feat: support building for macos

Marking draft as this is a WIP, would like to test debugging and other items first but am struggling to be able to build to macOS on my machine 🤷🏻
Closes #1129

@ewanharris I would actually take this for a base implementation already and then we could still iterate on it later. Would that be okay?

@hansemannn that sounds good to me, lemme check it out again later and get it merged

@hansemannn are you looking to use this? Want a release putting out?

I don't need it personally, but thought some users that have macOS apps could benefit from it :)


Updated DbUtils.java with insertRow() and deleteRow() methods

Added insertRow() and deleteRow() methods
Description
Thanks for contributing this Pull Request. Make sure that you submit this Pull Request against the develop branch of this repository, add a brief description, and tag the relevant issue(s) and PR(s) below.

Relevant Issues : (compulsory)
Relevant PRs : (optional)
Type of change :

[ ] New feature
[ ] Bug fix for existing feature
[ ] Code quality improvement
[x] Addition or Improvement of tests
[ ] Addition or Improvement of documentation

Added insertRow() and deleteRow() methods in Dbutils.java

@SandbhorSarjerao thanks but no thanks :| reasons here: https://stackoverflow.com/a/52078427/143475


Update: VoodooSoft.VoodooShield version 6.57

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

#19757

My PR passed but #19757 didn't. 🙂


Building failed under CentOS 7

libs/libdaemon/src/BaseDaemon.cpp uses BUS_MCEERR_AR and BUS_MCEERR_AO definitions.
They are provided by glibc-headers >= 2.20.
But CentOS 7 contains glibc 2.17.

Already fixed in master


Version Packages

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
<EMAIL_ADDRESS>Patch Changes

Updated dependencies [27a70551c]:

<EMAIL_ADDRESS>

<EMAIL_ADDRESS>Patch Changes

Disable chunking for @clerk/clerk-js/headless to ensure the library doesn't attempt to dynamically load chunks in a non-browser environment. (#1654) by @BRKalow

<EMAIL_ADDRESS>Patch Changes

Updated dependencies [27a70551c]:

<EMAIL_ADDRESS>

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


Feature Request for resize method of video preview

Thanks for this great library. Never thought, that it would be possible to do such an complex task with Javascript!
I try to include QuaggaJS into an online book database. For the mobile version (responsive design) I need a way to resize the video preview. It would be great, if You could include a method into QuaggaJS to do this.

What exactly are you looking for? I was in the believe that all of this could easily be handled by CSS only. What's missing?

In my case the video preview should be resized on window resizing/changing portrait to landscape mode. I didn't find out how to do this by changing css settings with javascript. It works for the video element, but the overlaying canvas element with the barcode boundary gets "out of sync" .

Example: https://buch.archinform.net/service/scan.mobi.htm
Video preview should be resized on init/page resize/portrait-to-landscape-switch events to full screen width. How can I do this?

I need this feature too.
the ability to be responsive for the video capturing window.

Have a try using the screen orientation media queries following:

the Mozilla Developer Network screen orientation docs
making sure the canvas appears over the video

If you put the live example in JSBin I'll help troubleshoot.


Cherry pick - Chef - Add Chef CD builds for linux_arm64_ipv6only (#20468)

Problem

Missing cherry pick for Chef CD builds for RPi.

Change overview

2022-07-08  Chef - Add Chef CD builds for linux_arm64_ipv6only (#20468)

Testing

Tested in vscode container:
./chef.py --build_all

Example is here: https://github.com/project-chip/connectedhomeip/pull/20499

This seems to be #20468,

Please only check this into master, anything in the examples directory will automatically get cherry picked.

@woody-apple good to know! I added a PR to bring in the docker update changes (#20502). Is that PR still appropriate?

Should be ok because docker are prerequisite for platform changes (at least this is what I think).
That being said, that PR also had a 'examples' tag so should be auto-cherrypicked (but guessing maybe it was not?) so I merged it ... but am unclear why it was not auto-cp.


Different initialization of the AccessTokenLifetime property in response generators

I need to configure token lifetime in TokenService in some situations. Token has the correct lifetime, but the "expires_in" property in response is different because of the different initialization.

good AuthorizeResponseGenerator
not desirable TokenResponseGenerator

for the token code path - the lifetime can be changed dynamically in a custom validator. That's why it is read from the request.
The fact that this is inconsistent with the authorize path is something we have to look into in the future.

@leastprivilege thank you for useful information.


Add function sendwhatmsg_to_group_instantly

Adding functionality to send a message to a group instantly.

@bharathbrat seems good

@bharathbrat thanks for the valuable contribution. Did you ran pre-commit run --all-files before pushing the changes?

Definitely missed that step. I am a bit confused with what exactly lint was complaining about there. But it seems to have fixed something with pywhatkit/py.typed.

Thanks for the contribution!


[react-form] Application fails to build when using react-form package

Overview
Service fails to build after installing and using @shopify/react-form. The error message is as follows:
[client (latest)] Compile failed with errors
Error: webpack has removed these modules:
<EMAIL_ADDRESS>
• If a module is necessary for production, preserve it by adding it to package.json#sideEffects (for more information, see https://github.com/webpack/webpack/tree/master/examples/side-effects)
• If a module can be safely removed, add it to FailOnUnexpectedModuleShakingPlugin's 'exclude' list
    at /Users/ryan/src/github.com/Shopify/react-form-error-example/node_modules/@shopify/sewing-kit/dist/src/tools/webpack/index.js:116:23
    at Generator.next (<anonymous>)
    at fulfilled (/Users/ryan/src/github.com/Shopify/react-form-error-example/node_modules/@shopify/sewing-kit/dist/src/tools/webpack/index.js:24:58)

Screenshot

This unfortunately means that the package can't be used at the moment, without extra configuration to the service's webpack configuration.
Steps to reproduce

Clone this repo with dev clone react-form-error-example
dev up
yarn sewing-kit build

You should expect to see the same compile error message. This reproduction example is the baseline React/Rails app generated with dev init and then modified in a single commit to install the @shopify/react-form package and to use the example code provided in the README.
Consuming repo
I originally encountered this in https://github.com/shopify/services-db however I have setup a minimal reproducing case at https://github.com/Shopify/react-form-error-example/ , specifically in this commit

The error message states that this can be avoided by adding the reference to FailOnUnexpectedModuleShakingPlugin's exclude list, but that value is hardcoded by sewing-kit to an empty array.
For now, I'll try to work around this by declaring the file to have side effects.

Adding the file to the list of sideEffects also does not have the desired effect, I'll try downgrading to v0.10

Thanks for filing this issue. Before merging https://github.com/Shopify/quilt/pull/1698, I 🎩 'd various quilt packages in shrink-ray (https://github.com/Shopify/shrink-ray/pull/1718). Our sewing-kit tooling does consume esnext builds in packages as expected. I'm not entirely sure what's up with react-form though.
FailOnUnexpectedModuleShakingPlugin's takes and exclude option which you can configure in your projects sewing-kit config. Here's a changeset which I used when testing in shrink-ray, I was able to fix it with that. That should work with services-db as well.
Webpack tries to help improve performance by removing code it thinks it doesn't need. IIRC, in the past we've had prod issues were it has removed modules we actually needed. FailOnUnexpectedModuleShakingPlugin's was born out of these issues. I've seen some apps across the org leverage FailOnUnexpectedModuleShakingPlugin.options.exclude to exclude certain @shopify/polaris component bundle. We may have to do the same with @react-form.
cc/ @TheMallen, anything come to mind in react-form that could be causing this?

I also ran some shrink-ray tests with<EMAIL_ADDRESS>vs the latest release with esbuild support. The production builds are behaving as expected. 🤔
<EMAIL_ADDRESS>The production build is consuming the entire react-form package yielding a ~6KB vendor bundle for the page I included react-form in.

GitHub check
Detailed shrink-ray report

<EMAIL_ADDRESS>(Latest)
When consuming the esnext build, webpack can treeshake the 3rd party module better, yeilding a ~3KB vendor bundle for that page.

GitHub check
Detailed shrink-ray report

Thanks for the detailed write-up @ismail-syed! For the moment, I've downgraded to v0.10 which successfully resolved the issue. Given the tradeoff between the additional package size versus the changeset to add FailOnUnexpectedModuleShakingPlugin we'd probably choose the former (our emphasis right now is more on code/config simplicity than bytes-over-the-wire).
Is there anything else I can help provide to dig into this further? It seems to me that perhaps index.esnext being dropped as a module is a reasonable expectation for this module since it is just re-exporting all values. Is Webpack perhaps smart enough to drop it and just resolve those re-exported values instead?

The plugin is just plain wrong here, and it should be removed from sewing-kit.  It used to be useful for flagging global CSS imports being silently dropped from production bundles, but it's providing negative value now.

Same issue on SpyV2 with this change, I'm not tracking the conversation here, so I'm not sure if there is a fix yet.

Same issue on SpyV2 with this change, I'm not tracking the conversation here, so I'm not sure if there is a fix yet.

@DougEdey, you can apply this changes to resolve the issue.

@DougEdey, you can apply this changes to resolve the issue.

Just ran into an issue with react-network as well when upgrading from 3.5.8 to 3.6.0. It seems that the only material change between the two was the switch to the build system, but our app now fails when installing 3.6.0 (we reverted)
We began getting this error in the console, despite setting up the NetworkProvider context provider

Just ran into an issue with react-network as well when upgrading from 3.5.8 to 3.6.0. It seems that the only material change between the two was the switch to the build system, but our app now fails when installing 3.6.0 (we reverted)
We began getting this error in the console, despite setting up the NetworkProvider context provider

@ryanwilsonperkin, @dirceu We were able to upgrade to<EMAIL_ADDRESS>without any issues. What you experienced with react-network is different from this issue description regarding react-form.
I took a look at https://github.com/Shopify/services-db/pull/6702. If you look at the yarn.lock, that PR is introducing duplicate dependencies for some packages (eg. @shopify/react-html). I suspect that was the issue. Duplicate dependencies of various quilt packages will cause SSR issues because it leads to duplicate React contexts across libraries which get mucked up during an SSR. You can dedupe these packages running npx yarn-deduplicate --scopes @shopify yarn.lock. This could have also happened with react-i18n.

@ryanwilsonperkin, @dirceu We were able to upgrade to<EMAIL_ADDRESS>without any issues. What you experienced with react-network is different from this issue description regarding react-form.
I took a look at https://github.com/Shopify/services-db/pull/6702. If you look at the yarn.lock, that PR is introducing duplicate dependencies for some packages (eg. @shopify/react-html). I suspect that was the issue. Duplicate dependencies of various quilt packages will cause SSR issues because it leads to duplicate React contexts across libraries which get mucked up during an SSR. You can dedupe these packages running npx yarn-deduplicate --scopes @shopify yarn.lock. This could have also happened with react-i18n.

Thanks @ismail-syed ! Will try that dep upgrade again now

Thanks @ismail-syed ! Will try that dep upgrade again now

Thanks @ismail-syed fixed with 8c6539f (#655)

Thanks @ismail-syed fixed with 8c6539f (#655)

We've done a similar fix now in https://github.com/Shopify/services-db/pull/6697 to allow us to get to the latest version of react-form and react-graphql. I'd like to keep this issue open though if that's alright with those involved because I think a full resolution for this would probably require one of the following:

Change to the bundling format of Quilt packages to fix these index files (if there's an issue with them)
Change to sewing-kit's webpack config to prevent this plugin from flagging index files (if there isn't an issue with them)
Change to the sewing-kit/quilt generator so that new apps automatically get these overrides in sewing-kit.config.ts

Sound good?

We've done a similar fix now in https://github.com/Shopify/services-db/pull/6697 to allow us to get to the latest version of react-form and react-graphql. I'd like to keep this issue open though if that's alright with those involved because I think a full resolution for this would probably require one of the following:

Change to the bundling format of Quilt packages to fix these index files (if there's an issue with them)
Change to sewing-kit's webpack config to prevent this plugin from flagging index files (if there isn't an issue with them)
Change to the sewing-kit/quilt generator so that new apps automatically get these overrides in sewing-kit.config.ts

Sound good?

Is there any update on a fix for this?


Issue5048 Start a Wikimedia Commons upload project with just a folder…

Fixes #5048
Changes proposed in this pull request:

UI - Added option in create project flow to specify a directory
Files from the specified directory are read and a CSV file is created with details -fileName, fileSize(KB), fileExtension, lastModifiedTime, creationTime, author, filePath

Doing this server side looks rather dangerous and would break all compatibility with remote hosts(including Wikimedias PAWS). You can however, do the same client side using the File System API.

I don't see it like that. OpenRefine is currently designed to run locally, so I don't think we can qualify this of of "breaking all compatibility", since it's not a use case we have ever claimed to support. In the case of PAWS and uploading files to Commons, doing the file listing in the browser would actually make this new feature useless for PAWS users, because the actual file uploading to Commons interprets the file paths in the backend-side. The current way to use PAWS for a Commons upload is indeed to upload the files to the PAWS workspace first, so that's where they need to be listed.
So, funnily enough, if we want to help PAWS users here, I think we need to keep listing files in the backend as this PR does. Unless we redesign the Commons support in the Wikibase extension to fetch files to upload via the browser, but that sounds like a rather complicated move and it's not clear to me the UX would be improved.

Doing this server side looks rather dangerous and would break all compatibility with remote hosts(including Wikimedias PAWS). You can however, do the same client side using the File System API.

I don't see it like that. OpenRefine is currently designed to run locally, so I don't think we can qualify this of of "breaking all compatibility", since it's not a use case we have ever claimed to support. In the case of PAWS and uploading files to Commons, doing the file listing in the browser would actually make this new feature useless for PAWS users, because the actual file uploading to Commons interprets the file paths in the backend-side. The current way to use PAWS for a Commons upload is indeed to upload the files to the PAWS workspace first, so that's where they need to be listed.
So, funnily enough, if we want to help PAWS users here, I think we need to keep listing files in the backend as this PR does. Unless we redesign the Commons support in the Wikibase extension to fetch files to upload via the browser, but that sounds like a rather complicated move and it's not clear to me the UX would be improved.

My point is not about the usefulness of the functionality, it's about exposing the remote file system.  If we want to do this server-side(as you say there is a use case) let's put in an extension(just like with Jython).

Note: I am also supportive of designing this feature so that it can be useful beyond the Commons import use case. Perhaps there are use cases for which listing the files from the browser would be better, but at the moment I can't think of any.

Native file picking/accessibility and support for remote hosts? Support for containerized distributions(docker, snap, flatpak, etc)?

When I wrote "use cases", I was more thinking about user stories. In which context would you use this feature apart from Commons uploads? Meaning: what sort of data are you dealing with, what do you want to do with this data, what do you want to export it to, and so on. I think it's generally worth stepping back and looking at the whole user journey, as the case of PAWS shows.

Mostly preparation of other types of uploads, plenty of upload tools have two steps with files+tabular metadata. So I imagine that most would use it to bootstrap such metadata files. Kinda like a combination of ls + printf (but way easier for most users).

@wetneb @Abbe98 Here is a suggestion to support file listing feature with ability to add support for more sources going forward. As in the database connection, provide a set of sources from which file list can be obtained.

@wetneb @Abbe98 Here is a suggestion to support file listing feature with ability to add support for more sources going forward. As in the database connection, provide a set of sources from which file list can be obtained. Mockup - made using image editor

I would suggest that you go with a regular select element(or something similar) inside the panel to pick a source. The existing pattern with nested sidebars is not the best as each time a sidebar is opened/closed the content will "jump" to to either side.

@wetneb @Abbe98  Updated the file list generation flow; for showcase purpose i added options of Google Drive, Flickr. Let me know if the flow is as expected. This now gives the ability to add support to get file list from multiple sources.
https://github.com/user-attachments/assets/0eaa7260-1dc6-4daa-937c-7bd385541f7c

I would like propose to step back a bit. I am a bit worried that if we already get on to UI details and enlarging the scope of this effort to other file sources, it might result in a lot of work from @sunilnatraj which could then be blocked by higher-level considerations, don't you think? It seems to me that we currently don't have an agreement on rather important points:

Where should this feature be implemented? It could be in this repository, in the Commons extension, or in another extension. It's a question on which it would be worth hearing opinions from more people, I think.
Should file listing be done on front-end side or back-end side. It's something worth getting an agreement early on since the implementation will be very different depending on the answer.

Perhaps those things are worth discussing in #5048 ? I think this PR is a great way to show what it could look like and prompt us to identify design questions. Sorry about that @sunilnatraj, I probably should have flagged that earlier.

@sunilnatraj : I have a suggestion for you: would you be willing to implement that in a totally new extention, let’s call it here the File Extension? I think what you did is great, and that the discussion in the community will be more of a break than helping you code. I’m not saying to not listen to the proposition of the community, but rather that it will give you more flexibility to develop a working product, while letting the community contribute at their own pace, while not stoping you.
I would be very happy to test your extension. And this extension could be useful not only for WikiCommons, but also as a standalone.
Features suggestions:

[ ] Add an option to import the text of each file in a new column
[ ] It would be great to have BOTH server side import (from a path of a folder on the server) and import thru multiple folder or file download (for PAWS).
[ ] Have a column with a checksum, like MD5, SHA, SHA256m etc…
[ ] Have a column with permissions (RWX etc) on the server side import

Thank you very much for this contribution, it’s awesome!
Regards, Antoine

Closing this PR as the decision is to provide this support in an extension


Is next/link really a higher order component?

I'm currently going through learnnextjs.com. This page says the following:

Link is Just a Higher Order Component (HOC)
Actually, the style prop on next/link has no effect. That's because next/link is just a higher order component which only accepts the "href" and some similar props. If you need to style it, you need to do it to the underlying component.

This confused me because next/link isn't used like a higher order component, it's used like a component that can wrap children. The linked documentation page has the actual definition of higher order component:

Concretely, a higher-order component is a function that takes a component and returns a new component.

That page also says:

An HOC is a pure function with zero side-effects.

and

Don't Use HOCs Inside the render Method.

So you don't directly use HOCs in JSX, and they don't directly accept props because they are just functions which return components. I don't see any references on that page to the style of component that next/link is. The terminology is important here because the idea behind higher order components is that they can be functionally composed. This isn't true for next/link. Concretely, the following does not work:
import { compose, pure } from 'recompose';
import Link from 'next/link';

compose(
  pure,
  Link,
)(() => About);

You will actually see an error: Cannot call a class as a function.
Am I wrong? My understanding is that Higher Order Components are named after Higher Order Functions. If next/link were actually a higher order component I'd expect it to expose an API like such:
link({ href: '/about' })(() => About);

That will work with functional composition and also has a functional interface for supply the href "prop."
Anyway, that's just a really roundabout way of saying that I believe next/link is just a component, and not a higher order component.

You are correct.
I've change the wording.
See: https://learnnextjs.com/basics/navigate-between-pages/wrapper-component


Setup project & dev environment

Initialize the project with the following setup:

gitignore(s)
docker compose
spring-boot folder structure
empty database

in spring boot maven project set up:

openapi auto gen
prod, local, and dev .properties file(s)
health check

also include .pre-commit-config.yaml


WIP: Add even-odd block sort for dataframes

This PR implements #958. It uses a block-wise even-odd sort. Currently, only DataFrame.sort_values is implemented. I'd prefer to gauge interest first, before implementing Series.sort_values (which should take minimal effort).
The sort is performed in approximately npartitions iterations. For each iteration, two neighboring partitions are merged, sorted and split again. To transfer information, the neighborhoods are shifted for each iteration. Within each partition the pandas standard, i.e., quicksort, is used.

I'm curious if we can reuse the existing logic around shuffling and setting the index.

TBH, I didn't look at existing functionality, but copied the code verbatim from a project of mine where I needed sort_values. Since I spent hardly any time on this PR, I'm perfectly fine with closing it, if you feel this implementation introduces too much code duplication.

I think that having a sort_values method is valuable, so I'd like to see this work continue.  However I do suspect that the implementation currently in dataframe/shuffle.py is worth looking at.  I suspect that it can be faster in some situations.

You were right, it's quite simple to use set_index to implement sort_values. However, dataframes with one column appearing much more frequently than others are problematic. Sorting them will create hugely unbalanced partitions:
>>> df = pd.DataFrame({'val': [0] * 100})
>>> ddf = dd.from_pandas(df, npartitions=10)
>>> len(set_index(degenerate_ddf, 'val').reset_index().get_partition(9).compute())
100

For this reason, I made the set_index based implementation optional and kept my original one. If you'd like I can also remove the alternative implementation all-together.

It may be that we can use some of the logic behind set_index without actually using set_index.  My concern about the even-odd sorting technique is that it might involve sending many copies of the data around the network.  Is this assumption correct?  If not then can you provide a brief explanation of the costs of this algorithm?
The approach taken in set_index or shuffle.py generally might be worth looking into

For example maybe we shouldn't do even/odd but should break things up into groups of four or eight or some other number.  Maybe it makes sense to re-partition data beforehand to reduce the number of copies.  Etc.  These sorts of problems and more have been handled in the code in shuffle.py.  It would be nice to have solutions to these problems in sort_values as well and it would be nice not to have two copies of the same code lying about.
Thoughts on how to merge these approaches?

Hm. Maybe it's best to let somebody else pickup that thread. Since I don't have access to machines to test on, I can only speculate about performance. That makes it really hard to adapt the implementation.


官方安装脚本检查更新时比较版本的逻辑需要纠正

What version of V2Ray are you using (If you deploy different version on server and client, please explicitly point out)?
v4.22.1

What's your scenario of using V2Ray? E.g., Watching YouTube videos in Chrome via Socks/VMess proxy.
从源代码构建了最新的 v2ray 版本，考虑到服务器上有官方的安装脚本每周运行一次检查更新，就传递参数 --check 看是不是真的会出现官方发布的相对较旧版本覆盖编译安装的新版本的现象。

What did you see? (Please describe in detail, such as timeout, fake TLS certificate etc)
安装脚本确实判断从源代码构建的包比官方发布的版本旧。

What's your expectation?
安装脚本能正确判断版本大小，不要主动覆盖旧版本回来。

~/go/src/v2ray.com/core# release/install-release.sh --local /tmp/make_v2ray_release/v2ray-custom-amd64-linux-20200316-064218.zip
Installing V2Ray via local file. Please make sure the file is a valid V2Ray package, as we are not able to determine that.
Shutting down V2Ray service.
Archive:  /tmp/make_v2ray_release/v2ray-custom-amd64-linux-20200316-064218.zip
  inflating: /usr/bin/v2ray/geoip.dat
  inflating: /usr/bin/v2ray/v2ctl
  inflating: /usr/bin/v2ray/v2ray
  inflating: /usr/bin/v2ray/geosite.dat
Restarting V2Ray service.
V2Ray local is installed.

~/go/src/v2ray.com/core# bash <(curl -L -s https://install.direct/go.sh) --check
Checking for update.
Found new version v4.22.1 for V2Ray.(Current version:v4.22.2-48-g16288788)

值得注意的是，按照现在 GitHub 存储库上的 user-package.sh 代码，实际创建的版本号值是 v4.22.1-48-g16288788
我是已经考虑到小版本号相等可能会害脚本无法正确判断版本号大小，人为对 user-package.sh 构建脚本做过了调整，但是还是遇到了这个问题。

简单来说，对现在的安装脚本来说，版本 v4.22.1 是大于 v4.22.2-48-g16288788 的。
这不合理，希望抽空纠正。

~/go/src/v2ray.com/core# bash <(curl -L -s https://install.direct/go.sh) --check
Checking for update.
Found new version v4.22.1 for V2Ray.(Current version:v4.22.2)

……
所以问题不在后缀上，晚点有心情了把相关代码找出来看看吧，太不合理了。

1: new V2Ray. 0: no. 2: not installed. 3: check failed. 4: don't check.
getVersion(){
if [[ -n "$VERSION" ]]; then
NEW_VER="$(normalizeVersion "$VERSION")"
return 4
else
VER="$(/usr/bin/v2ray/v2ray -version 2>/dev/null)"
RETVAL=$?
CUR_VER="$(normalizeVersion "$(echo "$VER" | head -n 1 | cut -d " " -f2)")"
TAG_URL="https://api.github.com/repos/v2ray/v2ray-core/releases/latest"
NEW_VER="$(normalizeVersion "$(curl ${PROXY} -s "${TAG_URL}" --connect-timeout 10| grep 'tag_name' | cut -d" -f4)")"
    if [[ $? -ne 0 ]] || [[ $NEW_VER == "" ]]; then
        colorEcho ${RED} "Failed to fetch release information. Please check your network or try again."
        return 3
    elif [[ $RETVAL -ne 0 ]];then
        return 2
    **elif [[ $NEW_VER != $CUR_VER ]];then**
        return 1
    fi

……我没话讲

將目前腳本的 266 行修改為：
IF_VER="$(echo "$NEW_VER $CUR_VER " | awk '{ if ( $1 > $2 ) print $1; else print $2 }')"
if [[ $IF_VER == $NEW_VER ]]; then
    return 1
fi

如何？

將目前腳本的 266 行修改為：
IF_VER="$(echo "$NEW_VER $CUR_VER" | awk '{ if ( $1 > $2 ) print $1; else print $2 }')"
if [[ $IF_VER == $NEW_VER ]]; then
    return 1
fi

如何？

這個解決思路不是很直觀，但確實應該可以 work，而且不至於在其他沒有想到的地方引起破壞，我覺得很好！
這是你的 idea，請提交你的 PR。我不該搶你的貢獻 XDD

將目前腳本的 266 行修改為：
IF_VER="$(echo "$NEW_VER $CUR_VER" | awk '{ if ( $1 > $2 ) print $1; else print $2 }')"
if [[ $IF_VER == $NEW_VER ]]; then
    return 1
fi

如何？

這個解決思路不是很直觀，但確實應該可以 work，而且不至於在其他沒有想到的地方引起破壞，我覺得很好！
這是你的 idea，請提交你的 PR。我不該搶你的貢獻 XDD

今天再次測試了一下，發現並不精確，所以又重寫了一段：
NEW_VERSIONSION_NUMBER="${NEW_VERSION#v}"
NEW_MAJOR_VERSION_NUMBER="${NEW_VERSIONSION_NUMBER%%.*}"
NEW_MINOR_VERSION_NUMBER="$(echo $NEW_VERSIONSION_NUMBER | awk -F '.' '{print $2}')"
NEW_MINIMUM_VERSION_NUMBER="${NEW_VERSIONSION_NUMBER##*.}"
CURRENT_VERSIONSION_NUMBER="$(echo ${CURRENT_VERSION#v} | sed 's/-.*//')"
CURRENT_MAJOR_VERSION_NUMBER="${CURRENT_VERSIONSION_NUMBER%%.*}"
CURRENT_MINOR_VERSION_NUMBER="$(echo $CURRENT_VERSIONSION_NUMBER | awk -F '.' '{print $2}')"
CURRENT_MINIMUM_VERSION_NUMBER="${CURRENT_VERSIONSION_NUMBER##*.}"
if [[ "$NEW_MAJOR_VERSION_NUMBER" -gt "$CURRENT_MAJOR_VERSION_NUMBER" ]]; then
    return 1
elif [[ "$NEW_MAJOR_VERSION_NUMBER" -eq "$CURRENT_MAJOR_VERSION_NUMBER" ]]; then
    if [[ "$NEW_MINOR_VERSION_NUMBER" -gt "$CURRENT_MINOR_VERSION_NUMBER" ]]; then
        return 1
    elif [[ "$NEW_MINOR_VERSION_NUMBER" -eq "$CURRENT_MINOR_VERSION_NUMBER" ]]; then
        if [[ "$NEW_MINIMUM_VERSION_NUMBER" -gt "$CURRENT_MINIMUM_VERSION_NUMBER" ]]; then
            return 1
        fi
    fi
fi

至於 PR 就不著急了，最近正在嘗試大改官方腳本。

這上面用了兩個非常有意思的 SHELL 語法，學習了。
看了你説的，我重新設計了一個刁鑽一點的場景（NEW_VER=4.9.25；CUR_VER=4.10.1），發現果然最初的脚本返回結果是不正確的！
這裏我有一個建議，不要用 NEW_***_VERSION 這樣的變量名。因爲這個變量名可能會引起誤會——實際上它是遠端 GitHub releases 頁發佈出來的版本，不一定比本地拿來做比較的程式版本「新」，所以不妨用 github 或是 remote 這樣的前綴。
另外個人的看法是 SHELL 裏面變量名不要用大寫，因爲要是起的變量名太簡短，是真的可能會和作業系統裏的環境變量重名的哦。這樣執行完脚本后會修改作業系統内的環境變量，是非常危險的行爲。
建議變量名就用小寫就好。

這上面用了兩個非常有意思的 SHELL 語法，學習了。
看了你説的，我重新設計了一個刁鑽一點的場景（NEW_VER=4.9.25；CUR_VER=4.10.1），發現果然最初的脚本返回結果是不正確的！
@dctxmei
這裏我有一個建議，不要用 NEW_***_VERSION 這樣的變量名。因爲這個變量名可能會引起誤會——實際上它是遠端 GitHub releases 頁發佈出來的版本，不一定比本地拿來做比較的程式版本「新」，所以不妨用 github 或是 remote 這樣的前綴。
另外個人的看法是 SHELL 裏面變量名不要用大寫，因爲要是起的變量名太簡短，是真的可能會和作業系統裏的環境變量重名的哦。這樣執行完脚本后會修改作業系統内的環境變量，是非常危險的行爲。
建議變量名就用小寫就好。

多謝提供建議，已修正。
不過，像是 VERSION= 這樣的寫法，僅僅屬於「Global variable」，也就是「全局變量」，這種變量僅僅是應用於當前 Shell 進程的內部，在結束當前進程後就會被丟掉，而不會影響到作業系統內的環境變量。
另外，如果對 OpenBSD 和腳本感興趣的話，可以來嘗試一下：
https://github.com/v2fly/openbsd-install-v2ray
:)

不過，像是 VERSION= 這樣的寫法，僅僅屬於「Global variable」，也就是「全局變量」，這種變量僅僅是應用於當前 Shell 進程的內部，在結束當前進程後就會被丟掉，而不會影響到作業系統內的環境變量。

你説的對，我有點多慮了。

最新的脚本 bash <(curl -L -s https://install.direct/go.sh)  在debian 7 32位安装出错：
root@urpised:~# bash <(curl -L -s https://install.direct/go.sh)
Installing V2Ray vhttps://api.github.com/repos/v2ray/v2ray-core/releases/22545481 on i686
Downloading V2Ray: https://github.com/v2ray/v2ray-core/releases/download/vhttps://api.github.com/repos/v2ray/v2ray-core/releases/22545481/v2ray-linux-32.zip
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100     9  100     9    0     0     28      0 --:--:-- --:--:-- --:--:--    33
/dev/fd/63: line 144: unzip: command not found
awk: not an option: -e
Updating software repo
Installing unzip
Selecting previously unselected package unzip.
(Reading database ... 20652 files and directories currently installed.)
Unpacking unzip (from .../unzip_6.0-8+deb7u5_i386.deb) ...
Processing triggers for man-db ...
Setting up unzip (6.0-8+deb7u5) ...
Archive:  /tmp/v2ray/v2ray.zip
  End-of-central-directory signature not found.  Either this file is not
  a zipfile, or it constitutes one disk of a multi-part archive.  In the
  latter case the central directory and zipfile comment will be found on
  the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /tmp/v2ray/v2ray.zip or
        /tmp/v2ray/v2ray.zip.zip, and cannot find /tmp/v2ray/v2ray.zip.ZIP, period.
Failed to copy V2Ray binary and resources.

最新的脚本 bash <(curl -L -s https://install.direct/go.sh) 在debian 7 32位安装出错：
root@urpised:~# bash <(curl -L -s https://install.direct/go.sh)
Installing V2Ray vhttps://api.github.com/repos/v2ray/v2ray-core/releases/22545481 on i686
Downloading V2Ray: https://github.com/v2ray/v2ray-core/releases/download/vhttps://api.github.com/repos/v2ray/v2ray-core/releases/22545481/v2ray-linux-32.zip
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100     9  100     9    0     0     28      0 --:--:-- --:--:-- --:--:--    33
/dev/fd/63: line 144: unzip: command not found
awk: not an option: -e
Updating software repo
Installing unzip
Selecting previously unselected package unzip.
(Reading database ... 20652 files and directories currently installed.)
Unpacking unzip (from .../unzip_6.0-8+deb7u5_i386.deb) ...
Processing triggers for man-db ...
Setting up unzip (6.0-8+deb7u5) ...
Archive:  /tmp/v2ray/v2ray.zip
  End-of-central-directory signature not found.  Either this file is not
  a zipfile, or it constitutes one disk of a multi-part archive.  In the
  latter case the central directory and zipfile comment will be found on
  the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /tmp/v2ray/v2ray.zip or
        /tmp/v2ray/v2ray.zip.zip, and cannot find /tmp/v2ray/v2ray.zip.ZIP, period.
Failed to copy V2Ray binary and resources.

使用https://raw.githubusercontent.com/v2ray/v2ray-core/572abd73a057697e597ea8ddfcf62028bc75585c/release/install-release.sh 版本成功安装...

請盡量不要使用已經被發行版官方停止支援的版本，目前最新的 Debian Stable 是 10（Buster）：
https://wiki.debian.org/DebianStable
腳本則可以嘗試使用新版的參考項目，參見 https://github.com/v2ray/v2ray-core/issues/2328 。

最新的脚本 bash <(curl -L -s https://install.direct/go.sh) 在debian 7 32位安装出错：
root@urpised:~# bash <(curl -L -s https://install.direct/go.sh)
Installing V2Ray vhttps://api.github.com/repos/v2ray/v2ray-core/releases/22545481 on i686
Downloading V2Ray: https://github.com/v2ray/v2ray-core/releases/download/vhttps://api.github.com/repos/v2ray/v2ray-core/releases/22545481/v2ray-linux-32.zip
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100     9  100     9    0     0     28      0 --:--:-- --:--:-- --:--:--    33
/dev/fd/63: line 144: unzip: command not found
awk: not an option: -e
Updating software repo
Installing unzip
Selecting previously unselected package unzip.
(Reading database ... 20652 files and directories currently installed.)
Unpacking unzip (from .../unzip_6.0-8+deb7u5_i386.deb) ...
Processing triggers for man-db ...
Setting up unzip (6.0-8+deb7u5) ...
Archive:  /tmp/v2ray/v2ray.zip
  End-of-central-directory signature not found.  Either this file is not
  a zipfile, or it constitutes one disk of a multi-part archive.  In the
  latter case the central directory and zipfile comment will be found on
  the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /tmp/v2ray/v2ray.zip or
        /tmp/v2ray/v2ray.zip.zip, and cannot find /tmp/v2ray/v2ray.zip.ZIP, period.
Failed to copy V2Ray binary and resources.

使用https://raw.githubusercontent.com/v2ray/v2ray-core/572abd73a057697e597ea8ddfcf62028bc75585c/release/install-release.sh 版本成功安装...

請盡量不要使用已經被發行版官方停止支援的版本，目前最新的 Debian Stable 是 10（Buster）：
https://wiki.debian.org/DebianStable
腳本則可以嘗試使用新版的參考項目，參見 #2328 。

此问题我在Debian9 Debian10 Debian bullseye 都有遇到，而且是概率发生，连续执行脚本更新命令，有时可以正确判断是否更新，有时出现此错误。

试试最新的

最新的脚本 bash <(curl -L -s https://install.direct/go.sh) 在debian 7 32位安装出错：
root@urpised:~# bash <(curl -L -s https://install.direct/go.sh)
Installing V2Ray vhttps://api.github.com/repos/v2ray/v2ray-core/releases/22545481 on i686
Downloading V2Ray: https://github.com/v2ray/v2ray-core/releases/download/vhttps://api.github.com/repos/v2ray/v2ray-core/releases/22545481/v2ray-linux-32.zip
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100     9  100     9    0     0     28      0 --:--:-- --:--:-- --:--:--    33
/dev/fd/63: line 144: unzip: command not found
awk: not an option: -e
Updating software repo
Installing unzip
Selecting previously unselected package unzip.
(Reading database ... 20652 files and directories currently installed.)
Unpacking unzip (from .../unzip_6.0-8+deb7u5_i386.deb) ...
Processing triggers for man-db ...
Setting up unzip (6.0-8+deb7u5) ...
Archive:  /tmp/v2ray/v2ray.zip
  End-of-central-directory signature not found.  Either this file is not
  a zipfile, or it constitutes one disk of a multi-part archive.  In the
  latter case the central directory and zipfile comment will be found on
  the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /tmp/v2ray/v2ray.zip or
        /tmp/v2ray/v2ray.zip.zip, and cannot find /tmp/v2ray/v2ray.zip.ZIP, period.
Failed to copy V2Ray binary and resources.

使用https://raw.githubusercontent.com/v2ray/v2ray-core/572abd73a057697e597ea8ddfcf62028bc75585c/release/install-release.sh 版本成功安装...

請盡量不要使用已經被發行版官方停止支援的版本，目前最新的 Debian Stable 是 10（Buster）：
https://wiki.debian.org/DebianStable
腳本則可以嘗試使用新版的參考項目，參見 #2328 。

此问题我在Debian9 Debian10 Debian bullseye 都有遇到，而且是概率发生，连续执行脚本更新命令，有时可以正确判断是否更新，有时出现此错误。

的确，我在debian9下出现这个错误后按照你说的重试了几次，又成功安装了。

重试了几次？你把logs贴出来

重试了几次？你把logs贴出来

root@PR888D:~# bash <(curl -L -s https://install.direct/go.sh)
Installing V2Ray vhttps://api.github.com/repos/v2ray/v2ray-core/releases/24822244 on x86_64
Downloading V2Ray: https://github.com/v2ray/v2ray-core/releases/download/vhttps://api.github.com/repos/v2ray/v2ray-core/releases/24822244/v2ray-linux-64.zip
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100     9  100     9    0     0     37      0 --:--:-- --:--:-- --:--:--    37
awk: not an option: -e
[/tmp/v2ray/v2ray.zip]
End-of-central-directory signature not found.  Either this file is not
a zipfile, or it constitutes one disk of a multi-part archive.  In the
latter case the central directory and zipfile comment will be found on
the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /tmp/v2ray/v2ray.zip or
/tmp/v2ray/v2ray.zip.zip, and cannot find /tmp/v2ray/v2ray.zip.ZIP, period.
Archive:  /tmp/v2ray/v2ray.zip
End-of-central-directory signature not found.  Either this file is not
a zipfile, or it constitutes one disk of a multi-part archive.  In the
latter case the central directory and zipfile comment will be found on
the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /tmp/v2ray/v2ray.zip or
/tmp/v2ray/v2ray.zip.zip, and cannot find /tmp/v2ray/v2ray.zip.ZIP, period.
Failed to copy V2Ray binary and resources.
root@PR888D:~# bash <(curl -L -s https://install.direct/go.sh)
Installing V2Ray vhttps://api.github.com/repos/v2ray/v2ray-core/releases/24822244 on x86_64
Downloading V2Ray: https://github.com/v2ray/v2ray-core/releases/download/vhttps://api.github.com/repos/v2ray/v2ray-core/releases/24822244/v2ray-linux-64.zip
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100     9  100     9    0     0     81      0 --:--:-- --:--:-- --:--:--    82
awk: not an option: -e
[/tmp/v2ray/v2ray.zip]
End-of-central-directory signature not found.  Either this file is not
a zipfile, or it constitutes one disk of a multi-part archive.  In the
latter case the central directory and zipfile comment will be found on
the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /tmp/v2ray/v2ray.zip or
/tmp/v2ray/v2ray.zip.zip, and cannot find /tmp/v2ray/v2ray.zip.ZIP, period.
Archive:  /tmp/v2ray/v2ray.zip
End-of-central-directory signature not found.  Either this file is not
a zipfile, or it constitutes one disk of a multi-part archive.  In the
latter case the central directory and zipfile comment will be found on
the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /tmp/v2ray/v2ray.zip or
/tmp/v2ray/v2ray.zip.zip, and cannot find /tmp/v2ray/v2ray.zip.ZIP, period.
Failed to copy V2Ray binary and resources.
root@PR888D:~# bash <(curl -L -s https://install.direct/go.sh)
Latest version v4.23.1 is already installed.
root@PR888D:~# bash <(curl -L -s https://install.direct/go.sh)
Installing V2Ray vhttps://api.github.com/repos/v2ray/v2ray-core/releases/24822244 on x86_64
Downloading V2Ray: https://github.com/v2ray/v2ray-core/releases/download/vhttps://api.github.com/repos/v2ray/v2ray-core/releases/24822244/v2ray-linux-64.zip
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100     9  100     9    0     0     79      0 --:--:-- --:--:-- --:--:--    78
awk: [/tmp/v2ray/v2ray.zip]
not an option: -e
End-of-central-directory signature not found.  Either this file is not
a zipfile, or it constitutes one disk of a multi-part archive.  In the
latter case the central directory and zipfile comment will be found on
the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /tmp/v2ray/v2ray.zip or
/tmp/v2ray/v2ray.zip.zip, and cannot find /tmp/v2ray/v2ray.zip.ZIP, period.
Archive:  /tmp/v2ray/v2ray.zip
End-of-central-directory signature not found.  Either this file is not
a zipfile, or it constitutes one disk of a multi-part archive.  In the
latter case the central directory and zipfile comment will be found on
the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /tmp/v2ray/v2ray.zip or
/tmp/v2ray/v2ray.zip.zip, and cannot find /tmp/v2ray/v2ray.zip.ZIP, period.
Failed to copy V2Ray binary and resources.
root@PR888D:~# bash <(curl -L -s https://install.direct/go.sh)
Installing V2Ray vhttps://api.github.com/repos/v2ray/v2ray-core/releases/24822244 on x86_64
Downloading V2Ray: https://github.com/v2ray/v2ray-core/releases/download/vhttps://api.github.com/repos/v2ray/v2ray-core/releases/24822244/v2ray-linux-64.zip
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100     9  100     9    0     0     73      0 --:--:-- --:--:-- --:--:--    73
awk: not an option: -e
[/tmp/v2ray/v2ray.zip]
End-of-central-directory signature not found.  Either this file is not
a zipfile, or it constitutes one disk of a multi-part archive.  In the
latter case the central directory and zipfile comment will be found on
the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /tmp/v2ray/v2ray.zip or
/tmp/v2ray/v2ray.zip.zip, and cannot find /tmp/v2ray/v2ray.zip.ZIP, period.
Archive:  /tmp/v2ray/v2ray.zip
End-of-central-directory signature not found.  Either this file is not
a zipfile, or it constitutes one disk of a multi-part archive.  In the
latter case the central directory and zipfile comment will be found on
the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /tmp/v2ray/v2ray.zip or
/tmp/v2ray/v2ray.zip.zip, and cannot find /tmp/v2ray/v2ray.zip.ZIP, period.
Failed to copy V2Ray binary and resources.
root@PR888D:~# bash <(curl -L -s https://install.direct/go.sh)
Installing V2Ray vhttps://api.github.com/repos/v2ray/v2ray-core/releases/24822244 on x86_64
Downloading V2Ray: https://github.com/v2ray/v2ray-core/releases/download/vhttps://api.github.com/repos/v2ray/v2ray-core/releases/24822244/v2ray-linux-64.zip
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100     9  100     9    0     0     83      0 --:--:-- --:--:-- --:--:--    83
[/tmp/v2ray/v2ray.zip]
awk: not an option: -e
End-of-central-directory signature not found.  Either this file is not
a zipfile, or it constitutes one disk of a multi-part archive.  In the
latter case the central directory and zipfile comment will be found on
the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /tmp/v2ray/v2ray.zip or
/tmp/v2ray/v2ray.zip.zip, and cannot find /tmp/v2ray/v2ray.zip.ZIP, period.
Archive:  /tmp/v2ray/v2ray.zip
End-of-central-directory signature not found.  Either this file is not
a zipfile, or it constitutes one disk of a multi-part archive.  In the
latter case the central directory and zipfile comment will be found on
the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /tmp/v2ray/v2ray.zip or
/tmp/v2ray/v2ray.zip.zip, and cannot find /tmp/v2ray/v2ray.zip.ZIP, period.
Failed to copy V2Ray binary and resources.
root@PR888D:~# bash <(curl -L -s https://install.direct/go.sh)
Latest version v4.23.1 is already installed.
root@PR888D:~# bash <(curl -L -s https://install.direct/go.sh)
Installing V2Ray vhttps://api.github.com/repos/v2ray/v2ray-core/releases/24822244 on x86_64
Downloading V2Ray: https://github.com/v2ray/v2ray-core/releases/download/vhttps://api.github.com/repos/v2ray/v2ray-core/releases/24822244/v2ray-linux-64.zip
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100     9  100     9    0     0     78      0 --:--:-- --:--:-- --:--:--    78
awk: not an option: -e
[/tmp/v2ray/v2ray.zip]
End-of-central-directory signature not found.  Either this file is not
a zipfile, or it constitutes one disk of a multi-part archive.  In the
latter case the central directory and zipfile comment will be found on
the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /tmp/v2ray/v2ray.zip or
/tmp/v2ray/v2ray.zip.zip, and cannot find /tmp/v2ray/v2ray.zip.ZIP, period.
Archive:  /tmp/v2ray/v2ray.zip
End-of-central-directory signature not found.  Either this file is not
a zipfile, or it constitutes one disk of a multi-part archive.  In the
latter case the central directory and zipfile comment will be found on
the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /tmp/v2ray/v2ray.zip or
/tmp/v2ray/v2ray.zip.zip, and cannot find /tmp/v2ray/v2ray.zip.ZIP, period.
Failed to copy V2Ray binary and resources.
root@PR888D:~# bash <(curl -L -s https://install.direct/go.sh)
Latest version v4.23.1 is already installed.
root@PR888D:~# bash <(curl -L -s https://install.direct/go.sh)
Installing V2Ray vhttps://api.github.com/repos/v2ray/v2ray-core/releases/24822244 on x86_64
Downloading V2Ray: https://github.com/v2ray/v2ray-core/releases/download/vhttps://api.github.com/repos/v2ray/v2ray-core/releases/24822244/v2ray-linux-64.zip
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100     9  100     9    0     0     69      0 --:--:-- --:--:-- --:--:--    68
awk: not an option: -e
[/tmp/v2ray/v2ray.zip]
End-of-central-directory signature not found.  Either this file is not
a zipfile, or it constitutes one disk of a multi-part archive.  In the
latter case the central directory and zipfile comment will be found on
the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /tmp/v2ray/v2ray.zip or
/tmp/v2ray/v2ray.zip.zip, and cannot find /tmp/v2ray/v2ray.zip.ZIP, period.
Archive:  /tmp/v2ray/v2ray.zip
End-of-central-directory signature not found.  Either this file is not
a zipfile, or it constitutes one disk of a multi-part archive.  In the
latter case the central directory and zipfile comment will be found on
the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /tmp/v2ray/v2ray.zip or
/tmp/v2ray/v2ray.zip.zip, and cannot find /tmp/v2ray/v2ray.zip.ZIP, period.
Failed to copy V2Ray binary and resources.
root@PR888D:~# bash <(curl -L -s https://install.direct/go.sh)
Latest version v4.23.1 is already installed.
root@PR888D:~# bash <(curl -L -s https://install.direct/go.sh)
Latest version v4.23.1 is already installed.
root@PR888D:~# bash <(curl -L -s https://install.direct/go.sh)
Installing V2Ray vhttps://api.github.com/repos/v2ray/v2ray-core/releases/24822244 on x86_64
Downloading V2Ray: https://github.com/v2ray/v2ray-core/releases/download/vhttps://api.github.com/repos/v2ray/v2ray-core/releases/24822244/v2ray-linux-64.zip
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100     9  100     9    0     0     81      0 --:--:-- --:--:-- --:--:--    81
awk: not an option: -e
[/tmp/v2ray/v2ray.zip]
End-of-central-directory signature not found.  Either this file is not
a zipfile, or it constitutes one disk of a multi-part archive.  In the
latter case the central directory and zipfile comment will be found on
the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /tmp/v2ray/v2ray.zip or
/tmp/v2ray/v2ray.zip.zip, and cannot find /tmp/v2ray/v2ray.zip.ZIP, period.
Archive:  /tmp/v2ray/v2ray.zip
End-of-central-directory signature not found.  Either this file is not
a zipfile, or it constitutes one disk of a multi-part archive.  In the
latter case the central directory and zipfile comment will be found on
the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /tmp/v2ray/v2ray.zip or
/tmp/v2ray/v2ray.zip.zip, and cannot find /tmp/v2ray/v2ray.zip.ZIP, period.
Failed to copy V2Ray binary and resources.
root@PR888D:~# bash <(curl -L -s https://install.direct/go.sh)
Installing V2Ray vhttps://api.github.com/repos/v2ray/v2ray-core/releases/24822244 on x86_64
Downloading V2Ray: https://github.com/v2ray/v2ray-core/releases/download/vhttps://api.github.com/repos/v2ray/v2ray-core/releases/24822244/v2ray-linux-64.zip
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100     9  100     9    0     0     90      0 --:--:-- --:--:-- --:--:--    90
awk: [/tmp/v2ray/v2ray.zip]
not an option: -e
End-of-central-directory signature not found.  Either this file is not
a zipfile, or it constitutes one disk of a multi-part archive.  In the
latter case the central directory and zipfile comment will be found on
the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /tmp/v2ray/v2ray.zip or
/tmp/v2ray/v2ray.zip.zip, and cannot find /tmp/v2ray/v2ray.zip.ZIP, period.
Archive:  /tmp/v2ray/v2ray.zip
End-of-central-directory signature not found.  Either this file is not
a zipfile, or it constitutes one disk of a multi-part archive.  In the
latter case the central directory and zipfile comment will be found on
the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /tmp/v2ray/v2ray.zip or
/tmp/v2ray/v2ray.zip.zip, and cannot find /tmp/v2ray/v2ray.zip.ZIP, period.
Failed to copy V2Ray binary and resources.
root@PR888D:~# bash <(curl -L -s https://install.direct/go.sh)
Installing V2Ray vhttps://api.github.com/repos/v2ray/v2ray-core/releases/24822244 on x86_64
Downloading V2Ray: https://github.com/v2ray/v2ray-core/releases/download/vhttps://api.github.com/repos/v2ray/v2ray-core/releases/24822244/v2ray-linux-64.zip
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100     9  100     9    0     0     87      0 --:--:-- --:--:-- --:--:--    87
[/tmp/v2ray/v2ray.zip]
awk: not an option: -e
End-of-central-directory signature not found.  Either this file is not
a zipfile, or it constitutes one disk of a multi-part archive.  In the
latter case the central directory and zipfile comment will be found on
the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /tmp/v2ray/v2ray.zip or
/tmp/v2ray/v2ray.zip.zip, and cannot find /tmp/v2ray/v2ray.zip.ZIP, period.
Archive:  /tmp/v2ray/v2ray.zip
End-of-central-directory signature not found.  Either this file is not
a zipfile, or it constitutes one disk of a multi-part archive.  In the
latter case the central directory and zipfile comment will be found on
the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /tmp/v2ray/v2ray.zip or
/tmp/v2ray/v2ray.zip.zip, and cannot find /tmp/v2ray/v2ray.zip.ZIP, period.
Failed to copy V2Ray binary and resources.
root@PR888D:~#
这是刚刚试的15次，10次出现这个错误，5次成功。Debian10。

似乎是curl -s "https://api.github.com/repos/v2ray/v2ray-core/releases/latest" --connect-timeout 10| grep 'tag_name'出的问题，有时能准确找到的tag_name，有时返回的是所有内容，所以才会最后截取了第一行的https://api.github.com/repos/v2ray/v2ray-core/releases/24822244作为了新版本的值。

新的已经有人提出具体原因了，你说得对。#2373

似乎是curl -s "https://api.github.com/repos/v2ray/v2ray-core/releases/latest" --connect-timeout 10| grep 'tag_name'出的问题，有时能准确找到的tag_name，有时返回的是所有内容，所以才会最后截取了第一行的https://api.github.com/repos/v2ray/v2ray-core/releases/24822244作为了新版本的值。

fix #2374


Provide ability to override host address for ec2 metadata and task metadata service.

I'm looking at implementing a mock metadata service hosted within Docker for developers running applications within Docker containers on their local machines.  Currently we must provide the developer's IAM credentials with the required access for all applications they'd be running on their local machines. This then also means these applications have the full credentials that the developer has.
I'd like to use a mock metadata service to provide credentials to the application that are locked down to our test environment and be similar to credentials that would be used in production.
Expected Behavior
The SDK has a method for overriding the hostname/ip and port used to access EC2 metadata and ECS Task metadata.
Current Behavior
Currently the EC2 metadata service host address is hard-coded here https://github.com/aws/aws-sdk-net/blob/b50da18c15202f8135b8a66a95cd3ac695256220/sdk/src/Core/Amazon.Runtime/Credentials/_bcl%2Bcoreclr/InstanceProfileAWSCredentials.cs#L161  and the ECS task metadata address is hard-coded here https://github.com/aws/aws-sdk-net/blob/bbf86bf59fe348a388b8093db9b174858c69e760/sdk/src/Core/Amazon.Runtime/Credentials/ECSTaskCredentials.cs#L35
These addresses being hard-coded without a method for overriding them make it difficult to consume a mock metadata service such as https://github.com/NYTimes/mock-ec2-metadata or https://github.com/lyft/metadataproxy.  It is possible but it requires changes to host routing to achieve it.
Possible Solution

Allow the metadata server addresses to be overridden using an environment variable. (preferred)
Allow the metadata server addresses to be overridden within application code.

Context
I'd prefer to not have to make an application code change so overriding it with environment variables is preferred.  I also don't want to have to change the developer's computers routing tables or other network configuration settings to achieve this because it would need applied when purchasing new computers.

I'm working on this functionality in this branch https://github.com/jamiegs/aws-sdk-net/tree/OverrideMetadataHost.
I hope to have a Pull Request ready within the next day or so.


Support new netip package

See https://pkg.go.dev/net/netip, a much better implementation of IP addressing in Go. It's built on top of a "uint128" type (2 uint64s).
Update: maybe netip users can use https://github.com/gaissmai/bart instead... feel free to close

It's been hung up in #46 a while

Dupe


Installation without Vagrant

I would like to test api-umbrella without Vagrant but cannot find clear installation procedure.
Can anybody point me in the right direction?
Tnx.

There is a pull request open with a Dockerfile.


Update security-guide.md

Suggested update to clarify need to disable clipboard redirection

@TomHickling : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Heidilohr Could you review the proposed update to your article? Thanks!

The content has been moved or reconfigured since the pull request was opened. The pull request can't be merged in, so we'll need to close it. If the proposed update still needs to be added to the content, please submit it in a new pull request. Thanks.


[FLINK-4784] Unique MetricQueryService actor names

This PR makes the MetricQueryService actor name unique by appending the TaskManagers resource id. For the jobmanager nothing is appended.

I tested the change this morning, and its not working:
2016-10-20 11:08:28,216 WARN  org.apache.flink.runtime.metrics.MetricRegistry               - Could not start Metr
icDumpActor. No metrics will be submitted to the WebInterface.
akka.actor.InvalidActorNameException: illegal actor name [MetricQueryService_ResourceID{resourceId='e29f9e7d096c56
2054a1caa29be21a36'}], must conform to (?:[-\w:@&=+,.!~*'_;]|%\p{XDigit}{2})(?:[-\w:@&=+,.!~*'$_;]|%\p{XDigit}{2})
*
        at akka.actor.dungeon.Children$class.checkName(Children.scala:182)
        at akka.actor.dungeon.Children$class.attachChild(Children.scala:42)
        at akka.actor.ActorCell.attachChild(ActorCell.scala:369)
        at akka.actor.ActorSystemImpl.actorOf(ActorSystem.scala:553)

Thank you
The change is good to merge!


Update content

/botio build

From: MushinBot (botio-academy.horizen.global)

Received
Command cmd_build from @tuanhvdev received. Current queue size: 0
Live output at: https://botio-academy.horizen.global/4ac49208e24e4e9/output.txt

From: MushinBot (botio-academy.horizen.global)

Failed
Full output at https://botio-academy.horizen.global/4ac49208e24e4e9/output.txt
Total script time: 1.83 mins
Error: Build failed at step "bundle exec jekyll build" with ExitCode 1

/botio build

From: MushinBot (botio-academy.horizen.global)

Received
Command cmd_build from @tuanhvdev received. Current queue size: 0
Live output at: https://botio-academy.horizen.global/4d5eead45aed2fa/output.txt

From: MushinBot (botio-academy.horizen.global)

Success
Full output at https://botio-academy.horizen.global/4d5eead45aed2fa/output.txt
Total script time: 1.93 mins
You can download the generated site at: https://botio-academy.horizen.global/latest.tar.gz
Or view a preview at https://devweb-academy.horizen.global


chore: go-demo-6 to 1.0.339

chore: Promote go-demo-6 to version 1.0.339

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Allow n >= 2 volumes to share the same metadata DB

What would you like to be added:
The ability for several JuiceFS volumes to share the same one metadata DB.
Why is this needed:
I just received a surprise when putting JuiceFS and its CSI driver through its paces, exactly the same as described in the summary of juicefs-csi-driver issue 430. In our use, storage is dynamically allocated, sometimes several times per day. If it's true that JuiceFS cannot share a metadata store for use with n >= 2 volumes, that means we need to create a new DB for every new allocation of a storage volume.
Well, this will be burdensome for devops. The entire point of an SDS is to automate away this kind of building and instantiating. We prefer to merely declare that we are carving out a volume from storage with the current deployment idioms (like k8s & a PV), and then have the components manifest that declaration into reality.
This, or please make it excruciatingly clear in the documentation that the metadata DB cannot be shared; it's the sole property of a single volume, and that if you want more volumes, you're gonna have to make more metadata DBs. Particularly in the project README.md plus the metadata document.
Thanks!

Hi @enspritz , are you suggesting that you need inter-application data isolation? If so, you can achieve this by using a same juicefs volume. You can dynamically mount it using a storage class, and each application can request its own PVC(refer to https://juicefs.com/docs/csi/guide/pv/#dynamic-provisioning). The data between applications will be automatically isolated through subdirectories. This eliminates the need for creating a new volume each time.

Hi @zwwhdls , yes that's right, inter-application data isolation. I understand what you are saying about effecting this using storage classes, thanks for pointing that out.
Even with application data isolated by subdirectories, I'm afraid this approach won't harmonize well with our backup/restore systems. Everything else here is operating under the assumption of one volume per deployment; this way, each commissioning and decommissioning is an atomic operation that operates on the most natural-sized idioms at each layer, in this case, one discrete JuiceFS/S3-backed volume + one discrete JuiceFS metadata DB for workload storage. This satisfies the security and compliance people, in particular.
It was the promise of POSIX file system compliance which I am investigating, and I have already confirmed that it functions much better than current SeaweedFS. But the metadata DB story is difficult to swallow at this time...


Array helper: concat

Hey, awesome project. I just wanted to ask if anyone besides me is interested in a concat helper for arrays (and possibly other types as well, such as strings?). If so I would be interested in creating a PR for that.
Since I'm already using this helper myself, here is the code for it:
module.exports = function(arrayA, arrayB, options) {
  if (Array.isArray(arrayA) && !Array.isArray(arrayB)) {
    return arrayA;
  } else if (Array.isArray(arrayA) && Array.isArray(arrayB)) {
    return arrayA.concat(arrayB);
  } else {
    return [];
  }
}

Thanks for the issue! A PR would be great and we can discuss any details in there.
Thanks!


adding G. Narayanamma Institute of Technology & Science (for Women) institute (gnits.in)

adding G. Narayanamma Institute of Technology & Science (for Women) institute (gnits.in)

@chandanpasunoori Please provide us with a proof, which shows that the school recognizes the domain gnits.in that you are submitting as an official email domain for the students.

@philipto letter head from college will work? I will try to get one.

@chandanpasunoori It seems to be even too much. Isn't there an email to you or any other instruction from the university which you have been given regarding using this email address while you are a student? I did not find any official information about the domain at the official website.

@chandanpasunoori I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and comment if you have an update regarding the aforementioned issue. Thank you for the understanding!


Fix binary package creation

create_binary_package.sh was broken due to builders/ccaas.
The make "release/${TARGET}" step creates the builders/ccaas directory, just like it creates the bin directory.
Therefore there is no need to later create this directory or cp the content since it already exists in the correct location.
Signed-off-by: David Enyeart<EMAIL_ADDRESS>

@Mergifyio backport release-2.5

@Mergifyio backport main


Suggestion: Add URL pattern blacklisting

Hello,
There is a blacklist of domains, but not a blacklist of URL regexp's.
I tried to implement it, I thinks I do it well, but it don't works. D:
This is my code: https://github.com/OSPG/colly/commit/344b0fdafaef2fcf5ca2e9d817eadb43418db80c
This an example of use: https://gist.github.com/palvarezcordoba/56d9a014a5262e258ba8b7bd83f98263
The above gist should not visit URLs starting with https://a, but it visit https://accounts.google.com/(...)
Anybody wants to help me to implement it? :smiley:

And, without URL blacklisting is it easy to implement this?:
Allowed:
https://(www\.)?google\.(.*?)/q\?=
https://(www\.)?youtube\.com/(feed/trending|user|channel/UC-9-kyTW8ZkZNDHQJ6FgpwQ)
https://policies\.google\.com/privacy

Disallowed:
https://(www\.)?google.(.*?/)/imghp
https://accounts\.google\.com/(signin|accounts)
https://support\.google\.com
https://(www\.)?youtube\.com/channel/UCEgdi0XIXXZ-qJOFPf4JSKw
https://(mail|news)\.google\.(.*?)
https://policies\.google\.com/technologies

LOL I was wrong.
https://gist.github.com/palvarezcordoba/846b36bdae6d9700e44110f70e0390da
package main

import (
	"github.com/OSPG/colly"
	"log"
	"regexp"
)

func main() {
	r := regexp.MustCompile(`https://.*debian\.org/?.*`)
	r2 := regexp.MustCompile(`(png|jpg|jpeg|gif|ico|pdf|iso)$`)
	c := colly.NewCollector(
		colly.URLFilters(r),
		colly.DisallowedURLFilters(r2),
	)
	c.OnHTML("a", func(e *colly.HTMLElement) {
		link := e.Request.AbsoluteURL(e.Attr("href"))
		if len(link) > 0 {
			//		    log.Println("I'm going to try to visit", link)
			c.Visit(link)
		}

	})
	c.OnRequest(func(r *colly.Request) {
		log.Println("visiting", r.URL.String())
	})
	log.Println(c.DisallowedURLFilters)
	c.Visit("https://debian.org")
}

My code works fine. I will open a PR.

added in #132


Add an Animated Unsubscribe Page

Is your feature request related to a problem? Please describe.
No its not a problem.
Describe the solution you'd like
I would like to add an Animated Unsubscribe Page

Additional context
Please assign me this under gssoc21

@ridsuteri @991rajat Please assign.


Add volume support for run

Fixes #148.

Thanks for this @clee! I'm ok to add this, would it be possible to add a README entry? Ideally we'd get a test too, but I can help with that if need be.

Good call, @lox! This PR has been updated with new documentation in the README. I attempted to match the tone and style of the existing documentation, but I'm happy to adjust it (or for y'all to change it).

Thanks for the PR @clee! I've just rebased this, added some tests for you.
One thing I noticed, is that it seems to support both vol and volumes — but I've only tested for the latter. What do you think about me removing vol support?

It lines up nicer with env but that’s literally the only reason I implemented it. I’m fine with you taking it out!

Ok cool, thanks for the backstory.
The env is there because we have the same alias for the env in command steps in the pipeline.yml  — so you can copy+paste. But because there's no vol equivalent, we can probably remove it from here.
I'll do that now, and merge! 🎉


Unable to enable CORS from HTTP API

Specs: rasa-core v0.8.5 / rasa-nlu v0.11.4
OS: Linux 4.13.0-21-generic #24-Ubuntu SMP (Server) / Windows 10 (Client)
I am facing CORS issue while trying to call the Rasa server from a different origin (an Angular app hosted on different domain). I am trying the default MoodBot example, and facing the following error on client side (Windows 10 browser console):

Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://localhost:4200' is therefore not allowed access. The response had HTTP status code 404.

I have tried:

running the server with --cors ['*'] option
adding "cors_origins" : ["*"] to nlu_model_config.json file.

The server responds correctly when using Postman to make the POST call. It was working without trying any CORS workaround as well. Valid JSON is received by Postman, and on server side, following message is displayed:
"POST /conversations/default/parse HTTP/1.1" 200 635 "-" "PostmanRuntime/7.1.1"
But when I make POST request from Angular app using no headers, server displays:
"POST /conversations/uzair/parse/ HTTP/1.1" 404 233 "http://localhost:4200/" "Mozilla/5.0 (Windows NT 10.0; Win64; x64)
If I add Content-Type: application/json header with POST request from Angular, server returns:
"OPTIONS /conversations/uzair/parse/ HTTP/1.1" 404 233 "-" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) (POST is replaced by OPTIONS now)
The same 404 error posted on top is returned in both cases on client browser.
What am I doing wrong here?
Cross SO question: Link

Using the 0.9.0a2 branch, its is working now. This is the working setup, in case anyone happens to needs.
$ python -m rasa_core.server -d models/dialogue -u models/nlu/default/current -o out.log --cors "*" --auth_token myToken
And on the Angular side, define a method:
public getResponse(query: string) {
  let finalUrl: string = "http://<IP_ADDRESS>:5005/conversations/default/parse?token=myToken";
  let data = {
    "query" : query
  }
  return this.http.post(
      `${finalUrl}`, data
    ).map(res => {
      return res.json()
    })
}

And call this method:
getResponse("hi").subscribe(res => {
      // Use the response returned in 'res' object
    );
});

It was quite straightforward, but I got stuck on some steps. Thanks @tmbo and @amn41!


How to pass nested attribute to FILTER?

If I have a document like this:
{
  "foo": {
      "bar": true,
      "blat" false
   }
}

how do I pass these to match as filters? If I try this:
and: [
  { 'foo.bar': true },
  { 'foo.blat': false }
],

then ToAQL quotes it and the resulting query doesn't work:
FOR d IN x FILTER (d.`foo.bar` == true && d.`foo.blat` == false)

I also tried:
and: [
  { foo: { bar: true } },
  { foo: { blat: false } },
],

which resulted in:
FOR d IN x FILTER (d.`bar` == true && d.`blat` == false)


zopen clone spits out errors

I created a 'zopen' installation under /home/fultonm/zopen.
I then did a clone to /home/fultonm/cloned and got the following:

@DevonianTeuchter please tell me if you won't have time to look at this and I can take a look... I want to be able to write a blog showing how someone can install tools, test them out, them 'clone' them to the correct target location.
@IgorTodorovskiIBM fyi

Looks like it ignored your new FS location and tried to overwrite your existing location... let me investigate

thanks! I tried to hack a fix but failed 😩


Deployment

This PR will track fixes needed to deploy the dev RP into production

@mjudeikis @m1kola, we're live; merging.  I added feature flags for metrics and the operationsStatus API as I couldn't get either of these live in prod yet; also not live yet is signed TLS certs...


remmina: only use fuse on linux systems

Description of changes
fuse is used in FreeRDP and now needs to be included 1 in remmina. This breaks darwin and is only used for file clipboard on linux2.
This commit also fixes a compiler error due to some upstream refactoring3.
This fixes the darwin build issue introduced by updating remmina in #308922
@SuperSandro2000 could you take a look?
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@SuperSandro2000 thanks for the quick review!


Feature/order endpoints

get endpoints for order and post endpoint that still needs work, isn't returning proper JSON object

Does it still have merge conflict?


Discuss: throw error when settings service is unavailable?

There are two situations in which the settings service could not be available. At the moment, sdk is returning an empty array in both situations.
1: Settings service is not set up / configured at all. -> valid to fall back to defaults
2: Settings service is temporarily not available. -> should throw an error instead of returning defaults. Would be confusing for the user to fall back to defaults.
We need to discuss this. It's probably a good idea to fail on temporarily not available settings service.

Can we go forward once we have a capability for the settings service? (https://github.com/owncloud/ocis/pull/2655)


chore: initial version

This PR pushes the the initial version (0.8.0) of the ARK messenger client to the repository.

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.
If no reviewer appears after a week, a reminder will be sent out.

Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days.

If safari is still an issue because of BigInt, it makes sense to add that disclaimer somewhere in the readme.
Sending more than 1 message in a short timeframe (e.g. a b c d e) discards most of the messages after a. Is it only possible to have 1 transaction in a block or what is the cause of this?
Linebreaks are not send over, so you can add those to your message but after sending it will all be on one line.
Not sure what the message preview modal is for. I expected a preview of a message after it was sent and not forged yet instead of a modal that I can click before sending.
Sending <test> returns in an empty message as it's not rendered (added to the DOM instead). This also means you can send stuff like oh no and it will show up as html (needs some sanitizing)
You can send a message to any existing chat address and it will show up in there.

The app supports Markdown. So if you apply markdown syntax to your message input, you can preview it with this modal. Perhaps I should rename the preview to "Markdown preview" (it will also serve as a small hint that Markdown is supported that way)

If safari is still an issue because of BigInt, it makes sense to add that disclaimer somewhere in the readme.

Will do.

Sending more than 1 message in a short timeframe (e.g. a b c d e) discards most of the messages after a. Is it only possible to have 1 transaction in a block or what is the cause of this?

I believe it's a small error in the custom transaction, where it rejects a tx if the sender already is in the pool (forgot to omit it when using the register business transaction as a template)

Linebreaks are not send over, so you can add those to your message but after sending it will all be on one line.

Will look into it.

Not sure what the message preview modal is for. I expected a preview of a message after it was sent and not forged yet instead of a modal that I can click before sending.

The app supports Markdown. So if you apply markdown syntax to your message input, you can preview it with this modal. Perhaps I should rename the preview to "Markdown preview" (it will also serve as a small hint that Markdown is supported that way)

Sending <test> returns in an empty message as it's not rendered (added to the DOM instead). This also means you can send stuff like oh no and it will show up as html (needs some sanitizing)

Will do.

You can send a message to any existing chat address and it will show up in there.

This is true. However, as discussed in the chat with Michel a little while ago, it is indeed an issue, but also considered out of scope for now.
Thanks for the extensive feedback and will get back to it soon! 👍


PollBuddy Home Page

I designed PollBuddy's home page.

While we're at it, I fixed the react-countdown-now issue since no one else has yet and I already did it locally for testing so I thought I might as well commit it.

Awesome! @hbh7

I'll see if I can get our PM @burgus7 to merge it this weekend. Perhaps backend too if we're feeling adventurous lol. Not much changed but not really any reason not to either so idk.

Ok sounds good @hbh7

Ok I will change them @nbezanis


Update murmurhash package

Be more compatible with PHP 8

Can this be merged? i really need php 8 support.

Merge this please.

Has Php 8 support been added yet?

No, seems like this package is inactive. Perhaps we should create a fork and continue maintaining? @ndirpaya

No, seems like this package is inactive. Perhaps we should create a fork and continue maintaining? @ndirpaya

Someone has forked it already, and it works! https://github.com/n3omaster/bitcoin-php
Check it out and let me know.

No, seems like this package is inactive. Perhaps we should create a fork and continue maintaining? @ndirpaya

@ExpDev07  Someone has forked it already, and it works! https://github.com/n3omaster/bitcoin-php
Check it out and let me know.


Php 5.5

https://github.com/rmrevin/yii2-fontawesome/blob/master/composer.json#L26
Do you need php 5.5 for this project? Since its merely an asset wouldnt 5.4 suffice (yii2 is compatible with it as well).

We are planning a new version for php 7. So would gradually increase the minimum requirements. Rollback in extension version 2.17.1.
P.s. PHP Versions below 5.6 are no longer supported, it is better to upgrade.

That is true but why not support 5.4 as well? Yii2 does the same? Why not just use a different version for your PHP 7 dependency, so at least people can use this repo with a static semver instead of having to fork it.


XxxApplicationMetadata Methods in can only be 64k bytes.

Find another way to construct the meta data since we may run out of space for large meta data sets.

More information about this can be read here: stackoverflow.com.


virt lines can't handle \t

Description
^
Neovim version
NVIM v0.6.1
Operating system and version
ArchLinux
Steps to reproduce

Open a file with tab as indent under git repo;
Enable show_deleted;
Delete the indented lines.

Expected behavior
Respect tabstop.
Actual behavior
Single space for \t.
Gitsigns debug messages
No response
Minimal config
None

Pretty sure this an issue with neovim core. I've raised https://github.com/neovim/neovim/issues/17148
Closing ticket as issue isn't due to Gitsigns


Wip dedication and consent

added a step definition for a previously undefined step in the feature file
added a path in paths.rb

LGTM


Degraded performance after upgrading from 3.0.1 to 3.1.0

Hi,
We've experiencing significant slowdowns in our application after upgrading from 3.0.1 to 3.1.0. Our Mocha tests started to timeout as requests take much longer than before. We authenticate using /oauth/token (password) authentication mechanism.
We're using the following Stormpath middleware's for our routes:
stormpath.apiAuthenticationRequired, stormpath.getUser
Only configuration change for the upgrade was the addition of web.register.form.fields.confirmPassword.enabled
If we rollback to 3.0.1, the slowdown is gone. Can you confirm this?
Thanks,
Matti Lindell

Hello @cgilindellmo , can you tell me which token authentication strategy you are using? stormpath or local?  If you are using stormpath, that will explain the slowdown: in 3.1.0 we fixed apiAuthenticationRequired to respect the stormpath option, and make a roundtrip call to our API on every authentication attempt.

We've explicitly defined local token auth strategy (although it's documented as the default).
Thanks,
Matti

Here's the config:
stormpath.init(app, {
debug: 'info, error',
web: {
me: {
enabled: false
},
oauth2: {
password: {
validationStrategy: 'local'
}
},
register: {
form: {
fields: {
confirmPassword: {
enabled: true
}
}
}
}
}
});

Thanks!  I see where the problem is, I forgot to carry the strategy option into a part of this refactor :( I'll make a patch release today, sorry about this!

I've published 3.1.1, which should fix this issue.  @cgilindellmo can you please try?  Thanks!

It's good now, thanks!

Awesome!


Report a Bug

Hi, I think there might be a bug here, a strange break makes it only traverse one image before it get out of the for loop. Could you please have a check, thanks.
https://github.com/YoungXIAO13/FewShotDetection/blob/78e95a32ec7b955e93fec5c17e7bdc6ebc01271c/lib/datasets/metadata_coco.py#L236

Hi @Ze-Yang
This break is directly borrowed from the original file in Meta R-CNN.
You can remove it.


🔥 Moved user email removal to API serialization layer

Essentially these changes reflect similar logic to what has been done in case of similar changes - https://github.com/TryGhost/Ghost/commit/0306c397d04779d22d93c3660fdf3f594da5e756.
@rishabhgrg @kevinansfield 	the only bit I was worried about is accidentally leaking the email field if the API is used directly (e.g. fetching resource from "frontend") but haven't found anything obvious. For example, in webhooks we don't listen to user change events at all. Maybe you could think of a case I didn't take into account :thinking:

@gargol Changes look good to me. 🚢

For example, in webhooks we don't listen to user change events at all. Maybe you could think of a case I didn't take into account
We might have a use for exposing user change events in future, but I don't see email being exposed there as a problem tbh 🤔 Plus we can always take care of how we want to handle it in case its explicitly needed to be ignored, the changes here are still right direction 👍


$routes not do the job as well

I use my codeigniter rc3 as HMVC. Here is my structure

I try to do some action from HomeView with input username and password also method POST that handled by Home Controller to ActionSignIn. I set the route like this $routes->get('action-signin', 'Acme\Home\Controllers\HomeAction\ActionSignIn::index');
Peekaboo, it show 404 when I press the submit button. I try to visit action-signin directly, nothing was wrong.

Please look for support on the forums. The issues here are for bug tracking.
If you find a  bug while working through things with others on the forum, feel free to bring that back here.

okay


Available CRDs check feature

Changes

Update the storageClaim controller to react whenever a create/delete event has been enqueued for a specific CRD that's become newly available.
Exit the ocs-client-operator process with a specific exit code whenever a new crd of interest is being created or deleted
Catch the exit code with a bash script and restart the ocs-client-operator process
Conditionally watch the DRClusterConfig CRD

In the future we will need to watch Maintenance Mode CRD by ramen as well
This PR just adds the base for watching the DRClusterConfig CRD by ramen, the actual creation will be added in https://github.com/red-hat-storage/ocs-client-operator/pull/177
Ref: https://github.com/red-hat-storage/ocs-operator/pull/2745

/lgtm

minor comment rest is same as the one implemented in ocs-operator, isn't it? btw, are you planning on sending another PR for using this mechanism for storagecluster cr?
asking because, I'm going to remove specific code in a couple of days (when we get RC).

No, I don't plan to send a PR to use this for storageCluster CR


Able to import sprite packages as easily as extensions

Can we have a path to import special "sprite packs" as easily as we can import a new project or extension?
I imagine this would be related to log-in, as ideally packs would load for a user…not just a project.

You should be able to do this via images.g.ts and images.g.jres
see: https://github.com/Jacob-Tate/tomatocube-arcade-sprites

This would be good to get in for the Holiday season...  I could imagine some Halloween, Thanksgiving or Christmas special sprite packs.  And a way to open these types of extensions from the asset editor, like an Import button...

We do have support of sprite packs through extension dialog.

I will keep this alive for future design.

We can do this now through the Extensions menu.


Update column name in table of learn-common-operators.md

@shsagir
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

#sign-off


should varaible "rotmat_recon" in decode function match to 'global_xform' ?

hi, I have a little question about the generative model. I looked throught the code, in decode function, the varaible "rotmat_recon" is transformed from "local_motion". And it is transformed into varaible "local_rotmat" using function self.fk.global_to_local() for calculating "pos_recon"

so can it be regarded as the reconstructed "global_xform"? The "rotmat_recon" is further assigned as output['rotmat']. In backward() function , it is used to calculate the rotmat_recon_loss by comparing with self.input_data['rotmat']. But does the gt varaible self.input_data['rotmat'] should be gt "local_rotmat" instead of gt "global_xform"?  Because in data processing the varaible "rotmat" is calculated straight from smpl data

Haha ok thx, that makes it clear to me, thank you for the reply >_<


Execute own shell commands

Hey,
I'm just wondering if there is a way to execute your own shell commands in the Brewfile. I would like to use it to install some php extensions during the installation of the bundle:
brew<EMAIL_ADDRESS>link: true
system<EMAIL_ADDRESS>install mongodb"

Using system executes the command immediate and not after installing php, and I didn't found any fitting entries in the DSL, or in the documentation/readme.
Thank you for your help.

There's no support in the DSL for this, sorry, and no plans to add it.

You might be interested in https://github.com/shivammathur/homebrew-extensions as an alternative to your PECL approach though (since PECL is deprecated)

@thedustin You could drop in an at_exit block… Something like:
brew<EMAIL_ADDRESS>link: true
at_exit do
  system<EMAIL_ADDRESS>install mongodb"
end


Add Roadster launch video link

Add the link of the maiden Falcon Heavy to the Tesla Roadster endpoint.
For example:
video: "https://youtu.be/wbSwFU6tY1c",

Added 👍

Great! Thanks!


MINOR: add Yahoo benchmark to nightly runs

System test passed: https://jenkins.confluent.io/job/system-test-kafka-branch-builder-2/. cc @guozhangwang

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/5462/
Test PASSed (JDK 8 and Scala 2.12).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/5477/
Test PASSed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/5478/
Test PASSed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/5479/
Test PASSed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/5464/
Test PASSed (JDK 8 and Scala 2.12).

Don't check in yet, just got a system test failure.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/5496/
Test PASSed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/5481/
Test PASSed (JDK 8 and Scala 2.12).

Thanks @dguy . Verified system tests working at https://jenkins.confluent.io/job/system-test-kafka-branch-builder-2/345/console

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/5555/
Test PASSed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/5541/
Test PASSed (JDK 8 and Scala 2.12).


TypeError: Object(...) is not a function

Getting TypeError: Object(...) is not a function when trying to implement this per the demo.  Simply adding
import { Provider } from "react-alert";
import AlertTemplate from "react-alert-template-basic";

to the top of my file causes the error

Closing due to inactivity

Uncaught TypeError: Object(...) is not a function
at Provider (react-alert.js:303)
at mountIndeterminateComponent (react-dom.development.js:15425)
at beginWork (react-dom.development.js:15956)
at performUnitOfWork (react-dom.development.js:19102)
at workLoop (react-dom.development.js:19143)
at HTMLUnknownElement.callCallback (react-dom.development.js:147)
at Object.invokeGuardedCallbackDev (react-dom.development.js:196)
at invokeGuardedCallback (react-dom.development.js:250)
at replayUnitOfWork (react-dom.development.js:18350)
at renderRoot (react-dom.development.js:19261)
at performWorkOnRoot (react-dom.development.js:20165)
at performWork (react-dom.development.js:20075)
at performSyncWork (react-dom.development.js:20049)
at requestWork (react-dom.development.js:19904)
at scheduleWork (react-dom.development.js:19711)
at scheduleRootUpdate (react-dom.development.js:20415)
at updateContainerAtExpirationTime (react-dom.development.js:20441)
at updateContainer (react-dom.development.js:20509)
at ReactRoot.push../node_modules/react-dom/cjs/react-dom.development.js.ReactRoot.render (react-dom.development.js:20820)
at react-dom.development.js:20974
at unbatchedUpdates (react-dom.development.js:20292)
at legacyRenderSubtreeIntoContainer (react-dom.development.js:20970)
at render (react-dom.development.js:21037)
at Module../src/index.js (index.js:21)
at webpack_require (bootstrap:782)
at fn (bootstrap:150)
at Object.0 (tarotCard.js:148)
at webpack_require (bootstrap:782)
at checkDeferredModules (bootstrap:45)
at Array.webpackJsonpCallback [as push] (bootstrap:32)
at main.chunk.js:1

I am also getting this error trying to use the basic template:
react-hot-loader.development.js:285 TypeError: Object(...) is not a function
    at Provider (react-alert.js:309)
    at ProxyFacade (react-hot-loader.development.js:791)
    at mountIndeterminateComponent (react-dom.development.js:14811)
    at beginWork (react-dom.development.js:15316)
    at performUnitOfWork (react-dom.development.js:18150)
    at workLoop (react-dom.development.js:18190)
    at renderRoot (react-dom.development.js:18276)
    at performWorkOnRoot (react-dom.development.js:19165)
    at performWork (react-dom.development.js:19077)
    at performSyncWork (react-dom.development.js:19051)

Line 309. Little obfuscated because of webpack.
  var root = Object(react__WEBPACK_IMPORTED_MODULE_0__["useRef"])(null);

My code:
import { transitions, positions, Provider as AlertProvider } from 'react-alert'
import AlertTemplate from 'react-alert-template-basic'

const alertOptions = {
  // you can also just use 'bottom center'
  position: positions.TOP_RIGHT,
  timeout: 5000,
  offset: '30px',
  // you can also just use 'scale'
  transition: transitions.SCALE,
}

const App = props => (
  <AlertProvider template={AlertTemplate} {...alertOptions}>
     // ...
  </AlertProvider>
)

My React was out of date, upgrading has resolved it.


Update pandoc to 1.13.2

…and replace caveats describing conflicts with dedicated stanza.

Has conflicts_with been implemented? Now that I look at it, #5569 and #4688 seem to suggest it; but #4497 and #7683 suggest it hasn’t.

No, it is still a stub. I seemed to recall a consensus that conflicts with homebrew formulae could be left unstated, but it would appear that was merely my own opinion in https://github.com/caskroom/homebrew-cask/pull/4451#issuecomment-43457961.
We should probably stub conflict caveats into conflicts_with while we work on an actual implementation, but meanwhile, I will reinstate the stanza.


Code: 503. Errors Vault is sealed

Hello!
I try install vault cluster with raft
[vault_raft_servers]
vault1 ansible_host=192.168.2x.3
vault2 ansible_host=192.168.2x.4
vault3 ansible_host=192.168.2x.5

Config:
 /etc/vault.d/vault_main.hcl
cluster_name = "dc1"
max_lease_ttl = "768h"
default_lease_ttl = "768h"

disable_clustering = "False"
cluster_addr = "http://<IP_ADDRESS>:8201"
api_addr = "http://<IP_ADDRESS>:8200"

plugin_directory = "/usr/local/lib/vault/plugins"

listener "tcp" {
  address = "<IP_ADDRESS>:8200"
  cluster_address = "<IP_ADDRESS>:8201"
  tls_disable = "true"
}

storage "raft" {
  path = "/var/vault"
  node_id = "vault2"
        retry_join {
    leader_api_addr =  "http://<IP_ADDRESS>:8200"
  }
            retry_join {
    leader_api_addr =  "http://<IP_ADDRESS>:8200"
  }
      }

// HashiCorp recommends disabling mlock when using Raft.
disable_mlock = true

ui = true

Log:
2021-01-10T09:38:42.031+0300 [INFO]  core: raft retry join initiated
2021-01-10T09:38:42.031+0300 [INFO]  core: security barrier not initialized
2021-01-10T09:38:42.031+0300 [INFO]  core: security barrier not initialized
2021-01-10T09:38:42.031+0300 [INFO]  core: attempting to join possible raft leader node: leader_addr=http://<IP_ADDRESS>:8200
2021-01-10T09:38:42.032+0300 [INFO]  core: join attempt failed: error="error during raft bootstrap init call: Error making API request.
URL: PUT http://<IP_ADDRESS>:8200/v1/sys/storage/raft/bootstrap/challenge
Code: 503. Errors:
* Vault is sealed"
* ```

Vault needs initialization it seems. Did you already run vault operator init or use the UI to do that?

Vault needs initialization it seems. Did you already run vault operator init or use the UI to do that?

Should i run vault operator init by hand?
When?

Should i run vault operator init by hand?
When?

That is one way to do it, an alternative way is using the UI:
https://learn.hashicorp.com/tutorials/vault/getting-started-ui?in=vault/getting-started-ui

That is one way to do it, an alternative way is using the UI:
https://learn.hashicorp.com/tutorials/vault/getting-started-ui?in=vault/getting-started-ui

Thanks!

Thanks!

  It seems like maybe sticking
vault_seal_generate_key: True

in your vars should get past this automatically?  But this is not the case, at least in my experience.


Don't use raw prefix

@damianooldoni rather than using the raw_ prefix:
https://github.com/inbo/sovon/blob/efbf1f49630ad03ae8a0a98871e86533bf8710fa/src/map_inbo_data_to_sovon.Rmd#L181-L189
Can you leave the columns as is, but add the sovon_ prefix when mapping to the structure of the sovon database? That makes it easier to recognize columns. See also the (updated!) checklist recipe on how we remove the dwc_ prefix: https://github.com/trias-project/checklist-recipe/blob/3e7491eec1437d15a2ff542163abd72796fddd52/src/dwc_mapping.Rmd#L267

Yes, thanks for suggesting it. I will do it.
Just a detail, about code in recipe: https://github.com/trias-project/checklist-recipe/blob/3e7491eec1437d15a2ff542163abd72796fddd52/src/dwc_mapping.Rmd#L276
Please, consider to use str_remove() instead of str_replace(). Same effect but better to understand, as common people don't consider replacing with nothing a replacement, actually :smile:
colnames(taxon) <- str_remove_all(colnames(taxon), pattern = "dwc_")

All raw prefixes removed.


replace polymer test by wct in travis build

After updating polymer-cli, the build never ends, e.g polymer test -l chrome,  otherwise running wct -l chrome it works.
Downgrading polymer-cli and wct does not fix the problem, seems that the issue is in a 3rd party dependency.

This change is

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 1 of 1 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable


update lnbits to 0.10.2 and use poetry instead of venv

as the title states, updating lnbits to 0.10.2 and installing/running it with poetry now
i did not test it on a raspiblitz yet ;(
LNbits version 0.10.2 will be releases very soon.

Thanks for the PR :) - can you base it on the dev branch please.

And how soon is 0.10.2 .. next week or more next month?

i hope 0.10.2 is today :) :crossed_fingers:

i hope 0.10.2 is today :) 🤞

https://github.com/rootzoll/raspiblitz/pull/3703