NotFoundError (see above for traceback): Key resnet_v1_50/rpn_conv/3x3/weights not found in checkpoint

Hi Chen,
In order to test on my own images, I follow steps in the Demo/Test on your own images section.
I encountered an issue when doing the step3(Detect all objects).
(sence-graph) nadoudou@nadoudou-ThinkStation-P310:~/iCAN$ python ../tf-faster-rcnn/tools/Object_Detector.py --img_dir demo/ --img_format png --Demo_RCNN demo/Object_Detection.pkl
2018-12-11 15:02:48.221898: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE4.1 instructions, but these are available on your machine and could speed up CPU computations.
2018-12-11 15:02:48.221920: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE4.2 instructions, but these are available on your machine and could speed up CPU computations.
2018-12-11 15:02:48.221925: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use AVX instructions, but these are available on your machine and could speed up CPU computations.
2018-12-11 15:02:48.221930: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use AVX2 instructions, but these are available on your machine and could speed up CPU computations.
2018-12-11 15:02:48.221934: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use FMA instructions, but these are available on your machine and could speed up CPU computations.
2018-12-11 15:02:49.798437: W tensorflow/core/framework/op_kernel.cc:1158] Not found: Key resnet_v1_50/rpn_conv/3x3/weights not found in checkpoint
2018-12-11 15:02:49.798742: W tensorflow/core/framework/op_kernel.cc:1158] Not found: Key resnet_v1_50/rpn_conv/3x3/biases not found in checkpoint
2018-12-11 15:02:49.799248: W tensorflow/core/framework/op_kernel.cc:1158] Not found: Key resnet_v1_50/bbox_pred/biases not found in checkpoint
2018-12-11 15:02:49.799520: W tensorflow/core/framework/op_kernel.cc:1158] Not found: Key resnet_v1_50/bbox_pred/weights not found in checkpoint
2018-12-11 15:02:49.799539: W tensorflow/core/framework/op_kernel.cc:1158] Not found: Key resnet_v1_50/rpn_cls_score/weights not found in checkpoint
2018-12-11 15:02:49.800069: W tensorflow/core/framework/op_kernel.cc:1158] Not found: Key resnet_v1_50/rpn_cls_score/biases not found in checkpoint
2018-12-11 15:02:49.800601: W tensorflow/core/framework/op_kernel.cc:1158] Not found: Key resnet_v1_50/rpn_bbox_pred/weights not found in checkpoint
2018-12-11 15:02:49.801182: W tensorflow/core/framework/op_kernel.cc:1158] Not found: Key resnet_v1_50/rpn_bbox_pred/biases not found in checkpoint
2018-12-11 15:02:49.804062: W tensorflow/core/framework/op_kernel.cc:1158] Not found: Key resnet_v1_50/cls_score/weights not found in checkpoint
2018-12-11 15:02:49.804685: W tensorflow/core/framework/op_kernel.cc:1158] Not found: Key resnet_v1_50/cls_score/biases not found in checkpoint
Traceback (most recent call last):
  File "../tf-faster-rcnn/tools/Object_Detector.py", line 68, in <module>
    saver.restore(sess, tfmodel)
  File "/home/nadoudou/anaconda2/envs/sence-graph/lib/python2.7/site-packages/tensorflow/python/training/saver.py", line 1548, in restore
    {self.saver_def.filename_tensor_name: save_path})
  File "/home/nadoudou/anaconda2/envs/sence-graph/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 789, in run
    run_metadata_ptr)
  File "/home/nadoudou/anaconda2/envs/sence-graph/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 997, in _run
    feed_dict_string, options, run_metadata)
  File "/home/nadoudou/anaconda2/envs/sence-graph/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 1132, in _do_run
    target_list, options, run_metadata)
  File "/home/nadoudou/anaconda2/envs/sence-graph/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 1152, in _do_call
    raise type(e)(node_def, op, message)
NotFoundError: Key resnet_v1_50/rpn_conv/3x3/weights not found in checkpoint
	 [[Node: save/RestoreV2_274 = RestoreV2[dtypes=[DT_FLOAT], _device="/job:localhost/replica:0/task:0/cpu:0"](_arg_save/Const_0_0, save/RestoreV2_274/tensor_names, save/RestoreV2_274/shape_and_slices)]]

Caused by op u'save/RestoreV2_274', defined at:
  File "../tf-faster-rcnn/tools/Object_Detector.py", line 67, in <module>
    saver = tf.train.Saver()
  File "/home/nadoudou/anaconda2/envs/sence-graph/lib/python2.7/site-packages/tensorflow/python/training/saver.py", line 1139, in __init__
    self.build()
  File "/home/nadoudou/anaconda2/envs/sence-graph/lib/python2.7/site-packages/tensorflow/python/training/saver.py", line 1170, in build
    restore_sequentially=self._restore_sequentially)
  File "/home/nadoudou/anaconda2/envs/sence-graph/lib/python2.7/site-packages/tensorflow/python/training/saver.py", line 691, in build
    restore_sequentially, reshape)
  File "/home/nadoudou/anaconda2/envs/sence-graph/lib/python2.7/site-packages/tensorflow/python/training/saver.py", line 407, in _AddRestoreOps
    tensors = self.restore_op(filename_tensor, saveable, preferred_shard)
  File "/home/nadoudou/anaconda2/envs/sence-graph/lib/python2.7/site-packages/tensorflow/python/training/saver.py", line 247, in restore_op
    [spec.tensor.dtype])[0])
  File "/home/nadoudou/anaconda2/envs/sence-graph/lib/python2.7/site-packages/tensorflow/python/ops/gen_io_ops.py", line 640, in restore_v2
    dtypes=dtypes, name=name)
  File "/home/nadoudou/anaconda2/envs/sence-graph/lib/python2.7/site-packages/tensorflow/python/framework/op_def_library.py", line 767, in apply_op
    op_def=op_def)
  File "/home/nadoudou/anaconda2/envs/sence-graph/lib/python2.7/site-packages/tensorflow/python/framework/ops.py", line 2506, in create_op
    original_op=self._default_original_op, op_def=op_def)
  File "/home/nadoudou/anaconda2/envs/sence-graph/lib/python2.7/site-packages/tensorflow/python/framework/ops.py", line 1269, in __init__
    self._traceback = _extract_stack()

NotFoundError (see above for traceback): Key resnet_v1_50/rpn_conv/3x3/weights not found in checkpoint
	 [[Node: save/RestoreV2_274 = RestoreV2[dtypes=[DT_FLOAT], _device="/job:localhost/replica:0/task:0/cpu:0"](_arg_save/Const_0_0, save/RestoreV2_274/tensor_names, save/RestoreV2_274/shape_and_slices)]]

many thanks!

Hi,
Sorry for my late reply. The reason you faced this issue is that you haven't downloaded the pre-trained weights for the object detector. A simple fix is to run line 72~75 in download_dataset.sh. This script will download the pre-trained weights and put them in the right place.
Let me know if this works for you.

Hi Chen,
Thanks for your reply and guidance.
Now it works fine.
I think the issue can be closed.
Thanks again!


Feature/beam package improvements

Motivation for this change
This includes to major changes to beam packages. One is the ability to add debugging information on a global and per package basis. The second is the ability to override phases for hand written beam expressions.
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

This change is

Using the nox-review tool, I got some failure on the ejabberd package. Do you mind taking a look?

===> Upgrading erlware_commons ({pkg,<<"erlware_commons">>,<<"0.20.0">>})
===> A request is being made that violates Nix hermicity This request has been stopped. Details of the request are as follows:
===> Requesnt: get https://s3.amazonaws.com:443/s3.hex.pm/tarballs/erlware_commons-0.20.0.tar?
Makefile:39: recipe for target 'install' failed
make: *** [install] Error 1
builder for ‘/nix/store/3v0lbav9pg6q0m2wskp321jiwirfazar-hex2nix-0.0.5.drv’ failed with exit code 2

@zimbatm I just noticed the same thing and will have some fixes out shortly.

Feel free to ping me when you're happy with the PR. I don't get notified if you just push the code.

@zimbatm
ejabberd seems to be failing because the hash to one of its deps has changed. A dep not managed by these beam packages. Its rebuilding because it does depend on elixir which we made a small change to. I could go and 'fix' the hash, but i am not the maintainer of ejabberd and have no idea what the expected behavior is.
What is the usual way to resolve this problem?
output path ‘/nix/store/5hyiq0gm437day6dfb8dbdknbwd7ysg3-ejabberd-deps-16.04’ has r:sha256 hash ‘1iphn0p6gq79arsfr3dgjyypfvk0w8dvmwv9i7kxdzp0c61j8wcy’ when ‘0jrxd3v6p35wjrpw0jbb6m8nrm2lffhfgdcqmzcvsvjzji7nlkzx’
was expected

cc @abbradar is one of the ejabberd maintainers, they may know more.

See https://github.com/NixOS/nixpkgs/pull/16037


Add dynamic screen space error

This accommodates https://github.com/CesiumGS/cesium-native/pull/466

Thanks for the pull request @baothientran!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

[ ] Cesium for Unreal Samples works.

@baothientran this is really interesting! The reduction in tiles for horizon views near the ground is quite impressive. And in some cases it actually does a better job of preserving detail. For example, here's a horizon view with dynamic SSE enabled and default settings. Notice the small peak at the horizon near the middle-right of the screen.

Now here's the same scene with dynamic SSE disabled:

Huh.. where'd the peak go? Apparently, it got fog culled. Not great. But even less great is that second screenshot with the missing peak rendered 145 tiles, while your improved algorithm only rendered 81. That's very impressive.
Here's a zoomed out view showing which tiles were selected, with dynamic SSE (81 tiles rendered):

And with the original, non-dynamic algorithm (145 tiles rendered):

The new algorithm is switching to bigger, less detailed tiles much more aggressively, but it also is pushing the horizon out much further.
Of course, if you look closely, you can see the loss of detail at medium zoom distances.

It's more obvious in the above gif because Bing has an imagery discontinuity here.
Also, because the dynamic SSE is only activated when the camera descends below a certain height, it's possible to observe weird discontinuities where moving the camera downward (and thus closer to the globe) causes the globe to become less detailed:

So I think this is super promising, but we need to be a bit more rigorous about it. Especially considering that there are so many user-tweakable settings here. It's going to be very hard to explain to users how to set them, and settings that work great in one part of the globe may work very poorly in others. Perhaps we need some basic knowledge of terrain heights over the globe so that we can use that as an input to the algorithm? CesiumJS does similar things elsewhere (but not for tile selection, AFAIK).

yeah I agree we should have a better way to estimate those settings automatically, so that it works reliably for the whole earth and make it easier for user. I will check on CesiumJS to see if we can calculate the estimation

So I think this is super promising, but we need to be a bit more rigorous about it. Especially considering that there are so many user-tweakable settings here. It's going to be very hard to explain to users how to set them, ...

The number of settings/parameters depends on the exact approach that is implemented. The computation right now is implemented as
double sse = frustum.computeScreenSpaceError(tile.getGeometricError(), distance);
if (_options.enableDynamicScreenSpaceError) {
    // some complex computation, hightly specific for the approach,
    // depending on 7 user-tweakable parameters and many aspects
    // of what is currently visible on the screen...
    sse = ...;
}

where indeed quite a few paramters come into play.

Regardless of the implementation, it all boils down to a single bit being 0 or 1 (render or don't render). So it could be written as
boolean skipDueToSse = sseCuller.compute(....);

Usually (but not necessarily!) this is based on comparing the SSE with the "maximum SSE". So the default implementation of the SseCuller#compute function could be
boolean compute(....) {
    double sse = sseComputer.compute(tile, distance, ...);
    return sse < maxSse;
}

with SseComputer being a single-virtual-function class. One could argue about the exact inputs, but one could be open-minded about that. In any case, it would open room for further experiments, including approaches with fewer user-tweakable parameters.

Back when I opened https://github.com/CesiumGS/cesium-native/issues/342 , I actually played around with one implementation like that, using sse = geometricError / pow(distance, someExponent) as the actual function. (That's just one of many possible SseComputer implementations that could be switched transparently, without affecting any other part of the code).
Some screenshots are attached.
The fist one (scene A) shows one scene where I varied the Distance Exponent ( lower right) in the range [0.25, 2.0], and chose the Maximum Screen Space Error so that roughly the same number of tiles are rendered. In the second one (scene B), I did the same with fewer steps.
This this had really just been very basic experiments, because there was no explicit "goal" here. The question about the "goal" could be:

Should there be fewer tiles rendered for the same SSE ?
Should the SSE be smaller for the same number of rendered tiles?
(+ probably many other "axes" to explore....)
...
(abstractly: ) How to actually quantify "visual quality"?

CesiumUnreal distance exponent.zip


Create body update debug helper

As a developer I want to be able to quickly check which change triggers a view body update.
Acceptance criteria

A debug helper is available to print which change triggers a body update.
This helper must be prevented from use in release builds.

Tasks

[ ] Write a simple modifier that implements _printChanges (debug code only since a private API).

Not possible it seems. The change context must be available where Self._printChanges() is called so there is no way to introduce a generic modifier which would see the original context.


Improvements to encoding

I have just learned that Polars uses its own reference counting system. This means that we could directly point to the underlying Polars/Arrow binaries by using make_resource_binary, then bumping the ref count on ARC, and decreasing the ARC refcount when the binary is GCed. Doing so means we don't need to double the allocation for string series.
Something else to explore to reduce allocation is to allow Iterators to be converted to lists. I believe today we allocate a vector and then we allocate a list, but I keep wondering if we can iterate in reverse and allocate the linked list in one pass.
Unfortunately both of these are above my paygrade. :)
Originally posted by @josevalim in https://github.com/elixir-nx/explorer/issues/281#issuecomment-1241938332

Another idea to explore is to preload NifStructs keys. Currently we are doing this to speed up encoding, specially in a loop:
https://github.com/elixir-nx/explorer/blob/9166d739e43eee7457e6e93ac7b918cf54f8bee4/native/explorer/src/encoding.rs#L65
However, I think we can do this automatically. There are a couple options:

When encoding a Vec, we automatically encode the keys before hand, as we did manually above. We should also apply this to iterators.

When the nif is loaded, we can use the C load callback to preload already encoded atoms and keys into enif_priv_data. This may require declaring structs as part of rustler::init


Customize minimum zoom level to interact with nodes

Please describe the feature that you want to propose
From my usage it seems like there is a minimum zoom level required to interact with individual nodes, otherwise it just pans the whole canvas (see below).

How can we adjust this threshold?

This shouldn't be the case 🤔 Can you create a codesandbox for this? https://new.reactflow.dev

I tried to repro today (admittedly a lot of changes in our codebase) and it's working as expected 🤷🏻
Thanks!


[Add LOI tasks] Inconsistent behavior of Add LOI tasks

The addLoiTask boolean has been deprecated. Instead we should:

[ ] Stop assuming these special "add LOI" tasks appear as the field task
[ ] Identify add LOI tasks by their ID ($addLoi)
[ ] Remove the boolean flag addLoiTask on Task

@sufyanAbbasi PTAL?

It seems like, for some reason, while the $addLoi task appears in the task list from Firestore, when we're retrieving the taks lists from the JobEntity in the local DB, that task is no where to be found. Investigating further.

After debugging some more, by changing the $addLoi ID to something like $addLoi123 then setting the target LOUID task ID to $addLoi123, the feature began to work again as expected. With breakpoints, I can see that as we iterate over the surveys and store them into the DAO, when the same LOI task ID key is encountered, we store it there.
Given that the taskDao uses the taskId as the primary key, it gets overridden by the other tasks when loaded into the DAO. Inspecting the DB revealed the issue:

Proposed fixes:

Change it from $addLoi to $addLoi<JOB ID> and we can use a simple startsWith() check.
Do this transformation on the local DB side and remember to unparse it later at fetch time.
Reconfigure the DB to use both a Primary and Secondary key, the task and job ID, something something?

Great sleuthing, Sufy! What if we just go back to using the "addLoiTask" boolean? That way clients would be able to count on task IDs being UUIDs. @rfontanarosa does this complicate things much?

I wanted to report that option 3, having two primary keys, is a completely viable option: I modified the task table, multiple choice table, and option table to use the task ID and job ID as primary keys. I have no crashes and as long as task IDs are unique within a job, the solution actually works REALLY well. Furthermore, consider the scenario in which a sufficiently lazy survey creator wanted to just copy and paste a survey schema. With this solution, they could theoretically JUST change the job ID and the two surveys could coexist on the device. In the status quo scenario, doing the operation that I just described would be unsafe.
The cost is a table schema update and more complicated key structures which would get in the way of migration.

Update: We reevaluated this issue, and agreed instead on the solution outlined in https://github.com/google/ground-platform/issues/1530. For now, no changes are needed Android-side. We'll eventually deprecate addLoiTask boolean, but not in this version, so closing this for now.


chore(SetTheory/Ordinal/Basic): group typein and enum theorems together

We previously had two separate sections with lemmas about typein and enum, since we defined the linear order instance relatively late in the file. Thanks to #16401, we can group almost all of these lemmas together. The remaining ones will be deprecated in a separate PR, for separate reasons.

[x] depends on: #17517

I'll do the golfing stuff in a separate PR.

Thanks!
maintainer merge

Thanks! :tada:
bors merge


Issue/392 document config private python package repo

Description
Document the proper way to configure a project to access a private python package repository
closes https://github.com/inmanta/inmanta-service-orchestrator/issues/392
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[x] Attached issue to pull request
[x] Changelog entry
[ ] Type annotations are present
[ ] Code is clear and sufficiently documented
[ ] No (preventable) type errors (check using make mypy or make mypy-diff)
[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Correct, in line with design
[x] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
[ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see test-fixes for more info)

@edvgui I added you as a reviewer, because you created the ticket and have a better understanding about how this is configured in practice.

@FloLey Do you also make sure you test this procedure?

Processing this pull request

Pull request rejected by merge tool. Multiple change entry files found (changelogs/unreleased/1249-fix-race-condition-compile-requests.yml,changelogs/unreleased/367-id-attribute-called-id.yml,changelogs/unreleased/391-document-migration-from-one-running-orchestrator-to-another.yml,changelogs/unreleased/392-document-config-private-package-repo.yml,changelogs/unreleased/5392-event-loops-in-threads.yml,changelogs/unreleased/5433-list-comprehensions.yml,changelogs/unreleased/5555-make-crudhandler-generic.yml,changelogs/unreleased/5631-module-freeze-command.yml,changelogs/unreleased/5651-ignore-plugins-for-modules-that-arent-loaded.yml,changelogs/unreleased/5690-unmanaged-resources-storage.yml,changelogs/unreleased/5706-add-support-keyword-only-attributes.yml,changelogs/unreleased/5708-import-modules-agent-logger-helpers-into-core.yml,changelogs/unreleased/5755-verbose-flags-ignored-at-some-locations.yml,changelogs/unreleased/5757-add-f-strings-to-the-language.yml,changelogs/unreleased/5815-expose-logging-setup.yml,changelogs/unreleased/5816-module-release-tag.yml,changelogs/unreleased/5824-dependabot.yml,changelogs/unreleased/5825-dependabot.yml,changelogs/unreleased/5831-dependabot.yml,changelogs/unreleased/5832-dependabot.yml,changelogs/unreleased/5834-dependabot.yml,changelogs/unreleased/5835-dependabot.yml,changelogs/unreleased/5836-dependabot.yml,changelogs/unreleased/5838-dependabot.yml,changelogs/unreleased/5842-dont-cleanup-halted-env.yml,changelogs/unreleased/5844-dependabot.yml,changelogs/unreleased/5845-dependabot.yml,changelogs/unreleased/5871-dependabot.yml,changelogs/unreleased/5884-improve-logging-regarding-resource-sets.yml,changelogs/unreleased/5887-dependabot.yml,changelogs/unreleased/5888-dependabot.yml,changelogs/unreleased/5895-dependabot.yml,changelogs/unreleased/5898-fix-query-get-resource-events.yml,changelogs/unreleased/5902-dependabot.yml,changelogs/unreleased/5903-dependabot.yml,changelogs/unreleased/5904-dependabot.yml,changelogs/unreleased/5905-dependabot.yml,changelogs/unreleased/5906-dependabot.yml,changelogs/unreleased/5907-dependabot.yml,changelogs/unreleased/5925-dependabot.yml,changelogs/unreleased/5931-version-consistency.yml,changelogs/unreleased/5933-investigate-timeout-on-license-component.yml,changelogs/unreleased/5937-dependabot.yml,changelogs/unreleased/5941-dependabot.yml,changelogs/unreleased/5944-produce-warning-when-database-pool-is-exhausted.yml,changelogs/unreleased/5955-dependabot.yml,changelogs/unreleased/5956-dependabot.yml,changelogs/unreleased/5964-dependabot.yml,changelogs/unreleased/5965-dependabot.yml,changelogs/unreleased/5966-dependabot.yml,changelogs/unreleased/5967-dependabot.yml,changelogs/unreleased/5974-web-console-environment-delete-does-not-delete-env-dir-on-server.yml,changelogs/unreleased/5976-use-pip-config-file.yml,changelogs/unreleased/5984-dependabot.yml,changelogs/unreleased/5985-dependabot.yml,changelogs/unreleased/5989-troubleshooting-documentation-is-in-terms-of-the-old-dashboard.yml,changelogs/unreleased/5993-add-dedicated-pip-index-url-config-for-full-project.yml,changelogs/unreleased/5997-dependabot.yml,changelogs/unreleased/6003-dependabot.yml,changelogs/unreleased/6004-dependabot.yml,changelogs/unreleased/6005-dependabot.yml,changelogs/unreleased/6006-dependabot.yml,changelogs/unreleased/6007-dependabot.yml,changelogs/unreleased/6023-unmanaged-resources-storage-fixes.yml,changelogs/unreleased/6030-list-comprehension-docs.yml,changelogs/unreleased/6043-dependabot.yml,changelogs/unreleased/6049-dependabot.yml,changelogs/unreleased/6066-dependabot.yml,changelogs/unreleased/6069-dependabot.yml,changelogs/unreleased/6075-dependabot.yml,changelogs/unreleased/6076-dependabot.yml,changelogs/unreleased/6081-dependabot.yml,changelogs/unreleased/6090-deadlock-2.yml,changelogs/unreleased/6090-deadlock-3.yml,changelogs/unreleased/6090-deadlock-4.yml,changelogs/unreleased/6090-deadlock.yml,changelogs/unreleased/6098-dependabot.yml,changelogs/unreleased/6109-dependabot.yml,changelogs/unreleased/6130-dependabot.yml,changelogs/unreleased/6132-dependabot.yml,changelogs/unreleased/6133-dependabot.yml,changelogs/unreleased/6151-dependabot.yml,changelogs/unreleased/6182-dont-log-everytime-database-pool-exhaustion-is-checked.yml,changelogs/unreleased/6192-dependabot.yml,changelogs/unreleased/add-support-for-multi-url-endpoints.yml,changelogs/unreleased/add_agent_resource_backoff_config_option.yml,changelogs/unreleased/auto-comment-lines-in-db-dump.yml,changelogs/unreleased/bad_import_in_moduletool.yml,changelogs/unreleased/bugfix-compiler-lazy-boolean-promises.yml,changelogs/unreleased/bugfix-resource-action-cleanup.yml,changelogs/unreleased/buildmaster-test-speed.yml,changelogs/unreleased/bump-compiler-version-2024-0.yml,changelogs/unreleased/bump-std-version-in-v1-tests.yml,changelogs/unreleased/change-default-agent-backoff.yml,changelogs/unreleased/cleanup-agent-py.yml,changelogs/unreleased/dependabot-divergence.yml,changelogs/unreleased/document-pip-config-option.yml,changelogs/unreleased/drop-deprecated-log_msg-method.yml,changelogs/unreleased/drop-support-purge-on-delete.yml,changelogs/unreleased/event-loop-fix.yml,changelogs/unreleased/export-resource-set-log-message.yml,changelogs/unreleased/fix-bug-compile-request-committed.yml,changelogs/unreleased/fix-cron-expression-in-test-case.yml,changelogs/unreleased/fix-extension-loading-test.yml,changelogs/unreleased/fix-formatting-docs-v1tov2-cmd.yml,changelogs/unreleased/fix-issue-timedelta-heartbeat.yml,changelogs/unreleased/fix-log-line-agent-backoff.yml,changelogs/unreleased/fix-race-condition-compilerservice.yml,changelogs/unreleased/fix-race-condition-on-get-env-setting.yml,changelogs/unreleased/fix-race-condition-test-get-facts-extended.yml,changelogs/unreleased/fix-race-condition-version-resource.yml,changelogs/unreleased/fix-sequencing-issue-disconnect-from-db.yml,changelogs/unreleased/fix-task-queue-calculation.yml,changelogs/unreleased/fix-test-server-recompile-test-case.yml,changelogs/unreleased/fix-typing.yml,changelogs/unreleased/heartbeat-timer.yml,changelogs/unreleased/improve-doc-get-resource-endpoint.yml,changelogs/unreleased/improve-performance-get-resource-logs-endpoint.yml,changelogs/unreleased/improve-request-error-logging.yml,changelogs/unreleased/investigate-flaky-test-cleanup-agent.yml,changelogs/unreleased/log-enabled-extensions.yml,changelogs/unreleased/log_on_cache_failure.yml,changelogs/unreleased/lost-comment-on-lsm-partial.yml,changelogs/unreleased/server-status-timeout-fix.yml,changelogs/unreleased/server-token.yml,changelogs/unreleased/status_endpoint_timeout.yml,changelogs/unreleased/test-failure-visibility.yml,changelogs/unreleased/test_curation.yml,changelogs/unreleased/typing-extensions-clean-up-constraint.yml,changelogs/unreleased/typing-extensions-constraints.yml,changelogs/unreleased/update-doc-indexes-on-embedded-entities.yml,changelogs/unreleased/update-documentation-keycloak.yml,changelogs/unreleased/update-install-doc.yml). This may happen when a change entry was removed from the remote repository due to a reverted change. In that case, make sure the latest changes from origin/master are merged into issue/392-document-config-private-python-package-repo before triggering merge bot.

Processing this pull request

Failed to merge changes into iso6 due to merge conflict. Please open a pull request for these branches separately by cherry-picking the commit that was made on the branch master (git cherry-pick 83bb26a9187ea83ffaf7388bc313b66eebb7318d).

Merged into branches master in 83bb26a9187ea83ffaf7388bc313b66eebb7318d

Not closing this pull request due to previously commented issues for some of the destination branches. Please open a separate pull request for those branches by cherry-picking the relevant commit. You can safely close this pull request and delete the source branch.

This branch was not deleted as it seems to still be in use.


Global media controls in KDE

Would it be possible to make cpod controllable with KDE's built in media player controls? I'm mainly interested in play/pause controls.
I believe it's handled by mpris?

If it is handled by MPRIS then this issue should be resolved along with #28. I'll ping here when that one's resolved so we can see if that's the case.

Oh sorry. I've actually seen that post before but didn't know what mpris was at the time, just learned what it is while making this post. Didn't put 2 and 2 together.
From my quick googling it seems like that's what it is in KDE so fingers crossed.

Hello, it seems to be the case that MPRIS is indeed responsible for KDE global media controls. (Pre)release 1.20.0 contains basic MPRIS integration including but not limited to play and pause. Tested on KDE neon. Please let me know if there are any problems.

Hi, thanks for implementing it :)
Looks like it's working in the system tray which is great, but it doesn't work in the task manager panel right click context menu. Perhaps there's some extra implementation required to get it to work there? If you don't know how, I can try to find out in some kde forums how that's handled and let you know.
Here it is working in the system tray:

Here's media controls in the task manager panel working for Spotify:

Here's how it looks for CPod:

It might be the case that Spotify's context menu controls is not actually related to MPRIS but a set of buttons specified in its desktop file. I'll look into how I can achieve this in Electron (the framework that CPod uses).

Other apps that I noticed have it are VLC, Rhythmbox, and Clementine, though they're not Electron.
I installed a few Electron music apps from this list https://electronjs.org/apps?category=music to see if any developers managed to do it, but none of the apps I tried had it, (though none had general MPRIS support in the system tray either). I'll try some more later.

I couldn't find anything in the documentation for Electron related to customizing the taskbar context menu, so I'll have to find a way to get around that by modifying the desktop entry. There's a possible solution that I'm already working on and I'll let you know how that goes. Thanks.

:+1: :+1: :+1:


Brief Cycan color flash

There's a brief flash of cyan color when the camera is not ready. And it is hardcoded here:
This line

In other news, is there why the android min SDK is 26? are you using any special api that requires that?

This should be fixed in 0.1.4. Also, i downgraded the min SDK to 21.


No page found Asura scan

Source information
Asura Scan
Source language
English
Steps to reproduce
Open app
Open manhwa
Open chapter
No page found
Expected behavior
Open app
Open manhwa
Open chapter
Page found
Actual behavior
Open app
Open manhwa
Open chapter
No page found
Mihon/Tachiyomi version
Tachiyomi stable0.15.3
Android version
Android 11
Other details

Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.15.3.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

It had been working well 2 or 3 days ago. But now when i try to read manhwa. It's showing no page found

Will i have to migrate again? ive migrated 3x now with asurascans and its been 100+ manhwa each time lol

It's unlikely since mangas are recognized, only pages are not


Documentation

Add appropriate documentation for all applications.

hi, i can try if you don't mind, might take a while.


Additional Standard Class Attributes [CT/Model]

Additional, standard new ones:

label
type
code

As discussed during scrum 08/08: Change TimingDescription to Description and add Name and Label to Timing class

Two parts to this work

Name changes to existing classes that contain type and code elements (CT and MODEL DONE) - API to be done
Identifying additional classes that need any of the default elements (name description label code and type)

DDF Sprint 4_Addition of Label Attribute.xlsx
Please see the attached spreadsheet containing the list of potential attribute additions for 'label' to various entities.

DDF Sprint 4_Addition of Label Attribute.xlsx
Please see the attached spreadsheet containing the list of potential attribute additions for 'label' to various entities.

Erin
Two comments:

Timing class, "label" attribute already added in previous sprint?
Content class, not sure "label" is useful here. We have unstructured text which is, in some way, the label, the human readable form. That is in the "text" attribute so tempted not to add here.

Label for syntaxTemplate and SyntaxTemplateDictionary in USDM_CT.xls. I thought we agreed not to include label for syntaxTextTemplates?

I have it in my notes that the 'label' attribute is unnecessary for Content entity, but nothing in my notes from yesterday to remove 'label' attribute from SyntaxtTemplate class. Does anyone else remember that discussion?

@EMuhlbradt @czwickl @BSnoeijerCD Cannot think of any reason not to include "label" as per discussion on scrum call of 29th Aug 2023

@jared-schreibman-cdisc to refer to the CT changes XL file in the release 2-3 branch where a list of labels has been inserted into various classes.


Add a limit for the batch request

We have a limit of batch request which is defined in the doc[1].
However, in the batch class there is no such limit, which usually result
a timeout somewhere and very hard to debug.
[1] https://developers.google.com/api-client-library/python/guide/batch

Please add a corresponding test for this.

Done :)

@tseaver thanks for your approval!
@theacodes what else I could do to get the PR merged?


feat: expose StoreAction in relation to multiplayer history

Introduced breaking change in updateScene API due to the added Store component as part of the #7348. Specifically, sceneData property commitToHistory: boolean was replaced with storeAction: StoreActionType.

Additional small improvements:

Stabilises Store methods, internal API & public API (i.e. introduced commit)
Avoids potential concurrency issues due to updateScene modifying store before already scheduled store actions execute
Fixes slight issues with AppState in shared scenes (collab)

This is deployed to version 17.6?


how to load from cogvideo official pretrained model?

Only support the t2v model.

How to resume dataset ?

Set --resume_from_checkpoint="latest"

Set --resume_from_checkpoint="latest"

By examining the code, it can be seen that only the parameters and epoch have been loaded, and the data iters has not been resumed.
if args.resume_from_checkpoint:
    if args.resume_from_checkpoint != "latest":
        path = os.path.basename(args.resume_from_checkpoint)
    else:
        # Get the most recent checkpoint
        dirs = os.listdir(args.output_dir)
        dirs = [d for d in dirs if d.startswith("checkpoint")]
        dirs = sorted(dirs, key=lambda x: int(x.split("-")[1]))
        path = dirs[-1] if len(dirs) > 0 else None

    if path is None:
        accelerator.print(
            f"Checkpoint '{args.resume_from_checkpoint}' does not exist. Starting a new training run."
        )
        args.resume_from_checkpoint = None
        initial_global_step = 0
    else:
        global_step = int(path.split("-")[1])

        initial_global_step = global_step

        pkl_path = os.path.join(os.path.join(args.output_dir, path), "sampler_pos_start.pkl")
        if os.path.exists(pkl_path):
            with open(pkl_path, 'rb') as file:
                _, first_epoch = pickle.load(file)
        else:
            first_epoch = global_step // num_update_steps_per_epoch
        print(f"Load pkl from {pkl_path}. Get first_epoch = {first_epoch}.")

        accelerator.print(f"Resuming from checkpoint {path}")
        accelerator.load_state(os.path.join(args.output_dir, path))

The details are in load_model_hook fn.
pkl_path = os.path.join(input_dir, "sampler_pos_start.pkl")
if os.path.exists(pkl_path):
    with open(pkl_path, 'rb') as file:
        loaded_number, _ = pickle.load(file)
        batch_sampler.sampler._pos_start = max(loaded_number - args.dataloader_num_workers * accelerator.num_processes * 2, 0)
    print(f"Load pkl from {pkl_path}. Get loaded_number = {loaded_number}.")

I will close this issue first. If there is anything unclear, you can reopen it.


interactive_world: 0.0.11-0 in 'indigo/distribution.yaml' [bloom]

Increasing version of package(s) in repository interactive_world to 0.0.11-0:

upstream repository: https://github.com/WPI-RAIL/interactive_world.git
release repository: https://github.com/gt-rail-release/interactive_world-release.git
distro file: indigo/distribution.yaml
bloom version: 0.5.20
previous version for package: 0.0.10-0

informed_object_search
* Update package.xml
* small edits to server
* Contributors: David Kent, Russell Toris

interactive_world
* Update package.xml
* Contributors: David Kent

interactive_world_msgs
* Update package.xml
* small edits to server
* Contributors: David Kent, Russell Toris

interactive_world_parser
* Update package.xml
* Contributors: David Kent

interactive_world_tools
* Updated messages to use rail_manipulation_msgs insted of carl_moveit
* Update package.xml
* small edits to server
* Contributors: David Kent, Russell Toris

jinteractiveworld
* Update package.xml
* Contributors: David Kent

spatial_world_model
* Update package.xml
* small edits to server
* Contributors: David Kent, Russell Toris

Your python-rosdistro version is out of date - you need 0.4.4 or higher. Please upgrade and rerun bloom-release with --pull-request-only or -p or edit the commit to fix the REP version.

@dekent please close this it is not intended or ready for release release

The old version is currently failing to build: http://build.ros.org/view/Ibin_uT64/job/Ibin_uT64__interactive_world_tools__ubuntu_trusty_amd64__binary/
Please consider to address this soon since otherwise these packages will be removed finally from the rosdistro (and for EOL platforms that will be permanent since it is the last sync before turning of the build farm as announced on the mailing list some time ago).


UWP Documentation

For UWP, assembly information needs to be included when the app is loading in app.xaml.cs. If this is not added, the app will throw some exceptions. This info is missing from the wiki, but the code is there in the samples. Attaching the screenshot of the line which I'm referring to. This would help anyone who might be facing this issue.

@ninaada Which error exactly are u getting? There are some issues in the nuget right now, @roubachof is taking care of them. Or after adding this line all issues were gone?

@themronion I should add that this happens only in release mode. If not added, the compiler may not include the assembly. That's all.

Well be added with the next push


KeyboardPauseEvent is not raised in server side

Hey!
While working on the proxy I noticed that Winkey+PauseBreak is not working when using the proxy.

I thought maybe the function fastpath_recv_input_event_scancode could be changed like this:
static BOOL fastpath_recv_input_event_scancode(rdpFastPath* fastpath, wStream* s, BYTE eventFlags)
{
	rdpInput* input;
	UINT16 flags;
	UINT16 code;

	if (!fastpath || !fastpath->rdp || !fastpath->rdp->input || !s)
		return FALSE;

	input = fastpath->rdp->input;

	if (Stream_GetRemainingLength(s) < 1)
		return FALSE;

	Stream_Read_UINT8(s, code); /* keyCode (1 byte) */
	flags = 0;

+      if ((code == RDP_SCANCODE_LCONTROL) && (eventFlags & FASTPATH_INPUT_KBDFLAGS_PREFIX_E1))
+      {
+	   /* PAUSE-BREAK sequence started */
+         if (!IFCALLRESULT(TRUE, input->KeyboardPauseEvent, input))
+            return FALSE;
+      }

	if ((eventFlags & FASTPATH_INPUT_KBDFLAGS_RELEASE))
		flags |= KBD_FLAGS_RELEASE;
	else
		flags |= KBD_FLAGS_DOWN;

	if ((eventFlags & FASTPATH_INPUT_KBDFLAGS_EXTENDED))
		flags |= KBD_FLAGS_EXTENDED;

	return IFCALLRESULT(TRUE, input->KeyboardEvent, input, flags, code);
}

What do you think about this addition?

It is important to note that the same addition (with a different flag, called KBDFLAGS_EXTENDED1) has to be added to slowpath input.
I'll be glad to submit a PR for this addition :)

Seem reasonable to me.

shouldn't it be sufficient to pass on the FASTPATH_INPUT_KBDFLAGS_PREFIX_E1 flag in KeyboardEvent?

shouldn't it be sufficient to pass on the FASTPATH_INPUT_KBDFLAGS_PREFIX_E1 flag in KeyboardEvent?

@akallabeth It can be sufficient, but as KeyboardPauseEvent is a callback that can be registered outside the library, as a client of the library I'd expect it to raise it in server side. It's up to you :) Let me know and I'll open a PR

the KeyboarPauseEvent currently is a client side convenience function to send a pause sequence.
this change would give it a server side meaning too (with quite a different application).
I'd prefer not to do that to avoid confusion.

@akallabath Okay, but the thing is that the flag is different between slow/fast path input, so as a client of the library I'll have to check if the event flags contains 2 different flags. I find it a little ugly...

@kubistika you just found a bug ;)
but as far as I see you can just use one flag in both cases (it does not matter if you receive slow or fastpath events, you just need the information)

@kubistika you just found a bug ;)
but as far as I see you can just use one flag in both cases (it does not matter if you receive slow or fastpath events, you just need the information)

@akallabeth I know, I'll fix it later.
However, I can't see how as a user of the library I can use one flag.
The slowpath adds KBD_FLAGS_EXTENDED1 (0x0200) and fastpath adds flag FASTPATH_INPUT_KBDFLAGS_PREFIX_E1 (0x04). So, in order to determine if PAUSE was pressed, I have to check if any of them is presented...

@kubistika sorry, I don't follow.
The callback we're talking about has as argument the flags and the scancode.
You don't need to know if fast or slow path, that part should already be abstracted.

@akallabeth I think there is a misunderstanding between us.
Yes, there is a parameter called flags, but currently the flag which indicates whether a pause sequence is presented is added only in fastpath input.
According to the spec, in fasthpath, its value is 0x4, and in slowpath 0x0200. In freerdp, nor the slowpath or fastpath recv implementation adds the flag.
Again, according to the spec, the flag which indicates pause sequence has different value and name. This is why we can't just push one of those flags.

@kubistika yes, correct. currently the flag is not set before the callback.
But this can be added as there are already 2 functions reading (one for slow, one for fastpath) as is already done with the key press and key release.

Thanks @akallabeth


FizzBuzz Example

FizzBuzz is a common problem to solve in python.
I solved it and uploaded the script.
Many people get stuck at this point:
else if (donut % 3 === 0)

Okay a better way to show this code is copy the permalink:
https://github.com/MishManners/GitHub-Like-A-Boss-Demos/blob/06bba0c86a88d7f5d1b1a9c153c5453c5df7a918/fizzbuzz.py#L12

I can also copy multiple lines of code:
https://github.com/MishManners/GitHub-Like-A-Boss-Demos/blob/06bba0c86a88d7f5d1b1a9c153c5453c5df7a918/fizzbuzz.py#L6-L9


DBZ-3223 - Update sensitive env vars for connect-base image

JIRA

@vanhoale LGTM, one question. Still I have one question, is not CONNECT_CONSUMER_SSL_KEY_PASSWORD missing?

@vanhoale LGTM, one question. Still I have one question, is not CONNECT_CONSUMER_SSL_KEY_PASSWORD missing?

@jcechace you are right, I missed that one!

@vanhoale Applied, thanks!


failing in installing mjpc

when using the command cmake .. -DCMAKE_BUILD_TYPE:STRING=Release -G Ninja -DCMAKE_C_COMPILER:STRING=clang-12 -DCMAKE_CXX_COMPILER:STRING=clang++-12 -DMJPC_BUILD_GRPC_SERVICE:BOOL=ON
I encounter the error
CHECK_STARTmujoco::FindOrFetch: checking for targets in package mujoco
CHECK_FAILtarget mujoco::mujoco not defined.
CHECK_STARTmujoco::FindOrFetch: Using FetchContent to retrieve mujoco
CHECK_STARTmujoco::FindOrFetch: checking for targets in package qhull
CHECK_FAILtarget qhull not defined.
the version of ubuntu is 20.04.6

full error information:

Performing Test CAN_BUILD_AVX
-- Performing Test CAN_BUILD_AVX - Success
-- Performing Test SUPPORTS_LLD
-- Performing Test SUPPORTS_LLD - Failed
-- Performing Test SUPPORTS_GOLD
-- Performing Test SUPPORTS_GOLD - Success
-- Performing Test SUPPORTS_GC_SECTIONS
-- Performing Test SUPPORTS_GC_SECTIONS - Success
-- Found Python: /usr/bin/python3.8 (found version "3.8.10") found components: Interpreter
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
CHECK_STARTmujoco::FindOrFetch: checking for targets in package mujoco
CHECK_FAILtarget mujoco::mujoco not defined.
CHECK_STARTmujoco::FindOrFetch: Using FetchContent to retrieve mujoco
CHECK_STARTmujoco::FindOrFetch: checking for targets in package qhull
CHECK_FAILtarget qhull not defined.
CHECK_STARTmujoco::FindOrFetch: Using FetchContent to retrieve qhull
-- Looking for sys/types.h
-- Looking for sys/types.h - found
-- Looking for inttypes.h
-- Looking for inttypes.h - found
-- Looking for stddef.h
-- Looking for stddef.h - found
-- Looking for stdint.h
-- Looking for stdint.h - found
-- Check size of off_t
-- Check size of off_t - done
-- Looking for fseeko
-- Looking for fseeko - found
-- Looking for ftello
-- Looking for ftello - found
-- Looking for PRIdMAX
-- Looking for PRIdMAX - found
--
-- ========== qhull Build Information ==========
-- Build Version:                             8.1-alpha1
-- Install Prefix (CMAKE_INSTALL_PREFIX):     /usr/local
-- Binary Directory (BIN_INSTALL_DIR):        bin
-- Library Directory (LIB_INSTALL_DIR):       lib
-- Include Directory (INCLUDE_INSTALL_DIR):   include
-- Documentation Directory (DOC_INSTALL_DIR): share/doc/qhull
-- Man Pages Directory (MAN_INSTALL_DIR):     share/man/man1
-- CMake Directory (CMAKE_INSTALL_DIR):       lib/cmake/QHull
-- PkgConfig Directory (PKGCONFIG_INSTALL_DIR):lib/pkgconfig
-- Build Type (CMAKE_BUILD_TYPE):             Release
-- Build static libraries:                    ON
-- Build shared library:                      OFF
-- Use shared library for linking apps:       OFF
-- Build tests:				   OFF
-- To override these options, add -D{OPTION_NAME}=... to the cmake command
--   Build the debug targets                  -DCMAKE_BUILD_TYPE=Debug
--
-- To build and install qhull, enter "make" and "make install"
-- To smoketest qhull, enter "ctest"
--
CHECK_PASSDone
CHECK_STARTmujoco::FindOrFetch: checking for targets in package tinyxml2
CHECK_FAILtarget tinyxml2 not defined.
CHECK_STARTmujoco::FindOrFetch: Using FetchContent to retrieve tinyxml2
CHECK_PASSDone
CHECK_STARTmujoco::FindOrFetch: checking for targets in package tinyobjloader
CHECK_FAILtarget tinyobjloader not defined.
CHECK_STARTmujoco::FindOrFetch: Using FetchContent to retrieve tinyobjloader
CHECK_PASSDone
CHECK_STARTmujoco::FindOrFetch: checking for targets in package sdflib
CHECK_FAILtarget SdfLib not defined.
CHECK_STARTmujoco::FindOrFetch: Using FetchContent to retrieve sdflib


Fix xcode build settings parsing

Regexp chopped off setting values at first space. Flavors test broken as a result, I believe.


Changes to Rapid Form Questions

This is something that has been raised as part of the OASPA issue (#101) and with suggestions from users (#85). There are a few meta-decisions that need to be made here:

[ ] Determining how we want to manage versions of the questions

[ ] How do we want to aggregate over different versions of the questions?
[ ] When the questions form is changed, how do we want to handle questions that are removed or previous reviews that don't have answers to the new questions?

[ ] What is the approval process for changes to the questions on the form?

For the OASPA conversation, here is a mockup with notes from @dasaderi with ideas about changes.

@majohansson do you have thoughts about the approval process for making changes to the form for rapid reviews?

@georgiamoon These are bigger changes you highlighted and I think we will need to consider as part of a large-scale plan.

Building on @majohansson 's comment from a conversation we had — until we have a plan for managing versions of the questions, it'd be better to keep the form as is.
We did discuss re-wording the data question, so that it more clearly communicates asking about access to the data set from a study, as the OASPA initiative has expressed interest in.

In the OSrPRE review/question form, split the data sharing question (“Are the data used in the manuscript available”) into something like: “Are the data used in the manuscript available via a link? Please share the link.” and “If there is no link to available data, are the data used in the manuscript available upon request? Please share who to contact about seeing the data.”
@dasaderi was thinking something with some logic:

If yes > link
If no/unknown > other question?

Thank you all for these comments. @murkatr @majohansson @georgiamoon this is what I would suggest based on conversations so far:

Are the data used in the manuscript openly available. If yes, please paste the link to the data in the box below.

I also suggest we change the (?) part that currently says "In the paper, supplement, on a public repository, or from a cited source?" to "The data are available for anyone to see and/or download e.g. from a public repository and are linked in the manuscript or supplementary information."

Some minor suggestions:

Are the data used in the manuscript openly available? If yes, please paste the link to the data in the box below.

(should be it accessible instead of available?)
And for the info box: "The data are available for anyone to download (e.g. from a public repository) and are linked in the manuscript or supplementary information."

@harumhelmy @jheretic @rudietuesdays how soon can we get this modified in the form? With the OASPA initiative we would like to invite reviewers who signed up next week. Is it possible to get this done by Wednesday next week?

Data question will require a link be added to the text field if “yes” is selected

@dasaderi is this something that would be desired before the site merge? If so, we can prioritize!


Permission checks and user elevation

Well.. it's definitively to big PR. I'm not opposed to move logger creation earlier, but.. if we are moving it earlier the logs that were just stderr print should be changed to logger at the same time.

Commits:
f98e655 Move logger creation earlier
f6bc8b5 Add checking permissions and owner for cfg file
76b8859 Add verification and pulling of git commit (no tests)
moved to #55


Rocket pods

Add a type of rack that disables missile explosions unless its armour is pierced.
Use the same entity as racks, just stuff some more logic in there.
Armour should be defined accurately in a config file to allow easy balance.
Loadable missiles should be limited solely and precisely by caliber.
Fire-rates should be faster than rack missiles.
Firepower should be lower than rack missiles.
Should be able to hide the missile (to save fps + obscure unfolded fins etc)
Any launcher that is tube-shaped or cartridge-like is a pod.  Racks differ in zero protection + variable caliber mounting.

Will we still have support for tube/round-based missiles on racks? I'm thinking it'd be cool to at least allow for 2x racks for the BGMs, to help reducing the amoutn of physical entities on contraptions. Any thoughts on this?
http://www.operatorchan.org/w/src/140012690464.jpg

We can:

Make 1xTOW, 2xTOW... models and classify these as new pods.  (more models needed, no code needed - already supported.)
Spawn a tube model and parent it to the missile (doubled entity count, susceptible to deletion etc, code needed, less models needed.)
Set the missile's model to the tube model until it's fired (code needed, less models needed, tube will "disappear" when fired.)

We can add more code here to drop a tube model from the rack on the clientside, but this is more code + complication + definitely feature-creep.

If we go for an option that needs more code, I'd only do that as a post-beta feature.

I'll just go for the double-BGM model in that case, since the tubes will always be mounted on the racks, no matter what.

Done in 7569dc7b5bbdf203874c589875caf1d047b961b1


pine64/pinebook-pro: remove obsolete issue docs

Description of changes
Per discussion in #882, this PR removes an obsolete issue section in the docs
Things done
(this is a change to the README only, no code changes are done here)

[ ] Tested the changes in your own NixOS Configuration
[ ] Tested the changes end-to-end by using your fork of nixos-hardware and
importing it via <nixos-hardware> or Flake input

@mergify queue


Highlight which step/instructions are completed and which aren't

Contact Details
<EMAIL_ADDRESS>A clear and concise description of what you want to happen.
Today, when I click on each step/instruction.. and switch to some other work and come back.. its not clear till what step/instruction I have finished and from where I need to start
May soem color coding cna be done.. steps which are completed should be in different color and some tooltip or msg should be shown for user coming back (after some time) to refresh his memory and point him to the right step from where he/she needs to resume
thanx,
deepak

@dpkshetty Thanks Deepak for the feedback. We will take a look at improving this experience.

@dpkshetty this feature is now available.  Give a try on any of the applications on https://developer.ibm.com/sandbox/.

@MVillari I took it for a spin...
i went till "get Code" step... as u can see in the terminal... git clone just finished
But it shows "Install Dep" step also highlighted.... giving a false msg that the step is done but its not!


Support object style access of dictionary elements that include hyphen

Thanks for creating omegaconf, it's great. However, would it be possible to add object style access of dictionary elements that include hyphens? If for example a config includes batch-size: 32 it's only possible to access it with cfg["batch-size"]. I'd like to access it using cfg.batch_size.
Take for example Box which converts batch-size to batch_size. Therefore, it's possible to use cfg.batch_size. I think it would be awesome if this feature could be added to omegaconf.

Thanks for the feature request @fjp.
Because OmegaConf also enables attribute style access as you pointed out, this would be a breaking change.
For example, this config would become illegal, or at least broken:
cfg:
  batch-size: 10
  batch_size: 20

I will keep this open as a wishlist item to gauge interest and consider it if there is enough interest.

Hi @fjp,
Given the lack of interest from the community I am closing this for now.
I think adding it is not worth the corner case issues it might introduce (such as the one I pointed out).


Added scripts for the rest of the GoldSrc Steam games

This should fix #240 however, I did have problems getting the mods to actually download. Perhaps the problem is related to #274.

Great work. Just a question about HL:DMC I already have a server called Half Life: Deathmatch classic. mine says valve and yours dmc. Whats the difference?

The one you have with the "valve" folder is actually regular Half-Life multiplayer. Deathmatch Classic or "dmc" is a port of Quake by Valve to GoldSrc. You should change the HalfLifeDeathmatchClassic folder to just HalfLifeDeathmatch.

Thanks for the heads up I will modify my scripts and merge yours. Thanks for your submission. Code submissions are always welcome.

No problem, I'll probably contribute some more soon enough here.

Looks like we are only missing Half-Life Deathmatch: Source Dedicated server now and we have the complete set. If you could create that one it would be very helpful.


Fix #161 -- use extras_require to specify per-platform/per-Python dependencies

This fixes #161. pip understands extras_require and uses them properly.

Coverage remained the same at 99.79% when pulling 2e3419a2e423be375b2c09a81cbe3bb7e7f70e90 on Kwpolska:master into fcaa499cf4131788497971e56f4a9f1d5dd1c5a7 on pydoit:master.

failed. "darwin" is not valid on 3.3 and 3.4.

Coverage remained the same at 99.79% when pulling 26c17dad6b2203206e44b389019d28fecd791d95 on Kwpolska:master into fcaa499cf4131788497971e56f4a9f1d5dd1c5a7 on pydoit:master.

Coverage remained the same at 99.79% when pulling 6333bb8c80a1399f78c94b4e3a0236d6037d361f on Kwpolska:master into fcaa499cf4131788497971e56f4a9f1d5dd1c5a7 on pydoit:master.

Coverage remained the same at 99.79% when pulling c43d1652435aee48402139c17615ba3b7c469bc3 on Kwpolska:master into 6712d5b8344b952a6f6370a8816ec12620e795a3 on pydoit:master.


Debug/Release and Toolchains don't have separate build directories

Need to update CMake so that the various toolchains and Debug/Release modes all have separate build directories. This should be something like: "build/xcode/Debug", "build/xcode/Release", "build/clang/Release", "build/clang/Debug", etc.

Fixed with configuration script update


March 25, showing data below x-axis

Hi,
in the trend on https://adamaltmejd.se/covid/ the mark for the 14-day data, on around march 25, is shown below the x-axis.
/Jörgen

Its because FHM removed a death from that date and moved it to another. Nothing wrong :).


[iOS] fileNameOptional doesn't work when open file in storage directly

It still open anywhere
openFileViaStorage(filename, extension, title) {

        //filename = "1516012203338"
       //extension = "png"
      //title = "sample-title"

        filename = `${filename}${extension != "" ? `.${extension}` : ""}`;
        path = `${RNFS.DocumentDirectoryPath}/${filename}`;
        OpenFile.openDoc([{
            url: path,
            fileNameOptional: title,
        }], () => { });
}

Screenshot

Hi @philipphecht , I have made some changes to fix this issue. Can you review in a pull request? Thanks.

Yes of course. I have at this time no free time  to finish this project.
Von meinem iPhone gesendet

Am 26.03.2018 um 12:48 schrieb LeMinh1995<EMAIL_ADDRESS>Hi @philipphecht , I have made some changes to fix this issue. Can you review in a pull request? Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


File encoding

I have a problem with file encoding, my file is UTF-8 but when downloadet some speciel char like æ, ø and å are not showed correctly, is der allready a fix for setting expected file encoding like:
Content-Type: text/html; charset=utf-8

this can't be set for AFAIK since this plugin doesn't (and cannot) do programmatic ajax sever interactions (it just looks like it from the API)

let me know if you discover otherwise


LitData feedbacks

Hey there,
I am the main author of LitData. I wondered if you had any feedbacks to improve the library.
Best regards,
T.C

Hey there,
I am the main author of LitData. I wondered if you had any feedbacks to improve the library.
Best regards, T.C

@tchaton Thank you and other contributors for your amazing work!
I wonder if it is possible to add cross validation and graph structure data support (i.e. PyG compatability) to LitData. In addition, when using compressed optimized datasets, is it possible to prevent the generation of extracted files in the same directory?
Best regards,
C.W.


AnimatedIcon Catastrophic Failure when Unloaded from Visual Tree

Describe the bug
Testing things in XAML Studio with the MUXC Expander control, however, when I refresh the view, I disconnect the children first with DisconnectChildrenRecursive. This is causing a crash (catastrophic failure error message), appearing to come from the AnimatedIcon used in the Expander togglebutton style.
Happening on line 35 here after call to VisualTreeHelper.DisconnectChildrenRecursive(...);
https://github.com/microsoft/microsoft-ui-xaml/blob/da62ad7e7ac6925061b8664edf0cc0e84ed08544/dev/AnimatedIcon/AnimatedIcon.cpp#L29-L35
Steps to reproduce the bug

Add an Expander to a page.
Call VisualTree.DisconnectChildrenRecursive on it.

Expected behavior
No crash, unloads cleanly.
Screenshots
No response
NuGet package version
None
Windows version
Windows 10 (21H2): Build 19044
Additional context
Using 2.7.3 can't upgrade to latest due to PRI issue #8959

If I just call panel.Children.Clear() things work as expected, but haven't seen similar problems explicitly calling the VisualTreeHelper before now.


It's not working when open from weChat and Skype app

Hi everybody,
I'm using iphone 5S and it's not working. I will shown step by step incorrect at below:

My App not install --> Open weChat or Skype --> Copy link and paste --> Click this link and work fine
App installed --> Open weChat or Skype --> Copy link and paste --> Click this link and not working now (It's still says "view app" although my app installed)

Best regards

Hi @phanthinh!
I'm not sure what weChat or Skype have to do with it.
It sounds like something other than the jQuery plugin is the issue.

Oh, you shouldn't closed issue of me. But it's no problem at this time because me look good article for it (http://thescube.com/blog/app-banner-ios-android/)
below are issue message:

Currently the above meta tags does not work on iOS chrome browser. Jasny has produces a workaround that will show small banner on iOS chrome browser
http://jasny.github.io/jquery.smartbanner/
When we tested it, app banner worked great on chrome browser. How ever on safari there was two banners, one banner from the meta tag and another from the smart banner.

Ah, if you know how detection app installed in the mobile device, please share with me...
Best regards


does not work for teamviewer

download tv 15
open the installer, select run instead of install
press alt-f1
results: window is immune
expected results: window hides

Looks like TeamViewer intentionally disables any attempt at modifying its GUI state, including making it hidden.  Probably to prevent malicious usage of their software.
MinimizeToTray only works on compliant Windows GUIs.
A workaround would be to modify the target application's memory directly, but that'd be against plenty of software TOS.


problem with video name max length

Hi,
I'm facing a problem related to Video Indexer v2 connector on Logic Apps. It seems that it's limiting the video name length to around 40 chars however blobs allow up to 256 chars for a blob name (or maybe even more). Is there a way to update / fix this limitation?

Hi thdotnet. I will send your question to the engineering team.

Hi @thdotnet,
Video Indexer API limit the file name to 80 characters not 40. Can you provide more info on how you hit a 40 character limit?
Regarding increasing the 80 character limit. The limitation is not coming from the blob.
I would like to suggest you raise this ask in our user voice

#please-close


gatsby-plugin-netlify-cms - registerPreviewStyle

Is there any possibility to use a css in js solution like styled components with the preview?
At the moment there is no style applied and registerPreviewStyle does just link to a css file..

See this issue:
https://github.com/netlify/netlify-cms/issues/793
I made a solution for styled components based on the answer in there (not the prettiest), see below.
This is in my cms.js where i register the previews:
//Components used to Enable netlify CMS to apply the styles added through styled-components
class CSSInjector extends React.Component {
  constructor(props) {
    super(props)

    this.state = {
      iframeRef: ''
    }
  }

  componentDidMount() {
    const iframe = document.querySelector(".nc-previewPane-frame")
    const iframeHeadElem = iframe.contentDocument.head;
    this.setState({ iframeRef: iframeHeadElem })
  }

  render() {
    return (
      <div>
        { this.state.iframeRef && (
          <StyleSheetManager target={this.state.iframeRef}>
            { this.props.children }
          </StyleSheetManager>
        )}
      </div>
    )
  }
}

CMS.registerPreviewTemplate('index', props => (
  <CSSInjector>
    <IndexPagePreview {...props} />
  </CSSInjector>
))

Duplicate of #793.

Also note you can now pass strings into registerPreviewStyle: https://www.netlifycms.org/docs/beta-features/#raw-css-in-registerpreviewstyle.

this solution does not work with v2:

this might be the problem:  const iframe = document.querySelector(".nc-previewPane-frame");

Replace the first line with
const iframe = document.getElementsByTagName('iframe')[0]

Here, implemented as hooks!
`import React from 'react';
import { StyleSheetManager } from 'styled-components';
export default function({ children }) {
const [iframeRef, setIframeRef] = useState(null);
useEffect(() => {
const iframe = document.getElementsByTagName('iframe')[0];
const iframeHeadElem = iframe.contentDocument.head;
setIframeRef(iframeHeadElem);
}, []);
return (

{iframeRef && (
{children}
)}

);
}
`

@a8t, have you thought of putting this in a separate package, would be pretty nice? 🙂


fix(curriculum): correct misspelling

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #44596

@gikf Thank you for the feedback. I revise it ^^ and ask for a review soon. :paw_prints:

Hey @najmieh
This change will need to be made in the further steps of the section. However before that there's need to sync your fork with the freecodecamp:main - currently part-053.md file exists in different directory, with changed name.
We would love to be able to merge your changes, but it looks like the branch is not up to date. ⚠
To resolve this error, you will have to sync the latest changes from the main branch of the freeCodeCamp/freeCodeCamp repo.
Using the command line, you can do this in three easy steps:
git remote add upstream git://github.com/freeCodeCamp/freeCodeCamp.git

git fetch upstream

git pull upstream main

If you're using a GUI, you can simply Add a new remote... and use the link git://github.com/freeCodeCamp/freeCodeCamp.git from above.
Once you sync your fork and pass the build, we will be able to review your PR and merge it. 😊
Feel free to reference the Syncing a Fork article on GitHub for more insight on how to keep your fork up-to-date with the upstream repository. 🔄

@gikf I Synced my fork with the main. However, when I tried the command git fetch upstream I faced  error: invalid argument`
What other changes do I need to make this fully ready for a merge? :)

Could you paste the complete output from the terminal? Both with commands used and the results of it.

@gikf apparently, I already had the remote name upstream on my local branch.

So, I tried to use the commands above but, with the git fetch upstream step I'd get fatal error: invalid argument
I removed the upstream with git remote rm and followed the above steps this time I'd get:

Maybe it is because of my directory or branch?
PS: I used this https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork  and synced my fork.

This is weird, error suggests there might be some problem with account permissions to the .git folder.

@gikf I think I covered all of them.
Appreciate any feedbacks.

Yeah, although that's also for files that were since renamed and moved.

Currently they are in /curriculum/challenges/english/14-responsive-web-design-22/learn-basic-css-by-building-a-cafe-menu with part in file name changed to step. However because PR branch is based on older main branch, these files won't be there, what creates merge conflict.

Currently they are in /curriculum/challenges/english/14-responsive-web-design-22/learn-basic-css-by-building-a-cafe-menu with part in file name changed to step. However because PR branch is based on older main branch, these files won't be there, what creates merge conflict.

I covered all the steps from 53 to the rest. I checked the precedents and those didn't have the word cinnamon.
I synced my fork with the option fetch upstream and I can see that I have still the older version of the curriculum on my clone.
Not sure how to do the further edits if a file is left out, or make this fully compatible to merge.

Do you have local main branch up to date? I should be more explicit that after syncing fork it's needed to rebase PR branch. Sorry about that.
If local main branch is synced, rebasing can be done with commands:
git checkout FCC-edit
git rebase main

This however won't be as easy right now, because each of the changed files, will require manual resolving in this case (what means removing part-0xx.md file and then editing step-0xx.md).
The quickest way to resolve it right now, that I can think of, might be kind of starting afresh - bringing FCC-edit local branch to the state of local main branch (if it's synced), again making necessary changes to the step-0xx.md files, pushing FCC-edit branch back to the fork, with --force option.
git checkout FCC-edit
git reset --hard main
(make necessary changes on local branch and commit them)
git push --force origin FCC-edit

Note that changes to all files can be done in a single commit, it doesn't need to be one file - one commit.

Maybe it is because this is the beta version and I don't have the privilege to see its content on GitHub. Therefore I can not clone it. Because I can not even see the beta version on the freeCodeCamp GitHub account itself.
@gikf If that is the case, It might be a better idea to close this PR.

You definitely should have rights to see it on GitHub, they are here: https://github.com/freeCodeCamp/freeCodeCamp/tree/main/curriculum/challenges/english/14-responsive-web-design-22

You definitely should have rights to see it on GitHub, they are here: https://github.com/freeCodeCamp/freeCodeCamp/tree/main/curriculum/challenges/english/14-responsive-web-design-22

Thank you for your patience, generous time, and knowledge. It definitely made a difference for me.
I am stuck in this one.
I rather not go further with the PR.  If it is possible close it.

If you'd change your mind, or will need other assistance with contributing, you can come to Contributor's chat room, there's many helpful people there. I'm using "sanity" username on it.


Coverage of pyspark user defined function

Originally reported by Abdeali Kothari (Bitbucket: AbdealiJK, GitHub: AbdealiJK)

I have a case where I have some pyspark codes in my code base and I am trying to test them.
When doing that, I find that any python UDF I can with spark does not get covered even though I am running it. Note that I am running it in the local spark mode.
Reproducible example:
#!python

def get_new_col(spark, df):
    def myadd(x, y):
        import sys, os
        print("sys.version_info =", sys.version_info)
        print({k: v for k, v in os.environ.items() if k.lower().startswith('cov')})
        x1 = x
        y1 = y
        return str(float(x1) + float(y1))

    spark.udf.register('myadd', myadd)
    return df.selectExpr(['*', 'myadd(x, y) as newcol'])

def run():
    try:
        import findspark
        findspark.init()
    except ImportError:
        pass
    import pyspark
    spark = pyspark.sql.SparkSession.Builder().master("local[2]").getOrCreate()
    df = spark.createDataFrame([
        [1.0, 1.0],
        [1.0, 2.0],
        [1.0, 2.0]
    ], ['x', 'y'])

    outdf = get_new_col(spark, df)
    outdf.show()
    outdf.printSchema()
    assert outdf.columns == (df.columns + ['newcol'])

    spark.stop()

if __name__ == '__main__':
    run()

This says the UDF was not covered even though it did run.
Here are the logs when I run it:
#!python
$ coverage run example.py
2018-05-04 14:58:29 WARN  NativeCodeLoader:62 - Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
Setting default log level to "WARN".
To adjust logging level use sc.setLogLevel(newLevel). For SparkR, use setLogLevel(newLevel).
2018-05-04 14:58:30 WARN  Utils:66 - Service 'SparkUI' could not bind on port 4040. Attempting port 4041.
[Stage 0:>                                                          (0 + 1) / 1]sys.version_info = sys.version_info(major=3, minor=6, micro=4, releaselevel='final', serial=0)
{'COVERAGE_PROCESS_START': ''}
sys.version_info = sys.version_info(major=3, minor=6, micro=4, releaselevel='final', serial=0)
{'COVERAGE_PROCESS_START': ''}
sys.version_info = sys.version_info(major=3, minor=6, micro=4, releaselevel='final', serial=0)
{'COVERAGE_PROCESS_START': ''}
+---+---+------+
|  x|  y|newcol|
+---+---+------+
|1.0|1.0|   2.0|
|1.0|2.0|   3.0|
|1.0|2.0|   3.0|
+---+---+------+

root
 |-- x: double (nullable = true)
 |-- y: double (nullable = true)
 |-- newcol: string (nullable = true)

Relevant packages:
Python 3.6.4 :: Anaconda, Inc.
coverage (4.5.1)
Edit 1: Simplified the reproducible example to remove unittest and pytest.

Bitbucket: https://bitbucket.org/ned/coveragepy/issue/658

Hi,
Any update on this issue? I am facing the same problem when I try to run pytest-cov to test python methods that use @udf decorated nested methods.
Thanks!

Do these help?

https://github.com/nvembar/spark-coverage-example
https://stackoverflow.com/a/67184714/14343

https://stackoverflow.com/a/67184714/14343

I'm running into the same problem. I tried your two suggestions, @nedbat , and had no luck.
I'm invoking coverage.py via pytest-cov. I'm using Python 3.8 and have the following pyspark, pytest, pytest-cov, and coverage modules
Name: pyspark
Version: 2.4.7

Name: pytest-cov
Version: 2.11.1

Name: coverage
Version: 5.4

Hello, running into the same problem too:
pyspark==3.2.1
pytest==7.1.1
pytest-cov==3.0.0

If someone could provide very specific step-by-step instructions to reproduce the failure, that would help move this forward (though no guarantees...)

@nedbat I tried to provide that here: https://github.com/AndrewLane/repro-coverage-issue-with-pyspark-udf

@AndrewLane experimenting a bit with this, my guess is that the code is running in a subprocess, but that process is started in a way that doesn't get coverage started on it, perhaps because it's started from Java.

Here is what I have tried.  I created a doit.sh file in my copy of the repo to configure subprocess measurement, and to simplify re-running it:
cd /home
rm -f debug.txt
pip install pytest==7.0.1 coverage==6.2
echo "import coverage; coverage.process_startup()" > /usr/local/lib/python3.6/site-packages/00coverage.pth
export COVERAGE_PROCESS_START=$(pwd)/.coveragerc
coverage run -m pytest tests/test.py --disable-pytest-warnings

I created a .coveragerc file in /home:
[run]
parallel = true
source = ./src

I changed code.py to add some debugging like this:
import os, sys
from pyspark.sql.functions import col, udf
from pyspark.sql.types import StringType

with open("debug.txt", "a") as f:
    print(f"outside: {os.getpid()}: trace: {sys.gettrace()}\n", file=f)

def translate(english):
    with open("debug.txt", "a") as f:
        print(f"inside: {os.getpid()}: trace: {sys.gettrace()}\n", file=f)

    if english == "1":
        return "uno"
    elif english == "2":
        return "dos"
    else:
        return f"Cannot translate {english}"

translation_udf = udf(lambda english: translate(english), StringType())

def transform_data(df):
    return df.withColumn("spanish", translation_udf(col("english")))

When I run (with source /home/doit.sh), I have a debug.txt that looks like this:
outside: 14: trace: <coverage.CTracer object at 0x7fb34c1483f0>

outside: 172: trace: <coverage.CTracer object at 0x7fc301112030>

outside: 183: trace: <coverage.CTracer object at 0x7fc301112030>

outside: 186: trace: <coverage.CTracer object at 0x7fc301112030>

inside: 186: trace: <coverage.CTracer object at 0x7fc301112030>

outside: 180: trace: <coverage.CTracer object at 0x7fc301112030>

outside: 177: trace: <coverage.CTracer object at 0x7fc301112030>

outside: 188: trace: <coverage.CTracer object at 0x7fc301112030>

inside: 177: trace: <coverage.CTracer object at 0x7fc301112030>

inside: 188: trace: <coverage.CTracer object at 0x7fc301112030>

inside: 183: trace: <coverage.CTracer object at 0x7fc301112030>

inside: 186: trace: <coverage.CTracer object at 0x7fc301112030>

outside: 136: trace: <coverage.CTracer object at 0x7fc301112030>

inside: 136: trace: <coverage.CTracer object at 0x7fc301112030>

and the data files are:
root@5fcaa35b647e:/home# ls -al .coverage*
-rw-r--r-- 1 root root 53248 May  7 12:50 .coverage
-rw-r--r-- 1 root root 53248 May  7 13:19 .coverage.5fcaa35b647e.118.982518
-rw-r--r-- 1 root root 53248 May  7 13:19 .coverage.5fcaa35b647e.14.449311
-rw-r--r-- 1 root root    37 May  7 12:46 .coveragerc

That should mean that process id's 118 and 14 recorded data, but the debug output doesn't show those ids.  Also, the id of the CTracer object is the same for many different processes, so maybe we are dealing with something similar to #310?

Hi Ned, sorry for the lack of info.
I fastly made a repo to reproduce the lack of coverage on UDFs.
https://github.com/RaccoonForever/py-cov-potential-issue
Don't look at code, it was just to reproduce :)
Thanks for your help!

Does someone have a workaround ? :'(

I have the same issue when testing pySpark UDFs using pytest. But as a workaround, the UDFs are python functions and I can create tests that specifically test that function only.

python 3.8
pyspark==3.2.3
coverage ==6.5.0
Although this is not fully operational, I've uncovered something that might provide insight into how to make it work.
example:
file: module1.py
from pyspark.sql import SparkSession
from pyspark.sql.types import IntegerType
from pyspark.sql.functions import udf

spark = SparkSession.builder \
    .appName("SimpleSparkUDF") \
    .getOrCreate()

data = [("John", 25)]
columns = ["Name", "Age"]

df = spark.createDataFrame(data, columns)

def add_one_udf(age):
    import os
    import coverage
    import module2

    # set up coverage
    content = f"""
    [run]
    branch = True
    cover_pylib = False
    concurrency = multiprocessing,thread
    parallel = True
    data_file = {os.getcwd()}/.coverage
    """

    with open("coveragerc_temp", "w") as file:
        file.write(content.strip())

    os.environ["COVERAGE_PROCESS_START"] = "coveragerc_temp"

    cov = coverage.process_startup()

    print("This line isn't covered by coverage.py")
    module2.foo()

    cov.stop()
    cov.save()

    coverage_data_files = [
        f"{current_directory}/{name}" for name in os.listdir(current_directory) if name.startswith(".coverage")
    ]

    # send back the .coverage files to my local machine
    ubprocess.run(["scp", "-o", "StrictHostKeyChecking=no", *coverage_data_files, os.environ["localhost"])

    return age + 1

add_one_udf_spark = udf(add_one_udf, IntegerType())

result = df.withColumn("AgePlusOne", add_one_udf_spark(df["Age"]))

result.show()

file: module2.py
def foo():
    print("This line is covered by coverage.py")
    print("This line is covered by coverage.py")
    print("This line is covered by coverage.py")

On my local host, I received 1 .coverage file. After mapping the paths to my local machine and executing coverage combine + coverage report, I can easily see that the lines from module2.py are covered (75% of the lines, excluding the function signature). However, it seems like module1.py isn't covered at all. Additionally, I tried to debug it with the trace flag in the debug section, and module1.py isn't mentioned at all.
Does anyone have insights into why module1.py isn't covered at all, unlike module2.py?

Does anyone have insights into why module1.py isn't covered at all, unlike module2.py?

You have to show us the steps you used to run the code, and how you used coverage on it.  module1 starts coverage then calls foo().  This is why the three lines in the body of foo() are covered.  Are you using coverage in any other way?  If not, then module1 would not be measured.

@nedbat thanks for the fast response!
No, in this example, I don't use coverage in any other way.

This is why the three lines in the body of foo() are covered.
I totally understand why these 3 lines are covered.

If not, then module1 would not be measured.
I'm not sure I get It, why isn't module1 covered, but module2 is covered?
I'm initiating the coverage.process_startup() command on module1 within the PySpark UDF.

Coverage can't measure code that ran before it was started. This is why the def line in module2 isn't covered.  It will only measure code executed after coverage has been started, and additionally, only in functions called, not in the current function.
You are using the API in a really unusual way: process_startup() isn't meant for you to call from your code: it's for something that runs very early in the process, like sitecustomize or a .pth file.

The best way to help get pyspark support is to provide a complete runnable example, with detailed explicit instructions.

and additionally, only in functions called, not in the current function.

You are correct; this was my issue. Thank you very much!
For those attempting to edit the sitecustomize within the Spark executor, it didn't work for me. Please share if someone manages to collect coverage from the UDF itself using alternative methods.

The best way to help get pyspark support is to provide a complete runnable example, with detailed explicit instructions.

You are correct, unfortunately, it can be challenging to reproduce the Spark environment as it runs on distributed machines.


Add support for gradient clipping

I've found that this makes training more stable in certain cases, especially when using high learning rates

i wasn't planning on it, have been testing on fairly specific usecases so far with a hash-based (but not nerfacto) architecture, and I'm not sure whether this is needed for nerfacto / the specific clipping values I'm using will generalize. For nerfacto I'd maybe start with adding weight decay per https://github.com/nerfstudio-project/nerfstudio/issues/873 and then we could figure out reasonable clipping values if training is still unstable.

Gotcha 👍


How to Install INim?

I have

nim -v
Nim Compiler Version 0.18.0 [Linux: amd64]

I was trying to install inim

nimble install inim --verbose
Reading official package list
Downloading https://github.com/AndreiRegiani/INim using git
Cloning latest tagged version: 0.2.5
Setting Nim stdlib prefix to /home/appu/Nim
Setting Nim stdlib path to /home/appu/Nim/lib
Verifying dependencies for<EMAIL_ADDRESS>Error: Couldn't find Nim version.

I tried

which nim
/home/appu/.nimble/bin/nim

and

whereis nim
nim: /usr/lib/nim /etc/nim.cfg /usr/share/nim /home/appu/bin/nim /home/appu/.nimble/bin/nim /home/appu/Nim/bin/nim

What should I do?

Can you install other Nimble packages?
It seems the problem is with your Nim installation, I recommend using choosenim: https://nim-lang.org/install.html
To install should be nimble install inim, then inim to open.

I am sorry, so this is a bug in choosenim after all! Nimble attempts to read ~/.config/nimble/nimble.ini. Choosenim has not created such a directory. I should have reported a bug there.


correct gcs ha to gcs ft

Why are these changes needed?
correct gcs ha to gcs ft
Related issue number
N/A
Checks

[ ] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[X] Manual tests
[ ] This PR is not tested :(

@Jeffwan


Action isEnabled property

Link to feature: https://adaptivecards.productboard.com/feature-board/planning/features/5456616

This work is currently tracked in #4257

Dup# 4257

Re-opening since this one tracks the overall feature and will serve as the parent for the other SDK issues

This will also resolve #3857


Piano Keys Location Bug

Hi,
I am doing a project for university using mrtk2 with unity, basically I'm doing a virtual piano that you can learn songs on like the other apps with midi cubes falling on it and stuff, but sometimes when I press the piano keys they don't get back up so their z position stays  goes to 0.2~0.4 permenantly.
To reproduce the bug:
after I light up the keys that i want to play I just keep playing the piano, eventually I will encounter it
Screenshots

here is a screenshot showing what I mean by keeping their position.
note that the C key before the yellow key has already been pressed and the D key after the yellow key hasn't been pressed.
so I don't think it is because of the color changes.
My setup

Unity Version  2021.3.13f1
MRTK2

##Target platform :

testing it on metaquest 2

@marlenaklein-msft can you try reproducing in the MRTK3 sample scenes?

its okay, turned out to be a bug in the script.


$("body").on is not a function

Hi I'm trying to use bootstrap but it throws javascript error in Firefox 9.0. It works in IE9.
Any ideas ?
Cheers
Vinny

Your version of jquery must be out of date - you need 1.7+

Thanks for that. Worked perfectly

cool, good to hear :)

oh my... been struggling about it. totally forgot the one i use was 1.6.1.. -___-
thanks, man...


Great collaboration!

What an awesome repo :love_you_gesture:

haha its empty :P

It will eventually leave a PR comment with all the colab notebooks found in the repo + links w/ badges to open them in colab (from the specific branch)