[BUG] SAML login fails when username contains '\h' due to JwtToken.

What is the bug?
SAML login fails when username contains '\h'. it passes in all other cases such as username containing '\a' or '\x' .
The error is coming from: (https://github.com/opensearch-project/security/blob/main/src/main/java/com/amazon/dlic/auth/http/saml/AuthTokenProcessorHandler.java#319)
We tried logging in using two usernames :

First username had a '\h' in it. We got a 500 internal error with this.
Second username had a '\a' in it. We were able to login using this.

https://github.com/opensearch-project/security/blob/main/src/main/java/com/amazon/dlic/auth/http/saml/AuthTokenProcessorHandler.java#L297 extracts similar jwtSubjectKey for usernames with '\h' and '\a'.
But the encoded JWT at : https://github.com/opensearch-project/security/blob/main/src/main/java/com/amazon/dlic/auth/http/saml/AuthTokenProcessorHandler.java#L319
return different types of values for sub.
For username with '\h', it returns (in encoded form) :
{2 items
"header":{1 item
"alg":"HS512"
}
"payload":{5 items
"nbf":1678363196
"exp":1678366796
"sub":"abcdhhabcd"
"saml_nif":"email"
"saml_si":"318941483"
}
}

For username with '\a', it returns (in encoded form) :
{2 items
"header":{1 item
"alg":"HS512"
}
"payload":{5 items
"nbf":1678363358
"exp":1678366958
"sub":"abcd\ahabcd"
"saml_nif":"email"
"saml_si":"693676161"
}
}

It is still unknown for how many characters will the issue repeat.
How can one reproduce the bug?
Steps to reproduce the behavior:

Create a SAML domain, and try logging in using a username with '\h' and you will see 500 internal error.
Now repeat same thing with '\a' or '\x'. This should work.

What is the expected behavior?
User should be able to login even when username contains '\h'.
What is your host/environment?

OS_1.3

Do you have any screenshots?
If applicable, add screenshots to help explain your problem.
Do you have any additional context?
Add any other context about the problem.

I verified by logging (jwt.getClaims()).getSubject() ) just before jwtProducer.processJwt at https://github.com/opensearch-project/security/blob/main/src/main/java/com/amazon/dlic/auth/http/saml/AuthTokenProcessorHandler.java#L318.
It is giving the correct expected value of username with '\h'. So the issue is with the encodedJwt:
String encodedJwt = this.jwtProducer.processJwt(jwt);

@abhivka7 Thanks for filing and digging in, how would you feel about making a PR to fix this issue?

Currently working on this issue. It seems like String encodedJwt = this.jwtProducer.processJwt(jwt); fails to generate a valid token when the input contains \h, and needs two backslashes \\h in order to work properly to save as one backslash in the JWT structure. Also, there is no way to have an odd number of backslashes more than 1 (like 3, 5, 7 backslashes), as I have tried it manually on the JWT Web Token site from Okta.
Here, you can see that for \h, it is not allowed to have odd numbers of backslashes more than one.
Trying to input the username\\\hexample with 3 backslashes as the saved "sub" (subject) value:

(It is red and quite literally will not create a JWT token)
Trying to input the username\\\\\hexample with 3 backslashes as the saved "sub" value:

(It is also red and refuses to create a JWT token)
A working JWT token with a backslash before h created can only be with one backslash as \h or an even number of backslashes (such as \\\\h), which will be saved as a subject token as \\h. After that, \\\\\\h (6 backslashes) will be saved as \\\\\\h with 6 backslashes, and there is incredibly inconsistent backslash handling after this.
(most likely due to the way how backslashes are treated as escape characters in string literals)
Some examples of this is:

When the username input has 8 backslashes before h, \\\\\\\\h, the JWT token subject value will be processed and saved as \\\\h with 4 backslashes
When the username input has 10 backslashes, the JWT token subject value will have 2 backslashes
And when the username input has 12 backslashes, the JWT token subject value will have 6 backslashes

and so on.....
Since there have been cases where \h is requested to be part of a username, I will be submitting a PR today for when \h is the desired saved JWT token subject value output, and for when \\h is the desired output too, but I would recommend disallowing any more backslashes after that.

Currently working on this issue. It seems like String encodedJwt = this.jwtProducer.processJwt(jwt); fails to generate a valid token when the input contains \h, and needs two backslashes \\h in order to work properly to save as one backslash in the JWT structure. Also, there is no way to have an odd number of backslashes (like 1, 3, 5, 7 backslashes), as I have tried it manually on the JWT Web Token site from Okta.
Here, you can see that for \h, it is not allowed to have odd numbers of backslashes:
Trying to input the username\hexample with 1 backslash as the saved "sub" (subject) value:

(It is red and quite literally will not create a JWT token)
Trying to input the username\\\hexample with 3 backslashes as the saved "sub" (subject) value:

(It is red and will not create a JWT token)
Trying to input the username\\\\\hexample with 5 backslashes as the saved "sub" value:

(It is also red and refuses to create a JWT token)
A working JWT token with a backslash before h can only be created with an even number of backslashes beginning with \\h, which will be saved as \\h.
Then, there is terribly inconsistent backslash handling after this.
Examples:

\\\\h  will be saved as a subject token as \\h
\\\\\\h (6 backslashes) will be saved as \\\\\\h with 6 backslashes
\\\\\\\\h (8 backslashes) will be saved as \\\\h with 4 backslashes
10 backslashes will be saved as 2
and 12 backslashes will be saved as 6

This is most likely due to the way how backslashes are treated as escape characters in string literals.
Since there have been cases where \h is requested to be part of a username, I will be submitting a PR today for \\h, which can be used as an alternative to \h, which  cannot be used to generated a JWT token. I would recommend disallowing any more backslashes after two.

@nancyjlau What is the full error message that String encodedJwt = this.jwtProducer.processJwt(jwt); produces when the subject has \h in it?
Does jax-rs have a general way to escape token claims? Is this only an issue with the sub claim or does this exception get thrown regardless of the claim.
FYI there is a PR to switch the JWT library used in this repo? Do we know if the new library has similar behavior?
Relevant PR: https://github.com/opensearch-project/security/pull/3421

@peternied @cwperks folks is it possible to get more traction for this issue? We do have more requests referring to the same wrong behavior.

@martin-gaievski I think I finally got to the bottom of this. This is an issue with the cxf library that the security plugin uses to issue JWTs for SAML auth.
CXF thinks that \h is a special character that needs to be escaped: https://github.com/apache/cxf/blob/main/rt/rs/extensions/json-basic/src/main/java/org/apache/cxf/jaxrs/json/basic/JsonMapObjectReaderWriter.java#L52
PR where it was introduced: https://github.com/apache/cxf/pull/819/files#diff-3396d540d530ac37f53c476b87ef6fdb86343aa6ff211826418438171e05c764
I can't find an official list of characters that need to be escaped in JSON, but https://stackoverflow.com/a/27516892 seems to indicate that it isn't one. I will open up a PR in cxf to solicit comments.
@reta Fancy seeing you in that codebase! Do you know if h can be removed ESCAPED_CHARS set or if there is documentation about what the \h character is?

Opened a PR in cxf: https://github.com/apache/cxf/pull/1872
I was able to validate that removing h from ESCAPED_CHARS in cxf resolves this issue.
To test I:

Setup OpenSearch with SAML login that contained a user with \h in the username.
Created the jars for cxf: mvn -Pfastinstall,everything
Did a volume mount in docker to override the jars

I've attached the docker configuration below. The user list is configured in saml-demo/config/authsources.php and contains a user user4\hexample:user4pass. Before the change in CXF it fails to login with internal server error and after the change the user is able to login.
2.11.0-saml-plus-basic-multiauth 2.zip

@reta Fancy seeing you in that codebase! Do you know if h can be removed ESCAPED_CHARS set or if there is documentation about what the \h character is?

:-D @cwperks I think this is a typo, h -> n, as per https://datatracker.ietf.org/doc/html/rfc8259#section-7:
 string = quotation-mark *char quotation-mark      char = unescaped /
          escape (
              %x22 /          ; "    quotation mark  U+0022
              %x5C /          ; \    reverse solidus U+005C
              %x2F /          ; /    solidus         U+002F
              %x62 /          ; b    backspace       U+0008
              %x66 /          ; f    form feed       U+000C
              %x6E /          ; n    line feed       U+000A
              %x72 /          ; r    carriage return U+000D
              %x74 /          ; t    tab             U+0009
              %x75 4HEXDIG )  ; uXXXX                U+XXXX
escape = %x5C              ; \
quotation-mark = %x22      ;
unescaped = %x20-21 / %x23-5B / %x5D-10FFFF

Could you open an issue here https://issues.apache.org/jira/projects/CXF/issues? (if not, I could open it on your behalf)

I don't think I have permissions to create an issue. I'll go through the self serve signup page to request an account.

@reta Created an issue: https://issues.apache.org/jira/browse/CXF-9015

Nice! Thanks @cwperks and @reta. @cwperks seems your fix is merged, can we track this on OpenSearch for next release (2.15)?

Nice! Thanks @cwperks and @reta. @cwperks seems your fix is merged, can we track this on OpenSearch for next release (2.15)?

Sure, we would need to have Apache CXF released first, I am not sure it will happen before 2.15.0

@cwperks new releases just landed [1], we should be able to fix this issue in time for 2.16.0, thanks!
[1] https://cxf.apache.org/download.html

@reta Thanks for following up! I will raise PRs on the release branches.

@cwperks Can this issue be closed now?

Yes it can be.


FAQ Update

FAQ Update

[x ] Tested Locally

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65823d18318f7a0d31c286a9--harness-developer.netlify.app


With ens label

Should perhaps also show the label when the user leaves the text box and switches to amount? A better idea?

@hboon A is already done in this PR, if pasting a normal address you won't see anything in the label
B is also basically done but it doesn't have a set point to start resolving, perhaps we wait a few seconds after . is push, to prevent lagging?

Right. A is how it used to work with addresses and it still works the same way with this PR.

@James-Sangalli good for review.


.Net can't run first docker images

Problem encountered on https://dotnet.microsoft.com/en-us/learn/aspnet/microservice-tutorial/run-docker
Operating System: windows
hi all, I can't start my first docker in .net, I followed all the procedure, but every time I run the docker run I get this error.
I tried setting the localhost but nothing changed
Unhandled exception. System.IO.IOException: Failed to bind to address http://[::]:80: address already in use.
---> Microsoft.AspNetCore.Connections.AddressInUseException: Address already in use
---> System.Net.Sockets.SocketException (98): Address already in use
at System.Net.Sockets.Socket.DoBind(EndPoint endPointSnapshot, SocketAddress socketAddress)
at System.Net.Sockets.Socket.Bind(EndPoint localEP)
at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketTransportOptions.CreateDefaultBoundListenSocket(EndPoint endpoint)
at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketConnectionListener.Bind()
--- End of inner exception stack trace ---
at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketConnectionListener.Bind()
at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketTransportFactory.BindAsync(EndPoint endpoint, CancellationToken cancellationToken)
at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure.TransportManager.BindAsync(EndPoint endPoint, ConnectionDelegate connectionDelegate, EndpointConfig endpointConfig, CancellationToken cancellationToken)
at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerImpl.<>c__DisplayClass30_01.<<StartAsync>g__OnBind|0>d.MoveNext() --- End of stack trace from previous location ---    at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindEndpointAsync(ListenOptions endpoint, AddressBindContext context, CancellationToken cancellationToken)    --- End of inner exception stack trace ---    at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindEndpointAsync(ListenOptions endpoint, AddressBindContext context, CancellationToken cancellationToken)    at Microsoft.AspNetCore.Server.Kestrel.Core.ListenOptions.BindAsync(AddressBindContext context, CancellationToken cancellationToken)    at Microsoft.AspNetCore.Server.Kestrel.Core.AnyIPListenOptions.BindAsync(AddressBindContext context, CancellationToken cancellationToken)    at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.AddressesStrategy.BindAsync(AddressBindContext context, CancellationToken cancellationToken)    at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindAsync(IEnumerable1 listenOptions, AddressBindContext context, CancellationToken cancellationToken)
at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerImpl.BindAsync(CancellationToken cancellationToken)
at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerImpl.StartAsync[TContext](IHttpApplication`1 application, CancellationToken cancellationToken)
at Microsoft.AspNetCore.Hosting.GenericWebHostService.StartAsync(CancellationToken cancellationToken)
at Microsoft.Extensions.Hosting.Internal.Host.StartAsync(CancellationToken cancellationToken)
at Microsoft.Extensions.Hosting.HostingAbstractionsHostExtensions.RunAsync(IHost host, CancellationToken token)
at Microsoft.Extensions.Hosting.HostingAbstractionsHostExtensions.RunAsync(IHost host, CancellationToken token)
at Microsoft.Extensions.Hosting.HostingAbstractionsHostExtensions.Run(IHost host)
at Program.$(String[] args) in /src/Program.cs:line 23
someone know how to fix it ?

I know we made some changes to default ports on .NET 8 that made us update the tutorial. Sorry we missed your feedback earlier. Let us know if you're still seeing the issue by following the latest version of the tutorial.


Needs to be corrected. Problems in using bs4 library

https://github.com/ramanshsharma2806/Personal-Bot/blob/406b2aa6ce5e2147f89486e9d448dc7dd8a4cfc9/get_data.py#L81-L90

Resolved


[Feature] Frontend: As an Operator, I can check individual campaign details and update the Status

Clicking on the campaign link in List view opens a detailed view. Visible campaign details are the same from here
with added fields:

documents download (button)
comments (list), with author and date, sorted in descending order by date

Acceptance criteria:

I can download all attached documents and can add a comment
I can also update the status of the campaign from the initial PendingValidation to Approved or Rejected
All available statuses are described here
2.1 In case of Approval, the Payment module needs to be notified, so that payments are open for this campaign
2.2 In case of Rejection, I need to provide a mandatory comment about the rejection reason
If the campaign was in Active state, I can mark it as Completed.
3.1 This should disable further donations on the campaign, so the Payments module needs to be notified

Currently available in Admin view.


Bug Fix: query::rows::get(int, std::string) will return an empty string ...

...when the data of column is empty.

Let me close this request. If you still have an issue, please reopen this.
Thanks.


Problems in reproducing the results in the leaderboard

Hello.
I'm trying to reproduce the results in the leaderboard.
For each model, I run the following script, according to the README.md.
The script is run with python 3.10.15 environment created by anaconda and pip install -r requirements.(and install torch that is not specified in the requirements.txt)
python generate_cov_hf.py --model <model_name> --num_tests 20
python format.py --mode overall --path totalcov_<model_name>.jsonl
python eval_overall.py --path totalcov_<model_name>format.jsonl

Here's my results and comparisons with reported results.
Branch Coverage  | Overall |   | Cov@1 |   | Cov@2 |   | Cov@5 |
-- | -- | -- | -- | -- | -- | -- | -- | --
  | Reported | Reproduced | Reported | Reproduced | Reported | Reproduced | Reported | Reproduced
LLaMa3-8B-Instruct | 89.02 | 77.91 | 69.47 | 59.97 | 73.37 | 64.06 | 79.22 | 69.1
CodeLLaMa-7B-Instruct | 81.56 | 75.78 | 72.28 | 66.77 | 73.96 | 68.43 | 75.9 | 70.61
CodeLLaMa-13B-Instruct | 80.55 | 80.38 | 73.21 | 70.56 | 75.54 | 72.89 | 77.13 | 75.13
CodeLLaMa-34B-Instruct | 83.74 | 83.94 | 71.37 | 71.99 | 74.5 | 74.22 | 77.8 | 78.38
gemma-1.1-7b-it | 91.46 | 90.52 | 67.15 | 66.09 | 72.94 | 72.76 | 90.29 | 79.69
CodeQwen1.5-7B-Chat | 86.9 | 83.68 | 77.66 | 77.27 | 78.94 | 78.29 | 80.95 | 79.38
DeepSeek-Coder-1.3B-instruct | 75.99 | 75.18 | 69.06 | 70.07 | 69.9 | 70.34 | 70.7 | 70.94
DeepSeek-Coder-6.7B-instruct | 91.6 | 93.29 | 75.29 | 75.19 | 78.73 | 79.12 | 83.46 | 84.26
Line Coverage  | Overall |   | Cov@1 |   | Cov@2 |   | Cov@5 |
-- | -- | -- | -- | -- | -- | -- | -- | --
  | Reported | Reproduced | Reported | Reproduced | Reported | Reproduced | Reported | Reproduced
LLaMa3-8B-Instruct | 90.98 | 80.34 | 77.4 | 68.66 | 80.08 | 71.35 | 84.42 | 74.78
CodeLLaMa-7B-Instruct | 86.09 | 81.02 | 79.46 | 74.97 | 80.72 | 76.08 | 82.04 | 77.59
CodeLLaMa-13B-Instruct | 85.66 | 86.22 | 80.49 | 79.84 | 82.26 | 81.5 | 83.44 | 82.91
CodeLLaMa-34B-Instruct | 87.96 | 88.92 | 78.83 | 80.86 | 81.25 | 82.48 | 83.71 | 85.23
gemma-1.1-7b-it | 93.16 | 93.05 | 76.23 | 76.64 | 80.54 | 81.43 | 85.9 | 85.99
CodeQwen1.5-7B-Chat | 90.73 | 89.31 | 84.53 | 85.42 | 85.33 | 86.05 | 86.71 | 86.75
DeepSeek-Coder-1.3B-instruct | 81.22 | 81.09 | 75.89 | 77.59 | 76.5 | 77.78 | 77.09 | 78.2
DeepSeek-Coder-6.7B-instruct | 93.48 | 95.27 | 82.4 | 83.92 | 84.74 | 86.48 | 87.97 | 89.84
I checked that the generation result is deterministic. So I think it should reproduce exactly same score with the reported results in the leaderboard. But they are different.
For some models like LLaMa3-8B and CodeLLaMa-7B, the difference is significant.
For gemma-1.1-7b-it model, overall branch coverage is similar but cov@5 is significantly low than the reported score.
Could you provide exact command, arguments and library versions to reproduce the results in the leaderboard?
Thank you very much for your time and assistance.

Hello, sorry to get in here but how did you get the results. for me i only got Syntax correctness, i don't know why, i didn't change the code. could you maybe share the json files of the generated tests or at least the formatted one or even a snippet to compare to mine? Only for deepseek-coder-1.3b-instruct since i'm only running this. I'm really at my ends witt.

deepseek.tar.gz
It seems that your evaluation is ended too fast. It takes quite long time for my case(for running coverage command and compute cov@k for each case)
Running the test code can be exited unexpectedly by the time limit or memory limit, so that the coverage won't be evaluated correctly. I think evaluating it with more memory and adjusting time limit may helpful.


When completed, make sure all of the migrated features and work are well documented in the commit log

Hi, excited to contribute in this project.

Hi Guys
Excited to work on this project.


Adding asynchronous features to harness

Most of the setter functions are not asynchronous. This is not desirable because we often have use cases for using asynchronous code (ie: fetch requests) within beforeSet/afterSet functions as well as loadData itself.

[ ] Make setFilter async
[ ] Make loadData async
[ ] Make setChartData async
[ ] Ensure that all of the above wait on their respective before/after set functions

After realizing that making certain function async would not allow us to await a subscription relative to the trigger we decided to go with a different approach. Alex specified:

what if HVB just ran setFilter, and harness itself had the check for synchronous and running of loadData? if so, we formalize the synchronous behavior instead of having that be a side effect of the component package. and if we do, we can put that check into the subscription block so that it explicitly runs after user-defined afterSet behaviors

we’d be altering the subscribeActions function in here: https://github.com/RTIInternational/harness-vue/blob/main/src/store/subscriptions.js
so that in before we would await runSubscriptions, and in after we would await runSubscriptions, then add a check that looks for setFilter with synchronous set to false and then await loadData


Update UG and own PPP

Update UG for changes to new methods added -> findstatus and findclasscode
Update own PPP to record new changes

Great change to reflect updated command strings.


[reggen] We are discarding data integrity from windows in reg_top modules

The generated reg_top modules unconditionally use a tlul_rsp_intg_gen instance to add response integrity (fine!) and data integrity (oh no!) bits to all responses. Including those that come from memory windows.
This discards the stuff that we thought we were passing through. Oops! See #9537 which describes this happening for rom_ctrl. It also happens for (at least) OTBN.

@tjaychen, @msfschaffner: I'm going to scramble to sort out the rom_ctrl version of this (which currently makes fixing this awkward). But I think we probably need to figure out a nice way to handle it in the reg_top modules.
Maybe it's as simple as muxing the d_user.data_intg field of tl_o between tl_o_pre and some newly named output from the integrity generator? Or maybe it would be cleaner to add a passthru_i input to tlul_rsp_intg_gen which we could set when the data came from a window? Or maybe we should unconditionally pass the data integrity through and add it explicitly on the register side? Not sure what would be better.

@rswarbrick i commented in one of your PRs.. hehe
This again is an issue of me and documentation... hope to fix soon.
This option that otbn is using in theory should address this on the windowed connections.
https://github.com/lowRISC/opentitan/blob/master/hw/ip/otbn/data/otbn.hjson#L493
Let me know if it resolves what you're seeing.

Yeah, this was user error on my part. Thank goodness!


Details of the finetuning settings for the LIBERO task

In the "Launching LIBERO Evaluations" section, could you please provide the details about the finetuning process for the four tasks on the LIBERO task? For example, the number of epochs, batch size, iteration steps, etc.? The success rate of our self-finetuned results has been very low. 😭

I saw that the settings of batch size and iteration steps are explained in the readme of the official ckpt website link, and the other settings are from the default script of LoRA finetuning.

OpenVLA 7B Fine-Tuned on LIBERO-Spatial
We fine-tuned OpenVLA with batch size 128 for 50K gradient steps using 8 A100 GPUs.

OpenVLA 7B Fine-Tuned on LIBERO-Object
We fine-tuned OpenVLA with batch size 128 for 50K gradient steps using 8 A100 GPUs.

OpenVLA 7B Fine-Tuned on LIBERO-Goal
We fine-tuned OpenVLA with batch size 128 for 60K gradient steps using 8 A100 GPUs.

OpenVLA 7B Fine-Tuned on LIBERO-10 (LIBERO-Long)
We fine-tuned OpenVLA with batch size 128 for 80K gradient steps using 8 A100 GPUs.

Both
We applied random crop and color jitter image augmentations during training (therefore, center cropping should be applied at inference time.

soso thx!

Have you reproduced the LIBERO simulation experiment? I set the batch size to be 32, and keep the default settings in fintune.py. With 50K updates, the accuracy was still below 50% for the LIBERO-goal task.
Tried twice and not tested other tasks.

Have you reproduced the LIBERO simulation experiment? I set the batch size to be 32, and kept the default settings in fintune.py. With 50K updates, the accuracy was still below 50% for the LIBERO-goal task. Tried twice and not tested other tasks.

I finetuned both the object and spatial datasets, but neither achieved the results in the paper. Here are my settings

ckpts  from https://huggingface.co/openvla/openvla-7b/tree/main
dataset from https://huggingface.co/datasets/openvla/modified_libero_rlds/tree/main
8 x A100(80G)
batch_size=16 (16x8=128)
learning_rate= 2e-5
grad_accumulation_steps=1
image_aug=True
lora_rank=32
lora_dropout=0.0
use_quantization=False
Python 3.10.13, PyTorch 2.2.0, transformers 4.40.1, and flash-attn 2.5.5
Tested using ckpt with step=60k

Task
Test Type
Success Rate
Number of Trials

Object
Official ckpt
82.2%
101

Object
My ckpt
5.4%
37

Spatial
Official ckpt
91.6%
178

Spatial
My ckpt
50.8%
60

I noticed that most of the failures were caused by the robot arm not moving.

I think I found solution. My codebase is not updated to the latest version. The latest version of the code seems to have added processing for empty tokens.

I am also struggling to reproduce the results of finetuning on Libero dataset. My results are very comparable with @Talnex (same node setup and parameters used). Were there any additional modifications applied to the code/data that are not mentioned in the paper?

UPDATE Solved the plateau issue by increasing the learning rate to 1e-4. Would be interesting to know the official parameter used for the results reported in the paper.

Hi everyone (@jiayueru @Talnex @zhaoyu775885 @rokas-bendikas),
Below are the hyperparameters we used for all LIBERO experiments:

Hardware: 8 x A100 GPUs with 80GB memory, for every checkpoint
Fine-tuned with LoRA: use_lora == True, lora_rank == 32, lora_dropout == 0.0
Learning rate: 5e-4
Batch size: 128 (8 GPUs x 16 samples each)
Number of training gradient steps: 50K for LIBERO-Spatial, 50K for LIBERO-Object, 60K for LIBERO-Goal, 80K for LIBERO-10 (in general, we fine-tuned until action token accuracy stabilized at ~100% with image augmentations enabled)
No quantization at train or test time
No gradient accumulation (i.e. grad_accumulation_steps == 1)
shuffle_buffer_size == 100_000

We'll update the model cards on Hugging Face to include these extra details!
-Moo Jin

Hi @Talnex, i'm also experiencing similar issue. Did you solve this problem??

Hi @Talnex, @rokas-bendikas, i'm also experiencing similar issue. Did you guys solve this issue??

I used full fine-tuning to reproduce the effect. The training accuracy can reach 98%+

task
ckpt
ft setting
test setting
success rate

spatial
paper
aug-2e-5-bs128
aug-50K
84.7 ± 0.9%

spatial
official-lora
aug-2e-5-bs128
aug-50K
83.4%

spatial
full-ft
aug-2e-5-bs128
aug-10K
77.4%

task
ckpt
ft setting
test setting
success rate

object
paper
aug-2e-5-bs128
aug-50K
88.4 ± 0.8%

object
official-lora
aug-2e-5-bs128
aug-50K
85.8%

object
full-ft
aug-2e-5-bs128
aug-50K
85.6%

task
ckpt
ft setting
test setting
success rate

goal
paper
aug-2e-5-bs128
aug-60K
79.2 ± 1.0%

goal
official-lora
aug-2e-5-bs128
aug-60K
77.4%

goal
full-ft
aug-2e-5-bs128
aug-30K
72.0%

task
ckpt
ft setting
test setting
success rate

long
paper
aug-2e-5-bs128
aug-80K
53.7 ± 1.3%

long
official-lora
aug-2e-5-bs128
aug-80K
54.0%

long
full-ft
aug-2e-5-bs128
aug-80K
46.6%

The ckpt of full fine-tuning is closer to the official ckpt result than Lora fineture. Goal  and object  task is comparable.
At the same time, I found that the ckpt I trained was not necessarily the best performance at the corresponding step.
I used osmesa as a virtual display for rendering LIBERO. :)


Fix broken link in README

link to Pivotal blog had changed

Closing, as this project appears to be unmaintained


[New game]: heal the world

🎮 Game Request
It's a very meaningful game.
There will be some troubles in the world.
You need to remember what they need and give them cure.
Then you healed the world.
Point down the features
The more you heal the more you score
Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @S-ishita !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

Hey @S-ishita ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


ContractLocalCallTransitionLogic

The current ContractLocalCallTransitionLogic is "stitched" together just so that we can test the Besu Integration.
We must refactor the transition logic with the new refactored model. For reference see Token Mint/Burn/Wipe in hedera master.

Requires additional discussion for the implementation. To be estimated afterwards


When exact match for value

So, when pasting in a purpose code like 00, you have to wait for it to find it then select the value.
If someone just pastes in a value like 99 then tabs off the field, it should accept that value.
This would also apply to some or all of the other fields.
Currently, if it finds it, you can then tab off to populate it, but you have to wait.

Seems like it is working now


fix!: Allow @event usage with a name argument

This PR allows inserting a name into the event decorator.
Checklist

[x] I've ran pre-commit to format and lint the change(s) made.
[x] I've checked to make sure the change(s) work on 3.8.6 and higher.
[ ] This fixes/solves an Issue.

(If existent): #717

[ ] I've made this pull request for/as: (check all that apply)

[ ] Documentation
[ ] Breaking change
[ ] New feature/enhancement
[x] Bugfix

Do we really need the coroutine to be optional? We'll always expect it to be there when registering an event for dispatch.

It is always there. It just has to be optional, so you can do @bot.event. Keeping it not optional locks the name arg, removing the coro argument forces you to always do @bot.event().
No matter how the decorator is used, the coro will always be present. Keeping it optional just improves UX


TypeScript 3.7+ regression issue in Lerna monorepo w/ Yarn Workspaces and composite projects

TypeScript Version:  3.7.3
Node Version: 12.13.1

Search Terms: lerna, monorepo, yarn, workspaces
Problem Description:
TypeScript 3.7+ seems to have issues in a Lerna monorepo using yarn workspaces. TypeScript 3.6.4 does not exhibit the same problem.  In the example repo (https://github.com/amirburbea/ts-37-issue), there are two projects @issue/utilities and @issues/server.
@issue/utilities is a typescript composite library. For the purpose of keeping it simple, this project exports a single default function - but I experienced this issue in a signficantly larger project with named exports.
@issue/server is a node application that invokes the function exported in @issue/utilities.
There are several scripts you can run at the root when testing which will save a great deal of time

yarn build: Instructs typescript to build the projects.
yarn clean: Instructs every project to delete their build outputs and tsconfig.tsbuildinfo
yarn rebuild: Runs clean and then build
yarn start: Runs build and then starts the output of @issue/server

In general, both in TypeScript 3.6.4 and TypeScript 3.7.3, the code will transpile and afterwards, run identically.
The issue is in the editing experience. If you build and then open the file packages/server/src/index.ts in VS Code, typescript initializes, and when that process is complete hovering over line 4 run(); will show that intellisense has an understanding of the exported function from @issue/utilities.

Now simply add a blank line at the end of the file - TypeScript will suddenly not understand the import of @issue/utilities (the import will have squiggly red lines under it and the type will be unknown) until I again reload the window making editing a painful experience. I experienced this in both Visual Studio Code <IP_ADDRESS> and Visual Studio 2019 16.4.2 almost identically.

I upgraded the two package.json to use typescript 3.8 daily build and got the same error. I downgrade them to use typescript 3.6.4 and the issue goes away.
As an FYI, my own project structure (which this example repo mirrors) is based on a sample posted by @DanielRosenwasser when composite was first introduced, but I'm happy to make changes to my tsconfig files if someone can suggest a workaround.

Not only does lerna connect the references by a simlink, but the node_modules folder is at the repository root (and not at each project level) - I wonder if somehow that's what's breaking typescript.

Actually I'm able to get this to stop breaking with a workaround suggested by @AlexChi who said I should add a baseUrl and paths to the @issues/server tsconfig.  I guess I'm willing to do that, but it seems unnecessarily verbose.
{
  "compilerOptions": {
    "outDir": "lib",
    "rootDir": "src",
    "baseUrl": "../../",
    "paths": { "@issue/utilities": ["packages/utilities"] }
  },
  "exclude": ["./lib/", "./node_modules/"],
  "extends": "../tsconfig.base.json",
  "references": [{ "path": "../utilities" }]
}

Note that this issue repros only when preserveSymlinks is set to true

Does this mean that in TS3.8 this will work without me specifically putting in the baseUrl/paths?


⚠ SceneTime has degraded performance

In 972c168, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 14600 ms

Resolved: SceneTime performance has improved in 594d9fa.


Don't Merge! PR real time test for webhook case

Docs Build status updates of commit a063112:
:clock10: Pending: waiting for processors (21 builds ahead of you)
:warning: Docs Build is busy, currently there are 21 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit a063112:
:clock10: Full build: the average full build time is 7 min(s) 37 sec(s), this is based on the last 30 build(s) for this repository.

Docs Build status updates of commit a063112:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/testing.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


chore: cherry pick get history always return empty array

Description
cherry pick get history always return empty array
Task Item

Screenshots

Looks good to me, but let's leave this until @tonyanziano get a chance to confirm this.


json only house spawn

peculia:json_only_house is a structure which spawns in certain biomes like forest, plains and deserts and etc, it spawns very frequently, so much so that you can find 3 of them in the same area
it seems that this structure isn't supposed to be an actual structure that spawns in the mod

Hi!
I  dont know how that slipped through the cracks with whatever release you had gotten (are you using the unfinished snapshot on the discord? that may do it!) But you are absolutely correct. I was using a tutorial file as reference for how structure files work, to understand it better and it may have persisted through one of the snapshot releases.
Just to make sure is this version from the discord server or from the curseforge page? Thank you!

(No I was using the latest version on the curseforge), I understand it's reference, it's alright, we all make mistakes

I see. Ill put a fix out on CurseForge later today, but for the meantime-- the discord server does have a snapshot of the new Peculia version, and that bug is fixed there--if you still want to play the mod without those pesky houses


[WIP] Use and test KafkaSource v1 API

Replace usages of v1beta1 KafkaSource to v1 KafkaSource
Part of https://github.com/knative-extensions/eventing-kafka-broker/issues/3953

/retest-required

This can be merged only after 1.16 is out

/retest

/retest


Slow Helper warning

Is it possible to improve the helper timing? someone suggested on ghost blog to improve helper timing for overall performance.

I'm not sure about this, I'm doing that following the recommendation from the docs:

The most effective way to show posts that are related by topic in your related posts block is to filter by tag. For example:
https://ghost.org/tutorials/related-posts-block/

{{#get "posts" limit="5" filter="tags:[{{post.tags}}]+id:-{{post.id}}" include="tags" as |related|}}
{{/get}}

The only difference is that I include the authors since I need this data to display the author info.
I would say the number of tags also has to do something with that timing, probably with less tags would be a bit faster. Also maybe there are another factors like the database and server environments 🤔 .
You can try to edit the file post.hbs and replace the line above with this one:
{{#get "posts" limit="5" filter="tags:[{{post.primary_tag}}]+id:-{{post.id}}" include="tags" as |related|}}

I'm not sure if it actually works or not but the idea is to filter just by the primary tag instead of filter by all the tags.


Setup test coverage

Depends on #7 or it will be a shame to show
https://github.com/codecov/example-android
Setup badge to readme

Will not be totally valid, because Espresso tests still cannot run on Travis


Typescript language service died unexpectedly 5 times in the last 5 minutes

VSCode Version: Code 1.9.1 (f9d0c687ff2ea7aabd85fb9a43129117c0ecf519, 2017-02-09T00:26:45.394Z)
OS Version: Windows_NT ia32 6.3.9600
Extensions:

Extension
Author
Version

python
donjayamanne
0.5.8

Angular1
johnpapa
0.1.16

net-core-project-manager
ksubedi
0.3.6

csharp
ms-vscode
1.7.0

java
redhat
0.0.10

Steps to Reproduce:

Please upgrade to VSCode 1.10.2+. The release fixed several important bugs in 1.9


Use entire class name of message instead of short name

This is helpful when messages have FQCNs like Acme\MessageQueue\EmailSender\Message. The short name is simply Message which is super not-helpful. So my change now uses the full class name.

The example makes perfect sense 👍. Thank you!


I'm able to edit someone else's comment on my PR

What happened:
When clicking into the 3-dot menu on a comment on my PR, I had the option to edit the comment, which I didn't write. This feels like it's a bug, as I don't remember being able to do that in the past.
More info:
https://user-images.githubusercontent.com/14898887/137210236-ab80dc47-185d-4980-9133-d4106da0109e.mov

Hi, I believe this is a question about GitHub.com, the website. This issue tracker is for a command-line utility called hub, not the website itself. For reporting bugs and requesting features for GitHub the website, please go to https://github.com/contact or visit https://github.community. Thank you!


Refactor talk view action to Illuminate

This PR makes the talk view action in the admins controller use Illuminate instead of spot.
This was a bit more intensive then initially expected, so this PR includes all the following changes as well

New functions in the TalkMeta and User model
Admin Talks Controller Test now uses our own test case as a base class, plus some changes to make this work
Put the Database Test Case in a trait, so it can be used in combination with our normal test case. Plus changes to the classes that originally extended the Database Test case to make them work again.
A few small changes to templates to accommodate the changes from spot to illuminate.
Added an asAdmin function to the base testcase which does the sentry mocking for us.

Using the database in our tests does slow it down a bit, but if we keep the amount of DB interaction to a minimum it might still be faster than using the overload: functionality in Mockery. Plus it makes the tests a lot smaller and a lot more readable.
Related to #506 .

Thanks @BackEndTea


Which version of QuestEval did you use?

I guess QuestEval implementation by the authors (repo) is used in this code.
Can I ask which version (commit id) you used for your result?
https://github.com/tingofurro/summac/blob/53fae37bbdd3995c50b50a2713d196680966c765/model_baseline.py#L17

Hey Ryo,
You are correct, we used the implementation from the official Github repo for the QuestEval comparison: https://github.com/ThomasScialom/QuestEval
I unfortunately don't have access to the machine anymore (the machine I used in Berkeley), but I ran experiment in mid-July, so I asssume from the Github history that it was either version 0.2.0 or 0.2.4.
I would hope however that the results would not be affected by the QuestEval version. Are you noticing discrepancies?

Hi Laban,
Thank you for your kind reply!
Honestly, I have not tried your code yet.
However, the README of the QuestEval repository says the code has changed from the paper and I observed some differences from the older version.
https://github.com/ThomasScialom/QuestEval/blob/main/README.md#summarization
I will try on 0.2.0 or 0.2.4 to reproduce your results.


release keys when xfreerdp is unfocused to prevent stuck keys

fixes issue #2104

This also happens on Windows, so another fix is needed for that too.

@freerdp-bot test

Like @ismail, I can confirm that this (still) is a bug in Windows.


Sticky component doesn't honor data-sticky-on attribute

How to reproduce this bug:

Create a layout with sticky elements in accordance with the sticky component examples in the docs
Set data-sticky-on="large" attribute on sticky elements

What should happen:
elements should only be sticky on large and all dom manipulations associated with the sticky component should not be applied on screen sizes smaller than the one specified in the data-sticky-on attribute.
What happened instead:
It seems like it's trying to work but there are lots of side effects and it's highly prone to jank. dom manipulations continue to occur on screens smaller than the one specified which can result in overlapping elements, disappearing elements, and other jankiness.
Test case:
Here's a codepen that demonstrates the problem.
This layout includes left nav, a main content area, and a right nav and utilizes source ordering and sticky sidebars.
On mobile: Main content is full width, Left nav and Right nav are positioned below main content
On medium: source ordering kicks in and moves the sticky left nav to the left of main content, right nav stays at the bottom
On large: left nav is sticky, main content scrolls, right nav is sticky
For reference, here's the same codepen without the sticky classes to demonstrate that the layot itself (i.e. the source ordering) is behaving as expected.
I hope the issue here is that I'm just not using the data-sticky-on properly :)

Are these working correctly for you:
Foundation.MediaQuery.is("medium")
Foundation.MediaQuery.is("large")

@dragthor in what context? Everything's working fine with the exception, it seems, of the data-sticky-on attribute listed in the docs. If you set data-sticky-on to large, then the sticky component should only manipulate the element on large screens and greater but, as the codepen demonstrates, it continues to make changes to the dom on smaller screens. So to answer your question to the best of my understanding, yes, everything breakpoint-related is working properly; the only thing not behaving as expected is that data-sticky-on attribute.

Same issue here as described above.  Imma pour into the JS but might be in way over my head.
@gpspake know if there are js 'hooks' or some kind of Foundation guideline for isolating JS issues or error reporting?

Same issue here, set data-sticky-on to large but the plugin still set a value to css property "height" on small and medium media queries.

I am also having this issue, when I set data-sticky-on="medium", when on a mobile sized screen, the plugin runs, but sets a top value of 10015.6px ( about the height of my screen ).  This pushed the  to the bottom of my page, and I get classes add:
"sticky is-anchored is-at-bottom"
If I set data-sticky-on="small", it is sticky and works as expected on mobile, but I really don't want a sticky on mobile.
Full option set:

NOTE: this only happens when the page loads at some place other than the top.  For instance, if you scroll down part way / all the way, and refresh, or scroll down -> click a link to a new page then go back.  If you are at the top of the page, the  stays in the correct position, but clicking the back button is such a common behavior, I can't let this go into production.  Tested on Android 6.x and Chrome dev tools.

@scottsawyer, I have the same issue with a site I'm building. Everything functions fine until you refresh the page on a non-large screen from anywhere but page top. Then the contents of data-sticky-container move to the bottom of the page and looking like they disappear.
I can't put this site into production without a patch. I've dug into the CSS and JS a bit but it's over my head. Any word on whether Zurb is working on this?

Would like to get this fixed for 6.4 (roughly 1 month out). @colin-marshall can you take a look, or shall I?

(assuming the fix doesn't require major restructuring we'll also backport it for a 6.3.2 patch)

@kball Thanks for the quick update. Please let us know if it will require a major restructure so we can hack around it.

Experiencing the same behavior that @Ateker is experiencing; refresh on non-large screen when scrolled down the page, the sticky element drops near the bottom of the page with the 'top' css declaration.
Guess it is not quite correctly interpreting the position of the element specified in 'data-top-anchor="element_id:bottom"

Still buggy 😄 Just came into it.

@dobromir-hristov implementing another grid system was more important than fixing bugs... this tells me a lot about the future of Foundation... http://foundation.zurb.com/forum/posts/38374-so-long-and-farewell

Yes - Sticky hasn't been consistent since v5. Getting really inconsistent results with it - even when implementing it using just the example code. (which is not that useful).

On a side note (I didn't want to open another issue):
Using Zurb Template, building for production, Sticky won't work unless you set ".sticky" on UNCSS options on the config.yml file.
Lost 40 minutes debugging this.

As a workaround, put this into app.js:
if (!Foundation.MediaQuery.atLeast('large')) {
  $('.sticky').foundation('_destroy');
}

@gandalfar  i did something like this:
$(function($) {
    $(document).foundation();

    if(!Foundation.MediaQuery.atLeast('large')) {
        $('.sticky').foundation('destroy');
    }
});

But it did break some JS components like the MediaQuery for code after this part, does the underscore before destroy makes a difference ?

@sveetch It looks like destroy (and _destroy) incorrectly removes all JS plugins. There's probably another ticket for this somewhere.

Sticky seems to be very buggy in Foundation 6.4.1  I 'm creating a header with titelbar, topbar, dropdown menu (drilldown on mobile). This is my code..
`

Home
Over ons
Corian®
Jobs
Service
Contact
 |

              keuken
              badkamer
              interieur
              totaalconcept
              professional

`
With this code, the titlebar is not sticky on mobile. The only way i got this to work is by adding some javascript, but it's not beautiful on mobile cause the sticky region is 'flickering' becaus everytime the user scrolls, the javascript is executed to keep everything in place. This is the javascript.
`function fix_scroll() {
  var s = $(window).scrollTop();
  var fixedTitle = $('.sticky');
  fixedTitle.css('position','absolute');
  fixedTitle.css('top',s + 'px');
}fix_scroll();
$(window).on('scroll',fix_scroll); `

I'm using Foundation 6.3.1 and have been fighting the issue described by @scottsawyer and @Ateker. Specifically, the one where the sticky element loads partway (or all the way) down the page on refresh or when navigating to another page and going back.
It's inconsistent, which makes me think it has to do with the loading order. Foundation as a whole is typically initialized before $(document).ready(), but some plugins—like Sticky—clearly need to know the position of everything before they initialize, otherwise stuff like this is going to happen. I suspect the plugin is not waiting, which is causing this mess.
I started out just destroying the sticky things on page load when the screen is small (@gandalfar's tip), but then they need to be reinitialized if the screen size increases (think rotating a device to portrait and back). Programmatically initializing sticky things has its own problem (#10505), which can be solved by manually triggering load.zf.sticky but then the console gets littered with errors and that's yucky.
So, a workaround:
I noticed a couple of sticky.zf.unstuckfrom:top events fire on refresh, and whenever it bugs out there's also a single sticky.zf.unstuckfrom:bottom (Note that none of this should be happening, since this is a small screen and stickyOn defaults to medium, but I digress). So, just listen for that buggy event to fire and remove the offending classes and styles from the sticky thing, which should put it back to its starting position.
// Prevent small screen page refresh sticky bug
$(window).on('sticky.zf.unstuckfrom:bottom', function(e) {
  if (!Foundation.MediaQuery.atLeast('medium')) {
    $(e.target).removeClass('is-anchored is-at-bottom').attr('style', '');
  }
});

If you have some custom inline styles (like width:100%) you may want to remove just the top style instead of wiping them all out.

You can disable the sticky module by using server side mobile detection.
https://github.com/serbanghita/Mobile-Detect
Just leave out the sticky data-tags if it is mobile.

are they ever going to fix this issue ? though thr are some other issue with sticky class !

in 6.4.3 sticky is working as expected

not for me ..  using 6.4.4-rc1

Also the issue exists in 6.4.3. On small and medium sticky is still activated with data-sticky-on="large".

strange... this one's made with 6.4.3 ....
https://vdidesign.be

@guyvanbael sticky works well if set for both mobile and desktop not so well if you want to set just for desktop.
Also I have site where left sticky sidebar overflow footer area sometime.

I'm using 6.4.4-rc1 and it is still an issue.  I needed the element to be sticky on anything large or above.
Solution that worked for me:
A slight variation from the solution of @yorb
`
$(window).on('sticky.zf.unstuckfrom:bottom', function(e) {
if (Foundation.MediaQuery.atLeast('medium')) {
$(e.target).removeClass('is-anchored is-at-bottom').attr('style', '');
}
});
`

This is twice now in one project that I've thought that a sticky element would be nice to have and tried implementing it, only to find that the responsive aspect is broken. le sigh

I'm also using 6.4.4-rc1 and still running into this issue. Using _destory doesn't work either since I have a modal window being launched from the sticky and this removes this as well.
I only needed an element to be sticky on large and this did it. For some reason medium down did not work for me and I had to use the OR operator.
$(window).on('sticky.zf.unstuckfrom:bottom', function(e) {
		if (Foundation.MediaQuery.atLeast('medium') || Foundation.MediaQuery.atLeast('small')) {
			$(e.target).removeClass('is-anchored is-at-bottom').attr('style', '');
		}
	});

Please clone the current develop branch, rebuild using gulp and try thr generated dist files.
Can you also provide a codepen which reproduces the issue so we can test it?

I'm on 6.4.3 and I want to have sticky elements only for medium+ screens. Here is how I achieved it:
if (Foundation.MediaQuery.is('small')) {
  $('.sticky').removeAttr('data-sticky');
}
$(document).foundation();

6.5.3 and sticky is still buggy as described .

Yeah i can confirm, i'm in 6.5.3 and still have this issue

This issue has cost us lots of dev hours to circumvent. Still an issue in 6.5

6.4.3 is outdated and there were many issues fixed in the latest releases.

Can you also provide a codepen which reproduces the issue so we can test it?

Can you also provide a codepen which reproduces the issue so we can test it?

I've updated our version of Foundation to 6.4.3 but unfortunately the issue remains. In our case, we have two elements (navigation menu and gutter) which we want to be sticky at the large viewport only. However, when viewing our site at smaller viewports all the sticky classes are active despite having added the data-sticky-on="large" attribute.
As per your request I've created a codepen for this: https://codepen.io/rarest/pen/yLLJKrM

Upgrading to v6.4.3 fixed the data-sticky-on issue for me. However, I think many people ending up here are experiencing a problems with the sticky elements appearing at the bottom of the page as I was.
This bug has been documented and there are workarounds available here: https://github.com/foundation/foundation-sites/issues/11098

Hej guys,
I'm using foundation 6.5.1 and all is working fine except on mobile, when I first load the page (removing the cache) it works well (it sticks and when changing orientation from portrait to landscape, it expands well to full width, but when reloading the page second time, it only sticks the first height of my page, then it diseapears (roll up) and doesn't expand to full width when changing orientation from portrait to landscape.
Does anyone have a good solution for that please ? @Defiled you says to add sticky classes manually, when please ?
Thanks for reading,

Can anyone else confirm that they still see this issue occurring using v6.6.1? I seem to be encountering the same issue using the latest Foundation release so just wanted to check if others still see this occurring. I've worked around it for now using Yorb's code from his comment above: https://github.com/foundation/foundation-sites/issues/9892#issuecomment-322878472

yes. 6.6.3 - still expieriencing that issue...

Can anyone else confirm that they still see this issue occurring using v6.6.1? I seem to be encountering the same issue using the latest Foundation release so just wanted to check if others still see this occurring. I've worked around it for now using Yorb's code from his comment above: #9892 (comment)


Multiple rules for the same class not being merged

Hi,
I've tried out the first example shown on the front page of this site - whilst atcss is compiling, it isn't producing the output I would expect to see?
I've used both atcss at a command prompt level, and as a gulp plugin - on a Windows environment, I get this output:
.imprt {
  color: blue;
}

.class {
  /*
   * @base
   * @constant
   */
  font-size: 12px;
  padding: 8px 16px;
}

.too-long-and-ugly-selector-name {
  /*
   * @base
   */
  color: red;
}

.class {
  /*
   * @use .base-1
   */
  background-color: green;
}

.too-long-and-ugly-selector-name {
  /*
   * @use .base-2
   */
  margin: 10px;
}

..which doesn't match the output on the front page of this site, where the .too-long-and-ugly-selector-name class rules are clearly shown as having been merged into one rule. Can you please confirm which is expected behavior?

It dose not reproduce in my environment (Mac OS X 10.10, Node v4.2.3, atcss v2.0.0). Sorry, I don't have any windows machines. Can you tell me your Node and atcss versions?

No problem - I downloaded the current release of atcss that is available from this site; my version of Node is 4.1.1, with NPM at version 3.5.3.
If it is not reproducible, and given I have a slightly older version of Node, is it worth me upgrading to see if this fixes the issue?

I've tried updating to the latest version of Node (4.2.6) - unfortunately the result is still the same for me; it isn't merging the two instances of the ".too-long-and-ugly-selector-name" rule into one.

@alexlibby I just released css-annotation v0.6.2, a dependency module of atcss. Please re-install atcss and confirm again.

Sorry - it's still the same for me: it is not merging the rules together.
I had to reinstall both atcss and gulp-atcss before I could get any compilation to complete. I got an warning around fsevents, which I've seen before - I understand that this relates to adding code that is Mac-specific; is it possible this may be causing an issue? The text of the warning is this:
npm WARN optional Skipping failed optional dependency /chokidar/fsevents:
npm WARN notsup Not compatible with your operating system or architecture: fseve
<EMAIL_ADDRESS>npm WARN enoent ENOENT: no such file or directory, open 'C:\wamp\www\postcss\nod
e_modules\cls\package.json'
npm WARN enoent ENOENT: no such file or directory, open 'C:\wamp\www\postcss\nod
e_modules\cosmiconfig\package.json'
npm WARN<EMAIL_ADDRESS>No repository field.

Not sure if this has any bearing on the issue, but thought it best you be aware...
EDIT: A question - once code is compiled, would you expect to see the comments still appear? Granted, I understand why they are required for compilation, but once the code is compiled, do they actually serve any purpose?

@alexlibby That's the good question for cssnano. It purges all comments and extraneous whitespaces from CSS.


Upgrading YAPF to version 0.14.0

This change is

Coverage remained the same at 85.714% when pulling 5a75011cb9aeeed66c5de624118704a83ad9a988 on mtlynch:yapf-upgrade into 8932bc49a1eebfdc60757f059850363f2e6a4761 on JeetShetty:master.


Times are always shown in UTC despite different local timezone configured on system

I'm using this on Ubuntu 22.04 with my local timezone set to CEST:
$ date
Mo 8. Mai 18:13:43 CEST 2023

Nonetheless, all times printed by watson log are shown in UTC (without saying that that's what it is, which makes it even more confusing, but that's a separate issue). I think this is a bug because anyone would reasonably expect human-readable times output by a tool like this to be in local time.
What's even weirder is that times manually added via watson add are understood to be in local time, as evidenced by being shifted by UTC-CEST from their numeric input values in the log output. So it's really just the output that's the issue.
Related (but not the same because it's asking for anything other than local time to be possible): #391
Version info
$ watson --version
Watson, version 2.1.0

The TZ="Europe/Paris" workaround works, thank you!
Here is my timedatectl output:
$ timedatectl
               Local time: Mo 2023-05-08 20:44:48 CEST
           Universal time: Mo 2023-05-08 18:44:48 UTC
                 RTC time: Mo 2023-05-08 18:44:48
                Time zone: Europe/Berlin (CEST, +0200)
System clock synchronized: yes
              NTP service: active
          RTC in local TZ: no


chore: add google form submission link

This pr adds the project submission form to the about page.

📝Changed routes:

/about

(view full size)

Commit 816aea6884fd8003449c752fe43fcbeb950f3b97 (https://open-o3ecyz09q-thinkfiveable.vercel.app).


Does RepoDB support the TimeOnly data type?

I have a Project which uses Sql Server and the TimeOnly data type.
When I attempt to save an entity which has a TimeOnly field, I get the following error message.  I searched the docs, but I did not find any mention of TimeOnly,  Is there a way to resolve this?
Using version 1.13.0
await connection.UpdateAsync(tutorInfo);
System.InvalidCastException
HResult=0x80004002
Message=Failed to convert parameter value from a TimeOnly to a TimeSpan.
Source=Microsoft.Data.SqlClient
StackTrace:
at Microsoft.Data.SqlClient.SqlParameter.CoerceValue(Object value, MetaType destinationType, Boolean& coercedToDataFeed, Boolean& typeChanged, Boolean allowStreaming)
at Microsoft.Data.SqlClient.SqlParameter.GetCoercedValue()
at Microsoft.Data.SqlClient.SqlParameter.Validate(Int32 index, Boolean isCommandProc)
at Microsoft.Data.SqlClient.SqlCommand.BuildParamList(TdsParser parser, SqlParameterCollection parameters, Boolean includeReturnValue)
at Microsoft.Data.SqlClient.SqlCommand.BuildExecuteSql(CommandBehavior behavior, String commandText, SqlParameterCollection parameters, _SqlRPC& rpc)
at Microsoft.Data.SqlClient.SqlCommand.RunExecuteReaderTds(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, Boolean isAsync, Int32 timeout, Task& task, Boolean asyncWrite, Boolean inRetry, SqlDataReader ds, Boolean describeParameterEncryptionRequest)
at Microsoft.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, TaskCompletionSource1 completion, Int32 timeout, Task& task, Boolean& usedCache, Boolean asyncWrite, Boolean inRetry, String method)    at Microsoft.Data.SqlClient.SqlCommand.InternalExecuteNonQuery(TaskCompletionSource1 completion, Boolean sendToPipe, Int32 timeout, Boolean& usedCache, Boolean asyncWrite, Boolean inRetry, String methodName)
at Microsoft.Data.SqlClient.SqlCommand.BeginExecuteNonQueryInternal(CommandBehavior behavior, AsyncCallback callback, Object stateObject, Int32 timeout, Boolean inRetry, Boolean asyncWrite)
at Microsoft.Data.SqlClient.SqlCommand.BeginExecuteNonQueryAsync(AsyncCallback callback, Object stateObject)
at System.Threading.Tasks.TaskFactory1.FromAsyncImpl(Func3 beginMethod, Func2 endFunction, Action1 endAction, Object state, TaskCreationOptions creationOptions)
at System.Threading.Tasks.TaskFactory1.FromAsync(Func3 beginMethod, Func2 endMethod, Object state)    at Microsoft.Data.SqlClient.SqlCommand.InternalExecuteNonQueryAsync(CancellationToken cancellationToken) --- End of stack trace from previous location ---    at RepoDb.DbConnectionExtension.<UpdateAsyncInternalBase>d__10081.MoveNext()
at RepoDb.DbConnectionExtension.d__989`1.MoveNext()
at Rihisi.Data.DataStore.d__0.MoveNext() in C:\Dev\BlueHatSoftware\Rihisi\V5\Rihisi\Rihisi\Data\DataStore.cs:line 25
This exception was originally thrown at this call stack:
[External Code]
Inner Exception 1:
InvalidCastException: Object must implement IConvertible.

I was able to get this working by defining the Entity Type as a TimeSpan, instead of a TimeOnly.  Then no exception was thrown. I then convert it to a TimeOnly.
public TimeSpan TimeOnlyTest {get;set;}

public TimeOnly MyTimeOnly
{
    get { return TimeOnly.FromTimeSpan(this.TimeOnlyTest); }
    set { this.TimeOnlyTest = value.ToTimeSpan(); }
}


pandoc-mode 2.19

Created with brew bump-formula-pr.

@rwhogg would these be fixed by adding a newer default compiler to Travis? https://travis-ci.org/Homebrew/homebrew-emacs/builds/157104548#L4527

@dunn I'm not sure. I've opened https://github.com/Linuxbrew/homebrew-core/pull/859 to see if we can get icu4c bottled.

Oh, thanks!

Bleh: https://travis-ci.org/Homebrew/homebrew-emacs/builds/157104548#L4878
I guess add
      (add-to-list 'load-path "#{Formula["homebrew/emacs/cl-lib"].opt_elisp}")

to the test file.

Ok, this is getting silly https://travis-ci.org/Homebrew/homebrew-emacs/builds/157428705#L4930

Oh, it's trying to build bottles.  Could you rebase?

@dunn rebased!

@BrewTestBot test this please


Add note about v3 dev code in readme

Resolves #8281

@alexkuc is this what you had in mind?

@alexkuc is this what you had in mind?

@etimberg yes! although, I would phrase it a little different:

Currently, there are two versions of the library (2.9.4 and 3.x.x). Version 2 is the latest stable version while 3 is the next (currently beta) version. As such bear the following in mind:

current docs points to version 2.9.4
npm/CDN/etc point to version 2.9.4 (unless you explicitly set newer version, e.g. npm next)
source currently points to 3.x.x version
docs for version 3.x.x are available here

This is a little more verbose but it highlights that e.g. CDN points to version 2.9.4 instead of master.
E.g. https://cdn.jsdelivr.net/npm/chart.js
(for dev purposes, personally I'd prefer a little more information as devs would benefit from that)
Let me know what you think

@etimberg yes! although, I would phrase it a little different:

Currently, there are two versions of the library (2.9.4 and 3.x.x). Version 2 is the latest stable version while 3 is the next (currently beta) version. As such bear the following in mind:

current docs points to version 2.9.4
npm/CDN/etc point to version 2.9.4 (unless you explicitly set newer version, e.g. npm next)
source currently points to 3.x.x version
docs for version 3.x.x are available here

This is a little more verbose but it highlights that e.g. CDN points to version 2.9.4 instead of master.
E.g. https://cdn.jsdelivr.net/npm/chart.js
(for dev purposes, personally I'd prefer a little more information as devs would benefit from that)
Let me know what you think

Good feedback! I adjusted to use that


Testing, please ignore. (vhpbll)

Bug bounty test - please ignore.... Please DO NOT APPROVE THIS! (vhpbll)

@yanshulmatok what is the point of this ?


Wrong configuration loaded if path is not pyproject.toml

Hi @dbatten5, I'm facing an issue when loading the configuration from a different file than pyproject.toml. Imagine that I have three files with the same content:
[tool.autoimport]
common_statements = { "FooBar" = "from baz.qux import FooBar" }

.
├── config
│   └── pyproject.toml
├── other.toml
└── pyproject.toml

When loading them:
>>> ProjectConfig(project_name="autoimport", source_files=['pyproject.toml']).to_dict()
{'common_statements': {'FooBar': 'from baz.qux import FooBar'}}
>>> ProjectConfig(project_name="autoimport", source_files=['other.toml']).to_dict()
{'tool': {'autoimport': {'common_statements': {'FooBar': 'from baz.qux import FooBar'}}}}
>>> ProjectConfig(project_name="autoimport", source_files=['config/pyproject.toml']).to_dict()
{'tool': {'autoimport': {'common_statements': {'FooBar': 'from baz.qux import FooBar'}}}}

I'd expect that loading other.toml and config/pyproject.toml returns the same result as pyproject.toml == {'common_statements': {'FooBar': 'from baz.qux import FooBar'}}
I'm using version 1.4.0.
Thanks!

Hi @lyz-code good to hear from you again 👋
I definitely agree that config/pyproject.toml should have the same result as pyproject.toml, that's a bug.
As for other.toml, I think that's up for discussion. I envisaged supporting generic toml files in situations where there's a dedicated toml file for the tool being used, eg. autoimport.toml. In that case I thought it would be odd if autoimport.toml had a structure like
[tool.autoimport]
common_statements = { "FooBar" = "from baz.qux import FooBar" }

Since autoimport.toml is dedicated to autoimport wouldn't it just list the config at the root level? Eg.
common_statements = { "FooBar" = "from baz.qux import FooBar" }

Yeah, what you say makes total sense

Hi @lyz-code sorry I haven't had a chance to look at this, I've been away for a while. Thinking about this again, I can't really envisage a situation where the pyproject.toml wouldn't be at the root of the project directory. Do you have any examples of this happening?

Hi @dbatten5 it's nice to hear from you again :), I had to dive deep into the code to remember why I needed this myself xD
It looks I was trying to [make a test to check the `--config-file` argument of `autoimport](https://github.com/lyz-code/autoimport/blob/main/tests/e2e/test_cli.py#L144). The idea was that the user could select a different `pyproject.toml` than the original. I myself don't have that need but some user made a PR to add that functionality, so I guess it needs it `¯_(ツ)_/¯`.
If it's hard to implement or it adds complexity, I can add a DeprecationWarning and if no one complains in 6 months we can close the issue

Hi @lyz-code, makes sense that a user would like to specify a different autoimport config file, but I would be surprised if they were trying to specify a pyproject.toml file at a level different to the project root as AFAIK the pyproject.toml has to be at the root of the project directory (couldn't really find much information on this so I could well be wrong about that). If they were trying to specify eg. a autoimport.toml at a different level to the root, maybe at config/autoimport.toml then this package would work as is right?

Actually, just taking a look at the code, I think if you added a starting_path argument to the constructor for ProjectConfig then you might be able to achieve what you're after
ProjectConfig(project_name="autoimport", source_files=['pyproject.toml'], starting_path=Path("path/to/config").to_dict()

It makes sense all that you said. Whenever I can spare some time I'll try to implement your proposal

Hi @dbatten5 I ran into the same issue here as well - it looks like if you provide the path to the pyproject.toml directly, the simple check if source.startswith("pyproject"): is failing, because that's the start of the filename not the start of the (absolute) path.
https://github.com/dbatten5/maison/blob/main/src/maison/utils.py#L101
I would propose to change this line to if file_path.name.startswith("pyproject"):
So the path library can handle it and you would just check the basename instead.

Hi @marcules, ah yes good catch, will get that fixed up ASAP

Hey @lyz-code - slightly off topic but I'm currently experience some clashing dependencies with flake8 and mkdocs which I think has been resolved by flake8 releasing version 6.0.0 recently, however this version requires python version >=3.8.1. I'm happy to drop python 3.7 support in maison to fix that clash but would that be a pain for autoimport?

OMG 6.0.0 already?  For example flakeheaven does not yet support 5.x. I'm sad to say that if you pin to something like flake8>=5.0.0 I won't be able to use the newer versions until flakeheaven supports it :(. Although if it's in the dev dependencies, it won't affect me.
My plan is to support python 3.7 until it's end of life on the 27 Jun 2023 (can't wait, if I'm honest with you), so I'd be unable to use newer versions if you also pin the python version.
That being said, go ahead :) , I've been struggling myself with dependencies clash these months (specially due to flake8) and I completely understand you don't want to fight with it anymore. If I feel that I need a new feature of maison more than the will to give support till the end of life or to use flakeheaven I'll upgrade myself.
On the other hand, you probably only need the flake8 dependencies for the development environment. So maybe you can keep the minimum python version, the pins of your direct dependencies and then generate the Poetry.lock with the constrain of python >=3.8?
Thanks for asking :)

Hi @marcules sorry just coming back to this now. Could I confirm that you tried adding the starting_path argument to ProjectConfig? That should allow you to specify a pyproject.toml in a different location, e.g.:
config = ProjectConfig(
  project_name="yamlfix",
  starting_path=Path("/some/other/path")
)

print(config.config_path)
#> PosixPath(/some/other/path/pyproject.toml)

@lyz-code yeah that makes sense. I think I wouldn't be able to upgrade flake8 to 6.0.0 without updating the minimum python version to 3.8.1 even if flake8 is just a dev dependency (using poetry)? Unless I'm missing something

Then use pdm!!
But surely there's a way to tell poetry to not to resolve the constrains of some dependency and override it with the desired version

@lyz-code Ah yeah I've come across pdm - looks like a good tool althogh feels a bit of a pain to migrate. I've been looking at replacing flake8 with ruff anyway so maybe I'll give that a try

closing due to inactivity as but feel free to reopen if there are still issues


feat: Add checkbox to enable/disable params in HTTP Sampler

Description
This pull request adds a new column in the HTTP Sampler parameters table which allows the user to enable or disable the http parameter.
To implement this feature, a new "isEnabledFromGui" property has been added in HTTPArgument and it has been used in several places (HTTPHC4Impl, HTTPSamplerBase, PutWriter etc.) to determine whether to include the argument in the request or not.
To enable the property setting by the user a new column has been added in HTTPArgumentsPanel.
The HTTPArgumentSchema has been adjusted to include this new field too.
Tests file and localization files has been adjusted to be compliant with this new attribute.
Motivation and Context
I think this feature could be really useful, because sometimes I and other people I know wished JMeter had it while doing some tests.
Fixes https://github.com/apache/jmeter/issues/5466
How Has This Been Tested?
I have successfully built the project by using ./gradlew build and all tests ran without issues.
My testing environment is Windows 10, Intel I5 6th gen, 16GB Ram DD4, Oracle JDK 17.
Screenshots (if appropriate):

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

[x ] My code follows the code style of this project.
[ ] I have updated the documentation accordingly.

Hi @vlsi could you please help me on that?
I don't really have a clue on why these tests are failing...

@vlsi I've also ran on my machine the task :src:dist-check:batchResponseDecompression which is failing in 17, microsoft, windows, America/New_York, tr_TR and it ran successfully

@pochopsp, have you tried using the default org.apache.jmeter.testelement.TestElementSchema#getEnabled for the attributes?
Is there a need for a separate property?

@vlsi you were right, there is no need for a new property in the HTTArgumentSchema. I updated my pull request with commits including the use of org.apache.jmeter.testelement.TestElementSchema.enabled as you suggested.
Furthermore, by doing so the number of edited files decreased to just six.


Input Select in sub-button overlaps side of screen on mobile

Describe the bug
When using the input select entity as a sub-button, in a bubble card button card, the size of the drop down doesn't change. This problem is only on mobile and is due to the buttons being sized smaller on mobile.
The buttons are in a pop-up. The screenshot explains the issue better.
Expected behavior
Resize the dropdown to not exceed the width of the button card it's in.
Screenshots
Not sure why the picture is so big, sorry about that. I've also updated pop-up setting margins since screenshotting this.

YAML
Relevant section:
type: vertical-stack
cards:
  - type: custom:bubble-card
    card_type: pop-up
    hash: "#lights"
    button_type: switch
    show_header: true
    entity: script.turn_off_house_lights
    margin_top_mobile: "-56px"
    bg_opacity: "100"
    shadow_opacity: "0"
    bg_blur: "14"
    styles: ""
  - type: vertical-stack
    cards:
      - type: custom:bubble-card
        card_type: separator
        name: Living room
        icon: mdi:sofa
        card_layout: large
        styles: |-
          .bubble-sub-button-icon {
            --mdc-icon-size: inherit !important;
          }
        sub_button:
          - entity: input_select.living_room_kitchen_light_brightness
            name: Brightness
            show_name: false
            show_icon: false
            show_background: false
            show_arrow: true
            show_attribute: false
            attribute: icon
      - type: horizontal-stack
        cards:
          - type: custom:bubble-card
            card_type: button
            entity: light.living_room_light
            scrolling_effect: false
            show_name: true
            sub_button:
              - entity: input_select.living_room_light_brightness
                show_icon: false
                state_background: true
                show_background: false
                show_arrow: true
                name: Brightness
                show_attribute: false
                attribute: options
            tap_action:
              action: toggle
              target: {}
            name: Living room
            show_icon: false
            show_attribute: false
            attribute: brightness
            show_last_changed: false
            show_state: false
            force_icon: false
            icon: mdi:light-recessed
            styles: ""
          - type: custom:bubble-card
            card_type: button
            entity: light.living_room_bookshelf_light
            scrolling_effect: false
            show_name: true
            sub_button: []
            tap_action:
              action: toggle
            name: Bookshelf
            icon: mdi:light-switch
            show_icon: false
        grid_options:
          columns: 12
          rows: 1

Informations (please complete the following information):

OS: Android
Bubble Card version: v2.3.0-beta.7
Home Assistant version: 2024.11.2

Additional Info
If there's any styling I can apply to reduce the width of the drop-down I'm happy to apply that.

Hi! Indeed I need to fix that! But in the meantime you change it with:
ha-card {
  --bubble-select-list-width: 150px;
}

This is pretty difficult to fix, so I'm not sure that I will change that for the next release, but I will not forget about that one 👌

Thats perfect thanks so much! Love your work by the way, I only started making my firt proper hass dashboard recently and its all bubble cards and looking fantastic. Keep it up!
While I have you just another question. This may be a more general hass question though, so if so let me know and I can go searching for the answer.
I'm using the input select entity to run an automation (e.g. select Low and dim lights low) but I can also manually/physically change the light brightness, so I don't want the state I selected in the dropdown to save, so I can reselect it after. Do you know how to not make the state save in the dropdown after I select it?

Tough one, I guess that the best way would be to create an automation that reset your input_select, even if I'm not sure that there is an easy way to detect if it was modified outside of your initial input_select automation.
I can't help you more on that but let me know if you found a way.
And thanks for the kind words!

Tough one, I guess that the best way would be to create an automation that reset your input_select, even if I'm not sure that there is an easy way to detect if it was modified outside of your initial input_select automation.
I can't help you more on that but let me know if you found a way.
And thanks for the kind words!

I made an additional option called 'Test' in my input select and then an automation with a trigger so when one of the options are selected, after 1 second the 'Test' option is then selected.
I tried making it so the trigger was when the brightness would change, but that didn't work.
Automation yaml below. I just have to add in all other options to the triggers.
alias: Living Room Light Brightness Clear
description: ""
triggers:
  - trigger: state
    entity_id:
      - input_select.living_room_light_brightness
    to: Low
    for:
      hours: 0
      minutes: 0
      seconds: 1
conditions: []
actions:
  - action: input_select.select_option
    metadata: {}
    data:
      option: Test
    target:
      entity_id: input_select.living_room_light_brightness
mode: single

A couple of question.

Is there a way to hide an option in the input_select entity? Or like only how first x number of options?
Is there a better way to do what I'm trying to do?

I know this isn't related to bubble cards now, so I need to ask elsewhere please let me know :)

You could rename that empty option to "Custom" or "None", there is maybe a way to hide it with a custom style, but I know that some parts of it can't be edited, so I'm unsure.

I appreciate the suggestions but I might just leave it for now since it's working well enough. I'll keep an eye out for a solution but I'm pretty happy with it now.
I also realised the automation can trigger when the state 'changes to any state' so I can set triggers for each light and use the choose action to hit each of the light inputs selects, so at least that part is easy


Add always

This PR adds support for the always transition, which works exactly the same as eventless transitions:
on: {
- '': 'someTarget'
},
+always: 'someTarget'

As the tests show, this is not a breaking change. The original way for defining eventless transitions will continue to work.
TODO:

[x] Docs
[x] Tests

Should we introduce a deprecation warning for '' right away?

Going to merge this in (all comments resolved) - won't release yet, in case a critical change is needed. @Andarist

we should also update the docs here:
https://xstate.js.org/docs/guides/events.html#null-events

we should also update the docs here:
xstate.js.org/docs/guides/events.html#null-events

Feel free to make a PR for this, or an issue please


Feature/lang graph

this will be huge update, when we can expect it will go to production? :) Thank you for your amazing work


refactor(scrub): replace umoci logic in scrub implementation

implement scrub also for S3 storage by replacing umoci
change scrub implementation for ImageIndex
take the Subject into consideration when running scrub

What type of PR is this?

Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Why do we still have umoci in go.mod?


[TreeItem] allow conditional child #20154

[x] I have followed (at least) the PR section of the contributing guide.

@eps1lon can you advise on the failure.

@tonyhallett  Flaky netlify deploy. You need to rebase anyway so this should resolve itself.

Going to be easier to just do the change again


OperatorPolicy test fixes

Check the message before compliance (since that test failure could be more helpful)
Fetch the CSV name dynamically (since a static version could be flaky if a new z-stream is released)
Only attempt an OperatorGroup/CSV deletion if a name was discovered
Clean up all CSV when deployed clusterwide (this is mainly for the benefit of the Canaries)

Followup to:

#743
#736

Looks like 2 Disabled events were generated:
   [FAILED] Timed out after 30.000s.
  The function passed to Eventually failed at /go/src/github.com/stolostron/governance-policy-framework/test/integration/compliance_history_test.go:338 with:
  expected cluster local-cluster to have one disabled events
  Expected
      <[]interface {} | len:2, cap:2>: [

FYI @mprahl

/retest

CI is passing here now! 🎉

/cherry-pick release-2.10


Signature Parameter offsets

Once #294 is merged ParameterInformation we will be able to return offsets into the SignatureInfo.label instead of a separate string (which is intended to be a substring of SignatureInfo.label). This would make the code a little simpler.
See https://microsoft.github.io/language-server-protocol/specification#textDocument_signatureHelp

It looks like #294 is merged already. If this is still waiting for someone to do it I'd like to help.

This was probably solved in e1e79cf064, consider closing the issue


Version in About dialog wrong

From<EMAIL_ADDRESS>on 2010-11-17T03:55:54Z
What steps will reproduce the problem?

Open About dialog 2. 3. What is the expected output? What do you see instead? I expect to see the version 2.0.0rc1 but there is still 2.0.0beta6b What version of the product are you using? On what operating system? Win7 x64, EPD 6.3 x64

Original issue: http://code.google.com/p/spyderlib/issues/detail?id=453

From pierre.raybaut on 2010-11-17T09:50:51Z
How did you install Spyder? (from source with 'python setup.py install' or with the .exe installer)
Are you sure that you have uninstalled the previous version?
Actually I'm unable to reproduce this bug.

From<EMAIL_ADDRESS>on 2010-11-24T01:37:09Z
I built spyder 2.0rc2 again from source. This time I removed all spyder* files and directories within site-packages/. Now the version number is correct.

From<EMAIL_ADDRESS>on 2010-11-17T13:54:51Z
Yes, I built spyder from source with 'python setup.py install'. I did not try the .exe installer because I assumed it was made for x86 systems only.
And no, I did not uninstall any previous version. Btw, how should I do this?
I assumed that since one of the last messages during "setup.py install" is something like "writein spyder.py to ..EPD\Scripts" launching this file will use the current (=newest) version of spyder.

From pierre.raybaut on 2010-11-24T01:56:26Z
Status: Done


DOCSP-41335: Id field alias

JIRA - https://jira.mongodb.org/browse/DOCSP-41335
Staging - https://preview-mongodbnorareidy.gatsbyjs.io/laravel/DOCSP-41335-id/query-builder/#logical-or-example
Checklist

[ ] Add tests and ensure they pass
[ ] Add an entry to the CHANGELOG.md file
[ ] Update documentation for new features

Setting the Model $primaryKey is no logger necessary since models using id as PK will see their requests converted to _id.
https://github.com/mongodb/laravel-mongodb/blob/ce05d9dd63e3557b9851a10756778290ecb69e62/docs/eloquent-models/model-class.txt#L300-L301


I want to use reverse c++. but it doesn't work

Please provide detailed information about the failure you experienced.

There are a couple of bugs in the parser:

the 'class' type qualifier is not recognized on instance variables, or as parameters:

class foo {
    public: class foo * foo( class foo * f ) const { return f; }
};

In this case class foo * is required because there is a method named foo. This is an issue in many header only c++ packages, and is especially pernicious with forward decls, and with external subsystems like bison.

visibility statements won't work if there is nothing in between (or if they are made in visible by the preprocessor or comments:

class foo {
protected:
// nothing here!
public:
virtual void bar() const;
};
That code is totally valid and should not generate an error. The empty protected: statement should just be interpreted as a null statement.


[6.0] SIL: Fix lowering for 'var's whose types contain local archetypes

6.0 cherry-pick of https://github.com/apple/swift/pull/74414.

Description: Fix compiler crash when a mutable local var contains a pack element type.

Origination: Never worked.

Reviewed by: @hborla

Risk: Low. This changes a very commonly-executed bit of code, but hopefully our test coverage here is sufficient.

Radar: rdar://123706574

@swift-ci Please test


It's error in console

Uncaught TypeError: Cannot read property 'firstChild'

@keangkai what is prompting the error? Can you provide a screenshot of the error?

i want review too

This was resolved by #631. Many thanks to @denmch for fixing it, and finding me on Twitter to make sure this issue is properly closed. Apologies for missing it and keeping it open.


HTTPException: 500: Failed to import module from features.quizzify.core: No module named 'features'

Scenario - 1 :
After cloning the changes in the main code base
Code snippet below

Config snippet below

Error snippet below

Scenario - 2 :
After changing the config file
Config snippet below

Error snippet below

Solution :
Patching the code until a solution is found

Yes, we introduced the parent module directly in order to allow relative module imports. So when you add app to that module, it specified which module path.
@sanithpallerla Given that you have a solution, can you make a PR for this for me to review the changes and do testing into STAGING? Thanks,

@mikhailocampo I have found that the system actually works when I build a Docker Container for it. I think that @sanithpallerla is trying to run the code in his local environment.

@AaronSosaRamos Yes, I completely agree with you. @mikhailocampo I have made the necessary changes. Now it works in Local environment and Docker container and raised a PR from AI-Avengers team's end which includes expedition 7.1 too.


tidy up url by removing localId

Coverage decreased (-0.1%) to 42.773% when pulling edb4594e563955830ceecf86731f10382592c2bd on removeLocalIdFromUrl into 04dfd80904a5d9329f805282ad41c5db5cd62f11 on master.


Cannot exclude workspace folder from search when using absolute paths for workspace folders

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.61.2
OS Version: Windows 10, Remote SSH into OpenSUSE Leap 15.2

Steps to Reproduce:
$ pwd
/home/bers/test
$ tree
.
├── test.code-workspace
├── X
│   └── x
└── Y
    ├── y
    └── Z
        └── z

3 directories, 4 files

test.code-workspace:
{
    "folders": [
        {
            "name": "X",
            "path": "/home/bers/test/X",
        },
        {
            "name": "Y",
            "path": "/home/bers/test/Y",
        },
    ],
    "settings": {
        "search.exclude": {
            "**/Y": true, // does not work - file y is found
            "**/Y/Z": true, // does not work - file z is found
            // "**/Z": true, // works - file z is not found
        }
   },
}

Interestingly, this starts working as soon as I do this:
...
    "folders": [
        {
            "name": "X",
            "path": "test/X",
        },
        {
            "name": "Y",
            "path": "test/Y",
        },
    ],
...

Are you expecting the exclude patterns to work on the paths of the workspace folders? They won't work on the workspace folder itself, only under the folder. I wouldn't expect it to work in the second case either, so maybe something else is going on there


Crash contracting cup and inverse

Crash dump

Can you add a screenshot or hom file? We can't import action dumps in the website.

panicked at 'node in collapse base does not connect to max_dim_index', homotopy-core/src/contraction.rs:677:30

I am very pleased if this is broken because it is a nice simple example.

Can you add a screenshot or hom file? We can't import action dumps in the website.

Yes we can. It doesn't show .txt as a supported format for some reason, but it can load up actions files and replay them just fine.

Can you add a screenshot or hom file? We can't import action dumps in the website.

Yes we can. It doesn't show .txt as a supported format for some reason, but it can load up actions files and replay them just fine.
Correction: we actually cannot import them because AttachOption has a fake deseralize.

See this to add .txt as a supported format: https://github.com/homotopy-io/homotopy-rs/blob/e375617791f0175bc9751dd8924a6bc2d009c042/homotopy-web/src/app/project.rs#L33

Can you add a screenshot or hom file? We can't import action dumps in the website.

Yes we can. It doesn't show .txt as a supported format for some reason, but it can load up actions files and replay them just fine.
Correction: we actually cannot import them because AttachOption has a fake deseralize.

See this to add .txt as a supported format: https://github.com/homotopy-io/homotopy-rs/blob/e375617791f0175bc9751dd8924a6bc2d009c042/homotopy-web/src/app/project.rs#L33

Sorry that's pointing to an old version because I copied it from an old PR.

With 1b24a43, we can import this action file into homotopy-cli and homotopy-web.

You can't even construct this diagram now to contract it, let alone trigger the contraction bug.

Is it possible you tried before the CI updated alpha.homotopy.io?

I just tried this and it's definitely fixed.

Ok my bad 😅


[.cmd] redirection must be inside quotes ?

line
dbl > pvlist_${IOCNAME}.dbl

tree-sitter message:
    (ERROR [56, 0] - [56, 13])
    (macro_expansion [56, 13] - [56, 23])
    (ERROR [56, 23] - [57, 17])

fix:
 dbl > "pvlist_${IOCNAME}.dbl"

could you accept that the redirection is not between quotes ?

This is a macro issue, that I can't do much about. Although I'd like to support this case, personally I'd say that if ${IOCNAME} contains a space, you'd run into some trouble, and should quote the path.


Allow class in field definition

I'm customizing my bootstrap views for mobile layout and would like to specify fields that are only shown in the desktop view using the bootstrap class "visible-desktop".  I'd like to use the "class" specification as part of "fields" to accomplish this.
I'm particularly interested in doing this for a data_view.
I assume the best alternative at this point is to create a template.

@perak I was looking to work on adding this feature to Meteor Kitchen but I don't see the actual kitchen source posted. Is this something I can help with?

@rgstephens excuse me for late answer. Kitchen-cli is not open source yet. I published on kitchen site that my attention is to open the source (and it is) but I was under negotiations with the company who asked me to wait - to not open the source yet before they decide what to do.
Now, I can say that kitchen-cli will go open source for sure, please just a little bit patience. And thank you fir your good will to contribute.
About your particular problem: in meantime, I can add possibility to define any html attribute to the generated fields (including "visible-desktop"). Would that work?

@perak That would work great.  Thanks.

@rgstephens added input_control_class property to field object. And there is old input_group_class property too.
This example shows where classes will be added:

	Some Field

		<input type="text" name="someField" value="12345" class="form-control INPUT_CONTROL_CLASS">

Will be published in v0.9.63 most likely tomorrow (~24 hours after now).

@perak, this is working as you've documented it with forms but I'd also like to set class when the field is used in a table. It may be that I'll start using custom_template more.

@rgstephens ah... data_view, not form - I didn't read issue carefully enough. I'll add that in next version.


fallthrough actions

In normal reducers we can use fallthrough to use the same reducing method for multiple action types. What's the easy way to do this in redux-actions?
// normal reducer
switch (action.type) {
    case FETCH_ERROR:
    case CREATE_ERROR:
    case EDIT_ERROR:
    case DELETE_ERROR:
      return state
        .set('phase', ERROR)
        .set('error', String(action.payload.error));

  default:
    return state;
}

// redux-actions
handleActions({
  [FETCH_ERROR]: (state, { payload }) => state
    .set('phase', ERROR)
    .set('error', String(payload.error));

  [CREATE_ERROR]: (state, { payload }) => state
    .set('phase', ERROR)
    .set('error', String(payload.error));

  [EDIT_ERROR]: (state, { payload }) => state
    .set('phase', ERROR)
    .set('error', String(payload.error));

  [DELETE_ERROR]: (state, { payload }) => state
    .set('phase', ERROR)
    .set('error', String(payload.error));
}, {});

Is this even possible?
I realize I can create a small helper function, and call this function 4 times, but still it doesn't look very nice:
// redux-actions
const setError = (state, { payload }) => state
    .set('phase', ERROR)
    .set('error', String(payload.error));

handleActions({
  [FETCH_ERROR]: setError,
  [CREATE_ERROR]: setError,
  [EDIT_ERROR]: setError,
  [DELETE_ERROR]: setError,
}, {});

Anyone with suggestions to handle this in a clean way?

have you checked combineActions ?

Yep, please see https://github.com/acdlite/redux-actions/#combineactionsactiontypes. Thanks @xiaohanzhang.

Yes, I did see combineActions.  But even after rereading this section several times,  it's not directly obvious how to handle this case.

This is how we usually use it in code:
handleActions({
  [
    combineActions(
      FETCH_ERROR,
      CREATE_ERROR,
      EDIT_ERROR,
      DELETE_ERROR
    )
  ]: (state, { payload }) => state
    .set('phase', ERROR)
    .set('error', String(payload.error));
}, {});

That one is briljant. Can't believe it's not that obviously noted in the readme.

@smeijer Would you mind submitting a PR to improve the README?

Actually, this is taken care of in https://github.com/acdlite/redux-actions/pull/165/files.


vert.x 4.5.9 released

fixed with https://github.com/NoEnv/vertx-jsonpath/commit/cdcd179460b2c00ccc6324f99b59d529a6428c8a


UPDATE ERROR RASPBERRY PI B

When updating I receive an error
./install.sh: line 377: [: ==: unary operator expected
this occurs after reading package lists, building dependency tree, and reading state information.
The Raspberry Pi B was updated this afternoon, and the kernal was updated.
Thank you
Perry

Strange; that part of the install script hasn't changed for a long while. I'll check it out.

I'm trying to build this for docker using https://github.com/droogmic/rpi-cam-web-docker and am receiving this same error.
Indeed cat /proc/cmdline on my RPi2 is not returning a boardrev.
kevin@raspberrypi:~ $ cat /proc/cmdline | awk -v RS=" " -F= '/boardrev/ { print $2 }'
kevin@raspberrypi:~ $ cat /proc/cmdline
bcm2708_fb.fbwidth=656 bcm2708_fb.fbheight=416 bcm2708_fb.fbswap=1 vc_mem.mem_base=0x3dc00000 vc_mem.mem_size=0x3f000000  dwc_otg.lpm_enable=0 console=ttyAMA0,115200 console=tty1 root=PARTUUID=4f85592a-02 rootfstype=ext4 elevator=deadline fsck.repair=yes rootwait

Are you using the latest version. I did put a change in so that it ignored a missing boardrev. The line in install.sh should have double [[ which allows a comparison against a blank string to work

I was not. Now I am and I can confirm this is resolved. Thank you!


Ender IO - missing breaking particles

http://i.imgur.com/69VC8cD.jpg this machine has no breaking particles.

Particles? Or the animation overlay? It's a TESR so the animation overlay isn't possible

I mean these particles -> http://i.imgur.com/LbdvuJC.jpg


Make Service page responsive and fix footer issues

Hey @Artemiskgg1 ,
Enhanced the Service page to be fully responsive across all devices. Corrected styling and layout issues in the footer for improved consistency.

@Artemiskgg1


Integrate pronoundb.org

Is your feature request related to a problem? Please describe.
Having an external server store your pronouns helps reduce time setting it up on every server.
Describe the solution you'd like
Integration with https://pronoundb.org/.
Describe alternatives you've considered
I mean, this was the idea from the very start of this project, but now I'll keep PronounDB as an optional provider.
Additional context
Related commits:

https://github.com/cyyynthia/pronoundb.org/commit/deed1e8a8edeacd9c07f35c14730496d3bebc1f3

PronounDB's issue: https://github.com/cyyynthia/pronoundb.org/issues/50
Example API endpoint: https://pronoundb.org/api/v1/lookup?platform=minecraft&id=63d08e0c-1b0a-4afa-a545-aa5088c48d7a

Possibly also integrate https://pronouns.page?

Possibly also integrate https://pronouns.page?

@ItsCryptic Although this might or might not be harder than pronoundb.org, I'll try my best!

Possibly also integrate https://pronouns.page?

@ItsCryptic Although this might or might not be harder than pronoundb.org, I'll try my best!

Let me know if you need anything! I'm a member of the team over there and would be glad to help out wherever possible :)