Add test id prop

Added test id prop to the modal trigger component and to the option component

As an alternative to adding a one-off prop pass-through, I propose passing the entire props through.  This is more extensible for any future props that are desired.  For examplerenderOption could become:
https://github.com/anovoselnik/react-native-modal-selector/blob/9041b3a14397cbc01baa431bfcd99285c529b1cb/index.js#L138
<TouchableOpacity onPress={() => this.onChange(option)} {...option}>

And render would become:
https://github.com/anovoselnik/react-native-modal-selector/blob/9041b3a14397cbc01baa431bfcd99285c529b1cb/index.js#L209
<View {...this.props}>

The downside is that extraneous props are passed along, and there's a chance of collision (passing in a prop that  actually looks at but isn't correct).  So far there aren't any collisions.

@anovoselnik
Hope you don't mind that I changed the prop from testId to passThruProps.  This allows users to pass in any set of props that they like (in your case {testId: myTestId}) that will pass through to the container View and options' TouchableOpacity.


Layer masks

This PR allows you to add one or more circle or rectangle mask layers after a shape that clip the boundaries of that shape after other transforms are run. It takes our machine boundary logic and lets you apply it within your pattern, with great flexibility. I wrote most of this code to create interesting submissions for the recent Sisyphus contest.
After digesting #182, I decided to make the Mask shape an "effect" (renamed from manipulator to mimic Photoshop). Effects are treated a bit differently that other shapes. They have fewer options and can't be changed into other shapes after creation. They are also displayed under their parent shapes in the play list. Down the road, we can add other effects if we don't want to include them in every shape by default.

To test:

Add a new shape.
Add a mask below it.
Play around moving the shape around, and also moving and re-sizing the mask.
Try out the various mask options.

I think it would be useful to draw the perimeter of the mask when the mask layer is selected. The square has the konva handle, but the circle is harder to "feel".

I think it would be useful to draw the perimeter of the mask when the mask layer is selected. The square has the konva handle, but the circle is harder to "feel".

This is really excellent and it works very smoothly. I have some comments, but nothing that will hold this up.

This is really excellent and it works very smoothly. I have some comments, but nothing that will hold this up.

This is really excellent and it works very smoothly. I have some comments, but nothing that will hold this up.

I will do some cleanup and we can merge. Can we consider a new release after this? We have a number of new features.

This is really excellent and it works very smoothly. I have some comments, but nothing that will hold this up.

I will do some cleanup and we can merge. Can we consider a new release after this? We have a number of new features.

Yes, definitely. It is about time. Sometime this week.

Yes, definitely. It is about time. Sometime this week.

This works great.

This works great.


bump version numbers for designspace ufo sources

Had to bump python version since fontTools requires 3.7+

I unfortunately need this for Roboto Flex.

Thanks. Can you cut a new release or give me privileges so I can do it?

0.3.0 is on pypi now. I should set up CD at some point...


Level time functions implementation

Implemented Level.getTime(), Level.setTime() + Actor.getLevel() functions.
Level.getTime() :

Hooks Level::getTime
Returns the current level time (in ticks)

Level.setTime() :

Hooks Level::setTime
Sets the level time
Syncs the level time with clients (by sending a SetTimePacket)

Actor.getLevel():

Hooks Actor::getLevel
Returns a Level instance
Allows to get the level instance in a simpler way

nb: Level::getTime & Level::setTime call LevelData::getTime & LevelData::setTime in the BDS source code, but i felt it was more appropriate to implement them in the Level class (it also does not make any difference)

I must say that this is really detail 👍🏻
But I don't get the time to check it yet

You are right.
Though, the time ranges from 0 to 23999 (ticks) so i guess precision is not that important ?


CI passes even when it actually timed out

Describe the bug
CI passes even when it actually timed out
Example:
https://jenkins-ceph-csi.apps.ocp.ci.centos.org/blue/organizations/jenkins/mini-e2e-helm_k8s-1.23/detail/mini-e2e-helm_k8s-1.23/76/pipeline/99
https://jenkins-ceph-csi.apps.ocp.ci.centos.org/blue/organizations/jenkins/mini-e2e_k8s-1.22/detail/mini-e2e_k8s-1.22/1470/pipeline/93
https://jenkins-ceph-csi.apps.ocp.ci.centos.org/blue/organizations/jenkins/mini-e2e_k8s-1.23/detail/mini-e2e_k8s-1.23/77/pipeline/93
Especially on #2359 , since it add multiple e2e test cases which take more time.

It seems that these logs do not exist anymore. @Rakshith-R, could you please alert someone with admin permissions in Jenkins when you notice this again? Admins can mark CI job runs with keep forever , so that the logs do not get cleared out.

Another occurence @nixpanic  @Madhu-1 , can we mark CI job runs with keep forever please?
https://github.com/ceph/ceph-csi/pull/2359
https://jenkins-ceph-csi.apps.ocp.ci.centos.org/blue/organizations/jenkins/mini-e2e-helm_k8s-1.21/detail/mini-e2e-helm_k8s-1.21/2301/pipeline/99

I don't know the exact steps to keep single job logs forever. I will let @nixpanic take care of it.

On Wed, Jan 05, 2022 at 09:43:05PM -0800, Madhu Rajanna wrote:

I don't know the exact steps to keep single job logs forever. I will let @nixpanic take care of it.

open the failed job
login on Jenkins
click the [->] button (go to classic) in the upper right corner
click th [Keep this build forever] button on the right side

This is done now, thanks!


Bugfix/remove lowercase in diagnostic path

This changes visible behavior
OS: windows
Path in diagnostic output are converted to lowercase. If there is name in path not in lowercase, when clicking on issue in "PROBLEMS" window vscode will open new editor window with same file just lowercase name.

I think this relates to needing a proper canonicalization of Windows paths. I'm just not sure how to go about doing it.
LGTM.


[Lightbox] Open animation

[x] Check why it doesn't work on Samuel's posts

[x] Looks like now it OOM's :(

[x] Look for leaks?

[x] Flicker on https://bsky.app/profile/steveklabnik.com/post/3lafytssuhj27
[x] iOS avi first frame jumps
[x] I think I got stuck on iOS once

[x] Repro: quick open and close many times

[x] Animate tall images correctly

Pushed a fix for supertall images. Should be good now.


UTF incompatibility?

Running into problems with UTF characters like â, curly quotes, ...

@JanVerkoyen can you provide a failing test case please? Thanks.

Try this for example: Codepen.io
Results in something like this:

ÔÇ£Vendre son ├ómeÔÇØ

@JanVerkoyen No problem. It's good you found the root cause.


[Feature]: Use .fetch() instead of .resolve() for simple command args

Feature?
When using a simple command arg for a channel or user, the library internally uses .resolve() which will attempt to pull the target from the client's cache. This means if the target is not cached, null will be returned.
Unfortunately moving to use .fetch() would require async and some error handling logic. The other option would be to explicitly document the behaviour and ensure that where appropriate users handle the null case.
Package
discordx

@lolPants have you encountered this issue?

Agree, should check the cache.
https://discord.js.org/#/docs/discord.js/stable/typedef/BaseFetchOptions
The async handler and the exception is not an issue, any issue that happens during the internal resolution of DJS due to a propagation should be thrown back to the user.
You should never get null

@oceanroleplay yeah, was looking to port an old Discord.js v12 codebase to something more modern and ran into this issue pretty quickly.

@oceanroleplay yeah, was looking to port an old codebase using Discord.js v12 to something more modern and ran into this issue pretty quickly.

just an FYI, @SimpleCommand is a last case for a command that can not be used for Slash commands.

@oceanroleplay yeah, was looking to port an old codebase using Discord.js v12 to something more modern and ran into this issue pretty quickly.

sure thanks for reporting, This issue will be resolved very soon.

@lolPants I request you review https://github.com/oceanroleplay/discord.ts/pull/529
If you think there can be more improvements, let me know.

Install v9.3.0 for fix 🎉

Was a little busy today so didn't get around to a review, but all looks good!
Thanks for working on this 😄


chore: host assigner

Script for host assignment in transport stanza for samples to be migrated from requirement tests to KO tests.

Codecov Report

Merging #703 (ba16fe5) into main (525ed4a) will decrease coverage by 1.17%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #703      +/-   ##
==========================================
- Coverage   87.02%   85.84%   -1.18%
==========================================
  Files          51       52       +1
  Lines        2766     2804      +38
==========================================
  Hits         2407     2407
- Misses        359      397      +38

Impacted Files
Coverage Δ

...lunk_addon/standard_lib/utilities/host_assigner.py
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Encrypt the values in secret.yml

The idea is to provide an interface and then expect our customer to have implementation of encrypt utility command line with a decrypt class in the classpath so that they can optionally encrypt some or all of the values in secret.yml. The SecretConfig class will check the value with prefix "CRYPT" to make decision on if the decryptor needs to be invoked. So if you just want to use clear text in secret.yml, it is still OK.

The release is pending and there is an tutorial for this feature.
https://doc.networknt.com/tutorial/security/encrypt-decrypt/


Add option to set the canvas background color

Fixes https://github.com/MattKetmo/darkroomjs/issues/40

Thanks


Proxy Factory library

We want to remove the App/Package/ImplementationDirectory set of contracts. (See prior discussion in the design document for 3.0.)
Since this is the current recommendation for creating proxies on-chain, we need to provide an alternative way to accomplish that. What we've come up with is a ProxyFactory library
This library should be used as shown below. It's designed to give complete control about the details of proxy creation to the developer.
contract MyFactory {
    using Proxies for Proxies.ProxyFactory;

    // This struct contains the address of the implementation that is
    // used for the proxies it creates.
    struct Proxies.ProxyFactory factory;

    constructor() public {
        // Initializes the factory struct by deploying the implementation
        // and storing its address.
        factory = Proxies.newFactory(FooUpgradeable.creationCode);
    }

    // initializerData is the encoded call to the initializer function.
    function deployInstance(address admin, bytes initializerData) public {
        factory.deploy(admin, initializerData);
    }
}

Moved to OpenZeppelin Contracts at https://github.com/OpenZeppelin/openzeppelin-contracts/issues/2339.


Vickel: Watch etnafes.com

Vickel requests the watch of the watch_keyword etnafes\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

etnafes\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by tripleee in Charcoal HQ


Added Insert Intervals problem in C++, C, Python and Java

🛠 Issue (Number)

Issue no #717
👨💻 Changes proposed
Added Insert Intervals in Greedy Algorithm folder in c, c++, python and java languages.
✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers
Please review my PR with proper documentation.
📷 Screenshots

@Kumar-laxmi Kindly review my PR for the issue #717

I have made this PR 4 days ago, please review my PR and if there is any problem kindly inform @Kumar-laxmi @072arushi


Pixhawk 4 could not be disarmed after landing, and logging stops with ESC at no-zero output

Describe the bug
The drone took off in position mode(EKF aided by motion capture system), moved few meters and landed. After landing, the drone was disarmed(using the RC switch), but the props continued to increase in throttle
Symptoms:

Drone failed to disarm with RC disarm switch and the z estimate shot up by few meters.
Baro and IMU data not logged during the period when disarm was send(300.6 - 301.2 sec)
Warning for [ecl/EKF] EKF ev hgt timeout - reset to baro was not logged.
Disarm RC command should always log output of the sensors if the motors are armed

To Reproduce
Steps to reproduce the behavior:

Drone switched on '...'
Takeoff in position mode with EV position data
move around a bit.
Land in position mode
While on the ground with idle PWM, lose motion capture data for around 200ms
Disarm the drone and it doesn't disarm.

Expected behavior
Losing mocap data should graciously degrade position accuracy, without uncertain jumps.
Disarm RC should always disarm.
Log Files and Screenshots
https://review.px4.io/plot_app?log=7a62d51d-a1ca-40fe-b7ea-44733e6993bd
Data from around when the issue happened. Issue occurs between 300 and 302 seconds

Drone (please complete the following information):

X configuration multicopter.
Pixhawk 4

This is a video of rosbag replay of the issue on rviz:

How did you try to disarm? And at what time (as time in the flight review plots)?

Was disarmed around ~294.8 sec and attempted a second time at ~299 sec.
Orange is the rc channel for arm in the last chart below:

Ok, the most likely issue here is that landed was not detected yet, presumably because you lost mocap data for a bit. Therefore, it did not disarm. I believe you need to wait long enough with throttle all the way down until the props are truly at idle. You might also just use auto-disarm to prevent having to get the disarm moment right.

Losing mocap data should graciously degrade position accuracy, without uncertain jumps.

I agree with this one. And it might improve with 1.11.

Disarm RC should always disarm.

This is by design only for stabilized. The risk is accidental in-flight disarming (trust me, I've done it). If you need authoritative (but potentially dangerous) force disarm, I suggest to use a kill switch.

Ok, the most likely issue here is that landed was not detected yet, presumably because you lost mocap data for a bit. Therefore, it did not disarm. I believe you need to wait long enough with throttle all the way down until the props are truly at idle. You might also just use auto-disarm to prevent having to get the disarm moment right.
There was atleast 2 seconds or more of time on the land with idle throttle which should be enough to detect land. Right ?
See https://user-images.githubusercontent.com/518314/86965953-5368e700-c136-11ea-8fb6-39be5721829f.png

Losing mocap data should graciously degrade position accuracy, without uncertain jumps.

I agree with this one. And it might improve with 1.11.
Could you point to few fixes or issues that could have helped the issue in 1.11 ?

Disarm RC should always disarm.

This is by design only for stabilized. The risk is accidental in-flight disarming (trust me, I've done it). If you need authoritative (but potentially dangerous) force disarm, I suggest to use a kill switch.

There was atleast 2 seconds or more of time on the land with idle throttle which should be enough to detect land. Right ?

Right, it depends on quite a few inputs though. I would have to look in detail at all data and what the land detector does. I'm afraid I don't have bandwidth to do that. If you find a consistent case where the land detector doesn't perform as it should, and understand it, then we could of course change/improve it.

Could you point to few fixes or issues that could have helped the issue in 1.11 ?

No chance. I just know that there are continuously fixes coming up around ekf2.
@bresch mocap data lead to a position jump in the log file above. Is this expected? Or do you know if this has been improved since 1.10?

I am using the kill switch now.

Makes sense I'd say, for your use case.

This is still an issue.


Use keys.openpgp.org as default keyserver

Currently, the default key server keyserver.ubuntu.com is down and prevents agent bootstrapping. As this happened multiple times now over the last months, I think this key server is too flaky, and I would propose to use keys.openpgp.org instead.
I'm also ok to just override the default userdata in my deployments if someone prefers this way.

As Woodpecker is affected as well, can you force merge it @anbraten

Nevermind that will not help at all as the image will not be build and pushed....

This doesnt work...


Tlstunnel not found

Hi, I have installed tlstunnel on mac os el capitan but the command is not found
[ John  ~/.opam ] opam install tlstunnel
[NOTE] Package tlstunnel is already installed (current version is 0.1.1).
[ John  ~/.opam ] tlstunnel
-bash: tlstunnel: command not found
[ John  ~/.opam ]
Where can I find the binary ? thanks

it should be in .opam/$swtich/bin (if you run ````eval opam config env`````, your $PATH` will be extended with the current switch)

@Fen0l any news on this? were you able to find the binary? please reopen if this is still relevant.


docs($exceptionHandler): code snippet syntax is incorrect

Updated the documentation on exception handler, there was an end bracket missing.
Supposedly not a breaking change, it's only documentation update.

I signed it!


Typo fix

Hi Pit, thanks for the typo fix. Actually, it's not pefromant nor peformant, but performant. 😉 Anyway, I'm closing this PR as I'm working on another version of this library which will have a revamped README, hopefully without typos.

Wow 🤦♂
You fooled me 😅


[Zone] accepts_nested_attributes_for :authentication

Requires change in UI at the same time

Introduces code into the AuthenticationMixin to allow the including class to choose whether the relationship is a has_one or a has_many
Allows saving attributes for an authententication with the Zone record (via accepts_nested_attributes_for)
Implements the changes into Zone, where the relationship has indirectly been a has_one all along

Part of the alternative to https://github.com/ManageIQ/manageiq-api/pull/916
Links

Cross Repo Tests:  https://github.com/ManageIQ/manageiq-cross_repo-tests/pull/318
Changes required in UI classic:  https://github.com/ManageIQ/manageiq-ui-classic/pull/7629
Alternative to https://github.com/ManageIQ/manageiq-api/pull/916
Addresses https://github.com/ManageIQ/manageiq-api/issues/898

QA Steps
You can test that this works in he API by using the following post body:
# POST /api/zones/X
{
  "action": "edit",
  "resource": {
    "description": "Updated Zone Description",
    "authentication_attributes": {
      "userid": "from",
      "password": "curl"
    }
  }
}

@miq-bot cross_repo_tests https://github.com/ManageIQ/manageiq-ui-classic/pull/7629

@Fryguy @abellotti Wouldn't mind your thoughts on this.  This is an alternative to https://github.com/ManageIQ/manageiq-api/pull/916 which actually doesn't require an API change now to allow updating nested attributes.
Might be a good pattern to following in the future if this is required elsewhere, but determining how to expose these in docs or OPTIONS is something that I am not sure how we want to handle.

@bdunne as a side note, I would prefer that discussion we are having over in https://github.com/ManageIQ/manageiq-api/pull/1014 would happen over here, since it is much more relevant to the code changes happening here.  The changes in the API are just validating that they are working as expected when using the API endpoints.


App archieved using the dogfood cert/profile will crash after download to iPhone.

What App Center service does this affect?
Appcenter ms dogfood environment for iOS
Describe the bug
I requrested the cert from dogfood environment and published the ipa then uploaded to appcenter ms, it can be downloaded to iPhone but failed to run when starting the application.
After the iPhone Distribution: Microsoft Corporation certificate been trusted on the iPhone, the app will crash and exist soon during starting, quite like some certificate invalid/expire situation.
To Reproduce
Steps to reproduce the behavior:

Go to 'https://appcenter.ms/apps?os=iOS'
Find the app on 'MScribe'
Download it to your local iPhone
Trust the cert and start the app.

Expected behavior
Our app should be able to start.
Smartphone (please complete the following information):

Device: iPhone 8 Plus
OS: iOS 12.1

@RichardSunMS please open a ticket in support (blue button) or feel free to find and message me directly.

@derpixeldan, I think you can just close it.
My bad it's a library reference issue, nothing relates to the cert.
Sorry for any inconvenience.
Richard.


Add NPM registry proxy

https://verdaccio.org/docs/en/docker
To speed up installs

First steps in feature/npm-registry-proxy, needs further work due to several concerns:

Lockfile includes registry URL -> how to handle CI / different environments? Maybe just shadow the NPM registry inside the DDE network?
What happens if Lockfile references a resolved file, but the proxy doesn't have it cached yet?

Maybe we could also use something like https://www.npmjs.com/package/npm-proxy-cache - not exactly the same use-case but same direction

https://github.com/yarnpkg/yarn/issues/5892
Seems like this will be included in Yarn v2 (Berry), and possibly not backported. Until then not sure how to proceed - except some hackery with string replacements, or just dynamic proxying.

Closing this issue as stale. If this is still a concern, please open a new issue


fix: Row FieldNames() memory allocation

What changes were proposed in this pull request?
The rowImpl.FieldNames() array allocation was wrong, resulting in empty strings at the start of the list.
Why are the changes needed?
To fix the bug.
Does this PR introduce any user-facing change?
No
How was this patch tested?
In my head^^

good catch, I  wonder how tests did not find this bug ?

I wrote a test case to validate
// rowImplTest is a read-only sample [Row] to be used in all tests.
var rowImplSample rowImpl = rowImpl{
	values: []any{1, 2, 3, 4, 5},
	offsets: map[string]int{
		"one":   0,
		"two":   1,
		"three": 2,
		"four":  3,
		"five":  4,
	},
}

func TestRowImpl_FieldNames(t *testing.T) {
	exp := []string{"one", "two", "three", "four", "five"}
	act := rowImplSample.FieldNames()
	require.Equal(t, exp, act)
}

test fails
Expected :[]string{"one", "two", "three", "four", "five"}
Actual   :[]string{"", "", "", "", "", "four", "five", "one", "two", "three"}

So the issue is that
names := make([]string, len(r.offsets))

will create a slice with the given length and initialize it with default values
It is idiomatic in Go to declare a slice like below
var names []string

then the slice is not nil, it is both (i.e. initialized && empty ), and can be appended to without surprising bugs
I created tests for the Row type and pushing it now 👍🏽

I raised https://github.com/apache/spark-connect-go/pull/77
@paulheg I wanted to push without ur fix, but the test was failing :'(
I had to update the impl, to pass the test
so sorry :/

Btw your implementation using var names []string does not preallocate, and is slower for large rows.
Lets see what the maintainers of this repo will make out of this.

Btw your implementation using var names []string does not preallocate, and is slower for large rows. Lets see what the maintainers of this repo will make out of this.

+1, I agree it is slower, u should use the cap arg if you know already beforehand to avoid the penalty of allocation a larger internal array and copying the data

Thanks for your contribution.


ServiceWorker are not using --deploy-url

The service worker is loaded from the base url which is not working if i set a deploy-url
Versions
Angular CLI: 1.6.5
Node: 8.9.4
OS: darwin x64
Angular: 5.2.1
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router, service-worker

@angular/cli: 1.6.5
@angular-devkit/build-optimizer: 0.0.42
@angular-devkit/core: 0.0.29
@angular-devkit/schematics: 0.0.52
@ngtools/json-schema: 1.1.0
@ngtools/webpack: 1.9.5
@schematics/angular: 0.1.17
typescript: 2.6.2
webpack: 3.10.0

Repro steps

ng build --deploy-url something/different/than/the/base/url

Observed behavior
Angular uses the base url instead of deploy-url
Desired behavior
The service worker is loaded by following rules:

take absolute url if given
fallback to deploy-url
fallback to base url

This is quite an important bug. Can we maybe remove the freq: low tag so it gets a little more attention and love?

For anyone reading this, I managed to get around without too much messing around by re-generating the ngsw.json with the following command
./node_modules/.bin/ngsw-config myDistFolder pathToNgswConfig deployUrl

in my case
./node_modules/.bin/ngsw-config dist/apps/viewer ./ngsw-config.json /viewer

@santialbo-actimo does your solution work for CDN urls as well? For example if I set deployUrl to https://cdn.mydomain.com/

From looking at docs/design/deployurl-basehref.md, it seems that deployUrl is quite inconsistent and baseHref might be a better alternative. There was also a PR to remove it, but it didn't make it for 6.x: angular/devkit#505
I am trying to understand the usecase. Wouldn't --baseHref work for you instead of --deployUrl and if not why?

Our cdn is on a different url than the application self.
Example:
https://myapplication.domain.com/ <- index.html is served by a server (configurations are made on the fly)
and the deployments of the resources are on the cdn url
https://cdn.domain.com/.....
Thats the reason why i like the different possibilities for basehref and deploy url

So, other than index.html what other files are served from https://myaplication.domain.com/?

@tfiwm Using an HTML base HREF of https://cdn.domain.com and an Angular APP_BASE_HREF of / may work for your use case.  With the advantage of directly referenced assets or scripts automatically using the correct base path (i.e., in this case the CDN).

Sounds great and we will try it ;)
How will be the /ngsw-worker.js handled? Based on html base HREF or the APP_BASE_HREF

At

Can you please also guide where do we set APP_BASE_HREF and --baseHref
Should we set APP_BASE_HREF as provider in AppModule as suggested https://angular.io/api/common/APP_BASE_HREF
  providers: [{provide: APP_BASE_HREF, useValue: '/my/app'}]
and --baseHref as parameter when building prod bundles?

We set the cdn base path with --baseHref
Why?
Resources are getting loaded by the
<base href="MY_CDN_DOMAIN">

-> relative paths in scripts or other assets are getting loaded from there
We set the APP_BASE_PATH for our application (routing)->
Something really important here! If you have a dynamic value use a FactoryProvider otherwise a ValueProvider is enough.
Here an example with dynamic value
export const initAppBaseHref = () => {
  return environment.appBaseHref;
};

export const baseHrefProvider: FactoryProvider = {
  provide: APP_BASE_HREF,
  useFactory: initAppBaseHref
};

providers: [baseHrefProvider]

I tried this but receiving below error when I deploy the website:
ERROR Error: Uncaught (in promise): SecurityError: Failed to execute 'replaceState' on 'History': A history state object with URL 'https://www.mycdnurl.com/' cannot be created in a document with origin 'https://www.websiteurl.com' and URL 'https://www.mywebsiteurl.com/'.
Error: Failed to execute 'replaceState' on 'History': A history state object with URL 'https://www.mycdnurl.com/' cannot be created in a document with origin 'https://www.websiteurl.com' and URL 'https://www.mywebsiteurl.com/'.

in my AppModule I have added
import { APP_BASE_HREF } from '@angular/common';
...
providers: [
    ...
    { provide: APP_BASE_HREF, useValue: '/' }
  ],

When I manually edited the Index.html file and replaced
<base href="https://www.mycdnurl.com/" />
with
<base href="/" />
and added CDN to the path of javascript bundles, it started working.
I built app with  --baseHref https://www.mycdnurl/

your <base href="https://www.mycdnurl.com/path/to/dist" /> should be your cdn because all the relative files generated by angular cli will loaded from there.
{ provide: APP_BASE_HREF, useValue: '/' } -> must return the path to your application base href (necessary for the router)
I am using following trick in my environment file
{
  appBaseHref: `${window.location.origin}/`
}

Not sure if this will work with serverside rendering too but in my case it was working with a factoryprovider

@gkalpak @clydin @filipesilva
I tested my app with different configurations and below is my conclusion:
Using an HTML base HREF of https://cdn.domain.com and an Angular APP_BASE_HREF of / doesn't work.
Using an HTML base HREF of https://cdn.domain.com and dynamically setting Angular APP_BASE_HREF to mydomain.com works.
e.g.:
environment.appBaseHref: window.location.protocol + "//" + window.location.hostname + (window.location.port ? ':' + window.location.port:'')
{ provide: APP_BASE_HREF, useValue: environment.appBaseHref }
Though the second option works, but it introduces another issue, since we have now set the HTML base HREF to our CDN domain, this breaks other libraries that we are using. For example in my case
we are using other libraries such as Firebase Messaging for Push Notifications. When HTML base HREF is set to CDN it doesn't work.
I think we do need support for --deploy-url
So, when  --deploy-url is provided, the urls generated in service worker should have the --deploy-url prepended to the assets.
@tfiwm can you please re-open this issue?


bazel: fix for consuming builds

Signed-off-by: Matt Klein<EMAIL_ADDRESS>

@htuch @jmillikin-stripe


Add host target triple for RaspberryPi arm-linux-gnueabihf

My RaspberryPi cross compiler toolchain instructions break in SPM 4.1 because it hardcodes(!) the architecture. The proper fix would be to remove all this hardcoding, but meanwhile, this adds the specific target triple, similar to what people do for S/390 and PPC.

Hm, I think its hardcoded to get the triple name but I don't remember the details. /cc @weissi

@swift-ci please smoke test

I'm sure there are going to be a lot more requests like this one and we're going to wind up with a big list of different hardcoded architectures.  I was going to submit a request to add aarch64-unknown-linux for 64-bit ARM systems but I thought I would wait and see if this is really the way we're going to proceed.

Maybe we can dump this information from the compiler. /cc @jrose-apple

@aciidb0mb3r looks okay to me

Hm, I think its hardcoded to get the triple name but I don't remember the details

Can we figure out how/why this happened and why it is necessary? It seems really wrong to me that a build system should know about such stuff (apart from stuff being passed into it, e.g. by the toolchain).

The compiler will default to compiling for the host OS if you don't pass any target. That gets tricky on macOS because the version of the OS matters too, but elsewhere it should be fine.
In the general case, it doesn't make sense to ask "what target should I use for this given compilation environment" because that's what a target is. I guess you could leave out components and the compiler could try to fill them in, but I'm not sure you want to rely on that.

No, that's not correct. A single toolchain can often be used to build products for multiple targets. For example, the toolchains in Xcode can build for any Apple platform, and the toolchains on Linux can usually build for either i386 or x86_64.

I can understand having an internal list of supported targets

Why would you want that in SPM? It simply doesn't matter to the build system itself? Do you want to update that every time when the Swift compiler can emit for a new architecture? That doesn't seem reasonable, and BTW it worked just fine up to 4.0. I think the hardcoding must have sneaked in by accident.

IIRC, this was added as part of cross-compilation support, a feature that 4.0 did not have.

@neonichu --destination was part of 4.0, that is my complaint ... it worked just fine in 4.0, but is now b0rked in 4.1 ;-)

@jrose-apple the --destination and the corresponding .json files don't abstract over LLVM in any way and I agree that'd be bound to fail. Here's an example destination.json file:
$ cat devel/swiftxc/cross-toolchain/ubuntu-xenial-destination.json
{
    "version": 1,
    "sdk": "/Users/johannes/devel/swiftxc/cross-toolchain/ubuntu-xenial.sdk",
    "toolchain-bin-dir": "/Users/johannes/devel/swiftxc/cross-toolchain/swift.xctoolchain/usr/bin",
    "target": "linux-unknown-x86_64",
    "dynamic-library-extension": "so",
    "extra-cc-flags": [
        "-fPIC"
    ],
    "extra-swiftc-flags": [
        "-use-ld=gold", "-tools-directory", "/Users/johannes/devel/swiftxc/cross-toolchain/swift.xctoolchain/usr/bin"
    ],
    "extra-cpp-flags": [
        "-lstdc++"
    ]
}

Ah, my bad for not paying attention to the package manager cross-compilation stuff!

So what needs to happen to get this from Open to Merged? I really would like to be able to x-compile for Raspi again.

https://bugs.swift.org/browse/SR-7612


Adds option to configure ExchangeStrategies on WebClient

This PR is meant to add the capability to adjust some options on the inner WebClient, namely to configure ExchangeStrategies

use CustomizableWebClientBuilder


Allow service to be disabled completely

Add an option to disable autostart of the datadog service completely, this will allow the service to be started after a machine has booted up and is ready to service traffic.

Fixed by #3


URL to Azure Storage Client Libraries 404

URL pointing to https://msdn.microsoft.com/library/azure/dn261237.aspx pointing to Azure Storage Client Libraries is incorrect.
404 - Page not found error

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b46c09cf-2ce5-b822-7b07-40b809256e72
Version Independent ID: 124a9438-9a25-e118-591e-4415373402c9
Content: Introduction to Azure Files
Content Source: articles/storage/files/storage-files-introduction.md
Service: storage
Sub-service: files
GitHub Login: @roygara
Microsoft Alias: rogarana

@isehuetdk Thanks for your question. We are checking on this and will respond to you soon.

@isehuetdk It looks perfect there is no 404 error,
This content has been moved. Please see Azure Storage Client Library for .NET
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue for the client library reference.


Use fmt::Display to format error messages in logs

This PR changes the proxy to log error messages using fmt::Display whenever possible, which should lead to much more readable and meaningful error messages
This is part of the work I started last week on issue #442. While I haven't finished everything for that issue (all errors still are mapped to HTTP 500 error codes), I wanted to go ahead and open a PR for the more readable error messages. This is partially because I found myself merging these changes into other branches to aid in debugging, and because I figured we may as well have the nicer logging on master.

@seanmonstar sorry for the mess, I was working on mapping more errors to specific error codes & commented out the work in progress code rather than deleting it. c25133777fc2358d797fc98758d746452f5b4562 should clean it up a bit!


add golang 1.20 to test matrix

Adds the newly released Golang 1.20 to the test setup.

Codecov Report

Merging #1157 (f2a8cc7) into master (6153c1e) will increase coverage by 0.06%.
The diff coverage is 92.59%.

@@            Coverage Diff             @@
##           master    #1157      +/-   ##
==========================================
+ Coverage   49.40%   49.46%   +0.06%
==========================================
  Files         127      127
  Lines       12290    12303      +13
==========================================
+ Hits         6072     6086      +14
+ Misses       4840     4839       -1
  Partials     1378     1378

Impacted Files
Coverage Δ

utils.go
72.72% <ø> (ø)

dns.go
68.69% <92.45%> (+4.97%)
:arrow_up:

workers.go
57.14% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Provide dnsChallenge credentials per resolver

Do you want to request a feature or report a bug?
Feature
What did you expect to see?
multiple resolvers is 🔥
but what if I have multiple accounts
something like this:
[certificatesResolvers.sample1.acme]
  email =<EMAIL_ADDRESS>  storage = "acme/acme.json"
  [certificatesResolvers.sample1.acme.dnsChallenge]
    provider = "cloudflare"
    <API_KEY> = <.......>
[certificatesResolvers.sample2.acme]
  email =<EMAIL_ADDRESS>  storage = "acme/acme.json"
  [certificatesResolvers.sample2.acme.dnsChallenge]
    provider = "cloudflare"
    <API_KEY> = <.......>

use case: Traefik running multiple domains that belongs to different accounts on Cloudflare

Hi @bstuff , thanks for reporting this use case. This issue is labelled as "proposal" as there should be a discussion on the topics below:
It looks like that implementing this would require the following challenge to be solved:

Disparity of behavior between DNS providers: using token, API key, instance profiles or any other way for using account credentials depends on the provider. This could cause a lot of complexity.
Some providers make it really hard for this. Example with AWS where the client has to manage credentials between API keys, instance profiles and IAM roles. Profiles should be used in this case, but only in this case.

Finally, please note that this proposal would lead to some changes in Lego (the library used for ACME usage in Traefik), not only on Traefik.

Hello, something is new for that proposal ?
I ask because i want setup traefik with multiple domains but i have multiple credentials :(
For now i am oblige to manage certificates with certbot externally to traefik.
Thanks.

May be a solution is to run the lego as a separated process? It would be really nice to have separated credentials per domain…

I have a specific use case for this, which I hope will bring interest to this feature request.
I share a server with someone, and we have two domains, one each. We use Traefik to redirect users to our respective containerized services and provide the respective certificates, which are both wildcard certs.
It'd be a great value to add this feature to Traefik, since I think it matches its philosophy quite well.
Being able to configure secrets per provider would also be quite nice.
#5632 seems related

Here is an idealized Dockerfile that mimics the actual DNS challenge user guide.
version: "3.3"

services:

  traefik:
    image: "traefik:v2.1"
    container_name: "traefik"
    command:
      #- "--log.level=DEBUG"
      #- "--api.insecure=true"
      - "--providers.docker=true"
      - "--providers.docker.exposedbydefault=false"
      - "--entrypoints.web.address=:80"
      - "--entrypoints.websecure.address=:443"
      # Arguments related to generating "domain1.ex" certificates
      - "--certificatesresolvers.domain1_resolver.acme.dnschallenge=true"
      -<EMAIL_ADDRESS>      - "--certificatesresolvers.domain1_resolver.acme.storage=/letsencrypt_domain1/acme.json"
      - "--certificatesresolvers.domain1_resolver.acme.dnschallenge.provider=_domain1_provider"
      # would be best to use secrets here
      - "--certificatesresolvers.domain1_resolver.acme.dnschallenge.provider.apikey=..."
      # Arguments related to generating "domain2.ex" certificates
      - "--certificatesresolvers.domain2_resolver.acme.dnschallenge=true"
      -<EMAIL_ADDRESS>      - "--certificatesresolvers.domain2_resolver.acme.storage=/letsencrypt_domain2/acme.json"
      - "--certificatesresolvers.domain2_resolver.acme.dnschallenge.provider=_domain2_provider"
      # would be best to use secrets here
      - "--certificatesresolvers.domain2_resolver.acme.dnschallenge.provider.apikey=..."

    ports:
      - "80:80"
      - "443:443"

    volumes:
      - "/var/run/docker.sock:/var/run/docker.sock:ro"
      # Bind mount storing certificates for "domain1.ex"
      - "/home/domain1_postmaster/lets_encrypt:/letsencrypt_domain1"
      # Bind mount storing certificates for "domain2.ex"
      - "/home/domain2_postmaster/lets_encrypt:/letsencrypt_domain2"

  whoami_domain1:
    image: "containous/whoami"
    container_name: "whoami_domain1"
    labels:
      - "traefik.enable=true"
      - "traefik.http.routers.whoami.rule=Host(`whoami.domain1.ex`)"
      - "traefik.http.routers.whoami.entrypoints=websecure"
      - "traefik.http.routers.whoami.tls.certresolver=domain1_resolver"

  whoami_domain2:
    image: "containous/whoami"
    container_name: "whoami_domain2"
    labels:
      - "traefik.enable=true"
      - "traefik.http.routers.whoami.rule=Host(`whoami.domain2.ex`)"
      - "traefik.http.routers.whoami.entrypoints=websecure"
      - "traefik.http.routers.whoami.tls.certresolver=domain2_resolver"

I'm wondering if it would be possible to ask traefik to update the env variables before a call into lego client. It is not ideal, because at the moment traefik does not even know that they exist, and it will have to. But the advantage of that approach is that lego won't need to be changed. Of course it will require synchronisation so no more than one challenge for a particular dns provider is running at the same time, but this is doable. This could be an interim solution, until we can figure out how to do this better, it does not seem that there are a lot of options though.
Otherwise people have no choice but to run two instances of traefik.

Is there a solution in sight? Will there be a solution at all? Where can I find out more?

I have a similar need -- I am looking for options to leverage multiple godaddy accounts (several different API keys).
Here is a link to a thread I started in the community on it (almost identitical to @bstuff original post
https://community.traefik.io/t/traefik-let-s-encrypt-dns-challenge-with-multiple-instances-of-same-provider/7917
Any chance of getting this into the road map?  Right now it seems the only option is to run multiple copies of traefik (different docker servers).

any news here ?

Could a temp solution be to use "External Program" provider?
You could then write a wrapper around another dnsChallanger or your own challanger. Just extract the host and match it against a collection of credentials?

Could a temp solution be to use "External Program" provider?
You could then write a wrapper around another dnsChallanger or your own challanger. Just extract the host and match it against a collection of credentials?

Is it possible to use for example "certs bots" and provide the certificat to traefik ?

Could a temp solution be to use "External Program" provider?
You could then write a wrapper around another dnsChallanger or your own challanger. Just extract the host and match it against a collection of credentials?

Is it possible to use for example "certs bots" and provide the certificat to traefik ?

Any updates here?

No news for me ...

@ldez maybe you have some thoughts on how can this issue be resolved properly?
If so, can you please share them with community?
Maybe we would be able to bring you a good solution based on your thoughts.
Right now this issue seems to be abandoned and I'd like to bump it.

I hope this gets fixed soon. I'm stuck using let's encrypt for a whole set of subdomains and I can't assign a new acme provider without dns challenge. I don't want to try to run two traefik instances and combine them or something.
- --certificatesresolvers.resolverA.acme.caServer=
- --certificatesresolvers.resolverA.acme.email=
- --certificatesresolvers.resolverA.acme.storage=/acme.json
- --certificatesresolvers.resolverA.acme.eab.kid=
- --certificatesresolvers.resolverA.acme.eab.hmacEncoded=

# cloudflare dns challenge
- --certificatesresolvers.resolverA.acme.dnsChallenge.provider=cloudflare
# this!!! it should be local not global!
- --certificatesresolvers.resolverA.acme.dnsChallenge.env.CF_API_EMAIL=
- --certificatesresolvers.resolverA.acme.dnsChallenge.env.CF_API_KEY=

I don't see this being too hard to implement? When registering resolverA, instead of getting CF_API_EMAIL and CF_API_KEY from the process environment, just pick it up from the config it's currently in: certificatesresolvers.resolverA.acme.dnsChallenge.env
I would add it in myself but I've never used go before.

Okay I see the problem. This is where it fetches things:
https://github.com/go-acme/lego/blob/8e7bba485fe98dcb6f116eb9f524cd37312540ac/providers/dns/cloudflare/cloudflare.go#L70
It's in a different library hmm.

Lego calls a function named GetOrFile here:
https://github.com/go-acme/lego/blob/8e7bba485fe98dcb6f116eb9f524cd37312540ac/platform/config/env/env.go#L146
Which will look for CF_API_EMAIL_FILE and read it's contents. This sounds so silly, but if you were to create a temporary file and write to it before initializing the dns provider... haha nevermind...
It doesn't look there's an easy fix other than working together with the lego people to add a new function to replace here:
https://github.com/traefik/traefik/blob/ce2e02b6904329d4c62a2f04e2707869ea525271/pkg/provider/acme/provider.go#L269
NewDNSChallengeProviderByNameWithCustomEnv..?

I found this issue after a discussion with a user who is impacted by this.
Not sure why recent comments that share community-based investigations toward a solution (for example those by @makitsune) are being marked as off-topic, especially while repeated comments that only ask for updates remain unflagged. This community-driven sharing is what makes open source productive and useful. I think they should be un-flagged to reveal useful information and add context to what's happening in the code.
Indeed, as @makitsune shows, the underlying ACME library, lego, reads DNS provider credentials from environment variables. This makes it difficult/impossible to configure different provider credentials in a single environment, at least with the current implementation of lego.
While my comment will probably get hidden, I wanted to propose a solution to be considered anyway, with some background.
About a year and a half ago, I raised an issue in lego similar to this one, and later proposed a change that treated env vars as optional defaults instead of as the only way to configure the credentials.
I admit I wasn't able to design a satisfactory solution without making other major changes to the code base, so I let the PR be closed. My solution instead was to write a leaner ACME library named acmez that has a completely different API. It can be configured with a DNS challenge solver that gets its credentials without the need for environment variables.
The DNS solver I implemented is in CertMagic, and it's an exported type so it can be used by any library, including lego. Notice that the DNSProvider field is a type that uses any libdns implementation:
type ACMEDNSProvider interface {
	libdns.RecordAppender
	libdns.RecordDeleter
}

libdns is a set of interfaces implemented by a collection of libraries that manipulates records on various DNS providers. In this case, ACME challenges require appending and deleting records, hence the above interface. There are already a fair number of implementations, with more on the way -- and they're relatively easy to implement new ones.
(We know this works because this is what Caddy 2 uses to support multiple DNS credentials per config.)
tl;dr - Using certmagic.DNS01Solver along with libdns libraries (and possibly acmez which is already compatible with them) can solve the issue at hand since these APIs do not require the use of the environment. It may require some changes in lego, but the changes in Traefik -- if any at all -- should be minimal.

@mholt excellent suggestion and approach.  Hopefully the traefik team is interested in it.

To illustrate more concretely, here is what a solution could look like (again, this would have to go inside lego, probably -- and I've omitted details like getting the ACME account and private key):
client := acmez.Client{
	Client: &acme.Client{
		Directory: "https://...",
	},
	ChallengeSolvers: map[string]acmez.Solver{
		acme.ChallengeTypeDNS01: &certmagic.DNS01Solver{
			// notice that credentials are not provided by env vars (but could be by using os.Getenv)
			DNSProvider: &cloudflare.Provider{
				APIToken: "secret",
			},
		},
	},
}

ctx := context.Background()

// put your domains here that are associated with the DNS credentials above
domains := []string{"example.com"}

certs, err := client.ObtainCertificate(ctx, acmeAccount, certPrivateKey, domains)

Notice how DNS providers can be plugged into the solver config easily, and doesn't require the use of env vars, but does allow them if you want. An approach/API like this could resolve the issue. But I do think actual dev work would need to be tracked in go-acme/lego.

The suggestions made by @makitsune and @mholt are based on the same assumption that all DNS providers can be configured via environment variables or with a simple configuration structure but this assumption missed that there are several ways to configure DNS providers and some of them don't use environment variables/configuration structure but elements based on the system configuration.
The problem has been already explained here:

https://github.com/go-acme/lego/issues/1054#issuecomment-583901705
https://github.com/traefik/traefik/issues/5472#issuecomment-534908109

Be sure that I know really well the problem, I have already spent a lot of time trying to find a solution, and I still looking for viable approach.

I have already spent time finding a way to have several configurations for a single provider, but it is quite difficult because of non homogeneous providers behavior.
https://github.com/go-acme/lego/issues/1054#issuecomment-583919285

If you want to dicuss more about that feel free to open an issue on lego.

Question, have you seen the approach that Posh-Acme?  The model he took seems to work well with almost any DNS based system.

Maybe this sounds silly and might not be possible in go, but when using node sounds reasonable: to spin up a new thread/instance with the resolver defined environment variables and close it when its done.

Yes I know the other ACME clients and in Go we have Go routines (~threads) but it's neither the problem nor the solution.
I will repeat: some DNS providers don't use environment variables/configuration structure but elements based on the system.
Please, if you want to discuss more feel free to open an issue on lego.

Can you help us understand what you mean by that? Like what are examples of DNS libraries that can only be configured by external settings and not by code?

Please, if you want to discuss more feel free to open an issue on lego.

If going by the replies there seems no option other than consolidate all domains into one authoritative DNS provider (Cloudflare in my case) and then use DNS-01. This solution is not possible as some clients have their own CF account and are not comfortable delegating their domain to someone else's CF account.

A solution can be to use CNAME: you add a CNAME to only one domain, and you will only need one account.
If you have example.org (account foo) and example.com (account bar) you can create a CNAME on example.org called _acme-challenge.example.org pointing to _acme-challenge.example.com.
So you need only one account (foo) to handle the challenge for all the accounts.
https://letsencrypt.org/2019/10/09/onboarding-your-customers-with-lets-encrypt-and-acme.html#the-advantages-of-a-cname

A solution can be to use CNAME: you add a CNAME redirecting to only one domain, and you will only need one account.
If you have example.org (account foo) and example.com (account bar) you can create a CNAME on example.org called _acme-challenge.example.org pointing to challenge.example.com. So you need only one account (foo) to handle the challenge for all the accounts.
https://letsencrypt.org/2019/10/09/onboarding-your-customers-with-lets-encrypt-and-acme.html#the-advantages-of-a-cname

Thank you, this works perfect!
For anyone using Cloudflare, do not forget to turn off the "Orange" proxy for the _acme-challange.example.org CNAME

I have created a repository called traefik-multi-instance-letsencrypt that provides a solution to this issue. The repository includes a sample setup that uses Docker Compose and Traefik to demonstrate how multiple instances of Traefik can be used together to handle HTTP to HTTPS redirection and domain-specific routing with unique Let's Encrypt certificates. This setup can be used as a starting point for your own projects that require similar functionality.

I hit a roadblock with this. I want to get traefik to request wildcard certificates from letsencrypt, for domains hosted on separate Gandi accounts, but it seems that I can only use a single gandi api key. I hope this feature will be added in the near future.

welcome to 2024.  it is shame that traefik cannot handle functionality which can be handled by caddy2.

I take it this will not be implemented? If so, that is a bummer.

Especially because the 'cname' way is not what this feature is about: example.org is not supposed to be an 'alias' for example.com...

May be as alternative solution will be good to implement directory or certificate watch and reload certificates in moment if updated certificate in certificate folder. In that case it will be quite easy to use certbot and cron to update certs.

The CNAME alias is not on example.org but on _acme-challenge.example.org.

Oooh weew sorry @ldez! I just saw your comment higher up and link, now I get it!

To clarify the situation, as @ldez explained here, today there is no way to support multiple ACME accounts due to the heterogeneous DNS challenges implementations. The workaround that Let's Encrypt proposes is to use CNAME. Not only this solves this issue, but it brings additional benefits. I invite to read the Let's Encrypt blog post.
We updated our documentation to clarify this accordingly.


store raw app instances metrics to database

[#131839215]

get raw instance metrics from loggregator
store raw instance metrics to metrics database

Note:

using the raw instance metrics for aggregation will be done in story #131839361
will remove previous metrics table and related code after story #131839361 is done

I committed a change to add index, and revised test cases accordingly. Please review


lazy not working for recursive parser

I have this mini parser for add expression. But compiler overflows due to the recursive structure. I saw lazy seems to be the solution for this but can't figure out why it doesn't work.
term : Parser Utf8 U64
term = alt digits (lazy (\_ -> expr) |> between (codeunit '(') (codeunit ')'))

expr : Parser Utf8 U64
expr = const (\x -> \y -> x + y) |> apply (lazy \_ -> term) |> skip (codeunit '+') |> apply (lazy \_ -> term)

expect parseStr expr "1+2" == Ok 3u64
expect parseStr expr "1+(1+2)" == Ok 4u64

The Elm equivalent works fine
parens = Parser.succeed (\v -> v) |. Parser.symbol "(" |= expr |. Parser.symbol ")"

term = Parser.oneOf
        [ Parser.int
        , parens
        ]

expr = Parser.succeed  (\x y -> x + y) |= Parser.lazy (\_ -> term) |. Parser.symbol "+" |= Parser.lazy (\_ -> term)

main =
    "1+(2+3)"
        |> Parser.run expr
        |> Debug.toString
        |> text

I think it's related to the compiler bug here https://github.com/roc-lang/roc/issues/4288


Use new Material Design color palette

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡

Material UI should follow the latest MD specs for the dark theme colors. And not just colors, this also applies for surfaces and other UI components.
Might be related to https://github.com/mui-org/material-ui/issues/17241.
Examples 🌈

Motivation 🔦

I think it's important to follow the specs closely, makes it easy to align with native mobile apps that use the same MD specs.

Are these colors not available in the color palette or are you suggesting we should change the default primary and secondary color?

elevation is achieved using a white overlay with transparency

#18309?

I agree, https://github.com/mui-org/material-ui/issues/18309 describes part of the issue.
According to the specs, the background color and paper color is #121212. That is not the case for Material UI. Take the drawer from the docs as is on the online docs today:

The background for the drawer is #424242. Though, the main background seems to be correct.
As for the colors, the default primary color is #bb86fc and default secondary is #03dac6 (in the material design spec - as seen in the image I added to the issue body). I cannot find these in any of the pink or cyan palettes. But maybe they have changed the way they aggregate these colors from the 2014 palettes.
You can find more about the dark theme guidelines in the Dark Theme  section.

@rolandjitsu Ok thanks, let's close for #18309 and #18308 that cover two issues with the dark theme. If you see something else, please open a specific issue. Thanks

@oliviertassinari sure, how about the colors? Is there another issue for this?

What's the issue with the color?

Ok, we will come back to it for v5, in 1 year.


Bump pathwatcher version to fix installation issues #45 and #47

@danielgtaylor Could we get this merged? :+1:

@danielgtaylor ping!

@danielgtaylor looking forward to this 😄 :+1:

@danielgtaylor 🙏

Yes please.

@danielgtaylor bump :+1:


Empty Property names: can be created and behaves very destructive

Reported by atze on 11 Jul 2014 21:10 UTC
It is possible to create properties via web interface with an empty property name.
This gives very strange result when viewing the ticket and prohibits any further editing of ticket properties.
When editing properties, such with an empty name should be filtered.

Modified by texec on 12 Jul 2014 09:00 UTC

Comment by atze on 21 Sep 2014 17:23 UTC
This problem still exists, now it's impossble to even view a ticket after assigning a property with empty key.

Comment by texec on 22 Sep 2014 21:38 UTC
Constrain added in [by atze, error message added in changeset:902fe1d.
Still missing: constrains for project properties and languages.

Modified by texec on 20 Oct 2014 14:57 UTC

Comment by atze on 3 Nov 2014 22:32 UTC
hopefully fixed in changeset:f83ed83


static labels not working with leaflet labels and markercluster

From @muuuub on December 25, 2014 2:42
Static labels won't show up in angular-leaflet-directive using markercluster.
Here is my marker:
m1: {
    lat: 51.5,
    lng: 0,
    focus: true,
    draggable: false,
    group: "my_cluster_group",
    label: {
        message: "Hi there",
        options: {
            noHide: true
        }
    }
}

If noHide: false then the label will show up if you over over the marker, but it won't be a static label.
There was an issue filed on the leaflet.label github related to this:
https://github.com/Leaflet/Leaflet.label/issues/35
However the issue was marked as fixed (for desktop), so I think this problem might be something to do with angular-leaflet-directive.
I'm using:
leaflet.label 0.2.1
markercluster 0.4.0
leaflet 0.7.3
angular-leaflet-directive 0.7.9
Copied from original issue: tombatossals/angular-leaflet-directive#581

From @tombatossals on December 29, 2014 12:23
Please, could you write a jsfiddle as an example of this issue?


Allow batch usage of the seed command for games

Add an option for updating the seed for all games installed, or at least a subset. Useful for things such as CIAngel and freeshop where the eshop is not wanted to be opened for one reason or another. It become tedious to have to select each game and fix the seed, and if a large list of games are downloaded at once, the user might not even remember which games need it vs not needing it

CIAngel and freeShop now install the seed automatically, as does FBI when a title with a seed is installed. Not sure if this would really be necessary.

Opened this issue before freeshop added seed support. Thanks for responding to it anyway


README.md: keep the example up-to-date

🤔 What's changed?
The README has a YAML sample to use in one's project.
⚡ What's your motivation?
To make the sample even-more-easily copy-pasteable, I wanted the user to avoid deprecation warnings from GH Actions.
🏷 What kind of change is this?

:bank: Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

📋 Checklist:

[x] I agree to respect and uphold the Cucumber Community Code of Conduct

I'll have a look at the failure.

@mpkorstanje I assumed the failure was that it ran on my user's behalf, and I don't have the Rubygems secrets, "Access Denied. Please sign up for an account at https://rubygems.org/" - but I could be off.


fix(core): enable date and time types support in vineyard-graph (and GIE)

Codecov Report
Attention: 64 lines in your changes are missing coverage. Please review.

Comparison is base (a383a34) 70.97% compared to head (406033a) 34.52%.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #3498       +/-   ##
===========================================
- Coverage   70.97%   34.52%   -36.46%
===========================================
  Files         110      109        -1
  Lines       11384    11426       +42
===========================================
- Hits         8080     3945     -4135
- Misses       3304     7481     +4177

Files
Coverage Δ

python/graphscope/framework/utils.py
44.81% <3.44%> (-26.79%)
:arrow_down:

python/graphscope/tests/minitest/test_min.py
0.00% <0.00%> (ø)

... and 68 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a383a34...406033a. Read the comment docs.

See also: https://github.com/v6d-io/v6d/pull/1721


Publish javadocs on github pages

Like we do with AutoDispose. Should link it in the README as well

This is done: https://uber.github.io/crumb/0.x/


[Bug] Don't support  one tile covers another one

When a tile has something (e.g.  grass )  need to  cover other tile.
They can't be rendering correct.

Isn't that problem of how do you order tiles?

I think I'm right . I debug & test . the order is right.
I've used Tiled many years , and  wrote some Tiled's lib/tools/utils  with different game engines.
I think  I don't   make the basic mistake.
of course , maybe I maked some other mistakes.
But I've no idea now. So sad.
Could you give me some adviace ?
BTW , When I render the map with PIXI.ParticleContainer &  many Sprites, everything  is OK.
The logics of these tow ways  are the same .
.

Well take only 5x5 map and look the order you call addRect().

I make a 1*2 , the order is right
index 23 is water , 7 is grass .
x y is a relative postion.

I found that :
the tile with big index is be put into  the last  child (children) of CompositeRectTileLayer.
                var layers = this.children;
                for (var i = 0; i < layers.length; i++)
                    layers[i].renderWebGL(renderer, this.useSquare);

So , the rendering order is not as same as  addFrame/addRect order.

Then make it that way it belongs only to one layer.

one layer only could include 16 textures.
one texture is one tile . the tileset include many tiles.

then how does it work with ParticleContainer?

Because this code
              var maxTextures = this.maxTextures;
               if (len > 4 * maxTextures) {
                   return;
               }

the texPerChild could not bigger than 16.

I create many sprites as tiles.

I love this feature I suggested , but no one  like it https://github.com/pixijs/pixi.js/issues/3388

Current maxTextures = 4.
I don't what's mean , but I see this
http://webglstats.com/webgl/parameter/MAX_TEXTURE_IMAGE_UNITS
most devices support 16 textures .  so may be we could change the maxTextures to 8 or 16.
Then texPerChild could be 48 or 416. I think it's enough

May be you mistake Texture for BaseTexture?

"May be you mistake Texture for BaseTexture?"  what's mean ?

    // `imgLoader` is a function that load img object by `tileset.name , tileset.image`
    Map.prototype.createTileTextures = function(imgLoader) {
        var baseTextureTable = {};

        for (var i = 0, len = this.tilesetList.length; i < len; i++) {
            var tileset = this.tilesetList[i];
            var name = tileset.name;
            var image = tileset.image;
            var baseTexture;
            if (typeof imgLoader === 'function') {
                baseTexture = PIXI.BaseTexture.from(imgLoader(name, image));
            } else {
                baseTexture = PIXI.BaseTexture.from(image);
            }
            baseTextureTable[name] = baseTexture;
        }

        var tileTextures = [];

        for (var i = 0, len = this.tileList.length; i < len; i++) {
            var t = this.tileList[i];
            var baseTexture = baseTextureTable[t.tileset];
            var texture = new PIXI.Texture(baseTexture,
                new PIXI.Rectangle(t.x, t.y, t.w, t.h)
            );
            tileTextures.push(texture);
        }

        return tileTextures;
    };

    Map.prototype.createTilemap = function(tileTextures, texPerChild) {
        var tilemap = new PIXI.tilemap.CompositeRectTileLayer(0, tileTextures, false, texPerChild);

        return tilemap;
    };

Is there something wrong ?
Thanks

Ok, how many images do you have there? Can you assemble them into an atlas?

@ivanpopelyshev  , the image file (tileset) just one png.

@ivanpopelyshev ,  I think maybe pixi-tilemap needs a deep refactor.

support big tileset image
support more textures
The order of rendering should be as same as  the order of calling addFrame.

agree

Do you have some new plan or roadmap about pixi-tilemap ?


New version nudge

Ticket
Closes #1329
The existing nudge to refresh the webpage only happens when the app cannot find the specific javascript file in the server. As we don't purge the files on each build, the browser typically uses the cached version of the app, which could be weeks behind (based on the error logs).
Approach
Poll the current version periodically (set to 1 hour for now) and invoke the nudge when a newer version is detected.
We typically don't need to bump MINIMUM_VERSION unless there is an urgent need to make users move away from older versions (e.g. API changes, mistakes, etc.)
Trade-offs

Wanted to put the value in a separate file called .min.version so that the env's history won't be polluted with version bumps, but not sure how to implement with minimal code without having to read from the file. Getting from the env is the easiest to implement (per my limited knowledge).
This does not force the refresh (only nudges) since the user could be typing something. But the nudge is non dismissible, so annoying enough to just refresh the page in the next convenient slot.
This requires a full build, rather than changing a dynamic file in the server. This allows the bump history to be logged through git.

Since we won't use too often, should be fine. We can eventually separate our into its own env file if needed.


Parameterize OPA validation check commenting

Currently when using a custom run: step, digger is commenting for each service Terraform plan validation check. This is happening even when there are no OPA policies configured. When many plans are running, it is a lot of extra commenting without a real purpose. Please implement a way to disable this commenting when it is not necessary.

Hey thanks for reporting, on slack you also mentioned using cdktf. Does it mean you have overriden both the plan and apply steps of digger and you expect to not see any comments besides the summary comment in this case?


Option to leave some structure intact

It would be great to be able to specify that some fields at root level are not to be flattened but will still be outputted.
Here is an example: json
In the above, if you look under the key "solr_additions", there are many values in the list (one for each country in Africa). It would be great to output this, because it is useful, but not flatten it as it results in more than 50 keys ie. output it unflattened.

The point of flatten to me is that the resulting object has no structure (no iterables other than strings are present as values of the flat dictionary). This way you can easily pass the dictionary to Pandas.

The unflattened structure would need to be converted into a long string and in the above case, put under a single key called "solr_additions". json_normalize in Pandas behaves this way (but obviously doesn't have all the other flattening features of this library).
I don't know how this could be achieved outside flatten.

If I were to rank usefulness to me, it would be:

This ticket
https://github.com/amirziai/flatten/issues/13
https://github.com/amirziai/flatten/issues/12

Relative to the other 2, I think this one is much simpler to implement and easier to set up for the end user. The other 2 are for power users. Just my two cents.


Parse DATABASE_URL for connecting via psycopg2

DATABASE_URL works, it only needs to be parsed to pass the connection info to psycopg2.

Thanks. I think it is possible to get psycopg2 to use a url directly - but this works great.


fix(graph): Handle ghost connections in graph flow derivation

Add protection against invalid node references in connections and update graph version to 20241217

Skip connections that reference non-existent source/target nodes
Add test case to verify ghost connection handling
Update graph version to 20241217 with migration path
Update initialization and version checking logic

Fixes potential errors when processing broken graph connections

@toyamarinyon It seems the CI has failed. Could you fix it, please?

Sorry! I'll fix it quickly!


Plug-In System

Want to ask if plug-in system will be added or this plan is canceled !?
If Yes, I found this project sharing it may it help so don't need to implement system from scratch.
https://github.com/dejanstojanovic/Application-Plugin-Manager
Another video may be useful too 😄 (calling method despite its name)
https://www.youtube.com/watch?v=sUeRdmzRwbs

Plugin system is not canceled. It's on my todo list. I'll publish a roadmap for quasar soon so everyone can see what's the plan for the next months and in what direction quasar will go.

Thanks for fast replay. Hope to see it soon.
Good luck :)

https://github.com/BahNahNah/MLRat have too nice plugin system, but some hardcoded, but i think usefull


cometindex: 📇 add a minimal indexer prototype

Describe your changes
this is a continuation of #4573.
Adds the skeleton of a minimal but extensible indexer. The indexer consumes events from a source (raw event) database and writes to a destination database with compiled / processed tables. The indexer is a library that other binaries import and slot their indexes into.
The cometindex library is intended to be generic over any cometbft events. The pindexer binary is for penumbra specifically and we can add all our own code to it. This structure mirrors the existing distinction between comet (generic) and the app. The code is intended to be shaped so that it's easy for users to plug in additional indexes. In particular, all of the "meat" of the binary is in the cometindex::Indexer type, which builds an indexer and handles all arg parsing. This way, the external interface of the program, how it's invoked, etc, is the same no matter what app views are present, and orchestration code like containers doesn't need to be concerned with them.
Before merging:

[x] Rename the Index trait to AppView (it's a view of some application data)
[x] Rename the create_tables method to init_chain
[x] Add polling for ingesting / processing new events after the initial catch-up (500ms?)
[x] Make sure the pindexer AppView traits are public so that pindexer can be pulled in as a library
[x] Add an extension trait in the pindexer crate that adds an Indexer::with_default_penumbra_app_views() method that hooks in all the AppView impls, so we can add to it as we fill in impls

Followup:

[ ] Change init_chain to take a serde_json::Value and add plumbing to the Indexer builder to take a genesis.json file in a standardized way so that every instance of the binary doesn't need to implement that -- ideally this is the exact genesis.json that was used by comet, and the plumbing in the Indexer builder pulls out the app_state key and saves it to be able to pass it into each AppView. Longer term we could explore other options but for now I think it's simplest if we just make it a required parameter every time.

Closes #4604
Checklist before requesting a review

[x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

New tool outside of consensus

opened #4611 to track the follow-on work related to init_chain().

@hdevalence this is ready for review, when you are able to take a look


Fixes #166 update user fails when no password

Seems to have been introduced in commit eed33d2 during refactoring.

How about simply if update_data.get("password", ""): ?

I had this exact problem, fixed it with :
if update_data.get("password"):

How about simply if update_data.get("password", ""): ?

I use this but if update_data.get("password", default=False): to be even more explicit and avoid implicit type conversion.


open_karto: 1.2.0-0 in 'melodic/distribution.yaml' [bloom]

Increasing version of package(s) in repository open_karto to 1.2.0-0:

upstream repository: https://github.com/ros-perception/open_karto.git
release repository: https://github.com/ros-gbp/open_karto-release.git
distro file: melodic/distribution.yaml
bloom version: 0.6.6
previous version for package: null

open_karto
* Adds maintainer and branches for melodic
* Merge pull request #14 <https://github.com/ros-perception/open_karto/issues/14> from ros-perception/maintainer-add
  Adding myself as a maintainer for open_karto
* Adding myself as a maintainer for open_karto
* Merge pull request #11 <https://github.com/ros-perception/open_karto/issues/11> from Maidbot/minimum_time_interval
  Process scan if enough time has elapsed since the previous one
* Merge pull request #10 <https://github.com/ros-perception/open_karto/issues/10> from mikepurvis/fix-cpp11
  Use std::isnan/isinf, for C++11 compatibility.
* [Mapper] Take time into account in HasMoveEnough
  The function HasMovedEnough now also returns true if more than MinimumTimeInterval time has elapsed since the previously processed laser scan
* [Mapper] Add new parameter, MinimumTimeInterval
* Use std::isnan/isinf, for C++11 compatibility.
* Merge pull request #8 <https://github.com/ros-perception/open_karto/issues/8> from mig-em/feature/invalidScans1.1.4
  Add invalid scan detection for scanmatcher
* Merge pull request #9 <https://github.com/ros-perception/open_karto/issues/9> from Maidbot/ignore_min_readings
  Ignore readings less than the sensor's minimum range
* [Karto] Also ignore readings less than the minimum range
* Add invalid scan detection for scanmatcher
* Contributors: Luc Bettaieb, Michael Ferguson, Mike Purvis, Russell Toris, Spyros Maniatopoulos, mig-em

Holding for melodic sync


Update default logging configuration

By default, configured logging should log only at INFO level.
Current configuration in logback.xml files in the whole repository log at TRACE level.
Please refactor all logback.xml files and set logging to INFO level.

@Skejven do we also want to update the logback-test.xml files in a similar manner?


feat(uri): [normalizeURL] introduce helper to normalize url strings.

Codecov Report

Merging #11 (1c5be17) into master (e139c08) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #11   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            8         9    +1
  Lines          190       203   +13
  Branches        49        53    +4
=========================================
+ Hits           190       203   +13

Impacted Files
Coverage Δ

packages/uri/src/normalizeURL.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e139c08...1c5be17. Read the comment docs.


Create WASM asset to be downloaded by the extension

We don't want to check in the WASM file into the extension as it blows up the repo size. Rather we would like to bundle it as part of the extension release. Therefor we need a downloadable wasm file, preferably from the GitHub release.

@christian-bromann this is done. To download a WASM binary, follow either https://github.com/stateful/rdme/releases/download/v0.1.12/rdme_js_wasm.tar.gz or https://download.stateful.com/rdme/0.1.12/rdme_js_wasm.tar.gz. Let me know if this works as expected.


Vulkan backend not working on linux

Creating Sokol App backend
Main loop starting
Sokol app starting main loop
Sokol app context initializing
Sokol setup backend: gfx.Backend.GLCORE

Oh, sorry. This was a misunderstanding on my part. The list of backends Sokol actually supports is:
macOS: Metal + GL4.1
Windows: D3D11 + GL4.3
web: WebGL2 + WebGPU
iOS: Metal + GLES3.0
Android: GLES3.0
Linux: GL4.3macOS: Metal + GL4.1
Windows: D3D11 + GL4.3
web: WebGL2 + WebGPU
iOS: Metal + GLES3.0
Android: GLES3.0
Linux: GL4.3

Its fine thanks for clearing my doubt


[WIP] Read temperatures and use them for calibration curves

Hello @matteobachetti! Thanks for submitting the PR.

In the file srttools/io.py, following are the PEP8 issues :

Line 255:33: E127 continuation line over-indented for visual indent
Line 268:21: E127 continuation line over-indented for visual indent
Line 269:21: E128 continuation line under-indented for visual indent
Line 271:21: E127 continuation line over-indented for visual indent
Line 272:21: E128 continuation line under-indented for visual indent
Line 286:5: E722 do not use bare except'

In the file srttools/tests/test_io_and_scan.py, following are the PEP8 issues :

Line 22:1: E722 do not use bare except'


[ENTESB-5152] add support for OSGi WAR bundles

so far we only supported jar-based bundles. WARs
are, however, supported as well on Karaf/Fuse.
The code is a hack basically. It tries to search
search resources with WEB-INF/classes prefix to
cover the WAR use case. For 7.x we should look
into making this easier to undersntad, by e.g.
having two (or more) different classes

OsgiJarKieModule and OsgiWarKieModule. They
would then hide the implementation details
of WEB-INF/classes, etc. Implementing this for
6.x is a risk at this stage.

This is a forward port of #368. We need to come up with better approach, bot for now let's at least keep in sync with 6.4.x

+1


Inline editing for Tables

Introduce inline editing to data tables. This should expend the basic design approach described in #199.

@mcarrano #295 is redundant. Please confirm and close whichever one make sense.

Is the design on this complete?

No. This still requires design attention. I have not had time to get to it.

I've got a use case for this in Cloud Services Vulnerabilities. I want to be able to click a line in a table and edit the values involved.
Rox gave me a demo of what they currently have in Satellite where the entire table is editable vs the row being editable on its own (which I see in the PF3 docs). I'd prefer row, but could make the other work.

Thanks @katierik ! Can you list any product/project release(s) and timelines your trying to align with?
Are you interested in HTML/CSS only or leveraging a PF-React implementation?

I reviewed requirements in the PF design sync meeting today and we agreed to start with looking for parity with current PF3 offering as implemented in the PF3 React repo. Corresponding PF3 designs can be found here: https://www.patternfly.org/pattern-library/forms-and-controls/inline-edit/  There should be three possible levels of editing:

At the cell level, where user can make a single cell editable. PF3 React implementation
At the row level, where user can make an entire row editable. PF3 React implementation
At the table level, where the entire table can be made editable. PF3 React implementation

Based on these requirements, next step would be to create visual mockups that consider how these interactions can live in the PF4 table approach.

@bkjeffer thanks for agreeing to create initial wireframes and interaction spec for this feature. @rachael-phillips FYI.

Capturing requirements and initial design concepts here: https://docs.google.com/document/d/1oTqG-Ow6qk-9_3Vw-EVKx2RkHLBe8cuwqkpPferWSg4/edit?usp=sharing

Proposed wireframes in Invision: https://projects.invisionapp.com/boards/VR3U6GU9BM4/

I think that we have a good conceptual approach on this. I am going to kick it back to the backlog and tag for Visuals as I think that is the next step.

Here's my working doc that outlines inline editing in different contexts, including tables: https://docs.google.com/document/d/15aOWgpkd0Zp0hvbKM4jfG6Jf00FHjY_f92bkosbo1Ds/edit?usp=sharing

@mcarrano @kybaker
I made the updates since our sync up yesterday and have updated this document:
https://docs.google.com/document/d/15aOWgpkd0Zp0hvbKM4jfG6Jf00FHjY_f92bkosbo1Ds/edit?usp=sharing
As far as I'm concerned this is ready to move to CSS

Design complete.


cmd/bosun: Export time.ParseDuration as ParseDuration to templates

Fixes #1014

@kylebrandt what problem does this solve. It looks like @ayashjorden solved #1014 without it.

@captncraig See the associated issue. It makes it so we don't have to do some string replacement or ugly constants in the templates.

ok, change to parseDuration and merge.


Update grpc alt

Trying to avoid a patch in #982.

Just making it "ready for review" to get the CI to try it.

Ok the patch was necessary. Closing this :laughing:


E5108: Error executing lua [string ":lua"]:1: attempt to index field 'config' (a nil value)

I'm using the unstable branch like the docs said with neuron <IP_ADDRESS>, I also tried <IP_ADDRESS>, and I'm getting the following error when trying to create a new note, with the default setup and directory structure of this plugin.
E5108: Error executing lua [string ":lua"]:1: attempt to index field 'config' (a nil value)

My config looks like this.
  {
    "oberblastmeister/neuron.nvim",
    { branch = "unstable" },
    requires = { { "nvim-lua/popup.nvim" }, { "nvim-lua/plenary.nvim" }, { "nvim-telescope/telescope.nvim" } },
 }

@yutkat Thanks, if that was fully on me.


TLS 1.0 will be disabled

Nettaxpt announced that they will disable TLS 1.0 at November 1. Will that be an issue for existing implementations?
http://www.anpdm.com/newsletterweb/444A5842794842504376444359/424A58417043425B4B764142514171

The issue relates to the setup of servers running the gateway.  For example, the later versions of OpenSSL and libcurl must be installed. Old servers such as CentOS 5, Debian 5 and earlier may have issues. This isn't really related to the omnipay code or the netaxept gateway.
Most gateway providers have already switched over to supporting TLS 1.2 only.


unable to run demo

Hello, I'm trying to run the demo with the pre-trained model. I downloaded it and moved it inside a models/ directory, but I get this error.
python demo.py

Using TensorFlow backend.
Traceback (most recent call last):
  File "demo.py", line 9, in <module>
    from data_generator import generate_trimap, random_choice, get_alpha_test
  File "/Users/andy/Documents/projects/Deep-Image-Matting/data_generator.py", line 17, in <module>
    with open('Combined_Dataset/Training_set/training_fg_names.txt') as f:
IOError: [Errno 2] No such file or directory: 'Combined_Dataset/Training_set/training_fg_names.txt'

please contact author for dataset

Devin147 is correct, the demo relies on original dataset.

Hi foamliu, how can I get the dataset?

Follow the instruction (in README.md) to contact author for the dataset.
在 2018-09-12 12:27:36，"jjlchui"<EMAIL_ADDRESS>写道：
Hi foamliu, how can I get the dataset?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks.  刘杨
On Wed, Sep 12, 2018 at 1:48 PM 刘杨<EMAIL_ADDRESS>wrote:

Follow the instruction (in README.md) to contact author for the dataset.
在 2018-09-12 12:27:36，"jjlchui"<EMAIL_ADDRESS>写道：
Hi foamliu, how can I get the dataset?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/foamliu/Deep-Image-Matting/issues/1#issuecomment-420520123,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AnIs7N7tuok4Od1KgWxsJ3reaikx1IHvks5uaKAjgaJpZM4V0xi_
.

@jjlchui , Can you send me the Adobe datasets's link, I have send a email for author of Deep Image Matting, but I didn't get a reply.Thanks. My email is<EMAIL_ADDRESS>

@jjlchui , Can you send me the Adobe datasets's link, I have send a email for author of Deep Image Matting, but I didn't get a reply.Thanks. My email is<EMAIL_ADDRESS>

Can you send me the Adobe datasets's link, I have send a email for author of Deep Image Matting, but I didn't get a reply.Thanks. My email is<EMAIL_ADDRESS>

Can you send me the Adobe datasets's link, I have send a email for author of Deep Image Matting, but I didn't get a reply.Thanks. My email is<EMAIL_ADDRESS>

Sorry guys, I am not authorized to redistribute this dataset.

@jjlchui ,  @syoung125  @foamliu  @flyonok Can you send me the Adobe datasets's link, I have send a email for author of Deep Image Matting, but I didn't get a reply.Thanks. My email is<EMAIL_ADDRESS>

@jjlchui ,  @syoung125  @foamliu  @flyonok Can you send me the Adobe datasets's link, I have send a email for author of Deep Image Matting, but I didn't get a reply.Thanks. My email is<EMAIL_ADDRESS>


'cursorline' causes 'foldtext' to be evaluated too often

With :set cursorline &foldtext is evaluated every time when going to another line (i.e. when the cursor line is redrawn).
Given t-foldtext.vim:
let s:c = 0
function! F()
  let s:c += 1
    return 'foldtext: '.s:c
endfunction

set cursorline

set foldtext=F()
set foldmethod=marker
set foldlevel=0

" fold {{{
"
" }}}

When running vim -Nu NONE t-foldtext.vim --cmd 'source %' moving around
across lines will update the counter.
This also happens with just :set cursorline.
I've noticed this with vim-fugitive, which has a custom foldtext setting, and a
custom plugin that (un)sets cursorline dynamically, because &cursorline by
itself causes slowness due to too many redraws.

I think this is essentially the same issue as #2584 (in my testing, entire window gets redrawn, not only the  two lines really necessary)

so closing as duplicate of #2584

@chrisbra
Not sure if this is really a duplicate.
It might be similar to #2584 in regard to that hl_combine_attr is involved, but is a separate issue by itself.
For what it's worth it also happens with v7.4.2367 (i.e. not related to the bisected commit - if this is really the problem after all).
We can keep this closed as a duplicate, but the fix for #2584 should be verified to fix this issue here then, too.

@blueyed but the main problem with #2584 was never combine attr, rather the unnecessary redraws. And redraw evaluates foldline.


Add .Expand() to resolve $ref's

Hi, I'm working on a code generator for the AsyncAPI specification. It is very similar to OpenAPI. I wanted to use your package but I need to expand all the $ref pointers and get a proper JSON object. Is it something that you would like to add? Maybe it already exists and I'm missing something.
I can take care of it if you want.
Thanks!

[disclaimer: I'm not associated with this project, but I am part of the JSON Schema spec team]
It's not generally possible to expand all $ref pointers and produce valid JSON, as you may end up with cycles in your dereferenced data structure.  The meta-schemas are an example of this, as they use {"$ref": "#"} extensively to build a tree structure (many values within a JSON Schema are themselves JSON Schemas).

Hey @handrews, thanks for your response. I know there are certain cases where you can't perform the "dereferencing" but there are lots of cases where it's actually useful and possible. Usually, OpenAPI and AsyncAPI documents don't have circular references nor self-references. They are very simple JSON schema documents.
So from my perspective, this is something that's useful even with its limitations.
An example of a package doing it in Node.js: https://github.com/BigstickCarpet/json-schema-ref-parser/blob/master/docs/ref-parser.md#dereferenceschema-options-callback

Yes, it definitely has some uses (I'm familiar with that package, actually).  But I think it is important to advertise feature correctly including the limitations.  There are very simple structures that can't be implemented without circular references.
Personally, I find API description formats that don't allow structures like trees to be described to be non-starters, but I realize many APIs can get away without it.

But I think it is important to advertise feature correctly including the limitations.

Totally agree.


Prevent Submission of Blank Surveys

Changes made to prevent user form submitting blank surveys in cooking oils and surfer questioner.

Closing this PR since the changes are also in #226


Fix GitHub lib/pq link

Old link was relative and thus didn't work.

@samruddhikhandale requesting your approval for the workflow run (in case there's anything you'd like to check first before we merge).


[WIP] Working on adding bichain

Per the discussion here, adding in bichain

@evilsoft to have a bimap is to be a bifunctor is the a version of this for chain? Just want to ensure i'm using the correct words

or maybe, isBiSemigroup?

@dalefrancis88 yeah it is a hard one as a real operation in the ADT sense. So we may want to stay away from comparisons to bimap/Bifunctor. I would focus more on the "recovery" aspect of it.

cool, sounds good to me. This was when i was looking to make the identifying predicate and just wanted to double check that there was no special name it should have

Coverage remained the same at 100.0% when pulling 142ea301116351b67e76cf921701ba094c4b98e4 on feature/bi-chain into aa0092cb90e2f9572f3dd122028f890981253546 on master.

@evilsoft This is not fully tested yet but it'd be great if you could take a first pass over this while i get the last testing work done

Sorry I missed this, throwing some :eyes: now!

Will do those right now

Looks to work great on my end. Thanks for doing this.


Remove DateUtil abstraction

When we initially introduced the DateUtil we only used moment for a couple of minor tasks (looping over all days in the week for example). At that point I decided that the abstraction would help us get rid of moment as a dependency in the future.
Looking at the codebase now it is save to say that we have grown more dependent on moment than was initially expected, and therefor it is also time to remove the DateUtil abstraction.
Ref #282 (sparked the initial discussion).

(@rafeememon I'm assigning you since you mentioned you had a branch ready for this. Let me know if you can't work on this and I will happily take over)

@RSO, please take a look when you get a chance, thanks!


Atomic ER tooltip

as previous discussion new elements are added to the atomic ERs tooltip to give more info to the user:
Atomic ERs contained in iER:

Atomic ERs contained in aER:

Atomic ERs contained in rER:

Great, we'll discuss today. Two typos: Avaiable and Rubic.


External links shouldn't open in the service tab.

(Is this the official repository for the Franz 5 github integration? This new structure is somewhat tricky to understand.)
If it is, then there seems to be a bug in the plugin that causes any external link to open in the client rather than an external browser window. It is then hard to navigate back without either disabling the service or restarting the client.
Edit: If I understand the architecture right, the solution could be adding some code to webview.js that intercepts any link and tells it to open in the browser.

Issue in the Franz repo for more information: https://github.com/meetfranz/franz/issues/185


Unix socket?

Its possible to connect via UNIX socket?
I've tried via /tmp/mysql.sock like in the readme but is not working :thinking:
I'm missing something?
Thanks

You can use --socket option.
mysql --socket=${{ steps.setup-mysql.outputs.base-dir }}/tmp/mysql.sock


STORM-1919 Introduce FilterBolt on storm-redis

introduce RedisFilterBolt, and relevant class (RedisFilterMapper)
add example topology: WhitelistWordCount
update how to use to README.md
also correct some javadocs

It should be easy to backport to 1.x-branch as well so I didn't create another pull request against 1.x-branch.

@darionyaphet Could you check if this bolt covers your origin intention? Thanks!

LGTM

@HeartSaVioR Thank you for you Great Work . I have a small question about Mapper extention structure .


Thermostat Support

It would be great to get https://developers.homebridge.io/#/service/Thermostat in the HomeKit.
thanks

I'll consider it.  What device do you have that works with Smartthings?

I have Heatit - Z-Wave - Z-TRM3 .
It works with the default Zwave thermostat driver.
Also I am looking into making my AC connected using ESP8266. It will be a custom driver

virtual thermostat can help with the dev https://community.smartthings.com/t/st-edge-virtual-things-edge-driver/232875

+1 As I migrate from tonesto7’s plugin to yours, I’d like to add my 2gig CT100 thermostat.

+1 XL824


Merge Rust and model updates.

let me known if there are any open issues with the change.

I'm in the middle of overhauling some things and adding additional models. let me know of any feature requests you have.


MONDO:0015985 bone dysplasia, Azouz type [Obsolete]

Mondo term (ID and Label)
MONDO:0015985 bone dysplasia, Azouz type
Reason for deprecation
The SNOMED CT entry in UMLS is now showing as obsolete; the GARD page shows as "under development" and the link from Gard to orphanet is on the retired record.
MedGen does not have an active use case for this concept for submissions in GTR or ClinVar; it does not appear that there is much/any demand for this specific disease.
Suggested term to consider
Per Orphanet's comment, they redirect to "Primary bone dysplasia with disorganized development of skeletal components" which is ORPHA:93450 (not in Mondo)
or skeletal dysplasia http://purl.obolibrary.org/obo/MONDO_0018230
Your nano-attribution (ORCID)
If you don't have an ORCID, you can sign up for one here

Dear @kanems,
Thank you for reaching out to the Mondo Disease Ontology, part of the Monarch Initiative!
We have received your ticket and will review it as soon as possible.
If you have any additional information or updates relevant to your inquiry, please add them in a comment on this ticket. Your input is valuable in helping us understand and resolve the issue effectively.
Thank you for your patience and for your contributions to Mondo!
Sincerely,
The Mondo Team

bone dysplasia, Azouz type is not used in any other reference, and not referred to in medical literature. The term has been obsoleted #8350


JSON-SCHEMA Vulnerability

Currently my "jsprism" is of version "4.17.1" and it requires a package - "json-schema" of its old version "0.2.3". This version of json-schema currently has a critical vulnerability (CVE-2021-3918).
Is there any version of "jsprism" which requires the a stable "json-schema" version which does not have a vulnerability. If so, could you please let us know?

Hi @joelrichardvitrana,
This repository is for the npm module "jsprim" which has no version "4.17.1", perhaps you've confused this repository with another?
The latest published version of this module uses an updated version of json-schema (see #33)