[RFC-0007] Enable Azure OIDC for Azure DevOps repositories

This PR includes changes to enable oidc for Azure for git repositories. Changes include

Addition of a new provider field to GitRepository API spec which defaults to generic and can be set to azure for enabling passwordless authentication for Azure.
API docs change for new provider.
If provider is set in GitRepository spec, set the providerOptions in git authOptions to use changes in pkg PR #789 to get credential using azidentity APIs and fetch the access token for git repository.

Closes: #1284

Implement new packages auth, azure and git for passwordless authentication scenarios fluxcd/pkg#789

from my side I see this error "repository not found" I've changed the provided to "azure" and have configured the needed stuff that mentioned in the document, also have removed the secretRef part, the URL looks as suggested, any idea why?

Implement new packages auth, azure and git for passwordless authentication scenarios fluxcd/pkg#789

from my side I see this error "repository not found" I've changed the provided to "azure" and have configured the needed stuff that mentioned in the document, also have removed the secretRef part, the URL looks as suggested, any idea why?

"repository not found" error occurs when the permissions are not configured correctly. Could you check that the managed identity has access to the project that the Azure DevOps Repository is in ?

Implement new packages auth, azure and git for passwordless authentication scenarios fluxcd/pkg#789

from my side I see this error "repository not found" I've changed the provided to "azure" and have configured the needed stuff that mentioned in the document, also have removed the secretRef part, the URL looks as suggested, any idea why?

"repository not found" error occurs when the permissions are not configured correctly. Could you check that the managed identity has access to the project that the Azure DevOps Repository is in ?
I've tried to give the managed identity only contributor and then I tried to give it almost everything, I actually assigning these permissions to the managed identity of the AKS cluster (node agent), and I do this through azure devops project settings --> repo --> security


test alternative plans in WindowFuzzer

Summary:
Allow window fuzzer to test the following alternative plans and ensure their results are the same with the basic plan values(input).window(...).

values(input).orderBy(allKeys, false).streamingWindow(...)
tableScan(inputRowType).localPartition(partitionKeys).window(...)
tableScan(inputRowType).orderBy(allKeys, false).streamingWindow(...)

Also, this diff allows fuzzer to specify IGNORE NULLS in window function calls with 50% chance.
This is part of https://github.com/facebookincubator/velox/issues/7754.
Differential Revision: D52720371

@kagamiori : We should add plans with spilling as well. Though it can be done in a subsequent PR.
LGTM otherwise.


Subcommand to add a new dependency to Cargo.toml

I've grown to appreciate
npm install --save packagename

which automatically finds the package and adds it to package.json. composer require works in a similar way.
Cargo isn't as convenient for adding new dependencies to a project. I need to:

Visit the crates.io website find the package I want
Copy its latest version
Paste it to Cargo.toml myself

That's a bit tedious, especially that I have to switch from terminal to a web browser.
I'd be much nicer if Cargo had a command for adding dependencies, e.g.
cargo add packagename

that would find the package on crates.io and add it with an appropriate version to [dependencies] in Cargo.toml.

edit: for now, the fix is to run cargo install cargo-edit that adds cargo add command

https://github.com/killercup/cargo-edit provides this

Good to see others think it's useful to have too. Judging by the long list of dependencies of cargo-edit it looks like it reimplements cargo's code for communicating with the registry, so the implementation would be much smaller if it were built into cargo.

This is a dupe of the https://github.com/rust-lang/cargo/issues/4, which was in fact closed pointing to cargo edit, since cargo install now makes it super easy to install it.

Knowing about existence of cargo-edit is a barrier.
For me it went like this:
$ cargo install package
…
specified package has no binaries

…grumble, grumble, advised to use cargo-edit…
$ cargo install cargo-edit
…
# long list of compiled deps here
…
$ cargo add package
No such subcommand

	Did you mean `doc`?
$ export PATH=$PATH:~/.cargo/bin
$ cargo add package

That's not a great experience. Having it listed in cargo -h and working out of the box would be much better.

Yeah as @huonw mentioned this is basically a dupe of #4 so I'm going to close this, but I think it's a good point that discovering subcommands may not be the easiest thing to do today. I've opened https://github.com/rust-lang/cargo/issues/2187 on this topic and we can perhaps have discussion over there!

You are kidding me. An official package manager bug about not being able to add a dependency via its cli is closed because some other tool out there can do this. Sic.

This issue was compounded for me by openssl-sys failing to build (w/o sudo apt install libssl-dev)
While this may not belong in cargo (although it may) it should probably at least be adopted in the default rustup bundle?

For anyone else confused about the actual answer, first:
cargo install cargo-edit

after that, you can:
cargo add rand

etc.

@tom-james-watson thanks for the awesome explanation but I still don't see why cargo-edit is not install by default.

There's an intent to.  It's now being tracked in #5586 and there's a WIP PR against that too.

https://github.com/rust-lang/cargo/issues/1917
https://github.com/rust-lang/cargo/issues/2179
https://github.com/rust-lang/cargo/issues/4
https://github.com/rust-lang/cargo/issues/5586
https://github.com/rust-lang/cargo/issues/6457
https://github.com/rust-lang/cargo/issues/6488
https://github.com/rust-lang/cargo/issues/651
https://github.com/rust-lang/cargo/pull/5611

just hit my head against this, while trying to make my first step in rust. SUPER frustrating

Also, installing cargo-edit was a whopping 239 crates for me, that takes quite a while to download and install. Definitely not a great user experience.

@lavoiesl Jesus Christ, that sounds worse than even JavaScript with NPM. What happened to Rust?

Moderator note: Please don't post off topic and unconstructive rants about other software ecosystems in official Rust spaces.

But this is constructive. It's a good sample.

I believe @burntsushi refers to a comment that was deleted

Indeed.

Is there a specific reason for the add command, and maybe whole cargo-edit, to not be packed with the standard cargo?
Different hands working on each or some other more specific reason?
I got really curious for this second possibility... :)

I suspect there's a good reason. Perhaps someone could link a blog or something explaining this design decision?

I was surprised by this too. Coming from node having a command that does "add this package and save it in the list of dependencies" should be available out of the gate. I mean, 90% of the time I install something I'm going to be using it as part of my project, so why not save it and save me the trouble of editing the file?

It's being worked on: https://github.com/rust-lang/cargo/issues/5586

"just hit my head against this, while trying to make my first step in rust. SUPER frustrating"++;

Until #5586, getting cargo add, cargo rm and cargo upgrade is as simple as doing:
cargo install cargo-edit

One more great thing about it is you don't have to reinstall it for every toolchain update.
It's just there, and works.
You can do it after installing rustup, or you can do it once you encounter the error: no such subcommand: add. It's really not a big deal.
Finding out it exists is the bigger deal. I understand the unwillingness to add it to documentation (eg to the error text when the subcommand is exactly add) because the api of the builtin might be different than this third party utility, but not giving usage instructions and saying it will change and so to use cargo add help would go a long way. Basically it would prevent the cli -> google cargo add -> github/cargo-add -> see it's deprecated -> click deprecation link -> cli journey.

@qm3ster on top of that, cargo install cargo-edit somehow pulled around 200 packages:

It really matters whether it's built-in or something that needs to be installed. For years now, I've pushed for use of cargo-edit on https://lib.rs, but users still ask me to provide copy'n'paste alternative that works without it.

@kornelski I'm curious is it possible to install cargo-edit package with the toolchain automatically. Also, it would be helpful for an unfamiliar user to see cargo-edit commands in cargo --help.

This is now tracked in #5586

I can't believe I had to find this github issue in order to learn how to add dependencies from the terminal. :P

For anyone on this thread that didn't switch over to the issue posted above (#5586), cargo-add has been merged.  It will take several months for it to go from the nightly to beta and then stable release channels.


Remove version: Tencent.QQMusic version 18.91

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://dldir1.qq.com/music/clntupate/QQMusic_Setup_1891.exe
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 911)


build: Combine Taskfiles

For simplicity, at the cost of some build caching (almost always we should aim for simplicity...)

Merging b/c I want to make another change, but feedback still welcome


Add NiftyIODispatcher

Adds a NiftyIODispatcher which serializes downstream
messages that come from worker threads to be back
on the IO threads.
This has some benefits for some classes like SSL which
otherwise have to take locks on the IO thread to deal
with being called from various threads.

This pull request is put up for discussion purposes for now

like
We did something similar for SASL: https://github.com/facebook/nifty-header-protocol/blob/master/src/main/java/com/facebook/nifty/header/security/NiftySaslSecurityFactory.java#L862

@alandau I'm wonder at which stage it's appropriate to serialize on io thread. for instance should we do thrift encoding on workers or io threads.

Thrift serializatoin should be done on worker threads since it keeps the to-be-serialized objects cache hot. That's the same logic we have in c++

cool i believe in this diff it is done in worker threads because the niftyiodispatcher is placed before thrift decoder

LGTM


Client Definitions

Related to #9

Clients should be generated outside of the protocol and server definitions module and based on the .protofiles generated by the Protocol definition in #9
A client has a direct correlation to a @service definition and its sole concern is communicating with the remote @service. A client may be generated as shown below:

@client[Greeter] trait GreeterClient

Combinators instrospected from the protocol definitions and made synthetic in the client trait via macro should expose operation as @free algebras with default implementations provided as implicit instances in the client's companion. These handlers as everything in Freestyle should be overridable and able to target any M[_] : AsyncContext capable monads. (Streaming capabilities TBD).
3. Clients should remain scala.js compatible (it'll be addressed in https://github.com/frees-io/freestyle-rpc/issues/21)
4. Clients synthetic handlers should impose implicit evidence of the remote endpoint configuration for the service.

[X] Client Derivation based on protocol definitions (it'll be addressed in #28 )
[X] Clients correlated with Service definitions for unary Services (fixed in https://github.com/frees-io/freestyle-rpc/pull/16)
[ ] Clients correlated with Service definitions for client streaming services
[ ] Clients correlated with Service definitions for server streaming services
[ ] Clients correlated with Service definitions for bidirectional streaming services

The three remain items will be tackled as a part of https://github.com/frees-io/freestyle-rpc/issues/30


Symmetry definition

Check the symmetry information in CPACS. Probably the documentation needs to be
updated.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 15 Sep 2014 at 9:03

Three references are possible for a symmetric component:

compete component (e.g. whole wing)
defined component (e.g. right wing)
symmetric component (e.g. left wing)

The current definition in CPACS is not sufficient to reference all three elements. Hence, the following naming conventions is proposed:
Definition Component

References to component

Whole wing uID = „mainWing“
Defined wing uID = „mainWing_symm“
Symmetric wing uID = „mainWing_mirror“

Please note, this is not downward compatible...

Carsten added some valuable comments to the discussion. Will shortly include them here:

No clear definition is available on whether parts will be duplicated via symmetry, e.g. VTP on the BWB. Carsten proposes to exclude this option
_def and _sym instead of the options proposed above
Symmetric component shall be defined up to the symmetry plane
Linked components, e.g. engines on a wing, shall not be copied as a result of the symmetry.
Need to take into account symmetry and guidecurves

We discussed the issue at the FrEACs Meeting in Hamburg 2015. The proposed solution is to add an symmetry attribute to the stringUIDBaseType. The optional argument may have the values: full, symm or def. Hence if one references to a part he may specify whether the whole part is meant or only one half.
wingUID


Major overhaul of internals

This PR overhauls the ST2 code to do several important things:

Adds full table output - the actual contingency table that each draw from the Gibb's sampler generates is now returned by the (API function) _gibbs and _gibbs_loo.
Adds _gibbs_loo method - this is the API for leave-one-out calls and can now be run in parallel in the same manner that _gibbs can.
Update internals to use pandas - much of the code dealing with e.g. nonoverlapping metadata and feature sample sets has been moved to simple pandas operations.

There are a variety of bug fixes as well (no more nans, checks for fractional count tables, etc.)
The test examples work and the test code passes, but this is a significant update so if ya'll could give a thorough review that would be much appreciated. @lkursell @johnchase @gregcaporaso

@wdwvt1, ok if I get to this next week? I won't have time tomorrow.

@gregcaporaso - yeah, absolutely.

@wdwvt1 I took a pass, but we need @gregcaporaso for the main review

Sorry guys, I'll review on Monday at the latest.

@wdwvt1, done with my review. Can you confirm that all new functions that you created have corresponding tests? For example, I don't see tests for get_samples? It's probably worth running coveralls on the code base too to get an idea of what is/isn't being tested.

@gregcaporaso - thanks for the review!
Two high level thoughts:

I don't want to depend on QIIME2.  I don't think there will be a gain in functionality, and the code maintenance burden (so far less than 15 lines of code) is not high. The support burden of QIIME2 will be higher I think -- QIIME2 will change rapidly as it gets fleshed out if scikit bio, biom format, and QIIME 1 are any guide. I won't have much of a say in those decisions so I'll have to accommodate the decisions downstream. I can just avoid that all together by dealing with these things here.
The documentation for the API vs the CLI is starting to diverge significantly I think. Should I make two sections in the README.md for these?

Minor thoughts:

I use underscores in particular functions to indicate things I am going to operate on/do more work on before returning something out of the function. Most of these underscores seem intuitive to me (feature_table -> _ft).  I think I prefer short names just because I am used to one-character variables. I'll change these to improve the readability.
I will add a description of what is required for the mapping file if using the CLI.

I don't want to depend on QIIME2.

Makes sense, no problem. It is all minor stuff.

The documentation for the API vs the CLI

We don't really have a public API for this yet (just a candidate) so I think that's premature, but if you want to, go for it.

I use underscores in particular functions to indicate things

I think it'd be better to not create this convention here - the leading underscore usually indicates private functionality, so it's going to be confusing to other developers who want to contribute to this. This is getting into style though, so take this as my opinion (i.e., not required for merge, just a strong suggestion).

I will add a description of what is required for the mapping file

Sounds good.
Let me know when you're ready for a re-review.

Thanks @gregcaporaso - I will work on these over the next two days and then ping you for re-review.

Simulations with a large data set revealed a heinous memory leak: 5 minutes of run time with a large enough table would end up requesting 80gb of memory. The source of the memory leak appeared to be a cyclic reference in the Sampler class. In addition, storing the full table as output during the gibbs_sampler runs was causing significant memory allocation problems.
To resolve these problems I eliminated the Sampler class, and rewrote gibbs_sampler so that it produces only the vectors needed for calculating the proportions and the full output (but does not do it itself).
Benchmarks with this PR show that you can now do a ST2 run of 100 sinks, 350 sources, 8000 features, 10 restarts, 10 draws/restart, 100 burnins, in 30 minutes when using 6 cores, without exceeding 1gb of total memory use.
@gregcaporaso can you please review? @johnchase and @lkursell - your review would also be appreciated if you have time.
@nscott1 - this PR will resolve the unreasonable runtime problems you were seeing.
This PR now solves issues #55 #58 #13 #21 #52 #41

@wasade - thanks for taking a look! The np.int32 calls were because I was worried about memory usage. The memory usage was was not related to them at all, but I ended up leaving those in there. I am happy to remove them if you think that its poor practice/unnecessary. The only failure case I could see is if someone had counts that were greater than a np.int32 could handle. In that case, ST2 is just not an appropriate tool - there would never be enough burnins for that to be reasonably well assigned. Perhaps that bears mentioning in the documentation/paper as we write it.
You are absolutely write about the cythonization. The vast majority of code runtime is consumed in the inner loop (primarily in the updating the p_tv * p_v and in drawing a value from that with np.choice. Your email about sampling from a discrete distribution might lead to an improvement here as well.

Ah, makes sense with int32. It shouldn't be a problem to keep.
Do you have a profile to share? I'd be happy to help with some cythonizing
if you want to go that route.
On Aug 20, 2016 17:42, "Will Van Treuren"<EMAIL_ADDRESS>wrote:

@wasade https://github.com/wasade - thanks for taking a look! The
np.int32 calls were because I was worried about memory usage. The memory
usage was was not related to them at all, but I ended up leaving those in
there. I am happy to remove them if you think that its poor
practice/unnecessary. The only failure case I could see is if someone had
counts that were greater than a np.int32 could handle. In that case, ST2
is just not an appropriate tool - there would never be enough burnins for
that to be reasonably well assigned. Perhaps that bears mentioning in the
documentation/paper as we write it.
You are absolutely write about the cythonization. The vast majority of
code runtime is consumed in the inner loop (primarily in the updating the p_tv

p_v and in drawing a value from that with np.choice. Your email about
sampling from a discrete distribution might lead to an improvement here as
well.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/biota/sourcetracker2/pull/51#issuecomment-241232118,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAc8sn8U_up3-yYH-EJKUPg_iowiugY_ks5qh58BgaJpZM4JNBOB
.

@wdwvt1 I spent some time on this today and it's looking reasonable. I didn't spend as much time as I did on my first pass, but if there are specific areas that you want me to look at in more detail I can do that. Just let me know what those are. I'd like to look through this a little more tomorrow - in particular I want to spend more time reviewing the test code.
Have you gone through the previous comments to make sure that you've addressed everything? It's hard to tell since so much changed since my last review.
Also, have you confirmed that all new methods and new functionality now have tests? I think it might be worth starting to compute test coverage on this repo. I started experimenting with this in another pull request.

Thanks - I'll fix the documentation, typos, and camel case.
Have fixed previous comments except for the mapping file loading
thing/issue you opened. Haven't seen loading a mapping file give an error
and the test code in skbio doesn't have an example of a mapping file that
triggers the errors the function is supposed to catch (that I saw). Is
there an example of a mapping file that fails?
The linked code also doesn't make sense to me, is it catching a case with
leading comments?
I'm mainly interested in a review of the changes to the internal code,
specifically the elimination of the 'Sampler' class and the removal of the
proportion calculation from 'gibbs_sampler'.
On Aug 22, 2016 5:22 PM, "Greg Caporaso"<EMAIL_ADDRESS>wrote:

@wdwvt1 https://github.com/wdwvt1 I spent some time on this today and
it's looking reasonable. I didn't spend as much time as I did on my first
pass, but if there are specific areas that you want me to look at in more
detail I can do that. Just let me know what those are. I'd like to look
through this a little more tomorrow - in particular I want to spend more
time reviewing the test code.
Have you gone through the previous comments to make sure that you've
addressed everything? It's hard to tell since so much changed since my last
review.
Also, have you confirmed that all new methods and new functionality now
have tests? I think it might be worth starting to compute test coverage on
this repo. I started experimenting with this in another pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/biota/sourcetracker2/pull/51#issuecomment-241591129,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA__-Uu61QkUEfIawaD_SFI9tC-LDD5Bks5qij04gaJpZM4JNBOB
.

Also yes to addition of tests.
Coverage testing sounds good, though I think if I had to choose between
that and more eyes on the internals of the algorithm (comparison of Dan's
sourcetracker internals to our 'gibbs_sampler') I'd choose the latter.
On Aug 22, 2016 5:55 PM, "Will Van Treuren"<EMAIL_ADDRESS>wrote:

Thanks - I'll fix the documentation, typos, and camel case.
Have fixed previous comments except for the mapping file loading
thing/issue you opened. Haven't seen loading a mapping file give an error
and the test code in skbio doesn't have an example of a mapping file that
triggers the errors the function is supposed to catch (that I saw). Is
there an example of a mapping file that fails?
The linked code also doesn't make sense to me, is it catching a case with
leading comments?
I'm mainly interested in a review of the changes to the internal code,
specifically the elimination of the 'Sampler' class and the removal of the
proportion calculation from 'gibbs_sampler'.
On Aug 22, 2016 5:22 PM, "Greg Caporaso"<EMAIL_ADDRESS>wrote:

@wdwvt1 https://github.com/wdwvt1 I spent some time on this today and
it's looking reasonable. I didn't spend as much time as I did on my first
pass, but if there are specific areas that you want me to look at in more
detail I can do that. Just let me know what those are. I'd like to look
through this a little more tomorrow - in particular I want to spend more
time reviewing the test code.
Have you gone through the previous comments to make sure that you've
addressed everything? It's hard to tell since so much changed since my last
review.
Also, have you confirmed that all new methods and new functionality now
have tests? I think it might be worth starting to compute test coverage on
this repo. I started experimenting with this in another pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/biota/sourcetracker2/pull/51#issuecomment-241591129,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA__-Uu61QkUEfIawaD_SFI9tC-LDD5Bks5qij04gaJpZM4JNBOB
.

more eyes on the internals of the algorithm

Can you link me to the implementation that you'd like me to compare against? I'm not very familiar with that code.

Coverage increased (+6.09%) to 87.912% when pulling e551825e09f3aa4c8e691de430e867e181da3a28 on wdwvt1:pd_internals into 3927d148aa27756b1ed1bdeb01a06428f8949940 on biota:master.

Coverage increased (+6.09%) to 87.912% when pulling 07f67e404b39ab8bf0880ce8cea635fc44442f52 on wdwvt1:pd_internals into 3927d148aa27756b1ed1bdeb01a06428f8949940 on biota:master.

Thanks @wdwvt1! As discussed on our call today, we can deal with the remaining items that were brought up here through the new issues that we created.


Terraform validation error on new update_bridgecrew trigger

Error: Missing resource instance key

  on .terraform/modules/bridgecrew-cloudtrail-connection/bridgecrewio-terraform-aws-bridgecrew-cloudtrail-4d236e4/bridgecrew_sns_resource.tf line 31, in resource "null_resource" "update_bridgecrew":

  31:     build = md5(data.template_file.message.rendered)

Because data.template_file.message has "count" set, its attributes must be
accessed on specific instances.

Hey @m-wynn ! Please check out v1.1.2


Use storageClassName for pvc

Context
In this pull request, I aim to address an issue related to the storageClassName in the resources section.
Test instructions

Verify that the storageClassName is correctly set based on the provided size.
Ensure that when storageClassName is "-", it is properly handled and results in an empty storageClassName.

Checklist before requesting a review

[ ] I have performed a self-review of my code
[ ] I've added documentation about this change to the README.
[X] I've not introduced breaking changes.

I've revoked my change requests.
I don't understand what you wanna achieve with this PR. IMO, you just made it more complicated to set an empty storage class name.

I've revoked my change requests.
I don't understand what you want to achieve with this PR. IMO, you just made it more complicated to set an empty storage class name.

I see. Most Helm charts are written this way. If it's unnecessary, then it can be omitted. Thank you.


Issues with single player joining multiplayer

https://www.notion.so/webaverse-app-4b1f76bd97c44295b2361f4eac447066

@anu-nexus needs to setup the project in her local machine and replicate this issue. She is welcomed to add more details in form of images and video so that Kinjal should understand it in more detail

-So right now, Once we equip items in single player and shift to multiplayer room. The items do get replicated but not attached to the avatar.
-As it can be seen in the video below, When we shift from single player to multiplayer room along with items such as sword, helmet.. These items do appear in remote instance of multiplayer room, but not attached to the avatar.
-I wasn't able to reproduce other issues stated above such as avatar disappearing right now. Maybe the dev can add more details on how to reproduce these.
https://user-images.githubusercontent.com/35926530/163600113-5a6d00f3-7ab5-479e-82f2-a1dc0ef7b4b1.mp4
Meanwhile, You may also check these issues pointed out by me here:
https://github.com/webaverse/app/pull/2807#issuecomment-1095384244

This is still happening

https://user-images.githubusercontent.com/18633264/164958686-5f2cd0a3-7377-4f6f-ac0d-99eb861c14b7.png

When single player joins multiplayer, grabble item is worn by player but its not working.
Kindly watch the video.
https://www.awesomescreenshot.com/video/8697925?key=f7240e8710894cd41407e6af2610f219

@anu-nexus have you taken latest pull from master?

When a player joins multiplayer, grabbed sword is showing but animation is not working.
If player wear helmet  and joins multiplayer then it is showing bug.
https://www.awesomescreenshot.com/video/8697925?key=f7240e8710894cd41407e6af2610f219

When single player joins multiplayer, player is joining multiplayer with sword and animation is also available but after releasing sword that local player is not able to wear that sword again.
https://www.awesomescreenshot.com/video/8844469?key=0f2e5eaacb8977bc695f9afc408a4f67

Once we equip items in single player and shift to multiplayer room. The items do get replicated but not attached to the avatar.
-As it can be seen in the video below, When we shift from single player to multiplayer room along with items such as sword, helmet.. These items do appear in remote instance of multiplayer room, but not attached to the avatar.
https://www.awesomescreenshot.com/video/9042974?key=9d043d6a10d7bdac3f778df7a891da7a

This issue has been resolved.
https://user-images.githubusercontent.com/101788714/170948098-9b22c04e-03c6-493b-83e6-82a212e30236.mp4


Adding ASP.NET Core + SQL Server Compose Tutorial

On branch master
Your branch is up-to-date with 'origin/master'.
Changes to be committed:
new file:   compose/aspnet-mssql-compose.md
Proposed changes
Adding Docker Compose sample for getting started with an ASP.NET Core
web application running SQL Server on Linux in the back-end. This sample
can be used in Docker for Linux, Windows and Mac using Docker-Engine.
Note: This sample doesn't use Windows Containers.

@carlfischer1 Should the link to Docker for Windows use one of your intall_site tracking ids?
Such as: https://docs.docker.com/docker-for-windows/?install_site=vs_docs
It's a doc written by Microsoft, but hosted by Docker. What do you think?
@SteveLasker FYI.

How about:
keywords: dotnet, .NET, Core, example, installation, ASP.NET Core, SQL Server, mssql

Re @kendrahavens question ^, we spoke in mail. No need to decorate these URLs.

CC @ManoMarks -- How does this look to you?

CC @sixeyed

Updated the keywords as per suggestion by @johndmulhausen

@sixeyed let me know if there's any more feedback.
Thanks!

Thoughts? Is there any more feedback you'd like me to take a look at?
@ManoMarks @johndmulhausen @carlfischer1 @sixeyed

After looking at the netlify preview, I found that the indentation of the codeblocks wasn't looking as intended, so I added a few more changes to fix that. It now looks good on netlify :)

I used the netlify preview and it seems like there's some weird behavior where the content gets rendered on the side bar as well. Is this an error with the preview or would this show up in production? @friism @johndmulhausen @mstanleyjones

This looks great! I did some reformatting and fixed one mistake (you said that you mapped the port to 8080 in the Dockerfile but it should have said the docker-compose.yml.
I don't really love the repeated use of "Ready!", but I'm prepared to love with it, in the face of such great content.
I rewrapped the file at or around 80 characters for ease of diffing later on. Sorry to say it will make reviewing MY changes this time more difficult. I also changed the code examples to use explicit fencing, and I fixed the indentation of the numbered list items to make for fewer surprises later on. The extra space after the number really helps with alignment of sub-elements of the list item.

Looks like we are so close to the finish line on this!

Awesome, thank you so much for this. Merging! See you at Dockercon!

Thanks @mstanleyjones @friism @johndmulhausen!


Proposal - Description of the data

The proposal should be written as a markdown document in your repo (reports/m1_proposal.md), be max 1,000 words in length, and include the following sections:
Motivation and purpose
Description of the data
Research questions
App sketch and description
Section 2: Description of the data
In your proposal, briefly describe the dataset and the variables that you will visualize:

Include how many rows and columns there are in the dataset (that you plan to use).
There should be a clear link to how the dataset and the variables you describe will help you solve your target audience's problem.
Indicate at least one new variable that you are planning to derive/engineer for your visualizations.
-- If there are no new variables to derive, indicate what additional information you would have liked to have in the dataset to better be able to answer your research questions (even if it is impossible for you to engineer it).
If you are planning to visualize a lot of columns, provide a high level description of the variable types rather than listing every single column.
-- For example, indicate that the dataset contains a variety of categorical variables for demographics and provide a brief list rather than describing every single variable.
-- You may also want to consider visualizing a smaller set of variables given the short duration of this project.
To be able to include this information you might wish to perform a brief exploratory data analysis for you to grasp what could be interesting variables to look at in your data. We will not be grading the EDA aspect, but include your EDA notebooks in the public GitHub repo, so that you have everything in one place.

Example writeup:
We will be visualizing a dataset of approximately 300,000 missed patient appointments. Each appointment has 15 associated variables that describe the following characteristics, which we hypothesize could be helpful in determining why patient's miss their appointments:

Patient demographics (patient_id, gender, age, etc)
The health status of the patient (general_health_status, existing_conditions e.g. "Hypertension", "Physical disability")
Information about the appointment itself (appointment_id, appointment_date)
Whether the patient received a reminder about the appointment (reminder_sent)
Whether the patient showed up (status)

Using this data we will also derive new variables, such as the time since the patient's last appointment (days_since_last_appointment) and which weekday the appointment was on (appointment_weekday), as it would be interesting to explore if these could be linked to the patient missing their appointment.

Done #17


Initialise plans using sync.Once

Previously, plans were initialised through a racy assignment. Now they
are initialised through a sync.Once, which is more clearly race free and
also makes the intent clear (it is initialisation).
With this change it's also necessary to make the plan more pointer-like,
since if you pass a struct around by value with a lock in it, you are
going to have a bad time. This was pointed out to me by the
gometalinter.
Fixes go-gorp/gorp#296.
Supercedes go-gorp/gorp#153.

I've tested this in my own codebase and it seems to do the trick.

Tests failed due to #302. Coverage went down!? Not sure I grok/believe that one.

Looks good, thanks!

Can this be backported to v1? We're currently running into this race condition, but updating to master is not recommended right now.


Support UnityModManager

Can u guys supports UnityModManager plssssss

You can make a PR to add the support.

Well then i have to wait someone to do that cause i'm bad at C programming


send an email to the creation of a user

Being able to send an email with a link or a personalized message would be really practical. Or an alternative idea ?

I am not sure. What use case do you have in mind?

I think that login already provides this function?
Or do you have something else in mind?

What I am looking for and the creation of a user we enter his email and I would like the plugin to send him an email directly.

You can do it by using the "Send welcome email" option as @MakaryGo mentioned.

You can do it by using the "Send welcome email" option as @MakaryGo mentioned.


Fix SystemBar content color before IOS 17

fix #18
Result (1-2 sim, 3-4 real):

Will it work like before on iOS 17 if you set light theme and full black screen?

And could you also please check if it will work if you use this insted:
viewController.overrideUserInterfaceStyle = if (dark)
    UIUserInterfaceStyle.UIUserInterfaceStyleDark
else UIUserInterfaceStyle.UIUserInterfaceStyleLight

It should work without plist property and set correct keyboard and nav strip appearance

i tried overrideUserInterfaceStyle but it doesn't work.
LaunchedEffect(dark) {
        viewController.overrideUserInterfaceStyle = if (dark)
            UIUserInterfaceStyle.UIUserInterfaceStyleDark
        else UIUserInterfaceStyle.UIUserInterfaceStyleLight
        viewController.setNeedsStatusBarAppearanceUpdate()
    }

Will it work like before on iOS 17 if you set light theme and full black screen?

Yes, it works, the only problem I noticed is when opening bottomsheet with a light theme.

Thanks! Status bar style for bottom sheet is complex because of different presentation styles and detents. I'll probably do it later


Support other providers

Hello 👋🏼
I do really like the project, Although it's locked with OpenAI
I would like to know if it's possible to support other providers (Mistral/Claude) or simply Ollama
Is something like this planned ?
Thanks

How would that even work? The Assistants API is all based on cloud resources. It is not like the completions API.


Add data quality check for  large dataset

When importing data into your data warehouse, you will almost certainly encounter data quality errors at many steps of the ETL pipeline.
An extraction step may fail due to a connection error to your source system. The transform step can fail due to conflicting record types. And even if your ETL succeeds, anomalies can emerge in your extracted records – null values throwing off stored procedures, or unconverted currencies inflating revenue.
How do you catch these errors proactively, and ensure data quality in your data warehouse?
This feature is aiming to enhance QStreaming to support the data quality check for a large dataset by introducing amazon deequ library.
The idea is to invent some grammar in sql.g4 at design time, and then compile to deequ check  at runtime.

This has been implementing in https://github.com/qiniu/QStreaming/pull/32


fix the version and weid-contract-java

适配weid-contract-java1.2.29
优化getWeIDListByPublicKey接口逻辑

Codecov Report

Merging #290 (25b4abd) into release/1.8.0 (6f3f94a) will increase coverage by 0.03%.
The diff coverage is 60.86%.

@@                 Coverage Diff                 @@
##             release/1.8.0     #290      +/-   ##
===================================================
+ Coverage            42.75%   42.78%   +0.03%
- Complexity            1588     1592       +4
===================================================
  Files                  236      237       +1
  Lines                12826    12849      +23
  Branches              1668     1670       +2
===================================================
+ Hits                  5484     5498      +14
- Misses                6649     6655       +6
- Partials               693      696       +3

Impacted Files
Coverage Δ
Complexity Δ

.../com/webank/weid/service/impl/WeIdServiceImpl.java
59.86% <60.00%> (+<0.01%)
70.00 <2.00> (+2.00)

.../webank/weid/protocol/response/WeIdListResult.java
66.66% <66.66%> (ø)
2.00 <2.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8e6ae6...25b4abd. Read the comment docs.

Codecov Report

Merging #290 (25b4abd) into release/1.8.0 (6f3f94a) will increase coverage by 0.03%.
The diff coverage is 60.86%.

@@                 Coverage Diff                 @@
##             release/1.8.0     #290      +/-   ##
===================================================
+ Coverage            42.75%   42.78%   +0.03%
- Complexity            1588     1592       +4
===================================================
  Files                  236      237       +1
  Lines                12826    12849      +23
  Branches              1668     1670       +2
===================================================
+ Hits                  5484     5498      +14
- Misses                6649     6655       +6
- Partials               693      696       +3

Impacted Files
Coverage Δ
Complexity Δ

.../com/webank/weid/service/impl/WeIdServiceImpl.java
59.86% <60.00%> (+<0.01%)
70.00 <2.00> (+2.00)

.../webank/weid/protocol/response/WeIdListResult.java
66.66% <66.66%> (ø)
2.00 <2.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8e6ae6...25b4abd. Read the comment docs.


Close and reopen memfile dataset before WarpedVRT

Depending on format, datasets that have been written need to be closed before they are complete, so this is safer. A future version of rasterio will require that datasets passed to WarpedVRT be opened in read-only mode. Also, using numpy.moveaxis so that we only call mraster.write once.

The build errors look unrelated :shrug:

Thanks a lot!

The build errors look unrelated shrug

Indeed that is being fixed in https://github.com/geopandas/contextily/pull/164


port: add command/commandResult activity types

Fixes #3429
Description

Added command/commandResult activity types and related triggers.
Specific Changes

Added command/commandResult activity types
Added trigger OnCommandActivity/OnCommandResultActivity
Implemented onCommand/onCommandResult in ActivityHandler

Testing

Added tests as well.

Pull Request Test Coverage Report for Build 711291815

0 of 0   changed or added relevant lines in 0 files are covered.
31 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.01%) to 84.942%

Files with Coverage Reduction
New Missed Lines
%

libraries/botbuilder-lg/src/templateExtensions.ts
1
84.48%

libraries/botbuilder-core/src/activityHandlerBase.ts
13
86.21%

libraries/botbuilder-core/src/activityHandler.ts
17
79.22%

Totals

Change from base Build 710131379:
0.01%

Covered Lines:
18963

Relevant Lines:
21264

💛  - Coveralls


TypeError: metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases

File "~/torchdrug/torchdrug/data/dataset.py", line 20, in
class MoleculeDataset(torch_data.Dataset, core.Configurable):
TypeError: metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases

After encountering this problem, I uninstall the torchdrug. And now I cannot install the torchdrug, the error is:
error: legacy-install-failure
× Encountered error while trying to install package.
╰─> torch-scatter
But I already install torch-scatter and my environment is :
windows
python=3.7
pytorch=1.7.1+cu110
torch_geometric = 2.0.4
torch_cluster = 1.5.9
torch_scatter = 2.0.6
torch_sparse = 0.6.9
torch_spline_conv = 1.2.1
deepchem = 2.6.1
rdkit


UX lift-up

I feel that there is a room for improvement with the current UI/UX.

The page header (eg. everything above the first search result) is large, taking up to a half of the height of smaller screens. Given that it consists mostly of empty space, compacting the layout a bit could leave more of the page for search results.

I'd consider removing the top pagination control altogether, putting the dropdown and the toggle on a single line right under the search field to make them feel more connected with the search field, and centering the "result count" line.

The result items are overcrowded with text.

Some text can be made into icons (homepage, manifest link etc.)
IMO some of the fields aren't strictly necessary, considering the use-case:

"commiter" carries very little meaning, as well as the link "commit" (feel free to explain the reasoning tho, maybe I just don't get it)
star count for official buckets -- the blue mark should be enough, I'd even consider dropping star count everywhere and creating a new "popular community bucket" mark that would show for buckets with >50 stars, so there's only one thing displayed next to a bucket name

I also had the idea that bucket could be moved to the header instead of version, like "firefox in extras ✅", eliminating the need to duplicate the checkmark to the header

"updated" could show just "x time ago" which is more readable than an absolute date

The layout feels misaligned -- most elements in the result item don't align with each other
One thing I think is missing is easily available scoop bucket add x, like shovel.sh has -- I know that there's a button for it on unofficial buckets, but even official buckets need adding the first time

To present a more clear "vision", a result item could look rougly like this.
Official bucket (short bucket name in title):

 🖼 firefox in extras ✅
 📜 MPL-2.0 | 🌍 mozilla.org/firefox

 Popular open source web browser.
	 > scoop bucket add extras 📋

 v96.0.3 (updated 6 days ago)
 > scoop install firefox 📋

Unofficial bucket (full bucket name, star count in tooltip, different icon if >50 stars):

 🖼 firefox in JanPokorny/SomeBucketIMadeUp❓
 📜 MPL-2.0 | 🌍 mozilla.org/firefox

 Popular open source web browser.
	 > scoop bucket add SomeBucketIMadeUp https://github.com/JanPokorny/SomeBucketIMadeUp 📋

 v96.0.3 (updated 6 days ago)
 > scoop install firefox 📋

Thanks a lot for this feedback.
There is definitely room for improvement and your points are quite interesting. We will try to improve the UX/UI according to your proposals 👍
Thanks

Hey @JanPokorny,
I started to apply some of your UI/UX proposals to the search results. Could you take a look on the video attached and give me your early feedback?

top pagination control removed
new search result layout according to your proposal
stars removed and replaced with popular community bucket icon

Remaining parts:

compacting layout
responsive
compacting search bar + search options

I think this new layout is much more appealing than the previous one. I' m just not convinced with the > scoop bucket add ... displayed everywhere (as it's an action you' re doing only once per bucket)
https://user-images.githubusercontent.com/3621529/152723282-b0cea2e6-4ac0-4858-b9a4-71a1304ab67b.mp4

@gpailler Great work! I am glad that you liked the proposal and implemented it!

When I look at it now, I think it might look slightly more logical if the licence+homepage and version+lastchanged were swapped, since the version ties to the app name and bucket, whereas the homepage ties more to the description. Like this (I also put homepage first since it seems more interesting of the two, and added a "package" icon before version since pretty much everything else has an icon):

 🖼 firefox in extras ✅
 📦 v96.0.3 (updated 6 days ago)

 Popular open source web browser.
	 > scoop bucket add extras 📋

 🌍 mozilla.org/firefox  📜 MPL-2.0
 > scoop install firefox 📋

With the bucket URL, I see what you mean. The current control for presenting the scoop commands is visually heavy, thus having two of them makes the layout feel unbalanced. Perhaps making it more subtle (remove borders, tone down background, instead differentiate by using a monospace font), and higlighting/bolding the more important one, could look better? Like this (yes I did just shamelessly copy shovel.sh):

Thanks for the feedback @JanPokorny.
I applied most of the changes, and you can test the dev version on https://scoopsearch.github.io/scoopsearch-dev.github.io/.

Icons are replaced with lighter versions
Margins are reduced and consistent between header and body
Last update/Version are swapped with Homepage/License

Having the Version in last position makes it more readable according to my tests

Overlays are available on the Verified icon, Last update and Homepage (if truncated) to display extra information (repo type, stars, full date, full url)
Organization part is removed from Official repositories
Scheme and trailing slash are stripped off from the Homepage url
License is clickable (if it's a known SPDX license)
Copy controls are lighter

I think we are moving to the right direction 👍

@gpailler Definitely moving in the right direction!

IMO it would look better if the bottoms of the two columns were aligned in the "usual" case, that is one-line description.

The command font size is smaller than the rest (most is 16px, command is 14px), which looks weird. What about 16px font and 1.7 line height?

Alternatively, this is a 14px monospace variant with 2.0 line height. I prefer light/bold to opacity, since the semi-transparent field gives off a "disabled form control" vibe.

I also think it would be nice if the commands would react to click -- either select the command on click for easier copying, or outright make the whole thing act as the copy button and copy it on click. (I don't really see a use case for selecting just a part of the command...)

According to your comments, I pushed some changes on https://scoopsearch.github.io/scoopsearch-dev.github.io/.
What are your thoughts?

It's great!
I noticed a little visual bug (probably browser specific) -- a vertical line after > caused by the elements overlapping their semi-transparent backgrounds:

Simply set the background to a static color (#f7f7f7) to stop this.
I'd also put user-select: none on both #user-command-prefix and #user-command-text, add a tooltip with "Click to copy" (and perhaps "Copied!" after clicking?), and changed the after-copy checkmark color to green to make it more apparent what's happening.

Thanks for the feedback. I'm really not that good with this kind of small CSS details...
I fixed all the small discrepancies with the copy commands. Looks good !

@gpailler You did great work! I think the new search result is pretty and functional. @rashil2000 any thoughts from you?

I found a tooltip bug when the star count is 0:
https://scoopsearch.github.io/scoopsearch-dev.github.io/#/apps?q=dolphin-nightly

Also I noticed that the wording on the toggle is "Search only known buckets", whereas the tooltips use "Official bucket". I know that Scoop uses "known", but I'd stick to "official" here since it better carries the meaning.

Regarding my original suggestions on the search bar controls, do you have any thoughts? My idea was moving them to the center like this, to make the controls more connected, but I suppose there might be better way. I also think that it's worth it to make the page a bit more welcoming if someone stumbles upon it by accident -- by placing one sentence describing what it is.

The words "apps" (forgot to link that one 😅) and "buckets" would replace the current buttons. (Also please excuse that this is super misaligned because it is composed mostly in MSPaint 😁)

Looks awesome to me. Just one minor comment: in the overhaul, I feel we lost one bit of information: latest commit link. It should be easy to turn the following text into a hyperlink pointing to the commit, no?

I also think that it's worth it to make the page a bit more welcoming if someone stumbles upon it by accident -- by placing one sentence describing what it is.

I think this might not be required once the website has a homepage?

One can still link to the search page directly

Hmm. But I'm not a fan of cluttering up the titlebar. Maybe we can put something directly above the search box?

@rashil2000 What about not showing results when nothing is typed in, and instead showing a short message? There could be a small link under it to browse all apps (hide the message and go back to old behavior) to not lose the functionality

Hmm, seems good to me

Hello guys

I found a tooltip bug when the star count is 0:

Thanks. Fixed

Also I noticed that the wording on the toggle is "Search only known buckets", whereas the tooltips use "Official bucket"

Correct, I changed Known to Official as it's the word we are using everywhere.

Regarding my original suggestions on the search bar controls, do you have any thoughts?

I'm not convinced by having the filtering/sorting controls centered below the search bar. I would rather go with a single "Options" dropdown next to the search bar containing all the sorting and filtering options. I will try to propose a mockup a bit later.

Looks awesome to me. Just one minor comment: in the overhaul, I feel we lost one bit of information: latest commit link. It should be easy to turn the following text into a hyperlink pointing to the commit, no?

The diff link was not really useful to me as you have the manifest link already but it's quite easy to re-add it. Something like that?

What about not showing results when nothing is typed in, and instead showing a short message?

Well, the only goal of showing results without any search was to showcase the results display so the user can see what he can expect. But yes, we can just display the number of manifests indexed and a small appealing message instead

The diff link was not really useful to me as you have the manifest link already but it's quite easy to re-add it. Something like that?

Yep, precisely!
I agree very less people will use it (which includes me 😅), but I have gotten similar requests in the past (see https://github.com/ScoopInstaller/Scoop/issues/4448) so I thought why not just use the information we already have in the JSON.

@rashil2000 Deal 🤝 ! You can take a look on https://scoopsearch.github.io/scoopsearch-dev.github.io for the result.

Regarding my original suggestions on the search bar controls, do you have any thoughts?

I'm not convinced by having the filtering/sorting controls centered below the search bar. I would rather go with a single "Options" dropdown next to the search bar containing all the sorting and filtering options. I will try to propose a mockup a bit later.

@JanPokorny What about an options menu like this one?

With a menu like this one, we can sort by ascending or descending order, and we can add other filters without overcrowding the UI. It makes the sorters/filters less discoverable though, but I think that in most cases, you don't need to change these options when you are looking for a specific app (the general use case)

@rashil2000 Deal 🤝 ! You can take a look on https://scoopsearch.github.io/scoopsearch-dev.github.io for the result.

Yep, awesome ♥

With a menu like this one, we can sort by ascending or descending order, and we can add other filters without overcrowding the UI. It makes the sorters/filters less discoverable though, but I think that in most cases, you don't need to change these options when you are looking for a specific app (the general use case)

How about we keep the official-bucket toggle outside but keep the filtering option inside the dropdown menu? This is to maintain symmetry with the Found 14 applications for 'fiefox'. text on the left.

@gpailler I love the drop-down menu! You're right that the options are now more hidden, but it elegantly solves the layout. I'd also consider having the drop-down button in the right top corner of the search results, with a longer title like "Sorting & Filtering" to make it more noticeable. This would maintain symmetry as @rashil2000 proposed (I don't really like the idea to separate the toggle)

@rashil2000 @JanPokorny New unified sorting/filtering dropdown is available on https://scoopsearch.github.io/scoopsearch-dev.github.io/
Any thoughts?

@gpailler The only little thing I noticed is that the cursor changes to pointer inconsistently when hovering the "official bucket" toggle (both text and the toggle itself)

@JanPokorny You were right, as usual ;-) The issue with the cursor is fixed

@JanPokorny should we merge the develop branch, if the changes are good to go?

I think that this first bunch of changes can be deployed. Then we can continue to work on other improvements

Okay, please go ahead :)

We're live! ;-)  https://scoopsearch.github.io/

Yay!
I'm closing this issue, as the original request is fulfilled.
More suggestions can come in newer issues.


No op named StringReverse in defined operations. (while importing the graph_def from .pb file)

I have generated the pb file from the model.ckpt. When i am going to load the pb file to predict, I encountered this problem:
Traceback (most recent call last):
File "pb_demo.py", line 18, in
tf.import_graph_def(graph_def, name='')
File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/importer.py", line 285, in import_graph_def
raise ValueError('No op named %s in defined operations.' % node.op)
ValueError: No op named StringReverse in defined operations.
I think the reason maybe the op StringReverse which seems written by the author in directory aster/c_op is not included in the tf1.4.
Does anyone know how to solve this problem? Thanks in advance.

You have to load the compiled custom operations found in /aster/c_ops/libaster.so. This can be done lazily by importing the following module into the module where you're using your .pb.
from aster.c_ops import ops
You don't need to actually use it, only import it.


Master branch dies

Also the Docker image https://hub.docker.com/r/openzim/phet/
Copying compressed images beginning with: ZW
Copying compressed images beginning with: ZX
Copying compressed images beginning with: ZY
Copying compressed images beginning with: ZZ
Copying compressed images beginning with: Zundefined
Copying compressed images beginning with: Zundefined
Copying compressed images beginning with: undefined0

><EMAIL_ADDRESS>export /phet
> node_modules/typescript/bin/tsc && node_modules/browserify/bin/cmd.js res/js/index.js  -t babelify --presets [es2015] -o res/js/dist.js && node_modules/ts-node/dist/bin.js steps/export.ts

Error: Cannot find module '../state/get/catalog.json'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.Module._load (module.js:417:25)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/phet/steps/export.ts:29:28)
    at Module._compile (module.js:570:32)
    at Module.m._compile (/phet/node_modules/ts-node/src/index.ts:395:23)
    at Module._extensions..js (module.js:579:10)
    at Object.require.extensions.(anonymous function) [as .ts] (/phet/node_modules/ts-node/src/index.ts:398:12)
    at Module.load (module.js:487:32)

npm ERR! Linux 4.4.0-22-generic
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "export"
npm ERR! node v6.10.1
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>export: `node_modules/typescript/bin/tsc && node_modules/browserify/bin/cmd.js res/js/index.js  -t babelify --presets [es2015] -o res/js/dist.js && node_modules/ts-node/dist/bin.js steps/export.ts`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>export script 'node_modules/typescript/bin/tsc && node_modules/browserify/bin/cmd.js res/js/index.js  -t babelify --presets [es2015] -o res/js/dist.js && node_modules/ts-node/dist/bin.js steps/export.ts'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the phetscraper package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node_modules/typescript/bin/tsc && node_modules/browserify/bin/cmd.js res/js/index.js  -t babelify --presets [es2015] -o res/js/dist.js && node_modules/ts-node/dist/bin.js steps/export.ts
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs phetscraper
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls phetscraper
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /phet/npm-debug.log

npm ERR!  Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'npm run setup && npm run get && npm run transform && npm run export'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the phetscraper package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run setup && npm run get && npm run transform && npm run export
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs phetscraper
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls phetscraper
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /phet/npm-debug.log
root@4c2d26b4d691:/phet#

This seems to have been fixed.


Logo doesn't disappears after start

Logo image prevails throughout the whole editing session :-1:

I've seen this happen once, but could never reproduce. Can you?
-- Zef
Sent from my iPhone

On 01 Jun 2015, at 06:18, Fernando Lucio Canizo<EMAIL_ADDRESS>wrote:
Logo image prevails throughout the whole editing session
—
Reply to this email directly or view it on GitHub.

Almost... I reproduced it once after reading your request, and when I tried again to confirm the steps and tell you here, I couldn't.
All I know so far is it happens when Zed tells me it couldn't open project and shows me the project picker by itself, I mean, I'm not calling Project: Open Project Picker myself.
Some other observations that may or may not help:

sometimes when starting Zed from my i3 menu, which calls it without parameters (no project), then Zed will open the project picker and things will get fucked up. I say things because when this happens, besides the logo issue, I also get:

split views and split preview keybindings won't work as expected. I cannot go back to Split-1, I always have two or three splits or the preview opened.

I cannot find a way to reproduce the behavior of Zed telling me it couldn't open the project and bringing up the project picker. I you can tell me when this happens, then I may be able to reproduce this.

I just found out issue #550 is also related to this situation. My AVPAG/REPAG keys are working now. So you can merge that one into this.


fix: allow skipLibCheck: false by removing internal type imports

Removes the _runtime in favor of a _mdwrArgs, i.e. instead of passing a string runtime and letting the internal type decide what type req and res should have, the createBuilder has to provide those type itself.
This lets us remove all the lib imports completely in the internal types, meaning only the specific entrypoint will import stuff from that package.
e.g. the /next entrypoint is the only file importing stuff from next, /express is the only that imports from express.
This means that we don't block (well, at least that's the goal) skipLibCheck: false for people who wanna use that option since no types are getting pulled in that they don't have.
NOTE: Some type imports from internal files are also removed in #360

I think this is also just a generally cleaner approach.

I think this is also just a generally cleaner approach.

yep - totally.


Table Search spyglass needs centering.

Table does not use a spyglass in the search field anymore so closing.


Support for midi files and MT32-Pi

I was wondering if we can add support for MIDI files and make BGM stream them on the MT32-Pi.

Hi mate. I'm really sorry, I actually thought I'd replied to this. I like the idea a lot.
The mt32-pi is probably not going to happen, I don't own one anymore and I think it'd be quite complex to do (I'm happy to be proven wrong though and would be totally happy to add support). Plain midi files definitely sounds doable but needs some thought, I don't think there's a simple midi playing utility that ships with the mister image. Maybe with fluidsynth?
I'm a bit busy with work at the moment but I'll try look into it.

And I just saw on discord you worked out how to do everything already. If you want to comment and give me your notes you worked out on playing midi files on the command line and playing them through the mt32-pi I'd be happy to put together a patch to include midi file support.

Hello @wizzomafizzo ,
Perfect timing. @ebraminio and I did some work over the weekend.
So, we have something that works and needs to get integrated into BGM.
Please find attach the binary of mt32-pi-ctl (source code here https://github.com/gmcn42/mt32-pi-control)
mt32-pi-ctl.zip
and MIDIMeister can be found on
https://github.com/bbond007/MIDIMeister/raw/main/MIDIMeister
Also I found a nice MIDI file (WILLYMT.MID) which you can find from here: https://www.midimusicadventures.com/qs/midi-zips/soundtracks/willymt.zip
To start MIDI use this
#play MIDI on MT32 as background music
killall aplaymidi
killall MIDIMeister
/usr/bin/MIDIMeister &
/usr/bin/mt32-pi-ctl -p 128:0 -r
/usr/bin/mt32-pi-ctl -p 128:0 -m
/usr/bin/aplaymidi -p 128:0 /media/fat/MIDI/MT32/WILLYMT.MID &
To stop MIDI (when you go in other cores)
#Stop MIDI when not in MENU
kill aplaymidi
/usr/bin/mt32-pi-ctl -p 128:0 -r
kill MIDIMeister
I will put a video on Discord.
Let's get started :)

Thank you both for getting this so far. I think the pull request is almost but not quite there.

It would be better if bgm checks if it's running or not and will launch the midi daemon if necessary. Before every time it plays a midi would be fine. It would be good not to have to manually add it to the startup script and I believe the /sbin/uartmode script kills an existing daemon if it's running (before and after? not sure) when a compatible core is launched
I'd prefer that playing through fluidsynth was the default behaviour. Have the mt32-pi as a configurable option. Is there some way we can check if an mt32-pi is plugged in? If so, then we can default to using it. Having a UDP server as an option would great too

What do you reckon? I can look into this when I've got some time free.

Let's do it. It all sound great.
Unfortunately there is no way to detect if an MT32-Pi is connected as there is no feedback from the ALSA MIDI client AFAIK.
So far, we have it working expect when you come back from a core (specially the AO486) things will not resume. That might be related to the multiple calls of the midi daemon.

As vast possibility of different configurations, e.g. fluidsynth with different sound fonts or mt32d or MIDIMeister for hardware setup with different possible options, I think it will be better to just indicate the possible options in README.md rather than intervening with the user setup, leaving just the common part in bgm itself.

That's a great point, totally agree. Can you even run fluidsynth in the first place without some manual setup? Don't think so.
That said, it still sounds like we need to manually launch the daemon if necessary before playing since it sounds like uartmode does actually kill it after a core is exited. Will midimeister run ok with the MENU option even if a core isn't running? Perhaps that could be a way to use preconfigured values without adding much complexity to the script.

Thank you! :)

Can you even run fluidsynth in the first place without some manual setup? Don't think so.

Yes. 'midilink', preinstalled, can run fluidsynth ok but I couldn't run it independently as it needs some configuration.

Will midimeister run ok with the MENU option even if a core isn't running?

Sure, it isn't dependent to any core, now that I have midimeister in user-startup.sh, my MiSTer just plays random MIDIs in the specified folder on startup with no issue. I just think we only should add a section to the README.md that in order to play midi files correctly with bgm one should make sure aplaymidi --port=128:0 file.mid works correctly also independently, i.e. their setup is already ok, and if not, here are the suggestions depending on your setup.


Unable to run pypdfocr.exe ver 0.9.0

Hi,
I am unable to run pypdfocr.exe 0.9.0 on Windows 7 x64. This is the error message that I get:
This version of pypdfocr.exe is not compatible with the version of Windows you're running. Check your computer's system information to see whether you need a x86 (32-bit) or x64 (64-bit) version of the program, and then contact the software publisher.

I have tested on windows 7 x64 and it runs fine for me.  Are you sure you're on 64-bit?  Have you tried an older version of pypdfocr (like 0.8.3) and does that also not work?

Closed, unable to reproduce


Add checkbox on website to add 4 spaces for reddit

I noticed you have a comment about reddit.  But you could just add it to the text input after you check a box.
or there could be a copy-to-clipboard button for reddit, which copies with spaces.

https://github.com/1j01/ascii-hypercube/pull/3


TBS-100 Utilize opcodes for server communications

I addressed the above issues and added a hook to lint our commit messages 🎉


Jac/groups

[Defect 1426885] [Tabcmd WAM] addusers and removeusers error can be clearer when group doesn't exist
[Defect 1428584] [Tabcmd WAM] Delete group not working
fixed various error messages that hadn't been localized

Confirmed this fixes deletegroup (bug 1428584) and probably the addusers one as well (bug 1426885).


Add VertexInput type

Changelog:
Replace the line about VertexDefinition with:
- **Breaking** The `VertexDefinition` trait no longer has `AttribsIter` and `BuffersIter` as associated types. It instead returns a `VertexInput`.

Add:
- Added `VertexInput` type, which contains the binding and attribute descriptions.
- Added a `vertex_input` method to `GraphicsPipelineAbstract`, which returns a reference to the vertex input.

The main purpose of this change is to allow other code to access the vertex input description. This is needed for the work I'm doing on #1635, since draw commands need to be able to know which of the bound vertex buffers they are going to access. However, it's also a step closer to being able to eliminate the last remaining type parameter of GraphicsPipeline, and therefore the GraphicsPipelineAbstract trait.

Looks good

I think you forgot to include the replacement for the removed text in the changelog?

Indeed. I misread the changelog part "Replace the line about VertexDefinition with:" as "Remove...".


Add delta timing to update function for branch object

To reduce constantly calling the get_delta_ticks for objects with logic, default to calling update(float delta_time) for all branch objects .

This was completed in Spring Milestone via https://github.com/pawbyte/Game-Pencil-Engine-Editor/pull/108/commits


Link to JSCS Configuration in contributing.md is broken

Hey all,
I was trying to see how this project uses JSCS, and saw that the link to the jscs config under the Coding Rules section in contributing.md gives me a 404. I think(?) the link should point to the .jscsrc file, but it currently points to https://github.com/google/material-design-lite/blob/master/jscs-config, which doesn't exist.
I'd be happy to submit a PR that fixes this. Just wanted to make sure that I have the correct links.
Thanks!

I think this issue is fixed in the following PRs https://github.com/google/material-design-lite/pull/774 https://github.com/google/material-design-lite/pull/837 https://github.com/google/material-design-lite/pull/840

Yes, as @yuyokk mentioned, this has been fixed. Thanks, @achalv :)


How to set custom MQTT server

I don't want to use the built-in MQTT server from HA, where can I set my MQTT server IP? Thanks

In this case you can use Sungather, or solariot.


[timeseries] presets: Support CrostonClassic and CrostonOptimized

Fixes #4393
Issue #: 4393
Description of changes: This PR adds CrostonClassic and CrostonOptimized to the list of supported model types.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Hi @hsbadr, thanks for submitting the PR and sorry for a slow response!
We've decided to deal with #4393 by unifying the 3 Croston models (CrostonClassic, CrostonSBA, CrostonOptimized) into a single model Croston and allowing the user to choose the specific model type using the version hyperparameter. These changes are implemented in #4564

Thanks @shchur! Sounds great. I'm closing this PR.


Remove Admin API

This is not required anymore as Rummager listens to the Publishing API queue.
See: alphagov/panopticon#386
https://trello.com/c/mElcg7zG

👍 once https://github.com/alphagov/panopticon/pull/386 is deployed.


silence noisy logging

Every time a virtual table description is loaded (cache miss), we log details about the table. This is especially noisy during zos dyno restarts.

Codecov Report

Merging #595 into master will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #595   +/-   ##
=========================================
  Coverage     73.45%   73.45%
  Complexity      783      783
=========================================
  Files            54       54
  Lines          3850     3850
  Branches        482      482
=========================================
  Hits           2828     2828
  Misses          821      821
  Partials        201      201

Impacted Files
Coverage Δ
Complexity Δ

.../dynamodbv2/mt/admin/AmazonDynamoDbAdminUtils.java
67.69% <100%> (ø)
13 <0> (ø)
:arrow_down:

.../mappers/sharedtable/impl/TableMappingFactory.java
90.41% <100%> (ø)
10 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a23b32c...f604937. Read the comment docs.


Stop using crontab

Because it runs as root and messes things up.
Use systemd instead...

Fixed in #4


add option to build HVM AMIs

This change is needed to be able to build HVM AMIs using t2 generation instances.

Oops, this was already solved in d75560e308c20ebe0cfbd6ec08491c3a7310d372


doc: Add clear settagstack example for plugins

Add an example using 't' which is the simplest way to use settagstack to
implement 'jump to definition' behaviour -- the same behaviour as C-].
None of the examples are very clear about how a plugin author should use
settagstack because they omit handling other tagstack entries.
I've been thinking about this since #3336 was closed because it wasn't clear to me how to use the new functions. Looks like #5417 introduced a simple API. This PR adds an example using that new API.
I applied this pattern to vim-lookup and it works correctly in my tests.
(I guess existing implementations like vim-lsp, vim-lsc, racer-rust all predate the 't' argument and that's why use a much more convoluted method?)

Even with this simple example, I initially got it wrong because getcurpos() returns 0 for the bufnr! Fixed and tested by manually entering each line, changing to another file, and C-t.

@yegappan can you review this?

Thanks, I'll include it.


Locked funds in Deposit contract

A user deposit may not be applied by L2. I'm trying to figure out cases where this OK. From my current understanding, this should not be desirable because the user cannot generate proofs to redeem the fund locked in the deposit feed. In particular, I'm concerned about this piece of code here. The following is a scenario that triggers the opnode error highlighted in the aforementioned code.

Fund an account with 2 ETH on L1.
Create a deposit transaction on L2, minting 1 ETH, while transferring 5 ETH to any address:

depositTransaction{value: 1 ether}(address, 5 ether, 40000, false, "0x")

Doing so does not create any deposit transactions on L2, and the account balance of the sender remains unchanged. So not even the minted ETH is added to its balance. While this is obviously a bug, its resolution is not totally clear. But maybe we can decide on the following:
Expected behavior

The engine mustn't drop any deposit transactions. Maybe this can be relaxed for deposits that don't mint.
Any ETH minted in a deposit tx must always be applied to the depositor's account, even if the deposit tx itself reverts.

This was fixed in https://github.com/ethereum-optimism/optimistic-specs/pull/366 I believe


Remove the usage of must_cache and async_cache

What changes are proposed in this pull request?
current version didn't support must_cache and async_cache, so remove the usage of must_cache and async_cache usage in code and mark deprecated to prevent any use.
Why are the changes needed?
This change focuses on removing the write type of MUST_CACHE and ASYNC_CACHE, and https://github.com/Alluxio/alluxio/pull/17980 would remove the master-side code about async persist.
Does this PR introduce any user facing changes?
No

Please also have a simple test to make sure it works.

alluxio-bot, merge this please


Missing First Character for Theorems

Hello, I'm a big fan of your notes package and I have just started using it for my own math notes. The only issue I'm having is that the first letter of anything in any of the environments keep getting dropped. I feel like it is probably user error rather than an issue with the package, but I figured I'd ask just in case you knew what I was doing wrong. Thanks for you awesome work.

Well I figured out what I'm doing wrong; I had just gone from a traditional math environment to yours and the issue only appears when the theorem/definition is unnamed. There's an easy fix with search and replace as I have just copied and pasted in 1500 lines of notes and I'd rather not have to name everything specifically. Just out of curiosity, do you know if there is a way to make this work without having to name things?

Oh my. Ignore all of this. I feel awfully silly. I should have read you example code better.

Yeah you need to add the label {thm:label} after every colored environment you define. Having a name for an environment is not compulsory.


The "Error" popup is displayed after opening the sending G$ link

Description
The "Error" popup is displayed after opening the sending G$ link
Precondition:
There is a send token https://goodqa.netlify.com/AppNavigation/Dashboard/Home?paymentCode=82f5c433ae3ec41330c7&reason=Test
There is a user (hollow edit hobby path cup pave flower shuffle build quiz abstract pink)
Steps to reproduce:

Open the website
Login
Open the link from pre-condition
Pay attention to the error

Actual result: The "Error" popup is displayed after opening the sending G$ link
Expected result: The money are withdraw to the user account after opening the sending G$ link
Supporting data
Env https://goodqa.netlify.com
iPhone X / Safari
https://www.screencast.com/t/wNYEjUdI

@qatests1001 in order to take a better look into this would be useful to have both accounts: sender and receiver. I'm assuming that the one that you shared is for the receiver right?

@dminones
Sender: hollow edit hobby path cup pave flower shuffle build quiz abstract pink
Receiver: soul usual cup disorder tool state kit midnight consider filter camera sound

@qatests1001 ok, seems like all the links were withdrawn for sender account since are marked as completed (perhaps you opened the link in sender session?). I've just tried myself and was able to send and receive from those accounts.
As example, I've left a pending transaction without withdrawing and this transaction looks very different if nobody withdraws that G$

@qatests1001 this happens when opening link immediatly before it is confirmed on the blockchain


[GH-37751] [C++] [Gandiva] Avoid registering exported functions multiple times in gandiva

Rationale for this change
Try to fix https://github.com/apache/arrow/issues/37751
What changes are included in this PR?
The exported functions defined in gandiva are registered multiple times unnecessarily. This PR tries to address this issue.
Are these changes tested?
The PR doesn't affect any external behavior, and is covered by existing tests, and should pass all existing tests.
Are there any user-facing changes?
No

Can you also fix the lint issue in CI?

Can you also fix the lint issue in CI?

Sure. I fixed the lint issue in CI in the new commit.

Can you also add a unit test to make sure each function is only registered once?

I tried to do that, but currently the registered() method of ExportedFuncsRegistry is a private method, and it is not possible to retrieve the list of currently registered functions from the registry externally, so it is not possible to add such a unit test unless we make the registered() method public. Do you have any recommendation for this? Thanks.

@js8544 this PR is ready for review. There is still one check failing, but it seemed irrelevant with my change (may be caused by CI network issue as far as I can tell). Any comment is appreciated. Thanks.

@github-actions crossbow submit -g cpp

Thanks! LGTM now. Will need @pitrou's approval to merge.


Support tree-shakable imports for --target es2015

Changes the emit for --importHelpers when the module kind is es2015 or esnext so that they are tree-shakable by WebPack.
For example, we previously would emit:
// --module es2015
import * as tslib_1 from "tslib";
const obj = tslib_1.__assign({}, other);

But now we emit:
// --module es2015
import { __assign } from "tslib";
const obj = __assign({}, other);

The emit for commonjs, amd, umd, and system is unaffected.
Fixes #16999

I'd expect our emit to be something like [...]

We explicitly don't do this for any helpers, because we allow you to replace helpers. If we renamed a helper because we found a declaration with the same name at the top-level, we would break that feature.

We explicitly don't do this for any helpers, because we allow you to replace helpers. If we renamed a helper because we found a declaration with the same name at the top-level, we would break that feature.

But that doesn't work for import helpers, because the helper gets imported and accessed via namespace (usually)?

"Rename the helper for all uses of the helper in the file but only if its imported and --target ES2015, but don't rename it if its emitted inline" seems kind of an esoteric rule that I'm not sure is 100% necessary.

I'm just point out hat previously
const x = {};
const __assign = {...x, x: 12};
export {};

with importHelpers: true, target: es5, and module: es6 would work at runtime without error, while after the import style change, its behavior changes and now __assign mangles the import...

Fair enough. I'll look into it tomorrow.

I've added import aliases for cases where there are collisions.


Support completing built-in objects

Introduced in https://github.com/mdempsky/gocode/commit/9f6c12218c306acb79904362833755c25464b778
When enabled, completions for built-in types like string will be available. For example:

Merged.


Add Icons to contacts in Resume

Add Icons to resume contacts.
Example Screenshot

Can you explain more briefly on this issue

Can you explain more briefly on this issue

You will simply add the social icons to the template, for the email and phone number etc.
Would you like to work on this?

Just now, I explore your website, but I don't understand where you want to add this template. (Home page or Where?)

Just now, I explore your website, but I don't understand where you want to add this template. (Home page or Where?)

I want to add it in the resume builder tool

Just now, I explore your website, but I don't understand where you want to add this template. (Home page or Where?)

I want to add it in the resume builder tool

Okk, Can I work on it?

Just now, I explore your website, but I don't understand where you want to add this template. (Home page or Where?)

I want to add it in the resume builder tool

Okk, Can I work on it?

Sure


Update type for ngModelAttrs with key String

angular-formly/angular-formly.d.ts
to author(@scatcher). could you review this PR?
:+1: or :-1:?
check list

[ ] pass the Travic-CI test?

:+1:

thanks mate!


Add Feature: Node Status Report

We need Node Monitor to create and send a once-daily status report.
This status report must tell the recipient if any of their nodes are down, and if so, which ones.
It must be easily readable without the recipient having to do any math.
🩺
Method:

Create a new instance variable called self.last_status_report
On every step, Node Monitor should check if time.now() - self.last_status_report >= 1 day
If True, create and send out the status report.
If False, do nothing

The current notification message can be made more user friendly as it doesn't immediately tell the NP that their nodes are ok. NPs still need to remember the total number of nodes they have in production and make sure that is equal to the number of nodes "UP" + "UNASSIGNED"
Solution: The first line of the status report message should already indicate if action is required (this will tend to be what is seen on mobile notifications as well). More concretely:

#nodes 'UP' + #nodes 'Unassigned' = #nodes in production --> No action required
#nodes 'UP' + #nodes 'Unassigned' != #nodes in production --> Action required

After this first line, then the rest of details of the status report can be added (#nodes up, unassigned etc.) If you think of other data that could be included feel free to add that along.
Requirements:

[ ]  Add fields (probably in the preference or channel detail table) to show the number of nodes a NP has in production
[ ]  SQL query to get the number of nodes
[ ]  Function to construct message (maybe in the directory node_monitor_helpers


Logging not Working for me

Description
Write a simple log inside a test:
TEST_CASE ("asset_path not empty")
{
      INFO("hello"); //! print nothing
      auto result = nephtys::client::details::assets_real_path().string();
      INFO("appimage asset real path: " << result); //! print nothing
      CHECK_FALSE(result.empty());
}

Steps to reproduce
Write a simple test with logging
Extra information

doctest version: 2.3.1 (through conan)
Operating System: Linux
Compiler+version: gcc-8/gcc-9/clang-8 Linux

Even with the unit test from the source code nothing appear:

static int someTests() {
  int some_var = 42;
  INFO("lots of captures - some on heap: " << some_var << " " << some_var << " " << some_var << ";");
      FAIL_CHECK("forcing the many captures (including those on the heap) to be stringified");
  return some_var;
}

TEST_CASE("a test case that will end from an exception") {
  int some_var = someTests();
  INFO("someTests() returned: " << some_var); // note that we have to use a local variable - cannot pass a temporary
  INFO("this should be printed if an exception is thrown even if no assert has failed: " << some_var);
  {
    INFO("in a nested scope this should be printed as well: " << some_var);
    {
      INFO("this should not be printed");
      CAPTURE(some_var);
    }

        CHECK_MESSAGE(some_var == 666, "why is this not 666 ?!");
  }
}

logged context with INFO is shown only if an assert fails. In your first example it seems that the assert is successful - note that it isn't checking for a true condition, but for a false one - meaning that .empty() probably returns false, and since you are using a <TYPE_OF_ASSERT>_FALSE(expr) assert it would be a success if the expression evaluates to false (in contrast to the standard <TYPE_OF_ASSERT>(expr)).
As for the second example - I do get output and it looks like this (precisely what I would expect):
[doctest] doctest version is "2.3.1"
[doctest] run with "--help" for options
====================================================================
D:\doctest\scripts\playground\test.cpp(16):
TEST CASE:  a test case that will end from an exception

D:\doctest\scripts\playground\test.cpp(12): ERROR: forcing the many captures (including those on the heap) to be stringified
  logged: lots of captures - some on heap: 42 42 42;

D:\doctest\scripts\playground\test.cpp(27): ERROR: CHECK( some_var == 666 ) is NOT correct!
  values: CHECK( 42 == 666 )
  logged: someTests() returned: 42
          this should be printed if an exception is thrown even if no assert has
 failed: 42
          in a nested scope this should be printed as well: 42
          why is this not 666 ?!

====================================================================
[doctest] test cases:      1 |      0 passed |      1 failed |      0 skipped
[doctest] assertions:      2 |      0 passed |      2 failed |
[doctest] Status: FAILURE!

So... are you sure you aren't executing the binary from the second example with -tc="asset_path not empty"? Because the test is named "a test case that will end from an exception".

I just misunderstood the context, I think it's was permanent logging, I want a permanent logging for each run !

In that case you should make use of MESSAGE() - let me know if that is what you need.

Perfect, thank's a lot, the documentation was not evident for me !


How to combine this add-on with markdown?

I want to use this markdown add-on with ember.
Has anyone done this already?

Hi @harianus I don't have any plans to integrate this in the near future, but feel free to send pull requests.


Install problem

I can not follow the step below you provided previously. Could you have any suggestion for the detail, any video or any picture?
Then follow this - https://github.com/chrisleekr/binance-trading-bot#how-to-use
PS: I have Ubuntu in my computer.
Best

@Akincayir
All you need is docker & docker-compose installed in your Ubuntu.
Please google it and install them.
Please close the issue if your issue is resolved.


Added Zurix Network (Read description)

Server not mapped, still says "Playing on Private Server". (zurix.us)

You'll probably get better luck joining the Lunar Client Developers Discord -> https://discord.gg/3T9Atyb6pf
Pull requests with no files changed will just get closed immediately

I've already updated the store, that's enough I guess.


body with an empty json not getting encoded

Im sending a body that has in it an empty json.
["and": [["id": ["inq":["1", "2", "3"]]], [:]]]
Im using a URLRequestConvertible enum.
after the encoding in asURLRequest
try URLEncoding.default.encode(urlRequest, with: params)
I get
query[and][][id][inq][]=55b6725435c49b0300a1f979
and its missing the empty json.
Is there a way to leave the empty json in the body?
Thanks

You want to use URLEncoding.queryString instead. That will leave your httpBody intact. I'd definitely suggest reading through the docstrings for URLEncoding to get a better feel for the options available to you.
Cheers. 🍻

Thanks @cnoon .
This doesn't work.
Using .methodDependent, .httpBody  gives me the same result (missing empty json).
Using .queryString appends the body to the query instead of the http body.

Can you give us your brief function code how you are calling and adding perams.?

enum AssignmentRouter: URLRequestConvertible {

    case assign(params:[String:Any])

    var method: Alamofire.HTTPMethod {
        switch self {
        case .assign:
            return .post
        }
    }

    var path: String {
        switch self {

        case .assignForms(params: _):
            return "/**/a"
        }
    }

    var params: [String: Any]? {
        switch self {
        case .assign(let params):
            return params
        }
    }

    func asURLRequest() throws -> URLRequest {
        let url = (APIManager.baseURL + path).encodeUrl()
        var urlRequest = URLRequest(url: URL(string: url!)!)

        urlRequest.httpMethod = method.rawValue

        //add headers
        APIManager.addHeraders(urlRequest: &urlRequest)

        return  try URLEncoding.default.encode(urlRequest, with: params)
    }
}

Please Try this
first convert your parameter in to JSON string and use this
try! StringBodyEncoding(string: JSONString ).encode(urlRequest,with:nil)
Custom Encoding Struct
struct StringBodyEncoding: ParameterEncoding {
    private let string: String

    init(string: String) {
        self.string = string
    }

    func encode(_ urlRequest: URLRequestConvertible, with parameters: Parameters?) throws -> URLRequest {
        var urlRequest = urlRequest.urlRequest
        urlRequest?.httpBody = string.data(using: String.Encoding.utf8, allowLossyConversion: false)
        return urlRequest!
    }
}

Not working for me, the empty JSON is still missing.

What is the empty JSON you would expect to send @ilandbt...let's start there. What would you like to send up to the server. By empty do you mean nothing? I'm assuming not, but have to ask. I would "assume" you're trying to send an empty dictionary {}. Is that correct?

@cnoon i want to send this JSON:
{"and": {{"id": {"inq":{"1", "2", "3"}}}, {}}}

Thanks for posting that @ilandbt...I've found a few issues in your expectations. First off, the JSON you just posted isn't valid. You are encoding arrays as dictionaries which results in invalid JSON. The valid form of the dictionary in your original question is:
import Foundation

let parameters: [String: Any] = ["and": [["id": ["inq":["1", "2", "3"]]], [:]]]

do {
    let data = try JSONSerialization.data(withJSONObject: parameters, options: [])

    if let utf8 = String(data: data, encoding: .utf8) {
        print("JSON: \(utf8)")
    }
} catch {
    print(error)
}

// Outputs: {"and":[{"id":{"inq":["1","2","3"]}},{}]}

This is certainly your core issue "if" the invalid JSON you posted is actually what you need to send. In case you just posted the JSON wrong, I went a step further to make sure the empty JSON dictionary is actually encoded when using JSONEncoding.
func testEmptyJSON() {
    let urlRequest = URLRequest(url: URL(string: "https://httpbin.org/get")!)
    let parameters: Parameters = ["and": [["id": ["inq":["1", "2", "3"]]], [:]]]

    do {
        let httpBody = try JSONEncoding.default.encode(urlRequest, with: parameters).httpBody

        if let httpBody = httpBody, let utf8 = String(data: httpBody, encoding: .utf8) {
            print("JSON: \(utf8)")
        }
    } catch {
        print(error)
    }
}

// Outputs: {"and":[{"id":{"inq":["1","2","3"]}},{}]}

As you can see, it outputs the same JSON as the other example and DOES include the empty dictionary.
What I'd recommend is using the debugPrint(request) approach to print out the cURL command for the request. That will show you exactly what's being sent to the server.
If you are debugging on the server, then I'd try to figure out if the server is stripping off the empty dictionary although I really doubt it. You could also use the cURL command and something like Charles Proxy to continue to debug.
At this point, this is on you to investigate because Alamofire is working exactly as it should in this case. If you do need to encode the invalid JSON that you posted, then you'll need to implement your own ParameterEncoding type because Alamofire does not encode invalid JSON.
If you continue to have issues, please take your question to Stack Overflow.
Cheers. 🍻

Thanks @cnoon
My problem was using URLEncoding  instead of 'JSONEncoding'
The invalid JSON was a mistake in the comment.


Using Gulp

You should consider using Gulp as a build system, removing bash-script dependencies. This will make it easier to build across platforms, and easier for developers only accustomed to JavaScript to develop, build and help improve the application.

Im considering it, but I want to be sure I have all the freedom I need

Gulp is a build system where you program the different tasks in JavaScript (similar to Gradle for Java), so you should have the same freedom as you would get with a bash script.