YARN-11360: Add number of decommissioning nodes to YARN cluster metrics.

Description of PR
YARN cluster metrics expose counts of NodeManagers in various states including active and decommissioned. However, these metrics don't expose NodeManagers that are currently in the process of decommissioning. This can look a little spooky to a consumer of these metrics. First, the node drops out of the active count, so it seems like a node just vanished. Then, later (possibly hours later with consideration of graceful decommission), it comes back into existence in the decommissioned count.
This issue tracks adding the decommissioning count to the metrics ResourceManager RPC. This also enables exposing it in the yarn top output. This metric is already visible through the REST API, so there isn't any change required there.
How was this patch tested?
The patch adds new unit tests for the ResourceManager RPC, correct merging of the metric through the router service and yarn top.
For code changes:

[X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[X] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[X] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 44s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m 42s

trunk passed

+1 :green_heart:
compile
10m 34s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
9m 15s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
2m  9s

trunk passed

+1 :green_heart:
mvnsite
6m 10s

trunk passed

+1 :green_heart:
javadoc
5m 45s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
5m 32s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
10m  4s

trunk passed

+1 :green_heart:
shadedclient
23m  8s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 33s

the patch passed

+1 :green_heart:
compile
10m  2s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
cc
10m  2s

the patch passed

+1 :green_heart:
javac
10m  2s

the patch passed

+1 :green_heart:
compile
9m 31s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
cc
9m 31s

the patch passed

-1 :x:
javac
9m 31s
/results-compile-javac-hadoop-yarn-project_hadoop-yarn-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.txt
hadoop-yarn-project_hadoop-yarn-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 generated 4 new + 642 unchanged - 0 fixed = 646 total (was 642)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 56s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
hadoop-yarn-project/hadoop-yarn: The patch generated 3 new + 176 unchanged - 0 fixed = 179 total (was 176)

+1 :green_heart:
mvnsite
5m 36s

the patch passed

+1 :green_heart:
javadoc
4m 58s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
5m  0s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
10m 21s

the patch passed

+1 :green_heart:
shadedclient
23m 19s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 34s

hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
5m 25s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
100m 26s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
unit
28m 55s

hadoop-yarn-client in the patch passed.

-1 :x:
unit
5m 58s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
1m 14s

The patch does not generate ASF License warnings.

338m 43s

Reason
Tests

Failed junit tests
hadoop.yarn.server.router.clientrm.TestFederationClientInterceptorRetry

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5060/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5060

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets cc buflint bufcompat

uname
Linux c36a346bf48e 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a201215392c65e5d65b60fc6f0b5f69f0515c42e

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5060/1/testReport/

Max. process+thread count
974 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5060/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@cnauroth this Junit Test error is caused by YARN-11342 (#5005), I submitted a fix patch YARN-11357(#5055). Can you help review this pr(#5055)?

Can you help review this pr(#5055)?

@slfan1989 , thanks for notifying me of the test failure! I gave +1 on your patch, but I'd also like to see one more code review from someone who has spent more time than me in the federation code.

@slfan1989 , thanks for notifying me of the test failure! I gave +1 on your patch, but I'd also like to see one more code review from someone who has spent more time than me in the federation code.

@cnauroth Thank you very much for your help reviewing the code!

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 42s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 31s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
28m 26s

trunk passed

+1 :green_heart:
compile
11m 10s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
9m 51s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
2m 18s

trunk passed

+1 :green_heart:
mvnsite
6m 27s

trunk passed

+1 :green_heart:
javadoc
5m 48s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
5m 32s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
10m 24s

trunk passed

+1 :green_heart:
shadedclient
24m 37s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 31s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 38s

the patch passed

+1 :green_heart:
compile
10m 24s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
cc
10m 24s

the patch passed

+1 :green_heart:
javac
10m 24s

the patch passed

+1 :green_heart:
compile
12m 35s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
cc
12m 35s

the patch passed

-1 :x:
javac
12m 35s
/results-compile-javac-hadoop-yarn-project_hadoop-yarn-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.txt
hadoop-yarn-project_hadoop-yarn-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 generated 4 new + 642 unchanged - 0 fixed = 646 total (was 642)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 59s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 176 unchanged - 0 fixed = 177 total (was 176)

+1 :green_heart:
mvnsite
5m 42s

the patch passed

+1 :green_heart:
javadoc
5m 32s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
5m 10s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
10m 48s

the patch passed

+1 :green_heart:
shadedclient
24m 27s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 33s

hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
5m 29s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
102m  9s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
unit
29m  7s

hadoop-yarn-client in the patch passed.

+1 :green_heart:
unit
6m 17s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
1m 19s

The patch does not generate ASF License warnings.

351m 58s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5060/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5060

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets cc buflint bufcompat

uname
Linux 0472c4e96392 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 767ddb937b8013633e1bc5c8f4758d89cac16a3c

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5060/2/testReport/

Max. process+thread count
977 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5060/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Regarding Checkstyle -0, TopCLI.java has 134 pre-existing Checkstyle violations. For consistency, my patch is continuing one of the class's patterns that triggers a Checkstyle violation. I'm not planning to address this right now. We could do a big style cleanup later, but I don't want to mix it with real logic changes here.
Pre-commit tests also reported new compiler warnings, pasted below. I don't understand why this is happening. It looks unrelated to anything I'm changing in this patch, but I also can't reproduce the warnings locally.
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestNoHaRMFailoverProxyProvider.java:153:9:[unchecked] unchecked conversion
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestNoHaRMFailoverProxyProvider.java:258:11:[unchecked] unchecked conversion
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestRMFailoverProxyProvider.java:255:11:[unchecked] unchecked conversion
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestRMFailoverProxyProvider.java:283:11:[unchecked] unchecked conversion

[nit]
@cnauroth, may be you want to uncheck the below in PR description
* Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
* If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
* If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

[nit]
@cnauroth, may be you want to uncheck the below in PR description
* Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
* If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
* If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

Thanks for the suggestion. I made the update.
Thanks also for the code review and LGTM!

I have committed this to trunk, branch-3.3 and branch-3.2 (after resolving a minor merge conflict). @mikaylakonst , @ashutoshcipher and @abmodi , thank you for the code reviews.


which filetype for 'plantuml' snippets

I see that 'plantuml' snippets are supported. But they don't show up for me.
The plugin works with GdScript files. So maybe I am using a wrong file type?

Hi @gitacrobat, I checked again and it seems you will need to add a line to you configuration to set the file type.
E.g. init.lua, below will support *.plantuml and *.puml.
vim.cmd('autocmd BufNewFile,BufRead *.plantuml set filetype=plantuml')
vim.cmd('autocmd BufNewFile,BufRead *.puml set filetype=plantuml')

Closing, feel free to re-open if you run into further issues :sunglasses:


toastr js and css minify blocked

Hi,
I have a problem, when i load my page, i have this error on the console "net::ERR_BLOCKED_BY_CLIENT" for toastr.min.js and toastr.min.css load.
When i disable my adblock, i don't have the error.
Can someone help me please?

I report the example here https://forums.lanik.us/viewtopic.php?f=91&t=34539
Hi, same here, but the moderator of the adblock FR list want a REAL example (i have only local sample or demo sample). Do you have a "real" online example please?

This has been corrected by the AdBlock team. Thanks to those who assisted.


Fixes to write_calfits to ensure units are correct and tols are met

Addresses #311.
I worry that this will affect downstream pipelines, because it looks like there were certain scenarios where the time deltas were being stored in units of seconds, and other instances stored in units of days. So it would be good to have @zakiali @jsdillon and @nkern look at this to see if we need to include backwards compatibility.

The parameter description of integration_time on the uvcal object says that it has units of seconds, but it looks like you're assuming units of days here.

I think it's just the opposite - the old code assumed integration_time and time_array were in the same units. Now I am converting integration_time into days to use as time_spacing, which is used for setting the time axis delta. In other words, CRVAL3 and CDELT3 need to be in the same units, so I'm converting the spacing to match.

Sorry, I misread it. Thanks for the clarification.

I approved but didn't merge this in case you wanted to wait for comment from others.

This doesn't affect hera_cal.io.load_cal or hera_cal.io.update_cal, but it may affect hera_cal.io.write_cal. @nkern what do you think?

I've always thought that the UVCal.integration_time attribute has units of seconds..

@adampbeardsley we can always change hera_cal.io.write_cal to match whatever pyuvdata wants, so don't worry too much about us

@adampbeardsley just be sure to make sure the docs are up-to-date :)

Ok, don't say I didn't warn y'all...


remove useless dependencies

dump v0.2.3
for the crate root

serde_yaml
log

fix this issue: https://github.com/Fabinistere/yml_dialog/issues/12


Feature/po demo ---- DO NOT MERGE -- ONLY FOR DEMO

Before creating a pull request make sure that:

[ ] commit messages are meaningful and follow good commit message guidelines
[ ] README and other documentation has been updated / added (if needed)
[ ] tests have been updated / new tests has been added (if needed)
[ ] Screenshot attached for the Evidence of manual testing
[ ] Functional, Smoke and API tests have been run locally
[ ] Full gradle build and run tests with coverage have been completed (if needed)

Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
Change description
Testing branch and instruction
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ ] No

demo completed. Hence closing this pr.


Remove System.Web and web caching from shapefile

The AppVeyor build failed with an error here:
C:\projects\mapsui\Mapsui.Desktop\Wms\WmsProvider.cs(416,44): error CS1069: The type name 'HttpUtility' could not be found in the namespace 'System.Web'. This type has been forwarded to assembly 'System.Web, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' Consider adding a reference to that assembly. [C:\projects\mapsui\Mapsui.Desktop\Mapsui.Desktop.csproj]

@janusw Fixed that in the later MR.


Long frames and stalling at startup

On startup, the map stalls as resources load in (with some very long frames). While this is a problem in general, it is especially pronounced during the initial environment load and theme change.

Resolved as far as we can for current release.


Implement kill switches using https://vercel.com/docs/storage/edge-config

Closing until we have a concrete use case


Bottombar not working in Vanilla javascript

it displays blank screen as I embedded it with another GridLayout under TabView element in android
<GridLayout ...> <TabView ....> ...... </TabView <FAB:fab     row="1"     icon="res://add"     tap="fabTap"     rippleColor="#fff"     class="fab-button" />  </GridLayout> <GridLayout row="9" rows="*, auto">   <StackLayout row="0" orientation="vertical">     <Label text="demo"></Label>   </StackLayout>   <btn:BottomBar tabSelected="tabSelected" titleState="1">      <btn:BottomBar.items>       <btn:BottomBarItem title="Cake" icon="res://icon" />       <btn:BottomBarItem title="Favorites" icon="res://icon" />       <btn:BottomBarItem title="Settings" icon="res://icon" />     </btn:BottomBar.items>   </btn:BottomBar> </GridLayout>

Cant have less than 3 BottomBarItem

I have pasted the one  in the demo example but it would blank my screen not displaying  any content. I have the following on my page
Telerik side drawer,
Tabview & floatingactionbutton
Is there any of this BottombarItem would not work with?

Your path to your icon is wrong too, no need for res://

Now I think I have an error saying as show in the picture below

Ok,
Which version of NativeScript are you using? And which version of nativescript-bottombar?
This issue has nothing to do with the fact that you use Vanilla JS, it should work also on non-angular apps !

│ nativescript     │ 3.1.3           │ 3.1.3          │ Up to date    │
│ tns-core-modules │ 3.1.0           │ 3.1.0          │ Up to date    │
│ tns-android      │ 3.1.1           │ 3.1.1          │ Up to date
"nativescript-bottombar": "^2.1.4",
alright thanks

ok, this is a common issue, always look in the closed one before opening a new one:

tns plugin remove nativescript-bottombar
rm -rf platforms
tns plugin add<EMAIL_ADDRESS>tns run android

And it should work! 👍

@bismert please close this issue if it's fixed 😄

I'm so sorry I've not been able to fix it that's why I have not closed it.
I have  tried so many things else like changing my default language from Vanilla javascript to Typescript and started a new project under that. I tried following the above solution it worked i.e that particular error stopped only to report something new like below

Thanks for the feedback @bismert,
So one more time, when you get issues like this there is no reason that it occures because of the language that you use, TypeScript is the same as JavaScript.
This error is also another common issue that you can find in the closed one. This error occures when your icon path is wrong.
Since you have icon="icon" you should have a file in your drawable folders called icon.png

I really want to commend your selfless commitment but then, not yet fixed then I get this error

it still the same, the icon exist in all the drawable folders

Make a screenshot of your ressources folder with the icon in it please :)

do you have it on each of your drawable folders?

Yes its there in all the drawable folders

Well can't you help you more.
If you want more help please provide a repo with the issue.
Thanks 😄

here's the repo link
Thanks in advance
BottomBarNotFound

I'm facing the same problem, followed the recomendations above and nothing worked. My version is the same as bismert's.

@rhanb any other recomendation? Am I doing something wrong?

Hi @AdeilsonSilva ,
I'm working on an other plugin right now which is my priority ! I need time to fix this issue, will keep you up to date when i'll fix it !
Cheers from France

I have the same issue now

I manage to make it work in a plain typescript nativescript app. Checkout the demo 😄


BUG - Child products in salsify missing data when imported

Describe the bug
When a product is a child in salsify it will only have fields that are directly attached to it exported. This causes issues because there is missing data in silverstripe that is present in salsify.
Expected behavior
Child product should have all the fields listed in salsify filled.
How to fix
If a product has a property called salsify:parent_id it should look up the parent and merge the data before mapping.

Fixed in #84


Get first and last name

Hi,
I added these lines here:
graph = request.facebook.graph
fb_profile = graph.get_object("me")
user.first_name = fb_profile['first_name']
user.save()

When I try to connect I get this error: int() argument must be a string or a number, not 'AnonymousUser'.
Why?

The graph will be removed due to Facebook dropping support for their "official" python sdk

But, presumably, you've tried to save an AnonymousUser instead of creating a new User()?

Looked at it again.
You're definitely trying to save an anonymous user. The user will only be a regular Django user after the call to login


Microsoft.Diagnostics.Tracing.TraceEvent 2.0.6 Version only supports .NET4.7.1

can you please allow Microsoft.Diagnostics.Tracing.TraceEvent 2.0.6 to be used with .NET4.6.2 is forcing 4.7.1
also please include Missing reference to Microsoft.Win32.Registry

Please try version 2.0.10.    There was an issue that was fixed that was probably your problem.
I just tried it on project that was built against V4.6 and it worked for me.


Not working in Sketch 48

The plugin no longer works for me. I'm not able to see previews while configuring. After applying a loop, the layer group is flattened into a single layer that cannot be selected. If I hit 'Undo', the layer group folder displays (along with the layer copies), but the effect did not compose on the artboard (all layers are stacked on each other).

Doesn't work in recently released v49 either.

Hey Dave, I am not able to replicate this :( Can you try removing other plugins and give it a try to just make sure its not bec of an conflict of some sorts? Cheers!


Add device ID for RM Mini3

My RM mini3 model shows this device ID
add it to DeviceType.
Learn Code/Send Hex Code acts correctly

This project never updated so I forked it with you fix and another devices as well
https://github.com/fbacker/broadlinkjs-rm

Hey @tonyshare1 , thanks for providing the device identifiers. I've included them along with another in the latest update.


BTree Example

Codecov Report

Merging #1496 (f78d658) into master (f91b5b5) will decrease coverage by 0.00%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master    #1496      +/-   ##
==========================================
- Coverage   71.00%   71.00%   -0.01%
==========================================
  Files         413      414       +1
  Lines       40015    40028      +13
==========================================
+ Hits        28414    28420       +6
- Misses       9810     9812       +2
- Partials     1791     1796       +5

Flag
Coverage Δ

go-1.14
?

go-1.15
71.00% <88.88%> (+0.04%)
:arrow_up:

go-1.16
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

container/gtree/gtree_btree.go
92.15% <88.88%> (+3.78%)
:arrow_up:

net/gtcp/gtcp_pool.go
28.40% <0.00%> (-10.23%)
:arrow_down:

os/gspath/gspath_cache.go
80.70% <0.00%> (-7.02%)
:arrow_down:

os/glog/glog_logger_rotate.go
68.78% <0.00%> (-2.93%)
:arrow_down:

net/gtcp/gtcp_conn.go
31.89% <0.00%> (-2.17%)
:arrow_down:

container/gtree/gtree_avltree.go
92.03% <0.00%> (-1.20%)
:arrow_down:

container/gtree/gtree_redblacktree.go
86.68% <0.00%> (-0.47%)
:arrow_down:

os/gcmd/gcmd_command.go
70.00% <0.00%> (ø)

frame/gins/gins_httpclient.go
100.00% <0.00%> (ø)

os/gcmd/gcmd_parser.go
74.26% <0.00%> (+2.20%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f91b5b5...f78d658. Read the comment docs.


Possible CHROME BUG with Foreign Object content

Hello, I'm using d3 to build a bpmn software and I found a possible problem.
The D3.js has any INTERNAL event associated to CTRL + Z ? Because, when I changed the html text from a div inside one foreign object and I TYPED ctrl + z my function don't works. When I changed the event for ctrl + b for example my function works. This means the D3 is making something in this scenario..

This happen only in CHROME.

D3 has no internal event handlers of any kind. And, even if you register you own event listeners for ⌃Z, D3 wouldn’t do anything with that event other than pass it along to your listener. So anything wonkey happening during ⌃Z would either be due to browser functionality or something in your code. Sorry!


Installing and Importing lua libraries

Hay @Olical, sorry if this is extremely simple question.
I'm trying to install a cool lib called lua fun, and I'd like to use it to develop my plugin, any suggestions?
Also, is it possible to use lib fun without prefix?
Thanks 🙏

You don't need to use the prefixing / embedding script at all, I just use it as standard but it's not essential. It is really quite a bit hack so I get people not wanting to use it.
You can just put the Lua file in your lua/ directory and then require it as you would any other module. You'll just need to write a script or something that fetches the lua file and puts it in your lua directory.

You don't need to use the prefixing / embedding script at all, I just use it as standard but it's not essential. It is really quite a bit hack so I get people not wanting to use it.

Oh I believe you misunderstood what I meant. By without prefix, I meant using for example, join with out str.join. Speaking of / prefix, this is something I do miss from clojure, and it feels a bit wired using .. Wish if there's a way to use / for prefix to have a constant experience with clj dev.

You can just put the Lua file in your lua/ directory and then require it as you would any other module. You'll just need to write a script or something that fetches the lua file and puts it in your lua directory.

Nice, very easy todo, thank you

Oh I'm sorry! So you meant import everything from aniseed.string into your current context. I don't think there's a way to do that in Lua at all, but I would strongly recommend against it, also as a Clojure lover / user, :refer-all is always a nightmare for me when I'm maintaining old code myself or someone else wrote. Munging things together may be convenient for today but tomorrow's you will regret it, in my opinion.
And yeah, / to access modules could be really nice, I guess it'd require some really magic macro stuff or changes to the Fennel compiler? I don't think there's a way to do it right now at all :thinking: would be neat though, I just got used to . in Fennel I guess because I think of the Lua semantics underneath.


Don't mark field as changed on reverseTransform

When reverseTransform is done the UOW does not need to be triggered that a change occured because the value after transforming is still the same in the database as before. Only an actual change of the field should trigger transform to be executed again.

Just did an update which keeps track of changes between original and transformed value. Whenever the original versions still match the transformed value is restored without performing a new transformation.


🐛  Fix score calculation for multiple files

Token permission check does not handle multiple files for score calculation, due to the fact that all workflows shared the same permission map. This is because the check used to only look for undefined top-level permissions, globally. Now we've switched to looking for both run-level and top-level permissions. We want to only flag when some files don't declare both of them; or if only the run-level permissions are declared.
closes https://github.com/ossf/scorecard/issues/1400

error
make: *** [Makefile:137: build-scorecard] Terminated
Error: Timeout of 30000ms hit

seems to be happening for all PRs now
cc @naveensrinivasan @azeemsgoogle


[Add a Play]: AirBnb Experiences clone

What's the Play about?
This project is the clone of the AirBnb Experiences page.
What ReactJS concept will be used to create this play?
Components, Props, Creating components from an array of data
Record

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I want to work on this issue
[X] I am in Hacktoberfest

Code of Conduct

[X] I agree to follow this project's Code of Conduct

👍


Polymer 2.0 and IOS 10 Safary

Hi.
The sound does not play when the button is pressed.
On android and PC Chrome everything works well

Hi, @FynjyAC. Please provide more info.
If you will go to demo page on iPhone, you will see that it is works

Hi. All works fine. It was a problem on hosting


Frontend support for delegation and rejection

What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?

If an agent rejects a task, the web GUI would "crash" because we don't support it on frontend yet
Agent delegation always shows a weird empty box when it finishes, because frontend doesn't handle agent delegate observation

Give a brief summary of what the PR does, explaining any non-trivial design decisions

Add support for rejection action on frontend
Show users the reason for rejection
Get rid of weird empty box after delegation

Other references
Demo (this PR, using ManagerAgent, with some prompt tweaks, which will be in a separate PR):
Delegate & Rejection

Delegate & Success

You might see some messages are seemingly redundant and not very user-friendly. This is left for https://github.com/OpenDevin/OpenDevin/issues/2309 and we may need some UI redesign. This PR makes it at least work end-to-end.

Asking CodeActAgent to use Google search to find out the current president of USA:

The first weird All done! What's next on the agenda? message is due to delegated BrowsingAgent finishing its task. Seems weird at the moment. We should collapse delegate agent's activities as suggested here: https://github.com/OpenDevin/OpenDevin/issues/2309#issuecomment-2154312838

The message with JSON in the last screenshot is the delegate observation, right? I think we can tweak its message property to display user-friendly text instead of JSON, so that it displays more naturally in the chat box.
I'm not sure exactly how, it seems it can respond with different dict keys, and currently, that property is `` by default... but maybe we can find a way to make it into a phrase that includes the relevant key values when they exist?

I'm not sure exactly, it seems it can respond with different dict keys

You are right! It could be anything. Every micro-agent, for example, has its own schema defined in agent.yaml.
Why don't we simply make every agent return a natural language output as CodeActAgent? The reason is, some agents (especially micro-agents) are designed to do a very narrow task, and they may or may not want to answer in natural language. A SQL agent, for (imaginary) example, could return SQL execution results in any pre-defined format.
What we should do here is unclear to me. I don't know how we could design delegation better and more elegant.

Oh, I see, I was actually thinking we might be able to retrieve this info a little better... like, from the agent who should know best what it's doing or at least from the parent who asked for something, one would think it can read a response...in some way we can use, but no... not quite. 😅
Okay, there is someone who knows our answer, but that someone is not in our code, it's... the LLM. 😅
Then I suppose the fallback option is the LLM, right: a summary sentence. I thought delegate summaries made a lot of sense and save tokens and confusion, but it seems to me that they're simply necessary here. It would tell us what the delegate concluded or how it concluded.
For this PR, what do you think about something like:
Delegate agent finishes task with content: Based on search results, the current president of the USA is Joe Biden.
Delegate agent finishes task with answer: 0.62....
Delegate agent finishes task with reason: Not a valid git repository....
In other words, I'm wondering if the best we can do for now is just the absence of too obvious formatting, since it's not a code block...

Then I suppose the fallback option is the LLM, right: a summary sentence. I thought delegate summaries made a lot of sense and save tokens and confusion, but it seems to me that they're simply necessary here. It would tell us what the delegate concluded or how it concluded.

Exactly. Your work would be very important here.

@enyst  Applied your suggestion. Looks better now, thanks!

in the image, I'd find it confusing, why suddenly a "Delegate agent..." is mentioned, without first seeing something like "Task has been delegated..." in chat?
Just as an observation.

Let me rephrase my observation:
from a user perspective, the 2nd and 3rd agent messages are not relevant/confusing.
Even though they may be technically needed/wanted in the backend.

Let me rephrase my observation: from a user perspective, the 2nd and 3rd agent messages are not relevant/confusing. Even though they may be technically needed/wanted in the backend.

The 1st agent message will be auto-collapsed after #2309
The 2nd agent message is a summary of what has been done by sub-agent
The 3rd agent message is specific to rejection (not really delegate-related). The "the agent" here refers to the current agent (at that time), which is the top-most agent.

Let me rephrase my observation: from a user perspective, the 2nd and 3rd agent messages are not relevant/confusing. Even though they may be technically needed/wanted in the backend.

The 1st agent message will be auto-collapsed after #2309
The 2nd agent message is a summary of what has been done by sub-agent
The 3rd agent message is specific to rejection (not really delegate-related). The "the agent" here refers to the current agent (at that time), which is the top-most agent.

Right. That is all transparent and obvious to you, that it is a sub agent.
It's probably just me, but with my "user hat" on, I don't have a need to know, other than the result, i.e rejection happened for a reason.
But I'll leave it be now, please continue. 😁

without first seeing something like "Task has been delegated..." in chat?

That's a good point. I'll add support for that.

I have to admit the UX for delegates & rejection are independently awful 😆

@tobitege Applied your suggestion

without first seeing something like "Task has been delegated..." in chat?

We still have some low-hanging fruits that can improve UX by a bit: e.g. don't say "delegate" agent, say what exactly agent it is.
i.e.

I am asking CommitWriterAgent to...

sounds better than

I am asking Delegate Agent to...

Similarly, we shouldn't say

Task is rejected by the agent

we should say

Task is rejected by CommitWriterAgent

I'd leave it as good first issue.


Add links to books on bookshelf

Hello, just stumbled across your site and was interested in the bookshelf page. Some of the books there look good for me, but I noticed that there are no links to the books on the page. I could just google the title but I'd rather waste a few minutes writing an issue 👍

Hello, thanks for bringing this up. It was an intended decision to avoid referencing book links since everyone has their own preferred bookstores.


Add support for autograd

Autograd is really nice -- and right now there is not good way of calculating gradients for our singular linear model. It would be great to start adding in a generic framework to handle this.

I'd love to give this a shot! Are you looking to have a home-brew solution or a framework from somewhere else?

I'd love to give this a shot! Are you looking to have a home-brew solution or a framework from somewhere else?

@aidenfoxivey looking to do as much from scratch as possible -- I think that all this will need is a good API and an implementation of the chain rule. That's all it would need to start, at least. However, I think that issue #2 is probably higher priority to get right before moving to this hard stuff.
Reason being, I don't have a great starting point to build Autograd on top of. I think we need more primitives.
I guess it is also worth diving into the literature on this and see what people have done in torch, tensorflow, JAX etc. to take inspiration from :)

I'm looking to get more work done on this task this week!

@aidenfoxivey making progress on the autograd the latest ideas are in #23 -- but it is still horribly messy. I think that maybe a good line of development is to start making more failing tests so that we can add very specific features.
Another issue that came up is I need some good way of making scalar only Tensors. So far I just made an alias, but there must be a better way.


Investigate Travis CI Windows support

See the announcement of the Early Release: https://blog.travis-ci.com/2018-10-11-windows-early-release
Travis now allows to run the same build on multiple operating systems, possibly allowing us to purely rely on it, instead of running Travis and AppVeyor side-by-side.
See #1241 for trying out the multi-OS support.

https://docs.travis-ci.com/user/reference/windows/#supported-languages
There is currently no support for java, although the JDK should be installed by default. However builds currently immediately fail with:
The language 'java' is currently unsupported on the Windows Build Environment.
Once Java support is added we can re-open #1241 to run a build.

The drawback with this one is that the CI needs longer to finish for every PR.
Currently, Windows and Linux builds run concurrently which shortens the feedback cycle.
In the last few months, AppVeyor hasn't been flaky at all.
So, I don't see the benefit of introducing this feature.
What do you think? @arturbosch

But we also run tavis for java8 and 10. So two jobs, one 18 min other 20min. Haven't observed if they run in parallel or after each other.
@schalkms yep Appveyor runs okay for months ^^

I'd favor to close this then and not invest any more time in it.

If AppVeyor triggers new problems, we should reopen this issue.
For now, staying with AppVeyor is fine. Thus, I'm closing this issue.


hashes: Rename length field and use u64

The hash engine types have a length field that is used to cache the number of bytes hashed so far, as such it is an arbitrary number and could use a u64 instead of usize.
While we are at it rename length to bytes_hashed to remove any ambiguity of what this field is. Note this field is private, we already have the public getter n_bytes_hashes to get the value.
Introduce a private function incomplete_block_size, the purpose of this function is to put all the casts in one place so they can be well documented and easily understood.
Fix: #3016

Strong concept ACK. This is a pretty nice way to encapsulate exactly the location where casting is both safe and common.

Thanks, I was pretty happy when this dropped out of my brain late in a long day. Will re-spin.

That diff is so hot right now.

In 6cc3a07458bb25232e3884695ac7a83171be3389
Why are we using a macro for something that a generic function would deal with? I would even prefer the original trait-based thing to this.

I'm not sure what you mean by using a generic function, its early right now, perhaps I'm still half asleep, but anyways I removed the macro and duplicated the code. FTR I didn't do it like this originally because I thought the benefit of having all the casting in exactly one place outweighed the usual caveat that macors are harder to read and maintain.

Can you write
fn incomplete_block_len<H: HashEngine>(eng: &H) -> usize {
    (eng.n_bytes_hashed % blocksize) as usize // or whatever
}

Ugh, I was thinking BLOCK_SIZE was only a private const, I forgot its an associated const as well.

Will re-spin

Ugh, I was thinking BLOCK_SIZE was only a private const, I forgot its an associated const as well.

Then the trait-based solution wouldn't have worked either.

A little surprised the script didn't notice the obvious API break of changing a trait method from returning a usize to returning a u64.
In any case, this PR is great. A definite correctness improvement (though perhaps not for typical sizes of hashed data :)) and avoids peppering the codebase with questionable casts.

Can this one go in? Its been ack'ed for 2 weeks and the review issue from @Kixunil has been removed.

I think this broke our CI because it doesn't rename the fields during fuzzing.
I suspect that locally I don't have tests to set the hashes_fuzz cfg flag (but I'll try to figure out how to do this). Not sure why the real CI wasn't complaining. It is on master, and may have been for the last two weeks, but I think I missed it in the sea of red Xs from other projects due to clippy breakage.


Ensure tmp files get removed.

Prior to this change any exception would prevent the temp files being removed. This fixes that and should temporarily stop breakages that arise when a container's drive gets full.
The best long term solution is to stop storing AuditData in our database and store it somewhere better suited to unbounded data-sets, like DynamoDB or Firestore.
1
The second best solution is to increase the disk size of the ec2 instances hosting the containers.

Merge to wrong branch. Closing.


[Feature/SPM]: Support spanmetrics connector

Requirement
As a jaeger operator, I want to use the newly introduced spanmetrics connector for the following reasons:

Introduces a number of improvements to the spanmetrics processor.
The spanmetrics processor is deprecated and so future enhancements will no longer be added to the processor.
Avoid being in a situation where the spanmetrics processor is decommissioned preventing me from upgrading my OTEL collector version.

Problem
The known breaking issues include:

Renaming the calls_total metric to calls [1], while also allowing for a namespace prefix [2], so a metric name could resemble: my_namespace_calls.

[1]: https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/18677
[2]: https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/18697

Renaming the latency metric to duration [3], while also allowing for a namespace prefix [4], so a metric name could resemble: my_namespace_duration_bucket.

[3]: https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/19371
[4]:  https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/18697

Proposal
Make the metric names configurable.
Perhaps introduce an spm parameter namespace where metric names can be configured. e.g. --spm.calls-metric-name and --spm.latency-metric-name.
Other suggestions welcome.
Open questions
No response

I want to use the spanmetrics connector too.

I have a workaround based on metricstransform processor. Here an example of otel-collector-config.yaml:
receivers:
  otlp:
    protocols:
      grpc:
      http:

processors:
  batch:
  metricstransform/insert:
    transforms:
      - include: calls
        match_type: strict
        action: update
        new_name: calls_total
        operations:
        - action: update_label
          label: span.name
          new_label: operation
      - include: duration
        match_type: strict
        action: update
        new_name: latency
        operations:
          - action: update_label
            label: span.name
            new_label: operation

exporters:
  otlp:
    endpoint: "jaeger:4317"
    tls:
      insecure: true
  prometheus:
    endpoint: "otel-collector:9464"
    resource_to_telemetry_conversion:
      enabled: true
    enable_open_metrics: true

connectors:
  spanmetrics:
    histogram:
      explicit:
        buckets: [100us, 1ms, 2ms, 6ms, 10ms, 100ms, 250ms]
    dimensions:
      - name: http.method
        default: GET
      - name: http.status_code
    dimensions_cache_size: 1000
    aggregation_temporality: "AGGREGATION_TEMPORALITY_CUMULATIVE"

service:
  pipelines:
    traces:
      receivers: [otlp]
      processors: [batch]
      exporters: [otlp, spanmetrics]
    metrics:
      receivers: [otlp, spanmetrics]
      processors: [metricstransform/insert]
      exporters: [prometheus]

This worked well for me however something is not entirely right. I have a demo application with 5 services talking to each other. All 4 of them has data under Monitor but one of them does not have data. One application out of 4 is very similar to this one that is not working which puzzled me.
Maybe something about the name of the span? Any tips on how to debug it?

I have a workaround based on metricstransform processor. Here an example of otel-collector-config.yaml:

receivers:

otlp:

protocols:

  grpc:

  http:

processors:

batch:

metricstransform/insert:

transforms:

  - include: calls

    match_type: strict

    action: update

    new_name: calls_total

    operations:

    - action: update_label

      label: span.name

      new_label: operation

  - include: duration

    match_type: strict

    action: update

    new_name: latency

    operations:

      - action: update_label

        label: span.name

        new_label: operation

exporters:

otlp:

endpoint: "jaeger:4317"

tls:

  insecure: true

prometheus:

endpoint: "otel-collector:9464"

resource_to_telemetry_conversion:

  enabled: true

enable_open_metrics: true

connectors:

spanmetrics:

histogram:

  explicit:

    buckets: [100us, 1ms, 2ms, 6ms, 10ms, 100ms, 250ms]

dimensions:

  - name: http.method

    default: GET

  - name: http.status_code

dimensions_cache_size: 1000

aggregation_temporality: "AGGREGATION_TEMPORALITY_CUMULATIVE"

service:

pipelines:

traces:

  receivers: [otlp]

  processors: [batch]

  exporters: [otlp, spanmetrics]

metrics:

  receivers: [otlp, spanmetrics]

  processors: [metricstransform/insert]

  exporters: [prometheus]

This worked well for me however something is not entirely right. I have a demo application with 5 services talking to each other. All 4 of them has data under Monitor but one of them does not have data. One application out of 4 is very similar to this one that is not working which puzzled me.
Maybe something about the name of the span? Any tips on how to debug it?

Several possible issues and solutions that comes to my mind:

Spanmetrics namespaces - check if there are any
Rejected/lost/dropped spans - check otel-collector own metrics, maybe you have some configuration or connectivity issues
Check your app exporter - substitute otel exporter with console exporter so as to be sure that you have expected spans
See debug logs - https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/troubleshooting.md

Thanks! The problem was due to the application missing http semantic conventions. Otherwise your workaround works like a charm.


Hi

Hello
Is the referenced roadmap regarding new regions publicly available anywhere?
Specifically interested in ETA on availability in Norway and Sweden.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f3da2148-af4d-1394-b46d-e5513443c9eb
Version Independent ID: b09e715d-a3f7-b984-76c3-d5bc7d18f743
Content: Install Palo Alto Networks Cloud NGFW in a Virtual WAN hub - Azure Virtual WAN
Content Source: articles/virtual-wan/how-to-palo-alto-cloud-ngfw.md
Service: virtual-wan
GitHub Login: @wtnlee
Microsoft Alias: wellee

@StureA , thank you for your question. We'll review this and get back to you shortly!

Please reach out to @.*** for region roadmap.
The Palo Alto team owns the region build out prioritization
Get Outlook for iOShttps://aka.ms/o0ukef

From: StureA @.>
Sent: Tuesday, September 26, 2023 1:36:16 PM
To: MicrosoftDocs/azure-docs @.>
Cc: Mention @.***>
Subject: [MicrosoftDocs/azure-docs] Hi (Issue #115194)
Hello
Is the referenced roadmap regarding new regions publicly available anywhere?
Specifically interested in ETA on availability in Norway and Sweden.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f3da2148-af4d-1394-b46d-e5513443c9eb
Version Independent ID: b09e715d-a3f7-b984-76c3-d5bc7d18f743
Content: Install Palo Alto Networks Cloud NGFW in a Virtual WAN hub - Azure Virtual WANhttps://learn.microsoft.com/en-us/azure/virtual-wan/how-to-palo-alto-cloud-ngfw
Content Source: articles/virtual-wan/how-to-palo-alto-cloud-ngfw.mdhttps://github.com/MicrosoftDocs/azure-docs/blob/main/articles/virtual-wan/how-to-palo-alto-cloud-ngfw.md
Service: virtual-wan
GitHub Login: @wtnleehttps://github.com/wtnlee
Microsoft Alias: wellee

—
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/azure-docs/issues/115194 or unsubscribehttps://github.com/notifications/unsubscribe-auth/AH3KDZ2EP2VCOAPQ37BZHJTX4K43DBFKMF2HI4TJMJ2XIZLTSWBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJLJONZXKZNENZQW2ZNLORUHEZLBMRPXI6LQMWBKK5TBNR2WLKJZHE2TCMRSGAYDPJDOMFWWLKLIMFZV63DBMJSWZAVFOZQWY5LFVIYTIMBUHA4TKNJWGCSG4YLNMWUWQYLTL5WGCYTFNSBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTLDTOVRGUZLDORPXI6LQMWSUS43TOVS2M5DPOBUWG44UQKSHI6LQMWVHEZLQN5ZWS5DPOJ42K5TBNR2WLKBXGI3DQNJQGI3IFJDUPFYGLJLJONZXKZNFOZQWY5LFVIYTSMJTGMYTINZRGGBKI5DZOBS2K3DBMJSWZJLWMFWHKZNJHE4TKMJSGIYDAN4CUR2HS4DFUVWGCYTFNSSXMYLMOVS2UMJUGA2DQOJVGU3DBJ3UOJUWOZ3FOKTGG4TFMF2GK.
You are receiving this email because you were mentioned.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@StureA , We have assigned this issue to the respective product owner for assistance.
@wtnlee , the email ID you provided is masked. Could you please share it again?

Hi! The email was blurred by GitHub. You need to reach out to<EMAIL_ADDRESS>

#please-close


Support Import and Export of RLN Credentials

See https://github.com/waku-org/nwaku/issues/1278#issuecomment-1423319660
Cc @s1fr0

Let's align on the outcome of this issue and particular API to be implemented.

Support the import of export of ZK credentials in RLN js as implemented in https://github.com/waku-org/nwaku/pull/1285
Do note that I think we may want to split the current rln-js example in two:

uses wallet signature
Uses this (and possibly deprecated old import)

Resolving with Keystore supporting export functionality.
https://github.com/waku-org/js-rln/pull/70


Automated update deps action is broken

Per my comment on Slack:
https://cloud-native.slack.com/archives/C04LY4Y3EHF/p1690493604522879?thread_ts=1690468783.558009&cid=C04LY4Y3EHF
There's a race condition issue with execution of update-deps.sh and update-codegen.sh in this order. That's done in knobot's update deps for example. Due to the fact that update-codegen.sh is calling update-deps.sh without any flags at the end, it negates all the changes, because different version values are used etc.
Update: the broken part is git submodule update, that is being reset by the order of actions performed.
Knobot's action:
https://github.com/knative-sandbox/knobots/blob/3ab3f877f1440449a1d3e26e85052f2cefda1c01/actions/update-deps/entrypoint.sh#L54-L65
Codegen script:
https://github.com/knative-sandbox/eventing-istio/blob/bfed9ec22c1b25b4d4a679dc27664f3e426c48e5/hack/update-codegen.sh#L68-L69
/cc @pierDipi @creydr

Eventing does the same: https://github.com/knative/eventing/blob/ffa591593417f3e879a4834ddb87cc13e6cd3e05/hack/update-codegen.sh#L71-L72

serving as well: https://github.com/knative/serving/blob/0a3f5f96a8a599e1c060eb978590dc7a350292f4/hack/update-codegen.sh#L103-L104

IMO the issue is specifically in git submodules update. Because without executing fetch function the git submodule --init --recursive will reset the changes pulled by update-deps.sh script, i.e. diff is clean without additional changes.

Here's example of submodule being updated: https://github.com/knative-sandbox/knobots/actions/runs/5684668902/job/15407902127#step:6:234
But later when codegen is executed, the older version checked out again: https://github.com/knative-sandbox/knobots/actions/runs/5684668902/job/15407902127#step:6:3617
It's a side effect of no git fetch being performed and git submodule --init --recursive resetting the update.

I see, I'm not sure if we can simply remove  git submodule --init --recursive


Finding Functional Tests

Implemented the following test suites:

[x] Add Finding
[x] Edit Finding
[x] Import scan results
[x] Add Images to finding
[x] Delete Image from finding
[x] Mark Finding for review
[x] Clear Review from finding
[x] Make template from a finding
[x] Apply template to a finding
[x] Close Finding
[x] Delete Finding
[x] Delete Findnig Template

Fix issue #1204
Please submit your pull requests to the 'dev' branch.

When submitting a pull request, please make sure you have completed the following checklist:

[x] Your code is flake8 compliant (DefectDojo's code isn't currently flake8 compliant, but we're trying to correct that.)
[x] Add applicable tests to the unit tests.

@devEricA  please test and review this PR.

When running these tests, a permissions error appears when attempting to add an image to the finding. The directory in question does not have permission to accommodate the new image. This is a container issue and will be investigated. Until then, this will have to hangout a bit.


[BUG] - Responsive Sidebar Vertical Scroll Bar Issues

NextUI Version
2.6.8
Describe the bug
The vertical scroll bar inside the side bar component (NextUi Pro version) never shows up even though the width of the sidebar separator seems to be the width when a scroll bar is present?
I renamed some of the files from the sidebar component Sidebar.tsx -> NextUiSidebar.tsx, SidebarDrawer.tsx -> NextUiSidebarDrawer.tsx -> App.tsx -> Sidebar.tsx
I noticed that I can get the wide scroll bar to go away if I remove the overflow-y-scroll on line 100 in NextUiSidebarDrawer.tsx but this still doesn't actually scroll when the content overflows like desired.
Your Example Website or App
https://github.com/SeeRich/web-template
Steps to Reproduce the Bug or Issue
npm install --legacy-peer-deps
npm run dev

Expected behavior
I would expect the width of the sidebar component separator to be much smaller when not actually scrolling. Also, when the content overflows, there should actually be a scroll bar.
Screenshots or Videos
Appologize for the terrible quality, still can't figure out screen recording...
https://github.com/user-attachments/assets/a506f9ad-30d4-44c0-8ae2-9cde8daaadb0
Operating System Version
macOS
Browser
Chrome

For nextui-pro issue, please discuss in NextUI Pro channel (ping me in discord if you don't have the access) and don't create a public repo. You can set it private and invite our team member to investigate.


Cannot enable PIP with custom controls

Current Behavior
I'm working with vimeo videos and a custom control bar that I've made, so my props at  are:
<ReactPlayer ref={player} pip={true} controls={false} config={{ vimeo: { playerOptions: { quality, responsive: true, pip: true } } }} ...rest of props />
If I change de controls prop to controls={true} and do not render my custom props, the PIP icon appears and it works well:

But If I use my custom controls and disable the vimeo ones, when I press the PIP button it gives me this error on console:

My onClick code is:
const handleOnEnterPIP = async () => {
    // Player is set at <ReactPlayer ref={player} ... />
    let video = player.current.getInternalPlayer();

    if (document.pictureInPictureEnabled) {
      try {
        video.requestPictureInPicture();
      } catch (error) {
        console.log('❌ Error', { error });
      }
    } else {
      console.log('Your browser cannot use picture-in-picture right now');
    }
};

Expected Behavior
I want to now how to avoid this exception when I press my custom PIP control.

Any update on this? 😕


Translate StopStalk strings to Bengali

Request access to this document if you are interested in helping with the translations - https://docs.google.com/spreadsheets/d/1li1wB7qkKVRA8QN301tJuxCOBKPuiEUK-PyiI38Hslw/edit#gid=420381315

I would like to help with the Bengali translations. Requested access to the document.

Hey @raja-d : Approved your access.

Is bengali translation ready? rest is easy :smiley:

@dbads It's not ready yet

once translation is ready.. I'll do the rest of the things :+1:

I can help with translation if needed @raj454raj .


feat: bytebuferpoll use mcache replace

#1026

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.mac seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Please follow the template to fill the PR description.
Fix CIs.
Sign the CLA.

Please check that the changes are all ready for CR🙏

No update for too long, will be closed, reopen if necessary.


Custom web searches from PT Run

Description of the new feature / enhancement
I saw that we can use ?? to perform a web search from PT Run. It would be great if we could add custom website search types.
For example, you might type ?YT funny cats to search for funny cats on YouTube.
Scenario when this would be used?
When you want to find videos of funny cats. ;)
Supporting information
No response

Duplicate of #15032

Thanks for your suggestion! This issue is a duplicate.
I'm linking this issue to #15032 to centralize the discussion thread, please go to that thread for discussion.
Thanks for your help to make PowerToys a better piece of software!

@franky920920 , Perfect, thanks for that.

Thanks for your help to make PowerToys a better piece of software!
My absolute pleasure. :)


Issue with this hooks. Not able to use them.

check-column-name-contract: Check column name abides to contract.
check-model-name-contract: Check model name abides to contract.

Error Message:
pre-commit autoupdate
Updating https://github.com/offbi/pre-commit-dbt ... Cannot update because the update target is missing these hooks:
check-column-name-contract.

Seems to relate to #77 & #42.


Add support for color and vent enum constants

In the May 9th update, Rocketwerkz added enum constants for Color and Vent, for example, Color.Red and Vent.Inward. However, the add in shows these in red underlines. Thank you for creating this addin!

Please disregard, after a while the red underlines on the constants went away.


Cant retrieve exams -> Unauthorized access

Hi!
I tried to get the exams for a range by using getExamsForRange().
Unfortunately I get a 403.
Homework on the other hand is no problem with getHomeworks().
Is this some kind of school restriction? Is there another way of getting the exams?
Thanks!

Yes, might be a restriction by your school.


[coro_rpc] mark the paramater as const

Why
mark the paramater "path" of the function "file_exists" as const
Closes #373

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Removed intervals <15 minutes for abandoned carts

Codecov Report

Merging #115 (9f7a678) into master (df8f030) will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #115      +/-   ##
============================================
+ Coverage     26.97%   27.02%   +0.04%
  Complexity     2143     2143
============================================
  Files            76       76
  Lines          6851     6839      -12
============================================
  Hits           1848     1848
+ Misses         5003     4991      -12

Impacted Files
Coverage Δ

retailcrm/retailcrm.php
26.58% <ø> (+0.43%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df8f030...9f7a678. Read the comment docs.


unable to override Backbone.Firebase.Model#sync (and friends)

It is worth mentioning in the docs, if not actually fixing, that the smart technique used to define #sync (#save, and other data mangement methods) effectively breaks inheritance.
Well for now, I'm going to outsmart the library by assigning #sync in the overridden constructor...

There are two improvements the library could have. The first is being able to customize the Firebase reference before sync. The second is to be able to properly override the sync method. This is a bit tricky because it's different than your XHR model, but I expect these two issues will be tackled in the next big release.

The way it is implemented and used, I see no damage in converting the autoSync option into proper subclassing, e.g.: Backbone.Firebase.LiveModel extends Backbone.Firebase.Model. Then, sync should continue to be the entry point of saving data to the server (Firebase in our case).

I've been revisiting the architecture of this library and I agree.
I think autoSync seemed like a good approach initially. However, now I'm seeing that a traditional subclassing approach would be the most ideal.
Using autoSync also requires the prototype of the Collection/Model to be set dynamically. This can cause some confusion when debugging.
I plan on revisiting the architecture to allow for proper overriding of the sync method.

@davideast Thanks for you work. I hope I'll be able to help you (with a review at least) after a certain round of work on my projects. I plan to write a post on my hybrid (dual DB) approach which will actually benefit from the architectural changes you mentioned — and then, I will hopefully contribute here.

@davideast anything new on this front?


[Enhancement] Starrocks to support function SESSION_USER()

Why I'm doing:
What I'm doing:
Added support for new scalar function session_user()
when run sqlmap tool on Starrocks master it gave error like session_user() function not found. mysql support this function.
https://www.w3schools.com/sql/func_mysql_session_user.asp
Its similar to Starrocks user() function.
MySQL [(none)]> select session_user();
+--------------------+
| SESSION_USER()     |
+--------------------+
|<EMAIL_ADDRESS>|
+--------------------+
1 row in set (0.007 sec)
Fixes #50512
What type of PR is this:

[ ] BugFix
[ ] Feature
[X] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[X] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.3
[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

would be great to add test to cover the usage. And also do we need to enforce the notes from the link
Note: This function is equal to the [SYSTEM_USER()](https://www.w3schools.com/sql/func_mysql_system_user.asp) and the [USER()](https://www.w3schools.com/sql/func_mysql_user.asp) function.

would be great to add test to cover the usage. And also do we need to enforce the notes from the link
Note: This function is equal to the [SYSTEM_USER()](https://www.w3schools.com/sql/func_mysql_system_user.asp) and the [USER()](https://www.w3schools.com/sql/func_mysql_user.asp) function.

@kevincai updated. added test case.
this function is sort of an alias for user() function. so i feel its implicitly handled.


Add settings for automatic release of binaries

Update CI settings with the results of rust-playground.

Codecov Report
Base: 76.10% // Head: 76.10% // No change to project coverage :thumbsup:

Coverage data is based on head (007f4c0) compared to base (de1fa77).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #104   +/-   ##
=======================================
  Coverage   76.10%   76.10%
=======================================
  Files          15       15
  Lines        1285     1285
=======================================
  Hits          978      978
  Misses        307      307

Flag
Coverage Δ

unittests
76.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


CLOUDSTACK-10364: Change the "setXXX" method names to "getXXX".

The two methods are named as "setXXX",
actually, they are not setter but getter.
Thus, they should be renamed as "getXXX".

@DaanHoogland you comment about get have been addressed, the author has used a generate method name prefix that sounds acceptable (generating a name from params).
This is a pure method name change, build and Travis have passed. I'll merge this based on these tests and reviews.


Add tape test framework

Refers to #4.
Still need to work on a few points:

[x] Really check if we will keep the test/unit folder structure rather than src/js/tests. If we keep this structure we must import the modules as ../../
[x] Add proper ES6 coverage
[x] Add test watch script
[x] Add travis integration
[x] Make tap-notify work (right now throws an error, was having the same issue with ava)

We can merge this and check back each item later on.

#7 Will handle provided points now.


Subdirs in S3 storage is always same

Subdirs in S3 storage is always same. (first 4 chars of url is always http)
        hex_name = codecs.encode(url.encode('utf-8'), 'hex').decode('utf-8')
        sub_dir = os.path.join(hex_name[:2], hex_name[2:4])

Maybe make hash of URL or take URI instead of URL?

Thank you for reporting this, would you like to fix it?

Okay, i'll try.


chore: Lake touchups

Better acclimates Lake to the Lean 4 repo and applies other quick fixes and tweaks.

@Kha Question: In general, should I squash a set of Lake commits into single monolith, or it fine to rebase and merge them as is to keep commits more focused?

This kind of history looks perfectly fine to me, I don't see a reason to squash it

Ah, something that came to my mind too late: I do make use of prefixes like server:  for changes specific to a (large) subcomponent if the component is not otherwise apparent from the message

@Kha Good point! I will make sure to add a lake:  prefix to such commits in the future. Unfortunately, in addition to these all the old merged-in Lake commits also have no prefix and thus could be a bit confusing as well. On flip side, it does mean these don't stand out too much. 😆


Update scalafmt to 2.7.1

Codecov Report

Merging #433 into develop will decrease coverage by 0.09%.
The diff coverage is 58.82%.

@@             Coverage Diff             @@
##           develop     #433      +/-   ##
===========================================
- Coverage    77.25%   77.16%   -0.10%
===========================================
  Files           46       46
  Lines         1051     1051
  Branches        30       30
===========================================
- Hits           812      811       -1
- Misses         239      240       +1

Impacted Files
Coverage Δ

...r/bijection/twitter_util/JavaFutureConverter.scala
46.15% <22.22%> (ø)

.../main/scala/com/twitter/bijection/Bufferable.scala
90.80% <100.00%> (-1.15%)
:arrow_down:

...scala/com/twitter/bijection/InversionFailure.scala
100.00% <100.00%> (ø)

...ala/com/twitter/bijection/json/JsonInjection.scala
90.27% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d197ba5...6d0107d. Read the comment docs.


Reordering of User Guide's Table of Contents

Summary of changes
Reorganized the User Guide's Table of Contents
This mostly follows the scheme given here, with the following exceptions:

"Controlling files in the distribution" is kept not immediately after the "Package Discovery" page, but rather towards the end, because a lot of the material in that page overlaps with material given in the "Package Discovery" and "Data Files" pages. Therefore, it seems to me that this page should be read after the other two pages have been
read.
"Development Mode" is kept not towards the end but introduced close to the beginning, because readers might want to start using it early on in their projects.
"Building Extension Modules" is kept immediately after the "Entry Points" and "Data Files" pages, since it is the last major topic we would like to discuss. The two topics that follow ("Specifying your Project's Version" and "Controlling Files in the Distribution") are lighter topics that can be read later by users after they have been able to get a basic start with their projects.
Have retained the pages "Extending or Customizing Setuptools",  "Configuring Setuptools using setup.cfg files" and "Configuring Setuptools using pyproject.toml files" for now.

Have also removed the quotes around the heading of the page on Development Mode, it seems unnecessary.
Pull Request Checklist

[x] News fragment added in changelog.d/.
(See documentation for details)

Thank you very much @codeandfire for the reorganisation.
Do you believe this logic makes more sense? When I did the suggestion I was just trying to find a sequence that would make logic sense when guiding the user through learning. But I did not double check with the actual pages :rofl:
If you belive that is the way to go, I am happy to merge!

Well @abravalheri, the way I think about this reorganization is the sequence a person starting a new Python package would follow. Package Discovery and Dependencies Management would probably be the first in this sequence, since these two are essential to package any Python project. Next they should know about development mode / editable installs so that they can get started with development. The next three topics namely Entry Points, Data Files and Extension Modules are involved topics that may or may not be relevant to their specific project. Finally there are two minor topics namely Versioning and Controlling Files in the Distribution which cover some finer details of the packaging process.
I did not strictly follow your suggestion :) but I feel this is a reasonable way of ordering the pages.

Thanks @codeandfire. I think you put more thought on this than I did, so I am very happy with that!


[WINDOWS] MAke sure the warning reporting is building under windows a…

…s well!
Take care there is a hard link between selecting warning resporting as a library and the build flags for core in this sommit, the buildflag CORE_WARNING_REPORTING for core needs to be enabled if the warning reporting library is build (otherwise that build will fail!)

@VeithMetro at least it compiles :-) Did test it on windows but some other error occured on windows if you use the Warning Reporting, so it still requires more TLC for windows...


VLSV writer

Perhaps it would be useful to implement a VLSV writer as well. One use case is that the user can calculate some derived quantities from a VLSV file and then append the quantities to that flie. This may be helpful for VisIt users, since we already have a VisIt plugin VLSV reader.
There is already one VLSV writer in Analysator, so it wouldn't be too hard to have one.

One tiny issue is that the new variable names cannot be identical to the predefined ones in Vlasiator.jl, otherwise they cannot be read by readvariable since Vlasiator.jl treat them as derived quantities in the beginning.


Remove hot spots from client

Not sure if I need to remove them, for now, will just leave them there.


Fix parsing

addresses #64
depends on a PowerModels#moi-julia-v0.7 PR to fix the dclines parsing

it was coming in as:
julia> typeof(pv_dict["name"])
SubString{String}

We need to find a better way to do that, the conversion can make the translation from Dict -> Struct incredibly slow.

@claytonpbarrows Can you add a comment with the packages that you added using the development branches? So we can keep track of them and check when the new release comes out.


cleanup & update dependencies tree

Hello,
This PR cleans up and updates the dependencies tree for the columnq crate.
There are still two conflicts:

ConnectorX is still using arrow version 52. This can be resolved by merging this PR.
DeltaLake is still using datafusion 41.0. This will be resolved once they find a fix for this issue. The likely solution would be upgrading to datafusion 42.1 or skipping that version and using datafusion 43

Thanks for the update @hozan23 , for deltalake, you we can also create a temporary fork at https://github.com/roapi/delta-rs to unblock the upgrade. Let me know if you need any help with it.

Hello @houqp
I think they are currently working on releasing datafusion 42.1 and they will use it with deltalake. we can wait for a few days until they merge it.

An update:
The DataFusion 43 version has been released; we can continue with this PR once DeltaLake starts using DataFusion 43

@hozan23 do you need any help pushing this over the finish line?

@hozan23 I don't have access to push to your branch, so started a new branch based off yours to finish off the upgrade. Thanks again for the help!


Debugger doesn't work with Android apps when packager uses non-standard port

Issue Description
When using a non-standard port (e.g. on a machine where McAfee takes up port 8081), React Native Android apps can't be used with a debugger.
While the port can be configured for the app itself (using the debug_http_host shared preference), this seems to have no effect on the URL passed to the debugger when the app sends it the request to load the bundle.
This is briefly mentioned at the end of this react-native-webpack-server issue.
Steps to Reproduce / Code Snippets
Start any React Native app on an Android device, either physical or emulator, open the dev menu and choose "Debug JS Remotely".
A Chrome tab will open, pointed at a URL with the correct port for the debugger-ui, but will then throw errors indicating it tried to load index.android.bundle at port 8081 and, naturally, failed.

(This seems to be caused by DevServerHelper.java always returning the hard-coded AndroidInfoHelpers.DEVICE_LOCALHOST in getHostForJSProxy for the debugger, whereas the app itself uses getDebugServerHost, which does take preferences into account.)
Expected Results
The same port used by the app to load the package itself would also be used in the URL passed to the debugger, so that the debugger could successfully get the bundle from the packager.
Additional Information

React Native version: 0.33.0
Platform(s) (iOS, Android, or both?): Android
Operating System (macOS, Linux, or Windows?): macOS

When using a non-standard port (e.g. on a machine where McAfee takes up port 8081)

You should try having McAfee use a different port as well. Anyways, on Android you have adb reverse tcp:8081 tcp:8081 line mentioned on https://facebook.github.io/react-native/docs/running-on-device-android.html
All you need to do is change 8081 to something else. You can already the packager with different ports, just point the devices's 8081 to the new port you choose to run your packager.
Also please ask this on Stackoverflow, not here.

@hey99xx Thanks for the response.
As for your first suggestion: Unfortunately I can't change the McAfee port, as it's set to 8081 for all machines in my company, and I'm told all of them (a few thousands) would need to change for this to work (not sure if that's actually true, but anyway it's beyond my power to make that change).
As for using adb reverse, I've tried that as well.
I started the packager on port 8085, and then tried both adb reverse tcp:8085 tcp:8085 and adb reverse tcp:8081 tcp:8085.
Neither helps, unfortunately, since it's not the app on the device having the issue, but the debugger. Seeing as the debugger, running on my own machine, doesn't go through adb (as far as I can tell), it doesn't help with my issue.
If there is some way to get the debugger to go through adb's socket forwarding, rather than just straight to localhost:8081 as the app instructs it to do, that'd be awesome, but I haven't been able to find one.
Finally, as for posting on Stack Overflow and not here, I was trying to follow the instructions provided when opening an issue here:
Seeing as this isn't a usage question, it seems Stack Overflow would not be appropriate.
I suppose this could be classified as a feature request, in which case it would belong on Product Pains. However, I figured since the app itself does take the shared preference into account when loading the bundle, and only neglects to do so when passing the URL to the debugger, this seems more like a bug.

When you say 'debugger', do you mean you use a virtual simulator on your computer to do your debugging. If that's the case, and adb reverse doesn't work for that, I understand your pain point. You can always give it a shot to Genymotion if the regular Android emulator is the issue.
If you're running on physical device but adb doesn't work with it, Im not sure what the issue would be. You can check it with adb devices, it should show a unique id for your device. It really differs from device to device to udnerstand why adb doesn't always work with a physical device. I had a device where I needed to enable USB teethering to get it to work. Please let me know if that's the issue.

@hey99xx I'll try to clarify the situation, based on my understanding of React Native debugging:
I'm OK running with either a physical device or an emulator, and have tried both.
Both of those options work, in the sense that adb recognizes them, the app runs successfully, etc.
Wherever I choose to run the app, the issue starts when I then want to attach a debugger to it.
This can be the regular React Native debugger which uses Chrome's dev tools, or Nuclide's debugger, or any other debugger that supports React Native, as far as I'm concerned .
Whichever one I choose, React Native debugging works in such a way that the debugger, running on a development machine, runs the JS code for the app, while connected to the physical/virtual device where all the native code runs.
For this to work, the React Native app has to provide a URL for the debugger, where the debugger can load the JS bundle.
The problem is that, as far as I can tell, the URL passed by the app (whether running on a physical device or an emulator) to the debugger (running on my machine) is hard-coded, and always points to localhost:8081 (see DevServerHelper.java, mentioned under "Steps to Reproduce").
Seeing as it is ultimately just my machine that tries loading that URL, and not a device/emulator, I don't believe adb can be of much help.
And, unfortunately, I have so far been unable to find any other tools that would allow me to manipulate ports, when it's just my machine accessing a localhost URL.
Of course, I'd think either way the proper solution is just passing the correct URL to the debugger in the first place, s.t. there'll be no need for socket manipulation at all.

Should be solved by #12095

Awesome! Many thanks @ivmarkov. :)


%Z formatting

Currenlty only shows the OFFSET instead of the zone name

Could you provide code, please.

Nevermind, closing the ticket, it seems %Z only works if the object is a Time object. when created as a DateTime both mri and rbx return same result. either case it really is a bug as the %Z option should relfect properly insted of as the raw offset value. However since this is a bug in MRI and RBX im closing it here and going to open a ticket against MRI


isAutoFocus documentation

I think some of the documentation is out of date.   if I set isAutoFocus to false, no focus is shown for the item that has focus (which I would expect), but because of this, the focusScale and focusDrawable don't display.     The only way I have gotten these to work is to have isAutoFocus set to true, and making shoure that the focusDrawable is just a drawable either a png, image, or a non Selector drawable.
If you want I can do a pull request to update the documentation.   I'll probably have one coming along to add the Directional Keys from a keyboard to what the view should respond to besides just the DPAD events.

yes, if set isAutoFocus to false, the focusScale and focusDrawable will not work(This is explained in the documentation)， isAutoFoucus set to false indicates that RecyclerView does not handle the focus, the focus is left to the child view to handle, so the zoom and focus frame should be handed to the child view. so my example：
https://github.com/henryblue/TvRecyclerView/blob/master/app/src/main/java/com/app/tvrecyclerview/maulCarouselActivity.java
the zoom is "FocusRelativeLayout" to handle.
My English is not good, maybe the document description is not clear

thank you very much


Fix render bug in config builder

Not really sure how to fix the infinite render loop so I just made this change for now: 783245204e99b140a00d5c8d5c8fc6fc27c01dc5
These imports should come from open-truss and not the demo-app: cca6a9f32fdfeae738423f8a35546753889b4fc3

Still one outstanding bug afaict related to signals:

App go boom 💥

I'm going to merge this but just want to note that 1 above may not be the correct fix (cc @kmcq) and that the error screenshots at the bottom of the OP are an ongoing issue. Those can be addressed in follow up PRs though. Shipping this PR will let me update the shadcn PR to apply styles to the config builder.


Prettier plugin for autoformatting

In the past I've used:

https://github.com/homer0/packages/tree/main/packages/public/prettier-plugin-jsdoc
https://github.com/hosseinmd/prettier-plugin-jsdoc

But neither have good support for TSDoc.
The primary features I am after in such a plugin are:

Auto-format code blocks. This is a massive time saver. It is not practical to do without (at scale).
Auto-format general lines. So I can just start writing text and get food line length enforcement.

And then sure all the other details like adjacent empty lines and so on.

I also believe ESLint plugin auto-fix will be a big part of the story. For example this should not require manual fixing:


Modification to works.ttl: adding clarification of relationship of works when one is an image

What is this PR trying to achieve?
Who is this change for?
This relates to the MIRO data, in which much of the descriptive metadata relates not to the digital image but to the thing of which it is an image: clarifying that CreatedDate will refer to the original and not the image itself.
Supersedes previous clumsy attempt to upload this file!
Have the following been considered/are they needed?

[ ] Tests?
[ ] Docs?
[ ] Spoken to the right people?

Hmm. Something funky is still going on with line endings to screw up the diff – let’s investigate on Monday.


First drag-n-drop of a file results in error (Safari)

Issue Summary
Using Safari, the very first drop of a file on a file upload drop zone results in an error due to the file not being passed through, subsequent drag-n-drops work ok.

Steps to Reproduce

Go to a a file upload screen (subscribers import and theme upload both confirmed so far)
Drag a file onto the drop zone
Note the error in the console (slightly different depending on the validation method of the file upload chosen in step 1 but always results from file being undefined)
Drag the file onto the drop zone again
Note the validation/upload worked ok

Technical details:

Browser/OS: Safari

Fixed with: https://github.com/TryGhost/Ghost-Admin/pull/288
This is due to safari not allowing double hyphens at the start of a class.

@kevinansfield Excuse me, I misreferenced the wrong issue in my PR. My PR (228) fixes issue #7221 and not this issue.
Although I could not reproduce this issue in Safari on my machine.

Oops, closed due to wrong issue reference, re-opening. Thanks for pointing it out @KennethAshley!

@kevinansfield No problem. Sorry about that! Ok on to fixing another issue ahaha 😁

@kevinansfield this seems to be resolved in Ghost 1.0? Cant reproduce

I can still see the issue in the theme uploader, it doesn't seem to be a problem anywhere we expect image uploads.


Split DummyBroker into DummyStreamer and PaperBroker

Currently the functionality of DummyBroker is a little confusing - when used as a streamer, it generates dummy data as its name implies, but when used as a broker, it paper trades. Now that brokers have the mode attribute, DummyBroker should be split into separate brokers as described in the title.
Also, the following name convention is suggested for brokers:

[Name] for classes that function as streamers && brokers
[Name]Streamer for classes that only work as streamers
[Name]Broker for classes that only work as brokers

How will we organize this? The dummy broker is based off the Robinhood broker which does both fetching data and buying and selling stocks. I don't think that the robinhood broker should be split and I though that each broker should follow its template..

E.g. if someone tries to use the Papertrader as a streamer it will give an error like "this broker only works as a brokerage, please use another broker or specify a streamer" I feel like we'll need this organization anyways since there are lot of apis out there that only work as a streamer like Polygon.IMO

So Robinhoodbroker stays the way it is. I'm also working on a yahoo broker which is a streamer only broker so that'll be a good example

See #74 for an example of a streamer-only broker class

I think we can do what I did for YahooStreamer, which is to just raise an Exception when an unsupported endpoint is called. We can also use the mode attribute to warn the user, for example when YahooStreamer is set as a broker.


The link is invalid when debugging in docker.

VS Code version
1.64.0-insider (user setup)
Extension version
v2022.0.1578295602-dev
OS type
Windows
OS version
Win10
Python distribution
python.org
Python version
3.9.9
Language server
Default
Expected behaviour
Debug in Docker successfully and can hit the breakpoint.
Actual behaviour
Invalid link shown

Steps to reproduce
1.Git clone https://github.com/qubitron/pydemo
2.Open Anaconda Prompt window
3.Cd pydemo
4.Run py -3 setup.py
5.Open "stackoverflow-flask" folder and open "app->main.py"
6.Set a breakpoint in line 6
7.Switch to "dockerized" branch

8.Change "DEBUG" configuration to "Python: Run in Docker"

9.Start to debug
Logs
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Thanks for the bug report, I tried to reproduce the issue, but I can't find any dockerized branch in the project, could you tell me if the error persists? Thank you

In today's build, Invalid still exist.

  Build Info

Build of Visual Studio Code - Insiders: 1.67.0-insider(user setup)
Build of python-insider: v2022.5.11051003
Build of jupyter-insider: v2022.4.1001071005
Build of pylance-insider: v2022.4.1
Build of jupyter Notebook Renderers: v1.0.6
Build of jupyter Keymap: v1.0.0

The link shown here comes from flask, we don't control this. In Dockerized cases, you would have to configure the debugger differently, in a remote-attach mode for it to work, and add a preLauncTask that starts the container.


all headers not found in response

I have a vagrant machine set up with an nginx frontend reverse proxying a service. Whenever i use superagent (from my host machine) to make a GET or POST request (through the nginx frontend), in the headers field I only see a Content-Type header. I cURLed the same URL and I get all the headers that I'm expecting.
Specifically, I'm trying to be able to set a cookie from the service, but I can't since the headers aren't coming through all the way. Any reason for this?

Without a failing example it could really be anything or nothing.

I wasn't really sure if pasting code or config would work, there was a lot of space where it could've been. But I just figured out that apparently cookies and those additional headers won't come in if I'm on a localhost domain, so there has to be at least 2 levels, a custom dns name like www.localhost or <IP_ADDRESS> will have to be used.
Thanks!


flutter start crashes when port 8181 is in use

Catch the error and log a warning.
Fixes #1050

@devoncarew @chinmaygarde

lgtm


Add Dartium to the path on package bots

Currently, although Dartium is installed on the package bots, the dartium executable doesn't seem to be on the path. Since there's no standard installation directory for Dartium, the test runner relies on path lookup to run it.

There are two possible ways to put dartium on the bots, and on the path.  All the other browsers have a single installation on the actual build slave, which is on the path, and which is used by all buildbot runs.
The current way dartium is downloaded by test.py when it runs with -r dartium, is that it is downloaded from the google storage bucket dartium-archive, which has the latest bleeding-edge dartium that was built.  I think this is not what we want, considering that we only use the latest dev branch release for the SDK.
So the two alternatives are to install a single dartium on the machine, outside the build directories, and put it on the path.  This is easy, but automatic updating of it is hard.
Otherwise, we want a copy of dartium in each build directory, which means about 50 copies of dartium on each machine.  Then we want a system for updating them to the latest dev channel build, the same way the sdk is downloaded.  But the sdk is downloaded fresh for each run, even if it hasn't changed, so we would want to avoid this for the dartium download.  Then we also need to put this download's directory (different for each buildbot run) into the environment, and make it available to later build steps.  This is much trickier.
So I propose installing dartium on the path of each bot, for now.  How often do you need dartium to be updated?

So I propose installing dartium on the path of each bot, for now. How often do you need dartium to be updated?

Although for the most part we don't need bleeding-edge features in Dartium, we are going to be doing more with the VM service protocol which may require us to run tests against a fairly recent version. Bleeding edge would be ideal, but we could make do with the latest dev release.

DBC: There are benefits of both dev and bleeding edge. Main downside of just pulling TOT bleeding edge builds (that are green) is that you get an unpredictable extra vertical. If a test is failing, you need to consider the possibility that there is something wrong/changed with dartium on bleeding edge. If you don't surface that information, people may be looking in the wrong spot for a failure for a long time.
So in short, if we use dartium bleeding edge we should make sure people get that information when a test is failing on dartium (this may be as simple as "PLEASE note that this is running on version X.Y.Z of dartium from bleeding edge, get the corresponding copy from https://storage.google.com/.... and put it in foo/bar/drt locally to reproduce)

Dartium no longer has an executable named dartium.exe or dartium.  The executable is named chrome.  So the strategy used in package:test to find it will not work.  Package:test also has other outdated code, about finding dartium in the editor checkout.  I think the whole strategy of package:test for finding dartium needs to be redone, perhaps with an environment variable to specify the path or the executable.
I did put the current dev channel dartium on the path of the Windows bot, with name dartium, so you can see how that works.  We can do this on the other platforms, without a problem, if that is what you want.

I think the whole strategy of package:test for finding dartium needs to be redone, perhaps with an environment variable to specify the path or the executable.

The current approach seems to be working well for users. In practice, no one actually uses the executable name chrome to refer to Dartium, because that would be confusing and potentially clobber use of actual Chrome. We certainly can't just look for chrome and assume it's Dartium.
Given that users need to explicitly specify where their Dartium executable is, creating a symlink or wrapper script called dartium is a good way of doing so. Unlike an environment variable, it's something that users are likely to have set up already (for example, Homebrew does it automatically) and it's useful for manual invocations as well as using the test runner.

Dartium will no longer be supported on 2.0. Closing.


SpongeBanBuilder should accept a ban without a reason

Creating a ban without a reason causes a precondition to fail
Ban.of(player.getProfile());

Results in
java.lang.IllegalStateException: Reason cannot be null!
	at com.google.common.base.Preconditions.checkState(Preconditions.java:176) ~[guava-17.0.jar:?]
	at org.spongepowered.common.ban.SpongeBanBuilder.build(SpongeBanBuilder.java:123) ~[SpongeBanBuilder.class:?]
	at org.spongepowered.api.util.ban.Ban.of(Ban.java:61) ~[Ban.class:?]

Using dev version on commit 9dc74b3693f19f10eb4e841f3723da0dd38d80ca

SpongeBanBuilder#reason : Optional<Text> is not initialized.
The line
 private Optional<Text> reason;

should be changed to
 private Optional<Text> reason = Optional.empty();