name 'random_string' is not defined

File "demo.py", line 161, in
os.rename(i, too_small + "/too small-" + str(counter) + random_string(15) + ".jpg")
NameError: name 'random_string' is not defined
What could be the problem here? What is -i?

Have you run the script to the point where it placed jpgs into your 1_output folder?
Are there photos in that folder?

I'm not sure what the problem is because 'random_string' is defined on line 91.
But you're getting 'NameError: name 'random_string' is not defined'

Okay, could you explain what is -h?

I don't know what '-h' is. Where are you seeing '-h'?
Do this in your terminal. Go into python3...
$python 3
import random
import string

def random_string(length):
    return ''.join(random.choice(string.ascii_letters) for m in range(length))

print (random_string(10))

Enter each line into the python terminal. Make sure to indent the 'return ".join(ra.... ' line.
what's that do?
Does it print 10 random letters or give an error?

It gives me 10 letters.

I'm not sure what the problem could be because the script defines 'random_string'.
Are your videos .mp4s?

Seems like just putting one video made it work. Might be an issue handling several large mp4s?

"Seems like" like you're getting it to work with one video?
I have a dir of 66, 1080p mp4s and it rips through them.

Running the script seems a bit slow, not "ripping through" like you say. It's checking about 2 frames per second. Could this mean I installed the dlib wrong? It should be using the GPU, right?

Glad to hear it's working.
Do you have an nvidia GPU? A serious GPU you bought seperate and not a basic GPU that came with the computer?
If so type
nvidia-smi
in the command terminal when the script is running.
It should display that python is using lots of GPU memory.
If you have a heavy duty GPU you bought you can probably run the dlib install instructions in the readme without trying to uninstall anything and that should get your GPU running.
I have a 1080ti and it takes a few minutes to pull 500 found faces from a video. Maybe "rip" isn't the operative adjective but much faster and easier than doing it yourself.
I plan on getting a Titan V soon if I don't hear of something better coming out.

I can't run this command. I'm on Windows 10, by the way. Task manager is showing that cpu is at 23% and gpu roughly 8%. It's a 1060.

It seems that it's hardly using the GPU at all. I'll look into the dlib again.

Yeah, you have the GPU power you are not, and def want to be using.
I haven't touched a PC in ten years so I don't know if the install is different than my install instructions for dlib I put in the readme.
Let me know if it works or if I should put a note to do something different for a PC.
I'm sure you will find support for getting dlib and face_recognition to utilize the GPU online. Most people have PCs.

@MotorCityCobra I'm getting the same issue as @shaded3d, but only using one video instead of a group of them didn't fix the problem for me.

The script created the correct directories, but there's no images in any of them.
Running your python trouble shooting script also successfully gives me 10 letters
All dependencies are installed and, as far as I can tell, working as they should be
I've tested face_recognition and didn't come across any issues
I don't have an Nvidia GPU, I'm using a 2015 iMac with on-board "Intel Iris Pro Graphics 6200 1536 MB" GPU

You're the third or fourth person to have this problem. I never hear back if anyone gets around it.
There's something wrong with the for loop on line 68.
It just dawned on me that it might be because I used 'i' in three different for loops.
I just changed them all to be unique in the repo if you want to grab the 'demo.py' file again.
If that doesn't work try replacing the for look on 68 with these two lines...
vid = True
while(vid):

@MotorCityCobra Pulling your edits didn't work unfortunately.
You want me to replace the entire loop with those two lines, or replace vid = random.choice(glob.glob(vid_dir + '*.mp4')) with vid = True and add while(vid): above print("Now looking at video: " + vid)?

Oh right, my bad.
I'm not getting the error any more which is good, but It seems to be stuck after
[ INFO:0] Initialize OpenCL runtime...
Using OpenCL: True.
Output directory: /example/Photo/pic_output.
Scanned videos will be moved to: /example/Photo/pic_scanned_vids.

It's been hanging there for ~5 minutes but I guess it could just be taking a while to load? Is there supposed to be a progress bar or something? There's nothing in my output folders yet, but it created the folders successfully

hmmm. You should be getting more on the screen than that.
It looks like the script has stopped near that same problem area on 67/68.
Your target image gets loaded right before that. Do you want to put...
print ("Target image loaded" + target_image)
under line 63 (on line 64) and tell me if it printed?

Now it's spitting this out:
Traceback (most recent call last):
  File "demo.py", line 64, in <module>
    print ("Target image loaded" + target_image)
TypeError: ufunc 'add' did not contain a loop with signature matching types dtype('<U19') dtype('<U19') dtype('<U19')

Try replacing
print ("Target image loaded" + target_image)
with
print ("Target image loaded" + str(target_image))

So close! It started loading images but it froze after a few lines:
[ INFO:0] Initialize OpenCL runtime...
Using OpenCL: True.
Output directory: /Users/lars.field/Documents/Development/deep/sets/Rachel Weisz/Photo/pic_output.
Scanned videos will be moved to: /Users/lars.field/Documents/Development/deep/sets/Rachel Weisz/Photo/pic_scanned_vids.
Target image loaded[[[222 228 216]
  [219 225 213]
  [209 215 203]
  ...
  [170 183 189]
  [167 180 186]
  [164 177 183]]

 [[180 185 178]
  [179 184 177]
  [172 177 170]
  ...
  [170 183 189]
  [168 181 187]
  [166 179 185]]

 [[152 158 156]
  [154 160 158]
  [150 156 154]
  ...
  [167 180 186]
  [166 179 185]
  [165 178 184]]

 ...

 [[ 54  55  59]
  [ 54  55  59]
  [ 54  55  59]
  ...
  [107 124 140]
  [107 124 140]
  [ 96 113 129]]

 [[ 54  55  59]
  [ 54  55  59]
  [ 55  56  60]
  ...
  [111 128 144]
  [109 126 142]
  [ 96 113 129]]

 [[ 54  55  59]
  [ 55  56  60]
  [ 56  57  61]
  ...
  [113 130 146]
  [110 127 143]
  [ 95 112 128]]]

Nothing appearing in the output folders either

Well, we can cross that part of the script off the list as not being the problem.
Are you using a virtual environment?
I know this will be time consuming but I'm pretty much stumped here.
If you are running this in a conda environment could you re-install all the dependencies in a virtualenv environment, or vice versa?
I'm just two years into programming, so no expert, but I've never seen a script have such a inexplicable problem with one part.

I wasn't using a virtual environment, but I'll give virtualenv a go. Might take a while :'(

This must be a problem with whatever version of python you're using and some package, right?
is it 3.6?
I don't see how python can just not read a while loop or for loop.

I've been using 2.7.1, should I have been using 3.6? :S

Yes. Try 3. Anything that you can install with pip install with
pip3 install some_package
and when you're finally ready to run the script again try running it with $python3, python3.4, python3.5, python3.6 until one, hopefully, works.

Did you try running it with,
$python3, python3.4, python3.5, python3.6
In the environment you were trying to run it in earlier?

Yep, but I was getting the same errors. I'll try 3 and report back

Tried it with python3. It's still printing the same thing out and then freezing, just with different numbers :(

@MotorCityCobra Have you heard from anyone who's managed to get the script working successfully? Trying to figure out if, besides yourself, it's working for some but not for others

Bummer
Haven't heard from anyone after having this problem, no.
I figured Stack Overflow might be able to help. I would ask them but I don't have the problem so can't debug. It scrapes just fine for me.
I got this script from this script.
Try the original.
https://github.com/Tyrannosaurus1234/GetFaces

@MotorCityCobra I posted a thread on stackexchange, if anything comes of it I'll let you know.
The original GetFaces script works fine for me, so I guess whatever's broken is in the faceripper9000 script.

@MotorCityCobra
Got a response
"Why do you define random_string(length) in the while loop???? Take it outside of the loop. As a side note, your try/except block is way broad."

I was just looking at that and came here to github to see if I, and/ or Teranisourus1234 did that.
I see that's how I had it in the repo.
So, did that fix it?

Nope, still just printing out arrays of numbers :(

I think we tried this already but can you put this above the while loop and the 'vid = True' on line 71?
vid = random.choice(glob.glob(vid_dir + '*.mp4'))
print("Now looking at video: " + vid)
So if you inserted this in the current demp.py on line 71 (not indented in or under anything) it should be after the random_string function and before the while loop and the vid = True lines.
What does this print out for you in the Terminal?

Closing.
Check that the script is grabbing random mp4s in your video dir by adding to the script if you have this problem.
vid = random.choice(glob.glob(vid_dir + '*.mp4'))
print (vid_dir)
print ("Now looking at video: " + vid)

Didn't mean to duck out, just got busy. Seems to have fixed this particular issue though :) Nice work 👍


tab with show-* causes the tab rendered as vertical column

When I use tab without show-*, the display of tab is flex. When I use tab with show-*, when it is shown, it has display: block instead of flex. This causes the tabs rendered as vertical menu with each tab title as one newline.

created pull requests #424 for scss and #425 for less


Update fails for 0.5.1 with failed command (non-zero code)

I don't know whether this repository is the right for Hass.io Access Point, as Home Assistant shows 0.5.1 as the current version but there are no matching releases or tags in this repository. But otherwise this seems to match, therefore I'll submit this issue here.
When I try to upgrade Hass.io Access Point from 0.4.8 to 0.5.1 I get the following error: Error updating Hass.io Access Point: The command '/bin/bash -o pipefail -c apk update && apk add --no-cache bash iw hostapd networkmanager networkmanager-cli net-tools sudo dnsmasq iptables && rm -rf /var/cache/apk/*' returned a non-zero code: 4
The complete system log shows following stack trace:

Click to expand
Logger: homeassistant.components.websocket_api.http.connection
Source: components/websocket_api/commands.py:239
integration: Home Assistant WebSocket API (documentation, issues)
First occurred: 10:39:45 AM (3 occurrences)
Last logged: 10:44:35 AM

[140357330160960] Error updating Hass.io Access Point: The command '/bin/bash -o pipefail -c apk update && apk add --no-cache bash iw hostapd networkmanager networkmanager-cli net-tools sudo dnsmasq iptables && rm -rf /var/cache/apk/*' returned a non-zero code: 4
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/hassio/update.py", line 167, in async_install
    await async_update_addon(self.hass, slug=self._addon_slug, backup=backup)
  File "/usr/src/homeassistant/homeassistant/components/hassio/handler.py", line 58, in _wrapper
    data = await funct(*argv, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/hassio/handler.py", line 135, in async_update_addon
    return await hassio.send_command(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/hassio/handler.py", line 592, in send_command
    raise HassioAPIError(error.get(ATTR_MESSAGE))
homeassistant.components.hassio.handler.HassioAPIError: The command '/bin/bash -o pipefail -c apk update && apk add --no-cache bash iw hostapd networkmanager networkmanager-cli net-tools sudo dnsmasq iptables && rm -rf /var/cache/apk/*' returned a non-zero code: 4

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 239, in handle_call_service
    response = await hass.services.async_call(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/core.py", line 2319, in async_call
    response_data = await coro
                    ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/core.py", line 2356, in _execute_service
    return await target(service_call)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 905, in entity_service_call
    single_response = await _handle_entity_call(
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 975, in _handle_entity_call
    result = await task
             ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/update/__init__.py", line 161, in async_install
    await entity.async_install_with_progress(version, backup)
  File "/usr/src/homeassistant/homeassistant/components/update/__init__.py", line 465, in async_install_with_progress
    await self.async_install(version, backup)
  File "/usr/src/homeassistant/homeassistant/components/hassio/update.py", line 169, in async_install
    raise HomeAssistantError(f"Error updating {self.title}: {err}") from err
homeassistant.exceptions.HomeAssistantError: Error updating Hass.io Access Point: The command '/bin/bash -o pipefail -c apk update && apk add --no-cache bash iw hostapd networkmanager networkmanager-cli net-tools sudo dnsmasq iptables && rm -rf /var/cache/apk/*' returned a non-zero code: 4

System details:
Core 2024.3.3
Supervisor 2024.03.1
Operating System 12.1
Frontend 20240307.0

Thank you for raising this, I'll investigate now

@muellermartin Hi, this should have been fixed in 0.5.2, please verify

@ROBOT0-VT Thanks for the quick reaction!
Unfortunately, the issue seems to persist in 0.5.2 with a very similar error (only some code line numbers changed):

Click to expand
Logger: homeassistant.components.websocket_api.http.connection
Source: components/websocket_api/commands.py:239
integration: Home Assistant WebSocket API (documentation, issues)
First occurred: 3:55:16 PM (1 occurrences)
Last logged: 3:55:16 PM

[140229125004480] Error updating Hass.io Access Point: The command '/bin/bash -o pipefail -c apk update && apk add --no-cache bash iw hostapd networkmanager networkmanager-cli net-tools sudo dnsmasq iptables && rm -rf /var/cache/apk/*' returned a non-zero code: 4
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/hassio/update.py", line 168, in async_install
    await async_update_addon(self.hass, slug=self._addon_slug, backup=backup)
  File "/usr/src/homeassistant/homeassistant/components/hassio/handler.py", line 59, in _wrapper
    data = await funct(*argv, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/hassio/handler.py", line 136, in async_update_addon
    return await hassio.send_command(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/hassio/handler.py", line 593, in send_command
    raise HassioAPIError(error.get(ATTR_MESSAGE))
homeassistant.components.hassio.handler.HassioAPIError: The command '/bin/bash -o pipefail -c apk update && apk add --no-cache bash iw hostapd networkmanager networkmanager-cli net-tools sudo dnsmasq iptables && rm -rf /var/cache/apk/*' returned a non-zero code: 4

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 239, in handle_call_service
    response = await hass.services.async_call(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/core.py", line 2543, in async_call
    response_data = await coro
                    ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/core.py", line 2580, in _execute_service
    return await target(service_call)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 971, in entity_service_call
    single_response = await _handle_entity_call(
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 1043, in _handle_entity_call
    result = await task
             ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/update/__init__.py", line 162, in async_install
    await entity.async_install_with_progress(version, backup)
  File "/usr/src/homeassistant/homeassistant/components/update/__init__.py", line 466, in async_install_with_progress
    await self.async_install(version, backup)
  File "/usr/src/homeassistant/homeassistant/components/hassio/update.py", line 170, in async_install
    raise HomeAssistantError(f"Error updating {self.title}: {err}") from err
homeassistant.exceptions.HomeAssistantError: Error updating Hass.io Access Point: The command '/bin/bash -o pipefail -c apk update && apk add --no-cache bash iw hostapd networkmanager networkmanager-cli net-tools sudo dnsmasq iptables && rm -rf /var/cache/apk/*' returned a non-zero code: 4

Alrighty, I've fixed this properly, and tested on a fresh addon instance from this repo, rather than my local copy.
Sorry for the super dumb change 🙏 and thank you for your good issue!


fix require statement in jittertest

@ericelliott Thanks for putting this together!
I really love the idea of this project

Thanks!


How to combine parameters of both AKHighPassFilter and AKCompressor to AKAudioInput from microphone?

Just chain these effects in the instrument, for instance:
AKHighPassFilter *hp = [[AKHighPassFilter alloc] initWithInput:mic cutoffFrequency:akp(2000)];
AKCombFilter *comb = [[AKCombFilter alloc] initWithInput:hp];


Launch external merge tool for conflict - No such file or directory: '--verbose'

Sublime Text version number: Dev channel, Build 3139
Git version number: 2.13.0 (Apple Git-88)
OS type and version: macOS Sierra, 10.12.5
Console error output:
>>> view.run_command("gs_status_launch_merge_tool")
Traceback (most recent call last):
  File "core.interfaces.status in /Users/sumanjay/Library/Application Support/Sublime Text 3/Installed Packages/GitSavvy.sublime-package", line 802, in <lambda>
IndexError: tuple index out of range

A description of the problem:
On attempting to launch an external merge tool to resolve a conflict, nothing happens.
Inspecting the console shows this -
  File "core.interfaces.status in /Users/sumanjay/Library/Application Support/Sublime Text 3/Installed Packages/GitSavvy.sublime-package", line 802, in <lambda>
  File "core.git_mixins.merge in /Users/sumanjay/Library/Application Support/Sublime Text 3/Installed Packages/GitSavvy.sublime-package", line 88, in launch_tool_for_file
  File "core.git_mixins.merge in /Users/sumanjay/Library/Application Support/Sublime Text 3/Installed Packages/GitSavvy.sublime-package", line 68, in launch_tool_for_file
  File "./python3.3/subprocess.py", line 819, in __init__
  File "./python3.3/subprocess.py", line 1448, in _execute_child
FileNotFoundError: [Errno 2] No such file or directory: '--verbose'

Relevant section of my gitconfig file:
[difftool "sourcetree"]
	cmd = /Applications/DiffMerge.app/Contents/MacOS/DiffMerge --nosplash \"$LOCAL\" \"$REMOTE\"
	path =
[mergetool "sourcetree"]
	cmd = /Applications/DiffMerge.app/Contents/MacOS/DiffMerge --merge --result=\"$MERGED\" \"$LOCAL\" \"$BASE\" \"$REMOTE\"
	trustExitCode = true
[diff]
	tool = diffmerge
[merge]
	tool = diffmerge
[difftool "diffmerge"]
	cmd = diffmerge
[mergetool "diffmerge"]
	trustExitCode = true
	cmd = diffmerge --merge --result=\"$MERGED\" \"$LOCAL\" \"$BASE\" \"$REMOTE\"

Output of git config merge.tool is diffmerge.
Output of git config mergetool.diffmerge.cmd is - diffmerge --merge --result="$MERGED" "$LOCAL" "$BASE" "$REMOTE"
Steps to reproduce, if possible: I'm not entirely sure, I switched back to using my older Mac after encountering this issue on my current one. Very similar setup with just a difference in hardware (2015 vs 2013).

Hi @oddysee , thank you for reporting the issue! Kindly help us with a few more details:

Output of git config -l | grep merge

Result of running git mergetool on it's own in a shell

If the above still doesn't provide enough information, please record and attach a debug log like so:

Open sublime, and get to the state of conflict just prior to running the merge command
Open command palette, and run the command "GitSavvy: enable logging"
Perform the failing "Launch external merge tool" command.
Run the command "GitSavvy: disable logging"
Run the command "GitSavvy: view recorded log", save the file and attach it here. Take care to remove any sensitive information that may be recorded in GitSavvy.

I am seeing the same issue on one of my machines but not another. I do have a different mergetool than the OP. Here is the info you asked for:

**Output of git config -l | grep merge:

merge.tool=sublimerge
mergetool.sublimerge.cmd=subl -n --wait "$REMOTE" "$BASE" "$LOCAL" "$MERGED" --command "sublimerge_diff_views"
mergetool.sublimerge.trustexitcode=false
diff.tool=sublimerge
difftool.sublimerge.cmd=subl -n --wait "$REMOTE" "$LOCAL" --command "sublimerge_diff_views {\"left_read_only\": true, \"right_read_only\": true}"
branch.widget-migration.merge=refs/heads/widget-migration
branch.dev.merge=refs/heads/dev
branch.production.merge=refs/heads/production
branch.team-dash--35429.merge=refs/heads/team-dash--35429
branch.fed-bugs-for-client-launches.merge=refs/heads/fed-bugs-for-client-launches
branch.panels-layered--56935.merge=refs/heads/panels-layered--56935

Result of git mergetool: Mergetool correctly opens up and works as expected.
Result of GitSavvy debug log attached.

As noted, running git mergetool works just fine, so it's not a major issue; but I can't figure out why one of my machines works and another doesn't when I hit M from the status screen to run the mergetool. Both machines have the same config. Any help would be appreciated.
Thank you for all your work on GitSaavy... it's a great tool that I use every day and sure appreciate it!!

Result of GitSavvy debug log attached.
Where is it?

Where is it?

Sorry, not sure what happened. I updated the comment with the attached log.

@theiviaxx
Can you inspect the console and see if it prints an error? maybe there is a problem with the path

@thezimmee are you sure  that the issue occurred in the attached log? There doesn't seem that there is --verbose anywhere in the merge command to be executed.
If you still have the issue, I have created a branch that adds a bit more logging about executed command over here: feature/add-process-debug-log
Please try it out and add the new output here.

@asfaltboy OP here, I discovered that a botched install of a Git client (SourceTree) had mangled the gitconfig, which was resulting in the --verbose merge tool command.
Apologies for the confusion and thanks for all the assistance. Leaving this open for @thezimmee, though I'd suggest his issue is different and he'd be better off opening a separate issue.

I recently installed the dev build of Sublime, and for whatever reason that seemed to resolve the issue for me. Thanks for your help guys, I will let you know if I see it again.


Please re-open issue #94829

I believe there was a misunderstanding for this issue, I posted #94829 in hopes of adding that VM Scale Sets aren't supported for Start on Connect in the documentation, not to solve the technical issue - as I understand it's not supported.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
ID: fac2ed89-73b2-b382-d331-bef4df300297
Version Independent ID: a4364f7a-f260-36db-b08e-08c5a3a4762c
Content: Set up Start VM on Connect for Azure Virtual Desktop
Content Source: articles/virtual-desktop/start-virtual-machine-connect.md
Service: virtual-desktop
GitHub Login: @Heidilohr Heidi Lohr FTE
Microsoft Alias: helohr

@kaheamartin
Thanks for your feedback! We will investigate and update as appropriate.

@Heidilohr
Can you please check and add your comments on this doc update request as applicable.

Hi @kaheamartin - apologies for the confusion. Virtual Machine Scale Sets aren't supported for use at all as session hosts with Azure Virtual Desktop, not just Start VM on Connect. I've made a note for this in the prerequisites article and the changes should be visible in a few hours.
#please-close


Implement Sleuth interceptor for Apache HttpClient

Would it be possible to add an interceptor which instruments outgoing calls from an Apache HttpClient? It would follow the same pattern as the other interceptors in org.springframework.cloud.sleuth.instrument.web.client.
This interceptor would implement org.apache.http.HttpRequestInterceptor, and can be used as follows:
@Autowired
private TraceHttpClientInterceptor tracingInterceptor; // New class

...

org.apache.http.client.HttpClient httpClient =
    HttpClientBuilder.create()
                     .addInterceptorFirst(tracingInterceptor)
                     .build();

How about a contribution? :) You have almost everything sorted out so it would be great if you continued the work and wrote the missing implementation and wrote some tests to it. We will gladly accept such a contribution :)

@marcingrzejszczak, for sure, I'll be happy to contribute. I just wanted to be sure that it fits into the overall project before starting.

@marcingrzejszczak please share the complete example. it will really help to see the implementation. is the project on github? i have the same problem statement to use apache HTTP client for tracing in spring boot microservice and export traces to zipkin

@mukulb82 wherever you're using an HttpClient you have to use in the way I've presented above. You can read more about this here https://github.com/openzipkin/brave/tree/master/instrumentation/httpclient and here you have a test for that https://github.com/openzipkin/brave/blob/master/instrumentation/httpclient/src/test/java/brave/httpclient/ITTracingHttpClientBuilder.java#L44-L55

okay. let me take a look. thanks

i have a question, in the java class - https://github.com/openzipkin/brave/blob/master/instrumentation/httpclient/src/test/java/brave/httpclient/ITTracingHttpClientBuilder.java how are you creating httpTracing ?

You can autowire it. Tracer and HttpTracing are available as beans.

@marcingrzejszczak i have a question, in the java class - https://github.com/openzipkin/brave/blob/master/instrumentation/httpclient/src/test/java/brave/httpclient/ITTracingHttpClientBuilder.java how are you creating httpTracing ?

ok, while autowiring these are not available. i tried doing the autowiring and i am being told
No qualifying bean of type 'brave.Tracing' available: expected at least 1 bean which qualifies as autowire candidate

i am using - spring-beans-4.3.9.RELEASE.jar

I have no idea what you're doing. If you generate a project via start.spring.io then it will work (https://github.com/spring-cloud/spring-cloud-sleuth/blob/master/spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/autoconfig/TraceAutoConfiguration.java#L76). If you have questions about Brave, please go to Brave's GitHub project and ask for questions there or on Brave's Gitter channel.

on gitter, both brave alone and also later sleuth were mentioned. I have no idea specifically what's of interest but if I create a diff for using httpclient I'll post it here.

https://github.com/openzipkin/sleuth-webmvc-example#apache-http-client-tracing shows what we were talking about

https://github.com/openzipkin/brave-webmvc-example/compare/add-apachehc-tracing for brave standalone (just because I said I would :P )


[8.x] Add new allows blade directive

This pull request adds a new "allows" directive. It is an alternative to the "can" directive, and only provides the possibility to get the "reason" (message) that is the result of the Gate inspect message.
Users can check if an action is authorized.
@can("create", App\Models\Post::class)
    You can create a post!
@elsecan
    You cannot create a post...
@endcan

To get the message/reason for the denial, we have to pass a variable holding the result of the Gate's message method call like this:
@php
    use App\Models\Post;

    $creatingPost = Gate::inspect("create", Post::class);
@endphp

@if($creatingPost->allowed())
    You can create a post!
@else
    {{ $creatingPost->message() }}
@endif

(Note that you would have probably pass the $creatingPost from your controller)
This pull request offers a more straight forward way to do all of this using a shortened code.
@allows("create", App\Models\Post::class)
    You can create a post!
@elseallows
    {{ $message }}
@endallows

It works exactly like the @error directive, exposing a local $message variable that holds the result of the Gate's message call. Note that like the @error directive, if there was already an existing $message variable, its value will be stored in a variable called $__messageOriginal.
Also note that you can pass the message of the allowing result as well:
namespace App\Policies;

use App\Models\Post;
use Illuminate\Auth\Access\HandlesAuthorization;
use Illuminate\Auth\Access\Response;

final class PostPolicy
{
  use HandlesAuthorization;

  public function update(User $user, Post $post): Response
  {
    return $post->author->is($user) ?
      Response::allow("Update your post.") :
      Response::deny("Only author can update their post.");
  }
}

@allows("update", $post)
    {{ $message }}
@elseallows
    {{ $message }}
@endallows

No breaking changes should occur after merging this PR.
I shamelessly copy/pasted the source code on my own L8 project to test if it works (and it did), since I cannot figure out how to test the whole integration.

If think you should unset the $access and $message variables inside compileEndallows, like compileEndError does:
<?php unset($message);
if (isset($__messageOriginal)) { $message = $__messageOriginal; }
endif;
unset($access); ?>

I also would like your opinion because I thought of even more "readable" Blade keys. What do you think of this:
@allow("update", $post)
  You can update your post!
@deny
  {{ $message }}
@endallows

It would be breaking but I kind of think this should be integrated into the @can directive because they do basically the same thing. The only difference is that @allows exposes that message. But as I said this would be problematic for all cases where people use the @can directive with a $message var inside.

That's for this exact reason I've decided to make a new directive @dennisprudlo. I am eager to make @can benefit from this, and target 9.x branch. I guess it's up to the Laravel team to decide 🤔
If you need my opinion -> I guess 9.x is close, so it's time to stop adding new features, and postpone anything for the next big release.

I agree that I'd just add this to @can() in 9.x and wait until then for its release. If $message is too general, you could name the new variable something like $gateMessage to minimize conflicts.

Yes, I agree with that too. There is no need to add another directive that actually does the same thing.

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


Traefik 2.11.1 & 3.0.0-rc4 break websocket connections

See https://github.com/traefik/traefik/issues/10598
Fix: roll-back or wait for the update
Workaround: add this to your entrypoint in eg. traefikyml (static config):
    transport:
      respondingTimeouts:
        tcp:
          lingeringTimeout: 180

NOTE: Traefik 2.11.2 and 3.0.0-rc5 have actually removed the tcp.lingeringTimeout setting and more importantly, will fail to start if these are present

I am going to unpin this because as far as I read https://github.com/traefik/traefik/issues/10598, this is fixed


Consul Catalog templating issue

Do you want to request a feature or report a bug?
Possible bug
What did you do?
I'm configuring traefik to work with Consul Catalog backend and the templating system is not picking up the service name from consul. The weird thing here is that if I don't touch the frontEndRule in the configuration the service name is picked and I see Host:admin..
I've tested the frontEndRule using PathPrefix:/{{.ServiceName}}, Host:{{.ServiceName}} and even Host:{{.ServiceName}}.{{.Domain}} which you expect to see working because it's the default, but it doesn't.
What did you expect to see?
"routes":{"route-host-admin":{"rule":"PathPrefix:/admin"}}

What did you see instead?
"routes":{"route-host-admin":{"rule":"PathPrefix:/\u003cno value\u003e"}}

Output of traefik version: (What version of Traefik are you using?)
docker run traefik:1.5 version
Version:      v1.5.4
Codename:     cancoillotte
Go version:   go1.9.4
Built:        2018-03-15_01:35:21PM
OS/Arch:      linux/amd64

What is your environment & configuration (arguments, toml, provider, platform, ...)?
logLevel = "INFO"
[web]
  address = ":9997"
  [web.statistics]
    RecentErrors = 10
  [web.metrics.prometheus]
    Buckets=[0.1,0.3,1.2,5.0,10.0,20.0]
[entryPoints]
  [entryPoints.http]
    address = ":9996"
[consulCatalog]
  endpoint = "<IP_ADDRESS>:8500"
  frontEndRule = "PathPrefix:/{{.ServiceName}}"
  constraints = ["tag==dev", "tag==external"]

If applicable, please paste the log output at DEBUG level (--logLevel=DEBUG switch)
time="2018-03-27T16:25:07Z" level=debug msg="List of services changed"
time="2018-03-27T16:25:07Z" level=debug msg="Fetching service" service=admin
time="2018-03-27T16:25:07Z" level=debug msg="Service admin pruned by 'tag==dev' constraint"
time="2018-03-27T16:25:08Z" level=debug msg="Configuration received from provider consul_catalog: {"backends":{"backend-admin":{"servers":{"admin--[REDACTED]--59030--dev--microservic
e--urlprefix-admin--traefik-tags-dev--traefik-tags-external--traefik-tags-internal--0":{"url":"http://[REDACTED]:59030","weight":0},"admin--[REDACTED]--50487--dev--microservice--traefik-tags-dev--traefik-tags-external--traefik-tags-internal--1":{"url":"http://[REDACTED]:50487","weight":0}},"loadBalancer":{"method":"wrr"}}},"frontends":{"fronten
d-admin":{"entryPoints":["http"],"backend":"backend-admin","routes":{"route-host-admin":{"rule":"PathPrefix:/\u003cno value\u003e"}},"passHostHeader":true,"priority":0,"basicAuth":[]}}}
"

Thanks for your interest in Traefik !
To have a value for {{.Domain}} you need to define the domain in the Consul Catalog configuration section: https://docs.traefik.io/configuration/backends/consulcatalog/
[consulCatalog]
# ...
domain = "my_domain"

The value \u003cno value\u003e (<no value>) appears because your service seems don't have service name, please check the service information in your Consul.
Join us on the Traefik community Slack is you need more support.

Hi, thanks for the reply, but I’m not talking about the domain here. It’s about the service name. It doesn’t show up as it’s supposed to

Ty, this ticket helped my issue.
"... The weird thing here is that if I don't touch the frontEndRule in the configuration the service name ..."
Using v1.7.3
Regardless that the value is the default. It now works for me now by removing its declaration from traefik.toml
[consulCatalog]
  frontEndRule = "Host:{{.ServiceName}}.{{.Domain}}"


Definitions for type-checking

Just a small question: why was this necessary:
from typing import (
    TYPE_CHECKING,
)

if TYPE_CHECKING:
    from nomad.datamodel.datamodel import (
        EntryArchive,
    )
    from structlog.stdlib import (
        BoundLogger,
    )

Was this introduced to avoid some import problems, or is this the recommended way instead of importing the actual definitions?

This was added because @hampusnasstrom requested this.
But this is also the recommended way to add type annotations to avoid circular imports, see blog post on this.

I was just wondering, because the new plugin layout is designed to avoid cyclical import as best as we can, and if there was an actual problem with some schema. @hampusnasstrom: Did you experience some issues with cyclical imports?

I see. I would then argue that we can simplify this in the new system by simply importing these two directly. The new system will load the plugins in a way that should prevent the cyclical imports.
Could you @blueraft do this simplification for all entry points? Just do both imports at the top regularly. If we then later still get some unfixable problems with the imports, then we can always come back to this solution.

We just need to make sure that the IDEs (VScode at least) understands this for type hinting.

LSP works fine

But we will have to pull in structlog as a main dependency now since it's not a conditional import anymore.
❯ python
Python 3.9.10 (main, Feb  6 2024, 15:20:00)
[GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from nomad_foobar.schema_packages import mypackage
>>> mypackage.load()
Schema is deprecated, use plugins. ()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/ahmedilyas/cookiecutter-nomad-plugin/nomad-foobar/.venv/lib/python3.9/site-packages/nomad_foobar/schema_packages/__init__.py", line 9, in load
    from nomad_foobar.schema_packages.mypackage import m_package
  File "/home/ahmedilyas/cookiecutter-nomad-plugin/nomad-foobar/.venv/lib/python3.9/site-packages/nomad_foobar/schema_packages/mypackage.py", line 6, in <module>
    from structlog.stdlib import BoundLogger
ModuleNotFoundError: No module named 'structlog'

Yes, structlog should be a default dependency.


using Helpers trait and controller constructor

This code will give this error: (all routes of this controller are api protected)
"Maximum function nesting level of '200' reached, aborting!"
class UserController {
   use Helpers;

   public function __construct()
   {
      $this->user = $this->user(); // WHY? No problem if we use "this->user()" without injecting in the constructor
   }

   public function me()
   {
      return $this->item($this->user, UserTransformer::class);
   }

   public function update(Request $request)
   {
      $this->user->update($request->all());

      return $this->item($this->user, UserTransformer::class);
   }
}

Why is this? I'm using last versions of laravel and dingo

Are you sure it was supposted to work with class string. In the wiki you will find like this
        return $this->response->item($user, new UserTransformer);

@catalinux  Yes, but it doesn't matter, is an example code, the problem is in the constructor.

You have an infinite loop there.
You cant use $this->user() on __construct method because it will be recursive. This errors occurs only if the user variable isn't set and if the user isn't authenticated.
Keep in mind that at this point the route object doesn't exist yet. So the API try to authenticate the user (https://github.com/dingo/api/blob/master/src/Auth/Auth.php#L151) that will try to use each provider available (https://github.com/dingo/api/blob/master/src/Auth/Auth.php#L82) to do so. This authenticate function expects as parameter 2 the current route (that doesn't exist remember?).
So the function $this->router->getCurrentRoute() called as parameter 2 take us to Router.php calling $this->createRoute($route) (https://github.com/dingo/api/blob/master/src/Routing/Router.php#L691) that creates a new Route object (https://github.com/dingo/api/blob/master/src/Routing/Router.php#L713).
In this point tracking the Route object and its construct method it calls $this->setupRouteProperties($request, $route) (https://github.com/dingo/api/blob/master/src/Routing/Route.php#L144) that calls $this->mergeControllerProperties() (https://github.com/dingo/api/blob/master/src/Routing/Route.php#L167) that finally calls $this->makeControllerInstance() (https://github.com/dingo/api/blob/master/src/Routing/Route.php#L186).
So makeControllerInstance method is making a new instance of our controller (https://github.com/dingo/api/blob/master/src/Routing/Route.php#L325) that's call our __construct method again, that fires $this->user() again, and the stack begins again.
This will be recursive until the max stack on nesting level in xDebug be reached that for you is 200 (but for me is 256). BTW you can deactivate xDebug or set the maximum nesting level in the php.ini higher using xdebug.max_nesting_level=500 for example.
So this proves that you can't use $this->user() on __construct method.
But the real question is WHY you need to use that or even set it to a user property when the Helpers trait dynamic offers you that user property by magic method __get as an alias for user() method?

@tembra Thx from your great explanation.
I did not know that "user" property exists (magic method), so I had more methods in the controller that I need the "user" object, that's why I initialized the user property to user method.

Excellent explanation @tembra, thanks for your replies to many of these issues. Very helpful. :+1:
I do need to clear a lot of these little confusing errors up though by noting it in the docs. One day.


Deleted Username to make way for a Team Name

I had user account Remedycoin but preferred to have a team name be remedycoin.  Everything I read said that presently we aren't allowing a team name to be the same as a username.  So I had seen the nuke feature.  So I nuked myself -- expecting to be like the phoenix, rising from the ashes as a group name.  I have an older account foghorn that I'm using presently.  Thanks so much for the awesome software and infrastructure!
my log id: 3476ade130d6949432b7271c

Once a username is picked up it cannot be reused so even if you left then your account cant be impersonated by creating a new one with the same username. So all usernames can be used once.

Time to fork the project, so I can have the remedycoin team name.  (just kidding!)
I started a team of remedycoincom


Fixing leak of Vulkan command buffer resource sets.

Looks like we aren't running ASAN+vulkan - probably swiftshader?

(reminds me I need to loop back around to my VMA replacement - so context switched o_o)


Cherry-pick to sdf10: Store material file path information

Cherry-pick #349 to sdf10. Use rebase and merge.
Store material file path information (#349)

Codecov Report

Merging #356 into sdf10 will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##            sdf10     #356   +/-   ##
=======================================
  Coverage   87.35%   87.36%
=======================================
  Files          60       60
  Lines        9207     9214    +7
=======================================
+ Hits         8043     8050    +7
  Misses       1164     1164

Impacted Files
Coverage Δ

src/Material.cc
99.29% <100.00%> (+0.03%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d506bf3...4e94d16. Read the comment docs.


How to specify c and c++ compiler

@stevenmburns When I export CC=path/to/gcc and export CXX=path/to/g++ it seems still using the default gcc and g++ in /usr/bin. Even though I set an empty path it still goes to /usr/bin. How can I set the compiler path?

@soneryaldiz Do you have any idea on this?

@854768750 Can you set the CC/CXX variables, remove _skbuild directory and try rebuilding?

It works now, after rebuilding.


Bumped supported Kubernetes version in integration tests

This change is

@krzyzacy can you please help with debugging the issue here?

@piosz sure, what's the context?

The test passed with the old version here https://github.com/kubernetes/heapster/pull/1535 a couple of minutes ago.

@krzyzacy both locally and on Jenkins I can see:
=== RUN   TestHeapster
E0316 23:05:18.324786   14810 framework.go:166] failed to tear down cluster - "exit status 1"
Bringing down cluster using provider: gce
!!! kubectl appears to be broken or missing
!!! Cannot find kubernetes-server-linux-amd64.tar.gz
Required binaries appear to be missing. Do you wish to download them? [Y/n]
E0316 23:05:18.817638   14810 framework.go:149] failed to bring up cluster - "exit status 1"
... Starting cluster in europe-west1-c using provider gce
... calling verify-prereqs
... calling verify-kube-binaries
!!! kubectl appears to be broken or missing
!!! Cannot find kubernetes-server-linux-amd64.tar.gz
Required binaries appear to be missing. Do you wish to download them? [Y/n]

Is this somehow related to the new image?

em I don't think the image has been changed though

some sort of conflicted resource names?

@k8s-bot test this

Oh the issue is only related to the version, I thought presubmit is broken for everything..
Not super familiar with how the integration is written, something new/different in 1.5.3 package which requires a test update?

@k8s-bot test this

@krzyzacy thanks for help. The issue was in Kubernetes kube-up.sh script: starting from 1.5 it requires some confirmations. Jenkins is happy.

lgtm


Getting "resource" is null with Spring Data REST and azure-spring-data-cosmos

Hi
I am trying to use azure-spring-data-cosmos with Spring Boot Starter Data REST, but encountering the following error on Spring Boot app's startup:
Caused by: java.lang.NullPointerException: Cannot invoke "org.springframework.data.rest.core.mapping.ResourceMetadata.isExported()" because "resource" is null
Dependencies in pom.xml:
<dependency>
            <groupId>org.springframework.boot</groupId>
            <artifactId>spring-boot-starter-data-rest</artifactId>
            <version>2.7.7</version>
        </dependency>
        <dependency>
            <groupId>com.azure</groupId>
            <artifactId>azure-spring-data-cosmos</artifactId>
            <version>3.31.0</version>
        </dependency>

Environment
JDK 17 - java version "17.0.5" 2022-10-18 LTS
Java(TM) SE Runtime Environment (build 17.0.5+9-LTS-191)
Java HotSpot(TM) 64-Bit Server VM (build 17.0.5+9-LTS-191, mixed mode, sharing)
Windows 10 x64

@backwind1233 could you please follow up?

@joshfree sure, I will follow up this.

Hi @singh-abhijeet, thanks for reaching out, I can't reproduce your issue, could you tell me more about your issue, steps I can follow to reproduce your issue, a mini sample would be better, if you could attach the sample here.

Thanks for the reply @backwind1233 , I am utilizing Spring Data REST for creating REDTful CRUD APIs of models and using Cosmos DB as the persistence.
To keep things simple, I'm using User model and repo. But while starting the Spring Boot app, I'm getting NPE:
"org.springframework.data.rest.core.mapping.ResourceMetadata.isExported()" because "resource" is null
Sharing the project so it becomes easier for you to reproduce and help:
SpringDataREST.zip
Removed application.yml from zip, but it looks like this:
spring:
  mvc:
    pathmatch:
      matching-strategy: ANT_PATH_MATCHER
logging:
  level:
    org.springframework.web: DEBUG
    root: INFO

server:
  port: 8080
  servlet:
    context-path: /config-meta

Hi @singh-abhijeet
I reproduced you issue with your sample, but the error is because of springfox, your samples depends on springfox-boot-starter
        <dependency>
            <groupId>io.springfox</groupId>
            <artifactId>springfox-boot-starter</artifactId>
            <version>3.0.0</version>
        </dependency>

You can report your issue in https://github.com/springfox/springfox, and I think they already tracked this: https://github.com/springfox/springfox/issues/3462

@backwind1233 Thanks for reproducing the error. As per your suggestion, I have removed SpringFox from the deps but the issue is still coming:
2023-01-20 13:05:36.883 DEBUG 7804 --- [nio-8080-exec-3] o.s.w.s.m.m.a.HttpEntityMethodProcessor  : Writing [org.springframework.data.rest.webmvc.support.ExceptionMessage@cd0ae5b]
2023-01-20 13:05:36.884 DEBUG 7804 --- [nio-8080-exec-3] .m.m.a.ExceptionHandlerExceptionResolver : Resolved [java.lang.NullPointerException: Cannot invoke "org.springframework.data.rest.core.mapping.ResourceMetadata.isExported()" because "metadata" is null]
2023-01-20 13:05:36.884 DEBUG 7804 --- [nio-8080-exec-3] o.s.web.servlet.DispatcherServlet        : Completed 500 INTERNAL_SERVER_ERROR

The web app starts and on hitting the API (GET) it gives 500 status code

Attaching new project without SpringFox - SpringDataRESTNoSpringFox.zip

Hi @kushagraThapar, could you help look at the issue?

@singh-abhijeet not sure on this one, the error is not coming from the spring data cosmos SDK.

Thanks @kushagraThapar for the reply. As per the Azure-Cosmos-Java-SDK docs, it supports Spring Data REST. Can you please share a sample Spring Data REST project leveraging Cosmos as persistence, that would be helpful as a starting point.

@singh-abhijeet unfortunately we don't have any samples on this, but we should definitely be able to build one sooner. @trande4884 / @TheovanKraay  can you please follow up on this, thanks!

@singh-abhijeet we will add samples.
However, to get a simple rest service up and running, you are only one step away. In your code, you just need a HomeController.java or similarly named class at the same directory as ConfigmetaApplication.java, with the rest mapping annotations. E.g. like the following:
package org.test;

import com.azure.cosmos.models.PartitionKey;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.context.annotation.PropertySource;
import org.springframework.stereotype.Controller;
import org.springframework.web.bind.annotation.DeleteMapping;
import org.springframework.web.bind.annotation.GetMapping;
import org.springframework.web.bind.annotation.PathVariable;
import org.springframework.web.bind.annotation.PostMapping;
import org.springframework.web.bind.annotation.RequestBody;
import org.springframework.web.bind.annotation.RequestMapping;
import org.springframework.web.bind.annotation.ResponseBody;
import org.test.models.User;
import org.test.repo.UserRepository;

import java.util.UUID;
import java.util.stream.Collectors;
import java.util.stream.StreamSupport;

@PropertySource("classpath:application.yaml")
@Controller
@RequestMapping(path = "/home")
public class HomeController {
    private static final Logger logger = LoggerFactory.getLogger(HomeController.class);
    private final UserRepository userRepository;

    public HomeController(UserRepository userRepository) {
        this.userRepository = userRepository;
    }

    @PostMapping
    public @ResponseBody String createUser(@RequestBody User user) {
        UUID uuid = UUID.randomUUID();
        user.setId(String.valueOf(uuid));
        userRepository.save(user);
        return String.format("Added %s.", user);
    }

    @GetMapping
    public @ResponseBody String getAllUsers() {
        Iterable<User> iter = userRepository.findAll();
        return StreamSupport.stream(iter.spliterator(), true)
                .map(User::toString)
                .collect(Collectors.joining(" , "));
    }

    @GetMapping("/{id}")
    public @ResponseBody String getUser(@PathVariable UUID id) {
        User user = userRepository.findById(id.toString()).get();
        String response = "no users found for this tenant!";
        if(user != null){
            logger.info("user: "+ user.getLastName());
            response = "first name: "+user.getFirstName() +", lastName: "+user.getLastName()+ ", id: "+user.getId();
        }
        return response;
    }

    @DeleteMapping("/{id}")
    public @ResponseBody String deleteUser(@PathVariable UUID id) {
        User user = userRepository.findById(id.toString()).get();
        if(user != null){
            userRepository.deleteById(id.toString(), new PartitionKey(user.getLastName()));
            return "Deleted " + id;
        }
        else{
            return "no users found for this tenant!";
        }
    }
}

REST call to create doc:
curl -s -d '{"firstName":"Theo","lastName":"van Kraay"}' -H "Content-Type: application/json" -X POST http://localhost:8080/config-meta/home

Thanks @TheovanKraay for sharing customized Controller code. But I see this deviates from the pattern of Spring Data REST where the framework automatically exposes a discoverable REST API for your domain model, and creation of Controller is optional.
To demonstrate this, I have changed the persistence to Mongo, and all the features of Spring Data REST are accessible as expected ("metadata" is null error gone when switched to Mongo!).
Auto-generated traversable REST API is accessible at: http://localhost:8080/config-meta/
Code: SpringDataRESTMongo.zip
I am interested in utilizing Cosmos with Spring Data REST, but without manually creating Controllers.

@singh-abhijeet I believe this is a feature of Spring Data REST support for "managed" data sources (currently JPA, MongoDB, Neo4j, Solr, Cassandra, Gemfire). With that said, we may need to clarify this better in our documentation, and we will also investigate the path to add support. cc @kushagraThapar and @trande4884 for further comment.
Meanwhile, I wonder if it is worth it for you to consider Azure Cosmos DB API for MongoDB. If you create an account with this API, Azure Cosmos DB should behave as though it is MongoDB at the wire protocol level, and the above features should then work as you expect.

Yes, in that case the documentation should have a caveat mentioning "Spring Data REST auto RestController generation not supported".
Additionally, in future releases spring-data-cosmos should support these features to be fully compatible with Spring Data REST, else as per the current approach (manual Controller creation) it is only compatible with Spring Boot WebMvc arch.


Review n genes

Similar to last PR (https://github.com/iobio/gene.iobio.vue/pull/629). Source indicator visuals have changed.
Clin branch: https://github.com/iobio/clin.iobio/tree/feature-review-top-n-genes
Issue: https://github.com/iobio/gene.iobio.vue/issues/625
Do npm install as its dependency packages have been updated.
To test it> Run clin with demo data > Add phenotypes > Top 20 genes will be selected by default. > Go to review variants > Genes selected from phenotype step should be passed on > Also the source should be indicated in the genes and variant tab on left sidebar and also in the variant inspect card.

quarantest build successful. Demo link at
http://2910fd35.quarantest.iobio.io


FMU builder doesn't load / certificate error

It looks like the FMU builder has a problem with its certificate? In the App this leads to a blank pane, but in Chrome I can navigate to https://sweng.au.dk/fmubuilder and add a security exception, then it works fine.
Not sure if this is just on Newcastle campus or a wider problem.

Can confirm the same error shows up here.

Chrome says NET::ERR_CERT_DATE_INVALID.

Yes I did not manage to install the new one before I vent on vacation all domains should be updated now


Using react-arborist in an app seems to break file & folder drop on  elements

I just recently added react-arborist to a React 18.2 app and have discovered it seems to break file and folder dropping on an <input type="file" multiple />, at least, it prevents onchange events from being delivered to the input onchange handler.
With a single, simple <Tree /> in the app, none of the file <input /> drop targets see onchanged events, and it appears something is eating the event, as a regular drop onto a page other than an input element opens the file in another browser tab.
If I comment out the <Tree />, the drop targets all accept file & folder drops again.
I've tried running <Tree /> with all of disableEdit disableDrag disableDrop in place, but it still breaks input.
Any suggestions?

Somewhat similar issue I am facing. Rendering the tree component is preventing this event -> document.addEventListener('dragend', handleDragEndGlobal) from no longer being called.

Not sure if this will fix your issue, but it fixed my above issue - see - this issue
Specifically in my case, using the tree's parent as the element to pass as the root element for the dndRootElement prop
      <div         ref={treeContainerRef}         className="relative flex h-full min-h-0 flex-col " // Set this div as a flex container       >         {treeContainerRef.current && (           <Tree             dndRootElement={treeContainerRef.current}             ref={treeRef}             data={treeData}             // etc.           >             {HierarchyPanelTreeNode}           </Tree>         )}       </div>


Update MD file on new branch 2017-23-26_13-11-15

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


🔄 synced file(s) with klaasnicolaas/github-config

synced local file(s) with klaasnicolaas/github-config.

Changed files

synced local directory .github/ with remote directory github/

This PR was created automatically by the repo-file-sync-action workflow run #8798827841

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (807c584) to head (a8d593a).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #625   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            5         5
  Lines          166       166
  Branches        26        26
=========================================
  Hits           166       166

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat: Delete old url paths when webtools become disabled

What does it do?
Deletes old ul aliases
Why is it needed?
It does not make sense to have url aliases in the database which are not in use.
How to test it?
TODO
This is still WIP and needs to be tested
Related issue(s)/PR(s)
closes #51

This PR seems legit to me @Alexnortung.
Is there any reason it's still on Draft?
Also there are some eslint warnings causing the pipeline to fail.

I need to test it and it would be nice if I could add some automated tests for this. And I also just wanted to quality assure it


Add PHP Gui

Very nice PHP GTK alternative
https://github.com/gabrielrcouto/php-gui

Pull requests welcome.

@josegonzalez is to add on framework section?

@joubertredrat, maybe to Miscellaneous ?


Document patternplate

This is undocumented. Looking at the code I ended up doing:
$ mkdir -p .patterns/<my-pattern>
$ touch patterns/<my-pattern>/pattern.json

And now  shows up in the list of valid scopes.

Please see #112 for an alternative way which I think it's better IMHO. Ideally it would be part of the commitlint.config.js but I didn't want to stretch ;).

Closing this as discussed in #112


CMD+P or Ctrl-P is broken if file names contain non utf8 symbols

example:

create a file named über.txt
make sure it is located in a folder path that you have added to your favorites
in this case, CMD+P will never finish

related to serde_json again. At that time in the scope of wasm modules (matcher) in client


Drop Python 2 support

pywebsocket3 depends on six, and while it's very unlikely to be the indirect six dependency in https://github.com/web-platform-tests/wpt/issues/28776, perhaps can be dropped?
Is pywebsocket3 used outside of WPT, or can it just go with Python 3.6+ like WPT?

It's still used in at least Chrome's web_tests and WebKit's layout tests. I don't think we can drop Python 2 support just yet, but we might be close.
An option might be to pin Python 2 support at a particular version, and remove it from later versions, but I'd prefer not to do that as it could backfire badly.
I'm going to keep this open as a task to do when the known downstreams are ready.

Are we still using Python 2 in Chromium CI? For WebKit, @gsnedders was OK with dropping py2 support for WPT itself on Feb 1 this year, which happened, but maybe pywebsocket3 is also used in contexts outside of WPT in Chromium/WebKit CI?
@jgraham do you know if this is used in Gecko outside of WPT?

Yes, pywebsocket3 is still run under Python 2 for the tests located in https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/http/tests/websocket/. From my skimming of the code, it looks like all of run_web_tests.py apart from wptserve run under Python 2 still. I think it should be possible to switch only pywebsocket3 over using a similar technique, however the last time I tried this I was not successful.

I see, so this isn't a quick fix then. But now there's an issue that can grow old before finally being resolved :)

We seem to have another vendored copy for mochitests, which are apparently still running under Py2 in CI. But that is supposed to change soon and we could upgrade that copy seperately from the copy in wpt which we're using with Py3 exclusively.


raise ArgumentError if object cannot be proxied

fixes #1356

@pirj can you take a look?
however I cannot understand why travis CI failed, I will try to reproduce with the given ruby versions on localhost to identify what's wrong

thanks @JonRowe will update

I couldn't find changelog for ruby 2.0.0, but surely in previous ruby versions symbols where not frozen by default, that's why travis was failing for older ruby versions.
consider this example, I reproduced and fixed with ruby 1.9.3
irb(main):001:0> RUBY_VERSION
=> "1.9.3"
irb(main):002:0> :subject.frozen?
=> false

@pirj @JonRowe and I see on another PR #1349 you planning to drop ruby < 2.3, maybe there is no need to adjust this code to be compatible with older ruby versions. what do you think?

@zhisme If you wish to target this off 4-0-dev for release in 4.0.0 you are welcome to drop the compatibility code, we plan to release around the launch of Ruby 3.0.0 but there is no guaranteed timeline for it. I will probably backport this to main however for release in a bugpatch in the 3.x series.

@JonRowe  any idea of travis-ci build error?
And other seems like failed due to this one. Need your help
Failure/Error: require 'thread_order'
LoadError:
  cannot load such file -- thread_order

Thanks, don't worry about Travis we're phasing it out as its become really unreliable since they essentially dropped open source.

Hi, I've just pulled this in and am getting test failures in areas where I've stubbed destroyed ActiveRecord objects, which freezes them. I'm not understanding why rspec should refuse to stub these objects and I'm not seeing any explanation here, but hoping someone could explain it to me?

Hi, I've just pulled this in and am getting test failures in areas where I've stubbed destroyed ActiveRecord objects, which freezes them. I'm not understanding why rspec should refuse to stub these objects and I'm not seeing any explanation here, but hoping someone could explain it to me?

@keegangroth Frozen objects cannot be modified, which is required to stub them.

@keegangroth Frozen objects cannot be modified, which is required to stub them.

OK, I think there's something specific to ActiveRecord here, because old and new versions of rspec both throw errors for Hash objects. I'll see if I can come up with a trivial example for activerecord, here's something that behaves more or less the same both before and after this change.
describe 'frozen stubbing' do
  let(:h) { Hash.new }
  let(:error) { StandardError.new 'mine' }

  context 'expect_any_instance_of' do
    before do
      expect_any_instance_of(Hash).to receive(:map).and_raise(error)
    end

    # fails with either
    # expected #<StandardError: mine>, got #<ArgumentError: Cannot proxy frozen objects, rspec-mocks relies on proxies for method stubbing and expectations. Hash: {}>
    # or
    # expected #<StandardError: mine>, got #<FrozenError: can't modify frozen class/module>
    it 'fails' do
      h.freeze
      expect{h.map}.to raise_error(error)
    end
  end

  context 'instance stub' do
    before do
      expect(h).to receive(:map).and_raise(error)
    end

    it 'works' do
      h.freeze
      expect{h.map}.to raise_error(error)
    end
  end
end

OK, I think there's something specific to ActiveRecord here, because old and new versions of rspec both throw errors for Hash objects. I'll see if I can come up with a trivial example for activerecord, here's something that behaves more or less the same both before and after this change.
describe 'frozen stubbing' do
  let(:h) { Hash.new }
  let(:error) { StandardError.new 'mine' }

  context 'expect_any_instance_of' do
    before do
      expect_any_instance_of(Hash).to receive(:map).and_raise(error)
    end

    # fails with either
    # expected #<StandardError: mine>, got #<ArgumentError: Cannot proxy frozen objects, rspec-mocks relies on proxies for method stubbing and expectations. Hash: {}>
    # or
    # expected #<StandardError: mine>, got #<FrozenError: can't modify frozen class/module>
    it 'fails' do
      h.freeze
      expect{h.map}.to raise_error(error)
    end
  end

  context 'instance stub' do
    before do
      expect(h).to receive(:map).and_raise(error)
    end

    it 'works' do
      h.freeze
      expect{h.map}.to raise_error(error)
    end
  end
end

The behavior has definitely changed for destroyed ActiveRecord Models. I don't know what makes their version of freezing different from hash. Trivial example using rails to do the db setup:
class Human < ApplicationRecord
  def my_method
    10
  end
end

RSpec.describe Human, type: :model do
  let(:h) { described_class.create! name: 'Steve' }
  let(:error) { StandardError.new 'mine' }

  context 'expect_any_instance_of' do
    before do
      expect_any_instance_of(described_class).to receive(:my_method).and_raise(error)
    end

    it 'fails' do
      h.destroy!
      expect{h.my_method}.to raise_error(error)
    end
  end

  context 'instance stub' do
    before do
      expect(h).to receive(:my_method).and_raise(error)
    end

    it 'works' do
      h.destroy!
      expect{h.my_method}.to raise_error(error)
    end
  end
end

result on rspec-mocks 3.9.1:
Finished in 0.0497 seconds (files took 0.82981 seconds to load)
2 examples, 0 failures

result on rspec-mocks 3.10.1:
Failures:

  1) Human expect_any_instance_of fails
     Failure/Error: expect{h.my_method}.to raise_error(error)

       expected #<StandardError: mine>, got #<ArgumentError: Cannot proxy frozen objects, rspec-mocks relies on proxies for method stubbing and expectations.> with backtrace:
         # ./spec/models/human_spec.rb:14:in `block (4 levels) in <top (required)>'
         # ./spec/models/human_spec.rb:14:in `block (3 levels) in <top (required)>'
     # ./spec/models/human_spec.rb:14:in `block (3 levels) in <top (required)>'

Finished in 0.04758 seconds (files took 0.87952 seconds to load)
2 examples, 1 failure

Failed examples:

rspec ./spec/models/human_spec.rb:12 # Human expect_any_instance_of fails

Probably warrants it's own (new) issue? Kind of niche, but it's now a major headache to test certain kinds of functionality in active record (I actually haven't yet figured out the work around for my particular case).

The behavior has definitely changed for destroyed ActiveRecord Models. I don't know what makes their version of freezing different from hash. Trivial example using rails to do the db setup:
class Human < ApplicationRecord
  def my_method
    10
  end
end

RSpec.describe Human, type: :model do
  let(:h) { described_class.create! name: 'Steve' }
  let(:error) { StandardError.new 'mine' }

  context 'expect_any_instance_of' do
    before do
      expect_any_instance_of(described_class).to receive(:my_method).and_raise(error)
    end

    it 'fails' do
      h.destroy!
      expect{h.my_method}.to raise_error(error)
    end
  end

  context 'instance stub' do
    before do
      expect(h).to receive(:my_method).and_raise(error)
    end

    it 'works' do
      h.destroy!
      expect{h.my_method}.to raise_error(error)
    end
  end
end

result on rspec-mocks 3.9.1:
Finished in 0.0497 seconds (files took 0.82981 seconds to load)
2 examples, 0 failures

result on rspec-mocks 3.10.1:
Failures:

  1) Human expect_any_instance_of fails
     Failure/Error: expect{h.my_method}.to raise_error(error)

       expected #<StandardError: mine>, got #<ArgumentError: Cannot proxy frozen objects, rspec-mocks relies on proxies for method stubbing and expectations.> with backtrace:
         # ./spec/models/human_spec.rb:14:in `block (4 levels) in <top (required)>'
         # ./spec/models/human_spec.rb:14:in `block (3 levels) in <top (required)>'
     # ./spec/models/human_spec.rb:14:in `block (3 levels) in <top (required)>'

Finished in 0.04758 seconds (files took 0.87952 seconds to load)
2 examples, 1 failure

Failed examples:

rspec ./spec/models/human_spec.rb:12 # Human expect_any_instance_of fails

Probably warrants it's own (new) issue? Kind of niche, but it's now a major headache to test certain kinds of functionality in active record (I actually haven't yet figured out the work around for my particular case).

The activerecord models are not really frozen, they override that method and delegates it to the attributes, which are frozen when the record is destroyed. https://github.com/rails/rails/blob/914caca2d31bd753f47f9168f2a375921d9e91cc/activerecord/lib/active_record/core.rb#L618
def frozen?
  @attributes.frozen?
end

I'm not sure if there's a better way to check the real frozen status for the model itself.

The activerecord models are not really frozen, they override that method and delegates it to the attributes, which are frozen when the record is destroyed. https://github.com/rails/rails/blob/914caca2d31bd753f47f9168f2a375921d9e91cc/activerecord/lib/active_record/core.rb#L618
def frozen?
  @attributes.frozen?
end

I'm not sure if there's a better way to check the real frozen status for the model itself.

Feel free to raise that as a bug with the Rails team, if an object isn't actually frozen it probably shouldn't return that it is.

Feel free to raise that as a bug with the Rails team, if an object isn't actually frozen it probably shouldn't return that it is.

I don't mind raising this with rails, but does any really think they're going to change their interface for this? Seems like there are some pretty simple alternatives here in rspec such as just catching the FrozenError (which looks like it was always raised in these cases) and re-raising with the appropriate message.

I don't mind raising this with rails, but does any really think they're going to change their interface for this? Seems like there are some pretty simple alternatives here in rspec such as just catching the FrozenError (which looks like it was always raised in these cases) and re-raising with the appropriate message.

They might not be aware they are breaking an expected Ruby behaviour, they might have a reason for it being the way it is, I don't know, but currently these objects don't behave as they should by the standards Ruby sets, its worth finding out if this is blocking you, equally If you'd like to create an alternative implementation for this warning feel free.

They might not be aware they are breaking an expected Ruby behaviour, they might have a reason for it being the way it is, I don't know, but currently these objects don't behave as they should by the standards Ruby sets, its worth finding out if this is blocking you, equally If you'd like to create an alternative implementation for this warning feel free.

#1401 for what it's worth

#1401 for what it's worth


[CosmosDB] Emulator release 2.14.20

@sajeetharan
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Add unit testing for HasRecvClientErrorWithStatus.

    Add unit test for IgnoreDetails.

      * (M) chk/chk.go
      * (M) chk/chk_test.go
        - Fix implementation of IgnoreDetails to ensure that it allows
          details received from the server to be ignored rather than
          solely from the client.
        - Add unit test.

    Ignore details when chk.AllowUnimplemented() is specified.

      * (M) chk/chk.go
        - when chk.AllowUnimplemented() is specified, details of the error
          (which hasn't been explcitly implemented) are still checked -
          change the implementation to explicitly not require details to
          match in these cases.
      * (M) chk/chk_test.go
        - Add unit testing for HasRecvErrorWithStatus.

@deep-gajjar5 @sthesayi Could you PTAL/approve here please?


forbidden: User "system:serviceaccount:kube-system:default" cannot get namespaces in the namespace "default

Following the instruction in the documentation when running
helm install --name myfn fn
I get the error forbidden: User "system:serviceaccount:kube-system:default" cannot get namespaces in the namespace "default
I solved running these commands to my k8s cluster:
kubectl create serviceaccount --namespace kube-system tiller
kubectl create clusterrolebinding tiller-cluster-rule --clusterrole=cluster-admin --serviceaccount=kube-system:tiller
kubectl patch deploy --namespace kube-system tiller-deploy -p '{"spec":{"template":{"spec":{"serviceAccount":"tiller"}}}}'
if confirmed should be added to the documentation

PS C:\WINDOWS\system32> kubectl patch deploy --namespace kube-system tiller-deploy -p '{"spec":{"template":{"spec":{"serviceAccount":"tiller"}}}}'
I am getting below error
kubectl : Error from server (BadRequest): invalid character 's' looking for beginning of object key string

thanks all, I had the same and was able to fix the issue by following the doc https://docs.helm.sh/using_helm/#tiller-and-role-based-access-control

@postak were you able to resolve the issue with the links mentioned in the thread?

Yes, with these commands
kubectl create serviceaccount --namespace kube-system tiller
kubectl create clusterrolebinding tiller-cluster-rule
--clusterrole=cluster-admin --serviceaccount=kube-system:tiller
kubectl patch deploy --namespace kube-system tiller-deploy -p
'{"spec":{"template":{"spec":{"serviceAccount":"tiller"}}}}'
Il giorno ven 17 ago 2018 alle 19:03 Peter Jausovec <
<EMAIL_ADDRESS>ha scritto:

@postak https://github.com/postak were you able to resolve the issue
with the links mentioned in the thread?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fnproject/fn-helm/issues/21#issuecomment-413928528,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAnPtsExq6_UPnQZX-ORTtMwHfC1OMqlks5uRvd8gaJpZM4TM9q4
.

--
-- Sent from my StarTAC

Perfect. Since this was resolved and it's not really related to Fn, I'll close it. Feel free to open a new issue if you ran into issues. Thanks!

Worked here as well, thanks guys

kubectl patch deploy --namespace kube-system tiller-deploy -p '{"spec":{"template":{"spec":{"serviceAccount":"tiller"}}}}'
Error from server (BadRequest): invalid character 's' looking for beginning of object key string

@rnkhouse if the problem you're seeing is related to Fn, please open a separate issue and explain what you're seeing. This issue is closed.

This is RBAC realted issue itseems. It worked for me with the above commands.

helm init --upgrade --service-account tiller worked for me

Closing one. Please reopen if necessary or if you see the following problem with the latest chart.

kubectl patch deploy --namespace kube-system tiller-deploy -p '{"spec":{"template":{"spec":{"serviceAccount":"tiller"}}}}'
Error from server (BadRequest): invalid character 's' looking for beginning of object key string

Try this :
 $jsondata=  '{"spec":{"template":{"spec":{"serviceAccount":"tiller"}}}}'| ConvertTo-Json
kubectl patch deploy --namespace kube-system tiller-deploy -p $jsondata

Why is this is not part of the Helm documentation?!

kubectl create serviceaccount --namespace kube-system tiller
kubectl create clusterrolebinding tiller-cluster-rule --clusterrole=cluster-admin --serviceaccount=kube-system:tiller
kubectl patch deploy --namespace kube-system tiller-deploy -p '{"spec":{"template":{"spec":{"serviceAccount":"tiller"}}}}'

@loxal, that's totally a patch worth making :)

kubectl patch deploy --namespace kube-system tiller-deploy -p '{"spec":{"template":{"spec":{"serviceAccount":"tiller"}}}}'
Error from server (BadRequest): invalid character 's' looking for beginning of object key string

Try this :
 $jsondata=  '{"spec":{"template":{"spec":{"serviceAccount":"tiller"}}}}'| ConvertTo-Json
kubectl patch deploy --namespace kube-system tiller-deploy -p $jsondata

@gopimails @rnkhouse
I had this same issue, you need to escape the double quotes characters on the json:
kubectl patch deploy --namespace kube-system tiller-deploy -p '{\"spec\":{\"template\":{\"spec\":{\"serviceAccount\":\"tiller\"}}}}'

I solved running all of these commands in given sequence to my k8s cluster:
kubectl create serviceaccount --namespace kube-system tiller
kubectl create clusterrolebinding tiller-cluster-rule --clusterrole=cluster-admin --serviceaccount=kube-system:tiller
kubectl patch deploy --namespace kube-system tiller-deploy -p '{"spec":{"template":{"spec":{"serviceAccount":"tiller"}}}}'
helm init --upgrade --service-account tiller
And then you can run your helm command like:
helm install --name postgres stable/postgresql --set postgresqlPassword=secretpass,postgresqlDatabase=cdap

The latest v2.15 HELM is finally compatible with K8s v1.16.2.

$ kubectl patch deploy --namespace kube-system tiller-deploy -p '{"spec":{"template":{"spec":{"serviceAccount":"tiller"}}}}'
produces
Error from server (NotFound): deployments.apps "tiller-deploy" not found
and
helm init --upgrade --service-account tiller
produces
Error: unknown flag: --upgrade
I´m running an automanaged cluster on Digital Ocean. Tiller has been installed through the Gitlab Dashboard after connecting to my cluster.
Appreciate any help

kubectl --namespace kube-system create serviceaccount tiller;
kubectl create clusterrolebinding tiller --clusterrole cluster-admin --serviceaccount=kube-system:tiller;
helm init --service-account tiller --upgrade;
sleep 30;
kubectl get po --all-namespaces;
helm list;

I had to escape double quotes and also use " instead of '.
kubectl patch deploy --namespace kube-system tiller-deploy -p "{"spec":{"template":{"spec":{"serviceAccount":"tiller"}}}}"

Isn't tiller gone with helm 2?
A Gentle Farewell to Tiller

@miraj-godha-guavus - Your suggested worked for me.


separate signatures for ModInt

Signed-off-by: fredchenbj<EMAIL_ADDRESS>What problem does this PR solve?
Separate signatures for ModInt.  See tidb pcp https://github.com/pingcap/tidb/issues/13978

@breeswish  @lonng PTAL

Please fix conflicts, thanks!

/run-all-tests

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: breeswish:x: fredchenbjYou have signed the CLA already but the status is still pending? Let us recheck it.

@fredchenbj Hi, would you like to resolve these conflicts? Thanks!

I'm going to close this PR since it hasn't been updated for a long time. feel free to reopen if you want to continue with it. thank you for your contribution.


HDDS-9720. XceiverServerRatis.triggerPipelineClose throws NPE.

What changes were proposed in this pull request?
To reproduce, run TestSecureContainerServer.testClientServerRatisGrpc() (although it will pass) and then search NPE in the log.
Caused by: java.lang.NullPointerException
	at org.apache.hadoop.ozone.container.common.transport.server.ratis.XceiverServerRatis.triggerPipelineClose(XceiverServerRatis.java:715)
	at org.apache.hadoop.ozone.container.common.transport.server.ratis.XceiverServerRatis.handleApplyTransactionFailure(XceiverServerRatis.java:842)
	at org.apache.hadoop.ozone.container.common.transport.server.ratis.ContainerStateMachine.lambda$applyTransaction$11(ContainerStateMachine.java:968)
	at java.util.concurrent.CompletableFuture.uniApply(CompletableFuture.java:616)

What is the link to the Apache JIRA
HDDS-9720
How was this patch tested?
Run TestSecureContainerServer.testClientServerRatisGrpc() and search NPE.

Thanks @szetszwo for the fix.

@adoroszlai , thanks a lot for reviewing and merging this!


Very slow navgation in editor

Since 0.9.0 the navigation is very slow sometimes. For example, when the cursor moves inside a string (between apostrophes if it matters) the whole UI gets stuck for seconds and "Atom Helper" process stays at 100%.
Tested with 0.8.7 and 0.8.6 and it works fine.

querying the type on cursor position change will be debounced in the next version. it is indeed a performance issue.

this hasn't been fixed right? I just saw that the new version 0.10 is out but I still have huge lags while typing or navigating in the editor.

In my specific case, it looks fixed. Tried the same file that gave me headaches before (10 seconds lag sometimes) and the cursor is quick. The tooltip appears after a while, instead of following the cursor all the time, so maybe it is debounced now.
Didn't find the specific commit for this, though.

Nope. Spoke too soon. It is still very very slow sometimes with CPU hovering at 100% for many seconds. Reverting to 0.8.7 (Atom 1.2.4) always fixes the problem.

I'm also having the same issue. Is there an Atom or ternjs version that I can revert back to till this issue is fixed?

It is written above: 0.8.7
apm install<EMAIL_ADDRESS>The only issue I have with this one is that it sometimes makes ternjs to jump to 100% and it needs a server restart (from Packages/Atom Ternjs/Restart server). Also, atom 1.2.x crashes with (old) ternjs, so I'm using 1.3.0-beta6.

I've read so many things that I've must have skipped it somehow. Damn.
Thanks, it's fixed now.

@tststs: is there any roadmap when this will be fixed? Since 0.8.7 the plugin is unusable, except on very simple files. Unfortunately I've attempted to understand what caused this behaviour but you've shuffled quite a lot of code after 0.8.7 so I've failed.

No roadmap. When i find time i will investigate the purge problem.
Since 0.8.7 tern-lint is back in the game. So this might be a performance regression. Is lint activated?
These freezes and massive purge calls normally only exist, if you include a whole lot of files via loadEagerly (e.g. node_modules or minified js files).
On the other hand, maybe it has something to do with some of the change made by Tern itself since then.

How big in numbers is the project?
What's the configuration via .tern-project?
Are there examples you can provide, so i can reproduce the problem?

Greetings.

Here's the .tern-project file:
{
  "ecmaVersion": 6,
  "libs": [],
  "plugins": {
    "node": {},
    "doc_comment": {
      "fullDocs": true
    }
  }
}

All the projects have the same tern config. They are pretty small, like 5-8 dependencies and 3-4 source files.
"dependencies": {
    "bluebird": "^3.0.6",
    "bunyan": "^1.5.1",
    "express": "^4.13.3",
    "lodash": "^3.10.1",
    "pixl-xml": "^1.0.4",
    "querystring": "^0.2.0"
  }

Ok, keep me updated on this one.
Greetings.

Any word on this, the project is extremely cool, but just slightly too laggy to be useful. Is it possible to somehow push the autocompletions onto a webworker or something to that affect?

@ericwooley +1
I stopped using PhpStorm and moved into Atom the moment I've discovered this package, so I also find this package great and extremely useful, but it's a little slow (I use 0.8.7, it's faster than the latest version). I know that this is not a job you get paid for, but it'd be great to see some improvements.

Closing this in favor of #193.


[skip ci] Doc: fix org change that link dead for discuss

fix #ISSUE_Number

Change logs
As cloudberry the org changed to apache now, most of the links can redirect but for the discuss such as orgs/cloudberry/discuss can not, this PR fix that case.
you can try:
link dead:  https://github.com/orgs/cloudberrydb/discussions/categories/proposal
link fixed:    url: https://github.com/apache/cloudberrydb/discussions/categories/proposal
for the case it may  graduate from apache some day so keep the urls can redirect first.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:

[ ] Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
[ ] Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
[ ] Learn the coding contribution guide, including our code conventions, workflow and more.
[ ] List your communication in the GitHub Issues or Discussions (if has or needed).
[ ] Document changes.
[ ] Add tests for the change
[ ] Pass make installcheck
[ ] Pass make -C src/test installcheck-cbdb-parallel
[ ] Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

Hi @yihong0618, thank you! There is already a PR #696 for the link changes. Please feel free to rebase your commit once #696 is merged.
BTW, welcome to take the git commit template to amend your commit title and body. Thanks again!

@tuhaihe the issue created is dead in cloudberry it will link a 404 page, maybe we can merge this two pull requests

@tuhaihe the issue created is dead in cloudberry it will link a 404 page, maybe we can merge this two pull requests

Agreed. Welcome to rebase to trigger the CI (now can use the tag ‘skip ci ‘ to skip the checks) then merge it.

Hi @yihong0618 welcome to resolve the conflicts.
Also please amend your commit messages per the template - https://github.com/apache/cloudberry/blob/main/.gitmessage, thanks.

done

Hi @edespino add the tag skip ci to the PR title, but seems that cannot skip the build. FYI.

@tuhaihe - I believe the [skip ci] will work but it has be in the PR title when the PR is created. Please give it a try with the next PR which does not need a build. You can also test it with a draft PR and then close it.


Provision to prevent dropdown from redirecting

Select one ...  (check one with "x")
[ ] bug
[x] feature request
[] enhancement

Expected behavior
When a dropdown option is clicked redirection should not happen.
There could be a property to prevent dropdown item click to redirect.
The documentation clearly mentions the usage of dropdown vs. select box, but we have a requirement where we want a dropdown (menu), clicking the items open modal box.
It would be great to use the dropdown instead of a custom button + UL/LI menu.
Actual behavior
The default behavior of dropdown item click is to navigate away from current view state.
Reproduction of behavior
Can be reproduced by pulling in clarity-seed project and using a clr-dropdown.
Environment details

Angular version: 2.0.X
Angular 2.4.1

Clarity version:
Using latest version of clarity.

OS and version:
macOS Sierra 10.12.2 (16C67)

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Sorry but I am unable to understand the problem correctly. Can you post the markup of the dropdown that you are using?
Are you saying that the page redirects after you click on the dropdown item? If yes, are you using anchor tags for dropdown items? If yes, you could also use buttons and that way the page won't redirect:

@adityarb88 - Yes that works for me.
Thank you for the quick response, appreciate the help.
Closing the ticket based on your inputs.


column major

Hi
Is your matrix math column or row major ordering? I was wrangling with sony's vectormath library and while the math is good the api is really terrible [in my opinion]. You seem to have a reasonable api with neon and sse support. Do your matrices work with column major or row major?
Also do you provide a cmake build?

From the graphene_matrix_t API reference:

The matrix is treated as row-major, i.e. it has four vectors (x, y, z, and w) representing rows, and elements of each vector are a column

But when converting from and to floating point C arrays the memory layout is compatible with column-major interpretations like GL or DirectX.
I don't use or know CMake, so I don't have a CMake build. I'm not formally against having a parallel CMake build, but I would not be able to maintain it myself, so I would not be able to fix it if/when it breaks.


Move build retrieval to just in time

Using v1 api would cause the build list to be generated twice, once during the initial creation of the class (in the constructor) and a second time during setPostData.  This is wasteful and causes issues because the v1 post data hasn't been set properly during the first time through.

Thank you!


Broken URL for Public Health Scotland

Broken URL: #https://www.opendata.nhs.scot/

Closing as false positive


Remove winston for logging (not web compatible)

Winston is nodejs only.
This changes our logging to match what the Python extension did (much simpler).
It does however maintain the trace decorators that Don added.

Telemetry and localization also had to be web specific (used by logging) so moved those too.
Most of the changes are in localize.ts and the logging code. Everything else is just name changes.

I love our tests 🥇 . Windows test failed for interrupt because the daemon path couldn't be constructed for the interrupt daemon module. Root cause - path-browserify won't join rooted paths. It just drops the path altogether.


knightos-mkrom: 1.0.2 -> 1.0.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/mkrom/versions.
meta.description for knightos-mkrom is: "Packages KnightOS distribution files into a ROM"
meta.homepage for knightos-mkrom is: "https://knightos.org/"
meta.changelog for knightos-mkrom is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

directory tree listing: https://gist.github.com/1450a9064e58f10710516afb610451db

du listing: https://gist.github.com/71aa14047e6da836d52633e93790433d

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
0 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
knightos-mkrom

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/x3l75yhmlicaifqk8spgwgxaxjkcyx79-mkrom-1.0.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A knightos-mkrom https://github.com/r-ryantm/nixpkgs/archive/2fb151e24f8219d4ebf613cc43b25ac2bbdbe1df.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/x3l75yhmlicaifqk8spgwgxaxjkcyx79-mkrom-1.0.3
ls -la /nix/store/x3l75yhmlicaifqk8spgwgxaxjkcyx79-mkrom-1.0.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

1 package built:

knightos-mkrom

Maintainer pings
cc @siraben for testing.

Result of nixpkgs-review pr 102603 1

1 package built:

knightos-mkrom

@danieldk


Question : Messages validation for fieldGroup ?

Hello,
I have a rules validation with a "fieldGroup" who is working fine, and I want to add a specific message validation.
I tried the same pattern as the rule, but it's not working ?
I don't find the information into the documentation, this is not supported ?
Here is my code :
const validationRules = {
  fieldGroup: {
    plainPassword: {
      name: {
        first: {
          minLength: ({value}) => value.length >= 6,
          capitalLetter: ({ value }) => /[A-Z]/.test(value)
        }
      }
    }
  },
  name: {
    username: {
      minLength: ({value}) => value.length >= 3
    }
  }
}
const validationMessages = {
  fieldGroup: {
    plainPassword: {
      name: {
        first: {
          missing: 'Please provide the first password',
          invalid: 'The first password is invalid',
          rule: {
            minLength: 'First Password must be at least 6 characters long',
            capitalLetter: 'First Password must include at least one capital letter'
          }
        }
      }
    },
  },
  name: {
    username: {
      rule: {
        minLength: 'Username must be at least 3 characters long'
      }
    }
  }
}

Thanks for the help ! :)

Hey, @Gus19. Thanks for reaching out.
I'm afraid targeting fields based on their field group is not supported when providing validation messages. The validation messages object supports three root-level keys (selectors):

name
type
general

These are described in the Validation messages section of the documentation.
If you wish to have a unique validation message for a field based on its field group, I suggest you provide a custom message resolve function and decide on the validation message based on props:
const validationMessages = {
  name: {
    first: {
      invalid({ fieldProps }) {
        // Look the properties of `fieldProps` and return conditional error messages.
      }
    }
  }
}

Thanks for your response. I will continue to work with name for specifics messages :)