Expired auth notification is not dismissed after (re)sign-in

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce

Sign in with Microsoft auth provider to your account (in vscode.dev)
Close browser and wait some time (e.g. 24 hours)
Reopen the same URL and invoke code that requests authentication
You will be presented with expired auth (signed out) notification at the bottom:

Invoke the sign-in flow again

Actual Behavior
The signed out notification is not dismissed - neither during the sign-in process, nor at the successful completion of the sign-in.
During sign-in:

After successful sign-in:

Expected Behavior
Sign-out notification to be dismissed automatically once sign-in process begins.

Unfortunately, the showErrorMessage API that I use does not have a way to dismiss a notification at will. I would need something like that to implement this.

I use does not have a way to dismiss a notification at will. I would need something like that to implement this.

We will not implement this. Notifications are there for users to be seen (and dismissed). Steeling attention from a user with a notification just to hide it while they are reading/acting on it isn't something we will do.
The extension shouldn't use the notification API to begin with but if you find that's this is a common issue for auth providers than its API needs to cater for this so that VS Code can build the best UI for this case

The extension shouldn't use the notification API to begin

@jrieken what should it use instead to notify the user that their log in state was lost?

Idk - my point is that this case should be handled by VS Code not by an extension


Support for multiple customDistributionURLs for test clusters

Is your feature request related to a problem? Please describe.
When we run the BWC tests on the bundle distribution level, we want to set up the test cluster with two bundle URLs with different versions from our distribution build pipeline. However, currently the customDistributionURL gradle property only supports one URL now. https://github.com/opensearch-project/OpenSearch/pull/2420
Furthermore, the framework doesn't check whether the version is align with the version we specified when initialize the test cluster. For example, the BWC tests for AD plugin when we set up the cluster with version
testClusters {
        "${baseName}$i" {
            testDistribution = "ARCHIVE"
            versions = ["1.1.0", opensearch_version]
            numberOfNodes = 3
        }
}

We could still pass whatever version of customDistributionURL into the framework and it would resolve this custom URL without making sure versions are same.
https://github.com/opensearch-project/OpenSearch/blob/6a56b39646737aa31558142b41a577426eb89126/buildSrc/src/main/java/org/opensearch/gradle/DistributionDownloadPlugin.java#L198-L203
Describe the solution you'd like
We have a different property called customDistributionURLs and we could pass either one or multiple custom distribution URLs separated by comma into it.
For example:
-PcustomDistributionUrls="https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.6/latest/linux/x64/tar/dist/opensearch/opensearch-1.3.6-linux-x64.tar.gz,https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/2.4.0/latest/linux/x64/tar/dist/opensearch/opensearch-2.4.0-linux-x64.tar.gz"

With the test cluster set up as
testClusters {
        "mycluster" {
            testDistribution = "ARCHIVE"
            versions = ["1.3.6", "2.4.0"]
            numberOfNodes = 3
        }
}

This should also follow the convention as the first URL link passed should be the version that the test cluster started with and should be able to transition to following versions sequentially by calling the goToNextVersion() on node.
Additional context
Add any other context or screenshots about the feature request here.

Had offline discussion with @adnapibar, do you have anything to add here?

I was thinking to add a loop and conditional check to add each of the URL respectively.
Maybe like
Object customDistributionUrls = project.findProperty("customDistributionUrls");
if (customDistributionUrls != null) {
    for (String customDistributionUrl : customDistributionUrls.toString().split(",")) {
        if (customDistributionUrl.contains(setup_version)) {
            addIvyRepo(project, DOWNLOAD_REPO_NAME, customDistributionUrl, FAKE_IVY_GROUP, "");
            addIvyRepo(project, SNAPSHOT_REPO_NAME, customDistributionUrl, FAKE_SNAPSHOT_IVY_GROUP, "");
        }
    }
} else ...

So when we have test cluster set up as version ["1.3.6", "2.4.0"], and add new property when running
-PcustomDistributionUrls="https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.6/latest/linux/x64/tar/dist/opensearch/opensearch-1.3.6-linux-x64.tar.gz,https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/2.4.0/latest/linux/x64/tar/dist/opensearch/opensearch-2.4.0-linux-x64.tar.gz"

the first version 1.3.6 will get into the distributionDownloadPlugin class and add the distribution of the first URL; when processing the second version 2.4.0; the second URL would be added to download repo.
The problem here is I don't know how we could access the setup_version in the conditional check above.
Do you guys have any other ideas?

@saratvemulapalli @dblock @adnapibar Do you have any suggestion here?

Currently the customDistributionUrl represents the URL of a single artifact. Do you think we can split it into two parts to construct the Ivy repo?

base url e.g. https://artifacts.opensearch.org
pattern layout e.g. /core/opensearch/[revision]/[module]-min-[revision](-[classifier]).[ext]

This way the version can be filled in from the list of supplied versions in the cluster config into the pattern.

Adding to @adnapibar's suggestion, the DistributionDownloader needs to get smarter (or less smart depending on how we look at it), and support the feature of "given version X, I can download it". I would leave the custom URL alone.


[Issue]: With openApiV2, BigInt cannot be serialized

Description
We have one operation "CreateCartEntry". The request body is "OrderEntry". This is the spec:
post:
      tags:
      - Cart Entries
     ....
      requestBody:
        content:
          application/xml:
            schema:
              $ref: '#/components/schemas/OrderEntry'
          application/json:
            schema:
              $ref: '#/components/schemas/OrderEntry'
        required: true

"OrderEntry" has property quantity which is init64:
 OrderEntry:
      type: object
      properties:
        ...
        quantity:
          type: integer
          description: Quantity number of items in order entry
          format: int64

My code to call the operation is this:
const { data, error } = await operations.mutate({
        operationName: 'occ/CreateCartEntry',
        input: {
          ...
          fields: 'DEFAULT',
          postBaseSiteIdUsersUserIdCartsCartIdEntriesInput: {
            quantity: 1,
            product: { code: productCode },
          },
        },
      });

With openApiV2, I get error of "Do not know how to serialize a BigInt":

Reproduction
check the description

Identified the issue, but still investigating how this should be fixed.
https://github.com/Urigo/graphql-mesh/issues/6054


Cannot run cli

I installed twint, it has a cli. When I drop into the nix-shell and run twint, it says twint: command not found
❯ twint
bash: twint: command not found

❯ python3
Python 3.8.5 (default, Sep 10 2020, 08:51:33)
[Clang 7.1.0 (tags/RELEASE_710/final)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import twint
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'twint'
>>>

shell.nix
let
  mach-nix = import (builtins.fetchGit {
    url = "https://github.com/DavHau/mach-nix";
    ref = "refs/heads/master";
    rev = "3acbfc2ebd0b826cd046925493714a5e2f146d73";
  }) {};
in
mach-nix.buildPythonPackage {
 src = "https://github.com/twintproject/twint/tarball/ae5e7e1189be1c";
 overridesPre = [(
    pySelf: pySuper: {
      dateutil = null;
    }
 )];
}

I solved by defining my python package as a variable and giving it inside propagatedBuildInputs and it worked.
{ lib, buildPythonPackage, docopt }:
let

	mach-nix = import (builtins.fetchGit {
		url = "https://github.com/DavHau/mach-nix";
		ref = "refs/heads/master";
		rev = "3acbfc2ebd0b826cd046925493714a5e2f146d73";
	}) {};

	twint = mach-nix.buildPythonPackage {
		src = "https://github.com/twintproject/twint/tarball/ae5e7e1189be1c";
		overridesPre = [(
			pySelf: pySuper: {
				dateutil = null;
			}
		)];
	};

in buildPythonPackage rec {
	pname = "packagename";
	version = "0.0.1";

	src = ./.;
	doCheck = false;
	propagatedBuildInputs = [
		docopt
		twint
	];

	meta = with lib; {
		description = "";
		homepage = "";
		license = licenses.mit;
		# maintainers = [ maintainers.ihsanturk ];
	};

}

I guess the problem is that you're executing nix-shell on a package derivation instead of a shell derivation.
To use your package in nix-shell, you need to wrap it in a mkShell like:
pkgs.mkShell {
  buildInputs = [ yourPackage ];
}

Or just simply use mach-nix.mkPythonShell and pass your package via packagesExtra


Translations support

Hi!
This tool looks awesome!
If it's possible, it would be very nice if all the hard-coded text would be translatable (lang files / json translations).

Translations added. More info in the readme. Update to 1.1.0 version. Regards.


Sequential subjects

Summary of Changes

Implements a subject set utility that provides a basic CLI to manage OW ships. Features include 1) listing subject sets available to current active user, 2) ability to activate/deactivate subject sets, 3) generate a linked list within a subject set provided pageNumber is defined for each subject
Ensures default workflow, project.configuration.default_workflow is used in place of the ambiguous project.links.workflows[0]

Linked List Implementation Details
The subjectFactory keeps track of the current_subject. If current_subject.metadata.nextSubjectId exists, then the next subject is fetched by that ID; otherwise, a random unseen subject is fetched. As is, subjects are only "cached" one-at-a-time. To do: Experiment with creating linked list with arrays of prev and next IDs to cache in batches greater than 1.

@itsravenous: I think this PR is finally ready to review. Lemme know if you run into any problems.


[MAINTENANCE] Update Python versions and other

It's time to do some maintenance.

Update Python versions
Check if any other packages are outdated or needs to be updated
Test scripts and make sure they run
Look into adding a docker container for testing and verifying the setup

Update the default python flake8 settings to include new plugins available to the linter. Further, fix SublimeText settings file such that it firstly attempts to use flake8 located in local directory, then it falls back on global / pipx flake8.
See https://github.com/DmytroLitvinov/awesome-flake8-extensions for flake8 extensions to add.
Just to name a few:

flake8-bugbear
tryceratops
flake8-pie
flake8-useless-asserts
etc


What Code editor or IDE does Flynn team use for development?

Hi All
I am new to Flynn and new to Go. I have followed Flynn's official guide of setting up development environment using Vagrant and Packer. Things went very smoothly and my one-node cluster is up. However, the official guide doesn't mention what code editor or ide the team is using and is pre-built into the development environment. I looked into Packer's template file and install.sh script but don't find any relevant information about it. Does the team just use Vim for most of the development work? That seems pretty brave! If this is the case, does Flynn's contributing guideline encourage using gocode, go oracle toolchain to make contributed codes less error-prone?
Thanks.
Cai

The entire team uses Vim currently, but there's no need to advocate for a specific editor/plugins, Flynn/Go is editor-agnostic :)


Error on building

is glut or freeglut a dependence ?
[ 14%] Built target glutil
[ 14%] Building C object glsdk/CMakeFiles/freeglut.dir/freeglut/src/freeglut_callbacks.c.o
In file included from /home/joilnen/ogre3d_devel/gltut/glsdk/freeglut/src/freeglut_callbacks.c:29:
/home/joilnen/ogre3d_devel/gltut/glsdk/freeglut/src/freeglut_internal.h:32:14: fatal error: config.h: No such file or directory
32 | #    include "config.h"
|              ^~~~~~~~~~
compilation terminated.
make[2]: *** [glsdk/CMakeFiles/freeglut.dir/build.make:76: glsdk/CMakeFiles/freeglut.dir/freeglut/src/freeglut_callbacks.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1786: glsdk/CMakeFiles/freeglut.dir/all] Error 2
make: *** [Makefile:91: all] Error 2

freeglut is built as part of the project. Are you on Linux?
Then likely this command failed:
https://github.com/paroj/gltut/blob/2f385318a2fd6d2081639e457bf20b8921ff7bd9/glsdk/CMakeLists.txt#L8

yes on linux, archlinux dist

can you run that command manually in glsdk/freeglut

works
sh ./configure
joilnen@sutherland freeglut]$ sh ./configure
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /usr/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking for gcc... gcc
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
...
config.status: creating progs/demos/One/Makefile
config.status: creating progs/demos/shapes/Makefile
config.status: creating progs/demos/smooth_opengl3/Makefile
config.status: creating progs/demos/spaceball/Makefile
config.status: creating src/Makefile
config.status: creating config.h
config.status: config.h is unchanged
config.status: executing depfiles commands
[joilnen@sutherland freeglut]$

try building again now

I got this error now
[joilnen@sutherland gltut]$ cmake --build build/
[  2%] Built target glload
[  9%] Built target glimg
[ 14%] Built target glutil
/usr/include/c++/11.2.0/bits/stl_vector.h:1123: std::vector<_Tp, _Alloc>::reference std::vector<_Tp, _Alloc>::front() [with _Tp = cmGccStyleDependency; _Alloc = std::allocator; std::vector<_Tp, _Alloc>::reference = cmGccStyleDependency&]: Assertion '!this->empty()' failed.
make[2]: *** [glsdk/CMakeFiles/freeglut.dir/build.make:477: glsdk/CMakeFiles/freeglut.dir/depend] Aborted (core dumped)
make[1]: *** [CMakeFiles/Makefile2:1785: glsdk/CMakeFiles/freeglut.dir/all] Error 2
make: *** [Makefile:91: all] Error 2

you probably have to either update freeglut manually or use an older compiler


some regression for benchmark on stable diffusion v1.5

Dear,
I've run the llm_bench\python to test stable diffusion v1.5, and found some regression between different ov packages, like below,

2023.3->8.73s

2024.0->10.65s

2024.1->9.18s
the parameters is 20 steps, 512x512, the others are the same with prompt/stable-diffusion.jsonl file.
the command is:

python benchmark.py -d GPU --model "C:\AIGC\openvino\models\stable-diffusion-optimum-sdv1_5" --prompt_file "prompts/stable-diffusion.jsonl" -n 1

the platform is MTL U9 185 iGPU with 32GB.
Thanks a lot,

who can please help take a look at?

Hi @aoke79, I was not able to reproduce the regression. I got 11.6s with OV 2023.3 and 10.7s with OV 2024.1 on my MTL U7 165H w/ 16GB RAM. BTW, did you run stable diffusion with llm_bench\python\benchmark.py? I think it's not for stable diffusion but for LLM.

2023.3 --> 9.37s
2024.0 --> 11.56s
Is that correct?

@aoke79 Continuous improvements are observed on master branch, can you try latest nightly and see if the performance is better  than 23.3 now?
python -m pip install --upgrade pip
pip install --pre -U openvino --extra-index-url https://storage.openvinotoolkit.org/simple/wheels/nightly

Thanks feedback, and I've udpated the OV by the command below, the perf is better, about 8.77s (warm up), 7.24s (1st run).
python -m pip install --upgrade pip
pip install --pre -U openvino --extra-index-url https://storage.openvinotoolkit.org/simple/wheels/nightly


Error for Criteria/Grader csv download from graders view

I noticed this error when trying to download a csv file from the graders view and selecting Criteria/Grader map CSV format. Seems to be coming from the download_grader_criteria_mapping function in graders_controller.
Backtrace:
app/controllers/graders_controller.rb:143:in block in download_grader_criteria_mapping'
app/controllers/graders_controller.rb:142:in download_grader_criteria_mapping'
ActiveRecord::StatementInvalid (PG::UndefinedTable: ERROR:  missing FROM-clause entry for table "users"
LINE 1: ...iations".* FROM "criterion_ta_associations" WHERE "users"."t...
^
: SELECT "criterion_ta_associations".* FROM "criterion_ta_associations" WHERE "users"."type" IN ('Ta') AND "criterion_ta_associations"."criterion_type" = 'RubricCriterion' AND "criterion_ta_associations"."criterion_id" IN (14, 13, 11, 12, 8, 9, 15, 10)):
app/controllers/graders_controller.rb:143:in block in download_grader_criteria_mapping'
app/controllers/graders_controller.rb:142:in download_grader_criteria_mapping'

We can't reproduce this one. @melneubert do you remember anything else about when you encountered this bug?

Unfortunately I don't. Is it possible it could have been something related to my setup/database? (If so, sorry for reporting this)

That's okay.  I just thought I would check.
We wil close this for now since we can't reproduce.


Footer gets pulled up on menu

Describe the bug
A clear and concise description of what the bug is.
clicking on menu is pulling the footer up the menu
Expected behavior
footer should not be pulled above
Screenshots
If applicable, add screenshots to help explain your problem.

Fixed. 👍🏻

footer still changes its position when clicking the menu


Te11.2 update

Addressed
https://github.com/openconfig/featureprofiles/pull/1154/files
https://github.com/openconfig/featureprofiles/pull/1144/files

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 57.219%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1181

Relevant Lines:
2064

💛  - Coveralls

I think it's good to add another pair of eyes for review so that I don't miss anything. @LimeHat can you also help do a quick review (focus on aligning with the README)? Thanks.

Currently all traffic is generated with a single src. IP & a single dst. IP
https://github.com/openconfig/featureprofiles/blob/9e4444ebf3fe1b4dcc4d7829ba329329730f1617/feature/gribi/ate_tests/backup_nhg_multiple_nh_test/backup_nhg_multiple_nh_test.go#L341
Would it make sense to use the full dst subnet (/24) for LB purposes? Two primary next-hops are currently being provisioned with 80/20 weights
https://github.com/openconfig/featureprofiles/blob/9e4444ebf3fe1b4dcc4d7829ba329329730f1617/feature/gribi/ate_tests/backup_nhg_multiple_nh_test/backup_nhg_multiple_nh_test.go#L299
https://github.com/openconfig/featureprofiles/blob/9e4444ebf3fe1b4dcc4d7829ba329329730f1617/feature/gribi/ate_tests/backup_nhg_multiple_nh_test/backup_nhg_multiple_nh_test.go#L38-L40
(also const "dstPfx" on L40 is currently unused in ATE test)

@xw-g  @LimeHat  appreciate the feedback. Manan is off, so I or someone else from our team will address the comments.

Currently all traffic is generated with a single src. IP & a single dst. IP
https://github.com/openconfig/featureprofiles/blob/9e4444ebf3fe1b4dcc4d7829ba329329730f1617/feature/gribi/ate_tests/backup_nhg_multiple_nh_test/backup_nhg_multiple_nh_test.go#L341
Would it make sense to use the full dst subnet (/24) for LB purposes? Two primary next-hops are currently being provisioned with 80/20 weights
https://github.com/openconfig/featureprofiles/blob/9e4444ebf3fe1b4dcc4d7829ba329329730f1617/feature/gribi/ate_tests/backup_nhg_multiple_nh_test/backup_nhg_multiple_nh_test.go#L299
https://github.com/openconfig/featureprofiles/blob/9e4444ebf3fe1b4dcc4d7829ba329329730f1617/feature/gribi/ate_tests/backup_nhg_multiple_nh_test/backup_nhg_multiple_nh_test.go#L38-L40
(also const "dstPfxMask" on L40 is unused in ATE test)

just fyi, @manan-patel I'm ok with not validating the LB (80/20), because it's not the focus of this test (and we have other test to cover it).

Yeah i'm not saying we should validate 80/20 specifically, however with just a single flow you are unlikely to validate that the second next hop is active at all

@mojiiba any ETA for next review? I think overall this PR is good, just some minor things to address. Thanks!

@xw-g ,
Please review .Addressed the changes

@xw-g ,
Please review .Addressed the changes

Thanks @agvarghe-cisco I see there are still several comments not addressed. Can you help address them? Thanks.

Also, note that https://github.com/openconfig/featureprofiles/pull/1154 is merged.

Thanks for the changes and updates guys, looks good
Just two more small requests from me:

please remove this line (assignment of port1 to DEFAULT vrf under deviation flag; since this port is now assigned to vrf1)
https://github.com/openconfig/featureprofiles/blob/8a61c08bf7dbbc09d7155017f3d9c0f600fd8ede/feature/gribi/ate_tests/backup_nhg_multiple_nh_test/backup_nhg_multiple_nh_test.go#L234
please add the following deviation code to configureDUT() function (any place inside the function is fine, e.g. at the very end is ok):
https://github.com/openconfig/featureprofiles/blob/8a61c08bf7dbbc09d7155017f3d9c0f600fd8ede/feature/gribi/ate_tests/backup_nhg_multiple_nh_test/backup_nhg_multiple_nh_test.go#L205

	if *deviations.ExplicitGRIBIUnderNetworkInstance {
		fptest.EnableGRIBIUnderNetworkInstance(t, dut, *deviations.DefaultNetworkInstance)
		fptest.EnableGRIBIUnderNetworkInstance(t, dut, vrf1)
		fptest.EnableGRIBIUnderNetworkInstance(t, dut, vrf2)
	}

Additionally, I think there was a comment by @xw-g that went unnoticed regarding our earlier conversation about traffic and packet loss:
https://github.com/openconfig/featureprofiles/pull/1181#discussion_r1150873178

@LimeHat There is a comment by @xw-g requesting to change the prefix to /32, indeed we have the following options
1: Have /32 prefix and advertise only 1 prefix via ATE
2: Have /32 mask and enhance AddIPv4 call to handle scale config of prefixes
3: Have /24 mask

@manan-patel i'm ok with the current prefixes (single /32), that's fine.
I'm refering to the other comment (linked above):
Actually, @LimeHat and @mojiiba you brought a good point. Reading the code again, it stops the traffic before the flipping the port status.

What we wanted is that

Start traffic.
flip the port status.
Validate the traffic moved between ports.

Thanks @manan-patel for addressing all the comment. Please ping me when it's ready for another review. Thanks!

@xw-g  TC is ready for another review

/gcbrun

b/271139038 has the internal test results.


Custom picker?

Is it possible to create a picker with custom data, meaning something different from Date or Time?

For what use?

It would be like the second Date Picker screenshot, but instead of years, a custom list of String values. Similar to an iOS selector but "Materialized" :)
Also it would be great to be able to customize the header

The use case for that sounds specific to your app. It's simple enough to create your own solution using a standard list and adapter.


Multiple Checkboxes field targeting single Schema Array

I am noticing some undesired behavior when targeting a single array on my schema when using multiple fields of type checkboxes targeting that same array.
Plunker example: https://plnkr.co/u22GAXC6Fpwh1xOmm27Q

In the plunker, select a type from both dropdowns to expose the two checkboxes fields.
check one of the checkboxes on the top field, notice the model includes the object in the array properly.
check one of the checkboxes on the second checkbox field shown.  The model will empty the array.
check one of the checkboxes on the second checkbox field again, and the array will get populated with the proper object, of course the original checkbox from the first checkboxes field will be missing and unchecked.

Would be nice to not have the array get cleared.  Is there an option to make that happen by chance?

Thanks for the plunker, the main issue would be using the same key for different sets of checkboxes, but the removal of the value when you select another I am not so sure of why that happens I would have expected it to replace it only.
I would use a unique key name and then add click event to handle merging the values into your required key. But I see your issue thanks to your plunker and agree it would be nice if a copyValueTo styled behaviour could handle updating an array of merged values.

If I comment out lines 2393 through 2400, and below that add:
                form.titleMap.forEach(function (item, index) {
                    var arrIndex = arr.indexOf(item.value);
                    if (arrIndex === -1 && vals[index])
                        arr.push(item.value);
                    if (arrIndex !== -1 && !vals[index])
                        arr.splice(arrIndex, 1);
                });

The issue seems to be resolved.  However I haven't had time to play around with the test scripts you guys have so not sure if this would break anything else as a pull request.  Also you appear to be in the middle of some refactoring with deprecated code.  So will leave this here for now for feedback.

You can still make a PR we plan to review all approved PRs to make sure they are working once the main split has been completed, that said if you can find the file in the webpack-babel branch it is worth checking that has the same code, if so then a PR would be fine if it is easy to migrate when ready.

@kyse as your code suggestion is in the alpha I will close this, let me know if there is anything more you think needs doing on it :)


Protection from front-running via commit/reveal

We need a commit/reveal scheme where the commitment and the reveal happen in separate transactions. This is necessary because whatever we do in a single transaction can be copied.
Properties we want:

Rune cannot be determined from commitment
Commitment cannot be copied by a third party
One reveal is visible, can't commit and reveal before the reveal is mined

So, with the following in mind, an etching is valid if:

An input witness contains a data push of the rune name
The transaction that created that input was mined at least 144 blocks ago

Since the witness is a script, the committer can include a blinding factor in the script
The commitment script can include an OP_CHECKSIG with the committers public key. The commitment can be copied by a third party creating an output with the same address, but they cannot reveal from it because they do not know the private key
Once the reveal transaction is published, as long as it is mined within 144 blocks, it cannot be front-run, because a different commit for the same rune cannot be revealed before the reveal is mined

144 blocks is chosen because the primary reason a reveal wouldn't be mined is fee uncertainty, and 144 blocks both lets the etcher catch a 24 hour dip in the fees, and plenty of time to fee-bump the transaction.
This prevents front-running, but not collisions. A commitment should not be required for automatically allocated runes.

This is a great idea, please try to implement for day 1 so the wallfacers can all mint on day 1 sophon free.

This is a great idea, please try to implement for day 1

I'm definitely going to try, although this has implications for UX, namely that deploys would take 6+ blocks to activate.

wallfacers

😂

144 blocks, 1 + 4 + 4 equals 9,
Block 84.000 8 + 4 equals =12, 1+ 2= 3.
3, 6 and 9. Putting Nikola's theory  in Runestone dna @casey

144 blocks will let the etcher have 24 hours.
2 + 4 = 6.
Irs written kek.

It is done!


[Bug] oal add filter start error

Search before asking

[X] I had searched in the issues and found no similar issues.

Apache SkyWalking Component
OAP server (apache/skywalking)
What happened
Edit oal  server_sla =  from(Server.*).filter(responseCode not contain 40).percent(status == true);  Application startup error

What you expected to happen
Configuration error or document error
How to reproduce
Edit oal  server_sla =  from(Server.*).filter(responseCode not contain 40).percent(status == true);
Anything else
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

respond Code had been removed for years.. Check the latest doc, I think. rpcStatusCode and httpResponseStatusCode are there only.

Where can I check the latest documents?


Configuration and secrets in DDS.new

Those apps that stay need their config migrated from .NET xml .config files to CORE JSON formats, and adherence to policy for management of secrets.
Align management of secrets with rest of platform.

Using AWS SecretManager for managing secrets. Other 'non-secret' values can be stored in ParameterStore or appsettings.{environment}.json. The environments will be Staging and Production (default dotnetcore values). These are set in the relevant Terraform (see: staging dashboard for example).
We are using the terraform-aws-ecs-service modules to inject secrets via the ecs containerdefinition 'secrets[].valueFrom' property. These are set as envvars and picked up by standard .netcore configuration.

@tomcrane - closing this as we have the pattern for getting secrets into containers. We can add values as and when they are migrated.


Support tracing of HTTP requests using HttpClient

Feature request.
Currently the SDK only supports out-going HTTP requests using the HttpWebRequest client. It would be useful having tracing capabilities for those using System.Net.HttpClient.
For now I've created a custom MessageHandler for this, but would be great to have this or something similar as part of the SDK.
Edit: I just noticed that this has already been requested in #3.
I will look at adding that as a pull request

Hi @ljacobsson ,
Thank you for the feature suggestion. We welcome your pull request.
Thanks,
Yogi

You can use Diagnostics Source to get information about outgoing http calls.

Hi @ljacobsson ,
We have included this feature in 2.2.0-beta release.
Please refer release details : https://github.com/aws/aws-xray-sdk-dotnet/blob/master/CHANGELOG.md
I am closing this issue.
Thanks,
Yogi


Link to other badges people have made

There were a few other badges people had made, that didn't work for us for various reasons. But we should link to them anyway as they did important work and some folks might prefer theirs.

Hi @pbiggar ,
I created the StandWithPalestine two years ago.
Thanks,
Saed


3.8 nightly error: TypeError: code() takes at least 14 arguments (13 given)

For a project of mine, I run Travis CI with 3.5, 3.6, 3.7, and nightly. Only nightly is failing with the following error:
platform linux -- Python 3.8.0a4+, pytest-4.4.1, py-1.8.0, pluggy-0.9.0 -- /home/travis/virtualenv/python3.8-dev/bin/python

    app = Flask(__name__)
../../../virtualenv/python3.8-dev/lib/python3.8/site-packages/flask/app.py:558: in __init__
    self.add_url_rule(
../../../virtualenv/python3.8-dev/lib/python3.8/site-packages/flask/app.py:66: in wrapper_func
    return f(self, *args, **kwargs)
../../../virtualenv/python3.8-dev/lib/python3.8/site-packages/flask/app.py:1216: in add_url_rule
    self.url_map.add(rule)
../../../virtualenv/python3.8-dev/lib/python3.8/site-packages/werkzeug/routing.py:1562: in add
    rule.bind(self)
../../../virtualenv/python3.8-dev/lib/python3.8/site-packages/werkzeug/routing.py:711: in bind
    self.compile()
../../../virtualenv/python3.8-dev/lib/python3.8/site-packages/werkzeug/routing.py:767: in compile
    self._build = self._compile_builder(False)
../../../virtualenv/python3.8-dev/lib/python3.8/site-packages/werkzeug/routing.py:1128: in _compile_builder
    return self.BuilderCompiler(self).compile(append_unknown)
../../../virtualenv/python3.8-dev/lib/python3.8/site-packages/werkzeug/routing.py:1119: in compile
    co = types.CodeType(*code_args)
E   TypeError: code() takes at least 14 arguments (13 given)

@asottile

@c17r thanks for reporting, someone was seeing a 3.8 nightly failure at the sprint yesterday too. Travis’s allow_failures can be used to prevent the entire build from failing in the meantime in case this is helpful.

I don't think we're constructing code.CodeType any more, please upgrade to the latest werkzeug

I upgraded from 0.15.2 to 0.15.4 and got a new error:
    app = Flask(__name__)
../../../virtualenv/python3.8-dev/lib/python3.8/site-packages/flask/app.py:559: in __init__
    self.add_url_rule(
../../../virtualenv/python3.8-dev/lib/python3.8/site-packages/flask/app.py:67: in wrapper_func
    return f(self, *args, **kwargs)
../../../virtualenv/python3.8-dev/lib/python3.8/site-packages/flask/app.py:1217: in add_url_rule
    self.url_map.add(rule)
../../../virtualenv/python3.8-dev/lib/python3.8/site-packages/werkzeug/routing.py:1388: in add
    rule.bind(self)
../../../virtualenv/python3.8-dev/lib/python3.8/site-packages/werkzeug/routing.py:730: in bind
    self.compile()
../../../virtualenv/python3.8-dev/lib/python3.8/site-packages/werkzeug/routing.py:794: in compile
    self._build = self._compile_builder(False).__get__(self, None)
../../../virtualenv/python3.8-dev/lib/python3.8/site-packages/werkzeug/routing.py:951: in _compile_builder
    code = compile(module, "<werkzeug routing>", "exec")
E   TypeError: required field "type_ignores" missing from Module

which is #1551 which y'all already fixed for 0.15.5. Good deal.
cheers, sorry for the noise!


Non-linear limb-darkening?  Power-2 limb-darkening?

Limb-darkening with a z^{n/2} behavior (what Claret refers to as "non-linear" limb-darkening) can also probably be computed analytically in terms of hypergeometric functions and series expansions.  This might be a faster alternative to using Batman or the Mandel/Agol routines in this case.  The power-law limb-darkening, z^\alpha, proposed by Hestroffer, Morello and Maxted is (perhaps) the most accurate two-parameter limb-darkening.  It would be nice if we could come up with an analytic expression for this limb-darkening model.
Alternatively, we can Taylor expand these limb-darkening laws at the location of the planet, and then use the polynomial series expansion in z^n to approximate over the disk of the planet.

I can't find an analytic expression for either of these cases, so closing this for now.  The polynomial expansion idea may still be worth pursuing.


MSAL - Cumulative Version Update 230525

Task name:
AzureAppServiceManageV0
AzureAppServiceSettingsV1
AzureFunctionOnKubernetesV1
AzureKeyVaultV1
AzureKeyVaultV2
AzureMysqlDeploymentV1
AzureResourceGroupDeploymentV2
AzureResourceManagerTemplateDeploymentV3
AzureRmWebAppDeploymentV3
AzureRmWebAppDeploymentV4
HelmDeployV0
JavaToolInstallerV0
KubernetesManifestV1
Description: Cumulative version update for proxy fixes
Documentation changes required: (Y/N) N
Added unit tests: (Y/N) N
Attached related issue: (Y/N) N
Checklist:

[X] Task version was bumped - please check instruction how to do it
[X] Checked that applied changes work as expected

/azp run

test results are ok:

@ozanaydinMSFT Seems like this update affected multiple customers, that are using AzureRmWebAppDeployment@4 task -> #18361 . When could we expect fix for that?
Thanks!

This pr broke all our webapps deployments, please revert

@LukaszEV , @roofiq ; thanks for the comments. But actual issue was related another change not this one. We're investigating.

Thanks @ozanaydinMSFT, could you link what caused the issue? If it's not a problem :)


Mixed use of ofetch and $fetch

While reading the codebase (to potentially implement #89, most likely based on the existing Keycloak provider) I noticed that some places use ofetch and others use $fetch. Is there a specific reason for this? Otherwise it might be wise to unify them and use one of the two consistently throughout the codebase.

$fetch = ofetch
ref: https://nuxt.com/docs/getting-started/data-fetching#fetch
TLDR from the link;
Nuxt includes the [ofetch](https://github.com/unjs/ofetch) library, and is auto-imported as the $fetch alias globally across your application.

I knew that $fetch is at least some wrapper over ofetch. However, if there is no difference, I would reason that only one of the two should be used consistently throughout the codebase

I am happy to move everything to $fetch.
Anyone happy to open a PR for this? 🙏


[TextField] CSS API missing

[x] This is not a v0.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔
Show CSS API like https://material-ui.com/api/input-label/#css
Current Behavior 😯
CSS API missing
Steps to Reproduce 🕹
https://material-ui.com/api/text-field/#css
Context 🔦
I wanted to look up how to pass down a class to the helper Text
Your Environment 🌎
Online Documentation

Tech
Version

Material-UI
v4.2.0

This component doesn't inject any styles.

OK then, but shouldn't we at least say that in the docs then? I was passing stuff to classes and got the error "Only root is available" - so should we then at least list that under CSS API?

On the other hand it would be great if you could pass down classes.
My workaround is now passing a class down to classes={{ root: classes.helperText }} and then having
helperText: {
  '& p': {
    //my overwrites here
  }
},

Oh, I was wrong. Thanks for raising that the root key was working. I had forgotten that we introduced it for global theme overrides.
https://github.com/mui-org/material-ui/blob/22ba481fd549ffd35199846d2c313881406256a4/packages/material-ui/src/TextField/TextField.js#L21
Ok, in this case, I think that we should export the style const so the API generator can pick it up:

I got this one 👍


Investigate QLoRA

https://github.com/artidoro/qlora
https://arxiv.org/abs/2305.14314

We present QLoRA, an efficient finetuning approach that reduces memory usage enough to finetune a 65B parameter model on a single 48GB GPU while preserving full 16-bit finetuning task performance.
…
Our best model family, which we name Guanaco, outperforms all previous openly released models on the Vicuna benchmark, reaching 99.3% of the performance level of ChatGPT while only requiring 24 hours of finetuning on a single GPU.
…
Our results show that QLoRA finetuning on a small high-quality dataset leads to state-of-the-art results, even when using smaller models than the previous SoTA

Ultimately we want to get to a place where we can fine tune models offline. Maybe that involves QLoRA, maybe something else.
This task involves exploring what it would take to get QLoRA (or some alternative) up and running locally.

See https://github.com/kuleshov-group/llmtune/blob/main/llmtune/engine/lora/lora.py for an implementation.


Applying invalid field for vaadin-date doesnot apply.

Hello guys...In one my angular2 forms i have a datepicker which is a required field...When user proceeds to save the form without selecting date i am planning to show the date field as invalid and applied this condition for my datepicker-<vaadin-date-picker [invalid]="!StartDate.valid && isSubmitted" [ngFormControl]="StartDate"></vaadin-date-picker> But this doesn't show the field as an invalid control...If i simply keep the <vaadin-date-picker [invalid]="isSubmitted"></vaadin-date-picker> the invalid property applies to the control...
Here isSubmitted is a boolean value set to true

Added this statement to my directives list PolymerElement('vaadin-date-picker').filter(function(v, i) { return i !== 3; })  Suggested by @platosha


[Event Request] Codeunit 414 "Release Sales Document" -  OnBeforeReleaseATOs in procedure ReleaseATOs

Hello. Could you please add the following "OnBeforeReleaseATOs" event to Codeunit 414 "Release Sales Document" into the procedure  ReleaseATOs?

    local procedure ReleaseATOs(SalesHeader: Record "Sales Header")
    var
        SalesLine: Record "Sales Line";
        AsmHeader: Record "Assembly Header";
        IsHandled: Boolean
    begin
        // NEW CODE START
        IsHandled := false;
        OnBeforeReleaseATOs(SalesHeader, IsHandled);
        if IsHandled then
            exit;
        // NEW CODE END
        SalesLine.SetRange("Document Type", SalesHeader."Document Type");
        SalesLine.SetRange("Document No.", SalesHeader."No.");
        if SalesLine.FindSet() then
            repeat
                if SalesLine.AsmToOrderExists(AsmHeader) then
                    CODEUNIT.Run(CODEUNIT::"Release Assembly Document", AsmHeader);
            until SalesLine.Next() = 0;
    end;

    [IntegrationEvent(false, false)]
    local procedure OnBeforeReleaseATOs(var SalesHeader: Record "Sales Header"; var IsHandled: Boolean)
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 10879.


feat: allow esbuild 0.16

Set engines.node to be the same as esbuild.
Updated dependencies

esbuild 0.16
TypeScript 4.9

Updated TS config to target Node 12

Looking forward to this - PNPM is complaining about about package in our monorepos right now 😅

@webdeveric esbuild was moved from devDependencies to dependencies therefore the peerDependencies mechanism doesn't work as expected anymore

@mmachatschek It did not move.
https://github.com/pradel/esbuild-node-externals/blob/d5e8ef7201e1c28275b8de7f7e654ae3ed4fa37f/esbuild-node-externals/package.json#L28-L40


Stop character going off screen

Currently the main character can be moved off screen, this makes the game too easy because the player can keep the Jump button held down to constantly avoid the enemies.
Task

Add boundaries so that the character stops when hitting the sides or the top of the game area.

This issue is now assigned to @Goranmedic


Backend: Patch using FQN for entities

In order to patch using id, we need to do a get call to list entity/entities, fetch the id of the entity and then pass it to patch.
Rather than making additional calls, we can patch using fqns which would eliminate the need to list entities for their ids in some scenarios.
ref: https://openmetadata.slack.com/archives/C02B6955S4S/p1708654933324039

this is done here #16113


fix: update examples

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@devel dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Regression cli tests

Add accelerate launch tests
What does this add?
This PR introduces a subset of tests for checking accelerate launch and in turn accelerate config, and solves a bug I found during testing
Why is it needed?
Users have pointed out that we're not quite doing a good enough job with backwards compatibility checks on config yamls. To ensure these can be caught new tests are added to run a simple script using accelerate launch with no configuration file or specific configuration files
What parts of the API does this impact?
User-facing:
Nothing
Internal structure:
tests/test_configs should contain (at least) the last 2 major versions of Accelerate plus the latest version, which are direct outputs from accelerate config. Since these tests take so fast to execute, I think it's fine if this just contains the last 5 or 6 configs until we are comfortable.
Anticipated maintenance burden? (What will happen in say, 3 months if something changes)
As part of PR review, maintainers should be aware of any changes to the config file or CLI arguments and ensure that a new config is added to the folder for proper testing.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


download yt-dlp

ERROR: [youtube] mun0xn7pIN4: Sign in to confirm you’re not a bot. This helps protect our community. Learn more

Hello, when playing music with YouTube, this error is seen, what should we do?

Hello, when playing music with YouTube, this error is seen, what should we do?
ERROR: [youtube] mun0xn7pIN4: Sign in to confirm you’re not a bot. This helps protect our community. Learn more

Login you youtube account


debug travis

@ywk253100 this seems may workaround the issue in travis, please consider apply this fix if the problem remains.

Changes Unknown when pulling 68f7cf0afff3b477de1d946c4b13e821115313ed on reasonerjt:config-refactory into ** on vmware:dev**.

Travis comes back, so will close it.


Fix repo-config and file whitelist for AuditUncommitted function

The audit uncommitted function does not honour the --repo-config flag or the whitelist file section of the config file. This MR fixes these issues.
I think this fix would be better by refactoring the code base so both audit functions use a single logical function, rather than copying it into 2 different places. I will try and look at this when I get a bit more time. But for now this should be an improvement.

Awesome! Thanks for the contribution, could you update the unittest test data file to reflect the changes in this PR?

Updated, sorry I didn't realise it had failed the tests.
Is it possible to push a new release (3.0.3) after this is merged? I'm very keen to get this rolled out to the rest of the team.
Many thanks,
Peter


plotting multiple graph routes

with plot_graph_route, is there a way to plot multiple graph routes on one figure?

Not built into that function, no. But you can do this by plotting the graph then adding routes manually  on top with matplotlib.


Updated API wording around password rotation object.

Reworded the API reference to match examples.

@chrisroode this is perfect, thanks


use WATCH macro for BellPairStore

I added a WATCH macro to check the contents of the BellPairStores like the screenshot below.

This change is

this PR is still a work in progress. later I'll clean up and then send PR again


Fix ShowInTaskbar on Win32.

What does the pull request do?
Window.ShowInTaskbar wasn't working on win32. Originally when this feature was implemented it used the WS_EX_TOOLWINDOW style to hide the icon, but this has the unwanted side-effect of removing certain window decorations and so this style was removed in #3705.
To correctly hide the taskbar icon on win32 we need to parent the window to a hidden window. In addition if the window is visible when when set ShowInTaskBar = true then we need to temporarily hide the window and show it again.
Fixed issues
Fixes #5454

@kekekeks ah nice, I didn't notice that. Updated the PR to use that.


Add null param check for StandardPodUtils and Unit test

A small start to #26!
Added a null check in StandardPodUtils, since an instance with a null Kube client would have limited usefulness and we should protect developers from a configuration error. If a developer decides not to use a KubernetesClient, they should probably implement the PodUtils interface and supply an alternate implementation instead of passing null to StandardPodUtils.
Holding off on additional tests for StandardPodUtils for now, since it will be tricky to simulate running inside a pod because of the file system checks, and we can't guarantee that the test is running outside of a pod.

LGTM


pending workaround for protractor

protractor marks pending tests as failed, this fix corrects this behavior...

https://github.com/angular/protractor/issues/2454 once this is merged, we can remove this workaround

Hi @digitalkaoz,
If you want to go forward on this issue, there is a test on protractor integration, I suggest you to add your failing case and then add the code that make it pass.
Let me know if there is any trouble.

@bcaudan i added an integration test case... travis is green

I've looked into it and I do not wish to integrate it for two reasons:

it is a long running issue on protractor side, I have no idea when this behavior will be fix so I do not want to maintain this behavior for ages.
IMO, this workaround does not provide much help since protractor exit code is still 1, so your test is still failed.

Does it sound fair?

Yeah i guessed so...sad that protractor didnt fixed that issue
Bastien Caudan<EMAIL_ADDRESS>schrieb am Sa., 15. Apr. 2017,
12:37:

I've looked into it and I do not wish to integrate it for two reasons:

it is a long running issue on protractor side, I have no idea when
this behavior will be fix so I do not want to maintain this behavior for
ages.
IMO, this workaround does not provide much help since protractor
exit code is still 1, so your test is still failed.

Does it sound fair?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bcaudan/jasmine-spec-reporter/pull/135#issuecomment-294285336,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAR617Tuw2LkwytARybHtGYLqWmZZV6Oks5rwJ34gaJpZM4M7Uxn
.


How to use &hm (homerow mods)

I can see that a homerow mod behavior is defined here: https://github.com/KinesisCorporation/Adv360-Pro-ZMK/blob/V3.0/config/adv360.keymap#L20
But i dont get how I can use that in the editor. I try to use &hm but It says that it does not know it and also does not give me the option of specifying mod and key.
Thanks

the &hm behaviour is a predefined variant of the hold-tap functionality provided by ZMK https://zmk.dev/docs/behaviors/hold-tap . It's an advanced function and as such can't be configured in the Kinesis GUI. You can either use a different ZMK GUI editor (I believe this one supports hold tap configuration: https://nickcoutsos.github.io/keymap-editor/) or do it manually in the file

thank you, manuell editing worked fine :)


Error in CodeExample3 with "Raphaël"

In the CodeExample3 if you select Raphaël and others and the go back to the SuperSelectField Raphaël is not marked in the menu as selected but still apearing in the selectedRednerer.
You can't remove him after you selected him once and you are able to add him multiple times.

Bug confirmed, thanks 👍

Fixed


Runtime required components do not work correctly for components added through #[require(...)]

Bevy version
Bevy 0.15.0-rc.3
What you did
I have a component, let's say A, that requires another component B using #[require(B)]. B then requires another component C, but the requirement is registered in a plugin using app.register_required_components::<B, C>().
What went wrong
When I spawn an entity with A, C is not added!
Here's a simple test that fails:
#[test]
fn runtime_required_components() {
    // `A` requires `B` directly.
    #[derive(Component)]
    #[require(B)]
    struct A;

    #[derive(Component, Default)]
    struct B;

    #[derive(Component, Default)]
    struct C;

    let mut world = World::new();

    // `B` requires `C` with runtime registration.
    // This *fails*, but not when using `#[require(C)]` for `B`.
    world.register_required_components::<B, C>();

    // Adding runtime registration for `A -> B` also doesn't help if done after `B -> C`,
    // but it *does* work if done before.
    let _ = world.try_register_required_components::<A, B>();

    let entity = world.spawn(A).id();
    assert!(world.entity(entity).get::<C>().is_some());
}

If the entity is spawned with B directly, it does work:
#[test]
fn runtime_required_components_2() {
    #[derive(Component)]
    #[require(B)]
    struct A;

    #[derive(Component, Default)]
    struct B;

    #[derive(Component, Default)]
    struct C;

    let mut world = World::new();

    world.register_required_components::<B, C>();

    let _ = world.try_register_required_components::<A, B>();

    let id = world.spawn(B).id();
    assert!(world.entity(id).get::<C>().is_some());
}

This implies that the problem is related to runtime requirements not being properly propagated up the inheritance tree if the higher levels use #[require(...)], or if the higher level requirement is added after the lower level requirement.

        let mut world = World::new();
        world.register_required_components::<B, C>();
        let result = world.try_register_required_components::<A, B>();
        assert!(result.is_ok());
        let id = world.spawn(B).id();
        assert!(world.entity(id).get::<C>().is_some());

The first assertion actually fails, so the problem seems to be with the attempt to register the required component.

DuplicateRegistration(ComponentId(6), ComponentId(4))

That one is supposed to return an error (hence why I used try_) since the requirement is already defined earlier with #[require(B)]. It's not related to the issue where the requirement for A -> C isn't added correctly

This isn't fully resolved by #16410:
    #[test]
    fn runtime_required_components_propagate_up_multiple() {
        #[derive(Component)]
        struct A;

        #[derive(Component, Default)]
        struct B;

        #[derive(Component, Default)]
        struct C;

        #[derive(Component, Default)]
        struct D;

        let mut world = World::new();

        world.register_required_components::<A, B>();
        world.register_required_components::<B, C>();
        world.register_required_components::<C, D>();

        let id = world.spawn(A).id();

        assert!(world.entity(id).get::<B>().is_some());
        assert!(world.entity(id).get::<C>().is_some());
        assert!(world.entity(id).get::<D>().is_some());
    }


add support to pass a kms to encrypt cloudwatch log groups

Added support for KMS encription on cloudwatch log groups
Related Issues

[none]

Public Changelog
Added cloudwatch_log_groups_kms_arn as a variable. You can pass the ARN of a KMS resource and it will be used to encript the cloudwatch log groups.
Security Implications
[none]

Thanks!


Transitive dependency version not respected

TypeScript Version:  3.4.0-dev.201xxxxx

Search Terms:
different transitive dependency versions
Our use case uses a sub-module to provide dependant modules with the latest versions of certain 3rd party dependencies, while allowing them to use older versions directly depended on throughout the rest of the code base.
This works perfectly fine from a pure JS perspective and allows a nice upgrade mechanism. Unfortunately, we can't get this working from a TS perspective. Depending on configuration, either the top-level types are used throughout - which is incorrect with reference to the corresponding JS - or we get version conflict compile errors.
Expected behavior:
(Referenced repos created solely to demonstrate the issue)
This shouldn't compile: https://github.com/irond13/dep-test-consumer/blob/with-dep/src/with-dep.ts#L10 (referenced method indexBy doesn't exist in transitive version of lodash @ 4.x.x)
This should compile: https://github.com/irond13/dep-test-consumer/blob/should-compile/src/with-dep.ts#L10
Actual behavior:
This does compile: https://github.com/irond13/dep-test-consumer/blob/with-dep/src/with-dep.ts#L10
This doesn't compile: https://github.com/irond13/dep-test-consumer/blob/should-compile/src/with-dep.ts#L10 (referenced method keyBy does exist in transitive version of lodash, but doesn't exist in directly depended on version of loads @ 3.x.x)

Another variation of the above is where both versions of the lodash types are parsed in the same context for some reason, which causes compile errors due to conflicts.
This branch demonstrates: https://github.com/irond13/dep-test-consumer/tree/compile-fail-conflict
It fails with the following compile errors:
node_modules/@types/lodash/index.d.ts(6,1): error TS6200: Definitions of the following identifiers conflict with those in another file: ListIterator, ObjectIterator, StringIterator, MemoVoidIterator, MemoIterator, MemoVoidArrayIterator, MemoVoidDictionaryIterator, List, LoDashImplicitArrayWrapper, LoDashImplicitObjectWrapper, LoDashImplicitNumberArrayWrapper, LoDashImplicitStringWrapper, LoDashExplicitArrayWrapper, LoDashExplicitObjectWrapper, LoDashExplicitNumberArrayWrapper, LoDashExplicitStringWrapper, DictionaryIterator, NumericDictionaryIterator
node_modules/@types/lodash/index.d.ts(41,26): error TS2314: Generic type 'LoDashImplicitWrapper<T, TValue>' requires 2 type argument(s).
node_modules/@types/lodash/index.d.ts(43,27): error TS2314: Generic type 'LoDashImplicitWrapper<T, TValue>' requires 2 type argument(s).
node_modules/@types/lodash/index.d.ts(47,23): error TS2314: Generic type 'LoDashImplicitWrapper<T, TValue>' requires 2 type argument(s).
...

compile_fail.txt

You need a version of @types/lodash that doesn't unconditionally dump its types into the global scope. :(
Since its types are global, they can conflict when multiple versions are installed - this is fine in a browser environment, since it'd indicate they you have multiple conflicting global lodash includes, but in the module context it's just unpleasant, since the two copies of lodash don't really interact.


[HOLD for payment 2023-04-26] [$1000] Compose field's left border doesn't extend as the field expands

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open chat and start typing
Goto second line by pressing Shift + Return (Enter)
Keep Typing and goto Next line by Pressing Shift + Return (Enter)
Check line between + Button & type area (the left border of the compose field)

Expected Result:
Line Should extend along with text box size
Actual Result:
Line is not extending along with text box size

Workaround:
N/A - minimal impact
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/43996225/231903889-b83833eb-198e-4ffc-9bac-79b10c813894.mov
Expensify/Expensify Issue URL:
Issue reported by: @corange-lab
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681377556974939
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~019ff38561f983d47e
Upwork Job ID:<PHONE_NUMBER>295243776
Last Price Increase: 2023-04-14

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@kavimuru this issue title seems... wrong 😆

@kavimuru this issue title seems... wrong 😆

@conorpendergrast i wrote that title and i don't have word for it so ..

Oh hah, I just spotted that it's in the Slack thread about this 😄

I'm going to re-title this to make it a little clearer, but I did enjoy that previous title. Reproduced

Job added to Upwork: https://www.upwork.com/jobs/~019ff38561f983d47e

Current assignee @conorpendergrast is eligible for the External assigner, not assigning anyone new.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

Proposal
Please re-state the problem that we are trying to solve in this issue.
When composer has multiline text at that time right border beside Plus icon does not expand vertically.
What is the root cause of that problem?
This is the parent view that consist all three button i.e. collapse, expand, and addAction
https://github.com/Expensify/App/blob/ab9b7d9ef1fb1656f5ccfc28ca4a68820fa373b4/src/pages/home/report/ReportActionCompose/index.js#L764-L768
Plus button shows right border via View having styles.chatItemAttachBorder  as shown below:
https://github.com/Expensify/App/blob/ab9b7d9ef1fb1656f5ccfc28ca4a68820fa373b4/src/pages/home/report/ReportActionCompose/index.js#L807
chatItemAttachBorder consist below style:
https://github.com/Expensify/App/blob/ab9b7d9ef1fb1656f5ccfc28ca4a68820fa373b4/src/styles/styles.js#L1587-L1590
So during multiline plus button view does not expand vertically so line does not show. This is the root cause of the problem.
What changes do you think we should make in order to solve the problem?
We have to do below changes to solve this

Remove View from line 807 as shown below

<View style={styles.chatItemAttachBorder}>    // *** Remove this
   .... // Keep this content
</View>.     // *** Remove this

Apply styles.chatItemAttachBorder to its parent View that starts at line 764 as shown below:

 <View style={[
     styles.dFlex, styles.flexColumn,
     (this.state.isFullComposerAvailable || this.props.isComposerFullSize) ? styles.justifyContentBetween : styles.justifyContentEnd,
    styles.chatItemAttachBorder,   // *** Add this
 ]}
 >

Note: We can rename styles.chatItemAttachBorder if wish, otherwise it is ok. It consist style for right border.
So this will solve the issue. It is working as expected in all platform. Sample video added in Results section below.
What alternative solutions did you explore? (Optional)
None

Results
https://user-images.githubusercontent.com/7823358/232017357-d7f7142a-feac-4587-ba19-5f4fc8d0333c.mov

Proposal
Please re-state the problem that we are trying to solve in this issue.
Line in the composer doesn't extend as the user presses shift enter
What is the root cause of that problem?
This line is created by using a borderRight. this border is added with "styles.chatItemAttachBorder" but originally only added to the View element of the actionButton which does not wrap the entire element that will expand with the textArea
What changes do you think we should make in order to solve the problem?
We can move the style to a higher level, that way the border is attached to the entire element and will expand properly

    {({openPicker}) => (
        <>

What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Line in the composer doesn't extend as the user presses shift enter
What is the root cause of that problem?
This line is created by using a borderRight. this border is added with "styles.chatItemAttachBorder" but originally only added to the View element of the actionButton which does not wrap the entire element that will expand with the textArea
What changes do you think we should make in order to solve the problem?
We can move the style to a higher level, that way the border is attached to the entire element and will expand properly

    {({openPicker}) => (
        <>

What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Line in the composer doesn't extend as the user presses shift enter
What is the root cause of that problem?
This line is created by using a borderRight. this border is added with "styles.chatItemAttachBorder" but originally only added to the View element of the actionButton which does not wrap the entire element that will expand with the textArea
What changes do you think we should make in order to solve the problem?
We can move the style to a higher level, that way the border is attached to the entire element and will expand properly
<AttachmentPicker>
    {({openPicker}) => (
        <>
            <View style={[
                styles.chatItemAttachBorder,
                styles.dFlex, styles.flexColumn,
                (this.state.isFullComposerAvailable || this.props.isComposerFullSize) ? styles.justifyContentBetween : styles.justifyContentEnd,
            ]}
            >

What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Thank you guys for the proposals!
While everyone has the same correct solution and @PrashantMangukiya proposal is the first to post it right after the Help Wanted label. @aldo-expensify, we can go with @PrashantMangukiya's proposal!

Result

🎀 👀 🎀 C+ reviewed!

📣 @PrashantMangukiya You have been assigned to this job by @aldo-expensify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

@mollfpr  @aldo-expensify Thank you. Accepted job on Upwork. I will prepare and submit PR within two hours asap.

@mollfpr @aldo-expensify PR is ready for review. Thank you.

@mollfpr @aldo-expensify can i also apply on upwork?

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.1-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/17464

If no regressions arise, payment will be issued on 2023-04-26. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@conorpendergrast] Determine if we should create a regression test for this bug.
[ ] [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@conorpendergrast] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Ping for Upwork.

@conorpendergrast Ping for Upwork.

@conorpendergrast i am waiting for response on upwork.

Conor is out of office and he will be back early next week to process your payments

@aldo-expensify Thanks for giving update.

Thanks all, and appreciate you applying via Upwork - makes it a lot easier!
Assigned: April 14th 8:18pm
PR merged: April 17th 8:15pm
That's less than 3 business days, and so C and C+ are eligible for 50% bonus

@conorpendergrast Received Thank you.

Invited and paid @PrashantMangukiya.
Invited @mollfpr to the job in Upwork.
@corange-lab I'm really sorry, I wasn't able to find your application on Upwork, and I haven't been able to find your Upwork profile! Can you either apply here, or reply with your Upwork profile URL and I'll invite you? Thanks!

@conorpendergrast
https://www.upwork.com/freelancers/~0182d5b08109999ffb
Thanks for response

@conorpendergrast Accepted Thanks.

Friendly ping @mollfpr on completing: https://github.com/Expensify/App/issues/17424#issuecomment-1515078000

@aldo-expensify Sorry I miss this; I'll complete the checklist today 🙏

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

This issue has existed since the first implementation of the attachment button inside the composer https://github.com/Expensify/App/pull/399. Then it got refactored here https://github.com/Expensify/App/pull/13645, where it's not part of the button anymore.
So I don't think any of that PR is causing the bug, but now we see it as unsuitable.

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The checklist is good for now!

[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

For the regression test, I'll propose to have it under Compose box - Text Input. At Enter 3+ lines of text, and select/highlight the text, we can add Verify that the border after the action button is extended accordingly.
👍 or 👎?

That sounds perfect for me ^

Sounds good to me too - I'll create that regression test


Attempt to fix "Gave up!" problem in prop_balanceTransactionUnresolvedInputs

Simply removing ==> seems to work fine, and I believe makes it more likely to
pass.
Remove withMaxSuccess because it seems to be doing nothing in
conjunction with checkCoverage.

Comments

I'm not entirely sure of the interplay between the various ==>, checkCoverage, etc, not certain that this for sure is a fix, however, it can't hurt to try.

$ cabal run cardano-wallet:test:unit -- --match "unresolved inputs" --seed<PHONE_NUMBER>
Cardano.Wallet.Shelley.Transaction
  balanceTransaction
    when passed unresolved inputs
      may fail (1697ms)
        +++ OK, passed 100 tests:
        10% unknown txins

        87% other error
         3% nothing dropped

Finished in 1.6980 seconds, used 1.7075 seconds of CPU time
1 example, 0 failures

Issue Number
ADP-1590

bors r+

bors r+

bors r+


Open code coverage report in browser after tests finished

Codecov Report

Merging #886 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #886      +/-   ##
==========================================
- Coverage   97.74%   97.74%   -0.01%
==========================================
  Files          36       36
  Lines        3240     3411     +171
  Branches      274      493     +219
==========================================
+ Hits         3167     3334     +167
+ Misses         73       66       -7
- Partials        0       11      +11

Impacted Files
Coverage Δ

browser/main.js
98.41% <0%> (-1.59%)
:arrow_down:

browser/model/helpers/downloader.js
96.94% <0%> (-1.52%)
:arrow_down:

browser/pages/confirm/controller.js
94.94% <0%> (-1.48%)
:arrow_down:

browser/model/devstudio.js
96.8% <0%> (-0.97%)
:arrow_down:

browser/model/cdk.js
99.21% <0%> (-0.79%)
:arrow_down:

browser/model/jdk-install.js
96.61% <0%> (-0.42%)
:arrow_down:

browser/pages/start/controller.js
100% <0%> (ø)
:arrow_up:

browser/model/kompose.js
100% <0%> (ø)
:arrow_up:

browser/model/helpers/installer.js
100% <0%> (ø)
:arrow_up:

browser/model/cygwin.js
100% <0%> (ø)
:arrow_up:

... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd75ab0...6947083. Read the comment docs.


Time change is not registered

Instead of time set in the field I get current time
  handleDateTimeChange(date) {
    this.setState({
      startDate: date
    });
  }

The state receives the date correctly but time if in a form I change the time to 5 pm it still returns 6 if it's now 6. Here is component
          <DatePicker
              dateFormat="YYYY-MM-DD HH:mm"
              selected={this.state.startDate}
              todayButton="Today"
              onChange={this.handleDateTimeChange}
          />

is there any support to change the date as well as time from the date picker itself??

this.state.startDate is a moment object. You can always rewrite it in onChange or you can use onSelect callback if you need to catch each select. DatePicker is not TimePicker, it just cares about dates, but you can track current time in onSelect callback.

Closing due inactivity.


feat: button generator

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/ng-primitives/ng-primitives/blob/main/CONTRIBUTING.md#-commit-message-guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation changes
[ ] Other... Please describe:

What does this PR implement/fix?
This PR introduces a generator to help generate a button component that uses the ng-primitive button
Does this PR introduce a breaking change?

[ ] Yes
[x] No

@allcontributors please add @kedevked for code


feat:  support trailer

What type of PR is this?

feat
Check the PR title.

[x] This PR title match the format: <type>(optional scope): <description>
[x] The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.
增加 HTTP Trailer 支持
(Optional) More detail description for this PR(en: English/zh: Chinese).

en:

add Trailer struct to RequestHeader and ResponseHeader
implement trailer read and write for http1.1

zh(optional):

为RequestHeader 和 ResponseHeader 增加 Trailer 结构
为 http1.1 实现 trailer 的读和写

Which issue(s) this PR fixes:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

reviewer + @byene0923 🙏

PATL @Duslia @FGYFFFF @welkeyever


Potential row limit on server

I'm trying to execute a line like so:
client.queryWithOpts('Property', '1', '(246=A),(61=|BROWARD,DADE)', {limit: 10, offset: 0}, function(error, data) {
	fs.writeFile("./test.txt", JSON.stringify(data))
	console.log(error);
});

The data.length is always 5000 when I have no limit or 10000 as my limit. Offset does not work on my RETS endpoint and returns an error like so:
{ [Error: RETS Server returned an error - ReplyCode: 20203 ReplyText: Offset is not supported.  Reference ID: 7be5d629-085a-4cba-a6e0-769b50b8ee78]
  replyCode: '20203',
  replyText: 'Offset is not supported.  Reference ID: 7be5d629-085a-4cba-a6e0-769b50b8ee78' }

Do you think this problem is related with the server? Is there something I can do to confirm this from my side? There is no publicly available documentation on my RETS feed website.

Hi Georgiy,
I've experienced the same issue with the rets server I develop against.
Even though I set a limit on some queries to a value greater than 5000 I
only get back 5000. I've seen this happen on a java rets client
implementation and also when hitting the rets server directly. My sense is
that this is a problem related with the server. Is there a technical point
of contact that maintains your rets server that you can get in touch with?
-Steve
On Wed, Aug 19, 2015 at 1:50 PM, Georgiy Slobodenyuk <
<EMAIL_ADDRESS>wrote:

I'm trying to execute a line like so:
client.queryWithOpts('Property', '1', '(246=A),(61=|BROWARD,DADE)', {limit: 10, offset: 0}, function(error, data) {
fs.writeFile("./test.txt", JSON.stringify(data))
console.log(error);
});
The data.length is always 5000 when I have no limit or 10000 as my limit.
Offset does not work on my RETS endpoint and returns an error like so:
{ [Error: RETS Server returned an error - ReplyCode: 20203 ReplyText: Offset is not supported.  Reference ID: 7be5d629-085a-4cba-a6e0-769b50b8ee78]
replyCode: '20203',
replyText: 'Offset is not supported.  Reference ID: 7be5d629-085a-4cba-a6e0-769b50b8ee78' }
Do you think this problem is related with the server? Is there something I
can do to confirm this from my side? There is no publicly available
documentation on my RETS feed website.
—
Reply to this email directly or view it on GitHub
https://github.com/sbruno81/rets-client/issues/10.

Thanks for the quick reply,
Yes, we have a point of contact that may be able to answer that for us. I'll go ahead and ask.

Got a response back from my point of contact:

Yes the 5000 is a limit by a company business decision. Once the the download is completed the first time all updates will be in one pull if done daily.

some RETS providers will give you up to 25 tries to download the full set of data, then it is incrementally after that.   I'm working with one right now where they only allow 100 per search, and there are around 130,000 records to download.

@scottconrad, thanks for the additional input.  For anyone else who finds this ticket, this sort of business rule will have to be dealt with using the offset option to iteratively request additional records.
Closing the ticket since this is a server-side setting, not client-side.


validation

first validation length is less mean the program execution stop after(f5) that show that alert message
i want only show alert error message only not code unhandle exception

if (password == null ||
password.Length < Membership.MinRequiredPasswordLength)
throw new ValidationError("PasswordLength", "Password",
String.Format(Texts.Validation.MinRequiredPasswordLength, Membership.MinRequiredPasswordLength));

This only happens on developer environment. if you hit continue and check your browser the alert error message is shown.

If you run it in 'Release' versus 'Debug', the browser alert that @reybatacjr was talking about will be displayed without Visual Studio going into break mode.

Use visual studio exceptions window to disable break on that kind of exception.

tank u


docs: improve hiro archive documentation

Description
Updates Hiro Archive documentation to add detail, disambiguate, and clarify.
Related issue.

@max-crawford What are your thoughts on the Hiro Archive doc updates?

@CharlieC3 these changes are awesome and answer a lot of my questions in the blog draft. One nit: there is a typo in the second sentence in the intro (italics for emphasis): "which otherwise could day days or weeks" should read "which otherwise could take days or weeks "


Project #1 Design issue

Description
Hi, I am stuck on the project design. I have seen some other similar issues but I am still confused on how to update the servers' queues.
The way I am designing my program is the following: Simulator creates an ImList of servers, then I create a PQ of input Arrive events coming from the input files, each corresponding to a customer arriving. Then, these two objects are passed to another class called Manager.java.
What the manager does is create a PQ for each Server, which I group together in an ImList.
Then, I start by getting an Arrive event, scanning the servers PQs, and see if there's an idle one, etc.
However, I am not sure on how to update these server PQs as time goes by. Because a new Customer may arrive and see that the PQ is full, while it has actually finished serving the previous customer by that time.

I think that you are almost there! As I understand you, the main goal is to have an updated ImList of servers for every time an event is polled from PQ. So I am not sure how your code is organised, but what maybe could be done would be to update the ImList every single time an event is polled. What I did for this is super inelegant and desperate, but hopefully it may be of help. Every time I poll an event from the PQ, I do two things, which can happen in the appropriate order you deem it to be.
The first is to process each event using the latest ImList from my manager - so my method specification for this is Event processEvent(ImList listOfServers). This will ensure that every event is processed using the most current list of servers and updated queues. The second thing I did was to have a method that updates the ImList in the manager, which is as desired. This method of mine is also located within the parent Event class, just as .processEvent was, so the specification is something like ImList updateListOfServers(ImList listOfServers). So to recap, in my Event class, I have two methods .processEvent and .updateListOfServers that I call from my manager for every event I poll. As an example, if I poll a Wait event from PQ, I want to add a Serve event back into PQ (first method), and also decrease the queue of my one true managerial ImList of servers (second method).
How the appropriate event times are updated, was a fluke for me, for as you might already predict, it gets a little messy and inelegant cos I sometimes have one or two lines of duplicate code across the two methods, though it gets the job done. Definitely do seek out a more elegant solution, just writing what I have here cos it's Tuesday!

You can update the server after each event gets executed by returning in the execute method with your event with the pair function. In your case, you can try update the Manager Class in each execute method and return it to update it generally in the Simulator class

Hi, I think just as how your nextEvent works (i.e., checking certain conditions and call the next event accordingly), your updateServer can do the same. Btw, what I did was having a class of CounterQueue to store all Servers and within each Server is ImList of Customers in the queue. Then I update the waiting queue and/or servers' availabilities accordingly. Hope this helps!

However, I am not sure on how to update these server PQs as time goes by. Because a new Customer may arrive and see that the PQ is full, while it has actually finished serving the previous customer by that time.

Hello! I think this is indeed a problem if you are simply adding the Arrive events to the various servers' PQ immediately before you started processing the other events (Wait, Done, etc.). To ensure that each server's PQ accurately reflects the state of the server's own queue at any time, you would have to actively poll the events when needed and then add the following event (if it exists) to the server's PQ.
You would still require an overarching "meta" PQ as per our previous labs that contains the events from all servers, and iteratively process each event until this PQ is empty. During the processing of each event in this PQ, you can then perform the relevant actions to the appropriate server's PQ. I think this should help you accurately keep track of the state of each server's PQ at any time.
Hopefully this helps!


IPSN-14801 Data Distribution metrics REST API is broken for secured c…

…aches
https://issues.redhat.com/browse/ISPN-14801
The issue happened with local caches, which also lacked some test coverage.

@jabolina backport is needed


React warnings in the javascript console

Describe the bug
We see a couple of warnings in the JavaScript console when using this library.
Package Version
react-input-pin-code: "npm:^1.2.0"
react: "npm:^18.2.0"
react-dom: "npm:^18.2.0"
Screenshots

@joker-777 you might pass props down to children components, and ultimately to a DOM element.
here is the related issue: https://stackoverflow.com/questions/54468535/how-to-solve-warning-react-does-not-recognize-the-x-prop-on-a-dom-element
related documentation: https://reactjs.org/warnings/unknown-prop.html
see if it works for you

@joker-777 Hi sorry for late response, it seems that styled-components has updated to v6, so the input component is needed updated to compatible with
If you need a quick solution in condition, you could downgrade styled-components to v5.
Also, glad to see you PR to make it compatible with styled-components v6.


[BUG] System.IO.IOException: Access to the path '\?\C:\Users\GSP\AppData\Local\Bloxstrap\Roblox\Player.old\content\textures' is denied.

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.
[X] I have thoroughly looked through the available Wiki articles and could not find a solution to my problem.
[X] I am using the latest version of Bloxstrap.
[X] I did not answer truthfully to all the above checkboxes.

Bloxstrap Version
v2.8.1
What problem did you encounter?
i cant open it because of this error
Bloxstrap Log
N/A

Did you install bloxstrap as administrator
If you did, you shouldn't have done that
Also, read the fourth checkbox before opening another issue

Did you install bloxstrap as administrator If you did, you shouldn't have done that Also, read the fourth checkbox before opening another issue
uhh how to fix

yo storm what should i do then how to i get to open it again

blue what do u mean


Pickling the accelerator after preparing data loader no longer possible

System Info
accelerate v0.34.0

Information

[ ] The official example scripts
[X] My own modified scripts

Tasks

[ ] One of the scripts in the examples/ folder of Accelerate or an officially supported no_trainer script in the examples folder of the transformers repo (such as run_no_trainer_glue.py)
[ ] My own task or dataset (give details below)

Reproduction
import pickle
import torch
from accelerate import Accelerator

data = torch.arange(10)
ds = torch.utils.data.TensorDataset(data)
dl = torch.utils.data.DataLoader(ds)

accelerator = Accelerator()
pickle.dumps(accelerator)  # works
accelerator.prepare(dl)
pickle.dumps(accelerator)  # fails

The error is:
    pickle.dumps(accelerator)  # fails
    ^^^^^^^^^^^^^^^^^^^^^^^^^
_pickle.PicklingError: Can't pickle <class 'accelerate.data_loader.DataLoaderShard'>: it's not the same object as accelerate.data_loader.DataLoaderShard

Expected behavior
Pickling and unpickling the Accelerator instance used to work but now it fails if a data loader has been prepared. I could trace down the issue to this PR: #2895. Although I haven't investigated further, I'm fairly certain that messing with the __class__ attribute is the reason:
https://github.com/huggingface/accelerate/blob/b5235f21d83c7f714a44d876cfd6fd0b1339dd38/src/accelerate/data_loader.py#L436
If that's so, there might be the necessity to adjust __getstate__ or __reduce__ on DataLoaderAdapter to account for the fact that the class is dynamically changed.

Ping @byi8220. I already discussed this issue internally with Zach, who might take a look later today.

Although I haven't investigated further, I'm fairly certain that messing with the class attribute is the reason

Fully agree on that.

there might be the necessity to adjust __getstate__ or __reduce__ on DataLoaderAdapter to account for the fact that the class is dynamically changed.

Makes sense, IIUC it would be preferred to adjust __getstate__ (and possibly __setstate__) to be aware of the calling object's dynamic __class__ type?
Alternatively, we could just abandon the dynamic class solution entirely and incur a lot of code duplication (which we discussed in the original PR, but decided against).

who might take a look later today.

Ack, I'll hold off on writing PR then?

Ack, I'll hold off on writing PR then?

I think you can give it a try, I'm sure Zach will write here when he starts working on this.

@byi8220 let's go with the getstate/setstate version rather than do code duplication. I haven't gotten there yet, so feel free to have at it!

Working on a possible fix for this in https://github.com/huggingface/accelerate/pull/3074
Honestly, even before breaking the class pickling DataLoaders seems really sort of fragile. There's more details in the PR, but I'm not sure if StatefulDataLoader could (or should) even be pickled.
Also, my current multigpu tests are failing with an error message of TypeError: cannot pickle 'torch._C.Generator' object when I try to pickle the accelerator. I am not sure if that's related to the issue at hand or if that is a known existing bug.
At the very least, I ran test_hf.py within https://github.com/skorch-dev/skorch with the above PR, and managed to get those tests to pass. So it should unblock their CI. Although it's sort of strange, considering their failing test literally says pickling doesn't work.
However, I can't run their integration tests, so there's still a chance this is not sufficient. I still think there's some rough edges with pickling, especially in a distributed context.

Also, my current multigpu tests are failing with an error message of TypeError: cannot pickle 'torch._C.Generator'

Yet again, this was just me not updating to the latest pytorch version. Pickling generators is only available in torch version
2.4.0 and above.


Pictures of past events are ridiculously small

See bottom page of http://protocultural.org/2015/11/dubai/

Great! Those ones of us playing drums are pretty great that are somehwere
On Saturday, February 13, 2016, Clément Renaud<EMAIL_ADDRESS>wrote:

See bottom page of http://protocultural.org/2015/11/dubai/
—
Reply to this email directly or view it on GitHub
https://github.com/protocultural/protocultural.org/issues/23.


Need an explanation for expand option in README

It would be cool to add an explanation of this option.

That's a grunt feature and has nothing to do with plugin. It's even linked to right below the example.

@sindresorhus,  I see, thanks.


For getting more accuracy in faster rcnn , which parameters i have to tune (tuning parameters).

For getting more accuracy in faster-rcnn , which parameters i have to tune (tuning parameters). please anybody provide the solution for that problem, actually my model is working but the problem is getting less accuracy and some miss classifications are happens , so please kindly provide solution for getting high accuracy in the model.
Thanking you!

please can anybody suggest tuning parameters ???
**Thanking you **


Spring colour one

Description
Created 2 colour theme CSS files
Light theme screenshot

Dark theme screenshot

Type of change

[ ] Bug fix
[x] New feature
[ ] Refactoring
[ ] Documentation

Problem
Briefly describe the root cause and analysis of the problem
Solution description
Describe your code changes in detail for reviewers.
Explain the technical solution you have provided and how it fixes the issue.
Tests
All unit tests pass?
Builds successfully?
Attach screenshot of the expected result (e.g. UI of the website/ postman api call result/ database changes)
Provide steps in detail for reviewers to reproduce the expected result of the code changes.
Relevant document/ link (if any)
Any related documents could help reviewers to review this PR
Risk
Identity the risk level (low, medium, high) and indicate which component(s) will be affected if bugs exist.

Major changes made recently:

Removed colours 3 & 4 (just light and dark now)
Updated so they work properly with the various layout options recently implemented
After PR 226 is merged I can make it dynamic (just need to replace the const darkMode = true variable with an actual variable from data or fakeData)

Oops, hit approve a bit prematurely. Before you merge, could you add the theme option into fakeData.js so we can control it from there rather than in each of the App.js?


Registry startup failing with certificates

Hi,
I am getting following error when i am using registry:2 and along tls certificates for http
registry_1 | time="2015-12-30T18:59:56Z" level=warning msg="No HTTP secret provided - generated random secret. This may cause problems with uploads if multiple registries are behind a load-balancer. To provide a shared secret, fill in http.secret in the configuration file or set the REGISTRY_HTTP_SECRET environment variable." go.version=go1.5.2 instance.id=a97415c3-5d7a-42b1-8c91-ab7655951d6e version=v2.2.1
registry_1 | time="2015-12-30T18:59:56Z" level=info msg="Starting upload purge in 4m0s" go.version=go1.5.2 instance.id=a97415c3-5d7a-42b1-8c91-ab7655951d6e version=v2.2.1
registry_1 | time="2015-12-30T18:59:56Z" level=info msg="redis not configured" go.version=go1.5.2 instance.id=a97415c3-5d7a-42b1-8c91-ab7655951d6e version=v2.2.1
registry_1 | time="2015-12-30T18:59:56Z" level=info msg="using inmemory blob descriptor cache" go.version=go1.5.2 instance.id=a97415c3-5d7a-42b1-8c91-ab7655951d6e version=v2.2.1
registry_1 | time="2015-12-30T18:59:56Z" level=fatal msg="crypto/tls: failed to parse key PEM data"
dockerregistry_registry_1 exited with code 1

@mohanrao Here is the line of code issuing the failure:
https://golang.org/src/crypto/tls/tls.go#L206

Just guessing, this may be a corrupt or encrypted certificate. As @liuchang23 said, posting the first line of the PEM will help (make sure not to post any private key data).
To better understand the issue, we'll need to at least see the configuration, as well.

Thanks @stevvooe and @liuchang23 . Its the cert and key wrong combination. After the cert and key modified to correct combination. the issue resolved. But the error is giving wrong impression

@mohanrao Indeed that is a confusing error message. Looking at the Go tls API, I am not sure if we could infer more from the parse error without delving into the exact mismatch.
How did you go about discovering the mismatch?

I was searching with that error and go tls api specific. Then I discovered it can be the mismatch and used openssl to verify

@mohanrao Great! Thanks for the description!


Research: communication between two smartphones on same app

one phone should display the game state
other phone should update the game's state

implemented with PubNub in 5e88890f8928f


Suggestion: Split pane direction should default to 'down'

I would like to offer a friendly suggestion that the 'Split Pane Direction' setting should default to 'Down' instead of 'Right'.
If there are other notifications present, they block the window for commit comments. You can't see what you are typing and have to exit out of all notification windows first. As you know, notifications default to that same Upper-Right location.

+1: This would be much appreciated


Initial work on adding Dynamic Type support

Related to issue #496.
This patch is not exhaustive - it doesn't make everything use Dynamic Type fonts.
Still, it makes most of the (frequently used) UI scalable, which should be a nice first step and an improvement for people with visibility problems.
Even in the generic case (no visibility problems and font size increase set in Accessibility settings), with this patch, the fonts appear a little larger and more legible than before (addresses issue #1487).
This patch defines some basic fonts, listens for a UIContentSizeCategoryDidChangeNotification and maintains these fonts updated accordingly.
To let the rest of the app know about such font size changes, we send the same kRiotDesignValuesDidChangeThemeNotification which gets dispatched when people change between the Dark/Light themes. Since the intention is similar (UI settings update & redraw), it seemed natural to repurpose it.
Not all fonts are assigned dynamically (widget.font = ..), so not all widgets use the new font values from RiotDesignValues.
In other places, we simply configure the Dynamic Type font inside the .xib file.
UI widgets which have their font defined in the .xib file do not get immediately updated. Using the "Automatically Adjust Font" property seems like an easy viable solution, but it requires iOS>=10, so it hasn't been done.
Signed-off-by: Slavi Pantaleev<EMAIL_ADDRESS>

@spantaleev thanks for this! @giomfo or @manuroe please can you take a look? I know a certain ex-boss who would love for this to land...

@giomfo, thanks for the review!
I've made the changes as per your advice and rebased my changes on top of develop.
Some notes about what wasn't done:

about the bing font, I'm not sure how we can have a medium-weight in a Dynamic Type system. Maybe we should do this in another PR later, if there turns out to be some way of doing it.

I'm not sure how to properly align the boxes in RoomInputToolbarView. Maybe we should do it later in another PR.

Hi @spantaleev, I don't see your changes, did you push them?

@giomfo, it should be --force pushed to the same branch.
As the history in #496 indicates:

my first push was for dd8ab16a04b7391b, which you have reviewed above
since then, I've made: changes based on your feedback, rebased against develop and --force pushed to the same branch (add-dynamic-type), which became commit 05027d64c0acd64

@giomfo, I've just done the following:

removed the changes done to RoomCollectionViewCell.xib
rebased on top of develop again

I guess you could easily take this dynamic-type branch now and continue forward.

Thank @spantaleev to have initiated the Dynamic Type support.
Feel free to provide new PRs on Dynamic Type support by considering thevector-im:dynamic-type branch

Hi
Is this in? If so how can I use it? The fonts are so small

@spantaleev would you by any chance be able to take a look at implementing Dynamic Type again? Sadly it hasn't been properly implemented yet.

No.. Doing it once was enough. I'm not even an iOS developer, so it took some effort and annoyance dealing with the tools.. In the end, it didn't even get merged, so there's no point in doing it again.

@spantaleev completely understandable, thanks for your contribution regardless :)

@giomfo it looks like the dynamic-type branch has been deleted from the element ios tree. Can you provide an update on the effort to add support for dynamic type on ios? This seems like a huge accessibility/readability issue that needs attention.
@spantaleev thank you for your efforts!!


Fix Sublime Text alias. Solves #889

Sublime Text was not opening specified file or folder using the alias. Fixed by removing --args
Details in  #889

Thanks!