feat(cli): Support GitHub Workflow Commands

Summary
See discussion in #441
WIP
Open questions / TODO:

Where to put the env var check? Maybe add a field to TraversalMode::CI that states if the cli is running in some CI (determined by the env vars).
File name escapes

Where to put the env var check? Maybe add a field to TraversalMode::CI that states if the cli is running in some CI (determined by the env vars).

I think so. We could add something like
    CI {
        /// Whether the CI is running in a specific environment, e.g. GitHub, GitLab, etc.
        environment_name: Option<String>
    },

We could create a new function to read the environment variable:

    pub(crate) fn new_ci() -> Self {
        let environment_name = std::option_env!("GITHUB_ACTIONS").and_then(|_| {
            Some(String::from("GITHUB_ACTIONS"))
        });
        Self {
            report_mode: ReportMode::default(),
            traversal_mode: TraversalMode::CI {
                environment_name
            },
            max_diagnostics: MAXIMUM_DISPLAYABLE_DIAGNOSTICS,
        }
    }

This will be called in the ci.rs file

File name escapes

Thanks for the feedback. I've updated the PR.
However, I save the environment as an enum:
pub(crate) enum ExecutionEnvironment {
    GitHub,
}

I also used std::env::var instead of std::option_env! because the latter is a compile-time check and we need a runtime check here.

I'm not sure what you mean; can you explain?

As the workflow commands are just "CSV" [^1], we need to escape , in file names, so the fields/files are not mixed up. At least that's what I thought.
I've looked in the documentation as well as the core library source and did not find any sign of escaping or quoting. Maybe we can just omit this and assume that the file name does not contain a ,.
I still haven't managed to get the diagnostic description due to the printer function using a biome_console Formatter and the diagnostic.description(fmt) expecting an std formatter.
We also need to set the env var GITHUB_ACTIONS in CI, so this feature doesn't break the current tests (since it emits more than before ;)). Setting it to false should work. Or we just update the snapshots.
[1]: "::{} file={},line={},endLine={},col={},endColumn={}::{}"

@ematipico the tests are failing due to the workflow commands being emitted because the whole test suite is executed in GH Actions.
Should we accept these as baseline or set GITHUB_ACTIONS to false in CI tests?
Accepting them as a baseline will likely make it inconvenient to run the tests locally.

@ematipico the tests are failing due to the workflow commands being emitted because the whole test suite is executed in GH Actions. Should we accept these as baseline or set GITHUB_ACTIONS to false in CI tests? Accepting them as a baseline will likely make it inconvenient to run the tests locally.

We should disable this functionality in the snapshot tests; as you said, it would create a lot of friction. Although it would be great if we could have some assertions before printing the snapshot, to make sure that the output is correct.
We can use the redact_snapshot function inside snap_test.rs to remove that message from the final snapshot.

@ematipico I've added it to the redaction in a9d5572d785ccd95d03cf6b07b1e1b139a60e825. There are cases where a workflow command is emitted without a "normal" diagnostic message, which results in the output being empty. To match against current snapshots, I've refactored the method to return an Option<T> and skipped the message as if it wasn't there to begin with.


Add a table with an inner join

Hi,
How can I index a table but add one field another table? (like a left join?)
Mick

You can try either:
Eager load relations
YourModel::with('the_relation')->all()->adToIndex()

or https://github.com/elasticquent/Elasticquent#document-data
function getIndexDocumentData()
{
    return [
        'id'      => $this->id,
        'title'   => $this->title,
        'custom'  => 'variable',
    ];
}

@chuangbo Just a notice that there is a typo 'adToIndex()'.
I tried first one but there is an expection
[BadMethodCallException]
Call to undefined method Illuminate\Database\Query\Builder::all()

I use get() and it worked.

@AlexLove77 Thanks. all() is is typo too.


Provide access to object bounding box in shader

Issue description:

I am working on godot-blender-exporter,  a lot of blender cycle materials make use of blender's  Generated Texture Coordinate (it is an uvw in object's world bounding box) and also Generated Texture Coordinate is useful for anisotropy.

visualize Generate Texture as color

If bound box is providing in godot shader script as a builtin, then it is possible to generate the same uvw as  'Generated Texture Coordinate' in godot and it is not costly to do it.
I have found unreal has Objects Bound and Object Position available in shader. https://docs.unrealengine.com/en-us/Engine/Rendering/Materials/ExpressionReference/Vector

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.
The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.
If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!


日志代码没有清除

Describe the bug
在代码热更新时触发输出以下内容

输出位置位于

Steps to reproduce
No response
System Info
其他无关

Used Package Manager
pnpm
Validations

[X] Follow our Code of Conduct.
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a VueHooks Plus issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion.
[X] The provided reproduction is a minimal reproducible example of the bug.

Describe the bug
在代码热更新时触发输出以下内容  输出位置位于
Steps to reproduce
No response
System Info
其他无关

Used Package Manager
pnpm
Validations

[x]  Follow our Code of Conduct.
[x]  Read the Contributing Guidelines.
[x]  Read the docs.
[x]  Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[x]  Make sure this is a VueHooks Plus issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[x]  Check that this is a concrete bug. For Q&A open a GitHub Discussion.
[x]  The provided reproduction is a minimal reproducible example of the bug.

PR: #103
version: v1.6.0-alpha.3


Fix layout tuner test

This PR reenables the layout tuner test.

Coverage increased (+0.5%) to 63.42% when pulling 72864f3e4c8c7d0fb49e10d60d99f44f8659833c on jarulraj:master into 96d119a09a39bbe029977ae2e9a453f7f331ec0a on cmu-db:master.

@malin1993ml can you check this fix?


prepare use case scenarios

appropriate use case scenarios are created and can be found in wiki

appropriate use case scenarios are created and can be found in wiki


No node awareness for riak clients [JIRA: CLIENTS-882]

Currently HttpClusterPoolClient does not know whether all the hosts in the hosts list are up and running. If by chance a node goes down, it will keep trying that host everytime a new request gets in. So for example is the timeout on the http client is 10 seconds, then we will waste 10 seconds of our time by just trying the host which is down. We need to have a heartbeat mechanism for riak clients which will continuously monitor whether the hosts are up and when it detects that a host is down, it needs to quarantine that client till the host becomes active again.

I have coded this up and i can submit a pull request soon

Hi @arunvisw,
The 2.0 client has heartbeats, node health, etc built-in.  What version are you running?
Thanks,
Alex

1.4.4... the problem is we are using 1.4.2 riak and cannot use the new 2.0 client which is not backward compatible..

@alexmoore

@arunvisw both Riak 1.4.2 and Riak Java client 1.4.4 are no longer supported. We appreciate your offer of a PR but can't accept it due to the old Riak Java client no longer being supported.
Riak Java clients 2.0 and later are compatible with Riak 1.4.X versions, however, so that may be an option for you.
Thanks

Won't fix, for an older version of the Java Client.
[posted via JIRA by Alexander Moore]


optional background color value in savePixmap() settings

Fix for #274

@edzis Apologies -- I didn't notice until now that you had added commits to this PR (I don't get a notification if commits are added, only if there's an actual message).
Anyway, since I was so late on this, I took the liberty of rebasing 913f6c7 and fixing it up relative to our new convert.js file. That commit has now landed in master (with you as the author) as fca3a145ca0943d377d53ed080e760e63ec04887
I'm not sure what you were going for in a3f1116, but it doesn't seem complete (or necessary). So, I've left that commit out for now.
I'm going to close this PR (as merged, even though it won't say that). If you have something you need to add for padding fill, please open a new PR.
And again, sorry for the huge delay. Thanks for your contribution!

@joelrbrandt Thanks for the merge and glad to be able to help.
The a3f1116 is another and proper fix for my mall-articulated problem. It might deserve it's own PR..  Sorry for lack of explanation from my part.
After the original commit I realized that -background is too aggressive for my needs - it fills also those areas that I had intentionally left with transparency. I need to transform pixmap data in a way that the alpha channel is needed. What I was missing is a way to colorize everything else outside the pixmap boundaries. This is what I have done in a3f1116.

Ahh, I see. Well, I'd welcome a PR that does what you mention in a3f1116. However, please make sure that the addition is documented, and that you do the same argument validation as is done for settings.background


Telemetry

We need to land a telemetry story (i.e. if/what to measure, how to opt in/out, how users can view what is being sent, how to configure different telemetry endpoints for different environments, the technology used to implement telemetry and how to wire it throughout the codebase, etc.)

Done for initial release with #717 and other PRs. Will close this tracking issue for now, and open new issues for additional telemetry requirements.


Update version to 1.1.16-11 on staging

Update version to 1.1.16-11

🚀 Deployed to staging by @OSBotify in version: 1.1.16-11 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @roryabraham in version: 1.1.17-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Error: Unable to Register Application with android app

First ever issue on github, hope I am formatting this the right way.
Home Assistant release with the issue:
 Home Assistant 0.103.4
Last working Home Assistant release (if known):
None
Operating environment (Hass.io/Docker/Windows/etc.):

Operating on a synology within docker container.
homeassistant-home-assistant image.
Synology is attached to the network.
Port 80/443/8123 are forwarded
Integration:
https://www.home-assistant.io/integrations/mobile_app#apps
Description of problem:
When I manually try to reach my home assistant through the android app (home assistant),
I reach the inlogscreen. when I try to log in i get the notification:
Unable to Register Application
Please check to ensure you have the mobile_app integration enabled on your home assistant instance.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

# Configure a default setup of Home Assistant (frontend, api, etc)
default_config:

# Uncomment this if you are using SSL/TLS, running in Docker container, etc.
 https:
   base_url: https://www.domain.nl

# Text to speech
tts:
  - platform: google_translate

homeassistant:
  latitude: xxxx.xxxxx
  longitude: x.xxxxxxx
  elevation: 2
  unit_system: metric
  time_zone: Europe/xxxxx
  name: Home
  customize: !include customize.yaml

group: !include groups.yaml
automation: !include automations.yaml
script: !include scripts.yaml
scene: !include scenes.yaml

frontend:
  themes: !include themes.yaml

influxdb:
  host: xxx.xxx.xxx.xx

mqtt:
  broker: !secret mqtt_url
  port: !secret mqtt_port
  client_id: home-assistant
  discovery: true
  discovery_prefix: homeassistant

yeelight:
  devices:
    xxx.xxx.xxx.xxx:
      name: Overloop

panel_iframe:
  configurator:
    title: Configurator
    icon: mdi:wrench
    url: 'http://xxx.xxx.xxx.xx:xxxx'

hacs:
  token: ***********************************************

sensor: !include sensor.yaml

Try to clear data in the app and login again to see if that fixes the issue.

Try to clear data in the app and login again to see if that fixes the issue.

I tried this, no Luck. Also reinstalled the app multiple times. Doesnt change the outcome

I get this if I use my own domain (lets encrypt ssl and nginx proxy)... if I use nabu https it works.

Found this issue via google. Cleaning app data worked for me!
Must be due to previous tests inside my WiFi.
@edgardluz
For me HA does work as synology docker container with synology reverse proxy and let's encrypt cert.

Can you guys try again with the latest android app (1.7.0) and latest HA version (0.105)?  You may need to start fresh with the app to ensure nothing else is lingering
https://companion.home-assistant.io/docs/troubleshooting/resetting

Working Fine now
On Wed, 12 Feb 2020, 20:32 Daniel Shokouhi<EMAIL_ADDRESS>wrote:

Can you guys try again with the latest android app (1.7.0) and latest HA
version (0.105)? You may need to start fresh with the app to ensure nothing
else is lingering
https://companion.home-assistant.io/docs/troubleshooting/resetting
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/issues/30565?email_source=notifications&email_token=AOFR35OP4FBOQGCSTIDQANDRCRFDXA5CNFSM4KD7PCKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELSCTDI#issuecomment-585378189,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOFR35J6EHH2XFLFKZ7KDBDRCRFDXANCNFSM4KD7PCKA
.

Closing as fixed

Still get the same. Removed the app. Installed the latest (1.7). Have no entry in the configuration -> integration.
When I use the app I can see the following in my home assistant logs:
WARNING (MainThread) [homeassistant.components.webhook] Received message for unregistered webhook null

Any suggestions on how to debug this further?

@parberge so you don't have any mobile_app integrations at all? usually the unregistered webhook gets fixed when you perform the starting fresh steps:  https://companion.home-assistant.io/docs/troubleshooting/faqs#starting-fresh-with-the-android-app

@dshokouhi I had it "working" (before it had GPS location stuff), so I thought so. Read through the guide and I had totally missed the required default_config:.
Added that, removed everything again, and voila, now it works! Thanks and sorry for not reading the guide properly

this is still an issue for me. i previously had the app working fine but had uninstalled and re-installed the app. now i get the 'unable to register application' notice. i previously did not have default_config: in my config.yaml but instead mobile_app: i have since tried with each and both together by using the starting fresh with android as previously linked but i still get the same issue each time
using samsung galaxy s10
home assistant (hassio) v.105.2

@tbar05 can you add your device info to: https://github.com/home-assistant/home-assistant-android/issues/132
I believe its the same issue correct?

@dshokouhi the issue is the same as outlined here. i get a 'unable to register application' - please check to ensure you have the mobile_app integration enabled on your home assistant instance. that seems slightly different to the other issue of 'Unable to connect to Home Assistant'

any errors in the HA logs when you attempt to login?

@dshokouhi i get this in the log...
Error handling request
9:58 AM components/person/__init__.py (ERROR)

Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/aiohttp/web_protocol.py", line 418, in start
    resp = await task
  File "/usr/local/lib/python3.7/site-packages/aiohttp/web_app.py", line 458, in _handle
    resp = await handler(request)
  File "/usr/local/lib/python3.7/site-packages/aiohttp/web_middlewares.py", line 119, in impl
    return await handler(request)
  File "/usr/src/homeassistant/homeassistant/components/http/real_ip.py", line 39, in real_ip_middleware
    return await handler(request)
  File "/usr/src/homeassistant/homeassistant/components/http/ban.py", line 72, in ban_middleware
    return await handler(request)
  File "/usr/src/homeassistant/homeassistant/components/http/auth.py", line 135, in auth_middleware
    return await handler(request)
  File "/usr/src/homeassistant/homeassistant/components/http/view.py", line 123, in handle
    result = await result
  File "/usr/src/homeassistant/homeassistant/components/http/data_validator.py", line 50, in wrapper
    result = await method(view, request, *args, **kwargs)
  File "/usr/src/homeassistant/homeassistant/components/mobile_app/http_api.py", line 80, in post
    DOMAIN, data=data, context={"source": "registration"}
  File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 109, in async_init
    result = await self._async_handle_step(flow, flow.init_step, data)
  File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 172, in _async_handle_step
    result: Dict = await getattr(flow, method)(user_input)
  File "/usr/src/homeassistant/homeassistant/components/mobile_app/config_flow.py", line 47, in async_step_registration
    self.hass, user_input[CONF_USER_ID], devt_entry.entity_id
  File "/usr/src/homeassistant/homeassistant/components/person/__init__.py", line 108, in async_add_user_device_tracker
    if device_tracker_entity_id in device_trackers:
TypeError: argument of type 'NoneType' is not iterable

Similar to @tbar05 , I get the same errors in log.

hassion: 0.105.3
MobileApp (Android): 1.7.1

Traceback (most recent call last):
File "/usr/local/lib/python3.7/site-packages/aiohttp/web_protocol.py", line 418, in start
resp = await task
File "/usr/local/lib/python3.7/site-packages/aiohttp/web_app.py", line 458, in _handle
resp = await handler(request)
File "/usr/local/lib/python3.7/site-packages/aiohttp/web_middlewares.py", line 119, in impl
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/real_ip.py", line 39, in real_ip_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/ban.py", line 72, in ban_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/auth.py", line 135, in auth_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/view.py", line 123, in handle
result = await result
File "/usr/src/homeassistant/homeassistant/components/http/data_validator.py", line 50, in wrapper
result = await method(view, request, *args, **kwargs)
File "/usr/src/homeassistant/homeassistant/components/mobile_app/http_api.py", line 80, in post
DOMAIN, data=data, context={"source": "registration"}
File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 109, in async_init
result = await self._async_handle_step(flow, flow.init_step, data)
File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 172, in _async_handle_step
result: Dict = await getattr(flow, method)(user_input)
File "/usr/src/homeassistant/homeassistant/components/mobile_app/config_flow.py", line 47, in async_step_registration
self.hass, user_input[CONF_USER_ID], devt_entry.entity_id
File "/usr/src/homeassistant/homeassistant/components/person/init.py", line 108, in async_add_user_device_tracker
if device_tracker_entity_id in device_trackers:
TypeError: argument of type 'NoneType' is not iterable

@balloob Any ideas? I don't know enough about person and device_tracker :(

Please start a new issue, don't reopen old issues with new problems, just because the title of the issue matched.

Hello,
I just updated the android companion (1.8.0) and I got the same message "Unable to Register Application" with Hass 0.104.3
So I updated Hass to 0.105.5 (same error) then I updated Hass to 0.106.2 (same error)
And I have default_config: set in the configuration
I don't see anything in Hass logs when I try to connect (in info level).
I tried https://companion.home-assistant.io/docs/troubleshooting/faqs#starting-fresh-with-the-android-app without success

I got this log in the log file, only the first time I try to connect with the android app:
2020-03-01 10:55:46 DEBUG (SyncWorker_0) [homeassistant.helpers.storage] Writing data for auth
2020-03-01 10:55:53 DEBUG (MainThread) [homeassistant.components.http.view] Serving /auth/login_flow/4e4b05953baf47a3af479f5e8bb17bc7 to <IP_ADDRESS> (auth: False)
2020-03-01 10:55:54 DEBUG (MainThread) [homeassistant.components.http.view] Serving /auth/token to <IP_ADDRESS> (auth: False)

@balloob Should I open a new issue ? (It seems to be the same as this one) if yes, where ? in this project or in the android app ?
Here a summary of my tries:

Android app
Hass
state
Notes

1.7.0
0.104.3
Failed

1.8.0
0.104.3
Failed

1.8.0
0.105.5
Failed

1.8.0
0.106.2
Failed

1.8.0
dev branch
Failed

1.8.0
dev branch
Failed
fresh install of android app and hass (empty config dir)

Nevermind, The root cause issue is that I don't have google play services ...
https://github.com/home-assistant/home-assistant-android/issues/231


OpenSSL 3.0.0 deprecates ENGINE APIs

https://www.openssl.org/docs/man3.0/man7/migration_guide.html
It looks like OpenSSL 3.0.0 deprecates ENGINE related APIs and bunch of low-level getters and setters.
There are lots of deprecation warnings when compiled with OpenSSL 3.0.0.

A fix for me using  libressl (pretty sure it's the same issue) is to use the OPENSSL_NO_ENGINE def (from /usr/local/include/openssl/opensslfeatures.h) in neverbleed.c.
--- deps/neverbleed/neverbleed.c.orig   2023-12-11 18:48:55 UTC
+++ deps/neverbleed/neverbleed.c
@@ -2220,6 +2220,7 @@ int neverbleed_init(neverbleed_t *nb, char *errbuf)
         EC_KEY_METHOD_set_sign(ecdsa_method, ecdsa_sign_proxy, NULL, NULL);
 #endif

+#if !defined(OPENSSL_NO_ENGINE)
         if ((nb->engine = ENGINE_new()) == NULL || !ENGINE_set_id(nb->engine, "neverbleed") ||
             !ENGINE_set_name(nb->engine, "privilege separation software engine") || !ENGINE_set_RSA(nb->engine, rsa_method)
 #ifdef NEVERBLEED_ECDSA
@@ -2230,6 +2231,7 @@ int neverbleed_init(neverbleed_t *nb, char *errbuf)
             goto Fail;
         }
         ENGINE_add(nb->engine);
+#endif
     }
 #endif

Going by the name, I would think it is not libressl specific.


pfTableView: change templateFn to receive the row item as second parameter

fix #665
@dtaylor113

Commit message needs to be formatted for semantic release. See https://github.com/patternfly/angular-patternfly#git-commit-guidelines

Formatted the commit message according to semantic release.


Bump version 5.0.0

Bump version 5.0.0

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (345b5ce) 66.82% compared to head (f30833a) 43.84%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #148       +/-   ##
===========================================
- Coverage   66.82%   43.84%   -22.98%
===========================================
  Files        3284     1558     -1726
  Lines       63184    31392    -31792
  Branches    10052     5930     -4122
===========================================
- Hits        42223    13764    -28459
+ Misses      18481    16598     -1883
+ Partials     2480     1030     -1450

Flag
Coverage Δ

Linux_1
?

Linux_2
?

Linux_3
43.84% <ø> (-0.01%)
:arrow_down:

Linux_4
?

Windows_1
?

Windows_2
?

Windows_3
?

Windows_4
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Bump version to 1.4.2

Checklist

[ ] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

Whenever possible python packages should use pip. See https://conda-forge.org/docs/meta.html#use-pip

@PrimozGodec Do you have any idea why this fails? It seems like an issue with a compiler. Do we need to set it explicitly somewhere?

https://github.com/conda-forge/orange3-network-feedstock/pull/12


User-facing constructor for TaggedTable

Is your feature request related to a problem?
It's not possible to "hide" the __init__ method from users via naming conventions. Moreover, it's the default place users go to instantiate a class. Because of this, it should be usable and not reveal internals.
Desired solution
Make the __init__ of TaggedTable work like the __init__ of Row. Replace current internal calls to the constructor with calls to TaggedTable._from_pandas_dataframe or TaggedTable.from_table (which has to be tested and added).
Possible alternatives (optional)
No response
Screenshots (optional)
No response
Additional Context (optional)
No response

:tada: This issue has been resolved in version 0.12.0 :tada:
The release is available on:

v0.12.0
GitHub release

Your semantic-release bot :package::rocket:


Upgrade go.mod dependencies

What type of PR is this?

Uncomment only one  /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:
Have you updated the necessary documentation?

[ ] Documentation update is required by this PR.
[ ] Documentation has been updated.

Which issue(s) this PR fixes:
Fixes #?
How to test changes / Special notes to the reviewer:

/retest

/retest


Add fwts test results for Dell Inspiron 3521

I removed the board serial number, chassis serial number, product serial number, and product UUID. Let me know if one of those is necessary, and I can add it back in. Thanks

You did well. I could not really find if SN are a private data or not so I am deleting them by precaution.
Nice contribution. I was looking forward famous devices :)

Glad I could help, and thanks for deleting the serial number. I'll add some more devices in a bit.


Animated component - attach/detach native views on each render

I just noticed, that each re-render of my animated component, it will detach and attach native events for the same view.
I believe the root cause is the check in componentDidUpdate, which uses this._prevComponent to do equality check.
https://github.com/facebook/react-native/blob/master/Libraries/Animated/src/createAnimatedComponent.js#L197-L205
The issue is that  this._prevComponent will always be undefined, since we only set it inside setRef method, which being invoked only once per component instance.
https://github.com/facebook/react-native/blob/master/Libraries/Animated/src/createAnimatedComponent.js#L143-L145
Currently not sure, what is intended behaviour in componentDidUpdate method. So just raising issue without PR.
Another concern is related to UNSAFE_componentWillReceiveProps. This will invoke __detach on every parent re render, even if props are same.

I ran into this issue as well. Did you ever find a workaround?

Switching to the react-native-reanimated library solved the issue.


Firebase Analytics Flutter Example doesn't work

Describe the bug
I have downloaded Flutter Example but failed to build it.
To Reproduce
Steps to reproduce the behavior:

Go to https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_analytics/firebase_analytics/example
Clone repo for source codes
Do flutter pub get in the folder

Expected behavior
Pubs should be updated, the project should build without errors
Flutter doctor
Run flutter doctor and paste the output below:
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, 1.20.0, on Mac OS X 10.15.5 19F101, locale ru-RU)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 11.6)
[✓] Android Studio (version 4.0)
[✓] VS Code (version 1.47.3)
[✓] Connected device (4 available)
I met 2 issues
#1
[i] flutter pub get
Running "flutter pub get" in i...
Could not find a file named "pubspec.yaml" in "/Users/user/Desktop/cm".
pub get failed (66; Could not find a file named "pubspec.yaml" in "/Users/user/Desktop/cm".)
exit code 66
#2 in main.dart
Undefined name 'Firebase'.
Try correcting the name to one that is defined, or defining the name.dartundefined_identifier

Hi @Dersh,
I tried to replicate the issue you mentioned, but I was able to run firebase_analytics example properly without any issues.
I am on latest Stable (1.20.1).
I cloned the flutterfire repo and then opened the specific package example firebase_analytics as  flutterfire -> packages ->firebase_analytics ->firebase_analytics -> example.

I've run into a similar problem. I went to flutterfire/packages/firebase_auth/firebase_auth/example and ran flutter pub get. I got this as the output:

Because every version of firebase_dynamic_links from path depends on firebase_core from hosted and firebase_auth_example depends on firebase_core from path, firebase_dynamic_links from path is forbidden.
So, because firebase_auth_example depends on firebase_dynamic_links from path, version solving failed.
Running "flutter pub get" in example...
pub get failed (1; So, because firebase_auth_example depends on firebase_dynamic_links from path, version solving
failed.)

Same thing here:
date
su 23.8.2020 20.55.38 +0300
cd ~/git/Omat/flutterfire/packages/firebase_auth/firebase_auth/example
git pull
Already up to date.
flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 1.20.2, on Linux, locale en_US.UTF-8)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
[✓] Android Studio (version 3.5)
[✓] Android Studio (version 4.0)
[✓] Connected device (1 available)

• No issues found!

flutter pub get
Because every version of firebase_dynamic_links from path depends on firebase_core from hosted and firebase_auth_example depends on firebase_core from path, firebase_dynamic_links from path is forbidden.
So, because firebase_auth_example depends on firebase_dynamic_links from path, version solving failed.
Running "flutter pub get" in example...
pub get failed (1; So, because firebase_auth_example depends on
firebase_dynamic_links from path, version solving failed.)

Is this example working for anyone???
It would be nice to get on with flutter & google authentication.

I made a new issue, with the same contents as @sudiptachatterjee at https://github.com/FirebaseExtended/flutterfire/issues/3300
(because it is about firebase_auth, not about firebase_analytics as here.)

Closing in favor of #3300.
Could not find a file named "pubspec.yaml" in "/Users/user/Desktop/cm".
pub get failed (66; Could not find a file named "pubspec.yaml" in "/Users/user/Desktop/cm".)

This seems to indicate an issue outside of this library also.


Typo in 'Create a pipeline run'

$RunId = Invoke-AzDataFactoryV2Pipeline `
    -DataFactoryName $DataFactory.DataFactoryName `
    -ResourceGroupName $ResGrp.ResourceGroupName `
    -PipelineName $DFPipeLine.Name

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8423caa5-6655-e1b3-b57c-ac9e99f53965
Version Independent ID: 686acc4c-a955-c0a4-44a3-2ea2818554f0
Content: Copy data in Blob Storage using Azure Data Factory
Content Source: articles/data-factory/quickstart-create-data-factory-powershell.md
Service: data-factory
GitHub Login: @linda33wj
Microsoft Alias: jingwang

@bebekim, Thank you for sharing the query. We are looking into this and will get back to you soon on this thread.

@bebekim Thanks for your contribution, I've addressed this issue in PR: https://github.com/MicrosoftDocs/azure-docs-pr/pull/91412.
The changes should be live EOD or tomorrow. We will now close this issue. In future, if you see any minor bug fixes in the doc, feel free to click on the edit button and submit a PR to update. we love to take community contributions


Can't install npm dependency from github

Hi,
It would be nice if it was possible to install the dependency from github since it deviated quite a bit from the last release. e.g.:
npm install github:substance/texture --save

That 'installs' fine but the dependency can't be imported. Which I think is because the bundle is missing.

I've added a postinstall hook, to build the bundle. Can you try again?

Well that does not seem to work. I think we need the npm releases because of that said build step.

Okay, I think some other projects either provide a bundle built by CI or the source is standard enough to be understood. I noticed that your latest preview is actually in npm. So it is probably not an issue if those are available frequently.

Yes, we'll count them up frequently (at least the preview channel), as we have softwares depend on Texture. E.g. https://github.com/stencila/stencila

@de-code I think this should be possible now, after I have re-factored the build configuration via #454.


[ ] Added/Updated related tests.

Short description of the change(s)
#1046

@kshyju can you please take a look at the new documentation when you have the time? Will like to get your feedback as you are the one who reported it :)
Thanks!


The InvalidPSF objects should not be used, but we should be able to copy them

The HAL.get_simulated_dataset(self, name) function calls makes a deepcopy of the HAL instance clone = copy.deepcopy(self) on https://github.com/giacomov/hawc_hal/blob/master/hawc_hal/HAL.py#L523.
It crashes when any of the response bin contains an invalid PSF (even if the bin is not part of the active planes):
File "/Users/cr/miniconda2/envs/myconda/lib/python2.7/site-packages/hawc_hal/psf_fast/psf_wrapper.py", line 179, in __getattribute__
    raise InvalidPSFError("Trying to use an invalid PSF")
hawc_hal.psf_fast.psf_wrapper.InvalidPSFError: Trying to use an invalid PSF

This commit fixes that. I'm not sure if that's the best solution though, comments welcome.

That's perfect!
Please add a comment to explain why that is necessary and a quick test using the copy module (not the parallel feature, for which you would need a running ipython cluster) that both copy.copy and copy.deepcopy work.


mingwpy: what do we do for [win and py35] support?

Our current mingwpy recipe skips py35 on win, but we have deprecated py34 on win, meaning we can no longer build any packages that depend on mingwpy for win.
conda-force provides mingwpy for py35 win. Can we use this instead?

I recommend checking with https://mingwpy.github.io and their forums. Py35 uses vs2015 on win which has a totally different ABI and runtime link design. The last time I was involved, mingw did not support it yet.
Why did we deprecate py34 on win?
Sent from my iPhone

On Aug 6, 2016, at 5:18 PM, John Chodera<EMAIL_ADDRESS>wrote:
Our current mingwpy recipe skips py35 on win, but we have deprecated py34 on win, meaning we can no longer build any packages that depend on mingwpy for win.
conda-force provides mingwpy for py35 win. Can we use this instead?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Is it accurate that we have deprecated py34 on Windows? There's no issue about it, and it's still in the Appveyor yaml.
Sent from my iPhone

On Aug 6, 2016, at 5:18 PM, John Chodera<EMAIL_ADDRESS>wrote:
Our current mingwpy recipe skips py35 on win, but we have deprecated py34 on win, meaning we can no longer build any packages that depend on mingwpy for win.
conda-force provides mingwpy for py35 win. Can we use this instead?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

My bad---I just read the appveyor test failures incorrectly. We're still building against py34 on win.
I'll punt on any changes then.

And thanks!


MSID: 90505 Version: 1 DOI: 2<IP_ADDRESS>3194

"msas": "Physics of Living Systems"
"msid": "90505"
"preprintDoi": "10.1101/2<IP_ADDRESS>3194"
"Reviewed Preprint posted": "2023-11-10"
"Sent for peer review": "2023-08-03"
"Posted to bioRxiv": "2023-08-15" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>3194v1/")
[PLACE PDF URL HERE WHEN AVAILABLE] See step 7
Step 1. Inform bioRxiv
Who can help: @QueenKraken, @nlisgo, @scottaubrey

[x] Manuscript is in data hub index (https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=90505)

Step 2. Create preview of manuscript
Who can help: @fred-atherden, @nlisgo, @scottaubrey

[ ] Manuscript is available for preview (https://prod--epp.elifesciences.org/preview/90505/v1)

[ ] Trigger import for staging: https://prod--epp.elifesciences.org/import
[ ] Sync data folder with s3://prod-elife-epp-data/data
[ ] Trigger import for staging: https://staging--epp.elifesciences.org/import
[ ] Sync data folder with s3://staging-elife-epp-data/data
[ ] Pull request created to enhanced-preprint-data
[ ] Post link to pull request below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-manuscript
Step 3: Awaiting public reviews and QC
Who can help: Production team

[ ] QC passed or QC not needed

Who can help: Editorial team

[x] Public reviews available on sciety (https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>3194)
[x] Manuscript and editor details at the top of this issue (Supplied by Editorial team)
[ ] Reviews returned by EPP - https://prod--epp.elifesciences.org/api/reviewed-preprints/90505/v1/reviews

Example
"msas": "Genetics and Genomics", "Neuroscience"
"msid": "84628"
"version": "1"
"preprintDoi": "10.1101/2<IP_ADDRESS>4241"
"articleType": "Reviewed Preprint"
"status": "Published from the original preprint after peer review and assessment by eLife."

"Reviewed Preprint posted": "2023-01-02"
"Sent for peer review": "2022-10-28"
"Posted to bioRxiv": "2022-11-21" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>4241v1")

Editors:
Reviewing Editor
Michael B Eisen
University of California, Berkeley, United States
Senior Editor
Michael B Eisen
University of California, Berkeley, United States

Step 4: Modify manuscripts.json (no PDF)

[ ] Reviewed preprint is published to EPP (https://elifesciences.org/reviewed-preprints/90505)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[ ] Request that a doi be registered

[ ] Post link to #enhanced-preprint comment below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]

Instructions to modify manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/publish-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/334/files
Once the pull request is merged in it should be available a few minutes later.

Request that a doi
Post the following in #enhanced-preprint:
@Fred can you register a doi for https://elifesciences.org/reviewed-preprints/90505

Step 5: Awaiting search reindex

[ ] Reviewed preprint is avaliable on journal homepage (https://elifesciences.org)

The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.

Additional info
If needed, the jenkins pipeline to reindex search can be triggered sooner.
https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 6: Published! Request PDF generation

[ ] Post the link to the PDF url at the top of the issue

[ ] Post link to #enhanced-preprint comment below

#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]
Post the following to the #enhanced-preprint on slack:
@Ryan Dix-Peek please can you generate a PDF for https://elifesciences.org/reviewed-preprints/90505

Step 7: Introduce PDF to data folder and git repo

[ ] PDF is avaliable at https://github.com/elifesciences/enhanced-preprints-data/raw/master/data/90505/v1/90505-v1.pdf

Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-pdf
Step 8: Add PDF url to manuscripts.json

[ ] Reviewed preprint PDF is available for download (https://prod--epp.elifesciences.org/reviewed-preprints/90505)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[PLACE LINK TO PULL REQUEST HERE]

Instructions to add PDF url to manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/add-pdf-url-to-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/397/files
Once the pull request is merged in it should be available a few minutes later.

Step 9: Done!

[ ] Kettle is on!

Duplicate content within references e.g.
Mielke 1988
Landau L, Lifshitz E 1971

Nicely done Rebecca. Both of these are mistagged. I'll fix with an xsl and reload

@rkcook312 should be fixed now. Please check and update

@fred-atherden, issue fixed but also noticed another problem from whats present in the preprint, some of the citations are not hyperlinked to the reference list but instead just bold?
(Levayer and Lecuit (2012)
Blankenship et al. (2006)
(Vuong-Brender et al. (2017a)
Kirchhoff and Hensel (1883)
Moulton et al. (2020a)
Vuong-Brender et al. (2017b)
Page and Johnstone (2007)
Schulz et al. (2022b,a)
Goriely and Ta- bor (2013)
Howard and Clark (2002)

Thanks @rkcook312 - are these present in the preprint on bioRxiv as well? If so, I think we should proceed as is.

Thanks @fred-atherden, yes these are present in bioRxiv, I'll give this one last check and then QC OK.


Python 3 + Django 1.9 error

Dear All
Using it (1.1.0) with Python 3 + Django 1.9 error I got this error in models.py line 44
AttributeError: 'dict' object has no attribute 'has_key'
def votes_for(cls, model, instance=None):
    *
    return cls.objects.filter(**kwargs) <----

Thanks!
D

I have updated the package on pypi, you can now download the latest version of django-vote(1.1.2) from pypi which has supported Python 3.


Minimal changes to support llvm-15

Inside Meta we're pushing to support llvm-15, so need some minor API changes.
The biggest difference since 11 is the move to opaque, untyped pointers; I've applied LLVMContext::setOpaquePointers(false) to work around this for now, and hopefully the move to MLIR will obviate this by the time LLVM 16 comes around.

Is it ok to delay this until after the triton-mlir merge? triton-mlir uses LLVM-14 right now, and it still will at merge time. Then, one of the first thing that will be done after the merge will be to switch to LLVM ~HEAD

That sounds fine; we’ve got an internal patch stack for changes like this so we aren’t blocked, I just expected it might be useful upstream too 🙂

@ptillet - to take advantage of this discussion - would there be any interest in a pull request with the changes required for opaque pointers? (if yes - I'm happy to send it (after some additional testing / cleanup)) (the changes should be fine for both LLVM-11 and LLVM-14 (to the best of my knowledge))

Might be helpful if the patch can contribute to trition-mlir directly, from my perspective.


Add list of client libraries to README

Description

Adds a list of currently existing client libraries to the README file for the overall Flagr project.
Motivation and Context

This makes it clear which languages might still benefit from implementation, and allows a central place to find client libraries even if they're not officially supported (a field could be added to denote official support later).
How Has This Been Tested?

Markdown preview within GitHub.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

None of the above. Minor docs change.
Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Codecov Report

Merging #383 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #383   +/-   ##
=======================================
  Coverage   83.01%   83.01%
=======================================
  Files          27       27
  Lines        1755     1755
=======================================
  Hits         1457     1457
  Misses        214      214
  Partials       84       84

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea10604...845f22f. Read the comment docs.

Related to https://github.com/checkr/flagr/issues/378, I think we can add the list of clients (including all the community generated clients) to the docs - or even better, a dedicated page for SDK/clients and how to generate them from the openapi(swagger) spec.
https://github.com/checkr/flagr/blob/master/docs/_sidebar.md
https://checkr.github.io/flagr/#/


ERROR 500 or 503

The problem
I have successfully installed the add-on but when I go in to edit the google created in "rclone.conf" like in the example I am not directed to the google authorization page.
The first time it seems to direct to a page but then returns to the gui.
Subsequent times it gives a "500" error and nothing can be done.
Where could be the problem?
The same thing happens with oneDrive
Is there a beginner's guide?

[SOLVED]
I make a connection with a windows tool that work fine and I've put token in rclone.conf  in HASSIO and work fine!!!
Thanks for this add-on!

Expiriencing the same issue Error creating config. Error: Request failed with status code 500 when I believe the UI is supposed to be displaying the google auth page, I don't know any other way of getting a token

[SOLVED] I make a connection with a windows tool that work fine and I've put token in rclone.conf in HASSIO and work fine!!! Thanks for this add-on!

could you tell me, whitch tool you use? I ran into the same issue. I was trying to add dropbox but it dosen't open the oauth Page.

ah found out. Rclone is also available for windows (never heard of before). There I created a conf file and conection is working now.


Not an edit command

After installing i tried to add use it and got this error;

Not an editor command: Aerojump kbd space

Configs:
nmap <leader>as <Plug>(AerojumpSpace)

same here

To those encountering this issue, make sure that your Vim/Nvim has Python3 support. echo has("python") should print 1.

For anyone wondering what Python3 support means - install pynvim.


Join declaration and assignment

@gpetrou if you rework those line, maybe switching to var is also a good task if possible. Thanks for the contribution!

Sometimes I do that such as var bytes = new List(self._bytes); in this PR, but many times the type is not clear, so I leave it as it is.


Discriminator information for parent types used in properties

Taking a look at the graph metadata for beta , there exists the userSet type which is abstract.
<ComplexType Name="userSet" Abstract="true">
  <Property Name="isBackup" Type="Edm.Boolean" />
</ComplexType>

It also has several other derived types (such as externalSponsors, groupMembers,  internalSponsors) as shown below.
<ComplexType Name="externalSponsors" BaseType="graph.userSet" />
<ComplexType Name="groupMembers" BaseType="graph.userSet">
  <Property Name="description" Type="Edm.String" />
  <Property Name="id" Type="Edm.String" />
</ComplexType>
<ComplexType Name="internalSponsors" BaseType="graph.userSet" />
<ComplexType Name="logicAppTriggerEndpointConfiguration" BaseType="graph.customExtensionEndpointConfiguration">
  <Property Name="logicAppWorkflowName" Type="Edm.String" />
  <Property Name="resourceGroupName" Type="Edm.String" />
  <Property Name="subscriptionId" Type="Edm.String" />
</ComplexType>

The abstract userSet type is referenced through properties of other classes as shown below
<ComplexType Name="approvalStage">
  <Property Name="approvalStageTimeOutInDays" Type="Edm.Int32" />
  <Property Name="escalationApprovers" Type="Collection(graph.userSet)" />   -----> SEE HERE
  <Property Name="escalationTimeInMinutes" Type="Edm.Int32" />
  <Property Name="isApproverJustificationRequired" Type="Edm.Boolean" />
  <Property Name="isEscalationEnabled" Type="Edm.Boolean" />
  <Property Name="primaryApprovers" Type="Collection(graph.userSet)" />   -----> SEE HERE
</ComplexType>
<ComplexType Name="assignmentReviewSettings">
  <Property Name="accessReviewTimeoutBehavior" Type="graph.accessReviewTimeoutBehavior" />
  <Property Name="durationInDays" Type="Edm.Int32" />
  <Property Name="isAccessRecommendationEnabled" Type="Edm.Boolean" />
  <Property Name="isApprovalJustificationRequired" Type="Edm.Boolean" />
  <Property Name="isEnabled" Type="Edm.Boolean" />
  <Property Name="recurrenceType" Type="Edm.String" />
  <Property Name="reviewers" Type="Collection(graph.userSet)" />          -----> SEE HERE
  <Property Name="reviewerType" Type="Edm.String" />
  <Property Name="startDateTime" Type="Edm.DateTimeOffset" />
</ComplexType>

The generated OpenAPI description.
    microsoft.graph.userSet:
      title: userSet
      type: object
      properties:
        isBackup:
          type: boolean
          description: 'For a user in an approval stage, this property indicates whether the user is a backup fallback approver.'
          nullable: true

Question
Should the userSet type have the appropriate discriminator mappings for the derived types? Or is this only limited to types used in nav properties?
The current situation leads to Kiota failing to generate the derived type models of the userSet class.
cc @baywet, @irvinesunday , @darrelmiller

Thanks for reporting this!
The fact that a type is exposed through a navigation property or a "regular" property doesn't change the inheritance structure.
An approval stage could perfectly come back with a group members entry in the escalation approvers property. In that case the service should annotate the odata type at that level to help the client deserialize to the correct target type. And the client should know what to do with it.
So yes, even in that specific case, the conversion library should add that information to the component.

Thanks for clarifying on this one @baywet


support intents

ugh, gitskarios lost my message. https://github.com/sahan/Travis-Jr supports this, but it no longer works.

Could you please provide better description? Which kind of Intents support do you expect?

yeah, sorry about that, I was on my phone.
Basically, when I tap "view build" in google inbox, I get the option to open it in a web browser or in travis jr, since travis jr has registered itself to open urls at "travis-ci.org"
I believe this is where it registers itself: https://github.com/sahan/Travis-Jr/blob/1d0c83b1857a5080ebf0f7d51dbd94ba8fcbdb69/travisjr/AndroidManifest.xml#L55

Hey hey hey!
Gitskarios dev here.
I was planning to do a new Travis app, but just saw that one.
If the developer adds intent-filter support, it will be awesome!


polish(create-docusaurus): add comment in config to mention different ways to declare config + doc link

Pre-flight checklist

[X] I have read the Contributing Guidelines on pull requests.
[ ] If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
[ ] If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Fixes #8925 - Docusaurus config is confusing: const config vs module.exports
Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs

#8925

Thanks @Josh-Cena LGTM

Thanks, looks good enough


Refactor nssm resource

Following last nssm bump with the cookbook v3.0.1 the escaping behavior changed and broke contingent cookbooks. It also added extra execution time to check parameters values.
Non goals
This PR does not aim to be backward compatible.
Main changes

[breaking] Handle escaping for the user:

No need to use """ for parameters with spaces
What the user set in the property is what he gets in nssm.

Use latest way to define resources (custom resource):

Smaller code
Separated Platform implementation

Use version in nssm path to allow upgrade scenario
Speed up the convergence:

Load current service state at once by implementing the load_current_value  using nssm dump
Requires nssm >= 2.24.94 for the nssm dump command

Introduce start & stop actions to manipulate the service

The README and tests have been updated accordingly. I did many commits to help see how I came to the current result.
Let me kow if you have any question, remark or feedback.
Cc. @aboten

@dhoer I managed to get green CI :D
I also updated the code to take into account your comments and try to be as much backward-compatible as possible.
I'm creating smaller reviews for different stuffs.

Wow quick merge, thanks!

Getting the following error:
resource execute[Install service name service] is configured to notify resource service[service name] with action start, but service[service name] cannot be found in the resource collection. execute[Install service name service] is defined in C:/Users/TEST_U~1/AppData/Local/Temp/kitchen/cache/cookbooks/nssm/resources/service.rb:31:in `block in class_from_file'
Do you have time to look at this?

This is related to #22, I was looking at it but your merged it before I managed to get my test OK :D
I'll try again ;)


Enable basic authentication for socket option (unix_http_server)

What does this PR do?
Enable basic authentication when socket option (unix_http_server) is used
Motivation
Resolves #5825
Additional Notes
Sample supervisor.conf
[unix_http_server]
file=/var/run/supervisor.sock   ; (the path to the socket file)
chmod=0755                      ; socket file mode (default 0700)
username=foo
password=bar

Sample supervisor.d/conf.yaml
instances:
  - name: supervisor_socket
    host: http://<IP_ADDRESS>
    socket: unix:///var/run/supervisor.sock
    user: foo
    pass: bar

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

So it alright to remove the Configuration Options  altogether then?

redoing the PR borked it again

new PR https://github.com/DataDog/integrations-core/pull/6239


Improve performance of using_device for NumPy and Intel64 devices

1.86 us -> 0.54 us (only if device is either CpuDevice or Intel64Device).
with chainer.using_device(device):
    pass

jenkins, test this please.

Jenkins CI test (for commit c7d98650983415f72fe925717eba212f3b235096, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

LGTM!


Send An email to new user is not working

Description of bug
When creating a new user account as a SuperUser/Admin and checking the "Send An Email To New User." checkbox, no email is sent to the email I specify.
Once the user is created, sending password reset links, etc. work fine. Emails are sent and received correctly so it appears the SMTP settings are correct.
Steps to reproduce
List the steps to reproduce the behavior:

Go to 'Manage Users'
Click on 'Add User'
Fill in user details
Check the "Send An Email To New User" checkbox
Click "Save"

Current result
The user is created successfully but no email is send to the user.
Expected result
User gets created and registration email is sent to the users' email address.
Additional context
SMTP is configured to use SendGrid smtp but password reset etc do work without any issues.
Affected version

[x] 9.2.2
[x] 9.2.1
[x] 9.2

Affected browser

[x] Chrome
[x] Firefox
[ ] Safari
[ ] Internet Explorer
[x] Edge

Which registration type ate you using - public, verified or private?

Hi Sebastian (@sleupold),
The "User Registration" setting is set to "None"

I have a customer who has 'verified' as user registration with the same issue.

AFAIR there has been already a PR merged in this area, I am not sure, whether it fixes this issue as well. It would be great if anyone could test it in a nightly build.

I've upgraded the site from version 9.2.2 to the Nightly Build 9.3.0-alpha.31 and the same issue persists.

Is there any known workaround for this?

Dear community,
Email notification is not handled for the User Registration None type. Initially, if None is set, we shouldn't allow anyone to create users.
Nevertheless, I found property IgnoreRegistrationMode which overwrites above logic and makes us ALWAYS possible to create new users. See below:
https://github.com/dnnsoftware/Dnn.AdminExperience/blob/95513df2b8440bc0d37316545d6dd327a3f30506/Extensions/Manage/Dnn.PersonaBar.Users/Components/Contracts/RegisterationDetails.cs#L41
This property was introduced within https://dnntracker.atlassian.net/browse/SOCIAL-3158 Unfortunately, do not have access to check what is it about.
The default value of this property is hardcoded and is true. It is not cumming from UI so it is not configurable. With this property, it is senseless to use None registration mode.
https://github.com/dnnsoftware/Dnn.AdminExperience/blob/95513df2b8440bc0d37316545d6dd327a3f30506/Extensions/Manage/Dnn.PersonaBar.Users/Services/UsersController.cs#L81
To fix this issue we should either disallow user registration when mode is None (so the issue will gone) or add missing functionality to send welcome email for the newly created user.
Please, share your thoughts.

Mike,
registration type "None" does not mean, no-one can create a user account, but there is no "register" option for self registration on the site. Superusers and Site Admins are always allowed to manage site accounts. This is DNN behavior since DNN 1 and should not be changed IMO.
I have no clue, what DNN Social is overriding, maybe an integration with another event like buying a product, which offers to create (or auto-creates) a user account for the product social site (just a guess)

@sleupold thanks for explanation.
Just confused a bit. When admin is creating new user, UserController -> CreateUser->RegisterController.Instance.Register is invoked.
Inside Register there is list of registration types for which email is going to be sent.
https://github.com/dnnsoftware/Dnn.AdminExperience/blob/95513df2b8440bc0d37316545d6dd327a3f30506/Extensions/Manage/Dnn.PersonaBar.Users/Components/RegisterController.cs#L272
So Private/Public/Verified types are handled. None is not there, so email sending is ignored.

@mikebigun ,
I'd like to describe, what should happen:

if a user clicks register and registration is set to "public", he is granted access immediately and gets an email sent with site name, URL and login for reference. The site admin(s) might get a notification about the new user.
if a user clicks register and registration is set to "verified", the user gets limited access (unverified user) and an email with a confirmation link, he needs to click to gain full access. the site admin(s) gets a notification about the new user.
if a user clicks register and registration is set to "private", the user gets an email confirming his registration and the info, the admin has been notified. The site admin(s) gets a notification about the user awaiting registration
if an admin creates a user account (any registration mode), the user gets an email about his new account with site name, site URL, user name and an option to obtain his password.

@mikebigun
I don't know the reason, maybe the code for PB has been inspired by wrong source code part of DNN 8 - just a guess.

I agree with @sleupold fourth point which is not happening at the moment. One thing I would add though is that when an administrator creates a user it should be a choice whether or not to send the user an email, but the default should be to send the user an email.

@Icidis apologies, I reread your post and realized that's what it was about.

After reviewing the flow of the user creation from user admin. I found the following.
There is an event "UserCreated" which could be updated to include the below code
Mail.SendMail(args.User, MessageType.UserRegistrationPublic, PortalSettings.Current);
but of course you don't know which template/message type to use when sending the email.
https://github.com/dnnsoftware/Dnn.Platform/blob/584b0f54bd6b6d237594dd9f96053f14db0b1a53/DNN%20Platform/Library/Entities/Users/UserEventHandlers.cs#L39
Better solution:
I would say the code change should be done here:
https://github.com/dnnsoftware/Dnn.AdminExperience/blob/95513df2b8440bc0d37316545d6dd327a3f30506/Extensions/Manage/Dnn.PersonaBar.Users/Components/RegisterController.cs#L272
as described by @mikebigun .
I'll create an issue and pull request on that repo for review.

IMO we should fix it in the API, not in the UI, which is not accessed by 3rd party extensions.
We may need to extend the method with additional parameters, if necessary.

Changing it in the API would be the best solution. But I would imagine that would take some time to discuss with all the relevant parties including the changes to the API
I would be happy with the change in the UI now as the email notifications sit there already and then later change to a more appropriate solution.

I would appreciate it if there is a chance to fix it in the current implementation. The issue reported exactly for the persona bar and considered as a bug. It is expected to be fixed asap.
Moving to API changes will require long discussion involving all API consumers. I agree, this is certainly right direction for the further improvements, still we need to make correction for the existing part.

Hi has this issue been fixed?

As far as I can tell, this should be resolved in 9.3.1, if you can still reproduce after 9.3.1 @markandcurry please create a new issue with the version number affected. Thanks.


Update Readme.md

Hi @Durgesh4993
Title: Merge Priya Ghosal as Campus Ambassador for Winter of Blockchain
Description: This pull request adds myself, Priya Ghosal, as a Campus Ambassador for the Winter of Blockchain (WoB) by GirlScript Foundation. I have successfully completed all the prerequisites and am now part of the WoB Campus Ambassador Program.
Changes:
Added Priya Ghosal to the list of Campus Ambassadors
Included my role, bio, and relevant contact information

Don't forget to Star repo & follow me on GitHub :)


1.17.1 Support

pls

pls

this hasn't been updated for so long 😭

We're working on this for the latest version of the game. Which is currently 1.18.0.
Join our Discord for updates.


Add image sources

First off wanted to say a huge thanks for such a great piece of software!! its exactly what I was looking for after discovering OBS, but wanting something web based.
I'd like to use this to do recordings of our local user group meetups and one thing I'd like to be able to do is set a background for the composited video stream to get a result somewhat along the lines of what is described here
To start with I'd like to have just our meetup logo (in background) along with 2 video feeds (for camera and talk slides) which it looks like I can already do.
So my feature request is to add a UI widget to allow setting a background image (eg. via a url). I see you are using canvas.captureStream() so I'm hoping its not too big a change to be able to add this. I tried to have a go at quickly testing this via your demo and Chrome DevTools but I couldn't seem to get hold of the canvas element the JS code is using in the VideoStreamMerger so perhaps this needs some changes in that project too?

So you want to be able to add an image source like in OBS?
That's already supported in VSM, so I'd be willing to add it.

Thanks, yes that would be great!

Implemented. Sorry about the wait!


Is it possible to highlight tests with no assertions?

I'd quite like to be able to error if tests contain no assertions. I'm using cats-effect so if I write a test like:
"foo bar" in {
  IO { ... }
}

and I forget to run that IO.. the test looks like it passes. I thought about using regex to look for the IO running, but thought it might be cooler if Scalatest can highlight tests with no assertions for me (no assertions probably means the IO wasn't run)
WDYT?

@henricook Hmm, I can't think of a way the current assertion to help with this, but in the upcoming 3.3 release there's a type of style trait that the test will expect a Fact, which is return from an expect (vs the old assert), if you forget the expect the compiler may in that case give you an error.

This sounds interesting thanks @cheeseng . I've also just discovered cats-effect-testing which means I can at least enforce my tests returning an Effect, that gets me some of the way there. I can see how I could customise that library so that only IO[Assertion] would work, I think.
I need to read up on expect/assert - I hadn't spotted the news that that was changing yet!


feat: add prompt for git repo initialization

https://github.com/SAP/generator-easy-ui5/issues/109

A confirm option with the name initrepo is added to the prompts array and in the end function git initialization steps are only performed if this.config.initrepo is true (the default value).

credits: dfenerski

LGTM


Compatibility with web containers

Maybe an issue for https://github.com/hirosystems/stacks.js-starters ?
I've been trying to use Stackblitz and Codesandbox to make shareable demos, debug issues etc.
They're incredibly helpful, though for a couple reasons, they don't play that well with Stacks packages

Polyfilling Buffer: The age old issue, but this is a barrier to getting some apps working. Requires extra config
Packaging issues: See example of how it runs into error thrown from @nobel/hashes attempting to pull from index.js which throws error

Some of these issues could lie with the apps themselves, so perhaps fixing isn't trivial. Though, if we could offer stacks.js ready containers, that'd be a huge dev productivity win imo.

Related issue: https://github.com/stackblitz/core/issues/1987 Seems to be a noble-hashes feature that Stackblitz doesn't play well with


Mapping nullable Enum to custom object

for now I can have something like the following to register mapping for all enums in the system
config.NewConfig<Enum, KeyValueData>()
            .MapWith(s => new KeyValueData(s, Enums.ResourceManager));

However, it's not possible to have the same cofig for a nullable Enum.
The following config is not working:
config.NewConfig<Enum?, KeyValueData?>()
            .MapWith(s => s == null ? null : new KeyValueData(s.ToString(), Enums.ResourceManager));

I'll get the following Exception
Error while compiling
source=Tests.FirstClass
destination=Tests.SecondClass
type=Map
-> InnerException:
Error while compiling
source=System.Nullable`1[Model.IdentityType]
destination=Model.KeyValueData
type=Map
--> InnerException:
No default constructor for type 'KeyValueData', please use 'ConstructUsing' or 'MapWith'

I've figured a way out but still think it might be a better if we've somthing more helpful in the config. Especially from primitive types to classes. Anyways, my solution was simply like the following:
config.NewConfig(typeof(Nullable<>), typeof(KeyValueData))
            .IgnoreNullValues(true)
            .Map("key", "Value")
            .MapToConstructor(true);

Hello @WahidBitar , if your goal is to skipped mapping when the Source is null, maybe you help [.IgnorIf()] or (https://github.com/MapsterMapper/Mapster/wiki/Ignoring-members#ignore-conditionally)

Hello @WahidBitar, I ran into this problem while preparing a fix for the problem record detection.
I think the problem is as follows: Nullable in Mapster terminology should adapt as Record - forced creation via constructor. But now it happens as a Class where without special directives, there is only creation through a constructor without parameters.

Thanks @DocSvartz , My main goal is not to skip the null values. My goal is to map from a nullable enum to my custom class KeyValueData in a general way.
I'll put here the entire aspects and my work around so you may take benifit of it.
Note: you may found something weard in my KeyValueData class because I have a general mapper from Enum to string because I put translation of the enums in the Resources files, so If you don't have this case your config should be simpler. Anyway here is my classes and config:
Mapping config:
public class GeneralMapper : IRegister
{
    public void Register(TypeAdapterConfig config)
    {
        // by default the following config will cause the Key property in the KeyValueData to get the value from the resources.
        // so I've updated the KeyValueData class to ignore the setter
        config.ForType<Enum, string?>()
            .MapWith(e => Enums.ResourceManager.GetString(e.ToResourceKey()) ?? e.ToString());

        config.NewConfig<Enum, KeyValueData?>()
            .MapWith(s => new KeyValueData(s));

        config.NewConfig(typeof(Nullable<>), typeof(KeyValueData))
            .MapToConstructor(true)
            .Map("key", "Value");
    }
}

the KeyValueData class:
public record KeyValueData
{
    private readonly string? keyHolder; // I had to set this field to this name becuase key will get the value from Resources
    private string? description;

    public KeyValueData(Enum key)
    {
        this.keyHolder = key.ToString();
        Description = Enums.ResourceManager.GetString(key.ToResourceKey()) ?? key.ToResourceKey();
    }

    public string Key
    {
        get => keyHolder!;
        set { } // Don't know why mapster call the setter after calling the constructor. I guess there is a bug related to this.
    }

    public string? Description
    {
        get => description;
        set => description ??= value;
    }
}

@WahidBitar, I wanted to see the KeyValueData in order to better help you. Now I see next:

In this moment you Type KeyValueData has been detect Mapster as Class not  as Record.
Activate Setter from Property Key possible linked from this bug in Class adapter I described it from this issue #633.

Hello @WahidBitar , In version Mapster 7.4.0 and Mapster Tool  8.4.0  (Net 7.0) it working
from your last example: not Error
 public class GeneralMapper : IRegister
 {
     public void Register(TypeAdapterConfig config)
     {
         // by default the following config will cause the Key property in the KeyValueData to get the value from the resources.
         // so I've updated the KeyValueData class to ignore the setter
         config.NewConfig<Enum?, KeyValueData?>()
             .MapWith(s => s == null ? null : new KeyValueData(s))
             .IgnoreNullValues(true).Compile();

     }
}

Result of Generation
public partial class FooMapper : TEstConsole.Mapster.IFooMapper
{
    public TEstConsole.clases.KeyValueData MapToEntity(System.Enum s)
    {
        return s == null ? null : new TEstConsole.clases.KeyValueData(s);
    }
}

thank you so much @DocSvartz
till now I don't use the Mapster Tool, but I am using the Mapster 7.4.0 and don't know why this config didn't work for me
config.NewConfig<Enum?, KeyValueData?>()
            .MapWith(s => s == null ? null : new KeyValueData(s.ToString(), Enums.ResourceManager));

so I ended up with my workaround solution

The problem in here:
source=System.Nullable`1[Model.IdentityType]
destination=Model.KeyValueData
new KeyValueData(s.ToString(), Enums.ResourceManager)
Enums is Static or what is it ?

Linked this #476

@WahidBitar  @andrerav
Looks like I made a  fix from this Problem
But there was a regression with this test
With Fix created Additional check for TSource:  CreatedUserName = IIF((Param_0.CreatedUser == null), null, Param_0.CreatedUser.Name)
I can't figure out if this is better or worse for Projection way Adapt ?
@andrerav i can integrated this fix from my PR  #634  or is it better to open a new PR?

@DocSvartz Yes I prefer a separate PR :) Thanks for all your recent contributions, amazing work!


Unsupported 'no-timeout': true option in example configs

The 'no-timeout': true option described inside example .mocharc.js doesn't work.
https://github.com/mochajs/mocha/blob/09ffc30b43db53b0cb3f54670132270271d8fe97/example/config/.mocharc.js#L41
Other options like timeout: false or timeout: 0 work correctly.
I suggest removing the note about 'no-timeout': true option from example config files.

@radimbuchtela I agree, it's not working in config files.
The timeout option is typeof string, and the negation does not work. Mocha doesn't have an option named no-timeout.
Weird enough, on the CLI --no-timeout is working and timeout is set to zero. It seems to be some weirdness of yargs-parser I don't want to rely on in future.
I will remove no-timeout from our config file samples and our docs.
Thanks for filing this issue.


SE-0139: NSValue bridging

For every struct type for which the frameworks provides an NSValue category for boxing and unboxing values of that type, provide an _ObjectiveCBridgeable conformance in the Swift overlay that bridges that struct to NSValue, allowing the structs to be used naturally with id-as-Any APIs and Cocoa container classes. This is mostly a matter of gyb-ing out boilerplate using NSValue.init(bytes:objCType:) to construct the instance, NSValue.objCType to check its type when casting, and NSValue.getValue(_:) to extract the unboxed value, though there are a number of special snowflake cases that need special accommodation:

To maintain proper layering, CoreGraphics structs need to be bridged in the Foundation overlay.
AVFoundation provides the NSValue boxing categories for structs owned by CoreMedia, but it does so using its own internal subclasses of NSValue, and these subclasses do not interop properly with the standard NSValue subclasses instantiated by Foundation. To do the right thing, we therefore have to let AVFoundation provide the bridging implementation for the CoreMedia types, and we have to use its category methods to do so.
SceneKit provides NSValue categories to box and unbox SCNVector3, SCNVector4, and SCNMatrix4; however, the methods it provides do so in an unusual way. SCNVector3 and SCNVector4 are packaged into CGRects and then the CGRect is boxed using valueWithCGRect:. SCNMatrix4 is copied into a CATransform3D, which is then boxed using valueWithCATransform3D: from CoreAnimation. To be consistent with what SceneKit does, use its category methods for these types as well, and when casting, check the type against the type encoding SceneKit uses rather than the type encoding of the expected type.

@swift-ci Please test

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 3cd9b9b1831b658c135f735f619a270009590ef4
Test requested by - @jckarter

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 3cd9b9b1831b658c135f735f619a270009590ef4
Test requested by - @jckarter

@swift-ci Please test

@swift-ci Please test

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 853afe50b09dcc1e16aa59e0205731647b0c0ee0
Test requested by - @jckarter

@swift-ci Please test

@swift-ci Please test

@jrose-apple You've already glanced over this, but do you mind reviewing for inclusion in 3.0.1 as well?

I'll do another pass tonight; the first pass wasn't too thorough.

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - edf0aec59a52824aedb3564e0320471744d966a8
Test requested by - @jckarter

Seems good for now. Still a few open questions but nothing that would affect the 3.0 branch.

@swift-ci Please test

@swift-ci Please test

@jrose-apple I updated the comment in ASTContext.cpp and added some tests for specific type encodings that ought to be stable across platforms. How's this look for 3.0 now?

Ship it!

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - c58492cc32720577c8c0adbdf1c06e7202fa8916
Test requested by - @jckarter

@swift-ci Please test

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - c58492cc32720577c8c0adbdf1c06e7202fa8916
Test requested by - @jckarter

@phausler Is this Foundation test failure expected, or transient?
TestFoundation/TestNSURLSession.swift:40: error: TestURLSession.test_dataTaskWithURL : Asynchronous wait failed - Exceeded timeout of 12.0 seconds, with unfulfilled expectations: data task
11:05:05 TestFoundation/TestNSURLSession.swift:42: error: TestURLSession.test_dataTaskWithURL : XCTAssertEqual failed: ("unknown") is not equal to ("Kathmandu") - test_dataTaskWithURLRequest returned an unexpected result
11:05:05 Test Case 'TestURLSession.test_dataTaskWithURL' failed (12.006 seconds).

@swift-ci Please test

yea that failure is transient, we have seen it flutter a bit and it really needs to be replaced with loopback testing

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - c69d35d67b7530a3dcc0cbd49a98e1b45698a779
Test requested by - @jckarter

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - c69d35d67b7530a3dcc0cbd49a98e1b45698a779
Test requested by - @jckarter

@swift-ci Please test

@swift-ci Please test


Yarn dev dependency not listed

Description
The build process requires "yarn" package, but it's not listed as a dependency.
"package.json" should be updated to include this devDependency.
Steps to reproduce
$ npm install
$ npm test

><EMAIL_ADDRESS>pretest /path/to/lint-staged
> yarn lint

sh: yarn: command not found
npm ERR! Test failed.  See above for more details.

Should we stick to npm in package json since I believe it work for both npm and yarn?

cc @sudo-suhas

I would have, but that's a whole separate set of changes to redo much more (i.e., Travis, AppVeyor, package.json). Suggest you accept this (since no one can test or commit without it currently) and decide about other changes in separate issue.

@plroebuck To clarify @okonet suggested that we do the changes only in package.json so that whatever scripts where invoking yarn, they would use npm instead. And I too would prefer that. I have not seen any repos which have yarn as a dev dependency and installing yarn through npm isn't recommended either:

Note: Installation of Yarn via npm is generally not recommended. When installing Yarn with Node-based package managers, the package is not signed, and the only integrity check performed is a basic SHA1 hash, which is a security risk when installing system-wide apps.
For these reasons, it is highly recommended that you install Yarn through the installation method best suited to your operating system.

Yeah, read that warning (and the following paragraph which installed using npm anyway). As a devDependency, the warning doesn't really apply as heavily since not installed as system-wide app. Looking at Heroku specs, they specify the dependency in the "engines" section instead. I could fix my commit by moving the dependency there, but that then creates a runtime dependency requirement.
Personally, I fail to see the point of requiring "yarn" anywhere nowadays. YA dependency for little payback. Don't use "yarn" for any of my projects, so not gonna globally install it anyway.
But you can't have it both ways -- pick one package manager, not two.

Yarn or npm in 2018?

Why wouldn't I use npm to install yarn?

I’m okay to stick to NPM only if this can increase the adoption. @sudo-suhas do you remember why we introduced yarn to this project?

@okonet We introduced yarn when we updated jest to v22 but wanted to lock down the version via lock file.

As a devDependency, the warning doesn't really apply as heavily since not installed as system-wide app.

As you yourself pointed out, having yarn as a dev dependency adds 172 dependencies. So again, no to adding it as a dev dependency.
I personally still prefer yarn over npm for the following reasons:

When npm@5 came out, I had tried to use it on Windows but it was very very buggy and often failed to install dependencies correctly with EPERM errors.
I am very sceptical of npm when issues like this one(npm/npm#19883) keep popping up but the development team doesn't own up to the mistake.
We had observed a lot of CI failures on Appveyor when we were using npm(ex: https://ci.appveyor.com/project/okonet/lint-staged/build/1.0.79/job/c1u2k57uwn2dn91o).

Again, this is just my personal opinion but I am entitled to vote on the choice of yarn vs npm as a maintainer.

Don't use "yarn" for any of my projects, so not gonna globally install it anyway.

But you can't have it both ways -- pick one package manager, not two.

You don't have to. I don't think you fully understand the change we are suggesting. By using npm as the script runner, contributors are free to use whatever package manager they are comfortable with. But we will continue to use yarn in our CI.


Does mmaction support action recognition for single image?

Hi, I would like to do action recognition like smoking, phoning for single image. Does mmaction support that? Or any suggestion about that? Thanks.

MMAction supports action recognition for single image. You can train TSN model with 1-seg setting for your task.


How to exclude checks on "passive"

I see some information on https://github.com/btford/write-good
exclude checks like this:
write-good *.md --no-passive
I don't want "passive" be checked, how can I exclude?
Thanks!

If you check linter-write-good's package settings, there's an input for "Additional arguments to pass to write-good." You can add the --no-passive flag there!


Constant values should not be quoted by default

When dealing with fixed parameters <aa>, the value (in this case aa) should not be quoted by default. This allows numbers or booleans and nulls to be passed in properly as a JSON parameter instead of a string.

This has been fixed in master. As it changes the underlying JSON parsing a lot, this change will only make it to 2.1 to avoid unwanted side-effects to the 2.0.x line especially as no bugs have been reported against it (yet).


cannot bash into pods

https://github.com/kelseyhightower/kubernetes-the-hard-way/issues/630#issuecomment-991947838

worked with a combination of:
add workernodes to /etc/hosts on controllers
Add this to kube-apiserver arguments (in the systemd service): --kubelet-preferred-address-types=InternalIP,ExternalIP.
remove from kubelet config (most importantly, I think):
clusterDNS:
  - "<IP_ADDRESS>"


Downgrade Storybook to 6.5

Dependabot had previously automatically upgraded Storybook to version 7, which broke our Storybook scripts in package.json. In this PR, I downgrade Storybook to 6.5 to make everything work again.
Additionally, I configure the dependabot automerge action to not automatically merge major version updates in order to prevent it from updating Storybook to version 7 again. I also think that mergin major updates automatically is a bit hazardous. There isn't that many major updates happening, so at least I can afford time to merge them manually.

:tada: This PR is included in version 23.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[Idea] Use C++ instead of C for FFI

At WWDC, Apple announced that Swift now has out-of-the-box C++ interop. There will be a session about it tomorrow:

This reminded me of the cxx Rust library, which does something similar to swift-bridge, but for C++, and it is more stable and complete (although still lacking async functions).
So the idea is: can the C FFI be replaced with C++, and would it be beneficial? C++ is still a far cry from Swift, but it is closer, and cxx already supports strings, results, slices, vectors, ... I believe replacing C exports with C++ can help ease implementation of new features in swift-bridge, bringing it closer to a seamless bridge. It can also simplify the generated Swift code.
Disclaimer: I'm not an FFI expert by any measure, the most FFI I have written myself is a basic one between Rust and C#, and it barely worked. So this may not be beneficial at all, but I still want to bring it up because it's a thing I immediately thought of when seeing the announcement in WWDC.

Thanks for bringing this up and sharing your ideas and thoughts.

This reminded me of the cxx Rust library, which does something similar to swift-bridge, but for C++, and it is more stable and complete

In what sense is it more stable and complete? (not a challenge, I'm just trying to understand your use case better.)

I believe replacing C exports with C++ can help ease implementation of new features in swift-bridge

Do you have an example of what you mean by this?

In what sense is it more stable and complete? What criteria are you using? (not a challenge, I'm just trying to understand your use case better.)

CXX has stuff like slices, boxed values, arrays ([T; N]) implemented. Also it has more contributors and is more widely adopted, meaning naturally it will be more stable since there are more eyes on it. In the CXX documentation, it calls itself as "a replacement for extern "C" in a sense", maybe that explains what I mean better.
The new C++ Swift interop means that in most use cases (e.g. just passing strings, structs, enums, etc. across the language border), CXX can be used instead of swift-bridge altogether, and then Swift can interop with that. Although I can't really confirm it since I don't have access to the Xcode beta.

Do you have an example of what you mean by this?

For example, arrays can be implemented just by exposing them as a C++ API and then letting Swift interop with it.
BTW, the session is live, and there are some more details (although still not everything) about the new bridging layer they have. Here are some screenshots from it:
C++ -> Swift APIs

Some Swift APIs in C++ (not complete list)

Some C++ APIs in Swift (not complete list)

Again, this whole thing is an idea. It could make the package simpler, or it could make it more complicated. I just saw that the project has slowed down over the past few months and some stuff is still not implemented, so I am suggesting this as a way of implementing it. Not an FFI expert whatsoever so please correct me on anything that I got wrong :)

Thanks a lot for the additional context. I'll address your thoughts:

Also it has more contributors and is more widely adopted, meaning naturally it will be more stable since there are more eyes on it

If by stability you're referring to API churn, that isn't much of a concern I don't think since swift-bridge's APIs are fairly stable.
If you're referring to the likelihood of bugs, I'm also not weighing this highly since swift-bridge's test suite is fairly robust.'

CXX has stuff like slices, boxed values, arrays ([T; N]) implemented

cxx's type support is motivated by common C++/Rust interop use cases.
For example, cxx doesn't support Option<T>. I don't write C++, but I'm assuming that options can't be all that common if they aren't yet suppoted by cxx.
swift-bridge implemented support for Option<T> very early on since Swift/Rust both have a very commonly used Option{al} type.
Adding support for new types to swift-bridge is relatively easy. When it isn't it's almost always because of some Swift language
consideration ( example: https://github.com/chinedufn/swift-bridge/issues/152 ). cxx won't have solved these Swift related considerations
since it isn't focused on Swift.

The new C++ Swift interop means that in most use cases (e.g. just passing strings, structs, enums, etc. across the language border), CXX can be used instead of swift-bridge altogether

If you're implying that we might be able to use cxx's bridge module macro, we'd lose the ability to have our own custom attribute such as https://github.com/chinedufn/swift-bridge/blob/master/book/src/bridge-module/opaque-types/README.md?plain=1#L210-L220
If you're implying that we might be able to use cxx's codegen machinery to power our codegen, that would just be adding an extra complex dependency to help with something that would be easier and better to keep in tree
(tighter control over the exact code that is generated).

So yeah, I don't think that cxx would help us in any meaningful way.
On the other hand, there may still be ways to take advantage of the new Swift and C++ interop directly ourselves. We should definitely research that.

Again, this whole thing is an idea. It could make the package simpler, or it could make it more complicated.

Gotcha.
I'm very interested in anything that you think might simplify our codegen or more easily support some kind of interop, without making the user experience more complex for end users.
Is there a specific example of a change that you would want to see made to some of our codegen? You can see a lot of our current codegen in here https://github.com/chinedufn/swift-bridge/blob/master/crates/swift-bridge-ir/src/codegen/codegen_tests.rs#L30-L53

I just saw that the project has slowed down over the past few months and some stuff is still not implemented

Thanks a lot for expressing the concern. My commits started to slow down when all of the features that I needed were implemented. (I maintain a mission-critical production application that uses swift-bridge on iOS)
It looks like Swift 5.9 has some useful stuff that I'm interested in taking advantage of (such as to solve https://github.com/chinedufn/swift-bridge/issues/155), so I might have a spurt of commits around that.

Not an FFI expert whatsoever so please correct me on anything that I got wrong :)

Ha no worries, I guess it's hard to comment since there isn't an exact change that's being proposed. I appreciate you bringing up the idea. I've been monitoring some new Swift features that we might be able to take advantage of so this is timely.
I'll leave this issue open until I look through all of the new Swift/C++ interop and see if there is anything that we can use to solve real problems that we have. Feel free to suggest as well.

Ok, sounds good. I agree, if swift-bridge is stable and it's already being used in production then there's no point overcomplicating it by adding another dependency that would actually limit what swift-bridge itself can do in codegen.
In terms of other features of Swift 5.9, maybe the ownership features are worth taking a look at? In this session they show that you can make a class not inherit from Copyable and have consuming funcs, which could more closely reflect what Rust has (e.g. &self vs self in methods). Actually I found something interesting about it, I'll make a second issue since it's not really related.
I'll try seeing if I can help in any way to implement some new types :) Feel free to close this issue if there's nothing in the new interop that can help you

Yup we totally want to explore Swift's new ownership features.
I'll add a link to that video to issue 155's body

I'll try seeing if I can help in any way to implement some new types

That would be awesome! This could be a good one to get your feet wet https://github.com/chinedufn/swift-bridge/issues/187


FIX fix map/struct/array support arrow

Proposed changes
Issue Number: close #xxx

support map/struct support arrow format
fix string arrow format
fix largeInt 128 for arrow builder

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Moving the index_configuration_tool into a "FetchMigration" subdirectory

Description
Following updates to the Dockerfile and the use of Data Prepper, the functionality of this tool has expanded to beyond just "index configuration". Thus, i've opted to group the index_configuration_tool Python code, its Dockerfile and future related code under a FetchMigration subdirectory. This contrasts nicely with our other directories/approches i.e. TrafficCapture and TrafficReplayer.
This refactoring also includes the following changes:

The README and Dockerfile have been moved to the new base directory.
The Dockerfile has been updated to account for the above path difference.
The README has been updated significantly to reflect the use of Data Prepper instead of Logstash

This PR also includes a second commit that adds an additional unit test.
Issues Resolved
N/A
Testing
$ python -m coverage report --omit "*/tests/*"
Name                  Stmts   Miss  Cover
-----------------------------------------
index_operations.py      29      0   100%
main.py                 112      0   100%
utils.py                 13      0   100%
-----------------------------------------
TOTAL                   154      0   100%

Check List

[ ] New functionality includes testing

[x] All tests pass, including unit test, integration test and doctest

[x] New functionality has been documented
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Lint is failing:
Run flake8 $(git ls-files '*.py')
  flake8 $(git ls-files '*.py')
  shell: /usr/bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.10.12/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.10.12/x64/lib
test/tests.py:1:66: E231 missing whitespace after ','
Error: Process completed with exit code 1.

I was initially unable to repro this on my local setup (which was using Python 3.11.2) but I can repro it after switching to Python 3.10.12 (the one used by the CI runtime).

$ flake8 --show-source test/tests.py
test/tests.py:1:66: E231 missing whitespace after ','
from operations import create_index, check_index, create_document,\
    delete_document, delete_index, get_document
                                                                 ^

I'll push a fix for this.


Move to the RSE docker images

https://github.com/rse-ops/docker-images
These are more up to date than the axom-docker repository. This will be needed for newer Ubuntu's.

Fixed in #1074


[docs] Use 'argocd' namespace in Installation docs

We start by applying the installation manifests in namespace "argocd".
However, later we restart the deployment in a separate "argocd-image-updater" namespace.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #452 (a5b1814) into master (f12a5ab) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #452   +/-   ##
=======================================
  Coverage   65.60%   65.60%
=======================================
  Files          21       21
  Lines        2035     2035
=======================================
  Hits         1335     1335
  Misses        571      571
  Partials      129      129

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Nevermind; didn't realize all of that was part of the Method 2 section.