Killing torxakis doesn't kill the server or the constraint server

Added by Petra van den Bos
When killing (ctr+c) torxakis, i.e. the user interface, the processes of the server and the constraint solver stay alive.
Scenario: I kill (ctr+c) the command prompt in which TorXakis runs (because the constraint solver is taking too long to evaluate string expressions). The Task Manager then shows that the CVC4-process is still running.
Sugested solution: When TorXakis receives a kill, TorXakis first kills the constraint solver, and only after that it kills itself.

See
https://hackage.haskell.org/package/process-<IP_ADDRESS>/docs/System-Process.html
terminateProcess and interruptProcessGroupOf
On Windows systems, it generates a CTRL_BREAK_EVENT and will only work for processes created using createProcess and setting the
create_group flag

Now, when the txsserver is started from the txsui process, Ctrl-C kills the txsserver and the solver processes. So this issue boils down to properly handling interruptions in the server, in case the server is started as a separate process. @pjljvandelaar should we close this after merging feat/start-txsserver-from-ui?

What about closing and making a low priority issue for the server as a separate process

Next week I plan to work on the issue of proper exception handling at the txsserver, namely #55. So I guess no need to make a separate issue.


How to make image inversion more precise?

Fantastic work on this project @bloc97!
I'm able to get super impressive results with prompt editing. However, when doing img2img I find that the results degrade greatly. For example, here I'm editing the prompt to change to a charcoal drawing, which works well. However, if I pass in the initial image generated from the original prompt, there's no values of parameters I can find to get anywhere close to the quality of the prompt edit without initial image. I'm observing similar issues to stock SD where either the macro structure of the initial image is lost or the prompt edit has little to no effect.
The reason I want this is to edit real images and to build edits on top of each other. I realize this may be unsolved, and depend on how well the network understands the scene content, but I'm very interested in your thoughts and suggestions here as I think it would be incredibly powerful.
img_original = stablediffusion(
    prompt="a fantasy landscape with a maple forest",
    steps=50,
    seed=42,
)

img_prompt_edit = stablediffusion(
    prompt="a fantasy landscape with a maple forest",
    prompt_edit="a charcoal sketch of a fantasy landscape with a maple forest",
    steps=50,
    seed=42,
)

img_init_image = stablediffusion(
    prompt="a fantasy landscape with a maple forest",
    prompt_edit="a charcoal sketch of a fantasy landscape with a maple forest",
    steps=50,
    seed=42,
    init_image=img_original,
    init_image_strength=0.6,
)

You can try the method in InverseStableDiffusion.inpyb. However, this works very well only with images that were generated with stable diffusion. For real images, inversion with high CFG is an unsolved problem currently. Sometimes you get good results, sometimes you don't. Usually images that will never get generated by the model given the input prompt fares quite poorly.
Here's what I get with the following code:
gen_latents = inversestablediffusion(input_image, "a fantasy landscape with a maple forest", refine_iterations=10, guidance_scale=5.0)
stablediffusion("a fantasy landscape with a maple forest", guidance_scale=5.0, init_latents=gen_latents)
stablediffusion("a fantasy landscape with a maple forest", prompt_edit="a charcoal sketch of a fantasy landscape with a maple forest", guidance_scale=5.0, init_latents=gen_latents)

Reconstruction:

Edit:

Examples where inversion doesn't work well:
Left is original image, right is reconstruction with prompt.
https://www.pexels.com/photo/tray-of-pumpkins-on-a-knitted-sweater-5429788/
gen_latents = inversestablediffusion(input_image, "a temperate forest in autumn", refine_iterations=10, refine_skip=0.5, guidance_scale=3.0)
stablediffusion("a temperate forest in autumn", guidance_scale=3.0, init_latents=gen_latents)

https://www.pexels.com/photo/trees-at-the-park-under-clear-sky-3227735/
gen_latents = inversestablediffusion(input_image, "pumpkins in a tray seen from above", refine_iterations=10, refine_skip=0.4, guidance_scale=3.0)
stablediffusion("pumpkins in a tray seen from above", guidance_scale=3.0, init_latents=gen_latents)

That's good input @bloc97, thank you. I spent most of today experimenting with the inverse method on real images and getting unpredictable results, as you commented. Although, with a couple of great examples.
Have you thought about whether fine tuning the model or using an embedding (like textual inversion or dreambooth) could help with this applied to a particular domain? For example if one were to take a video through a particular forest or scene and fine tune with examples of that, whether it would then be possible to do precise prompt-to-prompt editing of real images that are close to that distribution?

That's good input @bloc97, thank you. I spent most of today experimenting with the inverse method on real images and getting unpredictable results, as you commented. Although, with a couple of great examples.
Have you thought about whether fine tuning the model or using an embedding (like textual inversion or dreambooth) could help with this applied to a particular domain? For example if one were to take a video through a particular forest or scene and fine tune with examples of that, whether it would then be possible to do precise prompt-to-prompt editing of real images that are close to that distribution?

Have you thought about whether fine tuning the model or using an embedding (like textual inversion or dreambooth)
That might actually work! A better reconstruction usually allows for better editing...

@hmartiro There's Google's Imagic paper that just got released. https://arxiv.org/abs/2210.09276
From the paper, it seems that inverting the prompt embeddings too (not just the latent) yields even better results. In that paper they also fine tune the model on the inverted embeddings so that it reconstructs the input image better.

Very spicy @bloc97! I'll take a look at that paper.
I did end up fine tuning using the DreamBooth approach on a novel object type, and I haven't tried this cross-attention method yet on that model but the similar "img2img alternate" approach in the automatic1111 repo did greatly improve prompt editing once the model understood the class. It's definitely still immature though and results are sproadic.

Also see: https://text2live.github.io/
So far it appears very slow to run since it requires training extensively on a single image, but very exciting in the results. I really like the idea of the split edit layer that gets composited on top of the original. Do you think such an approach would have value with your method?

Thanks for the amazing work. But I am a bit confused about this inversion ... I wonder if there is corresponding paper/article that elaborate this process.


Create Memoization Util

Having a util to Memoize functions would promote the practice of optimizing your functions; and further increase the performance of the Knit Framework as it'd be returning already cached self or local variables, that is if the variable isn't in an ignore list.

Hi! Unfortunately, such a function is out of scope for Knit's purpose. I do agree that memoizing is nice.


Mitmdump option error

Problem Description
When passing random arguments to mitmdump it doesn't show any error.
Steps to reproduce the behavior:

Type mitmdump abc

It doesn't show any flow after that just clientconnect and clientdisconnect on requests but no error about wrong argument. Mitmproxy show this kind of error. I am not sure this is supposed to behave like this or this is a bug.
System Information
Paste the output of "mitmproxy --version" here.
Mitmproxy: 6.0.0.dev (+116, commit 7791410)
Python:    3.7.5
OpenSSL:   OpenSSL 1.1.0j  20 Nov 2018
Platform:  Linux-5.3.0-kali2-amd64-x86_64-with-debian-kali-rolling

They don't have the signature. mitmdump has `[filter]. I assume that's what confuses you (I didn't know either, just noticed it)
$ mitmproxy --help
usage: mitmproxy [options]

$ mitmdump --help
usage: mitmdump [options] [filter]

positional arguments:
  filter_args           Filter expression, equivalent to setting both the
                        view_filter and save_stream_filter options.

I assume that's what confuses you (I didn't know either, just noticed it). Request sth. like www.example.com/abc and you'll see it because of the /abc

Well you are right, this confuses me and thanks for clearing this up,I think for a single space filter is apply to url as request to www.example.com/abc is shown on
mitmdump abc
But for more spaces like
mitmdump abc something
i am still confused on what context of flow does this filter apply to.

It is a filter expression, see https://docs.mitmproxy.org/stable/concepts-filters/

Strings with no operators are matched against the request URL.

What I don't understand is why mitmdump "foo bar" will match "/foo/bar". Maybe that's something I don't know about Python-style regex @mhils ? Shouldn't the space be taken literal?
I think what can be done better is that if [filter] is provided then mitmdump could show the user what view_filter this results in. At least in verbose mode.
Do you have any suggestions what exactly you would change to make things more clear? What what you add to the docs?

Strings with no operators are matched against the request URL.

I think i miss that line.

I think --help should contain some examples in general

Yeah it can be applied instead of docs.
For the docs i think we can add some example in https://docs.mitmproxy.org/stable/tools-mitmdump/ about url filtering with or without "~u" and if multiple spaces is legit then also add some more info in https://docs.mitmproxy.org/stable/concepts-filters/

Related: https://github.com/mitmproxy/mitmproxy/issues/3142
I think there's room for improvement in multiple places. Thank you for bringing it up.

Yeah, let's wait for @mhils  approval whether we implement this or not.

What I don't understand is why mitmdump "foo bar" will match "/foo/bar". Maybe that's something I don't know about Python-style regex @mhils ? Shouldn't the space be taken literal?

mitmweb actually has the best interface here which explains it:

The explanation is generated by the JS reimplementation in web/src/js/filt/filt.peg). Would be nice if we had the same in the console somewhere.
FWIW, the behavior is also mentioned in the docs at https://docs.mitmproxy.org/stable/concepts-filters/:

Strings with no operators are matched against the request URL.
The default binary operator is &.

That explanation is obviously super cryptic for everyone who doesn't know filters. 😄

For the docs i think we can add some example in https://docs.mitmproxy.org/stable/tools-mitmdump/ about url filtering with or without "~u" and if multiple spaces is legit then also add some more info in https://docs.mitmproxy.org/stable/concepts-filters/

I feel that it might be more intuitive to just make it a regular option (like --filter) instead of parsing argv. What do you two think?

I feel that it might be more intuitive to just make it a regular option (like --filter) instead of parsing argv. What do you two think?

You mean for url filter add a option like
mitmdump [options] --filter [expression]
Yeah it world be great and as @Prinzhorn suggested we can add some more info in --help
about this.

@mhils @Prinzhorn any update on this.

Looking at the implementation the argv handling does a bit more than what I initially thought:
https://github.com/mitmproxy/mitmproxy/blob/bfb8da4b1c5f1422b4a9031d1e3e77d40552208c/mitmproxy/tools/_main.py#L154-L162
Maybe we just add a f"Only processing flows that match {v!r}" message to mitmdump and be done with it. If someone feels like it we can move the mitmweb filter explainer to Python.


Store context in a ThreadLocal to explicitly forbid sharing.

https://github.com/square/duktape-android/issues/69

I don’t really like this. It’s not consistent with how thread-unsafe things typically work in Java.
In particular, a reasonable programmer should be able to defend a Duktape instance with synchronized blocks and things should just work from any thread. That’s how ArrayList works! We’re better off just being explicit that Duktape instances aren’t thread safe.

Sure thing.


don't log decryption failures of password items

includes https://github.com/replicatedhq/kots/pull/360 changes


XMLHttpRequest's using Git WebView Resource return unexpected result

VSCode Version:  Version: 1.52.1 (user setup)
OS Version: Windows 10, also Linux

TLDR: XMLHttpRequest inside a WebView on a Git link like
vscode-webview-resource://ba65fa50-10a1-41ed-81ee-f4425d2254f9/git/d%3A/pdf/dummy.pdf?%7B%22path%22%3A%22d%3A%5C%5Cpdf%5C%5Cdummy.pdf%22%2C%22ref%22%3A%22~%22%7D

does not provide a valid pdf file, but plain text from git diff instead.
Steps to Reproduce:

Prepare folder

mkdir D:\pdf
cd /d D:\pdf
git init
curl https://www.w3.org/WAI/ER/tests/xhtml/testfiles/resources/pdf/dummy.pdf --output dummy.pdf
git add dummy.pdf
git commit -m "dummy.pdf"
curl http://www.africau.edu/images/default/sample.pdf --output dummy.pdf
git diff dummy.pdf

You should see something like this:
D:\pdf>git diff dummy.pdf
warning: CRLF will be replaced by LF in dummy.pdf.
The file will have its original line endings in your working directory
diff --git a/dummy.pdf b/dummy.pdf
index 774c2ea..c0e31a0 100644
--- a/dummy.pdf
+++ b/dummy.pdf
@@ -1,2 +1,22 @@
-Dummy PDF file
+A Simple PDF File
+
+  This is a small demonstration .pdf file -
+
+  just for use in the Virtual Mechanics tutorials. More text. And more
+  text. And more text. And more text. And more text.

code D:\pdf
Install https://marketplace.visualstudio.com/itemdetails?itemName=tomoki1207.pdf (instructions below are for v1.1.0)
Go to source control view
Double-click dummy.pdf

You will now see this - this is the bug described in https://github.com/tomoki1207/vscode-pdfviewer/issues/70

To see what the problem is:
6. Open %USERPROFILE%\.vscode\extensions\tomoki1207.pdf-1.1.0\lib\build\pdf.js ($HOME/.vscode-server/extensions/tomoki1207.pdf-1.1.0/lib/build/pdf.js for Remote SSH server on Linux)
7. Add console.log(this.url, xhr); before line 12738 (const chunk = getArrayBuffer(xhr);); save and reload as needed
8. Go to source control view again
9. Double-click dummy.pdf
10. Start workbench.action.webview.openDeveloperTools action
11. Expand XMLHttpRequest in the console windows that just opened.
You will see two requests like this:
First:

Second:

Note the response for the second being only 16 bytes long, while the first is >3000 bytes. The first (37, 80, 68, 70, 45, 49, 46, 51, 13, 10, 37 ...) is basically %PDF-1.3..., a valid PDF header - while the second (68, 117, 109, 109, 121, 32, 80, 68, 70, 32, 102, 105, 108, 101, 10, 12) is Dummy PDF file. This is exactly what git diff shows above. I feel the WebView resource resolver should provide the full pdf file, not just its text.

I should add that the behavior on Windows with Remote SSH to Linux is a bit different. In this case, both requests return the new pdf file, which is also confirmed by the requests having the same size (3028 bytes):

@eamodio I don't agree that this issue is caused by an extension - yes, it is observed in an extension, but the root cause is in incorrectly(?) resolving the Git WebView resource.
The resolving of the resource is in line with the command-line output of git diff. On a clean installation of git on Linux, git diff, one gets
diff --git a/dummy.pdf b/dummy.pdf
index 774c2ea..dbf091d 100644
Binary files a/dummy.pdf and b/dummy.pdf differ
lines 1-3/3 (END)

and then the issue does not appear.
The issue does appear, however, when one uses (still on Linux) a .gitattributes files with
*.pdf           diff=pdf

and a .gitconfig with
[diff "pdf"]
        textconv = pdfinfo
        binary = true

In this case, git diff shows something like this:
diff --git a/dummy.pdf b/dummy.pdf
index 774c2ea..dbf091d 100644
--- a/dummy.pdf
+++ b/dummy.pdf
@@ -1,16 +1,15 @@
-Author:         Evangelos Vlachogiannis
-Creator:        Writer
-Producer:       OpenOffice.org 2.1
-CreationDate:   Fri Feb 23 16:56:37 2007 CET
+Creator:        Rave (http://www.nevrona.com/rave)
+Producer:       Nevrona Designs
+CreationDate:   Wed Mar  1 08:28:26 2006 CET
 Tagged:         no
 UserProperties: no

and the same seems to be true in resolving the WebView resource, leading to apparently broken PDF files.
On Windows (using https://gitforwindows.org/), I don't recall making any of these changes, and I cannot find a .gitattributes file. However, a default setting diff.astextplain.textconv=astextplain likely has the same effect (compare https://stackoverflow.com/q/28146244/).
D:\pdf>git config --list --show-origin
file:C:/Program Files/Git/etc/gitconfig http.sslbackend=schannel
file:C:/Program Files/Git/etc/gitconfig diff.astextplain.textconv=astextplain
file:C:/Program Files/Git/etc/gitconfig credential.helper=manager-core
file:C:/Program Files/Git/etc/gitconfig core.editor="C:\\Program Files\\Notepad++\\notepad++.exe" -multiInst -notabbar -nosession -noPlugin
file:C:/Program Files/Git/etc/gitconfig core.autocrlf=input
file:C:/Program Files/Git/etc/gitconfig core.fscache=true
file:C:/Program Files/Git/etc/gitconfig core.symlinks=false
file:C:/Program Files/Git/etc/gitconfig pull.rebase=false
file:C:/Program Files/Git/etc/gitconfig credential.https://dev.azure.com.usehttppath=true
file:C:/Program Files/Git/etc/gitconfig init.defaultbranch=master
file:C:/Users/bers/.gitconfig   color.diff.old=white red
file:C:/Users/bers/.gitconfig   color.diff.new=white green
file:C:/Users/bers/.gitconfig   winupdater.recentlyseenversion=2.25.0.windows.1
file:.git/config        core.repositoryformatversion=0
file:.git/config        core.filemode=false
file:.git/config        core.bare=false
file:.git/config        core.logallrefupdates=true
file:.git/config        core.symlinks=false
file:.git/config        core.ignorecase=true

So, still, git diff returns text
warning: CRLF will be replaced by LF in dummy.pdf.
The file will have its original line endings in your working directory
diff --git a/dummy.pdf b/dummy.pdf
index 774c2ea..c0e31a0 100644
--- a/dummy.pdf
+++ b/dummy.pdf
@@ -1,2 +1,22 @@
-Dummy PDF file
+A Simple PDF File
+
+  This is a small demonstration .pdf file -

and in line the that, the issue does appear.
In summary, I believe VS Code's resource resolver is confused by gits tendency to convert resources into text. This is very similar to #129505 - however, this issue appears even with default settings, I believe (on Windows). VS Code should make sure that in any kind of diff view, where the right side of the diff view resolves via the file system and will always receive a binary file, the left side should resolve without resorting to any kind of textconv.


partition.py and quantity.py mutually import each other at the top level

Importing partition.py results in this error:
from jax_md import partition
File "partition.py", line 38, in
from jax_md import quantity, space, dataclasses, util
File "quantity.py", line 294, in
format: partition.NeighborListFormat=partition.Dense):
AttributeError: module 'jax_md.partition' has no attribute 'Dense'
I think this is because quantity.py is importing partition.py, but since it's already been imported the setup of Dense, etc. hasn't happened.  Importing at the function level might help?

Thanks for reporting this! I removed the import to quantity from partition.py. Seems to fix the issue on my end, but let me know if something is still amiss.

Works for me.


Add AMD/ROCm build dependency for grapper/optimizer

Hi Eugene,
Please review and provide feedback.
Thanks!

@ezhulenev
Hi Eugene,
This is passing all the CIs except ARM CI which is failing a conv_3d_ops. The failure looks to be completely unrelated to this commit as it is grappler/ROCm specific and adds some dependencies to the BUILD file. Also, for Windows Bazel GPU I can't see any details. Seems to me the CIs might be broken.
Given this can we merge this commit?

@ezhulenev Can you please assist on above comment from @rahulbatra85. Thank you!


[BUG] Wrong data-index when drag a blank position.

Hi, thank you for your great library.
When we drag a blank position, We'll get a wrong data-index, It's 0. So select-container with index 0 get a wrong transform.

Thanks to your PR. Now you can download the latest v1.2.0-beta.4 to use it.


efficient memory for SAGA if least-square data-fit is used

Hi guys,
I think we should be able to implement SAGA with only a extra memory size of one sinogram for least-square data fit:
Say F(x) = ||Ax - b|| + R(x), A \in R^{n  x d} , number of subset we denote as s , subset size m, As \in R^{m x d} a subsampled operator. then a subset gradient reads:
g = As^T (Asx - bs) , then we don't need to store g (sized d) in memory for SAGA here, only the vector Asx (sized m) for each subset. When calling g from memory we only pay a small extra computation of As^T.
The memory requirement here for SAGA is no-longer O(s*d) but only O(d), -- note that this is only for least-square data fit.

https://arxiv.org/pdf/1407.0202.pdf


🚧 Removes old Plugin Scores

Description
Resolves #193.

Submitter checklist

[ ] If the issue exists, it is well described and linked in the description
[ ] The description of this pull request is detailed and explain why this pull request is needed
[ ] The changeset is on a specific branch

feature/ for new feature, or improvements
fix/ for bug fixes
docs/ for any documentation changes

[ ] If required, the documentation has been updated
[ ] There is automated tests to cover the code change / addition

If there is no test, include an explanation why in the description

[ ] Run mvn verify locally and all tests are passing successfully
[ ] There is no new warnings on the code

@yashre-bh please let me know if you are progressing on this subject. I will close this pull request by the end of the week otherwise.


Clyde Dialogue tool not showing up in 3.5

Pretty self explanatory, in Godot 4, the asset shows up just fine:

However, in Godot 3.5.3 (AKA LTS) the plugin fails to load:

Other plugins with this type of feature worked, so maybe there's a version mismatch in the addot.gd code?

@rabbitwithworms the plugin for Godot 3 does not include the editor and player at the moment, that's why there is no main panel tab.  The importer, interpreter and helpers should work as usual though.
I'm planning to bring the feature to godot 3 eventually. However, it's likely it won't have syntax highlighting, as it's way trickier in godot 3.


How to add common interceptors for every http request？

I want to set some common interceptors for every http request，for example: set some header before send request ( the header value is dynamic, provid by a function ); handle all response errors by a common ErrorHandler.
How can we do, please ?

Write your own layer on top of request.

@simov OK, Thank you `(∩_∩)′


Move modules/classes route to /api

Move route for modules/classes documentation to /api. Provides better semantics for urls with support for api docs and guides.
Include route redirect support for /docs until v4.

Completed in develop branch.


Cannot Paste Contract Address

Hi there,
Been starting to check this out after someone on InterWasm tipped me about it. I can't paste a contract address into the contract address field.
System info:
MacBook pre M1
Steps to reproduce:
Open up the CW-IDE tab
Copy an address from somewhere, for me I used one from my browser
Upon pressing Command-V in the input box nothing is pasted

I also had the same problem. And maybe this is not a problem unique to Cosmwasm IDE. You can copy/paste by Edit->Copy/Edit->Paste.

Yes, this is a problem for the vscode extension on Mac os

This is a known issue when using VSCode webview on VSCode desktop version of macOS. If you are using macOS, you can try using Gitpod instead to use the IDE.


terragrunt should copy .terraform.lock.hcl on providers lock command

Fixes #1500

Thanks for the PR! One thing that isn't clear to me is why this wasn't handled by auto init? Had you run init before, and then updated to a new version of Terraform? If so, and you already had a .terraform folder, then I guess Terragrunt would not have run init automatically, and therefore, wouldn't have copied the lock file.
Could you try Terragrunt without this fix, but delete any .terragrunt-cache/.terraform folder first?

This change is to explicitly support the flow described here https://www.terraform.io/docs/commands/providers/lock.html#specifying-target-platforms.
terraform init is not guaranteed to pull all checksums depending on platforms, if you already have the provider requested in a cache, or if you are using a mirror. There are lots of details here https://github.com/hashicorp/terraform/issues/27264#issuecomment-743389837. This extra sub command enables you to ensure that the lock file is fully populated.

Thanks for the PR! One thing that isn't clear to me is why this wasn't handled by auto init? Had you run init before, and then updated to a new version of Terraform? If so, and you already had a .terraform folder, then I guess Terragrunt would not have run init automatically, and therefore, wouldn't have copied the lock file.
Could you try Terragrunt without this fix, but delete any .terragrunt-cache/.terraform folder first?

This change is to explicitly support the flow described here https://www.terraform.io/docs/commands/providers/lock.html#specifying-target-platforms.
terraform init is not guaranteed to pull all checksums depending on platforms, if you already have the provider requested in a cache, or if you are using a mirror. There are lots of details here https://github.com/hashicorp/terraform/issues/27264#issuecomment-743389837. This extra sub command enables you to ensure that the lock file is fully populated.

Thanks for the PR! One thing that isn't clear to me is why this wasn't handled by auto init? Had you run init before, and then updated to a new version of Terraform? If so, and you already had a .terraform folder, then I guess Terragrunt would not have run init automatically, and therefore, wouldn't have copied the lock file.
Could you try Terragrunt without this fix, but delete any .terragrunt-cache/.terraform folder first?

This change is to explicitly support the flow described here https://www.terraform.io/docs/commands/providers/lock.html#specifying-target-platforms.
terraform init is not guaranteed to pull all checksums depending on platforms, if you already have the provider requested in a cache, or if you are using a mirror. There are lots of details here hashicorp/terraform#27264 (comment). This extra sub command enables you to ensure that the lock file is fully populated.

Ohhh, I get it, thanks for the context! Could you add that to the comment above shouldCopyLockFile so future maintainers can see the context too?

Thanks for the PR! One thing that isn't clear to me is why this wasn't handled by auto init? Had you run init before, and then updated to a new version of Terraform? If so, and you already had a .terraform folder, then I guess Terragrunt would not have run init automatically, and therefore, wouldn't have copied the lock file.
Could you try Terragrunt without this fix, but delete any .terragrunt-cache/.terraform folder first?

This change is to explicitly support the flow described here https://www.terraform.io/docs/commands/providers/lock.html#specifying-target-platforms.
terraform init is not guaranteed to pull all checksums depending on platforms, if you already have the provider requested in a cache, or if you are using a mirror. There are lots of details here hashicorp/terraform#27264 (comment). This extra sub command enables you to ensure that the lock file is fully populated.

Ohhh, I get it, thanks for the context! Could you add that to the comment above shouldCopyLockFile so future maintainers can see the context too?

I've updated, feel free to use the Github suggested edit stuff to make any small changes you'd like to see and commit them yourself.

I've updated, feel free to use the Github suggested edit stuff to make any small changes you'd like to see and commit them yourself.

Tests passed! Merging now.

Tests passed! Merging now.

https://github.com/gruntwork-io/terragrunt/releases/tag/v0.27.3

https://github.com/gruntwork-io/terragrunt/releases/tag/v0.27.3


ColorSpaceKHR enum only contains one element

ColorSpaceKHR enum only contains one element: https://docs.rs/ash/0.31.0/src/ash/vk/enums.rs.html#1153-1155
But the spec actually lists quite a few more: https://www.khronos.org/registry/vulkan/specs/1.2-extensions/man/html/VkColorSpaceKHR.html
This is especially relevant if one doesn't want to work in sRGB space.

Hi @michidk!
ash uses impl blocks to extend "enums" with more members for extensions elsewhere:
https://github.com/MaikKlein/ash/blob/dd2849450fca7a6361fa51883bda7a37daf2add5/ash/src/vk/extensions.rs#L8299-L8358

Gotcha! Thanks for the explanation!

For completeness, they do show up in the documentation as well:
https://docs.rs/ash/0.31.0/ash/vk/struct.ColorSpaceKHR.html


Unsure of need for cluster-admin / host networking

From looking at documentation, it doesn't look like the xray daemon needs cluster-admin permissions (or any kubernetes api access whatsoever) or host networking enabled. Is there anything I've missed or can those be safely removed from the manifest?

Ideally this project would also be able to use something like IAM for Service Accounts to grant permissions to the daemon.
Any other set of permissions should not be required. Feel free to remove the code and send a PR.

I've removed these as a test, works fine.

I have removed the permissions and added instructions how to set up IAM Roles for Service Accounts to your EKS cluster (if you use the open source web hook this also works for k8s on EC2).
Thanks for the valuable input and ensuring this project sticks to best practices.


Timeline view

LGTM. Tested locally. Note: The package-lock.json is changed again when I do npm i in the demo. I use volta and it uses the correct npm version you specify. I don't know what is going on.

Ok I've understood... to have a clean package-lock, I remove the package-lock and node_modules then run npm i. And it seems running npm i a second time does change the package-lock (by adding the name field on every local dependencies)
fixed in last 2 commits

@CGNonofr do you want to go the non-LTS version on purpose?

@CGNonofr do you want to go the non-LTS node version on purpose? 20 is LTS 21 is current

No really, is that a big deal? just trying to be as up to date as possible

@CGNonofr is there no more automatic release?

When are you planning to publish the next one. I want to release a new monaco-languageclient version later this week.


Parse Query ordering with matches query

[x] You've met the prerequisites: https://github.com/ParsePlatform/parse-server/wiki/Parse-Server-Guide#prerequisites.

[x] You're running the latest version of Parse Server: https://github.com/ParsePlatform/parse-server/releases

[x] You've searched through existing issues: https://github.com/ParsePlatform/Parse-Server/issues?utf8=✓&q=is%3Aissue Chances are that your issue has been reported or resolved before.

[x] You have filled out every section below. Issues without sufficient information are more likely to be closed.

--
Issue Description
[DELETE EVERYTHING ABOVE THIS LINE BEFORE SUBMITTING YOUR ISSUE]
Describe your issue in as much detail as possible.
Hello. I have 2 tables in my Parse Server.
First Table
Venues

Name (strint)
Location (Geopoint)

Second Table
Events

Name (string)
idVenue (Pointer to class Venues)

And when i'm trying to take the Events that are near me with Matches Query (iOS)
I make a query first in Class Venues
        let queryEvents = PFQuery(className: "Events")
        let queryVenues = PFQuery(className: "Venues")

        queryVenues.whereKey("Location", nearGeoPoint: myGeoPoitz, withinKilometers: 15)
        queryEvents.includeKey("idVenue")
        queryEvents.whereKey("idMagazi", matchesQuery: queryVenues)

Steps to reproduce
Please include a detailed list of steps that reproduce the issue. Include curl commands when applicable.

[FILL THIS OUT]
[FILL THIS OUT]
[FILL THIS OUT]

Expected Results
To bring the Events on a certain order that they are near me
Actual Outcome
It actually brings events on the order that have been inserted on Class
Environment Setup

Server

parse-server version (Be specific! Don't say 'latest'.) : 2.2.18
Operating System:     CentOS 6
Hardware:             Don't know
Localhost or remote server? (AWS, Heroku, Azure, Digital Ocean, etc):  Remote

Database

MongoDB version: 3.0.2

Logs/Trace
You can turn on additional logging by configuring VERBOSE=1 in your environment.
no point on doing this.
We have to find a way to make 2nd (and nth) levels of queries to have a certain order.
Thanks a lot for your time.

What was the behaviour on parse.com? What should happen if you specify a different order on your main query?

It was exactly the same also in parse.com
I'm talking about an improvement here. A feature that didn't exist neither in parse.com
Let me rephrase.
If i want to find events near my location
First i have to get my location
then i have to query Venues class to find which Venues are near me
and then with matches query to find the events that have the Object ID of the Venue inside the collumn "venuesID" (which is a pointer to Class Venues)
But this query will NOT bring me the closest events by order (from nearest to other way).
It will bring me in the order of createdAt.

Alright so that's an improvement/new feature. Feel free to work on it and submit a PR. For now we prioritize more issues that prevent people from correctly running parse-server or transitioning.
We welcome additional features, like @cherukumilli is doing for securing user accounts.


[PIO-61] Add S3 Model Data Repository

@marevol Would you like to add some integration test for this? https://github.com/jubos/fake-s3 or https://github.com/atlassian/localstack might be useful for mocking S3 locally within Travis.

Added LocalStack for S3 testing.
LocalStack/moto seems to have a problem about ETag handling...
I added DISABLE_CHUNKED_ENCODING option to avoid it in S3 testing.

I would like to merge S3 support this week.
For travis testing, it passed in https://travis-ci.org/jpioug/incubator-predictionio/builds/235569236 though apache-travis was failed...
Please let me know if you have any comments/concerns.

Sorry for the delay. I was on vacation.
This looks great to me, especially the use of localstack. I think the Travis failed downloading a Python library and erred out. It shouldn't matter IMO. I'll merge this now.


[BUG] esteem v2.1 The number of notifications are not omitted, even after viewing them.

Project Information
Repository: https://github.com/esteemapp/esteem-mobile
Project Name: esteem-mobile
Expected behaviour
The notification number should be omitted after viewing them, should new notification may pop up in notification icon.
Actual behaviour
Here, the actual behaviour is exactly opposite to expected behaviour. The notification number remains as such, even after viewing them.
How to reproduce
1-Download the application
2- Go to the main page of feed
3- click on the notication icon
4- see bug
Browser/App version: v2.1.0
Operating system: 7.1.2
Smartphone: redmi note 4
Recording Of The Bug
https://youtu.be/P7F0mN1pBbY
My Github Account
https://github.com/peerzadaaabid

If you press one of them the notificaiton can mark as view. other wise if you want to mark as read all ot them just press the check icon right of the header line. So work as designed.

Plz have  look,
I'm taking about the red colour notification numbers as shown here in snap
https://drive.google.com/file/d/1E27WRLFSG9VE8mj6z4_sybIc56YhyhpX/view?usp=drivesdk


Documentation theme core components explained wrong

Current behavior
The current explanation on https://docs.vuestorefront.io/guide/core-themes/core-components.html states, that core components are for business logic only and should be imported as mixins. But that is not the case for the current default theme. There core components are regular components with a template and style.
Expected behavior
The doc should mirror the logic used within the code.
Steps to reproduce the issue
Just visit the doc page: https://docs.vuestorefront.io/guide/core-themes/core-components.html
Can you handle fixing this bug by yourself?
NO
Environment details
No details for the doc.
Additional information
It feels like the page contains information about the modules?

@kkdg I'm assigning this issue to you :)

@filrak got it, working on it.


doc(canary): Add dynatrace canary integration doc

Not merge until Dynatrace-kayenta integration code is released.


Video rooms improvements

These changes make the video rooms a bit neater and a the layout a tad more stable. The main contribution is cleaning up some of the code and eliminating unnecessary div tags and similar from the generated output.

Edit: This has been tested in Chrome (latest) and Firefox (81.b02)

Note: The screenshot above doesn't show my subsequent tweak where videos of different sizes will align neatly underneath presenter view or when in grid view.


Using new Collection() instead of collect()

When using this package in a Laravel project the collect() returns an instance of Illuminate\Support\Collection instead of an instance of Tightenco\Collect\Support\Collection and throw a error like:
Argument 1 passed to Rodenastyle\StreamParser\Parsers\CSVParser::formatCurrentLineValues() must be an instance of Tightenco\Collect\Support\Collection, instance of Illuminate\Support\Collection given
This PR changes the collect() to new Collection() to explicitly get the Tightenco\Collect\Support\Collection as expected.

@jn-jairo Great contribution! Thank you so much!


MJ4: \mskip\thickmuskip yields typesetting error

Issue Summary
\mskip\thickmuskip yields Missing dimension or its units for \mskip in math mode with MJ4, but shouldn't.
Of note: \; (shorthand for \mskip\thickmuskip) doesn't yield an error.
Steps to Reproduce:

Go to https://codepen.io/alexedgcomb/pen/LYveYBK

Observed: Typesetting error

Expected: No typesetting error, like MJ2:
https://codepen.io/alexedgcomb/pen/qBwpByG

Technical details:

MathJax Version: 4.0.0-beta.4
Client OS: MacOS 13.4
Browser: Firefox 124.0.1

I am NOT using a MathJax configuration and loading MathJax via:
<script<EMAIL_ADDRESS>
Supporting information:
Issue present in MJ4.0.0-alpha.1: https://codepen.io/alexedgcomb/pen/MWRrWPX
Issue NOT present with \; in beta.4: https://codepen.io/alexedgcomb/pen/yLrpLxK (also not present in alpha.1)

MathJax does not implement dimen registers, count registers, token registers, boxes, or many of the other low-level internals of actual TeX.  In particular, the means \thickmuskip and other similar registers, are not implemented.  MathJax only processes explicit dimensions for \mskip and other macros that take dimensions.
This was also true in v2.  There reason your example "worked" is that v2 had a very simplistic approach to array environment preambles:  it completely ignored any characters other than c, l, and r, so your r@{\mskip\thickmuskip}l was reduced to rcl (the 'c' from within the "thick" in \thickmuskip) before being processed.  In contrast, v4 implements most of the array preamble options from array.sty, and so actually tries to handle \mskip\thickmuskip, but it looks for an explicit dimension, and can't process \thickmuskip (which is not defined in MathJax in any case).
As you may have guessed, \; is not short for \mskip\tickmuskip in MathJax.

Thank you, @dpvc !


docs: add plug-in for dataset management examples auto generation

Pull Request Test Coverage Report for Build 835877504

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.97%

Totals

Change from base Build 835853062:
0.0%

Covered Lines:
4276

Relevant Lines:
5347

💛  - Coveralls


Coop Dungeons

COOP Mode: A difficult quest called Dungeon that can only be done together. It would be great if you could invite another player to join you on an open quest.

We have it in mind as many players already requested this feature and of course our focus is to increase interaction between players. So yes, there would be a Dungeon or coop quests but will have to wait a little 😃
But feels good that more players are validating the ideas like this one!
Awesome


[No merge] Llama debug

PR types
New features
PR changes
Others
Description
Run llama in Prim + PIR + jit.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark:<PHONE_NUMBER>:white_check_mark: jeff41404:x: cyber-pioneerYou have signed the CLA already but the status is still pending? Let us recheck it.


Reduce Parallel Execution of E2E Tests to Improve Stability

see K8S-9651
Description
Add shortnames ec, ecs to EdgeConnect CRD.
kubectl get ec -n dynatrace should return EdgeConnect CRs.
How can this be tested?
make manifests/crd/install
kubectl get ec -n dynatrace

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.32%. Comparing base (9d63386) to head (dbf3f9b).
Report is 2 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3409   +/-   ##
=======================================
  Coverage   58.32%   58.32%
=======================================
  Files         333      333
  Lines       18661    18661
=======================================
  Hits        10884    10884
  Misses       6558     6558
  Partials     1219     1219

Flag
Coverage Δ

unittests
58.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[HOTFIX] Fix carbon file name duplicate problem

Why is this PR needed?
What changes were proposed in this PR?
Does this PR introduce any user interface change?

No

Is any new testcase added?

No

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1577/


Serializing not working on collections when using BigIntType

Serializing cycles on collections when using BigIntType on id's.
RangeError: Maximum call stack size exceeded
    at /home/jeroni/coding/WebstormProjects/mikro-orm-test/node_modules/@mikro-orm/core/entity/EntityTransformer.js:103:18
    at Array.map (<anonymous>)
    at Function.toObject (/home/jeroni/coding/WebstormProjects/mikro-orm-test/node_modules/@mikro-orm/core/entity/EntityTransformer.js:103:14)
    at Book.prototype.toJSON (/home/jeroni/coding/WebstormProjects/mikro-orm-test/node_modules/@mikro-orm/core/entity/EntityHelper.js:27:62)
    at WrappedEntity.toJSON (/home/jeroni/coding/WebstormProjects/mikro-orm-test/node_modules/@mikro-orm/core/entity/WrappedEntity.js:37:28)
    at /home/jeroni/coding/WebstormProjects/mikro-orm-test/node_modules/@mikro-orm/core/entity/ArrayCollection.js:36:62
    at Array.map (<anonymous>)
    at Collection.toArray (/home/jeroni/coding/WebstormProjects/mikro-orm-test/node_modules/@mikro-orm/core/entity/ArrayCollection.js:36:32)
    at Function.processCollection (/home/jeroni/coding/WebstormProjects/mikro-orm-test/node_modules/@mikro-orm/core/entity/EntityTransformer.js:178:24)
    at Function.processProperty (/home/jeroni/coding/WebstormProjects/mikro-orm-test/node_modules/@mikro-orm/core/entity/EntityTransformer.js:148:38)

Example:
    @Entity()
    class Author {

        @PrimaryKey({type: BigIntType})
        id?: string;

        @Property()
        name!: string;

        @OneToMany({ entity: () => Book, mappedBy: (book: Book) => book.author, orphanRemoval: true})
        books: Collection<Book> = new Collection<Book>(this);

    }

    @Entity()
    class Book {

        @PrimaryKey({type: BigIntType})
        id?: string;

        @Property()
        name!: string;

        @ManyToOne({entity: () => Author})
        author!: Author;
    }

    const orm = await MikroORM.init({
        entities: [Author, Book],
        dbName: 'mikro-test',
        type: 'postgresql',
        // Connection fields omitted
        debug: true,
    });

    try {

        const em = orm.em

        const stephenKing = await em.findOne(
            Author,
            {name: 'Stephen King'},
            ['books']
        );

        console.log(JSON.stringify(stephenKing));

    } catch (e) {

        console.log(e);

    } finally {
        await orm.close();
    }

If BigIntType is removed from id's it works normally.
node 14.16.0
typescript 4.3.4
mikro-orm 4.5.6
postgresql

Seems to be already fixed in master, but I can reproduce it in 4.x branch. I did cherry pick all the fixes that were easily portable, but it did not help, so it was most probably fixed as part of some v5 feature or refactoring. Closing (with a test case) as fixed in v5, you will need to wait for that (or use the dev version, there are not that much BCs, mostly internal things).
Should be possible to get around issues like this via custom toJSON method or property serializers.


net: lwm2m: fix sending packet w/o token setup when error

Token is missing when we jump to the error handling where outgoing
message is cleared. To correct it, setup the token if there's any.

Update to correct the root cause of the issue.
The root cause is not because of token is cleared by lwm2m_reset_message().
It is because the token is not setup before the error is met.
The updated patch setup the token at the very beginning of the handle_request() function to fix the issue


Incorrect bumped version for v0.8.16

angel@Lenovo-X301: /ChicagoBoss ((v0.8.16))$ rgrep 0\.8\.15 .
./src/boss.app.src:    {vsn, "0.8.15"},
./skel/rebar.config:  {boss, ".*", {git, "git://github.com/ChicagoBoss/ChicagoBoss.git", {tag, "v0.8.15"}}}
./ebin/boss.app:              {vsn,"0.8.15"},
./rebar.config:        {tinymq,                ".*",   {git, "git://github.com/ChicagoBoss/tinymq.git",        {tag, "v0.8.15"}}},
./rebar.config:        %{tiny_pq,               ".*",   {git, "git://github.com/ChicagoBoss/tiny_pq.git",       {tag, "v0.8.15"}}},

I will put more attention to *.app.src files before making release.
Regarding other libraries: their version may not match CB version, although I try to keep them synced. But I will not make a release without  any commit just to bump version.

Nice!!!
I think this also solves the issue #610.

Solved in 0.8.19.


CQ-4294648 [Masonry]: Added WAI-ARIA grid support for accessibility.

Description

Enables better accessibility support for Masonry component by adding WAI-ARIA grid roles, enabled setting a new attribute.
When enabled (ariagrid="on"), role and related attribute are added as follows:
-- Preserve current role attribute of the parent element of <coral-masonry> and set its new role as grid.
-- Preserve current role attribute of <coral-masonry>, and set new role as row.
-- Set role attribute of all child <coral-masonry-item> as gridcell.
When disabled (ariagrid="off"):
-- Restore preserved (if any) role attribute of the parent element of <coral-masonry>.
-- Restore preserved role attribute of the <coral-masonry>.
-- Remove role attribute of all child <coral-masonry-item>.

If ariagrid property is not set, above changes are not done (default)

Related Issue

https://jira.corp.adobe.com/browse/CQ-4294648

Motivation and Context
Adds better accessibility support for the Masonry component.
How Has This Been Tested?
Test through unit tests, and manual testing.
Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.

@adobe/coral-spectrum, @icaraps, @kozmaadrian, @martinischeery

@majornista can you please have a look ?

@jasghar I opened https://github.com/jasghar/coral-spectrum/pull/1 to include ariaLabel and ariaLabelledby support. It also adds support for toggling ariaGrid on example page.


run multiple scripts in the same GroovyScriptEngine

This updates DslScriptLoader to run the batch of scripts using the same GroovyScriptEngine instance, rather than creating a new GroovyScriptEngine instance for each script. We have 20+ scripts and this change cuts the execution time in half.
I also cleaned up the file a bit and made it instance-based, rather than static.

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

Script execution time is becoming an issue. I started to work an a similar change a few weeks ago, but stopped because changing the classpath for the script engine may introduce problems for users. Currently each script engine gets a classpath consisting of the script`s directory and the additional classpath. When sharing a script engine, there can only be one classpath. One way of solving this is to merge all classpaths as you did. But user's may rely on having separate classpaths, e.g. when using the following workspace layout:
projectA/script.groovy
projectA/Utils.groovy
projectB/script.groovy
projectB/Utils.groovy

When using a combined classpath, the helper class in projectA/Utils.groovy will hide the helper class in projectB/Utils.groovy. It pushed a test case for this to master: https://github.com/jenkinsci/job-dsl-plugin/commit/0f6e0ca8054c0a3176f8a845a9e718bca9dcc473
This is a subtle change and probably hard to debug for users. Can we find a compatible solution? E.g. only sharing a script engine for scripts with an identical classpath?

Sharing a binding between script will probably cause similar compatibility issues. Is there a reason why you share the binding?

Good points. I've updated to share only for scripts with an identical classpath. Also unshared the binding.

That makes sense. The order is fixed now.

Cool. Can't wait to try this in production. I merged your commits manually.


Don`t works with Android11

Account can be created under Accounts, but not added to Contacts

i have the same problem. Android 9


updateinfo not cached

Usually I click the 'check for updates' button in the dashboard, see that there is something new available.
If there is an update available I have to navigate to 'System / Firmware' and click 'fetch updates' again to fetch the information about updates a second time before I can install it.
Its not a big issue but doing this 'see if there is something new' twice all the time feels a bit weird.
Couldn't that information be cached somewhere (with a short timeframe) so that the process would be faster and more straight forward? Or I am just doing this the wrong way around :-) ?

It could be stored in the user session. Discussed this briefly, but as you said it is a minor issue. We tried to cache it on the file system previously, but that was prone to race or go stale/invalid.

btw.. fetching updates from CLI is an order of magnitude faster than fetching them in the GUI..


Location Geocoder API

Note: These need to be run inside an AsyncTask!
Reverse Geocoding:
Turn Address in LatLng:
// getLocationFromAddress(this, "171 Lopez Ave, Menlo Park, CA");
public LatLng getLocationFromAddress(Context context,String strAddress) {
    Geocoder coder = new Geocoder(context);
    List<Address> address;
    LatLng p1 = null;
    try {
        address = coder.getFromLocationName(strAddress, 5);
        if (address == null) { return null; }
        Address location = address.get(0);
        location.getLatitude();
        location.getLongitude();
        p1 = new LatLng(location.getLatitude(), location.getLongitude() );
    } catch (Exception ex) {
        ex.printStackTrace();
    }
    return p1;
}

Source: http://stackoverflow.com/a/27834110/313399
Note: This need to be run inside an AsyncTask!
Geocoder
Turn Lat and Lng into Address:
public String getAddressFromLatLng(float lat, float lng) {
   Geocoder geocoder;
    List<Address> addresses;
    geocoder = new Geocoder(mContext, Locale.getDefault());
    try {
        addresses = geocoder.getFromLocation(lat, lng, 1);
        String address = addresses.get(0).getAddressLine(0);
        String city = addresses.get(0).getAddressLine(1);
        String country = addresses.get(0).getAddressLine(2);
        return address + "\n" + city + ", " + country;
    } catch (IOException e) {
        e.printStackTrace();
    }
   return null;
}

Source: Displaying Address Geocoding
Note: This need to be run inside an AsyncTask!
Workarounds
You might try catching this request and retrying the request a few times, it will usually work as long as you have internet. Another approach you might find useful:

http://stackoverflow.com/questions/16119130/android-java-io-ioexception-service-not-available
http://stackoverflow.com/questions/19059894/google-geocoder-service-is-unavaliable-coordinates-to-address
http://stackoverflow.com/questions/22803755/java-io-ioexception-timed-out-waiting-for-response-from-server

In short you may want to try one of the workarounds to avoid using the geocoder SDK and instead use the geocoder API through a manual REST call instead. Hope that helps,

...
return address + "\n" + city + ", " + country;
...

@adilansari fixed thanks!


Data Science jnyman

Similar to my attempt with Dino Catalog, I have once again used Hirb for display purposes.
My main focus was on the tests which all execute but I also included a runner file so that the "production data" could be executed. This also gave another way to run some of the test data sets.

Awesome job at making a clean git history. This PR is easy to read.

Overall, this is excellent work. Take a look at some of the specialized matchers I suggested. You are good to move on!


chore: release v1.9.0

This pull request was generated using releasetool.
03-25-2020 14:09 PST
New Features

Add @BetaApi ApiFutres.catchingAsync() (#117)

Dependencies

Update guava to v28.2-android (#110)
Update error_prone_annotations to v2.2.3 (#111)

Release is at https://github.com/googleapis/api-common-java/releases/tag/v1.9.0

The release build has started, the log can be viewed here. :sunflower:

:egg: You hatched a release! The release build finished successfully! :purple_heart:


Tinkering with speaker-notes/progressive reveal stuff

This PR includes some improvements for speaker notes, and is part of the background for #236 but only part.

No, I'm going to rework this entirely.


Use Microsoft.Data.SqlClient package

According to https://devblogs.microsoft.com/dotnet/introducing-the-new-microsoftdatasqlclient/
old package System.Data.SqlClient can be considered outdated now (it's still supported but the main focus will be on the new package).

Done f7563f2e4974c4841264666919674aa2c9682480.


Linux build: Fix incorrect log output

Now we use a function closure to capture the destArch variable so the
for loop can't change it.

@grunjol - please review this :)

great! tested and working fine

@grunjol Thanks!


Resolve correct icon for Electron builds

fix #87
Since it's proven to be quite difficult to actually resolve a custom icon on a Mac development build, ensure that the built version of the NWB GUIDE application has the correct icon by running:
npm run build-[platform]

Where platform is either win, mac, or linux based on the desired target OS.
You'll be able to find the built project in the /dist folder.
I can work more on resolving the icon in development for Mac—but I assume it might not be consequential if we can resolve it for the final build.

I'd recommend testing this on the branch for #91, which fixes #90 (uncovered here) to ensure that the frontend is resolved properly.

The icon looks right, but double-clicking it gives me this error:

@bendichter See #89.

So... is this still in progress? Draft? Stuck due to the M1 PyInstaller issue?

Technically completed as much as we can since Mac generally doesn't like resolving the icons during development—though the Mac Pyinstaller issues are downstream of this.
When you build on Mac, you now get the right NWB GUIDE icon. You just also get an error about not having the Python server available.

Ah, but do you need the changes from the PR to make that a possibility through the Mac build?

If we can push a working icon resolution without a functional Mac build, I'd suggest merging this.

Yeah, that's fine. It can be a known disconnect between dev and non-dev builds


About supporting other regional languages

Can it support other regional languages, such as Japanese

English please. Yes it can, you set the language you want to use on Steam, enter the game to download language specific content, then launch YgoMaster and change the language there to match the language set on Steam.


Knockout binding handler snippet doesn't work

Hey everyone,
after reading #838, implementing the docs' snippet and trying several suggestions from the referenced issue, I've added my two cents over at https://github.com/Eonasdan/bootstrap-datetimepicker/issues/838#issuecomment-111452978 - but it seems nobody gets notified since the issue was closed a couple of weeks ago.
Therefore I'm opening this issue to seek out for your help. My issue is as follows:
Using the docs from http://eonasdan.github.io/bootstrap-datetimepicker/Installing/#knockout I get:
Property 'dateTimePicker' does not exist on type 'KnockoutBindingHandlers'

Adding a Knockout interface for that (current TypeScript definition for Bootstrap V3 DateTimePicker was written for 3.0.0 and not 4.14.30; BTW: @Eonasdan the changelog at http://eonasdan.github.io/bootstrap-datetimepicker/Changelog/ has a typo: 4.14.40):
/// <reference path="knockout.d.ts" />

interface KnockoutBindingHandlers {
  dateTimePicker: KnockoutBindingHandler;
}

and another fix for:
Property 'date' does not exist on type 'Datetimepicker'.

by modifying bootstrap.v3.datetimepicker.d.ts with this:
line 32 (**interface DatetimepickerOptions**): format?: any;
lines 58-62 (**interface Datetimepicker**):
date(): any;
date(date: any): void;
format(): any;
format(format: any): void;

I got the compiler's OK. However, it seems that I've missed something, because having
ko.utils.registerEventHandler(element, "dp.change", function(event) {
  var value = valueAccessor();
  console.log(value);

doesn't log anything.
Am I missing something? What did I wrong?
Any help would be greatly appreciated!

sorry I don't know enough about knockout to help you with this.


Performance Degradation

Fixes the performance degradation.
Fixes https://github.com/owncloud/ocis/issues/10545

Final Loadtest: https://drone.owncloud.com/owncloud/ocis/41011/48/1


Support WithDefault method

This issue is a feature request
Both Arg and Option don't support default value now. In order to do that, I can write something like below:
installCommand := cli.NewCommand("install", "Install a package").
	WithOption(
		cli.NewOption("retry", "maximal retry times (default: 3)").WithType(cli.TypeInt),
	).
	WithArg(
		cli.NewArg("package", "package name").WithType(cli.TypeString),
	).
	WithAction(func(args []string, options map[string]string) int {
		if _, ok := options["retry"]; !ok {
			options["retry"] = "3"
		}
		// do something
	})

With WithDefault method, I can write the default value 3 for only one time and avert a conflict between the actual code and the doc.

Should be easy to implement. Want to submit a pull request?


Compatibility with python 2.X

Compatibility with python 2.X

As I say in previous close of #2 and c971524d9ad00e0dee754a0b2296bf1938c481dc, I only accept bytes to bytearray changes.
The only way to define a new Device instance is with parameters, any other mechanism to load configuration files must be implemented by the user of Device.


Fix cut title in certificates info screen (EXPOSUREAPP-10175)

Ticket
Title in certain languages was too long and it was getting cut. Switch to English to test.

Verified with repro steps from issue https://github.com/corona-warn-app/cwa-app-android/issues/4202 on Android 11.
Steps
On Pixel 3a emulator:

Settings > Display > Font size > Default
Settings > Display > Display size > Default
Language English (United States)

In Android Studio:

Run CovPassInfoFragmentTest.kt
View file /data/data/de.rki.coronawarnapp.test/screenshots/CovPassInfoFragment.png with Device File Explorer
Note title is no longer truncated and it wraps onto two lines

There is still an issue on this screen with wide devices, such as new folding ones, described in

https://github.com/corona-warn-app/cwa-app-android/issues/4203

If you are making changes to the layout fragment_cov_pass_info.xml, this may be a good time to also take a look at this other issue.

There is still an issue on this screen with wide devices, such as new folding ones, described in
* ["Certificate Verification by Third Parties" image overlaps title #4203](https://github.com/corona-warn-app/cwa-app-android/issues/4203)

If you are making changes to the layout fragment_cov_pass_info.xml, this may be a good time to also take a look at this other issue.

@we have a separate ticket for this issue


Create an account on the Gateway Demo system

The tutorial should be updated to reflect the use of ES5 as the gateway system.

The tutorial at the start says ES5 - https://www.sap.com/developer/tutorials/gateway-demo-signup.html
Do you see something wrong in the tutorial - text, screenshot, validation ? Can you point it out?

Yes, it’s about images.
Please note that other additional tutorials include ES4 images as the GW system, e.g. https://www.sap.com/developer/tutorials/teched-2016-4.html step 6https://www.sap.com/developer/tutorials/teched-2016-4.html step 6.
An additional issue I encountered is missing images in most tutorials for creating destinations:
The filter I used:
<EMAIL_ADDRESS>Example:
<EMAIL_ADDRESS>Regards,
Raz
From: Jonathan Baker<EMAIL_ADDRESS>Sent: Monday, August 27, 2018 15:22
To: SAPDocuments/Tutorials<EMAIL_ADDRESS>Cc: raz-korn<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [SAPDocuments/Tutorials] Create an account on the Gateway Demo system (#2576)
This is about the images, correct? Specifically the last image that says ES4?
We didn't replace it because the only thing that changed was the system name (ES4 is now ES5). Everything else is the same.
I'm closing the ticket, but if there is something else please re-open the ticket and let me know the issue. Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/SAPDocuments/Tutorials/issues/2576#issuecomment-416208731, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFwrcW0i_tbNsNxNNn7zSrCbIQB8Z4E9ks5uU-R0gaJpZM4WMyTP.


Cart add only 3 items

I am using shopping cart with L5. The problem is cart only add three items not more then 3. I dont now where problem is.
Cart::destroy();
        //Add Items to Cart

            foreach($request->service_id as $row):
                $detail = explode('-', $row);
                Cart::instance('shopping')->add($detail[0], $detail[2], '1', $detail[1]);
            endforeach;

I can't reproduce this problem, everything seems to work fine. Please check your setup, or supply me with more data to reproduce your problem.


CDF file requirements example

Change Summary
Overview
Edited the cdf_requirements.rst file to include an example at the end of the Global Attributes section.
New Dependencies
None
New Files
None
Deleted Files
None
Updated Files

cdf_requirements.rst
--Included example from ticket #578 at the end of the Global Attributes section.

Testing
None

https://github.com/all-contributors please add @anamanica  for code and documentation!

@all-contributors please add @anamanica for code and documentation!


Add missing german tanslations

Some missing translations.
Do you have any kind of translation policies and/or online translation tools currently enabled for this project? (e.g. Transifex, Crowdin, etc.)

Thanks for contributing these translations. I'll wait for the review of our German-speaking friends. About your question: we don't have any policy about this or use any of the tools you mentioned. Thanks!

Fixed :wink:

The security check is failing on my language file changes - I love Travis :tongue:

While playing wit #531 I discovered more missing strings... @xabbuh would you mind to re-check? :wink:

Fixed, Thanks!
I also changed everything to "informal".
BTW: @xabbuh do you think #531 makes any sense? How do you check for missing translations? Don't you think using an online translation service (Transifex, Crowdin, etc.) would help?
Thanks again :wink:

Thank you @elkuku.


Can't load template from sibling folder

Hey,
I have the following folder setup

templates

partials
portfolio

I would now like to include a handlebars template from portfolio into a template from partials, however it does not work.
I tried many variations of:
{{>"../portfolio/item"}}

Is there a way to do this and if so, how? Thank you.

The handlebars-library does not have the notion of directories and files. If you want to use a partial, you have to call Handlebars.registerPartila('partialName', 'Contents of the partial'). Then you can use
{{> partialName}}

in your template. Or, if you are using a framework like Assemble, Metalsmith or Bootprint, you have to see how they map filenames to partial-names.

Thank you, I will look into it. 👍


fix: update to eye v10.23.1

fix: update to eye v10.23.1

:tada: This issue has been resolved in version 16.27.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release
v16.27.1

Your semantic-release bot :package::rocket:


Can't apply explain_weights neither show_weights for sklearn_crfsuit.CRF object

I was following this tutorial
https://github.com/TeamHG-Memex/eli5/blob/master/docs/source/_notebooks/debug-sklearn-crfsuite.rst
and got an error when trying to get the weights and features of the trained CRF model.
I can't get apply explain_weights neither show_weights for sklearn_crfsuite.CRF object.
I'm running all inside a python Jupyter notebook:
eli5.explain_weights_sklearn_crfsuite(crf)
AttributeError                            Traceback (most recent call last)
<ipython-input-75-2efd5261dc5d> in <module>()
      1 import eli5
----> 2 eli5.explain_weights_sklearn_crfsuite(crf)

~/virtual_envs/python3/lib/python3.6/site-packages/eli5/sklearn_crfsuite/explain_weights.py in explain_weights_sklearn_crfsuite(crf, top, target_names, targets, feature_re, feature_filter)
     26     ``feature_re`` and ``feature_filter`` parameters.
     27     """
---> 28     feature_names = np.array(crf.attributes_)
     29     state_coef = crf_state_coef(crf).todense().A
     30     transition_coef = crf_transition_coef(crf)

~/virtual_envs/python3/lib/python3.6/site-packages/sklearn_crfsuite/estimator.py in attributes_(self)
    463         A list of known attributes.
    464         """
--> 465         if self._info is None:
    466             return None
    467

~/virtual_envs/python3/lib/python3.6/site-packages/sklearn_crfsuite/estimator.py in _info(self)
    497             return None
    498         if self._info_cached is None:
--> 499             self._info_cached = self.tagger_.info()
    500         return self._info_cached
    501

pycrfsuite/_pycrfsuite.pyx in pycrfsuite._pycrfsuite.Tagger.info (pycrfsuite/_pycrfsuite.cpp:9581)()

pycrfsuite/_pycrfsuite.pyx in pycrfsuite._pycrfsuite.Tagger.info (pycrfsuite/_pycrfsuite.cpp:9498)()

~/virtual_envs/python3/lib/python3.6/site-packages/pycrfsuite/_dumpparser.py in feed(self, line)
     60             self.state = None
     61         else:
---> 62             getattr(self, 'parse_%s' % self.state)(line)
     63
     64     def parse_FILEHEADER(self, line):

~/virtual_envs/python3/lib/python3.6/site-packages/pycrfsuite/_dumpparser.py in parse_STATE_FEATURES(self, line)
     83     def parse_STATE_FEATURES(self, line):
     84         m = re.match(r"\(\d+\) (.+) --> (.+): ([+-]?\d+\.\d+)", line)
---> 85         attr, label = m.group(1), m.group(2)
     86         assert attr in self.result.attributes
     87         assert label in self.result.labels

AttributeError: 'NoneType' object has no attribute 'group'

and with show_weigths I have a similar error
eli5.show_weights(crf, top=30)
AttributeError                            Traceback (most recent call last)
<ipython-input-76-ed63fb41bd58> in <module>()
----> 1 eli5.show_weights(crf, top=30)

~/virtual_envs/python3/lib/python3.6/site-packages/eli5/ipython.py in show_weights(estimator, **kwargs)
    116     """
    117     format_kwargs, explain_kwargs = _split_kwargs(kwargs)
--> 118     expl = explain_weights(estimator, **explain_kwargs)
    119     html = format_as_html(expl, **format_kwargs)
    120     return HTML(html)

~/virtual_envs/python3/lib/python3.6/site-packages/singledispatch.py in wrapper(*args, **kw)
    208
    209     def wrapper(*args, **kw):
--> 210         return dispatch(args[0].__class__)(*args, **kw)
    211
    212     registry[object] = func

~/virtual_envs/python3/lib/python3.6/site-packages/eli5/sklearn_crfsuite/explain_weights.py in explain_weights_sklearn_crfsuite(crf, top, target_names, targets, feature_re, feature_filter)
     26     ``feature_re`` and ``feature_filter`` parameters.
     27     """
---> 28     feature_names = np.array(crf.attributes_)
     29     state_coef = crf_state_coef(crf).todense().A
     30     transition_coef = crf_transition_coef(crf)

~/virtual_envs/python3/lib/python3.6/site-packages/sklearn_crfsuite/estimator.py in attributes_(self)
    463         A list of known attributes.
    464         """
--> 465         if self._info is None:
    466             return None
    467

~/virtual_envs/python3/lib/python3.6/site-packages/sklearn_crfsuite/estimator.py in _info(self)
    497             return None
    498         if self._info_cached is None:
--> 499             self._info_cached = self.tagger_.info()
    500         return self._info_cached
    501

pycrfsuite/_pycrfsuite.pyx in pycrfsuite._pycrfsuite.Tagger.info (pycrfsuite/_pycrfsuite.cpp:9581)()

pycrfsuite/_pycrfsuite.pyx in pycrfsuite._pycrfsuite.Tagger.info (pycrfsuite/_pycrfsuite.cpp:9498)()

~/virtual_envs/python3/lib/python3.6/site-packages/pycrfsuite/_dumpparser.py in feed(self, line)
     60             self.state = None
     61         else:
---> 62             getattr(self, 'parse_%s' % self.state)(line)
     63
     64     def parse_FILEHEADER(self, line):

~/virtual_envs/python3/lib/python3.6/site-packages/pycrfsuite/_dumpparser.py in parse_STATE_FEATURES(self, line)
     83     def parse_STATE_FEATURES(self, line):
     84         m = re.match(r"\(\d+\) (.+) --> (.+): ([+-]?\d+\.\d+)", line)
---> 85         attr, label = m.group(1), m.group(2)
     86         assert attr in self.result.attributes
     87         assert label in self.result.labels

AttributeError: 'NoneType' object has no attribute 'group'

Nevertheless if I call crf.tagger_.dump(filename="crf_tagger.txt") I get a file crf_tagger.txt with all the information about features, state transitions, etc.

Hm, I just reinstalled everything, and tutorial works for me. I'm not sure how to debug this. Could you try updating python-crfsuite? What package versions are you using (sklearn-crfsuite, python-crfsuite, eli5)?

sklearn-crfsuite (0.3.6)
python-crfsuite (0.9.2)
eli5 (0.7)
everything installed through pip

Is it failing for the tutorial as-is, or have you changed anything? It shouldn't fail with changes; I'm just trying to figure out how to reproduce it.
It looks like a bug in https://github.com/scrapinghub/python-crfsuite - it has code which parses crf.tagger_.dump(filename="crf_tagger.txt") output to get data in a structured format, and this fails for you.

what is your NLTK version, by the way?

I'm using the tutorial code, but with a different corpus and roughly the same feature extraction temples just some small changes.
I don't have NLTK installed, is it a dependency?
Also, using: Python 3.6.2 (default, Jul 17 2017, 16:44:45)

NLTK is not a dependency for eli5, but it is required to run the tutorial (corpus is from NLTK).
I suspect corpus can trigger the bug; feature names extracted on your data may break the export. Export is just formatted text, and I'm not sure data is escaped properly by crfsuite. It looks very similar to https://github.com/scrapinghub/python-crfsuite/issues/14.

I'm now just reducing the feature extraction template for a simple set of features, I will let you know how it goes. Thanks for the quick feedback!

I've noticed that in the crf.tagger_.dump(filename="crf_tagger.txt") dumped file, I have long line breaks, this is happens due to tokenisation of the input text, producing several \n as a token, e.g.:
     24: +1:word.lower():,
     25: +1:shape:,
     26: +2:word.lower():

     27: +2:shape:,
     28: word.lower():,
     29: shape:,
     30: -1:word.lower():hallo
     31: -2:word.lower():flüge
     32: -2:word.istitle()
     33: -2:word.isupper()
     34: -2:word.isdigit()
     35: -2:shape:Xxxxx
     36: +1:word.lower():

     37: +1:shape:

     38: +2:word.lower():ich
     39: +2:shape:

might this be the reason for the regex to fail?

It was indeed that the reason! Fixed that and it's working now! =)

Yeah, it looks like a reason. Ideally, it should be fixed in python-crfsuite (https://github.com/scrapinghub/python-crfsuite/issues/14). Thanks for confirming it!

Where do you guys are exactly performing the replacements of new lines and spaces? It seems I am having the same problem... Thanks in advance :-)

Where are you guys exactly performing the replacements of new lines and spaces? It seems I am having the same problem... Thanks in advance :-)

It was indeed that the reason! Fixed that, basically replacing new lines and spaces by #NEWLINE and #SPACE and it's working now! =)

This is still an issue and replacing \n characters or \s is not a solution. Since I need to find the original position of predicted token in original text. When i replace \n with in original text. This is no longer possible.
Where are you guys exactly performing the replacements of new lines and spaces?
TIA


Add interface for caching sorted affine peers

r @raynos @jcorbin

@jcorbin Did we do this in #111

Enough for now yes, if we ever want to revisit micro-ops like updating a sorted list incrementally, we can revisit.


Skip fields from bib that are created in the enrichment.

The fields are:

[x] 950 $a should be true or false
[x] 852 $8 starts with:22 ends with:06421
[x]  866 $8 starts with:22 ends with:06421
[x] 867 $8 starts with:22 ends with:06421
[x] 868 $8 starts with:22 ends with:06421
- [ ] 952 $8 starts with:22 ends with:06421 check with @mzelesky. I don't think we have this. We decided not to use 952 https://github.com/pulibrary/bibdata/issues/823#issuecomment-740063481
[x] 876 $0 starts with:22 ends with:06421 check notes in commit with @mzelesky
[x] 951 $8 starts with:53 ends with:06421
[x] 953 $a starts with:53 ends with:06421
[x] 954 $a starts with:53 ends with:06421

Also update old sandbox fixtures with alma fixtures. I opened an issue for two that I need to spend more time to find them https://github.com/pulibrary/bibdata/issues/1530

Check with @mzelesky notes in princeton_marc line: ~795 Traject::MarcExtractor.cached('87603ahjptxz').collect_matching_lines(record) do |field, _spec, _extractor|. In the past we were using this block only for scsb. Now we are using it to index in holdings_1display more information that exists in the item level. eg. copy_number

closed by #1543


Fix shellcheck not working

What type of PR is this?
/kind fix
What this PR does / why we need it:
Disable ignoring warnings and error for shellcheck
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

NONE

/ok-to-test

/hold

@tenzen-y Could you check if shellcheck is working fine for you now.

@tenzen-y I think we can remove the hold form this PR.

@tenzen-y I think we can remove the hold form this PR.

Oops, I forgot to cancel the holding. Thanks!
/hold cancel


Working GOVUK One Login integration

Context
First iteration of spike: https://github.com/DFE-Digital/apply-for-teacher-training/pull/9430
How GOV.UK One Login works: https://docs.sign-in.service.gov.uk/how-gov-uk-one-login-works/#how-gov-uk-one-login-works
We will only need P0 Authentication for now. This does not prove identity but provides Authentication to a similar level as what “magic links“ do for us currently. The idea is Candidates can login using the One Login service rather than using a clunky magic links for signing into the service
At DfE there has been a push to use GOV.UK One Login to manage user authentication for all DfE applications, this has a few benefits:

Creates consistency across all DfE owned applications
Allows a user to sign in using GOV.UK One Login once and access all GOV.UK One Login supported DfE applications
Is more secure as we have one system to manage authentication

Changes proposed in this pull request

Added a new flow (this is just for functionally, so it looks ugly). On the candidate home page their is now a link Sign in with GOVUK One Login to sign in using GOVUK One Login (You can still sign in using magic links for now)

Link to Trello card
https://trello.com/c/kXrGVWMt/1533-spike-onelogin-authentication-service
Notes
To get this running locally you will need to set the below variables. GOVUK_LOGIN_PRIVATE_KEY I can provide, the GOVUK_LOGIN_PUBLIC_KEY can be found at https://admin.sign-in.service.gov.uk/ under Public Key and the GOVUK_LOGIN_ISSUER_URL is mentioned in the technical documents but is https://oidc.integration.account.gov.uk/
GOVUK_LOGIN_PRIVATE_KEY
GOVUK_LOGIN_PUBLIC_KEY
GOVUK_LOGIN_ISSUER_URL
In order to get this working with review apps or any other environment, I needed to add the review app url under the Redirect URIs Post logout redirect URIs.

 Long running Sidekiq pods in Review


[BACKLOG-14601] - Change URL and modify text position

@pentaho/bobafett please review

It means to change doc URL we need rebuild kettle instead of just change properties file. Is it correct?

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f ui/build.xml clean-all resolve jacoco && ant -f ui/build.xml checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  ui/src/org/pentaho/di/ui/core/PropsUI.java
  ui/src/org/pentaho/di/ui/core/default.properties
  ui/src/org/pentaho/di/ui/core/dialog/BrowserEnvironmentWarningDialog.java
  ui/src/org/pentaho/di/ui/core/dialog/messages/messages_en_US.properties

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.ui.core.PropsUI

Complexity Change:  + .00%
Instruction Change:  + .00%
Line Change:  + .00%
Method Change:  + .01%

Checkstyle violations
The code submitted is not complying with one or more of our guidelines. To perform these checks locally, please use this tool.
/home/buildguy/project/ui/src/org/pentaho/di/ui/core/dialog/BrowserEnvironmentWarningDialog.java

:heavy_exclamation_mark: 'static' modifier out of order with the JLS suggestions. at Line: 67 Column: 17

:heavy_exclamation_mark: '=' is not preceded with whitespace. at Line: 67 Column: 39

Yes, the idea is to eliminate the redundant url that was added in the properties file and instead use the function getDocUrl to obtain it

Build Completed
:white_check_mark: This pull request has passed all validations.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f ui/build.xml clean-all resolve jacoco && ant -f ui/build.xml checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  ui/src/org/pentaho/di/ui/core/PropsUI.java
  ui/src/org/pentaho/di/ui/core/default.properties
  ui/src/org/pentaho/di/ui/core/dialog/BrowserEnvironmentWarningDialog.java
  ui/src/org/pentaho/di/ui/core/dialog/messages/messages_en_US.properties

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.ui.core.PropsUI

Complexity Change:  + .00%
Instruction Change:  + .00%
Line Change:  + .00%
Method Change:  + .01%


fix: platform issues.

windows and rhel5.4 can't load libmklml_intel.so.
macos need to load libmklml.dylib.
rhel5.4 need use the icc because libiomp5 is not compatiable.

Create new Jenkins PR server. Passed all test cases.


Larva on ibis4testiaf fails with 'too many redirects

Describe the issue
Larva on ibis4testiaf fails with 'too many redirects'
Reporter
Gerrit

To Reproduce
Steps to reproduce the behavior:

Go to ibis4testiaf
Click on testing -> Larva
See error 'xxxx redirected you too many times.'

Environment
FF! 7.8-20220705.153038: Ibis4Test
Running on xxxx using IBM WebSphere Application Server/<IP_ADDRESS>
Java Version: Java(TM) SE Runtime Environment (<IP_ADDRESS> - pxa6480sr7-20211025_01(SR7))
Heap size: 769M, total JVM memory: 1024M
Free disk space: 1GB, total disk space: 2GB
Up since: 2022-07-05 23:20:06 (9h)

https://www.ibm.com/support/pages/javalangstring-getpathinfo-returns-null


double-beep: Blacklist smartspidering.com

double-beep requests the blacklist of the website smartspidering\.com. See the MS search here and the Stack Exchange search here.

smartspidering\.com has been seen in 6 true positives, 0 false positives, and 1 NAA.

Approved by Makyen in Charcoal HQ


[core]Support common jdbc catalog lock for filesystem catalog.

Purpose

Linked issue: close (https://github.com/apache/incubator-paimon/issues/3032)

@FangYongs  @JingsongLi  PTAL

I will revert this PR in https://github.com/apache/paimon/pull/3099
It seems that the current approach is wrong.


For a 1.3.3 release

#121

Codecov Report

Merging #122 (f740946) into master (cd38d76) will not change coverage.
The diff coverage is 50.00%.

:exclamation: Current head f740946 differs from pull request most recent head 5684782. Consider uploading reports for the commit 5684782 to get more accurate results

@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   93.87%   93.87%
=======================================
  Files           8        8
  Lines         245      245
=======================================
  Hits          230      230
  Misses         15       15

Impacted Files
Coverage Δ

src/data_utils.jl
98.21% <ø> (ø)

src/model_api.jl
66.66% <0.00%> (-8.34%)
:arrow_down:

src/model_traits.jl
73.17% <75.00%> (+1.74%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd38d76...5684782. Read the comment docs.


Internal Limits to Views

ValueSize, KeyLength, SegmentationValues

great work! 🚀 just to note, there is one failing test in unit tests, mentioning here not to slip. not sure if it's relevant or not.


Dataview parsing of YAML tags doesn't match Obsidian parsing

What happened?
I'm defining multiple tags in the YAML block like this:
tags: Financial-advice  source/article
Note that I do not have a comma as a delimiter between the two tags.   This 'space as delimiter' does work correctly with Obsidian itself - I can search for either tag and see the file that contains this YAML block.
The problem is that if I run a dataview query based on a tag defined in this way, dataview does not report it in its results.
list
from #source/article

This conflict between how Obsidian parses YAML defined tags and how dataview does it is very confusing.  Can you revise Dataview's parsing to match how Obsidian natively parses YAML-defined tags?
Thanks!
DQL
list
from [[Topic]] and #source/article

JS
No response
Dataview Version
0.5.23
Obsidian Version
0.14.15
OS
MacOS

I think the problem is the reverse: not a Dataview issue, but a Obsidian issue.
The main problem is: what's the right way to enter multiple tags in yaml?
Obsidian suggest this format (a usual yaml frontmatter rule):
---
tags:
  - tag1
  - tag2
---

You can also use this (also a second yaml frontmatter rule):
---
tags: [tag1, tag2]
---

You can also benefit from other accepted format to Obsidian and Dataview:
---
tags: tag1, tag2
---

i.e, at least with a comma. (in this point you benefit from the fact that tags becomes also the implicit field file.tags. Because if you query to the field tags you don't have a list but a simple string: tag1, tag2.
If Obsidian strangely accept the format tags: tag1 tag2... well, it's a strange behavior in Obsidian side, not in Dataview side (because Dataview follow the right yaml rules).

Thanks for the feedback.
I brought this up because irregardless of the standard, the result is that dataview can silently 'fail' to return some results that would otherwise be valid and expected by the end user.  Even if they were not trying to use a space as a delimiter, they may inadvertently delete one or fail to add it, with everything still working okay in Obsidian except Dataview doesn't return that particular file in a query.
I think this should be a community discussion as I know of at least one other plug-in that uses the Obsidian parsing variation (Linter).  Also some plugsin do YAML tag pulldown menus, and I'm not sure which standard they follow.
Can you (or I) bring this up in discord to see if we can get a discussion and agreement about standardizing the parsing here?  I can live with it either way, I just don't like having inconsistent rules / silent failures between different components.
Thanks!

To be clear, is the issue here that you define tags in frontmatter like tag: tag1 tag2? Dataview does not support this syntax present, but if Obsidian works, I will also support it.

@blacksmithgu, yes, is that the issue here. I know you can do anything :)
@DanF-88 You can start a discussion (you're certainly more informed and with better knowledge than me - i'm not a coder or similar). I just have some reluctance about the "deviations" from standard because the future of the basic plain text (md) file. It's more secure to use the standard list syntax in yaml or an amount of exceptions in specific app and plugins?
But this is just a principle reluctance (but I can be wrong...).

Dataview supports space-delimited tags in the next release this evening.

Thank you!  I appreciate the quick response and update!
If you and the Obsidian Devs decide to move to the formal YAML delimiter format, that would also be fine for me. I'm just interested in having Obsidian and all the plug-ins follow the same rules.

Dan

On Sat, Jun 4, 2022, at 5:22 PM, blacksmithgu wrote:

Dataview supports space-delimited tags in the next release this evening.
—
Reply to this email directly, view it on GitHub https://github.com/blacksmithgu/obsidian-dataview/issues/1146#issuecomment-1146710619, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUCOE34PT72OU7JDIIOZD43VNPXN5ANCNFSM5X36ZXEQ.
You are receiving this because you were mentioned.Message ID: @.***>


Random text glitches when using WSL1

Environment
Windows build number: Version 10.0.19041.207
Windows Terminal version (if applicable): Version: 0.11.1251.0
GPU0: Intel UHD Graphics 630 | Driver: <IP_ADDRESS>37
GPU1: Nivida GTX 1060 6GB | Driver: 445.87

Steps to reproduce

Open a new tab with "Ubuntu" on WSL1
Type any command e.g(ls)
Wait for 2 or 3 seconds

Behavior
The text starts to break and glitch out. I've had this problem before with VS CODE and was fixed by disabling GPU acceleration

Thanks for the report! This looks like a /dupe of #5759.
Do you have "Conservative Morphological Anti-Aliasing" turned on in the Intel driver settings?

Thanks @DHowett-MSFT for the fast response. this was actually fixed by disabling Image sharpening at Nivida control panel


stuntrally: 2.6.1 -> 2.6.2

This update also fixes the build problems
reported in #175646.
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Default stdenv has gcc11
Please remove the stdenv override from all-packages.nix
  stuntrally = callPackage ../games/stuntrally
    { stdenv = gcc10StdenvCompat; ogre = ogre1_9; mygui = mygui.override { withOgre = true; }; };

Compiles and runs fine.

@Artturin Thank you for catching this!