Github website is returning 404

@heyarviind Thanks for the issue, it seems someone has changed the name of the repository. Hence GitHub pages couldn't find the source code as it once did. We will get it resolved soon enough. Thank you.

Solved.


scrollToIndex not working on a FlatList

Please provide all the information requested. Issues that do not follow this format are likely to stall.
Description
calling scrollToIndex() does not scroll to index
React Native version:
Run react-native info in your terminal and copy the results here.
How do I run Run react-native info on snack (I assume snack is using a recent react)?
Steps To Reproduce
Provide a detailed list of steps that reproduce the issue.

create a FlatList with 100 items, to many to fit on a page
call this.flatListRef.scrollToIndex({animated: true, index: 50}

Expected Results
Expect item 50 to appear at the top of the rendered FlatList
Actual Results
FlatList shows item 0 at the top of rendered list
Snack, code example, screenshot, or link to a repository:
minimal snack example
import React, { Component } from 'react';
import { Text, View, FlatList, Dimensions, Button, StyleSheet } from 'react-native';

const { width } = Dimensions.get('window');

const style = {
  justifyContent: 'center',
  alignItems: 'center',
  width: width,
  height: 50,
  flex: 1,
  borderWidth: 1,
};

const COLORS = ['deepskyblue','fuchsia', 'lightblue '];

function getData(number) {
  let data = [];
  for(var i=0; i<number; ++i)
  {
    data.push("" + i);
  }

  return data;
}

class ScrollToExample extends Component {

  getItemLayout = (data, index) => (
    { length: 50, offset: 50 * index, index }
  )

  getColor(index) {
    const mod = index%3;
    return COLORS[mod];
  }

  scrollToIndex = () => {
    this.flatListRef.scrollToIndex({animated: true, index: 50});
  }

  render() {
    return (
      <View style={styles.container}>
        <View style={styles.header}>
          <Button
            onPress={this.scrollToIndex}
            title="Tap to scrollToIndex"
            color="darkblue"
          />
        </View>
        <FlatList
          ref={(ref) => { this.flatListRef = ref; }}
          keyExtractor={item => item}
          getItemLayout={this.getItemLayout}
          renderItem={({ item, index}) => (
              <View style={{...style, backgroundColor: this.getColor(index)}}>
                <Text>{item}</Text>
              </View>
            )}
          data={this.props.data}
        />
      </View>
    );
  }
}

const styles = StyleSheet.create({
  container: {
    flex: 1
  },
  header: {
    paddingTop: 20,
    backgroundColor: 'darkturquoise',
    alignItems: 'center',
    justifyContent: 'center'
  }
});

export default class app extends Component {
  render() {
    return  <ScrollToExample
              data={getData(100)}
            />
  }
}

Note: In the snack we are calling a list index in range. But IF I call with a large index (e.g. 150), we will get "Uncaught Invariant Violation: scrollToIndex out of range: 150 vs 99", which is expected AND shows that the component is receiving the function call.

The snack example works perfectly fine for me. The flatlist contains 100 items with viable indices ranging from 0 to 99. If you try to scroll to an index smaller than 0 or bigger than 99 you'll naturally get an out of range exception.
Are you sure that you are not getting the exception because you're trying to scroll to an out of range index?

This works on the iOS simulator, not the Web version. At the top right of the Snack, select iOS instead of Web.

The snack example works perfectly fine for me. The flatlist contains 100 items with viable indices ranging from 0 to 99. If you try to scroll to an index smaller than 0 or bigger than 99 you'll naturally get an out of range exception.
Are you sure that you are not getting the exception because you're trying to scroll to an out of range index?

@naraB  I am asking about why it doesn't work when the index is IN range. I mentioned the out of range exception, only to demonstrate   that the component is being called. In the snack the index is in range.

@israelgonzalezb @kenpower i have a similar issue however in my case i set the initialIndex to my target index X, and also i do the scrollToIndex, however when my list has a large number of data (like 100-500 image) it just scroll the wrong index Y (which is always < X).

Any workarounds?

Any Update on this?

calling scrollToIndex() does not scroll to index for ios it works fine on android
"react-native": "0.72.4",
"@react-navigation/native": "^6.1.7",
"@react-navigation/native-stack": "^6.9.13",


Error detecting Vivo devices

UA:
Mozilla/5.0 (Linux; U; Android 9; th; vivo 1915) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.137 Mobile Tenta/3.1.6 Build/2162 Safari/537.36

Result:
Calculated:
browser:
    name: 'Tenta Browser'
    family: { name: Chrome, version: 64 }
    version: 3.1.6
    type: browser
engine:
    name: Blink
os:
    name: Android
    version: '9'
device:
    type: mobile
    subtype: smart
    model: 'vivo 1915) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.137 Mobile Tenta/3.1.6'

The device->model is displaying junk result.
Expected results:
device:
    model: Y19

I leave the admins to fix this issue.

Fixed in upcoming 2.1.1

Fixed in upcoming 2.1.1


Documentation: Clearly state that OkHttpClient should be a singleton

I learned from StackOverflow that a single instance of OkHttpClient should be created and that it should be shared among all services in the application that need to communicate via HTTP. I haven't been able to find anything definitive in the docs on how the OkHttpClient is designed to be used.
I'd like to request that this information be included in the overview page of the docs https://square.github.io/okhttp/ in order to have a trustworthy and easy to find source for that piece of information. All examples in the docs just create a new instance of the client.

Yep, it should probably go on the main doc page.
It's here currently https://square.github.io/okhttp/5.x/okhttp/okhttp3/-ok-http-client/index.html

Hey bro
Where can I upload everything I do have

So I go where to write this
Plz understand me i don't understand a lot computer
I just wanna learn it

Hey I respect that bro
So you guys in my house almost

I can't find it can you help me man plz

Can I add here?


Docker hub page shows deprecated source repository

The Docker Hub home page for ibmcom/mq is showing the deprecated repository ibm-messaging/mq-docker as the source page for the image. This should be corrected.

Unfortunately, Docker do not allow that field to be changed!

This no longer seems to appear on the Docker Hub page, and it shows that the ibmcom/mq image isn't linked to a GitHub repository.


Remove expensive web casts

as casts are not free, and on the web the runtime as check implementation is in the top 2-3 hot functions. This is an attempt to remove as many as casts as possible

closing in favor of individual changes


WIP: Python wrapper

Hi! I need some feedback on my python wrapper for your library.
Build and Install
Package uses setuptools extension interface, so it can be properly built and installed into virtualenv.
You need g++, make, cmake and swig to be installed on your system.
> python setup.py install

Try it out
from ivfhnsw import Index, IndexGrouping
import numpy as np

index = Index(4, 4, 4, 4)
index.build_quantizer('', '', '')
x = np.array([[5, 5, 5, 5]], dtype=np.float32)
labels = index.assign(x, 1)
distances, labels_ = index.search([[1, 2, 3, 4]], 1)
print(labels, distances, labels_)

This example is from python-tests/ directory
Plans
I need to know if anyone really needs a fully working python interface.
Any help is appreciated!

Hi,
Thanks for your contribution! I'll test your wrapper on real data at an early date. If everything is fine, I'll accept your request.


Cannot add new collection to Mongo connector

I've been using mongo-connector for some time now to connect my company's mongo database to an Elasticsearch instance on AWS. I recently tried to add another collection to the collections being connected via mongo connector, and for some reason mongo connector did not add it into elasticsearch. Following the instructions under Resyncing The Connector in the wiki, I deleted the index at which the new collection would be stored, and restarted mongo-connector with an empty oplog progress file. Mongo connector added in the collection that was previously in the index that I had deleted, but for some reason the one I'm trying to add still hasn't been put into Elasticsearch. See my config file here. The collection I added is bank.goalbook_bank_goal_bases. Please let me know if there are any troubleshooting steps I've missed or if there is an error within mongo-connector somewhere.

The issue turned out to be that one of the fields in my documents were a reserved field type in elasticsearch.


Update to duckdb 070

Huge thanks to @kimmolinna for commits 1-5, bumping duckdb version to 0.7.0 and fixing consequent API breakages.
There is something going on with testing infrastructure that I have to come back on, failures were all like:
Expected 1 to equal 1. (??) potentially it has to do with the testing infrastructure itself, I am checking this out to be able to revert the last commit.

And there should be tests also for different storage provider connections.


coverage report -m reports "No source for code:"

Describe the bug
While trying to produce the coverage report for a package the following error is produced:
No source for code: '/home/janito/dinterpol/Expression: "a["b"]"'.
To Reproduce
git clone git@github.com:joaompinto/dinterpol.git
cd dinterpol
pip install coverage
coverage run -m pytest
coverage report -m

What version of Python are you using?
3.8.10

-- sys -------------------------------------------------------
coverage_version: 6.4.1
coverage_module: /home/janito/.local/lib/python3.8/site-packages/coverage/init.py
tracer: -none-
CTracer: available
plugins.file_tracers: -none-
plugins.configurers: -none-
plugins.context_switchers: -none-
configs_attempted: .coveragerc
setup.cfg
tox.ini
pyproject.toml
configs_read: /tmp/dinterpol/setup.cfg
/tmp/dinterpol/tox.ini
config_file: None
config_contents: -none-
data_file: -none-
python: 3.8.10 (default, Jun  2 2021, 10:49:15) [GCC 9.4.0]
platform: Linux-<IP_ADDRESS>-microsoft-standard-WSL2-x86_64-with-glibc2.29
implementation: CPython
executable: /usr/bin/python3
def_encoding: utf-8
fs_encoding: utf-8
pid: 3232
cwd: /tmp/dinterpol
path: /home/janito/.local/bin
/usr/lib/python38.zip
/usr/lib/python3.8
/usr/lib/python3.8/lib-dynload
/home/janito/.local/lib/python3.8/site-packages
/usr/local/lib/python3.8/dist-packages
/usr/lib/python3/dist-packages
environment: HOME = /home/janito
command_line: /home/janito/.local/bin/coverage debug sys
sqlite3_version: 2.6.0
sqlite3_sqlite_version: 3.31.1
sqlite3_temp_store: 0
sqlite3_compile_options: COMPILER=gcc-9.3.0, ENABLE_COLUMN_METADATA, ENABLE_DBSTAT_VTAB,
ENABLE_FTS3, ENABLE_FTS3_PARENTHESIS, ENABLE_FTS3_TOKENIZER, ENABLE_FTS4,
ENABLE_FTS5, ENABLE_JSON1, ENABLE_LOAD_EXTENSION, ENABLE_PREUPDATE_HOOK,
ENABLE_RTREE, ENABLE_SESSION, ENABLE_STMTVTAB, ENABLE_UNLOCK_NOTIFY,
ENABLE_UPDATE_DELETE_LIMIT, HAVE_ISNAN, LIKE_DOESNT_MATCH_BLOBS,
MAX_SCHEMA_RETRY=25, MAX_VARIABLE_NUMBER=250000, OMIT_LOOKASIDE,
SECURE_DELETE, SOUNDEX, TEMP_STORE=1, THREADSAFE=1, USE_URI

Expected behavior
A report being generated.

You haven't provided a way to reproduce the problem.  To get some more data, can you run with COVERAGE_DEBUG=trace in your environment variables?  It will write data to stderr that shows the tracing decisions being made.
Are you running some unusual packages? It looks like you have something like Expression: "a["b"]" which has code being executed. What does that?
BTW: you can probably just simply work around this by using the coverage report --ignore-errors option.

Hi, I presume you missed the "To Reproduce" section :) those commands should result in the error.
In short you can test with the "https://github.com/joaompinto/dinterpol" library.
Yes, I am using the -i for workaround but would be nice to fix the bug :)
Thanks

Looks like "enclosed" is being used in an unusual way. I even installed it from GitHub:
ImportError while importing test module '/private/tmp/bug1393/dinterpol/dinterpol/test_template.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/local/pyenv/pyenv/versions/3.8.13/lib/python3.8/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
dinterpol/__init__.py:1: in <module>
    from .template import Template
dinterpol/template.py:1: in <module>
    from enclosed import Parser, TokenType
E   ImportError: cannot import name 'TokenType' from 'enclosed' (/usr/local/virtualenvs/tmp-5545f1cbf614fba/lib/python3.8/site-packages/enclosed/__init__.py)

I fixed that with:
diff --git a/dinterpol/template.py b/dinterpol/template.py
index 2d6f073..a60b71d 100644
--- a/dinterpol/template.py
+++ b/dinterpol/template.py
@@ -1,4 +1,4 @@
-from enclosed import Parser, TokenType
+from enclosed.parser import Parser, TokenType
 from .attr2key import attr2key

I would recommend changing these lines:
diff --git a/dinterpol/template.py b/dinterpol/template.py
index 2d6f073..ed2dfcf 100644
--- a/dinterpol/template.py
+++ b/dinterpol/template.py
@@ -64,7 +64,7 @@ def f_string_compile(self, tokens):
             if self.attribute_convert:
                 token_text = attr2key(token_text)
             code = compile(
-                token_text, filename='Expression: "%s"' % token_text, mode="eval"
+                token_text, filename='<dinterpol expression: "%s">' % token_text, mode="eval"
             )
             return code
         f_string = ""
@@ -79,7 +79,7 @@ def f_string_compile(self, tokens):
                 token_text = attr2key(token_text)

                 f_string += "f'{%s}'" % token_text
-        code = compile(f_string, filename='Expression: "%s"' % token_text, mode="eval")
+        code = compile(f_string, filename='<dinterpol expression: "%s">' % token_text, mode="eval")
         return code

     def render(self, mapping):

Coverage.py assumes that "file names" starting with an angle bracket are synthetic and reading them should not be attempted.  I'm not sure what other way I can change its behavior.

Will do. Thanks for the help.


IndexError while merging dask dataframes

I'm running into the following issue while merging a dask dataframe with an empty dask dataframe.
IndexError: single positional indexer is out-of-bounds
The stacktrace is as follows:
File "/home/ubuntu/.local/lib/python3.6/site-packages/dask/dataframe/multi.py", line 555, in merge
    indicator=indicator,
  File "/home/ubuntu/.local/lib/python3.6/site-packages/dask/dataframe/multi.py", line 271, in hash_join
    lhs2 = shuffle_func(lhs, left_on, npartitions=npartitions, shuffle=shuffle)
  File "/home/ubuntu/.local/lib/python3.6/site-packages/dask/dataframe/shuffle.py", line 239, in shuffle
    meta=series_type_like_df(df)([0]),
  File "/home/ubuntu/.local/lib/python3.6/site-packages/dask/dataframe/utils.py", line 674, in series_type_like_df
    return type(df._meta.iloc[:, 0])
  File "/home/ubuntu/.local/lib/python3.6/site-packages/pandas/core/indexing.py", line 1418, in __getitem__
    return self._getitem_tuple(key)
  File "/home/ubuntu/.local/lib/python3.6/site-packages/pandas/core/indexing.py", line 2092, in _getitem_tuple
    self._has_valid_tuple(tup)
  File "/home/ubuntu/.local/lib/python3.6/site-packages/pandas/core/indexing.py", line 235, in _has_valid_tuple
    self._validate_key(k, i)
  File "/home/ubuntu/.local/lib/python3.6/site-packages/pandas/core/indexing.py", line 2014, in _validate_key
    self._validate_integer(key, axis)
  File "/home/ubuntu/.local/lib/python3.6/site-packages/pandas/core/indexing.py", line 2088, in _validate_integer
    raise IndexError("single positional indexer is out-of-bounds")
IndexError: single positional indexer is out-of-bounds

This error is specifically happening with the latest release (dask==2.5.2) . It seems to work smoothly with dask 2.4.0

Thank you for the error report @debabrata-mishra .  Are you able to provide a minimal reproducible example?  That is probably the first step to identifying and resolving this error:

https://stackoverflow.com/help/minimal-reproducible-example
https://blog.dask.org/2018/02/28/minimal-bug-reports

Sure. The following is the code snippet where the code used to fail.
	overall_data = pd.DataFrame()
	overall_data = dd.from_pandas(overall_df, npartitions=self.npartitions)

	for x in range(self.k_clusters):
		#some code blocks
		df = df[df.cluster == x]
		overall_data = dd.merge(overall_data, df, how='outer')

The following is a sample code which should be able to reproduce the error:
import pandas as pd
import dask.dataframe as dd
k_clusters = 3
df = pd.DataFrame({'user': ['A', 'B', 'C', 'D', 'E', 'F'],
                   'cluster': [1, 1, 2, 2, 3, 3]})
df = dd.from_pandas(df, npartitions=10)

empty_df = pd.DataFrame()
empty_df = dd.from_pandas(empty_df, npartitions=10)

for x in range(k_clusters):
	df = df[df.cluster == x]
	empty_df = dd.merge(empty_df, df, how='outer')

As mentioned the code snipet works flawlessly in dask v2.4.0 but is throwing the aforementioned error with the latest release.

Thank you for the minimal reproducible example @debabrata-mishra . This is very helpful.
@rjzamora I suspect that this might have something to do with your recent work.  Would you mind taking a look?

No problem - I will look into this.  I can confirm that I get the same error


Sanitize documentation for G2Diagnostic to remove examples and mark methods as internal

Too many G2Diagnostic examples and the documentation exposes G2Diagnostic functions that should be considered unsupported/experimental/internal.
Get with @antaenc to determine which G2Diagnostic functions are visible in G2Command.

no loger needed


chore: bdd-gh-1586084182 to 0.0.1

chore: Promote bdd-gh-1586084182 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Add query to return a list of available queries for the workflow instance

The list should also include documentation about each query semantic and accepted arguments.

Cadence Web is actually working around this by attempting to call a query and parsing the list of names from the returned error. It doesn't include the parameters though.

And it is broken for Java which returns this list in a different error string

Requires https://github.com/uber/cadence/issues/390

this should already be supported, closing it.


Add envFrom to container spec and expose in values file for use in proxy environments

Tell us about your request
Add the envFrom property to the container spec in charts/karpenter/templates/deployments.yaml and expose that property in the charts/karpenter/values.yaml file.
Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
Many of our customers route traffic through network proxies, which requires deploying a configMap with http_proxy environment variables in the cluster, and referencing that configMap in each container that is part of a deployment. Adding the envFrom property in the container spec and exposing it in the values file makes it easy for customers to use the upstream directly without having to maintain their own charts with that modification.
Are you currently working around this issue?
I have made the changes suggested above, packaged the charts, and tested in an environment with a proxy. PR is ready to go, but I wanted to create the issue first and ask when submitting the PR, would this be a feat, docs, fix, etc.? It doesn't warrant updating a minor version , but I think updating the patch version would be appropriate even though it's not a "fix" in the purest sense.
Additional Context
No response
Attachments
No response
Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Feel free to submit the PR, we can categorize it while reviewing the PR!

https://github.com/aws/karpenter/pull/3394

Merged! Thanks!


Arbitrary folder structure for Config Context retrieved from Git repository

Environment

Python version: 3.6.2
Nautobot version: 1.2.1

Proposed Functionality
When importing Config Context data from Git repositories, instead of assuming flat folder structure within the key folder names, we leave it up to the user to define any arbitrary folder structure, and via recursive function we extract all the files.
Use Case
When retrieving Config Context from a Git repository, we look for some key folder names (such as devices, regions, etc.) and then within them, we look for specific matches of the slug in YAML or JSON files.
When you manage thousands of elements, the list gets big and updating data could be misleading, so being able to create any kind of folder structure within these folders could help to a more user-friendly composition.
For instance, the user could decide to group all the devices by the region and the site it belongs too, for easier management:
Today we have:
├── devices
│   ├── device_1.yaml
│   ├── device_2.yaml
│   ├── device_3.yaml
│   ├── device_4.yaml

With this feature, the user could define their own folder structure:
├── devices
│   ├── abc
│   │   └── device_2.yaml
│   │   └── 123
│   │   │   ├── device_3.yaml
│   ├── xyz
│   │   └── device_1.yaml
│   │   ├── device_4.yaml

Database Changes
No changes expected
External Dependencies
No changes expected

@chadell Validating a constraint: The folders abc, 123, and xyz in your example above should not follow any convention and are therefor arbitrary. The system would just search all subdirectories under devices for all device configs.

yes @bryanculver , the folders are totally arbitrary, the more convenient for the user purposes. It's kind of flatting all the files within devices, still using the filename for mapping.

something like this could do the trick


add new feature for image stimuli

add a new feature which enables us to use image stimuli

pre-commit-ci failing due to #774

I changed it to a copyright free image, according to this  and this is the image

you can checkout this branch and test the feature via:
import pymovements as pm

pm.utils.plotting.draw_image_stimulus('./tests/files/pexels-zoorg-1000498.jpg', show=True)


SA1604, SA1615 do not support the  tag

Consider the following files:
Class.cs:
// <copyright file="Class1.cs" company="PlaceholderCompany">
// Copyright (c) PlaceholderCompany. All rights reserved.
// </copyright>

namespace ClassLibrary3
{
    using System.Threading.Tasks;

    /// <summary>
    /// Sample class.
    /// </summary>
    public class Class1
    {
        /// <include file='Class1.xml' path='/Class1/Foo/*'/>
        public async Task Foo()
        {
            await Task.Delay(0);
        }
    }
}

Class1.xml:
<?xml version="1.0" encoding="utf-8" ?>
<Class1>
  <Foo>
    <summary>
      Sample method.
    </summary>
    <returns>
      A <see cref="Task"/> representing the asynchronous operation.
    </returns>
  </Foo>
</Class1>

The method Foo is documented and the C# compiler correctly generates the documentation for this method.
However, StyleCop reports:
Warning	SA1604	Element documentation must have summary	ClassLibrary3	Class1.cs	15
Warning	SA1615	Element return value must be documented	ClassLibrary3	Class1.cs

Classic StyleCop did support XML <include> statements

Well, I had no trouble reproducing this but I'm having a ton of trouble getting unit tests to work. I'm starting to think the AdhocWorkspace we use doesn't support resolving files specified in documentation comments. :no_mouth:

Special thanks to @daveaglick who unblocked my testing on this!

:thumbsup:


power in units of volts?

https://github.com/catalystneuro/ndx-photometry/blob/8ae8824911829a5fef696f8008fea7b7471bd44b/spec/ndx-photometry.extensions.yaml#L157

@luiztauffer, I also ran into this in my conversion.  Could use some clarification what this is referring to in the context of a time-varying commanded voltage series.

hum, I don't know about that, the MultiCommandedVoltage class is legacy from the original code, I didn't have to use it for the fiber photometry data I've encountered so far...
I'm interested to learn that, @pauladkisson what's the role of this commanded voltage in the experiments you're converting? Why would it be necessary to record the power alongside of its voltage amplitude?
The problem @bendichter is pointing out could be simply a wrong description of units for a power time series, which should be Watts instead of Volts.

@luiztauffer, I got some clarification on that today.  Basically, the commanded voltage time series varies sinusoidally from -1 to 1 for each of 2 LEDs (one blue, one UV).  But, the actual voltage amplitude of each LED is recorded separately in a metadata .json file.  This structure was chosen because it's easier to demodulate the two response signals (blue vs. UV) with the normalized commanded voltages.  I would guess that the original design of MultiCommandedVoltage had similar considerations.


Inconsistent behavior between model.relation.afterAttach and model.relation.afterDetach

Winter CMS Build
1.2
PHP Version
8.1
Database engine
MySQL/MariaDB
Plugins installed
No response
Issue description
Hi,
I noticed a difference in how model.relation.afterAttach and model.relation.afterDetach events behave. It sounds more like a bug than something wanted.
I have a custom trait attached to my model and two listeners: one for afterAttach and another for afterDetach:
trait NotifyChanges
{
	public static function bootNotifyChanges()
	{
		static::extend(function ($model) {

			$model->bindEvent('model.relation.afterAttach', function (string $relationName, array $attachedIdList, array $insertData) use (&$model) {
				traceLog("New relation {$relationName} was created", $attachedIdList);
			});

			$model->bindEvent('model.relation.afterDetach', function (string $relationName, array $detachedIdList) use (&$model) {
				traceLog("Relation {$relationName} was removed", $detachedIdList);
			});

		});
	}
}

In my API I simply do the following:
$task->labels()->sync(array_unique($data['labels'], SORT_NUMERIC));

This is the output:
[2024-06-10 10:44:19] development.INFO: New relation labels was created
[2024-06-10 10:44:19] development.INFO: Array
(
    [0] => 8
)

[2024-06-10 10:44:19] development.INFO: New relation labels was created
[2024-06-10 10:44:19] development.INFO: Array
(
    [0] => 1
)

[2024-06-10 10:44:19] development.INFO: New relation labels was created
[2024-06-10 10:44:19] development.INFO: Array
(
    [0] => 6
)

[2024-06-10 10:44:37] development.INFO: Relation labels was removed
[2024-06-10 10:44:37] development.INFO: Array
(
    [0] => 1
    [1] => 6
    [2] => 8
)

The afterAttach listener is invoked for every new relation; instead, the afterDetach listener is invoked only once and it receives an array of ids as expected. I made some mistake in my configuration or is it a bug? Thank you for your efforts as always.
Steps to replicate

Setup afterAttach and afterDetach listeners.
Use sync method.

Workaround
No response

Forgot to say... labels relation is a morphToMany

This is how Laravel implemented sync(), not a bug.

How can I know which labels have been removed and which added? What I have to do is to notify task assignees that some labels have been removed and some other added. sync() method gives me an array of detached ids via afterDetach but one id at a time for attached ones. Should I collect them? Is there a better way?

How can I determine which labels have been removed and which ones have been added? My task involves notifying task assignees that certain labels have been removed while others have been added. The sync() method provides an array of detached IDs via afterDetach, but it only gives one ID at a time for attached ones. Should I collect them individually, or is there a more efficient method?

Hi there,
I forgot to get back to you. Ultimately, I decided to manually diff the two collections and use attach / detach directly. For anyone who needs this:
$ids = $task->assignees()->pluck('id');
$newIds = collect(array_unique($data['assignees'], SORT_NUMERIC));

if (!empty($toDetach = $ids->diff($newIds)->all())) {
	$task->assignees()->detach($toDetach);
}
if (!empty($toAttach = $newIds->diff($ids)->all())) {
	$task->assignees()->attach($toAttach);
}


[BugFix] Solve R3MTransform init problem

Description
Solves #802

Still unhappy with this.
The lazy init is a nightmare, there's a ton of hidden bugs with it.
What we want to cover:
Some envs return images with dim BWHC. Sometimes, we'd like to process multiple images at the same time.
So what we do is that we allow R3M to cat images along the first dim. We check in the parent env what is the dim of the image: if it is a 3d image, we unsqueeze the first dim to then do the cat operation.
What I think we should cover
We should only cover cases where the input image has size WHC (or BWHC if B is the tensordict batch size).
Then we would simply stack the images along the first dim after the tensordict.ndim.
In all other cases, we should leave the error as it is, or point the user to a solution.


Check for exceptions when updating submodules

This PR fixes an error introduced in https://github.com/jenkinsci/git-client-plugin/pull/348 where exceptions arising in git submodule update commands would be mistakenly suppressed. A test case has been added to verify the new behavior is correct.
Also, another fix is included which provides proper names to the threads in the ExecutorService pool via the NamingThreadFactory class.

ping @darxriggs, @MarkEWaite, @samrocketman, thanks!

Generally looks Ok to me other than the imports.

@MarkEWaite @samrocketman Ok, I've fixed the imports (and also removed an unused import which snuck in there).

@darxriggs Thanks for the review! I've pushed a pair of fixups based on your suggestions.

@darxriggs @MarkEWaite Ok, I've rebased + squashed, since the fixups were getting a bit out of hand. Mind taking a look at the new patch? What else needs to be done for us to be able to merge this patch?

Currently I am bit short of time. But there are still some changes required. I'll keep you posted.

@nre-ableton do you work on the mentioned issues?
I also started some fixes and tests locally. Threading is hard. So it will take some time.

@darxriggs No, I haven't had time to go through your points yet, but I will do so soon. I have a few questions for you as well.

Not setting a value results in a NullPointerException in the git-client-plugin code.

I'm a bit confused here; which value are you referring to?

Manually aborting a job run (threads=1), just interrupts the current submodule update and it goes on with updating the next submodule.
Manually aborting a job run (threads=2) many times until all submodule updates are interrupted, does not abort the job run but runs into the plugin's retry mechanism (enabled by default), starting with a fresh workspace from scratch, updating all submodules.

How can we detect if a job run has been aborted? Will a certain type of exception be thrown that we can expect?

Even if one submodule update fails, all commands are run to the end. This means unneccessary waiting times in case of errors.

True; can fix.

This approach doesn't apply to recursive submodules.

IMHO this is fine, though we should probably document the behavior. However, I'm probably biased towards my specific use-case. In any case, supporting recursive submodules is likely to be a big headache. Are you fine with leaving it as-is and just documenting this behavior as such?

NullPointerException
I updated my comment above. I was referring to the threads value.
As suggested in https://github.com/jenkinsci/git-plugin/pull/612#discussion_r217908351, this should be solved by changing the interface public SubmoduleUpdateCommand threads(Integer threads) to public SubmoduleUpdateCommand threads(int threads) and just using int internally.
aborting jobs
I would expect a java.lang.InterruptedException.
recursive submodules
I had a short look at it. With the current implementation and the feature to provide different credentials for each submodule it is quite hard to implement parallelity for recursive submodules.
So properly documenting the feature scope/resctriction is be fine.

@darxriggs Thanks for your patch! I had a look at that commit on your branch and will cherry-pick it to this branch (and also rebase, while I'm at it).

Please test it thoroughly.
It is still WIP - one of the unit tests is still a blinker, the commit comment is not finished, ...

@darxriggs Will do -- I have no problem cleaning up the commit message nor testing the patch. However, I'm unclear on which test is unstable. Is it in GitCommandsLauncherTest? I ran that class in IntelliJ with the "repeat until failure" mode and let it fly for several minutes and didn't get a single failure. Which test did you mean?

This test (https://github.com/darxriggs/git-client-plugin/commit/9363f4dd0288355bc59a8893aeede84c370b626d#diff-f109f6ec426f8eedea9f0ee47ca8a0f1R102) was failing a lot of times.
I now updated my commit:

performed small changes
fixed the blinker test
add more tests
updated the commit comment

I also created a repository (https://github.com/darxriggs/repo_with_submodules) with some big random binary files, so fetching takes some time. Have a look at the branches "3-submodules" and "invalid-url". With this repository all testcases mentioned above can be performed.
From time to time (5-10% of manual tests) I see a git process still running after former git process failed, the job run into a timeout or was canceled by the user. This is still an issue and I don't understand it yet.

@MarkEWaite @darxriggs Sorry for the radio silence on my end -- I've been quite busy with other work and haven't had time to test these changes properly. Even so, I don't think that I'm familiar enough with the codebase to confidently say that my efforts in that regard would be dependable.
I'm really not sure how we can proceed and get this patch merged. Would @darxriggs be interested in "adopting" this PR by cherry-picking/rebasing the patches into his branch and submitting it? Or should I rather rebase from that branch and force push here?
Either way, I'm unsure of how to proceed. Where do we go from here?

I think you should integrate the changes from @darxriggs into your branch so that the pull request can be evaluated further by others.  I'd really like to include this change in the git client plugin 3.0 plugin that I want to deliver before end of December 2018.
I have some testing ideas and testing infrastructure that I can use for further evaluation.  If that testing shows the same types of issues that @darxriggs detected, it may also provide some hints of things that should be investigated further.

@MarkEWaite @darxriggs Ok, I've rebased this branch on master, and also squashed and reordered the commits. The HEAD commit basically replaces my previous commits in this branch, so I squashed them together. Hopefully the diff came out correctly.

@darxriggs that's perfectly understandable. Thanks so much for all of your help and time on this issue!


Should we publish a separate module (gem) for each Google Cloud service?

This is the gcloud-ruby specific discussion of the broader conversation in gcloud-common, #30, Should separate APIs be separately installable?. See also @jgeewax's comment in gcloud-node #91.

This has been discussed before and the current monolithic direction was chosen.
My opinion is that they should be separate. We can manage versions independently, and release hotfixes for one service gem without requiring the other service gems to be updated. I think we should follow what rspec does and have the main gcloud gem have dependencies on all the service gems. And we should have a gcloud-core gem that contains shared infrastructure like Error and Backoff.
gcloud -> gcloud-datastore, gcloud-storage, gcloud-pubsub
gcloud-datastore -> gcloud-core, beefcake (protobuf lib)
gcloud-storage -> gcloud-core
gcloud-pubsub -> gcloud-core
The current behavior would remain, you require gcloud and you get all the services available. But, if you wanted to only use Storage you could depend on gcloud-storage and require gcloud/storage and only have that code. The caveat for this is that right now the unused services aren't loaded and memory isn't used, but the dependencies may be loaded if you are using Bundler and configured it to load everything. This approach would also make development and documentation more difficult since it would span several projects.


Add a creative commons 4.0 license

It was pointed out by #109 that we are currently missing a license for the content in this repo. This was a simple oversight that happened during the initial creation of the repo, and it has flown under the radar until now.
The absence of a license was never intentional, but after so many contributions have already happened, it would be inappropriate to unilaterally add a license without the consent of prior contributors. After some internal discussions we concluded that CC-BY-4.0 is the right license for the repo, so now we're seeking consent on that from everyone who has contributed.
I'm tagging everyone who has made a substantial contribution (excluding non-content contributions like grammatical fixes). If every substantial contributor gives explicit consent, we'll merge immediately. Otherwise we will wait until 23 August 2024 to see if any past contributor raises an objection. If we receive no objections by EOD anywhere in the world of that date, then we will assume consent. This is a reasonable assumption since all other documentation repos by OSRF are also licensed under CC-BY-4.0, and all contributors knew that they were contributing to an OSRF project.
If you are tagged below, kindly indicate consent by commenting with a :+1: or leave a comment objecting along with the rationale for your objection.
@mdfesto
@Yadunund
@codebot
@aaronchongth
@thedevmanek
@kscottz
@gbiggs
@xiyuoh
@youliangtan
@maryaB-osr
@marcoag

👍👍 🐀


Add iothub-explorer reference in iothub-security-devguide

The iothub-security-devguide only references the .NET based tool DeviceExplorer. It's worth pointing out that iothub-explorer, which is cross-platform also allows generating SAS tokens for devices.

Hi @pierreca, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Pierre Cauchois). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@dominicbetts Hi Dominic Please review this contribution. Thanks.

@pierreca - thanks for the suggestion.
#sign-off


Update README.md

Since janet-set is in pkgs, you can install it using its unadorned/short name.

Thanks @uvtc !


tidb_query_expr: fix round function with real type

What is changed and how it works?

Issue Number: Close https://github.com/tikv/tikv/issues/18010

What's Changed: Follow https://dev.mysql.com/doc/refman/5.7/en/precision-math-rounding.html, let round function works like MySQL.
Related changes

[ ] PR to update pingcap/docs/pingcap/docs-cn:
[ ] Need to cherry-pick to the release branch

Check List
Tests

[x] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Release note

fix round function works with real type to make it behave more like MySQL and TiDB.

/needs-linked-issue

/ok-to-test

/cc @wshwsh12 @MyonKeminta PTAL

/retest

/test pull-unit-test


Compound component (e.g., Form.Group, SearchField.Advanced) exports include entire module in Webpack bundles

Hello team, making some investigation I found that some of your imports bundles the entire lib, and the tree shacking is not working. Here's an example of search vs container.
|Search field:

Container:

I already validated this with @adamstankiewicz, so please let me know if there's anything I can do in order to help with this issue.

Thanks for the report of this issue, @ochavarria2u!
We'll need to decide what we want to do to mitigate these bundle size impacts across Paragon's consuming repos in a reasonable way. For example, is there any workaround to keep compound components (Form.Group) still functional with tree shaking? Do we have standalone components exported for all compound components that be migrated over to? Is there a CLI tool we could expose to consumers to auto-migrate compound components to their associated standalone components (e.g., Form.Group -> FormGroup)?

Hey, @ochavarria2u, thanks for reporting this!
The root problem was that our icons package did not support tree-shaking at all, which resulted in all of the icons being included into the initial bundle if your code used at least one of the icons. That's what happened in your first example - SearchField uses couple of icons internally which led to including all of the icons into the initial bundle. Container on the other hand does not use any icons, so only this component got into the bundle.
Note however that this only caused size problems for the initial bundle size (Stat size on the screenshots), but after minification process all of the redundant icons were removed and did not get into the final bundle provided you built your project with the help of frontend-build (you can see it by the Parsed size and Gzipped size). You can read more on how that happened in the comments to the PR that adds tree-shaking to icons package. The fix was released in v20.45.2 of Paragon and it should drastically reduce Stat size of you bundles.
I'm not sure why your first example reports 0B for parsed and gzipped sizes though, I believe that means that none of paragon code got into the final bundle, which is really strange. When I tried to reproduce your example this is what I got

Could you maybe provide a bit more context on the first example, e.g. how did you use TestParagonLib component in the code and what script you used to build the application?

Hi @viktorrusakov thanks for the fix, I've been fetching the reports and it seems that the bundle size got reduced by 150mb. Checking our reports it seems that the parsed size and gzipped size is still 0. I belief this is the reason why.

I'm seeing that some of the parents aren't supporting treeshake so we can only do compound components, do you have plans on doing it ? Here's some componenets I've identify that could use the change.
import { SearchField } from '@edx/paragon';
import { Form } from '@edx/paragon';
import { Collapsible } from '@edx/paragon'; // Needs to implement treeshake
import { Dropdown } from '@edx/paragon'; // Needs to implement treeshake
import { ModalDialog } from '@edx/paragon'; // Needs to implement treeshake
import { Card } from '@edx/paragon'; // Needs to implement treeshake
FYI - Here's how we use the reports:
    ...(process.env.BUNDLE_REPORT ? [       {         resolve: 'gatsby-plugin-webpack-bundle-analyser-v2',         options: {           devMode: true,           analyzerMode: 'static',           openAnalyzer: true,         },       },       'gatsby-plugin-perf-budgets',     ] : []),

@ochavarria2u I don't think these component would affect the bundle very much as they only include related compound components (which shouldn't take too much space) into the bundle and not the whole Paragon. However, I understand that's it is still an issue and we do plan to fix them.
I've created a separate issue #2464 to track progress on migrating off of compound components in Paragon. I'm pretty sure there is no way to support tree-shaking for them, so we just have to remove them and instead only use standalone components. I'm not sure when this will be done though, I'd like @adamstankiewicz input here on prioritization.

@ochavarria2u @viktorrusakov I agree, it appears that compound components (e.g., Form.Group, SearchField.Advanced) can not support tree-shaking, unfortunately. Thanks Viktor for filing #2464.
I think the first step here should be to evaluate whether all Paragon's compound components have an associated standalone component export (e.g., If we have Form.Group, FormGroup should also be exported. Assuming we do export all compound components as standalone components today, @ochavarria2u you should be able to migrate off the compound components in your repo to mitigate the tree shaking concern. Though as Viktor mentioned, these components shouldn't really take up too, too much space although we should still definitely optimize it.
Then, tackling what's proposed in #2464 makes sense. We should definitely deprecate the compound components (perhaps even with a legit DEPR ticket, which I'd be happy to file) first with adequate warning for consumers. @viktorrusakov I'll add some thoughts to this effect to #2464.
tl;dr; For the purpose of this issue, we should confirm that all compound components do indeed have an associated standalone components exported already to ensure consumers have a path forward today to mitigate these concerns, and perhaps update the Paragon README about tree shaking to mention lack of support for it with compound components: https://github.com/openedx/paragon#treeshaking

Moving conversation to #2464


Enhance req.acceptsCharsets method 5.x

I had a discusion with @wesleytodd and learned about the plan of landing this or similar ones like #5870, #5871, and #5872.
Right now the team is more focused on releasing version 5. Please do not feel left out if it takes some time, thank you for being an awesome contributor 🎉


As an employee that is working for an organisation that requires reporting on population information I want to create a report for all the population of people, people living in cities and people not living in cities in each continent

SQL Statement:
SELECT allpops.Country_Continent, allpops.Country_Population, allpops.City_Population, (allpops.Country_Population - allpops.City_Population) AS Non_City_Population
FROM (
SELECT country.Continent AS Country_Continent, country.Population AS Country_Population, SUM(city.population) AS City_Population
FROM country.Region, country JOIN city ON country.Code == city.CountryCode
GROUP BY Country_Continent
) AS allpops
GROUP BY allpops.Country_Continent, allpops.Population


Add koa example

Create an example for using Koa.js that demonstrates:

Connecting to Db2 for i
Authenticating with IBM i credentials
Using a router

Signed-off-by: Mark Irish<EMAIL_ADDRESS>

Not quire ready for primetime yet. Need to update the README and also add more code comments throughout to explain whats going on. But the example is working out of the box on IBM i.

Looks good, based on somewhat-blind assumptions that Passport will handle the pool objects appropriately. Thanks!


Resolve syncing conflicts from repo_sync_working_branch to live

Pull request opened by Docs to resolve syncing conflicts from repo_sync_working_branch to live.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@LanaChin PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

Hi @Manuela - This is  a merge from the live branch that the PubOps team handles.  FYI @traya1.


Env seems to be lost

Reported on Zulip: https://zulip.lurk-lab.com/#narrow/stream/17-lurk/topic/Cannot.20access.20env.20after.20eval/near/113458
This works:
(let (
    (env (let  ((f (lambda (x) x))) (current-env)))
    (apply1 (lambda (fn arg) (fn arg)))
    (apply (lambda (expr) (apply1 (eval (car expr) env) (cdr expr)))))
  (apply '(f 1)))

But this doesn't
(let (
    (env (let  ((f (lambda (x) x))) (current-env)))
    (apply (lambda (expr) ((eval (car expr) env) (cdr expr)))))
  (apply '(f 1)))

But apparently both should work

This reproduces in LEM so it's effectively a bug in the CEK machine itself


[Cls] Support different compression schemes for sending back data from CLS

Seems like LZ4 is the best.


Move chai and mocha to dev dependencies

chai and mocha are used in tests so they shouldn't be part of dependencies

Thank you for your PR. Mocha and chai are no dev dependencies, we use them during postinstall to do a sanity check on the downloaded public suffix list. See https://github.com/peerigon/parse-domain/issues/43


Azure OpenAI example uses OpenAI APIs

The notebook example for Azure Open AI (https://github.com/microsoft/generative-ai-for-beginners/blob/main/07-building-chat-applications/notebook-azure-openai.ipynb) is using OpenAI APIs and does not seem to demonstrate how to use it with Azure Open AI Service as the title mentions.
So this would need to get updated to either change the title to say "OpenAI" only, or update the code examples to match Azure Open AI Service

fix https://github.com/microsoft/generative-ai-for-beginners/pull/72 @koreyspace


Upgrade to latest google-apitools.

I had to specify the precise version of oauth2client as well; if I
don't, tox will install a version google-apitools isn't compatible
with. Not sure why that happens.
Resolves #21.

Codecov Report

Merging #37 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #37   +/-   ##
=======================================
  Coverage   93.16%   93.16%
=======================================
  Files          56       56
  Lines        3056     3056
=======================================
  Hits         2847     2847
  Misses        209      209

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b56f78c...5eb952f. Read the comment docs.


Microsoft 365 Apps Usage Report - Web Column (formerly Active on Web) is always No

It's unclear where one can report an issue with the actual Office 365 Admin Portal Usage Reports but I am hoping this will get the attention of the appropriate team.
Since late June 2020, potentially linked to when the activity values were changed from True/False to Yes/No, the Web column (formerly Is Active on Web) is always "No" for every user for every Office 365 Tenant regardless of their actual usage.  I believe this is an issue affecting every tenant's Microsoft 365 Apps Usage Reports and is not limited to the Tenants I have seen.
Here is a link to the actual usage report:
https://admin.microsoft.com/AdminPortal/Home#/reportsUsage/ProPlusUsage

@bt101 Thank you for your feedback. I'm assuming this is more related to the document https://docs.microsoft.com/en-us/microsoft-365/admin/activity-reports/microsoft365-apps-usage?view=o365-worldwide . I'll test the report and make changes to the document if need be.
Thanks
Sri

@bt101 Thank you for your feedback. I tested this on multiple tenants and found the same issue. Since this is a product bug and nothing needs to be changed on the document, I'd recommend you to contact support and pass the feedback.  You can open a support ticket from the need help section on the M365  admin center.
@yogkumgit This seems to be a product bug as per testing and no changes required in the document as of now. Please close this issue.
Thanks
Sri

@msbemba Thank you very much for the contribution and sharing this explanation. @bt101 Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

@yobougaz Thank you for confirming it's a product bug.  Given that you are a member of Microsoft and that this is a Microsoft Product bug I'm a bit surprised that you closed the issue and asked me to open an issue with the product team. Given you write the documents to support the product I would expect you would have a close relationship with the team and have an ability to pass the issue to the appropriate team including your findings.

@bt101
Hello bt101,
I apologize but I am not following you, was your message supposed to go to me or @yogkumgit ?
Thank you 😊


using esbuild with injectDevServer for @cypress/react component testing

if i run cypress open-ct it crashes
To run component-testing, cypress needs the dev-server:start event.

Please implement it by adding this code to your pluginsFile.

// /Users/me/dev/testcase/cypress/plugins/index.js
module.exports = (on, config) => {
  on('dev-server:start', () => startDevServer(...)
}

this is how my plugin index looks for now
/// <reference types="cypress" />

const createBundler = require('@bahmutov/cypress-esbuild-preprocessor')
const path = require('path');

/**
 * @type {Cypress.PluginConfig}
 */
module.exports = (on, config) => {
    const bundler = createBundler({
        // any ESBuild options here
        // https://esbuild.github.io/api/
        esbuildOptions: {
            resolveExtensions: ['.js', '.jsx', '.ts', '.tsx', '.css'],
            define: {'process.env.NODE_ENV': '"development"'},
        },
    })
    on('file:preprocessor', bundler)
    return config
}

any ideas how to use esbuild with the component testing?

i see i need something that doesnt exist yet like esbuild-dev-server

@bahmutov any ideas on a work around or something not having to install vite or webpack dev server?


Testing PSI selection

Description
Write tests for PSI selection (classes and method). Verify that only the classes that are supposed to be selected are selected, and only the methods that are supposed to be selected are selected.
Note: This issue is optional for this sprint. It might be moved into the next sprint if it is not done during this sprint
Definition of Done

[ ]  Class selection is tested
[ ]  Only the allowed classes are selected
[ ]  Method selection is tested
[ ]  Only the allowed methods are selected

Moving to Sprint 4


feat(peer): enable empty env variable

Type of change

Improvement (improvement to code, performance, etc)

Description
Enable empty value to be set for environment variable, and not have it overwrite it with a default value.

Additional details

Pulled the viper configuration into a utility function
Added a viper configuration to allow empty env variables
Added a test that verifies empty env variables to take precedence over defaults

Related issues
None

Resolves #4076

Thank you for the contribution.
A few things that need to be resolved:

Please add a PR Description
The Basic Checks failed because "goimports -l -w" needs to be run against the test file.
The DCO check failed because you need to sign the commit, see https://github.com/hyperledger/fabric/pull/4309/checks?check_run_id=14869644772

Please amend and re-push.

@denyeart
Hi, I resolved your review comments.
Would it be possible for you to review the PR?


RestController Documentation

I believe the Example of an RestController in the README File contains a wrong annotation.
What it says:
@GetMapping
    public String feature(@RequestMapping @Context(name = "name") final String name) {
        return featureDemoService.getDemoString(name);
    }

What it should say:
@GetMapping
    public String feature(@RequestParam @Context(name = "name") final String name) {
        return featureDemoService.getDemoString(name);
    }

Thank you for raising and fixing this @malte-baumann! Your PR has been approved, feel free to merge!

Thank you @malte-baumann, we merged your PR and are closing this issue!


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-k8s-25-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 2218

Questions ?
Please refer to the Backport tool documentation


Add DocumentSnapshot.data(as:with:decoder:)

This adds support for specifying alternative server timestamp behaviors when decoding snapshots.
Fixes #6328.

@ryanwilson Consider this PR a proposal. Note what usage looks like in the tests. I'm not particularly happy with the way data(as:with:decoder:) reads and am open to suggestions.
What I have is:
try snapshot.data(as: Model.self, with: .estimate)  // Or `.none` or `.previous`

It might be better to do something like this:
try snapshot.data(as: Model.self, serverTimestamps: .estimate)

@ryanwilson Consider this PR a proposal. Note what usage looks like in the tests. I'm not particularly happy with the way data(as:with:decoder:) reads and am open to suggestions.
What I have is:
try snapshot.data(as: Model.self, with: .estimate)  // Or `.none` or `.previous`

It might be better to do something like this:
try snapshot.data(as: Model.self, serverTimestamps: .estimate)

I agree - I don't think the standalone with: reads super well. I think serverTimestamps: is a reasonable tradeoff of readability and verbosity (instead of using the full serverTimestampsBehavio(u)r).
Would you want to make the change in the base SDK as well at next breaking change?


Update operator manifest for v0.3.0

@nwneisen

Is this all generated code?

Yes, there is a make target to generate this in boundless-operator repo.

Can we create a ticket to summarize what is done here so that it can be added to the release CI

Created this ticket: https://mirantis.jira.com/browse/BOP-318


Fix #1137, exclude system databases

The databses "mysql", "sys", "information_schema", "INFORMATION_SCHEMA", "performance_schema" and "PERFORMANCE_SCHEMA" are excluded for SSM metastore.

And every time you want to create a pull request, please checkout a new branch from the latest trunk to avoid the duplicated commit history.

LGTM +1


Link ghost tables on import API run

Non unlinked tables have become a big problem with programmatic imports.  It shouldn't add any appreciable overhead to link ghost tables after an import API run, instead of just when the dashboard is loaded.
@gfiorav

@gfiorav @juanignaciosl is this issue still happening?

This ~"issue"~ is still happening, because Import API is not related at all with ghost tables. It's not a matter of performance, it's just that we shouldn't do it. Import API links imported tables, and shouldn't worry about other existing tables.
We could consider a programmatic way to trigger ghost tables, but importing any dataset shouldn't have this effect.


failed with exit status 0xffffffff

Hello.
I ran Limelighter and got the following error
cmd.Run() failed with exit status 0xffffffff

I would appreciate it if you know the solution.

Not sure if this was correct at the time, but I've encountered the same error which was not caused by the resolving the domain.
Instead, it was caused but a failure to complete the SignExecutable function.

Again, not sure if this is relevant but it is currently an issue I'm facing which doesn't seem to have any relation to resolving the domain.


Helpp Speaker Labeling is not consistent

When i try in the demo transcribing audio to text is so accurate this is the output in the demo
Speaker 0:
Hello.
Speaker 1:
Hi is this Tina.
Speaker 0:
Yes it is who is this.
this is my output
Speaker 0:
Hello.
Speaker 1:
Hi is this Tina.
Speaker 0:
Yes it is this this
this is my set up in recognize
private RecognizeOptions getRecognizeOptions(InputStream captureStream) {
return new RecognizeOptions.Builder()
.audio(captureStream)
.contentType(HttpMediaType.AUDIO_MP3)
.model("en-US_NarrowbandModel")
.interimResults(true)
.inactivityTimeout(-1)
.timestamps(true)
.speakerLabels(true)
.smartFormatting(true)
.build();
}
when i trying to change the model into a en-US_Broadband this the output
Speaker 0:
Hello.
Speaker 1:
Hi is this Tina. Yes it is who is this
The diferrence is the word Yes it is who is this is a different speaker so the expected result will be this
Speaker 0:
Hello.
Speaker 1:
Hi is this Tina.
Speaker 0:
Yes it is who is this.
please help is this bug or there is something error on my code by the way i am using mp3 file not wav file

please help me

need help sir

This is not an issue with the Android SDK. If you're confused about getting the most out of the Speech to Text service, please consult the documentation: https://cloud.ibm.com/docs/services/speech-to-text


[remote-component] remove MoreVert icon

Signed-off-by: Abhishek Kumar<EMAIL_ADDRESS>Description
This PR fixes #
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

@Abhishek-kumar09 @Chadha93 If this asset isn't added here, then where is it added?

Ok, I see now...


fix(runfiles): @bazel/runfiles usage with non-bzlmod repos

When in non-bzlmod and no _repo_mapping file exists the logic repo mapping logic should have no side-effects and should take the same code path as before https://github.com/bazel-contrib/rules_nodejs/commit/21b56da9f20c9c5e8b8c1ac19052f1f7cc7b5920

There still seem to be issues and differences with non-bzlmod in bazel 6 vs 7.
In bazel 7 the _repo_mapping seems to exist with non-bzlmod, but the mappings are essentially no-ops. While in bazel 6 the _repo_mapping does not exist at all. I can't get bazel 6 or 7 working properly with non-bzlmod in the rules_js e2e/runfiles tests.
But I believe @jfirebaugh reports this fix is working so I think it is good to land for now...


tailscale: create reusable acceptance testing facility

Use this facility for webhooks acceptance test as a demonstration.
Updates #cleanup

I verified that the acceptance test passes in CI. I also temporarily broke one of the conditions in the acceptance test and verified that it failed in CI.

Closing in favor of https://github.com/tailscale/terraform-provider-tailscale/pull/398


fix(migrations): Refactoring migrations to be idempotent and our handling of trasactions

To test this:

docker-compose down -v
docker-compose up -d
go test ./... -postgres-url postgres://postgres:password@localhost:5432 -v
then delete registry of migrations from v9 to v6  and rerun ./... -postgres-url postgres://postgres:password@localhost:5432 -v

Codecov Report

Merging #38 (8490c23) into main (b0cfaab) will increase coverage by 1.01%.
The diff coverage is n/a.

:exclamation: Current head 8490c23 differs from pull request most recent head 40e9b66. Consider uploading reports for the commit 40e9b66 to get more accurate results

@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
+ Coverage   63.32%   64.34%   +1.01%
==========================================
  Files          11       11
  Lines         589      589
==========================================
+ Hits          373      379       +6
+ Misses        169      165       -4
+ Partials       47       45       -2

Impacted Files
Coverage Δ

keepalive.go
69.23% <0.00%> (+23.07%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Feature Proposal: Load Data Preview when the button is clicked instead of page load

Expected Behavior or Use Case
As discussed here, there seems to be a collective interest on changing when the Data Preview request is done on the frontend. The proposal is to trigger the Data Preview request only when the button is clicked, instead of page mount so that the compute resources are used more efficiently and potentially some cloud cost is saved.
Service or Ingestion ETL
Frontend
Possible Implementation
React code will need to be updated to trigger Data Preview request only on button click instead of page mount
Example Screenshots (if appropriate):
N/A
Context
The reason for this proposal is since the Data Preview request can be compute-intensive depending on the backend, it is more efficient to load it only when it is needed, instead of loading every time a table detail page is visited. This can potentially save some cloud cost for the hosts as well.

Let's make this configurable though, so people that always want it don't have to wait extra.


Tank Web Application

Description
A new example which runs on the web created with Plotly Dash. Calculates a circular tank and returns the maximum stress.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

How Has This Been Tested?

[ ] Unit Tests
[x] Attached examples

Test Configuration:

RFEM / RSTAB version: 6.02.0034
Python version: 3.9

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Files: export.vtk and export.obj and forder: export should be excluded from git versioning in .gitignore.

With latest commit:

Check for external libraries
Auto clicked web browser
New styling items

has added.
Script only works with python version <3.10. We're still waiting dash library to create new release for 3.11.


Is this project still active

Is this project still active?

It seems it's not.

It seems it's not. @aqrln Alexey could you please comment on this: is this project abandoned or it's just works fine despite the WIP warnings on the README.md 😃

I tried to run cargo build --release with Cargo 1.41 and it didn't produce example.node, only napi_example.lib and napi_derive.dll etc.

@anurbol

So it seems that one shoudn't use this crate in commercial production, or could they?

I'd recommend against that, right.

I tried to run cargo build --release with Cargo 1.41 and it didn't produce example.node, only napi_example.lib and napi_derive.dll etc.

Yeah, you need to run npm run build inside the example directory to build the actual Node.js addon.

@aqrln I'm working on a new napi & rust project: https://github.com/Brooooooklyn/napi-rs
And it seems napi-derive crate name was taken by you..
Could you please transfer this crate name(napi-derive) to me if you don't want maintain this project anymore?

@Brooooooklyn yeah sure, your project looks awesome, and I don't even need that name anymore because if I were to continue working on this project, it would be called napi-codegen like in this demo.

My napi-derive implementation is similar with napi-codegen 😄
#[macro_use]
extern crate napi_rs_derive;

use napi_rs::{Result, Value, CallContext, Number};
use std::convert::TryInto;

#[js_function(1)]
fn fibonacci<'env>(ctx: CallContext<'env>) -> Result<Value<'env, Number>> {
  let n = ctx.get::<Number>(0)?.try_into()?;
  ctx.env.create_int64(fibonacci_native(n))
}

#[inline]
fn fibonacci_native(n: i64) -> i64 {
  match n {
    1 | 2 => 1,
    _ => fibonacci_native(n - 1) + fibonacci_native(n - 2)
  }
}

Cool! In my implementation the boilerplate for retrieving arguments from context is generated automatically too:
#[napi::callback(fibonacci_js)]
fn fibonacci(env: Env, n: Number) -> Result<Number> {
    Number::from_i64(env, fibonacci_native(n.to_i64()?))
}

Would you want to add something similar or there are some drawbacks I didn't account for?

Would you want to add something similar or there are some drawbacks I didn't account for?

How do you get this object from call object in your implementation?
My version is not simpler enough for now, I will make them easier to use in next version. Now I'm focusing developing ecosystem around my napi-rs: https://github.com/Brooooooklyn/node-rs

@Brooooooklyn

How do you get this object from call object in your implementation?

I guess it could be a parameter of special type?

Now I'm focusing developing ecosystem around my napi-rs

That looks very cool!


iOS rotation device

Hello!
This project is amazing, very customizable! I have a question about rotation.
When the device is rotated the UIActionSheet does not update. There is a way, is it a bug or a feature not yet implemented?
Thanks

Hi,
AHKActionSheet was created when iOS 7 was the newest available version. It mimicked the behavior of UIActionSheet at that time. Not supporting rotation was a feature then, but can be considered a bug now.
I'm not actively developing this library, if you want to add this feature, please feel welcome to! 😃

Thank you for your answer! I would like to help but do not know where to start! If you have time one day it would be great because your project is really cool!


Fix typespec for Session struct

I just ran the tests and session.id is a uuid string, not an integer. Here is a sample session struct I received when running the test suite.
%Wallaby.Session{id: "9ae736b0-1958-11e7-9573-6f21b8c89bef", screenshots: [],
  server: #PID<0.228.0>,
  session_url: "http://localhost:59483/session/9ae736b0-1958-11e7-9573-6f21b8c89bef",
  url: "http://localhost:59483/session/9ae736b0-1958-11e7-9573-6f21b8c89bef"}}

:tada:


refactor: apply lf on checkout

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Codecov Report

Merging #328 (3e06bb9) into master (05a9edf) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #328   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           76        76
  Lines         2644      2644
  Branches       457       457
=========================================
  Hits          2644      2644

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05a9edf...3e06bb9. Read the comment docs.


Add: bsztw-riesa

The BSZ-TW Riesa is a vocational school for technology and economics with a vocational high school.
Official website: https://www.bsztw-riesa.de/
Thanks for your help

@CsharpLassi Please provide us with a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.

Thanks for the comment.
Lernsax is an online platform for schools in Saxony/Germany.
https://www.lernsax.de/wws/9.php#/wws/101505.php?sid=28649802758737435960061766176820S83c1dc29
E-Mail-List with students and teachers:

@CsharpLassi Thank you for the clarification. Pull request merged.


Align VS Code process editor with improved structure

Adapt to new structure with ivy-tool-bar being outside of diagram
Read HTML file from source and adapt instead of re-creating it
Slightly improve editor worker location handling in webview

@ivy-lli With this PR the VS Code extension also makes sure that it uses the new structure for adapted UI extensions.


switch to fargate usage

To make things easier, the ECS services could move to fargate. This would remove the need for an explicit EC2 instance in the end and also it probably allows for easier auto-scaling of the shell server successor.

terraform module which can be used: https://github.com/wellcomecollection/terraform-aws-ecs-service

this is now being done in #311 as well


Switch type devices not parsing

Checklist

[ X] I have read the common issues wiki page
[ X] I have checked to make sure the plugin is up to date

Describe the bug
For switch type devices, a parsing error is happening and device is not available.
Same configuration using the deprecated homebridge-tuya-switch that was merged into this project works fine.
To Reproduce
Add any switch type device into homebridge-tuya.
{
"type": "Switch",
"name": "Lower Stairs Switch",
"id": "",
"key": "",
"switchCount": "2"
}
Expected behavior
Device is available at homekit app.
Error message:
[04/01/2023, 10:35:01] [TuyaLan] Discovered Upper Stairs Switch<PHONE_NUMBER>000) identified as Switch (3.3)
[Tuya] Changing ping gap for Upper Stairs Switch to 9s
[TuyaDiscovery] Failed to parse discovery response on port 6667: {"ip":"<IP_ADDRESS>","gwId":"0000000000000","active":2,"ablilty":0,"encrypt":true,"productKey":"000000000000","version":"3.3"}
[TuyaDiscovery] Failed to parse discovery raw message on port 6667: 000055aa00000000000000130000009c0000000058e467256fac78567b1684089fe6e3ad0f391faedd696ee887c29235c38177acddf4a2ae9ca0e2cf50f15eddc4495330db51460a5c11f93f1668baae19fae8817256f992ef0bb3c9946f6ca8e2e148532e0dbc9a92c3317286ebf238be579786549444277ab50453c95f3f91893206fd666d4bf5f941e5454d81cf9cb714dfe77a23e3b2249f5adf48a714f851aaf43984590ede0000aa55

I have that same issue

put Tuya in manufacturer field fixed it for me


normalise - adds commands to pick correct PAR and colour metadata for…

… blackmagic media express captures
Along with this commit:
https://github.com/kieranjol/IFIscripts/commit/cd383089a42b2f9144bfbe6e1e9d1557e2a1610a
This will force the aspect ratio of 4:3 via the PAR of 1.067.
The function in ififuncs checks to see if there is a clap atom containing 702 width, 703 height and a PAR of 1.093.
Without the corrections in normalise.py to account for this, you will end up with a Display Aspect Ratio of about 1.37 instead of 1.33. i also specified the correct colour metadata values as well.
I tested this with a file from Blackmagic Media Express and the correct command line was produced, which also thankfully passed the Specialist AV mediaconch policy.
'-c:v', 'ffv1', '-g', '1', '-level', '3', '-c:a', 'copy', '-map', '0', '-dn', '-report', '-slicecrc', '1', '-slices', '16', '-vf', 'setdar=4/3', '-color_primaries', 'bt470bg', '-color_trc', 'bt709', '-colorspace', 'bt470bg',
I also tried with a FCP type file to make sure that check_for_fcp still works - and it does.
AAAnd i tried it with a regular old file that does not have any of these fancy pieces of metadata and it proceeded as expected.
So I think this is good to merge.

We have yet to have any files that are 16:9, so this will probably be problematic in that instance, but due to the presence of the clap width values, there would probably be a PAR that would produce a DAR that was > 16:9 anyhow, so further compensation would be needed regardless.


Pow

hey @asutula is there something simple blocking here?

we need to do a draft release so staging is usable, wondering if we add this in


Experimental Checker for input variables analysis question.

Hi,  My name is Rui Ferreira and I'm a master's student at Instituto Superior Técnico (Lisbon).
As part of my master's thesis I've been studying the idea of creating a checker with Infer to detect and signal potential unused input data, in programs written in Java.
The approach would be similar to Lyra, created by Catherine Urban (for applications written in Python) (https://caterinaurban.github.io/pdf/esop2018.pdf). This approach tracks and classifies variables as {Used, Not Used, Bellow, Overwritten}, based on the relation between them, and is a backwards analysis.
I've been told the implementation may not be possible because Lyra uses a relational domain (the classification of a variable depends on its interaction with other variables). Would that be an actual problem to the implementation?
Are there any other obstacles to such implementation?
I'm sorry if this is a very complex question, but I've been struggling to answer them in the last few months. Any input on the matter would be highly appreciated.
Best Regards,
Rui Ferreira

Hi Rui, infer doesn't put any constraint on your abstract domain, it can be whatever you want. We have many relational domains in infer already. Without looking at the analysis in details it's difficult for me to give more guidance. If you are looking for resources to get started writing checkers in infer please check out the labs: https://github.com/facebook/infer/blob/master/infer/src/labs/README.md

Thanks a lot!


TypeError on dev/generate

Version
v2.4.5
Reproduction link
https://github.com/Berkmann18/nuxty
Steps to reproduce

Follow this tutorial (up to the point where you run npm run generate or npm run dev).
See the output on the CLI.

What is expected ?
No errors.
What is actually happening?
%cError background: red; color: white; padding: 2px 4px; border-radius: 3px; font-weight: bold; Network error: Response not successful: Received status code 401
/mnt/c/Users/max/Projects/nuxty/node_modules/zen-observable/lib/Observable.js:63
     throw e;
     ^
TypeError: Cannot read property 'delete' of undefined
    at /mnt/c/Users/max/Projects/nuxty/node_modules/apollo-link-dedup/lib/dedupLink.js:48:47
    at cleanupSubscription (/mnt/c/Users/max/Projects/nuxty/node_modules/zen-observable/lib/Observable.js:90:7)
    at notifySubscription (/mnt/c/Users/max/Projects/nuxty/node_modules/zen-observable/lib/Observable.js:145:41)
    at onNotify (/mnt/c/Users/max/Projects/nuxty/node_modules/zen-observable/lib/Observable.js:165:3)
    at SubscriptionObserver.error (/mnt/c/Users/max/Projects/nuxty/node_modules/zen-observable/lib/Observable.js:224:7)
    at /mnt/c/Users/max/Projects/nuxty/node_modules/apollo-link-dedup/lib/dedupLink.js:42:81
    at Set.forEach (<anonymous>)
    at Object.error (/mnt/c/Users/max/Projects/nuxty/node_modules/apollo-link-dedup/lib/dedupLink.js:42:45)
    at notifySubscription (/mnt/c/Users/max/Projects/nuxty/node_modules/zen-observable/lib/Observable.js:134:18)
    at onNotify (/mnt/c/Users/max/Projects/nuxty/node_modules/zen-observable/lib/Observable.js:165:3)
    at SubscriptionObserver.error (/mnt/c/Users/max/Projects/nuxty/node_modules/zen-observable/lib/Observable.js:224:7)
    at notifySubscription (/mnt/c/Users/max/Projects/nuxty/node_modules/zen-observable/lib/Observable.js:134:18)
    at onNotify (/mnt/c/Users/max/Projects/nuxty/node_modules/zen-observable/lib/Observable.js:165:3)
    at SubscriptionObserver.error (/mnt/c/Users/max/Projects/nuxty/node_modules/zen-observable/lib/Observable.js:224:7)
    at /mnt/c/Users/max/Projects/nuxty/node_modules/apollo-upload-client/lib/index.js:104:20
    at process.internalTickCallback (internal/process/next_tick.js:77:7)

This bug report is available on Nuxt community (#c8831)

Please open a bug report at https://github.com/nuxt-community/apollo-module :relaxed:

Done. cf. https://cmty.app/nuxt/apollo-module/issues/c188


"yarn mint" fails

Describe the bug
the last command as mentioned on github page, "Yarn mint" fails.
To Reproduce
Steps to reproduce the behavior:

yarn mint

Expected behavior
should do usual mint code path
Screenshots

Desktop (please complete the following information):

OS: windows 10
Browser [chrome]
Version [22]

i am running it from the root path of installation.
in my case its c:\simple-nft-example>
On Wed, Oct 13, 2021 at 4:23 AM Kevin Seagraves @.***>
wrote:

@schetan https://github.com/schetan what path are you calling yarn mint
from?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/scaffold-eth/scaffold-eth/issues/491#issuecomment-941709779,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAPFV5PTUNIJLOIUXESVIHDUGS4AFANCNFSM5F3VJSIA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--
Regards,
Chetan
+919665562626

When i checked out the code, the downloaded scripts folder was missing
mint.js.
I had manually downloaded from the github repo files browser.
On Wed, Oct 13, 2021 at 10:03 AM Chetan @.***> wrote:

i am running it from the root path of installation.
in my case its c:\simple-nft-example>
On Wed, Oct 13, 2021 at 4:23 AM Kevin Seagraves @.***>
wrote:

@schetan https://github.com/schetan what path are you calling yarn mint
from?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/scaffold-eth/scaffold-eth/issues/491#issuecomment-941709779,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAPFV5PTUNIJLOIUXESVIHDUGS4AFANCNFSM5F3VJSIA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--
Regards,
Chetan
+919665562626

--
Regards,
Chetan
+919665562626

did downloading the mint.js file resolve your issue @schetan ?


Add initial support for juniper cptx

Add initial support for juniper cptx

Thanks for the review Marcus. Once the CLA is signed (more below), you can please merge the code?
Also Art is on PTO for the next week. Once he is back, would it be possible to meet with you to understand your requirements going forward?
I have been advised by our legal team that they have signed the CLA and delivered it to Google and are awaiting Google legal team's reply.
I actually tried to sign it myself, but the Google weblink rejected it as I am not an owner our mailer for this w/ Google.
Is there someone in Google our legal counsel can contact to expedite this process? They are also trying to reach out to Google in the meantime.
W.r.t. to the configuration file for our device, we will update it with a test config once our testing is done. Right now, it is just a default config as you say, and does not hurt anything.
We are also providing a CLI like other vendors whereby you can log in to our EVO CLI and do additional config at run time.
Regards,
Kaveh
Juniper Business Use Only
From: Marcus Hines @.>
Sent: Thursday, August 12, 2021 6:26 PM
To: google/kne @.>
Cc: Kaveh Moezzi @.>; Author @.>
Subject: Re: [google/kne] Add initial support for juniper cptx (#20)
[External Email. Be cautious of content]
@mhines01 commented on this pull request.
you need to sign the CLA as well before i can accept the PR

In topo/node/cptx/cptx.gohttps://urldefense.com/v3/__https:/github.com/google/kne/pull/20*discussion_r688182049__;Iw!!NEt6yMaO-gk!UOAmz2CpVirP6QyVpkJ7nXg5-zgJ3-pBTRRYWi1P74l1t_i7PoE2Kj7w7gfrv0CY6w$:

+func (n *Node) ConfigPush(ctx context.Context, ns string, r io.Reader) error {

   return status.Errorf(codes.Unimplemented, "Unimplemented")

+}

+func (n *Node) CreateNodeResource(_ context.Context, _ node.Interface) error {

  return status.Errorf(codes.Unimplemented, "Unimplemented")

+}

+func (n *Node) DeleteNodeResource(_ context.Context, _ node.Interface) error {

  return status.Errorf(codes.Unimplemented, "Unimplemented")

+}

+func defaults(pb *topopb.Node) *topopb.Node {

  return &topopb.Node{

         Constraints: map[string]string{

                 "cpu":    "8",

GAH that is CRAZY expensive for cpu what is up with that?

In examples/3node-cptx-host.pb.txthttps://urldefense.com/v3/__https:/github.com/google/kne/pull/20*discussion_r688182213__;Iw!!NEt6yMaO-gk!UOAmz2CpVirP6QyVpkJ7nXg5-zgJ3-pBTRRYWi1P74l1t_i7PoE2Kj7w7gfZEnqx9w$:

   value: {

       name: "ssh"

       inside: 22

   }

}

+}
+nodes: {

name: "cptx"

type: JUNIPER_CEVO

config: {

 image: "cptx:latest"

 config_path: "/home/evo/configdisk"

 config_file: "juniper.conf"

 file: "../examples/cptx/cptx-config"

}

services:{

you can just take your defaults() but this doesn't hurt anything

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/google/kne/pull/20*pullrequestreview-729191550__;Iw!!NEt6yMaO-gk!UOAmz2CpVirP6QyVpkJ7nXg5-zgJ3-pBTRRYWi1P74l1t_i7PoE2Kj7w7gf1CvcYyA$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AVFQEDPTHI6FTQIMUWJJLCDT4RYBDANCNFSM5CCOKJJQ__;!!NEt6yMaO-gk!UOAmz2CpVirP6QyVpkJ7nXg5-zgJ3-pBTRRYWi1P74l1t_i7PoE2Kj7w7geMuZYKwg$.
Triage notifications on the go with GitHub Mobile for iOShttps://urldefense.com/v3/__https:/apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675__;!!NEt6yMaO-gk!UOAmz2CpVirP6QyVpkJ7nXg5-zgJ3-pBTRRYWi1P74l1t_i7PoE2Kj7w7gdF-0GZaw$ or Androidhttps://urldefense.com/v3/__https:/play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email__;!!NEt6yMaO-gk!UOAmz2CpVirP6QyVpkJ7nXg5-zgJ3-pBTRRYWi1P74l1t_i7PoE2Kj7w7gfX9v6gJQ$.

Hi Marcus,
With  respect to your comment about why we are allocating 8 CPUs to our container, Art, who is on PTO for the next week, had communicated this a few weeks ago to Google in a meeting that other Google leads were present, but unfortunately you were not. Did they update you?
I hope you have been made aware that our solution has an EVO VM embedded in a container. Google's team had not objected to this. We are essentially providing a faithful representation of our HW platform for testing purposes. We had told Google we need 8 cores/20G of memory at the time, we are reducing that to 8 cores and 8G of memory and testing as we speak.
We can discuss this more with you when Art is back and get your inputs. I think it would be very helpful to start having discussions with you to tailor our product to your needs.
Regards,
Kaveh
Juniper Business Use Only
From: Kaveh Moezzi
Sent: Thursday, August 12, 2021 8:21 PM
To: google/kne @.>
Cc: Ganesh Raman @.>; Art Stine @.***>
Subject: RE: [google/kne] Add initial support for juniper cptx (#20)
Thanks for the review Marcus. Once the CLA is signed (more below), you can please merge the code?
Also Art is on PTO for the next week. Once he is back, would it be possible to meet with you to understand your requirements going forward?
I have been advised by our legal team that they have signed the CLA and delivered it to Google and are awaiting Google legal team's reply.
I actually tried to sign it myself, but the Google weblink rejected it as I am not an owner our mailer for this w/ Google.
Is there someone in Google our legal counsel can contact to expedite this process? They are also trying to reach out to Google in the meantime.
W.r.t. to the configuration file for our device, we will update it with a test config once our testing is done. Right now, it is just a default config as you say, and does not hurt anything.
We are also providing a CLI like other vendors whereby you can log in to our EVO CLI and do additional config at run time.
Regards,
Kaveh
Juniper Business Use Only
From: Marcus Hines<EMAIL_ADDRESS>Sent: Thursday, August 12, 2021 6:26 PM
To: google/kne<EMAIL_ADDRESS>Cc: Kaveh Moezzi<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [google/kne] Add initial support for juniper cptx (#20)
[External Email. Be cautious of content]
@mhines01 commented on this pull request.
you need to sign the CLA as well before i can accept the PR

In topo/node/cptx/cptx.gohttps://urldefense.com/v3/__https:/github.com/google/kne/pull/20*discussion_r688182049__;Iw!!NEt6yMaO-gk!UOAmz2CpVirP6QyVpkJ7nXg5-zgJ3-pBTRRYWi1P74l1t_i7PoE2Kj7w7gfrv0CY6w$:

+func (n *Node) ConfigPush(ctx context.Context, ns string, r io.Reader) error {

   return status.Errorf(codes.Unimplemented, "Unimplemented")

+}

+func (n *Node) CreateNodeResource(_ context.Context, _ node.Interface) error {

  return status.Errorf(codes.Unimplemented, "Unimplemented")

+}

+func (n *Node) DeleteNodeResource(_ context.Context, _ node.Interface) error {

  return status.Errorf(codes.Unimplemented, "Unimplemented")

+}

+func defaults(pb *topopb.Node) *topopb.Node {

  return &topopb.Node{

         Constraints: map[string]string{

                 "cpu":    "8",

GAH that is CRAZY expensive for cpu what is up with that?

In examples/3node-cptx-host.pb.txthttps://urldefense.com/v3/__https:/github.com/google/kne/pull/20*discussion_r688182213__;Iw!!NEt6yMaO-gk!UOAmz2CpVirP6QyVpkJ7nXg5-zgJ3-pBTRRYWi1P74l1t_i7PoE2Kj7w7gfZEnqx9w$:

   value: {

       name: "ssh"

       inside: 22

   }

}

+}
+nodes: {

name: "cptx"

type: JUNIPER_CEVO

config: {

 image: "cptx:latest"

 config_path: "/home/evo/configdisk"

 config_file: "juniper.conf"

 file: "../examples/cptx/cptx-config"

}

services:{

you can just take your defaults() but this doesn't hurt anything

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/google/kne/pull/20*pullrequestreview-729191550__;Iw!!NEt6yMaO-gk!UOAmz2CpVirP6QyVpkJ7nXg5-zgJ3-pBTRRYWi1P74l1t_i7PoE2Kj7w7gf1CvcYyA$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AVFQEDPTHI6FTQIMUWJJLCDT4RYBDANCNFSM5CCOKJJQ__;!!NEt6yMaO-gk!UOAmz2CpVirP6QyVpkJ7nXg5-zgJ3-pBTRRYWi1P74l1t_i7PoE2Kj7w7geMuZYKwg$.
Triage notifications on the go with GitHub Mobile for iOShttps://urldefense.com/v3/__https:/apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675__;!!NEt6yMaO-gk!UOAmz2CpVirP6QyVpkJ7nXg5-zgJ3-pBTRRYWi1P74l1t_i7PoE2Kj7w7gdF-0GZaw$ or Androidhttps://urldefense.com/v3/__https:/play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email__;!!NEt6yMaO-gk!UOAmz2CpVirP6QyVpkJ7nXg5-zgJ3-pBTRRYWi1P74l1t_i7PoE2Kj7w7gfX9v6gJQ$.

so i think all you need to do
is to follow the link in the cla page and to signup with the same email that is on your github account

Hi Marcus,
Our Senior legal counsel is working with "Erin" in Google to get our CLA in place. We had to replace our existing one and that has created some additional work.
I am hoping this will get cleared by Monday.
Is the rest of the code OK for commit with the explanations I have given? We also want to follow up and meet with you please when Art gets back from PTO in a week.
There we can discuss about CPU resources as well as some questions our team has to understand your needs better.
Regards,
Kaveh
Juniper Business Use Only
From: marcushines @.>
Sent: Friday, August 13, 2021 9:56 AM
To: google/kne @.>
Cc: Kaveh Moezzi @.>; Author @.>
Subject: Re: [google/kne] Add initial support for juniper cptx (#20)
[External Email. Be cautious of content]
so i think all you need to do
is to follow the link in the cla page and to signup with the same email that is on your github account

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/google/kne/pull/20*issuecomment-898595959__;Iw!!NEt6yMaO-gk!RvHTvsPKc1urB9Yd9Oo0DtmeDr0_vBSBC8r1dKwTzK_FvinA7gOqY0kX3ZlC-ELSGA$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AVFQEDPMU6RYQ5GQ4D5J4SLT4VFDPANCNFSM5CCOKJJQ__;!!NEt6yMaO-gk!RvHTvsPKc1urB9Yd9Oo0DtmeDr0_vBSBC8r1dKwTzK_FvinA7gOqY0kX3Zla2xB2HQ$.
Triage notifications on the go with GitHub Mobile for iOShttps://urldefense.com/v3/__https:/apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675__;!!NEt6yMaO-gk!RvHTvsPKc1urB9Yd9Oo0DtmeDr0_vBSBC8r1dKwTzK_FvinA7gOqY0kX3ZmC1WB49A$ or Androidhttps://urldefense.com/v3/__https:/play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email__;!!NEt6yMaO-gk!RvHTvsPKc1urB9Yd9Oo0DtmeDr0_vBSBC8r1dKwTzK_FvinA7gOqY0kX3ZlEfG6ZWQ$.

I just checked - Juniper does have a corporate cla with us
here are the instructions
How do I add authorized contributors for my company?
First, add their email address to the Google Group that you submitted with the corporate CLA. This is most commonly their company address.
Instruct contributors to use that same email address for any contributions to Google projects that are made on behalf of the company. For example, for projects that use git for source control, they may need to use the git config command to set their email address.
Additionally, if contributing to a project that is hosted on GitHub, contributors should add that email address to their GitHub account. This will allow us to map their GitHub username to the Corporate CLA that their contribution is covered by.
so your company should have signed up with a google group - your email needs to get added to that group and then it should be good but that will be up to whoever the administrator of your group is to get that done

Ack Marcus, apparently the old CLA has to be replaced per our legal team just to get my name added as a contributor.
Ning who is our senior legal counsel is working on this. Added him to the thread.
I apologize for any inconvenience to your time this has taken. Our legal team will take care of this with your legal team.
Regards,
Kaveh
Juniper Business Use Only
From: marcushines @.>
Sent: Friday, August 13, 2021 10:08 AM
To: google/kne @.>
Cc: Kaveh Moezzi @.>; Author @.>
Subject: Re: [google/kne] Add initial support for juniper cptx (#20)
[External Email. Be cautious of content]
I just checked - Juniper does have a corporate cla with us
here are the instructions
How do I add authorized contributors for my company?
First, add their email address to the Google Group that you submitted with the corporate CLA. This is most commonly their company address.
Instruct contributors to use that same email address for any contributions to Google projects that are made on behalf of the company. For example, for projects that use git for source control, they may need to use the git config command to set their email address.
Additionally, if contributing to a project that is hosted on GitHub, contributors should add that email address to their GitHub account. This will allow us to map their GitHub username to the Corporate CLA that their contribution is covered by.
so your company should have signed up with a google group - your email needs to get added to that group and then it should be good but that will be up to whoever the administrator of your group is to get that done

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/google/kne/pull/20*issuecomment-898602253__;Iw!!NEt6yMaO-gk!V_aZ38NAVfLjCFTeSg55p3p1IzQ_l71zsigkuM7N9fMrfxbUdkxOn61ZiH_VIyRTfw$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AVFQEDKNV7HFJT54RX6E223T4VGODANCNFSM5CCOKJJQ__;!!NEt6yMaO-gk!V_aZ38NAVfLjCFTeSg55p3p1IzQ_l71zsigkuM7N9fMrfxbUdkxOn61ZiH80luZGpg$.
Triage notifications on the go with GitHub Mobile for iOShttps://urldefense.com/v3/__https:/apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675__;!!NEt6yMaO-gk!V_aZ38NAVfLjCFTeSg55p3p1IzQ_l71zsigkuM7N9fMrfxbUdkxOn61ZiH_Eb60glQ$ or Androidhttps://urldefense.com/v3/__https:/play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email__;!!NEt6yMaO-gk!V_aZ38NAVfLjCFTeSg55p3p1IzQ_l71zsigkuM7N9fMrfxbUdkxOn61ZiH8QpVcvpg$.

I just checked - Juniper does have a corporate cla with us
here are the instructions
How do I add authorized contributors for my company?
First, add their email address to the Google Group that you submitted with the corporate CLA. This is most commonly their company address.
Instruct contributors to use that same email address for any contributions to Google projects that are made on behalf of the company. For example, for projects that use git for source control, they may need to use the git config command to set their email address.
Additionally, if contributing to a project that is hosted on GitHub, contributors should add that email address to their GitHub account. This will allow us to map their GitHub username to the Corporate CLA that their contribution is covered by.
so your company should have signed up with a google group - your email needs to get added to that group and then it should be good but that will be up to whoever the administrator of your group is to get that done

Hi Marcus, Google and Juniper legal cleared the CLA and added me to it. Please merge the code if you agree. Regards, Kaveh

The CLA is done Marcus. Thanks, Kaveh.

the check. still doesn't seem to be passing - can you just create a dummy PR with just like a single line change - i just want to see if that will show the same issue?

Done Marcus. Google CLA team told us we were all set on Friday. If this still does not work, please let me know and I will add you to that thread.
Juniper Business Use Only
From: marcushines @.>
Sent: Monday, August 16, 2021 8:23 AM
To: google/kne @.>
Cc: Kaveh Moezzi @.>; State change @.>
Subject: Re: [google/kne] Add initial support for juniper cptx (#20)
[External Email. Be cautious of content]
the check. still doesn't seem to be passing - can you just create a dummy PR with just like a single line change - i just want to see if that will show the same issue?

You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/google/kne/pull/20*issuecomment-899598413__;Iw!!NEt6yMaO-gk!Vq3DgCG6l94vWsd2bgWv-rtm48_Lnv9KqreofE4aVv3E9hGT9WGO4aCWpQBZX6M1Ww$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AVFQEDIFYYGJ6W25ZEYRZW3T5EUMBANCNFSM5CCOKJJQ__;!!NEt6yMaO-gk!Vq3DgCG6l94vWsd2bgWv-rtm48_Lnv9KqreofE4aVv3E9hGT9WGO4aCWpQDFuw7NFw$.
Triage notifications on the go with GitHub Mobile for iOShttps://urldefense.com/v3/__https:/apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675__;!!NEt6yMaO-gk!Vq3DgCG6l94vWsd2bgWv-rtm48_Lnv9KqreofE4aVv3E9hGT9WGO4aCWpQA9mFX0Jw$ or Androidhttps://urldefense.com/v3/__https:/play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email__;!!NEt6yMaO-gk!Vq3DgCG6l94vWsd2bgWv-rtm48_Lnv9KqreofE4aVv3E9hGT9WGO4aCWpQCfpb1SeA$.