refactor: used black to refactor entire codebase

I have reformatted the codebase with black

Hello @edeediong! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file cli/popper/cli.py:

Line 15:80: E501 line too long (81 > 79 characters)
Line 64:80: E501 line too long (80 > 79 characters)
Line 72:80: E501 line too long (87 > 79 characters)

In the file cli/popper/commands/cmd_ci.py:

Line 103:80: E501 line too long (84 > 79 characters)

In the file cli/popper/commands/cmd_dot.py:

Line 66:80: E501 line too long (84 > 79 characters)

In the file cli/popper/commands/cmd_run.py:

Line 23:80: E501 line too long (80 > 79 characters)
Line 85:80: E501 line too long (87 > 79 characters)
Line 113:80: E501 line too long (83 > 79 characters)
Line 167:80: E501 line too long (84 > 79 characters)

In the file cli/popper/config.py:

Line 51:80: E501 line too long (86 > 79 characters)

In the file cli/popper/log.py:

Line 126:80: E501 line too long (82 > 79 characters)

In the file cli/popper/parser.py:

Line 223:80: E501 line too long (84 > 79 characters)
Line 226:80: E501 line too long (86 > 79 characters)
Line 251:80: E501 line too long (85 > 79 characters)
Line 257:80: E501 line too long (84 > 79 characters)
Line 263:80: E501 line too long (84 > 79 characters)
Line 273:80: E501 line too long (87 > 79 characters)
Line 318:80: E501 line too long (83 > 79 characters)
Line 416:80: E501 line too long (84 > 79 characters)
Line 517:80: E501 line too long (86 > 79 characters)
Line 611:80: E501 line too long (80 > 79 characters)
Line 793:80: E501 line too long (80 > 79 characters)

In the file cli/popper/runner.py:

Line 28:80: E501 line too long (85 > 79 characters)
Line 117:80: E501 line too long (87 > 79 characters)

In the file cli/popper/runner_host.py:

Line 183:80: E501 line too long (83 > 79 characters)
Line 196:80: E501 line too long (83 > 79 characters)
Line 340:80: E501 line too long (88 > 79 characters)
Line 359:80: E501 line too long (83 > 79 characters)
Line 414:80: E501 line too long (82 > 79 characters)
Line 416:80: E501 line too long (85 > 79 characters)
Line 420:80: E501 line too long (88 > 79 characters)
Line 448:80: E501 line too long (82 > 79 characters)

In the file cli/popper/runner_slurm.py:

Line 180:80: E501 line too long (88 > 79 characters)
Line 184:80: E501 line too long (83 > 79 characters)

In the file cli/popper/scm.py:

Line 130:80: E501 line too long (87 > 79 characters)

In the file cli/test/test_cmd_dot.py:

Line 16:80: E501 line too long (86 > 79 characters)
Line 37:80: E501 line too long (84 > 79 characters)

In the file cli/test/test_config.py:

Line 36:80: E501 line too long (83 > 79 characters)
Line 50:80: E501 line too long (83 > 79 characters)

In the file cli/test/test_parser.py:

Line 23:80: E501 line too long (81 > 79 characters)
Line 199:80: E501 line too long (80 > 79 characters)
Line 200:80: E501 line too long (80 > 79 characters)
Line 201:80: E501 line too long (80 > 79 characters)
Line 216:80: E501 line too long (85 > 79 characters)
Line 224:80: E501 line too long (80 > 79 characters)
Line 225:80: E501 line too long (80 > 79 characters)
Line 226:80: E501 line too long (80 > 79 characters)
Line 241:80: E501 line too long (85 > 79 characters)
Line 283:80: E501 line too long (80 > 79 characters)
Line 284:80: E501 line too long (80 > 79 characters)
Line 285:80: E501 line too long (80 > 79 characters)
Line 308:80: E501 line too long (80 > 79 characters)
Line 326:80: E501 line too long (80 > 79 characters)
Line 327:80: E501 line too long (80 > 79 characters)
Line 328:80: E501 line too long (80 > 79 characters)
Line 343:80: E501 line too long (85 > 79 characters)
Line 386:80: E501 line too long (80 > 79 characters)
Line 404:80: E501 line too long (80 > 79 characters)
Line 443:80: E501 line too long (82 > 79 characters)
Line 498:80: E501 line too long (81 > 79 characters)
Line 588:80: E501 line too long (81 > 79 characters)

In the file cli/test/test_runner.py:

Line 73:80: E501 line too long (81 > 79 characters)
Line 79:80: E501 line too long (84 > 79 characters)
Line 96:80: E501 line too long (81 > 79 characters)

In the file cli/test/test_runner_host.py:

Line 113:80: E501 line too long (88 > 79 characters)
Line 127:80: E501 line too long (88 > 79 characters)
Line 134:80: E501 line too long (81 > 79 characters)
Line 142:80: E501 line too long (88 > 79 characters)
Line 166:80: E501 line too long (88 > 79 characters)
Line 192:80: E501 line too long (88 > 79 characters)
Line 222:80: E501 line too long (88 > 79 characters)
Line 276:80: E501 line too long (84 > 79 characters)
Line 295:80: E501 line too long (80 > 79 characters)
Line 316:80: E501 line too long (88 > 79 characters)
Line 320:80: E501 line too long (84 > 79 characters)
Line 335:80: E501 line too long (93 > 79 characters)
Line 346:80: E501 line too long (82 > 79 characters)
Line 354:80: E501 line too long (82 > 79 characters)
Line 359:80: E501 line too long (84 > 79 characters)
Line 372:80: E501 line too long (84 > 79 characters)
Line 408:80: E501 line too long (84 > 79 characters)
Line 438:80: E501 line too long (84 > 79 characters)
Line 442:80: E501 line too long (86 > 79 characters)

In the file cli/test/test_runner_slurm.py:

Line 449:80: E501 line too long (208 > 79 characters)

In the file cli/test/test_scm.py:

Line 77:80: E501 line too long (80 > 79 characters)

In the file docs/conf.py:

Line 281:80: E501 line too long (82 > 79 characters)
Line 321:80: E501 line too long (82 > 79 characters)

@ivotron should I be worried that @pep8speaks is warning me of pep8 guidelines? Can I use the autopep8 library to ensure the codebase conforms with pep8?

hey @edeediong , thanks a lot for working on this!
we can configure pep8speaks to use the same default line length as black. See here for more: https://pep8speaks.com/
would it be possible to also add black to setup.py (dev section), and add a step in .travis.yml to check for format violations using black?
also, it would be great if we could update the CONTRIBUTIN.md and docs/sections/contributing.md documentation with a note mentioning that we use black, and maybe adding a link to where contributors can find more about how to install and setup black in their IDEs.
thanks a lot 🙏

We can do that. IN the travis file, we will do a black --check . to confirm if it is formatted or not. Let me get right on it

@ivotron Hi! So I have a few observations and suggestions/

I used the pytest black plugin to test for black formatting. It works perfectly. Is this acceptable? Or is there another way this could work?
Also can by PR be merged, please? Your changes just failed black formatting and I had to correct it, lol. It'd be nice to have you correct it, hahaha. It's mostly due to merge conflicts though that's why.
I'd love to include a test in the test folder so that when one runs tests on his local machine if it's not formatted with black it should fail. This test will be independent of the CI test.
If number 2 is done above, I will still work on the documentation before I move to the other issue

thanks Eddie! See questions/comments inline

@ivotron Hi! So I have a few observations and suggestions/

I used the pytest black plugin to test for black formatting. It works perfectly. Is this acceptable? Or is there another way this could work?

can you explain what does pytest-black does that black doesn't? I was under the impression that black --check --diff would be enough, but I haven't used black before.

Also can by PR be merged, please? Your changes just failed black formatting and I had to correct it, lol. It'd be nice to have you correct it, hahaha. It's mostly due to merge conflicts though that's why.

This is where git rebase -i comes handy as it allows you to edit the history so that you can reorder/discard commits in a way that can ease rebasing changes made to upstream.

I'd love to include a test in the test folder so that when one runs tests on his local machine if it's not formatted with black it should fail. This test will be independent of the CI test.

what would the test do that is different than doing black --check on the command line? Also, some IDEs have black integrations, so it might be better to let contributors run the formatter in a way that it suits their environment best

If number 2 is done above, I will still work on the documentation before I move to the other issue

yeah, we can break this in two

@ivotron please review.

Also, the reasoning behind including a test for black in the codebase is it would be good for a contributor to have an idea of all the tests that are run on a CI build also on their local machine. You're sure if tests pass on your PC it'd pass in a Travis environment. When I contributed to Oppia and Tensorflow I saw this as well. Linting tests are checked on the local machine as well as on a Travis Build. It may not be necessary though

Also, the reasoning behind including a test for black in the codebase is it would be good for a contributor to have an idea of all the tests that are run on a CI build also on their local machine. You're sure if tests pass on your PC it'd pass in a Travis environment. When I contributed to Oppia and Tensorflow I saw this as well. Linting tests are checked on the local machine as well as on a Travis Build. It may not be necessary though

I think this is part of the documentation changes I suggested. We can include those in this PR if you want. So basically, to run tests locally:
python -m unittest -f cli/test/test_*
black --check --diff .

If that runs locally, it should run on travis as well

#fmt: off
<block-of-code-containing-a-very-long-string-here>
#fmt: on

the above lets black now that it should ignore that.

Where do I add the above?

#fmt: off
<block-of-code-containing-a-very-long-string-here>
#fmt: on

the above lets black now that it should ignore that.

Where do I add the above?

in the case of this W501 error we can create a multi-line f-string. In the case of this other, we add a comment in the python file before and after the block of code. This is described here.

@ivotron I had AssertionError: '#!/bin/bash\ndocker rm -f popper_1_123abc || true\nd[420 chars]3abc' != '#!/bin/bashdocker rm -f popper_1_123abc || truedocke[412 chars]3abc' Diff is 953 characters long. Set self.maxDiff to None to see it. when I used multiline f-strings.
Would try to fix this now.

@ivotron I used multi-line f string for everything. I feel if black should be used as the formatter then there shouldn't be exceptions. KIndly review

thanks Eddie, this looks great. The only thing missing is to add a note on CONTRIBUTING.md and docs/sections/contributing.md on how to run black. Would it be fine to include that as well in this PR? A short description like on both files would be enough:
We use [`black`](https://github.com/psf/black) to automatically format the codebase. To execute it on your machine, you can run:

```bash
black --check --diff .
```

@ivotron documentation added

thanks Eddie, much appreciated! 🙏


Fix #278

Newline characters were automatically standardized to CRLF, so there are many diffs.
See #278 to see the actual diffs.

改行文字がCRLFに自動的に標準化されたため、差分の数が多くなっています。
実際の変更点は #278 をご覧下さい。

Hello, since the PR is very large (+4461/-4430), I will have to request you a short summary of which lines you changed/for which reason

(My bad, I removed my mistake, just saw you explained the changes on the issue, checking this and will merge if it's good)

Looks good to me ! Merged thank you


The default group name is Miscellaneous instead of Custom.

Q
A

content fix?
yes

New article?
no

Related issues?
N/A

What's in this Pull Request?
If the group field is not specified in web part, the classic web part picker puts the web part to Miscellaneous group instead of Custom.

This PR is to update the doc for this.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/spfx/web-parts/guidance/simplify-adding-web-parts-with-preconfigured-entries.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

thx


ci(deps): update terraform-ibm-modules/common-pipeline-assets action to v1.5.1

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/common-pipeline-assets
action
patch
v1.5.0 -> v1.5.1

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, click this checkbox. ⚠ Warning: custom changes will be lost.

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.11.0 :tada:
The release is available on:

GitHub release
v1.11.0

Your semantic-release bot :package::rocket:


Preflight check API parameters and limit number of rows returned by API queries

May API calls allow a date range (or offset + page size) to determine the size of the data return. This can be abused (often unintentionally) to query and return an unbounded amount of data.
API and Database calls should limit sizes.

At the API level, if any parameters can very data size returned (page size, date range), then they should be sanity checked and return an error 413 Payload Too Large.
ALL db calls accessible from APIs should include a .limit(MAX_RECORDS_TO_RETURN) to set an upper bounds on rows returned from a query. This is a safety fallback if some API call doesn't have the check.

TODO

List all APIs as a checklist to verify. Ticket may need to be an epic?

[ ] adm/getsendfailures
(Issue #6304 - tomn)
[ ] adm/listreceiversconnstatus
(Issue #6304 - tomn)
[ ] ...

Duplicate of Michael Kalish's work with STLT dashboard. @mkalish


added printing cache after part 1 and part 2

don't merge - it's very verbose - im just sharing the code

Thanks, that's helpful!


Revisiting surface topography visualization

I think we should revisit the visualization of the individual topographies completely. In this process, we should also address the related issue #676.
Here are a couple of things I like:

https://isg.nist.gov/deepzoomweb/view/image/moche
https://www.zoosphere.net/

They are both based on OpenSeadragon. The repository is here and seems to be still maintained. I believe the little scale bar and the overview is done via a plugin. There is a Django plugin that has not seen updates since 2015. It may not be useful in any case.
OpenSeadragon needs a tiled image format. Several formats are supported. This means what we need is a tool that converts surface topographies to this tiled image format. This functionality could (and probably should) be part of SurfaceTopography. We can then create the tiled image in a celery process, circumventing the memory problem.

After looking into this, I think it should be super simple to implement. I'll write a DZI export filter for SurfaceTopography and then we can discuss how to get this into TopoBank

The funny thing is, once we've already had an OpenSeadragon solution in the very beginning of this project (#62) for a short period, now we're coming back. Not sure why, maybe it was easier then. Okay, let's discuss that. With support by the backend it is hopefully easy to implement.

We had discussed this but never implemented it, correct?

See also here: https://github.com/ContactEngineering/SurfaceTopography/pull/104

Yes, it was implemented, but didn't look nice or I had no idea how to have a good color bar for the encoding. Not sure why. We've had it about one week and then I switched to bokeh. Or maybe I thought it was easier overall.

Here is an example to play with:
openseadragon-test.zip
I think it is okay. I don't know how to set the aspect ratio of a pixel which is something we would need. It certainly feels more snappy and responsive than Bokeh. It also solves the problem with having to load the full file. Better would of course to have something like this within Bokeh. (I mean tiled loading of data.)

For implementation we need the following: The tiled image files would be cached (in the S3). We would need a routine that converts the topography to the DZI format. This could well be an analysis function. Django needs to do nothing other than deliver those image files.

Note that we may want to change all map visualization, i.e. also the visualization of contact pressure area etc.

Another thing is that SurfaceTopography should export an image of a scale bar as well. We probably need to stick numbers to it in HTML. See also here https://github.com/ContactEngineering/SurfaceTopography/issues/105

Thanks for the example. The zooming works quite well, at least when all data is locally available.
I expect this would also work with intermediate requests.
You've written that we might exchange all map visualizations. I'm a bit hesitant since we would also
loose then the axes frame, which always show the coordinates of the area you're looking at. Then it would be
more an image than a plot. Also tooltips with specific information at the mouse pointer are not possible any more
(so far only used for the topography view).
I'm not sure whether the axes or tooltips are relevant from a user perspective or not.
If yes: Maybe we could think of having both visualizations? Or have a detailed look at DataShader? The latter seems to be made for this use case, although I'm not sure yet how to embed
it into Django.

I agree that we would loose some Bokeh functionality. Let me try to compile a list of pros and cons:
Pros

Does not load full topography to client
Fluent zooming
Scale bar
Easy to implement

Cons

Loose single pixel selection
Loose x- and y-axis (but have scale bar)
Not clear if aspect ratio != 1 is possible
Image files contain too much data (it would be better if we had a tiled topography)
No scale bar out of the box

The killer argument is really the fact that this seems to be the only way to display large topographies (without us implementing our own JavaScript library).

In terms of cons. It may be possible to implement 1 and 2 as a plugin, and I think 3 should be possible.

That Zoom box is an open plugin, that should be easy to do.

Okay, fine, let's give it a try.

I can try to implement this. One thing to discuss would be whether the generation of the tiled images should be an analysis function.

Maybe we can discuss that on the next meeting. There are different cases:
The topography image itself
Not sure. From a gut feeling I would say that we use use a Celery task, like I did for generating the thumbnail files, but no analysis. The latter would be more complicated than needed, e.g. you don't want this analysis being chooseable in the UI.
Example thumbnails: Each topography in Topobank has a renew_thumbnail() method which can be called within a Celery task:
https://github.com/ContactEngineering/TopoBank/blob/aed522ff431a4951a98f67e74ed922b921774aa1/topobank/taskapp/tasks.py#L274
Basically you only need to write a Topography method like this:
https://github.com/ContactEngineering/TopoBank/blob/aed522ff431a4951a98f67e74ed922b921774aa1/topobank/manager/models.py#L810
Then call it from a task and start the task with .delay() everywhere when needed.
We also have to think about what to do if the files are not ready yet and the user tries to display them etc.
Maps from analysis results
Here we may just create the tiled images within the analysis, writing the tiles images in the S3 "folder" of the analysis.
And we need to recreate all related analysis in production so everywhere the tiled images are available. Can be done with the management command trigger_analyses.
On the other hand it sounds also nice to have everything generated in an analysis. This would need some
reconstruction.

Btw. this could be helpful to implement a "Save image" functionality: https://github.com/KTGLeiden/Openseadragon-screenshot


git push error after upgrade git server from 1.8 to 2.1

Gitea version (or commit ref):
Git version:
Operating system:
Database (use [x]):

[ ] PostgreSQL
[x] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[x] No
[ ] Not relevant

Log gist:

Description
I use CentOS 7 and install git 1.8,after I upgrade git from 1.8 to 2.1.
I can not push
...
Screenshots

what error do you get?

I think it is OK now.
I forget restart the gitea process.


No self.new for aliased self-containing hash

This alias can be declared, but doesn't get a self.new
alias SelfContainingHash = Hash(String, String | SelfContainingHash)

a = SelfContainingHash.new # Error: undefined method 'new' for SelfContainingHash.class

Compiler version:
Crystal 0.35.1 [5999ae29b] (2020-06-19)

LLVM: 8.0.0
Default target: x86_64-unknown-linux-gnu

Recursive aliases can't have methods. That's why I'd like to remove them from the language, they are inconsistent.

That's fine as long as you provide a syntax that allows generics to contain themselves. Aliases are overloaded to perform forward declarations, which really need their own syntax.
I can't say:
forward B
class A < Array(Int32|B)
end
class B < A
end


I need help with a syntax theme from Atom.

Hello, I am trying to create a simple syntax theme like Classic Plus from Dev-C++.
My questions are:
1: How i can put #include <> with color: @green; and font-weight: normal; but perserving this:
&.syntax--control {     color: @syntax-text-color;     font-weight: bold;   }?
2: How i can put (),{},,,.,;...  with color: @red; and font-weight: bold;?
I let you an image in which you can see this stuff in Dev-C++:

An now, how this code looks on Atom:

If you need to see my base.less, tell me and I'll add it.
Thank you very much. :-)
Alberto.

Thanks for reaching out!
Because we treat our issues list as the Atom team's backlog, we close issues that are questions since they don't represent a task needing to be completed. For most questions about Atom there are a lot of options, check out:

The Atom Flight Manual
The Atom FAQ on Discuss
Discuss, the official Atom and Electron message board - in particular, be sure to use the Themes label for your post.
Join the Atom Slack team

On Discuss and in the Atom Slack team, there are a bunch of helpful community members that should be willing to point you in the right direction.


crash when creating font

java.lang.ClassCastException: class com.ray3k.skincomposer.LeadingTruncateLabel cannot be cast to class com.badlogic.gdx.scenes.scene2d.ui.TextField (com.ray3k.skincomposer.LeadingTruncateLabel and com.badlogic.gdx.scenes.scene2d.ui.TextField are in unnamed module of loader 'app')
at com.ray3k.skincomposer.dialog.DialogBitmapFont$6.lambda$changed$0(DialogBitmapFont.java:327)
at com.badlogic.gdx.backends.lwjgl3.Lwjgl3Application.loop(Lwjgl3Application.java:154)
at com.badlogic.gdx.backends.lwjgl3.Lwjgl3Application.(Lwjgl3Application.java:114)
at com.ray3k.skincomposer.desktop.DesktopLauncher.main(DesktopLauncher.java:405)
this exception happens reproducable on every try of creating a font with the attached settings.
I enter "acme_white_18_shadow" as the filename when clicking on the .fnt name box (and then the save dialog appears).
When i click on "save" at the system save-as dialog, this crash happens.
i have a screen recording so you can see what I type - unfortunately windows game bar doesn't record the system save-as dialog but you can see what I enter
hope this helps!
screen-video.zip
escape-font-settings-shadow.zip

I'd like to add that I now tried with other settings (no shadow, etc) -> same crash.
So, at the moment I am not able to add any new fonts through the skin composer.

Strangely enough I ran into this problem myself yesterday. Sorry for the inconvenience. I'd suggest using an older version for now, but I'll have a fix soon. Thanks for the report.

you're welcome!
Thank you very much for this great tool!

Sorry this took so long to resolve. I really couldn't find the time! I've been assigned a lot of different projects. This should be resolved with version 39. Thank you.


MM-17694: Migrate to circleci.

Still probably needs some adjustments especially for the aws s3 upload part.
https://mattermost.atlassian.net/browse/MM-17694
https://github.com/mattermost/mattermost-server/issues/11853

I've created the matterbuild-docs context, all setup

@metanerd can you please amend the commit to trigger the job? I've enabled that on circleci now


Add support to set S3 access logs bucket

What
Allow setting access_log_bucket_name and access_log_bucket_prefix variables, which will be bypassed to the cloudposse/s3-log-storage/aws module as-is.
We need to bump the cloudposse/s3-log-storage/aws module to version 0.24.0, as that's where the access_log_bucket_prefix variable was introduced.
Why

Need to keep track of accesses to LB access logs.

References

https://github.com/cloudposse/terraform-aws-s3-log-storage/commit/c1a2a8faba43c9b3a824184faa4be0d6dfea09e4

/test all

Thank you for the quick resolution, @korenyoni!


manuals: Describe how to link NixOS tests from packages

Motivation for this change
Finally explains passthru.tests for NixOS tests!
Things done

[x] Doc-only change

I rebased on https://github.com/NixOS/nixpkgs/commit/47fe2c7e935b03e7788f4db1935b0527af370a09 which moved one involved file to CommonMark.


Fix for VS2015

_set_output_format(_TWO_DIGIT_EXPONENT); is no longer necessary and the function was removed from the library.

I can't work out why the link errors... it really looks like it's linking the proper lib, and the symbols look correct, but it still fails.

I can't work out why the link errors... it really looks like it's linking the proper lib, and the symbols look correct, but it still fails.

I just tried compiling the VS solution with VS2015 for git-head: a lot of warnings in the C++ code, but no link problems and a successful build for both Win32 and x64. You'll need a recent dmd version, though, i.e. 2.069 or newer.

I've been running DMD nightlies, so that's well up to date.
Only think I can think of is sc.ini perhaps? There's no remaining residue from sc.ini polluting the environment when building under vs2015 that might cause our build environments to be different?

actually, the C++ project references an older toolset... when you load it in 2015, if the old toolset is available, 2015 will use it, if the old toolset is unavailable, it will offer to convert the project for the latest toolset.
In my case, I have no other version of VS installed, so it updates to the 2015 toolset. Are you updating, or building the project against the older toolset referenced by the project file?

I've let VS convert the projects to v140. What link errors do you get?

https://issues.dlang.org/show_bug.cgi?id=15611
__vsnprintf, _snprintf, _sscanf

That means legacy_stdio_definitions.lib is missing from the link. That should be automatically be added by Visual D, though.

Apparently not...? I'll try and explicitly link that lib later tonight.

I've added support for it in latest Visual D 0.3.43. dmd installers downloaded 0.3.42 until a few days ago.

oh okay. well that's almost certainly my problem.

Fixed it. Thanks!


On Boarding Employees Feature

Description
A page that is accessible by managers, hr, and admin. This page will be a way for new employees to be added into the system. This should include inputs for all fields in the employee class, and on submit, should add a user into the database.
As a "Manager",
So that "I can add a new employee",
I want "To have a place on the kiosk to add an employee to the system"
Acceptance Criteria
What are some implicit tasks/criteria to be achieved within this story?

[ ]  Create HTML page for adding in employee creation form
[ ]  Add logic to add employee info into database
[ ]  Make this new page accessible to only hr, manager, and admin.

So I know this was just opened, but we can probably use Django's built-in registration form, and only allow it to be fillable by HR.
Or, we can re-CSS the admin page so that we can just reuse that page for user creation/deletion


Fix row unwrapping #3117

This is probably not the best way to achieve this, but I'm open to feedback. I didn't know how to generate the minified version so it's untouched.
Fixes #3117

This apparently was fixed in the master branch by checking against _.options.rows > 0 and my problem doesn't show up anymore. This patch is not needed if you use the latest version.


meta: enable "discussions" feature on Github

Discussions are much more useful for random questions (such as #33) than issues are.

Done 👍🏽


Suggestion: Add support for "will-change"

https://dev.opera.com/articles/css-will-change-property/
http://dev.w3.org/csswg/css-will-change/
http://caniuse.com/#feat=will-change (~41% browser share, )
Currently mobileHA:true is used to promote animated elements via transform:translateZ(0) and (hopefully) optimise whatever happens to be moving. This is set at the start of the animation (ie, first frame after creating it).
Basically this change would set the will-change:<keys> css attribute when the animation is created instead of setting translateZ when it starts (so only useful on browsers that support it - fallback to translateZ in all other cases), then deleting it when finished.
The benefit would be slightly smoother animations and slightly less thrashing on the first frame as the browser would have the opportunity to create any layers (if they're even needed) before it starts.
Questions: if using the tween key, or a progress function should it still try to predict or should it just use translateZ, or should there be an option that we can manually set things that are going to change?

Good stuff. Will get back to you on this before the next update.

Apparently Chrome has completely screwed with this to make it unusable, a pretty good writeup is available here - https://greensock.com/will-change


Basic Llama2 Tuning

What does this PR do?
Add support for Llama model tuning on TPU v5e, with a related example.
Before submitting

[x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[x] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Is there any reasons why you choose to use 2D sharding instead of FSDPv2? The latter is integrated in to transformer trainer: https://huggingface.co/blog/gemma-peft#accelerate-with-fsdp-via-spmd-on-tpu

@alanwaketan yes, the reason is that it did not work out of the box, apparently the trainer was trying to use some API from the XLA that was in experimental and it is not available anymore, so the code was raising an exception. I guess we can fix the FSDP in transformers too, and compare both to see which one performs better.

@alanwaketan yes, the reason is that it did not work out of the box, apparently the trainer was trying to use some API from the XLA that was in experimental and it is not available anymore, so the code was raising an exception. I guess we can fix the FSDP in transformers too, and compare both to see which one performs better.

Can you point me to the error? All the API the trainer uses should be available in 2.3.

FSDPv2's intention is to releif the need for all this complicated shardings from regular users. Unless you know you need 2D sharding instead of 1D.

@alanwaketan sure it makes total sense, I will get back to you with the error

@alanwaketan you can check the errors I see with FSDP here.

I raised an issue on the accelerate project to fix the FSDP/dataloader issue https://github.com/huggingface/accelerate/issues/2775

@alanwaketan Ah btw I was still using torch xla 2.2, we haven't moved to 2.3 yet. I will do that so I can re-test FSDP.

2.2 is expected to not work. The 2.3 issue seems more generic than FSDPv2.


[FEATURE] add adaptive learning rate feature (automatic adjust LR-level)

Now with every epoch learning rate decreased according to lr_decay value by ExponentialLR rule.
When users make their nam-models they trying to achieve maximum quality of model no matter how long will it train.
So they run trainig for 1000+ epochs and after 500-600 epochs they see completely flat horisontal line of error with no next improvement no matter how mane epochs there will be.
But lowering LR_decay can get it to better results.
So:

Automatic set lr_decay value according to lr and epochs.
For example:
lr_decay ( lr, epochs ) = minimum( lr_decay_default_value , lr_decay_default_value  /  epochs * 500  )
, it's very simple and stupid but efficient method
, now lr_decay by default = 0.007
On some drive marshall training tests i get results:
standart architecture (lr_dec = 0.007, 2000 ep) = 0.0020 ESR
lite architecture(lr_dec = 0.002, 2000 ep)          = 0.0017 ESR

Now NAM using ExponentialLR, maybe try other, for example:
lr_scheduler.ReduceLROnPlateau (https://pytorch.org/docs/stable/generated/torch.optim.lr_scheduler.ReduceLROnPlateau.html#torch.optim.lr_scheduler.ReduceLROnPlateau)
lr_scheduler.CyclicLR

In many my neural trainig models i use adaptive learning rate.
it decreasing when many epochs there is no significant error improvement but big amplitude of error level (reduceLROnPlateau analog)
, and increasing when many epochs there is no significant error improvement and very small amplitude of error level (by batches or epochs).

Brilliant tip!

I've tried a lot of these in the past :) Exponential works fairly well.
I don't think I'm keen to open this up on the "user-friendly" trainers, but if you want to get deep like this, the learning rate is configurable using the script-based trainer, bin/train/main.py.  You configure this under the model's configuration JSON. See Model.configure_optimizers().


eval'd field is not preserved with keep

I'm running kapacitor 1.5.0 on mac(10.12.6) installed via brew. I would expect the following tick to preserve AB and C fields at the end but AB seems to be missing.
Tick:
stream
    |from()
        .database('test')
        .measurement('test')
    |log()
    |eval( lambda: ("A"/"B") *5)
        .as('AB')
        .keep('C')
    |log()

> select * from test
name: test
time                A B C
----                - - -
1536190236170076357 1 2 3
>

Here's the log:
ts=2018-09-05T16:30:36.170-07:00 lvl=info msg=point service=kapacitor task_master=main task=test node=log2 prefix= name=test db=test rp=autogen group=   **field_A=1 field_B=2 field_C=3** time=2018-09-05T23:30:36.170076357Z
ts=2018-09-05T16:30:36.170-07:00 lvl=info msg=point service=kapacitor task_master=main task=test node=log4 prefix= name=test db=test rp=autogen group=   **field_C=3** time=2018-09-05T23:30:36.170076357Z

Without .keep() AB is preserved.

probably I should just use .keep().


Crash when trains collide with entity.

Describe the Bug
when a train hits an entity the server crashes. Included is client log too.
https://paste.atlauncher.com/view/9f84d7c1-b503-4fb0-85f5-1279ab64d382
Reproduction Steps

make train
hit a mob

...
Expected Result
To damage the entity
Screenshots and Videos
No response
Crash Report or Log
https://mclo.gs/BKRuJOB
Operating System
windows 10
Mod Version
0.5.0i
Minecraft Version
1.18.2
Other Mods
[05/05/2023 20:39:14 pm] Mods:
[05/05/2023 20:39:14 pm]  - \advancednetherite-fabric-1.5.1-1.18.2.jar (Added)
[05/05/2023 20:39:14 pm]  - \alloygery-2.5.5+1.18.2.jar (Added)
[05/05/2023 20:39:14 pm]  - \almostunified-fabric-1.18.2-0.3.10.jar (Added)
[05/05/2023 20:39:14 pm]  - \Apugli-1.18.2-1.6.2.jar (Added)
[05/05/2023 20:39:14 pm]  - \architectury-4.11.93-fabric.jar (Added)
[05/05/2023 20:39:14 pm]  - \audioplayer-1.18.2-1.0.3.jar (Added)
[05/05/2023 20:39:14 pm]  - \authme-mc1.18.2-3.1.0.jar (Added)
[05/05/2023 20:39:14 pm]  - \balm-fabric-3.2.6.jar (Added)
[05/05/2023 20:39:14 pm]  - \bclib-1.4.7.jar (Added)
[05/05/2023 20:39:14 pm]  - \better-end-1.1.1.jar (Added)
[05/05/2023 20:39:14 pm]  - \better-nether-6.1.2.jar (Added)
[05/05/2023 20:39:14 pm]  - \bettercombat-fabric-1.6.2+1.18.2.jar (Added)
[05/05/2023 20:39:14 pm]  - \betterpotionvisuals-1.18.x-1.0.0.jar (Added)
[05/05/2023 20:39:14 pm]  - \bitsandchisels-2.6.13.jar (Added)
[05/05/2023 20:39:14 pm]  - \bobby-3.1.1.jar (Added)
[05/05/2023 20:39:14 pm]  - \bringdecay-0.0.2-1.16.3-1.19.2.jar (Added)
[05/05/2023 20:39:14 pm]  - \CITResewn-1.1.1+1.18.2.jar (Added)
[05/05/2023 20:39:14 pm]  - \Clockwork_Fabric_Pre-Alpha_Patch_1.2.jar (Added)
[05/05/2023 20:39:14 pm]  - \cloth-config-6.3.81-fabric.jar (Added)
[05/05/2023 20:39:14 pm]  - \cloth-config-6.4.90-fabric.jar (Added)
[05/05/2023 20:39:14 pm]  - \continuity-2.0.2+1.18.2.jar (Added)
[05/05/2023 20:39:14 pm]  - \cpm-osc-compat-1.2.1.jar (Added)
[05/05/2023 20:39:14 pm]  - \cpm-svc-compat-1.1.0.jar (Added)
[05/05/2023 20:39:14 pm]  - \create-fabric-0.5.0.i-1002+1.18.2.jar (Added)
[05/05/2023 20:39:14 pm]  - \create-track-map-1.3+mc1.18.2-fabric.jar (Added)
[05/05/2023 20:39:14 pm]  - \CreateFabricREIBugFix-0.1.2-mc1.18.x.jar (Added)
[05/05/2023 20:39:14 pm]  - \createplus-1.0.0-beta4.jar (Added)
[05/05/2023 20:39:14 pm]  - \creatoroverlays-2.2.1.jar (Added)
[05/05/2023 20:39:14 pm]  - \CullLessLeaves-1.0.1.jar (Added)
[05/05/2023 20:39:14 pm]  - \CustomPlayerModels-Fabric-1.18-0.6.7a.jar (Added)
[05/05/2023 20:39:14 pm]  - \dim-height-1.1.1.jar (Added)
[05/05/2023 20:39:14 pm]  - \enhancedblockentities-0.7.1+1.18.2.jar (Added)
[05/05/2023 20:39:14 pm]  - \entityculling-fabric-1.6.1-mc1.18.2.jar (Added)
[05/05/2023 20:39:14 pm]  - \entity_texture_features_fabric_1.18.2-4.3.1.jar (Added)
[05/05/2023 20:39:14 pm]  - \eureka-1.1.0-beta.9.jar (Added)
[05/05/2023 20:39:14 pm]  - \extraalchemy-fabric-1.18.2-1.8.1.jar (Added)
[05/05/2023 20:39:14 pm]  - \fabric-api-0.76.0+1.18.2.jar (Added)
[05/05/2023 20:39:14 pm]  - \fabric-language-kotlin-1.9.4+kotlin.1.8.21.jar (Added)
[05/05/2023 20:39:14 pm]  - \FabricShieldLib-1.7-1.18.2.jar (Added)
[05/05/2023 20:39:14 pm]  - \guarding-1.1.1.jar (Added)
[05/05/2023 20:39:14 pm]  - \indium-1.0.7+mc1.18.2.jar (Added)
[05/05/2023 20:39:14 pm]  - \iris-flywheel-compat-1.18.2-0.1.9-BETA.jar (Added)
[05/05/2023 20:39:14 pm]  - \iris-mc1.18.2-1.6.2.jar (Added)
[05/05/2023 20:39:14 pm]  - \isometric-renders-0.3.2+1.18.jar (Added)
[05/05/2023 20:39:14 pm]  - \justenoughkeys-0.5.3-fabric.jar (Added)
[05/05/2023 20:39:14 pm]  - \keybind_fix-1.0.0.jar (Added)
[05/05/2023 20:39:14 pm]  - \krypton-0.1.9.jar (Added)
[05/05/2023 20:39:14 pm]  - \letmedespawn-1.18.x-1.19.x-fabric-1.0.2.jar (Added)
[05/05/2023 20:39:14 pm]  - \lithium-fabric-mc1.18.2-0.10.3.jar (Added)
[05/05/2023 20:39:14 pm]  - \map-atlases-2.3.0+1.18.jar (Added)
[05/05/2023 20:39:14 pm]  - \mcda-2.0.7.jar (Added)
[05/05/2023 20:39:14 pm]  - \mcdw-5.0.4-1.18.jar (Added)
[05/05/2023 20:39:14 pm]  - \MiningDimensions_Fabric-1.18.2-1.3.10.jar (Added)
[05/05/2023 20:39:14 pm]  - \modmenu-3.2.5.jar (Added)
[05/05/2023 20:39:14 pm]  - \momento-1.0.0.jar (Added)
[05/05/2023 20:39:14 pm]  - \moreculling-1.18.2-0.8.2.jar (Added)
[05/05/2023 20:39:14 pm]  - \morevanillapotions-FABRIC-1.18.2-1.0.jar (Added)
[05/05/2023 20:39:14 pm]  - \multiworldborders-1.4-fabric-1.18.2.jar (Added)
[05/05/2023 20:39:14 pm]  - \neruina-0.1.0+1.18.jar (Added)
[05/05/2023 20:39:14 pm]  - \Oh_The_Biomes_You'll_Go-fabric-1.18.2-1.4.7.jar (Added)
[05/05/2023 20:39:14 pm]  - \Origins-1.18.2-1.4.1.jar (Added)
[05/05/2023 20:39:14 pm]  - \owo-lib-0.7.2-no-cme+1.18.jar (Added)
[05/05/2023 20:39:14 pm]  - \Paxi-1.18.2-Fabric-2.1.1.jar (Added)
[05/05/2023 20:39:14 pm]  - \Pehkui-3.7.3+1.14.4-1.20.jar (Added)
[05/05/2023 20:39:14 pm]  - \phosphor-fabric-mc1.18.x-0.8.1.jar (Added)
[05/05/2023 20:39:14 pm]  - \player-animation-lib-fabric-1.0.2+1.18.jar (Added)
[05/05/2023 20:39:14 pm]  - \realcamera-1.18.2-fabric-0.4.4-alpha.jar (Added)
[05/05/2023 20:39:14 pm]  - \replaymod-1.18.2-2.6.11.jar (Added)
[05/05/2023 20:39:14 pm]  - \RoughlyEnoughItems-8.3.594.jar (Added)
[05/05/2023 20:39:14 pm]  - \seaborgium-mc1.18.2-0.1.3b.jar (Added)
[05/05/2023 20:39:14 pm]  - \servercore-fabric-1.3.5+1.18.2.jar (Added)
[05/05/2023 20:39:14 pm]  - \simplyswords-fabric-1.40-1.18.2.jar (Added)
[05/05/2023 20:39:14 pm]  - \SkyIslands-1.0.0.jar (Added)
[05/05/2023 20:39:14 pm]  - \sodium-fabric-mc1.18.2-0.4.1+build.15.jar (Added)
[05/05/2023 20:39:14 pm]  - \Steam_Rails-1.2.6+fabric-mc1.18.2.jar (Added)
[05/05/2023 20:39:14 pm]  - \TerraBlender-fabric-1.18.2-<IP_ADDRESS>.jar (Added)
[05/05/2023 20:39:14 pm]  - \TheWildBackportAdditions-1.18.2-1.0.2-fabric.jar (Added)
[05/05/2023 20:39:14 pm]  - \tooltipfix-1.0.4-1.18.jar (Added)
[05/05/2023 20:39:14 pm]  - \tournament-1.0.0-beta2+39af2d30ae-fabric.jar (Added)
[05/05/2023 20:39:14 pm]  - \valkyrienskies-118-2.1.0-beta.11.jar (Added)
[05/05/2023 20:39:14 pm]  - \voicechat-fabric-1.18.2-2.4.6.jar (Added)
[05/05/2023 20:39:14 pm]  - \waystones-fabric-1.18.2-10.2.1.jar (Added)
[05/05/2023 20:39:14 pm]  - \wildbackport-1.2.3.jar (Added)
[05/05/2023 20:39:14 pm]  - \xlpackets-1.0.4-1.18.x.jar (Added)
[05/05/2023 20:39:14 pm]  - \YungsApi-1.18.2-Fabric-2.2.9.jar (Added)
[05/05/2023 20:39:14 pm]  - \Zoomify-1.6.0+build.2.jar (Added)
Additional Context
No response

Issue with Guarding.
Incorrectly assumes an entity is a LivingEntity: https://github.com/ExDrill/Guarding/blob/84ffc793e1d908e2d395196ab2288197a882aa62/src/main/java/com/exdrill/guarding/Guarding.java#L54
Unfortunately, it seems unmaintained, and the 1.18 version is lost to git history. You will have to remove it.


Blurred terminal using gpuAcceleration when toggle wrap

Using Toggle Size to Content Width in terminal causes a blur with default terminal.integrated.gpuAcceleration settings - auto. terminal.integrated.gpuAcceleration: off works fine.
https://user-images.githubusercontent.com/60842560/136496752-d73f85c4-8129-4629-844b-6903ebc293db.mp4
Here is the test file.
There are several things in the clip that we can consider to open a new issue, I don't know if they are the same problem here:

[ ] Wrapped terminal cannot trim too long lines. Maybe the auto-fixed dimension is not enough?
[ ] #134623.

Does this issue occur when all extensions are disabled?: Yes
Windows info:
Version: 1.61.0 (system setup)
Commit: ee8c7def80afc00dd6e593ef12f37756d8f504ea
Date: 2021-10-07T18:13:09.652Z
Electron: 13.5.1
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19042

Linux info:
Version: 1.61.0
Commit: ee8c7def80afc00dd6e593ef12f37756d8f504ea
Date: 2021-10-07T18:11:02.929Z
Electron: 13.5.1
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Linux x64 5.11.0-37-generic

the blur is as a result of the canvas getting too wide for Chromium to handle. upgrading to a newer version of windows would fix this.
this will happen less on insider's, where the width fits the content better after some polish work that's been done.


Review

Hello Reviewer, 👋
We are a group of two programmers, @Abe1able and @ilyassatlassi, Looking forward to coding a unique Recipe App called Cookspiration.
We have made a Kanban board to fairly divide tasks among ourselves. Below is the link of that project.
https://github.com/users/Abe1able/projects/2/views/1?layout=board

Hello Reviewer, 👋
We are a group of two programmers, @Abe1able and @ilyassatlassi, Looking forward to coding a unique Recipe App called Cookspiration.
We have made a Kanban board to fairly divide tasks among ourselves. Below is the link of that project.
https://github.com/users/Abe1able/projects/2/views/1?layout=board

Hi Team,
Good job so far, indeed you have spent time on this project!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

Equal distribution ✔
Kanban board usage ✔

Required Changes ♻
Check the comments under the review.

[ ] Your tasks is missing the N + 1 issue and the Unit tests, kindly add them too.

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Hi team,
Great work on making the changes requested by a previous reviewer 👏
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.
Highlights

No linter errors
Descriptive PR

Required Changes ♻
Check the comments under the review.
One of the project requirements for this milestone is that each card should have points associated with it. Each point equals 1 hour of work. Two of your cards are missing this requirement. The card you just added following the first review is missing this and also the Technical requirements card.

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Hi @TEAM,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

Team work ✔
Good implementations ✔

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


LightGBM: Plot Feature importances after model training (similar to sklearn & CatBoost)

Again, the feature is related to issues #992, #981 and #965.
Implementation is similar to https://github.com/wandb/client/pull/1031.

Add lightgbm plot feature importances functionality
Also, notebook to illustrate on how to use this feature: https://github.com/neomatrix369/awesome-ai-ml-dl/blob/master/examples/cloud-devops-infra/wandb/feature-importance/lightgbm_feature_importance_tutorial.ipynb

Works in the W&B Dashboard via local runs:

@vanpelt @lukas Is this good to go?


Improve PushNotificationIOS documentation

The documentation currently list a few but not all of the steps required. This changes completes that list of required project changes.
This addresses #5612

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@respectTheCode updated the pull request.

@facebook-github-bot shipit

Thanks for importing. If you are an FB employee go to Phabricator to review.


openstack-ardana-gerrit: fix resource label

The Jenkins jobs triggered by Gerrit patches must use
a set of Lockable Resources dedicated to Gerrit, labeled
cloud-ardana-gerrit-slot, whereas the periodic Gerrit
Jenkins jobs must use the same Lockable Resources as the
other periodic Ardana jobs, the ones cloud-ardana-ci-slot.

Duplicate of #2906


Add debug/verbose setting for more useful console output

Related issues (if any): #8
Type of issue: ✨Feature Request
Urgency: ⏰Normal
Describe feature: The transpiler configuration settings in package.json should include an optional debug/verbose flag, which when set:

Outputs a list of files matching the specified glob to the console (This may require a dependency on minimatch, but it's a very lightweight package.)
Outputs a line to the console on each invocation of transpile() including (at a minimum) the absolute path of the file being transpiled

Now that I've finished merging in #10, I plan to begin working on this option over the weekend - probably for the next minor release. However, as I think about how to make this setting optimally useful for debugging purposes (both for me and for people using this for their own projects,) I'm realizing that I may need to do some heavy refactoring to avoid spaghettifying the existing code.
Of course, I'm hesitant to succumb to "feature creep" on a package that's supposed to be very simple and lightweight... I mean, as it is, the total size of the package on npm is ~12 KB, and it has no dependencies at all, so I definitely want to resist bloating the package unnecessarily. That said, I think that:

There is still a strong reason to implement an option for more verbose output, given that atom-ts-transpiler is in a sense a "black box" between Atom and the packages that its users are developing. Even diagnosing whether a bug is internal to the package being transpiled vs. the transpiler itself would be a rabbit hole of poking around, trying to figure out what Atom is actually doing and what's going wrong. Adding an option for verbose output would make it more obvious to developers whether the bug is on their end or ours, and if it is on our end, provide better feedback to isolate and resolve the issue.
The refactoring that this would require in order to implement it the way I'm imagining is probably a good idea anyway, and would leverage the fact that atom-ts-transpiler is now written in TypeScript in order to give the program a more intuitive structure. Organizing the code in a slightly more "OOP" way would encapsulate the sort of wonky internals into a form that's easier to maintain, and paves the way for the new debug option perfectly.

I believe my strategy for this feature is going to involve adding glob as what you might call an "optional peer devDependency"... debug mode will certainly never be used by the average end-user, but probably will be used by some Atom package developers. We already resolve the project's node_modules directory in order to require the version of TypeScript that the project uses, so it's no extra work to grab and cache glob at the same time, if it happens to be there and "debug" is set.
One other thing that I'd like to explore for 1.2 is whether the resolving/caching system needs to be as complex as it currently is. I'm planning on taking a look at how Atom/apm resolves packages' dependencies, and whether it's possible for two packages that share a dependency to end up grabbing the same "instance" from the require cache. If it's not, a fair bit of code that deals with managing multiple packages could actually be removed.
Anyway, I don't really expect anyone to read this, I'm mainly jotting it down so that I don't forget my current thought process once I begin working on the changes. I figured I might as well post it as a comment though, to make my plans for the next milestone more obvious.

Based on some brief poking around in Atom's source code, it appears to me that (as I suspected) there is a possibility of "cross-contamination" between two different modules using compatible versions of atom-ts-transpiler. If a module with the same name has already been loaded as a dependency of a different Atom package, and the version number is compatible, Atom will return the already-required version rather than requiring the same module again from a different path. That's smart, and certainly saves memory vs. using the standard npm way of resolving requires, but does mean that atom-ts-transpiler needs to be able to manage cached information related to multiple packages simultaneously.
See https://github.com/atom/atom/blob/e9bf53fc3b28c0c62c76604167aec01d955b889c/src/module-cache.coffee#L170 in atom/atom for Atom's implementation of module caching.
This doesn't actually affect my plans at all, it simply reaffirms the benefit of the refactoring I was already planning on doing, rather than tearing away the "multiple package juggling" to make the program simpler overall.

Apparently I need to take that last comment back: a cursory glance at Atom's source led me to believe that Atom packages could "share" module dependencies, but now that I've tested it, that appears not to be true.
Two "dummy" packages both depending upon atom-ts-transpiler ^1.1.1 were transpiled with the versions from their own respective node_modules folders, despite the version numbers being identical. I must not have looked closely enough at what was actually going on with Atom's module resolution code. Anyway, given that there seems not to be a danger of cross-contamination, that actually makes the spec a whole lot simpler, and takes away the need to get into complicated OOP stuff. Should make the debugger output easier to implement, as well.

Ah, okay. Here's the reason: package-transpilation-registry.js. Transpilers are required by absolute path, not by package name, so there's no danger of module scopes clashing with each other. It should be safe to write atom-ts-transpiler to manage the transpilation of just one package, since a new "instance" will be required for each Atom package that uses it.

I'm actually going to close this for the time being: I've done some more research and realized that the feature, as I envisioned it, may not actually be possible (or might be far more difficult/"bloaty" than it's worth.) I'll continue looking for a way to achieve useful debug output, but as it stands, it seems that the main thing I was hoping to accomplish - tracking the contents of the compile cache to determine which files are already in it, and which match the glob but aren't yet in it - is going to be much more difficult than I imagined, possibly to the point of not being worth it. If I find a way to manage it in a reasonable way, I'll likely re-open this.


Remove sqlRow now!

We know the sqlRow class is writed to used until the time that pluslib add support for models, now the models are supported so sqlRow can be removed from the library (framework 😝).

[ ] Use models instead of sqlRow in example projects
[ ] Then remove it from the library

We are one step closer to solving this! (In 7715922)
How?
The classes: sqlRow and sql_abcol are now deprecated!


in memory zipping

allow users to keep source csv file in memory instead of serializing to disk if compressing
this prevents Google Drive for Desktop from trying to upload the intermediary .csv file before it's zipped

this should use a command line flag to let the user turn on/off, maybe something like
socrata-dump --in-memory ...

done


ERR_STREAM_WRITE_AFTER_END

We use logagent in a container logging using GELF to Graylog, and after working for a while it stars filling container log so fast it fills the docker partition.
This log keeps spamming, restarting container brings it back to working state.
Possibly Unhandled Rejection at: Promise  Promise {
 Error [ERR_STREAM_WRITE_AFTER_END] [ERR_STREAM_WRITE_AFTER_END]: write after end
at writeAfterEnd (_stream_writable.js:266:14)
at RotatingFileStream.Writable.write (_stream_writable.js:315:5)
at OutputFile.eventHandler (/lib/plugins/output/files.js:67:14)
at LogEventEmitter.emit (/node_modules/eventemitter3/index.js:203:33)
at LogEventEmitter.parsedEvent (/lib/core/logEventEmitter.js:22:8)
at processOutput (/bin/logagent.js:619:31) {
code: 'ERR_STREAM_WRITE_AFTER_END'
}
} reason:  Error [ERR_STREAM_WRITE_AFTER_END] [ERR_STREAM_WRITE_AFTER_END]: write after end
at writeAfterEnd (_stream_writable.js:266:14)
at RotatingFileStream.Writable.write (_stream_writable.js:315:5)
at OutputFile.eventHandler (/lib/plugins/output/files.js:67:14)
at LogEventEmitter.emit (/node_modules/eventemitter3/index.js:203:33)
at LogEventEmitter.parsedEvent (/lib/core/logEventEmitter.js:22:8)
at processOutput (/bin/logagent.js:619:31) {
code: 'ERR_STREAM_WRITE_AFTER_END'
}
Error [ERR_STREAM_WRITE_AFTER_END] [ERR_STREAM_WRITE_AFTER_END]: write after end
at writeAfterEnd (_stream_writable.js:266:14)

Hey @mqw ! Thanks for reporting this issue. I'll take a look at it today.
Can you explain to me a bit more about your setup? You're running Logagent as a container in Docker Swarm/Compose or Kubernetes? What container engine are you using, Docker or Containerd? Also, I'd like to know what your logagent.conf looks like, if you're using a custom config.


[Android][Action Button Rendering] [Not able to style the action buttons for android]

Platform
What platform is your issue or question related to? (Delete other platforms).

Android

Author or host
adaptive cards -  in webex android application
Version of SDK
Version: 1.2.6[io.adaptivecards:adaptivecards-android:1.2.6]
Details
I was looking at styling the adaptive cards based on the theme selected for my android application. My android application supports dark and light themes. I am able to style the adaptive-card by passing a config[JSON file with colors configured] to Host Config like below.
val hostConfig = HostConfig.DeserializeFromString(adaptiveCardConfig)
I have three action buttons [Action.ShowCard, Action.Submit, Action.OpenUrl ] in my card. I would like to change the background color, font, shape of the action buttons based on the theme  selected. I tried reading the docs and looked at the samples in github, but did not find a way to do it.
The documentation has a section Native-Styling under android docs which tells me to specify style in my themes.xml file.
@style/adaptiveInlineAction
Specifying a style with this attribute doesn't apply the specified style.
Attached screenshot gives you the preview of the buttons that I am looking at styling.

Can you please let me know if there is an option to style the action buttons?

@almedina-ms can you take a look at this real quick ? Thanks!

The inline action element refers to an action defined in a textblock, if you want to try styling for other actions you can try setting a sentiment and overriding that style. On the other hand, I'm also prototyping more native styling for other elements so expect an update soon

Closing this as it's going to be fixed along with this issue
https://github.com/microsoft/AdaptiveCards/issues/3830


:sparkles: Improve data grid

resolves #3234
What does this pull request change?
This pull request introduces the following improvements to the data-grid:
Most of these changes have been discussed with @yusijs.

✨ Reexport @tanstack/react-table types to ease typing in apps using the data grid
📌 Move eds-core-react to peer dependencies

This is neccessary because EDS uses React Context and the grid and the project should
have the same React instance running. This makes it possible to set EDS Density of the
table above the component.

♻ Move text truncating into default cell to enable overwriting cell content

This enables custom cells like popover, autocomplete or other cells that overflows the cell itself.

🐛 Inherit row background color for pinned cells

This ensures hover color on the whole row when columns are pinned

🐛 Support 100% width

Support string width and height

✨ Allow setting minWidth of table
✨ Expose getRowId callback from react-table
✨ Expose virtualizer ref

This is needed to be able to run "scroll to" functionality in apps.

🐛 Hide virtualizer rows top and bottom rows when not needed

Why is this pull request needed?
In order to implement this in our project, we need to be able to use custom cells, set 100% width and use the EdsProvider with the table. Also, there are some minor bugs discovered during implementation.

I cannot edit reviewers, but I would like a review from @yusijs 😄
It seems like the checks are failing due to a missing secret, but I'm not sure whether it's on my side or yours?

I have added @yusijs as a reviewer 🙂
The checks failing from forked pull requests are on our end. We need to fix the github action, but in the meantime we  can run the tests locally 👍

✅ Lint
✅ Tests
✅ Types

lint/test/types all seems to be in order still 👍

Yes I will merge 👍 Was just trying the build downstream in an app for the final test  but looks good


added dikshtra in java

i have added the code of dijkstra's algorithm in java

#237

@all-contributors please add @SATAKSHI08  for code


Handle duplicate members in cw4-group create

When a cw4-group contract is instantiated with a list of members where some are duplicated, the iterator overwrites any previous member weight, whilst still incrementing the total weight. This PR merges duplicate weights in the create function

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: ueco-jb:x: codehansYou have signed the CLA already but the status is still pending? Let us recheck it.

@codehans will you pick up that PR and add some proper test?

fwiw - i do think this could be considered to be a non-backwards compatible change.
for example, before our audit (see the first issue there) we did not dedup the members list when instantiating a dao that uses cw4-groups. we now do, but were this to land we'd probably stop doing that to be consistent with the new behavior.

apologies @ueco-jb @ezekiiel missed this one. this isn't something we're actively using or particularly precious about. happy to leave as-is, especially as time is fairly scarce these days

This looks like a serious flaw. If you don't mind, I'll pick this up, rebase, add a test, and merge. @codehans do you mind if I push here?

fwiw - i do think this could be considered to be a non-backwards compatible change.

@0xekez That's fair! I don't think we guarantee backwards-compatibility currently (0.* semantic versions). Is this going to cause problems for you?

This looks like a serious flaw. If you don't mind, I'll pick this up, rebase, add a test, and merge. @codehans do you mind if I push here?

go ahead!

@codehans Would you mind signing the CLA thing? I'll need that to merge later.


Fixed month overflow check for UTC option enabled

Came searching this repo for the same issue! Would be nice to have an associated test :)


Slacksend returns null response

Jenkins and plugins versions report:
Jenkins 2.263.2
Slack plugin 2.48
slackResponse = slackSend (baseUrl : slackURL,
teamDomain:'myteam',
channel: slackChannel,
message: 'Hello, world',
iconEmoji: 'jenkins',
botUser: 'false',
token: slackToken,
username: 'Jenkins')
sh"""
echo ${slackResponse}
echo ${slackResponse.channelId} //  channelid is null
echo ${slackResponse.ts} // ts is also null
"""
jenkis logs

echo jenkins.plugins.slack.workflow.SlackResponse@1f6401de
jenkins.plugins.slack.workflow.SlackResponse@1f6401de
echo null
null
echo null
null

did you setup a custom slack app?

No could you guide me to setup
On Wed, Sep 8, 2021, 14:56 Tim Jacomb @.***> wrote:

did you setup a custom slack app?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jenkinsci/slack-plugin/issues/776#issuecomment-915071269,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJDDK34LYDXXW5HNLT44JL3UA4T4ZANCNFSM5DUH4WXQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

https://github.com/jenkinsci/slack-plugin#bot-user-mode

Hi Timja
i created custom app as per above doc and using that token but is failing
with below error
Slack Send Pipeline step running, values are - baseUrl: SlackURL, teamDomain:myDomain, channel: #qe_result_test, color:
, botUser: true, tokenCredentialId: Slack Token, notifyCommitters: false, iconEmoji: jenkins, username: Jenkins, timestamp:
ERROR: Slack notification failed with exception: ok
ERROR: Slack notification failed. See Jenkins logs for details.
Response is null

slackResponse = slackSend (baseUrl : slackURL,
teamDomain:'myDomain',
channel: slackChannel,
message: 'Hello, world',
iconEmoji: 'jenkins',
botUser: 'true',
token: slackToken,
username: 'Jenkins')
//timestamp:ts.toString())
sh"""
echo ${slackResponse}
echo ${slackResponse.ts}
echo ${slackResponse.channelId}
"""

Anything in the logs? Have you invited the app to the channel?

Yes invited
Is mandate to select Custom slack app bot user?
If i select this it will be problematic for others channel notification

there's more features in the bot users so it is recommended.
The 'legacy' one has not been updated by Slack in a long time

if it is set then it will impact  the flow which use legacy app?

not if you leave botUser off globally and only enable it in the jobs you need it.

how to set globally off for botUser and enable in job level
thank you very much


The garden!

This artwork is a beautiful scenery of a garden that randomly generates different flowers and grass on each run I had a great time programming this and learned a lot about the blot ecosystem. I have used my prior experience with Python and HTML to understand the functions and how to use them.

I think this may not quite be there yet. Could you try to make the flowers with outline strokes? The code also seems to rely on AI assistance quite a lot. The idea of drawing a field is nice.


BF2 scenario fails in the wait task

Description
{"task": "<WaitTask: 100>", "event": "Task errored", "logger": "scenario_player.tasks.base", "level": "error", "timestamp": "2019-11-27 06:49:24.854217", "exception": "Traceback (most recent call last):\n  File \"/usr/local/lib/python3.7/site-packages/scenario_player/tasks/base.py\", line 74, in __call__\n    return self._run(*args, **kwargs)\n  File \"/usr/local/lib/python3.7/site-packages/scenario_player/tasks/execution.py\", line 72, in _run\n    gevent.sleep(self._config)\n  File \"/usr/local/lib/python3.7/site-packages/gevent/hub.py\", line 159, in sleep\n    hub.wait(t)\n  File \"src/gevent/_hub_primitives.py\", line 46, in gevent.__hub_primitives.WaitOperationsGreenlet.wait\n  File \"src/gevent/_hub_primitives.py\", line 55, in gevent.__hub_primitives.WaitOperationsGreenlet.wait\n  File \"src/gevent/_waiter.py\", line 151, in gevent.__waiter.Waiter.get\n  File \"src/gevent/_greenlet_primitives.py\", line 59, in gevent.__greenlet_primitives.SwitchOutGreenletWithLoop.switch\n  File \"src/gevent/_greenlet_primitives.py\", line 59, in gevent.__greenlet_primitives.SwitchOutGreenletWithLoop.switch\n  File \"src/gevent/_greenlet_primitives.py\", line 63, in gevent.__greenlet_primitives.SwitchOutGreenletWithLoop.switch\n  File \"src/gevent/__greenlet_primitives.pxd\", line 35, in gevent.__greenlet_primitives._greenlet_switch\ngreenlet.GreenletExit"}

The scenario fails at the wait task here
- serial:
    name: "stop node1"
    tasks:
       - stop_node: 1
       # give it time to shutdown
       - wait: 100

Line 183
Expected Behavior
The wait task should be executed successfully
bf2_long_running_2019_11_27.tar.gz

Related: https://github.com/raiden-network/scenario-player/issues/434

Just leaving the logs for 3rdDecember fail. It is due to the Stop task

{
  "task": "<StopNodeTask: 1>",
  "event": "Task errored",
  "logger": "scenario_player.tasks.base",
  "level": "error",
  "timestamp": "2019-12-03 05:11:07.211497",
  "exception": "Traceback (most recent call last):\n  File \"/usr/local/lib/python3.7/site-packages/scenario_player/tasks/base.py\", line 74, in __call__\n    return self._run(*args, **kwargs)\n  File \"/usr/local/lib/python3.7/site-packages/scenario_player/tasks/raiden_node.py\", line 16, in _run\n    method()\n  File \"/usr/local/lib/python3.7/site-packages/scenario_player/node_support.py\", line 229, in stop\n    ret = self.executor.stop(timeout=timeout)\n  File \"/usr/local/lib/python3.7/site-packages/scenario_player/utils/legacy.py\", line 170, in stop\n    self.wait_for(process_stopped)\n  File \"/usr/local/lib/python3.7/site-packages/mirakuru/base.py\", line 350, in wait_for\n    time.sleep(self._sleep)\n  File \"/usr/local/lib/python3.7/site-packages/gevent/hub.py\", line 159, in sleep\n    hub.wait(t)\n  File \"src/gevent/_hub_primitives.py\", line 46, in gevent.__hub_primitives.WaitOperationsGreenlet.wait\n  File \"src/gevent/_hub_primitives.py\", line 55, in gevent.__hub_primitives.WaitOperationsGreenlet.wait\n  File \"src/gevent/_waiter.py\", line 151, in gevent.__waiter.Waiter.get\n  File \"src/gevent/_greenlet_primitives.py\", line 59, in gevent.__greenlet_primitives.SwitchOutGreenletWithLoop.switch\n  File \"src/gevent/_greenlet_primitives.py\", line 59, in gevent.__greenlet_primitives.SwitchOutGreenletWithLoop.switch\n  File \"src/gevent/_greenlet_primitives.py\", line 63, in gevent.__greenlet_primitives.SwitchOutGreenletWithLoop.switch\n  File \"src/gevent/__greenlet_primitives.pxd\", line 35, in gevent.__greenlet_primitives._greenlet_switch\ngreenlet.GreenletExit"
}

Fails at the stop node task
- stop_node: 1
bf2_long_running_2019_12_03.tar.gz


@craigspaeth: Link underlines should be compatible with newlines

The border-bottom trick to underline links looks bad when links wrap:

Links wrap a lot, especially given the narrow content area. The default behavior looks slightly less bad:

...but still looks bad. I made the easy change, but I'd rather fix the underline thickness. Is that possible?

You could use a background image linear gradient, which is what force has mostly switched to doing: https://github.com/artsy/force/blob/1f56f84b151adf8cf276169a0387af6937ccc49c/components/stylus_lib/index.styl#L193-L198
(Might need some tweaking)

:+1: thanks!

Thanks @dzucconi. Now looks like:

This is ahem not obvious, so I anticipate weirdness. However, it seemed OK according to my quick check in Chrome.


The page shows "No shop provided"

Current Shopify CLI version: 3.64.1
current nodejs version is 20
English：Hello, why does the shopify-app-template-node code run without moving anything, the page shows: "No shop provided", is there a solution

Here is the code for shopify.js
import { BillingInterval, LATEST_API_VERSION } from "@shopify/shopify-api";
import { shopifyApp } from "@shopify/shopify-app-express";
import { SQLiteSessionStorage } from "@shopify/shopify-app-session-storage-sqlite";
import { restResources } from "@shopify/shopify-api/rest/admin/2023-04";

const DB_PATH = `${process.cwd()}/database.sqlite`;

// The transactions with Shopify will always be marked as test transactions, unless NODE_ENV is production.
// See the ensureBilling helper to learn more about billing in this template.
const billingConfig = {
  "My Shopify One-Time Charge": {
    // This is an example configuration that would do a one-time charge for $5 (only USD is currently supported)
    amount: 5.0,
    currencyCode: "USD",
    interval: BillingInterval.OneTime,
  },
};

const shopify = shopifyApp({
  api: {
    apiVersion: LATEST_API_VERSION,
    restResources,
    billing: undefined, // or replace with billingConfig above to enable example billing
  },
  auth: {
    path: "/api/auth",
    callbackPath: "/api/auth/callback",
  },
  webhooks: {
    path: "/api/webhooks",
  },
  // This should be replaced with your preferred storage strategy
  sessionStorage: new SQLiteSessionStorage(DB_PATH),
});

export default shopify;

I opened it through him, directly or in shopify: No shop provided
➜  Local:   http://localhost:53384/

Hi @LiuYuYang01, thank you for opening this issue. Which URL did you use to open the app?

I opened it through him, directly or in shopify: No shop provided
➜ Local: http://localhost:53384/

@LiuYuYang01 could you try using the preview functionality of the CLI? Try pressing p after running dev.

Hi LiuYuYang01,
This issue occurs because the shop parameter is not defined in the URL. To install the app on your Shopify store, you need to include the shop parameter in the URL.
Please use the following URL, replacing "your_shop_url" with your actual Shopify store URL:
http://localhost:53384/?shop=your_shop_url.myshopify.com

This will redirect you to the Shopify installation page, where you can complete the app installation process.


Plugin no longer showing on Runelite 1.8.33

On the latest update, the plugin is no longer showing.

https://github.com/runelite/plugin-hub/pull/3303


Bump node to 10.0.0 and yarn to 1.6.0

I was going to do these bumps in separate PRs, but yarn install is failing on Travis when just bumping node alone, so let's see if also bumping yarn at the same time helps.

Actually looking at the error in Travis that I got when just bumping node by itself, it was probably just a random network error or some issue on yarn's end (rather than an issue of trying to bump node without bumping yarn), but whatever.
The error:
$ yarn install
yarn install v1.5.1
(node:7044) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
error An unexpected error occurred: "https://registry.yarnpkg.com/async-validator/-/async-validator-1.8.2.tgz: Request failed \"503 Service Unavailable\"".
info If you think this is a bug, please open a bug report with the information provided in "/home/travis/build/davidrunger/david_runger/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
The command "yarn install" exited with 1.


More binary release targets

Cross-compiling is really a headache:
REFs:

https://github.com/rust-lang/cargo/issues/4133
https://github.com/swc-project/swc/blob/main/.github/workflows/publish-node.yml
https://github.com/kubewarden/policy-server/blob/main/.github/workflows/container-image.yml
https://github.com/ajeetdsouza/zoxide/blob/main/.github/workflows/release.yml

Closed by cdb551a 01cb196 and 26d8f13

Add aarch64-pc-windows-msvc ?


Build broken with "TypeError: _interopRequireDefault is not a function"

🐛 Bug Report
Initial installation of docusaurus is unable to build
Have you read the Contributing Guidelines on issues?
Yes
To Reproduce
Install docusaurus using the installation instructions

npx @docusaurus/init@latest init my-website classic
cd my-website
yarn build

Expected behavior
Build is successful
Actual Behavior
Error
TypeError: _interopRequireDefault is not a function
(undefined) TypeError: _interopRequireDefault is not a function
at Object. (main:36883:17)
at webpack_require (main:21:30)
at Object. (main:17523:53)
at webpack_require (main:21:30)
at Module. (main:54339:11)
at webpack_require (main:21:30)
at main:85:18
at main:88:10
at Script.runInContext (vm.js:142:18)
at Script.runInNewContext (vm.js:147:17)
error building locale=en
Your Environment

Docusaurus version used: 2.0 alpha 70
Environment name and version yarn v1.22.4, node v14.8.0
Operating system and version (desktop or mobile): macOS and BitBucket Pipeline with default docker container

@reubenbijl I have the same situation here. The build fails inside a docker container but it works on the host machine
Have you managed to solve it?

Are you on alpha 70?
Wonder if it's not related to using symlinks? Reminds me another issue
Le mar. 23 févr. 2021 à 13:43, Thiago Alves Silva<EMAIL_ADDRESS>a écrit :

@reubenbijl https://github.com/reubenbijl I have the same situation
here. The build fails inside a docker container but it works on the host
machine
Have you managed to solve it?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/facebook/docusaurus/issues/4272#issuecomment-784174477,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFW6PUXDXRHLTMOBIOZ3NLTAOPFLANCNFSM4YBUWI2Q
.

@slorber  Yes, alpha 70
I noticed that when I add docusaurus2-dotenv to the dependencies list I get the error.
This is my package.json:
{
  "name": "devportal",
  "version": "0.0.0",
  "private": true,
  "scripts": {
    "docusaurus": "docusaurus",
    "start": "docusaurus start",
    "build": "docusaurus build",
    "swizzle": "docusaurus swizzle",
    "deploy": "docusaurus deploy",
    "serve": "docusaurus serve",
    "clear": "docusaurus clear"
  },
  "dependencies": {
    "@docusaurus/core": "2.0.0-alpha.70",
    "@docusaurus/preset-classic": "2.0.0-alpha.70",
    "@mdx-js/react": "^1.6.21",
    "clsx": "^1.1.1",
    "core-js": "^3.8.3",
    "docusaurus-lunr-search": "^2.1.9",
    "docusaurus-plugin-sass": "^0.1.11",
    "docusaurus2-dotenv": "^1.4.0",
    "mobx": "^6.0.4",
    "react": "^16.8.4",
    "react-dom": "^16.8.4",
    "react-s-alert": "^1.4.1",
    "react-select": "^4.0.2",
    "styled-components": "^5.2.1",
    "swagger-i18n-extension": "^1.0.1",
    "swagger-ui-react": "^3.40.0"
  },
  "browserslist": {
    "production": [
      ">0.5%",
      "not dead",
      "not op_mini all"
    ],
    "development": [
      "last 1 chrome version",
      "last 1 firefox version",
      "last 1 safari version"
    ]
  }
}

I don't know what is this dotenv plugin or what it does 😅

It is mentioned here:
https://v2.docusaurus.io/community/resources#integrations

@thiagoalves accept almost any community link PR on this page, does not mean we approve or reviewed the code too deeply :)
I won't be able to tell how this plugin affects your Docusaurus unfortunately

For the record: I have upgraded some packages and the problem seems to be gone:
"@mdx-js/react": "^1.6.21" -> "^1.6.22",
"docusaurus-lunr-search": "^2.1.9" ->  "^2.1.10"
"core-js": "^3.8.3" -> "^3.9.0"
"mobx": "^6.0.4" -> "^6.1.7"
"react-select": "^4.0.2" -> "^4.1.0"
"swagger-ui-react": "^3.40.0" -> "^3.43.0"


BigQuery builds seem to be very broken

e.g.

https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/1960
https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/1963

There are many more in the last 48 hours (sorry I don't have time to gather them all right now).
We should diagnose and fix ASAP.

This somehow fixed itself like magic (I made a small PR #3468 that doesn't seem big enough to have fixed these breakages)

#3468 explicitly fixed the breakage in test_dump_table_w_public_data.  The one in test_list_tables might be an eventual-consistency issue?


An organization slug is required (provide with --org) on release android

I resolve this issue in my project to make these changes.
first I go to https://sentry.io/settings/masaar/ in setting top organization slug, then copy organization slug and add org: __SLUG__ line
config.plugins.push(
    new SentryCliPlugin({
      urlPrefix: SENTRY_PREFIX,
      rewrite: true,
       org: '__SLUG__',
      cleanArtifacts: true,
      release: `com.iklix.klix@${appVersion}+${buildNumber}`,
      dist: `${buildNumber}.${platform}`,
      ignoreFile: '.sentrycliignore',
      include: [dist, join(dist, SOURCEMAP_REL_DIR)],
    })
  );

then I get this error  error: A project slug is required. then I resolve this error using to add org: __SLUG__ line in
config.plugins.push(
    new webpack.SourceMapDevToolPlugin({
      org: '__SLUG__',
      append: `\n//# sourceMappingURL=${SENTRY_PREFIX}[name].js.map`,
      filename: join(SOURCEMAP_REL_DIR, '[name].js.map'),
    })
  );

now my project is successful build release version.
Reference : https://github.com/getsentry/sentry-cli/issues/179
sorry for weak English.

@ali4fun so is this an issue or do you just share the solution to your issue?


subtoltals not work with categorical NaN values in groupby:

subtoltals not work with categorical NaN values in groupby:
ValueError: Length of values (7) does not match length of index (99999)
In example (7)-real rows grouped count. (99999) - any big number, length of category, included NaN values/rows.
Maybe solve this error by add parameter "observed=True" onto groupby method.

@kraevedalex -- could you share a sample CSV that fails please? That will help me reproduce the error.


Update hydrogen and remove @parcel/watcher

WHY are these changes introduced?
Regular update of hydrogen version.

WHAT is this pull request doing?

Update hydrogen to latest
Remove an unused dependency

How to test your changes?

Post-release steps

Measuring impact
How do we know this change was effective? Please choose one:

[ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
[ ] Existing analytics will cater for this addition
[ ] PR includes analytics changes to measure impact

Checklist

[ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
[ ] I've considered possible documentation changes

/snapit


Remove Simple API cache files for alternative indexes in cache clean

Summary
The simple-v9 directory was missing the index segment. See before:

And after:

Every other bucket has this index segment for non-PyPI indexes, e.g.:

Closes https://github.com/astral-sh/uv/issues/5352.

Adding tests in a follow-up PR because I want to test more behavior.


docs: fixed text typo in README.md file

cloud computer has been fixed to cloud computing.

GJ First Pull Req


Heroku CD Application Failure

To be put on the backburner until main application is finished.
Followed both this CLI version guide AND this simpler GUI video walkthrough on how to set up CD with heroku.
Heroku app build passes and deploys successfully but the application always shows an Application Error on the actual heroku URL for some reason. For control, I ran through both guides with the sample-todos meteor app and it succeeded in deploying both times.
I have searched through the both Heroku Papertrail and Deployment logs to no avail as there were no application specific errors at all.

Identified that the root cause of the deployment failure is the interaction between server/main.js process and the backend heroku MongoDB.

Identified that the dyno boot time limit of 60 seconds was not sufficient in allowing server/main.js to pre-treat the CSV data before insertion into MLab MongoDB. Fixed by increasing Heroku dyno boot timeout to 180 seconds using Heroku's Boot Timeout tool. As suggested by Heroku, this is a temporary solution, realistically we would set a proper pipeline to enable pre-booting but that might lead to multiple versions of the app being served. To just avoid the weeds for this project, this will suffice for now. 😅


Error when loading saved filter settings

This was caused by using sepcific ascii encoding when saving the settings files.  It broke with the Py2.7 to Py3 port.  Removal of the ascii encode fixed it.


Windows mac tests - Fixed

Pull request
Please confirm that this pull request has done the following:

[x] Tests added
[x] Documentation added (where applicable)
[x] Example added (either to an existing notebook or as a new notebook, where applicable)
[x] Description in CHANGELOG.rst added

Might need to ignore output of some cells to make notebook tests pass


Fix Rake task enhancement for compatibility with Rails 6.1+

Rails 6.1 deprecated the db:structure:dump Rake task in favor of a combined db:schema:dump task: https://github.com/rails/rails/pull/39470 Even internally, tasks like db:migrate are now invoking db:schema:dump after the migration instead of switching between db:{structure,schema}:dump conditionally.
However, activerecord-clean-db-structure was hooking explicitly into the db:structure:dump task. This meant that your db/structure.sql would no longer be reformatted by the gem after upgrading to Rails 6.1+.
There was an existing pull request at https://github.com/lfittl/activerecord-clean-db-structure/pull/26 that just swapped the task name, but (a) that hasn't been merged in over a year and (b) it doesn't bother with a version check. The present commit improves upon the other PR by conditionally switching the task based on the version of the activerecord gem.

Closing this in favor of #32, because I originally opened this against the fork's master branch instead of creating a separate branch. D'oh.


Slow computing times running on Docker

Running GridLAB-D validation gives inconsistent timing results on docker.
When docker has been restarted validation time with -T 3: ~ 204s
After multiple runs (inconsistent as to what event reduces the time) in the same image the time increases with -T 3: ~1000s
No timing issues found through the host system or VMware Centos7
Every odd time validation is executed, segmentation error occurs right away:
/usr/local/bin/gridlabd: line 360: 98768 Segmentation fault      "$bindir/gridlabd.bin" "$@"

And executing validation command again - allows to validate at ~200s time.

Attempts for slowing down docker without a slow down of validation:

Running make install again between validations
Killing the validation process and following by validation
Exiting the image and starting a new one

Found the problem occurring when the computer goes to sleep and then used again. Work-around is through re-starting the docker for now.

Good discussion on this topic: https://hackernoon.com/another-reason-why-your-docker-containers-may-be-slow-d37207dec27f

Some evidence has emerged recently that now centos:7 is slow all the time.

Suggestion on this: modify exec_clock() so it does not call ftime() when the profiler is off, and modify all the autotests so they don't use the profiler. Remember to add a caveat to the global profiler docs to note that performance may be affected by use of the profiler.


Ensure reproducible artifact resolution by setting ResolutionStrategy.failOnNonReproducibleResolution()

See the following dsl docs for details:
https://docs.gradle.org/current/dsl/org.gradle.api.artifacts.ResolutionStrategy.html#org.gradle.api.artifacts.ResolutionStrategy:failOnNonReproducibleResolution()
Without this setting artifact resolution may change depending on when the build is executed, and what artifacts are available in the artifact repository at that time.
This setting helps ensure that subsequent builds for the same Git commit will resolve to the same artifact dependency graph.

I like this proposal. Thanks.


Github page having 502 errors

http://ramdajs.com/repl/?v=0.22.1

see https://github.com/ramda/ramda/issues/1873


fix(events): add removal of listeners on close

Removes listeners on close - removes only the listeners that have been
added with the event module

Prevents the listener memory leak when restarting the server without restarting the program.

@trs @Jl14Salvador


Entitlement Service Service Principal Is not authorized to call ReadAll for GraphAPI

Service Principal Needs granted access to the following Graph APIs.
Directory.Read.All
User.Read.All
This change has to occur in the service-principal module which currently looks like the following.
resource "azuread_application" "sp" {
count = local.sps_to_create
name  = var.display_name
}
This means that support in the module for resources are not built into the module yet.  The resource needs to have a section that looks somewhat like the following which is pulled from the ad-application module.
required_resource_access {
resource_app_id = var.resource_app_id
resource_access {
  id   = var.resource_role_id
  type = var.resource_access_type
}

}
You can see that this only supports then 1 Resource Type, but we have multiple.  It will have to be extended to look more like the following.
dynamic "required_resource_access" {
for_each = local.required_resource_access
content {
  resource_app_id = required_resource_access.value.resource_app_id

  dynamic "resource_access" {
    for_each = required_resource_access.value.resource_access

    content {
      id   = resource_access.value.id
      type = resource_access.value.type
    }
  }
}

}

This issue is actually a feature requirement necessary to support additional API's for Entitlements.  Entitlements has the need to be able to access MS Graph API and the service principal being used needs privileges to retrieve information from this API.

@daniakodeih This feature has been successfully added to the infrastructure.


Importing JsValue in a proc_macro causes a compilation error on recent nightly's

Thanks for the crate! I noticed a regression on recent Rust nightly's that causes a linker error when using stylist.

Rust regression issue: https://github.com/rust-lang/rust/issues/111888

JsValue inclusion: https://github.com/futursolo/stylist-rs/blob/fbd788f0a9a63ccadf6a25e028829a25224140eb/packages/stylist-core/src/error.rs#L19
(this type is later imported by stylist-macros but, as far as I know, this variant won't be constructed there)

I'll work on a PR to see if JsValue can be removed for proc_macro purposes.

Is this a duplicate of #114?

Is this a duplicate of #114?

Almost certainly yes!

I have submitted a pull request awaiting code review from @WorldSEnder.
Until this is mitigated from stylist, there is a comment in the compiler regression issue about how to mitigate the impact by switching the linker to lld until Rust compiler is fixed.

solution with lld doesn't work for me but adding this in Cargo.toml with rust 1.70 helps me to solve this issue
[profile.dev.package.wasm-bindgen]
debug-assertions = false

Same error here, I can't compile stylist.
Im on rust 1.70

After going back to rust 1.69, I can confirm that it is a version issue (it worked with 1.69)

Stylist v0.12.1 has been released, which should also mitigate this issue from within stylist.
Affected users can run cargo update in their projects and it should pick up the new version automatically.

This current workaround has a couple requirements:

For single crate applications, you need to use edition 2021.
For applications inside a workspace, you need to enable cargo resolver 2. (See #129)

In addition, since Rust 1.72 has fixed this regression and this workaround is no longer needed, I do plan to remove the workaround.
The current plan is once 1.72 has been released for 6 months, we bump the MSRV requirement to 1.72 to avoid this regression and remove the workaround.


Using Firefox View Makes It Appear In Tab List

When you open QTS, it shows just the open tabs from the browser's tab bar. However, if you select the Firefox View icon at any point, from that point on Firefox View will appear as a tab in the QTS tab list, right after the first tab in the tab bar. This is probably not expected/wanted behavior.
Maybe we can just skip over it in QTS? We could definitely skip over the URL, which is about:firefoxview-next, but that might not be what's wanted if a user intentionally opens Firefox View in a tab for whatever reason.

I would say the latter, it being accessible only through an icon seems like mozilla didn't intend for it to be accessed directly. Might as well keep it consistent.
Users interested in the former behavior can set a bookmark shortcut to it or something like it.

I've added a basic option to filter Firefox View from the list. It's enabled by default and simply skips about:firefoxview-next. I think this should probably be enough.

Firefox View's URL has changed to about:firefoxview, so the filtering code needs to be updated.
Also, it seems Firefox View can't be disabled from about:config anymore.


Improve MoleBox packer detection.

This PR introduces the following changes:

Removes a redundant detection of a BitArts packer. It is covered by the detections of Crunch (BitArts is a company that produced Crunch packer).
Adds two new generic detections for MoleBox virtualizer/packer.
Adds detection for MoleBox v4.2321
Adds detection for MoleBox v2.3.6

The tests are added here.

Thank you for the improvements! Let's run TeamCity tests.


Question: :style directive

Am I correct in understanding that the :style directive works with a property like a string?
If so, can we improve the functionality a bit and accept the camelCase objects keys and automatically insert the kebab-case?

Can you give an example?

@dy
Of course
<header class="navbar is-flex p-0 pt-2 pb-2"
        :style="{
          color: '{{$c->fontColorify('header-font-color')}}',
          backgroundColor: '{{$c->backgroundColorify('header-background-color')}}'
        }"
>
...
</header>

This code didn't set background-color

Thanks, done!


Research: Winnowing: Local Algorithms for Document Fingerprinting

sigmod03

@SnoozeThis wait for 1 day

(https://snoozeth.is/lA9j1p9FLbY) I will wait until Wed, 07 Dec 2022 19:35:31 UTC and then reassign to you.


pin phoenix js until path issue is resolved

Travis CI tests passing would confirm this works, see the following issue for info: https://github.com/phoenixframework/phoenix/issues/3445

the travis tests passed, merging


Add an event target: Prompted for a rationale

This issue was discovered by @camgnostic as he was working on event deletion
To reproduce the issue

Find (or create and save) an indicator with one or more Event targets.
Reopen the indicator and visit the Targets tab
Click "Add an event" button just underneath the target table.

Expected behavior: A new event row is added.
Observed behavior:

I'm prompted for a rationale, as if I had clicked the save button, like so:

If I fill out the rationale field and click OK, I get no system message, but the new event row is added.

Acceptance criteria

[ ] 1. If I click "Add an event", a new event row is added, just as it happens on Production
[ ] 2.  IF there are no linked results, THEN I get the usual "Success, form data saved" message.
[ ] 2.2. IF there are linked results, THEN I am prompted for a rationale AND the change is logged in the program's change log, including the rationale.

QA - PASSED

[ ]  1. If I click "Add an event", a new event row is added, just as it happens on Production
[ ]   2.  IF there are no linked results, THEN I get the usual "Success, form data saved" message.
[ ]  2.2. IF there are linked results, THEN I am prompted for a rationale AND the change is logged in the program's change log, including the rationale.


SUBMARINE-424. Enable scala style check in github actions

What is this PR for?
add some scala style check rule from http://www.scalastyle.org/rules-1.0.0.html
enable it in the GitHub workflow
What type of PR is it?
feature
Todos
What is the Jira issue?

Open an issue on Jira https://issues.apache.org/jira/browse/SUBMARINE-424

How should this be tested?
pass github actions
Screenshots (if appropriate)
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

cc @liuxunorg @yuanzac


HCI - ProPhase User Requesting Login Access to RS

Problem Statement
We received a request in the RS inbox from Matthew Chriscoe, asking for a login for the HCINTEGRATIONS sender account.
What you need to know
Currently, the HCINTEGRATIONS Sender group does not exist in Okta and will need to be created.
Acceptance Criteria

[ ] User is able to log into the RS dashboard and access their Submission History

To Do

[x] Create Okta group for HCINTEGRATIONS Sender
[x] Add user<EMAIL_ADDRESS>
Additional Comments
Should Sender groups be created in Okta as part of the onboarding process?

Group created.
User created and activation email sent.


Merge upstream to vllm?

Hey! Amazing project. Wanted to know if you are considering merging this upstream into vllm? Or will it be maintained seperate from it?

Hey, thanks for your interest! We will maintain this as a separate project, and it will support not only vLLM but also other different serving engines like SGLang or TGI in the future.
We are also working closely with the vLLM team, and they might also import LMCache as a library to support some functionalities in vLLM later.

Oh cool! Thanks for clarifying.


Ref. "update a record in an elastic table"

Ref. this issue.
Summary: updating one column in elastic table record with Power Automate causes data in all other columns to be wiped/erased.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 430deb7b-cad7-a516-222d-d3507b6912b9
Version Independent ID: 430deb7b-cad7-a516-222d-d3507b6912b9
Content: Use elastic tables using code - Power Apps
Content Source: powerapps-docs/developer/data-platform/use-elastic-tables.md
Service: powerapps
Sub-service: dataverse-developer
GitHub Login: @pnghub
Microsoft Alias: gned

Thanks for your comment, @AndrewElans. This issue has been assigned to the doc author for review.

The same bahaviour is true for web api operation

With Dataverse Web API both Upsert and Update use the PATCH HTTP method.
The difference is that Update must use the If-Match: * request header. This prevents an Upsert from occurring.
An Upsert doesn't use the If-Match: * request header.
With elastic tables, Upsert operations will overwrite existing values.
In Power Automate, I believe the 'Update a row' action is using PATCH without the If-Match: * request header, which makes it an Upsert.
I'll loop in the people to see how to best make this visible to people using Power Automate with elastic tables.

Thanks, @JimDaly.
I've just tested the web api operations on the elastic table. Providing the result for reference, basically as explained in this para.

PATCH with header If-Match: * updates only the selected field of the existing entity.
PATCH without header If-Match: * updates ALL fields of the existing entity, including "Created On". Fields that are not included in the Body are set to null.
PUT updates only selected field

Power Automate flow though shall be fixed.

I've looped in the teams responsible for the documentation here:

Create and edit elastic tables - Power Apps | Microsoft Learn
Use a flow to update a row in Dataverse - Power Automate | Microsoft Learn

But I think this is a bug. Until it is fixed, I think the work around is to exactly what you shouldn't do with standard tables:

Retrieve all the columns
Apply changes to that set,
Update to all columns

There isn't anything actionable for this article. It explains the API behavior correctly. Closing this.