Ingest liquidity pool operations

CAP38 introduces two new operations which act on liquidity pools. There is the deposit operation which allows an account to deposit reserve assets into a liquidity pool in exchange for pool shares. And there is the withdrawal operation which allows an account to claim reserve assets for the underlying pool shares.
Also, the change trust operation will be extended to allow the creation, modification, and deletion of pool share trust lines.
Below you can find the JSON definition for the withdrawal and deposit operation objects.
Deposit Liquidity Operation JSON
{
  "id": "3697472920621057",
  "paging_token": "3697472920621057",
  "transaction_successful": true,
  "source_account": "GBB4JST32UWKOLGYYSCEYBHBCOFL2TGBHDVOMZP462ET4ZRD4ULA7S2L",
  "type": "liquidity_pool_deposit",
  "type_i": 22,
  "created_at": "2021-11-18T03:47:47Z",
  "transaction_hash": "43ed5ce19190822ec080b67c3ccbab36a56bc34102b1a21d3ee690ed3bc23378",
  "liquidity_pool_id": "abcdef",
  "reserves": [
    {
      "asset": "JPY:GBVAOIACNSB7OVUXJYC5UE2D4YK2F7A24T7EE5YOMN4CE6GCHUTOUQXM",
      "max_deposit_amount": "1000.0000005"
    },
    {
      "asset": "EURT:GAP5LETOV6YIE62YAM56STDANPRDO7ZFDBGSNHJQIYGGKSMOZAHOOS2S",
      "max_deposit_amount": "3000.0000005"
    }
  ],
  "min_price": "0.2680000",
  "min_price_r": {
    "n": 67,
    "d": 250
  },
  "max_price": "0.3680000",
  "max_price_r": {
    "n": 73,
    "d": 250
  },
  "reserves_deposited": [
    {
      "asset": "JPY:GBVAOIACNSB7OVUXJYC5UE2D4YK2F7A24T7EE5YOMN4CE6GCHUTOUQXM",
      "amount": "983.0000005"
    },
    {
      "asset": "EURT:GAP5LETOV6YIE62YAM56STDANPRDO7ZFDBGSNHJQIYGGKSMOZAHOOS2S",
      "amount": "2378.0000005"
    }
  ],
  "shares_received": "1000"
}

Withdraw Liquidity Operation JSON
{
  "id": "3697472920621057",
  "paging_token": "3697472920621057",
  "transaction_successful": true,
  "source_account": "GBB4JST32UWKOLGYYSCEYBHBCOFL2TGBHDVOMZP462ET4ZRD4ULA7S2L",
  "type": "liquidity_pool_withdraw",
  "type_i": 23,
  "created_at": "2021-11-18T03:47:47Z",
  "transaction_hash": "43ed5ce19190822ec080b67c3ccbab36a56bc34102b1a21d3ee690ed3bc23378",
  "liquidity_pool_id": "abcdef",
  "reserves": [
    {
      "asset": "JPY:GBVAOIACNSB7OVUXJYC5UE2D4YK2F7A24T7EE5YOMN4CE6GCHUTOUQXM",
      "min_amount": "1000.0000005"
    },
    {
      "asset": "EURT:GAP5LETOV6YIE62YAM56STDANPRDO7ZFDBGSNHJQIYGGKSMOZAHOOS2S",
      "min_amount": "3000.0000005"
    }
  ],
  "shares": "200",
  "reserves_received": [
    {
      "asset": "JPY:GBVAOIACNSB7OVUXJYC5UE2D4YK2F7A24T7EE5YOMN4CE6GCHUTOUQXM",
      "amount": "993.0000005"
    },
    {
      "asset": "EURT:GAP5LETOV6YIE62YAM56STDANPRDO7ZFDBGSNHJQIYGGKSMOZAHOOS2S",
      "amount": "2478.0000005"
    }
  ]
}

Here's how the change trust operation will look like when performed against a pool share trustline:
{
  "id": "157639717969326081",
  "paging_token": "157639717969326081",
  "transaction_successful": true,
  "source_account": "GBBWI7TEVQBPEUXKYNGI3GBAH7EHFEREONKK3UK56ZSLJIDIYHQJCVSG",
  "type": "change_trust",
  "type_i": 6,
  "created_at": "2021-08-04T20:01:24Z",
  "transaction_hash": "941f2fa2101d1265696a3c7d35e7688cd210324114e96b64a386ab55f65e488f",
  "asset_type": "liquidity_pool_shares",
  "liquidity_pool_id": "abcdef",
  "limit": "1000",
  "trustor": "GBBWI7TEVQBPEUXKYNGI3GBAH7EHFEREONKK3UK56ZSLJIDIYHQJCVSG"
}

Tasks:

[ ] Update operations ingestion processor to support new deposit and withdraw liquidity operations
[ ] Update operations ingestion processor to support change trust operation on pool shares
[ ] Allow lookup of transactions and operations by pool id (this will require something like ClaimableBalancesTransactionProcessor but for liquidity pools)
[ ] Add a fuzzing test if possible

@tamirms I think "min_amount" should be renamed to "min_withdraw_amount" to make it consistent with "max_deposit_amount". Thoughts?

In fact, I would probably do:
  "reserves_min": [
    {
      "asset": "JPY:GBVAOIACNSB7OVUXJYC5UE2D4YK2F7A24T7EE5YOMN4CE6GCHUTOUQXM",
      "amount": "1000.0000005"
    },
    {
      "asset": "EURT:GAP5LETOV6YIE62YAM56STDANPRDO7ZFDBGSNHJQIYGGKSMOZAHOOS2S",
      "amount": "3000.0000005"
    }
  ],

instead of
  "reserves": [
  {
    "asset": "JPY:GBVAOIACNSB7OVUXJYC5UE2D4YK2F7A24T7EE5YOMN4CE6GCHUTOUQXM",
    "min_amount": "1000.0000005"
  },
  {
    "asset": "EURT:GAP5LETOV6YIE62YAM56STDANPRDO7ZFDBGSNHJQIYGGKSMOZAHOOS2S",
    "min_amount": "3000.0000005"
  }
],

and
```
"reserves_max": [
{
  "asset": "JPY:GBVAOIACNSB7OVUXJYC5UE2D4YK2F7A24T7EE5YOMN4CE6GCHUTOUQXM",
  "amount": "1000.0000005"
},
{
  "asset": "EURT:GAP5LETOV6YIE62YAM56STDANPRDO7ZFDBGSNHJQIYGGKSMOZAHOOS2S",
  "amount": "3000.0000005"
}

],

instead of

"reserves": [
{
  "asset": "JPY:GBVAOIACNSB7OVUXJYC5UE2D4YK2F7A24T7EE5YOMN4CE6GCHUTOUQXM",
  "max_deposit_amount": "1000.0000005"
},
{
  "asset": "EURT:GAP5LETOV6YIE62YAM56STDANPRDO7ZFDBGSNHJQIYGGKSMOZAHOOS2S",
  "max_deposit_amount": "3000.0000005"
}

],

This change:
1. removes redundancy (`min_` and `max_` prefixes)
2. it simplifies the types used by the SDK (at least in Go, which uses struct tags for json marshalling)

@2opremio sounds good to me. do you have any objections to this API change @marcelosalloum @paulbellamy ?

@tamirms regarding:

Allow lookup of transactions and operations by pool id (this will require something like ClaimableBalancesTransactionProcessor but for liquidity pools)

Is querying by transaction and operation part of the MVP? I think it will spare us a day or two

Is querying by transaction and operation part of the MVP? I think it will spare us a day or two

we will need to implement the db tables and ingestion for the querying in the MVP because otherwise it will require us to reingest history which is going to be burdensome on horizon operators

ok, will do

The changes to reserves_max and reserves_min LGTM!


Update draw.io web version

Try to find a way to use a newer version of draw.io web where the plugin is still enabled by default on first load.
Possible options:

Wait for a new release of draw.io web where custom plugins can be enabled and loaded on first load
Fork the draw.io web version and embed our plugin as a standard (not custom!) plugin. Please check beforehand whether bundled plugins (already existing ones in draw.io) can be enabled on first load by default!

Closed by #133.


Add codeowners

Codecov Report

Merging #209 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #209   +/-   ##
=======================================
  Coverage   88.95%   88.95%
=======================================
  Files          24       24
  Lines         806      806
  Branches      105      105
=======================================
  Hits          717      717
  Misses         58       58
  Partials       31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5b6b72...9be249e. Read the comment docs.


After deploying to Azure login doesn't work

Not sure if I did anything wrong. I tried all versions starting with 12. It works fine locally, I am able to log in, do debugging in VS 2017. When I deploy to Azure, there are issues:

Identity server page has distorted layout, different from what I see at localhost:5000, there is missing top navigation bar. Here is URL: http://identityapp13.azurewebsites.net/home

Clicking Login in ClientApp doesn't do anything. I tried to do remote debugging but for some reason I couldn't make it work (still learning Angular/bower/etc.). Here is URL: http://clientapp13.azurewebsites.net/home

for version 15 ClientApp was not loading at all (error processing your request). Here is URL: http://clientapp15.azurewebsites.net/home

Please advise.
Thank you,
Michael

The first 2 issues was related to Content Security Policy. Changing references from remote sources of css and scripts to local resolved problem.

Glad you found an answer to your first two item. Have you tried changing the ASPNETCORE_ENVIRONMENT environment var to Development to get more details on the third?

Yes, it is the same as #29. I didn't change the variable; it is still Development, but I get the message to change it on page. Sorry, I don't know what to do; I am  not so strong in latest technologies, haven't programmed for 12 years :(

I closed #29 and opened this one back up since I believe they are different issues.
When you publish to Azure the variable isn't set to development it is set to production. Check out this page on the docs for how to put the site into development mode. Once you do that we should get a more detailed error message that will help find the issue.

I set variable. This is what I see. Any suggestion what to try?
System.AggregateException: One or more errors occurred. (Webpack dev middleware failed because of an error while loading 'aspnet-webpack'. Error was: Error: Cannot find module 'aspnet-webpack'
at Function.Module._resolveFilename (module.js:469:15)
at Function.Module._load (module.js:417:25)
at Module.require (module.js:497:17)
at require (internal/module.js:20:19)
at Object. (D:\local\Temp\4pjsgnvg.u42:83:19)
at webpack_require (D:\local\Temp\4pjsgnvg.u42:20:30)
at createWebpackDevServer (D:\local\Temp\4pjsgnvg.u42:62:26)
at D:\local\Temp\lgntfojf.pnm:114:19
at IncomingMessage. (D:\local\Temp\lgntfojf.pnm:133:38)
at emitNone (events.js:86:13)
Current directory is: D:\home\site\wwwroot
) ---> Microsoft.AspNetCore.NodeServices.HostingModels.NodeInvocationException: Webpack dev middleware failed because of an error while loading 'aspnet-webpack'. Error was: Error: Cannot find module 'aspnet-webpack'
at Function.Module._resolveFilename (module.js:469:15)
at Function.Module._load (module.js:417:25)
at Module.require (module.js:497:17)
at require (internal/module.js:20:19)
at Object. (D:\local\Temp\4pjsgnvg.u42:83:19)
at webpack_require (D:\local\Temp\4pjsgnvg.u42:20:30)
at createWebpackDevServer (D:\local\Temp\4pjsgnvg.u42:62:26)
at D:\local\Temp\lgntfojf.pnm:114:19
at IncomingMessage. (D:\local\Temp\lgntfojf.pnm:133:38)
at emitNone (events.js:86:13)
Current directory is: D:\home\site\wwwroot
at Microsoft.AspNetCore.NodeServices.HostingModels.HttpNodeInstance.d__71.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at System.Runtime.CompilerServices.TaskAwaiter1.GetResult()
at Microsoft.AspNetCore.NodeServices.HostingModels.OutOfProcessNodeInstance.d__131.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at System.Runtime.CompilerServices.TaskAwaiter1.GetResult()
at Microsoft.AspNetCore.NodeServices.NodeServicesImpl.d__101.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at Microsoft.AspNetCore.NodeServices.NodeServicesImpl.<InvokeExportWithPossibleRetryAsync>d__101.MoveNext()
--- End of inner exception stack trace ---
at System.Threading.Tasks.Task1.GetResultCore(Boolean waitCompletionNotification)    at System.Threading.Tasks.Task1.get_Result()
at Microsoft.AspNetCore.Builder.WebpackDevMiddleware.UseWebpackDevMiddleware(IApplicationBuilder appBuilder, WebpackDevMiddlewareOptions options)
at ClientApp.Startup.Configure(IApplicationBuilder app, IHostingEnvironment env, ILoggerFactory loggerFactory) in C:\Users\michael.lavatman\source\Workspaces\Angular-Core-IdentityServer-0.15.0\ClientApp\Startup.cs:line 58
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at Microsoft.AspNetCore.Hosting.ConventionBasedStartup.Configure(IApplicationBuilder app)
at Microsoft.AspNetCore.Server.IISIntegration.IISSetupFilter.<>c__DisplayClass3_0.b__0(IApplicationBuilder app)
at Microsoft.AspNetCore.Hosting.Internal.AutoRequestServicesStartupFilter.<>c__DisplayClass0_0.b__0(IApplicationBuilder builder)
at Microsoft.AspNetCore.Hosting.Internal.WebHost.BuildApplication()
---> (Inner Exception #0) Microsoft.AspNetCore.NodeServices.HostingModels.NodeInvocationException: Webpack dev middleware failed because of an error while loading 'aspnet-webpack'. Error was: Error: Cannot find module 'aspnet-webpack'
at Function.Module._resolveFilename (module.js:469:15)
at Function.Module._load (module.js:417:25)
at Module.require (module.js:497:17)
at require (internal/module.js:20:19)
at Object. (D:\local\Temp\4pjsgnvg.u42:83:19)
at webpack_require (D:\local\Temp\4pjsgnvg.u42:20:30)
at createWebpackDevServer (D:\local\Temp\4pjsgnvg.u42:62:26)
at D:\local\Temp\lgntfojf.pnm:114:19
at IncomingMessage. (D:\local\Temp\lgntfojf.pnm:133:38)
at emitNone (events.js:86:13)
Current directory is: D:\home\site\wwwroot
at Microsoft.AspNetCore.NodeServices.HostingModels.HttpNodeInstance.d__71.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at System.Runtime.CompilerServices.TaskAwaiter1.GetResult()
at Microsoft.AspNetCore.NodeServices.HostingModels.OutOfProcessNodeInstance.d__131.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at System.Runtime.CompilerServices.TaskAwaiter1.GetResult()
at Microsoft.AspNetCore.NodeServices.NodeServicesImpl.d__101.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at Microsoft.AspNetCore.NodeServices.NodeServicesImpl.<InvokeExportWithPossibleRetryAsync>d__101.MoveNext()<---

Does anything in this help?
Try disabling server-side rendering and see if you still have a problem.

Whatever I did, didn't help

What did you do?
Try putting the site back into production mode and see if there are any logs in Azure that might help give us a hint.

I tried it and got the same issue. Seems to be related to this. Looks like the solution is to recreate the client application using the new Angular CLI compatible template. I have added redoing the client app to my list.

I did fix the ClientApp site crash.
But it generates an error:
Failed to load https://identityapp15.azurewebsites.net/.well-known/openid-configuration: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://clientapp15.azurewebsites.net' is therefore not allowed access.
And when clicking Login:
Well known endpoints must be loaded before user can login!
And this:
main.8a793f93b771dc4cf54e.bundle.js:1 ERROR Error: Uncaught (in promise): Error: Cannot match any routes. URL Segment: 'login'
Also, as I mentioned before in label15 there are client side errors in Identity app:
Refused to load the stylesheet 'https://ajax.aspnetcdn.com/ajax/bootstrap/3.3.7/css/bootstrap.min.css' because it violates the following Content Security Policy directive: "default-src 'self'". Note that 'style-src' was not explicitly set, so 'default-src' is used as a fallback.
identityapp15.azurewebsites.net/:11 Refused to execute inline script because it violates the following Content Security Policy directive: "default-src 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-eNYKgDOxdMjUMFmlqVjLSIBHYSBciCwh8Qq2QkPk7xA='), or a nonce ('nonce-...') is required to enable inline execution. Note also that 'script-src' was not explicitly set, so 'default-src' is used as a fallback.
identityapp15.azurewebsites.net/:1 Refused to load the script 'https://ajax.aspnetcdn.com/ajax/jquery/jquery-2.2.0.min.js' because it violates the following Content Security Policy directive: "default-src 'self'". Note that 'script-src' was not explicitly set, so 'default-src' is used as a fallback.
identityapp15.azurewebsites.net/:166 Refused to execute inline script because it violates the following Content Security Policy directive: "default-src 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-dIkC+lnHXmVnIT5Z+EXzjiqO37UV46cPSb2V0TNQlxc='), or a nonce ('nonce-...') is required to enable inline execution. Note also that 'script-src' was not explicitly set, so 'default-src' is used as a fallback.
Thanks.


duplication function calls in attribute

Laravel Version
10.6.1
PHP Version
8.1.5
Database Driver & Version
postgres
Description
Every time i call any attribute in models it calls method agian
Steps To Reproduce
imagine we have a model like this
class TestModel extends Model {
    //......
    //......
    //......
    public function getTitleAttribute()
    {
        $test2 = Test2Model::query()->find($this->id);

        return $test2?->title;
    }
}

when I use a query like below
 $p = Test2::query()->first();

and
    if (isset($p['title'])) {
        $t = $p['title'];
    }

    if (isset($p->title)) {
        $t = $p->title;
    }

Everytime i call $t->title, getTitleAttributes() is called again, so if i call it 5 times, 5 times that getTitleAttributes() is called;
$t->title;
$t->title;
$t->title;
$t->title;
$t->title;

I don't really see a bug here.

getTitleAttribute is called every time you reference the title attribute, then you need to add some cache to your code.
class TestModel extends Model
{
    protected array $cache = [];

    public function getTitleAttribute(): string
    {
        return $this->cache['title'] ??= Test2Model::query()->where('id', $this->id)->value('title') ?: '';
    }
}


Wrecks accounts fast

can you add a sleep function every 15 adds that increaes by 400 seconds each time?

how much users you add from one user?

Less than 15.

Hello?


No "sourceType" field on TSConfig compiler options

I notice the README instructions suggest adding "sourceType": "module" to TSConfig compilerOptions but there is no such field: https://www.typescriptlang.org/tsconfig.
May I remove it? It makes Cypress pretty unhappy:

I have the same problem


Bug with Biz.time(...).before(...) calculations

Hi,
Given this configuration
schedule = Biz::Schedule.new do |config|
  config.hours = {
    mon: { '09:30' => '16:00' },
    tue: { '09:30' => '16:00' },
    wed: { '09:30' => '16:00' },
    thu: { '09:30' => '16:00' },
    fri: { '09:30' => '16:00' }
  }
  config.holidays = []
  config.breaks = {}
  config.time_zone = 'America/New_York'
end

sunday_beginning_of_the_day = ActiveSupport::TimeZone.new('America/New_York').local(2016,6,12,0,1,0)
sunday_end_of_the_day = ActiveSupport::TimeZone.new('America/New_York').local(2016,6,12,23,59,0)

puts schedule.time(1, :day).before(sunday_beginning_of_the_day)
puts schedule.time(1, :day).before(sunday_end_of_the_day)

it will print two different days
2016-06-09 20:00:00 UTC
2016-06-10 20:00:00 UTC

and since Sunday is free day then it should return the same day (thursday or friday it's debatable) regarding what hour we pass.
I dig a little and in for_duration.rb file the advanced_time returns Friday both times but with different hours and then the periods calculation happen and the problem seems to be somewhere there.

Just found issue #56 - your explanation makes total sense once you read it

Find the next day that contains business hours. Starting from the same minute on that day as the specified time, look forward (or back) to find the next moment in time that is in business hours.

Maybe we should move it to the readme in separate section How day calculations work to avoid confusion?

Maybe we should move it to the readme in separate section f.e.: How day calculations work to avoid confusion?

Seems reasonable to me. Added in https://github.com/zendesk/biz/pull/74.

Awesome - thank you!


Volume Icons / Stepping not present.

OS:
Win10 2016 LTSB x64
Issue Descriptions:
Clicking on the volume icons do nothing in the desktop player. One would expect there to be stepping present based on the icons...
Steps to Reproduce:
Click on the volume icons, nothing happens.

This isn't present on the web application either, which this is just a wrapper for. It could probably be added, at the cost of having to update any time the UI updated on Google's end.

This needs backported to the web app ASAP, haha, very handy when your mouse is already nearby. Great work on this little QoL feature too, gentlemen.


Scaling seems doesn't work for python

Hi, TEASER++ works great for same scale point clouds with large outliers.  But for point clouds with large scaling difference, the result seems not very good. I'm not sure if it is because the Python binding does not support scaling? I tuned the parameter estimate_scaling in helpers.py to be True, but the performance seems unchanged.

The result of the model will return the scale. I forgot the code but the scale can be derived from result.s as well as the rotation and translation (result.T).
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: ttsesm @.>
Sent: Friday, February 18, 2022 10:02:02 PM
To: MIT-SPARK/TEASER-plusplus @.>
Cc: Liu Qingzhen @.>; Mention @.>
Subject: Re: [MIT-SPARK/TEASER-plusplus] Scaling seems doesn't work for python (#117)
    - External Email -

@liu-qingzhenhttps://github.com/liu-qingzhen, @gaussiangithttps://github.com/gaussiangit did you manage to have scaling working. I am having a similar scaling use case and the result is not that good as well.
—
Reply to this email directly, view it on GitHubhttps://github.com/MIT-SPARK/TEASER-plusplus/issues/117#issuecomment-1044574345, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQXSV5P2L7FR5O6RGJXAJL3U3ZGNVANCNFSM5FB5LAGA.
You are receiving this because you were mentioned.Message ID: @.***>
Notice: This email is generated from the account of an NUS alumnus. Contents, views, and opinions therein are solely those of the sender.

Sure it returns an s value, however it is not correct. When the scaling ratio between the two pcds is quite big, it fails to address the registration and the scaling value doesn't really help much.
In any case, thank you for your time.

Yeah, they said it is because of the feature extraction with fpfh is not accurate. The scale estimation model makes sense, but the performance is not good with traditional feature descriptor.
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: ttsesm @.>
Sent: Saturday, February 19, 2022 6:00:42 AM
To: MIT-SPARK/TEASER-plusplus @.>
Cc: Liu Qingzhen @.>; Mention @.>
Subject: Re: [MIT-SPARK/TEASER-plusplus] Scaling seems doesn't work for python (#117)
    - External Email -

Sure it returns an s value, however it is not correct. When the scaling ratio between the two pcds is quite big, it fails to address the registration and the scaling value doesn't really help much.
In any case, thank you for your time.
—
Reply to this email directly, view it on GitHubhttps://github.com/MIT-SPARK/TEASER-plusplus/issues/117#issuecomment-1045245430, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQXSV5LJGLD7CT7PELPPLK3U326QVANCNFSM5FB5LAGA.
You are receiving this because you were mentioned.Message ID: @.***>
Notice: This email is generated from the account of an NUS alumnus. Contents, views, and opinions therein are solely those of the sender.

I see, did you test with an alternative feature descriptor, other than the fpfh, to see whether it performs better?

@ttsesm FPFH is not designed to be scale-invariant (see the original paper). Maybe try this: https://link.springer.com/article/10.1007/s00521-017-2964-1?


Adopted atomic design changes

Fixed components regarding to atomic design branch

Can we have a little presentation of the principles behind the
reorganization and the rules going forward in one of our check-ins? Thanks!
On Fri, Apr 7, 2017 at 10:59 AM Thomas Schlage<EMAIL_ADDRESS>wrote:

Fixed components regarding to atomic design branch
You can view, comment on, or merge this pull request online at:
https://github.com/wholesale-design-system/components/pull/45
Commit Summary

Adopted atomic design changes

File Changes

M demo/index.scss
https://github.com/wholesale-design-system/components/pull/45/files#diff-0
(1)
M dist/amd/ws-header/ws-header.scss
https://github.com/wholesale-design-system/components/pull/45/files#diff-1
(2)
M dist/amd/ws-notification/ws-notification.scss
https://github.com/wholesale-design-system/components/pull/45/files#diff-2
(4)
M dist/amd/ws-week-picker/ws-week-picker-calendar.js
https://github.com/wholesale-design-system/components/pull/45/files#diff-3
(10)
M dist/amd/ws-week-picker/ws-week-picker.js
https://github.com/wholesale-design-system/components/pull/45/files#diff-4
(2)
M dist/amd/ws-week-picker/ws-week-picker.scss
https://github.com/wholesale-design-system/components/pull/45/files#diff-5
(48)
M dist/commonjs/ws-header/ws-header.scss
https://github.com/wholesale-design-system/components/pull/45/files#diff-6
(2)
M dist/commonjs/ws-notification/ws-notification.scss
https://github.com/wholesale-design-system/components/pull/45/files#diff-7
(4)
M dist/commonjs/ws-week-picker/ws-week-picker-calendar.js
https://github.com/wholesale-design-system/components/pull/45/files#diff-8
(10)
M dist/commonjs/ws-week-picker/ws-week-picker.js
https://github.com/wholesale-design-system/components/pull/45/files#diff-9
(2)
M dist/commonjs/ws-week-picker/ws-week-picker.scss
https://github.com/wholesale-design-system/components/pull/45/files#diff-10
(48)
M dist/es2015/ws-header/ws-header.scss
https://github.com/wholesale-design-system/components/pull/45/files#diff-11
(2)
M dist/es2015/ws-notification/ws-notification.scss
https://github.com/wholesale-design-system/components/pull/45/files#diff-12
(4)
M dist/es2015/ws-week-picker/ws-week-picker-calendar.js
https://github.com/wholesale-design-system/components/pull/45/files#diff-13
(10)
M dist/es2015/ws-week-picker/ws-week-picker.js
https://github.com/wholesale-design-system/components/pull/45/files#diff-14
(2)
M dist/es2015/ws-week-picker/ws-week-picker.scss
https://github.com/wholesale-design-system/components/pull/45/files#diff-15
(48)
M dist/system/ws-header/ws-header.scss
https://github.com/wholesale-design-system/components/pull/45/files#diff-16
(2)
M dist/system/ws-notification/ws-notification.scss
https://github.com/wholesale-design-system/components/pull/45/files#diff-17
(4)
M dist/system/ws-week-picker/ws-week-picker-calendar.js
https://github.com/wholesale-design-system/components/pull/45/files#diff-18
(10)
M dist/system/ws-week-picker/ws-week-picker.js
https://github.com/wholesale-design-system/components/pull/45/files#diff-19
(2)
M dist/system/ws-week-picker/ws-week-picker.scss
https://github.com/wholesale-design-system/components/pull/45/files#diff-20
(48)
M src/ws-header/ws-header.scss
https://github.com/wholesale-design-system/components/pull/45/files#diff-21
(2)
M src/ws-notification/ws-notification.scss
https://github.com/wholesale-design-system/components/pull/45/files#diff-22
(4)
M src/ws-week-picker/ws-week-picker.scss
https://github.com/wholesale-design-system/components/pull/45/files#diff-23
(13)

Patch Links:

https://github.com/wholesale-design-system/components/pull/45.patch
https://github.com/wholesale-design-system/components/pull/45.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/wholesale-design-system/components/pull/45, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAuZXq8h1yntx_1T435RhG5DJ1dSyU0mks5rtfrTgaJpZM4M2ok9
.

👍


Assertion Failed: You must use Ember.set() to set the record property

I'm getting this error from:
https://github.com/ebryn/ember-model/blob/master/packages/ember-model/lib/model.js#L100
I was able to change this to an Ember.set, and it worked. Not sure how to properly test this though, as I can't reliably reproduce.

I actually have a PR for this issue. I just haven't had a chance to put together a failing test for it. Looks like others are experiencing the same thing.
https://github.com/ebryn/ember-model/pull/385


[FLINK-26235][connectors/filesystem] CompactingFileWriter and PendingFileRecoverable should not be exposed to users.

What is the purpose of the change
In FLINK-25583, we added a FileCompactingWriter to write the compacting file. The writer is exposed to users in the FileCompactor, while it has a closeForCommit function, and relies on the PendingFileRecoverable, both of which should not be exposed to users. We should fix this and annotate them as Internal.
Brief change log

Annotate CompactingFileWriter and PendingFileRecoverable as Internal.
Hide CompactingFileWriter in the FileCompactor.
Call FileCompactor with either of the implementation.

Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)

@gaoyunhaii
Thanks for the review! The comments are now resolved.

@flinkbot run azure

@flinkbot run azure


Prepare modules for Public Bicep Registry Test

Packaging tool now available at: https://www.nuget.org/packages/Azure.Bicep.RegistryModuleTool/
Docs: https://github.com/Azure/bicep/blob/main/docs/contributing-to-registry.md
We should prepare several modules to be used in the CI environment of the public bicep registry. The main challenge will be to prepare the test-bicep files.
The closest ones we currently have are

Analysis Services
Virtual Machine

However, if we want to publish them without relying on other modules to be already published, we would need to create all bicep files using direct resource references (instead of CARML modules) which can be a lot of effort.
As a result it may make sense to start with a badge of modules that have no, or almost no such dependencies.
Also,

it is unclear wther there is a principal we can use for RBAC. Probably we'll need to deploy an MSI as part of each module that supports any sort of principal assignment (e.g. RBAC, Access policies, etc.).
there is no logic to purge key vaults currently implemented in the PG's CI environment. This will likely cause issues for e.g. the VM test (as it deploys a key vault too)

Virtual Network (simple as it has only one child and support for locks, RBAC & diagnostic settings)
Availability Set (simple as it has no children and only comes with added capabilities like locks & RBAC)
Resource Group (simple as it has no children and only comes with added capabilities like locks & RBAC)

Modules created (using tool) in path 'PG-Modules'

Note: Unfortunately the tool generates docs with auto-formatting that makes manual adjustments very difficult:

Both the AvailabiltiySet & VirtualNetwork modules were successfully published to the public bicep registry.


Code restructure to prep for malicious sort

Moving semi honest sort code in semi_honest folder. This is preparation for malicious upgrade

Might not even need this restructure. Closing for now and will revisit


SM CLI refers to older version of Service Manager

The SM CLI will fail on installation due to referring to an older package name for the class LabelChanges.
The pull request from Service Manager which made these changes is here: https://github.com/Peripli/service-manager/pull/444
It seems like SM CLI should update the coding to reflect these changes, otherwise the installation of the tool will not work.

In my case, I had to revert back to version 0.10.2 of the Service Manager in order to make the SM CLI tool work.

Is this issue still relevant?
Re-open is it is.


v0.2.0

Codecov Report
Attention: Patch coverage is 94.31818% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 94.07%. Comparing base (a959c50) to head (9978438).

Files
Patch %
Lines

slider.go
92.59%
2 Missing :warning:

token_bucket.go
89.47%
2 Missing :warning:

offset.go
83.33%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   93.81%   94.07%   +0.25%
==========================================
  Files           4        4
  Lines          97      135      +38
==========================================
+ Hits           91      127      +36
- Misses          5        8       +3
+ Partials        1        0       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


WIP: Filling out test by querying for data which was created by ActiveStorage gem

Still working on this, but starting to hit a couple of challenges and wanting to share the progress / idea of it.

Using the repo from the config rather that Chaskiq.Repo (at least in one function for now)
Pre-loading the blob when getting the attachment (I figure that we'll probably always want the blob (??))
Renamed the tables to match the gem's names

Got a bit more time!  Just made it based on an ecto schema/record.  Now ActiveStorage.get_attachment! needs an ecto record and an attachment name.  So in Ruby you would do User.find(123).avatar in active_storage_ex you would do:
user = Repo.get(User, 123)
ActiveStorage.get_attachment!(user, "avatar")

awesome! it looks good to me


The internalLogFile does not resolve ${nlogdir}

Type

Bug

NLog version: 4.5.1
Platform: .Net 4.6.2
Current NLog config
<?xml version="1.0" encoding="utf-8" ?>
<nlog xmlns="http://www.nlog-project.org/schemas/NLog.xsd"
      xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
      autoReload="true"
      throwExceptions="false"
      internalLogFile="${nlogdir}\..\Log\Test.exe.NLog.log" internalLogLevel="Debug" >

  <targets>
      <target xsi:type="File"
            fileName="${nlogdir}\..\Log\Test.exe.log"
            keepFileOpen="false"
			name="default"
      />
  </targets>
  <rules>
    <logger name="*" writeTo="default" minlevel="Debug" />
  </rules>
</nlog>

Program
LogManager.Configuration = new XmlLoggingConfiguration(@"..\..\nlogconfig.config");
var logger = NLog.LogManager.GetCurrentClassLogger();
logger.Error("Hello World");

In case of a BUG:

What is the current result?
The internal log file writes to {Project}\bin\Debug\Log
The target file logs to {Project}\bin\Log

What is the expected result?
The internal log file should write to {Project}\bin\Log

The internalLogFile is just a string and not layout renderers are allowed in them.

duplicate of https://github.com/NLog/NLog/issues/581

It seems I didn't google good enough. Thanks for the info.


First roll does not return results onRollComplete

I've been seeing an interesting behaviour where the first die or array of dice that I roll does not return a result onRollComplete. Every roll after works as expected. dice-box seems like its completing init fine and I have a spinner to ensure the user isn't clicking roll too soon. You can see in the image below that I'm going getting one complete message for two rolls.

 useEffect(() => {
    setIsLoading( true )

    const Box = new Dicebox("#dice-box", {
      assetPath: '/dice-box/',
      theme: pink,
    })

    Box.init().then(() =>  {
      setDiceBox( Box )
      setIsLoading( false )
    } );
  }, [])

I tried commenting out the diceBox.add and just using the diceBox.roll. This bug was the same here.
const diceRoll = async ( notation: string | string[], add = false ) => {
    console.log("%c Clicked~", `color: orange; size 14px;`)

    add ? await diceBox.add( notation ) : await diceBox.roll( notation )

    if ( diceBox ) {
      diceBox.onRollComplete = (resultsArray: resultsType[]) => {
        console.log( resultsArray )
      };
    }
  }

I resolved my issue by updating the code. I recalled in our past emails that you were going to make rolls promises.
So this worked:
    if ( add ) {
      await diceBox.add( notation ).then((results: resultsType[]) => {
        handleResults(results)
      })
    } else {
      await diceBox.roll( notation ).then((results: resultsType[]) => {
        handleResults(results)
      })
    }

Do you want me to put in a PR to update the README ? Do you intend to keep onRollComplete ?

I think this is the same issue I reported in #17
I've been reworking how the roll promises are done the last two days so they don't swallow each other. It kind of overlaps how the internal data is handled when an array of dice notations is passed in and turned into dice groups.
To summarize the issue, on .roll a promise is attached to the World class that is fulfilled onRollComplete. The problem is that every time .add is used, it hijacks the promise, essentially removing it from calls made before it. Instead of attaching this pending promise to the world class object, each .roll and .add call should have its own promise.

Fixed with 0.6 release. I overhauled the way data was managed internally to resolve the promise issues.


Add Support for CPack

Can create installer packages for both Windows and MacOS/Linux. I've also added a lean boost install (install only required libraries), as per issue #37.
Also removed the CI CD pipeline... I'm gonna build it myself

Tested on windows. Works

Tested on MacOS. Works. Linux should work as well...


Support disabling python linters via configuration setting

As a contributor to multiple python projects I need to be aware of which linters a project uses. Contributions to a project to resolve linting errors for a linter the project does not use are generally not accepted unless they can be associated with a known bug.
The current Python linter docs note:

Linters, if installed, are enabled by default. You can disable them by disabling the extension per workspace.

Remembering to enable/disable linter extensions for a specific workspace This is a much less friendly DX experience than the obsolete
"python.linting.pycodestyleEnabled": false,
"python.linting.pylintEnabled": true,
"python.linting.enabled": true,

configuration that existed previously.
Please provide a way to remark which linters should be enabled in a workspace as a configuration setting if multiple linters are installed simultaneously, i.e. as a disabled section in .vscode/extensions.json or as block in .vscode/settings.json like:
 "[python]": {
        "editor.enabledLinters": [
            "charliermarsh.ruff",
            "ms-python.pylint"
        ]
}

This is a similar feature request to https://github.com/microsoft/vscode/issues/40239

Please file the issue against the python extension.

https://github.com/microsoft/vscode-python/issues/22607 is the associated vscode-python issue.


fix: typo in mountPath #2

Thanks for your contribution :tada:
I have merged it as of https://github.com/redirectionio/kubernetes-example/commit/40249fd761baa7aa76d80358fecc7b4661309d10


404 when specifying host, and path in first argument of form.submit

var form = new FormData();
  form.append('name', project.name);
  form.append('description', 'blerg');
  form.append('project_id', project.notableProject.id);
  form.submit({
    host: 'http://host.notable.dev',
    path: '/api/v1/prototypes',
    headers: {
      'Authentication': 'secret'
    }
  }, function(err, res) {
    if(err) console.log("ERR: ", err)
    else console.log("RES: ", res)
    console.log(res.statusCode);
  });

Will return a 404 even though I can hit that host/path by using submit with the less explicit syntax and get an http 200 (success).
form.submit('http://host.notable.dev/api/v1/prototypes', function(err, res) {
    if(err) console.log("ERR: ", err)
    else console.log("RES: ", res)
    console.log(res.statusCode);
  });

If more details will help I will be happy to provide them.

This part should be more like:
{
    host: 'host.notable.dev',
    path: '/api/v1/prototypes',
    headers: {
      'Authentication': 'secret'
    }
  }

There is separate property for the protocol.
{
    protocol: 'http:',
    host: 'host.notable.dev',
    path: '/api/v1/prototypes',
    headers: {
      'Authentication': 'secret'
    }
  }

But http is the default one, so you can omit it.

I think this is resolved? @erikmellum Does that work for you?

@erikmellum Please let us know if you have follow up questions. Closing for now.


Accessing notifications received while the app is closed on iOS

Currently when the app is closed (i.e not in background) the notification event is triggered only when the user opens the app by clicking on the notification in the iOS notification center.
Is it possible to access the list of recent notifications from the iOS or APN api ?
This would enable displaying past notifications when the user re-opens the app.

@matdev this is the same root cause of #557.

Indeed, that's why I am looking for a workaround.
Being able to read past notifications when the app starts up would solve the problem.
A "no it's not possible" answer would be fair enough.

@matdev Yeah, it's currently not possible. The user would have to click on the notification in the shade in order to fire the event.

But there are many apps displaying past notications received while they are closed.
Do you mean it's not possible to do with the plugin but possible natively ?

@matdev if you want the event fired even when the user does not click on the notification then you'll need to look at background notifications in the docs. You can still have UI with these notifications but you'll have to keep track of the events since if the user clicks on the notification again you'll get the event a second time. Usually folks will just put a unique ID in the notifications to track.

I already display background notifications properly, thanks.
My question relates to notifications received when the app is fully closed, i.e not in background.
As I said, many apps displays past notifications when they are re-opened.
Why the plugin does not allow that ?

@matdev The thing is that the notifications are stored in memory and just the last of them. As of now the plugin doesn't persist them, that's why it doesn't allow that.

I don't get it; how could the plugin persist notifications if the app is not running ?

@matdev In order to accomplish the display of past notifications when the app is re-opened, those notification should be stored somewhere. I don't get your question.

Well some past notifications are stored somewhere on the phone, since they are displayed in the notification center.
The question is how do native apps manage to display past notifications when they are re-opened ?
Do they have an access to past notif' that cordova apps don't ?
Or do they load past notifications from a web service somewhere ?

Calling setApplicationIconBadgeNumber(success, failure, 0) will clear all the notifications for your app.


Object values

implemented fix.

Hadn't had time to review it; but reviewed found minor issue; Elijah fixed and we merged.  :grinning:

Awesome, thank you both! We will use 0e62597e9cecec73c581b3ccd8964d75171103aa until the next NPM version. Thanks!


simpe exec ffmpeg doesn't work on debian and os x

Hi,
I have a strange problem with exec ...
exec ffmpeg >/tmp/out.txt 2>&1;

doesn't work
however this :
exec which ffmpeg >/tmp/out.txt 2>&1;

works fine and outputs a good path to my ffmpeg in /usr/local/bin/ffmpeg
I was looking through the issues but i didn't found any that is resolves my problem. I updated the nginx to 1.5.3 today and also made a git pull of nginx-rtmp module 2 hours ago.
I have the same problem on os x as well as on debian

@sulphur
hi, how you fix it?

Hi @SanteR1 ,  @sulphur
I'm expirience the same issue.

I don't remember :( Is your stream is a rtmp received from flash plugin in browser ? I think it was related to flash plugin and the corrupted/malformed rtmp stream that caused ffmpeg tu quit

Hi @sulphur
I managed to resolve my issue (there were lot of them :( )
First my nginx service ran under nobody user and I changed it to run under root.
Second. I had couple of ffmpeg errors, I was able to identified them by adding ">output.txt1>&2" to the end of the ffmpeg command.


Update app-sync-job.yaml

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test case A
[ ] Test case B

Checklist:

[ ] The title of the PR states what changed and the related issues number (used for the release note).
[ ] Does this PR require documentation updates?
[ ] I've updated documentation as required by this PR.
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have tested it for all user roles
[ ] I have added all the required unit/api test cases

edit


Request Pico-8

Hi
Request: Add the "scan for new games" script also to Pico-8.
Reason: After installing new games in Pico-8 with zzzsplore.p8 (pico-8 program), new games never appear in menu.
Note: Pico-8 ganes have a .png file extension in the carts folder.
Thanks

No need to do a scan or restsrt emulationstation for this.  Just press select then choose uodate gamelist and they will appear


HOTFIX: removing jcenter from repositories

JCenter is currently down, which has led to me discovering that we should not be using it anymore anyway: https://blog.gradle.org/jcenter-shutdown

If all dependencies are also available from other repositories, it's good to be rid of unnecessary ones. 👍


Add Hoefler & Co test texts from https://github.com/hoeflerco/proofs

Closes #14

Hold fire - I'm going to see if there's a better way to track the hoefler repo than just pulling in the text as a once-off.

Why is the Lua file here marked as a binary?
I this a usecase for a git subtree? I haven't looked at how the original is updated or maintained...

When I look at the .lua file with Notepad++, it shows NUL characters on lines 6 and 7 just before the close quote. Those may or may not cause a problem, but they probably should be removed and that might make GitHub happy as well.

There's a much more significant problem with incorporating Jonathan's texts - there is no copyright or licensing info whatsoever. We can't include them.
BTW - once he gets the texts properly licensed I'd prefer a one-off inclusion. No subtrees please - they are just a pain and certainly not worth the bother in this case.

The license is here: https://github.com/hoeflerco/proofs/blob/master/license.md
Thread: https://twitter.com/HoeflerCo/status/1262859175991918592

Hold on - I've now noticed that he's used cc-by-nc-sa, which means we can't use it. I've seen his thread on this, but whatever his intent, nc would place a restriction on fontproof. So sorry, can't do unless his drops the nc.


Buff emergency welder

About the PR
Doubles the emergency welder's fuel count.

Technical details

Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

tweak: Changed emergency welder's fuel count from 25 -> 50

Emergency welder was too powerful for the tests to handle


Event on upload Complete ?

in jquery, how can add an event while upload complete ? thank you :D

This should work
$('.my-pond').on('FilePond:processfile', function(e) {
    console.log('file added event', e.detail);
});

oke that's work,, but.. how i use the json respon of request ?
FilePond.setOptions({
	   server: {
	        url: '<?=base_url()?>',
	        process: {
	            url: '/import/import_excel',
	            method: 'POST'
	        }
             }
});

i see in the network, it's have a respon that i want.. but, i don't know how to get it to my page ?

The response is available in the server.process.onload callback, please note that this callback should return the file id. You can use it to access other data as well but it is not adviced.

As original question has been answered I’ll close this issue


Migrate to PowerShell Core by default?

Currently, the plugin prefers classic PowerShell if both PowerShell and PowerShell Core are available (see com.intellij.plugin.powershell.ide.run.PSExecutionUtilKt#findPsExecutable).
We should figure out if we it's safe to migrate to Core version by default.
My opinion is that if a person has explicitly installed the Core version, then it's likely they did that for a reason and want to use it: otherwise, why would they install it?

If it is decided that this isn't a good idea, an alternative would be to provide a setting for the default powershell path to use for scripts. (I'm assuming that this would be possible.) Of course, simply switching the default to PSCore is likely sufficient for most people, so that would be the simpler solution.

You can already switch the currently used PowerShell executable in the plugin settings. pwsh is expected to be fully supported, I use it myself. (Though I have to admit that my usage of script run configs may be lower than of some other features.)

Do you mean by editing the Run configuration template for PowerShell to point at the PSCore path? Or is there a more obvious setting somewhere? (I'm not entirely sure I know where to find the right settings).

I mean this setting:

Does it not work?


Switch to using modulename.rs style code layout

trivial typo
Switch to using modulename.rs style code layout.

This might run into strong opinions if they already exist, however I do find this layout to be substantially better overall - and we do use it for the majority of our internal code, so it would be nice to be consistent.

I don't really care, to be honest. I've used the mod.rs approach since I started, but if this is what we're using elsewhere I'm fine with switching.


New organization under "Helpful Material" (testwise)

Organized content under Helpful Material in an accordion component (testwise) to declutter and save some space.

I like it :)


Icon Not displaying

Icons display before I package my app with electron. But after they show the default one.

I've had this issue and it has to do with having appId instead of appID when you build out the application.

appId instead

I tried. It didn't work

I've had this issue and it has to do with having appId instead of appID when you build out the application.

I tried. It didn't work


Illegal characters in path

I cannot seem to get anything to generate.  This message sunk me last night; I thought that I had it, but no.  If I disable automatic installation, it still dies.  Following is my verbose log from the latest attempt.
C:\letsencrypt>letsencrypt.exe --centralsslstore c:\Central_SSL\  --verbose
[DBUG] Config folder: \LOCALSERVERNAME\Users\administrator\Application Data\letsencry
pt-win-simple\httpsacme-v01.api.letsencrypt.org
[VERB] Using registry key HKEY_CURRENT_USER\Software\letsencrypt-win-simple\htt
ps://acme-v01.api.letsencrypt.org/
[VERB] Settings SettingsService {ConfigPath="\\LOCALSERVERNAME\Users\administrator
\Application Data\letsencrypt-win-simple\httpsacme-v01.api.letsencrypt.org",
RenewalStore=["{"Date":"2017-11-07T19:22:14.4574565Z","Binding":{"Host":
"remote.mydomain.com","HostIsDns":false,"IIS":false,"WebRootPath":"%S
ystemDrive%\\inetpub\\wwwroot","SiteId":0,"TargetSiteId":0,"Validation
SiteId":null,"InstallationSiteId":null,"SSLPort":0,"ExcludeBindings":null
,"AlternativeNames":["remote.mydomain.com","exchange.mydomain.com","a
utodiscover.mydomain.com","mail.mydomain.com"],"TargetPluginName":"Manual","ValidationPluginName":"http-01.FileSyst
em","HttpFtpOptions":null,"HttpWebDavOptions":null,"DnsAzureOptions":null
,"DnsScriptOptions":null,"PluginName":"Manual"},"CentralSsl":"c:\\Cen
tral_SSL\\","CertificateStore":null,"San":true,"KeepExisting":false,"I
nstallationPluginNames":null,"Script":null,"ScriptParameters":null,"Warmup
":false}"], HostsPerPage=50}
[VERB] .NET Framework >=4.7 detected
[INFO] Let's Encrypt Windows Simple (LEWS)
[INFO] Software version 198.0.6545.42419 (RELEASE)
[INFO] IIS version 7.5
[INFO] ACME Server https://acme-v01.api.letsencrypt.org/
[INFO] Please report issues at https://github.com/Lone-Coder/letsencrypt-win-si
mple
[VERB] Verbose mode logging enabled
[DBUG] Renewal period: 60
N: Create new certificate
L: List scheduled renewals
R: Renew scheduled
S: Renew specific
A: Renew all
V: Revoke certificate
C: Cancel scheduled renewal
X: Cancel all scheduled renewals
Q: Quit
Please choose from the menu: n
1: Single binding of an IIS site
2: SAN certificate for all bindings of an IIS site
3: SAN certificate for all bindings of multiple IIS sites
4: Manually input host names
C: Cancel
Which kind of certificate would you like to create?: 4
Enter comma-separated list of host names, starting with the primary one: remote
.mydomain.com, autodiscover.mydomain.com, mail.mydomain.com, exchange.mydomain.com
[INFO] Plugin Manual generated target [Manual] [4 bindings - remote.mydomain.
com, ...]
1: [dns-01] Azure DNS
2: [dns-01] Run external program/script to create and update records
3: [http-01] Save file on local (network) path
4: [http-01] Upload verification file to FTP(S) server
5: [http-01] Self-host verification files (recommended)
6: [http-01] Upload verification file to WebDav path
C: Cancel
How would you like to validate this certificate?: 5
Copy default web.config before validation? (y/n): - yes
1: Do not run any installation steps
2: Create or update IIS bindings
3: Run external script
C: Cancel
Which installer should run for the certificate?: 1
[DBUG] Loading signer from \LOCALSERVERNAME\Users\administrator\Application Data\lets
encrypt-win-simple\httpsacme-v01.api.letsencrypt.org\Signer
[DBUG] Getting AcmeServerDirectory
[DBUG] Send GET request to https://acme-v01.api.letsencrypt.org/directory
[DBUG] Loading registration from \LOCALSERVERNAME\Users\administrator\Application Dat
a\letsencrypt-win-simple\httpsacme-v01.api.letsencrypt.org\Registration
[DBUG] Send POST request to https://acme-v01.api.letsencrypt.org/acme/new-authz
[INFO] Cached authorization result: valid
[DBUG] Send POST request to https://acme-v01.api.letsencrypt.org/acme/new-authz
[INFO] Cached authorization result: valid
[DBUG] Send POST request to https://acme-v01.api.letsencrypt.org/acme/new-authz
[INFO] Cached authorization result: valid
[DBUG] Send POST request to https://acme-v01.api.letsencrypt.org/acme/new-authz
[INFO] Cached authorization result: valid
[DBUG] Certificate folder: c:\letsencrypt\temp
[DBUG] Using Centralized SSL path: c:\Central_SSL
[DBUG] RSAKeyBits: 2048
[INFO] Requesting certificate remote.mydomain.com 2017/12/8 7:49:55 AM
[DBUG] Send POST request to https://acme-v01.api.letsencrypt.org/acme/new-cert
[INFO] Saving certificate to c:\letsencrypt\temp
[DBUG] Set private key exportable
[INFO] Copying certificate to the Central SSL store
[DBUG] ArgumentException: ArgumentException {Message="Illegal characters in pat
h.", ParamName=null, Data=[], InnerException=null, TargetSite=Void CheckInvalidP
athChars(System.String, Boolean), StackTrace="   at System.IO.Path.CheckInvalidP
athChars(String path, Boolean checkAdditional)\r\n   at System.IO.Path.Combine(S
tring path1, String path2)\r\n   at LetsEncrypt.ACME.Simple.Services.CentralSsl.
Save(CertificateInfo input)\r\n   at LetsEncrypt.ACME.Simple.Program.OnRenewSucc
ess(ILifetimeScope scope, ScheduledRenewal renewal)", HelpLink=null, Source="msc
orlib", HResult=-2147024809}
[EROR] ArgumentException: Illegal characters in path.
[EROR] Create certificate failed

I managed to reproduce and fix this bug, it will be solved in the next beta, which should be ready this weekend.


Proper code coverage for ES6(Babel)

Details about the issue/solution are detailed in #27.
PR also includes a small change mentioned in #27 which removes the "plugins" key in karma.conf.js. If this needs to be in a separate PR let me know and I'll cherry-pick the commit out.

This looks great, thanks for doing it!
Just one question: do we still need the karma-babel-preprocessor dependency since we're just using the Babelify transform now?

Good catch - I doubt we do. I'm AFK for part of the day today, but I'll test that out as soon as I'm back at my computer.

@jakemmarsh When you're right, you're right :) -- just pushed an update to the PR.

@jakemmarsh It looks like I actually did things backwards -- we need karma-babel-preprocessor during testing (for code coverage to work correctly), but we do not need babelify during testing.
I squashed the last commits together in this branch to prevent the history from having irrelevant info, but everything should be working now in this PR.

Looks great, thanks for handling this :+1:


scripts: gen_handles: silence "should it be static?" warnings

Some compilers and static analyzers warn when non-static (globals) are not declared in some .h file. Tweak the generated code and add an extern declaration before each device handle definition to make it look it was declared in a (non-existent) .h file.
This makes the code a bit longer but it is already generated and very repetitive anyway.
In the typical SOF configuration this silences about 150 sparse warnings; as many as device handles.

Spam example that this fixes:
https://github.com/thesofproject/sof/actions/runs/4789322954/jobs/8517045526?pr=7488
350/354] Building C object zephyr/CMakeFiles/zephyr_final.dir/dev_handles.c.obj
/zep_workspace/build-mtl/zephyr/dev_handles.c:7:1: warning: symbol '__devicehdl_dts_ord_80' was not declared. Should it be static?
/zep_workspace/build-mtl/zephyr/dev_handles.c:12:1: warning: symbol '__devicehdl_dts_ord_79' was not declared. Should it be static?
/zep_workspace/build-mtl/zephyr/dev_handles.c:17:1: warning: symbol '__devicehdl_dts_ord_78' was not declared. Should it be static?
/zep_workspace/build-mtl/zephyr/dev_handles.c:22:1: warning: symbol '__devicehdl_dts_ord_77' was not declared. Should it be static?
/zep_workspace/build-mtl/zephyr/dev_handles.c:37:1: warning: symbol '__devicehdl_dts_ord_40' was not declared. Should it be static?
/zep_workspace/build-mtl/zephyr/dev_handles.c:42:1: warning: symbol '__devicehdl_dts_ord_38' was not declared. Should it be static?
/zep_workspace/build-mtl/zephyr/dev_handles.c:47:1: warning: symbol '__devicehdl_dts_ord_44' was not declared. Should it be static?
/zep_workspace/build-mtl/zephyr/dev_handles.c:54:1: warning: symbol '__devicehdl_dts_ord_42' was not declared. Should it be static?
/zep_workspace/build-mtl/zephyr/dev_handles.c:59:1: warning: symbol '__devicehdl_dts_ord_92' was not declared. Should it be static?
/zep_workspace/build-mtl/zephyr/dev_handles.c:64:1: warning: symbol '__devicehdl_dts_ord_4' was not declared. Should it be static?
/zep_workspace/build-mtl/zephyr/dev_handles.c:73:1: warning: symbol '__devicehdl_dts_ord_88' was not declared. Should it be static?
/zep_workspace/build-mtl/zephyr/dev_handles.c:82:1: warning: symbol '__devicehdl_dts_ord_87' was not declared. Should it be static?
/zep_workspace/build-mtl/zephyr/dev_handles.c:91:1: warning: symbol '__devicehdl_dts_ord_86' was not declared. Should it be static?
/zep_workspace/build-mtl/zephyr/dev_handles.c:100:1: warning: symbol '__devicehdl_dts_ord_85' was not declared. Should it be static?
/zep_workspace/build-mtl/zephyr/dev_handles.c:109:1: warning: symbol '__devicehdl_dts_ord_84' was not declared. Should it be static?
/zep_workspace/build-mtl/zephyr/dev_handles.c:118:1: warning: symbol '__devicehdl_dts_ord_83' was not declared. Should it be static?
/zep_workspace/build-mtl/zephyr/dev_handles.c:123:1: warning: symbol '__devicehdl_dts_ord_54' was not declared. Should it be static?
/zep_workspace/build-mtl/zephyr/dev_handles.c:128:1: warning: symbol '__devicehdl_dts_ord_53' was not declared. Should it be static?
/zep_workspace/build-mtl/zephyr/dev_handles.c:133:1: warning: symbol '__devicehdl_dts_ord_52' was not declared. Should it be static?
/zep_workspace/build-mtl/zephyr/dev_handles.c:138:1: warning: symbol '__devicehdl_dts_ord_51' was not declared. Should it be static?
/zep_workspace/build-mtl/zephyr/dev_handles.c:143:1: warning: symbol '__devicehdl_dts_ord_50' was not declared. Should it be static?
/zep_workspace/build-mtl/zephyr/dev_handles.c:148:1: warning: symbol '__devicehdl_dts_ord_49' was not declared. Should it be static?
/zep_workspace/build-mtl/zephyr/dev_handles.c:153:1: warning: symbol '__devicehdl_dts_ord_62' was not declared. Should it be static?
...
...

150 lines


cleanup(bigtable): rename testing namespace

Used to be called google::cloud::bigtable::testing which can clash
with ::testing.
Part of the work for #732

This change is

I made a mistake, it is too early to make these changes.


Texture bug with Flat Colored Blocks (1.12)

https://imgur.com/a/GXv4w & https://imgur.com/a/IlPdk
I have no idea why this happens.

https://minecraft.curseforge.com/projects/ender-compass/files/2447913


Example for reading EXIF data from the container

It seems I should probably use jxl-bitstream directly, but not immediately clear how to. Having an example would be very nice.

Currently jxl-bitstream reads and discards auxiliary boxes including EXIF and XMP metadata. It's a bit complicated because those boxes may be Brotli-compressed, but yeah, we definitely need some interface to get aux boxes.

There is a performant and safe Brotli implementation in Rust that can be leveraged here: https://crates.io/crates/brotli-decompressor
Although I would prefer it being an optional dependency gated behind a feature flag.
I've recently added exif_metadata() to the image crate's ImageDecoder trait, so Exif could be easily exposed via image API as well.


can you provide the whole datalists used for text detection and spotting?

You can download them follow the instruction in https://github.com/hikopensource/DAVAR-Lab-OCR/tree/main/demo/text_spotting/datalist

IC13/IC15/TotalText train/CTW with transcript are all missing from that link

IC13/IC15/TotalText train/CTW with transcript are all missing from that link

I've just checked the link, and there are 20 datalists in the directory, including all the lists you mentioned. How many did see?

IC13/IC15/TotalText train/CTW with transcript are all missing from that link

I've just checked the link, and there are 20 datalists in the directory, including all the lists you mentioned. How many did see?

Link he mentioned is the Hikvision Netdisk link, https://one.hikvision.com/#/link/nipWaectFcwClNGrkcAT

Hi, I have another question. When I login to the Hikvision Netdisk, it prompts
19000007:单点自动登录失败，请联系工作人员处理。

I visit that link with another browser and found all 20 datalists, chrome just shows me 10 of them.
thanks!

Hi, when i access the link, it is required to log in as the attached image? how should i register for account in order to download the data?

thank you very much.


chore: fix update check tests downloading deps

Deno looks up the cache dir via HOME. We replaced that with a tmp dir in our tests, which lead to all dependencies being downloaded from scratch. This PR changes that so that we use a different environment variable for our tests. That way we can reuse the existing cache which is much faster.

Merging myself since this just speeds up tests.


Implement on the fly prediction with ranger given a single data sample

Need to implement prediction for a given data sample rather than just batch predictions from reading a CSV file. Suggested command parameters:
./OrbitAI_ranger --includevars PD1,PD2,PD3,PD4,PD5,PD6,LABEL --input 0.01,0,1.12,0.29,0,0.02,1 --predict ranger_out.forest
./OrbitAI_ranger --includevars PD1,PD2,PD3,PD4,PD5,PD6,LABEL --input 0.01,0,0.28,0.2,0.01,1.16,0 --predict ranger_out.forest

Maybe we just re-use the capability of ranger to predict on a given file (--file) that will contain just one sample? This would save time since we avoid having to implement a parser of N-dimension data for the --input argument.
Unless you think you can easily re-use what exists to parse the one line of the --file, then I'm ok with this.

@TanguySoto I'll give myself a few hours to see if I can adapt ranger to take in a string of values via command argument but if it requires too many disruptive untested changes then I will do as you suggest.

I ended up implementing the solution proposed by @TanguySoto.


[FEATURE] Tracing search functionality - Jaeger gap

Problem: A popular use case for trace analytics is being able to search for specific requests (traces) based on a set of criteria that defines the issue - to troubleshoot, users can search based on service (optional), operation (ALL or a specific one), context (optional, some otel tags, e.g error=true), time frame, min duration (optional), max duration (optional), number of expected results (traces)
This allow focusing on traces that match a certain incident and serves as a good point to start a troubleshooting scenario.
The Jaeger search screen and search results is brought as an example. It allows to execute a search without the need to apply a specific search syntax like Lucene

Results provide a rich description (quick glance) of the traces found as well as a timeline diagram with the traces found mapped to duration and number of spans(size of bubble)
This can be a basis for a friendlier and more effective search experience

Thanks for submitting an issue, a few questions for clarification:

what does it mean to search based on number of expected results (traces)?
what is operation and context? I assume it's similar to name and user defined tags, would be helpful if you could confirm them in our schema:
https://github.com/opensearch-project/data-prepper/blob/99ad5ad2f616bd83a408cbc98a44381298ac329b/docs/schemas/trace-analytics/otel-v1-apm-span-index-template.md#fields

Also got similar feedback from another customer. I would also add

Search for matching spans, in addition to matching traces
Lets also include searching for tags or attributes that can be added in OTEL format. Customer for example was adding product descriptors to the traces and wanted to search for them

Adding here as a reference - some example on a better ux for searching traces (and spans)
It is highly relevant that the search itself provides a good experience and makes it easier on searching, rather than that having the functionality available

@anirudha let's label this as jaeger-gap


Docs, introduce Installation, Bootable, Galleon Guides and Galleon layers table

Docs change:

index.adoc, reference new Guides,
Installation Guide, help you choose the kind of installation that best fits your needs.
Bootable JAR Guide
Galleon provisioning extracted from Admin Guide to separated Guide.

I'm poking around and am going to make random comments. :)
The basic structure seems useful.
Any use of "Java EE" must be changed to "Jakarta EE".

Another generic comment is:
s/Microprofile/MicroProfile
Also, the first use of MicroProfile in a document should be "Eclipse MicroProfile" but after that it can just be "MicroProfile".

@bstansberry , thank-you. In addition I removed references to servlet and core feature packs from the Galleon guide, we can achieve the same use-cases with wildfly FP + layers.

I killed the CI jobs for this. If you push again today please wait until CI starts and then kill the jobs so we don't waste the resource that we may want used to process an urgent task.

@jfdenise In the layers table I'd like to see coverage of "alternatives". Possible way to handle this:

Before the table an explanation of what "alternatives" means.
In the table in the "Description" column, if a layer has an alternative put in a new line and then "Alternative: " with Alternative in italics or perhaps bold.

I submitted https://github.com/jfdenise/wildfly/pull/1 with input re the layers list.
I think we should find a different way to present the optional layer deps as the nested table takes a lot of space and looks a bit odd.  Perhaps a simple list of names with optional ones italicized?  My PR includes some initially text explaining the table so the meaning of the italics could be out there. Or just write (optional) after the optional ones.
I think the Installation Guide could use an opening paragraph.

@bstansberry , I removed the nested table. I added a sentence to introduce the Installation Guide.

@darranl , thank-you I implemented a bunch of your comments. Thank-you.

@bstansberry @darranl , I have force-pushed your suggestions. Let me know if you have some more, if not I will squash commits. Thank-you.

@jfdenise I sent up another batch at https://github.com/jfdenise/wildfly/pull/2. Once you've done what you want with those suggestions I think you can go ahead and squash.
Great job!

I don't think I need another pass unless you want me to, most of my comments were just my opinions but from the discussions they have either been implemented or discussed so it sounds like we will be good to go.
Overall a really nice set of changes to the documentation.

Thanks @jfdenise @yersan @darranl  -- big progress here!


Add link to new Scala API in README

A new Scala (JVM) API is available & maintained by Enliven Systems here: https://github.com/enlivensystems/invoicing-hungarian
It could be useful for others if they happen to find this repository first. The above repository also refers to this PHP codebase.

It's great to see other open source implementations in different languages, I've just added to the README.


Quote Driven Market Implementation

Quote Driven Market Implementation
Implementation of:

Quote Creation
Quote Deletion
Quote Tickers and subscription functionality
Accept Quote

OK to merge; some issues to address:
How are stream quotes handled? Not clear.
In https://github.com/EnergyMashupLab/eml-cts/pull/70/commits/618061a8dc237fb02a5396b4b906c0b1650738ee
Does this eliminate the duplicated EiCreateTransactionPayload sent to the party attempting to lift the quote? Appears that it doesn’t, which is OK - but should add comment on evolving spec. My initial choice was two (buy and sell) EiCreateTransactionPayloads PLUS an EiAcceptedQuotePayload, which seems to be what’s in the code.
buyerTransaction and sellerTransaction seem good names for the temp variables. I need a walkthrough. Is this parallel to the split in the Parity bridge/LME marketCreateTransaction? Comment either way, please.
How is cancelQuote handled for stream quotes?
https://github.com/EnergyMashupLab/eml-cts/pull/70/commits/e1c8f2bcfccc0a58b1be71c8f3252c3489a71527
Why are the subscription payloads done using @JsonProperty in addition to the enum? Need comment.
https://github.com/EnergyMashupLab/eml-cts/pull/70/commits/73e5617cf54e0cb63a7bc3f017a45d6f11fd4766
The @Override in SubscriptionIdType.java needs a comment on use - the SubscriptionId the RefId for the message as described in the spec line 1305.
https://github.com/EnergyMashupLab/eml-cts/pull/70/commits/016125cd9121856b53fe4633f78fa30d4bd10085
A comment on why the change to ArrayList (and the performance implications and threads safety) is needed.
TeuaRestController.java - where are the new PostMappings clientCreateQuote and clientCreateStreamQuote documented?
Where the new PostMappings documented? Wiki and comments?
Old:
@PostMapping("{teuaId}/createTransaction")
@PostMapping("/cancelTender")
@PostMapping("{teuaId}/clientCreateTender")
New:
@PostMapping("{teuaId}/clientCreateStreamTender")
@PostMapping("{teuaId}/clientCreateStreamQuote")
@PostMapping("{teuaId}/clientCreateQuote")
@PostMapping("{teuaId}/clientAcceptQuote")
@PostMapping("{teuaId}/clientCancelQuote")
@PostMapping("{teuaId}/clientManageTickerSubscription”)


Merge upstream/master to googletest/hunter

Mostly because it fails to compile on newer version of MSVC2017.
I hope I got conflict resolution right but maybe not.

I hope I got conflict resolution right but maybe not.

Let's see what tests will show.
Released: https://github.com/hunter-packages/googletest/releases/tag/1.8.0-hunter-p11

I saw that you removed the following lines in the CMakeLists.txt files from the original googletest starting at line 104:
# If the CMake version supports it, attach header directory information
# to the targets for when we are part of a parent build (ie being pulled
# in via add_subdirectory() rather than being a standalone build).
if (DEFINED CMAKE_VERSION AND NOT "${CMAKE_VERSION}" VERSION_LESS "2.8.11")
  target_include_directories(gtest      SYSTEM INTERFACE "${gtest_SOURCE_DIR}/include")
  target_include_directories(gtest_main SYSTEM INTERFACE "${gtest_SOURCE_DIR}/include")
endif()

Was this intentionally or an accident? The comment indicates that we do not need them in a hunter package, but I think we should make as view changes as possible to the original version. But as it is already merged I think we can leave it as is, as long as nobody complains.

target_include_directories(gtest SYSTEM INTERFACE "${gtest_SOURCE_DIR}/include")

Just for the record this is not correct in general. You should never put full path to PUBLIC/INTERFACE includes. It's an error with or without Hunter. Fix is to use $<BUILD_INTERFACE:...>.

@Knitschi
I believe that they were removed before my merge due to 35d5f03cd0960 so I decided to keep it that way. The merge conflicts was there because these lines changed a bit in upstream but they weren't fixed like in comment by @ruslo so CMake was complaining. I think that would be good thing to push $<BUILD_INTERFACE:...> stuff to upstream and keep them but can't promise to follow through on that :)

Ok ok I shut up. I guess ruslan told me back then to remove the stuff.


Integrate the range check trace with the VM execution trace

This PR closes #143 by adding the trace generated by the RangeChecker to the overall execution trace.

A note about testing -
Because the trace length is now 1024 (the minimum for the range checker), the some aspects of the aux table trace tests relating to the padding were no longer useful, and I've removed them.

I think we need come up with a good way to test the overall execution trace to make sure we're covering situations where the length is driven by any of the different components.
Additionally, I think that the aux table trace tests should perhaps stay in the processor when the other integration tests move.

It didn't make sense to include these things in the same PR, but please let me know your thoughts.


Create def for "Jinkies" sound effect for yellow letter events

It would be funny to hear "Jinkies" when someone gets horribly killed

Sound effect already added and converted to correct format, just needs def


Gateway bootstrap peer connect is synchronous

If a bootstrap peer somehow gives an I/O timeout this causes the gateway to take a long time to finish starting

closed in https://github.com/threefoldtech/rivine/pull/592


Program or web interface to download all final submissions for an assignment

We need a robust & standard way to download all final submissions for an assignment. (I know @soumyabasu has some kind of script, but let's make sure that the script is sufficiently documented so that exporting submissions is straightforward.

I talked with @soumyabasu about adding this to the ok-client. It could then also be used by students to download their latest backup from the server (this might make sharing between partners easier as well). I have a bit of code written for this, but I'd want to see the existing script before proceeding further to make sure I implement it properly.

Adding batch download to ok-client sounds like a good idea to me. We need a way to restart a batch download when it's only half-complete and something goes wrong.

@soumyabasu, could you upload your script somewhere so I can reference it when implementing this? Thanks!

Sent you all of the scripts via email.
The long term solution for using the API is to understand this file: https://github.com/Cal-CS-61A-Staff/ok/blob/master/server/app/api.py

I've added this on this branch where the --submissions option overrides the client's normal behavior and instead downloads all  final submissions for the provided assignment (the --course option can be used to specify a course ID, though the client will prompt the user to select a course if this isn't provided). It should also be able to resume downloading if something goes wrong.
I don't have automated tests for this yet and I'm not sure how to write them since they depend on a server. I'm also not sure how well this works in relation to partners on an assignment.

Nice work- it looks like the right shape. One thing that might get annoying is that we'll have the list of every course on ok being displayed all the time. I think your code is laid out well enough though to handle pretty easily.
To test, you should mock out the API calls to the server. Maybe something like [1] might be helpful. Also, you should think of a general way to do this in case someone wants to add a feature like yours and needs to mock out requests to ok-server unless @albert12132 has already done this?
[1] https://pypi.python.org/pypi/requests-mock

Oh, one thing- the server might return a permission error, so you should look at the response code and display the right error message. (Imagine if a student tries to download everything)

I'll take a look at this either tonight or tomorrow night. In the meantime,
feel free to make a PR so that we can comment on the code. All of the
current server communication code is untested, so there's not really a good
testing framework set up. I can work with you on developing tests once I
review the code.
On Fri, Jun 5, 2015, 9:06 PM soumyabasu<EMAIL_ADDRESS>wrote:

Oh, one thing- the server might return a permission error, so you should
look at the response code and display the right error message. (Imagine if
a student tries to download everything)
—
Reply to this email directly or view it on GitHub
https://github.com/Cal-CS-61A-Staff/ok/issues/444#issuecomment-109493436
.

I have api_request displaying Only members of the course staff can export submissions. and exiting if it gets a 401 error.

Ah, kk. I missed that line- good job. :)

https://github.com/Cal-CS-61A-Staff/ok-client/pull/77 implements a client-based solution to this, although eventually there should be a web interface that supports submission downloads.


serious issue developed after libwrapper update

having custom hotbar enabled stalls foundry due to new libwrapper update. please fix.

Same here. Game doesn't load properly.
In the console a number for rendering the CostumHotbar keeps counting.

Thanks for your support!

Thanks folks. I'm traveling, but I'll update later today .
Please let the author of libwrapper know also. I don't believe this is a custom hotbar issue really because I do not use lib wrapper as a dependency (that I recall off the top of my head anyway, has been a while)

It turns out that this was never an issue with Custom Hotbar but with LibWrapper. Custom Hotbar does not even include LibWrapper.
My understanding is that this was very promptly fixed by the LibWrapper author and there's nothing for me to do here. If this is not true, please reopen this issue and let me know, thanks.


playing current time and duration get wrong

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
If needed, include code examples for the problem or steps to reproduce.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Version [e.g. 0.7.0]

Smartphone (please complete the following information):

Device: [e.g. iPhone6, Simulator iPhone6 ...]
OS: [e.g. iOS8.1]
Version [e.g. 0.7.0]

Additional context
Add any other context about the problem here.

You have to provide more details to explain your problem.

have same issue


training cost

Dear team,
Thanks for sharing the great work.
Could you please share how long it takes to train EfficientViT-B1? (and on how many gpus?)
Looking forward to your reply:)

did you find out? @JunMa11


Error while installing & serve:ing with both NPM & Yarn

I've been trying to install and get this to work.
When I tried using NPM, I got the same type of errors as this issue: https://github.com/ZachJW34/nx-plus/issues/189 , both in NPM 7 & using lower versions of NPM like the recommendation in the issue above.
So I turned to Yarn. But I still are getting errors and can't get Nuxt to work.
Yarn -v
1.22.10

node -v
14.17.6

nx serve my-app

First line of errors
Though the "loose" option was set to "false" in your @babel/preset-env config, it will not be used for @babel/plugin-proposal-private-property-in-object since the "loose" mode option was set to "true" for @babel/plugin-proposal-class-properties.
The "loose" option must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled): you can silence this warning by explicitly adding
	["@babel/plugin-proposal-private-property-in-object", { "loose": true }]
to the "plugins" section of your Babel config.
Though the "loose" option was set to "false" in your @babel/preset-env config, it will not be used for @babel/plugin-proposal-private-methods since the "loose" mode option was set to "true" for @babel/plugin-proposal-private-property-in-object.
The "loose" option must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled): you can silence this warning by explicitly adding
	["@babel/plugin-proposal-private-methods", { "loose": true }]
to the "plugins" section of your Babel config.
Though the "loose" option was set to "false" in your @babel/preset-env config, it will not be used for @babel/plugin-proposal-private-property-in-object since the "loose" mode option was set to "true" for @babel/plugin-proposal-class-properties.
The "loose" option must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled): you can silence this warning by explicitly adding
	["@babel/plugin-proposal-private-property-in-object", { "loose": true }]
to the "plugins" section of your Babel config.
Though the "loose" option was set to "false" in your @babel/preset-env config, it will not be used for @babel/plugin-proposal-private-property-in-object since the "loose" mode option was set to "true" for @babel/plugin-proposal-class-properties.
The "loose" option must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled): you can silence this warning by explicitly adding
	["@babel/plugin-proposal-private-property-in-object", { "loose": true }]
to the "plugins" section of your Babel config.
Though the "loose" option was set to "false" in your @babel/preset-env config, it will not be used for @babel/plugin-proposal-private-property-in-object since the "loose" mode option was set to "true" for @babel/plugin-proposal-class-properties.
The "loose" option must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled): you can silence this warning by explicitly adding
	["@babel/plugin-proposal-private-property-in-object", { "loose": true }]
to the "plugins" section of your Babel config.
Though the "loose" option was set to "false" in your @babel/preset-env config, it will not be used for @babel/plugin-proposal-private-property-in-object since the "loose" mode option was set to "true" for @babel/plugin-proposal-class-properties.
The "loose" option must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled): you can silence this warning by explicitly adding
	["@babel/plugin-proposal-private-property-in-object", { "loose": true }]
to the "plugins" section of your Babel config.
Though the "loose" option was set to "false" in your @babel/preset-env config, it will not be used for @babel/plugin-proposal-private-property-in-object since the "loose" mode option was set to "true" for @babel/plugin-proposal-class-properties.
The "loose" option must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled): you can silence this warning by explicitly adding
	["@babel/plugin-proposal-private-property-in-object", { "loose": true }]
to the "plugins" section of your Babel config.
Though the "loose" option was set to "false" in your @babel/preset-env config, it will not be used for @babel/plugin-proposal-private-property-in-object since the "loose" mode option was set to "true" for @babel/plugin-proposal-class-properties.
The "loose" option must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled): you can silence this warning by explicitly adding
	["@babel/plugin-proposal-private-property-in-object", { "loose": true }]
to the "plugins" section of your Babel config.
Though the "loose" option was set to "false" in your @babel/preset-env config, it will not be used for @babel/plugin-proposal-private-property-in-object since the "loose" mode option was set to "true" for @babel/plugin-proposal-class-properties.
The "loose" option must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled): you can silence this warning by explicitly adding
	["@babel/plugin-proposal-private-property-in-object", { "loose": true }]
to the "plugins" section of your Babel config.
Though the "loose" option was set to "false" in your @babel/preset-env config, it will not be used for @babel/plugin-proposal-private-property-in-object since the "loose" mode option was set to "true" for @babel/plugin-proposal-class-properties.
The "loose" option must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled): you can silence this warning by explicitly adding
	["@babel/plugin-proposal-private-property-in-object", { "loose": true }]
to the "plugins" section of your Babel config.
Though the "loose" option was set to "false" in your @babel/preset-env config, it will not be used for @babel/plugin-proposal-private-property-in-object since the "loose" mode option was set to "true" for @babel/plugin-proposal-class-properties.
The "loose" option must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled): you can silence this warning by explicitly adding
	["@babel/plugin-proposal-private-property-in-object", { "loose": true }]
to the "plugins" section of your Babel config.
Though the "loose" option was set to "false" in your @babel/preset-env config, it will not be used for @babel/plugin-proposal-private-property-in-object since the "loose" mode option was set to "true" for @babel/plugin-proposal-class-properties.
The "loose" option must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled): you can silence this warning by explicitly adding
	["@babel/plugin-proposal-private-property-in-object", { "loose": true }]
to the "plugins" section of your Babel config.
Though the "loose" option was set to "false" in your @babel/preset-env config, it will not be used for @babel/plugin-proposal-private-property-in-object since the "loose" mode option was set to "true" for @babel/plugin-proposal-class-properties.
The "loose" option must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled): you can silence this warning by explicitly adding
	["@babel/plugin-proposal-private-property-in-object", { "loose": true }]
to the "plugins" section of your Babel config.
Though the "loose" option was set to "false" in your @babel/preset-env config, it will not be used for @babel/plugin-proposal-private-property-in-object since the "loose" mode option was set to "true" for @babel/plugin-proposal-class-properties.
The "loose" option must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled): you can silence this warning by explicitly adding
	["@babel/plugin-proposal-private-property-in-object", { "loose": true }]
to the "plugins" section of your Babel config.
Though the "loose" option was set to "false" in your @babel/preset-env config, it will not be used for @babel/plugin-proposal-private-property-in-object since the "loose" mode option was set to "true" for @babel/plugin-proposal-class-properties.
The "loose" option must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled): you can silence this warning by explicitly adding
	["@babel/plugin-proposal-private-property-in-object", { "loose": true }]
to the "plugins" section of your Babel config.
Though the "loose" option was set to "false" in your @babel/preset-env config, it will not be used for @babel/plugin-proposal-private-property-in-object since the "loose" mode option was set to "true" for @babel/plugin-proposal-class-properties.
The "loose" option must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled): you can silence this warning by explicitly adding
	["@babel/plugin-proposal-private-property-in-object", { "loose": true }]
to the "plugins" section of your Babel config.
Though the "loose" option was set to "false" in your @babel/preset-env config, it will not be used for @babel/plugin-proposal-private-property-in-object since the "loose" mode option was set to "true" for @babel/plugin-proposal-class-properties.
The "loose" option must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled): you can silence this warning by explicitly adding
	["@babel/plugin-proposal-private-property-in-object", { "loose": true }]
to the "plugins" section of your Babel config.

Second line of errors
ERROR in ./dist/apps/my-app/.nuxt/client.js
Module build failed (from ./node_modules/babel-loader/lib/index.js):
Error: /Users/userX/Sites/nx-test-repo/dist/apps/my-app/.nuxt/client.js: Cannot find module '@babel/preset-env/lib/utils'
Require stack:
-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>- /Users/userX/Sites/nx-test-repo/node_modules/babel-loader/lib/index.js
- /Users/userX/Sites/nx-test-repo/node_modules/loader-runner/lib/loadLoader.js
- /Users/userX/Sites/nx-test-repo/node_modules/loader-runner/lib/LoaderRunner.js
- /Users/userX/Sites/nx-test-repo/node_modules/webpack/lib/NormalModule.js
- /Users/userX/Sites/nx-test-repo/node_modules/webpack/lib/NormalModuleFactory.js
- /Users/userX/Sites/nx-test-repo/node_modules/webpack/lib/Compiler.js
- /Users/userX/Sites/nx-test-repo/node_modules/webpack/lib/webpack.js
-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>- /Users/userX/Sites/nx-test-repo/node_modules/nuxt/dist/nuxt.js
-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:889:15)
    at Function.Module._load (internal/modules/cjs/loader.js:745:27)
    at Module.require (internal/modules/cjs/loader.js:961:19)
    at Module.require (/Users/userX/Sites/nx-test-repo/node_modules/@nrwl/tao/src/compat/compat.js:7:40)
    at require (internal/modules/cjs/helpers.js:92:18)
    at PluginPass.Program (/Users/userX/Sites/nx-test-repo/node_modules/@nuxt/babel-preset-app/src/polyfills-plugin.js:15:34)
    at newFn (/Users/userX/Sites/nx-test-repo/node_modules/@babel/traverse/lib/visitors.js:177:21)
    at NodePath._call (/Users/userX/Sites/nx-test-repo/node_modules/@babel/traverse/lib/path/context.js:53:20)
    at NodePath.call (/Users/userX/Sites/nx-test-repo/node_modules/@babel/traverse/lib/path/context.js:40:17)
    at NodePath.visit (/Users/userX/Sites/nx-test-repo/node_modules/@babel/traverse/lib/path/context.js:100:31)
    at TraversalContext.visitQueue (/Users/userX/Sites/nx-test-repo/node_modules/@babel/traverse/lib/context.js:103:16)
    at TraversalContext.visitSingle (/Users/userX/Sites/nx-test-repo/node_modules/@babel/traverse/lib/context.js:77:19)
    at TraversalContext.visit (/Users/userX/Sites/nx-test-repo/node_modules/@babel/traverse/lib/context.js:131:19)
    at Function.traverse.node (/Users/userX/Sites/nx-test-repo/node_modules/@babel/traverse/lib/index.js:82:17)
    at traverse (/Users/userX/Sites/nx-test-repo/node_modules/@babel/traverse/lib/index.js:62:12)
    at transformFile (/Users/userX/Sites/nx-test-repo/node_modules/@babel/core/lib/transformation/index.js:105:29)

Should somebody else stumble on this while trying this out, here's the solution I found on StackOverflow
Adding the following to my nuxt.config.js fixes this:
export default {
  //  ....
  build: {
    babel: {
      presets({isServer}) {
        const targets = isServer ? { node: 'current' } : { ie: 11 }
        return [
          [ require.resolve("@babel/preset-env"), { targets }  ]
        ]
      },
      plugins: [
        "@babel/syntax-dynamic-import",
        "@babel/transform-runtime",
        "@babel/transform-async-to-generator"
      ]
    },
  }
  // ....
}

I'm not much further than this yet, but at least it allows me to proceed.


ContentView

I there some way to have some box where react-tooltip-lite can be shown?
If not this will be pretty nice feature.
Example:
I have box with size 200 & 300, inside box i have button with react-tooltip-lite
So if i hover over or click on the button, react-tooltip-lite will just show inside "box" & not outside (respect box dimensions for showing tooltip only inside box).
Thanks.

Hi @gjabelAmbitas there's no feature like this currently.  You could use an iframe to get this effect, as the tooltip will respect it's surrounding window.  I'm a little unsure of why exactly you'd want this, can you elaborate more about the user experience you're going for?

Closing because as far as I can tell this is not something we'll want to do.


dita -install does not work (DITA-OT 2.1.2)

The dita -install myplugin.zip command does not work with DITA-OT 2.1.2. It works using the DITA-OT 2.2.1.
What I did:

Launch startcmd.bat.
cd bin
dita -install myplugin.zip

No error message appears. Maybe this is related to #2002.

One thing that may or may not be related: if you use the dita command, do not use the startcmd.bat. Instead, open a new Command Prompt from start menu.

Could you rerun the integration with -d argument to get some more logging?

Opening a command line interface my launching cmd.exe makes no difference. The -d parameter does not help.
C:\Users\eike\DITA-OT\dita-ot-2.1.2\bin>dita -d -install com.oxygenxml.webhelp.zip
Unable to locate tools.jar. Expected to find it in C:\Program Files\Java\jre1.8.0_66\lib\tools.jar
Searching for integrator.xml ...

If this works in 2.2 but not in 2.1, I'm somewhat inclined to mark this as won't fix, as we don't have the resources to maintain older versions. @robander what's you're take.

I'd suggest that the DITA-OT should have Long Term Support versions, that will receive some picked cherrys for at least 12 months or so. Our plugins are incompatible with 1.8.5, but each new 2.x version closes some bugs and ships new ones. Or you should explain, that the OT is a rolling release tool, that has to be updated by vendors in real time, like a browser. LTS is probably what the vendort want.

LTS is what vendors want, but because no vendor is willing to do the work, we're stuck with the resources we currently have. OT is not a rolling version number since we don't release e.g. every 6 weeks. However, due to resource limits, we can't really update versions other than the latest release (2.2 as of writing this). When we relese 3.x, we will probably update 2.x for a while. But, the support will not last that long and all resources are directed to the latest development.

Closing as we currently don't intend to release new bug fixes in 2.1 branch.

Late to this as I was out of the office, but agree to what @jelovirt said above. I'd love to have LTS for at least the last couple of major releases, but with the current team that's not possible. I think we carried on releasing fixes for 1.8.x a bit longer than usual when 2.0 came out, and that's probably going to be the same for the last major 2.x when we  come out with a 3.0. Otherwise, we're limited by the current resources.