defining and modifying palettes on-the-fly

Reported by andrew wittenberg on 25 May 2013 00:32 UTC
(This discussion was moved here from ticket #2042.)
It would be great to be able to create palettes on-the-fly, as well as slightly modify existing palette (.spk) files.
Example of on-the-fly palette generation:
! On-the-fly emulation of redscale.spk
SHADE/PALETTE=(By_Percent,(0,0,0,0),(100,100,0,0))

A much simpler syntax could be used for a single-color palette:
! Overlay a dark-green land mask.
SHADE/OV/PALETTE=(0,25,0) IF rose GT 0 THEN rose

Modifying existing palettes could be done either via modifying a .spk file to create a new .spk file, or (better) on-the-fly via the /PALETTE qualifier.  Helpful operations would include:
   SCALE: multiply palette colors by a 3-tuple

   ADD: add a 3-tuple to palette colors

   SHIFT: shift palette range [A2](A1,) to [B2](B1,)
      (intermediate values are scaled appropriately)
      (any existing palette vertices within [are overwritten)
      (flipping [lo,hi](B1,B2]) reverses the palette)
      (final By_Percent values exceeding [0,100] would yield an error.)

Order of precedence would be: SHIFT, then SCALE, then ADD.
Anywhere the resulting color percents exceeded 0 or 100, they would be clipped at 0 or 100.
Possible syntax for on-the-fly palette modification:
! make a palette darker
SHADE/PALETTE=(redscale,SCALE=(.5,.5,.5))

! change redscale to "inverse cyanscale"
SHADE/PALETTE=(redscale,ADD=(0,100,100))

! stretch top half of palette to the full range
SHADE/PALETTE=(redscale,SHIFT=(50,100)(0,100))

! reverse a palette
SHADE/PALETTE=(redscale,SHIFT=(0,100)(100,0))

! Several operations in one step: in this case the net result
! is a palette with red saturation running from 75% -> 50%.
SHADE/PALETTE=(redscale,SHIFT=(50,100)(100,0),SCALE=(.5,.5,.5),ADD=(25,0,0))

Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/2073

Comment by andrew.wittenberg on 25 May 2013 01:00 UTC
See also #1329.

Modified by karl.smith on 25 May 2013 03:07 UTC

Comment by andrew.wittenberg on 4 Apr 2014 20:05 UTC
By the 80/20 rule, I'd suggest starting with just the single-color on-the-fly palette specification first:
POLYGON/PALETTE=(25,0,0) {0,1,0,0},{0,0,1,0}

This would be really handy for overlaying filled polygons with arbitrary colors.

Comment by steven.c.hankin on 7 Apr 2014 16:21 UTC
(I have not been tuned into this ticket in the past, so plz forgive my left-field entry.)
Can we find a way to fit these new capabilities into Ferret through the existing Ferret command syntax?  For example, could we envision operations like SHIFT and ADD as command qualifiers?  This approach would suggest family of commands such as
DEFINE PALETTE/COLORS=<some color syntax> my_palette
DEFINE PALETTE/LIKE=old_palette/ADD=/SHIFT=  my_palette
SET PALETTE/ADD=/SHIFT my_palette
CANCEL PALETTE my_palette
SHOW PALETTE my_palette
SAVE PALETTE/FILE= my_PALETTE

Admittedly, this approach means that it takes an extra command to tweak the colors of the plot that is on the screen.  But there are some offsetting advantages ... including code complexity, the ability to save and reuse the palette, documentation needs, etc.  (e.g. SHOW COMMANDS informs the user of the qualifiers)
In the meantime, it is possible to explore the concepts trough the creation of (pretty simple) scripts
GO PALETTE_CREATE  <some color syntax> my_palette.spk   [PALETTE_ADD     <some color syntax> my_palette.spk   [existing_palette](existing_palette]
GO)
GO PALETTE_SHIFT   <some color syntax> my_palette.spk   [existing_palette]

Tweaking the colors of a plot could even be recalled and edited as a single command
GO PALETTE_SHIFT my_palette;   SHADE/PALETTE=my_palette my_var    ! tweaked plot

My recollection is that there are some scripts around already that illustrate creation and modification of palette files.


Guar

Mod source
Factorio Mod Portal
Which mod are you having an issue with?

[ ] pyalienlife
[ ] pyalternativeenergy
[ ] pycoalprocessing
[ ] pyfusionenergy
[X] pyhightech
[ ] pyindustry
[X] pypetroleumhandling
[ ] pypostprocessing
[ ] pyrawores

Operating system

=Windows 10

What kind of issue is this?

[ ] Compatibility
[X] Locale (names, descriptions, unknown keys)
[ ] Graphical
[ ] Crash
[ ] Progression
[ ] Balance
[ ] Pypostprocessing failure
[X] Other

What is the problem?
In medium py, there is a tech called gaur-processing that doesn't have a locale processing
Steps to reproduce
No response
Additional context
No response
Log file
No response

Fixed.


Change upload format from base file

Change upload format from base file and show, hide buttons to download

not acceptable to change in base file.


import garden using sqlite

This imports 2 ways.

looks at sqlite database and sees if there's a last_sha for user, if exists, only pull the changed files between last sha and now
if last_sha doesn't exist pull all files into database and set last_sha to current sha

Just saw this now, will try to poll for PRs more often or uprank associated notifications :)
Thank you! :D


Fix tests for latest version of mosquitto

Codecov Report

Merging #90 (3b2780d) into main (5ebb6fc) will decrease coverage by 2.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   78.93%   76.61%   -2.33%
==========================================
  Files          22       20       -2
  Lines        2312     2219      -93
==========================================
- Hits         1825     1700     -125
- Misses        487      519      +32

Impacted Files
Coverage Δ

Sources/MQTTNIO/MQTTListeners.swift
73.68% <0.00%> (-26.32%)
:arrow_down:

Sources/MQTTNIO/MQTTClientV5.swift
62.92% <0.00%> (-15.74%)
:arrow_down:

Sources/MQTTNIO/MQTTConnection.swift
80.95% <0.00%> (-12.50%)
:arrow_down:

Sources/MQTTNIO/MQTTClient.swift
78.19% <0.00%> (-4.70%)
:arrow_down:

Sources/MQTTNIO/MQTTProperties.swift
77.73% <0.00%> (-1.69%)
:arrow_down:

...s/MQTTNIO/AsyncAwaitSupport/MQTTClient+async.swift

...MQTTNIO/AsyncAwaitSupport/MQTTClientV5+async.swift

...urces/MQTTNIO/ChannelHandlers/PingreqHandler.swift
90.90% <0.00%> (+30.90%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ebb6fc...3b2780d. Read the comment docs.


Fix some syntax error of rst format.

There are some errors about verbatim.
One is verbatim can't be nested and the other is content may not start with whitespace.

Thanks for the fixes.


Issue #208 -- Disable generating parser.out

By default the ply/yacc parser generator runs in debug mode. This
creates a parser.out file in the directory parser.py is located. The
user which runs flanker does not always have access to this directory,
which causes 'permission denied errors.'
See https://github.com/mailgun/flanker/issues/208

Can one of the admins verify this patch?

up

retest this please


[Draft] add landscaper-service blueprint

What this PR does / why we need it:
This PR adds a blueprint that can be used to install the landscaper service.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Release note:

Add blueprint to install the landscaper service with the landscaper.

This PR needs a rebase on main once #5 is merged.

This PR needs to be rebased agains main once #6 is merged.


[feat] Proof of D.O.G.E.

I saw Elon's Tweeter and would like to help develop Doge.
I have an idea. I propose to develop a mining system/software to cluster all miner's devices as a cluster computing supercomputer(s) to solve human's current computing challenges. Scientists, engineers, mathematicians, and others can use computing power for their researches to save the world, such as renewable energy, space science, electric vehicle, and etc. It will reduce the cost to develop supercomputers and put all mining energy to good use as the DOGE's spirit, Do Only Good Everyday!! Using the proof of D.O.G.E. to get the reward.
1 Dogecoin = 1 Dogecoin. To the moon!!!
Best Regards,
LCo

Somehow that is how I see a cryptocurrency now, instead of a ponzi scheme. I see it as a pool of dog money that you can take it when you need, like you lose 1 DOGE and get a low valued fiat to buy groceries and stuff. But regarding your idea this is something too hard for us to develop, not that it is a bad idea, just a bit out of scope i think.

Things like BOINC already exist. I'm not sure that we would be adding anything new and in the end, we would just be dividing the computing we have.

This is already being done by the Banano meme coin. You can Fold@Home to earn Banano (reddit.com/r/banano if you're curious).

Thank you for all your inputs. I did not know those exist already. Those are great and hope they will succeed. I learned a lot today.
BOINC doesn't have a cryptocurrency as rewards to motivate people, and Banano is focusing on medical research, which is wonderful. I will look into that for sure.
I am thinking maybe Dogecoin can focus on ML (ex. auto-pilot), big data or a specific computing area? There are massive needs for computing power I can see, and many of them can help our world become better.

how about cure and folding at home, also similar perhaps

Would https://www.dogecoinfah.com/ be a close enough match to what you're trying to achieve?

Would https://www.dogecoinfah.com/ be a close enough match to what you're trying to achieve?

oh yea, probably

Yes! Thank you for spending time to react to all of our crazy suggestions. DOGE is great because of people. Thank you again, Ross and your team for keeping DOGECOIN strong and great.
To the moon!
best regards,
LCo
A Doge Hodler since 2018.

By the way, dogecoinfah.com and fold @ home are great. I love their ideas. However, it is relying on donations (100 doges per week for all contributors). Is it possible to have DOGECOIN-Official to support that program, so it becomes a more "mining-like" work for D.O.G.E. and a long-term contribution to the world? Thank you again. :)


[FR][Terminal] clear method

Would be nice to have a clear method.
Related discussion: https://github.com/Microsoft/vscode/issues/17678

This was added a while ago: workbench.action.terminal.clear

thanks @Tyriar will have to take a look and try to use it.

I have two terminals when  i execute this commands ,just one terminal are clear it .
i would like to apply to all terminals.

I have two terminal, when i use it just clear one terminal.
i would like to clear all terminals,, how can i do it? .
thanks.

@NumberX no way currently, via the API you would need https://github.com/Microsoft/vscode/issues/13267

thanks for replay ,how we can use it?
2017-04-26 19:31 GMT+01:00 Daniel Imms<EMAIL_ADDRESS>
@NumberX https://github.com/NumberX no way currently, via the API you
would need #13267 https://github.com/Microsoft/vscode/issues/13267
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/17895#issuecomment-297500953,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AT_EGk-D2yNtqgzykyUWbrAn-kzS7kMAks5rz42GgaJpZM4LXhPA
.

@NumberX vscode.commands.executeCommand should work https://code.visualstudio.com/docs/extensionAPI/vscode-api

I would like to add textbox and button to the top of terminal in debug mode
.
2017-05-03 2:59 GMT+01:00 Daniel Imms<EMAIL_ADDRESS>
@NumberX https://github.com/NumberX vscode.commands.executeCommand
should work https://code.visualstudio.com/docs/extensionAPI/vscode-api
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/17895#issuecomment-298807360,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AT_EGsVUNTq3EMgMgdGYFMzaENqXjZ54ks5r199vgaJpZM4LXhPA
.


Do you can set title with Unicode

Hello
With title is Vietnamese, Chinese, Japanese --> title output is not support utf8 unicode right now.
so you can add this in next version please. Thank you so much

Hi @hoan277 !
Thankyou for your information.
I recommend you to take a look at issue thread #5.
You need to manually decode the strings if you choose mode="json" (JSON does not store them like that.)
** Please try using mode="dict" or mode="list". **
Let me know if issue still persists.
Feel free to reopen issue.


Consider replacing build.sh with something else

Build.sh is pretty much build around the use of drush make and while it can do composer builds too there are many other options available that can take care of that part.
One such tool is http://magephp.com/ which itself is also based on composer / symphony.

How about a GNU makefile?

that could be one option too.
Basically what we would need:

Tool where we can define our custom commands
Something that is easy to configure (e.g. yaml)
...
...

Might be also good to consider: https://github.com/capistrano/capistrano
There are symfony deployment recipes around as an example.

In my company, we're now about to switch from build.sh to Capistrano. "We" are using Capistrano for non-Drupal projects so this is a natural choice for us.

I have also looked into Deployer, which is a PHP based tool that seems to work in a similar way to Capistrano. That one has the advantage of not adding non-PHP dependencies.
https://deployer.org/


Token validation

Hey,
When i submit a request with a total failing token:
moncullllfjmdqsjkhgflkqdjshfgkjhsdfkjghlskjdhflksjghslkdfjhglskjdfhglksjhdflgkjshdflgkjhsdflkjghslkdfjhglskjdfhglksjdfhglkjsdhfglkjsdfh
I get a success instead of an error. I think it's an API issue.
What can i do?

That is indeed the behavior of the tracking API. In the interest of getting your requests turned around as quickly as possible, the server basically just checks that they're formatted and signed correctly and have gone into the data ingestion pipeline. Matching the token to an existing project happens outside of the request cycle. If you want to discuss how that might impact your specific use case, email us at<EMAIL_ADDRESS>and we'll be happy to help!


Thread release and play end of buffer

Change the run loop termination condition so when there is nothing to do it will exit - otherwise the thread sits there after the stream plays doing nothing, using up resources.
Removing self.isPlaying = NO from the TDAudioStreamEventEnd handling as that is just the end of the stream - the queue still has buffered data to play, so the stream is still playing. [self.audioQueue finish] instructs it to flush out the rest of the queued data and then stop.
Adding self.isPlaying = NO; to the error handler and audioQueueDidFinishPlaying, the latter of which is called when the queue runs out of data to play and the stream is really finished.
Making the notifications come from the self object rather than nil - makes no difference if you were listening to nil (ie all) but enables differentiation of the stream you are listening too.

This looks good too!


Fix modal close callback

When we called unmount on a modal mounted by not opened, it was calling closeCallback prop which was causing some issues further down the road.

Codecov Report

Merging #599 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #599   +/-   ##
=======================================
  Coverage   99.72%   99.72%
=======================================
  Files         259      259
  Lines        6537     6537
  Branches     1525     1525
=======================================
  Hits         6519     6519
  Misses         18       18

Impacted Files
Coverage Δ

src/components/modal/Modal.tsx
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d333cf...51fb14e. Read the comment docs.


Closes: #1

Updated validation.py python script.
Fixed the behavior of validate_user function in validations.py.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

googlebot I signed it!
-------- Original message --------From: "google-cla[bot]" @.> Date: 3/11/21  5:23 PM  (GMT-08:00) To: google/it-cert-automation-practice @.> Cc: lamateosmit @.>, Author @.> Subject: Re: [google/it-cert-automation-practice] Closes: #1 (#12862)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ Googlers: Go here for more info.
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.


Propose Logo

Hi. I'm graphic disigner. I would like to know if you are interested that I make a logo for your project? If you allowed me, i"ll make logo for your project for free.
Best Regard

Wow! This is super cool!! Please make a PR that adds this to the front page and I'll approve it ASAP

Daniel Stern | CEO
Ishimura Capital Partners

From: Mirza Zulfan<EMAIL_ADDRESS>Sent: July 2, 2018 11:55 PM
To: danielstern/ngAudio
Cc: Daniel Stern; Mention
Subject: [danielstern/ngAudio] Propose Logo (#201)
Hi @danielsternhttps://github.com/danielstern ,, i'm graphic designer and an open source enthusiast. I would like to contribute to your awesome project. I've designed a logo for your project and its free. if you need something else i'll make it for your project. Thank you
Best Regard. Mirza Zulfan
[ngaudio]https://user-images.githubusercontent.com/36124339/42197935-70720366-7eaf-11e8-9317-ec295a7ea74e.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/danielstern/ngAudio/issues/201, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEEgeAWrO-maJJFA-N1Fqnn3FXs3ixIDks5uCutNgaJpZM4VAQbC.

Thank you @danielstern ..

What kind size you need for the logo?

Hey Mirza.
I'm guessing 1024x768, set to 100% width in the Readme page would be best.
Cheers,
DS

Daniel Stern | CEO
Ishimura Capital Partners

From: Mirza Zulfan<EMAIL_ADDRESS>Sent: July 13, 2018 8:10 AM
To: danielstern/ngAudio
Cc: Daniel Stern; Mention
Subject: Re: [danielstern/ngAudio] Propose Logo (#201)
Thank you @danielsternhttps://github.com/danielstern ..
[42197935-70720366-7eaf-11e8-9317-ec295a7ea74e]https://user-images.githubusercontent.com/36124339/42690791-2ba668a6-8695-11e8-96aa-f08b5c838eea.png
What kind size you need for the logo?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/danielstern/ngAudio/issues/201#issuecomment-404814920, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEEgeBATjsFkcKMmhaM4-Ias34wu1aVtks5uGI4xgaJpZM4VAQbC.

I uploaded the files and updated the readme file. You can get the other version in Gdrive
Here's the pr #202 . Thanks @danielstern
If you need anything changes in the future, dont hesitate to contact me,
Email<EMAIL_ADDRESS>Have a nice day.
Best regards.


Doesn't appear to work with Desktop Safari

I tried with version 10.1.1 on macOS Sierra (10.12.5)

If anybody can reproduce this, please add the browser user agent and more information, like errors in the console or a print screen of the result.


config: allow unknown fields flag

Description: Add a flag allow-unknown-fields that controls whether all fields must be known in the filter configurations.
If allow unknown fields is set to false the following takes effect:

filter configs (represented as proto structs) must only have fields defined in the protos
files loaded from .pb, .yaml, and .json are also checked for known fields

Internal conversions in other parts of the code (upstream transport socket factories, etc) always allow unknown fields.
Proto text always requires known fields (general protobuf constraint).
Protos sent as Any always allow unknown fields. Reasoning here is that if the proto is packed then the schema has already been enforced on the supplier side. I also could not find a way to enforce strict checks in the protobuf API.
Risk Level: Medium. Allow unknown fields is set to false by default, meaning unknown fields will be rejected by envoy.
Testing: Unit tests were updated to have it strict by default. Some wrong filter configs were discovered.
Docs Changes: None
Release Notes:
Add a flag allow-unknown-fields to control validation of filter configurations for unknown fields.
Fixes #4053
/cc @PiotrSikora

@kyessenov quick pre-review comment: I don't agree this should default to false. I think it should default to true. The current default is very confusing for new/less sophisticated users. I would prefer that we go back to what we had before your first change and then allow people to opt-in to not strict behavior.

Sure thing. I'm just concerned about risks of some control planes pushing fields and breaking things. I can change the default to true.

Sure thing. I'm just concerned about risks of some control planes pushing fields and breaking things. I can change the default to true.

I think we can make this clear in the docs and we can guide operators to make the right choice for their deployment? I'm mainly trying to optimize here for what I think is the common case that people want and what will lead to the least amount of support burden.

Internal conversions in other parts of the code (upstream transport socket factories, etc) always allow unknown fields.

What's the reasoning here?

@mattklein123 : I have started down that road but then noticed that there is downcasting happening after conversion. Should I keep going to wire this flag through all the places where any config proto conversion happens?

@mattklein123 : I have started down that road but then noticed that there is downcasting happening after conversion. Should I keep going to wire this flag through all the places where any config proto conversion happens?

@htuch thoughts? I hate to propose a static/global but I wonder if this is one case in which it's the least bad solution for something like this?

(Basically would love to avoid the huge amount of call site changes if possible...)

(Basically would love to avoid the huge amount of call site changes if possible...)

Yeah, would making a Singleton to provide this flag to MessageUtil saves the amount of call site change?

Are we all OK using a singleton / global for this flag? I'm not a fan of hidden switches, but it surely helps with a less invasive change.

Closing this one for now since I think we are converging on the other PR.


research papers added to machine learning folder

#225

Closing this as we are now tracking this under https://github.com/vicky002/AlgoWiki/pull/339 after resolving merge conflicts.


How do you add an item to an array?

var a = [1,2,3];
a.push(4);

Uncaught Exception: <AttributeError('[1, 2, 3]' has no attribute 'push')>
  at <module 'main'>

add an item to array is append, here is the demo.
var a = [1,2];
print(a);
a.append(3);
print(a);
a.append(4,5,6); // you can also add multiple item at once
print(a);
a.pop();  // remove last object
print(a);
print(a.__length__());  // the count of items

you may want join mailing-list of lemon, https://groups.google.com/d/forum/lemon-lang


WEBAPP-85: Convert LocationBig to svg

If you're concerned: I tested it in every browser (IE11, Chrome, FF, Edge, iOS >= 6)

merge!!!


Async status response message should be an envelope

Async status should return an (anonymous) envelope containing the response message and not the response message.

Missing many-js and albert support.

Issues for frontend:

https://github.com/liftedinit/many-js/issues/69
https://github.com/liftedinit/albert/issues/85


Support .tf.json files

Currently tfsec seems to support only configurations in .tf (HCL) files. Terraform does support writing it's configuration in JSON) format, useful when you are generating it programmatically.
It would be good to get tfsec to run on directory made exclusively of .tf.json files. Terraform CDK generates all configuration in json.  I tried running tfsec in such directory, but it reports files loaded         0.
I haven't looked at any other alternative. Please do let me know if tfsec already supports it. In that case, I can submit a PR to update README with a sample usage.

Hi @shirishp - tfsec doesn't support parsing .tf.json files at the moment. we use the hashicorp hcl library for parsing to ensure that the full model is loaded as it would be by terraform, Im not sure they have a similar parse for .tf.json files. I can take a look, but I don't think this will be a priority task

Hey @shirishp and @ademariag apologies for the delay on this, it has been implemented in v0.42.0 - Please raise a new issue if you have any problems


eof_1

@khallock  I believe I am getting back something reasonable from geocat.comp.eofunc(), but I am getting an error when following up with a call to geocat.comp.eofunc_ts().   I may be missing something basic, but from my best reading of the geocat docs, the call I'm making seems correct.
If you copy/paste the current NCL_eof_1_1.py example into a file and run it, you should see an error for the final line that says:
 File "/Applications/PyCharm CE.app/Contents/plugins/python-ce/helpers/pydev/pydevd.py", line 1434, in _exec     pydev_imports.execfile(file, globals, locals)  # execute the script   File "/Applications/PyCharm CE.app/Contents/plugins/python-ce/helpers/pydev/_pydev_imps/_pydev_execfile.py", line 18, in execfile     exec(compile(contents+"\n", file, 'exec'), glob, loc)   File "/Users/bonnland/PycharmProjects/GeoCat-examples/Plots/Contours/NCL_eof_1_1.py", line 164, in <module>     eof_ts = eofunc_ts(xw["slp"], eof, time_dim=1, meta=True)   File "/Users/bonnland/miniconda3/envs/geocat-examples/lib/python3.7/site-packages/geocat/comp/__init__.py", line 780, in eofunc_ts     response = _ncomp._eofunc_ts_n(np_data, np_evec, time_dim, options, missing_value=missing_value)   File "src/geocat/comp/_ncomp.pyx", line 31, in geocat.comp._ncomp.carrayify.wrapper   File "src/geocat/comp/_ncomp.pyx", line 589, in geocat.comp._ncomp._eofunc_ts_n geocat.comp._ncomp.NcompError: An error occurred while calling libncomp.eofunc_ts_n with error code: 3

@bonnland I was able to reproduce that error and trace it back to a bug in the NComp library (the C++ and Fortran code used by GeoCAT-comp). I created a pull request (NCAR/ncomp#23) with a fix and will try to get a new NComp conda package built as soon as I can. Thanks for the update and the bug report!

@khallock   Please review the plot created by this code.   It looks like the first plot is identical to the NCL version, but the other two plots have flipped signs.
Because the EOF computation sounds similar to PCA, I'm wondering if the computed EOF directions come in (postive, negative) pairs, so that the sign is arbitrary (choosing the EOF direction or its negated version is arbitrary).    This is just a huge guess, having not looked at the computation myself.

@bonnland It looks like the arrays being passed to eofunc in Python and in NCL are different and that might be affecting the plots. As a quick check, I printed some information about the first argument arrays being passed to eofunc.
If I addprint(xw["slp"]) at line 160 in NCL_eof_1_1.py, I get:
<xarray.DataArray 'slp' (lat: 23, time: 26, lon: 45)>

And if I add printVarSummary(xw) at line 98 of eof_1.ncl:
Variable: xw
Type: float
Total Size: 103500 bytes
            25875 values
Number of Dimensions: 3
Dimensions and sizes:	[lat | 23] x [lon | 45] x [time | 25]

There seems to be an extra timestep in the Python implementation, so the code that generates that array might be a good place to start poking around. I hope this helps!

Here is a diagnostic plot to verify correct values.    This plot, made by running NCL, shows the first three timesteps of the SLP variable.

@khallock @dcherian   I fixed a bug in my month_to_season() implementation, and now the contour plots look basically correct.   The code can still use some simplifying and cleanup before publishing.
I am, however, getting some strange results when trying to add contour labels.  You can uncomment the "clabel" line to see.   It looks like some strange polygons get added to the plot, in addition to the labels.    I have not found any explanation online for this behavior.

@khallock  The bar plot is interesting.   If you run the NCL script, the bar plot values are scaled differently from this screenshot:   https://www.ncl.ucar.edu/Applications/Images/eof_1_2_lg.png
I think the plot generated in python has the same scaling as when the NCL script is run.

@erogluorhan  The code is basically ready for review.   There is some strange plotting issue when contour labels are added to the plot.   You will find that line commented out in the code.   It also appears that the second plot is basically correct, except that the plotted values are off by a factor of two or so.
Please try running the script, or looking at the Sphinx output, to review.   Thank you!

@erogluorhan   I tried to take all your suggestions into account.   There are a few outstanding issues that I see:

If you look at the Sphinx output, you will see some warnings about constrained_layout not applied.   I have no idea what is going on; if you ever figure out how to address this, I would like to know how you did it.
The diagnostic print statements might be considered by some people to be excessive.   Personally I feel it provides some understanding about data slicing issues.
The EOF bar plot does not look like this screenshot:  https://www.ncl.ucar.edu/Applications/Images/eof_1_2_lg.png.  I believe this is because the screenshot is outdated.   If you run the NCL script as provided, it produces bar heights that are half as tall as the screenshot.

I can make another pass if you like, but I am also happy with you taking the code and making it consistent with the other examples.

Hi @khallock  and @dcherian, I have pushed a new commit Constraint_layout warnings resolved that resolves the constraint_layout warning that is generated within the notebook and attaches diagnostic print statements to a simple debug parameter (in order to avoid prints in examples website).
With this version, it should be good for you reviews.


3.0.0a3

Description

Define use_scope return type as a dict to prevent clashes between django, django-stubs, and django-idom
Bump django-idom version
Prevent db_cleanup from causing startup failure on ANY DatabaseError, rather than just OperationalError

Checklist:
Please update this checklist as you complete each item:

[X] Tests have been included for all bug fixes or added functionality.
[X] The changelog has been updated with any significant changes, if necessary.
[X] GitHub Issues which may be closed by this PR have been linked.

@rmorshea I will until idom-team/idom#911 is merged, and idom==1.0.0a4 is released before marking this as Ready for Review


Test env log adding ::f to end of test name

I think that test_env_log::test is modifying test names as reported by the runner. Here's a test annotated with #[test]:
     Running target/debug/deps/quwue-ace6fa7a6ba4cdb3

running 1 test
test run::tests::parse_message ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

[Finished running. Exit status: 0]

And here's one with test_env_log::test:
     Running target/debug/deps/quwue-ace6fa7a6ba4cdb3

running 1 test
test run::tests::parse_message::f ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

[Finished running. Exit status: 0]

Notice the extra ::f.

That is required to allow for global imports. What exactly is the problem you are having?

No particular problem, it's just unattractive and makes the test runner output harder to read.

I am not aware of another way to solve the problem, so I don't see how it can be removed. If you have a suggestion please let me know.

Ahh, okay, I looked at the code and this is definitely a harder problem than I thought. I have no clever ideas to solve it 😅

FYI, I found a way to fix that peculiarity while keeping the desired behavior. Contained in 0.2.4.

FYI, I found a way to fix that peculiarity while keeping the desired behavior. Contained in 0.2.4.

NIce!

NIce!


Fix misnamed variable in setChannelTopic

Upon further testing, this still does not appear to be working (i.e., the topic is not set), even though it resolves the crash.

Found the problem and reported it in issue #404.
This PR is otherwise good to go.


Changing API Preference results in Alert Rule names being overwritten with GUIDs

This statement is misleading (I lost data):
"
The process of moving alert rules from legacy Log Analytics Alert API does not involve changing your alert definition, query, or configuration in any way. Your alert rules and monitoring are unaffected and the alerts will not stop or be stalled, during or after the switch. The only change is a change in API preference and access to your rules via a new API.
"
It should include a strong warning that the process does destroy Alert Rule name data by replacing the names with some combination of GUIDs.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ae5768cb-367b-d03f-e62b-aac97f123e07
Version Independent ID: 201b88d2-b6a8-111d-42bb-c0ba183e6c37
Content: Switch from legacy Log Analytics alerts API into new Azure Alerts API
Content Source: articles/azure-monitor/platform/alerts-log-api-switch.md
Service: azure-monitor
Sub-service: alerts
GitHub Login: @yanivlavi
Microsoft Alias: yalavi

@craig-martin Thanks for the comment. We are actively investigating on the issue and will get back to you shortly with an update.

@yanivlavi  Can you please provide your inputs on the comment?

@craig-martin you are correct. The switch does change the alert name definition by design.
I apologize for any inconvenience this caused you. I will submit a update to the documentation to inform on this change.

A fix was merged and will be released tomorrow. Thanks for letting us know.

My feedback is that the Alert Rule name is an important piece of data because:

it is the key piece of data for viewing alerts
it is used in integrations such as IcM, so incidents also look broken
the name property is read-only, so when it gets changed by this process we cannot change it back, meaning we have to create new rules

Please see the changes I made to:
https://docs.microsoft.com/en-us/azure/azure-monitor/platform/alerts-log-api-switch#process-of-switching-from-legacy-log-alerts-api
The alert rule name is maintained in the UI and is a property in the alert definition, but the URI had to change as the rule is now an ARM tracked resource.

I think that is incorrect, because when I switched all of my rule names changed from meaningful descriptions to GUIDs.  It is especially annoying because rule names cannot be modified, so I had to create the rules all over again.  To warn future users of this switch I think the doc should read:

Rule Names will be changed by the switch to the format
Rule Names cannot be modified back to the original value because Rule Name is read-only after the Alert Rule is created
-The following script can be used to backup your rules and re-create them after the switch (I had to script that myself, but it would be handy if future users did not need to)

We appreciate your question. I think we answered your question.
Since this question was created some time ago, we don't know if it still applies. We kindly ask you to create a new github issue if it's still important. We will engage with you on the new thread. Thank you for your understanding.
#please-close

#assign:rboucher

#please-close


why you don't provide the source of Mesh::createFromBoundingBoxBuffer ?

because of that it's not possible to compile or start the DXR-RayTracingInOneWeekend and DXR-Sphereflake sample as the source had not been updated ...

Thanks, I'll try to make time soon to look at this problem and others.

Sorry, I haven't forgotten, there are just more time-critical tasks. Still on the list.


run legacy api functional tests on push to master

@AlexanderMoskovkin @AndreyBelym
Changes:

remove node --version (AppVeyor build log contains the record about node version)
display branch and executed gulp task name
change start url for Firefox from https://google.com to http://example.com/
add email notifications for build on master branch. Appveyor does not allows to send notification only for commit author. The notification about failed build will be sent for predefined recipient list.

@testcafe-build-bot \retest

@testcafe-build-bot \retest

@testcafe-build-bot \retest

@testcafe-build-bot \retest

@testcafe-build-bot \retest

@testcafe-build-bot \retest

@testcafe-build-bot \retest

@testcafe-build-bot \retest

FPR

I suspend this task until we found a way to stabilize the takeElementScreenshot tests.
@AndreyBelym

@testcafe-build-bot \retest

@testcafe-build-bot \retest

There is a problem with legacy quarantine tests. Trying to figure out what's going wrong.

Rebase is needed to incorporate changes from https://github.com/DevExpress/testcafe/pull/2295. It must fix the tests.

@testcafe-build-bot \retest

@testcafe-build-bot \retest

@testcafe-build-bot \retest

FPR @AlexanderMoskovkin


Cleaner Concierge Templates

Add a newline to the signature so it doesn't accidentally make heading text.
Added a CONTRIBUTORS.md config to trigger checking if the PR author has added themselves.
Deleted the pullRequestOpened.hbs to use the new default template.

The biggest change here is the last point. You can see the new template here. When posted, it'll look something like this (if it's not your first PR):

Thanks for the pull request @OmarShehata!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

:grey_question: Changes to third party files were made.

Looks like a file in one of our ThirdParty folders (thirdParty/) has been added or modified. Please verify that it has a section in LICENSE.md and that its license information is up to date with this new version.

Some notes:

I reserve :x: for missing things that require the PR author's action, like missing CLA and adding their name to contributors.
I use ❔ for everything that concierge will likely comment on frequently but usually are false positives (like updated changes.md. So it's a reminder, but not a blocking action).

I think this new template is much more readable and much more useful. I'm open to hearing feedback! The new structure makes it very easy to add new items to this bullet point list (they're independent and the language still makes sense if they're placed in any order). I think we want to keep in mind that too many items will make it users skim/not pay attention any more, especially if they aren't usually relevant.
We can also easily add conditional things (ex: if anything in folder X is changed, insert this reminder/bullet point), and I think those would be best. I think we should minimize reminders that more often than not false positives.
Anything else you would add/remove here?

@OmarShehata, thanks for the pull request! Maintainers, we have a signed CLA from @OmarShehata, so you can review this at any time.
:warning: I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.
:earth_africa: :earth_americas: :earth_asia:

Also, I opted for using check marks, cross marks and question marks as opposed to badges like the CLA one we have now. I think that makes it more consistent, since if everything is good, it will be a list of check marks, as opposed to different colored badges for different things.
And if something is not good, each bullet point will have a sub bullet for an action to take.

Thanks @OmarShehata ! Is there anything from https://github.com/AnalyticalGraphicsInc/cesium/pull/6684 that we want to carry over here?

Any feedback? @pjcozzi @hpinkos @mramato @lilleyse

It doesn't look like the checkboxes from the pull request template have been moved over here yet.  Is the plan to add them to concierge and close the PR template pull request?

I'm fine with whatever you decide.

@hpinkos I wasn't planning on adding the checkboxes in the form they appear in the PR template. I think the bullet points concierge posts perform the same function (they will remind you if you haven't updated CHANGES.md, and about updating unit tests if you haven't already when this is merged.
Actual tests will be checked by Travis, and down the road it would be nice to add automatically coverage checks too. If you think there's missing items here, we could add them as a ❔ bullet if it's just a reminder.

I'm with @hpinkos in that I think we need a few more items aimed squarely at the reviewer (checkboxes would work in my opinion) .  The list does not need to be exhaustive but needs to cover the critical mistakes that we as a team seem to make over and over again.  My list would simply be:

[ ] Cesium Viewer works
[ ] Works in 2D/CV
[ ] Works (or fails gracefully) in IE11

All three of these bite us all the time.
Since these are Cesium specific, we would either not use the default template or could separate it out into a separate message.  Think of it as the first message being aimed at the PR opener and the second message being aimed at the reviewer.

As long as they are added somewhere.  I thought the idea is we wanted to add them to the concierge post so people couldn't delete them from the PR template as they open the PR.
Also, I like checkboxes because they are actionable.  People don't actually read things.  It's way easier to ignore a bullet point than a checkbox.
Side note, we always need to run the tests locally in addition to running them on travis because travis doesn't support WebGL yet and we have a bunch of render tests that are skipped or mocked when they're run on travis.

Oh, I didn't realize we were talking about the checklist for the reviewer. I was worrying about it feeling like a burden to the PR author/them ignoring it.
I added a bottom section aimed at reviewers. The checkboxes here now are:
[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.
[ ] Works in Chrome & Firefox.
[ ] Works in Safari.
[ ] Works in Edge.
[ ] Passes all tests.
Is this too much? Too little? Should all browsers be combined into one "works in Chrome, Firefox, Safari & Edge" box?

Yeah, I think you can combine all the browsers into one checkbox.  And I would say Passes all tests locally in Chrome for the last checkbox.  And maybe add a checkbox for CHANGES.md is updated (or is not necessary)

Is this too much? Too little? Should all browsers be combined into one "works in Chrome, Firefox, Safari & Edge" box?

Yes, this is too much, I feel this list should concentrate on things that have bitten us in the past, not an exhaustive checklist of nice to haves.

@mramato I don't think that's too much, those are all things that have been problems in the past

Yeah, I think you can combine all the browsers into one checkbox.

No one runs all unit tests on all browsers, it's a ridiculous burden to put on reviewers.  IE 11 is the one that brakes all of the time.  travis covers Chrome already (and will cover Firefox in the near future).

No one runs all unit tests on all browsers

This isn't saying to run tests in all browsers, just to make sure that you can open the feature in Sandcastle

This isn't saying to run tests in all browsers, just to make sure that you can open the feature in Sandcastle

I still don't think that's necessary.  We need a very small checklist that people will actually follow without wasting a ton of time.  The majority of PRs are simply changes that don't need such exhaustive testing, we just need to handle the gotchas.

The majority of PRs are simply changes that don't need such exhaustive testing, we just need to handle the gotchas

Alright, fair enough

So more like this? @mramato
[ ] CHANGES.md is updated (or is not necessary).
[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.
[ ] Passes all tests locally in Chrome.

I would remove the first and last item.  CHANGES is already covered and the last one is unlikely to add any value outside of what we already do unprompted.  Again, the goal here is to remind reviewers of things that have constantly bitten us in the past.

Okay, I think this is ready for a test run!

I'm happy with these changes for now. If anymore suggestions come up, it should be trivial to update the template.


Improve the text at the top of the home page

Received the latest home page text from the product team.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: binofc sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Remove flow typing for DraftEntity mock

Summary
Flow typing this file breaks Travis CI. See also discussion in #1890
Test Plan
yarn run flow

LGTM


Set isSelected property of choice input in html renderer

https://github.com/Microsoft/AdaptiveCards/issues/346

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

This is by design. To pre-select a choice, you need to set the value of the input in the JSON payload to one of the Choice input's values. There is no isSelected property on choice.


fix(conf-loader) add format check for admin_listen_ssl string

Summary
Adds a listen address check in conf_loader.lua for the admin_listen_ssl configuration string to enhance error reporting when a Kong node is misconfigured.

LGTM!


new(rules): Change namespace privileges via unshare

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area rules

/area registry

/area build

/area documentation

Proposed rule maturity level

Uncomment one (or more) /area <> lines (only for PRs that add or modify rules):

/area maturity-stable

/area maturity-incubating

/area maturity-sandbox

/area maturity-deprecated

What this PR does / why we need it:
See desc and also part of modernizing Falco rules https://github.com/falcosecurity/rules/issues/138.
CC @darryk10 @Andreagit97
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: incertum
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: darryk10, incertum
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: ef0995f4d1b4bd7b063eb004cf93dc9db15d8e95

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: darryk10, incertum, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [LucaGuerra,incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: darryk10, incertum
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: darryk10, incertum
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: c0668328313504ba333a829e9f32d51aa22679d5

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, darryk10, incertum
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/hold
Why the CI is failing?

Because the memfd + exec rule made it already incompatible with 0.35.


Bump framework and osbuilder

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

check is not working, @mauromorales was right :sob:

issues seems to be a different thing, kairos-agent state get kairos.init is not working as expected and that was introduced a few days ago and got lumped with this change. It should as soon as framework is rebuilt with the updated package

Most of the stuff seems to work now. Manual tested uki and also installs and triggers correctly. Will need to check the test.
upgrade job, no idea, need to manually test to see if there is any incompatibility between 2.5 and 3, but alpine one passes...

so the actual error for the upgrade is:
      +run-qemu-test |   [FAILED] sudo: you do not exist in the passwd database

which is baffling...
This is installing a v2.5.0 image, and it fails during that install...so I have no idea why that would fail somehow????

current framework is main but I just cut 2.7.1, so if this pass with the current framework it will be ok to set the proper version and merge


Why does the webpack-es2016 (now webpack-skeleton) contain typescript?

This was a pure es2016-webpack implementation and now there seems to be no skeleton support for it. There is now typescript in it and it is hard to tell how to use it with the multiple src directories.
I see now that the webpack-skeleton supports JS. TS and Electron approaches. This feels very messy for something being used to understand a specific approach to Aurelia. It may feel slick to the writer, but to the adopter is feels burdensome and overly complex.
I was relying very heavily on the es2016-webpack skeleton to test library changes and maintain stability with my project.
A skeleton should be something you use to start a project. Nobody(IMHO) should start a project with multiple approaches inside the implementation source.
Why not a separate webpack-typescript and a webpack-es2016(esnext)?

This now just seems bloating and over complicated. IMHO each skeleton should focus on a single approach and not mix stacks. Even the electron approach should be in its own skeleton project.

To answer your question: Why not a separate webpack-typescript and a webpack-es2016(esnext)?
Simplicity and consolidation. 95% of the code between both skeletons is the same. Merging them means faster development and quicker bug-fixes for both skeletons. In the future we might only have a single skeleton for all implementations, with a configurator tool that will be run before installing any dependencies.
Not sure what you mean by:

it is hard to tell how to use it with the multiple src directories

Nothing has changed in that respect.
Once you've selected JavaScript as your language, you can freely delete the packages such as: tslint, typescript and awesome-typescript-loader. TypeScript-specific src files are deleted automatically.
Electron support is separated into its own configuration files and its dependencies are not installed by default.
More documentation on how to use the new Webpack skeleton will come in the future. Please note that it has not yet been officially released.

Simplicity and consolidation. 95% of the code between both skeletons is the same. Merging them means faster development and quicker bug-fixes for both skeletons. In the future we might only have a single skeleton for all implementations, with a configurator tool that will be run before installing any dependencies.

I completely disagree. More files does not equal "simplicity".

Once you've selected JavaScript as your language, you can freely delete the packages such as: tslint, typescript and awesome-typescript-loader. TypeScript-specific src files are deleted automatically.

There is nothing stating what I have to delete that will not break whichever implementation I choose. This is bad. I have no idea what to remove and do not wish to learn anymore TS right now.

More documentation on how to use the new Webpack skeleton will come in the future. Please note that it has not yet been officially released.

I understand it has not been released yet. I am an early adopter and trying hard to help support the es6/webpack approach. But this is really pulling the rug out from under folks who are relying on updating the project continually, as I just tried to do but was met with errors when after fetching updates.

There is nothing stating what I have to delete

Please be patent. Writing docs for something that's still not fully designed would be a waste of time.

More files does not equal "simplicity".

One messy large file also doesn't equal simplicity :) I take your point — we already have plans to simplify the skeleton.

Let me say thank you for your hard work. I can't tell you how much I talk up Aurelia in my circles. And the rxjs bindings are awesome! Thanks for that.
  I will work to keep it updated and happy for others who are interested. Maybe later down the road towards release it will become worthwhile in the configurator tasks you are talking about.
Sorry if the original question I posted sounded ranty. I am VERY pleased with how smooth the changes have been compared to other frameworks.
Kudos.

Please be patent. Writing docs for something that's still not fully designed would be a waste of time.

I usually am extremely patient. Sorry this came off as negative. I think I was feeling the setback of no longer having a weathervane for my current project. I use the skeleton as a canary in the mineshaft when my project suffers from something bad.
Updating my skeleton and committing it will also allow me to surface issues to the Aurelia team with more context.


Owners parameter syntax is wrong

The syntax for the Owners parameter is given as "user<EMAIL_ADDRESS>but this does not work. It triggers the error: New-PnPSite : {"error":{"code":"-1,
System.Data.Services.Client.DataServiceClientException","message":"{"odata.error":{"code":"Request_BadRequest","message":{"lang":"en","value":"One or more added object
references already exist for the following modified properties: 'owners'."}}}"}}
The correct usage is "user<EMAIL_ADDRESS>
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fa5e3530-a63e-71ce-97c8-c904619aafa8
Version Independent ID: 2c961b64-5c27-6331-b704-716ccfb8c5a7
Content: New-PnPSite (sharepoint-pnp)
Content Source: sharepoint/sharepoint-ps/sharepoint-pnp/New-PnPSite.md
GitHub Login: @techwriter40
Microsoft Alias: kirks

@officedocsbot assign @yogkumgit

Hello @teylyn  👍 how are you?
Documentation for PnP cmdlets is directly reflected from the cmdlet's source code.
So, I will need to kindly ask you to visit this other repo to open PnP issues. PnP cmdlets are maintained by the community, a member of it will pick it up there.
Thanks

@get-itips  Thank you very much for the contribution and sharing this explanation. @teylyn
Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


test_utils::TestError: rely on error type equality instead of string matching

TestError currently relies on strings and substring matching to confirm that an expected error occurred.
A better way is to use type equality on errors, which was added in https://github.com/0xPolygonMiden/miden-vm/pull/1145.
An apparent downside of the current approach is that when the Debug implementation of a type used in errors changes, tests break. This occurred recently with the Debug implementation of fields changing, and the operations::sys_ops::assert_with_code test breaking.

I no one else is working on this I would like to tackle it.

Go for it 🙂 Let us know if you have any questions

Here's a PR for this issue: PR-1194

Closed by #1194.


add required python version in various setup.py

Currently, pip assumes 2.14.0 is the latest version for all python interpreters and installs that version. This causes errors like this on older python versions:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/confus/.local/share/virtualenvs/specter-yzp-I12c/lib/python3.2/site-packages/azure/cli/core/commands/__init__.py", line 425
    def cached_put(cmd_obj, operation, parameters, *args, setter_arg_name='parameters', **kwargs):
                                                                        ^
SyntaxError: invalid syntax

This probably a systemic problem in more than one of the azure libraries and because older packages with this error are already on pypi.org, it is hard to solve in retrospect. This PR is just to raise awareness for the issue.

required python version

hi @fengzhou-msft could you pls help to review?

Please be advised, that similar changes are likely due in other azure packages, too.


Add interaction counts to statuses

It would be extremely useful to have the reblog, favorite, and reply counts included in the status rows. This PR adds this, and updates the tests accordingly.

Thanks @phildini for your contribution!


[WIP] engine: add support for VMware 7.0 dependency and hypervisor capability

This adds support for VMware 7.0 with a jar dependency and sql upgrade path. The jar dependency has been added to support noredist pkging here:
https://github.com/rhtyd/cloudstack-nonoss/blob/master/install-non-oss.sh#L37
Fixes #4441
Fixes #4423
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔centos8 ✔debian.

Marvin tests with this PR and vCenter 7.0 with CentOS7 mgmt server but two 6.7u3 ESXi hosts:

Test
Result
Time (s)
Test File

test_01_deploy_kubernetes_cluster
Error
0.15
test_kubernetes_clusters.py

test_02_deploy_kubernetes_ha_cluster
Error
0.07
test_kubernetes_clusters.py

test_04_deploy_and_upgrade_kubernetes_cluster
Error
0.06
test_kubernetes_clusters.py

test_05_deploy_and_upgrade_kubernetes_ha_cluster
Error
0.07
test_kubernetes_clusters.py

test_06_deploy_and_invalid_upgrade_kubernetes_cluster
Error
0.06
test_kubernetes_clusters.py

test_07_deploy_and_scale_kubernetes_cluster
Error
0.06
test_kubernetes_clusters.py

test_01_add_primary_storage_disabled_host
Error
0.51
test_primary_storage.py

test_01_primary_storage_nfs
Error
0.18
test_primary_storage.py

ContextSuite context=TestStorageTags>:setup
Error
0.31
test_primary_storage.py

test_02_list_snapshots_with_removed_data_store
Error
1.21
test_snapshots.py

test_02_create_template_with_checksum_sha1
Error
5.28
test_templates.py

test_03_create_template_with_checksum_sha256
Error
5.20
test_templates.py

test_04_create_template_with_checksum_md5
Error
5.20
test_templates.py

test_01_volume_usage
Error
11.57
test_usage.py

test_11_migrate_vm
Error
50.32
test_vm_life_cycle.py

test_01_create_volume
Error
134.77
test_volumes.py

test_02_attach_volume
Error
44.96
test_volumes.py

test_03_download_attached_volume
Error
1.10
test_volumes.py

test_04_delete_attached_volume
Error
1.11
test_volumes.py

test_05_detach_volume
Error
1.10
test_volumes.py

test_06_download_detached_volume
Error
1.11
test_volumes.py

test_07_resize_fail
Error
2.28
test_volumes.py

test_08_resize_volume
Error
1.11
test_volumes.py

test_09_delete_detached_volume
Error
12.63
test_volumes.py

test_11_attach_volume_with_unstarted_vm
Error
2.39
test_volumes.py

ContextSuite context=TestVolumes>:teardown
Error
19.09
test_volumes.py

test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL
Failure
443.14
test_vpc_redundant.py

test_04_rvpc_network_garbage_collector_nics
Error
3790.27
test_vpc_redundant.py

test_04_rvpc_network_garbage_collector_nics
Error
3790.31
test_vpc_redundant.py

test_05_rvpc_multi_tiers
Error
0.01
test_vpc_redundant.py

ContextSuite context=TestVPCRedundancy>:teardown
Error
0.02
test_vpc_redundant.py

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2250

@blueorangutan test centos7 vmware-67u3

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

Trillian test result (tid-3035)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46517 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4300-t3035-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 83 look OK, 2 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_03_deploy_and_upgrade_kubernetes_cluster
Failure
249.79
test_kubernetes_clusters.py

test_02_create_template_with_checksum_sha1
Error
5.15
test_templates.py

test_03_create_template_with_checksum_sha256
Error
5.14
test_templates.py

test_04_create_template_with_checksum_md5
Error
5.14
test_templates.py

Trillian test result (tid-3178)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36966 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4300-t3178-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Smoke tests completed. 84 look OK, 1 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_02_create_template_with_checksum_sha1
Error
5.19
test_templates.py

test_03_create_template_with_checksum_sha256
Error
5.23
test_templates.py

test_04_create_template_with_checksum_md5
Error
5.19
test_templates.py

Rebased master - @blueorangutan package

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2411

Run tests against vCenter 7.0 with 2 ESXi hosts on version 7.0.1:
[root@ref-trl-1958-v-M7-nicolas-vazquez-marvin marvin]# cat test-summary.txt
82 look ok, 4 have errors
[root@ref-trl-1958-v-M7-nicolas-vazquez-marvin marvin]# cat smoketests-summary.txt
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 82 look OK, 4 have error(s)
Only failed tests results shown below:

Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_DeployVmAffinityGroup | `Failure` | 168.65 | test_affinity_groups.py
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 786.00 | test_kubernetes_clusters.py
test_04_deploy_and_scale_kubernetes_cluster | `Failure` | 85.78 | test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster | `Failure` | 96.18 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.11 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.09 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.10 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 85.21 | test_kubernetes_clusters.py
test_03_migration_options_storage_tags | `Error` | 0.44 | test_primary_storage.py
test_01_migrate_VM_and_root_volume | `Error` | 112.09 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 60.85 | test_vm_life_cycle.py
test_03_migrate_detached_volume | `Error` | 73.09 | test_vm_life_cycle.py
ContextSuite context=TestVAppsVM>:setup | `Error` | 62.04 | test_vm_life_cycle.py

@blueorangutan package

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2520

@blueorangutan package

@blueorangutan package

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2561

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2561

@blueorangutan package

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2674

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2680

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2691

@blueorangutan package

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2698

@blueorangutan help

@DaanHoogland I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [keepEnv]
Mgmt OS options: ['centos6', 'centos7', 'centos8', 'ubuntu']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-centos8', 'kvm-ubuntu', 'xenserver-71', 'xenserver-65sp1', 'vmware-67u3', 'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'xcpng76', 'xcpng80', 'xcpng81', 'xenserver-74', 'xcpng74']
Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the matrix command.
Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'sureshanaparti']

@blueorangutan package

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@davidjumani can you please review the CPVM/noVNC related commits?

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2705

@blueorangutan test matrix

@rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

Trillian test result (tid-3542)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32380 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4300-t3542-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_01_scale_vm
Failure
10.41
test_scale_vm.py

Trillian test result (tid-3543)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38140 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4300-t3543-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

ContextSuite context=TestISOUsage>:setup
Error
0.00
test_usage.py

Trillian test result (tid-3544)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 50317 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4300-t3544-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_03_deploy_and_upgrade_kubernetes_cluster
Failure
1451.71
test_kubernetes_clusters.py

Thanks @sureshanaparti @rhtyd - comments addressed
@blueorangutan package

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]

@blueorangutan package

Packaging result: :heavy_multiplication_x: centos7 :heavy_multiplication_x: centos8 :heavy_multiplication_x: debian. SL-JID 41

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2825

@blueorangutan package

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2826

Let me regression testing
@blueorangutan test centos7 vmware-67u3

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

Trillian test result (tid-3622)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39141 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4300-t3622-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 84 look OK, 2 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_03_deploy_and_upgrade_kubernetes_cluster
Failure
775.66
test_kubernetes_clusters.py

test_03_migrate_detached_volume
Error
72.70
test_vm_life_cycle.py

ContextSuite context=TestVAppsVM>:setup
Error
43.50
test_vm_life_cycle.py

@rhtyd @nvazquez this has [WIP] in the name. is it still a draft?

@DaanHoogland it is ready for review, I have now removed the WIP tag on the name

@blueorangutan package

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]

Packaging result: :heavy_multiplication_x: centos7 :heavy_multiplication_x: centos8 :heavy_check_mark: debian. SL-JID 130

@blueorangutan package

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]

Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 136

@nvazquez can you fix the merge conflict?

@blueorangutan package

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 351

@nvazquez please fix conflicts and re-run a round of smoketests against vmware7 and vmware 6.7

@blueorangutan package

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 377

@blueorangutan test centos7 vmware-67u3

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

Trillian test result (tid-399)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37625 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4300-t399-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 86 look OK, 1 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

ContextSuite context=TestVAppsVM>:setup
Error
82.81
test_vm_life_cycle.py

@nvazquez can you kick smoketests against vmware 7.0 as well? And if we can get support for vsphere7 in Trillian?

@blueorangutan help

@nvazquez I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [keepEnv]
Mgmt OS options: ['centos6', 'centos7', 'centos8', 'ubuntu18', 'ubuntu20']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-centos8', 'kvm-ubuntu18', 'kvm-ubuntu20', 'xenserver-71', 'xenserver-65sp1', 'vmware-67u3', 'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'xcpng76', 'xcpng80', 'xcpng81', 'xenserver-74', 'xcpng74']
Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the matrix command.
Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'sureshanaparti']

@blueorangutan help

@nvazquez I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [keepEnv]
Mgmt OS options: ['centos6', 'centos7', 'centos8', 'ubuntu18', 'ubuntu20']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-centos8', 'kvm-ubuntu18', 'kvm-ubuntu20', 'xenserver-71', 'xenserver-65sp1', 'vmware-67u3', 'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'xcpng76', 'xcpng80', 'xcpng81', 'xenserver-74', 'xcpng74']
Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the matrix command.
Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'sureshanaparti']

@blueorangutan help

@nvazquez I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [keepEnv]
Mgmt OS options: ['centos6', 'centos7', 'centos8', 'ubuntu18', 'ubuntu20']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-centos8', 'kvm-ubuntu18', 'kvm-ubuntu20', 'xenserver-71', 'xenserver-65sp1', 'vmware-70u1', 'vmware-67u3', 'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'xcpng76', 'xcpng80', 'xcpng81', 'xenserver-74', 'xcpng74']
Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the matrix command.
Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'sureshanaparti']

@blueorangutan package

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 411

@blueorangutan test centos7 vmware-70u1

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-70u1) has been kicked to run smoke tests

@blueorangutan test centos7 vmware-70u1

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-70u1) has been kicked to run smoke tests

@blueorangutan test centos7 vmware-70u1

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-70u1) has been kicked to run smoke tests

Trillian test result (tid-441)
Environment: vmware-70u1 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36325 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4300-t441-vmware-70u1.zip
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 85 look OK, 2 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_10_traceroute_in_vr
Failure
61.16
test_diagnostics.py

test_01_redundant_vpc_site2site_vpn
Failure
347.83
test_vpc_vpn.py

test_01_vpc_site2site_vpn
Failure
243.03
test_vpc_vpn.py

@rhtyd @vladimirpetrov Vmware 7.0 support was introduced into Trillian and the last tests were executed on it, few errors which seem unrelated to this PR. Please advise if we are ready to merge it

LGTM, @vladimirpetrov are you lgtm on this?

Merging based on tests and code reviews.


Multiple changes/adds

I'm planning on using your module but to do that I need to add the following features:

additional annotations;
Affinity and anti-affinity;
strategy;
init container;
hosts;
replicas;
Also I need to make linkerd annotations optional.
Does this make sense to you for the future development of this module?

(I'm  available to do this changes, are you interested on the PR?)

Hi Tiago,
I'm glad to see that our module can be useful to you! I'm currently on holidays and will be back in 10 days, so if you want to propose a PR, go for it! My colleague @Gfeuillen can look into that. The most important is to be able to support the variety of configurations that will make this module useful, you can look at how we use the lookup feature to give freedom to the user. Thanks for the interest! 😁

Perfect! I will do that.

I have created separate issue for easy tracking each task.
Closing this issue.


`connect_nonblock': SSL_connect returned=1 errno=0

Expected Behavior
After copying the code into the console app it should authenticate with google service
Actual Behavior
I do not know if it is a problem with google gem or may be something else
C:/Ruby/lib/ruby/2.3.0/net/http.rb:933:in `connect_nonblock': SSL_connect returned=1 errno=0 state=error: certificate verify failed (Faraday::SSLError)
        from C:/Ruby/lib/ruby/2.3.0/net/http.rb:933:in `connect'
        from C:/Ruby/lib/ruby/2.3.0/net/http.rb:863:in `do_start'
        from C:/Ruby/lib/ruby/2.3.0/net/http.rb:852:in `start'
        from C:/Ruby/lib/ruby/2.3.0/net/http.rb:1398:in `request'
        from C:/Ruby/lib/ruby/gems/2.3.0/gems/faraday-0.12.2/lib/faraday/adapter/net_http.rb:80:in `perform_request'
        from C:/Ruby/lib/ruby/gems/2.3.0/gems/faraday-0.12.2/lib/faraday/adapter/net_http.rb:38:in `block in call'
        from C:/Ruby/lib/ruby/gems/2.3.0/gems/faraday-0.12.2/lib/faraday/adapter/net_http.rb:85:in `with_net_http_connection'
        from C:/Ruby/lib/ruby/gems/2.3.0/gems/faraday-0.12.2/lib/faraday/adapter/net_http.rb:33:in `call'
        from C:/Ruby/lib/ruby/gems/2.3.0/gems/faraday-0.12.2/lib/faraday/request/url_encoded.rb:15:in `call'
        from C:/Ruby/lib/ruby/gems/2.3.0/gems/faraday-0.12.2/lib/faraday/rack_builder.rb:141:in `build_response'
        from C:/Ruby/lib/ruby/gems/2.3.0/gems/faraday-0.12.2/lib/faraday/connection.rb:386:in `run_request'
        from C:/Ruby/lib/ruby/gems/2.3.0/gems/faraday-0.12.2/lib/faraday/connection.rb:186:in `post'
        from C:/Ruby/lib/ruby/gems/2.3.0/gems/signet-0.7.3/lib/signet/oauth_2/client.rb:960:in `fetch_access_token'
        from C:/Ruby/lib/ruby/gems/2.3.0/gems/signet-0.7.3/lib/signet/oauth_2/client.rb:998:in `fetch_access_token!'
        from C:/Ruby/lib/ruby/gems/2.3.0/gems/googleauth-0.5.1/lib/googleauth/signet.rb:69:in `fetch_access_token!'
        from C:/Ruby/lib/ruby/gems/2.3.0/gems/googleauth-0.5.1/lib/googleauth/user_authorizer.rb:179:in `get_credentials_from_code'
        from C:/Ruby/lib/ruby/gems/2.3.0/gems/googleauth-0.5.1/lib/googleauth/user_authorizer.rb:201:in `get_and_store_credentials_from_code'
        from quickstart.rb:29:in `authorize'
        from quickstart.rb:39:in `<main>'

Steps to Reproduce the Problem

ruby quickstart.rb
Open the following URL in the browser and enter the resulting code after authorization
Paste code form website into console

Specifications

Ruby version: ruby 2.3.3p222 (2016-11-21 revision 56859) [x64-mingw32]
Windows

Which quickstart is this for?

Here is the URL for the quickstart I was following when I ran into this
issue.
https://developers.google.com/calendar/quickstart/ruby?authuser=1
On Sun, Sep 9, 2018 at 12:36 PM, Anu<EMAIL_ADDRESS>wrote:

Which quickstart is this for?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/gsuitedevs/ruby-samples/issues/12#issuecomment-419735592,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABruk8XWlgm1Wbtyguq_WDeawwULIYZks5uZV-wgaJpZM4V_jL6
.

Here you go
https://developers.google.com/drive/api/v3/quickstart/ruby

I am also having the same problems when trying to use the quickstart file for google sheets API.
https://developers.google.com/sheets/api/quickstart/ruby
I'm a complete newbie. So any pointers are appreciated.


Crashes after update from 3.1.4 to 4.1.3

import 'dart:ffi';
import 'dart:io';

import 'package:ffi/ffi.dart';
import 'package:win32/win32.dart';

main() async {
  await getDesktopFolders();
  print('213');

  await Future.delayed(const Duration(seconds: 10));
  print('21');
}

/// Retrieves all user's desktop paths.
/// Example: {C:\Users\Test\Desktop, C:\Users\Test\OneDriveDesktop}
Future<Set<String>> getDesktopFolders() async {
  // Final value to be filled and returned
  final Set<String> directories = {};

  // Create pointers for 3 different WinAPI methods of retrieving known folders
  final Pointer<GUID> appsFolder = GUIDFromString(FOLDERID_Desktop);
  final Pointer<PWSTR> ppszPath = calloc<PWSTR>();
  final Pointer<COMObject> ppkf = calloc<COMObject>();
  final Pointer<Utf16> path = calloc<WCHAR>(MAX_PATH).cast();

  // Try modern WinAPI way of retrieving the desktop folder
  try {
    // Fill ppszPath pointer with possible desktop path
    final int _result = SHGetKnownFolderPath(
      appsFolder,
      KF_FLAG_DEFAULT,
      NULL,
      ppszPath,
    );

    // Stop function if SHGetKnownFolderPath was not completed with
    // successful result
    if (FAILED(_result)) throw 'SHGetKnownFolderPath method has failed';

    // Check if retrieved WinAPI directory exists
    final String _winAPIPath = ppszPath.value.toDartString();
    if (await Directory(_winAPIPath).exists()) {
      directories.add(_winAPIPath.toLowerCase());
    }
  } catch (_) {
    /* Do nothing */
  }

  // Get the path for a known Winodws folder, using the COM API
  try {
    CoInitializeEx(nullptr, COINIT_APARTMENTTHREADED);

    // Get instance of KnownFolderManager
    final KnownFolderManager knownManager = KnownFolderManager.createInstance();
    int hr = knownManager.getFolder(appsFolder, ppkf.cast());
    if (FAILED(hr)) throw 'KnownFolderManager method has failed';

    final knownFolder = IKnownFolder(ppkf);
    hr = knownFolder.getPath(0, ppszPath);
    if (FAILED(hr)) throw 'IKnownFolder method has failed';

    // Convert retrieved path to dart string, uninitialize no longer needed
    // KnownFolderManager instance.
    final path = ppszPath.value.toDartString();
    CoUninitialize();
    if (await Directory(path).exists()) directories.add(path.toLowerCase());
  } catch (_) {
    /* Do nothing */
  }

  // Try deprecated windows api (still works better than new APIs on old
  // windows version)
  try {
    final result = SHGetFolderPath(
      NULL,
      CSIDL_DESKTOP,
      NULL,
      0,
      path,
    );

    if (SUCCEEDED(result)) {
      final String dartPath = path.toDartString();
      if (await Directory(dartPath).exists()) {
        directories.add(dartPath.toLowerCase());
      }
    }
  } catch (_) {
    /* Do nothing */
  }

  calloc.free(appsFolder);
  calloc.free(ppkf);
  calloc.free(ppszPath);
  calloc.free(path);

  // Return default path if none of above exist
  return directories;
}

Launch the app and restart it, it will crash. In my case when code is used in the huge app with other calculations it crashes instantly. In test app i have to run the code twice. With win32 3.1.4 there are no crashes

Since v4.0.0 COM objects' pointers are automatically freed by NativeFinalizer as mentioned in the CHANGELOG.
So you need to remove this calloc.free(ppkf);

Since v4.0.0, COM objects' pointers are automatically freed by NativeFinalizer as mentioned in the CHANGELOG. So you need to remove this calloc.free(ppkf);
Perhaps we should update the CHANGELOG to better explain this with examples.

But there is no .release method for them

Since v4.0.0, COM objects' pointers are automatically freed by NativeFinalizer as mentioned in the CHANGELOG. So you need to remove this calloc.free(ppkf);
Perhaps we should update the CHANGELOG to better explain this with examples.

But there is no .release method for them

By COM objects, I mean the classes that extend the IUnknown class. In your example, the variable knownManager is a COM object and has a .release() method.
Note that, with v5.0.0, .release() is also called automatically if you wish to upgrade it.

Since v4.0.0, COM objects' pointers are automatically freed by NativeFinalizer as mentioned in the CHANGELOG. So you need to remove this calloc.free(ppkf);
Perhaps we should update the CHANGELOG to better explain this with examples.

But there is no .release method for them

By COM objects, I mean the classes that extend the IUnknown class. In your example, the variable knownManager is a COM object and has a .release() method. So you can just call knownManager.release();.
Note that, with v5.0.0, .release() is also called automatically if you wish to upgrade it.

What is the purpose of this update? Seems strange to make it this way

This is a simple pointer, why making different releasing behavior for same pointer objects? This will create a lot of confuses and misunderstandings

It's definitely not a simple pointer. Pointer<COMObject> is only used by COM objects and we wanted to simplify using COM objects by relieving the burden of manual memory management from developers.
This helps reduce the chances of accidental resource leaks and makes the code more robust by ensuring that resources are properly released even if developers forget to explicitly call .release() and free its pointer.

It's definitely not a simple pointer. Pointer<COMObject> is only used by COM objects and we wanted to simplify using COM objects by relieving the burden of manual memory management from developers.
This helps reduce the chances of accidental resource leaks and makes the code more robust by ensuring that resources are properly released even if developers forget to explicitly call .release() and free its pointer.
EDIT: With v5.0.0, COM objects now have .detach() method that you can call to opt out of this behavior.

This is bad when behavior for same allocation is different, you never know what you should calloc.free by your own and what you must never touch

It's definitely not a simple pointer. Pointer<COMObject> is only used by COM objects and we wanted to simplify using COM objects by relieving the burden of manual memory management from developers.
This helps reduce the chances of accidental resource leaks and makes the code more robust by ensuring that resources are properly released even if developers forget to explicitly call .release() and free its pointer.
EDIT: With v5.0.0, COM objects now have .detach() method that you can call to opt out of this behavior.

This is bad when behavior for same allocation is different, you never know what you should calloc.free by your own and what you must never touch

This is mentioned in CHANGELOG and also in the COM documentation.


Can I convert some input into an array?

<input type="hidden" name="a[arr][0]" value="12" />
<input type="hidden" name="a[arr][1]" value="34" />

will be convert to this
{
    "a": {
        "arr": {
            "0": "12",
            "1": "34"
        }
    }
}

how to make it like this?
{
    "a": {
        "arr": ["12", "34"]
    }
}

I'm looking into this. This is tricky because it has to be an Array and both an Object in the same time. Some have stuff like a[arr][0], a[arr][1], a[arr]['stuff']. Thanks for noticing this

I have two distinct situations:
<input type="hidden" name="a[arr][0]" value="12" />
<input type="hidden" name="a[arr][1]" value="34" />

which should result in
{
    "a": {
        "arr": ["12", "34"]
    }
}

and
<input type="hidden" name="a[arr][name]" value="Serban" />
<input type="hidden" name="a[arr][age]" value="99" />

which should result in
{
    "a": {
        "arr": {
          "name": "Serban",
          "age": "99"
        }
    }
}

If you have any suggestions how to do this, please reply. I'm thinking of subclassing the Array prototype.

Also there is the situation when the key doesn't start from 0
<input type="hidden" name="a[arr][55]" value="12" />
<input type="hidden" name="a[arr][88]" value="34" />

I think you can follow the body-parser way:
<input type="text" name="caruosel[0][link]" value="c link 0">
<input type="text" name="caruosel[0][src]" value="c src 0">
<input type="text" name="caruosel[11][link]" value="c link 1">
<input type="text" name="caruosel[11][src]" value="c src 1">

wiil be
{
    "caruosel": [
        {
            "link": "c link 0",
            "src": "c src 0"
        },
        {
            "link": "c link 1",
            "src": "c src 1"
        }
    ]
}

and
<input type="text" name="caruosel[0][link]" value="c link 0">
<input type="text" name="caruosel[0][src]" value="c src 0">
<input type="text" name="caruosel[a11][link]" value="c link 1">
<input type="text" name="caruosel[a11][src]" value="c src 1">

will be:
{
    "caruosel": {
        "10": {
            "link": "c link 0",
            "src": "c src 0"
        },
        "a11": {
            "link": "c link 1",
            "src": "c src 1"
        }
    }
}

@littlee Interesting, not sure about the numeric key example, it resets your key value when you get back the object to a server request. Maybe this should be a limitation ...
I'm looking at https://github.com/expressjs/body-parser right now.
In the meanwhile I decided to start writing unit tests for formToObject so I can make these kind of refactoring decisions much easier for the future.

I might find a good way for this issue
check this out
https://lodash.com/docs#values
it can convert object to array

I might've recommended a different approach.
Instead of using <input name="obj[foo]"> as the syntax, using <input name="obj.foo"> allows for a distinction between arrays and object properties.

@Merwer parsing and interpreting field names like obj.foo.bar is a good idea, it's a different patch though.

@serbanghita Hey, it's almost 2 years since my create this issue, I'm still expecting a array parsing feature.
Here's my proposal:
if the parsed value is "strictly ordered" and starts from "0", it should be pared to an array.
<input type="hidden" name="a[0]" value="12" />
<input type="hidden" name="a[1]" value="34" />

will get
{
  a: [12, 34]
}

<input type="hidden" name="a[2]" value="12" />
<input type="hidden" name="a[5]" value="34" />

will get
{
  a: {
   "2" : 12,
   "5": 34
  }
}

Believe yourself, you can do it. 💪 💪 💪

@littlee thanks for making the context more clear! Stay tuned 💥

Waiting for this feature too :)

Done in https://github.com/serbanghita/form-to-object/releases/tag/3.0.0-rc.0


Added apply response command to enable hybrid server-client implementations

Description
Adds an apply response action. Note, this also will trigger the send event complete event.
Related Issue
https://jira.corp.adobe.com/browse/PDCL-9396
https://jira.corp.adobe.com/browse/TNT-44491

Motivation and Context

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Improvement (non-breaking change which does not add functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA or I'm an Adobe employee.
[x] I have made any necessary test changes and all tests pass.
[x] I have run the Sandbox successfully.
[x] I've updated the schema in extension.json or no changes are necessary.
[x] My change requires a change to the documentation.

Hey @jonsnyder, this is my first time seeing this extension, can you share some context about how customers will use this feature?  How do they get a server response linked to alloy using this?

@jasonwaters I can give you a demo sometime if you’d like. In short, you would load the response headers and body into a JavaScript variable on page load. Then you would create data elements that reference these global variables. Then you would create a rule that triggers when the library loads with the apply response action. Finally, you could create a rule that triggers via the send event complete event if you need to do some process on the result of the applyResponse event.


[webportal] job list paging

Coverage remained the same at 34.828% when pulling d3a5d70841019f3c84f21ebcf994a574f9de427a on yiyi/webportal_job_paging into c0a616d890802d592ba32345ac196822db329316 on master.


Add Wasm load and store API to UntypedValue

Nearly all other Wasm operations are already included in the UntypedValue API but store and load operations were still missing. This will help to reduce code duplication especially if more wasmi engine backends and routines are added over time. Also this shifts some code from the bloated wasmi crate over to the more lightweight wasmi_core crate.

The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #608      +/-   ##
==========================================
- Coverage   80.85%   79.86%   -0.99%
==========================================
  Files          82       82
  Lines        6702     6785      +83
==========================================
  Hits         5419     5419
- Misses       1283     1366      +83

Impacted Files
Coverage Δ

crates/core/src/untyped.rs
76.61% <0.00%> (-18.93%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Improve DonateMenu and add more info to contributionMessage

I noticed some clicks weren't being picked up by the /cq donate menu; so I quickly fixed it myself.
While fixing that, I noticed a few more areas for improvement:
Non-donate menu related changes:

The plugin now blocks drag events from putting items in its menus
Item names in "materials" are parsed once; instead of on every check
Added contributionCount to contributionMessage since +1 looked awkward

Donate menu related changes:

Border item is created earlier
Clicks like shift-click, number key and off-hand swap are now considered as input
Since we get the clicked item more dynamically now, we can get rid of delaying the quest item check

If you do not want one or more of these changes, don't hesitate to comment on it and I'll remove it.
Feel free to also comment on code style, everyone has their own and I'll respect if you want something to not be different in your repository.

Looks great! Thanks for opening a PR, will take a closer look today and get it merged 😄