External crates

atom-racer is working great for completions from std and the current file in a project but it does not show completions from external crates and other files in the current project.  I was under the impression that racer supported external crates, reading dependencies from Cargo.toml files, and detecting the .cargo folder. Should these features work in atom-racer?  Am I doing something wrong?

Hello,
AFAIK, we provide "racer":

as RUST_SRC_PATH:

the user configured rustc sources along with
the current Atom project paths

as input for completion:

the currently edited buffer (and current editing position).

Racer does the rest and I dont know if it does special things to handle cargo.

Maybe @phildawes could shed some light?

Hello! Yes, racer should work with cargo. Also you say it doesn't work for files in the current project? Can you give an example please?
Thanks!

I think I know where the problem is:
We pass the current buffer to complete as a temporary file that is created in the systems temporary directory. And from what I understood, Racer is using that file's base path to search for a Cargo.toml.
We should probably switch to a strategy of writing the temp file at the root of the current project path so that it's found.
(Although I'm scared it might do strange flickers in sidebar due to adding and deleting files constantly while typing. Or find a way to force Atom to ignore our temporary file extensions).
I also have to check if Racer actually uses multiple values in RUST_SRC_PATH since we pass the current project path along with the rustc source using that environment variable.

That definitely seems like the problem.  Racer does use the open file and the multiple values in RUST_SRC_PATH because when I changed the project_path part of the RUST_SRC_PATH generated by atom-racer to project_path/src, it resulted in completing the names of the modules in project_path.  Oddly, it did not provide completions for anything in the modules, just their names.

Come to think of it, maybe it is only completing the names because it only loads "project_path/src/lib.rs" and not the source files in folders such as "project_path/src/MODULE_NAME".
Additionally, are the temporary files properly deleted after every racer invocation?  If so, moving the temporary files to the project's root could result in some serious clutter in a folder that should really remain clean.

Should be fixed by #29


JWK doesn't support certificate chain

Hi, as stated in https://vertx.io/docs/apidocs/io/vertx/ext/jwt/JWK.html, the certificate chains (x5c) in a JWK only allow a single element chain. Why so? Our company's OIDC compliant server has a certificate chain with all the CAs embedded. But the class io.vertx.ext.jwt.JWK throws an exception in this case...
if (json.containsKey("x5c")) {
    JsonArray x5c = json.getJsonArray("x5c");
    if (x5c.size() > 1) {
        throw new RuntimeException("Certificate Chain length > 1 is not supported");
    }

    CertificateFactory cf = CertificateFactory.getInstance("X.509");
    this.certificate = (X509Certificate)cf.generateCertificate(new ByteArrayInputStream(this.addBoundaries(x5c.getString(0)).getBytes(UTF8)));
}

Couldn't it just pick the first certificate ignoring the others in the chain and try to validate the token against that? Right now we're trying to test io.quarkus:quarkus-oidc:1.6.1.Final which includes io.vertx:vertx-auth-oauth2:3.9.1.

we can confirm this behaviou.

Webauthn supports this. I'll refactor oauth2 to also support it.

Wonderful, would it also be possible to create a fix for the 3.9.x stream? Because I don't know if the Quarkus people are ready for a major release change of 3.9.x to 4.x in the near future.

I can't promise anything on that field as webauthn is a 4.0 feature, it all depends on how hard is to backport.

The main branch for 4.0.0 was already supporting chains, I've ensured that the validation is consistent (and performed the same way across all handlers)

@dirien I've pushed to the 3.9 branch of vertx-auth a fix to allows certificate chains in JWKs endpoints. Can you run some tests on your side?

Hi @pmlopes, please excuse the late response. I've missed your hint for the fix. It works perfectly well with the version 3.9.5-SNAPSHOT. Thanks a lot! When can we expect a release of this version and more important an update of vertx-auth in a new Quarkus version?

Hi @develrulez releases are managed by @vietj , maybe he may give an estimate on a date


Leftovers

Both of these packages are still in registry

What version of Windows?
Where does it list those?
Did you try rebooting after running?

Yes, I see them in simplewall. Normally after uninstalling a windows store app, it will show as a random numerical combination.
For example, here are the uninstalled edge components.

But these edge components still exist
Microsoft.MicrosoftEdge_40.15063.0.0_neutral__8wekyb3d8bbwe.xml
Seems related to many built in apps
But it seems Microsoft.MicrosoftEdgeDevToolsClient_1000.22621.1.0_neutral_neutral_8wekyb3d8bbwe is related to appinstaller?

It should be working again

Yes, it removed those two packages


Misspelling

There looks to be a misspelling of the word migration in the endpoints.
Current: https://.sharepoint.com	Destination for migratrion
Should be: https://.sharepoint.com	Destination for migration

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 88bace7b-082e-b83d-5489-a9891d2c4e3a
Version Independent ID: d2777cb8-575d-064b-481c-9c870d8420b7
Content: Troubleshooting SPMT installation issues
Content Source: migration/spmt-install-issues.md
Service: sharepoint-online
GitHub Login: @JoanneHendrickson
Microsoft Alias: jhendr

@Padavid  Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

Hello @Padavid thanks for noticing and reporting, created a pull request to correct the article.

@Padavid Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


security.acme: added reload and restart lists for sytemd targets

Motivation for this change

added a list for systemd reload and restart targets
using the nixos module system to set the default at the domain option (instead of using code in the config =  section which duplicates code and makes it not accessible from outside the acme.nix scope)

Things done

[x] Fits CONTRIBUTING.md.

@zimbatm if you like it, please merge it. i didn't test 'our' work in production yet, so merge with care. and thanks for your effort, very much appreciated!

@zimbatm @fpletz
regarding default values
at the moment this is the most important patch so that domain is always stet to a resonable value (not null but a string) by default. this is a important patch since i can read the certificates directly and don't have to check if they are null and otherwise use the attrName.
regarding restart/reload
creating the new reload and restart targets was motivated by the idea that one can merge the different configs for a single domain so nixcloud.email could use the same TLS certificates as nixcloud.webservices but since merging does not work our current solution is to use seperate certs for these two use-cases.
this usage still does not exceed the quota of weekly certs of 4. that said, so far this works.

webroot might have to be a unique directory but i'm not sure.

How about creating a new PR with just the default values change?
The rest is less obvious to me and I don't have a setup to test it out right now; I think overall the idea is good, it just needs to be fleshed out a bit more.

@zimbatm yes, this seems to be a good idea. let's skip the restart/reload feature completely for the time being.

@zimbatm

please check this latest patch and squash merge it.
after your merge into master i would like to cherry-pick this into 17.09 later on, agreed?

@GrahamcOfBorg test acme

Failure on aarch64-linux (full log)
Partial log (click to expand)
Package ‘botan-1.10.17’ in /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/development/libraries/botan/generic.nix:46 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Partial log (click to expand)
webserver: running command: sync
webserver: exit status 0
test script finished in 105.64s
cleaning up
killing client (pid 612)
killing letsencrypt (pid 593)
killing webserver (pid 623)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/tmp/nix-build-vm-test-run-acme.drv-0/vde1.ctl': Directory not empty
/nix/store/7f6jj93lgz7klhdsl6kc2gsqn9cfk4rk-vm-test-run-acme

@qknight looks good to me. It should be safe to be cherry-picked as well.
Any idea on what to name the commit?

something like acme_default_value_via_module_system

Fixed XML in #34683


Expose Formidable's onPart

Feature Request Summary
So what I am trying to achieve is handle multipart/form-data with files, such that the file is not saved on disk. I need a stream/the content of files for parsing them further on, without having to go touch the file system.
The recommended way for Formidable is by providing a callback on each processed part, and then do an operation on the provided part (see https://stackoverflow.com/a/8760340/11599033). This requires setting onPart, but koa-body does not expose this?
My request is to either provide this option, or allow me to set my own Formidable object that I can modify on my own.
This request is similar to #36
Environment Information

koa-body: 4.1.1
Koa: 2.11.0
Node.js: v12.13.1

@Coada Having a similar issue right now? Wondering if you ever find a workaround for this. Thanks


Enhancement support only min/max runtime filter in BE

Proposed changes
this PR https://github.com/apache/doris/pull/25193 have achieve about FE.
eg: select count() from lineorder join supplier on lo_partkey < s_suppkey;
will have a max filter after build hash table , so could use it to filter probe table data.
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall


show labels on all events

hi, Can I show labels on all timeline events instead of just start and end? And also, id there a way to add some text in the labels that show under the event?

+1, interested as well

+1, I've just created a fork, I need this for some work I'm doing as well.  I found an earlier version of timeknots.js, being used from a dashing/smashing widget.

https://github.com/aysark/dashing-timeline/blob/master/assets/javascripts/timeknots.js

which suffers from a number of issues that are fixed in current version.  It seems somewhere between this version [1] and current we lost labels for all events.  I'll send a PR if I make some progress.

+1

+1


Can't find phrases in justified text

Attach PDF file here: 1503.01817v2.pdf (from https://arxiv.org/pdf/1503.01817v2.pdf)
Configuration:

Web browser version: Chrome 80.0.3987.158
Operating system version: Chrome OS 80.0.3987.158
PDF.js version: 2.5.40 https://mozilla.github.io/pdf.js/web/viewer.html
Is a browser extension: no (but also reproduces on https://chrome.google.com/webstore/detail/pdf-viewer/oemmndcbldboiebfnladdacbdfmadadm version 2.3.164)

Steps to reproduce the problem:

Open the attached PDF.
Search for "are not yet".

What is the expected behavior?
The line "tions are not yet available for the YFCC100M at present," should match. It matches as normal in Chrome's built-in PDF viewer.
What went wrong?
"are not yet" is not matched, as you can see in this screenshot:

You have to search for
are  not  yet

with doubled spaces in order for it to be found:

Analysis
This seems to happen because pdf.js is misunderstanding justified text and inserting extra spaces. If you copy the line and surrounding lines using pdf.js, you get the following string, with doubled spaces for the middle line which was more heavily justified:
boxes, segmentations of objects and faces, and image cap-tions  are  not  yet  available  for  the  YFCC100M  at  present,although generating and releasing them is on our roadmap.

whereas if you copy the same text using Chrome's PDF viewer, you get the following string with normal spacing:
boxes, segmentations of objects and faces, and image captions are not yet available for the YFCC100M at present,
although generating and releasing them is on our roadmap.

Additional information
Related to:

#4742 (Can't search across lines in some PDFs) and its PR #5783 (Improve Copy/Paste), but those are about there being too little whitespace not too much.
#11752 (Can't find words hyphenated across lines)

The PDF was generated with standard software for scientific papers: [1.5 pdfTeX-1.40.12 / LaTeX with hyperref package]

Duplicate of #7355.

Ah yes, #7355 seems to be the same issue, though I'd suggest a different solution. Rather than making Find in Document handle variable whitespace (or in addition), it seems it'd be cleaner to fix parsing of justified text so that spaces aren't doubled up. That way copied text would also have the correct whitespace, as in Chrome's pdfium.

Closing as a duplicate of that issue for now. Possible solutions can be discussed there to keep the discussion in a central place. I also feel like the correct solution would be to not double up the spaces, but text selection in PDF files is difficult and currently (partly) heuristic-based, which we should improve.


fritzcollectd: Support Fritz!Dect devices

Currently there's only support for switches.

Coverage decreased (-32.7%) to 67.284% when pulling 1065c36be34cb0fc35e3340a69091bc490d533f5 on dect into 92062bc35152f00b26e6fb6d70eb38c5b3799d2b on master.

Coverage decreased (-32.7%) to 67.284% when pulling 1065c36be34cb0fc35e3340a69091bc490d533f5 on dect into 92062bc35152f00b26e6fb6d70eb38c5b3799d2b on master.

Coverage decreased (-32.7%) to 67.284% when pulling b426b1d13587a0fc83021dcdf9d9f09d35f6a0f1 on dect into 92062bc35152f00b26e6fb6d70eb38c5b3799d2b on master.

Coverage decreased (-0.5%) to 99.462% when pulling 1afdebbf9cfd0ffc3ac4af4401c69ac80ab33f8d on dect into 92062bc35152f00b26e6fb6d70eb38c5b3799d2b on master.

Coverage decreased (-1.06%) to 98.942% when pulling 22c5438ef0a3c0ae892046f0bc59bfd07856d786 on dect into 92062bc35152f00b26e6fb6d70eb38c5b3799d2b on master.

Coverage decreased (-1.06%) to 98.942% when pulling 229a86dddd9f0e7f5644f016fa12b819b14972ae on dect into 92062bc35152f00b26e6fb6d70eb38c5b3799d2b on master.

Coverage decreased (-0.5%) to 99.471% when pulling 5f76aa6a09d1e090e5ae27d2f1427822385f8564 on dect into 92062bc35152f00b26e6fb6d70eb38c5b3799d2b on master.

Coverage decreased (-0.5%) to 99.471% when pulling b1b9dcb22d6de0f99b32fa2d153fc5810932b1ce on dect into 92062bc35152f00b26e6fb6d70eb38c5b3799d2b on master.

Coverage remained the same at 100.0% when pulling d8ab47b578337feb78ea77253b05a65efe323a86 on dect into 92062bc35152f00b26e6fb6d70eb38c5b3799d2b on master.


Schematic input does not validate, data path must not have additional properties(spec)

🐞 Bug report
Command (mark with an x)

[ ] new
[ ] build
[ ] serve
[ ] test
[ ] e2e
[X] generate
[ ] add
[ ] update
[ ] lint
[ ] extract-i18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Is this a regression?
yes

 Yes, the previous version in which this bug was not present was: ....
^11.2.12
Description
 A clear and concise description of the problem...
🔬 Minimal Reproduction

add to angular.json:
"@schematics/angular:component": {
"spec": false
}
run ng generate component blah
🔥 Exception or Error

Schematic input does not validate against the Schema: {"style":"scss","spec":false,"name":"_component/ListNotificationsComponent","project":"xxxx"}
Errors:

  Data path "" must NOT have additional properties(spec).

🌍 Your Environment
Schematic input does not validate against the Schema: {"style":"scss","spec":false,"name":"_component/ListNotificationsComponent","project":"hp-supplies-dataprovider"}
Errors:
Data path "" must NOT have additional properties(spec).

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/

Angular CLI: 12.1.4
Node: 14.17.3
Package Manager: yarn 1.22.5
OS: win32 x64

Angular: 12.1.4
... animations, cdk, cli, common, compiler, compiler-cli, core
... forms, language-service, localize, material
... platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1201.4
@angular-devkit/build-angular   12.1.4
@angular-devkit/core            12.1.4
@angular-devkit/schematics      12.1.4
@schematics/angular             12.1.4
rxjs                            6.6.7
typescript                      4.3.5

seems to be basically the same as https://github.com/angular/angular-cli/issues/20848 which is already closed and locked
solution is probably the same, remove the setting by a migration
If I remove the spec: false, it works as expected
It would probably be a good idea to check if any other options have been removed and add migrations for them as well

The spec option was removed in version 9 and we already have a migration that replaces the usage of this when upgrading from version 8 to 9.
https://github.com/angular/angular-cli/blob/268a03b63094d9c680401bc0977edafb22826ce3/packages/schematics/angular/migrations/update-9/schematic-options.ts#L51
You can re-run the migration by using the below command
ng update @angular/cli —-migrate-only schematic-options-9

It is possible one of the other developers updated angular outside of ng update.  Maybe it would be worth looking into a way to detect this and print a warning message.


Update dependencies, fix build

[X] All tests passed. If this feature is not already covered by the tests, I added new tests.

Have run all the tests that don't require a docker instance running.  If someone else has one handy and can test this, it would be appreciated!
Fixes #652

I have read the CLA Document and I hereby sign the CLA

recheck

Guys, any updates on this PR?

@elevenfive,
After merging this PR, I noticed that the publish tasks failed.
We'd appreciate it if you could create a new PR after verifying that the publishToMavenLocal task passes.
By the way - what is the original reason that the build failed for you? Did you compile with JDK 8?
Thanks.

Hi I was using JDK 11, are you able to run this build at all?  Upgrade to Gradle 7 is the reason, I will push with Gradle 6.  Gradle 7 migration will be more involved and beyond my current expertise with Gradle plugins.

hello! and when you are going to collect new realize ?


Labels and Properties

What is the Standard-Topbar? Do we have a Topbar? If not, simply use Topbar
We have a Full-Topbar... but the difference is unclear
There's no order for the categories.
Error-Bar -> Error Bar
SysColors -> System Colors
CrashView -> Crash View
CellPadding -> Cell Padding -> which cells do you mean?

Standard-Topbar -> Standard-Menu
Corporation-Topbar -> Corporation-Menu
Full-Topbar -> transferType Full (V2) Menu
If I all call them "Topbar" they will overwrite thmeselves in the map, but I can restructure the map so that I can change the display-name

What about: Topbar (Standard), Topbar (Corporation), Topbar (Full)
I don't like the Topbar-Standard (the minus sign without spaces)

This is also good, but I'm still going to change the map so a proper display-name can be shown. https://github.com/sibvisions/reactUIDesigner/issues/32 in this ticket I also want to hide editors so a visible-flag is also necessary, so I need to rebuild the map anyways

map with display names was introduced, now all topbars are only called "topbar". Also I've changed the labels which you pointed out.


Can't inject

Help please

Help please

Use Manual + Wouldn't use right now because it will crash randomly due to a invalid vmt hk

manual map not supported


Logo Change Request, Manual Review Required

Summary
This token already exists. I want to change the logo of the token. Logo Change Request #27460

@keone , hi please solve this issue. This token already exists. I want to change the logo of the token. Logo Change Request https://github.com/solana-labs/token-list/pull/27460


[WIP] Add Calm ~> DynamoDB adapter

This adds the interesting logic for a Calm ~> DynamoDB investor. Current status:

[x] Fetch first page of results from the OAI
[x] Fetch additional pages based on the resumptionToken
[x] Parse records/resumption token from the OAI XML
[x] Turn records into objects that can be pushed into DynamoDB
[ ] Push those objects to DynamoDB
[x] Rename this to "calm_adapter"
[x] Rewrite this as a series of actors
[ ] Add the ability to ingest the Calm XML dump

Because the OAI is incredibly slow, I think we eventually want to break this up into a series of actors – and then we don’t block waiting for the OAI. Initial thoughts on what those actors might look like:

We can take a complete XML dump or fetch incremental updates from OAI – but doing an initial ingest from the OAI will be much slower.
Resolves #52, #53.

I’ve just pushed a version that rewrites this as a series of actors, with broadly the same functionality as the old one. Still to do:

[ ] Actually push records to DynamoDB
[ ] Don’t ingest every record at once – we should ask Dynamo “what’s the latest record you already have”, then look at the modified timestamp (probably)
[ ] Error handling. What if a record doesn’t ingest correctly?
[ ] Docs

Having tried it now, it’s only the first call to the OAI that’s slow. Subsequent calls return extremely quickly. If we make the Dynamo table configurable, we could do a complete reingest by just pointing at an empty Dynamo table.
Plus a whole bunch of TODOs in comments.


Allow an extension / plugin to register variables into context

Actually context is created by user, but a plugin can also provide a context.
However there is no possibility to merge them, as an example a custom extension/plugin may propose variable to configure his behavior and allow user to change them if needed, not sure what's best in term of DX, but i think something like this would be nice :
#[AsListener(ContextCreateEvent::class)]
function update_context(ContextCreateEvent $event) {
    $event->context['value'] ??= 'default';
}

I think having context is better, so a plugin can also register environment variables if needed

Considering the listener, and if the application has N contexts, doest it update all contexts ?
Anyway there is a precedence issue between listener and context creation. Context should be resolved before listener because a listener can use the context
https://github.com/jolicode/castor/blob/feb54231303bcc8403c612725ab00ffe400bbbe5/src/Kernel.php#L118

Considering the listener, and if the application has N contexts, doest it update all contexts ?

Even if we have N context we generally use one contexts when executing a task, so we will mostly only update one context.
However if we use another context it should update it as well.

Anyway there is a precedence issue between listener and context creation. Context should be resolved before listener because a listener can use the context

I don't understand this portion, why context should be created before loading listeners, i understand why a context should be created before dispatching an event, but AFAIK listeners can be loaded (not executed) before ?

I don't understand this portion, why context should be created before loading listeners, i understand why a context should be created before dispatching an event, but AFAIK listeners can be loaded (not executed) before ?

Hhmmm, you are right!


feat: Update dependencies

: Upgrade lenra_components to v1.0.0-beta.26

:tada: This PR is included in version 1.0.0-alpha.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Only instantiate specification once

Fixes #1801
I had to make quite a few additional changes to satisfy mypy.

coverage: 94.231% (-0.06%) from 94.287%
when pulling f1d1b3ebab0a14c5537b7e6a6f69112c1642fb71 on bugfix/instantiate-spec-once
into bbd085bd390721cdd48a492b8a57a1bb1b99c4f2 on main.


Investigate implications of moving to self hosted kubernetes

DOD:
Write up on the implications of moving to self hosted kubernetes. Understand the benefits/challenges. Propose a way to migrate.

create a new ticket for this, phase-2 and make it a priority p2


Push is using old state reference when using connect from react-redux

Version
4.1.1
Steps to reproduce
I have a modal that contains a button that dispatches the following async action:
export const searchNewConverters = () => {

  const url = `/api/Converters/SearchNewConverters`;

    return (dispatch, getState) => {
      dispatch(actions.closeModal());
      dispatch(actions.requesting());

      axios
        .get(url)
        .then(({ data }) => {
          dispatch(actions.searchNewConverters(data));
        })
        .then(() => {
          dispatch(actions.completed());
          dispatch(push("/converterList"));
        })
        .catch(error => {
          dispatch(globalActions.completed());
          console.log(error);
        });
    };
};

When using connect from react-redux in my component:
When I dispatch actions.searchNewConverters(), the newConverters Array inside my converter object in state is updated to this:

However, as soon as I dispatch push("/converterList"), the newConverters Array inside my converter object in state is updated to this:

When not using connect from react-redux in my component:
The push action does not update the newConverters Array.

Am I missing something? Or is this unexpected behavior?

Nothing in react-router-redux touches those other state properties. In fact, when used inside combineReducers it doesn't even have access to them.
My only guess is something else is going on with your connect argument functions. But that would have nothing to do with the router.


improve error message when user supplies an invalid chip name

Describe the bug
Currently, when I supply an incomplete or wrong chip name, for example
probe-run --chip nrf5 tests/test_elfs/hello

, I get a somewhat misleading error message:
➜  probe-run git:(main) ✗ probe-run --chip nrf5 tests/test_elfs/hello
(HOST) INFO  flashing program (5.75 KiB)
Error: Error while flashing

Caused by:
    The execution of 'erase_sector' failed with code 1. Perhaps your chip has write protected sectors that need to be cleared? Perhaps you need the --nmagic linker arg https://github.com/rust-embedded/cortex-m-quickstart/pull/95

I would expect to get a notification that what I passed to --chip isn't valid instead.

I think what's happening here is that probe-rs picks the first target whose name starts with nrf5, and then that ends up being the wrong one (nRF51?), so flashing doesn't work.
I think what we should do here is adjust the code below to check if the fetched Target's name matches what the user input, and issue an info! log that says that the target was adjusted if not (or some other on-by-default level):
https://github.com/knurling-rs/probe-run/blob/783724ad289f55883eb0ec43536ec2377b4c2a49/src/target_info.rs#L17

the alternative is to require an exact name match but this would be a breaking change (we are releasing probe-run 0.3 soon-ish so that's not much of an issue). some full chip names are rather non-memorable though, e.g. instead --chip nrf52840 you would need --chip nRF52840_xxAA.
OTOH, for the start substring nrf52832 there are actually two matches in probe-rs database (see probe-run --list-chips): nRF52832_xxAA and nRF52832_xxBB. unsure what the difference between the 2 is but if you use probe-run --chip nrf52832 today you do not get an errror, probe-rs probably uses the first match? (not sure). I think that would be worthwhile to change to emit an error if there's more than one match (which also is a breaking change AND it technically turns probe-rs additions to their target database that generate ambiguity into breaking changes in probe-run)

I discovered that probe-rs does not accept ambiguous chip names anymore since https://github.com/probe-rs/probe-rs/pull/815, so I think we can close this issue here.


dimension whitelist/blacklist for ender daisy

It will prevent ender daisy to spawn in all dimensions it shouldn't spawn.

there is a config option:
# Whether or not Ender Daisies generate naturally [default: true]
B:EnableEnderDaisyWorldGen=true
Use this for now..I will add support for a dim whitelist/blacklist though

i keep em open till I get the jar on curse ;)


Restore aarch64 support

Changelog
- description: |
    Restored `aarch64` support
  type:
  - maintenance

Context
cardano-cli already has support aarch64 and it depends on cardano-api, so I am not sure why this is disabled.
How to trust this PR
If the CI passes I would trust it.
Checklist

[x] Commit sequence broadly makes sense and commits have useful messages
[x] New tests are added if needed and existing tests are updated. See Running tests for more details
[x] Self-reviewed the diff

@smelc smooth as butter 😆


Imposible to use raw data in AbstractRestfulController in some cases

here https://github.com/zendframework/zend-mvc/blob/8a464ff52049a6ad4990347eb30f69fb79f14a47/src/Controller/AbstractRestfulController.php#L586 is unreachable code
parse_str($content, $parsedParams); // returned $parsedParams keys not indexes

there are only one way to get raw response if $content is something like 0=something otherwise if $content = 'foo' or similar parse_str() will return ['foo' => '']

for example if you use:
public function update($name, $data) {
    // here $data is always array but sometimes I need just a string or xml or something.. I want raw data
}

ping @weierophinney or someone any response?

Fixed with #43


Set assembly versions by MSBuild

Related #3400
Motivation
We inherited old assembly file versions from Windows PowerShell.
Currently we shouldn't set versions of assemblies statically in AssemblyInfo.cs files, we should set versions of assemblies dynamically by MSBuild as discussed in #3690.
Fix

Remove AssemblyVersion and AssemblyFileVersionAttribute attributes from AssemblyInfo.cs files.
Put all common properties in PowerShellCommon.props including version related properties.
Import PowerShellCommon.props in all csproj files.

Follow-Up Work
In the PR we temporarily hard code assembly versions as "6.0.0-beta.2".
Later we should set a dll version based on GitCommitId.

@mirichmo @daxian-dbw Could you please continue with the PR?

@mirichmo I don't think this PR is ready to merge yet. Please revert this merge.
@PowerShell/powershell-maintainers I didn't get the time to thoroughly review all PRs related to .csproj changes. Let's hold on merging them.

@mirichmo hold on the revert. Let's see if we can quickly fix the issues.

@mirichmo I don't have a quick fix. I suggest reverting this merge for now and submit another PR later.

This merge has been reverted via #4091. Thanks @mirichmo for the quick turnaround.
@iSazonov Sorry for the troubles ☹ Lesson learned: if you think a PR is risky but don't yet have the time to thoroughly review, leave a comment to point out that you need more time to review so that everyone is on the same page. I will open a new PR for this change.

😕 It's a very strange side effect. I thought PowerShell Core assembles is not Windows PowerShell assemblies, and we could be free in the change. CoreFX assemblies don't keep old versions too. Maybe a right way is to be based on packages versions?

@iSazonov With netstandard2.0 we expect most of the existing Windows powershell modules to work on powershell core without change. They were built against <IP_ADDRESS> S.M.A.dll, so we want to make sure nothing will break there.
By the way, I think you have to submit a new PR for this. If I submit it, it will be from my fork and thus you won't be able to make changes. It's very easy to check out a PR with the tool hub. Once you get that tool, you can do things like this to get the changes from this PR:
## It will get the changes from this PR to a local branch named iSazonov-csproj-common-props
hub checkout https://github.com/PowerShell/PowerShell/pull/3917
## Then rebase this branch and push it to your fork
## Then submit a new PR with that remote branch

Again, sorry for the troubles and thanks for your understanding.

@daxian-dbw Should I restore the branch for you?

I think you have to submit a new PR for this.

Ok!


Dist folder missing...?

I'm looking to use this plugin purely in a browser and I was hoping to find the native JS code in a dist folder (as mentioned in the documentation). However, there is no dist folder. Can you help?

Are you sure? Unpkg is able to find it:
<EMAIL_ADDRESS>

Thanks. I was looking in the master branch here on GH.


Auto adding query into any options variable

For some reason, when I'm giving to subscribe function some options variable, It wraps her arguments in query: {}. This is not cool, to find, that your variable was edited, when you just gave it to your function. I've fixed this by replacing options (in func) on JSON.parse(JSON.stringify(options)). May be there are more efficient way, but idk. Here is example:
let options = {
	sort: '-updated',
	expand: 'allowed,owner'
};

await pb.collection('users').subscribe('*', () => {}, options);

console.log(options);

// options = {
//     "query": {
//         "sort": "-updated",
//         "expand": "allowed,owner"
//     }
// }

I've pushed a minor update in v0.21.5 release to shallow copy the options argument similar to the other methods.
Note that we don't do deep clone because the options argument could technically contain user defined functions (e.g. fetch) which will require special manual handling. I'll think a little more on it with the refactoring and eventually may create a helper that will call structuredClone + some additional handling for the special cases but for now remains a low priority.


local checksum not match remote while node-gyp install

#645

We're seeing the same issue -- see travis-ci/travis-ci#5562

What's the issue?  It downloads the tarball and the checksum fails?  What makes you think it's node-gyp and not e.g. a network problem?

Quoting @klemmster in that issue:

TLDR: It's a node-gyp issue, yes. I don't think there's anything you could do. (Other than making node_jsversion variable (in travis.yml) available even though language is not set to nodejs. That would make choosing a different node version easier.)
For some reason, node-gyp wasn't calculating the correct sha256sum of the downloaded node-v0.10.xx.tar.gz
Thanks to the ssh access I got from you, I was able to pinpoint the problem to
node-gyp configure.
Using NODE_DEBUG=request node-gyp configure it seems the file received was fine (at least the filesize was ok), so it doesn't seem to be a networking/proxy or caching issue. (I curled over the download a 100 times, file was also ok)
I wasn't able to pinpoint what's the root cause of the issue though. Something within install.js in node-gyp(v3.0.3).

That it's the correct file size doesn't mean they're the right bytes; chunks may have gotten corrupted in transit.  What does sha256sum (the command line tool) print for the tarball?
I'm inclined to believe it's an issue local to your environment.  If everyone was hit by this, we'd be swamped in bug reports, but we're not.

for i in {1..100}; do  curl -s "https://nodejs.org/dist/v0.10.36/node-v0.10.36.tar.gz" | sha256sum; done

printed the correct sha256sum a hundred times
Also,
fs.readFile('/tmp/node-v0.10.36.tar.gz', function(err, data) {
  if(err) {throw err;}
  var shasum = crypto.createHash('sha256');
  shasum.update(data);
  console.log(shasum.digest('hex'));
});

did.
I wasn't able to find the tarball download by node-gyp. If you could point me to it, I'd be happy to provide a checksum for that as long as travis debugging instance is still available to me (don't know when they close it)

v0.10.36 is the tarball you want?  What happens when you rm -rf $HOME/.node-gyp and then run node-gyp install --dist-url=https://nodejs.org/dist v0.10.36?  Please post the complete output.

$ node /home/travis/.nvm/v0.10.36/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js install --dist-url=https://nodejs.org/dist v0.10.36

gyp info it worked if it ends with ok
gyp info using<EMAIL_ADDRESS>gyp info using<EMAIL_ADDRESS>| linux | x64
gyp http GET https://nodejs.org/dist/v0.10.36/node-v0.10.36.tar.gz
gyp http 200 https://nodejs.org/dist/v0.10.36/node-v0.10.36.tar.gz
gyp http GET https://nodejs.org/dist/v0.10.36/SHASUMS256.txt
gyp http 200 https://nodejs.org/dist/v0.10.36/SHASUMS256.txt
gyp WARN install got an error, rolling back install
gyp ERR! install error
gyp ERR! stack Error: node-v0.10.36.tar.gz local checksum 0064afb1eafc4ddfc456036d3848986e9f101122bf9ab5039d9a4958554adac8 not match remote b9d7d1d0294bce46686b13a05da6fc5b1e7743b597544aa888e8e64a9f178c81
gyp ERR! stack     at deref (/home/travis/.nvm/v0.10.36/lib/node_modules/npm/node_modules/node-gyp/lib/install.js:300:20)
gyp ERR! stack     at IncomingMessage.<anonymous> (/home/travis/.nvm/v0.10.36/lib/node_modules/npm/node_modules/node-gyp/lib/install.js:339:13)
gyp ERR! stack     at IncomingMessage.emit (events.js:117:20)
gyp ERR! stack     at _stream_readable.js:944:16
gyp ERR! stack     at process._tickCallback (node.js:442:13)
gyp ERR! System Linux 2.6.32-042stab108.8
gyp ERR! command "node" "/home/travis/.nvm/v0.10.36/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "install" "--dist-url=https://nodejs.org/dist" "v0.10.36"
gyp ERR! cwd /home/travis
gyp ERR! node -v v0.10.36
gyp ERR! node-gyp -v v3.0.3
gyp ERR! not ok

And the same with --verbose
http://pastebin.com/tNzqP6Vu

Thanks.  Can you try downloading v0.10.36 again but now with node v4.2.6 or v5.x as the binary that runs node-gyp?  Please delete the .node-gyp directory first.

Also, FWIW, it works perfectly for me with v0.10.41 and v6.0.0-pre (i.e. node master.)

$ node /home/travis/.nvm/versions/node/v5.5.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js install --dist-url=https://nodejs.org/dist v0.10.36
gyp info it worked if it ends with ok
gyp info using<EMAIL_ADDRESS>gyp info using<EMAIL_ADDRESS>| linux | x64
gyp http GET https://nodejs.org/dist/v0.10.36/node-v0.10.36.tar.gz
gyp http 200 https://nodejs.org/dist/v0.10.36/node-v0.10.36.tar.gz
gyp WARN install got an error, rolling back install
gyp ERR! install error
gyp ERR! stack Error: unexpected end of file
gyp ERR! stack     at Zlib._handle.onerror (zlib.js:363:17)
gyp ERR! System Linux 2.6.32-042stab108.8
gyp ERR! command "/home/travis/.nvm/versions/node/v5.5.0/bin/node" "/home/travis/.nvm/versions/node/v5.5.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "install" "--dist-url=https://nodejs.org/dist" "v0.10.36"
gyp ERR! cwd /home/travis/.nvm/versions/node/v5.5.0/lib/node_modules/npm/node_modules/node-gyp
gyp ERR! node -v v5.5.0
gyp ERR! node-gyp -v v3.0.3
gyp ERR! not ok

The "unexpected end of file" error means something went wrong while downloading.  It's probably either a corrupted chunk or the connection was closed prematurely.

Running that little script:
var http = require('http');
var fs = require('fs');

var file = fs.createWriteStream("node-v0.10.36.tar.gz1");
var request = http.get("http://nodejs.org/dist/v0.10.36/node-v0.10.36.tar.gz", function(response) {
  response.pipe(file);
});

a 100 times:
for i in {1..100}; do rm node-v0.10.36.tar.gz1 && node download.js && sha256sum node-v0.10.36.tar.gz1; done
I do get:
…
b9d7d1d0294bce46686b13a05da6fc5b1e7743b597544aa888e8e64a9f178c81  node-v0.10.36.tar.gz1
b9d7d1d0294bce46686b13a05da6fc5b1e7743b597544aa888e8e64a9f178c81  node-v0.10.36.tar.gz1
b9d7d1d0294bce46686b13a05da6fc5b1e7743b597544aa888e8e64a9f178c81  node-v0.10.36.tar.gz1
cad7af68d21457d9408002394ecb0cedf46b8f858d0159b6776dcb8982289990  node-v0.10.36.tar.gz1
…
b9d7d1d0294bce46686b13a05da6fc5b1e7743b597544aa888e8e64a9f178c81  node-v0.10.36.tar.gz1
b9d7d1d0294bce46686b13a05da6fc5b1e7743b597544aa888e8e64a9f178c81  node-v0.10.36.tar.gz1
4a67cbef70ad6399ef64ccd4812d16fe1dde5c3680714408c1d90bef10b38fa2  node-v0.10.36.tar.gz1
b56c3a746a0502ed2e2d974c3466fb374b8a680961da63a10ee08a3dbc9f2de4  node-v0.10.36.tar.gz1
b9d7d1d0294bce46686b13a05da6fc5b1e7743b597544aa888e8e64a9f178c81  node-v0.10.36.tar.gz1
…
b9d7d1d0294bce46686b13a05da6fc5b1e7743b597544aa888e8e64a9f178c81  node-v0.10.36.tar.gz1
51de26b504db37ed79f37a8613c36dff7c6a39c4e909fe05173f1fd18c19c5d4  node-v0.10.36.tar.gz1
b9d7d1d0294bce46686b13a05da6fc5b1e7743b597544aa888e8e64a9f178c81  node-v0.10.36.tar.gz1
…
b9d7d1d0294bce46686b13a05da6fc5b1e7743b597544aa888e8e64a9f178c81  node-v0.10.36.tar.gz1
562c5e8eb639250523c198d006d8d86ca08bc269f854c557ceb7ba84a08f0d9e  node-v0.10.36.tar.gz1
b9d7d1d0294bce46686b13a05da6fc5b1e7743b597544aa888e8e64a9f178c81  node-v0.10.36.tar.gz1
b9d7d1d0294bce46686b13a05da6fc5b1e7743b597544aa888e8e64a9f178c81  node-v0.10.36.tar.gz1
…

while it still never fails with  curl.
So the question remains why node receives corrupted chunks and closes the connection where curl doesn't.

Your guess is as good as mine.  I ran it in batches of 10 downloads a few times but I always get the right checksum:
$ for i in {1..10}; do rm -f node-v0.10.36.tar.gz1 && out/Release/node tmp/issue693.js && sha256sum node-v0.10.36.tar.gz1; done
b9d7d1d0294bce46686b13a05da6fc5b1e7743b597544aa888e8e64a9f178c81  node-v0.10.36.tar.gz1
b9d7d1d0294bce46686b13a05da6fc5b1e7743b597544aa888e8e64a9f178c81  node-v0.10.36.tar.gz1
b9d7d1d0294bce46686b13a05da6fc5b1e7743b597544aa888e8e64a9f178c81  node-v0.10.36.tar.gz1
b9d7d1d0294bce46686b13a05da6fc5b1e7743b597544aa888e8e64a9f178c81  node-v0.10.36.tar.gz1
b9d7d1d0294bce46686b13a05da6fc5b1e7743b597544aa888e8e64a9f178c81  node-v0.10.36.tar.gz1
b9d7d1d0294bce46686b13a05da6fc5b1e7743b597544aa888e8e64a9f178c81  node-v0.10.36.tar.gz1
b9d7d1d0294bce46686b13a05da6fc5b1e7743b597544aa888e8e64a9f178c81  node-v0.10.36.tar.gz1
b9d7d1d0294bce46686b13a05da6fc5b1e7743b597544aa888e8e64a9f178c81  node-v0.10.36.tar.gz1
b9d7d1d0294bce46686b13a05da6fc5b1e7743b597544aa888e8e64a9f178c81  node-v0.10.36.tar.gz1
b9d7d1d0294bce46686b13a05da6fc5b1e7743b597544aa888e8e64a9f178c81  node-v0.10.36.tar.gz1

I did notice that node v0.10.40 uses a ton more CPU time than v6.0.0-pre but that doesn't seem to affect the download results:
$ for i in {1..10}; do rm -f node-v0.10.36.tar.gz1 && ../v0.10/out/Release/node tmp/issue693.js && sha256sum node-v0.10.36.tar.gz1; done
b9d7d1d0294bce46686b13a05da6fc5b1e7743b597544aa888e8e64a9f178c81  node-v0.10.36.tar.gz1
b9d7d1d0294bce46686b13a05da6fc5b1e7743b597544aa888e8e64a9f178c81  node-v0.10.36.tar.gz1
b9d7d1d0294bce46686b13a05da6fc5b1e7743b597544aa888e8e64a9f178c81  node-v0.10.36.tar.gz1
b9d7d1d0294bce46686b13a05da6fc5b1e7743b597544aa888e8e64a9f178c81  node-v0.10.36.tar.gz1
b9d7d1d0294bce46686b13a05da6fc5b1e7743b597544aa888e8e64a9f178c81  node-v0.10.36.tar.gz1
b9d7d1d0294bce46686b13a05da6fc5b1e7743b597544aa888e8e64a9f178c81  node-v0.10.36.tar.gz1
b9d7d1d0294bce46686b13a05da6fc5b1e7743b597544aa888e8e64a9f178c81  node-v0.10.36.tar.gz1
b9d7d1d0294bce46686b13a05da6fc5b1e7743b597544aa888e8e64a9f178c81  node-v0.10.36.tar.gz1
b9d7d1d0294bce46686b13a05da6fc5b1e7743b597544aa888e8e64a9f178c81  node-v0.10.36.tar.gz1
b9d7d1d0294bce46686b13a05da6fc5b1e7743b597544aa888e8e64a9f178c81  node-v0.10.36.tar.gz1

My working hypothesis is still that it's an issue local to your environment.

On a newly-configured Windows 10 box , node-gyp install dies at different points, with checksum errors. I ran @klemmster's download.js to see what it did. Surprise: almost every time, it produces different results. Here's five runs in a rwo (file size in bytes):
14,385,078 node-v0.10.36.tar.gz1
14,410,899 node-v0.10.36.tar.gz1
14,410,899 node-v0.10.36.tar.gz1
14,397,978 node-v0.10.36.tar.gz1
14,407,382 node-v0.10.36.tar.gz1

The correct size is 14,410,899 (running download.js on Linux shows this). So it looks like the last block is being arbitrarily lost. Whatever the cause, it makes node-gyp unusable on Windows.

/cc @nodejs/platform-windows - is anyone able to reproduce?

FWIW it is not a node-gyp issue, pretty sure of that. I also tried node-gyp-install and got the same results. Using 'node-gyp configure' I was after about 8 attempts able to get an OK, and then build. My test server is on Rackspace and has no proxy. However it does break node-gyp badly so is worth investigating IMO.

@hintjens (and others able to repro this) can you npm ls inside the node-gyp directory and see what version of request you have bundled with it? The download is almost entirely handled by request so the problem likely there or possibly in core (it's also interesting to note you're using v0.10.36 so perhaps it's an old bug that's since been fixed in Node v4+).
Cruising through the request issues shows things up like https://github.com/request/request/pull/1568 so the problem could easily be there too.

node-gyp is using<EMAIL_ADDRESS>

well then .. that's the latest, I'll file an issue over there and see if they have a clue, we can't rule out a v0.10 problem, however.

actually, I'm going to hold off and try a bit harder to reproduce it myself, there's some old style streams work going on in there that I think could be improved

I never have this problem on Linux or OS X, always have this problem with Windows (now that I'm doing prebuilds for all platforms of native dependencies).

Fwiw, in eight Travis builds we are seeing five checksum mismatches, one "Completion callback never invoked!", one 522, and one success, suggesting that this is network-related.

we are having issues with our download service right now. hoping to have it
sorted out very soon
On Fri, Dec 9, 2016, 11:36 AM Chad Whitacre<EMAIL_ADDRESS>wrote:

Fwiw, in eight Travis builds
https://github.com/gratipay/gratipay.com/pull/4130#issuecomment-266057077
we are seeing five checksum mismatches, one "Completion callback never
invoked!", one 522, and one success, suggesting that this is
network-related.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nodejs/node-gyp/issues/693#issuecomment-266058950,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAecV8U3FHYNyv00TdvYqu-MT9epVDbVks5rGYOUgaJpZM4FtWv0
.

closing due to staleness


panic: runtime error: slice bounds out of range

https://play.golang.org/p/of9fapZ8vMs

CVE-2020-36067 was assigned to this issue.

CVE-2020-36067 was assigned to this issue.


[ BETA ] Mobility Update v1.2.1-beta

ACF MOBILITY UPDATE V1.0.0-beta

This update brings new logic to ACF3 mobility. This update will NOT affect existing dupes that are using the legacy mobility components. Updated components must be spawned new as they do not share the same class as legacy components.
Legacy components cannot be auto updated by using the ACF spawner tool to use the new mobility logic. THEY MUST BE SPAWNED NEW
Legacy Components CANNOT be linked to updated components and vice-versa.
Please view the Other Changes sections for how to enable/disable this update, and to spawn updated components.
**this update is experimental and may have adverse effects to your health
**please be patient as bugs may increase in prevalence to its stage of development
Engine Component Changes

Engine Feedback - engine rpm is matched to gearbox rpm
Engine Braking - braking torque is applied to wheels in the absence of throttle input
Engine Over-rev - engines are no longer limited to their redline
Improved Flywheel Response - flywheel mass has an improved response to sudden load
Idle Throttle - engines will roll in gear

Gearbox Component Changes

Gear Ratios Use Realistic Ratios - gear ratios no longer follow a 0 ...1 format
Improved Clutch Simulation
Gearboxes Have RPM - rpm is retrieved from connected wheels relative to gear ratio
Differentials are Open - differentials are no longer limited slip
Ratio Converter -Converts old ratios to new ratios and vice-versa
Past Data -Ability to paste data from the copy tool to gearbox ratios

Other Changes

New Server Setting - server setting to allow client spawning of new engine components
- New Client Setting - client setting to spawn updated components
- New Client CMD - acf_mobilityupdate can be used to enabled/disable this update
- Update Eligibility - notification description added to all engines and gearboxes.
!

Future Updates

[ ] Limit slip slider added to differentials
[ ] Automatic Gearbox Update
[ ] CVT Gearbox Update
[ ] Double Differential Update
[ ] Auto Clutch
[ ] Engine Over Rev Damage
[ ] Clutch Slip Due to Over Torque
[ ] Clutch Damage

For Developers
Creating Eligible Components
To create or update existing engine addons, all engines must have the following variables in their registry:

Displacement
FlywheelMassUpdate

Important Info
Updated mobility components are NOT acf_engine acf_gearbox classes.
Updated mobility components are acf_engine_update acf_gearbox_update classes.
The reason for this was to create a separation of legacy and updated mobility components to maintain a stable mobility components as changes are made to the mobility update.
The legacy components should be considered depreciated.

I notice the calcMass test is failing for KEShove, I was told that it was caused from an  unrelated change to KEShove. Is there something I need to update or change for this pull request?

Merge the latest commit from dev and the tests should be good now

Do you plan to move the new functionality into the existing acf_engine/gearbox classes? I assume the separation is to allow this to be used on servers in the meantime, but if this is intended to be the long-term implementation I'm not really sure why it's necessary. Same thing with the FlywheelMassUpdate variable for engines; this should just be moved into FlywheelMass in the end (adding fully new ones like Displacement is fine, but we may want to have a default value for existing addons that do not get updated)
Also for everyone's future reference, this appears to close #250 (feel free to correct me on this if not or tag any other applicable issues)

Yes, the end goal is to replace the logic of current acf_engine and acf_gearbox classes. You're correct that the separation, duplicate variables, and server settings are there to make it usable on servers, without forcing a change to existing contraptions that are using the old logic.
The reason I'm approaching the change in this way is to catch any major issues and to get feedback before it becomes the main system. The differences between the new logic and the old logic are great enough that it's a better idea to implement and test along side the old system in the dev branch until it reaches a stable release.
Displacement is used to simulate engine braking and should be the only new variable introduced. This could possibly be defaulted to 0 for older addons.

This would also close https://github.com/ACF-Team/ACF-3/issues/134, one of the most annoying long-standing issues in all versions of ACF

This also closes #136 & #103 bug and suggestion

I have a couple of suggestions but I wasn't entirely sure with bringing them up because they could certainly end up being controversial.
One of the topics that has been brought up in the discord when it comes to mobility components is the inconsistency on the units used by them:

Clutches use 0-1
Throttle uses 0-100
Brakes use 0-100 unless you need more then it goes all the way up to 5000 (iirc)
Which makes me think, would it be possible to standarize all these inputs to use a single unit? Changing Throttle and Brake to work with 0-1 would certainly make everything much simpler for the end user, but it'd also break every single old contraption prior this change.

Yeah I could make them all use a 0-1 value and for brakes to use 0-50 to keep it relative. The input manager for throttle converts 0-100 to a 0-1 value immediately anyways so that would make the code a lot more simple.
Not sure how the manager for brake converts but i assume it’s the same.
It wouldn’t necessarily break old contraptions, but if they did use say 50 throttle it would be similar to using 100% throttle since the value would be clamped to 1 as a maximum.
I do like this update because it would allow users to use nothing but a chair and a wire POD controller for mobility if they don’t have access to ecu codes

This says closed, does that mean it was not integrated at all to the main ACF? Would be a real bummer as this fixes so many issues with ACF.


Research how to upload file to website (frontend)

@sahansk2

Useful reference: https://javascript.info/file


Create multiple smoke flows in a line from where a round is fired

Iterate over tiles in a hitscan and take x from the smoke amount and then move forwards until the smoke amount is 0

Could just add 1 tile distance to a line and get the tile in that line until a solid is hit, not as accurate as a proper hitscan but easier to implement


Remove EL6 from builds

Remove EL6 from st2-enterprise-auth-backend-ldap.

Thanks!
I couldn't find any other el6 rpm specific logic in this repository.

I searched all files for 6, but if there is something in there without a comment then it might have got missed, but was the best way I could try and find anything EL6 specific.


DBZ-2296 Change handling of GTID_MODE=OFF_PERMISSIVE and ON_PERMISSIVE

return false instead of true from isGtidModeEnabled for GTID_MODEs of OFF_PERMISSIVE and ON_PERMISSIVE

@echatman-ias Applied, thanks


Add support for sparse arrays (pydata) to .varp and .obsp fields

Please describe your wishes and possible alternatives to achieve the desired result.
scipy.sparse only supports 2D arrays. Whereas varp and obsp support N-D arrays.
Most of the time we would want them to be sparse.
But right now anndata prevent the varp and obsp fields to contain the pydata/sparse formats.
Not all but many features are available on these matrix formats. Are there missing features that would be required as of now that would prevent this integration?

Ah, you’re talking about https://sparse.pydata.org/en/stable/.
We haven’t talked about this much yet, but it’s definitely worth discussing.

Let me know if I can help since it doesn't seem like too complicated to add and would be worth it for some applications :)
If you can point me to some of files to be looking at for updates I can have a look

@jkobject If I remember, our main stumbling block with this up until now has been the dependency on numba, which is too much for anndata.
But we could do this as an optional dep.  In this case, we should think more broadly about a registration mechanism for choosing which array type gets returned from i/o.  This would be helpful for GPU.

I would add that last I talked to the authors of pydata/sparse they were looking at a full rewrite. So it might be in a rocky state for a while.

@ivirshup it loooks like the package has a backend for finch now...could be worth trying out actually...would be huge for array-api compat!


forcejump

whats offset for dwforcejump?

https://github.com/a2x/cs2-dumper/blob/main/output/buttons.rs#L14
hf following your bhop tutorial


Cr src returns error

When I attempt to run cd src main.py in cmd I get an error saying CD is not valid along with a few other errors.
Is there perhaps a way to make a exe that is less tempermental?

this can be closed. I was combining the cd src and main.py commands.
I do however after sperating the commands run into a new error. Path, Line 1, in  from PyQt5.QtGui import Qicon, QDesktopServices ModuleNotFoundError: No module named 'PyQt5'

I was also running into this - any solution?

Yes first enter cd src command and switch into the directory that contains main.py. then the next command is to run main.py
The error fristrated87 ran into can be fixed by updating the moduals to the latest ones. Once it was all updated I was able to run it but couldn't get it to search or anything and have not progressed beyond this point.


MaxBitRate is ignored in Android

Bug
Problem:
After setting MaxBitRate property, Android Exoplayer is seen to ignore this value and continues downloading/playing the video track with highest bitrate in the HLS playlist.
Platform

Android ExoPlayer

Environment info
"react-native": "0.66.4",
"react-native-video": "5.2.0",

Steps To Reproduce

Play a video with HLS list (.m3u8 format), having a few resolutions and set MaxBitRate to a value such that it should only qualify 3 tracks.

Example master manifest file:
#EXT-X-STREAM-INF:BANDWIDTH=2516370,AVERAGE-BANDWIDTH=2516370,CODECS="mp4a.40.2,avc1.640020",RESOLUTION=720x1280,CLOSED-CAPTIONS=NONE

#EXT-X-STREAM-INF:BANDWIDTH=1640580,AVERAGE-BANDWIDTH=1640580,CODECS="mp4a.40.2,avc1.640020",RESOLUTION=540x960,CLOSED-CAPTIONS=NONE

#EXT-X-STREAM-INF:BANDWIDTH=4755240,AVERAGE-BANDWIDTH=4755240,CODECS="mp4a.40.2,avc1.64002a",RESOLUTION=1080x1920,CLOSED-CAPTIONS=NONE

#EXT-X-STREAM-INF:BANDWIDTH=994068,AVERAGE-BANDWIDTH=994068,CODECS="mp4a.40.2,avc1.64001f",RESOLUTION=360x640,CLOSED-CAPTIONS=NONE

#EXT-X-STREAM-INF:BANDWIDTH=697078,AVERAGE-BANDWIDTH=697078,CODECS="mp4a.40.2,avc1.64001e",RESOLUTION=270x480,CLOSED-CAPTIONS=NONE

With the list, above, set maxBitRate={1640580}

Observe on Android Exoplayer, it still downloads the highest resolution chunks to play after the initial chunk. You can cross check the downloaded chunk url belongs to the manifest of the highest resolution.

...
Expected behaviour
After setting MaxBitRate, Android Exoplayer should be downloading/playing only video track that honours the max bit rate set.
Reproducible sample code
<Video
source={{ uri: 'https://multiplatform-f.akamaihd.net/i/multi/will/bunny/big_buck_bunny_,640x360_400,640x360_700,640x360_1000,950x540_1500,.f4v.csmil/master.m3u8' }}
style={{ width: 300, height: 300 }}
maxBitRate={1062000}
} />

Video sample
You may try with
https://multiplatform-f.akamaihd.net/i/multi/will/bunny/big_buck_bunny_,640x360_400,640x360_700,640x360_1000,950x540_1500,.f4v.csmil/master.m3u8
Comments
Not sure if this was intentional but digging through the Exoplayer code it seems that the culprit of this behaviour stems from the videoLoaded() function in ReactExoPlayerView.java when onPlayerStateChanged() is called with Player.STATE_READY.
private void videoLoaded() {
        if (loadVideoStarted) {
            loadVideoStarted = false;
            setSelectedAudioTrack(audioTrackType, audioTrackValue);
            setSelectedVideoTrack(videoTrackType, videoTrackValue); // <--- this creates a default selectionOverride
            setSelectedTextTrack(textTrackType, textTrackValue);
            Format videoFormat = player.getVideoFormat();
            int width = videoFormat != null ? videoFormat.width : 0;
            int height = videoFormat != null ? videoFormat.height : 0;
            String trackId = videoFormat != null ? videoFormat.id : "-1";
            eventEmitter.load(player.getDuration(), player.getCurrentPosition(), width, height,
                    getAudioTrackInfo(), getTextTrackInfo(), getVideoTrackInfo(), trackId);
        }
    }

The setSelectedVideoTrack() called inside videoLoaded will lead to Exoplayer creating default selectionOverride which includes all tracks, making all of them available for ABR when we really only want those tracks that meets the MaxBitRate set. Every subsequent call to check track selection will use the overridden tracks instead.
If videoLoaded() is required, then perhaps another way around this is to offer user a means to configure the param forceHighestSupportedBitrate, which will then give the expected behaviour as discussed via this issue in Exoplayer official thread.

can you try to add this line in videoLoaded, just after setSelectedVideoTrack(videoTrackType, videoTrackValue);:
                trackSelector.setParameters(trackSelector.buildUponParameters()
                        .setMaxVideoBitrate(maxBitRate == 0 ? Integer.MAX_VALUE : maxBitRate));

Just as a workaournd ...

@freeboub I tried out your suggestion, it does not work. The root cause is because of setSelectedVideoTrack(videoTrackType, videoTrackValue) being called with videoTrackType being null. See the images below as reference:

Because of that the list of all the tracks is being generated and overridden into the trackSelector regardless of the max bitrate set.
This however works:
	private void videoLoaded() {
		if (loadVideoStarted) {
			loadVideoStarted = false;
			if (audioTrackType != null) {
				setSelectedAudioTrack(audioTrackType, audioTrackValue);
			}
			if (videoTrackType != null) {
				setSelectedVideoTrack(videoTrackType, videoTrackValue);
			}
			if (textTrackType != null) {
				setSelectedTextTrack(textTrackType, textTrackValue);
			}

It does not make sense to update the track selections if the type is not available anyway. What do you think?
I'd be happy to help get a PR in if you think this is acceptable.


Add a .usage property on LLM object

Add a .usage property on LLM object allowing tracking of token/sec consuption and Amount accross all call for OpenAI and Anthropic.
Also update the LLM module doc to reflect the change

@hexapode Great idea, but how do we keep this in sync with the price changes?

@marcusschiesser: We have to manually check? No better idea for now / no provider expose a pricing API?

@hexapode Great idea, but how do we keep this in sync with the price changes?

@marcusschiesser: We have to manually check? No better idea for now / no provider expose a pricing API?

@hexapode I think for a start we could just track the usage (i.e. tokens and compute seconds) and not the costs. That's still valuable and if needed a user could calculate the costs - e.g. you could add an example computing the costs in examples/

Agreed, we can just return the total tokens used, the price isn't trustable and we can't let users think that's the current real price
bump @hexapode if you have any plans for it, when I have free time can go with it as well

TODOS:

remove cost from usage (as the price is not stable)
add example (same as in docs)

I will try to use AsyncLocalStorage on this

I think the ideal API would be
const usage = new Usage();
const llm = new OpenAI();
usage.track(llm)
// ...
console.log(usage.cost) // in dollar

@himself65, your API looks great!
We probably don't need to support reusing Usage objects between LLMs, so you can even simplify it to:
const llm = new OpenAI();
const openAIUsage = new Usage(llm);
// ...
console.log(usage.tokens)

{
	const newLLM = new AnotherAI();
        const anotherAIUsage = new Usage(newLLM);
}

Btw: I don't think we should start with the costs, see https://github.com/run-llama/LlamaIndexTS/pull/270#issuecomment-1867576025

closing as you should implement this in user land


feed: remove trailing / from base URL

This way, one can use "/" as base URL. This is only valid if we are
sure that URI should always have a leading "/". Is that the case?
Fix #437.

What cases did you test?  What external settings (e.g. nginx setup) are assumed?  What are you assuming about configuration file settings?


Generated models don't support wrapped XML arrays properly when the media type is application/xml

We are using a swagger model in which the produced and consumed media type for all operations is "application/xml". The model contains "wrapped" XML arrays, for example:
files:
  type: array
  items:
    $ref: "#/definitions/File"
  xml:
    namespace: http://www.sap.com/lmsl/slp
    wrapped: true

Currently, array types are always generated simply as arrays, e.g. type Files []*File. Instead, if xml.wrapped is true, they should be generated as structs containing arrays. There should also be a field of type xml.Name that contains the namespace specified in xml.namespace and the correct XML element name (see #354).
type Files struct {
    XMLName xml.Name `xml:"http://www.sap.com/lmsl/slp files"`
    Files   []*File  `xml:"File,omitempty"`
}

Consequently in the Validate function, m.Files should be used instead of m to refer to the array.
Similarly, arrays within object types are also always generated simply as arrays, e.g. Parameters []*Parameter. Instead, if xml.wrapped is true, they should also be generated as structs containing arrays, for example:
type ProcessParameters struct {
    Parameters []*Parameter `xml:"Parameter,omitempty"`
}

type Process struct {
...
  Parameters ProcessParameters `xml:"parameters,omitempty"`
}

I believe in this case it's better to generate a named struct type instead of anonymous one, as the corresponding field is then much easier to initialize.

parent: #183

We're using both JSON and XML.
I like this approach rather than creating type StuffThings []StuffThingor something like that when wrapped=true.
type Stuff struct {
    XMLName xml.Name `json:"-" xml:"http://www.sap.com/lmsl/slp tuple"`
    Name string `json:"name"
    StuffThings []StuffThing `json:"stuffThings,omitempty"    xml:"StuffThings>StuffThing,omitempty"`
}


Terminate DBeaver gracefully after starting updater

We've implemented automatic updates in #6558, but the termination routine may lead to the workbench corruption.

Please make sure that installer asks user to close all unsaved data.

The installer doesn't ask it and changes are not saved (tested on Mac)

veirified on Mac and Win10. Separate ticket is created https://github.com/dbeaver/dbeaver/issues/11859


Modus Data Table - Row action menu offset when page has scrolled

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have read the contributing guidelines

Describe the issue
When a page containing a data table has scrolled down, the row action menu no longer appears next to the button. In the worst cases, the menu no longer appears on the page.

I'm happy to investigate a fix for this issue as I think I know what's causing the issue.
Reduced test cases
No response
What operating system(s) are you seeing the problem on?
No response
What browser(s) are you seeing the problem on?
No response
What is the issue regarding ?
@trimble-oss/modus-web-components
What version of npm package are you using ?
No response
Priority
Low
What product/project are you using Modus Components for ?
Viewpoint For Projects [Trimble Connect integration]
What is your team/division name ?
Viewpoint
Are you willing to contribute ?
Yes
Are you using Modus Web Components in production ?
Yes, I'm happy to walk through our implementation if interested.

@CCurryViewpoint PR approved and merged 👍🏼 Please expect the fix in the upcoming release, or let us know if you need it urgently.
cc @coliff


Adapter is crashing without any presets defined

If there are no presets defined (usually done via SoundTouch app on Android or IOS), the adapter crashes during startup.

fixed with 0.1.7
different preset handling for no presets, one preset and more presets defined


When doing QueryProxy queries on models which are subclasses...

specify all labels in the MATCH

Coverage decreased (-7.58%) to 90.97% when pulling c0f6b307c197652d4300dda2ca9bbc434ae0a71f on various into 50cccf78cebf0abd3d8b0f44fecea8b8f09fb91d on master.

I was thinking about this last night and now I'm not so sure about it. When doing MATCH (u:User:GithubUser), wouldn't it match nodes with either label, not both labels?

Nope it will return nodes with both labels. The problem with such query is a bit performance when dealing with big databases, check section avoid the need to match on multiple labels here http://graphaware.com/neo4j/2015/01/16/neo4j-graph-model-design-labels-versus-indexed-properties.html

Yeah, I double checked just after posting and noticed that. My bad. The stuff mentioned in that link under "Use well named relationship types to avoid some use of labels" was what I was talking about the other day, @cheerfulstoic.

Gotcha.  It was actually @jexp who suggested I use multiple labels.  I actually re-worked neo4apis to fit that idea.  I wonder if making multiple labels more performant is on the radar

Also, it just occurred to me, does this apply to neo4j 2.2?  One min, off to check ;p

The performance impact is not so bad, it is cheaper to check for a label than for a property

Ah ha!  2.2 seem to help here!  I wrote a quick Ruby script (code here) to get the number of DB hits for each query and the label order doesn't seem to matter in 2.2 (not that User.login isn't indexed here):
neo4j 2.1.7
$ ruby profile_test.rb
MATCH (u:User) RETURN *: 8389
MATCH (u:User:GitHub) RETURN *: 8388
MATCH (u:User:StackOverflow) RETURN *: 8388
MATCH (u:User) WHERE u:GitHub RETURN *: 8388
MATCH (u:StackOverflow:User) RETURN *: 8646
MATCH (u:GitHub:User) RETURN *: 46574
MATCH (u:User) WHERE u.login = 'cheerfulstoic' RETURN *: 16776
MATCH (u:User:GitHub) WHERE u.login = 'cheerfulstoic' RETURN *: 25164

neo4j 2.2.0-M04
$ ruby profile_test.rb
MATCH (u:User) RETURN *: 8389
MATCH (u:User:GitHub) RETURN *: 8388
MATCH (u:User:StackOverflow) RETURN *: 8388
MATCH (u:User) WHERE u:GitHub RETURN *: 8388
MATCH (u:StackOverflow:User) RETURN *: 8388
MATCH (u:GitHub:User) RETURN *: 8388
MATCH (u:User) WHERE u.login = 'cheerfulstoic' RETURN *: 16776
MATCH (u:User:GitHub) WHERE u.login = 'cheerfulstoic' RETURN *: 25164

2.2. uses a cost based planner, so whichever label has the lower cardinality in the database (is more selective) is used first and then the second label is checked against it.

Coverage decreased (-0.08%) to 98.44% when pulling 64bcd3407a4aa8e542ce5f2bc58b944aa5f0805c on various into e74eb24f77d6b41e48cc478f0cc11622041fb50f on master.

Coverage decreased (-0.08%) to 98.44% when pulling 64bcd3407a4aa8e542ce5f2bc58b944aa5f0805c on various into e74eb24f77d6b41e48cc478f0cc11622041fb50f on master.

Coverage decreased (-0.53%) to 97.99% when pulling ea9a4b2fb5f6ef1b5860178005cc93abacb1c7a1 on various into e74eb24f77d6b41e48cc478f0cc11622041fb50f on master.

Coverage decreased (-0.53%) to 97.99% when pulling ea9a4b2fb5f6ef1b5860178005cc93abacb1c7a1 on various into e74eb24f77d6b41e48cc478f0cc11622041fb50f on master.

Coverage decreased (-0.53%) to 97.99% when pulling 476f2735b1186978e38693fb37663a71ecd57517 on various into e74eb24f77d6b41e48cc478f0cc11622041fb50f on master.

Coverage decreased (-0.08%) to 98.44% when pulling 7dedf4dfe2bc3907d13493059ce8ba37f3f83f6b on various into e74eb24f77d6b41e48cc478f0cc11622041fb50f on master.

Coverage decreased (-0.08%) to 98.44% when pulling 7dedf4dfe2bc3907d13493059ce8ba37f3f83f6b on various into e74eb24f77d6b41e48cc478f0cc11622041fb50f on master.

Coverage decreased (-0.08%) to 98.44% when pulling f219d0ada4cf58aeb75096cb9ba5daaa73c62698 on various into e74eb24f77d6b41e48cc478f0cc11622041fb50f on master.

Coverage decreased (-0.08%) to 98.44% when pulling f219d0ada4cf58aeb75096cb9ba5daaa73c62698 on various into e74eb24f77d6b41e48cc478f0cc11622041fb50f on master.


login page UI

https://www.figma.com/file/MxkFG5mlyPyX7njZdJLiss/(Not)-QEMS3?type=design&node-id=311-1643&mode=design&t=oU7crmY8jWEuXWF3-4

When I run npm start I see the following:
Module not found: Error: Can't resolve './login.module.css' in '/home/jerry/Development/qb-question-platform/client/src/components/login'
ERROR in ./src/components/login/login.js 4:0-40
Module not found: Error: Can't resolve './login.module.css' in '/home/jerry/Development/qb-question-platform/client/src/components/login'

ERROR in ./src/components/login/showoff.js 4:0-40
Module not found: Error: Can't resolve './login.module.css' in '/home/jerry/Development/qb-question-platform/client/src/components/login'

ERROR in ./src/pages/loginPage.js 6:0-58
Module not found: Error: Can't resolve '../components/login/login.module.css' in '/home/jerry/Development/qb-question-platform/client/src/pages'

Looks like some CSS is missing? Forgot to check it in?

Huh, yeah, weird -- should be in there now

We'll also want a mobile page design, current one doesn't port well to mobile. I'm thinking a gradient bar at the top with Quote in it, then the login functionality centered below that


Save state POST in HTTP API errors on non-integer etag

Dapr v0.9 throws exception when Save State request includes etag with a non-integer format (eg "v1"), even though proto defines this StateItem property as string.
// The exact ETag format is defined by the corresponding data store.
Etag string `protobuf:"bytes,3,opt,name=etag,proto3" json:"etag,omitempty"`

To reproduce it, submit a following request to v0.9 Dapr HTTP API
curl -v -X POST -H "Content-Type: application/json" \
    http://localhost:3500/v1.0/state/statestore \
    -d '[{ "key": "k1", "value": "hi", "etag": "v1"}]'

The resulting error includes the raw go error:
{"errorCode":"ERR_STATE_SAVE","message":"strconv.Atoi: parsing \"v1\": invalid syntax"}

Same post with the etag value bing "1" or any other string quoted integer work fine. I have not tried to test it in previous releases yet

Found the culprit. This is Redis state component trying to parse etags as integer
func (r *StateStore) parseETag(etag string) (int, error) {
	ver := 0
	var err error
	if etag != "" {
		ver, err = strconv.Atoi(etag)
		if err != nil {
			return -1, err
		}
	}
	return ver, nil
}

Found the culprit. This is Redis state component trying to parse etags as integer
func (r *StateStore) parseETag(etag string) (int, error) {
	ver := 0
	var err error
	if etag != "" {
		ver, err = strconv.Atoi(etag)
		if err != nil {
			return -1, err
		}
	}
	return ver, nil
}

This may be the intended behavior.
/cc Haishi2016

Looks like a few other state components implement similar logic (eg aerospike). This is user provided value on input so we should probably prevent the user from shooting themselves in the foot with a valid value which is adhering to our APIs (expects string). Changing that to integer will be breaking change but given that every REST and DB ETag definition I can find out there describes ETag as a hash, we propose refactoring the etag implementation in the stores that support it to a proper string.

@Haishi2016 what do you say?

Dapr doesn't define a ETag format, because that is subject to the underlying state store. A user is not supposed to supply an arbitrary ETags in requests - ETags are maintained by the state store and users can only play back ETags instead of creating new ones.
Because we can't dictate how ETag is implemented, we can't decide on a specific ETag format. Redis doesn't have built-in ETag so we are using a version number, which is integer on Redis.
I propose we keep the design and maybe clarify that further in docs.

That makes sense. @mchmarny your thoughts?

Yep, this totally makes sense from the implementation standpoint. Strings lowest common denominator. I'll updates the Dapr state store API docs to make this more explicit.


Better error message if required plugin is not installed

Overview
Deploying a contract without having the right plugins (like vyper) gives the error message AttributeError: 'ProjectManager' object has no attribute 'NFT'. The error is not clear enough for the user to know what the problem is to solve the error.
Specification
Instead of raising an attribute error, check to see if there is a file in the contracts/ directory with this name. If yes, check the extension. Then raise a better error like Missing compiler for '.vy' source extension
Dependencies
None

the error message has improved since the ticket was opened.  However, there is a source file named 'Test', did you mean to reference a contract name from this source file? Else, could it be from one of the missing compilers for extensions: .sol?

This seems to cover what is being asked for!


ERROR

Hi
"alexflipnote.js": "^1.2.8",
(node:9360) UnhandledPromiseRejectionWarning: Request failed. Status code: 400
(node:9360) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 3)

Update to latest version and read the docs

Update to latest version and read the docs


Edi User page allows one to edit the UserId, but doesn't reflect the change on next edit, then errors

Created a User, edited User, changed UserId (removed space), pressed OK, change was shown on Users page, pressed Edit, it displays the original User Id.

When you press save , you get this

If you close all the User pages and re-open, it is all OK

duplicate of #1414

re-opened as is slightly different to #1414

I wasn't able to replicate this issue after fixing gh-1414


Add a transient dispatch for SMerge mode

Motivation
When I resolve merge conflicts I'd like to use keybindings to pick correct hunks. One option is using ediff, another is to rely on a more lightweight SMerge. The latter is loaded by default when hitting RET on a file that is marked as  unmerged in a Magit status buffer. However, I don't do merge often enough, that merge related keybindings had a chance to engrave in my memory.
Solution
Add a transient that is showing bindings for commands from semrge-mode. I took an idea from some forum post a few years back (can't find a reference though). Have also seen similar solution being implemented in DOOM yet it uses hydra-mode and VI-style keybindings. I thought, I'd rather use transient to keep things consistent with Magit.
Comments

I've picked C-c C-s for save buffer, as I think that is usefull to have extra checkpoints when doing merge. This is not the regular C-x C-s, as it seems to conflict with built-in transient commands.

The revert & status reverts the unmerged file to the last saved checkpoint. I have been pondering about implementing reverting to the point that was when merge has started. But that seems to be more involved and I think for now an advise to abort the merge and start over should be enough. If there's a strong ask for that, I think I can try to do something in a following PR. Yet, there are some questions I don't seem to have a good answer at this point, so if you'd like to see such an extensions, please let me know your thoughts about::

How to capture such a state? I.e., when the file is not visited from magit-status
Where to keep it?

Memory? What if the diff is large?
File? How to manage the state, i.e., cleaning orphans etc.

I've made the dispatch to be displayed by default, since I found it extremely useful to do a quick merge. For more complicated things one can just hit E and that will start a full blown ediff session.

Just a minor detail: I think the ELisp convention for function named “some-prefix—do-this” (with double dash in the middle) is used for private functions. This is is just a workaround for ELisp not having support for proper namespaces: you prefix your function names with something hopefully unique. Sadly I did not follow that convention in the beginning, I should refactor my old modules some time.
But I see that you are using that convention for interactive functions, which are “public” and potentially invoke from M-x. Double check but I don’t think that is the recommended way.
Like I said, I’m nitpicking. Rest looks good. Thanks Przemek.

Just a minor detail: I think the ELisp convention for function named “some-prefix—do-this” (with double dash in the middle) is used for private functions. This is is just a workaround for ELisp not having support for proper namespaces: you prefix your function names with something hopefully unique. Sadly I did not follow that convention in the beginning, I should refactor my old modules some time.
But I see that you are using that convention for interactive functions, which are “public” and potentially invoke from M-x. Double check but I don’t think that is the recommended way.
Like I said, I’m nitpicking. Rest looks good. Thanks Przemek.


Multiple Markers Not Rendering

Hey there! I've been working on trying to get my markers appearing on the map but haven't had any luck as of yet.
Here's what my code is looking like currently:
import React, { Component } from 'react';

import { styles } from './styles.js';

import {
    AppRegistry,
    View,
    Text,
    Dimensions
} from 'react-native';

import MapView from 'react-native-maps';
import Geocoder from 'react-native-geocoder';

// Accessed from our own REST API in the future
const addressList = [
    '2101 Sutter St. San Francisco, California 94115',
    '2100 Sutter St, San Francisco, CA 94115',
    '2232 Bush St, San Francisco, CA 94115',
    '1911 Fillmore St, San Francisco, CA 94115'
];

const fakeData = [{
        title: 'Sweet Maple',
        id: 1,
        description: 'Sweet Maple is a laid-back and unpretentious neighborhood restaurant, coffeehouse and meeting place located in the Lower Pacific Heights neighborhood of San Francisco.',
        image: 'https://media-cdn.tripadvisor.com/media/photo-s/02/6b/a4/92/filename-photo-7-jpg.jpg',
        address: '2101 Sutter St, San Francisco, CA 94115',
        latlng: {
            latitude: 37.785727,
            longitude: -122.4350462,
            latitudeDelta: 0.015,
            longitudeDelta: 0.0121
        }
    },

    {
        title: 'Sweet Lime Thai Cuisine',
        id: 2,
        description: 'Thai Food has a lot of peanuts!',
        image: 'http://www.fillmorestreetsf.com/wp-content/blogs.dir/172/files/2012/02/customer2woman_eat_640.jpg',
        address: '2100 Sutter Street, San Francisco, CA 94115, USA',
        latlng: {
            latitude: 37.7860026,
            longitude: -122.4351187,
            latitudeDelta: 0.015,
            longitudeDelta: 0.0121
        }
    }
];

let locationList = [];
const LATITUDE_DELTA = 0.01;
const LONGITUDE_DELTA = 0.01;

export default class Map extends Component {
    // Convert addresses to coordinates
    componentWillMount() {
        // Add addresses to array
        for (let i = 0; i < addressList.length; i++) {
            Geocoder.geocodeAddress(addressList[i]).then(function(res) {
                // res is an Array of geocoding object
                locationList.push(res);
                // console.log(locationList);
            }).catch(function(err) {
                console.log(err);
            });
        }
    }

    render() {
        //    const { region } = this.props;
        return (
            <View style = {styles.container}>
        <MapView
          style={styles.map}
          region={{
            latitude: 37.78825,
            longitude: -122.4324,
            latitudeDelta: 0.015,
            longitudeDelta: 0.0121,
          }}
          onRegionChange={this.onRegionChange}
        />
        {
        fakeData.map(function(marker) {
           return <MapView.Marker
                coordinate={{latitude: marker.latlng.latitude, longitude: marker.latlng.longitude}}
                title={marker.title}
                description={marker.description}
                key={marker.id}
            />
        })
        }
        </View>
        )
    };
}

AppRegistry.registerComponent('lighthouse', () => Map);

Is there anything that I might be missing?

Please make a clonable project, so we can help you.
It's difficult to read a non-obvious error here in your post.
You can try forking https://github.com/alvelig/react-native-maps to modify to your needs.

closing as per the new rules of following the template


Add peerDependencies

This will warn if a user of this module updates this module without updating the needed @opentelemetry/* modules to a compatible version, which can otherwise be easily missed

Hey @voxpelli, thanks for the PR!
This is a bit of a tricky situation. There are a lot of OpenTelemetry packages that rely on specific versions of @opentelemetry/api. When the API version used by the end user is not compatible with a package's version, that package receives a no-op implementation of the API (source). Unfortunately this happens silently, which can make it easy to miss.
While the peer dependencies added in this PR can be used to configure @opentelemetry/api, they are not hard dependencies of @autotelic/fastify-opentelemetry. We'd be listing modules that we aren't actually dependent on as peer dependencies in order to provide a warning message - which could very well be helpful. However, it isn't really this modules responsibility to warn about dependencies of other modules. The best place to source these warnings would probably be in @opentelemetry/api - when they make the version compatibility check (here).

Are there any changes we could make to the readme that would improve awareness of potential compatibility issues? We recently added an OpenTelemetry Compatibility section, but it probably could use some improvement.
We're always open to and very much appreciate input, so please let us know! 😄

Sorry for being a bit slow in responding @HW13, got quite a lot to do this week.
I don't think peerDependencies needs to be limited to hard dependencies, as long as it's modules that this module makes no sense to use without then it would be quite helpful to have them there?
If one wants to make them optional, then one can use peerDependenciesMeta: https://medium.com/@noamgjacobsonknzi/what-is-peerdependenciesmeta-acea887c32dd

However, it isn't really this modules responsibility to warn about dependencies of other modules. The best place to source these warnings would probably be in @opentelemetry/api

Well, this module is the one depending on @opentelemetry/api, not them depending on you: https://github.com/autotelic/fastify-opentelemetry/blob/cefbba112ff92a97810d9f8fe708e4702c5245ab/package.json#L46
It would be impossible for @opentelemetry/api to warn at install time, the only one that can do that is this module, and warning on runtime isn't really helpful and doesn't really enable any tools to be able to derive what's needed from a standard field like peerDependencies, eg. running https://github.com/christopherthielen/check-peer-dependencies on CI to get feedback on whether a Dependabot or similar is enough or not.
Right now I guess a quick merge of a Dependabot update of this module will just disable the logging and emit a run time warning then? That's less than ideal to me. I want the warning install time.

Are there any changes we could make to the readme that would improve awareness of potential compatibility issues?

If anything it would have to be in release notes that it's highlighted, not the readme.

Hey @voxpelli, thanks for the feedback.

I don't think peerDependencies needs to be limited to hard dependencies, as long as it's modules that this module makes no sense to use without then it would be quite helpful to have them there?

While most people will configure an SDK with the help of @opentelemetry/core and @opentelemetry/tracing, it is still possible to write custom implementations that only depend on @opentelemetry/api. We don't want to start assuming or dictating how devs will or will not configure their OpenTelemetry SDK.

If one wants to make them optional, then one can use peerDependenciesMeta: https://medium.com/@noamgjacobsonknzi/what-is-peerdependenciesmeta-acea887c32dd

peerDependenciesMeta is definitely a potential solution - although I find that article a little confusing (neither of the dependencies in peerDependenciesMeta are actually in peerDependencies 🤔 ). After a bit of digging I did find some documentation hidden away in the npm v7 docs -> https://docs.npmjs.com/cli/v7/configuring-npm/package-json#peerdependenciesmeta - interesting stuff.

Well, this module is the one depending on @opentelemetry/api, not them depending on you

Yes, this module depends on a specific version of @opentelemetry/api. @opentelemetry/core also depends on a specific version of @opentelemetry/api. The source of truth is the end user's version of @opentelemetry/api, that is what decides what is and isn't compatible - and subsequently replaces incompatible implementations with no op implementations. While it may not be helpful to your specific use case, it would make sense to centralize warnings in the location of this "no op swap" (seems like it could be helpful in local development).

Right now I guess a quick merge of a Dependabot update of this module will just disable the logging and emit a run time warning then? That's less than ideal to me. I want the warning install time.

Like OpenTelemetry, this module is using initial development versioning. Minor version bumps will most likely include breaking changes. It would be best not to implement these breaking updates via Dependabot PR. Once OpenTelemetry hits 1.0.0, this module will follow and many of these compatibility issues will subside - as we can then rely on a defined public API and the versioning that comes with it.

If anything it would have to be in release notes that it's highlighted, not the readme.

Going forward we'll be sure to include notes with our releases 👍
Thanks again for the input, peerDependenciesMeta looks promising. I'm currently on holiday 🎄 and would like to hold off on any decisions until I'm back and able discuss with my team. Happy holidays! ☃


Presented view can be sized automatically

Pass UILayoutFittingCompressedSize or UILayoutFittingExpandedSize into contentViewSize, and the view will be automatically resized via auto-layout.
The example app was updated to include this new feature. The README sample code was also updated to mention this feature.

Please do not merge yet, fixing some issues.

This is now ready to merge.

Looks good thanks!


Spyder unable to open from Anaconda CMD with latest conda updates

When opening spyder from the anaconda cmd prompt, the following error loops and the Kernel for python does not open with Spyder.  This started with the latest updates from conda.
js: Not allowed to load local resource: file:///C:/Users/"username"/Continuum/anaconda3/lib/site-packages/spyder/utils/help/static/css/default.css

Thank you, Carlos.  That did it.  Do you happen to know why ipykernel 4.9.0 isn't compatible with spyder right now?

I really don't know. It has an error that only affects Windows.

I did it and corrected the problem.
What I have to say is that the character "-" in the path  /Anaconda3/lib/site-packages/spyder/...  is not recognized by the windows explorer. I see that anaconda python can see that character. It is good to search this issue.
The problem was only when I doubled clicked a  .py file from window explorer to be opened in spyder.


moved to custom AB getter

The speclite library was not doing the units conversions carefully which could result in magnitudes being improperly normalized. However, they utilities they use for these conversions are exposed and I have been able to do the calculations myself.

Codecov Report

Merging #190 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
- Coverage   74.78%   74.74%   -0.05%
==========================================
  Files         126      126
  Lines       13251    13256       +5
==========================================
- Hits         9910     9908       -2
- Misses       3341     3348       +7

Ok, I fixed up the test. Now the optical photometry is giving proper results. I will stick with speclite for the moment.


[Bug]: upgrading to version 7.34.0 breaks eslint.

Is there an existing issue for this?

[X] I have searched the existing issues and my issue is unique
[X] My issue appears in the command-line and not only in the text editor

Description Overview

Eslint does not work with  "eslint-plugin-react": "7.34.0", and yarn
There are no eslint warnings and files do not get parsed.
steps to fix

Needed to revert to  "eslint-plugin-react": "7.33.2",
delete yarn.lock
re-install node-modules

package.json dependencies (working): set to "eslint-plugin-react": "7.34.0",  and run yarn to break.
  "dependencies": {
    "@capacitor/android": "5.7.2",
    "@capacitor/core": "^5.7.2",
    "@capacitor/ios": "^5.7.2",
    "@fontsource-variable/alegreya": "^5.0.13",
    "@fontsource/nova-cut": "^5.0.8",
    "@types/node": "^20.11.25",
    "@types/react": "^18.2.64",
    "@types/react-dom": "^18.2.21",
    "@vercel/analytics": "^1.2.2",
    "@vitejs/plugin-react": "^4.2.1",
    "crypto-js": "^4.2.0",
    "electron-log": "^5.1.1",
    "react": "^18.2.0",
    "react-dom": "^18.2.0",
    "react-speech-kit": "^3.0.1",
    "react-toastify": "^10.0.4",
    "react-use-audio-player": "^2.2.0",
    "steamworks.js": "^0.3.1",
    "typescript": "^5.4.2",
    "vite": "^5.1.5",
    "vite-tsconfig-paths": "^4.3.1",
    "web-vitals": "^3.5.2"
  },
  "devDependencies": {
    "@capacitor/assets": "^3.0.4",
    "@capacitor/cli": "^5.7.2",
    "babel-eslint": "^10.1.0",
    "cross-env": "^7.0.3",
    "electron": "^29.1.1",
    "electron-packager": "^17.1.2",
    "esbuild": "^0.20.1",
    "eslint": "^8.57.0",
    "eslint-config-prettier": "^9.1.0",
    "eslint-config-react-app": "^7.0.1",
    "eslint-config-standard": "^17.1.0",
    "eslint-plugin-import": "^2.29.1",
    "eslint-plugin-prettier": "^5.1.3",
    "eslint-plugin-promise": "^6.1.1",
    "eslint-plugin-react": "^7.33.2",
    "prettier": "3.2.5"
  }

Expected Behavior

Eslint works with  "eslint-plugin-react": "7.34.0", and yarn
Files get parsed, eslint errors show in vscode.
eslint-plugin-react version
7.34.0
eslint version
8.57.0
node version
18.19.0

Closing:
The issue was I was using out of date parser.
needed to replace
 "babel-eslint": "^10.1.0",
with
  "@babel/eslint-parser": "^7.23.10",


The format of the master seed is not following BIP39

According to BIP39 the last word should be the checksum, but you ignore this in the code.
https://github.com/bitcoin/bips/blob/master/bip-0039.mediawiki
https://iancoleman.io/bip39/
Also, since there are no checksum it is very easy to write wrong mnemonic words when doing restore. Actually a one word mnemonic seed is accepted, and it most definitely should not.
However, like your project!

Thank you for the suggestion. We plan to introduce the option to choose BIP39 in future releases of the application. Regarding the lack of a checksum in our seed, look at our backups. Almost all are based on encrypted seed and are presented as QR code. This excludes the possibility of a mistake.
Greetings!

Good that you plan to introduce BIP39! Without it it's hard to verify that the HD addresses are valid (with tools like https://iancoleman.io/bip39/ ) and also very hard to use some other wallet to access the coins in case thats needed.
The other backups you have are good, but advanced users should be allowed to verify and restore using BIP39 mnemonic words.


refresh device list

actual device descriptor did not change

@trapacska

Please update the device list ind the step.yml for the device input.

The devices did not change, only some ABI versions, that is why there is no diff in the descriptor.


Fix deleted resources permission handling

Deleted resources permission handling
Changes to the resource deletion concept had the unintended effect of removing deleted resources from permission handling. As a result, deleted resources could no longer be requested by users at all.
This PR fixes two bugs directly involved in the deletion handling process and resolves #142.

Good work, lgtm! :handshake:


How to export excel sheet with full size of hearders?

I'm using aoa to export data to excel sheet.
    const ws: XLSX.WorkSheet = XLSX.utils.aoa_to_sheet(this.eportedData);
    const wb: XLSX.WorkBook = XLSX.utils.book_new();
    XLSX.utils.book_append_sheet(wb, ws, 'Sheet1');

I want the headers that are in the excel sheet take the full size of the header name, no need for the user to resize them manually.

Unfortunately Excel exposes no option to mark columns to automatically resize.  You can get a reasonable estimate by manually walking the cells of each column, figuring out the max number of characters in a cell, and setting the column width object's wch property
In our Pro builds, auto widths are determined by inspecting individual cell text and fonts to calculate what the correct width would be.