Add s3 connection TTL config property

Can one of the admins verify this patch?

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/11162/
Test PASSed.

Merged build finished. Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/11191/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/11192/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/11217/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/11234/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/11235/
Test PASSed.

alluxio-bot, merge this please


Update README.md to include correct API authorization for organizations

Obvious fix. Without the organization parameter, the authorization fails.

Hey, there's no need to specify an organization, please see the docs here
Are you having any problem when authenticating your user?
BR.


Grammar

Describe the proposed changes

Project version

Related issue

Related issue or PR in another project

Please take a look

Better grammar.

Thanks, @stewx :)


macOS compilation fix

Another macOS compilation fix.
Apparently, the net API is somewhat different on macOS. So, we cannot use some of the features. However, your lib still does the trick for me.

It's merged now. Thanks for the fix.


Some issues with mod

I found few bugs

I cant exit G3DPlanetLayer with esc button for no reason
When I have complete level I didnt see something like "Level completed" or funny message from robtop, instead i got "Level verified" and possibily to editor of the level

The no pressing escape is intentional and I might change that in the future
for the second issue it is fixed in the developmental release
https://github.com/adafcaefc/Geome3Dash/releases/tag/develop


Fix the WSL/Ubuntu/GCC-9 TPL builds

For some reason when updating spack, the -ldl -lz link flags got moved to the front of the link line for netcdf. I don't like this fix, so I am open to any other suggestions.

Should we merge this as a stopgap fix until https://github.com/LLNL/serac/issues/324 gets resolved?

Should we merge this as a stopgap fix until https://github.com/LLNL/serac/issues/324 gets resolved?

Should we merge this as a stopgap fix until #324 gets resolved?

Yea I'll try to get to it this week.

Should we merge this as a stopgap fix until #324 gets resolved?

Yea I'll try to get to it this week.

@joshessman-llnl could you take a look at this?

@joshessman-llnl could you take a look at this?

Codecov Report

Merging #315 (b0cb34d) into develop (2892b67) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #315      +/-   ##
===========================================
- Coverage    90.77%   90.72%   -0.06%
===========================================
  Files           43       43
  Lines         1658     1649       -9
===========================================
- Hits          1505     1496       -9
  Misses         153      153

Impacted Files
Coverage Δ

src/serac/infrastructure/cli.cpp
95.83% <0.00%> (-0.84%)
:arrow_down:

src/drivers/serac.cpp
97.67% <0.00%> (-0.16%)
:arrow_down:

src/serac/numerics/mesh_utils.hpp
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2892b67...ee309b8. Read the comment docs.

Codecov Report

Merging #315 (b0cb34d) into develop (2892b67) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #315      +/-   ##
===========================================
- Coverage    90.77%   90.72%   -0.06%
===========================================
  Files           43       43
  Lines         1658     1649       -9
===========================================
- Hits          1505     1496       -9
  Misses         153      153

Impacted Files
Coverage Δ

src/serac/infrastructure/cli.cpp
95.83% <0.00%> (-0.84%)
:arrow_down:

src/drivers/serac.cpp
97.67% <0.00%> (-0.16%)
:arrow_down:

src/serac/numerics/mesh_utils.hpp
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2892b67...ee309b8. Read the comment docs.

LGTM

LGTM


Policy Update

Policy Updates

@isMeyer Please fix indentation with spaces

@isMeyer Please update, or I will close as stale.


"remove unused packages" is not showing in visual studio <2019 16.11.23>

even by right clicking on project name or dependencies node in Solution Explorer in visual studio 2019 pro <16.11.23>
"remove unused References" is not showing  !
i also checked ( Tools -> Options -> Text Editor -> c# -> Advanced -> [Show "Remove Unused References .... "] )
and its enabled.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 83570d18-e0b6-0097-6966-1ffd6856955e
Version Independent ID: 2a191933-b3ab-60ae-3e31-f1fb129ceefa
Content: Remove unused references - Visual Studio (Windows)
Content Source: docs/ide/reference/remove-unused-references.md
Product: visual-studio-windows
Technology: vs-ide-general
GitHub Login: @mikadumont
Microsoft Alias: midumont

@nasusonetrick -- thank you for your feedback.  This appears to be a product issue, rather than a documentation issue.  Please add it here:

Report product issues to us via the Report a Problem tool that appears both in the Visual Studio Installer and in the Visual Studio IDE.
Suggest a feature, track product issues, and find answers in the Visual Studio Developer Community.

Also, consider these resources:

Visual Studio on Microsoft Q&A
Visual Studio MSDN Forum
Stack Overflow
Reddit

I am closing this issue now.  You are welcome to @ mention me for any followup.  We hope to hear from you again.


AzureKeyVault@1 secrets filter takes a string, not an enum.

See https://github.com/microsoft/azure-pipelines-tasks/blob/1ce4d23fadc246ec4474baa1580e7c58ce35077c/Tasks/AzureKeyVaultV1/task.json#L46
Using enum causes Visual Studio Code, using the Azure Pipelines plugin, to raise a syntax error on JSON using this task in a pipeline.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: a30001539 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Schema file is generated automatically from the server, and we don't take manual changes.


Revert "Testing action trigger "

Reverts testsigmahq/testsigma-addons#8

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Exposed Spotify Client ID/Secret in config.yml

I tried to imitate the way youtube-api-key was setup.
I needed to create set_client_credentials() in spotify_tools.py else it tried to access const.args before it was initialized.

Also I apologize for the large number of commits, I forgot to rebase my fork before pushing again :)

oops, seems like creating set_client_credentials() was a bad idea.

So I removed set_client_credentials() and I reverted the changes to tests applied in the Workaround to make tests pass commit and the tests pass now.

Yes I could definitely give this a go, I'll let you know if I need any more clarification :)

@ritiek So I've created a SpotifyAuthorize class that initializes a class variable self.spotify.
I've noticed, functions such as match_youtube_and_metadata (youtube_tools.py#L52-55) will be making use of the SpotifyAuthorize class, I'm unsure whether you'd prefer if a SpotifyAuthorize instance was passed in as a parameter, because I initialize an instance in spotdl.py; or if functions like these should initialize their own instance of SpotifyAuthorize and use that.

functions like these should initialize their own instance of SpotifyAuthorize and use that.

This should be better IMO.


[Question]How to training on different node with specific gpu in each node

Hi, I try to training the BingBertSquad on 2 nodes (each has 4 gpus) with specific gpus (2 gpus, another 2 gpus are occupied by others), and my hostfile's content is:
work1 slots=2
work2 slots=2
and part of my launch script on one node is
deepspeed --hostfile hostfile --include=work1:2,3 training.py .... ,
but it reports the error
No slot 2 specificied on host work1.
what is correct way to train in this situation?

Let your hostfile correctly reflect the hardware, then use the include flag to restrict gpus to use.
 work1 slots=4
 work2 slots=4


Benchmark a "fast" query to compare flux vs influxql [Backport 1.8]

Backport the fix to #22147 to the 1.8 branch

Closed by #22215


Feature/add screening tag

Type of Change

Build Scripts:
Tool Source:
Something else:

What issue does this relate to?

What should this PR do?
Card - https://flow.reg.ru/space/26/card/122672
What are the acceptance criteria?

As mentioned in https://github.com/digitalocean/nginxconfig.io/pull/341#issuecomment-1092809359, I imagine you want to be opening this PR against reg.ru's upstream fork, not this repo. We have solved the XSS issues in PRs after the point y'all forked, without needing to strip out </> from every input.


Browser doesn't open on WSL2

Hi, I came to this library when debugging why cargo doc --open doesn't actually open the web browser on Windows Subsystem for Linux 2 (WSL2). I've reproduced the issue by doing the following in this repository:

Get a path to a html file . I use the html file generated by cargo doc
cargo run <path_to_html>
The application prints "Opened path successfully." but nothing happens.

Manually running the xdg-open bundled in this repo gives:
❯ opener/src/xdg-open /home/ryan/Programming/External/opener/target/doc/opener/index.html
Start : This command cannot be run due to the error: The system cannot find the file specified.
At line:1 char:1
+ Start "/home/ryan/Programming/External/opener/target/doc/opener/index ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (:) [Start-Process], InvalidOperationException
    + FullyQualifiedErrorId : InvalidOperationException,Microsoft.PowerShell.Commands.StartProcessCommand

It looks like it might be invoking the windows start command somehow. Unsure what mechanism makes this happen.
The return code is 0, indicating a success, yet clearly the command failed.
I am on WSL2, and running Ubuntu 20.04. I do not know if the problem also occurs on WSL1 or not. Note that the BROWSER environment variable is empty.
The expected behavior would be to fail the command, since it does not complete successfully, or better yet, open the file in the windows web browser and translate the path.

From what I can see, the problem is that this crate is using Process::spawn to run the program. On top of that stdout for that program is set to Stdio::null(). The whole combination leads to the situation when the exit status would be ok even if the xdg-open script fails just because it was spawned successfully. This also leads to inability to run a text-mode browser under certain configurations, because it will have no tty to work with and will exit immediately.
To be completely correct it might be useful to change the script in such a way that it spawns GUI applications, runs CLI apps in foreground and exits if it is incapable of opening the provided path. And obviously use Process::output instead of Process::spawn. That's the rough idea.

This should be fixed with the 0.5 release.


Visual player bugs when there is an empty line with the same timestamp as the next line

Visual player bugs when there is an empty line with the same timestamp as the next line and the synced lyrics stop showing after that.

Simply changing the blank line timestamp to be the smallest amount off from the next line works fine. I think this is a bug with lrcget's visual display. Other platforms handle these lyrics fine.

P.S. Thank you for your work!


feat(http,validate): add create guild ban delete message seconds

Additionally deprecated delete message days related functionality.
Reference:https://github.com/discord/discord-api-docs/pull/5219
Closes: #1883

I think it would be better to remove delete message days and target next

I think it would be better to remove delete message days and target next

I actualy think the opposite, target main but make delete_message_days a stub that calls delete_message_seconds with the same argument * 86400


database/sql: maxBadConnRetries is hard coded but not configurable

In database/sql,  maxBadConnRetries is hard coded but not configurable.
Sometimes I do not want it to retry when connect fails, or more retry times is required.

Timed out. Closing this.


Address encoding problem in 3.0

Examples:

nominatim/reverse.php?format=json⪫=-20.2453300&lon=-70.0942000&zoom=18&addressdetails=1
nominatim/reverse.php?format=json⪫=49.607605&lon=8.517553&zoom=18&addressdetails=1

It happens with all 3 reverse lookups. They return everything correct, so I would guess error is in the code (would help, but I don't trust my java knowledge, which is barely above 0)

I guess the problem is when the data is written into the database. What database are you using?

Tried default and MySQL. Utf8_general_ci on MySQL

Make sure you have following parameters in your database.url parameter:
useUnicode=yes
characterEncoding=UTF-8

I've both of them, and even tried refreshing page.
Not really sure what the issue could be :/

Is the encoding incorrect in the web interface or in the database as well?

Both of them.

Try to use utf8mb4 encoding in MySQL instead of simply utf8.


Create an effective .npmignore

Hey,
I just installed UI Router thru NPM, and it gave me a heavy (6.7 MB), bloated package:

When I opened the .npmignore, I found that its contents aren't effective at all:
# master only
build
site

# common
node_modules
bower_components
.DS_Store
*~

# webstorm files
.idea

I suggest adding at least the following directories to the list:

config
lib
sample
test

I wanted to send a PR with this modifications, but I couldn't find anywhere in this repo a file called .npmignore.
Guys, can we do this? It will make everyone's CI builds faster!

thanks for the heads up

@gustavohenke why don't you submit a PR and @christopherthielen will review it so that they can work on other more complicated things for 0.2.14?

@ilanbiala Yes sir! See #1701

Could you please include bower_components folder in .npmignore? I had install today and it comes with almost 80 MB in DefinitelyTyped folder

@americoneto1 Sure. It'll probably happen faster if you submit a PR. :smile:

Nice! I'll do it!


Questions about IdleStateHandler member variables

IdleStateHandler's lastReadTime and lastWriteTime should be volatile
Because IdleStateHandler cannot guarantee that it will work in the event loop

Why should you attach it to another executor?

Why should you attach it to another executor?

Could there be such a misuse?
channelPipeline.addLast(executorGroup, new IdleStateHandler(readIdleTimeOut, writeIdleTimeOut, allIdleTimeOut, TimeUnit.SECONDS));


Stop OC from executing getInfoData in its worker thread

This should fix https://github.com/GTNewHorizons/GT-New-Horizons-Modpack/issues/13528 and https://github.com/GTNewHorizons/GT-New-Horizons-Modpack/issues/13527
This means that people using this API will need to wait up to one tick for it to return. The alternative, it seems, is checking every implementation of getInfoData for any race conditions.
This was mentioned in the context of NIDAS, and I don't really know much about OC. @S4mpsa will this cause anything to explode (literally or otherwise) on your end?

@MeiTianyou i merge this and we test it in a new dev or nightly


mkpr

Applied mkpr on .github/workflows/auto_approve.yml
./merge.sh

Codecov Report

Merging #755 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #755   +/-   ##
=======================================
  Coverage   91.03%   91.03%
=======================================
  Files          12       12
  Lines         792      792
  Branches       94       94
=======================================
  Hits          721      721
  Misses         71       71

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba38978...fd003d7. Read the comment docs.


Snippets update.

Hi - I noticed the access modifier in the method snippet wasn't a field, so that has been rectified in this PR. I've also added a snippet for namespace. Thanks.

Hi @kungfusheep, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@kungfusheep, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

Thanks for the contribution @kungfusheep . Merged!


S3 websiteConfiguration is not working

Slack thread: https://crossplane.slack.com/archives/CEG3T90A1/p1645139809042389
What happened?
When we are creating the s3 bucket with websiteConfiguration, bucket is being created in the console without website config and the bucket is in NOT READY status on the cluster stating cannot create or update: api error MalformedXML: The XML you provided was not well-formed or did not validate against our published schema.
We are trying to convert s3 bucket from cloudformation to crossplane.
CloudFormation
      WebsiteConfiguration:
        ErrorDocument: bb-test-docs/error.html
        IndexDocument: index.html

Crossplane
    websiteConfiguration:
      errorDocument:
        key: 'bb-test-docs/error.html'
      indexDocument:
        suffix: 'index.html'

How can we reproduce it?
Create a bucket with the following
apiVersion: s3.aws.crossplane.io/v1beta1
kind: Bucket
metadata:
  name: bb-test-bucket-temp
spec:
  forProvider:
    acl: private
    locationConstraint: us-west-2
    publicAccessBlockConfiguration:
      blockPublicAcls: true
      blockPublicPolicy: true
      ignorePublicAcls: true
      restrictPublicBuckets: true
    tagging:
      tagSet:
        - key: Application
          value: value
    websiteConfiguration:
      errorDocument:
       key: bb-test-docs/error.html
      indexDocument:
       suffix: index.html
  providerConfigRef:
    name: crossplane-provider-config

Bucket is in NOT READY status
NAME                           READY   SYNCED   AGE
bb-test-bucket-temp             False   False   7m8s

with Warning  CannotUpdateExternalResource  41s (x16 over 12m)  managed/bucket.s3.aws.crossplane.io  cannot create or update: api error MalformedXML: The XML you provided was not well-formed or did not validate against our published schema
What environment did it happen in?
Crossplane version:
DockerImage: v1.5.0

Fixed by #1156


[151527583] Remove 4.4, move to alpine image, and use oauth2_proxy 2.2.0

https://www.pivotaltracker.com/story/show/151527583
This is already been pushed up kibana-testing.  Please QA that app before approving this PR.  Once this merged to master, I will push it to kibana-testing.

@EmergentBehavior Cool, I'll merge this and then looking into the Bengal S3 tarball issue


fix old eval tasks order

as we  have lots of data evaluated on old version, better to follow the old order.


Add Cursor Tail Effector done ! #1173 ✅

Hello, PR
Add new Feature - #1173
Done -
https://github.com/user-attachments/assets/1be325aa-3241-4e2d-bd51-552743e68cd0

Type of PR

[ ] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Checklist:

[ ] I have made this change from my own.
[ ] I have taken help from some online resources.
[ ] My code follows the style guidelines of this project.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.
[ ] I have tested the changes thoroughly before submitting this pull request.
[ ] I have provided relevant issue numbers and screenshots after making the changes.

@PriyaGhosal merge my PR and add level 3
Thank You

@Subhajit-2023-44 Your pull request has been successfully merged! Don't stop here—continue contributing by addressing more issues and aiming to become a top contributor. Exclusive swag awaits for those who go the extra mile!
Great contribution ! 🎉


Lint with pre-commit

This PR proposes to

add a .pre-commit-config.yaml file to make it possible to use https://pre-commit.com/ to run the Ruff lint and format step (i.e. have everything checked and fixed at commit time (if so desired)).
for consistency's sake, switch CI to do that too using pre-commit/action.

on that note, it sets RUFF_OUTPUT_FORMAT to "github", so Ruff outputs warnings in a form that makes GitHub Actions print them quite prettily

add the basic pre-commit-hooks hooks to enforce some hygienic line-ending rules (and fixes the handful of issues).

This shouldn't affect regular development without pre-commit other than having to remember to keep the Ruff version in sync between the lint extra and the pre-commit config.

If this doesn't feel like a chaiNNer or Spandrel thing to do, that's fine too!

I personally don't like pre commit hooks, so I appreciate it that this one is optional.
The main issue I see with it, is that it's not really optional. You can just choose when to run it (before commit, after push (by CI)) and still have to follow all of its rules. This can actually make not using the pre commit hook less user-friendly since some of the options you enabled (e.g. end-of-file-fixer) seem to be designed for automated fixing and would just be annoying to deal with manually. I can just paste a ruff command into my terminal to fix formatting, but there's nothing for those extra pre commit rules.
So I'm not sure about this.

I personally don't like slow pre-commit hooks either

It's not just slow ones. I don't want my commits to fail, well, committing. I'd rather use IDE save actions to see what exactly is committed before committing.

That said, I can absolutely get rid of the extra rules and just keep Ruff in :)

Please do that. We can still re-add them later if need be.

Alright, with my mistake resolved, I think this is basically ready. Could you please resolve the conflict?
Also, we should probably document this in CONTRIBUTING.md.


[Manual Requests] Add OpenMoneyRequestsReportPage command

Details

Adding OpenMoneyRequestsReportPage read command call to pull transaction data. This is not used anywhere in the product yet.
Related Web-E PR https://github.com/Expensify/Web-Expensify/pull/36959
Fixed Issues

$ https://github.com/Expensify/Expensify/issues/270585
Tests

Manually call this Report.openMoneyRequestsReportPage with valid iouReportID
Verify you get the expected return onyx data
Thats transaction data keyed by transactionID in the transactions_ onyx collection key

[x] Verify that no errors appear in the JS console

Offline tests

N/A
QA Steps

N/A

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos
No visible changes in the app so nothing to show here.
Response from a command:
{
   "onyxData":[
      {
         "onyxMethod":"set",
         "key":"report_5265731642757761",
         "value":{
            "reportID":"5265731642757761",
            "type":"iou",
<EMAIL_ADDRESS><EMAIL_ADDRESS>            "currency":"CZK",
            "chatReportID":"5860324700845728",
            "state":"SUBMITTED",
            "cachedTotal":"(K\u010d392.05)",
            "total":39205,
            "stateNum":1,
            "submitterPayPalMeAddress":"",
            "hasOutstandingIOU":true
         }
      },
      {
         "onyxMethod":"mergecollection",
         "key":"transactions_",
         "value":{
            "transactions_5265731642757761":{
               "3601095477076285295":{
                  "amount":-1000,
                  "comment":{
                     "comment":"test"
                  },
                  "created":"2023-04-14 07:37:24",
                  "currency":"GBP",
                  "modifiedAmount":0,
                  "modifiedCreated":"",
                  "modifiedCurrency":"",
                  "transactionID":"3601095477076285295"
               },
               "6288687046925990472":{
                  "amount":10000,
                  "comment":{
                     "comment":""
                  },
                  "created":"2023-01-03 13:08:25",
                  "currency":"AED",
                  "modifiedAmount":0,
                  "modifiedCreated":"",
                  "modifiedCurrency":"",
                  "transactionID":"6288687046925990472"
               },
               "2060282402996207705":{
                  "amount":10000,
                  "comment":{
                     "comment":""
                  },
                  "created":"2023-01-03 13:08:22",
                  "currency":"CZK",
                  "modifiedAmount":0,
                  "modifiedCreated":"",
                  "modifiedCurrency":"",
                  "transactionID":"2060282402996207705"
               }
            }
         }
      }
   ],
   "jsonCode":200,
   "requestID":"uoUAKk"
}

Screenshot from db

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

I dont think this will require C+ review. Sorry made this ready for review, but flying today
I will have to test this yet.

@luacmartins Added screenshots of the tested command and the response, its looking good.

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

👀  at this

Thinking through the above comment some more...
Tracking the loading state of something like a blocking "read" command could maybe look different if we can reimagine how it might work with hooks.
const {loading, errors} = useAction(Report.openMoneyRequestsReportPage)

not really sure how that implementation would work, but just thinking out loud on it. I find it slightly confusing to connect which actions are triggering which loading states or errors sometimes.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.1-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.1-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.1-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Firewarrior

Firewarrior is still not worth the money
Try to change cooldown of sleight of fist from 4 to 3
P.S. Rebalancing of thunder units was perfect

done


Added trino creds

Description

Added keys/values to connect to our instance of Trino.
Motivation and Context

How Has This Been Tested?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Enhancement (improves on existing behavior)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project. (Did you install and run the pre-commit hooks?)
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

:+1:


Set up Danger to run Rubocop and quality/language checks

The output and error messages are vastly improved over our current system, which requires reading the entire Travis CI log file.
http://danger.systems/

We should also move the quality specs & rubocop to a separate matrix entry, and consider using the danger-rubocop and danger-junit plugins

Also, this probably should wait until 2.0, since danger only supports Ruby 2+

@segiddins So if I would like to work on this, can I work on the 2.0 branch?

I would personally recommend waiting, as project infrastructure stuff will conflict horribly when we finally get around to merging 2-0-dev into master

There hasn't been much interest in this. Closing.


Cargo silently ignores patch crates with a missing feature.

Steps

Create a package my_package with a feature my_funky_feature:# my_package/Cargo.toml
[package]
name = "my_package
[features]
my_funky_feature = []

Create a copy of my_package  without the feature my_funky_feature:# my_package_copy/Cargo.toml
[package]
name = "my_package
[features]

Create yet another package my_bin, which depends on my_package, activates the feature my_funky_feature of it.# my_bin/Cargo.toml
[package]
name = "my_bin"
[dependencies]
my_package = { git = "github.com/aiofwiewof/vioe", features = ["my_funky_feature"] }

Set the copy of my_package which doesn't have my_funky_feature as patch for my_package.# my_bin/Cargo.toml
# [...]
[patch."github.com/aiofwiewof/vioe"]
my_package = { path = "../my_package_copy" }

Cargo silently uses the original my_package without warning.

Possible Solution(s)
Give a warning when a patch is ignored, because there is a missing feature.
Notes
Output of cargo version:
cargo 1.33.0-nightly (2cf1f5dda 2018-12-11)

Oh dear definitely sounds like a bug! I think we can probably turn this into a hard error

I was curious about this, but there is a part of the [patch] implementation that I don't understand. The entry gets stuck on the "unused" list.  What does "unused" mean, and why is it there?  Why would it allow unused patches?

The unused list is serialized into Cargo.lock to ensure that if a [patch] isn't actually used then every time you type cargo build we don't try to re-update the registry (by ensuring we lock it to something). It does make a little sense that this'd go on the unused list, and we could probably warn about that even though it's a possibly valid situation

So if a new version of a crate on crates.io has a missing feature, it is silently ignored, right?

I believe so.  The resolver is a bit of a mystery to me.

Oh thanks for digging in! I think this may also be conflating with https://github.com/rust-lang/cargo/issues/4678 which I've never really fully understood as an issue, but I know it's "lock file plus new patch sections equals weirdness".
I actually think it's relatively correct behavior for the resolver to skip this dependency, it definitely has logic to simply filter out candidates that are missing features. I think the no-lockfile scenario is exhibiting this behavior, where it's actually somewhat correct that we're simply skipping the candidate provided by [patch]. For the with-a-lockfile scenario that should have the same behavior as the no-lockfile scenario, but I suspect #4678 is thwarting it.
I think I agree with a warning here though! @ehuss the [patch] section is actually entirely hidden from the resolver (intentionally!) and it only shows up in the PackageRegistry type, which is sort of like semi-resolver but only part of it. I think in any case your conclusion about the difficulty of otherwise providing a targeted warning is correct that it will be difficult to do so.
In terms of issuing warnings, I would personally prefer to only issue a warning when [unused] is first emitted into the lock file. That way you won't get an un-suppressable warning on every single build, but rather just the first one that adds the unused section to the lock file.

So if a new version of a crate on crates.io has a missing feature, it is silently ignored, right?

Yes, removing a feature is a breaking change. Before #5000 this would lead to Cargos resolver erroring loudly. But, it was mostly getting triggered by the resolver doing things out of order and trying really old versions of dependencies. So we switched to just ignoring the versions that don't have the required feature. Like how we just ignore versions that don't match the version requirement. But it is not quite "silently", like all filters the resolver uses if we can not find any valid resolution we report an error message explaining what was skipt and why. As @ehuss described you get a good error message if you force the resolver to use the [patch] version with the missing feature but if the resolver can fix it for you (by using an older one on crates.io) then it just fixes it.
@alexcrichton What is the legitimate use of an unused [patch] section? Why is that use important enough to not just have to live with a warning?

AFAIK there's no legitimate use of an unused [patch] other than "I changed something and forgot to delete it", so it's true yeah an unconditional warning is probably ok


Use Hamcrest assertions instead of JUnit in  examples/openapi (#1749)

Part of #1749
I've already signed OCA. It's an automation problem.
Just curiosity. Are these tests runnable by pipeline?
Backport 2.x

/oca-checked

/trigger


Remove "FileLogging"

Logging output should be written to standard error and standard output streams instead (this allows redirection to file when run automatically, or observing output in terminal when run directly).

@milang , please review.

:+1:

:+1: for merge from me.


feat(secops): add kubeaudit

Hi @rndmh3ro,
Thank you for your new contribution,
We are glad that the project seems to interest you


elfutils: revert "split debuginfod into its own output"

This reverts commit d7ccc25142f62b4c25a75ae016a1ff552cc446d4.
THe change broke builds of gdb and linuxPackages_latest.systemtap.
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Further digging yesterday led me to the conclusion that debuginfod should probably be its own package, not an output of elfutils. Let's get this fix in so we don't have to wait for the "proper" implementation for the packages to build again.


Cannot locate module locally

Prerequisites

[x] Ensure you have latest version of plugin installed
[x] Search for possible issue duplicates - related to closed issue https://github.com/VladRassokhin/intellij-hcl/issues/170

Installation details

[x] IDE version (Help->About->Copy to Clipboard)IntelliJ IDEA 2021.2 (Ultimate Edition)
Build #IU-212.4746.92, built on July 27, 2021
Runtime version: 11.0.11+9-b1504.13 x86_64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 10.15.7
GC: ParNew, ConcurrentMarkSweep
Memory: 4029M
Cores: 8
Registry: scala.erase.compiler.process.jdk.once=false
Non-Bundled Plugins: org.intellij.plugins.hcl (0.7.14), mobi.hsz.idea.gitignore (4.2.0), name.kropp.intellij.makefile (212.4746.52), org.toml.lang (<IP_ADDRESS>26-212), org.jetbrains.plugins.hocon (2021.1.0), intellij.prettierJS (212.4746.57), Pythonid (212.4746.96), org.jetbrains.plugins.go (212.4746.92), org.intellij.scala (2021.2.15), pro.bashsupport (<IP_ADDRESS>)
Kotlin: 212-1.5.10-release-IJ4746.92

[x] intellij-hcl plugin version (Settings->Plugins) - 0.7.14
[x] Terraform version (terraform -v) - v1.0.10 (darwin_amd64)

Terraform Configuration Files
module "iam" {
  source = "s3::https://s3.amazonaws.com/path/to/module.zip"
}

And here is the project folder (including .terraform cache):
.
├── .terraform
│   ├── modules
│   │   ├── iam
│   │   │   ├── Makefile
│   │   │   ├── main.tf
│   │   │   ├── modules
│   │   │   │   ├── iam
│   │   │   │   │   ├── .terraform.lock.hcl
│   │   │   │   │   ├── main.tf
│   │   │   │   │   ├── outputs.tf
│   │   │   │   │   └── variables.tf
│   │   │   │   ├── local-data
│   │   │   │   │   └── outputs.tf
│   │   │   │   └── path
│   │   │   │       ├── outputs.tf
│   │   │   │       └── variables.tf
│   │   │   ├── output.tf
│   │   │   ├── policies
│   │   │   │   └── assume-role
│   │   │   │       └── codebuild.json
│   │   │   ├── variables.tf
│   │   │   └── versions.tf
│   │   ├── iam.path.path
│   │   │   ├── go.mod
│   │   │   ├── go.sum
│   │   │   ├── infra
│   │   │   ├── output.tf
│   │   │   ├── readme.md
│   │   │   └── variables.tf
│   │   ├── iam.session
│   │   │   ├── Makefile
│   │   │   ├── main.tf
│   │   │   ├── modules
│   │   │   │   └── local-data
│   │   │   │       └── outputs.tf
│   │   │   ├── outputs.tf
│   │   │   └── versions.tf
│   │   └── modules.json
│   └── providers
│       └── registry.terraform.io
│           └── hashicorp
│               └── aws
│                   └── 3.58.0
│                       └── darwin_amd64
│                           └── terraform-provider-aws_v3.58.0_x5
├── .terraform.lock.hcl
└── main.tf

Exception
N/A
Expected Behavior
The HCL plugin should be able to reference any module cached in the ./.terraform in the current directory. We are using Terraform inside of a monorepo, so we have several directories scattered around with Terraform configuration. I have noticed in some project folders we do not have this issue and in others we do. It seems to happen most often within sub-modules (e.g. ./modules/bar, relative to the project root), or when referencing sub-folders of a module, for example:
module "bar" {
  source = "s3::https://s3.amazonaws.com/path/to/module.zip//path/to/sub-module"
}

Actual Behavior
 Cannot locate module locally: Terraform Module 'iam' with source 's3::https://s3.amazonaws.com/path/to/module.zip' directory not found locally, use `terraform get` to fetch modules.

The module exists, of course, and is downloaded and cached in the .terraform folder. Performing Terraform CLI commands in the directory will succeed. It's just a problem with the plugin cache.
. <-- in this folder the module was resolved, and it also resolved it in the sub-folder
├── Makefile
├── main.tf
├── modules
│   ├── iam <-- the folder where the module cannot be resolved
│   │   └── main.tf
│   └── meta
│       └── outputs.tf
├── output.tf
├── readme.md
├── variables.tf
└── versions.tf

In the example we are downloading the module from S3, but it shouldn't matter what the source is. Notably, though, I haven't seen this happen with a local module reference (e.g. source = "../../path/to/module").
Steps to Reproduce
See the comment below https://github.com/VladRassokhin/intellij-hcl/issues/365#issuecomment-981972598

Here is a more thorough example. This is the project structure (this project exists in our monorepo repository at location: ./libraries/terraform/aws/bucket-object):
.
├── main.tf
├── modules
│   └── policies
│       ├── main.tf
│       ├── outputs.tf
│       └── variables.tf
├── outputs.tf
├── readme.md
├── variables.tf
└── versions.tf

Inside main.tf there is a module reference:
module "session" {
  source = "s3::https://s3.amazonaws.com/<REDACTED>/terraform/terraform-aws-session/terraform-aws-session_v0.2.2.zip"
}

Starting with no .terraform cache, I run terraform init in the root of the project...
➜  monorepo git:(feature/foo) cd libraries/terraform/aws/bucket-object
➜  bucket-object git:(feature/foo) terraform init
Initializing modules...
Downloading s3::https://s3.amazonaws.com/<REDACTED>/terraform/terraform-aws-session/terraform-aws-session_v0.2.2.zip for session...
- session in .terraform/modules/session

Initializing the backend...

Initializing provider plugins...
- Reusing previous version of hashicorp/aws from the dependency lock file
- Installing hashicorp/aws v3.61.0...
- Installed hashicorp/aws v3.61.0 (signed by HashiCorp)

Terraform has been successfully initialized!

You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.

If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.

The project .terraform cache folder now has the following structure:
.
├── modules
│   ├── modules.json
│   └── session
│       ├── main.tf
│       ├── modules
│       │   ├── meta
│       │   │   └── outputs.tf
│       │   └── policies
│       │       ├── main.tf
│       │       └── outputs.tf
│       ├── outputs.tf
│       └── versions.tf
└── providers
    └── registry.terraform.io
        └── hashicorp
            └── aws
                └── 3.61.0
                    └── darwin_amd64
                        └── terraform-provider-aws_v3.61.0_x5

The modules/modules.json file has the following content:
{"Modules":[{"Key":"","Source":"","Dir":"."},{"Key":"session","Source":"s3::https://s3.amazonaws.com/<REDACTED>/terraform/terraform-aws-session/terraform-aws-session_v0.2.2.zip","Dir":".terraform/modules/session"}]}

IntelliJ now correctly resolves this module from the cache, so the modules cache at the root of the project work fine. Now let's resolve the module references for the ./modules/policies sub-module, which contains the following in it's main.tf file:
module "session" {
  source = "s3::https://s3.amazonaws.com/<REDACTED>/terraform/terraform-aws-session/terraform-aws-session_v0.2.2.zip//modules/policies"
}

Again starting from having no .terraform cache, I navigate into the sub-module folder and run terraform init:
➜  bucket-object git:(feature/foo) cd modules/policies
➜  policies git:(feature/foo) terraform init
Initializing modules...
Downloading s3::https://s3.amazonaws.com/<REDACTED>/terraform/terraform-aws-session/terraform-aws-session_v0.2.2.zip for session...
- session in .terraform/modules/session/modules/policies

Initializing the backend...

Initializing provider plugins...

Terraform has been successfully initialized!

You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.

If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.

The ./modules/policies/.terraform cache directory now has the following structure:
.
└── modules
    ├── modules.json
    └── session
        ├── main.tf
        ├── modules
        │   ├── meta
        │   │   └── outputs.tf
        │   └── policies
        │       ├── main.tf
        │       └── outputs.tf
        ├── outputs.tf
        └── versions.tf

The modules/modules.json file has the following content:
{"Modules":[{"Key":"","Source":"","Dir":"."},{"Key":"session","Source":"s3::https://s3.amazonaws.com/<REDACTED>/terraform/terraform-aws-session/terraform-aws-session_v0.2.2.zip//modules/policies","Dir":".terraform/modules/session/modules/policies"}]}

However, IntelliJ cannot resolve the module:

Exactly the same problem.
terraform plan works A-OK but PHPStorm doesn't find the module files

I believe it worked with multiple terraform modules in same project before and now it can't locate modules for unknown reason for all but one module.

Not sure if it's the same cause but had the same issue with Terraform 1.1.0. They changed how they store the Source in .terraform/modules/modules.json causing the issue. See https://github.com/hashicorp/terraform/pull/28854. Looks like the plugin reads that file.
Fixed it by making sure the Source field in .terraform/modules/modules.json matches exactly the source in the TF file. If doesn't match, modify it for all the modules in that file and restart the IDE.
Example for an official module: change registry.terraform.io/terraform-aws-modules/vpc/aws to terraform-aws-modules/vpc/aws
I'm using PyCharm 2021.3 and version 0.7.14 of the plugin. I have also a monorepo with multiple Terraform projects!

Same issue. This seems to have started recently:
Webstorm: Build #WS-213.5744.224, built on November 27, 2021
Plugin 0.7.14
OS: Arch Linux
Error Cannot locate module locally: Unknown reason
module "gce-container-c1" {
  source = "terraform-google-modules/container-vm/google"
  version = "~> 2.0"
  container = {
    image = "eu.gcr.io/XXXX"
  }
  restart_policy = "Always"
}

Any workarounds?

Not sure if it's the same cause but had the same issue with Terraform 1.1.0. They changed how they store the Source in .terraform/modules/modules.json causing my issue. See hashicorp/terraform#28854. Looks like the plugin reads that file.

I can confirm, this solved the issue for me. Since the original reporter used 1.0.10, what we experienced here is a separate issue

Alternativlity,  you can prepend your source URI with registry.terraform.io/ in your main.tf since not including it is just a short hand way of indicating that the module is hosted on the Terraform registry. Then you don't have to touch the files in the cache.
module "vpc" {
  source  = "registry.terraform.io/terraform-aws-modules/vpc/aws"
  version = "3.11.0"
}

Thanks @danpoland , it's really helpful!

looks like plugin successfully can find a remote modules after terraform get  with terraform version 1.0.11 and below, unfortunately can't find modules with latest terraform versions.

@shuliakovsky see my reponse above in case you missed it for a workaround: https://github.com/VladRassokhin/intellij-hcl/issues/365#issuecomment-996019841.
You will to need to update the .terraform/modules/modules.json for the plugin to work properly when using Terraform >= 1.1.0.

We can use sed to quickly fix a repository with multiple workspaces:
alias jb_hcl_fix='sed -i "s/registry.terraform.io\///g" **/.terraform/modules/modules.json'

Please see https://github.com/VladRassokhin/intellij-hcl/issues/373 for issues related to the module paths introduced in Terraform 1.1.x -- the issue in this ticket only relates to sub-modules.

Would there be a way to update the plugin to look for the new Source address alongside the exact match?
From glancing at hashicorp/terraform#28854 I see the following:

registry/module            --> registry.terraform.io/registry/module
github.com/some/module     --> git::https://github.com/some/module
git@github.com:some/module --><EMAIL_ADDRESS>
^By no means is this an exhaustive list, I compiled it from looking at some of the updated unit tests.
The fixes mentioned above do work for me, but it is a lot more verbose than I'd like. If the plugin can search modules.json for both an exact match OR an expected transformed match, wouldn't it handle the cases for both Terraform 1.1.x and below that as well?

I've just recently had this issue, again despite checking that the values under source = and values under the file modules.json are the same
Resolution

Try restarting Intelli-j, or
See if there are any updates to the plugin, or
Update terraform (Personally I use tfswitch, or
Reboot ( ͡° ͜ʖ ͡°)

I'm not sure why this happened, but the above steps seem to solve it temporarily

Not sure if it's the same cause but had the same issue with Terraform 1.1.0. They changed how they store the Source in .terraform/modules/modules.json causing my issue. See hashicorp/terraform#28854. Looks like the plugin reads that file.
Fixed it by making sure the Source field in .terraform/modules/modules.json matches exactly the source in the TF file. If doesn't match, modify it for all the modules in that file and restart the IDE (or close and open the file).
Example for an official module: change registry.terraform.io/terraform-aws-modules/vpc/aws to terraform-aws-modules/vpc/aws
I'm using PyCharm 2021.3 and version 0.7.14 of the plugin. I have also a monorepo with multiple Terraform projects!

I have same issue using:

terraform v1.2.4;
WebStorm v2022.1.3
Terraform Plugin v22.5921.12

This answer still works, thanks!

In my case I had to switch from terraform-aws-modules/vpc/aws to registry.terraform.io/terraform-aws-modules/vpc/aws.

terraform 1.2.4
Intellij 2022.1.2

In my case I had to switch from terraform-aws-modules/vpc/aws to registry.terraform.io/terraform-aws-modules/vpc/aws.

terraform 1.2.4
Intellij 2022.1.2

That tip was life-saving for me, thanks @lozuwa


fix perspective, multiply the result matrix by perspective matrix

This is a fix for a 3D view of rotation.
https://github.com/jmurzy/react-native-foldview/issues/17

@jmurzy Here's a fix for a perspective view.

@ErrorPro Awesome! Thanks for doing this, Ven!


addAtlasJSONArray() method fails

Version

Phaser Version: 3.60.0

Operating system: Windows 10

Browser: Chrome

Description
The addAtlas and addAtlasJSONArray methods of Texture Manager errors out when trying addAtlas.
Expected behavior: an Atlas array is added to an existing Phaser Texture.
Actual behavior: an exception is thrown:
Uncaught TypeError: Cannot read properties of null (reading 'key')     at TextureManager.addAtlasJSONArray (phaser.js:211602:1)
Example Test Code
this.textures.on(LOAD, (key: string, texture: Phaser.Textures.Texture)=>{
      if(key === 'flares'){
        this.textures.addAtlas(FS_KEYS.FLARES, texture, flaresAtlas)
      }

Additional Information
Similar problem like here https://github.com/photonstorm/phaser/issues/6553 , tries to access key property on 'null'
addAtlasJSONArray: function (key, source, data, dataSource)
    {
        var texture = null;

        if (source instanceof Texture)
        {
            key = texture.key;
            texture = source;
        }
        else if (this.checkKey(key))
        {
            texture = this.create(key, source);
        }

Thank you for submitting this issue. We have fixed this and the fix has been pushed to the master branch. It will be part of the next release. If you get time to build and test it for yourself we would appreciate that.


Implement marketplace

Add marketplace functionality to the world, namely the ability to list ... an object.

@dluman  The code rewrite was for sure needed because my code was becoming a jumbled mess and was becoming a lot of different variables in many different locations, looking back I think it may have been a good idea to just have the make_library and make_version functions just be built into the build function, because we were never going to actually call these functions outside of build and so I believe having them outside just makes the code a little more complicated in having to import all these different variables to input information.


Optimize catalog fetch in catalog-service

Currently, we always pull a version of the Rancher catalog, even if it hasn't changed. We should optimize so it only fetches when there has been a change based on commit reference.
https://developer.github.com/changes/2016-02-24-commit-reference-sha-api/
https://developer.github.com/v3/repos/commits/#get-the-sha-1-of-a-commit-reference
for catalog-service, we'll need to do something like
if ( github.com/{org}/{repo} ) {
  Send request to https://api.github.com/repos/{org}/{repo}/commits/{branch}
  Also follow redirects, because those send a redirect now that they don't mention in docs...
  if ( response is 304 ) {
    do nothing
  }
} else if ( git.rancher.io )  {
  Send similar request to ${some url we creates}
  if ( response is 304 ) {
    do nothing
  }
}

do regular update

Tested with rancher-server version v1.6.3-rc5
Changes done on catalog side ( like add/edits/deletes of existing templates) get reflected in the rancher-server side within the next 5 mts ( default catalog.refresh.interval.seconds).

Optimization for catalog fetch works for catalogs hosted in github.com and git.rancher.io .
Optimization for catalog fetch will not work with  catalogs hosted in private mirrors.

We should include optimizations for users with personal mirrors which is tracked in  -
https://github.com/rancher/rancher/issues/9273


aadeshpa issue 132 updated the appsody list to appsody version

Checklist:

[ ] Read the Code of Conduct and Contributing Guidelines.

[ ] Followed the commit message guidelines.

Updates to the collections

Related Issues:

This fixes https://github.com/kabanero-io/kabanero-pipelines/issues/137.


#4958: Move all python api unit tests to frequent in order to reduce SD pipeline length

We may have to slow this down and consider putting the python unit tests in a separate job with a different pipeline name...
And maybe possibly rename current frequent qualifiers to something like frequent_models and frequent_unit_tests
Another consideration is the markers in pytest.ini


make up return error

Hi, I got this error when try to run make up, can you help?
Error response from daemon: path /mlan_asterisk/docker-asterisk/demo/pulse is mounted on / but it is not a shared mount

Hello @fukemy
Are you running the demo as root? If so you might try to share /
mount --make-shared /
systemctl daemon-reload

This is just a guess since I have not tested this. Perhaps it is better to run the demo as a non privileged user.


Improve compression settings in nginx configuration

Currently our nginx configuration in puppet/zulip/files/nginx/nginx.conf uses gzip compression; we should use something more efficient.
See https://chat.zulip.org/#narrow/stream/development.20help/subject/adding.20custom.20js for discussion.

Maybe something like Brotli? Though there isn't official support for it in nginx.

Hmm.  We probably want to stick to things supported in nginx in Ubuntu 14.04 Trusty for simplicity of deployment, but there are other compression options than gzip and Brotli.

@zulipbot  claim

Copying relevant conversation -
https://chat.zulip.org/#narrow/stream/49-development-help/topic/Improve.20compression.20settings.20in.20nginx

@timabbott I searched for some other standard compression algorithms, gzip works better in most of the cases. For eg. zopfli, pigz can be used for static files might give us a little bit of improved performance.

@zulipbot  abandon

OK, I'm going to close this -- it's certainly not a good first issue since we don't have a specific thing to try, and this aspect of performance isn't a current problem.  I imagine we'll think about this again in the context of profiling our web performance if it seems to be one from that standpoint in the future.


How to build for AWS lambda?

Hello, I have an AWS lambda function written in Zig and I want to use the lambda bundler provided by zig2nix. This is the relevant code of my flake.nix:
    packages = forAllSystems (pkgs: let
      env = zig2nix.outputs.zig-env.${pkgs.system} {};
      target = "aarch64-linux";
      skia = ((env.pkgsForTarget target).callPackage ./nix/minimal-skia.nix {});
    in rec {
      exporter-lambda = env.packageForTarget target {
        src = ./.;
        zigPreferMusl = false;
        zigDisableWrap = false;
        buildInputs = [ skia ];
        zigBuildFlags = [
          "-Dskia-include=${skia.dev}/include"
          "-Dskia-lib=${skia.out}/lib"
        ];
      };
      aws = env.bundle.aws.lambda {
        package = exporter-lambda;
        arch = "aarch64";
      };
    });

(minimal-skia.nix is essentially a modified version of this package with useless dependencies removed)
in my build.zig I'm doing something like:
const skia_include = b.option([]const u8, "skia-include", "path to skia include dir");
const skia_lib = b.option([]const u8, "skia-lib", "path to skia lib dir");
// ...
if (skia_include) |include| {
  exe.addIncludePath(.{ .cwd_relative = include });
}
if (skia_lib) |lib| {
  exe.addLibraryPath(.{ .cwd_relative = lib });
}

But when trying to nix build .#aws I'm getting this error:
error:
       … while calling the 'derivationStrict' builtin

         at /builtin/derivation.nix:9:12: (source not available)

       … while evaluating the derivation attribute 'name'

         at /nix/store/0jr2kk95c34c0b6yxi75q4fqgb43kqkm-source/pkgs/stdenv/generic/make-derivation.nix:334:7:

          333|     // (optionalAttrs (attrs ? name || (attrs ? pname && attrs ? version)) {
          334|       name =
             |       ^
          335|         let

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: architecture  is not supported

What could I be doing wrong? Thanks

The arch expects aws arch so arm64 in this case. Usually it should be autodetected by omitting it though.

I had the same error without specifying arch.

Ah sorry, it indeed should be aarch64. Will it work if you give your package a name?

Sorry for late reply. Giving the package a name and setting the meta.mainProgram for my zig package fixed it. Thanks!


Hello World Example

Where is the best place to start learning the networking in regards to the k8's cluster deployments? Flannel doesn't seem to have a clear hello world example. What would be the best way to create one?

Have you looked at https://github.com/GoogleCloudPlatform/kubernetes/blob/master/docs/networking.md

I actually ended up using the flannel portion in this article. It has a few straight forward steps to send a packet around using flannel. One glance at the article and I understood a simple flannel stand alone use case.
http://www.generictestdomain.net/docker/weave/networking/stupidity/2015/04/05/weave-is-kinda-slow/


SAK-29960 Upgrade log4j impl 1 to 2

SLF4J is still the api used in Sakai code, all this does is upgrade our logging impl from log4j 1 to log4j 2.

This is marked draft as I still need to migrate the log4j.properties in unit tests


GraphQL to Protobuf converter

We require a GraphQL to Protobuf supporter similar to GraphQLToAvroConverter.
It will be called when a user creates a new topic with a GraphQL schema and expects Quick to use Protobuf schemas.

What about the following types:

nullable fields (we have to add the optional keyword, at least for primitives)
lists
enums


Prevent inherit from itself SoapClient.

The original code not working on Windows OS, occurs an error:
PHP Fatal error:  Class 'VCR\Util\SoapClient' not found ...

This is happens due to code transformation (see SoapCodeTransform), after which VCR\Util\SoapClient inherit from itself. Like this:
<?php

namespace VCR\Util;

use VCR\LibraryHooks\SoapHook;
use VCR\VCRFactory;

class SoapClient extends \VCR\Util\SoapClient
{
    ...

PR solves issue #67.
Tests' result before the patch:
> .\vendor\bin\phpunit
PHPUnit 3.7.38 by Sebastian Bergmann.

Configuration read from D:\Projects\php-vcr\phpunit.xml

...............................................................  63 / 248 ( 25%)
..........................PHP Fatal error:  Class 'VCR\Util\SoapClient' not found in D:\Projects\php-vcr\src\VCR\Util\SoapClient.php on line 13

Tests' result before fix StreamProcessorTest::testDirOpendirNotFound:
> .\vendor\bin\phpunit
PHPUnit 3.7.38 by Sebastian Bergmann.

Configuration read from D:\Projects\php-vcr\phpunit.xml

...............................................................  63 / 248 ( 25%)
............................................................... 126 / 248 ( 50%)
.....S......................................................... 189 / 248 ( 76%)
.........................F..S..............................

Time: 2.2 seconds, Memory: 11.25Mb

There was 1 failure:

1) VCR\Util\StreamProcessorTest::testDirOpendirNotFound
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'opendir(not_found): failed to open dir: No such file or directory'
+'opendir(not_found,not_found): ═х єфрхЄё  эрщЄш єърчрээ√щ Їрщы. (code: 2)'

D:\Projects\php-vcr\tests\VCR\Util\StreamProcessorTest.php:84
D:\Projects\php-vcr\src\VCR\Util\StreamProcessor.php:334
D:\Projects\php-vcr\tests\VCR\Util\StreamProcessorTest.php:88

Tests' result after the patch:
> .\vendor\bin\phpunit
PHPUnit 3.7.38 by Sebastian Bergmann.

Configuration read from D:\Projects\php-vcr\phpunit.xml

...............................................................  63 / 248 ( 25%)
............................................................... 126 / 248 ( 50%)
.....S......................................................... 189 / 248 ( 76%)
............................S..............................

Time: 2.23 seconds, Memory: 11.25Mb

OK, but incomplete or skipped tests!
Tests: 248, Assertions: 343, Skipped: 2.

Probably the blacklist is not working on Windows where the SoapClient util and other paths are blacklisted https://github.com/php-vcr/php-vcr/blob/master/src/VCR/Configuration.php#L121.

Indeed, items from the blacklist are not matched, because Windows uses backslash for path separator.

I rebase the branch.

@adri can you review?

Looks good, thank you very much @yethee.


Typo in readme banner

Typo in the readme banner image. Respons e

Good spot and thanks! Have improved the banner wording too.


Use template variables like Schemes and Host in the API Description

Is your feature request related to a problem? Please describe.
I would like to be able to use template variables like Schemes and Host in my API Description like this: // @Description More information can be found here: [Service Documentation]({{index .Schemes 0}}://{{.Host}}/docs/service). This is because we host other information like flow diagrams, code examples, etc. on the same server as the Open API spec.
Describe the solution you'd like
Parse and Execute the SwaggerInfo.Description as a template like the generated doc.

According to your example please explain what will happen if host and schemes will not be set in comments/annotation (because they are optional).
Is there any reason this doesn't work for you ?
// @Description More information can be found here: [Service Documentation](/docs/service).

true, that should cover my case

close the issue and revisit if another use-case comes up?

I think is better to not implement it for the moment. If we will have more requests for this we will take in consideration this feature.
Thanks.


Fixed draco subscriber parameter names

Superseed this PR https://github.com/ros-perception/point_cloud_transport_plugins/pull/37
The subscriber param names:
pct.point_cloud1.draco.skipDequantizationColor
pct.point_cloud1.draco.skipDequantization...
pct.point_cloud1.draco.skipDequantization...
pct.point_cloud1.draco.skipDequantization...
...
pct.point_cloud2.draco.skipDequantizationColor
pct.point_cloud2.draco.skipDequantization...
pct.point_cloud2.draco.skipDequantization...
pct.point_cloud2.draco.skipDequantization...

@FranzAlbers
Do you mind to try the combinantion of these two PRs

https://github.com/ros-perception/point_cloud_transport_plugins/pull/38
https://github.com/ros-perception/point_cloud_transport/pull/43

Thanks for helping out so fast, @ahcorde!
I've tested the PR cherrypicked on my ROS2 Humble installation, but I think this shouldn't make a difference.
Two different subscribers can now be instantiated without crash.
The crash still occurs when parameters of the same subscriber are redeclared (e.g., add different two displays for /points/draco or add only one display for /points/draco, rename the topic to something different and then again to /points/draco)

I made a new change, do you mind to try it @FranzAlbers ?

Thanks @ahcorde, this fixes the crashes! 👍

https://github.com/Mergifyio backport humble iron


Windows Builds Missing from Release Assets

I assume there is reason for this based on some of the open issues of people trying to build iwasm themselves, but I couldn't find any exlicit reason why there is no windows build in the release assets.
The only reason I haven't just built it myself is because my windows install is messed up and my path keeps lossing things, and my linux machine is RMA...

This is just what I think. Anyone, @wenyongh, is welcome to add their thoughts.
One reason might be that there aren't many developers in the community who are familiar with Windows for development. I think this might be because most of the WAMR use cases we know about don't use Windows. Anyway, not having enough experience makes the porting job go slower and leads to the issue you talked about. We're open to any help, especially in this area. 🤝

I'm not directly that interested in WAMR itself, but rather just as a runtime for wasm.
And from my own benchmark comparing wasmer with hand rolled wat to native C for a basic http ping server it had a 50% performance loss, and going through their rust code base is like seven different layers of Rust abstraction to get to any thing actually executing at an OS or wasm level.

It seems that wamr is the only runtime that has both GC and berkley sockets, so I guess I'll need to start getting into building it.

Agree, it would be great if there are windows binaries in the release assets, e.g. iwasm.exe and wamrc.exe. But it seems that @AjaniBilby wants iwasm.exe with GC and socket support, and other developer also hopes to release iwasm with GC support, see #3829, so my suggestion is to release: (1) iwasm without GC support for macos, ubuntu and windows, (2) iwasm with GC support for macos, ubuntu and windows, (3) wamrc for macos, ubuntu and windows.

It looks like @wenyongh and others have already done most of what I would have been able to contribute already 🫡
Also the latest release of wabt isn't able to convert the example in the proposal overview (adjusted to the latest spec) from wat to wasm. So it definetly is a bleeding edge feature, and I'll just rely on V8 based runtimes for now iWasm is ready 🙇


Update comparison matrix

@dianasaur323, I think you're reworking the cockroachdb in comparison matrix? We should add Google Cloud Spanner.
Also, we could add another "Jepsen" dimension, indicating whether the db has been tested by Jepson, the highest consistency level verified by that testing, and a link to the post.

Ok, that sounds solid. Will do - thanks!
Diana
On Tue, Feb 28, 2017 at 2:15 PM jseldess<EMAIL_ADDRESS>wrote:

@dianasaur323 https://github.com/dianasaur323, I think you're reworking
the cockroachdb in comparison matrix? We should add Google Cloud Spanner.
Also, we could add another "Jepson" dimension, indicating whether the db
has been tested by Jepson, the highest consistency level verified by that
testing, and a link to the post.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cockroachdb/docs/issues/1131, or mute the thread
https://github.com/notifications/unsubscribe-auth/AFgDWCD9AYctL7bSgJ3_WX_oFLkRdOyoks5rhHJJgaJpZM4MOynY
.

--
Diana Hsieh
<EMAIL_ADDRESS>407-690-9048

Here's Google Spanner's. I think we need to update the row titles and we can add Jepsen in there too.
Automated Scaling - Yes
Automated Failover - Yes
Automated Repair - Yes
Strongly Consistent Replication - Yes
Consensus-Based Replication - Yes
Distributed Transactions - Locking Read-Write
ACID Semantics - Yes
Eventually Consistent Reads - No
SQL - Read-only
Open Source - No
Commercial Version - Yes
Support - Yes

Thanks, @dianasaur323. Are you adding these, or would you like me to?

Hi Jesse - I can do it. I actually think Spanner supports eventual reads -
I need to double check that.
On Fri, Mar 31, 2017 at 12:55 PM, jseldess<EMAIL_ADDRESS>wrote:

Thanks, @dianasaur323 https://github.com/dianasaur323. Are you adding
these, or would you like me to?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cockroachdb/docs/issues/1131#issuecomment-290768005,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFgDWGFVnT0NWsJfIicmr6GvSiLaaFhhks5rrS_wgaJpZM4MOynY
.

--
Diana Hsieh
<EMAIL_ADDRESS>407-690-9048

Addressed in https://github.com/cockroachdb/docs/pull/1264


feat(renovate): add dependencyDashboard

Coverage remained the same at 85.273% when pulling d5848c5be2e9dacbcd322503b0689399e83d332f on renovatedashboard into 3f4db4954d7df527c9fba93c90fe699c32521ba7 on dev.


The ipv4 filter requires python's netaddr be installed on the ansible controller

Hi
Im running into this issue
TASK [ovirt.hosted_engine_setup : Wait for the bridge to appear on the host] ************************************************************************************************************************************
changed: [all-in-one.home.adrians.computer]

TASK [ovirt.hosted_engine_setup : Refresh network facts] ********************************************************************************************************************************************************
ok: [all-in-one.home.adrians.computer]

TASK [ovirt.hosted_engine_setup : Fetch IPv4 CIDR for virbr0] ***************************************************************************************************************************************************
fatal: [all-in-one.home.adrians.computer]: FAILED! => {"msg": "The ipv4 filter requires python's netaddr be installed on the ansible controller"}

PLAY RECAP ******************************************************************************************************************************************************************************************************
all-in-one.home.adrians.computer : ok=103  changed=27   unreachable=0    failed=1    skipped=41   rescued=0    ignored=0

and I have netaddr installed
$ ll -d /usr/lib/python2.7/site-packages/netad*
drwxr-xr-x. 6 root root 4096 May 24 09:41 /usr/lib/python2.7/site-packages/netaddr
drwxr-xr-x. 2 root root 4096 May 24 09:41 /usr/lib/python2.7/site-packages/netaddr-0.7.19-py2.7.egg-info

Just a little more info - the above issue I ran into when running the playbook from my laptop (Fedora) aiming at a remote server.
If I ssh directly into the server and run the script there locally (as root) it seems to work fine

{"msg": "The ipv4 filter requires python's netaddr be installed on the ansible controller"}

This means that python's netaddr should be installed on the ansible controller node, AKA your laptop if you are executing ansible-playbook from there.
On my FC29 machine I see:
[stirabos@t470s ovirt-engine]$ ansible-playbook --version
ansible-playbook 2.8.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = ['/home/stirabos/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python3.7/site-packages/ansible
  executable location = /usr/bin/ansible-playbook
  python version = 3.7.3 (default, Mar 27 2019, 13:41:07) [GCC 8.3.1 20190223 (Red Hat 8.3.1-2)]

so it's definitively using python 3.7 and netaddr on python 3 is distributed on Fedora as python3-netaddr
which is definitively not /usr/lib/python2.7/site-packages/netaddr.
Can you please retry installing  python3-netaddr on your laptop?

Thanks, that did solve this problem. I ran into another issue later but I shall do some troubleshooting and open an separate issue if I cant resolve it
Many thanks


java.lang.NoSuchMethodError: sun.nio.ch.DirectBuffer.cleaner()Lsun/misc/Cleaner; when closing DB on Mac with Java 9

Let me begin by saying how much I value MapDB and the concept it represents. I forms an integral part of my own project.
When running MapDB using Java 9 on MacOS
$java -version
java version "9.0.4"
Java(TM) SE Runtime Environment (build 9.0.4+11)
Java HotSpot(TM) 64-Bit Server VM (build 9.0.4+11, mixed mode)

closing any map fails with
java.lang.NoSuchMethodError: sun.nio.ch.DirectBuffer.cleaner()Lsun/misc/Cleaner;
	at org.mapdb.volume.ByteBufferVol.unmap(ByteBufferVol.java:340)
	at org.mapdb.volume.MappedFileVol.close(MappedFileVol.java:183)
	at org.mapdb.StoreDirect.close(StoreDirect.kt:877)
	at org.mapdb.DB.close(DB.kt:472)
	at org.mapdb.HTreeMap.close(HTreeMap.kt:1343)

Please let me know if you require additional information.
Thanks!

I found out that this is related to the .cleanerHackEnable() option. When removing this flag from the database builder, I am not getting the above exception.

@jankotek, can this issue be fixed while keeping cleanerHackEnable() option?


Remove .jsx from Javascript file extensions and create an jsx-mode

This PR removes .jsx from Javascript file extensions and creates an separate jsx-mode.

@petetnt we have used the convention in the past to put in the title of the PR "[DO NOT MERGE]" or something to that extent for a more visual cue of the status of the PR.

Looking forward to this :)

@MiguelCastillo Yeah that's probably a good idea. I changed the title :+1:

I created and added a label to track PRs that shouldn't be merged. :)  Easier to filter

CodeMirror is now merged so this should be too. Ping @MiguelCastillo

@petetnt Yup - this is my next item on the list :)

I think this is an easy merge now. Is there something blocking this, @MiguelCastillo @petetnt?

@MarcelGerber nope AFAIK. Just needed the CodeMirror update.

Yeah you guys are right. I completely disappeared for a bit and neglected.  Merging now.

It works very nicely too!  Thank you @petetnt.


Update README.md

Java version updated to 21.
I hope this information is useful.
Thank you :)

Java version updated to 21.
I hope this information is useful.
Thank you :)

Java version updated to 21.
I hope this information useful.
Thank you :)


Binding data from vuex state to vuetable

Binding data from vuex state to vuetable (instead of providing the table instance an api-url) would be very useful if one would want to make API requests in Vuex, store the results in the Vuex state and get the data from there. That would, in some cases, seem like good practice instead of directly communicating with the API through the Vuetable.
Has anyone implemented this yet?

Currently, I see using Vuex to handle state management as a recommended way in a large web app that uses Vue.js. Not using it is by no mean an indication for bad practice at all.
However, I would love to see how people would integrate vuex with Vuetable to solve their problems that might also benefit the others as well.

From my point, I don't see so many advantages using vuex to store paginated tabular data. If you want to keep paginated data in vuex it might become hard to manage it, as well as manage edited/added fields if you have many pages. For the apps I used vue table, the current solution seemed to be more than enough. The only disadvantage was more on the required pagination fields as I had to implement them on the backend side and adapt my backend pagination to vue table. This, to me is a bigger issue than handling results in vuex state

@cristijora Can you please explain some more about the required pagination fields that you had to implemented? I'm not quite understand what you mean. Maybe you can open a new issue for that so that
we can discuss.

Usecase:
I use vuex in a large app that store real estate data, each row has hundreds of fields that should be filterable.
The webapp must be offline usable (without installing local databases), because sometimes the real estate agents are in areas where they did not have a good internet connection.
On demand the rows are loaded and stored in vuex and the local storage. At the next application start only modified rows are reloaded, or if an other user modify a row, each connected client updates their vuex state in "realtime".
I load the data for vuetable from the vuex store. The store filter/sort/etc. and deliver the needed data to vuetable. If vuex did not have the requested data, it loads them over the API.
One questions is: why did vuetable not watch the data change?
I do this manually with adding a watcher that calls setData.
<template>
  <div class="re-list">
    <vuetable
      :api-mode="false"
      :data="elements"
      ref="vuetable"
      :fields="fields"
      :per-page="1"
      :muti-sort="true"
      multi-sort-key="shift"
    ></vuetable>
  </div>
</template>

<script>
import Vuetable from 'vuetable-2/src/components/Vuetable'

import { mapActions, mapGetters } from 'vuex'

export default {
  name: 'ReList',

  components: {
    Vuetable
  },

  data () {
    return {
      fields: [
        {
          name: 'name',
          sortField: 'name'
        }, //...
      ]
    }
  },

  created() {
    this.fetch({
      page: 1, // static values for a shorter example
      perPage: 10,
      filter: {},
      sort: {}
    })
  },

  computed: {
    ...mapGetters('plugins/re/list/', {
      elements: 'get' // better with 'getFiltered'
    })
  },

  methods: {
    ...mapActions('plugins/re/list/', {
      fetch: 'fetch'
    }),
    //...
  },

  watch: {
    elements: function(data) {
      this.$refs.vuetable.setData(data)
    }
  }
</script>

@rottmann What I'm currently working on is that, in data mode, Vuetable will call you callback function asking for the data instead of calling the API endpoint. So, you can implement whatever logic necessary and then return those chunk of data from your callback to Vuetable. It will then use those data to call setData() method. Hope to have time to finish it soon.

@ratiw can we use feature or is still on development ?

Just wondering if this is a bug when you bind data through vuex with VueTable, where when perform a sort on a column, console log displays "data mode: array".
That code is in VueTable.vue component line 1156.
I think there are cases where setting the data explicitly, rather than through apiUrl is better. Although doing so right now seems cumbersome.
Also, I see the same console log message when applying search filter functionality.

@AngeloAnolin It's just a console.log dump that I forget to remove, sorry about that.
I actually feel the same that using the Data mode is quite cumbersome. As I don't really use it myself, any suggestion on how to improve it will be very appreciated. I primarily use API mode without Vuex, so I don't quite understand how the workflow is.


Fix alignment with available commands

When upgrading the Color package from v1.15.0 to v1.16.0, the list of available commands becomes incorrectly aligned:
Available Commands:

  completion Generate the autocompletion script for the specified shell
  help      Help about any command
  test      Test command for clarity

This was related to an issue where reset codes were not correctly set. The fix, which added extra reset codes, increased the length of the string (which includes the ANSI codes) causing the amount of padding to be insufficient.
This change, which upgrades the Color package to v1.16.0, also increass the padding to account for the additional ANSI reset codes that are now part of the string. This restores the text alignment to how it was previously displayed.
Unit tests also needed to be updated to account for this change and are passing successfully.
The Color package had updated its dependencies which has caused the changes in go.mod to impact more than itself.
Fixes: #4

@ivanpirog Let me know if this meets your requirements for fixing this issue.


Unite forces?

Hello,
Nice project.
I'm using emacs-aichat for the moment, and I just realized there are many projects in this domain and/or trying to unify the access to any GenerativeAI services. Would be great to unite forces, I'll create & link issues on all the projects so that each of you can think about it :)
= Similar projects (studied a little bit)
https://github.com/xhcoding/emacs-aichat
https://github.com/rksm/org-ai
https://github.com/xenodium/chatgpt-shell
https://gitlab.com/daanturo/starhugger.el

= Similar projects (just read READMEs)
https://github.com/emacs-openai/chatgpt
https://github.com/emacs-openai/codegpt
https://github.com/CarlQLange/chatgpt-arcana.el
https://github.com/stuhlmueller/gpt.el
https://github.com/joshcho/ChatGPT.el
https://github.com/manateelazycat/mind-wave
https://github.com/antonhibl/gptai
https://github.com/samrawal/gpt-emacs-macro

= Project unifying access to local/cloud LLMs (for emacs)
https://github.com/freckletonj/uniteai

@liar666 Sorry I missed this until now! Yes, I would love to join forces.
I considered these projects, but liked my approach because it keeps the domain code (ML models, etc) in python where it's easily extensible, and via LSP, useful in any editor.
What did you have in mind?

@liar666 This was a good idea, thanks, and I've reached out to several repo authors.
If we get some momentum, I'll start a discord for us to coordinate.

I started the discord, btw :)  https://discord.gg/3K2Q93bug

I started the discord, btw :) discord.gg/3K2Q93bug

Hmm

@LexiconCode Thanks for pointing that out! Here's a fresh one! https://discord.gg/EPcaUCPj

@upbqdn Hey sorry about that, I think discord was trying to make never-expiring links a premium feature, which this discord channel doesn't have. It seems I can generate them now though, so
Here's a fresh one! https://discord.gg/r7Wy7pcDan
This project is still functional and built on solid ground, but I haven't been working on it much the last little while since the community interest languished.
If you have some particular interest, I'm happy to spend more time on this!

Great, thank you. I've joined the Discord server. I'll continue the conversation there.