RequireJS, TypeScript and Popper

CodePen demo

I've created a test project to reproduce the issue.
https://github.com/chapterjason/proper-issue
Steps to reproduce the problem
Im currently starting to use popper.js in my project. The first issue I've got that I can't importing files that ends with .js in require.js (https://github.com/requirejs/requirejs/issues/1560). I could resolving this with adding a mapping instead of a path.
I tried now to import popper with import Popper from 'popper.js'; which ends up in TypeError: popper_js_1.default is not a constructor in the browser.
I also tried the other import style import Popper = require('popper.js'); but this ends up in the following semantic errors on the TypeScript compilation:
.....ts(..,..): error TS2694: Namespace ''popper.js'' has no exported member 'PopperOptions'.
.....ts(..,..): error TS2351: Cannot use 'new' with an expression whose type lacks a call or construct signature.

What is the expected behavior?

After looking in https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.12.3/umd/popper.js I expected no semantic errors, cause define(factory) returns the Popper function and not a multiple exports module.
What went wrong?

The index.d.ts the typings went wrong for amd.
Any other comments?

I don't know TypeScript, but in JS import Popper = require('popper.js'); is syntax error, it should be const Popper = require('popper.js')
Regarding your problem, I would probably ask on the repository of the bundler you are using, since Popper.js loads just fine on all the other user's projects.
I'm sorry but I don't think I'm able to help you further.

I think you misunderstood me. The index.d.ts is incompatible with the umd version.
As you can see there is only one "export"
(function(global, factory) {
    typeof exports === 'object' && typeof module !== 'undefined' ? module.exports = factory() :
        typeof define === 'function' && define.amd ? define(factory) :
        (global.Popper = factory());
}(this, (function() {
    var Popper = function() {
        [...]
    }();
    return Popper;
})));

module.exports = factory() or define(factory) or factory() will always return the constructor.
In the index.d.ts you've got the following.
declare module 'popper.js' {
  export default Popper;
}

And it is not correct in comparsion to the documentation https://www.typescriptlang.org/docs/handbook/declaration-files/templates/module-class-d-ts.html

@chapterjason,  did you solve this successfully?
how can i make this work? i am getting the same error as you did (TS+NG5)

Getting the same error aswell...

I got it working in a hacky way by using any. Of course, this pretty much removes all typescript benefits.
import * as PopperJS from 'popper.js';
...
const P: any = PopperJS;
this.popperInstance = new P(..);

@FezVrasta it looks like the issue is getting more popular. I didn't rember if I got any solution, but I will try it later and will provide a pr

It's quite a shame that this issue is not fixed, and yet still occurring because of improper type definitions. My fix consist of "own" typings: https://gist.github.com/kadet1090/b11d4dbe794f6016cb826b516e1fd45b
And then i can require it via:
/// <reference path="./types/popper.js.d.ts" />
import Popper = require("popper.js");

The first line is actually quite important because it tells typescript to use my typings instead of those provided with package.

@kadet1090 thanks a lot! you saved my day.

Also mine :)
You should do a PR.
Sometimes I'm having a hard time understanding why the majority of developers still uses plain JS, instead of TS ;)


Hotfix/class order docs

closes #9

Coverage decreased (-0.4%) to 76.852% when pulling 907da0f21413596777e15a1076cad935860b9294 on hotfix/class-order-docs into 34fb26da1209ba66b079677da6a793810eeefe44 on master.


useless self-update made

When the rustup call is made, --no-self-update is not passed: as a result rustup does a self update, but this is useless as rustup will typically not be used again during the CI run.
When rustup update is needed, it will need to be done before installing rust - #170 .
So I suggest passing --no-self-update for any run installing rust components, and removing it if and only if calling rustup self update explicitly.

For anyone who needs a similar action but without the self-update, take a look at dtolnay/rust-toolchain.


merge plot

mapping rate by species
read number by species
etc

supported by https://github.com/kfuku52/amalgkit/commit/44991794c5355daa5f9dcc4571bba849d568a200


Match other Solarized ports

This PR changes the base.less colors.
It will most likely "break" stuff in a few places, but should make it match more other Solarized ports (Sublime, TextMate).

[x] base.less
[x] autocomplete variables
[x] update all languages

Closes #55

Ok, this is somewhat ready. Not 100% perfect, but should be close. Some screens (Atom vs TextMate):

Some of the language files didn't changed, so they might could still be optimized. Like removing stuff that now is already styled from base.less. But that can happen over time.

nice progress!

One thing I miss from Sublime's Solarized is that the line gutters have the same background as the editor area

.

@MayhemYDG Personally, I also prefer no gutter background. On the other hand the "original" Solarized theme defines a gutter background: http://ethanschoonover.com/solarized.
You could also remove the background in your styles.less file with:
atom-text-editor::shadow .gutter {
  background-color: transparent;
}

Good point. The "original" theme also highlights the line the cursor is on, but not the gutter's background-color for the line number. Which might actually be better.
I ended up with this:
atom-text-editor::shadow {
  .cursor-line {
    background-color: #073642;
  }

  .indent-guide:first-child {
    box-shadow: none;
  }
}

Thanks for the snippet anyway, it helped me do this.

Re. cursor line.. ya, good question. I made a new issue about it: #60


Typo fixes runtime error - user_email => writer_email

Make sure to terminate  with  instead of .
Have not created an issue since the fix is trivial.

cla: I signed it!

Thanks!


select2 first value id is null

select2 first element id is coming empty.how to get first element id of select item.
i  using this code to get id
 var id=$(this).select2('data').id;

it is working for all option but first element of select is not coming.i need first element id and call ajax on that

This appears to be more of a usage question than a bug report or common feature request.  As we continue to keep the Select2 issue tracker geared towards these two areas, bug reports and common feature requests, we are redirecting usage questions to other communities such as the mailing list, IRC, or Stack Overflow.


fix(Avatar): Add max-height to avatar element (#143)

After a lot of research, I believe this should be the least collateral solution to this problem. Any suggestion is welcome.

This doesn't seem to solve the issue, I'm still seeing the following issues.
Gmail (Chrome):

Outlook 2021 (Win 10)

Gmail (Chrome):

Yahoo! (Chrome):

I couldn't test it on Outlook as I don't have access to an Email there.

I don't think the Avatar component should have default style other than the styles that actually matter for email.
For example, component size, color, bg color, radius, etc should be input by the user, not by us. We should only add style like this to fix email client acting weird on base components.


Replace assert with warning in error event processing

Fixes an issue introduced in PR #7809.
Replaced the ink_release_assert with a warning so we can gain information about this situation.

We have been running this in our production.  Vinith looked up the messages we received.  50 over our footprint in a 4 hour period.  Most of them are just EPOLLERR (0x8).  A least one also had EPOLLHUP (0x18).  May be ok to just ignore them.  Or to pass them along via a write event as this PR does.

Cherry-picked to v9.1.x branch.


Add testing to check if configuration changes are applied successfully

The kcconf.py script does not work with the double quotes according to my tests. It worked after removing them.

Hmm.. Maybe some tests would be in order to check config files after startup.

Originally posted by @fbartels in https://github.com/zokradonh/kopano-docker/pull/218#issuecomment-523605703

Unit testing framework or simple bash script (something like https://blog.jevsejev.io/2016/06/09/docker-image-tests/)?
Should test startup of containers with various changes to .env. Test if additional packages are installed, etc.

A first shot at using goss has been merged. Goss could also be used to implement a healthcheck for each container, see https://github.com/aelsabbahy/goss-docker.
The above change is not yet part of the actions performed in Travis.

While goss is nice for general verification of the image (and subsequently doing healthchecks) without additional scripting it does not really seem capable of testing different container configurations.
Maybe https://github.com/SimonBaeumer/commander could be a good fit?
Something like:

wrapper script similar to gcgoss that copies commander binary and test description into the container
container would be started with docker-compose run kopano_server sh (which means kopano-server would not be started)
run startup script repeatably with changing env vars and check configuration files

This issue is no longer required, some of the containers now have tests based on goss and commander. The next steps is setting up github actions to execute them on regular intervals (as doing it on each commit will impact test runtime too much).


Feature request: Monospace

Hi BC-Sans team, linux-land software developer here. Is there a monospace variant I'm missing in the docs? It doesn't show up in the FAQ, or seem to have been hit during the project's ascendance thus far. (Looked through your issue history.) If there is monospace, I'd love a link, and sorry I missed it in my search. Anyway, if this is a new feature request: I would LOVE a monospace version of this font. The sales pitch is basically this:
I'm the software R&D lead behind a BC-based industry leader, delivering some products to BC fisheries as our entrance onto the global market as a green-energy leader. Our technology offering will need to natively support a host of indigenous languages in order for our (low-funding) work to really take off. Our software in particular will be the only software on the market that natively supports the indigenous languages of the nations or global regions entering our market. Most of my personal time is spent in monospace, and it does have a measurable impact on the pacing of my productivity. If the effort has the right sorts of outputs, I suspect I can bring indigenous language support to the broader linux world, and others in my (currently quite productive) cohort. For example, I would like to get it included (insofar as we can) as an optional default display in the Firefox browser. Your steps in the How-To could start with "Option 1: Use Firefox, it's faster lately, seriously supports your data's security at all the platforms our software will end up utilizing, and supports your privacy better against AIs and the like."
I can integrate as much of my coding or project-management time is required for the project, to expand scope of the project as much as possible - for example, I imagine you've noticed the spellchecker of your browser sometimes doesn't like Canadian words very much. I think BC in particular can do this really well.

Found the landing page you send to most in-gov developers, but just a heads up I'm a different audience.
As an aside, for my particular task today, I'd love a test string to demonstrate to myself that my Firefox install of the font is in fact showing the custom BC-Sans characters. I also saw the internal data you use for testing your pipelines, but it's not really digestible as a test string ;)

Oh I should add, my wife is @caggles , I understand the processes.

I should add: for now, a string of test characters would be fantastic for my immediate work. Afterwards, if feasible, a monospace version of the font would be a huge deal.


img_pygame: Fix loading of binary alpha formats

Fixes Pygame imageloader for binary alpha formats, passes imageloader test 100% after this. It just forces  the conversion process if a colorkey is present, which gives us an alpha channel

@bionoid thanks 👍


Sub badges not showing

Checklist

[X] I'm reporting a problem with Chatterino
[X] I've verified that I'm running the most recent nightly build or stable release
[X] I've looked for my problem on the wiki
[X] I've searched the issues and pull requests for similar looking reports

Describe your issue
Whenever I open Chatterino I get "Failed to load channel badges - OAuth token is missing ".
I've tried clearing cache, I've reinstalled 2.5.1 multiple times. Now I've tried 2.4.3 which makes me able to see every other badge besides sub badges.
Screenshots
No response
OS and Chatterino Version
Chatterino 2.4.3 (commit 379cc576) built with Qt 5.15.2, Windows SDK, MSVC 193431944, Crashpad Running on Windows 10 Version 2009, kernel: 10.0.22631

Just login. OAuth token missing means that you are not logged in. Twitch made badges require authentication

When im using 2.5.1 instead of 2.4.3 while logged in, I still cant see any badges, it will only show the Chatterino Supporter badge and the FFZ Supporter badge


fix: 修复 datepicker 下拉样式问题

🤔 这个 PR 的性质是？

[x] 日常 bug 修复
[ ] 新特性提交
[ ] 文档改进
[ ] 演示代码改进
[ ] 组件样式/交互改进
[ ] CI/CD 改进
[ ] 重构
[ ] 代码风格优化
[ ] 测试用例
[ ] 分支合并
[ ] 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

fix(组件名称): 处理问题或特性描述 ...

[x] 本条 PR 不需要纳入 Changelog

☑ 请求合并前的自查清单
⚠ 请自检并全部勾选全部选项。⚠

[ ] 文档已补充或无须补充
[ ] 代码演示已提供或无须提供
[ ] TypeScript 定义已补充或无须补充
[ ] Changelog 已提供或无须提供

Codecov Report

Merging #1276 (fe6e451) into develop (492d477) will increase coverage by 0.28%.
The diff coverage is 41.24%.

:exclamation: Current head fe6e451 differs from pull request most recent head c667192. Consider uploading reports for the commit c667192 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1276      +/-   ##
===========================================
+ Coverage    57.94%   58.22%   +0.28%
===========================================
  Files          407      408       +1
  Lines        15371    15290      -81
  Branches      2931     2883      -48
===========================================
- Hits          8907     8903       -4
+ Misses        6187     6111      -76
+ Partials       277      276       -1

Impacted Files
Coverage Δ

src/cascader/cascader.tsx
64.00% <ø> (ø)

src/color-picker/color-picker.tsx
81.25% <ø> (ø)

src/date-picker/DatePicker.tsx
26.74% <ø> (ø)

src/date-picker/DateRangePicker.tsx
15.82% <ø> (ø)

src/date-picker/base/Header.tsx
7.57% <0.00%> (-0.37%)
:arrow_down:

src/date-picker/date-picker-panel-props.ts
100.00% <ø> (+90.00%)
:arrow_up:

src/date-picker/date-range-picker-panel-props.ts
100.00% <ø> (+90.90%)
:arrow_up:

src/date-picker/date-range-picker-props.ts
42.85% <0.00%> (-11.69%)
:arrow_down:

src/date-picker/hooks/useRange.ts
35.89% <ø> (ø)

src/date-picker/hooks/useSingle.ts
37.28% <ø> (ø)

... and 45 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[ENH]: add apply_function method to epochs and evoked objects

Reference issue
Fixes #8346.
What does this implement/fix?
first proposed version on how apply_function can be added to epochs and evoked objects. At the moment, just implementing the function to epochs objects. This follows the apply_function implemented in raw objects.
Additional information
CC with @nordme

just notice: why a commit for another branch is being shown in this PR?

@vpeterson can you have a look at the CI issues? thcx

Just a few nitpicks. Looks very nice!

@wmvanvliet thank you!

We added the apply_function now also to evoked object with @nordme.
Let us know how the changes look like @larsoner @wmvanvliet

Hi everyone! We think that we are ready for the final review with @nordme
@drammock, let us know how the PR looks.

@wmvanvliet can you look again and see if your request for changes is satisfied?


(LK-C-5) Add controlled generator (1-qubit) support for Lightning Kokkos

Before submitting
Please complete the following checklist when submitting a PR:

[ ] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests directory!

[ ] All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running make docs.

[ ] Ensure that the test suite passes, by running make test.

[ ] Add a new entry to the .github/CHANGELOG.md file, summarizing the
change, and including a link back to the PR.

[ ] Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.

Context:
This PR adds support for 1-qubit controlled generator (RX/RY/RZ/PhaseShift/GlobalPhase) to Lightning Kokkos.
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-76777]

Python tests are not added here yet, they will be added when adjoint is supported in LK-C-7

I have also removed the params argument to generators, because generators do not depend on parameters


[Event Request] Codeunit 5760 "Whse.-Post Receipt" function InitSourceDocumentLines

Dear ALAppExtensions Team,
We would like to request the following event publisher in codeunit 5760 "Whse.-Post Receipt" function InitSourceDocumentLines
         OnBeforePurchLineModify(PurchLine, WhseRcptLine2, ModifyLine);
         if ModifyLine then
               PurchLine.Modify();
         until PurchLine.Next() = 0;
         // DINNL <<
         DINOnInitSourceDocumentLinesAfterModifyPurchLines(PurchHeader);
         // DINNL >>
       end;
   DATABASE::"Sales Line": // Return Order

local procedure DINOnInitSourceDocumentLinesAfterModifyPurchLines(PurchaseHeader: Record "Purchase Header")

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


So... What is Pixi Flex?

Hello,
I've just been browsing the DDD Conference website and saw that @GoodBoyDigital will be giving an interesting workshop focused on Pixi Flex. But a quick search for “Pixi Flex” turned up absolutely nothing, except for the page of said workshop.
Is Pixi Flex a brand new exciting thing that's yet to be announced, or is it an alias for something I'm not aware of?
Thanks!

I believe Pixi Flex refers to the new geometry-based rendering system that @GoodBoyDigital has been working on for the v5 branch. WE should have more to share as we actually get the branch going :)


Timestamp does not match response format

I was getting "Invalid timestamp" exception when fetching responses

Thanks! This is now released as v1.1.2


ci: test with 3.11 in all OSes

Codecov Report
Base: 77.81% // Head: 77.92% // Increases project coverage by +0.10% :tada:

Coverage data is based on head (0567c76) compared to base (6e6dc47).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
+ Coverage   77.81%   77.92%   +0.10%
==========================================
  Files          21       21
  Lines         915      915
  Branches      142      142
==========================================
+ Hits          712      713       +1
- Misses        176      177       +1
+ Partials       27       25       -2

Impacted Files
Coverage Δ

src/dvc_task/worker/temporary.py
80.32% <0.00%> (ø)

src/dvc_task/contrib/kombu_filesystem.py
39.28% <0.00%> (ø)

tests/worker/test_temporary.py
96.96% <0.00%> (+3.03%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Increase naming length limit to 128 characters

Increase naming length limit to 128 characters
We have use cases that have table or column names greater than the 64 characters limit.
The restriction makes it's hard for us to adopt Starrocks in our production.

https://github.com/StarRocks/starrocks/pull/10005
Will this meet your requirements?

#10005 Will this meet your requirements?

Yes. Thanks for the quick reply.
Look forward to this feature.


Add note about setting proxy for bootstrap.

Users may not expect that bootstrap.sh goes out and fetches things from
the internet. If internet access requires a proxy, they won't know that
they need to set up the proxy environment variables before running
bootstrap.
We can't tell them exactly how to set up their proxy, but they should
know how to do that if it's required. We just need to make them aware
that bootstrap requires internet access.
Fixes #473

LGTM


After upgrading to 8.8, GetCredtialAsync() creates Internal Firebase Error

Operating system: Windows 10 Home
Operating system version: 20H2
Version of Unity: 2021.2.8f1
What steps will reproduce the problem:

Create blank Unity project
Install Firebase.Auth plugin version 8.8 (latest)
Install Google Play Services for Unity version 10.14 (latest)
Create a script that checks firebase dependencies, then creates the app, then calls auth.SignInWithCredentialAsync()

OR -
Download and run the blank project I created to demonstrate this problem: Google Drive Public Link

What is the expected result?
That auth signin will work correctly, as it did before upgrading from 8.0 to 8.8
What happens instead of that?
Internal Firebase Error - no further details given.
Please provide any other information below, and attach a screenshot if possible.
Hello,
I have a Unity game I've been developing with Firebase for over a year. I first created the Authentication process back during I think version 6.0 of Firebase for Unity. Since then I was able to upgrade twice without issue.
However, after upgrading from 8.0 to 8.8, GetCredentialAsync() creates an internal firebase error with no debug information. I've

Downloaded the latest version of Firebase for Unity (from https://firebase.google.com/download/unity)
Updated Google Play Games for Unity to the latest version, 0.10.14 (from https://github.com/playgameservices/play-games-plugin-for-unity)
Checked Unity logs which show no sign of error
Ensured my project number, project id, and client id in google-services.json match what's in firebase console
Tried using different email/password user accounts to log in
Created a new blank project with only the firebase auth plugin, google play games plugin, and GetCredentialAsync() code. See Google Drive Public Link

Note 1:
Even in the new project, Google Version Handler is prompting me to delete version 1.2.167 of Google.IOSResolver.dll, JarResolver.dll, PackageManagerResolver.dll, and VersionHandlerImpl.dll. Is this expected behavior?
Note 2:
Because I won't post my app secret config here, you'll need to supply your own google-services.json to Assets folder and edit AuthTest.cs:86 with your app config. Likewise, you'll need to set the email and password on line 23 to a user registered with Email Signin to your project.

Please help me with this error. Since Firebase doesn't host old versions of the plugins (and I don't commit plugins to version control) I'm unable to downgrade and undo the change.

CJ

@cjcurrie
Sorry to get you back this late.
About your note 1, yes, that should be normal because Firebase and Play Game Plugin includes different version of EDM4U.  Version Handler was basically trying to remove the older version of EDM4U.
Also, you should be able to get Firebase version back to 6.13.0 here. But make sure that you are using .Net 4.x.
https://developers.google.com/unity/archive#firebase

Are you experiencing this issue on desktop (Windows/macOS/Linux) or mobile (iOS/Android) device?
Are you still experiencing the same issue with later version of Firebase SDK?


Add location info for targets being echoed

Mostly for metrics purposes, it would be very helpful if the targets specified to be echoed have an additional location field.
Because differents users/orgs perceive/treat location differently, what would suffice is for this location field to be a single string field.

Resolved with https://github.com/uber/arachne/commit/0a8f949186f73df6b962bd5e1ef8cb929d45bbd2


chore: eliminate the manual steps to start local development

Description
This commit allows developers to run yarn dev and start development without any additional manual steps.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Manual validated the local development environment

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Legal
This project is available under the Apache 2.0 License.

Looks good!


feat: support patch crds conversion

Signed-off-by: huangminjie<EMAIL_ADDRESS>support this pr https://github.com/kubevela/kubevela/pull/3890

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: JarHMJ sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


icu: bugfix #71142 - Fixes icu-config reporting bad location

Motivation for this change
Copied from issue# 71142:
Describe the bug
While attempting to build some software, I have discovered that icu-config --incpkgdatafile returns the wrong location which causes my downstream build to fail.
To Reproduce
Steps to reproduce the behavior:
[red@apophenia:~/projects/ltfs]$ nix-shell -p icu

[nix-shell:~/projects/ltfs]$ icu-config --incpkgdatafile
/nix/store/vb7zl9wdbmgkkfdkzvklh87lv29mxbds-icu4c-64.2/lib/icu/64.2/pkgdata.inc

[nix-shell:~/projects/ltfs]$ ls -la /nix/store/vb7zl9wdbmgkkfdkzvklh87lv29mxbds-icu4c-64.2/lib/icu/64.2/pkgdata.inc
ls: cannot access '/nix/store/vb7zl9wdbmgkkfdkzvklh87lv29mxbds-icu4c-64.2/lib/icu/64.2/pkgdata.inc': No such file or directory

@jtojnar provided a suggested patch which I have now applied and tested.  It resolves the issue and doesn't break any downstream packages that I have detected.
Things done
Applied suggested patch and created this PR

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @raskin @jtojnar @shlevy

I think it should go to staging

I think it should go to staging

I'm still a little new around these parts, so I'm guessing that means using a different branch other than master?
Which would you like me to set it against?
Also - I guess since we're jumping branches I would need to open a second PR?
So, do that and leave this one in limbo?

Staging is the staging branch, this is the branch where large non-time-critical rebuilds get accumulated for some time before forcing a mass rebuild on master. I think GitHub allows you to edit Pull Request and change the target branch.

https://github.blog/2016-08-15-change-the-base-branch-of-a-pull-request/

Staging is the staging branch, this is the branch where large non-time-critical rebuilds get accumulated for some time before forcing a mass rebuild on master. I think GitHub allows you to edit Pull Request and change the target branch.

Done!


BaPictureUploader: Can't get the onUploadCompleted event!

I'm submitting a ...
[ ] bug report
[ ] feature request
[ X ] question about the decisions made in the repository

What is the current behavior?
I want to get the uploaded image in my form by found no example how to do this in layouts.* example. Got a look at the component BaPictureUploader and saw that there was two events available: onUpload and onUploadCompleted.
I tried to use them without success:

        <ba-picture-uploader [picture]="user.image" [defaultPicture]="defaultPicture"
          [uploaderOptions]="uploaderOptions" (onUploadCompleted)="pictureUploaded()" (pictureChange)="pictureUploaded()"></ba-picture-uploader>

My method pictureUploaded() never got called.
I surely didn't get the behavior of this control :(.
Any clue?
Thanks a lot in advance.
Serge.

I added a method in the component to return the image content to save it only when the user's form is posted

this works for me
change this
  @Output() onFileUpload = new EventEmitter<any>();
 @Output() onFileUploadCompleted = new EventEmitter<any>();
to this
@Output() onFileUpload: EventEmitter<any> = new EventEmitter<any>();
@Output() onFileUploadCompleted: EventEmitter<any> = new EventEmitter<any>();


Can you please upload the pretrained model?

Thank you!

Sure, I have uploaded a pretrained model both in pytorch and OpenVINO.
Hope it helps. Thanks.
61da1b7fe61111355f9329c7c0db20b2ecd0a411

I have uploaded a pretrained model b

I tried to do the prediction using ur models but getting the following error:
RuntimeError: Error(s) in loading state_dict for Encoder:
Missing key(s) in state_dict: "conv.18.weight", "conv.19.weight", "conv.19.bias", "conv.19.running_mean", "conv.19.running_var", "conv.21.weight", "conv.22.weight", "conv.22.bias", "conv.22.running_mean", "conv.22.running_var", "conv.24.weight", "conv.25.weight", "conv.25.bias", "conv.25.running_mean", "conv.25.running_var", "conv.27.weight", "conv.28.weight", "conv.28.bias", "conv.28.running_mean", "conv.28.running_var".
size mismatch for conv.9.weight: copying a param with shape torch.Size([256, 256, 1, 3]) from checkpoint, the shape in current model is torch.Size([256, 256, 1, 5]).
size mismatch for conv.12.weight: copying a param with shape torch.Size([256, 256, 1, 3]) from checkpoint, the shape in current model is torch.Size([256, 256, 1, 5]).


Dawson153-Mobile Implement Art Assets Push 1

Berry Bushes And Trees Implemented and Rotated

Island Heart And Drone Art Implemented

Closing this since you changed tasks. You can make a new pull request if I'm confused.


expected return code for redfish.account_service.test_user_account.Verify Error While Deleting Root User ?

This test is failing on 3 different platforms: two BMCs from different OEMs and romulus running on qemu.
The three are returning a 404 for the redfish DELETE to /redfish/v1/AccountService/Accounts/root but the test is expecting a 403.
Are the implementations correct or is the test correct?

@rahulmah can you check on this one

or @manashsarma @prkatti1 Have you seen this one in recent testing?

Yes, George . I think it is a similar issue I raised already through defect -
SW530782 : FTC1020:Rainier: HTTP return code is not uniform in service related forbidden operations with Redfish

@manashsarma : That issue is specific to service login. We should have a separate one for root user to get this one fixed.
@gkeishin : We should be getting response status code like 405 (Method Not Allowed) for this operation. At present we are getting not found error. Let me ask @AshwiniC777 to take care of this.
{
  "error": {
<EMAIL_ADDRESS>[
      {
<EMAIL_ADDRESS>"#Message.v1_1_1.Message",
        "Message": "The requested resource of type #ManagerAccount.v1_4_0.ManagerAccount named root was not found.",
        "MessageArgs": [
          "#ManagerAccount.v1_4_0.ManagerAccount",
          "root"
        ],
        "MessageId": "Base.1.8.1.ResourceNotFound",
        "MessageSeverity": "Critical",
        "Resolution": "Provide a valid resource identifier and resubmit the request."
      }
    ],
    "code": "Base.1.8.1.ResourceNotFound",
    "message": "The requested resource of type #ManagerAccount.v1_4_0.ManagerAccount named root was not found."
  }```

@gkeishin

Is there any update? I also have the same error. Is it possible that the response code is wrong?

@rahulmah can you check on this and update

The judgment of ec.value==5 should be added to this. Although I don’t know what 5 is, this is the result of the test. Another question is that the auto-test hopes to be 403. Does the current error message support 403?
https://github.com/openbmc/bmcweb/blob/20fa6a2c6cea77a4b411634dfca67eef6c8f430f/redfish-core/lib/account_service.hpp#L2102


Code over complex ?

Is it really necessary to use a call back to call a simple method ?
https://github.com/image-js/image-js-typescript/blob/04f73e6f3f6cf700975760c34707aa07442f37c1/src/roi/Roi.ts#L125-L129
https://github.com/image-js/image-js-typescript/blob/04f73e6f3f6cf700975760c34707aa07442f37c1/src/roi/Roi.ts#L331-L341
For me it makes the code very complex to read and to maintain (and also to contribute in fact).

I agree. We should only use #getComputed when the computation has a big performance cost.

TODO:
remove #getComputed from ped and eqpc


What to do if there are two functions with the same name in two different files

What to do if there are two functions with the same name in two different files, but the paths of the OpenAPI do not allow the existence of functions with the same name

Does this work?
use mod1::foo as foo1;
use mod2::foo as foo2;

yeah, thanks for your answer！

Great. Could you please close the issues that have been resolved?


Extension is watching files outside of the workspace

Issue Type: Bug

Behaviour
Expected vs. Actual
Expected: Python extension does not watch files outside of the workspace
Actual: Log (Window):
[<timestamp>] [renderer15] [error] [File Watcher (parcel)] Inotify limit reached (ENOSPC) (path: <some/path/that/is/not/the/workspace>)

where the path is sometimes a neighbouring python project workspace or ~/.conda/envs/<env_name>/lib/python3.9. The neighbouring projects in question are not imported by any of the python files in this workspace.
Steps to reproduce:

Open a python project workspace

Additional context
This only started happening recently.
If I disable the Python extension for the workspace and close + reopen, I don't get the ENOSPC error until I re-enable the extension.
$ cat /proc/sys/fs/inotify/max_user_watches
32768

Diagnostic data

Python version (& distribution if applicable, e.g. Anaconda): 3.9.10
Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Conda
Value of the python.languageServer setting: Pylance

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

N/A

User Settings

condaPath: "<placeholder>"

languageServer: "Pylance"

linting
• flake8Enabled: true
• mypyArgs: "<placeholder>"
• mypyEnabled: true
• pycodestylePath: "<placeholder>"

formatting
• autopep8Args: "<placeholder>"

testing
• pytestArgs: "<placeholder>"
• pytestEnabled: true

Extension version: 2022.8.0
VS Code version: Code 1.67.2 (c3511e6c69bb39013c4a4b7b9566ec1ca73fc4d5, 2022-05-17T18:23:40.286Z)
OS version: Linux x64 3.10.0-1160.66.1.el7.x86_64
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Xeon(R) CPU E5-2690 v4 @ 2.60GHz (4 x 2599)

GPU Status
2d_canvas: unavailable_softwarecanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: disabled_softwaremultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: disabled_offrasterization: disabled_softwareraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: disabled_softwarevideo_encode: disabled_softwarevulkan: disabled_offwebgl: unavailable_softwarewebgl2: unavailable_software

Load (avg)
2, 2, 2

Memory (System)
7.62GB (0.59GB free)

Process Argv
--unity-launch --crash-reporter-id 4cb3165e-6680-471f-992f-0c1e623756f7

Screen Reader
no

VM
100%

DESKTOP_SESSION
1-gnome

XDG_CURRENT_DESKTOP
GNOME

XDG_SESSION_DESKTOP
1-gnome

XDG_SESSION_TYPE
x11

I've now identified an even worse culprit: https://github.com/microsoft/vscode/issues/151744
Still, I wouldn't expect the python extension to watch neighbouring project folders

@MetRonnie Perhaps use this to avoid the TypeScript resource draining.
{
    // This increases VS Code speed
    /*
       - source: https://dev.to/rmorabia/how-to-make-visual-studio-code-150-faster-in-large-projects-3eag
       - Why? Dangerously loud laptop fan
    */
    "typescript.disableAutomaticTypeAcquisition": true
}

The watcher set in the original bug report is caused by Pylance, transferring this.


Is there a way to add a jwt in response body on renew?

I'm looking for a way to add renewed token to the body of the action response like it is done in the authenticate action handler in play-silhouette-angular-seed example.
Implementation like this doesn't help - there is token in the header but not in the body:
def renew = SecuredAction.async { request =>
  request.authenticator.renew(Future.successful(Ok))
}

May be I can do the same directly:

retrive the authentificator by loginInfo
discard it
generate a new one
embed it into header
put in into body

Is it correct? Thank you!

Yes, you could do the same directly. But this does currently not work because the access to discard is restricted. We work on a solution. Please follow #323

Thank you!


Responsive Design

After the Addition of scientific Notation, it is no longer responsive. I would highly appreciate it if someone solved this issue.

hello bro, I can do this....can you please assign me this task...

Sure @mohtasheem135

Best of luck

Getting this error message bro ....
remote: Permission to Ctoic/Calculator-using-HTML-CSS-JS.git denied to mohtasheem135.
fatal: unable to access 'https://github.com/Ctoic/Calculator-using-HTML-CSS-JS.git/': The requested URL returned error: 403

It is because the base code changed after you forked the repository.  Fork the current version of repo again and try.

I have added new issues you can try them as well and I will merge them.

It is because the base code changed after you forked the repository. Fork the current version of repo again and try.

I don't think that is the issue....There is some kind of permission issue I also don't know exactly the reason but again its showing the same problem.

Other Contributors are contributing they are not facing any issues @mohtasheem135 but I will look at this again. Hopefully, I will fix it.

I am really sorry bro .....it was actually my mistake
I have made the PR  ....  please use the hactoberfest tag

I have merged your pull request. Don't forget to star the Repository ⭐


Warning: the query argument to createHref is deprecated; use a location descriptor instead

I copy the code from doc and see this error, how do I fix it?
https://github.com/rackt/react-router/blob/master/docs/Introduction.md#with-react-router
return (

App

<Link to="/about">About</Link>

<Link to="/inbox">Inbox</Link>

		{this.props.children}

);

I can not find any solution for me inside CHANGES.md
https://github.com/rackt/react-router/blob/master/CHANGES.md#accessing-location

The same issue with this dependencies below

Related to #2668 ?

Yes

-> https://github.com/rackt/react-router/issues/2669

waiting for the new release


docs: Update to advise on preferred indented macros in integration docs.

I have update the integrations documentation to advise on the correct
macros to use now we prefer the indented macros.

Testing plan:
GIFs or screenshots:

Nice, merged, thanks @adambirds!


Add means to collapse a Scale card on dashboard and display pages

added to dashboard only to keep Card style on display page


Fixed weekday bug in vehicle.py

Line 628 contained incorrect reference to day, renamed it to weekdays. Should now return the correct schedule array.
I have not been able to test any of this, since I don't know how to incorporate the code edit in my home assistant instance.

I have reviewed the code but the "days" variable should be correct. The string sent to the API should be in the "yynnyny" format.

Ok, but then the logic is still faulty. It currently filters only the ‘y’ and hence returns incorrect strings. E.g. yynnyny become yyyy. My logs confirm this, see this issue.

I looked at the code again, didn't have time in a while, sorry. I believe that the check on line 627 in vehicle.py needs to be roved. If you look at the debug info in the post linked above you can see that this check basically filters all 'n's from the array. But as you correctly mentioned, the api expects a length 7 array. Do you want me to create a pull request for this?

I will reopen this and take a look in the near future now when I have some spare time

Closing this PR since the change is incorporated since a while back.


Investigate networktables update rate

Currently networktables is being used as a global key/value store for inter-submodule communication (e.g. drive subsystem with vision subsystem). Over the network, it is limited to a 10Hz update rate by default and convention. The robot control rate is 50Hz and it would be preferable for on-robot inter-submodule communication to operate at that rate at minimum.

[ ] Investigate whether the 10Hz networktables update rate only limits network updates or local updates as well
[ ] If the networktables rate is limited to 10Hz in all cases, investigate alternatives for inter-submodule communication (thread-safe dict, lightweight database, etc)

10hz update rate only affects network update rate

Thanks @virtuald, good to hear from an expert :smile: Per other discussions it may be somewhat of a moot point if NT-based usage incurs performance penalties that preclude heavy high-rate usage anyway.


build(.releaserc.json): deprecated updateVersion.sh in favor of semantic-release replace plugin

:tada: This PR is included in version 4.0.25 :tada:
The release is available on:

v4.0.25
GitHub release

Your semantic-release bot :package::rocket:


Deserializer as a function

Resolves #59

Cool stuff. The FunDeserializer should be moved to cakesolutions.kafka package, and a helper constructor should be added for converting a Array[Byte] => T function to Deserializer[T]. E.g:
object KafkaDeserializer {
  def apply[T](f: Array[Byte] => T): Deserializer = new FunDeserializer(f)
}

Thus KafkaConsumer.apply can still remain compatible with existing deserializers and at the same time you would have a (relatively) nice way for hooking up deserializer functions to consumers.
KafkaConsumer.Conf(
    ...,
    keyDeserializer = ...,
    valueDeserializer = KafkaDeserializer(bytes => convertBytes(bytes))
)

Similar API for serializers would nice too.


[MM-41392] Clean path name on browser pushes for subpaths

Summary
When navigating on a server with a subpath, the path name of the server URL would be included when sending URLs back and would be append to the pathname (eg. for a server with site URL: http://myserver.com/subpath, urls would end up being http://myserver.com/subpath/subpath/<rest of url>)
This PR cleanses out the subpath from the pushed URL and pushes back the pathname without the server URL subpath.
Ticket Link
https://mattermost.atlassian.net/browse/MM-41392
NONE

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/desktop/17139
https://circleci.com/gh/mattermost/desktop/17138
https://circleci.com/gh/mattermost/desktop/17137

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/desktop/17139
https://circleci.com/gh/mattermost/desktop/17138
https://circleci.com/gh/mattermost/desktop/17137


Update how-to-guides.md

Small updates:

changed "techdocs-plugin" to "TechDocs plugin", for consistency with how Search plugin is mentioned earlier in the doc
changed reference to "getting started guide" to correspond w the guide's heading (Getting Started with Search)
minor text edits

Signed-off-by: Bodil Björklund<EMAIL_ADDRESS>

Sigh. I did fix what caused the previous prettier issues. Or so I thought. Need to get my vscode editor to show formatting errors!


use gpt-3 to explain the rholang vote

nifty idea by @TheoXD

It already can simplify legal documents and vice versa, generate fully functioning react applications out of plain english descriptions, so I think it would be cool to present users with a simple explaination behind any rholang code before signing, like for example
"By signing you grant this application to:  Send 1 revlette to <...>, send1 revlette to <...>, send 1 revlette to <...> and send 1 revlette to <...>."

I wonder if "... you grant this application to..." is simpler than the explanation provided by the existing UI: the form with radio buttons.
That is: the plain English version of what they're signing is more like "vote yes on Wiley E. Coyote for board member".


Plugins that only support one Platform currently need dummy boilerplate for the other platform

It is totally possible to have plugins that only make sense on one of the supported platforms (e.g. a Plugin that launches an Android Intent doesn't make sense on iOS). Users might want to still use these plugins in their cross-platform app (and guard calls to them with platform.isAndroid). Currently, the only way to make this work is to include a lot of boilerplate dummy code in your plugin for the platform your plugin is not supporting to make the Flutter build system happy. It would be better if Flutter could detect that a plugin dependency is e.g. Android only (for example by realizing that the plugin is missing an iOS subdirectory) and if that's the case Flutter should stop including that plugin in the generated platform registry for the unsupported platforms.
/cc @mehmetf who ran into this with the Android-only android_intent plugin
/cc @mit-mit and @mravn-google for opinions

Agree we should fix this; see also https://github.com/flutter/flutter/issues/10288 which should enable this

We need to fix this prior to 4; we are already seeing plugins published that look like they support both platforms but really only support one. We have to fix that or we get a polluted ecosystem.

Leaving this in the current milestone because this is important plugins framework maintenance work.

Postponing to milestone 4.

This was resolved a while ago; plugins can have arbitrary subsets of platforms now.


⚠ Bofrost.be has degraded performance

In 6089121, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 871 ms

Resolved: Bofrost.be performance has improved in 5971b8e after 35 minutes.


Unable to locate module github.com/rupor-github/win-gpg-agent/misc

When I execute go get, I'm getting
github.com/rupor-github/win-gpg-agent/cmd/agent imports
        github.com/rupor-github/win-gpg-agent/misc: cannot find module providing package github.com/rupor-github/win-gpg-agent/misc

The dir misc doesn't exist in the repo and the three binaries call to misc.GetVersion().

Project is being built by cmake file (which is included) - and that is how versions.go is generated :) I am not interested in supporting "go get" or "go install".


Unused

Function util.GroupsFromRegex in according to https://codecov.io/gh/elliotchance/c2go/pull/308/src/util/regexp.go not used
File util/test.go not used in according to https://codecov.io/gh/elliotchance/c2go/pull/308/src/util/test.go

Please clarify - Is it some debug tools?

Good catch. The easiest way to test if its not used is to rip it out and see if the build still passes ;)

Now, after #344 , it is not so easy.
Some code if not need in according to codeconv, but need for transpiling sqlite.
So, removing unused part will be only after solving all problems.


Integration: Add triple integral

I've recently encountered the need to perform triple integration over tetrahedral regions. To address this, I've added a very simple yet convenient 3D integral method to the GaussLegendreRule class.
Regarding the method name, since the 2D integration method is called OnRectangle, I've named the 3D integration method OnCuboid. However, I'm uncertain if this name is appropriate.

Thank you!


fix: temp fix for home > fi

#144  👈
development

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Hessuew and the rest of your teammates on  Graphite


fix: change deprecated treesitter query method get_query to get

fix warning of (will be) deprecated treesitter query method

from get_query to be get

Thanks! Could you add a conditional to check if the function exists so that we don't break things for potential users that havent updated their nightly yet?
I think something like this should work:
local highlighter_query = vim.treesitter.query.get and vim.treesitter.query.get(tree:lang(), "highlights") or vim.treesitter.query.get_query(tree:lang(), "highlights")

@seblj I've added the ternary, and reminder comment. you may remove if you don't like TODOs I guess
please check 😄


Parameterize not ready

Hello Douglas, this feature isn't working as confirmed by Azure engineer. I have opened a ticket with Azure, see ticket number, SR<PHONE_NUMBER>00189, or speak to  Jayasree Parvataneni (MINDTREE LIMITED<EMAIL_ADDRESS>who has confirmed that its not working.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2bf75315-da09-2cf9-6db5-d12fcc804283
Version Independent ID: bf4deb1b-fe88-a9cb-3605-0500a60fb882
Content: Parameterize linked services in Azure Data Factory
Content Source: articles/data-factory/parameterize-linked-services.md
Service: data-factory
GitHub Login: @douglaslMS
Microsoft Alias: douglasl

@cpatte7372 What is it on this page of the documentation that I need to correct or clarify?

Hi Douglas,
My apologies, there isn’t a problem with the documentation. The problem is with the actual parameterization itself. It’s a technical problem. The problem has been acknowledged by Azure and they’re trying to fix it. Please get in touch with Azure representative in attached email for details.
Thanks
Carlton
From: Douglas Laudenschlager<EMAIL_ADDRESS>Sent: 29 October 2018 22:32
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: cpatte7372<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Parameterize not ready (#17877)
@cpatte7372 https://github.com/cpatte7372  What is it on this page of the documentation that I need to correct or clarify?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/MicrosoftDocs/azure-docs/issues/17877#issuecomment-434105233 , or mute the thread https://github.com/notifications/unsubscribe-auth/AXd82d_R4Izk0MAUmDx4DSbtUyZj1ig1ks5up4HDgaJpZM4YAsY6 .

Sorry my login wouldn't work, and was unable to close


Revert "Merge pull request #21941 from markdroth/xds_logging"

This reverts #21941 due to ongoing distribtest failures that we're still investigating.

The "Basic Tests Python Linux" problem is a failure fetching an external dependency.


Documentation page not served correctly when authentication is enabled

Context

hapi-swagger 7.7.1:
hapi-auth-jwt2 7.3.0:

What are you trying to achieve or the steps to reproduce ?
When the hapi-auth-jwt2 plugin is enabled, by default it adds auth to all routes, hapi-swagger is excluding settings.documentationPath from authentication but it is not excluding the static resources for that page to render correctly and therefore only a single unstyled link with "swagger" as the text is displayed.
If I make the changes as shown below to index.js everything is fine, look for // >> comments.
// add documentation page
      if (settings.documentationPage === true)
      {
        pluginWithDependencies.route([{
          method: 'GET',
          path: settings.documentationPath,
          // >> this config line already exists
          config: {
            auth: settings.auth
          },
          handler: (request, reply) =>
          {
            reply.view('index.html', {});
          }
        }]);
      }

      // add swagger UI if asked for or need by documentation page
      if (settings.documentationPage === true || settings.swaggerUI === true)
      {
        pluginWithDependencies.route([{
          method: 'GET',
          path: settings.swaggerUIPath + '{path*}',
          handler: {
            directory: {
              path: swaggerDirPath + Path.sep,
              listing: true,
              index: false
            }
          },
          // >> the config/auth lines below are added
          config: {
            auth: settings.auth
          },
        }, {
          method: 'GET',
          path: settings.swaggerUIPath + 'extend.js',
          config: {
            files: {
              relativeTo: publicDirPath
            },
            // >> the line below is added
            auth: settings.auth
          },
          handler: {
            file: 'extend.js'
          }
        }]);
      }

this is my jwt-auth initialization:
function initializeJwtAuth(server)
{
  server.auth.strategy('jwt', 'jwt',
    {
      key: jwtSecret,
      validateFunc: validateJwt,
      verifyOptions:
      {
        algorithms: ['HS256'],
        ignoreExpiration: (env === 'development'),
        tokenType: 'Bearer'
      },
      urlKey: false,
      cookieKey: false
    });
  server.auth.default('jwt');
}

The settings.auth propagation was removed in 7059c17ea67f82917249fce855674f9c7220602b

Would the problem perhaps be resolved by adding auth: settings.auth === false ? false : undefined in the config parts?
We specify auth: false when loading hapi-swagger, which I believe is the opposite situation that the commit referenced above attempts to fix. So it breaks when auth: false is used..

Or should it perhaps be just auth: false always in the config parts?

Ok this seems to be fixed through #453, can you retest @click2install ?

I had the same issue and #453 solved that for my case :+1:

@xkr47 Working as expected now, thank you :)

@click2install guess you can close the issue then? :smile:


Import GBC Infrared Communication from Dan Docs

I've copied the "GBC Infrared Communication" article from @shonumi 's Dan Docs.
Some notes:

I've converted the two tables, the first one needs reviewing and could be used as possible standard for the other registry-bit explanation ones

I have omitted a couple of paragraphs too specific to titles / excessively long lists.
The source is specified at the top in a "small" text:

How hard it is to put this fragment of text in a "partial" file and import it? So we don't duplicate it in every Dan Docs-imported article?
If this style is appreciated, we need to apply it to the similar notice in "Game Boy Printer"

We need to decide if we should use GCB or CGB to refer to the Game Boy Color model.

This seems to overlap a lot with #327?
For point 1, please not that there's already #334 pending for the tables, with the style that was agreed upon after the attached issue's discussion.
For point 3, this is as simple as using {{#include}}. We'd mostly just need first to figure out where to put the partial files in src/.
For point 4, there's probably a convention to be established, possibly using the two different terms in different ways, e.g. GBC = all color models (CGB, AGB, GBS), but CGB = strictly Color's.


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-2.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 860

Questions ?
Please refer to the Backport tool documentation


Add support for Python 3.11

Python 3.10 works:
$ python3.10 -m pip install symforce
Collecting symforce
  Downloading symforce-0.6.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (4.3 MB)
...

Python 3.11 doesn't:
$ python3.11 -m pip install symforce
ERROR: Could not find a version that satisfies the requirement symforce (from versions: none)
ERROR: No matching distribution found for symforce

Looks like latest release 0.6.0 supports python 3.8 to 3.10:

We're working on py3.11 support - in the meantime you're welcome to try building from source with pip as described here: https://github.com/symforce-org/symforce#build-from-source
We haven't tested this on py3.11 either, so no guarantees it'll work (and no guarantees everything in symforce will work even if the install succeeds).  And the "Build with CMake" instructions there won't work out-of-the-box on py3.11 yet since the pinned package versions we use for that aren't yet 3.11 compatible.

Fixed by v0.7 and the changes mentioned in the release notes there


ModelNew does not completely clear when loading/reloading

Fixed in https://github.com/MarkOates/allegro_flare/commit/a68c7bd0a9443f37429c5a21ac16a5f347de9bb2


inform user to login to OCM if the backplane failed due to that

What type of PR is this?
(feature)
What this PR does / Why we need it?
OCM offline token disabled, backplane login would fail if OCM not logged in, inform the user to do the ocm login if it is not when executing the backplane commands
Which Jira/Github issue(s) does this PR fix?
Resolves #OSD-21603
Special notes for your reviewer
Unit Test Coverage
Guidelines

If it's a new sub-command or new function to an existing sub-command, please cover at least 50% of the code
If it's a bug fix for an existing sub-command, please cover 70% of the code

Test coverage checks

[ ] Added unit tests
[ ] Created jira card to add unit test
[ ] This PR may not need unit tests

Pre-checks (if applicable)

[ ] Ran unit tests locally
[ ] Validated the changes in a cluster
[ ] Included documentation changes with PR

Codecov Report
Attention: Patch coverage is 0% with 35 lines in your changes missing coverage. Please review.

Project coverage is 45.51%. Comparing base (272df9a) to head (d516bb6).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #486      +/-   ##
==========================================
- Coverage   45.66%   45.51%   -0.15%
==========================================
  Files          72       72
  Lines        5961     5980      +19
==========================================
  Hits         2722     2722
- Misses       2895     2914      +19
  Partials      344      344

Files
Coverage Δ

...ocm-backplane/accessrequest/createAccessRequest.go
42.85% <0.00%> (ø)

...ocm-backplane/accessrequest/expireAccessRequest.go
33.33% <0.00%> (ø)

...md/ocm-backplane/accessrequest/getAccessRequest.go
34.61% <0.00%> (ø)

cmd/ocm-backplane/cloud/console.go
22.91% <0.00%> (ø)

cmd/ocm-backplane/cloud/credentials.go
62.50% <0.00%> (ø)

pkg/ocm/mocks/ocmWrapperMock.go
77.91% <0.00%> (-4.56%)
:arrow_down:

pkg/ocm/ocmWrapper.go
0.00% <0.00%> (ø)

Thanks for the PR

The functionality works all good:

 ./ocm-backplane login $CLUSTER_ID
ERRO[0000] failed to create OCM connection: please make sure you have logged into OCM, use "ocm login --use-auth-code --url $ENV" to login

./ocm-backplane cloud console $CLUSTER_ID
ERRO[0000] failed to create OCM connection: please make sure you have logged into OCM, use "ocm login --use-auth-code --url $ENV" to login

I was thinking to check the test case coverage, but looks all the subcommands don't have the test case to cover the previous function  ocmConnection, err := ocmsdk.NewConnection().Build() to initialize OCM connection, so we don't have to update the test case for the new function SetupOCMConnection() based on that with the additional notification.

LGTM.

/lgtm


PEER REVIEW: 13/07/23

GREAT WORK SO FAR! 💯
The project is well done and the requirements are met

[OPTIONAL SUGGESTIONS]

You can add some CSS styling to the contact section to make it more appealing visually

Your work is great; please try to add syles on the navbar button to indicate the active button to make the user interface descriptive.


How to install DGL 0.6.1 ?

For the requirement:
DGL 0.6.1 (note that DGL 0.7x made some changes to the Coauthor-CS data such that the label split is not balanced)
I can not find a way to install it after I try many times. Could you help me? Thanks a lot !!!

You can use pip install dgl==0.6.1.
Note: for the Coauthor-CS data, if you previously load the data using DGL 0.7X or 0.8X, please delete the saved cache data at ~/.dgl/. Then run the code after you install dgl 0.6.1.


Grid component

With the Lightning framework, we are using lng.components.List Component for Carousel. Do you have a plan to create a Grid component?
Thank you.

Hey @MykhailoDz,
Actually, we don't plan to develop components in lightning any further because each party has their specific needs. At some point, we'd like to clean up lightning of all the components it has as well. If we come to a point we'd like to develop generic components though, it would be separate library outside of lightning.
Best regards


add a mp4 muxer

in order to favor usability of the command line encoder, we should add a mp4 (isomedia) muxer following the spec available https://aomediacodec.github.io/av1-isobmff/
writing a full mp4 muxer is a pretty big task, so it could be simpler to use a separate library. Some possible candidates are

l-smash, https://github.com/l-smash/l-smash/compare/av1, currently not working
libavformat, seems to work, but there still might be some compatibility problems
gpac, currently used to mux the chimera streams

Another reason this is nice is because .ivf doesn't signal keyframes, requiring a remuxer to have an AV1 parser.


Fix mathvista Idefics2

A very small change in the prompting of MathVista.
This can change a bit the performance (up to 1 point).
Idefics2 was fine-tuned with a specific prompt for MCQ.
In this PR, I add a sentence that was always seen during the fine-tuning when the model is expected to answer with a letter for MCQ.
Feel free to directly merge if you think this modification makes sense.

Thanks, we will re-evaluate and update the results of Idefics2 on MathVista.

BTW, a community contributor is also trying to add support for Idefics3, do you have time to take a look (on sth like evalset-specific prompts)?
https://github.com/open-compass/VLMEvalKit/pull/379

Actually I haven't tested on Idefics2, but only Idefics2-large that we are going to release soon (maybe this week)
I think there's not much to change.
The only thing is that the PR in Transformers is not merged yet.
Apart from that, the custom prompts for MMMU and MathVista are valid, and the other ones for MMStar.
There are some (hopefully small) discrepancies when generating with our internal repo and Transformers integration.
If the scores differ too much from what we have reported, don't hesitate to ping me so I can have a look!

@HugoLaurencon
Unfortunately, I find this modification does not work for Idefics2-8B.
Its original rating on MathVista was 52.2, after the update, it becomes 51.4. You can have a double check by running
torchrun --nproc-per-node=$GPU run.py --model idefics2_8b --data MathVista_MINI
with VLMEvalKit on your side.

Okay thanks for the evaluation!
Maybe it's because recently the integration of Idefics2 was broken with the recent versions of Transformers, could you tell me your version?
I will try to investigate a bit morre

Okay thanks for the evaluation!
Maybe it's because recently the integration of Idefics2 was broken with the recent versions of Transformers, could you tell me your version?
I will try to investigate a bit more

The results is obtained with transformers=4.44.0, torch=2.0.1+cu118

Thanks I'll have a look when I find time! Also, if you still have the details of MMMU evaluation scores for Idefics2 for all the categories in your cache, would it be possible to copy paste the whole output of VLMEvalKit here, to compare with what I have with slightly different prompts?
If it's not in your cache no worries no need to spend time recomputing, I'll do it!

Hi, @HugoLaurencon
We have created a huggingface dataset named OpenVLMRecords: https://huggingface.co/datasets/VLMEval/OpenVLMRecords.
You can find the records in this repo.

Very nice feature!


fix: scopedAppName for env

Closes #1919
✅ Checklist

[x] I have followed every step in the contributing guide (updated 2022-10-06).
[x] The PR title follows the convention we established conventional-commit
[x] I performed a functional test on my final commit

Changelog
Fixes for #1919
Changes involves using scopedAppName instead of projectName on creation of env files

Screenshots

💯

@AbiramK Thanks for fixing this!


feat: add accessibility

Added accessibility for screen readers.
Tested and verified it works with

[x] This update works with the built in iOS screen reader
[x] This update works with the built in Android screen reader

One caveat is that I did not add support for partial stars. Just full stars.

This will resolve issue #71

I am probably going to go back in and add a property, accessibilityToggleSize (or some other name). That way they can control how much the stagedRating changes on increment and decrement actions. That way it is not always 1. I had someone complain already that they wanted to do half stars. Though, it will default to 1.
I am also thinking about allow the user to pass in properties for the accessibility labels. That way they can modify the language if they want.

Thanks, this looks great! I was just trying to test the behaviour of the rating component in the iOS app store to get some inspiration, but I'm struggling a bit to use the the actions... I'll try again a bit later when I have some more time. Have you tested it? I'm also wondering if incrementing/decrementing should change the value directly, instead of having to apply it using the activate action. This way you would still get the visual feedback of the stars changing. What do you think?

Thanks, this looks great!
🎉

I was just trying to test the behaviour of the rating component in the iOS app store
Were you having trouble figuring out the screen reader actions? I can post a quick guide if that helps.

I was actually using the app store star rating as inspiration too. I had copied their accessibility label and actions. They use the stage method which is why I used it but I am totally okay not doing that and just applying the rating. I think that is how it was on Android. They use a slider method and as you slide it applies that new rating immediately.

Have you tested it?
I tested this update on my app for both iOS and Android.

Now I figured it out. Ok let's keep it like this then! I'm wondering if instead of adding the accessibilityToggleSize  prop we should just also increment/decrement half steps if enableHalfStar is true. Otherwise users who use accessibility features are a little more limited than users who don't, which is not very accessible, right? Otherwise we would also have to handle the case that the rating is already set at a half value. Currently if it starts at 2.5 for example you can only increment to 3.5.

I'm wondering if instead of adding the accessibilityToggleSize  prop we should just also increment/decrement half steps if enableHalfStar is true

I 100% agree! For some reason I thought you could customize the increment size to any decimal but I think that was another star library I was looking at.
I can make that update to check for that enableHalfStar flag instead. That would be much better.
I probably won't be able to make the change until Monday/Tuesday though. I am visiting family and trying to limit my computer time lol.

 And I already got that feedback too on my app. It should be the same for everyone.

Sure, take your time. Enjoy your weekend :)

@bviebahn I think I got everything.
It now does half stars if the enableHalfStar flag is true.
I also added additional properties to allow the user to customize the accessibility labels. I was thinking this would help support other languages.
I also updated the readme.
Let me know if you want me to change anything :)

Looks perfect! I just created a new release 1.9.0. Thanks for your help! 🚀


commandbar destination doc

Hi team! Excited to get our destination integration live. Please let me know if you have any edit requests, I was not sure whether to delete or leave comments for example.
Proposed changes
Adding documentation for the CommandBar destination integration
Merge timing

This should be merged/published once the CommandBar destination integration is approved and merged.
Related issues (optional)

None (currently)

Moved to #3951


Adds a document regarding the usage of storage commands.

What type of PR is this?
/kind documentation
What does does this PR do / why we need it:
It adds a document about the usage of storage commands.
Which issue(s) this PR fixes:
Fixes #3761
PR acceptance criteria:

[ ] Unit test

[ ] Integration test

[X] Documentation

[X] I have read the test guidelines

How to test changes / Special notes to the reviewer:
Check if the document is correct, clear and easy to understand.

level=error msg="Attempted to gather ClusterOperator status after installation failure: listing ClusterOperator objects: Get https://api.ci-op-i335nzk0-2f74e.origin-ci-int-aws.dev.rhcloud.com:6443/apis/config.openshift.io/v1/clusteroperators: dial tcp <IP_ADDRESS>:6443: connect: connection refused"

level=error msg="Attempted to gather ClusterOperator status after installation failure: listing ClusterOperator objects: Get https://api.ci-op-i335nzk0-2f74e.origin-ci-int-aws.dev.rhcloud.com:6443/apis/config.openshift.io/v1/clusteroperators: dial tcp <IP_ADDRESS>:6443: connect: connection refused"

/retest

Hey @mik-dass unfortunately the document isn't the same format as other documentation such as: https://github.com/openshift/odo/blob/b0cc651f8f14ec7e17ef38d33b0fe234e637b85b/docs/public/deploying-a-devfile-using-odo.adoc
There are certain (unwritten) requirements that we follow from the OpenShift docs team. @boczkowska unsure if Yana has an official link to it.
For example, for each command, we need to have $ in front of the command, and for anything that's ran by root, it has to have #

@cdrage Fixed

I am thinking about you can a storage - I mean shouldn’t it be “storage volume”. And also should we explain what that means? Because a new user would naturally ask that “without “storage” I don’t have any storage capacity in my component?”
Explaining that adding a storage volumes means that data in that directory would persist across rebuilds seems like a good idea. Just a suggestion.

@girishramnani Fixed.

This is good start.
/lgtm
/approve

/override ci/prow/v4.5-integration-e2e
this is just docs, we don't need to wait for tests


Person in authority can view and edit all buildings

Persons part of an authority can view and edit all existing buildings, and can add new ones as well.
That is something undesired, they should at most be able to view and exit their own buildings.

We will remain authority people to be able to add new buildings, this allows them to register a new location without the need of an admin. All these actions are logged anyways, so people adding unwanted buildings will be tracable.


Add .cjs to known JavaScript file extensions

Add .cjs to known JavaScript file extensions.
Related:

https://github.com/babel/babel/pull/10599
Node.js 13.2 Unflag --experimental-modules. https://github.com/nodejs/node/releases/tag/v13.2.0

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: xiaoxiangmoe sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Can you please create an issue for this as well. This helps us track what is delivered each milestone

Thanks!


Update CHANGELOG entries

@ydah Thank you for your recent contributions. Could I add them to the change log?

Let me check the rule... :eyes:
https://github.com/danger/danger/blob/84f0721148252c6520b82b0622213a2d3c856173/.github/pull_request_template.md#L9-L13
https://github.com/danger/danger/blob/84f0721148252c6520b82b0622213a2d3c856173/.github/pull_request_template.md#L15-L17
And the older entries... :eyes:
https://github.com/danger/danger/blob/84f0721148252c6520b82b0622213a2d3c856173/CHANGELOG.md#L62
I think #1486 and #1487 deserve to be explained in the change log.
I will remove #1485 because @ydah explicitly tagged it as #trivial.


Merging after PISA repo moved to IceCubeOpenSource

First batch of changes to merge following the PISA repo move. These are changes that were made during the wait for the move.
Also one fix required to the current master branch is implemented (pint version issue).
Changes are pretty uncontroversial, e.g. a few minor fixes. Some major changes to the simple parameterised reco stage (used for Upgrade work). Is more general now, and more steerable from the cfg file. Docs updated accordingly.

"Also one fix required to the current master branch is implemented (pint version issue)." ... what exactly is the version issue? Does the fix require a particular version (in which case you need to update requirements.txt and setup.py)? Did it crop up between specific versions but the fix works regardless of version? This kind of information is important to communicate so we can avoid the issue you found in perpetuity.

For the pint issue, the issue is only in newer versions it seems. I guess specifying an old version isn't great practise, which is why I added the current fix.
The issue can be shown simply using the following code snippet:
import collections
from pisa import ureg
import pint
print("pint version : %s" % pint.__version__)
a = 123. * ureg.dimensionless
print("%s is an Iterable : %s" % (type(a),isinstance(a,collections.Iterable)))

On my laptop (newer pint) the problem is seen, output below:
pint version : 0.9
<class 'pint.quantity.Quantity'> is an Iterable : False

On cobalt (older pint):
pint version : 0.8.1
<class 'pint.quantity.Quantity'> is an Iterable : True

So your fix works with either version of PInt that you tested?

Correct, the fix supports any pint version I believe. E.g. it supports anything iterable as usual (in pint or otherwise), but now also supports Quantity arrays in pint versions where these aren't deemed iterable.

I think everything is addressed here, let me know if I've missed something. Otherwise, please could we go ahead with the merge.

Since this is still open, I've added too more small changes/fixes. Might as well get it all in at once!

pipeline/stage.get_outputs() can now return the events (previously could only return a mapset)
toy event generator brought up-to-date with latest code

Everything looks in order to me, thanks for the fixes and improvements! I'll go ahead and merge.

Great, thanks for the review


API unfriendly to Windows requests?

If I'm on my Mac, I can use curl or python's requests library to fetch the json without issue.
On my Windows machine, this request:
requests.get("https://api.hearthstonejson.com/v1/latest/enUS/cards.json")
returns this error:
ConnectionError: ('Connection aborted.', error(10054, 'An existing connection was forcibly closed by the remote host'))
I tried passing in "Mozilla/5.0" as a user-agent to see if the API was happier with that, but no dice.
I don't know much about networking, is there some obvious cause for this issue?

Hey! HearthstoneJSON SSL is configured to be TLS1.2 only, which your installation might not support. I would highly recommend looking into that. It might be caused by a version of python that is too old, try using Python 3.4 or above.
Let me know if this helps. Otherwise, there's a cdn url for hearthstonejson which supports TLS 1.0 but it's not an official one, we only use it internally.

Thank you, Jerome! You were correct, my version of Python (2.7.6) was too outdated. I just installed Python 2.7.12 and the request went through without a hitch. Thank you for your help.


Let's call it lasso

The name seems to work. Let me know @e-lo when a good time to make the change is.

anytime - go for it!
On Fri, Dec 6, 2019 at 9:56 AM David Ory<EMAIL_ADDRESS>wrote:

The name seems to work. Let me know @e-lo https://github.com/e-lo when
a good time to make the change is.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/wsp-sag/client_met_council_wrangler_utilities/issues/43?email_source=notifications&email_token=AAGCBI5IO77AVLPLP3A6GRTQXKG4VA5CNFSM4JW6GEH2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H6W6K5Q,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGCBI657PPIULD3WBBT7W3QXKG4VANCNFSM4JW6GEHQ
.


product is not listed even success alert is visible

Hi @vaishaliwebkul  i'm unable to reproduce this

@ghermans
After debugging I noticed that if slash / is added at the end of APP_URL then the listing will not reflect on UI, after removing slash it's working.
Bit confused about whether it's a bug or not.

Hi @vaishaliwebkul
In my opinion, this should not be considered as a bug because whenever you're setting up the project you need to take about the APP_URL, this is the part of setting up/installation of the project.


Fix for when RangeUsed() in worksheet returns null.

Motivation and Context (Why the change? What's the scenario?)
I have an excel document that has a special worksheet which is not even visible in Excel. I don't know the specifics behind this, but
RangeUsed() returns null for this worksheet. This PR addresses this by skipping the worksheets for which RangeUsed() returns null.
High level description (Approach, Design)
Fix for a special kind of Excel document.

Thanks!


Dev: Try static files before deciding on redirect

- Summary
Fixes: https://github.com/netlify/cli/issues/517
Fixes: https://github.com/netlify/cli/issues/432
Fix the logic to check if a static file for given URL exists.

- Test plan
netlify.toml:
[[redirects]]
  from = "/"
  to = "/home"
  status = 200

Ensure a file exists in /static/home/index.html
run netlify dev
browse to http://localhost:8888

- Description for the changelog

Move alternativePathsFor function from dev command index.js to rules-proxy.js
Use alternativePathsFor to check if a path has static file before calling next()

- A picture of a cute animal (not mandatory but encouraged)
🐥

yes! we've needed this for forever!


Local events added

Add local events:
 <social-sharing ... @open="open()" @close="close()">
   ...
 </social-sharing>

Coverage decreased (-4.2%) to 58.333% when pulling 5140e549b79f1a79fcd92e86ddf448238438c6a8 on anteriovieira:patch-1 into 374b5fc22852eff011dcb56b72717951cc57f24e on nicolasbeauvais:master.

Hello @anteriovieira,
thank you for contributing to vue-social-sharing!
Could you tell me what would be the use case for local events? This will help me to write documentation & tests for it

Hi @nicolasbeauvais ,
I use the sharing on some page of a teaching platform and need to trigger sensors to register the sharing event.
Example:
 <social-sharing ... @open="open()" @close="close()">
   ...
 </social-sharing>

export default {
  // ..
  methods: {
    open() {
        this.$sensor.track('Video shared', { /* properties */ })
    }
  }
}

Is it possible to trigger an event when shared?

:+1:

Hello @anteriovieira, your PR is merged and part of the 2.2.11 release.
As explained in #62 it is not in the scope of this package to validate the success of a share action as it would involve implementing API calls.
Sorry for the wait, and thank you again for contributing :+1:


Provide a means to configure the URL the internal haproxy-exporter uses

Hi, I've been testing the metrics endpoint and ran into an issue. Since I'm using a modified image which setups a separate frontend for the stats:
frontend stats
    bind *:81
    default_backend stats
backend stats
    mode http
{{.Stats}}

It'd be nice if a means to configure the URL the exporter uses internally to fetch the stats was available (preferably through secrets, since this would include authentication if enabled)

This issue is fixed and available as tag 17.09.06-6. DFP will respect the value of the environment variable STATS_URI. Metrics retrieval is still hard-coded to the port 80. This will be changed with the issue #324.

The implementation passed automated tests but I did not have time to try it out on a functional level. Can you please give me a hand and test the tag beta and report back whether it works as expected? You'll need to define environment variable STATS_PORT.


add c client sdk for yodaos

Checklist

[ ] npm test passes
[ ] tests and/or benchmarks are included
[ ] documentation is changed or added

And I don't see anything that generating the API, it's still a static library? If yes, that should not work well with YodaOS and not getting merged unfortunately.


Figure out how to constructReactInstance in React 17

Older versions of React had a different way of creating components.
I am almost certain that this doesn't work in React 17.
Some research by someone who knows Reacts internals is required to bring this functionality into the modern era.
One of the things that might make things more difficult (or more easy, depending on how you look at it), is how React 17 handles event handlers.
React 17 release notes

Also a bit unrelated, but a bit less fun is that JSX can compile down to two "syntaxes".
New JS Transform

Frustratingly, I never had the opportunity to get to this, but I came across this article deconstructing how React works and felt it might be handy in future if I or others can do so!

I'm doing some long term project planning right now, and will try to get to this in W3 of February 2023.


ucx: 1.10.0 -> 1.10.1

Motivation for this change
Bugfix release: https://github.com/openucx/ucx/releases
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 123681 at 788306b5 run on aarch64-linux 1

41 packages marked as broken and skipped:

grass
openspace
python38Packages.arviz
python38Packages.dask-gateway
python38Packages.dask-jobqueue
python38Packages.dask-ml
python38Packages.dask-mpi
python38Packages.dask-xgboost
python38Packages.datashader
python38Packages.dftfit
...

66 packages skipped due to time constraints:

apacheHttpdPackages.mod_tile (apacheHttpdPackages_2_4.mod_tile)
cdo
cloudcompare
eccodes
elmerfem
ezminc
freecad
gdal_2
getdp
globalarrays
...

41 packages built successfully:

EBTKS
bicgl
bicpl
conglomerate
gdal (python38Packages.gdal)
hdf5-mpi
highfive-mpi
hpcg
hpl
inormalize
ior
libminc
librsb
mapproxy
migrate
minc_tools
minc_widgets
mni_autoreg
mpi (openmpi)
n3
netcdf
netcdfcxx4
oobicpl
parmetis
python38Packages.boltztrap2
python38Packages.fenics
python38Packages.h5netcdf
python38Packages.meshio
python38Packages.mpi4py
python38Packages.netcdf4
python38Packages.wrf-python
python39Packages.boltztrap2
python39Packages.fenics
python39Packages.h5netcdf
python39Packages.meshio
python39Packages.mpi4py
python39Packages.netcdf4
python39Packages.wrf-python
pytrainer
scotch
ucx


[Compiler] Component

Most of the basic APIs related to component runtime have been basically implemented or are waiting for merging. I think it's time to complete the basic implementation of the component Compiler part.
related: #4

About runtime code for creating component instances.
Currently, it kind of feels like I'm forcibly using the render function that has been in this repository since the beginning, and the interface is not very clean.
As I mentioned in https://github.com/vuejs/core-vapor/pull/40, before implementing the compiler, it might be better to first tidy up the runtime interfaces like createComponent. 🤔

You are right. After I tried it, I also found this problem, and I think it's good to make some attempts. Now we know that we must separate the creation of components from the mounting of components.

createComponent and props compilation are mostly completed in https://github.com/vuejs/core-vapor/pull/151 !
Directives and slots, among others, are not yet supported.
The runtime for slots just merged a moment ago.
I think it's possible to start working on these now.
related:

https://github.com/vuejs/core-vapor/issues/162
https://github.com/vuejs/core-vapor/issues/154


Sync to 2.42.1

Hi,
This is a simple sync to 2.42.1
Hope this PR finds you, @kidonng pretty soon as I'm right now forced to import my fork as a submodule in my monorepo to be able to get the fix added to this version of daisyui ;)
Thanks for this great work btw.

Sorry for the long wait! I'm doing the sync now.
I appreciate your efforts, but only the submodule changes are necessary, maybe next time I'm not catching up with updates, I will merge it 😃

It's your call @kidonng but I would recommend using the dist of the daisyui package instead of the source code to avoid compatibility issues with design choices made. For instance, the chat component doesn't work if you're not using the dist files.

I would recommend using the dist of the daisyui package instead of the source code to avoid compatibility issues with design choices made. For instance, the chat component doesn't work if you're not using the dist files.

Fixed in #3, please try the latest version (v2.50.1-0) 😊


Improve UX in add/search menu

e.g. key repeat doesn't work nor home/end.
Maybe add shortcuts for number keys to jump to a specific hit.

Home/end now works, since 3c1e7ac3380340edbec5dc932881d8e3b5596084


Link Classifications to MSD web pages

Link to the MSD classifications page from the classifications. (same link on all classifications)

The URL to link the "BFC" text to is:
https://www.familyservices.govt.nz/directory-help/classifications.html


Dockerfile creation

Iam trying to build a docker image from the code which is existing  now. Below one is the dockerfile
FROM golang:1.12.0-alpine3.9
RUN mkdir /app
COPY go.* ./
RUN go mod download
COPY . ./
RUN go build -o kubescape .
CMD ["/app/main"]
But iam getting the below error when iam trying to build kubescape. Do we have any workaround this.
#8 0.383 main.go:5:2: cannot find package "kube-escape/cautils" in any of:
#8 0.383 	/usr/local/go/src/kube-escape/cautils (from $GOROOT)
#8 0.383 	/go/src/kube-escape/cautils (from $GOPATH)
#8 0.383 main.go:6:2: cannot find package "kube-escape/cautils/k8sinterface" in any of:
#8 0.383 	/usr/local/go/src/kube-escape/cautils/k8sinterface (from $GOROOT)
#8 0.383 	/go/src/kube-escape/cautils/k8sinterface (from $GOPATH)
#8 0.383 main.go:7:2: cannot find package "kube-escape/inputhandler/clihandler" in any of:
#8 0.383 	/usr/local/go/src/kube-escape/inputhandler/clihandler (from $GOROOT)
#8 0.383 	/go/src/kube-escape/inputhandler/clihandler (from $GOPATH)
#8 0.383 main.go:9:2: cannot find package "kube-escape/opaprocessor" in any of:
#8 0.383 	/usr/local/go/src/kube-escape/opaprocessor (from $GOROOT)
#8 0.383 	/go/src/kube-escape/opaprocessor (from $GOPATH)
#8 0.383 main.go:10:2: cannot find package "kube-escape/policyhandler" in any of:
#8 0.383 	/usr/local/go/src/kube-escape/policyhandler (from $GOROOT)
#8 0.383 	/go/src/kube-escape/policyhandler (from $GOPATH)
#8 0.383 main.go:11:2: cannot find package "kube-escape/printer" in any of:
#8 0.383 	/usr/local/go/src/kube-escape/printer (from $GOROOT)
#8 0.383 	/go/src/kube-escape/printer (from $GOPATH)

Issue solved modifying the dockerfile
go application
FROM golang:1.16.0-alpine
RUN apk add git --no-cache
&& git clone https://github.com/armosec/kubescape.git kubescape && cd kubescape
&& go mod tidy && go build -o kubescape .
&& cp kubescape /usr/local/bin
CMD ["kubescape"]


on-editor-created callback in directive

Hello,
first thank you very much for your work, it is great to have this editor in angular. I'm new to angular so my entire problem could be a terrible mistake in understanding the framework. So maybe my thoughts are all wrong and there could be a much smoother way to handle it - please keep that in mind.
Okey so: I created some kind of formbuilder in angular. That means I have an array of field types and I include different templates depending on the field type in my controller to build each field. One field type should be a quill editor.
The databinding works perfectly but I can't figure out how to access the 'on-editor-created' in my directive
This is my html
<div class="form-group">
    <ng-quill-editor
            theme="snow"
            ng-model="datasource"
            ng-blur=""
            on-editor-created="editorCreated(editor)"
    >
    </ng-quill-editor>
</div>

This is my directive
myApp.directive('thinDirective', function($compile,$templateRequest, configService) {
    return {
        restrict: 'A',
        scope: {
            datasource: "=",
            attributes:"=",
            index: "="
        },
        compile: function (element, attrs) {
            return function (scope, element, attrs) {
                $templateRequest(configService.angularTemplatePath + 'admin/forms/matrix/' + attrs.thinDirective + ".twig").then(function (html) {
                    element.append($compile(html)(scope));
                });
            }
        },
        link: function($scope){
            /**
             * callback after editor is created
             * @param editor
             * @param key
             */
            $scope.editorCreated = function (editor) {
                alert("test");
            };
        }
    }
});

Could you eventually explain me how to access the on-editor-created in my directive or in my parent scope?
Thanks for your time and sry for the trouble - like I said I started to use angular few days ago

An example without a directive can be found here:
https://github.com/KillerCodeMonkey/ng-quill/blob/develop/demo.html
in your case a directive is the wrong approach to handle a custom template:
directives - Change the behavior (like even listeners) or the appearance of an existing dom node
component - A directive with an own template :)
So you should go with the component.
https://toddmotto.com/exploring-the-angular-1-5-component-method/
I think the link step in a directive is to late, so you miss the editor on create event.

Thank you very much, that helps me to understand angular better and sorry for the trouble since it was not really related to your plugin and more to angular itself


Spacing between the button

@NikhilM98  @llaske   I want to propose one enhancement in Sugarizer-server which is little spacing between the button and icon-buttons in dashboard!
it'll be much better if we add  some spacing over there !
please tell me your thoughts  on this , i'll surely make  a pull request regarding this issue.
thank you !
screenshot below :arrow_down:

@llaske  have a look on this


No-Flux approach

Hi. Nice work with using behaviors to integrate Reflux and Polymer. I should have thought about that myself ;)
I'd like to hear your opinion on my alternative approach, where I completely ditch any Flux flavour and simply use the document as a dispatcher and send custom events. I also prefer the declarative binding but I guess it's just a matter of preference.
Of course this way I sacrifice out-of-the-box action synchronization. Also I'm not a JS pro :wink:. Are there possible performance drawbacks?
Also I've been thinking how you decouple stores from actual API calls. Is this the Flux way? I though that stores were actually responsible for contacting the back-end, etc and updating the state when necessary...

Oh, of course! Please do have a look at my fork

Hey!  Thanks for bringing this stuff up.  I totally looked through your polymer-flux repo a bunch of times while thinking about using Polymer with flux :)
Your branch of this repo looks cool and I'll definitely keep an eye on it!  I know you're not the only person thinking about using Polymer on its own to implement flux.  Some folks in the Polymer slack were chatting about it recently.  And then there's this codepen.  It's all very interesting stuff to me.

I'd like to hear your opinion on my alternative approach, where I completely ditch any Flux flavour and simply use the document as a dispatcher and send custom events.

I think that using the document as a dispatcher is sound as far as the pattern goes– it should work fine for implementing some form of flux.  There are two reasons that I prefer events that live outside the DOM.

The DOM is slow.  The action-event would have to travel up and down the DOM tree per the bubble/capture cycle.  Reflux actions are dispatched quickly because they basically just call each of a list functions (the subscribers) in an array.  It's mechanically simpler and quicker.
That would unnecessarily intermingle your actions and your view layer.  And it would be tempting to think of the path that the action-event travels (as it bubbles through the DOM) as being meaningful or useful, but in reality I think that it's a distraction.  I like keeping the actions and stores as separate from the view as possible.  If they are completely separated, then the view layer could be replaced entirely by something else with minimal hassle.  Using funk, this is violated somewhat, because the stores are Polymer elements.  There's a good reason for that, though– we want the views to subscribe to the stores using "native" Polymer data-binding.

Also I've been thinking how you decouple stores from actual API calls.

I think the jury is still out on this.  Some people do put that kind of stuff in their stores.  It can be okay.  The key (as far as I'm concerned) is that the stores' subscribing methods must make any changes to the store synchronously.  The way this is handled in reflux is that certain actions have "completed" and "failed" sub-actions.  While each one of those actions and sub-actions are responded to by the stores immediately, of course there may be a gap in time between firing the main action (e.g. getProducts()) and the sub-action that denotes its successful completion (e.g. getProducts.completed(products)`).
What are your thoughts on all of this?

Also– these are two must-see repos for using Polymer with flux, if you haven't seen them yet:
https://github.com/balloob/home-assistant-polymer
https://github.com/balloob/home-assistant-js

Closing this, simply due to age– happy to reopen if there are more thoughts to throw around.


Deprecate toString() and toQuery() functions

Environment
Knex version: Latest
Database + version: Any
OS: Any
Feature discussion / request

Explain what is your use case
The toString() and toQuery() functions don't generate safe SQL queries that can be run against the database. This is mentioned briefly in the docs but is often overlooked. toString() is a pretty standard function in JavaScript—I came across it without seeing it in the docs—and it seems logical that it would output safe SQL if you don't see the warning in the docs.

Explain what kind of feature would support this
Deprecating these two functions and replacing them with something like toDebugString() will make it immediately clear that it isn't safe to use those functions for anything other than debugging.

Give some API proposal, how the feature should work
My suggestion is to log a deprecation warning whenever the current functions are called (to avoid breaking existing code by removing them completely) and add a new function called toDebugString() that doesn't log anything and works the same as the existing toString() function.

This issue stemmed from this documentation issue: knex/documentation/issues/227

Agree'd I confused another engineer for a while today about why it wasn't emitting the promise object as a string. Is the .toString method overwriting the inherited .toString prototype method? If so I believe that alone would be a strong enough use case to deprecate and replace the name.

It isn't a promise—it's a query builder. Promises don't have methods like select, where, or join. The best string representation of the query builder is the current query itself, which is what toString outputs. The issue is that many users expect toString to output safe SQL, which it doesn't.

this toString almost had me refactoring my app because it causes queries inside brackets to be altered.
For Example
select * from `Monitors` where `ke` = 'x4oIQf3IOx' and (`mid` = 'bguXu91LSS80' or `mid` = 'Xx1ioUVo6N8999' or `mid` = '3ENv8L3SwC80')

suddenly becomes
select * from `Monitors` where `ke` = 'x4oIQf3IOx' and (`mid` = 'bguXu91LSS80' and `mid` = 'Xx1ioUVo6N8999' and `mid` = '3ENv8L3SwC80')

This is really bad. I'm not sure how this could be allowed to happen :(