In application plugin, permit separating modular and non-modular JAR directory

Windows shells have a limit on their command line which is easily hit by Java command lines.
Gradle's application plugin generates start scripts which define the class path and the module path in the command line.
Application authors could, in principle, override the standard start script templates to use some alternative technique to define the class path and the module path.
One such technique is to use wildcards in those definitions: set CLASSPATH=%APP_HOME%\\lib\\*
This technique works for non-modular applications where only the class path is set.
However, for modular application, one cannot use this technique, since both module and non-module JAR files are placed in the same directory.
If one sets class path as above and module path as set MODULEPATH=%APP_HOME%\\lib\\*, the same file will be loaded twice, which is incorrect.
Expected Behavior
Gradle's application plugin should allow overriding separately the directory where modular and non-modular files are placed.
application {
  libraryDir = 'lib'
  moduleDir = 'module'
}

Current Behavior
Gradle's application plugin doesn't allow said overriding.

Sorry for the late reply
This issue needs a decision from the team responsible for that area. They have been informed. Response time may vary.

Truthfully, this is about "long paths" and launching in Windows shells.
Any solution with good ergonomics would do.
Currently, doing "tools" in Java is an excellent experience (picocli, jshell) except for a lurking blocker bug (add one dependency and oops "path is too long").


move stripCustomoji logic to default Tengo script

The problem
Removing the image ID from the message (without any possibility of recovering it later) is a loss of valuable data that prevents Matterbridge users from giving support to custom emoji via Tengo scripts.
The solution
By moving the stripCustomoji function logic to the default outmessage.tengo script we obtain the same end result while giving the user the option of overriding this logic and creating their own techniques to work on the image id (now available). This is particularly useful -for instance- to convert custom emoji markdown tags into urls, so that clients like converse.js (xmpp) can display these images just like the official discord client does.
Example technique
By using this Tengo script:
text := import("text")

// turn custom emoji tags into url's for xmpp
if (inProtocol == "discord" && outProtocol == "xmpp") {
    rePNG := text.re_compile(`<:.*?:([0-9]+)>`)
    msgText=rePNG.replace(msgText,"https://cdn.discordapp.com/emojis/$1.png")
    reGIF := text.re_compile(`<a:.*?:([0-9]+)>`)
    msgText=reGIF.replace(msgText,"https://cdn.discordapp.com/emojis/$1.gif")
}

the message
<:emoji_name:611124225839156144>
becomes
https://cdn.discordapp.com/emojis/611124225839156144.png

Thanks, very good idea and I'm always a fan of moving more to tengo :-)

Are you also willing to put a PR for your tengo script ? for mattebridge/contrib ?

Thanks a lot, and yes!, will do right now.


fix(prio-nav): calculate position of nav-items relative to parent element

Pull Request
📖 Description
This fixes an issue that is very clear if the syn-prio-nav is not on the left edge of the viewport, where it will start displaying the dropdown menu a lot earlier than is needed.
It also makes sure to not take into account the size of the dropdown button unless the dropdown button is actually shown.
Also slightly related, the cache should probably be purged if the size of the elements change, but I'll perhaps tackle that at another point.
🎫 Issues
Closes #639
👩💻 Reviewer Notes
This seems like it'd be quite easy to create a test for. Can someone point me in the right direction where to add such a test?
📑 Test Plan

✅ DoD

[x] I have tested my changes manually.
[x] I have added automatic tests for my changes (unit- and visual regression tests).
[ ] I have updated the project documentation to reflect my changes (e.g. CHANGELOG, Storybook, ...).
[ ] I have added documentation to the DaVinci migration guide (if need be)
[x] I have made sure to follow the projects coding and contribution guides.
[ ] I have made sure that the bundle size has changed appropriately.
[ ] I have validated that there are no accessibility errors.
[ ] I have used design tokens instead of fix css values

@xkabylgSICKAG: Thank you for your Input, we will have a look at it. Do you mind sharing an example what is broken in the first place (e.g. via a Code-Pen. and maybe creating an issue for this? We are not notified per default when a new PR is created, so it slipped through initially).

@schilchSICKAG sure, I'll create a codepen. I was thinking I'd create a test for this anyway, and starting there would probably be easy to convert to a test later.

@schilchSICKAG sure, I'll create a codepen. I was thinking I'd create a test for this anyway, and starting there would probably be easy to convert to a test later.

Thanks a lot, really appreciated :)

@schilchSICKAG
https://codepen.io/xkabylgSICKAG/pen/YzoMjaQ
You can see quite clearly here that if you set the width to 500px there is enough room for all the nav-items but on the nav that has margin it's still collapsed.
Also, even for the lower nav without the margin, when you set it to 450px there's still clearly enough room to show all the items but it still collapses one. Both of these should be fixed with this PR.
Is there a way I can create a codepen using my updated code to show that it fixes the issue?

I found this in dStudio, when adding the prio-nav to this sub-part of the page it collapses very early.

I added two tests that fail before this fix, and that pass after this fix.

Hi, what's currently blocking this PR, and is there anything I can do to help move this forward?

Hey @xkabylgSICKAG,
just had a look at your PR. There are some other open issues (#582, #631, #410, #409) that I also want to tackle that are all part of the navigation and navigation items. As they are all somehow related, I will create an umbrella branch to fix them all at once and also include your bugfix (which now has its own issue at #639).

@schilchSICKAG Any possibility that we could merge this PR earlier than the other things get fixed? We're currently blocked from releasing a new version of dStudio until this issue gets fixed, since it majorly affects a part of our application.

@schilchSICKAG Any possibility that we could merge this PR earlier than the other things get fixed? We're currently blocked from releasing a new version of dStudio until this issue gets fixed, since it majorly affects a part of our application.

Hey @xkabylgSICKAG,
in this case I will have a look at it tomorrow. Maybe we can also add a reduced version of the bigger PR (e.g. just fixing the use of getBoundingClientRect?) as a quick fix and adding the rest of the features after this has passed?

@schilchSICKAG Yeah, it'd be nice to fix the other sizing issue too, but just fixing the issue with setting a margin would be good enough so we can ship usage of this component.
Want me to split this into two PRs? The first one to merge now would be the test changes minus the should not hide items if there's enough space test and the update to the cacheItemPositions() method. And the rest of the changes would go in the second PR.

@schilchSICKAG Yeah, it'd be nice to fix the other sizing issue too, but just fixing the issue with setting a margin would be good enough so we can ship usage of this component.
Want me to split this into two PRs? The first one to merge now would be the test changes minus the should not hide items if there's enough space test and the update to the cacheItemPositions() method. And the rest of the changes would go in the second PR.

Hi @xkabylgSICKAG, thats actually a great offer, thank you. Yees, would be happy to add this as a quick fix today if you split the PRs ❤

The other tickets are now tackled at https://github.com/synergy-design-system/synergy-design-system/issues/644 under an umbrella ticket and branch.

@schilchSICKAG I rebased it on the main branch and only included the parts that consider the parent when calculating the position of the elements.


It's better to show usage

It's better to show usage , open/impl showhelp?

OK, we will join these in next update~


Add build/test instructions to README + minor improvements.

Improve instructions for first-time contributors and bring the document more into line with the GDS Way and readme template.

List the actual commands necessary to run the testsuite under GOV.UK Docker.
Add copy/pasteable instructions for running the test suite without GOV.UK Docker. This lowers the barrier to entry for potential contributors (including me!), because setting up GOV.UK Docker requires a high-end machine, good Internet connectivity and significant time.
Delete the technical documentation heading, since the whole page is technical documentation and that heading wasn't adding anything.
Update links to 3rd-party gems' websites.
en-GB spelling for licence (noun).
Move the reference-style links underneath the sections where they're used. This makes it easier to read the document in plain text form.

That's fine, no probs. Thanks for asking :)


A user gets highlighted when someone posts a link to MUC

A tkabber user with nickname "любитель криппи языков" gets highlighted when a kaiwa user with nickname "rexim" posts any HTTP URL link to a MUC<EMAIL_ADDRESS>Also, we need to get better reproduction instructions on that.

Also, we need to understand if it's a tkabber's problem or kaiwa's. Or both.

wat

That was my reaction too!

wat

http://chatlogs.jabber.ru/support@conference.jabber.ru/2015/12/15.html#00:41:41.822509

@ForNeVeR @vitalyster so, what's your resolution on that? Invalid?

@rexim did you try suggested Tkabber plugin?

@vitalyster, of course not! I don't use Tkabber!
Besides, it completely unclear from the logs what's the plugin (patch?) and how to get it. I'm sorry, but "somewhere in the logs" sounds like "fuck you".

I'm sorry but "I do not want to read exact 5 lines of log" sounds like "fuck you"

Here is it: http://chatlogs.jabber.ru/support@conference.jabber.ru/2015/09/22.html#17:44:31.206203
Currently we think that's tkabber bug. Please notify us and reopen on any further information.

The plugin - http://pastebin.com/Kvw7GKvT

@vitalyster, sorry, didn't actually mean that. And didn't want to offend you either. Just wanted to understand the situation and your link to that place in the log really confused me. And thanks for the plugin! :)
@ForNeVeR, thanks to you too! :)

@ForNeVeR @vitalyster also, I have one more request for you guys. Could please put the Invalid tag on this issue?

We haven't one and don't classify issues as such. Closed is enough. Goat approves.

Very well then. Thanks anyway! :)

I've also cleaned up this thread a bit.


Make non-recursive schedulings explicit.

In preparation for https://github.com/dotnet/reactive/pull/598, we evaluate where to replace IScheduler.Schedule by the ScheduleAction extension which does not allow recursive scheduling.

AppendPrependSingle.AppendValue would also be a candidate.

I omitted that because PrependValue is not (yet) a candidate. I'll fix that later.

Added more explicit ScheduleActions.

Turns out there are quite a few places that don't need to schedule recursively and would benefit from #598 if the optimization would live in the ScheduleAction extensions.


Optional Secret types via features

ReusableSecret is optional feature
Should StaticSecret be optional that can also make rand_core optional ?

https://github.com/dalek-cryptography/x25519-dalek/issues/116

To that matter should EphemeralSecret be optional as well ? :thinking:

To me this crate's whole purpose is providing a simple interface for ECDHE.
If people want patterns that go beyond ECDHE, they should be using curve25519-dalek directly, IMO.

Yup so we can make StaticSecret optional (with it's warning) and leave EphemeralSecret as ECDHE "baseline"

StaticSecret was made optional so this can be closed


[Docs] Handbook info addition | CU-1ydvcdq

Signed-off-by: Gaurav Chadha<EMAIL_ADDRESS>Description
Handbook info addition
This PR fixes #CU-1ydvcdq
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

@warunicorn19 @leecalcote let's merge this :)


chore: configure renovate

Fixes #608
The configuration is taken from INRIA/spoon.

@monperrus I think this is enough to enable the bot. Could you review it?


Failure to login when built on Arch system.

Well it's a bit embarrassing, but I tried to login via the arch cli installation, and got a login error. It appears the user breath tries to create silently failed, hence the error. Will investigate further tomorrow and issue a fix if found.

Ok well now I'm really confused, in part because I was able to login when building via debian a week ago, and now I'm not. Nothing in the installation process was changed since then, so I'm hoping It's just me and my typos :(

Closing since this looks like a personal issue and not relevant to the current state of the repo.


Support prices up to 10 digits on Huobi

Huobi supports prices up to 10 decimal places (eg KAN/BTC market). Modified Huobi-client to use toFixed(10) on all price related numbers to prevent loss of data.

Any chance of getting this merged? I'd like to use this package with Huobi in production.

Sorry for the delay, merged and released in https://github.com/altangent/ccxws/releases/tag/v0.29.5


issue resolved #191 real time name change  and also added some styling

1)real time name change
https://github.com/user-attachments/assets/27b36de5-9e9e-4437-9652-94d61fddd6cb
Through this change we can get the real time name change feature which is mandatory
2)some styling changes
https://github.com/user-attachments/assets/fe121fe7-9512-4cb1-a6a5-70aab6e5ae81
their is  need to change  since to make it  more effective towards end users.

Hey i guess, if you make something like when a user clicks on "your name" an alert should pop up using javascript and that alert asks for the name, that would be better. And then the value of the input field should be transferred to that div, and new name would appear

I'll merge it soon.

Hey i guess, if you make something like when a user clicks on "your name" an alert should pop up using javascript and that alert asks for the name, that would be better. And then the value of the input field should be transferred to that div, and new name would appear

@rahul-chakradhari have you made the required changes?

@divyanshudhruv sir you can check

sure

thanks @divyanshudhruv

@rahul-chakradhari np, good luck


showing past codeforces contest as the present one

Hey it's cool stuff! :sweat_smile:  But there is this bug. Umm  It seems like the json data which you are fetching has some wrong information. It shows codeforces past DIV2 (324) as the upcoming one ( which is rather 325 ).

Similar issues with Codechef too.

There was some error at the backend. Should be fixed now. Let me know if there is any other problem.

@architv Seems to be working fine now!  I guess you are sending a GET request. You don't have any  control on reliability of the json data being fetched. Right? May I please know what changes you have made to fix it? I couldn't find anything satisfactory in commits.

@tushar-rishav I actually built the backend API, so I do have control over it. The crons weren't running earlier, which was causing the problem.

@architv  cool! I am terminating this thread.


♻ Feat/yadm

Hello Ian, I just want to say thank you for having this public repo; I recently started learning a bit about ansible and your yadm role was massively helpful in configuring my own system!

You're welcome and I'm glad it helps you 😄  Take care!


Limit number of retries in Azure ARM destroy_node.

Limit number of retries in Azure ARM destroy_node.
Description
Azure ARM has several retry loops related to deleting the NIC and VHD as part of node cleanup.  This bounds those loops so they don't retry forever.
Status

done, ready for review

Checklist (tick everything that applies)

[ ] Code linting (required, can be done after the PR checks)
[ ] Documentation
[ ] ICLA (required for bigger changes)

@tetron Any progress?

@pquentin I've renamed ex_retries as requested, added a new param to control the polling delay.

Codecov Report

Merging #1134 into trunk will increase coverage by 0.01%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##            trunk    #1134      +/-   ##
==========================================
+ Coverage   85.47%   85.48%   +0.01%
==========================================
  Files         348      348
  Lines       66421    66492      +71
  Branches     5909     5918       +9
==========================================
+ Hits        56772    56840      +68
- Misses       7242     7243       +1
- Partials     2407     2409       +2

Impacted Files
Coverage Δ

libcloud/compute/drivers/azure_arm.py
50.25% <42.85%> (-0.35%)
:arrow_down:

libcloud/test/compute/test_gce.py
97.59% <0%> (+0.03%)
:arrow_up:

libcloud/compute/drivers/gce.py
76.15% <0%> (+0.04%)
:arrow_up:

libcloud/test/compute/test_ec2.py
97.93% <0%> (+0.18%)
:arrow_up:

libcloud/compute/drivers/ec2.py
74.25% <0%> (+0.19%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29c8eab...eebbd5e. Read the comment docs.

@ldipenti Do you think you could test the retry behavior and fix the conflict from #1137 that I just merged? Thank you!

Thank you! Merged in trunk. ✨

Great! thanks.


Shogun Python package using setup.py

Shogun Python package using setup.py

@arianepaola let's get this moving...

@vigsterkr @lisitsyn @karlnapf @lgoetz I have mentioned on IRC that I did strip down this version to a minimum to create a pull request.

@vigsterkr @lisitsyn @karlnapf @lgoetz  Please review, comment and test. It is fully functional and requires only minor tweaks before merging.

@vigsterkr @lisitsyn @karlnapf @lgoetz Please review, comment and test. It is fully functional and requires only minor tweaks before merging.

ok so couple of things:
... does this require it to run cmake prior to run setup.py, because if so it's a problem... and why do we think that that's required
when i checkout a clean repo and do python setup.py --version
i'm getting this:
shogun wiking$ python setup.py --version
Retrieving Shogun version
Verifying Shogun preconditions
Shogun build environment completed tasks: cmake: [False] -  make: [False] - make install: [False]
Bootstrapping Shogun
Running CMake
CMake arguments: -DPythonModular=ON -DENABLE_TESTING=OFF -DCMAKE_INSTALL_PREFIX=install
Creating build directory: /Users/wiking/backup/shogun/build
-- The C compiler identification is AppleClang <IP_ADDRESS>00181
-- The CXX compiler identification is AppleClang <IP_ADDRESS>00181
CMake Error at /usr/local/Cellar/cmake/3.5.2/share/cmake/Modules/Platform/Darwin.cmake:76 (message):
  CMAKE_OSX_DEPLOYMENT_TARGET is '10.10' but CMAKE_OSX_SYSROOT:

   ""

  is not set to a MacOSX SDK with a recognized version.  Either set
  CMAKE_OSX_SYSROOT to a valid SDK or set CMAKE_OSX_DEPLOYMENT_TARGET to
  empty.
Call Stack (most recent call first):
  /usr/local/Cellar/cmake/3.5.2/share/cmake/Modules/CMakeSystemSpecificInformation.cmake:36 (include)
  CMakeLists.txt:27 (project)

-- Configuring incomplete, errors occurred!

@vigsterkr As discussed on IRC:
It is not needed to manually run cmake prior to running setup.py.
setup.py will run a bootstrapping process of  cmake, make and make install, as it requires the generated files / content for the Python package.
As Viktor mentioned, cmake was installed using brew. The setup.py script uses the default system cmake and might not have picked up the updated user's PATH.

@vigsterkr I squashed the commits.

@karlnapf Updated description.
@vigsterkr ready to merge

Fine to merge.


Restore path to RCTDeviceEventEmitter

This fixes Issue https://github.com/yamill/react-native-orientation/issues/6#issuecomment-144442760. Several people have been getting error messages since commit ce56ce656cc4d60cdc08fba0ad6965ef5ebd74cd was merged. This reverts that commit. Apparently things have changed since that commit fixed an issue. For the record, my environment is:
RN 0.11
Xcode 6.4
building with RN packager.

Thanks! :smile:


Skip modules/*/Pods/ when running SwiftLint. Those are created (but not checked in) if we run pod install in inhouse pods #4259

Should not the following directories be excluded as well?
/docs
/fastlane
/resources
/TokenScriptFiles
/vendor

@hboon

They could be specified, but they don’t affect things because they are small and don’t contain Swift source files.


build-frontend: suppress npm noise

Closes #362

Now that #359 is merged, is this PR ready for review?


Update readme.md

The environment lines in the tutorial are missing the "/resources/postgres/" part of the env path name. Changed from:
  - "./modules/catalog/postgres/postgres.env"

to:
- "./modules/catalog/postgres/resources/postgres/postgres.env"

Thank you for updating the readme, Duane!


replace node-fetch with native fetch module (coming with node v18)

We are using node-fetch for fetching url's in 3 places:

calendar
newsfeed
e2e tests

With the new version v3 they decided to convert node-fetch to ES module so we can not use require anymore. I testet the alternative syntax using const fetch = (...args) => import('node-fetch').then(({default: fetch}) => fetch(...args)); instead.
The modules calendar and newsfeed are working with this change, but jest is failing with a Segmentation fault:
PID 2750 received SIGSEGV for address: 0x10
/opt/magic_mirror/node_modules/segfault-handler/build/Release/segfault-handler.node(+0x3206)[0x7f18049f3206]
/lib/x86_64-linux-gnu/libpthread.so.0(+0x12730)[0x7f18046b9730]
node[0xa15ec0]
node(_ZN2v88internal7Isolate38RunHostImportModuleDynamicallyCallbackENS0_6HandleINS0_6ScriptEEENS2_INS0_6ObjectEEENS0_11MaybeHandleIS5_EE+0xad)[0xe4bb5d]
node(_ZN2v88internal25Runtime_DynamicImportCallEiPmPNS0_7IsolateE+0xb1)[0x11fd7d1]
node[0x15ce134]

AFAIS this error comes from the headless chromium browser used for the e2e tests.
At this point I stopped my PR for using node-fetch v3. They still support v2 with security patches, so we have no problem yet.
For the future we need a solution for this or have to use antoher library.
In package.json node-fetch must stay on v2.

Thanks for the investigation. I agree to keep v2.
Converting to es modules .... That might help the overall project but has a loooot of implications :-) Future selfs problem I'd say ;-)

@khassel I had a look into your MR. I'm not sure why we spin up the full electron app for those tests. It should be sufficient there to only run in server mode only.
I applied your recent changes from https://github.com/MichMich/MagicMirror/pull/2655/files to your branch node-fetch.
I added the import const app = require("../../js/app"); to the vendor_spec.js file.
Changed the beforeAll hook to:
beforeAll(function (done) {
  app.start(() => {
    done();
  });
});

I received the error:
Cannot find module 'logger' from 'js/app.js'

    Require stack:
      js/app.js
      tests/e2e/vendor_spec.js

    However, Jest was able to find:
    	'./logger.js'

Therefore I also applied the moduleNameMapping in the package.json for the e2e tests.
Then I got TypeError: logger_1.default is not a function.
I'm not sure who would trigger the default, so I added a default to the logLevels default: Function.prototype.bind.call(console.log, console).
However, it still complains about default is not a function.
Any ideas on how to fix the logger import?

First of all I'm not very familiar with these e2e tests.

I'm not sure why we spin up the full electron app for those tests. It should be sufficient there to only run in server mode only.

agree to minimize use of e2e

Then I got TypeError: logger_1.default is not a function.

can reproduce this, but I think this error message is misleading because of the following lines:
    TypeError: logger_1.default is not a function

      at Object.<anonymous> (node_modules/@wdio/utils/build/initialiseServices.js:9:29)
      at Object.<anonymous> (node_modules/@wdio/utils/build/index.js:9:30)

The error is related to @wdio and this webdriverio error is coming from stuff in required global-setup.js where more electron and spectron things are done. May this helps for digging deeper ...

Tested with the current develop branch the following setup:
Added moduleNameMapper to the e2e section in package.json
                                "moduleNameMapper": {
                                        "logger": "<rootDir>/js/logger.js",
                                        "node_helper": "<rootDir>/js/node_helper.js"
                                },

Changed the vendor_spec.js file to:
const fetch = require("node-fetch");
const app = require("../../js/app.js");

describe("Vendors", function () {

        beforeAll(function () {
                process.env.MM_CONFIG_FILE = "tests/configs/env.js";

                app.start();
        });

        afterAll( function () {
                app.stop();
        });

        describe("Get list vendors", function () {
                const vendors = require(__dirname + "/../../vendor/vendor.js");

                Object.keys(vendors).forEach((vendor) => {
                        it(`should return 200 HTTP code for vendor "${vendor}"`, function (done) {
                                const urlVendor = "http://localhost:8080/vendor/" + vendors[vendor];
                                fetch(urlVendor).then((res) => {
                                        expect(res.status).toBe(200);
                                        done();
                                });
                        });
                });

                Object.keys(vendors).forEach((vendor) => {
                        it(`should return 404 HTTP code for vendor https://localhost/"${vendor}"`, function (done) {
                                const urlVendor = "http://localhost:8080/" + vendors[vendor];
                                fetch(urlVendor).then((res) => {
                                        expect(res.status).toBe(404);
                                        done();
                                });
                        });
                });
        });

});

Executing this test with npx jest tests/e2e/vendor_spec.js --force-exit works (except the process needs to be force exited).
But running with node-fetch v3 I'm getting again a segmentation fault.
So this is may no solution for the node-fetch upgrade but I will check which other e2e tests could be run with this method which means without the electron/spectron stuff.

I created a PR #2750.
Since node-fetch is converted into an ES module, a simple require statement no longer works.
I also tested the cross-fetch module. It worked and I thought it was a good solution until I found out that it also depends on node-fetch 2.6.1.

Oh, I missed that @khassel already tested the alternate syntax 😑 So this is not a step forward, sorry.

problems are the tests, mm itself is running with this change but the tests are failing with a segmentation fault, e.g. npx jest tests/e2e/env_spec.js.
Seems to be a node issue so we may have to wait until that is fixed on their side.

Okay, I don't think there is an urgent need for us to upgrade now. Should I close my PR?

I did the same work already in September ;) but decided not to create a PR. If you want to leave your PR open you can look into mine to solve the lint problem (instead of ignoring the files) and I also had to change the digest-fetch import but I forgot meanwhile if this is necassary ...

digest-fetch still depends on node-fetch 2.x. So it makes sense that you replaced it too.
I'll leave my PR open, if it bothers someone, we can of course close it.
I have started to replace node-fetch with the build in package https, but it is more complex and I am not sure whether I will finish it.

I'll leave my PR open, if it bothers someone, we can of course close it.

you could convert it to draft so it is clear that it should not merged at the moment

I have started to replace node-fetch with the build in package https, but it is more complex and I am not sure whether I will finish it.

inspired of your answer I did this yesterday in my module MMM-RepoStats, here the diffs.
Beside this is working in the module I think it is no good idea to do this here. I ran in 2 problems

https supports no redirects out of the box, you need an extra package. One of my url's needed a / at the end, without it was redirected and therefore didn't work.
https sends no default User-Agent header. One of my url's didn't work without.

In my case this is not problematic because the url's are fix but in mm the url's for calendar or newsfeed are defined by the user. Therefore, I consider a well-maintained package like node-fetch, got or axios to be a better choice.

I'm not sure if it's worth bringing this up here or on another ticket, but moving from requests to node-fetch caused some plugin modules to fail, as they required the requests module.  @KristjanESPERANTO suggests that they have started some work on "converting" node-fetch to built-in https.  This should be considered a breaking change, since modules will then be required to install and use node-fetch on their own, similar to what has to be done for some current third party modules and the requests node module.
My suggestion would be to enhance node_helper with some async functions to aid in basic REST functionality.  What that interface looks like, however, I'm not really sure.  In that case, rather than having to invoke the library directly, third party devs can use the node_helper functions to retrieve HTML.  It looks like there has been some start to this with checkFetchStatus and checkFetchError being added to the node helper already.
This would allow third party devs to use node helper for data retrieval, and allow core devs some ability to ensure consistency in error handling during data retrieval.

but moving from requests to node-fetch caused some plugin modules to fail, as they required the requests module.

this is only correct for those modules, which didn't define their dependencies in a package.json, for more info see #2617 .

suggests that they have started some work on "converting" node-fetch to built-in https.

see my comment above "no good idea" ...

My suggestion would be to enhance node_helper with some async functions to aid in basic REST functionality.

we can discuss this but @MichMich is the one who decides this, so I would wait for his statement before someone begins with coding.

@khassel I don't plan on doing anything without consulting.. it's definitely an expanded use of the node_helper which may add unnecessary overhead to non-data plugins.
While the module development section on the website outlines how to use native modules, it doesn't really explicitly say "Don't use modules that we already use" and, because of how JS is loading modules, if it's there, it can be used.  Perhaps something as simple as a nice large warning for module devs to warn them to always install the packages they need via their own packages.json and to not assume packages and versions within magicmirror will be available.

What do you think about using node-fetch-commonjs? I have put it in #2750 as a test.
I think it is better than continuing to use node-fetch 2.x, but technically it is not really optimal.

Are there any features in v3 that are missing for use in this project? The node-fetch team still provides fixes for the v2 of the module.
The nodejs team also announced that they implement fetch as a native module in the next LTS version 18 https://github.com/nodejs/node/pull/41749 which can already be used with the experimental flag.
I'm not sure if it is worth it to switch now to another module without a need instead of updating v2 with the fixes and then switching for the native module.

That fetch becomes a native module in nodejs was news to me. Thanks! I think we can wait for that and as you suggested then switching to the native module :-)

Will take a while until node 18 will be the minimum version for MM² but I agree, until then we can use v2 of the library

should not be closed.

sorry for the late reply.

If you remove node-fetch from your external libraries

at the moment we have to stay with node-fetch v2 because the internal fetch function included in Node > v18 was not stable in our tests.

My only ask is that, if and when these types of changes occur, some effort is made in either the forums or discord (or both) to notify module developers of the changes, it will be helpful in order to update our modules to be compatible.

we can do this (if we switch in the future) but this will reach only a few active developers. We had already such a situation when we removed request. These old modules are still in use but never fixed which caused a lot of support in the forums.

does it make sense to extend the node_helper.js class to include a fetch function

we have already such a fetch function in js/fetch.js which is just a wrapper around node-fetch at the moment (we left the part where internal fetch was used as comment). I never tested this but this should work in modules too.

I understand the desire to allow module developers the ability to use their own libraries/make their own calls, but it would seem some modules have been built to utilize modules installed by MagicMirror Core.

I don't see anything we can do to prevent this ...

one should note that developers 'utilize modules installed by MagicMirror Core.'  is because we don't have professional developers and they are cloning the default modules and re-using the code.. this is a good OS model.
i have added code to my upgrade script to try to address the modules where developers didn't know about package.json (as it wasn't needed for default modules) etc,etc,etc..
part of the lifecycle

I don't see anything we can do to prevent this ...
nor should we.. but, we should try to cover our tracks.. the default modules should have documentation on their used libs and package.json files.. (even if they aren't actively 'used')


Change Request: remove default testResultServerHash

Change in BE-Pullrequest: https://github.com/corona-warn-app/cwa-quick-test-backend/pull/75


When trying to login with a user after the first user is created it fails.

When trying to login with a user after the first user is created it fails.
If I delete the first user from the DB (after ldap login created it), I can login with a different user and it will create this user in the DB.  I cannot however login with another user where it would be the second user in the DB.  Please advise.

Hi @seitzbg!
If you're able to, can you try the same thing with local non-LDAP users and let me know if it breaks?

I think this issue might be related to a broken DB after the manual fix applied in issue #11. Since I can't replicate this issue via Active Directory or OpenLDAP and the reporting user hasn't returned I recommend this issue be closed.


Adds is process running and wait for exit functions

Adds two new functions to Application class
is_process_running() -> checks that process is still running
wait_for_process_exit() -> waits for process to finish until timeout (based on timings.wait_until)
Resolves #376

Codecov Report

Merging #378 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #378      +/-   ##
==========================================
- Coverage    94.5%   94.49%   -0.01%
==========================================
  Files          49       49
  Lines       19749    19761      +12
==========================================
+ Hits        18664    18674      +10
- Misses       1085     1087       +2

Thanks for your contribution! I'm planning to make a release on Monday (July, 3). Hope to include these enhancements as well.


Scaffold project upgrades page

What does this PR do and why?
Provide a description of what this PR does. Link to any relevant GitHub issues, Notion tasks or Discord discussions.
Screenshots or screen recordings
If applicable, provide screenshots or screen recordings to demonstrate the changes.
Acceptance checklist

[ ] I have evaluated the Approval Guidelines for this PR.
[ ] I have tested this PR in all supported browsers.
[ ] I have tested this PR in dark mode and light mode (if applicable).

Current dependencies on/for this PR:

main

PR #2160   👈

This comment was auto-generated by Graphite.

Graphite Merge Job
Current status: 🔄 Waiting for checks to pass
This pull request is currently waiting for CI and mergeability checks to pass before being merged.
This comment was auto-generated by Graphite.

Job Reference: 2UzpC3JR8gjxEQLDrz47


elastalert-test-rule should respect ES config

Use ElastAlert's configuration builder to respect the ES options specified in the individual rule file, and use ElastAlert's factory to construct the client used to connect to ES.

Nice! Can you remove the Elasticsearch import now that it's unused? The tests are failing with
"elastalert/test_rule.py:22:1: F401 'Elasticsearch' imported but unused"

@Qmando Oops! Fixed. :)


added a bunch more fox noises

About the PR

renault can make a bunch more legally distinct copyright free fox noises
Why / Balance

we've been doing a lot of personal practice projects to figure out how the codebase works and stuff and this was just a whim of ours so we decided why not see of people like it or something so we're making the PR for the bit. and also it would be kinda cool to voice a fox in a video game...
Media

[ X ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

https://github.com/space-wizards/space-station-14/assets/12144569/b0170dde-3855-437f-8120-9b7515696ddb
Changelog
🆑 fujiwaranao
add: Renault's voice lines have been expanded upon.

This probably needs an attributions entry at Resources/Audio/Animals/attributions.yml. Based on the description, I assume you voiced these samples yourself? If so, the entry might look something like...
- files:
    - fox1.ogg
    - fox2.ogg
    - fox3.ogg
    - fox4.ogg
    - fox5.ogg
    - fox6.ogg
    - fox7.ogg
    - fox8.ogg
    - fox9.ogg
    - fox10.ogg
    - fox11.ogg
    - fox12.ogg
    - fox13.ogg
    - fox14.ogg
    - fox15.ogg
    - fox16.ogg
    - fox_distort.ogg
  copyright: "Created by fujiwaranao"
  license: "CC0-1.0"
  source: "https://github.com/space-wizards/space-station-14/pull/27578"

Pick a license like CC0-1.0 or CC-BY-NC-SA-4.0 or whatever you wish, as long as it is compatible with this codebase and formatted according to SPDX License Identifiers. The original fox_squeak.ogg is CC0-1.0.
See Robust Generic Attribution.

This probably needs an attributions entry at Resources/Audio/Animals/attributions.yml. Based on the description, I assume you voiced these samples yourself? If so, the entry might look something like...
- files:
    - fox1.ogg
    - fox2.ogg
    - fox3.ogg
    - fox4.ogg
    - fox5.ogg
    - fox6.ogg
    - fox7.ogg
    - fox8.ogg
    - fox9.ogg
    - fox10.ogg
    - fox11.ogg
    - fox12.ogg
    - fox13.ogg
    - fox14.ogg
    - fox15.ogg
    - fox16.ogg
    - fox_distort.ogg
  copyright: "Created by fujiwaranao"
  license: "CC0-1.0"
  source: "https://github.com/space-wizards/space-station-14/pull/27578"

Pick a license like CC0-1.0 or CC-BY-NC-SA-4.0 or whatever you wish, as long as it is compatible with this codebase and formatted according to SPDX License Identifiers. The original fox_squeak.ogg is CC0-1.0.
See Robust Generic Attribution.

oh oh thank you yes we did voice this ourselves aaa we're shy anyway thank you so much for the sample file

Also, the changelog may need some grammatical edits.
- add: Renault can make a bunch more legally-distinct, copyright-free fox noises.
Strictly speaking, it does not have "significant in-game impact" to warrant a changelog entry; however, I do find this significantly cool, and the maintainers might not mind.
See Pull Request Guidelines (for reference; I am confident you have read those).

Also, the changelog may need some grammatical edits.
- add: Renault can make a bunch more legally-distinct, copyright-free fox noises.
Strictly speaking, it does not have "significant in-game impact" to warrant a changelog entry; however, I do find this significantly cool, and the maintainers might not mind.
See Pull Request Guidelines (for reference; I am confident you have read those).

We have removed the changelog entry. We had misread the portion about changelog entries in that we'd somehow gotten it mixed up and thought visual (and probably by extension audio) changes were to be logged, but we'd misunderstood.
Also, we're flattered that this has been received so positively...we didn't expect to be considered so seriously and kinda thought people were just going to laugh at us but given this reception, we're going to take some time to go through the audio files again and make sure the sound mixing is tuned to the best of our ability aaaa thank you so much

We have removed the changelog entry. We had misread the portion about changelog entries in that we'd somehow gotten it mixed up and thought visual (and probably by extension audio) changes were to be logged, but we'd misunderstood.

Keep in mind I'm not a maintainer and my voice is not the be-all and end-all. I just figured while I was looking over the grammar I would give my thoughts on that. Since it is not an invisible change, I say keep the changelog; A maintainer can remove it at their discretion. :)

showcase video updated with the cleaned up sounds 😊

kind of based

it might be better to opt for some creative-commons fox recordings just for something that sounds a bit more realistic.

it might be better to opt for some creative-commons fox recordings just for something that sounds a bit more realistic.

the sound linked there would probably be better suited for our falling-into-a-hole sound effects than our fox-petting sound effects, but yes, creative commons sound effects would in theory be more realistic (wikimedia commons probably has a lotta of fox sounds)
on the other hand, nobody actually knows what foxes really sound like (as we all know), so really anything other than demonic screaming would probably pass

on the other hand, nobody actually knows what foxes really sound like (as we all know), so really anything other than demonic screaming can pass as realistic

people do in fact know what foxes sound like, hence why i recognized that the sound effects here don't really sound that accurate to foxes. In fact, you can watch extensive footage and recordings of foxes making various sounds.

it might be better to opt for some creative-commons fox recordings just for something that sounds a bit more realistic.

these are vixen cries and foxes sound like this under very specific circumstances. the noses we produced replicate the kinds of noises foxes make when playing or like...being pet and stuff when more domesticated

people do in fact know what foxes sound like, hence why i recognized that the sound effects here don't really sound that accurate to foxes. In fact, you can watch extensive footage and recordings of foxes making various sounds.

The sounds here are reminiscent of some recordings of captive foxes making various non-screaming noises, like Finnegan and others on the YouTube channel SaveAFox.

I am wondering if this be added to the base MobFox prototype instead of just Renault?

thanks for reminding us 😊

Do not use codeblock for changelog (sorry if my example misled you). Also present active voice is preferred e.g. "Renault now has additional fox noises."

eeep thanks for the suggestion we didn't realize we were dipping into the past perfect tense out of habit when writing formally

Wait... you did these yourself.... ok damn.... you win

OH MY GOD THANK YOU SO MUCH THIS MAKES US SO HAPPY AAAA


Fix cli help shorthand

Issue:
What I did
This fixes#5360
How to test

Is this testable with Jest or Chromatic screenshots? Nope
Does this need a new example in the kitchen sink apps? Nope
Does this need an update to the documentation? Nope

@pascalduez PR is based on the master branch, it needs to be based on the next branch.


WGS84->NAD83MTM1 Projection error (reported by Terry)

This issue was imported from CodePlex
Shade1974 wrote 2010-09-11 at 00:29
When performing a transform from NAD1983UTM11 to WGS1984, there are no issues.
N,E,Z coordinates in, Lat/Long generated (decimal degrees).
Data used is:
xy(0) = 337286.313 (easting)
xy(1) = 4694674.076 (northing)
z(0) = 182.366 (elevation)
myProjIn = DotSpatial.Projections.KnownCoordinateSystems.Projected.NationalGridsCanada.NAD1983MTM1
myProjOut = DotSpatial.Projections.KnownCoordinateSystems.Geographic.World.WGS1984
Reproject.ReprojectPoints(xy, z, myProjIn, myProjOut, 0, 1)
Results:
xy(0)=-82.1054299846804 (longitude)
xy(1)=42.391001348558135 (latitude)
z(0)=182.366 (height)
Correct!
When performing a transform from WGS1984 to NAD1983UTM11, there are issues.
Lat/Long/Height in (decimal degrees), NEZ not generated?
Data used is:
xy(0) = -82.105429984679 (longitude)
xy(1) = 42.3910013476671 (latitude)
z(0) = 182.366 (height)
myProjIn = DotSpatial.Projections.KnownCoordinateSystems.Geographic.World.WGS1984
myProjOut = DotSpatial.Projections.KnownCoordinateSystems.Projected.NationalGridsCanada.NAD1983MTM1
Reproject.ReprojectPoints(xy, z, myProjIn, myProjOut, 0, 1)
Results:
xy(0)=-1.#IND
xy(1)=-1.#IND
z(0)=182.366
Also, if my projection of WGS1984 is a GeographicInfo, how do I go about setting this to a ProjectionInfo, because Reproject.ReprojectPoints is excpecting both systems to be Projections.ProjectionInfo and not a Projections,GeographicInfo.
For example, the user is selecting the GeographicInfo and ProjectionInfo values from list boxes.
Dim myGeographic As New DotSpatial.Projections.GeographicInfo
myGeographic.Name = ComboBox2.Text
Dim myProjection As New DotSpatial.Projections.ProjectionInfo
myProjection.Name = ComboBox5.Text
So how does myGeographicInfo become a ProjectionInfo required by Reprohject?
Thanks,
Terry

Not reproduced.


GH actions: update lint workflow to newer version of Go

What motivates this is a newer lint version for local running with 1.22, which fixes the loop range issue and doesn't require spurious lint errors in tests any more.

Thanks for the quick review!


How to install and run Fleet on Windows

Hello. I'm looking to set up Fleet on a Windows 10 Pro machine but don't know exactly how to proceed. It seems like the Docker container approach is the easiest route so I pulled the kolite/fleet image off Docker Hub. I also cloned this GitHub repository and ran docker-compose up to start the MySQL and Redis services in Docker. However, when I tried to start a container based off the kolide/fleet image, I received the following error:
ts=2019-01-22T19:46:33.846474Z mysql="could not connect to db: dial tcp <IP_ADDRESS>:3306: connect: connection refused, sleeping 0s"

I assume this means that the kolide/fleet container can't see the mysql container because they're on different networks. Am I supposed to add this image as a new service to the docker-compose.yml file?
Just to clarify, my current goal is to get Fleet up and running on my Windows 10 pro machine. After that, I want to add the same Windows host (which is running OsQuery) to Fleet. Later on, I plan to add more hosts as well. Thank you for your assistance.

hi can you please provide the steps to add windows as host in kolide


Rust reqwest dependency with all features makes cross compiling difficult

We've been trying to rely on rustls to avoid system openssl issues, the object_store crate actually enables this by turning off reqwest default_features:
https://github.com/apache/arrow-rs/blob/735f48d1f2ebd7e6edb4df167f4f3e91d33f84a4/object_store/Cargo.toml#L53
I'm not sure if there's conditional compilation stuff that we can do, or if y'all wanna just rely on rustls because you already are transitively through object_store, but easier cross compilation would be cool.
FWIW I can get around this by declaring a dependency on openssl and using its "vendor" feature, but, it would be nice to not have to compile openssl

Closed by #1189


npm run format:all

Should be merged into branch why #974
This PR:

Formats the files so that CI passes
Add eslint alphabetize rule https://github.com/huggingface/hub-docs/pull/975/commits/68c6c5ae044c6804c118013aebca19a7dc808fb4 so that you don't need to manually sort https://github.com/huggingface/hub-docs/pull/974/commits/12a3381b9a8b849cd8d8d93c7fd85e348d6524ec. However, we don't have this alphabetize in moon. And we are supposed to align with moon as written in https://github.com/huggingface/hub-docs/pull/924 @krampstudio wdyt?

2. Add eslint `alphabetize` rule [68c6c5a](https://github.com/huggingface/hub-docs/commit/68c6c5ae044c6804c118013aebca19a7dc808fb4) so that you don't need to manually sort [12a3381](https://github.com/huggingface/hub-docs/commit/12a3381b9a8b849cd8d8d93c7fd85e348d6524ec). However, we don't have this `alphabetize` in moon. And we are supposed to align with moon as written in [Align prettier config #924](https://github.com/huggingface/hub-docs/pull/924) @krampstudio wdyt?

eslint config can be specialized, so you can use the base rules from moon and add dedicated rules/plugins for hub_docs if it makes sense

don't think we really need alphabetize though


CI: add Windows build and test coverage

Now that the Windows port is complete enough to build and pass the test
suite, add coverage to prevent regressions.

@saelo - this is the final change for the port, but will not pass until #288 is merged.  The Windows port is nearly merged :-D


Powerpoint Presentation to summarize the work

@yongtang @greenpau
I had started working on the PPT, however, there were a few doubts that crept up. The questions that I have our:

Currently, the project only caters to CoreDNS community. But in theory, it could be used in every other domain (say genomics or brain mapping etc). So should we focus on a general perspective or just focus on the work that we have done? Or should we say that this can be extended to other applications and this is a demo that shows its application for a particular problem statement?
How many slides would the PPT be? (I am guessing the shorter the better but I would like your thoughts on this, as if it's too short it may not convey the entire idea)

@yongtang @greenpau
Please find the first version of the slides here
I would love to have your feedback so that I can improve it. :)


Setting for default value for "unformat" when the input is invalid / none / blank?

Is there any way I can set the default value, when the input is NaN? At the moment, it spit out "0" which may not be desired all the time.

This is the same as issue #98 and #54
Pull request #122 should fix this. Is takes in an 'invalid value' parameter.
accounting.unformat('what', ',' , null) = null


about yabai rule

i put this rule in my config file
yabai -m rule --add app="^Finder$" sticky=on layer=above manage=off
but it not work
the finder app is still managed by yabai . i want finder to be float
i have made SIP disabled and also restart yabai after modify the config file

If you only add it to your config, you need to restart yabai for the config (and the newly added rule) to be applied. You can also just run that one command manually from a shell and it will work just fine as well. I tested the rule and it works fine. you just didn't run it in the active session.


Column 'createdUserId' cannot be null

Scenario:
ZK 1.4.6
MediaModule 1.2.2
Fresh installation.
 Do not edit or delete!", 0, 0, null, null, null, null, null, null, null, null, null, null, null, null]: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'createdUserId' cannot be null"

I'm not sure, but the problem was resolved with a new try.

Great :)
KratorD<EMAIL_ADDRESS>schrieb am Di., 4. Apr. 2017, 10:20:

Closed #92 https://github.com/cmfcmf/MediaModule/issues/92.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/cmfcmf/MediaModule/issues/92#event-1027941285, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACC7RL9XE1psd0zBJb_YpsQe9k6iDu7Pks5rsf1VgaJpZM4Muf__
.

--
Sent from my phone.


Re-train with nnUNet

We will try to re-train this model using nnUNetv2 and compare the results with this one. If it works well enough, we can discuss slowly transitioning out from ivadomed and into nnunet for ADS.

See https://github.com/axondeepseg/axondeepseg/issues/771 for the nnunet retraining master issue. I will now upload the best checkpoints as release assets. We did a 5-fold cross-validation but I don't have the 2 last folds at hand right now, so I'll only upload the 3 first folds. Not only will this make the filesize lighter and the model faster, but I reckon there will not be any performance drop as there was low variance across folds for the TEM dataset (at least compared to the other dsets):


Feature Request: Workspace Icon

As documented here and here, VS Code supports root folder icons.
It'd be great to see one added for Material Theme.

Note
https://github.com/Microsoft/vscode/blob/master/extensions/theme-defaults/fileicons/vs_minimal-icon-theme.json
Sent with GitHawk


Internal Error: database.lua:435: Set bit found with previous bit unset!

Description

ClockP (https://archive.org/download/3-libjune-05/3LIBJUNE05.iso/library%2Fepocgames%2Fclockp%2FClockP.sis)

Details
database.lua:435: Set bit found with previous bit unset!
CLOCKP\MAIN:00000301: B4 [Open] logName=11 fields=LAN$
stack traceback:
	[C]: in function 'assert'
	database.lua:435: in function <database.lua:373>
	(...tail calls...)
	runtime.lua:628: in method 'openDb'
	ops.lua:1587: in function 'ops.Open'
	runtime.lua:859: in function <runtime.lua:844>
	[C]: in function 'xpcall'
	runtime.lua:978: in method 'pcallProc'
	runtime.lua:1242: in function 'runtime.runOpo'

Excellent, well that answers the question of can you get gaps in that bitset...

Actually this error is due to misparsing section 7 as a data section (it isn't), so I think it's probably still true that you shouldn't have gaps in the datasetBitmask.

Now fixed on tomsci-database branch


[ENH] More user-friendly handling of input decoding/reading errors

Closes #314

Changes proposed in this pull request:

Explicitly require UTF-8 encoding of inputs for the bagel pheno command
Print informative error message (without a traceback!) when a UnicodeDecodeError or JSONDecodeError are encountered

For reviewer: Any thoughts on whether this should have the pr-patch or pr-bug-fix label?

Checklist
This section is for the PR reviewer

[ ] PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
[ ] PR has a label for the release changelog or skip-release (to be applied by maintainers only)
[ ] PR links to GitHub issue with mention Closes #XXXX
[ ] Tests pass
[ ] Checks pass

For new features:

[ ] Tests have been added

For bug fixes:

[ ] There is at least one test that would fail under the original bug conditions.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>8
Details

31 of 31 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.07%) to 98.062%

Totals

Change from base Build<PHONE_NUMBER>5:
0.07%

Covered Lines:
759

Relevant Lines:
774

💛  - Coveralls


Update Homebrew documentation

As of Homebrew 2.6.0:

All brew cask commands have been deprecated in favour of brew commands (with --cask) when necessary.

See https://brew.sh/2020/12/01/homebrew-2.6.0/.
Also, removed mention of openrefine-dev cask as this facility does not appear to be in use.

@wetneb I can take a crack at it. I'm a little out-of-practice, my last update being in 2018 - but I'll look into what may need to be updated. Would you like those updates in this same PR?

As you see fit! This is already a documentation PR so I don't think it would inappropriate to add further documentation changes in the same go :)


images check results in GCB run failures despite successful image push

What happened:
https://github.com/kubernetes-sigs/k8s-container-image-promoter/pull/311 added a check for the existence of the pushed images (cip, cip-auditor) before marking the GCB job successful.
Here are some examples:

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-cip-push-image-cip/1406887836669448192
https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-cip-push-image-cip/1407220804646604800
https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-cip-push-image-cip/1407381867107192832

From some of the output, we can see that the images are actually getting built:
INFO: Build completed successfully, 37 total actions
2021/06/22 17:00:33 Destination {STABLE_IMG_REGISTRY}/{STABLE_IMG_REPOSITORY}/{STABLE_IMG_NAME}-auditor:latest was resolved to gcr.io/k8s-staging-artifact-promoter/cip-auditor:latest after stamping.
2021/06/22 17:00:33 Destination {STABLE_IMG_REGISTRY}/{STABLE_IMG_REPOSITORY}/{STABLE_IMG_NAME}-auditor:{STABLE_IMG_TAG} was resolved to gcr.io/k8s-staging-artifact-promoter/cip-auditor:v20210622-v1.337.0-16-gfdaf8db after stamping.
2021/06/22 17:00:33 Destination {STABLE_IMG_REGISTRY}/{STABLE_IMG_REPOSITORY}/{STABLE_IMG_NAME}:{STABLE_IMG_TAG} was resolved to gcr.io/k8s-staging-artifact-promoter/cip:v20210622-v1.337.0-16-gfdaf8db after stamping.
2021/06/22 17:00:33 Destination {STABLE_IMG_REGISTRY}/{STABLE_IMG_REPOSITORY}/{STABLE_IMG_NAME}:latest was resolved to gcr.io/k8s-staging-artifact-promoter/cip:latest after stamping.
2021/06/22 17:00:34 Successfully pushed Docker image to gcr.io/k8s-staging-artifact-promoter/cip-auditor:latest
2021/06/22 17:00:34 Successfully pushed Docker image to gcr.io/k8s-staging-artifact-promoter/cip:latest
2021/06/22 17:00:34 Successfully pushed Docker image to gcr.io/k8s-staging-artifact-promoter/cip-auditor:v20210622-v1.337.0-16-gfdaf8db
2021/06/22 17:00:35 Successfully pushed Docker image to gcr.io/k8s-staging-artifact-promoter/cip:v20210622-v1.337.0-16-gfdaf8db
ERROR
ERROR: failed to find one or more images after execution of build steps: ["gcr.io/k8s-staging-artifact-promoter/cip:v20210622-v1.337.0-16-gfdaf8db" "gcr.io/k8s-staging-artifact-promoter/cip:latest" "gcr.io/k8s-staging-artifact-promoter/cip-auditor:v20210622-v1.337.0-16-gfdaf8db" "gcr.io/k8s-staging-artifact-promoter/cip-auditor:latest"]

/assign
What you expected to happen:
Image pushing postsubmits should run successfully.
How to reproduce it (as minimally and precisely as possible):
Merge any commit to the repo to trigger an image building postsubmit.
Anything else we need to know?:
Environment:

Cloud provider or hardware configuration:
OS (e.g: cat /etc/os-release):
Kernel (e.g. uname -a):
Others:

Disabled check: https://github.com/kubernetes-sigs/k8s-container-image-promoter/pull/313
We'll keep this open until the check is reinstated.

Successful postsubmit with the image check disabled: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-cip-push-image-cip/1407411111174606848

Fixed in https://github.com/kubernetes-sigs/k8s-container-image-promoter/pull/427.


feat(pixels): add my new pixel

Checklist

[ ] I ran npm test locally and it passed without errors.

[ ] I only edited the _data/pixels.json file.

[ ] I entered the username in the pixels.json that I'm also using to create this pull request.
[ ] I acknowledge that all my contributions will be made under the project's license.

Hoping this bad boy comes through


Update MD file on new branch 2017-11-21_05-31-18

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Fix an aliasing bug in compiler_flags for a compiled binary.

It looks like someone tried to handle this by wrapping the default arg in a copy(), but that doesn't work. Without this patch, the flags of the first CompiledBinary in a bundle will be carried on to the others, whether we want that or not.
This bug means, for example, that if a bundle contains a binary with an executable stack following by one without an executable stack, they both get compiled with "-zexecstack", completely negating the fact that the second one shouldn't have a executable stack.

@rriley Thank you! We are reorganizing here as the 2018 activities are ramping up. It may take a bit of more time before you see any action on this. I just thought I should drop you a line to say thank you.

Known behavior of mutable default arguments in python. As is, the copy itself remains mutable.
Simple fix, LGTM


Multidimensional KShape

Hello,
When we use the KShape algorithm in tslearn, can I apply the algorithm to multi-dimensional data?
The code can receive the multi-dimensional data, for example X.shape=(10, 300, 8) not like (10, 300, 1), but I can't understand what occurs in this code.
In this case, how do this code calculate the _inertia? Is there some weights for each dimension?
I read the original paper, but I couldn't get how to extend this algorithm to multi-dimensional data.
When one dimensional data, my calculated SBD is equal to the output( _inertia ), but when >=2d, the output doesn't match my result.
So please help me.

Dear @TomohitoNakano
Thanks for your interest in tslearn. Distances are computed there based on the Cython function defined there.
To be honest, it has been a while since I last dig in that code, so I prefer not to answer your question right now since I would be likely to write false claims. I could have a look at that later once we have released version 0.2 (which is the hot topic for tslearn at the moment).
If the code helps you find out why your results differ in dimension greater than 1, do not hesitate to post your hint here.
Romain

Dear @rtavenar
Thanks a lot for your prompt reply !
I think I specify the target code here for my problem.
return numpy.real(cc).sum(axis=-1) / denom
So summing up along the dimensional axis, right (weights = all 1)?
Thank you !

Yep, that is what this line does.


Webpack and Sidekiq not sending emails on non-test environments

I am trying to move all of our assets over to Webpacker/Webpack. I have gotten this working locally thanks to #232, but whenever I ship to our staging environment, our Sidekiq fails to deliver our emails.
All of our Sidekiq servers are on separate instances from our web servers. As such, since Sidekiq has no awareness of Webpacker/Webpack, I get the following error when trying to send emails:
ActionView::Template::Error: Webpacker can't find mailer.css in
/opt/project/public/packs/manifest.json.

Any guidance is appreciated.

Closing as stale.


docs: add ADR-0030 User generated client keys

Description

Related Issue

Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

test environment:
test case 1:
test case 2:
...

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[ ] Tests only (no source changes)

Checklist:

[ ] Code changes
[ ] Unit tests added
[ ] Acceptance tests added
[ ] Documentation ticket raised:

needs fixing and merge

we will use reva app auth https://github.com/owncloud/ocis/blob/afc6ed1e416c8c1abef832df3e6912b7487cccbd/vendor/github.com/cs3org/reva/v2/pkg/appauth/appauth.go


[SPARK-49552][CONNECT][FOLLOW-UP] Make 'randstr' and 'uniform' deterministic in Scala Client

What changes were proposed in this pull request?
Make 'randstr' and 'uniform' deterministic in Scala Client
Why are the changes needed?
We need to explicitly set the seed in connect clients, to avoid making the output dataframe non-deterministic (see https://github.com/apache/spark/commit/14ba4fc479155611ca39bda6f879c34cc78af2ee)
When reviewing https://github.com/apache/spark/pull/48143, I requested the author to set the seed in python client.
But at that time, I was not aware of the fact that Spark Connect Scala Client was reusing the same functions.scala under org.apache.spark.sql. (There were two different files before)
So the two functions may cause non-deterministic issues like:
scala> val df = spark.range(10).select(randstr(lit(10)).as("r"))
Using Spark's default log4j profile: org/apache/spark/log4j2-pattern-layout-defaults.properties
df: org.apache.spark.sql.package.DataFrame = [r: string]

scala> df.show()
+----------+
|         r|
+----------+
|5bhIk72PJa|
|tuhC50Di38|
|PxwfWzdT3X|
|sWkmSyWboh|
|uZMS4htmM0|
|YMxMwY5wdQ|
|JDaWSiBwDD|
|C7KQ20WE7t|
|IwSSqWOObg|
|jDF2Ndfy8q|
+----------+

scala> df.show()
+----------+
|         r|
+----------+
|fpnnoLJbOA|
|qerIKpYPif|
|PvliXYIALD|
|xK3fosAvOp|
|WK12kfkPXq|
|2UcdyAEbNm|
|HEkl4rMtV1|
|PCaH4YJuYo|
|JuuXEHSp5i|
|jSLjl8ug8S|
+----------+

Does this PR introduce any user-facing change?
no
How was this patch tested?
after this fix:
scala> val df = spark.range(10).select(randstr(lit(10)).as("r"))
df: org.apache.spark.sql.package.DataFrame = [r: string]

scala> df.show()
+----------+
|         r|
+----------+
|Gri9B9X8zI|
|gfhpGD8PcV|
|FDaXofTzlN|
|p7ciOScWpu|
|QZiEbF5q7c|
|9IhRoXmTUM|
|TeSEG1EKSN|
|B7nLw5iedL|
|uFZo1WPLPT|
|46E2LVCxxl|
+----------+

scala> df.show()
+----------+
|         r|
+----------+
|Gri9B9X8zI|
|gfhpGD8PcV|
|FDaXofTzlN|
|p7ciOScWpu|
|QZiEbF5q7c|
|9IhRoXmTUM|
|TeSEG1EKSN|
|B7nLw5iedL|
|uFZo1WPLPT|
|46E2LVCxxl|
+----------+

Was this patch authored or co-authored using generative AI tooling?
no

cc @dtenedor and @HyukjinKwon

Merged to master.


Translate into Korean

Hi, I want to translate this fantastic project.
Is there any process I have to follow?

Me.
https://github.com/Rumo-Arf/How-to-Make-a-Computer-Operating-System

@Rumo-Arf  Did you get any approval from the author?

Nope, but #89 shows that translating to another language won't be problem may be...

refer to https://toolchain.gitbook.com/languages.html for diretory layout.
We will unite in a single repository to do a standardized translation each for your language.
I am waiting for the author's reply at #126

Nice, I am new to gitbook.

I think we need to wait for the author ( @SamyPesse )´s response,
But without a doubt the next step is to create a common repository for all, an organization where the project and everything related will be placed.
I suggest there are 3 repositories,

One for the project site one entry page. (Gh-pages)
One for the text of the book and its translations
And finally one with the sample book sources.

What do you think?
We could open an issue in this new repository to discuss this.


Update after stoping tedge_agent not functioning untill key file is manually deleted

Describe the bug
According the How to documentation in order to make tedge update user can use the same script as the fresh installation, but tedge components need to be stopped.
To Reproduce
Following the documentation:
To successfully upgrade thin-edge.io all thin-edge.io components must be stopped

sudo systemctl stop tedge-mapper-c8y
sudo systemctl stop tedge-mapper-collectd
sudo systemctl stop tedge-agent
sudo systemctl stop c8y-log-plugin
sudo systemctl stop c8y-configuration-plugin
curl -fsSL https://raw.githubusercontent.com/thin-edge/thin-edge.io/main/get-thin-edge_io.sh | sudo sh -s

Error message will be noticed that Another instance of tedge_agent is running
ERROR flockfile::unix: Another instance of tedge_agent is running.
Error will not appear only if the file:
/run/lock/tedge_agent.lock
will be manually removed
Expected behavior
the existeance of tedge_agent.lock should not be registered as another tedge_agent instance is running, having in mind that at the mentioned location
tedge-mapper-az.lock
tedge-mapper-c8y.lock
tedge-mapper-collectd.lock
tedge_agent.lock
are also existing
Screenshots

Environment (please complete the following information):

OS [incl. version]
Hardware [incl. revision]
System-Architecture [e.g. result of "uname -a"]
thin-edge.io version [e.g. 0.1.0]

Additional context

I can guess why it happened.

A device has already tedge_agent.lock owned by tedge user as tedge_agent is supposed to run by tedge user.
However, tedge_agent --init is now run as root user. This was changed by https://github.com/thin-edge/thin-edge.io/commit/fe705ffdf2b18e09492df0ab613a69f8b5bca72f.

A workaround to fix is to delete the /run/lock/tedge_agent.lock file. Like
sudo rm /run/lock/tedge_agent.lock

Resolved by #1557. The build is #918

Tested: Issue cannot be reproduced

Will deliver in 0.8.1


jrnl: fails test at master

Steps To Reproduce
Steps to reproduce the behavior:

build jrnl
get test errors

Build log
https://hydra.nixos.org/build/184485353/nixlog/4
Additional context
N/A
Notify maintainers

@zalakain
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.18.15, NixOS, 22.11 (Raccoon), 22.11.20220730.7b9be38`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.10.3`
 - channels(root): `""`
 - channels(user): `""`
 - nixpkgs: `/etc/nix/channels/nixpkgs`

I have opened a PR for fix and upgrade, but I still fail to run tests at the moment.


Fix README

The README should be made more detailed and should include information about things that need to be done in order to ensure that users can run the app successfully on a development machine.

There are still a lot of issues with the documentation. You should reference other applications to help you with how you write your documentation. See https://github.com/divio/django-cms for example.


Generate BibTeX references.

I've added a method to generate a reference for the BibTeX formatter as per the suggestion of @merrygoat in #37.
Some notes:

I went for [last name of first author]_[up to first three words of title]_[year] as the format
It's robust to there being no year present
All spaces are converted to _
-$£%&()+!?\/:;'"~# are removed

I went for the first three words of the title as just choosing one word could still clash if it was 'A' or 'The' for example.
Would appreciate thoughts from @paxos, @merrygoat and @arfon on this. One question would be: should I lowercase the reference?

Gah, hang on... I used a ruby 2.7-ism (_1) so I need to fix that as we say we're good with 2.6...

Coverage increased (+0.07%) to 93.882% when pulling a4850a2ecde1e325c0e87c54474703640a24c870 on bibtex-auto-refs into ce825a2202d0f9d590e2ae33b151de513851bccb on main.

Sounds good to me!


Unable to authenticate the request" err="[invalid bearer token, Token has expired.]"

OS Version: ubuntu 18.04.5
k3s version v1.21.4+k3s1
error log:
controller.go:116] loading OpenAPI spec for "v1beta1.metrics.k8s.io" failed with: failed to retrieve openAPI spec, http error: ResponseCode: 500, Body: Internal Server Error: "/openapi/v2": Unauthorized
3 16:12:47 Ks-Kubernetes-Node01 k3s[911]: E0403 16:12:47.424793     911 authentication.go:63] "Unable to authenticate the request" err="[invalid bearer token, Token has expired.]"
Why does this happen? Restarting k3s service doesn't work either
Thank You!

Something is running with a stale token. In this case I suspect it's the metrics-server pod. You might try deleting it and allowing it to be re-created.


Add multi pdb entry

This PR adds

ability to add multiple PDB files
ability to see both rings via toggle
select metrics based on map availability

This PR addresses the following issue: #8

@lcs551 Could you please pull this and test the functionality of uploading two files?
git checkout add_multi_pdb_entry
cd frontend
npm run tsc-watch
in another terminal npm run dev


Add Amazon Search extension

Description
A straightforward extension that integrates Amazon's search functionality into Raycast, providing autosuggestions across various Amazon marketplaces.
Screenshot

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

@pernielsentikaer

Maybe add a custom view (Maybe a List.EmptyView) when nothing is searched for

Could you mention another extension where I can see how List.EmptyView was implemented?

Is it possible to add images to the list items

No. The autocomplete results don't represent specific products but search terms for the Amazon Store.

Just tried to search in Sweden, seems like all links are broken

It started working for me after I clicked on a banner (cookies, I believe).

An example could be something like this extension: https://www.raycast.com/koinzhang/google-maven-repository
Just to have a better UI/UX initially 🙂

An example could be something like this extension: https://www.raycast.com/koinzhang/google-maven-repository
Just to have a better UI/UX initially 🙂

Do you recommend me to use the Amazon icon in the List.EmptyView? Also, is there a standard image size that I should use? (512px looks too big in this case)

@pernielsentikaer I added a List.EmptyView with a 128px logo image. Please tell me what you think.


Release 0.7.3 - [merged]

In GitLab by @Asacolips on Nov 19, 2023, 09:13
Merges release/0.7.3 -> master
Note: This will be the final v10 release of the system. Future releases will be v11 or higher.

Added labels (label) to Actor types (#48, !42).
Added modifiers bounds (minMod and maxMod) to sheet configs to limit modifiers within a certain threshold (!26).
Added French localization (!28).
Added a "Send to chat" button to Moves within Actor sheets (#69, !37).
Added a "View Playbook" button next to the Playbook input on Actor Sheets that opens the playbook's sheet (#62, !36)
Added a "Roll Mode" localization (!29).
Added localization to Actor and Item types.
Added blocking of unsupported items from being created on actor sheets (#88, !43).
Changed tab visuals to make a sheet's selected tab to be the darker one (#56, !34).
Fixed Clocks mutating data (#87, !43).
Fixed pressing Enter changing Onward by -1 (#66, !42).
Fixed creating nameless actors would throw an error instead of creating an actor with a default name (!41).
Fixed conditions dialog opening on Moves without rolls (#68, !33).
Fixed styling on chat messages that have a Choices section (#82, !42).
Fixed an error thrown when opening NPC sheets in a world with tags (#88, !42)
Removed migration text from Moves (#75, !31).

In GitLab by @Asacolips on Nov 19, 2023, 09:14
mentioned in commit b44a933b43035575b60dc630b701e0dda2ba703a


PackageId:CPython39.Exe.x64;PackageAction:Install;ReturnCode:1;

This issue has been moved from a ticket on Developer Community.

Describe your issue here  \n  \n  \n===DO NOT EDIT BELOW THIS LINE===  \nPackageId:CPython39.Exe.x64;PackageAction:Install;ReturnCode:1;

Original Comments
Feedback Bot on 12/8/2022, 05:51 PM:
(private comment, text removed)

Original Solutions
(no solutions)

Hi there, please see https://learn.microsoft.com/en-us/visualstudio/python/installing-python-support-in-visual-studio?view=vs-2022#troubleshooting and reopen the ticket if it doesn't resolve your issue. Thanks!


Error in lowering mrcnn model

Added model signature to model using below code:
import tensorflow as tf
import tensorflow_hub as hub

model_url = "https://tfhub.dev/tensorflow/mask_rcnn/inception_resnet_v2_1024x1024/1"
loaded_model = hub.load(model_url)
call = loaded_model.__call__.get_concrete_function(
tf.TensorSpec(shape=(1, 1024, 1024, 3), dtype=tf.uint8))
signatures = {'predict': call}
tf.saved_model.save(loaded_model,'/data/aruna/maskedrcnn/iree', signatures=signatures)

Then used /data/aruna/iree/integrations/tensorflow/bazel-bin/iree_tf_compiler/iree-import-tf -tf-import-type=savedmodel_v1 -tf-savedmodel-exported-names=predict /data/aruna/maskedrcnn/iree --print-ir-before-all&>2 -o sample.mlir
:0: error: loc(callsite(callsite(callsite("BatchMultiClassNonMaxSuppression/MultiClassNonMaxSuppression/Select@__inference___call___42606" at "StatefulPartitionedCall@__inference_restored_function_body_108980") at "StatefulPartitionedCall@__inference_signature_wrapper_110151") at "StatefulPartitionedCall")): currently unsupported operand types: 'tensor<?xf32>' and 'tensor<300xf32>'
:0: note: loc("StatefulPartitionedCall"): called from
Running iree-import-tf TF import pass pipeline failed

I am looking at these one by one but looks like tf.ResizeBilinear/tf.NonMaxSuppressionV5 and tf.CropAndResize could be major ones,
Actually started with tf.CropAndResize

created a python equivalent code to use the python API ( tf.image.crop_and_resize) tf.image.crop_and_resize  |  TensorFlow Core v2.6.0   to get tf dilaect operator
Created a saved_model.pb
Ran the saved model with tflite_convert .
4 Dumped the tf and tfl dialects using module.dump() and extracted the both these dialects on a txt file
tfllie_convert failed with error converting tf.CropAndResize to equivalent tfl /data/Work/tf/tensorflow

time TF_DUMP_GRAPH_PREFIX=crop TF_CPP_MAX_VLOG_LEVEL=4 bazel-bin/tensorflow/lite/python/tflite_convert --saved_model_dir=/data/Work/dkd/tmp42f5h1vo/module_with_signature/ --output_file=crop.tflite &>log.crop
tensorflow/compiler/mlir/lite/flatbuffer_export.cc:406] GetTensorFlowNodeDef %0 = "tf.CropAndResize"(%arg0, %arg1, %arg2, %arg3) {T = f32, device = "", extrapolation_value = 0.000000e+00 : f32, method = "bilinear"} : (tensor, tensor, tensor, tensor<2xi32>) -> tensor loc(callsite(callsite("CropAndResize@inference_call_43" at "PartitionedCall@inference_signature_wrapper_50") at "PartitionedCall")): error: 'tf.CropAndResize' op is neither a custom op nor a flex op
2021-08-30 12:42:35.450948: I tensorflow/compiler/mlir/lite/flatbuffer_export.cc:1883] resourceops 0 error: failed while converting: 'main': Some ops are not supported by the native TFLite runtime, you can enable TF kernels fallback using TF Select. See instructions: Select TensorFlow operators  |  TensorFlow Lite
 TF Select ops: CropAndResize, Placeholder Details: tf.CropAndResize(tensor, tensor, tensor, tensor<2xi32>) -> (tensor) : {T = f32, device = "", extrapolation_value = 0.000000e+00 : f32, method = "bilinear"} tf.Placeholder() -> (tensor) : {device = "", shape = #tf_type.shape} tf.Placeholder() -> (tensor) : {device = "", shape = #tf_type.shape}
tf-opt too failed while legalizing
/data/dkd/tf_linalg/tensorflow/bazel-bin/tensorflow/compiler/mlir/tf-opt -tf-executor-island-coarsening -canonicalize --tf-device-decompose-resource-ops-in-cluster --tf-promote-var-handles-to-args --tf-readonly-references-to-resources --tf-resource-device-inference --tf-executor-to-functional-conversion --tf-shape-inference -xla-legalize-tf crop_tf.mlir -print-ir-before-all --mlir-disable-threading -print-ir-after-all &>log.cropResize crop_
tf.mlir:11:3: error: The following operations cannot be legalized: tf.CropAndResize (count: 1); tf.Placeholder (count: 2). These legalization failure(s) may be due to missing TF to HLO lowerings and/or unsupported attributes, etc. builtin.func private @inference_call_430(%arg0: tensor<2x200x200x3xui32> {tf._user_specified_name = "x"}) -> tensor<*xf32> attributes {tf._construction_context = "kEagerRuntime", tf._input_shapes = [#tf_type.shape<2x200x200x3>]} {\ ^ crop_tf.mlir:11:3: error: Emitting more detail about one op that failed to legalize... builtin.func private @inferencecall430(%arg0: tensor<2x200x200x3xui32> {tf._user_specified_name = "x"}) -> tensor attributes {tf._construction_context = "kEagerRuntime", tf._input_shapes = [#tf_type.shape<2x200x200x3>]} { ^ crop_tf.mlir:38:11: error: 'tf.CropAndResize' op is not legalizable %12 = "tf.CropAndResize"(%0, %4, %11, %cst) {T = f32, device = "", extrapolation_value = 0.000000e+00 : f32, method = "bilinear"} : (tensor<?x?x?x?xf32>, tensor, tensor, tensor<2xi32>) -> tensor
crop_tf.mlir:38:11: note: see current operation: %71 = "tf.CropAndResize"(%9, %18, %70, %8) {T = f32, device = "", extrapolation_value = 0.000000e+00 : f32, method = "bilinear"} : (tensor<?x?x?x?xf32>, tensor<?x4xf32>, tensor<?xi32>, tensor<2xi32>) -> tensor<?x10x10x?xf32> // -----// IR Dump After LegalizeTF Failed //----- /(edited)
Will try with iree-import-tf now.

It's a bit hard to parse contexts. Could you organize the error log better with a link or a code block?
If there are two models, I think it's better to file a bug for each one. It's easier to us to track the missing work. :)

Can you check if we can run it in TFLite?
Sorry that I did not point it out directly. I'm not familiar with TFLite MLIR path. I meant to run TFLite converter and inference (like benchmark_tool?) on the models.

I also see these 6 tf Ops after the ConvertToMHLOPass which might need the equivalent HLO conversions proably

You can try to add some patterns to https://github.com/tensorflow/tensorflow/blob/800d21c92441c17a9ae521adcff62d2ce0640914/tensorflow/compiler/mlir/xla/transforms/legalize_tf.cc
I remembered that we have TopKV2 lowering, but we could miss some cases.

We will create separate issues and attach the log files and paste only the relevant error messages in the console .
Regarding TFLite converter  we did run the model with it and found that it was not able to lower the tf.CropAndResize(tensor<1x64x64x1088xf32>, tensor<?x4xf32>, tensor<100xi32>, tensor<2xi32>)  to an equivalent
tfl Operator , We will reattach the error log for it .
Please suggest the name of the benchmark_tool we can include it too.
Sure we will try to see if we can add some patterns for the ops,  in case @benvanik  might sign up for tf.NonMaxSuppressionV5 as discussed over iree discord  .

@ArunaKote Please attach the error log files and create separate issues .

Ok


Time travel is broken

Looks like the time travel fix to get future Custom Standard rotations working broke the feature in other ways. Details to be investigated.

Oh interesting. Time travel has 4 components:

card release date - that should be straightforward, just stick proper date in set's json file (or per file if it's a weird set like promo cards). Time travel gets really confused when this date is wrong or missing.
name resolution - if you use time:roe instead of time:2010-15-31 format, it uses that date, easy to support for your own sets
ban list - that generally shouldn't apply, but banlist format is super friendly (see search-engine/lib/ban_list/brawl.rb for small recent example). It's just list of dates with list of legalities and announcement link (can be nil).
format rotation - if you inherit from FormatStandard and override rotation_schedule, it should work.

There's no rotation-specific logic anywhere else IIRC.

I'd recommend writing specs like search-engine/spec/format_brawl_spec.rb for your custom rotating format.

Found it again: the query (time:OGW f:Standard) not (time:SOI f:Standard) works fine on mtg.wtf but is broken on Lore Seeker.

Right, the default is to include future cards, so it works in prerelease season. You need explicit time:now or similar to override this.

That's not the desired bahavior for Lore Seeker though, hence my (broken) change.


Switch #isolation from AnyActor to Actor

We are currently lacking the ability to describe "normal or distributed
actor" with a single protocol in a manner that allows hopping to it,
because AnyActor is a marker protocol. Use Actor while we sort
this out.

@swift-ci please smoke test


Add better NFC status callbacks

Solves the issues presented in #26

@petter-fidesmo I'm having a hard time building this, could you assist?

Ready for review @petter-fidesmo

@Franzaine :+1: This looks very nice.
@adriaan-telcred Do you have any comments on the final result here?

Great! I'll move ahead with merging this then!


chore(main): release 1.0.0

:robot: I have created a release beep boop
1.0.0 (2024-06-06)
Bug Fixes

UI: docker settings improved (98158ef)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/WMS-Corporation/wms-WebApplication/releases/tag/v1.0.0 :sunflower:


Allow using node specific BmhLabelSelector

jira: OSPRH-10282

/hold till https://github.com/openstack-k8s-operators/openstack-baremetal-operator/pull/154 merges

recheck openstack-operator-docs-preview  POST_FAILURE

It has to wait for https://github.com/openstack-k8s-operators/ci-framework/pull/2414

I'm ok to override rdoproject.org/github-check

I'm ok to override rdoproject.org/github-check

openstack-k8s-operators/ci-framework#2414 has merged now and I've rebased to stop/re-run the jobs.

@rabi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name 	Commit 	Details 	Required 	Rerun command
ci/prow/openstack-operator-build-deploy-kuttl 	2d033ba link 	true 	/test openstack-operator-build-deploy-kuttl
Full PR test history. Your PR dashboard.

Removing debug pod ...
error: unable to upgrade connection: container container-00 not found in pod oko-19-ctvzz-master-1-debug-xk78z_openstack-kuttl-tests

/test openstack-operator-build-deploy-kuttl

/test openstack-operator-build-deploy-kuttl

recheck

recheck RETRY_LIMIT


Fix sorting by name

Currently
AZaz
Desired
AaZz

Codecov Report

Merging #375 (b9b71b2) into master (83926fa) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #375      +/-   ##
============================================
+ Coverage     65.46%   65.54%   +0.08%
- Complexity      713      715       +2
============================================
  Files           146      146
  Lines          2531     2537       +6
  Branches        284      285       +1
============================================
+ Hits           1657     1663       +6
  Misses          736      736
  Partials        138      138

Impacted Files
Coverage Δ

...in/java/seedu/foodrem/commons/util/StringUtil.java
86.27% <100.00%> (+1.83%)
:arrow_up:

...c/main/java/seedu/foodrem/model/item/ItemName.java
90.00% <100.00%> (ø)

...main/java/seedu/foodrem/model/item/ItemRemark.java
90.00% <100.00%> (ø)

...c/main/java/seedu/foodrem/model/item/ItemUnit.java
90.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Module 2.2 Assignment

👋 for this assignment, if you'd like to try again, please include a screenshot of merging on the command line using git fetch and git merge.

Hi, is this better? :)

Here are the steps I did when I completed this assignment:

Create branch edit-module-assignment on GitHub
Edit Module 2.2 Assignment with your name on GitHub
Then on the command line:


Wdt 353 domain info wlsroles

Add WDT model support to specify WebLogic global roles and add documentation around existing Security section that specifies users and groups. Additional details on WLSRoles section can also be found in the JIRA task WDT-353.

Hmmm... I have no clue why the last merge on the branch would fail wercker build as this was to update a simple typo in the markdown file plus I have no permission on the wercker project to see what may be wrong?


Allow overriding logic to determine highlightes page

Add option to pageNavigationList which is passed to
HighlightedPage to allow overriding the navigation bar mode. This
can be used in navigation bars which always only display the main
storyline.

Coverage remained the same at 99.156% when pulling 8b240aea49c421d5ceedf06991a707d3e4f8fce5 on tf:custom-highlighted-page-navigation-bar-mode into e6f5227c7a857c189b7fcec8474e965bb67eb4c2 on codevise:master.


feat: add logflare fdw

What kind of change does this PR introduce?
This PR is to add the Logflare FDW.
What is the current behavior?
N/A
What is the new behavior?
N/A
Additional context
N/A

For integration testing, LF can run in docker container with supabase mode enabled so that the supabase-related logflare endpoints are seeded, then we can run test queries against it.

For integration testing, LF can run in docker container with supabase mode enabled so that the supabase-related logflare endpoints are seeded, then we can run test queries against it.

Does the LF container need a BigQuery backend or can we use other local backend? As the integration testing will be running in GitHub action, it might not able to access cloud-based backends.


Suppress dead code warning in gpio module.

Allow dead code for the AFRL impl, and document the exact cases that require it.

Was able to figure out the exact problem cases, and I think this was the only source of warnings.  However, I don’t have access to my laptop currently, so I wasn’t able to run or validate this.  It’s a small change, but if someone were to give it a sanity check, that would probably be a good idea!
Otherwise, I’ll post again as soon as I’m able myself :)

I can run a quick sanity on this. This is good for now, later we can probably add to the macro to conditionally impl AFRL.

I was able to build all device features without any warnings

Awesome, thanks for the double check!


Fix tensorflow _dot_product_attention_xla and update MHA tests

This PR modifies enable_flash_attention to set the value to None. This makes it more user-friendly by allowing the backend to decide whether to use flash attention.
The MHA tests have been also updated.
Additionally, a minor but crucial bug in dot_product_attention in tensorflow backend has been fixed. (identified by the updated test)

Codecov Report
Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 60.00%. Comparing base (6479475) to head (ec6872a).

Files with missing lines
Patch %
Lines

keras/src/backend/jax/nn.py
0.00%
3 Missing :warning:

keras/src/layers/attention/multi_head_attention.py
60.00%
1 Missing and 1 partial :warning:

keras/src/backend/tensorflow/nn.py
0.00%
1 Missing :warning:

:exclamation:  There is a different number of reports uploaded between BASE (6479475) and HEAD (ec6872a). Click for more details.
HEAD has 6 uploads less than BASE

Flag
BASE (6479475)
HEAD (ec6872a)

keras
4
1

keras-torch
1
0

keras-tensorflow
1
0

keras-jax
1
0

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #20510       +/-   ##
===========================================
- Coverage   82.11%   60.00%   -22.11%
===========================================
  Files         515      515
  Lines       47720    47721        +1
  Branches     7478     7478
===========================================
- Hits        39183    28636    -10547
- Misses       6727    17331    +10604
+ Partials     1810     1754       -56

Flag
Coverage Δ

keras
60.00% <40.00%> (-21.96%)
:arrow_down:

keras-jax
?

keras-numpy
60.00% <40.00%> (+<0.01%)
:arrow_up:

keras-tensorflow
?

keras-torch
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


chore: Bumped version

Signed-off-by: Grant Seward<EMAIL_ADDRESS>

the version is just bumped (https://github.com/amundsen-io/amundsen/pull/1360/files) .

@feng-tao the release failed with the previous tag, and locally it worked. Our assumption is that something wrong happened during the build process, and hence a new PR to bump the version to make it same with the tag name.
https://github.com/amundsen-io/amundsen/runs/3107251952?check_suite_focus=true


Use walkdir based copy + don't copy .git, fix "Permission denied" build errors

Switch from using xcopy/cp to using walkdir + fs::copy to improve reliability, also don't copy .git directory because read-only files cause failed rebuilds
Fixes errors such as:
  cp: cannot create regular file '/Users/user/wrk/play/electrum/contrib/packetcrypt_rs/packetcrypt-dll/target/release/build/libsodium-sys-6b0dfc7ac10b8aa6/out/source/libsodium/./.git/objects/pack/pack-762
2e108e422314744293f1577160ccc4aced3f6.pack': Permission denied
  cp: cannot create regular file '/Users/user/wrk/play/electrum/contrib/packetcrypt_rs/packetcrypt-dll/target/release/build/libsodium-sys-6b0dfc7ac10b8aa6/out/source/libsodium/./.git/objects/pack/pack-762
2e108e422314744293f1577160ccc4aced3f6.idx': Permission denied
  thread 'main' panicked at 'Failed to copy sources into build directory: exit code: 1', /Users/user/.cargo/git/checkouts/sodiumoxide-9b8c3ad42446e2d9/c1581f0/libsodium-sys/build.rs:370:13
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
error: build failed

@adamreichold Thanks for the comments, implemented both.

testing new config
@bors try

bors: try

@cjdelisle we've fixed the ci, could you rebase your branch to get rid of the merge commits? :)

@kpcyrd done but it looks like your CI thing still doesn't work

bors: r+


Expirable messages

Nice addition :+1: One improvement to the UX would be to include the expiry time on the store view 📆 ⌚


Setup translation

Setup translation which best matches our implementation of client side translation of current site with a language switcher.
The solution should provide ways to extract messages from the code and update the translations though CLI
There are multiple options, evaluate and choose:
https://github.com/vercel/next.js/tree/canary/examples/i18n-routing
https://github.com/vercel/next.js/tree/canary/examples/with-i18n-rosetta
https://github.com/vercel/next.js/tree/canary/examples/with-next-i18next
https://github.com/vercel/next.js/tree/canary/examples/with-lingui
https://github.com/vercel/next.js/tree/canary/examples/with-next-translate

I am working on that issue.

and update the translations though CLI

Did you intend to update the translations of UI through CLI?.

@mdPial Are you working on this?

I have stopped in the middle. I wanted to clear my doubts. If you want to work you can start. I am preparing for exam right now so may b I won't be able to work on this issue for few days.

starting working on this.

starting this.

From chat:
Best is to test their examples. Most focus of server side routing technique to switch language. What we need is a client side switcher with ability to extract messages through CLI. Lingui is very close to our current solution but it depends on msgmerge which the current project also depends upon. So, I would prefer a pure JS solution, but if they don't fit our criteria, we can go with lingui. Also, I don't know if lingui supports CLI message extraction or not

Best is to test their examples. Most focus of server side routing technique to switch language. What we need is a client side switcher with ability to extract messages through CLI. Lingui is very close to our current solution but it depends on msgmerge which the current project also depends upon. So, I would prefer a pure JS solution, but if they don't fit our criteria, we can go with lingui.