Custom template without Handlebars and with dynamic JSON data

Dears ..
thanks for this awesome plugin ...
i am new on ui development and i am facing issues with twitter typeahead ..
im getting data to the "source" by an ajax request and the data that is passed to the "suggestion" template is almost like following :

data = [
{
category: 'category 1',
docs:['doc1', 'doc2', 'doc3']
},
{
category: 'category 2',
docs:['doc4', 'doc5', 'doc6']
},
]

here is my code :

$('#appendedInputButton').typeahead({
            hint: false,
            highlight: true,
            menu: $('.Typeahead-menu'),
            minLength: 1,
            limit: 50,
            classNames: {
                open: 'is-open',
                empty: 'is-empty',
                cursor: 'is-active',
                suggestion: 'Typeahead-suggestion',
                selectable: 'Typeahead-selectable'
            }
        }, {
            source: engineWithDefaults,
            display: 'label',
            templates: {
                suggestion: function(data){
                    // console.log(data.docs);
                    sOutput = "
"+data.category+"

"+data.docs.label+"
"+data.docs.extra1+"

";
                    return sOutput;
                },
                empty: function(){
                    return '
EMPTY !!!
';
                }
            }
        });

Please i need help in this badly !

Hi!
what about multiple datasets https://twitter.github.io/typeahead.js/examples/#multiple-datasets?

@josielrocha Thanks a lot for your response ...
currently the search link that i have accepts only query parameter ... i guess if it is modified to accept "category" as a second parameter your solution will be perfect for me ... i will try to apply it ...
but is that mean that my mentioned above approach is completely wrong ? or is there away to make it work ?

Hi @hala3amme
If you multiple data inside one datasource some features could not work properly. Something like key events or highlight results.
Of course there are many ways to do anything, so if you find another way, please let me know.


Reference OTel BOM documentation from Spring Monitor

API change check
APIView has identified API level changes in this PR and created following API reviews.
com.azure.spring:spring-cloud-azure-starter-monitor


Incorporate Land Cover type in analysis

Utilize ArcGIS to take in lat/lon for each image and return percentages of each type of cover within a half-mile box centered at the lat/lon of the image.

We can use the NJ land cover layer, added on this map and accessed through the ArcGIS Python API. Map has citations for layer, as does mapping.py which fetches and processes the data.
Dan is going to bin categories available so we have a manageable and logical set of regions for our educational purposes.

Next steps:

[ ] Wrapper function in mapping.py to return proper format for incorporation into QUEST dataset for Andromeda.
[ ] Incorporation of binned categories.
[ ] UI interface:

[ ] Toggle/dropdown option (not required step).
[ ] Note: may be time consuming (>1min depending on internet connection)?
[ ] Sign in for ArcGIS (will require users to have account).
[ ] Fetch data call at appropriate time in process (ensure lat/lon in request).


Support special character ?

HI!
I'm trying to parse special character like '<' but it's doesn't seem to be supported.
Does anyone had this problem ? Did you find a solution ? Does the library can easly support this ?

Duplicate !17


Configure proxy for Jenkins

Hello,
I don't know if it is duplicated or no but my question is about node downloading and the use of the proxy.
Well, my project has 2 modules, the first is frontend (React) and the second is backend (Java).
My goal is to package the React sources in the resource of the backend project.
Locally everything is fine but on Jenkins (Behind a proxy), errors are as shown below as the build fails:
> Task :frontend-bo:assemble
> Task :frontend-bo:compileTestJava NO-SOURCE
> Task :frontend-bo:processTestResources NO-SOURCE
> Task :frontend-bo:testClasses UP-TO-DATE
> Task :frontend-bo:test NO-SOURCE
> Task :frontend-bo:check UP-TO-DATE
> Task :frontend-bo:nodeSetup UP-TO-DATE

> Task :frontend-bo:npmSetup
npm ERR! code EHOSTUNREACH
npm ERR! errno EHOSTUNREACH
npm ERR! request to https://registry.npmjs.org/npm failed, reason: connect EHOSTUNREACH <IP_ADDRESS>:443

npm ERR! A complete log of this run can be found in:
npm ERR!     /var/lib/jenkins/.npm/_logs/2019-07-31T14_22_05_568Z-debug.log

> Task :frontend-bo:npmSetup FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':frontend-bo:npmSetup'.
> Process 'command '/data/jenkins/workspace/commerce-frontend_PR-14-EBXQHC6O2GZBYJ73TBRYTBWUEEHVDY2LF2WNHVC2KAFDE6VHI3CQ/frontend-bo/.gradle/nodejs/node-v10.16.0-linux-x64/bin/node'' finished with non-zero exit value 1

It stays blocked on the Task :frontend-bo:npmSetup (npmSetup) task and it takes a long time before throwing the error. That's means it can't download npm from npmjs website.
Is there any way to configure the proxy on these tasks ?
I used this configuration too but it didn't work too.
Thanks.

I close this ticket after I found a solution by setting proxy settings in the Jenkinfile and it works.
node {
   ...
   env.HTTP_PROXY = "http://proxy.threatpulse.net:8080"
   env.HTTPS_PROXY = "http://proxy.threatpulse.net:8080"
   ...
}


adopting style auto enforcement configs

I'm sure that any repo with more than one contributor must have code style policy enforced. As this module is spec compliant I think the best possible style guide is node repo itself, so, I adopted eslint and editorconfig files from node repository as a starting point.
It's not completely following current style, as most source files are using tabs instead of spaces, but I'm not sure what part is better to change. Anyway, I think the best way is to introduce these gradually.
Having these files in project will also help to prevent autoformating at contributors IDE setup.

Codecov Report

Merging #244 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #244   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           6      6
  Lines         387    387
  Branches      117    117
=====================================
  Hits          387    387

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0d0675...56ff5db. Read the comment docs.

Currently the code base is mixed: files in src/ are indented with tabs (which is what @bitinn prefers IIRC) but other files like .travis.yml are done with 2 spaces (though indentation of package.json is forced).
I personally prefer indentation with 2 spaces, which seems to be the norm in most of the JS world. If we were to switch to tabs wholesale, we might still want to specify a indent_size = 2 so that tabs don't take up 8 character-spaces each.

I usually do tab with indent size 4. I know, it's not exactly the de facto style in nodejs world, but I want to see how everyone feels here. Is using 2 spaces a big deal for new contributors? If so, I can live with using 2 spaces.
I personally feel ok as long as the src/ JS files are consistently formatted, I don't have a problem with yml/json files using other formatting/indent style.

I'd love to use 2 spaces, but the biggest deal is when eslint/editorconfig is missing at all - as many IDE starts to reformat code to a developer default.
As I stated above, I've pulled node repo code convention because I think that a ultimate target for any standard compliant module is to be merged into node repo, so, it's good to be prepared even it's not an idea :) However, I can switch to just eslint:recommended if you feel that better.

OK, in this case it will not affect hard decisions of refactoring tabs to spaces :), but will at least create a foundation and prevent autoformating by IDE

I have a spec breaking test waiting for PR and want either merge or close this, please give your opinion...


[BUG] Vagues saves setting show bugged information to players

v <IP_ADDRESS>
When vague saves are set, the word settings are now showing, just a reference to the table

I'm not sure if this is revlavent or not, but this is what's showing up on player side in the f12 window

If the translation strings are showing like that, then it's something that got left over from an old version. It's easy to fix though. Just go to the Bestiary Labels module settings menu and hit reset on the labels and save.
There is however another bug related to saves at the moment which I will soon push out a fix for.

I've just released v<IP_ADDRESS>. It has a fix to display saves properly. 🥳


Memory leak in forward pass on FasterRCNN with varying aspect ratio

Thank you for pytorch!
My object detector is running out of CPU memory after a few iterations.
I traced down the issue to the fact that I use varying aspect ratios at the input.
(My dataset has varying aspect ratios and I want to train the network to handle this properly. Since  my training is distributed, I use batch size 1, making this possible.)
The memory keeps increasing on the forward pass. Training with varying sizes but constant aspect ratio or putting the model in evaluation mode solves the issue (ie constant memory at 1171MB). After a few iterations, memory will oscillate but still have an upwards trend.
I'm not blocked by this but still wanted to know if this is expected behavior and if there is a quick fix for this?
The code below illustrates the issue:
import os
import gc
import random

import torch
import psutil
from torchvision.models.detection import fasterrcnn_resnet50_fpn

process = psutil.Process(os.getpid())
model = fasterrcnn_resnet50_fpn(pretrained=True)
# model.eval() # Gives no issues

for i in range(10):
    size = random.randint(700, 900)
    images = torch.rand([1, 3, size, 800])
    # images = torch.rand([1, 3, size, size]) # Gives no issues
    targets = [{'boxes': torch.tensor([[ 10., 20., 30., 40.]]), 'labels': torch.tensor([1])}]
    model(images, targets)
    gc.collect()
    print("Current memory: ", process.memory_info()[0] / float(2**20))

Output:
Current memory:  1301.67578125
Current memory:  2059.98046875
Current memory:  2895.0234375
Current memory:  3668.140625
Current memory:  3556.203125
Current memory:  4434.28515625
Current memory:  4428.390625
Current memory:  4432.43359375
Current memory:  3522.76953125
Current memory:  3351.46484375

Environment
Output of collect.py
ollecting environment information...
PyTorch version: 1.3.1
Is debug build: No
CUDA used to build PyTorch: None

OS: Mac OSX 10.14.6
GCC version: Could not collect
CMake version: Could not collect

Python version: 3.7
Is CUDA available: No
CUDA runtime version: No CUDA
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA

Versions of relevant libraries:
[pip3] numpy==1.17.4
[pip3] torch==1.3.1
[pip3] torchvision==0.4.2

Hi,
I believe this is fixed in https://github.com/pytorch/vision/pull/1657
Can you try with a latest PyTorch / torchvision nightly and report back if this hasn't been fixed?

Indeed, it's fixed on the nightly. 👍
Much appreciated!


Introduce the mixer/pkg/server package

This new package absorbs the functionality previously implemented in
mixer/cmd/server. This package is what pulls all of the Mixer bits and pieces
together to form a running server.
This package is not only used for mainline Mixer, but can be used from
tests to create a "mixer in a box". As such, we no longer need the
mixer/pkg/mock package, so that is deleted.
While I was here, I deleted a few Mixer command-line options that we never used
(gRPC compression and manually controlled mTLS)

@geeknoid: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.
Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
f19888f551ae049f261564807bee5a12494e0880
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

It's a convention to name packages like the binary. Maybe rename to mixs?
On Tue, Nov 28, 2017, 8:02 PM Martin Taillefer<EMAIL_ADDRESS>wrote:

This new package absorbs the functionality previously implemented in
mixer/cmd/server. This package is what pulls all of the Mixer bits and
pieces
together to form a running server.
This package is not only used for mainline Mixer, but can be used from
tests to create a "mixer in a box". As such, we no longer need the
mixer/pkg/mock package, so that is deleted.
While I was here, I deleted a few Mixer command-line options that we never
used
(gRPC compression and manually controlled mTLS)
You can view, comment on, or merge this pull request online at:
https://github.com/istio/istio/pull/1911
Commit Summary

Introduce the mixer/pkg/server package.
Remove obsolete command-line options and associated logic.

File Changes

M generated_files
https://github.com/istio/istio/pull/1911/files#diff-0 (4)
M mixer/cmd/server/cmd/BUILD
https://github.com/istio/istio/pull/1911/files#diff-1 (2)
M mixer/cmd/server/cmd/server.go
https://github.com/istio/istio/pull/1911/files#diff-2 (386)
D mixer/cmd/server/cmd/test_server.go
https://github.com/istio/istio/pull/1911/files#diff-3 (56)
D mixer/pkg/mock/BUILD
https://github.com/istio/istio/pull/1911/files#diff-4 (35)
D mixer/pkg/mock/server.go
https://github.com/istio/istio/pull/1911/files#diff-5 (107)
D mixer/pkg/mock/server_test.go
https://github.com/istio/istio/pull/1911/files#diff-6 (133)
A mixer/pkg/server/BUILD
https://github.com/istio/istio/pull/1911/files#diff-7 (54)
A mixer/pkg/server/args.go
https://github.com/istio/istio/pull/1911/files#diff-8 (161)
A mixer/pkg/server/monitoring.go
https://github.com/istio/istio/pull/1911/files#diff-9 (76)
A mixer/pkg/server/server.go
https://github.com/istio/istio/pull/1911/files#diff-10 (292)
A mixer/pkg/server/server_test.go
https://github.com/istio/istio/pull/1911/files#diff-11 (156)
A mixer/pkg/server/tracing.go
https://github.com/istio/istio/pull/1911/files#diff-12 (76)
M mixer/test/e2e/BUILD
https://github.com/istio/istio/pull/1911/files#diff-13 (4)
M mixer/test/e2e/e2e_report_test.go
https://github.com/istio/istio/pull/1911/files#diff-14 (57)
M mixer/test/e2e/util.go
https://github.com/istio/istio/pull/1911/files#diff-15 (19)

Patch Links:

https://github.com/istio/istio/pull/1911.patch
https://github.com/istio/istio/pull/1911.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/1911, or mute the thread
https://github.com/notifications/unsubscribe-auth/AJGIxszciUT2bwEl8uakneyAyP5ZdoP9ks5s7NdegaJpZM4QuY9_
.

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
bd9e189287a40777dc9e00d59184ab4d4da1504f
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This is not the Mixer executable. That remains in mixer/cmd/server where
command-line arguments are parsed, and then control is transferred to this
new package.
On Tue, Nov 28, 2017 at 9:10 PM, istio-bot<EMAIL_ADDRESS>wrote:

@geeknoid https://github.com/geeknoid: The following test failed, say
/retest to rerun them all:
Test name Commit Details Rerun command
prow/istio-presubmit.sh bd9e189
https://github.com/istio/istio/commit/bd9e189287a40777dc9e00d59184ab4d4da1504f
link
https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/1911/istio-presubmit/748/ /test
istio-presubmit
Instructions for interacting with me using PR comments are available here
https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md.
If you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://github.com/kubernetes/test-infra/blob/master/commands.md.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/1911#issuecomment-347754933, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AVucHVgkALveslDuzwbnvn8PlWZQpR7Gks5s7OdggaJpZM4QuY9_
.

Ok, but while you are it, you could rename mixer/cmd/server into
mixer/cmd/mixs.
On Tue, Nov 28, 2017 at 9:14 PM Martin Taillefer<EMAIL_ADDRESS>wrote:

This is not the Mixer executable. That remains in mixer/cmd/server where
command-line arguments are parsed, and then control is transferred to this
new package.
On Tue, Nov 28, 2017 at 9:10 PM, istio-bot<EMAIL_ADDRESS>wrote:

@geeknoid https://github.com/geeknoid: The following test failed,
say
/retest to rerun them all:
Test name Commit Details Rerun command
prow/istio-presubmit.sh bd9e189
<
https://github.com/istio/istio/commit/bd9e189287a40777dc9e00d59184ab4d4da1504f
link
<
https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/1911/istio-presubmit/748/>
/test
istio-presubmit
Instructions for interacting with me using PR comments are available here
<
https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md
.
If you have questions or suggestions related to my behavior, please file
an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow issue
:>
repository. I understand the commands that are listed here
https://github.com/kubernetes/test-infra/blob/master/commands.md.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/1911#issuecomment-347754933, or
mute
the thread
<
https://github.com/notifications/unsubscribe-auth/AVucHVgkALveslDuzwbnvn8PlWZQpR7Gks5s7OdggaJpZM4QuY9_
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/1911#issuecomment-347755350, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AJGIxvGI_0YE-FyN0Tcshnql_whS-rHmks5s7OglgaJpZM4QuY9_
.

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
1491929cb4f4f8a674998823dd456bcb331c063b
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retsst

/lgtm

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
f8161fa1c2bba9741fa39cc20eae0064068d8565
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
56341bea1a68cf4f00f4bd2d45f9a20074341339
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
62f12f112a994816e9af9426dd663a4623c55169
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
585310042a3b41f649707b661a6b335c18f92c9a
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
cbe0fa835c7c09f8fcb89cf0b13c91d544fc4cb9
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
6524e45fa5b751b97a9a2dab89a8abf427640fcb
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
991a0a1d81d52f9e896f06d8e2c807d5c50a0a76
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
63421dd33252f82c8c992607a427278ec10e0888
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
7e0ce9d6664103391d342d686935acc055468e32
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
fdd98bf8424e03ea011dc1e18159c9e8adba0ba5
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
db76b147af19e83cd24bc0f610bb6f31022d086d
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
db76b147af19e83cd24bc0f610bb6f31022d086d
link
/test istio-pilot-e2e

prow/e2e-smoke.sh
db76b147af19e83cd24bc0f610bb6f31022d086d
link
/test e2e-smoke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
fd9068b2b604d595a58d83978aaf4a4fc5a64c6e
link
/test e2e-smoke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
fd9068b2b604d595a58d83978aaf4a4fc5a64c6e
link
/test e2e-smoke

prow/istio-presubmit.sh
13c98b003834627f672bc46ef348520ba37a598b
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
a78e78f6e4774e5190faad288f6e2c515d6765a2
link
/test e2e-smoke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest all

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
a78e78f6e4774e5190faad288f6e2c515d6765a2
link
/test e2e-smoke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
436362a86942c9f2f3a0b7214a3e30b1fe00a7ba
link
/test e2e-smoke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
794b7d1cde6ed1caccfdd974d716fab924cd76cd
link
/test e2e-smoke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
787f655a2652c6978a09bdfd33a7f08aede945a8
link
/test e2e-smoke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
787f655a2652c6978a09bdfd33a7f08aede945a8
link
/test e2e-smoke

prow/istio-pilot-e2e.sh
7b286cec2b33689f899ae80105e5628cd976cab3
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
787f655a2652c6978a09bdfd33a7f08aede945a8
link
/test e2e-smoke

prow/istio-pilot-e2e.sh
7b286cec2b33689f899ae80105e5628cd976cab3
link
/test istio-pilot-e2e

prow/istio-presubmit.sh
2695114703f24eb6006208588132d2a5eb2cd5b4
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
b5a245d58783878d35421b6858bf9aa6f5bc658a
link
/test e2e-smoke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
0826f1ac25543d0a5223a3732b5fef5ffbb5a1b7
link
/test e2e-smoke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
bf3746f6f83cdf55df8b3630a14a32220e82a977
link
/test e2e-smoke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
bf3746f6f83cdf55df8b3630a14a32220e82a977
link
/test e2e-smoke

prow/istio-presubmit.sh
abc8fe95f88ed9b3c9d7bef80b813c309e572b46
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
abc8fe95f88ed9b3c9d7bef80b813c309e572b46
link
/test istio-presubmit

prow/e2e-smoke.sh
34a4cd19028226bfe648bf06416dacfb7cf21f7d
link
/test e2e-smoke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I believe this accidentally introduced an error on setting up server binary; mixer e2e tests will fail due to missing templates/adapters info -- the serverCmd / runServer simply ignore these info. #2050 should fix this.


How to print a single data live?

Hello,
There is a refreshing data every 100 ms. I want to show this data on the graph but I was not successful. I can't see any data on the chart when I write it as below. I would be happy if you could help.
System.Drawing.Color color = System.Drawing.Color.FromArgb(255, 139, 26, 26);
double[] angle1Array = new double[1];
private void DispactherTimer_Tick(object sender, EventArgs e)
        {
            try
            {
                    angle1Array[0] = Convert.ToDouble(angle1.Text);
                    dateTime = dateTime.AddMilliseconds(100);
                    Angle_Angle1_Graphic.plt.PlotSignal(angle1Array, 864000, xOffset: dateTime.ToOADate(), color: color, markerSize: 5);
                    Angle_Angle1_Graphic.plt.AxisAuto();
                    Angle_Angle1_Graphic.Render();
            }
            catch
            {

            }
        }

I tested the growing data in the demo in my own application, I am having a similar problem. Could there be a situation about the version difference?
Version 4.0.48
Growing Data Code
    public partial class MainWindow : Window
    {
        public double[] data = new double[100_000];
        int nextDataIndex = 1;

        PlottableSignal signalPlot;
        Random rand = new Random(0);

        private DispatcherTimer _updateDataTimer;
        private DispatcherTimer _renderTimer;

        public MainWindow()
        {
            InitializeComponent();

            var signalPlot = wpfPlot1.plt.PlotSignal(data);
            wpfPlot1.plt.YLabel("Value");
            wpfPlot1.plt.XLabel("Sample Number");

            _updateDataTimer = new DispatcherTimer();
            _updateDataTimer.Interval = TimeSpan.FromMilliseconds(1);
            _updateDataTimer.Tick += UpdateData;
            _updateDataTimer.Start();

            _renderTimer = new DispatcherTimer();
            _renderTimer.Interval = TimeSpan.FromMilliseconds(20);
            _renderTimer.Tick += Render;
            _renderTimer.Start();

            Closed += (sender, args) =>
            {
                _updateDataTimer?.Stop();
                _renderTimer?.Stop();
            };
        }

        void UpdateData(object sender, EventArgs e)
        {
            if (nextDataIndex >= data.Length)
            {
                throw new OverflowException("data array isn't long enough to accomodate new data");
                // in this situation the solution would be:
                //   1. clear the plot
                //   2. create a new larger array
                //   3. copy the old data into the start of the larger array
                //   4. plot the new (larger) array
                //   5. continue to update the new array
            }

            double randomValue = Math.Round(rand.NextDouble() - .5, 3);
            double latestValue = data[nextDataIndex - 1] + randomValue;
            data[nextDataIndex] = latestValue;
            ReadingsTextbox.Text = $"{nextDataIndex + 1}";
            LatestValueTextbox.Text = $"{latestValue:0.000}";
            nextDataIndex += 1;
        }

        void Render(object sender, EventArgs e)
        {
                wpfPlot1.plt.AxisAuto();
            wpfPlot1.Render(skipIfCurrentlyRendering: true);
        }

        private void DisableAutoAxis(object sender, RoutedEventArgs e)
        {
            wpfPlot1.plt.AxisAuto(verticalMargin: .5);
        }
    }

Hi @saklanmazozgur,
I notice two large programs with your code. First, you must only call PlotSignal() one time. In your code you call it multiple times. The correct way to do this is to call it once (passing in an array) then later if the data changes, modify the values in the array and request a new render. The second issue is that you put your code in a try/catch block, so we cannot debug what is wrong.
For real-time highspeed updates of signal plots, you may find this demo helpful to review
https://github.com/swharden/FftSharp#microphone-demo
https://github.com/swharden/FftSharp/blob/1e623b5aab99dbb60231a933c740b3df138caee2/src/FftSharp.Demo/FormMicrophone.cs#L1-L103
Hope it helps!
Scott

After thinking about it some more, here is an alternative option which may be simpler.
In ScottPlot 4.0, use a scatter plot instead of a signal plot.
In ScottPlot 4.1, you can create a Point plot which might be even easier if you just want to show a single point! This way you won't have to use arrays at all. https://swharden.com/scottplot/cookbooks/4.1.6-beta/category/plottable-point/#point
// ScottPlot 4.0 example
//  I'm writing it in the browser so it may not be close, but I hope it conveys the idea.
PlottableScatter Scatter;
private void Init()
{
    // create the scatter plot only once
    double[] xs = new double[1];
    double[] ys = new double[1];
    Scatter = Angle_Angle1_Graphic.plt.PlotScatter(xs, ys);
}

private void DispactherTimer_Tick(object sender, EventArgs e)
{
    // update the scatter plot's values whenever the data changes
    dateTime = dateTime.AddMilliseconds(100);
    Scatter.xs[0] = dateTime.ToOATime();
    Scatter.ys[0] = Convert.ToDouble(angle1.Text);
    Angle_Angle1_Graphic.plt.AxisAuto(); // I'm not sure what happens here if you only have 1 point
    Angle_Angle1_Graphic.Render();
}

Hello @swharden
Thank you for your answer. It was an unsuccessful attempt for me. Running the code below does not give any error but it doesn't run the other code below. (Not in Try catch.)
If the graph is then zoomed, it gives the error "The parameter is not valid". I do not get such an error when I make the size of the array 2.
In addition, what I want to do. Sequentially printing the incoming data every 100 milliseconds. As with Growing Data, it must be a constantly flowing data.
The example above is similar to the one that constantly refreshes data or did I get it wrong

Hello @swharden ,
I did something like the following with reference to the example you shared. The only problem here is; Since the array is not full after the last value, it shrinks itself to 0. I shared it as a picture and I placed the relevant field in red.
How can I solve this problem.
I couldn't upload images due to a problem with Github. I also shared it on an image upload site. For your information.
https://ibb.co/mJVqjY6
Thanks.

Hi @saklanmazozgur,
The issue is that you have created large arrays for X and Y data (where all values are instantiated at 0), but have only partially filled those arrays. When you go to plot them, many of the points are (0, 0). Here are two strategies you may find helpful:
One option would be to use the brand new Scatter.MaxRenderIndex = lastIndexToDisplay that was just added this week. It's so new it's not on NuGet yet, so you'd have to download this repo and use ScottPlot from source. This lets you load a big array and define which index range should actually be rendered.
Another option is to use a Signal plot, which already has MaxRenderIndex functionality. This would require every X data point to be evenly spaced though, which may or may not be ok for your use case.
Perhaps the best option is to create a ScatterPlotList instead of a regular ScatterPlot. The ScatterPlotList list has methods to add additional data points, and it uses a List under the hood to keep track of the data it's plotting.
I suspect all 3 of these ideas could work so I'll close this issue, but feel free to continue to reply if you have further questions or open it up again if you hit a snag! Good luck!

Hi @swharden ,
I was using version 4.0.48. I decided to upgrade to version 4.1 to fix the problem we were talking about. However, when trying to edit the menu of the graph in version 4.1, it gives an error.
I will probably use the Signal plot. I think I can overcome the problem with it.
Know the problem with the menu. Thank you for your attention.
Example ;
AxisX_Graphic.ContextMenu.Items.Clear();
Error: System.NullReferenceException: 'Object reference not set to an instance of an object.'

System.Windows.FrameworkElement.ContextMenu.get returned null.


Issue 1125 test 2 1 x fix partial

Not meant for merge; for showing issues relating to https://github.com/spring-cloud/spring-cloud-sleuth/issues/1125

ping @colejnic :arrow_up:

@marcingrzejszczak  I'm hoping to address this soon (early next week)! got pulled away for a while

@marcingrzejszczak I did some cleanup; there's still a spot I left commented in TraceFeignObjectWrapper where I'm not sure what should happen if we fail to modify the delegate via reflection.
Let me know if there's more you had in mind!


SDK-389: add connection threshold check for incoming connections as w…

…ell, plus test

Closing, bad rebase


new packages

Add a react-codesandboxer-loader - an inline loader that takes in a file path and provides the running components, a 'view code' button, and a codesandbox link.

very important to allow it to work just as an information provider so user's can customise the appearance

Add gatsby-codesandboxer - the above but specifically for gatsby contexts

No longer sure about this.


Clean the DeltaLog class

While digging into the DeltaLog code, I realized that there's some code that can be refactored, and that's the main goal of this Pull request.

I have removed some unused imports
removed an unused method
remove an unnecessary variable
convert some code to Single abstract methods

Hello @zsxwing , can you please take a look to this PR and let me know what you think about it ?
Thanks 🙏


feat(tree): measure different parts of canonicalization

More time measurements to have a better insight into what takes 200-400ms to canonicalize a new chain.
2023-11-02T15:45:28.130879Z DEBUG blockchain_tree: Committing new canonical chain: [(18485367, 0x5c68a1de4564a80f6ae9640c12ab8dfe51219901b6929568b94b7bbbc71e1788), (18485368, 0xb1c5055845d76df1ff942fb4390431534d6e3d4305cf368516d7f646558dda55)]
2023-11-02T15:45:28.167709Z DEBUG providers::db: Inserted block block_number=18485367 actions=[(InsertCanonicalHeaders, 77.513µs), (InsertHeaders, 47.021µs), (InsertHeaderNumbers, 29.252µs), (GetParentTD, 120ns), (InsertHeaderTD, 36.341µs), (GetNextTxNum, 7.68µs), (InsertTxSenders, 283.941µs), (InsertTransactions, 4.187357ms), (InsertTxHashNumbers, 31.614418ms), (InsertBlockWithdrawals, 24.161µs), (InsertBlockBodyIndices, 21.24µs), (InsertTransactionBlock, 27.792µs)]
2023-11-02T15:45:28.192933Z DEBUG providers::db: Inserted block block_number=18485368 actions=[(InsertCanonicalHeaders, 2.39µs), (InsertHeaders, 3.74µs), (InsertHeaderNumbers, 21.231µs), (GetParentTD, 50ns), (InsertHeaderTD, 2.09µs), (GetNextTxNum, 2.67µs), (InsertTxSenders, 174.291µs), (InsertTransactions, 788.716µs), (InsertTxHashNumbers, 24.144254ms), (InsertBlockWithdrawals, 4.96µs), (InsertBlockBodyIndices, 1.44µs), (InsertTransactionBlock, 1.5µs)]
2023-11-02T15:45:28.723336Z DEBUG providers::db: Inserted hashes range=18485367..=18485368 actions=[(InsertStorageHashing, 10.515042ms), (InsertAccountHashing, 6.99229ms), (InsertMerkleTree, 492.040001ms)]
2023-11-02T15:45:28.810353Z DEBUG providers::db: Appended blocks actions=[(InsertBlock, 36.456379ms), (InsertBlock, 25.21712ms), (InsertState, 20.813777ms), (InsertHashes, 509.593546ms), (InsertHistoryIndices, 86.952873ms), (UpdatePipelineStages, 23.361µs)]
2023-11-02T15:45:28.906509Z DEBUG blockchain_tree: Canonicalization finished actions=[(CloneOldBlocks, 13.04µs), (FindCanonicalHeader, 18.121µs), (SplitChain, 1.63µs), (SplitChainForks, 210ns), (MergeAllChains, 370ns), (UpdateCanonicalIndex, 3.1µs), (CommitCanonicalChainToDatabase, 775.615658ms)]

From this block we can see that largest bottlenecks are transactions insertion and merkle tree.

Well ok maybe these timings doesn't actually make a lot of sense
2023-11-01T16:55:12.869695Z DEBUG blockchain_tree: Canonicalization finished timings=[("clone old blocks", 8.481µs), ("find canonical header", 10.55µs), ("split chain", 610ns), ("split chain forks", 320ns), ("merge all chains", 470ns), ("update canonical index", 2.45µs), ("commit canonical chain to database", 589.38833ms)]

Nice, that's more useful
2023-11-01T17:19:40.006286Z DEBUG providers::db: Appended blocks timings=[("block 18478702", 685.133661ms), ("state", 8.115162ms), ("hashes", 237.400492ms), ("history indices", 6.841576ms), ("pipeline stages", 17.041µs)]
2023-11-01T17:19:40.061571Z DEBUG blockchain_tree: Canonicalization finished timings=[("clone old blocks", 11.69µs), ("find canonical header", 13.52µs), ("split chain", 590ns), ("split chain forks", 270ns), ("merge all chains", 500ns), ("update canonical index", 2.97µs), ("commit canonical chain to database", 992.818124ms)]

oops, sorry, just saw previous comments and the diff. @mattsse see my comment above about relative recordings

any action added in between record_relative calls will require creating new action and recording it as well.

I think we're already tracking a lot and areas that are now part of an action are negligible, so I think adding another clock syscall per record is not worth it

@mattsse this is more of a maintenance question than benefitting any individual action. i'd be more in favor of scoping the recorded actions, but agree that it is rather invasive

i'd be more in favor of scoping the recorded actions

agree, but I'd rather do it via tracing separate more granular methods instead of passing closures, but it would require breaking down the existing functions.


cleanup Credit

Remove deprecated Credit parameters #6014

Welcome to the Cesium community @Jahrkor!
Can you please send in a Contributor License Agreement (CLA) so that we can review and merge this pull request?
:warning: I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.
:earth_africa: :earth_americas: :earth_asia:

We now have a CLA from @Jahrkor.
Thanks again for the contribution!

Thanks @Jahrkor!  You'll also need to remove the deprecationWarning and the if block from lines 36-40

Hi @Jahrkor, thanks for the PR!
It looks like you have some esLint failures, see the build log. Can you resolve those?

Great @Jahrkor !  One last thing:  can you remove the deprecationWarning from the requires at the top of the file?


Certain AH showing as "Not provided"

In edge case where they were a previous AH but are now the 'A', they are showing up as other. @LisaMoore1 here's an issue for the fix I did and data I sent to review.

Import cronjob set to watch range-myra-api:hotfix temporarily to allow this to go out.  Checked in prod and things look good.


sql error

Sharding-Proxy rc4

[Err] 1054 - Unknown column 'aa.journal_template_type' in 'order clause'

it's ok

Can you change the title for search friendly?


Update network id for cpouta devel

Probably following a cpouta devel rebuild, the network id of the previous test network has been changed. This simple PR updates its value to the current one.

LGTM. You know it already but will still mention this will require a git pull to the three directories on the build server to get everything even steven


[Feature] Add pagination method to REST queries

https://docs.github.com/en/rest/guides/traversing-with-pagination


Add CI runner to check we can compile with older cmake versions

We had a report that the code fails to compile with cmake 3.23, which is not ideal. It would be nice to make sure we can compile the code on older cmake, idealy cmake 3.16 like metatensor/rascaline (this is the version on Debian stable).

Living on the edge. Will only compile with cmake_nightly.


Crash on startup of project manager and startup of editor (DisplayServer regression)

Godot version
4.0.dev
System information
Arch (Linux-lts 5.15.36-1) with i3 window manager
Issue description
This issue probably only happens on tiling window managers I think.
Whenever I start up the project manager or a project, and right after that I switch my workspaces so the project/project manager startups in an inactive screen, Godot just doesn't open and crashes. This has been happening since Alpha 1.
This is the log I got just now:

Steps to reproduce
In a tiling window manager, open a project or the project manager and switch workspaces while the program is starting.
Minimal reproduction project
No response

Can you reproduce this if you start Godot with the --single-window command line argument?

Can you reproduce this if you start Godot with the --single-window command line argument?

When using this, no crashes anymore. So should I just change my .desktop files to include this? I enabled the setting single window mode in the editor settings, but this is something different, is it?

So should I just change my .desktop files to include this? I enabled the setting single window mode in the editor settings, but this is something different, is it?

--single-window is exactly the same, although it can be used to enable single-window mode before you open the editor for the first time. (The editor setting is also used in the project manager.)
I recommend editing your .desktop file for now, but ideally, Godot should automatically use single-window mode if a tiling WM is detected. I don't expect a multi-window mode to actually work well when using a tiling WM.

I recommend editing your .desktop file for now, but ideally, Godot should automatically use single-window mode if a tiling WM is detected. I don't expect Godot's multi-window mode to actually work well when using a tiling WM.

That's what I will do then for now. Should this issue stay open then until there is a patch for this?

Should this issue stay open then until there is a patch for this?

Yes, I'd prefer keeping this issue open until we manage to implement a fix.

Has the similar problem. All 4.0 alphas crashes when I switch to another desctop while the project manager startup or while the editor loads a project. The --single-window and enabling "Single Window" option in the editor settings has no effect.
Kubuntu 20.04
KDE Plasma 5.18.8
KDE Frameworks 5.68.0
QT 5.12.8
Kernel 5.4.0-113-generic

This should be fixed by #64943

Can confirm that this is fixed now, no longer do I need to stop my multitasking behavior of flying through windows. Thank you!


fix(helm): --set for out of order list values

When a user specifies value overrides for list values out of order,
strvals.listItem panics. Change strvals.listItem to handle this case by
re-initializing nil values to a new map.
Closes #4503
Co-authored-by: Cameron Childress<EMAIL_ADDRESS>Co-authored-by: Kevin Collette<EMAIL_ADDRESS>Co-authored-by: Connor McKelvey<EMAIL_ADDRESS>Co-authored-by: Dan Winter<EMAIL_ADDRESS>Signed-off-by: Dan Winter<EMAIL_ADDRESS>

slating for 2.12 for review

@danjwinter Thanks for the PR. I tested and reviewed it and the code looks good.
While you had co-authors they each need to have a signoff for the commit. Would it be possible to get a Signed-off-by line for each of them? If they co-authored they technically need to signoff on their contributions. Yeah, following the DCO can sometimes have some little annoying details. Thanks.

Final boarding call for amending the commit to make it in for the 2.12 merge window! ✈

@bacongobbler @mattfarina added, sorry for the delay!


Narrow webmention discovery

Right now we run webmention discovery liberally on incoming activities' "targets," eg inReplyTo, mentions, etc. In practice, these are almost all fediverse/Mastodon URLs that don't accept webmentions. We should probably do one or both of:

Load and reuse Bridgy's blocklist
Only do webmention discovery on users' domains

Simpler start here is just to cache wm discovery. Ideally we'd move Bridgy's existing caching into webutil.webmention, opt in somehow, maybe via kwarg.

As for a blocklist of all existing AP instances, fediverse.observer and the-federation.info both have APIs over their node lists, easy to export all the domains. They have 46k and 41k respectively, 36k in common, 13k in just one or the other.
https://api.fediverse.observer/ :
query MyQuery {
  thefederation_node {
    host
  }
}

and https://cloud.hasura.io/public/graphiql?endpoint=https%3A%2F%2Fthe-federation.info%2Fv1%2Fgraphql
query MyQuery {
  nodes {
    domain
  }
}

Added wm discovery caching. It's ok, but not great, since right now we churn instances pretty frequently. Eventually the full fediverse instance blocklist would be useful.

#552 would help here.

This shouldn't be happening now that we do protocol discovery.


updating

Docs Build status updates of commit c04ce7c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

azureadps-2.0/AzureAD/AzureActiveDirectory.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Fix node descriptions

Fixes #49

Pull Request Test Coverage Report for Build 116

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.541%

Totals

Change from base Build 114:
0.0%

Covered Lines:
200

Relevant Lines:
204

💛  - Coveralls


[image] create --source now identifies disk from ID instead of vm, when there is a naming conflict.

image create --source now identifies disk from ID instead of vm, when there is a naming conflict.
Closes #4814

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[x] I adhere to the Command Guidelines.

Will add tests @yugangw-msft

Done @yugangw-msft

ping @yugangw-msft

I will merge this at the end of today @yugangw-msft, if that's fine with you.


Full proofs of inverse_mix_columns

Resolves #295
This PR fills in the last two admits that were left in #504, which stated that modular multiplication in the AES byte field was associative and distributive.
The strategy here is very computational; after investigating a bit and determining that proving the properties we needed in full generality (i.e. for all polynomials) would likely be very time-consuming, I took advantage of the fact that the AES field has a fixed modulus to write explicit expressions in terms of the input for modular reduction, multiplication, and addition in terms of GF(2) (bit) operations, and then used Coq's ring tactic to prove these equivalent.
Because of the computational strategy (which results in pretty large expressions), the proofs are unfortunately pretty slow. Compiling MixColumns.v takes about a minute on my laptop. The proofs have few dependencies, though, so they should be highly parallelizable and hopefully won't do too much damage to our CI time.
CC @cipher1024 The explicit formulas for byte multiplication/modulo might be helpful for mix_columns proofs.

Looks like the CI does parallelize this well enough to avoid a major performance hit -- I ran the CI twice, and got one run on the high end of our recent CI runtimes and one on the low end.


geopoint attribute not working

Hi I'm trying to use GeoPoint type, but it's being mapped to string:
indexProperties.geolocation.type | string
Here's how I'm using in my code:
            [GeoPoint]
            public GeoLocation GeoLocation
            {
                get
                {
                    return new GeoLocation(double.Parse(latitudeDeg), double.Parse(longitudeDeg));
                }
            }

Can you show the code that you're using to map the geopoint property to a mapping in an index please?

@thdotnet do you have a complete but succinct example that you can share, that shows the issue?

As I am no longer using it, I'll close the issue.


Write readme and add sphinx doc

[x] add readme
[x] set up sphinx and readthedocs for the code documentation
depends on #29 #28

Codecov Report
Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 83.90%. Comparing base (76eeac8) to head (87dd108).

Files
Patch %
Lines

src/faunanet_record/set_up.py
50.00%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   83.78%   83.90%   +0.12%
==========================================
  Files           6        6
  Lines         259      261       +2
  Branches       66       66
==========================================
+ Hits          217      219       +2
  Misses         23       23
  Partials       19       19

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

current documentation build: https://isparrowrecord.readthedocs.io/en/latest/
this only contains the readme and the code documentation. didn´t write anything more because I feel that is enough for this little package.


cmake required

Make sure you have cmake installed, otherwise it will silently fail. Should be in docs.

It is already there:
Make sure cmake is installed on your system and install python prerequisites:


Update java doc

We've added some features in 3.0 so we need to update the limitations section on the Java client.

Thank you, @mikaelm12!


Curve3d baking refactor

Related with PR #64043, PR #63956 there are two purpose of this PR:

Continuing #64043 's effort, move all remaining rotation interpolation modes from PathFollower3D to Curve3D
Reimplement baking for Curve3D with geometry methods of Basis class

The new implementation should be more stable. Although I test it for some cases, further testers are needed, as I mainly use Curve2D for current project.

Do you have a proposal or an issue that this closes? We ask that our contributors first document the problem or limitation that they experience, so that other contributors, users, and maintainers can find the best solution. A PR that adds new API needs a proposal, and a PR that fixes a bug needs a bug report.
You would also need to squash all your commits into one before this can be merged (but this can be done after the code review).

Do you have a proposal or an issue that this closes? We ask that our contributors first document the problem or limitation that they experience, so that other contributors, users, and maintainers can find the best solution. A PR that adds new API needs a proposal, and a PR that fixes a bug needs a bug report.
You would also need to squash all your commits into one before this can be merged (but this can be done after the code review).

Thanks for the advice, this is my first effort to submit code on Github, and is still trying to figure out the proper procedure. I add a proposal.

Thanks for the advice, this is my first effort to submit code on Github, and is still trying to figure out the proper procedure.

It often depends from project to project. We have our procedures explained in the documentation for contributors:
https://docs.godotengine.org/en/stable/community/contributing/index.html

@TokageItLab I will look at this too.

I tested my implementation with examples in the following tickets:

it seems all worked well.

Something is odd. There are 6 ways to convert euler to quaternion. You only have 3.

Something is odd. There are 6 ways to convert euler to quaternion. You only have 3.

Because only those 3 are presented in the old implementation. I can add the rest 3 if necessary.

Is there anything blocking this now that the 2D equivalent has been merged?

A major refactor of the sampling methods on baked points. The main changes are

Factor out the binary search code, repeated in several sampling methods, into a new method _find_interval().
rearrange the error checking calls, in order to avoid redundant checks.
Add tilt_enable property to PathFollow3D, to control whether it honers the tilt of the Curve3D

Now this PR should be ready for review. I plan to start coding this proposal once this PR merged, as sample_baked_with_rotation() method added in this PR is essential for an clean implementation.

I think it is fine to correct the baking process. But I don't see the need to move the rotation process to Curve3D from PathFollower. I assume that the rotation process is still the role of PathFollower. Can you elaborate about this?

This PR is related with PR https://github.com/godotengine/godot/pull/63956, which do the same thing for PathFollower2D.
The idea is allowing sample curves without pathfollower. The pathfollower just use the sample methods on curves, instead implement its own.
The end user of pathfollower should not be affected. For them this change is transparent, just an implementation detail.

But isn't sample_baked_with_rotation used by anyone other than pathfollower?

Yes, currently PathFollow3D is the only user of sample_baked_with_rotation in the editor. But I think this method should be put on Curve3D instead of PathFollow3D for the following reasons:

sample_baked method which samples position is on Curve3D; it feels symmetrical to have a sample_baked_with_rotation:grin:. This is actually my initial motivation.
It can be useful for other part of the engine/editor. For example, if I were to implement a fish bone visualization of path for the Path3DEditorPlugin, I need to sample the rotation frames along the curve. If sample_baked_with_rotation were on PathFollow3D, it will be awkward for Path3Ds without a PathFollow3D.
It can be useful for other curve-sampling-intensive applications. One example, I am developing a city road traffic game which depicts thousands of cars run along curved road.  I could sample the road with PathFollower3D, but do that for thousands or tens of thousands times per frame is very ineffective. I am sure there are other people could benefit from fast curve sampling
Bottom line is, for existing PathFollow3D user, there is no functional change, they can use it as if nothing has changed.

Hope these consideration, especially #4:wink:, addressed your concerns.

5 is not a concern. Rather, the question is whether the use case for 3 really exists, since it is a bad move to have an API in Curve3D that is not used by anyone other than Path3D.

Fair enough. How about number 2?

I think sampling multiple times per frame is the wrong implementation to begin with. Baked curves should be cached in Path3D.

I think sampling multiple times per frame is the wrong implementation to begin with. Baked curves should be cached in Path3D or PathFollower3D.

If you look at the code, the curves are baked, to a given interval length(say every 0.2 meter). But if the position is between those points, you have to sampling again...

With this implementation, can't we use a single curve when each object has a different RotationMode?

If PathFollow3D::RotationMode is bound correctly, then PathFollow3D::RotationMode should be available as an argument to Curve3D::sample_baked_with_rotation() as follow:
Curve3D::sample_baked_with_rotation(PathFollow3D::RotationMode p_rotation_mode)

However, I still don't see why sample_baked_with_rotation() really needs to be implemented within Curve3D instead Path3D or PathFollow3D.

It can be useful for other part of the editor. For example, if I were to implement a https://github.com/godotengine/godot-proposals/issues/5716 visualization of Path3D for the Path3DEditorPlugin, I need to sample the rotation frames along the curve. If sample_baked_with_rotation were on PathFollow3D, it will be awkward for Path3Ds without a PathFollow3D.

If fish bones are needed for Path3D gizmo, sample_baked_with_rotation should be implemented in Path3D, not Curve3D.

It can be useful for other curve-sampling-intensive applications. One example, I am developing a city road traffic game which depicts thousands of cars run along curved road. I could sample the road with PathFollower3D, but do that for thousands or tens of thousands times per frame feels very inefficient. I am sure fast curve sampling could benefit other people.

I don't see clearly why the calculation is reduced for this as well. At least if there are multiple PathFollower3Ds, isn't there one Path3D? Then couldn't it implement sample_baked_with_rotation in Path3D instead of Curve3D?

Also for about https://github.com/godotengine/godot-proposals/issues/5716.

Since Path3D is just a thin wrapper of Curve3D, the rotation sampling logic need to be add on the Curve3D first.

This is wrong. Path3D is Node, Curve3D is Resource.
Curve3D is just a cubic Bezier curve with only informations for drawing such as inflection points, and should not have meaningless information as a cubic curve such as orientation. When it come Path3D, it can finally have information such as orientation and rotation.

Or, conversely, it is possible to remove the PathFollow3D::RotationMode. There is no need to define the same enum twice.
Ok, that is a fair point. I kept the Curve3D::RotationMode insead of PathFollow3D::RotationMode, as it feels more natural to let PathFollow3D depend on Curve3D than the other way around. Thanks!

However, I still don't see why sample_baked_with_rotation() really needs to be implemented within Curve3D instead Path3D or PathFollow3D
Take a urban traffic game such as City Skyline as example. If I want to implement the road system in Godot, then my first choice is to represent road with Path3D, and each car is a mesh bind to PathFollow3D.

However this implementation will quickly become inefficient when there are hundreds of cars on one road. One way to optimize this is to define a Road class, which render cars by calling RenderServer directly. This Road class still needs to sample the curve to get the position and location of each car. If we still do it through PathFollow3D it will feel very awkward.

If fish bones are needed for Path3D gizmo, sample_baked_with_rotation() should be implemented in Path3D, not Curve3D
Then couldn't it implement sample_baked_with_rotation() in Path3D instead of Curve3D?
Curve3D is just a cubic Bezier curve with only informations for drawing such as inflection points, and should not have meaningless information as a cubic curve such as orientation. When it come Path3D, it can finally have information such as orientation and rotation.

So if I understand correctly, your main concern is that rotation is not an intrinsic part of a Curve3D so it should not be sampled on Curve?
First I think we can agree that position is an intrinsic part of a curve, as we already have an Curve3D::sample_baked(). The situation of the rotation frame is not very different from the position, as we can define mathematically rotation frame for most reasonable curves (For example Frenet method using tangent and bi-normal)
Beside this theoretical point, implementing rotation baking on Curve3D instead of Path3D have two practical advantages.

API consistency. We already have Curve2D::sample_baked_with_rotation(), a 3D  counterpart is easier for user to find.
Avoid redundancy. When I say "Path3D is just a thin wrapper of Curve3D", I mean the Path3D did very little thing for the Curve3D except to instantiate it into the scene tree, and probably we should keep it that way by not adding other sampling method there. Then in use cases where other class provides the instantiation(such as the Road class of urban traffic game), use Curve3D through Path3D is redundant.

Hope these reason addressed the questions.

First I think we can agree that position is an intrinsic part of a curve, as we already have an Curve3D::sample_baked(). The situation of the rotation frame is not very different from the position, as we can define mathematically rotation frame for most reasonable curves (For example Frenet method using tangent and bi-normal)

No. For example, you can get a reflection vector from Line2D and a Vector2, but that should be done outside of the Line2D class, since it is not in the essence of Line2D.
Also, RotationMode should be defined for PathFollow3D or Path3D, not Curve3D.

For example, you can get a reflection vector from Line2D with external Vector2, but that should be done outside of the Line2D class, since it is not in the essence of Line2D

You mean Vector2D::reflect()? Of course it is not the essence the Line2D. Line2D just happens to use it. So the dependency order is Line2D -> Vector2D.
In the situation of Curve3D, I think the reasonable dependency order is PathFollow3D->Path3D->Curve3D. Can we agree on this?

What is allowed to be implemented in Curve3D is what can be extracted from the information contained in Cueve3D. So it is possible to implement functions to get the normals at points. But since sample_baked_with_rotation() requires RotationMode which is external vector, it must be processed outside of Curve3D.

Ok, how about this:
keep the RotationMode unrelated sampling logic in Curve3D::sample_baked_with_rotation(), and move the RotationMode related logic such as locking Euler axes to the PathFollow3D ?

Do you mean that you want implement like Basis sample_baked_rotation(real_t p_offset, bool p_cubic = false, bool p_apply_tilt = false) const;? I think something like a derivative could be implemented in Curve3D, but I think we wouldn't call it a Rotation.

Take a urban traffic game such as City Skyline as example. If I want to implement the road system in Godot, then my first choice is to represent road with Path3D, and each car is a mesh bind to PathFollow3D.

However this implementation will quickly become inefficient when there are hundreds of cars on one road. One way to optimize this is to define a Road class, which render cars by calling RenderServer directly. This Road class still needs to sample the curve to get the position and location of each car. If we still do it through PathFollow3D it will feel very awkward.
I have a very similar use case. I want to be able to easily sample the curve w/o PathFollow3D to cut down on the number of nodes around.

@Zireael07 Sampling with PathFollow3D may not good. So wouldn't it be enough to implement sampling in Path3D instead of Curve3D?

@TokageItLab Either is fine as long as it's possible to easily sample/follow w/o PathFollow3D

@Zireael07 In my opinion, the starting point, ending point, and such as get_transform(float p_offset, RotationMode protation_mode) can be implemented in Path3D.
Then, PathFollow3D should be able to just get the transform from Path3D and follow it. And, if necessary, you can get the transform directly from the Path3D in your scripts.

Do you mean that you want to implement like Basis sample_baked_rotation(real_t p_offset, bool p_cubic, bool p_apply_tilt) const;? I think something like a derivative could be implemented in Curve3D, but I think we wouldn't call it a Rotation.

I pushed a new version. The API is
Transform3D sample_baked_with_rotation(real_t p_offset, bool p_cubic = false, bool p_apply_tilt = false) const;
to be consistent with the current 2D counterpart
Transform2D sample_baked_with_rotation(real_t p_offset, bool p_cubic = false, bool p_loop = true, real_t p_lookahead = 4.0) const
If we need to change name, it probably can be done in following PR, as both 2D and 3D need to be coordinated.

Can you check that your new code uses sentence casing?

Does it handle properly about tilt? The behavior seems to be different than before obviously.

Can you check that your new code uses sentence casing comments?

Done. Thanks for help checking these comments, appreciate it. Those lower casing comment comes from the old code, so I thought that is the convention. And "a", "the" don't have counterparts in my native language, so I always tend to get them wrong...

Does it process correctly about tilt? The behavior seems to be different than before obviously.

I think so. The _bake() method produces smooth rotation frames at baked points, tilt is applied in _sample_posture.

First the _bake() method produces smooth rotation frames at baked points, then tilt is applied in _sample_posture. This division make the intention more clear.

The previous implementation applied the tilt after the correct_posture. But your implementation applies the tilt before the correct_posture, and it looks like the correct_posture overrides it, making it ineffective maybe.
But honestly, I feel that the original implementation of the tilt is a bit useless. This will be a separate proposal, but I think it would be better to eliminate the Curve3D tilt and have a Curve graph on the Path or PathFollow side to Twist.

The previous implementation applied the tilt depends on RotationMode after the correct_posture. But your implementation applies the tilt with ignoring RotationMode before the correct_posture,

My implementation always apply tilt in _sample_posture(), before correct_posture, which apply RotationMode.

it making tilt ineffective maybe
To apply tilt before or after correct_posture, I think, depends on how do we understand the role of tilt. In my case it is considered an intrinsic part of Curve3D, so it should be applied before. But If it is considered an artistic control then it should be applied after.

This will be a separate proposal, but I think it would be better to eliminate the Curve3D tilt and have a Curve graph on the Path or PathFollow side to Twist

Agreed, intrinsic or artistic control. It is a debatable point. If it is an artistic control it should be in PathFollow3D like the posture modification.

But I think the tilt is valid when creating roads with twists.
Can you apply tilts after correct_posture depending on the RotationMode like implementing PathFollow3D::apply_tilt(real_t p_tilt, RotationMode p_rotation)?

To do it properly, the tilt data also need to be move to PathFollow3D. This PR discussion is already too long, better to leave it to following PR.

To do it properly, the tilt data also need to be moved to PathFollow3D

I think you just need to sample using Curve3D::sample_baked_tilt().

I think you just need to sample using Curve3D::sample_baked_tilt() in PathFollow3D.

Technically, probably yes. But conceptually it is inconsistent with our consensus.

So now our consensus is this: rotation frame on Curve3D, artistic control on PathFollow3D. Do I understand correctly?

If you really want that, probably you can do it in a following PR.

Technically, probably yes. But conceptually it is inconsistent with our consensus.

Leaving aside the consensus, it is better to keep behavior changes to a minimum. Before you hide that behavior in this PR, we need to discuss whether old behavior is really unnecessary.

Before you hide that behavior in this PR, we need to discuss whether old behavior is really unnecessary or not.
But honestly, I feel that the original implementation of the tilt is a bit useless.

As you already said, the old behavior is not particularly useful, and I agree with you. If you need the opinions of others, I can wait.

Leaving aside the consensus

I take our consensus quit seriously

I am really glad we come to some consensus, as to allow Curve3D to be sampled without going through other layer is the raison d'être of this PR. I will try my best to follow through.
So now our consensus is this: rotation frame on Curve3D, artistic control on PathFollow3D. Do I understand correctly?

Maybe it is my misunderstanding, this no such consensus?

artistic control on PathFollow3D

There is no consensus on this yet. It is impossible to determine, as even this PR description does not compare the two enough. It is recommended that the original behavior be retained so that this can be properly discussed in another PR.

There is no consensus on this yet.

Ok, then it is my misunderstanding.

It is impossible to determine, as even this PR description does not compare the two enough. It is recommended that the original behavior be retained so that this can be properly discussed in another PR.

I propose the comparison can be done by user between new build and original build, if the old behavior is indeed better, it can be implemented properly in following PR(move both data and behavior to PathFollow3D).
Honestly this PR discussion is too long (arguably the longest per file? 130+ post for just 6 files), it seems this part is too intricate for me. I propose we wrap it up here, or leave it to someone more capable.

Let's keep the old behavior for now but keep the new TNB code somewhere so that it can be reused in a follow-up PR

The actual discussion is not that much since most of the comments are syntax and variable name corrections and your responses to them.
The length of the discussion is not the point, in refactoring it is important to be careful and to implement it correctly.

the old behavior should be retained to reduce discussion in this PR
done

Need to squash.

, but I think that most of problem has been removed and it becomes readable in some extent now. The behavior is not perfect, but it is better than before. Thank you for hard working :)

Also thank you for all your effort putting into this PR. Hope we can get to consensus faster in future PRs :)

@YuriSizov is it possible to move this PR to 4.0 milestone? Considering the Curve2D counterpart has already been merged.

Thanks!

This change seems to have changed the behavior for Curve3D::sample_baked_up_vector() I noticed this while rebasing my changes for #68873 which adds a visual indicator and editable handle for the tilt of a Curve3D.
Here is a screenshot of a curve with tilt 0 for all points before and after this was merged:
My change rebased on top of 8ab3e73a799bbfa862403747a5de9fc96ba83149^ (immediately before the merge):

My change rebased on top of master:

(Admittedly, I didn't git-bisect I just looked at the git log for curve.cpp)
You can see the up vectors are 90 degrees from their previous location.

@xiongyaohua Might it be possible that normal is being baked by mistake? In any case, the Path3D area is refactoring now, so if anyone find anything odd, we should open an issue and discuss it each time @Ademan.


Cannot read property 'isUnion' of undefined

I receive an error from the no-array-destructuring rule at this line:
 const {                                         items: [{ phone }]                                     } = await response.json();
The stack trace is:
[Error - 1:43:28 AM] TypeError: Cannot read property 'isUnion' of undefined
    at ArrayPattern (node_modules/eslint-plugin-total-functions/dist/rules/no-array-destructuring.js:44:51)
    at node_modules/eslint/lib/linter/safe-emitter.js:45:58
    at Array.forEach (<anonymous>)
    at Object.emit (node_modules/eslint/lib/linter/safe-emitter.js:45:38)
    at NodeEventGenerator.applySelector (node_modules/eslint/lib/linter/node-event-generator.js:254:26)
    at NodeEventGenerator.applySelectors (node_modules/eslint/lib/linter/node-event-generator.js:283:22)
    at NodeEventGenerator.enterNode (node_modules/eslint/lib/linter/node-event-generator.js:297:14)
    at CodePathAnalyzer.enterNode (node_modules/eslint/lib/linter/code-path-analysis/code-path-analyzer.js:635:23)
    at node_modules/eslint/lib/linter/linter.js:949:32
    at Array.forEach (<anonymous>)```

This should be fixed in v1.18.0. Thanks for reporting.


Should a simplest possible template be added for beginners?

I'm using Vue with relatively new JavaScript developers in some of my curricula and I wondered whether a simple template might be useful for beginners who just want to dive into a simple, single-file, single-component app. No Webpack, Browserify, Babel, etc - just plain HTML and JavaScript.
Possibly something like this?
<!DOCTYPE html>

  <title>Welcome to Vue</title>

{{ greeting }}

        To learn more about Vue, visit

          {{ humanizeURL(docsURL) }}

        For live help with simple questions, check out

          the Gitter chat

        For more complex questions, post to

          the forum

I could see this useful, although the docs already suggests starting with a jsfiddle: https://jsfiddle.net/yyx990803/okv0rgrk/
I personally think the CLI's purpose is doing the "heavy lifting" for scenarios with at least medium complexity.
On the other hand I feel there could be a simpler way to let people try out single file components (*.vue files). http://www.webpackbin.com/ is soon going to support that, which is great. There could also be an in-browser transform for *.vue files - which would be ideal for quick prototyping and could potentially serve as the "simplest boilerplate" - once you are happy with the idea you can simply port the *.vue files into a more complete boilerplate.

I like the jsfiddle, but for some students, I've found the extra layer of abstraction can make it difficult to transfer what they learn to a real file in a text editor. As a result, I try to have people coding real, complete projects as soon as possible (and ideally from the very beginning).
Some kind of dead simple template would help in this regard. I do like the idea of an in-browser transform for *.vue files, but I worry that even introducing the (albeit core) idea of components is too much complexity to start with. Unlike the other templates, the purpose wouldn't be to facilitate prototyping, boost productivity, or consolidate community knowledge. It would actually never be used by more experienced devs, but rather would act as an entry point for less experienced devs.
It'd give them a small taste of (and introduction to) the tooling in the Vue ecosystem, as well as a demonstration of how truly simple adding Vue to a project is - even for those who are just now looking to move beyond jQuery. My hope would be that over time, it would help those less experienced developers see that they don't actually need a template for apps this simple. Until they get to that point though, they'd have some training wheels.
And in terms of bringing new people into the ecosystem, I think it could do a lot to make Vue's simplicity even more apparent to newcomers. And I think this is vital, because it stands in stark contrast to what's probably the most popular, direct competitor: React. I'm also an enthusiastic member of the React ecosystem, but despite the possibly smaller API, using it in even simple projects is far from trivial.
So that's sort of what I'm thinking. Sorry for not being able to better communicate that earlier! What are your thoughts?

Sure! I can add you to the vuejs-templates organization to work on that - that would also give you privilege to manage issues in other templates. Are you interested in that?

Sounds great! :smiley: Do you have any policies I should stick to? (For example, when issues should be closed or what's definitely out-of-scope for a template.)

Not at this moment, I guess just use your best judgement. If not sure just mention me :)

:+1: Will do.

@yyx990803 It looks like I can add new repositories, but don't yet have access to moderate / write to current repos.

Should be good now.

Confirmed. :smiley: Thanks again!

Done: vuejs-templates/simple


Different font

I think Open Sans or Roboto is better readable as Abel.
Maybe only use Abel for title's but not for text. I think Abel is a beatifull font but not very read friendly.

@RichardLindhout  i have change it to : "Helvetica Neue", Helvetica, Arial, sans-serif


Terraform plan fetching the secret (client.Retrievesecret) instead of generating a plan for upcoming action

I used this code to fetch the secret from Conjur.
But I can see two entries of audit log in the Conjur UI that the user is actually fetching the secret twice
->First fetch is done during the Terraform plan
->Second fetch is done during the Terraform apply
How to prevent the fetch done during the Terraform plan?

Hi, I believe fetching the secret during the plan phase is intended behavior. When running terraform apply are you passing in the saved plan file (eg. terraform apply "tfplan")? If no plan file is passed to apply then the plan phase will be executed again. Please share the commands used for plan and apply. Thanks


tabnine It still interferes with normal advice

As shown in the figure above, a very simple syntax completion is implemented
Once tabNine is enabled, the above extension will not work

hey @2234839, according to the API of the DocumentFilter - only the pattern property is  GlobPattern, the language and the scheme  properties are strings and hence the value of '*' will be addressed as string and not as pattern.
can you please try your example with the pattern: "**" or the language and the scheme with valid values?
I've attached some examples:
1 - with TabNine extension and pattern: "**" as the filter
provider registration:

usage:

both extension are working
2 - without TabNine extension and the provider is registered with language: "*", scheme:"*"
provider registration :

usage:

the registered extension is not working

Closing as we need more info from the original poster


inicializarFastCachedImage got error on Windows

My App is got this error on windows:
Error  inicializarFastCachedImage : PathAccessException: lock failed, path = 'C:\Users\myUser\Documents\cachedimageskeys.lock' (OS Error: The process cannot access the file because another process has locked part of the file.
How to prevent it from disrupting the functioning of my App?

i faced the same problem i have traced this location and there an another app use this file so i closed it and deleted and it's worked fine


Merge pull request #1 from ctripcorp/master

update

Codecov Report

Merging #2545 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2545      +/-   ##
============================================
+ Coverage     50.18%   50.19%   +<.01%
- Complexity     2046     2047       +1
============================================
  Files           410      410
  Lines         12556    12556
  Branches       1285     1285
============================================
+ Hits           6301     6302       +1
  Misses         5808     5808
+ Partials        447      446       -1

Impacted Files
Coverage Δ
Complexity Δ

...ervice/service/ReleaseMessageServiceWithCache.java
87.05% <0%> (+1.17%)
25% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 932e3ed...d4aa758. Read the comment docs.

Coverage remained the same at 53.743% when pulling d4aa758f467220025bbd0aeb536ce9217e5c8160 on yeming233:master into 932e3ed5de37ba863c1473477f79fa4d40b0beea on ctripcorp:master.


Added Unicode block element support

Summary
This PR implements support for rendering QR codes using the block elements available in Unicode. Two lines can be rendered as one, using FULL BLOCK, UPPER HALF BLOCK and LOWER HALF BLOCK. While it would also be possible to use the quadrant characters, reducing the string length even further, they are very rarely implemented in fonts.
The name Utf8QRCode is definitely up for discussion :)

I see now that this was also done in #384 . Didn't see it, since it was called ASCII, which it isn't :)

Hi @gliljas ,
thanks for your PR and the work you put into it. I reviewed your PR as also the aforementioned PR #384 and decided for the latter at the end.
Reason: I like the integration into the existing ASCIIQRCode more that having a another separate renderer with nearly the same use-case/output. Nevertheless your code was very inspiring and a took parts of your ideas into the codebase from #384. (E.g. the invert parameter as also the fixed size/capacity of the string builder.)
I mentioned in the release notes and hope this is fine for you: https://github.com/codebude/QRCoder/wiki/Release-Notes#150
Regarding the naming "ASCIIQRCode" and your note (it was called ASCII, which it isn't :)) on it, I added an explanation in the wiki which reads out as follows:

Trivia: The renderer is called Ascii renderer, although it uses characters from the Utf-8 character set by default. The idea behind this is that the renderer uses a text-based graphical representation that is reminiscent of classic Ascii art. Naming it Utf8QrCode was rejected in the design phase, as it would be difficult to deduce from this name what type of return value the renderer has.

I hope this helps to avoid confusion. :-)
Thanks again!


Review PR for node-docs.md

Guidelines for reviewers
Using this Pull Request (PR), you can:

Add general comments about the article in this PR
Add a comment to a specific line in one of the files that make up this article
Propose edits to the article

You can view the published version of this article at:
https://azure.microsoft.com/documentation/articles/node-docs/
Add general comments
To add a general comment, use this page (Conversation tab)
Add comments to a specific line
To add a comment to specific line, go to the Files changed tab, hover your mouse pointer over the line in the file and click the blue + to add a new line comment.
Propose edits to the article
To propose edits to this article, go to the Files changed tab, find the file you want to edit and click the pencil icon (Change this file using the online editor), and make your changes. When you are done you will be prompted to create a PR that contains your proposed changes.

Note: The PR with your proposed changes will be pushing changes to the dominicbetts/azure-content-pr:edit-node-docs branch.

I've created a work item to do this throughout the whole repo.

Processed all feedback up to here.


Make AllocatedR1CSInstance and AllocatedRelaxedR1CSInstance generic in the size of IO

This PR resolves #321.
The solution adds a const generic parameter to the two structs, and a new constant that is used in both the Nova and SuperNova augmented circuits where the instances are known to have IO of length 2.

I think I cleaned up some of the nasty stuff I was doing with iterators, it should be a bit better now!


typescript migration

remove babel and use typescript instead

Deploy preview processing.
Built with commit 31f492d111dd6a1fe638766f5e3a58720e273425
https://app.netlify.com/sites/csurvey/deploys/59bb6696a700c4286cd2d064


Why not LibreSSL instead of OpenSSL?

duplicate #85

Sorry. Thanks for pointing it out.

I forgot I asked the same months ago.


updated home page according to new figma design

It would be really helpful if you could attach some screenshots of the updated design

except for the navbar and the font, almost everything is identical.
and for the navbar, I have already created a new issue

Looks good


Unhandled Runtime Error When using remarkCodeHike

Hello, I'm moving from contentlayer to velite and everything is great until I tried adding remarkCodeHike to remarkPlugins.
The error would occur by simply adding the remark plugin
import { defineConfig } from "velite";
import { remarkCodeHike } from "@code-hike/mdx";

export default defineConfig({
    root: "content",
    collections: {
        // collections
    },
    mdx: {
        remarkPlugins: [
            remarkCodeHike
        ]
    }
})

Unhandled Runtime Error
Error: await is only valid in async functions and the top level bodies of modules

Source
src\components\ui\MDX\index.tsx (5:15) @ useMDXComponents

  3 |
  4 | const useMDXComponents = (code: string) => {
> 5 | const fn = new Function(code)
    |           ^
  6 | return fn({ ...runtime }).default
  7 | }
  8 |

Here is a fork of next.js example with codehike added to show the error:
https://stackblitz.com/edit/velite-nextjs-ladcsb?file=readme.md
navigate to /about page
I'm thinking this is caused by how mdx is compiled in velite.

https://codehike.org/docs/introduction#limitations
its a bit awkward. Velite built-in s.mdx() schema used MDX v3.x
If you have to use this plug-in, you can consider implementing an old version of mdx with a schema by yourself
https://codehike.org/docs/configuration#auto-import
If there is no special reason, https://rehype-pretty-code.netlify.app/ Is a very good choice

Would it be possible to add recma plugins support sometime in the future for codehike v1?
see https://github.com/code-hike/codehike/discussions/413#discussioncomment-10018509

I believe the new beta version does use mdx v3
https://github.com/code-hike/v1/blob/main/packages/codehike/package.json


Gather IPv6

IPv6 are not well gathered...
If the app is beind a proxy, it's the proxy's ip

Comme from Docker when IPv6 is not configured


Source release configuration directory handling completely broken

Xmake Version
2.7.4
Operating System Version and Architecture
Source tarball, extracted on Linux
Describe Bug
There are several issues with the source tarball and included configure script shipped in v2.7.4. This seems like a GNU Autotools style configure script, but it doesn't actually work in any of the standard ways. As a downstream packager I would appreciate if it was fixed so the expected functions work as in autotools. If you need help doing this right I may be able to help setup the tooling.
Here are some of the issues:

The sources don't extract with a top level directory. This makes a huge mess because the tar has no root directory. Sources build with make dist will always have the version number in the name and extract to a matching top level directory.

The configure script does not accept ./configure --prefix=.... This is standard usage for distro packagers that don't use the usual /usr/local defaults and want to set /usr or similar instead.

The make install DESTDIR="..." does not function to accept a base director. This is also standard usage. This and no 2 only work if bundled together as make install PREFIX="/base/prefix", but this is broken non-standard usage.

There may be more, I gave up trying to use it at all when I discovered the prefix and destination handling was cross wired.
Expected Behavior
A top level directory in the source tarball, a --prefix configure flag that works, a DESTDIR install target that works.
Project Configuration
No response
Additional Information and Error Logs
No response

The configure script does not accept ./configure --prefix=.... This is standard usage for distro packagers that don't use the usual /usr/local defaults and want to set /usr or similar instead.

It is supported and you can test it.
./configure --prefix=/xxx
make
make install

About 1 and 3, I will improve it in the next two days

The make install DESTDIR="..." does not function to accept a base director. This is also standard usage. This and no 2 only work if bundled together as make install PREFIX="/base/prefix", but this is broken non-standard usage.

I have supported it now.

The sources don't extract with a top level directory. This makes a huge mess because the tar has no root directory. Sources build with make dist will always have the version number in the name and extract to a matching top level directory.

I have modified it, you can try this tar bar.
xmake.tar.gz

Looking forward to the fixes in the next release, I'll update packaging when a stable version is tagged.

BTW the tar file you attached above has a top level directory, but it is not versioned. It is quite typical to distribute software with versioned files that extract to versioned directories because this avoids all sorts of possible headaches and confusion. The filename should be something like xmake-X.Y.Z.tar.gz and extract to a directory called xmake-X.Y.Z (Using a v prefix is optional, conventions vary widely on whether to include it in the filename and/or directory. In fact it's pretty common to find it used in the tar file name but not the extraction directory, which I think is weird but whatever. The important thing on this topic is to stay consistent between releases.).

I have modified it.
xmake-v2.7.4.tar.gz

There is an extra /./ in the tar file paths now. This will work for some situations and make a mess of others. Typically the paths would just be xmake-X.Y.Z/<files> not ./xmake-X.Y.Z/<files>. You can pretty easily compare this with auto generated archives from e.g. GitHub. For example look at the this:
$ wget https://github.com/xmake-io/xmake/archive/refs/tags/v2.7.4/xmake-2.7.4.tar.gz
$ tar xvfl xmake-2.7.4.tar.gz

...vs. the output of tar xvfs for the bundle you attached here. Again some tooling will deal with this, but others will not. In particular the depth extraction arguments to many tar related tools will be off by one and give unexpected results.

I have improved it.
xmake-v2.7.4.tar.gz

I released new version. https://github.com/xmake-io/xmake/releases/download/v2.7.5/xmake-v2.7.5.tar.gz

Oh, no.  You've removed old (working!) build system without a warning and giving a chance to try out xmake.sh.  Please don't make surprises like that, warn in a changelog beforehand and remove previous build only if there are no issues with the new one for a whole release or 3-4 month (whichever comes last).
xmake.sh seems to check presence of functions by compilation only which makes it think lua5.4/luajit is there, based on the headers from another version.  And specifying --runtime=lua doesn't change anything, I'd expect it to have higher priority than whatever is found automatically.

Oh, no. You've removed old (working!) build system without a warning and giving a chance to try out xmake.sh. Please don't make surprises like that, warn in a changelog beforehand and remove previous build only if there are no issues with the new one for a whole release or 3-4 month (whichever comes last).
xmake.sh seems to check presence of functions by compilation only which makes it think lua5.4/luajit is there, based on the headers from another version. And specifying --runtime=lua doesn't change anything, I'd expect it to have higher priority than whatever is found automatically.

If you encounter a problem, you can open a separate issue and provide verbose logs and I will fix it.

It's basically one more bullet to this issue, build from source using ./configure fails the same on v2.7.4 and v2.7.5 if you have installation of Lua from a different version.

It's basically one more bullet to this issue, build from source using ./configure fails the same on v2.7.4 and v2.7.5 if you have installation of Lua from a different version.

please open a new issue and provide error.