aarch32 excn vector not pinned in mmu causing newlib heap overlap

Describe the bug
Concerning Zephyr v3.2.0, present since release v3.0.0, introduced by commit
70c403c215 - arch: arm: core: aarch32: introduce basic ARMv7 MMU support
The linker script for aarch32 cortex A and R places z_mapped_start after the exception vector section, just before the code text section.
This causes the Newlib malloc_prepare to allocate a heap at the same physical address as the exception vector, because it's page frame is marked by mmu as available rather than pinned.
The effect is that when allocated heap memory is written to, this overwrites the exception vector, causing undefined operations.
This does not affect aarch32 cortex M as it does not have MMU.
This does not affect minimal libc.
This does not affect aarch64 as that linker script places z_mapped_start before the exception vector.
This does not affect XIP targets.
I believe this only affects CPU_CORTEX_A9 with Newlib and no XIP.
To Reproduce
This is what we did to encounter the problem:

create a soc using CPU_CORTEX_A9 (we used another new ARMv7-A CPU_AARCH32_CORTEX_A which is ISA_THUMB2 but that should be irrelevant)
create a board using that soc, and include in the _defconfig file CONFIG_HEAP_MEM_POOL_SIZE=4096 and CONFIG_NEWLIB_LIBC=y
build using the hello_world sample or any sample for that matter
execute and observe

Expected behavior
I think the linker script for aarch32 cortex A should define z_mapped_start before the exception vector
Impact
We have currently implemented a workaround by modifying as per above.
Logs and console output
None.
Environment (please complete the following information):
Debian, Zephyr SDK 0.15 toolchains, tag v3.1.0 2ddd73feaf
Proposed patch
diff --git a/include/zephyr/arch/arm/aarch32/cortex_a_r/scripts/linker.ld b/include/zephyr/arch/arm/aarch32/cortex_a_r/scripts/linker.ld
index 6be9667943..21863a8bd2 100644
--- a/include/zephyr/arch/arm/aarch32/cortex_a_r/scripts/linker.ld
+++ b/include/zephyr/arch/arm/aarch32/cortex_a_r/scripts/linker.ld
@@ -120,6 +120,11 @@ SECTIONS
  * zephyr_linker_sources(ROM_START ...). This typically contains the vector
  * table and debug information.
  */
+#ifndef CONFIG_XIP
+        z_mapped_start = .;
+#endif
 #include <snippets-rom-start.ld>

     } GROUP_LINK_IN(ROMABLE_REGION)
@@ -133,10 +138,6 @@ SECTIONS
     SECTION_PROLOGUE(_TEXT_SECTION_NAME,,)
     {
         . = ALIGN(_region_min_align);
         __text_region_start = .;
-#ifndef CONFIG_XIP
-        z_mapped_start = .;
-#endif

 #include <zephyr/linker/kobject-text.ld>

If you agree with my assessment of this bug, I can open a merge request.

Interesting as I have actually been building projects for aarch32 Cortex-A with Newlib as the active C library and without XIP. However, my heap mem pool size is significantly larger than 4k. I should get the chance tomorrow to verify the described issue on the Zynq-7000 with the trusty ole' Lauterbach debugger.

Well actually the code is
max_heap_size = MIN(CONFIG_NEWLIB_LIBC_MAX_MAPPED_REGION_SIZE,
                    k_mem_free_get());

So I take it CONFIG_HEAP_MEM_POOL_SIZE doesn't have any effect.

I have implemented #51035 and have CONFIG_SRAM_BASE_ADDRESS=0x8000000 (because of FastModel limitations on our side which are beyond my understanding at the moment), though it was my understanding this shouldn't matter.

Interesting as I have actually been building projects for aarch32 Cortex-A with Newlib as the active C library and without XIP. However, my heap mem pool size is significantly larger than 4k. I should get the chance tomorrow to verify the described issue on the Zynq-7000 with the trusty ole' Lauterbach debugger.

Have you been able to look into this yet? I would be interested to know that it works for you.

When k_mem_map is called, it in turn calls map_anon_page in a loop until the desired amount of memory is mapped.
At the time being, the first call to map_anon_page will actually map the first 4k page whose PA is at the start of the Zephyr image in RAM, where the vectors are located. As those have been copied to address 0 by the time map_anon_page is first called, this re-use hasn't caused any damage so far - but if VBAR is used and the vectors are permanently used at that location, the system will crash. Any subsequent call of map_anon_page will assign memory above the end of the Zephyr image.
Even if this behaviour doesn't cause any damage in the scenario where the vectors are copied to address 0, we're definitely not getting contiguous memory when the first call to k_mem_map requests more than 4k.


multiple versions of pyarrow installed?

Hey there,
Apologies for the beginner-level question, but it appears that pypy has somehow installed multiple versions of pyarrow on our system. We have a long list of libraries that are installed from requirements.txt, and we didn't realize that this process could install multiple versions of the same library? If that's not the case, how is it possible that we are able to uninstall two different versions?
root@b5d80f9670ea:~/src# pip uninstall -y pyarrow
Found existing installation: pyarrow 2.0.0
Uninstalling pyarrow-2.0.0:
  Successfully uninstalled pyarrow-2.0.0
root@b5d80f9670ea:~/src# pip uninstall -y pyarrow
Found existing installation: pyarrow 0.15.1
Uninstalling pyarrow-0.15.1:
  Successfully uninstalled pyarrow-0.15.1

Unfortunately one of the other packages, transformers, is complaining that version 0.15.1 is too old, and throwing an error. It's ignoring the fact that the newer version is installed.
Thanks!
Happy New Year!

This could just be a usage problem with the different ways to install packages with pip (in your virtualenv, via --user and systemwide). Nothing special with Arrow here.
Note that pyarrow won't be working on PyPy, not sure how you even installed it there as it doesn't compile currently.

This could just be a usage problem with the different ways to install packages with pip (in your virtualenv, via --user and systemwide). Nothing special with Arrow here.
Note that pyarrow won't be working on PyPy, not sure how you even installed it there as it doesn't compile currently.

Not a pyarrow issue, closing.

Not a pyarrow issue, closing.


Fix sg-core image tag

"current-podified" tag doesn't exist for the sg-core image. We use "v5.2.0-nextgen" instead

/retest
unable to upgrade connection: container container-00 not found in pod oko-18-vwt7g-master-2-debug-5vwnn_openstack-kuttl-tests


Migration to Stack 2

Based on #1 by @qrilka, but I cannot push commits on that branch.
Seems to work!

My bad, I wanted to make the PR to my own repo: https://github.com/nh2/stack2nix/pull/2
@domenkozar Do you think you could transfer stack2nix to me?

@nh2 I don't have permissions for that. @disassembler


Add postrgesql.User

We tried to add a Role() to our AWS Redshift cluster and this resulted in a SQL error message:
error: error creating role my_user: pq: syntax error at or near "ROLE"

@t0yv0 pointed out in the Pulumi Slack, that Redshift in particular does not support the more modern CREATE ROLE and instead still uses the older CREATE USER construct, but the pulumi PostgreSQL provider does not support this.
Affected feature

Adding the User() would help to use the Pulumi PostgreSQL provider with older or forked versions of PostreSQL.

This looks like it's tracked upstream in https://github.com/hashicorp/terraform-provider-postgresql/issues/147.  When that is addressed, we'll pick up the fix here.  It might be necessary to port that issue over to the new github.com/cyrilgdn/terraform-provider-postgresql repo to track there as well since that is where active development is happening now.

Any alternative on how to provision users to a PostgreSQL DB using Pulumi?


Colab integration

Some links:

https://github.com/Dsantra92/Julia-on-Colab

https://gist.github.com/yiyuezhuo/91ac12cf8caa28b2776f19a9fa58d031

https://www.youtube.com/watch?v=xpZo3L2dYTY

In principle, should only need to do something

!curl -sSL "https://julialang-s3.julialang.org/bin/linux/x64/1.4/julia-1.4.1-linux-x86_64.tar.gz" -o julia.tar.gz
!tar -xzf julia.tar.gz -C /usr --strip-components 1
!rm -rf julia.tar.gz*
!julia -e 'using Pkg; pkg" up; add IJulia ;  precompile"'

# refresh window to activate julia kernel

or
# Installation cell
%%shell
if ! command -v julia 3>&1 > /dev/null
then
    wget 'https://julialang-s3.julialang.org/bin/linux/x64/1.4/julia-1.4.1-linux-x86_64.tar.gz' \
        -O /tmp/julia.tar.gz
    tar -x -f /tmp/julia.tar.gz -C /usr/local --strip-components 1
    rm /tmp/julia.tar.gz
fi
julia -e 'using Pkg; pkg"add IJulia InstantiateFromURL; precompile;"'
echo 'Done'

And then "refresh" the window.  But getting the notebook to match the kernelspec might be needed.
Note that the URL also works, so maybe we could get people to copy/paste some text like that in... or even have a "colab-notebooks" repo.
https://colab.research.google.com/github/QuantEcon/quantecon-notebooks-julia/blob/master/getting_started_julia/julia_essentials.ipynb

Strategy would be a post-processing script to add an installation instructions/cell and potentially change the jupyter kernel stuff.
Might also make sense to remove the InstantiateFromURL and tell people to manually install...

Seems to work, but getting the notebook's kernelspec to match before you upload is essential. Also switched to 1.4.1, which came out recently.
I'm able to install CuArrays and reproduce his results.

I used the %%shell-style script.
The GPU they give us is:
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 440.82       Driver Version: 418.67       CUDA Version: 10.1     |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|===============================+======================+======================|
|   0  Tesla P4            Off  | 00000000:00:04.0 Off |                    0 |
| N/A   62C    P0    26W /  75W |    161MiB /  7611MiB |      0%      Default |
+-------------------------------+----------------------+----------------------+

+-----------------------------------------------------------------------------+
| Processes:                                                       GPU Memory |
|  GPU       PID   Type   Process name                             Usage      |
|=============================================================================|
+-----------------------------------------------------------------------------+

OK, @arnavs  sounds like we basically have 2 choices here.  In both cases, we wuold generate a set of notebooks with a patch on the existing ones to add in the colab installation... and we can make sure to setup the jupyter kernelspec to precisely match.
Also, in both cases we take the generated notebooks and find the generated output matching the
using InstantiateFromURL
github_project("QuantEcon/quantecon-notebooks-julia", version = "0.5.0")
# uncomment to force package installation
# github_project("QuantEcon/quantecon-notebooks-julia", version="0.5.0", instantiate=true)

cell a replace it with two cells.  In the first cell is always something with julia installation and colab instructions.  That is, something like
%%shell
if ! command -v julia 3>&1 > /dev/null
then
    wget 'https://julialang-s3.julialang.org/bin/linux/x64/1.4/julia-1.4.1-linux-x86_64.tar.gz' \
        -O /tmp/julia.tar.gz
    tar -x -f /tmp/julia.tar.gz -C /usr/local --strip-components 1
    rm /tmp/julia.tar.gz
fi
julia -e 'using Pkg; pkg"add IJulia InstantiateFromURL; precompile;"'
echo 'Done'

Choice 1:   We add in an instantiatefromurl option to download and instantiate withtout precompiling.  So the cell becomes something like
using InstantiateFromURL
github_project("QuantEcon/quantecon-notebooks-julia", version = "0.5.0", instantiate = true, precompile = false)

The advantage of this is that we know the combination of package versions will work, and the user doesn't need to see any errors as they add packages.  The disadvantage is that it may take an extra 2-3 minutes to load, and if people want to update notebooks they would have to manually delete the project/manifest.  The first is an issue, the second I am less worried about.
Choice 2: We turn that into something like the following
] add Plots Distributions Expectations   # add more packages as required

Where we can tell the user to add in packages when they get errors.
The benefit of this is that it will be faster to load the first time, and will get the latest copies of packages.  The downside is that the latest copies of packages might be incompatible or buggy, and it requires a lot of stop and start as users find missing packages.  That round-trip time could be > 2-3 minutes...

@arnavs  I created https://github.com/QuantEcon/quantecon-notebooks-julia-colab for the notebook repo we would push to... regardless of the approach.

Closing this as we have more specific issues and we decided on the precompile = false setup with InstantiateFromURL as the approach.


Need help, how to choose one column of a tensor

predict_op = tf.argmax(py_x, 1) # at predict time, evaluate the argmax of the logistic regression
here what to do if I want to choose one column of py_x, like py_x[1] ?
Also it would be of great help if we have example of showing how to do text classification using tensorflow( sparse feature).
Example of showing how to evaluate using auc instead of  precision is greatly appreciated.

I think tf.slice(...) might be what you want for getting 1 column.  Let us know if that doesn't work!
You might also want to follow https://github.com/tensorflow/tensorflow/issues/206
As for text classification: I'm sure that will be added over time (either by us or externally).


Fe: proof of authenticity

There's already an IPFS hyperlink, next to it can be the transaction. First need to setup blockscout https://github.com/webaverse/app/issues/1130


[#2288] Fix for conditional check of published resources.

Found and fixed a bug causing error when trying to delete published resources from My Resources page.

@hyi, could you review this small PR. Deployed and confirmed working at playground.hydroshare.org

@Maurier, @dtarb - is this a hot-fix? or just a standard fix that goes into the next deployment?
If it's a hot-fix the base branch would need to be changed.

@mjstealey, this is simple enough that could go as a hotfix. @dtarb, let me know how to proceed.

This is a standard fix.  The criterion for hotfix is not simplicity.  It is urgency.  While simple, this is not an urgent fix of something that is badly broken.  It should be merged into develop and then be part of all the testing normally associated with a deploy, and go out with the next deploy when it is deployed.

Ok, merging with develop.


Unable to extract title, failing to download youtube playlists

ironman@J:~/Videos/Shed$ youtube-dl -citw --verbose https://www.youtube.com/playlist?list=PLUtQYRyYUbS7-K1p0i6VjkHMFQM5Y47mL
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['-citw', '--verbose', 'https://www.youtube.com/playlist?list=PLUtQYRyYUbS7-K1p0i6VjkHMFQM5Y47mL']
[debug] Encodings: locale 'UTF-8', fs 'UTF-8', out 'UTF-8', pref: 'UTF-8'
[debug] youtube-dl version 2014.02.17
[debug] Python version 2.7.6 - Linux-3.13.0-66-generic-x86_64-with-Ubuntu-14.04-trusty
[debug] Proxy map: {}
[youtube:playlist] PLUtQYRyYUbS7-K1p0i6VjkHMFQM5Y47mL: Downloading page #1
WARNING: [youtube:playlist] PLUtQYRyYUbS7-K1p0i6VjkHMFQM5Y47mL: Playlist page is missing OpenGraph title, falling back ...
ERROR: Unable to extract title; please report this issue on https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type  youtube-dl -U  to update.
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 1511, in _real_extract
playlist_title = self._og_search_title(page)
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 428, in _og_search_title
return self._og_search_property('title', html, **kargs)
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 416, in _og_search_property
escaped = self._search_regex(self._og_regexes(prop), html, name, flags=re.DOTALL, **kargs)
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 356, in _search_regex
raise RegexNotFoundError(u'Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract OpenGraph title; please report this issue on https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type  youtube-dl -U  to update.
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 493, in extract_info
ie_result = ie.extract(url)
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 158, in extract
return self._real_extract(url)
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 1517, in _real_extract
r'(.*?)', page, u'title')
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 366, in _html_search_regex
res = self._search_regex(pattern, string, name, default, fatal, flags)
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 356, in _search_regex
raise RegexNotFoundError(u'Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract title; please report this issue on https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type  youtube-dl -U  to update.

You are using an outdated version of youtube-dl. Read our FAQ if you have troubles updating.


CSS and fonts disappeared from bower main in latest update

only js/bootstrap.js is listed
which has broken my build, I have to override main manually back to:
"css/bootstrap.css",
"js/bootstrap.js",
"fonts/glyphicons-halflings-regular.eot",
"fonts/glyphicons-halflings-regular.svg",
"fonts/glyphicons-halflings-regular.ttf",
"fonts/glyphicons-halflings-regular.woff",
"fonts/glyphicons-halflings-regular.woff2"

yes, stumbled upon the same issue, last version where it is ok, 3.3.4

This is a conflicting open Issue. Font files should not be included in bower.json. However, css/bootstrap.css does need to be added back. Doing a build with wiredep is broken in the current configuration.

Yes, I can see that there is a whole theory why the font files shouldn't be included in the main bower files.
However, as for my build, this would work only in development mode, as all bower_components are used directly. In production build I do uglification and minification of all JS and CSS files, including bower_components, so I need to copy all compiled files and generally all assets to the dist location. For that reason I need to collect also fonts and images delivered as bower components with main-bower-files tool.
There are use cases where let's call them all production files need to be listed as main bower files, especially for complex builds.

Hey @moravcik - according to this pull request only entry points should be listed in Main. Since the Font files are referenced within our css file, the fonts should be "scooped up" by the build script.
I'm am new to this, but I have been using yeoman-angular with grunt to build a github pages site. I changed the bower_componenets/bootswatch-dist/bower.json "main"  to be
"main": [
    "css/bootstrap.css",
    "js/bootstrap.js"
  ],

and my build dist grabbed the fonts just fine.
I hope this helps somewhat. It's cool that you are from Bratislava -  my wife and I went backpacking through there a couple of years ago and ate lots of Bryndzové halušky. There was lots of snow - what a beautiful city! And great music everywhere.

@Kamps-Duac, I was playing a little bit with your Kamps-Duac.github.io project.
First of all, generally modifying any files in bower_components is not the best practice. Every time you checkout your project, or you do bower update you loose your changes.
You can do the same thing in your root bower.json, just add:
  "overrides": {
    "bootswatch-dist": {
      "main": [
        "css/bootstrap.css",
        "js/bootstrap.js"
      ]
    }
  }

In my case I add also the font files, as I was describing before.
Well, how your font files get resolved into dist dir? Check following portion of your Gruntfile.js:
// Copies remaining files to places other tasks can use
copy: {
  dist: {
    files: [{
      expand: true,
      dot: true,
      cwd: '<%= yeoman.app %>',
      dest: '<%= yeoman.dist %>',
      src: [
        '*.{ico,png,txt}',
        '*.html',
        'images/{,*/}*.{webp}',
        'styles/fonts/{,*/}*.*'
      ]
    }, {
      expand: true,
      cwd: '.tmp/images',
      dest: '<%= yeoman.dist %>/images',
      src: ['generated/*']
    }, {
      expand: true,
      cwd: 'bower_components/bootswatch-dist',
      src: 'fonts/*',
      dest: '<%= yeoman.dist %>'
    }]
  },
  styles: {
    expand: true,
    cwd: '<%= yeoman.app %>/styles',
    dest: '.tmp/styles/',
    src: '{,*/}*.css'
  }
},

especially this portion:
  cwd: 'bower_components/bootswatch-dist',
  src: 'fonts/*',

so, the build script does the manual copying of bootswatch-dist font files into the dist directory.
I was doing the same thing, but for all assets generally listed in bower main files in all bower components.
Glad to hear you liked Bratislava trip and bryndzove halusky (not everyone likes them). I would recommend visiting also our mountains, especially High Tatras, which are the smallest alpine type mountains in Europe. I have never visited Florida yet, but I liked San Francisco and Yosemite park which I visited 2 years ago, very nice.

Thanks for the override tip @moravcik!

To comply with the bower spec, as bootstrap does, fonts & css files are removed from main. For wiredep, override method can be used.

In my opinion the 43 is a big step backward, since it breaks tons of builds and requiring a lot of manual "overrides" sections. This leads many developers to think about bower alternatives, e.g. Migrate away from Bower
Fortunately there is a new spec for "files" section in Bower 47, but anyway I think the "files" spec should be implemented before the meaning of main is deliberately changed.
I understand that this repo is a distribution of bootstrap, so it needs to follow bootstrap bower config. However, I think such big changes should be introduced in new major versions, not minors, which are resolved automatically and causes failing builds.

I understand that this repo is a distribution of bootstrap, so it needs to follow bootstrap bower config.

This is why I am confused. The Bootstrap 3 and 4 bower config does have a stylesheet included in bower.json "main". Also, the bower spec includes an example of "main" having a stylesheet. What am I missing?

@moravcik I could not agree more, this breaks many builds. However, css files are not entry points. And wiring deps in html and bundling them is whole different thing to discuss.
Bower is not the perfect package manager anyway, migrate to npm if you can.
@Kamps-Duac there is no css files in bootstrap 3 or 4 bower configs; they're less or sass files.


[manila-csi-plugin] Probe() must be forwarded to partner node plugin

The binaries affected:

[ ] openstack-cloud-controller-manager
[ ] cinder-csi-plugin
[ ] k8s-keystone-auth
[ ] client-keystone-auth
[ ] octavia-ingress-controller
[x] manila-csi-plugin
[ ] manila-provisioner
[ ] magnum-auto-healer
[ ] barbican-kms-plugin

What this PR does / why we need it:
csi-manila is built using proxy architecture - it relies on a partner node plugin to do the node operations (e.g. mounts) on behalf of csi-manila.
Querying csi-manila for its readiness (Probe RPC of the CSI Identity Service) means querying the partner node plugin as well.
This PR:

adds Probe function to the csiclient.Interface interface
forwards Probe to the partner node plugin

Release note:

NONE

Addressed review comment, PTAL @ramineni @gouthampacha

/lgtm

/lgtm

/approve

Sorry for the delay on this.  Code looks fine and I now got a chance to run it in my local deployment where it also seems fine.
/lgtm
/approve

/assign ramineni
please help us merge :)

/approve


Issue with zksync-ethers.js version 6: Blockage on Usage, Works with Version 5

🐛 Bug Report for zksync-ethers JavaScript SDK
📝 Description
I wanted to bring to your attention an issue I encountered while using zksync-ethers.js version 6. It appears that there is a compatibility issue or a bug with this version, as I experienced errors when trying to run my code. Specifically, I was unable to retrieve block information using zksync-ethers.js version 6, whereas the same code worked perfectly fine with version 5.
To resolve this issue, I downgraded to zksync-ethers.js version 5, and the problem was resolved. I was able to successfully retrieve the required block information without any errors.
There is an issue with the zksync-ethers JavaScript SDK version 6 where certain functionalities do not work as expected.
🔄 Reproduction Steps
Install zksync-ethers version 6.
Attempt to perform certain operations, such as retrieving latest block number
const { Provider, utils, types } = require("zksync-ethers");
const { ethers } = require("ethers");

async function main() {
    const provider = Provider.getDefaultProvider(types.Network.Sepolia);
    const ethProvider = ethers.getDefaultProvider("sepolia");

    // Get the network
    const network = await provider.getNetwork();
    console.log(`Network: ${JSON.stringify(network)}`);

    // Get the latest block number
    const blockNumber = await provider.getBlockNumber();
    console.log(`Block number: ${blockNumber}`);

}

main().catch(console.error);

Observe the error or unexpected behavior.
🤔 Expected Behavior
I expected the SDK to function without errors and provide accurate information regarding blocks.
😯 Current Behavior
The SDK throws errors and does not retrieve block information correctly.
🖥 Environment
Node version: 18.16.1
Operating System & Version: macOS
Other relevant environment details:
📋 Additional Context
This issue was not present in zksync-ethers version 5, suggesting a regression in functionality with the latest version.
Add any other context about the problem here. If applicable, add screenshots to help explain.
📎 Log Output
node essai.js
/Users/michel/botcrevic/node_modules/zksync-ethers/build/types.js:58
class TransactionResponse extends ethers_1.ethers.TransactionResponse {
                                                  ^

TypeError: Class extends value undefined is not a constructor or null
    at Object.<anonymous> (/Users/michel/botcrevic/node_modules/zksync-ethers/build/types.js:58:51)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Module._load (node:internal/modules/cjs/loader:960:12)
    at Module.require (node:internal/modules/cjs/loader:1143:19)
    at require (node:internal/modules/cjs/helpers:110:18)
    at Object.<anonymous> (/Users/michel/botcrevic/node_modules/zksync-ethers/build/utils.js:22:17)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)

Node.js v18.16.1

Do you use one of the latest versions of SDK? I managed to fetch block and number with version v6.6.0 and v6.5.0:
import { Provider, types, utils } from "zksync-ethers";

const provider = Provider.getDefaultProvider(types.Network.Sepolia);

async function main() {
    console.log(`Block number: ${await provider.getBlockNumber()}`);
    const block = await provider.getBlock("latest", true);
    console.log(`Block: ${utils.toJSON(block)}`);;
}

main()
    .then()
    .catch((error) => {
        console.log(`Error: ${error}`);
    });

output:
Block number: 1379704
Block: {"_type":"Block","baseFeePerGas":"100000000","difficulty":"0","extraData":"0x","gasLimit":"4294967295","gasUsed":"335821","hash":"0x61bff05d816eb38839a9636a0bb6eddbea3e4101dbed6d7cda4ffb46de6b64c5","miner":"0x0000000000000000000000000000000000000000","nonce":"0x0000000000000000","number":1379704,"parentHash":"0x51f5f524fd28499b7a395f64184b060ced8fb208abfd2321da4bd55c375f58fd","timestamp":1711649800,"transactions":["0xf7ad0f6597c14bdd0767c34ed1e6c016ba7780fed1fbb12b8ace424e013e9e7c"]}


bug raro

when I activate the dead eye the audio is distorted
https://www.youtube.com/watch?v=0bwZtFFMU1c
these are the addons I was using
https://steamcommunity.com/sharedfiles/filedetails/?id=2935496546

seems that tfa is slowing down the sounds, try setting sv_tfa_soundscale to 0


WIP: Make 95-test_external_pyca_data/cryptography.py less silent

The pyca test doesn't seem to work right on Travis.  This PR will hopefully help determine what's going on.

Which of the builder's output should I look at?

Hold on, I just condensed .travis.yml to only contain builds that would only exercise test_external_pyca

So from now on, it's any build you can see...

I think you may have excluded too much, in the output I see "ok 1 # skip PYCA Cryptography not available"

Yeah, I noticed.  I'm not sure what caused this, but I keep experimenting.  I see further up in the log that the pyca-cryptography submodule is checked out, so pyca-cryptography/setup.py should be there...

Finally got it right...

Ok, we now have a clear error message: https://travis-ci.org/openssl/openssl/builds/213413215#L808-L818
If you don't want to install all our weird dependencies for a full dev environment you can reply pip install -r dev-requirements.txt with pip install .[test], that should get everything you need just to run the tests.

Right now, I'm trying the other way around, to install libenchant-dev to see if that solves the issue.  But if only pip-installing the test requirements is enough, I'm game as well!

I think I'll opt for simplicity, so pip install .[test] it is.
Time to make a nice patch of this and take this PR out of WIP.

👍

Done.  Review time.

.travis.yml is restore.  In the current build, the xxxx.9 job is the one to look at.

Sorry, wrong, I meant the xxxx.7 job.

It seems I'm getting another type of error now:
Traceback (most recent call last):
  File "/home/travis/build/openssl/openssl/venv-pycrypto/local/lib/python2.7/site-packages/_pytest/config.py", line 362, in _importconftest
    mod = conftestpath.pyimport()
  File "/home/travis/build/openssl/openssl/venv-pycrypto/local/lib/python2.7/site-packages/py/_path/local.py", line 662, in pyimport
    __import__(modname)
  File "/home/travis/build/openssl/openssl/venv-pycrypto/local/lib/python2.7/site-packages/_pytest/assertion/rewrite.py", line 216, in load_module
    py.builtin.exec_(co, mod.__dict__)
  File "/home/travis/build/openssl/openssl/venv-pycrypto/local/lib/python2.7/site-packages/py/_builtin.py", line 221, in exec_
    exec2(obj, globals, locals)
  File "<string>", line 7, in exec2
  File "/home/travis/build/openssl/openssl/pyca-cryptography/tests/conftest.py", line 10, in <module>
    from cryptography.hazmat.backends.openssl import backend as openssl_backend
  File "/home/travis/build/openssl/openssl/pyca-cryptography/src/cryptography/hazmat/backends/openssl/__init__.py", line 7, in <module>
    from cryptography.hazmat.backends.openssl.backend import backend
  File "/home/travis/build/openssl/openssl/pyca-cryptography/src/cryptography/hazmat/backends/openssl/backend.py", line 49, in <module>
    from cryptography.hazmat.bindings._openssl import lib as _lib
ImportError: /home/travis/build/openssl/openssl/pyca-cryptography/src/cryptography/hazmat/bindings/_openssl.so: undefined symbol: __gcov_merge_add
ERROR: could not load /home/travis/build/openssl/openssl/pyca-cryptography/tests/conftest.py

That particular job is configured no-shared...  @alex, that would never work with the pyca tests, would it?  It seems we need to make a separate job for external tests...

It's definitely possibly to statically link a .a with pyca/cryptography, though I can't remember how off hand. /cc @reaperhulk

I find this reason enough to have a separate job for external tests...

Ok, it builds!

Merged.  8c1054ae084935d67eb24f9efa82fb462d3a222a to 34fffdb521040d3bc658c1ceaa9c79fbd191ded3


Housekeeping [To be merged as final PR to 1.17.1]

Description
Just a bunch of housekeeping. I think this should be one of the final PR's targeting 1.17.1, as my next PR will likely be bringing us into 1.18 once forge is primed. The idea is to have our repo spick and span ready for 1.18 porting to commence.
Todo

[x] Move anything lang related into EIOLang
[x] Gear rotation config per-item (somehow)
[ ] Fused quartz glass item icons (maybe)
[x] Any outstanding configs, including any from #39
[x] Rename the wither enchantments
[x] Split wither arrow into an enchantment for bow and one for crossbow
[ ] Add fluid support to the levitation staff? (Might skip until we add our own fluids)
[x] Add health information to mobs in the soul vial, dep #43
[x] Make all tooltips that aren't using TooltipUtil from #29 to use it
[ ] Energy tooltips as part of IEnergyBar (renaming it to IEnergyDisplay), dep #43
[ ] Convert SinglePaintedBlockEntity#readPaint to a capability - @agnor99
[x] Shift to reveal more tooltip.
[x] Any other minor todos or code tweaks.
[x] Fix merge after #43
[ ] Move the additional coloured glass into decor, leaving just the base pair of glass.
[x] I want to do a minor rework of the soul vial as it is messy.

Crossed items are deferred to not slow down EnderIO porting progress.
Checklist:

[x] #29
[x] #39
[x] #43
[x] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you)
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation

Merging so I can begin work on 1.18


Make a cool new main page

Make a more visually appealing main page, also including there the new elements of RiverBench:

#104
#73
#88

Maybe use a layout like the one I did in Jelly: https://jelly-rdf.github.io/dev/

Also update the README a bit...


Add version test

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

I'm curious if this (slightly hacky) test will work :eyes:

@dhirschfeld I just uncommented pip check and the build failed. Curious to see if your solution works. Thank you for your help.

A successful failure! :tada:
import: 'autogluon.tabular'
import: 'autogluon.tabular'
+ python -c 'from autogluon.tabular import __version__ as v; assert v == '\''0.6.2'\'', f'\''{v} != 0.6.2'\'''
Traceback (most recent call last):
  File "<string>", line 1, in <module>
AssertionError: 0.6.2b20230120 != 0.6.2
Tests failed for autogluon.tabular-0.6.2-pyhd8ed1ab_2.conda - moving package to /home/conda/feedstock_root/build_artifacts/broken

@dhirschfeld Perfect! Thank you.

@dhirschfeld Perfect! Thank you.

Happy to help! :)

Thanks for this @dhirschfeld !!


LiquidFire animations breaking css of some elements

Easier to show:
http://tedconf.github.io/ember-collapsible-panel/
Go to the "Nested panels" section, toggle the parent element once or twice and the child elements will display strangely.
Without animations, this issue doesn't happen.

@CourtneyJooste I believe this is because Liquid Fire's default crossFade transition isn't cancelable.
I would love it if someone could write a cancelable transition that we could include in this library!

I'm going to close this issue merely due to age. If it's still an issue, please re-open. Thank you! 👍


After upgrade 0.9 -> 0.10 derivative functions returns empty result

SELECT non_negative_derivative(mean(value))*0.01666 FROM "freeradius_value" WHERE "type_instance" = 'Access_Requests' AND $timeFilter GROUP BY time(1m), "host"

I have this query in Grafana and it worked with InfluxDB 0.9
But after upgrade to 0.10 it returns empty set.
How should I change the query to make it work?

Closing since this is very likely a dup of #5474.  @emanuelis see the workaround in that issue. You may need to manually edit your meta/node.json.


con`t add image

add image fail, can you fix it?

Please check my Stackoverflow regarding this here: https://stackoverflow.com/questions/72243589/qrcodevue3-load-image-into-center-of-qr-code/72243856#72243856

Image support should be working for long time.. Demo here: https://github.com/scholtz/qrcode-vue3-sample/blob/master/src/App.vue#L12


Custom Keras RNN with constants changes constants shape when saving

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
No
Source
source
TensorFlow version
2.15
Custom code
Yes
OS platform and distribution
Windows WSL
Mobile device
No response
Python version
3.11
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
Constants shape changes from rank 2 during inference to rank 3 tensor during model saving
Standalone code to reproduce the issue
from tensorflow.python.keras.layers.recurrent import (
    DropoutRNNCellMixin,
    _config_for_enable_caching_device,
    _caching_device,
)

class RNNWithConstants(
    DropoutRNNCellMixin, tf.keras.__internal__.layers.BaseRandomLayer
):
    def __init__(
        self,
        units,
        activation,
        recurrent_activation,
        dropout,
        recurrent_dropout,
        **kwargs,
    ):
        super(RNNWithConstants, self).__init__(**kwargs)
        self.units = units
        self.dropout = dropout
        self.recurrent_dropout = recurrent_dropout
        self.recurrent_activation = recurrent_activation
        self.cell = tf.keras.layers.GRUCell(
            units=units,
            activation=activation,
            recurrent_activation=recurrent_activation,
            recurrent_dropout=recurrent_dropout,
            dropout=dropout,
        )
        self.state_size = units
        self.output_size = units

    @tf.function
    def call(self, inputs, states, constants):
        print(f"inputs {inputs.shape}")
        print(f"states {states[0].shape}")
        print(f"constants {constants[0].shape}")
        inputs = tf.concat([inputs, constants[0]], axis=-1)  # error due to shape change
        h, _ = self.cell(inputs, states)
        return h, h

class ConstantsModel(tf.keras.models.Model):
    def __init__(self, units, **kwargs):
        super().__init__(**kwargs)
        self.units = units
        self.cell = RNNWithConstants(units, "sigmoid", "sigmoid", 0.1, 0.1)
        self.rnn = tf.keras.layers.RNN(self.cell)

    @tf.function
    def call(self, inputs, constants, training):
        return self.rnn(inputs, constants=constants)

const = ConstantsModel(10)
print("initializing...")
_ = const(tf.random.normal(shape=(100, 50, 10)), tf.random.normal(shape=(100, 10)))
print("\nsaving....")
const.save("./const_model")

Relevant log output
initializing...
inputs (100, 10)
states (100, 10)
constants (100, 10)
inputs (100, 10)
states (100, 10)
constants (100, 10)

saving....
inputs (None, 10)
states (None, 10)
constants (None, 10)
inputs (None, 10)
states (None, 10)
constants (None, None, 10)

I've opened the  in the keras repo issue


Take and return new RMW_DURATION_INFINITE correctly

Depends on https://github.com/ros2/rmw/pull/301
Meets the new API expectations introduced in https://github.com/ros2/rmw/pull/301 - to accept and return RMW_DURATION_INFINITE for cross-implementation consistency.

@asorbini this is probably not worth merging here, right, and should instead go to rmw_connextdds?

@emersonknapp I can confirm I'd like support for this special value to be added to rmw_connextdds, but I can't really comment on whether it shouldn't be merged to rmw_connext_cpp too. I'm not sure what the plans are for EOL'ing the package, beside phasing it out of the source tree. I'm assuming development will eventually stop, but a maintainer should comment on that.
Feel free to open a PR for rmw_connextdds though, I'd be happy to review/merge.
Keep in mind that @ivanpauno is also working on some changes related to QoS configuration (see rticommunity/rmw_connextdds#7), so you might want to coordinate these additions with him.

My personal view on this is that the work here is done, so we should just go ahead and merge this.  I wouldn't spend much additional time here, given that it is on its way out, but "on its way out" is not the same thing as "gone".

Gist: https://gist.githubusercontent.com/emersonknapp/08a0496aa3726c8053285e6def25ab07/raw/1550d9ed37d12a2824dfb876996e6b09bf6844ba/ros2.repos
BUILD args: --packages-up-to rmw_connext_cpp rcl
TEST args: --packages-select rmw_connext_cpp rcl
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/7857

Linux
Linux-aarch64
macOS
Windows

^ the rmw_connext packages are being ignored by the build, I guess we've already disabled connext in CI?

^ the rmw_connext packages are being ignored by the build, I guess we've already disabled connext in CI?

My changes have only made it into a branch of ros2/ci.
I think rmw_connext_cpp was already disabled (as in, completely ignored) for linux-aarch64 and armhf. See this change from my commit for reference.

Oh! You're right it's only on ARM. Never mind then, we can just ignore that build

@ros-pull-request-builder retest this please

@ahcorde @mjcarroll as maintainers do you have any input on this?

@clalancette friendly ping - should we merge this?

Linux
Linux-aarch64 (not supported by rmw_connext)
macOS
Windows


Basic Tasks 21-28 by Sarath Chandra

@the-sarathchandra
Task21: Changes Verified.
Task22: Changes Verified.
Task23: Changes Verified.
Task24: Changes Verified.
Task25: Changes Verified.
Task26: Changes Verified. Contains Default activity name.

Task27:  Changes Verified. Contains Default activity name

Task28: Changes Verified


Update license with up-to-date year

Made only one change:

Update license to a year range, and include up-to-date year.
No other changes were made.

Thanks!


If no dd= data is to be propagated, it might be completely missing

Description
Complements #1864 and fixes Datadog/dd-trace-php#2386's failing parametric test
Motivation

Workflow

⚠⚠ Create your PR as draft
Follow the style guidelines of this project (See how to easily lint the code)
Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
Mark it as ready for review

Once your PR is reviewed, you can merge it! :heart:
Reviewer checklist

[ ] Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
[ ] CI is green

[ ] If not, failing jobs are not related to this change (and you are 100% sure about this statement)

[ ] if any of build-some-image label is present

is the image labl have been updated ?
just before merging, locally build and push the image to hub.docker.com

[ ] if a scenario is added (or removed), add (or remove) it in system-test-dasboard nightly

Ci run : https://github.com/DataDog/system-tests/actions/runs/7113514470

Hey @cbeauchesne, is there anything else needed? (I believe this is my first PR on this repo 🤔)

Thanks!


TFS functionality?

The ALM Accelerator tool does NOT work with TFS Server, correct? If it does, are there any published workarounds to get it up and running with TFS?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 39ededf2-e486-7b3b-0a19-7d390d79c987
Version Independent ID: 39ededf2-e486-7b3b-0a19-7d390d79c987
Content: ALM Accelerator for Power Platform - Power Platform
Content Source: power-platform/guidance/alm-accelerator/overview.md
Service: power-platform
Sub-service: guidance
GitHub Login: @jenschristianschroder
Microsoft Alias: jeschro

Thanks for your comment, @lordBrightLord. This issue has been assigned to the doc author for review.


Remove Fluent NorthStar

What

Why

How Tested

Process & policy checklist

[ ] I have updated the project documentation to reflect my changes if necessary.
[ ] I have read the CONTRIBUTING documentation.

Is this a breaking change?

[ ] This change causes current functionality to break.

Not sure if it's expected

Was
Now

It looks like delete button doesn't work in context menu for a message in the MessageThread

Message with a Mention is broken


Issue w.r.t pretraining models

Thank you for releasing the codes of ReferFormer and the following update of the pretraining code.
Can you please also release the scripts for the pre-training process? I have tried to use the hyper params mentioned in the paper (like the multi-step LR scheduler). However, the code you released uses a StepLRScheduler rather than a MultiStep one, and the run got stuck and failed. As such, I'm wondering if the script for the released pretraining code needs a special setup. The pretraining process consumes lots of computation resources and I don't want to waste any of the GPU cards. It would be appreciated if you can help with this.
Thanks in advance.

I may leave another question here and hope you can kindly answer.
For the joint training on YTB-VOS, does it still need the 12-epoch pretraining process? Or, the model can be trained directly, by the joint dataset of video-like RefCOCO/+/g and YTB-COCO (e.g. for video-swin, only k400 pretrained params are needed). In addition, are all the hyper params keep the same as the one with Ref-COCO pre-trained models.

Hi,
We have updated the pretraining main script. And please refer to this issue https://github.com/wjn922/ReferFormer/issues/7 to start the pretraining. But note that we pretrain the models on 32 V100 GPUs.
For the joint training, the datasets of Ref-YTVOS and Ref-COCO/+/g are mixed so the models are trained directly and do not need the pretraining process. The hyper params are similar to pretraining process except setting --batch_size 1 --num_frames 5 --freeze_text_encoder.
We have no plans to release the joint training in a short term, the expected released date would be 1～2 months later.


[runtime:ts] Fix firefox Worker error

Firefox don't transmit Worker message if an object of type Error is in the message.

LGTM!


Crunchyroll Subtitle Downloader

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm asking a question and not reporting a bug or requesting a feature
[X] I've looked through the README
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've searched known issues and the bugtracker for similar questions including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Please make sure the question is worded well enough to be understood
Can yt-dlp download Crunchyroll subtitles from premium videos?
Provide verbose output that clearly demonstrates the problem

[ ] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[ ] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
No response

yt-dlp --ignore-no-formats-error --skip-download --write-sub --sub-langs en-US --username "username" --password "password" "url"

I got ERROR: [crunchyroll] GYZXQ2036: Invalid username and/or password even though I put in the correct username and password.

Username needs to be your email address. This could be an issue with special characters/escaping. Make sure to quote your username/email. Also, omit --password from the command and yt-dlp will prompt you to enter it interactively

Here are the languages of the subtitles. I only want to extract the English and Deutsch ones.

--write-sub --sub-lang "en.*,de.*"

I got this:
WARNING: [crunchyroll] GYZXQ2036: This episode is for premium members only [crunchyroll] GYZXQ2036: Downloading chapter info WARNING: No video formats found! WARNING: Requested format is not available [info] There are no subtitles for the requested languages

if it's premium-only content and you don't have premium it's not gonna work. yt-dlp isn't magic

It appears just trying to download thumbnails or subs spits out 403 error.


Is it possible to postpone the access_token expiration with every call?

When I successfully login and gets forwarded to my webpage I obtain the following:

I would like to implement some sort of a timeout: if you do not interact with the page in 10 minutes, at the next call you will have to login again.
Right now I am using:
    authentication portal my_portal {
      crypto default token lifetime 600
      cookie lifetime 7200

But after 20 minutes I have to login again.
With every call the expiration of the session cookie gets extended but the access_token one no.
Is it possible to do that?

The issue appears to me that that token is a jwt that is hardcoded to expire in 900 seconds (15 minutes)
It's pretty annoying with SSO and really annoying if you do local logins or are streaming anything for any duration.
I'm actually not clear why you can even set a cookie lifetime if this limitation is still in place.
I may try to patch something myself for my own use, but I would really love to see something similar as an official change.

crypto default token lifetime 7200 cookie lifetime 14440
this would be 2 hours expiration

I am not trying to enlarge the lifetime, but to reset it with every interaction. If the user keeps on working with the page the lifetime is potentially eternal, but as soon as he stops, after for example 10 minutes the token expires.

@carlo161 , are you asking for the ability to refresh the token just before it expires?

As long as the user is active?

Ah, I was mistaken.  Either way, my overarching confusion was "Why have a longer cookie lifetime if the JWT expiring kills the session?"
Anyway, back to this issue - yes, @greenpau , I think the ask is to make the token auto-refresh / have the expiration extend to now+increment on every request

Yes, right. I would like to refresh the token with every call, as long as the user is active.

Following this for further information. Since i would like to refresh the token on every call too.

Any update on this? This plugin already support token refresh?

It is a critical issue for our project: users have to stay logged in for as long as they are active (GET, POST,....). The only option for me now is to set lifetime = 2 years, which is not a proper solution but rather a desperate measures.

this plugin is very nice but it does require some refreshing mechanism. I am working with logs and suddenly it fails to fetch and I have to refresh and log in again which is quite disruptive.


ignore jupyter folders

Changes
ignore .ipynb_checkpoints folders in pytest discovery

why would we have these in the root directory?

why would we have these in the root directory?

jupyter tends to create a lot of temporary files in those folders (e.g. when opening a .py file)
They don't pop up in the root dir, the exclude works in subfolders


How to setup Gauge?

I am trying to run gauge
I can see switch s1 is added in both faucet and gauge controller, but  I am not getting any stats from switch
my gauge log
Feb 26 01:57:20 gauge  INFO     DPID 1 (0x1) up
Feb 26 01:57:35 gauge  INFO     port stats request timed out for s1
Feb 26 01:57:40 gauge  INFO     port stats request timed out for s1

My VM IP: <IP_ADDRESS>, <IP_ADDRESS>
my config files:

faucet.yaml

version: 2
vlans:
    4090:
        name: "trusted network"
        unicast_flood: True
dps:
    s1:
        dp_id: 1
        description: "Switch"
        interfaces:
            1:
                native_vlan: 4090
                name: "port1.0.1"
            2:
                native_vlan: 4090
                name: "port1.0.2"

gauge.yaml

version: 2
faucet_configs:
    - '/etc/ryu/faucet/faucet.yaml'
watchers:
    port_state_poller:
        type: 'port_state'
        dps: ['s1']
        db: 'influx'
        interval: 5

    port_stats_poller:
        type: 'port_stats'
        dps: ['s1']
        db: 'influx'
        interval: 5
dbs:
    influx:
        type: 'influx'
        influx_db: 'faucet'
        influx_host: 'localhost'
        influx_port: 8086
        influx_user: 'faucet'
        influx_pwd: '123'
        influx_timeout: 10

Steps I followed:

Start controller
sudo ryu-manager  --ofp-tcp-listen-port=6633 faucet/src/ryu_faucet/org/onfsdn/faucet/faucet.py
Start mininet and add gauge controller
sudo mn  --mac --controller=remote,ip=<IP_ADDRESS>
sh ovs-vsctl set-controller s1 tcp:<IP_ADDRESS>:6633 tcp:<IP_ADDRESS>:6663
Start gauge controller
sudo ryu-manager --verbose --ofp-tcp-listen-port=6663 faucet/src/ryu_faucet/org/onfsdn/faucet/gauge.py

Always getting port stats request timed out for s1

Looks like there is some kind of connectivity problem (gauge is not receiving replies). It would be good to troubleshoot gauge<->OVS connectivity.
If you find a bug within gauge that's causing the problem, please do reopen this issue with the details. You can also look at the existing unit tests that run Gauge for an example of running Gauge successfully within Mininet.

I tried ovs-vsctl, it shows me both controllers are connected
mininet>sh ovs-vsctl show
f1d910ec-c953-40bf-acdc-15d3ade32575
    Bridge "s1"
        Controller "tcp:<IP_ADDRESS>:6633"
            is_connected: true
        Controller "tcp:<IP_ADDRESS>:6663"
            is_connected: true

Can you specify how to troubleshoot gauge<->OVS connectivity?
I am not able to understand unit test, can you  please give me bare minimal faucet-gauge mininet example.

If I change watchers db from influx type to text type, I am getting correct data written in file.
version: 2
faucet_configs:
    - '/etc/ryu/faucet/faucet.yaml'

watchers:
    port_stats_poller:
        type: 'port_stats'
        dps: ['s1']
        db: 'ft_file' # influx throws port stats request timed out
        interval: 5
dbs:
    influx:
        type: 'influx'
        influx_db: 'faucet2'
        influx_host: 'localhost'
        influx_port: 8086

    ft_file:
        type: 'text'
        file: 'ports.out.json' # Getting correct data written in file

Finally got it working.
I don't know whether this is relevant but when I changed influx_host from localhost to <IP_ADDRESS> or IP aaddress, it worked


⚠ Bofrost.com has degraded performance

In f595d99, Bofrost.com (https://www.bofrost.com) experienced degraded performance:

HTTP code: 200
Response time: 1342 ms

Resolved: Bofrost.com performance has improved in 301cbba.


Ability to hide server list

This is not an issue but a "nice to have" feature.
The ability to hide the server's list on the left, the same way we can hide the nicknames list on the right.

Closing as duplicate of https://github.com/thelounge/lounge/issues/50, but thanks for your input!


doc/style.css: Put ToC into a left column

This is a change to the HTML manual stylesheet that puts the table of contents into a fixed left column. I feel this improves the UI for browsing the docs on a desktop computer or laptop, on the other hand this change will probably make things worse on mobile/tablets. I expect this to be controversial, and this is certainly not the end-all, be-all of stylesheets.
Before:

After:

Also see the SnabbDoc status below for a demo. :-)

Awesome!
I like simple black-on-white style with a floating table-of-contents. That is how I read most documentation.
I do think that programmer friends don't let programmer friends write their own CSS though. Consider finding a popular pandoc template in this style?

I do think that programmer friends don't let programmer friends write their own CSS though. Consider finding a popular pandoc template in this style?

I had written that for my own website, its more or less copy/paste. If anybody finds a good template I have no issue with scrapping the CSS. I personally prefer my own CSS though, so if I am to be bothered with this at all it will be my ~100 lines that I understand well. I don't touch other peoples CSS for... reasons. Let's just say I am the son of a graphic designer, its an emotional topic. ;-)

@eugeneia I definitely see a floating ToC as a big step in the right direction. I will gladly merge.
On a meta-level I think we need to decide how we want to present the documentation and perhaps make a follow-on PR based on that. Some possibilities:

DIY-retro-programmer style. In this case we should write our own CSS.
Generic contemporary style. In this case we should pick a popular template.
Clever and novel style. In this case we should hire a designer.

I lean towards the middle option and would be happy with a generic template like the one on readthedocs. I would hope that somewhere there is a gallery of 20 popular pandoc themes that we could choose from.
I have some specific beefs with the CSS on this PR, particularly that the left-hand-side feels cramped (horizontal + vertical scrollbars on the ToC) while the right-hand-side is empty space. However, unless we specifically want the DIY-retro-programmer style then I don't think it makes sense to work out the design via haggling on Github PRs.
Sorry to poke on what is acknowledged to be an emotional topic.

Sorry to poke on what is acknowledged to be an emotional topic.

Oh, my CSS is not emotional for me, other CSS is. E.g. the readthedocs CSS is a typographic catastrophe. It gets basic things like text rhythm so wrong, its like a searing iron stuck right into my eye. That's what I mean with graphic designer heritage. So my choice would be the first option because I am extremely biased.
Realizing my own bias, I will remove myself from this discussion starting now. :-)

@eugeneia I start to come around to your point of view. I googled around for pandoc templates and to me it seems like everybody else is cooking up their own. I don't find any generic off-the-shelf template that I can recommend. On closer inspection the readthedocs CSS does look like an eyesore to me too.
I will seek some feedback from the in-house designer at Snabb HQ :-) and we can see what we think about that.

@eugeneia Okay! Let's open this "programmers talking about layout" can of worms after all :-).
I like the overall style on this PR. I feel like some tweaks could improve it. I asked Ann for suggestions and she whipped up an idea for some tweaks in Photoshop.
Before:

After:

What do you think?
The main change is to add more whitespace and then also to make H1/H2/H3 headers more distinct with shading and spacing.

@lukego Can you publish a commit to the changes somehow so I can append it to this PR? Its hard to evaluate without being able to resize the viewport.
I think I like the header tweaks. Regarding the spacing, I choose the minimal spacing in order to support viewports as small as possible (e.g. I never have my browser fullscreen). I think the optimal solution would be to use the coming “flexbox” feature, but I did not go down that route because its not yet standardized across browsers.

@eugeneia Sorry, I don't know how to write CSS. The "after" image is only a visual suggestion, it is literally a Photoshopped version of the "before" image.

Sorry if this is a distraction on this PR but I also generated the PDF manual for the first time in ages: snabbswitch.pdf.
Just in case we would become frustrated with HTML/CSS one backup option would be declaring the PDF manual canonical. This way we already have the formatting that Pete Kazmier did years ago and the reader software (Evince, Preview, iBooks, etc) can take care of making the table of contents accessible.

I am not exactly a friend of the PDF file format to be honest, but let's not decide that here and now.
I will merge this as-is onto max-next for now, as I see it as an immediate albeit imperfect improvement. We can iterate in separate PRs.

Sounds good.
I do fear that maintaining raw CSS for the HTML manual will be laborious, since people will be reading this on Safari/Firefox/Chrome/IE and Desktop/Laptop/Tablet/Phone and complaining about perceived shortcomings, but let us see how that plays out. I don't have much to offer in this area.
I can volunteer to give the PDF manual some love as a secondary format. Personally I read most reference material in PDF e.g. datasheets, Intel CPU manuals, Agner's optimization manuals, etc. This works really well for me in Preview on the Mac and in iBooks on the iPad. (evince on Linux is at least tolerable.) I also have a little shelf of hardcopies from Lulu and would love to include the Snabb manual there :).
Likely 95% of what people do to improve one format will carry through to the other formats anyway since content is king. I do like the idea of having one format as canonical, and never shipping a release where we screw that one up, and am totally fine with this being the HTML edition once we have that in the shape we want it.

@eugeneia How about The Unofficial DynASM Documentation as tasteful CSS that we could reuse as a base?


Semantic UI problem when adding a table within a grid

When we add a table within a grid it forces the next column to flow underneath and then you can't control your display for different devices sizes. Does anyone knows how to fix this

1 row mobile - 2 tablet - 4 computer

1
2
3

1 row mobile - 2 tablet - 4 computer

1
2
3

1 - row mobile - 2 tablet - 4 computer

1 - row mobile - 2 tablet - 4 computer

Try removing the second table and you will see that it will replace itself properly
When you run the debug in chrome you see that it changes the class where the table is contained to
sixteen wide mobile eight tablet four computer column

Set table-layout: fixed, there's no way on a framework level to prevent tables from auto-expanding beyond 100% width

Do you have a timeframe for version 2.2.x as I have many places where I have a table withiin a grid (building an elearning content creation tool) and requires lots of advanced layout and need to provide a tablet and smartphone version

This has to do with how table work in the browser and is not inherent to SUI. This will happen with any grid system.

Have you looked at what I wrote above. The issue is with the SEMANTIC markup being changed when there is a table inside. If I am in the console and rewrite what was changed then it flows perfectly.
sixteen wide mobile eight wide tablet four wide computer column  -  IN THE CODE
sixteen wide mobile eight tablet four computer column  - IN THE RENDERED CODE

There's a contributing guide to explain how to submit a bug report. This is not a suggestion but a mandate for your bug request to be evaluated correctly. You need to include a test case (fork the jsfiddle in readme) and accurately outline the steps to reproduce.
Your code sample didnt appear correctly because you didnt include the  markdown for code. Now that I've inferred what you intended, and created my own test case I can't reproduce the issue
http://jsfiddle.net/f3rauaqa/

Fair enough
I created a meteorpad project for you to look at to properly view the issue
http://meteorpad.com/pad/opEoAS5vrPJ5Dxc2e/Semantic Grid and Table - automatic!
meteorpad

Just found out from Meteor that it is an issue with Blaze that will remove redundant class names when compiling to javascript. Will leave additional notes in Meteor / Semantic for other people who might have the same issue

Check #1526


MaxLen Validator failed with non-ASCII characters

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
Define a field where maxlen setting to 3 for example.
field.String("text").Default("").MaxLen(3)
than set non-ASCII to this field.
create.SetText("😯")
it will report value is greater than the required length
I think it cause by if len(v) > i {.

Expected Behavior 🤔
From what I know, MySQL and PostgreSQL varchar define char length.
Should we change the above behavior to validate char length?

Steps to Reproduce 🕹

Steps:

Your Environment 🌎

Tech
Version

Go
1.15.?

Ent
0.5.?

Database
Mysql

Driver
https://github.com/go-sql-driver/mysql

I can help with this if you want

I'd say add a validator RuneCount() instead and mention the difference in the docs.
I have a case where I'm interested in the byte length of a string and your proposal will break that for me. I will follow this thread.

Hi @zhyon404, please see comment from https://github.com/ent/ent/issues/1637#issuecomment-859854768

@giautm
I've considered this option
I think another role of MaxLen is to change the size of the varchar.
And the assignment to size needs to go through desc.
Something like
f:=field.String("name").
    Validate(MaxRuneCount(10))

f.desc.Size=10

Writing this break builder pattern and I think is a little annoying?
direct change is backward incomplete, of course,  so do you think it's a good idea to add a new method like MaxRuneLen?

f.desc.Size=10 why you need this statement?
I think you have wrong charset when creating the table, it should be utf8mb4 or utf8mb3 to storing Unicode character.

f.desc.Size=10 why you need this statement?
It should be:
field.String("name").
    MaxLen(10).
    Validate(MaxRuneCount(10))

The above code MaxLen  call should be here?
https://github.com/ent/ent/blob/f326c7dfd088f112d0bc3150161862115d6fff63/schema/field/field.go#L211-L221
which add validator,
so if I want to change size without adding a validator, I need this f.desc.Size=10 if I'm understanding correctly.

Yah, sorry about wrong reference code. 🥲
If you want change Size only, you can use entsql.Annotation
import (
	"entgo.io/ent/dialect/entsql"
	"entgo.io/ent/schema/field"
)

field.String("name").
	Annotations(entsql.Annotation{Size: 21})

@giautm that's very helpful. thanks.


Capture in ios always fail

Hello! When I try capture sound in iphone,the return value is always false. I'm use UE5.1 and iphone 13,phone system is 16.3.1

the record permission is granted

Hello. Can you please provide any logs you have? I haven't been able to test the capturable sound waves on iOS because I don't have that device at the moment, but if you can provide me with any logs that would be great.
To clarify, have you added NSMicrophoneUsageDescription to the AdditionalPlistData field in Unreal Engine? The DefaultEngine.ini file should have the following line (RuntimeAudioImporter is written just for consistency):
AdditionalPlistData=<key>NSMicrophoneUsageDescription</key><string>RuntimeAudioImporter</string>

Hello.NSMicrophoneUsageDescription has added.

And I'm not sure if the fellowing log is what you want.The log is in Xcode.
log.txt
By the way,I'm facing same issue when I use UE's Audio capture.As shown below:

When I first recording phone no response.On the second attempt, the phone crashed.That crash is in [File:./Runtime/AudioCaptureImplementations/IOS/AudioCaptureAudioUnit/Private/AudioCaptureAudioUnit.cpp] [Line: 165]

I think the following code also needs to be executed before capturing for iOS, can you test that?
[[AVAudioSession sharedInstance] requestRecordPermission:^(BOOL granted) {
    // It might make sense to check the result here
}];

For example you could add the following function declaration to CapturableSoundWave.h:
UFUNCTION(BlueprintCallable, Category = "Capturable Sound Wave|Permissions")
void RequestCapturePermissions();

And the following function definition to CaptureableSoundWave.cpp:
void UCapturableSoundWave::RequestCapturePermissions()
{
#if PLATFORM_IOS
    [[AVAudioSession sharedInstance] requestRecordPermission:^(BOOL granted) {
        // It might make sense to check the result here
    }];
#endif
}

And revoke this function beforehand.

The permission is granted.

Only when in case AVAudioSessionRecordPermissionGranted,I'll start capture audio

@gtreshchev  T_T  I have the same problem on my iphone too
And also on my M1, the first record can play sound, but the second-time record doesn't playback.
I just notice that the second time I press key to record, there is no log about PCM data, but on my windows, the PCM data always appears when I press record button.

@original-curtain Hello, do you make it work in IOS finally? ^_^

Sorry，I'm not make it work

@original-curtain  I found that "Cross-Platform Voice Chat Pro" plugin can work in IOS, you can find the blog in https://blog.csdn.net/qq_31042143/article/details/129479405?spm=1001.2014.3001.5501
BTW, Are you Chinese? Me too ^_^

对啊 不过老哥 你这插件收费，目前我是通过调ios原生方法来实现录音的，只不过最后播放录音还是有问题 orz

@original-curtain 我查到的方法也是说要写原生插件。前几天三折，我买了这个Pro插件，哈哈；看了一下源码，他在UE里面直接调用AVFoundation.h，然后写了语音功能，没有用XCode去封装库调用；俺先研究研究 orz

@1165048017 （抱拳

This could potentially solve the issue, but I am unable to test it at the moment as I do not have an iOS device. If anyone can take a look and test it, that would be very helpful.
RuntimeAudioImporter.zip

@1165048017 @original-curtain this support should have been added since commit bc628baf25206b294f5bfa8e8d779eeda5bc85d3. Please reopen this ticket if the issue still persists.


Separate option for resetting AFK status on mouse click

Lack of functionality to disable removal of AFK status on mouse click
Raid farms and most XP farms require the player to setup an autoclicker to run them while afk. It's frustrating that there is no way to tell whether a player is online or is AFK and running this farm of this type. There are already options like resetOnMovement and resetOnLook, but attacks always remove the AFK status
Solution
Addition of an option in the config file named something like resetOnClick that when set to true, will check for clicks and remove the AFK status if a click is detected, and when set to false, will not check for clicks.

That is a vanilla function that resets the lastPlayerAction value

It might not be exactly as you've stated, but I was able to add functionality to mark players as AFK while they are "ONLY" attacking, and not moving; such as stationary with an auto clicker.

It might not be exactly as you've stated, but I was able to add functionality to mark players as AFK while they are "ONLY" attacking, and not moving; such as being stationary with an auto clicker.

Okay, thanks for helping!

Yeah so the feature basically works by measuring "move / look / attack" update status timers; and compares the 4 data points.
So basically, if the Auto Clicking player does Anything like accidentally picking up items; or have any sort of changes in looking or even micro movements; then this change will not take effect; because those values are required for the detection to work.


[FLINK-10254][backend]Fix inappropriate checkNotNull in stateBackend

What is the purpose of the change
The argument checked in AbstractKeyedStateBackend of numOfKeyGroups is inappropriate, and it should be checked with the value bigger than 1.

cc @StefanRRichter

Do we have any tests for that? Why was the change introduced in the first place? Did you hit an issue with this check?

@dawidwys I check git history of this selection, and it was substituted in FLINK-4380, but may be the project structure was adjusted and I can't really find the change line in the FLINK-4380, Do you mean that I need to add another test case to cover this change ?

What I meant is: Why have you decided to open this PR? Have you came across any problems with the check as it is currently in master? Before even analyzing a PR we should have a clear picture what is the reason for a change to be able to properly prioritize an important changes from not so much, but still requiring an effort of reviewing, verifying etc.
As far as I understand this is an isolated, internal component and a similar check is done one layer upwards. That's why I would really like to understand the reason for this PR.

I didn't run into a problem, but when i review the code locally, i found that a checkNotNull do nothing to a primitive int value.It's indeed checked upwards, but i think its here for defensive code, so i push a little change.


No Kotlin?

Maintaining the GUI DSL is a pain. Every field must be stored since they cannot be retrieved from the Builder (easily).
I see two solutions:

No more Kotlin
Add getters to the builders

1. No More Kotlin
This is self-explanatory.
2. Add getters to the builders
This would mean the chest function would be changed to look something like this:
public fun chest(init: Chest.Builder.() -> Unit): Chest = Gui.chest().apply(init).build()

This may be reconsidered later.


[Misc] Minor Improvements

Acceptance

[ ] The website is fully responsive

Tasks

[ ] Improve / Fix mobile responsiveness on the website (e.g. footer not fully responsive)

[ ]  Replace data package image on the home page with live demo/code example (Data Integration and Management)

@lauragift21 can we get a bit more descriptive heading and can issues start with a description / job story ...

@lauragift21 can you update the title for this issue so it accurately reflects the contents. I came and looked at it when i got a notification and could have skipped if notification had been "Make website fully responsive: Fixed"


Change name of the getLocation method to a simple getUrl

This method is not yet released in any releases, so it should be safe to rename it. The new name better reflects what it returns, and users will know that it is always a URL being returned.

Ok, changed to URL most places
PluginRelease still uses String though...

Pushed a fix to a related bug. The DefaultUpdateRepository accessed its private url member directly instead of through getter in initPlugins(). This caused problems for my GitHubUpdateRepository which overrides getUrl but not initPlugins.

Thanks!

I have the same question from my last comment, if we should change the signature of UpdateManager.updatePlugin (similar with installPlugin method - without URL parameter).

I don't understand the question regarding UpdateManager.updatePlugin. Do you mean that udpatePlugin only needs to take id as param? Or that it could take id, version instead of id, url and find the url from that?

My idea is to have the same signature for the method updatePlugin like installPlugin, with id and version as parameter and to use the same downloadPlugin(id, version) method for download. I don't know yet if it's possible but I feel that it's more clear/natural.


fix translation path for docs

Coverage decreased (-0.03%) to 88.798% when pulling 70329441a4d7a5b9477f548f7b3d086714e838c7 on fix/docs-translations into 1e5764b406293d8ecb3095172ba085b2b95a05e2 on main.


Duplicate silences created

I'm not exactly sure when it started happening, but I think it began with version 0.64. When I create a silence in Karma using Silence this group, two identical silences end up being created.
It should be noted that I run two Alertmanagers in HA mode, and two instances of Karma behind HAproxy, running on the same VMs as each Alertmanager.
Here's the alertmanager section of karma.yml, which hasn't changed since 0.63 at least:
alertmanager:
  servers:
  - name: default
    uri: http://localhost:9093
    external_uri: https://alertmanager.example.com
    proxy: true

Looks like another request is being send when the modal is closed.

Should be fixed now, will make a new release soon

Switching between tabs also triggers a new request (after it was submitted). Needs a better fix

Need to move state handling so it doesn't get lost on tab switch. Will try to get it done in the next few days.

Should be fixed for good now

I just upgraded to v0.66, and it works great, thanks!


Refactor TextEditViewController to use separate KeyboardViewController

Refactoring the TextEditViewController to only be responsible for the top bar which is now not part of a collection view, meaning that the dismiss button & confirm edit button are no longer collection view cells but rather gazeable buttons. To display the keyboard, it embeds a KeyboardViewController that is responsible for the keyboard & suggestions.
This KeyboardViewController should be used in the future as a component to refactor the keyboard within the main home screen as well.

"X" button and "check" button don't respond to headtracking taps. this is on the edit my sayings keyboard


add unit test for remoting module

What is the purpose of the change
Increase unit test coverage for remoting module
Brief changelog

add test for remoting-netty4 and remoting-grizzly
use NetUtils to get free port for JettyHttpBinderTest and TomcatHttpBinderTest
add curator-test library to fix zookeeper test

Verifying this change
CI pass

Codecov Report

Merging #1509 into master will increase coverage by 0.49%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1509      +/-   ##
==========================================
+ Coverage   31.59%   32.09%   +0.49%
==========================================
  Files         682      682
  Lines       33035    33035
  Branches     6592     6592
==========================================
+ Hits        10437    10602     +165
+ Misses      20742    20539     -203
- Partials     1856     1894      +38

Impacted Files
Coverage Δ

...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java
83.33% <0%> (-5.56%)
:arrow_down:

.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java
73.14% <0%> (-2.78%)
:arrow_down:

.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java
54.54% <0%> (-2.03%)
:arrow_down:

...baba/dubbo/remoting/transport/mina/MinaClient.java
57.97% <0%> (-1.45%)
:arrow_down:

.../alibaba/dubbo/config/AbstractInterfaceConfig.java
38.46% <0%> (+0.45%)
:arrow_up:

...ing/transport/netty4/logging/MessageFormatter.java
14.28% <0%> (+14.28%)
:arrow_up:

.../remoting/transport/netty4/NettyClientHandler.java
18.18% <0%> (+18.18%)
:arrow_up:

...remoting/transport/netty4/logging/NettyHelper.java
20.75% <0%> (+20.75%)
:arrow_up:

.../dubbo/remoting/transport/netty4/NettyChannel.java
25% <0%> (+25%)
:arrow_up:

...o/remoting/transport/netty4/NettyCodecAdapter.java
29.72% <0%> (+29.72%)
:arrow_up:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb8884e...f96e764. Read the comment docs.


feat: re-implement dynamic-import-vars

Description
fix: #6992

Additional context
I think we can deps on @rollup/dynamic-import-vars (dynamicImportToGlob) to re-implement it.
We can get some enhancements to dynamic import

replace translater to es-module-lexer instead of compiler. There should be an improvement in performance?
support dynamic import query syntax. such as ?raw.
support @/${variable} resolve path.

Because we can make dynamic import use the code of import.meta.glob :thinking:

What is the purpose of this pull request?

[ ] Bug fix
[x] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.n
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Ideally, include relevant tests that fail without this PR but pass with it.

Hey! 👋
It looks so cool!

#7537 got merged. While I do not completely understand this PR, from a brief overview, I guess maybe instead of depending on the glob transform directly, maybe we could directly transform the code to import.meta.glob expressions and let the importMetaGlob plugin handle the rest. Similiar to https://github.com/vitejs/vite/blob/330e0a90988509454e31067984bf0cdbe2465325/packages/vite/src/node/plugins/assetImportMetaUrl.ts#L55

yes, this PR make the dynamicImport syntax to importGlob and now is easy to make it.  😊https://github.com/vitejs/vite/pull/7756/files#diff-309e5af7d3263d408c73cf68d3c7a2d526438f01ad6e1b56bf08c62d9cafa06dR101-R102

@poyoho I made the suggest changes at https://github.com/poyoho/vite/pull/1

wow. good point. thanks @antfu make it forward. 😄


fix(connectors): fixes MGDCTRS-860, fixed admin API connector delete

Description
Fixes MGDCTRS-860, fixes admin API connector delete
Verification Steps
Added integration test should pass.
Checklist (Definition of Done)

[X] All acceptance criteria specified in JIRA have been completed
[X] Unit and integration tests added that prove the fix is effective or the feature works (tested against emulated and non-emulated OCM environment)
- [ ] Documentation added for the feature
[ ] CI and all relevant tests are passing
[ ] Code Review completed
- [ ] Verified independently by reviewer
- [ ] Required metrics/dashboards/alerts have been added (or PR created).
- [ ] Required Standard Operating Procedure (SOP) is added.
- [ ] JIRA has created for changes required on the client side

LGTM, added a note about some additional tests/checks


Unable to add third party packages in AndroidTV

Hi
In my current application, I am trying to install third-party packages i.e 'react-native-vlc-player', 'react-native-crypto-js' etc.
and added it in renative.json but still Renative doesn't include these package settings in Android TV settings.gradle, app/build.gradle & app/src/main/java/rnv/MainApplication.kt.
I have also added these files in Renative's appConfigs/base folder with the same hierarchy which is required in AndroidTV but after then, the build stopped working.

@SandeepKharbanda can you share how your  ./renative.json section:
"plugins": {
       "react-native-vlc-player": { .... },
       "react-native-crypto-js": { .... }
}

looks like

@pavjacko I have tried with both ways but still, I am getting an error.
"react-native-vlc-player": "source:rnv"
"react-native-vlc-player": {
      "version": "0.2.3",
      "android": {
        "package": "com.ghondar.vlc.VlcPlayerPackage",
        "path": "node_modules/react-native-vlc-player/android"
      }
    }

And, the package is working fine in react-native.

replace android with androidtv
"react-native-vlc-player": {
      "version": "0.2.3",
      "androidtv": {
        "package": "com.ghondar.vlc.VlcPlayerPackage",
        "path": "node_modules/react-native-vlc-player/android"
      }
    }


[confcom] adding warning if users are going to print to the command line

Needed for compliance with best practices in warning users when secrets may be printed to the command line
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
confcom
General Guidelines

[x] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
[x] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

confcom


更新了February的拼写错误

There was a typo in the “Langhian/docs/docs/integrations/retrievers/tavily.ipynb”, "February" was misspelled.

this is actually text from the retrieved documents, so prefer to keep as is


Home page sections and first steps of setting up the user entities

Continuation of #8.
The main update is regarding the authentication and authorisation flow exemplified below. We are not currently storing any token because we don't need them at this phase.

Updates:

Functions to add a new user to the database and join a group on behalf of them.
A new class that can be shared amongst the servlets in order to retrieve the ID of the user (if they had previously authenticated and provided the authorisation needed).
The start date and the end date fields of the Event class are stored as longs instead of strings (we are storing the number of milliseconds since epoch time).
Functions to retrieve all the groups joined by a user.
Functions to add a new event to a specific group.
Working lateral menu to switch between different sections on the home page (the groups have been moved into a new section).
Onclick list of events associated with each group.

I used the following restraint in order to provide the functionality of switching between different sections on the home page:
The section associated with one of the options on the lateral menu has the same ID as the text incorporated in that option (case insensitive). In this way, once I know the option I can easily identify the section without checking other sections. This will be later modified since it allows only single word options.
The user will be later added to all the groups by default and they will be registered for all the events from all the groups. The page supports adding new groups / events without directly associating them with the user.
The next phase will be to provide functionality of joining events and groups. We will also include a separate pull request for more error checking and testing after developing all the necessary functions.
Instructions for including the credentials and testing the app

In order to use the authentication and authorisation, the web page should provide valid OAuth 2.0 Client ID, OAuth 2.0 Client Secret and API key.
For this project, I already set up the OAuth consent screen and the OAuth 2.0 client ID.
The owners can easily access this information from the Credentials page associated with the project on the Google Cloud Platform (the client secret is available on the edit page of the OAuth 2.0 client).
I will further detail where should be this information included:

API key

line 17 in script.js: const API_KEY = 'YOUR_API_KEY'

Client ID

line 4 in home-page.html: <meta name="google-signin-client_id" content="YOUR_CLIENT_ID">
line 6 in index.html: <meta name="google-signin-client_id" content="YOUR_CLIENT_ID">
line 18 in script.js: const CLIENT_ID = 'YOUR_CLIENT_ID'
line 44 in AuthStatusServlet.java: private static final String CLIENT_ID = "YOUR_CLIENT_ID"

Client Secret

line 45 in AuthStatusServlet.java: private static final String CLIENT_SECRET = "YOUR_CLIENT_SECRET"

URL

line 46 in AuthStatusServlet.java: private static final String REDIRECT_URI = "YOUR_URL"

After including these, you should also make sure that the current URL is part of the authorized JavaScript origins and authorized redirect URLs.
To check that open the edit options of the OAuth 2.0 client and add the URL in the following sections: authorized JavaScript origins and authorized redirect URLs (or skip the addition if the URL is already present).
It might take a few minutes to update the client.
You can also try to delete the cache in case you still receive an error about the URL not being a valid origin.

Thanks @csperl for pointing out these aspects! I will break this pull request into multiple requests such that they are easier to understand and follow.


CSS file is not overwritten, instead changes are appended

node v12.13.1
npm 6.12.1
node-sass 4.13.0
libsass 3.5.4
node -p process.versions
{   node: '12.13.1',   v8: '7.7.299.13-node.16',   uv: '1.33.1',   zlib: '1.2.11',   brotli: '1.0.7',   ares: '1.15.0',   modules: '72',   nghttp2: '1.39.2',   napi: '5',   llhttp: '1.1.4',   http_parser: '2.8.0',   openssl: '1.1.1d',   cldr: '35.1',   icu: '64.2',   tz: '2019c',   unicode: '12.1' }
node -p process.platform
linux
node -p process.arch
x64
I am using node-sass --watch file.scss > file.css on the command line, but any changes are appended to the output file, instead of overwriting it:
=> changed: /media/xyz/file.scss

[changes here..]

 => changed: /media/xyz/file.scss

[changes here..]

Nor sure where to look for in the documentation. Any clues?

I tried it in a different way:
node-sass -w -r scss/force-app/ -o ../dfind/force-app/
Seems to work for now.

If you're using the redirect operator https://quickleft.com/blog/command-line-tutorials-redirection-pipes/ and it's not working, that is a system level issue unrelated to node-sass


IoT samples using CDK(Python + Typescript) and CloudFormation

Issue #, if available: https://github.com/aws-cloudformation/iac-model-evaluation/issues/18
Description of changes: IoT samples using CDK(Python + Typescript) and CloudFormation
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

What's the difference between this and the iotanalytics samples we already have in the repo?

I added samples for IOT Core as mentioned here in this PR by mistake.


Add parallel processing

You want to make a PR to Wrangle
Thanks so much :) First, please take a moment to carefully check through
the below items:
Sanity

[ ] I'm aware of the implications of the proposed changes
[ ] Code is PEP8
[ ] I'm making the PR to master

Docs

[ ] Docs are updated
[ ] Docs version is correct (index.html and _coverpage.md)

Tests

[ ] Changes have gone through actual use testing
[ ] All local tests have passed (run ./test.sh in /talos)
[ ] Tests have been updated to reflect the changes

Hello @mikkokotila! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file wrangle/df/df_parallelize_process.py:

Line 2:1: W293 blank line contains whitespace
Line 4:1: W293 blank line contains whitespace
Line 9:1: W293 blank line contains whitespace
Line 13:1: W293 blank line contains whitespace
Line 19:1: W293 blank line contains whitespace

Pull Request Test Coverage Report for Build 112

2 of 11 (18.18%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.3%) to 50.874%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

wrangle/df/df_parallelize_process.py
1
10
10.0%

Totals

Change from base Build 107:
-0.3%

Covered Lines:
611

Relevant Lines:
1201

💛  - Coveralls


services.geoclue2: no way to add [static-source]

Describe the bug
geoclue.conf offers a  [static-source] section. This section is not exposed in services.geoclue2, nor is there a way to inject arbitrary INI sections.
Steps To Reproduce
Steps to reproduce the behavior:

open https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/desktops/geoclue2.nix
grep for "static-souce"
I guess?

Expected behavior
There should either be a way to inject arbitrary config (in the style of font.fontconfig.localConf), or a nix-ized mapping for static-source.
Screenshots
None.
Additional context
I have a mostly static computer that accesses the Internet through a "VPN" (actually a sing-box proxy). Ever since Mozilla Location Service went down, geoclue has been using just geoip, which puts me on the wrong side of the Pacific. I would like to use [static-source].enable = true to pin down a known-good location.
I might also require a way to write to the geolocation file in geoclue's own etc. A symlink out to /etc (non-static) might do, I don't know.
Notify maintainers
If I am reading the source correctly, that would be the pantheon people: @davidak @bobby285271
Metadata
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.28, NixOS, 24.05 (Uakari), 24.05pre616726.7bb2ccd8cdc4`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.2`
 - channels(root): `"nixos, nixos-hardware"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Add a :+1: reaction to issues you find important.

I think the [compass] section is also not mapped in.

Now urgent because of #321121.

I've opened https://github.com/NixOS/nixpkgs/pull/329654. For now, the workaround is simple, e.g. from my NixOS configuration
{
  environment.etc = lib.mkIf (! config.services.geoclue2.enableWifi) {
    "geolocation".text = ''
      # Example static location file for a machine inside Statue of Liberty torch
      40.6893129   # latitude
      -74.0445531  # longitude
      96           # altitude
      1.83         # accuracy radius (the diameter of the torch is 12 feet)
    '';
    "geoclue/conf.d/00-config.conf".text = ''
      [static-source]
      enable=true
    '';
  };
}

where /etc/geolocation is of the format described in the man page.


Output Colors

Steps to reproduce
I originally posted the issue to here https://github.com/dotnet/cli/issues/9250, but according to one of the comments it looks like I should investigate msbuild.
Summary:

dotnet build and dotnet run commands do not color output (at all).
dotnet build /clp:ForceConsoleColor allows colors to correctly appear
This does not work for dotnet run of course.

My main questions are:

Is there a ForceConsoleColor command (perhaps an environment variable) for dotnet run
How does one troubleshoot why this is occurring?

Environment data
msbuild /version output: Microsoft (R) Build Engine version <IP_ADDRESS>362 for .NET Core
OS info:
Linux, x86, with dotnet core:
Version: 2.1.0-rc1
Commit:  eb9bc92051

Do I understand correctly that you also don't see colors when running your custom application that uses Console.ForegroundColor?

Correct! I run it via dotnet run though, which according to https://github.com/dotnet/cli/issues/9250#issuecomment-388116275 , it seems msbuild is somehow involved in this?

MSBuild is invoked to build  your code, then it's run. Since it sounds like neither the dotnet CLI itself nor MSBuild nor your application is working, this sounds like a problem with the common coloring library itself. I'll move the CLI bug (which has more info) to the appropriate repo for that.

Cool, thank you for that (and your response time was epic)! It is confusing to decouple the components involved. I will close this one.


MudDialog: LockScroll parameter in DialogOptions

LockScroll Parameter was missing for MudDialog. As seen on Material dialog, the dialog should be able to block the background.
To make it work on touch devices, mudScrollManager.js has been slightly modified.
Description
Resolves #7454

lockScroll in mudScrollManager.js modified to work on touch devices as well
added LockScroll parameter in DialogOptions for MudDialog

How Has This Been Tested?
Manually.
Example has been added in Docs.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[ ] I've added relevant tests.

@henon do you know if it's possible to unit test scrolling with bUnit? If yes, we definitely should ask it from author then.

Do I understand correctly that it also solves this issues https://github.com/MudBlazor/MudBlazor/issues/6108? Since its mentioned in your https://github.com/MudBlazor/MudBlazor/issues/7454 issue

Do I understand correctly that it also solves this issues #6108? Since its mentioned in your #7454 issue

Yes, it does.
I've tried to write a test for that but I had few problems with it... I might need help for that

In the last change I wanted to modify the ScrollManager js calls to not to be fired on each render.
All involved tests passed.

I did change the ScrollManager js calls from OnAfterRenderAsync because was calling the same multiple times.
They'll be called only if required when the value Visible change.
Is failing DebouncedTextFieldRerenderTest but I don't know why. In local it passes in 3s

I will reopen a new PR with cleaner commits.

The commits don't matter, in the end we'll squash everything anyway so you can as well reopen this.

Yeah, you can commit as much as you want. There is usually no reason to open new PR since you can do with your branch whatever you want: squash, edit commit history, force push etc.

I did change the ScrollManager js calls from OnAfterRenderAsync because was calling the same multiple times.

What you just did i.e. moving the js calls from OnAfterRenderAsync  to the [parameter] is very bad practice, later it will cause problems with pre-rendering on NET8. These JS calls should be in OnAfterRenderAsync because this event is happening when the browser is attached and JS calls are possible. If multiple calls are not desirable you can use firstTime argument / local variables to check that you have already called your methods.

I did change the ScrollManager js calls from OnAfterRenderAsync because was calling the same multiple times.

What you just did i.e. moving the js calls from OnAfterRenderAsync  to the [Parameter] is very bad practice, later it will cause problems with pre-rendering on NET8. These JS calls should be in OnAfterRenderAsync because this event is happening when the browser is attached and JS calls are possible. If multiple calls are not desirable you can use firstTime argument / local variables to check that you have already called your methods.

https://learn.microsoft.com/en-us/aspnet/core/blazor/javascript-interoperability/call-javascript-from-dotnet?view=aspnetcore-7.0#prerendering
for more information

Thank you guys!
I'll change my code and I'll update you!

Just noticed that most of the bugs were just because of the js functions.. for now I would go easy on that to not to risk to make things worse.
Thank you for all the reviews!
Now the only files that are changed are the JS and a new rule for css. It will fix most of the overlay scrolling problems.
So far, the only one that I've noticed not working as expected is mudDrawer. Does not block anything.

Do I need to change description/PR ?

Sure, what would be a better description of the change? So you think this ready to merge?

Sure, what would be a better description of the change?

Is basically a small enhancement on the javascript functions "lockScroll" and "unlockScroll".
Everything that was working before now is working also for touchscreen devices.
After this change, the dialog and everything that works with MudOverlay don't need to be modified to work properly.

So you think this ready to merge?

Yes, I think so.