scheduler never run

i'm using rq-scheduler and django-rq, i've reqistered a scheduled task like this:
from django_rq import get_scheduler
scheduler = get_scheduler('default')
scheduler.schedule(
        scheduled_time=datetime.datetime(dt.year, dt.month, dt.day, dt.hour, 15*(dt.minute // 15)), # Time for first execution, in UTC timezone
        func=my_func,                     # Function to be queued
        args=[],             # Arguments passed into function when executed
        kwargs={},         # Keyword arguments passed into function when executed
        interval=60 * 15,                   # Time before the function is called again, in seconds
        repeat=None                      # Repeat this number of times (None means repeat forever)
)

i started a worker by python manage.py rqworker high default low  at the same machine
but the scheduled job will never run, however simply django_rq.enqueue(my_func) run's without any problem
what's happening here, am i doing something wrong?

From docs:
scheduler.schedule(
scheduled_time=datetime.utcnow(), # Time for first execution, in UTC timezone
The scheduled_time variable is when you scheduled the task, not when you want it to run. And it must be in UTC time.

Like @johnseekins said, you should use UTC datetime to schedule the job.


Need help in training with hyper-parameters

I am interested in training this model which implements the below paper:
Conformer: Convolution-augmented Transformer for Speech Recognition
I believe the example 1 with conformer-lstm would train this model. Is my assumption right?
Also, according to paper there are 3 different models that vary according to the hyper-parameter and I am interested in the "s" version of the model having around 10M parameters. How can I select this version or provide the hyper-parameters?

Also, do you have any script for end-to-end inference (including language model)?

Hello.
Conformer paper's model is conformer-transducer actually.
You can train this model like below:
$ python ./openspeech_cli/hydra_train.py \
    dataset=librispeech \
    dataset.dataset_download=True \
    dataset.dataset_path=$DATASET_PATH \
    dataset.manifest_file_path=$MANIFEST_FILE_PATH \
    tokenizer=libri_subword \
    model=conformer_transducer \
    model. encoder_dim=144 \
    model. num_attention_heads=4 \
    num_encoder_layers=16 \
    num_decoder_layers=1 \
    audio=fbank \
    lr_scheduler=warmup_reduce_lr_on_plateau \
    trainer=gpu \
    criterion=transducer

You can see conformer-transducer configuration at [link]

Hello!I am also doing the same work as you.Could you have the interest to  communicate with me？

Hello!I am also doing the same work as you.Could you have the interest to communicate with me？

You are asking me?

Yes！I am also doing the work to implement the paper with the author's model.

Hello!I am also doing the same work as you.Could you have the interest to communicate with me？

You are asking me?

Hello!Did you meet the error as follows when you run the project?

@CLC2019 Thank you for letting me know. We will check this problem.
CC. @hasangchun

@CLC2019 Can you show me the script?

@CLC2019 Can you show me the script?

Thank you for your reply.I use the command line to run the project.The commands are showed as follows.

@sooftware And I use the pycharm to debug,finding the error which exists in warp-rnnt package as follows.

@hasangchun Can you check this problem?

@CLC2019 When I tested the same command with the latest Git, I was able to confirm that it worked without any errors. And your code doesn't seem to be up-to-date. Could you try again by cloning it to the latest Git?

@hasangchun Thank you for your reply and suggestion.But there is also a error as follows when I run your the latest project in my device.

@CLC2019   Can I know the your gpu status in the script?

@hasangchun My GPU is GeForce RTX 2080 Ti which is 10GB memory.

@CLC2019 I'm really sorry for replying late. We tested with a single gpu. Are you still getting the error?

@hasangchun Thank you for your reply.I think the error sources from the package--warp_rnnt. The error occurs on my server,but  on other server the warp_rnnt runs without errors. Maybe my environment doesn't match the warp_rnnt.Could you tell me your dependences of the warp_rnnt?Thanks a lot.

@hasangchun I also test with warp-rnnt==0.4.0.My CUDA version is 10.0,pytorch==1.6,and cudatoolkit==10.1.Could you give me your information?Thanks a lot.

@CLC2019 My CUDA version is 11.4, pytorch==1.9.0 and cudatoolkit==10.2.  Thanks a lot.

can only use transducer,  I used ctc and   joint ctc cross entorpy.


Unable to replicate SAM results

Hello,
Thank you for you work. I've tried to replace your model instead of using SAM in a visualisation pipeline that i've setup. The problem is that I'm unable to obtain as good results as with original SAM, even compared to the Vit-b version. On my test with AutoMask, your model is unable to separate objects as SAM can do. Is the model given in weights your trained model and if yes do you have any clue on what could be wrong ? (the preprocessing is OK as my code is working with original SAM)
Thank you in advance !

Hello,
Thank you for you work. I've tried to replace your model instead of using SAM in a visualisation pipeline that i've setup. The problem is that I'm unable to obtain as good results as with original SAM, even compared to the Vit-b version. On my test with AutoMask, your model is unable to separate objects as SAM can do. Is the model given in weights your trained model and if yes do you have any clue on what could be wrong ? (the preprocessing is OK as my code is working with original SAM)
Thank you in advance !

Thanks for your interest in our work. After our model with pretrained weights is publicly available, it’s the first time that we receive such an issue like this. We provide a demo on hugging face, can you at least get a reasonable results in this simple setup?

The demo is not working at all, each time I want to try to segment an image I get an error as return :

The demo is not working at all, each time I want to try to segment an image I get an error as return :

I just tested it and the demo indeed Suddenly crashed with a error. It worked normally before, I kinda know what might be wrong, but need to let my coworkers give it a check tomorrow. Now it’s 4:13am in Korea, thanks for your understanding and letting us know that the demo suddenly doesn’t work.

The demo is not working at all, each time I want to try to segment an image I get an error as return :

Thanks for notifying us of this issue which has been solved. Please check the demo again.

The demo is not working at all, each time I want to try to segment an image I get an error as return :

Another demo showing MobileSAM working in your local browser is available at https://mobilesam.glitch.me/ Please also give it a check. Hope it is helpful for you.


Fix bug in duplicate deletion due to usage of raw pointers

Fix bug in first statement in #99

So I ran into this problem a while back and I don't think this is the right approach.

Why are the mappers not returning unique pointers?  What else has a handle to these plan nodes to require them to be shared?  Only the root of the plan tree is shared between the cache and the executing thread.
We should be explicit when using unique pointers.  If a class takes ownership of an object, the constructor must accept an r-value reference to the object (std::unique_ptr &&r) so that the caller has to issue a std::move(r).  This makes it very clear that the caller is relinquishing ownership to the class.

That makes sense. The plan nodes are shared in rare cases now but they shouldn't. Actually one of these bugs is that our code share same schema in multiple plan nodes, which can be avoided by using unique_ptr. I will refactor to use unique_ptr.

I will finish the refactoring and create a new pull request.


Double gzip compression of files

Example: https://dist.ipfs.io/go-ipfs/v0.4.2/go-ipfs_v0.4.2_linux-amd64.tar.gz or https://ipfs.io/ipns/dist.ipfs.io/go-ipfs/v0.4.2/go-ipfs_v0.4.2_linux-amd64.tar.gz
Results in: https://gist.github.com/Kubuxu/7a5a8ed0454ee7113c543117dbfaf683

This is a an issue for distributions.git -- not sure what the issue is. dist's build-go.sh looks okay, and I using tar -xf or gzip -d for uncompression works fine.

And I don't get your double zcat -- after the first zcat, it's a tarball.

It happens only with browser.
Local gateways are not affected only the global ones.

I just got this with https://ipfs.io/ipns/dist.ipfs.io/fs-repo-migrations/v1.1.0/fs-repo-migrations_v1.1.0_linux-amd64.tar.gz

Disabled gzip compression in 803b9790c6e7a4426748d20fbcf7fb6411d6a683

Firefox has this bug with Content-Encoding: gzip, and .tar.gz files.
It won't gunzip anything, and leave you with a double-gzipped tarball.
Our new website is smaller than the old one,
so I think it's okay to remove gzip compression for now.


v2 logging enhancement

Context
following https://github.com/Police-Data-Accessibility-Project/data-sources-app/pull/48
We should update our logging infra to make sure we're ready to handle searches (and maybe other activity).
We don't want to track what named individual users are doing, and should actively not do that.
This is for keeping track of what people search for and whether we show them results. It will will help us focus our data source ID efforts and front end in general
Requirements

[ ] expand current logging direct-to-database, or formalize in elasticsearch or similar open-source logging package
[ ] log a summary of the search parameters + a summary of the results

whichever format lends itself to flexibility (these formats may change over time) and searchability (elastic)
query could be key-value pairs for properties
results could be a list of sources by ID

this will help us track how many times a source appears in searches, an interesting metric for popularity

consider response_time or something to indicate performance, how long it took to get results back from the API / if we failed

[ ] plan to store logs indefinitely, until we run out of space and need to expire it
[ ] only admins/staff/internal people need access. that said, we should plan to just host it somewhere with our auth so we can easily look
[ ] modify quick search logs (#279)

store the airtable_uid of data sources as results, not a full package
don't store updated_at
store a log, but not a results package, for quick searches of all and all, because they always return all results.

@josh-chamberlain Questions to ask in order to flesh this out further:

What data do we want to log? What searches are performed (e.g. how often a specific geographic location or record type is searched for)? What data sources are returned in a search? Other search parameters?
What do we intend to use the logged information for?
How long do we intend to retain the logged data? Indefinitely? Only for a specific period of time?
Who do we want to have access to the logged data? What roles/individuals?

a summary of the search parameters + a summary of the results
keeping track of what people search for and whether we show them results will help us focus our data source ID efforts and front end in general
indefinitely, until we run out of space and need to expire it
admins/staff/internal type people, unless random people want it (why, though) and it's safe to distribute

@josh-chamberlain With that in mind, the quick_search_query_log part will require three distinct components, executed in the following order:

Modify the quick_search_query_log table in the database
Modifying the existing script(s) to change its behavior
Modify all previous logs to enforce conformity with the new behavior

1 will involve modifying the dev_scripts file in the prod-to-dev migration repository, so that after importing from prod to dev,  the new schema is applied.
3 will involve a one-time script, and we don't currently have a procedure for doing such actions. We could just say "yolo" and modify the database with a disposable query, but we may want to make sure any database changes we make are traceable, and that may require us to think a bit more about how to deploy one time scripts. And this will almost certainly not be the last OTS we deploy.
3 also adds an additional wrinkle in that we probably will want to apply this after the v2 changes are complete -- otherwise we'll have to deploy it after every dev database refresh to ensure it persists.

Context
following #48
We should update our logging infra to make sure we're ready to handle searches (and maybe other activity).
We don't want to track what individual users are doing, and should actively not do that.
This is for keeping track of what people search for and whether we show them results. It will will help us focus our data source ID efforts and front end in general
Requirements

[ ]  expand current logging direct-to-database, or formalize in elasticsearch or similar open-source logging package

[ ]  log a summary of the search parameters + a summary of the results

whichever format lends itself to flexibility (these formats may change over time) and searchability (elastic)

@josh-chamberlain Elasticsearch would probably be the best option, but we should note the costs. Here is the pricing for the ELK stack, with the lowest option being $95 per month. Trying to circumvent that through setting up a droplet wouldn't work, as the hardware requirements for the droplet(s) required for this would match if not eclipse the cloud pricing (to say nothing of having to learn how to set up all of that).
That being said, for that price, we get a cloud-based solution with a lot of flexibility and built-in analytics. To use a technical term, that's pretty sweet. From what I know about our budget, I think we can handle this. Initially, it will probably feel like overkill, but it seems it will scale well.

@maxachis Traceability for the old logs is nice, but not the greatest priority. The logs are just for us, so as long as they're usable at the end and we are confident they're accurate, they can be retroactively time stamped.
So, with that in mind: how about just creating a new table for logs and getting it working, then migrating the quick search logs once that's figured out? Who knows what may change in the meantime. As it stands, we still need to deprecate quick search, or modify it, but if it keeps loggin' away it will be the same amount of work to migrate it later.
re: cloud deployment, that's probably best! It almost never makes sense to accept the maintenance overhead for something we haven't tried yet.

@josh-chamberlain Acknowledged! Will work on the design for a new search_logs table.

re: cloud deployment, that's probably best! It almost never makes sense to accept the maintenance overhead for something we haven't tried yet.

A little unclear if this means "We should look into Elastic" or "We shouldn't use Elastic without trying it". But in either case, Elastic does enable a 14 day trial where we could fiddle around with it and see how it looks.

Current Design: search_logs

id, PK
search_params, json array, NOT NULL
search_results, json array or "ALL", NOT NULL
result_count, int, NOT NULL
created_at, datetime, NOT NULL

@josh-chamberlain One thing also worth considering is implementing pagination for search results, both in the front-end display and back-end query.
If our search results are currently returning upwards of hundreds of results in a single query, that's going to have issues in a number of domains, especially as our number of data sources grow:

As mentioned, logging all the results returned becomes cumbersome, even when we're only logging the IDs
Retrieving the data itself will become more resource-intensive over time.
If the point of logging is to identify the interests of our users, then returning a large amount of results will tell us very little -- we'll probably learn more about user interests not by how many results a search returns, but by when the user stops searching -- i.e., indicating that they've found their desired results (or, more pessimistically, when they gave up searching).

With that in mind, we probably want to limit the number of results returned by a result -- at least initially. If we implement something like infinite scrolling, we can continually load additional data as the user looks for it. That would require adjustments to how we log data, but would help address the issues mentioned above.
Finally, If we want logging information, it probably also benefits us to know what data sources are clicked on, in addition to merely retrieved. That can give us even more precise ideas of people's interest. That will require some additional efforts and logging adjustments, but could be powerful.

@josh-chamberlain So if I'm understanding this correctly, The immediate agenda is the new search_logs table, with the design above. The two things outside the scope of v2 are ElasticSearch and Pagination.

@mbodeantor do you have an opinion about whether we should expand on the simple search logs table, or move forward with elastic as discussed?
I think either way pagination is separate—if someone gets results back, we should log all of them.

Our needs for analytics seem pretty straight forward, would love to see what can do without elasticsearch first.

@maxachis ↑

Duplicate of #334


Api spec changes

Fixes some things @I-Al-Istannen noticed while implementing the new API in the frontend.

There's going to be at least one more change regarding the /run endpoint. I probably shouldn't have requested code reviews this early.

At the moment, I can't think of any more changes.


Update RAC Link API

Closes https://github.com/orgs/adobe/projects/19/views/32?pane=issue&itemId=25877582
Depends on #4993
This updates the RAC Link API to just have href and other link props directly on it rather than cloning its child. With the RouterProvider added in #4993 this will support client side routers the same way as our other components, meaning there is no need to support wrapping a router Link component.

Oh good catch!


Bulk Download Gives Error

Downloading bulk data appears to be a pretty simple process, but gives an error. The initializing code is:
from edgar import *
<EMAIL_ADDRESS>download_edgar_data()

but returns an error:

Traceback (most recent call last):
File "/Users/sledge/Development/Python/edgartools/local_data/download.py", line 3, in
download_edgar_data()
~~~~~~~~~~~~~~~~~~~^^
File "/Users/sledge/Development/Python/edgartools/edgar/core.py", line 251, in download_edgar_data
download_submissions()
~~~~~~~~~~~~~~~~~~~~^^
File "/Users/sledge/Development/Python/edgartools/edgar/entities.py", line 945, in download_submissions
return asyncio.run(download_submissions_async())
~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File<EMAIL_ADDRESS>line 194, in run
return runner.run(main)
~~~~~~~~~~^^^^^^
File<EMAIL_ADDRESS>line 118, in run
return self._loop.run_until_complete(task)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
File<EMAIL_ADDRESS>line 721, in run_until_complete
return future.result()
~~~~~~~~~~~~~^^
File "/Users/sledge/Development/Python/edgartools/edgar/entities.py", line 938, in download_submissions_async
return await download_bulk_data("https://www.sec.gov/Archives/edgar/daily-index/bulkdata/submissions.zip")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/sledge/Development/Python/edgartools/edgar/httprequests.py", line 607, in download_bulk_data
await stream_file(data_url, as_text=as_text, path=download_path)
File "/Users/sledge/Development/Python/edgartools/edgar/httprequests.py", line 491, in stream_file
content = await response.text()
^^^^^^^^^^^^^
File "/Users/sledge/Development/Python/edgartools/.venv/lib/python3.13/site-packages/httpx/_models.py", line 578, in text
content = self.content
^^^^^^^^^^^^
File "/Users/sledge/Development/Python/edgartools/.venv/lib/python3.13/site-packages/httpx/_models.py", line 572, in content
raise ResponseNotRead()
httpx.ResponseNotRead: Attempted to access streaming response content, without having called read().

The fix has been released in 3.0.1. Please test.
Thanks again, much appreciated

@dgunning Yes, it's not working exactly as expected. Many thanks.
This Python package is extraordinary, btw. I am very impressed and appreciative.


How to log best metrics in Table[Q]

In Keras after training only best_epoch & best_loss can be seen in the Table. Is there any way to log the best result for other metrics as well like, best_accuracy? Unfortunately, WandbCallback doesn't show the best value for the metrics.

Hey @awsaf49 we're working on better documentation for a new feature that supports this.
After you call wandb.init you can call:
wandb.run.define_metric("accuracy", summary="best", goal="maximize")

Then a new column will be added to the table named accuracy.best.


Not caching the base layer?

Describe the bug
Hi! I am trying this plugin now and have a problem. I can see that it pushes layers to Github Package Registry because it says so. However when the build starts it seems it tries to read from a local /cache directory for the first layer instead of the cache repo. I see this in the log:
INFO[0001] Resolved base name ubuntu:bionic to ubuntu:bionic
--
2 | INFO[0001] Resolved base name ubuntu:bionic to ubuntu:bionic
3 | INFO[0001] Downloading base image ubuntu:bionic
4 | 2019/10/07 17:36:07 No matching credentials were found, falling back on anonymous
5 |
6 | INFO[0003] Error while retrieving image from cache: getting file info: stat /cache/sha256:1bbdea4846231d91cce6c7ff3907d26fca444fd6b7e3c282b90c7fe4251f9f86: no such file or directory
7 | INFO[0003] Downloading base image ubuntu:bionic

This means that every time it starts the build from scratch. Is there a way to avoid this and ensure that everything is cached? Thanks!
Steps to reproduce the issue:
Just set cache: true.
Expected behavior
I would expect the caching to cache the first layer as well, because otherwise the caching of following layers is very little useful.

Nevermind. I was missing the local "warmed" cache. I think I'll stick with the default Docker plugin for now, because I found a way to properly cache with it which works a lot better. I would like to use Kaniko but from searching it looks like it still has several issues (not just with caching). Thanks anyway :)

Hi @vitobotta, care to share your alternative solution?

Hi @servo1x I wrote about it here https://vitobotta.com/2019/10/09/ci-cd-with-drone-for-deployment-to-kubernetes-with-helm/


Byron protocol info cleanups

Deduce more PBFT parameters implicit in genesis, instead of having them passed as demo configuration.
There is likely a discussion to be had, where to place the new functions and types.

https://github.com/input-output-hk/cardano-node/pull/79 is now using this -- https://github.com/input-output-hk/ouroboros-network/pull/824/commits/bc9fd760c08b7d7ce0665ddb9233b2cabdb68564, specifically.

bors +r

Yes of course I did! :roll_eyes:

bors r+


Serin downloading lastest serene template fail

I want to test serenity by vscode on linux (debian)
I fellow your blog "Serene Install" (http://serenity.is/blog/2017/03/30/serene-install), but serin can't create the project, the error message:
(node:24269) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: ENOENT: no such file or directory, open '/home/recozo/.serene/SereneCore.Template.124.zip'

Update serin, e.g. "npm update -g serin"
Then it should work.


Artist Endpoint 'NoneType' error

Getting the following error when hitting the artist endpoint.
An unknown error occurred: 'NoneType' object has no attribute 'get'
Not seeing this error with the album endpoint. Any ideas what this could be?
UPDATE - Looks like this is caused by the BAD CREDENTIALS error we've seen in the past. Last year around this time we needed to update the desktop client version number. Has anyone found a workaround?

@entriphy - Any ideas what's going on?


Reload and Auto Reload no longer working.

As described in the title, the reload feature is not working for me. I have to switch between pages (All to Downloading, Downloading to All) for the view to refresh. This applies to all views.
Tried clearing cookies and cache, same issue.
Using Chrome 60 and 62, on TWC version: 1.4.0 (20171108)

With further testing, and without applying the fix given to be in the previous comment, I discovered that the auto refresh bug is only present when accessing the Transmission Web Control page using HTTPS (with a self signed certificate) instead of HTTP. I'm not sure if this behavior is expected, but I'm sure I've seen it work before over HTTPS, but I may be wrong.

AFAIK Transmission itself does not provide HTTPS connection and the Web is served only by HTTP. Are you using proxy to get it over HTTPS?

Yes, I'm using reverse proxy on my Synology DiskStation. That way I can set any HTTP-only services to be served over HTTPS, externally.

I got rid of my self-signed certificate, and got a valid certificate instead. I now have 1.5.0 beta installed, and auto refresh seems to be working well, now! I don't know if the issue was caused by the self-signed certificate, but that issue is now resolved for me. You may close it, if you want.


Remove dirname and pass through S3 return data

Removes the requirement for dirname and changes the filename property to key. This should resolve issue #9.
In addition, extend the payload passed back to multer and ultimately to the request file property with the data that is provided by the s3.upload call.

We should note that this is very much a breaking change and should be released under a new major version. I'm all for this change though, :+1:
Maybe add a test with the key function supplied though.

Updated requested changes including updated test, incremented major version.

Looks awesome!
I want to give some time to let @badunk look thru this though since the change is rather large. But :+1: from me.

Also, maybe we should consider baking in the proposed change about passing in an aws instance and dropping the dependency on aws-sdk. On the other hand, maybe that needs some more discussion...

If so I think that should be a separate pull request. How key is managed and the aws instance are really two separate things. They probably should have been broken out into separate issues.

Yes, it should absolutely be a separate issue, but the version number should probably not be included here though.
Actually, do you mind removing 7fe6354 (the version bump commit)? I'll do that with npm version major when we are releasing, that will create the correct tags as well. You can do that with git rebase -i master, just remove the line corresponding to that commit.

Sorry about that, done.

Looks good to me, not sure what I was thinking when I was calling it filename and dir - maybe I wanted to keep to the same multer options names.  I prefer the s3 semantics as well.
Thanks!

Let's merge, thanks for the awesome work @sabymike!

Would either of you mind publishing the newest version to npm?

I don't have access so that must be done by @badunk, I would like to get #13 merged first though. Get all the breaking changes now so we don't have to release 3.0.0 in a week again.
Maybe I'll get some time to look at it tonight (Swedish time)


Confused by PulseTimer terminology

From the docs:
uint16_t SerialWombatPulseTimer::readHighCounts()
Retreives the most recent Counts in the configured units for the most recent high pulse.

Returns
Counts in mS or uS depending on configuration.

I'm really confused by this.  You don't measure "counts" in time units.  You can measure them over a specific length of time but "counts in mS or uS"?  I don't get it.
Ideally, I'm trying to retrieve the number of debounced pulses over a period of time and have the count reset on read.    The DebouncedInput though seems geared for button presses and not say a reed switch.   Where the pulse rate is less than the sample rate, I can just check for any transitions since the last sample and count that as a 1.   For higher pulse rates, say 100Hz at about a 15% duty cycle, it's harder to figure out what's a legitimate pulse and what's noise caused by the switch.    If the pulse rate is variable, as it is in my case, it's hard to tell the DebouncedInput the length of a "good" pulse.
Any thoughts on this?

In the future, please ask support / implementation questions on the appropriate YouTube video (best case because that gives the most visibility to help other users) or send to<EMAIL_ADDRESS>rather than opening an issue against the library.
The Pulse Timer function is designed to measure how long a signal is high or low  The "High Counts" is simply a time delta in uS or mS of how much time elapsed between the last low to high transition and high to low transition.  It doesn't do any debouncing.
The Debounced input is going to be your best bet in general for removing noise, but you do need to be able to set a minimum amount of time, and you're right that 100Hz with a 15% duty cycle isn't practical at a 1kHz sample rate.
Is it practical to put an analog filter such as an RC filter on the switch output to eliminate noise, then use the pulse timer function on the filtered input?

In the future, please ask support / implementation questions on the appropriate YouTube video (best case because that gives the most visibility to help other users) or send to<EMAIL_ADDRESS>rather than opening an issue against the library.

Oops, sorry about that.  It wasn't obvious where to post issues.   You know you can disable issues under repository settings right? :)

The Pulse Timer function is designed to measure how long a signal is high or low The "High Counts" is simply a time delta in uS or mS of how much time elapsed between the last low to high transition and high to low transition. It doesn't do any debouncing.

Ah, now that makes sense.  It was the "Counts" that was throwing me off.

The Debounced input is going to be your best bet in general for removing noise, but you do need to be able to set a minimum amount of time, and you're right that 100Hz with a 15% duty cycle isn't practical at a 1kHz sample rate.

As always happens, I woke up in the middle of the night and thought...  "I know what the fastest pulse rate is going to be and it's probably much slower than the bounce noise.  I should be able to set the minimum time from that.".  I'll be testing with my logic analyzer today. :)

Is it practical to put an analog filter such as an RC filter on the switch output to eliminate noise, then use the pulse timer function on the filtered input?

That's certainly a possibility.
Thanks for your help and the product!  I've already used the 8 4Bs I had and will be ordering more shortly.


Type 'RegExpMatchArray' is not assignable to type 'boolean'

TypeScript Version:  2.2.1
Code
console.log( true && [/hi/].find(regex => "hello".match(regex)) );

Expected behavior:
false
Actual behavior:

error TS2345: Argument of type '(regex: RegExp) => RegExpMatchArray' is not assignable to parameter of type '(value: RegExp, index: number, obj: RegExp[]) => boolean'.
Type 'RegExpMatchArray' is not assignable to type 'boolean'.

The documentation says:

The find() method returns the value of the first element in the array that satisfies the provided testing function. Otherwise undefined is returned.

So I am expecting to take advantage of comparing for truthiness.
Whereas, this works as expected:
console.log( true && [1, 2, 3, 4].find(v => v === 2) );

"hello".match(regex) returns an array. Documentation from MDN.
Use:
console.log( true && [/hi/].find(regex => "hello".match(regex) !== null) );

Thanks, @j-oliveras. I don't think the problem is with String.match, because this works fine:
console.log( true && "hello".match(/hi/) );

I think it's something to do with Array.find.

In general when a function expects a truthiness value, we expect an explicit coercion of non-booleans. Otherwise it becomes to easy write something like [NaN, 3, 3].find(n => isFinite) - literally any JS value is a valid truthiness value.
We can make an exception if it's truly burdensome in some cases, but that's the general idea.

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.


WIP: Unnormalize weighted loss functions

Fix https://github.com/alan-turing-institute/MLJ.jl/issues/445
I am not familiar with the resampling API, appreciate if you can fix the tests.
After this is merged, I will prepare a second PR in an attempt to reorganise all these traits and measure implementations.

Notice I've also cleaned the synonym mav used as an alternative to mae. Synonyms aren't very helpful, and can be quite confusing actually. The term mae plays well with mse for mean square error. In a future PR, I will work on this naming to make sure that all the acronyms follow a minimum convention: mse, mae, rmse, rmae, etc.


Change name to SublimeLinter-contrib-modelsim

Change name to SublimeLinter-contrib-modelsim, or something similar.
Now that the plugin supports both vcom and vlog the name should reflect that in some way.

@jevogel, correct me if I am wrong, but you should be able to rename the repository (as it's owner).
Renaming a repository

Okay, I'll change the name of the repo and then update the package control repo here. We may have to remove the old package and install the new one.

BTW, the initial header in the Readme.md, line1 is still SublimeLinter-contrib-vcom (not -modelsim or whatever other name will be used for the package).

Fixed that, thanks.

Plugin is officially renamed in the package control repo. Closing.
https://github.com/SublimeLinter/package_control_channel/pull/72#event-1955254630


Fill field don't propagate to component

When I type a date in the input like 01/01/2010, the value don't propagate to component.
Somebody have the same problem?
Somebody can help me?
The input code follow:
<input class="mdl-textfieldcustom__input ng-valid ng-touched ng-dirty" date-format="DD/MM/YYYY" date-only="true" ng2-datetime-picker="" type="text" ng-reflect-model="" ng-reflect-date-format="DD/MM/YYYY" ng-reflect-date-only="true" ng-reflect-ng-model="" ng-reflect-id="de" id="de" ng-reflect-read-only="false">

@Krisa can you take a look at this issue?

I've noticed this problem too since quite some time. The input is cleared for some reasons when the input is blurred. Will look at it if I find the cause.


Bump Creek to 0.4.2-SNAPSHOT

Coverage: 97.321%. Remained the same when pulling b3bee052637da7eb5ad08cfae79aaed93c4d60f6 on big-andy-coates-patch-1 into de4a15813e9105116ce249c7ecd9c69ec51e8707 on main.


[FromBody]/ JSON binding doesn't use  Culture from RequestCultureProviders

Describe the bug
Culture derived from RequestCultureProviders is not being implemented in JSON Input binding.
The culture received is being used in query string, application/x-www-form-urlencoded binding but not working with application/json.
To Reproduce
https://github.com/ruchanb/AspNetCoreCultureModelBind
This is standard new project build with addition of
var supportedCultures = new System.Collections.Generic.List<CultureInfo>
            {
                new CultureInfo("en-US"),
                new CultureInfo("es-MX")
            };

            var requestLocalizationOptions = new RequestLocalizationOptions
            {
                SupportedCultures = supportedCultures,
                SupportedUICultures = supportedCultures,
            };
            //requestLocalizationOptions.DefaultRequestCulture = new RequestCulture(culture: "en-US", uiCulture: "en-US");
            requestLocalizationOptions.RequestCultureProviders.Insert(0, new JsonRequestCultureProvider());
app.UseRequestLocalization(requestLocalizationOptions);

provider
public class JsonRequestCultureProvider : RequestCultureProvider
    {
        public override Task<ProviderCultureResult> DetermineProviderCultureResult(HttpContext httpContext)
        {
            if (httpContext == null)
            {
                throw new ArgumentNullException(nameof(httpContext));
            }
            var header = httpContext.Request.Headers["culture"];
            var culture = header.Count == 0 ? "en-US" : header[0]; // Use the value defined in config files or the default value
            var uiCulture = culture;
            return Task.FromResult(new ProviderCultureResult(culture, uiCulture));
        }
}

Controller
 [Route("api/[controller]/[action]")]
    public class ValuesController : ControllerBase
    {
        [HttpGet]
        public IActionResult Date1(DateTime date)
        {
            return Ok(date);
        }
        [HttpPost]
        public IActionResult Date2(DateModel model)
        {
            return Ok(model);
        }
        [HttpPost]
        public IActionResult Date3([FromBody]DateModel model)
        {
            return Ok(model);
        }
}
public class DateModel
    {
        public DateTime Date { get; set; }
}

Here are some cURL commands to run when we start the application
curl http://localhost:20991/api/values/date1?date=5/15/2019
curl http://localhost:20991/api/values/date1?date=15/5/2019 -H "culture: es-MX"
curl http://localhost:20991/api/values/date2 -X POST -d "Date=5/15/2019"
curl http://localhost:20991/api/values/date2 -X POST -d "Date=15/5/2019" -H "culture: es-MX"
curl http://localhost:20991/api/values/date3 -X POST -d "{\"Date\":\"5\/15\/2019\"}" -H "Content-Type: application/json"

curl http://localhost:20991/api/values/date3 -X POST -d "{\"Date\":\"15\/5\/2019\"}" -H "culture: es-MX" -H "Content-Type: application/json"

Expected behavior
The expected behavior is to return date in ISO format, with 5 as Month, 15 as Day and 2019 as Year.
All the commands pass except the last one with application/json content-type and es-MX as culture. Here it takes the input as invalid.
Additional context
I am running the project on asp.net core 2.2 visual studio 2017. Issue is replicated also on 2.1 and 1.1 versions as I have checked.
I am aware this could, not be a bug, if so please provide information on how can I implement this behavior.
Related SO question: https://stackoverflow.com/questions/55951070/datetime-input-to-deserialize-from-users-culture-instead-of-servers-asp-net-c

So, I assume this behavior is intended?

Thanks for contacting us, @ruchanb.
@JamesNK can you please look into this? Thanks!

I can repo your issue. I think the problem here is JsonRequestCultureProvider is setting the thread culture, but the JsonTextReader isn't using it. JsonTextReader has a Culture property that is used to parse strings to values, such as a date string. It defaults to InvariantCulture.
https://www.newtonsoft.com/json/help/html/P_Newtonsoft_Json_JsonReader_Culture.htm
Parsing "15/5/2019" with invariant culture will fail.
Should JsonTextReader use the culture of the request? That would put it more in line with how model binding works.
@pranavkm @rynowak

Set it here along with the other properties: https://github.com/aspnet/AspNetCore/blob/master/src/Mvc/Mvc.NewtonsoftJson/src/NewtonsoftJsonInputFormatter.cs#L155-L157? That seems reasonable.

This seems like something we should offer as an option.
This is a totally reasonable thing for us to have, but this is the first time it's come up. I think changing the default has the potential to make more people sad than happy.

Changing the culture the reader uses will be be a breaking change.
For example, if you were previously assuming invariant culture when parsing number text to double/float then "1,000.23" on your server with a European culture will fail because the new culture expects "1.000,23".
Are we ok with this? Do we want a feature flag for this?

Are we ok with this? Do we want a feature flag for this?

The bar for changing a default behaviour is really high.  We should consider adding this as a non-default option.

I think the default should stay as it is, and MvcNewtonsoftJsonOptions can get public bool ReadJsonWithCurrentCulture { get; set; }. When true the CultureInfo.CurrentCulture onto the reader.
Thoughts?

Like 👍

Having this as an option feels the best method for me too.
Anyway guys, for now how do I implement this? Or I should be sending ISO dates?

Sending ISO date is a good idea and will work. It's a little bit more standard.
If you're interested in adding support for this setting (as described here) we'd accept a PR for that.

An ISO date is a good idea because it does not use the culture.


Support page rendering with non-2xx responses

Default behavior is unchanged.
Page may elect to proceed with ordinary rendering via setHaveDocument().
Response is still be set by handleRoute() return value.
Example:
handleRoute() {
    this.setHaveDocument(true);
    return { code: 404 };
}

getTitle() {
    return "404 Not Found";
}

getElements() {
    ...
}

I'm going to set up some tests for 500 pages, too.
Putting this out for feedback on the interface first.

Oops.  Accidentally deleted the branch, which closed the PR... uh...

Okay, I added basic tests for 500 pages with and without document render.
Tests uncovered some weird behavior WRT exceptions arising during handleRoute() which I'll patch with a separate PR.

Love the tests!
And I know I'm a little late on this, but I'm a little uncertain about the setHaveDocument(...) API. If it's something that's going to be very rare to use, it's probably OK, but I wonder if it makes more sense as something like: return {code: 500, haveDocument: true}? That wouldn't allow us to render a document in the case where there's a throw, but if someone really wanted that behavior, they could wrap their whole handleRoute in a promise or a try/catch?

I'm a little uncertain about the setHaveDocument(...) API.

Yeah, same.  Feels weird.

something like: return {code: 500, haveDocument: true}?

Yeah, thought about that initially, but I was worried about introducing another magic key in the handleRoute() response object.  I guess maybe that's just a matter of documentation?  I like the look of it more, and it ties the "... but I have a document" more closely to the "my response code is 500".

wouldn't allow us to render a document in the case where there's a throw

That's explicitly disallowed here, but no special handling would be necessary with a new key in the handleRoute() response object...
Okay, you've convinced me!  I'll push an update that moves the trigger into the response object.

@roblg: :+1:?

Ugh.  Just realized I pushed my changes to redfin/react-server last night instead of gigabo/react-server. :disappointed:

LGTM


Stremio Addon Config Page Not Loading

Addon Manifest URL
https://torrentio.strem.fun/qualityfilter=threed,nonthreed,cam/configure
Addon Description
The config URL does not work. https://torrentio.strem.fun/qualityfilter=threed,nonthreed,cam/configure
Language of Content
English (en-US)
Choose Labels

[ ] anime
[ ] asian drama
[ ] bollywood
[ ] cartoons
[ ] debrid support
[ ] http streams
[ ] live tv
[ ] metadata
[ ] misc
[ ] movies
[ ] music
[ ] nsfw
[ ] podcasts
[ ] radios
[ ] subtitles
[x] torrents
[ ] tv shows
[ ] video games

Why do you close it? That is the URL on the Strem.io addon to configure it. It does not load. Can't configure addon!


This project is incompatible with the pdm 2.8 lock format

Before loading the pdm.lock file it would be great to first check that the lock version is compatible with what rules_pycross supports. pdm 2.8 which was released last week drastically changes the format and the rules_pycross is now failing with slightly difficult to understand errors.

@betaboon have you run into this yet?

we haven't updated to pdm 2.8 yet.
the suggestion with checking the lock_version (which is contained in the lockfile) is very good.
I'll try to take a look in the coming days. I'm quite busy atm, thus i cannot give any time guarantees tho.
i will report back.

i just took a quick look:

the lockfile format has changed a lot and doesn't contain the package-urls by default anymore. the inclusion of the package-urls can be enforced with --static-urls now tho.
some pdm-internals that i was using have changed/gone missing. so i will have to investigate if there is a different approach that i can take to bring back the functionality.

Thanks for looking! I suppose for now we can add a version check and output a more helpful error message.

the PR #40 should fix this. @aignas can you give it a try ?
fyi:
when creating the lockfile you need to run pdm lock --static-urls to contain the urls in the lockfile.
this gets saved in the lockfile and will not be required afterwards.

@aignas did you get a chance to check if the PR resolves the issue for you ?


Formatting does not load previous selected date

Hi there!
As you can see in the Formatting with dateFormat in the sample page, which apply flatpickr('#dateFormat', { dateFormat: 'Y-m-d'});, will not focus the previous selected date when picking a date, closing the popup, and reopening it.
Here is the popup after closing and opening it again:

Another problem is pre-loading the date field with, for example, 11/01/2016.
With d/m/Y as dateFormat, 11 represents the day, and 01 the month. But when opening the popup, it will load November as month, and 01 as day. Looks like it is parsing directly from the input, ignoring the dateFormat option.

Another problem is pre-loading the date field with, for example, 11/01/2016.
With d/m/Y as dateFormat, 11 represents the day, and 01 the month. But when opening the popup, it will load November as month, and 01 as day. Looks like it is parsing directly from the input, ignoring the dateFormat option.

I could reproduce the bug. will be fixed over the weekend.
thank you

The selection bug is fixed now.
And you're right, dateFormat right now is just used for formatting a picked date from calendar.
I'll see if its viable to perhaps add a dateInputFormat option.

Hi there!
It still does not work for other formats, like 'd/m/Y'.
After investigating the problem, I saw that the selected date object is lost after the popup is closed and reopened, due the redraw() destroying everything and rebooting it again.
I made it work by initializing flatpickr with the self.selectedDateObj, like:
self.redraw = function(){
    flatpickr(self.element, self.config, self.selectedDateObj);
}

var flatpickr = function (selector, config, last_date) {
    ...
    element._flatpickr = new flatpickr.init(element, config, last_date);
    ...
}

init = function () {
    ...
    if ( self.element.value || (!self.element.value && self.config.defaultDate ) ){
        self.selectedDateObj = last_date||self.config.defaultDate;
    }
    ...
}

Of course this is just a workaround solution. I think you can get a better solution to this, maybe storing the last date in self.config itself? Since js lack support to create date from string using a format, it would be a lot easier to flatpickr to just store the selected date object itself.

Also, this new update breaks if the input is pre-loaded with a formated date, like this print:

Reverting back to 1.3 solves this problem. Another reason to store the selected date as object, and not as string to parse it ;)

Thanks for the hint about redraw :thumbsup:
It was indeed parsing again from a value with a format that javascript's new Date() might not accept, hence the undefined bug.
Everything should be working correctly now.

Hi @chmln!
Now selecting a date, closing the popup and reopening it is working flawless! :+1:
But the problem with pre-loaded input date still occurs.
For example, if the input has a pre-defined value of 02/01/2015 (date format d/m/Y), flatpickr will try to guess the current date, and it will miss, setting the selected date to 02 as month and 01 as day.
To solve this, I tried to set the defaultDate option, but flatpickr priorizes the input value instead the defaultDate.
Would be possible to, when defaultDate is set and input has value and selectedDate is not yet defined, then set selectedDate based on defaultDate option, since I can set the defaultDate option with a format that js can understand?
This should solve the issue.
Best regards,
Rafael.

When preloading it does make more sense to give priority to defaultDate
as opposed to the value which might be unparseable like in your case.
I've updated an example on the website to reflect your case.
Please verify everything working correctly now.
And thanks for the insight :+1:

Working like a charm :smile:
Thank you very much!


Feature/#267 html generation 2

Added functionality to generate and download html protocols of finalized minutes.

Thank you very much for this cool feature. ;-)
Will merge in.


Using Ruff on an Online Python Playground, CompileError: WebAssembly.instantiate(): expected magic word 00 61 73 6d, found 3c 21 64 6f @+0

I have a not-yet-announced Python Playground.
Within it, I plan to have the [Format] button formatting the main.py codes shown on the Left Panel.
vite.config.js
// `ruffFormatPluginVite` attempts to copy the both files into the browser's assets.
const ruffFormatPluginVite = {
  name: "vite-plugin-ruff",
  generateBundle: async () => {
    const ruffSourceDir = "node_modules/@astral-sh/ruff-wasm-web";
    const assetsDir = "dist/assets";
    const files = [
      "ruff_wasm.js",
      "ruff_wasm_bg.wasm",
    ];
    for (const file of files) {
      await copyFile(join(ruffSourceDir, file), join(assetsDir, file));
    }
  },
}

export default defineConfig({
  optimizeDeps: { exclude: ["@astral-sh"] },
  plugins: [vue(), WindiCSS(), ruffFormatPluginVite], // pyodidePluginVite],
  define: {
    __API_URL__: JSON.stringify(apiURL),
    __PY_VER__: JSON.stringify(pyVer),
    __COMMIT__: JSON.stringify(commit),
  },
});

ruff.format.js
import init, { Workspace } from "@astral-sh/ruff-wasm-web";

await init();

export const workspace = new Workspace({
    'line-length': 88,
    'indent-width': 4,
    format: {
        'indent-style': 'space',
        'quote-style': 'double',
    },
    lint: {
        select: [
            'E4',
            'E7',
            'E9',
            'F'
        ],
    },
});

Here I simply follow the example here and export the workspace.
Run.vue
function formatCode() {
  // const errorMsg = "\`Format\` functionality is not yet implemented!";
  // toast.error(errorMsg);
  console.log("Format action triggered");
  store.files["main.py"] = workspace.format(store.files["main.py"])
  const formattedMessage = `Codes have been formatted!`;
  toast.success(formattedMessage);
}

Here in Run.vue, store.files["main.py"] is the Python source codes and it is formatted by workspace and assigned back to store.files["main.py"].
This is the error I got when executing the npm run dev.
ruff.format.js:3 `WebAssembly.instantiateStreaming` failed because your server does not serve wasm with `application/wasm` MIME type. Falling back to `WebAssembly.instantiate` which is slower. Original error:
 TypeError: Failed to execute 'compile' on 'WebAssembly': Incorrect response MIME type. Expected 'application/wasm'.
__wbg_load @ @astral-sh_ruff-wasm-web.js?v=99fcae90:432
await in __wbg_load
__wbg_init @ @astral-sh_ruff-wasm-web.js?v=99fcae90:768
await in __wbg_init
(anonymous) @ ruff.format.js:3
Show 2 more frames
Show lessUnderstand this warning
:5173/#ewB9AA==:1 Uncaught CompileError: WebAssembly.instantiate(): expected magic word 00 61 73 6d, found 3c 21 64 6f @+0

Any idea what's going on?
Thank you.

This looks neat!
Hmm, not sure. I would try to fix

TypeError: Failed to execute 'compile' on 'WebAssembly': Incorrect response MIME type. Expected 'application/wasm'.

first by double checking what mime type your server returns for the WASM file. I somewhat suspect that the WASM file might be missing and that your server returns a HTML error page.

Thank you for your prompt reply.
// `ruffFormatPluginVite` attempts to copy the both files into the browser's assets.
const ruffFormatPluginVite = {
  name: "vite-plugin-ruff",
  generateBundle: async () => {
    const ruffSourceDir = "node_modules/@astral-sh/ruff-wasm-web";
    const assetsDir = "dist/assets";
    const files = [
      "ruff_wasm.js",
      "ruff_wasm_bg.wasm",
    ];
    for (const file of files) {
      await copyFile(join(ruffSourceDir, file), join(assetsDir, file));
    }
  },
}

export default defineConfig({
  optimizeDeps: { exclude: ["@astral-sh"] },
  plugins: [vue(), WindiCSS(), ruffFormatPluginVite], // pyodidePluginVite],
  define: {
    __API_URL__: JSON.stringify(apiURL),
    __PY_VER__: JSON.stringify(pyVer),
    __COMMIT__: JSON.stringify(commit),
  },
});

I actually copied this from pyodide and that is how they taught me on how to get the .wasm binary and .js shim to be copied into dist/assets and be made available at runtime within the console.
When I investigate the Sources tab of Chrome, I do realize that they are actually not copied over.
Perhaps, is there a working example, aside from the Ruff playground, to illustrate how one can deploy the Ruff wasm on the frontend?
Thank you.

Perhaps, is there a working example, aside from the Ruff playground, to illustrate how one can deploy the Ruff wasm on the frontend?

Not that I'm aware of. I would expect vite to automatically pick up the dependencies when importing the wasm package.

Yeah I saw the wasm-build command actually calls wasm-pack and dump the built artefacts directly into src. I guess I shall try the same later. Will update here on how it goes.

Let me know if you're still facing any issues. I close this for now.


Pin 31 and deepsleep on nRF51822 mKIT

Two changes were made for this pull request. Both lines were already in the original code but commented out.

Enable the use of pin 31.
Calling deepsleep() will power off the microcontroller.

There's a similar discussion about the pin p31, you can find out here more https://github.com/ARMmbed/mbed-hal-nrf51822-mcu/issues/19 . mKit does not have p31 pin , it's package QF, where it's missing.
I am closing this PR, please if you test further the sleep power off, send PR.


Rendering

What library do you recommend for rendering natal chart using data generated by this package, for React?

I don't know of any React-specific libraries for rendering the chart - I only came across a couple of libraries which do rendering-only work like this one: https://github.com/Kibo/AstroChart and I didn't find any react-specific ones. If you do, I'd love to link to it in the README!

Thanks I have been using AstroChart. Its quite good.


Generate alternate .Query files if error-spec specified

PIVOTAL: https://www.pivotaltracker.com/story/show/156579632, https://www.pivotaltracker.com/story/show/156767378
DEPENDENCIES: None
Used to account for errors on Http 200 response (according to official graphql specs).

:shipit: :dragon:


New created controllers are not picked up while LSP is running

Hi,
Not sure if this is a known issue or this is due to our project setup.
If I create a new controller, as the LSP is running, it is not getting picked up? When I restart the LSP they do get picked up.

Thanks for opening the issue!
I'm pretty sure this worked at one point, but it could be that I somehow broke it. In which folder are you creating the new controllers? Maybe the client is not watching the right folders for picking up the changes.

The behaviour described by Gert-JanPeeters happens as well on my machine.

The behaviour described by Gert-JanPeeters happens as well on my machine.

Hey @divagueame, thanks for the report!
Are you using it in NeoVim or VS Code?

Neovim  v0.9.5

Oh interesting, seems like this is specific to NeoVim then. Let me try to reproduce it in NeoVim.

I think the problem is that the NeoVim setting doesn't register the file events

I'm seeing this issue too (using LazyVim / Neovim 0.9.5)
Changes to controller actions are not being picked up whilst the LSP is running either.

Looks like this also happens on VS Code Insiders (Version: 1.93.0-insider (Universal))

I need to revisit this soon, seems like there's something off somewhere along the line


Drag and Drop delay

I want to drag react component when I holding click or touch on it for some time. How can I do that?

This isn't something that can be configured.  What you'll want to do modify react-dnd-html5-backend to suit your needs.


Update azure.yaml template name

cc: @pamelafox @kjaymiller

Looks good to me! However, @kjaymiller is the one with merge permissions.


Facilitate Navigation from Cookie to Corresponding Network Request

Feature Request
Description:
This feature aims to enhance the user experience by providing a seamless way to navigate from a cookie listed in the PSAT Extension to its corresponding network request in the network panel. The process would be facilitated by generating a query string from the selected cookie and its domain, which can then be copied to the clipboard for easy pasting in the Network tab.
Motivation:
The primary motivation for this feature is to streamline the workflow for users who need to track how specific cookies are used in the network requests. By simplifying this process, users can more efficiently analyze and debug web applications, leading to faster debugging of cookies in the Network tab of Chrome Dev Tools.
User Story:
As a web engineer, I want to quickly navigate from a selected cookie in the Cookie table of PSAT Extension tab to its corresponding network request, so that I can efficiently analyze how the cookie is being used in the network activity of my web application.
Acceptance Criteria:

[x] The feature should allow users to right-click on a cookie in the Cookie table of PSAT Extension and select an option to copy the query string based on the selected cookie.
[x] A query string based on the selected cookie should be automatically generated and copied to the clipboard.
[x] Users should be able to paste the copied query string in the Network tab to filter and identify the relevant network request.

Additional Information:
Example query string:
cookie-domain:accounts.google.com cookie-name:__Host-1PLSID

@amovar18 The added functionality looks good to me. but I have some minor UI feedbacks to share which can be addressed later.

[ ] The Copy network filter string. is not aligned in the centre.

[ ] Also, I feel there is slightly different color in bg wrt Application Tab.

Application Tab
PSAT

Also, I feel there is slightly different color in bg wrt Application Tab

Thanks @kjnanda for pointing this out let's make an enhancement issue for this the context menu used everywhere else is styled the same.

Released as a part of v0.4.0, closing this issue.


⚠ Bofrost.be has degraded performance

In 03a81d6, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1062 ms

Resolved: Bofrost.be performance has improved in db8c217 after 37 minutes.


Add output_type_id_datatype property to v3.0.1. Resolves #87

This PR introduces an optional output_type_id_datatype property to enable hub administrators to configure and communicate the output_type_id column data type at a hub level. This will allow hubs to override default behaviour of automatically determinining the simplest data type that can accomodate output type IDs across all output types when creating hub schema.
The setting is also useful for administrators to future proof the output_type_id column from potential issues arising by changes in data type, introduced by new output types after submissions have begun, by setting output_type_id_datatype to the simplest data type from the start, i.e. character (#87).
For more info on related work see https://github.com/orgs/hubverse-org/projects/3/views/12

Not a review because I'm still swimming in the documentation sea, but here's a reference of the diff as of 0a93c9e
diff -u --color=always v3.0.0/tasks-schema.json v3.0.1/tasks-schema.json

--- v3.0.0/tasks-schema.json	2024-07-22 08:47:15.851365031 -0700
+++ v3.0.1/tasks-schema.json	2024-07-22 08:47:36.079408585 -0700
@@ -1,6 +1,6 @@
 {
     "$schema": "https://json-schema.org/draft/2020-12/schema",
-    "$id": "https://raw.githubusercontent.com/hubverse-org/schemas/main/v3.0.0/tasks-schema.json",
+    "$id": "https://raw.githubusercontent.com/hubverse-org/schemas/main/v3.0.1/tasks-schema.json",
     "title": "Schema for Modeling Hub model task definitions",
     "description": "This is the schema of the tasks.json configuration file that defines the tasks within a modeling hub.",
     "type": "object",
@@ -1439,6 +1439,18 @@
                 ],
                 "additionalProperties": true
             }
+        },
+        "output_type_id_datatype": {
+            "description": "The hub level data type of the output_type_id column.",
+            "examples": ["character"],
+            "type": "string",
+            "enum": [
+                "character",
+                "double",
+                "integer",
+                "logical",
+                "Date"
+            ]
         }
     },
     "required": [

Thanks for the tip @zkamvar ! I reckon we should put that in the README as it's especially useful for these PRs

Also I should mention that while the feature to override the column data type always existed in functions to create the schema it had not been exposed in the validations. This issue is the impetus for setting this work in action https://github.com/hubverse-org/hubValidations/issues/94

There's a link to additional related issues to this change in the PR description above and a lot more detail in the issue.

Thanks for the quick reply and sorry I was not clear, I got a little bit lost in all the links, that's why I was asking too. But my understanding is that it will be used in the function to create the schema, validate the schema (of course), validate the PR and submission and validate the model output, with that new optional parameter as default. Is that correct?
I need to maybe think a little bit more, but I am little confused by this behavior of a optional parameter being the default of other function.

Also, this must be a hub level setting because all files, especially parquet must share the same schema to be opened as a dataset at a hub level.

That was my understanding for the hub level.

Ah got it!
If the parameter is not set, the rest of the functionality defaults to the previous default of autodetection. So no change to prior functionality if it's missing.
Hopefully all this will be clearer in the downstream PRs in the related packages.

Thanks @nickreich & @LucieContamin for comments!
I've gone ahead and made the following changes (diff below):

Added more detail to the property description. Note as well that I'm planning a whole section in hubDocs about the topic: https://github.com/hubverse-org/hubDocs/issues/143
I though about the property being optional too. We definitely want this to be optional because we don't want this change to be a breaking one (which it would be if we made it required). What I have done, though, is added an "auto" option. This is equivalent in behaviour to not including the property at all (i.e. when the property is missing, all downstream functionality defaults to "auto"), but it means we have a way to encode this default behaviour via a property value, which feels right to be possible. It also means we can include the property, set to the default "auto" in our hubTemplate, so new admins can be aware of it.
I also added a note in the README with code snippets for producing file diffs between versions for easier reviewing.

--- v3.0.0/tasks-schema.json    2024-07-22 17:59:17
+++ v3.0.1/tasks-schema.json    2024-07-23 09:58:23
@@ -1,6 +1,6 @@
 {
     "$schema": "https://json-schema.org/draft/2020-12/schema",
-    "$id": "https://raw.githubusercontent.com/hubverse-org/schemas/main/v3.0.0/tasks-schema.json",
+    "$id": "https://raw.githubusercontent.com/hubverse-org/schemas/main/v3.0.1/tasks-schema.json",
     "title": "Schema for Modeling Hub model task definitions",
     "description": "This is the schema of the tasks.json configuration file that defines the tasks within a modeling hub.",
     "type": "object",
@@ -1439,6 +1439,20 @@
                 ],
                 "additionalProperties": true
             }
+        },
+        "output_type_id_datatype": {
+            "description": "The hub level data type of the output_type_id column. This data type must be shared across all files in the hub and be able to represent all output type ID values across all hub output types and rounds. If not provided, hub defaults to autodetecting the simplest hub level data type.",
+            "default": "auto",
+            "examples": ["character"],
+            "type": "string",
+            "enum": [
+                "auto",
+                "character",
+                "double",
+                "integer",
+                "logical",
+                "Date"
+            ]
         }
     },
     "required": [

Here's also a related PR in hubTemplate introducing the property but setting it to the previous "auto" behaviour by default: https://github.com/hubverse-org/hubTemplate/pull/17

Also, in case you are interested in downstream implementation details @LucieContamin, I've now opened the first related PR in hubData https://github.com/hubverse-org/hubData/pull/49


[BEAM-12851] Map output table names

This change forces output schema (both name and type) to match the expected value.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @ibzib

Looks like this needs the revert in #15468 first.

run sql postcommit

@ibzib this is passing now.


Problem in method DgcGatewayDownloadConnector::updateIfRequired()

Hello,
I have found the following problem. The line (DgcGatewayDownloadConnector.java, method updateIfRequired, line 105)
trustedCscaCertificateMap = trustedCscaCertificates.stream()
    .collect(Collectors.toMap((ca) -> ca.getSubject().toString(), (ca) -> ca));

throws exception java.lang.IllegalStateException: Duplicate key if trustedCscaCertificates  contains two (or more) certificates
with same subject.
I am using development gateway. The problematic certificates returned by the gateway are

First

Subject: C=BB,ST=NRW,L=Test,O=MinistryOfTest,OU=DGCOperations,CN=CSCA_DGC_DE_01
SN:<PHONE_NUMBER>66195600131091134914499111884383337176

Second

Subject: C=BB,ST=NRW,L=Test,O=MinistryOfTest,OU=DGCOperations,CN=CSCA_DGC_DE_01
SN:<PHONE_NUMBER>31557717335939590388500291603260377746

Problem should be fixed with #67


New rule proposal: XMLDoc documentation of a method needs to list all not-caught exceptions thrown in that exact method

We are interested in knowing whether it's possible to create a new rule that makes sure that every uncaught exception thrown in a method has to be documented in the XML documentation of the method?

Noncompliant:
public void X(){
    throw new Exception();
}

Compliant:
/// <exception cref="Exception">Some text</exception>
public void X(){
    throw new Exception();
}

Compliant:
public void X(){
    try{
        throw new Exception();
    } catch(Exception e){

    }
}

Compliant (X does not need to document an exception that is thrown in a called method):
public void X(){
    Y();
}

/// <exception cref="Exception">Some text</exception>
public void Y(){
    throw new Exception();
}

Is it hypothetically possible to implement this?
One possible problem could be the catch (Exception e) when (expr) syntax which makes is potentially impossible to find out during compile time whether an exception will always be caught or not.

I'm hesitant to implement this rule based on the outcome of Redgate Exception Hunter. This commercial product attempted to solve this problem for code, but it was so problematic that the company discontinued the product altogether.

Duplicate of #1950


[IOTDB-1632] fill only if the value is missing

For detailed descriptions: https://issues.apache.org/jira/browse/IOTDB-1632

Coverage decreased (-0.004%) to 67.373% when pulling 33d70a662747eea840bbd4d4f4d9e8a03051cbe0 on cornmonster:fix_fill_executor_fills_non_null_values into 3333f3b2a6a5035b7f42a33dd23b3e841b0768b1 on apache:master.

@HTHou Hi, could u please have a look at this PR? Thanks for your time.

I noticed the E2E test failed. Here is the failed test case and it seems to be an unrelated error
2021-09-09T10:14:45.8632217Z [ERROR] Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 730.007 s <<< FAILURE! - in org.apache.iotdb.db.sql.nodes5.FiveNodeCluster2IT
2021-09-09T10:14:45.8638541Z [ERROR] showTimeseriesRowsTest(org.apache.iotdb.db.sql.nodes5.FiveNodeCluster2IT)  Time elapsed: 522.68 s  <<< FAILURE!
2021-09-09T10:14:45.8640357Z java.lang.AssertionError: expected:<3000> but was:<0>

The Sonar-Coveralls test also failed because of an unrelated unit test case:
Error:    IoTDBLoadExternalTsfileIT.loadUnsequenceTsfileTest:448 » IoTDBSQL 411: Cannot ...

I noticed the E2E test failed. Here is the failed test case and it seems to be an unrelated error
2021-09-09T10:14:45.8632217Z [ERROR] Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 730.007 s <<< FAILURE! - in org.apache.iotdb.db.sql.nodes5.FiveNodeCluster2IT
2021-09-09T10:14:45.8638541Z [ERROR] showTimeseriesRowsTest(org.apache.iotdb.db.sql.nodes5.FiveNodeCluster2IT)  Time elapsed: 522.68 s  <<< FAILURE!
2021-09-09T10:14:45.8640357Z java.lang.AssertionError: expected:<3000> but was:<0>

I guess it may be caused by some random reasons. Could you please retry the CI test? Thanks!
@HTHou

Sure

The Sonar-Coveralls test also failed because of an unrelated unit test case:
Error:    IoTDBLoadExternalTsfileIT.loadUnsequenceTsfileTest:448 » IoTDBSQL 411: Cannot ...

It is a bug we are fixing. It doesn’t matter.

I have checked the latest CI test results. There is a new failure Main Win / win (16, server):
java.lang.AssertionError
	at org.apache.iotdb.db.integration.IoTDBContinuousQueryIT.checkCQExecutionResult(IoTDBContinuousQueryIT.java:345)
	at org.apache.iotdb.db.integration.IoTDBContinuousQueryIT.testContinuousQueryResult1(IoTDBContinuousQueryIT.java:245)

I checked the source code, the IT IoTDBContinuousQueryIT#testContinuousQueryResult1 seems like another unrelated test case.
@Alima777 @neuyilan Could u please help review this PR? Thanks for your time!


Using knex with dotenv

Hi,
is there a simple way to use Knex and the migration/seed CLI with dotenv?

In case anyone comes here looking for a solution, here's what I do (and it works like charm!)
`require('dotenv').config({path: 'path_to_env_file'});
module.exports = {
client: 'pg',
connection: {
host: process.env.DB_HOST,
user: process.env.DB_USER,
password: process.env.DB_PASS,
database: process.env.DB_NAME
}
};
`

@mbavio Thanks that fixed it the issue. The problem for me specifically was that I have my knexfile.js is a subdirectory of my project, not at the root directory. So therefore it couldn't find my .env without passing the path to it. Thanks again!

Hi, everyone It's possibile to run knex in silent mode, so without asking me via prompt the environment , I'm deploying in a different machine via ssh

With Babel (ES6) you can do:
import dotenv from 'dotenv';
dotenv.config();

export default require('knex')({
  debug: true,
  client: 'mysql',
  connection: {
    host: process.env.DB_HOST,
    user: process.env.DB_USER,
    password: process.env.DB_PW,
    database: process.env.DB,
    charset: 'utf8',
  }
});

I had the same problem when I tried to run migrations as npm scripts. It worked when I changed the script to node -r dotenv/config ./node_modules/knex/bin/cli.js migrate:latest.

You are f*cking genius

You may find this helpful:
env $(cat .env) knex migrate:latest
Please note that in this case Knex is expected to be installed globally

@RaimoJohanson A more proper way to do that would be
env $(cat .env) ./node_modules/.bin/knex migrate:latest
or if you are using an NPM Script:
env $(cat .env) knex migrate:latest

@Jakobud I read up about the .bin directory being used by Node internally in npm scripts - thanks for that!

@Jakobud this wouldn't work on Windows

With multiple .env files it might be a solution to use the DOTENV_CONFIG_PATH environment variable. In my package.json I created a test script that picks up .env, and a test:knex that works with .env.test:
"scripts: {
  "knex": "babel-node -r dotenv/config node_modules/.bin/knex",
  "test:knex": "DOTENV_CONFIG_PATH=.env.test npm run knex"
}

I have this setup, was struggling with same situation also, which is working for me now:
    "start": "nodemon -r dotenv/config -r module-alias/register index.ts",

{path: 'path_to_env_file'}

@marbiano  Thank you, you save my day !

@RaimoJohanson A more proper way to do that would be
env $(cat .env) ./node_modules/.bin/knex migrate:latest
or if you are using an NPM Script:
env $(cat .env) knex migrate:latest (the .bin directory is automatically resolved when using npm scripts)

I get an error when I try to read the .env file with this script.
env: #: No such file or directory, I am sure I am setting the env file in the correct path.

If I call "knex migrate:up --env test" the process.env.NODE_ENV within knexfile shows undefined. Is this expected?

I had the same problem when I tried to run migrations as npm scripts. It worked when I changed the script to node -r dotenv/config ./node_modules/knex/bin/cli.js migrate:latest.

Still working in 2024 - thanks!

It helps me to replace export const to export default config in typescript.


Fix binary Scala version detection for Scala 3

Hi thanks for this useful plugin. I note that the issue with Scala 3 has been fixed but there is no release yet with this change. Any chance this can be released soon? Many thanks.

Sorry! Done! 0.2.4 is on its way.

Thank you 🙌

Hi, has 0.2.4 been released yet? Thanks.

Opened an issue here: https://github.com/sbt/sbt-ci-release/issues/237. I suspect it's not an issue on their end but afaict nothing has changed about how this library is deployed.

Opened an issue with Sonatype. Will report back when I hear from them.

Many thanks for taking the time to look into this, much appreciated.

Heard back from someone at Sonatype:

I'm keeping an eye on Maven and will update this ticket when the newest version is released (or not)

0.2.4 has landed! I really appreciate everyone's cooperation and patience. Let me know if there are any further issues.

Thank you so much and for taking the time to follow this up. I and my colleagues really appreciate it.


Update stable version in repo from 1.2.0 to 1.2.2

Think about update stable version to 1.2.2
Version: stable=1.2.0 (213 days old) => latest=1.2.2 (15 days old)
Installs: stable=163 (70.87%), latest=41 (17.83%), total=230
Click to use developer portal
Click to edit
Do not close this issue manually as a new issue will be created if condition for update still exists.
Please drop a comment if any reason exists which blocks updating to version 1.2.2 at this time.
Note: This is an automatically generated message and not personally authored by bluefox!
@mcm1957 for evidence

This issue seems to be outdated.
This issue suggests to update the stable version of this adapter to 1.2.2 but the current stable version is already 1.2.2.
So this issue should be closed.
@mcm1957 for evidence


New version: Badlion.BadlionClient version 3.12.2

- [X] Have you signed the Contributor License Agreement?

[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.4 schema?


Fix bug in speed factor for word alignment with speed perturbation

Codecov Report

Merging #187 (1a913b7) into master (2e31982) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
- Coverage   37.47%   37.39%   -0.08%
==========================================
  Files          86       86
  Lines       10061    10059       -2
  Branches     2118     2118
==========================================
- Hits         3770     3762       -8
- Misses       6093     6095       +2
- Partials      198      202       +4

Impacted Files
Coverage Δ

neural_sp/datasets/alignment.py
0.00% <0.00%> (ø)

neural_sp/datasets/asr.py
0.00% <0.00%> (ø)

neural_sp/models/modules/cif.py
87.34% <0.00%> (-1.27%)
:arrow_down:

...eural_sp/models/seq2seq/decoders/rnn_transducer.py
73.95% <0.00%> (-0.97%)
:arrow_down:

neural_sp/models/seq2seq/decoders/transformer.py
62.39% <0.00%> (-0.62%)
:arrow_down:

neural_sp/models/seq2seq/decoders/las.py
50.85% <0.00%> (-0.12%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e31982...1a913b7. Read the comment docs.


[zh-cn] resync: authentication.md

Signed-off-by: Hu Shuai<EMAIL_ADDRESS>

/lgtm

/approve


Container fails to run with memory limit

When adding -m or --memory as limit to podman run command it fails with following error.
# podman run --rm -it --memory 1g alpine sh
Error: could not find cgroup mount in "/proc/self/cgroup"

I tried to check the mount and that was available.
# mount | grep cgroup
cgroup2 on /sys/fs/cgroup type cgroup2 (rw,relatime)

I also tried adding options like nsdelegate and memory_recursiveprot, but it had the same issue.
# mount | grep cgroup
cgroup2 on /sys/fs/cgroup type cgroup2 (rw,relatime,nsdelegate,memory_recursiveprot)

Looks like podman expects cgroups to be set up on the system, and we don’t currently do that yet: https://github.com/containers/podman/issues/14236#issuecomment-1127025185
Not entirely sure what the minimum steps are to fix this. Contributions welcome :)

Thanks for the reference, I will try something and if it works will share the updates here.

The steps mentioned in the referenced issue works. I used the same code as mentioned in https://gokrazy.org/packages/docker-containers/ and added a function setCgroups() which initializes the current process to use a common cgroups.
const (
	CgroupPath = "/sys/fs/cgroup/podman_containers"
)

func setCgroups() error {
	// create a cgroups path
	if err := os.MkdirAll(CgroupsPath, 0755); err != nil {
		return err
	}

	// set current process pid in that cgroup.procs
	if err := os.WriteFile(filepath.Join(CgroupsPath, "cgroup.procs"), []byte(strconv.Itoa(os.Getpid())), 0644); err != nil {
		return err
	}

	return nil
}

It sounds to me like commits https://github.com/containers/podman/commit/94e82121bf73c163d86d99fa37b0d64adf996fba and/or https://github.com/containers/podman/commit/bd51410b8d16093e9c397b1e620baa08e910890c will fix this without requiring changes from our end, but are not yet in a tagged podman release.

gokrazy/podman is now updated to v4.2.1, which contains the fixes. For me, podman run --rm -it --memory 1g alpine sh now results in a working container.


Rename report flow param from prompt to reload-three-times-within-20-seconds

Task/Issue URL: https://app.asana.com/0/0/1208889990660025/f
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

#5339  👈 (View in Graphite)
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.


chore: bdd-nh-1587645281 to 0.0.1

chore: Promote bdd-nh-1587645281 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


docs: Updating container instructions

Adds:

a reference to the GHCR CI container builds.
updates instructions for the container build, in particular the importance of providing the git metadata to the build process.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.4%) to 84.153%

Totals

Change from base Build<PHONE_NUMBER>:
-0.4%

Covered Lines:
308

Relevant Lines:
366

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.4%) to 84.153%

Totals

Change from base Build<PHONE_NUMBER>:
-0.4%

Covered Lines:
308

Relevant Lines:
366

💛  - Coveralls


uTikDownloadHelper Problem

Unexpected Character Encounter while parsing value <. Path". line 0, position 0.

This is more of a problem for DanTheMan827 (on git).


Consolidate ssh code into onboard.

Followup to #150
Advantages:

Less code
Single config type for all SSH stuff
Only one place now needed to change HostKeyCallback
Only one place where the nohup command is
SSH session creation code consolidated

Disadvantages:

The onboard name is now misleading.

In a followup!

Not super happy approving a merge yet without naming changes given no reason the naming shouldn't be reflected now rather than later.


Allow for --size to take a percentage

This means detecting the free space where the data-dir is located and doing a little math. All in all fairly straightforward, but keeps people from overloading their systems.

@barakmich this seems like it should be pretty easy to do, I'll jump on this.


Proposal: Augmented download (with working PoC)

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[x] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
This introduces concept of "augmented downloading", to allow running side-tasks as needed.
Design notes

Each tasks are called "augment"s. They run background tasks required by some websites. (e.g. heartbeating, data rewriting...)
These "augment"s can be called by adding augments key to infodict of formats or root. They do not require instantiation at Extractor-side, much like PostProcessors.
"Augment"s may modify infodict to make subsequent code to use them.

This is intended to replace bloated heartbeat code, and to add HTTP rewriting server in the future (ref. https://github.com/yt-dlp/yt-dlp/pull/888#issuecomment-1065670214 wtf).
So it fully replaces FC2LiveFD.
Content of augments key
{
  "augments": [{
    "key": "heartbeat",
    ... # parameters required by each augment
  }, ...],
}

augments is intentionally made a list to keep order of thing in control. You can even run 2 heartbeating with different interval at the same time.
Augmentations cannot be dynamically filtered for now.
The currently defined key for each augment is only heartbeat, but can be added and checked at yt_dlp/downloader/augment.py
The code is currently rough, since it's at proposal now. Please feel free to review and provide suggestions.

@dirkf, pinging since you had merged the NiconicoDmcFD in youtube-dl

@dirkf, pinging since you had merged the NiconicoDmcFD in youtube-dl

Thx

... bloated heartbeat code ...

Really? But I see the advantage of a framework for running something during the download (might it also be possible to replace the per-downloader progress monitoring?). If you guys get it right, I'm open to pulling such a thing into yt-dl if the affected extractors need to be back-ported again.

... bloated heartbeat code ...

Really?

I agree the existing implementation is better if we needed it only for niconico. But the issue is that we keep finding more sites where this is needed. Creating a new downloader for each such site will end up in an unmanageable mess


An exception arose when reading instructions from the ELF file

Environment:
commit id: f335738370e50d5d23614150c3e8c4a85685e43a
Description:
Hi,
I built NaxRiscv according to https://github.com/SpinalHDL/NaxRiscv/blob/main/src/test/cpp/naxriscv/README.md.
Then I run an elf (input_nax_0.zip) on NaxRiscv with the following command:
cd $NAXRISCV/src/test/cpp/naxriscv
./obj_dir/VNaxRiscv --load-elf=./input_nax_0.elf --start-symbol=_start --pass-symbol=write_tohost --timeout=100000 --name=input_nax_0 --trace --trace-ref

However, it reported:

DUT is blocked in a endless trap cycle of death
TIME=668
LAST PC COMMIT=80000ac4
INCOMING SPIKE PC=0
ROB_ID=x27
FAILURE input_nax_0

After debugging the waveform, I found that NaxRiscv reported illegal instruction exception with tval='0x0297e101'. The Instructions after PC=0x80000ac4 are as follows:

It seems that NaxRiscv is confusing bnez with auipc. However, I have no idea how to solve this problem. Could you please offer some help?

Hi,
RVC isn't enabled by default, and i can see that 80000ac8 is a compressed instruction.
Either you need to turn on RVC support in Nax, either you need to compile the binary without RVC :)

--timeout=1000000 mean that the simulation should fail if longer than the given amount. It isn't an "inactivity" timeout, but a dead line.

bigger ^^, or just remove it

i mean software source file

i mean the source code which generated input_nax.elf

Then you need to check the traces generated by the simulation to see what the software is doing and if it is stuck somwere.
Also note that no missmatch against spike was detected (lock-step sim)


Changing master key to BLS12381-HD-KEYCHAIN

Description
In order to be more general, master key in HMAC function changed to "BLS12381-HD-KEYCHAIN".
Checklist

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] My code follows the code style of this project.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.
[ ] CHANGELOG is updated.

merge


[meta] Improve contributor guides

📚 Subject area/topic
contributor guides -- recipe style guide
📋 Page(s) affected (or suggested, for new content)
up for discussion -- possibly:

The Writing Guide
Recipe Guide
The Contributing to Docs section on the docs website

📋 General description or bullet points (if proposing new content)
I see some things to improve in our writing guides. Happy to submit a PR or 3!
State implicit guidelines more clearly
While we were working on the CMS recipe for Builder.io, some additional writing guidelines came out in the PR. I think it might save future contributors (and our brave reviewers) some time if these guidelines were stated clearly somewhere in the writing guides:

“we typically like to avoid getting into too many of the third-party's instructions."

This is a quote from @sarah11918 that we could almost put in the docs as is :o). I'd add smth like: "You can give some, but keep it simple. For more complex procedures, you can link to a relevant page in the official documentation instead".

Don't attach screenshots.

Possible space for these instructions

in the section Recipe writing within writing-and-style-guide.md

Improve instructions for text highlighting in our section on code samples
I’ve had trouble applying some of the regex examples in that section to my own snippets.
After doing some tests (see reproduction) I think I found the thing that really threw me off:
Example 2 says "- highlight any occurrence of {props.title} and {props.social}",
but the following regex -- /{props.(title|socialLinks)}/ (sic!) -- only highlights the words title and social -- whatever is in the round brackets. I thought for a long time there was something wrong on my side.
I think it should be made clear this only highlights the words in the round brackets. And possibly give another example highlighting the whole {props.title}, including the wavy brackets.
Also, the regex in the example saying socialLinks instead social seems to be an oversight.
💜
🖥 Reproduction in StackBlitz (if reporting incorrect content or code samples)
Ran some quick in a Gitpod workspace. They're at the top in the Builder CMS recipe.
https://gitpod.io#snapshot/2c8fcfdb-aa29-4ba2-b9ad-5adb316bf012

We are so backed up, I'm just getting around to some older issues now... it looks like this one should have been closed with the merged PR!
Thanks for this, for contributing, and hope to see you around the docs again! (And I have a lot of behind-the-scenes contributor guide improvements happening... so I hope these docs will continue to get better!)