Identifiers in auto-tactics don't respect lexical scope

Prerequisites
Please put an X between the brackets as you perform the following steps:

[X] Check that your issue is not already filed:
https://github.com/leanprover/lean4/issues
[X] Reduce the issue to a minimal, self-contained, reproducible test case.
Avoid dependencies to Mathlib or Batteries.
[X] Test your test case against the latest nightly release, for example on
https://live.lean-lang.org/#project=lean-nightly
(You can also use the settings there to switch to “Lean nightly”)

Description
PR #3328 began allowing identifiers in auto-tactics, a much-desired feature. But these identifiers don't respect lexical scope/hygiene.
Steps to Reproduce

Create a file with the definition from the test case in #3328:def f3 (x y : Nat) (h : x = y := by exact Eq.refl x) : Nat :=
x + x

Run the test with a local name other than x:#check fun someNameOtherThanX => f3 someNameOtherThanX someNameOtherThanX

Expected behavior: I would expect the test to pass, because x is bound by the function's parameter named x. Lean's tactic language usually respects lexical scope.
Actual behavior: Elaboration fails with the message unknown identifier 'x'
Versions
This is present in the 4.9 release, as well as 4.11.0-nightly-2024-07-01 on live.lean-lang.org.
Impact
Add :+1: to issues you consider important. If others are impacted by this issue, please ask them to add :+1: to it.

This seems unlikely to work, especially if you consider that you can also call f3 (1 + 1) 2, at which point it's not clear what name x is supposed to be. The "correct" behavior in this particular case would be to treat x in the auto tactic not as a name but rather a reference to the previous expression and subject to substitution like regular expressions, but I don't think tactics allow that. Perhaps you can hack it in by adding let x := 1 + 1 into the local context in which to run the tactic, but that can have other side effects and it's not obviously the right behavior.

It's definitely tricky, and I agree that there isn't an obviously right semantics. But we do need to explain to people how to use this at some point.
What is the specification for the current behavior? Is it that names in the script are resolved in the global context immediately prior to the definition, or is it that they're resolved unhygienically at the use site? The former seems like something we can document our way out of, but the test here seems to indicate the latter, which strikes me as unpredictable.

Putting the assignment x := 1+1 into the local context before elaborating the tactic seems to be most correct behavior to me, if it can be made to work. The other semantics discussed here seem rather weird.

Another issue related to this feature is that these identifiers now show up in the .ilean files at the call-sites of those functions. E.g. IO.waitAny has a parameter (h : tasks.length > 0 := by exact Nat.zero_lt_succ _) and Nat.zero_lt_succ now shows up in the .ilean files of all call-sites of IO.waitAny, effectively breaking language server support for that function.


please update rvm installer

rvm installer within vcap installer says
Deprecated command, please use:

    bash -s stable < <(curl -s https://raw.github.com/wayneeseguin/rvm/master/binscripts/rvm-installer)

but vcap installer does not stop and finishes incomplete installation.
I made patch to update rvm installer URI and check return value.
--- install.orig	2012-01-25 10:16:46.000000000 +0900
+++ install	2012-01-25 10:22:33.000000000 +0900
@@ -60,8 +60,12 @@
 fi

 echo "Installing rvm"
-curl -s -k -B https://rvm.beginrescueend.com/install/rvm > /tmp/install_rvm
+curl -s -k -B https://raw.github.com/wayneeseguin/rvm/master/binscripts/rvm-installer > /tmp/install_rvm
 bash /tmp/install_rvm
+if [ "$?" != "0" ]; then
+    echo "failed to install rvm, cancelling setup"
+    exit 1
+fi
 rm /tmp/install_rvm

 echo "Activate rvm"

This installation method is going away and the currently "experimental" installer is what you should use: https://raw.github.com/cloudfoundry/vcap/master/dev_setup/bin/vcap_dev_setup


Stockholm integration needed

A frontend for automatic evaluation is present in our ecosystem. We need its integration here.

Stockholm will not be required with the advent of the new platform.


Flake8 rule 'E901' reported an invalid point

Flake8 reported an invalid point for the rule E901, with the messge SyntaxError: EOL while scanning string literal.
String was not closed somewhere inside the file. Flake8 couldn't tell line. It was NaN/NaN instead.
Debug information:
Atom version: 1.16.0
Flake8 version: 2.5.5 (pep8: 1.5.7, hacking.core: 0.0.1, ProxyChecker: 0.0.1, mccabe: 0.2.1, pyflakes: 0.8.1) CPython 3.5.1+ on Linux

Please update your flake8 version (pip install -U flake8). This particular error should be fixed in flake8>=3.2.1.

Closing due to a lack of response, if you are still having issues after updating flake8 please provide code to reproduce this!


Make sure we return false when committing.

This adds a tests to make sure we do not implement commit like this:

public function commit()
    {
        $saved = true;
        foreach ($this->deferred as $item) {
            $saved = !$this->save($item));
        }
        $this->deferred = [];

        return $saved;
    }

Current coverage is 100.00%

Merging #10 into master will not affect coverage as of 1495a1f

@@            master     #10   diff @@
======================================
  Files            2       2
  Stmts          100     100
  Branches         0       0
  Methods         20      20
======================================
  Hit            100     100
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of 1495a1f

Powered by Codecov. Updated on successful CI builds.


ValueError: unsupported pickle protocol: 3

Traceback (most recent call last):   File "./train_lm.py", line 41, in <module>     'reload': [False]})   File "./train_lm.py", line 27, in main     use_dropout=params['use-dropout'][0])   File "/mnt/f/Programing/dl4mt_codes/codes/dl4mt-tutorial/session0/lm.py", line 641, in train     worddicts = pkl.load(f) ValueError: unsupported pickle protocol: 3
i use the data of europarl-v7.fr-en suggest at #62 instead wiki data, and hanpen the problem above.
Thanks

This seems like a python 2 - 3 compatibility issue.
Please, try passing protocol=2 to pkl.dump(worddict, f, protocol=2) when you create the vocabulary, here

Hi @orhanf , thank you for your reply in time! and now it works.


Unable to override a Typography component with inline style or CSS

I have a Paper element containing a grid system (24 columns) that contains a Paper, that contains a typography
(schematic)
<Paper>
  <Grid container spacing={24}>
    <Grid item xs={12} sm={6}>
      <Paper>
        <Typography>

I would like to change the Typography's font color to white, but it gets overriden by the Typography component. I can make it change if use the style attribute or the classes, but I would like to use some "normal" CSS for these kind of things

[x] I have searched the issues of this repository and believe that this is not a duplicate. (Note: Also search on Google in general)

Expected Behavior

expected result:

Current Behavior

This is what I can see from the developer's console:

Steps to Reproduce (for bugs)

<Paper elevation={4} className="dashboard-paper">
  <Grid container spacing={24}>
    <Grid item xs={12} sm={6}>
      <Paper
          elevation={8}
      >
        <Typography // This is the component that causes me some troubles
            variant="headline"
            component="h3"
            className="dashboard-typography"
        >
          This is a sheet of paper.
       </Typography>
       <Typography component="p">
         Paper can be used to build surface or other elements for your application.
       </Typography>
      </Paper>
    </Grid>
 </Grid>
</Paper

.dashboard-typography {
  padding: 2%;
  background-color: #3f51b5;
  color: #ffffff;
}

Context
Even though I can use css by creating const and putting some css in it, I would like to avoid it because I don't know React and Material UI well enough to "allow me" this. The problem is it seems that I don't have a choice, or maybe I did something wrong
Your Environment

Tech
Version

Material-UI
v1.0.0-beta.33

React
16.0.36

browser
Chrome 64.0

Please follow our guide: https://material-ui-next.com/guides/interoperability/#raw-css. You need to make sure the CSS injection order is correct.


[feat] Add Aim monitor

Introducing AimMonitor, a new wrapper for Aim  that helps track experiment metadata and events. This pull request includes:

[x] AimMonitor creation
[ ] Documentation update
[ ] Testing

These changes enhance experiment monitoring, making it more transparent and user-friendly.

@tmynn please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="AimHub"

Resolves #3158

Hi @tamohannes - is this a PR that you will want to complete?  If so, could you resolve the merge conflicts?


Space not showing for CompleterService.remote

If the JSON returned by the server is:
{name: 'Nicolas Sharp', id: 1}
Then 'NicolasSharp' is intermittently displayed in the dropdown.
Also, completerServicePeople.remote(null, '', 'fullname'); doesn't work, you must include the field name as the second argument, I believe this is incorrect behaviour.

@nicolassharp space omission doesn't reproduce in the demo, can you provide a plunk?
As for the empty search field:
When the data is an array of objects there is no way to know which field should be searched. if you want to include all items you should set it to null and not to an empty string.
An empty string is expected when the data is an array of strings and then there is no field to search.

@oferh the API is private so that's a little hard to do, when I have a bit more time I'll try on Pluckr with a public API. In the meantime here are some screenshots:

Got the same... I my case a framework causes display: inline-block on spans
And your search will create something like the following
Nicolas
 Sharp

And the ´inline-block´ omitts the space visually
try this
.completer-list-item {
        display: unset;
      }
´´´


[WIP] Update vendoring

Update all vendoring, pinning versions.

This is going to make https://github.com/prometheus/prometheus/pull/4802 more complicated for me to rebase if we merge this first.

@simonpasquier Ok, do you want to do the vendor version pinning after we switch to go mod?


[Bug] Buttons on Torrent Page

Description:
Buttons aren't showing on Torrent page
I can provide the other details if needed, but after tons of trial and error, in order for the buttons to show up on the torrents page, you can't have Category Icons set to "Text Only" in Preferences on https://www.myanonamouse.net/preferences/index.php?view=torrents.
Technical Details:

OS: macOS 12.4/5
Browser: Chrome 103
Userscript: ViolentMonkey

Wow, good catch!  I've never had my icons set to Text Only so never would have caught that.

Happy to help!
Also, I couldn't get the gift new users on the homepage button to work (the new tabs worked) - the settings I tried (not sure which one) that seems to have fixed it: i changed the site max width to 950px, switched to DropDown Menu for Site Menu Style (I think this one is most temperamental with MAM+), and I turned back on the sections of the top menu including bonus points- screenshot attached.  I didn't have the error log of MAM + running at the time.  I'll try better troubleshooting when there are new users to test again.

Downside of changing my Site Menu Style - it deleted the specific site search links i'd added from the custom site links above the menu bar.  Ah, well...

hmmm..... probably should be creating a new issue for that?

Update: Worked with width set to 0 for Site Max Width.  (Still dropdown menu and points selected.)

Tried again with the Side Menu Style, and didn't work.  But opening in new tabs does work.

Sorry for the lack of response lately! I saw the email notification but didn't follow up on it immediately and then kinda disappeared for the last month or so... When the next M+ version goes live there will likely be a lot of bugs that need fixing, so I'll likely end up working on this at the same time.
I definitely appreciate the work you've put in the catch these edge cases, thank you!


Class PhoneNumber has incorrect end tag

is:
Public Class PhoneNumber
    ...
End Module

should be:
Public Class PhoneNumber
    ...
End Class

Fixed a while back


Rewrite ytimg and youtube URL schemes to https to prevent mixed content warnings

Right now https pages on most of pyvideo.org throw mixed-content warnings and don't show the lock icon.  Rewrite most of the thumbnail URLs like so:
$ find . -name '*.json' -print -exec sed -e s,http://i.ytimg,https://i.ytimg,g -i '' '{}' ';'
$ find . -name '*.json' -print -exec sed -e s,http://www.youtube,https://www.youtube,g -i '' '{}' ';'

Nice! Thank you @glyph


FE Proxy fails to route the requests correctly if the non-default dns setup is utilized.

FE Proxy fails to route the requests correctly if the non-default dns setup is utilized. When I modify values.yaml setting up
resolver: "kube-dns.kube-system.svc.mycustomizations.com"
in line 1074 of https://github.com/StarRocks/starrocks-kubernetes-operator/blob/main/helm-charts/charts/kube-starrocks/values.yaml
the proxy starts up, but upon receiving  streming load request to upload a csv file fails with errors like
"PUT /api/my_db/my_jobs/_stream_load HTTP/1.1" 502 182 "-" "curl/8.2.1"           ││ 2024/08/14 15:00:03 [error] 20#20: *18 kube-starrocks-fe-service.starrocks.svc.cluster.local could not be resolved (3: Host not found) indicating that custom setting does not get fully propagated.
Starrocks version is 3.3.2 setup in Kubernetes cluster. The deployment is done through kubernetes operator helm chart (https://docs.starrocks.io/docs/deployment/helm/).
The issue appears both on default version of nginx and on v1.27.
At the same time regular FE has no issues with resolution (as seen on the attached screenshot) - only FE Proxy has.

Steps to reproduce the behavior (Required)

Create a .csv file that looks like

"col1","col2"
1,"ABC"
2,"DEF"
3,"GHI"

Deploy starrocks on kubernetes cluster with fe proxy. Let's assume root username and password are root and blank password correspondently.
Create database and add a table that matches your CSV file. Let's say you go with

CREATE DATABASE control_db;
USE control_db;
CREATE TABLE test_table(
    Col1 INT,
    Col2 VARCHAR(255)
)

Make sure curl is installed on your machine and execute:
curl --location-trusted -u root:      -H "label:custom_label1"      -H "Expect:100-continue"      -H "column_separator:,"      -H "columns: col1, col2"      -T Tab1.csv      -XPUT http://<fe_proxy_ip>:<fe_proxy_port>/api/control_db/test_table/_stream_load

Expected behavior (Required)
{
    "TxnId": 12345,
    "Label": "custom_label1",
    "Status": "Success",
    "Message": "OK",
    "NumberTotalRows": 3,
    "NumberLoadedRows": 3,
    "NumberFilteredRows": 0,
    "NumberUnselectedRows": 0,
    "LoadBytes": 1024,
    "LoadTimeMs": 100,
    "BeginTxnTimeMs": 1,
    "StreamLoadPlanTimeMs": 15,
    "ReadDataTimeMs": 0,
    "WriteDataTimeMs": 99,
    "CommitAndPublishTimeMs": 101
}

Real behavior (Required)

<title>502 Bad Gateway</title>

502 Bad Gateway

nginx/1.27.0

StarRocks version (Required)
3.3.2 (but initially observed on 3.3.1)

kube-starrocks-fe-service.starrocks.svc.cluster.local could not be resolved (3: Host not found)
@zakhalex what's the canonical service dns name in your kubernetes cluster setup?

@kevincai correct - in the environment where this issue happens, it is a customized domain name instead of the default .cluster.local (In other words - it is NOT cluster.local)

@zakhalex it is caused by the hardcode domain name of the kubernetes cluster in line https://github.com/StarRocks/starrocks-kubernetes-operator/blob/main/pkg/subcontrollers/feproxy/feproxy_configmap.go#L30
You can modify the line, change the svc.cluster.local to your customized domain name svc.mycustomization.com.
We will take a look how to support customized domain name in operator.

@kevincai correct - in the environment where this issue happens, it is a customized domain name instead of the default .cluster.local (In other words - it is NOT cluster.local)

@zakhalex wait for the next release of the operator to suppport customized domain setup. refer to https://github.com/StarRocks/starrocks-kubernetes-operator/pull/604


Signalr 2023 08 01 preview

ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see Getting help section below.
Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!

[x] New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix swagger quality issues in S360.
[ ] Other, please clarify:

edit this with your clarification

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:

The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
You believe there is no need for you to request breaking change approval, for any reason.
Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

The breaking changes are introduced in this PR due to migrate to common types: https://github.com/Azure/azure-rest-api-specs/pull/22948#issuecomment-1478860791. I think we could ignore them

Anyone could help review this? 😂

Looks we skipped step 1 and completed step 2. So I added back the label "WaitforArmFeedBack" to put it into the Arm review queue. Then the bot removes the "ArmSignOff" 😂 . We need to wait again..
The breaking changes have been approved before and we hope to get a quick approvol for that.

#pr RequestMerge

/prRequestMerge

/pr RequestMerge


[fix][BOM]delete useless dependency exclusions

Purpose of the pull request
delete software.amazon.awssdk useless dependency exclusions
Brief change log
delete software.amazon.awssdk useless dependency exclusions
Verify this pull request
Manually verified the change by testing locally.

Codecov Report

Merging #12273 (507298c) into dev (c7435a5) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #12273      +/-   ##
============================================
- Coverage     39.68%   39.67%   -0.01%
  Complexity     4207     4207
============================================
  Files          1021     1021
  Lines         38242    38209      -33
  Branches       4394     4378      -16
============================================
- Hits          15176    15160      -16
+ Misses        21314    21298      -16
+ Partials       1752     1751       -1

Impacted Files
Coverage Δ

...r/plugin/task/sqoop/parameter/SqoopParameters.java
55.12% <0.00%> (-1.29%)
:arrow_down:

...rver/master/runner/task/BlockingTaskProcessor.java
75.86% <0.00%> (-0.55%)
:arrow_down:

...heduler/api/service/impl/ResourcesServiceImpl.java
51.68% <0.00%> (-0.47%)
:arrow_down:

.../dolphinscheduler/plugin/task/spark/SparkTask.java
72.56% <0.00%> (-0.25%)
:arrow_down:

...eduler/api/dto/workflow/WorkflowCreateRequest.java
100.00% <0.00%> (ø)

...eduler/api/service/impl/DataSourceServiceImpl.java
30.06% <0.00%> (ø)

...cheduler/server/master/utils/DependentExecute.java
0.00% <0.00%> (ø)

.../dolphinscheduler/plugin/task/datax/DataxTask.java
0.00% <0.00%> (ø)

...phinscheduler/plugin/task/chunjun/ChunJunTask.java
0.00% <0.00%> (ø)

...cheduler/plugin/task/api/ShellCommandExecutor.java
0.00% <0.00%> (ø)

... and 9 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


A major improvement is that we can now use vectorize=True to get sane dask graphs for vectorized interpolation to chunked arrays (https://github.com/pydata/xarray/issues/6799#issuecomment-2474126217)
Added a bunch of typing.
Happily this fixes #4463

[x] Closes https://github.com/pydata/xarray/issues/6799#issuecomment-2474126217
[x] Closes #4463
[ ] Tests added
[ ] User visible changes (including notable bug fixes) are documented in whats-new.rst
[ ] New functions/methods are listed in api.rst

cc @ks905383 your vectorized interpolation example now has this graph:

instead of this quadratic monstrosity

Merging on thursday if there are no comments.
IMO this is a big win for maintainability.


feat!: rename function to archive

Companion PRs
https://github.com/Substra/orchestrator/pull/310
https://github.com/Substra/substra-backend/pull/739

/e2e help

Usage: /e2e [options] [help]

/e2e may appear anywhere as long as it is on its own line

Options:
  --refs <value>                                   Extra refs (branch or tag) with format REPO=GIT_REF,REPO=GIT_REF.
  Supported repositories: hlf-k8s, orchestrator, substra-backend, substra-frontend, substra-tools, substrafl, substra, substra-tests, substra-documentation, substra-ci.
  Example: /e2e --refs substra-backend=some_branch,orchestrator=some_tag (default: {})
  --tests-to-run, --tests <tests-to-run>           Comma-separated list of tests to run. Valid options: sdk, substrafl, doc, frontend, mnist, camelyon or NONE. (default: "sdk")
  --orchestrator-mode, --mode <orchestrator-mode>  Comma-separated list of orchestrator modes to run tests for. Valid options: standalone,distributed (default: "standalone,distributed")
  -h, --help                                       display help for command

Thanks :) But there is a mention to it in SubstraFL. You need to open a companion PR there too: https://github.com/Substra/substrafl/blob/3f4434a11288ab416afaf33a5800cc2c120d83f0/tests/remote/register/test_register.py#L74
This is the only mention I found so it might just be a one line PR :) (I looked in substra tests, subtrafl and substra-doc)

Nice catch 👍
I'm wondering if I might need to change some things in substra-tests too, in the factory possibly... 😭

Thanks :) But there is a mention to it in SubstraFL. You need to open a companion PR there too: https://github.com/Substra/substrafl/blob/3f4434a11288ab416afaf33a5800cc2c120d83f0/tests/remote/register/test_register.py#L74
This is the only mention I found so it might just be a one line PR :) (I looked in substra tests, subtrafl and substra-doc)

Nice catch 👍
I'm wondering if I might need to change some things in substra-tests too, in the factory possibly... 😭

I looked and didn't find any :)

Thanks for the PR. To be merged with the POC functions then ? (which mean we'll need to release substra too ?)

Not with the POC branch, it's the next bunch of PRs (adding checksums, permission checks and a bit of refactoring / renaming) 😅
I anticipate lots of fun to rebase all that 😂


Postcreate

Resolves #27
Edit: topic create part is also done, it isn't the most beautiful thing in the world but it's just for admins so should be fine.

Post create works fine, however, the topic create part is inaccessible for me


My Email WebPart

Category

[x] Bug

Describe the bug
Expected or Desired Behavior
open outlook web new email
Observed Behavior
Clicking the New Email button does not go to new email in the outlook webpage and just leaves the user at a error page.
Steps to Reproduce
Add the webpart and have something in  your calendar.
click new email.

Apparently the path to the new email page has changed. This is being looking into, expected outcome is an updated webpart that could be deployed directly to the app catalog, as well as an updated provisioning package in case you wanted to redeploy the entire solution.

This bug has been fixed in a recently merged commit: https://github.com/pnp/sp-starter-kit/commit/81a8beb88a4bc4fba4d31ba2e2fd3de742345816
You can either obtain the latest full source from the master branch and reapply the entire kit, or simply pull the latest sppgk from ./source/react-personal-email and replace what was provisioning in the app catalog.

Wow thank you that was fast. I had only installed the bundled package I assume applying the individual one next to that would cause problems ?

Oh, I missed this was related to V1. What was just provided is aimed at V2. We are not actively updating V1, thus I am not sure how quickly we could update the v1 sppkg.
If you took the sppkg from v2, just the specific email webpart, then yes, you would see a duplicate of available personal email webparts, and your existing instances of the personal email webpart would not be updated. They would need to be replaced.
You could still have both webparts in your app catalog though.
My suggestion for the quickest fix is to look at the recent commit and you will see the one primary .tsx file that was updated. You can merge these changes over to .\solution\src\webparts\personalEmail, re build/bundle/package-solution the .\solution SPFx project, and finally update the V1 sppkg.

No problem thanks for your help!


 I've been trying to get SGS01 plant sensor info in to home assistant.
Does this integration require a tuya bluetooth hub to work? Or would it work with the HA bluetooth integration (Bluetooth dongle on HA PC, or esphome bluetooth proxies)?
I have tried several forks of the ha_tuya_ble integration but none of them seem to work either, I can get the SGS01 sensor added in to HA but it does not give me any data, either the temp and moisture sensors show up as unavailable or they do not show up at all...

@pilonull yes, you need hub

I’ve integrated this sensor and it doesn’t update regularly, but if I open the Smart Life mobile app it does update the sensor data right away. Anybody else with the same issue?

t doesn’t update regularly

I have exactly this behavior of this sensor, you need to write to the developers of the sensor.

t doesn’t update regularly

I have exactly this behavior of this sensor, you need to write to the developers of the sensor.

It is a fw issue then… I’ll try to find who are the developers of this sensor. Didn’t knew if it was something that the integration could manage it.

If you can find out how the app manages to get the sensor to update more frequently, it is possible that some way to use that same method could be added.  But most likely this is a battery conservation measure, so doing it all the time would run through batteries too quickly.

If you can find out how the app manages to get the sensor to update more frequently, it is possible that some way to use that same method could be added. But most likely this is a battery conservation measure, so doing it all the time would run through batteries too quickly.

That seems a great idea, I guess that every 60 minutes it is more than enough. This sensor uses two AAA batteries which for a BLE is quite powerful (thinking on a PC mouse that batteries last for years nowadays).
I can enable logs or anything that can help, l’m new on Tuya wold and apologies for my ignorance but glad to help the community.

I think is that a defect resides within the firmware's code (or perhaps a universal firmware intended for low-capacity battery devices is employed), whereby the sensor perpetually amasses data, yet only transmits said data upon receiving a specialized request from the application or hub. Regrettably, this renders the sensor devoid of utility for the purpose of creating automatizations

I can confirm that json definitely works! If sent within a short period of time will not update the hub, but at least with 40 minutes it works. @make-all can you implement this?

No access to the C/F setting has been provided in the pull request, so that cannot be done without more info on the dps mappings.

Understand. looking to the code dps mappings seems to have a relation with the teh json commands:

@almirus can you add something on this?

DPS mappings are in Cloud / API Explorer / Device Control / Query Things Data Model.  You need to set your data center are the top of the page, and fill in the device id for your SGS01.

Apologies, the temperature unit is exposed as read-only within the temperature sensor. So it just needs to expose the same dp via a select entity.

Apologies, the temperature unit is exposed as read-only within the temperature sensor. So it just needs to expose the same dp via a select entity.

No need to apologize. I've applied your change and voilá it works as charm 👍
With the new select, the service to call is very straight:
service: select.select_option
target:
  entity_id: select.sensor_humidade_vasos_temperature_unit
data:
  option: celsius

I'm now checking how often can be called starting with an automation every 30 minutes for test purposes, my goal is to update the  sensorwhile the irrigation is running and before its stops.
Thank you @make-all

A new update: Like in the Smart Life app the "update" retrieves not the actual/last value, but recorded data stored in the device, this behavior is confirmed in this discussion  #1910 by Adrian.
See here the humidity:

and the same for the temperature:

Now it will be just a matter of findind the right interval to retrieve the last value only and profit 👍

@Joao-Sousa-71 as I had previously stated, the sensor stores all statistics over a defined period of time (temperature and humidity), but transmits the entire data set simultaneously upon receiving a request from the hub or application.
It is plausible that in conjunction with the aforementioned data transmission, a timestamp is also reported

@Joao-Sousa-71 as I had previously stated, the sensor stores all statistics over a defined period of time (temperature and humidity), but transmits the entire data set simultaneously upon receiving a request from the hub or application. It is plausible that in conjunction with the aforementioned data transmission, a timestamp is also reported

Make sense. So far 30 minutes seems a good interval and yet didn't receive more that one value of humidity and temperature. Need to change the location of the sensor and force temperature changes within the period.

i've been making adjustments and with 30 and 20 minutes cadence, still have a just a few syncs where more than one value is sent to the Gateway. I'm now testing 15 minutes (which is 4 updates per hour) to see how it goes.
Keep you posted.

@Joao-Sousa-71 I have a version that periodically switches to Celsius (only). I am using the following automation:
@jmotor
alias: >-
  Для обновления датчиков влажности почты нужно дернуть установку единицы
  измерения
description: ""
trigger:
  - platform: time_pattern
    minutes: "01"
    hours: "13"
    seconds: "00"
condition: []
action:
  - device_id: dd122e973bd3631ebf95e6c23b2099ea
    domain: select
    entity_id: 1b60addd90ea0d4b1b01798a178431b0
    type: select_last
    enabled: false
  - device_id: e9bd7c36bda01143ee01902642c4fb01
    domain: select
    entity_id: 3b9254e2fdc12e862aeec6cc2cc4afc5
    type: select_last
    enabled: false
  - delay:
      hours: 0
      minutes: 0
      seconds: 2
      milliseconds: 0
    enabled: false
  - device_id: dd122e973bd3631ebf95e6c23b2099ea
    domain: select
    entity_id: 1b60addd90ea0d4b1b01798a178431b0
    type: select_first
  - device_id: e9bd7c36bda01143ee01902642c4fb01
    domain: select
    entity_id: 3b9254e2fdc12e862aeec6cc2cc4afc5
    type: select_first
mode: single

@Joao-Sousa-71 I have a version that periodically switches to Celsius (only). I am using the following automation: @jmotor
alias: >-
  Для обновления датчиков влажности почты нужно дернуть установку единицы
  измерения
description: ""
trigger:
  - platform: time_pattern
    minutes: "01"
    hours: "13"
    seconds: "00"

Хорошо быть умным...
Я туповат в этом вопросе...
Это надо вписать в...? Куда?
Или ещё ID поменять?

How did you do it? Do you have detailed instructions?

just this:
´´´
Update soil moisture sensor every X minutes

id: update_ble_soil_moisture_sensor
alias: update_ble_soil_moisture_sensor
description: 'Atualiza o Sensor de Humidade Horta'
initial_state: true
trigger:

platform: time_pattern
minutes: "/15"
action:
service: select.select_option
target:
entity_id: select.sensor_humidade_vasos_temperature_unit
data:
option: celsius
´´´

    device_id: dd122e973bd3631ebf95e6c23b2099ea
    entity_id: 1b60addd90ea0d4b1b01798a178431b0
    device_id: e9bd7c36bda01143ee01902642c4fb01
    entity_id: 3b9254e2fdc12e862aeec6cc2cc4afc5

What do these numbers mean? Where did you get them?

These are internal ids that HA uses when you set up an automation from the UI. Unlike select.sensor_humidade_vasos_temperature_unit, the hex id cannot be changed by the user.

The refresh button is using a hack to try to get the hub to communicate immediately with the devices so they send updates. What I have observed is that when you use the phone app, the app communicates directly with the devices via Bluetooth, so it may be using a method which is not exposed via the hubs to get them to send the data. When the devices do send data, they seem to send a batch of updates in succession, in the cloud there seems to be a timestamp which allows these to be displayed properly in a graph, but the timestamp is not exposed via the local protocol, so they all appear as a spike within a few seconds. Often the last one sent is identical to the previous reading (maybe a bug in the hub firmware) so the sensors do not appear to be updating even though the history shows updates received.


pull request for e2e test at 11/19/2016 13:26:05

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Documentation: Observable typo

📖 Documentation
There is a typo in the Observable documentation: Aletrnaitve instead of Alternative.

Closed by https://github.com/gcanti/fp-ts-rxjs/pull/57


cmd/go: remove --first-parent for git tag discovery

This commit fixes an invalid last tag retrieval for go modules by
including git tag from merge branches.
Fixes #31673

I signed it!


Update the State RFC to match the current database format

Motivation
This PR brings Zebra's State RFC up-to-date with the current database format. (Including upcoming Sprout changes.)
This is unexpected client planning work in sprint 24.
Review
Anyone can review this low-priority PR.
Reviewer Checklist

[x] Design makes sense
[x] Design matches implementation

Follow Up Work

#3137

I'll leave syncing up to you since there seems to be other stuff being merged right now


fix zh doc typro

fix a simple typro for zh doc

Thanks for your correction, though this file has some more in-synced content with the en upstream. The zh localization team does not accept partial changes of a file.
Would you like to sync those differences which you can find by running this command on your main branch:
./scripts/lsync.sh content/zh-cn/docs/reference/command-line-tools-reference/kube-scheduler.md

/hold


Update client3:circe, client3:core to 3.8.0

Updates

com.softwaremill.sttp.client3:circe
com.softwaremill.sttp.client3:core

from 3.3.18 to 3.8.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.softwaremill.sttp.client3" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "com.softwaremill.sttp.client3" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by https://github.com/polyvariant/sttp-oauth2/pull/511


Fix lint and requirements

@kokosing @rschlussel

looks good.

looks good
Maybe you could make line length limit longer just for convenience. Now you had to split so many lines, with longer line length limit you could avoid that.

We were hesitant to change the line length limit, since that's the standard PEP-8 limit. Might as well keep it for now.


feat: add GHSA-vfp6-jrw2-99g9 fixes in cosign v1.13.1

adds GHSA-vfp6-jrw2-99g9 fixes in cosign v1.13.1

Got this error from https://github.com/kyverno/cosign/actions/runs/6808524179/job/18513119071?pr=1:
Error from server (NotFound): services.serving.knative.dev "fulcio-grpc" not found


[resolves #490] Remove dependency on TCCL

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/wildfly-camel-pullreq/384/
Test FAILed.

retest this please

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/wildfly-camel-pullreq/385/
Test PASSed.


[Wallet] Prepare App/Play store accounts with the relevant content

Implement everything gathered in #3706 in App/Play store and make sure it's ready for the launch of the wallet.
As a part of #3643

Decided with @nityas that it would be handled by Product team.


some bugs

https://github.com/KevinMIN95/StyleSpeech/blob/ddff11e680e7c1491df7733fa498aa07b0be1c5f/preprocessors/libritts.py#L130
the remove_outlier here return none

and  in line 51,52:
list indices must be integers or slices, not list

x = np.array(x)

return x.to_list()

Revise the code as below
in preprocessors/libritts.py
BEFORE
if len([f for f in f0 if f != 0]) ==0 or len([e for e in energy if e != 0]):
AFTER
if len([f for f in f0 if f != 0]) ==0 or len([e for e in energy if e != 0])==0:

When I ran the preprocess.py, I would get this error: IndexError: cannot do a non-empty take from an empty axes.
Traceback (most recent call last):
File "preprocess.py", line 54, in
main(preprocessor, args.data_path, args.output_path)
File "preprocess.py", line 39, in main
datas = preprocessor.build_from_path(data_dir, out_dir)
File "/media/fish-bsp/fish_4TB/Audio/StyleSpeech-main/preprocessors/libritts.py", line 132, in build_from_path
f0 = remove_outlier(f0)
How can I revise the code to let it run successfully? Thanks.


Delete KonachanBridge.php

The website is not available.

$ curl https://konachan.com/ 2>/dev/null | grep "<title>"
  <title>konachan.com - Konachan.com Anime Wallpapers</title>


"Class 'Doctrine\Tests\OrmFunctionalTestCase' not found" when trying to run PHPUnit

Guys, since I'm new as developer, I'm trying to participate on Open Source community.
I have here a Xubuntu 14.04, 64-bits. Already installed Apache2, MySQL and PHP5 (5.5.9). After forked the repository, I'm trying to run the unit tests... it is my first time with them.
I've been following these instructions, but when I type $ phpunit Doctrine/Tests/ORM/Functional/Locking/GearmanLockTest.php, I get this error:
PHP Fatal error:  Class 'Doctrine\Tests\OrmFunctionalTestCase' not found in /var/www/html/doctrine2/tests/Doctrine/Tests/ORM/Functional/Locking/GearmanLockTest.php on line 14
I think that I'm missing something, because I already checked this class and its namespace and, theoretically, it exists.
Could someone help me? And I am sorry if I am making a foolish mistake.

@StanleySathler
git clone git@github.com:doctrine/doctrine2.git
cd doctrine2
composer install
./vendor/bin/phpunit

Try that :-)

Also, obviously requires patching those docs, I suppose :-\

@Ocramius
I installed composer and its packages, but I don't have any idea of how patch these docs. Is it something like a class mapper? Could you send me any link that could me teach more about it?

@StanleySathler if that snippet I gave you works (tests run), then you can simply edit tests/README.markdown and send it back at us (you can edit it directly from the github UI)

I've done it ;)

Linking #5623

Ocramius, the snippet didn't work. I'll try Jean's suggestions and I'll back with feedback.

@StanleySathler , my snippet is the same, I just added that you need to install at least SQLite to have a green test suite to start with.

@Ocramius do we need to update anything here regarding this issue?

No, this is dealt with in https://github.com/doctrine/doctrine2/pull/5623


Request School page mobile responsiveness

WHAT DOES THIS PR DO?

The Request School page now has basic mobile responsiveness (mainly text scaling and appropriate element padding)

Compared to #123 , this PR also attempts to follow 3 levels of font sizes:

1: For main headers text-lg md:text-xl lg:text-2xl xl:text-3xl
2: For sub headers text-base md:text-lg lg:text-xl xl:text-2xl
3: For input box example text and labels text-sm md:text-base lg:text-lg

Small refactoring done to the Enter School Name and Enter School Website boxes

WHAT ISSUES ARE RELATED TO THIS PR?

#106

HOW DO I TEST OUT THIS PR?

Run this project's front end locally (navigate to the web directory, run npm i, then npm run dev)
Navigate to the "Request School" page (use the navbar or go to http://localhost:5173/request-school)
To test the mobile version in your browser, use "inspect element" (both examples are rendering at iPhone 12/13 dimensions of 399x844)

Current request school page:

Updated request school page:

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8399ea8) 100.00% compared to head (1355bf7) 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##              main      #124   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines            3         3
  Branches         1         1
=========================================
  Hits             3         3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Need to load page on https://hostname instead of ionic://hostname

We are using the Ionic4 with angular router. For IOS Need to load page on wkwebview url like https://hostname instead of ionic://hostname. because we need to call the okta server for two way authentication. okta not accept the "ionic" as trusted orgin. okta allowed only "https or http".

@mlynch is there any possibility to change the scheme for IOS.

https://github.com/ionic-team/cordova-plugin-ionic-webview#scheme

https://github.com/ionic-team/cordova-plugin-ionic-webview#scheme

@wnabil this preference is for Android, and it works on that platform.
+1 for this possibility on iOS, I also need it for external service which checks app protocol...
Would be great to allow https for iOS as well!
Is there any reason why it's not allowed?

To have https as trusted origin for iOS is huge. Hopefully in the next release?

you can use v2 of the plugin, but on v4 you can't use https or http to serve the files


Visual Designer visual studio doesn't work

I was poking around this and made some interesting discoveries.
The way the designer renders the preview window is it has an out of process app which binds to the projects AppBuilder to instantiate the environment and then it renders the control inside of that.
The problem is that out of process host app is not a console app, and so all console APIs blow up. And even it were a console app it's looking for a bitmap to send back to the preview page.
BUT I managed to get it working sort of by doing this:

in program.cs I create an AppBuilder property
in UseConsolonia I use Designer.IsDesignMode to return a standard Avalonia.Desktop AppBuilder with a #ifdef DEBUG around it
I add conditional nuget package references to Avalonia.Desktop environment so they are only included on DEBUG builds
I add designer attributes to control

             xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
             mc:Ignorable="d" d:DesignWidth="100" d:DesignHeight="100"

it displays a preview (although completely illegible)!
Issues I had:

I had to add FontFamily FontSize Foreground and Background to render anything which didn't have that on it. (The colors panel actually previewed the best because it has explicit colors
The size of the image that is created is literally 100x100 pixels so I had to zoom to 800% to see anything.

I think this approach might work, but I think we need some combination of styling and scaling to make it work.
There are some alternative approaches that might be possible as well, but it would be more complicated

create an IConsole which paints onto an Avalonia canvas?
Somehow hack the host process to take snapshot of console window?

I don't know...but I thought I'd record what I figured out for whenever/whomever tries to tackle this.

May be we need own plugins for VS and Rider to run a proper out of process terminal and capture the window render. Just first thought.
IConsole which draws to canvas is little hacky but could work. Any mono font would work for it, but we have stuff like special characters, we would need to write own terminal emulator basically.
By the way, theoretically, do we have an option to render some terminal emulator into a bitmap? May be we already have some existing cross-platform emulator which can do this?

Yeah, I'm pursuing that route right now.  I can capture the console output as VT100 codes, as raw char buffer or as a bmp.
branch tomlm/preview is where I'm working. I'm trying to get a previewer working as Consolonia app, then I will try binding that to via one of the means to the avalonia preview


Update @berndverst photo

Updating my photo.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

advocates/media/profiles/bernd-verst.png
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Bump go loggregator to v4.0.1

Promotes value metrics to container metrics when appropriate.
[#150906690]
Signed-off-by: Wesley Jeanette<EMAIL_ADDRESS>

Includes changes in #356

Thanks, @bradylove ! Prioritizing for the Diego team to pull in. I'll also close https://github.com/cloudfoundry/diego-release/pull/356 since this PR subsumes it.
Best,
Eric


MODCXEKB-82 Parse package cql request

Purpose
Implement parsing of CQL query that searches for packages
Approach
Refactor existing logic in CQLParserForRMAPI and reuse it to parse package query.
I've split logic in CQLParserForRMAPI into classes CQLParameters, TitleParameters,
class CQLParameters parses CQL query into map of parameters (it also separately parses sort value and id parameter),
TitleParameters uses this map of parameters to apply validation and map them to corresponding RM API values for title endpoint,
Then CQLParserForRMAPI constructs queries using those RM API parameters.
class PackageParameters is similar to TitleParameters, but it applies validation and mapping specific to packages endpoint
TODOS and Open Questions

[ ] As I understand field names that are used in CQL query should correspond to fields of entities that are returned from mod-codex-ekb.
Existing logic for parsing titles sometimes doesn't follow this rule, for example CQL query is expected to have field "resourceType", but name of Instance attribute(i.e. attribute defined in raml\schemas\codex\instance.json) is actually "type".

Regarding comment on todos and open question: * for example CQL query is expected to have field "resourceType", but name of Instance attribute  is actually "type".
-- since this CQL is currently in use we need to continue to support existing syntax as is. Could look to revise when UI is updated (but all sources would need to be adjusted)

Regarding comment on todos and open question: * for example CQL query is expected to have field "resourceType", but name of Instance attribute is actually "type".
-- since this CQL is currently in use we need to continue to support existing syntax as is. Could look to revise when UI is updated (but all sources would need to be adjusted)

Yes, this is fine, I just wanted to check if CQL fields should directly correspond to schema fields, or if there is some other mapping that I should know about


#5561 Set a new name for the button acs style

Issue => https://github.com/epam/ketcher/issues/5561
Check list

[ ] unit-tests written
[ ] e2e-tests written
[ ] documentation updated
[x] PR name follows the pattern #1234 – issue name
[x] branch name doesn't contain '#'
[x] PR is linked with the issue
[x] base branch (master or release/xx) is correct
[x] task status changed to "Code review"
[x] reviewers are notified about the pull request

Closed the PR due to problems with the build


Fix Stream API Domain

When trying to connect to the Stream API to run a command in a container, the SDK tries to connect to live-test.tutum.co, which doesn't exist and fails to resolve. This fixes that URL to point to the correct domain stream.tutum.co .

Good catch! Thanks!

Just spotted the constant used elsewhere in the file, updated to use that instead.

Great, LGTM


alias sass-loader to scss-loader for unit testing

Adding this alias allows vue-loader to work in injection mode when using lang="scss" in a component.
Please see https://github.com/vuejs/vue-loader/issues/724
Thanks to @rsoule3 for finding a fix.

Thanks!


Disable XMIR Verification at Runtime

It's better to disable XMIR verification by default and enable it in all tests. This will significantly speed-up the entire pipeline.

@rultor release, tag is 0.7.0, title is 0.7.0

@rultor release, tag is 0.7.0, title is 0.7.0

@volodya-lombrozo OK, I will release it now. Please check the progress here.

@rultor release, tag is 0.7.0, title is 0.7.0

@volodya-lombrozo Done! FYI, the full log is here (took me 18min).


I2C DMA on MAX32666 does not work

I am trying to get I2C working with DMA on a MAX32666 and finding that it does not work. I set up my code based on the example at https://github.com/analogdevicesinc/msdk/tree/main/Examples/MAX32665/I2C
I need to be able to do the following types of transactions - none of which currently work:

Write a register address, followed by reading one or more bytes
Write a register address, followed by writing one or more bytes
Read one or more bytes

I made some changes in a i2c_reva.c that have 1 and 2 working, but I am unable to complete a transaction in the style of item 3 above.
https://github.com/sullivanmj/msdk/tree/fix(I2C-DMA)
I also was not able to get any of the above working with high speed I2C at ~3.2 MHz. This isn't a big pain point, but it would be nice to have working too.

Hi @sullivanmj, Can you attach your code which you are trying to do 1-3? I am gonna tag @Jake-Carter and @sihyung-maxim. They may be able to help if I cannot.

Hi @sullivanmj, I think the main problems are related to making sure the correct IRQ is enabled.
I noticed this loop starts at DMA8, but you are using DMA1.  So I suspect the DMA1 IRQ is not enabled, and the vector is not assigned.
MXC_DMA_Init(MXC_DMA1);
for (IRQn_Type i = DMA8_IRQn; i <= DMA15_IRQn; i++)
{
    MXC_NVIC_SetVector(i, DmaPoolIrqHandler);
    NVIC_SetPriority(i, 6);
    NVIC_EnableIRQ(i);
}

Our async and DMA I2C callback functions are reliant on MXC_I2C_AsyncHandler/MXC_DMA_Handler being called from the correct ISR, so if the NVIC routing is not enabled properly then the callbacks will not work.
Instead I would suggest explicitly enabling and routing the exact IRQ for the instance you're using.
NVIC_EnableIRQ(MXC_DMA_CH_GET_IRQ(MXC_DMA_GET_IDX(MXC_DMA1)));
MXC_NVIC_SetVector(MXC_DMA_CH_GET_IRQ(MXC_DMA_GET_IDX(MXC_DMA1)), DmaPoolIrqHandler);
// ...

Hi @Jake-Carter,
Thanks for taking a look at this. I am able to hit the DMA ISR and see the callbacks executing. My example code gets successfully through everything, until it gets to the i2cRead call, where it is stuck inside waiting for i2cResult to be set by the callback. The ISR & callback all appear to be executing correctly for all of the transactions until we get to an I2C transaction that has mxc_i2c_req_t.rx_len of 0, at the very end of my sample program.
The DMA setup is a little confusing, but the intent is to initialize the DMA1 peripheral, which contains DMA channels 8-15, and then enable interrupts on each channel (8-15) in DMA1. I have used this approach in another codebase where we are using DMA channels 8-15 as a pool, with other peripherals, and they all need to call MXC_DMA_Handler in their respective ISRs, so this bit of code works well for that arrangement. In any case, I updated the code in the gist to setup the interrupts on an as-needed basis, depending on whatever channel is returned from MXC_I2C_DMA_GetTXChannel and MXC_I2C_DMA_GetRXChannel, I still don't see any change in the cases that work vs do not work.
I also updated my branch that fixes case 1, to only include the requisite change for that fix.
So, to summarize/clarify, here's where I am at:

I am able to do transactions of this format, but only with the change in my branch.

Write slave address
Write n bytes (mxc_i2c_req_t.tx_len > 0)

I am able to do transactions of this format, even without the change in my branch. It is possibly noteworthy that this is the only flavor of DMA-based I2C transaction in the I2C example for MAX32666, where both a read and a write occurs in the same transaction.

Write slave address
Write 1 byte (the example writes 255, I have not tried writing any more than 1, though)
Read n bytes (mxc_i2c_req_t.rx_len > 0)

I am not able to do transactions of this format. I have tried a few things in the SDK code, but couldn't get it to work. What I see is that the slave address is shifted out, and then the MAX32666 holds SCL low, indefinitely. No DMA ISR ever triggers.

Write slave address
Write 0 bytes, this is the distinction between 2 above and this case
Read n bytes (mxc_i2c_req_t.rx_len > 0)

Thanks @sullivanmj, this helps clarify.  We'll definitely merge in your fix for case 1.
I'll take a deeper look at case 3.  I went down a similar path as you and it's not immediately obvious what is holding up the TX side just looking through the software.  I'll run some tests and take a look at what's going on in the hardware

Great, thanks. I'll be happy to help test this one as well, if/when you have a fix.

@sullivanmj just want to shoot you a quick update on this - it's still the queue.  We've been hit with some other really critical issues on a few other parts that we have to look into first, so there has been some delay

Just checking in - is there any ETA on a fix for this?

@sullivanmj Last week I brought in some additional resources to help and we're simultaneously looking into some other I2C timing issues that seem to be related on the MAX78002.  Your fix was relevant to fix some callback setups on that micro as well.
It's being more actively worked on now - no ETA yet just because we're still not exactly sure what the issue is.  We should make some progress this week and I'll keep you updated

@sullivanmj are you communicating with an I2C peripheral, or using a loopback configuration?

It's an I2C peripheral.

What's the part number for the peripheral?

It's an MS8607-02BA01. The particular transaction sequence that is problematic is illustrated in can be found in Figure 19 of the Datasheet, which illustrates the "I2C Measure RH No Hold Master communication sequence".

@Jake-Carter I hate to be the squeaky wheel, but is there any timeframe on this getting fixed?

@sullivanmj Not sure if you have already tried but I think in the 3rd case you may have to set .restart to 1 in i2cWriteAddressed.

@sullivanmj We're starting to take some chunks out of our backlog again.  Yours is top of the queue.  I've got an Adafruit module on the way which should get here tomorrow.  I hope to have a fix for this implemented by the end of the week.

@ttmut thanks for the tip, I will give this a shot.
@Jake-Carter thank you for the update.

@sullivanmj I've fixed the issue.
The main problem is that our drivers did not deal with NACKs from the slave on the RX side of the DMA I2C transactions.  I'm glad I got ahold of an MS8607 to test with - we had been struggling to replicate this artificially.  See the PR above for the implementation/test code and some logic analyzer traces.
Here's a version of the test code that will build for the MAX32666.  I need to re-order another MAX32666 kit to actually test it, mine seems to have disappeared recently...
Let me know if you can run this/how it works.  I think there may still be some updates to make to handle the MAX32666's multiple DMA instances.  Note I am also assigning the default DMA handler in the drivers now - may need to implement some mechanism similar to #763 to support custom handlers
Build against my fix/gh-987 branch.
git remote add jake-carter git@github.com:Jake-Carter/msdk.git
git fetch jake-carter
git checkout remotes/jake-carter/fix/gh-987 -b fix/gh-987

/******************************************************************************
 *
 * 2024 Analog Devices, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 *
 ******************************************************************************/

/**
 * @file    main.c
 * @brief   Hello World!
 * @details This example uses the UART to print to a terminal and flashes an LED.
 */

/***** Includes *****/
#include <stdio.h>
#include <stdint.h>
#include <stdbool.h>
#include <math.h>
#include "mxc_device.h"
#include "led.h"
#include "board.h"
#include "mxc_delay.h"
#include "i2c.h"

/***** Definitions *****/
#define ADDR_PT 0x76
#define ADDR_RH 0x40
#define MS8607_CMD_RESET_RH 0b11111110
#define MS8607_CMD_MEASURE_RH_HOLD 0b11100101
#define MS8607_CMD_MEASURE_RH_NOHOLD 0b11110101

static volatile bool g_dma_complete = false;
static volatile int g_dma_status = E_NO_ERROR;

#define I2C_INSTANCE MXC_I2C0_BUS0

void DMA_Callback(mxc_i2c_req_t *req, int result)
{
    g_dma_complete = true;
    g_dma_status = result;
}

/***** Globals *****/
static mxc_i2c_req_t g_req = {
        .i2c = I2C_INSTANCE,
        .addr = ADDR_RH,
        .rx_buf = NULL,
        .rx_len = 0,
        .tx_buf = NULL,
        .tx_len = 0,
        .callback = DMA_Callback
    };

/***** Functions *****/
// Utility function for resetting flags and launching the I2C DMA transaction
static inline int launch_DMA_Transaction(void)
{
    g_dma_complete = false;
    g_dma_status = E_NO_ERROR;
    int err = MXC_I2C_MasterTransactionDMA(&g_req, MXC_DMA);
    return err;
}

int MS8607_Reset(void)
{
    uint8_t tx_buf = MS8607_CMD_RESET_RH;
    g_req.addr = ADDR_RH;
    g_req.tx_buf = &tx_buf;
    g_req.tx_len = 1;
    int err = launch_DMA_Transaction();
    MXC_Delay(MXC_DELAY_MSEC(15));
    return err;
}

int MS8607_MeasureRH_NoHold(double *out_RH)
{
    uint8_t tx_buf = MS8607_CMD_MEASURE_RH_NOHOLD;
    uint8_t rx_buf[3] = { 0, 0, 0 };

    // Send command
    g_req.addr = ADDR_RH;
    g_req.tx_buf = &tx_buf;
    g_req.rx_buf = NULL;
    g_req.tx_len = 1;
    g_req.rx_len = 0;
    int err = launch_DMA_Transaction();
    while(!g_dma_complete) {} // Wait for command to be sent

    do {
        MXC_Delay(MXC_DELAY_MSEC(2));
        // ^ RH measurement seems to take about 15ms.
        // If we constantly spam the MS8607 with polling reads then
        // the measurement will never finish.  It needs some space to
        // perform the calculations, so we delay ~2ms between each poll.
        g_req.tx_len = 0;
        g_req.rx_len = 3;
        g_req.rx_buf = rx_buf;
        err = launch_DMA_Transaction();
        while(!g_dma_complete) {} // Wait for read to complete.
    } while (g_dma_status != E_NO_ERROR && err != E_NO_ERROR);
    // ^ The MS8607 will NACK our read request if the measurement is not ready.
    // In that case, the callback function will receive E_COMM_ERR and MXC_I2C_MasterTransactionDMA
    // will return E_COMM_ERR.  We want to keep re-trying until the sensors ACKs our read request.

    uint16_t D3 = rx_buf[0] << 8 | (rx_buf[1] & 0b11111100);
    int16_t RH = -600 + 12500 * (D3 / (pow(2, 16)));
    *out_RH = RH / 100.0f;
    return err;
}

// *****************************************************************************
int main(void)
{
    MXC_I2C_Init(I2C_INSTANCE, true, ADDR_RH);
    MXC_I2C_SetFrequency(I2C_INSTANCE, 400000);
    MXC_I2C_DMA_Init(I2C_INSTANCE, MXC_DMA, true, true);

    int err = MS8607_Reset();
    if (err) {
        printf("Failed to reset MS8607, error %i\n", err);
        return err;
    }

    double RH = 0;
    err = MS8607_MeasureRH_NoHold(&RH);
    if (err) {
        printf("RH Measurement error %i\n", err);
    } else {
        printf("RH Success, result: %.2f%%\n", RH);
    }
}

@Jake-Carter That's great news - thanks for looking at this. I'll try to test it out early next week.

@Jake-Carter to quickly test this on a MAX32666, I modified the MXC_DMA_Handler always call MXC_DMA_RevA_Handler passing in MXC_DMA0 as the argument.
I was able to run your example app on my custom board, and it works.
To test continuous RH conversions, I added a while loop around the calls to reset & measure RH, with a 1 second delay at the end of the loop, and found that after the first RH conversion, the g_dma_status and err are always both E_COMM_ERR. But moving the reset to happen only once, before the while loop fixes this problem. So I don't really know if it is a problem with the peripheral or with the I2C/DMA driver code.
Works:
int err = MS8607_Reset();
if (err) {
	printf("Failed to reset MS8607, error %i\n", err);
}

while (1) {
	double RH = 0;
	err = MS8607_MeasureRH_NoHold(&RH);
	if (err) {
		printf("RH Measurement error %i\n", err);
	} else {
		printf("RH Success, result: %.2f%%\n", RH);
	}
	MXC_Delay(MXC_DELAY_SEC(1));
}

Does not work:
while (1) {
	int err = MS8607_Reset();
	if (err) {
		printf("Failed to reset MS8607, error %i\n", err);
	}
	double RH = 0;
	err = MS8607_MeasureRH_NoHold(&RH);
	if (err) {
		printf("RH Measurement error %i\n", err);
	} else {
		printf("RH Success, result: %.2f%%\n", RH);
	}
	MXC_Delay(MXC_DELAY_SEC(1));
}

Prodded this a bit more, it was actually a problem with reusing the g_req during MS8607_Reset, after it had been used for the RH conversion. Once I fixed that up, it can run either way in a loop.

@sullivanmj great, thanks for testing!  Good catch on the reset function - I did not reset the RX-related fields.
int MS8607_Reset(void)
{
    uint8_t tx_buf = MS8607_CMD_RESET_RH;
    g_req.addr = ADDR_RH;
    g_req.tx_buf = &tx_buf;
    g_req.tx_len = 1;
    g_req.rx_buf = NULL; // <--- this should fix it in the loop
    g_req.rx_len = 0; //    <---
    int err = launch_DMA_Transaction();
    MXC_Delay(MXC_DELAY_MSEC(15));
    return err;
}

Working on a way to handle the handlers then will get this reviewed and merged.  Hopefully we've unblocked you in the meantime.  Let me know if there's any other issues

@sullivanmj FYI just went with a basic API for routing things to "hard" DMA handlers for DMA0/DMA1.  See https://github.com/analogdevicesinc/msdk/pull/1109/commits/7e8df444530b631010bddf427424a0f2d19bcd3d
Should have this reviewed and merged into main in the next couple days.


Nothing happens after running the app in Sonoma 14.4.1

Hi,
Did the installation per your instructions (system settings, open anyway, etc.).
Then ran the app. I can see the icon flashes once, then nothing happens. No icon on the menu bar.

Hello,
It seems to work ok for me on macOS 14.5. If there are no error messages then I'm not sure how to check what went wrong. Could you perhaps try opening it using the Terminal? I'm just hoping that that might print an error message.
Open the Terminal app and then run:
/Applications/Bluesnooze.app/Contents/MacOS/Bluesnooze

For me it asks for Bluetooth permissions, which I guess is granted automatically when run normally.
Did the original Bluesnooze work at all for you? https://github.com/odlp/bluesnooze
Maybe try older versions and see if any of them work?

Sorry I forgot to mention that mine is a Hackintosh... using a BCM943224 WiFi+BT card.
This might be outside the app's intended support hardware.
I apologize for that. Let me close the issue for now.


use generators when querying ledger and different file stores

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Error - cosmos db container deployment

Unable to parse request payload due to the following reason: 'Error converting value "/id" to type 'Microsoft.Azure.Documents.PartitionKeyDefinition'. Path 'partitionKey
I have created 3 Biceps file for
Cosmos DB account creation
Cosmos DB sql database support API
container creation
first two deployments worked fine
while running 3rd getting the error as above specifically for "partition key"
Attaching herewith the files 3 bicep & json parameters file for reference
cosmos-sqlcontainer.zip

Closing as dup of #6228


Loop protection - We have tried to solve 3 times in a row

I get this error:
Python 2.7.16 (default, Apr  6 2019, 01:42:57)
[GCC 8.2.0] on linux2
Type "help", "copyright", "credits" or "license" for more information.

import cloudscraper
scraper = cloudscraper.create_scraper(interpreter='nodejs')
scraper.recaptcha={  'provider': 'deathbycaptcha',  'username': 'xxx',  'password': 'yyy'}
contenido=scraper.get("http://arenavision.us/p81/cloud/servers/362ws/saz/xz/d3/2/few/ef/23/2e/wdc/df/events-guide").content
RuntimeError: !!Loop Protection!! We have tried to solve 3 time(s) in a row.

SSL Version:

import ssl
ssl.OPENSSL_VERSION
'OpenSSL 1.1.1c  28 May 2019'

Same in python3:
Python 3.7.3 (default, Apr  3 2019, 05:39:12)
[GCC 8.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.

import cloudscraper
scraper = cloudscraper.create_scraper(interpreter='nodejs')
scraper.recaptcha={ 'provider': 'deathbycaptcha', 'username': 'xxx', 'password': 'yyy'}
contenido=scraper.get("http://arenavision.us/p81/cloud/servers/362ws/saz/xz/d3/2/few/ef/23/2e/wdc/df/events-guide").content
RuntimeError: !!Loop Protection!! We have tried to solve 3 time(s) in a row.

SSL Version:
import ssl
ssl.OPENSSL_VERSION
'OpenSSL 1.1.1c 28 May 2019'

The last error was in Raspberry Pi 4. I have tested the same in a Google Cloud machine and I get this other one:
import cloudscraper
scraper = cloudscraper.create_scraper(interpreter='nodejs')
scraper.recaptcha={ 'provider': 'deathbycaptcha', 'username': 'xxx', 'password': 'yyy'}
contenido=scraper.get("http://arenavision.us/p81/cloud/servers/362ws/saz/xz/d3/2/few/ef/23/2e/wdc/df/events-guide").content
ERROR:root:Error executing Cloudflare IUAM Javascript. Cloudflare may have changed their technique, or there may be
a bug in the script.
Traceback (most recent call last):
File "", line 1, in
File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 501, in get
return self.request('GET', url, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/cloudscraper-1.2.16-py2.7.egg/cloudscraper/init.py", line 195, i
n request
resp = self.Challenge_Response(resp, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/cloudscraper-1.2.16-py2.7.egg/cloudscraper/init.py", line 428, i
n Challenge_Response
self.interpreter
File "/usr/local/lib/python2.7/dist-packages/cloudscraper-1.2.16-py2.7.egg/cloudscraper/init.py", line 309, i
n IUAM_Challenge_Response
getattr(e, 'message', e)
RuntimeError: Unable to parse Cloudflare anti-bots page: Missing Node.js runtime. Node is required and must be in t
he PATH (check with node -v).
Your Node binary may be called nodejs rather than node, in which case you may need to run apt-get install node js-legacy on some Debian-based systems.
(Please read the cloudscraper README's Dependencies section: https://github.com/VeNoMouS/cloudscraper#dependencies.
)

Sorry, I have installed cloudscraper in Google Cloud machine, including all dependencies nodejs, and then... same error in Google Cloud:
RuntimeError: !!Loop Protection!! We have tried to solve 3 time(s) in a row.

Just one consideration: this page is not permanent, so probably in one hour or two it will be UAM free

SOLVED!!
I was directing to http:// and the real web was https://
Just a "s" in https... so important sometimes.
Thank you for your attention!

Anyway... the page in http:// keeps serving the same error message. I have passed the problem because in https:// there is no UAM. So I don't know if the problem is relevant or it is not, in http://

The web was http until today. Now it seems to have gone https and all my programs suddenly have started to fail. It was the reason.
But If I try to access the web the old way -- i.e. http -- then it fails with the mentioned error. Thanks for averything!

SOLVED!!

I was directing to http:// and the real web was https://```

Refer #117 , This also addresses your issue @Fran008


LazyLoad support ?

Checks

[X] Not a duplicate.
[X] Not a question, feature request, or anything other than a bug report directly related to Vue Splide. Use Discussions for these topics: https://github.com/Splidejs/splide/discussions

Version
0.5.18 (vue-splide)
Description
As written in the documentation, I used the data-splide-lazy="path-to-image" with the lazyLoad: true option. The 2 first images are loaded but not the next ones.
The problem is that when scrolling to the next ones, a loading animation is displayed but the next images are not loaded and no request is made in the network tab.
Another problem I encountered, I couldn't catch the lazyload:loaded event with @lazyload:loaded
Reproduction Link
No response
Steps to Reproduce
Add multiple images to a vue-splide component with lazy-load enabled
Expected Behaviour
Lazy loads the images

It's working as I expected:
https://codesandbox.io/s/lazyload-p8isup

Thanks for the example ! But what about the lazyload:loaded event ?

The splide prefix is missing.
https://splidejs.com/integration/vue-splide/#events

thanks again !


Allow filtering of uncertain results

We should consider this in a body of "filter" functions for search and autocomplete results. See also #103.

Allowing a resultFilter function to be passed as an option when initialising would be really useful. Simple to implement and use.


fix(chart): update last modified in chart list

SUMMARY
Update last_saved_at to utcnow
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE
https://user-images.githubusercontent.com/10289162/200527693-faacb79b-80c0-47d0-9a62-63be73452bab.mov
AFTER
https://user-images.githubusercontent.com/10289162/200528412-e3a63b7c-df20-4dd3-877e-9514de4e7115.mov
TESTING INSTRUCTIONS
change timezone

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

@zhaoyongjie @villebro can you help with this review?

IMO, Although the utcnow() is a timezone-agnostic approach for the use case, the now() and utcnow() don't distinguish in the codebase.
So, I suggest that we should set the container/machine timezone instead of changing code logic.

Got it, thanks for your suggestion.


SIL: Remove consumption kind from unconditional casts.

@swift-ci test.

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - dac7b1178bb912d24672a08c906141ef667cf28c
Test requested by - @atrick

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - dac7b1178bb912d24672a08c906141ef667cf28c
Test requested by - @atrick

@swift-ci test.

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - dac7b1178bb912d24672a08c906141ef667cf28c
Test requested by - @atrick

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - dac7b1178bb912d24672a08c906141ef667cf28c
Test requested by - @atrick

@swift-ci test.

I'm sure this test was just using @in/@out as a convenient way to get an address value and wasn't really claiming to be correct about it.


Add support for writetimeout

Added support to specify timeout between writing temp files in S3 and calling upon Redshift to COPY. This fixes the issue caused by the eventual consistency of S3 S3ServiceException:The specified key does not exist.,Status 404,Error NoSuchKey when  trying to write a DataFrame to Redshift. The issue is described in more details here: https://github.com/databricks/spark-redshift/issues/136

any update about this? when this fix will be merge in the branch databricks:master?


Add wholebodydynamics device configuration files for all robots with a modern CPU in icub-head

For all iCub with a modern CPU in the head, we should be able to provide wholebodydynamics device (i.e. the device available in https://github.com/robotology/whole-body-estimators/pulls) xml files such as the one that are available for iCubGenova02 and iCubGenova04 . First of all, we should be able to get a list of the iCubs with modern CPUs.

Based on the analysis of internal documents, I think that the robots that do not have a pc104 but instead a modern icub-head in the robot head (and for this reason are suited for having a wholebodydynamics-device running insede the main yarprobotinterface instance) are:

YARP_ROBOT_NAME
wholebodydynamics conf files are already present?
Notes

iCubGenova02
✅

iCubDarmstadt01
❌

iCubGenova04
✅

iCubNottingham01
❌

iCubSheffield01
❌
No legs.

iCubHeidelberg01
❌
Only torso and legs.

iCubTwente01
❌

iCubErzelli01
❌

iCubLausanne02
❌

iCubNancy01
❌

iCubChemnitz01
❌
Head + Right arm

iCubSingapore01
❌

iCubGenova07
❌

iCubMoscow01
❌

iCubShenzhen01
❌

iCubHongKong01
❌

iCubGenova08
❌

Note this info are tentative are should be confirmed.
Thanks @Fabrizio69 for the precious info.

According to @Fabrizio69 , iCubHeildeberg01 still uses an old pc104 board, so for now I removed it from the list.


Hide calendar (focus mode)

Scrivener has a "Focus" mode in wich every tool and the whole UI is hidden, so the user can concentrate exclusively in writing. You can also do that on Rednotebook by dragging the divider to hide the calendar. I think this is a really useful feature, as it makes the experience more immersive. you could centralize the text entry space, just don't make it wider, as It's perfectly sized right now, in my opinion.

I was just thinking this would be nice as well. Thanks @caio-hungria


fix: mismatch between values and fields arrays and longToWide on …

…non aggregations

I proposed one more change, that I think helps with the case Islam most recently pointed out in slack.
Are there any remaining concerns with this PR?  For me the improvement to filter queries is very significant (basically useless/broken otherwise)


Action fails to run - Invalid regular expression: /*.exe/: Nothing to repeat

Behaviour
The GitHub Action to check a releases' files on VirusTotal always fails with
Invalid regular expression: /*.exe/: Nothing to repeat
Steps to reproduce this issue

Create new GitHub Action .yml as per instructions on https://github.com/marketplace/actions/virustotal-github-action#scan-assets-of-a-published-release
Publish a new release

Expected behaviour

The Action should run and update the release with the analysis report

Actual behaviour

Action fails with error

Invalid regular expression: /*.exe/: Nothing to repeat
Configuration

Repository URL (if public): https://github.com/tryallthethings/Discord-Disco
Build URL (if public): ?

name: VirusTotal release scan

on:
  release:
    types: [published]

jobs:
  virustotal:
    runs-on: ubuntu-latest
    steps:
      -
        name: VirusTotal Scan
        uses: crazy-max/ghaction-virustotal@v2
        with:
          vt_api_key: ${{ secrets.VT_API_KEY }}
          github_token: ${{ github.token }}
          update_release_body: true
          files: |
              *.exe

Logs

logs_6.zip

Little update: I modified my .yml yesterday to the exact .exe - filename. Now it works.
Does the *.exe maybe need some escaping?

I've now tried several was to escape the *.exe but I only get
´´´
No files were found. Please check the 'files' input.
´´´

Hi @tryallthethings

Does the *.exe maybe need some escaping?

*.exe is not a valid regular expression. Try wtih .exe$.

Thank you, it works! See PR #54


Consider changing repository configuration regarding pull request merging

When merging pull requests, the option "Create a merge commit" is currently disabled in this repository. I actually prefer that option, as it documents in the commit history which commits belong to larger pieces of work.
"Squash and merge" is currently enabled. I suggest disabling it, as that makes it easy to accidentally lose valuable history, especially since it's currently the default option. Whenever squashing commits is desirable, it's easy enough to do manually.
I'd also prefer to disable "Rebase and merge", due to my preference for merge commits. I don't feel strongly about this point.
cc @nrf-rs/team, especially @wez

I generally prefer merge commits as well. No opinion from me regarding squash and merge.

I agree that squash should go.  I personally prefer rebasing to keep history more linear (my day job is wrangling massive source control systems) but am fine with merging if that’s your collective preference.

@wez

I agree that squash should go. I personally prefer rebasing to keep history more linear (my day job is wrangling massive source control systems) but am fine with merging if that’s your collective preference.

I don't feel too strongly, and I realize that linear history has its benefits. I think the main problem right now is that "Merge" is disabled, and "Squash" is at the top of the list. I'm perfectly fine with leaving "Rebase" enabled, and could even live with "Rebase" being the only option :)

I've turned off squash, which effectively makes rebase the "default".  I've left merge out for now, but please don't hesitate to enable it if you have a situation where you want to merge.


No documentation about set custom transaction expired

Hello I am using midtrans for my business, and I have struggle finding how to define custom trx expire in ChargeReq.
I have try this one by reading the code of go-midtrans but this is not work, please help me by explain how to define custom
transaction expire in ChargeReq
req := &midtrans.ChargeReq{
		PaymentType: midtrans.SourceEchannel,
		MandiriBillBankTransferDetail: &midtrans.MandiriBillBankTransferDetail{
			BillInfo1: "complete payment",
			BillInfo2: "dept",
		},
                // how to set valid configuration for custom trx expire
		CustomExpiry: &midtrans.CustomExpiry{
			OrderTime:      trxTime.Format("2006-01-02 15:04:05 +0700"),
			ExpiryDuration: 1,
			Unit:           "HOUR",
		},
		TransactionDetails: midtrans.TransactionDetails{
			OrderID:  trxID,
			GrossAmt: grossAmt,
		},
		CustomerDetail: &midtrans.CustDetail{
			Phone: custPhone,
			FName: custName,
		},
		Items: &[]midtrans.ItemDetail{
			{
				ID:    itemID,
				Price: grossAmt,
				Qty:   1,
				Name:  itemName,
			},
		},
	}

Hi @muhammadisa Thank you for reaching out to us.
could you elaborate on this => but this is not work, return an error or what? the code looks good.
note for CustomExpiry:
almost all value in the OrderTime are equal to transaction time, you can remove this field
thank you

Hi @omarxp the last I tried using HOUR unit is not work, and the result in midtrans dashboard looks not same with the custom expiry that I set, but when I changed the unit to MINUTE and set ExpiryDuration to 120, its works maybe there is an logic error, but using MINUTE unit its work for me.
CustomExpiry: &midtrans.CustomExpiry{
	OrderTime:      trxTime.Format("2006-01-02 15:04:05 +0700"),
	ExpiryDuration: 120,
	Unit:           "MINUTE",
},


Set grid on NineTileBox

What could be improved
Allow the user to manually set the nine-tile grid sizes.
Why should this be improved
In many cases the user needs to use a grid size other than the default 1/3 3x3 grid.
Any risks?
Not that I can see. I have implemented and tested it in my own project and works well.
More information
I have implemented the feature already. See changes here
Any feedback helpful, especially:

Are the asserts overkill? I could instead adjust the user values to fit without overflowing
Where to add tests?
Update example here, or create new?
Aside from update, any change to docs required?

Good stuff, please put it up as a PR. :)

Are the asserts overkill? I could instead adjust the user values to fit without overflowing

Since you have already written them and they give some value to the user I think they can be kept.

Where to add tests?

You can add a new file here: https://github.com/flame-engine/flame/tree/main/packages/flame/test/components
It doesn't seem like the NineTileBoxComponent has any tests yet, only the widget.

Update example here, or create new?

I think you can create a new one to not cram to much stuff into the existing example.

Aside from update, any change to docs required?

Just explain how to use the newly added method.
Some other comments:

We don't allow abbrevations like rightCol, write out the full words.
It would be good to be able to set this directly from the constructor, so maybe create a class that contains these values ({int? leftCol, int? rightCol, int? topRow, int? bottomRow}) that can be passed in?
The method's dartdoc could explain a bit more what it does.


createReadStream from collection

Hello,
I try to use collection to read file form mongo.
My code:
var gfs = Grid(conn.db);
.....
gfs.collection('movies').find(where_condition).limit(1).toArray(function (err, file) {
var type='';
if(node_id && file[0])
{
var type=file[0]['type'];
                    if(type)
                    {
                        res.writeHead(200, {'Content-Type': type});
                        gfs.collection('movies').createReadStream({_id:ObjectID(file[0]['sid'])}).pipe(res);
                    }
                    else
                    {
                        res.writeHead(404, {"Content-Type": "text/html"});
						res.end();
                    }
                }
                else
                {
                    res.writeHead(404, {"Content-Type": "text/html"});
					res.end();
                }
            });

File is found but I have error:
TypeError: Object # has no method 'createReadStream'
But when i use it with no collection I have "record not found"
Any ideas?

The correct syntax is
gfs.createReadStream and not gfs.collection('movies').createReadStream
If you need to read or write from a different collection please see the root option as stated in the docs.


Fix an older version of setuptools

Coverage remained the same at 100.0% when pulling 0e9ca37b370ce36dd745ab23e8b8e9882e8da61c on fix_old_setuptools into 3bd5d0a612218091a9a32c63244f102b81941518 on master.


Defining a method in a header is now ugly (monospace)

Compare old: https://streams.spec.whatwg.org/commit-snapshots/26ba2c5de34c785778bc5ad3ca7d14eed7c6c4ef/#rs-prototype
with new: https://streams.spec.whatwg.org/#rs-prototype
I thought this might be because of our build post-processing step, but I removed that from console and it's still ugly.
At a minimum I think the section marker and the section number should stay in the normal font, even if the actual text of the header becomes monospace.

Ah, agreed, this is just the "wrap IDL stuff in <code>" getting a little trigger-happy.  I'll specially detect headers and avoid doing that.
(I can't even just move it down to the actual header text, as it might not be all code.  You can just use code directly if necessary, or autolinks in the text.)

Should be good now.

Hmm, I re-ran the build for whatwg/console and am still getting the ugly headers. Maybe this didn't deploy to the CSSWG servers?


Exception refreshing token with cmd

I am having an error which says Exception refreshing token with cmd.
2021-03-23 10:51:26.153: Exception refreshing token with cmd full_path/get_token.py.  Error: invalid syntax (<unknown>, line 1)
I have passed token with
dotnet Restler.dll test --grammar_file Compile/grammar.py \
             --dictionary_file Compile/dict.json \
             --settings Compile/restler_user_settings.json \
             --token_refresh_command "/full_path/token.py" \
             --token_refresh_interval 720

Can you show us the sample output of your token.py?

See https://github.com/microsoft/restler-fuzzer/issues/163.

Any suggestions? I tried to pass a simple .py file with manually printed text but still it is throwing same error.

Hi @Srijan619 , I think your token generation script is adding additional characters (may be space) at the end of the token. Probably instead of printing can you try returning the value?( just a trail). Also till that time you can hard code the access token in grmmar.py as follows
primitives.restler_static_string("Authorization: Bearer XXXXXXXXXXXXXXXXXXXXXXXXXXXX\r\n"),

@Srijan619 -
can you change your command from
/full_path/get_token.py
to use python to call the script ?
This is how we set up Token authentication in RAFT (we use dotnet executable and we have to specify it explicitly)
https://github.com/microsoft/rest-api-fuzz-testing/blob/27c7bad5d54174904559999ed59036da092eeb46/src/Agent/RESTlerAgent/AgentMain.fs#L263

I tried to give full path with python to call the plain script but it also failed.

Hi @Srijan619 , I think your token generation script is adding additional characters (may be space) at the end of the token. Probably instead of printing can you try returning the value?( just a trail). Also till that time you can hard code the access token in grmmar.py as follows
primitives.restler_static_string("Authorization: Bearer XXXXXXXXXXXXXXXXXXXXXXXXXXXX\r\n"),

Where to add that line, at the end of the request or after the end of endpoint like api/blog/add+ string?

It seems like the given token_refresh_command is executed with subprocess module in Python, which interprets scripts with /bin/sh by default.
There are two solutions for this:

Use Python to call the script: --token_refresh_command "python3 /full_path/token.py"
Add the Python shebang on the first line of token.py + make the script executable.

#!/usr/bin/env python3
import os

print("{u'app1': {}}")
print(f"Authorization: Bearer {os.getenv('TOKEN', 'token_not_found')}")

Great, thank you for confirming!