Filtered messages still show up in /mentions

Describe the bug
Using Filters, despite the fact that a filter properly removes the message from the chat, the message still shows up in your mentions tab if you are mentioned by it.
To reproduce

Add a filter
Add a highlight/mention involving that same filter
Have someone post a message containing said phrase
🥒

Screenshots

Chatterino version
cfcac99ae
Operating system

win10

This can be fixed by using a filter on the mentions tab as well.
(channel.name != "hasanabi" && (message.content contains "felan"))

WAI IMO, a filter belongs to a split in the UI, not a channel


Documentation cmake

@raysan5 I added some comments to describe the different sections of CMake. I also made some minor changes (mostly restructuring). I think this is enough refactoring on the build system and I will not do any more changes on it. Will look into the github actions though or some other raylib features.

@object71 Thank you very much! This is truly appreciated! I like reading commenting code, for me is the best way to learn! Thanks! :)

@object71 Thank you very much! This is truly appreciated! I like reading commenting code, for me is the best way to learn! Thanks! :)


Made checklist creation easier, and fixed a small bug

When an item is edited after searching, sometimes, it would not update in the app after the user went out of the list and coming back (though it would in the database).
I made the default item type for a new item the item type of the last item in items.
Closes #25

You don't need to include (see description) in the title. People should always read the description. Also please include the issue number in your description in the format: Closes #25

This is a more descriptive PR title 👍🏽 There is no need to include issue numbers in your PR titles. Include the issue number in the description with "closes"


10-32bit entering just f*cking don't work

First I apologize for the rudely language, but I tried to compile my 32bit entering code, And IT IS NOT WORKING, ALWAYS.
I tried to get information on OSDev wiki, but it seems that there are many ways of writing a 32bit pmode enterer, and I've got NO IDEA of WHICH WAY I'm GOING TO CHOOSE.
For example, in 32bit-switch.asm, the standard code in the tutorial looks like this:
[bits 16]

switch_to_pm:
    cli ; 1. disable interrupts
    lgdt [gdt_descriptor] ; 2. load the GDT descriptor
    mov eax, cr0
    or eax, 0x1 ; 3. set 32-bit mode bit in cr0
    mov cr0, eax
    jmp CODE_SEG:init_pm ; 4. far jump by using a different segment

[bits 32]
init_pm: ; we are now using 32-bit instructions
    mov ax, DATA_SEG ; 5. update the segment registers
    mov ds, ax
    mov ss, ax
    mov es, ax
    mov fs, ax
    mov gs, ax

    mov ebp, 0x90000 ; 6. update the stack right at the top of the free space
    mov esp, ebp

    call BEGIN_PM ; 7. Call a well-known label with useful code

but some of the tutorials looks like... say:
[bits 16]

switch_to_pm:
    cli ; 1. disable interrupts
    xor ax, ax   ; two more lines of code
    mov ds, ax
    lgdt [gdt_descriptor] ; 2. load the GDT descriptor
    mov eax, cr0
    or eax, 0x1 ; 3. set 32-bit mode bit in cr0
    mov cr0, eax
    jmp CODE_SEG:init_pm ; 4. far jump by using a different segment

[bits 32]
init_pm: ; we are now using 32-bit instructions
    mov ax, DATA_SEG ; 5. update the segment registers
    mov ds, ax
    mov ss, ax
    mov es, ax
    mov fs, ax
   ;  mov gs, ax, NO GS

    mov ebp, 0x90000 ; 6. update the stack right at the top of the free space
    mov esp, ebp

    call BEGIN_PM ; 7. Call a well-known label with useful code

Actually the os-tutorial source code and some of the third party src code both work, but none of them can jump to 32bit successfully.
I.. have no words. I can only raise up an issue here... I really don't know how you guys' code work.

I am sooooo sorry : ) Actually I just mentioned the '32bit protected mode' is printed on the top left corner,

Wait - There's a bug with GitHub... I cannot close this issue: You can't comment at this time — your comment cannot be blank.


⚠ Bofrost.lu has degraded performance

In 02de296, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1426 ms

Resolved: Bofrost.lu performance has improved in 9c648f1 after 13 minutes.


NewConstant naming causes slowdown when constant matrix gets too large

NewConstant uses the value itself as a name. It uses fmt.Sprintf("%v", v) as the name, to be specific. With large matrices(4000000 x 500) was my example, this can cause a significant amount of time spent in there
Perhaps the signature should be changed to this:
func NewConstant(v interface{}, name string, opts ...NodeConsOpt) *Node

Hi,
I think the function doesn't need additional parameters. One of the NodeConsOpt is setting the name. We only need to remove the fmt.Sprintf("%v", v) in the code and use the WithName directly.
Using the code will become:
NewContant(10, WithName("10"))
we can default the name field if it's not set or maybe return an error?

+1

Should I send a PR for this?

yes please

see #180 and let me know if this is what you would like. It is a rather simple change.

please add a check for names to not be "" somewhere. Appreciate the help.

I see! I thought the default value should be "". Do you want this check also inside the WithName function. That the name won't be assigned when it is empty?

The general rule of constants is that:

They are unique within a computation
They are not attached to a graph

Both are technically true of any input nodes as well (i.e. they are free
variables and unbound) but I only enforced it of constants because of the
use of constants
On 21 Dec. 2017 8:22 am, "Bart"<EMAIL_ADDRESS>wrote:

I see! I thought the default value should be "". Do you want this check
also inside the WithName function. That the name won't be assigned when
it is empty?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/gorgonia/gorgonia/issues/177#issuecomment-353186009,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAczUvOx9dkieMfzdfTtgMqaHFc-EKu_ks5tCXqigaJpZM4Qq7J3
.


⚠ Processors has degraded performance

In 938ab08, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 40 ms

Resolved: Processors performance has improved in 306e051.


[Python] Update tensorflow doc

Add documentation for using built-in TensorFlow model handlers.
Preview

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Whitespace PreCommit

R: @AnandInguva @damccorm

Check finished but not updated here, updated the PR description


test: add test for request_encoding

Signed-off-by: Meenal Trivedi<EMAIL_ADDRESS>This tests add the following sestets https://github.com/matrix-org/sytest/blob/develop/tests/10apidoc/01request-encoding.pl in Golang

Hi @callahad @Kegsay , please take a look at the following test I added.

Hi @callahad , please do take a look, I have done all requested changes and have squashed my commits 😄

I accidentally merged this to master here while trying to test out CI on a different origin. My apologies ☹ I'll finish reviewing and get this merged properly in just a sec.

Sure, no problem😅
On Sat, 3 Apr, 2021, 15:48 Dan Callahan, @.***> wrote:

I accidentally merged this to master here while trying to test out CI on a
different origin. My apologies ☹ I'll finish reviewing and get this
merged properly in just a sec.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/matrix-org/complement/pull/92#issuecomment-812845153,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AS2Y6XWFPUH6ECBLQM27QL3TG3TNTANCNFSM42HV2BRA
.


Added link to the THREDDS Catalog to the Collection object.

@huard
Looks good.
Another issue I faced trying to port changes in https://github.com/crim-ca/ncml2stac is that https://github.com/Ouranosinc/stac-populator/tree/collection_link/implementations is not under the source directory, so it cannot be imported by other utilities.

Should (?) be fixed via #25.


Add contributing.md in this repo

Assign me and I will fix all these issues

Hello, dear! managed to solve? comment there close as resolved if yes 🎉✨


Include src directory in package

So it would be possible to use "Go to implementation" and view ts source file instead of js file

@ptol please describe the required steps or send a PR.
Relevant https://github.com/gcanti/fp-ts/issues/223


Allow collapsing of directives at the top of a Razor file

Currently (AFAIK) we don't have our own outlining (folding range) areas but just mirror Roslyn and Html. We should considering adding something for the page directives at the top of a razor file, so they can all be collapsed together. At the very least, we should do it for the @using directives, if there are more than one, to mirror what Roslyn does for using directives in C#. There is a FoldingRangeKind of Imports in the LSP spec after all.

Currently in FoldingRangeEndpoint we only delegate to C# and Html. We can also add our own logic for Razor files, using the syntax tree to find the block of directives at the start of the file, and add a range for them (or one for every block? 🤷♂)


FoundryVTT v12 Support

This module is used almost religiously by several of my players, would love to see v12 Compatibility.

You might want to take a look at https://github.com/reonZ/pf2e-dailies which is fully maintained and up to date and has staves as part of its feature set

You might want to take a look at https://github.com/reonZ/pf2e-dailies which is fully maintained and up to date and has staves as part of its feature set

I'll have to look into that, does it allow for preparing more than one staff? And put a full spell list from the staff into the Player's spell list section?

does it allow for preparing more than one staff?

No, to my knowledge, it implements the RAW of 1 staff at a time.

put a full spell list from the staff into the Player's spell list section?

Yes, it adds a new spell entry to the Activations tab with all the spells on the staff.


Provide social authentication service for users

[proposal] Provide the User the option of:
Authenticate using facebook, twitter, github or gmail credential.
Any help is welcome. Thank you.

Authentication with facebook completed. A better implementation is welcome.
Please revise the app\LaracmsApp\Authentication\FacebookAuthentication class and try to come up with a better solution. Thank you.


Fix confusing error messages for called asserts

Fixes issue #58 so that the called error messages will print either 0 or >0 instead of nil for the expected call count.
describe("foo", function()
  it("bar", function()
    local func = spy.new(function() end);
    func();
    assert.spy(func).was_not.called();
  end)

  it("bar2", function()
    local func = spy.new(function() end);
    assert.spy(func).was.called();
  end)
end)

◼◼
0 successes / 2 failures / 0 errors / 0 pending : 0.0 seconds

Failure → foobar_spec.lua @ 2
foo bar
foobar_spec.lua:5: Expected to be called 0 time(s), but was called 1 time(s)

Failure → foobar_spec.lua @ 8
foo bar2
foobar_spec.lua:10: Expected to be called >0 time(s), but was called 0 time(s)

needs rebase

Just rebased


Sorting/filtering by inputs

It's useful to filter executions down by the value of certain inputs. For instance, if a workflow takes a region code as an input and is run frequently with different values for the region code, a user may want to only see executions using one given value of that code ("SEA").
This functionality will require a design spec, since workflows may have many inputs of varying types and indexing across those types and values is non-trivial.
Note: There is an internal design document that could be cleaned up and moved to public in order to provide guidance for this item.

Bug bankruptcy.

Bug bankruptcy.


Exclude nested fields with large data under Collection/Upload datasets

As a result of https://github.com/hubmapconsortium/entity-api/issues/767, we agreed upon a short-term solution to exclude the files, metadata, and ingest_metadata fields nested under Collection.datasets and Upload.datasets in entity-api. This will resolve the page loading issue in ingest-ui.
On the search-api side, the large files list would still cause failures when indexing Collections and Uploads with such datasets. Confirmed by IU and Harvard teams, they are not using files, metadata, and ingest_metadata fields nested under Collection.datasets and Upload.datasets from the search documents. So we'll be excluding them to reduce the document size.
https://portal.hubmapconsortium.org/browse/collection/14f93f4c97996eefd5779f6a29d3f13c can be used for verifying the results.

@kburke's before/after reindex comparisons:
DEV
# prior to excluding re-index, 4678 line response, after exclusion re-index 96 lines - Collection
GET /hm_dev_consortium_entities/_doc/0a120b03012a8fe839bdea4612429fe4

# prior to excluding re-index, 7753 line response, after exclusion re-index 5077 lines - Upload
GET /hm_dev_consortium_entities/_doc/12b812cbb0eb430f94385772d22855b2

TEST
# prior to excluding re-index, 1,299,744 line response, after exclusion re-index 695 lines - Collection
GET /hm_test_consortium_entities/_doc/a3f18562d549e49c4251f5ef2419882f

# prior to excluding re-index, 1,299,737 line response, after exclusion re-index 691 lines - Upload
GET /hm_test_consortium_entities/_doc/40d03365e87305b8d2ef92d267319762

Updates released to PROD. I reindexed Collection 14f93f4c97996eefd5779f6a29d3f13c to verify, it was 44 MB document, now only 323 KB. Will full reindex PROD data over the weekend.


Username not logged for logged in users in access log

Gitea version (or commit ref): 1.15.0+rc2
Operating system: Host: Ubuntu 20.04.02 running Gitea docker container
Database (use [x]):

[ ] PostgreSQL
[X] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[X] No

Access log entry of logged in user:
<IP_ADDRESS>:0 - - [02/Aug/2021:13:15:29 +0000] "GET /api/v1/user/stopwatches HTTP/1.1" 200 3 "" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.1.2 Safari/605.1.15"

Config:
[log]
MODE      = file
LEVEL     = info
ROUTER    = console
ROOT_PATH = /data/gitea/log
ENABLE_ACCESS_LOG = true
ENABLE_SSH_LOG = true
LOG_ROTATE = true
DAILY_ROTATE = true
MAX_DAYS = 90

oh yes I see... that's both interesting, annoying and I don't quite know what's happened there..

Hmm... fixing this is a bit more involved that I would have hoped.


restype = check_error causes problems on Windows environments

Hello,
I am currently porting a Python program using libxmp onto Windows 7 and I noticed that I got caught in an infinite loop that doesn't happen on my Linux environment (Ubuntu 14.04):
Using get_array_item to walk through a sequence is the culprit, and peculiarly the check_error call through the ctypes restype variable:
I dumped the value of the success parameter while executing the program and it seems like on a Windows environment, when xmp_get_array_item returns True, we get success = 1, but when xmp_get_array_item returns False, we get... something that is not 1 (various high int values), so the loop of XMPMeta.count_array_items goes on indefinitely.
I suspect this is due to the internals of ctypes and ctypes.WinDLL, but the solution I've implemented for now is the following one: replace the restype = check_error assignation by restype = ctypes.c_booland call the check_error function on the return value of xmp_get_array_item.
I've only done it for this function in my code, but it might be worth doing this kind of fix in the whole lib in order to enhance Windows compatibility.
Anyway it's up to you guys to decide if you think that's worth it !
Workaround code:
def get_array_item(xmp, schema, name, index):
    EXEMPI.xmp_get_array_item.restype = ctypes.c_bool
    EXEMPI.xmp_get_array_item.argtypes = [ctypes.c_void_p,
                                          ctypes.c_char_p,
                                          ctypes.c_char_p,
                                          ctypes.c_int32,
                                          ctypes.c_void_p,
                                          ctypes.POINTER(ctypes.c_uint32)]
    _item = _string_new()
    property_bits = ctypes.c_uint32(0)

    retVal = EXEMPI.xmp_get_array_item(xmp,
                              schema.encode('utf-8'),
                              name.encode('utf-8'),
                              ctypes.c_int32(index),
                              _item,
                              ctypes.byref(property_bits))

    check_error(retVal)
    item = string_cstr(_item)
    _string_free(_item)

    return item, property_bits.value

I've just noticed that a similar issue was described in issue #15, about old versions of exempi, but I'm using the latest exempi version available on GitHub (pulled from the master branch) on my Windows environment, so this current issue may still be valid.

Might have to ask you for your instructions on how to build exempi on windows so I can test it.  I've tried building it a few times, always gave up.

You're right, that was most definitely not a straightforward process.
I've set up a repo where I put all my Windows-compatible exempi directory : https://github.com/MaxyMoos/exempi-Win7-VS2013/
Here are the steps that lead to a successful compilation on my machine:
Everything was built with Visual Studio Express 2013 on Windows 7 (64-bit), so there might be some instructions that apply only to this specific version:
1- In /build/shared/CMakeUtils.bat, change
set GeneratorVersion = Visual Studio 11 to set GeneratorVersion = Visual Studio 12 (line 25)
and (lines 62 to 64):
if /I "%1"=="2011" (
echo "Generator VS 2011 specified"
set GeneratorVersion=Visual Studio 11

to:
if /I "%1"=="2013" (
echo "Generator VS 2013 specified"
set GeneratorVersion=Visual Studio 13

2- Add the zlib (1.2.8) headers and expat (2.1.1) lib folder in /third-party/zlib/ and /third-party/expat/
3- In /build, execute the GenerateXMPToolkitSDK_win.bat tool and use option 2 (Generate XMPSDKToolkit Dynamic Win32). The cmake build should now work and Visual Studio solutions should have been generated for XMPCore & XMPFiles.
4- Beginning the fun part: there are some modifications to be done in order to compile the XMPFiles solution:
In XMPFiles/source/FileHandlers/JPEG_Handler.cpp :
Add #include <algorithm> after all the other include instructions (else there's a conflict for the definitions of std::min and std::max)
And we need to add a few files that are missing from the project...
In the XMPFiles project, open the Solution Explorer and under XMPFiles / Header Files / Internal Headers:

Add under File Handlers: GIF_Handler.hpp
Add under Format Support: GIF_Support.hpp

And under XMPFiles / Source Files :

Add under File Handlers: GIF_Handler.cpp
Add under Format Support: GIF_Support.cpp

5- Compile both XMPFiles and XMPCore solutions
6- Create a new project libexempi in VS and add the following files from the /exempi folder to it:

exempi.cpp
xmp.h
xmp++.hpp
xmpconsts.h
xmperrors.h

In the project properties, add to the Include folders:

The pthread headers directory
The XMPCore and XMPFiles source directories
The exempi root directory
The /public folder of the exempi root dir

Add to the linker libraries folders:

The pthread lib directory
The /public/libraries/windows/Release directory, where your XMPCore and XMPFiles DLLs and .lib must have been generated

Add to the linker's Additional dependencies :

XMPFiles.lib
XMPCore.lib
pthreadVSE2.lib

Finally, in /public/XMP_Environment.h, add the following at the top of the file:
#define WIN_ENV 1
And last but not least: add DllExport around all functions in xmp.h and exempi.cpp.
I strongly recommend you get those two files from my repo as it:

Is not very interesting to copy/pasting DllExport statements... and I've done it already so take advantage
I encountered a problem with the CompareDateTime function call (linker issue that I didn't manage to solve), so to work around it, I duplicated all the necessary code in exempi.cpp

Don't forget to set the project configuration to generate a DLL and not a .exe or static lib and normally, you're good to go.
Hope that'll help !

A problem with check_error was corrected but Windows support isn't available (see #83) and the issue is quite old, so I'm closing this ; note for those that got exempi to compile on Windows that sharing / upstreaming the recipe could be welcome by Exempi upstream. Please free to reopen if the issue is re-demonstrated.


[1.3] [TC-RVCCLEANM-2.2] Test failing due to Status code is mismatching

Reproduction steps
Executed the below mentioned command to put DUT into a commissionable state
./chip-all-clusters-app
Once DUT reach the commissionable state sent below mentioned command on TH.
./chip-tool pairing onnetwork 1 20202021
After the successful commissioning Send the below commands

Read SupportedModes attribute of the RVC Run Mode cluster.

./chip-tool rvcrunmode read supported-modes 1 1
[1690177742.429087][6315:6317] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0054 Attribute 0x0000_0000 DataVersion: 551764487
[1690177742.429341][6315:6317] CHIP:TOO:   SupportedModes: 3 entries
[1690177742.429483][6315:6317] CHIP:TOO:     [1]: {
[1690177742.429540][6315:6317] CHIP:TOO:       Label: Idle
[1690177742.429595][6315:6317] CHIP:TOO:       Mode: 0
[1690177742.429658][6315:6317] CHIP:TOO:       ModeTags: 1 entries
[1690177742.429732][6315:6317] CHIP:TOO:         [1]: {
[1690177742.429791][6315:6317] CHIP:TOO:           Value: 16384
[1690
177742.429842][6315:6317] CHIP:TOO:          }
[1690177742.429892][6315:6317] CHIP:TOO:      }
[1690177742.429967][6315:6317] CHIP:TOO:     [2]: {
[1690177742.430020][6315:6317] CHIP:TOO:       Label: Cleaning
[1690177742.430070][6315:6317] CHIP:TOO:       Mode: 1
[1690177742.430188][6315:6317] CHIP:TOO:       ModeTags: 1 entries
[1690177742.430263][6315:6317] CHIP:TOO:         [1]: {
[1690177742.430320][6315:6317] CHIP:TOO:           Value: 16385
[1690177742.430374][6315:6317] CHIP:TOO:          }
[1690177742.430427][6315:6317] CHIP:TOO:      }
[1690177742.430501][6315:6317] CHIP:TOO:     [3]: {
[1690177742.430555][6315:6317] CHIP:TOO:       Label: Mapping
[1690177742.430605][6315:6317] CHIP:TOO:       Mode: 2
[1690177742.430664][6315:6317] CHIP:TOO:       ModeTags: 1 entries
[1690177742.430729][6315:6317] CHIP:TOO:         [1]: {
[1690177742.430784][6315:6317] CHIP:TOO:           Value: 16384
[1690177742.430901][6315:6317] CHIP:TOO:          }
[1690177742.430966][6315:6317] CHIP:TOO:      }

Read the CurrentMode attribute from the RVC Run Mode cluster.

./chip-tool rvcrunmode read current-mode 1 1
[1690203158.762178][18282:18284] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0054 Attribute 0x0000_0001 DataVersion: 468915105
[1690203158.762194][18282:18284] CHIP:TOO:   CurrentMode: 0

If CurrentMode is in Idle state, change the mode to non-idle mode(Cleaning)

./chip-tool rvcrunmode change-to-mode 1 1 1
[1690178355.021382][6358:6360] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0054 Command 0x0000_0001
[1690178355.021533][6358:6360] CHIP:TOO:   ChangeToModeResponse: {
[1690178355.021692][6358:6360] CHIP:TOO:     status: 0
[1690178355.021750][6358:6360] CHIP:TOO:    }

Read SupportedModes attribute of the RVC Clean Mode cluster.

./chip-tool  rvccleanmode read supported-modes 1 1
[1690182376.583260][14996:14998] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0055 Attribute 0x0000_0000 DataVersion:<PHONE_NUMBER>
[1690182376.583288][14996:14998] CHIP:TOO:   SupportedModes: 3 entries
[1690182376.583301][14996:14998] CHIP:TOO:     [1]: {
[1690182376.583304][14996:14998] CHIP:TOO:       Label: Vacuum
[1690182376.583307][14996:14998] CHIP:TOO:       Mode: 0
[1690182376.583311][14996:14998] CHIP:TOO:       ModeTags: 1 entries
[1690182376.583316][14996:14998] CHIP:TOO:         [1]: {
[1690182376.583319][14996:14998] CHIP:TOO:           Value: 16385
[1690182376.583322][14996:14998] CHIP:TOO:          }
[1690182376.583325][14996:14998] CHIP:TOO:      }
[1690182376.583331][14996:14998] CHIP:TOO:     [2]: {
[1690182376.583333][14996:14998] CHIP:TOO:       Label: Wash
[1690182376.583336][14996:14998] CHIP:TOO:       Mode: 1
[1690182376.583340][14996:14998] CHIP:TOO:       ModeTags: 1 entries
[1690182376.583344][14996:14998] CHIP:TOO:         [1]: {
[1690182376.583347][14996:14998] CHIP:TOO:           Value: 16386
[1690182376.583349][14996:14998] CHIP:TOO:          }
[1690182376.583352][14996:14998] CHIP:TOO:      }
[1690182376.583357][14996:14998] CHIP:TOO:     [3]: {
[1690182376.583360][14996:14998] CHIP:TOO:       Label: Deep clean
[1690182376.583362][14996:14998] CHIP:TOO:       Mode: 2
[1690182376.583366][14996:14998] CHIP:TOO:       ModeTags: 2 entries
[1690182376.583369][14996:14998] CHIP:TOO:         [1]: {
[1690182376.583372][14996:14998] CHIP:TOO:           Value: 7
[1690182376.583375][14996:14998] CHIP:TOO:          }
[1690182376.583378][14996:14998] CHIP:TOO:         [2]: {
[1690182376.583380][14996:14998] CHIP:TOO:           Value: 16384
[1690182376.583383][14996:14998] CHIP:TOO:          }
[1690182376.583385][14996:14998] CHIP:TOO:      }

Then try to change the mode to any mode listed in the SupportedModes attribute of the RVC Clean Mode cluster.

Actual Outcome:
./chip-tool  rvccleanmode  change-to-mode 2 1 1
[1705656302.541257][334243:334245] CHIP:DMG: Received Command Response Data, Endpoint=1 Cluster=0x0000_0055 Command=0x0000_0001
[1705656302.541266][334243:334245] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0055 Command 0x0000_0001
[1705656302.541290][334243:334245] CHIP:TOO:   ChangeToModeResponse: {
[1705656302.541298][334243:334245] CHIP:TOO:     status: 64
[1705656302.541301][334243:334245] CHIP:TOO:     statusText: Cannot change the cleaning mode during a clean
[1705656302.541304][334243:334245] CHIP:TOO:    }

Expected Outcome:
./chip-tool  rvccleanmode  change-to-mode 2 1 1
[1705656302.541257][334243:334245] CHIP:DMG: Received Command Response Data, Endpoint=1 Cluster=0x0000_0055 Command=0x0000_0001
[1705656302.541266][334243:334245] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0055 Command 0x0000_0001
[1705656302.541290][334243:334245] CHIP:TOO:   ChangeToModeResponse: {
[1705656302.541298][334243:334245] CHIP:TOO:     status: 3
[1705656302.541301][334243:334245] CHIP:TOO:     statusText: Cannot change the cleaning mode during a clean
[1705656302.541304][334243:334245] CHIP:TOO:    }

Bug prevalence
Whenever I do
GitHub hash of the SDK that was being used
b044b5e486a625fb68dd684317221c65b3fa61c7
Platform
raspi
Platform Version(s)
1.3
Summary:
As per Spec, When we try to change the mode for RVCCLEAN Mode while the RVC Run Mode cluster’s CurrentMode attribute is set to a mode without the Idle mode tag. The ChangeToModeResponse command SHALL have the StatusCode field set to the InvalidInMode value . But currently getting response as StatusCode field is Set to 64(0x40)
Anything else?
Specification References:

https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/app_clusters/Mode_RVCClean.adoc#8-mode-change-restrictions

Test Plan References:

https://github.com/CHIP-Specifications/chip-test-plans/blob/master/src/cluster/mode_rvc_clean.adoc#331-tc-rvccleanm-22-change-to-mode-restrictions-with-dut_server

Reference Log:
TC-RVCCLEANM-2.2.txt

Please note that there has been a change to the RVC Clean Mode cluster spec that introduce this new error. The test scripts are currently being updated. This update is being tracked by this issue.

Issue Fixed in commit f63b505179fd326c2cb5df91eed330ecd71a39b8. Hence closing this Issue.


Support for SHA512 algorithm

Please add support for the SHA512 algorithm. I tried to add TOTP for an account, but because it uses SHA512 I couldn't add it to Yubico Authenticator. Scanning the QR code gave a generic error and there's no option for SHA512 when adding manually.

SHA512 is supported and should be shown as an option when adding an account if the YubiKey supports it. Note that SHA-512 support is available on YubiKey 4.3.1 and later.

SHA512 is supported and should be shown as an option when adding an account if the YubiKey supports it. Note that SHA-512 support is available on YubiKey 4.3.1 and later.

I tried my newer YubiKey and it worked. Thank you.

I tried my newer YubiKey and it worked. Thank you.


Error: [vite]: Rollup failed to resolve import "@segment/analytics-next"

When I used the main branch, I encountered similar errors. After checking the issues, I learned that I should use the dev branch, but errors still occurred. Below are the commands I executed
git clone -b DEV https://github.com/neo4j-labs/llm-graph-builder.git
cd llm-graph-builder
cp example.env .env
sudo docker-compose up --build

The error log is as follows:
 => ERROR [frontend build 7/7] RUN BACKEND_API_URL=http://localhost:8000     RE  18.8s
------
 > [frontend build 7/7] RUN BACKEND_API_URL=http://localhost:8000     REACT_APP_SOURCES=local,youtube,wiki,s3,web     LLM_MODELS=diffbot,openai-gpt-3.5,openai-gpt-4o     GOOGLE_CLIENT_ID=     BLOOM_URL=https://workspace-preview.neo4j.io/workspace/explore?connectURL={CONNECT_URL}&search=Show+me+a+graph&featureGenAISuggestions=true&featureGenAISuggestionsInternal=true&search=Show+me+a+graph&featureGenAISuggestions=true&featureGenAISuggestionsInternal=true}     TIME_PER_CHUNK=4     CHUNK_SIZE=5242880     ENV=DEV     LARGE_FILE_SIZE=5242880     CHAT_MODES=     yarn run build:
0.537 yarn run v1.22.22
0.575 $ tsc && vite build
8.181 vite v4.5.3 building for production...
8.225 transforming...
10.19
10.19 warn - The safelist pattern `/^(hover:)?n-text-(palette|dark|light|primary|danger|warning|success|blueberry|mint|neutral)-/` doesn't match any Tailwind CSS classes.
10.19 warn - Fix this pattern or remove it from your `safelist` configuration.
10.19 warn - https://tailwindcss.com/docs/content-configuration#safelisting-classes
10.19
10.19 warn - The safelist pattern `/^(hover:)?n-bg-(palette|dark|light|primary|danger|warning|success|blueberry|mint|neutral)-/` doesn't match any Tailwind CSS classes.
10.19 warn - Fix this pattern or remove it from your `safelist` configuration.
10.19 warn - https://tailwindcss.com/docs/content-configuration#safelisting-classes
10.19
10.19 warn - The safelist pattern `/^(active:)?n-bg-(palette|dark|light|primary|danger|warning|success|blueberry|mint|neutral)-/` doesn't match any Tailwind CSS classes.
10.19 warn - Fix this pattern or remove it from your `safelist` configuration.
10.19 warn - https://tailwindcss.com/docs/content-configuration#safelisting-classes
10.19
10.19 warn - The safelist pattern `/^(hover:)?n-border-(palette|dark|light|primary|danger|warning|success|blueberry|mint|neutral)-/` doesn't match any Tailwind CSS classes.
10.19 warn - Fix this pattern or remove it from your `safelist` configuration.
10.19 warn - https://tailwindcss.com/docs/content-configuration#safelisting-classes
18.61 ✓ 2696 modules transformed.
18.61 ✓ built in 10.43s
18.61 [vite]: Rollup failed to resolve import "@segment/analytics-next" from<EMAIL_ADDRESS>18.61 This is most likely unintended because it can break your application at runtime.
18.61 If you do want to externalize this module explicitly add it to
18.61 `build.rollupOptions.external`
18.62 error during build:
18.62 Error: [vite]: Rollup failed to resolve import "@segment/analytics-next" from<EMAIL_ADDRESS>18.62 This is most likely unintended because it can break your application at runtime.
18.62 If you do want to externalize this module explicitly add it to
18.62 `build.rollupOptions.external`
18.62     at viteWarn (file:///app/node_modules/vite/dist/node/chunks/dep-41cf5ffd.js:48216:27)
18.62     at onwarn (file:///app/node_modules/@vitejs/plugin-react/dist/index.mjs:266:9)
18.62     at onRollupWarning (file:///app/node_modules/vite/dist/node/chunks/dep-41cf5ffd.js:48245:9)
18.62     at onwarn (file:///app/node_modules/vite/dist/node/chunks/dep-41cf5ffd.js:47976:13)
18.62     at file:///app/node_modules/rollup/dist/es/shared/node-entry.js:24276:13
18.62     at Object.logger [as onLog] (file:///app/node_modules/rollup/dist/es/shared/node-entry.js:25950:9)
18.62     at ModuleLoader.handleInvalidResolvedId (file:///app/node_modules/rollup/dist/es/shared/node-entry.js:24862:26)
18.62     at file:///app/node_modules/rollup/dist/es/shared/node-entry.js:24822:26
18.71 info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
18.71 error Command failed with exit code 1

failed to solve: process "/bin/sh -c BACKEND_API_URL=$BACKEND_API_URL     REACT_APP_SOURCES=$REACT_APP_SOURCES     LLM_MODELS=$LLM_MODELS     GOOGLE_CLIENT_ID=$GOOGLE_CLIENT_ID     BLOOM_URL=$BLOOM_URL     TIME_PER_CHUNK=$TIME_PER_CHUNK     CHUNK_SIZE=$CHUNK_SIZE     ENV=$ENV     LARGE_FILE_SIZE=${LARGE_FILE_SIZE}     CHAT_MODES=$CHAT_MODES     yarn run build" did not complete successfully: exit code: 1

Hi @lissettecarlr thanks for pointing out we will try to replicate.

we informed nvl team they are at this

Achieve a temporary fix by making these changes:
frontend/package.json
    "@neo4j-nvl/base": "0.3.1", # Removed '^'
    "@neo4j-nvl/react": "0.3.1", # Removed '^'

frontend/Dockerfile
WORKDIR /app
COPY package.json yarn.lock ./
# RUN yarn add @neo4j-nvl/base @neo4j-nvl/react # Remove or comment this line
RUN yan cache clean # Don't know if this is needed, but added anyway
RUN yarn install
COPY . ./

Hi @elheremes Did you get any type errors after you tried docker-compose

Hi @elheremes Did you get any type errors after you tried docker-compose

No errors after these changes.

@elheremes Your node version?

@elheremes which node version you are using?

I'm pretty certain its node:20, didn't change any of that. Going to post the entire content of the Dockerfile and package.json I'm using:
package.json
{
  "name": "neo4j-needle-starterkit",
  "private": true,
  "version": "1.0.0",
  "type": "module",
  "scripts": {
    "dev": "vite --host <IP_ADDRESS>",
    "build": "tsc && vite build",
    "format": "prettier --write \"**/*.{ts,tsx}\"",
    "lint": "eslint --ext .ts --ext .tsx . --report-unused-disable-directives --max-warnings 0",
    "preview": "vite preview"
  },
  "dependencies": {
    "@emotion/styled": "^11.11.0",
    "@mui/material": "^5.15.10",
    "@mui/styled-engine": "^5.15.9",
    "@neo4j-devtools/word-color": "^0.0.8",
    "@neo4j-ndl/base": "^2.11.6",
    "@neo4j-ndl/react": "^2.15.10",
    "@neo4j-nvl/base": "0.3.1",
    "@neo4j-nvl/react": "0.3.1",
    "@react-oauth/google": "^0.12.1",
    "@types/uuid": "^9.0.7",
    "axios": "^1.6.5",
    "clsx": "^2.1.1",
    "eslint-plugin-react": "^7.33.2",
    "neo4j-driver": "^5.14.0",
    "re-resizable": "^6.9.16",
    "react": "^18.3.1",
    "react-dom": "^18.3.1",
    "react-icons": "^5.2.1",
    "react-markdown": "^9.0.1",
    "react-router": "^6.23.1",
    "react-router-dom": "^6.23.1",
    "remark-gfm": "^4.0.0",
    "tailwind-merge": "^2.3.0",
    "uuid": "^9.0.1"
  },
  "devDependencies": {
    "@types/node": "^20.11.10",
    "@types/react": "^18.2.15",
    "@types/react-dom": "^18.2.7",
    "@typescript-eslint/eslint-plugin": "^6.0.0",
    "@typescript-eslint/parser": "^6.0.0",
    "@vitejs/plugin-react": "^4.0.3",
    "autoprefixer": "^10.4.17",
    "eslint": "^8.45.0",
    "eslint-config-prettier": "^8.5.0",
    "eslint-plugin-react-hooks": "^4.6.0",
    "eslint-plugin-react-refresh": "^0.4.3",
    "postcss": "^8.4.33",
    "prettier": "^2.7.1",
    "react-dropzone": "^14.2.3",
    "tailwindcss": "^3.4.1",
    "typescript": "^5.0.2",
    "vite": "^4.5.3"
  }
}

Dockerfile
# Step 1: Build the React application
FROM node:20 AS build

ARG BACKEND_API_URL="http://localhost:8000"
ARG REACT_APP_SOURCES=""
ARG LLM_MODELS=""
ARG GOOGLE_CLIENT_ID=""
ARG BLOOM_URL="https://workspace-preview.neo4j.io/workspace/explore?connectURL={CONNECT_URL}&search=Show+me+a+graph&featureGenAISuggestions=true&featureGenAISuggestionsInternal=true"
ARG TIME_PER_CHUNK=4
ARG TIME_PER_PAGE=50
ARG LARGE_FILE_SIZE=5242880
ARG CHUNK_SIZE=5242880
ARG CHAT_MODES=""
ARG ENV="DEV"

WORKDIR /app
COPY package.json yarn.lock ./
# RUN yarn add @neo4j-nvl/base @neo4j-nvl/react
RUN yarn cache clean
RUN yarn install
COPY . ./
RUN BACKEND_API_URL=$BACKEND_API_URL \
    REACT_APP_SOURCES=$REACT_APP_SOURCES \
    LLM_MODELS=$LLM_MODELS \
    GOOGLE_CLIENT_ID=$GOOGLE_CLIENT_ID \
    BLOOM_URL=$BLOOM_URL \
    TIME_PER_CHUNK=$TIME_PER_CHUNK \
    CHUNK_SIZE=$CHUNK_SIZE \
    ENV=$ENV \
    LARGE_FILE_SIZE=${LARGE_FILE_SIZE} \
    CHAT_MODES=$CHAT_MODES \
    yarn run build

# Step 2: Serve the application using Nginx
FROM nginx:alpine
COPY --from=build /app/dist /usr/share/nginx/html
COPY nginx/nginx.conf /etc/nginx/conf.d/default.conf

EXPOSE 8080
CMD ["nginx", "-g", "daemon off;"]

Sorry if I'm not responding clearly, I don't have much experience using docker environments.

Thanks for the help，I tried modifying frontend/package.json and frontend/Dockerfile, but the error message during the build remained unchanged.
vim frontend/package.json

"@neo4j-nvl/base": "^0.3.2"   ->  "@neo4j-nvl/base": "^0.3.1",
"@neo4j-nvl/react": "^0.3.2", ->  "@neo4j-nvl/base": "^0.3.1",

and
vim frontend/Dockerfile

# Step 1: Build the React application
FROM node:20 AS build

ARG BACKEND_API_URL="http://localhost:8000"
ARG REACT_APP_SOURCES=""
ARG LLM_MODELS=""
ARG GOOGLE_CLIENT_ID=""
ARG BLOOM_URL="https://workspace-preview.neo4j.io/workspace/explore?connectURL={CONNECT_URL}&search=Show+me+a+graph&featureGenAISuggestions=true&featureGenAISuggestionsInternal=true"
ARG TIME_PER_CHUNK=4
ARG TIME_PER_PAGE=50
ARG LARGE_FILE_SIZE=5242880
ARG CHUNK_SIZE=5242880
ARG CHAT_MODES=""
ARG ENV="DEV"

WORKDIR /app
COPY package.json yarn.lock ./
RUN yarn cache clean :q
RUN yarn install
COPY . ./

RUN BACKEND_API_URL=$BACKEND_API_URL \
    REACT_APP_SOURCES=$REACT_APP_SOURCES \
    LLM_MODELS=$LLM_MODELS \
    GOOGLE_CLIENT_ID=$GOOGLE_CLIENT_ID \
    BLOOM_URL=$BLOOM_URL \
    TIME_PER_CHUNK=$TIME_PER_CHUNK \
    CHUNK_SIZE=$CHUNK_SIZE \
    ENV=$ENV \
    LARGE_FILE_SIZE=${LARGE_FILE_SIZE} \
    CHAT_MODES=$CHAT_MODES \
    yarn run build

# Step 2: Serve the application using Nginx
FROM nginx:alpine
COPY --from=build /app/dist /usr/share/nginx/html
COPY nginx/nginx.conf /etc/nginx/conf.d/default.conf

EXPOSE 8080
CMD ["nginx", "-g", "daemon off;"]

I only modified these two places above, then compiled, and the error log was exactly the same as before.

Hi @lissettecarlr and @elheremes
As temporary fix add nvl packages in resolutions in package.json and remove
yarn add @neo4j-nvl/base @neo4j-nvl/react
from frontend docker
For the references check Branch
EX:
  "resolutions": {
    "@neo4j-nvl/base": "0.3.1",
    "@neo4j-nvl/react":"0.3.1"
  }

I used the new branch: origin/Concurrent-Processing-of-files, and successfully deployed it with Docker.
Thanks~

I used the new branch: origin/Concurrent-Processing-of-files, and successfully deployed it with Docker. Thanks~

can confirm. default branch docker will not build. new branch builds without error

Yes DEV version is updated with these changes

Hi, I updated my package.json with the one in DEV branch but keep having same problem, I did clean install remove cache etc, is there anything else that require changes?

Hey @maxlawdify NVL team released the 0.3.3 version they resolved all the issues. refer to the DEV branch package.json and vite.config.ts for successfully building the project.


Can't change site/course title

Steps to Reproduce

Create a new (course) site
Add enough content to publish to staging
Confirm that the stage site's title is the one you choose at creation time
In studio, go to the site metadata section and change the title to something else
Publish to staging

Expected Behavior

The published site's title should be the same as what is in course metadata

Actual Behavior

The published site's title doesn't change. It remains the same as when the site was created.

@pdpinch is this still happening for you?  I just modified a title for my site on RC and that title was displayed after a subsequent publish: https://ocw-draft-qa.global.ssl.fastly.net/courses/mb-april-5-site/

Ok, looks like I was wrong about this.
I'll open a new issue for changing the title in the studio site listing, assuming that's possible.


[User Profile] Handle an error scenario where the submission fails

I believe we have a lot more error handling around uploads/submissions, but didn't want to close this till you got a chance to look at it @shindigira.


Does perPage work with AJAX data?

Just found this and I've been trying to make this work with my table that get its data using AJAX.
It appears to hide the columns when they're empty but the columns don't come back if I navigate back to a page where they're not empty.
For the columns to show again I have to refresh the page.
I've copied the bit from the example for perPage the only difference seems to be that I'm loading the data with AJAX instead of it already being on the page.
Is there something I could have missed?
Here's how I've created the table if it's any help:

    $(document).ready(function () {
        var oTable = $('#e-table').dataTable({
            columns: [
                {title: "Name"},
                {title: "Serial Number"},
                // Some more columns generated by PHP
            ],
            serverSide: true,
            "bInfo": false,
            "bLengthChange": false,
            "pageLength": 15,
            "oLanguage": {
            "sZeroRecords": "Nothing to display",
                    "sSearch": ""
            },
            hideEmptyCols: {
                columns: <?php echo $columnsToHide; ?>,
                perPage: true
            },
            "ajax": '/ajax_table/'
        });
    });

The data returned from /ajax_table/ is just as the dataTables spec says it should be.

Hey Mike,
Thanks for using the plugin and opening the ticket, and I apologize for the response delay. I had to take a break from personal projects like this, due to the demands in my professional career.
I will work on this and see whats causing the issue, then update you asap!

No probs! If there's anything else you need from me, let me know.
There's no big rush for it, it's a 'nice to have' :)

Nobody handled that so far?

I'll try to verify this later, but @mikeee324, have you looked at the change submitted by @AlexeyKosov?
Ill merge it to master in just a bit. Thanks for the contribution AlexeyKosov! I think thats the first time someones actually contributed to one of my repositories, lol.

@mikeee324 I just merged the pull request from @AlexeyKosov, and committed an example of a datatable using an ajax source and this plugin. Let me know if you have any other questions/issues


i18n in shared folder

Description
Changes proposed in this pull request:

...
...
...

Related issue(s)

/retest


weather.for(time) problem

Hi Mark,
Thanks for the gem, I love it.  This is the first time I'm using the weather.for part of the gem and I am getting a nil back even when using your example.   The only time it does work is when I pass in the current time.
I have pasted some output here: https://gist.github.com/1147675
Thanks again

Barometer doesn't retrieve results for historical weather, only from the current and forecasted data returned from each weather service.  Thus, weather.for can only be used to get results from the set of returned results.


I cannot add a song in source code!

Describe your problem here.
When i try to add a song in source code, and when i try to play it, it crashes.
I tried adding both .OGG and .MP3 files [html uses mp3], i tried adding it in a week on the files, it simply did not work in anyway at all.
Do i need to do something extra?
Are you modding a build from source or with Lua?
Source
What is your build target?
HTML5/Browser
Did you edit anything in this build? If so, mention or summarize your changes.
Editing Donate in StoryMenuState.hx to play the song im talking about.

You usually want to make the song, you need these files listed for the song to work inside of either the songs/your-song-name/ or data/your-song-name, depending on if it's sound or data: Inst.ogg,Voices.ogg,Inst.mp3, and Voices.mp3 , and the song data that matches the name of the folder that it's in, aka the song name in the files, for example, winter-wonderland , with .json at the end of it., difficulties can be added with the addition before the .json, like for example, `philly-nice-hard'.

Thanks, but that was already done, turns out the song name was just broken.
But now, i am stuck in the loading screen, what does that mean?
My possible theories is that the character is not loading.

I found the problem, but then theres another problem.
Somehow, it could not load the song files that i previously had put, i tried replacing them with another one, which is a random song in the source code, and it loaded.

Did it do the countdown?

If it did, then there is nothing to load on the screen


AtomicReconciler semantically incorrect

hi,
in the code of the AtomicReconciler you can see the pattern:
for i := 0; i < len(r.model.Resources()); i++ {
    resource := r.model.Resources()[i]

where model.Resources() returns a map[int]Resource.  The upper code only works, if the map is really an array, so the key's in the map are identically to the list of 0..len(r.model.Resources()).
Suppose you have a map like:
{
  10 : ressource1,
  20 : ressource2
}

if you use the upper loop, you will loop from 0..1 and use these two numbers as keys in the map, but this won't work, as the keys in the map in this example are 10 and 20.
you should either use a return type of []Resource for the model.Resource() function or use the range keyword to iterate over the map and get the correct keys. i think the current code is semantically incorrect.
yeah, you are creating the model's with consecutive numbers, but this is an implemetation issue, which is not guaranteed by the signature of the type. and it is very strange if you want to understand the code, to see constructs like this :-)

Hi, so this is a reflection of our migration strategy and not our inability to understand Go.
We know it's weird, and we are working on refactoring it. #572 was the first step in this effort.


Guru Creation Request: PrimeFaces

GitHub: https://github.com/primefaces/primefaces
Maintainer: yes

Hey @melloware
Do you have a Gurubase account that I can assign the PrimeFaces Guru once I create it?

I just created a gurubase account with my GitHub melloware account.


[CLI] SIFT Installation

Hello! i am trying to install SIFT on my laptop and cannot seem to make it past the mv sift-cli-linux /usr/local/bin/sift part I included a screen shot of my terminal to show the error I'm receiving.
I am pretty new to Linux and totally sure I'm messing something up. I followed your responses to a user with a similar issue but still to no luck. Thank you ahead of time. I really appreciate your assistance!!!!

As a side note, I have the two release files located on my desktop

sudo mv

Thank you! I made it through step 7!!! Stupid question: where to now?

I think I got it??

 Sorry for taking your time and expertise, still new to a lot of this!!

If you are building SIFT yourself, you do not need the file on the SANS website.


MockClassLoader#loadMockClass fails to preserve original ProtectionDomain of classes prepared for test

From<EMAIL_ADDRESS>on March 09, 2015 19:33:10
What steps will reproduce the problem? 1. Try to use another bytecode manipulation tool together with PowerMock, for example, JaCoCo. What is the expected output? What do you see instead? The other tool should still be able to properly instrument classes that got prepared for test by PowerMock. Doing so might require that the original ProtectionDomain of the prepared class be preserved in the copy generated by MockClassLoader. JaCoCo, in particular, checks that the ProtectionDomain of each class has a code source location, to determine whether it's a legitimate ".class" file from the codebase, or a dynamically generated class which only exists at runtime (and therefore should not be instrumented for coverage).
This can affect other tools, such as JMockit Coverage. What version of the product are you using? On what operating system? PowerMock 1.6.1, on Windows 7 (the OS or JDK version should not matter here). Please provide any additional information below. There is already a JaCoCo issue open: https://github.com/jacoco/jacoco/issues/294 I believe the fix should be relatively simple: PowerMock will need to save somewhere the ProtectionDomain of each class prepared for test (say, in a Map<String, ProtectionDomain>) of prepared class names), so that it can recover the PD and pass it in the call to "ClassLoader#defineClass" at the end of "loadMockClass". This should solve the problem without any backward-compatibiliy issues.
Original issue: http://code.google.com/p/powermock/issues/detail?id=544

From<EMAIL_ADDRESS>on July 07, 2015 07:47:15
Any idea when this issue might be addressed?

Is this bug something which may get fixed soon?  it's quite frustrating not being able to use such a useful and flexible tool as powermock with jacoco, which is our and sonar's chosen coverage tool.

Please help out if you know how to modify the classloader to achieve this. Or if you find any resources that can help me solving it.

Hello, I believe this commit: https://github.com/astafev/powermock/commit/6f32a1e97ea647cf67aada6a2259b07d5e32d6c7 fixes the issue. May I ask you to review/adopt it?

Please add it as a pull request.

Looks like it has been added to the master branch.
I would like to use this feature but I am getting error while fetching the 1.6.4-SNAPSHOT version. Here are the details of the error:
[ERROR] Failed to execute goal on project spoon-client: Could not resolve dependencies for project com.squareup.spoon:spoon-client:jar:1.2.1-SNAPSHOT: Could not find artifact org.powermock:powermock-api-mockito:jar:1.6.4-SNAPSHOT in sonatype-nexus-snapshots (https://oss.sonatype.org/content/repositories/snapshots) -> [Help 1]
Please suggest how can I get this fix working for my application.

I haven't published a snapshot with this feature included yet.

Hi I am still experiencing the problem with version 1.6.4 of PowerMock, I am trying in on an Android project, PowerMock with EasyMock, launching tests with PowerMockRunner.
Result is still 0% code coverage.

I don't develop for Android, could you share sample project and instructions to reproduce the problem?

Hi !
Here is a sample project which shows the problem :
Github sample
I wrote a first analysis in Readme file

Hi, as far as I see, the reason is different from current thread, take a look here: https://github.com/jacoco/eclemma/issues/15. Probably, it can't be fixed, at least not on powermock side.
May I ask to check the following: replace class2 in Class1Test.java with real implementation and check if Class2 will be covered in resulting report. If everything goes fine, Class2 should be covered with powermock version 1.6.4.

6f32a1e97 only seems to preserve the protection domain for unmocked classes, which unfortunately means we can't get the protection domain of the class under test (which MockClassLoader considers mocked).  Perhaps my real question is "why is the class under test considered mocked" (i.e. not applicable to this thread), but is there any reason why the protection domain isn't preserved for the mocked class too (glancing at ClassLoader.defineClass(), any reason for not passing the ProtectionDomain along isn't obvious)?

@jameyg42 hi

which unfortunately means we can't get the protection domain of the class under test (which MockClassLoader considers mocked)

I either didn't understand that, or disagree, if you're "preparing for test" class under test, then yes, but it's not necessary.
According to my understanding of protection domain concept, providing it to mocked class isn't right. Besides it won't help to get coverage from jacoco.
If I remember it right it's because jacoco compares hashes of class in runtime and class in filesystem and that hashes will be different.


Add support for optional client authentication on TLS

Fixes #6900

@jon-wei Could you please review this?


fix typo

@loosely-coupled : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thanks for the typo fix @loosely-coupled.


Unable to run this project

Hi, when i try to download and run the project it throws following error message.
Exception in thread "main" java.lang.IllegalArgumentException: Neither port nor sslPort specified. Use command line options -port/-sslPort or configure connectors in application.conf

I don't use ssl in this project. You can refer to ktor official document


Fixes #4286 - Contributions didn't appear after logging in again

Description (required)
Fixes #4286
What changes did you make and why?
The issue was because after logging in again, the previous username key with boolean false is not removed from the continuationStore map, that is why it is returning the empty list. Now I have added a method that will remove and reset the existing key, and it will be called when the list has no items in the User's Contribution.
Tests performed (required)
Tested betaDebug on Pixel 3 with API level 29.

Hey @nicolas-raoul, Can you test this solution as you are facing a quite different issue but I think this might solve that issue too. It is working fine in my case. Thanks!

Seems solved 🙂
On Wed, 7 Apr 2021, 18:04 Pratham Pahariya, @.***>
wrote:

Hey @nicolas-raoul https://github.com/nicolas-raoul, Can you test this
solution as you are facing a quite different issue but I think this might
solve that issue too. It is working fine in my case. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/commons-app/apps-android-commons/pull/4337#issuecomment-814741251,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAYKBTAXSKIDUIN5ADBRU3THQN2DANCNFSM42QLUARQ
.

Well, currently on master I reproduced this issue once but I had one very normal login too, so the issue is unstable. However, on this branch (both on beta and prod) I reproduced the weird issue reported by @nicolas-raoul in issue page (very old contributions comes to top). I don't think this patch makes things better. I think the issue is both having zero contrib and having old pics on top sometimes (sometimes it just works as it should). I verify "old posts comes to top" issue can be observed in this branch for both prod and debug.

I have tested again, I still see my "very old uploads on top and new uploads are not on the list" on this branch. I experience the same thing on master. I never experienced "zero contributions issue" in either this branch or master. So I don't think this PR fix things.

@neslihanturan @nicolas-raoul Sorry for the trouble it is strange that I am facing a different issue but I will try to reproduce the mentioned issue properly and make more contributions, as I think it occurs when the user has many contributions. So It's better to close this PR.

@Pratham2305 Tip: Feel free to check https://github.com/commons-app/apps-android-commons/issues/4359#issuecomment-820904731 if you need an account with 200+ contributions.

I tried logout and login again, i am not able to see any contribution, even though phone shows right number of contributions

and also data is loaded as you can see in the logcat, that means the problem should be with the adapter

I have tried this on master-prodDebug

@vinayak0505 The data shown in your IDE screenshot is campaigns data (for the small campaigns banner at the top), not pictures data.

Oh okay

I have notices logging out some times deletes the complete contribution tables, some times delete all items in contribution, some times leave 10 contributions behind, which causes old images to show in top as they are not arranged desc to upload date

I am able to reproduce both the issues now, Blank Screen appears when you log out after the contribution table is filled with 50 contributions, and if you log out before that then the contribution table is not empty and old contributions will appear on top.
I have made the changes @nicolas-raoul @neslihanturan Please review.

Codecov Report

Merging #4337 (c4a75b8) into master (049dd7c) will decrease coverage by 0.40%.
The diff coverage is 20.00%.

:exclamation: Current head c4a75b8 differs from pull request most recent head 8a01d2f. Consider uploading reports for the commit 8a01d2f to get more accurate results

@@             Coverage Diff             @@
##             master   #4337      +/-   ##
===========================================
- Coverage     10.29%   9.89%   -0.41%
- Complexity      471     492      +21
===========================================
  Files           342     343       +1
  Lines         13155   14386    +1231
  Branches       1063    1245     +182
===========================================
+ Hits           1354    1423      +69
- Misses        11733   12890    +1157
- Partials         68      73       +5

Impacted Files
Coverage Δ
Complexity Δ

...fr/free/nrw/commons/category/ContinuationClient.kt
89.47% <0.00%> (-10.53%)
11.00 <0.00> (ø)

...main/java/fr/free/nrw/commons/media/MediaClient.kt
88.09% <0.00%> (-2.15%)
17.00 <0.00> (ø)

...mons/contributions/ContributionBoundaryCallback.kt
88.88% <50.00%> (-6.57%)
6.00 <1.00> (ø)

.../commons/contributions/ContributionsPresenter.java
63.15% <0.00%> (-19.20%)
6.00% <0.00%> (+2.00%)
:arrow_down:

...commons/contributions/ContributionsRepository.java
38.46% <0.00%> (-7.00%)
3.00% <0.00%> (ø%)

...rw/commons/bookmarks/BookmarkListRootFragment.java
7.89% <0.00%> (-0.93%)
1.00% <0.00%> (ø%)

...va/fr/free/nrw/commons/upload/UploadPresenter.java
75.67% <0.00%> (-0.69%)
12.00% <0.00%> (+4.00%)
:arrow_down:

...free/nrw/commons/wikidata/WikidataEditService.java
25.98% <0.00%> (-0.34%)
8.00% <0.00%> (+4.00%)
:arrow_down:

...in/java/fr/free/nrw/commons/data/DBOpenHelper.java
0.00% <0.00%> (ø)
0.00% <0.00%> (ø%)

... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 049dd7c...8a01d2f. Read the comment docs.


[charts/portal] Updating the mysql version to 8.0.37 for demo db

Description of the change

Benefits

Drawbacks

Applicable issues

fixes #

Additional information
Checklist

[x] Chart version bumped in Chart.yaml according to semver.
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [charts/gateway])
[x] If the chart contains a values-production.yaml apart from values.yaml, ensure that you implement the changes in both files

pls update Readme with latest mysql version

pls update Readme with latest mysql version

Done


is_action_pressed sometimes skips key press

Godot version:
3.2-stable
OS/device including version:
Windows 10 Home (Version: 1903, Build 18362.657)
Issue description:
Sometimes in-game keystroke events are skipped (this happens often when fps is low). This happens if you press them between frame updates. In my case, this happened  with the “X” and arrow buttons. But I think there are many other cases when this can happen.
Steps to reproduce:
To reproduce this problem with a 99% guarantee, you will need to set the Frame Delay Msec to high value, for example, to 1000 (1 frame per second). Then need to press any arrow key and then X key (but before next render). In test you'll see x____
Minimal reproduction project:
KeyboardTest.zip (version 2)
If everything is OK, you'll see something like this x__<_ (pressing left then X) or this x^___ (pressing up then X)
If not, you'll only see x____ (when pressed any arrow key then X) or even _____.
Frame rate of demo already set to 1 frame per second
My thoughts on this issue:
I downloaded the source code of the engine and did a little research. I think the problem is in the WM_KEYPRESS event (most likely on the Windows side).
As I understand it, this is because the OS sets a flag to indicate that it is a key repeat, regardless of whether the program processed the keystroke or not. Thus, in the WM_KEYPRESS event, the 30th bit of lParam indicates that the arrow key was previously pressed (but the Godot did not know about it).
To fix this problem, it probably makes sense to change the 1183 line of os_windows.cpp to something like this:
bool last_is_pressed = Input::get_singleton()->is_key_pressed(k->get_scancode());
k->set_echo((ke.uMsg == WM_KEYDOWN && last_is_pressed));

Cannot reproduce this on Windows 10 Pro 64 bit, (10.0, Build 18362)
Test project for those who need it:
Test.zip
var keys_pressed = 0

func _process(_delta):
	print(keys_pressed)
	if Input.is_action_just_pressed("ui_up"):
		keys_pressed += 1
	if Input.is_action_just_pressed("ui_down"):
		keys_pressed += 1
	if Input.is_action_just_pressed("ui_left"):
		keys_pressed += 1
	if Input.is_action_just_pressed("ui_right"):
		keys_pressed += 1
	if Input.is_action_just_pressed("x"):
		keys_pressed += 1

func _input(event):
	if event.is_action_pressed("ui_up"):
		keys_pressed += 1
	if event.is_action_pressed("ui_down"):
		keys_pressed += 1
	if event.is_action_pressed("ui_left"):
		keys_pressed += 1
	if event.is_action_pressed("ui_right"):
		keys_pressed += 1
	if event.is_action_pressed("x"):
		keys_pressed += 1

It prints out the total number of keys you pressed, so just keep pressing all 5 at once and make sure the number is divisible by 10 (2 checks of each type)
(Serious) Easy way to press all the arrow keys simultaneously. I had quite a bit of trouble with it.

@OlegDydy Does this occur if you disable input accumulation by calling Input.set_use_accumulated_input(false) in _ready()?

@Calinou No it does not. I don't use Input.set_use_accumulated_input(false) anywhere. The very first time I encountered this problem was when I figured out the standard Godot demo “2D Platformer Demo (kinematicbody)”

@nathanwfranke I think this version (KeyboardTest.zip) of the test demo will be much more informative (and yes, you do not need to press “X” and all the arrow keys, just “X” and any arrow key)
extends Node

var keys_pressed = ""

func _process(_delta):
	keys_pressed = ""
	keys_pressed += "x" if Input.is_action_pressed("x") else "_"
	keys_pressed += "^" if Input.is_action_pressed("ui_up") else "_"
	keys_pressed += "V" if Input.is_action_pressed("ui_down") else "_"
	keys_pressed += "<" if Input.is_action_pressed("ui_left") else "_"
	keys_pressed += ">" if Input.is_action_pressed("ui_right") else "_"
	print(keys_pressed)

If everything is ok, you'll see something like this x__<_ or this x^___
If not, you'll only see x____
PS Using your method, I achieved a result when almost all the arrow keys were skipped (the demo printed x^___ despite the five keys pressed on the keyboard).

I've opened your project in current 'master' build. I've been pressing all buttons in random order - and as you see - all of them are being recorded properly.

Need to press keys (eg  + ) at the same time (not hold X and then press arrows, this case have no problems).

Nope. Pressed X and arrow (and couple of them) at the exact same time. I've been also holding them for longer period to find if they start to flicker - but nothing funky happened - I've always had: x<^ in the output. Maybe it's something with your keybaord config (like key-strokes ratio) on Windows.
Does that error occur on other OS? Like, did you check it on Linux/macOS ?

Anyone who can reproduce this, make sure you have an anti-ghosting keyboard and no issues within keyboard testing apps.

@dreamsComeTrue I ran demo on Linux (on the same machine) and everything was fine. This only happens on Windows. Of course, I do not exclude the possibility of something wrong with my Windows installation, and not with Godot.

A small update. This error seems to depend on the frame rate. When I turn off VSync and make the frame rate unlimited, the problem disappears. And when I set the frame rate, for example, to 1 frame per second, it becomes more noticeable. For some reason key down event enters the program with is_echo() equals to true. In attached image the output from _unhandled_input callback.

To add on @OlegDydy, here's a snippet to consistently reproduce the bug
extends Node

var should_be_zero_when_spacebar_released = 0

func _ready():
	assert(
		ProjectSettings["application/run/frame_delay_msec"] == 1000,
		"Set your frame rate to 1000 in Project > Project Settings > General > Application > Run > Frame Delay Msec")
	print("Tap spacebar between the frames/prints. If the counter increases, you reproduced the bug")
func _process(_delta):
	if Input.is_action_just_pressed("ui_accept"):
		should_be_zero_when_spacebar_released -= 1
	if Input.is_action_just_released("ui_accept"):
		should_be_zero_when_spacebar_released += 1
	print(should_be_zero_when_spacebar_released)

Output:
Tap spacebar between the frames/prints. If the counter increases, you reproduced the bug
0
0
1
2
3
4
5
5


chore: add fantom vaults + add vault projection apy

Summary
Allow APY conversion for yield projection based on the rewards vs. duration since the previous harvest. This is true live APR!
🚀 🚀 🚀
Adds new Fantom Vaults

reviewed action didn't run on second approval


Support for --word_timestamps

Would it be possible to implement support for word timestamps? And output them in .json file.
So 0_test.mp3 would produce something like this:
{"text": " he broke his ties with groups of former friends.", "segments": [{"id": 0, "seek": 0, "start": 0.0, "end": 2.12, "text": " he broke his ties with groups of former friends.", "tokens": [5036    5, 415, 6902, 702, 14039, 365, 3935, 295, 5819, 1855, 13, 50484], "temperature": 0.0, "avg_logprob": -0.2811406942514273, "compression_ratio": 0.8888888888888888, "no_speech_prob": 2.7216827424604573    e-13, "words": [{"word": " he", "start": 0.0, "end": 0.16, "probability": 0.5108894109725952}, {"word": " broke", "start": 0.16, "end": 0.42, "probability": 0.9929890632629395}, {"word": " his", "sta    rt": 0.42, "end": 0.6, "probability": 0.9917784333229065}, {"word": " ties", "start": 0.6, "end": 0.88, "probability": 0.9973449110984802}, {"word": " with", "start": 0.88, "end": 1.1, "probability":     0.9941546320915222}, {"word": " groups", "start": 1.1, "end": 1.38, "probability": 0.980868399143219}, {"word": " of", "start": 1.38, "end": 1.56, "probability": 0.9978156089782715}, {"word": " form    er", "start": 1.56, "end": 1.8, "probability": 0.9916045069694519}, {"word": " friends.", "start": 1.8, "end": 2.12, "probability": 0.9920713305473328}]}], "language": "en"}

Something like following would do the job:
    def recurrent_timestamped(self, raw, sot):
        new_tok, i = mx.zeros((1,0), dtype=mx.int32), 0
        timestamped = {} # NEW
        while i+3000 < len(raw):
            piece = self.step(raw[i:i+3000][None], sot)
            arg_hop = mx.argmax(piece).item()
            hop = (piece[:,arg_hop].astype(mx.int32).item()-50365)*2
            new_tok = mx.concatenate([new_tok, piece[:,:arg_hop]], axis=-1)
            timestamped[i/100] = self.tokenizer.decode(piece[:,:arg_hop])[0] # NEW
            i += hop if hop > 0 else 3000
        new_tok = [i for i in new_tok.astype(mx.int32).tolist()[0] if i < 50257]
        return self.tokenizer.decode(new_tok)[0], timestamped

Would it be possible to implement support for word timestamps? And output them in .json file.
So 0_test.mp3 would produce something like this:
{"text": " he broke his ties with groups of former friends.", "segments": [{"id": 0, "seek": 0, "start": 0.0, "end": 2.12, "text": " he broke his ties with groups of former friends.", "tokens": [5036 5, 415, 6902, 702, 14039, 365, 3935, 295, 5819, 1855, 13, 50484], "temperature": 0.0, "avg_logprob": -0.2811406942514273, "compression_ratio": 0.8888888888888888, "no_speech_prob": 2.7216827424604573 e-13, "words": [{"word": " he", "start": 0.0, "end": 0.16, "probability": 0.5108894109725952}, {"word": " broke", "start": 0.16, "end": 0.42, "probability": 0.9929890632629395}, {"word": " his", "sta rt": 0.42, "end": 0.6, "probability": 0.9917784333229065}, {"word": " ties", "start": 0.6, "end": 0.88, "probability": 0.9973449110984802}, {"word": " with", "start": 0.88, "end": 1.1, "probability": 0.9941546320915222}, {"word": " groups", "start": 1.1, "end": 1.38, "probability": 0.980868399143219}, {"word": " of", "start": 1.38, "end": 1.56, "probability": 0.9978156089782715}, {"word": " form er", "start": 1.56, "end": 1.8, "probability": 0.9916045069694519}, {"word": " friends.", "start": 1.8, "end": 2.12, "probability": 0.9920713305473328}]}], "language": "en"}

How did yo do this and how did yo solve it? Could you send an example code? I'm not able to get other output than full text transcription.


Add factory and new-style config for Queued processor

This is part of remaining migration to new configuration format.
Github issue: https://github.com/open-telemetry/opentelemetry-service/issues/46
Testing done: make

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@9e8f857). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master      #47   +/-   ##
=========================================
  Coverage          ?   69.42%
=========================================
  Files             ?       85
  Lines             ?     5541
  Branches          ?        0
=========================================
  Hits              ?     3847
  Misses            ?     1475
  Partials          ?      219

Impacted Files
Coverage Δ

internal/collector/processor/queued/factory.go
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e8f857...8f43cc8. Read the comment docs.


Update addImage input param(compression) type

Here the Issue on addImage parameter compression data type error fixed.
It initially throws error on entering string type params.

We should rather fix the ImageCompression enum:

export it: export enum ImageCompression ...
fix the enum values, e.g. NONE = "NONE"

Fixes #2894.

Was fixed in #2933.


[Backport v1.0.3] Bump golang in harvester-installer to 1.18

This is a backport issue related to https://github.com/harvester/harvester/issues/2372

Skip QA verification. This is a compiler change and we agree the CI tests should meet the QA requirement.


Win message?

Hey Gamak, how do I edit the win message? Everytime i do i wll get an error called Broken Signature

Oh wait I fix it now


Added DatabaseTest

This test harness only sets up a testing database, with no full Jersey
container environment. Useful for testing components that make use of
the JNDI connection, but don't necessarily need to live in a full
application.

Coverage remained the same at 100.0% when pulling 5cb3eee7b10f568ee882e76e632bd785dfa93f3e on feature/database_test into ff5a8214aea824e48ccd75205154787b21dcd3c2 on develop.


Admob Video Reward Revenue $0

I have implemented admob video reward few days ago. released my app update and then i tested it myself on another device I was being served with video reward ad and was successfully getting reward.
Problem is its been couple of days now that my admob account is showing $0.00 revenue for my reward video ad unit.
I am sure I have removed isTesting attribute.
Should I add isTesting = false on reward video? because on banner and interstitial removing isTesting works fine and generating revenue.
I am worried It would have been the top performer but showing $0.00 revenue.

Removing the option isTesting is same as isTesting:false.
How many users updated to your latest version? (You can see the data in Google Play developer console.)
Here are some key data related with revenue:
.................  (ad frequency) ......... (fill rate) ............. (click rate) ...... (ad price)  ........
(daily active users) -> (ad request) -----> (impression) ---> (clicks)  -----> (revenue)
In AdMob portal, you check the following key data for each ad unit id:

ad request count (user traffic)
impression (ad correctly displayed)
clicks (most ad are CPC - cost per click ad)

FYI.

Following is the reposone of my video ad
AdMob Network requests | Matched requests | Match rate | Impressions | Clicks | Impressions CTR | Impression RPM | Estimated earnings
220,278 | 897 | 0.41% | 89 | 0 | 0.00% | $0.00 | $0.00
Can you please help, math request is too low

Actually
Request = 220,278
Match Rate = 897
Impression = 89
Revenue = $0.00
Can you please help how to improve?

request is not bad, but the impression is very little, which means, in the area of most users, not enough video ad is available for display.
my advice:

Either use normal interstitial ad (text, picture, etc) more than reward video ad. The normal intersititial ad fill rate is much higher, which may fully make use of your user traffic.
Or, add mediation to other video ad networks, like vungle, or unityads, etc.

Thank you so much, I will give a try to mediation otherwise back to pavilion interstitial ads :)

i have same problem implemented reward ad in my app but even after watching video revenue is 0. Should User have to click the ad or after watching video we will be paid...I have implemented it on non game app..User have to watch video to unlock content like book pages...or video ad only works for game only?

as I know, most ads are CPC (cost per click) type. only the ad is clicked, it's counted.


Unknown command when sending G1.

I am attempting to run StepD with the octoprint plugin. Everything has started, but when sending any movement commands I get the following: Any ideas?
Example: G1 X0 Y0 Z5 F4000
Recv: echo:Unknown command: "!\x0f)"
Recv: echo:Unknown command: "!\x0e"
Recv: warn:pending OK count dropped below 0
Recv: echo:Unknown command: "!"
Recv: warn:pending OK count dropped below 0
Recv: echo:Unknown command: ""
Recv: warn:pending OK count dropped below 0
Recv: echo:Unknown command: "!\x0c"
Recv: warn:pending OK count dropped below 0
Recv: echo:Unknown command: "!\x0b"
Recv: warn:pending OK count dropped below 0
Recv: echo:Unknown command: "!"
Recv: warn:pending OK count dropped below 0
Recv: echo:Unknown command: ""
Recv: warn:pending OK count dropped below 0
Recv: echo:Unknown command: "!	"
Recv: warn:pending OK count dropped below 0
Recv: echo:Unknown command: ""
Recv: warn:pending OK count dropped below 0
Recv: echo:Unknown command: "!\x07"
Recv: warn:pending OK count dropped below 0
Recv: echo:Unknown command: "!\x06"
Recv: warn:pending OK count dropped below 0
Recv: echo:Unknown command: "!\x05"
Recv: warn:pending OK count dropped below 0
Recv: echo:Unknown command: "!\x04"
Recv: warn:pending OK count dropped below 0
Recv: echo:Unknown command: "!\x03"
Recv: warn:pending OK count dropped below 0
Recv: echo:Unknown command: "!\x02"
Recv: warn:pending OK count dropped below 0
Recv: echo:Unknown command: "!\x01"
Recv: warn:pending OK count dropped below 0
Recv: echo:Unknown command: "!"
Recv: warn:pending OK count dropped below 0

@ChadDevOps are you using a 32-bit Marlin board? Direct Stepping in Marlin only supports 8-bit AVR boards at the moment. Support for the 32-bit ARM boards should be coming up soon- I have a functional version, but theres a USB Serial issue that I need to figure out first. I was close, but I've recently come into some housing complexities and will not have access to everything I need to test for another 2-3 months :(

@colinrgodsey Ah! Yes, I have the 4.2.2 board in the Ender 3 Max. That would explain it :) Thanks for the follow-up.

@ChadDevOps are you using a 32-bit Marlin board? Direct Stepping in Marlin only supports 8-bit AVR boards at the moment. Support for the 32-bit ARM boards should be coming up soon- I have a functional version, but theres a USB Serial issue that I need to figure out first. I was close, but I've recently come into some housing complexities and will not have access to everything I need to test for another 2-3 months :(

¿can you updated the readme to reflect this?, because nowhere it says that stepd only works with 8-bit boards until i read this issue, i was trying to make it work on my 32-bit board and now will stop after reading this.

@colinrgodsey thanks for a good project. But is it dead ? No updated from January ...

@Temtaime not dead, just big changes in personal situation. the next step i have to do is build a rig to test my smoothieboard (which is god knows where in storage) for 32b integration. it is mostly done, but i need to proceed with some real word tests (and possible deal with wonky data collection patterns for USB).
as far as the original target, the 8-bit boards, things should still be working fine.

@colinrgodsey Hello, first thank you so much for your work on this, you are the only person working on a step daemon for Marlin, even now years later. Do you anticipate still working on 32 bit support for this? I just upgraded my Ender 3 Pro with a BTT SKR Mini E3 V3 which is 32 bit and would love to use direct stepping with it


Is it possible to support multiple languages?

I want to translate it into Japanese

I'm planning to add support for other languages, however I need to first find a font that supports essentially every character and then edit the code to read the text in from other files. I'll ping you here once I've done that!

thx!
It seems that this font is compatible with all languages
https://github.com/XorTroll/Goldleaf/pull/500/commits/76e2020bc5a9f3d0365e6732a622c4f5dfcc479b

I'm willing to provide a french translation when we get there 🎉

Good news is I'm just about ready for translations - I just need to double check everything works properly and add an option in the settings! I may get it all done today :P

That was quicker than expected, everything is ready! All you need to do is make a copy of Application/romfs/lang/en.json and rename it to your language code, and translate the strings within the file. If you know your way around code, feel free to add the required code in order for it to appear in-app. Otherwise I can edit the code where needed after merging the translation.
I'll close this issue as it's now possible to support other languages, it's just a matter of waiting for translations :P
Thank you in advance! :)

That code seems familiar.
Would you mind giving credit to the respective project?
Especially as licenses are compatible in this case.

Can do, apologies for not doing so. I think I was looking at Awoo Installer as a guide for how to do this language stuff, so how would you like to it to be credited?


better handling of bad inputs to Gauges

For example, passing a point in 2-space instead of in 3-space causes a pretty nasty error of the form:
ValueError: operands could not be broadcast together with shapes (1836,3) (2,)
    node_distances = norm(self.vertices - location, axis=1)
ValueError: operands could not be broadcast together with shapes (1842,3) (2,)
    node_distances = norm(self.vertices - location, axis=1)
ValueError: operands could not be broadcast together with shapes (1788,3) (2,)

I am sure there are a couple of other cases to catch.

Another example, passing points as lists instead of tuples to the PointGauges constructor gives errors about unhashable type.

@adimako - Feel free to point out anything else that's weird about the Gauge interface.  I'll do a sweep at some point in a couple of weeks and fix these issues.


wasi-sockets: Implement initial listen backlog

Allow set_listen_backlog_size to be called before listening. This enables us to pass the backlog value to the initial listen syscall, which is more widely supported. This is in line with the explanation in https://github.com/WebAssembly/wasi-sockets/issues/34
Silently clamp the provided backlog value, instead of failing with OutOfMemory.

I've just committed an additional line that got lost while resolving the conflicts. Should be good to go now.


Need to have chrome session in Rest client as well similar to older version

Your description here
Need to test my post request after logging in. I logged in to google chrome and i tried my api request in Rest client but it showing user not logged in. Is there any way to file my post request after loggin in.
Expected outcome
What should happen?
Actual outcome
What happened?
Versions
App: <IP_ADDRESS>-stable
Chrome: 51.0.2704.103
Platform: Windows (10)
Steps to reproduce

Hi,
Thank you for issue report.
Please, Use the "Use XHR" switch above the request panel (requires installation of additional extension) to proxy the request through Chrome. Then it should work as in old version.


[CENNSO-1149] feat: drop sessions upon receiving "Session context not found" errors

@ivan4th any objections on this PR?

@mgumz this is still a draft and not in review, should be ready later today or tommorow, hang tight!

LGTM, I'll leave the final approval to @ivan4th


Server Question, Not An Issue

Hello! I'm doing some work on communicating between the NUC and the workstation, and I've mainly been doing this over a flask server.
It's possible I'm doing something wrong, but the delay is quite bad (~0.15 sec delay, but I'd like to run at 20 hz).
Although I'm willing to use Polymetis as the server since it supports this anyway (and I assume at a much faster rate), I'd prefer not to so that our codebase stays robot agnostic.
I am curious if you guys have any advice on this? For example, is there an alternative to flask that works much better? I had some trouble figuring out what Polymetis uses under the hood :)
Thanks as always!

Polymetis uses gRPC, the interface of which can be found here.
I don't have any experience with flask, but I would try to identify where the bottleneck is along the pipeline (and ensuring that it is due to flask) before making an effort to switch frameworks.

So I found that it was actually consecutive calls that was making things slow, and sending less calls in bigger packets greatly sped things up.
I'm finding that I can send small vectors of info (~ Length 7) within 20 milliseconds. Is this on the same scale as the Polymetis servers across an ethernet cable? I'd test it myself but my other machine is a Mac so I can't download Polymetis :)

In order to achieve real-time control at 1kHz, the entire control loop must complete within 1ms (deserialize robot state, run Torch policy to get control output, serialize torque, send message over network). So I'm guessing the message serialization/deserialization/communication we're using (i.e. gRPC, or really Protobuf) is orders of magnitude faster on average.
You're likely bottlenecked by (in order): Flask overhead, Python, serialization/deserialization protocol. For a closer-to-the-bare-metal communication, you might try just directly sending bits over sockets, which probably will work just fine for small projects in Python, or try something like zmq, gRPC, etc.


Login functionality complete

This PR uses the API authenticate endpoint to check the users database table to authenticate a user.

Great stuff - really excited to roll out the log in features.


New version: VectorPrisms v1.1.1

Registering package: VectorPrisms
Repository: https://github.com/JuliaComputing/VectorPrisms.jl
Created by: @Keno
Version: v1.1.1
Commit: de894f3ef6ad4d2de48458d6616dad51915a9056
Git reference: HEAD
Description: Making structs viewable as AbstractVectors

I guess 1.1.0 never got registered here. I don't think it's worth bothering to do that - it's only one commit behind. I could make this 1.1.0 instead, but I don't want to rewrite history, so I think just [merge approved] is fine.

[merge approved]


WIP: test release

Related:

https://github.com/teamhephy/workflow/pull/152

I think there are changes yet in kingdonb/controller:git-7beda111 that are necessary for Native Ingress to work, but they have not yet landed in a release image from hephy/controller but I have to confirm this.


[Question] Validate response against a specific response schema.

Use case: testing.
In a test I want to check if the response's content matches the schema of the expected status code and not any other schemes defined in the possible responses.
Example:
Let's say you have following example endpoint spec.
 /endpoint:
    get:
        responses:
            '200':
                content:
                    application/json:
                        schema:
                            type: string
            '403':
                content:
                    application/json:
                        schema:
                            type: int

Is there a way to validate a response only against the schema specified in '200'? The validation shouldn't try to match the response against the '403' schema.

Hi @Booktivity
if you want to validate only schema you should try openapi-schema-validator which is used under the hood

Hi @Booktivity if you want to validate only schema you should try openapi-schema-validator which is used under the hood

Thanks and sorry for replying so very late:). IFf openapi-core uses the schema-validator under the hood, then I don't understand why the validator doesn't return validation errors if in my case a django response doesn't match the schema.


App is stuck when start playing song "The Man Who Sold The World (2015 Remastered Version)"

OS:
Solus 3.9999
GPMDP Version:
4.6.1
Issue Descriptions:
App is stuck when start playing song "The Man Who Sold The World (2015 Remastered Version)". Music was continued to play, so only UI was stuck. Only this song has caused this issue. Also there is 100% usage of one of CPU threads. Reproduced on both of my computers.
https://i.imgur.com/sEiWi1X.png
https://i.imgur.com/MJvKMmP.png
https://i.imgur.com/2T2RP7F.png
Steps to Reproduce:

Open app
Start playing song "The Man Who Sold The World (2015 Remastered Version)"

I am getting the same issue but on multiple tracks. Same issue on my Mac and Windows machines

Today I also started the application to hang. When playing with youtube, the interface freezes up when opened, but the music continues to play. In this case, only the multimedia buttons on the keyboard work. But the interface itself is constantly waiting for a response.

My app freezes as well after playing any song. Music continues to play, goes to next song, then also freezes after a few seconds into the song. CPU usage at ~20-30% while frozen (i7-8550U)

Confirmed to randomly occur within a moment of starting another song. CPU usage is spinning 100% of a core.

Same here, after 10-20 Minutes, on windows 10, which song doesn't matter. When I reopen Player from background after a while it crashes and no more reaction:

This issue is caused by a lyrics fetching API and is being worked on. You need to disable lyricsfreak from the app to stop it from crashing so use the fix @Tune389 mentioned for the time being.

duplicate of pinned issue #3483

Sick song though.


Middleware

Hi, could you pls give a way to do and use middlewares with your "Luthier-ci" like a "middleware example"?

Hi,
A middleware is basically any PHP class stored in the application/middleware folder, with a a run() public method, the entry point. For example, this is a middleware named Test_middleware:
<?php
# application/middleware/Test_middleware.php

defined('BASEPATH') OR exit('No direct script access allowed');

class Test_middleware
{

    /**
     * Middleware entry point
     *
     * @return void
     */
    public function run()
    {
        echo "Hello!  ";
    }
}

It can be triggered in your routes with the following syntax:
<?php
#application/routes/web.php

// Group based middleware:
Route::group('/', ['middleware' => 'Test_middleware'], function(){

    Route::get('/', function(){
        echo 'Oi';
    });

    // Route based middleware:
    Route::get('/test', function(){
        echo 'Oi 2';
    }, ['middleware' => 'Test_middleware']);
});

The middleware can be an extension of the Controller, since we can retrieve the current framework instance using the ci() function. For example, it's possible to load a library inside a middleware:
<?php
# application/middleware/Test_middleware.php

defined('BASEPATH') OR exit('No direct script access allowed');

class Test_middleware
{

    /**
     * Middleware entry point
     *
     * @return void
     */
    public function run()
    {
        ci()->load->library('MyLibrary');
    }
}

A properly documentation will be added soon.


Enable Flash Attention on GGML/GGUF (feature now merged into llama.cpp)

Flash Attention has landed in llama.cpp (https://github.com/ggerganov/llama.cpp/pull/5021).
The tldr; is simply to pass the -fa flag to llama.cpp’s server.

Can we please have an Ollama server env var to pass this flag to the underlying llama.cpp server?

also a related idea - perhaps there could be a way to pass arbitrary flags down to llama.cpp so that hints like this can be easily enabled? (E.g. OLLAMA_LLAMA_EXTRA_ARGS=-fa,—something-else

Are there any cons for using Flash Attention? If not it probably should be the default.

Also if there is more memory available we should really set the default quants to Q4_K_M and fallback to Q4 when Q4_K_M is not available

also a related idea - perhaps there could be a way to pass arbitrary flags down to llama.cpp so that hints like this can be easily enabled? (E.g. OLLAMA_LLAMA_EXTRA_ARGS=-fa,—something-else

Yeah, I think this would help a lot.

I had a hot crack at a PR tonight but as you said @jukofyork it seems server.cpp has diverged from llama.cpp a lot and I couldn't get my head around it.
Might have to wait for someone more familiar with Ollama's version of it / more brains than me.

FYI: LM Studio added Flash Attention earlier today: https://www.reddit.com/r/LocalLLaMA/comments/1cir98j/lm_studio_released_new_version_with_flash/

Comparing GGUF performance with/without Flash Attention
Hardware

Apple Macbook Pro M2 Max (96GB)

Model

llama3-bartowski-8b-instruct-q8-0.gguf

Request
curl http://localhost:11434/v1/chat/completions -H "Content-Type: application/json" -d '{
        "model": "registry.internal/ollama/llama3-bartowski:8b-instruct-q8_0",
        "messages": [
            {
                "role": "user",
                "content": "Tell me two short jokes."
            }
        ]
    }'

LM Studio with Flash Attention
Start time: 14:10:20.401
End time: 14:10:21.636
"prompt_tokens": 38,
"completion_tokens": 37,
"total_tokens": 75

1.235 seconds
60.65 tokens/s

Ollama
total duration:       1.866343375s
load duration:        1.299853709s
prompt eval count:    15 token(s)
prompt eval duration: 84.22ms
prompt eval rate:     178.10 tokens/s
eval count:           18 token(s)
eval duration:        481.335ms
eval rate:            37.40 tokens/s

Start TIMESTAMP:<PHONE_NUMBER>
End TIMESTAMP:<PHONE_NUMBER>

1.866 seconds
40.38 tokens/s

Got it working by adding the OLLAMA_LLAMA_EXTRA_ARGS environment variable in llm/server.go as @sammcj suggested. This allows the -fa flag be passed into ext_server/server.cpp. If anyone is interested, my hack can be found here. Hopefully this can help others get Flash Attention working too.

That looks VERY similar to what I tried @wanderingmeow, perhaps I just wasn't parsing the parameters correctly 🤔 , that's awesome!

That worked instantly, still no where near as fast as LM Studio but it's a start.
export OLLAMA_LLAMA_EXTRA_ARGS="-fa"

ollama serve

...
llama_new_context_with_model: n_ctx      = 2048
llama_new_context_with_model: n_batch    = 512
llama_new_context_with_model: n_ubatch   = 512
llama_new_context_with_model: flash_attn = 1
llama_new_context_with_model: freq_base  = 500000.0
llama_new_context_with_model: freq_scale = 1
...

ollama run registry.internal/ollama/llama3-bartowski:8b-instruct-q8_0 'tell me two short jokes' --verbose
Here are two short jokes:

1. Why don't scientists trust atoms? Because they make up everything!
2. Why don't eggs tell jokes? They'd crack each other up!

Hope you find them amusing!

total duration:       2.539137625s
load duration:        1.286854542s
prompt eval count:    15 token(s)
prompt eval duration: 83.363ms
prompt eval rate:     179.94 tokens/s
eval count:           44 token(s)
eval duration:        1.168093s
eval rate:            37.67 tokens/s

@wanderingmeow I've created a PR with the changes - https://github.com/ollama/ollama/pull/4120

Awesome! :+1:

I wonder if we can extend this:
	if other_args := os.Getenv("OLLAMA_LLAMA_EXTRA_ARGS"); other_args != "" {
		params = append(params, strings.Split(other_args, ",")...)
	}

To  use a reg-ex to match against the model name passed in model string?
Then we can just completely bypass the modelfile code and pass model-specific parameters as well? This would save all the hassle of PRs not getting accepted and then breaking because the code all got moved around!
It looks like we could just copy in server_params_parse from  the sub-module (possibly automatically using AWK or something) and we would have access to any parameter added to llama.cpp.
It probably doesn't want to be split using "," as that is used by llama.cpp for  some options like tensor-split, etc.

Something like:
export OLLAMA_LLAMA_EXTRA_ARGS=".* ; -fa | qwen.* ; -sm row ; -ts 3,2"

Although I'm not sure if the model string will actually be the name or the weird sha hash name that points to the GGUF file?

still no where near as fast as LM Studio but it's a start.

From my testing, the current ollama ext_server implementation performs on par with the latest server example from llama.cpp, with only a slight slowdown (<1%).

It looks like we could just copy in server_params_parse from the sub-module (possibly automatically using AWK or something) and we would have access to any parameter added to llama.cpp.

@jukofyork I had a look at this, but it was getting messy, fast.
What I think probably could work is:

Split out Ollama's custom server configuration from the model server parameters.
Do the same in llama.cpp in PR (if @ggerganov thinks this might be a good idea).
Then Ollama or any project that wants to use llama.cpp's model server parameters library can do so separate from their server configuration logic.

still no where near as fast as LM Studio but it's a start.

From my testing, the current ollama ext_server implementation performs on par with the latest server example from llama.cpp, with only a slight slowdown (<1%).

It really helps reduce the VRAM use of long-context models: some I could only run at 16k or 32k are now running with 32k or 64k for the same quant!

It looks like we could just copy in server_params_parse from the sub-module (possibly automatically using AWK or something) and we would have access to any parameter added to llama.cpp.

@jukofyork I had a look at this, but it was getting messy, fast.
What I think probably could work is:
1. Split out Ollama's custom server configuration from the model server parameters.

2. Do the same in llama.cpp in PR (if @ggerganov thinks this might be a good idea).

3. Then Ollama or any project that wants to use llama.cpp's model server parameters library can do so separate from their server configuration logic.

That's way out of my ball park though 😅

Yeah, but it would be good for the long-run: some of the parameters and their default settings that Ollama is using are very out of date compared to llama.cpp's server now and I can only see things getting worse and worse if nothing is done about it.

Anyway, https://github.com/ollama/ollama/pull/4120 provides the functionality for now, just waiting on someone to approve it...

#4120 is still sitting waiting for approval to be merged, I've been trying to keep it up and fix conflicts etc as other PRs are merged in.

FA is also required for another important feature already present in Llama.cpp and hopefully coming in Ollama: KV cache quantization, with the two options -ctk and -ctv . In particular, it's required for V:
llama_new_context_with_model: V cache quantization requires flash_attn


Add Hungarian Algorithm Implementation in C

issue solved #1569
Pull Request: Add Hungarian Algorithm Implementation in C
Description
This PR introduces an implementation of the Hungarian Algorithm (also known as the Kuhn-Munkres algorithm) in C to solve the assignment problem. The assignment problem is widely used in optimization, scheduling, and resource allocation, aiming to minimize the total cost of assigning tasks to workers, where each worker is assigned exactly one task, and each task is completed by only one worker.
Implementation Details

Matrix Representation: The cost matrix is a 4x4 matrix where each element represents the cost of assigning a particular task to a specific worker.
Algorithm Components:

u and v: Dual variables used to manage potentials for optimal assignment.
p and way: Arrays used for tracking the optimal path and backtracking in the matching process.
minv and used: Arrays to manage minimum values and visited status during the assignment process.

Code Structure

hungarian_algorithm: Main function that implements the Hungarian Algorithm using matrix reduction and optimization techniques.
min: Helper function to find the minimum of two values.
main: Initializes the cost matrix and invokes the hungarian_algorithm function, which calculates and prints the minimum cost and the optimal assignment.

Example Output
Using the predefined 4x4 cost matrix:
9  2  7  8
6  4  3  7
5  8  1  8
7  6  9  4

Sample program output:
Minimum cost: 13
Optimal assignment:
Worker 1 assigned to task 2
Worker 2 assigned to task 3
Worker 3 assigned to task 1
Worker 4 assigned to task 4

This result provides an assignment of workers to tasks that minimizes the overall cost.
Testing

The code was compiled and tested using a C compiler (GCC).
The current implementation uses a 4x4 cost matrix, but this can be adjusted for different problem sizes by modifying the N constant and cost matrix.

Future Improvements

Extend the code to support dynamically sized matrices.
Add error handling for cases where no valid assignment exists.

@pankaj-bind kindly review the issue and kindly merged it possibly with labels