Customize output logs during install and upgrade - request

Enhancement request:
Currently, when executing helm upgrade --install --atomic (or --wait) there is no information or detail about what is going on, unless you go run kubectl commands elsewhere against the cluster. This is especially painful when running in CI/CD, as you cannot tell if the rollout is hung or progressing.
I have found that the --debug flag is incredibly useful for all of the relevant information one might want to have while an install or upgrade is rolling out: including the resources that helm is managing and whether it found any changes to make or not, as well as what resource(s) kubernetes is currently reporting as not ready, preventing successful completion of the task.
The issue with --debug, though, is that it also forces the entire manifest, as well as the user values and calculated values to be output to stdout. These items can often contain sensitive information (secrets) or are just overly verbose, which is also painful for CI/CD logs.
Unless I am mistaken, this means the current support for output logging during a rollout consists of:

Nothing, just a process that works silently and hopefully completes, and no info on what it changed
or
Every single detail anyone could want, including overly verbose and sensitive information, and things that can be grabbed other ways (eg. helm get manifest)

It would be fantastic to see helm get some better output options for different capability in this regard.
Proposal ideas:
These are just some options to base some discussions on.

A --follow flag which can be used with (or implies) --wait to signal that the output for resources being updated and resources waiting to become ready should be logged to stdout (effectively --debug without the extra cruft).
Split the current --debug output into --debug for the current logging that is actually [debug] logs following the useful things noted in option 1, and --verbose to include the other objects (values, manifests, etc.)
Revamp / revise the existing --output format options to be able to take a stringArray of output objects to include (eg. --output debug,user_values,hooks,manifest)
Flags to squash / remove the specific output objects (eg. --suppress manifest,computed_values)

I'd personally prefer options 1 or 2, but depending on implementation overhead or expected extensibility maybe you think other ideas are more worthwhile?

@tstraley Thank you for the request. This is not the first time I've heard this.
I think we need a HIP to move this forward. It is not a straight forward request when we look at backwards compatibility in Helm v3 and in what we could do for Helm v4.
Overall, I like the high level idea.

@mattfarina anyone can write a HIP and submit via PR? I have an interest in this feature. Would first ask @tstraley if they'd prefer to turn this issue into one.


Question: is there any way to see the duration of individual rules?

Thanks for wanting to report an issue you've found in gulp-tslint. Please make sure it's an issue in gulp-tslint, not tslint. Otherwise please submit an issue to tslint: https://github.com/palantir/tslint/issues/new. Please delete this text and fill in the template below.
gulp-tslint version: 7.1.0
tslint version: 4.5.1
Operating system: Windows 10
TSLint is during pretty long since we are using rules from codelyzer and rules from tslint-contrib-microsoft. I wanna know which rules are 'expensive'. Is there any way in the report system to maybe log the duration of each individual rule executed?

This is a tslint issue, please file an issue at https://github.com/palantir/tslint/issues/new


Honour the NewtonSoft JsonObject NamingStrategy

Fixes #227

Oooh, thanks @caitchison , let me have a look and I'll try to get this out asap!

Looks good, thank you for this!

It will be in the <IP_ADDRESS> release which is on it's way to Nuget as I type..


[HxGrid] Filter rows

I think in the past there was a feature available to filter rows by entering a keyword in the context of one column.
Can somebody give me a hint where it is? I can find it..

There are some examples regarding filtering/searching at https://havit.blazor.eu/components/HxListLayout

Thanks a lot!


red5 server and rtmp

Hello,
i'm using ur sample to test
the lib works great with wowza but on Red5 i can't play the stream via VLC i only can hear the voice without video
also didn't work on ffmpeg player
i see this warning in red5 console when i start publishing
[WARN] [NioProcessor-2] org.red5.server.net.rtmp.InboundHandshake - Client not compatible
is this library not compatible with red5 or i'm need to modify something to make it work ?
thanks in advance

https://github.com/pedroSG94/rtmp-rtsp-stream-client-java/issues/66
If you are using Linux with open source red5 code try with Windows and Mac. This look red5 bug

thanks for your reply
i'm already use Red5 on windows
any configuration can help to work ?

I don't know.
Try use ffmpeg to stream using other pc in your net and you can know if the problem is with red5. If you have this problem you can't stream using other pc, you only can stream with the pc where server is installed. Same to take stream using vlc or ffplay. If you can do it I could try debug to know if this is my error or not.

there is no problem in the connection because i can hear voice from VLC
from ffmpeg log i get this error
"Received FLV packet before play()! Ignoring."

That log is when you do a stream using ffmpeg or when you get the stream with ffplay?
If it is the first case then propably you can't do stream. Ffmpeg should work always.
I will install red5 on my w10 and see the result. If I get the same problem that with Linux using w10 then you only can use Mac or wait a update of red5.

Hi @K0EZ
I have some trouble with Red5 Server in the beginning and it works well for me now
I created an issue a while back:
https://github.com/pedroSG94/rtmp-rtsp-stream-client-java/issues/39
I create an SWF to help test the stream
https://github.com/MikeMannox/RtpSubscriber/releases/tag/1.1


[AutoPR machinelearningcompute/resource-manager] chore: jsonfmt machinelearningcompute

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/6139

(message created by the CI based on PR content)


Issue #33

Hi Enet4,
I'm learning Rust and I sometimes bump into DICOM, so I gave issue #33 a try.
Keep up the good work, adeusinho.

That's pretty much it! Thank you! :+1:


Suppress ExternalLoginUserNotExist error

Fixes #21202
Closes #21276
An ExternalLoginUser is not mandatory if the current user account was created with/by the external login source.

CI failure is related.

Ha! is this the first PR to use the new not exist err?

I guess we should try to fix these missing these missing ExternalLoginUser entries though.

I guess we should try to fix these missing these missing ExternalLoginUser entries though.

But from my understanding they are not missing. See my comment here.

Please send backport


Update github.com/hashicorp/golang-lru to v2

This PR updates github.com/hashicorp/golang-lru to v2 which uses Go generics. I'm not very familiar with the code so this requires some experienced eyes but I believe I figured out the correct changes for the bump to v2.

oh! could you squash the commits?

@thaJeztah Done :)


Develop update

Hello @gwenchee! Thanks for submitting the PR.

In the file tests/continuous_integration_test.py, following                are the PEP8 issues :

Line 22:1: E302 expected 2 blank lines, found 1
Line 38:1: E305 expected 2 blank lines after class or function definition, found 1
Line 53:80: E501 line too long (89 > 79 characters)
Line 58:80: E501 line too long (85 > 79 characters)
Line 83:80: E501 line too long (82 > 79 characters)
Line 111:1: E302 expected 2 blank lines, found 1
Line 121:80: E501 line too long (113 > 79 characters)
Line 121:114: W291 trailing whitespace
Line 123:80: E501 line too long (112 > 79 characters)
Line 124:80: E501 line too long (112 > 79 characters)
Line 125:80: E501 line too long (103 > 79 characters)
Line 126:80: E501 line too long (109 > 79 characters)
Line 127:80: E501 line too long (85 > 79 characters)
Line 127:86: W291 trailing whitespace


thenCombine vs thenCompose

Both of these methods are used to combine 2 completable futures asynchronously, but I'm not very sure what differentiates them and which method to use in what circumstance. Would appreciate if someone could explain this thanks!

I believe thenCompose is used if you want to compose two Futures, so the output of one becomes the input of the other. On the other hand, thenCombine is used if you want to put together both the outputs of each Future.
e.g. bar(foo(a)) --> thenCompose, but bar(a) + foo(a) --> thenCombine
CMIIW!

thenCombine  is similar to reduce. thenCompose is similar to flatmap, thenApply is map

agree with @sumhungyee. comparing it to map will make it easier to understand


1.I ¦Support for different Execution Cycles

[ ] 1.I.I ¦M: Run to End
[ ] 1.I.II ¦M: Single Cycle (step forward)
[ ] 1.I.III ¦*S: Multi Cycle
[ ] 1.I.IV ¦*S: Being able to Set & Run to Breakpoints
[ ] 1.I.V ¦*C: Step Back/Rewind

Step back could make use of gates containing a reference to the previous value
(pushing an input to a gate, sets it's "previous value" = current, then current = input)
Keeping a reference of the entire Data_Memory & Register_Bank would be too expensive.
Since an instruction can only modify 1 value at a time.  They could instead keep a index of the last
" write signal, write index, data_before_write"
(the write instruction can set the data_before_write to the current value before overwriting)
This would be a significantly more efficient than storing a snapshot of every data point for each step.
Snapshots could possibly be made before running "Run to End" or "Step Multiple (Multi Cycle)"  and then allowing 'Undo' to before those instructions were run.
Or it may be faster to simply record the cycle #. And reanimate the execution silently upto that cycle.
If user input was used, a log of user input would need to be made, and referenced in the place of requesting for input.


segmentation for ScanNet

Could you please offer the segmentation code for ScanNet?

Please refer to this issue #9.
Thanks


feat(bazel): support generation with x-api deps

Support BUILD.bazel file generation with cross-API dependencies. Such a dependency is identified by the presence of a version in the import path e.g. google/cloud/foo/v1/bar.proto, which would normally be converted into a dependency label like google/cloud/foo/v1:bar_proto. However, generated BUILD.bazel files in googleapis have proto_library targets that represent the entire package rather than one target per-proto-file. So, the API package is parsed out of the import path and used as the replacement in the label e.g. google/cloud/foo/v1:foo_proto.
Note: This implementation generates a py_proto_library dependency that will not have been generated into the dependency package and must be added manually. This can be fixed when py_gapic_library targets can be used in their place (something @parthea has mentioned wanting to fix for this specific x-api dep scenario).
Fixes http://b/269312831.

Just a friendly bump on this @alexander-fenster and @parthea. Tony, I'd love your take on how this will impact/how this could aid Python GAPIC generation & the migration of py_proto_library to py_gapic_library targets.

@alexander-fenster could you review this when you have a chance please? Thanks

@noahdietz py_gapic can now be used as a dependency instead of py_proto
See cl/520334574 as an example

@noahdietz py_gapic can now be used as a dependency instead of py_proto for python. I found that the dependency needs to be imported with py_import first.

Wonderful! I will adjust this PR accordingly.

@parthea sounds like we can resolve https://github.com/googleapis/rules_gapic/issues/46 too in a way. I think I will do this in a separate CL and have this one gated on that.


[MM-17422] Sets custom bot icon at LHS if present.

Summary
Display LHS bot Icon in web app. As part of mentioned task, Checks if LastIconUpdate is present for each bot and if present (that means a custom bot icon is present), fetches the bot icon and sets it.
Ticket Link
https://mattermost.atlassian.net/browse/MM-17422
Fixes https://github.com/mattermost/mattermost-server/issues/11925
Depends on: https://github.com/mattermost/mattermost-server/pull/12229

This issue has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @hanzei

Hey @prapti looks like this is ready to be QA'd.
This requires a server change (https://github.com/mattermost/mattermost-server/pull/12229)

@ali-farooq0 can the ticket be updated with QA test steps? That'd be very helpful!

@renilJoseph Would you please merge master into your branch?

@ali-farooq0 Gentle reminder about https://github.com/mattermost/mattermost-webapp/pull/3673#issuecomment-544794485

@prapti https://mattermost.atlassian.net/browse/MM-17422 is now updated with the QA steps.

@renilJoseph @ali-farooq0 can the PR description and/or ticket be updated with QA test steps? That'd be very helpful!

@prapti you have to check that the following errors (https://mattermost.atlassian.net/browse/MM-17294) is not showing up when you test the following situations: start with no bot icon, set the bot icon (make sure webapp updates), remove the bot icon (make sure the web app reverts to default bot icon). Also, the above situations should be working as it is supposed to.
For creating the above mentioned situations: Please follow QA test steps specified in the link: https://mattermost.atlassian.net/browse/MM-17422
@ali-farooq0 please confirm.

@renilJoseph @ali-farooq0 can the PR description and/or ticket be updated with QA test steps? That'd be very helpful!

@prapti you have to check that the following errors (https://mattermost.atlassian.net/browse/MM-17294) is not showing up when you test the following situations: start with no bot icon, set the bot icon (make sure webapp updates), remove the bot icon (make sure the web app reverts to default bot icon). Also, the above situations should be working as it is supposed to.
For creating the above mentioned situations: Please follow QA test steps specified in the link: https://mattermost.atlassian.net/browse/MM-17422
@ali-farooq0 please confirm.

Spot on @renilJoseph 👍

Thanks @renilJoseph! I'll let you know if I have further questions.

I'm still seeing the 404 not found error when deleting the icon. Are you seeing it @renilJoseph? Both my server and webapp are pointing to the correct PR branches (server-12229, webapp-3673)

Test server creation failed. See the logs for more information.

I'm still seeing the 404 not found error when deleting the icon. Are you seeing it @renilJoseph? Both my server and webapp are pointing to the correct PR branches (server-12229, webapp-3673)

@prapti A small change which did not check for undefined results caused that. Adding this line solved the issue: https://github.com/mattermost/mattermost-webapp/blob/e47ecd6748361597743d38ca1ccc114933f34baf/components/sidebar/sidebar_channel/index.js#L92
Sorry for the delay. Can you please test again ?

Creating a new SpinWick test server using Mattermost Cloud.

Mattermost test server created! :tada:
Access here: https://mattermost-webapp-pr-3673.test.mattermost.cloud

Account Type
Username
Password

Admin
sysadmin
Sys@dmin123

User
user-1
User-1@123

Test server destroyed

Creating a new SpinWick test server using Mattermost Cloud.

Mattermost test server created! :tada:
Access here: https://mattermost-webapp-pr-3673.test.mattermost.cloud

Account Type
Username
Password

Admin
sysadmin
Sys@dmin123

User
user-1
User-1@123

@ali-farooq0 This is the PR that I wanted to mention (and maybe I already did.. sorry for redundancy in that case). What I'm seeing is that issuing the curl to set the bot icon returns {"status":"OK"}curl: (3) URL using bad/illegal format or missing URL and the icon is not visible on LHS, but doing a get on <bot_id>/icon shows correct icon. Please let me know if this repros for you as well. Thank you!

This issue has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @hanzei

@ali-farooq0 Can you help with the question above?

Test server destroyed

@ali-farooq0 Gentle reminder about the questions above

/update-branch

Thank you very much for this great feature contribution :tada: Glad we got it merged at the end :man_dancing:


Multi-touch with touchpads

I noticed that egui has multi-touch support in the API via InputState::multi_touch. However I have not been able to produce any multi-touch events on my Linux laptop using libinput on sway.
I saw in the initial issue and PR that it is more focused toward touchscreens rather than touchpads. However, in applications that support zooming and panning, a true multi-touch experience on a touchpad is great for UX. As such, I am wondering if egui (or eframe, not sure where the support for this has to go) could add support for multi-touch on touchpads.
I would be willing to implement this if someone more familiar with the organization of the codebase could tell me where to start.

This would be great! I think you need to start implementing it in winit though if you want to have it in eframe

This is also interesting for MacOS, where the "Magic" Trackpad, and the MacBook's builtin trackpad, sound to me they could be inputting these kinds of multi_touch events.
A lot of apple-native apps make use of it, so being able to use something like two-finger drags to drag something away, would be interesting to explore.

I think it would be possible to link https://wayland.app/protocols/pointer-gestures-unstable-v1 to https://docs.rs/winit/latest/winit/event/enum.WindowEvent.html#variant.TouchpadMagnify etc. I'll look into it.
Does egui support these winit events? Seems not based on the Event enum.


feat: add configure tuic modal

Background

Checklist

[ ] The Pull Request has been fully tested
[x] There's an entry in the CHANGELOGS
[ ] There is a user-facing docs PR against https://github.com/daeuniverse/dae

Full changelogs

feat: add configure tuic modal

Issue reference

None
Test Result

Congestion Control has optional values:

bbr
cubic

Optional values of Congestion Control:

bbr
cubic

Solved by adding select options to configure node form modal


Can't Load API Key

Even after creating a .env file with my API key, it is not recognized. Is there a way to hard code the API key into the script?

Set-Variable -Name OPENAI_API_KEY -Value
or
export OPENAI_API_KEY=

oh yea then you have to set the api in agent settings for the LLM you are using


Add fee waiver to this form

Specifically mentioned in the Next Steps that you can fill out a fee waiver when filing. This would be a good first one to start with. Related to https://github.com/mplp/docassemble-FeeWaiverRequest/issues/1.

probably going to hold off on adding fee waive to concentrate on getting other interviews opened.


3D Human Pose Estimation Using Deep learning

Deep Learning Simplified Repository (Proposing new issue)
:red_circle: Project Title: 3D Human Pose Estimation  using Deep Learning
:red_circle: Aim: To predict 3D coordinates of human body joints from 2D images.
:red_circle: Dataset: Synthetic dataset generated using 2D pose data and corresponding 3D coordinates.
:red_circle: Approach: Utilize 3-4 algorithms such as CNNs for image processing and regression networks for 3D coordinate prediction. Compare accuracy scores to determine the best-performing model. Perform exploratory data analysis (EDA) prior to model creation.

📍 Follow the Guidelines to Contribute in the Project:

You need to create a separate folder named as the Project Title.
Inside that folder, there will be four main components:

Images - To store the required images.
Dataset - To store the dataset or information/source about the dataset.
Model - To store the machine learning model you've created using the dataset.
requirements.txt - This file will contain the required packages/libraries to run the project on other machines.

Inside the Model folder, the README.md file must be filled up properly, with proper visualizations and conclusions.

:red_circle::yellow_circle: Points to Note:

The issues will be assigned on a first-come, first-serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include the issue number along with it.
Follow Contributing Guidelines & Code of Conduct before you start contributing.

:white_check_mark: To be Mentioned while taking the issue:

Full name: Alolika Bhowmik
GitHub Profile Link: https://github.com/alo7lika
Email ID<EMAIL_ADDRESS>Participant ID (if applicable): GSSOC Contributor
Approach for this Project: Use CNNs and regression networks for 3D human pose estimation.
What is your participant role? (Mention the Open Source program): GSSOC Contributor

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

Assign me the task under GSSOC EXT 24  and HACKTOBERFEST @abhisheks008

Similar problem statement is already present in this repository hence closing this issue as duplicate.


Create zh-tw.json

Merged to  master manually after limited testing (as in, I can't read Chinese, but the text changed when I picked the language preference '正體中文' and a quick reverse google translate of the zh-tw.json file seemed ok.)


[FEATURE] Better detection of incoherent CacheNames options

Problem
With the introduction of the builder in v0.20 FusionCache got a nice way to configure the various options and components, in a very flexible way.
In one particular scenario though, it is possible to specify something incoherent: a single instance with multiple CacheNames, by using both the high level AddFusionCache("MyCache") and the WithOptions(...) methods, like this:
services.AddFusionCache("foo")
  .WithOptions(options => {
    options.CacheName = "bar";
  });

This does not make any sense of course, but it is a case that is currently not proactively detected by FusionCache, so the runtime behaviour may lead to some surprises, which is not nice.
A slightly different and more subtle way to fall into this trap is this:
services.AddFusionCache()
  .WithOptions(options => {
    options.CacheName = "bar";
  });

This may happen because the developer didn't notice the AddFusionCache(name) overload, and thought about setting the CacheName via the WithOptions(...) method.
It should be noted that, while it may seems like a valid way to specify the CacheName and so it should be supported, that is not the case because the CacheName specified via the AddFusionCache(name) is fundamental since the name is used for different things while building the FusionCache instance, like when trying to get named options via IOptions<FusionCacheOptions> and more things internally.
Finally, in crucial places like these, it's normally better to have one correct way to setup things, so the official way remains AddFusionCache(name).
Solution
An InvalidOperationException exception should be thrown when trying to instantiate the cache, typically via the IFusionCacheProvider.GetCache(name) method.
A slightly different case is for registering the default cache (a FusionCache with the default name, which can be resolved by simply having an IFusionCache param in a ctor instead of having to use an IFusionCacheProvider param): in this case the exception would be thrown by .net when trying to resolve the param.
Finally, xml docs for the related methods and exception thrown should be made better to account for this scenario, and ideally they should give clear instructions about how to correctly register named caches or to avoid changing the cache name via the WithOptions(...) when using the DI/builder approach.
Thanks Alberto!
I'd like to thank @albx that allowed me to stumble upon this special case: he's been kind enough to invite me to one of his live coding events (italian language) as a guest and see him move his first steps with FusionCache live.
That has been a really nice experience, and on one hand it allowed me to validate that the various design and naming approaches I took along the years have been solid and intuitive, and on the other hand it made me discover a small niche scenario that could've been made even better (this one).

Thanks Alberto!
I'd like to thank @albx that allowed me to stumble upon this special case: he's been kind enough to invite me to one of his live coding events as a guest and see him move his first steps with FusionCache live.

That has been a really nice experience, and on one hand it allowed me to validate that the various design and naming approaches I took along the years have been solid and intuitive, and on the other hand it made me discover a small niche scenario that could've been made even better (this one).

My pleasure @jodydonetti. It has been a really nice and interesting experience and I'm really happy that this experience gave a little contribution to this project :)

Hi all, I just released v1.0.0-preview1 🥳
Please try it out so we can spot any potential issue before the official v1.0, thanks!

Hi all, I just released preview2 🥳
Please give it a try, thanks!

Hi all, I've finally released v1.0 🥳
Feels a little unreal tbh, but yep: v1.0 is out.


Update sites.yml

This PR is:

[x] Adding a new domain
[ ] Updating existing domain size
[ ] Changing domain name
[ ] Removing existing domain from list
[ ] Website code changes (512kb.club site)
[ ] Other not listed

[x] I used the uncompressed size of the site
[x] I have included a link to the GTMetrix report
[x] The domain is in the correct alphabetical order
[x] This site is not a ultra lightweight site
[x] The following information is filled identical to the data file

I confirm that I have read the FAQ section, particularly the two red items around minimal pages and inappropriate content and I attest that this site is neither of these things.

[x] Check to confirm

- domain: catdrout.xyz
  url: https://catdrout.xyz
  size: 506
  last_checked: 2022-05-28

GTMetrix Report: https://gtmetrix.com/reports/catdrout.xyz/WD0Kk8lh/

Fixed

It seems like you updated the size as well. Do you have a new report as a proof?🙂

let me generate a report

give me 24 hours i need to fix something real quick

Merge

I don't know if the results of Pingdom are on par with what we're using. Let's stick to GTMetrix, to keep it fair with everyone else.

Just a heads up GTMetrix is what we officially use, however if the site can not be scanned an alternative is used on a case by case.

https://gtmetrix.com/reports/catdrout.xyz/2PVmEzlH/
Page size 313 kb uncompressed


Remove redundant Rewrite call

Closes #3859

Can you add a test that shows what is fixed?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: michaelstaib:white_check_mark: PascalSenn:x: Artur GordashnikovArtur Gordashnikov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Closing this issue since the CLA was not signed.


Chore: PowerShell script for docker build

Changelog Description
Added PowerShell script to run docker build.
Testing notes:

Run ./tools/docker_build (with possible variant centos7 or debian)
Build should be in ./build once finished

Shouldn't this be added to readme? What is actually a use case for this in OP?

Shouldn't this be added to readme

Added, if you think there should be more, don't be shy and add more :)

What is actually a use case for this in OP?

To be able to create linux builds on windows...


[Workspace Feeds] Double header on the Expensify Card

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:
Action Performed:

Add account to workspaceFeeds beta
Sign in with test account
Select Manage my team’s expenses
Enter any business name / personal name
Navigate to the workspace editor of the newly created workspace
Navigate to More features tab
Toggle on the feature
Navigate to the Expensify Card page
Select Issue new card, give the user a $2 limit
Follow the steps for an OPEN bank account (option 3) of this SO
Finish the setup process
Issue a card
Navigate back to the Expensify Card page

Expected Result:
Only see one Expensify Card header.
Actual Result:
Two Expensify Card headers are shown.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Hey, I'm Viktoryia from Callstack, I've been working on this page, so I can take a look.


Anisotropic Laplace, Advection, and Advection-Diffusion solutions

Questions:

Dependencies on LinearAlgebra, StaticArrays?
Is it okay to limit allowable types to Float64? (What about complex? I don't know how to type the function without a Union datatype.)
Pretty (and reliable? no exactness guarantees..) way to display an example for Float64 coefficients that?

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:

I think this is good to go except for the doctests failure, which I don't understand..


Fix zero_grad when opt_class is None

zero_grad breaks if opt_class=None because self.optimizers_dict is not defined. This PR fixes the issue.

@Adel-Moumen, could you please take a look?

zero_grad breaks if opt_class=None because self.optimizers_dict is not defined. This PR fixes the issue.

In which case do we have opt_class=None and self.optimizers_dict=None at the same time ?

I added some checks to deal with the case opt_class is not None and self.optimizers_dict is None. I also fixed a painful import message from kmeans. I'm awaiting for a reply by Luca regarding my previous message, and then, I will merge it.

The problem is that self.optimizers_dict is defined only if self.opt_class is not None https://github.com/speechbrain/speechbrain/blob/develop/speechbrain/core.py#L1052:
if self.opt_class is not None:
    if self.remove_vector_weight_decay:
        all_params = rm_vector_weight_decay(self.modules)

    self.optimizer = self.opt_class(all_params)

    self.optimizers_dict = {"opt_class": self.optimizer}

    if self.checkpointer is not None:
        self.checkpointer.add_recoverable("optimizer", self.optimizer)

Hence if self.opt_class=None, when you call zero_grad it errors out because the variable self.optimizers_dict doesn't exist. I think the latest commits you made address the issue.
Using a Brain without passing opt_class can be useful in some advanced use cases (e.g. in continual learning when you want to compute some gradient statistics over the whole dataset without performing any parameter update).

The problem is that self.optimizers_dict is defined only if self.opt_class is not None https://github.com/speechbrain/speechbrain/blob/develop/speechbrain/core.py#L1052:
if self.opt_class is not None:
    if self.remove_vector_weight_decay:
        all_params = rm_vector_weight_decay(self.modules)

    self.optimizer = self.opt_class(all_params)

    self.optimizers_dict = {"opt_class": self.optimizer}

    if self.checkpointer is not None:
        self.checkpointer.add_recoverable("optimizer", self.optimizer)

Hence if self.opt_class=None, when you call zero_grad it errors out because the variable self.optimizers_dict doesn't exist. I think the latest commits you made address the issue.
Using a Brain without passing opt_class can be useful in some advanced use cases (e.g. in continual learning when you want to compute some gradient statistics over the whole dataset without performing any parameter update).

OK I see... I tried to reproduce your example on the Transducer baseline, by removing init_optimizers and opt_class, it creates an issue on the side of optimizers_step because we do expect an optimiser. I added a check, if we do not have opt_dict and opt_class then we simply return from this function. What do you think? Could you please let me know if now everything works on your end ?


use yaml.v3 library

mostly resolve dpendabot issue#10 (modules/markup/markdown/renderconfig.go still uses v2)

CI failure is related(maybe affected by a breaking change?)

CI failure is related(maybe affected by a breaking change?)

Or perhaps fixed by v3.0.1?


How to configure docker-registry.yml to store images in the storage path specified in prod?

I am using the following docker-registry.yml file for my private docker-registry.
What do I have to do in order to store images in the storage path specified in prod?
Basically once changed the file, I restarted the docker-registry service but the push operation still stores images in /tmp/registry.
common: &common
    issue: '"docker-registry server"'
    # Default log level is info
    loglevel: _env:LOGLEVEL:debug
    # Enable debugging (additional informations in the output of the _ping endpoint)
    debug: _env:DEBUG:true
    # By default, the registry acts standalone (eg: doesn't query the index)
    standalone: _env:STANDALONE:true
    # No search backend
    search_backend: sqlalchemy
    # SQLite search backend
    sqlalchemy_index_database: _env:SQLALCHEMY_INDEX_DATABASE:sqlite:////tmp/docker-registry.db

local: &local
    <<: *common
    storage: local
    storage_path: _env:STORAGE_PATH:/tmp/registry

dev:
    <<: *local
    loglevel: _env:LOGLEVEL:debug
    debug: _env:DEBUG:true
    search_backend: _env:SEARCH_BACKEND:sqlalchemy

prod: &prod
    <<: *local
    storage_path: _env:STORAGE_PATH:/data

Hi @joda70 - any update?


Add execution time for each build in e2e tests

Add execution time for each build in e2e tests.
For issue: https://github.com/redhat-developer/build/issues/192

The final result looks like:
2020-05-12T13:21:53Z 1 Creating build kaniko-custom-context-dockerfile
2020-05-12T13:21:53Z 1 Amended object: name='kaniko-custom-context-dockerfile', image-url='<IP_ADDRESS>:5000/redhat-developer/build-e2e:kaniko-custom-context-dockerfile'
2020-05-12T13:21:53Z 1 Build kaniko-custom-context-dockerfile created
2020-05-12T13:21:53Z 1 TaskRun is not yet generated!
2020-05-12T13:23:26Z 1 Test build 'kaniko-custom-context-dockerfile' is completed after 1m29s !

All result can be found:
https://travis-ci.org/github/redhat-developer/build

/lgtm

This data might be a good way to improve the speed of builds in future?

Hi @sbose78 ,
I think this data at least can help us to verify the speed of the buildrun.
In future, we can have a base line for each buildrun, such as:

kaniko: xxx seconds
buildpacks: xxx seconds
etc ...

Then we can use this base line to check if there is any performance issue in the new change or build.
I don't have idea about improve the speed of builds, but the data can help us to analyze and then back to improve our code manually :)

/retest

/lgtm

/assign @otaviof

/lgtm
/approve


[Feature request] generic svg icon support

https://github.com/jgthms/bulma/issues/1867
Add some sort of generic support for mutli line svg files as I commented in issue linked above.
The example I posted is by no mean great but an input on how it could be implemented. The example is not updating pointer or color for example.
Since our project will not be able to handle the full suit of for example Font Awesome I plan to start using only a handful of their fonts but not as web fonts but as svg code. And to keep it clean I want to have them in one source file and fetch the code for the svg as described above. It would be great if Bulma Fluent could support it out of the box. Thanks!

I will see if that is possible, currently I am focusing on getting the main things ready. Which should be soon I believe.
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: Grovkillen<EMAIL_ADDRESS>Sent: Tuesday, May 22, 2018 12:14:21 PM
To: mubaidr/bulma-fluent
Cc: Subscribed
Subject: [mubaidr/bulma-fluent] Feature request (#21)
jgthms/bulma#1867https://github.com/jgthms/bulma/issues/1867
Add some sort of generic support for mutli line svg files as I commented in issue linked above.
The example I posted is by no mean great but an input on how it could be implemented. The example is not updating pointer or color for example.
Since our project will not be able to handle the full suit of for example Font Awesome I plan to start using only a handful of their fonts but not as web fonts but as svg code. And to keep it clean I want to have them in one source file and fetch the code for the svg as described above. It would be great if Bulma Fluent could support it out of the box. Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/mubaidr/bulma-fluent/issues/21, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACHqboYDk18AI-7zDpckgh8ka2Is0W2gks5t07rNgaJpZM4UIF-a.

extra style needed for this to look good:

navbar setup:

			 <button title='Toggle Main Menu' class='button is-white'><object data='icons.svg#logo'></object></button>

Menu

								<object class='icon' data='icons.svg#logo'></object>

							Dashboard


fix: make spend_ecash not overspend by default

The default behavior of spend_ecash is a foot-gun: if no notes of the correct denominatons are available it will return the next bigger note without regard for the amount over-spent. This was ok for expert integrators, but is a massive foot-gun for people less familiar with the code base.
This PR makes spend_ecash fail if the exact amount cannot be provided and introduces a new spend_ecash_expert function that can be used by people relying on the old behavior.
This is mostly relevant to the Web SDK, but also the CLI. cc @maan2003 @alexlwn123

This PR makes spend_ecash fail if the exact amount cannot be provided and introduces a new spend_ecash_expert function that can be used by people relying on the old behavior.

but what would ui do in that case?
what is the path to resolve that issue.

what is the path to resolve that error

A simple UI will not provide resolution, a fancy UI will try to come online and re-issue or use the expert mode to accept a certain degree of overspending. Ideally we'd have better support for creating exact-sized e-cash bags while online, but till we do I'd prefer integrators not paying attention to not shoot themselves in the foot.


webpack-bundle-analyzer for stats

Changes proposed on this pull request:

add webpack-bundle-analyzer to view the bundle contents and sizes in a webpage

Reviewers

@carloluis
@matiasdelgado
@rrivem
@marina-acosta

Coverage remained the same at 100.0% when pulling 10a1dea83fa5c250f48ad6395ce22c2325409d99 on feature/webpack-bundle-analyzer into b2b192ae9642675c5b7220cf06eff1fa243ab50f on develop.


[E][esp32-hal-misc.c:94] disableCore0WDT(): Failed to remove Core 0 IDLE task from WDT

I have the message in console:
[E][esp32-hal-misc.c:94] disableCore0WDT(): Failed to remove Core 0 IDLE task from WDT
when adding more the one stepper service, but all works fine
I think, we need check disabling watchdog in void ESP_FlexyStepper::startAsService(void)

Indeed I never checks this use case of starting multiple services.
Feel free to submit a pull request if you have a working solution

Indeed I never checks this use case of starting multiple services.
Feel free to submit a pull request if you have a working solution

This is not a critical check. I thought about adding the following functionality, although I'm not sure if it is in demand:
the ability to specify the core on which it will be executed when creating a Task, for example:
stepper.startAsService ();
the task will be created on default core
stepper.startAsService (0);
the task will be created on core 0
stepper.startAsService (1);
the task will be created on core 1

This is not a critical check. I thought about adding the following functionality, although I'm not sure if it is in demand:
the ability to specify the core on which it will be executed when creating a Task, for example:
stepper.startAsService ();
the task will be created on default core
stepper.startAsService (0);
the task will be created on core 0
stepper.startAsService (1);
the task will be created on core 1

This is a good idea, I will check on that tomorrow, should be easy to implement

This is a good idea, I will check on that tomorrow, should be easy to implement

If you wish, I can create a pull request with these changes.

If you wish, I can create a pull request with these changes.

Yes, Please go ahead, I will review ASAP once I receive the PR
Thanks

Yes, Please go ahead, I will review ASAP once I receive the PR
Thanks

#Voha888:adding-dual-core-support
Due to my poor knowledge of the English language, I did not add comments to the code.
I made two commits.
The first one adds the ability to specify the kernel for the background process
The second, when creating multiple instances of the process (several stepper motors), removes the message from Serial: [E] [esp32-hal-misc.c: 94] disableCore0WDT (): Failed to remove Core 0 IDLE task from WDT
It was not done very nicely, but I did not find a method to check if WDT is disabled or not.

#Voha888:adding-dual-core-support
Due to my poor knowledge of the English language, I did not add comments to the code.
I made two commits.
The first one adds the ability to specify the kernel for the background process
The second, when creating multiple instances of the process (several stepper motors), removes the message from Serial: [E] [esp32-hal-misc.c: 94] disableCore0WDT (): Failed to remove Core 0 IDLE task from WDT
It was not done very nicely, but I did not find a method to check if WDT is disabled or not.

thanks for the updates @Voha888, I will review tonight and merge if all is good

thanks for the updates @Voha888, I will review tonight and merge if all is good

In the examples, I did not find the use of several stepper motors at the same time.
When you add the changes, I can create an example using multiple stepper motors on multiple processor cores.

In the examples, I did not find the use of several stepper motors at the same time.
When you add the changes, I can create an example using multiple stepper motors on multiple processor cores.

Sure can do.
I put some comments on your pull request for minor changes to be performed before merging. Maybe you can have a look at it

Sure can do.
I put some comments on your pull request for minor changes to be performed before merging. Maybe you can have a look at it

Thank You!
I see you changed the name of my pull request, but I don't see any other fixes. Please tell me where to go to see them?

Thank You!
I see you changed the name of my pull request, but I don't see any other fixes. Please tell me where to go to see them?

I added some comment on some lines of code that you changed in the pull request

I added some comment on some lines of code that you changed in the pull request

Sorry, but I don`t see any your comments on this link https://github.com/pkerspe/ESP-FlexyStepper/pull/10/files
Where have you posted these comments? Give me a link please.

Sorry, but I don`t see any your comments on this link https://github.com/pkerspe/ESP-FlexyStepper/pull/10/files
Where have you posted these comments? Give me a link please.

Sorry, my bad, I forgot to submit the review.you should see it now

Sorry, my bad, I forgot to submit the review.you should see it now


Fixes #2415. Hide global setting fix behind sbt.globalsettingfix

We are hiding a bug fix on global setting that was not importing auto
imports because fixing this via sbt/sbt#2399 breaks the source
compatibility: sbt/sbt#2415
I've split out the relevant portion of the scripted test into
global-settings, and marked it pending.
/cc @timcharper, @dwijnand

Thinking about this more I'm now in agreement with a feature flag. :+1:
Even if it's just for the remainder of 0.13, can we find a less opaque name than sbt.globalsettingfix? Not sure but perhaps something like sbt.enable.autoimports.in.global?
Also we should tweaks notes so people know can learn how to benefit from this fix.

Not sure but perhaps something like sbt.enable.autoimports.in.global?

Using dot (.) delimited English phrase I don't think is consistent with other flags we do have, which are partially documented to be fair in http://www.scala-sbt.org/0.13/docs/Command-Line-Reference.html and peppered around the code via sys.props and Boolean.getBoolean.
As per tweaking notes, could we do it after the merge? I'm about to get on a flight, and if possible I'd like to get RC2 sooner without involving Travis waiting.

I'm happy to tweak both the words and the formatting, just looking for something a little more informative. sbt.global.autoimports to match sbt.global.base?
Sure we can do notes later, let's just remember :) Have a safe flight and enjoy the conference.

@dwijnand Added a commit from :airplane:.

Ugh, I'd merge if I could. Punching Travis into going green.


incorrect intrinsicContentSize

Hello.
I use this view in my project. Thanks.
But intrinsicContentSize calculated not correct.
rows count is incorrect.
i use it in scrollview. i want to resize height constraint of tagview and get height of content. in my project it's 16 rows but this method calculate height using 13 rows.

Intrinsic Content Size returning wrong size #105
find answer here.


landing page new links

The documentation changed address. This PR is just updating the landing page to reflect those changes.

A new docs website will be available for this.


"--after-rebuild-hook" runs before "--after-initial-build-hook"

is this issue currently blocking your project? (yes/no): No
is this issue affecting a production system? (yes/no): No

Context

node version: v14.0.0
module version with issue: 6.3.0
last module version without issue: unknown
environment (e.g. node, browser, native):  macOS BigSur
used with (e.g. hapi application, another framework, standalone, ...): CRA
any other relevant information:

What are you trying to achieve or the steps to reproduce?
I added the initial and rebuild hooks as follows:
  "scripts": {
      "hotbuild": "cra-build-watch -v -b webapp/myapp --after-initial-build-hook 'config/inital.sh -d webapp/myapp -w web.xml' --after-rebuild-hook 'config/rebuild.sh",
     ...
 }

What was the result you got?
✔ after rebuild hook: Rebuild complete. [OK]

✔ after initial build hook: Initial build. Complete. [OK]

What result did you expect?
On the initial build, I should only see the "after initial build hook" and should never see the "after rebuild hook".
On subsequent builds,  I should only see the "after rebuild hook".

What was the result you got?
✔ after rebuild hook: Rebuild complete. [OK]

✔ after initial build hook: Initial build. Complete. [OK]

What result did you expect?
On the initial build, I should only see the "after initial build hook" and should never see the "after rebuild hook".
On subsequent builds, I should only see the "after rebuild hook".

I'm getting the same output as you: after rebuild hook is console.log before after initial build hook. But does your script still work in the sequence you expect i.e. config/rebuild.sh is run after config/initial/sh`?  It's only the shell feedback is is out of order, correct?

It didn’t actually occur to me to check.
From: Trang Le @.>
Sent: Monday, April 26, 2021 2:19 AM
To: Nargonath/cra-build-watch @.>
Cc: Alex Lesniak<EMAIL_ADDRESS>Author @.***>
Subject: Re: [Nargonath/cra-build-watch] "--after-rebuild-hook" runs before "--after-initial-build-hook" (#282)
This message originated from outside Trinidad Benham. Please use caution when opening attachments, clicking links, or responding to this email.
What was the result you got?
✔ after rebuild hook: Rebuild complete. [OK]
✔ after initial build hook: Initial build. Complete. [OK]
What result did you expect?
On the initial build, I should only see the "after initial build hook" and should never see the "after rebuild hook".
On subsequent builds, I should only see the "after rebuild hook".
I'm getting the same output as you: after rebuild hook is console.log before after initial build hook. But does your script still work in the sequence you expect i.e. config/rebuild.sh is run after config/initial/sh`? It's only the shell feedback is is out of order, correct?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/Nargonath/cra-build-watch/issues/282#issuecomment-826617748, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APGMDWY2A3WAPB45T2AIFVTTKUOWNANCNFSM4UT5DKIA.
DISCLAIMER: This communication, along with any attachments, is intended only for the use of the addressee and may contain legally privileged and confidential information. If you are not the intended recipient, you are hereby notified that any dissemination, distribution or copying of any information contained in or attached to this communication is strictly prohibited. If you have received this message in error, please notify the sender immediately and destroy the original communication and its attachments.
P Please consider the impact of printing this email
This message has been scanned for malware by Websense. www.websense.com

Sorry I don't have time to maintain this project anymore so I'll archive it and add a note in the README. Feel free to fork it as you see fit.


Run GraphQL query based on cursor position.

If there are multiple operations in the GraphQL query it automatically choose
which operation to run based on the cursor position.

This is a very well done PR, thanks!
I will also leave some actual review comments but I just wanted to have a brief high-level discussion about this feature first.
While I do think this feature is useful (and I know it's part of GraphiQL), it seems like there is potential to cause confusion since there's no obvious indication that the cursor position is controlling the selected query.
A quick improvement could be to highlight the selected query name based on the currently active OperationName. I'm perfectly happy making this (or similar) improvement after merging this PR. However, if you felt like adding this yourself that would be awesome too.
Thoughts?

Ok, how to highlight? (in terms of style)
I thought on these two alternatives:

the selected query have syntax color

the selected query have a bolder operation name

(I'm not good on design stuff 😅)

Ooo I like grayscaling everything else but I'm not sure how difficult that is to implement. If it's not easy, I would also be fine with using Codemirror's markText function to highlight the background of the query name.
Here's a code snippet of how it works.
editor.markText({line: 6, ch: 26}, {line: 6, ch: 42}, {className: "styled-background"});

Setting up the precise colors to use may be tricky since it has to work with the Insomnia theme system. But, if you want to add the basic implementation I can help fine-tune it if needed.

Docs, if needed https://codemirror.net/doc/manual.html#api_marker

I have worked on it using codemirror textmarker.
The result is nice! Using graphql documentAST helped a lot.
Let me work on a little issue introduced in this PR; a little refactor is
necessary :)
Il mer 20 giu 2018, 05:30 Gregory Schier<EMAIL_ADDRESS>ha
scritto:

Docs, if needed https://codemirror.net/doc/manual.html#api_marker
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/getinsomnia/insomnia/pull/990#issuecomment-398613180,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AExGXuAYCx8cMpw--yKfhVwQsqHb0nKFks5t-cHMgaJpZM4Uqx8q
.

Awesome! I'm looking forward to it 😄
Let me know if you need any help! 👍

It seems like this change didn't make it into the docs: https://support.insomnia.rest/article/61-graphql


WebSocketRpcClient's connect leaks memory on failure

This would happen when retries are enabled.
WebSocketRpcClient.__aenter__ retries connecting indefinitely:
return await retry(**self.retry_config)(self.__connect__)()

If __connect__ keeps failing - memory usage gradually increases (more noticeably when configuring fast retry strategy).
This is due to __connect__ not cleaning resources on exceptions:

The websocket object is not cleaned
The RpcChannel object is not closed

This was found while debugging: https://github.com/permitio/opal/issues/274

Fix merged


Group export buttons

Gropus the export buttons into a dropdown because it overlays names and namespaces in the case of long names as shown in the first screenshot.

The new UI groups this now:

[x] Ensure that you followed http://eclipse.github.io/winery/dev/ToolChain#github---prepare-pull-request. Especially, we require a single commit
[x] Ensure that the commit message is a good commit message
[x] Ensure to use auto format in all files
[ ] Change in CHANGELOG.md described
[ ] Tests created for changes
[x] Screenshots added (for UI changes)

Can one of the admins verify this patch?

I would put "Delete" before export, because hitting the rightmost button is easier than a button in the middle. Otherwise: LGTM


thinks I can remove testImplementation after adding compileOnly

Build scan link
https://scans.gradle.com/s/w4puysfgcc2ms
Plugin version
1.3.0
Gradle version
------------------------------------------------------------
Gradle 8.6
------------------------------------------------------------

Build time:   2024-02-02 16:47:16 UTC
Revision:     d55c486870a0dc6f6278f53d21381396d0741c6e

Kotlin:       1.9.20
Groovy:       3.0.17
Ant:          Apache Ant(TM) version 1.10.13 compiled on January 4 2023
JVM:          21.0.2 (Eclipse Adoptium 21.0.2+13-LTS)
OS:           Linux 6.6.19-1-MANJARO amd64

(Optional) reason output for bugs relating to incorrect advice
Calculating task graph as configuration cache cannot be reused because file 'build.gradle.kts' has changed.
Type-safe project accessors is an incubating feature.
> Task :buildSrc:checkKotlinGradlePluginConfigurationErrors
> Task :buildSrc:generateExternalPluginSpecBuilders UP-TO-DATE
> Task :buildSrc:extractPrecompiledScriptPluginPlugins UP-TO-DATE
> Task :buildSrc:compilePluginsBlocks UP-TO-DATE
> Task :buildSrc:generatePrecompiledScriptPluginAccessors UP-TO-DATE
> Task :buildSrc:generateScriptPluginAdapters UP-TO-DATE
> Task :buildSrc:compileKotlin UP-TO-DATE
> Task :buildSrc:compileJava NO-SOURCE
> Task :buildSrc:compileGroovy NO-SOURCE
> Task :buildSrc:pluginDescriptors UP-TO-DATE
> Task :buildSrc:processResources UP-TO-DATE
> Task :buildSrc:classes UP-TO-DATE
> Task :buildSrc:jar UP-TO-DATE
> Task :jpa:processResources NO-SOURCE
> Task :jpa:processTestFixturesResources NO-SOURCE
> Task :jpa:findDeclaredProcsMain UP-TO-DATE
> Task :jpa:serviceLoaderMain UP-TO-DATE
> Task :jpa:findDeclarations UP-TO-DATE
> Task :jpa:findDeclaredProcsTest UP-TO-DATE
> Task :jpa:artifactsReportMain UP-TO-DATE
> Task :jpa:explodeCodeSourceTest UP-TO-DATE
> Task :jpa:explodeCodeSourceMain UP-TO-DATE
> Task :jpa:explodeCodeSourceTestFixtures UP-TO-DATE
> Task :jpa:findDeclaredProcsTestFixtures UP-TO-DATE
> Task :jpa:explodeJarMain UP-TO-DATE
> Task :jpa:compileJava UP-TO-DATE
> Task :jpa:findInlineMembersMain UP-TO-DATE
> Task :jpa:graphViewMain UP-TO-DATE
> Task :jpa:graphViewTestFixtures UP-TO-DATE
> Task :jpa:graphViewTest UP-TO-DATE
> Task :jpa:classes UP-TO-DATE
> Task :jpa:abiAnalysisMain UP-TO-DATE
> Task :jpa:explodeByteCodeSourceMain UP-TO-DATE
> Task :jpa:synthesizeDependenciesMain UP-TO-DATE
> Task :jpa:jar UP-TO-DATE
> Task :jpa:synthesizeProjectViewMain UP-TO-DATE
> Task :jpa:compileTestFixturesJava NO-SOURCE
> Task :jpa:serviceLoaderTestFixtures UP-TO-DATE
> Task :jpa:testFixturesClasses UP-TO-DATE
> Task :jpa:artifactsReportTestFixtures UP-TO-DATE
> Task :jpa:computeActualUsageMain UP-TO-DATE
> Task :jpa:explodeJarTestFixtures UP-TO-DATE
> Task :jpa:abiAnalysisTestFixtures UP-TO-DATE
> Task :jpa:testFixturesJar UP-TO-DATE
> Task :jpa:explodeByteCodeSourceTestFixtures UP-TO-DATE
> Task :jpa:findInlineMembersTestFixtures UP-TO-DATE
> Task :jpa:compileTestJava UP-TO-DATE
> Task :jpa:synthesizeDependenciesTestFixtures UP-TO-DATE
> Task :jpa:artifactsReportTest UP-TO-DATE
> Task :jpa:serviceLoaderTest UP-TO-DATE
> Task :jpa:explodeByteCodeSourceTest UP-TO-DATE
> Task :jpa:synthesizeProjectViewTestFixtures UP-TO-DATE
> Task :jpa:explodeJarTest UP-TO-DATE
> Task :jpa:synthesizeProjectViewTest UP-TO-DATE
> Task :jpa:findInlineMembersTest UP-TO-DATE
> Task :jpa:computeActualUsageTestFixtures UP-TO-DATE
> Task :jpa:synthesizeDependenciesTest UP-TO-DATE
> Task :jpa:computeActualUsageTest UP-TO-DATE
> Task :jpa:computeAdvice UP-TO-DATE
> Task :jpa:filterAdvice FROM-CACHE

> Task :jpa:reason

----------------------------------------
You asked about the dependency 'com.xenoterracide:tools:0.0.0-SNAPSHOT (libs.java.tools)'.
You have been advised to remove this dependency from 'testImplementation'.
----------------------------------------

Shortest path from :jpa to com.xenoterracide:tools:0.0.0-SNAPSHOT (libs.java.tools) for compileClasspath:
:jpa
\--- com.xenoterracide:tools:0.0.0-SNAPSHOT

There is no path from :jpa to com.xenoterracide:tools:0.0.0-SNAPSHOT (libs.java.tools) for runtimeClasspath

Shortest path from :jpa to com.xenoterracide:tools:0.0.0-SNAPSHOT (libs.java.tools) for testCompileClasspath:
:jpa
\--- com.xenoterracide:tools:0.0.0-SNAPSHOT

Shortest path from :jpa to com.xenoterracide:tools:0.0.0-SNAPSHOT (libs.java.tools) for testRuntimeClasspath:
:jpa
\--- com.xenoterracide:tools:0.0.0-SNAPSHOT

There is no path from :jpa to com.xenoterracide:tools:0.0.0-SNAPSHOT (libs.java.tools) for testFixturesCompileClasspath

There is no path from :jpa to com.xenoterracide:tools:0.0.0-SNAPSHOT (libs.java.tools) for testFixturesRuntimeClasspath

Source: main
------------
* Uses 1 class: com.xenoterracide.tools.java.annotation.Initializer (implies implementation).

Source: test
------------
* Uses 1 class: com.xenoterracide.tools.java.function.PredicateTools (implies testImplementation).

Source: testFixtures
--------------------
(no usages)

BUILD SUCCESSFUL in 1s
53 actionable tasks: 2 executed, 1 from cache, 50 up-to-date
Configuration cache entry stored.

Describe the bug
The @Initializer is only needed at compile time, so I set my library as compileOnly but PredicateTools which is part of the same library is actually runtime and I added it for use as testImplementation
To Reproduce
I suppose you could add my library to a project, here's the annotation
https://github.com/xenoterracide/java-commons/blob/main/module/tools/src/main/java/com/xenoterracide/tools/java/annotation/Initializer.java
here's the failing build https://github.com/xenoterracide/spring-app-commons/actions/runs/8382923636/job/22957653966
In order to use the latter repo you'll need to set up github credentials gradle.properties
ghUsername=<your gh user>
ghPassword=<a class pat that can read packages>

Expected behavior
no error
Additional context

Facing the same issue

Could you try with the latest version?

I don't have this anymore


Change Butler code

Changed calculations inside butler_function and butler_derivative functions, attached slide gives some info

@lpgaff : Do you know how I can test this? (probably best to not merge before)

@ACeulemans I have tested on the Rn data. See the results in the attached image. Blue is the old method and red is your new method.
Ex_ebis_compare.pdf

This does however introduce another definition of alpha in Reaction.cc which could be confusing.

So no big shifts or changes. What is a bit puzzling is that it seems most bins seem to have less counts in general, is the minimization failing more often?

@dj-clarke Did you change the commented sections in the constructor, and in MakeReaction? If you only change the butler_function (and it’s derivative) it will still use the triangle/alpha method

Yes, I changed the commented sections to solve for z rather than alpha and then calculated the lab angle from this z.

Previous comparison was slightly incorrect, I had combined a run file where I shouldn't have. I have attached the corrected comparison. Same overall result but slightly less difference between counts in bins.
Ex_ebis_compare_new.pdf

Thanks for testing @dj-clarke. Do you also have comparisons of the Ex vs z/theta plots? I wonder if this straightens out the lines at all? It should have the biggest effect close to the knees in the kinematics, which is why I think we see the largest differences at high Ex, where the acceptance of the array is lower and you get relatively more events near to the knees.

I am going to accept the changes by @ACeulemans in any case, because it just fixes the mistakes in the Butler function. I think we need to work on the derivative though, because we currently treat psi as a constant. However, it is a function of r_max, which in turn is a function of alpha, which in turn is a function of z... Maybe Wolfram Alpha is needed to get a proper solution, if one even exists.
Going forward, if we make this the default, we can update the other sections of the code appropriately.

Ex_vs_theta_alpha.pdf
Ex_vs_theta_butler.pdf

Interesting. Doesn't really change the resolution or straighten up any of the curves, but it does kill the events below the knees maybe?
There is a second solution to the equation, which represents data in the knee. I think this may be in the secodn solution to psi = 2asin(r_det/r_max), which would come at psi = 2(pi - asin(r_det/r_max)).
If we input this solution, would we only get data below 10 degress, i.e. in the backbend of the knees?

I also tried to run the butler on my data, but the data gets cut, probably I missed something with the (un)commenting.
@lpgaff Perhaps it would be easier to implement simply a boolean in the header to switch between both methods. Maybe even add it to the settings file. If ok for you I can
Reaction.txt
implement it.

I don't know what has been missed, it looks ok at a quick glance. I have no added a pre-processor flag to the code at the top of Reaction.cc. This can be uncommented to switch to the Butler algorithm. It's untested though... see 8a7414b3ae040627eaa90213f35a73b2ffed41bc


Add Server Blacklist and Whitelist [WIP]

Contains
fix issue #1608.
Summary
Implementation for server whitelisting/blacklisting. Netty doesn’t allow refusing connections, but it is possible to immediately close a connection after opening one. I do this by making the network system force disconnect the client if the client ID is found on the blacklist. The client is notified when they are blocked by a new message in the scheduleTimeout function. To make it easier to communicate if the client is on a blacklist or not, protobuf ServerInfoMessage has the blacklist/whitelist added.
Details
AbstractClient and ReadWriteStorageManager both have an added null check for if an entity exists, as the server crashes without the changes. The server appears to be trying to unload a nonexistent entity without the checks.
For the protobuf changes, the only new thing is the server’s blacklist/whitelist is sent across ServerInfoMessage. Changes in NetworkSystemImpl getServerInfoMessage method provide the data for the new protobuf change.
NetworkSystemImpl also is the location where the server rejects or accepts the client. All that is done is the blacklist file is found and if the client’s ID is found on the list, the client is immediately force disconnected.
ClientConnectionHandler is changed so that the user can receive feedback about whether or not they have been blacklisted. The scheduleTimeout function was moved to after the NetMessage was declared. It looks to me that everything still works correctly, and we need it there to access the blacklist. The NetMessage needs to be initialized so we can tell the client that they have been blacklisted, otherwise it just tells them that the server timed out, which is a confusing error message.
I got most of my inspiration for the new blacklist/whitelist manager class from the blacklist/whitelist from the Server facade's ServerAdminsManager class as it accomplishes a similar task to what I am trying to do. The new class doesn’t do much at the moment, but it could be accessed easily from some other source, such as the server facade. I should be able to integrate it better into the rest of code when I get the time to make the finishing touches to the code.
How to test
At the moment, the blacklist appears to work most of the time with the minimal testing that I have done.

Run the game once to generate the blacklist/whitelist files.

Add your client ID to the blacklist in JSON format. For example, my blacklist.json contains the line:

 ["6a5f11f7-4038-4ef0-91ac-86cb957588b1","01264d12-27cf-4699-b8e2-bdc92ac8ef73"]
These two IDs are for my first and second clients. To find your own client ID, you can run the code with a normal client and headless client, and look at the testing print statement that says “ID: <client ID>.”

Try to connect to a server and observe how it says that the client is on the blacklist. Also try to connect with another client and notice how nothing is changed.

Outstanding before merging
This is a work in progress and there are many things that still need to be done.

[ ] Implementation for the whitelist needs to be completed.
[ ] Allow users to be blacklisted/whitelisted by IP address.
[ ] Need to add some unit tests.
[ ] Add javadocs
[ ] Will need translation work? The current implementation in the scheduleTimeout function uses a hardcoded English string for “Server stopped responding” on timeout. I am a bit confused by this, but I think that either this gets changed into a translated string somewhere else or this is an oversight.

Uh oh, something went wrong with the build. Need to check on that

All of the tests seem to be failing on this line with an NPE:
 if (blacklistedIDs.contains(client.getId())){
Looks like I might need to add a null check or two.

Hooray Jenkins reported success with all tests good!

Poking @engiValk for review of this one and any related security concerns :-)

Just a few changes for this most recent commit. The new whitelist functionality is essentially just the blacklist functionality with a few minor logic and variable changes. The blacklist/whitelist files are generated on first run with the change to StateHeadlessSetup. There are also a bunch of new null checks. Also, the previous commit is actually not temporary.
I am concerned about using the CoreRegistry class since it isn't encouraged to do so. The ClientConnectionHandler class is the only one where I added it, and CoreRegistry is already used in an existing method. I figure that when the time comes to refactor CoreRegistry out of the class, my usages could be changed without too much difficulty.

Hooray Jenkins reported success with all tests good!

Thanks to you both for the feature, the nice review work, and the adjustments. Keep it coming and we'll get this merged soon :-)

Some of the requested changes have been done in the newest commit. There are still some bugs though, and one of them is serious. If you click join game and quickly switch to custom and join the server, you can have the error message say "Disconnected From Server" when it should say something about the blacklist. The blacklist blocks and accepts connections as appropriate, but for some reason connecting as an authorized user causes the following NPE:
20:59:36.320 [main] ERROR o.t.e.event.internal.EventSystemImpl - Failed to invoke event
java.lang.NullPointerException: null
	at org.terasology.logic.characters.CharacterMovementSystemUtility.setToState(CharacterMovementSystemUtility.java:75)
	at org.terasology.logic.characters.ClientCharacterPredictionSystem.onCharacterStateReceived(ClientCharacterPredictionSystem.java:117)
	at org.terasology.logic.characters.ClientCharacterPredictionSystemMethodAccess.invoke(Unknown Source)
	at org.terasology.entitySystem.event.internal.EventSystemImpl$ByteCodeEventHandlerInfo.invoke(EventSystemImpl.java:516)
	at org.terasology.entitySystem.event.internal.EventSystemImpl.sendStandardEvent(EventSystemImpl.java:279)
	at org.terasology.entitySystem.event.internal.EventSystemImpl.send(EventSystemImpl.java:270)
	at org.terasology.entitySystem.entity.internal.BaseEntityRef.send(BaseEntityRef.java:204)
	at org.terasology.network.internal.ServerImpl.processEvent(ServerImpl.java:244)
	at org.terasology.network.internal.ServerImpl.processMessages(ServerImpl.java:276)
	at org.terasology.network.internal.ServerImpl.update(ServerImpl.java:187)
	at org.terasology.network.internal.NetworkSystemImpl.update(NetworkSystemImpl.java:324)
	at org.terasology.engine.subsystem.common.NetworkSubsystem.preUpdate(NetworkSubsystem.java:46)
	at org.terasology.engine.TerasologyEngine.tick(TerasologyEngine.java:430)
	at org.terasology.engine.TerasologyEngine.mainLoop(TerasologyEngine.java:400)
	at org.terasology.engine.TerasologyEngine.run(TerasologyEngine.java:376)
	at org.terasology.engine.Terasology.main(Terasology.java:154)

Hooray Jenkins reported success with all tests good!

Well, the error is saying that there is no LocationComponent for the gaze entity returned by GazeAuthoritySystem.getGazeEntityForCharacter(entity).
            LocationComponent gazeLocation = gazeEntity.getComponent(LocationComponent.class);             gazeLocation.setLocalRotation(rotation);
That's a new area to me.   Maybe @Josharias can help as he committed the component.
It doesn't seem likely that this problem is caused by this patch, but maybe I've overlooked something.

It turns out that the serious bug was caused by two things:

processRemovedClient function was trying to remove a client that wasn't even connected, causing problems with the server. This also generated a problematic player file which caused crashes.
Kicked status was not being reset correctly. This made it so that whenever a blacklisted client tried to connect, the next client was said to have been kicked, and the function that normally cleans up a client requires that the client isn't clicked.

Now that these are taken care of, I can work on the rest of the feedback and try to finish this up.
Also, a few of the null checks I added are no longer needed with these recent changes, so I removed them.

Hooray Jenkins reported success with all tests good!

Uh oh, something went wrong with the build. Need to check on that

Hooray Jenkins reported success with all tests good!

I think the changes I have made cover everything up to this point. We could merge this now and it would work, although I would like to try to block by IP addresses as well if I don't run out of time before GSOC coding starts.
@gianluca-nitti I'm fine with this taking a long time to merge, it is a fairly big change after all. I get to learn more about the code review process as well.

Hooray Jenkins reported success with all tests good!

For blacklisting and whitelisting IP addresses, I'm not sure if it will be easily possible to do. I'm going to leave a few notes here to explain my process and provide an approach for if someone else (or me) decides to add this in later. My understanding is that the IP address of the connecting client is first available in the join() method of NetworkSystemImpl through the line connectCheck.await();
You can then get the IP address of the client by calling connectCheck.getChannel().getLocalAddress()
Note that the function is getLocalAddress because the join() function is called by the client; getRemoteAddress returns the address of the server. The problem is that this code is client side, and it isn't safe to do client side authentication.
The server does get the client IP address in ServerConnectionHandler. Maybe it also gets it in other places. The messageReceived() and receivedConnect() methods appear to be the last places where the client's IP address is visible through channelHandlerContext.getChannel().getRemoteAddress(). receivedConnect() calls some functions that add the connecting client to the newClients variable in NetworkSystemImpl, where it gets added by update() and goes through my blacklisting code. What we need to have done is we need to make the IP address available in the same place as a context so that ServerConnectListManager can check to see if the IP address is blocked.
I think it would be easiest to send the IP address to the networkSystem in ServerConnectionHandler. We could make a new function setIPAddress() and a new global variable IPAddress in NetworkSystemImpl, then call networkSystem.setIPAddress(channelHandlerContext.getChannel().getRemoteAddress()) inside receivedConnect(). I don't know if this is acceptable from a code quality standpoint.
Either way, with GSoC coding starting in a few days I don't want to take on any more work than I have to. So if there aren't any other changes I need to make, this is ready for merging.

Thank you @Inei1, I had a final look, tested everything out again and for me it's ok to merge.
Ping @mkienenb to see if he approves as well and @Cervator for a possible merge

Yes, I don't think you should be trying to add in ip address checking as part of this PR.   I was going to say that earlier but didn't get around to it.
You can remove the work-in-progress tag as soon as you are no longer planning to make changes.   (ie, as soon as you want it to be reviewed and merged).

Hooray Jenkins reported success with all tests good!


change block statement into expression

automatically fixed when #228 is closed

cannot support block expression due parser restriction

reopen due to commit 39967caafb2937134f41b7bc8eccaef959839f53


Github workflow updates

There are some things that can solve test problems:

Update the usage of the keepalive workflow, see https://github.com/ddev/ddev-addon-template/blob/eba2da81ee29c2c8dfbfb84f9513a9354ec1405e/.github/workflows/tests.yml#L89-L91
Add https://github.com/ddev/ddev-addon-template/blob/eba2da81ee29c2c8dfbfb84f9513a9354ec1405e/.github/workflows/tests.yml#L18-L20

Thanks, I've added this!


Fix azureblob splitfilepath to work for windows file paths

Description
Just a small change to the splitfilepath function so it will now also work with file paths that have backslashes.
Motivation and Context
The splitfilepath function would not work with windows file paths with '\' in them.
Have you tested this? If so, how?
I have ran my own jobs with this change and have also included a test for paths with a backslash.

This PR is changing a module I don't know so much about. Can you do a git blame and look for other contributors who have edited those files and @-mention them to summon them as reviewers of this patch? Once others +1. I can help press "merge".

@manish


Deploy first version to hex.

Should probably be a 0.1.0 because I don't think we've found a stable API yet,
Was previously depending on a git version of stdlib but features now exist in stdlib 0.10.0
NOTE gleam_bitwise depends on an uncompatible version of stdlib currently, can either post a new gleam_bitwise version to hex otherwise will require stdlib to be specified in the deps.

Good idea, I'll do that now!
Rebar will override the bitwise stdlib version, and I think mix will too? Did you have a problem when you tried it?

mix you need to explicitly set override on your mix deps. but that's been working fine when I remember

It would be ideal if we didn't need to do that. I wonder if there's something like ~> that I'm supposed to use with rebar.

Don't know about rebar.
Even with the ~> in mix it doesn't take you over breaking changes. so If i set bitwise to ~> 0.10.0 that works for 0.10.x but not 0.11.0

Aye, I know. I'm wondering if there's something we can use in rebar to get that same flexible versioning, it sounds it it's an exact version when combined with mix from what you're saying

with mix it's variable in the last digit you define.
~> 0.10.0 = 0.10.0 0.10.1
~> 0.10 = 0.10.0 0.10.1 0.11.0

Aye, as I've said I'm familiar with ~>

oh you mean "an exact version when [rebar] combined with mix"

Oops, yes, sorry!


Adjust keyboard and gamepad bindings

When I started the latest build, I assumed that the arrow keys or WASD would control Player 1 (as they had in previous builds). Since this wasn't working, I assumed that the controls might be broken. @Cheeseness told me through IRC that Y and H are the current controls for player 1.
Unless there is a good reason to keep the left player controls as Y/H, I'd recommend changing it to W/S (since a lot of games use WASD for movement). Furthermore, I think the action buttons for the left player should be Left Shift and Left Ctrl.
As for the right player, I'd recommend arrow keys/Right Shift/Right Ctrl. This would mirror the other players controls and most closely align with other games. These controls would also allow for either one handed or two handed play, depending on preference.
And if InputManager actually allows this: when there is only one player per computer (such as online or single player offline), then either W/S or up/down could be used for the player's paddle (since up/down is the most intuitive for people who might skip the instructions quickly).
I don't want to step on anybody's toes, so I won't make these changes myself.
@Cheeseness also mentioned that the gamepad bindings also may need some tweaking, but I haven't yet tested the gamepad option myself.

They're yh because using left shift, left ctrl, left at with yh is uncomfortable.

Ideally 2 players on one keyboard would use 2 hands.

I don't know how to edit comments on phone. Should have read using one hand on wd and one hand on left shift/alt/ctrl is uncomfortable

Here's my suggestion after some thought: Up/Down/Right Shift/Right Ctrl for right player. W/S/Left Shift/Left Ctrl for left player, Besides being symmetrical and more likely to be discovered based on similar mappings in other games, this would allow either player to use 1 or 2 hands for their controls.
I don't want to step on anybody's toes so I've I will update the description according to these ideas rather than make the changes myself. But I believe my suggestion isn't any less comfortable than the current setup.
And if InputManager actually allows this: when there is only one player per computer (such as online or single player offline), then either W/S or up/down could be used for the player's paddle (since up/down is the most intuitive for people who might skip the instructions quickly).

@Cheeseness, @lightsoda, @framental, what do you think of my suggestion in the comment above?

Have you tried using WS  and left shift/ctrl/alt with two hands for more
than just a few seconds?  Your hands have to overlap and it's awkward, in
my experience.  I do agree that WS is a more obvious choice for left player
because it is so commonly used, but I don't know if it can be comfortably
used.
Up Down right shift/ctrl/alt should be right player mappings now unless
someone has purposefully or mistakenly changed them.  Right player should
also be first player, unless that has changed.
On Apr 26, 2017 4:59 PM, "Paul"<EMAIL_ADDRESS>wrote:

@Cheeseness https://github.com/Cheeseness, @lightsoda
https://github.com/lightsoda, @framental, what do you think of my
suggestion in the comment above?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Double-Fine-Game-Club/pongball/issues/115#issuecomment-297553774,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE1A8OAeOR5HUhG0vvvgPRK9A40c-ceRks5rz75LgaJpZM4NJFkA
.

@fragmental, yes, I tested with two hands for about a minute (please note that my proposal doesn't require using the Alt keys at all, which makes a huge difference). With my keyboard and keeping my left hand close to the left edge of the Shift button, it feels good, but I know that hands and keyboards vary. I noticed somebody did a pull request that changed controls a bit but not quite to what I proposed. In the end I think everybody could have a different opinion about optimum controls and it just depends on what @Cheeseness decides to do regarding the pull requests.

possibly.  There are the power buttons and the flipper buttons.  Which is 3 or 4?

I'm comfortable using WS and left shift/ctrl/alt with two hands and don't have any problems.
Different keyboards, hand sizes and finger preferences, and whether a player is sitting in them middle or to the left of the keyboard are all definitely going to have an impact here - I think anybody offering feedback must have had two people sitting at their keyboard for that feedback to be relevant (otherwise we're likely to be getting experiences from people sitting in the middle of the keyboard clouding things up).
Right now, first player is left player, and the right player's power controls are space and left alt.

I'm still getting around to reviewing pull requests. I'll see how #122 looks when testing.

As for first player left, if no one intentionally changed that, then I did
it by mistake when I was working on the UI.  If I did it, it's a simple
change, and can be done by changing the order of the paddle spawn prefab in
the load assets script in the unity (profiler, is that what it's called?
I'm afk).  But that's only IF I changed it.
Hopefully, at some point we can overhaul inputs and handle them in-game,
making them easier to remap for the player, but unity doesn't make that
easy, so that will probably have to be post AF stuff.
On Apr 26, 2017 6:30 PM, "Cheeseness"<EMAIL_ADDRESS>wrote:

I'm still getting around to reviewing pull requests. I'll see how #122
https://github.com/Double-Fine-Game-Club/pongball/pull/122 looks when
testing.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Double-Fine-Game-Club/pongball/issues/115#issuecomment-297569842,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE1A8GMAShnh4qu0VjQJh6P8VwobH7xSks5rz9OagaJpZM4NJFkA
.

Not to bring up a dead issue, but I tried and you were correct, w/s is more comfortable when you're left of the keyboard.  Absolutely 100%
Seems like a good reason to make first player right side, though, since middle of the keyboard would be the natural sitting position of a single player.  Possibly trifling detail? shrug

I've popped up some changes in #129 that address legitimate bugs that came in with the first implementation, and tries to address some of the comfort/awkwardness concerns laid out here.

#129 has been merged. I'll close this one here, and we can open new issues (referencing this and others if needed) to address any further refinements/changes that are needed.


Controller instance integration tests

Add integration tests that tests scenarios around creating and updating ServiceInstances.

@staebler @jpeeler should this have do-not-merge?

@staebler @jpeeler Okay - I'm not clear on whether this PR is meant to be mergeable as-is, or whether jpeeler is going to open a new PR for this stuff.  Can you clarify?

@pmorie My understanding is that this PR is meant to merge as is. @jpeeler will be creating additional tests that will come in future PRs.

Yeah I just pulled this PR and kept on going. So once this merges I'll just rebase.

Fantastic work with this. LGTM.


Assert for property name not in response shows failure

e.g. response does not contain property xyz. I enter assert as xyz,  = (comparator) , null or blank (expected value). This gives failure.
In above case it should give success.

When property is altogether not present, any comparison must fail. So closing this issue.


Illegal instruction on ESP32C3 after update

I updated esp-wifi in my project which implements BLE gatt server. Now it crashes with exception 'Illegal instruction' at start. Seems async_ble example works fine. I double checked used dependencies and features, it is completely same.
Could anybody known that may went wrong?
Exception 'Illegal instruction' mepc=0x40385e5c, mtval=0x0000b170
0x40385e5c - ram_bt_set_tx_gain
    at ??:??
0x0000b170 -
    at ??:??
TrapFrame
PC=0x40385e5c         RA/x1=0x40385e54      SP/x2=0x3fc86658      GP/x3=0x3fccea00      TP/x4=0x00000000
0x40385e5c - ram_bt_set_tx_gain
    at ??:??
0x40385e54 - ram_bt_set_tx_gain
    at ??:??
0x3fc86658 - __global_pointer$
    at ??:??
0x3fccea00 - _heap_start
    at ??:??
0x00000000 - os_random
    at /home/bjoern/esp/esp-idf/components/wpa_supplicant/port/os_xtensa.c:48
T0/x5=0x0000005d      T1/x6=0x00000060      T2/x7=0x00006542      S0/FP/x8=0x3fccea90   S1/x9=0x3fc86000
0x0000005d -
    at /home/bjoern/esp/esp-idf/components/wpa_supplicant/src/utils/common.c:563
0x00000060 -
    at /home/bjoern/esp/esp-idf/components/wpa_supplicant/src/utils/common.c:563
0x00006542 -
    at ??:??
0x3fccea90 - _heap_start
    at ??:??
0x3fc86000 - _ZN8esp_wifi6compat12timer_compat6TIMERS17hb3addae244c7180cE
    at ??:??
A0/x10=0x0000002e     A1/x11=0x3fcce9bb     A2/x12=0x3fc8631d     A3/x13=0xfffffffc     A4/x14=0x0000000e
0x0000002e -
    at /home/bjoern/esp/esp-idf/components/wpa_supplicant/port/os_xtensa.c:61
0x3fcce9bb - _heap_start
    at ??:??
0x3fc8631d - phy_param
    at ??:??
0xfffffffc - _rtc_fast_bss_end
    at ??:??
0x0000000e - os_get_time
    at /home/bjoern/esp/esp-idf/components/wpa_supplicant/port/os_xtensa.c:51
A5/x15=0x3fc86000     A6/x16=0x3fc861ea     A7/x17=0x0000000e     S2/x18=0x3fc9c6cc     S3/x19=0x00000000
0x3fc86000 - _ZN8esp_wifi6compat12timer_compat6TIMERS17hb3addae244c7180cE
    at ??:??
0x3fc861ea - phy_param
    at ??:??
0x0000000e - os_get_time
    at /home/bjoern/esp/esp-idf/components/wpa_supplicant/port/os_xtensa.c:51
0x3fc9c6cc - g_phyFuns
    at ??:??
0x00000000 - os_random
    at /home/bjoern/esp/esp-idf/components/wpa_supplicant/port/os_xtensa.c:48
S4/x20=0x3fcceae8     S5/x21=0x3c0468fc     S6/x22=0x00000002     S7/x23=0x00000000     S8/x24=0x00000000
0x3fcceae8 - _heap_start
    at ??:??
0x3c0468fc - _ZN8esp_wifi14common_adapter13phy_init_data21PHY_INIT_DATA_DEFAULT17h7aefdfa83e8ce392E
    at ??:??
0x00000002 - os_random
    at /home/bjoern/esp/esp-idf/components/wpa_supplicant/port/os_xtensa.c:48
0x00000000 - os_random
    at /home/bjoern/esp/esp-idf/components/wpa_supplicant/port/os_xtensa.c:48
0x00000000 - os_random
    at /home/bjoern/esp/esp-idf/components/wpa_supplicant/port/os_xtensa.c:48
S9/x25=0x00000000     S10/x26=0x00000000    S11/x27=0x00000000    T3/x28=0x00000001     T4/x29=0x0000002e
0x00000000 - os_random
    at /home/bjoern/esp/esp-idf/components/wpa_supplicant/port/os_xtensa.c:48
0x00000000 - os_random
    at /home/bjoern/esp/esp-idf/components/wpa_supplicant/port/os_xtensa.c:48
0x00000000 - os_random
    at /home/bjoern/esp/esp-idf/components/wpa_supplicant/port/os_xtensa.c:48
0x00000001 - os_random
    at /home/bjoern/esp/esp-idf/components/wpa_supplicant/port/os_xtensa.c:48
0x0000002e -
    at /home/bjoern/esp/esp-idf/components/wpa_supplicant/port/os_xtensa.c:61
T5/x30=0x00000012     T6/x31=0x00001bf4
0x00000012 - os_get_time
    at /home/bjoern/esp/esp-idf/components/wpa_supplicant/port/os_xtensa.c:51
0x00001bf4 -
    at ??:??

MSTATUS=0x00001801
0x00001801 -
    at ??:??
MCAUSE=0x00000002
0x00000002 - os_random
    at /home/bjoern/esp/esp-idf/components/wpa_supplicant/port/os_xtensa.c:48
MTVAL=0x0000b170
0x0000b170 -
    at ??:??

Seems like the exceptions happens when executing code from IRAM. Probably the memory consumption increased and now the stack grows into code/data
Do you know which revision was working and which revision stopped working?

You could try https://github.com/esp-rs/esp-hal/pull/616 to see if it is the same problem.
Unfortunately, it's not enough to just patch the esp-hal dependency since esp-hal now depends on a more recent version of the PAC. But you can use a local copy of esp-wifi and update the dependency there and then patch your dependencies.
Otherwise, we plan to have new releases of esp-hal soon (plus updating esp-wifi)

@bjoernQ Thanks a lot! Seems issue solved.


Istio Ingress Informers

This PR adds informers for Istio CRD and adds a IstioClient to the main function

@rheaj99 This PRs commit history has high number of merge commits. These merge don't add any value plus make it harder to read.
In order to avoid this, You can choose to use git fetch origin master and git rebase origin/master.


Suggestion: memoize the list of primes

Hello, I used this library in attempt at Advent of Code puzzle day 20.  However, I found the approach I used to be quite slow, due to my repeated use of primes.Factorize().  Digging into it, it seems the library re-calculates the list of primes every time Factorize is run.  If this library is still being maintained, I think it would be a good improvement to memoize (aka cache) the list of primes.  Perhaps append to the primes list if required to factor a higher number than had been requested before.

Thanks!
You're saying about this, right?
https://github.com/otiai10/primes/blob/master/factor.go#L18
Yep, I prefer readability than speed so far.
But ('cause I knew someone (you) uses this lib, thank you!) I'm willing to improve speed now.
related: #3

naive imple
before
BenchmarkUntil	       2	 756366134 ns/op
BenchmarkFactorize	       2	 784614548 ns/op

after
BenchmarkUntil	100000000	        17.6 ns/op
BenchmarkFactorize	   10000	    123662 ns/op

https://github.com/otiai10/primes/commit/40b3480a9ee7c3cf1f82d74baa6e3ed1db5b649c
problem as is
It is effective ONLY WHEN you repeat calculations on EXACTLY equal numbers.
solution to be
thinking...

#5


Support uploading a pre-built WASM module

💡 Feature request

Overview and problem statement
Right now, wrangler supports the building a WASM module as part of the build and upload process with  type = "rust", but does not support uploading a pre-built WASM module. I propose adding a new key to the wrangler configuration to allow developers to specify the filepath location of any modules they want to bind (similar to how they already specify the webpack_config location). I imagine it would work similar to kv_namespaces.
Basic example
# wrangler.toml
name = "$SCRIPT_NAME"
type = "webpack"
account_id = "$ACCOUNT_ID"
workers_dev = true

# Just as webpack config files are located like this,
webpack_config = "./webpack.config.js"

# and KV namespaces are configured in an array like this,
kv_namespaces = [
  { binding = "FOO", id = "0f2ac74b498b48028cb68387c421e279", preview_id = "6a1ddb03f3ec250963f0a1e46820076f" },
  { binding = "BAR", id = "068c101e168d03c65bddf4ba75150fb0", preview_id = "fb69528dbc7336525313f2e8c3b17db0" }
]

# WASM modules could be configured as follows:
wasm_modules = [
  { binding = "MYWASM", location = "./my_wasm_file.wasm" }
]

Wrangler would simply have to locate the file, reference it in the metadata, and upload it alongside the script as a part of the PUT call to upload a new worker.

Have you seen https://github.com/cloudflare/wrangler/pull/1677

Have you seen https://github.com/cloudflare/wrangler/pull/1677

Ah, sweet! Didn't realize that PR will solve this too. Thanks for highlighting that, @koeninger.

Ah, sweet! Didn't realize that PR will solve this too. Thanks for highlighting that, @koeninger.

@GregBrimble since you are using the webpack type, https://github.com/cloudflare/worker-emscripten-template/blob/master/webpack.config.js#L24-L31 should fix your issue. It needs to be located at a specific path to get uploaded by wrangler. I don't think #1677  will fix that.

@GregBrimble since you are using the webpack type, https://github.com/cloudflare/worker-emscripten-template/blob/master/webpack.config.js#L24-L31 should fix your issue. It needs to be located at a specific path to get uploaded by wrangler. I don't think #1677  will fix that.

Amazing—thanks for that example, @xtuc! If #1677 doesn't address it, and there's interest for what I'm proposing, I'd be happy to try make a PR. Anyone on the wrangler team able to say if that's something they'd like to support?

Amazing—thanks for that example, @xtuc! If #1677 doesn't address it, and there's interest for what I'm proposing, I'd be happy to try make a PR. Anyone on the wrangler team able to say if that's something they'd like to support?

#1677 does in fact support uploading pre-built wasm modules.

@xortive @koeninger would either of you happen to know the answer to @sepbot 's last question?
I've been scouring the web trying to figure out how (if at all?) I can use ffmpeg.wasm or ffmpeg.js in a worker

In case it helps, setting wasm_modules = { MYWASM = "./something.wasm" } in wrangler.toml seems to work for me.


x1000

It looks like all of the underlying commands that are being used to set expirations for @Memoize* (setex and expire AFAIK) use seconds instead of milliseconds, so this change correctly reflects that in the docs.

:+1: thanks!

no problem!


Tmsv patch 3

@sobolevn I've made modest edits thanks to your help.
So if pyproject.toml is ok and ready for the merge, the next step is to create pyproject.lock, right?

Coverage remained the same at 100.0% when pulling cad22f545eec513b4a022da29372a1cfe3d85b0a on tmsv:tmsv-patch-3 into 02a75ba4b5083f0c551ab115e02a12ed78c3e6dc on sobolevn:master.