NotoSansOldHungUI-Regular font's source has rendering command problems

There are rendering command problems in NotoSansOldHungUI-Regular fonts. Request date: 2021-03-16
@marekjez86 I opened this Issue because of that problems in #324 PR  must be documented.

@marekjez86 I working on it!

@marekjez86 I replace the UFO files with simple glyphs file. Previous PR for resolve rendering problems had got wrong letterforms. I'll replace the name NotoSansOldHungarianUI.
@marekjez86  What do you think, should I develop Old Hungarian font with minimal amount of ligatures (q, w, x, y, dz and dzs) named NotoSansOldHungarianMinimal? Tamás Rumi so agressive about these ligatures. But, I think, he wants block leading in the standard Old Hungarian font for android devices. The others warned me about it.
So what should I do in your opinion?

@tamasbartos : thank you very much! nagyon szépen köszönjük! Noto needs to support what Unicode has in https://unicode.org/charts/PDF/U10C80.pdf so we are limited to what we can do. Where could I learn about what you propose? Is this somewhere written? Is this the same as what's in the Unicode? If not why are there differences. If you have some references please point them to me. They can be in Hungarian as long as it is a text and NOT PDF or and image.

@tamasbartos : thank you very much! nagyon szépen köszönjük! Noto needs to support what Unicode has in https://unicode.org/charts/PDF/U10C80.pdf so we are limited to what we can do. Where could I learn about what you propose? Is this somewhere written? Is this the same as what's in the Unicode? If not why are there differences. If you have some references please point them to me. They can be in Hungarian as long as it is a text and NOT PDF or and image.

@marekjez86  Thank you for the quick answer. I'll collect links to texts on the net about this theme.

@tamasbartos : thank you very much! nagyon szépen köszönjük! Noto needs to support what Unicode has in https://unicode.org/charts/PDF/U10C80.pdf so we are limited to what we can do. Where could I learn about what you propose? Is this somewhere written? Is this the same as what's in the Unicode? If not why are there differences. If you have some references please point them to me. They can be in Hungarian as long as it is a text and NOT PDF or and image.

There is an article link about foreign letters in the year of 2012 in the Gábor Hosszú's submission by Miklós Szondi:
http://magyarrovas.hu/hosszu-gabor-kiserlete/
There is an article link about foreign letters by rovasinfo:
http://rovas.info/2012/11/szondi-miklos-5-tevedese/
There is the link of Gábor Hosszú's submission in the year of 2012:
https://www.unicode.org/L2/L2012/12014-n4183-hungarian.pdf
As you can see, rovasinfo do not write the full truth about foreign letters.
There isn't any valid document, which describe obligatory to use "Old Hungarian q,x,y,w,dz,dzs" letters or ligatures at all.
There sn't any valid document, which describe obligatory to use "Old Hungarian" ligatures at all.

@marekjez86 I do not know, who asked from David Corbett ligatures, but once, when signed somebody him a mistake, he answered, if he/she doesn't like, then doesn't use. I tried extend sylable like ligatures.by logically, because I saw that some of them were developed, some of them not . It was a halfwork. I want to write that, ligatures aren't required, aren't described, just only "hisgoric symbols", which are in the chart.
That's what you were wondering?

@tamasbartos : thank you very much! nagyon szépen köszönjük! Noto needs to support what Unicode has in https://unicode.org/charts/PDF/U10C80.pdf so we are limited to what we can do. Where could I learn about what you propose? Is this somewhere written?

Everywhere and nowhere.

Is this the same as what's in the Unicode?

No.

If not why are there differences.

During the standardization users divided two parts: 1st part lost money on it, and the others need standard itself as it was used until the earlier 1800s for teaching childrens, etc.

If you have some references please point them to me. They can be in Hungarian as long as it is a text and NOT PDF or and image.

I can't. Most of publication are already in printed books or downloadable from  electronical library of Hungarian National Library "Széchenyi" http://mek.oszk.hu

@marekjez86
the views of the two parties can be seen in the comment:
https://github.com/googlefonts/noto-source/issues/353#issuecomment-856535034
If the google translate it, please look the style of the two articles, too. (rude, offensive words)
My question: Should I give for you another links?
If yes , I need to find them, and paired them.
It was enough?
Please answer for me!

@marekjez86 There are some unexpected issues with the fix of NotoSansOldHungarianUI font.
"Too many offcurves defined for curve." Could you help me, what does it mean?

@marekjez86 I can now resolve "curve" problems, I think.
My question is again: what will happen NotoSansOldHungarian-regular font, which has semi-developed syllable-like ligatures? These are non-prescribed ligatures, which ones are already developed and which ones are not yet developed, too. That font has non-syllable like ligatures, which ones non-prescribed and not useful at all.

@marekjez86 Here is a table made by András Tisza  about his syllable-like and duplicated consonant ligatures:
Table_of_ligatures_Emese_font.pdf
Here is an explanation of main Old Hungarian vowels and consonants:

András Tisza uses consonant + vowel syllable-like ligatures and duplicated consonants because of that, as he wrote me, it optimized. Using vowel + consonant syllable-like ligatures and consonant + vowel syllable-like ligatures together, as he wrote me, can be made the text chaotic.

@marekjez86 Ligature implementations in https://github.com/googlefonts/noto-source/issues/353?_pjax=%23js-repo-pjax-container#issuecomment-859662213 not so easy, but it is not impossible for an experienced reader to read. I can read his ligatures.

Sorry about closing and reopening this issue.

@marekjez86 Noto-fonts project might publish Old Hungarian font with syllable-like ligatures ( it does work https://github.com/googlefonts/noto-source/issues/353#issuecomment-859662213) and as you can read in rovas.info, they use modern letters, so their additional letters as ligatures might to be offered.

@marekjez86 Here is the Emese font full implementation by András Tisza:

As you can see, on several points is different from the strict Unicode chart's letter forms. If we want to develop additional ligatures for NotoSansOldHungarian-Regular font, we might not to follow in several ligature forms of Emese font, might to follow ligature form "rules" of the NotoSansOldHungarian-regular font.
András Tisza implemented in his font the modern letters as ligatures, too.

@marekjez86 There is a pull request #385 . Please merge it, but not publish. Please check me and write for me, which letters have still rendering problems. I can't use the  python script.

@marekjez86  The PR #382 try to resolve NotoSansOldHungarianUI font's rendering problems.

@marekjez86 I won't continue NotoSansOldHungarianUI development. The build process is caotical. There is an UFO command, for example : qcurve, which is in the UFO specification, but translator python script doesn't accept it. Only thing I ask for you develope UI version capital and small letters will be same baseline. UI version do not need additional ligatures.
Tamás Rumi achieved what he wanted, the Noto's Old Hungarian font development was frozen.
There are an another thing that I ask: the additional ligatured version's capital and small letters will be on the same baseline.
I can help Noto project plan ligatures, but in that case I need freehand. I will plan and correct the several modern ligatures, ligature "q", "x", "y", "w", "dz" and "dzs", too, if you agree my help.
Regards:
Tamàs Bartos.

@marekjez86 The ligatured Old Hungarian font needs about 300 small syllable ligatures. Must to remove left-to-right ligatures (these don't work at all.)
If you do not want that huge work, you might to add "q", "w", "x", "y" "dz" and "dzs" ligatures only. Never do halfwork!
Regards:
Tamás Bartos

@marekjez86 I'm waiting Your answer for comment
https://github.com/googlefonts/noto-source/issues/353#issuecomment-868839239
and comment https://github.com/googlefonts/noto-source/issues/353#issuecomment-868845033

@marekjez86 There is an attempt to resolving NotoSansOldHungarianUI in PR in #391

@marekjez86  Plesdr help me about #391 !

@marekjez86 I don't stop resolving this issue.
I won't include ligatures q w x y dz and dzs, because of that, you didn't signed back issue  on the noto-fonts about it.
I'll later will develop syllables. Syllable like ligatures must to be practical, readable, and aesthetic. Several ligatures in András Tisza's font are hardly readable.
I'll make testcases, because of that you could decide, you merge it or not. I don't want make difficult ligatureforms. if I can’t do some of the ligatures according to the criteria, I don’t force it.

@marekjez86 please merge PR #398 and #399 !
PR #398 create an Old Hungarian UI (compact, without additional ligatures) font, which is publicable in noto-fonts project, I think.
PR #399 clean up old version of Old Hungarian UI font. ( this stuffed with rendering problems)
If these PR will be merged, I start working the additional-ligatured version. (NotoSansOldHungarian font)

@marekjez86 We  ( Old Hungarian script users and standardizers ) discussed about "modern ligatures" (q, w, y, x, dz, dzs) that aren't in the Unicode, aren't required in an official font. Without these "ligatures" we can make correct spellchecker (as hunspell library). These are non historic ligatures or letters.

@marekjez86 @davelab6  I'm continue working on the NotoSansOldHungarian font, but unfortunately I must to go to the hospital for 4 or 5 weeks.
The ligature uni10CE5_10CE6 ("Old Hungarian sz"+"Old Hungarian t") and its ltr pair must be removed
Because:

Just its author know what is that.
Its form is irreparable.

I will keep all  the other ligatures, but several form of them needs to be corrected.

@marekjez86 The Old Hungarian UI version's rendering problems are fixed. The NotoSansOldHungarianUI font is done, might to be published. I close this issue.


Question: peer-calls play usage?

Hi,
Just noticed that peer-calls has a play sub-command:
$ dki -t --rm peercalls/peercalls play --help
Usage: play [OPTIONS]
Play RTP streams

Options:
      --audio-fmtp string        audio media format parameters
      --audio-mime-type string   audio mime type (default "audio/opus")
      --audio-ssrc uint32        audio SSRC (default 2)
  -a, --audio-stream string      audio stream to read RTP from
  -c, --config string            configuration to use
  -k, --insecure                 do not validate TLS certificates
  -n, --nickname string          nickname (default "player")
  -r, --room-url string          room URL (default "http://localhost:3000/call/playroom")
      --video-fmtp string        video media format parameters
      --video-mime-type string   video mime type (default "video/vp8")
      --video-ssrc uint32        video SSRC (default 1)
  -v, --video-stream string      video stream to read RTP from

However I'm not actually sure how to use this, what it's for etc... Are there an examples of how to use this? Use-cases?
Moreover what other interesting things can I do with WebRTC and Peer-Calls? (Note: I do believe I have my instance setup properly with a coturn server now finally 🥳)

Found an interesting tool that lets you share your Terminal over WebRTC termishare -- How do I (for example) wire this up into a PeerCalls session?

I added the play command for debugging so it might not always work. It can be used to stream a local video file via ffmpeg into a peer calls room.
Unfortunately I can't recall the exact commands, I'd have to look at my other machine for exact commands to use to do this

Ahh this is very interesting. Do you think we could also do other interesting things with this in general?


parseXml method throws parseerror and adds this node in xml

Here is the error description
Error thrown by setGraphXml() :-
Error: a.push is not a function for parsererror
    at mxObjectCodec.decodeChild (mxClient.min.js:1795)
    at mxObjectCodec.a.decodeChild (mxClient.min.js:1801)
    at mxObjectCodec.decodeChildren (mxClient.min.js:1794)
    at mxObjectCodec.decodeNode (mxClient.min.js:1791)
    at mxObjectCodec.decode (mxClient.min.js:1791)
    at mxCodec.decode (mxClient.min.js:1781)
    at Editor.setGraphXml

parseXml() adds following node during parsing the xml :-
<parsererror xmlns="http://www.w3.org/1999/xhtml" style="display: block; white-space: pre; border: 2px solid #c77; padding: 0 1em 0 1em; margin: 1em; background-color: #fdd; color: black">
This page contains the following errors:

error on line 1 at column 7422: Extra content at the end of the document

Below is a rendering of the page up to the first error.
</parsererror>

Let me know if you need my xml.

Closing this issue since there was extra trailing tag in my xml which caused whole error,


Docker provider implementation

This is a PR that also includes a few previous main commits (whoops?) for documentation

Tagging Documentation Commit


Replace jsonrpc-core with tailored LSP implementation

Added

Add tower-lsp-macros crate containing crate-internal procedural macros.
Define a core subset of JSON-RPC types as outlined in the LSP spec.
Permit Arc<dyn LanguageServer> in addition to Box<dyn LanguageServer>.
Implement support for $/cancelRequest.

Changed

Generate a static routing table with a custom #[rpc] proc-macro which annotates the LanguageServer trait.
Use pure serde to serialize and deserialize client and server requests and responses.
Redefine LspService as Service<Incoming, Response = Option<Outgoing>, Error = ExitedError>.
Implement FusedStream for MessageStream.
Document that LanguageServer::shutdown() will only execute once (as a result of refusing all further requests after call).

Fixed

Refuse all further requests with "invalid request" error after shutdown request is received, as per spec.

Removed

Remove delegate.rs and message.rs.
Remove jsonrpc-core and jsonrpc-derive dependencies.
Remove Server::with_handler() constructor, since it's specific to jsonrpc-core.

Due to the maintenance headache of mapping lsp-types concepts to jsonrpc-core, I've decided to roll out a tailor-made minimal JSON-RPC implementation which leverages lsp-types and serde more directly.
Closes #102.
Closes #145.

This pull request eliminates one more tokio::spawn call in src/client.rs, advancing the state of #180.


added a 'list' option to the ansi command

Had to change the name -> code from a match statement to a vector that generates a hashmap, so it can be listed. Since there are a lot of shortcodes, I figured just a hashmap literal would get a little too big. Let me know if you can think of a more elegant solution - I am sure there is one.
I also wasn't sure how I should actually display the code - I just removed the escape character, but could print it as text if you prefer.
Also added a category to the char command - I missed it in my last commit, figured I would sneak it in.

wow! that was fast! I can't wait to try this out but I'll be a couple hours.  thanks @matthewauld!!!

looks good to me. thanks


malformed DOI "nri2939 [pii]\r10.1038/nri2939" found in Romani 2011 https://www.zotero.org/groups/5435545/bat_literature_project/items/2WK8GVE9

see attached screenshot of https://www.zotero.org/groups/5435545/bat_literature_project/items/2WK8GVE9 shows invalid doi nri2939 [pii]\r10.1038/nri2939 . Expected 10.1038/nri2939

This DOI should be "https://doi.org/10.1038/nri2939", but the link through Zotero still brings me to an original source.

Hi @ajacsherman Thanks for confirming that the DOI is malformed.
I suspect that the Zotero Web UI applies some magic to turn the malformed DOI into a resolvable DOI.
Suggest to change the DOI to 10.1038/nri2939 to make the value consistent with other records.
See e.g., https://www.zotero.org/groups/5435545/bat_literature_project/items/BEGC9EYF/item-details value 10.3390/v8100270 and attached value.

Do you have an exhausted list of corrupt DOIs? I can correct them if you can send me that list.

For a list, see https://github.com/bat-literature/bat-literature.github.io/issues/5 .

Out of 2784 DOI, I found only 46 suspected malformed DOIs by checking whether the DOI started with 10. as extracted from v0.2 with signature hash://md5/be692b93a8edde4c4269be9e7d4ec1d7 generated via
preston ls\
 --algo md5\
 --anchor hash://md5/be692b93a8edde4c4269be9e7d4ec1d7\
 --remote https://linker.bio\
 | grep hasVersion\
 | grep "items?"\
 | preston cat\
 | jq --raw-output .[].data.DOI\
 | grep -v null\
 | sort\
 | uniq\
 | grep -v -E "^10[.]"

are:
Artn 550\rDoi 10.1186/S13059-014-0550-8
arXiv:1505.02710
http://dx.doi.org/10.1038/s41467-018-06779-w
https://doi.org/10.1002/ajp.23240
https://doi.org/10.1002/ece3.4842
https://doi.org/10.1002/ece3.5150
https://doi.org/10.1002/pro.2541
https://doi.org/10.1002/rse2.195
https://doi.org/10.1002/(SICI)1099-145X(199907/08)10:4<311::AID-LDR362>3.0.CO;2-3
https://doi.org/ 10.1017/S0031182019000817
https://doi.org/10.1046/j.0141-6707.2000.00299.x
https://doi.org/10.1098/rsbl.2021.0427
https://doi.org/10.1111/1365-2435.13640
https://doi.org/10.1111/1365-2656.13166
https://doi.org/10.1111/1365-2664.13619
https://doi.org/10.1111/2041-210X.12172
https://doi.org/10.1111/conl.12389
https://doi.org/10.1111/conl.12715
https://doi.org/10.1111/eva.12514
https://doi.org/10.1111/geb.13045
https://doi.org/10.1111/j.1365-2664.2005.01049.x
https://doi.org/10.1111/j.1461-0248.2010.01566.x
https://doi.org/10.1111/j.1469-1795.2006.00073.x
https://doi.org/10.1111/j.1600-0684.2010.00464.x
https://doi.org/10.1111/jzo.12769
https://doi.org/10.1111/mam.12173
https://doi.org/10.1111/mam.12225
https://doi.org/10.1111/mec.15437
https://doi.org/10.1111/tbed.12248
https://doi.org/10.1111/tbed.12522
https://doi.org/10.1111/tbed.12580
https://doi.org/10.1111/tbed.12833
https://doi.org/10.1111/zph.12509
https://doi.org/10.1111/zph.12540
https://doi.org/10.1111/zph.12563
https://doi.org/10.1139/z81-107
https:/ /doi.org/10.1371/journal.pcbi.1009706
https://doi.org/ 10.1371/journal.pntd.0008092
https://doi.org/10.2307/3504205
https://doi.org/10.2903/j.efsa.2015.4161
https://doi.org/10.2903/j.efsa.2017.4890
https://doi.org/10.3158/2158-5520-12.6.1
https://doi.org/10.3389/fimmu.2021.706951
https://doi.org/10.3390/v14010072
nri2939 [pii]\r10.1038/nri2939

Note that 10.2903/j.efsa.2015.4161 is a DOI and has a similar structure as the 2738 other DOIs with valid 10. prefix.

I've included an exhaustive list of DOIs in the v0.2 corpus in the attached file. Most start with 10. as expected.
all-dois.csv

This will take me two days at least. Let's see if we can streamline DOI verification/correction. Looking into it...

@ajacsherman thanks for having a look. Please do note that I noted just 46 suspicious DOIs as listed in https://github.com/bat-literature/bat-literature.github.io/issues/4#issuecomment-2140708382 . If you scan the entire list of DOIs, you might notice the differences in form (e.g., 10. notation, vs non-10. notation).

@ajacsherman I've re-written the DOI syntax check script to include the associated Zotero record url -
using
preston ls\
 --algo md5\
 --anchor hash://md5/be692b93a8edde4c4269be9e7d4ec1d7\
 --remote https://linker.bio\
 | grep hasVersion\
 | grep "items?"\
 | preston cat\
 | jq --raw-output '.[] | select(.data.DOI | length > 0  )  | [ .data.DOI, .links.alternate.href ] | @tsv' | grep -v "^10."\
 | mlr --itsvlite --omd cat

resulted in

suspicious DOI
Zotero record URL

https://doi.org/10.3158/2158-5520-12.6.1
https://www.zotero.org/groups/bat_literature_project/items/LLKZXQQA

https://doi.org/ 10.1371/journal.pntd.0008092
https://www.zotero.org/groups/bat_literature_project/items/TBIXMEZ6

https://doi.org/10.1098/rsbl.2021.0427
https://www.zotero.org/groups/bat_literature_project/items/AX2BJVCL

https://doi.org/10.3390/v14010072
https://www.zotero.org/groups/bat_literature_project/items/J5UDBN83

https:/ /doi.org/10.1371/journal.pcbi.1009706
https://www.zotero.org/groups/bat_literature_project/items/2YYYFWNK

https://doi.org/10.1139/z81-107
https://www.zotero.org/groups/bat_literature_project/items/BE8ZPHQY

https://doi.org/10.2307/3504205
https://www.zotero.org/groups/bat_literature_project/items/BE6KWPH9

https://doi.org/10.1111/jzo.12769
https://www.zotero.org/groups/bat_literature_project/items/CV4THVM6

https://doi.org/10.1111/zph.12563
https://www.zotero.org/groups/bat_literature_project/items/4LIDRK8Q

https://doi.org/10.1111/zph.12540
https://www.zotero.org/groups/bat_literature_project/items/7CAB2PJ5

https://doi.org/10.1111/tbed.12580
https://www.zotero.org/groups/bat_literature_project/items/CYR43UDI

https://doi.org/10.1111/tbed.12833
https://www.zotero.org/groups/bat_literature_project/items/UVJ33NQ4

https://doi.org/10.2903/j.efsa.2017.4890
https://www.zotero.org/groups/bat_literature_project/items/AP43YRHP

https://doi.org/10.2903/j.efsa.2015.4161
https://www.zotero.org/groups/bat_literature_project/items/FK7P8UD4

https://doi.org/10.1002/pro.2541
https://www.zotero.org/groups/bat_literature_project/items/EM3D5ZXL

https://doi.org/10.1111/mam.12173
https://www.zotero.org/groups/bat_literature_project/items/47WJFRSW

https://doi.org/10.1002/ece3.4842
https://www.zotero.org/groups/bat_literature_project/items/6ZT9U43D

https://doi.org/10.1002/(SICI)1099-145X(199907/08)10:4<311::AID-LDR362>3.0.CO;2-3
https://www.zotero.org/groups/bat_literature_project/items/LW3WMY4R

https://doi.org/10.1002/rse2.195
https://www.zotero.org/groups/bat_literature_project/items/C6UM6BA7

https://doi.org/10.1046/j.0141-6707.2000.00299.x
https://www.zotero.org/groups/bat_literature_project/items/5FNF97FV

https://doi.org/ 10.1017/S0031182019000817
https://www.zotero.org/groups/bat_literature_project/items/SHCAKTMI

https://doi.org/10.1002/ece3.5150
https://www.zotero.org/groups/bat_literature_project/items/H7MXWJYM

https://doi.org/10.1111/mam.12225
https://www.zotero.org/groups/bat_literature_project/items/723KLFAS

https://doi.org/10.1111/eva.12514
https://www.zotero.org/groups/bat_literature_project/items/KU4NHBKY

https://doi.org/10.3389/fimmu.2021.706951
https://www.zotero.org/groups/bat_literature_project/items/UU83B294

https://doi.org/10.1111/mec.15437
https://www.zotero.org/groups/bat_literature_project/items/Y7D7J5QM

arXiv:1505.02710
https://www.zotero.org/groups/bat_literature_project/items/T5JZXMWX

Artn 550\rDoi 10.1186/S13059-014-0550-8
https://www.zotero.org/groups/bat_literature_project/items/8E6KDZXE

https://doi.org/10.1111/1365-2664.13619
https://www.zotero.org/groups/bat_literature_project/items/T46CFDTJ

https://doi.org/10.1111/1365-2656.13166
https://www.zotero.org/groups/bat_literature_project/items/UJXMI3CX

nri2939 [pii]\r10.1038/nri2939
https://www.zotero.org/groups/bat_literature_project/items/2WK8GVE9

https://doi.org/10.1111/j.1469-1795.2006.00073.x
https://www.zotero.org/groups/bat_literature_project/items/UM24WNSY

https://doi.org/10.1111/zph.12509
https://www.zotero.org/groups/bat_literature_project/items/IP257X4S

https://doi.org/10.1111/tbed.12522
https://www.zotero.org/groups/bat_literature_project/items/4C7SM4R3

https://doi.org/10.1111/tbed.12248
https://www.zotero.org/groups/bat_literature_project/items/9AJVCVIE

https://doi.org/10.1111/j.1600-0684.2010.00464.x
https://www.zotero.org/groups/bat_literature_project/items/CQVCHDVX

https://doi.org/10.1111/conl.12715
https://www.zotero.org/groups/bat_literature_project/items/6LV7DIQT

https://doi.org/10.1111/j.1365-2664.2005.01049.x
https://www.zotero.org/groups/bat_literature_project/items/3GT3IZ8H

http://dx.doi.org/10.1038/s41467-018-06779-w
https://www.zotero.org/groups/bat_literature_project/items/4XMQKTXT

https://doi.org/10.1111/geb.13045
https://www.zotero.org/groups/bat_literature_project/items/JTH8K6E7

https://doi.org/10.1111/1365-2435.13640
https://www.zotero.org/groups/bat_literature_project/items/VBWGG4WY

https://doi.org/10.1111/j.1461-0248.2010.01566.x
https://www.zotero.org/groups/bat_literature_project/items/E4D2HGPV

https://doi.org/10.1002/ajp.23240
https://www.zotero.org/groups/bat_literature_project/items/BRZA6R7D

https://doi.org/10.1111/conl.12389
https://www.zotero.org/groups/bat_literature_project/items/GPIDWZ4C

https://doi.org/10.1111/2041-210X.12172
https://www.zotero.org/groups/bat_literature_project/items/MF43MGN5

closing this issue to make room for fresh doi review.


bug(Theming): After updating to Material 15 theming no longer works

Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
Hello, everyone, In Material 14 we created our theme file like this:
@import '@angular/material/theming'

$primary: mat-palette($mat-grey)
$accent: mat-palette($mat-blue-grey, A200, A100, A400)
$warn: mat-palette($mat-red)

$theme: mat-light-theme($primary, $accent, $warn)

@include angular-material-theme($theme)

Our CSS files are in Sass and knowing Angular Material's theming APIs are built with Sass, I thought no issues would happen after the update, but every time we change the theme file to the following:
@use '@angular/material' as mat
@include mat.core()
$primary: mat.define-palette(mat.$mat-grey)
$accent: mat.define-palette(mat.$mat-blue-grey, A200, A100, A400)
$warn: mat.define-palette(mat.$mat-red)
$theme: mat.define-light-theme((
color: (
primary: $primary,
accent: $accent,
warn: $warn
),
typography: mat.define-typography-config()
))
@include mat.core-theme($theme)
We get the following error:
SassError: expected ")".
╷
9 │ $theme: mat.define-light-theme((
Reproduction
StackBlitz link:
Steps to reproduce:

Create a project with Angular 15.2.9 and Material 15.2.9
Create a Sass file to define the theme
Try to run the project

Expected Behavior
The theme would be applied no error should be thrown.
Actual Behavior
The error SassError: expected ")".
╷
9 │ $theme: mat.define-light-theme((
Happens
Environment

Angular: 15.2.9
CDK/Material: 15.2.9
Browser(s): Brave
Operating System (e.g. Windows, macOS, Ubuntu): Windows 11

It looks like you're missing semicolons in a few places. Does this work?
@use '@angular/material' as mat;

@include mat.core();

$primary: mat.define-palette(mat.$mat-grey);
$accent: mat.define-palette(mat.$mat-blue-grey, A200, A100, A400);
$warn: mat.define-palette(mat.$mat-red);

$theme: mat.define-light-theme((
  color: (
    primary: $primary,
    accent: $accent,
    warn: $warn
  ),
  typography: mat.define-typography-config()
));

@include mat.core-theme($theme);

I can't add semicolons to a Sass file since it uses indentation instead of curly braces and semicolons to describe the format of the document. It will also through an error do to the semicolons.

Either way this looks like a syntax error somewhere in your theme file, not an issue in Material.

Okay, thank you I will look at this but nothing on the syntax seems wrong, I even copied and pasted what was on the theming tutorial in the material website, and still didn't work, and all I did was remove the semicolons they have. Which is this:
@use '@angular/material' as mat;

$my-primary: mat.define-palette(mat.$indigo-palette, 500);
$my-accent: mat.define-palette(mat.$pink-palette, A200, A100, A400);

// The "warn" palette is optional and defaults to red if not specified.
$my-warn: mat.define-palette(mat.$red-palette);

$my-theme: mat.define-light-theme((
 color: (
   primary: $my-primary,
   accent: $my-accent,
   warn: $my-warn,
 ),
 typography: mat.define-typography-config(),
 density: 0,
));

The theming tutorial uses the .scss syntax, not the indetation-based one which might have some other differences.

I Changed my syntax to $my-theme: mat.define-light-theme((color: (primary: $my-primary,accent: $my-accent,warn: $my-warn),typography: mat.define-typography-config(),density: 0)) so the theme is declared to one line only and fixes the issue


Mobile no floating

@dbatiste cause you know the wc floating buttons. :)
@dlockhart more for the mobile testing setup.
I looked into Galen a little bit and chatted with Anthony quickly.  It looks cool, and could help us with perceptual testing, but I needed to have WCT run in different size viewports.  So Galen didn't seem the right way to go for that (might be like taking a sledge hammer to a small nail).
I found setting the subset iframe width in a separate 'mobile' test index was the easiest/cleanest.  I didn't find any good examples online (such as in an iron component).  In fact I thought Google's own testing of iron-media-query to be lacking.
Needing to test like this is probably somewhat rare-ish, as normally you would just rely on CSS media queries and then something like Galen makes more sense.  In this case I felt I had to rely on JS determining the viewport size because of how widths/paddings/etc are set inline (so I'm using iron-media-query for that).

Related, but not for this PR since the code was already there: I feel like we could be doing a lot more here with events, pure CSS and properties that reflect back to attributes that the CSS is triggering off of. Seems like a lot of JavaScript setting CSS is all.
Basically:

resize/scroll event causes a handler to run
handler recalculates position/size of a few things, sets a property which gets reflected to a HTML attribute
CSS rules kick in based on those attributes and responsive breakpoints

Maybe an easy think you could correct while in here is the binding in attached:
window.addEventListener('resize', this._reposition.bind(this));
The binding should be moved to ready since the bind function results in a new instance of the function.  In order for the clean-up to be done correctly, it needs to reference the same function instance.  So, this should go into ready, and remove the bind call from attached.
this._reposition = this._reposition.bind(this);

@dbatiste Lemme know if that is what you're thinking of.

Almost.  The addEventListener calls should still be in attached, and the removeEventListener calls in detached.  We only want the handlers to fire when the component is attached to the DOM.  Alternatively, you may be able to just use Polymer's listen and unlisten helpers, but to be honest I don't think they really buy much, and I can't remember if they automatically bind to this, which we definitely need.

Right, yeah, that seems obvious now when I think about the wc's lifecycle.  Corrected. :)

LGTM


RMRK2 create - collection: Waiting is too long

I created a collection on RMRK2 and I had to wait around 5 minutes for it to appear in Create - NFT. I think that is too long. Can we do something about it and make it a bit faster? So artists don't lose their patience.
tested on beta

I had to wait around 5 minutes for it to appear in Create - NFT. I think that is too long. Can we do something about it and make it a bit faster? So artists don't lose their patience.

usually it's under <1 minute but I guess we are not refreshing that list iirc

#4752


Added index to Django Association model

This unique_together index on the server_url and handle columns ensures lookups do not result in full table scans.
Fixes #967

@omab please review
FYI @jibsheet

I think it's worth noting that running the migration in this PR against a MySQL database will incur downtime while the index is added (reference).

Acknowledged @rlucioni. I have also filed #970 to address the fact that this table should not store nonces forever. They should be removed once the authorization response is validated. Long-term it might make more sense to use Django's caching layer for this purpose rather than the database model.

@clintonb 👍

@omab thoughts on this?

As per the downtime, handling that is out of the scope of a simple lib, in fact the possible solutions mention in the stackoverflow question are mostly architectural. Still, thanks for the notice.
About the nounces, I agree that they shouldn't reside in the DB and I've been planning on removing that table for a while, probably just use the framework of choise session mechanism.

Thanks!

@omab would it be possible to publish v0.2.20 so that the community can take advantage of this change?

@rlucioni, v0.2.20 released to pypi.

Thank you @omab!


Add more switch Profile Test

@irisdingbj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_operator
111588e40b9222d966734827cb2c4ed745a08189
link
/test gencheck_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/cherrypick release-1.4

@ostromart: new pull request could not be created: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between istio:release-1.4 and istio-testing:cherry-pick-387-to-release-1.4"}],"documentation_url":"https://developer.github.com/v3/pulls/#create-a-pull-request"}

In response to this:

/cherrypick release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Oops, this one should not be cherrypicked, it's in 1.4 already.


Synchronisation blocks at 60%

Operating System: Win 7
MultiBit Version: 0.5.18
Steps to replicate the problem:
Hi i am meeting a strange probleme, when i open multibit the synchronisation don't go to the send, she always blocks at 60%, i need to fix this probleme because i have bitcoin in my wallet i dont want to loose them, thx
screen : http://www.hostingpics.net/viewer.php?id=297114MultibitBeug.jpg

We've seen this sometimes when a user has accidentally set the wrong date on their computer (for whatever reason). Then MultiBit will only sync to the computer's date.  Have a check of that.

Multibit error take my btc , i want my btc back .

I will post any every forum about this bug and how btc owners dont want to resolve it .


Operator Overloading as proposed or like QuickJS

Hello, I am currently looking for an embeddable JS engine and one concern is Operator Overloading: https://github.com/tc39/proposal-operator-overloading/
There is one engine that supports it: https://bellard.org/quickjs/jsbignum.html#Operator-overloading
Which is highly useful for everything related to math (and microcontrollers/robots control their environment via math).
Is this a planned feature or is there some support for it already?

JerryScript implements only features are in the latest ECMAScript specification, sometimes an important and stable stage 3 or stage 4 proposals too. As I see, operator overloading is in a very early stage, it is a stage 1 proposal. I think it's too early to discuss about supporting this feature, let's get back once it become a stage 3 proposal in the future.

Please reopen if the proposal gets to stage 3 or higher.


Question: An isolated way to use Khmer Angkor character reordering function from Keyman

Good morning, Marc!
I would like to get some ideas from you related to the usage of Khmer Angkor keyboard's character reorder/normalize function. Basically, something like this (https://github.com/sillsdev/khmer-character-specification/blob/master/python/scripts/khnormal) but in JavaScript.
Let's say I have a raw text string:
const text = "ស្រ្តី" // 0x179f 0x17d2 0x179a 0x17d2 0x178f 0x17b8

const result = normalize(text)

// => "ស្ត្រី" 0x179f 0x17d2 0x178f 0x17d2 0x179a 0x17b8

Basically, I want to use the normalize() function from Khmer Angkor keyman keyboard.

Sorry for long delay in replying -- I have been away and am now slowly catching up on the backlog.
We have a Python module but not currently anything in Javascript. See convert.ភាសាខ្មែរ.com for a live example (this site is just about to be launched).
Source for the conversion tool is at https://github.com/sillsdev/khmer-character-specification/tree/master/python/scripts
We would certainly welcome a translation of the Python code to a Javascript module!
@MakaraSok @mhosken and @Nnyny may also have thoughts on this!

Thanks for the response, @mcdurdin!

@seanghay please note two bugs identified in khnormal:

https://github.com/sillsdev/khmer-character-specification/issues/10
https://github.com/sillsdev/khmer-character-specification/issues/12

I also have a draft typescript module now which I hope to publish to npm once those two bugs are addressed

Thank you @mcdurdin for pointing this out! Honestly, I have heavily used khnormal script throughout my Khmer text-to-speech and other projects. If there is any test suites that I run and validate, I'll definitely help to fix those bugs.


Allow stacked DocumentArrays to be constructed from list of Documents

Is your feature request related to a problem? Please describe.
The pytorch dataloader's pin_memory implementation requires the data to have this signature
type(data)([pin_memory(sample, device) for sample in data])

This signature does not exist for Stacked DAs, and thus, they cannot be used as the return type of a dataset.
Describe the solution you'd like
An implementation of this constructor for Stacked DAs
Describe alternatives you've considered
None
Additional context
This might not resolve the issues with pin_memory but it would be a step in the right direction.

Deferred as the lack of pin_memory support was identified to not be a significant slowdown at the moment

This will be handled by #1079

I would like to be sure that the PR fixing this actually tackles the underlying problem

Yes it does. Patching the init and from_document_array in this hacky way allows the pin_memory to work.
So it is about having a constructor that can take list value.
    def __init__(
        self: T,
        docs: DocumentArray,
    ):
        if len(docs) > 0:
            docs = DocumentArray[type(docs[0])](docs)
        self._doc_columns: Dict[str, 'DocumentArrayStacked'] = {}
        self._tensor_columns: Dict[str, AbstractTensor] = {}

        self.from_document_array(docs)

    def from_document_array(self: T, docs: DocumentArray):
        self._docs = DocumentArray(docs)
        #self.tensor_type = self._docs.tensor_type
        self.tensor_type = TorchTensor
        self._doc_columns, self._tensor_columns = self._create_columns(
            docs, tensor_type=self.tensor_type
        )

The reason we didnt do a simple patch to it was because we could not reach consensus on whether we liked double parametrization. This is necessary because of this line.
        #self.tensor_type = self._docs.tensor_type
        self.tensor_type = TorchTensor

tensor_type needs to be class level information. However it is currently instance level information.
If we promote it to class level, the type needs to know about it. So we would have double parametrization e.g.
DocumentArray[PairTextImage, TorchTensor]


iojs 2.3.0 name 'openssl_fips' is not defined"

While iojs 2.2.1 has been working fine, I'm unable to install any node-gyp configured modules with --target=2.3.0
$ npm install --target=2.3.0
\
><EMAIL_ADDRESS>install /.../node_modules/usage
> node-gyp rebuild

gyp: name 'openssl_fips' is not defined while evaluating condition 'openssl_fips != ""' in binding.gyp while trying to load binding.gyp
gyp ERR! configure error
gyp ERR! stack Error: `gyp` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onCpExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/configure.js:343:16)
gyp ERR! stack     at emitTwo (events.js:87:13)
gyp ERR! stack     at ChildProcess.emit (events.js:172:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:199:12)
gyp ERR! System Darwin 14.1.0
gyp ERR! command "/usr/local/bin/iojs" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /.../node_modules/usage
gyp ERR! node -v v2.2.1
gyp ERR! node-gyp -v v1.0.3
gyp ERR! not ok

This is reproducible on both mac and a debian box. Just in case it's relevant or helpful:
$ for FLAG in cflags-only-I libs-only-L libs-only-l; do pkg-config --$FLAG openssl; done

-lssl -lcrypto -lz

@BlueWinds what's your binding.gyp look like?

@BlueWinds does this still happen with a new version of io.js?

Works for me on OS X:
Jeremiahs-MacBook-Pro:here-be-dragons Jeremiah$ npm -v
2.11.1
Jeremiahs-MacBook-Pro:here-be-dragons Jeremiah$ node -v
v2.3.0
Jeremiahs-MacBook-Pro:here-be-dragons Jeremiah$ npm i usage
/
><EMAIL_ADDRESS>install /Users/Jeremiah/node_modules/usage
> node-gyp rebuild

  CXX(target) Release/obj.target/sysinfo/src/binding.o
  SOLINK_MODULE(target) Release/sysinfo.node
<EMAIL_ADDRESS>../../node_modules/usage
├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>Jeremiahs-MacBook-Pro:here-be-dragons Jeremiah$

Maybe it has to do with your config?

Happens intermittently for most of us at NodeSource

I realize now I forgot to include a very important piece of the bug report, for which I apologize:
$ node -v
v0.10.31

Globally, an older version of node has been installed. So in my case it's an issue compiling more recent versions using --target when an older version of node is installed globally.
The workaround we've ended up using is to put the version of node I wanted to compile against directly in the path.
PATH=/path/to/iojs-v2.3.3:$PATH npm i usage

more clearly, node-gyp is creating a config from the current node's process.config not from the one targetted or used via --nodedir

Has anyone made any progress on this?   Having a similar issue with nw-gyp.

this is also affecting me as well, 100% of the time.  specifically, electron-rebuild is failing, which calls:
node {/path/to/}npm-cli rebuild --target=version --arch=version
@BlueWinds, your suggestion seems reasonable, however, I dont have the binaries for the versions I need to build against all of the time, which is cumbersome.  I'm on 0.12.7, and @mafintosh ref'd https://github.com/mafintosh/prebuild/issues/14.  maybe it's time to upgrade?

An extra argument --openssl_fips=X worked for me on OS X. https://github.com/nwjs/nw.js/issues/3786.

I'll close, I don't believe this is an issue any longer with the supported release lines.

I seem to getting this error on AWS Lightsail with electron-rebuild.

See: #2534

https://github.com/nodejs/node-gyp/issues/2673#issuecomment-1196931379


Exception on sematic start after installation

After installing sematic for the first time, I try to start and get the following exception. I tried to dig in a bit but didn't find an obvious solution...
python version: Python 3.9.7
11:07:21 root@6b93e1bb3779 algo ±|dev ✗|→ sematic start
Traceback (most recent call last):
  File "/opt/pyenv/versions/3.9.7/bin/sematic", line 5, in <module>
    from sematic.cli.main import cli
  File "/opt/pyenv/versions/3.9.7/lib/python3.9/site-packages/sematic/cli/main.py", line 5, in <module>
    import sematic.cli.start  # noqa: F401
  File "/opt/pyenv/versions/3.9.7/lib/python3.9/site-packages/sematic/cli/start.py", line 12, in <module>
    from sematic.api.server import run_wsgi
  File "/opt/pyenv/versions/3.9.7/lib/python3.9/site-packages/sematic/api/server.py", line 7, in <module>
    import eventlet
  File "/opt/pyenv/versions/3.9.7/lib/python3.9/site-packages/eventlet/__init__.py", line 17, in <module>
    from eventlet import convenience
  File "/opt/pyenv/versions/3.9.7/lib/python3.9/site-packages/eventlet/convenience.py", line 7, in <module>
    from eventlet.green import socket
  File "/opt/pyenv/versions/3.9.7/lib/python3.9/site-packages/eventlet/green/socket.py", line 21, in <module>
    from eventlet.support import greendns
  File "/opt/pyenv/versions/3.9.7/lib/python3.9/site-packages/eventlet/support/greendns.py", line 66, in <module>
    setattr(dns, pkg, import_patched('dns.' + pkg))
  File "/opt/pyenv/versions/3.9.7/lib/python3.9/site-packages/eventlet/support/greendns.py", line 61, in import_patched
    return patcher.import_patched(module_name, **modules)
  File "/opt/pyenv/versions/3.9.7/lib/python3.9/site-packages/eventlet/patcher.py", line 129, in import_patched
    return inject(
  File "/opt/pyenv/versions/3.9.7/lib/python3.9/site-packages/eventlet/patcher.py", line 106, in inject
    module = __import__(module_name, {}, {}, module_name.split('.')[:-1])
  File "/opt/pyenv/versions/3.9.7/lib/python3.9/site-packages/dns/dnssec.py", line 483, in <module>
    from Crypto.PublicKey import RSA as CryptoRSA, DSA as CryptoDSA
  File "/opt/pyenv/versions/3.9.7/lib/python3.9/site-packages/Crypto/PublicKey/__init__.py", line 21, in <module>
    from Crypto.Util.asn1 import (DerSequence, DerInteger, DerBitString,
  File "/opt/pyenv/versions/3.9.7/lib/python3.9/site-packages/Crypto/Util/asn1.py", line 27, in <module>
    from Crypto.Util.number import long_to_bytes, bytes_to_long
  File "/opt/pyenv/versions/3.9.7/lib/python3.9/site-packages/Crypto/Util/number.py", line 399
    s = pack('>I', n & 0xffffffffL) + s
                                 ^
SyntaxError: invalid syntax

(What else is required for a diagnosis?)

It appears that your version of eventlet depends transitively on a lib that claims to be python3 compatible but is actually not. Can you do pip freeze | grep eventlet and tell me what version of eventlet you're running? I've got 0.30.2. You can do pip install eventlet==0.30.2 to install that version. Then try sematic again. Let me know how it goes!

I should mention that unless eventlet has updated their allowed dependencies, it could be that pip just happened to randomly resolve to that lib, and you'll have to pip install a pinned version of another dependency. The full chain appears to be sematic => eventlet => dns => Crypto, with the true violation lying in Crypto. FWIW, my env doesn't have the Crypto lib at all.  I have dnspython==1.16.0, so if pinning eventlet doesn't work for you, you can try pinning dnspython.


dialog button should be on left hand side

Description
Just a very quick design change as discussed with @brody

Submitter checklist

[ ] Link to JIRA ticket in description, if appropriate.
[ ] Change is code complete and matches issue description
[ ] Appropriate unit or acceptance tests or explanation to why this change has no tests

Reviewer checklist

[ ] Run the changes and verified the change matches the issue description
[ ] Reviewed the code
[ ] Verified that the appropriate tests have been written or valid explanation given

@reviewbybees

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

Looks fine 🐝

Thanks @sophistifunk


Unable to register cuBLAS

2023-03-24 06:04:52.513140: E tensorflow/stream_executor/cuda/cuda_blas.cc:2981] Unable to register cuBLAS factory: Attempting to register factory for plugin cuBLAS when one has already been registered 2023-03-24 06:04:53.296714: W tensorflow/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libnvinfer.so.7'; dlerror: libnvinfer.so.7: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: /usr/lib64-nvidia 2023-03-24 06:04:53.296832: W tensorflow/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libnvinfer_plugin.so.7'; dlerror: libnvinfer_plugin.so.7: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: /usr/lib64-nvidia 2023-03-24 06:04:53.296853: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Cannot dlopen some TensorRT libraries. If you would like to use Nvidia GPU with TensorRT, please make sure the missing libraries mentioned above are installed properly. 2023-03-24 06:04:56.150136: E tensorflow/stream_executor/cuda/cuda_blas.cc:2981] Unable to register cuBLAS factory: Attempting to register factory for plugin cuBLAS when one has already been registered 2023-03-24 06:04:56.895312: W tensorflow/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libnvinfer.so.7'; dlerror: libnvinfer.so.7: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: /usr/lib64-nvidia 2023-03-24 06:04:56.895424: W tensorflow/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libnvinfer_plugin.so.7'; dlerror: libnvinfer_plugin.so.7: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: /usr/lib64-nvidia 2023-03-24 06:04:56.895442: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Cannot dlopen some TensorRT libraries. If you would like to use Nvidia GPU with TensorRT, please make sure the missing libraries mentioned above are installed properly. A matching Triton is not available, some optimizations will not be enabled. Error caught was: No module named 'triton'
I'm getting above errors in 5.3 when starts training
xfomers in 1.2 look like this:
 if install_xformers:
        !pip -q install -U xformers

Did u using older commit? I suggest to use newest update.


listbox rtl problem

hi
preview this problem

Hi @hakanensari,
Could you please help me to know:

Foundation version
Device
By the way, that pop-up menu (select element) is natively positioned by the browser, therefore Foundation doesn't affect that positioning anyway.


feat: isolation policy/isolation profiles

Hi @mitchos,
At the beginning let me thank you for your work done on this SDK.
We started using Isolation profiles/policies in prod on Zscaler tenant. That configuration is currently not available via this SDK. We want to push everything via YAML and APIs, but this was missing - that was our motivation to create this PR.
Added support for ZPA Isolation configuration via API (profiles and policies). Tests for created functions were also added. Docstring were updated in other methods to show, that they support new policy_type - isolation (reorder,update,delete). All added methods were tested directly with Zscaler API endpoints.

Hi @mitchos - I see that you are already working on 1.7.0 dev branch according to latest notifications. Can you let me know if this PR is going to be part of it?

Hi @martinkiska I do apologise, I completely missed this PR. I will review it now and merge it in ASAP.

Thank you again for this high-quality contribution @martinkiska.

You are welcome @mitchos. I am glad that this project is moving forward! :) It would be nice to have more contributors in general or direct support from the vendor.


[21w39a] Suggestion: Can ores drop items instead of blocks?

Hi,
I've been playing with your mod in 21w39a, so far so good.
Since 1.17, vanilla switched metal ores to dropping raw instead of blocks, leaving blocks for silk touch only.  Most mods have switched over to dropping raw metal or gems from the ores.
Just a thought.
Regards.

Additional thought, instead of using the hammer on smelted ingots, might make more sense to use hammer on raw drops to get powder.
I assume you already know the hammer only gets one use.

I did some work on  the mod and sharing my version:
https://github.com/kwpugh/YMetalLib-fabric-1.18.x-ex
List of  changes:

restructured into packages instead of one, big main class
fixed ore gen in overworld, nether, and end (using mixins into vanilla methods)
added tag support for my Resourceful Tools, which  takes damage and stays in crafting grid

I'm just playing with this locally, I have no intent to publish.  If you wish to use this version as a base, feel, otherwise,  disregard.
Cheers

Adjusted hammer and wrench to stay in grid, their recipes now produce 1 instead of 64 since they don't disappear

Are you Korean?

I am already developing 1.3.5-ex, which adds Tungsten, so sadly I cannot merge...

I'll close this out since it is in your court now.   Would you prefer that I take my copy down at this point?

Where's the source? (1.3.5-ex cancelled because 1.18 officially released)

I  took my version down, its your mod.

https://github.com/kwpugh/YMetalLib-fabric not exists

yeah, that is what I said, I deleted it from my GitHub, I was done with it.


Added Vocabulary to  the legaldb website to align with design system

Fixes

Partially fixes #195 by @netacci

Description

This PR adds vocabulary to the legaldb web project as a partial fix for adrressing the inconsistencies in the header design by aligning it with the latest Vocabulary design system.

I copied the src/ folder from the Vocabulary repository, renamed it to vocabulary, and added it to the static folder in the LegalDB project.

Vocabulary Version:

Using Vocabulary commit hash: e817e89362346401b92830a9cbf38323d7789684

Technical details

creativecommons/vocabulary: A cohesive system of design for Creative Commons

Screenshots

Problem [No design system header]

Resolved [Design system header added]

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main or master).
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

HI @Dev-JoyA . I think the menu in header has to align with the vocabulary design menu. here's a screenshot of what I'm trying to say.

what do you think ? @TimidRobot and @Dev-JoyA

@Queen-codes that is for another issue , issue #197
This particular issue is to add the header to the web page , The explore cc, donate etc and making sure its works by using the vocabulary.js script

@TimidRobot

It says here that all current vocabulary is unversioned

hi @Dev-JoyA . I think the commit hash he's asking to be included is this in the image below;

It's kind of circled in a light black circle. e817e89. That hash commit is the latest commit that was merged into Vocabulary indicating the lastest version of vocabulary. I think that makes sense? Let's wait for @TimidRobot to confirm.

@TimidRobot I have edited my Pr description to  include the commit Hash
@Queen-codes Thanks , I found it

Currently, vocabulary classes are not available in the compiled css. Not sure if this is on purpose or if this is a bug. The import on top of vocabulary.scss seems not to be included in the compiled file.


[feature request] Add a helper function to check if an address is a null address

reference implementation according to chatgpt:
`
const { utils } = require('ethers');
function isNullAddress(address) {
try {
// Normalize the input address
const normalizedAddress = utils.getAddress(address);
// Check if the normalized address is equal to the null address (all zeros)
return normalizedAddress === '0x0000000000000000000000000000000000000000';
} catch (error) {
// If the getAddress function throws an error, the input is not a valid address
return false;
}
}
const testAddress = '0x0000000000000000000000000000000000000000';
console.log(isNullAddress(testAddress)); // Output: true
`

bultin now
https://github.com/sentioxyz/sentio-sdk/pull/483/files#diff-d8c16c02a67e533b29afa2271006b041708b07a1fb3e1d4b3d4aeb9f59781733R245
just import from "@sentio/sdk/eth"


Move definitions of annotated unions?

Can we move:
MOUSE_PLATFORMS = Annotated[Union[tuple(MousePlatform.__subclasses__())], Field(discriminator="device_type")] STIMULUS_DEVICES = Annotated[Union[Monitor, Olfactometer, RewardDelivery, Speaker], Field(discriminator="device_type")] RIG_DAQ_DEVICES = Annotated[     Union[HarpDevice, NeuropixelsBasestation, OpenEphysAcquisitionBoard, DAQDevice], Field(discriminator="device_type") ] LIGHT_SOURCES = Annotated[Union[Laser, LightEmittingDiode, Lamp], Field(discriminator="device_type")]
from devices.py to rig.py?
I think it is much more understandable when this is the same file as the schema itself.
@jtyoung84 is this okay?

I think that should be okay. My biggest concern in re-arranging a few of the classes was to avoid potential circular dependencies, but if those are only expected to be imported in rig.py, then it shouldn't be a problem.

I'll take a look a be sure before doing anything. Thanks!

the LIGHT_SOURCES is the only one used in both rig.py and instrument.py, and we don't want to import across the two. I would either move LIGHT_SOURCES to both of those or leave it here.
The others are unique to rig

the LIGHT_SOURCES is the only one used in both rig.py and instrument.py, and we don't want to import across the two. I would either move LIGHT_SOURCES to both of those or leave it here. The others are unique to rig

We'll probably want to leave it where it is for now. If it's moved to two different places, it will require maintaining the list in two different places, which can get confusing.


this.letteravatar.clear() is not a function in ng2letteravatar.js

Ng2LetterAvatar.prototype.ngOnDestroy = function () {
if (this.letteravatar) {
this.letteravatar.clear();
}
};

Same issue here, @uttesh do you mind having a look into it?
Tested with<EMAIL_ADDRESS>

@gastonelhordoy  sorry for the late reply, will update the component this weekend.

Sure thing, thank you for sharing your work @uttesh !

Hi sir,
This plugin works fine with angular 4. However, I still got the error message this.letteravatar.clear is not a function. Can you help us to check it please?
Thanks for your time and help
@uttesh

@pgupta-infoobjects @gastonelhordoy @infinitysky  added the fix.

@pgupta-infoobjects @gastonelhordoy @infinitysky
This component is moved to ngu-utility module https://github.com/uttesh/ngu-utility and all issues are addressed.


⚠ Spryr has degraded performance

In ee41cd1, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 5374 ms

Resolved: Spryr performance has improved in 6ed11c7 after 8 minutes.


make flutter_cashfree_pg_sdk depends on js ^0.6.3

Hi,
make flutter_cashfree_pg_sdk depends on js ^0.7.1

Are you facing any issue?

Can you try overriding the version at your end ?


Bug: Terminal.plist not being backed up

I think this was working as of #63, so something must have broken during refactoring. It's possible that this problem only exists in my dev branch and not on master.

Yep, this is broken on master too. It's due to the refactoring of these two methods:
get_configs_path_mapping()
get_plist_mapping()


Durable Pub/Sub message

I hope any unreceived pub/sub message is persistent for a certain period. For example, 1 day or even a week. Google Pub/Sub

Skygear Server Date/Version: 1.4.0
Application Platform: All

Expected Results
Unreceived pub/sub message is persistent and can be received after reconnection.
Actual Results
Unreceived pub/sub message is discard.

I guess this is big enough for its own feature issue.
It could also either a new feature for pub sub, or make it another layer on top (say we call it “stream” like the redis data type)

is this issue still open? The documentation for message (https://docs.skygear.io/guides/chat/basics/js/#messages) provides Delivering, Delivered and Read as status. Does this imply that the issue is already solved?

is this issue still open? The documentation for message (https://docs.skygear.io/guides/chat/basics/js/#messages) provides Delivering, Delivered and Read as status. Does this imply that the issue is already solved?

This issue is still open, the delivery status of message is built on top of Pubsub with CloudDB, so it doesn't imply pubsub is durable.


instruction not working on windows 11

DAP server listening at: <IP_ADDRESS>:65179
Build Error: go build -o d:\Documentos\PROGRAMACIÓN\GOLANG\codigo\sample-app__debug_bin.exe -gcflags all=-N -l .
go: no such tool "compile"
go: no such tool "compile"
go: no such tool "compile"
go: no such tool "compile"
go: no such tool "compile"
go: no such tool "compile"
go: no such tool "compile"
go: no such tool "compile" (exit status 2)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fb83b6cd-3526-b914-affa-73d510391b3a
Version Independent ID: fb83b6cd-3526-b914-affa-73d510391b3a
Content: Configure Visual Studio Code for Go development
Content Source: articles/go/configure-visual-studio-code.md
Service: azure
GitHub Login: @Duffney
Microsoft Alias: jduffney

Hey @malet-pr,
I appreciate you submitting this issue, I'm looking into it and will try to repo the error you mentioned.
Thank you,

I walked through the tutorial, but wasn't able to reproduce the error. Looking at the error message I'm fairly certain its due to not having all the Go Tools installed. Going through the steps listed under the fifth heading should get them all installed for you. Would you mind give that a try and let me know if it resolves the error?
Thank you,

#please-close


Add Load Fast Fortran to the library panel

Library -> Famix -> Load additional modules -> Load Fast Fortran

PR is waiting for approval https://github.com/moosetechnology/Moose/pull/2503

merged


Try fix windows test

I saw where the problem is. Can we wait to merge this a bit? I'm fixing it.

https://github.com/arturbosch/detekt/pull/2497 should fix this problem. The problem was not in the test, it was in the production code. I think.


Managed BulkDependentResource fails with reconcilePrecondition

Bug Report
On Operator SDK 4.2.0 (commit: 061db9c):
I want to implement a Resource
public class SomeResourceDependentResource extends CRUDKubernetesDependentResource<X, Y>
    implements BulkDependentResource<X, Y>
{
... desiredResources(...)
... getSecondaryResources(...)
}

And use it as a Managed Resource with a reconcilePrecondition
@ControllerConfiguration(
    dependents = {
        @Dependent(
            name = "SomeResource",
            type = SomeResourceDependentResource.class
            reconcilePrecondition = SomePrecondition.class
            ),
    })

As soon as the reconcilePrecondition is configured, the SomeResourceDependentResource fails, since it is not handled as a BulkDependentResource but as a normal DependentReousource. So the getSecondaryResource() is called, instead the getSecondaryResources(), which leads to errors.
What did you expect to see?
Being able to use reconcilePrecondition with BulkDependentResource.

Thanks @grawinkel for reporting this, will take a look.

On Operator SDK 4.2.0 (commit: https://github.com/java-operator-sdk/java-operator-sdk/commit/061db9cc2241eb1079924a77a528ce8cd9473f37):

I can't see how this is related tbh.

The problem is with condition API, at some point we added there the resource created by the dependent resource, that is clearly not fitting in this case.
https://github.com/java-operator-sdk/java-operator-sdk/blob/d83b9f817fe79c81b4601c41401058b57492b41e/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/workflow/Condition.java#L20-L20
So we probably need to pass here the dependent resource not the resource. So then the user will can decide, which method to call. Will create a issue for that to discuss.
For now it can be handled in the PR, so the resource in the condition will be a Map of resources:
public class SamplePrecondition
    implements Condition<Map<String, ConfigMap>, BulkDependentTestCustomResource> {

  public static final String SKIP_RESOURCE_DATA = "skipThis";

  @Override
  public boolean isMet(BulkDependentTestCustomResource primary, Map<String, ConfigMap> secondary,
      Context<BulkDependentTestCustomResource> context) {
    return !SKIP_RESOURCE_DATA.equals(primary.getSpec().getAdditionalData());
  }
}

https://github.com/java-operator-sdk/java-operator-sdk/issues/1689


can we add the Affinity proper to migration target ?

Is your feature request related to a problem? Please describe:
type VirtualMachineInstanceMigrationSpec struct {
// The name of the VMI to perform the migration on. VMI must exist in the migration objects namespace
VMIName string json:"vmiName,omitempty" valid:"required"
}
I saw the migration define just only one VMI name, can we add the Affinity proper to migration target ?

@usrbinkat :
I have a idea, and i want to define resource pool concept for k8s worker nodes based on the k8s Affinity concept, maybe the k8s worker nodes can be split to multiply group based on the different area, then we can migrate the vm from one resource pool to another resource pool with the Affinity migration parameter, can you agree ?

@usrbinkat : I have a idea, and i want to define resource pool concept for k8s worker nodes based on the k8s Affinity concept, maybe the k8s worker nodes can be split to multiply group based on the different area, then we can migrate the vm from one resource pool to another resource pool with the Affinity migration parameter but not just migrate to other's nodes for now, can you agree ?

I think it's a good idea, and I'm thinking about it.


Display values for each data point

Hi, awesome library, it helped me a lot. I was wondering if there is a way to show the value for each point?
Thank you!

It would be possible to draw something with the value in it using the marker callback. Register a callback using setMarkerCallback. You will have to manually draw the value on the Canvas that the callback passes you.
If you instead want to show the value when the user touches the heatmap you can register an OnMapClickListener to be notified when the user touches the heatmap and the closest datapoint to where they touched. Then show the value in any kind of popup or toast.

Hi! I have a set of points and each of them has different values so I did the second option and it works fine. But, when I tried to do the first option with the setMarkerCallback all the points have the same value (which is the value of the last point it sees), instead of showing all the different values for each point.
map.setMarkerCallback(new HeatMapMarkerCallback() {
@Override
public void drawMarker(Canvas canvas, float v, float v1) {
Paint paint = new Paint();
paint.setColor(Color.RED);
paint.setStyle(Paint.Style.FILL);
paint.setTextSize(20);
canvas.drawCircle(v,v1,5,paint);
canvas.drawText(String.valueOf((int)point1.value), v, v1, paint);
}
});
}
To explain a little more I have 9 points with values (0 1 2 3 4 5 6 7 8) and instead of showing this, it shows all the points with the value "8"
If maybe you know what I'm doing wrong it will be appreciated, I'm pretty new in programming in general and I've learn everything on my own. If not, thank you so much! because the pop-up message with the value helps me anyways for what I'm trying to do.

It looks like you're always drawing whatever value is stored in point1.value. I've updated the library to v1.2.0 which now passes you the DataPoint to the drawMarker method. You should then be able to get the value to display from that. I also updated the platform and dependency versions, hopefully that won't cause you issues.
It also looks like you're using the same color for a background circle and the text. This may not be causing you issues yet as a radius of 5px is a really small circle. You should create two separate paints, one for the background and one for the text, and only create them once.
An update to your sample using the updated version:
final Paint backPaint = new Paint();
backPaint.setColor(Color.RED);
backPaint.setStyle(Paint.Style.FILL);

final Paint textPaint = new Paint();
textPaint.setColor(Color.BLACK);
textPaint.setTextSize(20);
textPaint.setStyle(Paint.Style.FILL);

map.setMarkerCallback(new HeatMapMarkerCallback() {
    @Override
    public void drawMarker(Canvas canvas, float x, float y, HeatMap.DataPoint point) {
        canvas.drawCircle(x, y, 5, backPaint);
        canvas.drawText(String.valueOf((int)point.value), x, y, textPaint);
    }
});

Thank you! it works perfectly. I later realize that I was putting the HeatMapMarkerCallback on a for loop which always chooses the last value entered on the loop and that's why it was showing the same value for all the points.


Popup URL Links not formatting correctly

I'm having a problem getting links I have configured on my map to show properly when used in the template. Everything else works great.  I tried several and no luck. See image below.

Here is a link to the map I am using for popups, maybe it has something to do with the way I configured them?:
http://arcg.is/1PhUvW9

I cannot view how you set up the pop ups, would you be able to share the pop up info?

Thanks for looking at this. I'm using the custom attribute display:

I was able to reproduce, it looks like a bug.  The work around for now is just use the field in the pop up, and not define it as a link.

OK thanks. bummer. Would have been perfect with the links.

It still can work for you, use this format for your pop up
For {distribution.BOUNDARY.COMDIST_LOOKUP.URL1}
will produce this in the popup

OK. Will give that a shot. Thanks.

Reopening as it is a bug, will close once resolved


Scheduler and Performance Report Fixes

Fixes a bug where processes could be run more than once in a tick.
Fixes a bug in the performance module that miscalculated the number of ticks recorded.
resolves #277

This Pull Request has been merged by GitConsensus.
Vote Totals

Yes
No
Abstain
Voters

3
0
0
3

Vote Breakdown

User
Yes
No
Abstain

tedivm
✔

dragoonreas
✔

PostCrafter
✔

Vote Results

Criteria
Result

Has Quorum
True

Has Votes
True


Application crash after opening

Application crash after opening.
It doesn't crash if it's not connected to internet.
Expected behaviour
to not crash and work

Version 1.5.5

Check now, no need to update. (you might need to change default provider, i remove anime-pahe as it was not working)


Rename *.txt to *.overpassql

*.overpassql is now the recommended file extension for Overpass QL: OSM Wiki: Overpass QL § File extension
(Disclaimer: I added that section after some discussion.)
I propose to rename all Overpass QL files in this repo to *.overpassql for consistency.
Context: GitHub's syntax highlighting engine requires that 200 repositories use the same file extension before they consider supporting that syntax and file extension: https://github.com/github/linguist/issues/5890

@tabacha Would you accept a pull request?

We are thinking of brining this projekt to an end, so I do not think that someone would get benifit of this. But if there is a pull request, we will merge it.

@tabacha Thanks for the reply. I created a PR: https://github.com/ADFC-Hamburg/adfc-tempo30/pull/122
I think it's useful to replace the file extension, even for an unmaintained project, as it brings the total number of repositories using this file extension closer to 200 and helps make it more popular.


TypeError when exploring classification DB

Exploring Image Classification DB and trying to filter items by class I get an error:
TypeError

unsupported operand type(s) for -: 'dict' and 'int'

Traceback (most recent call last):
  File "/home/roman/.local/lib/python2.7/site-packages/flask/app.py", line 1475, in full_dispatch_request
    rv = self.dispatch_request()
  File "/home/roman/.local/lib/python2.7/site-packages/flask/app.py", line 1461, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/work/Soft/DIGITS/digits/webapp.py", line 81, in decorated
    return f(*args, **kwargs)
  File "/work/Soft/DIGITS/digits/dataset/images/classification/views.py", line 397, in explore
    max_page = min((total_entries - 1) / size, page + 5)
TypeError: unsupported operand type(s) for -: 'dict' and 'int'

I got the same error.

I meet the same error, could anyone help?

same here

Same here: Digits 6, used from within docker container (nvidia/digits:latest, SHA c2faf5).
Created DB succesfully with Digits; error occurred while filtering by label.

I got the same error.

I have the same problem


Add an AppVeyor CI configuration file for running checks on Windows

This change is

Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


[vite-plugin-sveltekit-compile] Cannot read properties of undefined (reading 'has_server_load')

Describe the bug
Prior to SvelteKit 1.3.1 my code would build fine.  With no other code changes in my project, after updating to SvelteKit 1.3.1 (and subsequently 1.3.2), my project will no longer build and the error doesn't point to anything in my code to resolve.
The app runs fine in development mode (npm run dev).
[vite-plugin-sveltekit-compile] Cannot read properties of undefined (reading 'has_server_load')
error during build:
TypeError: Cannot read properties of undefined (reading 'has_server_load')
    at file:///***/node_modules/@sveltejs/kit/src/core/sync/write_client_manifest.js:67:43

More of the error log in the Logs section of this report. The reason I kept this part here is because if I click the write_client_manifest.js file I see this code:
let leaf_has_server_load = false;
if (route.leaf) {
	if (metadata) {
		const i = /** @type {number} */ (indices.get(route.leaf));
		leaf_has_server_load = metadata[i].has_server_load;
	} else if (route.leaf.server) {
		leaf_has_server_load = true;
	}
}

leaf_has_server_load = metadata[i].has_server_load; is where the error is triggered from. If I change it to leaf_has_server_load = metadata[i]?.has_server_load; then my code will build.
But I'm worried this might cause issues somehow in my app that I'm unaware of.
In case it is related to the tsconfig changes in the latest updates, here's my tsconfig:
{
	"extends": "./.svelte-kit/tsconfig.json",
	"compilerOptions": {
		"allowJs": true,
		"checkJs": true,
		"esModuleInterop": true,
		"forceConsistentCasingInFileNames": true,
		"resolveJsonModule": true,
		"skipLibCheck": true,
		"sourceMap": true,
		"strict": false
	},
}

Reproduction
Not sure how to reproduce this as the error isn't clear on what the issue is in my code.
Logs
[vite-plugin-sveltekit-compile] Cannot read properties of undefined (reading 'has_server_load')
error during build:
TypeError: Cannot read properties of undefined (reading 'has_server_load')
    at file:///***/node_modules/@sveltejs/kit/src/core/sync/write_client_manifest.js:67:43
    at Array.map (<anonymous>)
    at write_client_manifest (file:///***/node_modules/@sveltejs/kit/src/core/sync/write_client_manifest.js:55:5)
    at Object.handler (file:///***/node_modules/@sveltejs/kit/src/exports/vite/index.js:607:5)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async PluginDriver.hookParallel (file:///***/node_modules/rollup/dist/es/shared/rollup.js:23688:17)
    at async file:///***/node_modules/rollup/dist/es/shared/rollup.js:25032:13
    at async catchUnfinishedHookActions (file:///***/node_modules/rollup/dist/es/shared/rollup.js:24128:20)
    at async doBuild (file:///***/node_modules/vite/dist/node/chunks/dep-5e7f419b.js:44518:22)
    at async build (file:///***/node_modules/vite/dist/node/chunks/dep-5e7f419b.js:44347:16)

### System Info

```Shell
System:
    OS: macOS 13.0
    CPU: (10) arm64 Apple M1 Max
    Memory: 15.15 GB / 64.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 19.2.0 - /opt/homebrew/bin/node
    npm: 8.19.3 - /opt/homebrew/bin/npm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 109.0.5414.119
    Safari: 16.1
  npmPackages:
    @sveltejs/adapter-auto: next => 1.0.0-next.91
    @sveltejs/adapter-static: ^1.0.5 => 1.0.5
    @sveltejs/kit: ^1.3.2 => 1.3.2
    svelte: ^3.55.1 => 3.55.1
    vite: ^4.0.4 => 4.0.4

Severity
blocking an upgrade
Additional Information
I searched for this error prior to reporting it. Some had said to check all imports. I did this in case I had missed something. But all my imports are fine.

Also, to add -- I use adapter static and have no load functions (my app uses Firebase), configured like so:
kit: {
	adapter: adapter({
		pages: 'build',
		assets: 'build',
		fallback: 'app.html',
		precompress: true
	})
}

Not sure how to reproduce this as the error isn't clear on what the issue is in my code

In this situation, use the divide and conquer strategy - progressively delete chunks of code and remove dependencies until the only thing that remains is the source of the bug. You'll often get a good idea of what's causing the bug as a result of this process.
Unfortunately there's not much we can do to investigate without a repro

Running into similar issue

Appears to happen when building and there's a folder with only a+layout.svelte file and no +page.svelte or inner routes.
src
|_routes
|example
|+layout.svelte
and running npm run build


Placeholder: Create necessary services (TBD after lecture this week)

As a ...
I need ...
So that ...
Assumptions:

...

Acceptance Criteria:
Given ...
When ...
Then ...

Backlog grooming notes:
Team is uncertain what this entails, but knows it's necessary

Updated this story to reflect what needs to happen. I will go ahead and take this so then we can take the different CRUD functions and get those going


Add clusterctl settings and update release docs

This change adds a clusterctl-settings.json fail to make configuring developer environments easier, see this doc for more info. It also adds a little more info the RELEASE.md file about updating the version sensitive developer files before tagging.

/lgtm
/approve

thanks Alex!


Buffer pooling in alert templates

Hi,
I added benchmarks for alert node and found a quick performance boost,
After memory profiling, I found that we are allocating new buffer for the templates of id,message and details, so I wrapped this in a buffer pool, and got a performance improvement:
benchmark                            old ns/op       new ns/op       delta
Benchmark_T10_P500_AlertTask-4       210263431       159024737       -24.37%
Benchmark_T10_P50000_AlertTask-4<PHONE_NUMBER>1<PHONE_NUMBER>5     -16.72%
Benchmark_T1000_P500_AlertTask-4<PHONE_NUMBER>9<PHONE_NUMBER>0     -4.64%

benchmark                            old allocs     new allocs     delta
Benchmark_T10_P500_AlertTask-4       490648         467352         -4.75%
Benchmark_T10_P50000_AlertTask-4     50044467       47560324       -4.96%
Benchmark_T1000_P500_AlertTask-4     48492207       46626729       -3.85%

benchmark                            old bytes      new bytes      delta
Benchmark_T10_P500_AlertTask-4       36155296       33162568       -8.28%
Benchmark_T10_P50000_AlertTask-4<PHONE_NUMBER><PHONE_NUMBER>     -9.20%
Benchmark_T1000_P500_AlertTask-4<PHONE_NUMBER><PHONE_NUMBER>     -3.92%

Compared to master

by the way, I think we can improve further if we will move from text/json to https://github.com/pquerna/ffjson

@yosiat Thanks this looks great.

by the way, I think we can improve further if we will move from text/json to https://github.com/pquerna/ffjson

I think we will hold off on this one for now since the number of triggered alerts should be orders of magnitude less than the number of points processed. Adding the extra dependency seems over kill at this point.

@nathanielc I do agree, but when I profiled the benchmarks I found out that text/json is called a lot, when I don't trigger the alert (I am not calling post(), log(), or something)
It might be in the id/message/details rendering, I will check that out.


Main playlists and other functions are broken after Update

It looks like that in new v1.2.1 Update, functions are not working anymore
No Multiple Qualities.
fragmentMP4() not working.
Playlist of any quality includes few segments only.
Cache control not working.
HLStime not working.

#EXTM3U
#EXT-X-VERSION:3
#EXT-X-TARGETDURATION:6
#EXT-X-MEDIA-SEQUENCE:22
#EXTINF:1.209622,
db_480p22.ts
#EXTINF:0.959356,
db_480p23.ts
#EXTINF:2.168978,
db_480p24.ts
#EXTINF:5.505867,
db_480p25.ts
#EXTINF:2.586089,
db_480p26.ts

Code:

$video->HLS()  ->setFormat($format) ->fragmentedMP4() ->addRepresentations([$r_360p, $r_480p]) ->setHlsTime(10)  ->setHlsAllowCache(false) ->save(BASEPATH.'output/db.m3u8');

I have just tested the code you have ran and it worked totally fine.
$ffmpeg = Streaming\FFMpeg::create();

$video = $ffmpeg->open("/var/www/video/test.mp4");

$format = new Streaming\Format\X264();
$format->on('progress', function ($video, $format, $percentage){
    echo sprintf("\rTranscoding...(%s%%) [%s%s]", $percentage, str_repeat('#', $percentage), str_repeat('-', (100 - $percentage)));
});

$r_360p  = (new Representation)->setKiloBitrate(276)->setResize(640, 250);
$r_480p  = (new Representation)->setKiloBitrate(750)->setResize(854, 480);

$video->hls()
    ->setFormat($format)
    ->fragmentedMP4()
    ->addRepresentations([$r_360p, $r_480p])
    ->setHlsTime(10)
    ->setHlsAllowCache(false)
    ->save('/var/www/stream/test.m3u8');

Content of the test_480p.m3u8 file:
#EXTM3U
#EXT-X-VERSION:7
#EXT-X-ALLOW-CACHE:NO
#EXT-X-TARGETDURATION:11
#EXT-X-MEDIA-SEQUENCE:0
#EXT-X-MAP:URI="test_init.mp4"
#EXTINF:11.200000,
test_480p_0000.m4s
#EXTINF:9.600000,
test_480p_0001.m4s
#EXTINF:9.600000,
test_480p_0002.m4s
#EXTINF:9.600000,
test_480p_0003.m4s
#EXTINF:11.200000,
test_480p_0004.m4s
#EXTINF:8.833333,
test_480p_0005.m4s
#EXT-X-ENDLIST

Please make sure that you are looking for the right file in the right folder and also provide more details about the error you get.
As of version v1.2, some function names, and class names have been changed. Please take a look at the documentation to find out more about these changes.
If you want to use the previous version of this package, you can easily change the package dependency version to previous one in your composer.json.
{
    "..."
    "require": {
        "..."
        "aminyazdanpanah/php-ffmpeg-video-streaming": "^1.1",
        "..."
    },
    "..."
}

After changing, you should update the composer
composer update


Need str joins to cover list numbers from Fn::If

Issue #, if available:
Description of changes:

Update joins for printing Path to include converting ints to strs.  Helps cover cases where there could be a Fn::If with numbers for the path.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Abbreviation of Lambda to lmbd is because lambda is a keyword in Python.
I think this could cause some problems down the chain.  I'm sure we could shoe horn it in but I think we would have a lot of spots to change to make it work. Since this code is in a lot of spots the other thing could be a helper that does this work for us so we aren't repeating it all over the place.
Or something we just append to all messages.

Duh. Now I remember the lambda discussion from way back. I'm a bad dev.
On the rest -- Fair enough, but I had to ask.


CD build runs through all tests twice

Currently the travis build will run through all tests twice, this is because the install stage (install.sh) runs
mvn -q install -B -V
which will install code and run all tests and then the verify stage (verify.sh) runs:
mvn -q verify -P test -B
which will run the tests again. The verify step should be removed from the build.

merged into develop


Open Suggestions for "@" Symbol within the Text

When typing within the text, the "@" symbol doesn't trigger any mention suggestions. Normally it's working fine
Additional Information:
"react": "16.13.1"
"react-native": "~0.63.4",
"react-native-controlled-mentions": "^3.0.0-alpha.4",
https://github.com/dabakovich/react-native-controlled-mentions/assets/35214422/591a6dc8-1acb-43d1-85d9-32de939d9c71

@dabakovich Any idea about this

@shiyansiva I am also looking for the similar case. Please share.


Add an upper index on user email

I want to merge this change because of adding an upper index on user email.
In the test database, I have more than 100000 users.
Explain before index (94ms with sequence scan): https://explain.dalibo.com/plan/eed9c34b6b90ae28
Explain after index (0.57ms with index and heap scan): https://explain.dalibo.com/plan/1hde7fd013c16686

Impact

[x] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations

Docs

[ ] Link to documentation:

Pull Request Checklist

[ ] Privileged queries and mutations are either absent or guarded by proper permission checks
[x] Database queries are optimized and the number of queries is constant
[x] Database migrations are either absent or optimized for zero downtime
[ ] The changes are covered by test cases
[ ] All new fields/inputs/mutations have proper labels added (ADDED_IN_X, PREVIEW_FEATURE, etc.)
[ ] All migrations have proper dependencies
[x] All indexes are added concurrently in migrations
[x] All RunSql and RunPython migrations have revert option defined

Partially fix for: https://github.com/saleor/saleor/issues/14913


Clean up the deletion of fluent-bit and loki PriorityClasses as part of the Seed logging deletion

How to categorize this PR?

/kind cleanup
What this PR does / why we need it:
The fluent-bit and loki PriorityClasses have been dropped with the changes around https://github.com/gardener/gardener/pull/7577. Hence, the on Seed logging stack deletion DeleteSeedLoggingStack func does no longer need to delete these PriorityClasses.
Which issue(s) this PR fixes:
Part of https://github.com/gardener/gardener/issues/5634
Special notes for your reviewer:
N/A
Release note:

NONE

/approve

@ialidzhikov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name	Commit	Details	Required	Rerun command
pull-gardener-e2e-kind-ha-single-zone	18e70c7 link	unknown	/test pull-gardener-e2e-kind-ha-single-zone
Full PR test history. Your PR dashboard. Command help for this repository. Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Is another occurrence of #7530
/test pull-gardener-e2e-kind-ha-single-zone


Update scalameta to 4.4.33

Updates org.scalameta:scalameta from 4.4.31 to 4.4.33.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalameta" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Codecov Report

Merging #77 (9cb5ce4) into main (60417a9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #77   +/-   ##
=======================================
  Coverage   76.39%   76.39%
=======================================
  Files          17       17
  Lines         572      572
  Branches       20       20
=======================================
  Hits          437      437
  Misses        135      135

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60417a9...9cb5ce4. Read the comment docs.


is there some solutions for a text colse to right icon in toolbar

i want show a text close to right icon in toolbar,is there exist solution for this?any advice will be appreciated

I had almost same problem. So I worked on react-native-material-ui that was forked from this library. In that library you can use Toolbar component like this:
<Toolbar
   leftElement="arrow-back"
   centerElement="Title"
   rightElement={<Text>You can put here whatever you want</Text>}
/>

Of course, you can pass whatever you want to leftElement, centerElement and rightElement

@xotahal  thank you


Dockge is restarting in loop

⚠ Please verify that this bug has NOT been reported before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

Description
Hi
I'm trying to run Dockge and got this error in the logs :
the container is restarting in a loop.
I've found this other issue which was not answered du to an invalid format :  cannot run #499 : https://github.com/louislam/dockge/issues/499
👟 Reproduction steps
i did nothing special :

took the compose.yaml from https://dockge.kuma.pet/
followed the steps indicated and didn't change any folder

👀 Expected behavior
container running fine.
😓 Actual Behavior
container reboots in a loop
Dockge Version
1.4.2
💻 Operating System and Arch
Debian 5.10.197-1
🌐 Browser
firefox latest
🐋 Docker Version
20.10.6
🟩 NodeJS Version
No response
📝 Relevant log output
node[8]: ../src/node_platform.cc:68:std::unique_ptr<long unsigned int> node::WorkerThreadsTaskRunner::DelayedTaskScheduler::Start(): Assertion `(0) == (uv_thread_create(t.get(), start_thread, this))' failed.
 1: 0xb83f50 node::Abort() [node]
 2: 0xb83fce  [node]
 3: 0xbf14ee  [node]
 4: 0xbf15d1 node::NodePlatform::NodePlatform(int, v8::TracingController*, v8::PageAllocator*) [node]
 5: 0xb41ed3 node::InitializeOncePerProcess(std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&, node::ProcessFlags::Flags) [node]
 6: 0xb4256b node::Start(int, char**) [node]
 7: 0x7f331bc271ca  [/lib/x86_64-linux-gnu/libc.so.6]
 8: 0x7f331bc27285 __libc_start_main [/lib/x86_64-linux-gnu/libc.so.6]
 9: 0xac1fee _start [node]
bash: line 1:     8 Aborted                 (core dumped) node ./extra/clean-tsx-tmp.js

❌ Debian/Raspbian Buster or lower is not supported


Adding the design document for feature registry abstraction layer

This document talks about our plan to abstract the interface for Feature Registry and have concrete implementations for different backends (like Purview and SQL).  This will minimize the risk of breaking existing features or introducing bugs.

Thanks. But let's put this under a folder called docs/design_docs

Addressed, thanks


Footer layout isn't aligned with content layout

As noticed on GovWifi, the flexbox auto layout used in the footer means that the columns do not lock into the grid.
Example from GovWifi

With equal content, the content is not distributed evenly, the first column takes up more space. Adding content to the second or third column will take away space from the first, which is why the GovWifi example looks almost right, but it's coincidental.
Recreated in the Prototype Kit

Is there anything we can add to the flexbox properties to ensure min or max width of content?

I've had a look into this, I think the way flexbox works means that even though the proportions are correct in certain scenarios the footer will not align with the main grid system.
I have proposed a fix to improve the specific issues raised by Dave here for three columns: https://github.com/alphagov/govuk-frontend/pull/1542
I believe to fix this we need to improve how the footer works:
https://github.com/alphagov/govuk-frontend/tree/spike-only-default-two-thirds-footer-for-two-sections
This will require a small but breaking change, so will put this against the 4.0.0 milestone

We may want to look at #1284 at the same time as this.

As discussed in v4 prioritisation, we think this work is important but it's quite broad at the moment. We should probably do a timeboxed investigation into this issue and this related one to explore a few different layout systems for the footer and see how they perform.


Editing outside of the node appears to reshuffle all nodes and break the layout

While waiting on the execution to finish, I start editing some node. Clicking outside of the node appears to collapse all nodes and order them in a single line. Video demonstrates the problem.
Kazam_screencast_00039.webm
There are two problems here

[ ] GUI should not reshuffle nodes like that (restarting the projects brings the original layout)
[x] there are some underlying crashes on the engine side

Steps to reproduce:

select the node
enter a space
click outside of the node
all nodes are reshuffled

Reproduced; As currently numeric input accepts anything, we parse space and put it as "Block" node without lines, and probably then our "AST repairing system" inserts the parenthesis.
I think we should be careful in what is accepted in numeric input - the AST block should not be.
In this issue, undo is also broken sometimes.

This should also be handled differently in Ast.syncToCode--it could reject attempts to sync a non-block into a block, because that isn't safe in general.

We need to know what is the expected behavior here before a proper estimation can be done. Should the node be deleted, or should such edit be rejected?


it doesn't work

hi
just like the title said, it doesn't work for me.
I read manual installation that I only need to put scrollanim.css and .js in my project and then include them
but it doesn't work on any html tag that I put data-kui-anim : 'fadeIn' on it.
I also put and included every js and css in build folder and made the exact same structure like in example/index.html
still not working
do I need to do something more to get it work?

`eh never mind
so I need to the js at the very bottom of my template page


UE Setdress extract

[PYPE-621] created by admin

sorted in https://github.com/pypeclub/pype/pull/695


Slowness and failures in Azure CLI 2.0

Hello Team ,
It is seen that azure cli implemented in Python is very slow and has lot fixes to be done on stability & speed.
The failure to take up API's is high.
For example. ability to only run one command at time which is a policy of microsoft azure but the cli itself takes a long time.
Please implement the same in Go/Nodejs/JS Framework since the code looks too heavy to run and with the high latency.
Request you to optimize the code for easier use especially in bash.
Thank you.
Regards ,
Libin

We tried patching in the Windows servers. It ended failing multiple times. Eventually, we have manally do it. Kindly have a look at it.

Hello @R-LIBIN :   Thanks for reaching out to us , but at this time it does not look like you are referring to a document but to a specific scenario . If that's the case we request you to please post your question on Microsoft Q&A and other forums , we have our engineers and others who are monitoring them and will be happy to help .
If you have a document which you are following and if you think it needs  an update , please let us know about that here .


Rust crashes trying to format some macros

This macro from gfx:
gfx_pipeline!(pipe {
    vbuf: gfx::VertexBuffer<Vertex> = (),
    out: gfx::RenderTarget<ColorFormat> = "Target0",
});

causes rustfmt to crash with the following error:
~/src/game $ cargo fmt -v
[Bin] "/home/cjhowe/src/game/src/main.rs"
rustfmt /home/cjhowe/src/game/src/main.rs
thread '<main>' panicked at 'assertion failed: !fields.is_empty() || base.is_some()', /home/cjhowe/.cargo/registry/src/github.com-88ac128001ac3a9a/rustfmt-0.4.0/src/expr.rs:1393
third party subcommand `cargo-fmt` exited unsuccessfully

To learn more, run the command again with --verbose.

I can fix it simply by skipping formatting on that item. I still don't think rustfmt should crash if it can't format the inside of a macro, though.

Hmm, this is no longer crashing but it is generating incorrect output:
gfx_pipeline!(pipe {});

I guess what is happening is that we are parsing the macro argument as a struct and trying to format it. I've no idea why we would do that? I'd think we should leave the argument unformatted.
cc @marcusklaas  do you know what is happening here?

I have some clue as to what's happening here. Our macro routine tries to parse the inner tokens as an expression. It finds something that looks like a struct expression, but actually isn't. Instead of failing, the parser just returns something weird, it looks like...
Note sure where the fault lies here, or how we could best fix it.

x!({ a- }); sends rustfmt into an infinite loop :-1:

Also should be fixed once syntex is updated.


Implementation of Loading Indicator for Phone Number Verification Page Transition

Describe the bug
Currently, there is a lack of a loading indicator when users enter their phone number for verification on the Multivendor Food Delivery site. This absence of visual feedback may lead to uncertainty about the status of the verification process, causing a potential user experience issue.
To Reproduce
Steps to reproduce the behavior:

Visit the Multivendor Food Delivery site.
Navigate to the phone number verification page.
Enter a phone number for verification.
Observe the absence of a loading indicator during the transition to the next page.

Expected behavior
A loading indicator should be implemented to provide users with visual feedback during the transition to the next page after entering their phone number for verification. This will help users understand that the system is processing their input.
Screenshots
https://github.com/ninjas-code-official/food-delivery-multivendor/assets/152266796/c12d484e-b0f3-4035-8c8d-a466e6da99a2
Desktop:

Browser: chrome

I would like to pick this up. Can you please assign me this issue?

I would like to pick this up. Can you please assign me this issue?

Sure.

Hey @Inshirah23 I have fixed this issue by PR #321

Hey @Inshirah23 I have fixed this issue by PR #321

Thanks, our team will review it and let you know.