setInterval should also handled as global variable.

Bug Report

TSLint version: 5.17.0
TypeScript version: 2.8.4 and also tested with 3.2.4
Running TSLint via: VSCode

TypeScript code being linted
setInterval(() => {
  console.log('LOL');
}, 1000);

with tslint.json configuration:
{
  "rules": {
    "no-restricted-globals": true
  }
}

Actual behavior
The linter is still satisfied with setInterval.
Expected behavior
I expected that setInterval is marked as error. Because it's also a global variable (method).
All global - not own - variables should be restricted. setInterval should be called by window.setInterval. Only the global scope itself should be available. e.g. window.
Should be an error:
setInterval(() => {
  console.log('LOL');
}, 1000);

Should be (is already) ok:
window.setInterval(() => {
  console.log('LOL');
}, 1000);

Same with setTimeout. And all other properties of window.
In my case, when I hover with the mouse over setInterval (see reference), it shows it comes from NodeJS.Timer. But anyway, it's a global var.

According to the documentation, this is by design: "This rule takes a list of strings, where each string is a global to be restricted. event, name and length are restricted by default."

Yup, you can add timing globals such as setInterval and setTimeout to the rule's list of flagged names:
{
  "rules": {
    "no-restricted-globals": [
      true,
      "event",
      "length",
      "name",
      "setInterval",
      "setTimeout"
    ]
  }
}

Ok, thanks guys. My intention was to suggest this for the defaults. But maybe this rule has only non-blocking values as defaults, right? If this rule also blocks setInterval and setTimeout it will annoy some users, or not? I think: Why not? Because this rule is enabled for exactly this behaviour. Avoid using of pre-defined global variables (incl. methods). This is why I marked it as "bug". Because not expected this. But anyway, just a suggestion. :)


Make setup of details row routes optional

WHY
BEFORE - What was wrong? What was happening before this PR?
This was reported in https://github.com/Laravel-Backpack/community-forum/discussions/774 and @karandatwani92 brought this to my attention in https://github.com/Laravel-Backpack/CRUD/issues/5395
TLDR: If you use ListOperation in your CrudController, the details row routes are always setup, even if you don't enableDetailsRow(). So technically you can access admin/monster/1/details even when details row is not enabled.
AFTER - What is happening after this PR?
This PR adds a way for developers to disable the details row setup if they don't plan to use it in their List Operation.
HOW
How did you achieve that, in technical terms?
The correct way to go about this would be to separate the details row into a new operation, that you can add when you need. That way routes would only be setup when you add the operation to the controller.
That would be a BC at the moment. So I thought about the other ways we could go about this.
a) We could create a new ListOperation without the details row. Like SimpleList or something similar.

I don't think this is a good solution, because traits cannot be extended so we would have a lot of duplicated code.

b) We could create a php attribute #[WithoutDetailsInList] or something similar for example an interface to implement in the controller implements WithoutDetailsRow

I don't dislike neither ways to be used as a configuration mechanism, but to make this non-breaking we would be using them on the "negative". I wouldn't have nothing against if we were talking about WithDetailsRow, but it being negative makes it a not so good option.

c) use a property as config so that developer can prevent the route setup.

Indeed, this looks the easiest and cleanest way out. Setting protect $setupDetailsRowRoutes = false in your controller would work similar as if you didn't include that operation in that controller.

Is it a breaking change?
No I don't think so.
How can we test the before & after?
You can go to any controller where you don't have the enableDetailsRow(), and access entity/{id}/details.
docs: https://github.com/Laravel-Backpack/docs/pull/528

I completely agree with the reasoning, excellent job there Pedro! Loved reading it too, reads really really nicely.

Maybe there's another option?
(D) Seeing your conditional made me think... that the details row functionality is only useful if properly set up. How do you set it up? According to the docs:

Enable the functionality: CRUD::enableDetailsRow()
Overwrite the showDetailsRow($id) method; Alternative: overwrite views/backpack/crud/details_row.blade.php which is called by the default showDetailsRow($id) functionality;

I hate that we wrote that "alternative". Because that's a bad way to do that, it would apply to ALL details rows, for all entities. If we hadn't suggested that, we could have just changed the signature of showDetailsRow() and make it return false by default. But we can't do that, because of the above and because... it would be a breaking change.

So no, there's no D.


Inconsistent weight decay logics in multiple optimizers

Issue
The default behaviors of many optimizers are not optimal/consistent for optimization. The desired implementation proposed below will help convergence.
Gradient Clipping
In Tensorflow/Pytorch, weight decay is usually applied before gradient clipping. Not clipping weight decay would lead to much larger update caused by wd regularization compared to the derivative of the loss. For the following optimizers, the weight decay term is applied after gradient clipping, which should be corrected:

[ ] SGD
[ ] Signum
[ ] LBSGD
[ ] DCASGD
[ ] NAG
[ ] SGLD
[ ] Adam
[ ] AdaDelta
[ ] AdaGrad

Weight Decay Not Used to Update Optimizer State
The following optimizers apply wd on weight directly, and the state is not updated. This can make the training slow if a small learning rate is applied, while divergence if a large learning rate is used.

[ ] AdaDelta
[ ] AdaGrad

Other Optimizers
FTRL is a proximal optimizer which doesn't use weight decay for gradient clipping nor updating state, which is fine.
The following optimizers apply wd before clipping gradient, which is also fine:

[ ] RMSProp
[ ] Adamax
[ ] Nadam
[ ] FTML

Could you clarify which ones multiply wd with lr and which ones don't?

Just curious, is clip_gradient used anywhere?

@sxjscience supposedly it's used in all optimizers
AdaDelta doesn't multiply wd and lr.

Unless explicitly specified, for most of the optimizers as implemented in packages such as TF and torch, wd is merged into the gradient before the gradient clipping. When the proximal operator is used, the wd term is not merged.

@szhengac thanks for your inputs.
My concern is that if we change the wd behavior now, the change is incompatible with previous versions of MXNet and users have to change their code for new hyperparameters. I don't think this is provides a good user experience.
@szha @piiswrong @szhengac What about specifically documenting the update rules for the existing optimizers like https://mxnet.incubator.apache.org/versions/master/api/python/optimization/optimization.html#mxnet.optimizer.SGD ? For new optimizers, during code review committers should check if the implementation is similar to pytorch/tf ones?

Looks good. We can write math formulas instead.

Thank Haibin for raising such issues.
Besides, weight decay should only apply to weights (not bias). [1][2] Thus, users usually do
trainer = gluon.Trainer(net.collect_params(), 'sgd', {'learning_rate': learning_rate, 'wd': weight_decay})

by assuming that weight decay only applies to weights. However, our current implementation applies weight decay to all model parameters including bias.
Reference:
[1] LeCun, Y., Bengio, Y., & Hinton, G. (2015). Deep learning. nature, 521(7553), 436.
[2] Franklin, J. (2005). The elements of statistical learning: data mining, inference and prediction. The Mathematical Intelligencer, 27(2), 83-85.

Also there is this paper that discusses how weight_decay must be applied independently from optimizer: https://arxiv.org/abs/1711.05101
This was recently implemented in TF: https://github.com/tensorflow/tensorflow/pull/17438

Solved in #16167. So close it.


cmd/go: go mod tidy, vendor hide module load errors

The module loader leaves some problems for the standard loader to find, like not being able to resolve imports. But 'go mod tidy' and 'go mod vendor' do not run the standard loader, so those problems go undiagnosed. Maybe we should look for them explicitly.
For example make a file x.go that says import "nonexist". go mod tidy succeeds quietly.

https://github.com/golang/go/issues/27868 is possibly a duplicate of this issue; I'm not positive.

We have run into this issue where using go mod tidy on a machine that doesn't have bzr, but that has bzr dependencies, will just not mention that it didn't work correctly.
We caught it because our CI system is now running go mod tidy and it has bzr installed.

@bcmills this issue is tagged with NeedsInvestigation, are there any outstanding questions that need answers before solving this one?
As context I think this is a quite important issue to solve before go1.13 as it adds a lot of confusion for users.
I've seen several cases the thing that happens when bzr isn't installed (as described above by Paul and Jonathan), as well as when indirect dependencies have dependencies that gets removed/broken.

Hi @leitzler or @jsternberg, I think launchpad.net/gocheck and labix.org/v2/mgo might be examples, but do have a simple set of "from scratch" steps that are an example this with bzr where go mod tidy does not complain?  Could be helpful to make sure the ultimate fix here covers that case as well.

Sure! So far I have three different cases that I think is directly caused by this issue.

A Bazaar dependency when the bazaar client bzr isn't installed.

$ docker run -it --rm golang sh
# go version
go version go1.12.4 linux/amd64
# cd $(mktemp -d)
# rm $(which bzr)
# go mod init x
go: creating new go.mod: module x
# cat > main.go
package x

import _ "launchpad.net/gocheck"
# go mod tidy
# cat go.mod
module x

go 1.12
# go build
main.go:3:8: unknown import path "launchpad.net/gocheck": bzr branch --use-existing-dir https://launchpad.net/~niemeyer/gocheck/trunk . in /go/pkg/mod/cache/vcs/f46ce2ae80d31f9b0a29099baa203e3b6d269dace4e5357a2cf74bd109e13339: exec: "bzr": executable file not found in $PATH

An direct (or indirect) import can't be found:

$ cd $(mktemp -d) && go mod init x
go: creating new go.mod: module x
$ cat > main.go
package x

import _ "github.com/modsdemo/brokenimport"
$ go mod tidy
go: finding github.com/modsdemo/brokenimport latest
$ cat go.mod
module x

go 1.12

require github.com/modsdemo/brokenimport v0.0.0-20190506193535-03bc7b9ad6c8
$ go build
/home/leitzler/go/pkg/mod/github.com/modsdemo/brokenimport@v0.0.0-20190506193535-03bc7b9ad6c8/brokenimport.go:3:8: unknown import path "github.com/modsdemo/havebeenrenamed": cannot find module providing package github.com/modsdemo/havebeenrenamed

Using invalid GOPROXY setting

$ go mod init x
go: creating new go.mod: module x
$ cat > main.go
package x

import _ "github.com/modsdemo/notags"
$ GOPROXY=proxy.golang.org go mod tidy           # Missing https://, gives no error msg
$ cat go.mod
module x

go 1.12
$ GOPROXY=proxy.golang.org go build              # Missing https://
main.go:3:8: unknown import path "github.com/modsdemo/notags": cannot find module providing package github.com/modsdemo/notags
$ go mod tidy                                    # Works as expected
go: finding github.com/modsdemo/notags latest
$ go build                                       # Works as expected
$

@leitzler That's great! Thank you for taking the time to do that.

@leitzler

are there any outstanding questions that need answers before solving this one?

We need to figure out which paths are missing the needed error checks, and how to add them without breaking things like go list -e.

FWIW I just ran across what I think was this issue when using go mod vendor and it took me ages to work out what the problem was. There was an "ambiguous import" issue in one module; running go mod vendor appeared to succeed but actually didn't vendor the modules that there was a problem with, so we just saw an error about a missing module when CI ran.

The fix for this turned out to be super simple, given the nice import-stack reporting that @jayconrod added earlier in the 1.13 cycle. I'm hoping we can get this into the next 1.13 build.


Remove deprecated polyfills

Fixes https://github.com/CesiumGS/cesium/issues/10590
Removes the polyfills deprecated in https://github.com/CesiumGS/cesium/pull/10579 which have been replaced by native methods.

Thanks for the pull request @ggetz!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.


Add scrolling to map config modal for viewing multiMember list

Overview
The list of multi-member districts was not appearing in the Map configuration modal when the screen height was too short. This PR adds a minimum height to the multiMemberContainer to ensure that it always displays regardless of screen size and adds scrolling to the modal body while leaving the title and save/cancel buttons in place.
Checklist

[x] Description of PR is in an appropriate section of CHANGELOG.md and grouped with similar changes, if possible

Demo

Screenshot taken from a 1280x680 window zoomed to 100% in Chrome.
Notes
The added modalBodyContainer was given a max height of 100vh-16rem; this amount was determined via experimentation to be what looked best in conjunction with the modal styling when both a normal size and when too short.
Testing Instructions

Run ./scripts/server and navigate to one of your map project pages.
Open the Map Configuration modal and shrink the screen to be shorter than the modal's height. It should resize to fit the new height and a scroll bar should appear that allows you to see the modal's body.
Select "Use Multi-member Districts". The list should appear without changing the dimensions of the modal.
Verify the scrolling works as expected.

Closes #1089

@ktohalloran as part of this, we should also remove the scroll from the multi-member section itself.
Sorry for not making it clear in the original issue, but in general a scrolling element inside another scrolling element is something to try to avoid.

@maurizi thanks for taking a look at this--I thought the two scrollbars looked funky so I should have inferred that the one inside needed to go away. Thanks for clarifying--I've made that change so it should be ready for re-review.


How to install

I have no experience with Nix, how do I "use the nix flake"?
It looks like this tool is exactly what I am looking for...

I believe installing via regular nix would be nix profile install github:keifufu/dimland.
You can get nix for any distro of your choosing, or use nixos :p
https://nixos.org/download/

Thanks!
I simply ran cargo build and copied the binary into my path, that worked just as swiftly :)

Yeah, nix is just another build tool in the end anyway ^^


Automator: update common-files@master in istio/istio@master

Generated by Automator - 2021-05-26T00:33:32+00:00

@istio-testing: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-pilot-k8s-tests_istio

analyze-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-pilot-k8s-tests_istio

analyze-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test analyze-tests_istio

gencheck_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-pilot-k8s-tests_istio

analyze-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test analyze-tests_istio

gencheck_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test gencheck_istio

lint_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-pilot-k8s-tests_istio

analyze-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test analyze-tests_istio

gencheck_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test gencheck_istio

lint_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test lint_istio

integ-helm-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-helm-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-pilot-k8s-tests_istio

analyze-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test analyze-tests_istio

gencheck_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test gencheck_istio

lint_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test lint_istio

integ-helm-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-helm-tests_istio

integ-operator-controller-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-pilot-k8s-tests_istio

analyze-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test analyze-tests_istio

gencheck_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test gencheck_istio

lint_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test lint_istio

integ-helm-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-helm-tests_istio

integ-operator-controller-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-operator-controller-tests_istio

integ-security-multicluster-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-pilot-k8s-tests_istio

analyze-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test analyze-tests_istio

gencheck_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test gencheck_istio

lint_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test lint_istio

integ-helm-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-helm-tests_istio

integ-operator-controller-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-operator-controller-tests_istio

integ-security-multicluster-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-security-multicluster-tests_istio

integ-distroless-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-pilot-k8s-tests_istio

analyze-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test analyze-tests_istio

gencheck_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test gencheck_istio

lint_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test lint_istio

integ-helm-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-helm-tests_istio

integ-operator-controller-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-operator-controller-tests_istio

integ-security-multicluster-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-security-multicluster-tests_istio

integ-distroless-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-pilot-k8s-tests_istio

analyze-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test analyze-tests_istio

gencheck_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test gencheck_istio

lint_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test lint_istio

integ-helm-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-helm-tests_istio

integ-operator-controller-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-operator-controller-tests_istio

integ-security-multicluster-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-security-multicluster-tests_istio

integ-distroless-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-pilot-k8s-tests_istio

analyze-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test analyze-tests_istio

gencheck_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test gencheck_istio

lint_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test lint_istio

integ-helm-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-helm-tests_istio

integ-operator-controller-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-operator-controller-tests_istio

integ-security-multicluster-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-security-multicluster-tests_istio

integ-distroless-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-security-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-pilot-k8s-tests_istio

analyze-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test analyze-tests_istio

gencheck_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test gencheck_istio

lint_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test lint_istio

integ-helm-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-helm-tests_istio

integ-operator-controller-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-operator-controller-tests_istio

integ-security-multicluster-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-security-multicluster-tests_istio

integ-distroless-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-security-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-telemetry-mc-k8s-tests_istio

release-notes_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-pilot-k8s-tests_istio

analyze-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test analyze-tests_istio

gencheck_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test gencheck_istio

lint_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test lint_istio

integ-helm-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-helm-tests_istio

integ-operator-controller-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-operator-controller-tests_istio

integ-security-multicluster-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-security-multicluster-tests_istio

integ-distroless-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-security-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-telemetry-mc-k8s-tests_istio

release-notes_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test release-notes_istio

integ-pilot-multicluster-tests_istio
ede6cb3424374f5ca3b7331673bbff2495b3ac73
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Add influxDb tags

Sometimes influxDb tags can come in handy to split data by region, hostname etc.
I find there is no tagging in current prebid-server-java.
As dropwizard-metrics-influxdb already has tags support, I suggest this simple implementation.

Fixed empty tags exception


TiKV Hiberate Peers metric has negative numbers

Bug Report

What version of TiKV are you using?
5.0.2
What operating system and CPU are you using?
Internal big cluster
Steps to reproduce

Now 5.0.2 enable hiberate-region and  cdc.hibernate-regions-compatible, check grafana-> TiKV-details-> Server -> Hibernate Peers, there's negative numbers for awaken region count, such as -3.0K

The second issue is "show config;" list has not hiberate-region config, but only has tikv. cdc.hibernate-regions-compatible.

What did you expect?

How can I enable or disable hiberate-region since "show config" has not this config.
TiKV Hiberate peers has correct statistical information.

What did happened?

Didn't reproduce on a 1 node cluster (tpcc 5K, 8 hours). Would probably try a larger cluster or try to eyeball what's wrong from the code.


Add Lambda support

:smile:

@wsh submitted a pull request to add this.  Take a look once you get a chance.

I have been using a quick rebase/update I made based on @mattgartman's awesome work,
and it's been working for me locally for a couple weeks, PR open here:
https://github.com/dtan4/terraforming/pull/341

@davidbegin @mattgartman I tried cloning your fork, then I ran "gem install terraforming". I am not seeing "terraforming lambda" as an option when running terraform. Am I missing a step? Thanks for your hard work!

@gaberamosve looking at the PR, the command is lf for lambda function

Keeping this issue loosely alive.  I was able to clone the fork, build the gem, and use terraforming lf.
Would be to get this into latest. :)

@sover02
Out of curiosity, could you send me steps on how you we're able to get it working with @davidbegin fork?
 But this would be super helpful. I appreciate your help in advance.

@sover02 managed to get it working.
Is anyone else experiencing a limitation? Seems that it's not pulling ALL my lambda functions in my region.

Has anyone succeeded with that? Can't even run terraforming lf it says that the command doesn't exist 😞

for me this works https://github.com/cycloidio/terracognita/


Semantic highlight not activating (insiders regression)

Issue Type: Bug
In the latest insiders build semantic highlighting is no longer automatically activating when extension is activated.
Can be reproduced by installing the extension and opening a folder with test.nani file with the following content:
; comment

In the stable VS Code 1.63.2 the highlighting is automatically activated and the comment line becomes colored, while in the latest insider it's not.
Notes:

In insiders build, if an output window with any log category is opened, the highlighting is activated.
When a file with a built-in highlighting is opened (eg, settings JSON), the semantic highlighting provided by the extension is activated.
Adding "editor.semanticHighlighting.enabled": true to either extension's configurationDefaults or to the settings doesn't help, hence it's probably not related with #118639
Nothing noteworthy is detected in the logs or the developer console.


Reference to old script still on current live CD

In https://github.com/chimera-linux/chimera-install-scripts/commit/a8ecaa8630e2592ea58822b725270431142ead85 there was a change made that replaced message that referred to "chimera-live-chroot" with "chimera-chroot".
I recently used chimera-linux-aarch64-LIVE-20230915-base.iso for an install and the the chimera-bootstrap script in it still says:

"You can use chimera-live-chroot to get a shell in the system ..."

This caused a bit a confusion for me when I was installing the system.
Why is the /usr/bin/chimera-bootstrap script in above ISO still referring to the outdated script chimera-live-chroot ?

Should be fixed with https://github.com/chimera-linux/cports/commit/e5145773a418fad18ed7ab84106ebdcee916e3cc once fresh ISOs are made


Prevent automatic sync with Mongo upon startup

This is a really great tool, and it potentially has a tremendous future. I am having a problem though, and I am not sure what is going on. Whenever I startup the doc manager, it starts mass inserting data into neo4j automatically. I have run a series of insert commands in mongo in the past, but nothing is currently getting inserted into mongo. I even deleted everything from mongo, and it still inserts all of this data into neo4j upon startup. Is it intended that the doc manager should auto sync the neo4j database with the existing mongo database (even if there is nothing in the mongo database)? If so, can this functionality be disabled? It is really annoying and I will not be able to use this tool unless there is some way to turn off this feature, or if I can delete insertion history from the mongo database. Thanks for your help!

Could you try deleting the oplog.timestamp file that is created when running neo4j-doc-manager and starting the doc manager again? The timestamp in that file acts as a starting point for syncing data from mongo to neo4j, so all updates since that timestamp will be streamed, even if deleted later.
There is a bit more info on how this works here


cwms/data/ratings/{rating-id} returns "Not Implemented" in most browsers

In the swagger page https://cwms-data.usace.army.mil/cwms-data, I can get a return for TraverseRES_Dam.Stage;Stor.Standard.Production for MVP office, and I can get data for the generated link (https://cwms-data.usace.army.mil/cwms-data/ratings/TraverseRES_Dam.Stage%3BStor.Standard.Production?office=MVP) in the Opera browser.
In Chrome, Firefox, and Edge browsers I'm getting a "Not Implemented" for https://cwms-data.usace.army.mil/cwms-data/ratings/TraverseRES_Dam.Stage%3BStor.Standard.Production?office=MVP

That's odd. From the swagger page? It just worked for me in Firefox.
Was an "incident identifier" provided?
If you can recreate the error please provide the full error response.

The issue is that just hitting the link in a browser doesn't send the needed accept header and we haven't defaulted the types or done the alias thing.
https://github.com/USACE/cwms-data-api/issues/485

Doing the request from the swagger page adds the extra header and then it works.   Not sure why Opera would be different.

If you can recreate the error please provide the full error response.
Seems like you guys have a bead on it but for posterity:
{"message":"Not Implemented","incidentIdentifier":"-730284949424987388","details":{}}

@msweier In your browser (Firefox,Chrome, IE etc) can you "Try it out" in the swagger-ui interface and build up your query and then "Execute" ?
Until we get something like that #485 issue implemented the request needs an extra header.  The swagger-ui sees that the header is needed and adds it by default.
I've highlighted the extra header in this screenshot

Sorry I wasn't clear. Yes the swagger page works in all browsers. So can the header be attached or embedded in the link somehow?

From an html link?  No.
Requests made from Java or Javascript or Python or the command-line can easily add the header.

At the moment I don't think there are any code changes needed.  Communicating that header "application/json;version=2"  seems to be a stumbling block.  The tasks from #485 may improve things.  Should we add an html page that explains what is going on and how users can make V2 requests from Java, Javascript, Python, curl, wget etc?

Mike - how do we resolve this issue - is there something CDA needs to do?   More documentation?  Different error messages if application/json provided but application/json;version=2 is needed?  Or do we implement #485 and count on that to resolve this?

#485 and the associated work seems like the best way to me. Probably wouldn't be too difficult to just make a minor edge case for just these, but would be better to just really do the "here's the default" work.


Could not resolve conversation on old PR

I tried to resolve this comment via the extension: https://github.com/xtermjs/xterm.js/pull/3212#discussion_r555103406, the reaction icon also wasn't showing:

ext: v2021.7.30987
Version: 1.59.0-insider (user setup)
Commit: e8a59bc6f920e731b47f0bc72263e82aba8b796e
Date: 2021-07-22T05:14:01.507Z
Electron: 13.1.7
Chrome: 91.0.4472.124
Node.js: 14.16.0
V8: 9.1.269.36-electron.0
OS: Windows_NT x64 10.0.19042

Reaction not showing is https://github.com/microsoft/vscode/issues/128770.

I think we need https://github.com/microsoft/vscode/issues/130107 in order to solve this without a hack.

I experienced it now... is there anything new?
Can you merge the last commits?


Speed up deployments even more

https://nathanpeck.com/speeding-up-amazon-ecs-container-deployments/

No longer being used - on Hetzner for the time being


Acceptinvite

I think I used auto indent and that's probably why the entire document is highlighted in Collection.
I added POST("/{id}/reject",.. since it was missing and modified the existing POST("/{id}/accept",
and POST("/{id}/invite". Also made the helper function  private void handleInvitation near the end of the document.
I added a mail template for accepting invites.
For getting it to work I needed to keep track of who invited who, therefor I added a relation "inviter" which points from the person who invited to the person who got invited. I keep track of which collection the user got invited to by adding a property to the relation with the collection id.
Potential bugs:
I noticed that you can invite people who are already in the collection and they would then receive an invite to a collection they are member of.
I also noticed that stats won't return how many members there are in a collection if there are no entries in that collection. This is probably not a major problem since it makes no sense to have empty collections with lots of members but it is a bit weird behaviour.

Codecov Report

Merging #71 into master will increase coverage by 18.32%.

@@              Coverage Diff              @@
##             master      #71       +/-   ##
=============================================
+ Coverage     16.97%   35.29%   +18.32%
- Complexity       43       79       +36
=============================================
  Files            16       16
  Lines          1072     1085       +13
  Branches        107      109        +2
=============================================
+ Hits            182      383      +201
+ Misses          879      653      -226
- Partials         11       49       +38

Impacted Files
Coverage Δ
Complexity Δ

...main/java/se/lth/cs/connect/routes/Collection.java
17.94% <17.94%> (+5.27%)
6 <6> (+2)
:white_check_mark:

...main/java/se/lth/cs/connect/DatabaseException.java
0% <ø> (-62.5%)
0% <ø> (-2%)

.../main/java/se/lth/cs/connect/modules/Database.java
28.2% <ø> (-48.72%)
3% <ø> (ø)

src/main/java/se/lth/cs/connect/Connect.java
61.22% <ø> (+6.12%)
8% <ø> (+1%)
:white_check_mark:

...n/java/se/lth/cs/connect/routes/BackendRouter.java
81.81% <ø> (+9.09%)
8% <ø> (ø)
:x:

src/main/java/se/lth/cs/connect/TrustLevel.java
11.76% <ø> (+11.76%)
3% <ø> (+3%)
:white_check_mark:

src/main/java/se/lth/cs/connect/routes/Entry.java
23.98% <ø> (+19.45%)
6% <ø> (+3%)
:white_check_mark:

...rc/main/java/se/lth/cs/connect/routes/Account.java
47.89% <ø> (+31.57%)
15% <ø> (+10%)
:white_check_mark:

...c/main/java/se/lth/cs/connect/modules/Mailman.java
88.46% <ø> (+34.61%)
4% <ø> (+1%)
:white_check_mark:

.../main/java/se/lth/cs/connect/RequestException.java
100% <ø> (+42.85%)
3% <ø> (+1%)
:white_check_mark:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c7726b...49bd42b. Read the comment docs.

I talked to @smeetz IRL and he found the bug so now the tests on the master branch pass. :)

We now check if the user to be invited isn't already member of the collection before we send the invite.

 When a user you invited to a collection accepts/rejects it, you should get an email

I created new branch and merged this into master. All tests are fine and notifications are at least sent. We will probably have to keep an eye open for any leftover :bug:. In the future, just undo the code formatting, otherwise: :hear_no_evil:  :gun:


[Bug]: Android Foreground Notification does not always dismiss

Component/Nuget
Other
What operating system(s) are effected?

[ ] iOS (13+ supported)
[ ] Mac Catalyst
[X] Android (8+ supported)
[ ] Windows (.NET 7 Target - only Core is currently supported, BLE is coming)

Version(s) of Operation Systems
All
Hosting Model

[ ] MAUI
[ ] Native/Classic Xamarin
[ ] Manual

Steps To Reproduce
Seems to be a race condition with Android.  Queue up many http transfers, sometimes the foreground notification won't disappear
Expected Behavior
Notification disappears after transfers are completed every time
Actual Behavior
It does not do that
Exception or Log output
No response
Code Sample
No response
Code of Conduct

[X] I have supplied a reproducible sample that is NOT FROM THE SHINY SAMPLES!
[X] I am a Sponsor OR I am using the LATEST stable/beta version from nuget (v3.0 stable - ALPHAS are not taking issues - Sponsors can still send v2 issues)
[X] I am Sponsor OR My GitHub account is 30+ days old
[X] I understand that if I am checking these boxes and I am not actually following what they are saying, I will be removed from this repository!

Fixed in 3.1


Add linter for import grouping

How to categorize this PR?

/area dev-productivity
/kind enhancement
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

NONE

/test all

Thanks @acumino, this is awesome!
We have been wanting this for a long time! 😍


Swithing to VERSION_2 for StoreFindToken

There is a new version of StoreFindToken which contains inclusiveness and incarnationId. We already have a patch in progress that introduces this new version but supports it only in read path.
when switching to VERSION_2:

Change StoreFindToken.getBytes() to include incarnationId and inclusiveness flag
Add tests in serDeTest of StoreFindTokenTest to test the incarnationId and inclusiveness flag.

Done in #534


[BUG] Function definitions inside headers are not inline.

Describe the bug
Definitions of member functions inside headers should be marked inline. They're only implicitly inline if they are contained within the class definition body, are templates (not full specializations), or marked constexpr.  Applies to member functions of vertex buffer wrappers, framebuffer wrappers, etc. Haven't looked at all the code, but it's probably consistently missing.
To Reproduce
Steps to reproduce the behavior:

Create 2 .cpp files;
Include any header in both;
Compile and link;
See ODR violation.

Expected behavior
*Happy linker noises*
Desktop (please complete the following information):

Haven't actually tried this on a machine, but it's an ODR-violation even when I just think about it.

Additional context
Clang-tidy is heavily recommended. Catches this immediately.

You are right, this is such an obvious error but I did not spot it. I'm also running clang-tidy checks occasionally but they seem to never have caught these things, maybe the custom command is misfigured?
I will ship a fix ASAP.
P.S, Do you happen to know of any way to enable clang-tidy project-wide on CMake without having it check every target? I previously had it integrated that way but it spent minutes trying to apply FIX-ITs to GLAD, breaking the loader in the process.

maybe the custom command is misfigured?

misc-definitions-in-headers is what you're looking for.

P.S, Do you happen to know of any way to enable clang-tidy project-wide on CMake without having it check every target? I previously had it integrated that way but it spent minutes trying to apply FIX-ITs to GLAD, breaking the loader in the process.

The external libraries should be their own IMPORTED targets and be linked against by the example applications. Do not add their include directories like this. Instead, create an imported target that represents glad:
add_library(glad STATIC IMPORTED)
target_sources(glad PRIVATE ${GLAD_SOURCES})
target_include_directories(glad PUBLIC ${GLAD_INCLUDE_DIR})

And then link:
target_link_libraries(sandbox PRIVATE glad)

Then ask CMake to generate compile_commands.json by passing -DCMAKE_EXPORT_COMPILE_COMMANDS=TRUE when invoking cmake.
This should convince cmake that glad is an external target and will generate correct include/link flags inside compile_commands.json, which will then be picked up by clang-tidy as stuff to ignore.
Also this might not work, since I haven't exactly tried this, and cmake is, well, cmake. Unpredictable with its rules at times.
Also also probably don't blindly run clang-tidy fixes, just ask it to list all warnings instead, and then vet them manually.

I patched the clang tidy scripts manually to make them work and got rid of all ODR violations, I am in the process of ironing out some more warnings that turned up when the checks started working and I will shortly be pushing a fix.
Thank you for the insight on CMake, I'll try and clean the build system up next.

Instead, create an imported target that represents glad:

Or maybe that won't work because you can't build IMPORTED targets and you'll have to do a switcheroo with an extra target:
add_library(glad_impl STATIC)
target_sources(glad_impl PRIVATE ${GLAD_SOURCES})
target_include_directories(glad_impl PUBLIC ${GLAD_INCLUDE_DIR})

add_library(glad::glad IMPORTED INTERFACE)
target_link_libraries(glad::glad INTERFACE glad_impl)

# And then, finally...

target_link_libraries(sandbox PRIVATE glad::glad)

Keep in mind that I wrote like 10 lines of cmake and my head already hurts. So, uh, have fun figuring this out! Still no guarantees that this will work, sorry.

I appreciate the effort man, maybe we should just KISS and keep the custom commands, -header-filter=${STAPLEGL_HEADERS} seems to be working for me.


Typo on line 201.

Changed "droupou" to "dropout"

I don't know why it says I made changes to line 208 (on all of my pull requests to this file).


[PYTHON] Unifies the Callback function

Currently epoch_end_callback and batch_end_callback have two types of interfaces, this make things like logging evaluation metric not compatible. The things presented to the callbacks are also somewhat limited.
I like the way R handles the problem, where an environment variable is passed, which basically is a map containing all the local variables in the scope, this issue is opened to see if anyone likes to move toward this direction, and take stab on proposing specification of function in this issue, and contribute the code

related to #798

And please also expose Accuracy info in epoch_end_callback, so we can save model only when accuracy gains.


The memory leak issue is still present in version 9.3.3

Expected Behavior
I assume that this application should not take up so much memory at startup.
Actual Behavior
At the moment, the application eats up more than 4Gb of RAM when starting

Reproduction Steps
You need just to start your app on mac
Is there an existing issue for this?

[X] I have searched the issue tracker for this problem.

Additional Information

Insomnia Version
9.3.3
What operating system are you using?
macOS
Operating System Version
14.6.1 (23G93)
Installation method
download from insomnia
Last Known Working Insomnia version
2023.2.0

v2023.2.0 is OK. How can i turn off auto update after computer restart?

@CurryYangxx Is there any follow up question you may want to ask to identify the root cause of this issue?

Hi @yaroslavolekh. Could you please provide more detailed information? Do you have a large number of collections? Or does the memory usage increase after a certain operation?
Also If possible, you can enter Insomnia in the search box to filter out related processes in both Memory and CPU tab to help us locate the problem.

Hi @yaroslavolekh, we found a high CPU and memory consumption when using git sync and with a large number of folders. Are you under the same condition when you found this issue?

Similar issue #8020

@CurryYangxx Is there any follow up question you may want to ask to identify the root cause of this issue? I see my local version of Insomnia taking 132MB of memory, so this issue doesn't happen on my computer:

@yaroslavolekh is the memory increase constant, or did you notice it spiking up after doing some specific operations on the application (like loading a document, a collection, etc) ?

It fills up all the memory that is there until it crashes. Maybe the problem is in the 4 projects that I export? The problem still exists. But I can't give you the settings file, since there is no way to export without sensitive information.
But again, the old version I mentioned above works without problems. And my biggest problem now is the auto-update after reboot. I have to delete and reinstall the new version again.
https://monosnap.com/file/AjqlVP9iynBM0w7fAhuI0iQ3YSMKvn

Hi @yaroslavolekh, we found a high CPU and memory consumption when using git sync and with a large number of folders. Are you under the same condition when you found this issue?

Don't now why, but it most hardest navigation to use. It seems to open folder of requests make request to remote server to sublist of it.

@CurryYangxx Is there any follow up question you may want to ask to identify the root cause of this issue? I see my local version of Insomnia taking 132MB of memory, so this issue doesn't happen on my computer:

@yaroslavolekh is the memory increase constant, or did you notice it spiking up after doing some specific operations on the application (like loading a document, a collection, etc) ?

All I do is simply open the application into which I imported the project settings.

Please clarify what information I need to provide to help you resolve this issue.

More than 4GB of occupied memory with 110kb of settings file, that's very nice )

@yaroslavolekh Which page do you land on when you open the app? The dashboard page or the specific file page, such as a request collection or design document?

If you landed on the specific file page, could you try to go back to the dashboard page, close the app, and open it again, to see if the app memory is lower?
Also, you can create a new request collection or API design, and open the app again, also see if the memory will be lower.
If memory is lower in both cases, it will be related to the files you imported. We can analyze what is special about the import file.


[MM-32862] Sanitized app version and id for function name

Summary
AWS only allows letters, number, underscores and hyphens as function names.
Given that the app id and version are used to generate the function name, we need to limit the characters used in them to only the ones stated above. A version is likely contains a dots, hence I think it's fine to sanitized it before generating the function name.
I've also added an IsValid method to AppID and AppVersion to state that. They should get called in the provision process, but the seemed out of scope for this PR.
Ticket Link
https://mattermost.atlassian.net/browse/MM-32862

I am so confused... the names of the functions are something that we create when we create them, so why do we need methods that validate or correct them? We just need to generate valid names when we create...

We create the function names of out of the app's name and it's version. These two input might contain characters that are invalid for a function name. Hence, we need to sanitize. There is no need to validate the function name after we created it. Does that make the change more clear, @levb?

Also, I am still 1/5 that content-addressed names are better than the semantic names anyway. The functions' SHA are unique and that's all that matters.

While I agree that content-addressed names are better, I don't have a good idea what we want to use there. I assume you are talking about the SHA of the function zip file, correct? In that case it's not reproducible, which might cause issues.


RuntimeError('Unrecognized new version of ortools (9.8.3296). Expected < 9.8.0. Please open a feature request on cvxpy to enable support for this version.')

(CVXPY) Jan 15 12:41:11 PM: Encountered unexpected exception importing solver GLOP:
RuntimeError('Unrecognized new version of ortools (9.8.3296). Expected < 9.8.0. Please open a feature request on cvxpy to enable support for this version.')
(CVXPY) Jan 15 12:41:11 PM: Encountered unexpected exception importing solver PDLP:
RuntimeError('Unrecognized new version of ortools (9.8.3296). Expected < 9.8.0. Please open a feature request on cvxpy to enable support for this version.')

blocked on https://github.com/cvxpy/cvxpy/pull/2316#issuecomment-1882792870

I believe this is fixed.


Added function for creating 'dummy' devices.

I wrote a function to create a "dummy" Device to test different algorithms under realistic noisy conditions. It deep copies in "current" (currently available) specs and noise models of existing devices (e.g. '19Q-Acorn', '8Q-Agave') and simply removes their dead qubits and connections. While this might not directly help with preparing for submitting QPU jobs, it might still be useful for testing on the QVM.
Possible usage:
dummy_device = create_dummy_device(device_name='19Q-Acorn')
noisy_qvm = QVMConnection(dummy_device) # QVM with 19Q-Acorn's noise model

This looks helpful.
The semaphore error is a combination of #424 and #370

should be easier now with #731


Research how to handle sign up requests

Basic Information

Anyone can sign up however the super admin has the option to accept or reject the request.
Accepted users should be able to sign in straight away, and rejected or 'waiting for approval' requests cannot.
Research how firebase can handle this.
Design schema with this feature in mind.

Post any relevant links or information here.

https://docs.google.com/document/d/1Kz1bxbh2WgqaLC5yTWS3SWhBTgKChS0fWwG9LlI5gqA/edit?usp=sharing


Ensure no roles that enable to impersonate and manage all service accounts are used at a project level

Possible check to target the following resource

[ ] google_project_iam_binding

closing, tracking in spreadsheet


Update README.md

Added a useful repository.

This pull request is an example to demonstrate how to contribute to this repo.


Adjust License identifier

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

It is dual licensed (https://github.com/pycurl/pycurl/blob/885d08b4d3cbc59547b8b80fbd13ab5fc6f27238/setup.py#L894), so the spdx identifier should be LGPL-2.1-or-later OR curl

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin please rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe/meta.yaml:

PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.


fix wrong location of index.mdx in demo

fixes https://github.com/NK-WebDev/gatsby-theme-teranova/issues/4

Seems like the build does not like to install yarn:
1:02:57 PM: yarn install v1.17.0
1:02:57 PM: error An unexpected error occurred: "/opt/build/repo/package.json: Unexpected token } in JSON at position 104".
1:02:57 PM: info If you think this is a bug, please open a bug report with the information provided in "/opt/build/repo/yarn-error.log".
1:02:57 PM: info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
1:02:57 PM: Error during Yarn install

The build was failing because of a trailing comma in the package.json which I forgot about when updating the License but now it's fixed.


Needs compatible method with new CoordinatorLayout.

Hi,
it should be nice that the new CoordinatorLayout of design-lib gives behavior-relationship to your "fab" instead the FAB of design-lib self. I've tried but it throws exception to cast fab to FAB of design-lib.  With the behavior we can move the "fab" up automatically against Snackbar of design-lib.

Hi XinyueZ,
There is no possibility to perform such cast because this is how Java works
Despite the fact that classes com.software.shell.fab.ActionButton and android.support.design.widget.FloatingActionButton both extends android.view.View class they can't be casted to each other because no one of them is the superclass of the other and vice versa. In this case you'll get java.lang.ClassCastException. Always.
There are no plans to extend the com.software.shell.fab.ActionButton class from android.support.design.widget.FloatingActionButton in order to "make" it work with the new layouts. Furthermore, looking ahead I can say that starting from version 2.0.0 com.software.shell.fab.ActionButton will be extended from android.view.SurfaceView class, which in turn extends the android.view.View class
So for your case you have 2 choices:

Use the com.software.shell.fab.ActionButton AS-IS and fit it to the layout you are using. Use convenient move methods for this
Use the android.support.design.widget.FloatingActionButton from the android design support library

nice to know.


Hand-Write the Intended Generated Code

Summary
In order to get a good idea of the appropriate abstractions for the flexer code generation step, as designed in #940, it is important to hand-write some of the intended code.
Value
We will get a better understanding of what the generated rust code should look like.
Specification

[ ] Design a very small lanugage such as char := "a" | "b"; term := char*;.
[ ] By hand, write out the intended rust code that should be generated by the flexer to lex this language.
[ ] Work out what the appropriate abstractions are for this code and document them.

Acceptance Criteria & Test Cases

We have a good idea of the kind of rust code that the flexer should generate.

Obsolete


add allowCellFocusCondition

Would it be possible to add a "allowCellFocusCondition". This would solve my problem with toggling in and out of edit mode. I would then get row select behavior in non-edit mode and cell select behavior in edit mode. Like so:
allowCellFocus: function ($scope) {
return $scope.col.grid.appScope.view.isEditing;
},

This is probably a little more complex than it sounds, we'd be happy to accept a pull request to add this, but at the moment we're focused on fixing defects to get to a 3.0 release.

This is a useful request, but not really in the current roadmap.  We have far too many good ideas in the repository already, giving the impression that we have a project riven with defects.
Accordingly, I am leaving the enhancement tag on this, but closing it.  If someone would like this functionality, we'd welcome a pull request that adds it.


update to support 5.1

Please update this app, the instructions in the ReadMe.md, and on the website https://bugsnag.com/accounts/larabin/projects/laravel/integrate to support installation on 5.1
For starters, you need to update the BugsnagLaravelServiceProvider.php to publish config files properly in 5.1, and check/merge user settings.
Also, config\app.php needs to read
# Add `BugsnagLaravelServiceProvider` to the `providers` array
'providers' => [
    Bugsnag\BugsnagLaravel\BugsnagLaravelServiceProvider::class,
]

# Add the `BugsnagFacade` to the `aliases` array
'aliases' => [
    'Bugsnag' => Bugsnag\BugsnagLaravel\BugsnagFacade::class,
]

php artisan config:publish bugsnag/bugsnag-laravel isn't proper syntax for 5.1
Technically it would be
php artisan vendor:publish --provider="Bugsnag\BugsnagLaravel\BugsnagLaravelServiceProvider"

but even that wouldn't help until the code is updated.
until then, users need to create a file called bugsnag.php in the config directory with the following contents
<?php

return [
    'api_key' => env('BUGSNAG_API_KEY')
];

and add this to their .env file (for security and git version control purposes)
BUGSNAG_API_KEY=your-api-key

Hope this doesn't come off as rude. You guys provide an awesome service. I would think you would want to be up to date with the development community.

@Kryptonit3 this should now be fixed in 1.6.0 - and it totally didn't come off as rude! Let me know if there are any other things we could do to improve the library. We are always looking for feedback!


Retrieve API_KEY from .env

The issue is that config/config.yaml no longer has a "apiKey" under
"general" but the ZAP script generator is looking for it. This patch has
it pull from the environment instead.

LGTM


add .gitignore for the python content

Need for .gitignore for the Python content. I add also ignored the VS code outputs and MAC .DS_Store folder.
fixes #6

Thanks so much @ndjido for the PR! We definitely need a .gitignore, so I'm making a few small edits to the submitted file & merging - hope you don't mind and thanks again for the work :)


in production menu goes to 404 unless i override MenuResource and put $displayInNavigation = true, , but in local it works without it

Hi! I'm unable to reproduce this. Can you give me more info, such as Nova version, what URL you're being redirected to when clicking on the menu item?

redirect to 404
nova version: 3.27.0

as soon as i move .env file to production it happens, in local its not happening
also, if i overwrite those models its not happening

What URL does the button lead you to?

404 redirect after trying to goto region resource

I think there is something specific to your setup that is causing this issue as there are no other reports regarding this. Nor can I reproduce this issue. If you could set up a project where this issue is reproducible, I would be able to debug it. Thanks!


freezes opening passphrase-protected ssh git repository

VSCode Version: 1.5.1
OS Version: Arch linux 4.7.2-1-ARCH #1 SMP PREEMPT Sat Aug 20 23:02:56 CEST 2016 x86_64 GNU/Linux
Steps to Reproduce:

open a folder containing an SSH git repo with passphrase-protected key
open konsole (a KDE terminal emulator), run /opt/visual-studio-code/code &

Result: Vscode freezes. If I close the window, KDE says: "Application code is not responding" and giving me an option to terminate it.
Note:
If I run /opt/visual-studio-code/code in foreground, vscode does not freeze and I'm prompted for the passphrase:
Enter passphrase for key '/path/to/id_rsa':

I'm using 1.5.3 now and the problem seems to have disappeared. For me this is solved. Thanks.

Thanks!


folder creation duplicated

highlighting the text to the left closes the box. but will create addition folder as show in the video.
https://user-images.githubusercontent.com/75956274/116632298-b452ed00-a90b-11eb-90b1-935edda3b8f7.mp4

@jjkonway, thanks for reporting this bug!
By the way, if you want to quickly record an animated GIF with "bug step by step" you can use an awesome tool like peek.
After you recorded a GIF, you can drag & drop in "text editor" here in github.
Here is an example of animated GIF recorded with above mentioned tool:

for 2.1.4 this issue is not relevant anymore.


Added setuptools structure to enable installation

Added setup.py for setuptools installation support using Pip
Changed pico_generator to include a main() function for script execution when installed
GIF and TSV copied to installation directory
Changed pico_generator to read TSV file from current installation directory
Added section to README for Pip installation

@lurch These changes look sane to me but I am not a Python expert, any comments from you?

Sorry, I hadn't seen this before, oops. The changes to pico_project.py look good (although you'll obviously need to rebase onto the latest changes), but I'm afraid I've never written a setup.py script. Don't most projects that use pip use it to install stuff from PyPI? Is it absolutely necessary to move the repo-files into a subdirectory?

Sorry, I hadn't seen this before, oops. The changes to pico_project.py look good (although you'll obviously need to rebase onto the latest changes), but I'm afraid I've never written a setup.py script. Don't most projects that use pip use it to install stuff from PyPI? Is it absolutely necessary to move the repo-files into a subdirectory?

Have rebased as requested and put pip installation as "optional" and at the foot of the README.


Experiment w/ removal of coalesce on highest qps cases

Describe your changes
Related Issues / Projects
Checklist

[ ] I've manually tested my code

Superceded by #630


Store user logos locally to avoid missing markers in map

At the moment, we have URL links for logos in the user map JSON file.
https://github.com/festim-dev/FESTIM/blob/4cf700be5e1cf86a2cd1a5f2e869203edab64f0a/docs/source/map.json#L13-L16
However, this sometimes doesn't work either because the URL changes or maybe the request isn't authorised.
It produces this:

To fix it, a solution would be to store the logo locally in the docs directory instead of fetching it from the URL.

Is the method of adding the logo locally the same as adding other images?

Is the method of adding the logo locally the same as adding other images?

Adding the logos yes.
Then we require some changes to this script (responsible for generating the map) to make it work with non-URL images
https://github.com/festim-dev/FESTIM/blob/f7915f02c287be4b2f310df3bd3c461bcf02cf2f/docs/source/map.py#L50-L67

Then we require some changes to this script (responsible for generating the map) to make it work with non-URL images

Does it mean replace all the URL with local logo images?

Does it mean replace all the URL with local logo images?

Yes. Using the URL has proven to be too unreliable and local images would work better

Yes. Using the URL has proven to be too unreliable and local images would work better

I see. I'll try to do it.

Then we require some changes to this script (responsible for generating the map) to make it work with non-URL images
https://github.com/festim-dev/FESTIM/blob/f7915f02c287be4b2f310df3bd3c461bcf02cf2f/docs/source/map.py#L50-L67

I think I can help with gathering all the logo images for FESTIM/docs/source/map.json. But I might have no idea of making changes in FESTIM/docs/source/map.py
Lines 50 to 67 in f7915f0.

@XinShen-CHN
I think that you would need to add these lines:
        if "path" in feature["properties"]:
            url = feature["properties"]["path"]
            image_dimensions = Image.open(url).size

after https://github.com/festim-dev/FESTIM/blob/f7915f02c287be4b2f310df3bd3c461bcf02cf2f/docs/source/map.py#L58-L59
This will look for a key "path" in the JSON file with the local path to the image and set the value of url accordingly.
For example:
            "properties": {
                "name": "University of Surrey",
                "path": "images/user_logos/university_surrey.png"
            }

If you do that for all the properties then you can remove all the URL related code in map.py.
Or have another if statement:
        if "url" in feature["properties"]:
            url = feature["properties"]["url"]
            if url == "URL_PLACEHOLDER":
                url = "https://upload.wikimedia.org/wikipedia/commons/9/92/LOGO_CEA_ORIGINAL.svg"
            coordinates = feature["geometry"]["coordinates"]

            # Get the dimensions of the image from URL
            image_dimensions = get_image_dimensions_from_url(url)

        elif "path" in feature["properties"]:
            url = feature["properties"]["path"]
            image_dimensions = Image.open(url).size

@RemDelaporteMathurin Thank you very much! I'll try.


:memo: documentation

fixes #3
can be seen here: https://github.com/alakarteio/k-simple-state/blob/doc/README.md

Coverage remained the same at 98.225% when pulling 0da8218ec065ad81db32a5c8d2349c090671c468 on doc into d10266b3f9c84dd697d77f6e1c34a8d56c14311b on master.

I would like to merge this first version guys :)
@bpetetot @guillaumecrespel


Fix horizontal scrolling on homepage.

Disables horizontal scrolling on mobile.

I'm fairly certain this isn't how we want to fix this. We had a long discussion before about making things zoomable for people who have vision problems.


defaults for flags

it would be helpful to provider either defaults or environment variables for things like the --cloud and perhaps a few other options; cluster perhaps.

yeah a default machine-type would be nice as well


fix for xcode 15 beta 2

fix for xcode 15 beta 2: remove lines that cause: Stored properties cannot be marked unavailable with '@available' #789  -> In Xcode 15 beta 2

Fixed here https://github.com/Yummypets/YPImagePicker/commit/4ad09560321182b73ed415c543a77bc83b80a3f2
A temporary way for use: pod 'YPImagePicker', :git => 'https://github.com/Yummypets/YPImagePicker.git', :commit => '4ad09560321182b73ed415c543a77bc83b80a3f2'


What is the right way to skip none solutions in each generation.

I am using pymoo linking with simulation tools to optimize building forms to find near pareto front solutions accounting for daylighting and energy consumption, and the data exchange is by csv files, the core code run in Rhinoceros. Since the simulation tools are not steady, there will be individual solutions that cannot retrieve one or two objective value ( if I run the simulation again the value may be retrieved). So I mark these objective values to be 'None'.
To handle situations where certain objective values are marked as 'None' due to the nature of my simulation tools, and I want to avoid discarding these solutions entirely, I should implement a mechanism to keep track of these solutions and give them a chance in the subsequent generations.
My code is below, I use Vectorized Matrix Operation for parallelization, and the optimization is step by step, controled by the existence of an external txt file. I also use a callback to store solutions of every generation.
The question is:

I use the code
            if np.any(fitness_values == None):              continue
to skip solutions, is it the right way?
I print the fitness_values retrieved from result.X, to find the objective values are different from the ones recorded by the callback. The values in the callback is right, but the values of each generation retrieved from result.X seems wired (That is why I suspect my code is not a right way out).
The difference is like this:
If I manually set objective of the 5th solution to be None. The objective values of the first four solutions retrieved from the two ways are identical, but the objective value of the 5th solution retrieved from result.X is not None. And from the 5th to the 50th solution, the values retrieved from result.X is wrong.

import os
import time
import csv
import threading
import numpy as np
from pymoo.core.problem import Problem
from pymoo.core.problem import ElementwiseProblem
from pymoo.termination import get_termination
from pymoo.algorithms.moo.nsga2 import NSGA2
from pymoo.operators.crossover.sbx import SBX
from pymoo.operators.mutation.pm import PM
from pymoo.operators.sampling.rnd import FloatRandomSampling
from pymoo.optimize import minimize
import matplotlib.pyplot as plt
from pymoo.core.population import Population
from pymoo.core.evaluator import Evaluator
from pymoo.core.solution import Solution

n_var=5
n_obj=3
n_ieq_constr=0
xl=[8,0,0,0,0.2]
xu=[37,1,1,1,0.95]
pop_size=50
n_gen=60
seed=1
sleep_time=2

running_file_path = "D:/Zhu/Optimize/Hops/running.txt"

def is_running():
    return os.path.exists(running_file_path)

class TestProblem(Problem):
    def __init__(self, **kwargs):
        super().__init__(
                         n_var=n_var,
                         n_obj=n_obj,
                         n_ieq_constr=n_ieq_constr,
                         xl=xl,
                         xu=xu,
                         )

    def _evaluate(self, x, out, *args, **kwargs):
        # Step 1: Send data to Grasshopper
        data=np.array(x)
        file_path = "D:/Zhu/Optimize/Hops/Params.csv"  # Set the file path
        np.savetxt(file_path, data, delimiter=",", fmt="%f")

        # Step 2: Wait for result in Python
        result_file_path = "D:/Zhu/Optimize/Hops/Res.csv"  # Path to the result file
        initial_timestamp = os.path.getmtime(result_file_path)
        while True:
            time.sleep(sleep_time)  # Wait for 1 second
            current_timestamp = os.path.getmtime(result_file_path)
            if current_timestamp != initial_timestamp:
                data = np.genfromtxt(result_file_path, delimiter=',')
                if data.shape==(pop_size,n_obj):
                    break
        # Step 3: Read result files in Python
        data = np.genfromtxt(result_file_path, delimiter=',')
        # Check the running file to decide whether continue
        data[data==999]=None
        out["F"]=data

class MyCallback:

    def __init__(self) -> None:
        super().__init__()
        self.sols = []

    def __call__(self, sols):
        self.sols.extend(sols)
        print()

problem=TestProblem()

algorithm = NSGA2(
    pop_size=pop_size,
    sampling=FloatRandomSampling(),
    crossover=SBX(prob=0.9, eta=15),
    mutation=PM(eta=20),
    eliminate_duplicates=True,
    evaluator=Evaluator(callback=MyCallback())
    )

termination = get_termination("n_gen", n_gen)

if Run:
    open(running_file_path,'w')
    algorithm.setup(problem)
    while is_running():
        algorithm.next()
        if algorithm.termination.has_terminated():
            break
        result=algorithm.result()
        optimal_solutions = result.X
        optimal_objectives = result.F

        for solution, fitness_values in zip(optimal_solutions, optimal_objectives):
            # If the solution has missing objectives marker, skip processing
            print(fitness_values)
            if np.any(fitness_values == None):
                continue

    sols = Population.create(*algorithm.evaluator.callback.sols)

    X_history=np.array(sols[0].X)
    F_history=np.array(sols[0].F)
    for i in range(len(sols)-1):
        X_history=np.append(X_history,sols[i+1].X)
        F_history=np.append(F_history,sols[i+1].F)
    X_history=X_history.tolist()
    F_history=F_history.tolist()

What about simply setting the objective(s) to a very large value, e.g. 1e12 or so?
I am not exactly what you are trying to do in your code, but for the algorithm, it would be also okay to consider a solution simply as infeasible if the evaluation fails (also referred to as death penalty). This might be the cleanest way of implementing this.
If you know before running your third-party code a solution will fail, you can also filter them out beforehand.

The fact is, bacause of the insteability of the simulation software, it is impossible to decide which solution will fail. And the solution of the same variables may be OK if I run it again. So if I set the objectives to a very large value, I wonder the algorithm will not consider the solutions in the following generations, and that will affect the final search space I think. I am not sure my assumption is right or wrong? If the large penalty of these solutions doesn't affect the final searching space, I think it is a cleanest way.

It sounds to me that your problem is not that sometimes you don't have a solution (because the simulation crashes) but more that your evaluation function is non-deterministic. You are right that NSGA-II makes the assumption that you have a deterministic function and will not re-evaluate a solution for this reason.
What about adding retry if it fails and just assuming after n attempts it truly fails?

Hello @miraclema999 , I would suggest you to create surrogate model for the simulation if possible.

What about adding retry if it fails and just assuming after n attempts it truly fails?

Sorry for the late reply. I agree with your suggestion. This way will not affect the number of solutions in each generation.
To be honest, I'm not doing well in scripting, can you tell me how to modify this script, to let it retry the generation? Thank you

@miraclema999 I meant creating surrogate model with the samples from simulation software and replace it, and finally verify the result with simulation software. Here is the explanation of surrogate model on wikipedia.


Add Pattern Relations and Pattern Relation Types

Short Description
Adds PatternRelation and PatternRelationType with a complete CRUD-Interface to implement issue https://github.com/PlanQK/q-tal/issues/11

Codecov Report

Merging #52 into master will decrease coverage by 2.35%.
The diff coverage is 6.06%.

Looks good to me!

OK, I'm merging it then


Docker login doesn't support spaces

Hi,
publish_images command contains:
- run: docker login -u $<< parameters.login_variable >> -p $<< parameters.password_variable >> << parameters.registry >>
But this code doesn't work if login_variable or password_variable contains spaces. As far as I know, there is no repository that allow space in user name but JSON key file of JCR uses full file for password. Therefore I suggest to replace the line above to:
- run: echo $<< parameters.password_variable >> | docker login -u $<< parameters.login_variable >> --password-stdin  << parameters.registry >>
I hope to open a pull request about it soon.
Thanks

closed by #13


fix: fix sequence create table sql

What this PR does:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

ref: #235


Distributed training forthe RCL task

Hello,  I am trying to pretrain todbert on my own dataset, but because of the size of the dataset I need to distribute training to speed up computation. It seems like distributed training is built into the MLM task, but distributing the RCL task throws an error. We have written some to distribute the RCL task but our training results show little-to-no improvement on the RS loss vs the single-GPU case. I am wondering if there is any specific reason you decided not to distribute the RCL task over multiple GPUs or a problem you encountered, or if there is just likely a bug in our code.

Hi,
Can you provide what is the error when you run the RCL training? We did not focus too much on parallel training at that time and used the huggingface implementation for that.

I am not getting an error really, just the RS loss is not decreasing when it gets distributed. On a single GPU it converges fine (for a small amount of data) and for the same amount the distributed training did not converge at all.


Cert-manager version bump & asymmetric routing warning

PR Summary

Rev'd cert-manager to 1.6.0, unless appgw selected for ingress, then it reverted back to  version 1.5.3 here
Updated all validation errors to larger Text
Added invoke to contour install if running with private cluster
Adding Warning about asymetric routing if selecting in-cluster ingress with firewall

PR Checklist

[x] PR has a meaningful title
[x] Summarized changes
[x] This PR is ready to merge and is not Work in Progress
[ ] Link to a filed issue

Can you bump the AKS-C target release version to the latest one?
https://github.com/Azure/Aks-Construction/blob/kh-cert-manager-version/.github/workflows/ghpages.yml#L22


Significant changes on React Router

Proposal Submission
Significant changes on React Router [Languages]
Use keyword research to improve your article's SEO.
Proposed article introduction
When it comes to displaying multiple views without having to reload the browse  React Router plays an important role. In this tutorial, we’ll be looking at major changes in react router v6
Outline
Introduction
New react-router features
Conclusion
For example, if the article is based on machine learning, use the following: [Machine learning] Introduction to Machine Learning.
If the article is based on developing an Android application, use the following: [Android] Developing Apps using Android.
ONLY viable topics to pick from:

API

Artificial Intelligence

Blockchain

Containers

Edge Computing

Languages

Machine Learning

Networking

Node.js

Security

Key takeaways
At the end of this article, users will be able to

know the new features in react-router
Have an understanding of each of them
Write the code syntax for each of these features.

Article quality
The goal of this article is to discuss these features and enable readers to know how to use them. Those promoting good programming practice.
References
Please list links to any published content/research that you intend to use to support/guide this article.
Conclusion
Finally, remove the Pre-Submission advice section and all our blockquote notes as you fill in the form before you submit.
We look forward to reviewing your topic suggestion.

Thank you for your response and we thank you for submitting your topic. After some careful consideration it struck us that this topic may be a bit over saturated throughout other blog sites and official documentation (https://www.google.com/search?q=react+router+v6+significant+changes).
We typically refrain from publishing content that is covered widely on the net or other blogs. As we're more interested in original, practitioner-focused content that takes a deeper dive into programming-centric concepts.
We believe this is the best way for students to build a great portfolio (for potential employers) is by building what does not exist and what can provide the most value.
You are more than welcome to pursue another more in depth topic


do not appear to be receiving water data

After update via hacs, I removed the integration from home assistant, rebooted, and reinstalled integration.
I noticed an additional line in the config…
.com
Username
Password
I changed the .com to .ca in the initial setup assuming that is what was required to use the alternate site.
This change in the initial config did not connect to the .ca site.  I still had to modify the eow.py …It looks like Eyeonwater.com is still the default.
I updated that to .ca, and integration appears to be working with that one change.
so, integration creates the appropriate sensors, appears to connect to the correct site (after I changed how.py), allows me to add to energy dashboard, however, I do NOT appear to be getting any data into the water sensor after over 12 hours.
logs appear to show it is connecting every 5 mins.
2022-11-13 09:11:07.000 DEBUG (MainThread) [custom_components.eyeonwater] Fetching latest data
2022-11-13 09:11:07.001 DEBUG (MainThread) [custom_components.eyeonwater.eow] Requesting meter reading
2022-11-13 09:11:09.701 DEBUG (MainThread) [custom_components.eyeonwater] Finished fetching Eye On Water data in 2.700 seconds (success: True)
...
2022-11-13 09:16:09.002 DEBUG (MainThread) [custom_components.eyeonwater] Fetching latest data
2022-11-13 09:16:09.003 DEBUG (MainThread) [custom_components.eyeonwater.eow] Requesting meter reading
2022-11-13 09:16:11.619 DEBUG (MainThread) [custom_components.eyeonwater] Finished fetching Eye On Water data in 2.617 seconds (success: True)

Hi,
I've fixed one very stupid bug today, hopefully eyeonwater.ca will work now without code modifications.
Regarding the sensor updates - I see similar issue, but in my case the data has not been updated on eyeonwater.com, So I cannot get the actual meter readings.
Could you please verify the data in your eyeonwater.ca account?
Thanks.

Yes, I can confirm this as well.As of nov 12, I have only been seeing one daily entry.Before that, I was getting multiple depending on usage.My logs show eyeonwater communicating every 5 minsIs this related to the updates, or is it an eyeonwater issue?2022-11-14 06:35:09.003 DEBUG (MainThread) [custom_components.eyeonwater] Fetching latest data2022-11-14 06:35:09.003 DEBUG (MainThread) [custom_components.eyeonwater.eow] Requesting meter reading2022-11-14 06:35:19.088 DEBUG (MainThread) [custom_components.eyeonwater] Finished fetching Eye On Water data in 10.086 seconds (success: True)…2022-11-14 06:40:19.002 DEBUG (MainThread) [custom_components.eyeonwater] Fetching latest data2022-11-14 06:40:19.003 DEBUG (MainThread) [custom_components.eyeonwater.eow] Requesting meter reading2022-11-14 06:40:28.776 DEBUG (MainThread) [custom_components.eyeonwater] Finished fetching Eye On Water data in 9.774 seconds (success: True)dOn Nov 14, 2022, at 6:45 AM, Konstantin Deev @.***> wrote:
@bsp9493, I can confirm that may EOW account is getting updates once in 24 hours. Which makes energy dashboard looking very weird.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

Yes, not sure… Looking in the app, it is reporting usage every hour (flow history)But yet is says the read interval is every 15 minsdOn Nov 14, 2022, at 8:06 AM, Konstantin Deev @.***> wrote:
Ok, it might be a throttling on their end. Maybe 5 mins it's too much, so let me make it configurable.
It also might be the EOW changed their policy recently and it's out of our control.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>


Rollback function not rolling back all changes

I played around with your Rollback function and noticed that it not rolls back all changes.

DataTables file is not deleted
Changes in menu.blade.php are not rolled back, even stated by the script in the shells output
Model Schema JSON files is not deleted (Perhaps this should be confugurable, if that will be deleted also?)
DB Migration in not rolled back as well (Perhaps a good idea to add this also in Rollback process, perhaps also configurable?

Perhaps you can review these as ideas?
Regards
kay899

I noticed in the new version only DB migration is rolled back, but no files any more?


Transcluding code blocks and callouts doesn't work

Describe the bug
Embed code block、callout block looks ugly (sorry , poor english).
In Quartz

To Reproduce
Steps to reproduce the behavior:
use embed grammer
Expected behavior
hope display like normal block
Screenshots and Source
Desktop (please complete the following information):

Quartz Version: [e.g. v4.2.3]
node Version: [e.g. v18.16]
npm version: [e.g. v10.1.0]
OS: [e.g. macos]
Browser [e.g. chrome, safari]

should be fixed now!

@jackyzha0 hello jacky,  I fetch the latest v4 branch, but it also don't work like your screenshot. Just clone quartz and link a local content dir.
In obsidian,  no other theme or plugin

src block

ref block

in local quartz

Another question, If there is multiple line content in callout , it seems only display last line , for eg

in obsisidian  ref block

in local quartz

the source note for t1 , t2 callout

src block

ref block

This is a different bug, it works in the top-level case like I showed. If theres a bug with nesting, please file another issue with the markdown to reproduce (don't just show screenshots, I don't want to retype everything in your screenshot)


ansifilter: 2.9 -> 2.10

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/ansifilter/versions.
These checks were done:

built on NixOS
ran /nix/store/wp22r5r6lyy9is1b6nb0vdhh8n7jfazc-ansifilter-2.10/bin/ansifilter -h got 0 exit code
ran /nix/store/wp22r5r6lyy9is1b6nb0vdhh8n7jfazc-ansifilter-2.10/bin/ansifilter --help got 0 exit code
ran /nix/store/wp22r5r6lyy9is1b6nb0vdhh8n7jfazc-ansifilter-2.10/bin/ansifilter -V and found version 2.10
ran /nix/store/wp22r5r6lyy9is1b6nb0vdhh8n7jfazc-ansifilter-2.10/bin/ansifilter -v and found version 2.10
ran /nix/store/wp22r5r6lyy9is1b6nb0vdhh8n7jfazc-ansifilter-2.10/bin/ansifilter --version and found version 2.10
found 2.10 with grep in /nix/store/wp22r5r6lyy9is1b6nb0vdhh8n7jfazc-ansifilter-2.10
directory tree listing: https://gist.github.com/88abe21b0d96cd9fa48d2f4a459faa6b

cc @Adjective-Object for review

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: ansifilter
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: ansifilter
Partial log (click to expand)
Do not hesitate to report problems. Unknown bugs are hard to fix.
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/wp22r5r6lyy9is1b6nb0vdhh8n7jfazc-ansifilter-2.10
shrinking /nix/store/wp22r5r6lyy9is1b6nb0vdhh8n7jfazc-ansifilter-2.10/bin/ansifilter
gzipping man pages under /nix/store/wp22r5r6lyy9is1b6nb0vdhh8n7jfazc-ansifilter-2.10/share/man/
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/wp22r5r6lyy9is1b6nb0vdhh8n7jfazc-ansifilter-2.10/bin
patching script interpreter paths in /nix/store/wp22r5r6lyy9is1b6nb0vdhh8n7jfazc-ansifilter-2.10
checking for references to /build in /nix/store/wp22r5r6lyy9is1b6nb0vdhh8n7jfazc-ansifilter-2.10...
/nix/store/wp22r5r6lyy9is1b6nb0vdhh8n7jfazc-ansifilter-2.10

Success on aarch64-linux (full log)
Attempted: ansifilter
Partial log (click to expand)
Do not hesitate to report problems. Unknown bugs are hard to fix.
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/i5fcg8j01y75chkr9s5wpi3lmzlbkyca-ansifilter-2.10
shrinking /nix/store/i5fcg8j01y75chkr9s5wpi3lmzlbkyca-ansifilter-2.10/bin/ansifilter
gzipping man pages under /nix/store/i5fcg8j01y75chkr9s5wpi3lmzlbkyca-ansifilter-2.10/share/man/
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/i5fcg8j01y75chkr9s5wpi3lmzlbkyca-ansifilter-2.10/bin
patching script interpreter paths in /nix/store/i5fcg8j01y75chkr9s5wpi3lmzlbkyca-ansifilter-2.10
checking for references to /build in /nix/store/i5fcg8j01y75chkr9s5wpi3lmzlbkyca-ansifilter-2.10...
/nix/store/i5fcg8j01y75chkr9s5wpi3lmzlbkyca-ansifilter-2.10