Update documentation, fix bugs, add makefile automation to repo

This pull request features two main changes:

Add a usable first version of a user guide that is worth the name.
Add a make file to the repo along with explanations in the README.md on how to use it.

Suggested version number: version 2.1.1
Explanations:
MAKEFILE
The addition of the makefile was mainly done to ease our lives, both while working on the user guide as well as to automate releasing a new version to CTAN.
Basically, once a new version is tagged on the repo one can run
make release

to update all version information in all files as well as rebuild the user guide with this information. (Try it! =))
Read the README.md for more information.
Userguide
In the cource of writing the user guide many improvements were made to the code and hidden options were made available to the user. In detail, the changelog was updated to

write usable version of user guide.
partially fix orphaned section headers for singualar use of \section and \subsection
commands and give users the new adjustable lengths \cvsectionstretchability
and \subsectionstretchability. In case \section and \subsection are used
directly one after the other, an orphaned section header might still occur.
This is structural and should be solved by \newpage instead of increasing
\cvsectionstretchability. Closes #10.
Systematize colors and make them user adjustable. See documentation for details.
this requires the \moderncvcolor to be issued BEFORE \moderncvstyle.
all styles: make the head options 'details' and 'nodetails' available to the user. (previously they were hidden). Oldstyle does not respond too well to nodetails.
casual style: make the head options 'alternate', 'details' and 'nodetails' available to the user. (previously they were hidden).
fix Researcher ID (still) doesn't display Issue #29.
make options 'symbols' and 'nosymbols' available to all styles to toggle whether
symbols should be used or not. Include symbols in oldstyle by default.
migrate older newcommand syntax in moderncvcollection.sty to the xparse syntax.
Fix resumé typo in template. Is now résumé.
remove loading lmodern fonts in all styles as they can produce issues with
german characters, see https://tex.stackexchange.com/questions/496630/lualatex-problems-with-german-characters.
remove loading inputenc package by default. Only load the package when pdflatex is
used.

It would probably be a good idea if someone proof read the user guide.
Sorry for the bulk change, I know it's bad practice, but it uhm kinda happend. =D.

Hi @cryptointerest,
first of all thanks for all the work! I will try to go through it once I have time (currently writing my BA so it's a bit limited).
Can you maybe split the different functionalities of this PR in separate PRs? I.e. one for the manual, one for each bug, one for the makefile. You can also base the PR on each other when required (i.e. makefile & documentation).

Ok, I will try to do that. I admit, that it is a lot to take in.
It might be, though, that I cannot separate every bug fix  cleanly (work flow mistake), but I'll do my best.
Is there any trick to doing this besides checking out certain commits and making pull requests for those?
Good luck with the BA.


chore(deps): update module github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper to v1.31.6

This PR contains the following updates:

Package
Type
Update
Change

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
patch
v1.31.5 -> v1.31.6

Release Notes

terraform-ibm-modules/ibmcloud-terratest-wrapper (github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper)
v1.31.6
Compare Source
Bug Fixes

deps: update gomod (#802) (efcfa2f)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 1.0.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


support for react and jsx

Hello @MattKetmo !
Thank you for this project!
Do you have any plans for integration your library with react jsx?
I Added d.ts for using your libs with typescript https://github.com/borisyankov/DefinitelyTyped/pull/5784.
may be you want add any comments/ tests?
Thank you!

And what about integration with npm? May be you push you project to npm?

Hello,
Package is avaiable via npm.
I've no plan to support react/jsx (I don't use it).
About d.ts I didn't know about that project. Thanks for the PR.

i can download this packige via npm, but i can't import this lib like node module.

This lib don't have commonjs module for npm, but this will block most of browserify and webpack user.

Feel free to submit a PR ;-)

@MattKetmo #67 should solved this.

I'm working to apply Darkroom as a React component, cause I need a picture editor at my app.
So, how should I share this implementation?

This will be fixed in next major version #79


Adding newer files into .gitignore and flake8 exceptions

Adding some mac-specific and pycharm-specific exceptions and venv to flake8.

LGTM, I think the CI errors have a dependency on https://github.com/Azure/azure-functions-python-worker/pull/649. Please take a look.

Sorry, I forgot to mention one more thing.
Please consider creating branch from the original repository in Azure/azure-functions-python-worker.
Fork PR will not run E2E.

Closing in favor of #655.


Make load payload method in PayloadStorageService handle exceptions

Goal
PayloadStorageServiceImpl.loadPayloadAsStream() already handles all thrown exceptions - remove the throw from the interface and allow it to do all the necessary logging.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1563  👈
#1558
#1548 : 1 other dependent PR (#1549 )
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bidetofevil and the rest of your teammates on  Graphite

Merge activity

Oct 22, 1:18 PM EDT: A user merged this pull request with Graphite.


unix:///var/run/supervisor.sock no such file

Running into issues with Supervisor, this little work-around seems to fix it
sudo touch /var/run/supervisor.sock
sudo chmod 777 /var/run/supervisor.sock
sudo service supervisor restart

How did you provision? Can you include the output of your provision + running session?

I just ran the normal install scripts inside of an Ubuntu docker container. I will follow up with output as soon as I get a moment

Hi
On a ubuntu:trusty docker container, setup script ./scripts/setup/install always fails at reloading  supervisor  conf. The restart commands fails:
https://github.com/zulip/zulip/blob/master/puppet/zulip/manifests/supervisor.pp#L25
The output it  bash -c 'supervisorctl reread &&.. ' returned error code 2, indicating the socket file of supervisor does not exist. Indeed, the supervisor service is not running at that time.
Removing the custom restart line and falling back to a classic puppet stop/start fixes the issue on my side.

I recently fixed this after running into the same issue on a Xenial VM.  Thanks for the report @royalaid!


Added support for Dismissable leave-behind list items

Dismissables can specify a background widget that's stacked behind the Dismissable's child. This makes it easy to implement the Material Design "leave-behind" idiom.
See the "Leave-behind" subsection of https://www.google.com/design/spec/components/lists-controls.html#lists-controls-types-of-list-controls
The value of the Dismissable's background is a DismissDirection Map. If different actions are associated with flinging to the left or right (or up and down), then different backgrounds are usually needed.
Added a leave-behind gallery demo.
Also:

Fixed Gallery home screen's text color; dark theme
Made ListItem's primary widget optional

A map seems a bit heavy-weight here. Isn't it always going to just be either two options, or one option that's used in both directions?

Yes there are typically three valid options.

I think I'd go with two arguments, like we do for animations and curves, where we have "curve" and "reverseCurve", and if reverseCurve isn't set we use "curve" for both.

lgtm


Update peer dependencies

According to following warnings
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.

I wonder if we could update peer deps for webpack and extract-text-webpack-plugin. I am using them at v2 without any issues.

Updated peer dependencies. I haven't had a chance to use the latest versions of extract text plugin or webpack so please let me know if you have any issues.

@iansinnott Sure! Should be fine for now 🙌

Published to npm


Add Igalia Coding Experience Program

Closes: https://github.com/tapasweni-pathak/SOC-Programs/issues/82

LGTM :+1:


KAFKA-2924: support offsets topic in DumpLogSegments

@ijuma Fixed the type parameters on MessageParser.

Thanks @hachikuji. :)

@guozhangwang Ready for another look when you have a chance.

LGTM. Waiting for Jenkins job to finish.

Merged to trunk and 0.9.0.


Adding missing files for Apache release

Added missing files based on other repos contents
Updated package.json with new release number

Is there a problem with the version number @rabbah ? I think it make sense to name it 3.19.0
But this is why we have a [DISCUSS] thread 😄

seems fine; 3.19 is just normal semvar increment to 3.18 (not 19.03 reversed ;))

Codecov Report

Merging #154 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #154   +/-   ##
=====================================
  Coverage      99%    99%
=====================================
  Files          14     14
  Lines         402    402
=====================================
  Hits          398    398
  Misses          4      4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cf8e35...3ab5c49. Read the comment docs.


Create installation_raspbian.md

Wrote the steps of Raspbian's installation.
Raspbian November 2018
Kernel 4.14
Device D435

Hi @sleepy-maker
Thank you for the document, this is awesome! The team had some limited experience with LUbuntu on the Pi but we never got to bringing the SDK up on the Raspbian.
Looking over the document, I believe there is a limitation with regards to hardware timestamps that might cause troubles until the OS upgrades to 4.16. We could add a disclaimer and suggest the -DFORCE_LIBUVC=true route as a possible alternative.


[Question] Should pods in one edge node be able to communicate pods in other edge nodes?

What happened:
I have the following setup to mimic two edge nodes at different locations, and as you can see in below log, edge nodes are on different sub-nets.
$ kubectl get no -o wide
NAME           STATUS   ROLES    AGE     VERSION    INTERNAL-IP      EXTERNAL-IP   OS-IMAGE             KERNEL-VERSION     CONTAINER-RUNTIME
nuc7i5bnh      Ready    master   5d      v1.18.15   <IP_ADDRESS>    <none>        Ubuntu 18.04.5 LTS   5.4.0-65-generic   docker://19.3.6
sharkbay-vm1   Ready    <none>   4d18h   v1.18.15   <IP_ADDRESS>   <none>        Ubuntu 18.04.5 LTS   5.4.0-65-generic   docker://19.3.6
ttzeng-vm1     Ready    <none>   5d      v1.18.15   <IP_ADDRESS>   <none>        Ubuntu 18.04.5 LTS   5.4.0-65-generic   docker://19.3.6

I tried to deploy pods to each nodes (including the master node), it seems pods in an edge node can't communicate pods in other nodes:
$ kubectl get po -o wide
NAME             READY   STATUS    RESTARTS   AGE     IP              NODE           NOMINATED NODE   READINESS GATES
test-po          1/1     Running   0          47m     <IP_ADDRESS>   ttzeng-vm1     <none>           <none>
test-po-master   1/1     Running   0          3m35s   <IP_ADDRESS>   nuc7i5bnh      <none>           <none>
test1-po         1/1     Running   0          8m41s   <IP_ADDRESS>     sharkbay-vm1   <none>           <none>

Run the edge pod from the master node reveals the yurt server/agent have the tunnel set up for the communications:
$ kubectl exec test-po -- ifconfig
eth0      Link encap:Ethernet  HWaddr AE:AD:A5:90:91:32
          inet addr:<IP_ADDRESS>  Bcast:<IP_ADDRESS>  Mask:<IP_ADDRESS>
          UP BROADCAST RUNNING MULTICAST  MTU:1440  Metric:1
          RX packets:11225 errors:0 dropped:0 overruns:0 frame:0
          TX packets:20592 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:0
          RX bytes:1089142 (1.0 MiB)  TX bytes:2006326 (1.9 MiB)

lo        Link encap:Local Loopback
          inet addr:<IP_ADDRESS>  Mask:<IP_ADDRESS>
          UP LOOPBACK RUNNING  MTU:65536  Metric:1
          RX packets:0 errors:0 dropped:0 overruns:0 frame:0
          TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:1000
          RX bytes:0 (0.0 B)  TX bytes:0 (0.0 B)

But I can't ping the address of pods on other nodes (including the master node):
$ kubectl exec test-po -- ping <IP_ADDRESS>
^C

What you expected to happen:
I think in the Kubernetes networking model, pods on a node should be able to communicate with other pods in a cluster, so should the Yurt agent or some mechanism should set up NAT rules to route packets targeting for other pods?

@ttzeng Thank you for filing issue.
network communication in OpenYurt can be divided into two kinds:

communication between cloud and edge(we also call this as north-south traffic)
communication between edge nodes or between pods on different nodes(we also call this east-west traffic)

and yurt-tunnel-server/yurt-tunnel-agent is responsible for the first kind communication(north-south traffic), so your first command kubectl exec test-po -- ifconfig has worked.
then the second kind communication,  currently OpenYurt and K8s are in line, so You can use container network solutions like Flannel/Calico on the basis that the physical network between nodes can be connected.
and the reason of your second command kubectl exec test-po -- ping <IP_ADDRESS> failure is that the physical network between edge nodes is not connected.

@rambohe-ch , thanks for the explanation! Yes, we have Calico CNI installed, but it looks like different subnets are assigned to two edge nodes (as they behind firewalls), so I think pods on different nodes should communicate through the tunnel, as they are still in the same cluster per k8s networking model, isn't it?
Do you have plans to extend the yurt tunnel or other mechanism to support the east-west traffic? or we are thinking to leverage the SD-EWAN in ICN project for usages with east-west traffic, how do you think?

@rambohe-ch , thanks for the explanation! Yes, we have Calico CNI installed, but it looks like different subnets are assigned to two edge nodes (as they behind firewalls), so I think pods on different nodes should communicate through the tunnel, as they are still in the same cluster per k8s networking model, isn't it?

I think the need for connectivity between pods will vary from edge scenario to edge scenario. If in scenario that use NodePool, pods in different NodePool may not need to connect each other. of course, there are some edge scenario that pods in different physical place,  They need to communicate with each other for transferring data or something else.

Do you have plans to extend the yurt tunnel or other mechanism to support the east-west traffic? or we are thinking to leverage the SD-EWAN in ICN project for usages with east-west traffic, how do you think?

Currently we have no plans to extend yurt-tunnel or other mechanism to support east-west traffic. and the OpenYurt roadmap is here: https://github.com/alibaba/openyurt/blob/master/docs/roadmap.md.
@wenjun93  FYI. leverage the SD-EWAN to support east-west traffic, do you have any comments?
@ttzeng If you can leverage the SD-EWAN  based on OpenYurt, I think the work will be welcome.

@ttzeng currently we have the ability of inter-nodes/pods communication in our commercial product, which is also based on openyurt. We leveraged alibaba cloud's network infrastructure and SDN solution for edge-to-cloud, edge-to-edge traffic, looked at the SD-EWAN solution and yes there are something in common, we can discuss it :)


Show location for each Type (Framework or NuGet PackageId) for each target framework.

Lots of APIs used to be part of the framework and available as an ***embly reference. Now each framework version may have differences on location, whether it is an included ***embly or included in a NuGet package. Please show which it is for that moniker and if NuGet which package and minimum version.

⚠ Idea migrated from UserVoice
Created By: Ovan Crone
Created On: 2017/12/07 21:01:25 +0000
Votes at Migration: 1
Supporters at Migration: 1

@Powerhelmsman yes, I will take this.

#log-suggestion

🚀 ATTENTION: Internal request logged.


Update module github.com/pion/transport to v3

@dkess I added you to the Pion org. The tests should always run for you, and you can merge this w/e you like!


Place multiple cursors on found places

Hi VS Code team,
this is a feature request.
I have now many files with JSX full of some attributes I don't need anymore. Like this:  <h4 data-translate="almostThere"> I want to remove them with as little effort as possible. I can start by searching for them using this data-translate=" and I get all of them, this is OK. Now I have to go one by one and remove them by hand.
Would be great if I could have all the found elements in the file, have a cursor at the begging of the found string. I could then just navigate with keyboard and select all of them at once and delete them. (I am talking about the search in file component, the one which appears on top right when you press Ctrl+F.)

VSCode Version: 1.22.2
OS Version: Windows 10

JFYI:

There is "Search in all files" function (Ctrl+Shift+F)
when you select data-translate, you may press Ctrl+D multiple times which will add next match to selection. You may then edit all those places at once

Thank you, I didn't know about this. It is almost as I imagined :) Super!


Host scripts on http://cdnjs.com/

Hi,
Is there a chance you'll host the script files on http://cdnjs.com/ to concatenate the scripts to minimize http requests?
I've read that all the cool kids do that :o
By the way,  can this project be installed via the NuGet package manager? Can't find it in there.

+1 ... any response to whether this will be hosted on cdnjs or jsdeliver?

This is hosted on cdnjs now https://cdnjs.com/libraries/smalot-bootstrap-datetimepicker


qasm3.dumps Output Contains "!" Character Causing Loading Error

When using qasm3.dumps to output QASM3 strings, an issue arises when a while loop with a condition of 0 is encountered. The generated QASM3 string contains a "!" character as part of the condition, which subsequently leads to an error during the loading of the QASM3 code.
Code Example
from qiskit.circuit import QuantumCircuit, Clbit, Qubit, qasm3
bits = [Qubit(), Qubit(), Clbit()]
qc = QuantumCircuit(bits)

with qc.while_loop((bits[2], 0)):
    qc.h(0)
    qc.cx(0, 1)
    qc.measure(0, 0)
print(qasm3_str:=qasm3.dumps(qc))

Generated QASM3 Code:

OPENQASM 3;
include "stdgates.inc";
bit _bit0;
qubit _qubit0;
qubit _qubit1;
while (!_bit0) {
  h _qubit0;
  cx _qubit0, _qubit1;
  _bit0 = measure _qubit0;
}

Attempting to Load QASM3 Code:
qc_load = qasm3.loads(qasm3_str)

Error Message:
QASM3ImporterError: "6,7: unhandled unary operator '!'"

Expected Behavior
To address the issue of the "!" character causing errors during loading, an alternative approach can be explored. This approach involves modifying the qasm3.loads function to handle the "!" character appropriately. By extending the functionality of the qasm3.loads function, it would be possible to interpret and process the "!" character within the while loop condition, preventing unhandled unary operator errors.
Steps to Reproduce
Execute the provided Python code snippet that uses qasm3.dumps to generate a QASM3 string containing a while loop with a 0 condition.
Attempt to load the generated QASM3 string using the qasm3.loads function.
Additional Information
qiskit Version: 0.44.0
openqasm3 Version: 0.4.0
qiskit_qasm3_import Version: 0.2.0
Python Version: 3.9.7

Thanks for the report.  Yeah, I haven't updated the OpenQASM 3 importer to take into account all the newly supported parts of Qiskit Terra 0.25 yet (Qiskit 0.44) yet, but I need to.


[video_player] Fix XCUITest based on the new tooltip accessibility label

The accessibility label for tool tip seems change in one of the recent flutter updates(https://github.com/flutter/flutter/pull/87684), which results failure in this particular XCUITest. This is blocking the flutter to plugins roll.
Fixes: https://github.com/flutter/flutter/issues/102698
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
[x] I signed the CLA.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
[x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Interesting, the test is still failing on master.

@chunhtai this failure was caused by https://github.com/flutter/flutter/pull/87684, is the swapping of label text like this expected?
@cyanglaz looks like this needs to be included in a manual framework->plugin roll so the tests pass, on top of a roll like https://github.com/flutter/plugins/pull/5425

Just to add to @jmagman's comment, the "Playback speed" is the tooltip name, and "1.0x" is the tooltip current value.
The accessibility value used to be \n
After https://github.com/flutter/flutter/pull/87684, the accessibility value becomes \n

yes, previously the tooltips are appended to the label before multiple semantics node merges, but now tooltips are appended after multiple semantics node merges.
It looks like the change surface an accessibility issue, too.  tooltip should be announced after the label not before.


Deployment - running via command line with SSL

Is it possible to run the server via command line with SSL?
Running python -m sanic doesn't give any information on this.
usage: sanic [-h] [--host HOST] [--port PORT] [--workers WORKERS] [--debug]
             module

Thanks!

@mikmatko This was not supported, no. However, do you want to test the branch I created above? :) You should be able to with
git checkout -b r0fls-523 master
git pull https://github.com/r0fls/sanic.git 523

Or we can just merge it, there is no reason it wouldn't work...

Closing this since I merged the above. Let me know if you have issues.


[CI] Added llvm-12 to ubuntu1804_install_llvm.sh

This PR adds llvm-12 to ubuntu1804_install_llvm.sh. This is needed as llvm, prior to 11.1.0, contains an issue which affects X86 backend and virtually prevents some cases of vectorization done in TVM (https://github.com/llvm/llvm-project/commit/c7b54a196e1363cbe43122f01a728cd71fa1686a).
To reproduce this issue locally one can use following publicly available network https://github.com/ARM-software/ML-zoo/blob/master/models/keyword_spotting/ds_cnn_small/tflite_int8/ds_cnn_s_quantized.tflite
Command line:
tvmc compile --target llvm ds_cnn_s_quantized.tflite
will fail in attempt to perform combineMul  on t20: v12i32 = mul nsw t19, t6 due to missing MVT of v6i32 (which in fact should be EVT, not MVT) on llvm versions prior 11.1.0

Also cc @areusch for review.

LGTM, let's merge to get this into #7995


plugin use own dependencies

Hi, I know this is not an issue, but I thought here is the right place to ask this question, after some tryings in the gitter channel.
So I make a plugin which uses moment js as dependency. But when I installed this plugin it wants moment to be installed in the global project. How can I say to my plugin when I "import moment from 'moment'" I need to load it from its own dependencies. I asked this question also here:
http://patrickwalters.net/making-out-first-plugin/
Thanks in advance

Answered elsewhere.


What does the split.mat file mean?

In the file structure you gave, I see a file called split.mat in the wrgbd directory, what does that file contain? Can you send it here? Thank you very much!

Hi,
Thank you for your interest. Washington RGB-D has 10 splits, of which a different category instance is used for testing. The final comparison is made by averaging the 10 split results. splits.mat contains those testing instances for each split. Please check the provided link in the description. You will find the split.mat, when you download the dataset (https://rgbd-dataset.cs.washington.edu/dataset/rgbd-dataset_eval/).

Thanks for you answer.
I've download the file named testinstance_ids.txt
Then I just change the file name into "splits.mat" simply. And got the error in the scrennshot.
How should I organize the .mat file ?
   File "/home/users/.conda/envs/cnnrandrnn/lib/python3.7/site-packages/scipy/io/matlab/miobase.py", line 231, in get_matfile_version     raise ValueError('Unknown mat file type, version %s, %s' % ret) ValueError: Unknown mat file type, version 98, 111

I uploaded the file. Please check the link here


Add notes and agendas for 11-4 11-11 meetings

Signed-off-by: FiniteStateGit<EMAIL_ADDRESS>

Closing in favor of #28.


Password Generation with more rules

Hi,
I could not find a solution to that so just asking wether I am missing something: can we enforce more rules while generating an account by 1Password, i.e. the need to have at least one uppercase character?
Thanks

Hi @omichde,
Thanks for taking the time to write in :+1:
The password generator options or recipe are showcased in ACME's RegisterViewController.
By default when generating random passwords, the result will contain both lowercase and uppercase letters, therefore there is no need to "enforce" uppercase letters.
In any case, the user can still modify the generated password in while the 1Password extension. For example by choosing the wordlist password generator.
In the event that the 1Password extension returns a generated password which is not accepted by your backend, we recommend the following:

Inform the user that the password could not be accepted and to show them the required recipe.
Prompt the user to update the password by calling changePasswordForLoginForURLString: to update the newly saved login.

You can achieve this by having a isPasswordRejected class property in your registration view controller.  The code should look as follows:
@IBAction func changePasswordIn1Password(sender:AnyObject) -> Void {
	if self.isPasswordRejected() {
		OnePasswordExtension.sharedExtension().changePasswordForLoginForURLString("https://www.mysite.com", loginDetails: newLoginDetails, passwordGenerationOptions: passwordGenerationOptions, forViewController: self, sender: sender) { (loginDictionary, error) -> Void in
			self.passwordRejected = validatePasswordWithTheBackEnd();
		}
	}
	else {
		OnePasswordExtension.sharedExtension().storeLoginForURLString("https://www.mysite.com", loginDetails: newLoginDetails, passwordGenerationOptions: passwordGenerationOptions, forViewController: self, sender: sender) { (loginDictionary, error) -> Void in
			self.passwordRejected = validatePasswordWithTheBackEnd();
		}
	}
}

I am closing this issue for now, but please feel free to continue the conversation in this issue. Please let me know if this helps :wink:
Cheers!

Hi @radazzouz
this looks like the best way to go, thanks many times for this tip, will try that on monday!
Cheers...

That is great to hear, @omichde! Thanks for getting back to me so quickly :+1:
This issue made me open issue #307. I think that the solution described in previous comment should make it into our Wiki. This way, we hope to be used my more developers.
Please let me know how did work for you and also please do let me know if there's anything I can do for you after you try it out on Monday.
Have an Awesome weekend!

Hi @radazzouz,
by means of your code I could at least re-implement this feature in our APP, but due to the poor/disconnected APP extension API, I had a hard time arguing about it with our product owner. But this is not bound to 1P nor your extension - which is working fine so thanks again for your help.
Cheers, Oliver

Hi Oliver,
Thanks for getting back to us :+1:
I am not sure I fully understand what you meant by "poor/disconnected APP extension API". Is this something, we can improve on our end?
BTW, if you wish to move this conversation to a more private channel, please feel free to email us at<EMAIL_ADDRESS>Best,
Rad

Hi Rad,
my concern is that our login screens are setup in a way where the user cannot easily update the (possibly changed) credentials afterwards - because he was moved to a different confirmation page, currently unaware of any credential handling.
And even if so, from a UX perspective, it's weird to ask the user on the confirmation page to store his credentials (again), selecting the 1P extension point, open the 1P extension (probably via TouchID) and confirm his changes.
Again, I know that this is due to the limited Extension API of UIKit.
Cheers, Oliver

Thanks again for taking the time to explain, Oliver!
Now that I understand how your app's login screens are setup, I totally agree with you. You are right about the Extension API not allowing a "session"-like method of communication between the host app (your app) and the 1Password extension.
From a UX perspective, I agree that it is weird to ask the user on the confirmation page to "update" their credentials again. In my previous comment, I was suggesting to add the ability to "allow" the user to update the credentials and not necessarily "ask".
Hope that this clarifies things a bit. Anyway, please do let us know if you have any other questions and make sure that you give us a heads up at https://blog.agilebits.com/contact-developers/ to submit your app to our "Apps ❤ 1Password".
All the Best,
Rad


storage for device ephemeral keys

Device EK seeds will be stored encrypted in files on disk with an in memory cache. We want to ensure that deletions truly wipe these secrets.

Sorry to be late to the party here, but I think we should make our own interface here, something like this:
type ErasableKVStorer interface {
   Put(key string, val []byte) error
   Get(key string) ([]byte, error)
   Erase(key string) error
   AllKeys() ([]string, error)
   EraseAll() error
}

I think eventually we'll have special implementations on iOS, since I believe there is special storage on iPhones that you can erase.
As @joshblum mentions (and @patrickxb also points out), this is very similar to the SecretStore stuff we already have. There are some differences: (1) the types are going to be different; (2) i think we should probably put these keys in their own subfolder; (3) I don't know if we should be writing them to the macOS or iOS keychain, since those resources might be backed up to iCloud Keychain in a way that we don't understand.

Some other differences from other key storage we've done, if I understand everything right:

We're going to mix a 2MB entropy file into the encryption step, rather than XORing it with the stored key itself. That lets us store an encrypted blob of any size, rather than just a 32 byte key.
Keys we're storing here need to be individually shreddable. I think under the other APIs we have, that would mean having N different stores, and shredding the entire store when we need to delete the one key it holds.

@maxtaco I don't think the keys are synced to icloud unless the flags aren't respected:
https://github.com/keybase/client/blob/8dca6f0dc7875c68ef6f4555f49195a21b12921c/go/libkb/secret_store_osx.go#L11

I can't comment because the lines didn't change, but ephermeral.go:138, 186, 196:  check the err that is coming back on those lines before proceeding.

ah good catch


enabling intel

Closes #541
Received a reply on that link that worked. It's unfortunate that we have to do that manually now but at least it works

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.25%. Comparing base (555be4e) to head (7eeaa8d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #545   +/-   ##
=======================================
  Coverage   92.25%   92.25%
=======================================
  Files          45       45
  Lines        3407     3407
=======================================
  Hits         3143     3143
  Misses        264      264

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


HHH-16541 - (Jakarta EE 10 Platform TCK) jpa/core/lock/query/Client.java#getResultListTest1 test regression

https://hibernate.atlassian.net/browse/HHH-16541
Unable to reproduce so far outside of the TCK

After debugging the TCK test, I figured the problem was that we forced using follow-on locking because of a LEFT TableJoin referring to an uninitialized LazyTableGroup, which revealed a bug in follow-on locking. I fixed both issues with my PR https://github.com/hibernate/hibernate-orm/pull/6568


Update PermissionsFragment.kt

Permission - Bugfix Missing permission

I met a crashing when back to CameraFragment
at  displayId = viewFinder.display.displayId

This sample does not use external storage, so the permission is not required


No overload for validator.Validate for named parameters and rulesets

System Details

FluentValidation version: Latest
Web Framework version (eg ASP.NET Core 2.1, MVC 5, WebApi 2. Delete if not applicable):

Issue Description
Hi Jeremy,
I'm trying to include ruleSets into one of my validators, however when I attempt to pass in a named parameter of ruleSet: "Required" into the Validate method of my validator, I get a compiler error that says that ruleSet cannot be resolved.
Here is the call to my validator.Validate: var results = validator.Validate(combination, ruleSet: "Required");
And here is the validator, as you can see the Required ruleset is defined here.
public QuestionValidator(QuestionBank questionBank, QuestionRulesetCombination combination)
        {
            RuleSet("Required", () =>
            {
                RuleFor(x => x.AnswerDetail.Answer).NotNull().When(x => x.RuleSet.Required)
                    .WithMessage($"Section {_section} question {_questionId} cannot be null.");
                RuleFor(x => x.AnswerDetail.Answer).NotEmpty().When(x => x.RuleSet.Required)
                    .WithMessage($"Section {_section} question {_questionId} cannot be empty.");
            });
        }

Do you have any idea what I'm doing wrong here?

The overload that takes a ruleset is an extension method, so you need a using statement for the FluentValidation namespace. Please see https://fluentvalidation.net/start#rulesets

Perfect, thanks!


Add AddressSanitizer to travis build

AddressSanitizer helps detecting memory corruption, buffer overruns and use after free.
Example of detected bugs: https://travis-ci.org/xonatius/s2n/jobs/533950514#L3880
https://github.com/google/sanitizers/wiki/AddressSanitizer
Issue # (if available):
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e65cfa9). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #1067   +/-   ##
=========================================
  Coverage          ?   87.01%
=========================================
  Files             ?      186
  Lines             ?    16626
  Branches          ?        0
=========================================
  Hits              ?    14467
  Misses            ?     2159
  Partials          ?        0


Alternative metadata syntax/semantics

I would like to write the metadata directly on the field, instead of a separate struct like this:
struct Person
{
    Field<"name", std::string> name;
    Field<"age", int> age;
    Field<"country", std::string> country;
};

I have made an example on how this syntax could be enabled: https://godbolt.org/z/acheb5Y1v

This is a neat concept and I appreciate your effort to put together a working example.
As you've shown its totally doable, and it lends itself to making very clean macros like FIELD(std::string, name);
I'm a bit hesitant of the design though. For one, while we could make these strings entirely static constexpr, I'd be afraid the compiler wouldn't be as efficient with packing and optimizing the struct. It's also annoying to have to call get_value() or use a conversion operator for basic types. It is much cleaner to just call Person.name or &Person.name to get the address. I find it best to use simple structures in coding with basic parameters for simple and clean code, and this approach adds a layer of indirection. I expect you could still see nearly the same performance, but I don't feel like the current glaze metadata approach is much more complicated than this approach, especially if you use the macros.
I've been thinking about creating a simple tool to generate the glaze metadata structs for a given C++ struct or header file. This way users would easily be able to automate their glz::meta generation.
Allowing users to not have to change their structures and still serialize/deserialize without any performance degradation is a huge benefit of the current design. The benefit of your design is that there is a clear connection between the metadata and the variable itself, but I'm not sure that the proximity is worth the added complexity to generally program with the structs. I feel that the API should just be an additional layer that you can remove or include without affecting any of the core programming logic.
Anyway, that's my philosophy, but I would love to hear more thoughts about this approach, pros and cons, and I'm always open to ways to improve the library. I just think this is a problem that should be solved by reflection, so whether that is creating a tool to generate the metadata, using compile builtins like __builtin_dump_struct, or patiently waiting for reflection to be added to C++, I think these are better long term solutions.
Sincerely,
Stephen


feat: set app version as dev when building locally

A small enhancement to help when doing local development remember which version of the app is running 😎

Would also be nice to have "demo notifications" so that we don't need to load real ones 🤔

I have a stash locally that mocks the API response.  Could add that into the scope of #980

A while ago I was using https://github.com/setchy/gitify-notifications-sandbox too, which could be transferred into the gitify-app organization if we wanted "real" notifications

I suppose there's the two cases, the ones where we just want to work with UI, and the cases where we need to work with the flow themselves.


Soon-to-be-depreciated functionality warnings in 2024.3.0

Home Assistant version
2024.3.0
SmartIR version
1.17.9
SmartIR configuration

Add configuration here

Describe the bug
Am using the integration to run IR commands for an aircon. Post upgrade to 2024.3.0, I am seeing these warning messages in HA:
Debug log

Logger: homeassistant.components.climate
Source: components/climate/__init__.py:361
integration: Climate ([documentation](https://www.home-assistant.io/integrations/climate), [issues](https://github.com/home-assistant/core/issues?q=is%3Aissue+is%3Aopen+label%3A%22integration%3A+climate%22))
First occurred: 8:43:04 PM (3 occurrences)
Last logged: 8:43:04 PM

    Entity None (<class 'custom_components.smartir.climate.SmartIRClimate'>) does not set ClimateEntityFeature.TURN_OFF but implements the turn_off method. Please report it to the author of the 'smartir' custom integration
    Entity None (<class 'custom_components.smartir.climate.SmartIRClimate'>) does not set ClimateEntityFeature.TURN_ON but implements the turn_on method. Please report it to the author of the 'smartir' custom integration
    Entity None (<class 'custom_components.smartir.climate.SmartIRClimate'>) implements HVACMode(s): off, cool, dry, fan_only and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please report it to the author of the 'smartir' custom integration

Logger: homeassistant.components.climate.const
Source: helpers/deprecation.py:205
integration: Climate (documentation, issues)
First occurred: 8:42:32 PM (9 occurrences)
Last logged: 8:42:32 PM

HVAC_MODE_FAN_ONLY was used from smartir, this is a deprecated constant which will be removed in HA Core 2025.1. Use HVACMode.FAN_ONLY instead, please report it to the author of the 'smartir' custom integration
HVAC_MODE_AUTO was used from smartir, this is a deprecated constant which will be removed in HA Core 2025.1. Use HVACMode.AUTO instead, please report it to the author of the 'smartir' custom integration
SUPPORT_TARGET_TEMPERATURE was used from smartir, this is a deprecated constant which will be removed in HA Core 2025.1. Use ClimateEntityFeature.TARGET_TEMPERATURE instead, please report it to the author of the 'smartir' custom integration
SUPPORT_FAN_MODE was used from smartir, this is a deprecated constant which will be removed in HA Core 2025.1. Use ClimateEntityFeature.FAN_MODE instead, please report it to the author of the 'smartir' custom integration
SUPPORT_SWING_MODE was used from smartir, this is a deprecated constant which will be removed in HA Core 2025.1. Use ClimateEntityFeature.SWING_MODE instead, please report it to the author of the 'smartir' custom integration

Additional context
Add any other context about the problem here.

Yep - have been seeing those log entries as well, so hoping the developer can fix it before, since my Broadlink would be pretty much useless to me if smart-ir stops working.

SmartIR doesn't get updated often, I suspect a fork is probably our best bet.

Hope there is an update or someone that could do a fork or lots of automation are going to the bin.

Same here. Yes, hope it'll get sorted.

Hi, I just pushed PR https://github.com/smartHomeHub/SmartIR/pull/1231 fixing all those warning and errors.
@vassilis-panos Coudl you please review it, merge it and release if suitable? It also seems, that you have many PR pending, mostly related to new added codes. Are you planning to merge those? If you need any help please let me know.
If anyone would like to meanwhile get rid of the errors, you can use my fork from here: https://github.com/litinoveweedle/SmartIR

Hi, I just pushed PR #1231 fixing all those warning and errors.
@vassilis-panos Coudl you please review it, merge it and release if suitable? It also seems, that you have many PR pending, mostly related to new added codes. Are you planning to merge those? If you need any help please let me know.
If anyone would like to meanwhile get rid of the errors, you can use my fork from here: https://github.com/litinoveweedle/SmartIR

You are a legend. Thank you for your work.

Hi, I just pushed PR #1231 fixing all those warning and errors.
@vassilis-panos Coudl you please review it, merge it and release if suitable? It also seems, that you have many PR pending, mostly related to new added codes. Are you planning to merge those? If you need any help please let me know.
If anyone would like to meanwhile get rid of the errors, you can use my fork from here: https://github.com/litinoveweedle/SmartIR

Thank you for your work! I have been using your fork, but a new warning appeared unfortunalty, looks like HA is doing a lot of change.

Detected that custom integration 'smartir' calls 'async_track_state_change' instead of 'async_track_state_change_event' which is deprecated and will be removed in Home Assistant 2025.5 at custom_components/smartir/climate.py, line 176: async_track_state_change(self.hass, self._temperature_sensor, please report it to the author of the 'smartir' custom integration
• Detected that custom integration 'smartir' calls 'async_track_state_change instead of 'async_track_state_change_event' which is deprecated and will be removed in Home Assistant 2025.5 at custom_components/smartir/climate.py, line 192: async_track_state_change(self.hass, self._power_sensor, please report it to the author of the 'smartir' custom

Same

Hello, fixed in PR3  and release in the 1.17.11 in my forked repo.
As @vassilis-panos seem to ignore all my previous PRs, I did not opened PR with this fix against his/this original repo. I have no issue to push it later, if I there will be any sight of activity from his side. Therefore I am afraid you need to use my repo till then.

Hello, fixed in PR3 and release in the 1.17.11 in my forked repo.
As @vassilis-panos seem to ignore all my previous PRs, I did not opened PR with this fix against his/this original repo. I have no issue to push it later, if I there will be any sight of activity from his side. Therefore I am afraid you need to use my repo till then.

Hi how do i use your repo in Homeassistant instead of the original ?

HACS, add custom repo.

@litinoveweedle please note that the following errors on v1.17.12
2024-05-18 21:20:33.920 ERROR (MainThread) [homeassistant.config] Platform error: climate - cannot import name 'EventStateChangedData' from 'homeassistant.core' (/usr/src/homeassistant/homeassistant/core.py)
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/config.py", line 1437, in _async_load_and_validate_platform_integration
platform = await p_integration.integration.async_get_platform(domain)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/loader.py", line 1070, in async_get_platform
platforms = await self.async_get_platforms((platform_name,))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/loader.py", line 1163, in async_get_platforms
platforms[platform_name] = await future
^^^^^^^^^^^^
ImportError: cannot import name 'EventStateChangedData' from 'homeassistant.core' (/usr/src/homeassistant/homeassistant/core.py)

Fixed by upgrading to latest version of Home Assistant, please ignore.

Yep, that makes sense, as the warning fix is for the recent  HA version. I will check the exact version and put it as a prerequisite for integration into HACS manifest. Although I am pretty sure it is there. Did you by any chance install integration manually?

HACS, add custom repo.

Hi adding your repo to the repository won' t reset the originasl smarir  configuration right? Or i must reconfigure my smartir devices with the new repo?

Hi litinoveweedle
What exactly is your fork for?
And please do not submit it to HACS. There's a reason it hasn't been done all this time

Hello @vassilis-panos

What exactly is your fork for?

The reason I initially started my fork was because I needed some PR from other users included, PR which you did not merged for long time into your releases. Than I started to fix some recent HA deprecation warnings and also some long pending bugs reported to your repo. I was trying to push my changes to your mainstream, but without response I gave up. To ease maintenance and installation of my fork I therefore started making some less compatible changes now, including own custom HACS repo.

And please do not submit it to HACS. There's a reason it hasn't been done all this time

Any specific reason for that? In the next commit I am going to remove your original functionality for checking and updating integration version directly from github, as well as automatic download of the codes. This is from my perspective redundant to HACS (update of the integration) and potentially less secure dependent (codes download). Codes will be distributes as part of the HACS zip package release.

HACS, add custom repo.

Hi adding your repo to the repository won' t reset the originasl smarir configuration right? Or i must reconfigure my smartir devices with the new repo?

Test it and you will see. It is easy to make backup of whole HA or just HA configuration. It is just copy paste.

@vassilis-panos any reason you are not accepting PR? I see over 84 PRs pending.
Just need to know your opinion.

Hey, no need to cry here, just use my fork https://github.com/litinoveweedle/SmartIR
It is kept up to date, just beware of some minor breaking changes. (Just read the docs)


Use v0.1 image (latest image from release-0.1 branch) instead of latest image

/cc @chuckha
What this PR does / why we need it:
capdctl build off the release-0.1 branch should not default to the latest image of capd-manager, since that may be built off the master branch.

/lgtm


Bug when multiple PyEcoNet objects are instantiated

First of all, thank you for this package.  I love it!
On api.py:166, the HEADERS['Authorization'] template is populated with the token returned during authentication.  But it seems that this affects the HEADERS global, modifying the 'Authorization' value from 'Bearer %s' to 'Bearer [token]'.  Consider the following repro:
print(pyeconet.api.HEADERS)
PyEcoNet(ECONET_USERNAME, ECONET_PASSWORD)
print(pyeconet.api.HEADERS)
PyEcoNet(ECONET_USERNAME, ECONET_PASSWORD)

The first print shows: {'Authorization': 'Bearer %s', 'Content-Type': 'application/json'}
The second print shows: {'Authorization': 'Bearer abcdefg', 'Content-Type': 'application/json'}
And the second PyEcoNet invocation fails with:
Traceback (most recent call last):
  File "[redacted]/hpwh/main.py", line 21, in hpwh
    econet = PyEcoNet(ECONET_USERNAME, ECONET_PASSWORD)
  File "[redacted]/pyeconet/api.py", line 179, in __init__
    self.api_interface = EcoNetApiInterface(username, password)
  File "[redacted]/pyeconet/api.py", line 42, in __init__
    self.authenticated = self._authenticate()
  File "[redacted]/pyeconet/api.py", line 166, in _authenticate
    _auth = _auth % self.token
TypeError: not all arguments converted during string formatting

The hacky workaround is to re-set HEADERS['Authorization'] before instantiating PyEcoNet.
(In case it matters, this was repro'd in Python 3.7.5.)

Note that the workaround can (theoretically, but probably not practically) break the first instance (if you're using them concurrently), so it's most valid if you don't plan on using the first instance anymore (which happens to be the case for me).  (One more parenthetical for good measure!)

This should no longer be an issue with the new API.


BIGTOP-3721: Add Kafka support for Bigtop 3.1.0 Mpack

Description of PR
Add Kafka support for Bigtop 3.1.0 Mpack
Tested in CentOS7
How was this patch tested?
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'BIGTOP-3638. Your PR title ...')?
[ ] Make sure that newly added files do not have any licensing issues. When in doubt refer to https://www.apache.org/licenses/

@kevinw66 Thanks for working on it.
Pls give me some time to try to deploy this Kafa service by Mpack.

Integrated Mpacks PRs (#934 #933 #932 #931) with this one,  Hadoop, ZK and Kafka can be successfully deployed by Mpack with Bigtop-3.1.0.

+1, LGTM
I'd like to merge this PR after more tests for (#934 #933 #932 #931) .

Seems like there are problem when we Restart a running Kafka Broker.
But when click Stop then Start, it works fine.
Let me check on this.

Ran stop, start, restart Kafka services and both succeeded.
+1


Allow non-logged-in users to view published and public messages

Allow non-logged-in users to view published and public messages

rest api merge closes this issue


bug(gatsby-plugin-fastify): Error fetching page data for /using-ssr when pagePrefix is set

The error happens when I use pathPrefix (e.g: /gatsby) in gatsby-config.js. I am serving SSR pages.
ERROR: Error processing /gatsby/page-data/using-ssr/page-data.json, Error fetching page data for /using-ssr: Page for "/gatsby/page-data/using-ssr/page-data.json" not found
To Reproduce
Steps to reproduce the behavior:

Run the following boilerplate npx gatsby new gatsby-starter-rendering-modes
Add the following packagesnpm install gatsby-plugin-fastify fastify
Set pathPrefix (e.g: /gatsby) in gatsby-config.js
Add the plugin plugins: [ { resolve: 'gatsby-plugin-fastify' }] in gatsby-config.js,
Add the script { "scripts": { "start": "gserve" } } in package.json
Run the command npm run start
The error appears in Console Tab

A quick search in the gatsby-plugin-fastify code reveals me, the reason of the error.
Use potentialPagePath instead of workingURL variable as pathName param in the getData method.

[Additionally to solve problem with trailingSlash]
Use path instead of workingURL variable as param of reverseFixedPagePath method.

Expected behavior
A quick change in the compiled code solves the problem.
Code line 56 is modified to use the variable potentialPagePath.

[Additionally to solve problem with trailingSlash]
Code line 93 is modified to use the variable path.

eureka!!!

System Info

After running the command: yarn gatsby info --clipboard in my project directory
System:
OS: Windows 11 10.0.22621
CPU: (4) x64 Apple Silicon
Binaries:
Node: 19.9.0 - C:\Users\JHONNY~1\AppData\Local\Temp\xfs-fea441dd\node.CMD
Yarn: 4.0.2 - C:\Users\JHONNY~1\AppData\Local\Temp\xfs-fea441dd\yarn.CMD
npm: 9.6.3 - C:\Program Files\nodejs\npm.CMD
Languages:
Python: 3.12.0
Browsers:
Edge: Chromium (119.0.2151.97)
npmPackages:
gatsby: 5.12.12 => 5.12.12
gatsby-plugin-alias-imports: 1.0.5 => 1.0.5
gatsby-plugin-fastify: 0.13.1 => 0.13.1
gatsby-plugin-federation: 2.5.0 => 2.5.0
gatsby-plugin-image: 3.12.3 => 3.12.3
gatsby-plugin-manifest: 5.12.3 => 5.12.3
gatsby-plugin-offline: 6.12.3 => 6.12.3
gatsby-plugin-preconnect: 1.4.0 => 1.4.0
gatsby-plugin-robots-txt: 1.8.0 => 1.8.0
gatsby-plugin-sharp: 5.12.3 => 5.12.3
gatsby-plugin-sitemap: 6.12.3 => 6.12.3
gatsby-plugin-styled-components: 6.12.0 => 6.12.0
gatsby-source-filesystem: 5.12.1 => 5.12.1
gatsby-transformer-sharp: 5.12.3 => 5.12.3

@moonmeister
Yes, I did!
I am using gatsby build --prefix-paths in order to build with prefixPath. Right now I am serving my app with that configuration and with that minimal change. I would appreciate to you that you can reproduce my issue following my instrucction.
Include the gatsby build --prefix-paths in the script,  since I omite mentioned it before.
Note: in fact gatsby serve  --prefix-paths has problems using SSR. And your plugin is better than gatsby serve

The many problems with gatsby serve are why this plugin exists.
Okay, I'll try to find some time to look at this.
From my current understanding your current solution shouldn't be correct, the assumption is...if you have a prefix, the non-prefixed path is probably an entirely different server and thus wouldn't be able to handle these routes.

Okay, confirmed. I understand what's happening. potentialPagePath seems like the correct move since we already have that. I'm happy to merge a PR on this if you can get that submitted.

Thank you for the confirmation! I agree with proceeding with "potentialPagePath". I plan to submit the Pull Request, but I'll do so after the Christmas holidays. I hope you have a wonderful holiday season with your loved ones as well. 🎄☃

Deprecating Package. See: #495 for more info.


Simplify no_std implementation

By removing the usage of thread_local! entirely, we can simplify the code around no_std.

Does that mean string interning works on no_std now?

It does not.
It uses a HashMap, so we either stop using the std one or find a different implementation.
In any case, its unrelated to this PR.


fix: [REGAPIC] Fix snake_case nested resource names in generated unit tests

Prior to this fix we were comparing snake_case and camelCase of the same resource. Most often field names consist of one word (so both cases are the same), so this was not causing troubles.

lgtm. Is there an issue for this?

I guess buganizer automatically started creating issues for "fix" PRs. But no issue in github. I thought it was too small of a problem to have an issue for it. Do you want me to create one?


Remove map form drop and pickup location. And Fixed issue no. #1977.

Related Issue
None
[Cite any related issue(s) this pull request addresses. If none, simply state “None”]
Fixes:  #1977
Description

This pr will remove maps form drop and pickup location. And  issue #1977 is fixed.
[Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.]

Type of PR

[ ] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes. Make sure to attach before & after screenshots in your PR.]

Checklist:

[x] I have made this change from my own.
[ ] I have taken help from some online resources.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers and screenshots after making the changes.

Please help me with the pr description check.

Please accept this pr.

Please accept this pr as today is the last day of event


[JS] MQ-type work

When we have MQ time, we should invest in our JS infra to make our lives easier:

[ ] Move away from Lerna (possibly to workspaces), as Lerna is basically unmaintained at this point
[x] #6635
[ ] For each officially-published-package:

[ ] Split code out into separate files
[ ] Investigate code chunking/splitting/lazy-loading

[ ] [JS] Officially move to Node v14
[x] #6636
[x] #6637
[x] #6638
[ ] Consider restructuring "private" packages into other folders/projects
[x] #6605
[ ] Move over to monaco-webpack-plugin for designer (currently we have a declared dependency, but I don't think we're actually using it properly)
[x] #6634
[ ] Revisit/revive/enforce eslint use

Could you guys also consider building (and publishing) the various packages as ES modules instead of (or in addition to) CommonJS modules?
There's a big advantage to ES modules in that they can be dynamically imported from an HTTP endpoint at runtime, which isn't possible otherwise. Webpack 5 has support for ES modules, although at this point I believe it's still experimental.

And, could you also consider compiling to ES6 instead of ES5, now that IE isn't supported anymore?

Could you guys also consider building (and publishing) the various packages as ES modules instead of (or in addition to) CommonJS modules?
There's a big advantage to ES modules in that they can be dynamically imported from an HTTP endpoint at runtime, which isn't possible otherwise. Webpack 5 has support for ES modules, although at this point I believe it's still experimental.

Absolutely should be on this list -- in fact, I was just doing some reading on this just this morning. The only sticky bit for us is that Jest's support of ESM is also experimental (and some features like mocks aren't currently working). It's a solvable problem though, and I think we'd get more benefits than costs.


Implement basic isExpression

this is needed for templates
only is(typename) is implemented for now
but it is also the only thing parsed :)

Fixed

It would be good to test some identifier resolution on some template.

done

added template to test

I'll use asserts then;

It would be good to test some identifier resolution on some template parameter.

Ping ?

I just got back to working on this.
There is still stuff to figure out.

so ... basically this can work if we are content with disallowing stuff like is(S.opEquals) and require is(S.init.opEquals) instead.
I seem to recall that dmd rewrites S.bla to => S.init.bla


Reduce PDB$SEED UNDO and TEMP tablespaces

The current 21-full image comes with an UNDO tablespace and a TEMP tablespace that are taking space. This slows down the PDB provisioning process. It would be great to have the minimum size being used for each:

4 MB for UNDO
2 MB for TEMP

Hi @loiclefevre,
The full images are kept as close as possible to the out-of-the-box installation provided by the Oracle DB installation RPM file to allow for further customization of the default install. The UNDO and TEMP tablespaces are both shrunk for the CDB, PDB$SEED and XEPDB1 for the regular and slim images.


Upgradle idea-ext plugin to 1.0.1

fixing a task validation problem.
Fixes gradle/gradle-private#3300

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.

Pre-tested commit build cancelled.

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.


test #[derive] on packed struct

@bors r+

:pushpin: Commit 6a81014ae9f169b4b6277b76052ea0a032049477 has been approved by RalfJung

:hourglass: Testing commit 6a81014ae9f169b4b6277b76052ea0a032049477 with merge 562d60242204d149fef3c580cb70e6ccbb0a3723...

:sunny: Test successful - checks-travis, status-appveyor
Approved by: RalfJung
Pushing 562d60242204d149fef3c580cb70e6ccbb0a3723 to master...


Improve killPrecedessors in unclip

The previous method was poorly optimized. This commit comes with a speedup
on the order of two magnitudes.
goos: linux
goarch: amd64
pkg: github.com/gopasspw/gopass/pkg/clipboard
BenchmarkWalkProc-8            1<PHONE_NUMBER> ns/op
BenchmarkListProc-8<PHONE_NUMBER>4 ns/op
PASS
ok      github.com/gopasspw/gopass/pkg/clipboard        4.397s

Fixes #923
Signed-off-by: Dominik Schulz<EMAIL_ADDRESS>

Codecov Report

Merging #1074 into master will decrease coverage by 0.02%.
The diff coverage is 56.52%.

@@            Coverage Diff             @@
##           master    #1074      +/-   ##
==========================================
- Coverage   62.68%   62.66%   -0.02%
==========================================
  Files         183      183
  Lines       10227    10225       -2
==========================================
- Hits         6410     6407       -3
- Misses       3020     3021       +1
  Partials      797      797

Impacted Files
Coverage Δ

pkg/clipboard/clipboard_others.go
68.75% <56.52%> (-4.78%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4bdc69...cb9bcab. Read the comment docs.


Get-DbaAgentJobCategory - minor fixes and added tests

Type of Change

[ ] Bug fix (non-breaking change, fixes #)
[ ] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[X] Pester test is included
[ ] Nunit test is included
[X] Documentation
[ ] Build system

Purpose

tidied up CBH
fixed capitalization
added tests

bon!


Fix postgres restore wrong db type

Fixed a typo when restoring Postgres db.

Thanks!

Tagged as 3.3.11


use LocalAddr for UDP associate bind address

In UDP associate, the IP address used for connection from the client should be notified to client (at least, https://github.com/3proxy/3proxy is implemented in this way).
This also fixes IPv6 address ([::]) replied for IPv4 UDP associate request (in bytes, [5, 3, 0, 1, 0, 0, 0, 0, 0, 0]). Sorry this is wrong.

Oh sorry I found there is another pull request of much the same purpose (https://github.com/things-go/go-socks5/pull/63) but I think my implementation is more appropriate because clients on other hosts require external IP address to use UDP associate bind address.

@thinkgos Hi, can you merge this pull request?  I still think this is better than https://github.com/things-go/go-socks5/pull/63 .

@ge9 sorry, I am busy recently! I have a idea, custom bind address that user can define, but the package give a default implement.  so the fregie implemt can easy define itself.

But then it will be difficult to make go-socks5 listen to the wildcard address (<IP_ADDRESS>:XXXXX)?

listUDP need *net.UDPAddr, we can define a custom function like ResolveUdpAddr , define some parameter, return the  *net.UDPAddr and error, this is same as this PR .

But then it will be difficult to make go-socks5 listen to the wildcard address (<IP_ADDRESS>:XXXXX)?

Ah, I see, that's great! Thank you for your idea.

@ge9 the code change so much, not resolve #63 #65.

Oh, sorry, I've forgot to create a branch...


Charts: Custom Tick format

Description of suggestion or shortcoming:
The current "Tick format" is pretty bad for very small/large numbers.
D3 also allows for ".^10", but that's also kind of bad.
I imagine we want something custom. Some ideas:
0.00003 -> 3E-5
0.0003 -> 0.0003
0.03 -> 0.03
0 -> 0
0.3 -> 0.3
5,500 -> 5,500
5,000,000 -> 5M
5,000,000,000 -> 5B
5,000,000,000,000 -> 5T
5,000,000,000,000,000 -> 5E15
It would be nice if we could detect if the numbers span <0.0001 or >10E15, and if so, only use E notation for 1M+, too. Or, more specifically, we only use "M/B/T" in cases where all numbers are between 0.0001 and 10E15.

Yeah, we need our own custom tick format implementation, nothing in d3-format is good enough. I don't see much of a problem on the first screenshot, though?

Ah, you're right. Removed, though I'm trying something else now. I think you're right about our own tick format, I'll make a new issue for that.

I changed this issue accordingly


ZPA Pulumi Provider gone

This is unlikely to be the right repository, but given that the projects are so closely related, it make sense to post it here. What happened to the pulumi-zpa package? It was supported by the same team, and actually worked really well.
We're currently in the rollout-phase of ZPA, and exclusively use Pulumi for IaC, so this would severely limit our rollout.
Can anyone from the Zscaler team look at this?

Closing this issue, so we can continue conversations offline.


Implement exp distance-similarity

exp(-d/s)
s is a hyperparameter
ref: https://en.wikipedia.org/wiki/Exponential_distribution

Implemented at #26

fuck! I forgot the s hyperparameter...


Make javadocs fail on error

Pull Request Etiquette

[x] I have checked the PRs for upcoming features/bug fixes.
[x] I have read the contributing guidelines.

Changes

[x] Internal code
[ ] Library interface (affecting end-user code)
[ ] Documentation
[x] Other: _____

Closes Issue: NaN
Description
Replace this sentence with general description of what your Pull Request does.

According to https://docs.github.com/en/actions/learn-github-actions/environment-variables#default-environment-variables
I'll alter the isCI variable


[9.x] assertJson and assertExactJson do not handle enums the same way

Laravel Version: 9.27.0
PHP Version: 8.1.9
Database Driver & Version: n/a

Description:
The assertions assertExactJson(), assertJson(array), and assertJson(\Closure(AssertableJson)) handle enums differently, this is primarily due to assertExactJson() converting both payloads to JSON before comparison.
With assertExactJson a backed enum case can be passed as is, while both versions of assertJson() require ->value to be called in order for it to work.
Steps To Reproduce:
Create an enum in your application:
<?php

namespace App;

enum FooEnum: string
{
    case Bar = 'bar';
}

Add a route that returns an enum instance as part of a JSON response
Route::get('/', fn () => response()->json(['value' => App\FooEnum::Bar]));

The response would look something like this:
{"value":"bar"}

Add a test that asserts the response of the route
<?php

namespace Tests\Feature;

use App\FooEnum;
use Illuminate\Testing\Fluent\AssertableJson;
use Tests\TestCase;

class ExampleTest extends TestCase
{
    public function test_the_application_returns_a_successful_response()
    {
        $response = $this->get('/');

        // This will pass
        $response->assertExactJson(['value' => FooEnum::Bar]);

        // This will fail, but the error will be clear enough for the dev to understand whats going on
        //
        // E.g.:
        // Property [value] does not match the expected value.
        // Failed asserting that 'bar' is identical to an object of class "App\FooEnum".
        $response->assertJson(function (AssertableJson $json) {
            $json->where('value', FooEnum::Bar);
        });

        // This will fail with an error message where "expected" and "actual" are the same
        //
        // E.g.:
        // Unable to find JSON:
        //
        // [{
        //     "value": "bar"
        // }]
        //
        // within response JSON:
        //
        // [{
        //     "value": "bar"
        // }].
        $response->assertJson(['value' => FooEnum::Bar]);
    }
}

How to fix
In my opinion the framework should implicitly convert backed enums to their primitive values here, similar to what it does when creating the response itself. I'm open to creating a PR for this.

Heya, this seems more like a feature request. Feel free to attempt a PR 👍


Schnorr Signature support

WIP, still working on the error test vectors and cecc.py

One idea to make this easier to merge: make schnorr support python only for now.

OK, this should work now. Requires libsecp256k1 to be configured with
$ ./configure --enable-module-extrakeys --enable-module-schnorrsig --enable-experimental
The libsec optimization is totally worth it. test_schnorr on my machine runs in 0.05 seconds with libsec, 5.8 seconds without.

OK, this should work now. Requires libsecp256k1 to be configured with
$ ./configure --enable-module-extrakeys --enable-module-schnorrsig --enable-experimental

Add this to readme as part of this PR?

all bumped and README instructions updated.


Add Dennis Onyeka to interested-technical-writers.md #548

Kindly merge Dennis onyeka to the list of interested technical writers #548

Hi! To add yourself, please follow the instructions on the interested technical writers page.


Use devise method to store request location

Currently, redirecting after sign in loses query parameters. This change uses the Devise built-in method to store the location instead of doing it manually (since the Devise method handles query params). This method was created in Devise v.3.2.1, which would change the dependencies for the project.
An example of the problem is OAuth and expired passwords. OAuth makes use of a variety of query parameters to do its business. If the user has an expired password upon login, after successfully updating their password they cannot continue with the login process as all of OAuth's parameters are lost.

Could someone test this? I'd really like to merge it.

Hi @manno - we have been using this patch in production for 6 months and it's working well. Or were you talking about getting a unit test written?

More tests would be great, but if it's working for you I'll merge this in a moment.


lblis, lbr: 增加查询后端状态接口

这个 PR 实现什么功能/修复什么问题:
climc: 添加lblistener{,rule}-backend-status命令
lblis, lbr: 增加查询后端状态接口
lbbackends: 使用yunion.io/pkg/errors
influxdb: 记录结果中的tags

是否需要 backport 到之前的 release 分支:

release/2.10.0

/area region
/cc @ioito @tb365 @swordqiu

/lgtm

Codecov Report

Merging #3606 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #3606      +/-   ##
=========================================
- Coverage    6.97%   6.95%   -0.02%
=========================================
  Files         499     498       -1
  Lines       83677   83557     -120
=========================================
- Hits         5834    5813      -21
+ Misses      77346   77248      -98
+ Partials      497     496       -1

Flag
Coverage Δ

#aFlag
6.95% <0%> (-0.02%)
:arrow_down:

Impacted Files
Coverage Δ

pkg/util/influxdb/influxdb.go
0% <ø> (ø)
:arrow_up:

pkg/compute/models/loadbalancerbackends.go
2.8% <0%> (ø)
:arrow_up:

pkg/compute/models/loadbalancers.go
1.71% <0%> (-0.03%)
:arrow_down:

pkg/compute/models/loadbalancer_backendstatus.go
0% <0%> (ø)

pkg/compute/models/loadbalanceragents.go
2.25% <0%> (-0.04%)
:arrow_down:

pkg/cloudcommon/db/lockman/inmemory.go
62.19% <0%> (-4.88%)
:arrow_down:

pkg/baremetal/manager.go
0.52% <0%> (-0.01%)
:arrow_down:

pkg/cloudprovider/fakeregion.go
0% <0%> (ø)
:arrow_up:

pkg/compute/models/guestdrivers.go
20% <0%> (ø)
:arrow_up:

pkg/multicloud/aws/region.go
0% <0%> (ø)
:arrow_up:

... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 184f404...10e575f. Read the comment docs.

/lgtm

/lgtm

/lgtm

/approve

/approve


Reading appsetting value for creating FileName doesn't work

Hi,
I try to read an appsetting value for my filename in the target environment.
fileName="${environment:variable=TEMP}${appsetting: name  = mykey : default = mydefaultname }\Trace\test.log"
This ends up in following Exception:
Additional information: An error occurred creating the configuration section handler for nlog: Error when setting property 'FileName' on File Target[file].
Any idea why this doesn't work? The value for mykey is set correctly in appSettings environment.
Thanks!

/closed
Forgot to use the NlogExtended binary file :)


[CI]: K8sUpdates Tests upgrade and downgrade from a Cilium stable image to master

/home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:383
Cannot curl app1-service
Expected command: kubectl exec -n default app2-85b74b9c79-ztpb6 -- curl -s -D /dev/stderr --fail --connect-timeout 3 --max-time 8 http://app1-service/public -w "time-> DNS: '%{time_namelookup}(%{remote_ip})', Connect: '%{time_connect}',Transfer '%{time_starttransfer}', total '%{time_total}'"
To succeed, but it failed:
Exitcode: 28
Stdout:
 	 time-> DNS: '0.000000()', Connect: '0.000000',Transfer '0.000000', total '3.516777'
Stderr:
 	 command terminated with exit code 28

/home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/k8sT/Updates.go:216

e413417a_K8sUpdates_Tests_upgrade_and_downgrade_from_a_Cilium_stable_image_to_master.zip
2nd time:
da2b440e_K8sUpdates_Tests_upgrade_and_downgrade_from_a_Cilium_stable_image_to_master.zip

Happened in https://jenkins.cilium.io/job/cilium-ginkgo/job/cilium/job/master/1957/testReport/junit/k8s-1/8/K8sUpdates_Tests_upgrade_and_downgrade_from_a_Cilium_stable_image_to_master/ as well

happened here as well https://github.com/cilium/cilium/pull/6331

Another failure: https://jenkins.cilium.io/job/cilium-ginkgo/job/cilium/job/master/1965/testReport/junit/k8s-1/8/K8sUpdates_Tests_upgrade_and_downgrade_from_a_Cilium_stable_image_to_master/

master:  https://jenkins.cilium.io/job/cilium-ginkgo/job/cilium/job/master/2763
test_results_master_2763_BDD-Test-PR.zip
I've seen this one other time, and it may be distinct from the test failing overall:
23:54:23  cmd: kubectl get pods -o wide --all-namespaces
23:54:23  Exitcode: 0
23:54:23  Stdout:
23:54:23   	 NAMESPACE     NAME                                    READY     STATUS     RESTARTS   AGE       IP              NODE
23:54:23  	 kube-system   cilium-etcd-b245mtxhtk                  1/1       Running    0          34m       <IP_ADDRESS>      k8s1
23:54:23  	 kube-system   cilium-etcd-hf74w4zsdd                  1/1       Unknown    0          34m       <IP_ADDRESS>      k8s2
23:54:23  	 kube-system   cilium-etcd-operator-77d4ddf8c6-5skxb   1/1       Unknown    0          36m       <IP_ADDRESS>   k8s2
23:54:23  	 kube-system   cilium-etcd-whh4wxpk6v                  1/1       Unknown    0          34m       <IP_ADDRESS>      k8s2
23:54:23  	 kube-system   cilium-v9rl6                            1/1       NodeLost   0          27m       <IP_ADDRESS>   k8s2
23:54:23  	 kube-system   cilium-z5kwm                            0/1       Running    6          26m       <IP_ADDRESS>   k8s1
23:54:23  	 kube-system   etcd-k8s1                               1/1       Running    0          41m       <IP_ADDRESS>   k8s1
23:54:23  	 kube-system   etcd-operator-65476dd78f-2c8zz          1/1       Unknown    0          35m       <IP_ADDRESS>     k8s2
23:54:23  	 kube-system   kube-apiserver-k8s1                     1/1       Running    0          41m       <IP_ADDRESS>   k8s1
23:54:23  	 kube-system   kube-controller-manager-k8s1            1/1       Running    0          41m       <IP_ADDRESS>   k8s1
23:54:23  	 kube-system   kube-dns-f4d788bb7-rw7xm                3/3       Unknown    0          42m       <IP_ADDRESS>     k8s2
23:54:23  	 kube-system   kube-proxy-6b7zk                        1/1       Running    0          42m       <IP_ADDRESS>   k8s1
23:54:23  	 kube-system   kube-proxy-7wr62                        1/1       NodeLost   0          36m       <IP_ADDRESS>   k8s2
23:54:23  	 kube-system   kube-scheduler-k8s1                     1/1       Running    0          41m       <IP_ADDRESS>   k8s1

shows k8s2 as completely lost. I'm not sure what to make of this, and the only logs available are test-specific (nothing for cilium-v9rl6 or for kubelet).

Failed on https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/12211/execution/node/132/log/:
===================== TEST FAILED =====================
cmd: kubectl get pods -o wide --all-namespaces
Exitcode: 0
Stdout:
 	 NAMESPACE     NAME                                    READY     STATUS    RESTARTS   AGE       IP              NODE
	 default       app1-6f5f7bd649-4m944                   0/1       Running   0          3m        <IP_ADDRESS>     k8s1
	 default       app1-6f5f7bd649-8pnr4                   0/1       Running   0          3m        <IP_ADDRESS>      k8s1
	 default       app2-5c44ff87c-t9gcs                    1/1       Running   0          3m        <IP_ADDRESS>     k8s1
	 default       app3-579cbb5fcd-q8b7v                   1/1       Running   0          3m        <IP_ADDRESS>     k8s1
	 default       migrate-svc-client-7zht2                1/1       Running   0          3m        <IP_ADDRESS>     k8s2
	 default       migrate-svc-client-dvn82                1/1       Running   0          3m        <IP_ADDRESS>     k8s2
	 default       migrate-svc-client-tshpn                1/1       Running   0          3m        <IP_ADDRESS>      k8s2
	 default       migrate-svc-client-v7d6j                1/1       Running   0          3m        <IP_ADDRESS>      k8s1
	 default       migrate-svc-client-zzthh                1/1       Running   0          3m        <IP_ADDRESS>     k8s1
	 default       migrate-svc-server-7c2zv                1/1       Running   0          3m        <IP_ADDRESS>     k8s2
	 default       migrate-svc-server-d76hw                1/1       Running   0          3m        <IP_ADDRESS>      k8s1
	 default       migrate-svc-server-rx2xw                1/1       Running   0          3m        <IP_ADDRESS>      k8s2
	 kube-system   cilium-cl4ws                            1/1       Running   0          49s       <IP_ADDRESS>   k8s1
	 kube-system   cilium-etcd-mnbb98rjbf                  1/1       Running   0          4m        <IP_ADDRESS>     k8s1
	 kube-system   cilium-etcd-operator-77d4ddf8c6-595r7   1/1       Running   0          4m        <IP_ADDRESS>   k8s2
	 kube-system   cilium-etcd-qcjkndw7mk                  1/1       Running   0          3m        <IP_ADDRESS>     k8s2
	 kube-system   cilium-etcd-vm2wzkklc7                  1/1       Running   0          4m        <IP_ADDRESS>      k8s2
	 kube-system   cilium-n8d6f                            1/1       Running   0          49s       <IP_ADDRESS>   k8s2
	 kube-system   cilium-operator-5fb956fc65-ppntk        1/1       Running   0          1m        <IP_ADDRESS>     k8s1
	 kube-system   etcd-k8s1                               1/1       Running   0          27m       <IP_ADDRESS>   k8s1
	 kube-system   etcd-operator-65476dd78f-s9lmd          1/1       Running   0          4m        <IP_ADDRESS>      k8s2
	 kube-system   kube-apiserver-k8s1                     1/1       Running   0          27m       <IP_ADDRESS>   k8s1
	 kube-system   kube-controller-manager-k8s1            1/1       Running   0          27m       <IP_ADDRESS>   k8s1
	 kube-system   kube-dns-f4d788bb7-xjjmg                3/3       Running   0          4m        <IP_ADDRESS>      k8s2
	 kube-system   kube-proxy-v4xwj                        1/1       Running   0          28m       <IP_ADDRESS>   k8s1
	 kube-system   kube-proxy-z8c7z                        1/1       Running   0          19m       <IP_ADDRESS>   k8s2
	 kube-system   kube-scheduler-k8s1                     1/1       Running   0          27m       <IP_ADDRESS>   k8s1

@aanm Do you know what is the significance of pod listing READY column reporting "0/1"? Apparently the cilium state for these endpoint is "ready" and the test is happy to proceed, but then fails. I.e., we wait for the cilium endpoint list to show "ready", but not for the k8s pod READY to be "n/n".

@aanm Do you know what is the significance of pod listing READY column reporting "0/1"? Apparently the cilium state for these endpoint is "ready" and the test is happy to proceed, but then fails. I.e., we wait for the cilium endpoint list to show "ready", but not for the k8s pod READY to be "n/n".

@jrajahalme ebc77ece30c8c73cc15cae374e20695322da5448

#12548 had same failure, same symptom as in description. coreDNS was in crashloop backoff with these logs:
2020-07-28T19:04:49.845705843Z .:53
2020-07-28T19:04:49.845742463Z 2020/07/28 19:04:49 [INFO] CoreDNS-1.2.2
2020-07-28T19:04:49.845746522Z 2020/07/28 19:04:49 [INFO] linux/amd64, go1.11, eb51e8b
2020-07-28T19:04:49.845749987Z CoreDNS-1.2.2
2020-07-28T19:04:49.845753393Z linux/amd64, go1.11, eb51e8b
2020-07-28T19:04:49.845756755Z 2020/07/28 19:04:49 [INFO] plugin/reload: Running configuration MD5 = ffcc993a37738c0d6dd423fdb6ad81b0
2020-07-28T19:04:56.028383249Z <IP_ADDRESS>:48566 - [28/Jul/2020:19:04:56 +0000] 59749 "A IN app1-service.default.svc.cluster.local. udp 80 false 4096" NOERROR qr,aa,rd,ra 134 0.000136696s
2020-07-28T19:04:56.453196361Z <IP_ADDRESS>:54759 - [28/Jul/2020:19:04:56 +0000] 2004 "A IN app1-service.default.svc.cluster.local. udp 80 false 4096" NOERROR qr,rd,ra 134 0.000084368s
2020-07-28T19:04:56.848148387Z 2020/07/28 19:04:56 [FATAL] plugin/loop: Seen "HINFO IN<PHONE_NUMBER>600304678.7082390303545810211." more than twice, loop detected


[BUG] Intermittent VM IP Address Disappearance in Harvester v1.3.2

Intermittent VM IP Address Disappearance in Harvester v1.3.2
Environment

Harvester version: v1.3.2
VM OS: Ubuntu 24.04
qemu-guest-agent version: 1:8.2.2+ds-0ubuntu1.4 amd64

Issue Description
IP addresses of virtual machines frequently disappear and reappear ("blink") in the web interface and kubectl get vmi output. This issue started after upgrading to Harvester v1.3.2.
Network Configuration
Network for VMs:
apiVersion: k8s.cni.cncf.io/v1
kind: NetworkAttachmentDefinition
metadata:
  name: devops-test-stand
  namespace: default
  annotations:
    network.harvesterhci.io/route: >-
      {"mode":"manual","cidr":"<IP_ADDRESS>/24","gateway":"<IP_ADDRESS>","connectivity":"true"}
  labels:
    network.harvesterhci.io/clusternetwork: mgmt
    network.harvesterhci.io/type: L2VlanNetwork
    network.harvesterhci.io/vlan-id: '255'
spec:
  config: >-
    {"cniVersion":"0.3.1","name":"devops-test-stand","type":"bridge","bridge":"mgmt-br","promiscMode":true,"vlan":255,"ipam":{}}

VM netplan configuration:
network:
  version: 2
  ethernets:
    enp1s0:
      addresses:
      - "<IP_ADDRESS>/24"
      nameservers:
        addresses:
        - <IP_ADDRESS>
      dhcp4: false
      dhcp6: false
      routes:
      - to: "<IP_ADDRESS>/0"
        via: "<IP_ADDRESS>"
      link-local: []

VM Configuration
apiVersion: kubevirt.io/v1
kind: VirtualMachine
metadata:
  annotations:
    field.cattle.io/description: mrudakov on devops test stand network
    harvesterhci.io/reservedMemory: 100Mi
    harvesterhci.io/vmRunStrategy: RerunOnFailure
    harvesterhci.io/volumeClaimTemplates: >-
      [{"metadata":{"name":"mrudakov-disk-0-rqjm9","annotations":{"harvesterhci.io/imageId":"default/ubuntu24-devops-test-stand-storageclass"}},"spec":{"accessModes":["ReadWriteMany"],"resources":{"requests":{"storage":"30Gi"}},"volumeMode":"Block","storageClassName":"longhorn-ubuntu24-devops-test-stand-storageclass"}}]
    kubevirt.io/latest-observed-api-version: v1
    kubevirt.io/storage-observed-api-version: v1
    network.harvesterhci.io/ips: '[]'
  creationTimestamp: '2024-11-14T12:28:34Z'
  finalizers:
    - kubevirt.io/virtualMachineControllerFinalize
    - harvesterhci.io/VMController.UnsetOwnerOfPVCs
  generation: 3
  labels:
    harvesterhci.io/creator: harvester
    harvesterhci.io/os: linux
    harvesterhci.io/vmName: mrudakov
    tag.harvesterhci.io/environment: devops-test-stand
    tag.harvesterhci.io/service_type: mrudakov
  name: mrudakov
  namespace: default
  resourceVersion: '90163624'
  uid: adfeaad6-1dff-4c0a-b35d-7d4b58597f4a
spec:
  runStrategy: RerunOnFailure
  template:
    metadata:
      annotations:
        harvesterhci.io/sshNames: '[]'
        harvesterhci.io/waitForLeaseInterfaceNames: '["default"]'
      labels:
        harvesterhci.io/creator: terraform-provider-harvester
        harvesterhci.io/vmName: mrudakov
        tag.harvesterhci.io/environment: devops-test-stand
        tag.harvesterhci.io/service_type: mrudakov
    spec:
      affinity:
        nodeAffinity:
          requiredDuringSchedulingIgnoredDuringExecution:
            nodeSelectorTerms:
              - matchExpressions:
                  - key: network.harvesterhci.io/mgmt
                    operator: In
                    values:
                      - 'true'
        podAntiAffinity:
          preferredDuringSchedulingIgnoredDuringExecution:
            - podAffinityTerm:
                labelSelector:
                  matchExpressions:
                    - key: harvesterhci.io/creator
                      operator: Exists
                topologyKey: kubernetes.io/hostname
              weight: 100
      architecture: amd64
      domain:
        cpu:
          cores: 2
        devices:
          disks:
            - bootOrder: 1
              disk:
                bus: scsi
              name: disk-0
            - disk:
                bus: virtio
              name: cloudinitdisk
          interfaces:
            - bridge: {}
              macAddress: ...
              model: virtio
              name: default
        features:
          acpi: {}
          smm:
            enabled: true
        firmware:
          bootloader:
            efi:
              secureBoot: true
        machine:
          type: q35
        memory:
          guest: 3996Mi
        resources:
          limits:
            cpu: '2'
            memory: 4Gi
          requests:
            cpu: 125m
            memory: 2730Mi
      evictionStrategy: LiveMigrate
      hostname: mrudakov
      networks:
        - multus:
            networkName: default/devops-test-stand
          name: default
      terminationGracePeriodSeconds: 120
      volumes:
        - name: disk-0
          persistentVolumeClaim:
            claimName: mrudakov-disk-0-rqjm9
        - cloudInitNoCloud:
            networkDataSecretRef:
              name: default-cloudinit-ubuntu24-04
            secretRef:
              name: default-cloudinit-ubuntu24-04
          name: cloudinitdisk

Additional Information

No errors observed in qemu-guest-agent operation
Problem appeared after updating to Harvester v1.3.2
IP addresses consistently "blink" (disappear and reappear)
Harvester can still ping the gateway of this network

Steps to Reproduce

Set up Harvester v1.3.2 cluster
Create VMs with Ubuntu 24.04 and configure networking as shown above
Observe web interface and kubectl get vmi output over time

Expected Behavior
VM IP addresses should consistently appear in the web interface and kubectl get vmi output.
Impact
This issue affects the stability and manageability of our virtual machine environment, potentially disrupting services and complicating network-related operations.

could be related:

https://github.com/harvester/harvester/issues/3990#top
https://github.com/harvester/harvester/issues/5251#top

cc @starbops @rrajendran17

@bk201 Yes  same issue as
https://github.com/harvester/harvester/issues/5251
https://github.com/harvester/harvester/issues/3990
except that those were seen and we were able to reproduce locally only with alma-linux and rocky linux 9.
we were never able to reproduce this with ubuntu guest os while this issue mentions about ubuntu guest os.
I can try with ubuntu 24.04 once locally.
To note: We started observing this issue particularly after upgrade to v1.3.1 or v1.3.2 where we moved to newer kubevirt versions v1.1.1, v1.2.2.
From my observation, this happens whenever there are frequent updates from qemu-ga on any of the guest commands polled from virt-launcher.This is seen with alma-linux because there are frequent change in the information shared
from qemu-ga of alma-linux especially guest-get-fsinfo which is not happening with other images like ubuntu, opensuse etc.I believe we will see "ip disappearing issue" on any vm running guest os which will have frequent updates from qemu-ga to the virt-launcher during the polling thread.
Kubevirt tracking issue: https://github.com/kubevirt/kubevirt/issues/12698

I'm starting to see the same issue on Ubuntu machines. The VMs hold the IP addresses, but the IP addresses disappear in the VMI objects and the UI dashboard.

All of them are running the Ubuntu 22.04.5 LTS cloud image downloaded from https://cloud-images.ubuntu.com/jammy/current/jammy-server-cloudimg-amd64.img
Some information:

Harvester version: v1.3.2
KubeVirt version: v1.1.1
Ubuntu version: 22.04.5
QEMU guest agent version: 6.2.0

Solution to IP Address Blinking Issue
Hello,
We have conducted further investigation into the issue of periodically disappearing IP addresses of virtual machines and have discovered the root cause of this behavior.
Solution
The problem is resolved by ensuring consistency in the network interface naming across all relevant configurations. Specifically, the following elements need to have identical names (in our case, "enp1s0"):

The network interface name inside the virtual machine
The value in the harvesterhci.io/waitForLeaseInterfaceNames annotation
The name in the virtual machine's network configuration

Example of Correct Configuration

Interface inside VM: enp1s0
Annotation: harvesterhci.io/waitForLeaseInterfaceNames: '["enp1s0"]'
VM network configuration:networks:
  - multus:
      networkName: default/devops-test-stand
    name: enp1s0

Result
After applying these changes, the issue with disappearing IP addresses has been resolved.
Follow-up Plan
We plan to monitor this solution for another week to ensure its long-term effectiveness. We will return with additional feedback after this observation period.

Solution to IP Address Blinking Issue
Hello,
We have conducted further investigation into the issue of periodically disappearing IP addresses of virtual machines and have discovered the root cause of this behavior.
Solution
The problem is resolved by ensuring consistency in the network interface naming across all relevant configurations. Specifically, the following elements need to have identical names (in our case, "enp1s0"):

The network interface name inside the virtual machine
The value in the harvesterhci.io/waitForLeaseInterfaceNames annotation
The name in the virtual machine's network configuration

Example of Correct Configuration

Interface inside VM: enp1s0
Annotation: harvesterhci.io/waitForLeaseInterfaceNames: '["enp1s0"]'
VM network configuration:networks:
  - multus:
      networkName: default/devops-test-stand
    name: enp1s0

Result
After applying these changes, the issue with disappearing IP addresses has been resolved.
Follow-up Plan
We plan to monitor this solution for another week to ensure its long-term effectiveness. We will return with additional feedback after this observation period.

It worked for me, thx @MaksimRudakov !

Thanks @MaksimRudakov for the workaround.

@MaksimRudakov I do not think this issue is specific to interface or interface naming as we lose guestosInfo also in the vmi status along with interface information.
I am not able to reproduce the issue with ubuntu 24.04 with v1.3.2 Harvester version while on the same node I was able to reproduce the issue with rocky linux 9.
I have some possible working fix for the issue tested in issue state for rocky linux 9, will submit a PR to kubevirt.

Hi!
We tested this issue after upgrading to Harvester v1.4 with Rocky Linux 9 VMs. We maintained consistency in network interface naming as described in the previous solution, and we have not observed the IP blinking issue occurring.
Test setup:

Harvester version: v1.4
Guest OS: Rocky Linux 9
Network interface names kept consistent across VM config, annotations and guest OS

We'll continue monitoring and update if any issues arise.

Hello. I think the problem can be closed; in combine 1.4 there were no problems with blinking IP addresses.


Certain endpoints not visible in swagger BUT are fully functional

The endpoints are not visible in swagger but they still work and I can do CRUD requests to those endpoints. I'm using an GenericViewset and it seems that the cause is the queryset sending a get_object_or_404 object to the filter query.
serializer_class = CustomerCommunicationSerializer
def get_queryset(self):
customer = get_object_or_404(Customer, pk=self.kwargs.get("customer_pk"))
return CustomerCommunication.objects.filter(customer=customer)
Changing the code above to the code below causes the endpoints to show up in swagger
serializer_class = CustomerCommunicationSerializer
queryset = CustomerCommunication.objects.all()

I haven't quite got my head around exactly how this works, but DRF somehow builds a schema based on whether it can invoke endpoints or not, and this is the schema that django-rest-swagger displays.
I guess what's happening here is:

get_queryset gets called during the building of this schema;
self.kwargs.get("customer_pk") returns None (or some other value which isn't a customer primary key); and
get_object_or_404 returns a 404 error

You probably just want to have the following:
def get_queryset(self):
    return CustomerCommunication.objects.filter(customer_id= self.kwargs.get("customer_pk"))

I'm pretty sure this isn't an issue in django-rest-swagger through.

I've already tried that but it returns an empty list when the customer does not exist which is not what I want. I implemented the list method to get the desired results but the code is not nearly as sexy.


add contracts for [mr] mutable references

If we are asking for a mutable references, we are not expecting NULL.
Add a contract(eventually an assert as well) to avoid NULLs being passed in.

[ ] pre-condition
[ ] assert

also, pre-conditions can be implemented as guard clauses

this is specific to C and languages that don't have references


fix(item): fix color input for item divider and list header

adds ItemDivider class to add color and mode css classes to item
divider
adds e2e test for item divider colors
adds sass variables to improve control over list headers and item
divider styles
fixes style for item divider so it will be styled regardless of being
inside a list for md and wp modes
item divider and list header now get their own classes for colors
change the default text color and background color to match the theme
variables. This makes popover look better on dark theme and removes the
nesting of styles that breaks list headers.

Snapshot for these changes: http://ionic-snapshot-go.appspot.com/ionic2/snapshots/tt8/v2m/chrome_400x800
e2e test added to snapshot for item divider: http://ionic-snapshot-go.appspot.com/ionic2/snapshots/v2m/chrome_400x800#41fcb91b
fixes #8376

@brandyscarney the latest nightly build fixed the issue. However, when I try to apply global SCSS overrides for the button color and the text color, they are not being applied anymore
// Navbar custom styles
// --------------------------------------------------
$toolbar-ios-button-color:   #31C0E6;
$toolbar-md-button-color:  #31C0E6;
$toolbar-wp-button-color:   #31C0E6;
$toolbar-ios-title-text-color: #fff;
$toolbar-md-title-text-color:#fff;
$toolbar-wp-title-text-color: #fff;

Hey @gigocabrera. :) I'm not able to reproduce that using the conference app. Are you applying color to the button? If you have a color on the button it won't take the default. Otherwise, could you create an issue with the markup you are using so I can reproduce it? Thanks!

@brandyscarney my bad. This works as expected. I was looking at the wrong thing :stuck_out_tongue_winking_eye:


Update json tags on structs and add json tags to Payment Intents structs and bumb version

In order to keep up with our changes to the source code, several changes needed to be made to existing structs, as well as consume ongoing changes from Stripe. We also had to incorporate the Payment Intents portion of the api to ours, and in turn add the json tags to those structs. Also, we bumped our version number to the current 63.2.1-omni.1.

I'm just gonna go ahead and trust that you did this merge cleanly, rather than audit all 221 of those commits.
I did read the actual difference from Stripe's upstream, and it looks reasonable.


chore(README): Remove official contact options

Hello! Clerk employee here 👋
Thank you for working on this!
Currently the README can give the impression to users that they can expect official support in Discord and through our support platform. As we don't offer that for community SDKs I'm removing said portions from the README so that it's clearer.
Hope that makes sense! Cheers 😊

Understandable!