[Doc Feature][Update shared channels]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/app-fundamentals-overview.md
97
5
link
:white_check_mark:

msteams-platform/concepts/build-and-test/Shared-channels.md
78
11
link
:white_check_mark:

msteams-platform/tabs/how-to/access-teams-context.md
90
23
link
:white_check_mark:

msteams-platform/tabs/what-are-tabs.md
91
9
link
:white_check_mark:

msteams-platform/whats-new.md
91
34
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 96418a4:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/whats-new.md
:warning:Warning
View
Details

msteams-platform/concepts/deploy-and-publish/apps-publish-overview.md
:warning:Warning
View
Details

msteams-platform/mstdd-landing.yml
:warning:Warning
View
Details

msteams-platform/assets/images/app-fundamentals/shared-channels.png
:white_check_mark:Succeeded
View

msteams-platform/concepts/app-fundamentals-overview.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/build-and-test/Shared-channels.md
:white_check_mark:Succeeded
View

msteams-platform/tabs/how-to/access-teams-context.md
:white_check_mark:Succeeded
View

msteams-platform/tabs/what-are-tabs.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md

Line 22, Column 80: [Warning: bookmark-not-found] Cannot find bookmark '#government-community-cloud' in 'concepts/app-fundamentals-overview.md'.
Line 80, Column 76: [Warning: bookmark-not-found] Cannot find bookmark '#government-community-cloud' in 'concepts/app-fundamentals-overview.md'.
Line 231, Column 71: [Warning: bookmark-not-found] Cannot find bookmark '#retrieve-context-in-private-channels' in 'tabs/how-to/access-teams-context.md'.

msteams-platform/concepts/deploy-and-publish/apps-publish-overview.md

Line 40, Column 227: [Warning: bookmark-not-found] Cannot find bookmark '#government-community-cloud' in 'concepts/app-fundamentals-overview.md'.

msteams-platform/mstdd-landing.yml

Line 64, Column 14: [Warning: bookmark-not-found] Cannot find bookmark '#government-community-cloud' in 'concepts/app-fundamentals-overview.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/app-fundamentals-overview.md
97
5
link
:white_check_mark:

msteams-platform/concepts/build-and-test/Shared-channels.md
78
11
link
:white_check_mark:

msteams-platform/tabs/how-to/access-teams-context.md
90
23
link
:white_check_mark:

msteams-platform/tabs/what-are-tabs.md
91
9
link
:white_check_mark:

msteams-platform/whats-new.md
91
34
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit cb79318:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/whats-new.md
:warning:Warning
View
Details

msteams-platform/assets/images/app-fundamentals/shared-channels.png
:white_check_mark:Succeeded
View

msteams-platform/concepts/app-fundamentals-overview.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/build-and-test/Shared-channels.md
:white_check_mark:Succeeded
View

msteams-platform/tabs/how-to/access-teams-context.md
:white_check_mark:Succeeded
View

msteams-platform/tabs/what-are-tabs.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md

Line 231, Column 71: [Warning: bookmark-not-found] Cannot find bookmark '#retrieve-context-in-private-channels' in 'tabs/how-to/access-teams-context.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/app-fundamentals-overview.md
97
5
link
:white_check_mark:

msteams-platform/concepts/build-and-test/Shared-channels.md
83
9
link
:white_check_mark:

msteams-platform/tabs/how-to/access-teams-context.md
90
23
link
:white_check_mark:

msteams-platform/tabs/what-are-tabs.md
91
9
link
:white_check_mark:

msteams-platform/whats-new.md
91
34
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/app-fundamentals-overview.md
97
5
link
:white_check_mark:

msteams-platform/concepts/build-and-test/Shared-channels.md
83
9
link
:white_check_mark:

msteams-platform/tabs/how-to/access-teams-context.md
90
23
link
:white_check_mark:

msteams-platform/tabs/what-are-tabs.md
91
9
link
:white_check_mark:

msteams-platform/whats-new.md
91
34
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 4674f05:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/app-fundamentals/shared-channels.png
:white_check_mark:Succeeded
View

msteams-platform/concepts/app-fundamentals-overview.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/build-and-test/Shared-channels.md
:white_check_mark:Succeeded
View

msteams-platform/tabs/how-to/access-teams-context.md
:white_check_mark:Succeeded
View

msteams-platform/tabs/what-are-tabs.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Duplicate of PR #3828

Docs Build status updates of commit c48f877:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/app-fundamentals/shared-channels.png
:white_check_mark:Succeeded
View

msteams-platform/concepts/app-fundamentals-overview.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/build-and-test/Shared-channels.md
:white_check_mark:Succeeded
View

msteams-platform/tabs/how-to/access-teams-context.md
:white_check_mark:Succeeded
View

msteams-platform/tabs/what-are-tabs.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/app-fundamentals-overview.md
93
9
link
:white_check_mark:

msteams-platform/concepts/build-and-test/Shared-channels.md
83
9
link
:white_check_mark:

msteams-platform/tabs/how-to/access-teams-context.md
89
36
link
:white_check_mark:

msteams-platform/tabs/what-are-tabs.md
89
10
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

approved

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/app-fundamentals-overview.md
93
9
link
:white_check_mark:

msteams-platform/concepts/build-and-test/Shared-channels.md
83
9
link
:white_check_mark:

msteams-platform/tabs/how-to/access-teams-context.md
89
36
link
:white_check_mark:

msteams-platform/tabs/what-are-tabs.md
89
10
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit c11cd98:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/app-fundamentals/shared-channels.png
:white_check_mark:Succeeded
View

msteams-platform/concepts/app-fundamentals-overview.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/build-and-test/Shared-channels.md
:white_check_mark:Succeeded
View

msteams-platform/tabs/how-to/access-teams-context.md
:white_check_mark:Succeeded
View

msteams-platform/tabs/what-are-tabs.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

The content has been merged with PR #6502


Install/Update 'dep'

We need to install dep to manage vendors.

Updated with a fixed dep version and OS detection between linux and darwin.
Also separated in prepare so it's not executed on the all if not needed.

that's great!


Unit tests are needed

Looking for some extra help to cover this library with some xunit tests.

Added in aa77e92c12e117808631b8df1cfbecd60e153bf5


Update Wix Toolset repo

Sorry if this is not the right place to request this. On https://www.dnfprojects.com, The WiX Toolset repo is currently set to https://github.com/wixtoolset/Core, which was one of many micro repos that got consolidated back to a mono-repo last year. The active repo is https://github.com/wixtoolset/wix4, so it would be great if the website could be updated to use that repo instead. Thanks.

Apologies, I just noticed this issue now. The Url has now been updated.


Support Kubernetes extended resources for Kubernetes components

Which area this feature is related to?
/area api
Which functionality do you think we should add?
Why is this needed? Is your feature request related to a problem?
https://github.com/devfile/api/issues/920 has introduced the ability to allow specifying request/limits for resources other than memory and CPU. However, the function is specific to the container component.
Detailed description:
In some cases, the user may want to do a similar override on the Kubernetes components. One concrete use case is that App Studio is currently having custom attributes to do those overrides which can be configured as part of the App Studio UI. App Studio is currently using its own custom attributes to achieve the override (see https://github.com/devfile-samples/devfile-sample-python-basic/blob/main/devfile.yaml for an example).
This item is to propose using the syntax of the same attribute to achieve override on the Kubernetes component.
Describe the solution you'd like
Similar syntax of the override settings on the Kubernetes components. (detailed proposal will follow)
Describe alternatives you've considered
Using the tool's specific attributes that are unique to a particular tool makes it less portable to another environment that we are trying to fix.

This item is to propose using the syntax of the same attribute to achieve override on the Kubernetes component.

It is kubernetes component, so all those things can be defined in the Kubernetes file itself.
Why would anyone need to override this in the devfile?


× in HTML displayed as Ã— in prod build instead of 'X'

× in HTML displayed as Ã— in prod build instead of 'x'.
This is working fine in Dev build.
PFB screenshot:

Can you help in resolving this?
Am using  "@angular/cli": "1.3.0-beta.0",
Thanks,
Hari

Even   in the HTML code changes to Â  in --prod build.
I have the following charset in my index.html:
   <meta charset="utf-8">

Any help?

Hi,
The issue was with UTF-8 encoding. Added the following configuration in spring boot to resolve the issue:
spring.messages.encoding=UTF-8
server.tomcat.uri-encoding=UTF-8
spring.http.encoding.charset=UTF-8
spring.http.encoding.enabled=true
spring.http.encoding.force=true
Reference: http://netkiller.github.io/java/spring/boot/application.properties.html#charset
Thanks,
Hari

Closing then.

@harikrishnan-u01  Thanks for saving my time 👍


Fn::If condition not handled properly in the body of any property of any resource

Describe the bug
In case there is an !If clause in the body of the property of any Cloudformation resource, Kombustion transforms the template in such a way that null values are assigned to properties instead. Below is an example of how VersioningConfiguration in the S3 bucket resource AWS::S3::Bucket properties is handled improperly when the !If condition is employed in the body of its definition, producing a null as the value of the VersioningConfiguration.
To Reproduce
given this template in cf/alb-access-logs-s3.yaml
AWSTemplateFormatVersion: "2010-09-09"
Description: "Access logs S3 Bucket"
Parameters:
  AccessControl:
    Type: String
    Description: The canned access control list (ACL) that grants predefined
      permissions to the bucket.
    Default: ""
  BucketEncryption:
    Type: String
    Description: Whether server-side bucket encryption is on by default
    Default: "aws:kms"
    AllowedValues:
      - "false"
      - "aws:kms"
      - "AES256"
  BucketName:
    Type: String
    Description: Bucket Name (optional). If not provided CloudFormaiton will
      generate one
    Default: ""
  DenyInSecureQueries:
    Type: String
    Description: Whether to deny insecure requests to S3 bucket
    Default: "true"
    AllowedValues:
      - "true"
      - "false"
  GlacierTransition:
    Type: String
    Description: Glacier transitioning in days, leave blank for no transition
    Default: ""
  StandardIATransition:
    Type: String
    Description: Transitioning to standard IA in days, leave blank for no
      transition
    Default: ""
  VersioningConfiguration:
    Type: String
    Description: Enable versioning to prevent objects from being deleted or
      overwritten by mistake.
    Default: ""
  LoggingBucket:
    Type: String
    Description: Amazon S3 bucket where Amazon S3 store server access log files
    Default: ""
  LoggingPrefix:
    Type: String
    Description: prefix for the all log object keys in the S3 logging bucket
    Default: ""

Conditions:
  AccessControlIsDefined: !Not [ !Equals [ "", !Ref AccessControl ] ]
  BucketEncryptionIsOn: !Not [ !Equals [ "false", !Ref BucketEncryption ] ]
  BucketNameIsDefined: !Not [ !Equals [ "", !Ref BucketName ] ]
  GlacierTransitionIsDefined: !Not [ !Equals [ "", !Ref GlacierTransition ] ]
  StandardIATransitionIsDefined: !Not [ !Equals [ "", !Ref StandardIATransition ] ]
  VersioningConfigurationIsDefined: !Not [ !Equals [ "", !Ref VersioningConfiguration ] ]
  LifecycleConfigurationIsDefined: !Or
    - !Condition GlacierTransitionIsDefined
    - !Condition StandardIATransitionIsDefined
  LoggingBucketIsDefined:  !Not [ !Equals [ "", !Ref LoggingBucket ] ]
  LoggingPrefixIsDefined:  !Not [ !Equals [ "", !Ref LoggingPrefix ] ]
  SecureTransportOnly: !And
    - !Condition BucketEncryptionIsOn
    - !Not [ !Equals [ "false", !Ref DenyInSecureQueries ] ]

Resources:
  S3Bucket:
    Type: "AWS::S3::Bucket"
    Properties:
      BucketName: !If
        - BucketNameIsDefined
        - !Ref BucketName
        - !Ref AWS::NoValue
      AccessControl: !If
        - AccessControlIsDefined
        - !Ref AccessControl
        - !Ref AWS::NoValue
      LifecycleConfiguration:
        Rules: !If
          - LifecycleConfigurationIsDefined
          -
            - Id: Archive to Glacier/StandardIA
              Prefix: ''
              Status: Enabled
              Transitions:
                - !If
                  - StandardIATransitionIsDefined
                  - StorageClass: STANDARD_IA
                    TransitionInDays: !Ref StandardIATransition
                  - !Ref AWS::NoValue
                - !If
                  - GlacierTransitionIsDefined
                  - StorageClass: GLACIER
                    TransitionInDays: !Ref GlacierTransition
                  - !Ref AWS::NoValue
          - !Ref AWS::NoValue
      VersioningConfiguration: !If
        - VersioningConfigurationIsDefined
        - Status: !Ref VersioningConfiguration
        - !Ref AWS::NoValue
      LoggingConfiguration: !If
        - LoggingBucketIsDefined
        - DestinationBucketName: !Ref LoggingBucket
          LogFilePrefix: !If
            - LoggingPrefixIsDefined
            - !Ref LoggingPrefix
            - !Ref AWS::NoValue
        - !Ref AWS::NoValue
      BucketEncryption:
        ServerSideEncryptionConfiguration: !If
          - BucketEncryptionIsOn
          -
            - ServerSideEncryptionByDefault:
                SSEAlgorithm: !Ref BucketEncryption
          - !Ref AWS::NoValue
      Tags: !If
        - BucketNameIsDefined
        -
          - Key: "Name"
            Value: !Ref BucketName
        - !Ref AWS::NoValue

  S3BucketPolicy:
    DependsOn: S3Bucket
    Type: "AWS::S3::BucketPolicy"
    Properties:
      Bucket: !Ref S3Bucket
      PolicyDocument:
        Statement:
          - !If
            - SecureTransportOnly
            - Action: s3:*
              Condition:
                Bool:
                  aws:SecureTransport: 'false'
              Effect: Deny
              Principal: '*'
              Resource: !Sub "arn:aws:s3:::${S3Bucket}/*"
            - !Ref AWS::NoValue
          - Action: s3:PutObject
            Effect: Allow
            Principal:
              AWS: arn:aws:iam::783225319266:root
            Resource:
              - !Sub "arn:aws:s3:::${S3Bucket}/AWSLogs/*"

Outputs:
  S3Bucket:
    Value: !Ref S3Bucket
    Export:
      Name: !Sub "${AWS::StackName}::S3Bucket"

  S3BucketPolicy:
    Value: !Ref S3BucketPolicy
    Export:
      Name: !Sub "${AWS::StackName}::S3BucketPolicy"

and the parameters in params/nonprod.yaml
Name: ""
Region: "ap-southeast-2"
Environments:
  phoenix:
    AccountIDs:
    - "111111111111"
    Parameters:
      BucketEncryption: "AES256"
      GlacierTransition: "60"
      StandardIATransition: "30"
      DenyInSecureQueries: "true"

The command
kombustion --manifest-file params/nonprod.yaml generate cf/alb-access-logs-s3.yaml --stack-name msp-phoenix-s3-access-logs --environment phoenix --param BucketName=msp-phoenix-s3-access-logs

produces a resulting template with the
        VersioningConfiguration:
        Status: null

the bit that gets transformed into it is
      VersioningConfiguration: !If
        - VersioningConfigurationIsDefined
        - Status: !Ref VersioningConfiguration
        - !Ref AWS::NoValue

Replacing shorthand intrinsics with the Fn::If etc does not resolve the issue. Only if the !If case is completely removed the resulting template is as expected.
Expected behavior
Should not produce null
Screenshots
None
Desktop (please complete the following information):

OS: OS X Mojave 10.14.1
Browser N/A
Version v0.4.4.

Just to add, we need more test coverage in this area.

So this works when the if is on status directly.
      VersioningConfiguration:
        Status: !If
          - VersioningConfigurationIsDefined
          - !Ref VersioningConfiguration
          - !Ref AWS::NoValue

transforms to
      VersioningConfiguration:
        Status:
          Fn::If:
            - VersioningConfigurationIsDefined
            - Ref: VersioningConfiguration
            - Ref: AWS::NoValue

Does the aws cli handle the case in the OP?
Looking through the generated parsers, I dont know if we could support the example in the OP.

So this issue boiled down to the typing in kombustion's parsers. Once upon a time, that typing and validation was great. But since CloudFormation macros, we really cannot do any validation (outside user plugins), and need to let CloudFormation validate the template.
I've got a PR that removes all the strong typing for resources and properties in parsers, which fixes this and a few other bugs.


[sw/silicon_creator] typo in rnd_functest

Description
I noticed that //sw/device/silicon_creator/lib/drivers:rnd_functest_fpga_cw310_rom failed in the last two runs of my local coverage pipeline. I noticed the following typo in the test:
https://github.com/lowRISC/opentitan/blob/d1f1f9c1870eb45792ccffe2c19c2ed6c5950280/sw/device/silicon_creator/lib/drivers/rnd_functest.c#L195
Shouldn't this line use lc_expect_check instead of lc_expect_check_skip?

Hi @alphan, I am looking at this now.

Hi @alphan, I am looking at this now.

Thanks! PLMK if I can help.


Support newlines / paragraphs in table cells

Steps to reproduce:

Have a table cell with 2 paragraphs, e.g.:

|===
| Line 1

Line 2
|===

Render using HTML or PDF.
Publish to Confluence

Expected results:

In HTML and PDF, the sentences are on separate lines.
In Confluence, both of the sentences are also on separate lines.

Actual results:

OK: In HTML and PDF, the sentences are on separate lines.
NOK: In Confluence, both of the sentences are NOT on separate lines, but they are on the same line.

I'd love to get this fixed as its the last blocker for me on a project and I'd love to be able to contribute back to the community.  Anyone happen to have an idea where I could look to try and fix this?

I'm new to Java and Ruby but I think I've located where this could be fixed.  Perhaps in this template?  Anyone know if I'm on the right trail?
https://github.com/confluence-publisher/confluence-publisher/blob/master/asciidoc-confluence-publisher-converter/src/main/resources/org/sahli/asciidoc/confluence/publisher/converter/templates/block_table.html.slim

I'm looking at the last commit that changed the table template and it seems as though the java test with it should catch the problem here but its not and I'm wondering why.
https://github.com/confluence-publisher/confluence-publisher/commit/1a5ace0f680deac8ad3a725fe4d897096dbb32ce

I found a work around! I dug into asciidoc more and found there is an document attribute you can set at the top of your doc that publisher will enforce.
:hardbreaks:
https://asciidoctor.org/docs/asciidoc-writers-guide/#wrapped-text-and-hard-line-breaks
I still think this is a bug with publisher though in that it should be respecting the line breaks without it inside table cells if for nothing other than being consistent with the HTML and PDF output formats.


Add IPMI sensor numbers

Assigned numbers for the sensors.  Also fixed a HWMON and BMC_FRU_ID attribute value.

Reviewed Spinler's changes.


downsample/compact: Compactor is not able to compact downsampled blocks.

All my downsampled blocks errors with
level=error name=thanos-compactor ts=2018-04-11T15:20:38.938782011Z caller=compact.go:163 msg="compaction failed" err="compact blocks [/compactor-data/compact/300000@{cluster=\"alpha-eu-1\",environment=\"alpha\",monitor=\"thanos-coremon\",replica=\"thanos-coremon-1\"}/01CAG1M6HZPC2FH1TC7G0S8BN8 /compactor-data/compact/300000@{cluster=\"alpha-eu-1\",environment=\"alpha\",monitor=\"thanos-coremon\",replica=\"thanos-coremon-1\"}/01CAG396J6WA6XHX7FK6PME88T /compactor-data/compact/300000@{cluster=\"alpha-eu-1\",environment=\"alpha\",monitor=\"thanos-coremon\",replica=\"thanos-coremon-1\"}/01CAG4SVRYR3130MGTFQXHMWWE /compactor-data/compact/300000@{cluster=\"alpha-eu-1\",environment=\"alpha\",monitor=\"thanos-coremon\",replica=\"thanos-coremon-1\"}/01CAG0Y40ERDHMAKTA591B5Y4V]: write compaction: chunk 8 not found: invalid encoding \"<unknown>\""

I think it is as easy as just TSDB compaction having no idea how to read those blocks, because we have no control over blockReader for Compact (we cannot inject our own):
func (c *LeveledCompactor) Compact(dest string, dirs ...string) (uid ulid.ULID, err error) {
	var (
		blocks []BlockReader
		bs     []*Block
		metas  []*BlockMeta
		uids   []string
	)

	for _, d := range dirs {
		b, err := OpenBlock(d, c.chunkPool)
		if err != nil {
			return uid, err
		}
		defer b.Close()

		meta, err := readMetaFile(d)
		if err != nil {
			return uid, err
		}

		metas = append(metas, meta)
		blocks = append(blocks, b)
		bs = append(bs, b)
		uids = append(uids, meta.ULID.String())
	}

	entropy := rand.New(rand.NewSource(time.Now().UnixNano()))
	uid = ulid.MustNew(ulid.Now(), entropy)

	meta := compactBlockMetas(uid, metas...)
	err = c.write(dest, meta, blocks...)
	if err == nil {
		level.Info(c.logger).Log(
			"msg", "compact blocks",
			"count", len(blocks),
			"mint", meta.MinTime,
			"maxt", meta.MaxTime,
			"ulid", meta.ULID,
			"sources", fmt.Sprintf("%v", uids),
		)
		return uid, nil
	}

I feel like it is just a matter of adding an API for TSDB to allow opening special block readers and pass our newMemBlock reader, but it's to late to be sure about anything ^^
Any thoughts @fabxc?

Bartek Płotka [09:56]
Compactor gets chunks by ref and requires encoding which is for TSDB unknown:
func (s *Reader) Chunk(ref uint64) (chunkenc.Chunk, error) {
	var (
		seq = int(ref >> 32)
		off = int((ref << 32) >> 32)
	)
	if seq >= len(s.bs) {
		return nil, errors.Errorf("reference sequence %d out of range", seq)
	}
	b := s.bs[seq]

	if off >= b.Len() {
		return nil, errors.Errorf("offset %d beyond data size %d", off, b.Len())
	}
	// With the minimum chunk length this should never cause us reading
	// over the end of the slice.
	r := b.Range(off, off+binary.MaxVarintLen32)

	l, n := binary.Uvarint(r)
	if n < 0 {
		return nil, fmt.Errorf("reading chunk length failed")
	}
	r = b.Range(off+n, off+n+int(l))

	return s.pool.Get(chunkenc.Encoding(r[0]), r[1:1+l])
}

https://github.com/improbable-eng/thanos/pull/285 Fixes it.

Hi,
I still get these errors on Thanos 0.5.0 on S3 on a couple of compactor processes:
level=error ts=2019-06-14T18:33:54.886404704Z caller=main.go:181 msg="running command failed" err="error executing compaction: first pass of downsampling failed: downsample block 01D5CAVA4S0S9TF9V9WF2JVRNA to window 300000: get chunk<PHONE_NUMBER>29: invalid encoding \"<unknown>\""

I'm also seeing this on 0.7.0. @bwplotka any ideas why it might still be happening?

Seeing what exactly? What are the all components versions?

All thanos components are on 0.7.0.
level=info ts=2019-09-26T22:48:30.642775211Z caller=factory.go:39 msg="loading bucket configuration"
level=info ts=2019-09-26T22:48:32.846934222Z caller=compact.go:236 msg="retention policy of raw samples is enabled" duration=720h0m0s
level=info ts=2019-09-26T22:48:32.846983189Z caller=compact.go:239 msg="retention policy of 5 min aggregated samples is enabled" duration=8760h0m0s
level=info ts=2019-09-26T22:48:32.846995692Z caller=compact.go:242 msg="retention policy of 1 hour aggregated samples is enabled" duration=87600h0m0s
level=info ts=2019-09-26T22:48:32.847009602Z caller=compact.go:326 msg="starting compact node"
level=info ts=2019-09-26T22:48:32.847018949Z caller=prober.go:114 msg="changing probe status" status=ready
level=info ts=2019-09-26T22:48:32.847093161Z caller=main.go:363 msg="listening for metrics" address=<IP_ADDRESS>:10902
level=info ts=2019-09-26T22:48:32.847163577Z caller=prober.go:143 msg="changing probe status" status=healthy
level=info ts=2019-09-26T22:48:32.864676793Z caller=compact.go:1023 msg="start sync of metas"
level=info ts=2019-09-26T22:48:33.532383667Z caller=compact.go:1029 msg="start of GC"
level=info ts=2019-09-26T22:48:33.534161354Z caller=compact.go:1035 msg="start of compaction"
level=info ts=2019-09-26T22:48:33.737835252Z caller=compact.go:249 msg="compaction iterations done"
level=info ts=2019-09-26T22:48:33.737868383Z caller=compact.go:256 msg="start first pass of downsampling"
level=info ts=2019-09-26T22:55:02.63697195Z caller=downsample.go:243 msg="downloaded block" id=01CV08RB890A58KEZ2NFTPFW46 duration=6m26.317719535s
level=info ts=2019-09-26T22:55:28.943321054Z caller=streamed_block_writer.go:219 msg="finalized downsampled block" mint=1540231200000 maxt=1540814400000 ulid=01DNQWJMAJ2DDHV81N089A841Z resolution=300000
level=warn ts=2019-09-26T22:55:28.964872518Z caller=prober.go:154 msg="changing probe status" status=unhealthy reason="error executing compaction: first pass of downsampling failed: downsampling to 5 min: downsample block 01CV08RB890A58KEZ2NFTPFW46 to window 300000: get chunk 93, series 1681895: invalid encoding \"<unknown>\""
level=error ts=2019-09-26T22:55:28.967755041Z caller=main.go:213 msg="running command failed" err="error executing compaction: first pass of downsampling failed: downsampling to 5 min: downsample block 01CV08RB890A58KEZ2NFTPFW46 to window 300000: get chunk 93, series 1681895: invalid encoding \"<unknown>\""

@cassandracomar can you provide the step and I will try to replicate.
If you can't replicate, but still have the block causing this error this will also help if you could sent it privately so I can try to find what is causing the error.

We just used prometheus-operator 0.31.1 to deploy prometheus 2.10.0 with the thanos sidecar at v0.6.0, then deployed the other thanos components with this chart (https://github.com/kiwigrid/helm-charts/tree/master/charts/prometheus-thanos) at v0.6.0 on a brand new cluster and hit the same errors. I can send the block it's complaining about or I can send a script to replicate our setup on a fresh cluster, whatever is easier.

'v0.6.0' - did you mean v0.7.0?  I haven't looked the change logs, but I assume this should be fixed in 0.7.0  so should try and replicate with the 0.7 version right?

I can try again with 0.7.0. Just got a report this morning that it happened with a fresh deploy of 0.6.0.

I see, yeah lets try to replicate with the 0.7.0
I think for me it would be easier to replicate with just the blocks so once you get this error just ping me on slack thanos-dev to send me those blocks and  will try and find the culprit.


"dmr-client validate" report an error when using "humidity" semantic type and "%" unit

The validation of template fails when data in template are using "Humidity" semantic type and "percent" unit.
{             "@id": "dtmi:com:socomec:socomecdevice:Global_0_85894;1",             "@type": [                 "Telemetry",                 "Humidity"             ],             "displayName": {                 "en": "Humidity"             },             "name": "Global_0_85894",             "schema": "float",             "unit": "percent"         },
It is working in IOT Central:

But this is rejected by dmr-client:

However, it works if the semantic type is set to "RelativeHumidity".

Hi @tmb-soc
Thanks for reporting this issue, this seems an issue in Central rather than DMR.
I'm adding @sandeeppujar from the central team to take note before closing.

Closing as this is not related to this repo. If still require a resolution I'd suggest filing an issue in the Azure IoT Central docs


User friendly show state command

What's the difference?

What's the difference?

@erikzhang  I created this pr first, this one solved two major issues:

adding a block update progress, indicating the process of consensus (the dot in the second line). Otherwise, the screen looks frozen.
give the tag colors making the state more clear to check. (This can be replaced by #812 )

After I committed this pr, I found that the whole cli outputs are not user-friendly. So I created #812 which focuses on the color of different level logs.


icon missing when toggling the show/hide related entities

Go here:
https://cirm-dev.isrd.isi.edu/chaise/record/#1/Microscopy:Scan/id=35

Click 'Show all related entities'
Click 'Hide empty related entities'

Now the icon for the 'Show all related entities' is missing.

@howdyjessie Please move this to review if this feature is done.

@robes I've pushed for the fix for this to master (it was a small typo).


Support for "Seconds"

See commonhaus/foundation#203

Can I work on this issue?

Resolved by fbedae1ef53912722071f420262307a79ca3aff7


refactor: remove IDB on carousel

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR Type

[ ] Bugfix
[ ] Feature
[x] Refactoring

Context

[x] related with https://github.com/kodadot/nft-gallery/issues/4744. remove idb on carousel

Since you're removing idb cache on carousel, are we going to experience some loading (Time) issue from user perspective ? Otherwise wfm

From what @preschian claimed, it will be now managed by service worker

Let it roll.
It thought that I merged it🙈


attr.data-src not working

Cant get attr.data-src to work with interpolated data

{{ourwork.h2Title}}

{{ourwork.h3Title}}

{{ourwork.shortDescription}}

		    View More

No console errrors, images arent showing up... works perfectly when you use
data-src="website.com/url"
but I obviously want to use interpolation so I don't have write that 100 times

Hello @Alex61NN5!
Thank you for using this library to lazy load the images in your Angular application.
I have just checked the use case you describe here and it works for me.
Which angular version are you using? Can you please provide me an example where I can reproduce the error, or paste the DOM tree that was generated?

Im currently running
Angular CLI: 1.6.6
Node: 9.2.1
OS: win32 x64
Angular: 5.1.0
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

@angular/cli: 1.6.6
@angular/service-worker: 5.2.1
@angular-devkit/build-optimizer: 0.0.42
@angular-devkit/core: 0.0.29
@angular-devkit/schematics: 0.0.52
@ngtools/json-schema: 1.1.0
@ngtools/webpack: 1.9.6
@schematics/angular: 0.1.17
typescript: 2.4.2
webpack: 3.10.0

Yes, I have tried with Angular 5.1.0 as well, but I have been unable to reproduce the error. Can you provide me any code so that I can reproduce the error?

I'm also using Angular 5 with similar versions as Alex's. I had the similar issue that only data-src worked but it did not lazy-load the images. However I figured out that I forgot to import LazyLoadImagesModule. After correcting it, it worked perfectly.
P.S: @jesusbotella Thank you for making this module.

Yes, but the comment said that it was working with hardcoded strings, so I thought that it was loaded without errors. 🤔
Thanks to you @harryhoang for using it 😁

I am also using this library and it worked for me without any issues. Thanks @jesusbotella for this contribution.

Thank you @nikunjtilva!
I think I am going to close this issue. Feel free to reopen it if you face something similar.


A.01.validate.md

The description of the ATC says:

Document shall pass schema validation without errors, using one of the following XML schema definitions:

schemaLocation A
schemaLocation B
schemaLocation C

We need to specify the criteria to determine which schemaLocation to use.
Otherwise a validator, in order to claim compliance, would have to try A and if it fails B and if it fails C.

@aquaglia, what about the case that an xsd is duplicated and referenced locally (on the data server). In this case the schema is equal, but the location is different
And what about the case if the Schema is extended. In that case the schema's are different but could still be interoperable?

@pvgenuchten, where a specific schema definition is physically located is irrelevant.
The schema definitions in themselves are relevant.
In particular, the schema definitions found at the second and third schema locations in the ATC description are semantically different, and I am referring to:
ISO 19139 version 2005-DIS with GML 3.2.0
ISO/TS 19139:2007 with GML 3.2.1:
You need to specify an algorithm through which a reader can determine against which of the two schema definitions, the validation is intended to succeed.

As I'm sure you now, generally, the namespace of the XML Schema should be enough to identify the schema for validation purposes. The schemaLocation attribute is provided to help the validators in fetching the schema rules if it does not already know the referred schema: it's a hint.
The author of an XML document should not assume that the reader will necessarily use the schemaLocation provided to fetch the schema file. It may already have fetched the same schema (=same namespace) for interpreting some previously processed XML documents, or it may be designed to use locally cached versions of the schema files for performance or data security reasons (these files are also identified by namespaces, not schemaLocation URLs).
Unfortunately the case of the gmd is a good example what happens when this principle is not followed, but instead different versions of the schema files with the same namespace are published in different locations and by different parties. The identification of the schema rules is no longer possible using the namespace alone, which creates big problems for the validators. I agreed with @aquaglia that for this particular case we should suggest a way for the data providers to declare and validators to identify which variant of the gmd schema is used for a particular metadata record.
As for the @pvgenuchten's question of extended schemas: If these "extended" schemas are different from the original schemas they should be published under a different namespace. This in turn makes them completely different from the validator's perspective, because even the elements and types left unchanged are now contained in a different namespace, and thus are not equal.

@ilkkarinne, it might be the case that in general a namespace is enough to identify a schema, this is not the case in iso-metadata. We have quite some examples of namespace-naming being kept equal, while the underlying schema changed.
I think at this point we can choose some approaches:

Develop an algorythm as @aquaglia suggests that will grab the xsd and check if it's similar as the appropriate schema
Assume some of the other tests in this suite will likely fail if the appropriate schema is not provided, so just check if the document validates against the schema it's advertising to validate against and continue with the other tests
As approach 2, but additionally, replace the customised schema locations by the appropriate schema locations and validate the document again.

@ilkkarinne your comment 'makes them completely different from the validator's perspective' suggests that the validator should not validate a metadata document that is based on an extended schema.

@pvgenuchten In no way did I intend to suggest a schema comparison.
I meant instead detecting elements in the document instance that can drive the selection of the schema implementation to use.

@aquaglia ah I see it now, in that case the test will:

grab the xsd
algorythm to test if it's schema "ISO 19139 version 2005-DIS with GML 3.2.0" or "ISO/TS 19139:2007 with GML 3.2.1:"
Validate against one of these

@pvgenuchten
No, no, you have to inspect the xml document instance to validate not the resource pointed by schemaLocation
The schemaLocation attribute is not mandatory and we shall not rely on it.

@aquaglia : do you mean that the validator should decide which schema variation the metadata record is using by checking for the existence of certain elements in the record and only then run the schema validation against that schema? This option would also mean that this "peeking" of elements should be done using a non-validating XML parser.

Yes, of course.
It is a two step process:

You detect the "type" of the xml document, so that you know which schema definition files you have to pick;
You validate the xml document.

@aquaglia you're suggesting that implementors should not extend the schema or use a compatible schema. Is this only for metadata, or do you consider this the case for all test suites, what if people extend the WMS capabilities schema or a data theme schema, which seems to be encouraged to enable inclusion of organisation specific attributes.
I know schemaLocation attribute is (unfortunately) not mandatory, but I guess if it is specified it would make sense to use it in a test.

@pvgenuchten Each XML schema has its own rules for handling extensions and customizations. It is not possible to generalize.
The point of validating an XML document is to ensure its syntactic structure is consistent with one that the consumer of the document knows and understands.
It really does not help the consumer to know or check that an XML document is valid with respect to a schema modified by the producer of the document.
It also does not make sense to ask the consumer to embark on a semantic evaluation of the schemas customized in arbitrary ways by the producer.
If your proposal is to amend the MD TGs in order to make schemaLocation mandatory for metadata, I am against it especially if you also intend to allow the schemaLocation to point to customized versions of the schemas and perform the validation using those schemas.
@michellutz FYI

And remember that:
1, the official schemas for ISO 19139:2007 (at http://standards.iso.org/iso/19139/) do not include metadata for services. So far as I know, the nearest-to-official set was prepared for a late draft of 19119, and is at http://schemas.opengis.net/iso/19139/20060504/.

neither does ISO 19139:2007 include metadata 'extensions for imagery', but at least that (19115-2) does have an official ISO schema (http://standards.iso.org/iso/19115/-2/gmi/1.0/)

some times it may be better to start at the gmx.xsd root - although the only specific I know is if you are using a 'hybrid' schema set that contains service metadata as well as dataset metadata.

(I agree that the 'physical' schema locations - URLs - aren't the official identifiers, I'm using them as convenient indicators of the mess that OGC/ISO had created before agreeing that namespace identifiers need to be versioned)


Create Mixins for common entity types

Person, Place, Event, ...?

Added the needs-attention label, because we have to discuss how we want to implement this - I guess we don't want to implement every layer of cidoc crm

There should be an easy possibility to add vocabularies to type something #514
We should create an mixin that allows to include a SKOS compliant vocabulary in the ontology #441

we discuss that in extended Jfx 24th of Jan 2024


Columns are missing

When a new datasource is created from Snowflake all columns aren't showing.  This means that LIST columns doesn't show everything.  If using the cli someone is prompted to ADD a new column even though it's in there.
Query
I created a datasource using this query:
SELECT BABY_NAME
, NUMBER_OF_BABIES
, YEAR_OF_BIRTH
, GENDER
, SYLLABLES
, STATE
, RANK() OVER (PARTITION BY YEAR_OF_BIRTH, GENDER ORDER BY NUMBER_OF_BABIES DESC) AS ranking
FROM NAMES.PUBLIC.CA_HI
QUALIFY RANK() OVER (PARTITION BY YEAR_OF_BIRTH, GENDER ORDER BY NUMBER_OF_BABIES DESC) <= 100

tdsx
I then added it to saved datasources as a tdsx

List columns
When I run list_columns I don't see all of the columns. I only see "State"
➜  scratch git:(tutorial-1) ✗ tableau_utilities --location local --file_path '/Users/jayrosenthal/code/scratch/CA_HI_Top_100.tdsx' datasource --list columns
Columns:
  → caption: None local-name: [STATE] persona: string_dimension
  → caption: Custom SQL Query local-name: [__tableau_internal_object_id__].[_A126CDE57C4349A685328DA088990A6E] persona: None

@JustinGrilli  Do you think it would be heard to make list_columns show everything even when there isn't a column object?  Or perhaps we need some sort of "init" function that would add all the columns in that metadata records section even when there isn't a column
If I remember correctly we solved this in the code for Airflow but not in the CLI.  I think we solved it in the base functionality, not the DAG.

This will be fixed by https://github.com/jaybythebay/tableau-utilities/pull/15/files

Fixed in https://github.com/hoverinc/tableau-utilities/commit/d5e1b5bd0e56236647125d1bad40806199e749e4


How to know training and testing time?

Code version (Git Hash) and PyTorch version
Dataset used
Expected behavior
Actual behavior
Steps to reproduce the behavior
Other comments
[07.25.19|15:17:36] Training epoch: 0
[07.25.19|15:17:39] 	Iter 0 Done. | lr: 0.100000 | loss: 6.0831
[07.25.19|15:18:21]
When I train, I see the time like this.
So, how to know training and testing time?
When I train your kinetics-skeleton data with batch size = 32, I got cuda out of memory RuntimeError after training epoch 4.
RuntimeError: CUDA out of memory. Tried to allocate 1.98 GiB (GPU 0; 7.91 GiB total capacity; 2.70 GiB already allocated; 356.00 MiB free; 3.39 GiB cached)
My GPU memory is 8GB. So, How can I fix this?

training time:
In the default setting, the training will last 50 epochs.
memory problem:
You should also add --test_batch_size ${test_batch_size} after the command line to adjust the memory cost in testing state.

--test_batch_size
which command should --test_batch_size follow


Error:"Watchdog caught collective operation timeout" when finetuning MPT-7B on a local dataset using 2 A100 GPUs

Hi, I am trying to finetune the MPT-7B model using a local dataset on 2 A100 - 80GB GPUs. Below is the complete log.
Torch Version: 1.13.1+cu117
Appreciate any help to resolve the issue.
/mpt-7b/llm-foundry/scripts/train# composer train.py yamls/finetune/mpt-7b_jokes.yaml
Initializing model...
Explicitly passing a revision is encouraged when loading a configuration with custom code to ensure no malicious code has been contributed in a newer revision.
Explicitly passing a revision is encouraged when loading a model with custom code to ensure no malicious code has been contributed in a newer revision.
/root/.cache/huggingface/modules/transformers_modules/mosaicml/mpt-7b/14958374ab073ba1030c0caef4ae8380045bae45/attention.py:153: UserWarning: While attn_impl: triton can be faster than attn_impl: flash it uses more memory. When training larger models this can trigger alloc retries which hurts performance. If encountered, we recommend using attn_impl: flash if your model does not use alibi or prefix_lm.
warnings.warn('While attn_impl: triton can be faster than attn_impl: flash ' + 'it uses more memory. When training larger models this can trigger ' + 'alloc retries which hurts performance. If encountered, we recommend ' + 'using attn_impl: flash if your model does not use alibi or prefix_lm.')
Loading checkpoint shards: 100%|█████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 2/2 [00:08<00:00,  4.42s/it]
cfg.n_params=6.65e+09
Building train loader...
Using pad_token, but it is not set yet.
No preprocessor was supplied and no preprocessing function is registered for dataset name "local_dataset". No additional preprocessing will be applied. If the dataset is already formatted correctly, you can ignore this message.
Found cached dataset json (/root/.cache/huggingface/datasets/json/local_dataset-f2d32eae91a10861/0.0.0/0f7e3662623656454fcd2b650f34e886a7db4b9104504885bd462096cc7a9f51)
Loading cached processed dataset at /root/.cache/huggingface/datasets/json/local_dataset-f2d32eae91a10861/0.0.0/0f7e3662623656454fcd2b650f34e886a7db4b9104504885bd462096cc7a9f51/cache-e96cabec8ddb1637.arrow
Building eval loader...
No preprocessor was supplied and no preprocessing function is registered for dataset name "local_dataset". No additional preprocessing will be applied. If the dataset is already formatted correctly, you can ignore this message.
Found cached dataset json (/root/.cache/huggingface/datasets/json/local_dataset-f2d32eae91a10861/0.0.0/0f7e3662623656454fcd2b650f34e886a7db4b9104504885bd462096cc7a9f51)
Loading cached processed dataset at /root/.cache/huggingface/datasets/json/local_dataset-f2d32eae91a10861/0.0.0/0f7e3662623656454fcd2b650f34e886a7db4b9104504885bd462096cc7a9f51/cache-76316eeb9f4e44d9.arrow
Building trainer...
Logging config...
max_seq_len: 2048
global_seed: 17
run_name: mpt-7b-finetune
model:
name: hf_causal_lm
pretrained: true
pretrained_model_name_or_path: mosaicml/mpt-7b
config_overrides:
attn_config:
attn_impl: triton
attn_uses_sequence_id: false
tokenizer:
name: mosaicml/mpt-7b
kwargs:
model_max_length: ${max_seq_len}
train_loader:
name: finetuning
dataset:
hf_name: local_dataset
split: train
tokenizer_name: ${tokenizer_name}
max_seq_len: ${max_seq_len}
allow_pad_trimming: false
decoder_only_format: true
shuffle: true
drop_last: true
num_workers: 8
pin_memory: false
prefetch_factor: 2
persistent_workers: true
timeout: 0
eval_loader:
name: finetuning
dataset:
hf_name: local_dataset
split: test
tokenizer_name: ${tokenizer_name}
max_seq_len: ${max_seq_len}
allow_pad_trimming: false
decoder_only_format: true
shuffle: true
drop_last: true
num_workers: 8
pin_memory: false
prefetch_factor: 2
persistent_workers: true
timeout: 0
scheduler:
name: linear_decay_with_warmup
t_warmup: 50ba
alpha_f: 0
optimizer:
name: decoupled_adamw
lr: 5.0e-06
betas:

0.9
0.999
eps: 1.0e-08
weight_decay: 0
algorithms:
gradient_clipping:
clipping_type: norm
clipping_threshold: 1.0
max_duration: 2ep
eval_interval: 1ep
eval_first: true
global_train_batch_size: 8
seed: ${global_seed}
device_eval_batch_size: 4
device_train_microbatch_size: 4
precision: amp_bf16
fsdp_config:
sharding_strategy: FULL_SHARD
mixed_precision: PURE
activation_checkpointing: true
activation_checkpointing_reentrant: false
activation_cpu_offload: false
limit_all_gathers: true
verbose: false
progress_bar: false
log_to_console: true
console_log_interval: 1ba
callbacks:
speed_monitor:
window_size: 10
lr_monitor: {}
memory_monitor: {}
runtime_estimator: {}
save_folder: ./{run_name}/checkpoints
dist_timeout: 600.0
n_gpus: 2
device_train_batch_size: 4
device_train_grad_accum: 1
n_params:<PHONE_NUMBER>

Config:
node_name: unknown because NODENAME environment variable not set
num_gpus_per_node: 2
num_nodes: 1
rank_zero_seed: 17

[E ProcessGroupNCCL.cpp:821] [Rank 0] Watchdog caught collective operation timeout: WorkNCCL(SeqNum=2, OpType=_ALLGATHER_BASE, Timeout(ms)=600000) ran for 600963 milliseconds before timing out.
ERROR:composer.cli.launcher:Rank 1 crashed with exit code -6.
Waiting up to 30 seconds for all training processes to terminate. Press Ctrl-C to exit immediately.
[E ProcessGroupNCCL.cpp:456] Some NCCL operations have failed or timed out. Due to the asynchronous nature of CUDA kernels, subsequent GPU operations might run on corrupted/incomplete data.
[E ProcessGroupNCCL.cpp:461] To avoid data inconsistency, we are taking the entire process down.
terminate called after throwing an instance of 'std::runtime_error'
what():  [Rank 0] Watchdog caught collective operation timeout: WorkNCCL(SeqNum=2, OpType=_ALLGATHER_BASE, Timeout(ms)=600000) ran for 600963 milliseconds before timing out.
Global rank 0 (PID 786) exited with code -6
Global rank 1 (PID 787) exited with code -6
----------Begin global rank 1 STDOUT----------
Initializing model...
cfg.n_params=6.65e+09
Building train loader...
No preprocessor was supplied and no preprocessing function is registered for dataset name "local_dataset". No additional preprocessing will be applied. If the dataset is already formatted correctly, you can ignore this message.
Building eval loader...
No preprocessor was supplied and no preprocessing function is registered for dataset name "local_dataset". No additional preprocessing will be applied. If the dataset is already formatted correctly, you can ignore this message.
Building trainer...
----------End global rank 1 STDOUT----------
----------Begin global rank 1 STDERR----------
Explicitly passing a revision is encouraged when loading a configuration with custom code to ensure no malicious code has been contributed in a newer revision.
Explicitly passing a revision is encouraged when loading a model with custom code to ensure no malicious code has been contributed in a newer revision.
/root/.cache/huggingface/modules/transformers_modules/mosaicml/mpt-7b/14958374ab073ba1030c0caef4ae8380045bae45/attention.py:153: UserWarning: While attn_impl: triton can be faster than attn_impl: flash it uses more memory. When training larger models this can trigger alloc retries which hurts performance. If encountered, we recommend using attn_impl: flash if your model does not use alibi or prefix_lm.
warnings.warn('While attn_impl: triton can be faster than attn_impl: flash ' + 'it uses more memory. When training larger models this can trigger ' + 'alloc retries which hurts performance. If encountered, we recommend ' + 'using attn_impl: flash if your model does not use alibi or prefix_lm.')
Loading checkpoint shards:   0%|                                                                                | 0/2 [00:00<?, ?it/s]
Loading checkpoint shards:  50%|████████████████████████████████████████████████████████████                                                            | 1/2 [00:08<00:08,  8.54s/it]
Loading checkpoint shards: 100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 2/2 [00:10<00:00,  4.94s/it]
Loading checkpoint shards: 100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 2/2 [00:10<00:00,  5.48s/it]
Using pad_token, but it is not set yet.
Found cached dataset json (/root/.cache/huggingface/datasets/json/local_dataset-f2d32eae91a10861/0.0.0/0f7e3662623656454fcd2b650f34e886a7db4b9104504885bd462096cc7a9f51)
Loading cached processed dataset at /root/.cache/huggingface/datasets/json/local_dataset-f2d32eae91a10861/0.0.0/0f7e3662623656454fcd2b650f34e886a7db4b9104504885bd462096cc7a9f51/cache-e96cabec8ddb1637.arrow
Found cached dataset json (/root/.cache/huggingface/datasets/json/local_dataset-f2d32eae91a10861/0.0.0/0f7e3662623656454fcd2b650f34e886a7db4b9104504885bd462096cc7a9f51)
Loading cached processed dataset at /root/.cache/huggingface/datasets/json/local_dataset-f2d32eae91a10861/0.0.0/0f7e3662623656454fcd2b650f34e886a7db4b9104504885bd462096cc7a9f51/cache-76316eeb9f4e44d9.arrow
[E ProcessGroupNCCL.cpp:821] [Rank 1] Watchdog caught collective operation timeout: WorkNCCL(SeqNum=1, OpType=BROADCAST, Timeout(ms)=600000) ran for 601403 milliseconds before timing out.
[E ProcessGroupNCCL.cpp:456] Some NCCL operations have failed or timed out. Due to the asynchronous nature of CUDA kernels, subsequent GPU operations might run on corrupted/incomplete data.
[E ProcessGroupNCCL.cpp:461] To avoid data inconsistency, we are taking the entire process down.
terminate called after throwing an instance of 'std::runtime_error'
what():  [Rank 1] Watchdog caught collective operation timeout: WorkNCCL(SeqNum=1, OpType=BROADCAST, Timeout(ms)=600000) ran for 601403 milliseconds before timing out.
----------End global rank 1 STDERR----------
ERROR:composer.cli.launcher:Global rank 0 (PID 786) exited with code -6
/mpt-7b/llm-foundry/scripts/train#

I'm seeing the same thing... also using 2 A100 GPUs interestingly enough

I also have timeout error

I encountered the same problem. Could you tell me how you resolved it?

I also had this problem but it works after making this:export NCCL_P2P_LEVEL=NVL
(However now I'm running into out of memory error on 4xA100 80GB even though all I'm doing is running the finetune_example with model changed from gpt2 to mosaicml/mpt-7b-storywriter)

I've also had to go down to a 2x A100 setup because otherwise I run into the NCCL error, nothing larger seems to work

I also had this problem but it works after making this:export NCCL_P2P_LEVEL=NVL
On a 4xA100 80GB,verified two times it solved the issue when present

Were you on torch 1.13.1 or 2.0.1?

root@ce755e977208:/llm-foundry# pip show torch
Name: torch
Version: 1.13.1+cu117
Summary: Tensors and Dynamic neural networks in Python with strong GPU acceleration
Home-page: https://pytorch.org/
Author: PyTorch Team
Author-email<EMAIL_ADDRESS>License: BSD-3
Location: /usr/lib/python3/dist-packages
Requires: typing-extensions
Required-by: composer, flash-attn, llm-foundry, mosaicml-streaming, pytorch-ranger, torch-optimizer, torchmetrics, torchtext, torchvision, triton-pre-mlir

I'm running the docker "mosaicml/pytorch:latest"

Are people still running into this problem?

If you haven't already, can you try working off one of the recommended images in the top-level README, making sure that your code is up-to-date with the main branch, and re-installing to get all the latest dependencies? Basically, I'm wondering if this happens after following the install/set-up instructions in the README.
NCCL errors are notoriously hard to diagnose, so it'd be helpful to see if this is just an environment issue. But, honestly, there's not a lot to go off of here, so I can't make any promises.

I updated my code with the main branch and reinstalled the whole environment. It's working now... thanks

Follow-up on this error: when I use a larger local dataset, I get the error again when saving the checkpoint. Do you have any ideas on that? thanks
RuntimeError: NCCL communicator was aborted on rank 0.  Original reason for failure was: [Rank 0] Watchdog caught collective operation timeout: WorkNCCL(SeqNum=29544, OpType=_ALLGATHER_BASE, Timeout(ms)=600000) ran for 601762 milliseconds before timing out.
....
....
composer.core.engine: Post-closing callback RuntimeEstimator
[E ProcessGroupNCCL.cpp:455] Some NCCL operations have failed or timed out. Due to the asynchronous nature of CUDA kernels, subsequent GPU operations might run on corrupted/incomplete data.
[E ProcessGroupNCCL.cpp:460] To avoid data inconsistency, we are taking the entire process down.
ERROR:composer.cli.launcher:Global rank 0 (PID 160339) exited with code -6

Follow-up on this error: when I use a larger local dataset, I get the error again when saving the checkpoint. Do you have any ideas on that? thanks
RuntimeError: NCCL communicator was aborted on rank 0. Original reason for failure was: [Rank 0] Watchdog caught collective operation timeout: WorkNCCL(SeqNum=29544, OpType=_ALLGATHER_BASE, Timeout(ms)=600000) ran for 601762 milliseconds before timing out. .... .... composer.core.engine: Post-closing callback RuntimeEstimator [E ProcessGroupNCCL.cpp:455] Some NCCL operations have failed or timed out. Due to the asynchronous nature of CUDA kernels, subsequent GPU operations might run on corrupted/incomplete data. [E ProcessGroupNCCL.cpp:460] To avoid data inconsistency, we are taking the entire process down. ERROR:composer.cli.launcher:Global rank 0 (PID 160339) exited with code -6

I am also getting the same error while saving the model.

此错误的后续：当我使用较大的本地数据集时，保存检查点时再次收到错误。您对此有什么想法吗？谢谢
运行时错误：NCCL 通信器在等级 0 上中止。失败的原始原因是：[等级 0] 看门狗捕获集体操作超时：WorkNCCL(SeqNum=29544, OpType=_ALLGATHER_BASE, Timeout(ms)=600000) 在超时之前运行了 601762 毫秒。.... ....composer.core.engine：关闭后回调 RuntimeEstimator [E ProcessGroupNCCL.cpp:455] 某些 NCCL 操作失败或超时。由于 CUDA 内核的异步特性，后续 GPU 操作可能会在损坏/不完整的数据上运行。[E ProcessGroupNCCL.cpp:460] 为了避免数据不一致，我们将取消整个流程。错误：composer.cli.launcher：全局排名 0 (PID 160339) 退出，代码为 -6

保存模型时我也遇到同样的错误。

Im sure the problem comes from saving model on multi gpus，but i cant fix it。Do u fix it now？

We have fixed the issue with nccl timeouts at the end of runs while saving checkpoints. I have a feeling there may be a variety of issues in this thread at this point, so I am going to close this issue. Please open a new issue if you are still encountering problems.


Oauth2 Boot reference document' example miss a “{”

https://docs.spring.io/spring-security-oauth2-boot/docs/current-SNAPSHOT/reference/htmlsingle/#accessing-a-resource
the example is :
@RestController
public class SimpleController
	@GetMapping("/whoami")
	public String whoami(@AuthenticationPrincipal(expression="name") String name) {
		return name;
    }
}

expect result :
@RestController
public class SimpleController {
	@GetMapping("/whoami")
	public String whoami(@AuthenticationPrincipal(expression="name") String name) {
		return name;
    }
}

sorry I don't know if the documentation issue should be submitted here or not.

@kioyong thanks for the report. Yes, this is a good place to report those kinds of issues.
Would you be interested in submitting a PR to fix the documentation?

i careated a PR to fix the documentation, refer:
https://github.com/spring-projects/spring-security-oauth2-boot/pull/187


feat: Custom property types

This PR adds support for creating and adding custom property types.

Absolutely! Was looking into adding tests, but as it added more boilerplate I settled with adding example. But I'll make sure to add tests as well ☺

@lohnn if you update the branch now the pipeline should be fixed.

Tests now added, you can now take one more look 👍


When creating a mirror order, why filter ERC20 from original Order offer items?

In the createMirrorAcceptOfferOrder function, used to create mirror offers, we remove the Offer items that have itemType === 1 (which corresponds to ERC20 tokens).
https://github.com/ProjectOpenSea/seaport/blob/fb1c3bf4c25a32ae90f776652a8b2b07d5df52cf/test/utils/fixtures/marketplace.ts#L381
This creates issues when I want to mirror an Order of type:
{
  offer: [anERC721OfferItem],
  consideration: [anERC20ConsiderationItem]
}

which gets mirrored into:
{
  offer: [], // <--- now this is empty
  consideration: [anERC721OfferItem]
}

which, when I try to fulfil using the matchAdvancedOrders function, it fails with a InvalidFulfillmentComponentData() error.
BUT, if I comment out the line where we remove the ERC20 items, then the Order is matched correctly.
Tbh, I cannot think of a reason why ERC20 items should be removed when mirroring an Order. Am I missing anything?
Thanks!

Not sure, this is a test util so maybe it was doing something specific. You are right that it would not create a valid matched order if it excludes ERC20 items. If you remove that line do any of the tests fail?
If you are looking for a production library then check out https://github.com/ProjectOpenSea/seaport-js


[Meta/PM] Create a deprecation process

There is a need to define a feature deprecation process.
We can use this issue for a discussion to define the process.
Some internal discussion has come to this steps as an starting point:

Create a 'deprecation' labeled issue.
Soft deprecation and removal from the codebase.
Update examples and tutorials.
Hard deprecation by adding a deprecate compiler warning.
Mentioning in the release log.
Later: total removal.

I want to link @kianenigma's comment to add a bit of context

We probably also need a tracking issue for all the deprecated things that we have.
Could you maybe start one with a checklist or table @juangirini?
The two things from Kians comment obviously. Otherwise I can think of: Weight::{from_ref_time, from_proof_size}, other V1 weight stuff (1, 2).

We can also talk about the deprecated code that I left behind as part of refactoring all the Weight related types and logic into sp_weight. They're largely located in https://github.com/paritytech/substrate/blob/master/frame/support/src/weights.rs, where you can see there's a lot of deprecated items, with helpful hints as to where the actual types have been moved to.
A couple of observations to note:

Types that still uses the old path, e.g. frame_support::weight::DispatchClass, are simply type aliases to the type now located in the new path (frame_support::dispatch::DispatchClass).
Functions do not support aliasing, so instead what happens is that we create a new function in the old path (frame_support::weight::extract_actual_weight), and in its body, we call the function that's now located in the new path (frame_support::dispatch::extract_actual_weight).
Deprecating traits is a bit trickier, but not impossible. The way I handled it is by making the relocated trait a supertrait of the old trait path, e.g. frame_support::weight::OneOrMany is the old path, so now it has frame_support::dispatch::OneOrMany as its supertrait.

These are all measures to ensure that code that hasn't migrated yet would still work as intended, but would generate a deprecation warning during every compilation. I would suggest that this going forward, we should look into trying to support such a deprecation model as it allows users to migrate code at their leisure.
However, what still requires discussion is how long we intend to keep the deprecated code around until we remove them altogether.

A deprecation process is a good step in the right direction, but it needs a defined release process so that users know when "Later: total removal" will occur.
If we adopted semantic versioning major.feature.patch, deprecation could occur during any feature release version. Still, the removal wouldn't occur until the next major release or the first feature release version of a new major release if the deprecation occurs in the last feature release version of the previous major release. This is to ensure that deprecation warnings are present in at least two versions before removal.
For example:

A feature is deprecated in 6.4, the next release is 7.0, and the feature is removed in 7.1
Or a feature is deprecated in 8.2, it is still available for 8.3, 8.4, 8.5, and so on, before being removed in 9.0

Using this as a basis, I would imagine the process would then be as follows:

Decision is made to deprecate a feature in the next feature release
Docs, tutorials, templates, VODs, etc are updated to remove references to deprecated feature
Compiler deprecation warnings are added
Feature release version number is bumped
Deprecation is noted in the release log
Feature release version is published at the same time as updated docs, etc
Major release is planned
Deprecated feature is removed from the code base
Removal of the feature is noted in the release log
New major version is published

A feature is deprecated in 6.4, the next release is 7.0, and the feature is removed in 7.1

If we adopt semantic versioning, then we can't introduce a breaking change in a minor release. As explained here, in your example 6.4 would include the deprecation warning and 7.0 the actual removal.
Nevertheless, I don't think we are anywhere close to adopt semver, and I think we should introduce a deprecation process before that. We can always revisit the process after implementing semver.
Other than that the flow you propose seems logical, and I think that if we find a compromise solution i those lines where we don't need semver we should be good.

However, what still requires discussion is how long we intend to keep the deprecated code around until we remove them altogether.

Until we don't implement semantic versioning we might need to find a solution that takes time and releases into account.
My suggestion is to remove a feature in the first release after 6 months have passed since the release in which the feature was notified as 'deprecated' in its notes.

Those are very good questions, I'll reach out to the Data Team to see if they can help us with some stats

Depending on what process you settle here, the decl macro deprecation would also be a good candidate: https://github.com/paritytech/substrate/issues/12248
Would like to delete it out ASAP since it blocks a ton of other issues.

A few notes/ideas about the deprecation process from an extrinsics perspective, as a continuation of a few offline discussions we have had.
Currently, there is also no clear process to follow to deprecate or change the signature of extrinsics. Usually, we start by reaching out the community about the change and decide what is the best deprecation/update path. Communication is crucial since removing or refactoring extrinsics may break dapps (e.g. wallets with staking when the controller account is deprecated) and teams that do not keep up with the forum will only realise about the deprecation when the their app breaks.
One idea that has been floating around is to include in the metadata the extrinsics that are marked as deprecated and use that as a communication channel for projects to learn about soon-to-be deprecated or refactored extrinsics. The advantage is that community have an easier way to "subscribe" to changes in the extrinsics they depend, provided that they consume the metadata correctly. On the other hand, the disadvantage is that it bloats up the metadata, but the increase in storage requirements should be pretty low.
Implementation brainstorming

We could annotate extrinsics with #[pallet::deprecate("substrate/issues/XXXX")] and then the metadata amalgamator extracts all the deprecation annotations and includes it in the extrinsic metadata with the issue referring with deprecation notes.

Another options would be only annotate with #[pallet::deprecate)] and rely on the extrinsic comments to add deprecation details and pointers.

There is a breaking change coming up in with Metadata V15, perhaps we could piggy back this change in the release (~end of June).

This issue has been mentioned on Polkadot Forum. There might be relevant details there:
https://forum.polkadot.network/t/stablising-v15-metadata/2819/9

@gpestana I like the idea. However, I don't really want to overload the metadata format.
I had this idea since very beginning. How about just support custom metadata?
Allow something like #[pallet::metadata(name, value)] to be attached to extrinsics (and storages) and SDK can read those value and do whatever they want.
In that way we can extend metadata without extend the metadata format.
For this case, it could be #[pallet::metadata(known_metadata_key::DEPRECATE", "since version 0.9.43")]

@gpestana that's a great idea, and @xlc suggestion is a very nice way to generalise it.
The downside of the last proposal is that is less explicit, and a "DEPRECATE" key within "metadata" is more likely to be ignored if not understood by the reader. But not sure if that's a big deal.
@gpestana do you see any other pros of having a dedicated deprecate key instead of a generic on within metadata?
I really like the #[pallet::deprecate("")] syntax, which could actually be syntax sugar that translates into #[pallet::metadata("","")] behind the scenes.
I see this "metadata" solution has been proposed here.

I want to bring in the "deprecation" side-discussion started on #12939.
@bkchr has some concerns about the generic metadata proposed by @xlc that can be used for deprecation notices.

TBH, just sounds like a band tape on the shitty process we have. This should go into the release notes. No need to put this kind of stuff into the metadata where people will also just ignore it.

It is indeed a band tape, and we are trying to come up with a compromise solution while we don't have proper semver in place.
I think we all agree that we need release notes, and more visibility on deprecation/breaking changes.
And I also agree with @gpestana on this:

allowing developers to "subscribe" to deprecation through metadata could be a good complement to the process

It seems to me that it will be a stretch to add the deprecated info to the V15 release, but I think we could keep the discussion going and work on this to eventually add this feature to the next metadata format release.

Create a 'deprecation' labeled issue with the following
Soft deprecation and removal from the codebase
Update examples and tutorials
Hard deprecation by adding a warning message *
Deprecation is noted in the release log
Removal version is planned
Deprecated feature is removed from the code base
Removal of the feature is noted in the release log

What do you think about removing step 2 and replace it by step 4? So that there is no soft deprecation.
Currently, step 3 needs to happen after step 2, and step 4 needs to happen after 3. Whereas this seems ideal for developers, it slows down the process quite a lot.
This new proposal would allow async work between FRAME and docs teams and therefore a faster process.

@juangirini can you explain what it means "Soft deprecation and removal from the codebase"?

@muharem it means to stop using the 'deprecated' piece of code in the codebase by removing all usages of them and any references, without actually adding a compiler warning. Anyway it's been decided not to do that, please see the updated issue comment

fwiw, this is a good example where adding deprecation notes to the metadata would be useful https://github.com/paritytech/substrate/pull/14538

As I could understand from all related threads, there is no decision on whether we should include the deprecation note into the metadata or not.
One simpler decision that we could do, it is a pattern/suffux for PR titles or/and a label (we could include this info into the issue template with the checklists). This will help with release notes and search.


Cannot connect Metamask or Celo Browser Extension wallet

Trying to get this working with the web dapp tutorial. I added the next.config.js file specified here.
I am unable to connect Metamask or the Celo browser extension wallet. I see the following errors.
react.development.js?72d0:220 Warning: Each child in a list should have a unique "key" prop.

Check the render method of `Modal`. See https://reactjs.org/link/warning-keys for more information.
    at div
    at Modal (webpack-internal:///./node_modules/@celo-tools/use-contractkit/lib/modal.js:117:23)
    at Provider (webpack-internal:///./node_modules/unstated-next/dist/unstated-next.mjs:11:31)
    at ContractKitProvider (webpack-internal:///./node_modules/@celo-tools/use-contractkit/lib/use-contractkit.js:164:23)
    at div
    at WrappedApp
    at ErrorBoundary (webpack-internal:///./node_modules/@next/react-dev-overlay/lib/internal/ErrorBoundary.js:23:47)
    at ReactDevOverlay (webpack-internal:///./node_modules/@next/react-dev-overlay/lib/internal/ReactDevOverlay.js:73:23)
    at Container (webpack-internal:///./node_modules/next/dist/client/index.js:152:5)
    at AppContainer (webpack-internal:///./node_modules/next/dist/client/index.js:641:24)
    at Root (webpack-internal:///./node_modules/next/dist/client/index.js:772:24)

Uncaught (in promise) TypeError: Cannot read property 'indexOf' of undefined
    at WarningComponent.render (warning.js:1)
    at p._renderValidatedComponentWithoutOwnerOrContext (react-dom.min.js:13)
    at p._renderValidatedComponent (react-dom.min.js:13)
    at performInitialMount (react-dom.min.js:13)
    at p.mountComponent (react-dom.min.js:13)
    at Object.mountComponent (react-dom.min.js:14)
    at performInitialMount (react-dom.min.js:13)
    at p.mountComponent (react-dom.min.js:13)

warning.js?d96e:34 Warning: react-modal: App element is not defined. Please use `Modal.setAppElement(el)` or set `appElement={el}`. This is needed so screen readers don't see main content when modal is opened. It is not recommended, but you can opt-out by setting `ariaHideApp={false}`.

Most of those are warnings (will take the time to sort them out however), but with the latest @celo-tools/use-contractkit release (0.0.28) I verified it was working with the Celo Extension Wallet.


Trainer.model is not a PreTrainedModel, only saving its state dict.

训练Baichuan-13B-Base的RM环节，保存rm训练的结果会报这个错：
Trainer.model is not a PreTrainedModel, only saving its state dict.

忽视即可


WIP Replaced uses of GetAssemblies with a reflection helper that caches r…

Description
Made a reflection utility to replace the many places we look for generated code (and temporary components) as well as surface errors more clearly.

Going to remove the caching for now as the all types cache is big. Several ways to get around it but we will deal with that as it becomes a problem.


Omniauth With Devise: Given URL is not permitted by the Application configuration

We have configured our app following the tips stated here for version 2 of Facebook API.
In the initializers/Devise, we have as below:
config.omniauth :facebook, ENV['APP_ID'], ENV['APP_SECRET'], :scope => 'email,public_profile,user_friends', :display => 'popup' ,
:client_options => {:site => 'https://graph.facebook.com/v2.4',:authorize_url => "https://www.facebook.com/v2.4/dialog/oauth"}, token_params: { parse: :json }
The App itself is configured with callback URL as below:
www.domain.com/users/auth/facebook/callback.
Any amount of tweaking is doing nothing, but throw this error:
One or more of the given URLs is not permitted by the App's settings. It must match the Website URL or Canvas URL, or the domain must be a subdomain of
one of the App's domains.
Please help.

Please use the mailing list or StackOverflow for questions/help, where a wider community will be able to help you. We reserve the issues tracker for issues only.


Custom validation rule for a field

It would be great to have a way of setting custom validation rules to a field without overwriting the controller.
https://voyager-docs.devdojo.com/bread/introduction#validation
E.g
{
    "validation": {
        "rule": "required",
        "custom_rule": "App\Rules\DateWithinFinancialYear|App\Rules\SlugUniqueForCategory",
        "messages": {
            "required": "This :attribute field is a must."
        }
    }
}

There is no need to override Controller, create a custom rule and apply it like any other rule.

Please could you give example because I can only make it work with default laravel validation.
E.g using a custom validation rule
<?php

namespace App\Rules;

use Illuminate\Contracts\Validation\Rule;

class DateWithinFinancialYear implements Rule
{
    /**
     * Determine if the validation rule passes.
     *
     * @param  string  $attribute
     * @param  mixed  $value
     * @return bool
     */
    public function passes($attribute, $value)
    {
        return false; // always fail for testing
    }

    /**
     * Get the validation error message.
     *
     * @return string
     */
    public function message()
    {
        return 'The :attribute must be ....';
    }
}

Update the field details:
{
"validation": {
"rule": "required|DateWithinFinancialYear",
"messages": {
"required": "This :attribute field is a must."
}
}
}
Throws error:
Method Illuminate\Validation\Validator::validateDateWithinFinancialYear does not exist.

// in Provider boot method

//Custom validation rule
Validator::extend('date_with_financial_year', function ($attribute, $value, $parameters, $validator) {
    //your checks
});

{
  "validation": {
    "rule": "required|date_with_financial_year",
  }
}

Awesome thanks that's exactly what I needed. It's not in the laravel 8 documentation but exists in the older ones so might be worth adding it into the voyager documentation.


Update README (and build process?) to be friendlier towards data viz

It'd be cool if the README included a link to the chainquery SQL data structure in some kind of visualization tool.
(Not a priority)
Acceptance Criteria

Definition of Done

[ ]  Tested against acceptance criteria
[ ] Tested against the assumptions of the user story
[ ] The project builds without errors
[ ] Unit tests are written and passing
[ ] Tests on devices/browsers listed in the issue have passed
[ ] QA performed & issues resolved
[ ] Refactoring completed
[ ] Any configuration or build changes documented
[ ] Documentation updated
[ ] Peer Code Review performed

This could certainly be done. YeD has an online tool that can be used with a link and a graphml reference. Graphml is an open source visualization format. Below is a groovy example of doing this.
https://gist.github.com/agea/6591881
We can do this by just creating a quick go app to read from a db connection and write a graphml file. This way anytime we change the db schema we can run this app to update the graphml file.

I thinks #123 should be ok.
Dove with MySQL Workbench "reverse engineer" functionality


[SECURITY] Security issues with package dependencies

Potential vulnerability found in protobufjs

Dependency name

Severity

Affected versions

Earliest fixed version

<EMAIL_ADDRESS>(via<EMAIL_ADDRESS><EMAIL_ADDRESS>

High

>= 6.10.0, < 7.2.4

7.2.4

Reported as CVE-2023-36665 "protobufjs Prototype Pollution vulnerability"

This will be addressed in https://github.com/DoctorMcKay/node-steam-user/pull/450.

@DoctorMcKay let me know if you eventually need further information about or if I can contribute to fix this issue

Update on GitHub advisories
https://github.com/advisories/GHSA-h755-8qp9-cq85


shell command fails in IJulia

Hello all,
I am using Jupyter 4.2.0, I execute this command in Julia 0.4 and 0.5:
;sustrip<src.su>src.rsf@
sustrip: subcalls.c: efopen: fopen failed

Whereas if I change the kernel to python:
!sustrip<src.su>src.rsf@

It works normally (as if executed from shell).
Your help  is much appreciated!

What do ;pwd and !pwd output in Julia and Python, respectively?  Maybe they are not in the same directory?
Does it work if you do the same thing in the Julia REPL (i.e. the julia> command-line prompt, not IJulia)?  If so, maybe report a bug.
(What is the @ at the end of the filename for?)

(Note that ls -F prints an @ at the end of symbolic links, but the @ is not actually part of the filename.)

First, thanks for the reply!
1- same directory
2- Works in Julia REPL
3- The  @ is part of the filename, but I had already tried with another filename with no special character (suspecting those may be a problem), it fails too.
Thanks

What do ;pwd and !pwd output in Julia and Python, respectively?  Maybe they are not in the same directory?

Hmm, can you try:
Base.repl_cmd(`sustrip<src.su>src.rsf@`)

and
Base.repl_cmd(@cmd("sustrip<src.su>src.rsf@"))

to see if either works in IJulia?  IJulia is transforming your line into the former, but I suspect we should be using the latter.

Base.repl_cmd(`sustrip<src.su>src.rsf`,STDOUT)
sustrip: subcalls.c: efopen: fopen failed
Base.repl_cmd(@cmd("sustrip<src.su>src.rsf@"),STDOUT)
sustrip: subcalls.c: efopen: fopen failed

Ok, some advance here, the command has a optional argument par=/dev/tty. Without it, it prints the parameters to screen (which is what python, and julia REPL do). Once I added a par file, the command worked! I still don't understand though why the REPL could handle it but not IJulia.
;sustrip <src.su outpar=par >src.rsf@

Feel free to close the issue if that is not something that impedes other users.
Thank you guys for your help!

It probably has to do with the fact that STDOUT is a terminal device in the REPL, but is a pipe in IJulia (so that IJulia can capture output and redirect it to the browser).  Maybe it is calling fopen on the pipe or something like that and failing?
Not sure if anything can be done here.  cc @JobJob

Sorry @stevengj, also missed this mention.
@raminammour does this work in IJulia?
Base.repl_cmd(`sustrip<src.su>src.rsf@`, IJulia.orig_STDOUT)

@JobJob same error for above command

Had a quick look at the code for Base.repl_cmd
It seems commands are run differently if STDIN is a TTY (which at the REPL it is, but in IJulia it isn't), see this line: $shell -i -c ... vs $shell -c ...
So I think that's the difference, not sure how ipython runs shell commands but doing this:
cmd = `echo hello`
shell = Base.shell_split(get(ENV,"JULIA_SHELL",get(ENV,"SHELL","/bin/sh")))
run(`$shell -i -c "($(Base.shell_escape(cmd))) && true"`)

gives me a warning:
bash: cannot set terminal process group (85462): Inappropriate ioctl for device
bash: no job control in this shell

So I don't think we want to mess with this.
I imagine if you replace my
cmd = `echo hello`
in the example above with
cmd = `sustrip<src.su>src.rsf@`
it should work but will maybe give you a warning. I'm curious now, so let me know if it does :)
I'm guessing this is more of an issue with shell commands that expect to be run interactively than with IJulia.

It gives:
cmd =`sustrip<src.su>src.rsf@`
shell = Base.shell_split(get(ENV,"JULIA_SHELL",get(ENV,"SHELL","/bin/sh")))
run(`$shell -i -c "($(Base.shell_escape(cmd))) && true"`)

bash: no job control in this shell
sustrip: subcalls.c: efopen: fopen failed

I tried with different options for sh and had the same error too.

I really think the problem is /dev/tty. I ran:
In Julia Repl:
;tty
/dev/pts/97

In IJulia from Jupyter:
;tty
not a tty

In Python from Jupyter
!tty
/dev/pts/80

Hope this helps :)

Ok thanks. I think this is such a rare issue that I can live with it for now.
Thanks for reporting, it might help someone else one day.

Thank you guys for your help!


[SDK generation pipeline] remove outdated folder when generate from Typespec

Typespec doesn't have configuration --clear-output-folder as autorest so pipeline has to add the logic to delete outdated code before regeneration

After this PR merged, python generation failure of https://github.com/Azure/azure-rest-api-specs/pull/29887 shall be fixed


Pagination on coverflow effect does not work

This is a (multiple allowed):

[x] bug

[ ] enhancement

[ ] feature-discussion (RFC)

Swiper Version: 3.4.2

Platform/Target and Browser Versions: Windows // Chrome 56.0.2924.87

uri: http://idangero.us/swiper/demos/18-effect-coverflow.html

What you did
tried to use pagination on a coverflow
Expected Behavior
pagination should work, click on the dot to get the desired slide
Actual Behavior
the hand grabs the slide,and it is not possible to click on pagination dots, pagination is useless.

Have you tried using CSS to put the .swiper-pagination indices to a higher number?

Yes, z-index won't fix it.

it's look like event.preventDefault() on click function

Issue is closed because of outdated/irrelevant/not actual/needed more information/inactivity.
If this issue is still actual and reproducible for latest version of Swiper, please create new issue and fill the issue template correctly:

Clearly describe the issue including steps to reproduce when it is a bug.
Make sure you fill in the earliest version that you know has the issue.
Provide live link or JSFiddle/Codepen or website with issue


Please support MSVC v143 for NuGet release

I installed the NuGet release from Visual Studio and selected Dynamic CRT linkage. However, linkage failed for not founding packages\pugixml.1.11.0\build\native\lib\x64\v143\dynamic\Debug\pugixml.lib. Under directory packages\pugixml.1.11.0\build\native\lib\x64, I found it support only to v142 but not v143.
Please update the NuGet release to support MSVC v143, thanks.

pugixml 1.12 was published to NuGet just now with support for VS2022 following #468.


FY22-Q2 (plus a couple before)

Really need to remember to do this before I am starting the next one. Going to just merge it in since we already released this and this will keep the main repo up-to-date. This technically has WY21 & FY22-Q1 in it :)

Other than changes to ind and build/ files, this has the callout_cfg.yml changes, date changes in the viz_config.yml, and the addition of at USGS streamgages to the intro frame per Joe's request.


Change project organization to io.zipkin.brave.play

There are some remaining places that use the old organization. Those places are README and examples. We could completely remove the old organization in the next release.

food for thought @llinder's work here is io.zipkin.brave.ratpack https://github.com/openzipkin-contrib/brave-ratpack/blob/master/pom.xml#L20

Can we use io.zipkin.brave.play as the group id (organization in sbt) and the base package name? Also we need permission to publish artifacts to Sonatype.

sounds good on maven group ID. you might want to consider "brave.play"
on package name so that in case this is moved to ASF we don't have to
rename the packages (group id is a smaller matter).
on sonatype can you request to be added here? It has been my
experience that they always just add people who ask :)
https://issues.sonatype.org/browse/OSSRH-16669
On Mon, Mar 25, 2019 at 11:02 PM Naoki Takezoe<EMAIL_ADDRESS>wrote:

Can we use io.zipkin.brave.play as the group id (organization in sbt) and the base package name? Also we need permission to publish artifacts to Sonatype.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Fixed. Thanks for the jira link! I'll request access before releasing the next version.

@adriancole Do you mean we can use package names other than org.apache.* even after we move to ASF?

@adriancole https://github.com/adriancole Do you mean we can use
package names other than org.apache.* even after we move to ASF?

yes

@adriancole I got it, thanks!

thanks very much


Mining pickaxe and drill need buffs

So PKA and crusher can both mine which outclass pickaxe and drill atm.
What I'm thinking is maybe make it so pickaxe has a short cooldown (e.g. 0.5) and drill can be 1-handed. If we want diamond etc stuff to be different then could make it so basic pickaxe can't 1-shot diamond mines to encourage upgrades.

related, pickaxe doesnt need to be wielded it does enough damage to rocks 1-handed

I feel like mining could take a page from games like Stardew Valley, Terraria, etc...Starting with basic tools that take longer/create fatigue/can only mine "softer" rocks types/ores. Through research you unlock upgrades that are faster/less draining and can mine "harder" rock types/ores.
Make it so salvage couldn't actually mine an entire med/large asteroid in the early round(first 30-40 mins.) Then scale from there.


Reconnecting after pasting text

Hi All,
First time code-server user here.  Recently installed on AWS Ubuntu 20 for my team to WFH.
Upon Pasting text ~30 lines, the page will result in attempting to reconnect...
This happens everytime without exception.
I heard this might be extensions, however, the only extension we've installed is Material Theme & Material Icons.

Web Browser: Chrome, Safari
Local OS: MacOS Mojave
Remote OS: AWS Ubuntu 20
Remote Architecture: x86 - t3.nano
code-server --version: latest

Hey @arkjxu sorry for the late response. Can you update the issue with the precise version being used and also test the latest? Might be fixed. We've made significant changes to the HTTP layer in recent months.

Version: 3.6.2
I upgraded the version to  3.7.4, seems like it's fixed now

Awesome!


cc-check: warn if unrestricted_guest unavailable under hypervisor

If running under a hypervisor, the kvm "unrestricted_guest" option is
not required.
Fixes #439.
Signed-off-by: James O. D. Hunt<EMAIL_ADDRESS>

Unit test coverage maintained at 100%.

More github timeouts...
/me forces the CI to rebuild...

Coverage increased (+0.3%) to 55.644% when pulling f5855a81649f5b17ff18354a060cb4ce4417cc0f on jodh-intel:fix-cc-check-under-hypervisor into 48255158a15166ecaae2497c3b15f203b7728727 on clearcontainers:master.

LGTM

@jodh-intel travis is complaining, I guess you need to re-upload

Coverage increased (+0.3%) to 55.644% when pulling 7e749ef429e9f6f327e3ddfa4325bbd2b57e04a4 on jodh-intel:fix-cc-check-under-hypervisor into 48255158a15166ecaae2497c3b15f203b7728727 on clearcontainers:master.

After many attempts, Travis is now happy.

Hi @grahamwhaley - could you take a look?


Binput ignore validation rules

Hi,
I've tried to extend the Binput directly to my request, but it ignore all the validation rules.
//Request.php
 use GrahamCampbell\Binput\Binput;
 abstract class Request extends Binput
 {

  }

 //UserRequest
  public function rules()
   {
     return [
        'email'             => 'required|email|unique:users,email',
        'password'          => 'required|numeric|digits:6',
    ];
  }

It works perfectly. Everything is clean and trim. But if I try to not fill the email field. But it pass the validation request.
Am I doing mistake or is this how binput works?
Thanks

Binput is nothing to do with form requests.


Update script.js

Remove the number given to game in home page #125
PR Description 📜
Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes # 125

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[x] I have added working video of the game in README.md (optional)
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @Omkarkale59 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Thank you  @Omkarkale59 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


Typo

Closes https://github.com/MicrosoftDocs/office-docs-powershell/issues/6881

Docs Build status updates of commit ac83897:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-server/Remove-SPSecureStoreApplication.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

@Kateyanne Please merge this PR. Thanks.

Docs Build status updates of commit 369dacc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-server/Remove-SPSecureStoreApplication.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


create API

Routes:

GET / -> 200 OK
GET /fossils/lastest ->or /fossils/popular(??) -> list of fossils
GET /fossils/:id -> fossil details
POST /fossils/new -> new fossil
GET /users/:id -> user details
POST /users/new -> new user
PATCH/POST /users/:id -> change user details

I will probably use PocketBase for the API, so I will close this.