Intended for localhost use only?

After a failed attempt to access this remotely, I see that the browser javascript has 'localhost:5000' hard coded.
Is this only intended to be run locally?

Yes, at least at this point.  The time to send clips made this difficult to use online for systems with slow upload bandwidth, so this approach made more sense.


Two concurrent pushes of a new ID can fail incorrectly with 409

Describe the bug
Push the same new, package ID concurrently with different versions (no duplicate versions). You will sometimes see HTTP 409. On the second attempt of the failed package, there is no error.
Two actors creating a PackageRegistration row at the same time with the same ID collide. Subsequent pushes see the PackageRegistration already exists and have no problem.
Expected behavior
No HTTP 409 should be returned.
Additional context
The error is:
Cannot insert duplicate key row in object 'dbo.PackageRegistrations' with unique index 'IX_PackageRegistration_Id'. The duplicate key value is (0, Microsoft.NETCore.Jit).
The statement has been terminated.

It occurs on this line:
https://github.com/NuGet/NuGetGallery/blob/b1e426282fca0db14deca54e95cffc5c2eb4cd4c/src/NuGetGallery/Services/PackageUploadService.cs#L976
The code is expecting this to only occur for Package rows, but it can happen for PackageRegistration too.

has this happened? or just a code gap issue? would help in prioritizing.

I only noticed this on a deployment that has asynchronous validation enabled. But AFAIK it could happen either which way. I think it has more to do with the scale of the SQL DB.


Fix client handling for modify for optional types

When receiving an update for a column who contains a optional set type,
and the updated value is the same as what previously existed, the
modification should result in removing that element. In this case reset
the value to nil.
Also, when an update comes where columns update value is empty/nil we
should not update anything for that column.
Signed-off-by: Tim Rozet<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

16 of 20 (80.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 74.777%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

cache/cache.go
16
20
80.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.05%

Covered Lines:
4948

Relevant Lines:
6617

💛  - Coveralls

LGTM


--trim-filenames fails to clip file name properly when there is a dot in a video title

Checklist

[X] I'm reporting a bug unrelated to a specific site
[X] I've verified that I'm running yt-dlp version 2021.12.27. (update instructions)
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Description
This procedure:
https://github.com/yt-dlp/yt-dlp/blob/e04938ab88fc1fb4560f6cceb32525ef6e7f47a4/yt_dlp/YoutubeDL.py#L1221-L1225
Assumes that there is at most 2 extensions appended to the current filename. This fails when there is a dot in a video title. Yeah, that happens.
Proposed fixes
a. assuming there is only one extension => using os.path.splitext() to split the filename before trimming
b. trimming the file name before appending the ext.

might cause artefacts (trimming foo-bar-foo.mp4 to 14 chars would produce foo-bar-foo.mp.mp4)

c. mask dots from extracted video titles
d. let me know if you have some other idea
I am happy to fix that, just let me know which (a-d) would the maintainers prefer.
Verbose log
[debug] Command-line config: ['-Uv', '--trim-filenames', '30', 'https://www.dvtv.cz/video/slavme-odchod-delty-a-prichod-omikronu-ockovat-se-kvuli-byrokracii-a-ne-kvuli-zdravi-je-ulet-rika-hostomsky']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8 (No ANSI), err utf-8 (No ANSI), pref UTF-8
[debug] yt-dlp version 2021.12.27 [6223f67a8]
[debug] Python version 3.10.1 (CPython 64bit) - macOS-12.0.1-x86_64-i386-64bit
[debug] exe versions: ffmpeg 4.4.1 (setts), ffprobe 4.4.1
[debug] Optional libraries: Cryptodome, mutagen, sqlite, websockets
[debug] Proxy map: {}
Latest version: 2021.12.27, Current version: 2021.12.27
yt-dlp is up to date (2021.12.27)
[debug] [generic] Extracting URL: https://www.dvtv.cz/video/slavme-odchod-delty-a-prichod-omikronu-ockovat-se-kvuli-byrokracii-a-ne-kvuli-zdravi-je-ulet-rika-hostomsky
[generic] slavme-odchod-delty-a-prichod-omikronu-ockovat-se-kvuli-byrokracii-a-ne-kvuli-zdravi-je-ulet-rika-hostomsky: Requesting header
WARNING: [generic] Falling back on generic information extractor.
[generic] slavme-odchod-delty-a-prichod-omikronu-ockovat-se-kvuli-byrokracii-a-ne-kvuli-zdravi-je-ulet-rika-hostomsky: Downloading webpage
[generic] slavme-odchod-delty-a-prichod-omikronu-ockovat-se-kvuli-byrokracii-a-ne-kvuli-zdravi-je-ulet-rika-hostomsky: Extracting information
[debug] Looking for video embeds
[debug] Identified a HTML5 media
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id
[download] Downloading playlist: Slavme odchod delty a příchod omikronu. Očkovat se kvůli byrokracii a ne kvůli zdraví je úlet, říká Hostomský | DVTV - první internetová televize
[generic] playlist Slavme odchod delty a příchod omikronu. Očkovat se kvůli byrokracii a ne kvůli zdraví je úlet, říká Hostomský | DVTV - první internetová televize: Collected 1 videos; downloading 1 of them
[download] Downloading video 1 of 1
[debug] Default format spec: bestvideo*+bestaudio/best
[info] slavme-odchod-delty-a-prichod-omikronu-ockovat-se-kvuli-byrokracii-a-ne-kvuli-zdravi-je-ulet-rika-hostomsky: Downloading 1 format(s): 0
[debug] Invoking downloader on "https://www.dvtv.cz/uploads/videa-fotky/2022-01-10-dvtv-mr-hostomsky.mp3"
ERROR: unable to open for writing: [Errno 63] File name too long: 'Slavme odchod delty a příchod . Očkovat se kvůli byrokracii a ne kvůli zdraví je úlet, říká Hostomský _ DVTV - první internetová televize [slavme-odchod-delty-a-prichod-omikronu-ockovat-se-kvuli-byrokracii-a-ne-kvuli-zdravi-je-ulet-rika-hostomsky].mp3.part'
Traceback (most recent call last):
  File "/usr/local/Cellar/yt-dlp/2021.12.27/libexec/lib/python3.10/site-packages/yt_dlp/downloader/http.py", line 265, in download
    ctx.stream, ctx.tmpfilename = self.sanitize_open(
  File "/usr/local/Cellar/yt-dlp/2021.12.27/libexec/lib/python3.10/site-packages/yt_dlp/downloader/common.py", line 218, in sanitize_open
    return sanitize_open(filename, open_mode)
  File "/usr/local/Cellar/yt-dlp/2021.12.27/libexec/lib/python3.10/site-packages/yt_dlp/utils.py", line 557, in sanitize_open
    stream = open(encodeFilename(filename), open_mode)
OSError: [Errno 63] File name too long: 'Slavme odchod delty a příchod . Očkovat se kvůli byrokracii a ne kvůli zdraví je úlet, říká Hostomský _ DVTV - první internetová televize [slavme-odchod-delty-a-prichod-omikronu-ockovat-se-kvuli-byrokracii-a-ne-kvuli-zdravi-je-ulet-rika-hostomsky].mp3.part'

[download] Finished downloading playlist: Slavme odchod delty a příchod omikronu. Očkovat se kvůli byrokracii a ne kvůli zdraví je úlet, říká Hostomský | DVTV - první internetová televize

I am aware of this issue 😓. The --trim-filename option is just overall poorly implemented, making this tricky to fix. I honestly suggest using something like %(title).30s.%(ext)s instead

Related: https://github.com/yt-dlp/yt-dlp/issues/1837

I honestly suggest using something like %(title).30s.%(ext)s instead

Why does not it use the sanitized id too name the file. Like %(id)s.%(ext)? Or similar. I made a bash alias which includes the -o parameter by default such that I do not need to rename the files all the time.

A lot of Twitter videos fail to download because of this bug, since they use the contents of the tweet as the title.

I am aware of this issue sweat. The --trim-filename option is just overall poorly implemented, making this tricky to fix. I honestly suggest using something like %(title).30s.%(ext)s instead

Very nice, but does it also have a syntax to limit the byte-length of the string? Because if the string has several unicode characters then it will in my case often exceed the 255 bytes ext4 limit even if I make the maximum character length well below 255.

@JoakimCh Yes, and the answer is even pinned! https://github.com/yt-dlp/yt-dlp/issues/1136#issuecomment-932077195

@pukkandan Not in my experience. I find that, if I'm yt-dlp-ing videos off Twitter, I have to manually specify something like 200s for latin tweets and something like 50s for CJK tweets to minimize truncation while also avoiding getting a fatal error over the filename being too long.
I'd suggest a Python equivalent to how I implemented this Rust tool I wrote to truncate filenames to within what rclone's filename encryption requires.
(Feel free to read the code and port the algorithm to Python without complying with the MIT license if it helps. I don't currently have time to contribute a fix to yt-dlp or I'd do so.)

@pukkandan Not in my experience

What are you replying to?

@pukkandan This exchange:

Very nice, but does it also have a syntax to limit the byte-length of the string? Because if the string has several unicode characters then it will in my case often exceed the 255 bytes ext4 limit even if I make the maximum character length well below 255.

@JoakimCh Yes, and the answer is even pinned! https://github.com/yt-dlp/yt-dlp/issues/1136#issuecomment-932077195

I suggest you read the discussion under the linked comment.
This issue is about the bug in --trim-filenames, and there's not a single on-topic comment here! I'm locking the issue.
For reference, here's a potential solution for the actual issue https://github.com/yt-dlp/yt-dlp/issues/5526#issuecomment-1312783517


moveToFolder() not moving the message

After retrieving the messages and processing them, when I call moveToFolder() it doesn't move the message to the specified folder, instead I need to call the method twice in order to move the message
$compte = Client::account('test_inbox');

$compte->connect();

$inbox_folder = $compte->getFolder('inbox');

$messages = $inbox_folder->getMessages();

foreach ($messages as $num_message => $message)
{
    //processing the message
    $message->moveToFolder('INBOX.processed');
}

I noticed that the first time I call moveToFolder() the flag "answered" changes to 1, only after the second call is when the message get moved to the new folder.

OS X El Capitan 10.11.6
PHP: 7.1
Version 1.4.1

Thanks in advance for your help.

Getting the same error in here:
ubuntu 18.04 - lts
php 7.3
version 1.4.1
Currently calling "moveToFolder" twice to workaround that issue.


Sessions should only be visible by owning user

Overview
A user should be the only one who can view and manage existing sessions.
Currently with this module installed, a user who has access to view other member profiles (like the default Administrator role) has the ability to view and manage their sessions. This shouldn't be the case.
Acceptance Criteria

[ ] If you do not have access to view another user's member form then the session manager component should not show
[ ] By default, Admin roles do not have access to view the session manager component for another member
[ ] Session data can only be viewed and managed by the user that it relates to
[ ] Validate that all access control measures on the session manager components are as expected, i.e. CanView and CanDelete are doing the right thing
[ ] Confirm there is a sensible way for Developers to alter view and management permissions on the session manager component, allowing privileged users to manage sessions if that's a requirement of theirs.
[ ] The ability for Developers to alter the behaviour (and allow other users to access member session data) should be documented so the feature is discoverable
[ ] Confirm that there is no permission that can be assigned to a user to give them access to view another member session details

This code in LoginSession::handlePermission() should probably be changed from
        // Members can manage their own sessions
        if ($this->ID == $member->ID) {
            return true;
        }

        // Access to SecurityAdmin implies session management permissions
        return Permission::checkMember($member, 'CMS_ACCESS_SecurityAdmin');

to
        // Members can manage their own sessions
        if ($this->MemberID === $member->ID) {
            return true;
        }

Probably worth updating following code in LoginSessionController::removeLoginSession():
            $id = $request->param('ID');
            $loginSession = LoginSession::get()->byID($id);

            $id = $request->param('ID');
            $memberID = Security::getCurrentUser()->ID;
            $loginSession = LoginSession::get()->filter(['ID' => $id, 'MemberID' => $memberID])->first();

The current permission model is poorly implemented. MemberExtension has a bunch of logic to determine if the current user can edit and/or view the current session, but it completely bypasses LoginSession::canView/LoginSession::canEdit methods.
MemberExtension is also a PermissionProvider for SESSION_MANAGER_ADMINISTER_SESSIONS. If we want a permission provider, it should be on LoginSession because that's the object we are managing.
MemberExtension also tries to set the SessionManagerField to read-only if you are only allowed to view the current login session. However, we don't have a read-only view for this field.
LoginSession::handlePermission looks pretty good and already has permission extensibility built-in like @bergice mentioned in backlog grooming.
Here's what I want to do:

Update MemberExtension

Remove all the PermissionProvider logic
Use LoginSession::canView to determine if the field should be displayed or not
Set SessionManagerField to readonly if the user doesn't have canDelete permission and spin off an issue to implement a read-only view for this field.

Update LoginSession to

remove the permission check on CMS_ACCESS_SecurityAdmin
Set CanEdit to always return false ... the idea is that you should never be able to directly update a LoginSession object.
Set CanCreate to always return false for the same reason
Review CanView and CanDelete to be based on the owner of the LoginSession

Update the doc with an example of how you could implement your own permission layer if you wanted to.

Looks good

how you could implement your own permission layer if you wanted to.

How do you see this working?

You would stick an extension on LoginSession an hook into the canView/canDelete extension points.
Maybe you use a pre-existing permission to decide if the user can delete the login session. Maybe you just check if the current user can edit the member. Maybe you implement your own permission provider. Ultimately, that's a decision the developer has to make for themselves.
We've got a follow up issue to explore this in further detail https://github.com/silverstripe/silverstripe-session-manager/issues/57#issuecomment-819161619

The ability for Developers to alter the behaviour (and allow other users to access member session data) should be documented so the feature is discoverable

I've made a suggestion in https://github.com/silverstripe/silverstripe-session-manager/issues/63 that we should recommend that if the behaviour is altered, the privileged user should get both CanView and CanDelete actions (given there's no read-only view).

Linked PR has been merged
Noted on the pull request there's an issue with non-admin users revoking sessions.  We've agreed to split that of as a separate issue.


Deployment of a Symfony 2.7 PHP application fails

Hi,
I'm trying to deploy an PHP application and suddenly, I get this:

remote: -----> Compiled slug size is 109M
remote: -----> Creating release...
remote: Error deploying app release: web process type failed to start, got down job event
To https://git.........com/....git
! [remote rejected] master -> master (pre-receive hook declined)
error: failed to push some refs to 'https://git.........com/....git'

Log:

2015-12-16T16:20:58.960826Z app[web.flynn0-db77e7bf-9304-4088-b08d-cf6003406723]: Using Apache2 VirtualHost-level configuration include 'apache_app.conf'
2015-12-16T16:20:59.043666Z app[web.flynn0-db77e7bf-9304-4088-b08d-cf6003406723]: 4 processes at 128MB memory limit.
2015-12-16T16:20:59.048682Z app[web.flynn0-db77e7bf-9304-4088-b08d-cf6003406723]: Starting php-fpm...
2015-12-16T16:21:01.050160Z app[web.flynn0-db77e7bf-9304-4088-b08d-cf6003406723]: Starting httpd...
2015-12-16T16:21:01.058308Z app[web.flynn0-db77e7bf-9304-4088-b08d-cf6003406723]: Application ready for connections on port 8080.
2015-12-16T16:21:01.242660Z app[web.flynn0-54f50d1f-41b6-4901-976e-86befc453cc6]: Going down, terminating child processes...
2015-12-16T16:23:19.570054Z app[web.flynn0-177dcf75-c18e-4d1e-b27b-fd6f4389c208]: tar: This does not look like a tar archive
2015-12-16T16:23:19.570420Z app[web.flynn0-177dcf75-c18e-4d1e-b27b-fd6f4389c208]: tar: Exiting with failure status due to previous errors
2015-12-16T16:23:19.938508Z app[web.flynn0-ec31f3cd-0597-4fbd-9498-76c9c047b068]: tar: This does not look like a tar archive
2015-12-16T16:23:19.938816Z app[web.flynn0-ec31f3cd-0597-4fbd-9498-76c9c047b068]: tar: Exiting with failure status due to previous errors

That error typically indicates that the app slug was not successfully retrieved. Take a look at the blobstore log with flynn -a blobstore log

Hi,
thanks. This is the blobstore log during the failing deploy:

2015-12-16T16:33:14.079802Z app[web.flynn0-54d86f60-fec0-4085-a5e1-26b7a20f7853]: 2015/12/16 16:33:14 GET /9bf22aa6-03f0-4f45-a215-57a6e89ba163.tgz
2015-12-16T16:33:35.739417Z app[web.flynn0-54d86f60-fec0-4085-a5e1-26b7a20f7853]: 2015/12/16 16:33:35 GET /repos/a5babc3a-dcb6-4cde-b831-80d5931e7b41.tar
2015-12-16T16:33:36.919802Z app[web.flynn0-54d86f60-fec0-4085-a5e1-26b7a20f7853]: 2015/12/16 16:33:36 GET /repos/a5babc3a-dcb6-4cde-b831-80d5931e7b41.tar
2015-12-16T16:33:47.873976Z app[web.flynn1-598b7c6a-ece0-4c85-8328-6bbaa0c73e26]: 2015/12/16 16:33:47 GET /a5babc3a-dcb6-4cde-b831-80d5931e7b41-cache.tgz
2015-12-16T16:35:22.779797Z app[web.flynn0-54d86f60-fec0-4085-a5e1-26b7a20f7853]: 2015/12/16 16:35:22 PUT /3ca0c389-a164-4790-9cf8-c5a53dd9dfc5.tgz
2015-12-16T16:35:39.662087Z app[web.flynn1-598b7c6a-ece0-4c85-8328-6bbaa0c73e26]: > 2015/12/16 16:35:39 PUT /a5babc3a-dcb6-4cde-b831-80d5931e7b41-cache.tgz
2015-12-16T16:35:50.787333Z app[web.flynn0-54d86f60-fec0-4085-a5e1-26b7a20f7853]: 2015/12/16 16:35:50 PUT /repos/a5babc3a-dcb6-4cde-b831-80d5931e7b41.tar

And this line also occures in the blobstore logs:

2015-12-16T16:23:18.141623Z app[web.flynn0-54d86f60-fec0-4085-a5e1-26b7a20f7853]: 2015/12/16 16:23:18 discoverd: heartbeat blobstore (<IP_ADDRESS>:80) failed: unknown_error: Something went wrong

Ah, it looks like there was a discoverd issue while you were deploying. It may have recovered, but the debug logs would be useful.

Tried again, still getting this error.
Debug logs: https://gist.github.com/b2979d7e83485e497205

@benbjohnson It looks like discoverd is having some trouble, would you take a look?

@titanous I think the network periodically has high latency. discoverd seems to be able to elect and hold a leader for a while and then it's showing "raft: Failed to contact" errors that show it's not connecting to followers for ~1s which would trigger an election timeout.
We should probably allow discoverd's timeout settings to be configurable. We could also bump up the default settings to something higher than 1 second.
@philiplb Do you have any network latency stats? Do you see high latency between discoverd nodes or are you doing anything to saturate your network?

@benbjohnson
Hi,
there should be no network latency as flynn is the only application running on those three VMs.

@philiplb What kind of VMs are you running? It could also be underprovisioned machines that are causing high latency in responding to heartbeats.

Those are Cloud-VMs by www.inter.net. Kinda like Amazon EC2. No clue about the machines behind.

Looks like there is no bug here, we've only seen this on machines with very high load.

Alright, thx.


opts not being recongnized

hi there, great little plugin. this was like my first thought after installing snacks.
I have just configured it, below are bugs/suggestions

opts not being recongized, i tried using opts, using config = true, and doing require 'little-taskwarrior'.setup(opts). none of them worked. I wonder the get_snack_dashboard is not loading in the default config.
the placement of the log file, i have seen people putting it in ~/.local/share/nvim/plugin_name, this way i wont have to add it to .ignore
I notice your comment, and i see it in the code that theres a refresh function now, but it'd be nice to have it refresh periodically so that tasks added outside neovim can also appear without having to relaunch neovim. (not that important)

return {
  'folke/snacks.nvim',
  priority = 1000,
  dependencies = {
    {
      'praczet/little-taskwarrior.nvim',
      opts = {
        dashboard = {
          limit = 6,
          debug = false,
          max_width = 56,
          urgency_threshold = 1,
        },
      },
      config = true,
    },
  },
config = function()
  -- whether i do this with empty param or pass in a local copy of the opts, it just do not pick up the opts
  require('little-taskwarrior').setup()

ad1)
Ok here is my config of snacks.nvim (with Little-taskwarrior in dependencies)
local myFunc = require("my-functions")

local birth = require("next-birthday")
birth.setup({ bd_file = "/home/adam/Notes/me-social.md" })

local pplBirth = birth.birthdays("now")

local notes = myFunc.SnacksGetRecentNotes(" ", "Recent Notes", 2, 1, 1)
local currentDate = os.date("%Y-%m-%d")

return {
  {
    "folke/snacks.nvim",
    dependencies = {
      {
        "praczet/little-taskwarrior.nvim",
        opts = {
          dashboard = {
            limit = 6,
            debug = false,
            max_width = 56,
            urgency_threshold = 1,
          },
        },
        config = true,
      },
    },
    opts = {
      dashboard = {
        preset = {
          header = myFunc.DashHeader(),
        },
        sections = {
          {
            text = myFunc.DashHeader(),
            align = "center",
            height = 6,
            padding = 1,
          },
          {
            text = { { currentDate, hl = "key" }, { "\n\n" .. table.concat(pplBirth, "\n") .. "\n" } },
            align = "center",
          },
          {
            icon = "",
            title = "Little TaskWarrior",
            pane = 2,
          },
          {
            function()
              local ltw = require("little-taskwarrior")
              return { text = ltw.get_snacks_dashboard_tasks(56, "dir", "special") }
            end,
            pane = 2,
            indent = 2,
          },
          { section = "keys", gap = 1, padding = 1 },
          notes,
          { pane = 2, icon = " ", title = "Recent Files", section = "recent_files", indent = 2, padding = { 1, 1 } },
          { pane = 2, icon = " ", title = "Projects", section = "projects", indent = 2, padding = 1 },
          { pane = 2, section = "startup" },
        },
      },
    },
  },
}

This works. I had 6 lines of Tasks.
My default config look like this (I do not add little-taskwarrior in dependencies (I keep it in other file)). And it works also.

Can you share your little-taskwarror's config and config for snacks.nvim (Dashboard)?

@Praczet thanks for the super quick response. heres the config

heres what my dashboard looks like

ok.
Firstly when I changed my config in similar way to you, my config was picked up, but before we start checking this again look at this:

You have to wrap text with function

thanks! i did exactly what you told me. The interesting now is that the limit works! but everything else does not. i deleted the log file, it still gets populated. the urgency setting was updated a few times, but i dont see the highlight change. Am i still missing something?

Hi,
Finally I had some time to check it.
And there is what we've missed:
the proper configuration should be like this:
{
    "folke/snacks.nvim",
    dependencies = {
      {
        "praczet/little-taskwarrior.nvim",
        opts = {
          urgency_threshold = 1,
          dashboard = {
            limit = 6,
            debug = false,
            max_width = 56,

          },
        },
        config = true,
      },
    },
// ...
}

the urgency_threshold is part of plugin configuration not only for the dashboard. So it has to be on the same level as dashboard.


Make port forwarding configurable

My first attempt to build the Vagrant VM resulted in this error:
Vagrant cannot forward the specified ports on this VM, since they
would collide with some other application that is already listening
on these ports. The forwarded port to 8080 is already in use
on the host machine.

because I already had another VM listening on 8080.
This change enables devs to avoid port collisions by specifying:
FORWARDED_PORT=8091 vagrant up

Seems legit.


Added Windows Alternative Installation Method

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[ ] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[ ] Searched the bugtracker for similar pull requests
[ ] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[ ] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[x] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.
Added alternative method to install youtube-dl on Windows.

This method is discouraged for regular users. Also it's described in developer instructions.


Falsified "CI Text" test

  CI Text:            FAIL
    *** Failed! Falsified (after 77 tests and 6 shrinks):
    "\43929"
    "\43929" /= "\5065"
    Use --quickcheck-replay=93264 to reproduce.

  CI Text:            FAIL
    *** Failed! Falsified (after 72 tests and 6 shrinks):
    "\5115"
    "\5115" /= "\5107"
    Use --quickcheck-replay=960636 to reproduce.

There is yet another CI Text failure with tasty-golden <IP_ADDRESS>, should be a different thing though.

It is the same issue:
Unicode Character 'CHEROKEE SMALL LETTER YU' (U+13FB) -- 5115

Hrm, weird that it's only triggered after a tasty-golden update though. Sorry for the noise.

This text bug makes binary-instances tests non-deterministic: sometimes they pass, sometimes they fail.
I suggest making tests always fail by adding counterexample explicitly. Or always pass by filtering out known problematic cases.


[FEAT] bump graphql dependencies

Information
Add v16 graphql support to @tsed/graqhql package.
Acceptance criteria

[ ] Graphql works as expected
[ ] playground works as expected

Hello sir, I would like to work on this issue , can you pls tell me little more about it as i m new to the backend development. Thank You @Romakita

Hello @abhie16
This issue consist to bump graphQL dependencies here:
https://github.com/tsedio/tsed/blob/production/packages/graphql/apollo/package.json#L42
and here:
https://github.com/tsedio/tsed/blob/production/packages/graphql/typegraphql/package.json#L45
Note: bumping graphql dependencies need also to bump apollo dependencies and typegraphql. Some of theses dependencies are compatible or not with graphl.
To check if there is not regression you can run yarn test:graphql.
You can also start a local graphQL server by running this script here:
https://github.com/tsedio/tsed/blob/production/packages/graphql/typegraphql/package.json#L19
Tell me if you have any problems ;)
Romain


refactor(cli): resolve TODO comment in Version.test.ts

This came up during a deep dive meeting with @millsp and @SevInf.
PR marked as draft because we were not sure.

Do you remember was the outcome of our conversation our this?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Dinghy screwing with DNS setup?

Since using dinghy I've had two occasions where I've had to flush my dns manually to get a site to load. It could be down to chance but since I know Dinghy is screwing with my DNS I though I'd come and ask if there is any chance it could be related.

Hm I wouldn't think so -- dinghy only controls the .docker TLD, by adding a config file /etc/resolver/docker to your host machine. This is pretty common, http://pow.cx and https://github.com/phinze/landrush both do the same thing. Shouldn't affect DNS for any other TLDs.


Fixed issue#12 Nested field throwing errors

Added dump_only and load_only to _schema_kwargs in init.py. Accomodating marshmallow changes in version 2.0.0

Thanks!


Move napari to start using the Hub API

🚀 Feature

Move napari plugin manager dialog to use the hub API
Motivation
Use napari hub as the source of truth.
Additional context
The current endpoints for the napari hub API are as follows
https://api.napari-hub.org/plugins gives the full list of available plugins (plugin developers can "hide" deprecated or pre-release plugins, so this list is smaller than what PyPI returns)
https://api.napari-hub.org/plugins/ gives aggregated metadata for a given plugin (e.g. https://api.napari-hub.org/plugins/devbio-napari)

Update: we have added the api doc for our supported endpoints: https://api.napari-hub.org


Rewards page (earned by me) shows no data when using pagination

Description
Rewards page (earned by me) shows no data when using pagination
Steps to Reproduce

Go to https://governance.vega.xyz/rewards
Click on "earned by me"
Scroll down to pagination and click to next page
See data is not shown in the table

Expected behavior
I see my data for each epoch
Additionally I am not expecting to see the columns for rewards other than Staking and Infra fees since these are the only rewards relevant for stakers.
This was covered here but it looks like we're just showing zeroes instead of removing the columns entirely which is imho misleading because someone might have rewards there if they are trading too.
Screenshots
Page 1:

When using pagination (Page 2):

Device details
Desktop (please complete the following information):

OS: MacOS 14.2.1
Browser: Brave
Version v1.63.161

I've unassigned myself as I am not having a lot of success and find the code kind of hard to follow. I believe the problem is here-ish:
https://github.com/vegaprotocol/frontend-monorepo/blob/2e07ada966d5eca6766a061944377ea21532ec31/apps/governance/src/routes/rewards/epoch-individual-rewards/epoch-individual-rewards.tsx#L73-L89
I think when the refetch is happening, it is fetching rewards for the previous 'page' worth of epoch rewards, so when it munges them together (https://github.com/vegaprotocol/frontend-monorepo/blob/2e07ada966d5eca6766a061944377ea21532ec31/apps/governance/src/routes/rewards/epoch-individual-rewards/epoch-individual-rewards.tsx#L62-L71) it appears to have no rewards. I guess memoization, or the order in which things are triggered, are to blame.
acc55c7205cfcd5480e0235acab56a01487a39dc858a641fc04df6ba016870ee is an example party that should have rewards on page two of epochs.


Support link detection in test results terminal

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: VSCode 1.80.1, 1.81.0-insider; plugin playwright test for VSCode 1.0.14
OS Version: Windows 10

Steps to Reproduce:

Run playwright TS test throwing an error.
Open test results viewer in vs code (see picture)
Try Ctrl+Click on call stack item for the error

Expected
We jump to source code line
Actual
Nothing happens.
It stopped to work ~ a week ago, I guess. But used to work in  vs code insider build. But today is stopped to work in the insider build too. (monday, 17.07.2023)
Doesn't reproduce in VSCode  1.79.2.

Is this being worked on? I would like to file a PR for this.

yes!!


Fix bug where visible seeds are registered as 'invisible'

How to categorize this PR?

/area quality
/kind bug
/priority normal
What this PR does / why we need it:
Fix bug where visible seeds are registered as 'invisible'
Release note:

NONE

cc @grolu @ialidzhikov


GPT-MT: Add GPT-4

Currently we don't have results for GPT-4 on the GPT-MT report, but it would be nice to have them.

@neubig: Thanks Graham for this amazing analysis. I hoped someone would do this analysis when we released the data, I am happy that you did this.  We will update GPT-MT report's repo with GPT-4 and latest GPT-Turbo very soon. I expect to get some of them on the repo today and the rest should follow shortly.

Thanks so much @hanyh , that would be really appreciated. If you could ping me and/or send a PR updating this repo with the new models (here) when the new results are available that would be wonderful.

Thanks to @zwhe99 for sending in a PR for this! I'll be updating the report and online demo shortly.


Add --unsorted option to Retain Original Term Order

There are valid cases where users may want to preserve the original order of terms as returned by the POEditor API. Currently poesie does not provide an option to retain this default behavior.
This PR introduces an optional -u/--unsorted flag that allows users to skip sorting the exported terms before saving them. By default, terms will continue to be sorted to maintain backward compatibility.

interesting feature! Just out of curiosity: did you pushed this MR because you noticed a new version after several years of inactivity? Or is it a pure coincidence?

interesting feature! Just out of curiosity: did you pushed this MR because you noticed a new version after several years of inactivity? Or is it a pure coincidence?

It was just a coincidence that we noticed that this feature is missing right after there was recent activity after a while. Not sure if I would put the MR if the was such an inactivity.


python setup.py test fails

Forgetting the command line to run the test suite, I tried
python setup.py test

and it raised

TypeError: asm() missing 2 required positional arguments: 'kernel' and 'ubasis'

The command line is python -m unittest discover, as given in .travis.yml and Makefile, but I wonder what's required to get the other to work.

You must add some spells to setup.py and .cfg. I'll look into it.
On Tue, 14 May 2019 at 6.40, Geordie McBain<EMAIL_ADDRESS>wrote:

Forgetting the command line to run the test suite, I tried
python setup.py test
and it raised
TypeError: asm() missing 2 required positional arguments: 'kernel' and
'ubasis'
The command line is python -m unittest discover, as given in .travis.yml
and Makefile, but I wonder what's required to get the other to work.
—
You are receiving this because you are subscribed to this thread.

I think #184 covers it, just adding an entry to setup.py, nothing to setup.cfg.


[1.2] Bump log4j to 2.16 and plugin to 1.2.2

Signed-off-by: Joshua Li<EMAIL_ADDRESS>Description
backport #338
Issues Resolved
https://github.com/opensearch-project/opensearch-build/issues/1333
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #337 (2351896) into 1.2 (89f4642) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                1.2     #337   +/-   ##
=========================================
  Coverage     99.90%   99.90%
  Complexity     2687     2687
=========================================
  Files           256      256
  Lines          6524     6524
  Branches        420      420
=========================================
  Hits           6518     6518
  Misses            5        5
  Partials          1        1

Flag
Coverage Δ

sql-engine
99.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89f4642...2351896. Read the comment docs.


Update tooltip for version update action

Summary
Add more detail to the update-component-version github action to clarify that version input should not include a v prefix:
YES: 1.2.3
NO: v1.2.3
Details and comments

Hahahaha thank you @psschwei


Updating data model with new client suggestions

DOD:
QR code on planting and boxes (Planting public facing, boxes for registration)
Add phone number to profile
Move picture from profile to planting
change all "site" language to "planting"
Add email to profile
Add organization type to profile
Possibly add location type (Church, farm, school, etc) to planting


Add sleep to fix lag in chat stream

Description
This is a fix for a bug which I identified while attempting to use Chat Stream from within a thread. Adding a sleep within the loop unblocks the thread allowing the chat to stream as expected.
Without this fix, each iteration severely hangs.
Type of Change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
This has been tested within my application which uses llamaindex. My application runs in a separate worker thread which runs properly with all other streaming agents outside of llama index. When I use chat_stream with llama index, it hangs. This code fixes the issue.
Suggested Checklist:

[x] I have performed a self-review of my own code
[x] My changes generate no new warnings

@w4ffl35 I'm not 100% this fixes anything? Both with and without this fix the behaviour seems the same. See the test code here
https://github.com/run-llama/llama_index/issues/10290#issuecomment-1922538649
Maybe I'm using flask+streaming wrong though

@logan-markewich did you test with threads?
If the loop enters the continue line after the exception it will lag severely in a loop. I experienced it and lost hours debugging. Adding the sleep fixes it - you can see similar solutions employed in the huggingface workers in transformers for the same reasons as outlined in their commits (which I have since switched to).


Bug 2000276: EncryptionStateControllerDegraded: failed to get converged static pod revision

It turns out that when a node dies or is disconnected from the rest of the cluster, Kubernetes (kubelet) applies a policy for setting the phase of all Pods on the lost node to Failed.
Pods in the Failed state cannot transition back to Running state.
In addition, failed Pods are note GC'ed. The API objects remain in the cluster's API until a human or controller process explicitly removes them.
Thus we need to tolerate pods in Succeeded or Failed phase only if their revision <= the running pods. Otherwise, we won't make any progress.
See the following for more:
https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/
https://bugzilla.redhat.com/show_bug.cgi?id=2000276

/assign @sttts

/reopen
/remove-lifecycle rotten

/bugzilla refresh

I will address the concerns I raised in a follow-up PR.
/lgtm


macOS can't connect from client to server

I am starting server (work fine on both: Editor and macOS standalone), but after that I can't connect from client to it.

have you changed  ServerNetworkSystem.MaxPlayers?

@RomanZhu no, I didn't change this value


[Engine] Ray actor scaler during runtime

Data could come in at peak throughout the day, and the stream size in Redis may grow indefinitely, outpacing ray-consuming speed and eventually breaking the application. It's imperative to provide scaling for actors (internal operator), then the autoscaler from Ray will handle the rest (pod scaling)
This issue tracks the creation of a new Ray Actor that manages the creation and destruction of actors during runtime.

Closing in favor of our movement to Flink (built-in support is provided).


Update README.md for the Java Voice Assistant quickstart and fix broken links

@jhakulin please review. I fill remove the "en-us" in the docs.microsoft link in a new PR. Thanks!

@jhakulin please review. Thanks!


BinaryOperatorSpacesFixer - extend examples

it was asked on gitter, does it make sense to add it here? https://gitter.im/PHP-CS-Fixer/Lobby?at=6023da1a428d9727dd69566c

Coverage increased (+0.005%) to 91.934% when pulling f581c7928d8cc240882adfcac339476e0266f62a on keradus:2.18_BinaryOperatorSpacesFixer_examples into 54570cd248e37aace9462d9970d2b00e8b5ee2d9 on FriendsOfPHP:2.18.


chore: more unused variables

#17715

bors d+
Thanks!

Thank you for your comments!
bors merge


List Batches Page

(right after I login), When I want to able to see a list of all the current batches so I can pick then batch that I want to monitor.
Create a page below and use the endpoint developed on the issue to show the list https://github.com/HackYourFuture-CPH/FP-class11/issues/188

Please fix the border of the List Batch Table. When we have the mouse over the edges should remain round.

Hello Daniel I see the table with round borders


Allow editing event's slugs (URL)

Events are the only type of profile for which we do not allow changing the slug.

This was asked at, https://opencollective.freshdesk.com/a/tickets/323616

Just wanted to do this again (as I'd initially incorrectly put 19 Feb for this event, but it's actually 4 Mar https://opencollective.com/united-diversity-bridport/events/mmmm-monday-19-feb-movie-dorset-premiere-six-inches-of-soil-meal-and-mingling-bdaac114 ). I've edited it, but of course the URL still has the incorrect data included.
I also just spotted that it still shows the old date data in the little drop down menu thing in the top left here too:

Just hit this again. Please add this feature. Thank you.

This has been requested via Discord.


dumpcore on OpenBSD: provide a stub (copied from ukvm_dumpcore_kvm_aarch64)

I tried to compiled solo5 on OpenBSD and ran into trouble, this is the minimal fix I could come up with.

@ricarkol can you please merge? I'm offline for the rest of today.

Thanks @hannesm, merging.


Fix docs footer gradient by removing pointer events

How I discovered this bug:
I was quietly reading the documentation, when suddenly, I scrolled to the bottom of the page to activate the dark theme, but when I clicked nothing happened, so I went back up a bit and then it worked, I then noticed that on the Footer gradient there was no "pointer-events: none" to avoid this kind of problem, so I then added one using Tailwind
Screenshot:

Thank you for filing the issue! It's possible that we should instead fix the ordering to prevent this problem. We'll take a look!

Took a quick look, this is overlapping the theme selector in the nextra nav, so we would need to address the ordering on that side. Going to merge this for now since it's a reasonable approach to fixing an annoying issue. Thanks for finding @AntoineKM!


fix(article): table with data double quotes

Problem:
In the table if in some cell consist of char ( " ), then it will be removed.
linked PR: #368
For ex:
actual data :- project"tahiti
data display to user :- project tahiti

Additionally, if any table data is separated by ' instead of ",", it will fail.


Drop npm-cache

Buck itself is very good at handling caches. What we can do is to introduce two new rules: bower_dep and npm_dep which would represent bower/NPM packages.
Build rule for those rules would simply download the package from the internet and that's about it. Later on then ps_module would be build from those modules + purs and js files.
Issues:

Bower conflicts - I've seen it already: Library A depends on<EMAIL_ADDRESS>while lib C depends on<EMAIL_ADDRESS>which version should we use? If we just merge bower_components together that then have to define the rules how
Inconsistent cached dependencies - library A depends on B version ~1.0.0. On moment T1 it will be resolved to 1.0.1, on moment T2 it may be resolved to 1.0.2 e.g. our CI server may still use old version, while newer one will be used locally

Idea: We download everything, and lock version for each of the dependencies.
Imagine we would like to have a library A which depends on bower modules<EMAIL_ADDRESS>and<EMAIL_ADDRESS>which in turn depends on D@*
First we introduce bower dependencies:
bower_dep('B','1.0.1') # We lock the specific version
bower_dep('C','2.1.6')
bower_dep('D','1.2.1`) # We have to define all deps, including transitive one

Now we can safely define:
ps_module('A',
                   deps = [':B',':C'])

Nah, looks stupid to force user (and myself) to write down all the existing PS libs, let's think about it.

Packages in npm and bower are mutable, more than that - they can be deleted (left-pad yo). Main philosophy of Buck (and if we are targeting monorepo) - that's everything has to be immutable, so the only thing we can do is store the source in our repo, yep (looks like I'm again solving the problem that doesn't exists but that's OK, I got used to this)
Idea

Store everything that we need in our repo
Build everything from those without any HTTP calls
...
PROFIT

Implementation
Let's imagine hello world example, how I wish that to look:
# ls repo/deps
# BUCK purescript-console purescript-console purescript

# cat repo/deps/BUCK
dep('purescript-console')
dep('purescript')

# cat repo/libs/A/BUCK
ps_module('A',
          deps = 'purescript-console') # By default 'purescript' will be added

How we are going to solve transitive dependencies? Hm, let's imaging we have module B which depends on purescript-console-helpers which in turn depends on purescript-console of some different version:
# cat repo/deps/BUCK
# ... everything from previous example plus
dep('purescript-console-helpers')

# cat repo/libs/B/BUCK
ps_module('B',
          deps = 'purescript-console-helpers')

During build bower.json gonna be parsed and all dependencies would be transformed to location macro with the same name. Meaning purescript-console-helpers would depend on repo/deps/purescript-console which we have already. Which means that each deps wouldn't contain any sub-dependencies, only source + bower.json which would tell us about other dependencies.
Now we got back where we start from - for example for purescript itself we would have to specify 253  NPM dependencies, for average purescript project the number would be around 50.
How we going to update all of those? Some script maybe...
Versions are missing, which is not cool, on the other hand - there has to be one dependency version in the repo (we are talking about monorepo first of all), so it doesn't make any sense to have a version number itself. Could it be that we may want to have multiple versions of the same lib? It's such a rare case...
Actually we can solve this: We would have default library my-dependency and in case we really need it my-dependency-2.0.0-rc1

Looks OK in general, but can't we keep the same level of consistency and move something to runtime, rather than just store files and specify a lot of metadata about it?
Let' back to our console example:

A <- purescript-console-0.1.0
B <- purescript-console-helpers-0.0.1 <- purescript-console-0.0.1
C <- A B

Desired result should be:
C <- A B purescript-console-helpers-0.0.1 purescript-console-0.1.0, meaning explicit dep should win.
Really? Should it? If something is not-defined like in this case then we should fail I guess (same as bower does). Otherwise we may eventually install library X which depends on purescript-console-8.0.0 but continue to use explicit (but wrong) old version of the lib.

OK, here final design.
# cat repo/deps/BUCK
# Following content is generated

dep('purescript 0.9.1',
    ['async-each-series 1.0.0',
     'bin-build 2.2.0',
     'bin-wrapper 3.0.2',
     'logalot 2.1.0',
     'to-executable-name 1.0.0'])

dep('purescript-prelude 1.0.0')
dep('purescript-eff 1.0.0', 'purescript-prelude 1.0.0')
dep('purescript-console 0.1.0', 'purescript-eff 1.0.0')

By default dep function will create two targets: [name] [version] and [name]. Idea that all our custom code would depend on [name], without any specific versions. In case we need to update the library we would do in one place only, there would be no need to update all our custom modules for that. In case we really want to have multiple versions:
dep('purescript-prelude 1.0.0') # By default version-less alias target is created
dep('purescript-prelude 0.9.1',default=False)
dep('purescript-prelude 0.8.1',default=False)
dep('purescript-prelude 0.7.1',default=False)

There would be a chance for conflict, but that's OK - it's gonna be rarely used and usual case is safe.
Our custom code:
# cat repo/lib/A/BUCK

# Default purescript and purescript-console dependencies are used
ps_module('A','purescript-console')

Following dependency chain would be generated:
A <- purescript-console <- purescript-console 0.1.0 <- purescript-eff 1.0.0 <- purescript-prelude 1.0.0

Here the plan how we going to implement it:

[ ] Metadata generator: Input as a list of dependencies, output - BUCK file + downloaded sources
[ ] Tune up a bit build process
[ ] Tests

BTW repo/deps folder is a good candidate for pushing it to separate repo. Git submodules should be good for those


[QUERY] - How to use cloud-init with the ResourceManager or Fluent SDKs

Query/Question
Hi!  Today I am using Fluent to create VMs in my app's deployment validation process.  I would like to create VMs and use a cloud-init script with them.
There are plenty of examples of doing this using the az cli but I haven't found an example of how to do this with any of the dotnet SDKs.
Environment:

Name and version of the Library package used: [e.g. Azure.Storage.Blobs 12.2.0]
Hosting platform or OS and .NET runtime version (dotnet --info output for .NET Core projects): [e.g. Azure AppService or Windows 10 .NET Framework 4.8] dotnet 6
IDE and version : [e.g. Visual Studio 16.3] VS 2022

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

Figured it out and forgot I'd opened this one.
Answers over here https://github.com/Azure/azure-sdk-for-net/issues/25693


Thanks for this <3

Just wanted to thank you for this cool project! Easy and flawless to install and get started!
Smooth usage and working bug free so far!
Btw is the project name your sneaky coming out on github? xd

I'm glad you like it! :)
The project is actually named after the metrical foot in poetry. I liked the naming scheme used in a lot of Jabber software (e.g. prosody, strophe, scansion, verse, etc.) and decided to follow suit!


mix surface.init error

mix surface.init
I created a new phoenix application and followed the documetation to set up Surface

Add surface to the list of dependencies in mix.exs:
Configuring the project using mix surface.init

I got
== Compilation error in file lib/surface/components/form/field.ex ==
** (CompileError) lib/surface/components/form/field.ex:24: the function "component" cannot handle clauses with the -> operator because it is not a macro. Please make sure you are invoking the proper name and that it is a macro
    (elixir 1.13.1) src/elixir_fn.erl:17: anonymous fn/4 in :elixir_fn.expand/4
    (stdlib 3.17) lists.erl:1358: :lists.mapfoldl/3
    (elixir 1.13.1) src/elixir_fn.erl:23: :elixir_fn.expand/4
    expanding macro: Surface.sigil_F/2
    lib/surface/components/form/field.ex:24: Surface.Components.Form.Field.render/1

The behavior you expected
It should complete without error
Your Environment
Surface: v0.6.1
LiveView: v0.17.5
Elixir: v1.13.1

@shubie you need to be on LiveView v0.16.x

@shubie We are working on the making Surface compatible with LV 0.17. In the meantime, you could try with the following branch: https://github.com/surface-ui/surface/tree/ms-support-lv-0.17


bitcoind: only forget deposit that are really gone

Still trying to reproduce the panic without the patch, but this should at least fix it for master

ACK 799f33b


S3

Big update incorporating object storage support and support for S3.

looks like it is working very well.


Issues with redirects - had to use exit to make it work and blank page

name: Bug report
about: Help us improve the framework by reporting bugs!

Describe the bug
There are two issues with the redirect() method.

I am not able to use return redirect()->to('/'); so I have to follow it up with an exit to make it work. e.g.

public function hello() {
//this won't work;
return redirect()->to('/');
//this works
redirect()->to('/');
exit;
}

The other issue is none of the redirects are working now since approximately after yesterday (17 nov 2018) evening. To make sure, I haven't accidently broken it, I just downloaded a new copy of CI4-develop and after setup I could see welcome message to confirm everything working fine. Then I made these modifications below to the Home controller. If I try mylocalsite/home/daljit it just shows a blank page.

 namespace App\Controllers;

use CodeIgniter\Controller;

class Home extends Controller
{
	public function index()
	{
		return view('welcome_message');
	}

	//--------------------------------------------------------------------
    public function daljit()
    {
        return redirect()->to("/home/hello");
    }

    public function hello()
    {
        echo "Hello!";
    }
}

CodeIgniter 4 version
CodeIgniter 4 develop branch.

Ok, the oldInput changes have been reverted, and the unit tests show that bug.
They do not show any redirect() problems.
@daljit3 Can you confirm that redirect works again, and that the old() bug is back?

Hmm - after setting the baseURL & indexPage properties in App, I get a blank page even for .../home,
although the default home apge continues to work. This may not be a redirect problem at all, but something deeper.
I have looked at the commits over the last week, and don't see what would cause this.
daljit3, when did you last pull the develop branch from the repo, before the most recent one that seems to be problematic?

@jim-parry - no sorry redirect still doesn't work and I kind of rely on redirects to get to edit form page to do the testing for old(). Just for clarification, I updated my local copy again just now.
Also, I seem to have found another issue which wasn't there before but I need to investigate more what this new issue is and why I am getting this exception all of sudden as yesterday it was working. Could it be linked to that redirect issue?
CodeIgniter\HTTP\Exceptions\HTTPException
BASEPATH/HTTP\Exceptions\HTTPException.php at line 106
``

> daljit3, when did you last pull the develop branch from the repo, before the most recent one that seems to be problematic?

I actually update my local copy everyday using git pull and everything except old() bug worked fine.

I can confirm that this issue only started after I did git pull today after seeing your comment that it;s fixed.
I am lucky that I uploaded yesterday's code to our server and went live. I just checked and redirects work fine on my live site.

Very strange.
Now you are getting an exception isnide of the Exception class?
And whatever happened occurred over the last 24-26 hours.
Digging further here too.

Very strange indeed. The reason I am so sure about that it stopped working today is, as I mentioned above, that I published my local site yesterday. My server copy isn't synced to my local as I manually ftp the changes as of now.

@daljit3 I think this should solve both the redirect problem here, as well as the original old() issue.
If you could test, it would be appreciated.

@daljit3 When you call the listErrors() a view is loaded.
You can check if has errors with getErrors() before to load the view.

The redirect issue was caused by my dropping the sendHeaders(), to address a different bug :-/
Solved one but caused another :(

Solution confirmed

@jim-parry hi - it seems like redirects are ending on blank again!! Just updated my local copy today.

You update daily, so they were working yesterday and now not today?

I was working on a different project so I hadn't updated for the past couple of days. I just did and it went blank.

i'm trying to isolate "when" this broke. so, sometime in the last couple of days...

I am looking at #1504, #1505 or #1513 as causing the problem

Okay - if you want me to do any quick tests - I am available here for another hour and half. Please let me know.

The biggest help would be a unit test case that fails when it shouldn't. It is obvious to me that the ones we have now are missing the boat - they are not catching the problem, even I thought we caught it last week. There could be several things happening here.
I believe the relevant tests are in CommonFunctionTest.
Thanks!

I'll look and see if I know how to set that up on my local.
The exception error is back too! :(

I just ran php unit test and I get 105 failures but if I tried vendor\bin\phpunit --filter CommonFunctionTest I get "No code coverage driver is available". I might not have got it config properly?

to run just the one test, vendor/bin/phpunit tests/system/CommonFunctionsTest.php

@daljit3 Please, check if you have the PHP display_error active. And if your \Config\App::baseURL has the scheme (http or https), otherwise it ends in a blank page.

@lonnieezell @natanfelles  @jim-parry
Yes I do have "http" in my .env, app.baseURL = 'http://mylocalsite.dev/'
I think I have found what's causing issue for me.
As mentioned before, return redirect()->to('/'); never worked for me before @jim-parry made some changes the other day. However, I still some places where I have
redirect('/user-home');
exit;

To fix this issue, I have to replace with return redirect()->to('/user-home');
The bizzare thing is that both option worked for me with after @jim-parry fix and it only stopped since I raised this once again.
Here's my quick and dirty test with results on a fresh installation today at 09:30 AM 23/11/2018.
class Home extends Controller
{
	public function index()
	{
        echo "
Hello there!
";
        echo "
";
        echo "
Go to Test 1
";
        echo "
Go to Test 2
";
        echo "
Go to Test 3
";
        echo "
Go to Test 4
";
        echo "
Go to Test 5
";
        echo "
";
	}

    public function test1()
    {
        redirect("/home/login");
        exit;

        //Fails with this error
        /*
            CRITICAL - 2018-11-23 03:23:38 -->
            #0 C:\xampp-7.2.2\htdocs\myproject\system\HTTP\RedirectResponse.php(86): CodeIgniter\HTTP\Exceptions\HTTPException::forInvalidRedirectRoute('')
            #1 C:\xampp-7.2.2\htdocs\myproject\system\Common.php(821): CodeIgniter\HTTP\RedirectResponse->route(false)
            #2 C:\xampp-7.2.2\htdocs\myproject\application\Controllers\Home.php(18): redirect('/home/login')
            #3 C:\xampp-7.2.2\htdocs\myproject\system\CodeIgniter.php(825): App\Controllers\Home->test1()
            #4 C:\xampp-7.2.2\htdocs\myproject\system\CodeIgniter.php(325): CodeIgniter\CodeIgniter->runController(Object(App\Controllers\Home))
            #5 C:\xampp-7.2.2\htdocs\myproject\system\CodeIgniter.php(235): CodeIgniter\CodeIgniter->handleRequest(NULL, Object(Config\Cache), false)
            #6 C:\xampp-7.2.2\htdocs\myproject\public\index.php(45): CodeIgniter\CodeIgniter->run()
            #7 {main}
                 * */
    }
    public function test2() {
        // This test works OK for me
        return redirect()->to("/home/login");
    }
    public function test3() {
        // This test works OK for me
        return redirect()->to("/home/login/?referer=test2");
    }
    public function test4() {
        $refUrl = currentUrlWithQueryString();
        $redirect_to_url = '/home/login/?ref='.$refUrl;

        redirect($redirect_to_url);
        exit;

        /* Failes with this error below

        CRITICAL - 2018-11-23 03:39:20 -->
        #0 C:\xampp-7.2.2\htdocs\myproject\system\HTTP\RedirectResponse.php(86): CodeIgniter\HTTP\Exceptions\HTTPException::forInvalidRedirectRoute('')
        #1 C:\xampp-7.2.2\htdocs\myproject\system\Common.php(821): CodeIgniter\HTTP\RedirectResponse->route(false)
        #2 C:\xampp-7.2.2\htdocs\myproject\application\Controllers\Home.php(52): redirect('/home/login/?re...')
        #3 C:\xampp-7.2.2\htdocs\myproject\system\CodeIgniter.php(825): App\Controllers\Home->test4()
        #4 C:\xampp-7.2.2\htdocs\myproject\system\CodeIgniter.php(325): CodeIgniter\CodeIgniter->runController(Object(App\Controllers\Home))
        #5 C:\xampp-7.2.2\htdocs\myproject\system\CodeIgniter.php(235): CodeIgniter\CodeIgniter->handleRequest(NULL, Object(Config\Cache), false)
        #6 C:\xampp-7.2.2\htdocs\myproject\public\index.php(45): CodeIgniter\CodeIgniter->run()
        #7 {main}
        */
    }
    public function test5() {
	    // This test works OK for me
        $refUrl = currentUrlWithQueryString();
        $redirect_to_url = '/home/login/?ref='.$refUrl;

        redirect()->to($redirect_to_url);
        exit;
    }

    public function login() {
        echo "
Welcome to our Login page! :)
";
        echo "
";
        echo "
Go to Home
";
        echo "
";

    }
}

///---------------- Some helpers -----------------------------------//

function currentUrlWithQueryString($includeBaseUrl=false) {

    $uri = $_SERVER['REQUEST_URI'];
    if($includeBaseUrl == true) {
        $uri = base_url($uri);
    }
    return $uri;
}

You can no longer use .dev for localhost use .local
These changes were made in chrome and other web browsers.

@InsiteFX yes I am aware of that and that's not the issue.

Ah, ok, I see what's going on and looks like docs will take care of most of it. Suggestions after the break:

The redirect() method is built to have the response returned. That is the proper use. So times when you redirect() then exit will never send the actual redirect headers. A blank page is what you should see here.
redirect($url) uses the reverse routing rules to determine the route to go to. You're getting an exception because it's unable to find a route name and/or controller to route to as per the reverse routing needs. That could be cleaned up to provide a better experience. They are there as the default to help with one of the elements that used to be on OWASP's Top 10 list - Unvalidated Redirects and Forwards.

Here's what I see is needed to fix this up:

Update redirect() docs to specify that it's using reverse routing rules (and why)
Potentially provide additional details on the URI Routing page
Look into providing a cleaner, more descriptive error when no matched routing rule exists.

@lonnieezell yes that makes sense however please take a look at this test below ...
It doesn't redirect and just displays the text. The other tests 1 to 5 above still seem to work OK so can't figure out what's going wrong with this one.
namespace App\Controllers;

use CodeIgniter\Controller;

class Home extends Controller
{
    public function test6() {
		redirectIfNotLoggedIn();
		echo "You are here because you are logged in!";
    }
   public function login() {
		echo "You must login first!";
    }
}

///---------------- Some helpers -----------------------------------//
function redirectIfNotLoggedIn($refUrl=null) {
    if($refUrl == null) {
        $refUrl = currentUrlWithQueryString();
    }
    if(isUserLoggedIn() == false) {
        return redirect()->to('/login/?ref='.$refUrl);
    }
}
function isUserLoggedIn() {
    if (session('loggedin') == true) {
        return true;
    }
    return false;
}
function currentUrlWithQueryString($includeBaseUrl=false) {
    $uri = $_SERVER['REQUEST_URI'];
    if($includeBaseUrl == true) {
        $uri = base_url($uri);
    }
    return $uri;
}

You must return to stop the script:
   public function test6() {
		if(isUserLoggedIn() == false) {
				RETURN redirect()->to('/home/login/?ref='.$refUrl);
		}
		echo "You are here because you are logged in!";
    }

@daljit3 See Lonnie's comment

@natanfelles Sorry if I wasn't clear but are you referring to @lonnieezell on my old method of using redirect/exit? I have all the redirects now with the returns.
I am trying to understand why the below isn't redirecting. I am returning in the redirectifnotloggedin();
    public function test6() {
		redirectIfNotLoggedIn();
		echo "You are here because you are logged in!";
    }
function redirectIfNotLoggedIn($refUrl=null) {
    if($refUrl == null) {
        $refUrl = currentUrlWithQueryString();
    }
    if(isUserLoggedIn() == false) {
        return redirect()->to('/home/login/?ref='.$refUrl);
    }
}

To complete: You must return in the Controller method as well. Like the example I gave you.
I used only part of your functions because they do not allow it to be used consistently.

I may be wrong but I am not convinced I need to return from controller too? I mean I expect the redirect to happen when user is not signed in and otherwise just continue.
I can surely achieve that using different logic e.g. the way you suggested i.e. in the controller. However, I need to check that at various diffrent points so I would end up repeated If/Else checks throughout my project or perhaps I will end up writing my own redirect helper.
function my_redirect($url) {
	header("Location: $url");
	exit(0);
}

Yes. It continues, because it returns a RedirectResponse (as the Loonie's comment explain).
It will not exit because if you exit, Filters, etc, are not executed.
You could to use your custom my_redirect() if you want, but this will preclude some of the tasks that the framework does before finalizing the response.

I just feel the correct behaviour is that it should redirect() from redirectIfNotLoggedIn() when the condition fails as it's still being called in from a controller method.

Here's the code in question, right?
public function test6() {
		redirectIfNotLoggedIn();
		echo "You are here because you are logged in!";
    }

While redirectIfNotLoggedIn() does return the RedirectResponse, nothing is ever done with that response in the test6 method. In order for it to work, that redirectResponse that you just got from redirectIfNotLoggedIn() needs to be returned out of the controller, otherwise the headers are never sent to the browser.
At this point, we're dealing with a support issue, and not a bug. If you still have questions, please take it to the forums. I'm only leaving this open to remind us that we have a few things (listed above) that we need to take care of.

Yes understand. Thanks

@daljit3 Are you using "php spark serve" for local development and do you have a filter (FilterInterface) in your code? I'm going on a hunch here.

Hi, I'm currently migrating my old CodeIgniter code.
I also encounter this issue today.
The redirect() won't work if there's no exit() after it.  return redirect() is also not working.
Just wanted to say that it worked without exit() in the old CodeIgniter.

Well - this isn’t old CodeIgniter so that parts not helpful :)
We’ve gone over and over this and I’m pretty sure it’s solid at this point. Can you provide a code sample?
If I had to take a blind guess it’s that you’re trying to redirect out of a controller constructor and that doesn’t work any longer. You should check out Controller Gilters in the docs.

experiencing this problem too.

I may be wrong but I am not convinced I need to return from controller too? I mean I expect the redirect to happen when user is not signed in inside redirectIfNotLoggedIn() method and otherwise just continue.
I can surely achieve that using different logic e.g. the way you suggested i.e. in the controller. However, I need to check that at various diffrent points so I would end up repeated If/Else checks throughout my project or perhaps I will end up writing my own redirect helper.
function my_redirect($url) {
	header("Location: $url");
	exit(0);
}

this worked for me!

experiencing this problem too.

I may be wrong but I am not convinced I need to return from controller too? I mean I expect the redirect to happen when user is not signed in inside redirectIfNotLoggedIn() method and otherwise just continue.
I can surely achieve that using different logic e.g. the way you suggested i.e. in the controller. However, I need to check that at various diffrent points so I would end up repeated If/Else checks throughout my project or perhaps I will end up writing my own redirect helper.
function my_redirect($url) {
	header("Location: $url");
	exit(0);
}

this worked for me!

Hi. In this case you may use Filters. See that example https://www.patreon.com/posts/visit-logging-27277581

experiencing this problem too.

I may be wrong but I am not convinced I need to return from controller too? I mean I expect the redirect to happen when user is not signed in inside redirectIfNotLoggedIn() method and otherwise just continue.
I can surely achieve that using different logic e.g. the way you suggested i.e. in the controller. However, I need to check that at various diffrent points so I would end up repeated If/Else checks throughout my project or perhaps I will end up writing my own redirect helper.
function my_redirect($url) {
	header("Location: $url");
	exit(0);
}

this worked for me!

Hi. In this case you may use Filters. See that example https://www.patreon.com/posts/visit-logging-27277581

The redirect functions were not working. thats wat i needed, the filters will not do.
what i want:
in my admin controller i use a library with some checks. it wil update my routes file and will redirect me to the admin controller again from within my library. Here the redirect->to(current_url()) is not working and it just keeps executing the code but it should redirect with a refresh to the same url.
adding this works:
header("Location: ".current_url());
exit(0);

You who are having issues still, are you remembering to return the result of redirect()? And also not using it in the controller constructor? If you really really can’t get it to work a better alternative to the “header...exit” code above would be to throw a RedirectException, has a slightly nicer cleanup:
https://codeigniter4.github.io/CodeIgniter4/general/errors.html#redirectexception

I'm having issues with this as well int the latest version...
It seems like redirect()->to(url) doesn't do anything

I am facing the same problem. Can this be an issue related to .htaccess?
Options +FollowSymlinks -Indexes
RewriteEngine on

DirectoryIndex index.php
RewriteCond $1 !^(index\.php|resources|robots\.txt)
RewriteCond %{REQUEST_FILENAME} !-f
RewriteCond %{REQUEST_FILENAME} !-d
RewriteRule ^(.*)$ index.php/$1 [L,QSA]

As mentioned above, this is the only solution that works:
  header("Location: displayProfileView");
exit(0);

See https://codeigniter4.github.io/CodeIgniter4/general/common_functions.html#redirect

@daljit3
I also faced the same issue, but i was able to solve it . i belive it an  mistake in the routes file or the redirection url.
try changing it like(removing the '/ ' before view file or  try 'home/hello'.


Rework child Widget tracking

Right now the framework only gives a children_changed() method when a Widget has changed its data in a way that adds or removes children.
Instead, it should provide three methods:

child_added()
child_stashed(bool)
child_removed()

These methods should update semantic information in the widget tree, eg:

The focus chain
Active status, pointer capture (see linebender/xilem#379)
Keyboard focus

(Obviously, we'll need to add lots of unit tests for all that)

This is mostly superseded by the Pass Spec RFC.


disruptions.md replicaset.md service.md replicationcontroller.md update

NOTE: Please check the “Allow edits from maintainers” box (see image below) to
allow reviewers to fix problems on your patch and speed up the review process.
Please delete this note before submitting the pull request.

This change is

/unassign @madhusudancs @bprashanth
/assign chenopis


Is simde_mm512_load_ps missing?

Hi,
thank you very much for this cool library.
I noticed that simde_mm512_load_ps is missing while simde_mm512_loadu_ps is implemented. However, both seem to exist for Intel intrinsics (see screenshot). Maybe I oversaw one or maybe they do the same anyways?
Thanks
Lukas

This was fixed in https://github.com/simd-everywhere/simde/commit/d5880491cc07564a01f840b580d59701a51bb082


Download Sections Issues

There seems to be an issue with sections, I tried this video with Sections 1:20 to 1:40
https://www.youtube.com/watch?v=CduA0TULnow
the mp4 seems to be 20 secs only but when opening in video player 4 min are shown:

Secondly when selecting "Convert audio to MP3" to download only 20 secs audio, the mp3 is not cut but 4:12 min long.

I was not able to reproduce this. I got a few seconds extra (due to the cuts not being at keyframes), but I didn't get the entire length of the video. I tried with the versions of yt-dlp and ffmpeg that are packed with v2.4.0, and also with the latest versions.
Do you see --download-sections *1:20-1:40 in the command line? If so, then whatever is happening is probably not the program's fault.

Issue is no longer reproducible. works as expected for video and mp3. thank you for your support.


[pdb] PDB's for Chrome.dll from supermium_122_r3_portable_32.exe

Where can I get PDB for Chrome.dll from supermium_122_r3_portable_32.exe ?

And where to get supermium_122_r3_portable_32.exe from? @IDA-RE-things It is not visible for me on official Releases page. Is there a place where to get such inofficial early-builds?

No, its not official. I just wonted to test it for changes.
The link I cannot give without permission, sorry for this.

And where to get supermium_122_r3_portable_32.exe from? @IDA-RE-things It is not visible for me on official Releases page. Is there a place where to get such inofficial early-builds?

https://patreon.com/win32


Change references from labs to hyperledger

Change references from hyperledger-labs/fabric-private-chaincode to hyperledger/fabric-private-chaincode in documentation and code.
Note that github automatically reroutes request to hyperledger-labs/fabric-private-chaincode to hyperledger/fabric-private-chaincode already. Still, documentation should be updated asap.

go includes must also be updated

go includes must also be updated
working on this

Fixed with #576


Performance and resource utilization benchmark

uwsgi
gunicorn
vs hurricane
(ram, cpu, startup, RPS (requests per seconds), etc.)


update readme link to use same case as file path

Fixes Issue #1428
Proposed Changes
Update the casing in the ReadMe to match the casing of the file path. Locally, the link navigation works locally regardless of case, but on remote, it returns 404 not found if the case does not work.
Testing
N/A

@ericksoen thank you for the PR.  This issue has been addressed in a previous PR that was merged.


URDF file '/data4/mdv0/cabinet/0007/part_objs/cabinet_0007.urdf' not found

Hi Fei Xia,
Could you please let me know where is the URDF file? I am trying to execute command
python cabinets_example.py
But it looks like that it missed URDF file

This example has been deprecated. Thanks!


Hotsar Clone[HACTOBERFEST 2023]

Description
Hello Sir👨💻 ,I am Arpan Chowdhury, a aspiring Web developer.🤖 Here is the project of the front-end Web Developement. We all use the most famous streaming platform HOTSTAR. So, here is the frontend clone of the landing page👆🏻 .
ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

I have added my PR . Please take a review & merge my PR under HACTOBERFEST 2023.

@debrajrout lease take a review & merge my PR under HACTOBERFEST 2023.


ERC1155 module support

Add ERC1155 Puppet as a module as well as ERC20 and ERC721
ERC20: https://github.com/latticexyz/mud/tree/main/packages/world-modules/src/modules/erc20-puppet
ERC721: https://github.com/latticexyz/mud/tree/main/packages/world-modules/src/modules/erc721-puppet

you're in luck: https://github.com/latticexyz/mud/pull/2198


Allow passing commit reference in app deploy command

WHY are these changes introduced?
Fixes https://github.com/Shopify/app-deploys/issues/436

WHAT is this pull request doing?

Add the source-control-url to the deploy command
Include the value of the flag in the App deploy API request

How to test your changes?

Enable the beta app_unified_deployment in partners internal
Run this deploy command with at least one extension  pnpm shopify app deploy --path --source-control-url wrong-url --no-release

Run this deploy command with at least one extension pnpm shopify app deploy --source-control-url https://github.com/user/repo/commit/1c41f47d41bbbbdfa15c1970fd798d860390130d --no-release

Measuring impact
How do we know this change was effective? Please choose one:

[ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
[ ] Existing analytics will cater for this addition
[ ] PR includes analytics changes to measure impact

Checklist

[ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
[ ] I've considered possible documentation changes
[ ] I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@ani-shopify  @andy-schneidr I have added a validation when users try to run the command using the legacy mode and the new flag --source-control-url because it seems it's not supported in the backend and generates an unexpected error. This is the error message displayed in that case

I wonder if we should handle this use case in the backend as well, because this is the error returned by the appDeploy partners API request

I have added a validation when users try to run the command using the legacy mode and the new flag --source-control-url because it seems it's not supported in the backend and generates an unexpected error.

This sounds similar to another issue that occurs when running the command with the --message value but the deployments beta flag isn't enabled. (GH Issue link) After talking with @ani-shopify about it, we're feeling that this is something we can fix post-Editions, or once the rest of the items on our board leading up to Editions are done.
I could create another ticket for this or add this as a task for the linked ticket ☝ let me know what you think!

I have added a validation when users try to run the command using the legacy mode and the new flag --source-control-url because it seems it's not supported in the backend and generates an unexpected error.

This sounds similar to another issue that occurs when running the command with the --message value but the deployments beta flag isn't enabled. (GH Issue link) After talking with @ani-shopify about it, we're feeling that this is something we can fix post-Editions, or once the rest of the items on our board leading up to Editions are done. I could create another ticket for this or add this as a task for the linked ticket ☝ let me know what you think!

Hi @andy-schneidr. I agree with you that a new issue could be created and in the meantime we could handle this condition in the CLI. Please, add to the issue removing this CLI verification.

It would be good to specify which flag: "The `source-control-url` flag is not supported for this app."
Once we have final alignment on the feature name, I do think it would be nice to update this message to: "The `source-control-url` flag is not supported for this app. Upgrade this app to Deployments 2.0 to add a source control url."

I wasn't able to 🎩 this as I ran into an issue running CLI commands:
?  Which Partners organization is this work for?
✔  Partner 1

Before you preview your work, it needs to be associated with an app.

?  Create this project as a new app on Shopify?
✔  No, connect it to an existing app

?  Which existing app is this for?
✔  test-experimental

╭─ error ──────────────────────────────────────────────────────────────────────╮
│                                                                              │
│                                                                              │
│    The Partners GraphQL API responded unsuccessfully with the HTTP status    │
│  200 and errors:                                                             │
│                                                                              │
│    [                                                                         │
│    {                                                                         │
│      "message": "Unexpected system error",                                   │
│      "extensions": {                                                         │
│        "code": "500",                                                        │
│        "debug": {                                                            │
│          "message": "Failed.  Response code = 502.    Which Partners organization is this work for?
✔  Partner 1

Before you preview your work, it needs to be associated with an app.

?  Create this project as a new app on Shopify?
✔  No, connect it to an existing app

?  Which existing app is this for?
✔  test-experimental

╭─ error ──────────────────────────────────────────────────────────────────────╮
│                                                                              │
│                                                                              │
│    The Partners GraphQL API responded unsuccessfully with the HTTP status    │
│  200 and errors:                                                             │
│                                                                              │
│    [                                                                         │
│    {                                                                         │
│      "message": "Unexpected system error",                                   │
│      "extensions": {                                                         │
│        "code": "500",                                                        │
│        "debug": {                                                            │
│          "message": "Failed.  Response code = 502.   I'm not able to reproduce this problem either using this branch or deployments-for-3-48 or the experimental version.
I have tested against productions services and a fresh spin instance spin up partners
Your error is different than @darius-gai 's one. Your is thrown in the operation FindApp and Darius's in the DeployApp.

Hi @ani-shopify. I'm not able to reproduce this problem either using this branch or deployments-for-3-48 or the experimental version. I have tested against productions services and a fresh spin instance spin up partners Your error is different than @darius-gai 's one. Yours is thrown in the operation FindApp and Darius's in the DeployApp. Could you confirm me your test environment?, CLI version or branch, spin vs production. If you are stuck with this issue I'd glad to arrange a pair session with you to check it live.

After taking a look with @isaacroldan , it seems that it's a temporary error accessing the spin instance (502 bad gateway). It's the same error that @darius-gai run into, in fact, as I mentioned, the errors comes from different operations.

Hmm, I was using a local version of CLI against a spin instance. Let me make sure everything is running and try again.
But I don't think @darius-gai was using a spin instance.

Hi @ani-shopify then this PR is ready to be merged?, could you approve it?


X in first box #41

Created two buttons so that player can choose which would go first when reset.

Hi @Ravi-takhi Can you have a look on this please?


Couldn't find a pure Python 3 wheel for 'datasette==0.63'

I'm getting this error on https://lite.datasette.io/ right now:
  File "/lib/python3.10/site-packages/micropip/_micropip.py", line 286, in add_requirement
    raise ValueError(
ValueError: Couldn't find a pure Python 3 wheel for 'datasette==0.63'. You can use `micropip.install(..., keep_going=True)` to get a list of all packages with missing wheels.

Since I made this change:
https://github.com/simonw/datasette-lite/blob/44921283c0ef85e7ee7bab6dd6dc75798ffa9cc5/webworker.js#L60

I used DevTools to see what it was doing - it hits this endpoint:
https://pypi.org/pypi/datasette/json
Which includes:
  "urls": [
    {
      "comment_text": "",
      "digests": {
        "md5": "90bfebb34399f5d1207b76c4d99facab",
        "sha256": "e64027e075887ba07c88b32090d766eda5dd4812aebd97ee81b6bf050647fa5c"
      },
      "downloads": -1,
      "filename": "datasette-0.63-py3-none-any.whl",
      "has_sig": false,
      "md5_digest": "90bfebb34399f5d1207b76c4d99facab",
      "packagetype": "bdist_wheel",
      "python_version": "py3",
      "requires_python": ">=3.7",
      "size": 231407,
      "upload_time": "2022-10-27T22:22:18",
      "upload_time_iso_8601": "2022-10-27T22:22:18.246739Z",
      "url": "https://files.pythonhosted.org/packages/89/fc/990486156c87bc86fd776b908b24c95f4d3ae4d7167c2784fe845ea42d43/datasette-0.63-py3-none-any.whl",
      "yanked": false,
      "yanked_reason": null
    },

That looks correct to me though.

I'll try reverting to just datasette.

Weird. https://lite.datasette.io/#/-/versions after a force refresh works, but shows 0.62.
But on my laptop serving the same codebase I got 0.63.
I think it's probably a weird caching bug. I'll leave it a few hours and see if it heals itself.

It was caching. Tried https://lite.datasette.io/#/-/versions in Safari and got 0.63.


Why an error occurs "Cannot read property 'nameMethods' of undefined"?

My main.js:
`import router from './router'
import VueYandexMetrika from 'vue-yandex-metrika'
Vue.use(VueYandexMetrika, {
id: 46481307,
env: process.env.NODE_ENV,
router: router,
clickmap: true,
trackLinks: true,
accurateTrackBounce: true,
webvisor: true,
trackHash: true
})`
My components:
mounted () { 	if (this.isNewUser()) { 		this.$metrika.reachGoal('registration') 	} }
Result:
Error in mounted hook: "TypeError: Cannot read property 'reachGoal' of undefined"
If you set the timeout, then everything works. How can I fix this?

Hey.
I apologize for such a late reply :(
If this is still relevant: checked with the new version, everything works fine.

My code:
mounted() {
  this.$metrika.reachGoal('test-goal')
}

If you still have an error (with a new version) and want to fix it, please provide simple repo\fiddle.


DG CalendarEntryList desc improvements. I reordered some stuff too

Merge this first cuz reordering

Codecov Report

Merging #341 (d79ab1f) into master (338fda7) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #341   +/-   ##
=========================================
  Coverage     68.50%   68.50%
  Complexity     1127     1127
=========================================
  Files           136      136
  Lines          3858     3858
  Branches        523      523
=========================================
  Hits           2643     2643
  Misses          985      985
  Partials        230      230

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 338fda7...d79ab1f. Read the comment docs.


[test] Remove repo-setup from edpm

This will be made optional later

This was trying to troubleshoot and workaround an issue that was ultimately due to some missing pre-req jobs in my pipeline.