Wrong result when number is exactly 1 million or 1 trillion

1000000 should be 1M not 1000K
also
1000000000 should 1T not 1000M

I rewrote this in php, here's a gist for it: https://gist.github.com/polyamide/54397a009f17e633c07e345980fd1420


Create attribute set note__image to store attributes for note image

Create and use attribute set to reuse attributes for note icon.
Signed-off-by: Jake Bourne<EMAIL_ADDRESS>Description
Add attribute set for note icon attributes.
Motivation and Context
Allow attributes for note icon to be reused on different tags.
Fixes issue #3529.
Type of Changes
Reusability of common attributes.

Bug fix (non-breaking change which fixes an issue)

Documentation and Compatibility
No update to documentation necessary.
Backwards compatibility is maintained.

LGTM, thanks for the contribution

LGTM, thanks for the contribution


Azure Core AMQP Copper Improvements

Improvements for AMQP
Stress (Long-Running)

[ ] #23953
[ ] #23954

Diagnosability/Troubleshooting Improvements

[ ] #20836
[ ] #20837

[ ]  #3806

[x] #25114
[ ] #25115
[ ] #25605

Long-term Maintainability Features

[ ] #19221

[ ] Migrate Service Bus processors
[ ] Migrate Event Hubs processors

[ ] #5478

@lmolkova could you edit / add your Structured Logging work item(s) to this checklist and epic for better tracking?

I also added metrics work item into this list as something that would help customers to detect issues and give us more context on what/when happens and slice & dice it.

This issue is covered by the project: https://github.com/Azure/azure-sdk-for-java/projects/13


Make wget indempotent

This wget call used to download to csf.tgz.1 when called more than once - fixed

Thanks for this!

Actually, any chance you want to change the wget command to a get_url command in Ansible?

Thanks for this, ended up doing it as a separate PR though!

Cool, nice that you're still working on this role. I was going to do that but distractions happened.


[Bug]: When routing client-side  doesn't update SEO Meta Tags

Which Remix packages are impacted?

[ ] remix (Remix core)
[ ] create-remix
[ ] @remix-run/architect
[ ] @remix-run/cloudflare-workers
[ ] @remix-run/dev
[ ] @remix-run/express
[ ] @remix-run/netlify
[ ] @remix-run/node
[X] @remix-run/react
[ ] @remix-run/serve
[ ] @remix-run/server-runtime
[ ] @remix-run/vercel

What version of Remix are you using?
1.0.6
What version of Node are you using? Minimum supported version is 14.
v14.17.1
Steps to Reproduce

Create 2 routes, the First route should go to Second route and viceversa.
In each route export a MetaFunction with its corresponding metadata.
Run the application and move from one route to another.

If you want to check it out, you can go to https://crypto-remote.com and test it, but for easy check I've uploaded a video showing the issue:
https://user-images.githubusercontent.com/7697196/145892958-ec94a29c-4a72-4839-8a8f-1b0647f07021.mp4
Expected Behavior
When routing from one page to another if metadata is different it should be updated accordangly. Currently metadata only gets updated if I perform a full page reload.
Actual Behavior
When routing from one page to another metadata isn't getting updated.

It seems like there's a  Tag that is not rendered / managed by React. For html nodes that are handled by React you should see properties like this:

The first title does not have these properties, so my guess would be that this  tag is rendered by inserting a raw string into the markup, not by means of React.
This would explain why the initial load works but subsequent navigations do not (because React is unaware).
Just a guess

It seems indeed that there are two titles on the page, and one is not managed by remix.
Closing this for now, please provide a small reproduce case as a repo is you still think something is wrong with remix.


Upgraded to the latest transformime and associated transformers

Ran into some issues with API changes and new packages (did https://github.com/nteract/transformime-jupyter-transformers/pull/7 along the way). Adapting to promises was interesting.
I wouldn't merge this yet because I don't think it's completely friendly to upstream users. :wink:
Working though, fully updated!

/cc @jdfreder

No more WIP tag on this one. :smile:
While I was at it I fixed and tried out fromJSON and toJSON (which actually works with Objects but I digress).
jda = document.querySelector('jupyter-display-area');
data = JSON.stringify(jda.toJSON());
jda.clearOutput();
jda.fromJSON(JSON.parse(data))

:tada:


Switch only showing from 0-A

Hi there and thank you for your work.
I noticed the new Zelda game isn't showing on my calendar.
I noticed the link used only shows games from 0 to A.
Is this an issue or am I doing something wrong?
Thanks again

Fixed in 8e7506efaca8cb2d806d16be7782000e8a5b936a. Thank you very much for your feedback!


App restructure

1. Overview
Cleanup to make app.go easier and more similar to cleaner upgrades and keeper

upgrades/ directory to hold various chain upgrade functions
keepers/ dir to hold all keeper creation, just moved keeper defination from app.go to keeper and another struct to be passed to upgrades.
Note: Core logic for is just moved to new structure, not much refactor.

2. Implementation details

Create new packages for keeper and upgrades and add uniform process of writing upgrade handlers
Refactor code

3. How to test/use

Run app in previous version, stop the node and start the chain with this version, there should be no breaking changes

4. Checklist

[ ] Does the Readme need to be updated?

Please merge the branch at your convinience, since I dont have the access to merge this branch anymore


Updating Formatting According to WILDS Guidelines

Description
Performing a slight structural revamp of this repository in preparation for the WILDS WDL go-live to align with WILDS guidelines. Also needed to slightly modify the script functionality to operate properly within the context of Docker containers. The major updates are as follows:

Adding governance and template files according to Scott's templates
Updating WDL script formatting according to WILDS guidelines
Adjusting the tasks to use Docker containers instead of Rhino modules
Switching from a directory to a tar file for the STAR reference genome
Adding WOMtool validate GitHub Action to execute as a check during every pull request

Also added parameter_meta sections per Ted's suggestion to spell out all of the inputs/outputs just in case!


Issue with sphinx theme on RTD

Back to the 90s: http://spectral-cube.readthedocs.io/en/latest/

Oh 👨  ... this makes my 👀  :hurtrealbad: !

Also, there's no search field ... makes it really hard to find something.
Can one of you please fix or should I have a look?

@cdeil please have a look - I don't know what broke, but spectral-cube originally used the astropy theme.  Something changed in the past ~year.


Tile color rendering incorrectly maps mins/maxes when min bin is non-zero

Specifically regarding these two lines in DoublesImageRenderer
If the min bin value is 0 the color ramp range is mapped correctly. If the min bin value is non-zero the min/max range against which values are transformed into colors is incorrect because it assumes a 0 minimum. The problem becomes more confusing (to the end user) if the rangeMin is set > 0. I believe the lines in question should read:
double scaledLevelMinFreq = t.transform(minimumValue) + (t.transform(maximumValue)-t.transform(minimumValue))*rangeMin/100;
double scaledLevelMaxFreq = t.transform(minimumValue) + (t.transform(maximumValue)-t.transform(minimumValue))*rangeMax/100;

This is most apparent when bin values range into negative numbers.

I'm not understanding something here.
If I understand what you are doing here, you are implementing an unstated assumption that the transformers transform to [0, 1] into the renderer.
This wasn't the intent of the transformers - they are supposed to embody a comprehensible, simple mathematical transformation.
I would expect the fix to this problem to be just in the renderer, without having to touch the heart of the transformers (though perhaps it would require adding a getMinimumValue method to them)

My understanding is the gist of transformation is to map from input space to output space. Generally this means mapping from a numeric range [min,max] to a color ramp. [0,1] is a convenient generic output range that can be translated into any output (e.g. color ramp) with ease.
The existing linear transformer does map to a [0,1] output here
Also, this is derived from ApertureJS's concept of Range and Mapping constructs where Ranges map an arbitrary input set (numeric or otherwise) to an output set, generally [0,1].

Also, the log transformer is also mapping to [0,1] given an input in [1,supplied max].


Make ssh port forwarding secure the process so only chef-client can talk to it

When you port forward from the remote machine to the chef-zero server, any process on the remote machine can connect back.  See if there is a way to lock that down.

Any reviews ?


typo

expections -> expectations
I'm not sure where the other changes came from, I just clicked edit this file on GitHub and added ta

Thanks, but the PR should be send to https://github.com/rbind/yihui. This repo was forked from there.
Other changes were due to the fact that this repo's commits were behind the upstream repo. When you want to edit a page, you should do it directly from the menu "Edit this page" on my web pages, e.g. https://yihui.name/knitr/

submitted in the other repo. sorry for the noise.


Created a CODE_OF_CONDUCT.md file

Fixes: #17 Adding a Code of Conduct file

@shikharcodes Do not commit the changes I suggested as it is by clicking on :

it would create a lot of commits. Make all the changes in one commit

@shikharcodes Do not commit the changes I suggested as it is by clicking on :

it would create a lot of commits. Make all the changes in one commit

Yes, I'll do all the changes collectively by editing the file and then raise a single pr commit @kaustubhgupta

Yes, I'll do all the changes collectively by editing the file and then raise a single pr commit @kaustubhgupta

I've made the changes @kaustubhgupta and raised a commit. Also, do I have to click on resolve conversation buttons too where you have requested changes?

I've made the changes @kaustubhgupta and raised a commit. Also, do I have to click on resolve conversation buttons too where you have requested changes?


UI - Show proper error message to user when tool creation fails.

Steps to reproduce the problem:

Try to create new tool  with tool name having uppercase like

This results in tool creation to fail and 422 post error notification pops up.
Expected Behavior:
Provide a proper error message to user indicating what the problem is.

Looks like a duplicate of #502
@sangee2004 - can you close this if that is the case?

Closing this issue .
There is no name that needs to be entered when registering a tool now and #502 covers the error handling part of this issue.


Grammar

There were the following issues with your Pull Request

Commit: 2843c971b107e2ad4f8bf387df46a4ea46e229bc
Commits must be in the following format: %{type}/%{scope}: %{description}

Guidelines are available at https://github.com/autumnai/leaf/blob/develop/CONTRIBUTING.md#git-commit-guidelines

This message was auto-generated by https://gitcop.com

Thank you! :+1:

@homu r+

:pushpin: Commit 2843c97 has been approved by hobofan

:zap: Test exempted - status

Sorry, I was a bit too hasty with merging the PR.
The edits are great but please take a look at our Contribution Guide.
I manually ammended the commit message(cbfbc3e1cd092f0714ff3576ca750305fcaadb36) and all is good now. :wink:


Mousewheel event and magic mouse (inertial)

This is a (multiple allowed):

[x] bug

[ ] enhancement

[ ] feature-discussion (RFC)

Swiper Version: 3.4.2

Platform/Target and Browser Versions: macOS (Chrome, Safari).

On default demo http://idangero.us/swiper/demos/20-mousewheel-control.html try to switch slides by mouse wheel on magic mouse (Apple mouse with inertial scrolling).
Expected Behavior
Normal, default behaviour like mouse drag or touch.
Actual Behavior
First slide switch correct, but mouse have inertia, so events called after finger leave mouse - it' ok.
If I wait last event and scroll again I get normal behaviour, but if I try to scroll until last event is called I get infinite event but slide don't switch, because swiper don't recognise new scroll gesture.
https://youtu.be/JeGZG7Ix5yo
Seems this example working correct http://promo.github.io/wheel-indicator/

Also occurs with trackpad

Swiper Version: 3.4.2
Platform/Target and Browser Versions: macOS 10.12.4 (Chrome latest, Safari latest).

On HP laptop (ProBook 430 G4) touchpad slides switching correct like expected behavior. So, can't confirm this bug on not mac touchpad (regular scroll have inertial movement).

The same here

Swiper Version: 3.4.2
MacOS 10.12.6
Chrome 60.0.3112.101

Yep. It seems to stop scrolling all together if you continue to scroll. You then have to wait a few seconds before you can even attempt to scroll again.

@nolimits4web - What would the ETA on this look like? A lot of people with gesture-based laptops will be having similar issues. Thanks!

This is not an ideal solution but it worked for me. Using wheel-indicator to listen to scroll inputs and firing a slide change if the swiper instance is not already transitioning between slides: https://codepen.io/hack_nug/pen/dRxvbN

There is no bulletproof way to detect whether scroll happens with inertia or not. So there is a timeout set that has minimal allowed delays between scroll events. If i remove this delay you will get a lot unpredicted slide changes fired by intertia.


Interpolating opacity.

Now that it’s supported by d3-color, it would be nice to do here.
One tricky thing: CSS says that transparent is rgba(0, 0, 0, 0). A more natural representation in d3-color is rgba(NaN, NaN, NaN, 0), so the RGB channels can be inherited. Probably we should fix d3-color to set these channels to NaN if the opacity is zero, so that the existing interpolators will just work automatically.

As of 0.4.1, d3-color treats transparent as rgb(NaN, NaN, NaN, 0) instead of rgb(0, 0, 0, 0).

Shipped in 0.5.2.


Unrecognised model type: MALUUBA

(.venv) gpuws@gpuws32g:~/ub16_prj/question-generation$ bash train.sh
WARNING:tensorflow:From /home/gpuws/ub16_prj/question-generation/.venv/lib/python3.5/site-packages/tensorflow/contrib/learn/python/learn/datasets/base.py:198: retry (from tensorflow.contrib.learn.python.learn.datasets.base) is deprecated and will be removed in a future version.
Instructions for updating:
Use the retry module or similar alternatives.
Run ID is<PHONE_NUMBER>
Model type is  MALUUBA
Loaded SQuAD with  75722  triples
Unrecognised model type: MALUUBA
(.venv) gpuws@gpuws32g:~/ub16_prj/question-generation$

Please checkout commit 9d2aec68374549cdab9b20b9f6f9d83804096d17 for now, I'm in the process of changing a few things.

The latest commit should work correctly with the updated setup.sh


Introduce Blueprint Update Channels

Feature Description:
There is an ongoing effort to enable using Theia Blueprint as the IDE for developing Theia itself. Currently, we only publish a Blueprint version for ever major release (if I understand correctly). My proposal is to introduce different "update channels" for Theia which are updated at different frequencies. There should be three channels:

Release (published after every release)
Weekly (once a week)
Nightly (once a day)

I'm not sure it makes sense to publish on ever commit to Theia, t.b.h.
IMO, https://github.com/eclipse-theia/theia-blueprint/issues/235 is probably a prerequisite for this feature to be used sensibly.

I get "release" and "nightly", but what is the thought behind weekly?

The idea is that when someone screws up the build, you have time to notice before everyone using the channel gets their dev-environment gets broken. You can have some folks on the nightly channel that notice and tell the other's to pause updates, until the problem is fixed. Since it's just a "promoted" nightly build, it costs nothing, but can save bandwidth on the update servers.

As far as I could see VSCode also does not allow to have multiple installations on Windows. When I run the user installer on windows again, it will reinstall VSCode over my existing installation.
The VSCode nightly/insider build is basically a different application that updates more often. Since it is a different application we can install it next to an existing VSCode.
We could do the same for Blueprint, so having a regular Blueprint application and a Blueprint Nightly application.
However this then does not really fulfill #235, because we are just working around it by using different application names for both channels. However this may be enough?
Otherwise we require the portable installations again, which do not offer updates.

For the dog-fooding use case, it really does not matter whether it's the same application or multiple applications. In fact, having completely separate areas for installed plugins, settings, etc. might be a good thing. The installer could let you choose which "channel" to install.

I will have a look at this in more detail now.
Btw, at the moment there does not seem to be a nightly/next Theia Build any more: https://github.com/eclipse-theia/theia/pull/12699
Next version is still pointing to 1.39.0 https://www.npmjs.com/package/@theia/core?activeTab=versions
So this is something that we might have to bring back as well

So this is something that we might have to bring back as well

We could build from source, no?

So this is something that we might have to bring back as well

We could build from source, no?

Probably yes, but can you elaborate why this would be preferable?
Since we would have to duplicate Theia's github build workflows to some extent, which itself is not nice, there is also room for error when it comes to the Theia build. Every issue we see could be caused by some mis configuration in the workflow. And we have to maintain the additional workflows in the long run.
When the packages are not published, it makes it shakier to reproduce issues. When we know which next version was used, we can simply consume it again on a different machine and test. Otherwise we have to checkout theia, find the git commit, and build from source, which might lead to different results.
I find it weird that consumers of Theia would have to build their own integration points and have no official previews at all to test against.

Probably yes, but can you elaborate why this would be preferable?

We would not have to publish "next" releases, which were discontinued for good reasons. In addition, we would have a template for building applications against theia source, which seems to pose problems for folks, right now.

Since we would have to duplicate Theia's github build workflows to some extent, which itself is not nice, there is also room for error when it comes to the Theia build. Every issue we see could be caused by some mis configuration in the workflow. And we have to maintain the additional workflows in the long run.

We would not have to duplicate anything: if we have a build script that can build a blueprint package from source, we can just call this script in the github build. But we can also invoke it in inner loop development, for example trying out changes to the build more quickly than to having to push it to github and let the CI machinery run.

When the packages are not published, it makes it shakier to reproduce issues. When we know which next version was used, we can simply consume it again on a different machine and test.

I don't agree with this: we can record the git commit we have built from in the package. We need to know that info anyway if we want to know which version of the source has any given bug.

Probably yes, but can you elaborate why this would be preferable?

We would not have to publish "next" releases, which were discontinued for good reasons.

As far as I saw on the ticklet the reason was that we can't clean up next version on the official npm registry.
But imo this is not an argument against next versions, but against publishing the next versions to this registry. We could look at different registries, e.g. Github.
Also having a single official next build will reduce overall resource consumption, when compared to a scenario where every interested adopter has to build Theia themselves on a nightly basis.

In addition, we would have a template for building applications against theia source, which seems to pose problems for folks, right now.

Since we would have to duplicate Theia's github build workflows to some extent, which itself is not nice, there is also room for error when it comes to the Theia build. Every issue we see could be caused by some mis configuration in the workflow. And we have to maintain the additional workflows in the long run.

We would not have to duplicate anything: if we have a build script that can build a blueprint package from source, we can just call this script in the github build. But we can also invoke it in inner loop development, for example trying out changes to the build more quickly than to having to push it to github and let the CI machinery run.

I was talking about the github build workflow descriptions. As far as I know those have to be checked in at .github/workflows. Those have to be kept in sync with the main repository, e.g. when it comes to node or python versions. (https://github.com/eclipse-theia/theia/blob/master/.github/workflows/ci-cd.yml)

When the packages are not published, it makes it shakier to reproduce issues. When we know which next version was used, we can simply consume it again on a different machine and test.

I don't agree with this: we can record the git commit we have built from in the package. We need to know that info anyway if we want to know which version of the source has any given bug.

Yes we need this info when the bug is in Theia, but the bugs could be caused by the adopter's code as well. Rather than being able to just debug an issue, they have to build Theia first.

Also having a single official next build will reduce overall resource consumption, when compared to a scenario where every interested adopter has to build Theia themselves on a nightly basis.

I'm not really worried about overall resource consumption: many adopters, much resources! That said, building applications against a "nightly" version of published packages is a just a workaround for not being able to build against any given commit in the repo. If we can build a theia application against any commit, we trivally can build nightlies, but not the other way round: it's just the more powerful concept. Are you worried it's going to be difficult to implement?

I was talking about the github build workflow descriptions. As far as I know those have to be checked in at .github/workflows.

My philosophy is that CI build scripts should be minimal: you should be able to do the same locally with scripts independent of the CI system, basically: the CI job is responsible for building the correct environment and then invoking the build script. I've had to learn the hard way that you cannot debug CI scripts in a meaningful way, so anything we can keep out of there is a boon.

Yes we need this info when the bug is in Theia, but the bugs could be caused by the adopter's code as well. Rather than being able to just debug an issue, they have to build Theia first.

Building Theia is something you do once, if you don't make changes, and it takes (over time) sth like a minute max.
We're discussing pros/cons here, but I get the feeling we differ on whether it is desirable to build a blueprint package locally against a checked out source tree of Theia. I think that's super useful. What's your view?

I think we're getting to the bottom of our different views: I don't think Theia is just a "dependency" when you build a Theia-base application. It's the framework you live in and debugging through or building against upcoming changes should be a normal part of your routine. Working with Theia is "whitebox", not "blackbox".

@tsmaeder You might have a bias about the last statement. I know many adopting projects, where this is actually not really true. I am also in favor of discussing this in the dev meeting.

@JonasHelming of course I'm biased towards adopters that are also contributors (because they are awesome!). For the rest, it wouldn't make a difference.

In addition, we would have a template for building applications against theia source, which seems to pose problems for folks, right now.

It's the framework you live in and debugging through or building against upcoming changes should be a normal part of your routine.

I agree that a good example of a setup where this is possible, is needed, and see no better place than here, in Blueprint. cdt cloud blueprint and other extenders will inherit the mechanism. Like Thomas, I feel that those who are both Theia framework extenders and IDE authors are currently left under-served, with no decent example how to handle the intersection. Are they not our best customers?
The easier it is to locally publish/consume arbitrary versions of Theia framework extensions, the easier it will be for IDE authors to try their hand at local Theia enhancements, that can be quickly tried/used in their own app. Easier also for them to give-in the temptation of also becoming Theia framework extenders/contributors. Why use Theia if not to make something at least a bit different? Once that's done and you have something awesome, why maintain all the "nuts-and-bolts" yourself when a community is waiting to do it for you?

I know many adopting projects, where this is actually not really true.

It could be argued that we are doing this, here, so they don't have to. If they do not stray too far from the beaten path, they can do well just watching for recent Blueprint commits, reacting to Theia changes, and follow suite. We do a good job in Blueprint, managing the "intersection", they benefit without further effort on their part.
I mentioned before, one avenue could be to make it easy to publish and consume Theia extensions, in a local registry (e.g. Verdaccio). i.e. in the both the Theia and blueprint repos, make it easy to setup, use and maintain (probably mean frequent wiping of) the local registry. Such a setup provides flexibility, short of the two repositories directly depending on each other.
See the 3rd bullet in the how to test section of this PR for an example of how to manually build theia packages from source and publish them to a local registry, and then build a Theia app (e.g. Blueprint) from the result. It's not very complicated and could be made easier by a small integration (helper scripts) into the Theia and Blueprint repos. Blueprint and Theia should be well aligned in their build environment, which should minimize problems. As soon as they become not well aligned, it's good to know (e.g. requiring newer node version at the Theia level first).
Can this be made to work in GitHub workflows? I think so. Maybe we would need to use GitHub storage to save the local verdaccio registry content, after populating it with a Theia release based on latest master, and restore said storage in the Blueprint build job.  Will the job sometimes fail because e.g. Theia master is broken? Probably. I would consider the opportunity to occasionally report such issues upstream, a valid contribution towards the betterment of the framework (i.e. it's not wasted time).
(unfortunately I will not personally have time to spend on this, in the near future)

To sum up the discussion from the dev meeting:
There are basically two requirements:

is to have a nightly build again, but to be able to clean old nightlies again
is to be able to build against the sources

We want to have both in the end.
For 2. I have opened a separate ticket: https://github.com/eclipse-theia/theia-blueprint/issues/304
We will focus on 1. first.
Initial idea is to offer some containerized solution to build Theia sources and publish them to a configurable npm registry.
For 1. we will have a look at Github, for 2. this may then be Verdaccio. So this should help with both requirements.
For this ticket we want to consume the nightlies from the Github registry then and have an automated way to clean up older nightly versions.

@tsmaeder I think we can close this now


Add debug() to typings

What: Add debug() method to typings for RenderResult

Why: It exists in the API, but not in the typings

Checklist:

[ ] Documentation
[ ] Tests
[x] Ready to be merged
[x] Added myself to contributors table

:tada: This PR is included in version 3.1.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Feature Request:  Wallet activity should reflect host earnings and returned collateral

(This is a repost of 1933 https://github.com/NebulousLabs/Sia/issues/1933 as requested by tbenz9)
Over the last few months that I've been watching this, a common question I hear is "How do I see how much my host is earning".
In the wallet activity, hosts can see the withdrawal activity but they do not get to see the return of the collateral and the earnings after the contract is complete.  It is only reflected in "Host earnings" and the detailed reports in "host -v"  I will admit, this confused me at first as well.
Here are a few examples of times I've linked to bug 1933:
Where can I see hosting payments?
Seeing "earned" SC on Hosting screen, not seeing incoming SC to wallet
Proposal:  It would be nice to see wallet entries that show the return of collateral and earnings after the contracts are completed.
Overall, I find that once this is explained to users they understand it.  But it can be a bit disconcerting, especially if hosts are trying to see if contracts are coming to completion and being renewed.
I should add that when I filed the aforementioned issue, wallet logging was near non-existent.  Wallet logging has been much improved in later releases and gives hosts an option to search for it should they choose too.

This may be another UX problem that wallet contexts (#2266) could help address.


Navigation UI Ember Integration

Closes #4537

Adds Navigation to the Settings menu
Adds a navigationUI config flag (redirects if not an editor or author)

Note: This uses a massive default value which should be set to {} when dummy data is no longer needed.

To help move this forward, we've rejigged the issues a little bit. #4537 is now purely about getting the interface wired up (which this PR achieves) and #4539 includes adding and removing items as well as saving them.


data-role="select" multiple: a little glitch and a request

Hi Olton!
Code at:
https://codepen.io/TorakikiSan/pen/EeyWmp
The small glitch is related to the data-clear-button = "true" attribute, the cross is only partially displayed.
The request is related to the content displayed in the select field when many items are selected. The description of the values, as you can see, takes up a lot of space and when this is selected, even if it is shortened, with many values the space occupied is a lot. It would be useful to have an attribute in the "<OPTION" tag (for example data-option or data-value or data-alternate-value) in which to put the value to be displayed if you choose that option instead of the description between <OPTION ....> description
For example, the code could be:
<OPTION value = "arknoid2" data-value = "arknoid2"> Arkanoid - Revenge of DOH (World) </OPTION>
<OPTION value = "arkanoid" data-value = "arkanoid"> Arkanoid (World, older) </OPTION>
<OPTION value = "astrob" data-value = "astrob"> Astro Blaster (version 3) </OPTION>
<OPTION value = "bankp" data-value = "bankp"> Bank Panic </OPTION>

And in the field if you select those items:
Machine
+ --------------------------------------------------------------------------------------------------- --- +
| arknoid2 [X] arkanoid [X] astrob [X] bankp [X] |
+ --------------------------------------------------------------------------------------------------- --- +

I hope I have explained well.
Thanks

Sorry.  Unfortunately my computer is broken and at the moment the work on the library is suspended.  If the community helps me with the purchase of a new computer, then the work will continue as quickly as possible.  Unfortunately, I myself now have financial problems due to illness.

clear button fixed


Website UI is not good

Basically I am a UI Designer. I exclaimed that this repo have lot of deep learning projects. But, they are not indexed correctly in website. So I fix it

Do you gonna create a new website for this project repo? Coz the existing one is built on Google sites just to show case the collection of the projects and a small FAQ section for the contributors. Can you brief your work procedure and approach?
@MohamedMafaz

Creating new website is not that too easy

I'll fix it if you give me the access for Google Sites

Otherwise, If you need a professional website we can do that as freelancing project

Well I like your approach, the main motive of this project repo is deep learning projects. In future if it really requires a proper website then will definitely let you know.
Thanks for showing interest. Closing the issue.

If you assign me this issue I'll create you a website for free

Will let you know when it is required. Right now, the main focus is on the dep learning projects.


False compiler warning when building with Apple Clang

Since v1.14.0 I am getting this warning when building rkcomming on the macOS/arm64 platform with the current Clang compiler:
...
[10/15] Building CXX object rkcommon/CMakeFiles/rkcommon.dir/tasking/detail/tasking_system_init.cpp.o
In file included from /Users/stuko/progs/rkcommon/rkcommon/tasking/detail/tasking_system_init.cpp:26:
In file included from /Users/stuko/progs/rkcommon/rkcommon/math/arm/emulation.h:6:
/Users/stuko/progs/rkcommon/rkcommon/math/arm/sse2neon.h:108:2: warning: "GCC versions earlier than 10 are not supported." [-W#warnings]
#warning "GCC versions earlier than 10 are not supported."
 ^
1 warning generated.

This warning causes problems when building downstream projects such as OSPRay, which treat warnings as errors.
The issue appears to be fixed in upstream sse2neon: https://github.com/DLTcollab/sse2neon/blob/master/sse2neon.h#L120-L122

Thank you for pointing that out. I have prepared 1.14.1 bugfix release to address this. In order to use it in OSPRay superbuild you will need to override both RKCOMMON_VERSION and RKCOMMON_VERSION_REQUIRED CMake variables. e,g.
cmake -DRKCOMMON_VERSION=1.14.1 -DRKCOMMON_VERSION_REQUIRED=1.14.1 ../scripts/superbuild
Nevertheless the issue should not prevent OSPRay from building. OSPRay indeed defines a OSPRAY_WARN_AS_ERRORS CMake variable but it is OFF by default.


Add some details in Trello cards

Hi!
The project looks interesting to me.
I assume it would be a good idea to add subtasks or at least a minimum description in your Trello cards.

Hello,
Thanks for the feedback. I will definetly do that in the next days and add some more description to the Trello Cards. If something is still wrong with the new cards, then feel free to add some details what you would change then. If there's nothing to say anymore, you can close this issue now.

Hello,
I changed now the Trello Board structures and added some details to the cards. I hope these are better. If there's any improvements or idea, please let me know.


Categorisation by team

do we need a categorisation by team ?

Dear, Yes we need them
Normally participants will be registered individually and then they are merged into a team by the system.
Details will be elaborated during individual story refinements


technical-docuementation: wording

Signed-off-by: Jon Harper<EMAIL_ADDRESS>Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

[x] The commit message follows our guidelines
[x] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Docs
What is the current behavior? (You can also link to an open issue here)
typos and frenglish
What is the new behavior (if this is a feature change)?
Hopefully better english
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
NO

Just for information: the file "micro-services-architecture.svg" seems to have not supported fronts with my Inkscape and on my IE (I have on Windows). What can I do to help ?

What can I do to help ?
Post a screen capture ?

Is this the problem https://desk.draw.io/support/solutions/articles/16000042487-why-does-the-text-of-svg-export-sometimes-not-display-correctly-in-ie-and-some-svg-editors- ?


Centos 7.7 wrong ZFS repository configuration

The repository name is wrong (/etc/yum.repos.d/zfs.repo):
http://download.zfsonlinux.org/epel/7_7/x86_64/libnvpair1-0.8.2-1.el7.x86_64.rpm: [Errno 14] HTTP Error 404 - Not Found
Trying other mirror.
libuutil1-0.8.2-1.el7.x86_64.r FAILED

Should be http://download.zfsonlinux.org/epel/7.7/x86_64/
[root@puppet .../environments-from-git/opi_production]# wget http://download.zfsonlinux.org/epel/7_7/x86_64/libnvpair1-0.8.2-1.el7.x86_64.rpm
--2019-10-07 12:46:19--  http://download.zfsonlinux.org/epel/7_7/x86_64/libnvpair1-0.8.2-1.el7.x86_64.rpm
Resolving download.zfsonlinux.org (download.zfsonlinux.org)... 2600:1fa0:40c0:791:34da:d4b9::, <IP_ADDRESS>
Connecting to download.zfsonlinux.org (download.zfsonlinux.org)|2600:1fa0:40c0:791:34da:d4b9::|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
2019-10-07 12:46:20 ERROR 404: Not Found.

[root@puppet .../environments-from-git/opi_production]# wget http://download.zfsonlinux.org/epel/7.7/x86_64/libnvpair1-0.8.2-1.el7.x86_64.rpm
--2019-10-07 12:46:24--  http://download.zfsonlinux.org/epel/7.7/x86_64/libnvpair1-0.8.2-1.el7.x86_64.rpm
Resolving download.zfsonlinux.org (download.zfsonlinux.org)... 2600:1fa0:40c0:791:34da:d4b9::, <IP_ADDRESS>
Connecting to download.zfsonlinux.org (download.zfsonlinux.org)|2600:1fa0:40c0:791:34da:d4b9::|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 32652 (32K) [application/x-rpm]
Saving to: ‘libnvpair1-0.8.2-1.el7.x86_64.rpm’

libnvpair1-0.8.2-1.el7.x86_64.rpm                                          100%[=======================================================================================================================================================================================>]  31.89K   187KB/s    in 0.2s

2019-10-07 12:46:24 (187 KB/s) - ‘libnvpair1-0.8.2-1.el7.x86_64.rpm’ saved [32652/32652]

Ok, let me take a look and see what I've messed up.

Right, the zfs-release package uses a _ character as the version separator in the filename and I didn't change it to a . when I swapped to managing the Yum repos directly. Also the Vagrant box I am/was using for acceptance testing was only CentOS 7.2 so it never triggered this bug as the ZFS guys started making separate repos from 7.3 onwards.
Should be a one-line fix which I'll commit shortly.

v2.2.6 has been upload to the forge with what ended up being a single character fix 😄
Thanks for the bug report!

Much appreciated! 👍


refactor: Refactor controller error handling

Close: #3399
PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.
What is the current behavior?

Issue Number: #3399
What is the new behavior?
Refactor the duplicated code snippets of the controller error handling.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

New Imports

[ ] Yes
[x] No

Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information

Codecov Report

Merging #3400 (9608611) into master (15b4cda) will decrease coverage by 2.01%.
The diff coverage is 79.21%.

@@            Coverage Diff             @@
##           master    #3400      +/-   ##
==========================================
- Coverage   42.57%   40.56%   -2.02%
==========================================
  Files         189      189
  Lines       16546    15791     -755
==========================================
- Hits         7045     6405     -640
+ Misses       9052     8964      -88
+ Partials      449      422      -27

Impacted Files
Coverage Δ

internal/core/data/v2/controller/http/reading.go
78.04% <61.90%> (+3.76%)
:arrow_up:

internal/core/data/v2/controller/http/event.go
83.78% <70.49%> (+3.78%)
:arrow_up:

...t/notifications/v2/controller/http/notification.go
84.96% <75.51%> (+0.20%)
:arrow_up:

...t/notifications/v2/controller/http/subscription.go
90.90% <76.08%> (+2.83%)
:arrow_up:

...re/metadata/v2/controller/http/provisionwatcher.go
93.02% <82.35%> (+3.33%)
:arrow_up:

...nternal/core/metadata/v2/controller/http/device.go
93.87% <83.78%> (+3.17%)
:arrow_up:

.../core/metadata/v2/controller/http/deviceprofile.go
88.82% <84.90%> (+0.31%)
:arrow_up:

...l/support/scheduler/v2/controller/http/interval.go
96.42% <86.36%> (+0.71%)
:arrow_up:

...ort/scheduler/v2/controller/http/intervalaction.go
96.42% <86.36%> (+0.80%)
:arrow_up:

.../core/metadata/v2/controller/http/deviceservice.go
96.90% <88.88%> (+2.58%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15b4cda...9608611. Read the comment docs.


[AIRFLOW-3062] Add QDS dependency in readthedocs

Jira

[ ] My PR addresses the following Airflow Jira issues

https://issues.apache.org/jira/browse/AIRFLOW-3062

Description

[ ] Readthedocs not showing QDS integrations related info due to a missing dependency

Tests

[ ] Just adding a dependency

Commits

[ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[ ] Not applicable

Code Quality

[ ] Passes flake8

@kaxil Could we express these deps in terms of airflow[quoble] etc, or is that going to create a circular dep sort of situation?

@ashb  It is indeed apache-airflow[qds] as in our setup.py. So this list just install extras like gcp_api that translate to apache-airflow[gcp_api] etc.


Make Cleanup of local repositories configurable

Is your feature request related to a problem?
Currently, the cleanup of local repositories are configured here: https://github.com/ls1intum/Artemis/blob/eb5b9bd4321d953217e902868ac9f38de6dd6c6f/src/main/java/de/tum/in/www1/artemis/service/scheduled/AutomaticProgrammingExerciseCleanupService.java#L96
Describe the solution you'd like
It would be nice, to be able to configure the time spans to consider for cleanup. Additionally, I'm currently not sure what happens after cleanup and if a student opens the task once again ; will the local repository be cleaned up again?
Describe alternatives you've considered
No response
Additional context
No response

This is only done for old repositories that are checked out when the online code editor is active.
This makes sense to avoid polluting disk space and is only done for programming exercises which end date is at least 8 weeks in the past.
The LocalVC repositories (the "bare repositories" of the "git server") are not deleted at all, except if you delete the corresponding participation or programming exercises.
We could make the 8 weeks configurable, but I am not sure if this really is required. If you are interested in that, please reopen the issue.


Integrated terminal prompt disappear when pressing tab for suggestion

VSCode Version:1.13.0
OS Version: Ubuntu 16.04

Steps to Reproduce:

Similar Problem

VSCode Version:1.13.0
OS Version: Ubuntu 16.04

terminal print the path twice when using (may related to chinese Characters?)
the current path is D:\编程\Lidar
however the header in console shows D:\编程\Lidar编程\Lidar>

I'm having this exact problem on the Mac, with 1.13.0
It's a regression, it only started happening after upgrading to 1.13.0.

Same issue here on macOS Sierra (10.12.2)

Closing as duplicate of #28304
cc @Tyriar


user.displayName -match "Da.*"

In this example
Da, Dav, David evaluate to true, aDa evaluates to false.
Can you please confirm how the full stop works in the string?
I'm reading this as "Da." and any thing after the full stop.
example
Da.one, Da.two, Da.three (etc) evaluate to true, Da, Dav, David evaluates to false due to the full stop (.)
Please set me right as want to understand this.
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5f7a4070-1be8-5f1f-0092-68fb6b9e2305
Version Independent ID: cd34312f-b507-affe-555e-1e0c63e7d494
Content: Rules for dynamic group membership - Azure AD
Content Source: articles/active-directory/users-groups-roles/groups-dynamic-membership.md
Service: active-directory
Sub-service: users-groups-roles
GitHub Login: @curtand
Microsoft Alias: curtand

@johnhappygilmore, Thank you for sharing the query. We are looking into this and will get back to you soon on this thread.

@johnhappygilmore  So, here it works like the "." detonation after the characters denote to fill in after what has been mentioned. And the same before the characters, denote to what has been mentioned before them. The "." is what you might call fill the blanks before or after the mentioned characters.
We will be closing this thread now, let us know we can be of further help.


Clarify what the "Specific Build Discarder" does

Describe your use-case which is not covered by existing documentation.
Currently I have set Jenkins up with the following build-discarder settings:

When reading the text "The selected build discarder will be applied after any build finishes, as well as periodically." I assume that this is ALWAYS executed for all pipelines.
However even after 100 days we still have some artifacts on the server that should have been deleted since 10 days.
After reading the documentation on the plugin page (https://plugins.jenkins.io/build-discarder/) I suspect that something is incorrect:

The pictures and configuration options on top says "Default Build Discarder" which has the following help text: "Build discarder will be applied for jobs without a specific build discarder, after any build finishes. ..." however there is no such option (anymore?)
https://plugins.jenkins.io/build-discarder/#plugin-content-background contradicts itself:
Line 1 says "The built in Specific Build Discarder discards builds independent of specific job discarders." which matches the description in the Jenkins UI.
However Line 2 says "This discarder will not discard any builds if there's a job specific discarder specified..." which matches the old behavior in the screenshots.

So does "Specific Build Discarder" now ignore builds with job specific discarders or not?
If "Specific Build Discarder" is considering the job specific discarders, another variant of "Specific Build Discarder" that ignores job specific build discarders would be helpful.
Reference any relevant documentation, other materials or issues/pull requests that can be used for inspiration.
No response

Sorry, confused this plugin with the built in Jenkins variant.
Ignore this issue


Simple minio docs for developers

Hi, I know this project is in the development phase but I wanted to give it a try but I was way to lazy to create a new AWS account for this, in retrospect this might have been easier...
So I started to write a small guide on how to use minio together with loki, I hope this is something that you might think is useful in the long run.
I also updated hack/addons.yaml to match with the example that you are using in dev.
I'm currently having some issues, most likley due to that I haven't configured the Minio certificate to be used by loki.
In short I will keep on working on this if you think it's useful for you to have.
I know that RedHat uses OCS (ceph) but my poor laptop can't handle that load so I went with minio.
Bellow information is for my future debugging.
A simple test using logcli,
logcli query '{job="cortex-ops/consul"}'

http://loki-querier-http-lokistack-dev.loki.svc.cluster.local:3100/loki/api/v1/query_range?direction=BACKWARD&end=1629627846296171506&limit=30&query=%7Bjob%3D%22cortex-ops%2Fconsul%22%7D&start=1629624246296171506
Query failed: Error response from server: RequestError: send request failed
caused by: Get "https://minio.loki-operator-system.svc.cluster.local:9000/loki?delimiter=%2F&list-type=2&prefix=index%2Findex_18861%2F": dial tcp <IP_ADDRESS>:9000: i/o timeout

In the minio pod I can see the following:
kubectl logs -n loki-operator-system minio-tenant-1-ss-0-0
{"level":"INFO","errKind":"","time":"2021-08-22T08:28:12.3772888Z","message":"Formatting 1st pool, 1 set(s), 4 drives per set."}
{"level":"INFO","errKind":"","time":"2021-08-22T08:28:12.378198856Z","message":"WARNING: Host local has more than 2 drives of set. A host failure will result in data becoming unavailable."}
{"level":"INFO","errKind":"","time":"2021-08-22T08:28:12.431675625Z","message":"IAM initialization complete"}
2021/08/22 08:36:39 http: TLS handshake error from <IP_ADDRESS>:48022: remote error: tls: unknown certificate

@NissesSenap Amazing! First of all thank you for contributing and testing out the operator! I really appreciate it! :rocket:
FYI, we naturally use minio on the development process and I suggest you take a look at make deploy target. It is using the development overlay which in turn includes a simple minio installation.
Thus regarding this PR, I suggest we skip all the extra bash code in the hack folder. We can certainly update the addons.yaml.

Ahh that is great.
I'm currently on vacation but i will give it a try again sometime next week, but in the meantime i guess we can close this PR.


Merge with main, fixing merge conflicts

i don't really understand what's going on in this PR, but @Frostie314159 's PR should simply be rebased on master (sorry for the merge conflicts, but alas this is life); each commit should apply cleanly, ideally no merge commits, etc.
With @nyurik 's last two PR's there shouldn't be any merge conflicts anymore (it's possible the fmt string one will, but hard to say).

I realized this is frostie's forked repo after i wrote this, but i think still the same solution should be applied, something like (feel free to correct, but this is the general gist of what i'd do, also i haven't added an upstream remote in a while so that syntax could be wrong):
git remote add upstream https://github.com/m4b/scroll
git checkout upstream/master
git pull
git checkout my_branch
git rebase upstream/master
# fix merge conflicts
git push --force

@m4b it is easier to do a merge than to rebase.  This PR fixes the merge conflict.  Afterwards, you can "squash merge" - which keeps your git history linear and simple, combining all changes into one simple commit.

in other words, this PR contains all the changes that were happening on the main branch, plus the merge fix.  Once it is merged, you will have a clean diff with whatever is on the main branch, and you can squash merge.

ok sounds good


Add amenity=give_box

How about adding a recently approved preset?
It hasn't been used many times, but having its preset in iD, people could discover this tag.
https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dgive_box

Neat preset. I used the alternative name "Free Box" for the English locale since I'm certain people would mistag donation-only drop-off boxes as "give boxes".

I still can't find this on https://preview.ideditor.com/master/ ?

@forteller That v3 preview site isn't getting updated anymore. You can find the latest working changes at https://ideditor.netlify.app.

Huh. Ok, thanks. So there's no way to test the latest v3 any more? Does that mean it's close to release?

@forteller That preview site is up to date with the v3 branch, but we're not working on that branch of code anymore.  It was turning into a massive amount of work to keep that branch up-to-date with all the release-ready stuff in the develop branch, so we decided to abandon it.
We've learned a lot from it and will try to bring the best ideas to a future version of iD if we have the resources and community desire to do so. #7496 is tracking some of this but probably won't be merged in its current form.


Initial validation

We should validate the input notebook:

[ ] if there are no markdown cells, show an error
[ ] if there are only H1 headings

On the second bullet.
@edublancas who defines what's a few? Also what's invalid in it that we need an error?
Imo the user and maybe it's a valid notebook for them? I assume you meant H2s since we don't support H1s currently.
Unless it's a 300 lines notebook and there's no or maybe 1-2 headers and then it make sense to output something to the user, but then it's pretty similar to https://github.com/ploomber/soorgeon/issues/47

I'd say:

Only H1 headings (regardless of the number, since we don't support them): throw an error
Only one H2 heading, this is the same as #47

I updated the original description

Sounds about right, Only one H2 header will be dealt in a different PR.
The function sounds good, just validate the regex actually matches to H1s (I tried here on python and seems it doesn't https://regex101.com/).

^\s*##\s+(.+)

Is it working with this pattern?
Also I tried it online and not locally with a py console, that might be failing due to the parser.

Yes, it is.
What's the input? I tried # 1 as the input and it worked.

Small comment @94rain did we cover the case where no markdowns are found at all? Didn't see any in the test cases.

Does test_find_breaks_error_if_no_h1_and_h2_headers count? Expected notebook to have at least one markdown H2 heading. (No H1 and H2 headers)

Not really since there's still markdown in the string you're checking, try having a sample with a json or plain-text

Not really since there's still markdown in the string you're checking, try having a sample with a json or plain-text

OK. Do we expect the error message to be the same as Expected notebook to have at least one markdown H2 heading.?

Yes exactly!


Resizable Image with .aspectRatio(contentMode: .fill) not correctly displayed

When using a resizable Image with .aspectRatio(contentMode: .fill), the image may not be correctly displayed.
Here's a code example to reproduce the issue:
Grid(tracks: 3) {
    ForEach(0 ..< 7) { i in
        Image("ExampleImage")
        .resizable()
        .aspectRatio(contentMode: .fill)
    }
}
.gridContentMode(.scroll)

With ForEach(0 ..< 1), the image fills the whole width of the grid container (instead of just one column).
The more rows are added, the more zoomed in the images become.
With 10 rows, only a single pixel of the image is visible, filling the entire screen.

I guess adding a max height would fix the issue partially, with the other part being .gridCellClip(shape:)

Why don't you merge this into the master? What good a grid library view is if you can't display images properly?

@EfraimB
This seems to be fixed in the latest Xcodes. It should be appropriate to use .fit content mode in such cases.
Code:
	var body: some View {
		Grid(tracks: 3) {
				ForEach(0 ..< 7) { i in
					Image("apple")
						.resizable()
						.aspectRatio(contentMode: .fit)
				}
		}
		.gridContentMode(.scroll)
	}

Here are my results for the preview canvas:

But in runtime both Xcode builds work as intended.
Tested both on iOS 14.0 and iOS 13.6
If you are still having an issue please provide the code for reproducing.


Rplumber test application delivers error

Hallo,
I have been having problems with trying to get the API. So i follow the instruction https://gist.github.com/virtualstaticvoid/8bef2b32ae6b9665ffe1340283ffce44#file-r-version
I copy these files to my github and only having these files (.r-version, Procfile, app.R, init.R, myfile.R) ,
use the right buildpack: https://github.com/virtualstaticvoid/heroku-buildpack-r.git
But it still delivers no application

Where is the problem? I really need help. Thank you.

Hi @marissa97
That gist is a rather old.
Please use heroku-plumber-app instead; you can clone the repository and try it out "as is" to check that it works and then change the source code for your needs.
Hope that helps!

Hi @virtualstaticvoid, yes i did that the first time too. But the app shows 404: error. I deploy the exact github code. it should've shown the swaager API when it's working right? Thankyou.

Hi @marissa97
In the example app there isn't anything mounted to the root path, which would result in a 404 when requests are made. Also OpenAPI/Swagger isn't enabled.
The paths available are:

/echo
/plot
/sum?a=1&b=2

I've updated the example to include the OpenAPI/Swagger end-point and added a redirect from the root to the Swagger UI.

Hallo @virtualstaticvoid  Thankyou so much! It works really great now.


Rancher Agent provisioning is broken in 2.2.x

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):

Configure the rancher server
Start the rancher agent (v2.2.x)
Rancher provisioning fails due to issue in share-mnt binary

Result:
Other details that may be helpful:
Rancher 2.2.x includes https://github.com/rancher/share-mnt/releases/download/v1.0.4/share-mnt-amd64.tar.gz .  This binary on execution results in segmentation fault on AMD64 architecture.
docker run --privileged --net host --pid host -v /:/host --rm -it  --entrypoint /bin/bash  rancher/rancher-agent:v2.2.3
root@linuxkit-025000000001:/# share-mnt
Trace/breakpoint trap
root@linuxkit-025000000001:/#

However,  the agent with 1.0.3 version of share-mnt works.
docker run --privileged --net host --pid host -v /:/host --rm -it  --entrypoint /bin/bash  rancher/rancher-agent:v2.1.10
root@linuxkit-025000000001:/# share-mnt
Found container ID: 3cf22ef2d0f4367128a6f3f69ebed139c52279e57b15227a6fbf8f2d64b147d4
Checking root: /host/run/runc
Checking root: /host/var/run/runc
Checking root: /host/run/docker/execdriver/native
Checking root: /host/var/run/docker/execdriver/native
Checking root: /host/run/docker/runtime-runc/moby
Checking root: /host/var/run/docker/runtime-runc/moby

Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): v2.2.3
Installation option (single install/HA): single

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): Custom

Machine type (cloud/VM/metal) and specifications (CPU/memory): cloud + VM

Kubernetes version (use kubectl version): 1.14

Docker version (use docker version):

Client: Docker Engine - Community
 Version:           18.09.2
 API version:       1.39
 Go version:        go1.10.8
 Git commit:        6247962
 Built:             Sun Feb 10 04:12:39 2019
 OS/Arch:           darwin/amd64
 Experimental:      false

Server: Docker Engine - Community
 Engine:
  Version:          18.09.2
  API version:      1.39 (minimum version 1.12)
  Go version:       go1.10.6
  Git commit:       6247962
  Built:            Sun Feb 10 04:13:06 2019
  OS/Arch:          linux/amd64
  Experimental:     false

Untill this issue gets fixed,  I have patched agent with 1.0.3 version of share-mnt binary.
See https://github.com/intraedge-services/rancher-agent-patch

Can you share the full log of the share-mnt container when it is run when you add a node to the cluster? Also what OS and kernel is this on?

@superseb Here are the actual logs from 'share-mnt' container that got created when rancher was provisioned.  (All the sensitive info is removed)
INFO: Arguments: -- share-root.sh docker run -d --privileged --restart=unless-stopped --net=host -v /etc/kubernetes:/etc/kubernetes -v /var/run:/
var/run <registry-url>/rancher/rancher-agent:v2.2.3 --server https://<rancher-server> --token REDACTED --ca-checksum <ca-checksum>
<token> --no-register --only-write-certs /var/lib/kubelet /var/lib/rancher
+ trap 'exit 0' SIGTERM
++ grep :devices: /proc/self/cgroup
++ head -n1
++ awk -F/ '{print $NF}'
++ sed -e 's/docker-\(.*\)\.scope/\1/'
+ ID=d87baf20aeffcb44b62a1364c2ff2ae496c00202b136ee71e895394b32808404
++ docker inspect -f '{{.Config.Image}}' d87baf20aeffcb44b62a1364c2ff2ae496c00202b136ee71e895394b32808404
+ IMAGE=<registry-url>/rancher/rancher-agent:v2.2.3
+ bash -c 'docker run -d --privileged --restart=unless-stopped --net=host -v /etc/kubernetes:/etc/kubernetes -v /var/run:/var/run dev.registry.ew
s.int:443/vendored/rancher/rancher-agent:v2.2.3 --server https://<rancher-server> --token <token> --ca-ch
ecksum <ca-checksum> --no-register --only-write-certs'
4d8f955b5a73eacc2d753ea94fdb9a5cf1732aae6314a4b54d67855321637e21
+ docker run --privileged --net host --pid host -v /:/host --rm --entrypoint /usr/bin/share-mnt <registry-url>/rancher/rancher
-agent:v2.2.3 /var/lib/kubelet /var/lib/rancher -- norun
+ docker start kubelet
Error response from daemon: {"message":"No such container: kubelet"}
Error: failed to start containers: kubelet
+ sleep 2
+ docker start kubelet
Error response from daemon: {"message":"No such container: kubelet"}
Error: failed to start containers: kubelet
........
Above error repeats forever
........

From the above log, I tried running following command on different flavor of VMs (amd64 architecture), and it was failing with exit code 133  (Segmentation Fault) . The segmentation fault error is not shown in the log,  but after I ran a bash
[user@<host> ~]$ sudo docker run --privileged --net host --pid host -v /:/host --rm --entrypoint /usr/bin/share-mnt <registry-url>/rancher/rancher-agent:v2.2.3 /var/lib/kubelet /var/lib/rancher -- norun
[user@<host> ~]$ echo $?
133
[user@<host> ~]$ sudo docker run --privileged --net host --pid host -v /:/host -it --rm --entrypoint /bin/bash <registry-url>/rancher/rancher-agent:v2.2.3
user@<host>:/# /usr/bin/share-mnt /var/lib/kubelet /var/lib/rancher -- norun
Trace/breakpoint trap (core dumped)

OS and kernel version
CentOS Linux release 7.6.1810 (Core)
[user@host~]$ uname -a
Linux s8497dalv 3.10.0-957.10.1.el7.x86_64 #1 SMP Mon Mar 18 15:06:45 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
[user@host~]$

Once I found the issue,  I tried running container on Mac, Ubuntu 16 and I run into same segmentation fault.  After I download share-mnt binary (1.0.3) within the container,  the error goes away
curl -sL https://github.com/rancher/share-mnt/releases/download/v1.0.3/share-mnt.tar.gz | tar xvzf - -C /usr/bin/

I also tried to build and run share-mnt on my Mac , it had same issue.  I got the binary to work by removing external linkage. This works fine on alpine container,  however for some reason breaks on Ubuntu
See https://github.com/rancher/share-mnt/pull/9

Update on the issue:
I was able to get around share-mnt by re-creating the cluster. The binary still has the issue,  but I imagine the step is optional.
However,  after I cleaned up the containers (not the data) and started agent again, it again got stuck on share-mnt issue.

Yes, it doesn't block the provisioning from succeeding as it works as it should when it's run as it should. We can look into why the error occurs when the binary is ran manually though.
For the actual issue, please provide the steps from the issue template and the logs so we can use that to reproduce. Setting up a custom cluster and adding a node doesn't trigger this, so we need a bit more info to narrow down possible causes. Which is basically https://github.com/rancher/rancher/issues/13314 but can't tell for sure without the requested info.

I tried to apply this fix but unfortunately it's not working for me, my installation still stuck in a endless loop of
`+ docker start kubelet
Error response from daemon: {"message":"No such container: kubelet"}
Error: failed to start containers: kubelet

sleep 2
`

To reproduce:

Create custom cluster and add nodes
Check if kernel traps message is logged in system logging (/var/log/syslog, /var/log/messages, /var/log/kern.log) using grep traps $FILE

kernel: [  108.318555] traps: share-mnt[6515] trap int3 ip:4546f2 sp:7ffd8cf26a58 error:0 in share-mnt[400000+385000]

Run share-mnt binary manually and check exit code:

docker run --entrypoint share-mnt $(docker inspect $(docker images -q --filter=label=io.cattle.agent=true) --format='{{index .RepoTags 0}}' | tail -1); echo $?
133

To validate:

Create custom cluster and add nodes
kernel traps message should not be seen
Running the share-mnt binary should actually start and show logging, and fail with Failed to find state.json and exit with code 1 and not 133.

Reproduced in the custom cluster node in Rancher: v2.3.3
Steps:

run Rancher:v2.3.3 single install
add a custom cluster

Results:

ssh into one of the nodes, the logs in the node show the following errors

root@jiaqi-tf--rancheragent-0-all:~# cat /var/log/kern.log | grep trap
Dec 13 22:07:03 jiaqi-tf--rancheragent-0-all kernel: [  106.031038] traps: share-mnt[5966] trap int3 ip:4546f2 sp:7ffdad373ef8 error:0 in share-mnt[400000+385000]
root@jiaqi-tf--rancheragent-0-all:~# cat /var/log/syslog | grep trap
Dec 13 22:07:03 jiaqi-tf--rancheragent-0-all kernel: [  106.031038] traps: share-mnt[5966] trap int3 ip:4546f2 sp:7ffdad373ef8 error:0 in share-mnt[400000+385000]
root@jiaqi-tf--rancheragent-0-all:~#

Run share-mnt binary manually and check exit code

root@jiaqi-tf--rancheragent-0-all:~# docker run --entrypoint share-mnt $(docker inspect $(docker images -q --filter=label=io.cattle.agent=true) --format='{{index .RepoTags 0}}' | tail -1); echo $?
133

The bug fix is validated in v2.3-head 9626c3f9e
Results:

no error in the logs in the node
run share-mnt binary manually and the exit code is 1

root@jiaqi-tf--rancheragent-1-all:~# docker run --entrypoint share-mnt $(docker inspect $(docker images -q --filter=label=io.cattle.agent=true) --format='{{index .RepoTags 0}}' | tail -1); echo $?
Found container ID: ca6fb582bf511282cdda82756415b177fdb30c03ab01c17b6cf84ea1d4908a63
Checking root: /host/run/runc
Checking root: /host/var/run/runc
Checking root: /host/run/docker/execdriver/native
Checking root: /host/var/run/docker/execdriver/native
Checking root: /host/run/docker/runtime-runc/moby
Checking root: /host/var/run/docker/runtime-runc/moby
Checking root: /host/run/docker/runtime-nvidia/moby
Checking root: /host/var/run/docker/runtime-nvidia/moby
time="2019-12-13T22:37:15Z" level=fatal msg="Failed to find state.json"
1

The bug fix is validated in master-head 9e5545525
Results:

no error in the logs in the node
run share-mnt binary manually and the exit code is 1

root@jiaqi-tf--rancheragent-2-all:~#  docker run --entrypoint share-mnt $(docker inspect $(docker images -q --filter=label=io.cattle.agent=true) --format='{{index .RepoTags 0}}' | tail -1); echo $?
Found container ID: 6ea476646b67d37d0414b0cf5ed889b6589d7903a64ac484ec97ccac2d42f586
Checking root: /host/run/runc
Checking root: /host/var/run/runc
Checking root: /host/run/docker/execdriver/native
Checking root: /host/var/run/docker/execdriver/native
Checking root: /host/run/docker/runtime-runc/moby
Checking root: /host/var/run/docker/runtime-runc/moby
Checking root: /host/run/docker/runtime-nvidia/moby
Checking root: /host/var/run/docker/runtime-nvidia/moby
time="2019-12-13T22:50:34Z" level=fatal msg="Failed to find state.json"
1


[AUTO] Update CLI doc

Update CLI doc

Auto-generated by create-pull-request

This should not be merged until https://github.com/nebari-dev/nebari/pull/1634 is merged (it may no longer be necessary)

@kcpevey feel free to reopen this if you think we need to.


5.0 api error

Dynamic and static of the Mono Runtime version 5.0
There is no API in 5.0:
mono_config_get_os
mono_config_get_cpu
mono_config_get_wordsize
mono_get_config_dir
mono_set_config_dir
mono_get_machine_config
.......There are other API

I'm not sure what you mean - these functions are both in my code: https://github.com/kubasz/derelict-mono/blob/master/source/derelict/mono/stafunctions.d#L646 and Mono's code: https://github.com/mono/mono/blob/mono-<IP_ADDRESS>/mono/metadata/mono-config.c#L100 . Are you sure you're importing derelict.mono.mono or derelict.mono and not just one of the other files in the folder?

Are you using the version of <IP_ADDRESS>? I'm probably the wrong version, and I'm downloading the version of <IP_ADDRESS>. I'm very grateful to you, the open source, and the help for my framework.

Oh, no, it's not supposed to be the Windows version of mono.dll. Some of the functions are not exported, because I'm prompting that some functions can't be found when I export the function from DLL. But I think API in the source code has these functions. https://github.com/mono/mono/blob/mono-<IP_ADDRESS>/mono/metadata/mono-config.c#L100


temporary uses nextest in the CI

When we running cargo test we have a lot of tests that become flaky and trigger a deadlock. The issue seems to be linked to the fact that cargo test run all the tests in multiple threads instead of multiple environment. Thus, as a temporary fix I would like to move our test suite over nextest that run each test in a separate process.
Once this is merged we should open an issue to remove nextest from our CI.
The reason being that it doesn't run the doctests. We don't have a lot of doctests in meilisearch since we ship a binary and not a lib but I think it would be better to check the full test suite in the CI.

As we can see in the CI, it looks like there are still some tests hanging, and thus this PR doesn't fix the issue.


Feature/traefik k8s ingress

Hi, thank you for your contribution to Mantl! Before we can accept any code into
master, we need it to meet the following criteria. If there are any you can't
satisfy yourself, go ahead and open the pull request anyway and we'll help you
test. Feel free to delete this message once you're done. Thanks again!

[ ] Installs cleanly on a fresh build of most recent master branch
[ ] Upgrades cleanly from the most recent release
[ ] Updates documentation relevant to the changes

I see private and public certs in here that appear to have been generated already.  Are they meant to be part of the pull request?  That seems likely to be an error to me.
The merge robot says there are conflicts, so I think this branch needs to be at least rebased onto master so it can merge cleanly.
@Dacode45 @Theaxiom
I am new to mantl and don't have reviewer permissions yet, but I do have some kube experience.

I am going to look at this, I know a lot of these words...
Looks like your CI build is stopped because of a dependency on S3 key that is broke
Why should GCE and DO builds depend on an S3 key?

https://travis-ci.org/mantl/mantl/builds
Don't let it stop you from merging any features I guess!

Ah, I see now, this is mega-merge day.  Great!
I'll see if I can deploy it and get Traefik working myself

OK, Have reviewed v1.3.0 and it looks like Traefik was already enabled for Marathon.  This patch probably enables Traefik for Kubernetes, guessing based on the name of the PR.

I believe I may have let a change slip in where TF state may have been kept remotely which is the S3 bucket probably. It was mega merge, lets break everything and fix it day. We had a semi stable build in 1.3 so this was the next step.


Karma waits ~20 secs before exiting when using public api

Karma waits ~20 secs before exiting when using public api.
Happens to me with karma 0.13.19.
Downgrading to 0.12.x fixes it.
Looks like it was solved previously https://github.com/karma-runner/karma/issues/1035. ?

I expect this to be the same issues as #1788

Seems like the issue is resolved by using socket.io 1.4.5 https://github.com/socketio/socket.io/commit/b3fc530abefd384b3a89ff5493e97f3ef85098d4! Thanks!

@lukaselmer thanks for the confirmation. Closing this then.

Was it really fixed? Still looks occasionally hanging for about that time to me, with<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

@dignifiedquire @ChALkeR This is still happening for us too with<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

I am also running into this issue with<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

As said in the other issue, I'm not able to reproduce this with the latest versions, so please provide me with an example that reproduces this consistently

@dignifiedquire https://github.com/qmlweb/qmlweb/blob/master/gulpfile.js#L81 --- should be reproducible without that line. Sorry, no smaller testcase atm.


fritzing: added meta.Program

Added meta.Program as package name is fritzing but binary name is Fritzing.
Description of changes
Added meta.Program as package name is fritzing but binary name is Fritzing (Capital "F"!).
Otherwise fritzing does not launch with nix run nixpkgs#fritzing
Everything else left as-is, as it works.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[x] Tested basic functionality of all binary files (usually in ./result/bin/)

I think it should be meta.mainProgram according to https://nixos.org/manual/nix/stable/command-ref/new-cli/nix3-run.html


Add Padding and Organizing Contact Us Page

Add padding to the page.
Re-style the theme of the page.
Add AppBar.
Remove the logo of GSSoC and put appropriate content in the AppBar.
Add Github handle link.
Use this facebook logo. (The color accent in the existing one is incorrect)

Hey @ousnik , these issues are in ContactUs page, I guess?

Hey @ousnik @smaranjitghose I would like to work on this.


Updating Community Showcase 13/10

Description
Showcase Updates
Fixes # (issue)
Type of change

[x] Documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Please delete options that are not relevant.

[x] Unit Test
[x] Test Script (please provide)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

Maintainer Checklist

[ ] closes #xxxx (Replace xxxx with the GitHub issue number)
[ ] Made sure Checks passed

@aryankhanna475 can you please resolve the conflicts here?

Will raise a new one later


New terra-pill component

Feature Request
Create the Pill component based on the OCS designs posted in zeplin:
Basic Pill:
https://app.zeplin.io/project/59b1bfeae515657fa8268300/screen/5b60abaaa8b621561b120d39
Removable Pill:
https://app.zeplin.io/project/59b1bfeae515657fa8268300/screen/5f3d9d37694a9912ac38b2df
Roll Up Pill:
https://app.zeplin.io/project/59b1bfeae515657fa8268300/screen/5f3316c0c4dcb05133097579

I've been reviewing PR #3419 and i've noticed a couple of issue that I think warrant revisiting of the api design.
Selectable and basic pill types in a single pill list.
Currently consumers can create a pill list and populate it with and both selectable and non selectable pills. According to my discussions with our design standards we should prevent this situation.
I propose we break up pill list into a pills component and a selectablePills component. Additionally we should make the pill objects a subcomponent of the pills components to better tie the pill with the pill list.
Displaying a popup on truncation.
Our current strategy of having the consumer display a popup when basic pill text is truncated is not going to work, consumers likely will have little to no knowledge of the content of the pill or if it needs to be set to selectable. Their only option would be to make every pill selectable with a popup.
From discussions with @neilpfeiffer I think we have two options to explore:

For basic pills only, Auto discover if a pill is truncated and convert it to a selectable pill. This fix would involve moving pills back to terra-framework (I'm sorry) and detecting if the pill is truncated then applying the correct props to the pill and adding a popup feature the label. For selectable pills we should do nothing and assume the consumer is re-stating the label in the popup (this assumption should be documented). Making these changes to basic pill should not affect the consumer exposed api in any way.
Work with design standards to remove pill truncation. We should explore this option if auto detecting if a pill is truncated is found to not be possible or flaky.

Proposed Changes
Before we get into the changes i wanted to provide a set of examples of how i'd expect consumers to setup the pills. There are two examples one for Basic pills and one for selectable pills.
Basic Pills
import React, { useState } from 'react';
import Pills from 'terra-pills';

const RemovablePill = () => {
  const pills = [
    {
      label: 'asthma',
    },
    {
      label: 'bronchitis',
    },
    {
      label: 'fibro',
    },
  ];
  const [pillsState, setPillsState] = useState(pills);

  const handleOnRemove = (pillKey, metaData) => {
    const pillsArray = pillsState;
    pillsArray.splice(metaData.index, 1);
    setPillsState([...pillsArray]);
  };

  return (
    <Pills
      ariaLabel="Example of a Removable Pill"
      onRemove={handleOnRemove}
    >
      {pillsState.map((pill, index) => (
        <Pills.Pill
          label={pill.label}
          pillKey={pill.label}
          isRemovable
          metaData={{ index }}
        />
      ))}
    </Pills>
  );
};

export default RemovablePill;

Selectable Pills
import React, { useRef, useState } from 'react';
import Popup from 'terra-popup';
import SelectablePills from 'terra-pills';
import Spacer from 'terra-spacer';

const DisclosureAndRemovablePill = () => {
  const pillsData = [
    {
      label: 'asthma',
      ref: useRef(),
      id: 'terra-pills-example-disclosure-removable-pill-asthma',
    },
    {
      label: 'bronchitis',
      ref: useRef(),
      id: 'terra-pills-example-disclosure-removable-pill-bronchitis',
    },
    {
      label: 'fibro',
      ref: useRef(),
      id: 'terra-pills-example-disclosure-removable-pill-fibro',
    },
  ];
  const [pillsState, setPillsState] = useState(pillsData);
  const [openPillIndex, setOpenPillIndex] = useState(undefined);

  const handleOnRemove = (pillKey, metaData) => {
    const pillsArray = pillsState;
    pillsArray.splice(metaData.index, 1);
    setPillsState([...pillsArray]);
  };

  const handleOnSelect = (pillKey, metaData) => {
    setOpenPillIndex(metaData.index);
  };

  const handleOnRequestClose = () => {
    setOpenPillIndex(undefined);
  };

  const renderPopup = () => {
    if (openPillIndex === undefined) {
      return undefined;
    }
    const pillData = pillsState[openPillIndex];
    return (
      <Popup
        isOpen
        isArrowDisplayed
        targetRef={() => pillData.ref.current}
        onRequestClose={handleOnRequestClose}
        contentHeight="40"
        contentWidth="240"
      >
        <Spacer padding="medium" aria-labelledby={pillData.id}>
          - Sample Popup Content -
        </Spacer>
      </Popup>
    );
  };

  return (
    <>
      <SelectablePills
        ariaLabel="Example of a Basic Pill with a Popup"
        onSelect={handleOnSelect()}
        onRemove={handleOnRemove()}
      >
        {pillsState.map((pill, index) => (
          <SelectablePills.Pill
            label={pill.label}
            id={pill.id}
            pillKey={pill.label}
            isRemovable
            metaData={{ index }}
            refCallback={(node) => { pill.ref.current = node; }}
            ariaExpanded={openPillIndex === index}
          />
        ))}
      </Pills>
      {renderPopup()}
    </>
  );
};

export default DisclosureAndRemovablePill;

The main file should be switched to an index.js file.
/src/index.js
import Pills from './Pills';
import SelectablePills from './SelectablePills';

export default Pills;
export {
  SelectablePills,
} from 'terra-breakpoints';

I suggest moving the current pill component to a private folder and creating a wrapper component to expose the smaller api for the basic pill. This is because we should expose a simpler api for consumers of the basic pill, but internally we may need to make a basic pill selectable based on truncation.
Pills API changes

Add the onRemove callback prop. It should return the pillKey and metaData for the pill being removed.

Pills.Pill API changes

Remove 'onRemove'
Add 'isRemoveable' prop that indicates which pills are removable (Bool)
Remove 'onChange'
Add metaData prop, return it along with the pillKey in the onRemove callback. (Object)
Add pillKey to identify which pill is being removed. (String)
Remove refcallback, ariaHasPopup, ariaExpanded, and ariaControls from pill since this one is non-selectable by users (we may still need to add a popup internally but that shouldn't be exposed to consumers)

SelectablePIlls API changes

Add the onRemove callback prop. It should return the pillKey and metaData for the pill being removed.
Add the onSelect callback prop. It should return the pillKey and metaData for the pill being removed.

SelectablePills.Pill API changes

Remove 'onRemove'
Add 'isRemoveable' prop that indicates which pills are removable (Bool)
Remove 'onChange'
Add metaData prop, return it along with the pillKey in the onRemove callback. (Object)
Add pillKey to identify which pill is being removed. (String)
Consider removing ariaHasPopup and ariaControls from the selectablePills. IMO we should set ariaHasPopup by default and remove ariaControls altogether because the popup it references may not even be rendered until after it's clicked.

Regarding displaying a popup on truncation.
Option 2 (removing pill truncation) is the fallback solution if Option 1 (detecting and showing the popup) is not viable. I need the team to explore option 1 and we'll check in with you in a week and see what progress we've made.

+1

@mjhenkes @neilpfeiffer  Will we have any API changes or design changes for Collapsible Pills? Or will the design remain same as before.

Restating for clarity here the same details mentioned offline: all API items carry forward from the existing/original Pill & Pill-List definitions, paired with the changes listed above, (nothing was removed unless otherwise mentioned):
Pills:

Prop Name
Type
Is Required
Default Value
Description

ariaLabel
string
required
none
The string that labels the collection of pills, used in cased where the text label is not visible on the screen and required for minimum accessibility standards. Providing this prop adds the aria-label attribute to the Pills container element. (Required)

ariaLabelledBy
string
optional
undefined
If a visible text label is used with the collection of pills, provide a string of the ID for the html element containing the visible text label. Supplying the 'ariaLabelledBy' prop will override the 'ariaLabel' prop and adds the aria-labelledby attribute instead to the Pills container element. For best practices, ensure the visible text in the html element id provided to the Pills ariaLabelledbyprop matches the text provided to the ariaLabel prop, for consistency in the case of fallback or errors.

ariaDescribedBy
string
optional
undefined
If additional visible information text is used, provide a string containing the IDs for html elements that help describe the intent of the group of pills.

children
node
optional
undefined
The content to be shown in the pills container. Should only contain the sub-component <Pills.Pill>.

onRemove
func
optional
undefined
Callback function triggered on click/keypress of any included removable pill.

isCollapsed
bool
optional
undefined
Determines if the Pills group should be shown as rolled up or not, limited to a single line of display.

rollUpPillOnTrigger
func
optional
undefined
Callback function triggered on click/keypress of the roll-up pill when group of pills is collapsed.

Pills.Pill

Prop Name
Type
Is Required
Default Value
Description

label
string
required
none
The label text for the pill. (Required)

id
string
optional
undefined
The html 'id' attribute for the pill.

pillKey
string
optional
undefined
To identify which pill is being removed.

isRemovable
bool
optional
undefined
Adds the ability for a pill to be removable.

metaData
object
optional
undefined
Object returned along with the pillKey in the onRemove callback.

Privately the Pills.Pill component will provide these details when the pill is truncated and needs to add it's own popup:

Item
Description

refCallback
Callback to expose pill element's ref for popup placement.

ariaExpanded
Sets the aria-expanded attribute to true when using a popup via 'onSelect' and the popup is visible. Only applies when used along with the 'onSelect' prop.

title
Tooltip to display on mouse hover, will show the same contents as the label

SelectablePills:

Prop Name
Type
Is Required
Default Value
Description

ariaLabel
string
required
none
The string that labels the collection of pills, used in cased where the text label is not visible on the screen and required for minimum accessibility standards. Providing this prop adds the aria-label attribute to the Pills container element. (Required)

ariaLabelledBy
string
optional
undefined
If a visible text label is used with the collection of pills, provide a string of the ID for the html element containing the visible text label. Supplying the 'ariaLabelledBy' prop will override the 'ariaLabel' prop and adds the aria-labelledby attribute instead to the Pills container element. For best practices, ensure the visible text in the html element id provided to the Pills ariaLabelledbyprop matches the text provided to the ariaLabel prop, for consistency in the case of fallback or errors.

ariaDescribedBy
string
optional
undefined
If additional visible information text is used, provide a string containing the IDs for html elements that help describe the intent of the group of pills.

children
node
optional
undefined
The content to be shown in the pills container. Should only contain the sub-component <Pills.Pill>.

onSelect
func
optional
undefined
Callback function triggered on click/keypress of each selectable pill label. Intended to only be used to disclose a popup.

onRemove
func
optional
undefined
Callback function triggered on click/keypress of any included removable pill.

isCollapsed
bool
optional
undefined
Determines if the Pills group should be shown as rolled up or not, limited to a single line of display.

rollUpPillOnTrigger
func
optional
undefined
Callback function triggered on click/keypress of the roll-up pill when group of pills is collapsed.

SelectablePills.Pill

Prop Name
Type
Is Required
Default Value
Description

label
string
required
none
The label text for the pill. (Required)

id
string
optional
undefined
The html 'id' attribute for the pill.

pillKey
string
optional
undefined
To identify which pill is being removed.

isRemovable
bool
optional
undefined
Adds the ability for a pill to be removable.

metaData
object
optional
undefined
Object returned along with the pillKey in the onRemove callback.

refCallback
string
optional
undefined
Callback to expose pill element's ref for popup placement.

ariaExpanded
bool
optional
undefined
Consumers need to set the aria-expanded attribute to true when using a popup via 'onSelect' and the popup is visible. Only applies when used along with the 'onSelect' prop.

title
string
optional
undefined
Optional tooltip to display on mouse hover.


[minor] Generify the "about" page

The wording of the about page is specific to the particular dpaste.de implementation of this project.  Would it be interesting to make this page more generic so that it fits in any implementation?  If so, I'd be more than happy to write the text for that.
Just a thought - no worries either way. :smile:

removal of Bootstrap
:+1:

Whats the reasoning behind wanting to remove bootstrap out of curiosity?

Sure, couple of, nothing is major though:

dpaste is intended to be integrated into existing projects and I think it shouldn't require or dictate any third party UI styles, class names etc.
We only use so little of it that the overhead isn't worth it. 100kb CSS just to place an icon and a grid system is reasonable.
I want to get rid of more third party requirements, and beside Bootstrap also jQuery. We only use it for very little features, and they can be simply done by vanilla JS.
It looks very dated.

This was done in the v3 branch. Its very barebone in general now.


feat: adds support for periodic channel refreshing

This adds support for channel priming and refreshing. It will  be used in bigTable.
Its  a prototype PR so tests and comments are missing. We update them once the approach is finalized.

Hi @jskeet and @amanda-tarafa,
Please have a look at it and share your feedback.
Thanks,


Export to console button not working

Using Chrome Version 51.0.2704.63 m on a Windows 7 PC. Clicking the export to console button does nothing. Any potential conflicts I should look for?

Export to console only works when the console is shown (see 'Advanced' section of Wiki on how to show console) and will only list broken links.


Undefined is not an object (evaluating 'skus.includes')

Please use the Discussion board if you want to get some help. Please use issues to report bugs.

Description
import * as RNIap from "react-native-iap";
RNIap.initConnection().then(() => {
RNIap.getSubscriptions(itemSkus)
.then((res) => {
console.log(itemSkus);
// console.log("res---", res);
})
.catch((err) => {
console.log("err--", err);
});
});
Expected Behavior
please help me to get list of subscription
Screenshots

Environment:

react-native-iap:12.3.0
react-native:0.68.2
Platforms (iOS, Android, emulator, simulator, device): simulator

[Optional] Additional Context

Use like this await getSubscriptions({ skus: this.itemSkus });


[#8188] Fix strong markdown syntax

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Pre-trained weights over Pascal VOC 2012

Hello. Thank you very much for making the code available.
I was wondering if you still have the pre-trained weights over Pascal VOC 2012 dataset, and if those could be added here as well.
As far as I can tell, the ones in the README.md refer to the COCO dataset, right? Moreover, their links seem to be broken.
Cheers,

Would like to ask for the same.

Yes, we only released the model for COCO. We will consider releasing the VOC models later.
Thanks for pointing out the broken links on Tsinghua Cloud. we fixed them just now.

Hi, are pretrained weights for Pascal VOC shared in the meantime? Would love to use them as well

Looking forward to the release of the VOC model!