PdfRenderer inverts monochrome TIFF image + one more

Environment

Tesseract Version: Built form the main branch on 10/2/2018
Commit Number: Exists in the current version as of 10/5/2018
Platform: 32-bit Windows 10

Current Behavior:

Monochrome images are displayed inverted in generated PDF files.
Extra instructions in PDF page content stream when text_only flag is used (minor).

Suggested Fix:

Code lines from pdfrenderer.cpp starting at line number 718:

  int format, sad;
  sad = pixGenerateCIData(pix, L_FLATE_ENCODE, 0, 0, &cid);
  if (!cid) {
    sad = l_generateCIDataForPdf(filename, pix, kJpegQuality, &cid);
  }

We are trying Flate encoder first. This encoder can handle 1bpp images, so it succeeds and is used to insert the image into the PDF file as in the following extract:
11 0 obj
<<
  /Length 31159
  /Subtype /Image
  /ColorSpace /DeviceGray
  /Width 1728
  /Height 2376
  /BitsPerComponent 1
  /Filter /FlateDecode
  /DecodeParms
  <<
    /Predictor 1
    /Colors 1
    /Columns 1728
    /BitsPerComponent 1
  >>
>>
stream

The original image was a CCITT G4 compressed TIFF image. We shouldn't use PNG compression as it is not as efficient and has a different default for black (ie BlackIs1).

When generating a text_only PDF, the following code starting at line 347 is executed:

  pdf_str += "q ";
  pdf_str.add_str_double("", prec(width));
  pdf_str += " 0 0 ";
  pdf_str.add_str_double("", prec(height));
  pdf_str += " 0 0 cm";
  if (!textonly_) {
    pdf_str += " /Im1 Do";
  }
  pdf_str += " Q\n";

This correctly excludes the image from page content, but also generates a few lines that are not needed. I would propose to exclude the whole block as in:
if (!textonly_) {
  pdf_str += "q ";
  pdf_str.add_str_double("", prec(width));
  pdf_str += " 0 0 ";
  pdf_str.add_str_double("", prec(height));
  pdf_str += " 0 0 cm";
  pdf_str += " /Im1 Do";
  pdf_str += " Q\n";
}

Both issues are in the below screenshot:

Sample tiff and generated pdf:
ccitt.zip

@zdenop  @jbreiden, can I take this bug? I worked in pdfium project as committer before. I'd like to do some contributions in tesseract project.

@FarhadKhalafi, are you sure that the reported issue can be reproduced when text_only flag was true? I found the text in generated PDF was invisible when text_only flag is true. The generated pdf is blank. It's different with your reporting however it should be a bug. When text_only flag is false, I reproduced the reported issue. I verified that this issue was fixed by commit f794571195b089b8ae9c047d36ce77b7b27712ab.

@favpdf, The OCR text is always invisible. Tesseract uses a single glyph
font with rendering attribute of 3 for text that is hidden behind the
original image. The text_only flag is expected to create a blank PDF page.
The commit f794571
https://github.com/tesseract-ocr/tesseract/commit/f794571195b089b8ae9c047d36ce77b7b27712ab
does
resolve the inverted image bug as it limits the code to PNG images only. I
am OK with closing this issue.
On Mon, Oct 15, 2018 at 5:37 AM favpdf<EMAIL_ADDRESS>wrote:

@FarhadKhalafi https://github.com/FarhadKhalafi, are you sure that the
reported issue can be reproduced when text_only flag was true? I found the
text in generated PDF was invisible when text_only flag is true. The
generated pdf is blank. It's different with your reporting however it
should be a bug. When text_only flag is false, I reproduced the reported
issue. I verified that this issue was fixed by commit f794571
https://github.com/tesseract-ocr/tesseract/commit/f794571195b089b8ae9c047d36ce77b7b27712ab
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tesseract-ocr/tesseract/issues/1952#issuecomment-429815846,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIGOXQErLUU-z2IFdQYSjvclZ1J8Zg4fks5ulHLQgaJpZM4XLH0I
.

There is something wrong when text_only flag is true. The text rendering mode is set to 3(invisible mode) at line 363:
362  if (res_it->IsAtBeginningOf(RIL_BLOCK)) {
363      pdf_str += "BT\n3 Tr";     // Begin text object, use invisible ink
364      old_fontsize = 0;          // Every block will declare its fontsize
365      new_block = true;          // Every block will declare its affine matrix
366    }
If text_only flag is false, the invisible text is we want because a background image will be inserted to PDF. The image will be rendered and the text can be viewed even the text rendering mode is 3 ('3 Tr' means invisible text rendering mode).
However, it introduces a trouble because there isn't a background image when text_only flag is true. No text will be rendered so the generated pdf is like a blank pdf.

@favpdf, your last comment seems like a different issue.
@FarhadKhalafi,

I am OK with closing this issue.

You opened the issue, so you can close it.

@favpdf, The OCR text is always invisible. Tesseract uses a single glyph font with rendering attribute of 3 for text that is hidden behind the original image. The text_only flag is expected to create a blank PDF page. The commit f794571 <f794571> does resolve the inverted image bug as it limits the code to PNG images only. I am OK with closing this issue.
…
On Mon, Oct 15, 2018 at 5:37 AM favpdf @.***> wrote: @FarhadKhalafi https://github.com/FarhadKhalafi, are you sure that the reported issue can be reproduced when text_only flag was true? I found the text in generated PDF was invisible when text_only flag is true. The generated pdf is blank. It's different with your reporting however it should be a bug. When text_only flag is false, I reproduced the reported issue. I verified that this issue was fixed by commit f794571 <f794571> . — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1952 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/AIGOXQErLUU-z2IFdQYSjvclZ1J8Zg4fks5ulHLQgaJpZM4XLH0I .

@FarhadKhalafi, If the OCR text is always invisible, I think that we should always insert a background image into PDF (we call it as searchable pdf). That means we should remove the text_only flag. In my understanding, the text_only flag means there is no background image.

@favpdf: before suggesting to remove some feature you should search for reason for this implementations...

text_only is for 3rd party tools like @jbarlow83's OCRmyPDF

@favpdf my understanding of the text_only mode is that the process of
inserting the original image into a final PDF is left to the user.
The term text_only is probably a bit misleading as it might imply visible
text. Maybe it could be hidden_text_only or no_image. In any case, we do
expect to create a blank PDF page when text_only flag is true.
I will test and close the issue. Thanks.
On Mon, Oct 15, 2018 at 5:58 AM Amit D<EMAIL_ADDRESS>wrote:

@favpdf https://github.com/favpdf, your last comment seems like a
different issue.
@FarhadKhalafi https://github.com/FarhadKhalafi,
I am OK with closing this issue.
You opened the issue, so you can close it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tesseract-ocr/tesseract/issues/1952#issuecomment-429823233,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIGOXRbxLAWuHNGRSe3SW6Lf75Ei6Aq4ks5ulHhJgaJpZM4XLH0I
.

@FarhadKhalafi, the original image isn't inserted into a final pdf in the text_only (true) mode.  Please check the following code lines in pdfrenderer.cpp:
if (!textonly_) {
line 350:    pdf_str += " /Im1 Do";
}
snprintf(buf2, sizeof(buf2), "/XObject << /Im1 %ld 0 R >>\n", obj_ + 2);
line 852:  const char *xobject = (textonly_) ? "" : buf2;
line 909: if (!textonly_) {
char *pdf_object = nullptr;
int jpg_quality;
api->GetIntVariable("jpg_quality", &jpg_quality);
if (!imageToPDFObj(pix, filename, obj_, &pdf_object, &objsize,
jpg_quality)) {
return false;
}
AppendData(pdf_object, objsize);
AppendPDFObjectDIY(objsize);
delete[] pdf_object;
}

@favpdf my understanding of the text_only mode is that the process of inserting the original image into a final PDF is left to the user. The term text_only is probably a bit misleading as it might imply visible text. Maybe it could be hidden_text_only or no_image. In any case, we do expect to create a blank PDF page when text_only flag is true. I will test and close the issue. Thanks.
…
On Mon, Oct 15, 2018 at 5:58 AM Amit D. @.***> wrote: @favpdf https://github.com/favpdf, your last comment seems like a different issue. @FarhadKhalafi https://github.com/FarhadKhalafi, I am OK with closing this issue. You opened the issue, so you can close it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1952 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/AIGOXRbxLAWuHNGRSe3SW6Lf75Ei6Aq4ks5ulHhJgaJpZM4XLH0I .

@FarhadKhalafi, thank you for explaining.

Fixed by another commit that uses Flate only for png.

I may need to start locking this stuff down with unit tests. I sue hope we aren't transcoding PNG.


Pull Request Template

Are there plans to support pull request templates and issue templates? Would be nice when my editor opened with the PR Templates from the comandline. The templates a in the local copy of the repo anyway. Sould be easy.
Or do i missing some option?

Ah just after writing the Issue I found the option -F for the pull-request and I can use the PULL_REQUEST_TEMPLATE.md. But I can not edit this message. It's directly added to the PR and posted to Github.
Is there a possibility to use the PULL_REQUEST_TEMPLATE.md but edit it before submitting the PR?

Duplicate of #1118 which is being addressed by #1145.

Yes, duplicate. Thanks for the suggestion though!

Ah sorry search for pull request template before opening the issue.
Just missed it.
On 6 Apr 2016 12:38 pm, "Haralan Dobrev"<EMAIL_ADDRESS>wrote:

Duplicate of #1118 https://github.com/github/hub/issues/1118 which is
being addressed by #1145 https://github.com/github/hub/pull/1145.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/github/hub/issues/1156#issuecomment-206300307


Please tag a new 3.2.0 release on NuGet

Please can you make a release with .NET Core 3 support available on NuGet?
See https://github.com/AppMetrics/AppMetrics/issues/480
cc @alhardy

Or host somewhere other than myget, which is down right now :(

Done


[BUG] C-u mapped to doom/backward-kill-to-bol-and-indent under normal mode

Describe the issue
I revert the C-u key back to the emacs definition since I don't use it under evil-mode, and would like to have C-u functionalities under org-mode. Yet after the setting, the key is now bound to doom/backward-kill-to-bol-and-indent.
I would consider it as a minor bug, since C-u is defined as backward-kill-to-bol-and-indent only under insert mode as in vim. Under the default setting, it seems fine because C-u is masked by the evil-scroll-up.
Steps to reproduce

Add the following configuration in the beginning of ~/.doom.d/init.el.
(setq evil-want-C-u-scroll nil
      evil-want-C-d-scroll nil)

Open emacs, SPC h k then C-u.
Then one can see the keybinding.

System information

Place the output of `M-x doom/info` or `~/.emacs.d/bin/doom info` here.

As of ba7b8d6 C-u should no longer be bound globally like that, which should resolve your issue. Let me know if that isn't the case and I'll reopen it. Thanks for bringing it to my attention!

It works out greatly. Much appreciated...

@hlissner Is there a way to get it back to default only in insert mode? It's currently bound like this for me in insert mode:
evil-delete-back-to-indentation is an interactive and compiled
function defined in evil-commands.el.

Signature
(evil-delete-back-to-indentation)

Documentation
Delete back to the first non-whitespace character.

If point is before the first non-whitespace character of a
current line then delete from the point to the beginning of the
current line.  If point is on the beginning of the line, behave
according to evil-backspace-join-lines.

Key Bindings
evil-insert-state-map C-u
evil-surround-read-tag-map C-u
ivy-minibuffer-map C-u
ivy-switch-buffer-map C-u
minibuffer-local-map C-u

Is there a way to get it back to default only in insert mode?
@NightMachinary I'm not certain which "default" you want? evil-delete-back-to-indentation is the default for evil users, in insert mode.

Did you want the univeral argument? Or doom/backward-kill-to-bol-and-indent?

@hlissner I want “universal-argument.” I did it myself with “map!”. Thanks!

Understood. For future reference, C-u is being overridden by evil due to these two settings in the evil module:
(defvar evil-want-C-u-scroll t)  ; moved the universal arg to <leader> u
(defvar evil-want-C-u-delete t)

And can be reversed by adding these lines to ~/.doom.d/config.el:
(setq! evil-want-C-u-scroll nil
       evil-want-C-u-delete nil)


Nested objects with empty request payloads / defaults for all properties

This might be a bit of an edge-case, but I'm running into a problem with nested data objects when the request has an empty payload. In my situation this is happening because I have a data object with defaults for every property.
For example, say you have nested data objects like this:
class ParentData extends Data
{
    public function __construct(
        public bool $example_bool,
        public ChildData $child,
    )
    {
    }
}

class ChildData extends Data
{
    public function __construct(
        public ?string $example_string = 'example',
        public ?int $example_int = 123,
    )
    {
    }
}

When using from there is no problem creating the object from a payload like this:
public function test_from()
{
    $data = ParentData::from([
        'example_bool' => true,
        'child' => [],
    ]);

    $this->assertInstanceOf(ParentData::class, $data);
    $this->assertInstanceOf(ChildData::class, $data->child);
}

That passes. However, when the data object is created from a request with the same payload it fails:
public function test_resolve_from_request()
{
    request()->merge([
        'example_bool' => true,
        'child' => [],
    ]);

    $data = app(ParentData::class);

    $this->assertInstanceOf(ParentData::class, $data);
    $this->assertInstanceOf(ChildData::class, $data->child);
}

I think it would be nice if we could make it a bit more consistent.
In laravel-data versions before 3.5.0 it failed because child would automatically have a required rule added. I was able to bypass this by changing the validation rule from required on nested data objects to present.  This is because I wanted empty arrays to be allowed (required doesn't allow an empty array to pass validation). I think present might be a good choice in this situation as it would allows objects with defaults for every property.
I did this by adding my own rule inferrer that swapped the required rule with present:
class DataPresentInsteadOfRequiredRuleInferrer implements RuleInferrer
{
    public function handle(
        DataProperty $property,
        PropertyRules $rules,
        ValidationContext $context,
    ): PropertyRules
    {
        if (! $property->type->isDataCollectable && ! $property->type->isDataObject) {
            return $rules;
        }

        if (! $rules->hasType(Required::class)) {
            return $rules;
        }

        return $rules->removeType(Required::class)
            ->add(new Present());
    }
}

However, in version 3.5.0 this no longer works. Instead the error is that child isn't passed into the constructor of the parent data object.
I think this is happening because laravel doesn't treat an empty array as validated - even if it had validation rules run on it. E.g.
$validator = Validator::make(
    [
        'settings' => [],
    ],
    [
        'settings' => ['array', 'present'],
        'settings.primary_colour' => ['nullable', 'string'],
    ]
);

dump($validator->validate());// []

dump($validator->errors());// Illuminate\Support\MessageBag { messages: [], format: ":message" }

dump($validator->validated());// []

That exaple passes validation, but settings doesn't appear in validated even though it had the array and present rules run on it.
Is there a way we can support empty arrays as payloads for data objects with defaults?

This has todo with #432, we're going to release v3.5.1 without this feature and iron out the kinks in v4.

@rubenvanassche thanks for the update 😄  I look forward to seeing the improvements you make in v4!

So I've tried this in data v4, which is kinda ready for release and uses the validated properties. This is the test:
it('handles issue B', function (){
    class ParentData extends Data
    {
        public function __construct(
            public bool $example_bool,
            public ChildData $child,
        )
        {
        }
    }

    class ChildData extends Data
    {
        public function __construct(
            public ?string $example_string = 'example',
            public ?int $example_int = 123,
        )
        {
        }
    }

    class DataPresentInsteadOfRequiredRuleInferrer implements RuleInferrer
    {
        public function handle(
            DataProperty $property,
            PropertyRules $rules,
            ValidationContext $context,
        ): PropertyRules
        {
            if (! $property->type->kind->isDataCollectable() && ! $property->type->kind->isDataObject()) {
                return $rules;
            }

            if (! $rules->hasType(Required::class)) {
                return $rules;
            }

            return $rules->removeType(Required::class)
                ->add(new Present());
        }
    }

    config()->set('data.rule_inferrers', [
        \Spatie\LaravelData\RuleInferrers\SometimesRuleInferrer::class,
        \Spatie\LaravelData\RuleInferrers\NullableRuleInferrer::class,
        \Spatie\LaravelData\RuleInferrers\RequiredRuleInferrer::class,
        \Spatie\LaravelData\RuleInferrers\BuiltInTypesRuleInferrer::class,
        \Spatie\LaravelData\RuleInferrers\AttributesRuleInferrer::class,
        DataPresentInsteadOfRequiredRuleInferrer::class,
    ]);

    request()->merge([
        'example_bool' => true,
        'child' => [],
    ]);

    $data = app(ParentData::class);

    dd($data);
});

Outputting:
Spatie\LaravelData\Tests\ParentData {#3414
  #_additional: []
  #_dataContext: null
  +example_bool: true
  +child: Spatie\LaravelData\Tests\ChildData {#3497
    #_additional: []
    #_dataContext: null
    +example_string: "example"
    +example_int: 123
  }
}

This looks allright to me? Could you test your use case with the beyond-data branch? That should almost be what data v4 will be.


Remove the toybox package

High-level description
This package was used only by Spartan.
Refs: https://github.com/dcos/dcos/commit/d4870e89e44958df4be5ddd1f960165531ebb338 (https://github.com/dcos/dcos/pull/6308)
Corresponding DC/OS tickets (required)

DCOS-ID JIRA title / short description.

Related tickets (optional)

DCOS-ID JIRA title / short description.

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain.
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

@mesosphere-mergebot label Ready For Review

@mesosphere-mergebot request-review @drewvanstone @br-lewis @makkes @bamarni @rgo3


Welcome!

Welcome, new localizations team :)
To get this team up and running you have a few initial tasks to accomplish:

[ ] Create a README.md for this repository, it should include:

[ ] A "call to action" pointing to the Issue tracker for new translators to find tasks.
[ ] A list of the team members.
[ ] Instructions on how to log an issue to be added to this team.

[ ] Set the repository description. This should not be in English, it should be in the language for this community :)
[ ] Social Media
[ ] Create a twitter account for this language. Share the password privately with the team.
[ ] Create accounts on other social media popular in this language. Share the passwords private with the rest of the team.
[ ] Make sure you use these accounts not just to promote newly translated material but also to attract people in your community to help with translation tasks.
[ ] Optional: If you plan to do a Google hangout w/ your localization team have @mikeal add you to the Google+ account so that it can post to the iojs YouTube channel. Once you are added there is documentation on how to setup a hangout-on-air.
[ ] Finally, create a new Issue to translate and publish the latest io.js post. Once translated you should post it wherever you think it will get the most visibility to the community speaking you language, you don't have to post it to Medium unless you think that it is best.

Is the translation content-strict? I mean, can I elaborate on some points using my views (community influenced) or it must be just a translation?


feat: implement halo2 common primitives

Description
This PR adds common structures that used by halo2-common to main.

@chokobole Could you fix typo in the commit description in 1b140f1? There is an unnecessary "i" in i[VirtualCell].

@TomTaehoonKim I fixed it.

@chokobole Could you fix typo in the commit description in 1b140f1? There is an unnecessary "i" in i[VirtualCell].

Sorry for ugly rebase..


Add globe translation

Added sample globe component translation. How does it look? I wasn't 100% sure of some texts so feel free to correct!

Awesome @jarben.

Thanks for the review @Justineo ! Will fix asap and make sure I won't repeat these next time:)

Just pushed changes based on the review

@jarben Hi Jarben. Do you have time to fix the review opinions?


Async handling store state changes to increase performance

Although react-redux positioning itself like performant solution for connecting react components to the redux store. However it rerender components on each store state changes synchronously,
that can be an issue, if store changes very frequently(proof). So instead of that we can put component, which should be updated, to the queue and with 60 FPS frequency update each component in queue:
var components = [] // list of all connected components(containers)

function digest () {
  for (var i = 0; i < components.length; i++) {
    var component = components[i]
    if (component.shouldHandleStoreStateChange) {
      component.handleChange()
    }
  }
  requestAnimationFrame(digest)
}

digest()

// ...

trySubscribe() {
  if (shouldSubscribe && !this.unsubscribe) {
    this.unsubscribe = this.store.subscribe(this.queueChanges.bind(this))
    this.handleChange()
    components.push(this)
  }
}

queueChanges () {
  this.shouldHandleStoreStateChange = true
}

handleChange() {

  // ...

  this.hasStoreStateChanged = true
  this.shouldHandleStoreStateChange = false
  this.setState({ storeState })
}

Pros

increases performance up to 1.5x-2.0x and battery live, particularly on mobile devices
doesn`t patch redux core like redux-batched-subscribe, what prevents
inconsistency with redux after major releases
could be optional like pure option

Cons

harder to test async rendering

But if there is a pitfalls or this solution has no rights to live by another reasons, could you give an advice how to increase performance in this case?

I wouldn't be comfortable doing something as invasive by default. It makes testing and debugging harder, and introduces potential issues with some browser APIs that expect synchronous updates within an event handler (example: managing an audio tag on iOS).
I would keep it opt in with tools like https://github.com/tappleby/redux-batched-subscribe/. In the future React itself will learn to delay some updates (https://github.com/facebook/react/issues/6170) so longer term this might stop being an issue, and I don't want to break any existing apps that rely on the current synchronous behavior.

Glad to hear that this issue will be fixed on react level. :+1:
And thank you for detailed answer


introduce serialization module

We will continue using avro4k for serialization, but we need a bridge from the avro-kotlin wrapper and api to kotlinx-serialzation/avro4k.
Task: make repo multi module containing avro-kotlin and avro-kotlin-serialization.
new module avro-kotlin-serialization will be the one stop lib for kotlinx-serilization of avro records/data classes:
[ ] link to latest avro4k lib and set working transitive deps
[ ] links serialization Kind to SchemaType
[ ] ...

fixed via #55


Social Page is Responsive Now

Fixed: #25
Added a media query to make it responsive for phones
Screenshot

@beRajeevKumar  please add the gssoc-ext hactoberfest-accepted and level 2 so that my name comes on leaderboard please


fix: solve trending page's show all loading issue

Related Issue

Closes: #100
Description of Changes

Checklist:

[x] My code adheres to the established style guidelines of this project.
[x] I have conducted a self-review of my code.
[x] I have included comments in areas that may be difficult to understand.
[ ] I have made corresponding updates to the project documentation.
[ ] My changes have not introduced any new warnings.

Screenshots

Original
Updated

Please provide any necessary screenshots to illustrate the changes made.

You can get trending movies from the API endpoints. Try that as showing no movies is not a good option when you have some.

You can get trending movies from the API endpoints. Try that as showing no movies is not a good option when you have some. @suzy-g38

Actually, there were no movies in the trending section...the array length was 0. That's why it was in the loading state previously.
Okay then I will see if there is any API or anything in the movie db.


Add server to Grafana dashboard and allowing filtering all metrics

Requires mapping update: https://github.com/alhardy/AppMetrics.Extensions.Elasticsearch/blob/dev/visualization/App.Metrics.Sandbox-Elasticsearch-IndexAndMappingSetup.json


Take window boundaries into account

I personally like this behavior very much, but if you think otherwise could we then maybe support is behind a configuration option?

Thanks for sharing this @svanharmelen. If I'm reading correctly this will make the navigation keys do nothing if at the relevant edge of the screen, as opposed to wrapping around as they currently do? I've not heard much from folks looking for this functionality, and I personally wouldn't want this, so I'd at least want to see this behind an option. That said, it also only works on versions of tmux from 2.6 and up. All that combined leans me towards closing this as my driving goal here is to keep the plugin as simple as possible, and make it largely "just work" for folks. Again, thanks for sharing this, but for now I'm going to close this.

All good! Thanks for the feedback 👍🏻


Translations

Thanks for translating the module. Can I be helpful in any way to translate the names of the countries?

@hildwin
if you like yes, but we will need translations for 'es' and 'de' too

I've added the German names. I'll try to translate it via Wikipedia and Google Translate into Spanish, too. (If you trust me...)

#23


closes #835: update bootstrap cache on msg send

Move peer to the top of the bootstrap cache, if we are sending a message to it. That means this peer is the most active.

Deprecated in favor of https://github.com/maidsafe/crust/issues/1138


feat: add wallet entity and wallet factory

Get current user balances (Eth, POLY, or any other ERC20 token)

:tada: This PR is included in version 2.0.1-beta.77 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Command failed with ENOENT: linst-staged --debug when pnpm linst-staged --debug

Description
When lint-staged is runned, either by a hook or manually, we always get:
pnpm linst-staged                                           INT ✘
 ERR_PNPM_RECURSIVE_EXEC_FIRST_FAIL  Command failed with ENOENT: linst-staged
spawn linst-staged ENOENT

But, when we run it with npx, there is no problem.

Steps to reproduce
Just install lint-staged using pnpm.

Debug Logs
There is no debug logs cause:

expand to view
pnpm linst-staged --debug                             1 ✘  13s 
 ERR_PNPM_RECURSIVE_EXEC_FIRST_FAIL  Command failed with ENOENT: linst-staged --debug
spawn linst-staged ENOENT

However, using npx:
npx lint-staged                                               1 ✘
✔ Preparing lint-staged...
✔ Hiding unstaged changes to partially staged files...
❯ Running tasks for staged files...
  ❯ .lintstagedrc.json — 5 files
    ❯ *.{js,jsx,ts,tsx} — 1 file
      ✔ prettier --check --write
      ✖ eslint --fix [FAILED]
    ↓ *.css — no files [SKIPPED]
    ✔ *.json — 2 files
↓ Skipped because of errors from tasks. [SKIPPED]
↓ Skipped because of errors from tasks. [SKIPPED]
✔ Reverting to original state because of errors...
✔ Cleaning up temporary files...

✖ eslint --fix:

Oops! Something went wrong! :(

ESLint: 8.30.0

ESLint couldn't find the plugin "eslint-plugin-prettier".

(The package "eslint-plugin-prettier" was not found when loaded as a Node module from the directory "/home/luisalaguna/Projects/react-ts-vite-template".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

    npm install eslint-plugin-prettier@latest --save-dev

The plugin "eslint-plugin-prettier" was referenced from the config file in ".eslintrc.json".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

We can get the issue that was blocking the lint-staged execution.
Or:
npx lint-staged                                               1 ✘
✔ Preparing lint-staged...
✔ Hiding unstaged changes to partially staged files...
❯ Running tasks for staged files...
  ❯ .lintstagedrc.json — 5 files
    ❯ *.{js,jsx,ts,tsx} — 1 file
      ✔ prettier --check --write
      ✖ eslint --fix [FAILED]
    ↓ *.css — no files [SKIPPED]
    ✔ *.json — 2 files
↓ Skipped because of errors from tasks. [SKIPPED]
↓ Skipped because of errors from tasks. [SKIPPED]
✔ Reverting to original state because of errors...
✔ Cleaning up temporary files...

✖ eslint --fix:

/home/luisalaguna/Projects/react-ts-vite-template/commitlint.config.ts
  0:0  error  Parsing error: ESLint was configured to run on `<tsconfigRootDir>/commitlint.config.ts` using `parserOptions.project`: <tsconfigRootDir>/tsconfig.json
However, that TSConfig does not include this file. Either:
- Change ESLint's list of included files to not include this file
- Change that TSConfig to include this file
- Create a new TSConfig that includes this file and include it in your parserOptions.project
See the typescript-eslint docs for more info: https://typescript-eslint.io/linting/troubleshooting##i-get-errors-telling-me-eslint-was-configured-to-run--however-that-tsconfig-does-not--none-of-those-tsconfigs-include-this-file

Environment

OS:  Manjaro Linux x86_6
Node.js: v18.12.
lint-staged: 13.1.0

In your copy-pasted output, it says linst-staged instead of lint-staged.


establish gh-pages to get upated-site published

Update-site artifacts are to be publicly available.
There should appear a residence under GitHub  Pages facilities.

gh-pages  branch is created


Re-add removed migrations to avoid error messages

If we no longer need a migration, we should remove the contents, but not the file itself.
This is because people who have already migrated past a particular migration, but then upgrade to a newer code release, will be missing the migration files that they have already run.
This causes an error on server startup which we would like to avoid.
https://bugzilla.redhat.com/show_bug.cgi?id=1417313
Backporting this change will allow users who migrate from darga to the latest euwe release to avoid these messages.

@carbonin Looks like Travis found an issue with one of the migration dates.

Yeah, that was expected @bdunne, but to fix this issue we will need to merge this while it's red.
We will look a bit more into how to do that properly so that we don't break stuff too badly.

Closing this in favor of #14814


text (.txt) sample file added to basic test data

Thanks for the test case! But I see in the commit history something unrelated (windows testing, etc.). can you send a clean PR with just this new test case?
And about windows testing: we do need help, so feel free to open an issue to start discussion in case you found problems. Thanks!


Add information about Henrietta Leavitt

This pull request adds information about American astronomer Henrietta Swan Leavitt. Please check the id number.
x   General (misc updates, features, fixes, etc.)
x   I have checked my code and corrected any misspellings.
x   I have performed a self-review of my own code.
x   My changes generate no new warnings.
x   My code follows the style guidelines of this project (if applicable)

Thanks for the contribution 👍. Issue #37 PR #39


Update ballerina test command help text

Purpose
$subject.
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

:exclamation: No coverage uploaded for pull request base (fix-help-text@2c262ce). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             fix-help-text   #18829   +/-   ##
================================================
  Coverage                 ?   14.95%
================================================
  Files                    ?       47
  Lines                    ?     1230
  Branches                 ?      187
================================================
  Hits                     ?      184
  Misses                   ?     1033
  Partials                 ?       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c262ce...1f8bba0. Read the comment docs.


Sync users against LDAP (in the portal)

Manage user locking via LDAP syncing. Fixes #523.
Changes in this pull request:

Create TaskHandler to handle process flow for tasks (implemented via FS2 Stream)
Create simple table to handle task contention for distributed portal setup

If not already should prob be logging a list of a all users that were locked in a sync so it can easily be fed into a reversion script

closing, picked up and merged in #718


New article "DevTools external resources"

Rendered article for review:
Resources, talks, videos, and blogs about DevTools
Rendered article from other PR:
Resources, talks, videos, and blogs about WebView2

Docs Build status updates of commit 802a885:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/resources.md
:white_check_mark:Succeeded
View

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 9e23459:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/resources.md
:white_check_mark:Succeeded
View

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit c5cc6d0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/resources.md
:white_check_mark:Succeeded
View

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit e069549:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/resources.md
:white_check_mark:Succeeded
View

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit dec5a15:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/resources.md
:white_check_mark:Succeeded
View

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Docs: clarify address space connector and address forwarder conceptual information

Type of change

Documentation

Description
Fix asciidoc formatting issue and clarify address connector and address forwarder conceptual information
Checklist
Please go through this checklist and make sure all applicable tasks have been done

[ ] Update/write design documentation in ./documentation/design
[ ] Write tests and make sure they pass
[X] Update documentation
[ ] Check RBAC rights for Kubernetes / OpenShift roles
[ ] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
[ ] Reference relevant issue(s) and close them after merging
[ ] Update CHANGELOG.md

@lulf @rgodfrey @k-wall, Please review this PR with a view to the RNs information (that is, so terminology is consistent)

LGTM

Merging this as it seems review comments have been addressed


With multiple charts on page, tooltips for each chart all show data from last updated chart

I have created a page with a lot of charts on it in a grid.  When I load all the data into the page and update the charts, everything works fine, however the charts all show the same tooltip data from the last updated chart.  The label is correct (matches the x-value at the point), but the y-value is the same across all charts.
Here is my code:
<script>
  var paymentDailyChart, paymentWeeklyChart, paymentMonthlyChart,
    profitDailyChart, profitWeeklyChart, profitMonthlyChart,
    expensesDailyChart, expensesWeeklyChart, expensesMonthlyChart, options,
    config, default_data, update_data;

  options = {
    responsive: true,
    legend: {
      display: false
    },
    scales: {
      yAxes: [{
        ticks: {
          beginAtZero: true
        }
      }]
    }
  };

  default_data = {
    labels: [0,0,0,0,0,0,0],
    datasets: [{
      fill: true,
      data: [0,0,0,0,0,0,0]
    }]
  };

  config = { type: 'line', options: options, data: default_data };

  paymentDailyChart = new Chart(document.getElementById("daily-payment-chart"), config);
  paymentWeeklyChart = new Chart(document.getElementById("weekly-payment-chart"), config);
  paymentMonthlyChart = new Chart(document.getElementById("monthly-payment-chart"), config);
  profitDailyChart = new Chart(document.getElementById("daily-profit-chart"), config);
  profitWeeklyChart = new Chart(document.getElementById("weekly-profit-chart"), config);
  profitMonthlyChart = new Chart(document.getElementById("monthly-profit-chart"), config);
  expensesDailyChart = new Chart(document.getElementById("daily-expenses-chart"), config);
  expensesWeeklyChart = new Chart(document.getElementById("weekly-expenses-chart"), config);
  expensesMonthlyChart = new Chart(document.getElementById("monthly-expenses-chart"), config);

  update_data = function(){
    $.getJSON('/stats_charts.json', function(data){
      paymentDailyChart.data.labels = data['days_payments']['labels'];
      paymentDailyChart.data.datasets[0].data = data['days_payments']['data'];
      paymentDailyChart.update();

      paymentWeeklyChart.data.labels = data['weeks_payments']['labels'];
      paymentWeeklyChart.data.datasets[0].data = data['weeks_payments']['data'];
      paymentWeeklyChart.update();

      paymentMonthlyChart.data.labels = data['months_payments']['labels'];
      paymentMonthlyChart.data.datasets[0].data = data['months_payments']['data'];
      paymentMonthlyChart.update();

      profitDailyChart.data.labels = data['days_profits']['labels'];
      profitDailyChart.data.datasets[0].data = data['days_profits']['data'];
      profitDailyChart.update();

      profitWeeklyChart.data.labels = data['weeks_profits']['labels'];
      profitWeeklyChart.data.datasets[0].data = data['weeks_profits']['data'];
      profitWeeklyChart.update();

      profitMonthlyChart.data.labels = data['months_profits']['labels'];
      profitMonthlyChart.data.datasets[0].data = data['months_profits']['data'];
      profitMonthlyChart.update();

      expensesDailyChart.data.labels = data['days_expenses']['labels'];
      expensesDailyChart.data.datasets[0].data = data['days_expenses']['data'];
      expensesDailyChart.update();

      expensesWeeklyChart.data.labels = data['weeks_expenses']['labels'];
      expensesWeeklyChart.data.datasets[0].data = data['weeks_expenses']['data'];
      expensesWeeklyChart.update();

      expensesMonthlyChart.data.labels = data['months_expenses']['labels'];
      expensesMonthlyChart.data.datasets[0].data = data['months_expenses']['data'];
      expensesMonthlyChart.update();

      $('#overlay').remove();
    });
  };

  update_data();

  window.setInterval(function(){
    update_data();
  }, 3600000);
</script>

With this code, the charts all look correct and have the right x and y axises and line data, but the tooltips show the correct x axis data for each chart (Mon, Tues, Weds... for daily charts; 1 week, 2 week, 3 week... for weekly charts; etc), but the value shown for every one is the value at the same index for the final chart (expensesMonthly)...
I've also noticed some other weird behavior on update... If I move the chart updates to a block after loading the data, all of the charts will have the exact same data... like this:
salaryDailyChart.data.labels = data['days_salary']['labels'];
salaryDailyChart.data.datasets[0].data = data['days_salary']['data'];
salaryWeeklyChart.data.labels = data['weeks_salary']['labels'];
salaryWeeklyChart.data.datasets[0].data = data['weeks_salary']['data'];
salaryMonthlyChart.data.labels = data['months_salary']['labels'];
salaryMonthlyChart.data.datasets[0].data = data['months_salary']['data'];

salaryDailyChart.update();
salaryWeeklyChart.update();
salaryMonthlyChart.update();

^ all 3 charts will be the exact same unless I update inline.
Any ideas?

I'm not an expert, but I would try defining separate config and data blocks for each chart. I'm guessing charts.js assumes that each config/data block is separate for each chart, so it's storing metadata specific to each chart in that area, but it's actually a shared area, because of what you've done here.

@bradherman sharing the data object is not possible before v2.1.0. I think sharing configs will work. Can you put together a jsfiddle that reproduces this issue?

@etimberg https://jsfiddle.net/83pzooLq/
Getting the issue there... Pardon me if it's a little messy, I don't ever write js these days... This has just been a fun little project for me

Also as mentioned, if you run the update call all in a row, the charts will show the same data too... See this fiddle: https://jsfiddle.net/9ca0m7z3/

So I'm pretty sure what the problem is. What happens is that the data object is the shared between all charts but the data in the data object is changed before each chart is created. When the tooltip displays, it goes back to the data object to query the data and hence looks at the last data
All the charts should have a unique data object if they are to have different data.
I updated your fiddle at https://jsfiddle.net/ckgwhfcy/1/

@etimberg Ahhh, that makes sense... Would also explain why the charts would show the same information when updated after loading all the data in.  Thanks a ton!

np, glad I could help


'unauthorized' event handler

The example doesn't give any notification on an Unauthorised error.
It would be nice to log something on the server too, but I don't see how to do this.

Thanks a lot!


Adding more than 20 2FA accounts creates lots of issues.

Hi,
If you add more than 20 different 2FA accounts, the apps behaves completely erratic.
For instance:

It won't led you add a 21st account or more.
Performance issues, memory leaks:
Closing and reopening the app with 20 accounts, will duplicate your existing 2FA accounts:  (Probably related to #14)
Windows Hello sometimes will take a lof of time to ask for credentials.

Yes thats because credential locker only supports upto 20 entries.
What actions cause the memory leaks? Is it just having more than 20 accounts? Does it reduce if there is less than 20 accounts?
This is being looked at
How often does it take a long time to ask for credentials?

Yes thats because credential locker only supports upto 20 entries.
What actions cause the memory leaks? Is it just having more than 20 accounts? Does it reduce if there is less than 20 accounts?
This is being looked at
How often does it take a long time to ask for credentials?

Would there be a possibility to support more than 20?
It is having the 20 accounts at the same time, as soon as I launch the app, I can see in Task Manager a CPU spike and memory usage increasing. I have removed 5 accounts and I can see that the memory usage is well and stable.
Gotcha.
With the 20 accounts, on first launch is almost instantly, if I closed it and launch it a second time, it can take between 15-20 seconds to show the Windows Hello window.

Yes thats because credential locker only supports upto 20 entries.

What actions cause the memory leaks? Is it just having more than 20 accounts? Does it reduce if there is less than 20 accounts?

This is being looked at

How often does it take a long time to ask for credentials?

Would there be a possibility to support more than 20? Edit: I see that's a limitation from MS... goddamn, I love this app but I need something that supports more than 20 accounts...

It is having the 20 accounts at the same time, as soon as I launch the app, I can see in Task Manager a CPU spike and memory usage increasing. I have removed 5 accounts and I can see that the memory usage is well and stable.

Gotcha.

With the 20 accounts, on first launch is almost instantly, if I closed it and launch it a second time, it can take between 15-20 seconds to show the Windows Hello window.

Hi for the 20 account limitation there is another version of Protecc that uses encrypted database instead of credential locker and will support 20+ accounts, syncing, groups and images due to no limitations however that one will probably be paid
2. I see I believe it's because the animated text box control is heavy to use and isn't designed to have 20 instances. I will think about what I can do with this
4. The reason the first launch is fast is because of the pre launch technique. I will add optimisation to make initial windows hello launch faster

Alright so I have added it so that if there are more than 10 cards the subsequent cards wont have animation. Yes it is not ideal but it improves performance

And I added a block to add more than 20 accounts + startup improvements. I think this should resolv the issues so I am closing this now


ESP32-EYE person_detection example will not build

@tensorflow/micro
Ubuntu 20.04.1 LTS
GNU Make 4.2.1
ESP IDF v4.2 checked out tag and ran install.sh and source export.sh
Cloned esp32-camera into idf components
I tried several different TF commits. I ran git clean -f -x -d between TF versions.
TF master at 49524d68892d13265ec33b0e1cf7422fd71e316c
Making the ESP project works but running "idf.py build" gives:
CMake Error at /home/felix/esp-idf/tools/cmake/component.cmake:468 (add_library):
  Cannot find source file:

    /home/felix/source/tensorflow/tensorflow/lite/micro/tools/make/gen/esp_xtensa-esp32/prj/person_detection_int8/esp-idf/main/tensorflow/lite/micro/examples/person_detection_experimental/detection_responder.cc

I edited the file tensorflow/tensorflow/lite/micro/tools/make/gen/esp_xtensa-esp32/prj/person_detection_int8/esp-idf/main/CMakeLists.txt   and added  "../components/tfmicro/"  to the front of all the paths.
I can now run idf.py menuconfig to set (necessary) support for array rtc_gpio_desc.
Now I run "idf.py build" and get:
 #error "No camera module configured, please configure in menuconfig"

The camera module selection is not showing in the menuconfig system when running tensorflow/lite/micro/tools/make/gen/esp_xtensa-esp32/prj/person_detection_int8/idf.py menuconfig. (should I run it from somewhere else?)
I manually added "#define CONFIG_CAMERA_MODEL_ESP_EYE 1" in /tensorflow/tensorflow/lite/micro/tools/make/gen/esp_xtensa-esp32/prj/person_detection_int8/esp-idf/components/tfmicro/tensorflow/lite/micro/examples/person_detection/esp/app_camera_esp.h.
I then run idf.py build again.  This time I get a link error:
/home/felix/.espressif/tools/xtensa-esp32-elf/esp-2020r3-8.4.0/xtensa-esp32-elf/bin/../lib/gcc/xtensa-esp32-elf/8.4.0/../../../../xtensa-esp32-elf/bin/ld: esp-idf/main/libmain.a(main_functions.cc.obj): in function `loop':
/home/felix/source/tensorflow/tensorflow/lite/micro/tools/make/gen/esp_xtensa-esp32/prj/person_detection_int8/esp-idf/build/../components/tfmicro/tensorflow/lite/micro/examples/person_detection/main_functions.cc:101: undefined reference to `GetImage(tflite::ErrorReporter*, int, int, int, signed char*)'

In "tensorflow/tensorflow/lite/micro/tools/make/gen/esp_xtensa-esp32/prj/person_detection_int8/esp-idf/components/tfmicro/tensorflow/lite/micro/examples/person_detection/esp/image_provider.cc"  Change the definitions of
TfLiteStatus PerformCapture(tflite::ErrorReporter* error_reporter, int8_t* image_data)

and
TfLiteStatus GetImage(tflite::ErrorReporter* error_reporter, int image_width, int image_height, int channels, int8_t* image_data)

The image_data pointer was wrongly typed as uint8_t*, changing to int8_t* fixes the undefined reference issue and the example now builds and runs! Hurray!  That was not easy.
TF v2.4.0
make -f tensorflow/lite/micro/tools/make/Makefile TARGET=esp generate_person_detection_int8_esp_project
tensorflow/lite/micro/tools/make/Makefile:418: warning: overriding recipe for target 'tensorflow/lite/micro/tools/make/downloads/person_model_int8'
tensorflow/lite/micro/tools/make/Makefile:418: warning: ignoring old recipe for target 'tensorflow/lite/micro/tools/make/downloads/person_model_int8'
tensorflow/lite/micro/tools/make/Makefile:378: tensorflow/lite/micro/tools/make/targets/esp_makefile.inc: No such file or directory
make: *** No rule to make target 'tensorflow/lite/micro/tools/make/targets/esp_makefile.inc'.  Stop.

I renamed esp32_makefile.inc to esp_makefile.inc and now generation works.
cd tensorflow/lite/micro/tools/make/gen/esp_xtensa-esp32/prj/person_detection_int8/esp-idf/
idf.py build fails with....
CMake Error at /home/felix/esp-idf/tools/cmake/component.cmake:468 (add_library):
  Cannot find source file:

    /home/felix/source/tensorflow/tensorflow/lite/micro/tools/make/gen/esp_xtensa-esp32/prj/person_detection_int8/esp-idf/main/tensorflow/lite/micro/examples/person_detection_experimental/detection_responder.cc

Edit the file tensorflow/tensorflow/lite/micro/tools/make/gen/esp_xtensa-esp32/prj/person_detection_int8/esp-idf/main/CMakeLists.txt   add ../components/tfmicro/  to the front of all the paths
I can now run idf.py menuconfig to set (necessary) support for array rtc_gpio_desc.
idf.py build now results in
fatal_exception  esp-idf/app_trace/libapp_trace.a  -lgcov  esp-idf/app_trace/libapp_trace.a  -lgcov  -lc  -lm && :
/home/felix/.espressif/tools/xtensa-esp32-elf/esp-2020r3-8.4.0/xtensa-esp32-elf/bin/../lib/gcc/xtensa-esp32-elf/8.4.0/../../../../xtensa-esp32-elf/bin/ld: esp-idf/esp32/libesp32.a(cpu_start.c.obj):(.literal.main_task+0x18): undefined reference to `app_main'

TF v2.3.0
make -f tensorflow/lite/micro/tools/make/Makefile TARGET=esp generate_person_detection_int8_esp_project
cd tensorflow/lite/micro/tools/make/gen/esp_xtensa-esp32/prj/person_detection_int8/esp-idf/
idf.py build fails with....
CMake Error at /home/felix/esp-idf/tools/cmake/component.cmake:468 (add_library):
  Cannot find source file:

    /home/felix/source/tensorflow/tensorflow/lite/micro/tools/make/gen/esp_xtensa-esp32/prj/person_detection_int8/esp-idf/main/tensorflow/lite/micro/examples/person_detection_experimental/detection_responder.cc

Can anyone point to a combination of dependencies and TF that this example will actually build and run for esp32? I've managed to run the hello world but I'd like a more sophisticated example to work from.

Hi @felixcollins this is fixed bug. tag v2.4.0 doesn't contain the fix, hence the error.
Please cherry pick following commit: https://github.com/tensorflow/tensorflow/commit/a4373953b95a298913318a9722b5d8347f8cf1e5 or switch to master.

@vikramdattu  Did you read my description?  For TF 2.4 I said "I renamed esp32_makefile.inc to esp_makefile.inc and now generation works."   After that it fails with a link error : "undefined reference to `app_main'".   I'll try again with Master and report back, but last time I tried it had similar issues. I changed to trying to get a tag to work so at least it was a stable point to work from.

@vikramdattu  Did you read my description?  For TF 2.4 I said "I renamed esp32_makefile.inc to esp_makefile.inc and now generation works."   After that it fails with a link error : "undefined reference to `app_main'".   I'll try again with Master and report back, but last time I tried it had similar issues. I changed to trying to get a tag to work so at least it was a stable point to work from.

@vikramdattu I updated the issue description with my experiences with master branch.

@vikramdattu I updated the issue description with my experiences with master branch.

@vikramdattu  Yay! I got it working.  I just updated the description again. I managed to get it to build and run but as you can see there are a few issues with the project generation system and a couple of small mistakes in the image_provider.cc file for esp.

@vikramdattu  Yay! I got it working.  I just updated the description again. I managed to get it to build and run but as you can see there are a few issues with the project generation system and a couple of small mistakes in the image_provider.cc file for esp.

@felixcollins can you please raise an PR for the fix so it can be merged?

@felixcollins can you please raise an PR for the fix so it can be merged?

@vikramdattu Sorry, I've been taken off this work now and do not have a fork set up to submit a PR from. The only changes I could submit would be the fix of the type the image data pointer for PerformCapture and GetImage in esp/image_provider.cc. This is simply removing the two 'u' characters from the front of the type. The rest of the build system issues I did not fix, I just hacked around them.

@vikramdattu Sorry, I've been taken off this work now and do not have a fork set up to submit a PR from. The only changes I could submit would be the fix of the type the image data pointer for PerformCapture and GetImage in esp/image_provider.cc. This is simply removing the two 'u' characters from the front of the type. The rest of the build system issues I did not fix, I just hacked around them.

Hello @felixcollins
I wonder how you fix this problem.
In #47063,
msb@msb-VirtualBox:/usr/my/tensorflow$ make -f tensorflow/lite/micro/tools/make/Makefile TARGET=esp generate_person_detection_esp_project
tensorflow/lite/micro/tools/make/downloads/flatbuffers already exists, skipping the download.
tensorflow/lite/micro/tools/make/downloads/pigweed already exists, skipping the download.
make: *** No rule to make target 'generate_person_detection_esp_project'.  Stop.

Can you give me any advice or comments?
It's not working the beginning of the project.

Sorry @SunBeenMoon  I spent ages hacking around getting a build to work. I recommend you come back in a few years when they have things stabilised. The TFLite Micro seems to be very bleeding edge at the moment.

Hello @felixcollins
I wonder how you fix this problem.
In #47063,
msb@msb-VirtualBox:/usr/my/tensorflow$ make -f tensorflow/lite/micro/tools/make/Makefile TARGET=esp generate_person_detection_esp_project
tensorflow/lite/micro/tools/make/downloads/flatbuffers already exists, skipping the download.
tensorflow/lite/micro/tools/make/downloads/pigweed already exists, skipping the download.
make: *** No rule to make target 'generate_person_detection_esp_project'.  Stop.

Can you give me any advice or comments?
It's not working the beginning of the project.

Instead of generating 'person detection’, I tried generate_person_detection_int8_esp_project and had the project folder generated in \tools\make\gen path, however the main folder was empty and i manually moved the files to the project folder and modified the CMakeLists.txt

I ran the person detection model in the example on my ESP-EYE but the performance wasn't as good as I expected, I wondered if it was because the camera needed some time to focus..., or it's just because of something else?

Hi @yifeif what's the time it is taking per inference for you?
Last time I checked it is taking 700ms with greyscale model and about 1450ms (~1.5sec) for int8 model.

Hi@ vikramdattu, I simply used the stopwatch on my smartphone and I would like to say that's about 2secs/inference (that's longer than yours hh). In fact I am following an O'Relly's book called "TinyML" and this example belongs to Chap 9 & 10. The book mentioned that since the person detection model is much larger, it would take longer to run inference, so I think that 2sec delay is acceptable. Plus, I believe on the Sparkfun boards the time would take even longer:  'When the program is running the blue LED will toggle on and off, once for each inference. Because the vision model we are using for person detection is relatively
large, it takes a long time to run inference—around 6 seconds in total.'

Hi @felixcollins !
Could you give it a try the documentation on person detection from tflite-micro repo with CMake 3.16 or higher.
Thank you!


[Docs] Update AKS Documentation for Service-level Port Forwarding

Issue Description:
The current documentation for AKS (Azure Kubernetes Service) in the Supported providers section contains instructions for port-forwarding that involve a complex process of identifying and selecting a specific pod. This process can be streamlined and improved to enhance user-friendliness.
Proposed Change:
Introduction of Service-level Port Forwarding: The documentation should be updated to include clear instructions on how to perform service-level port forwarding. This change will simplify the process for users and eliminate the need to manually identify and select individual pods.
Current State
export POD_NAME=$(kubectl get pods --namespace meshery -l "app.kubernetes.io/name=meshery,app.kubernetes.io/instance=meshery" -o jsonpath="{.items[0].metadata.name}")
kubectl --namespace meshery port-forward $POD_NAME 9081:8080
Desired State
kubectl port-forward svc/meshery --namespace meshery  9081:9081

Contributor Guides and Handbook

📚 Instructions for contributing to documentation

Meshery documentation site and source

🛠 Meshery Build & Release Strategy
🎨 Wireframes and designs for Meshery UI in Figma (open invite)
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

@aboobakersiddiqr63  assign this to me

@shubhankar-mern contributor needs to review the proposal and should assign, I would request the assignee to assign this task to @shubhankar-mern :)

Thank you, gents. 👍


[Question] List by Recent instead of Top tags

Testing the script it looks like it always loads the "top" filter for tags. Is there a way to filter by "recent" instead since engagement is way higher there since posts are more fresh.

I think this should be fixed with the recently added -il, --inlast argument that targets posts within last n days. In the next push, I will add a hours, minutes filter to increase the depth of the search.


Storybook First Pass

#26
This PR is just a First Pass:

[x] Setup: add Storybook and Enzyme into package.json
[x] Take ui-components and move it into storybook

Each story should at the minimum test props: Empty, Wrong Type, Oversized with the knobs add-on.

[x] Adapt components as necessary if they are not working as expected outside of our app environment

[x] storybook addon-actions to simulate event handlers with data

[x] Deploy it online https://www.learnstorybook.com/react/en/deploy/

2nsd pass should include:

automated visual CI testing

deployed to https://paritytech.github.io/substrate-light-ui/

Let's see if the deploy script in run on CI!


Change profile medium screens

Closes #1019

Thanks! It's better but it still looks rather odd with a width of 700px - 950px. Maybe the left section needs a max width?
Also, the profile pic is too large in the sm breakpoint. I think it needs a maximum size.

I set the left column to be half the size of the right column in the medium breakpoint. Also, I set a max width for the avatar image at 288px. In the last commit, I made some spacing fixes in order to make the profile page look like Figma, (basically spacing and paddings), as I was messing around with them when making the commit, let me know if that's OK.

About the divider:
I agree with the point of not spacing the components. I changed it to equal spacing (16px top and bottom). The point is that the divider is often used with text above and/or below. As text always have extra spacing due to line-height, there is often need for adjusting. Here in this screen, 2 out of 3 lines would need extra margin-top or extra margin-bottom in order to keep even spacing.
Needs extra margin-top

Needs extra margin-bottom

This can be adjusted with and extra div and writing an extra class on each component. But in the long run we will end up with hundreds of classes that will basically be either margin-top: 0.5rem or margin-bottom 0.5rem (as this is a very common use-case). That doesn't scale well and it slows down CSS rendering.
Instead, I would propose to use pure html for this. Right now we have a dummy divider component just with styles wrapping a MUI component that is dummy as well.
I would instead use hr as plain html, so:

could be used the "default" divider instead of <Divider />, and

would be used when needed to add 8px to margin-top, 8px to  margin-bottom or 8px to both. In CSS we would just need to add 3 classes that would be non-scoped:
.o-divider : {
    border: none;
    height: 1px;
    margin: 1rem 0;
    flex-shrink: 0;
    background-color: rgba(0, 0, 0, 0.12);
}

.o-divider--extra-top-1 {
    margin-top: 1.5rem
}

.o-divider--extra-bottom-1 {
    margin-bottom: 1.5rem
}

(here o- would be a namespacing for objects, I'm following the BEMIT convention in order to avoid clashes)
Let me know what you think!

Yes, it is a common use case. However it is also used in other places like the search filter dialog.
I think you've got the right idea with a easy way to add it, but let's not introduce another customisation system. Instead maybe you want to add two more props to <Divider> like padTop and padBottom (or some other name) which add another jss className
Or even better, until we have need of bottom padding (maybe we won't), just one prop - text - for text dividers which gives the extra top margin.

I set both props margTop and margBottom as I already needed, and added them in the html. Let me know if you see anything else! Cheers

unitless line-height is pretty messy to use https://stackoverflow.com/questions/12303169/line-height-without-units#answer-12304722 and an lead to lots of layouts problems difficult to debug. When set to a fixed unit it makes things easier. In this context, the line-height is fixed by design, and it will change if design changes, imo it's way better to set it with units.

What kind of layout problems? In the link, they quite MDN saying unitless is the preferred way to set line height.

It was more about the second comment (the linked one)

Yes, it is a ratio: 1.5 means 1.5 times the font size of the element. So it means the same as 1.5em or 150%, but with one important exception: in inheritance, when a pure number is used, the number is inherited, not the computed value.
So if you have an element with font size 24pt, line-height: 1.5 sets the line height to 36pt. But if the element has a child, i.e. an inner element, with font size of 10pt, and without any line height set on it, then the child inherits the line-height value of 1.5, which means 15pt for that element. If, on the other hand, the line height were set to 1.5em or 150%, then the child would inherit the computed value of 36pt, creating grotesque line spacing.
Technically, this is hidden under a formulation that says. for a pure number used as line-height value: “The computed value is the same as the specified value.” So, nominally, the child inherits the “computed” value of 1.5, which will then be interpreted in the context of the child (1.5 times its font size).

A fixed unit is far more consistent, with no drawbacks. Also, take in account that our spaces are "fixed blocks" of 8px, while the unitless tend to give as a result things like semipixels and values out of grid. So if I set unitless to a 24px h1, I will have to change the line height from 3rem to 2. Then if somebody changes h1 to 25px, line height will then be 50px that is out of the grid. In cases where you have to set fractions in unitless the result could lead to subpixels.
In summary, as a good practice I try to avoid unitless (and I would say that is rarely used in good layouts), but if you feel is needed let me know and I'll add that.

There is a drawback - if in the future the font size is changed in the theme, all valued line-heights need to be found and recalculated, whereas a unitless line height will be fine.
It's a good point about the grid, but we tend to be very loose with the grid anyway, so I think it's not worth the extra maintenance burden.
I don't think inheritance is a factor for us, since we are only setting it on header elements which never have children of other sizes.

I'm ok with setting is a unitless, but tbh I don't get what would be the less manteinance burden. Could you maybe ellaborate that, so I have something to stick on?

Sure - the design team decides h1, now 1.5rem, should be 2rem and we change it in the theme, if we have used a rem or px value, we will have to find every instance of lineHeight and recalculate it for the new font size (eg. 3rem would become 4rem). If we use a unitless size (here would be lineHeight: 2), no change would be needed.
Unless I'm misunderstanding why you added line height here?

A fixed unit is far more consistent, with no drawbacks.

Since you are using rem here, this is not really an issue, but in general the biggest drawback with using a fixed unit line-height (especially when used against px) is that it's bad for accessibility, as it won't scale correctly if the user changes their browser's default font size.
I'd rather our app be usable than chasing for "pixel perfection" when our grid isn't very precise anyway. If this flexibility is breaking designs, this is something we need to work with designs to get better at as a team so we don't come up with brittle designs that will break easily. This will be important especially as we consider having app across multiple languages further down the line.

I think I fixed all the issues. Finally I used margins to fix the name spacing, so no custom lineHeight

@Jesus82: are you merging this?

@Jesus82: are you merging this?

Sorry, I didn't know I had the permissions to merge. I've just seen there are conflicts now. Will check that tomorrow.

I will merge this to save you dealing with the conflict which I caused


Disqus only shows if I click "view comments"

How do I make Disqus work normally?

Changes need to be made within the layouts/partials/disqus.html.
The disqus() function needs to fire on either page load or based on scroll events for it to work how, I believe, you're wanting it to.
I implemented disqus showing on page load within my forked repo on this commit.


improve bitget with bug fix and books1 support

fix: extract account info error and subscribe ORDER_UPDATE error in bitget_futures
dev: add books1 to MARKET_DEPTH for bitget

The bitget spot websocket api docs don't mention "books1", but it works when I tested it

We prefer to only support documented features. An exchange can remove any undocumented "features" without notification at any time. Relying on such features can be potentially dangerous in live trading.

Agreed. I have removed the books1 support. The current commit contains only bug fixes.


Use CHECKCOLDSTAKEVERIFY_LOF for coldstakingoutput

Issue being fixed: discord
Any clue why a cold staking node would get this? The input is unspent (and delegated to my Cold Staking node), it's attempted to stake many times and it always fails with this message.
2022-10-25T15:31:15Z ERROR: SignCoinStake : failed to sign coinstake
2022-10-25T15:31:15Z ERROR: Unable to sign coinstake with input <REDACTED>-1

analysis
vout[1] has OP_CHECKCOLDSTAKEVERIFY. OP_CHECKCOLDSTAKEVERIFY  will be the standard when V6 is enforced, for now OP_CHECKCOLDSTAKEVERIFY_LOF is. When OP_CHECKCOLDSTAKEVERIFY is used all outputs must have the same pubKeyScript. Pre V6 the masternode payment is in the last output, it doesn't have the same pubKeyScript so the check fails.
What was done?
The OP_CODE used for coldstakingoutput was changed from OP_CHECKCOLDSTAKEVERIFY to OP_CHECKCOLDSTAKEVERIFY_LOF
How Has This Been Tested?
At GitHub:PIVX-Project/PIVX:/src/script/interpreter.cpp#L1388 was checked if CheckColdStake failed.
It did for coldstakeoutputs with OP_CHECKCOLDSTAKEVERIFY, it didn't for coldstakeoutputs with OP_CHECKCOLDSTAKEVERIFY_LOF.
Breaking Changes
TODO: Change back to CHECKCOLDSTAKEVERIFY on Consensus::UPGRADE_V6_0
Checklist:

[x] I have performed a self-review of my own code
[x] I have performed a test of my own code
[x] I have commented my code, particularly in hard-to-understand areas

This is interesting! :eyes:
What confuses me is that MPW has been using this for a very long time (since we released Cold Staking), and the Labs address has been staking for many months using the previous CCSV opcode/script without issue, but only in the past 2-3 weeks, this staking suddenly caused errors, for both Labs and other users.
I will run some delegations with your PR however and see if this hits anything (should stake within 2-3 days maximum); I suggest we make some small modifications so that the switchover post-v6 is automatic rather than manual (MPW is aware of block heights).
So we pass the height and a chainparams UPGRADE_V6_0 to bitTrx.js, then the cold staking input function can choose the correct opcode.
Thanks for the time with investigating, a bounty of course shall be attached to this PR for your research/debugging efforts. :purple_heart:

I've been trying to test this for a solid week on my PIVX v5.5.0rc cold pool, and unfortunately no luck: which is incredibly weird, since staking the same amount with Allnodes resulted in stakes every 2-4-ish days very consistently for many months.
I've switched the Labz pool back to PIVX v5.4.0, and will continue testing. :pray:

The PIVX version isn't the issue. The issue is the OP_CODE used or rather the name and value of the OP_CODE
Let me elaborate on that a little bit more
In https://github.com/PIVX-Project/PIVX/pull/2275
PIVX changed the name from OP_CHECKCOLDSTAKEVERIFY to OP_CHECKCOLDSTAKEVERIFY_LOF
https://github.com/PIVX-Project/PIVX/pull/2275/commits/b194386d8bce3f65b142ccc7b8f5c651521149cd#diff-93c5ddf703879287802d651b68c9c6199644afe23db0dd3ff77e8d1ce3c20045R187
it's value remained 0xd1 (= 209)
And they introduced an OP_CODE with the name OP_CHECKCOLDSTAKEVERIFY and value 0xd2
https://github.com/PIVX-Project/PIVX/pull/2275/commits/df116317ecb5afe8b754207c269cf9f5c0005d80#diff-93c5ddf703879287802d651b68c9c6199644afe23db0dd3ff77e8d1ce3c20045R188
This pull request got merged on 2021-05-11 and was first released in v5.3.0
On 2021-09-19 in https://github.com/PIVX-Labs/MyPIVXWallet/commit/14701c8bf452521598a99c021f9785e4f3fb7f0f
The OP_CODE usage was refactored from value based to name based
https://github.com/PIVX-Labs/MyPIVXWallet/commit/14701c8bf452521598a99c021f9785e4f3fb7f0f#diff-c37ef34c80e966a932a437f8c65884db936a3f9b74bbf7ac60e034dda1ca3188R140-R142
const OP = {
⋮
// cold staking
  'CHECKCOLDSTAKEVERIFY_LOF': 0xd1, // last output free for masternode/budget payments
  'CHECKCOLDSTAKEVERIFY': 0xd2,
⋮

And the value for coldstaking outputs was changed from 209 (=0xd1)
https://github.com/PIVX-Labs/MyPIVXWallet/commit/14701c8bf452521598a99c021f9785e4f3fb7f0f#diff-8802cc49cf5a9eb9a9ec5ac1dad908afe4881078c7cc6c41e03a51978ba2fe02L128
buf.push(209);  // OP_CHECKCOLDSTAKEVERIFY

to the name OP['CHECKCOLDSTAKEVERIFY']
https://github.com/PIVX-Labs/MyPIVXWallet/commit/14701c8bf452521598a99c021f9785e4f3fb7f0f#diff-8802cc49cf5a9eb9a9ec5ac1dad908afe4881078c7cc6c41e03a51978ba2fe02R131
buf.push(OP['CHECKCOLDSTAKEVERIFY']);

As you can see, the coldstaking output now uses the value 0xd2 instead off 0xd1 as before
So when this commit got released on MyPIVXWallet, it started creating coldstaking outputs with an other OP_CODE value then intended

utACK

:coin: 405 PIV bounty fulfilled and sent


[ERROR] dotnet build exited with code 1

when I try to run the preview after clicking on the "build project" it doesn't work.
if I launch "dotnet build" from the terminal it works without problems

fixed in v0.0.25


Nothing prevents calling init() second time and setting state to {}

Rust SDK handles it with #[init].
Related issue: https://github.com/near/near-sdk-js/issues/153

Fixed in #200


last.fm app displays time in UTC, not in local timezone

Hi folks!
The last.fm app in the repository, when it has its clock function toggled on, seems to be displaying UTC time rather than local time - but the documentation in the app settings for that toggle says it should display local time. For instance, it's just gone 8pm here in the UK right now (British Summer Time, UTC+1), but it displays just past 7pm.
I'm not clear on whether the Tidbyt API actually offers a way to retrieve the time in the current timezone? Other similar clock apps in the repo seem to have either timezone or location settings separately. Does one need to be added, or is there a simpler fix?

@my-ugly-code - hi! I think you're the original author of the last.fm Tidbyt app. I note from the contributing guidance that changes are subject to approval from the original app author - would you be happy with a timezone setting being added? :)

If other clock apps display correctly for you, yes, just implement what they're doing...seems to be .in_location(). I'm ok with whatever addition is needed to support TZs.
I'm guessing the function handles seasonal adjustments like Summer Time (DST in US). I'm in Eastern US and it's always 'just worked' for me,.

Yes, to get the timezone for the device's location configured in the mobile app you just do config.get("$tz").
It's always a good idea to have defaults if things change in the future, so something like config.get("$tz", "America/New_York") would work.

Yep I've done something similar. Is there a guide that mentions $tz? Are there other similar special variables that would be good to know about?

Sadly it's not mentioned in the documention.
There's even a PR https://github.com/tidbyt/tidbyt.dev/pull/620 open since june to add it there. 😢

Thanks, I've added a note there about testing it as well.


fix: download ram differently

Dashes shouldn't be necessary, but you never know.
If https://github.com/freeCodeCamp/freeCodeCamp/actions/runs/3054476975/jobs/4926493493 fails, we can try this.  If not, this can be closed.

fwiw all the stack overflow posts I saw said - and _ were both valid lol

fwiw all the stack overflow posts I saw said - and _ were both valid lol

Yeah, seems so. Oh well!


Create magic8.py

Take name and question from user

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

magic8


Unsupported operation: InternetAddress.lookup

Hi,
Just want to report that there is an issue with your widget on a web build of a flutter application. I can't seem to throw the error on an Android emulator so I am unsure if the issue is also happening on there.
When I open the console in Chrome its throwing the following chrome.log
I am working on application an application for mobile and web and id love to include your widget.

Hi, thanks for reporting, currently there is no web support on this plugin, but I will implement it in this month


ImGui

why if I use beginchild in the menu , I have the menu crash?

i know who will probably know what's wrong, his name's debugger.
ps. imgui ALWAYS uses assertions, so if something is wrong, then you can go to place where the exception is thrown, just use call stack
ps2. its almost 2 months old lol


chore: Introduce Make target operator-seed-dev

How to categorize this PR?
/area documentation
/kind enhancement
What this PR does / why we need it:
This PR introduces a new Make target: make operator-seed-dev
Today, the getting-started documentation for local development/deployment that uses the gardener-operator focuses on commands that setup/teardown the environment. While it's possible to launch the dev-loop for the gardener-operator using make operator-dev this does not exist yet for other Gardener components such as the gardenlet.
The new Make target make operator-seed-dev is based on make operator-seed-up with the difference that:

It uses skaffold dev instead of skaffold run
The Skaffold tag policy for the gardenlet has been changed to use a timestamp instead of the abbreviated Git commit hash.

Which issue(s) this PR fixes:
n.a.
Special notes for your reviewer:
Thanks to @LucaBernstein for the Makefile and Skaffold support 🧙♂
Release note:
Add Make target `make operator-seed-dev` for local development of the `gardenlet` in the operator setup.

/cc @rfranzke
/cc @oliver-goetz
/cc @LucaBernstein

/retest

/lgtm

/approve


registry resource is updated when using dword<PHONE_NUMBER> (ffffffff)

Description
At each start of chef-client on windows, the registry key resource, when a dword max size<PHONE_NUMBER>) value is set, is always updating the resource despite that the value is correctly set in the windows registry.
Chef Version
chef-client x64 for windows v12.12.15 (tested with 12.11.18 too)
Platform Version
Windows 2012 R2 x64 En-US (on vmware)
Replication Case
registry_key "HKLM\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL\Ciphers\AES 256/256" do
values  [{:name => 'Enabled', :type => :dword, :data => '4294967295'}]
action  :create
recursive  true
end
Run first chef-client : the registry value is successfuly updated.
Run second chef-client command: the regitry value is updated again
The value "Enabled" is applied at each chef-client run.
Client Output
Starting Chef Client, version 12.12.15
[2016-07-12T11:54:55+02:00] INFO: *** Chef 12.12.15 ***
[2016-07-12T11:54:55+02:00] INFO: Platform: x64-mingw32
[...]

Chef Client finished, 1/1 resources updated in 12 seconds

Client full trace
trace.txt

i feel like i've read a similar bug recently, might be a dup?

Hello,
I don't understand why this issue is low priority. Have you an idea of the chef-client release which fix this bug?
Actually, our reporting tools is still contaminated by all changes applied at each chef-client run on all Windows servers.
If the problem is not fixed, we should probably set up a guard to make the change be skipped. But it is not the way we like to use chef ...
Regards,

Hi @lbn-aaio-team ,
After doing some analysis, found that chef has Recipe DSL methods like registry_key_exists?,registry_data_exists?
Use registry_data_exists? method  in not_if block of the registry_key resource, so if the data is already set correctly, it won't update it.
More details on the usage of the DSL methods can be found here
Let me know if you face any issues.

Hi @lbn-aaio-team,
My further analysis is as follows:-
In the chef code mentioned here, it checks if the value which needs to be set is same as that which is currently set.
current_value = {:name => 'Enabled', :type => :dword, :data =><PHONE_NUMBER>}   #current value set in registry key
value = {:name => 'Enabled', :type => :dword, :data => "4294967295"}         #value passed by user which needs to be set

The issue occurs for type dword, as when the data value passed as string in registry_key resource,   however while actually setting the data value in registry, it is set as Fixnum datatype(Integer).
During second chef client run, after verifying that registry key exist, during comparison of the set data and the new data value to be set, the values differ as the comparison happens for integer(current_value[:data]) and string(value[:data])
The workaround which works is in the data value of the registry_key resource, instead of assigning string value to data, assign it as integer value as follows.
registry_key "HKLM\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL\Ciphers\AES 256/256" do
values [{:name => 'Enabled', :type => :dword, :data =><PHONE_NUMBER>}]
action :create
recursive true
end

Hi @dheerajd-msys,
Thank you very much for your help.
I deploy my cookbook with your method and all is working fine now.
This is more perform than a powershell guard :)

@dheerajd-msys when type is dword, then data should always be a 32-bit number, yes? In that case we should patch chef to coerce the data to an integer so users don't need to learn about this caveat.

This is automatically fixed now by #5268, which will be in an upcoming release (probably october).


Multilingual?

How do i do multilingual in Jasper? Based on the STT module? Google module would work? Need help on this

@joevo2  Of course Multilingual should work but you have to define words for cross language integration.
http://jasperproject.github.io/documentation/api/standard/


Github username bibekpanda55

Added a math riddle with title magic number and completed its requisites.

Hey @bibekpanda55 after you, there were 2-3 PR has been merged, so can you pull all these changes and send us PR once again!!
Other than that, all are good🙌
And also go through the CONTRIBUTING.md and make some changes accordingly.

Hey @bibekpanda55 after you, there were 2-3 PR has been merged, so can you pull all these changes and send us PR once again!!
Other than that, all are good🙌
And also go through the CONTRIBUTING.md and make some changes accordingly.

Ok will do that in a minute

Hey @bibekpanda55, @razorcalhn is also chaning this issue, so wait some time and  let him give the PR and after him make changes into that.
Sorry for inconvenience😶

Hello, I've pulled all the changes into my forked repo and changed my files
accordingly.
Sent another PR, lemme know if there's an issue.
:)
On Wed 7 Oct, 2020, 4:12 PM Harsh Patel<EMAIL_ADDRESS>wrote:

Hey @bibekpanda55 https://github.com/bibekpanda55, @razorcalhn
https://github.com/razorcalhn is also chaning this issue
https://github.com/clubgamma/RiddlesWorld/pull/29, so wait some time
and let him give the PR and after him make changes into that.
Sorry for inconvenience😶
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/clubgamma/RiddlesWorld/pull/30#issuecomment-704851754,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALNLAHKDMCSGO4M7WT2LZE3SJRA2RANCNFSM4SGCZP6Q
.


adjust space between charts.

Screenshot

[drag & drop image(s) here!]
Description
[describe the issue here!]:
I need to reduce space between charts and with in chart border space is high. can we reduce this?
Design input
[describe any input/collaboration you'd like from designers, and
tag accordingly. For design review, add the
label design:review. If this includes a design proposal,
include the label design:suggest]

Please provide you rational along with a high res mockup for any UI change proposal, using one of the issue templates. Closing the issue for now.


podadrem: Issue newline before GB commands

reference: https://github.com/espruino/BangleApps/commit/ba7a2f79968ed26d3caa8ac2821e07856369e60e

Thanks!


[#6504] Remove unnecessary logs from netty-http2

Codecov Report

Merging #6505 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #6505      +/-   ##
=========================================
- Coverage    39.5%   39.5%   -0.01%
=========================================
  Files        3085    3085
  Lines       92063   92063
  Branches    11910   11910
=========================================
- Hits        36369   36368       -1
  Misses      52682   52682
- Partials     3012    3013       +1

Impacted Files
Coverage Δ

...pc/server/LoggingServerMessageListenerFactory.java
90% <0%> (-10%)
:arrow_down:

...rc/main/java/com/navercorp/pinpoint/test/Item.java
70% <0%> (-3.34%)
:arrow_down:

...om/navercorp/pinpoint/rpc/codec/PacketDecoder.java
57.44% <0%> (-2.13%)
:arrow_down:

...orp/pinpoint/rpc/server/DefaultPinpointServer.java
79.22% <0%> (-1.06%)
:arrow_down:

...point/rpc/client/DefaultPinpointClientHandler.java
72.07% <0%> (-0.33%)
:arrow_down:

...java/com/navercorp/pinpoint/rpc/DefaultFuture.java
74.16% <0%> (+1.66%)
:arrow_up:

...cluster/zookeeper/ZookeeperClusterDataManager.java
54.83% <0%> (+1.93%)
:arrow_up:

...navercorp/pinpoint/rpc/common/SocketStateCode.java
85.36% <0%> (+2.43%)
:arrow_up:

...p/pinpoint/rpc/stream/StreamChannelRepository.java
85% <0%> (+10%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35dfc72...36f8180. Read the comment docs.


Submit to homebrew/core

um is popular enough for a core formula, so why not submit it to core and make it easier for everyone? I can handle the grunt work of fixing it up to pass audits, having it submitted and seeing it through if you don't want to do that yourself.

 This hadn't even occurred to me. I'll take a look at what this would involve. Thanks for suggesting it.

@zmwangx Hoping to replace pandoc with a gem before this happens, but this is still on my radar.

No problem! Thanks for the update, and please take your time.

If anyone here is keen to see this happen, maybe let the Homebrew maintainers known in https://github.com/Homebrew/homebrew-core/pull/32670? Not sure how they decide which PRs get merged and which languish

Hmm, back when I was on the maintainer team (a long time ago), green new formula PRs with no additional complaints were either rejected fairly quickly or merged within maybe three days... Maybe just need a ping...

Woo hoo! Thanks for the ping.
https://github.com/Homebrew/homebrew-core/commit/4e0ce9a807800777f4d17a21578c016ca706a09b


pelletier/go-toml v1.9.0 released

Misc bug fixes and improvements.
refs https://github.com/pelletier/go-toml/releases/tag/v1.9.0

Next: Update version referenced in Docker files in order to pull in the newer version of the CLI tools.


Create a reference XML article(s) that contains all the potential tags/attributes that are required in the 'back' section to support an Insight Article

Description
As a Developer, I need a reference insights article so that I can use it for testing whilst developing.
DoD

[ ] A DAR archive, that contains a reference XML article with all the potential tags/attributes that might be found in the 'back' section of an insights article, committed into a repository in Github.

@joelsummerfield, which GitHub repo should this be deposited to? Or should I create one?

@FAtherden-eLife Good Question, I think for now that it might be an idea to create one, maybe something like 'reference-manuscripts' or similar, and just commit it there. Justification being that I can imagine that there will be more than one package that will want to make use of it.

Thanks Joel, done. Committed an Insight kitchen sink here https://github.com/libero/reference-manuscripts/blob/master/insight-kitchen-sink/elife-00001.xml
@JGilbert-eLife, @Melissa37 - please can you take a look and let me know if there's anything I've missed? (bear in mind that I'm just doing back stuff atm and will add more at a later point)

Hi @FAtherden-eLife
I know this is a comment not on the back, but think it should be changed now :-)
The id and rid should be to "con" not "conf" cor conflict.
This matches with the JATS4R recommendation.
I think it might still be there in your tagging because we had to use conf because con was used for contributions....but contributions will follow the other JATS4R recommendation for credit taxonomy so we're OK using con now.
Thanks!

Sure, done.

I don't think we normally list eLocation IDs for bioRxiv references, since they have DOIs. We do list them on arXiv references though . . .
This covers most variations on journal references but I think we should include ones that don't have volume or page range as well. Plus web references without a parent site e.g
    <ref id="bib50">
        <element-citation publication-type="web">
            <person-group person-group-type="author">
                <name>
                    <surname>Walker</surname>
                    <given-names>J</given-names>
                </name>
            </person-group>
            <year iso-8601-date="1994">1994</year>
            <article-title>Solar System Live</article-title>
            <ext-link ext-link-type="uri" xlink:href='https://www.fourmilab.ch/solar/'>https://www.fourmilab.ch/solar/</ext-link>
            <date-in-citation iso-8601-date="1995-09-10">September 10, 1995</date-in-citation>
        </element-citation>
    </ref>

@JGilbert-eLife, can't see a single instance of an aRxiv elocation-id in the archive (or bioRxiv, as you say). Is it a case of house style that we don't include elocaiton-ids for bioRxiv refs? It seems elocaiton-id is not allowed for preprint refs in the reference schematron (why is that?), but I don't see why we shouldn't do so if there's one present...
I'll commit an edited file with that journal/web addition after we clarify the above.


Adding tests of adding new answer with pytest

adding test for creating new user, profile and answer to the DB.
create PyTest YML file to run  the application's tests with PyTest on PR. (like what we are familiar with flake8)
Pipfile, Pipfile.lock modified by Django while installing PyTest .
made this PR due to Edward's request on Slack.
fix #73

I think you should set Edward as a reviewer because of what he wrote in Slack

@ifireball I fixed what you recommended

@ifireball can you review these tests,
I will make another PR with tests on view when I will make the add answer feature.

I'm looking at the PR description and I'm not understanding the point of the Pr or what it is supposed to contain any more. Its it just fr adding tests?

I'm looking at the PR description and I'm not understanding the point of the Pr or what it is supposed to contain any more. Its it just fr adding tests?

this PR includes DB tests on adding new answer and adding create new profile.
PR #87 includes the add answer feature with the editor and view and tests for that (test the post method).
I made this PR before Edward's lecture, so the feature wasn't ready then.

I'm still not understanding. Is this PR adding tests for code you already merged of for code that you have in another PR?
Is there PR no non-test code in this PR at all?

I'm still not understanding. Is this PR adding tests for code you already merged of for code that you have in another PR?
Is there PR no non-test code in this PR at all?

this PR is tests:

Add profile (not related to any other PR)
DB tests to adding answer - related to #87  PR.

in #87 PR there are tests for the view and the post method for adding answer.

It does not make sense to have a PR just for tests (Except to the case where you are closing a technical debt of adding tests to code that you merged in the past without tests).
If this PR is adding tests for functionality added in another PR - put the tests in that other PR.
If this PR is also introducing functionality elements, please clearly state those elements in the PR description and make sure to onlu include tests for those elements.

It does not make sense to have a PR just for tests (Except to the case where you are closing a technical debt of adding tests to code that you merged in the past without tests).
If this PR is adding tests for functionality added in another PR - put the tests in that other PR.
If this PR is also introducing functionality elements, please clearly state those elements in the PR description and make sure to onlu include tests for those elements.

OK, so I transferred all the tests to #87 PR , and I will close this PR.


Simplified ESM build

Issue: https://github.com/PrismJS/prism/issues/3702
Continues from PR https://github.com/PrismJS/prism/pull/3699
To test this in an existing app, install Prism v2 like so:
npm install prismjs@github:trusktr/prism#simple-esm

To try an existing Prism v2 example along with a Node ESM test try this repo:
https://github.com/trusktr/prism-v2-test
npm install # this installs Prism from git, from this branch
npm test # this verifies that importing Prism in Node ESM works

The gold standard today is that if it is importable in Node ESM, it is likely to work with todays build tools that all supports Node ESM format.
In particular though, this change tries to stay as close to vanilla ESM as possible, by avoiding the use of package.json exports field (browsers do not read package.json, let along an exports field).
The example app above shows importing Prism without any configuration or build. In the worst case, if they wish to avoid putting ./node_modules directly in their import statement, they can create a <script type=importmap> element to map prismjs to the node_modules location.
All Mocha unit tests pass except two of them. I also removed the components.json build, which I think needs to be restored for when new languages are added (? I'm not sure yet), but now we'll ensure that we restore what is needed on this simplified foundation.

The mantras here are:

simple ES Module output that requires the least amount of tooling or configuration to import in vanilla ES Modules (namely, in a browser where this is most likely to be imported, where browser ESM is a subset of Node ESM).
we start with most vanilla ESM setup before starting to add any build steps, so that we're staying on the most compatible ESM path.

This is as simple as it can possibly get for browser ES Modules (apart from us also including a sample importmap that they can paste into their HTML, which we can do.
This is still WIP, we need to look at the components.json build requirement.

[ ] ensure the components.json build is handled if needed
[ ] fix last type definition issues (described in the issue thread)

Comments in the diff have some more details.

Alrighty, I commented in all the relevant files to explain the changes. The rest of the vast majority of uncommented files are all just format updates (adding .js extensions, tweaking one or two imports for Node ESM compat, fixing __dirname).