Revert "Flysystem Persister"

We agreed (although hesitant) to wait until the next release (hopefully no more) to introduce Flysystem as A. We like the idea of using Flysystem 2.0 but B. They are still in beta currently. We hope that by waiting we can mitigate having to make breaking changes to the Flysystem persister if Flysystem decides to change their API between now and their first stable 2.0 release.
CC: @simplechris

Yeah, although I'm keen to see this enhancement get into master, delaying this to the 0.3.0 release this is the right call, imo.

Flysystem 2.x will have a far longer lifespan, and the design is objectively better/cleaner.
Considering a 2.0-beta3 release already out, it's just a matter of time before they optionally move to RC phase or directly to a stable release 🤞.
Although it's unlikely that the core interfaces will change in Flysystem 2.x (at this stage) crazier things have happened in software development. A little patience now could pay dividends in the future for us and avoid introducing any breaking API changes.
In the meantime I can open something against the upcoming 0.3.0 branch, that also includes the enhancements spotted in #109.
Also related: I'm making decent progress on #108 and hope to have a design proposal soon. We can use as starting point for designing a more fully-featured persistence subsystem. In turn, the existing interfaces can take advantage of this internally as we progress (in time) to the 1.0 release.


Incorrect recursive output for scala.xml.ProcInstr

Welcome to the Ammonite Repl 1.6.9
(Scala 2.12.8 Java 1.8.0_202-ea)
If you like Ammonite, please support our development at www.patreon.com/lihaoyi
@ val x = <?xml-stylesheet href="style.xsl"?>
x: xml.ProcInstr = ProcInstr(
  ProcInstr(
    ProcInstr(
      ProcInstr(
        ProcInstr(
          ProcInstr(
            ProcInstr(
              ProcInstr(
                ProcInstr(
                  ProcInstr(
                    ProcInstr(
                      ProcInstr(
                        ProcInstr(
                          ProcInstr(
                            ProcInstr(
                              ProcInstr(
                                ProcInstr(
                                  ProcInstr(
                                    ProcInstr(
                                      ProcInstr(
                                        ProcInstr(
...

There is a similar issue with the snippet:
object MainTest extends App{
  val test = <rss></rss>
  pprint.log(test)
}

Not sure if the same issue though, since it doesn't seem to happen in ammonite for people.


qutebrowser-qt6: :help doesn't load

Describe the bug
This error occurs when trying to open the help page.
23:13:04 ERROR: SchemeOSError while handling qute://* URL: [Errno 2] No such file or directory: '/nix/store/l8n17zmc8nxbxkgnhvdgk2qjm9vf6zx2-qutebrowser-unstable-2022-09-16/lib/python3.10/site-packages/qutebrowser/html/doc/index.html'

Steps To Reproduce
Steps to reproduce the behavior:
Launch qutebrowser-qt6
Run :help
Expected behavior
Loads help page
Notify maintainers
@nrdxp (since added qt6 build, although not a maintainer)
@jagajaga @rnhmjoj @ebzzry @dotlambda
Note this doesn't happen for the qt5 build.

I probably should have added myself as a maintainer. Right now I am still using the one in my flake, i.e. github:nrdxp/nrdos/locked#qutebrowser since it hasn't made it to nixos unstable yet.
I'll build the one in master and see if I can reproduce, but in this build it works fine which comes directly from my PR branch: #194833


Allow using attributes

Rebased version of #19.

Hi,
I'm sending a few improvements, including implementation of @lcobucci's failing test case concerning prophets in class property. It now depends on dev version of PHPStan but after you test it and tell me it's okay, I can release the change.

Any progress on merging this?

Yes, but i guess now we need another rebase

@Jan0707 once you merge #37 i'll rebase this, but please let's not let it stale once more.

@rdohms merged #37 :)

@Jan0707 there you go.


[Manual] - Counter for comments does not changing in offline mode

Commit number: bc9d25e
Preconditions:

Test user is signed in;

Steps to reproduce:

Set the application to offline mode
Open "Popular" feed
Add a comment to a post
Check "Comments" counter for the post

Actual Result: Counters for comments does not changing in offline mode
Expected Result: Counters for comments should changing in offline mode the same as in on-line mode

Jaroslaw, could you please try to reproduce that issue on develop branch after 43b638f6ec60521241368aae92736d21f5a67da4 commit

The problem is still active in build from commit number 949aa72

The problem is still active on "Post" screen on build from commit number 73646af7c86417b3aacb7aadf4c5b0b196e4e00a

Verified for feed on build fro commit number 73646af


 html tag does not display properly

Not sure if issue here or elsewhere, but the <kbd> ... </kbd> html tag does not display as button but rather monospace or similar in Safari and Firefox.

Can you add a screenshot?

On macOS it's the same in Safari, Firefox, Chrome

This seems to be a macOS styling decision then.
Not sure if this must be changed then?

Well, it's honestly still annoying.
I've tested html+css outside the knowledge base and was able to display a key properly with
kbd {
  padding:0.1em 0.6em;
  border:1px solid #ccc;
  font-size:11px;
  font-family:Arial,Helvetica,sans-serif;
  background-color:#f7f7f7;
  color:#333;
  -moz-box-shadow:0 1px 0px rgba(0, 0, 0, 0.2),0 0 0 2px #ffffff inset;
  -webkit-box-shadow:0 1px 0px rgba(0, 0, 0, 0.2),0 0 0 2px #ffffff inset;
  box-shadow:0 1px 0px rgba(0, 0, 0, 0.2),0 0 0 2px #ffffff inset;
  -moz-border-radius:3px;
  -webkit-border-radius:3px;
  border-radius:3px;
  display:inline-block;
  margin:0 0.1em;
  text-shadow:0 1px 0 #fff;
  line-height:1.4;
  white-space:nowrap;
}

(stack overflow styling, source: https://stackoverflow.com/questions/51641086/how-to-insert-the-so-like-kbd-effect-into-my-html-based-presentation)
However adding this to src/style/style.css didn't affect how it's displayed. Does fornax automatically overwrite the style sheet or pull from somewhere else?

Adding the style snipped from above to style.css works without issue for me,
I would recommend changing padding to padding: 0.1em 0.6em 0.1em 0.4em;, looks a bit better on windows at least, not sure about others


The crypto_script for orderer organization is enrolling the same admin user multiple times in Fabric.

Describe the bug
The Admin user for orderer organization is enrolled multiple times. The Admin user is organization specific and enrolled only once per Admin user.
To Reproduce
Steps to reproduce the behavior:

Edit fabric network.yaml with multiple orderers.
Deploy the fabric network.
Check the Admin user certificates at build/crypto-config/ordererOrganizations/sl-net/users/Admin@sl-net/msp/keystore
See error

Expected behavior
The fabric Admin user should be enrolled once per organization.
Screenshots

Environment (please complete the following information):

Version Fabric 1.4 and 2.2

Additional context
For reference, the Fabric documention for enrolling the admin is here .

RCA:
The organization level enrollment were done in the orderer level script. The sollution was to segregate those organization level and orderer level based commands to form differernt scripts for each level.


Eigenvalue and eigenvector deviation with GPU hardware

I have observed that the eigenvalues and eigenvectors change marginally if the underlying GPU or memory configurations are different. How to fix this issue? I am using random seed value to reproduce the results, but the hardware configuration change does not guarantee the exact eigenvalues and eigenvectors. It is affecting the accuracy of the algorithm. Can someone please help? Thank you.

Only setting seed does not guarantee deterministic behaviour on GPU. Have you tried using torch.use_deterministic_algorithms or torch.backends.cudnn.deterministic. Here is an article about it just in case you haven't seen it https://pytorch.org/docs/stable/notes/randomness.html


WIP: [zh] sync pod-scheduling-readiness.md

Sync with en https://github.com/kubernetes/website/pull/37675
I will proofread again after the original PR is merged.

Just a quick question, @iyear, I understand that this is the translation for a doc on the 1.26 release. However, is there a requirement/has there been an agreement for this to land in the dev-1.26 branch along with all other English docs? The reason is we typically have the localization teams work on the different docs AFTER the docs for that release are published since updating an isolated doc might result in inconsistencies.
cc : @reylejano @natalisucks @sftim @a-mccarthy

@divya-mohan0209
I'm very sorry for interfering with your work. I just skimmed through the history of zh PRs and contribution docs...
Reasons why I committed to the dev-1.26 branch: #37981, so I directly submit a new PR...
So I should wait until the new docs are released and I commit the translation to the dev-1.26-zh.x branch...?

@iyear The concern from the reviewers is valid. We don't have a lot of localization PRs going into the dev-1.xy branch because most localization teams are busy translating current/previous (sub-)versions. The Chinese (zh-cn) localization team, thanks to the passions from all contributors, has been following and closely tracking the main branch for some time. We are kind of pushing the limit, contributing to dev-1.xy branch directly. This is good.
However, there are some risks on doing this. Given an existing page en/foo/page.md, we have a zh-cn/foo/page.md. There could be changes to the English version for current release (say '1.25', aka, 'main' branch). These changes can be tracked using the scripts/lsync.sh script. There could be NEW changes to the same page in the dev-1.26 branch. We may want to update the Chinese version in the dev-1.26 branch as well, but the story is getting complicated. The en/foo/page.md now has two versions (one in main, one in dev-1.26). The release team needs to make sure there are no conflicts between them. This team CANNOT do the same for Chinese localizations. When conflicts do arise, they break the build, or even delay the site release.
So, I'd suggest we DO NOT commit localization PRs to the dev-1.26 branch.
/hold

Here's my concern: the release docs team have to merge in changes and resolve conflicts. We don't expect those teams to include representatives from every launched localization. It's much easier to have that team specialize in the upstream (English) localization.
If any localization team wants to make a head start on changes, those are OK to work on, but PRs will need to rebase after the v1.26 release and should be draft before then.

@divya-mohan0209 @tengqm @sftim Thank you very much for your reviews and replies, I didn't read the contribution files carefully enough to cause the conflict. It's true that I shouldn't commit to dev-1.26 and cause trouble for the team.
And what should I do next? It looks like merging this PR cause more trouble.


Configuration issue

microrl.c 361 seems should be moved to microrl.c 371
And whole hist_search() part should be covered with additional
#ifdef _USE_HISTORY
Suggestion:
...
#ifdef _USE_HISTORY
static void hist_search (microrl_t * pThis, int dir)
{
int len = hist_restore_line (&pThis->ring_hist, pThis->cmdline, dir);
if (len >= 0) {
pThis->cursor = pThis->cmdlen = len;
terminal_reset_cursor (pThis);
terminal_print_line (pThis, 0, pThis->cursor);
}
}
#endif
#ifdef _USE_ESC_SEQ
...

Fixed in #21 -- someone should close out this issue.


error: 'ACPI_STATUS' does not name a type; did you mean 'ACPI_STATE_S0'?

This issue arose using the latest gcc toolchain and latest sysroot when running make iso

Hi!
What kernel config are you using?
git grep ACPI_STATUS shows me 2 buggy references to this old type, but both are conditional on CONFIG_ACPI not being defined. Which in all honesty, you probably want defined.

kernel.config.minimal

Ah yes, to be fair, kernel.config.minimal is not very useful as an operating system (and I don't test with it). Please use one of the configs under kernel/configs, or specify CONFIG_ACPI=y.
I'll keep this open to track the build issue with CONFIG_ACPI=n.


problem occurs when running the DeepMimic.py

Hi,
"
*** Process received signal ***
Signal: Segmentation fault (11)
Signal code: Address not mapped (1)
Failing at address: (nil)
[ 0] /lib/x86_64-linux-gnu/libpthread.so.0(+0x11390)[0x7f67aba3d390]
"
On the other hand, I run the command "python3 mpi_run.py --arg_file args/train_humanoid3d_spinkick_args.txt --num_workers 4" and it worked well and began the training process.
The same bug occurs as in issue#10, and I commented the " glutInitContextVersion(3, 2)" in DeepMimic.py. But the bug still exists, Do I need some extra modifications?

It has been solved. Pay attention to your nvidia driver.

check DeepmimicCore/Main.cpp:InitDraw()

I have a same problem. Could you please tell me how to solve the problem?
When an error happened, which nvidia driver did you use? In addition, which nvidia driver did you change it into to solve an error?
thank you so much.

How can I check for the driver needed? Do u need Nvidea even to run python DeepMimic.py --arg_file args/run_humanoid3d_spinkick_args.txt? I need to run the pre-trained model on Intel® UHD Graphics 620 (Kabylake GT2). Can I do that? Is there any way I can modify the code to do that?

It has been solved. Pay attention to your nvidia driver.

It happen to my computer too but from issue#10 I have forward to file DeepMimic.py and it doesn't contain 'glutInitContextVersion(3, 2)'.
Please help about the nvidia driver what would have caused the problem. I am using OpenGL version string: 4.6.0 NVIDIA 555.42.06 [NVIDIA GeForce RTX 4070 Ti SUPER]


Compilation Issue

ERROR in<EMAIL_ADDRESS>46:0-104
App is not getting compiled and using the old libraries of aws-amplify. Could we get this updated ?

Hello, I am no longer working at aws and therefore have no ability to make changes. Please fork and correct the issues


Add crossplane dependencies to local testing

Summary

Adds Crossplane dependencies for testing locally in kind (Preparation for #17 )
Adds integration test boilerplate (Preparation for #17 )

Checklist

[x] Categorize the PR by setting a good title and adding one of the labels:
bug, enhancement, documentation, change, breaking, dependency
as they show up in the changelog
[x] Update tests.
[x] Link this PR to related issues.

Only tested the make targets so far and no code. Here are my findings so far:
make build creates a borked image, if run with macos. Didn't we fix that already somewhere? The image with make local-install seems fine though. So probably not that much of a deal.
The chart seems to have a problem when running make local-install:
helm upgrade --install provider-postgresql chart \
        --create-namespace --namespace postgresql-system \
        --set "operator.args[0]=--log-level=2" \
        --set "operator.args[1]=operator" \
        --set podAnnotations.date="Mon  9 May 2022 13:07:04 CEST" \
        --values /Users/simonbeck/repos/appcat/appcat-service-postgresql/.kind/webhook-values.yaml \
        --wait
Release "provider-postgresql" does not exist. Installing it now.
Error: clusterroles.rbac.authorization.k8s.io "provider-postgresql" already exists
gmake: *** [test/local.mk:27: local-install] Error 1

A subsequent make local-install fixes the problem though.

If you make cleaned the repo, then the binary built should be for macos (since it takes over GOOS and GOARCH). The base image (alpine:1.15) should be as well for darwin when you pull.

Yeah that's the problem. Docker on MacOs is always in a linux VM, so the locally built bin won't work. local-install seems to override things to linux and amd64 so then it works.

Did you delete the kind cluster before as well to have a clear plate? I changed the way how clusterrole(binding) is applied.

Yes my start was a clean cluster, basically make clean && make local-install.

Are you sure that's not a sentinel file skipping the targets?

First run:
helm upgrade --install provider-postgresql chart \
        --create-namespace --namespace postgresql-system \
        --set "operator.args[0]=--log-level=2" \
        --set "operator.args[1]=operator" \
        --set podAnnotations.date="Mon  9 May 2022 15:30:51 CEST" \
        --values /Users/simonbeck/repos/appcat/appcat-service-postgresql/.kind/webhook-values.yaml \
        --wait
Release "provider-postgresql" does not exist. Installing it now.
Error: clusterroles.rbac.authorization.k8s.io "provider-postgresql" already exists
gmake: *** [test/local.mk:27: local-install] Error 1

Second run:
helm upgrade --install provider-postgresql chart \
        --create-namespace --namespace postgresql-system \
        --set "operator.args[0]=--log-level=2" \
        --set "operator.args[1]=operator" \
        --set podAnnotations.date="Mon  9 May 2022 15:31:37 CEST" \
        --values /Users/simonbeck/repos/appcat/appcat-service-postgresql/.kind/webhook-values.yaml \
        --wait
Release "provider-postgresql" has been upgraded. Happy Helming!

The helm install seems to be running on every make local-install.

@Kidswiss I've fixed the sed command as we've figured out in the call. Please try again.

@ccremer seems to be working now.

Would it make sense to integrate https://github.com/vshn/kindev here?

Would it make sense to integrate https://github.com/vshn/kindev here?

Not now. PR #27 depends on this and I don't want to rebase 20+ commits based on a completely new structure. Maybe after that.

Not now. PR https://github.com/vshn/appcat-service-postgresql/pull/27 depends on this and I don't want to rebase 20+ commits based on a completely new structure. Maybe after that.

Fine by me, we can do it later.


Labelling specific commits

asv looks great, and we're currently considering using it for performance monitoring for our simulator instead of our own handcrafted and long-broken scripts.  From what I can see, the only feature our scripts had that I don't see in asv is the ability to label specific commits with an explanation of what happened with them.  We found that when we investigated the commit history, there were a few commits that caused major changes in performance (whether for good or for bad), and once we had completed our investigation we labelled those points on the performance charts, with a key that explains what happened.  (E.g. "Added new optimized component XX", "Switched to slower but more general component XX", "Removed potentially unsafe optimization in XX.x", "Rewrote C component in Python using numpy").  Adding these explanations made it clear that we had understood what happened on those specific commits, so that when we came back to look later we didn't start all over again wondering what the big performance drop (or jump) was from.  Does such a facility exist in asv?  If not, would it be difficult to add?  We certainly found it very useful, and appear to have a similar use case to yours...

Such a feature doesn't currently exist, but it seems like it would be very useful.  It does support showing any git tags in the graph -- but I understand that's not exactly what you want, but that feature could be extended to support what you want fairly easily, I would think.
You could probably experiment with it from outside in fact.  When you do an asv publish to generate the html/json, in html/index.json there should be a tags entry, like:
"tags": {
        "v0.1":<PHONE_NUMBER>000,
        "v0.2":<PHONE_NUMBER>000,
        "v0.2.1":<PHONE_NUMBER>000,
        "v0.2.2":<PHONE_NUMBER>000,
        "v0.2.3":<PHONE_NUMBER>000,
        "v0.2.4":<PHONE_NUMBER>000,
        "v0.2.5":<PHONE_NUMBER>000,
        "v0.2b1":<PHONE_NUMBER>000,
        "v0.2b2":<PHONE_NUMBER>000,
        "v0.2rc1":<PHONE_NUMBER>000,
        "v0.3":<PHONE_NUMBER>000,
        "v0.3.1":<PHONE_NUMBER>000,
        "v0.3.2":<PHONE_NUMBER>000,
        "v0.3b1":<PHONE_NUMBER>000,
        "v0.3rc1":<PHONE_NUMBER>000,
        "v0.4":<PHONE_NUMBER>000,
        "v0.4.1":<PHONE_NUMBER>000,
        "v0.4.2":<PHONE_NUMBER>000,
        "v0.4rc1":<PHONE_NUMBER>000,
        "v0.4rc2":<PHONE_NUMBER>000
    }

The first is a string, the second is a javascript time stamp of an associated commit.  You could add comments in the string part as long as you know the date time stamp, and they should appear in the graph.
Of course, all that would need to be wrapped up in something more convenient that took pairs on commits and comments from the asv.conf.json file, and passed them along and merged them into this tag list by asv publish.
One wrinkle is that you may not want these comments to appear for all benchmarks.  Certain refactoring changes may only impact certain parts of your library/application.  That would require a mapping from benchmark names to these annotations as well, and then some more smarts on the javascript side about when to show certain annotations.  That's a lot more work than the approach I describe above, but not impossible by any means.

Ok, thanks.  That sounds promising.  Yes, the git tag or even the git commit message shows some information, but not necessarily what will help us understand performance changes retroactively, and so your proposal of generating such a mapping specifically for annotations seems appropriate.  I too thought of the issue of multiple benchmarks for changes that affect only one of them, but that level of specificity seems like a feature that could be left safely far in the future.  The worst that would happen with a simple benchmark-global annotation is that we'd get an irrelevant annotation on some point of the graph where the performance didn't actually change for that particular benchmark.  I think it would be easy enough to ignore such annotations (since no one will be closely investigating parts of a benchmark graph where nothing interesting is happening!), and so probably not worth the effort to refactor the tags support at both ends as you describe.


Improve error messages for validation

Before the .dacpac is written the DacpacTool will perform a validation of the model. This can yield errors and warnings which are currently written to the console. These are picked up by Visual Studio and show up in the Errors List as you would expected. However, they are not correlated to the source file nor the source location on which the error occurs. This data is probably available in the Validate method on the PackageBuilder, but we simply don't expose it properly.

I will have a look.

Need to investigate the difference between GetErrors() and Validate


When on a platform affected by physics, standing on a vertical piston-propelled slime block when the piston extends sends you flying over 6000 blocks into the air. Funny thing, I could see me experimental rocket on the way down.

Old issue, closed. This should be fixed in the latest version.


squirrel syntax file

syntax file for the squirrel programming language

Thanks.  I'll include support for the filetype and the other files will be in the next runtime file update.


Running on my own server + nginx proxying + hard-coded assets URL = fail

Hello.
I have installed Slackin on my own server, and set up nginx's proxy to hide awful port thingy.
This is what I get: https://midgardr.ardiefox.me/kr-bsd-slack/
As you can see, nothing appears correctly due to that hard-coded /assets/... resource URLs.
Following is my current configuration.
First, I installed Slackin locally on /root/node_modules/slackin and ran it inside tmux like this: slackin --port 12661 --interval 60000 "kr-bsd" "MY-TOKEN"
And, this is my nginx config:
# ...
# [redacted]
# ...
location /kr-bsd-slack/ {
        proxy_cache off;
        proxy_http_version 1.1;
        proxy_pass http://localhost:12661/;
        proxy_redirect off;
        proxy_set_header Host $http_host;
        proxy_set_header X-Real-IP $remote_addr;
        proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
        proxy_set_header X-Forwarded-Proto $scheme;
        proxy_set_header X-NginX-Proxy true;
}
# ...
# [redacted]
# ...

And finally, this is what I get on /var/log/nginx/error.log:
2015/04/02 02:21:35 [error] 89021#0: *132 open() "/usr/local/www/public_html/assets/slack.svg" failed (2: No such file or directory), client: <IP_ADDRESS>, server: midgardr.ardiefox.me, request: "GET /assets/slack.svg HTTP/1.1", host: "midgardr.ardiefox.me", referrer: "https://midgardr.ardiefox.me/kr-bsd-slack/"
2015/04/02 02:21:35 [error] 89021#0: *132 open() "/usr/local/www/public_html/assets/superagent.js" failed (2: No such file or directory), client: <IP_ADDRESS>, server: midgardr.ardiefox.me, request: "GET /assets/superagent.js HTTP/1.1", host: "midgardr.ardiefox.me", referrer: "https://midgardr.ardiefox.me/kr-bsd-slack/"
2015/04/02 02:21:35 [error] 89021#0: *132 open() "/usr/local/www/public_html/assets/client.js" failed (2: No such file or directory), client: <IP_ADDRESS>, server: midgardr.ardiefox.me, request: "GET /assets/client.js HTTP/1.1", host: "midgardr.ardiefox.me", referrer: "https://midgardr.ardiefox.me/kr-bsd-slack/"

According to the log, every request that starts with /assets/ basically goes into the public_html root of the server.
I even tried editing the source code to remove that webroot-referring URL, but failed eventually.
What should I do to solve this problem?

server {
    server_name slack.hummingbird.moe;
    location / {
        proxy_pass                  http://localhost:3000;
        proxy_set_header            Host $host;
    }
}

works for me

Decided not to use slackin.

@ardiefox Do you have any expirience with php + nginx ? Can you try to use my project? https://github.com/vluzrmos/lumen-slackin


[SPARK-34775][SQL] Push down limit through window when partitionSpec is not empty

What changes were proposed in this pull request?
This is a followup from #31691. Push down limit through Window when the partitionSpec of all window functions is not empty and the same order is used.
Push down limit through Window when the partitionSpec of all window functions is not empty
And the origin author is @leoluan2009, since he didn't reply for long and did this follow up after invitation
Why are the changes needed?
Improve query performance.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added UT

ping @wangyum

Test build #138616 has started for PR 32475 at commit 78dd97a.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43137/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43137/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43137/

Test build #138616 has finished for PR 32475 at commit 78dd97a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138616/

Test build #142483 has started for PR 32475 at commit 78dd97a.

Test build #142489 has started for PR 32475 at commit 78dd97a.

Test build #142483 has finished for PR 32475 at commit 78dd97a.

This patch fails Spark unit tests.
This patch does not merge cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142483/

Test build #142489 has finished for PR 32475 at commit 78dd97a.

This patch fails Spark unit tests.
This patch does not merge cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46994/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46994/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142489/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46994/


Add security link for the user to check before starting the verification

https://www.idenfy.com/security/

Issue update:
initialized the dialog, will check the UI with Ehab

Issue update: the dialog is ready, changed the flow as well, but I can't test due the KYC dev net issue

Verified, Devnet 96e183a.
The acceptance term and condition daily were added with the security link in it.

A new test case created in KYC: TC2935 - Accept terms and conditions

But this fix introduces a new error where the KYC doesn't open anywhere now except in your profile page only.
Any other page as FullVM gives this error.

verified on devnet
Version a9a62b8

testcase

Verified:

Devnet
96e183a

The verify button enter infinite loop when cancel the terms and condition from the deploy page.

Devnet
96e183a

Test steps

Create a new account
Fund it with 100 TFT
Go to deploy page --> deploy micro VM
press verify button
in the dialog for terms and conditions check the checkbox.
press the cancel button
NOW: you will notice that the verify button keep rotating and get into infinite loop.

logs
dashboard.log
Screenshots

Verified:

Devnet
7f9c4df


chore: disable dependabot

Description
Disable dependabot updates since renovate configuration was successful.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[x] Refactor/improvement

How Has This Been Tested?
N/A
Checklist
N/A

:tada: This PR is included in version 1.9.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Provide an ability to the Magento backend users (merchants) to set up country restrictions separately for each AlphaCommerceHub's payment option (bank cards, PayPal, POLi Payments, etc.)

Similar to #84 (Provide an ability to the Magento backend users (merchants) to set up the «Require the billing address?» option separately for each AlphaCommerceHub's payment option (bank cards, PayPal, POLi Payments, etc.))

It would be nice to implement mage2pro/core#62 first (Improve Magento\Payment\Model\Checks\CanUseForCountry\CountryProvider::getCountry(): it should give priority to the shipping country over the billing country for my modules).

Implemented in 0.7.4.

Currently, it does not work correctly if a shipping address is changed without the browser's page reload, because the following code is not executed in this case:
https://github.com/mage2pro/alphacommercehub/blob/0.7.5/view/frontend/web/loader.js#L11-L12

As I understand, I can just pass the country restriction rules from the server side to the customer's browser, and adjust the payment options visibility dynamically in JavaScript.


Do not include grpc.pb.h if the file does not define a service.

In Bazel build we do not generate grpc.pb.h if has_services is false. Yet we have files include grpc.pb.h rather than pb.h.

This one was fixed.


fix: fill in keys from where also for CREATE

for a request like
.post(`/Orders(ID=${rootID},IsActiveEntity=true)/items`)

we need to propagate rootID to the items insert as foreign key.
fixes 'cds/tests/_runtime/odata/__tests__/integration/draft-create.test.js', for ucsn2

The req.data should already include the foreign key... This change does not fix the root cause

real fix done in cds, problem was @core.computed propagation


Minikube related SC installation instructions are outdated

Bug Report
What happened:
Minikube fails to start when following SC installation on Minikube instructions https://github.com/kubernetes-incubator/service-catalog/blob/master/docs/install.md#minikube
What you expected to happen:
Minikube starts up successfully
How to reproduce it (as minimally and precisely as possible):
Using Minikube 0.28.2 try to follow SC installation instructions for Minikube
Anything else we need to know?:
Problem is with RBAC configuration parameters, SC docs currently use localkube bootstrapper compliant arguments while Minikube deprecated localkube and switched to kubeadm as default boostrapper which expects parameters to be passed little bit differently, so replacing --extra-config=apiserver.Authorization.Mode=RBAC with --extra-config=apiserver.authorization-mode=RBAC should do it, if not also add to the Minikube installation docs note about prerequisite on recent Minikube version.
Environment:

minikube version: v0.28.2
service-catalog version: v0.1.31

Same issue exists in Kubernetes docs on SC: https://github.com/kubernetes/website/blob/master/content/en/docs/tasks/service-catalog/install-service-catalog-using-helm.md

Thanks for reporting this and explaining how to fix.


X-Upcache-Vary-

How it works is similar to "scope":

request has headerName

upcache does not know anything about that header, it builds a request key a usual and miss

app maps that headerName value to a responseValue, stored in X-Upcache-Vary-<headerName>

upcache stores that mapping in a dictionnary varies[headerName][requestValue] -> <responseValue> and use that value to build a vary-<headerName>=<responseValue>

request has  <headerName>

upcache finds that varies[headerName][headerValue] exists and use it to build a request key, cache hit

Invalidation is not correlated to this, as with scopes.

A typical use case for this is "User-Agent" header for polyfill-service.


Unable to sign transaction w/ 2nd Ledger Nano S account

I have a Nano S with multiple Algo accounts.  While I was able to add the 2nd account to AlgoSigner and opt into Tinyman and Yieldly, I am unable to run any swaps on Tinyman.  The extension prompts to sign the transactions for the swap but it never sends the transaction to the Ledger and the site returns an error:
There was a problem signing the transaction(s).
The same error throws if I run it without the Ledger attached so it seems to act like it can't find the device (even though I am able to connect the wallet to the website and it sees both accounts)
1/28 Update:
As a followup I am now unable to sign any transactions with the Ledger Nano S, even a simple send between accounts. After clicking "Send Transaction To Device" it just sits and spins. I can remove/re-add the accounts to the extension so it is at least able to communicate with the Ledger and find accounts, but for some reason never sends over transactions for signing.
Environment details:
OS: Windows 10 (also the same issue with Ubuntu 20.04)
Ledger Firmware 2.1.0
Ledger Algo App 1.2.15

As a followup I am now unable to sign any transactions with the Ledger Nano S, even a simple send between accounts.  After clicking "Send Transaction To Device" it just sits and spins.  I can remove/re-add the accounts to the extension so it is at least able to communicate with the Ledger and find accounts, but for some reason never sends over transactions for signing.

Hi! Thanks for the report, I'll be taking a look into this and get back to you if I find anything.

Hi @cccassidy
Regarding the Tinyman swaps: currently we don't support signing more than 1 Ledger transaction in a single group at once using AlgoSigner. By looking the Tinyman swaps, 2 of the group transactions require a signature from the Ledger device: the first I'm guessing is getting Algos to pay for the fees, and the second one is the actual ASA to swap. So unless they implement fee pooling to avoid creating an extra transaction, it's not going to work on Ledger devices using AlgoSigner for now.
In regards to your 1/28 Update: we've identified an issue with Ledger signing from the UI. We have a fix ready that should come with a next release in the coming weeks.

Hi @janmarcano Appreciate the info, and will be on the lookout for the update to fix the 1/28 Ledger signing issue!

@cccassidy Version 1.7.3 should be live in the store with the fix for using Ledger devices on UI-made transactions.
Closing this as the Tinyman issue is currently out of our hands, I've already reached out to them.
Let us know if you find any further issues, cheers.


Consider using byte[] instead of string for keys and data

The Mysto FPE library familiy are using String internally and in the method signatures. It would probably be a big change or addition to these contracts, but would you consider accepting a PR for using byte[] instead (or at least in the method interfaces)?
Using String instead of byte[] for handling cryptographic keys or secrets in Java can have several security implications:
Immutability: Strings in Java are immutable, which means that once a String is created, it cannot be changed. Consequently, a cryptographic key or secret stored as a String will remain in memory until garbage collection occurs, which may take an indefinite amount of time. This exposes the sensitive information to a higher risk of being leaked or exploited through memory-based attacks. On the other hand, byte arrays are mutable, allowing the contents to be explicitly overwritten or zeroed out when they are no longer needed, reducing the risk of sensitive information leakage.
String Interning: Java maintains a pool of unique strings called the "string constant pool." When a new String object is created, it may be added to this pool, increasing the chances of sensitive information being exposed or leaked. With byte arrays, this risk is significantly reduced as they are not pooled.
Encoding issues: When working with cryptographic keys or secrets, it is essential to ensure that the data is handled as raw binary data. Using Strings may inadvertently introduce encoding issues (e.g., converting between character sets), which could lead to data corruption or incorrect processing. Byte arrays, on the other hand, naturally represent raw binary data and do not suffer from encoding-related issues.
Memory representation: Strings store their data as character arrays, which are typically twice the size of byte arrays because Java uses UTF-16 encoding. This may lead to increased memory usage when handling large cryptographic keys or secrets.
To mitigate these security risks, it is generally advisable to use byte arrays or other mutable data structures for handling cryptographic keys or secrets in Java. Additionally, one could also use specialized libraries like Java's javax.crypto.SecretKey interface, which is designed specifically for handling cryptographic keys securely.

We are implementing an FPE primitive for Google Tink, and in Google Tink all primitives are designed to accept and output byte[] arrays instead of other data types. This is because byte[] is a universally supported data type that can be easily serialized, transported, and stored in various formats. To be compliant with this philosophy, when working with the Mysto FPE libraries, we end up doing a lot of byte[]->string->byte[] conversions, which might have performance implications.
The following are some of rationale behind the Google Tink byte[] design decision:
Security: byte[] arrays are a basic unit of data in cryptographic operations. Using byte[] arrays ensures that data is being processed at the lowest possible level, which can help ensure that the cryptographic operations are secure.
Interoperability: byte[] arrays can be easily serialized and deserialized in a platform-independent way. This makes it easier to transport and share data between different platforms and programming languages.
Flexibility: byte[] arrays can represent any type of data, from strings to integers to binary data. This makes them a versatile and flexible data type that can be used in a wide range of applications.
While it may be more convenient to use other data types in some cases, using byte[] arrays provides a consistent and reliable approach to handling data in cryptographic operations. By sticking to a standard data type, Tink can provide a simpler and more secure way to implement cryptographic primitives.

@kschulst you make an excellent argument. The Mysto clang version here uses OPENSSL_clear_free() for exactly this reason - to overwrite the data before releasing the memory.

@kschulst would adding the following suite your needs?

public FF3Cipher(byte[] key, String tweak)
public FF3Cipher(byte[] key, String tweak, String alphabet)
public FF3Cipher(byte[] key, String tweak, int radix)

Hi, any plan to release new version for  this enhancement?

@kschulst would you be interested in submitting a PR for this?

Thanks @altr-benjamin, marking resolved!


Add support for approving InstallPlans with multiple CSVs

First Commit
The operatorpolicy.policy.open-cluster-management.io/managed label is set to an empty value on the Subscription. The
operatorpolicy.policy.open-cluster-management.io/managed annotation is set to ..
The label doesn't set a value because the value could be too long.
This will allow querying for subscriptions managed by operator policies.
Second Commit
When an InstallPlan contains multiple CSVs, it will be approved if all CSVs can be approved by the current operator policies.
Rather than query the operator policies directly, the subscriptions in the namespace that are managed by an operator policy are queried and then their associated operator policies are queried to avoid having to resolve templates.
Relates:
https://issues.redhat.com/browse/ACM-11981

/unhold


Syncing from upstream patroni/patroni (master)

bt_gitbot

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

720 of 721 (99.86%)  changed or added relevant lines in 44 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 99.867%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

patroni/postgresql/bootstrap.py
1
2
50.0%

Totals

Change from base Build<PHONE_NUMBER>8:
0.02%

Covered Lines:
14228

Relevant Lines:
14247

💛  - Coveralls


Review spacing in some edge case resolutions (1024px to 1300ish px width)

Probably fixing from 1024px to 1280px (lg breakpoint) may be enough if next breakpoint makes it look worse in bigger resolutions from the xl breakpoint.

1280px example

Is it only for "completed grants"?

Is it only for "completed grants"?

Yep! Maybe other sections could have a little more spacing but not sure if they would look better or worse. So we can just set "completed grants" like they other ones and it would look balanced.

Should be fixed at #84
leave this open until test (I yoloed the PR)

Should be fixed at https://github.com/BuidlGuidl/grants.buidlguidl.com/pull/84

I see it great now! TYSM! Closing 🙌


Update juan-fernandes.json

Add authoredBy

Ah, sorry this is confusing but authoredBy is only needed if it doesn’t match twitter


Blueprint manipulation donation

This may or may not be useful to this project, but I thought I'd donate it here in case you thought it may be.  Attempting to work with blueprints (specifically of the ctrl-c variety being stamped on existing entities) is tough.  We don't get many events with a lot of info.  Just on_pre_build.  So you pretty much have to do your own BP position calculations.  These are a couple of functions that I put together to get a bounding box of all the BP entities, and how to find the center of where the BP will be placed.  If helpful, feel free to use them freely in flib.
---@param entities BlueprintEntity[] # E.g. from LuaPlayer.get_blueprint_entities()
---@return BoundingBox # Box that contains all blueprint entities
---@return uint # The building grid size needed to build this blueprint
function M.get_blueprint_bounding_box(entities)
  local box = flib_box.from_position(entities[1].position, true)
  local names = {}
  for _, e in ipairs(entities) do
    names[e.name] = true
  end

  local name_filter = {}
  for k, _ in pairs(names) do
    table.insert(name_filter, k)
  end

  -- Define a bounding box the size of the blueprint to be placed
  local grid_size = 1
  ---@diagnostic disable-next-line:missing-fields
  local protos = game.get_filtered_entity_prototypes{{filter = "name", name = name_filter}}
  for _, entity in pairs(entities) do
    local collision_box = protos[entity.name].collision_box
    grid_size = math.max(grid_size, protos[entity.name].building_grid_bit_shift)
    box = flib_box.expand_to_contain_box(
      box,
      flib_box.from_dimensions(
        entity.position,
        flib_box.width(collision_box),
        flib_box.height(collision_box)
      )
    )
  end

  -- Expand bounding box to be full tiles based on the entity with the largest building grid size
  box.left_top.x = grid_size * math.floor(box.left_top.x / grid_size)
  box.left_top.y = grid_size * math.floor(box.left_top.y / grid_size)
  box.right_bottom.x = grid_size * math.ceil(box.right_bottom.x / grid_size)
  box.right_bottom.y = grid_size * math.ceil(box.right_bottom.y / grid_size)
  return box, grid_size
end

---@param box BoundingBox # Bounding box of blueprint to place
---@param pos MapPosition # Position to center new bounding box around
---@param grid_size uint? # Building grid size to base centering.  Default: 1
---@return MapPosition # Center position of where blueprint will be placed
function M.get_placed_blueprint_center(box, pos, grid_size)
  local grid_size = grid_size or 1
  local pos_x = pos.x or pos[1]
  local pos_y = pos.y or pos[2]
  pos_x = (flib_box.width(box) / grid_size) % 2 == 0
          and math.floor(pos_x / grid_size + .5 ) * grid_size
          or math.floor(pos_x / grid_size) * grid_size + grid_size / 2
  pos_y = (flib_box.height(box) / grid_size) % 2 == 0
          and math.floor(pos_y / grid_size + .5 ) * grid_size
          or math.floor(pos_y / grid_size) * grid_size + grid_size / 2
  if pos.x then
    return { x = pos_x, y = pos_y }
  else
    return { pos_x, pos_y }
  end
end

I think it would be a good idea to have some blueprint functions. If you make a pull request we can get these added!


Confused about where files get saved

What is the purpose of the ~/.cheat folder vs. the ~/.config/cheat/cheatsheets/personal folder?
I created a new cheatsheet for myself, like this cheat -e terminal.  I would have expected it to be saved in my personal folder, but it was saved in the .cheat folder.
Thanks.  I really the idea of this, and I'd like to better understand the rationale.

Hello
They solve fundamentally different problems. One directory stores configuration data for the cheat executable, and the other stores your cheatsheets.
There's a bit of nuance to understand here.

What is the purpose of the ~/.cheat folder

In general, cheat executable configs likely live here. That said, configs needn't strictly live here. cheat honors the XDG specification in where it attempts to locate config information. If you squint at the code a bit, you can see where it checks for configs:
https://github.com/cheat/cheat/blob/master/internal/config/paths.go

vs. the ~/.config/cheat/cheatsheets/personal folder?

There's nothing special about this path. In your config file, you may specify any arbitrary number of locations at which cheatsheets may be found. You can store cheatsheets in your home directory, your "My Documents" folder, on your desktop - it doesn't matter. These paths can be whatever you like.
If you have "competing" cheatsheets that appear in several directories, cheat will (by default) display the one that comes "latest" in your config file. This is useful because it's quite common for folks to have "community" cheatsheets and "personal" cheatsheets, and, presumably, users would consider their personal cheatsheets to be higher priority.
The README talks about this in a bit more detail.
Does that make sense?

I'm going to close this ticket, but feel free to re-open it if you have further questions. Thanks.


Decrease minSdk?

i am editing the code, shall i decrease the minSdk.
why is that 17?
is not 14 enough?

I tried to the lowest possible and still keep it compiling.
A very quick check on my side raises errors in UpdateService on lines 102, 110, 112, 114, 172, 189, 201, 203, 205 and a few more.
Using the support library may/will help but I currently decided not to use it as I wanted to keep the app small.

Okay dude

I keep the issue open because it's interesting to try to support a lower API level.

Ok, i've implemented new features in my fork, few changes left.
What version code and name shall we assign?

APK size is just 101KB, so it is better to use support library and support more devices.
or
remove new style notification builder, and use old deprecated style notification.
What should we do?

I'll flag it as invalid for now: I want to keep the APK as small as possible as it's not doing much and for sure less than 1MB.
OK for lowering the API level if the downgrades in features are not too significant.


DataStreamer ContinuouslyAutoscale

Issue: If the ContinuouslyAutoscale is True some chart components get lost (Markers for example)
ScottPlot Version: 5.0.28
Code Sample: See http://scottplot.net/faq/repro/ for tips about creating reproducible code samples
using System;
using System.Collections.Generic;
using System.Threading;
using System.Threading.Tasks;
using ScottPlot;
using ScottPlot.Plottables;
using ScottPlot.WPF;

namespace trips.playback.plotters.scottplot;

public class RealTimeChart : ITestScenario
{
    private List<Task> _tasks;

    public RealTimeChart(WpfPlot wpfplot1, WpfPlot wpfplot2)
    {
        wpfplot1.Plot.Axes.AutoScale();
        wpfplot2.Plot.Axes.AutoScale();

        Task.Run(() => DoWork(wpfplot1));
    }

    private Task DoWork(WpfPlot plot)
    {
        const int points = 1000;

        var streamer = plot.Plot.Add.DataStreamer(points);
        //streamer.ContinuouslyAutoscale = true; // UNCOMMENT THIS LINE AND THE MARKER POSITION (X) GOES CRAZY.
        streamer.ViewScrollLeft();

        int x = 0;
        Marker? m1 = null;

        while (true)
        {
            double y = Math.Sin(x);
            streamer.Add(y);

            if (m1 == null)
            {
                m1 = plot.Plot.Add.Marker(points, Math.Sin(x), MarkerShape.FilledCircle, 10, Colors.Black);
            }
            else
            {
                if (m1.Location.X > 0)
                {
                    m1.Location = new Coordinates(m1.Location.X - 1, m1.Location.Y);
                }
                else
                {
                    m1.Location = new Coordinates(points, y);
                }
            }

            Thread.Sleep(10);
            plot.Refresh();
            x++;
        }
    }
}

Wrong behaviour

Hi @rubenslkirchner, I'm starting to work on this now. Can you clarify what behavior you expect? If the data streamer is only 1000 points and new data causes that marker to roll off the screen to the left, do you want the autoscaling to continue to widen the view to include it in the plot area even though it will just look like a marker floating in space with no data behind it?
Either way I'll refactor the "ContinuouslyAutoscale" feature a bit, moving it into the Plot itself, allowing it to be used for all data types.

@swharden good news! The problem is that the marker is floating over the line series. Did you notice this?

I noticed it, but I'm not sure I understand the expected behavior. I'm about to reply with a screenshot to see if it's what you had in mind...

Right at the beginning of the video, the space between the marker and the sine values gets closer but should maintain the same distance.

As an alternative to allowing a single DataStreamer to manage the axes, I'm adding a flag to autoscale the plot (evaluating all plotted objects) at the start of each render.
WpfPlot1.Plot.Axes.ContinuouslyAutoscale = true;

The video shows what happens when you switch between the two control strategies. What do you think about the behavior displayed in this video?

In my scenario the marker will be destroyed when x=0

In my scenario the marker will be destroyed when x=0

In my scenario the marker will be destroyed when x=0

Ah, that was the missing piece that confused me... I think this will be a good solution then!
I plan on publishing a new package tonight so you can try it out 👍
Thanks again for your feedback along the way!

I think this has been resolved by 72c0322 and 4378e83 but let me know if the behavior isn't what you expect and we can open this back up 👍

Working perfectly!


feature/prettier : Add ESLint & prettier

What was added

add dev dependency prettier, eslint + plugins
add script to run prettier, eslint on "/src/*.js"
add config .prettierrc, eslint.config.js

Related Issues

link related issues here
REPO_NAME #issueNum

Future Works

What else should be done ?

Checklist

[ ] I have performed unit tests
[ ] I have added necessary docs
[ ] I have checked for potential bugs & issues

stale PR


Properties of Reference Implementations

What should constitute a reference implementation?
Some early thoughts:

GitHub issue with a link to a working doc
-- algorithm details: e.g. network structure
-- normalization
-- pre-processing
-- hyper-param tuning
-- optimizations
-- GPU/accelerator assumptions and optimizations
-- datasets for validation: a small dataset for QA and some reference ones.
-- reproducing the results
code should checked against this issue
checking and review guidelines
-- get initial design doc reviewed
-- check in test harness/infra with scripts
-- check in the implementation with a [WIP] tag, get initial reviews
-- at least 2 core +ve and no -ve reviews. Core reviewers are expected to run against small dataset at a minimum to OK. Ideally one of the reviews should be from a subject matter expert. Also reviewers should check for adherence to coding guidelines.

Moved to the training code repo.


PR closed when it shouldn't have been?

From @RohanNagar on April 2, 2018 17:9
Hello,
I was going through Dependabot's PRs this morning and something weird happened. The first PR I merged was RohanNagar/thunder#114, which updated a bunch of dependencies that share the same version number.
Once I merged that, I looked at RohanNagar/thunder#116 and found that Dependabot closed this without rebasing, saying "Looks like these dependencies are updatable in another way, so this is no longer needed.". However, the dependencies in that PR were not updated by the one that was merged or by any other commit.
Is this a bug? (Language is Java)
Copied from original issue: dependabot/feedback#116

Hmmm, this does look like a bug. I'll look into it - thanks for reporting.

From @RohanNagar on April 9, 2018 16:54
Bug was reproduced this morning: I just merged RohanNagar/thunder#125, and dependabot closed RohanNagar/thunder#124 with the same message, though those dependencies have not been updated on the master branch yet.
Maybe of note: I merged the first PR using the "squash and merge" option, which I don't normally do for Dependabot pull requests. I did this for both this morning and last week because that option was still selected from some other PRs that I merged earlier.


Update yaml to match instructions.

The Problem/Issue/Bug:
The instructions in the pantheon.yaml.example file say to:
In your project's .ddev/providers directory, copy pantheon.yaml.example to pantheon.yaml and edit the project_id and environment_name.
There is no project_idor environment_name in the file. Instead, yourproject.dev must be defined.
How this PR Solves The Problem:
Renames yourproject.dev to project_id.environment_name to match with the instructions.
Manual Testing Instructions:
Review the PR.
Automated Testing Overview:
N/A
Related Issue Link(s):
N/A
Release/Deployment notes:
N/A

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This isn't correct; it's the instructions that are wrong :)

Hi @rfay , how does this look instead?

Thanks for this. I probably won't be able to review it this week.


Simultaneous WebRTC performance degredation in 1.0.1

Which version are you using?
v1.0.1
Which operating system are you using?

[ ] Linux amd64 standard
[ ] Linux amd64 Docker
[ ] Linux arm64 standard
[ ] Linux arm64 Docker
[ ] Linux arm7 standard
[ ] Linux arm7 Docker
[ ] Linux arm6 standard
[ ] Linux arm6 Docker
[ ] Windows amd64 standard
[ ] Windows amd64 Docker (WSL backend)
[ ] macOS amd64 standard
[X] macOS arm64 standard
[ ] macOS amd64 Docker
[ ] Other (please describe)

Describe the issue
There seems to be a bug causing slow / stuttering and often disconnecting streams when loading the same URL in multiple browser windows.. e.g. http://localhost:8889/test1/
Specifically this is for an RTSP to WebRTC stream.  I downgraded back to 1.0.0 and confirmed that it began working as expected again.
Describe how to replicate the issue

start the server
publish with an RTSP to WebRTC stream
open the same WebRTC Stream in two browser windows.

27aec28e-6181-4753-9acd-0456a75f0289:
    runOnDemand: ffmpeg -rtsp_transport tcp -i rtsp://username:password@xxx.xxx.xxx.xxx:554 -acodec pcm_mulaw -vcodec copy -f rtsp rtsp://localhost:$RTSP_PORT/$RTSP_PATH
    runOnDemandRestart: yes

1.0.1 Screen Capture
1.0.0 Screen Capture
I confirmed the problem also exists in 1.0.2
Did you attach the server logs?
no
Did you attach a network dump?
no

Thank you very much for reporting this critical issue, a new version is being released immediately (v1.0.3).

Not sure if this is a related issue but I'm seeing similar negative behaviour (poor perf, dropouts, etc.) on my rtsp proxy (wyze rtsp -> mediamtx rtsp proxy -> clients even on v.1.0.3.
I rolled back to v.1.0.0 and all seems fine again. I'll need to dig into logs when I have time (it proxies our kid cams) to tinker around with it again.


Support user defined preallocated array sizes

Synchronise changes required for https://github.com/ArduPilot/Micro-XRCE-DDS-Gen/pull/2

Hey there, I just ran a sync in the Github UI for master branch and now see there are conflicts. I've also added the 2.0.x and 3.0.x branches. Do you know if this was re-targetted on a one of those, it would go in cleanly? It would help to understand which branch we are pulling from, or if you manually cherry-picked these commits.

It would help to understand which branch we are pulling from, or if you manually cherry-picked these commits.

I created a branch from the submodule commit used in the PR https://github.com/eProsima/Micro-XRCE-DDS-Gen/pull/74, and created the PR from that.

Perfect, this is much more clear now. Thanks! I'll update downstream to use this.


catchException catches all exceptions rather than just Error exceptions

It seems clear that this package is intended to catch Error exceptions. However, catchException does this:
try {
        return t();
      } catch (e) {
        if (e instanceof Error || Object.prototype.toString.call(e) === "[object Error]") {
          return c(e)();
        } else {
          return c(new Error(e.toString()))();
        }
}

That is, if the exception is determined to not be an Error exception, it attempts to convert the exception to an Error exception. This conversion itself throws for both null and undefined, which are possible values. Furthermore, this implementation prevents users from catching other types of exceptions in an obvious way (they would have to use a different catch before this one).
Suggestion: just rethrow the exception if it is not Error.

I think this makes sense?
At the very least, there could be a variant that will only catch Errors and just rethrow exceptions, but I'm not sure whether that's desirable or not.

It's definitely a problem that attempting to catch a thrown null or undefined will throw an unrelated exception inside the implementation of catchException. I also think it's not ideal that we can't catch some other kind of thrown non-Error object without converting it into an Error, especially if it's a lossy conversion - .toString() usually loses information. Perhaps we could save the originally thrown object by writing it to a new property on the Error we are throwing.
However, I think catching a thrown object even if it's not Error does make sense. If I've written catchException, then I want exceptions to be caught. I would be open to adding an catchExceptionForeign which types the argument as Foreign, or something along those lines, for when you're expecting something which isn't necessarily an Error to be thrown. I would also be open to adding a variant which only catches Errors and rethrows everything else, but I don't think that should be the default.

There’s a stage 2 proposal to add a cause property to errors: https://github.com/tc39/proposal-error-cause. We could perhaps add the value originally thrown on the newly created error, under a cause property, when the proposal will reach stage 3 or 4?

There’s a stage 2 proposal to add a cause property to errors: https://github.com/tc39/proposal-error-cause. We could perhaps add the value originally thrown on the newly created error, under a cause property, when the proposal will reach stage 3 or 4?

It looks like the proposal has reached stage 4 now.

Looks like 88% of browsers support that? https://caniuse.com/mdn-javascript_builtins_error_cause

Even without native support for cause... this is JavaScript, so we could just attach the caught value as any arbitrary property to the Error we create; caught, inner, or something.


Fix warnings when mix test

List of warnings:

warning: use of operator < has no effect
warning: variable "acc" is unused
warning: variable "get_answers" does not exist and is being expanded to "get_answers()"

We also add the --warnings-as-errors option to mix test in GitHub
Actions.

Awesome as always @kianmeng!


Minimized code to reproduce the error.

import os
import pytest

import mars.tensor as mt
from mars.deploy.oscar.local import new_cluster

@pytest.fixture()
async def create_cluster():
    start_method = os.environ.get('POOL_START_METHOD', None)
    client = await new_cluster(subprocess_start_method=start_method,
                               n_worker=2,
                               n_cpu=2)
    async with client:
        yield client

@pytest.mark.asyncio
async def test_case(create_cluster):
    a = mt.ones((10, 10))
    b = a + 1
    b.execute()

Expected behavior
A clear and concise description of what you expected to happen.
Additional context
Add any other context about the problem here.

This is because cluster is created in the main event loop, so does the test function, so the execute method will block current event loop, in #2168 , I added a verification logic so that this behavior is not allowed.


[docs-infra] Prefetch pages on hover

Inspired by #40313. The idea is to reproduce what we do for the side nav but for all the markdown links.
Before: https://deploy-preview-40310--material-ui.netlify.app/material-ui/getting-started/usage/
https://github.com/mui/material-ui/assets/3165635/548ca3ed-6191-4d37-8d11-3b353c063f25
After: https://deploy-preview-40314--material-ui.netlify.app/material-ui/getting-started/usage/
https://github.com/mui/material-ui/assets/3165635/6cd53646-11f3-4cd3-9f58-dba623dea713
We save about 100-200ms in the page transition, that time here:

This is a significant UX improvement on my end, but there is still a lot we could do to make the docs feel super responsive. It doesn't feel great yet.

In the future, we should be able to make the whole markdown a server-side component with Next.js link as client-side components.

I'm excited about this change, a step toward a super slick docs experience 🧈


Update changes required

In this PR, I did the following changes:

Made the changes required by the reviewer.

STATUS: APPROVED 🎉🎉🎉
Great job! We can now merge this pull request!.

Highlights
Correct linters ✅
Great use of gitflow ✅
Good code design and implementation ✅
Good API implementation  ✅
Required Changes ♻
None
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:
N/A
Cheers and Happy coding!👏


Return original event loop after test case

Description
After running any test case which is using async test, the loop will end up closed. Which is because:

When asynctest.TestCase initializing new test it creates new loop in _init_loop method.
Then replace current loop with this new created
After test it closes TestCase's loop, which is now the current loop - and never return original one.

Then this closed loop end up as current loop.
Issue
The problem is that, after running any async test case, the asyncio module end up in unusable and different state than which it was before running tests.
Solution

In _init_loop store reference to original event loop, and then proceed same way.
Closing of test's loop is done inside cleanup - so add another cleanup after the one which close the loop. This new cleanup will restore original loop.
- Or just override _unset_loop to set original loop back

Thanks for reporting your issue.
Can you explain me why you want or need the loop outside the test case? It seems like a legitimate request, but I want to be sure it's implemented correctly, because I don't want to introduce confusion about the state of the default loop in a test function.
I am considering doing the following:

add an option allowing to set the default loop to None during the test, ensuring that the loop object is passed explicitly and asyncio.get_event_loop() isn't used in the tested code.
keeping track of the default loop the loop obtained by asyncio.get_event_loop() before replacing it, and restoring it after the test (as proposed in this issue). An other solution would be to mock asyncio.get_event_loop().

In any case, asyncio.get_event_loop() must never return a loop object which is not the same as self.loop.

Thank you for a quick reply.
I don't explicitly need the loop outside of the test case. But i have couple of old test cases which are using unittest.TestCase. These tests creating some objects instances which are now using some part of asyncio module - but these tests do not need asyncio.
Then i start using asynctest, which led to broken unittest test cases. Because i have run all test cases, and if asynctest case was executed before unittest case, the loop was already closed.
Correct way would be mocking out asyncio parts from these objects, and i will do so.
But also as i mentioned before running a test case should not lead to change of a state in the asyncio module (the current event loop state).

Yes, you are right about the state change. I will try to push a fix today.

I close the bug, I will put a release on pypi soon.


Uploaded text downloads as STDIN

Hello again i know i asked way back for this feature. But can we have an exeption so that files download as files (no browser open), but uploaded text still opens in the browser?
Turns out this feature is awesome for sharing passwords but its a bit problematic to explain ppl every time :)
Thanks for your hard work 👍

Hi,
I'd have to think about the way to do that. I would have to add a field in the database so I know if it was a file or stdin, because right now there is no differentiation between those two.
I'll have a look in an hour or so 👍

Just so I can get some clarification : You never want to display the file in browser ? Always download ? Or is that some special case for just files uploaded from stdin ?
Because there's already a always_download setting that allows to never display the content in browser and always offer to download the file. Also if you don't want your file to be named "stdin", simply use the -n/--name flag using the client or curl -F name="myfile.txt" ... as shown in the docs about curl

I was talking about only the text upload  when you write stuff in the field.

The new function where you can set how it will display it is awesome btw its just a little confusing when you can set those to file uploads too. (I can imagine users setting it to display a pdf as markup for example hence my other issue #58 )
I will check out what you wrote to #58 and try to add it like you explained (never programmed before :) )

Maybe I could just add an option in the upload form to say "this is a file named xxx and I never want it to be displayed in the browser" ? In such a case, I could add a field in the database and prevent the formatting (syntax highlighting, line numbers and theme) when the upload is completed and when the file is retrieved ?
I'll design a poc when I can and show it to you so you can validate if that fixes your use case 🤔

im not sure i understand. What i try to achieve is:

files would not be opened by browser (this works good when i set the always download option)

text uploaded would show in browser (with aweseome new functions :) )

Im sorry if i misunderstood you

Oh I see !
I don't know if that's possible as I have no way to know how the file was uploaded. I think I can just check for the filename and if it's stdin then show them in browser. But that would require that stdin is never changed, as soon as you give your file another name it would download. Sounds good ?

Oh i didnt know that.
So when i upload text (write stuff in the field like in the picture) it uploads as stdin?
Cool sounds gr8 :)

Yes I think. Just as when you upload from the command line, as there is no way for me to determine the name of the file you're trying to upload (since it's not a file but a stream), I name it stdin.


docs: remove useless contents

Signed-off-by: lowzj<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #592 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #592   +/-   ##
=======================================
  Coverage   47.26%   47.26%
=======================================
  Files          97       97
  Lines        5600     5600
=======================================
  Hits         2647     2647
  Misses       2733     2733
  Partials      220      220

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 960e4ff...ea0cb74. Read the comment docs.


”GIURGIU” is listed in the drop-down menu

Description:
"GIURGIU" is listed in the drop-down menu alongside its corresponding county and commune, according to the law.
Precondition:
The website is up an running.

Step 1
Type "GIURGIU" in the search bar.

Expected results
The location is listed in the drop-down menu as "Municipiul GIURGIU, COVASNA".


GDScript Editor Nesting bug

Godot version
4.1.3-Stable
System information
Windows 10
Issue description
GDScript editor nesting isn't working always correctly. When I want to collabse a function it sometimes collabses the next funtions """ comments with it. Annoying little bug, and I think it is because I use space in
Steps to reproduce
(Image 1) First I have this stupidly simple function which nulls my values. I can collabse everything (lines 51, 59, and 64) correctly except line 54 which is func clearNPC(). If I collabse it, image 2 will occur. If I collabse line 59 first, then Image 3 happens. This happens because I start the comment line with empty space. If I remove the spaces in the beginning of the line 62, collabse continue to work normally.

Minimal reproduction project
N/A

Happens the same when doing something similar with single line comments:

Investigating a bit it seems that this is being processed in the function fold_line from code_edit.cpp. When trying to count how many lines should be folded It only stops when it finds a new block of code or reaches the end of the file while keeping track of the highest line with and indentation level higher than the one it started at. Is the expected outcome to have all the text be treated with the same indentation level as the start of the multi line comment?


API Gateway setup for REST APIs has no CORS enabled for default 4xx and 5xx errors

Describe the bug
Current setup throws CORS errors to the client instead of the underlying 4xx or 5xx making debugging much difficult. This should also fix these issues: #5013, #4937
Amplify CLI Version
4.27.3
To Reproduce
Run amplify add api to create a new REST API for /todos on the root of a new project and follow the steps below

Please select from one of the below mentioned services: REST
Provide a friendly name for your resource to be used as a label for this category in the project: todosApi
Provide a path (e.g., /book/{isbn}): /todos
Choose a Lambda source Create a new Lambda function
Provide a friendly name for your resource to be used as a label for this category in the project: todosLambda
Provide the AWS Lambda function name: todosLambda
Choose the runtime that you want to use: NodeJS
Choose the function template that you want to use: Serverless ExpressJS function
Do you want to access other resources in this project from your Lambda function? No
Do you want to invoke this function on a recurring schedule? No
Do you want to configure Lambda layers for this function? No
Do you want to edit the local lambda function now? Yes
Restrict API access Yes
Who should have access? Authenticated and Guest users
What kind of access do you want for Authenticated users? create, read, update, delete
What kind of access do you want for Guest users? read
Do you want to add another path? No

When trying to access /items (a non-existing route) it throws a CORS error

Expected behavior
After enabling CORS for default 4xx and 5xx errors I get a more detailed response when trying /items (a non-existing route)

Setting up CORS for 4xx and 5xx errors in API Gateway Console

Desktop (please complete the following information):

OS: Mac
Node Version: v14.7.0

Additional context
Enable CORS with custom headers for an AWS Lambda function behind API Gateway

I am marking this as an enhancement and tagged for it to get prioritized

When will this be available?

I found the error. The ARN was broken. It missed a star in the GET proxy:
OLD
...
            "Resource": [
                "<ARN>staging/GET/*",
                "<ARN>/staging/GET//*",
            ]
...
}```

*NEW*
```{
...
            "Resource": [
                "<ARN>staging/GET/*",
                "<ARN>/staging/GET/*/*",
            ]
...
}```

Is there a possible workaround to allow CORS by still using the CLI ?

I submitted a PR for to allow CORS for default 4xx and 5xx errors


Add missing exception variable

:+1:

Could use a unit test to exercise that path, but otherwise fine to expedite to unblock CI.

:shipit:

:+1:

:+1:


cli: change sleep behavior for 'popper check'

The check.py popper check command, after launching a stage (e.g. setup.sh) continuously checks its status by sleeping for 20 seconds and, after waking up again, checking whether the task finished or not.
For short running tasks (e.g. demos on empty projects), this is too long. In order to make this more adaptive, we can modify the sleep behavior in check.py based on given timeout (instead of the fixed check every 20 secs), incrementing logaritmically up to 1% of given timeout (or an arbitrary number like 60 secs).

Hey @ivotron , by incrementing logarithmically ,do you mean the sleep time will start from 1 sec and will increase logarithmically until it reaches 1% of the given timeout or will start from 1% of the given timeout and will increase by 1% of the timeout in each loop?

Hi @AnishHota , sorry, I should have said "sleep time increases exponentially over time".  By this, we mean that the script first sleeps for 2 seconds and, after it wakes up, it checks the status of the command. If the command hasn't finished, we sleep for 4 seconds, then for 8, then 16, then 32.... until we reach a maximum of say 5 minutes. Does this make sense?

Yeah, it makes sense now.Thank you.


Is Change password permission required?

Reset password
Change password
Write permissions on lockoutTime
Write permissions on pwdLastSet
Extended rights for "Unexpire Password" on the root object of each domain in that forest, if not already set.

Is Change password permission required? And does it need to be assigned to the MSOL_* (AD DS Connector account) account ?
In AD, the Change password permission is required for the user who changes their own password using their current password.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 115ae83a-95dd-5643-bc88-f5447ebb2b99
Version Independent ID: 7462ce84-0a9f-4bfd-7eba-c00928d77865
Content: Enable Microsoft Entra password writeback - Microsoft Entra
Content Source: articles/active-directory/authentication/tutorial-enable-sspr-writeback.md
Service: active-directory
Sub-service: authentication
GitHub Login: @Justinha
Microsoft Alias: justinha

@LijuV-MSFT
Thanks for your feedback! We will investigate and update as appropriate.

@Justinha
Can you please check and add your comments on this doc update request as applicable.

@LijuV-MSFT
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly.

@LijuV-MSFT
We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.

@LijuV-MSFT Yes, change password permission required for the Entra Connect service account, as service account will be updating the password on behalf of the user in On-premises AD.

@SaibabaBalapur-MSFT , that is just it, I was able to perform SSPR without this permission assigned to the MSOL account. Have you been able to verify this?

@LijuV-MSFT Reviewing this post, I assume your query is related to change password permissions for the msol account. by default, User default permissions for Everyone has the change password permissions set,

User default permissions for Msol account

Hope this clarifies your query.

Yes, my suggestion in that case is that we add a note that typically, the Change password right does not need to be explicitly granted to the MSOL account.
To correctly work with SSPR writeback, **the account specified in Microsoft Entra Connect must have the appropriate permissions and options set.** If you're not sure which account is currently in use, open Microsoft Entra Connect and select the View current configuration option. The account that you need to add permissions to is listed under Synchronized Directories. **The following permissions and options must be set on the account:**

Reset password
**Change password**
Write permissions on lockoutTime
Write permissions on pwdLastSet
Extended rights for "Unexpire Password" on the root object of each domain in that forest, if not already set.


how to parse mv <files>... <target>?

E.g.: mv a1 a2 a3/
I use the code like this:
let m = App::new()
  .arg(Arg::with_name("files").required(true).multiple(true))
  .arg(Arg::with_name("target").required(true))
  .get_matches();

When input mv a1 a2 a3/, I expect result like this:
{
  files: ["a1", "a2"],
  target: "a3",
}

But I got a error:
error: The following required arguments were not provided:
    <target>

This is because there's no way to know when <files> ends and <target> starts. Positional arguments that take multiple values must be the last positional argument.
There are two ways to fix this, either swap the arguments (i.e. <target> <files>...) or limit the number of values to a fixed number (i.e. <file> <file> <target>). Obviously one of those solutions is less viable than the other (fixed number of files), but it's still an option.
Hope this helps! I'm also open to suggestions :wink:

Also, thinking about this a little more, there may be a way I could add this feature. Let me play with some implementations and get back with you!

I found a way to make this work, after #727 merges I'll upload v2.17.0 to crates.io
At which point this will give the expected results:
let m = App::new()
  .arg(Arg::with_name("files").required(true).multiple(true))
  .arg(Arg::with_name("target").required(true))
  .get_matches();

@hh9527 v2.17.0 is up on crates.io now

waooo, it is so nice of you! thank you for this great project!

@kbknapp I have tried v2.17.0, it works without subcommand, but still break in subcommand.
This works:
    let m = App::new("mv")
        .arg(Arg::with_name("paths").required(true).multiple(true))
        .arg(Arg::with_name("target").required(true))
        .get_matches();

And this not:
    let m = App::new("cli")
        .subcommand(
            SubCommand::with_name("mv")
                .arg(Arg::with_name("paths").required(true).multiple(true))
                .arg(Arg::with_name("target").required(true))
        ).get_matches();

Ah, thanks for pointing this out, I hadn't testsed it after a subcommand, only before!

It's fixed in #730 :wink:

v2.17.1 is up now!


⚠ Bofrost.si has degraded performance

In 9732fd5, Bofrost.si (https://www.bofrost.si) experienced degraded performance:

HTTP code: 200
Response time: 1281 ms

Resolved: Bofrost.si performance has improved in ad75359 after 6 minutes.


[css] no code assist proposals after variable declaration

From testing #6656
:root {
  --foo: block;
  //code assist here

}

Code assist should show regular rule proposals, such as display or background.

This is true for SASS variable declarations, hence removed CSS tag.


dwarf-fortress/dfhack: fix build with gcc 11

Description of changes
gcc11 increased hardening, and a taking address of rvalue warning was promoted to an error.
closes: #170572
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build dwarf-fortress-packages.dwarf-fortress-full


Fix typo

What this PR does / why we need it:
Change complared to compared
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

Good catch!
/approve


Error with an android basic checkout

Hi. I'm trying to use a basic checkout android. Im following this docs
Using the sample code, everything works fine:
public void submit(View view) {

  // Iniciar el checkout de MercadoPago
  new MercadoPago.StartActivityBuilder()
    .setActivity(this)
    .setPublicKey("TEST-ad365c37-8012-4014-84f5-6c895b3f8e0a")
    .setCheckoutPreferenceId("150216849-ceed1ee4-8ab9-4449-869f-f4a8565d386f")
    .startCheckoutActivity();

}

But if i use my own data for test with a sandbox account, i have an error: See video
new MercadoPago.StartActivityBuilder()
                .setActivity(this)
                .setPublicKey("TEST-fa1b4b03-c885-4c9c-922d-4c2bf7cc2743")
                .setCheckoutPreferenceId(checkoutPreference.getId())
                .startCheckoutActivity();

i'm sure that preference is creating correctly cause if i follow my sandbox_init_point  "sandbox_init_point": "https://sandbox.mercadopago.com/mlv/checkout/pay?pref_id=149007010-e2c7b039-f0c0-4b35-a1bd-eaaa07f9e53d"   i have an page for pay.
I REALLY NEEDS HELP NOW PLEASE :'( :+1:

Hi! Thanks for reporting this issue. There is a problem with our checkout when using test credentials from Venezuela. We're now working to fix it. It should work fine with productive credentials, though.

@mreverter That's right, that's what I did, set up the actual account and everything went well. What happens if the user trying to pay is not registered in mercadoPago? The pay is procesed ?

@tes1oner yes, the payment is processed.

@tes1oner please, try to use a sandbox credential again, it should work now.


Query filter and scoring

This PR will close #398
Description
This MR is the proposed implementation for the Query filter and scoring. Example:
/documents?filter={"query":"lung","limit":50}

The response includes the score for each item.
Example:
[
    {
        "pid": "pid:103115350",
        "isPublic": true,
        "type": "LS",
        "title": "LS-2783",
        "summary": "The study of iron oxide nanoparticles accumulation in the lungs and liver of nude mice with the blocked reticuloendothelial system",
        "doi": "10.15151/ESRF-ES-103115350",
        "startDate": "2018-06-06T08:02:17.829Z",
        "endDate": "2018-06-10T08:00:00.000Z",
        "releaseDate": "2021-06-10T08:00:00.000Z",
        "license": null,
        "keywords": [],
        "datasets": [],
        "members": [],
        "parameters": [],
        "score": 0.6843750000000001
    }]

This is the minimum required for the panosc data portal.
Testing Instructions
In order to test you need an instance of the scoring app up and running with the weights calculated.
You should properly setup the configuration config.yaml by filling the required parameters in the search_api.
Example:
  scoring_enabled: true
  scoring_server: "http://dau-dm-01:9000/score"
  scoring_group: "investigation" #corresponds to the defined group in the scoring app. https://github.com/panosc-eu/panosc-search-scoring/blob/master/docs/md/PaNOSC_Federated_Search_Results_Scoring_API.md#model
  scoring_limit: 1000

Consider double checking the consistency of the identifiers between the scoring app itemId and the pid so they match.

[ ] Review code
[ ] Check GitHub Actions build
[ ] If icatdb Generator Script Consistency Test CI job fails, is this because of a deliberate change made to the script to change generated data (which isn't actually a problem) or is here an underlying issue with the changes made?
[ ] Review changes to test coverage
[ ] Does this change mean a new patch, minor or major version should be made? If so, does one of the commit messages feature fix:, feat: or BREAKING CHANGE: so a release is automatically made via GitHub Actions upon merge?
[ ] {more steps here}

Agile Board Tracking
Connect to #{issue number}

Dear @VKTB
It is all good from my side. Thank you very much!

Thank you too @antolinos!

The failing tests will be fixed by the Fix/remove dataset filesize #403 PR.


A couple of enhancement to Gobblin on Yarn

Moved code that registers with a EventBus instance outside the constructors so to prevent objects to be registered from being exposed too early before exiting the constructors.
Use TaskExecutor.execute instead of submit whenever possible as ExecutorService.submit will not trigger uncaught exception handler if a task throws an unchecked exception.
Other minor code refactoring.

@zliu41 can you review?

LGTM


Fix #356 - parsing of milliseconds

Summary of changes
This fixes issue #356.
The use of ms |> String.trim("0") could result in an empty string when
the input was "000", which in turn made String.to_integer complain.
Since trim removes zeros from both ends of the string, milliseconds
ending in 0 or 00 were incorrectly parsed as well.
This commit changes String.trim to String.trim_leading and adds
a safety-clause to protect against the "000" input.
I tried to keep the changes minimal: I added a failing test to demonstrate the problem and then made it pass. I'm still very new to Elixir so the test is probably much uglier than it could be. I think elem(x, 0) is a smell here, but the second element of the tuple (the required precision) changed in ways I did not quite understand. I'd be happy to update the pull request with any needed changes.
I hope the pull request is acceptable without added typespecs -- still trying to figure those out.
Checklist

[ ] New functions have typespecs, changed functions were updated
[ ] Same for documentation, including moduledocs
[x] Tests were added or updated to cover changes
[x] Commits were squashed into a single coherent commit

Coverage increased (+0.01%) to 67.952% when pulling 5a010d08a9740a733868ac74fd5b26a6c7f86b77 on DataWraith:356-millisecond-parsing into 3852b8eb407a6c5cc7df8709511969330c8e2e8b on bitwalker:master.

Thanks!


Failing to create a cluster

Couldn't create a cluster via your dashboard/ui.
2020/08/29 19:34:34 [INFO] Starting container [rke-etcd-port-listener] on host [<IP_ADDRESS>], try #1
2020/08/29 19:34:40 [WARNING] Can't start Docker container [rke-etcd-port-listener] on host [<IP_ADDRESS>]: Error response from daemon: driver failed programming external connectivity on endpoint rke-etcd-port-listener (9abe2522e18968c076e90d40eb50eb77359a731a9db0941825719c2e2f37d989): Error starting userland proxy:
2020/08/29 19:34:40 [INFO] Starting container [rke-etcd-port-listener] on host [<IP_ADDRESS>], try #2
2020-08-29 19:34:50.785235 W | etcdserver: read-only range request "key:\"/registry/services/endpoints/kube-system/kube-controller-manager\" " with result "range_response_count:1 size:453" took too long (312.938835ms) to execute
2020-08-29 19:35:00.884673 I | mvcc: store.index: compact 10505
2020-08-29 19:35:00.915596 I | mvcc: finished scheduled compaction at 10505 (took 29.546867ms)
2020/08/29 19:35:30 [WARNING] Can't start Docker container [rke-etcd-port-listener] on host [<IP_ADDRESS>]: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
2020/08/29 19:35:30 [INFO] Starting container [rke-etcd-port-listener] on host [<IP_ADDRESS>], try #3
2020/08/29 19:35:47 [INFO] error in remotedialer server [400]: read tcp <IP_ADDRESS>:80-><IP_ADDRESS>:55892: i/o timeout
2020/08/29 19:35:47 [WARNING] Can't start Docker container [rke-etcd-port-listener] on host [<IP_ADDRESS>]: error during connect: Post http://%!F(MISSING)var%!F(MISSING)run%!F(MISSING)docker.sock/v1.24/containers/rke-etcd-port-listener/start: tunnel disconnect
2020/08/29 19:35:47 [ERROR] cluster [c-p6rpv] provisioning: [Failed to start [rke-etcd-port-listener] container on host [<IP_ADDRESS>]: error during connect: Post http://%!F(MISSING)var%!F(MISSING)run%!F(MISSING)docker.sock/v1.24/containers/rke-etcd-port-listener/start: tunnel disconnect]
2020/08/29 19:35:47 [INFO] kontainerdriver rancherkubernetesengine stopped
2020/08/29 19:35:47 [ERROR] ClusterController c-p6rpv [cluster-provisioner-controller] failed with : [Failed to start [rke-etcd-port-listener] container on host [<IP_ADDRESS>]: error during connect: Post http://%!F(MISSING)var%!F(MISSING)run%!F(MISSING)docker.sock/v1.24/containers/rke-etcd-port-listener/start: tunnel disconnect]
2020-08-29 19:36:00.035862 I | http: TLS handshake error from <IP_ADDRESS>:46150: EOF

Here is the log from the node:
https://gist.github.com/denissabramovs/994b4b2a2acbc529c95baacbc0862d39

2020/08/29 19:37:18 [WARNING] Can't start Docker container [rke-worker-port-listener] on host [<IP_ADDRESS>]: Error response from daemon: OCI runtime create failed: container_linux.go:349: starting container process caused "process_linux.go:449: container init caused \"process_linux.go:432: running prestart hook 0 caused \\\"error running hook: exit status 2, stdout: , stderr: fatal error: runtime: out of memory\\\\n\\\\nruntime stack:\\\\nruntime.throw(0x558c1c39394b, 0x16)\\\\n\\\\t/usr/local/go/src/runtime/panic.go:774 +0x74 fp=0x7ffd4a13d388 sp=0x7ffd4a13d358 pc=0x558c1aac7984\\\\nruntime.sysMap(0xc000000000, 0x4000000, 0x558c1e5f1678)\\\\n\\\\t/usr/local/go/src/runtime/mem_linux.go:169 +0xc7 fp=0x7ffd4a13d3c8 sp=0x7ffd4a13d388 pc=0x558c1aab06d7\\\\nruntime.(*mheap).sysAlloc(0x558c1e5d4ec0, 0x2000, 0x0, 0x0)\\\\n\\\\t/usr/local/go/src/runtime/malloc.go:701 +0x1cf fp=0x7ffd4a13d470 sp=0x7ffd4a13d3c8 pc=0x558c1aaa366f\\\\nruntime.(*mheap).grow(0x558c1e5d4ec0, 0x1, 0xffffffff)\\\\n\\\\t/usr/local/go/src/runtime/mheap.go:1255 +0xa5 fp=0x7ffd4a13d4c0 sp=0x7ffd4a13d470 pc=0x558c1aabe875\\\\nruntime.(*mheap).allocSpanLocked(0x558c1e5d4ec0, 0x1, 0x558c1e5f1688, 0x1)\\\\n\\\\t/usr/local/go/src/runtime/mheap.go:1170 +0x268 fp=0x7ffd4a13d540 sp=0x7ffd4a13d4c0 pc=0x558c1aabe708\\\\nruntime.(*mheap).alloc_m(0x558c1e5d4ec0, 0x1, 0x558c1aaf002a, 0x0)\\\\n\\\\t/usr/local/go/src/runtime/mheap.go:1022 +0xc6 fp=0x7ffd4a13d590 sp=0x7ffd4a13d540 pc=0x558c1aabdfa6\\\\nruntime.(*mheap).alloc.func1()\\\\n\\\\t/usr/local/go/src/runtime/mheap.go:1093 +0x4e fp=0x7ffd4a13d5c8 sp=0x7ffd4a13d590 pc=0x558c1aaf3c4e\\\\nruntime.(*mheap).alloc(0x558c1e5d4ec0, 0x1, 0x1002a, 0x40000)\\\\n\\\\t/usr/local/go/src/runtime/mheap.go:1092 +0x8c fp=0x7ffd4a13d618 sp=0x7ffd4a13d5c8 pc=0x558c1aabe28c\\\\nruntime.(*mcentral).grow(0x558c1e5d5cf8, 0x0)\\\\n\\\\t/usr/local/go/src/runtime/mcentral.go:255 +0x7d fp=0x7ffd4a13d658 sp=0x7ffd4a13d618 pc=0x558c1aab00fd\\\\nruntime.(*mcentral).cacheSpan(0x558c1e5d5cf8, 0x7f42f616a000)\\\\n\\\\t/usr/local/go/src/runtime/mcentral.go:106 +0x300 fp=0x7ffd4a13d6b8 sp=0x7ffd4a13d658 pc=0x558c1aaafc20\\\\nruntime.(*mcache).refill(0x7f42f616a008, 0x2a)\\\\n\\\\t/usr/local/go/src/runtime/mcache.go:138 +0x87 fp=0x7ffd4a13d6d8 sp=0x7ffd4a13d6b8 pc=0x558c1aaaf6b7\\\\nruntime.(*mcache).nextFree(0x7f42f616a008, 0x558c1e5f162a, 0x7f42f616a008, 0x8, 0xfffffffffffffff8)\\\\n\\\\t/usr/local/go/src/runtime/malloc.go:854 +0x89 fp=0x7ffd4a13d710 sp=0x7ffd4a13d6d8 pc=0x558c1aaa3e99\\\\nruntime.mallocgc(0x180, 0x558c1d39f980, 0x1, 0x558c1e5f16e0)\\\\n\\\\t/usr/local/go/src/runtime/malloc.go:1022 +0x7a5 fp=0x7ffd4a13d7b0 sp=0x7ffd4a13d710 pc=0x558c1aaa47e5\\\\nruntime.newobject(0x558c1d39f980, 0x4000)\\\\n\\\\t/usr/local/go/src/runtime/malloc.go:1151 +0x3a fp=0x7ffd4a13d7e0 sp=0x7ffd4a13d7b0 pc=0x558c1aaa4bea\\\\nruntime.malg(0x25300008000, 0x558c1e5d7568)\\\\n\\\\t/usr/local/go/src/runtime/proc.go:3232 +0x33 fp=0x7ffd4a13d820 sp=0x7ffd4a13d7e0 pc=0x558c1aad0e53\\\\nruntime.mpreinit(...)\\\\n\\\\t/usr/local/go/src/runtime/os_linux.go:324\\\\nruntime.mcommoninit(0x558c1e5cf980)\\\\n\\\\t/usr/local/go/src/runtime/proc.go:626 +0xc6 fp=0x7ffd4a13d858 sp=0x7ffd4a13d820 pc=0x558c1aaca786\\\\nruntime.schedinit()\\\\n\\\\t/usr/local/go/src/runtime/proc.go:543 +0x76 fp=0x7ffd4a13d8b0 sp=0x7ffd4a13d858 pc=0x558c1aaca3e6\\\\nruntime.rt0_go(0x7ffd4a13d9b8, 0x4, 0x7ffd4a13d9b8, 0x0, 0x7f42f5066b97, 0x65, 0x7ffd4a13d9b8, 0x44a13d9e0, 0x558c1aaf6010, 0x0, ...)\\\\n\\\\t/usr/local/go/src/runtime/asm_amd64.s:214 +0x129 fp=0x7ffd4a13d8b8 sp=0x7ffd4a13d8b0 pc=0x558c1aaf6149\\\\n\\\"\"": unknown

oh it is out of memory

ok it's resolved by deploying on nodes with more memory


Update visualization script

Fyi @lufre1 : this contains some updates to the visualizations script to load arbitrary many segmentations together and to efficiently load center crops of the data so that it can be loaded on a laptop with limited RAM.


Where is the ibm-gantt-chart.js file?

Sorry about the question but I'm not able to find it.
Thansk!

Hello,
the distribution files are not committed in github.
You should npm install ibm-gantt-chart to get the ibm-gantt-chart.js file.
Or you can transpile the GitHub version with:
yarn install
yarn build

and then look into packages/ibm-gantt-chart/dist


development fixes for PR #1233 to master

Cherry picks commit that was applied to master to apply it to development due to emergency.

🎖 🏅 🥇 !!!!!!!!


Avoid slicing the whole Jacobian if batch size does not divide total size

Codecov Report
Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 7.18%. Comparing base (973676a) to head (edf9b2c).

Files with missing lines
Patch %
Lines

...fferentiationInterface/src/first_order/jacobian.jl
0.00%
8 Missing :warning:

...fferentiationInterface/src/second_order/hessian.jl
0.00%
4 Missing :warning:

:exclamation:  There is a different number of reports uploaded between BASE (973676a) and HEAD (edf9b2c). Click for more details.
HEAD has 99 uploads less than BASE

Flag
BASE (973676a)
HEAD (edf9b2c)

DIT
20
0

DI
80
1

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #535       +/-   ##
==========================================
- Coverage   98.64%   7.18%   -91.46%
==========================================
  Files         106      71       -35
  Lines        4572    2964     -1608
==========================================
- Hits         4510     213     -4297
- Misses         62    2751     +2689

Flag
Coverage Δ

DI
7.18% <0.00%> (-91.60%)
:arrow_down:

DIT
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.