Capture spheres tame or enslave

If successful, and the captured thing is a trainable animal, make it tame and trained. E.g. fight a Thrumbo to low enough health that you can capture it, and you get a trained one to use for fights.
And if you do it to a humanoid, it becomes a slave, Palworld style

Right now it captures humanlikes as prisoners, iirc, it's a one-liner to change to slave. Should that be switched? Made a setting?
I believe it adds animals to the faction, but doesn't tame them. Should be easy enough.

What about a gizmo on the equipment when it’s unfilled?
On Sat, 13 Jul 2024 at 11:07, Kieran Evans @.***> wrote:

Right now it captures humanlikes as prisoners, iirc, it's a one-liner to
change to slave. Should that be switched? Made a setting?
I believe it adds animals to the faction, but doesn't tame them. Should
be easy enough.
—
Reply to this email directly, view it on GitHub
https://github.com/feldoh/PawnStorages/issues/40#issuecomment-2226844407,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA3LY25JPL3CQ6UOLRXTUSTZMD34LAVCNFSM6AAAAABJXXCWY6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRWHA2DINBQG4
.
You are receiving this because you authored the thread.Message ID:
@.***>


Move config files to rc file

I pulled my dotfiles out of this repo so that people can clone it without getting conflicts once they update their dotfiles, but you still have to update the config files to install the things you want, which defeats the purpose of the split.
It would be better if you had an rc file that sets these values, and it also not be a part of the repo.

https://github.com/evanthegrayt/cli-env-manager/pull/3


Small but impactfull changes

[ ] implement alpha keyword https://github.com/JuliaPlots/Makie.jl/issues/84
[ ] go through all kind of plotting commands and make sure they throw sensible errors for wrong arguments
[ ] Figure out float32 issues (don't convert to float32 in conversions.jl, and then, when converting to it in the backend, make sure number ranges are preserved)
[ ] make attributes discoverable (overload Base.propertynames)
[x] fix printing for all types
[x] make sure recipes don't index into empty vectors (https://github.com/JuliaPlots/AbstractPlotting.jl/issues/296)
[x] move all issues to Makie.jl, make it impossible to open an issue on AbstractPlotting, GLMakie, CairoMakie, WGLMakie.  Use tags etc for different libraries!
[x] clean up makiegallery examples (lots of repeating/ unhelpful examples)
[ ] try running rendering in another thread (needs to create opengl context in another thread)
[ ]  go through coverage report and add examples for missing coverage, remove unused code

Should be covered in new 1.0 roadmap


⚠ ClamAV has degraded performance

In c13c3bf, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 223 ms

Resolved: ClamAV performance has improved in f2f9ba2.


Update Custom Widgets Lambda runtime from nodejs12.x to nodejs16x

Issue #, if available:

nodejs12.x will be deprecated on Mar 31, 2023.

Description of changes:

Update Custom Widgets Lambda runtime from nodejs12.x to nodejs16x

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Awesome! Thanks! 🚀


fix: ignore patch version when comparing Rust versions

Implemented change to set TOOLCHAIN_VERSION by extracting only the major and minor version from the specified Rust version in rust-toolchain.toml.

This should fix https://github.com/lurk-lab/arecibo/issues/274

Closing in favor of #31


Meshes turn black when adding a Material to them

Godot version
4.0 alpha 2 official
System information
MacOS 12.2 Monterey, Vulkan API 1.1.198, Apple M1
Issue description
When I add a Material to a MeshInstance3D in my game, it turns pitch black even when I add lighting. Also, my hdri image doesn't show up in the editor even though I've set the default environment to be my environment with my hdri
Example:
Before:

After adding a StandardMaterial3D to the floor mesh instance:

Steps to reproduce
Create a new scene with two MeshInstance3Ds, set one or both of the objects Materials to a StandardMaterial3D and take a look at the editor
Minimal reproduction project
Minimal reproduction.zip

Found out this is a duplicate of https://github.com/godotengine/godot/issues/51898


Dint 910 & DINT 911 - Round prices for productListItems for AEP events

Description

Related Issue

https://jira.corp.adobe.com/browse/DINT-910
Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

I'm curious with these fixes, when the default currency is set to EUR, is the issue with the actual formatting, or is there a discrepency between using , and . as currency seperators.

I'm curious with these fixes, when the default currency is set to EUR, is the issue with the actual formatting, or is there a discrepency between using , and . as currency seperators.

The problem is doing float math causing floating precision errors.  Also, magento core stores numbers to 4 decimals, but we are being required to have just the two decimal places.


Error: Workflow failed! Uploading SARIF report to GitHub Advanced Security failed: Error: Cookies must be enabled to use GitHub.

I am using<EMAIL_ADDRESS>with the following config
blackduck_url: ${{ secrets.BLACKDUCK_URL }}
blackduck_token: ${{ secrets.BLACKDUCK_TOKEN }}
blackduck_scan_full: false
blackduck_scan_failure_severities: 'BLOCKER,CRITICAL'
blackduck_args: '--detect.diagnostic=true --detect.output.path=blackduck-reports'
github_token: ${{ secrets.GITHUB_TOKEN }}
blackduck_prComment_enabled: true
blackduck_reports_sarif_create: true
blackduck_upload_sarif_report: true
and i can not see the result directly in github - I get the error mentioned in the title.
If I use<EMAIL_ADDRESS>github action with the same github token, it works fine so I think it has the permission that i need. Can someone please help me?

Issue is most likely the following line:
https://github.com/synopsys-sig/synopsys-action/blob/76d326a25fdfe087271dff16eaf79b7b10396f72/src/synopsys-action/service/impl/github-client-service-base.ts#L27
    this.githubServerUrl = process.env[constants.GITHUB_ENVIRONMENT_VARIABLES.**GITHUB_SERVER_URL**] || ''
    this.githubApiURL = this.githubServerUrl === constants.GITHUB_CLOUD_URL ? constants.GITHUB_CLOUD_API_URL : **this.githubServerUrl**

As far as I understand this for on premise installations of github you have to use GITHUB_API_URL for the API URL and NOT the server-url.


Not sure if this info is needed, but here anyway.
tested browser with this output:
Opera version 	45.0.2552.812
Firefox 53.0.3
used OS:
Windows 7 32-bit

Setting z-index to a high number (10 works for me) on the mascot seems to fix it, although I don't know why this happens. @kipukun?

Hey everyone! Currently, the HTML and CSS is being completely rewritten, so this issue won't happen in the next release, I promise! <3

to be fixed in #658


Add errors parameter to open function

Add errors parameter to open function, which is passed to TextIOWrapper. this will help handle cases of decode errors in utf-8 etc..

This is fine, but could do with a test.
Once more, though, I should point out that this functionality is slated to move to fsspec, so I would appreciate your opinion on whether its open does the right thing for text, from your point of view.

It seems like moto has updated it version ID strategy. The following should fix the failing test
--- a/s3fs/tests/test_s3fs.py
+++ b/s3fs/tests/test_s3fs.py
@@ -1095,11 +1095,11 @@ def test_versions(s3):
     assert len(versions) == 2

     with s3.open(versioned_file) as fo:
-        assert fo.version_id == '1'
+        assert fo.version_id == versions[1]
         assert fo.read() == b'2'

-    with s3.open(versioned_file, version_id='0') as fo:
-        assert fo.version_id == '0'
+    with s3.open(versioned_file, version_id=versions[0]) as fo:
+        assert fo.version_id == versions[0]
         assert fo.read() == b'1'

Ping - are you intending to finish off this PR, @akaguy ?

Implemented in fsspec


added some entries to the Search Bar documentation regarding props

specifically for placeholder, placeholderTextColor and onChangeText

@temitope Thanks for the PR. 👍


TypeError: Illegal kind "string" for plugin ""

Getting the title'd error why trying to run styleguidist.
I'm not sure what's going on.  I tried to troubleshoot myself, but was unsuccessful.
><EMAIL_ADDRESS>styleguide-server /PROJECT
> styleguidist server

Listening at http://localhost:3000

webpack built 25ce954cda50e939fb85 in 823ms
Hash: 25ce954cda50e939fb85
Version: webpack 1.12.2
Time: 823ms
          Asset     Size  Chunks       Chunk Names
build/bundle.js  45.1 kB       0       main
chunk    {0} build/bundle.js (main) 7.69 kB [rendered]
    [0] multi main 40 bytes {0} [built] [1 error]
    [1] (webpack)-hot-middleware/client.js 3.27 kB {0} [built]
    [2] (webpack)/buildin/module.js 251 bytes {0} [built]
    [3] (webpack)-hot-middleware/~/strip-ansi/index.js 161 bytes {0} [built]
    [4] (webpack)-hot-middleware/~/strip-ansi/~/ansi-regex/index.js 145 bytes {0} [built]
    [5] (webpack)-hot-middleware/client-overlay.js 883 bytes {0} [built]
    [6] (webpack)-hot-middleware/process-update.js 2.93 kB {0} [built]

ERROR in ./~/react-styleguidist/src/index.js
Module build failed: TypeError: Illegal kind "string" for plugin ""
    at PluginManager.add (/PROJECT/node_modules/react-styleguidist/node_modules/babel-core/lib/transformation/file/plugin-manager.js:196:13)
    at File.buildTransformers (/PROJECT/node_modules/react-styleguidist/node_modules/babel-core/lib/transformation/file/index.js:237:21)
    at new File (/PROJECT/node_modules/react-styleguidist/node_modules/babel-core/lib/transformation/file/index.js:139:10)
    at Pipeline.transform (/PROJECT/node_modules/react-styleguidist/node_modules/babel-core/lib/transformation/pipeline.js:164:16)
    at transpile (/PROJECT/node_modules/react-styleguidist/node_modules/babel-loader/index.js:12:22)
    at Object.module.exports (/PROJECT/node_modules/react-styleguidist/node_modules/babel-loader/index.js:71:12)
 @ multi main

same issue here

I just upgraded from 1.2.1 to 1.3.0 and can reproduce the problem.

The bug is in https://github.com/sapegin/react-styleguidist/blob/c3b030083c9a0cb4f911d32d27e65184ba2b6d5a/src/make-webpack-config.js#L153 - reactTransformPath is "".

And this is probably because process.cwd() is not the folder of react-styleguidist, but the folder of the project that is using it. getInstalledPath expects the library to be installed in ${process.cwd()}/node_modules/babel-plugin-react-transform and this is not true with npm 2.x.
@sapegin could you fix it?

@sapegin we could use require.resolve(...) instead of get-installed-path.

@mik01aj Thanks for the investigation, I’ll try it soon.

@sapegin will you fix it or shall I try? This issue hits anyone using npm 2.x (so, most of devs imho)

It’d be cool if you try.

Turns out I can't today, sorry. Maybe tomorrow... :(

@sapegin, please have a look at the PR :)

@Pink401k and @zachkadish, we fixed this, please check if 1.3.1 works for you.

I'm getting it on a fresh install;

That seems to have done it! Thank you.


Create k

Resolves
What Github issue does this resolve (please include link)?
Proposed Changes
Describe what this Pull Request does
Reason for Changes
Explain why these changes should be made
Test Coverage
Please show how you have added tests to cover your changes

k!


grid load inside layout

I'm submitting a ...
[* ] bug report
[ ] feature request
[ ] question about the decisions made in the repository

hi i am trying to load a grid inside a panel of a layout.
It works fine, but I notice that the grid calls the server more than 1 time
I am using version 1.4

What is the current behavior?

If the current behavior is a bug, please provide the steps to reproduce and if possible a screenshots.

What is the expected behavior?

What is the motivation / use case for changing the behavior?

Link to jsFiddle that demonstrates the problem:

Other information

very likely related to #1883 where I reported a similar issue and my grid is also inside a layout.

I explained in #1883 why it might be happening. I would recommend trying to figure out why it calls reload twice. Put a debugger in onLoad event and see call stack who calls it. It should shed some light.


Passing data to Crawler callback when queuing URL

Alot of times passing local data associated with the url being queued to the callback is required. This for me is useful in building a relationship tree across gathered scraps or micro objects thrown in couchdb with nano, which I then combine into bigger objects later. Passing jquery gathered data while queing the URL lets me store attributes such as the kind of link or surrounding taxonomy hints which in some cases cannot be gathered locally from the pages markup depending on the flow of the website being crawled, if such information cannot be extracted from the page it self. I suggest having data passed to the callback while queuing it. Currently I append my data as a GET query string to the URL being queued and then parse request.uri back in the call back to get the passed data, even though this gets the job done, it is intrusive, the server admins can see what we are cooking, and overall not elegant.

Pls add this into Docs ... it's very useful :+1: :)

It has been added in the Docs.  And here is the usage:
var Crawler = require("crawler").Crawler;

var c = new Crawler({
    "maxConnections":10,
    "callback":function(error,result,$,done) {
        console.log(result.options.foo);
        done();
    }
});

// pass variable from here
c.queue({
    uri: "http://joshfire.com",
    foo: 'bar',
    cool: 'raoul'
});


Where can i find the comments that where downloaded?

Whenever i try to download comments it only downloads the pictures and captions of each post. I am not sure where and how the comments would be saved in case it worked. Hope somebody can help.

Whenever i try to download comments it only downloads the pictures and captions of each post. I am not sure where and how the comments would be saved in case it worked. Hope somebody can help.

Comments are saved in a separate JSON files of each post
File name is something like this 2020-08-17_21-13-06_UTC_comments.json
But if you have specified extra parameters like --no-metadata-json you might not see the comments file

Whenever i try to download comments it only downloads the pictures and captions of each post. I am not sure where and how the comments would be saved in case it worked. Hope somebody can help.

Comments are saved in a separate JSON files of each post
File name is something like this 2020-08-17_21-13-06_UTC_comments.json
But if you have specified extra parameters like --no-metadata-json you might not see the comments file


[WIP] Implement Router outlet pattern for getx

This PR simplifies nested navigation by making it a single navigator with a single navigation stack, and instead rendering the ui differently based on the current route.
I am still studying the best approach for this, but the general concept is to add a RouterOutlet widget as a place holder for the nested navigator, that would then listen to the router delegate and react to it to display different ui elements.
Some challenges are:

[x] Decoupling the logical routes from the visual routes

The most important challenge, basically how to navigate to a new page without the navigator taking over
How this was done is very straight forward, we filter what pages we pass to the Navigator inside the router delegate's build method

List<GetPage> getVisiblePages() {
  return routes.where((r) {
    final mware =
        (r.middlewares ?? []).whereType<RouterOutletContainerMiddleWare>();
    if (mware.length == 0) return true;
    return r.name == mware.first.stayAt;
  }).toList();
}

[x] Make Get's routing system work without the navigator (make it based on logical routes instead of visual routes)

Currently, Get relies too much on the Navigator and the events defined in GetPageRoute, but in order to make this new approach complete, we need to change how the bindings and middleware work.
This was done by mapping each GetPage to its related GetPageRoute in the router delegate and using the methods defined in GetPageRoute to emulate the old behavior.

[ ] adapt the old navigation api defined in getx (e.g. Get.toNamed, Get.to, Get.back,...) to the new routing api.

Amazing job.
Let me know if you need something

May I know if this based on Navigator 2.0?

@jonataslaw thanks for your great work on this library and simplifying our work flow 😄

yes, this is based on the navigator 2.0 api to make it compatible with the web and the other new features
currently this is what the example_nav2 can do:

currently there are some conflicts between the way getx handles navigation based on the old api and the new router delegate api.
e.g. the way bindings/parameters/arguments work

This is going to be really useful. Thanks a lot, looking forward for the merging 🚀

I managed to improve how the routing works  and now it's -almost- identical to how Getx works now.
I still don't know how to emulate the transitions between routes in a RouterOutlet, since navigator used to handle that automatically (and I am not an expert with animations), so if someone can help that would be great

Example src code: https://github.com/Bdaya-Dev/getx/tree/router-outlet/example_nav2

I think that should be necessary to update also the whole section in the README about the routing @ahmednfwela, do you need any help?

That would be great, but I am still not sure how to adapt the old api

Old API has a single navigation stack and you append to it if you want to move to a new route
e.g. going from route A to B :
/A => /A/B
New API has 2 navigation stacks (browser history + route identifier)
e.g.  going from route A to B :
/A => /B

Do we make Getx use the new api ALWAYS ? or only if the user opts in to the new Navigator API (by setting the router delegate) ?

That would be great, but I am still not sure how to adapt the old api

Me neither unfortunately

Do we make Getx use the new api ALWAYS ? or only if the user opts in to the new Navigator API (by setting the router delegate) ?

I think that Getx should use the new API always, and for this reason I think that this PR could be a major release. Flutter is now officially stable on the web too so the new standard should provide a nice way to handle routing, and this navigator update can fix the gap.

Anyway I think that we should wait an answer from @jonataslaw and see how to move but meanwhile amazing job @ahmednfwela 🎉

When I created GetNav (now replaced by this fantastic PR), my goal was to replace the current API, as it is more consistent with the navigation history and allows mock navigation.
IMO, we could migrate the current api, having a delegate by default in GetMaterialApp, and making the navigation extension methods call that delegate.
Challenges: maintain compatibility with the current api, and with packages that use GetX, such as https://pub.dev/packages/stacked_services
Or do a major release.
However, I planned to turn GetPage into a page where it could be extended, and declare the controllers, routes, guards, etc. for Getx5 on it, so I'm not sure if we can go up now, otherwise we will have to do another major release when this is ready.
IDK, that decision is up to the community.
And I would like to thank you @ahmednfwela  for the effort in making this PR, I will give you a prominent place in the changelog

maybe we can publish this as a non-breaking change, by checking if the user provided a RouterDelegate or not, then in GetX5 we can revamp the entire api and cleanup any leftovers

Okay, I'm going to merge this now and try to do an update as soon as possible.
Thank you very much for this contribution

@ahmednfwela ,
Hi, I wish to know how to implement the login and auto login with this great PR.
Could you please add this into your example?
Thanks!

@jasonlaw sure, I will try to add it soon

I checked and RouteOutlet didn't have its own navigator, that was why transitions weren't working.
I think our challenge now is to create a default delegate, and call it from Get.to/Get.toNamed etc, and mainly manage that with child routes.
In the current api we use an "id" identifier to navigate nested routes. Ex:
Get.toNamed(Routes.Product, id:'foo');
I think we could create a Names:Delegates Map to do something similar with the new api. Just to remove the amount of code within the build, to be something more objective.
Ahmed, do you have any contacts?


Support unique URLs for examples

From Qianwen:

Is it possible to get individual url for each example, something like https://sehilyi.github.io/geminid/examples?marks=bar, so that it will be easy to link the example in the doc

example url


Address flake8 warnings

Issue is #73.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

45 of 95 (47.37%)  changed or added relevant lines in 8 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.1%) to 21.241%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

fabrictestbed_extensions/fablib/component.py
3
4
75.0%

fabrictestbed_extensions/fablib/facility_port.py
4
5
80.0%

fabrictestbed_extensions/fablib/resources.py
4
5
80.0%

fabrictestbed_extensions/fablib/interface.py
3
7
42.86%

fabrictestbed_extensions/fablib/network_service.py
5
9
55.56%

fabrictestbed_extensions/fablib/slice.py
9
18
50.0%

fabrictestbed_extensions/fablib/fablib.py
7
17
41.18%

fabrictestbed_extensions/fablib/node.py
10
30
33.33%

Files with Coverage Reduction
New Missed Lines
%

fabrictestbed_extensions/fablib/node.py
1
9.8%

fabrictestbed_extensions/fablib/slice.py
1
9.79%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
724

Relevant Lines:
3112

💛  - Coveralls

Abandoning because this branch is too old and too stale. Also ruff is probably better than flake8, so I'll take a stab in that direction.


Can't use k8tz in a pod in the same same namespace of k8tz

Hi Team k8tz,
Very good job about k8tz ! I have a feature request about k8tz.
In our project we are deploying all our admin applications in a particular namespace, so we want to use k8tz in the pods in that namespace.
However, it is currently impossible to use k8tz on a pod in the same namespace.
In fact, by default, the k8tz namespace is automatically set in the namspaces to be ignored at webhook level.
https://github.com/k8tz/k8tz/blob/24478ff1d987b8645f785385f1d2958085d73bd5/charts/k8tz/templates/_helpers.tpl#L149-L158
I think it would be a good idea to add an option in helm values to specify whether or not to ignore pods in k8tz namespace.
Thank you,

Hi @gregoirearnoult,
To avoid a chicken and egg situation, k8tz must ensure that Kubernetes does not need the k8tz Admission Controller to create the k8tz Admission Controller pod. In such a situation the cluster will be stuck and will not be able to create more Pods.
The way to deal with that is to exclude k8tz from the Admission Controller Webhook, which can only be done at the namespace level. Therefore there is no choice but to distribute k8tz in its own namespace. You can choose an existing namespace or change the default namespace name, but either way - k8tz will not be able to process Pods created in its namespace.
You can read about it in the Namespacing section in the helm chart readme.


"ENOENT: no such file or directory, open '/Users/distiller/stardust-app/node_modules/react-native-fabric-twitterkit/android/Android.iml'".

On our CI, when we do yarn install (includes this package at "^0.1.2"), we get this error:
 "ENOENT: no such file or directory, open '/Users/distiller/stardust-app/node_modules/react-native-fabric-twitterkit/android/Android.iml'".

And indeed, here's what I see in the node_modules folder for this package:
distiller-build-57:react-native-fabric-twitterkit distiller$ pwd
/Users/distiller/stardust-app/node_modules/react-native-fabric-twitterkit
distiller-build-57:react-native-fabric-twitterkit distiller$ ls
FabricTwitterKit			LICENSE					Twitter.js				package.json
FabricTwitterKit.xcodeproj		README.md				index.js				react-native-fabric-twitterkit.podspec

Also confusing: The package.json in this library says 0.1.1, but the latest on NPM is 0.1.2, what's correct?

Must be an intermittent thing, stopped happening for me. Or maybe there was an NPM update.


(PUP-5609) Protect shared state with filesystem lock

Use a filesytem lock when running Puppet apply. This prevents multiple
simultaneous writes to the same state files by multiple apply processes
or a mix of apply and agent processes (the same state files are shared
by apply and agent).
This time it exits with status 1 if lock is already taken and has some tests for that from @MikaelSmith (from https://github.com/puppetlabs/puppet/pull/4582).

I'm still not sure why tests/resource/service/puppet_mcollective_service_management.rb fails. That needs some more investigation.

The acceptance test appears to run into a lag between unlinking the lockfile and exiting puppet, and when the file is released. I have to introduce a slight lag (200-300ms) between puppet apply runs. I want to investigate whether puppet agent has the same problem. This is irritating, but may not be an issue in practice.

My feeling is that it would be better to hold off merging until we also introduce a wait on the lockfile, and should default it to 0.5s.

https://github.com/puppetlabs/puppet/blob/master/acceptance/tests/agent/agent_disable_lockfile.rb covers acceptance testing the agent lockfile. It doesn't appear to test that you can do back-to-back runs.

@parisiale did you run into anything like this running on pxp-agent? Maybe testing service stop/start?

Blocked on sprint triage.

@MikaelSmith what do you think next steps are on this one?

Investigate if there's something broken in the lock implementation (PUP-3914 comes up as a possible issue). I also left next steps at https://github.com/puppetlabs/puppet/pull/4584#issuecomment-173342757.

A thought, what happens when you debug using apply, and quit in the middle. Does that clean up and release the lock?

It's supposed to be cleaned up on the next run, when Puppet detects the old process is no longer running.

CLA signed by all contributors.

Rebased this against master branch

This appears to pass acceptance tests for me, now.


Pass options to serverMiddleware

What problem does this feature solve?
Configuring a "generic" serverMiddleware is nearly impossible at the moment because an array of relative paths is the only way to pass them to nuxt.
(See the code reference)
What does the proposed changes look like?
It'd be great to do it similar to the modules system by allowing array with option objects:
(Modules example)
modules: [
    '@nuxtjs/pwa',
    ['@nuxtjs/axios', { baseURL: 'xxx' }]
  ]

This feature request is available on Nuxt.js community (#c6924)

Hi @manniL
Thanks for this feature request. Actually, what would be the use case to have a generic middleware?

Hey @Atinux
for example, the redirect-ssl middleware (which is also mentioned in the docs). Using it is currently possible by simply including the reference:
module.exports = {
  serverMiddleware: [
      'redirect-ssl'
  ]
}

But in case I want to configure it as done here, there is no way I'm aware of at the moment.

Actually what you can do is this to give options:
const redirectSSL = require('redirect-ssl')

module.exports = {
  serverMiddleware: [
    redirectSSL.create({ redirectPort: 8443 }))
  ]
}

The point is that you can use any connect middleware with Nuxt.js (not express), but most of them will not handle the options like Nuxt.js does :/

Ah, great! This should work as well. Thank you :relaxed:
You are completely right, otherwise we would limit users to a small range of middlewares.

I will close it, thank you for your help on Nuxt.js, I really appreciate it!

Thank you!
I'm happy I can contribute to this great project :pray: :heart:


URL Targeting debugging within Visual Editor

Problem: Users don’t know if URL targets are working when they make edits in the Visual Editor. Only when loading the SDK and experiment do they find out, and it’s hard to debug.
Proposed solution: Add an indicator to the Visual Editor that displays whether or not the URL targeting rules for a given experiment are targeting the current page being edited.
Steps to implement

Ensure the visual editor can load URL targeting rules of an experiment. (Needs to happen in fetchVisualChangeset in src/background.ts ) Might already be included in payload from API but if not, we need to make changes to GB backend to include them.
Leverage GrowthBook JS SDK util isURLTargeted to determine if any of the URLs target the current loaded page URL. (If the GB JS SDK is not installed it is OK to add as a dependency to Visual Editor)
Render UI in the Visual Editor that is minimal but effective in alerting the user when no URL targets target the currently loaded page URL

Addressed in https://github.com/growthbook/devtools/pull/45


Add working links in Robat

You can paste a link in wit.ai, but it doesn't link to a website, it stays plain text. It would be better to be able to link it like this: klik hier

Maybe a bit of a hack but it might work. Just came across this idea:
The message you receive from wit.ai is just a basic string right? Maybe you can add the <a href="#" HTML tags in the story in wit.ai and when the renderMessage function is called it might work? ¯\_(ツ)_/¯

Just checked in wit.ai and you already tried it!

It has works. right?

🎉


Upgrade ubuntu to 18.04

Hi,
Plans to upgrade base ubuntu image to 18.04 from 16.04.

ah yeah for sure, got similar request for alpine, it's the same approach with #121
see the actual merge request on #123 .
Now it looks like the latest of ffmpeg itself is breaking the build so I need to fix that first. But if you feel to take on the actual change to upgrade the ubuntu base, I'll gladly merge it.

Tried to update base image to 18.04 but image build was breaking.
Can't figure out the cause.

push your changes to a branch and make a merge request so travis will tell us what is the cause.
But yeah some versions seems to be broken at the moment.

/close


release(app): v3.4.0+30400

Checklist:

[ ] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)

Closes #XXXXX

Hey guys,
Such a quick transition from 3.3.0 to 3.4.0 release


Ask users for Reviews on iOS

As Digitalfabrik I want to ask users about a review: https://pub.dev/packages/app_review
Acceptance Criteria:

[ ] Ask users once for a review after using the app for 1 week

Do we really want this and why do we only want this for iOS?

Needs discussion on whether we want this or not. Maybe clarify with stakeholders.

Lets just close this :D Its below low priority :D


[Event request] COD1002 Job Create-Invoice, OnBeforeTestTransferred

Can OnBeforeTestTransferred please be added.
Place to be added:
LOCAL PROCEDURE TestTransferred@3(JobPlanningLine@1000 : Record 1003);
VAR
  IsHandled@1100366000 : Boolean;
BEGIN
  //<< DC
  OnBeforeTestTransferred(JobPlanningLine, IsHandled, SalesHeader2);
  IF IsHandled THEN
	EXIT;
  //>> DC

Publisher:
[Integration(DEFAULT,TRUE)]
PROCEDURE OnBeforeTestTransferred@1100366000(VAR JobPlanningLine@1100366000 : Record 1003;VAR IsHandled@1100366001 : Boolean;VAR SalesHeader2@1100366002 : Record 36);
BEGIN
END;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


bug report

Mac OSX 10.11
$ wget https://github.com/ekalinin/github-markdown-toc.go/releases/download/0.4.0/gh-md-toc.linux.amd64.tgz
$ tar xzvf gh-md-toc.linux.amd64.tgz
x gh-md-toc
$ ./gh-md-toc --version
-bash: ./gh-md-toc: cannot execute binary file

I found that I should use mac version. Thanks!

No problem :)


fix kubernetes version in kubeadm

Will move hardcoded version to better place in later pull request

Now it is probably failing due to this bug in kubernetes/kubeadm 1.6 https://github.com/kubernetes/kubernetes/issues/43815
A quick fix for KubeNow until they fix 1.6 version and we test 1.6 version in our setting is to merge branch with only fixed kubernetes flag in bootstram/master.sh

Closing in favour of #138


Disable Dark Theme

Hi,
I was looking through the documentation, but didn't notice an option in the configuration to disable the dark theme. Is this possible?

I've disabled it by default again, until we've released a better way of theme management. For now, we're back to only one, default light theme.


server crash, when user don`t have griefprevention.admin and use //set in region

GP645
SF3341
crash log
https://drive.google.com/open?id=1D68NE0b6CtqM_KIzwmkd1lE6ktv_hIPK
gamelog
https://drive.google.com/open?id=1A9AqHjV3Wvb0zybR1O1u_tkksFJrUtH2

2146 sting in gamelog.
In the radius of the team was privat, and the person did not have the right to access private.

Reproduce it on a clean server and list steps as I requested.

Closing as I still cannot reproduce this.


Normalise all code blocks in the docs

All .. code:: instances have been changed to use .. code-block::, and have been properly formatted. The syntax names have been normalised, so all django templates use the html+django syntax, shell commands use bash, and plain text uses text.

oh snap, you beat me to it, I was just about to submit a PR :)

Merged in: bc6b5a8a6c1d7c12683607d9169e4e6caf8c2661


Fix crash when expect_corrections runs into an infinite loop

The message for InfiniteCorrectionLoop was changed in #8701, but it now crashes if expect_corrections in a spec causes an infinite loop:
Failure/Error:
  root_cause = offenses_by_iteration[loop_start..-1]
               .map { |x| x.map(&:cop_name).uniq.join(', ') }
               .join(' -> ')

NoMethodError:
  undefined method `map' for nil:NilClass
# ./lib/rubocop/runner.rb:18:in `initialize'
# ./lib/rubocop/rspec/expect_offense.rb:160:in `new'
# ./lib/rubocop/rspec/expect_offense.rb:160:in `block in expect_correction'
# ./lib/rubocop/rspec/expect_offense.rb:150:in `loop'
# ./lib/rubocop/rspec/expect_offense.rb:150:in `expect_correction'

This fixes that crash by capturing the offenses in expect_offenses and passing them into RuboCop::Runner::InfiniteCorrectionLoop.new.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[ ] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Thanks!


GTK to raise error if image path is not valid

If the image path is invalid, gtk backend raises a value error instead of crashing the app.

Fixes #529
PR Checklist:

[ ] All new features have been tested
[ ] All new features have been documented
[x] I have read the CONTRIBUTING.md file
[x] I will abide by the code of conduct

It looks like the gtk test is failing due to an extra paren causing a syntax error.


What does flex actually do?

In CSS, flex is just a shorthand for flex-grow, flex-shrink, and flex-basis. Since none of these properties exist in React Native, what does the flex property actually mean?

See the spec for flex: https://developer.mozilla.org/en-US/docs/Web/CSS/flex
If you have only one value, it means flex-grow:
/* One value, unitless number: flex-grow */
flex: 2;

Thanks! Are there plans to adopt flex-shrink or flex-basis at any point or were they deemed unnecessary?

The general thoughts when supporting a new feature in the project is that by default we don't, but if there are common use cases where this would be useful, then we should consider it. We don't want to support every css property in the world, but don't want to leave out useful ones either :)
I haven't heard many people saying that flex-basis and flex-shrink would be useful in the context of a react native app though.

Fair. Just curious. Thanks again @vjeux!


Don't allow boolean values in math contexts

After discussion on how best to fix an editor crash related to constant
expression simplification it was decided to just not allow boolean
values in mathematical contexts. This means that from now on we  @nocore/variant_op.cpp
longer allow things like bool - bool, bool / bool etc. to be valid
GDScript.
This fixes #11291
It seems clang-format chokes on this file a bit, I'll make another PR to fix that.

I miss this hack :(
var right = Input.is_action_pressed("ui_right")
var left = Input.is_action_pressed("ui_left")
var x_speed = (right - left) * speed

Yeah, sad to see this go. I don't consider it a hack - many languages allow for this.

Just use int(right) - int(left), it at least let's you know that something numeric is going on.
bool - bool just makes no sense, if you want it to be a signed integer subtraction then use ints and not bools.

I'm working on a different PR that makes more changes to variant_op and includes this fix.


⚠ Bofrost.lu has degraded performance

In 814685c, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2330 ms

Resolved: Bofrost.lu performance has improved in 487fb49 after 33 minutes.


cleos set contract error message & usage info not update?

If you point cleos to a wrong path which beginner does a lot, you will get error messages which does not hint the correct path for them and sometimes confusing.
For example, if you have a folder at path:
/Users/dixia/code/onboarding/inline_action/addressbook
and use the following command:
cleos set contract addressbook ./addressbook addressbook.wasm addressbook.abi
Error 3160009: No wast file found
Error Details:
no wasm file found ./addressbook/addressbook.wasm
Firstly. why it is saying wast file is not found? I thought a wast file is not required or at least user does not have generate themselves?
Also it does not show the absolute path which the cleos is trying to read the contract from. That is difficult for beginner/new adopter to troubleshooting their problems if they use a wrong path or somehow in case of docker the path is not point to correct mapping folder.
Moreover, the usage of cleos set contract actually does not say the contract-dir has to be an absolute path.
contract-dir TEXT           The path containing the .wasm and .abi
It can do the job & good developers can figure it out. But this will consume new developers quite some time. Can we add support for relative path or update the usage?

The name of exception wast_file_not_found is changed to wasm_file_not_found, but not merged to master yet. (#6048)

The name of the exception has been corrected and is correct beginning with the v1.5.0 release.  The path in the error message now prints the canonical path, making debugging erroneous relative paths easier.  This is also available beginning with the v1.5.0 release.


Missing value at path rule should be improved

First off... thanks for this idea/tool. I am currently testing, if it is helpfull. I noticed the following when usign it with my charts:
In this example you see the the tool is generating an error. This is indeed correct that .Values.externalServices.mysql is not existing, but at the same time it is my desire to have the default empty. That is the reason why im am testing for the value.
Futhermore I do not know what to recommend. I just wanted to let you know.

Hey @xrow, thanks for informing me about this. I adjusted the regex for the Linter to not only ignore the {{ if... but also the {{ else if... lines. I plan on introducing an option in the settings to enable/disable linting for those if/else conditions. For now the Linter will just ignore these.

Fix released with v0.9.1


[realtime] fix issue with it not working under some conditions

This is a place holder.  It needs some testing (@psdtwk, maybe you can help on this?) to see all the circumstances in which it doesn't work at all, or doesn't work as expected.
We had some issues pointed out during the 3.0 beta, but we pushed/ignored them for the release.
Just add comments to this issue with all the found problems and we'll knock them out as they come up.  We can file new issues and defer them to another release as needed.

lol sorry about that. I thought it'd let me assign two people.

Nah, that's actually fine the other way.

I just want to say that I love the title of this issue.

If there's one thing we all know to be true, it's that: specificity is my defining characteristic.

Can we get some confirmation or increased specificity on this issue? Tag it "confirmed" when it can be reliably reproduced.

Can we get some confirmation or increased specificity on this issue?

What's to confirm?  It just doesn't work sometimes.  The point of this issue is to find which circumstances under which it does not work.

K, I guess I hadn't noticed it not working.

Leaving this module in beta.  We'll fix it up in 3.2+

Aaaaand... leaving this in beta for another release.


A problem in the width and height parameters of scene.drillPick

The width and height must be multiplied by 2 to get the correct result

hello nieling1
i am a beginner in open source world
can you please tell me exact location of code[related to this issue] in files
so that i can work on that

I'm closing this issue due to inactivity. If you believe this is still an issue, please feel free to re-open. Thanks!


Implement black level correction

Currently the ISP pipeline lacks black level correction in Bayer domain. Needs an implementation here black_level_correction.py

With referance to commit https://github.com/xx-isp/infinite-isp/commit/3df3298c6aa480a4ccb6c4889452b6f6b18762c4 BLC has been added to the project.


Rename Interpolate module to ColorComponents

Fixes #73

Thank you very much! I had better make some more "good first issues" :)

You are welcome, thank you for putting the label, it's very useful!


Using a prefix with spaces will break Felix

need to add a error message or something so you cant set your prefix to something qoliugfkuyquq

thank you so much for helping me you are a very clever lad =)

Transferred to issue #103


I want to add some chart style, such as linePlusBarChart, multiBarHorizontalChart, multiChart

Make sure these boxes are checked before submitting your issue - thank you!

[yes ] I have checked the superset logs for python stacktraces and included it here as text if any
[yes ] I have reproduced the issue with at least the latest released version of superset
[yes] I have checked the issue tracker for the same issue and I haven't found one similar

In our project , we enhance the viz that add some chart style :  linePlusBarChart, multiBarHorizontalChart, multiChart.
we can get the chart like that:

Superset version
0.14.1
Expected results
1.linePlusBarChart
2. multiBarHorizontalChart,
3.multiChart.
Actual results
fine
Steps to reproduce
New feature.
later, I will submit the code, ,if you think my code is okay, could you please merge pull reqiest?

note that we have the explorev2 refactor going on (to be merged probably end of week), until it's merged you need to make the changes in 2 places (explore and explorev2).
From the screenshot about, the 3rd chart looks pretty unreadable...
the 2nd chart seems like it could just be a new is_horizontal option added to the existing bar chart (if the api is similar enough)

@mistercrunch
i think the 3nd chart  is necessary，I was able to get any charts I wanted。
It looks unreadable because there are too many charts, you can choose what you want.
like that:

This would be GREAT !

This looks amazing. I am using version 0.19 but seems could not reproduce the above. I am also unable to locate the "chart options" in superset, could you please advise? Appreciated.

@ujhujuh  This looks great and will be very much usefull in our current project. Can you please document the steps how you have implemented this, it will be much helpfull .

FYI we're considering [longer term] to move our core charts to using data-ui which is built on vx. These charts are very "composable" meaning we could add better support for multi-layered charts at that point. Until then I don't think we want to add much more support for multi-layered-charts.

Notice: this issue has been closed because it has been inactive for 199 days. Feel free to comment and request for this issue to be reopened.

#6812


k8s: Fix IPv6 NodePort provisioning and add a surrogate frontend with cilium_host IP

This PR:

Fixes IPv6 NodePort provisioning.
Adds a surrogate frontend with cilium_host IP addr.

See commit messages for more details.

This change is

test-me-please

Coverage decreased (-0.02%) to 44.111% when pulling bf3ea9a4f68945ad4f20fd4055a15827f0ae8142 on pr/brb/nodeport-mgmt-fixes into 030ceacbcccf4048062db29457491122f0afc0a1 on master.


manually clear key when Transient Errors encounted?

The README says:

Transient Errors: A load may fail because it simply can't be loaded (a permanent issue) or it may fail because of a transient issue such as a down database or network issue. For transient errors, clear the cache:

and gives an code snippet on how to deal with this situation:
userLoader.load(1).catch(error => {
  if (/* determine if error is transient */) {
    userLoader.clear(1);
  }
  throw error;
});

It is recommended to do clear(key) manually. But after i read the code, it seems that DataLoader already take care of this. Am i missing something   or the doc need to update?

It'd seem so; I think the docs probably need to be updated.

I just made some updates to Readme that hopefully improve this. Your suggestion is half-correct. If the entire batch request fails, then cache is cleared. If individual values are provided Error, those are cached. I updated the language to make this clear.

Thanks, i got your point.
However, in real world from what i see, it rarely happens when individual values are provided Error, because batch function is designed to reduce network cost of fetching data to backend. For example, a batch function to load data from a rational database may look like this:
var batchFn = ids => {
  return new Promise((resolve, reject) => {
    sqlRun(`SELECT * FROM user_table WHERE ID IN (${ids.join(',')})`, (err, records) => {
      if (err) {
        return reject(err);
      } else {
        return resolve(records);
      }
    });
  });
};

rather than
var batchFn = ids => {
  return Promise.all(ids.map(id => {
    return new Promise((resolve, reject) => {
      sqlRun(`SELECT * FROM user_table WHERE id=${id}`, (err, record) => {
        if (err) {
          return reject(err);
        } else {
          return resolve(record);
        }
      });
    });
  }));
}

It certainly depends on the system you're communicating with, and of course it's up to how you implement your batching function. There is of course the case where the batch itself fails, which is well illustrated by your first example. There is also a case where your batch function may return a combination of values and errors. That is - the batch load itself succeeded however some of the individual operations within the batch failed.

Agreed, just to share my thoughts, thanks!


Why we're using dirty NIFs?

Why we have switched to dirty NIFs?
It seems that here we pass to NIF just one frame:
  # handle single frame
  defp encode_buffer(native, buffer, acc, bytes_used, raw_frame_size)
       when byte_size(buffer) >= raw_frame_size do
    <<raw_frame::binary-size(raw_frame_size), rest::binary>> = buffer

    with {:ok, encoded_frame} <- Native.encode_frame(raw_frame, native) do
      encoded_buffer = %Buffer{payload: encoded_frame}

      encode_buffer(
        native,
        rest,
        [encoded_buffer | acc],
        bytes_used + raw_frame_size,
        raw_frame_size
      )
    else
      {:error, reason} ->
        warn_error("Terminating stream because of malformed frame", reason)
        {:error, reason}
    end
  end

which should fit into constraint of having quick execution of a NIF call, so dirty NIF should not be necessary.

The reason is: sometimes the encoding of 1 frame takes longer than 1ms.

The overhead is of Dirty NIF is not that big and according to these articles:
https://medium.com/@jlouis666/erlang-dirty-scheduler-overhead-6e1219dcc7
https://potatosalad.io/2017/08/05/latency-of-native-functions-for-erlang-and-elixir
it's around 2us of latency on entry and 7.5us on return. The latter can be minimised when running on a phisical machine by preventing scheduler migrations between cores with some erlang flags


OAuth2 filter: supports forwarding ID tokens to upstream web service via the Authorization header bearer scheme

Title: OAuth2 filter: supports forwarding ID tokens to upstream web service via the Authorization header bearer scheme
Description:
OAuth2 filter has a forward_bearer_token configuration knob. If enabled, it forwards access tokens to the upstream web service via the Authorization header bearer scheme. Could we also add a knob to forward ID tokens via the Authorization header?  This would allow the JWT filter or applications to utilize ID tokens for JWT-based authentication or other authorization purposes.
Related discussion in Envoy Gateway: https://github.com/envoyproxy/gateway/discussions/2425#discussioncomment-8722381

cc @lizan @mattklein123 @derekargueta

I think this issue can help me with my case.
I want save Authorization Header from request. But if forward_bearer_token=false Authorization Header deleted from requests(

👀 Hi guys, any update on this one?

@nezdolik can we nostale this? On my radar, wrapping up https://github.com/envoyproxy/envoy/issues/2098 first


arrows in nyquist plot

Recently, the Nyquist plot adds arrows to show the directions in the diagram. However, those arrows have always the same size and  the same position. Working with my students, sometimes the arrows make difficult the correct interpretation of the Nyquist plots.
New options for the arrow size and position (not always the first and the last frequencies) could help to solve the issue .

Yes, I am also experiencing this problem. Is there any hack to reduce the size of arrows?
For example figure below,

The problem seems to be that the arrow dimensions are based on the axis units rather than an "absolute" size (e.g., pixels).  It should be relatively easy to add an option to nyquist_plot to set the arrow size.  Better would be to set the arrrow size so that it isn't in axis units.
If someone wants to generate a PR for that, it would be useful.  I won't have time to get to it for a while.
Quick hack: you might be able to get the arrow object with matplotlib  and reset its size.

PR #379 provides a quick fix that allows the arrowhead size to be set manually.
A better algorithm that computes arrow head size automatically is still needed at some point.  Arrow position is also not yet done in a good way.

I'm not too familiar with the issue but the matplotlib documentation suggests using an annotation with an empty string as text like this:
>>> ax.annotate("", xy=(0.5, 0.5), xytext=(0, 0),
...             arrowprops=dict(arrowstyle="->"))

Maybe this is worth looking into?

Hi @SchrodingersCat00, that sounds like a good solution, especially since the current code also just adds a dummy straight line for the arrow from the edges of the actual curve.
https://github.com/python-control/python-control/blob/f3e503591367f216d265fd0dd9337693923ef72d/control/freqplot.py#L534-L555
Do you want to submit a PR for that?

PR #534 fixes this issue.


Add a more complex editor for inbox messages

Currently when creating new inboxes, admins are limited to either only using content and image attachments to fill out an embed description and its images, or setting up a webhook and using a tool like Discohook to create custom embeds. This makes it difficult to thoroughly customize inbox messages.
A method should be devised to customize most features of an embed directly inside the client, including the author, title, thumbnail, fields, image(s), and footer. It should also allow for regular content alongside or in place of embeds.
A possible design might look like a message containing:

a preview of the contents;
a select menu to change different aspects of the message; and
a button to confirm the changes.

This will need to make extensive use of message components and modals.

This issue is low priority since the complexity of this feature overweighs the benefit of such intricate changes, most of which may not be interesting to admins. Although, admins should at least be able to change the embed's color in-message. Perhaps that particular element can be done with some parsing of the message itself, e.g. looking for a colour: #FFFF6E at the top of the message.


Update references to the renamed symbol in the entire project

Renaming a symbol updates only the references in the file it is defined in. When the item is imported in some other file, the references get broken. I expect them to be updated regardless of the place of reference, that is, throughout the entire project. For example:
// File: definition.typ
#let a = "a"

// File: reference.typ, in the same directory as definition.typ.
#import "./definition.typ": a

#a

Currently, renaming a in definition.typ breaks the reference in reference.typ. I would expect renaming a to b to result in
// File: definition.typ
#let b = "a"

// File: reference.typ, in the same directory as definition.typ.
#import "./definition.typ": b

#b

I have tested it and find it work as expected, so I guess the reference.typ is not in your workspace. The workspace files are all of that are in your the opening folder recursively, but the following superfluous build directories are excluded.
https://github.com/Myriad-Dreamin/tinymist/blob/5b7794a5879930ed8e37ce9252c8adaf38731bc4/crates/tinymist-query/src/syntax/module.rs#L98-L108

That is most likely my mistake, sorry. I tested on a different example, and it appeared to me to be obvious for the feature to be partly missing (this was a feature request). Therefore, instead of giving a tested, minimal, reproducible example of a bug, I gave an example for the feature description. I am not sure what went wrong then.
I must have inclined for the missing feature, because I previously used typst-lsp that does not support renaming symbols and this is a younger project, for which I am thankful. 🙂


set timeout on FluoAdminIT

This is a test.  Travis seems to keep timing out on FluoAdminImplIT.  Set timeouts on that test to see what happens.

I actually wanted this build to fail.  I have run it twice so far and the test has not timed out.  Maybe the third time will be the charm.

Fixed by #959


Add highlighting for hard line breaks in markdown.

Highlights hard line breaks as an "addition" in markdown.
Changes
Added a LINEBREAK regex case for hard line breaks.

Closing for inactivity.  We can reopen if you come back and have time to push this forward.


[IDEA/REQUEST] custom colors for yaml

Is your feature request related to a problem? Please describe.
To make yaml more visible and easier to work with.
Describe the solution you'd like
It would be nice if there was one color for the property and one for the value. If we can customize each one, even better.
Additional context (example)

That can easily be added, even though YAML will be reworked in the near future, according to Obsidian's Roadmap.

Really ? didn't know.

Yeah. This is an easy enough thing to do, though!


Neopronoun Text Entry (Enhancement)

Rather than being forced to choose the "other" option myself and others I'm sure would like a field to enter our own neopronouns. Of course this does come at the cost of need for moderation. Perhaps an approval process after saving changes and then if they are approved they will appear on supported apps/sites.

https://github.com/cyyynthia/pronoundb.org?tab=readme-ov-file#neo-pronouns-support
#96


finished dungeon search with no seeds

the server is running on freemcserver.net, it's on 1.16.5, and the world was also generated in 1.16.5, the server runs on purpur
no matter how many different dungeons I try it with it always gives me the same result
the server also does not have plugins

Fixed mine right after I discovered 2 dungeons. I don't know if it will work on you.

/seed data clear
Explore and look for 2 dungeons
Wait for the cracked seed


ReadOnlySpan for internal Produce methods

The first step to low-level producer without serializers.
Proposed producer interface can looks like
Task<DeliveryResult> ProduceAsync(
            string topic,
            ReadOnlySpan<byte> key,
            ReadOnlySpan<byte> value,
            Headers headers = null,
            Timestamp timestamp = default,
            CancellationToken cancellationToken = default(CancellationToken));

If you are interested in such changes, I can prepare a pull request with an implementation.
PS: Thank you for great library :)

@confluentinc It looks like @alec-anikin just signed our Contributor License Agreement. :+1:
Always at your service,
clabot

this is looking like we want to merge it to me, but i'll spend more time thinking about it before doing so.
re: low level producing without serializers - i'm hesitant (and explicitly didn't) add this to the K, V typed producer because I don't think it belongs there. I'd like to ultimately add an untyped Producer, where the serializer is chosen automatically based on type - i think this may fit in well there. Alternatively, maybe we have a whole new LowLevelProducer or BytesProducer class or something. The latter approach isn't seeming too bad to me ATM. Of course, both these would require a fair bit of refactoring under the covers so we get good code reuse.

Yes, methods with Spans are not at all suitable for the current KV producer interface. I've already tried making some draft. I'll try to polish it and create another pull request.


Add a scripting example to upload files to an API.

Signed-off-by: Tim Beermann<EMAIL_ADDRESS>

The UI now supports multipart files. Hence I will close this one.


zld: fix hash

Description of changes
Closes #189952.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

not sure why ofborg isn't building zld

not sure why ofborg isn't building zld

hydraPlatforms is set to an empty list.

ah, i forgot that was a thing


Fix the directory name of the reference

Please wait to merge this pr. It causes too large conflict.

I agree. I would like to discuss when to merge it.

It is time to merge this PR.

LGTM!


Element with id is already registered

I am also getting this error with v1.53.2 of VSCode and v11.2.1 of GitLens. It started recently and appears periodically.

Originally posted by @njbbaer in https://github.com/eamodio/vscode-gitlens/issues/606#issuecomment-784868320

@njbbaer Can you provide details on when/how you are experiencing it? And is it always with tags?

@eamodio I noticed that message in VSCode randomly every hour or so for a few days, but it hasn't recurred recently. I don't recall if it always had a tag or not. I'll post back here if it starts happening again.

In VsCode 1.53.2 I get the following error since upgrading everytime I push or pull:
gitlens:repository(c:/folder/repository):compare-branch(master):root is already registered

I get this message when I swap branches from the command line then switch back to visual studio code.

@welcometochristown You get this every time? Or at least reasonably reproducible?

This was occurring to me too - closing and opening VS Code fixed it, but cannot pin-point what triggered it in first place. Luckily it was nothing harmful but I got scared for a second that my local git repo was corrupted or something 😅

I can't seem to reproduce it. I have no idea what is causing it. Sometimes it happens when I commit, sometimes when I push and sometimes just randomly when there is a change.
The only thing I thought it might be is that I have 4 different repos in my workspace but I can't confirm that's the reason.
Closing visual studio does fix it temporarily but always comes back.

@eamodio Actually I think I can reproduce it by clicking away from the Source Control tab and then back to the Source Control tab in vs code.

I believe this has been resolved in the latest GitLens insiders edition (should be coming to GitLens stable soon).
You can install the GitLens insiders edition from here. Be sure to disable/uninstall the stable version of GitLens first.

It happens for me a lot when I am in a workspace with many repos open, and I am in the gitlens view and one of the historical dropdowns in the left sidebar is expanded (e.g. Commits, Repositories, File History, etc.)
Which repo it happens to appears to be random, but once it happens, it keeps happening repeatedly until I right click the repo in that historical dropdown, and click "Close Repository". Then the errors stop appearing -- for now. Since I work in remote environment that gets disconnected every 9 hours, it's liable to pop up again after reloading the environment entirely in order to re-connect (another thing that's annoying about VS Code... it can't reconnect without re-loading the entire workspace).
Because of the random nature of the repo it happens to, this makes me think that there is some parallel processing going on and that it literally is trying to "register" something twice that it already has registered once, and will keep doing so until you close it.
Using GitLens 114.4.1 on VS Code 1.55.1

also seeing the following, with https://github.com/louking/rrwebapp, https://github.com/louking/loutilities, https://github.com/louking/running open in workspace (in that order), vscode 1.57, GitLens 11.4.1
Element with id gitlens:repository(c:/folder/repo):compare-branch(master):root is already registered


Add xmllint

Hey there, here is a PR for xmllint
Each of the 7z files that the manifest calls out have a bunch of extra supporting folders in them that aren't needed for xmllint.exe to run properly (lib/, share/, include/, etc). The only stuff that needs to be part of this are the dlls in the bin/ folder in each 7z archive.
I tried to exclude the unneeded stuff in the manifest via the extract_dir element but I couldn't get it to work. So as it is now, when you install you'll get all 23mb of stuff that's in these 7z's as opposed to the ~8 that's actually needed.

That's cool – thanks.
To get extract_dir to work with more than one url, you need to make an array of the paths to extract for each url, e.g.
"extract_dir": [ "bin", "bin", "bin", "bin" ]

See vim.json for a real example.


This seems to work as expected, but I don't know enough to say if an extra type parameter affects the implicit search in practice (would it succeed in all cases you'd expect?)
given [T, K](using first: First[T] { type AssociatedFirst = K }): Second[T] with
  type AssociatedSecond = first.AssociatedFirst

This workaround uses a refinement type (?), but why does it help?

That's very clever. I can make a few banal observations which may be obvious.
The given First is a singleton, so its member type is known
val first: given_First_Test1.type = given_First_Test1

The given Second is a def of result type
    given class given_Second_T[T >: Nothing <: Any](using first: First[T])
       extends Object(), Second[given_Second_T.this.T] {
      T
      protected given val first: First[T]
      type AssociatedSecond = given_Second_T.this.first.AssociatedFirst
    }

where the First is not constrained. Its AssociatedFirst could be anything.
The second, constrained version is
    given class given_Second_T[T >: Nothing <: Any, K >: Nothing <: Any](using
      first:
        First[T]
          {
            type AssociatedFirst = K
          }
    ) extends Object(), Second[given_Second_T.this.T] {
      T
      K
      protected given val first: First[T]{type AssociatedFirst = K}
      type AssociatedSecond = given_Second_T.this.first.AssociatedFirst
    }

where the K is happily inferred
val second: given_Second_T[Test1, String] = ???

because AssociatedFirst is known. I don't know if you intend that the given First is always a singleton (unparameterized).
My experience is limited, but I expected this to be solvable by inlining. Is inlining not permitted for parameterized givens?

I don't know if you intend that the given First is always a singleton (unparameterized).

That's right. In my real code, I generate a lot of types with scalameta and one given each, targeting the same trait/typeclass.

Is inlining not permitted for parameterized givens?

This wouldn't be practical in my case because I have thousands of auto-generated types and inlining is slow. And it doesn't seem to help:
inline given [T](using first: First[T]): Second[T] = new Second[T]:
  type AssociatedSecond = first.AssociatedFirst

inline given First[Test1] = new First[Test1]:
  type AssociatedFirst = String

Yeah, this is working as expected.  You need to preserve more type information (the type of the returned given) if you want to rely on it.

Isn't it strange that a non-implicit definition infers all of this automatically?
scala> def secondFromFirst[T](using first: First[T]) = new Second[T]:
     |
     |   type AssociatedSecond = first.AssociatedFirst
     |
def secondFromFirst
  [T]
    (using first: First[T]):
      Second[T]{type AssociatedSecond = first.AssociatedFirst}

Feels like a footgun

Perhaps you can get your auto-generated types to add those associated types to the given type:
given [T](using first: First[T]): (Second[T] {
    type AssociatedSecond = first.AssociatedFirst }) =
  new Second[T]:
    type AssociatedSecond = first.AssociatedFirst

I did figure it out now with refinement types and it's been working fine. Just bothers me a little that it's not the default and you need to be aware of it.
In my case, the refinement is needed for the using parameter, so given [T, AssocFirst](using first: First[T] { type AssociatedFirst = AssocFirst }): Second[T]
I didn't need to refine the type of my given (so far, at least)

Yeah, type members don't need to be specified, unlike type arguments (for type parameters).

I keep running into this regularly and also discovered #20061 through googling. With -language:experimental.modularity -source future, this solves the problem cleanly:
given [T](using tracked val first: First[T]): Second[T] with
  type AssociatedSecond = first.AssociatedFirst


Auto select tasklist

Commits
- :sparkles: added -l persistant flag on tasks command

:recycle: refactor treewide, add logging
:art: moved to better and colorful printing
:memo: update root version

What changed

fixes the issue with -i or --include-completed flag which showed completed tasks
added the list selection persistent flag

Usage

To pre-select tasklist

gtasks tasks -l <tasklist name> add|rm|view|done

To manually select from prompt

gtasks tasks add|rm|view|done

Example:
gtasks tasks [--tasklist|-l] "DSC VIT" view [--include-completed | -i]

Fixes #1 and #6.


[Feature Request] Disable Rotate(Oblique) in CrosshairTool but it should be dragged.

What feature or change would you like to see made?
I want to disable rotate in CrosshairTools.
I can't use getReferenceLineDraggableRotatable because I need to drag.
Is there any way to make it?
Why should we prioritize this feature?
I think it's an important part of being able to define the functionality of the tool by dividing it.

I think this makes sense to add


Please add requirements.txt file

Would be very helpful to add a dependencies file. This is particularly useful when new libraries are used between versions.

The only dependency is "ntpdate" right?

pywin32


how to intergrate the cadvisor to our porject, in the case of having source code changing and adaptor.

@maquanyi @mengfanliang
As we disscussed last time, we should use cadvisor directly to do monitoring for containers,
And now, we have split the monitoring task into two parts,

enable support for ocp-testing project,
do develop on supporting the RKT container to the cadvisor.
To the first task,
we have a question about how to intergrate into the ocp-testing, the situation is,
we should do some source code developing and adaptor  in the cadvisor source code, thus, to enable the cadvisor for ocp-testing.

so , my question is , in this case, how can we intergrate cadvisor to our project?
my opinion is:
we can fork a repo from the cadvisor, and do the source changing in our forked repo, and then just use the forked repo in our project, and by the way, we do the pull&request to the main line of cadvisor.
so ,what about your opinion?

@liangchenye @mengfanliang
we found that there are two ways to intergrate cadvisor to our project.
A. use cadvisor/client,
for example,
import "github.com/google/cadvisor/client"
client, err = client.NewClient("http://localhost:8080/")
mInfo, err := client.MachineInfo()
but It is only can be used to send the result to the specied URL endpoint, but not to the local machine.
B. use API to install a net handle, the problem is the same as A, only support net url.
C. develop a storage in the cadvisor/storage,  we have to do more driver develop, in this way, we can support to storage data in native machine.
So, how to intergrate it should be determined by what we want!
Do we want to export data directly to the url endpoint throught the net, or to export data to the local machine?
It is emergence, we have to decided now.thx.

Hi Zhinan, cadivisor is one of the container performance monitoring tools.
I thinking the integration here means: use this tool in the testcase, either by wrapping it in the script or using it directly.

@liangchenye  we @liugenping decided that to write a client to support it.
according to the ouput fomat, we can keep changing in future.
thx.

I just confirmed with @liugenping, it is OK to integrate cadivisor to the framework without any change.

in the deploy part, run the cadivisor daemon in the related hostOS
at the end of the 'run' part, run your client to collect the output and redirect to a certain file.

@liangchenye  yse, we @liugenping have determined it yestody.thx


dbus hide/show operation disables tray

Hi! (@IvanMalison)
When I do hide taffybar(using dbus) then show I have tray icons gone.
Also when taffybar runs on screen "0" and try to activate it on screen "1" I have only tray icons on screen "0".
When I run taffybar only on screen "0" and do 'hide' then 'show' icons are gone and only restart helps.
Cheers,
Krzysiek

Yeah, this is a known (sort of) issue. The problem is that only 1 widget can own any given tray widget at a time. You'll notice that if you start an application like trayer before taffybar, the tray will also fail to show up, but of course what is actually happening is that all of the tray icons are simply not registering with the taffybar tray because they've already registered with trayer.
I think the correct course of action would be to explicitly destroy and unregister the tray when taffybar is "hidden" on a given monitor, but when I tried to add a haskell binding to the c function that does this for the tray it started causing crashes.
I've also tried making it so that there is actually only 1 tray-manager widget and it is simply moved between the different taffybars. This also failed for some reason.


feat: support distinguishing escape sequences inside strings, fix multiline strings

Checklist:

[ ] All tests pass in CI.
[x] There are sufficient tests for the new fix/feature. (Existing literals.txt reflects updates)
[x] Grammar rules have not been renamed unless absolutely necessary.
[x] The conflicts section hasn't grown too much.
[x] The parser size hasn't grown too much (check the value of STATE_COUNT in src/parser.c). (1282 -> 1297)

not sure how to make the CI run, but on my end running tree-sitter test and ./script/parse-examples is ok

cc @bmahe

Note that I derived a lot of inspiration from the way the javascript parser handles escape sequences here

Interesting changes!
@amaanq can we add some test cases to exercise the new cases being handled?

Interesting changes!
@amaanq can we add some test cases to exercise the new cases being handled?

I do believe the multiline string changes are covered with the tests you added, but I can add some for the escape sequences soon :)

@bmahe  Sorry, got caught up with life...added tests with the escape sequences
Let me know what you think of that.

oops, didnt mean to remove the request

Don't mean to be hasty or annoying...but I'd like to get this merged :slightly_smiling_face:
ping @bmahe @aryx

@amaanq can we add tests that demonstrate the intent of this PR?
The escape sequence provided in your latest commit is successfully parsed.
So what problem is this pr trying to resolve?
[bruno@buo tree-sitter-java]$ cat test.java
String a = "\n\a\b\fhi im a piece of text\t\v and im some more text \\\'\"\?";

[bruno@buo tree-sitter-java]$ tree-sitter parse test.java
Warning: You have not configured any parser directories!
Please run `tree-sitter init-config` and edit the resulting
configuration file to indicate where we should look for
language grammars.

(program [0, 0] - [2, 0]
  (local_variable_declaration [0, 0] - [0, 78]
    type: (type_identifier [0, 0] - [0, 6])
    declarator: (variable_declarator [0, 7] - [0, 77]
      name: (identifier [0, 7] - [0, 8])
      value: (string_literal [0, 11] - [0, 77]))))

@amaanq can we add tests that demonstrate the intent of this PR? The escape sequence provided in your latest commit is successfully parsed.
So what problem is this pr trying to solve?
On the latest in the main branch:
[bruno@buo tree-sitter-java]$ cat test.java
String a = "\n\a\b\fhi im a piece of text\t\v and im some more text \\\'\"\?";

[bruno@buo tree-sitter-java]$ tree-sitter parse test.java
Warning: You have not configured any parser directories!
Please run `tree-sitter init-config` and edit the resulting
configuration file to indicate where we should look for
language grammars.

(program [0, 0] - [2, 0]
  (local_variable_declaration [0, 0] - [0, 78]
    type: (type_identifier [0, 0] - [0, 6])
    declarator: (variable_declarator [0, 7] - [0, 77]
      name: (identifier [0, 7] - [0, 8])
      value: (string_literal [0, 11] - [0, 77]))))

output on my end (with my changes):
ts p test.java
(program [0, 0] - [1, 0]
(local_variable_declaration [0, 0] - [0, 78]
type: (type_identifier [0, 0] - [0, 6])
declarator: (variable_declarator [0, 7] - [0, 77]
name: (identifier [0, 7] - [0, 8])
value: (string_literal [0, 11] - [0, 77]
(escape_sequence [0, 12] - [0, 14])
(escape_sequence [0, 14] - [0, 16])
(escape_sequence [0, 16] - [0, 18])
(escape_sequence [0, 18] - [0, 20])
(string_fragment [0, 20] - [0, 41])
(escape_sequence [0, 41] - [0, 43])
(escape_sequence [0, 43] - [0, 45])
(string_fragment [0, 45] - [0, 68])
(escape_sequence [0, 68] - [0, 70])
(escape_sequence [0, 70] - [0, 72])
(escape_sequence [0, 72] - [0, 74])
(escape_sequence [0, 74] - [0, 76])))))
with this, editors can differentiate pieces of regular text vs escape sequences, like the image below:

the current parser doesn't allow for this. tree-sitter-python has a similar rule here, and tree-sitter-c here

Please make a separate PR for the styling/spacing/ and all the other stuff that are independent of what the title of this PR says.
In this PR we should just see modifications to distinguish escape sequence inside strings, and related test files, and nothing else. One this is merged you can make another PR to add those eslint and ci checks for styling issue.

Gotcha, I believe I've removed everything unrelated to the point of the PR. Anything else @aryx?

There's a tons of stuff not related to the PR title still. all those semicolons, $ to _, etc.
Those are good changes, but they need to be in a separate PR.
The modifications in this PR should just be related to the title of the PR, so only the stuff that help distinguish escape sequences
inside strings

tidied up history a bit

ping @aryx


Compatibility Fixes

This fixes everything that broke with the new canvas stuff and brings everything up to date with 0.7.6

@crhampton1 Would you be willing to join the League of Foundry Devs' Discord server (invite link)? Vance is one of the community leaders there and it'll probably be easier to get in touch there. (I'm Calego, feel free to @ me on discord)

Hi, curious of the status of this. Foundry is now at 0.7.8 and this module is keeping my from upgrading as I rely on it. Did any discussion happen with the author? Will maintenance proceed? Should we start pointing to @crhampton1's fork instead?

Just read this https://github.com/VanceCole/simplefog/issues/15#issuecomment-735416914, answered my question.


If you choose to overlap borders, then opacity will put in evidence the overlap.

If you choose to overlap borders, then opacity will put in evidence the overlap.

Isn't this the reason you want to have overlap?

No, I want to use overlap to hide fill borders, plus have some texture-alpha opacity to blend with fill texture.
I would like this to behave differently, to first merge textures and then apply opacity to the whole node, so you will see opacity but you won't be able to detect where the inner polygon ends.
But unless we split border polygons in two (outer border, inner border) and apply opacity differently to what is outside and inside, I think this might only be achieved throw _draw.


"ERROR: Use broadcasting (relu.(x))" when importing resnet18

After failing to import ResNet with ONNX.jl (onnx file here), I gave ONNXmutable.jl a try:
using ONNXmutable
g = ONNXmutable.CompGraph("models/resnet18-v1-7.onnx")

However, when I run g(ones(224,224,3,1)), I get
ERROR: Use broadcasting (`relu.(x)`) to apply activation functions to arrays.

Any idea?

Hi and thanks for the report.
The problem is most likely that I forgot that activation functions in flux must be broadcasted.
When they are inside Flux-layers this is done by the layer, but sometimes they end up as their own nodes in the graph and in that case they must be broadcasted.
I'll make a PR with a fix soon.

Ok try this branch and see if it works for you
] https://github.com/DrChainsaw/ONNXmutable.jl#bcact

I could load the model, but I haven't tested that it produces correct output.

Thanks for the prompt intervention!
I've run
] add https://github.com/DrChainsaw/ONNXmutable.jl#bcact

and verified that I'm on the correct branch
(@v1.4) pkg> status
Status `~/.julia/environments/v1.4/Project.toml`
  [c5f51814] CUDAdrv v6.3.0
  [be33ccc6] CUDAnative v3.1.0
  [3a865a2d] CuArrays v2.2.1
  [587475ba] Flux v0.10.4
  [6218d12a] ImageMagick v1.1.5
  [86fae568] ImageView v0.10.8
  [916415d5] Images v0.22.2
  [dbeba491] Metalhead v0.5.0
  [85610aed] NaiveNASflux v1.2.1
  [d0dd6a25] ONNX v0.1.1 [`dev/ONNX`]
  [cf2a63a0] ONNXmutable v0.1.0 #bcact (https://github.com/DrChainsaw/ONNXmutable.jl)
...

However, after re-running
using ONNXmutable
g = ONNXmutable.CompGraph("models/resnet18-v1-7.onnx")

as above and then issuing g(ones(224,224,3,1)), I still get the same error.

Thats odd...
Did you restart the repl between installing and using?
Here is from a fresh environment on my computer:
(testonnx) pkg> add https://github.com/DrChainsaw/ONNXmutable.jl#bcact
   ...
  [cf2a63a0] + ONNXmutable v0.1.0 #bcact (https://github.com/DrChainsaw/ONNXmutable.jl)
  ...

(testonnx) pkg> add NaiveNASflux
  [85610aed] + NaiveNASflux v1.2.1
 [no changes]

julia> using NaiveNASflux

julia> using ONNXmutable

julia> g = CompGraph("models/resnet18-v1-7.onnx");

julia> g(ones(Float32, 224,224,3,1))
1000×1 Array{Float32,2}:
 -1.2703923
 -0.509475
 -1.2314956
 -0.8486617

Sorry, I'm a julia newbie and I had only naively activated a new environment.
Now, re-running the commands from a fresh REPL, everything works. Thanks!
Probably unrelated, but when I precompiled ONNXmutable I got these warnings:
julia> using ONNXmutable
[ Info: Precompiling ONNXmutable [cf2a63a0-f8ae-421c-82b7-306ecfceaf66]
WARNING: Method definition iterate(DataFlow.ObjectArraySet{T} where T, Any...) in module DataFlow at /home/natema/.julia/packages/Lazy/KYseE/src/macros.jl:297 overwritten at /home/natema/.julia/packages/Lazy/KYseE/src/macros.jl:297.
  ** incremental compilation may be fatally broken for this module **

WARNING: Method definition iterate##kw(Any, typeof(Base.iterate), DataFlow.ObjectArraySet{T} where T, Any...) in module DataFlow at /home/natema/.julia/packages/Lazy/KYseE/src/macros.jl:297 overwritten at /home/natema/.julia/packages/Lazy/KYseE/src/macros.jl:297.
  ** incremental compilation may be fatally broken for this module **

Glad things worked out.
Restarting the repl after updating a package is certainly a bit of a gottcha. I'm not sure if it can be avoided somehow as I have developed the habit of restarting after some big enough change has been made. Apart from the new packages thing it also helps avoiding things like bugs hidden by global variables from past REPL commands.
Those warnings are annoying for sure. They come from ONNX.jl which in turn uses the obsolete package DataFlow. There is an issue on it here.


Windows libnetwork integration

This commit brings in the initial version of the windows libnetwork integration for networking.

Most of the code is common between the Linux and windows implementation so that has been pulled into common files.
TP4 builds don't have support for HNS so they will continue to work with the older model (os version check is performed in initNetcontroller  in daemon_windows.go)
We don't support hot add or removal of network devices so the implementation is missing with proper error being returned in those cases
The default network mode in Windows is "NAT" and not "bridge". Some of the common libnetwork code relied on the name being "bridge". I have updated that to query the DefaultDaemonNetworkMode
The engine-api changes are still pending to be merged so I have vendored my branch temporarily
HNS (windows networking service) maintains the networks and we query and add the networks from HNS at daemon startup.
Nic addition is not performed by libnetwork as in the case of Linux. This work is done by HNS and that information is passed as part of config to HCS at container start.
I have added a build script to build only windows. It was useful for me to create only windows builds (I can remove that if you think it is not required)

Job: Docker-PRs-WoW-TP4 FAILED:

---
9T04:54:29Z" level=error msg="hcsshim::DestroyLayer - Win32 API call returned error r1=0x80070020 err=The process cannot access the file because it is being used by another process.id=CI flavour=0"
ERROR:  hcsshim::DestroyLayer - Win32 API call returned error r1=0x80070020 err=The process cannot access the file because it is being used by another process.id=CI flavour=0
INFO: End of cleanup
INFO: Ended at Fri Feb 19 04:54:29 CUT 2016 (1m 27s)
Build step 'Execute shell' marked build as failure
[PostBuildScript] - Execution post build scripts.
[docker] $ sh -xe C:\Users\jenkins\hudson841871440292477836.sh
+ set +e
+ set +x
INFO: Nuking /d/CI
time="2016-02-19T04:54:32Z" level=error msg="hcsshim::DestroyLayer - Win32 API call returned error r1=0x80070020 err=The process cannot access the file because it is being used by another process.id=CI flavour=0"
ERROR:  hcsshim::DestroyLayer - Win32 API call returned error r1=0x80070020 err=The process cannot access the file because it is being used by another process.id=CI flavour=0
INFO: End
---

Job: Docker-PRs-Win2Lin FAILED:

---
/docker/engine-api/types/container".NetworkMode has no field or method IsBridge)
daemon\container_operations.go:419: too many errors
+ ec=1
+ set +x
ERROR: Build of binary on Windows failed
ERROR: Failed with exitcode 1 at Fri Feb 19 04:55:07 CUT 2016.
Build step 'Execute shell' marked build as failure
Performing Post build task...
Could not match :Build timed out  : False
Logical operation result is FALSE
Skipping script  : cd c:\scripts
sh timeout-post-build.sh

END OF POST BUILD TASK 	: 0
[PostBuildScript] - Execution post build scripts.
[docker] $ sh -xe C:\Users\Jenkins\AppData\Local\Temp\hudson94743003375936050.sh
+ set +x

---

Job: Docker-PRs-vendor FAILED:

---
stats.go
 D vendor/src/github.com/docker/engine-api/types/strslice/strslice.go
 D vendor/src/github.com/docker/engine-api/types/time/timestamp.go
 D vendor/src/github.com/docker/engine-api/types/types.go
 D vendor/src/github.com/docker/engine-api/types/versions/v1p19/types.go
 D vendor/src/github.com/docker/engine-api/types/versions/v1p20/types.go
?? vendor/src/github.com/msabansal/

Please vendor your package with ./hack/vendor.sh.

Build step 'Execute shell' marked build as failure
[PostBuildScript] - Execution post build scripts.
[Docker-PRs-vendor] $ /bin/sh -xe /tmp/hudson4646382139682435515.sh
+ set +x

---

Job: Docker-PRs-WoW-TP4 FAILED:

---
	      56	docker-1.11.0-dev.exe.md5
  0%
100%
	    New File  		      88	docker-1.11.0-dev.exe.sha256
  0%
100%
	    New File  		  27.3 m	docker.exe
  0.0%
  3.6%
  7.3%
 10.9%
 14.6%
 18.3%
 21.9%
 25.6%
 29.2%
 32.9%
 36.6%
 40.2%
 43.9%
 47.5%
 51.2%
 54.9%
 58.5%
 62.2%
 65.9%
 69.5%
 73.2%
 76.8%
 80.5%
 84.2%
 87.8%
 91.5%
 95.1%
 98.8%
100%

------------------------------------------------------------------------------

               Total    Copied   Skipped  Mismatch    FAILED    Extras
    Dirs :         1         0         1         0         0         0
   Files :         4         4         0         0         0         0
   Bytes :   54.62 m   54.62 m         0         0         0         0
   Times :   0:00:00   0:00:00                       0:00:00   0:00:00

   Speed :<PHONE_NUMBER> Bytes/sec.
   Speed :            63033.144 MegaBytes/min.
   Ended : Friday, February 19, 2016 5:06:31 AM

+ ec=0
+ set +x
INFO: Linking the built binary to /d/CI/CI-48ba5
---

Job: Docker-PRs-Win2Lin FAILED:

---
.172s
PASS: docker_cli_build_test.go:1251: DockerSuite.TestBuildAddDirContentToExistingDir	6.598s
PASS: docker_cli_build_test.go:1227: DockerSuite.TestBuildAddDirContentToRoot	5.104s
PASS: docker_cli_build_test.go:1305: DockerSuite.TestBuildAddEtcToRoot	0.474s
PASS: docker_cli_build_test.go:3121: DockerSuite.TestBuildAddFileNotFound	0.151s
PASS: docker_cli_build_test.go:959: DockerSuite.TestBuildAddFileWithWhitespace	7.947s

----------------------------------------------------------------------
FAIL: docker_cli_build_test.go:2916: DockerSuite.TestBuildAddLocalAndRemoteFilesWithCache

docker_cli_build_test.go:2940:
    c.Fatal(err)
... Error: failed to build the image: Sending build context to Docker daemon 3.072 kB

Step 1 : FROM scratch
 --->
Step 2 : MAINTAINER dockerio
 ---> Running in be5d47a0aab5
 ---> 47e4dfd9f79b
Removing intermediate container be5d47a0aab5
Step 3 : ADD foo /usr/lib/bla/bar
 ---> 1443c2f0f618
Removing intermediate container 16a028b43205
Step 4 : ADD http://<IP_ADDRESS>:32768/baz /usr/lib/baz/quux
Get http://<IP_ADDRESS>:32768/baz: dial tcp <IP_ADDRESS>:3276
---

Job: Docker-PRs-gccgo FAILED:

---
.pN57_github_com_docker_docker_integration_cli.DockerTrustSuite
SKIP: docker_cli_create_test.go:309: TestUntrustedCreate.pN57_github_com_docker_docker_integration_cli.DockerTrustSuite
SKIP: docker_cli_pull_trusted_test.go:49: TestUntrustedPull.pN57_github_com_docker_docker_integration_cli.DockerTrustSuite
SKIP: docker_cli_run_test.go:3187: TestUntrustedRun.pN57_github_com_docker_docker_integration_cli.DockerTrustSuite

----------------------------------------------------------------------
FAIL: docker_cli_authz_unix_test.go:231: TestAuthZPluginAllowEventStream.pN57_github_com_docker_docker_integration_cli.DockerAuthzSuite

[d37650000] waiting for daemon to start
[d37650000] daemon started
[d37650000] exiting daemon
[d37650000] waiting for daemon to start
[d37650000] received status != 200 OK: 500 Internal Server Error
[d37650000] daemon started
events_utils.go:125:
    c.Fatalf("failed to observe event `%s` for %s. Disconnection error: %v\nout:\n%v", event, id, e.disconnectionError, scannerOut)
... Error: failed to observe event `start` for 0d63765836786a616ace156111eabd242f430d779a3e367d8c67d19cd150891
---

Related engine-API PR is here https://github.com/docker/engine-api/pull/88

Job: Docker-PRs-Win2Lin FAILED:

---

Ping statistics for <IP_ADDRESS>:
    Packets: Sent = 4, Received = 4, Lost = 0 (0% loss),
Approximate round trip times in milli-seconds:
    Minimum = 0ms, Maximum = 4ms, Average = 1ms
ERROR: Failed with exitcode 1 at Sun Feb 21 03:31:37 CUT 2016.
Build step 'Execute shell' marked build as failure
Performing Post build task...
Could not match :Build timed out  : False
Logical operation result is FALSE
Skipping script  : cd c:\scripts
sh timeout-post-build.sh

END OF POST BUILD TASK 	: 0
[PostBuildScript] - Execution post build scripts.
[docker] $ sh -xe C:\Users\Jenkins\AppData\Local\Temp\hudson383897519412683189.sh
+ set +x

---

Job: Docker-PRs-WoW-TP4 FAILED:

---
	      56	docker-1.11.0-dev.exe.md5
  0%
100%
	    New File  		      88	docker-1.11.0-dev.exe.sha256
  0%
100%
	    New File  		  27.3 m	docker.exe
  0.0%
  3.6%
  7.3%
 10.9%
 14.6%
 18.2%
 21.9%
 25.6%
 29.2%
 32.9%
 36.5%
 40.2%
 43.8%
 47.5%
 51.2%
 54.8%
 58.5%
 62.1%
 65.8%
 69.4%
 73.1%
 76.8%
 80.4%
 84.1%
 87.7%
 91.4%
 95.1%
 98.7%
100%

------------------------------------------------------------------------------

               Total    Copied   Skipped  Mismatch    FAILED    Extras
    Dirs :         1         0         1         0         0         0
   Files :         4         4         0         0         0         0
   Bytes :   54.67 m   54.67 m         0         0         0         0
   Times :   0:00:00   0:00:00                       0:00:00   0:00:00

   Speed :<PHONE_NUMBER> Bytes/sec.
   Speed :            59649.837 MegaBytes/min.
   Ended : Sunday, February 21, 2016 3:32:49 AM

+ ec=0
+ set +x
INFO: Linking the built binary to /d/CI/CI-40358
---

Job: Docker-PRs-vendor FAILED:

---
stats.go
 D vendor/src/github.com/docker/engine-api/types/strslice/strslice.go
 D vendor/src/github.com/docker/engine-api/types/time/timestamp.go
 D vendor/src/github.com/docker/engine-api/types/types.go
 D vendor/src/github.com/docker/engine-api/types/versions/v1p19/types.go
 D vendor/src/github.com/docker/engine-api/types/versions/v1p20/types.go
?? vendor/src/github.com/msabansal/

Please vendor your package with ./hack/vendor.sh.

Build step 'Execute shell' marked build as failure
[PostBuildScript] - Execution post build scripts.
[Docker-PRs-vendor] $ /bin/sh -xe /tmp/hudson192417322685317377.sh
+ set +x

---

Job: Docker-PRs-userns FAILED:

---
ite.TestCpToCaseB	0.552s
PASS: docker_cli_cp_to_container_test.go:273: DockerSuite.TestCpToCaseC	1.388s
PASS: docker_cli_cp_to_container_test.go:300: DockerSuite.TestCpToCaseD	2.877s
PASS: docker_cli_cp_to_container_test.go:346: DockerSuite.TestCpToCaseE	1.860s
PASS: docker_cli_cp_to_container_test.go:382: DockerSuite.TestCpToCaseF	0.560s
PASS: docker_cli_cp_to_container_test.go:405: DockerSuite.TestCpToCaseG	3.006s

----------------------------------------------------------------------
FAIL: docker_cli_cp_to_container_test.go:451: DockerSuite.TestCpToCaseH

running `docker cp /tmp/test-cp-to-case-h965396597/dir1/. ce271bcde08ec01d643f0a92f7147f4f9b679d4525731053787a047202007750:testDir`
checking that container "ce271bcde08ec01d643f0a92f7147f4f9b679d4525731053787a047202007750" start output contains "file1-1\n"

running `docker start -a ce271bcde08ec01d643f0a92f7147f4f9b679d4525731053787a047202007750`
docker_cli_cp_to_container_test.go:468:
    // Should now contain file1-1's contents.
    c.Assert(containerStartOutputEquals(c, containerID,
---

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "HNSIntegration" git@github.com:msabansal/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~2
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR.  If you need more info; have a look at our contributors guide

also;
ping @mavenugo if you have time to check if this LGTY

@thaJeztah  Thanks. Done

@msabansal @thaJeztah will get to this PR soon.

@msabansal looks like this needs a rebase :cry:

@thaJeztah  done.
How can we restart the experimental & windowsTP4 tests? They seem to failing for some configuration issues and look to be transient errors

@msabansal done.

@cpuguy83  :) These tests will take some effort to pass

Spoke to @msabansal offline. There's a problem in the code currently which he's investigating. The windowsTP4 errors are genuine - the daemon under test is crashing it's http goroutine during the building of the busybox image, hence the subsequent multiple errors relating to the busybox image not being found.
(That said, looks like I need to investigate why the CI continued rather than erroring out at that point).

Screenshot of CI passing, complete with timestamp, included for posterity... Jenkins flakiness has been troublesome for getting a clean run, but that's being worked on independently by multiple people.
@icecrime @calavera @cpuguy83 @tiborvass @thaJeztah @powersplay @friism Can we please get this moved to code review? This is a super critical PR to get merged ASAP in support of the HNS/libnetwork integration for TP5. All issues have been resolved - it LGTM from my review.
@mavenugo @mrjana - Madhu/Jana, please can you code review as a priority?

ping @mavenugo PTAL

It's not completely related to the PR but I feel like container.go and container_operations.go are getting quite big and the changes moved back from container_unix.go could go to a container_network.go (same for container_network_operations.go.

@msabansal could you please confirm that the functions added back to container.go and container_operations.go are simply moving it from its *unix.go counterpart ?
Since that is the bulk of the work, I would like to get that confirmation and that would help a great deal with code-review.

bulk of these changes LGTM. I agree with @vdemeester that this is a perfect opportunity to structure those functions a little bit better.

could go to a container_network.go (same for container_network_operations.go)

I like this.

@calavera @vdemeester Can I suggest the restructuring comes in a follow-up PR?

@mavenugo @mrjana We do need libnetwork to be revendored again before this PR is merged(we renamed the windows drivers to be lowercase). Is there a plan to revendor it or should I work on getting that done?

@msabansal yes. we are planning on the vendoring shortly.
BTW, am +1 with @calavera & @vdemeester as well.

@mavenugo Yes most of the code is just refactoring and moving it to the common location.
I have addressed the one concern we had and renamed Subnet to FixedCIDR

Thanks @msabansal. I don't have any other comment.
We just have to wait for the next libnetwork vendor in. We are planning on pulling in a bunch of fixes
(including the windows fixes) tomorrow.
BTW, am fine with doing the container_network.go code reshuffling in a follow up PR.

@jhowardmsft I would think it's not that big a deal to just move the piece of code brought back into non …_unix.go file, as a first simple state. But it could be done in a follow-up PR, that's true (just think it would make sense in this one).
Few nits comments, but overall I'm LGTM 🐰 too .

This depends on #21019 Please, do not merge until that PR is merged.

@msabansal #21019 is now merged! Can you please rebase?

Please note that concept of execdrivers is being replaced with OCI compliant binaries executed through containerd. There is an ongoing effort for switching to containerd in #20662 . Please consider porting the changes in your PR to this branch instead.

@msabansal Ignore the Gordon comment. I've asked Darren to talk to you about that, and will catch up internally if you have more questions. For other reviewers/maintainers, this change is completely independent of the containerd effort and should be merged into master in its own right to support progress on TP5 before the containerd work is complete.

ping @calavera @vdemeester @mavenugo please review

bulk of the changes are simply code re-organizing to make most of the networking code relevant for windows. As agreed earlier in the thread, we can consolidate better, but that doesn't block this PR.
still LGTM.

Is this good now?

All good :tada: Thanks!

Thanks :)

Congrats on your first PR merged in Docker @msabansal !

@thaJeztah  Thanks :)