Thread 'tokio-runtime-worker-4' panicked at 'Bad input data provided to execute_block', runtime/src/lib.rs:228

Thread panic error when I have playing template-node. node version(substrate) is 1.0.0.
Reproduce steps:

run node ./target/release/substrate-test --dev
Set the value to Value defined in runtime/src/mytemplate.rs (via poladkt.js.org/apps/)

runtime/src/mytemplate.rs

decl_storage! {
    trait Store for Module<T: Trait> as MyStorage {
        Value get(value_getter): map T::AccountId => u64;
    }
}

Logs
====================

 stack backtrace:
    0: substrate_panic_handler::set::{{closure}}::hae047da797da35b0 (0x109b58cd0)
    1: std::panicking::rust_panic_with_hook::h4a3495c63f64f755 (0x109cb5e11)
    2: std::panicking::continue_panic_fmt::h3de7ba5e03709cd8 (0x109cb585c)
    3: std::panicking::begin_panic_fmt::hacd31b9797a72469 (0x109cb57b0)
    4: node_template_runtime::api::dispatch::h799c8f6abd8b6647 (0x1098958aa)
    5: std::panicking::try::do_call::ha9cece7285213e43 (0x108c90013)
    6: ___rust_maybe_catch_panic (0x109cbf1fe)
    7: substrate_executor::native_executor::safe_call::h9d5c5f979b020bee (0x108d9207a)
    8: <std::thread::local::LocalKey<T>>::with::h0869561142f3f1c6 (0x108c922fe)
    9: <substrate-test::service::Executor as substrate_executor::native_executor::NativeExecutionDispatch>::dispatch::hc512aaa42e2598b2 (0x108df5790)
   10: <std::thread::local::LocalKey<T>>::with::h74f844da3551185e (0x108ca479b)
   11: <substrate_state_machine::StateMachine<'a, H, B, T, O, Exec>>::execute_aux::hcb29428672c53e13 (0x109018c72)
   12: <substrate_state_machine::StateMachine<'a, H, B, T, O, Exec>>::execute_call_with_native_else_wasm_strategy::hf5510a3969474177 (0x1090493d7)
   13: <substrate_state_machine::StateMachine<'a, H, B, T, O, Exec>>::execute_using_consensus_failure_handler::h9646787ea25dd5b3 (0x1090352e5)
   14: <substrate_client::call_executor::LocalCallExecutor<B, E> as substrate_client::call_executor::CallExecutor<Block, substrate_primitives::hasher::blake2::Blake2Hasher>>::call_at_state::h76bb61ddd145ff3e (0x108d95f3f)
   15: <substrate_client::client::Client<B, E, Block, RA>>::apply_block::h812094d0e0a56723 (0x108f8ff43)
   16: <substrate_client::client::Client<B, E, Block, RA> as substrate_consensus_common::block_import::BlockImport<Block>>::import_block::h47b80d39cf62e8f7 (0x108f763a8)
   17: <futures::future::map::Map<A, F> as futures::future::Future>::poll::h90a4408471a141bf (0x108d15647)
   18: <futures::future::map_err::MapErr<A, F> as futures::future::Future>::poll::h571757c7b307f255 (0x108e6ae01)
   19: <futures::future::either::Either<A, B> as futures::future::Future>::poll::hb57e351061e5a45c (0x108e68d3f)
   20: <futures::stream::for_each::ForEach<S, F, U> as futures::future::Future>::poll::hb44b2fee1ec53c37 (0x108c13300)
   21: std::panicking::try::do_call::h18cdebfc20d74b1d (0x108c8f6ba)
   22: ___rust_maybe_catch_panic (0x109cbf1fe)
   23: <futures::future::chain::Chain<A, B, C>>::poll::hc74d3a5908f4ece3 (0x108e4d7c6)
   24: <futures::future::select::Select<A, B> as futures::future::Future>::poll::hd3a314aa2bcaa893 (0x108bd8085)
   25: <futures::future::chain::Chain<A, B, C>>::poll::hee05849463690fc1 (0x108e4ef68)
   26: futures::task_impl::std::set::h0d86a834a1e10977 (0x109b1665c)
   27: std::panicking::try::do_call::h7cc9311932bf7101 (0x109b1d7c5)
   28: ___rust_maybe_catch_panic (0x109cbf1fe)
   29: tokio_threadpool::task::Task::run::h8e82860acde7025b (0x109b190d4)
   30: tokio_threadpool::worker::Worker::run_task::h42a44be839b50ddb (0x109b13571)
   31: tokio_threadpool::worker::Worker::run::hac5f32903566b3fb (0x109b12c35)
   32: tokio_trace_core::dispatcher::with_default::h9a38aebbfac6de48 (0x109afa4f4)
   33: <std::thread::local::LocalKey<T>>::with::hec2535a1406bf0cd (0x109afc19e)
   34: <std::thread::local::LocalKey<T>>::with::he9141585252698a5 (0x109afc06c)
   35: <std::thread::local::LocalKey<T>>::with::h83150cfddfa7042f (0x109afbea1)
   36: tokio::runtime::threadpool::builder::Builder::build::{{closure}}::h72a1acc35647081f (0x109afd6d8)
   37: <std::thread::local::LocalKey<T>>::with::hb858a5178ff552cf (0x109b1b0e8)
   38: <std::thread::local::LocalKey<T>>::with::h0db4639a846986f4 (0x109b1aae5)
   39: std::sys_common::backtrace::__rust_begin_short_backtrace::h06fdc74486cb11e3 (0x109b1d46f)
   40: std::panicking::try::do_call::hf8ff3c7c403b189a (0x109b1d82f)
   41: ___rust_maybe_catch_panic (0x109cbf1fe)
   42: <F as alloc::boxed::FnBox<A>>::call_box::h8c8210f4dda0b820 (0x109b14425)
   43: std::sys::unix::thread::Thread::new::thread_start::h2ccd51efe09a6d88 (0x109cbe7bb)
   44: __pthread_body (0x7fff7765a2ea)
   45: __pthread_start (0x7fff7765d248)

 Thread 'tokio-runtime-worker-4' panicked at 'Bad input data provided to execute_block', runtime/src/lib.rs:228

 This is a bug. Please report it at:

         support.anonymous.an

 bad origin: expected to be a root origin

Can you please show the full code of your module and how do you set the value? Via a transaction?

Thank you.
That value generates trasaction from the Extrinsics menu at polkadot.js.org. But, It was solved after rebuilding. Maybe it is my mistake. I'm sorry. I will report if there is anything else.
Here is my source code:
runtime/src/lib.rs
//! The Substrate Node Template runtime. This can be compiled with `#[no_std]`, ready for Wasm.

#![cfg_attr(not(feature = "std"), no_std)]
#![cfg_attr(not(feature = "std"), feature(alloc))]
// `construct_runtime!` does a lot of recursion and requires us to increase the limit to 256.
#![recursion_limit="256"]

#[cfg(feature = "std")]
use serde_derive::{Serialize, Deserialize};
use parity_codec::{Encode, Decode};
use rstd::prelude::*;
#[cfg(feature = "std")]
use primitives::bytes;
use primitives::{ed25519, sr25519, OpaqueMetadata};
use runtime_primitives::{
	ApplyResult, transaction_validity::TransactionValidity, generic, create_runtime_str,
	traits::{self, NumberFor, BlakeTwo256, Block as BlockT, StaticLookup, Verify}
};
use client::{
	block_builder::api::{CheckInherentsResult, InherentData, self as block_builder_api},
	runtime_api, impl_runtime_apis
};
use version::RuntimeVersion;
#[cfg(feature = "std")]
use version::NativeVersion;

// A few exports that help ease life for downstream crates.
#[cfg(any(feature = "std", test))]
pub use runtime_primitives::BuildStorage;
pub use consensus::Call as ConsensusCall;
pub use timestamp::Call as TimestampCall;
pub use balances::Call as BalancesCall;
pub use runtime_primitives::{Permill, Perbill};
pub use timestamp::BlockPeriod;
pub use support::{StorageValue, construct_runtime};

/// The type that is used for identifying authorities.
pub type AuthorityId = <AuthoritySignature as Verify>::Signer;

/// The type used by authorities to prove their ID.
pub type AuthoritySignature = ed25519::Signature;

/// Alias to pubkey that identifies an account on the chain.
pub type AccountId = <AccountSignature as Verify>::Signer;

/// The type used by authorities to prove their ID.
pub type AccountSignature = sr25519::Signature;

/// A hash of some data used by the chain.
pub type Hash = primitives::H256;

/// Index of a block number in the chain.
pub type BlockNumber = u64;

/// Index of an account's extrinsic in the chain.
pub type Nonce = u64;

mod mytemplate;

/// Opaque types. These are used by the CLI to instantiate machinery that don't need to know
/// the specifics of the runtime. They can then be made to be agnostic over specific formats
/// of data like extrinsics, allowing for them to continue syncing the network through upgrades
/// to even the core datastructures.
pub mod opaque {
	use super::*;

	/// Opaque, encoded, unchecked extrinsic.
	#[derive(PartialEq, Eq, Clone, Default, Encode, Decode)]
	#[cfg_attr(feature = "std", derive(Serialize, Deserialize))]
	pub struct UncheckedExtrinsic(#[cfg_attr(feature = "std", serde(with="bytes"))] pub Vec<u8>);
	#[cfg(feature = "std")]
	impl std::fmt::Debug for UncheckedExtrinsic {
		fn fmt(&self, fmt: &mut std::fmt::Formatter) -> std::fmt::Result {
			write!(fmt, "{}", primitives::hexdisplay::HexDisplay::from(&self.0))
		}
	}
	impl traits::Extrinsic for UncheckedExtrinsic {
		fn is_signed(&self) -> Option<bool> {
			None
		}
	}
	/// Opaque block header type.
	pub type Header = generic::Header<BlockNumber, BlakeTwo256, generic::DigestItem<Hash, AuthorityId, AuthoritySignature>>;
	/// Opaque block type.
	pub type Block = generic::Block<Header, UncheckedExtrinsic>;
	/// Opaque block identifier type.
	pub type BlockId = generic::BlockId<Block>;
	/// Opaque session key type.
	pub type SessionKey = AuthorityId;
}

/// This runtime version.
pub const VERSION: RuntimeVersion = RuntimeVersion {
	spec_name: create_runtime_str!("substrate-test"),
	impl_name: create_runtime_str!("substrate-test"),
	authoring_version: 3,
	spec_version: 3,
	impl_version: 0,
	apis: RUNTIME_API_VERSIONS,
};

/// The version infromation used to identify this runtime when compiled natively.
#[cfg(feature = "std")]
pub fn native_version() -> NativeVersion {
	NativeVersion {
		runtime_version: VERSION,
		can_author_with: Default::default(),
	}
}

impl system::Trait for Runtime {
	/// The identifier used to distinguish between accounts.
	type AccountId = AccountId;
	/// The lookup mechanism to get account ID from whatever is passed in dispatchers.
	type Lookup = Indices;
	/// The index type for storing how many extrinsics an account has signed.
	type Index = Nonce;
	/// The index type for blocks.
	type BlockNumber = BlockNumber;
	/// The type for hashing blocks and tries.
	type Hash = Hash;
	/// The hashing algorithm used.
	type Hashing = BlakeTwo256;
	/// The header digest type.
	type Digest = generic::Digest<Log>;
	/// The header type.
	type Header = generic::Header<BlockNumber, BlakeTwo256, Log>;
	/// The ubiquitous event type.
	type Event = Event;
	/// The ubiquitous log type.
	type Log = Log;
	/// The ubiquitous origin type.
	type Origin = Origin;
}

impl aura::Trait for Runtime {
	type HandleReport = ();
}

impl consensus::Trait for Runtime {
	/// The identifier we use to refer to authorities.
	type SessionKey = AuthorityId;
	// The aura module handles offline-reports internally
	// rather than using an explicit report system.
	type InherentOfflineReport = ();
	/// The ubiquitous log type.
	type Log = Log;
}

impl indices::Trait for Runtime {
	/// The type for recording indexing into the account enumeration. If this ever overflows, there
	/// will be problems!
	type AccountIndex = u32;
	/// Use the standard means of resolving an index hint from an id.
	type ResolveHint = indices::SimpleResolveHint<Self::AccountId, Self::AccountIndex>;
	/// Determine whether an account is dead.
	type IsDeadAccount = Balances;
	/// The uniquitous event type.
	type Event = Event;
}

impl timestamp::Trait for Runtime {
	/// A timestamp: seconds since the unix epoch.
	type Moment = u64;
	type OnTimestampSet = Aura;
}

impl balances::Trait for Runtime {
	/// The type for recording an account's balance.
	type Balance = u128;
	/// What to do if an account's free balance gets zeroed.
	type OnFreeBalanceZero = ();
	/// What to do if a new account is created.
	type OnNewAccount = Indices;
	/// The uniquitous event type.
	type Event = Event;

	type TransactionPayment = ();
	type DustRemoval = ();
	type TransferPayment = ();
}

impl sudo::Trait for Runtime {
	/// The uniquitous event type.
	type Event = Event;
	type Proposal = Call;
}

impl mytemplate::Trait for Runtime {

}

construct_runtime!(
	pub enum Runtime with Log(InternalLog: DigestItem<Hash, AuthorityId, AuthoritySignature>) where
		Block = Block,
		NodeBlock = opaque::Block,
		UncheckedExtrinsic = UncheckedExtrinsic
	{
		System: system::{default, Log(ChangesTrieRoot)},
		Timestamp: timestamp::{Module, Call, Storage, Config<T>, Inherent},
		Consensus: consensus::{Module, Call, Storage, Config<T>, Log(AuthoritiesChange), Inherent},
		Aura: aura::{Module},
		Indices: indices,
		Balances: balances,
		Sudo: sudo,
		Mytemplate: mytemplate::{Module, Call, Storage},
	}
);

/// The type used as a helper for interpreting the sender of transactions.
type Context = system::ChainContext<Runtime>;
/// The address format for describing accounts.
type Address = <Indices as StaticLookup>::Source;
/// Block header type as expected by this runtime.
pub type Header = generic::Header<BlockNumber, BlakeTwo256, Log>;
/// Block type as expected by this runtime.
pub type Block = generic::Block<Header, UncheckedExtrinsic>;
/// BlockId type as expected by this runtime.
pub type BlockId = generic::BlockId<Block>;
/// Unchecked extrinsic type as expected by this runtime.
pub type UncheckedExtrinsic = generic::UncheckedMortalCompactExtrinsic<Address, Nonce, Call, AccountSignature>;
/// Extrinsic type that has already been checked.
pub type CheckedExtrinsic = generic::CheckedExtrinsic<AccountId, Nonce, Call>;
/// Executive: handles dispatch to the various modules.
pub type Executive = executive::Executive<Runtime, Block, Context, Balances, AllModules>;

// Implement our runtime API endpoints. This is just a bunch of proxying.
impl_runtime_apis! {
	impl runtime_api::Core<Block> for Runtime {
		fn version() -> RuntimeVersion {
			VERSION
		}

		fn execute_block(block: Block) {
			Executive::execute_block(block)
		}

		fn initialize_block(header: &<Block as BlockT>::Header) {
			Executive::initialize_block(header)
		}

		fn authorities() -> Vec<AuthorityId> {
			panic!("Deprecated, please use `AuthoritiesApi`.")
		}
	}

	impl runtime_api::Metadata<Block> for Runtime {
		fn metadata() -> OpaqueMetadata {
			Runtime::metadata().into()
		}
	}

	impl block_builder_api::BlockBuilder<Block> for Runtime {
		fn apply_extrinsic(extrinsic: <Block as BlockT>::Extrinsic) -> ApplyResult {
			Executive::apply_extrinsic(extrinsic)
		}

		fn finalize_block() -> <Block as BlockT>::Header {
			Executive::finalize_block()
		}

		fn inherent_extrinsics(data: InherentData) -> Vec<<Block as BlockT>::Extrinsic> {
			data.create_extrinsics()
		}

		fn check_inherents(block: Block, data: InherentData) -> CheckInherentsResult {
			data.check_extrinsics(&block)
		}

		fn random_seed() -> <Block as BlockT>::Hash {
			System::random_seed()
		}
	}

	impl runtime_api::TaggedTransactionQueue<Block> for Runtime {
		fn validate_transaction(tx: <Block as BlockT>::Extrinsic) -> TransactionValidity {
			Executive::validate_transaction(tx)
		}
	}

	impl consensus_aura::AuraApi<Block> for Runtime {
		fn slot_duration() -> u64 {
			Aura::slot_duration()
		}
	}

	impl offchain_primitives::OffchainWorkerApi<Block> for Runtime {
		fn offchain_worker(n: NumberFor<Block>) {
			Executive::offchain_worker(n)
		}
	}

	impl consensus_authorities::AuthoritiesApi<Block> for Runtime {
		fn authorities() -> Vec<AuthorityId> {
			Consensus::authorities()
		}
	}
}

runtime/src/mytemplate.rs
use support::{decl_storage, decl_module, StorageMap, dispatch::Result};

use system::ensure_signed;

pub trait Trait: balances::Trait {}

decl_storage! {
    trait Store for Module<T: Trait> as MyStorage {
        Value get(value_getter): map T::AccountId => u64;
    }
}

decl_module! {
    pub struct Module<T: Trait> for enum Call where origin: T::Origin {
        fn set_value(origin, value: u64) -> Result {
            let sender = ensure_signed(origin)?;
            <Value<T>>::insert(&sender, value);
            Ok(())
        }
    }
}

Good, then I will close this.


Brazil timezone - no summertime 2019

Hello all,
this year, Brazil will not have summer time.
I'm using mysql.az_load_timezone() procedure to load timezone tables in mysql database, but since yesterday I'm facing problems converting dates between UTC and "America/Sao_Paulo" (using convert_tz() function). The resulting time is one hour ahead of the real time in Brazil.
My understanding is that this procedure is considering that brazil summertime has started yesterday, but actually Brazil will not have summetime this year.
Is it possible to check it ?
Thanks in advance
Valmir

@ValmirCosta Hi, thanks for reaching out to us. Could you please send us the document if you are referring to something for the product? Thanks.

@YutongTie-MSFT
Sorry, but I don't get your point.
My request is not clear ?

@ValmirCosta I just want to check if you are referring any document for this issue, since this forum is for Documentation. ^^
I thought you are referring the function az_load_timezone() in Azure MySQL Database Service. I will hand this to a right person for help.

My bad.
I was following the doc below, but this is not a documentation problem. I will raise a ticket within Azure portal.
Thanks
https://docs.microsoft.com/bs-latn-ba/azure/mysql/howto-configure-server-parameters-using-cli#working-with-the-time-zone-parameter

@ValmirCosta Thanks. Great, could you please share the ticket number? I can track it also to see if further help needed. Are you good to close this?

@YutongTie-MSFT
You can close this, thanks

@ValmirCosta
We will now proceed to close this thread. If there are further questions regarding this matter, please respond here and @YutongTie-MSFT and we will gladly continue the discussion.


Error during install v0.1.5

I get the following error when I run install on CentOS 5.11.  Looks like it should be 'run.dat' but I can't find where this is referenced in the code.
running install
running build
running build_py
creating build
creating build/lib
creating build/lib/hotspotd
copying init.py -> build/lib/hotspotd
copying cli.py -> build/lib/hotspotd
copying main.py -> build/lib/hotspotd
error: can't copy 'un.dat': doesn't exist or not a regular file

@aossey Sorry for the delay, for some weird reason I've stopped getting email notifications for bug raised here. The run.dat is just a template configuration file for hostapd. It is later used to create the actual config file based on your SSID, etc. This should be in the same location as main.py

@aossey I'm closing this issue. Let me know if you face any issues and I'll reopen it.


Upgrade semver package Spec to SimpleSpec

What was wrong / missing?
semantic_version was throwing deprecation warnings about the Spec object being put out of order soon.
How was it fixed / added?
Upgraded the package and replaced existing usages with the new SimpleSpec object.
Cute Animal Picture

LGTM - also looks like time for a new release :)


[alicloud-cpi] Bump CPI to v39.0.0

Due to the fact that AliCloud CPI cannot get auto-bumped, this PR should bump it to the latest version.
https://github.com/cloudfoundry-incubator/bosh-alicloud-cpi-release/releases/tag/v39.0.0

@benjaminguttmann-avtq do you have any more context on why the AliCloud CPI cannot get auto-bumped? Because was just about to ask if you might be interested in adding auto bumping to the pipeline: https://github.com/cloudfoundry/bosh-deployment/blob/master/ci/pipeline.yml#L110

@rkoster please check this PR for more information => https://github.com/cloudfoundry/bosh-deployment/pull/394

Fixed in: https://github.com/cloudfoundry/bosh-deployment/commit/38234c8f79d6e78ef81e779cd4666ef24465ddf0
It works: https://github.com/cloudfoundry/bosh-deployment/commit/b10a3d19702e55ac2ace56674184b747657c2df0

Even better, thx @rkoster


test_dynamic_schemas_updated failure

https://drone-publish.rancher.io/rancher/rancher/198/1/2
=================================== FAILURES ===================================
_________________________ test_dynamic_schemas_update __________________________
request = <FixtureRequest for <Function 'test_dynamic_schemas_update'>>
admin_mc = <core.conftest.ManagementContext object at 0x7f74e1c3c828>
@pytest.mark.nonparallel
def test_dynamic_schemas_update(request, admin_mc):
assert not schema_has_field(admin_mc)
eks_schema = admin_mc.client.by_id_dynamicSchema(
'amazonelasticcontainerserviceconfig')
new_field = copy.deepcopy(eks_schema.resourceFields['displayName'])
new_field.description = 'My special field.'
setattr(eks_schema.resourceFields, 'mySpecialField', new_field)
admin_mc.client.update_by_id_dynamicSchema(eks_schema.id, eks_schema)
request.addfinalizer(lambda: cleanup_extra_field(admin_mc))
> assert schema_has_field(admin_mc)
E assert False
E + where False = schema_has_field(<core.conftest.ManagementContext object at 0x7f74e1c3c828>)
test_dynamic_schemas.py:20: AssertionError

This appears to be a one time failure based on using https://github.com/rmweir/FindBuilds to scan both PR and publish builds from drone.


DPL-299 [BUG] 404 when NPG update lane qc state if requests greater than 1

Describe the bug
As PSD we need to fix a bug, whereby when NPG send a message to update the qc state of a Lane, a 404 is returned if there is more than one sequencing request on the lane (e.g. example we saw was where one had been cancelled and a new one created). Check needs to be changed so is only looking for one active request.
RT Ticket Number
742604
To Reproduce
Steps to reproduce the behaviour:

Create more than one sequencing request for a lane, cancelling one and leaving a second active
Trigger the action_for_qc_state method in the AssetsController
The before action on AssetsController calls the find_request method which errors because requests.one? is false for the lane

Expected behaviour
The manual_qc state for the lane then does not get updated to Pass
Additional context
See this bit of code in Assets controller (starting line 66) in Sequencescape:
def find_request
  requests = @asset.requests_as_target
  raise ActiveRecord::RecordNotFound, "Unable to find a request for Asset: #{params[:id]}" unless requests.one?

  @request = requests.includes(batch: { requests: :asset }).first
end

requests does not filter to return only active requests. Also, error message is confusing, as we do find requests.
Maybe 'Unable to identify a suitable single request for Asset' or similar.

irb(main):003:0> Lane.find(37415542).requests_as_target.count
=> 2


drawPage for embedded PDF seems to lose hyperlink annotations

I am generating a bunch of PDF documents using puppeteer, and then compiling them into one large PDF using pdf-lib. The links from the individual PDFs seem to be lost when embedding them into the main PDF via drawPage
Here is some psuedocode detailing the problem:
const myPdfToEmbed = const pdfDoc = await PDFDocument.load(handoutPdfBytes);
fs.writeFileSync("./test.pdf", await myPdfToEmbed.save()); // This PDF has clickable links
const finalDoc = await PDFDocument.create();
const page = finalDoc.addPage();
const embeddedPage = await finalDoc.embedPage(myPdfToEmbed, { ... });
page.drawPage(embeddedPage);
fs.writeFileSync("./test2.pdf", await finalDoc.save()); // This PDF does not have clickable links

I'm not sure if I'm just using the library wrong or if there's a bug  :) Happy to provide any additional info you need

Hello @Mattykins! Can you please share some PDFs and a complete script that I can use to reproduce the issue?

I'm going to close this for now. Please feel free to reopen with additional information.


Replacing print() with Python logging facilities.

Thanks @estribiyo for the pull request, I reviewed the PR and I approve of the change.
I just need to change 1 of the tests in the test suite to accomodate for your changes.
I will merge your PR as soon as I update the test.
Thank you very much for your contribution and feel free to make new contributions, remarks etc... whenever you please.
SekouD.


Test smoke test percentile logic

Test

The next few commit will be changes to the main code base to test the smoke-test-verify logic.

Test 1: Add a blog post and update blogpost.yaml
Expected: pass

Test 2: delete src/docs/getting-started/*
expected: fail

Test 2: Succesful
Test 3: delete src/docs/java-sdk/*
Expected result: pass


require minimum of TS 4.7

v5 will need TS4.7 or greater to support the object syntax properly.

I believe the ts version in the repository of react-query should always use the latest version (or any the maintainers feel okay with!), since it won't affect the developers' land

If we use the latest version and use features of the latest version (4.9), like satisfies, the .d.ts files that we ship as type definitions will not work with versions prior to 4.9. we could do differential transpiling and ship different types for lower TS versions but that effort is not worth it imo.


[resolves #41] Merge in fluxible plugin and rename to fluxible-router

This combines the flux-router-component and fluxible-plugin-routr to form a cohesive routing solution for fluxible apps. flux-router-component relied too much on the fluxible interface to be real useful otherwise. This should make it easier for a developer to get routing up and running on a fluxible application without have to jump between multiple instructions to get a full solution up and running.

We're going to make some other changes in the API for fluxible-router before we release it. So, closing this PR for now.


UITextView autoCapitalizationType is always Words

Hi szweier,
The mentions library has overwritten my UITextView autoCapitalizationType type. It always capitalizes Words even though I have set my UITextView to Sentences. [For the auto-suggestion words]
I have tested with the sample in this project.

Could you please assist?
Thank you.

Looks like something specific to iOS 13, I'm looking now.

Hi szweier,
It is working perfectly. Thank you for helping.

Thanks for confirming.


[SPARK-48503][SQL] Fix invalid scalar subqueries with group-by on non-equivalent columns that were incorrectly allowed

What changes were proposed in this pull request?
Fixes CheckAnalysis to reject invalid scalar subquery group-bys that were previously allowed and returned wrong results.
For example, this query is not legal and should give an error, but instead we incorrectly allowed it and it returns wrong results prior to this PR (full repro with table data in the jira):
select *, (select count(*) from y where y1 > x1 group by y1) from x;

It returns two rows, even though there's only one row of x. The correct result is an error, because there is more than one row returned by the scalar subquery.
Another problem case is if the correlation condition is an equality but it's under another operator like an OUTER JOIN or UNION. Various other expressions that are not equi-joins between the inner and outer fields hit this too, e.g. where y1 + y2 = x1 group by y1. See the comments in the code and the tests for more examples.
This PR fixes the logic which checks for valid vs invalid group-bys. However, note that this new logic may block some queries that are actually valid, for example a + 1 = outer(b) is valid but would be rejected. Therefore, we add a conf flag that can be used to restore the legacy behavior, as well as logging for when the legacy behavior is used and differs from the new behavior. (In general, to accurately run valid queries and reject invalid queries, the check must be moved from compile-time to run-time - see https://issues.apache.org/jira/browse/SPARK-48501.)
This is a longstanding bug. The bug is in CheckAnalysis in checkAggregateInScalarSubquery. It allows grouping columns that are present in correlation predicates, but doesn’t check whether those predicates are equalities -  because when that code was written, non-equality correlation wasn’t allowed. Therefore, this bug has existed since non-equality correlation was added (~2 years ago).
Why are the changes needed?
Fix invalid queries returning wrong results
Does this PR introduce any user-facing change?
Yes, block subqueries with invalid group-bys.
How was this patch tested?
Add tests
Was this patch authored or co-authored using generative AI tooling?
No

@agubichev @andylam-db @cloud-fan

thanks, merging to master!


Error with latest commit and sb option

Hi there,
I updated to the latest commit and now have this error. (not sure what commit I was using before that - a month old at least)
INFO    Found 18 rooms
ERROR   Exception in get_search_page_info_rectangle
Traceback (most recent call last):
  File "./airbnb.py", line 2059, in ws_search_rectangle
    listing.property_type = json_listing["property_type"]
KeyError: 'property_type'
ERROR   Error
Traceback (most recent call last):
  File "./airbnb.py", line 1186, in __search_loop_bounding_box
    rectangle_zoom, flag)
  File "./airbnb.py", line 1271, in __search_rectangle
    rectangle, rectangle_zoom, flag)
  File "./airbnb.py", line 2059, in ws_search_rectangle
    listing.property_type = json_listing["property_type"]
KeyError: 'property_type'
INFO    Searching by bounding box - logged

Any idea what may have caused this issue?
Thank you

Hi Laura,
I reproduced this today. I suspect a change in the Airbnb web site format, but I will try this evening and let you know.
Tom

Airbnb had indeed changed the format. I have fixed the bug but no longer get property_type information. To be clear, the script does still get room_type (Entire home/apt, Private room, or Shared room), but does not get property_type (apartment, tree house, etc), which it did not get anyway until recently.

That works great again!
I was not using the property_type anyway.

Do we know what is the list of "property_type_id":x
It would actually be interesting to know which are "holiday houses" or anything that is tourist related.


support declaration type changes (e.g. func to var)

Codecov Report

Merging #5 into master will increase coverage by 0.82%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   16.01%   16.84%   +0.82%
==========================================
  Files           7        7
  Lines        1336     1342       +6
==========================================
+ Hits          214      226      +12
+ Misses       1117     1114       -3
+ Partials        5        2       -3

Flag
Coverage Δ

#
16.84% <ø> (+0.82%)
:arrow_up:

#go111x
16.84% <ø> (+0.82%)
:arrow_up:

#gotip
16.84% <ø> (+0.82%)
:arrow_up:

#linux
16.84% <ø> (+0.82%)
:arrow_up:

#osx
16.84% <ø> (+0.82%)
:arrow_up:

Impacted Files
Coverage Δ

changes.go
84.61% <ø> (ø)
:arrow_up:

changetype_string.go
60% <ø> (ø)
:arrow_up:

api.go
0% <ø> (ø)
:arrow_up:

cmd/gocompat/compare.go
67.71% <0%> (+2.42%)
:arrow_up:

convert.go
97.67% <0%> (+3.87%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e843fb...3fbd971. Read the comment docs.


Allow postgres subscriptions to be configured in publish only mode

Allows postgres subscription transport to be used in processes that perform publish operations only
see https://github.com/ChilliCream/graphql-platform/issues/6511
Closes #6511

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

maybe too DRY? not sure if its best to duplicate some of the code rather than reuse it the way i have here

I've just had another thought - the ITopicSender should participate in transactions (enlist) so the event is published when related data is committed to the database. Obviously the receiver needs to be independent of any transaction and pooling as it currently is

I've just had another thought - the ITopicSender should participate in transactions (enlist) so the event is published when related data is committed to the database. Obviously the receiver needs to be independent of any transaction and pooling as it currently is

Yes i agree. this would solve a couple of issues. e.g:

When you are in a transaction and you store an update and notify about the update, it's likely that the message is received on the consumer side before the data is actually updated in the database
When your transaction fails, the notification still arrives.

There are a couple of issue on the implemntation side with this though:

We currenlty batch the send notifications for higher throughput on inserts (it's like 10x more throughput)
The ITopicEventSenver runs decoupled from the context of the request

I have talked with @michaelstaib about this before, but we only really cut the topics ones in a discussion. Maybe we can pick this up again. There are a few adjustments that we would have to make to make this work.

We discussed this internally too and it is tricky to reason about. Leaving it as is is simpler and we can easily work around it. Using a different backend like redis you would not get any guarantees on transaction related dispatch

@williamdenton  Thanks for the contribution!

I'm guessing this will be in 13.6 rather than 13.5.x?


Fixes to create_ecg_epochs.

Closes https://github.com/mne-tools/mne-python/issues/3541

@jasmainak ok for you?

I ended up simplifying it quite a bit. It was previously quite inconsistent in the way it was picking the channels with different parameters, hence the entry in API section of whats_new.

maybe throw a more explicit error if create_ecg_epochs(raw, keep_ecg=True) saying "keep_ecg can be True only if the ECG channel is created synthetically".
Otherwise LGTM and great about the simplifications!

Current coverage is 87.30% (diff: 87.50%)

Merging #3551 into master will increase coverage by <.01%

@@             master      #3551   diff @@
==========================================
  Files           341        341
  Lines         60067      60069     +2
  Methods           0          0
  Messages          0          0
  Branches       9174       9172     -2
==========================================
+ Hits          52439      52441     +2
- Misses         4884       4887     +3
+ Partials       2744       2741     -3

Powered by Codecov. Last update 8ea7206...8faac24

+1 for merge

LGTM, merging! Thanks a ton @jaeilepp for the fixes


Tooltip Component

Looking at front-end #46, we're using a few different tooltip plugins (Bootstrap and tooltipsy). Should we introduce a CF tooltip component? If yes, I'll offer to write it.
A couple of questions:

Have we settled on design standards for tooltips? @Scotchester @mebates @stephanieosan @benguhin
How do we want to write JS CF components going forward? My gut reaction is to write them as UMD style jQuery plugins.

The design standard hasn't been settled. @huetingj has been working on it recently: https://github.com/cfpb/design-manual/issues/139

Sounds like good timing then! Once this is standardized, let's make it a CF component so we're not constantly restyling other libraries.

Ooooooh, tooltips of our own!

@ascott1 You could probably start hacking out the functionality even if the design isn't finalized yet. Also: great idea!

I will re-open the design tooltips conversation to try to get a solution for you, @ascott1 :)

This comment by @stephanieosan gives a really thorough description of the desired implementation.

And we have a repo. :tada:

The Design team has killed tooltips. RIP, we hardly knew ye. @ascott1 is our repo deprecation process documented somewhere or can I just go ahead and take a stab at it?

Can this be closed? @jimmynotjim @ascott1

Good catch - closing!

👋 old friends! love it when you pop up in my email box. RIP tooltips, but good.

Hi @mebates!


Tests: XFAIL test/stdlib/StringCreate.swift

XFAIL test/stdlib/StringCreate.swift on the back deployment bots until the failures there can be investigated further.

@swift-ci please test


Add upsert code samples

Description of changes:

Add upsert code samples.
Add Release Notes or update correct version in some README

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Got 2 approvals from zhihaoli and renzhong


Disable auto index creation

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines
[x] Tests for the changes have been added (for bug fixes/features)
[x] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behavior? (You can also link to an open issue here)
Attempting to add documents to an index that does not exist will fail with an error. Indices must be created explicitly before adding documents.
See https://github.com/marqo-ai/marqo/pull/516

What is the new behavior (if this is a feature change)?
Yes. Users must ensure an index exists before documents are added, or must handle the error. Code that relies on the removed automatic index creation behaviour will fail.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Yes. Users must ensure an index exists before documents are added, or must handle the error. Code that relies on the removed automatic index creation behaviour will fail.

Other information:

You may want to squash the commits before merging

You may want to squash the commits before merging

good point - I've disabled other merge methods


Removing incorrect statement under 'Public Preview'

Under the 'Public preview limitations' section, there is a statement that was probably duplicated from the item below.
Where it reads: "To be backwards compatible with the current version of group writeback, when you enable group writeback, all existing Microsoft 365 groups are written back and created as distribution groups, by default. This behaviour can be modified by following the steps detailed in Modifying group writeback."
It should read only: "To be backwards compatible with the current version of group writeback, when you enable group writeback, all existing Microsoft 365 groups are written back and created as distribution groups, by default."
As can be seen under the same document, the next section ("when you disable...") also mentions the same wording.
In practical terms, you cannot modify the initial writeback behaviour and even with the mentioned configuration, the groups will be written back.
Confirmation can be seen under IcM 328462189.

#sign-off

Learn Build status updates of commit aff41cb:
:bulb: Validation status: suggestions

File
Status
Preview URL
Details

articles/active-directory/hybrid/how-to-connect-group-writeback-v2.md
:bulb:Suggestion

Details

articles/active-directory/hybrid/how-to-connect-group-writeback-v2.md

Line 54, Column 86: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL.  Otherwise, remove the view parameter. URL: /graph/api/group-get?tabs=http&view=graph-rest-beta
Line 70, Column 83: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL.  Otherwise, remove the view parameter. URL: /graph/api/resources/directorysetting?view=graph-rest-beta
Line 87, Column 67: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL.  Otherwise, remove the view parameter. URL: /Exchange/plan-and-deploy/prepare-ad-and-domains?view=exchserver-2019#how-do-you-know-this-worked
Line 95, Column 315: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL.  Otherwise, remove the view parameter. URL: /Exchange/plan-and-deploy/prepare-ad-and-domains?view=exchserver-2019
Line 126, Column 9: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/exchange/recipients-in-exchange-online/manage-distribution-groups/manage-distribution-groups' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Fix flow error in reduceAssertionObject

fixes #219

Thanks @fernandopasik and thanks @pascalduez for the review!

@blainekasten could you please release a patch? That breaks my release process :)
Would be super rad.

@pascalduez sure thing, 1s

You are welcome @blainekasten!


Add API Documentation

To resolve comments raised in #19.

Docs can be generated with npm run doc. This will output the jsDoc to doc/index.html which can be opened in a web browser.
See commit feffecf5fbc98144275d59d94c813908d8fae0f9 for further information.


[ADD] Change TON explorer

To have a better overview of txs on TON please change to tonviewer.com

QA done.


feat(Table): Add scroll snapping

Adds iui-scroll-snapping mixin to .iui-table-body to enable Y-axis scroll snapping. Closes #378.

@veekeys Please take another look at the new changes. The approach is changed quite a bit but it's more versatile now.

@veekeys Please take another look at the new changes. The approach is changed quite a bit but it's more versatile now.

Wouldnt it be you if from simple thing wouldnt end up with some sass magic :D
I guess the only question would have what we would do if wanted to have also X snapping. But should be able to still reuse same mixin with some more params.
In general, you can merge this one. Should be fine..


After upgrading to identity v3 - Simple usage of InteractiveBrowserCredential is throwing  uninitialized_public_client_application

Package Name: @azure/identity
Package Version:  3.3.2 or 4.0.0 (was working while with 2.1.0)
Operating system: Windows
[ ] nodejs

version:  16.20.2

[ ] browser

name/version: Edge/ 119.0.2151.44 (also chrome)

[ ] typescript

version:5.2.2

Describe the bug
After upgrading to identity v3 - Simple usage of InteractiveBrowserCredential is throwing
uninitialized_public_client_application: You must call and await the initialize function before attempting to call any other MSAL API. For more visit: aka.ms/msaljs/browser-errors
To Reproduce
Steps to reproduce the behavior:

this.credential = new InteractiveBrowserCredential({
...this.interactiveCredentialOptions,
tenantId: this.authorityId,
clientId: this.interactiveCredentialOptions?.clientId ?? this.cloudInfo.KustoClientAppId,
redirectUri: this.interactiveCredentialOptions?.redirectUri ?? http://localhost:${this.getRandomPortInRange()}/,
})
const response = await this.credential.getToken(this.scopes, {
requestOptions: {
timeout: this.timeoutMs,
},
tenantId: this.authorityId,
});

https://github.com/Azure/azure-kusto-node/blob/e6eb8e5869aae255d4d42ca3df93ac009ce234ca/packages/azure-kusto-data/src/tokenProvider.ts#L151
Expected behavior
Get token
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
This is msal code usage - so it means it is handled only by the Identity library and therefore must be a bug there.
Seems like there should be a new API - credential.initialize in order for this to work.

Found the issue - i was taking dependency on old msal/common

@ohadbitt, can you elaborate on how you solved this issue? I'm dealing with the problem you described initially but can't seem to solve it.


[SPARK-43569][SQL] Remove workaround for HADOOP-14067

What changes were proposed in this pull request?
The pr aims to remove workaround for HADOOP-14067.
https://issues.apache.org/jira/browse/HADOOP-14067
https://issues.apache.org/jira/browse/SPARK-32256
Why are the changes needed?
1.According to the PR description, this doesn't happen in Hadoop 3.1.0 and above; Now spark support hadoop version: 3.2.2+ and 3.3.1+
2.Make code clean.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.

1.https://issues.apache.org/jira/browse/HADOOP-14067

2.https://issues.apache.org/jira/browse/SPARK-32256

Merged to master. Thank you, @panbingkun .

@panbingkun @dongjoon-hyun Wouldn't the workaround still be required with 3.0.x versions of Hadoop?  Or are those versions no longer supported by Spark?

@panbingkun @dongjoon-hyun Wouldn't the workaround still be required with 3.0.x versions of Hadoop? Or are those versions no longer supported by Spark?

In the Spark latest version, Hadoop 3.0.x is no longer supported.


Archive chat not working

We had tested in chrome console e we get this error.

WhatsApp version: 2.3000.1011957409
WA-JS version(s): 3.0.0
Browser: Chrome 121
OS: Windows 11
MultiDevice (BETA): yes

Fixed by https://github.com/wppconnect-team/wa-js/commit/d58e6d734783b9d9660698d6c5745a28775ed2bd


Astromine 1.9.0 falling from earth causes disconnect and no reconnect

Fabric API 0.19.0+build398-1.16
MC 1.16.2
Dedicated server
when falling from earth, the moment  you transition back to earth you are disconnected from server and then unable to log back in. I had to delete player data in order to log back in.
here is the log from the moment that the disconnect happens
https://hastebin.com/uwufitihaj.makefile

end me

ok

Your hastebin link seems to be empty, if you could provide us with the log that would be great!

Preferably avoid hastebin; it's been doing all sorts of cursed things lately, especially magically emptying itself.

Vini ur empty

woah me too

Hastebin go boom
Here is paste elsewhere
https://paste.gg/p/anonymous/9139d4754a20436fbc7d7b2d55a2e2e5


stdout ergonmics for tokens on entity creation

ziti version: v0.28.1
Problem:
Currently, there are generally two ways to dump tokens to stdout when creating an edge entity that supports enrollment. Both require some finesse to get just the enrollment token, which complicates scripts that wrap the cli.
Examples:

ziti edge create edge-router "test_router" --jwt-output-file /dev/stdout | tail -n 2 | head -n 1
ziti edge create identity device "test_identity" --output-json --jwt-ouput-file /dev/stdout | jq '[obtuse_filter]'

In the second case, it may be better to instead list the entity with json output to capture the enrollment token directly with jq, but that carries its own complexity due to the API returning a limited number of results which is error prone in scripting contexts.
Suggestion:
Provide a flag that allows dumping directly to stdout and suppresses other superfluous output.

Defaulting to stdout when no --output-file is provided is a good improvement for human operators.
For scripting/programming, I suggest we follow a similar pattern to the git tooling, which provides --porcelain, which offers stable parsable output. --output-json is a reasonable option for complex data but may be overkill for simple output.


logging: add AppStackLocationFilter, include in default flask configuration

https://trello.com/c/U24anuJR/58-improving-profiling-and-live-debuggability
This annotates a log record to include extra information on the first stack frame that's within the app, as it's often more illuminating than the location deep within a utility or library function where the log message is actually output.
As configured here initially, only include this information for WARNING or ERROR messages or messages originating from a "sampled" request.

Awesome feature? Is there going to be documentation for this? Would be good to make a note of what it is and what the log key is somewhere in the manual.

There will be once it's in and I'm sure it does exactly what I want.

Looking over the code it makes sense to me

Got is_sampled test coverage now too.


Fix typo in MIGRATE-2.0-to-3.0.md

Type

[x] Bug Fix
[ ] New Feature
[ ] Sample

Related Issues?
No related issues
What is in this Pull Request ?
Just a small typo fix, missing a P in Get-PnPRetentionLabel

Thanks @jackpoz !


Binding Issue

Hi,
I got this error when i tried to intregrate this plugin in my web app.
knockout.js?ver=6:72 Uncaught TypeError: Unable to process binding "tinymce: function (){return string_of_html }"
Message: $(...).tinymce is not a functionupdate @ knockout-tinymce.js?ver=6:38function.a.B.i @ knockout.js?ver=6:72Pc @ knockout.js?ver=6:51Qc @ knockout.js?ver=6:51aa @ knockout.js?ver=6:50a.m.a.B @ knockout.js?ver=6:49(anonymous function) @ knockout.js?ver=6:72q @ knockout.js?ver=6:11m @ knockout.js?ver=6:71k @ knockout.js?ver=6:69g @ knockout.js?ver=6:69k @ knockout.js?ver=6:69a.Rb @ knockout.js?ver=6:75(anonymous function) @ require-campaigns.js?v=1:96j @ jquery.js:3099fireWith @ jquery.js:3211ready @ jquery.js:3417I @ jquery.js:3433
knockout-tinymce.js?ver=6:20 Uncaught TypeError: $element.tinymce is not a function

Hey @derekang, would you mind showing me the code you're using to integrate this plugin into your web app?
Also, note that you do need to include knockout.js >= 3.4.0, tinymce.js >= 4.1.7 and jQuery >= 2.1.1 for this plugin to work. For example, you need to do something like this:
<script src="//code.jquery.com/jquery-2.2.4.min.js" integrity="sha256-BbhdlvQf/xTY9gja0Dq3HiwQF8LaCRTXxZKRutelT44=" crossorigin="anonymous"></script>
<script src="//cdnjs.cloudflare.com/ajax/libs/knockout/3.4.0/knockout-min.js"></script>
<script src="//cdn.tinymce.com/4/tinymce.min.js"></script>
<script src="/path/to/knockout-tinymce.js"></script>

Closed this due to lack of response.


Any chance for a 3.5.11 release?

Hey y'all, I was just hoping we might see a release for 3.5.11 to pick up some bug fixes that are already in the 3-stable branch. Thanks in advance!
Environment

Ruby 2.5.1
Rails 4.2.10
Devise 3.5.10

Current behavior
Syntax errors that were fixed in the 3-stable branch here: https://github.com/plataformatec/devise/commit/bddf051bfb4213114a3531708ccd68729c4ecef9
Expected behavior
No syntax errors.

Version 3 is not under maintenance anymore. We accepted the patch so it's possible to install it from GitHub but we don't intend to release a version for it. https://github.com/plataformatec/devise/pull/4749#issuecomment-356366226


Update README.md

I've made a few small tweaks.
@splendidbug can you check if the README makes sense here?
In addition, why do you show "embedding_dimension" 1024? What is the default setting you use? Because it seems that it's 1024+Bool, which is okay but it would at least deserve 1-2 sentences to explain the default or the choices users have?
WDYT?

I've made a few small tweaks.
@splendidbug can you check if the README makes sense here?
In addition, why do you show "embedding_dimension" 1024? What is the default setting you use? Because it seems that it's 1024+Bool, which is okay but it would at least deserve 1-2 sentences to explain the default or the choices users have?
WDYT?

The defaults are 3072 and Bool. I'll change the default to 3072 and Float32. I'll also add the default values in README. Thanks!

I'm merging the PR. I'll update kwarg names and the same will be reflected in readme in the next PR


a vertical dotted line at the Fermi level (FL) for dos plot and a horizontal line at FL for band  very much needed for explain the electrical conductivity very clearly in a paper

This feature has just been implemented and is available from the Master branch of Sumo. Use the --zero-line argument to enable the dashed line at the reference energy. If you need to shift the reference energy away from the default VBM/EFermi position this can be done with the --zero-energy argument.
I am glad to hear this will be useful for your research!


docs: update docs for release 0.4.3

Signed-off-by: Starnop<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
Welcome to the release 0.4.3 of Dragonfly.
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #785 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #785   +/-   ##
=======================================
  Coverage   39.19%   39.19%
=======================================
  Files         108      108
  Lines        6309     6309
=======================================
  Hits         2473     2473
  Misses       3630     3630
  Partials      206      206

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24aa469...2c738e7. Read the comment docs.

request a review.


Option to change units

Hi! Just started using this integration together with local Tibber Pulse through MQTT, seems to be working great! Thanks for your awesome work here!
Would you consider adding an option to choose kW and kVAR instead of W and VAR as units?
Thanks again!

My approach has been to use the native unit of measurement since this concept was introduces in HASS. My hope was that the introduction of native unit in HASS sensor was the first step in making the display unit more configurable in HASS. You can currently use a template sensor to do the conversion into a new entity.

Sure, I know and thanks for your reply. I agree and I understand your point of view. I'm also hoping that there will be a native way of changing units, and it seems like it is finding it's way. Started with weather units, and more and more seem to follow. Let's hope it finds it way to power- and energy sensors as well! Ref here.

Closing issue as we hope for native support of unit conversion.


fport: Fix triggeredBy/storeAs/etc using :=. Fixes #1444

This is a forward port of https://github.com/sbt/sbt/pull/2908
Fixes #3058

Closing this in favor of https://github.com/sbt/sbt/pull/3076


Report: hook_add / hook_source process duplicated at only once next start after plugin install completed.

Warning:  I will close the bug issue without the minimal init.vim and the reproduce ways.
The problem is low level, but I will report it.
Problems summary
Vim start with dein, hook_add / hook_source processed two count.
Problem happen only once next start after plugin install completed.
Problem detail write to reproduce step section.
Expected
dein's hook run only once hook_add / hook_source
(without user `call dein#call_hook('xxx') )
Environment Information (Required!)

dein.vim version(SHA1): e36677aada28fcb97c8fbfb49342e8a33c5b4b7b

OS: Windows 10 Pro (21H1 latest 2021/09/08)

Vim/neovim version:

VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Sep  2 2021 08:19:11)
MS-Windows 64 ビット GUI/コンソール 版 with OLE サポート
適用済パッチ: 1-3394

build in vim-tux project
Provide a minimal .vimrc with less than 50 lines (Required!)
https://github.com/tsuyoshicho/testvimrc.vim/tree/test/deinadddup
Minimal vimrc and reproduce log in this branch.
The reproduce ways from Vim starting (Required!)

start vim with minimal reproduce branch testvimrc.vim
1st time boot, install plugins
start vim with minimal reproduce branch testvimrc.vim
2nd time boot, problem reproduce
type :echo g:test_mb_addcnt and :echo g:test_mb_srccnt
contrast check :echo g:test_mb_postsrccnt
start vim with minimal reproduce branch testvimrc.vim
3rd or more time boot, problem no reproduce

these g:test_mb_* variables define and work in test.toml
count up per process hook_*
expect work: all set 1
Screen shot (if possible)
nothing.
Upload the log messages by :redir and :message (if errored)
https://github.com/tsuyoshicho/testvimrc.vim/blob/test/deinadddup/log/result.txt
PP g:test_mb_addcnt:
g:test_mb_addcnt = 2

PP g:test_mb_srccnt:
g:test_mb_srccnt = 2

PP g:test_mb_postsrccnt:
g:test_mb_postsrccnt = 1

Thanks a lot!


Nested Values Disappear when using StrictMode

Describe the bug
I have a problem that if I use it with react-aria's TextField they don't work (the TextField receives undefined.)
Based on The discord discussion and my local testing, it seems to be a StrictMode problem.
Your minimal, reproducible example
https://stackblitz.com/edit/vitejs-vite-hwpxmr?file=package.json,src%2FApp.tsx,src%2Findex.css&terminal=dev
Steps to reproduce
Open the reproduction link and see the inputs are empty.
Expected behavior
The inputs should be showing values (they have values set in the form.)
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform
OS: Linux
Browser: Chrome
Version: 124.0.63
TanStack Form adapter
react-form
TanStack Form version
^0.19.2
TypeScript version
^5.4.5
Additional context
No response

With some testing, this only appears to happen with nested values: name="one.two" type deal.
Investigating now, this is a huge p1 issue

OK, I think I narrowed it down to a single LOC issue. Making a PR momentarily, once I verify that the rest of our tests pass

Fixed in #686 with tests to verify. Thanks for reporting and filing!

I am also seeing an issue with StrictMode, specifically with using mode=array with a list of strings. In StrictMode, adding a new value with pushValue appears to not do anything. Under the hood, I believe it is adding the value and then immediately reverting the field value to whatever the previous value was.
I took the array example from the docs and changed it in the following ways:

Wrap App in StrictMode.
Change [Array<{ name: string; age: number }>](people: [] as Array<{ name: string; age: number }>) to people: [] as Array<String>

Clicking on the "Add person" button does not result in a new row.
Also of note is when you leave the people value to be an array of objects, StrictMode works fine. Its only when the underlying value is an array of strings that it breaks. If I had to guess, I'd say there is a value check somewhere that is failing since an empty string is "falsey", but I have no idea what the root cause would be.
Reproduction case: https://stackblitz.com/edit/tanstack-form-rxy9kq?file=src%2Findex.tsx&preset=node

@dlindahl I believe what you're describing is a separate issue that pertains to pushValue. Can you make a new issue?


FileSet extends sc:Intangible (according to documentation) but is subclass of sc:CreativeWork (according to .ttl)

According to the specification (/docs/croissant-spec.md, Line 702), FileSet extends sc:Intangible, but according to the ontology-file (docs/croissant.ttl, Line 16) it is a subclass of sc:CreativeWork.
croissant:FileSet a rdf:Class ;
  rdfs:label "FileSet" ;
  rdfs:comment "A set of homogeneous files extracted from a container, optionally filtered by inclusion and/or exclusion filters." ;
  rdfs:subClassOf schema:CreativeWork .

Which definition is the right one?

It seems that the specification is right and that the ontology file is going to be corrected: https://github.com/mlcommons/croissant/pull/634/files .
I don't understand why, indeed.

This is fixed now


Add batching for mod downloads

This will group mods in batches of 5 and attempt to download all of them. If the mod is downloaded, it will remove it from the batch and add another mod which will then begin downloading.

Very neat, though I tried this change and it seems like the mods are only downloaded one at a time, so the other bars just idle. Did it work with your Steam?
Also just personal preference, but I feel like 5 is too many at least for the current UI :p


OSSM-1107 Add jwksResolverCA field

This PR is related to OSSM-1107 and Istio PR 17176
Add a new 2.1 SMCP spec field as
.spec.security.jwksResolverCA

Signed-off-by: Yuanlin Xu<EMAIL_ADDRESS>

Tested this field using new operator image with CRD changes.
After applying a SMCP CR .spec.security.jwksResolverCA: [sample CA content],
a CM (pilot-jwks-extra-cacerts-basic) is created with the extra.pem data

Sorry, just now I realized this merged into 2.1 branch, and we are in code freeze. I blindly thought it was targeting 2.2 when I added the ok-to-merge label.
@rcernich How do you want to proceed? Should we revert this one and reopen it after 2.1.2 is tagged?


Datetime inputFormat mm/dd/yyyy allows entry of 02/3 without padding the day

(This issue refers to v4.0.0)
Using the basic datetime alias with an inputFormat of mm/dd/yyyy, it is possible to type a 2 (immediately padded to 02 for February), followed by a 3, which should be immediately padded to 03, but is not.
At this point, no further input will be taken, because the date is already in an invalid state.
I would try a PR fix, but cannot take the time to decipher the validation flow in the datetime extension. If anyone wants to point me in the right direction, I can try fixing.
FYI, using inputFormat dd/mm/yyyy works as expected, because the day is validated before the month is entered. So putting in 30 or 31 for the day correctly disallows the subsequent entry of a 2.
Thanks for the excellent library.

I should also note, related to this issue, that default masking is quite messed up if I swap out mm/dd/yyyy for m/d/yyyy. Out of the box, I get something like this in the input: m///yym/

@Josh68 ,
The problem with m/d/yyyy is a problem with the placeholder logic.  I'm aware of that.  Try placeHolder: "_" for now.
I add some smarter logic for relating day and month.

This issue is still present in version 5.0.0.


user resource

This commit introduces the user resource implementation for fisheye.

One code smell remains because getUserManager() is deprecated but I haven't figured out the alternative for now. I propose top leave it as such for now.


RuntimeError: Cannot find asset at \bedrock\assets\kb-docs

Is there a url to downloa the kb-docs? I want to see this solution in action before I invest too much time into understanding everything under the hoods.

You can put any no currupted pdf file and it should work.


docs: improve documentation for OneHotEncoder

Closes #181.
Summary of Changes
Improve documentation of OneHotEncoder.

🦙 MegaLinter status: ✅ SUCCESS

Descriptor
Linter
Files
Fixed
Errors
Elapsed time

✅ PYTHON
black
1
0
0
0.44s

✅ PYTHON
mypy
1

0
1.59s

✅ PYTHON
ruff
1
0
0
0.04s

✅ REPOSITORY
git_diff
yes

no
0.03s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
MegaLinter is graciously provided by

:tada: This PR is included in version 0.12.0 :tada:
The release is available on:

v0.12.0
GitHub release

Your semantic-release bot :package::rocket:


Automatically refresh APIs

Reason/Context
When adding APIs via the Microcks UI, we need a way to refresh the APIs on Docker UI
Description
The APIs in the Docker UI should reflect the changes made in the Microcks UI
Implementation ideas
There are a couple options:

Poll the services every X seconds
Publish and event
Websockets

@lbroudoux is there any kind of event or webhook in microcks for newly created services?

Now we've got something! When using microcks-uber with version starting 1.8.1, these events are published on a WS endpoint that is located on the main webapp component. We could use that to get this information!
See https://microcks.io/blog/microcks-1.8.1-release/#uberall-in-one-architecture-simplification


Rebase v5 on top of e1fc1580c2e979113c95850b8ae5d83845063ca5

Rebase v5 branch on top of the now-current master (fixes #2906 from @PolyPik)

Wouldn't it be simpler to have someone with write permissions to this repository to do a rebase on a local repository then push those changes back into this one?

Is there any updates on this? 😶

Still no-signal? ☹

@nschonni can you give feedback about this?

Closing as stale.


Pipelines: Improve the docs on passing data between pipeline components

Kubeflow v0.7 simplified the file I/O for passing data between pipeline components.
Weave a better story in the docs, using the following information sources:

https://github.com/kubeflow/pipelines/blob/master/samples/tutorials/Data passing in python components.ipynb
https://www.kubeflow.org/docs/pipelines/sdk/component-development/#components-and-data-passing
https://www.kubeflow.org/docs/pipelines/sdk/parameters/ - probably remove this page and redirect to the improved docs.

@Ark-kun and @paveldournov FYI we should do this soon. :)

@sarahmaddox
It would be great to do this.
The https://github.com/Ark-kun/kfp_samples/tree/master/2019-10 Kubeflow summit/106 - Creating components from command-line programs tutorial also demonstrates data passing for non-python components.
P.S. Please see the Organize Pipelines samples and tutorials in an ordered curriculum for a proposed structure and order of tutorials. (it still might not cover "quickstart"-style tutorials).

@Ark-kun Is this issue something you can tackle? It's marked as P0 in the docs planning for this month.

From Pipelines team meeting today: @Ark-kun will own this. He has a notebook under development. He'll add a new doc specifically about passing data which introduces the concepts and summarises the steps, and then points to the notebook. He'll also merge content from existing pages and replace that content with a link to the new page.
/assign @Ark-kun

/area docs
/priority p2


build registry

Coverage decreased (-0.03%) to 54.06% when pulling 694bbef6335b20dc9ae0aec6f49c79401559b54f on wy65701436:build-registry into 686b477775e6964c50f58fe2fb7f2e3482220e63 on vmware:master.

Coverage decreased (-0.03%) to 54.06% when pulling 3f831b23260b4f5a2a708b2c2188c5e55875d825 on wy65701436:build-registry into 686b477775e6964c50f58fe2fb7f2e3482220e63 on vmware:master.

Coverage remained the same at 54.095% when pulling c952db3c73fed3200fa0779e47de3db2adc97335 on wy65701436:build-registry into 686b477775e6964c50f58fe2fb7f2e3482220e63 on vmware:master.

An overall comment, this PR may not have to be merged in 1.2 timeframe as it does not block anything.

Coverage decreased (-0.2%) to 53.943% when pulling efc10127f3ce38ca74122d0ed1869da60f38acf2 on wy65701436:build-registry into 686b477775e6964c50f58fe2fb7f2e3482220e63 on vmware:master.


JSQMessagesAssets.bundle not loading when using JSQMessagesViewController as framework

General information

Library version(s): 7.3.4
Reproducible in the demo project? (Yes/No): NO

Bug report
JSQMessagesAssets.bundle is not in JSQMessagesViewController.framework .
I'm using cocoapods 1.0.1 with use_frameworks! and when showing the JSQMessagesViewController the param assert NSParameterAssert(minimumBubbleWidth > 0); from -[JSQMessagesBubblesSizeCalculator initWithCache:minimumBubbleWidth:usesFixedWidthBubbles:] rises an exception because +[NSBundle(JSQMessages) jsq_messagesAssetBundle] returns nil .
The JSQMessagesAssets.bundle isn't in the product .app/Frameworks/JSQMessagesViewController.framework
If manually adding the JSQMessagesAssets.bundle to the JSQMessagesViewController.framework from the Utilities menu (Target Membership) it works, the bundle is copied.
Not sure if this is a cocoapods issue or a podspec issue.

Hello everyone!
I'm sorry to inform the community that I'm officially deprecating this project. 😢 Please read my blog post for details:
http://www.jessesquires.com/blog/officially-deprecating-jsqmessagesviewcontroller/
Thus, I'm closing all issues and pull requests and making the necessary updates to formally deprecate the library. I'm sorry if this is unexpected or disappointing. Please know that this was an extremely difficult decision to make. I'd like to thank everyone here for contributing and making this project so great. It was a fun 4 years. 😊
Thanks for understanding,
— jsq


Add Vertex Color Support

Summary

Pack color attribute data in to Float Texture
Update material struct with vertexColors flag
Interpolate colors across faces

TODO:

[ ] Vertex colors are assumed to be RBGA Uint16. The data must be normalized before it's accessed in the fragment shader. Where should I put this normalization code?

closes #182

@gkjohnson Thanks for the review. The last few weeks have been very hectic, but I'll get to it this week:)

@gkjohnson  I ran the model viewer test locally and I noticed a couple things:

In khronos-VertexColor, colors are stored as normalized float 32 values. So should we assume that vertex colors are already normalized (0-1) and stored as float32? I know blender uses Uint16 by default for vertex colors in gltf,  so if we assume float 32, these models will not render correctly.

As per  this discussion, it seems we need to account for the material alphaMode to render colors correctly.  According to emackey, vertex color transparency turns off the z-buffer in most standard WebGL renderers, so he disabled alphaMode for khronos-VertexColor. I tried ignoring the alpha channel in my local code and that seems to work.  So should we just ignore the vertex color alpha channel for now, regardless of the material blendmode?

In khronos-VertexColor, colors are stored as normalized float 32 values. So should we assume that vertex colors are already normalized (0-1) and stored as float32? I know blender uses Uint16 by default for vertex colors in gltf, so if we assume float 32, these models will not render correctly.

There's no need to assume. As mentioned in https://github.com/gkjohnson/three-gpu-pathtracer/pull/257#discussion_r961081602 passing an Int array into into the VertexAttributeTexture will automatically normalize the values to [ - 1.0, 1.0 ] (or [ 0.0, 1.0 ] for unsigned). You can also pass in a FloatArray and it will be represented as-is. So basically you can plug a color array in with no changes either way and it should work correctly.

As per this discussion, it seems we need to account for the material alphaMode to render colors correctly ( or just ignore alpha values entirely). According to emackey, vertex color transparency turns off the z-buffer in most standard WebGL renderers, so he disabled alphaMode for khronos-VertexColor. I tried ignoring the alpha channel in my local code and that seems to work. So should we just ignore the vertex color alpha channel for now, regardless of the material blendmode?

For the Vertex Color alpha we can just treat it as opacity and multiply it into the "albedo" value here. Supporting different blend modes for rendering is outside the scope of this feature, I think, and I don't even feel it's something we should be supporting in the project necessarily.
Thanks!

For the Vertex Color alpha we can just treat it as opacity and multiply it into the "albedo" value here. Supporting different blend modes for rendering is outside the scope of this feature, I think, and I don't even feel it's something we should be supporting in the project necessarily.

Got it!
I see your point about not supporting different blend modes. Just note that if we treat the alpha as opacity, the  khronos-VertexColor model will render like this:

As opposed to this:

It looks like three.js will only render transparency when material.transparent = true which is why the vertex alphas aren't respected in the three.js forward rendering pipeline. If you set material.transparent to true then this is what you get - so the implementation you have seems to match that case pretty well!

But we'll want to replicate that .transparent flag behavior in the path tracer, as well. I think we can do that by adding a "transparent" flag to the material definitions and only respecting opacity if it's set to "true". I say we can get this merged as-is right now and then you can make another PR with the changes required for the "transparent" flag? What do you think?

It looks like three.js will only render transparency when material.transparent = true which is why the vertex alphas aren't respected in the three.js forward rendering pipeline. If you set material.transparent to true then this is what you get - so the implementation you have seems to match that case pretty well!

But we'll want to replicate that .transparent flag behavior in the path tracer, as well. I think we can do that by adding a "transparent" flag to the material definitions and only respecting opacity if it's set to "true". I say we can get this merged as-is right now and then you can make another PR with the changes required for the "transparent" flag? What do you think?

Yes sounds good!

Excellent! Nice work!
And thanks again


New package: Databricks.Databricks version 0.212.0

Pull request has been created with Komac v1.11.0 :rocket:

Resolve: #135161

Microsoft Reviewers: Open in CodeFlow

For moderators
This account is automated by Github Actions and the source code was created by CoolPlayLin. If you have any questions about any pull request, don't hesitate to ping @Exorcism0666, I'll get a notification.

[!important]
Please carefully review these Pull Request before merging. If it is a Pull Request for removing incorrect content and the URLs are issue, free upon manual checking, please close this Pull Request directly. (It is best to inform Exorcism0666 of the closure.)

良い一日をお過ごしください！

This looks like a valid PR to me. I don't see a cause for these uncommon labels.

/AzurePipelines run

@stephengillie, please merge once you have a chance

/AzurePipelines run

@Exorcism0666 ^

@nfx It's normal, at the moment there are some problems managing pull requests and therefore this is buggy, so we have to wait some more.

/AzurePipelines run


Features/split cell notebooks

This shows the idea, in this extension you can currently only toggle the split cell using shift-s in command mode. I haven't added a button yet. The information is stored in the cell metadata.

Added a button, renamed to jupyter namespace.

looks good to me!


fix: auto re-init data.json when schema updated

Description
When the data.json used  (the server data store) doesn't align with the new data.json template, we consider composer has been updated, and simply re-init data.json. later we may consider do a gracefully update.
Given our multi-user work, which introduced a new key in data.json, this will help user clean recent history and do a fresh start.
I also clean up ABS-related logic of initializing data store.
Task Item
fixes #2315

@boydc2014 what if instead we just wrote a version into the data?

@boydc2014 what if instead we just wrote a version into the data?

if we don't reuse same key for different purpose, comparing keys won't be good enough. Adding a explicit version means any time we want to update the schema of data.json, developer needs to update this version manually.  I don't know, i feel like it would be a little bit error-prone, "keys" here implicitly indicate a version, somehow.

@boydc2014 what if instead we just wrote a version into the data?

if we don't reuse same key for different purpose, comparing keys might be good enough. Adding a explicit version means any time we want to update the schema of data.json, developer needs to update this version manually in a correct format. I don't know, i feel like it would be a little bit error-prone, "keys" here implicitly indicate a version, somehow. what do you think

Offline synced with @a-b-r-o-w-n , i'm convinced let's start add a version here and leverage the generic data migration mechanism to achieve this.


[5.9] [SymbolGraphGen] move "protocol implementations" check into isImplicitlyPrivate

Cherry-pick of #64867

Explanation: -skip-protocol-implementations doesn't properly drop all the relationships to those skipped symbols, including protocols added via an extension.
Scope: Affects symbol graphs generated with -skip-protocol-implementations.
Issue: rdar://107432084
Risk: Low. The code change only affects symbol graphs with the above flag, and shouldn't affect normal compilation.
Testing: Testing has been added to ensure that the kinds of relationships that were previously erroneously included are now dropped.
Reviewer: @daniel-grumberg

@swift-ci Please test


Reorganize algorithm docs

Our docs currently have 1) a lot of redundancy, 2) a difficult interface for finding much or most of our API surface area. This creates both confusion for readers and engineering burden for maintainers.
Specific problems/challenges:

We write independent overviews of each algorithm in three different places. This increases the barrier to contributing new algorithms and makes maintenance more difficult. E.g., for BlurPool:

Place 1: composer.algorithms.blurpool docstring
Place 2: BlurPool method card
Place 3: composer.algorithms.blurpool.BlurPool algorithm class (for most algos)

Several algorithms have different interfaces. These interfaces show up in different places in the docs, and only some interfaces are available without clicking through several levels of API reference. As an example, blurpool has:

BlurPool the Algorithm, documented in:

composer.algorithms API reference
composer.algorithms.blurpool API reference
composer.algorithms.blurpool.blurpool API reference

apply_blurpool the all-in-one model surgery function

composer.algorithms.blurpool API reference
composer.algorithms.blurpool.blurpool API reference

BlurConv2d and company, documented in

composer.algorithms.blurpool API reference
composer.algorithms.blurpool.blurpool_layers API reference

blur_pool2d and other standalone functions for the core logic, documented in

composer.algorithms.blurpool API reference
composer.algorithms.blurpool.blurpool API reference

Because we take up so much sidebar real estate with method cards and model cards, any API not documented in one of these pages is really hard to find; I have to click on "API reference" at the very bottom (not even visible unless I scroll down a lot), and then repeatedly expand submodules and scroll down to find stuff.

E.g., it's super annoying to find our functional API right now, even if you know where to look.

Searching, especially for algorithms, is hard because we have so many pages with similar names and content. Which makes the recursive "API reference" clicking more mandatory.

Proposal
Algorithms

Prefix every algorithm directory with an underscore. E.g., composer.algorithms._blurpool

This will eliminate redundant documentation of algorithm contents. Everything that should be visible under composer.algorithms will now only be visible under composer.algorithms. Same for composer.functional.

Make a top level composer.layers in which nn.modules like BlurConv2d can be discovered without digging several layers deep in the API reference.
Add standalone logic like blur_pool2d to composer.functional (or maybe elsewhere?)
Make method cards README.rst files instead of README.md, and have algorithm module-level docstrings just .. include:: these files.

Eliminates duplicate descriptions
Makes it much easier for other algorithm code to reference the method card (instead of hardcoding a URL in our last-released docs that may have out of sync content and/or break at any time). This also allows eliminating duplicate descriptions in Algorithm class docstrings.

Have method cards link to, but not include, docstrings for all interfaces for a given algorithm.

If I want to use BlurPool but am not sure of the best way to use it in my codebase, I should be able to click on the big "BlurPool" heading and see my options.
But if we add the full docstrings to the method card, it's a giant wall of mostly-redundant text (and it duplicates the docstrings being shown elsewhere, like in composer.functional).
Right now there no links to the actual code, so you're stuck using the search bar if you want to deviate from the simple examples shown.

Eliminate the "Methods Overview" page. It looks cool but is redundant with the sidebar. Or maybe add its content to the bottom of one of the quickstart/overview pages.

Models

Similarly make model cards be the module-level docstrings under composer.modules

Sphinx

Minor: Make our current toctree collapsible. I should be able to minimize the Method Cards, Trainer section, etc, like in the PyTorch and PyTorch Lightning docs.
Minor bugfix: make expanding sections in the API reference not reload the page. Right now I have to scroll to bottom from very top, click "API reference", scroll to bottom from very top again, click on submodule, repeat as needed.
Either eliminate the API reference section or move almost all of our docs there. Right now:

Some APIs are easy to find on the left, but some require digging through several levels of API reference, and
the API reference and our other docs are often redundant.

Since AFAIK most public APIs are addressable as composer.one_level_deep.ThingToUse, I propose eliminating the hierarchical API reference and just having a page for every one_level_deep module, which would include both tutorial content as needed and the full API for that module (including child modules) at the bottom. Mirrors what HF transformers docs do, and combined tutorial + full docs in each module docstring mirrors what torch does.

This is done!


Cache most recent Gradle version to speed up Java builds in Docker

It can take a long time to pull down Gradle depending on network conditions. This could be sped up in Docker by:

Installing SDK man - curl -s "https://get.sdkman.io" | bash
Installing the latest Gradle version in the container - sdk install gradle 5.4.1

SDK man approach didn't work on first pass


[Feature Wish] Hide Like/Repost counter

Maybe identity-based hiding of like and repost counter, because I think, counts are not really healthy.

Yes, I agree - we can add it to the Identity Config system.

Added the option to Identity config. Would we want this to be set on a per User basis, instead? Not sure it's worth doing the extra DB hit for this one value.

Nah, User is purely for authentication, I generally want display preferences to be in Identity for now.


cannot install boost 1.71.1 from source

Hi there!
I've been trying to build the boost library 1.71.1 from your releases (https://github.com/boostorg/boost/archive/refs/tags/boost-1.71.0.tar.gz) and the installation keeps failing with missing files
After extracting the archive I run the following commands:
bash-4.2# cd boost-boost-1.71.0/
bash-4.2# bash bootstrap.sh --with-libraries=all --with-toolset=gcc
bootstrap.sh: line 196: ./tools/build/src/engine/build.sh: No such file or directory
Building Boost.Build engine with toolset ...
Failed to build Boost.Build build engine
Consult 'bootstrap.log' for more details
bash-4.2# cat bootstrap.log
./bootstrap.sh: line 226: cd: ./tools/build/src/engine: No such file or directory

The log mentions missing directories. Am I missing some steps in the installation procedure or is this package missing some files?
I'm running this installation on CentOS 7

The official download site is on jfrog artifactory: https://boostorg.jfrog.io/artifactory/main/release/1.71.0/source/boost_1_71_0.tar.gz

Thanks @mclow did not know releases on this page are not the official ones. It works with the jfrog one!


Add export --json option

After consideration I think this PR should focus on exporting basic information about the project and mostly on what has been requested, so the list of dependencies and resolvers. The discussion on the cross-compilation for platforms and scala versions should be moved to a follow-up issue.
For now the export --json result contains the following information about the project:

projectName
scalaVersion that's visible in the Main scope
platform only one that's visible in the Main scope
scalacOptions
scalaCompilerPlugins presented as a String with ':' as delimiters
scalaJsVersion that's visible in the Main scope, only if the platform is JS
scalaNativeVersion that's visible in the Main scope, only if the platform is Native
mainClass
extraDecls contains jsModuleKind information
scope specific infromation:

scopeName, e.g. "main", "test"
sources list of subpaths to the source files
dependencies presented as a String with ':' as delimiters
resolvers presented as URL for Maven and ivy:pattern for Ivy
resourceDirs
extraDecls contains custom jars added to the project

Follow-ups to consider:

cross-compilation
resolver authentication

@fthomas, @ckipp01
Is this format okay?

Is this format okay?

Just took a look. Really happy you're working on this! One thing I did notice though, which @prolativ already mentioned is that I like the more structured output than the concise string. By doing the concise string you're now forcing every consumer of this output to have to both know how and to manually parse that output to their needs instead of having it already structured. I'm not really sure what the benifit of the concise string is. Having it structured like you originally had it is much more flexible imo.

Showing only the configuration for the current/default platform seems reasonable. We could later (as an independent improvement) add --cross flag to return a json list/object with configurations for different platforms and scala versions.
One can have different scalacOptions for main and test so these should be split. I assume this is true also for scalaCompilerPlugins
is extraDecls supposed to be dependent on the platform (e.g. can it hold some options for scala-native?) or is it scala-js only? In the latter case why isn't it called explicitly jsModuleKind? And why is this property both top-level and separately for main/test?
If we specify scalaJsVersion and scalaNativeVersion, shouldn't we also include e.g. the version of js itself or JVM, if it's specified explicitly?
Maybe scopes should be a Map rather than a list? Then scopeName wouldn't be necessary and extracting a desired scope from the json structure would be easier

@prolativ

is extraDecls supposed to be dependent on the platform (e.g. can it hold some options for scala-native?) or is it scala-js only? In the latter case why isn't it called explicitly jsModuleKind? And why is this property both top-level and separately for main/test?

I would delete this field altogether and leave scala-j/scala-native options for follow-up PRs if needed. WDYT?

If we specify scalaJsVersion and scalaNativeVersion, shouldn't we also include e.g. the version of js itself or JVM, if it's specified explicitly?

By "the version of js itself" do you mean Scala.js ECMA Script version?

[UPDATE]
Added sctuctured dependecy json objects, move scalacOptions and scalaCompilerPlugins to scopes.
Added jvmVersion and jsEsVersion field.
For now the export --json result contains the following information about the project:

projectName
scalaVersion that's visible in the Main scope
platform only one that's visible in the Main scope
jvmVersion only if declared explicitly
scalaJsVersion that's visible in the Main scope, only if the platform is JS
jsEsVersion only if declared explicitly
scalaNativeVersion that's visible in the Main scope, only if the platform is Native
mainClass
scope specific infromation as a map of (scope name -> following information):

sources list of subpaths to the source files
scalacOptions
scalaCompilerPlugins as structured json
dependencies as structured json
resolvers presented as URL for Maven and ivy:pattern for Ivy
resourceDirs
customJarsDecls contains custom jars added to the project

Follow-ups to consider:

cross-compilation
resolver authentication
scala-js/scala-native options

Just curious, what was the motivation for this change? I like it, might be very useful for packaging in Nix, just wanted to know what other usecases you had :)

The main use case we were thinking about is Scala Steward support, since there was a suggestion that export to sbt might be used as intermediary, which scared me a bit :sweat_smile:

That suggestion turned quickly into reality: https://github.com/scala-steward-org/scala-steward/pull/2933 :see_no_evil: :rofl:


No refresh_token is returned when authorization_code is used in /token request

I attempting to use the auth_code grant type in order to retrieve and then cache tokens. I successfully receive the auth_code, but when I then post to the /token endpoint using grant_type=authorization_code, I receive a JSON object back with only the access_token defined.
Could you define the scenarios in which a refresh_token would not be included in the token response?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2870d4a9-e204-023a-56a8-c34e56347b43
Version Independent ID: 846fe3ae-21cb-e030-f68f-db73acef0c74
Content: Understand the OAuth 2.0 authorization code flow in Azure AD
Content Source: articles/active-directory/develop/v1-protocols-oauth-code.md
Service: active-directory
GitHub Login: @CelesteDG
Microsoft Alias: celested

@timjroberts-inty  Thanks for your feedback! We will investigate and update as appropriate.

There are certain scenarios when it is not included because a new token is issued. With the Client Credentials grant type there is no refresh token because the client can get a new access token by asking a new one when he wants. @CelesteDG can you confirm?

Many thanks for the prompt feedback. We found some answers on StackOverflow that cleared it up for us - namely, we now include the Offline_Access scope when hitting the /authorize and /token endpoints. This returns the refresh_token.

Thank you, @timjroberts-inty - We have more informational about offline_access and other permissions here: https://docs.microsoft.com/en-us/azure/active-directory/develop/v2-permissions-and-consent#openid-connect-scopes

@MarileeTurscak-MSFT @SaurabhSharma-MSFT @MohitGargMSFT @MicahMcKittrick-MSFT #please-close Customer got the answer and we also have the info documented. Thank you.


ci/cd: gains GH action to automate checks and tests

I have added a ci.yml to run a series of tests and checks on this repo on every push to main.
The following checks are conducted:

Installs all dependencies
Runs unit tests (using npm run test:unit)
Runs integration tests (using npm run test:integration)
Lints the code base for style (using npm run lint)
Checks all JS types (using npm run check)

Note: I expect currently that the integration tests, linter and type check will all fail at this stage.
I will open separate PRs to address those failures.
Closes #23

Depends on #26 and #27
Note: there are still many type check failures... I'm not entirely sure if/ how we do/ don't want to handle this.
On the one hand, implementing typescript and type safety might make our application more robust, and might make development easier in the long run, however translating all of our JavaScript modules might be arduous and not the most valuable use of our time at this stage.
I will discuss this with @MonikaFu on Monday, and we will come to a decision.

Depends on #26 and #27
Note: there are still many type check failures... I'm not entirely sure if/ how we do/ don't want to handle this. On the one hand, implementing typescript and type safety might make our application more robust, and might make development easier in the long run, however translating all of our JavaScript modules might be arduous and not the most valuable use of our time at this stage.
I will discuss this with @MonikaFu on Monday, and we will come to a decision.

Ok scratch that, it seems that in the short-term setting "checkJs": false, is the lowest friction approach to get the type checking to function (effectively limiting type checking to typescript files).
We can explore migrating our existing JS to TS later, if we think it is a valuable thing to do.

Once #26 and #27 are merged, this should be good to go

So it seems like the linter is still failing after #26 was merged.
These failures seem to be legitimate styling problems with our JS code (hey look, we are catching those now!!)
I would suggest that we merge this PR without solving those, and handle them in a separate issue, since they will likely require @MonikaFu to eventually have a look at, and she will be actively developing on a lot of those files next sprint.
So I would say this is ready for review @AlexAxthelm

Sweet :-)
Will wait for @MonikaFu to give it the once over before merging


SCRD-6838, SCRD-4498 on complete show links

Get links for complete screen from the keystone catalog.

Note that this won't work for astack deployments, but does produce the correct Horizon URL for "real" deployments.

Can you elaborate on that a bit?

...figuring out why the config file is missing the values in the first place

If you are referring to the ardana service config file, the reason it does not have these values is that they are only populated in the config file by the config processor, which is run as part of the deployment page, and they are not available to the ardana-service until it is restarted or the config file is forceably re-read, at which point the ardana service would be listening on another interface that is not available to the UI, etc.

Note that this won't work for astack deployments, but does produce the correct Horizon URL for "real" deployments.

Can you elaborate on that a bit?

on an astack system the urls show up as https://myardana.test:443 which doesn't help the user at all

based on Garys comment about the config processor, reading these from keystone and trimming the ops console URL may be the most reliable approach... so that should be a modest tweak from the current version of this change

This change should be trimming the path for both horizon and the opsconsole urls. As an alternative we could have the service request for the endpoints read and parse the config file from disk.

The astack fix worked, not sure I understand how the trimming is taking place (note that the Horizon url is correct coming out of keystone)

@eapodaca  question, when keystone is up...in day0 do we need to use user/pass to access endpoint list?

@jeremy-moffitt please re-review this has drastically changed since you reviewed it last.
I have updated the /api/v2/external_urls ardana-service endpoint to return the urls from the internal model.

@eapodaca does this require https://gerrit.suse.provo.cloud//#/c/5590/  to have landed to function?

@eapodaca does this require https://gerrit.suse.provo.cloud//#/c/5590/ to have landed to function?

Not required but with that change the bugs are 100% fixed.

tried this out with the gerrit change, and it does load the links... but it takes some time... at first I thought it was broken, but after waiting it out, the links did show up eventually.

overall this looks ok to me, though its taking 10 seconds to load the links, so if that time to load cant be reduced, then we should put a loading indicator of some sort where the "useful links" are (I'm hesitant to mask off the modal as it wouldnt be very obvious why thats happening)...  open to ideas... maybe "Loading useful links..." that changes into the current "Useful links:" section.