add caveat covering index

What
tries to optimize relationship lookup for various datastores by making sure caveat name and context are part of a covering index.
How
this PR explores making sure every relationship query is served from the index (aka covering index). This was the case before, but it stopped the moment we added caveats to the table.
This functionality is nicely handled in all databases, except MySQL, which does not support "including a column in the covering index".
In MySQL case, we also had to shrink the caveat_name column because adding any new element to the index hit the 3072 bytes InnoDB limit. The migration won't make this a covering index, but:

it will allow us to have an index for ReadRelationships with a RelationshipFilter that filters on caveat name
it will allow us to select all columns but column_context and make decisions based on the existence of a caveat in the row.

superseded by https://github.com/authzed/spicedb/pull/1050


Add notification processing schema

This PR adds the tables that power notification processing. The API uses this set of tables to control how it processes incoming webhook notifications from connected applications. There are three new entities being added:

notifications are a name for a set of filters and rules that are applied to the request body. The notification also defines where in the request body to retrieve the surrogate ID for an Imbi project
filters are responsible for deciding whether a notification should be processed by inspecting the request body
rules define the data to extract from a notification body and which Imbi facts to assign the data to

The processing logic will look something like:

retrieve the notification definition by integration name & notification name -- if not found, then ignore the notification
retrieve the list of filters for the incoming notification
evaluate each filters using the request body as input and decide whether the notification should be ignored or processed
extract the surrogate ID from the request body using information from the notification
look up the Imbi project using the integration name & surrogate ID -- if not found, then ignore the notification
create a list of updates using the rules and the request body -- the output is a list of (project-type-id, value)
remove updates with project-type-ids that are not applicable to the Imbi project
update the Imbi project facts for the project

There is a good bit of nuance in step 3 but that will be explained in code eventually. The following is a rough ERD for what the SQL should be building. The integrations and integration_identifiers tables were created in #16.
erDiagram
    integrations {
        string name PK
    }
    integration_notifications {
        string integration_name PK,FK
        string notification_name PK
    }
    notification_filters {
        string integration_name PK,FK
        string notification_name PK,FK
        string filter_name PK
    }
    notification_rules {
        string integration_name PK,FK
        string notification_name PK,FK
        int fact_type_id PK,FK
    }
    project_identifiers {
        string integration_name PK
        int project_id PK,FK
        string external_id
    }

    integrations ||--o{ integration_notifications : sends
    integration_notifications ||--o{ notification_filters : filtered-by
    integration_notifications ||--|{ notification_rules : extraction-definitions
    notification_rules }o--|| project_fact_types : fact-type
    project ||--o{ project_identifiers : identified-by
    project ||--o{ project_facts : ""
    project_facts }o--|| project_fact_types : ""

In general this approach LGTM. We may want more operations in the future beyond == and != (like string contains), but that should be extensible enough if the actual operation is done in code.
We may also need to do processing on the values that come in to transform them into well-formed fact values, like string formatting and such. That would add a wrinkle of complexity we may not need at first, but something to keep in mind.

In general this approach LGTM. We may want more operations in the future beyond == and != (like string contains), but that should be extensible enough if the actual operation is done in code.

Do you think that equals is going to be nicer than == when it comes to manipulating these in the UI? I don't think anyone sees them other than an Admin so I didn't put a lot of thought into it. The only headache is that the decision ripples through most of the projects (schema, openapi, and api).

We may also need to do processing on the values that come in to transform them into well-formed fact values, like string formatting and such. That would add a wrinkle of complexity we may not need at first, but something to keep in mind.

I was thinking about that though I really don't want to add a data massaging layer unless we really need one. I still have to think through what data transforms the server side is going to need since it is going from whatever is in the notification to a project fact value. For example, code coverage could be a string value in some notification and Imbi could be configured to a numeric value.... though they are all strings in the DB there could be some weirdness.


Python: MongoDbInstance and MongoDbPostInstallSetup init params with vpc_subnets causing error

I use example code from examples/deadline/All-In-AWS-Infrastructure-Basic/python by setting config.py self.deploy_mongo_db: bool = True this causing the error when passing vpc_subnets parameter into MongoDbInstance and MongoDbPostInstallSetup init method in storage_tier.py.
availability_zone = props.vpc.availability_zones[0]

        mongo_vpc_subnet = SubnetSelection(
            subnet_type=SubnetType.PRIVATE,
            availability_zones=[availability_zone]
        ),

        mongo_db = MongoDbInstance(
            self,
            'MongoDb',
            vpc=props.vpc,
            vpc_subnets=mongo_vpc_subnet, # <--- If I comment this out, it now work
            key_name=props.key_pair_name,
            instance_type=props.database_instance_type,
            mongo_db=MongoDbApplicationProps(
                user_sspl_acceptance=props.accept_sspl_license,
                version=MongoDbVersion.COMMUNITY_3_6,
                hostname='mongo',
                dns_zone=props.dns_zone,
                server_certificate=server_cert
            )
        )

        _mongo_db_post_install_setup = MongoDbPostInstallSetup(
            self,
            'MongoDbPostInstall',
            vpc=props.vpc,
            vpc_subnets=mongo_vpc_subnet, # <--- If I comment this out, it now work
            mongo_db=mongo_db,
            users=MongoDbUsers(
                x509_auth_users=[
                    MongoDbX509User(
                        certificate=client_cert,
                        roles=json.dumps([
                            {
                                'role': 'readWriteAnyDatabase',
                                'db': 'admin'
                            },
                            {
                                'role': 'clusterMonitor',
                                'db': 'admin'
                            }
                        ])
                    )
                ]
            )
        )

Reproduction Steps

Set up this project as usual and run cdk ls
Error Log

AttributeError: type object 'tuple' has no attribute '__jsii_type__'
Environment

CDK CLI Version      : 1.90.1
CDK Framework Version: 1.86.0
RFDK Version: 0.25.0
Deadline Version: latest release
Node.js Version: v14.15.5
OS               : Windows 10 with WSL2 Ubuntu
Language (Version): Python 3.8.5

Other

Traceback (most recent call last):
  File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/mnt/c/Users/karaoke/projects/github/aws-rfdk/examples/deadline/All-In-AWS-Infrastructure-Basic/python/package/app.py", line 133, in <module>
    main()
  File "/mnt/c/Users/karaoke/projects/github/aws-rfdk/examples/deadline/All-In-AWS-Infrastructure-Basic/python/package/app.py", line 91, in main
    storage = storage_tier.StorageTierMongoDB(app, 'StorageTier', props=storage_props, env=env)
  File "/mnt/c/Users/karaoke/projects/github/aws-rfdk/examples/deadline/All-In-AWS-Infrastructure-Basic/python/.venv/lib/python3.8/site-packages/jsii/_runtime.py", line 83, in __call__
    inst = super().__call__(*args, **kwargs)
  File "/mnt/c/Users/karaoke/projects/github/aws-rfdk/examples/deadline/All-In-AWS-Infrastructure-Basic/python/package/lib/storage_tier.py", line 218, in __init__
    mongo_db = MongoDbInstance(
  File "/mnt/c/Users/karaoke/projects/github/aws-rfdk/examples/deadline/All-In-AWS-Infrastructure-Basic/python/.venv/lib/python3.8/site-packages/jsii/_runtime.py", line 83, in __call__
    inst = super().__call__(*args, **kwargs)
  File "/mnt/c/Users/karaoke/projects/github/aws-rfdk/examples/deadline/All-In-AWS-Infrastructure-Basic/python/.venv/lib/python3.8/site-packages/aws_rfdk/__init__.py", line 2350, in __init__
    jsii.create(MongoDbInstance, self, [scope, id, props])
  File "/mnt/c/Users/karaoke/projects/github/aws-rfdk/examples/deadline/All-In-AWS-Infrastructure-Basic/python/.venv/lib/python3.8/site-packages/jsii/_kernel/__init__.py", line 268, in create
    args=_make_reference_for_native(self, args),
  File "/mnt/c/Users/karaoke/projects/github/aws-rfdk/examples/deadline/All-In-AWS-Infrastructure-Basic/python/.venv/lib/python3.8/site-packages/jsii/_kernel/__init__.py", line 141, in _make_reference_for_native
    return [_make_reference_for_native(kernel, i) for i in d]
  File "/mnt/c/Users/karaoke/projects/github/aws-rfdk/examples/deadline/All-In-AWS-Infrastructure-Basic/python/.venv/lib/python3.8/site-packages/jsii/_kernel/__init__.py", line 141, in <listcomp>
    return [_make_reference_for_native(kernel, i) for i in d]
  File "/mnt/c/Users/karaoke/projects/github/aws-rfdk/examples/deadline/All-In-AWS-Infrastructure-Basic/python/.venv/lib/python3.8/site-packages/jsii/_kernel/__init__.py", line 154, in _make_reference_for_native
    "data": {
  File "/mnt/c/Users/karaoke/projects/github/aws-rfdk/examples/deadline/All-In-AWS-Infrastructure-Basic/python/.venv/lib/python3.8/site-packages/jsii/_kernel/__init__.py", line 155, in <dictcomp>
    jsii_name: _make_reference_for_native(
  File "/mnt/c/Users/karaoke/projects/github/aws-rfdk/examples/deadline/All-In-AWS-Infrastructure-Basic/python/.venv/lib/python3.8/site-packages/jsii/_kernel/__init__.py", line 174, in _make_reference_for_native
    kernel.create(d.__class__, d)
  File "/mnt/c/Users/karaoke/projects/github/aws-rfdk/examples/deadline/All-In-AWS-Infrastructure-Basic/python/.venv/lib/python3.8/site-packages/jsii/_kernel/__init__.py", line 267, in create
    fqn=klass.__jsii_type__ or "Object",
AttributeError: type object 'tuple' has no attribute '__jsii_type__'

This is :bug: Bug Report

I also try with
> cdk --version
1.86.0 (build a10cfcf)

and the error is the same as above.
Thank you very much for looking into this.

Thanks for the report, and the great reproduction details!

Looks like we have a typo in our example. This is resolved by removing an extra comma. Change:
        mongo_vpc_subnet = SubnetSelection(
            subnet_type=SubnetType.PRIVATE,
            availability_zones=[availability_zone]
        ),

to
        mongo_vpc_subnet = SubnetSelection(
            subnet_type=SubnetType.PRIVATE,
            availability_zones=[availability_zone]
        )

Notice the removal of the comma after the close-parenthesis.
We'll get this fixed in our repo, but that should get you past this particular error in the meantime.


Add array judgement for creators in text and csv download

The join method was used to cause errors for @hash[:attribution] after it was changed to string. Add judgment in case some organizations want to include more than one creator.

Looks like the change made Rubocop unhappy. I think it is fine to just add , Metrics/PerceivedComplexity to the rubocop exception comments that wrap that method.

Looks like the change made Rubocop unhappy. I think it is fine to just add , Metrics/PerceivedComplexity to the rubocop exception comments that wrap that method.

I see. Yeah, I also feel there's no easy way to get around it. I removed the corresponding check


bump detekt version to 1.23.0

https://github.com/detekt/detekt/releases/tag/v1.23.0
Detekt 1.23.0 is released. This should bump this action to use 1.23.0 version of detekt

Thanks!


[PR][CLOSED] Added scripts to inspect health status of CI server

 Issue by geunsik-lim
Tuesday Jun 19, 2018 at 02:38 GMT
Originally opened as https://github.sec.samsung.net/STAR/TAOS-CI/pull/36

Added a script to check Out-of-Memory situation
Added a script to check SWAP situation

Signed-off-by: Geunsik Lim<EMAIL_ADDRESS>
geunsik-lim included the following code: https://github.sec.samsung.net/STAR/TAOS-CI/pull/36/commits

:octocat: cibot: Thank you for posting issue #53. The person in charge will reply soon.


binde acting like bind for XF86 volume controls

Bug or Regression?
Bug
System Info and Version
 System/Version info
Hyprland, built from branch  at commit 4cdddcfe466cb21db81af0ac39e51cc15f574da9  (cursor: minor fixes for unhiding surfaces).
Date: Tue May 14 11:45:12 2024
Tag: v0.40.0-80-g4cdddcfe, commits: 4686

flags: (if any)

System Information:
System name: Linux
Node name: crt
Release: 6.9.5-arch1-1
Version: #1 SMP PREEMPT_DYNAMIC Sun, 16 Jun 2024 19:06:37 +0000

GPU information:
00:02.0 VGA compatible controller [0300]: Intel Corporation 2nd Generation Core Processor Family Integrated Graphics Controller [8086:0116] (rev 09) (prog-if 00 [VGA controller])

os-release: NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues"
PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/"
LOGO=archlinux-logo

plugins:

Description
XF86 keybinds (e.g. Fn + F3 = XF86AudioLowerVolume), when assigned as a binde keybind, act as a bind keybind.
# These work like only one press, despite press and hold expected
binde=, XF86AudioLowerVolume, exec, wpctl set-volume @DEFAULT_AUDIO_SINK@ 5%-
binde=, XF86AudioRaiseVolume, exec, wpctl set-volume -l 1.5 @DEFAULT_AUDIO_SINK@ 5%+

# These work as press and hold, as expected
binde= Super, F3, exec, wpctl set-volume @DEFAULT_AUDIO_SINK@ 5%-
binde= Super, F4, exec, wpctl set-volume @DEFAULT_AUDIO_SINK@ -l 1.5 5%+

Holding XF86AudioLowerVolume will decrease the volume by 5% once, although rapid repeats are expected.
Holding Super + F3 will decrease the volume rapidly and repeatedly, as expected.

How to reproduce
Use wireplumber, pipewire-pulse, and add the following to hyprland.conf.
# These work like only one press, despite press and hold expected
binde=, XF86AudioLowerVolume, exec, wpctl set-volume @DEFAULT_AUDIO_SINK@ 5%-
binde=, XF86AudioRaiseVolume, exec, wpctl set-volume -l 1.5 @DEFAULT_AUDIO_SINK@ 5%+

# These work as press and hold, as expected
binde= Super, F3, exec, wpctl set-volume @DEFAULT_AUDIO_SINK@ 5%-
binde= Super, F4, exec, wpctl set-volume @DEFAULT_AUDIO_SINK@ -l 1.5 5%+

Inspect the change or lack thereof with pavucontrol's "Output Devices" section, or your status bar.
Crash reports, logs, images, videos
No response

Nevermind, it was a stray config file issue on my end. I overwrote the keybind with something else. -_-


(DTR Generator) Tutorial Generated DTR not Disappearing

Currently (v1.0.2), when you go to the DTR Gen's tutorial and exited while the generated sample DTR is shown, the DTR will not be removed as expected.
This can be implemented along with issue #14

Fix is applied in beta version release v1.1.0-beta.1. As no issues are found, this will be closed and is now guaranteed to be in the release v1.1.0.
This issue is patched with issue #14.

Wrong issue opened...


Short solution needed: "golang iota usage" (golang)

Please help us write most modern and shortest code solution for this issue:
golang iota usage (technology: golang)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments explain solution.
Link to this issue in comments of pull request.

golang iota usage


Ems role req

Check that auth page is visible/accessible only if user<EMAIL_ADDRESS>with password "123456789" is logged in.  Other users should not see or access the admin page.

works for me.

Works for me as well!

Password was 12345678 not 123456789 but otherwise it worked.


When node is retired we can relax compaction strategy as we have peaked

in memory usage and will go reduce from here.
@geirst or @toregge PR
@vekterli FYI

It might be better to treat node being (un)retired as a config change and amend the config. We already have AttributeAspectDelayer to delay attribute aspect changes until next node restart.


[BUG]  A random double-free error on CI

Describe the bug
We have noticed a random double-free bug in CI env:
https://github.com/alibaba/GraphScope/pull/363/checks?check_run_id=2742356572
It needs to be fixed, but not a blocking issue.
Expected behavior
The grape-engine shouldn't crash in any cases.
Additional context
N/A.

as my observation, the error is raise because in NETWORKX ON, an single session pytest memory useage is out of ci's memory bound.  and the error appear since commit https://github.com/alibaba/GraphScope/commit/3e55fce6aa5e40d8aa4291fc4394ab35c801eb99, the networkx use duplicated mode as default which use more memory.

It still requires more work to confirm, as OOM shouldn't be a "double free" by any means.

Close as wonfix and will investigate it further once we catch it on CI and fine a way to reproduce.

I believe we have corrupted the heap somewhere.
See also: https://github.com/alibaba/GraphScope/runs/2873352603?check_suite_focus=true


DT-23: Firewall delta internal subnet

I've just set it up to pull the images, I haven't looked at the apps at all or checked they work except to make sure they start.

This is merged, I was hoping GitHub would be able to figure it out 🙁


Migrate to new configuration ascidoc macro

Issue description
Migrate to new configuration ascidoc macro

I assume this is now closed.


Fixed #24908: readonly for overridden form fields would cause double rendering.

https://code.djangoproject.com/ticket/24908

Closing in favor of #4824 which is based on master.


feat(light-client): support ckb-light-client v0.3.0

Description
upgrade ckb-light-client rpc for support ckb-clight v0.3.0
resolve: https://github.com/ckb-js/lumos/issues/474
Type of change

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

[x] Tested the validity and return type of the 'get_peers' rpc
[x] Tested the validity and return type of the 'local_node_info' rpc
[x] Tested changes in fetch_transaction and get_transaction return types
[x] Tested the partial and delete commands for set_scripts.

ckb2023 has its own branch ckb2023 for now, can you change the target to ckb2023?


Adding "off" method for unsubscribing to events

I added an off() method so events could be unsubscribed to.

Looks good, thanks.


Consider pointing folks to other TLS solutions

Hi! I was hanging out in office hours and I asked a question about the state of hyper-tls and if there were plans to retire it.  There are a few other better tls implementations that we could direct folks to instead in documentation.  @seanmonstar Pointed out making an issue to start this discussion might be a good idea.
Example:

https://crates.io/crates/tokio-rustls

Does this mean that there won't be a hyper-tls release that is compatible with hyper v1.0?

I think a more appropriate replacement is https://github.com/rustls/hyper-rustls instead of tokio-rustls

Are there still any plans to support alternatives?


Can you

replace all string occurrences with string_builders cause every use of strings goes straight into memory, and then it grows exponentially due to having to overwrite each occurrence every time text is entered or read.

What

its using more memory than world gen in 1.20.1+

Have you tried FerriteCore (Fabric)

yeah it helps a tiny bit but adds upfront costs.

Like...?

it just costs a little memory upfront, all mods do

I have been searching for a couple of hours for a memory mod, and the only one that is any good is not fixing it.

FerriteCore saves memory in a list of ways you can read here.

Speaking of that, if you really want to know what takes up so much CPU/memory, use F3 + L to activate a profiling log, run around and stuff until it's done, then take a look at the ZIP file it generates.
Or attach it here and I'll look it.

and then it grows exponentially due to having to overwrite each occurrence every time text is entered or read.

Also, this is incorrect. You can hold a reference to a string of text for as long as you want. Thanks to Java's string pools, a string constant "hi_there" only has one instance. String concatenation is what takes CPU/memory time. Barely at all, though.

ok, I found out which mod was causing the issue out of my 3 mods...

a mod was claiming increased fps, and it does so, at the cost of memory and ticks

https://www.curseforge.com/minecraft/mc-mods/methane

ty for chatting


Display video snapshot preview

Hi there
How to disable Display video snapshot preview and message (path of saved image) ?

Maybe one of those options can help ?
https://github.com/videolan/vlc/blob/7dfc5072f8e024cc5313d33e61c7c8996ed14b00/doc/libvlc/vlc-thumb.c#L96
My guess would go to --no-snapshot-preview or --no-video-title-show

Hi Jeremy,
Thanks for your reply,
I remember some time ago were possible initialize vlc instance on program.cs but now I work just if put the vlc control on form. How now is possible initialize the instance and add such parameters?
I tried for example:
 myVlcControl.Play(new Uri(Url), new string[]                      {                        "--no-snapshot-preview", "--network-caching=1000", ":ffmpeg-hw", "--no-video-title"                     });
and did not work.

See wiki and sample codes. As you didn't fill the issue template, I don't know which project your are using. The option is named VlcMediaPlayerOptions if I remember correctly

I also tried it and no success. Thanks anyway

You must call it before EndInit. If using WinForms, you can set that property in the designer

Yeah, that was the solution. Thank you!
I have another question:
I need to capture snapshot each sec or less than. I run an timer calling myVlcControl.TakeSnapshot and after few min vlc goes freeze. Is there some way to capture video frames without call TakeSnapshop method? Or avoid vlc freeze due so many calls?


not comptabile with MI devices?

--- Delete everything above this line ---
Description
When you user try to pick image in MI devcices it showing user cancelled photo picker.whcih is not present in any other devices
How to repeat issue and example
Your explanation here and source code or link
Solution
What needs to be done to address this issue? Ideally, provide a pull request with a fix.
Additional Information

React Native version: [FILL THIS OUT: Be specific, filling out "latest" here is not enough.]
Platform: [FILL THIS OUT: iOS, Android, or both?]
Development Operating System: [FILL THIS OUT: Are you developing on MacOS, Linux, or Windows?]
Dev tools: [FILL THIS OUT: Xcode or Android Studio version, iOS or Android SDK version, if applicable] navigation crash for Android

Solve it？


Update StringResources.ru.xaml

Fix. Perhaps in the first time i missed some strings.
Check it out Key="S.Command.Cinemagraph", in UI it is, and in .en.xaml is missing. I already added it just in case.

There are also no translate hints for Undo, Redo, Cut, Copy, Paste and on the statistics tab.
In general, I wait for the English corrections file.

I just added the missing Cinemagraph text resource.
The other ones will be added in a future version, as they require changes in code.
Thank you.


add falcosidekick as optionnal dependency for falco

Signed-off-by: Issif<EMAIL_ADDRESS>
What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

What this PR does / why we need it:
This PR adds falcosidekick chart as an optionnal dependency for falco chart. It means we can deploy together falco and falcosidekick.
A message at end of deployment of falco has also been added for promoting usage of falcosidekick and how to deploy it.
$ helm install falco . -n falco

Release "falco" has been upgraded. Happy Helming!
NAME: falco
LAST DEPLOYED: Wed Jan 13 23:52:46 2021
NAMESPACE: falco
STATUS: deployed
REVISION: 8
TEST SUITE: None
NOTES:
Falco agents are spinning up on each node in your cluster. After a few
seconds, they are going to start monitoring your containers looking for
security issues.

No further action should be required.

Tip:
You can easily forward falco events to Slack, Kafka, AWS Lambda and more with falcosidekick.
Full list of outputs: https://github.com/falcosecurity/charts/falcosidekick.
You can enable its deployment with `--set falcosidekick.enabled=true` or in your values.yaml.
See: https://github.com/falcosecurity/charts/blob/master/falcosidekick/values.yaml for configuration values.

This message is not displayed if falcosidekick is deployed:
$ helm upgrade falco --set falcosidekick.enabled=true . -n falcoRelease "falco" has been upgraded.
Happy Helming!
NAME: falco
LAST DEPLOYED: Wed Jan 13 23:53:51 2021
NAMESPACE: falco
STATUS: deployed
REVISION: 9
NOTES:
Falco agents are spinning up on each node in your cluster. After a few
seconds, they are going to start monitoring your containers looking for
security issues.

No further action should be required.

In the same time, the configmap for falco is automatically configured for using falcosidekick as output for falco:
http_output:
  enabled: true
  url: http://falcosidekick:2801

Which issue(s) this PR fixes:
N/A

Fixes #
Special notes for your reviewer:
This PR is a proposal, this is why I haven't not bumped up the chart version yet. If everybody agrees, I will do it and squash commits.
Checklist

[ ] Chart Version bumped
[ ] Variables are documented in the README.md
[ ] CHANGELOG.md updated

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign issif after the PR has been reviewed.
You can assign the PR to them by writing /assign @issif in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

falco/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign issif after the PR has been reviewed.
You can assign the PR to them by writing /assign @issif in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

falco/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Issif: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Issif: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

LGTM label has been added.  Git tree hash: 3c3a2d871a7d4d2432f9c164c0361c0aa8e40b1e

LGTM label has been added.  Git tree hash: 3c3a2d871a7d4d2432f9c164c0361c0aa8e40b1e

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

falco/OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

falco/OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/hold cancel

/hold cancel

/close

/close

@leogr: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leogr: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/reopen

/reopen

@leogr: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leogr: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Task monitoring

Added automatic status update of  tasks running in Celery to properly reflect failures/success in DB.
Added option to allow filtering/searching through API.
There is an issue which needs to be resolved and it is the matter of sharing some common parts between Django App and Celery workers (TaskStatus, etc.) but this is a bigger thing and it needs some research and discussion in larger group.
Did some minor refactor here and there. Also removed some legacy task_runner code.

@harnash  Why did you close it?

@wladekb It was already merged. Those fixes should probably go in different PR.


Removes Duration from MXBean signature

Unfortunately Duration is defined recursively and can not appear in an MXBean signature.
This PR reverts commit 28eb33b5 and adds a test for MXBean compliance.

@markt-asf, this should probably be applied also to Tomcat 9.0, 10.0 and master, since the changes in the MXBean interface ended up in the latest releases (commit bd7b368).


Update Resolution Failures to report to Problems API

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

Replaced by https://github.com/gradle/gradle/pull/29645


Update aws-core, http-client-spi, ... to 2.16.85

Updates

software.amazon.awssdk:aws-core
software.amazon.awssdk:http-client-spi
software.amazon.awssdk:netty-nio-client

from 2.16.79 to 2.16.85.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

labels: library-update, semver-patch

Superseded by #413.


Temp list variable documentation (#3842)

Pull request opened by the merge tool on behalf of #3842

Merged into branches iso5 in e88e27973676524a91e2eef0b8e7e0c6888f5fca


LiveServer vs GitHub

LIVE SERVER:

GITHUB:

Hi @hairuochen
Pro tip: In Firefox (I think Chrome / Safari do the same thing) you can right click and select "Take Screenshot" and it will take a shot of the whole page for you!

Ooo thanks! Noted for next time! (:

Hi @hairuochen
The image isn't showing up / throwing a 404 because your code is looking for seating.png and your file name is Seating.png (not the uppercase 'S').
If you change the image file name to lowercase that should fix things up there.

That's very weird because I already fixed it prior to making my last commit. Is there any way to fix it on GithHub?

Okay I just changed the GitHub index into Seating.png to link them!

Well FML that's confusing. 🤦♂
I might need to google this but I see your https://github.com/imd1005-web-development-winter-2023/assignment-02-hairuochen/commit/81bdaaf581865ea8daebcce0ca9bd2523bc75f66 fixed it

I'm not sure why but on my end the image is still not appearing... ):

To deal with this:

Problem description
The issue here is that img inside the .descriptionImage div isn't being set to be full height.
https://github.com/imd1005-web-development-winter-2023/assignment-02-hairuochen/blob/81bdaaf581865ea8daebcce0ca9bd2523bc75f66/style.css#L110-L112
Resolution
Target the image inside your .descriptionImage div and set two properties, min-height to be 100% and object-fit to be cover.
/* Target an image inside the div */
.descriptionimage img {
   min-height: 100%; /* Set the min-height to be 100% so it always grows up to fill the height of the container */
  object-fit: cover; /* This tells the browser to scale the image properly - you can experiment with other values but I think cover will work best */
}

Try hitting CTRL+F5 in your browser to force the browser to do a refresh of your page.
The reason I say that is because https://github.com/imd1005-web-development-winter-2023/assignment-02-hairuochen/commit/81bdaaf581865ea8daebcce0ca9bd2523bc75f66 fixed it for me 😀

The same fix should work for hostingimage

Two additional small things:
Since you are setting the height on the actual element (height="800"), min-height might be overridden. So just watch out for that.
And, the nested section here, since it only has an img in it, this would be better marked up as a
, similarly to how you marked it up in the .descriptionImage.
The nested section isn't really adding semantic value.
https://github.com/imd1005-web-development-winter-2023/assignment-02-hairuochen/blob/f1ef0e9e0fb62ea519e44f66216c6e339e9e24d0/index.html#L104-L109
Better


List jumping when changing chunk

Hi.
VS items are jumping, shaking and making party when scrolling through list. Sometimes items disappear from list and show after scroll. As i saw it happens when chunks are changed.
Also scrollInto is not reaching it destination, but stops in middle of way.
Could you repair it or show me a way to repair it?

Hi @Worek, please share your work, so that I can take a look at the problem

I cant becouse its company code. But In items i have several observables thet connect to services and http. As i think this is problem becouse angular is creating those items "in go" when scrolling throug list with your component.
To prevent it, could you show me how to Lazy Load List element by element. I mean when using ngFor load first element, after it is loaded, load second element etc...

Hi, I'v got same problem

Render array with a lot of items
scrollInto(items[items.length -1])
On some user action items.push(newItem)
Then scrollInto(items[items.length -1])
Repeat few times (3-5)

After that items are jumping on scroll. Actually scrolls container only, items just jumping and no changes in DOM
Unfortunately can't share my project

It appears that you're modifying the array directly with .push. This did not previously auto-refresh, so calling scrollInto immediately afterwards would not work.  The lastest version of the package on npm tries to address this.
Please try the latest version & the above proposed solutions to see if it addresses your issue. Closing for now. Please re-open if you're still experiencing this issue.


make ball of junk accurate (again)

While looking at something else i noticed that the ball of junk had unaccuracied itself as its getCheck() was missing, this readds it for the same chapter 1 accuracy as before

I moved it to the self.check line, no need for this

you can close this PR I think, its in the initial:
self.check = Game.chapter == 1 and "A small ball\nof accumulated things." or "A small ball\nof accumulated things in your\npocket."

Didn't notice that it had been moved there, however it should ideally be moved back to getCheck() because its a dynamic text, defining it in init() means it will only update if re-initialised which it isn't after the first time the ball is recreated (in this case, its really just a good practice thing because its unlikely someone will change the chapter value mid mod but i think its better to leave it the way it was regardless)

this is how we did it for other stuff, like how Ralsei will look like, whether Susie will have bangs.
The config menu won't reload if you change the chapter mid-game anyway, you're not suppose to modify the Game.chapter without reloading the mod.


Build a release source archive

Avoid future GitHub checksum debacles.

The release of v0.10.2 did not work. It is still using the GH source archive URL

Release 0.10.3 is the first with a release archive.


Please consider adding hierline support

I'd PR it myself but I can't figure out what this is suggesting

Heirline is a DYI type of plugin, where you have to define everything yourself, but with a bunch of provided utilities. So it has no highlight groups. They are suggesting to just use the existing highlights that are normally used for highlighting similar things within neovim. If you use astronvim, it seems like this is where they define the highlights they use for heirline. This colorscheme might be missing some (pretty sure WinBar is missing, it should be added at some point), so you can have a look if you want to.
Also it seems like they have some sort of Heirline* highlights going on, but I would like to avoid those, if possible, because I wouldn't want for this colorscheme to support specific neovim configurations.

Thank you for the explanation. I'll dig in based off your comment.


tensorflow lite on armv7

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary):  Debian package repo
TensorFlow version:
Python version:3.6.9
Installed using virtualenv? pip? conda?:apt-get
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:

Describe the problem
Installed from Debian repo as my OS is ubuntu 16.04 on ARMv7l.
On apt-get update i see following message:
N: Skipping acquire of configured file 'main/binary-armhf/Packages' as repository 'https://apt.corretto.aws stable InRelease' doesn't support architecture 'armhf'
N: Skipping acquire of configured file 'main/binary-armhf/Packages' as repository 'https://apt.kitware.com/ubuntu bionic InRelease' doesn't support architecture 'armhf'
Subsequently installed : sudo apt-get install python3-tflite-runtime
But tflite_runtime import failed.
Does it mean the repo does not support current target hardware
Provide the exact sequence of commands / steps that you executed before running into the problem
Following are the commands:
echo "deb https://packages.cloud.google.com/apt coral-edgetpu-stable main" | sudo tee /etc/apt/sources.list.d/coral-edgetpu.list
curl https://packages.cloud.google.com/apt/doc/apt-key.gpg | sudo apt-key add -
sudo apt-get update
sudo apt-get install python3-tflite-runtime
Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

@yvkrishna91 ,
Can you please provide the tensorflow version you are using? Thanks!

I have not installed tensorflow. Intended to use tensorflow lite as specified in tensorflow python quick start guide.

From: tilakrayal @.>
Sent: Friday, June 11, 2021 9:44:07 PM
To: tensorflow/tensorflow @.>
Cc: VamsiKrishna Yesu @.>; Mention @.>
Subject: Re: [tensorflow/tensorflow] tensorflow lite on armv7 (#50223)
ATTENTION! This email originates from outside of the organisation. Do not open attachments or click links unless you are sure this email comes from a known sender and you know the content is safe.
@yvkrishna91https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fyvkrishna91&data=04|01|vamsikrishna.yesu%40yti.yokogawa.com|1394a181d4ce4b9797f008d92cf3f58c|05493cda785f4f49b345c2cce5a0e1ef|0|0|637590248588797771|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=nhMOqHAAGTTiFKAEjhNkaPfDPXuReJETF10YIf11pL4%3D&reserved=0 ,
Can you please provide the tensorflow version you are using? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftensorflow%2Ftensorflow%2Fissues%2F50223%23issuecomment-859689779&data=04|01|vamsikrishna.yesu%40yti.yokogawa.com|1394a181d4ce4b9797f008d92cf3f58c|05493cda785f4f49b345c2cce5a0e1ef|0|0|637590248588807770|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=HXzSJuNvhAoH436Vg%2FfnqBD%2BWdYh7clqIGb63qJf7lk%3D&reserved=0, or unsubscribehttps://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FATUOVPLFEWPBFGYFW326UYDTSIY47ANCNFSM46QQTDOQ&data=04|01|vamsikrishna.yesu%40yti.yokogawa.com|1394a181d4ce4b9797f008d92cf3f58c|05493cda785f4f49b345c2cce5a0e1ef|0|0|637590248588807770|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=gdZasV3%2F4%2BMt9xJwYjo%2B5TQSkysLh1vmKeyO%2BWVdngY%3D&reserved=0.

@yvkrishna91
If you are okay with unofficial, there is an installer that I created.

TensorFlow Lite stand alone installer
https://github.com/PINTO0309/TensorflowLite-bin/tree/main/2.4.1
TensorFlow installer
https://github.com/PINTO0309/Tensorflow-bin

Thank you
But the installation failed. Please find the attached error log.
instalationfailure.txt

@yvkrishna91
$ sudo pip3 install Cython

@PINTO0309
Cython installation we successful. numpy,pybing11,tflite-runtime fails.
instalationfailure.txt

@yvkrishna91
$ sudo pip3 install wheel

Installation is successful
Tried label_image.py and resulted in following error. Tflite module runtime is failing.
instalationfailure.txt
label_image.txt

Your environment is strange. Xenial or Bionic? What is the result of the following command?
$ uname -a
$ ldd --version

Linux ubuntu 4.14.164-rt73-ampxlnx #10 SMP PREEMPT RT Wed Feb 19 09:49:00 JST 2020 armv7l armv7l armv7l GNU/Linux
ldd --version
ldd (Ubuntu GLIBC 2.27-3ubuntu1.4) 2.27
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Written by Roland McGrath and Ulrich Drepper.

I see. Ubuntu 18.04 had not yet created an installer for the armv7l version.

Does it mean it is not possible to have tensorflow lite or mediapipe on this hardware, untill Ubuntu creates an installer for armv7l?

I just didn't target armv7l for my build because I thought the demand for it was low.
Did you use either of the following?
https://github.com/PINTO0309/TensorflowLite-bin/blob/main/2.3.1/download_tflite_runtime-2.3.1-py3-none-linux_armv7l.whl.sh
or
https://github.com/PINTO0309/TensorflowLite-bin/blob/main/2.4.0/download_tflite_runtime-2.4.0-py3-none-linux_armv7l.whl.sh

This is a work-around that you can try in your environment for now. I don't know if it will work.
$ wget https://github.com/lhelontra/tensorflow-on-arm/releases/download/v2.4.0/tensorflow-2.4.0-cp35-none-linux_armv7l.whl
$ mv tensorflow-2.4.0-cp35-none-linux_armv7l.whl tensorflow-2.4.0-cp36-none-linux_armv7l.whl
$ sudo pip3 install tensorflow-2.4.0-cp36-none-linux_armv7l.whl

I will try..

I'm sorry, but I think you should probably clean it up and try it.

I have not cleaned it up. But got following error.
instalationfailure.txt
Do you think clean up would solve this error?

Try
$ sudo apt-get install libhdf5-dev

It did not work after installation of libhdf5-dev. Error is still the same,
Loading library to get version: libhdf5.so
error: libhdf5.so: cannot open shared object file: No such file or directory
Attaching the libhdf5-dev installation log.
libhdf5-installation_succesful.txt

$ sudo pip3 uninstall h5py
$ sudo apt-get install libhdf5-dev

Please check the attached logs.
instalationfailure.txt

Can you please suggest next steps soon?

Do you want to build a TFLite Python wheel for your target armv7 OS?
Did you try https://www.tensorflow.org/lite/guide/build_cmake_pip ?

Yes i did, but get following error:
downloading 'https://storage.googleapis.com/mirror.tensorflow.org/www.kurims.kyoto-u.ac.jp/~ooura/fft2d.tgz' failed
status_code: 1
status_string: "Unsupported protocol"
log:
--- LOG BEGIN ---
Protocol "https" not supported or disabled in libcurl
But i am able to download other packages

Is Glib version the root cause? Does upgrading Glib would solve the issue?

FYI, https://github.com/tensorflow/tensorflow/issues/38642#issuecomment-988572129


Organize the page My repository shows only the number of items that do not show the list

Gogs version (or commit ref): <IP_ADDRESS>7
Git version: unknow
Operating system: unknow
Database (use [x]):

[ ] PostgreSQL
[x ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gogs.io:
Yes (https://try.gogs.io/org/test009/dashboard)

Description
I was using try.gogs.io for the test.
Members join the organization and do not join the organization team.
Organize the page My repository shows only the number of items that do not show the list.

...

Hi, is it reproducible for every new user?

Yes, I created a new account on Try

Yes, I created a new account on Try

This is not what I asked for.
What is the reproduce steps? I can't reproduce.

User A is the organization owner.
User B is a member of the organization,but B is not in any team.
A creates the  repository, the owner is the organization.
B in the organization dashboard, can only see the number of repository, can not see the list

Private or public repository?

Patch has pushed to fix this issue, please test on develop branch or https://try.gogs.io.

fixed～


move in stats website

https://github.com/threefoldtech/tfgrid_stats

Verifed,
https://github.com/threefoldtech/tfgrid-sdk-ts/tree/development/packages/stats


Outdated comment about proxy.secretToken

As a followup to #756: We have an outdated comment about proxy.secretToken. It can be updated to say that we still set one or two hub.services.<some-jupyterhub-service-name>.apiToken values via the common secret. We don't set proxy.secretToken like described, but we set:

An JupyterHub API token used by the deployer script providing admin access against the JupyterHub to run health checks
An JupyterHub API token used by components in the dask-gateway helm chart to authenticate jupyterhub users

Outdated comment
https://github.com/2i2c-org/infrastructure/blob/31a1d8c2dedb3d58bf61b482112f2fb8856669d6/deployer/deploy_actions.py#L184-L210
Source code using the common secret seed
https://github.com/2i2c-org/infrastructure/blob/31a1d8c2dedb3d58bf61b482112f2fb8856669d6/deployer/hub.py#L166-L193

Hmmm I could probably just have opened a PR to solve this instead of writing an issue about it I realize - sorry!

Hmmm I could probably just have opened a PR to solve this instead of writing an issue about it I realize - sorry!

Well... the PR is still welcome 😜 ja ja

I recall Yuvi fixing this


Font.FindGlyph and font.Glyphs return wrong data

Font ProggySmall.ttf everything renders and works correctly.
However if you print the contents of each glyph from ImGui.GetFont() you get uvs that dont make sense, AdvanceX that doesnt make sense etc. I tried to find the issue to the best of my knowledge, set structs to sequential in hopes that there is some layout mismatch, converted chars to utf8, the result is always the same - wrong data is provided.
I am not sure what is going on there.
here is the case where i found out the problem

static bool test = false;

    /// Draws vertical text. The position is the bottom left of the text rect.
    public static unsafe void AddTextVertical(string text, Color text_color, Vector2? position = null)
    {
        if (string.IsNullOrEmpty(text))
        {
            text = "Null";
        }

        Vector2 pos = position.HasValue ? position.Value + ImGui.GetWindowPos() : ImGui.GetCursorPos() + ImGui.GetWindowPos();
        ImDrawListPtr DrawList = ImGui.GetWindowDrawList();
        pos.x = Mathf.Round(pos.x);
        pos.y = Mathf.Round(pos.y);
        ImFontPtr font = ImGui.GetFont();

        if (!test)
        {
            var glyphs = font.Glyphs;
            for (int i = 0; i < glyphs.Size; i++)
            {
                var g = glyphs[i];
                Debug.Log("g: " + g.Codepoint + " a:" + g.AdvanceX + " v0:" + g.V0 + " v1:" + g.V1);
            }
            test = true;
        }

        byte[] bytes = Encoding.Default.GetBytes(text);
        text = Encoding.UTF8.GetString(bytes);

        ImFontGlyphPtr glyph;
        char c;
        //ImGuiContext g = *GImGui;
        Vector2 text_size = ImGui.CalcTextSize(text);

        float textX = text_size.x / text.Length;
        for (int i = 0; i < text.Length; i++)
        {
            c = text[i];

            glyph = font.FindGlyph(c);

            if (glyph.NativePtr == null) continue;

            DrawList.PrimReserve(6, 4);
            DrawList.PrimQuadUV(
                    pos + new Vector2(glyph.Y0, -glyph.X0),
                    pos + new Vector2(glyph.Y0, -glyph.X1),
                    pos + new Vector2(glyph.Y1, -glyph.X1),
                    pos + new Vector2(glyph.Y1, -glyph.X0),

                    new Vector2(glyph.U0, glyph.V0),
                    new Vector2(glyph.U1, glyph.V0),
                    new Vector2(glyph.U1, glyph.V1),
                    new Vector2(glyph.U0, glyph.V1),
                    text_color.ToUint());

            pos.y -= textX ;
        }

        ImGui.SetCursorPosX(text_size.y);
    }

Without really knowing too much about how these low-level font details work, it's hard to say if this is expected. Are you able to get the same or similar code working with the native library directly?

If you just want to sanity check the results from FindGlyph you could just have a test case like
Debug.Assert(fontptr.FindGlyph('B').AdvanceX == fontptr.GetCharAdvance('B'))

If you just want to sanity check the results from FindGlyph you could just have a test case like
Debug.Assert(fontptr.FindGlyph('B').AdvanceX == fontptr.GetCharAdvance('B'))

This is a problem with the sizes of the first two entries in ImFontGlyph. https://github.com/ocornut/imgui/blob/3867c6c5f0eace22ce2c59ac299bae285bb84ec4/imgui.h Lists 'codepoint' and 'visible' as unsigned ints, but the compiled library seems to have 2 byte ints so we need to have unsigned shorts here.
Changing in ImFontGlyph.gen.cs (or structs_and_enums.json I guess)
    public unsafe partial struct ImFontGlyph
    {
        public ushort Codepoint;  // <---
        public ushort Visible;       //  <---
        public float AdvanceX;
        public float X0;
        ---snip---
    }

makes the problem go away

This is a problem with the sizes of the first two entries in ImFontGlyph. https://github.com/ocornut/imgui/blob/3867c6c5f0eace22ce2c59ac299bae285bb84ec4/imgui.h Lists 'codepoint' and 'visible' as unsigned ints, but the compiled library seems to have 2 byte ints so we need to have unsigned shorts here.
Changing in ImFontGlyph.gen.cs (or structs_and_enums.json I guess)
    public unsafe partial struct ImFontGlyph
    {
        public ushort Codepoint;  // <---
        public ushort Visible;       //  <---
        public float AdvanceX;
        public float X0;
        ---snip---
    }

makes the problem go away

struct ImFontGlyph
{
    unsigned int Codepoint : 31;
    unsigned int Visible : 1;
    float AdvanceX;
    float X0, Y0, X1, Y1;
    float U0, V0, U1, V1;
};

Codepoint and Visible are bitfields, both are in the same 32bit int, Codepoint fills the first 31 bits and Visible the last 1 bit.

struct ImFontGlyph
{
    unsigned int Codepoint : 31;
    unsigned int Visible : 1;
    float AdvanceX;
    float X0, Y0, X1, Y1;
    float U0, V0, U1, V1;
};

Codepoint and Visible are bitfields, both are in the same 32bit int, Codepoint fills the first 31 bits and Visible the last 1 bit.

Ahhh, that makes sense now - I didn't recognise the bitfield syntax.

Ahhh, that makes sense now - I didn't recognise the bitfield syntax.

Yeah, bitfields are not handled at all right now. C# has no concept of a bitfield, so this will require a lot of custom handling to make these parts work. Luckily, they are very few and far between (although it seems the Tables API has added a few new instances).


Change StatusBar color to darker shade of stream color on narrow.

Fix:#435

That looks better :)
Two things:

Extract the background logic to some function in our own color.js file. (maybe call it getStatusBar()). This way we make sure the dependencies on external libs are localized.
I am not sure if you need to check for platform. I think on iOS the parameter is ignored. Check if true, if yes, don't even do the check.

Coverage decreased (-0.5%) to 56.115% when pulling cc441a8a2c5a61c837ff5b0c3182748e059ca163 on vishwesh3:issue-435 into 1bc3c4092a04554fe6aaa1f908ad3d0c4805286f on zulip:master.

Updated.
Why to first convert color from RGB to HSL and then manipulate and again convert back to RGB.
Found a quick solution by Craig Buckler.
https://www.sitepoint.com/javascript-generate-lighter-darker-color/

Coverage decreased (-0.5%) to 56.115% when pulling 0c293240972f615f63cd62d3b7c4508a4dacf3f5 on vishwesh3:issue-435 into 1bc3c4092a04554fe6aaa1f908ad3d0c4805286f on zulip:master.

I was going to merge the previous version ;)
Not sure why you decide to replace the code with this snippet.
I am definitely not a fan of code copy-pasted from places on the internet vs supported library.

Implement against this PR #499
I did add Qix-/color

Implemented (in #499)


add a second ip for VPN connections

hi, i would like to know if it is possible to add a second ip for VPN connections.  I would like that the android vpn started automatically if the local ip does not belong to the ip range of the primary connection.

Slightly similar request - but possibly a separate issue. My DSL provider's modem won't route packets for my external ddns address back to my home assistant instance. This means that if I'm on cellular data I can use my external url but on home WiFi I can't. In the iOS version of the HA app there is a possibility to have an internal and external url. Maybe an internal,external,and VPN url could be useful?

@EagleAdam that is not related to this issue and has already been implemented in the dev version.


Bad conditions are added to total expected experiment length even when re-attempts are set to 0

I recently updated the conductor so that the length of bad conditions would be added to the total experiment length, to reflect how long the re-attempts at the end of the experiment would take. I just realized if the user sets the number of re-attempts to 0 (meaning they don't want to retry bad conditions), their length is still added to the experiment time. Need to update this.

resolved with commit 21b2db93288795dec5b2044486d63c2829618f65


Execute a command using selected text

Great project @sminez.
Here I'm trying to recreate functionality in acme  which I use to send selected code to a running REPL using acme's win shell.
For ad I have created a script "mysend" (see below) which uses tmux instead but the principle is the same.
The issue is that I want to send the code I've selected not the text "mysend" to the REPL
Is this a feature you have seen in other text editors?
In acme it is possible to select text and then middle click on a "command" (which could for example be a shell script such as mysend) without the selected text "dot" changing to command name.
Please describe the change / addition you'd like to see made
The idea is to select text and then click on a command "mysend" to send the text to a REPL
mysend is a bash script which sends the selected text to a tmux pane (pane 0) which could be running bash/python/R or whatever REPL
#!/bin/bash

source "$HOME/.ad/lib/ad.sh"

# read selected text from ad into a variable
varin="$(bufRead "$bufid" dot)"

# split up each line by reading into an array
readarray -t cmdarray <<< $varin

# send each line of the array to tmux
for i in "${cmdarray[@]}"
do
        tmux send -t%0 $i Enter
done

The issue at the moment is that when I click on mysend it changes dot from the selected text to "mysend" so that the REPL executes "mysend" rather than the code selected.

Hi @davcam, thank you for taking an interest in ad! This is something I've been wondering about as well actually, I started trying to write a version of win that would be runnable inside of ad but ended up getting distracted by other things.
I've been meaning to look a bit more at mouse selection as part of https://github.com/sminez/ad/issues/8 and was thinking about adding the acme behaviour you are describing of supporting dragging the middle or right mouse buttons to make a second (differently highlighted) selection for executing and loading the current dot. I'm not sure how long that will take to implement (hopefully not too long) but I'll try to take a look over the next week or so if I have time. For now though, I think that the approach you've got here could work "as is" if you added a key-binding to your init.conf that ran mysend, but that obviously isn't exactly the same set up as is possible in acme.

Many thanks for your reply @sminez. ad seems to hit a sweet spot, at least for me and hopefully for quite a number of others.
An ad version of win would be great of course though I guess more work?
Yes a differently highlighted dot using the middle mouse selection for executing is the feature I'm keen to see from acme.
In the meantime thanks for pointing me towards init.conf

OK, not exactly the same setup as what you have above but I can get the following to work:
#!/bin/bash
source "$HOME/.ad/lib/ad.sh"

requireAd

# read selected text from ad into a variable
varin="$(bufRead "$bufid" dot)"
tmux send -t%21 "$varin" Enter

Here, 21 is the pane ID for the pane I had open but I'm not too sure how you would determine that dynamically. In the recording after I highlight the line I'm just hitting S to trigger the key-binding shown in init.conf.
I'll keep this issue open until I have the acme style functionality implemented :slightly_smiling_face:
https://github.com/user-attachments/assets/485009d0-7355-4d89-805c-9b15cbee78d7

An ad version of win would be great of course though I guess more work?

I had a look at the win source code and it does a fair amount of book keeping to filter out re-interpreting its own input as it gets fed into the window after running each command. I think I have an idea of how to handle that but I'll need to get an MVP up and running to be able to verify that what I have planned will work. I should probably raise an issue for that as well so people are able to see what sorts of things I have planned for the future :smile:

Yep exactly and nice demo too!

@davcam I've got a PR open now that adds acme style mouse chording and Load / Execute selections while maintaining the current dot selection. As I've said in the PR description, I'm not asking for a code review as that'd be a bit much(!) but please do take a look at the demo and see what you think :smile:
I'm working on adding some unit tests for the new functionality before merging. It's a little fiddly given the interactions with the clipboard so I've got some refactoring to do but the current state of the PR should accurately reflect how things are going to work.

Now implemented as of #35

@sminez sorry to have taken my time getting back to you on this.
First of all thanks very much for this really useful set of changes to the mouse behaviour. This makes the ad editor even more compelling than before.
BTW I am now essentially using the workflow that you suggested before by defining a key press to run the mysend script.
I think your point below from the PR should address my original enhancement query?
Middle (click+release): Execute Dot (expanding current dot from Cur if needed)
However when I tested it I didn't get the result I expected.
Below is an example using your "Send" script from above
If I highlight echo hello then middle click on Send. The shell reports "Send: command not found" because in clicking the middle mouse button it has changed dot from "echo hello" to "Send" whereas I was expected it to use the current dot "echo hello" to send to the other tmux pane.
echo hello
Send
So I guess strictly my original issue still stands and is perhaps now a bug?
Although just to repeat I do not need this workflow now and your mouse behaviour changes are great.

Hi @davcam :wave:
No worries about taking your time to reply, there's no rush! I've just tried out the Send script again with the new functionality and it works fine for me but there might be one part that isn't working as you expect / how acme handled things. This is what works for me

use the left mouse button to drag highlight echo hello
use the middle mouse button to drag highlight Send

What doesn't work is just clicking the middle button on Send. Is that what you were trying?

Thanks for your reply @sminez
"What doesn't work is just clicking the middle button on Send. Is that what you were trying?"
Yes exactly this. This would be quite useful as it avoids the need to highlight the command "Send" but isn't a major point.
"use the left mouse button to drag highlight echo hello"
"use the middle mouse button to drag highlight Send"
If I understand correctly, this uses dot as an argument to Send so essentially Send echo hello? This is fine if the script expects to receive arguments $*. This is like a 2-1 mouse chord in acme I think?
In my case the script expects to read dot using 9p ie varin="$(bufRead "$bufid" dot)". An easy change to my script would fix this.
As you state ad isn't meant to be a carbon copy of acme.


fix: incompatible fetch and Response types error while node-types version is above 20.8.4

What kind of change does this PR introduce?
fix the incompatible fetch and Response types
Did you add tests for your changes?
no need
If relevant, did you update the documentation?
no need
Summary
upgrade node types to latest version (above v20.8.4) will cause the Response types incompatible error , becuase node-types have added undici-types as dependency after 20.8.4
Does this PR introduce a breaking change?
no
Other information

https://github.com/cloudflare/puppeteer/issues/50#issuecomment-2156335902

@Whyjsee Thanks for your PR. The issue is fixed with @types/node >=20.10.


Remove dependencies on personal forks

Purpose
For security and reliable builds, all dependencies should be either pinned to a version on a package index or pinned to a SHA on a COS-owned GitHub repo.
Changes
Remove dependencies on non-COS GitHub repos and change them to COS owned repos/forks
Ticket
https://openscience.atlassian.net/browse/OSF-6092

👍
For even more secure and reliable builds, we could run our own package server. That'd protect against things like left-pad, e.g.


getting link error

Hi
I am getting link error
/home/manisha/RTCode/source_updated/C++/Algorithms/Dig_CP/src/Dig_CP_getScores.cpp: In member function ‘double boss::Dig_CP::getScores::retrieveScore()’:
/home/manisha/RTCode/source_updated/C++/Algorithms/Dig_CP/src/Dig_CP_getScores.cpp:89:25: error: ‘using String = class std::basic_string’ has no member named ‘str’
hashKey.SetS(ss.str());
code
is
 Aws::String ss;
    hashKey.SetS(ss.str());

Aws::string is read as  std::basic_string
-Manisha

If you are using the default build arguments with cmake, you need to be
using Aws::String in your code and passing -DAWS_CUSTOM_MEMORY_MANAGEMENT=1
to your compiler.
Or, you can turn custom memory management off when you build the sdk.
On Jan 5, 2016 12:48 PM, "msinha31"<EMAIL_ADDRESS>wrote:

Hi
I am getting link error
/home/manisha/RTCode/source_updated/C++/Algorithms/Dig_CP/src/Dig_CP_getScores.cpp:
In member function ‘double boss::Dig_CP::getScores::retrieveScore()’:
/home/manisha/RTCode/source_updated/C++/Algorithms/Dig_CP/src/Dig_CP_getScores.cpp:89:25:
error: ‘using String = class std::basic_string’ has no member named ‘str’
hashKey.SetS(ss.str());
code
is
Aws::String ss;
hashKey.SetS(ss.str());
Aws::string is read as std::basic_string
-Manisha
—
Reply to this email directly or view it on GitHub
https://github.com/awslabs/aws-sdk-cpp/issues/67.

Thanks Jonathan
It works
-Manisha
From: "Jonathan M. Henson" <notifications<EMAIL_ADDRESS>Reply-To: awslabs/aws-sdk-cpp <reply<EMAIL_ADDRESS>Date: Tuesday, January 5, 2016 at 3:52 PM
To: awslabs/aws-sdk-cpp <aws-sdk-cpp<EMAIL_ADDRESS>Cc: Manisha Sinha <manisha.sinha<EMAIL_ADDRESS>Subject: Re: [aws-sdk-cpp] getting link error (#67)
If you are using the default build arguments with cmake, you need to be
using Aws::String in your code and passing -DAWS_CUSTOM_MEMORY_MANAGEMENT=1
to your compiler.
Or, you can turn custom memory management off when you build the sdk.
On Jan 5, 2016 12:48 PM, "msinha31" <notifications<EMAIL_ADDRESS>wrote:

Hi
I am getting link error
/home/manisha/RTCode/source_updated/C++/Algorithms/Dig_CP/src/Dig_CP_getScores.cpp:
In member function 'double boss::Dig_CP::getScores::retrieveScore()':
/home/manisha/RTCode/source_updated/C++/Algorithms/Dig_CP/src/Dig_CP_getScores.cpp:89:25:
error: 'using String = class std::basic_string' has no member named 'str'
hashKey.SetS(ss.str());
code
is
Aws::String ss;
hashKey.SetS(ss.str());
Aws::string is read as std::basic_string
-Manisha

Reply to this email directly or view it on GitHub
https://github.com/awslabs/aws-sdk-cpp/issues/67.

Reply to this email directly or view it on GitHubhttps://github.com/awslabs/aws-sdk-cpp/issues/67#issuecomment-169130304.


Remove token-adding chat embedding params

This follows the discussion in:
https://github.com/vllm-project/vllm/pull/10501#issuecomment-2489937229
Where @DarkLight1337 agreed that its better to remove the parameters altogether.
In embedding, the model does not generate additional tokens on top of the input text. Therefore, all parameters like "should a start-of-assistant-turn token be added" don't make sense, and should be removed.
This replaces that PR with the agreed-upon solution

Hey, some of the tests fail but it looks unrelated to my changes. How can we proceed with the merge?

Asking for force-merge.


Add castWireValue

As @foolswood needs it to update the bridge to the latest Clapi version, and I sneakily removed it in my gargantufactor branch!

Pull Request Test Coverage Report for Build 763

0 of 5 (0.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage remained the same at 61.802%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/Clapi/Types/Wire.hs
0
5
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/Clapi/TextSerialisation.hs
1
97.06%

Totals

Change from base Build 759:
0.0%

Covered Lines:
1482

Relevant Lines:
2398

💛  - Coveralls


Evaluate introduction of taplo for Cargo.toml formatting

Recommendation from Yang of Litentry:

Besides, I have one small point that I would like to recommend to your team:
We just introduced a tool: taplo into our parachain repo. It works quite well to format all TOML files inside the project. 2 minutes can get the formatting done. Maybe another 10 minutes for CI/pre-commit/etc. configuration if needed.
If INTEGRITEE also introduce this tool to worker, then it would be easier for us to sync with upstream update in the future.
We are using such configs for .taplo.toml config file (just for reference):

include = ["**/Cargo.toml"]

[formatting]
align_entries = false
align_comments = false
array_trailing_comma = true
array_auto_expand = false
array_auto_collapse = false
compact_arrays = true
compact_inline_tables = false
compact_entries = false
column_width = 80
indent_tables = false
indent_entries = false
indent_string =  "  "
trailing_newline = true
reorder_keys = true
allowed_blank_lines = 2
crlf = false

When we do this, then we should also update our documentation: https://integritee.atlassian.net/wiki/spaces/INTEGRITEE/pages/297664665/Coding+Guidelines

Availability

VSCode, there is an extension Even Better TOML
CLion: use it via cmmand line.

Configuration
Formatter options (https://github.com/tamasfe/taplo/blob/5cc5670f51f8c9928ce4d9f526f3175f86450024/crates/taplo/src/formatter/mod.rs#L42 ) are read from a config file ".taplo.toml". By default, taplo looks for one config file in the working directory or the root of the workspace.
Done/Tested
Clion

In local terminal (Windows)
Installation : cargo install taplo-cli --locked
Formatting command manually: taplo fmt
Use File Watchers, to run automaticall the command when a cargo file is saved. It seems to slow down Clion.

Configuration

Add a.taplo.toml config file in the root dir of the project (worker)
The best configuration I could define to follow our conventions is

include = ["**/Cargo.toml"]

[formatting]
align_entries = false
align_comments = false
array_trailing_comma = true
array_auto_expand = false
array_auto_collapse = false
compact_arrays = true
compact_inline_tables = false
compact_entries = false
column_width = 80
indent_tables = false
indent_entries = false
indent_string = "    "
trailing_newline = false
reorder_keys = false
allowed_blank_lines = 2
crlf = false
inline_table_expand = false

#rule
#array_auto_expand

[[rule]]
include = ["**/Cargo.toml"]
keys = ["dependencies", "target", "patch"]

[rule.formatting]
reorder_keys = true

[[rule]]
include = ["**/Cargo.toml"]
keys = ["features"]

[rule.formatting]
array_auto_expand = true

This fulfills the following formatting conventions

alphabetical order within a grouping of dependencies
Use the one-liner import format: frame-support = { default-features = false, git = "https://github.com/paritytech/substrate.git", branch = "master", version = "4.0.0-dev" }

But not the following :

The order of the attributes in the imports
Replace ‘ by “

In addition, it does:

convert the indent into 4 spaces
handle the whitespace :

no whitespace inside single-line arrays []
always 1 whitespace around =
always 1 whitespace afer { and before }
always 1 whitespace after a  ,

expand the array [] of features if they are too long (define by column_width)
add a , after the last element of multiline arrays.

This configuration is applied on all Cargo.toml of our project

Evaluation results:

not perfect, we still need to check the order of the attributes in the imports and the `
easy to use
a help for many details (spaces, ',', ...) that can be easily overlooked.
taplo is an active project and we can expect further improvements
taplo is young and may have bugs. So we should be able to disable it and not force formatting by any means.


limit use of tags

Some user use more than 20 tags and that is simple to much. We should limit the use of tags to 10.
What do you think?

[ ]  change text in form
[ ]  database query who many user use more than 10 tags
[ ] inform users?
[ ] keep the first 10 tags and delete the rest  :)
[ ] constrains just 10 tags


[REQ] ci check to ensure docs website deploys after a pr merges

What kind of request is this?
Other
What is your request or suggestion?
looks like mdx-js react bump causes website to break (see #223)
we should have a check to verify website deploys succeed
example: https://github.com/open-policy-agent/gatekeeper-library/blob/db402844944f1a7a0394c46e44db9b59fcaae4d8/.github/workflows/website.yaml#L56

fixed with #263


Add option to build local libchromiumcontent

Currently libchromiumcontent is downloaded by default.
Now developer can choose to provide local libchromiumcontent src, shared and static path

Tries to solve similar issue noted in: [atom/electron#3310]

When I run:
./script/bootstrap.py --libcc_source_path=../libchromiumcontent/dist/main/src --libcc_shared_library_path=../libchromiumcontent/dist/main/shared_library --libcc_static_library_path=../libchromiumcontent/dist/main/static_library
I get the following error:
Traceback (most recent call last):
  File "/Users/romaincointepas/smartflix/electron/vendor/brightray/script/bootstrap", line 97, in <module>
    sys.exit(main())
  File "/Users/romaincointepas/smartflix/electron/vendor/brightray/script/bootstrap", line 38, in main
    args.libcc_static_library_path)
  File "/Users/romaincointepas/smartflix/electron/vendor/brightray/script/bootstrap", line 85, in setup_libchromiumcontent
    subprocess.check_call([sys.executable, download, '-s'] + args)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 535, in check_call
    retcode = call(*popenargs, **kwargs)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 522, in call
    return Popen(*popenargs, **kwargs).wait()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 1335, in _execute_child
    raise child_exception
TypeError: execv() arg 2 must contain only strings

Traceback (most recent call last):
  File "./script/bootstrap.py", line 233, in <module>
    sys.exit(main())
  File "./script/bootstrap.py", line 63, in main
    args.libcc_static_library_path)
  File "./script/bootstrap.py", line 144, in bootstrap_brightray
    execute_stdout([sys.executable, bootstrap] + args)
  File "/Users/romaincointepas/smartflix/electron/script/lib/util.py", line 178, in execute_stdout
    execute(argv, env)
  File "/Users/romaincointepas/smartflix/electron/script/lib/util.py", line 166, in execute
    raise e
subprocess.CalledProcessError: Command '['/usr/bin/python', '/Users/romaincointepas/smartflix/electron/vendor/brightray/script/bootstrap', '--commit', '464aff2398f619b1d4d91b9187de69803919dca2', '--target_arch', 'x64', 'http://gh-contractor-zcbenz.s3.amazonaws.com/libchromiumcontent', '--libcc_source_path', '../libchromiumcontent/dist/main/src', '--libcc_shared_library_path', '../libchromiumcontent/dist/main/shared_library', '--libcc_static_library_path', '../libchromiumcontent/dist/main/static_library']' returned non-zero exit status 1

Not sure about the error but what seems weird is that it is still calling the brightray bootstrap script with a commit hash and the URL?

Can you please try the (change) [https://github.com/tejaspathak/brightray/commit/d4a9d15d054ebcea03f34a865417d5f009ffc4b9]
and let us know ?

Same error :/
I'm on OS X 10.11.1 with Xcode 7.1.1.
I'm using master of each repo (with a merge of recent commits from libchromiumcontent/master to its atom branch).
Did I use the new arguments correctly and pointed to the right folder? (I assume libcc source is dist/main/src, not libchromiumcontent repo?)

The change which i mentioned above [tejaspathak/brightray@d4a9d15] is not merged to main repo yet. I have generated pull request [https://github.com/atom/brightray/pull/174]  for it now. That should solve the below error that you are getting:
TypeError: execv() arg 2 must contain only strings

pls make sure that you have manually applied above change or wait till it gets merged. libcc_source_path is the directory having component directory base, chrome, url, v8 etc.
The way I tested it was...

Get the libchromiumcontent automatically without passing above options to bootstrap.
Copy the directory electron/vendor/brightray/vendor/download/libchromiumcontent/ to lets say /Work/backup_libchromiumcontent
Get new clone of electron or clean the existing one.
Then pass foll. options to bootstrap. You might also want to pass -v for verbose messages

--libcc_source_path=/Work/backup_libchromiumcontent/src --libcc_shared_library_path=/Work/backup_libchromiumcontent/shared_library --libcc_static_library_path=/Work/backup_libchromiumcontent/static_library

Wow, sorry about that, it was late, I though it was merged already.
It fixed my problem, thanks!


Code consistency

Check if the code is consistent

Do we want to leave this line of code in the functions 'papers = data' ? I see some functions use 'papers' but others dont store the data in the papers variable


support for -n flag for --namespace

Problem

Typing is hard.
Solution

We should support -n (as I believe we used to), the lack of support feels jarring when also using flux/kubectl.
Additional context

Support -n flag where? Which repo and command?

Added some context from what I assumed is meant here. @sympatheticmoose please let me know if that's what you meant.

yup - global flag on the gitops cli


Reply to inline message

Required Information

Operating system: Linux 4f02e907-5938-4afc-822d-4d6d990d9f4a 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 15:49:21 UTC 2017 x86_64
PHP version: 7.1.10 (64bit); fpm-fcgi; Linux
PHP Telegram Bot version: 0.48.0
Using MySQL database: yes
MySQL version: 5.5.56-log
Update Method: Webhook
Self-signed certificate: no

Expected behaviour
Hi,
I'm trying to reply a date to the inline keyboard, now I show an inline keyboard with today and tomorrow buttons, and I would like to add the possibility to reply to the message with a custom date dd/mm/yyyy and handle the request in the callbackquery or in another command.
How can I do it?

You could make use of conversations!
Does it have to be an inline keyboard? For something like this, it would make sense to have a normal keyboard, which also allows a custom input as a normal message.

Thank you for your advice, I will try with conversations :)


Convert to a v2 addon and drop support for Ember < 3.16

I ran ember init -b @embroider/addon-blueprint@latest --pnpm and moved things around a bit.
One thing I did notice wasn't working is the Ember Data integration, but that is probably more related to the changes in Ember Data recently🙈

All the tests are green on my test PR if you want to approve the CI run then you will see it here too 👍 https://github.com/mansona/ember-drag-drop/actions/runs/8690561655

@dgavey I can fork it into adopted-ember-addons if that works for you? If you can add me to the npm I can then make sure it's released properly 👍 (I'm real_ate on npm)

That would be awesome, thanks Chris.  Hopefully I have the rights to add you to the NPM, been a while since I've been in there.  I'll look into that today.

Ok Invite sent.

@dgavey I've created https://github.com/adopted-ember-addons/ember-drag-drop and added you as a maintainer 👍 I haven't forked this repo since that would confuse people when creating PRs (they would open to the wrong place) but we can update the readme to mention the fork status 👍

Sure thing, I'll update the readme to point to the fork. Once it's been released with a new version from the new fork,  I'll archive this repo.

Readme updated

work moved to https://github.com/adopted-ember-addons/ember-drag-drop


recording test data: remove git repos

Fixes https://github.com/packit-service/packit/issues/558
Fixes https://github.com/packit-service/packit/issues/561

packit-tests-rpm-sess-rec  : SUCCESS in 3m 08s

packit-tests-pip-deps-sess-rec  : SUCCESS in 3m 29s

packit-tests-git-master-sess-rec  : SUCCESS in 3m 41s

Is skipping all tests the only fix?

packit-tests-rpm-sess-rec  : SUCCESS in 3m 08s
packit-tests-pip-deps-sess-rec  : SUCCESS in 3m 29s
packit-tests-git-master-sess-rec  : SUCCESS in 3m 41s

Is skipping all tests the only fix?

This is the problem: https://github.com/packit-service/packit/issues/561
Either the tests (and packit code) need to be rewritten (not recording fedpkg clone and/or doing anonymous clone and fitting the tests to that -- I'm not doing that to get us unblocked) or requre needs to not store the git repo on disk - e.g. compress it and store it like that.

Okay, everything is green, merging.
Obviously, this is not a proper solution, rather a temporary fix to have everything green so that master is in good shape.
Please improve the tests - all the info is in the accompanying issues.

This is the problem: #561

I've already read that.

Obviously, this is not a proper solution

:+1:

Please improve the tests - all the info is in the accompanying issues.

PRs welcome..;-)


Update Hardhat Contract Deployment Guide Screenshot to Match New Kaiascope UI

Describe the content contribution you'd suggest
The current documentation in the hardhat contract deployment section contains outdated screenshots from Klaytnscope. This needs to be updated to reflect the latest Kaiascope UI changes.
Tasks

Replace existing screenshots in the hardhat contract deployment section with current Kaiascope UI images
Ensure all steps in the process are accurately represented

Can you assign this to me?


New feature: Highlighting whitespace errors

This PR implements highlighting of common whitespace problems (trailing whitespaces and tab/space errors), making it easy to spot such problems. It is somewhat similar to highlighting of whitespace errors by git diff.
Namely, added 2 new options hltaberrors and hltrailingws (both disabled by default).

hltaberrors highlights tabs used instead of spaces and vice versa. It uses the value of tabstospaces option as a criterion whether a tab or space character is an error or not.
If tabstospaces is on, we probably expect that the file should contain no tab characters, so any tab character is highlighted as an error.
If tabstospaces is off, we probably expect that the file uses indentation with tabs, so space characters in the initial indent part of lines are highlighted as errors.

hltrailingws highlights trailing whitespaces at the end of lines. Note that it behaves in a "smart" way. It doesn't highlight newly added (transient) trailing whitespaces that naturally occur while typing text. It would be annoying to see transient highlighting every time we enter a space at the end of a line while typing.
So a newly added trailing whitespace starts being highlighted only after the cursor moves to another line. Thus the highlighting serves its purpose: it draws our attention to annoying sloppy forgotten trailing whitespaces.

I don't really know if such smart highlighting of trailingws is implemented in any of the existing editors. If it's not, micro can be the pioneer.
A screenshot with hltaberrors and hltrailingws working on a real-life example: micro's help (it does have some trailing spaces as well as some mixture of tab and space indentation):

I don't really know if such smart highlighting of trailingws is implemented in any of the existing editors. If it's not, micro can be the pioneer.

Nano does highlighting of trailing whitespace only. As I'm transitioning from Nano to Micro, your PR is godsend!

@zyedidia what do you think about this?

Ping.

Just stumbled upon this and would welcome this addition. Is this still viable?

I'm still using it all the time. If you feel like compiling micro yourself, you can also pull this PR and try and use it.
@zyedidia Any chance you review this PR?

I would like to see this feature in the near future too, because it's a really good idea to add this in a generic way into the micro code base so it doesn't need to be considered by additional checks in the syntax files.
But just one question question from my side:
Wouldn't it be more comfortable to call the option/flag hlwserrors instead of hltaberrors?
This would fit to hltrailingws more...I guess and leaves some space for extension e.g. highlighting some text  with two spaces added.

I consider trailing whitespace an error too, so tab errors are just a special case of whitespace errors.
Or are you suggesting to combine both options into a single option, which would be not boolean but allowing to specify what to highlight: trailing ws, tab errors, or both, or neither, and perhaps others types of ws errors in the future? Maybe it's a good idea. Or maybe it isn't worth it. (BTW, the hltrailingws option name is in line with rmtrailingws.)

No, combining hltaberrors and hltrailingws wasn't the intention of my question...at least not in the first place.
In case we would combine it we most probably run in to the situation in which one would use two out of three or more possibilities/modes, which then could become complicated (by using a list of values, like in #2857), but it would reduce the amount of additional options.
So yes, that took an interesting direction.

I see here one weird thing. If we consider something as an error, we shouldn't reproduce that error but auto-indentation just copies previous line indentation so if it contained error, new line will contain the same error

If we consider something as an error, we shouldn't reproduce that error but auto-indentation just copies previous line indentation

Shouldn't we? Consider such a code:

The for loop indentation is highlighted as an error because, for example, it is indented with spaces, while the rest of the file is indented with tabs. But, if we add more lines of code to this for loop, do we really want to indent those new lines with tabs, not spaces? If we do, the existing mess does not go away (the previously existing lines in the for loop are still indented with spaces), and we in fact create more mess, since we introduce an "inner" mess inside the for loop, which is now gonna be indented partially with spaces, partially with tabs.
So I think it's better to keep things simple and keep these 2 features (highlighting indentation errors and auto-indentation) orthogonal to each other, i.e. avoid introducing interdependence rules with unexpected consequences.

Ok I think you are right

Rebased on top of the newest master (just to clean up the commit history, no functional changes).

When is this going to get merged to main code base?

When do you expect this to be merged into the main codebase? Additionally, how long has the community been waiting for this merge?

When do you expect this to be merged into the main codebase? Additionally, how long has the community been waiting for this merge?

Community asks! One more reason to ping @zyedidia

These things have bothered me a lot in the micro repos, there are PR's like this one almost 4 years old where the "owner" of the editor doesn't show up in the discussions even when called while others the merge is done in less than a month.
This can discourage the community from contributing to PRs or plugins that are in the same state (that's why I forked the plugin-channel to put the "rejected" plugins).
I believe that in the beginning only one person used this editor, but that's not the case today.
Many people spend their time helping with issues/discussions and pr's or with the creation of plugins and in addition to being valued these people should be respected.
A simple "I don't want that in my editor" would be better than 4 years of silence.
I don't want to get into the merits of individual time spent reviewing and responding to each topic.
The point is that it's no longer up to the creator to decide what goes into the editor or not.
I think we could solve this by decentralizing this power, moving the repo to an org and adding admins and builders who are motivated to improve the editor.
I hope we can achieve this without having to fork the project, but if we do that's great too, it would be a plus for the community to know that it could be active and welcomed in this fork.
It reinforced the question that my friend deleted:

[...] how long has the community been waiting [...]?

And how much longer does he intend to wait?

@dmaluka:
I think the honor is yours now. :wink:


Windows installation failed to build stardist

Dear @ksugar ,
I've been attempting to use CellSparse on Windows, but I'm encountering an issue when trying to install the Cellsparse API. This problem arises regardless of whether I'm using a CUDA-compatible GPU or CPU instructions.
The error message I receive is as follows:
ERROR: Failed building wheel for stardist
Successfully built cellsparse-api cellsparse cellpose elephant
Failed to build stardist
ERROR: Could not build wheels for stardist, which is required to install pyproject.toml-based projects

I suspect that this issue is related to the pip installer problem mentioned here
I was wondering if you have any insights on how to address this issue and successfully complete the installation of CellSparse on Windows.
Thank you for your assistance!

Dear @ksugar ,
Thank for your response. Please find the requested information below.:

Windows OS version 10.0.19045, conda version 22.9.0
Unfortunately, I'm still getting the same error

Let me know if there is any additional information I can provide.
Thanks!

Dear @paucabar , thank you for the info.
I could reproduce the error on Windows.
Did you get the message something like below?
Building wheels for collected packages: stardist
  Building wheel for stardist (pyproject.toml) ... error
  error: subprocess-exited-with-error

  × Building wheel for stardist (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [65 lines of output]
      C:\Users\guest\AppData\Local\Temp\pip-build-env-8ixr6w92\overlay\Lib\site-packages\setuptools\dist.py:745: SetuptoolsDeprecationWarning: Invalid dash-separated options
      !!

              ********************************************************************************
              Usage of dash-separated 'description-file' will not be supported in future
              versions. Please use the underscore name 'description_file' instead.

              By 2023-Sep-26, you need to update your project and remove deprecated calls
              or your builds will no longer be supported.

              See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for details.
              ********************************************************************************

      !!
        opt = self.warn_dash_deprecation(opt, section)
      running bdist_wheel
      running build
      running build_py
      creating build
      creating build\lib.win-amd64-cpython-310
      creating build\lib.win-amd64-cpython-310\stardist
      copying stardist\big.py -> build\lib.win-amd64-cpython-310\stardist
      copying stardist\bioimageio_utils.py -> build\lib.win-amd64-cpython-310\stardist
      copying stardist\matching.py -> build\lib.win-amd64-cpython-310\stardist
      copying stardist\nms.py -> build\lib.win-amd64-cpython-310\stardist
      copying stardist\rays3d.py -> build\lib.win-amd64-cpython-310\stardist
      copying stardist\sample_patches.py -> build\lib.win-amd64-cpython-310\stardist
      copying stardist\utils.py -> build\lib.win-amd64-cpython-310\stardist
      copying stardist\version.py -> build\lib.win-amd64-cpython-310\stardist
      copying stardist\__init__.py -> build\lib.win-amd64-cpython-310\stardist
      creating build\lib.win-amd64-cpython-310\stardist\data
      copying stardist\data\__init__.py -> build\lib.win-amd64-cpython-310\stardist\data
      creating build\lib.win-amd64-cpython-310\stardist\geometry
      copying stardist\geometry\geom2d.py -> build\lib.win-amd64-cpython-310\stardist\geometry
      copying stardist\geometry\geom3d.py -> build\lib.win-amd64-cpython-310\stardist\geometry
      copying stardist\geometry\__init__.py -> build\lib.win-amd64-cpython-310\stardist\geometry
      creating build\lib.win-amd64-cpython-310\stardist\models
      copying stardist\models\base.py -> build\lib.win-amd64-cpython-310\stardist\models
      copying stardist\models\model2d.py -> build\lib.win-amd64-cpython-310\stardist\models
      copying stardist\models\model3d.py -> build\lib.win-amd64-cpython-310\stardist\models
      copying stardist\models\__init__.py -> build\lib.win-amd64-cpython-310\stardist\models
      creating build\lib.win-amd64-cpython-310\stardist\plot
      copying stardist\plot\plot.py -> build\lib.win-amd64-cpython-310\stardist\plot
      copying stardist\plot\render.py -> build\lib.win-amd64-cpython-310\stardist\plot
      copying stardist\plot\__init__.py -> build\lib.win-amd64-cpython-310\stardist\plot
      creating build\lib.win-amd64-cpython-310\stardist\scripts
      copying stardist\scripts\predict2d.py -> build\lib.win-amd64-cpython-310\stardist\scripts
      copying stardist\scripts\predict3d.py -> build\lib.win-amd64-cpython-310\stardist\scripts
      copying stardist\scripts\__init__.py -> build\lib.win-amd64-cpython-310\stardist\scripts
      creating build\lib.win-amd64-cpython-310\stardist\kernels
      copying stardist\kernels\stardist2d.cl -> build\lib.win-amd64-cpython-310\stardist\kernels
      copying stardist\kernels\stardist3d.cl -> build\lib.win-amd64-cpython-310\stardist\kernels
      creating build\lib.win-amd64-cpython-310\stardist\data\images
      copying stardist\data\images\histo.jpg -> build\lib.win-amd64-cpython-310\stardist\data\images
      copying stardist\data\images\img2d.tif -> build\lib.win-amd64-cpython-310\stardist\data\images
      copying stardist\data\images\img3d.tif -> build\lib.win-amd64-cpython-310\stardist\data\images
      copying stardist\data\images\mask2d.tif -> build\lib.win-amd64-cpython-310\stardist\data\images
      copying stardist\data\images\mask3d.tif -> build\lib.win-amd64-cpython-310\stardist\data\images
      running build_ext
      No module named 'numpy.distutils._msvccompiler' in numpy.distutils; trying from distutils
      building 'stardist.lib.stardist2d' extension
      >>> compiling with '/openmp' failed
      >>> compiling with OpenMP support failed, re-trying without
      building 'stardist.lib.stardist2d' extension
      error: Microsoft Visual C++ 14.0 or greater is required. Get it with "Microsoft C++ Build Tools": https://visualstudio.microsoft.com/visual-cpp-build-tools/
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for stardist
Failed to build stardist
ERROR: Could not build wheels for stardist, which is required to install pyproject.toml-based projects

If it is the case, please install Microsoft Visual C++ 14.0 as instructed here.
https://github.com/ksugar/cellsparse-core#windows-native-with-cuda-compatible-gpu

After installing the modules, I could proceed without the error.

In the future, a pre-built module will be available so that users do not need to install a build tool.

Dear @ksugar ,
Thank you very much for the support.
Indeed, I got a message like the one you posted. After installing the modules you mentioned the installation worked and I have been able to train StarDist models with the QuPath Cellsparse extension.
However, I was not able to generate results using CellPose. I can run the training but does not generate any prediction at the end.

Dear @paucabar , I'm glad to hear that you have started working with Cellsparse.
For training a Ceppose model, please try adding more annotations and running training&inference multiple times.
From my experience, Cellpose requires more annotations and more iterations of training than StarDist.

Dear @ksugar ,
Many thanks, I'll do that.
Best wishes.


issue-25 Respect IHandlerResolver's responsibility to create handlers for every incoming message.

Aside from that, all looks good...


Consider using KMeans from scipy instead of sklearn

Following also #1616 where we moved to using the KDTree implementation from Scipy, we could also consider using kmeans from Scipy, thereby removing dependency on sklearn in  particle data.py
https://github.com/OceanParcels/Parcels/blob/997e3f86399cf319341a3d3f4fb1c5dc339e2580/parcels/particledata.py#L15
We need to check/investigate though whether the behaviour of scipy.cluster.vq.kmeans is the same as that of sklearn.cluster.KMeans

Ooo, didn't know scipy also did kmeans.
Briefly looking into it, it seems we'd get a performance hit by moving to scipy's implementation. This is noted in the notes section of their API on this, and there's a dedicated comparison here.