Do you have plans for supporting other chart types?

I was wondering if you had any plans for supporting the following chart types:

[x] Boxplot.

[ ] Scatter plot.

[x] Heat map.

[x] Histogram.

[ ] Geospatial map.

[x] Segmented (stacked) bar plot within each level.

[x] Dodged (side-by-side) bar plot within each level.

I know, we cannot cover everything at once, but it would be great if we could prioritize some chart types. FYI, our team has been working on SVG-based accessible charts for bar plot, boxplot, heat map, and scatter plot. Will share our progress as well going forward. We are also trying to keep the same json metadata format in our own module to be compatible with C2M in the long run.

Bar charts
We already support bar charts with multiple categories. Here is a stacked bar chart example. Here is a side-by-side bar chart example. The categories are effectively in separate layers, and you press Page Up or Page Down to navigate between each category.
Note that, for stacked bar charts, C2M never communicates the total of all of the bars. I can look into that.
Histograms
Sure, we can add support for that pretty easily.
Box plots
We can support box plots, but it'll be a few weeks before we can get to it.
Scatter plot and heatmap
We don't currently have plans to work on that. We need to do a more extensive literature review to see if anyone's done research into the best approach for that dense of data.
Geospatial maps
We'd consider that to be outside the bounds of what Chart2Music can reasonably cover. Additionally, this patent fairly aggressively covers sonification of geospatial data, so I'd be concerned about possible patent infringement.

Thanks for your response. Scatterplot is a quite challenging when it comes to representing point spreadness although it's easily possible to sonify its smoothed best-fit line. I have been trying to use background noise to address that. Regarding heat maps, do you think it's possible to use one more spatial audio panning sound (up and down) just like left and right stereo mode to represent the grid? I know it might require 3D audio sound output device for users to fully benefit from its 4-way-direction audio channel though.

@julianna-ciq -- This is great! I understand that the boxplot feature is still experimental, but it's pretty neat. Is there any special reason for you not to include outliers in the up/down arrow statistic cycle?

There were a lot of unanswered questions about the best way to approach it.
Because there could be several outlier values for a box plot. I feel like a good UX for that would be using the up/down arrow keys to go between each individual item, but I wasn't confident about the best way to architect that just yet. Also, do I want all outliers to appear in the same place, or should lower/upper outliers be separated out? Sometimes outliers are labelled; how should those labels be handled? What if I just had a dialog that listed individual outliers for each box, instead of trying to sonify them? If I play the full box, should I include the outliers because their relevant, or exclude the outliers because it may confuse the user about where the core of the box actually exists?
These are some of the design questions I'd like to experiment with before I try to ship a more fleshed-out box plot sonification.
Please let me know if you have any thoughts or reactions to any of these questions. I was hoping to put together some samples of different ways to sonify a box plot, and then let people try them out. Unfortunately, I haven't had time to build any of these PoCs yet.

Today, we released version 1.6.1, which includes support for heatmaps and correlation matrices. The type we use for both of them is "matrix". You can see examples of both here:

Star Trek episode ratings
Example with amCharts 5

Both examples include visual syncing.
When designing the interaction model for a matrix/heatmap, we wanted the end user's cognitive burden to be as low as possible. So, we took interactions for bar and line charts, and we applied them to a matrix. When you interact with a matrix, you can use the left/right arrow keys to navigate between columns, and you can use Page Up / Page Down to navigate between rows.

We currently support 5 of the 7 chart types you asked about. The other 2, scatter plots and geospatial maps, are out of scope for us at this time.
For scatter plots, we've experimented with a couple of approaches to scatter plots, but we're not happy with the design or implementation details for any of them. For now, scatter plots will have to be on the backburner.
For geospatial maps, we consider those to be far outside the scope of Chart2Music, and we have no plans to support them at this time.


Fix issue 673

Ⅰ. Describe what this PR does
Add event and processing for corner case:

When dataload's namespace is different from dataset, will record event and noqueue
When onece the path of target dataset doesn't exist, will record event and noqueue

Ⅱ. Does this pull request fix one issue?

#673
Ⅴ. Special notes for reviews
@yangyuliufeng @TrafalgarZZZ

Thanks for fixing this. I am just wondering if it's necessary for DataLoad to fail fast when the namespaces are not the same. Maybe we should allow the difference and warn users about it instead of failing fast? Or fail at the TargetDatasetNotFound point?

I have tested this PR. And under the current implementation, no bugs have been found.

Thanks for fixing this. I am just wondering if it's necessary for DataLoad to fail fast when the namespaces are not the same. Maybe we should allow the difference and warn users about it instead of failing fast? Or fail at the TargetDatasetNotFound point?

Good point. Maybe it's better to use pending status rather than fail fast. @TrafalgarZZZ WDYT? Maybe we can enhance it in the next PR?

Thanks for fixing this. I am just wondering if it's necessary for DataLoad to fail fast when the namespaces are not the same. Maybe we should allow the difference and warn users about it instead of failing fast? Or fail at the TargetDatasetNotFound point?

Good point. Maybe it's better to use pending status rather than fail fast. @TrafalgarZZZ WDYT? Maybe we can enhance it in the next PR?

LGTM. We can enhance it in the future.

@TrafalgarZZZ @cheyang @XIAO-HOU Thanks, i will enhance the feature in next pr.


fix integer out of range for apipayments

related to PR #1030, this was missing

Codecov Report

Merging #1133 (1971b9a) into main (706eef2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1133   +/-   ##
=======================================
  Coverage   48.73%   48.73%
=======================================
  Files         239      239
  Lines       13494    13494
=======================================
  Hits         6576     6576
  Misses       6918     6918

Impacted Files
Coverage Δ

lnbits/core/migrations.py
74.35% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merging:

regtest failed checks unrelated to this PR
I will fix formatting check on a separate PR

Thank you for your contribution @ChuckNorrison !

Great work guys. Do this PR fixes this?
https://github.com/lnbits/lnbits/issues/1069#issuecomment-1315931984

I can take a look and create a last PR to finally fix those column types.

Please do, I wonder how did I miss those...
Thank you again!


Add support for Java 8

Closes https://github.com/Jasig/cas/issues/957

Good stuff. Now we want to make sure that all tests pass :-)

We'd want to ignore codeship for now; since a number of oauth tests require the java 8 JCE to be installed and we can't accommodate that easily via codeship. I spoke to @leleuj about this, and it seems like we'd able to solve that issue with a few updates to the underpinning oauth libs. So I'd leave that one be for now, failing. Travis is where we'd want to focus on, since it's able to install the JCE and get tests passed. I'll see what the failures are all about next.

As JWT support has been removed per #1425, OAuth tests should pass now. In the build, I see a problem with Checkstyle.

Working through a few remaining javadoc issues. about 60% done.

OK Travis is now fully building the branch. Shall we merge and continue?

I think so, I don't think we have any better option. The change is huge, mostly around date time stuffs. It's better to move on, we'll fix problems in future pull requests (we're on the master and far away from the release date).

Sounds good to me. @dima767 @frett  ?

+1
On Thu, Feb 4, 2016 at 11:25 Misagh Moayyed<EMAIL_ADDRESS>wrote:

Sounds good to me. @dima767 https://github.com/dima767 @frett
https://github.com/frett ?
—
Reply to this email directly or view it on GitHub
https://github.com/Jasig/cas/pull/1512#issuecomment-179928728.

Do we know when we can expect 4.3.0 be released?

Keep watching the milestone dates.


Wrong date on events when user is in different timezone

People are reporting they see different dates for the events in different timezones.
https://github.com/blockchainweek/data/issues/65#issuecomment-2099179524
https://github.com/blockchainweek/data/issues/47#issuecomment-2096689159
https://github.com/blockchainweek/data/issues/49#issuecomment-2099143380
I tried to debug the issue and was able to reproduce it with a timezone spoofer on my browser. The weird things is, the date initially shows correct then in a eye-blink it changes to the wrong date. However I wasn't able to catch the formatItemDate function or other formatters running twice. They only give console.log outputs once. Maybe that's about something I don't know about how Svelte works.
This happens on each refresh. I am refreshing in the video below.
https://github.com/blockchainweek/explore/assets/13069972/e3e92f87-8905-47ea-82d8-41b0e7853af5
I was able to track down the issue into the format function of the date-fns. The input to it is the non-timezoned date but it spits out the date in the timezone of the browser. And even in some examples it made the timezone +s to -s and vice-versa.
Take this code snippet I tried for example:
export function formatItemDate(item, opts = {}) {
	console.log(item.name);
	console.log(item.date);
	// Directly parse the ISO string into a date object with parseISO
	let dt = parseISO(item.date + 'T00:00:00'); // Add time to ensure it's the start of the day

	console.log('dt: ' + dt);
	let formattedDate = format(
		dt,
		'MMMM d hh:mm a O' + (opts.full && item.days === 1 ? ', yyyy' : '')
	);

	console.log('formattedDate: ' + formattedDate);
	if (item.days > 1) {
		let endDate = addDays(dt, item.days - 1);
		formattedDate += '-' + format(endDate, 'd' + (opts.full ? ', yyyy' : ''));
	}

	return formattedDate;
}

This is the output of this function call with item = { date: "2024-05-22", name: "Web3privacy now meetup"}
Web3privacy now meetup
2024-05-22
dt: Wed May 22 2024 00:00:00 GMT-0400 (Eastern Daylight Time)
formattedDate: May 21 11:00 PM GMT+4

The weird things is, the date initially shows correct then in a eye-blink it changes to the wrong date.

@kuzdogan This is because of SSG (Static Site Generation) or SSR (Server-Side generation). The correct timezone is probably set on the server, so it is generated correctly - but since the client has a different timezone, it is immediately swapped with the client-side date after hydration.
The solution is to make sure that the dates are consistent across server and client.
In the case of the snippet above, it is to use ISO Date which has a specified timezone. That is:
Instead of this:
let dt = parseISO(item.date + 'T00:00:00');

use this:
let dt = parseISO(item.date + 'T00:00:00Z');

The "Z" at the end guarantees that the date will always have the same timezone.

Unfortunately this is something that hasn't been resolved in the original Explorer by PBW.
As a systematic solution I suggest:

add a timezone flag to each year in the data repository - this will serve as a reference timezone, in this case "Europe/Berlin"
in explorer, load the date in the correct timezone via dateFnsTz.fromZonedTime() (according to the flag) - I recommend converting to Z
in the interface then display the dates via dateFnsTz.formatInTimeZone() (i recommend to show in Europe/Berlin) instead of via dateFns.format()

https://github.com/marnusw/date-fns-tz

Fixed with https://github.com/blockchainweek/explore/commit/46a9082e8da069a76ba2bf10929e7b5728a55223
However using the formatInTimeZone function in the TimelineHeatmap breaks the build. I can build locally (M1 Pro Mac) but the Github Ubuntu builds hang indefinitely https://github.com/blockchainweek/explore/actions/runs/9022033526
Anyways turns out formatInTimeZone in TimelineHeatmap is not required according to what users with the issues are reporting
https://github.com/blockchainweek/data/issues/47#issuecomment-2102855853
https://github.com/blockchainweek/data/issues/65#issuecomment-2102704078


Feat: Add eye symbol for password in booklists for swapping

Describe the feature
There is no eye symbol in the password section in the booklists for swapping.

Please assign this task to me!
Add ScreenShots
I want to add the eye symbol which helps to show the password and hide as well.

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Assigned!
Make sure to attach before & after screenshots in your PR. Also, star the repo before working on it. While creating your PR, ensure you pull all existing changes beforehand to avoid conflicts.
Happy open-source contributing!


Feature request: Support for JSONB in postgresql

Hi there,
can you please give me an advice how to store JSONB (binary) values into postgresql?
Table
create table tb_test
(
  "value" jsonb,
);

What I tried
let params = vec![
  ParameterValue::Binary(json_string.into_bytes()),
];
connection.execute("INSERT INTO tb_test VALUES ($1)", &params);

error output:
Error::QueryFailed("Error { kind: ToSql(1), cause: Some(WrongType { postgres: Jsonb, rust: \"alloc::vec::Vec<u8>\" }) }")

also as string does not work
let params = vec![
  ParameterValue::Str(json_string.clone()),
];
connection.execute("INSERT INTO tb_test VALUES ($1)", &params);

error output:
fail: Error::QueryFailed("Error { kind: ToSql(1), cause: Some(WrongType { postgres: Jsonb, rust: \"alloc::string::String\" }) }")

environment

spin: 3.0.0
postgresql: 17
rust

The Spin Postgres API doesn't yet support the jsonb type.  I can take a look at adding that.  In the meantime, is it practical for you to work around this by using a binary column (or a string column with the JSON as text)?

Hi @itowlson, thanks a lot and that would be great.
I really like your workaround. I will add an additional string column and would just have to migrate later. I had the idea of making a separate rust app, but that would be counterproductive.
Could you please tell me why postgresql and mysql are classified as "experimental"? They are pretty basic for a service, aren't they?

"Experimental" here means "we are not sure we have the right interfaces", rather than "we are not sure it works."  In practice they have been stable across multiple versions of Spin, and we have retained backward compatibility, so we should really remove that designator!
But for example we introduced a new Postgres interface in Spin 3, to allow for date-time types.  And those are a minefield which we may not have gotten right on the first go!  So in a sense those are experimental.  But if we do change them it will be "new interface alongside the existing one," just as Spin 3 continues to support the Spin 2 Postgres interface.  The existing interfaces won't break.

Thanks for clarifying the term as it is in use. To me, as an user of Spin, “experimental” looks like it might mean I shouldn't use it in production. Perhaps it should be called stable for mysql/postgres in general and explain which functions in particular are “experimental”.
As a further workaround for jsonb, I have now created a stored procedure and do not need a migration script:
CREATE PROCEDURE insert_data(a text)
LANGUAGE SQL
AS $$
INSERT INTO tbl VALUES (jsonb(a));
$$;


Remove binaries from source code

Automatize downloading from ultralight mirror binaries of specified commits, and use it.

It becomes much more noticeable problem - i have 6gb git pack file


Ionic searchbar: filtered items are updated only when keyboard is dismissed in android

Ionic version:  (check one with "x")
[ ] 1.x (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[ x] 3.x
I'm submitting a ...  (check one with "x")
[ x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
Filtered items are updated only when keyboard is dismissed.
Expected behavior:
Filtered items updated real time when input changes. As we can see on the official documentation
Steps to reproduce:
Copy and past offical docs and run in real android device.
Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
global packages:

    @ionic/cli-utils : 1.4.0
    Cordova CLI      : 7.0.1
    Ionic CLI        : 3.4.0

local packages:

    @ionic/app-scripts              : 1.3.7
    @ionic/cli-plugin-cordova       : 1.3.0
    @ionic/cli-plugin-ionic-angular : 1.3.0
    Cordova Platforms               : android 6.2.3 browser 4.1.0
    Ionic Framework                 : ionic-angular 3.3.0

System:

    Node       : v7.10.0
    OS         : Windows 10
    Xcode      : not installed
    ios-deploy : not installed
    ios-sim    : not installed
    npm        : 4.2.0

Which doc exactly did you copy?
What is your android's version?

7.1.1 my phone, but also some other which I don't know the version.

I add that also the search button displayed on the keyboard does nothing

Hello @Alb93 , would you mind posting a repo we could use to reproduce this issue? I am not able to repro this issue on my device (A nexus 6 running 7.1.1)

Hi @jgw96 , can you share with me your attempt? If you have done only this page this will be this faster way and then I can try on my android.

Hello @Alb93 , I'm just using our conference app demo to test this. The schedule page (first tab that shows when you open the app) has a searchbar on it.

Hello all! As it seems it has been a while since there was any activity on this issue i will be closing it for now. Feel free to comment if you are still running into this issue. Thanks for using Ionic!


Implement for GCC

@jwakely i think this is done?

I need to update some constraints to match the final wording, but will push it to GCC trunk some time this week (probably).


[Feature Request] Tree Table Adding Customization to Subtable Columns

Existing Component
是
Component Name
el-table
Description
Subtables of tree data want to customize column names, column numbers, and methods, rather than using columns from parent tables.

Sorry, we have no plan to support this.


Import grafana dashboards skipping with variable dashboard_id

What happened?
Import grafana dashboards skipping with variable dashboard_id
Did you expect to see some different?
Import grafana dashboards not skipping with variable dashboard_id
How to reproduce it (as minimally and precisely as possible):
Environment

Role version:
- cloudalchemy.grafana, 0.18.0

Ansible version information:
ansible [core 2.12.2]

Variables:

insert role variables relevant to the issue

Ansible playbook execution Logs:

---
- name: Install prometheus and Grafana
  hosts: prometheus
  roles:
    - role: cloudalchemy.node_exporter
    - role: cloudalchemy.prometheus
      vars:
        prometheus_targets:
          node:
          - targets:
            - localhost:9100
    - role: cloudalchemy.grafana
      vars:
        grafana_security:
          admin_user: admin
          admin_password: enter_your_secure_password
        grafana_datasources:
          - name: prometheus
            type: prometheus
            access: proxy
            url: 'http://localhost:9090'
            basicAuth: false
        dashboards:
        - dashboard_id: 1860
          revision_id: 26
          datasource: prometheus

Anything else we need to know?:

Change dashboards to grafana_dashboards and fixed


fix(app): fixed issuance preview screen in web (WIP)

Signed-off-by: Anton Biriukov<EMAIL_ADDRESS>

Codecov Report
Patch and project coverage have no change.

Comparison is base (2dcdb29) 89.98% compared to head (09d322a) 89.98%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #587   +/-   ##
=======================================
  Coverage   89.98%   89.98%
=======================================
  Files          98       98
  Lines        3896     3896
=======================================
  Hits         3506     3506
  Misses        258      258
  Partials      132      132

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Developed Home and Questionnaire pages

Please review Home and Questionnaire pages.
Thank you,
Sergey

Add some automated test as appropriate.
Also as discussed previously if you are not using some of the automation libraries yet then I would like those to be removed. Add those only when in use please. This is a generic/overall comment.
@skiselev1
Thanks!

Required cleanup is not done fully.
Missed seeing automated test though automated test libraries are added.


Filter decorators

Added support for outgoing message filters decoration. Decorators are required by Contour.Caching.

Branch is merged into move-caching


remove whitespace in German translation

Remove double whitespaces at the beginning of the sentence.

I'll include it, thanks.


vendors/espressif: ESP-IDF v4.4.2 upgrade and added support for ESP32-S3

Description

Updated the ESP-IDF submodule to the stable v4.4.2 release.
Updated the Amazon FreeRTOS port for compatibility with ESP-IDF v4.4.2.
Added support for ESP32-S3 SoC

Related

Depends on https://github.com/FreeRTOS/FreeRTOS-Kernel/pull/572
Resolves https://github.com/aws/amazon-freertos/issues/3459
Resolves https://github.com/aws/amazon-freertos/issues/3494
Closes https://github.com/aws/amazon-freertos/issues/3534
Closes https://github.com/aws/amazon-freertos/issues/3518

Notes

The FreeRTOS-Kernel submodule for this PR is based on the latest main branch commit - https://github.com/FreeRTOS/FreeRTOS-Kernel/commit/195a351ec797ba434c0e00fbba1d1f6adb74e279.
The ESP-IDF v4.4.x release requires an updated toolchain (xtensa-esp32xx-elf-gcc esp-2021r2-patch3-8.4.0) and is not compatible with the older toolchain used in Amazon FreeRTOS (xtensa-esp32xx-elf-gcc esp-2020r3-8.4.0).
For getting started with ESP32-S3, please refer to the guide here.
Users who want to test this PR can use the following commands -

git fetch origin pull/3541/head:afr_branch
git checkout afr_branch
git submodule update --init --recursive --checkout

Checklist:

[ ] I have tested my changes. No regression in existing tests.
[ ] My code is Linted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

plz, merge this change to aws/amazon-freertos as soon as you can, I have download hase/amazon-freertos and build my esp32s2 code successful.

Hello, @aggarg and @paulbartell!
This pull request updates ESP-IDF shipped with AFR to v4.4.2 and also adds support for the ESP32-S3 SoC.
As mentioned, the FreeRTOS-Kernel submodule for this PR is based on the latest main branch commit - https://github.com/FreeRTOS/FreeRTOS-Kernel/commit/195a351ec797ba434c0e00fbba1d1f6adb74e279. The same for AFR main branch is set at v10.4.3 LTS Patch 2 and there is a draft PR for updating it - https://github.com/aws/amazon-freertos/pull/3507.
Will we have to wait till the above draft PR is merged? Is there a plan to use only LTS versions of the FreeRTOS kernel in the AFR main branch henceforth?
CC: @mahavirj

works without issues
I have download hase/amazon-freertos and build my esp32s3 code successful.

The iot-reference integration for the ESP32S2 can be found as part of this repo:
https://github.com/FreeRTOS/iot-reference-esp32c3
This repo uses IDF 4.4 so it has support for all ESP32 devices.


colorSecondary not found

Description of the bug
Execution failed for task ':app:processDebugResources'.
> A failure occurred while executing com.android.build.gradle.internal.res.LinkApplicationAndroidResourcesTask$TaskAction
   > Android resource linking failed
     ERROR:C:\Users\libre\.gradle\caches\transforms-3\93da2a817caaa50f356b53b2252236fa\transformed\jetified-oneui-2.3.0\res\values\values.xml:899:5-902:13: AAPT: error: resource attr/colorSecondary (aka com.diccionario:attr/colorSecondary) not found.

To Reproduce
Create a sample react-native Android project, update android/src/build.gradle to add the dependency, update android/src/main/AndroidManifest.xml for theme, run npx react-native run-android.
Expected behavior
Expect the build to succeed
Screenshots
N/A
Device/IDE

Android Version: AVD API 31
IDE and Version: Android Studio, Target API 30

Additional context
Very new to Android development and not sure if this library can be applied with react native at the same time

If you have it enabled, try to remove the nonTransitiveRClass flag in your project's gradle.properties file. Separated R classes seems to give issues with the lib as saw in issue #47

gradle.properties file is very simple:
# Project-wide Gradle settings.

# IDE (e.g. Android Studio) users:
# Gradle settings configured through the IDE *will override*
# any settings specified in this file.

# For more details on how to configure your build environment visit
# http://www.gradle.org/docs/current/userguide/build_environment.html

# Specifies the JVM arguments used for the daemon process.
# The setting is particularly useful for tweaking memory settings.
# Default value: -Xmx1024m -XX:MaxPermSize=256m
# org.gradle.jvmargs=-Xmx2048m -XX:MaxPermSize=512m -XX:+HeapDumpOnOutOfMemoryError -Dfile.encoding=UTF-8

# When configured, Gradle will run in incubating parallel mode.
# This option should only be used with decoupled projects. More details, visit
# http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects
# org.gradle.parallel=true

# AndroidX package structure to make it clearer which packages are bundled with the
# Android operating system, and which are packaged with your app's APK
# https://developer.android.com/topic/libraries/support-library/androidx-rn
android.useAndroidX=true
# Automatically convert third-party libraries to use AndroidX
android.enableJetifier=true

# Version of flipper SDK to use with React Native
FLIPPER_VERSION=0.99.0

I don't think there is anything nonTransitiveRClass flag?

Nope there isn't, so that's not the issue. AndroidX and Material Components dependencies are declared in your build.gradle file, right?
implementation 'androidx.appcompat:appcompat:1.4.1'
implementation 'com.google.android.material:material:1.5.0'

Aha, if I add those, the errors will be gone, but I'll have errors with React native instead. I think React Native development can't use this library directly then


Allow attributes override, or at least constraint

In DDD it may be needed to override attribute in a sub-struct.
For example, I have a Customer with optional #address, but in Order I need Customer with mandatory #address.
I have an option to define class CustomerWithAddress < Customer with overwritten #address attribute, but with current implementation it's impossible to do it.
Also, we can think about better specific DSL for such things, like Customer.constrained(required_attribute: :address).
In this case, we need to have ability to revert .optional from Dry::Type.
Tell me your idea/opinion, and I can try to make PR.

I have mixed feelings about this but it wouldn't be a difficult thing to implement (mostly code removal). WDYT @backus @flash-gordon @timriley ?

IIRC we agreed somewhere on the Internet this should be allowed, this is defo not a hard thing to do :)

Yeah, I think it would be an expected thing to be able to override an attribute in a subclass.

Worth mentioning that right now we violate POLS here, so now I'm thinking we should do this

I'll send a PR

Interesting. In our private codebase that uses dry-struct we also ended up with some models named FooWithBar for somewhat different reasons. We more or less grew to view it as an anti-pattern and implemented a new abstraction outside of dry-struct to address this.

It might be nice to require the dry-struct user to be explicit about the cases where they want to do this. In other words, instead of
class Customer < Dry::Struct
  attribute 'address', Dry::Types['address'].optional
end

class CustomerWithAddress < Customer
  attribute 'address', Dry::Types['address']
end

what if the method here was
class CustomerWithAddress < Customer
  redefine_attribute 'address', Dry::Types['address']
end

I think this would be nice

We more or less grew to view it as an anti-pattern and implemented a new abstraction outside of dry-struct to address this.

@backus could you tell a bit more? I never liked structs like User and then UserWithAddress (although I had cases where coming up with a nice and meaningful name was really simple)

Well we don't use ROM so at first our queries would have to return a model that properly fit the data being returned. Therefore, initially, we had to create one-off models that would specify the exact relationship being returned for each query. Now we do something more dynamic depending on the data returned by the query. I can give more context if that is helpful, but the problem in our case I think was just that we are using dry-struct only and no ORM along with it

@backus so sounds like you built something similar to rom-repository, it builds structs dynamically based on relation schemas (dry-struct under the hood!)

Maybe. I'm not sure how much ROM::Repository does. This is basically a specialized delegation wrapper that doesn't abuse method_missing.
class App
  class Relationship
    include Concord.new(:primary_model, :included_models)

    def initialize(primary_model, **included_models)
      super(primary_model, included_models)

      delegate_to_model
      delegate_to_included
    end

    private

    def delegate_to_model
      model_methods.each do |method_name|
        define_singleton_method(method_name, &primary_model.method(method_name))
      end
    end

    def model_methods
      primary_model.public_methods - Dry::Struct::Value.public_instance_methods
    end

    def delegate_to_included
      included_models.each { |name, model| define_singleton_method(name) { model } }
    end
  end
end

Usage is like
customer = App::Relationship.new(
  customer_data,
  address: address_data,
  name:    name_data,
  order:   order_data
)

where the behavior is

via Relationship
Delegation

customer.id
customer_data.id

customer.address.street1
address_data.street1

customer.name.first
name_data.first

customer.order.tracking_number
order_data.tracking_number

It is pretty helpful. I'm sure ROM::Repository does way more.

@backus that's pretty clean, given the amount of dynamic behavior :)

I'm sure ROM::Repository does way more.

It does, but it uses dry-rb gems so a ton of complexity is handled by these gems, which made implementing pretty advanced features in rom really simple. Repositories automatically map relation tuples, including tuples from composed relations, into structs or struct aggregates. You can project data however you like and repos will always know what kind of structs it needs to create. They are cached so classes are created only once for every unique relation.
If you dump a relation into ast you'll see things that should look familiar:
[6] pry(main)> repo.users.to_ast
=> [:relation,
 [:users,
  {:dataset=>:users},
  [:header,
   [[:attribute, #<ROM::SQL::Type[Integer] primary_key=true name=:id source=ROM::Relation::Name(users)>], [:attribute, #<ROM::SQL::Type[NilClass | String] name=:name source=ROM::Relation::Name(users)>]]]]]

and a composed relation:
[8] pry(main)> repo.aggregate(:tasks).to_ast
=> [:relation,
 [:users,
  {:dataset=>:users},
  [:header,
   [[:attribute, #<ROM::SQL::Type[Integer] primary_key=true name=:id source=ROM::Relation::Name(users)>],
    [:attribute, #<ROM::SQL::Type[NilClass | String] name=:name source=ROM::Relation::Name(users)>],
    [:relation,
     [:tasks,
      {:keys=>{:id=>:user_id}, :combine_type=>:many, :combine_name=>:tasks, :dataset=>:tasks},
      [:header,
       [[:attribute, #<ROM::SQL::Type[Integer] primary_key=true name=:id source=ROM::Relation::Name(tasks) qualified=true sql_expr=#<Sequel::SQL::QualifiedIdentifier @table=>"tasks", @column=>"id">>],
        [:attribute,
         #<ROM::SQL::Type[Integer] foreign_key=true target=:users name=:user_id source=ROM::Relation::Name(tasks) qualified=true sql_expr=#<Sequel::SQL::QualifiedIdentifier @table=>"tasks", @column=>"user_id">>],
        [:attribute, #<ROM::SQL::Type[NilClass | String] name=:title source=ROM::Relation::Name(tasks) qualified=true sql_expr=#<Sequel::SQL::QualifiedIdentifier @table=>"tasks", @column=>"title">>]]]]]]]]]

All these attributes are backed by dry-types with extended API for rom-sql :)

Jeez that is pretty neat. Maybe I need to give ROM another look for this project soon.

@backus we're about to release rom 3.0.0 rom-sql 1.0.0 and rom-repository 1.0.0, so it's gonna be a really good time to check it out :)

Just an idea: that while it may be too powerful and dangerous to allow arbitrary type redefine,
some DSL for type extension would be neat.
class A < Dry::Struct
  attribute :attr, Types::Strict::String
end

class B < A
  extend_attribute :attr, &:optional
end

Actually, having opposite modifier to cancel .optional (.required?) along with such ability would cover 95% of use cases.
Can you imagine other need to redefine attribute other than make it required?
P.S. I understand that this idea is much harder to implement, so consider as just one more opinion =)

@solnic also, can I kindly ask to take a look into this issue, as it's crucial in DDD modelling and helpful, at least for us =)

Jeez that is pretty neat. Maybe I need to give ROM another look for this project soon.

@backus we're about to release rom 3.0.0 rom-sql 1.0.0 and rom-repository 1.0.0, so it's gonna be a really good time to check it out :)

As a followup, we are about to add ROM to our primary codebase :smile:

@backus oh wow that's fantastic! ping me if you need any help


Rtl labels support

reference: #2543
For usage see Label documentation and Label sandcastle example.
Supports new lines
Currently supports Hebrew (should easily support other RTL languages)
Tasks:

[ ] Add support for more languages
[ ] Fix case when there is RTL characters, numbers and space (ex: משתמש10 )

Wow, very cool thanks for the nice contribution @hodbauer and @YonatanKra!
@ggetz could you take a first look at this then pass it on to @bagnell for a final review and merge?

Hi @hodbauer, I see you made updates. Are you ready for another look?

Hi @ggetz
I'll be glad if you go over it again.
I want to clarify why I didn't change the logic at the rtl setter. From a check that I've done it seems that the label ran the algorithm even if I didn't call the reverseRtl from the setter of rtl.

@hodbauer, everything looks good except I still think you should reconsider the rtl setter.
In the sandcastle example, if I run this:
    var label = viewer.entities.add({
        position : Cesium.Cartesian3.fromDegrees(-75.1641667, 39.9522222),
        label : {
            text : 'Master (אדון): Hello\nתלמיד (student): שלום'
        }
    });

    label.rtl = true;

The rtl portion of the text will be reversed, which is not the same results as this:
viewer.entities.add({
        position : Cesium.Cartesian3.fromDegrees(-75.1641667, 39.9522222),
        label : {
            text : 'Master (אדון): Hello\nתלמיד (student): שלום',
            rtl : true
        }
    });

Ok @ggetz I'll check this case again and update the code according to the results

I have a question @ggetz.
At the sandcastle I ran a simple case like that:
var label = viewer.entities.add({
        position : Cesium.Cartesian3.fromDegrees(-75.1641667, 39.9522222),
        label : {
            text : 'Hi'
        }
    });
    label.text = 'Bye';

I was expect that the label at Cesium will be Bye, but it was Hi.
If this case not work, how the case that you mention before will work for me? What I was missing?
(It also was checked at the official Sandcastle)

After another check at Sandcastle I've got the next solution.
    var entity = viewer.entities.add({
        position : Cesium.Cartesian3.fromDegrees(-75.1641667, 39.9522222),
        label : {
            text : 'Master (אדון): Hello\nתלמיד (student): שלום'
        }
    });
    entity.label.rtl = true;

now it just work fine.
Waiting for your response @ggetz.

@hodbauer My mistake, you're correct!
@bagnell You're up for final review and merge.

Are we okay with using rtl rather than rightToLeft, we usually don't use abbreviations in our API, but rtl is a fairly common one.

Are we okay with using rtl rather than rightToLeft, we usually don't use abbreviations in our API, but rtl is a fairly common one.

Let's go with rightToLeft.  I do not think rtl is common enough for our users.

@pjcozzi,
I renamed it from rtl to rightToLeft.

@hodbauer please resolve the merge conflict with master when you have a chance.  Thanks!

@pjcozzi , @ggetz , @hpinkos any news about this PR?

@hodbauer it looks like there are some issues with the commits in this PR.  Can you merge in master and reset it properly so just your commits show up.  If so I'll try and get this into master for the next release.

@mramato, I've updated the branch so it will be only my changes, thanks for the attention.

@mramato any news?
what is the next version date to update the CHANGES.md file as needed?

@hodbauer November 1 is the next release, version 1.39.
@pjcozzi Did we need this reviewed by @bagnell or is this ready to go?

Sorry for the delay @hodbauer

Add support for more languages

What does this mean exactly?  Does this code not work on all RTL languages?
Have we tried this on all browsers?

@pjcozzi Did we need this reviewed by @bagnell or is this ready to go?

@bagnell, @mramato, or @tfili could review this.
Please make sure that test coverage is high enough as there are a lot of branches.

Add support for more languages
What does this mean exactly? Does this code not work on all RTL languages?

In the algorithm that I've wrote there is a regex that detects if the character is of RTL language.
But to actually detect different languages the letters of the language should be added to the regex.
I know how to write in Hebrew so it support it right now, but if we want to support more languages like Arabic it should be added to the regex and actually to check if it's looks good after rendering.

Have we tried this on all browsers?

No, checked only on chrome for windows.

Please make sure that test coverage is high enough as there are a lot of branches.

Is there a way to see what exactly covered?
I'll update the .md files in the coming days.

For test coverage, see https://github.com/AnalyticalGraphicsInc/cesium/tree/master/Documentation/Contributors/TestingGuide#run-all-tests-against-combined-file-run-all-tests-against-combined-file-with-debug-code-removed

summary after another iteration:

Have we tried this on all browsers?

It tested on Chrome, firefox and edge

Please make sure that test coverage is high enough as there are a lot of branches.

hopefully all the branches covered by adding more tests. When Iv'e added the tests I fix some edge cases.
Another interesting thing that I found during this tests is that JScoverage lib not support hebrew characters, so I changed my regex that detect Hebrew from /[א-ת]/ to the unicode represent /[\u05D0-\u05EA]/.
Also I was tried to understand if I can support Arabic or other rtl languages and understand that if I cannot read it I shouldn't promise that it work fine...

@hodbauer thanks for the diligent updates.
@mramato did you want to look at this again and merge when ready?

Sure, I'll try and get to this before the end of the week.

I merged in master for you and just have those few suggestions/questions.
Thanks again for the awesome work here, I'm sure a huge section of our community will be excited to have RTL support at last.

I don't know why but I've got this error while running travis ci:
Core/WebGLConstants
 ✗ freezes render states
	Expected function to throw an exception.

Any help about this issue, it not part of my changes

@hodbauer Seems to be failing across multiple branches, I opened #5924

@hodbauer I fixed that test in master, so if you merge that into your branch CI should pass. Thanks!

@ggetz @hpinkos @mramato thanks for solving the problem!
@mramato we could continue with the PR

As @mramato offered, I changed the way to enable the right-to-left algorithm.
The new way is by setting a static parameter of Label, currently named Label.enableRightToLeftDetection to true, then every update to any label will run the algorithm.
The only issue about this as you can see is that the tests failed.
for example:
            Label.enableRightToLeftDetection = true;
            var text = 'שלום';
            var label = labels.add({
                text : text
            });

            scene.renderForSpecs();

            expect(label.text).not.toEqual(text);
            expect(label.text).toEqual(text.split('').reverse().join(''));

This test failed although I enable the right-to-left algorithm. moreover, when I've checked the sandecastle it worked as expected.
So, how to use this parameter during tests?

So, how to use this parameter during tests?

It looks like your code should be activating it, so I'm not sure what's going on.

The code was OK, the problem was that during creation of a Label nothing calls to the text setter, so nothing run the algorithm.
The mandatory change that I've done at the last commit was to call the text setter in the constructor:
this.text = defaultValue(options.text, '');

my friend @YonatanKra that help me with this PR done it before. and me, by mistake, removed it in the last changes.

Awesome work here @hodbauer and @YonatanKra!  I submitted the tweak I mentioned, but otherwise I think this is ready so I'm going to merge.
If you find any issues or I accidentally broke something with my tweaks, please let me know.
Thanks again!


Swagger updates to introduce cosmos-db api version 2020-03-01, and add PublicNetworkAccess property

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

/azp run automation - sdk

the api ver is Mar 1 03-01, not Jan 3 01-03.


[QUESTION] Safe to add after gameplay?

Is this mod safe to add after already playing on a server for a bit? Like will it corrupt anything?

Yep, seems to be safe to add


Emby license change, now proprietary

It seems that the Emby server has changed license from GPL-2 to "proprietary core with open-source components":
https://github.com/MediaBrowser/Emby/issues/3479#issuecomment-444985456
As such, it seems that the sources for the 3.6 version and onward won't be distributed. I'm not sure what needs to be done here, but since I haven't seen a discussion about it yet, I'm opening a new issue.
Thanks!

Here is a discussion about Emby forks and alternatives:
https://github.com/nvllsvm/emby-unlocked/issues/28
And here is what looks to me as an active fork (but don't quote me on that):
https://github.com/jellyfin/jellyfin

Emby wasn't built from sources in nixpkgs anyway. So I think the first step would be to change the license to unfree with the 3.6 update.
If a fork gains traction I think it makes sense to package it.

Now that Jellyfin is packaged and has a module, I think it's safe to close this issue ^^


chore: bump web3.js to latest stable

@jh2oman wondering why you only did the patch bump in this relatively recent commit 2afe840466

@silasbw One of the @celo/ dependencies (I forget which one) depends on that exact version of web3 and doesn't play nice in Typescript with some of our code that also uses the web3 package unless they are the exact same versions. You can see some of the failures in the unit tests


Function disappears in the mapping expressions in VSCode

Description:
Consider the following video. Here the requirement is to uppercase the value in the output. When the output is selected to add a expression and then when the function is selected in the expression tab, the function disappears. Still  in the ts code the function call added.

Suggested Labels:

Suggested Assignees:

Affected Product Version:
OS, DB, other environment details and versions:
Steps to reproduce:
Related Issues:

The latest release v1.1.1 has resolved this issue. Please reopen if the problem persists.


FEATURE-<IP_ADDRESS> : https://kobman.github.io/

Mysterious '.io' page
This https://kobman.github.io/ page was generated from the README.md file (automatically)

Solution :
https://guides.github.com/features/pages/


Facilitate DCO in GitHub web UI

Given that DCO is mandatory, you might want to enable check the box "Require contributors to sign off on web-based commits"  on this repo, as described here: https://github.com/todogroup/gh-issues/issues/50#issuecomment-1148657762
That prevents an issue like I just ran into: #170

cc @cwayne18

Sorry for missing this :|


Apple Silicon compatibility?

I couldn't find any mention of whether this is compatible with M series CPUs. Either way, it's not showing up on my system after removing quarantine. It worked great on my previous Intel Mac.

It's been a long time since I've worked on it but i think it did work on my M1 mac back in the day. there's a comment here about it: https://github.com/diracdeltas/vstSpleeter/issues/8#issuecomment-1151553350


Usage of pre in Modelica.Electrical.Digital erroneous

Reported by clauss on 15 Mar 2016 13:34 UTC
P. Junglas reported errors when using basic components of Modelica.Electrical.Digital. Care for:
P. Junglas: Pitfalls using discrete event blocks in Simulink and Modelica. ASIM-Treffen STS/GMMS 2016, Treffen der ASIM/GI-Fachgruppen STS und GMMS, 10./11.März 2016, Lippstadt, pp. 90-97.
The publication is attached.
ASIM.pdf
The reason of wrong behavior seems to be the usage of pre.

Migrated-From: https://trac.modelica.org/Modelica/ticket/1959

Comment by hubertus on 15 Mar 2016 14:30 UTC
I have not had time to analyze this fully, but it looks like it may not be possible to build a correct RSFlipFlop with Modelica 3.2.x, and that synchronous features (or an update/correction of the spec) would be needed to do so. It would also mean that a block that has been in MSL for a long time, the RSFlipFlop is not really correct. Christoph, could you add a bit more detail to your assessment of this?

Comment by hansolsson on 16 Mar 2016 13:52 UTC
As far as I understand the reason for this is that the digital components contain pre - to break loops. If you use "long clock ticks" as the current examples in MSL it isn't a problem; and there are some benefits of this. But if you want to use instantaneous clock ticks and model a flip-flop it would require "one-sample-delay-blocks" etc - and using synchronous features becomes more convenient.
Note that there isn't really a flip-flop component in MSL; just an example model with it.

Point to @peterjunglas.

Christoph, could you add a bit more detail to your assessment of this?

@ECClauss


Web.Client: SignIn and SignUp

Follow swagger and create pages like out web site: https://www.silkroadprofessionals.com/

@Firuz2006 FYI


ImportError: cannot import name 'mpi_net' from 'nets'

Hi.
Do we need a version of nets from 2018 to get this working?  If you go to version history of nets https://pypi.org/project/nets/#history the furthest back you can go is May 22nd of 2020.  Can you explain how to get around the error "ImportError: cannot import name 'mpi_net' from 'nets'" ?  Thanks!

It's not supposed to import mpi_net from pypi.org, it's supposed to import it from https://github.com/google/stereo-magnification/blob/master/stereomag/nets.py which you can see defines mpi_net at line 23. Perhaps your python path is not set up to find the right source files?
…
On Tue, Mar 30, 2021 at 1:17 PM noobtoob4lyfe @.***> wrote: Hi. Do we need a version of nets from 2018 to get this working? If you go to version history of nets https://pypi.org/project/nets/#history the furthest back you can go is May 22nd of 2020. Can you explain how to get around the error "ImportError: cannot import name 'mpi_net' from 'nets'" ? Thanks! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#35>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE54MLLDYOIWHFQRGZTUIDLTGIBTTANCNFSM42CRAORA .

Thanks for your reply.  I'm using a google colab notebook, and running "!python ./mpi_from_images.py ".   Do I need to add something that tells it about a different python path?

I tried setting things up again from scratch.  should I not be doing "!pip install nets" ???  Is there a way to install the nets module contained in /stereomag/nets.py instead????

Python looks in the directories listed in sys.path to find where to import
libraries from. If you are trying to import nets directly into colab,
assuming you have the files available locally, you can either set sys.path (
https://docs.python.org/3/tutorial/modules.html#the-module-search-path), or
you may be able to just change "import nets" to (for example) "from
stereomag import nets".
r/
On Wed, Mar 31, 2021 at 12:57 PM noobtoob4lyfe @.***>
wrote:

I tried setting things up again from scratch. should I not be doing "!pip
install nets" ??? Is there a way to install the nets module contained in
/stereomag/nets.py instead????
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/google/stereo-magnification/issues/35#issuecomment-811251621,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE54MLLR2HIUQKKI65JUD53TGNIARANCNFSM42CRAORA
.


Revert "Change Docker image for flake8 step and enable flake8 check"

Reverts liquidinvestigations/core#54

closing in favor of https://github.com/liquidinvestigations/core/pull/57


Introduce hooks for fine-grained lakeFS automations in file system operations

Introduces hooks as functions with signature (client, context) -> None for executing lakeFS functions after file system operations.
Currently, only explicitly overridden file system operations are supported. In the future, we can extend this to other operations by either dummy-overriding them, or by wrapping them in a small block together with the hook (the dispatch is two lines long at most).
Implementation decisions tbm:

[ ] Should we always use HookContext.new(path) everywhere to save LoC at the expense of a new parse? It might not even have to be parsed anymore since that happens at the beginning of each file operation.
[ ] Should we explicitly override more abstract file system methods and include the hook dispatch?
[ ] Should we include a disable_hooks flag in the scope or something similar?
[ ] Could it make sense to set the hook map as a static attribute, i.e. one hook set for each file system class?

Closes #66.

Codecov Report
Patch coverage: 96.66% and project coverage change: +0.85% :tada:

Comparison is base (52fd5c1) 92.85% compared to head (fb2b4c1) 93.71%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
+ Coverage   92.85%   93.71%   +0.85%
==========================================
  Files           4        7       +3
  Lines         280      318      +38
  Branches       49       44       -5
==========================================
+ Hits          260      298      +38
  Misses         10       10
  Partials       10       10

Files Changed
Coverage Δ

src/lakefs_spec/spec.py
93.15% <91.11%> (-1.32%)
:arrow_down:

src/lakefs_spec/client_helpers.py
100.00% <100.00%> (ø)

src/lakefs_spec/config.py
100.00% <100.00%> (ø)

src/lakefs_spec/hooks.py
100.00% <100.00%> (ø)

src/lakefs_spec/util.py
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


support to reload CNI configs real-time if defaultNetName is not initialized

ref https://github.com/cri-o/ocicni/pull/31

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

/assign @zhuangqh

ping @rudyfly


merge from arlac77/npm-package-template-esm-only

package.json

chore(package): add ^16.0.0 remove ^15.14.0 (devDependencies.semantic-release)

:tada: This PR is included in version 8.1.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[Storage] az storage blob sync: add upload cap --cap-mbps option to limit bandwith

Related command
az storage blob sync ... --cap-mbps 1.0
Description
This adds the --cap-mbps option to   az storage blob sync, so it can limit bandwith during upload.
The azcopy command (where the azure cli is forwarding the call to) supports this, and @Jing-song added this in a similar way to the copy command in https://github.com/Azure/azure-cli/pull/18344

This checklist is used to make sure that common guidelines for a pull request are followed.

[X] The PR title and description has followed the guideline in Submitting Pull Requests.

[X] I adhere to the Command Guidelines.

[X] I adhere to the Error Handling Guidelines.
--> the underlying command (azcopy) will give an error if the cap-mbps value is not a number.

Storage

@MichaelWhi Thanks for contributing.
From CLI design perspective, we would like to add positional argument to pass through parameters to azcopy instead of copy azcopy specific argument to cli. Similar change from https://github.com/Azure/azure-cli/pull/20702 for your reference

From CLI design perspective, we would like to add positional argument to pass through parameters to azcopy instead of copy azcopy specific argument to cli. Similar change from #20702 for your reference

Thanks @evelyn-ys for your review and comment!
I agree that this is a much better change than adding single options. I changed the title, the description and force pushed the new changes to keep the history clean, and think this is ready to be reviewed again :)


"When using log, line ChartJS empty / null values doesn't break the line"

Expected Behavior
When encountering NaN / empty / null values the ChartJS line should be broken similar as when a non logarithmic type is selected.
Current Behavior
When using the logarithmic type in chart, the ChartJS line doesn't get broken as expected when encountering NaN / empty / null values, instead it is defaulted to 0
Possible Solution
Version 3 may provide a fix but at the moment a suggestion to resolve for version 2.9.4 is required,
Steps to Reproduce
https://codepen.io/wolwemaan/pen/ZEOmJdz
Context
Switching the y axis to type logarithmic causes the empty values to be charted as 0
Environment

Chart.js version: 2.9.4
Browser name and version: Chromium Version 86.0.4240.183 (Official Build) snap (64-bit)
Link to your project:

https://pasteboard.co/JzLUj2S.png
Attaching an image highlighting the unexpected 0's that is being charted

I got a non-ideal workaround by skipping NaN values altogether. Non-ideal since it results in the x-bar being updated accordingly

V3 will skip the NaNs by default, but that still causes X axis problems. The root cause of NaNs being skipped is the check for isNaN(otherValue) in https://github.com/chartjs/Chart.js/blob/master/src/core/core.datasetController.js#L609. The simplest solution would be to add an explicit max to the x axis.
https://codepen.io/etimberg/pen/QWGwgGQ?editors=1000

V3 will skip the NaNs by default, but that still causes X axis problems. The root cause of NaNs being skipped is the check for isNaN(otherValue) in https://github.com/chartjs/Chart.js/blob/master/src/core/core.datasetController.js#L609. The simplest solution would be to add an explicit max to the x axis.
https://codepen.io/etimberg/pen/QWGwgGQ?editors=1000


Log prediction responses

@TylerGillson had some uncommitted changes locally, so I've went ahead and introduced logging and now responses are also displayed on the server when DEBUG is set to true, would that work? sorry if I've stepped in your toes, but I had quite few conflicts when taking this in #44


numba compatibility with Ray

Hello. I'm trying to call a numba-decorated function from a ray.remote function. Without the @njit(fastmath=True) decoration the function works fine. With the decoration (I've also tried @jit and @njit without fastmath), I get a fatal error:
Assertion failed: (PassInf && "Expected all immutable passes to be initialized"), function addImmutablePass
The function is:
@njit(fastmath=True)
def mz_centroid(_int_f, _mz_f):
    return ((_int_f/_int_f.sum()) * _mz_f).sum()

It works fine as-is when it's called by a normal function (i.e. a function that is not a ray.remote). Am I doing something that should work?
Versions are ray 0.7.1, numba 0.44.1, and Python 3.6.7.
The full stack trace is:
Assertion failed: (PassInf && "Expected all immutable passes to be initialized"), function addImmutablePass, file /opt/concourse/worker/volumes/live/636f0d85-60d4-452d-50e9-ca6ab5111e2d/volume/llvmdev_1560805383854/work/lib/IR/LegacyPassManager.cpp, line 849.
(pid=1124) Fatal Python error: Aborted
(pid=1124)
(pid=1124) Stack (most recent call first):
(pid=1124)   File "/Users/fred/anaconda3/envs/py36/lib/python3.6/site-packages/llvmlite/binding/ffi.py", line 114 in __call__
(pid=1124)   File "/Users/fred/anaconda3/envs/py36/lib/python3.6/site-packages/llvmlite/binding/transforms.py", line 88 in _populate_module_pm
(pid=1124)   File "/Users/fred/anaconda3/envs/py36/lib/python3.6/site-packages/llvmlite/binding/transforms.py", line 95 in populate
(pid=1124)   File "/Users/fred/anaconda3/envs/py36/lib/python3.6/site-packages/numba/targets/codegen.py", line 660 in _module_pass_manager
(pid=1124)   File "/Users/fred/anaconda3/envs/py36/lib/python3.6/site-packages/numba/targets/codegen.py", line 627 in _init
(pid=1124)   File "/Users/fred/anaconda3/envs/py36/lib/python3.6/site-packages/numba/targets/codegen.py", line 608 in __init__
(pid=1124)   File "/Users/fred/anaconda3/envs/py36/lib/python3.6/site-packages/numba/targets/cpu.py", line 49 in init
(pid=1124)   File "/Users/fred/anaconda3/envs/py36/lib/python3.6/site-packages/numba/compiler_lock.py", line 32 in _acquire_compile_lock
(pid=1124)   File "/Users/fred/anaconda3/envs/py36/lib/python3.6/site-packages/numba/targets/base.py", line 250 in __init__
(pid=1124)   File "/Users/fred/anaconda3/envs/py36/lib/python3.6/site-packages/numba/targets/registry.py", line 34 in _toplevel_target_context
(pid=1124)   File "/Users/fred/anaconda3/envs/py36/lib/python3.6/site-packages/numba/utils.py", line 381 in __get__
(pid=1124)   File "/Users/fred/anaconda3/envs/py36/lib/python3.6/site-packages/numba/targets/registry.py", line 50 in target_context
(pid=1124)   File "/Users/fred/anaconda3/envs/py36/lib/python3.6/site-packages/numba/dispatcher.py", line 542 in __init__
(pid=1124)   File "/Users/fred/anaconda3/envs/py36/lib/python3.6/site-packages/numba/decorators.py", line 177 in wrapper
(pid=1124)   File "/Users/fred/anaconda3/envs/py36/lib/python3.6/site-packages/numba/decorators.py", line 161 in jit
(pid=1124)   File "/Users/fred/anaconda3/envs/py36/lib/python3.6/site-packages/numba/decorators.py", line 224 in njit
(pid=1124)   File "/Users/fred/anaconda3/envs/py36/lib/python3.6/site-packages/numba/typed/typeddict.py", line 18 in <module>
(pid=1124)   File "<frozen importlib._bootstrap>", line 219 in _call_with_frames_removed
(pid=1124)   File "<frozen importlib._bootstrap_external>", line 678 in exec_module
(pid=1124)   File "<frozen importlib._bootstrap>", line 665 in _load_unlocked
(pid=1124)   File "<frozen importlib._bootstrap>", line 955 in _find_and_load_unlocked
(pid=1124)   File "<frozen importlib._bootstrap>", line 971 in _find_and_load
(pid=1124)   File "/Users/fred/anaconda3/envs/py36/lib/python3.6/site-packages/numba/typed/__init__.py", line 3 in <module>
(pid=1124)   File "<frozen importlib._bootstrap>", line 219 in _call_with_frames_removed
(pid=1124)   File "<frozen importlib._bootstrap_external>", line 678 in exec_module
(pid=1124)   File "<frozen importlib._bootstrap>", line 665 in _load_unlocked
(pid=1124)   File "<frozen importlib._bootstrap>", line 955 in _find_and_load_unlocked
(pid=1124)   File "<frozen importlib._bootstrap>", line 971 in _find_and_load
(pid=1124)   File "/Users/fred/anaconda3/envs/py36/lib/python3.6/site-packages/numba/__init__.py", line 41 in <module>
(pid=1124)   File "<frozen importlib._bootstrap>", line 219 in _c

I don't think we've every tried using Numba with Ray, although Numba functions should work properly with pickle serialization and we do know they work with Dask distributed.
So there's no known reason it shouldn't work, although this looks like something strange is happening with the initialization of LLVM.  We'll have to do some experiments here and see if we can reproduce this.

also, just for completeness, can you run the numba -s command, which will let us know what platform, CPU features, and optional libraries (like SVML) are present?

I can reproduce with:
import numpy as np
from numba import njit
import ray

@njit(fastmath=True)
def mz_centroid(_int_f, _mz_f):
    return ((_int_f/_int_f.sum()) * _mz_f).sum()

@ray.remote
def f():
    a = np.random.random(10)
    b = 123
    return mz_centroid(a, b)

ray.init()
results = ray.get([f.remote() for i in range(4)])
print(results)

Here's a minimal reproducer:
import ray   # the importing of ray is causing llvm to abort

from llvmlite import binding as ll
import llvmlite.llvmpy.passes as lp

ll.initialize()
ll.initialize_all_targets()
ll.initialize_all_asmprinters()

pm = ll.create_module_pass_manager()
pmb = lp.create_pass_manager_builder(opt=0)
pmb.populate(pm)

Can't seem to reproduce on linux.

Related issues:

https://github.com/JuliaPy/PyCall.jl/issues/476

Potential workaround:

https://github.com/JuliaPy/PyCall.jl/issues/679#issuecomment-482419678

I am starting to doubt this is a llvmlite problem.  It could be on how ray/pyarrow is loading their LLVM.

numba -s output
--------------------------------------------------------------------------------
__Time Stamp__
2019-07-02 21:03:43.936836

__Hardware Information__
Machine                                       : x86_64
CPU Name                                      : haswell
CPU count                                     : 4
CPU Features                                  :
64bit aes avx avx2 bmi bmi2 cmov cx16 f16c fma fsgsbase invpcid lzcnt mmx movbe
pclmul popcnt rdrnd sahf sse sse2 sse3 sse4.1 sse4.2 ssse3 xsave xsaveopt

__OS Information__
Platform                                      : Darwin-18.6.0-x86_64-i386-64bit
Release                                       : 18.6.0
System Name                                   : Darwin
Version                                       : Darwin Kernel Version 18.6.0: Thu Apr 25 23:16:27 PDT 2019; root:xnu-4903.261.4~2/RELEASE_X86_64
OS specific info                              : 10.14.5   x86_64

__Python Information__
Python Compiler                               : GCC 4.2.1 Compatible Clang 4.0.1 (tags/RELEASE_401/final)
Python Implementation                         : CPython
Python Version                                : 3.6.7
Python Locale                                 : en_AU UTF-8

__LLVM information__
LLVM version                                  : 8.0.0

__CUDA Information__
CUDA driver library cannot be found or no CUDA enabled devices are present.
Error class: <class 'numba.cuda.cudadrv.error.CudaSupportError'>

__ROC Information__
ROC available                                 : False
Error initialising ROC due to                 : No ROC toolchains found.
No HSA Agents found, encountered exception when searching:
Error at driver init:

HSA is not currently supported on this platform (darwin).
:

__SVML Information__
SVML state, config.USING_SVML                 : False
SVML library found and loaded                 : False
llvmlite using SVML patched LLVM              : True
SVML operational                              : False

__Threading Layer Information__
TBB Threading layer available                 : True
OpenMP Threading layer available              : True
Workqueue Threading layer available           : True

__Numba Environment Variable Information__
None set.

__Conda Information__
WARNING: The conda.compat module is deprecated and will be removed in a future release.
conda_build_version                           : 3.15.1
conda_env_version                             : 4.6.11
platform                                      : osx-64
python_version                                : 2.7.16.final.0
root_writable                                 : True
WARNING: The conda.compat module is deprecated and will be removed in a future release.

Tried the same code on Ubuntu 18.04 and it works fine.

Hmm, I wonder if this has to do with differences in the way Linux and macOS handle linking and symbol resolution.

I can reproduce this on Mac OS 10.14.5, with python 3.7.2, with ray-0.7.2 and numba-0.45.0:
import ray
import numba

fails with
Assertion failed: (PassInf && "Expected all immutable passes to be initialized"), function addImmutablePass, file /Users/buildbot/miniconda3/conda-bld/llvmdev_1556270736866/work/lib/IR/LegacyPassManager.cpp, line 849.

Importing numba first, then ray does not fail in the same way. And importing numba before importing ray also makes @sklam 's minimal reproduction case pass.
I'll look into opening a bug with https://github.com/ray-project/ray

As mentioned in https://github.com/ray-project/ray/issues/5250#issuecomment-514066458, I can reproduce the issue on MacOS 10.14.3 with Python 3.6.7, by doing
import pyarrow
import numba

Since ray uses pyarrow (ray actually vendors its own version of pyarrow, but I can reproduce the issue with the pyarrow release on PyPI), I suspect the issue has to do with how Arrow bundles llvm.

FYI @wesm @pravindra.

Please take up with the Arrow dev mailing list

For the benefit of people looking into the numba & pyarrow compatibility issue and are not subscribed to the Arrow dev mailing list, I got in touch with Wes via said mailing list, copying his reply verbatim below.

hi Ivan,
We have statically linked LLVM symbols in our wheels on all platforms.
We're looking for new maintainers for the wheels to take care of
issues like this, see 1. In the meantime, I suggest you use conda
packages if you need to use numba and pyarrow together.
Thanks

Few workarounds I have:

install pyarrow==0.12.1, which works with the latest numba==0.45.0 at the time of writing.
as suggested above, use conda packages if you need to use numba and pyarrow together

Thanks @igozali. That should address arrow + numba, but won't quite solve the issue of ray + numba because ray actually ships with its own pyarrow wheels (as opposed to depending on the ones in PyPI). The reason for that has to do with needing to build pyarrow wheels that are compatible with TensorFlow and PyTorch (there is a longer discussion detailed in https://groups.google.com/forum/#!topic/ray-dev/gbYKK9Gy_ns/discussion).

One more workaround: I don't use ray, but with the plain pyarrow (version 15.0) it looks like the order of imports matter.
I.e. this will crash
import pyarrow
import numba

And this will work
import numba
import pyarrow

I'm not aware of side effects though.

This should be fixed in 0.15.1 (out soon)

Thanks @wesm, presume https://github.com/numba/numba/issues/4751 is fixed by the same?

Yes

This is fixed in the latest master (not the latest release yet). You can try installing the latest wheels by following the instructions at https://ray.readthedocs.io/en/latest/installation.html#latest-snapshots-nightlies.

@robertnishihara thanks for confirming the fix, please could you ping when the release with the fix in is shipped so that this ticket can be closed. Many thanks in advance!

@vfilimonov, this is fixed now in ray==0.8.2. The example posted by @sklam works now.

Thanks for all the fixes folks, seems like the last item was fixed in ray=0.8.2.
Closing this issue as it seems to be resolved. If this is not the case please re-open with a comment about any item that appears to be unresolved. Many thanks.


Ensure proper encoding in menus

I am trying to reproduce the issue in Windows 10 and not seeing it. Is this specific to OS X any directions will help me fix the issue.

Yeah, we may have fixed this somewhere along the way 🤔


Introduce an API for regexp pattern validation in NodeParser

Purpose

$title

Fixes #40318
Approach
Samples
Remarks
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Shall we add NodeParser related testcases to validate this ?
IMO, we can use approach similar to following tests
compiler/ballerina-parser/src/test/java/io/ballerinalang/compiler/parser/test/tree/nodeparser/ParseActionOrExpressionTest.java

Shall we add NodeParser related testcases to validate this ?
IMO, we can use approach similar to following tests
compiler/ballerina-parser/src/test/java/io/ballerinalang/compiler/parser/test/tree/nodeparser/ParseActionOrExpressionTest.java

Added in https://github.com/ballerina-platform/ballerina-lang/pull/40339/commits/b0536ab7e9d3ac45afa06f0d9725f331124cce88.

This fix is now invalid since we have a workaround. @sanjana please add the vertict and close the PR

As per the conclusions of the discussions, it is decided to use parseExpression() to parse a regexp expression, and use node.hasDiagnostics() to check for diagnostics.
Therefore, the need for this API specifically for parsing regexp expressions is unnecessary.
Hence closing this PR.


Fix CI

@rosa gentle ping ❤

Oops, so sorry, @lfv89, I completely missed this one!

No worries, thanks!!!


Could not change theme font

In SearchTextFieldTheme we can't set custom font
For example when I use UIFont(name: "BNazanin", size: 10)! in init of SearchTextFieldTheme the tableview does not appear for suggestion

I tested it and it's working. Are you sure you are following the right steps for using custom fonts in your app?. Here you have a good tutorial about it: http://codewithchris.com/common-mistakes-with-adding-custom-fonts-to-your-ios-app/#addfontstoplist

Thanks
Successfully added and works !
But I found something else
Suggestion tableview does not appear in iPhone 5 in simulator
(I didn't check in real device)

Good to know you could fix it!.
Regarding simulator please double check that the keyboard is being shown (if not force to show it).

so sry
It works
I don't know why that wasn't working
I have a question
How could I move suggestion strings to right I mean in right to left languages we should start from right

In fact right now it's not supporting RTL languages and it's a good suggestion. Thanks for that I'll implement it soon.

Is there anyway that I can do on my own to implement RTL ?

Please take a look at the new version 1.1.4, it already supports RTL (forceRightToLeft property).


Unable to install when registry baseUrl is using https

I confirmed that I can create a registry and install components from it when using SSH. However, when I set the repository url using https, I can't install components. I walked through and entered the advanced configuration and set credentials with no luck. I even made my repo public to see it that would work and it did not.

Hi @chrisjasp, thanks for reporting the issue! I'm currently analyzing it.

I've tested now the latest jspm-git v0.4.3 against a private Gitlab repo and it worked for me. Which error are you getting and which version of jspm-git are you using? Not sure which server hosts your repos but is HTTP Basic Authentication supported there?

I am also at version 0.4.3. My server is using HTTPS and I will check on
the authentication when I am back in the office. My provider is fogcreek
kiln.
On Sat, Feb 20, 2016, 05:05 subesokun<EMAIL_ADDRESS>wrote:

I've tested now the latest jspm-git v0.4.3 against a private Gitlab repo
and it worked for me. Which error are you getting and which version of
jspm-git are you using? Not sure which server hosts your repos but is HTTP
Basic Authentication supported there?
—
Reply to this email directly or view it on GitHub
https://github.com/Orbs/jspm-git/issues/28#issuecomment-186590963.

--
Best Regards,
Chris Jasper

Btw I've released now v0.4.4 which improves the configuration of the auth. credentials. But it should have no effect on the issue you're observing. To ensure that your credentials are correct please re-run
jspm registry config yourregname

I did update to the latest (0.4.4) this morning. I re-ran the registry config and I am still running into the same issue. I will look into my repository hosting service to get more details there.

To be sure that jspm-git is not the reason why you can't install packages from your repository you can try the following command
git ls-remote<EMAIL_ADDRESS>refs/tags/* refs/heads/*

If that works for you then it really sounds like a bug in jspm-git.

I think there is an issue with the fact the the usernames are an email address. Confirming that now.

Sorry for the delay. All credentials are getting url encoded so this shouldn't be an issue. Anyhow I'll try to make a test with a username that contains special characters like an @.

Great. I'm curious to hear the results.


How to recover portus deleted image tags

We have installed Portus using "head" version last month ( not sure the exact version number because upgraded with latest stable version Version: 2.3.5@35b9c801bf5275537a8bd8152d2f5769d6c24b09), the images got deleted automatically from portus. I see that the blobs layers are still available in the blobs folder.
I do not see the issues after upgraded with stable but How do we recover the deleted images tag and bring back it available?
last bug report
https://github.com/SUSE/Portus/issues/1160

I do not see the issues after upgraded with stable but How do we recover the deleted images tag and bring back it available?

 In this case, then the only thing you are missing is the manifest that Portus deleted. You could just push the images up again, and it should already re-use the blobs you had uploaded before the delete. This is the way to go imho.

got deleted automatically from portus

I'd need logs and the configuration to give you a better response :sweat_smile:

Same issue affects me.

I found, that each image was deleted after 30 day it was added, It looks like, the garbage collector did it, but it is not enabled in my config (I use default config):
delete:
  enabled: true
  contributors: false
  garbage_collector:
    enabled: false
    older_than: 30
    tag: ''

Portus version: 2.5.0-dev@c98a51eb0cc2ee772c19ee64269d2a86ec0fe0dc
portus-background container log:
[catalog] Removed the tag 'latest'.
[catalog] Removed the image 'cuda10'.
Handling 'delete' event:
{
  "id": "be4128a1-299f-4479-a46a-dd2d86f3fbcf",
  "timestamp": "2019-01-10T12:17:28.108994516Z",
  "action": "delete",
  "target": {
    "digest": "sha256:302496805dadfe2804ff60d8fa835e488f447c6422d0f897d0a4b12e8a366b9d",
    "repository": "dwx315410/cuda10"
  },
  "request": {
    "id": "9c7d04e3-0c02-4aaa-b32d-ba9dbdb5c5dd",
    "addr": "<IP_ADDRESS>",
    "host": "docker.matis.huawei.com",
    "method": "DELETE",
    "useragent": "Ruby"
  },
  "actor": {
    "name": "portus"
  },
  "source": {
    "addr": "f196d255bd82:5000",
    "instanceID": "cc9e6a8f-62a7-45a1-9711-9d3cd222fe14"
  }
}

registry container log:
time="2019-01-10T12:17:26Z" level=debug msg="authorizing request" go.version=go1.7.6 http.request.host=docker.matis.huawei.com http.request.id=a6f1618a-5ce4-4580-8bdb-92949e7e4f57 http.request.method=DELETE http.request.remoteaddr=<IP_ADDRESS> http.request.uri="/v2/dwx315410/cuda10/manifests/sha256:302496805dadfe2804ff60d8fa835e488f447c6422d0f897d0a4b12e8a366b9d" http.request.useragent=Ruby instance.id=cc9e6a8f-62a7-45a1-9711-9d3cd222fe14 vars.name="dwx315410/cuda10" vars.reference="sha256:302496805dadfe2804ff60d8fa835e488f447c6422d0f897d0a4b12e8a366b9d" version=v2.6.2
time="2019-01-10T12:17:26Z" level=warning msg="error authorizing context: authorization token required" go.version=go1.7.6 http.request.host=docker.matis.huawei.com http.request.id=a6f1618a-5ce4-4580-8bdb-92949e7e4f57 http.request.method=DELETE http.request.remoteaddr=<IP_ADDRESS> http.request.uri="/v2/dwx315410/cuda10/manifests/sha256:302496805dadfe2804ff60d8fa835e488f447c6422d0f897d0a4b12e8a366b9d" http.request.useragent=Ruby instance.id=cc9e6a8f-62a7-45a1-9711-9d3cd222fe14 vars.name="dwx315410/cuda10" vars.reference="sha256:302496805dadfe2804ff60d8fa835e488f447c6422d0f897d0a4b12e8a366b9d" version=v2.6.2
<IP_ADDRESS> - - [10/Jan/2019:12:17:26 +0000] "DELETE /v2/dwx315410/cuda10/manifests/sha256:302496805dadfe2804ff60d8fa835e488f447c6422d0f897d0a4b12e8a366b9d HTTP/1.0" 401 156 "" "Ruby"
...
time="2019-01-10T12:17:28Z" level=info msg="response completed" go.version=go1.7.6 http.request.host=docker.matis.huawei.com http.request.id=9c7d04e3-0c02-4aaa-b32d-ba9dbdb5c5dd http.request.method=DELETE http.request.remoteaddr=<IP_ADDRESS> http.request.uri="/v2/dwx315410/cuda10/manifests/sha256:302496805dadfe2804ff60d8fa835e488f447c6422d0f897d0a4b12e8a366b9d" http.request.useragent=Ruby http.response.duration=13.694751ms http.response.status=202 http.response.written=0 instance.id=cc9e6a8f-62a7-45a1-9711-9d3cd222fe14 version=v2.6.2
<IP_ADDRESS> - - [10/Jan/2019:12:17:28 +0000] "DELETE /v2/dwx315410/cuda10/manifests/sha256:302496805dadfe2804ff60d8fa835e488f447c6422d0f897d0a4b12e8a366b9d HTTP/1.0" 202 0 "" "Ruby"

@maleficxp this bug was fixed at https://github.com/SUSE/Portus/pull/2018. Your image is probably older than that. Also, we've imlemented the suggestions of https://github.com/SUSE/Portus/issues/2051. If you upgrade your instance you can take advantage of that too.

To be honest I think we can close this issue. What do you think, @mssola?

Agreed. Thanks @vitoravelino for the heads up :+1:


Roll out strategy for new Unleash versions

Using PubSub for notifications on new versions and then a rollout strategy?


Prevent invalid input feature

Closes #27

This change is

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Review status: 0 of 3 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion.

vaadin-text-field.html, line 242 at r1 (raw file):

        if (this.preventInvalidInput) {
          const input = this.$.input;
          if (input.value.length > 0 && !input.checkValidity()) {

We probably want to call this.validate() to support the custom validation

Comments from Reviewable

Review status: 0 of 3 files reviewed at latest revision, 2 unresolved discussions.

vaadin-text-field.html, line 89 at r1 (raw file):

      title="[[title]]"
      on-blur="validate"
      on-input="_onInput"

Have you notice that validate is called each time the user types something because of the value-changed, it seems that happens once the value has been set, so after blur the first time

Comments from Reviewable

Review status: 0 of 3 files reviewed at latest revision, 2 unresolved discussions.

vaadin-text-field.html, line 89 at r1 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
Have you notice that validate is called each time the user types something because of the value-changed, it seems that happens once the value has been set, so after blur the first time

Sure, but we want to prevent invalid input on user action only.

vaadin-text-field.html, line 242 at r1 (raw file):
Previously, Saulis (Sauli Tähkäpää) wrote…
We probably want to call this.validate() to support the custom validation

It's not specified to support custom validators. <iron-input prevent-invalid-input> doesn't.
Also, validate() changes this.invalid value (which notifies) as a side effect.

Comments from Reviewable

Review status: 0 of 3 files reviewed at latest revision, 2 unresolved discussions.

vaadin-text-field.html, line 89 at r1 (raw file):
Previously, tomivirkki (Tomi Virkki) wrote…
Sure, but we want to prevent invalid input on user action only.

But check validity is called twice, so the call in value changed could be debounced some way

vaadin-text-field.html, line 242 at r1 (raw file):
Previously, tomivirkki (Tomi Virkki) wrote…
It's not specified to support custom validators. <iron-input prevent-invalid-input> doesn't.
Also, validate() changes this.invalid value (which notifies) as a side effect.

In my PR I decided not to change this.invalid in validate but in the point where it is called if it is the case of changing the property

Comments from Reviewable

Review status: 0 of 3 files reviewed at latest revision, 2 unresolved discussions.

vaadin-text-field.html, line 89 at r1 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
But check validity is called twice, so the call in value changed could be debounced some way

No need for premature optimization if that's what you're after. Also, as mentioned below, I'm not using validate() directly but native input.checkValidity() which ignores custom validators

vaadin-text-field.html, line 242 at r1 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
In my PR I decided not to change this.invalid in validate but in the point where it is called if it is the case of changing the property

Sure, but that wasn't the main point of not using it but: "It's not specified to support custom validators.  doesn't."

Comments from Reviewable

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

vaadin-text-field.html, line 242 at r1 (raw file):
Previously, tomivirkki (Tomi Virkki) wrote…
Sure, but that wasn't the main point of not using it but: "It's not specified to support custom validators.  doesn't."

The ticket description says: "should of course work with custom validators also"

Comments from Reviewable

vaadin-text-field.html, line 242 at r1 (raw file):
Previously, Saulis (Sauli Tähkäpää) wrote…
The ticket description says: "should of course work with custom validators also"

Oh damn, missed that :D But still, should it?
To be precise, a concept of “custom validators” was dropped in favour of providing an example on how to implement that with the current API. And since the “custom validator” can be asynchronous as in the example at https://jsfiddle.net/Saulis/eqf2ph1c/, there’s no way we can hook it to this feature.
The spec says that "iron-input has a corresponding property called prevent-invalid-input" and as I mentioned, <iron-input prevent-invalid-input> bypasses custom validator also.

Comments from Reviewable

vaadin-text-field.html, line 242 at r1 (raw file):
Previously, tomivirkki (Tomi Virkki) wrote…
Oh damn, missed that :D But still, should it?
To be precise, a concept of “custom validators” was dropped in favour of providing an example on how to implement that with the current API. And since the “custom validator” can be asynchronous as in the example at https://jsfiddle.net/Saulis/eqf2ph1c/, there’s no way we can hook it to this feature.
The spec says that "iron-input has a corresponding property called prevent-invalid-input" and as I mentioned, <iron-input prevent-invalid-input> bypasses custom validator also.

As described here https://github.com/PolymerElements/iron-validatable-behavior/blob/master/iron-validatable-behavior.html#L24 validate() should have side effects (invalid & aria-invalid attribute).
Extracted the checkValidity() call to a shared _getValidity() function used by both the validate() and "prevent invalid input" feature.

Comments from Reviewable

Review status: 1 of 3 files reviewed at latest revision, 2 unresolved discussions, some commit checks broke.

vaadin-text-field.html, line 262 at r2 (raw file):

       */
      validate() {
        return !(this.invalid = !this._getValidity());

I don't think the validate() method should change the invalid flat. In my PR, invalid is set when it is convenient, so we don't need the _getValidity and the public method could be called anytime without changing the visual appearance.

Comments from Reviewable

vaadin-text-field.html, line 262 at r2 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
I don't think the validate() method should change the invalid flat. In my PR, invalid is set when it is convenient, so we don't need the _getValidity and the public method could be called anytime without changing the visual appearance.

It should according to https://github.com/PolymerElements/iron-validatable-behavior/blob/master/iron-validatable-behavior.html#L24

Comments from Reviewable

Review status: 1 of 3 files reviewed at latest revision, 2 unresolved discussions.

vaadin-text-field.html, line 262 at r2 (raw file):
Previously, tomivirkki (Tomi Virkki) wrote…
It should according to https://github.com/PolymerElements/iron-validatable-behavior/blob/master/iron-validatable-behavior.html#L24

But in their implementation (at least with iron-input) they don't assume that someone can override the validate method like we do.
Actually when they implement validate, they use an event for the user to custom validate and we  do not.
So if we encourage people to use extension, we need to notice them to handle the invalid flag by hand, each time validate is called. But it could be interesting to change the flag like in a proper form validation, or not like in your checkValidity case.

Comments from Reviewable

vaadin-text-field.html, line 262 at r2 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
But in their implementation (at least with iron-input) they don't assume that someone can override the validate method like we do.
Actually when they implement validate, they use an event for the user to custom validate and we  do not.
So if we encourage people to use extension, we need to notice them to handle the invalid flag by hand, each time validate is called. But it could be interesting to change the flag like in a proper form validation, or not like in your checkValidity case.

We don’t assume people override validate() either. It’s for <iron-form>’purposes. If you want to implement custom validation, you should consider overriding checkValidity instead (or whatever, not in scope of this PR to decide). The documentation I linked also states you shouldn’t override validate()

Comments from Reviewable

Reviewed 1 of 3 files at r1, 1 of 2 files at r2, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

vaadin-text-field.html, line 262 at r2 (raw file):
Previously, tomivirkki (Tomi Virkki) wrote…
We don’t assume people override validate() either. It’s for <iron-form>’purposes. If you want to implement custom validation, you should consider overriding checkValidity instead (or whatever, not in scope of this PR to decide). The documentation I linked also states you shouldn’t override validate()

Yes, we'll instruct our users to override checkValidity() in most cases. Some cases like async validation require overriding validate()

Comments from Reviewable


openfpgaloader: init at 0.2.1

Signed-off-by: David Anderson<EMAIL_ADDRESS>Motivation for this change
The yosys/nmigen ecosystem uses OpenFPGALoader to load gateware onto FPGAs. It seems to support a lot more targets than other (often single-vendor) programming tools, and complements other bits of the ecosystem nicely.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

/marvin opt-in
/status needs_reviewer

Ready for review, PTAL. Thanks!

@danderson it still does not eval and I think you reverted the libusb1 changes.

That's what I get for mixing git's suggestions flow and repushing from my local client... Fixed and pushed, let's see if I got it right this time...


Registration

@JuliaRegistrator register()

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/74230
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" 0d9434baf75a63ea7eb14387413f879fd1c0ab0d
git push origin v0.1.0


Extend openamp rsc table for imx8mm

Some time ago, I created a PR that also replaces some thematic changes from this PR. Only for information.
#44826


SoapFault: INVALID_TYPE: Must send a concrete entity type.

Hi guys,
with PHP7, I tried to create a Lead but return back this error: SoapFault: INVALID_TYPE: Must send a concrete entity type.
Any ideas?
Let me know.
Thanks in advance.

I have the same issue trying to create Contact records with PHP7. Found that this issue is talking about the same thing: https://github.com/developerforce/Force.com-Toolkit-for-PHP/issues/47 - and a solution is found here: https://github.com/developerforce/Force.com-Toolkit-for-PHP/pull/48/files


Refactor/reorg test driver to resurect browser testing.

Relies on demo/expressServer.js to expand the test list into a
list of files using the same functions called by the node test driver.
This dependency cost is balanced by no longer having to manually
ensure the tests are added to testRunner.html
Status: Tests run but the mocha progress bar over-writes itself
until the feature tests also converted to ES6 (in progress).
Add MochaDepencencies.js for platform probing.
Refactor TraceurTestRunner to glob asynchronously.
Refactor TraceurTestRunner -> BrowserTestRunner, NodeTestRunner.
Add "node-only:" prefix to suite() titles to exclude node-specific tests.
(Formerly just not included in testRunner.html).
Tweek ModuleStore error message to add URL.
Reorg unit test classes to run() in the endpoint so error messages are
easier to place.

Very nice. Looking forward to run the test with a real debugger again.

PTAL

PTAL

LGTM


deps: require numpy version 1.X.Y

The recent release of numpy 2.0 seem to break some of our dependencies.
If you were to re-run the CI on master before this commit, it would fail due to incompatible depenndencies.
This introduces a work around to ensure that we remain on a 1.X.Y version of numpy. I expect this to be removable once the ecosystem fixes their required dependencies.

Thanks for this Arthur. Did you discover whcih pair of deps caused this (so that we can monitor them)?

No, but @nicola-gigante is I think the one who delved the most into this issue and may have more insights.
Note that we faced the same problem also for doc generation, where the dependencies are quite different.

@mikand if you have access to the old CI logs, you should see the name of the offending module in the Python stack trace, I think.


Proposals for Reducing Infrastructure Costs

During the biweekly meeting with @batpad @erictheise @1ec5 , after reviewing the current status of our infrastructure https://github.com/OpenHistoricalMap/issues/issues/861#issuecomment-2430070614 , we discussed several ideas to reduce monthly infrastructure costs. One of the proposals is to explore services like Hetzner Matrix RX-  https://www.hetzner.com/dedicated-rootserver/matrix-rx, which could be a viable option for migrating our infrastructure. This is a topic we need to discuss further with the entire team
cc. @jeffreyameyer @danrademacher

The incremental savings over in #861 seem really great -- right-sizing resources based on data about actual usage.
Moving off of AWS onto Hetzner makes me a bit nervous. Some considerations:

We have a lot invested in the specific alphabet soup of AWS (such as Planet data on S3, DNS on Route 53, etc)
AWS is widely used and at least somewhat widely understood, so it seems a bit more resilient to changes in the dev team over time

However, I do agree that high monthly infrastructure costs make the project difficult to sustain if/when funding is in question.
I wonder if related to this we should revisit #699 and see if there are opportunities for AWS credits or other data-for-good supports that could diversify our sources of ongoing infrastructure funding.


Added a math parsing feature

The parser expects a block surrounded in $$ ... $$ or an inline component surrounded in $ ... $. You supply the renderer, via a math option, which is an object with a render method that returns a string, representing the outputed math.
This is different from #180, in that the renderer is not limited to just MathJax, but KaTeX will work as well.

Closing as missing tests and not current focus per #956


Create Vagrant Image for MacOS 10.14 to build Python Client

Is your enhancement request related to a problem? Please describe.
When releasing 2.8.3, I discovered that we do not have a vagrant image for MacOS 10.14. Without that image, we cannot create a python client for that target OS.
Describe the solution you'd like
Create an image, or figure out an alternative way to build the python client for MacOS 10.14.
Additional context
Related issues: https://github.com/apache/pulsar/issues/4540, https://github.com/apache/pulsar/issues/13334, #13429, #12293, #8794

@merlimat @codelipenghui @eolivelli - The MacOS 10.14 image is not available. I could not build the 2.8.3 Python Client for MacOS 10.14. It looks like there are several issues where users are asking for such a version. I created this issue to raise visibility about this missing image. Both of these URLs currently result in a 404.
https://app.vagrantup.com/apachepulsar/boxes/osx-10.14-python-dev/versions/0.1/providers/download/virtualbox.box
https://app.vagrantup.com/apachepulsar/boxes/osx-10.14-python-dev/versions/0.2/providers/download/virtualbox.box

Also it is not clear to me how do we maintain those images.
Is there any documentation?
In theory they are under the control of the Pulsar PMC

That would make sense. During the community meeting yesterday, @merlimat mentioned that the vagrant images are hard to build, and that we're missing several versions of MacOS. It seems that we probably need to take a closer look at this part of our build/release process.

@michaeljmarshall @codelipenghui @BewareMyPower Is it necessary for us to build pulsar c++ in the specific macOS version? If so, how about using the cmake parameter MACOSX_DEPLOYMENT_TARGET?

Is it necessary for us to build pulsar c++ in the specific macOS version?

I think it depends on the compiler.

If so, how about using the cmake parameter MACOSX_DEPLOYMENT_TARGET

I'm not sure which compiler the older macOS uses. But it looks like this flag doesn't work for Clang. See https://stackoverflow.com/questions/25352389/what-is-the-difference-between-macosx-deployment-target-and-mmacosx-version-min

@BewareMyPower @michaeljmarshall @merlimat is it still relevant? I can build the Python client on my macOS 12.6 now.

No. The script in pulsar-client-python repo works well now.

Closed as fixed.


Cursor is weird

Describe the bug
The cursor moves a weird way, like laggy and got a space between the character and the cursor itself
Expected behavior
Should work like other commands / like my shell
Screenshots

Desktop (please complete the following information):

OS: macOS 10.14.6
Version: 0.1.29

HI @kud, thanks for creating this issue. I'm able to reproduce the bug on multiple terminals and it's very annoying.

Fixed in version 0.1.33.


EHR Launch: pass the aud parameter to the authorize endpoint (matches the iss parameter)

This should now be available in SMARTAppLaunch.jl v1.2.0: https://github.com/JuliaHealth/SMARTAppLaunch.jl/releases/tag/v1.2.0