Failures introduced by GPUFeatureStatus Object

The linter is choking on this: https://github.com/electron/electron/blob/02972fac86ffd2d87c5513840b0f303886257e07/docs/api/structures/gpu-feature-status.md
Here's what it produces:
  interface GPUFeatureStatus {

    // Docs: http://electron.atom.io/docs/api/structures/gpu-feature-status

    /**
     * Canvas
     */
    2d_canvas: string;
    /**
     * Flash
     */
    flash_3d: string;
    /**
     * Flash Stage3D
     */
    flash_stage3d: string;
    /**
     * Flash Stage3D Baseline profile
     */
    flash_stage3d_baseline: string;
    /**
     * Compositing
     */
    gpu_compositing: string;
    /**
     * Multiple Raster Threads
     */
    multiple_raster_threads: string;
    /**
     * Native GpuMemoryBuffers
     */
    native_gpu_memory_buffers: string;
    /**
     * Rasterization
     */
    rasterization: string;
    /**
     * Video Decode
     */
    video_decode: string;
    /**
     * Video Encode
     */
    video_encode: string;
    /**
     * VPx Video Decode
     */
    vpx_decode: string;
    /**
     * WebGL
     */
    webgl: string;
    /**
     * WebGL2
     */
    webgl2: string;
  }

And here's the error output:
RuleFailure {
  failure: 'unexpected label on statement',
  ruleName: 'label-position',
  fix: undefined,
  fileName: 'test-smoke/electron/index.d.ts',
  startPosition:
   RuleFailurePosition {
     position: 111959,
     lineAndCharacter: { line: 2409, character: 5 } },
  endPosition:
   RuleFailurePosition {
     position: 111967,
     lineAndCharacter: { line: 2409, character: 13 } } }

RuleFailure {
  failure: 'unexpected label on statement',
  ruleName: 'label-position',
  fix: undefined,
  fileName: 'test-smoke/electron/index.d.ts',
  startPosition:
   RuleFailurePosition {
     position: 112010,
     lineAndCharacter: { line: 2413, character: 4 } },
  endPosition:
   RuleFailurePosition {
     position: 112018,
     lineAndCharacter: { line: 2413, character: 12 } } }

RuleFailure {
  failure: 'unexpected label on statement',
  ruleName: 'label-position',
  fix: undefined,
  fileName: 'test-smoke/electron/index.d.ts',
  startPosition:
   RuleFailurePosition {
     position: 112069,
     lineAndCharacter: { line: 2417, character: 4 } },
  endPosition:
   RuleFailurePosition {
     position: 112082,
     lineAndCharacter: { line: 2417, character: 17 } } }

RuleFailure {
  failure: 'unexpected label on statement',
  ruleName: 'label-position',
  fix: undefined,
  fileName: 'test-smoke/electron/index.d.ts',
  startPosition:
   RuleFailurePosition {
     position: 112150,
     lineAndCharacter: { line: 2421, character: 4 } },
  endPosition:
   RuleFailurePosition {
     position: 112172,
     lineAndCharacter: { line: 2421, character: 26 } } }

RuleFailure {
  failure: 'unexpected label on statement',
  ruleName: 'label-position',
  fix: undefined,
  fileName: 'test-smoke/electron/index.d.ts',
  startPosition:
   RuleFailurePosition {
     position: 112221,
     lineAndCharacter: { line: 2425, character: 4 } },
  endPosition:
   RuleFailurePosition {
     position: 112236,
     lineAndCharacter: { line: 2425, character: 19 } } }

RuleFailure {
  failure: 'unexpected label on statement',
  ruleName: 'label-position',
  fix: undefined,
  fileName: 'test-smoke/electron/index.d.ts',
  startPosition:
   RuleFailurePosition {
     position: 112297,
     lineAndCharacter: { line: 2429, character: 4 } },
  endPosition:
   RuleFailurePosition {
     position: 112320,
     lineAndCharacter: { line: 2429, character: 27 } } }

RuleFailure {
  failure: 'unexpected label on statement',
  ruleName: 'label-position',
  fix: undefined,
  fileName: 'test-smoke/electron/index.d.ts',
  startPosition:
   RuleFailurePosition {
     position: 112381,
     lineAndCharacter: { line: 2433, character: 4 } },
  endPosition:
   RuleFailurePosition {
     position: 112406,
     lineAndCharacter: { line: 2433, character: 29 } } }

RuleFailure {
  failure: 'unexpected label on statement',
  ruleName: 'label-position',
  fix: undefined,
  fileName: 'test-smoke/electron/index.d.ts',
  startPosition:
   RuleFailurePosition {
     position: 112457,
     lineAndCharacter: { line: 2437, character: 4 } },
  endPosition:
   RuleFailurePosition {
     position: 112470,
     lineAndCharacter: { line: 2437, character: 17 } } }

RuleFailure {
  failure: 'unexpected label on statement',
  ruleName: 'label-position',
  fix: undefined,
  fileName: 'test-smoke/electron/index.d.ts',
  startPosition:
   RuleFailurePosition {
     position: 112520,
     lineAndCharacter: { line: 2441, character: 4 } },
  endPosition:
   RuleFailurePosition {
     position: 112532,
     lineAndCharacter: { line: 2441, character: 16 } } }

RuleFailure {
  failure: 'unexpected label on statement',
  ruleName: 'label-position',
  fix: undefined,
  fileName: 'test-smoke/electron/index.d.ts',
  startPosition:
   RuleFailurePosition {
     position: 112582,
     lineAndCharacter: { line: 2445, character: 4 } },
  endPosition:
   RuleFailurePosition {
     position: 112594,
     lineAndCharacter: { line: 2445, character: 16 } } }

RuleFailure {
  failure: 'unexpected label on statement',
  ruleName: 'label-position',
  fix: undefined,
  fileName: 'test-smoke/electron/index.d.ts',
  startPosition:
   RuleFailurePosition {
     position: 112648,
     lineAndCharacter: { line: 2449, character: 4 } },
  endPosition:
   RuleFailurePosition {
     position: 112658,
     lineAndCharacter: { line: 2449, character: 14 } } }

RuleFailure {
  failure: 'unexpected label on statement',
  ruleName: 'label-position',
  fix: undefined,
  fileName: 'test-smoke/electron/index.d.ts',
  startPosition:
   RuleFailurePosition {
     position: 112701,
     lineAndCharacter: { line: 2453, character: 4 } },
  endPosition:
   RuleFailurePosition {
     position: 112706,
     lineAndCharacter: { line: 2453, character: 9 } } }

RuleFailure {
  failure: 'unexpected label on statement',
  ruleName: 'label-position',
  fix: undefined,
  fileName: 'test-smoke/electron/index.d.ts',
  startPosition:
   RuleFailurePosition {
     position: 112750,
     lineAndCharacter: { line: 2457, character: 4 } },
  endPosition:
   RuleFailurePosition {
     position: 112756,
     lineAndCharacter: { line: 2457, character: 10 } } }

RuleFailure {
  failure: 'expected an assignment or function call',
  ruleName: 'no-unused-expression',
  fix: undefined,
  fileName: 'test-smoke/electron/index.d.ts',
  startPosition:
   RuleFailurePosition {
     position: 111958,
     lineAndCharacter: { line: 2409, character: 4 } },
  endPosition:
   RuleFailurePosition {
     position: 111959,
     lineAndCharacter: { line: 2409, character: 5 } } }

RuleFailure {
  failure: 'expected an assignment or function call',
  ruleName: 'no-unused-expression',
  fix: undefined,
  fileName: 'test-smoke/electron/index.d.ts',
  startPosition:
   RuleFailurePosition {
     position: 111969,
     lineAndCharacter: { line: 2409, character: 15 } },
  endPosition:
   RuleFailurePosition {
     position: 111976,
     lineAndCharacter: { line: 2409, character: 22 } } }

RuleFailure {
  failure: 'expected an assignment or function call',
  ruleName: 'no-unused-expression',
  fix: undefined,
  fileName: 'test-smoke/electron/index.d.ts',
  startPosition:
   RuleFailurePosition {
     position: 112020,
     lineAndCharacter: { line: 2413, character: 14 } },
  endPosition:
   RuleFailurePosition {
     position: 112027,
     lineAndCharacter: { line: 2413, character: 21 } } }

RuleFailure {
  failure: 'expected an assignment or function call',
  ruleName: 'no-unused-expression',
  fix: undefined,
  fileName: 'test-smoke/electron/index.d.ts',
  startPosition:
   RuleFailurePosition {
     position: 112084,
     lineAndCharacter: { line: 2417, character: 19 } },
  endPosition:
   RuleFailurePosition {
     position: 112091,
     lineAndCharacter: { line: 2417, character: 26 } } }

RuleFailure {
  failure: 'expected an assignment or function call',
  ruleName: 'no-unused-expression',
  fix: undefined,
  fileName: 'test-smoke/electron/index.d.ts',
  startPosition:
   RuleFailurePosition {
     position: 112174,
     lineAndCharacter: { line: 2421, character: 28 } },
  endPosition:
   RuleFailurePosition {
     position: 112181,
     lineAndCharacter: { line: 2421, character: 35 } } }

RuleFailure {
  failure: 'expected an assignment or function call',
  ruleName: 'no-unused-expression',
  fix: undefined,
  fileName: 'test-smoke/electron/index.d.ts',
  startPosition:
   RuleFailurePosition {
     position: 112238,
     lineAndCharacter: { line: 2425, character: 21 } },
  endPosition:
   RuleFailurePosition {
     position: 112245,
     lineAndCharacter: { line: 2425, character: 28 } } }

RuleFailure {
  failure: 'expected an assignment or function call',
  ruleName: 'no-unused-expression',
  fix: undefined,
  fileName: 'test-smoke/electron/index.d.ts',
  startPosition:
   RuleFailurePosition {
     position: 112322,
     lineAndCharacter: { line: 2429, character: 29 } },
  endPosition:
   RuleFailurePosition {
     position: 112329,
     lineAndCharacter: { line: 2429, character: 36 } } }

RuleFailure {
  failure: 'expected an assignment or function call',
  ruleName: 'no-unused-expression',
  fix: undefined,
  fileName: 'test-smoke/electron/index.d.ts',
  startPosition:
   RuleFailurePosition {
     position: 112408,
     lineAndCharacter: { line: 2433, character: 31 } },
  endPosition:
   RuleFailurePosition {
     position: 112415,
     lineAndCharacter: { line: 2433, character: 38 } } }

RuleFailure {
  failure: 'expected an assignment or function call',
  ruleName: 'no-unused-expression',
  fix: undefined,
  fileName: 'test-smoke/electron/index.d.ts',
  startPosition:
   RuleFailurePosition {
     position: 112472,
     lineAndCharacter: { line: 2437, character: 19 } },
  endPosition:
   RuleFailurePosition {
     position: 112479,
     lineAndCharacter: { line: 2437, character: 26 } } }

RuleFailure {
  failure: 'expected an assignment or function call',
  ruleName: 'no-unused-expression',
  fix: undefined,
  fileName: 'test-smoke/electron/index.d.ts',
  startPosition:
   RuleFailurePosition {
     position: 112534,
     lineAndCharacter: { line: 2441, character: 18 } },
  endPosition:
   RuleFailurePosition {
     position: 112541,
     lineAndCharacter: { line: 2441, character: 25 } } }

RuleFailure {
  failure: 'expected an assignment or function call',
  ruleName: 'no-unused-expression',
  fix: undefined,
  fileName: 'test-smoke/electron/index.d.ts',
  startPosition:
   RuleFailurePosition {
     position: 112596,
     lineAndCharacter: { line: 2445, character: 18 } },
  endPosition:
   RuleFailurePosition {
     position: 112603,
     lineAndCharacter: { line: 2445, character: 25 } } }

RuleFailure {
  failure: 'expected an assignment or function call',
  ruleName: 'no-unused-expression',
  fix: undefined,
  fileName: 'test-smoke/electron/index.d.ts',
  startPosition:
   RuleFailurePosition {
     position: 112660,
     lineAndCharacter: { line: 2449, character: 16 } },
  endPosition:
   RuleFailurePosition {
     position: 112667,
     lineAndCharacter: { line: 2449, character: 23 } } }

RuleFailure {
  failure: 'expected an assignment or function call',
  ruleName: 'no-unused-expression',
  fix: undefined,
  fileName: 'test-smoke/electron/index.d.ts',
  startPosition:
   RuleFailurePosition {
     position: 112708,
     lineAndCharacter: { line: 2453, character: 11 } },
  endPosition:
   RuleFailurePosition {
     position: 112715,
     lineAndCharacter: { line: 2453, character: 18 } } }

RuleFailure {
  failure: 'expected an assignment or function call',
  ruleName: 'no-unused-expression',
  fix: undefined,
  fileName: 'test-smoke/electron/index.d.ts',
  startPosition:
   RuleFailurePosition {
     position: 112758,
     lineAndCharacter: { line: 2457, character: 12 } },
  endPosition:
   RuleFailurePosition {
     position: 112765,
     lineAndCharacter: { line: 2457, character: 19 } }

cc @miniak -- any ideas what might be causing this?

Ah it's the 2d_canvas key. Can't start with a number.


Send client remoting version and API version as header

Should possibly do this as part of user agent?

Done


[chore] update ubuntu

Fixes # .
Motivation
Update ubuntu 20.04
Solution
Update ubuntu 20.04
Open questions

Pull Request Test Coverage Report for Build 1550

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.09%) to 70.714%

Files with Coverage Reduction
New Missed Lines
%

indexer/indexer.go
2
74.23%

Totals

Change from base Build 1543:
-0.09%

Covered Lines:
1584

Relevant Lines:
2240

💛  - Coveralls


Scan details route

The development for now is completed because that we have some issues to be fixed with bookshelf to test the task thoroughly. We can review the task after the issue has been addressed.

Added test in half penny (dynamic path parameter passed to the test from test scripts)
Added validation for response.

I followed up some commits to get this closed out


add fix as PR https://github.com/Azure/azure-rest-api-specs/pull/2364

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[ ] The title of the PR is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[ ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[ ] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[ ] I have read the contribution guidelines.
[ ] My spec meets the review criteria:

[ ] The spec conforms to the Swagger 2.0 specification.
[ ] The spec follows the guidelines described in the Swagger checklist document.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Quick look validated what @azhao155 said. Because this is only a feature branch, we don't need to much extra scrutiny.

This commit was treated and no generation was made for Azure/azure-sdk-for-go

Swagger to SDK encountered an unknown error: (Azure/azure-sdk-for-go)
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 29, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 180, in rest_handle_action
    return rest_pull_close(body, github_con, restapi_repo, sdk_pr_target_repo, sdkbase)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 311, in rest_pull_close
    rest_pr.create_issue_comment("Was unable to create SDK %s PR for this closed PR.", sdkid)
TypeError: create_issue_comment() takes 2 positional arguments but 3 were given

This commit was treated and no generation was made for Azure/azure-sdk-for-python

Was unable to create SDK Azure/azure-sdk-for-python PR for this closed PR.


Adjust SSP Viewer for FedRAMP template

Adjustments have been made in the visual display of the FedRAMP SSP template, importing a profile, and displaying statements.
Visually, columns in System Characteristics and System Implementation have been adjusted in placement and size to lessen word wrap and fill more of the negative space. While making visual adjustments, the placement of other elements on screen were maintained.
After resolving the import-profile xml link in OSCALSspResolver, there was a need to rework how statements are fetched for the implementation controls to display correctly. This FedRAMP SSP template provided the set-parameters in the first/overarching statement, rather than each individual statement for the controls. For example, the set-parameters are listed purely in "ac-1_smt" versus being listed in something like "ac-1_smt.a" or "ac-1_smt.b.1" in NIST's SSPs. OSCALControl now tries to grab these statements (which are null if provided like NIST's statements), then passes them to underlying components. With this added feature, the SSP Viewer has no problem handling controls from both NIST and FedRAMP.

Resolves #133

Testing
Use the FedRAMP SSP template when running the SSP Viewer.

I chose to make the set-parameter fetch into a separate function in OSCALControl. I was wondering if we would even want to split this up further or place it elsewhere - like in ./oscal-utils? At this point, the implReqStatements grab and by-component id checks aren't used outside the scope of OSCALControl, but could potentially be referenced by components in the future?


Add XcodeProj extensions and models

Related to #101, #371.
This is part 2 of 3 parts for the Xcode scheme generation. The follow-on PR contains the meat of the logic. Breaking out these peripheral changes will make it easier to review the next PR.

Add isTestBundle to PBXProductType
Add buildableName, createBuildableReference, isTestable, and isLaunchable to PBXTarget
Add XcodeProjContainerReference to represent a referencedContainer string in Xcode schemes

FYI. I forgot to add defaultBuildConfigurationName to PBXTarget. I updated this PR to include it along with its tests.


Fixes issue #181 by adjusting Float casting.

See issue #181 for details.

This is a developer-facing breaking change that could break developer code.
Float longitude = sendLocation.getLongitudeDegrees(); // won't compile after this change

If this is a change that really needs to be made, technically the methods with Float type should be deprecated and replaced so existing developer code isn't affected.  This also allows the change to be brought in in 4.* instead of 5.0 under semantic versioning.

The problem with deprecating the getter and setter methods is that there will be library conflicts that won't compile.
public Float getLongitudeDegrees()
public Double getLongitudeDegrees() // This will cause a conflict

However, the code will compile that you mentioned before, but it will cause a ClassCastException because you cannot cast a Double to a Float in that manner, you would need to call .floatValue() or change your current value to a Double.
So in light of that, even renaming the legacy code method will still cause this runtime exception to occur. Any ideas on how to solve that issue then? @mrapitis @mikeburke106

Can we please discuss further in our next PR review.

@MikaylaRay44 Ahh, good point.  I don't think you have a choice, then, you'll have to make it a breaking change and it won't be able to be released until 5.0 under semantic versioning.  It also needs to be documented for developers to change their type to Double to fix the error that will be introduced in their code.

Also, instead of doing your reflection (instanceof) in each of the methods, you should use the SdlDataTypeConverter.objectToDouble method to be consistent with other classes.  Once the breaking change is made, you should no longer have to account for the floating point type.


Some changes

Left some more documentation for you

I will close this.
Appreciate the contribution, but don't consider it gives proper value, the descriptions seems a little bit off in the context they were put. Also for proper doc /// should be used.


Suggestion: add derivation logs in the summary

I, at least, have the habit of when a a PR settles I run this to check if that works on my machine is not happening but sometimes the build fails and it only posts if a package is failed or successfully built without any kind of logs.
My suggestion is to add the logs using summary/details so the logs are hidden by default but still acessible when the summary is posted.
But there are some concerns:

How it will look in notification emails?
Do GitHub have some kind of body limit when submitting a PR comment?
Isn't it wiser to post the logs using a gist as ofborg sometimes do? (suggestion: all logs for a PR in the same gist using different files)

The link with related information about this summary/details thing: https://gist.github.com/scmx/eca72d44afee0113ceb0349dd54a84a2

I am bit concerned that we abuse gist as a ci pastebin service. Unlike other pastebins they store logs forever. Just now it's only ofborg itself but this would multiple the number of logs done by individuals?

Seems fair


Set up shared .lintignore file for all linters

When committing *.scss files into ./package we see the following error:
✖ npm run lint:scss:cli -- --fix:
Error: All input files were ignored because of the ignore pattern. Either change your input, ignore pattern or use "--allow-empty-input" to allow no inputs

This PR extends this fix for ESLint for StyleLint too:

https://github.com/alphagov/govuk-frontend/pull/3186

Adding .lintignore largely duplicates .gitignore but adds "built-but-committed" directories such as:

./dist
./package

I've got a few concerns about this solution to the issue:

re-using the .gitignore ensures we don't forget to move a value from one of the list to the other. Duplicating it in a separate list feel like a recipe for forgetting to port one of the entry to .lintignore. If we really want to factor commited-but-to-be-ignored files, we could always use a JS module to share them across both config files, but imho, it's fine that there's a little separation between the two tools.
ESLint is used for filtering files linted at commit both for Stylelint and ESLint. Would that risk missing a file because a nested .eslintrc.js adds extra ignore patterns? It also feels a risk for the future in case the tools filtering diverges.

The error message makes it sound like Stylelint has a flag that would let us not worry about it trying to run on ignored files. Would it be fine to just use that instead rather than take more responsibilities on our side (it's a shame ESLint doesn't provide the same :'( )

@romaricpascal Shall I stick with a separate ignore file for each tool?
Will have the same problem with Prettier and EditorConfig
Not many repos commit their compiled code so I'm open to other ideas! 💡

Fair point about other linters, hadn't thought of that.
As it's really a "commit-on-linting" concern, how about we keep it to .lintstagedrc.js with an explicit list of locations that shouldn't get linted on commit (dist, package and src/vendor), filtered with our own globbing rather than tie it to the linter's own configurations?
That'd keep each concern (linting language X, linting on commit) isolated and feels a little safer to not tangle them all together?

And I realise I didn't answer your first question, but yeah, what I described would keep each linter in their current configuration (load .gitignore + have a couple of patterns in their config).

Oh sorry, I didn't mean to have a .gitignore + a .<name-of-the-tool>ignore file, but to follow the current convention of using .gitignore as the tool's ignore file and having extra paths in the .<name-of-the-tool>rc.js or .<name-of-the-tool>.config.js file.

Oh sorry, I didn't mean to have a .gitignore + a .<name-of-the-tool>ignore file, but to follow the current convention of using .gitignore as the tool's ignore file and having extra paths in the .<name-of-the-tool>rc.js or .<name-of-the-tool>.config.js file.

Sorted 👍
Prettier can only have "ignores" in .prettierignore but that's for another PR

Might be worth renaming the PR, though as it's now mostly fixing the Stylelint issue rather than setting a common ignore list 😆


[WIP] Add Arm64 support

Currently, this PR will build the jaeger operator and image with arm64 support, however the operator itself still uses the x86_64 image for instances of operator.

This change is

Oops, sorry, meant to open it against my repo until it's functional and ready for a PR.


change make_rootfs.sh to support centos

Now there is a commity support CentOS aarch edition, Could we changde make_rootfs.sh to support it?

Do you miss something here?

@umiddelb Thanks. I could not download your rootfs in my country, the dns to resolve www.dropbox.com is missing. So I could download it by some free vpn. I try your method with the original CentOS-aarch64.img.xz. I also follow your scripts to complete the changes. But my pine64+ could not boot successfully. I have no tools to monitor the uart output now. The only one interface I can use is the hdmi. Could you share your rootfs to me by email?

@umiddelb The setups in https://github.com/vanloswang/z2d/tree/master/pine64 maybe out of date. I found out that it is not the same with the steps in your scripts.

@umiddelb The setups in https://github.com/vanloswang/z2d/tree/master/pine64 maybe out of date. I found out that it is not the same with the steps in your scripts.

Feel free to for the script and add CentOS to it. If you are going to maintain this and also add packaging including a repository then create a PR and i am willing to merge.

@vanloswang , the difference you've mentioned is related to the readme only. The file is way too large (380 MB) to send it via email. I've uploaded the archive to my Office365 Account. If this turns out to be inaccessible as well, you might suggest a service to which I can upload to.

@umiddelb Thank you very much. I am downloading it now.
@longsleep I will try it out.

@umiddelb @longsleep
The cmds bellow will make a bootable centos 7.2 sd card. After execute the following cmds, need to update kernel and uboot by using longsleep's platform scripts at this git repo. Later I will test the follow cmds and push it here.
curl http://mirror.centos.org/altarch/7/isos/aarch64/CentOS-aarch64.img.xz -f --progress-bar --output CentOS-aarch64.img.xz
xz -d CentOS-aarch64.img.xz
dd if=CentOS-aarch64.img of=/dev/sdb bs=1M oflag=sync
mount /dev/sdb2 rootfs/
cp -ar rootfs centos7-rootfs
umount rootfs/
dd if=simpleimage-pine64-latest.img of=/dev/sdb bs=1M oflag=sync
/bin/echo -e "d\n2\nn\np\n2\n143360\n\nw\n" | fdisk /dev/sdb
mkfs.ext4 -O ^has_journal -b 4096 -L rootfs  /dev/sdb2
mount /dev/sdb2 rootfs/
cp -ar centos7-rootfs/* rootfs/
/bin/cat >> rootfs/etc/rc.d/rc.local <<FOE
echo '123456' | passwd root --stdin
[ ! -d /root/.ssh ] && mkdir -p /root/.ssh && touch /root/.ssh/authorized_keys && chmod 700 /root/.ssh
FOE
chmod +x rootfs/etc/rc.d/rc.local
/bin/cat >> rootfs/usr/lib/systemd/system/rc-local.service <<FOE
[Install]
WantedBy=multi-user.target
FOE
cd rootfs/
ln -s usr/lib/systemd/system/rc-local.service etc/systemd/system/multi-user.target.wants/rc-local.service
cd -
sed -i "s/#PermitRootLogin yes/PermitRootLogin yes/g" rootfs/etc/ssh/sshd_config
/bin/cat > rootfs/etc/fstab <<FOE

/dev/mmcblk0p1  /boot   vfat    defaults                        0               2
/dev/mmcblk0p2  /       ext4    defaults,noatime                0               1
FOE
umount rootfs/
sync
So now I am running CentOS 7.2 aarch edition on my pine64+ with hdmi output.


[BUG]: Allow absolute path to migration output directory

What version of drizzle-orm are you using?
?
What version of drizzle-kit are you using?
?
Describe the Bug
From drizzle-kit-mirror repo: https://github.com/drizzle-team/drizzle-kit-mirror/issues/81.

I'm working on a project containing many custom CLI tooling to trigger different CLI commands from different libraries. To have the most reliable file path to execute, we will normally use absolute paths for all configs.
With that said, Drizzle-ORM Kit is currently auto-adding a relative prefix path (./) to the config path without checking whether it is absolute or not when using drizzle-kit generate:mysql command. We can have a workaround to modify our custom CLI to handle this library specifically but it would be best to have the kit to handle it automatically.
Another reason is, the same absolute path in the migrate function (provided by drizzle-orm/<provider>/migrator) will work perfectly fine. It's better to have this behavior consistent.
The idea can be: checking if the path provided is a valid "absolute" path, or will add the prefix afterward.
Below is the current behavior.

Expected behavior
No response
Environment & setup
No response

I got a workaround by calculating the relative path:
import { relative, resolve } from 'node:path';

export default defineConfig({
  dialect: 'postgresql',
  out: relative('./', resolve(__dirname, './drizzle/')),
  schema: resolve(__dirname, './models/schemas.js')
});


Docs: Authentication

I got to this repo page from https://securityscorecards.dev/, "Using the GitHub Action" Step 2.  The link says https://github.com/ossf/scorecard-action#authentication, but there is no authentication section. there's even another broken link to this non-existent section in the very same document.
https://github.com/ossf/scorecard-action#troubleshooting
Without instructions on how to Authenticate my repository access, I don't know what to do.

It's public.

It's public.

Then the linked section above should be applicable. Authentication should be optional for public repos, happy to help with any issues


Data links option has no effect

Hello,
I am trying to create a data link with the option in the side panel because I need to use data from the query. However, this doesn't have any effect. On other base panels (stat for eample), adding a data link directly provides a link when hovering over the whole panel.
Is this intentional ?
Also, props for the amazing hand-on documentation !

Hi! Are you referring to a hyperlink that directs you to another website/dashboard?

Closing out this issue due to lack of activity. If you need more help, please feel free to open a new one!


Revert "Compensate loss of transitivity"

This reverts commit 7c4bd676
See https://github.com/scala/scala3/pull/21344#issuecomment-2275111405
We will have to reconsider how to alleviate the transitory problem before releasing 3.6.
Fixes #21320

I belive we can also add some additional reproducers for recently found issues:

softwaremill/tapir - https://github.com/scala/scala3/issues/21352 reproducer
neandertech/langoustine - https://github.com/scala/scala3/pull/21344#issuecomment-2274037341
tpolcat/doobie - https://github.com/scala/scala3/pull/21344#issuecomment-2274207166


Editorial Workflow Templates

Provide templates for an editorial workflow similar to Netlify CMS

Hi! I was looking through for some alternatives on NetlifyCMS and whilst researching, I stumbled on this discussion at TinaCMS https://github.com/tinacms/tinacms/discussions/2962. I believe their discussions on an editorial workflow is worth a look.

Netlify CMS also dealt with this by using branching (and PRs), but in doing so nearly doubled the code needed for EACH backend, and not every backend could support it.
In my opinion editorial workflow and preview deployments are outside of the scope of this project (at least at current with the size of the community and the number of maintainers).
However, this does not mean a similar setup cannot be achieved with how the CMS is today. I've just completed a template showing exactly that. A two environment setup with draft posts not appearing in the production build, but showing in the staging build.
https://github.com/StaticJsCMS/static-cms-next-netlify-editoral-template


Shrink the size of thisamericanlife.svg by optimizing path

By rearranging the order of commands in the <path> element, we can shrink the overall size from 309 bytes to 302 bytes.

My apologies, I am using this repository as a way to learn how to contribute to open source projects, and I did not realize that by pushing to master I would be adding commits to this pull request. I will make feature branches from now on

That's OK - we all have to learn somewhere.
Could you please check the Vivino one against the reference icon? Your new version looks different from our original.

From what I can tell, my version is closer to the official reference file than the one that I modified. In the previous version, there were lots of misalignments peppered throughout.
If you look at the reference file, all of the circles are placed along a sort of standardized grid system, where each circle is equidistant to each of their closest neighbors. Each circle is exactly aligned with every other circle in the same row and column. My version replicates this design and fixes some of the sloppiness in the previous version

Would you like me to make a separate pull request for altering vivino.svg? The current icon can be shrunk without any changes to the icon. I just also happen to think that the current icon's fidelity can be improved

Sounds good.


Translations

Good evening , I am French , and I would like to know if the project will be translated later :) ? (Sorry my english is bad)

@Thomasfda hello, I am Brazilian and my English is too bad,  I myself already started translating some things in the app

Hi @gncgabriel i think started translation at french

would be cool something that when the user opens the APP he could choose the language of the app, but I think too early for that

I also think I'll see for a translation and I'll post a job if the translation is accepting :) !

He need think about it but it's take more time to translates to foreign languages

I think I can facilitate its work

I'm italian and good with English... I can help you with italian translation!

I have started a translation :)

I could help with spanish translation if you want ;)

How did you go about translating this? Did you just edit the hard-coded strings in the project?
I'm going to probably add a strings localization file so that translations can be easier to plug in and out based on language

:)

I translate on files .html
I will create another subject for French translation

Hi, I'll quickly make a commit including json files with the english strings :)

Cool i translate the file after :D !

Hi, can I help for Turkish language?

Good to see Brazil working together on this project. Congratulations to all of you.

Hi! I can help translate the app to PT-BR too.

I can help with translation to dutch if you want

I can help translate into german :)

me with Czech :)

I would love to help with Norwegian. How can I help?

I will also provide updates to the dutch languages files, but I think now the focus is on building up the app. I will keep following and translate new added strings later

I want to help translate for pt-BR

Well I see how many people here want's to help to build the app and translate, however its not so simple but I can help you guys showing some videos about the apache Cordova

I wanna help with translation to turkish if you want to

I'd love to help with the portuguese Portugal (pt-PT) translation

@eduardoribeiro , already done by someone.
colors not the same comparing to the previous posts

@sefor I've changed them to Cyan which is a lot easier for the eyes and helps creating our own identity :)

@filfat I agree. We need create your own identity for the app and change the yellow to cyan its ok however some elements of snapchat (the best of)  app need be in something like a: A ghost or something very similar to final user thinks (this is a client but its already Snapchat)

The translation to PT-BR seems to be ok

@fifat ok, I understand and agree 😊

I'd be happy to help translate into German, and other languages (Icelandic, Old Norse, Old English, Gothic, Saxon/Low German, Frisian, etc).

We need now volunteers to translate the app in Chinese Mandarim and Japanese

Hello. I am from turkey. I can translate to turkish

I can help you traslating to spanish and catalán

@marcus2310 here are translation files, look around to see if there are mistakes or add some language that isn't added yet. But be careful, you have to maintain the same format/style of code. here is a Spanish translation file.

I can translate into Polish


python311Packages.nikola: 8.2.4 -> 8.3.0

Changelog: https://github.com/getnikola/nikola/blob/v8.3.0/CHANGES.txt
Description of changes
Fix failure (https://hydra.nixos.org/build/251433445)

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 293428 run on x86_64-linux 1

2 packages marked as broken and skipped:

python312Packages.nikola
python312Packages.nikola.dist

2 packages built:

python311Packages.nikola
python311Packages.nikola.dist


Conan SBOM JSON is malformed

Looking at the JSON output from the tool it looks to be malformed.
Before the most recent update, the generated JSON contained:
"bomFormat": "CycloneDX",
"specVersion": "1.3",
"serialNumber": "urn:uuid:<id>",
"version": 1,
"metadata": {
  "component": {
  "bom-ref"<EMAIL_ADDRESS>  "type": "application",
  "name": "unknown",
  "version": "0.0.0"
  }
}

This information is no longer found in the JSON

@wyatt-paquin Can you please give a (minimal) example input and output (as it seems to work fine for me)? We did not touch the metadata part.


beartype 0.5.1 (new formula)

That's what happens when you copy and paste without checking if the spacing changed...

That's what happens when you copy and paste without checking if the spacing changed...


fix for N-term mods

Hello,
Thanks for the great Alphapeptdeep tool. I was testing reading in PSMs from MSFragger pepxml files and noticed the b-ion masses were not calculated correctly. Previously, the peptide [n-term acetylation]MD[ADP-ribosyl]LSGVK had b_masses from alphabase.peptide.fragment.calc_fragment_mz_values_for_same_nAA() reported as
[45.96352207<PHONE_NUMBER>7<PHONE_NUMBER>5<PHONE_NUMBER>6<PHONE_NUMBER>8 1058.25749209]. In addition, it was assigning the n-terminal acetylation to mod_deltas instead of mods. With the proposed changes, n-terminal modified peptides now have correct b-ion masses
[173.05104977<PHONE_NUMBER>7<PHONE_NUMBER>5 1029.25514216 1086.27660588 1185.34501979].
I have not tested this with C-terminal mods.
Thanks,
Kevin

Hi Kevin,
Please check if it works on the updates yesterday:
https://github.com/MannLabs/alphabase/blob/development/alphabase/psm_reader/msfragger_reader.py
I renamed mod_deltas -> aa_mass_diffs.

C-term mod is still missing (mod_site=-1 in alphabase), It will be great if you can help.

Sure, I can run some C-term PTM data later.
I missed the changes in the development branch before, but they also fix the issue I was having.
I also noticed the default now is to exclude peptides that have unknown mass differences. If keep_unknown_aa_mass_diffs=True and these peptides are included in Alphapeptdeep training, how will they be interpreted? Will they be ignored during training?

Yes, these aa_mass_diffs will be ignored for DL models, as they don't have atom compositions.


feat(repo settings): approve build mechanism for pull_request events

DESCRIPTION
Inspired by this behavior that GH Actions is able to do.
This functionality would protect our user base from untrusted sources executing pipelines without approval. It is also much more tenable to provide this capability rather than show warnings like this.
This security enhancement was made possible by the temporary storage of compiled build objects (main PR for that). Using this, we can put builds on the ice box while they await approval.
The below diagrams illustrate this process (note the two DB icons are the same database, just duplicated for readability):
BEFORE

AFTER

MISC
As an aside, this will close all these open PRs for trying to differentiate PR events from forks:
Closes https://github.com/go-vela/types/pull/271
Closes https://github.com/go-vela/server/pull/727
Closes https://github.com/go-vela/ui/pull/593

Slotting for v0.23

@wass3rw3rk Included auditing and put the fork terminology in the constants rather than the field name with latest commit. Let me know what you think!


Fix deprecated NetBSD sigaction/sigaltstack symbols

Especially sigaction is needed for NetBSD/amd64, as otherwise every invocation crashes with ENOSYS since the legacy system call was never available on x86_64.
This replaces rust-lang/libc#191

Weird, not sure why ctest didn't pick this up? ah well
Thanks!


fix: missing global in browser environments

Which problem is this PR solving?

Fixes https://github.com/open-telemetry/opentelemetry-js/issues/1066

Short description of the changes

Add fallbacks for global accessing.

It turns out global shimming can not be turned off for assert depending on it...

I try this fix in my angular app and it works. :+1:

Codecov Report

Merging #1067 into master will increase coverage by 1.42%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1067      +/-   ##
==========================================
+ Coverage   95.17%   96.60%   +1.42%
==========================================
  Files         216      199      -17
  Lines        9063     8274     -789
  Branches      819      678     -141
==========================================
- Hits         8626     7993     -633
+ Misses        437      281     -156

Impacted Files
Coverage Δ

packages/opentelemetry-api/src/api/global-utils.ts
100.00% <100.00%> (ø)

packages/opentelemetry-api/src/platform/index.ts
100.00% <100.00%> (ø)

.../opentelemetry-api/src/platform/node/globalThis.ts
100.00% <100.00%> (ø)

...kages/opentelemetry-api/src/platform/node/index.ts
100.00% <100.00%> (ø)

...opentelemetry-context-zone-peer-dep/src/version.ts

...kages/opentelemetry-web/src/StackContextManager.ts

packages/opentelemetry-web/src/version.ts

...es/opentelemetry-exporter-collector/test/helper.ts

...emetry-exporter-collector/src/CollectorExporter.ts

...es/opentelemetry-exporter-collector/src/version.ts

... and 17 more

@open-telemetry/javascript-approvers this is high-priority so please take a look. The API is currently broken in all web scenarios.

@dyladan @obecny Just wonder, why this is not captured by the build? Can we do something here to handle this kind of issues in the compile or build time?

I would have expected the browser tests to catch this. API tests must not be run in browser? I'll look into it.

As I mentioned above, webpack added shimming for global in testing so we can access global in the testing environment.
I was trying to disable webpack’s global shimming in testing, but the assert shimming is depending on it, it can not be turned off.

@legendecas please avoid force pushes where possible. It breaks several features of the github UI useful during code reviews.


How add all steps for failed tests?

Hello, Taisia. Thanks for the wonderful plugin.
How I can see all steps for a failed test? At the moment, the report shows only successful steps, and the rest are missed. It would be very nice to see all the steps from the test plus the red-marked step that fell.

For example, in this test, I have 6 steps + expected result. The test failed on the third step, but the third step and other steps after them are not displayed.
And is it possible to add information about steps only for failed tests, and not add information about steps and cypress commands for passed tests?

@AndriiZhydkykh hello,
Actually failed steps should be added automatically as you can see in this example report https://mmisty.github.io/cypress-allure-adapter-example/
To understand why that didn't work for you could you please

share what is your test
your configuration (e2e.ts, plugins setup)
environment variables
how you start your tests

Thank you

Link to gitlab page https://allure-steps-example-andryzhidkikh-75825e16afa675914fb9248c80df.gitlab.io/
Link to gitlab repo -https://gitlab.com/andryzhidkikh/allure-steps-example
No failed steps are marked in red

@AndriiZhydkykh thank you!
So I see that you have disabled cypress commands logging by allureLogCyCommands: false
You don't see failed commands because of that. Set it to true.
if you want to see only your created steps you need to wrap cypress commands with allure steps:
 it('.type() - type into a DOM element', () => {
    cy.allure().startStep('1.Step one');
    cy.get('.action-email').type('fake@email.com').should('have.value', 'fake@email.com');
    cy.allure().endStep();

    cy.allure().startStep('2.Step two');
    cy.get('.action-disabled').type('disabled error checking', { force: true });
    cy.allure().endStep();
    // ...
  })

it('.type() - type into a DOM element', () => {
cy.allure().startStep('1.Step one');
cy.get('.action-email').type('fake@email.com').should('have.value', 'fake@email.com');
cy.allure().endStep();
cy.allure().startStep('2.Step two');
cy.get('.action-disabled').type('disabled error checking', { force: true });
cy.allure().endStep();
// ...

})
It does not help. I expected something like this

If I added allureLogCyCommands - true. I will see failed cypress commands but not steps. This can be misleading since it is not clear at what steps the test failed. Especially when the report is viewed by a developer or a manual QA

The command get: .action-disabled which failed is located inside step three, but this step is displayed as passed - with a green checkmark

@AndriiZhydkykh as I can see from your screenshot you still didn't wrap cypress commands by allure steps. You use cy.allure().step() but you need to to use cy.allure().startStep('my step'),
then add any cypress commands
and after that you need to end step
by step cy.allure().endStep()
And if some cypress commands fail inside your step then the step will be marked as failed in the report.

@mmisty Yes, forgive my inattention. Thank you, you helped me a lot with your plugin and help.


Add myself as a library author

Note on the Travis failure: I recently uploaded version 0.2 of my package, which has GHC8-compatible dependency bounds, shortly before filing this pull request. The TravisCI log indicates it was still trying to use the previous version, v0.1.

Restarted Travis.

Merged, thanks!


Replace fsfreeze with prior behavior of system sync due to race condition

there is a race condition around the fsfreeze between mount point evaluation of a device and the invocation of the fsfreeze if the device is unmounted from that mount point, the folder will now reference the original device that hosts the mount point folder.
As a hotfix I am removing the fsfreeze invocation and replacing it with our previous behavior of calling sync.
As a result of this change, the volume head is no longer dirty after
a snapshot operation unless there was additional io, so we are again
skipping recurring backups if no new io is present.
REF: longhorn/longhorn#2555
ISSUE: longhorn/longhorn#3125

@yasker the integration test was added to validate the correct functionality of the volume + snapshot operations for a mounted filesystem, previously if I remember correctly we only ever tested the block dev non mounted case.
Due to the timing of the fsfreeze/snapshot operation O(1) and the complexities involved to query a fs to see if it's frozen (fsfreeze has no mechanism to do so besides calling freeze/unfreeze, which would negatively impact the test) there is no automatic verification done that the fs is frozen during the snapshot operation outside from the log entries.
Instead it's only verified that the volume + snapshot operation produce the correct expected result.
Some additional research is required in this regard for a new fsfreeze solution but from a quick look it seems like there a syscalls that can be used for bdev and fs evaluation. https://linux-fsdevel.vger.kernel.narkive.com/Dfcmf0Aq/patch-1-2-fsfreeze-add-fiisfrozen-ioctl

LGTM.

LGTM


tusd converts Upload-Metadata headers to lowercase

Question
Hi, I'm using tusd in a system where users can upload files into S3-compatible cloud storage. Then, a user may want to download file back in the browser by the signed URL to the file on S3. So, in the browser's save dialog I want a file name and file extension to be set as in the original file. It can be done, if I set the following file metadata in the cloud storage:

Name
Value

ContentDisposition
attachment; filename="myFile.mov"

However, when I try to pass ContentDisposition metadata in the Upload-Metadata request header, it gets converted to lowercase, i.e. contentdisposition, and this is how it is saved in the file metadata on S3. And it does not work to provide a file name and file extension on download then.
This is not a tus-js-client problem, because I can see that the Upload-Metadata header of the request to tusd is set correctly with ContentDisposition, not contentdisposition.
Is it possible to configure tusd not to do lowercase conversion of Upload-Metadata request header? Is it the expected behaviour?
Setup details

Operating System: running tusd in a docker, from official image: https://hub.docker.com/layers/tusproject/tusd/v1.11.0/images/sha256-db463b74ebb57a7bc959d8ac364dd007bf8fd49d50ede93c0dde885800e74602?context=explore
Used tusd version: v1.11.0
Used tusd data storage: AWS S3 compatible
Used tusd configuration: -s3-endpoint $BUCKET_ADDRESS -s3-bucket $BUCKET_NAME -metrics-path /admin/prometheus -port=8080 --hooks-http $HOOK_ADDRESS -base-path $BASE_PATH -behind-proxy
Used tus client library: tus-js-client 2.3.1

I don't see any code that would lower case the metadata keys in tusd, so I would assume that this is maybe even done by S3 itself. However, this should also not matter in this case because header values are usually treated case insensitively.
What might be the problem is that you are using ContentDisposition instead of Content-Disposition. I am not entirely sure if that is the root cause, but at least the HTTP header is written with a dash.

Okay, I'll try to check what S3 does on that, thanks.
I know that the correct HTTP header name is with the dash (Content-Disposition), however, when I try to pass it within Upload-Metadata it is not saved as a metadata to S3.
On the other hand, when I manually add ContentDisposition (CamelCase, no dash) metadata to the file on S3, it gets downloaded with file name and extension info as I want it to. So, it actually works, I just cannot find the way to set this metadata correctly from tusd yet.

So, it seems that setting metadata only is not working for Content-Disposition.
I had a look at the CreateMultipartUploadInput of the AWS S3 go SDK here and it has a separate field ContentDisposition. So, I think when the multipart upload is created in s3store.go
	// Create the actual multipart upload
	res, err := store.Service.CreateMultipartUploadWithContext(ctx, &s3.CreateMultipartUploadInput{
		Bucket:   aws.String(store.Bucket),
		Key:      store.keyWithPrefix(uploadId),
		Metadata: metadata,
	})

it should also set ContentDisposition field separately here:
	// Create the actual multipart upload
	res, err := store.Service.CreateMultipartUploadWithContext(ctx, &s3.CreateMultipartUploadInput{
		Bucket:   aws.String(store.Bucket),
		Key:      store.keyWithPrefix(uploadId),
		Metadata: metadata,
		ContentDisposition: ...,
	})

I tested setting metadata from AWS S3 java SDK, it also has the separate field for ContentDisposition and it works correctly when I set it.
So, I would love if you guys could fix this.
I believe the same applies to ContentLanguage metadata/header, and maybe some others.

That makes sense. Then we would have to populate these properties. I think we could fill Content-Disposition and Content-Type from the metadata keys filename and filetype, like we already do when we respond to GET requests: https://github.com/tus/tusd/blob/b4ffdf43f034099ee46437271de2ff98c1f52397/pkg/handler/unrouted_handler.go#L763-L765
Feel free to open a PR for this! I am not sure when I could work on this.

Closing in favor of https://github.com/tus/tusd/issues/1016.


Add ids to the file validated page titles

This pr adds id's and removed leading spaces from the headings of the validated page. This is to make it easier for the automation tests to read the text.

CI: Security warnings found!


Create vfuse.rb

After making all changes to the cask:

[X] brew cask audit --download {{cask_file}} is error-free.
[X] brew cask style --fix {{cask_file}} reports no offenses.
[X] The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

[X] Named the cask according to the [token reference].
[X] brew cask install {{cask_file}} worked successfully.
[X] brew cask uninstall {{cask_file}} worked successfully.
[X] Checked there are no [open pull requests] for the same cask.
[X] Checked the cask was not already refused in [closed issues].
[X] Checked the cask is submitted to [the correct repo].

Closes https://github.com/caskroom/homebrew-cask/issues/30781.

Thanks @miccal


Uniswap - add CELO chain/network to the current Uniswap connector

Before submitting this PR, please make sure:

[ ] Your code builds clean without any errors or warnings
[ ] You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
Tests performed by the developer:
Test performed:
Set up gateway successfully
connected uniswap ethereum celo successfully
check wallet now showing on gateway connect command
check gateway balance show balance for the ethereum cello wallet
curl

[x] chain/status: ok
[x] /chain/balances
[x] add/ remove wallet: ok
[x] /amm/price: ok

Tips for QA testing:

Test performed:

Cloned and installed gwPR313 and development latest Client
gateway generate certs and make sure gateway ONLINE
/wallet/add: ok
amm/price: could check price succesfully, but price could be strange for some tokens (also same for uniswap site app prices)
amm/trade: Failed to trade CELO-USDC: "Error: Unsupported trade object
amm/trade: Failed to trade SUSHI-USDC: "Trade query failed: priceSwapOut: no trade pair found for 0xcebA9300f2b948710d2653dD7B07f33A8B32118C to 0x29dFce9c22003A4999930382Fd00f9Fd6133Acd1."

Note: CELO prices on celoscan and uniswap could not match.

Note: on celoscan there're 5 USDC tokens with same ticker so you have to modify tokenlist before start

i will look into this and give a feedback @nikspz

changes have been made @nikspz

@elijahsnoz
commit 1231296
Test performed:
cloned gwPR313 and development hummingbot client
connected gateway successfully
gateway connector-tokens added USDC and cETH
gateway balance - Failed to check USDC balance (and cETH balance as well)
price_uniswap - failed to check the price

Also, shoud it be celo chain as well?
https://celoscan.io/address/0x08940dc9b5a19fab9319b77c61dda7b8067e6843#tokentxns

Updated the token list. @nikspz, it doesn't need to be on the Celo chain since Celo is EVM compatible.

Sorry, I must have received incorrect information. I noticed that some separate EVM chains were extended from Ethereum also noticed other devs on similar project built on ethereum. Thank you for the clarification. I will proceed with adding Celo as a separate chain.

i did like to give a short @fengtality

I refactored the code at @fengtality  with Celo as a separate chain.

Failed to check balance using gateway balance
Steps:

Clone development + gwPR313
connect

logs_hummingbot.log
2024-06-04 20:37:48,682 - 4054695 - hummingbot.core.utils.async_utils - ERROR - Unhandled error in background task: 'NoneType' object is not subscriptable
Traceback (most recent call last):
  File "/home/nikita/d2/hummingbot/core/utils/async_utils.py", line 9, in safe_wrapper
    return await c
  File "/home/nikita/d2/hummingbot/client/command/gateway_command.py", line 524, in _get_balances
    bal_resp = await asyncio.wait_for(
  File "/home/nikita/miniconda3/envs/hummingbot/lib/python3.10/asyncio/tasks.py", line 445, in wait_for
    return fut.result()
  File "/home/nikita/d2/hummingbot/client/command/gateway_command.py", line 718, in all_balances_all_exc
    await self.update_exchange(client_config_map)
  File "/home/nikita/d2/hummingbot/client/command/gateway_command.py", line 713, in update_exchange
    results = await safe_gather(*tasks)
  File "/home/nikita/d2/hummingbot/core/utils/async_utils.py", line 22, in safe_gather
    return await asyncio.gather(*args, **kwargs)
  File "/home/nikita/d2/hummingbot/client/command/gateway_command.py", line 673, in update_exchange_balances
    return await self.add_gateway_exchange(exchange_name, client_config_map, **api_keys)
  File "/home/nikita/d2/hummingbot/client/command/gateway_command.py", line 649, in add_gateway_exchange
    market = GatewayCommand.connect_markets(
  File "/home/nikita/d2/hummingbot/client/command/gateway_command.py", line 602, in connect_markets
    connector_class = get_connector_class(exchange)
  File "/home/nikita/d2/hummingbot/client/config/config_helpers.py", line 563, in get_connector_class
    mod = __import__(conn_setting.module_path(),
  File "/home/nikita/d2/hummingbot/client/settings.py", line 214, in module_path
    return f"hummingbot.connector.{self.module_name()}"
  File "/home/nikita/d2/hummingbot/client/settings.py", line 204, in module_name
    return f"gateway.{self.type.name.lower()}.gateway_{connector_spec['chain_type'].lower()}_{self._get_module_package()}"
TypeError: 'NoneType' object is not subscriptable

logs_hummingbot.log

since it is a new chain it has to be included in supported chain constant on client @nikspz

would you like me to create a pr for that on client?

would you like me to create a pr for that on client?

ofc, if needed please proceed with it

https://github.com/hummingbot/hummingbot/pull/7073

Test performed:

Clone gatewayPR313 + PR7073
Connected gateway uniswap celo celo
Checked balance successfully
approved WETH and USDC successfully
created amm_arb using uniswap_celo_celo
started amm_arb, got Error: WETH, token not supported

logs_conf_amm_arb_1.log
gw313.zip

there was another weth in token list, removal of that should fix that @nikspz

Thanks for the work @elijahsnoz. I'm making some updates to the Uniswap connectors so that other PRs can be merged in. I'll address the conflicts in this one afterwards and see if I can get it over the line.

Thank you, @fengtality   I'm glad I could help.

Incorporated into #342


linux-hardkernel: 4.14.73-149 -> 4.14.78-150

Motivation for this change
Standard version bump. Tested on my Odroid HC1, seems to build and boot nicely.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

What slightly confuses me is that this causes a bunch of rebuilds for other platforms.
And why does Hydra build hardkernel modules ? https://hydra.nixos.org/jobset/nixpkgs/trunk/jobs-tab?filter=hardkernel

@xeji, I am afraid I've no idea, I don't know how Hydra really works :( I am also confused about that. (And also confused about why GrahamcOfBorg labels it as causing 101-500 linux rebuilds. Do really that many packages depend on the kernel?)

These rebuilds are all for other platforms while  hardkernel  is only for armv7.
Building modules based on hardkernel for x86_64-linux etc. makes no sense. There must be a bug somewhere. Anyway, it shouldn't be your problem :smile:


Problem with traefik using updated repository

I couldn't get traefik runing, I'm deleting all resources and try again, this worked with previous code after the last update
traefik-ingress-controller-6d697c497b-ltkmg
0/1
ContainerCreating

I'm going to close this one as we haven't run into it again.  Please feel free to re-open with additional information if you continue experiencing an issue.


[REQ] Filter by ratings

Related to #57. It would be great if there was a way to apply more rules to what is requested. For example, filtering by rating would be very useful. Kind of like what Overcrawlerr does.
Ideally, this would include ratings from various sources (Rotten Tomatoes, TMDB, Trakt, IMDB, etc.), but the easiest to implement is probably TMDB considering the existing integration. It should also consider how many review/votes were aggregated to form that score.
A couple of things that would need to be considered:

What if the review source does not include that show/movie?

Maybe have a setting for each filter of how to handle that (count it as a pass or fail of the filter condition).

API keys would be needed for each source used.

Adjust install instructions
Handle case where a rule exists for source which has no API key (avoid this causing an error in the CRON process and preventing other rules applying, or any suggestions from being added)

Example rules as they might appear in config.yaml:
FILTERS:
    - type: rating
      source: tmdb
      threshold: 75
      minimumVotes: 50
      failOnMissing: true

   -  type: rating
      source: imdb
      threshold: 7.5
      minimumVotes: 100
      failOnMissing: false

Hi @vahtos! Thank you for the suggestions 🙂
I've pushed an update to the nightly tag that includes some of these changes. Could you help test it out and let me know how it works?

WOW! That was so fast. It works for me, however a couple of notes:

The placeholder values on the inputs suggest to me that they are the default values if unset. So, I didn't set the Release Year initially, which broke suggestions. Clicking Run Now failed with the error:

Error: Value error: invalid literal for int() with base 10: ''

The value for "Include content with missing rating or votes" toggle gets saved to the config as a boolean [as FILTER_INCLUDE_NO_RATING] but the code expects a string. This causes suggestions to fail with the error:

Error: Unexpected error: 'bool' object has no attribute 'lower'

This is unrelated to this ticket (I can file another if you'd prefer), but I had an issue last night where requests were made in Overseerr (and thus auto-approved) with the admin account (it must have used the API Key), even though I have it set to log in with an unprivileged user so that requests should require approval. To remedy this, I had to edit the configuration, add the API Key [so that I could set the login credentials] and then remove the API Key to continue.

I think the solution here is that API Key should not be required for Overseerr/Jellyseerr, allowing users to specify a specific account OR an API key. This setup does appear to work, at least when I use the Run Now button. I'm not sure if there is some difference to running it that way vs. the way the CRON job runs it?

Hi @vahtos! Thank you so much for your detailed feedback and testing. It’s incredibly helpful for the development of this project!
I’ve pushed an update to the nightly tag that includes several fixes and improvements. I’ve also added a new field to allow selecting the original language of the content, with support for multiple language filters.
I’d love to hear your thoughts on it!

Hi @giuseppe99barchetta thank you for your time in working on this! Here are the issues that I found.
Data type issue in how this toggle is saved (saved as bool, expected to be string)

Placeholders are not defaults, this configuration is accepted -- and to many people might suggest language filter is US and release year minimum is 2000 -- but makes suggestions fail:

Hi @vahtos, thanks for the report! It looks like you're not on the latest nightly version. It seems to be the same one from yesterday. Could you try pulling the latest update?

Hi @vahtos, thanks for the report! It looks like you're not on the latest nightly version. It seems to be the same one from yesterday. Could you try pulling the latest update?

Yes, sorry about that. I've updated the previous comment.

Have you encountered any other issues? Anyway I pushed the fix for "Bool object has no attribute 'lower'" error right now :)

Not related to this ticket, no. I confirmed the rating threshold and vote count seem to be working (all suggestions within the values I set). All of the suggestions also followed the other filter settings I put, but though this is a small sample size.

Not related to this ticket, no. I confirmed the rating threshold and vote count seem to be working (all suggestions within the values I set). All of the suggestions also followed the other filter settings I put, but though this is a small sample size.

Great to hear the filters are working as expected! I'll plan to release this update soon. Just want to solve the duplicate request bug first. Thanks again for your feedback and testing!


Cannot received the otp by email

Hi Support,
i cant receive the otp by email, please check and advise

@donaldscho this project was a weekend hobby project from me many years ago. I dont think I will find time any time soon to do an update. I can accept and merge prs. Just note that this project is old and im not even sure if the digital ocean api has changed in the mean time :D I supposed to see that a few people still seam to use that app actively. I think today you will find many alternatives with more features in the AppStore :)


[devil] Fix 'tiff' option name.

Tiff feature is always disabled because of invalid option name.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: shaymagsumov sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Ignore Release Planner Tests when updating ADO Work Items

[IN DRAFT]
For testing purposes, the Release Planner App in DEV and PPE creates Work Items with the Release Planner Test Service tag on them.
Our automation - azure-sdk - version-updater >  Update release DevOps work-items task has not been updated to ignore these work items, so it has been founding duplicates when running. See this run for context.
In this PR I am adding a new condition to the query to ignore the Work Item if the tags contain Release Planner Test Service.

there was no need to use this branch for testing purposes anymore. Closing this draft PR in favor of 6503


NuGet.Server v3 Support

Is the NuGet.Server going to get support for NuGet v3 API and will it be ported to support multiple targets and thereby also .NET Core?

@danielwertheim , can you provide more details regarding your scenario?
Adding V3 support to NuGet.Server is currently not on our backlog.

@skofman1 honestly I guess it's more of an "will you keep this alive"...? But if V2 is to be supported for a long period it's not an issue. What's more interesting would be .NET Core support so that one easily could spin up "lighter" Docker containers with a custom host using NuGet.Server

@danielwertheim , V2 support is not going anywhere, not on nuget client side nor on nuget.org side.
Regarding rewriting NuGet.Server for .NET core, we have an issue to track it here: https://github.com/NuGet/NuGetGallery/issues/3390
And I see that @tomzo already started the work: https://github.com/ai-traders/liget
Closing this issue as duplicate.

What are the differences and the reason between v2 and v3 ?

V3 protocol is scalable, stable and performant.
The interaction between client and server is done by using JSON blobs that can be generated statically. Meaning, in order to perform a package restore operation there is no need to access any cloud service and server compute resources are no required. All the data the client needs is exposed in static JSON blobs, and download is made faster using CDN.
Unlike V3, V2 protocol uses nuget,.org website APIs to get information about packages and their download links.
We have recently documented V3 and added detailed instructions (with examples!) on how to consume it: https://docs.microsoft.com/en-us/nuget/api/overview

Any update about the issue? I'd like to know if the latest version has supported the V3 API?

NuGet.Server does not support V3 yet. If you're looking for servers that support V3, I'd recommend BaGet or Sleet.

We're trying to migrate our private Nuget.Server on-premise to Azure Artifacts, and apparently the package retrieval script only supports the V3 API.
https://docs.microsoft.com/en-us/azure/devops/artifacts/tutorials/migrate-packages?view=azure-devops
This is really unfortunate because now there isn't a path from a private on-premise NuGet feed into Azure Artifacts.
V3 support would be really nice, or (wishful thinking) a re-imagining of the NuGet.Server package as an ASP.NET Core package/middleware instead.

Hi @qJake, that's great feedback! Have you reached out to Azure DevOps about this suggestion?
Also, BaGet has a trick that lets you import packages from NuGet.Server. You should be able to use that to migrate to Azure Artifacts: https://loic-sharma.github.io/BaGet/tools/migrate/#steps


[HUGE WIP] New Magic

Changes

Issues (will be fixed with this PR - wip)

fix: #4125
fix: #4104
fix: #2443
fix: #3817
fix: #4036
fix: #3996
fix: #3980
fix: #3957
fix: #3718
fix: #3437
fix: #3280
fix: #3946
fix: #3915
fix: #3881
fix: #2470
fix: #3048
fix: #2089
fix: #2316
fix: #4196
Discord:

https://discord.com/channels/459365938081431553/1297775114330574869
Special characters: https://discord.com/channels/459365938081431553/1304455562536288318
Build args get parsed into environment variable section: https://discord.com/channels/459365938081431553/1304043152566648852/1304463453137797171
We need a place for ENV build time - so avialbe in build and runtime (otherwise env is only in runtime)
There should be a separate place for ARG so only availabe in build time (see discrod above why that is needed)

Hello,
Can you have a look at https://discord.com/channels/459365938081431553/1304467966582063164
Behavior does not seem expected and is related to parsing of env variables in docker-compose file.
Thank you


MSVD Weights

Hello, thanks for providing the code!
In regards to the models used for generating the results in the paper, is this uploaded anywhere that can be shared? I would be interested in the inference without running the training from scratch.

Hi @ntseng450, sorry for the delayed reply.  We had no plan to release the weights. Sorry for that.


Problem with unused library functions

My name is Hernan; with a group of colleagues we are conducting a research about unused code present in dependencies of JavaScript projects. We call this functions, UFF (Unused foreign functions). We found that in most projects there exist a great amount of UFF that are being included in the final bundle.
In the case of transform-pouch (v 1.1.3) our tools detected approximately 78 unused function in dependencies. Removing those functions, the size of transform-pouch bundled could be reduced at least 26% (All tests passed). I replaced the bundled in several projects that use transform-pouch as pouch-pid, crypto-pouch, pouch-box. I’m attaching the reduced version of your project.
pouchdb.transform-pouch(optimized).txt
I’ll be very grateful if you can answer me the following questions:
-Did you were aware of the existence of these unused functions in your projects?
-Do you think that this is a problem?
-Do you think that can be useful a tool for deal with this kind of problem?
Thanks in advance.
Cheers,

I don't know if you are familiar with 'code coverage' tools which are used in conjunction with tests to make sure all paths through the code are adequately tested, there is also a concept that certain optimizers do called 'dead code elimination'  which attempts to remove code that can probably never be run.
Modern tools tend to do this at the statement level not the function level (I.e. Remove branchs of an if statements).
Code coverage tools tend towards false positives because just because code is not run doesn't mean it will never run (I.e. The code will only run on certain platforms) while dead code elimination tends towards the opposite leaving in code it can't rule out from being run.
To circle back to your original questions

it looks like you were testing againt a bundled version of this lib, the bundle can include boilerplate or unused functions for other platforms. Though it's hard to tell based on sending us the cleaned up version telling us what you removed would be more helpful then telling us what you saved.
whether it's a problem will actually depend on what sort of tool you actually have, is it based on static analysis or on runtime data, if it's based on runtime data then the functions probably arn't unused but you just didn't run through all possible scenarios, if it's static then they likely are unnecessary but we run our library through a minifier (uglify) which has dead code elimination so will probably remove the code for us.
as for whether this is useful it depends on what exactly it does, if it's dynamic it's usefulness would depend on it being better then Istanbul which works at the expression level and gives super user friendly output showing you exactly what parts of the code are run, if it's dynamic you'd have to compete with uglyfy, the Babel minifier, and to an extent, rollupjs.

Hope that answers your questions.

Yes to add to what Calvin said, this is interesting research, but in general what's more valuable is code coverage tied to unit tests and to the existing build system. You've sent a text file of a reduced JS file and that solves the problem for the current version, but it doesn't change the build process when we need to change something...
I agree JS bloat is a problem and thank you for the info, but I don't believe this kind of tool is extremely useful unless it can be automated and unless it can be applied to users using all kinds of bundlers (Browserify/Webpack/Rollup/etc.). Thanks though!


Check UTxO HD assumption on size of values set needed when applying rules

During the design of UTxO HD we made the following assumption
No large set of values needs to be brought from disk when applying rules (slot tick or block application).

If the above assumption is wrong, then we need to redesign consensus and or ledger to work around this.
Furthermore, for future versions of UTxO HD: if a huge subset of the UTxO is required at slot ticks, then we will need to adapt our design.

While discussing https://github.com/input-output-hk/cardano-ledger/issues/3013 @TimSheard, @javierdiaz72, and I realized this assumption might not hold, so we need to check it.

Hi, guys! I think you have the wrong Javier. :) Cheers!
On Thu, Oct 27, 2022 at 1:31 PM Damian Nadales @.***>
wrote:

While discussing #3013
https://github.com/input-output-hk/cardano-ledger/issues/3013 @TimSheard
https://github.com/TimSheard, @javierdiaz72
https://github.com/javierdiaz72, and I realized this assumption might
not hold, so we need to check it.
—
Reply to this email directly, view it on GitHub
https://github.com/input-output-hk/cardano-ledger/issues/3105#issuecomment-1293785270,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHYDOT2QSL2JF7APXJTPXX3WFKU4LANCNFSM6AAAAAARQHW5V4
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hi, guys! I think you have the wrong Javier. :) Cheers!
This was bound to happen at some point. You have no idea how many times I had to delete what I wrongly autocomplete. Sorry about that (maybe you want to formalize the assumption in Isabelle anyway :stuck_out_tongue: )

@dnadales for just the adaptation of moving the UTxO on disk, that assumption is correct. The size of the UTxO that the ledger will need is bounded by:

how many transaction inputs you can fit into a transaction
how many transaction you can fit into a block

Only the UTXO rule uses the UTxOs, with the exception of the Shelley to Allegra translation.
Now, when we start moving other data structures to disk, such as the stake credentials and the stake distribution, we will need to reconsider!

@JaredCorduan I think this answer is enough for UTxO-HD v0.1 as we are only moving the UTxO set to disk. I think we can re-scope this issue now for future work when we move something else to the disk. Thanks!!


Debug make tests/specs/erc20/hkg/allowance-spec.k.prove TEST_SYMBOLIC_BACKEND=haskell

The prover hangs after step 1233. The config after step 1233 is attached. Everett's hint is to look at the SLOAD instruction being executed as well as the <storage> cell.
output-1233.txt

We likely need to convince the prover that this term (the key present in <storage> cell):
#hashedLocation ( "Solidity" , keccakIntList ( OWNER  2  .IntList ) , SPENDER  .IntList )

and this term (the argument to SLOAD):
keccak ( #buf ( 32 , SPENDER ) ++ #buf ( 32 , keccak ( #buf ( 32 , OWNER ) ++ b"\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02" ) ) )

are the same. Conveniently, they actually are the same! So we just need to add lemmas to convince the prover, or adjust how we're applying lemmas.
You can start by making a functional proof file for tests/specs/erc20/ at tests/specs/erc20/functional-spec.k. Just copy-paste the one from benchmarks into place, and strip everything out you don't need. Make sure to add an entry specifying the KPROVE_MODULE in the Makefile for this file too.
The thing you want to prove is that these two things are equal, so just have one in runLemma on one side of the proof, and the other in doneLemma on the other side.
Then add your lemmas to tests/specs/verification.k until that functional proof passes, and re-try the overall proof you're working on.

I'm still confused why lemmas are missing, since according to the rules in hashed-locations.md I'm able to do the following rewrites by hand. I think they should happen in this order too, based on my understanding of [function].
// term in the key of the <storage> cell
// #hashedLocation("Solidity", keccakIntList(OWNER 2 .IntList), SPENDER .IntList)
// #hashedLocation("Solidity", keccak(intList2ByteArray(OWNER 2 .Intlist)), SPENDER .IntList)
// #hashedLocation("Solidity", keccak(#buf(32, OWNER) ++ #buf(32, 2)), SPENDER .IntList)
// #hashedLocation("Solidity", keccakIntList(SPENDER keccak(#buf(32, OWNER) ++ #buf(32, 2))), .IntList)
// #hashedLocation("Solidity", keccak(#buf(32, SPENDER) ++ #buf(32, keccak(#buf(32, OWNER) ++ #buf(32, 2)))), .IntList)
// keccak(#buf(32, SPENDER) ++ #buf(32, keccak(#buf(32, OWNER) ++ #buf(32, 2))))
// index of the SLOAD

Copying the rules for reducing #hashedLocation to a keccak application and marking them as [simplification] does indeed get the proof to pass (running in ~30 minutes in the container).


feat: scanner template

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #471
Special notes for your reviewer:

Codecov Report

Merging #507 (e592493) into main (febf48b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #507   +/-   ##
=======================================
  Coverage   14.29%   14.29%
=======================================
  Files          13       13
  Lines        1567     1567
=======================================
  Hits          224      224
  Misses       1315     1315
  Partials       28       28

Flag
Coverage Δ

unittests
14.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

LGTM, merge when checks pass


[3.2] Use path instead classname to prevent errors for exported visual shaders

Fix #39569

Thanks!


stream.Err always nil

stream := c.client.Chat.Completions.NewStreaming(ctx, params) if err := stream.Err(); err != nil { 		panic(err) }
When I debug the code in the packages/ssestream/streaming.go  func (s *eventStreamDecoder) Next() bool,
I get the error message.it just don't return.

Hmm, thanks for raising, I'll try to take a look. Would you mind sharing a bit more of your code?

Hmm, thanks for raising, I'll try to take a look. Would you mind sharing a bit more of your code?

"I can't find the code; I just remember about the tool's function call. When I forget to post the function call parameter, it returns nil, but it has a fatal error.


getFunctionalInterfaceMethod() fails to recognize method override

On the latest master (f31a2f7). Here's a patch to produce a failing test:
diff --git a/nullaway/src/test/java/com/uber/nullaway/NullAwayTest.java b/nullaway/src/test/java/com/uber/nullaway/NullAwayTest.java
index e318ff0..1863775 100644
--- a/nullaway/src/test/java/com/uber/nullaway/NullAwayTest.java
+++ b/nullaway/src/test/java/com/uber/nullaway/NullAwayTest.java
@@ -139,4 +139,9 @@ public class NullAwayTest {
     public void functionalMethodSuperInterface() {
         compilationHelper.addSourceFile("NullAwaySuperFunctionalInterface.java").doTest();
     }
+
+    @Test
+    public void functionalMethodOverrideSuperInterface() {
+        compilationHelper.addSourceFile("NullAwayOverrideFunctionalInterfaces.java").doTest();
+    }
 }
diff --git a/nullaway/src/test/resources/com/uber/nullaway/testdata/NullAwayOverrideFunctionalInterfaces.java b/nullaway/src/test/resources/com/uber/nullaway/testdata/NullAwayOverrideFunctionalInterfaces.java
index e69de29..9383bef 100644
--- a/nullaway/src/test/resources/com/uber/nullaway/testdata/NullAwayOverrideFunctionalInterfaces.java
+++ b/nullaway/src/test/resources/com/uber/nullaway/testdata/NullAwayOverrideFunctionalInterfaces.java
@@ -0,0 +1,27 @@
+package com.uber.nullaway.testdata;
+
+import java.util.function.ToIntFunction;
+
+public class NullAwayOverrideFunctionalInterfaces {
+
+    public void test() {
+        call(str -> 42);
+    }
+
+    private int call(ObjToInt<String> f) {
+        return f.call("The answer to life the universe and everything");
+    }
+
+    @FunctionalInterface
+    private static interface ObjToInt<T> extends ObjToIntE<T, RuntimeException>, ToIntFunction<T> {
+        @Override
+        default int applyAsInt(T t) {
+            return call(t);
+        }
+    }
+
+    @FunctionalInterface
+    private static interface ObjToIntE<T, E extends Exception> {
+        int call(T t) throws E;
+    }
+}

Here's the relevant portion of the error stacktrace:
java.lang.AssertionError: An unhandled exception was thrown by the Error Prone static analysis plugin.
     Please report this at https://github.com/google/error-prone/issues/new and include the following:

     error-prone version: 2.1.1
     Stack Trace:
     java.lang.RuntimeException: already found an answer! call(T) applyAsInt(T) applyAsInt(T)
  	at com.uber.nullaway.NullabilityUtil.getFunctionalInterfaceMethod(NullabilityUtil.java:87)
  	at com.uber.nullaway.NullAway.matchLambdaExpression(NullAway.java:422)

Ah, I see the issue. Handling default methods correctly is going to be a bit tricky here, since inheriting interfaces can both "redeclare" them, making them abstract once again; or redefine them, making abstract methods into default methods. To handle this properly, we need to know which is the "effective" version of the method. @msridhar Do we have any guarantees that types.closure will return the types in any particular order? If so, we could keep track of which method definitions we have seen and ignore all but the first/nearest definition seen. If not, then it is a bit more involved.

So reading the source of closure I'm pretty sure it returns subtypes before supertypes.  So probably we can fix our code by just returning the first valid result it finds, rather than always going through all supertypes and failing on overrides.

That sounds good to me, assuming two things: 1) That we can rely on that implementation not changing, 2) That the java compiler itself guarantees each functional interface has a single abstract method. Can put up a PR if we are reasonably certain of those :)

Thanks for the report.  I'll try to cut a new release soon

Thank you!
Also, I'll formally license the test code I provided here under the same terms that Uber has licensed the rest of NullAway:

Copyright (c) 2017 Brandon Mintern
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.
 IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.


Encapsulate and unify google_maps_key usage

Make sure there is only one place that gets this key, and standardize its name across the project. It's usages are now easily grepped.
BTW: is it okay to log the key? I thought it is a secret.

@elazarg good catch. Not OK to log the key. It's secret - please delete this part of the log

@elazarg I can't seem to find where the code logs the key. If it does, could you please remove that log?
I'll merge after this issue is resolved.

@Mano3 done.


Update Install-AD-FS-Delegated-Admin.md

Approved in CSS content triage as Content Idea Request 83375:Update: Add note with older PS value to Creating an AD FS Farm without domain admin privileges. Reviewed by Ryan Ries.

Thanks, Jarrett!


Verify that support only gets the instructions and not the wrapper

Per https://github.com/will-in-wi/letsencrypt-webfaction/issues/4#issuecomment-200919136

This was the email Webfaction received. Probably should only send them the last part?

LetsEncrypt Webfaction has generated a new certificate for domain.com and www.domain.com. The certificates have been placed in /home/domain/le_certs/domain.com/20160324162750. WebFaction support has been contacted with the following message:
Please apply the new certificate in /home/domain/le_certs/domain.com/20160324162750 to domain.com and www.domain.com. Thanks!

Double check that I did this correctly, and if I did, clarify to the user what was indeed sent to support.

This was indeed a bug. It is fixed on master.


Map viewer CRS 4326 default for longitude latitude is inverted

When using CRS 4326 the rendering is inverting longtitude and latitude and treating geometry fields as latitude longitude. This default should be reverted to match the CRS selction dialog

Also related, the flip latitude/longitude coordinates option is not preserved requiring this option to be selected everytime a query or even new geometry column is selected in the result set.

verified


3.0.3 Mac Don't start

Mac system version 10.15.6 , Dont' start , Don't use。

We can't help you because you have not filled in a proper bug template.
First read this:
https://docs.rocket.chat/contributors/contributing/reporting-issues
Then use this as a template:
https://github.com/RocketChat/Rocket.Chat.Electron/issues/new?template=ISSUE_TEMPLATE.md
Thanks!


garden installs mapview to python2.7 instead of 3.6 OSx Sierra

Hi!
I'm on mac OSx Sierra, trying to install map view with garden, but it automatically installs it with python 2.7 and I want it with 3.6

Install/Invoke garden with python 3.6 then :)


Remove validation for instance type

https://github.com/perfectsense/gyro-aws-provider/blob/a4d1fcf80dfad1137a0a36adbf4523e81ba02a57/src/main/java/gyro/aws/ec2/InstanceResource.java#L806-L809

Duplicate of #498


Bugfix/calico node failure

Issue #, if available:
Description of changes: Calico node daemonset fails with OOM.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

may also apply to the terraform version (although could not find source for calico addon)

/do-e2e-tests

/do-e2e-tests


[Feature] Support remote cluster index on FGAC domains

What is the bug?
We can't create detector on remote cluster indices from ES7.9 as we add FGAC for AD plugin from ES7.9
How can one reproduce the bug?
Steps to reproduce the behavior:

Set up two security-enabled clusters on AWS OpenSearch Service
Configure remote cluster
Create detector on remote cluster index
It will fail, sample response

{
  "error" : {
    "root_cause" : [
      {
        "type" : "security_exception",
        "reason" : "No user found for indices:data/read/search"
      }
    ],
    "type" : "security_exception",
    "reason" : "No user found for indices:data/read/search"
  },
  "status" : 500
}

What is the expected behavior?
Should be able to create anomaly detector on remote cluster index and can run it correctly.
What is your host/environment?

Version: ES7.9 +
Plugins: anomaly-detection

Do you have any screenshots?
No
Do you have any additional context?
No

We have some basic support (by asking cx to put fields manually) in UX: https://github.com/opendistro-for-elasticsearch/anomaly-detection-kibana-plugin/pull/244
For FGAC domains, AD won't work even if cross cluster search works.
A few customers have asked about it.

remote index is now fully supported on FGAC and non FGAC domains from OS 2.17 and on. https://github.com/opensearch-project/anomaly-detection/pull/1290


Graph.forEdges() iterator documentation

Referring to this question on stackoverflow, I would suggest to add some simple example for the usage of the forEdges iterator, because the documentation doesn't really explain a lot and no example can be found anywhere. This iterator may actually be very useful, maybe with some further explanation in the Jupyter Notebook guide!

Kolja, can you please do that? We should indeed have more examples in notebooks on how to use specific features/algorithms. One step at a time but steadily...

Indeed! By the way, until that moment there's a good answer in that stackoverflow question which also explains what a GraphEvent is and how to use it. It's very useful and I think it's a good starting point to build some examples. Thanks for your work!

@eug93's SO answer resolves this question.


Unable to find transform matching filterSchema on serverless

First of all, amazing project! I literally had the same idea a while back, but didn't have the bandwidth to actually bring it to fruition. The plan is to implement Magento 2's GraphQL + Magento 2 REST API (for graphql feature gaps) + GraphCMS
I'm trying to run graphql-mesh in a serverless environment, but it seems to be having trouble finding the filter packages (as they are resolved at runtime?)
2020-05-12T19:32:53.523Z	undefined	ERROR	Unhandled Promise Rejection 	{"errorType":"Runtime.UnhandledPromiseRejection","errorMessage":"Error: Unable to find transform matching filterSchema","reason":{"errorType":"Error","errorMessage":"Unable to find transform matching filterSchema","stack":["Error: Unable to find transform matching filterSchema","    at getPackage (/var/task/node_modules/@graphql-mesh/runtime/index.cjs.js:94:11)","    at processTicksAndRejections (internal/process/task_queues.js:97:5)"]},"promise":{},"stack":["Runtime.UnhandledPromiseRejection: Error: Unable to find transform matching filterSchema","    at process.<anonymous> (/var/runtime/index.js:35:15)","    at process.emit (events.js:323:22)","    at processPromiseRejections (internal/process/promises.js:209:33)","    at processTicksAndRejections (internal/process/task_queues.js:98:32)"]}
2020-05-12T19:32:53.541Z	undefined	ERROR	Unhandled rejection: Error: Unable to find transform matching filterSchema
    at getPackage (/var/task/node_modules/@graphql-mesh/runtime/index.cjs.js:94:11)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
RequestId: 184cb927-2697-42e6-ba05-d34fde82cece Error: Runtime exited with error: exit status 1
Runtime.ExitError

Is there a hint how get it to work (maybe I'm not finding the correct docs)?

Alright worked around it, but it might be something for the docs somewhere.
Add your transforms and handlers that are loaded dynamically at the top of the file. This will now be included in the serverless build.
import '@graphql-mesh/transform-filter-schema'
import '@graphql-mesh/graphql'

A more complete example to get it to work:
// All imports that are going to be used.
import '@graphql-mesh/transform-filter-schema'
import '@graphql-mesh/graphql'
import { getMesh, processConfig } from '@graphql-mesh/runtime'

// Import the meshrc as a static json import instead of using 'fs'.
import meshrc from '../.meshrc.json'

// Copied method to replace env variables of the JSON
function injectEnv<T extends object>(json: T): T {
  let content = JSON.stringify(json)
  if (typeof process !== 'undefined' && 'env' in process) {
    content = content.replace(/\$\{(.*?)\}/g, (_, variable) => {
      let varName = variable
      let defaultValue = ''

      if (variable.includes(':')) {
        const spl = variable.split(':')
        varName = spl.shift()
        defaultValue = spl.join(':')
      }

      return process.env[varName] || defaultValue
    })
  }
  return JSON.parse(content)
}

// Create the endpoint
export const mesh = (async () => getMesh(await processConfig(injectEnv(meshrc))))()

const meshSchema = mesh.then(({ schema }) => schema)

export default meshSchema

Now I can use the meshSchema in my ApolloServer and use it with graphql-code-gen:
overwrite: true
require:
  - ts-node/register/transpile-only
  - tsconfig-paths/register
schema: ./node/meshSchema.ts

I think you already solved the issue. So closing this :)

We did! Thanks for reading :)

We did! Thanks for reading :)


manifest: update hal_gigadevice

Update hal_gigadevice to sync repository.
Signed-off-by: Gerson Fernando Budke<EMAIL_ADDRESS>

Update hash since https://github.com/zephyrproject-rtos/hal_gigadevice/pull/8 got merge.
Added myself as maintainer.


Add tooltip and tooltipML

Please add "ToolTip" and "Tooltip ML" fields properties. As I understand they are mandatory for a Dynamics365 Business edition.

We do support TooltipML on fields as before. The regular Tooltip is not needed anymore.
pageextension 70770077 CustomerListExt extends "Customer Card"
{
    layout
    {
        addafter(Blocked)
        {
            field(test; 'Anything')
            {
                ToolTipML = ENU = 'Hello';
            }
        }
    }
}


some weird issue that i get when executing the drivers

i dont understand this

This is an indication that the DMA channel is occupied
You can see the corresponding unused DMA channels in the error message, as shown below

Add the specified DMA channel to your cmake instruction as follows
-DDMA_RX_CHANNEL=0 -DDMA_TX_CHANNEL=5

This also doesnt seem to work it seems like when i connect rx to 0 it will automatically go to 1

close vc4-kms-v3d， and open hdmi hotplug
Please see the prompt.

i did in fact open hdmi hotplug but i was not aware of vc4-kms-v3d