xyzDialog.cs; Intercepting Save-and-close-button with Confirm dialog; save entity when clicking on yes

Hi JaiQ,
again me, John Ranger :-)
I have a "sensitive" Dialog - the Client wiping Dialog - where I really want to enforce it on the guys to be really sure that they want to wipe a specific Client.
For this, I have intercepted the save-and-Close-button in the protected override List GetToolbarButtons() method like this:

 protected override List<ToolButton> GetToolbarButtons()
        {
            var buttons = base.GetToolbarButtons();

            // *** Only get the save-and-close button
            var newButtons = new List<ToolButton>();
            newButtons.Add(buttons[0]);

            // *** Ask for wiping confirmation ***
            newButtons.First(x => x.CssClass == "save-and-close-button").OnClick = delegate
            {
                Q.Confirm(new LocalText("Dialogs.Wiping.ClientWiping.WipingConfirmation").ToLocaleString(), delegate
                        {
                            // *** Save Entity here ***
                            //this.Save();

                            DialogClose();
                        }
                        , new ConfirmOptions { DialogClass = "s-MessageDialog s-WarningDialog", HtmlEncode = false });

            };

            return newButtons;

        }

With the current implementation of mine, the record does not get updated because there is missing the this.Save(???) line.
As I could not figure it out how to parameterize this function (even with looking into goto definition), I allow myself to ask you how to parameterize it so that the Standard server-side calls are done.
Thanks again and
With Kind regards,
John

What about calling
Save(response => this.DialogClose());
Does this cause a problem?

Hi JaiQ,
no, that works perfectly, thank you very much.
For the benefit of other Readers, here the whole code block if you Need to get confirmation on clicking the save-and-Close button. Please note that I remove here all Buttons in the toolbar and only take the first one (the save-and-Close-button):
protected override List<ToolButton> GetToolbarButtons()
        {
            var buttons = base.GetToolbarButtons();

            // *** Only get the save-and-close button
            var newButtons = new List<ToolButton>();
            newButtons.Add(buttons[0]);

            // *** Ask for wiping confirmation ***
            newButtons.First(x => x.CssClass == "save-and-close-button").OnClick = delegate
            {
                Q.Confirm(new LocalText("Dialogs.Wiping.ClientWiping.WipingConfirmation").ToLocaleString(), delegate
                        {
                            // *** Save Entity here ***
                            Save(response => this.DialogClose());

                        }
                        , new ConfirmOptions { DialogClass = "s-MessageDialog s-WarningDialog", HtmlEncode = false });

            };

            return newButtons;

        }

I just didn't know this Syntax and I could not reverse-engineer it from the whole solution.
Please remember: I am just an Admin with some dev enthusiasm ;-)
With Kind regards,
John.


Current version?

Hello,
I am confused about the current version of this project. It seems like the current version is 3.1.1, but the code hosted here at github is referencing 3.0.6 as the latest version. I would like to fork the project, but cannot find the latest version of the code (which is different than what is hosted here).
What I am trying to do is add an export to the DefaultPreview component. When using this library with the "Info" addon, the propTables in addon show ""DefaultPreview" Component No propTypes defined!" as well as ""ReadmeContainer" Component No propTypes defined!". As a fix, I am importing ReadmeContainer into config.js and using the option for "propTablesExclude" from the Info addon, but I cannot import "DefaultPreview", as it is not exported in the code (and I cannot find any reference to it in the currently hosted version).
Thanks!

Current master is not released.
Will release in next few days.
Since three is vue support and a lot of new feature I should update docs but have not enough time

Thank you for the update!


add smooth constant in scheduler code

Hello.
I found a error in LinearWarmupAndCosineAnneal in utils/utils.py
The problem is divided by zero, so I add a smooth constant.
Thank you!

Hi @Sangh0,
Thanks for the PR and pointing out a potential problem! I think the proposed solution shouldn't affect the training dynamic, so we can keep it. I guess this can only arise when unexpected behavior happens, i.e., when  self.T_max < le, so it would be good to add a warning.


feat: support vercel

Codecov Report

Merging #165 (bf5a1b8) into master (7f9c253) will decrease coverage by 0.06%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
- Coverage   81.22%   81.15%   -0.07%
==========================================
  Files          35       35
  Lines        2956     2967      +11
  Branches      827      831       +4
==========================================
+ Hits         2401     2408       +7
- Misses        499      503       +4
  Partials       56       56

Impacted Files
Coverage Δ

packages/cli-plugin-package/src/index.ts
79.48% <33.33%> (-0.28%)
:arrow_down:

packages/serverless-spec-builder/src/wrapper.ts
87.50% <77.77%> (-1.05%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f9c253...bf5a1b8. Read the comment docs.


404 on boundary dependencies

I am getting a 404 on both the boundary dependencies from http://nuage.yohanboniface.me when running make import_boundary. Is there another source for these?

Should be fixed, sorry!


Support for Tiled .tmx infinite maps

Discussed in https://github.com/AlmasB/FXGL/discussions/1262

Originally posted by tobithe1st April  4, 2023
Hey,
Im just getting started with FXGL and already have problems getting the TileMap set up.
    @Override
    protected void initGame(){
        FXGL.getGameWorld().addEntityFactory(new KeplerTownFactory());

        FXGL.setLevelFromMap("test.tmx");
    }

    public static void main(String[] args) {
        launch(args);
    }
}

After starting the application I get the following exception:

I already tried all possible directories - nothing. When choosing a json file, the AssetLoader finds it ind resources/assets/json , but is also throwing an exception:

Map was created with Tiled.

For reference purposes: <chunk> in https://doc.mapeditor.org/en/stable/reference/tmx-map-format/


Add Release Announcements directory

Signed-off-by: TomSweeneyRedHat<EMAIL_ADDRESS>Creates a release-announcements directory under the docs directory and populates it with the release announcements that I could dredge up.  It includes the latest v1.3 RA which @rhatdan approved in a google doc.
Would like  to push this through ASAP so we can send out notes via twitter and such.

@nalind @umohnani8 PTAL

Happy green test buttons.

@rh-atomic-bot r+


NETWORK_TYPE=main.ton.dev  error

TON OS App server，
NETWORK_TYPE=main.ton.dev
When ton-node does not synchronize data, it prompts the above error
1616735461.529732438 TRACE [ton_node::external_db::kafka_producer]<PHONE_NUMBER>49472: Creating kafka producer (topic: blocks)...
1616735461.532777063 TRACE [ton_node::external_db::kafka_producer]<PHONE_NUMBER>49472: Kafka producer (topic: ) is DISABLED
1616735461.532810242 TRACE [ton_node::external_db::kafka_producer]<PHONE_NUMBER>49472: Creating kafka producer (topic: messages)...
1616735461.533083563 TRACE [ton_node::external_db::kafka_producer]<PHONE_NUMBER>49472: Creating kafka producer (topic: transactions)...
1616735461.533408231 TRACE [ton_node::external_db::kafka_producer]<PHONE_NUMBER>49472: Creating kafka producer (topic: accounts)...
1616735461.533640828 TRACE [ton_node::external_db::kafka_producer]<PHONE_NUMBER>49472: Creating kafka producer (topic: blocks_signatures)...
1616735461.534159416 INFO [ton_node::engine]<PHONE_NUMBER>49472: Engine::run
1616735461.534191643 INFO [ton_node::engine]<PHONE_NUMBER>49472: Creating engine...
1616735462.035297289 ERROR [ton_node]<PHONE_NUMBER>49472: Can't start node's Engine: Error("invalid type: integer 404, expected struct TonNodeGlobalConfigJson", line: 1, column: 4)

Fixed, thanks for reporting.
Please verify.


New image task - add option to add "Tags" and "Data Attributes" to created collection objects

In the New Image task I want to be able to add both "Tags" and "Data Attributes" to newly created collection objects.
Use case:
I want to add all my Lepidoptera project images and tag them with "LepProject2019" or data attribute: "Member of project" -> "object" -> "My project name"

Done


Attributing block I/O energy

Is your feature request related to a problem? Please describe.
Currently the attribution to Pods is based the Pods CPU/memory activities. The processes in the Pods could have disk I/O activities that are handled by interrupt handlers, we should attribute energy consumed by the handlers properly to the Pods that initiate them.
Describe the solution you'd like
The I/O stats are collected by cgroupfs. The interrupt handlers are currently classified as system processes.
In the first implementation, we can do the following flow

get the kworker process(es) that handle(s) the disk I/Os, quantify the processes' energy consumption.
from the process's cgroup disk I/O stat, find the block I/O stats on each block device
evenly distribute the kworker's energy to all processes based on their I/O stats
create another metrics for the pods called Pod disk I/O energy

We can quantify other I/O energy in similar way, e.g. network I/O.

Per kernel source here, the block I/O worker threads name regex is ^[kworker/.*kblockd]$, e.g. [kworker/93:1H-kblockd]

Thanks @rootfs for writing the summary of the idea here!

https://github.com/orgs/sustainable-computing-io/teams/kepler-core


AttributeErrors in Ellipses

AttributeErrors arise in the random generation of color, and in the math.radians part of my rectangle

Had to remove the from pygame import *


Solve conflict for multi

I'm using react-router v4 on some data analytics project, I use <Redirect /> to add some default value of query parameters to location, wish keeping data unchanged after refresh and/or copy&paste link in another browser.
This is how I did this:
export default function QueryDatePicker(props) {
  const { history, location, name } = props;
  const query = qs.parse(location.search);
  const value = query[name];
  if (!value) {
    // Add [name] query parameters.
    return (
      <Redirect to={{
        ...location,
        search: qs.stringify({
          ...query,
          [name]: moment().startOf('day').subtract(1, 'days').valueOf(),
        }),
      }}/>
    )
  }

  return (
    <DatePicker onChange={v => changeQuery(history, location, name, v)} value={moment(+value)} />
  )
}

I also have QueryRadioGroup , and use them like this:
export default function SomePage(props){
  const { location } = props;
  const query = qs.parse(location.search);
  const dataReady = !!query.date && !!query.inDays;
  const url = `/api/task1?from=${query.date}&to=${query.date}&inDays=${query.inDays}`;

  return (
    <div>
      <QueryDatePicker {...props} />
      <QueryRadioGroup {...props} name="type" values={VALID_TYPES}/>

      { dataReady && <Fetch url={url}>
        <SomeComponent />
      </Fetch> }
    </div>
  );
}

Each QueryXXX component will return a Redirect to add a query paremeter on location if missing.
The problem comes: each <Redirect /> will be mounted only once, after many history.replace() calls, only the latest one will effect. There's no chance for other Redirect to perform again.
Add a  componentWillReceiveProps method to Redirect class which performs again will solve this problem, but is this dangerous? Any better idea for this case?

Duplicate of #5162


Fix grammar

This is to improve the grammar coverage.

shape definition for "box" and "rotbox" are modified to allow multiple sizes,

box(18:13:27.558,+31:22:30.76,13.32",6.66",19.98",9.99",45.2623)

shape definition for  "ruler" and "compass" are added.

coordinate command for "wcs" and "wcs[a-z]" are added.

With this, coverage from https://github.com/astropy/regions/blob/master/dev/regions_pyregion_comparison.py
is improved. In fact, only warning issued is for the comment only region. And I believe it gives 100% coverage if we change how the number of regions are counted (https://github.com/astropy/regions/pull/126)

@leejjoon - See https://travis-ci.org/astropy/pyregion/jobs/230114088#L592

related https://github.com/astropy/regions/commit/6cebde74f1bec55093ffea473bf356fc3e7e0e28


[8.x] Rename setUp to setup in ParallelTesting classes

As suggested by @GrahamCampbell in https://github.com/laravel/framework/pull/36383#issuecomment-785733395
Renames all instances of setUp to setup in the ParallelTesting classes to make the code consistent.
This PR is an alternative to https://github.com/laravel/framework/pull/36383, so feel free to choose one of the solutions and close the other one.
If this PR will be merged, I will also prepare a PR for the docs.

NB My suggestion was on the grounds that we should either use setup everywhere or setUp, but not a mixture. It doesn't really matter that much anyway, since PHP method calls are not case sensitive. Any IDE/tools which treats them like that has a bug.

I agree with that. That's why I submitted a PR to make things consistent. And whether we change it in the docblock, or the code, doesn't matter to me.

We are using "setUp" everywhere, just like PHPUnit uses "setUp" too.

Closing this one in favor of the other. Thanks


Add dropdown menus

added: sass lint and autoprefixer
changed: height of mobile view is not 100vh but only required height
changed: introduced files for themes, etc.

Thanks for the PR! :) The dropdown option, file separation, linting and autoprefixer was inarguably needed and I definitely want them to be merged, however there are some changes that I don't want to add in the way you did:

By changing the opened navbar height from 100vh to 100% we lose the smooth opening transition which I think is important from the UX perspective
Putting the generated *.css files into a separate folder is a good idea but would made CDN inaccessible for some days (jsdelivr requires a config file and it takes some day to modify them). I think a good solution would be to have them in both place and after the jsdelivr files are changed I could simply delete de old ones

If you could change these things that would be awesome! 👍

Yep indeed! What would you prefer: the transition with 100% or with 100vh?
I've also added an npmignore which should help with the new issue ;-)

done - have a look. I'm not sure, but I guess the issue with the menu remaining open is fixed as well


Fix sender prefix in help dialog

The sender prefix is sender:, not email:.

I'm not certain this is the correct spot to make the change, so let me know.

This bug was fixed a while back.


Fix bug with ServiceStore embedded data editor and SchemSet editor

Summary

[x]  Improve User experience while hovering over the list of ServiceStubMappings/ Schemas
[x] Fix bug with the context-menu for deleting ServiceStubMapping/Schema

How did you test this change?

[ ] Test(s) added
[x] Manual testing (please provide screenshots/recordings)
[ ] No testing (please provide an explanation)

https://user-images.githubusercontent.com/87973126/176713880-e2ff3115-28d6-4fb7-8dd9-0b0f7bd80569.mp4

Can you also show a video of before, I don't quite get what the bug is about


Increase the verbosity level of memquota to reduce log spam

Release note:

None

This change is

/lgtm

/approve

We do not, it's on my long list of things to do (rationalize all of our logging, and come up with some standards). But today we default to v=4 and those log messages are incredibly uninteresting.

In my mind, 0-2 = normal, 3-4 = debug, 5+ = verbose.

@ZackButcher: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/mixer-e2e-smoketest.sh
06472ece77955dcf116a734b66cf18f08cf32871
link
/test mixer-e2e-smoketest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest
Lets roll the dice...

we should just force this in. let's forgo all pretext about this impacting e2e's here. every new PR that has been locally tested has felt this pain and has a bit to fix it:
@mandarjog ^^^

@ZackButcher: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/mixer-e2e-smoketest.sh
3d1091d32f173b813d6b601df0d5f179a44246c2
link
/test mixer-e2e-smoketest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Fix some 16- and 8-bit behavior in x64 backend related to rotates.

Uncovered by @bjorn3 (thanks!): 8- and 16-bit rotates were not working
properly in recent versions of Cranelift with part of the lowering
migrated to ISLE.
This PR fixes a few issues:

8- and 16-bit rotate-left needs to mask a constant amount, if any,
because we use a 32-bit rotate instruction and so don't get the
appropriate shift-amount masking for free from x86 semantics.

operand_size_from_type was incorrect: it only handled 32- and 64-bit
types and silently returned OperandSize::Size32 for everything else.
Now uses the OperandSize::from_ty(ty) helper as the pre-ISLE code
did.

Our test coverage for narrow value types is not great; this PR adds some
runtests for rotl/rotr but more would always be better!

I can confirm this fixes rotate in cg_clif.


feat: add two container icons

Added two new icons number 2307 (roll container) and 2308 (collection container)

Preview environments are getting posted here, as soon as they are ready!


could I use lrange with pipline?

hi,dear
when I run the down codes,I got the wrong thing,
>>> redis_obj=get_redis()
>>> with redis_obj.pipeline() as pipeline2:
...     key_feat=pipeline2.lrange('kdjdjo',0,100)
...
>>> key_feat
ClusterPipeline

So why is the ClusterPipeline ? it should be a list in fact
could you pls help me ?

@ucasiggcas This section is for reporting issues and not general questions or help. Please reopen this in the Discussion tag that you will find to the right of the Pull Requests tab.

@ucasiggcas This section is for reporting issues and not general questions or help. Please reopen this in the Discussion tag that you will find to the right of the Pull Requests tab.


Next.JS Monorepo Guide

A page designed to help streamline the process of connecting AdonisJS with a NextJS Frontend using Tuyau in a workspace environment.
Additional:

Adding a ./.adonisjs/index.ts file, and reference the adonisrc.ts file there, we'd be able to access type information there, instead of in the frontend files where we import the API schema, this also allows us to reference other types which we gonna need in one place. ( eg: creating a custom vine rule and declaring it. )

Heyy @Julien-R44
Rather then putting a monorepo inside a monorepo by creating a ./examples/nextjs wouldn't be better to create a separate repository like you have here.

Thanks a lot for the PR!  The docs look clear like that
Creating a separate repository sounds good for me. You could probably host it under your account ? and we'll reference it in the documentation just like that
About the .adonisjs/index.ts file: I’m thinking it might ideally be auto-generated. Then, people could add the missing  as they develop. I’ll think about it a bit

Creating a separate repository sounds good for me. You could probably host it under your account ? and we'll reference it in the documentation just like that

Okay :+1:

About the .adonisjs/index.ts file: I’m thinking it might ideally be auto-generated. Then, people could add the missing  as they develop. I’ll think about it a bit

Yes, it is definitely better to generate it. If you decide to do that, let me know, and I'll happily write it for you. I literally read all the code in @tuyau/core in order to write my own version of Tuyau with some improvements.

Hey !

Yes, it is definitely better to generate it. If you decide to do that, let me know, and I'll happily write it for you

Okay lets do it. Would you like to create the PR to use .adonisjs/index.ts as you suggested ? If you don't have the time, let me know and I'll take care of it.

I literally read all the code in @tuyau/core in order to write my own version of Tuyau with some improvements.

Why not bring these improvements to Tuyau isntead? 😼

Otherwise, current PR looks good to me. Let's merge it. Thanks a lot for taking the time to update the documentation and creating an example

Okay lets do it. Would you like to create the PR to use .adonisjs/index.ts as you suggested ? If you don't have the time, let me know and I'll take care of it.

No problem, I'll do it.

Why not bring these improvements to Tuyau instead? 😼

Those changes are more improvements for me because i wanted things to work in a different way and format, so i’m not sure how useful they’ll be for Tuyau in general.
But i am able to share that repo with you so you can see my changes and if you think there’s anything in there that would help, i’ll be happy to put it into Tuyau itself.

Otherwise, current PR looks good to me. Let's merge it. Thanks a lot for taking the time to update the documentation and creating an example

I'm happy to help! Let me know if I can do anything else.


fix: agreement

Agreement still isn't quite right.
Note to self: dyadic $ doco from the original dictionary might help:

https://www.jsoftware.com/help/dictionary/d210.htm

Also, looks like we broke forks at some point too (or likely they never quite worked).

Note to self: exact_chunks is what I'm looking for instead of axis_chunks_iter:
+ 533 #[test]
+ 534 fn test_TEMP_exact_chunks() {
+ 535     let a = Array::from_shape_vec(IxDyn(&[2,2,3]), (0..12).collect())$
+ 536     for i in a.exact_chunks(IxDyn(&[1,1,3])).into_iter() {
+ 537         println!("{}", i.into_shape(3).unwrap());
+ 538     }
+ 539     assert!(false);
+ 540 }

I think this PR is obsoleted by #66


Warnings - createFragmentSpecResolver

createFragmentSpecResolver: Expected prop viewer to be supplied to Relay(App), but got undefined. Pass an explicit null if this is intentional.

@davidhibbard1 Thanks for letting me know. Can you explain where this warning occurs?

Good Morning

It appears from the start - my guess is it is a routing issue because it occurs on every route selection

Gary

Sent: Saturday, August 12, 2017 at 9:11 AM
From: jkettmann<EMAIL_ADDRESS>To: jkettmann/relay-authentication<EMAIL_ADDRESS>Cc: davidhibbard1<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [jkettmann/relay-authentication] Warnings - createFragmentSpecResolver (#12)
@davidhibbard1 Thanks for letting me know. Can you explain where this warning occurs?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Update to 0.21.2

Codecov Report
Base: 68.71% // Head: 68.71% // No change to project coverage :thumbsup:

Coverage data is based on head (4ac1327) compared to base (e3408cd).
 Consider uploading reports for the commit b2bf8c9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #476   +/-   ##
=======================================
  Coverage   68.71%   68.71%
=======================================
  Files          27       27
  Lines        1448     1448
=======================================
  Hits          995      995
  Misses        453      453

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Simple Injector - Injecting IDbContextScopeFactory

I'm trying to inject a IDbContextScopeFactory object using Simple Injector but I'm always getting the following error:
Additional information: The configuration is invalid. Creating the instance for type IDbContextScopeFactory failed. The constructor of type DbContextScopeFactory contains the parameter with name 'dbContextFactory' and type IDbContextFactory that is not registered. Please ensure IDbContextFactory is registered, or change the constructor of DbContextScopeFactory.
My problem is that I dont see an implementation of IDbContextFactory  anywhere so I'm a little lost on how to resolve this situation. Any help is appreciated

IDbContextFactory is an interface that comes with the Entity Framework itself. With that said, I don't know where the default implementation is, or how to create one. Maybe someone else can pitch in.

Apparently, providing an object that implements IDbContextFactory is completely optional.
public DbContextScopeFactory(IDbContextFactory dbContextFactory = null)
{
    _dbContextFactory = dbContextFactory;
}

But as you discovered, it seems that SimpleInjector does not support constructors with defaulted parameters (in this case the default is null).
You could write your own implementation and register it in your container. The default implementation can be found here:
https://github.com/mehdime/DbContextScope/blob/master/Mehdime.Entity/Implementations/DbContextCollection.cs#L64-L68
@mehdime you could improve support for dependency injection by splitting the DbContextCollection constructor into an overload with and without parameters.
// default ctor for improved support for dependency injection containers that don't support default parameters
public DbContextScopeFactory()
    : this(null)
{
}

public DbContextScopeFactory(IDbContextFactory dbContextFactory = null)
{
    _dbContextFactory = dbContextFactory;
}

With that default implementation, I can now inject without any problems.
Thank you for your help!

@wheeeels, @StevenLiekens
I am using SimpleInjector to, and the library allows me to manage the lifetime of an instance when registering in an Owin WebApi 2 application. In case of DbContextScope I am currently using as below
container.Register<IDbContextFactory, DefaultDbContextFactory>(Lifestyle.Scoped);
container.Register<IDbContextScopeFactory, DbContextScopeFactory>(Lifestyle.Scoped);
container.Register<IAmbientDbContextLocator, AmbientDbContextLocator>(Lifestyle.Scoped);

container.Register<IRepositoryAsync<User>, Repository<User>>(Lifestyle.Scoped);

container.Register<IUserService, UserService>(Lifestyle.Scoped);

container.Verify();

My question is "Is Lifestyle.Scoped suits for Owin WebApi 2?" There's already a thread that said Singleton would make sense. But I see that you two have been using SimpleInjector so please give me some advise. Thank you.

I don't know, sorry.

@simon-nguyen What does your Repository class look like?


--vimgrep not worked with --color just like grep  --color=auto

--vimgrep not worked with --color just like grep  --color=auto, for now, i have to
pipe output to grep --color=auto to implement same result.

What i need is just --nogroup argument, i found it, Thanks


Style updates to find an issue page

Fixed exp/beginner label colour background
Added thead element to label table
Updated issue list screenshot (old one referenced old whitebelt label)
Content tweaks as per style guide

Signed-off-by: Lynda O'Leary<EMAIL_ADDRESS>

Hello, I am a new contributor. I would like to help out on any doc issues. While familiarizing myself with the style guide and contribution guidelines, I spotted a few style issues.
I also noticed that the gh-label beginner style wasn't being applied to the labels correctly, it looks to be the way the styles and comments are being parsed.  I have fixed this in this PR.
Let me know if there's anything I need to change, thanks for your time and patience on this! :smile:

LGTM :) @moxiegirl @thaJeztah

@lyndaoleary Nice and good to see ya on the project.  Maybe wait for the @thaJeztah to comment. After that any changes, rebase/squash, and we can merge.  Thank you.

First of all, great to see you started contributing @lyndaoleary, thanks so much for that!
The changes look really good. The only comment I have is that your new screenshot is a retina screenshot, and quite large because of that. I've prepared two optimized versions of your screenshot (one losslessly optimized to reduce the file size, and one resized version), and uploaded them to WeTransfer; http://we.tl/3vVoOXXW7k, could you use one of those to prevent the repository from "ballooning"?

@moxiegirl While reading this, I realized that this documentation is no longer accurate; some time ago, the issue triaging process was updated; https://github.com/docker/docker/pull/14719/, and new labels were decided on.
However, the labels were never adjusted to the new proces after that was merged https://github.com/docker/docker/pull/14719#issuecomment-128829177
So, I think a number of things have to be done to fix this;

New labels have to be added on github and deprecated labels removed
Existing issues have to be relabeled where needed (I think this has been done before, but I don't know if there's an easy way to do this, or to automate this)
This docs has to be adjusted to match the new situation

This is beyond the scope of this PR, but I wanted to bring it up :smile:
I'm good with merging this PR now (after the optimized image was added), because it's a good improvement :+1:

@moxiegirl @SvenDowideit @thaJeztah
Thanks for all the feedback. I changed the following:

Added resized and optimized screenshot (Thanks :smile: @thaJeztah)
Removed step 3 as discussed & updated numbering
Reordered steps 5 and 6
Replaced we with The project...

@thaJeztah I read through your comments and would like to work on updating this document as per the new issue triage process :+1:

Great work! I added one "nit", but LGTM otherwise.
Thanks for offering to help after the labels are adjusted! I'll check with @moxiegirl who/when we will do the label change/migration and will let you know when that's done.
I think that with the rewrite, we should also explain finding an issue by "kind"; not all issues have an "experience" label added, and people may want to look for issues in a specific "area" to work on; browsing through issues that are "popular" (most commented on), could be a clear indicator that it's something to work on. (That's just me thinking out loud)

LGTM for me. Thanks again @lyndaoleary  @thaJeztah if you can forgo your nit given Lynda is gonna come back and update...let's merge.

it's  just a nit, so let's merge!
thanks @lyndaoleary


Internet Availability

First Of All I Am Very Gratefull That You Have Created This Masterpiece But What If I Want To Use On Internet Or I Can Say Upload This To Website So I Can Able To Watch This From Anywhere,anytime etc

Yes , absolutelyYou can,


Add carthage support

Add carthage support to add this library from carthage.

Thanks @Dalodd!
Will you push a new release with this?

Do you want to maintain this repo? I'd like to transfer it to you.😄

I'm not planning to update this library. I just wanted to use it through
Carthage.
Thanks anyway.
Eduard Bosch
On Sun, Mar 31, 2019, 16:41 Hran<EMAIL_ADDRESS>wrote:

Do you want to maintain this repo? I'd like to transfer it to you.😄
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Dalodd/Alamofire-Synchronous/pull/15#issuecomment-478347829,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADvnidpwpvFvnRTxq2YirHt0pv7ndm7Hks5vcMj8gaJpZM4cOF1V
.


Support inputValueDeprecation in introspection query

Describe the bug
The introspection query does not support any configuration and comes with some presets.
I gave it a quick look, and it seems gql.tada uses the getIntrospectionQuery method from the graphql package to fetch remote schemas (internally and when using the CLI).
getIntrospectionQuery({
    descriptions: true,
    schemaDescription: false,
    inputValueDeprecation: false,
    directiveIsRepeatable: false,
    specifiedByUrl: false,
})

As a consequence, when an API introduces a non-breaking change by tagging an input field as deprecated, this yields a TypeScript error even though the input field is still accounted for at runtime.
Would it be possible to allow configuration of the introspection query?
Reproduction
No response
gql.tada version
gql.tada v1.3.6
Validations

[X] I can confirm that this is a bug report, and not a feature request, RFC, question, or discussion, for which GitHub Discussions should be used
[X] Read the docs.
[X] Follow our Code of Conduct

This is not 100% resolved yet as GraphQLSP will need to be updated.

Thank you so much @kitten 🙌

I noticed that I forgot to actually say what we changed here 😅 Sorry!
For reference, the new schema loaders reimplement getIntrospectionQuery entirely to make them a little more maintainable and separate us from changes the graphql.js ref implementation may make. We now run a pre-introspection “support” query that checks which features the GraphQL API supports (and account for that query failing too). We then run the appropriate introspection query, pulling down the new features that some older GraphQL APIs may not support dynamically

No worries 😉 I had to dig through the code a bit to understand what was going on, but once I stumbled upon the loadIntrospection function it all started to make sense. TIL about "support" queries ✨


Fix dependencies in package.xml files

Add missing dependencies. Use conditionals to handle multiple versions
of Ignition. Add XML schema for Catkin Package Format v3.

Thank you for the PR, I am going to test it ASAP.


Only print body if there is a body

Currently reading from a request can hang forever if there is no content available (e.g. GET / HEAD / DELETE / ...).
This adds a check if any of the content headers are there to indicate that actually something can be read.
Follow-Up for

https://github.com/yegor256/takes/pull/1302

Okay that don't work, because it seems some tests write a body without any content headers (what theoretically is allowed for HTTP 1.0 on connection close)... I'll have to think a little bit more about this.


Access denied to config file after installing CLI when running netlify command

Describe the bug
I installed the netlify-cli package globally using npm install netlify-cli -g , the installation completed. After that I ran netlify command and got this error
Error: EACCES: permission denied, open '/Users/{USER_FOLDER}/Library/Preferences/netlify/config.json.2846113261' You don't have access to this file.
To Reproduce
Steps to reproduce the behavior:

Run npm install netlify-cli -g
Installation succeed
Run netlify
Gets the error about not having access to config.json file

Hi @nicholaschedid, I believe this similar to https://github.com/netlify/cli/issues/3870.
Can you please try the workaround suggested in https://github.com/netlify/cli/issues/3870#issuecomment-1018483719

Yes, I followed your comment and solved. Thank you so much

Hi, for future reference instead of installing the package with NPM try installation with homebrew. This will solve the access issues from installing as root user.

Hmmm Im still having issues loggin in after using brew...
maybe I need to remove the cli?
Wondering if it got installed twice since I used npm first then brew?

Hmmm Im still having issues logging in after using brew...
maybe I need to remove the cli?
Wondering if it got installed twice since I used npm first then brew?
So I actually had to go into my library folder and manually delete the netlify folder.
I then reinstalled the netlify cli via brew

Yes exactly make sure to delete after installing via npm and then reinstall using brew!


Remove unlisted options for apps --> public

Description
We removed the unlisted option from apps creation in the past. This PR pushes this forward and remove the unlisted option entirely.
Risk
Low
Deploy Plan

run migration
deploy front
check that no app were created unlisted during deploy (very unlikely)

PMRR


Add a knownFiles transformation.

Also,

convert some uses of Hole back to Unit and
add an optimization that collapses two Filters into one.

Current coverage is 74.49% (diff: 34.78%)

Merging #1370 into master will decrease coverage by 0.15%

@@             master      #1370   diff @@
==========================================
  Files           214        215     +1
  Lines         11772      11802    +30
  Methods       11500      11531    +31
  Messages          0          0
  Branches        128        128
==========================================
+ Hits           8788       8792     +4
- Misses         2984       3010    +26
  Partials          0          0

Powered by Codecov. Last update 5a25841...58ca243

What's the motivation for switching some uses of Hole back to Unit?

I second @drostron's question about Hole vs Unit (just wanted to put myself on the msg thread)

So, we should replace Unit in general, but with specific types with specific meanings. qscript.Hole has a specific meaning, of referring to the source. But there is another use of Unit in QScript – when we linearize it. But this is distinct from the source reference.
I can think of at least two other places in our code where we use Unit in the same was as QScript linearization

we linearize Workflow in an aggregation pipeline, and
Matryoshka converts arbtirary T[F] into scala.Tree[F[Unit]].

The meaning here is something like “wish we could just delete this field in this case” or “we’re managing the recursion outside this structure” and we should have a name for it, but it’s not qscript.Hole.

Explanation appreciated. Wished I could offer a reasonable name so we could introduce that instead of Unit, 🤔.

@sellout @drostron Then could we give the Unit that are not qscript.Hole another name in this PR? How deep would that change have to go?

Thoughts on testing this transformation?

Definitely needs testing. I’m adding that, but while I do, here are some general questions and discussion for connector authors:
Initially, I saw knownFiles as very controlled by the connector itself. At the very least, a connector needs to supply a way for QScript to determine if there is a file or directory at a particular location on a mount. So that opens it up to “what is the most helpful way to define this from a connector’s point of view?”
One option was letting connectors specify their own path representation. So rather than final case class Read(path: pathy.AbsFile), we’d have final case class Read[A](path: A). But that’s not feasible until we have mutual recursion in QScript.
Another option is that what exactly constitutes a Read node. The way most (all?) connectors work, the “natural” structure of a collection at “/foo/bar” is similar to LeftShift(ProjectField(ProjectField(Root, "foo"), "bar")). So, a Read could represent that full structure. But then ProjectField(ProjectField(Root, "foo"), "bar") (no LeftShift[†]) would need to be represented as Reduce(Read("/foo/bar"), List(UnshiftMap(…))), but a different connector might prefer to not include the LeftShift in the Read, and then the latter case would be simply Read("/foo/bar").
Finally, a connector could choose to not have Read at all, and just deal with doing “the right thing” as it processes the “bare” QScript, containing LeftShifts, projections, etc. that can refer to directories, files, or data depending on their location.
In any case, I feel like it’s hard to suss this out until people have really used QScript. So, I expect knownPaths to change in the next month. But if people have thoughts now, I’m more than happy to hear them.
[†]: In MRA, projections affect the provenance, but in a way that the dataset stays the same size. So, with there being exactly one Root object, each ProjectField drills down one level, maintaining the singleton set. So, when you get to a collection, you don’t have a set of records, but a single object, with an entry for each record, where the keys are the ids of the record, so you need a LeftShift after the final projection to get the traditional notion of of a collection as a set of records.

@alissapajer I don’t think the non-Unit change would be deep. I’m happy to change it in this PR (I’d probably simultaneously change it in WorkflowTask, then later propagate it up to Matryoshka). @drostron suggested something along the lines of ExternallyManaged (with the single object maybe being called Extern?). That seems reasonable enough.

Expecting it to change over the next month is reasonable. Happy there will be a test or two providing a hint on usage.

@sellout Something that would be useful for incremental implementation, if possible, would be a transformation from LogicalPlan that just directly maps LogicalPlan.ReadF to qscript.Read. That'd at least allow us to sidestep this issue initially and then add support for arbitrarily pathing into objects within files.
This probably would cease to be possible once we start compiling SQL^2 directly to QScript (as connectors won't be able to choose how to interpret LogicalPlan, but might be helpful until then. One downside might be that it will take longer to start compiling directly to QScript because of this.

Updated this. Probably better to look at the whole thing, and not just the changes.
I’ll merge in master as soon as I get a chance.

This version looks like it should be easy to use by backends, nice work. Nothing major from me other than a few minor comments.

Oh yeah, that last commit also adds the version of convertToQScript that takes advantage of QueryFile.Ops.ls (i.e., knownFiles for free).

🎊  👍🏽


Intellisense not detecting array type

VSCode Version: 1.14.0

Steps to Reproduce:

Add an array as a property of an object and document the @type
View Intellisense for the property

Reproduces without extensions: Yes

This issue was moved to Microsoft/TypeScript#17140


[scnlib] Update scnlib to 0.3 to resolve missing header errors.

Describe the pull request
scnlib currently fails to build with Visual Studio 2019 version 16.6 because it doesn't include the correct headers; this has been fixed in the new version.

This is a duplicate of #11540

@c72578 Thanks, I missed that. We should take the one from the contributor; closing this one.


Add CodeCov support to .travis.yml #109

Closes #109
Waiting for review. Thanks.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

We were not able to merge this PR for two reasons:

#112 beat you to it
You did not sign the CLA

We would still love to chat with you! If you are interested, we would love the opportunity to talk to you about Hacktoberfest and our API libraries.
Our agenda would be: Explore what you liked and is there anything we can do to improve?
You can grab a time on my calendar that works for you and we can have a chat on Google Hangout or Skype. If you prefer, you can email me using my GitHub username at my company’s domain.
Thank you so much,
Matt Bernier - @mbernier - SendGrid Developer Experience Product Manager
Elmer Thomas - @thinkingserious - SendGrid Developer Experience Engineer
@SendGrid


fixes the MAV clear for scpi request without reply

in the TinyUSB example, the MAV flag is not cleared if the SCPI request does not reply (if it is a command instead of a request).
This pull request:
close #54

The value can only be 0 and positive.
reply_len is of type size_t
size_t is the unsigned integer type. Guaranteed to be 0 or more.


DEV-1052 selecting annotations

Changes the deserializeHighlights function to use the new deserializeHighlight function is it can accept an object instead of a json string.

@abrom Can you take a look at this please.


Implement a Linter

Also make tests for it for pull requests

Need to implement GitHub Action Lint too

Still need to check out other file types to lint, so leaving this open for now


Fix for Node 14 Gulp Build issue

Fixes #8864 by passing the minify argument as a string to fs.writeFileSync

Thanks for the pull request @LuminousPath!

:x: Missing CLA.

Please send in a Contributor License Agreement (CLA) and comment back here to let us know to check this!

:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.

Thanks @LuminousPath, even with a small change like this we need a CLA to accept the code. It's up to you if you want to contribute as an individual or on behalf of a company. See Contributor License Agreement for links to the web forms.
If you can't sign a CLA for whatever reason, I'm happy to make this change on your behalf (since it's tiny), but we can't add you to Contributors.md without the CLA.  So just let us know either way.
Thanks again.

No problem, I had to have a little back-and-forth with my business team but it looks like everything's in order. I've signed the CLA for my company, Navagis, so I think I should be good to go now.

Thanks @LuminousPath ! Can confirm we've received your corporate CLA.

Thanks @LuminousPath!


how to formate sql like PL/SQL beautifier in sql editor?

For example:
   select * from TABLE1 t where a > 100 and b between 12 and 45;
dbeaver formate above sql to this:
select
	*
from
	TABLE1 t
where
	a > 100
	and b between 12 and 45;

and PL/SQL beautifier formate above sql  to this:
select *
  from TABLE1 t
 where a > 100
   and b between 12 and 45;

Hi @zhaodecang ,
you could change formatting in preferences. Probably you can change formatter to Compact. Also, you can use External formatters.

Could you check if it resolves your issue?
Thanks in advance

Hi @zhaodecang ,
you could change formatting in preferences. Probably you can change formatter to Compact. Also, you can use External formatters.

Could you check if it resolves your issue?
Thanks in advance

Okay,thank you!


[user-managerd] Initialize pending call pointer. Fixes JB#49867

Also better logging of user switching.

LGTM


set effective gid before setting effective uid in switch_user_group

When I run a program using switch_user_group as root (uid 0/gid 0) and try and switch to another user that doesn't have setgid privileges (uid 1000/gid 1000 in this case), it fails with Operation not permitted (os error 1). I called the functions manually and found that set_effective_gid fails if called after set_effective_uid, but it works fine if called the other way around. This patch fixes the problem for me.
My guess is that setegid checks your effective uid to see if you have permission to change your effective gid, and since it was just changed to a non-privileged effective uid, the call fails.

Interesting! Thanks for investigating this issue and proposing a fix -- it's not one I've seen happen before. 👍

My guess is that setegid checks your effective uid to see if you have permission to change your effective gid, and since it was just changed to a non-privileged effective uid, the call fails.

This makes sense.

Published as v0.6.0

Awesome! Thanks for the quick response and publish.


fix: Separate zone caching by subnet selectors

Fixes #2228
Description
The set of zones for instance types was using the same cache key irrespective of the subnet selector. As a result, if two provisioners had distinct subnetSelectors that matched subnets in different availability zones, the karpenter controller would only see one of them and be unable to schedule nodes on some of the subnets.
How was this change tested?
Manually tested by patching this change on top of the v0.13.2-release branch in our cluster.
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

Release Note
Fix flakiness in setting up nodes in the right availability zone when provisioners target different subnets.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Nice fix! One minor recommendation

Thanks for the quick turnaround! Applied the recommendation.

looks like "github.com/aws/karpenter/pkg/utils/pretty" needs to be imported as well.

looks like "github.com/aws/karpenter/pkg/utils/pretty" needs to be imported as well.

Sorry for the bumbling around, fixed. Will keep an eye on any new silly compile errors.

@bwagner5 would it be possible to get this into a new RC (or if there is a regular release coming up, that would work as well)? Thanks!

We have snapshot builds, this includes this PR: public.ecr.aws/karpenter/controller:f4594705f9d20d3d1568fe5f989112dabbc51579


Streamlit cloud deploy

Setup free tier deployment with a github action

Done.  Link to the app in readme works now.


Cannot Import Istio CRD's due to error

Description of the bug:
When importing istio 1.5.8 crds I get a PascalCase error that fails the import
Reproduction Steps:
curl https://raw.githubusercontent.com/istio/istio/1.5.8/manifests/base/files/crd-all.gen.yaml > istio_crds.yaml
cdk8s import istio_crds.yaml
Error Log:
....
config.istio.io/attributemanifest
NOTE: Temp directory retained due to an error: /var/folders/f2/dp3vkzg520bbj33719z0gv3m0000gp/T/temp-CEQKku
Error: jsii compilation failed with non-zero exit code: 1
  | [2020-07-13T11:38:59.709] [ERROR] jsii/compiler - Type model errors prevented the JSII assembly from being created
  | error TS0: Type names must use PascalCase: attributemanifestOptions
  | error TS0: Type names must use PascalCase: attributemanifest
  +----------------------------------------------------------------------------------
  | Command: /usr/local/Cellar/cdk8s/0.26.0/libexec/lib/node_modules/cdk8s-cli/node_modules/jsii/bin/jsii --silence-warnings reserved-word
  | Workdir: /var/folders/f2/dp3vkzg520bbj33719z0gv3m0000gp/T/temp-CEQKku
  +----------------------------------------------------------------------------------
    at newError (/usr/local/Cellar/cdk8s/0.26.0/libexec/lib/node_modules/cdk8s-cli/node_modules/jsii-srcmak/lib/util.js:38:20)
    at ChildProcess.<anonymous> (/usr/local/Cellar/cdk8s/0.26.0/libexec/lib/node_modules/cdk8s-cli/node_modules/jsii-srcmak/lib/util.js:55:29)
    at Object.onceWrapper (events.js:421:26)
    at ChildProcess.emit (events.js:314:20)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:276:12)

Environment:

cdk8s --version  = 0.26.0
OS: OSX
Python : 3.8.3

Other:
Project is a python CDK8s

This is :bug: Bug Report

@campionfellin would you be able to take a look at this?

Yep, I can take this


[YBUG.IO] Error: insufficient funds to pay...

Error: insufficient funds to pay for pending and new transaction -- I'm getting that message whenever I click buy Buy SOV button on my Wallet confirmation Box and it also says that The User aborted the denied transaction.... why not enough fund for PENDING and New Transaction, while I'm just obtaining SOV?
Source url: https://live.sovryn.app/trade
Reported by<EMAIL_ADDRESS>Reported at: 29 Apr at 11:29 UTC
Location: SA, Eastern Province, Dammam
Browser: Chrome 90.0.4430.85
OS: Windows 7
Screen: 1366x768
Viewport: 1366x629
Screenshot:

For more details please visit report page on Ybug:
https://ybug.io/dashboard/reports/detail/8vrpfgjd37xphj44cykr

Sent user follow-up email with instructions on how to workaround this issue

Could you perhaps post that email here? given that Im having the same problem.

@R5fan the issue is specific to Liquality wallet, suggested workaround is lowering gas fee to "slow" and ensuring that you aren't using your full balance of rBTC, as Liquality currently has some issues with estimating/accounting for fees. If you're still experiencing issues after following these steps, I recommend contacting Liquality support or reaching out to our new support helpdesk here:
https://sovryn.freshdesk.com/support/home

Im not using liquality though, Im using a ledger nano x hardware wallet. Ill open a support ticket, thx.

Im not using liquality though, Im using a ledger nano x hardware wallet. Ill open a support ticket, thx.

@R5fan make sure you enabled "Contract data" access in your ledger RSK app settings


No example for using the debug output

Hi there,
I've initialized with html: false but it still gives me a html output, not the output like that of the debug tab in the demo, is this the intended behaviour or a bug or am I just doing it wrong?
Any help appreciated, thanks!

https://github.com/markdown-it/markdown-it/blob/master/support/demo_template/index.js#L198
This is is demo-specific feature.

Thanks!
Solved using .parse()


dap protocol jtag is an error when used

That's right, JTAG is not fully supported yet. (Because there is not much reason to support it, as almost every Cortex-M target support SWD, which is more efficient.) It's on the list to be implemented soon, however.

Closing this issue: duplicate of #593.


cli: Add getter methods to call return types

Implements #869.

Seems like the unit tests passed but the CI errored at the docker login command.
This is an expected failure, as only members can have access to Travis' secrets.

Thanks for checking it out.
What do you think about the update?

Hey @staa99 thanks for the contribution!!!
I agree that the developer experience can be improved, however I don't agree with the implementation.
The way this PR changes the code generation is appending getters at the end of a Result class:
export class {{ABI_NAME}}__{{FN_ALIAS}}Result {
  value0: BigInt;
  value1: Address;
  value2: string;

  constructor(
    value0: BigInt,
    value1: Address,
    value2: string
  ) {
    this.value0 = value0;
    this.value1 = value1;
    this.value2 = value2;
  }

  toMap(): TypedMap<string, ethereum.Value> {
    let map = new TypedMap<string, ethereum.Value>();
    map.set("value0", ethereum.Value.fromUnsignedBigInt(this.value0));
    map.set("value1", ethereum.Value.fromAddress(this.value1));
    map.set("value2", ethereum.Value.fromString(this.value2));
    return map;
  }

  // NEW CODE:

  getValue0(): BigInt {
    return this.value0;
  }

  getValue1(): Address {
    return this.value1;
  }

  getValue2(): string {
    return this.value2;
  }
}

However I think it would be simpler to just add a public modifier to those fields, like this:
export class {{ABI_NAME}}__{{FN_ALIAS}}Result {
  public value0: BigInt;
  public value1: Address;
  public value2: string;

  constructor(
    value0: BigInt,
    value1: Address,
    value2: string
  ) {
    this.value0 = value0;
    this.value1 = value1;
    this.value2 = value2;
  }

  toMap(): TypedMap<string, ethereum.Value> {
    let map = new TypedMap<string, ethereum.Value>();
    map.set("value0", ethereum.Value.fromUnsignedBigInt(this.value0));
    map.set("value1", ethereum.Value.fromAddress(this.value1));
    map.set("value2", ethereum.Value.fromString(this.value2));
    return map;
  }
}

Or even simplifying it even further, AssemblyScript supports a notation that the constructor can receive the public modifier itself, like this:
export class {{ABI_NAME}}__{{FN_ALIAS}}Result {
  constructor(
    public value0: BigInt,
    public value1: Address,
    public value2: string
  ) {
    // doesn't require to set them! :)
  }

  toMap(): TypedMap<string, ethereum.Value> {
    let map = new TypedMap<string, ethereum.Value>();
    map.set("value0", ethereum.Value.fromUnsignedBigInt(this.value0));
    map.set("value1", ethereum.Value.fromAddress(this.value1));
    map.set("value2", ethereum.Value.fromString(this.value2));
    return map;
  }
}

Unfortunately our "typescript" code generation currently doesn't support any of those, so you would have to change that instead.
What do you think? 🙂

Hi @evaporei
Thank you very much for your review. I think it's necessary for me to add more context here. I'll create a scenario:
Assuming the following contract exists:
contract SampleContract {
  struct A {
    uint256 someNumber;
    address someAddress;
  }

  function getData() public returns(A memory) {
    return A(block.timestamp, msg.sender);
  }
}

The code generator will generate a class like the following:
export class {{ABI_NAME}}__{{FN_ALIAS}}Result {
  value0: BigInt;
  value1: Address;

  constructor(
    value0: BigInt,
    value1: Address
  ) {
    this.value0 = value0;
    this.value1 = value1;
  }

  toMap(): TypedMap<string, ethereum.Value> {
    let map = new TypedMap<string, ethereum.Value>();
    map.set("value0", ethereum.Value.fromUnsignedBigInt(this.value0));
    map.set("value1", ethereum.Value.fromAddress(this.value1));
    return map;
  }
}

This is the current behavior. My changes will cause the generated class to change to this:
export class {{ABI_NAME}}__{{FN_ALIAS}}Result {
  value0: BigInt;
  value1: Address;

  constructor(
    value0: BigInt,
    value1: Address
  ) {
    this.value0 = value0;
    this.value1 = value1;
  }

  toMap(): TypedMap<string, ethereum.Value> {
    let map = new TypedMap<string, ethereum.Value>();
    map.set("value0", ethereum.Value.fromUnsignedBigInt(this.value0));
    map.set("value1", ethereum.Value.fromAddress(this.value1));
    return map;
  }

  getSomeNumber(): BigInt {
    return this.value0;
  }

  getSomeAddress(): Address {
    return this.value1;
  }
}

It is more friendly to use getSomeNumber() and getSomeAddress() in code than use the value0 and value1 fields. That's why I implemented it this way. What do you think? 🙂

@staa99 the code I've posted above was generated with your branch, I don't see how it would generate methods with the names getSomeNumber and getSomeAddress in the name instead of getValue0 and getValue1, could you elaborate on that please? 🙂

Sure @evaporei. The reason why it generated those for you is because of the names of the variables in your ABI. The line get${output.get('name')[0].toUpperCase()}${output.get('name').slice(1)} reads the name of the variable from the ABI, capitalizes the first letter and prepends get to it. For example, feeRate becomes getFeeRate.
I'll use a real sample I have locally. I updated my local implementation (in node_modules) to use the feature.
I have an abi with these fields:
{
  "inputs": [
    {
      "internalType": "uint256",
      "name": "",
      "type": "uint256"
    }
  ],
  "name": "sellOrders",
  "outputs": [
    {
      "internalType": "uint256",
      "name": "id",
      "type": "uint256"
    },
    {
      "internalType": "uint256",
      "name": "totalAmount",
      "type": "uint256"
    },
    {
      "internalType": "uint256",
      "name": "feeRate",
      "type": "uint256"
    },
    {
      "internalType": "uint256",
      "name": "minimumBuyAmount",
      "type": "uint256"
    },
    {
      "internalType": "uint256",
      "name": "lockedAmount",
      "type": "uint256"
    },
    {
      "internalType": "uint256",
      "name": "filledAmount",
      "type": "uint256"
    },
    {
      "internalType": "uint32",
      "name": "preDisputeDuration",
      "type": "uint32"
    },
    {
      "internalType": "address",
      "name": "seller",
      "type": "address"
    },
    {
      "internalType": "address",
      "name": "token",
      "type": "address"
    },
    {
      "internalType": "bool",
      "name": "active",
      "type": "bool"
    },
    {
      "internalType": "bytes",
      "name": "metadataURI",
      "type": "bytes"
    }
  ],
  "stateMutability": "view",
  "type": "function"
}

It generates the following class without the getters:
export class CryptoExchange__sellOrdersResult {
  value0: BigInt;
  value1: BigInt;
  value2: BigInt;
  value3: BigInt;
  value4: BigInt;
  value5: BigInt;
  value6: BigInt;
  value7: Address;
  value8: Address;
  value9: boolean;
  value10: Bytes;

  constructor(
    value0: BigInt,
    value1: BigInt,
    value2: BigInt,
    value3: BigInt,
    value4: BigInt,
    value5: BigInt,
    value6: BigInt,
    value7: Address,
    value8: Address,
    value9: boolean,
    value10: Bytes
  ) {
    this.value0 = value0;
    this.value1 = value1;
    this.value2 = value2;
    this.value3 = value3;
    this.value4 = value4;
    this.value5 = value5;
    this.value6 = value6;
    this.value7 = value7;
    this.value8 = value8;
    this.value9 = value9;
    this.value10 = value10;
  }

  toMap(): TypedMap<string, ethereum.Value> {
    let map = new TypedMap<string, ethereum.Value>();
    map.set("value0", ethereum.Value.fromUnsignedBigInt(this.value0));
    map.set("value1", ethereum.Value.fromUnsignedBigInt(this.value1));
    map.set("value2", ethereum.Value.fromUnsignedBigInt(this.value2));
    map.set("value3", ethereum.Value.fromUnsignedBigInt(this.value3));
    map.set("value4", ethereum.Value.fromUnsignedBigInt(this.value4));
    map.set("value5", ethereum.Value.fromUnsignedBigInt(this.value5));
    map.set("value6", ethereum.Value.fromUnsignedBigInt(this.value6));
    map.set("value7", ethereum.Value.fromAddress(this.value7));
    map.set("value8", ethereum.Value.fromAddress(this.value8));
    map.set("value9", ethereum.Value.fromBoolean(this.value9));
    map.set("value10", ethereum.Value.fromBytes(this.value10));
    return map;
  }

  getId(): BigInt {
    return this.value0;
  }

  getTotalAmount(): BigInt {
    return this.value1;
  }

  getFeeRate(): BigInt {
    return this.value2;
  }

  getMinimumBuyAmount(): BigInt {
    return this.value3;
  }

  getLockedAmount(): BigInt {
    return this.value4;
  }

  getFilledAmount(): BigInt {
    return this.value5;
  }

  getPreDisputeDuration(): BigInt {
    return this.value6;
  }

  getSeller(): Address {
    return this.value7;
  }

  getToken(): Address {
    return this.value8;
  }

  getActive(): boolean {
    return this.value9;
  }

  getMetadataURI(): Bytes {
    return this.value10;
  }
}

The problem is that it is hard to determine what the variables represent by using value0 or valueN. With the getters, it's easy to work normally with little risk of bugs resulting from inadvertently using the wrong variable.

Hi @evaporei, thanks a lot for your review. What are the necessary steps to get the changes merged and what is the release cycle like?

I'm sorry @staa99 that I didn't get back to this, I'll try to soon 🙏
Again, thanks a lot for the contribution and proactiveness ❤

Thanks a lot @evaporei. I appreciate the time taken to review the changes. I look forward to doing more to improve the tools we use and love.

@staa99 sorry for the long await, I was OOO (out of office). Can you rebase your branch with master so we can merge it 🙂

Hi @evaporei,
Sorry about the late response. I'll do that today and leave a comment.
Thank you.

Hi @evaporei,
I have rebased my branch with master.
Thank you for your time.


Document using kubectl to create an interactive debugging session on a node

This is a Feature Request

What would you like to be added
Document kubectl debug node in a node troubleshooting context
Why is this needed
Other than a small mention in Debug Running Pods, there's no task documentation to cover the kubectl feature that lets you create a Pod on a node - and attach to it - for doing node troubleshooting tasks.
Comments
I'd expect to see an update to https://kubernetes.io/docs/tasks/debug/debug-cluster/ as part of this work. Maybe a hyperlink, maybe more than that.
/language en
/sig cli
/kind feature
Relevant to https://github.com/kubernetes/enhancements/issues/1441

/triage accepted

hey I would like work on this. Could you provide some more details on what needs to be done?

@akankshakumari393: it's not clear who (which person, or which group) your request was aimed at.
If you've read https://github.com/kubernetes/website/issues/35031#issue-1305395977 and you have questions, maybe you can list some of the questions that you're now pondering?

Cool thanks, I will check and let you know on this.

/assign

@akankshakumari393 you can assign the PR to me when it's ready

Folks who'd like to work on this are welcome to do so. Please liaise with @akankshakumari393 first if possible, to avoid duplicating work.

/remove-lifecycle stale


fix: match outdated api by k8s version

Signed-off-by: chenk<EMAIL_ADDRESS>Related: Trivy issue 3338

looks like tests are failing @chen-keinan

@simar7 now its ready for review


[Question] How to use --inputDir flag?

How is the --inputDir flag supposed to work?
I was hoping that mcr --inputDir dir-with-raw-coverage will do the job. Felt like this should be enough, if raw coverage is already generate. Or?

close it, please see https://github.com/cenfun/monocart-coverage-reports/issues/51#issuecomment-2201780689


Quantifiers in predicate are not supported

`The sentence is - ex. assume x is a rational number . assume x is greater than 2 . then x is greater than every rational number less than 1 .
added variable names - ex. assume x is a rational number ( x 6 ) . assume x is greater than 2 . then x is greater than every rational number ( x 37 ) less than 1 .
simplified - ex. assume x is a rational number x . assume x is greater than 2 . then x is greater than every rational number ( x 37 ) such that ( x 37 ) is less than 1 .
Translate: Translations.hs:84:1-55: Non-exhaustive patterns in function translateTerm`
x is greater than every rational number less than 1 is not translated

Solved by cdf79da using a function to extract the quantified notion from the predicate


Add Audit Log

What is the purpose of the change
Whether the restful interface has the supplement of full confirmation missing of the audit action, and the key need is to add the operating data bar target ID
Related issues/PRs
Related issues: #3859
Related pr:#3860
Checklist

[x] I have read the Contributing Guidelines on pull requests.
[ ] I have explained the need for this PR and the problem it solves
[ ] I have explained the changes or the new features added to this PR
[ ] I have added tests corresponding to this change
[ ] I have updated the documentation to reflect this change
[ ] I have verified that this change is backward compatible (If not, please discuss on the Linkis mailing list first)
[ ] If this is a code change: I have written unit tests to fully verify the new behavior.

please  create pr  to dev-1.3.2


RuleToStringInterface introduced and added to all rules which support __toString()

The intention is to be able to convert rules reliably to strings  e.g.
/** @var RuleToStringInterface $rule */
foreach ($rules as $key => $rule) {
    $stringRules[$key] = $rule->__toString();
}

Why do we need to create a new interface that just requires __toString()? Instead we could use PHPs own Stringable interface. But as it states in the docs this interface is automatically present when the class contains a __toString() method.
https://www.php.net/manual/en/class.stringable.php

Good point but 'Stringable' is available starting with 8.0 PHP version but Laravel supports "php": "^7.3|^8.0",

Stringable should be a good addition for Laravel 9 since we bumping to php 8

👎 For merging this, because we're only gonna immediately deprecate it.

Stringable is the right way to go.

It's perfectly fine for me not to merge it.
If only PHP 8 is used in [9.x]  Stringable is way more elegant.


Front flash bug

When taking a front facing picture in the dark with flash on, the flash only shows for a brief second, and goes away before the picture is even taken, resulting in a dark photo. Any way to make the flash last until the picture is taken?

I am unable to reproduce this bug on any of my test devices. Do you have any other information?


Consider adding a fancy-ctrl-z function

Consider integrating the following code:
# —————————————————————————————————————————————————————————————————————
# Ctrl+Z
# —————————————————————————————————————————————————————————————————————
# - On an empty command line, runs bg (so that Ctrl+Z Ctrl+Z suspends a program and immediately resumes it in the background).
# - On a non-empty command line, suspend the current command edition: let me type another command, and when that second command line finished, I get back the first command to edit.
fancy-ctrl-z() {
	if [[ $#BUFFER -eq 0 ]]; then
		bg
		zle redisplay
	else
		zle push-input
	fi
}
zle -N fancy-ctrl-z

@sorin-ionescu Is CTRL+Q still mapped to this function? I can't get it to work.
I have tried this from Vim and nothing happened (expected Vim to suspend) and from zsh after suspending Vim (expected Vim to resume).

This is what I currently have in my zshrc:
function fancy-ctrl-z()
{
	if [[ $#BUFFER -eq 0 ]]
	then
		bg
		zle redisplay
	else
		zle push-line-or-edit
	fi
}
zle -N fancy-ctrl-z
bindkey '^Z' fancy-ctrl-z

Only significant difference is that I've chosen to use zle push-line-or-edit instead or push-input and have the bindkey operation at the bottom. Haven't used this in a while (primarily used to use it for vim but since switching to MacVim it's gathered dust) but I tried it out on my setup.
The function does work if I run sleep 10 but from some reason it doesn't not work for vim. I'm not sure why. The function will exit vim to the command line but I must use fg to get back into vim.
Also, the CTRL+Q is (was?) located here:
prezto/modules/editor/init.zsh
291:  for key in "$key_info[Control]Q" "$key_info[Escape]"{q,Q}

I see. I had similar code in my zshrc until I reverted to stock prezto earlier today:
  # Allow returning to Vim by pressing Ctrl+Z
  fancy-ctrl-z () {
    if [[ $#BUFFER -eq 0 ]]; then
      BUFFER="fg"
      zle accept-line
    else
      zle push-input
      zle clear-screen
    fi
  }
  zle -N fancy-ctrl-z
  bindkey '^Z' fancy-ctrl-z

I know it's not on topic, but would you mind explaining the differences between push-input and push-line-or-edit? And why does mine use BUFFER="FG", while yours uses bg? bg (which I assume means 'background') makes a lot more sense there. I'm a beginner and didn't write the code myself, but rather blindly copied it from a blog post, so I don't understand it all. And I'm assuming the bindkey line is just binding CTRL+Z to the function method. Would the original post work as intended without that line?
As I still primarily use Vim in the terminal, getting this to work would be very nice. Of course, CTRL+Z to suspend and fg to resume isn't such a hassle, it's just not nearly as convenient as pressing the same keys twice.
I guess the point is if Ctrl+Q does not work as intended, we should make it work or provide an alternative. It doesn't really matter if the we call it "fancy-ctrl-z" or "fancy-ctrl-q" as long as one of them works.
For reference, here is the Ctrl+Q line (287). I know I'm a beginner and all, but I don't see how this has the suspend and resume function of fancy-ctrl-z. It seems to me like it's only one way because it only does push-line-or-edit.

@ethanmad Sorry for the (very) late reply but I hope this helps!
I think I can clear some of this up. Let's walk through the logic:
Create a new function that can be called by the shell:
function fancy-ctrl-z()
{
...
}

Make the function into a widget that can be used by the editor:
zle -N fancy-ctrl-z

Assign a shortcut to the widget so that it can be called:
bindkey '^Z' fancy-ctrl-z

Now, let's look at the function's logic:
function fancy-ctrl-z()
{
    if [[ $#BUFFER -eq 0 ]]
    then
        ... # I'm currently in a program like vim
    else
        ... # I'm currently editing the command line
    fi
}

If I'm in vim (or similar) and I press Ctrl + z, two things happen:

bg sends vim to background
zle redisplay brings you back to the zsh line editor

If I'm on the command line, zle push-line-or-edit executes. As described by the manual:
At the top-level (PS1) prompt, equivalent to push-line. At a secondary (PS2) prompt, move the entire current multiline construct into the editor buffer. The latter is equivalent to push-input followed by get-line.

In effect, this means that if I start to run command foo (and haven't executed it) but remember that I need to run bar first, calling our widget with Ctrl + z will save what I've typed, give me a clean line to execute bar, and upon completion, place the unexecuted text that I started to type for the command foo back on the line editor. Very useful!
Hope this helps!

@chauncey-garrett Thank you! Makes sense now.

I like that this suspends vim.

@leoj3n That's what I end up using it for the most! :)

@sorin-ionescu Please consider reopening this enhancement or please explain why not.

As @ethanmad pointed out, it would be nice if pressing CTRL+Z undid the backgrounding.

Yes, that's the goal of the function. I think CTRL + Q only quits the
current application. The function as described by Chauncey is probably what
should be implemented, though my posted code works as well.
On Tue, Apr 14, 2015 at 8:05 PM Joel Kuzmarski<EMAIL_ADDRESS>wrote:

As @ethanmad https://github.com/ethanmad pointed out, it would be nice
if pressing CTRL+Z undid the backgrounding.
—
Reply to this email directly or view it on GitHub
https://github.com/sorin-ionescu/prezto/issues/438#issuecomment-93169289
.

CTRL+Q does not quit the current application. It copies the currently written command into a buffer, blanks the command line to allow the user to write another command then pastes the original command back on the command line after execution.
When is it useful? Let us say that you wrote a command that you are about to execute only to realise that you are in the wrong directory. Press CTRL+Q, change directories, then your command will be ready for execution.

I see, CTRL + Q is actually really useful. Having now tried it, it will definitely become one of my more common shortcuts.
CTRL + Z is similar in purpose, but for applications rather than commands.

@ethanmad CTRL+Z is functionally the same as CTRL+Q but with the added functionality of backgrounding the current process if one is running.

Yep, that's correct:
  # Use a more flexible push-line.
  for key in "$key_info[Control]Q" "$key_info[Escape]"{q,Q}
    bindkey -M "$keymap" "$key" push-line-or-edit

For what it's worth, when I originally opened this issue, I was unaware that the CTRL+Q functionality existed.
While I do find my CTRL+Z very useful, it may be too hacky for prezto (which, as @sorin-ionescu has specifically stated, is to contain sane defaults—which I greatly appreciate). At this point the issue here boils down to whether or not allowing the current process to be sent to the background with a global keyboard shortcut is a sane idea.
I haven't come across an occurrence where doing so has been an issue for me but I can imagine the keybinding could cause problems somewhere.

Overriding CTRL+Z, one of the most used commands does not seem wise.
On Wed, Apr 15, 2015 at 22:16 Joel Kuzmarski<EMAIL_ADDRESS>wrote:

@ethanmad https://github.com/ethanmad CTRL+Z is functionally the same
as CTRL+Q but with the added functionality of backgrounding the current
process if one is running.
—
Reply to this email directly or view it on GitHub
https://github.com/sorin-ionescu/prezto/issues/438#issuecomment-93618928
.

@chauncey-garrett, @leoj3n, @sorin-ionescu Now that I understand what Ctrl-Z does, I want to use this command as-is without overloading it to do the unbackgrounding. The command fg to bring a task back into the foreground makes more sense to me. Thanks


Main.js problem

Tried the theme, but but got an error in the console, looks like the main.js file path compiled wrong and looks like this:
https://localhost:3000/wp-contentthemespress-wind/main.js?ver=1691594594

Ok, found bug. The enqueue method:
wp_enqueue_script($slug, 'https://localhost:' . $port . '/wp-content' . get_wp_path($path) . '/main' . ($is_ts ? '.ts' : '.js'), [], strtotime('now'), true);
Function get_wp_path($path) is removing slashes.

i look that ASAP, thanks


Add className support

This looks good, thanks @tamirkash - I'll merge it in shortly.

Great!
My first contribution yay :)

I should be able to merge this in either tomorrow or Thursday. Just
curious, as this package is extremely new - how did you find it? :-)
On Tue, Mar 13, 2018 at 9:24 AM, tamirkash<EMAIL_ADDRESS>wrote:

Great!
My first contribution yay :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/factor1/react-card-flipper/pull/7#issuecomment-372727324,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJASebvEqtX9TOmioCnQSm6_Olfddi41ks5td_LCgaJpZM4Somwa
.

--
eric stout
<EMAIL_ADDRESS>
factor1studios.com  |  twitter.com/factor1  |  facebook.com/factr1

Basically I searched for an issue related to a react project with the label 'good first issue' and this issue came up

Nice! Thanks a lot.
On Tue, Mar 13, 2018 at 11:44 AM, tamirkash<EMAIL_ADDRESS>wrote:

Basically I searched for an issue related to a react project with the
label 'good first issue' and this issue came up
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/factor1/react-card-flipper/pull/7#issuecomment-372775921,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJASedEe7NkvLoUC9xqHyE46MlKmI7Xjks5teBOUgaJpZM4Somwa
.

--
eric stout
<EMAIL_ADDRESS>
factor1studios.com  |  twitter.com/factor1  |  facebook.com/factr1


Icon request for .tern-project

I use atom-ternjs for autocomplete and need it a .tern-project file in directory.
Can you add an icon for that file?
Thanks!

Sure thing! ;) On it.

Are there any other Tern-related files we should be using this icon for?

Gonna take that as a no, heh.
YA ESTA PARCERO

@Alhadis i was sleeping, but not, I don't know other tern-related file.
thanks for that!

DE NADA. ES UNA CHIMBAAAAAAA


Update AsNoTracking() summary

Updated AsNoTracking summary, specifying that it does not detach the returned
instances completely and tracking conflicts may still occur when loading new instances
using tracking.
- Previously there was no clear indicator that AsNoTracking() leaves the Entities attached, and
  the resulting error for loading a new tracked instance for these Entities
  (InvalidOperationException) does not lead to a direct resolution.

[ ] The code builds and tests pass (verified by our automated build checks)
[X] Commit messages follow this format
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Code meets the expectations our engineering guidelines. https://github.com/aspnet/Home/wiki/Engineering-guidelines.

Previously there was no clear indicator that AsNoTracking() leaves the Entities attached,

That is not true. Please file a new issue with detailed repro steps. The documentation change you are making here is incorrect.


fix: Clear exit survey data

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/50215
PROPOSAL: https://github.com/Expensify/App/issues/50215#issuecomment-2396524928
Tests

Login to any account
Navigate to settings > Switch to Expensify Classic
Select any of the options > Next > Fill in the next form with any text > Next
Refresh your browser > Navigate to settings > Switch to Expensify Classic
Verify the previously selected answer is not displayed as selected
Select any of the options > Next
Verify the previously text is not displayed

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/74e97e57-8c58-494b-89a1-0b8a89d010c6

Android: mWeb Chrome

https://github.com/user-attachments/assets/8d2f15e5-e23e-4c0a-afb9-d9088b3a5ae3

iOS: Native

https://github.com/user-attachments/assets/58143f9e-54d6-4fff-aeca-3ac247055238

iOS: mWeb Safari

https://github.com/user-attachments/assets/0cecb45a-99ae-4333-be43-98125133552d

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/17c839aa-7887-4dcc-ab6f-8a0808d5dcaa

MacOS: Desktop

https://github.com/user-attachments/assets/ac9da2d0-94da-4002-8d05-912f8431dfa9

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@truph01 Could you please handle the case where the value is not reset after reloading ExitSurveyResponsePage and then start a new flow?
https://github.com/user-attachments/assets/b5ad7fde-e699-455f-a0dd-281521de31d1
The issue occurs from 50s

@suneox I fixed the bug.

@truph01 Could you please add the QA Steps? If the QA Steps are the same as the Test section, you can simply write The same as the Test section  Due to in your checklist has an item I added steps for Staging and/or Production testing in the QA steps section

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


Resource request: What goes into a GitHub repo?

There are a lot of files that go into a GitHub repo which aren't the code itself, such as a README.md, perhaps a CONTRIBUTING.md or a CODE_OF_CONDUCT.md, or others.  We should make a page of short descriptions of each of these and what they mean, perhaps with links to longer articles or blog posts about the purpose of each.  This would be especially helpful for those new to open source!

Definitely... Brainstorming here...

.gitignore

A file that tells git which files to ignore when executing any sort of git add (relative or universal — using git add .

README.md

A file that contains basic information about the repository, such as title and description, creator, links to resources for the project, a reference to the license of the project, and perhaps a few usage examples. Some README.md files list contributors to the projects; others don't.

CONTRIBUTING.md

A file that GitHub will link to at the top of every new pull request. Outlines coding conventions in the project, or specifies other contributing guidelines, such as "must include unit tests."

CODE_OF_CONDUCT.md

A file which outlines the code of conduct for that project and its community on GitHub, usually defining expected behavior throughout issues, pull requests, or general discussion.

LICENSE

A file which outlines the licensing for the project. Licenses specify the range of use and modification of (with and without attribution) any publically released code or graphics. A great website for comparing licenses is TLDRLegal — Software Licenses Explained in Plain English.

CHANGELOG.md

A file which outlines various changes in a projects lifetime. Usually just includes changes on a per-release basis, but may include more detailed changes. Here is an example of a great changelog,  from Facebook's JavaScript library for building user interfaces, React.

Another great resource for understanding licenses is available here.

Closing now due to inactivity, but let's reopen if we want to revisit this! 🎉


TextContent Font Information

Attach (recommended) or Link to PDF file here: https://shub-storage.sgp1.cdn.digitaloceanspaces.com/tests/2322868/file_url/1646841064228_2022._De_5.pdf
Configuration:

Web browser and its version: Chrome   99.0.4844.84
Operating system and its version:  Windows 10 21H2 19044.1586
PDF.js version: 2.6.347

Is there anyway that i can get the font infomartion like fontSize 12px , open sanserif, etc.. from getTextContent or from getDocument ? After scrolling through some issues i know there is a FontFaceObj with fields like fallBackName : "serif" or loadedname "g_d2_f1" ,.... but i couldn't find the fontSize
I use the getPage function then render the pdf into canvas, does its fontsize affected by my html fontsize?
i need to calculate the width of textContent from getTextContent() to split the textContent into parts, because getTextContnet often break word into multiple text objects or keep the whole line as only 1 text object, but i can't find a way that i can get fontsize to do it
Thank you very much

PDF.js version: 2.6.347

That version is no longer supported, please find the latest releases at https://mozilla.github.io/pdf.js/getting_started/#download

Is there anyway that i can get the font infomartion like fontSize 12px , open sanserif, etc.. from getTextContent or from getDocument ?

That'd require iterating through the operatorList[1], and checking for the OPS.setFont operator which contains both the internal font-name and also the font-size. However, please note that since rendering and text-extraction are separate in PDF documents (from a specification perspective) you'll not be able to directly connect the rendered glyphs with actual textLayer content. Unfortunately it sounds like your use-case might be one that we don't really support, however given the somewhat limited information it's a bit difficult to tell exactly what you're actually trying to do here.

[1] See https://github.com/mozilla/pdf.js/blob/4d4c67dd6e5c826287cd7cdd216435cd651a9301/src/display/api.js#L1545-L1554


fix: [#4684] ESLint issues in botbuilder-ai-luis

Addresses # 4684
#minor
Description
This PR removes the unnecessary eslint.config file to reference the root one directly in the botbuilder-ai-luis project. No ESLint warnings or errors found.
Specific Changes

Removed 'only-warn' plugin from 'botbuilder-ai-luis'.

Testing
The following image shows that there are no more ESLint issues.

/promoted 4824


Fix for #711 - added jxcore url to configuration file

This change is

PR is added to the queue for testing as 1. task. (7f6295f)

Hi @czyzm, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

Test (Success) 67299656 build is completed (7f6295f)
See https://github.com/ThaliTester/TestResults/tree/672996567f6295f_Fix_for__711_-_added_jxcore_url_to_configuration_file_czyzm/ for the logs

Test 672996567f6295f(7f6295f) has failed
See https://github.com/ThaliTester/TestResults/tree/672996567f6295f_Fix_for__711_-_added_jxcore_url_to_configuration_file_czyzm/ for the fail logs

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable