Runtime.ImportModuleError: Unable to import module 'cleanup_bucket'

Hi Team, after run multiple times and there is openSSL issue and tested with diff. OS but still it's same issue while creating "S3Buckets" stack CF. looks like it's openssl issue which is out dated on the code. pls share next steps.

[ERROR] Runtime.ImportModuleError: Unable to import module 'cleanup_bucket': urllib3 v2.0 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with OpenSSL 1.0.2k-fips  26 Jan 2017. See: https://github.com/urllib3/urllib3/issues/2168
Traceback (most recent call last):

Thank you for bringing this to our attention, this will be fixed in our upcoming release. In the meantime, can you please provide steps to reproduce this error so I can help you with this issue?


Issue with image component in custom markers (Android)

Hi,
I'm facing an issue with custom markers where Image components randomly fail to get rendered in the MapView, following bellow an image about it where each one of the blue boxes represents a custom marker component:

The reason why it defines a custom marker to show an image rather than defining it through the "image" property is because I want to add a text overlay in the middle of the marker (perhaps there is another way to achieve the same result ?).
Also, I'm providing a test case which was used to generate the image above, since it's a bit long I've hosted it under pastebin :
http://pastebin.com/LJ6JRzLR
Bellow some additional information about my environment :

Lib
Version

react-native
0.26.2

react-native-maps
0.4.2

Android
5

Any thoughts ?
Cheers,
Paulo

Read #100 👍

Hi @DennisMG, thanks for pointing out that to me.

Duplicated issue, closing it


What response should I return when the url id does not match with the data.id on an update request?

Example:
PATCH /articles/1 HTTP/1.1
Content-Type: application/vnd.api+json
Accept: application/vnd.api+json
{
"data": {
"type": "articles",
"id": "123",
"attributes": {
"title": "To TDD or Not"
}
}
}

409 Conflict, as described here.


Clarify initial client interaction with view

I'm trying to get a simple frontend up and running, and I'm confused over what RPCs should be sent when creating a new view. My current understanding is that after sending client_started on initialization, a frontend would typically call new_view, and then receive an update to the line cache for that view.
The docs are unclear on what should happen next. Should my frontend attempt to render the view at this point? Should I then send an initial scroll_to to indicate to the core where the scroll window is?
Next, I'm confused as to what an "invalid" line means, and how a frontend should handle it. Does my client need to request that line so that the cache becomes valid? How can I do that?
It would be great to add these cases to the docs. I'd be happy to open a PR.

Hey sorry for missing this issue!
Sending scroll_to is good practice although it isn't strictly necessary; if it isn't set core will assume that the view is at line 0 and has a height of 10 lines.
The view should render any time it receives either update or scroll_to.
The client shouldn't necessarily ever need to request lines, except in specific circumstances where it is prefetching lines for something like predictive scrolling. In the general case, core will send the necessary lines after a given edit/scroll event.
It's useful to think of the update protocol as being specifically about cache state. An update message from core-> client should always leave the client with enough information to render the current view of the document.
The invalidate operation just tells the frontend to discard some set of lines. If those lines have been deleted, no further work is necessary; if those lines have been modified or replaced, then there will be an additional insert op that includes the new lines.
I agree that the frontend docs could use some help. Will take a look at that now.

Thanks for the clarification! So, to get the rest of the lines in the cache I need to send a scroll edit?
Also, I'm confused why I get invalid lines on the initial update. Is that just to let the cache know how many total lines are in the file, since the initial scroll window is only 10 lines?

Yes, sending the scroll event will set the size of the viewport; and yes, the invalid lines on the first update inform the frontend of the total line count.

closing this, docs were updated in #642 to discuss client_started.


Update heapsnapshot.js

I concur with @cfanoulis. This change is merely preference, and developers prefer to avoid DMs when possible.


Added Quickstart (Windows 11, using Scoop)

This PR adds a short Quickstart section that people on Windows 11 using Scoop can copy-and-paste into a Windows Terminal to quickly get the scoop.sh website built and running on localhost.
I have had success with this kind of Quickstart in a previous project and thought it may be helpful, especially to people who are not used to NodeJS or NPM.

LGTM. Thanks @hiAndrewQuinn


Hello World example detected as trojan virus.

This is more of an informational notice than an issue.
If you copy the hello world example and name it anything with hello or world in it, Microsoft Windows 11 Antivirus Engine will detect it as one of various Trojan viruses.
This is the case for any executable named hello or world. I doubt that it's even scanning the file, just going off of the name.

https://go.dev/doc/faq#virus


Add a Cargo.lock file

to avoid accumulating incompatible versions.
Signed-off-by: Jakob Naucke<EMAIL_ADDRESS>The one provided here was built with --no-default-features. https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries suggests binary applications should lock their versions. If you disagree, we can also use more rigorous version locks in Cargo.toml. What I'd like to avoid is random breakage, which happened on s390x with socket2 v0.4.3 in combination with libc v0.2.113 (see https://github.com/rust-lang/libc/pull/2645#issuecomment-1020128032).

@Jakob-Naucke Can you please rebase this PR and we can merge it.

Thanks @jialez0 -- this Cargo.lock is from just now.


What means connection parameter "keepAlive"?

does it means keepAlive the sql connection?but,the sql connection is TCP connection,Isn't it keepAlive?i want to communication with you,but i does not know how to contact you,so i put a new issue.

i believe the default for mssql is that after 30 seconds of idle, the connection is dropped. i've been running into this myself with a little REST interface; I've found that if i GET a json after that idle period, it'll hang. However, if i refresh the page, the query proceeds.
@denisenkom is that behavior by design? i ask because i'm planning to just have a ping before every query.

nevermind; found go-mssqldb#44

@tristanwietsma it means that if i does not use the connection some time,it will be closed?

@haochun http://blogs.msdn.com/b/sql_protocols/archive/2006/03/09/546852.aspx


EntityCommands get mutable reference to added components

What problem does this solve or what need does it fill?
When implementing modular systems-based entity spawning, you gather Commands to obtain EntityCommands for the specific entity that is being spawned in the series of added entity builder systems running that frame. Sometimes one entity builder system wants to obtain a mutable component a previous builder already added to that specific (ie adding an offset to the entity's existing Transform component). To my knowledge, this is not possible right now.
What solution would you like?
Some methods similar to that of Query. Ie get_component and get_component_mut get added to EntityCommands.
What alternative(s) have you considered?
One could add their own resource shared across those entity building systems and store&modify components through it and add a final system that wraps it up and adds it to EntityCommands.
Additional context
In the context of plugins expanding the default spawn components of each entity: plugins would insert their own labeled builder systems to the loop to tap into the spawning process of entities coming to life in the next frame from the EntityCommands frame. Currently, you cannot obtain or edit components that have already been passed to EntityCommands and building entities this way requires your own Resource that has to be some type of generic component container with various implementations to deal with it.

As an alternative to adding this functionality to Bevy itself, you can get this functionality entirely through the published API and a trait. This is based on my PR #9544, which provides the same functionality, just without the use of a trait. In my opinion, either #9544 could be accepted, or the below could be used to justify closing this issue.

Trait Implementation
use bevy_ecs::prelude::*;

/// Provides access to [`WithQuery::with_query`] and [`WithQuery::with_query_filtered`].
pub trait WithQuery {
    /// Allows querying of an entity's components with a filter. This is most useful when working
    /// with a highly composed entity where you wish to modify some of its components.
    fn with_query_filtered<Q, F>(
        &mut self,
        function: impl for<'t> FnOnce(Q::Item<'t>) + Send + 'static,
    ) -> &mut Self
    where
        Q: WorldQuery + 'static,
        F: ReadOnlyWorldQuery + 'static;

    /// Allows querying of an entity's components. This is most useful when working with a highly
    /// composed entity where you wish to modify some of its components.
    fn with_query<Q>(
        &mut self,
        function: impl for<'t> FnOnce(Q::Item<'t>) + Send + 'static,
    ) -> &mut Self
    where
        Q: WorldQuery + 'static,
    {
        self.with_query_filtered::<Q, ()>(function)
    }
}

impl WithQuery for EntityCommands<'_, '_, '_> {
    fn with_query_filtered<Q, F>(
        &mut self,
        function: impl for<'t> FnOnce(Q::Item<'t>) + Send + 'static,
    ) -> &mut Self
    where
        Q: WorldQuery + 'static,
        F: ReadOnlyWorldQuery + 'static
    {
        self.add(move |entity: Entity, world: &mut World| {
            let mut query = world.query_filtered::<Q, F>();

            if let Ok(result) = query.get_mut(world, entity) {
                function(result);
            };
        });

        self
    }
}

use bevy_ecs::prelude::*;

#[derive(Resource)]
struct PlayerEntity { entity: Entity }

#[derive(Component)]
struct Health(u32);

#[derive(Component)]
struct LuckyStart;

fn spawn_player(mut commands: Commands, player: Res<PlayerEntity>) {
    commands
        .entity(player.entity)
        .insert((Health(100), LuckyStart))
        /* ... */
       .with_query_filtered::<&mut Health, With<LuckyStart>>(|mut health| {
            // Players with the LuckyStart component start with double health.
            health.0 *= 2;
        });
}

I much prefer the solution proposed here, to implement EntityCommand for FnOnce(EntityMut):
https://github.com/bevyengine/bevy/pull/9544#issuecomment-1694355624

Ok so I've had a crack at implementing this but I've hit a usability road-block that I think I just need some advice on. Because EntityCommand is already implemented for FnOnce(Entity, &mut World), in order to implement it for FnOnce(EntityMut) as well, I think we need to add a level of indirection first.
What I tried was adding the following types:
struct EntityCommandFunction<F, Args> {
    f: F,
    _phantom: PhantomData<(F, Args)>,
}

trait IndirectEntityCommandFunction<Args> {
    fn apply(self, id: Entity, world: &mut World);
}

pub trait IntoEntityCommand<C: EntityCommand> {
    fn into_entity_command(self) -> C;
}

I can then implement EntityCommand for the indirect EntityCommandFunction type:
impl<F, Args> EntityCommand for EntityCommandFunction<F, Args>
where
    Args: Send + 'static,
    F: IndirectEntityCommandFunction<Args> + Send + 'static,
{
    fn apply(self, id: Entity, world: &mut World) {
        self.f.apply(id, world);
    }
}

Which would let me implement EntityCommand for two different function signatures:
impl<F> IndirectEntityCommandFunction<(Entity, &mut World)> for F
where
    F: FnOnce(Entity, &mut World) + Send + 'static,
{
    fn apply(self, id: Entity, world: &mut World) {
        self(id, world);
    }
}

impl<'w, F> IndirectEntityCommandFunction<EntityMut<'w>> for F
where
    F: FnOnce(EntityMut) + Send + 'static,
{
    fn apply(self, id: Entity, world: &mut World) {
        self(world.entity_mut(id));
    }
}

To then allow the .add(...) function to accept a closure which could become an entity command, I add the following From and Into implementations:
impl<T, C: EntityCommand> IntoEntityCommand<C> for T
where
    T: Into<C>,
{
    fn into_entity_command(self) -> C {
        self.into()
    }
}

impl<F, Args> From<F> for EntityCommandFunction<F, Args>
where
    Args: Send + 'static,
    F: IndirectEntityCommandFunction<Args> + Send + 'static,
{
    fn from(value: F) -> Self {
        Self {
            f: value,
            _phantom: PhantomData,
        }
    }
}

And modify .add(...) to accept anything that can become an EntityCommand:
pub fn add<C: EntityCommand>(&mut self, command: impl IntoEntityCommand<C>) -> &mut Self {
    let command = command.into_entity_command();
    self.commands.add(command.with_entity(self.entity));
    self
}

All this nonsense does preserve the current usage of .add(..) for concrete types that implement EntityCommand, but for closures, a type hint is required:
Commands::new(&mut command_queue, &world)
    .entity(entity)
    .add::<EntityCommandFunction<_, _>>(|id: Entity, world: &mut World| {
        /* no-op */
    })
    .add::<EntityCommandFunction<_, _>>(|mut entity: EntityMut| {
        let mut w = entity.get_mut::<W<u32>>().unwrap();
        w.0 *= 2;
    });

This all works, but I think that end result isn't very nice to use. I think the simpler option would be to just add an alternate signature for adding "arbitrary" closures as EntityCommands:
Commands::new(&mut command_queue, &world)
    .entity(entity)
    // One FnOnce signature can be cannon for this, so this preserves this fuinction
    .add(|id: Entity, world: &mut World| {
        /* no-op */
    })
    .add_function(|mut entity: EntityMut| {
        let mut w = entity.get_mut::<W<u32>>().unwrap();
        w.0 *= 2;
    })
    .add_function(|id: Entity, world: &mut World| {
        /* no-op */
    })
    .add_function(|id: Entity| {
        /* no-op */
    });

The problem with that is I think we've just looped back onto #9544 but with extra steps. Anyone have any suggestions?

Hmm. That indirection is quite unfortunate. I can see why it's needed: the conflicting blanket impls since it's technically possible for a single type to implement multiple Fn traits with different signatures :/
What if we had a dedicated method on EntityCommands? E.g.
impl EntityCommands<'w, 's> {
   fn mutate<F: FnOnce(EntityMut)>(&mut self, function: F) -> &mut Self
}

That avoids breaking anything, but should still preserve a nice API.

Hmm. That indirection is quite unfortunate. I can see why it's needed: the conflicting blanket impls since it's technically possible for a single type to implement multiple Fn traits with different signatures :/
What if we had a dedicated method on EntityCommands? E.g.
impl EntityCommands<'w, 's> {
   fn mutate<F: FnOnce(EntityMut)>(&mut self, function: F) -> &mut Self
}

That avoids breaking anything, but should still preserve a nice API.

I think that's the least-worst option. I'll make a PR for an implementation of this shortly. Just to spur discussion on naming:

mutate
add_mutation
add_entity_mutation
for_entity_mut

I personally like number 4, for_entity_mut, but I'm open to being told otherwise!


refactor: apply a workload Service instead of using juju created one

To avoid inconsistent behaviours, it is preferrable to apply and use a Service owned by the charm so it can be rendered as needed by the controller.

hi @DnPlas first, left a small comment second, can you explain what was the issue you were seeing? what is the problem this PR is trying to solve? I'm struggling to interpret that. Would be better if it is documented in an issue so we have a reference, wdyt?

The problem is that the Service created by juju will try to be used by two different Pods (the training operator charm and the training operator workload). This will cause inconsistencies like when we try to reach the metrics endpoint. We know that the training operator workload has it, but the charm doesn't, so sometimes trying to reach this endpoint will result in:
curl -v <IP_ADDRESS>:8080/metrics
*   Trying <IP_ADDRESS>:8080...
* connect to <IP_ADDRESS> port 8080 failed: Connection refused
* Failed to connect to <IP_ADDRESS> port 8080 after 0 ms: Connection refused
* Closing connection 0
curl: (7) Failed to connect to <IP_ADDRESS> port 8080 after 0 ms: Connection refused

To avoid having both Pods "fighting" over the same Service (which btw is not at all recommended, it goes against the logic of services), I'm proposing that the workload has its own.


Update free-courses-en.md

What does this PR do?
Add resource(s) | Remove resource(s) | Add info | Improve repo
Added https://www.datacamp.com/courses/free-introduction-to-r
For resources
Description
In this course, you will learn about the R console, basic data types, data frames, importing and exporting data, statistical analysis, and data visualization. No prior coding experience is required, and you will learn by doing, with hands-on exercises and projects throughout the course. By the end of the course, you will be able to write basic R code and use R to analyze and visualize data.
This course is ideal for beginners who want to learn R, and it is also a great resource for data scientists and statisticians who want to brush up on their R skills. The course is taught by experienced instructors, and it is self-paced, so you can learn at your own convenience.
Why is this valuable (or not)?
This is valuable because it teaches the basics of R in bite-sized pieces.
How do we know it's really free?
You can click on the link and sign for free to start the course for FREE!
For book lists, is it a book? For course lists, is it a course? etc.
It is a course.
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

"start the course for free" doesn't mean "the course is free". is the whole couse free???

This course is 100% free. I think they have the "Start for free" label because other courses are paid in this website. This is one of the free ones.


U-0015189 and U-0015188 are unable to be accessed/opened in PROD.

Describe the bug in current situation
When searching for these requests in Advanced Search, and selecting them, error thrown:
Private Zenhub Image
Unable to access these requests to open them.
Link bug to the User Story
Impact of this bug
Describe the impact, i.e. what the impact is, and number of users impacted.
Chance of Occurring (high/medium/low/very low)
Pre Conditions: which Env, any pre-requesites or assumptions to execute steps?
Steps to Reproduce
Steps to reproduce the behavior:

create request using submission form
verify identity using bc service card (can use idir or test login)
try to view unopened request in foi flow

Actual/ observed behaviour/ results
doesn't load
Expected behaviour
request should load
Screenshots/ Visual Reference/ Source
If applicable, add screenshots to help explain your problem. You an use screengrab.

So what happened here is they didn't receive an email to their inbox for one of the requests, and therefore, nothing was opened in AXIS. The applicant then reached out about the request, and they couldn't find a record of it in the inbox or AXIS. So they went into FOI Mod and searched for the unopened request to see if we received it and to get the request details (to create it in AXIS). When they tried to open it, the loading error occurred.
The email not being received has occurred in the past, but the error being able to view a request is new.

Working as expected now, and could access unopened requests in FOI Mod with birthdate populated.  Closing.


Documentation is already out of date

Describe the bug 📝
I am attempting to follow the documentation as closely as possible and there have been multiple instances where the documentation has been outright incorrect in regards to types and what is actually available.
Examples of instances of missing documented properties/methods:

components.scene.setup(), where setup() does not exist
components.renderer.postproduction.customEffects.outlineEnabled = true, where postproduction does not exist
The docs say for the highlighter to use highlighter.outlinesEnabled = true, where the actual call is highlighter.outlineEnabled = true.

With running into just these few variances, there have to be multiple more. The variance between the documentation and the actual types can get frustrating and if types are included, they should accurately describe available functionality, methods, and properties.
Reproduction ▶
No response
Steps to reproduce 🔢

Read the docs
Attempt to follow instructions exactly using a typescript project
Discover missing methods, properties.

System Info 💻
Node, Vite, Typescript, MacOS

Used Package Manager 📦
npm
Error Trace/Logs 📃
No response
Validations ✅

[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a IFC.js components issue and not a framework-specific issue. For example, if it's a THREE.js related bug, it should likely be reported to mrdoob/threejs instead.
[X] Check that this is a concrete bug. For Q&A join our Community.
[X] The provided reproduction is a minimal reproducible example of the bug.

There is a difference between component.scene and new OBC.SimpleScene(component)
component.scene return object from THREE.Scene.

The scene of three.js doesn´t have the method setup(). See https://github.com/mrdoob/three.js/blob/master/src/scenes/Scene.js
But OBC.SimpleScene has a method setup(). You can see at https://github.com/IFCjs/components/blob/main/src/core/SimpleScene/index.ts#L41.
To call the setup() from SimpleScene, it needs to break into 2 commands like this:
const myScene = new OBC.SimpleScene(components);
components.scene = myScene;
myScene.setup();

A similar is true for postproduction.
const rendererComponent = new OBC.PostproductionRenderer(component, viewerContainer)
rendererComponent.postproduction.enabled = true
component.renderer = rendererComponent


change chaos fanatic slayer task icon to match boss timers icon

Not sure how to assign this to myself... but I created a PR for it here: https://github.com/runelite/runelite/pull/8162


Add support for context specific tags

See  #29 for description

Hello,
In answer to your comments on #29, as it currently stands, this P/R can encode constructed or non-contrsucted objects (just have to pass false as the third argument to the ContextSpecificObject constructor).
However, when parsing back binary data, the reason I restricted it to constructed objects is that enabling parsing for non-constructed was breaking your X509 SAN tests. I did not have time to dig any deeper on the subject though.

I did some changes to your PR and merged this into master version 1.1.0.
When you try it out please note that I introduced one breaking change for all classes that inherit from \FG\ASN1\Object The getType function is no longer static but a real part of the Object interface.
In case you have classes inheriting from Object it should probably be enough to remove the static keyword in the function and make sure the function is only accessed in a non static way

Nice :) I'm always happy to see less static in code. I'll test your changes out on the ecc lib -- 1.1.0 means I can remove the context specific explicitely tagged object  implementation from there.


Fix: Shell scripts to pass shellcheck linter for sensor.sh and central.sh

Description

Fix shell scripts to pass Shellcheck linter for
deploy/k8s/sensor.sh
deploy/k8s/central.sh
deploy/openshift/central.sh
Checklist

[x] Investigated and inspected CI test results
[ ] Unit test and regression tests added [Does not apply]
[ ] Evaluated and added CHANGELOG entry if required [Does not apply]
[ ] Determined and documented upgrade steps [Does not apply]
[ ] Documented user facing changes (create PR based on [openshift/openshift-docs] Does not apply and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
CI pipeline is a sufficient indicator but tested by running make shell-style. It passed successfully.

/ok-to-test

@rachana-dani Style check still failing

@rachana-dani: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name	Commit	Details	Required	Rerun command
ci/prow/grouped-static-checks	d46ee71 link	true	/test grouped-static-checks
Full PR test history. Your PR dashboard.

Hey @janisz, I have excluded the file names from stylecheck_skip.txt and the grouped_static_checks are failing. This check is to see if files present in stylecheck_skip.txt don't have linting issues anymore. If none of the other tests are failing , why is this one failing?
Am I missing something? Can you please help me with this?

@rachana-dani: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name	Commit	Details	Required	Rerun command
ci/prow/grouped-static-checks	2202929 link	true	/test grouped-static-checks
Full PR test history. Your PR dashboard.

link

Hey @janisz , I have not made any changes to deploy/openshift/sensor.sh but yet somehow grouped_static_checks test is failing for me.
Please confirm if this is an issue? I don't think this is an expected behaviour?

/retest

@rachana-dani Could you rebase on master?

Please remove deploy/openshift/sensor.sh from the list as it's symlink to k8s/sensor.sh
deploy/openshift/sensor.sh -> ../k8s/sensor.sh

Thanks @janisz. @gavin-stackrox @tommartensen, can you please review this PR?

Thanks @janisz. @gavin-stackrox @tommartensen, can you please review this PR?

Hi @rachana-dani, thanks for the fix! It looks like @janisz has approved the PR and a single approver is sufficient to merge. Are you able to merge it?


Document clarifications

Hello again,
Thanks for providing ovn-scale-test. I believe it will bring a great value for the research community.
As a first time user of the tool, I faced some difficulties to install it and play with it. I think mostly due some ambiguity in the instructions.
These are some issues I faced and I think it will be helpful to add some text to clarify them:
1- Installing and running the code as a root.
The instructions doesn't say that you must download, install, and run the test as a root user. If you don't run as a root, you will find hard time figuring out why things go wrong.
2- ssh connections between hosts and and between containers and hosts.
This is also related to running as root. In ansible/group_vars/all.yml there is a variable "deploy_user" and the default is "rally". I was able to deploy but couldn't run any workload and was getting ssh failure errors because my machine was using the user name rally. I had to change it to "root" and everything worked after that.
3- Docker images.
It seems that docker images used for the emulated chassis are not up to date with ovs repository. Or, to be more specific, not in synchronization with the image used to build ovn-rally container. This caused a problem if the two images contain different versions of ovs commands.
4- Terminologies.

What is farm node? And why do I have to register them as it says here
"In addition, to register the hosts and sandboxes in the rally-ovs database, the create-sandbox task should be executed for individual farm nodes."
Is emulated chassis the same as sandbox?

5- What is the difference between a node that runs ovn-rally workload and one that runs rally container as mentioned here

@muradkablan thanks for these valuable feedback. I will update the document.

Adding to this thread,
Do you have instructions on how to create a workload? Which files need to be changed and/or added?
For example, if I want to create a new workload"create_and_connect_real_chassis.json"
Do I manually have to write that file and added to workload directory?

@muradkablan as I have updated ansible/README, can we close this issue now?

Yes. Thanks for the updated. I'll create an issue or update this one if I find anything needs to be clarified.


echonest: UnicodeDecodeError: 'ascii' codec can't decode byte

There appears to be a bug in the a way the echonest plugin handles Unicode.  It appears to be improperly trying to decode UTF as ASCII.  This appears to be a regression as this album imported successfully using the echonest plugin in v1.3.10.
This is the traceback of a crash during import:
Traceback (most recent call last):
  File "/usr/local/bin/beet", line 9, in <module>
    load_entry_point('beets==1.3.11', 'console_scripts', 'beet')()
  File "/usr/local/lib/python2.7/dist-packages/beets/ui/__init__.py", line 1081, in main
    _raw_main(args)
  File "/usr/local/lib/python2.7/dist-packages/beets/ui/__init__.py", line 1071, in _raw_main
    subcommand.func(lib, suboptions, subargs)
  File "/usr/local/lib/python2.7/dist-packages/beets/ui/commands.py", line 892, in import_func
    import_files(lib, paths, query)
  File "/usr/local/lib/python2.7/dist-packages/beets/ui/commands.py", line 869, in import_files
    session.run()
  File "/usr/local/lib/python2.7/dist-packages/beets/importer.py", line 316, in run
    pl.run_parallel(QUEUE_SIZE)
  File "/usr/local/lib/python2.7/dist-packages/beets/util/pipeline.py", line 301, in run
    out = self.coro.send(msg)
  File "/usr/local/lib/python2.7/dist-packages/beets/util/pipeline.py", line 183, in coro
    func(*(args + (task,)))
  File "/usr/local/lib/python2.7/dist-packages/beets/importer.py", line 1343, in plugin_stage
    func(session, task)
  File "/usr/local/lib/python2.7/dist-packages/beets/plugins.py", line 123, in wrapper
    return func(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/beetsplug/echonest.py", line 449, in imported
    song = self.fetch_song(item)
  File "/usr/local/lib/python2.7/dist-packages/beetsplug/echonest.py", line 406, in fetch_song
    song = method(item)
  File "/usr/local/lib/python2.7/dist-packages/beetsplug/echonest.py", line 344, in analyze
    prepared = self.prepare_upload(item)
  File "/usr/local/lib/python2.7/dist-packages/beetsplug/echonest.py", line 271, in prepare_upload
    tmp = source = self.convert(source)
  File "/usr/local/lib/python2.7/dist-packages/beetsplug/echonest.py", line 306, in convert
    util.command_output(opts)
  File "/usr/local/lib/python2.7/dist-packages/beets/util/__init__.py", line 653, in command_output
    cmd=b' '.join(cmd),
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 36: ordinal not in range(128)

Tested using beets version 1.3.11 on Raspberry Pi 2 B running Raspbian GNU/Linux 7 (wheezy) 3.18.7-v7+

The given command has unicode elements while they should all be byte strings, as per beets.util.command_output() docstring.

Nevermind about those, I found the problem: it's a 1-char change. Temp file path should be a byte string.
By the way I see that the function (convert()) in which this happens does something the Convert plugin does very well, maybe it should call the plugin. Thoughts, @sampsyo ?

Aha, good catch.
Yes, deduplicating the functionality between this and the convert plugin seems like a good plan. We'll need to be careful with cross-plugin imports, though (c.f. 0af2cdaa3a78493fa5483a8786b429e78cfe21fd, an approach that might also be appropriate here).


bug: When the API has an aspiration volume of 0uL, the OT-2 instead uses maximum pipette aspiration amount.

Overview
If you define aspiration volume as 0, then when simulating the protocol will output the maximum volume of the pipette.

Steps to reproduce
Try and aspirate 0 uL with a pipette.
Example with the GEN2 P300S
from opentrons import protocol_api

metadata = {'apiLevel': '2.8'}

def run(protocol: protocol_api.ProtocolContext):
    tr1 = protocol.load_labware('opentrons_96_tiprack_300ul', '1')
    p300_single = protocol.load_instrument('p300_single_gen2', 'left', tip_racks=[tr1])
    reservoir = protocol.load_labware('nest_12_reservoir_15ml', location='2')
    well = protocol.load_labware('opentrons_96_aluminumblock_nest_wellplate_100ul', location='4')
    p300_single.pick_up_tip()
    p300_single.aspirate(0,reservoir.wells()[0])
    p300_single.drop_tip()

`

Current behavior

Aspirates full volume. This happens in simulation with the GEN2 P300S and P300M as well as the GEN2 P1000S. I have run tests on the GEN2 P300S and P300M and they both aspirate full volume.

Expected behavior
Picking up tip from A1 of Opentrons 96 Tip Rack 300 µL on 1
Aspirating 0.0 uL from A1 of NEST 12 Well Reservoir 15 mL on 2 at 92.86 uL/sec
Dropping tip into A1 of Opentrons Fixed Trash on 12

The software should warn users if the aspiration volume is 0. Not blocking, but it should pop up to make sure that someone doesn't accidentally aspirate full volume.
Current work around
Put a very low value 0.0000001 or avoid aspirating 0uL.

@alexjoel42 FWIW this is documented behavior of aspirate: https://docs.opentrons.com/v2/new_protocol_api.html#opentrons.protocol_api.contexts.InstrumentContext.aspirate

volume (int or float) – The volume to aspirate, in microliters (µL). If 0 or unspecified, defaults to the highest volume possible with this pipette and its currently attached tip.

@alexjoel42 FWIW this is documented behavior of aspirate: https://docs.opentrons.com/v2/new_protocol_api.html#opentrons.protocol_api.contexts.InstrumentContext.aspirate

volume (int or float) – The volume to aspirate, in microliters (µL). If 0 or unspecified, defaults to the highest volume possible with this pipette and its currently attached tip.

Thanks for the speedy clarification. This makes sense + is documented. Might be worth talking about if this pops up more, but I have only seen it happen once in 7 or so months so I think we can close this.

Thanks for the speedy clarification. This makes sense + is documented. Might be worth talking about if this pops up more, but I have only seen it happen once in 7 or so months so I think we can close this.


Auth0Provider not sending client_id

Description

I'm using auth0/auth0-react and trying to follow Complete Guide to React User Authentication With Auth0.  When I try to implement the LoginButton component and test, I get an error that the client_id is missing.

Reproduction

Steps taken are as close as possible to your tutorial with the exception that this is not a "from scratch" project.  I am trying to modify ArchitectUI, a popular dashboard React template project.  I am following the tutorial up to the point of creating a Login/Logout Button component and testing that the user is forwarded to Auth0 for authentication.  I also made sure to configure the domain, client_id, and audience properties for the Auth0Provider component.

Log entry from dashboard
{
"date": "2020-07-14T22:55:59.867Z",
"type": "f",
"description": "Missing required parameter: client_id",
"connection_id": "",
"ip": "",
"user_agent": "Chrome 83.0.4103 / Windows 10.0.0",
"details": {
"body": {},
"qs": {
"audience": "",
"scope": "openid profile email",
"response_type": "code",
"response_mode": "query",
"state": "",
"nonce": "",
"code_challenge": "",
"code_challenge_method": "S256",
"auth0Client": ""
},
"error": {
"message": "Missing required parameter: client_id",
"oauthError": "invalid_request",
"type": "request-error"
},
"session_id": "****************"
},
"hostname": "",
"auth0_client": {
"name": "auth0-react",
"version": "1.0.0"
},
"log_id": "**********************",
"_id": "**********************************************************",
"isMobile": false
}
Error

Environment

auth0/auth0-react 1.0
React 16.12.0
react-router-dom 5.1
ArchitectUI React template project Project link
Win10, VS Code

Hi @jdsilva-scopesec
Couple of things to check:
Make sure your clientId is being loaded from the environment variables, so after assigning clientId log it to the console and check it is defined.
const clientId = process.env.REACT_APP_AUTH0_CLIENT_ID;
console.log('clientId', clientId)

Make sure you're passing clientId to the provider (not client_id)
<Auth0Provider
      clientId={clientId} <==
      ...
    >
    {children}
</Auth0Provider>

If you're still getting Missing required parameter: client_id please share your code or a running link to your app

Thanks @adamjmcgrath.  It seems I had incorrect parameter names in setting up the provider component.  I have also followed the recommendations for HashRouter in the examples as my project uses that type of router.

Great - glad it's working for you now


Add Issue templates to improve issue management

Closes #1
I borrowed them from the PowerShell team and rewrote them a bit.

Thanks @Manbearpiet


Can't compile specific ESP-IDF commit

I'll preface this by saying I'm not sure if this is an issue for this crate or embuild.
I've been using branch:release/v4.4 for a while, but recently they seem to have had a breaking change that I need to roll back in my project. I saw that the commit:<hash> syntax was supported for specifying the ESP-IDF version (in Cargo.toml), so I decided to use that. Here is the entry I'm using:
[package.metadata.esp-idf-sys]
esp_idf_version = "commit:9c384419163bdb94e3f7211540a7ae31c6a7cf11"

It seems to correctly clone the repository and checks out the appropriate commit, but has the wrong version of submodules (likely recursively cloning them from master and then checking out the specified commit in the main repo, but without rolling the submodules back to the correct versions for said commit). On top of this, I get the following error:
  Note: switching to '9c384419163bdb94e3f7211540a7ae31c6a7cf11'.

  You are in 'detached HEAD' state. You can look around, make experimental
  changes and commit them, and you can discard any commits you make in this
  state without impacting any branches by switching back to a branch.

  If you want to create a new branch to retain commits you create, you may
  do so (now or later) by using -c with the switch command. Example:

    git switch -c <new-branch-name>

  Or undo this operation with:

    git switch -

  Turn off this advice by setting config variable advice.detachedHead to false

  HEAD is now at 9c38441916 Merge branch 'bugfix/fix_sc_send_failure_and_exit_issue_v4.4' into 'release/v4.4'

  [notice] A new release of pip is available: 23.0.1 -> 23.1.2
  [notice] To update, run: python -m pip install --upgrade pip
  Using esp-idf v4.4.4 at '/home/devin/Desktop/netsblox-vm-esp32/.embuild/espressif/esp-idf/9c384419163bdb94e3f7211540a7ae31c6a7cf11'
  fatal: no tag exactly matches '9c384419163bdb94e3f7211540a7ae31c6a7cf11'
  Error: command 'LANGUAGE="" LC_ALL="C.UTF-8" "git" "--git-dir" "/home/devin/Desktop/netsblox-vm-esp32/.embuild/espressif/esp-idf/9c384419163bdb94e3f7211540a7ae31c6a7cf11/.git" "--work-tree" "/home/devin/Desktop/netsblox-vm-esp32/.embuild/espressif/esp-idf/9c384419163bdb94e3f7211540a7ae31c6a7cf11" "describe" "--all" "--exact-match"' exited with non-zero status code 128

  Caused by:
      fatal: no tag exactly matches '9c384419163bdb94e3f7211540a7ae31c6a7cf11'

Is there a way to fix both of these issues? I think a workaround would be to fork the ESP-IDF repository, add a new branch at the commit I want, and use branch selectors instead (which seem to work fine and only check out the single commit they refer to). I'll try that now, but ideally a commit reference to the official repo would also work.

All supported official release from ESP-IDF from v4.4.7 up to v5.2.2 should work. Using the release/v.4.4 is discouraged as you see its not stable. Using fully taged version like ESP_IDF_VERSION ="v4.4.7" should always work and you don't have to have the headache of upstream breakage.
The last time i tested to use individual commits it worked for me. Though you have to be careful that the commit is not around a ESP_IDF version boundary. In upstream they often back port stuff or have otherwise divergent branches that could lead to potential problems described here, but i don't know how actionable it is to fix that for us since its a pretty niche use-case. I don't say its invalid use-case but i don't think its worthwhile to go to deep here.
That's why i am closing this for now. If someone still runs into this issue please feel free to add to this issue, than i will reopen it, or just create a new one. Thanks!


Add file globbing to iotables.py

A bug exists somewhere that prevents iotables.py from processing large pcaps.  One workaround has been to rotate the pcaps frequently.
iotnetworklab:~ $ sudo tcpdump -n -s 0 -G 600 -w "nest-%s.pcap"

This results in many pcaps needing analysis, but iotables.py only processes one pcap at a time.  Add file globbing so that all pcaps can be processed in one go.

File globbing is now handled.  Multiple globs of pcaps can be passed as command line arguments.
$ python iotables.py -d Sonos sonos3-*.pcap sonos5-*.pcap

The globs are properly expanded and each file is processed.


Autocomplete shortcut.

Can I specify keyboard shortcut to trigger autocomplete menu, for example ctrl+space?

Not at the moment. There's an existing issue for this here: #1830


V4 https://api.spacexdata.com/v4/launches/1 details is not working!

Hi, i was testing the api. Version 3 works fine. Version 4 also working fine. But i have found scenario in version 4.
https://api.spacexdata.com/v4/launches these works but the details
https://api.spacexdata.com/v4/launches/1
parameter with (rocket number) is not working.
Could you please check ?

I assume you're passed flight number but you need to pass the id of the launch for example: 5eb87cd9ffd86e000604b32a.

I assume you're passed flight number but you need to pass the id of the launch for example: 5eb87cd9ffd86e000604b32a.

@PatrykWojcieszak oh..
Previous version 3 used this , right https://api.spacexdata.com/v3/launches/{flightNumber}`
Now you expect rocket id, right ?

@PatrykWojcieszak oh..
Previous version 3 used this , right https://api.spacexdata.com/v3/launches/{flightNumber}`
Now you expect rocket id, right ?

@jams032 you need to use id of the launch you want to get data of. The URL looks like this:
URL : https://api.spacexdata.com/v4/launches/:id
URL Parameters : id=[string] where id is the ID of the launch
Check docs for getting single launch: Single launch
or to query launches: Query launches

@jams032 you need to use id of the launch you want to get data of. The URL looks like this:
URL : https://api.spacexdata.com/v4/launches/:id
URL Parameters : id=[string] where id is the ID of the launch
Check docs for getting single launch: Single launch
or to query launches: Query launches

https://api.spacexdata.com/v4/launches/5e9d0d95eda69973a809d1ec
Do you mean this to access for single launch? I can't access this.
But i can access this : https://api.spacexdata.com/v4/rockets/5e9d0d95eda69973a809d1ec
Please, correct me if am doing any wrong.

https://api.spacexdata.com/v4/launches/5e9d0d95eda69973a809d1ec
Do you mean this to access for single launch? I can't access this.
But i can access this : https://api.spacexdata.com/v4/rockets/5e9d0d95eda69973a809d1ec
Please, correct me if am doing any wrong.

@jams032 If you want to get data of specific launch you need to use this URL https://api.spacexdata.com/v4/launches/:id.
But you need to use launch id not rocket id.

@jams032 If you want to get data of specific launch you need to use this URL https://api.spacexdata.com/v4/launches/:id.
But you need to use launch id not rocket id.


To change Audio language in website.

If the video have multiple language audio how to select in the video player. If this feature is implemented then i would be glad. Because for most of video if i click on external player it doesn't work. So that i have to stick to default language it self. In external player the error will be Your input can't be opened: VLC is unable to open the MRL.

Not possible, browsers don't support video containers, which is what you are talking about.


Can we get sandbox deployment instructions for OSX as well?

https://github.com/microsoft/iomt-fhir/blob/master/docs/Sandbox.md works for Windows users how about Mac and Linux?

@bookofdom I believe that the instructions assumes that you are running for within a powershell console, which is available for installation in Mac and Linux as well.


Add Json writer for cp2077-nativedb

Custom AST Json writer to be used with webapp cp2077-nativedb.

Thanks! Overall looks good but I have few questions:

Could you please tell me the difference between this and JsonWriter.hpp?
I see that you use one letter for the AST, could you explain why one letters instead of the fully name?

1. Could you please tell me the difference between this and [JsonWriter.hpp](https://github.com/WopsS/RED4.RTTIDumper/blob/master/src/Writers/JsonWriter.hpp)?

Flags are "compressed" such as only known bits / used bits in web app are stored in Json. It writes primitive types / template types as numbers too. It also writes definitions in grouped files (enums.json / bitfields.json / classes.json / globals.json) so only a few files are requested in web app.

2. I see that you use one letter for the AST, could you explain why one letters instead of the fully name?

I believe that reusing identical names improves compression ratio, as it should provide a minimum of different symbols, resulting in a smaller memory footprint (e.g. 10MB to 800KB with Brotli).

Ah, I see. Thank you for the explanation!


Bindable page size

Is there a way to change the page size with binding so I can have a drop down with different options

Hello @Joebu
you mean that you have separate dropdown component with numubers which is connected to the page size of the grid?

correct
<select @bind="@PageSize">         <option value="25">25</option>         <option value="50">50</option>         <option value="100">100</option>     </select> <GridView     PageSize="@PageSize"></GridView>

@Joebu
There is problem this can be done only for the first time whne you create the grid because, after the paramteres are set and TableDataSet object is created, every parameter change is not applicated. I will think how to do this works for these kind of scenarios. Whole problem is in OnParametersSetAsync method which have some checks which not affect grid

@Joebu
Version 0.11.0 contains new feature and will help solve your problem. See the wiki


Y-Scale on totals histogram.

You want a y-axis?

Maybe just a top line number indicating what the max is? I guess we could leave it off since we have the roll over quantities?

My preference is to be as minimal as possible but making sure things make sense. I think we can leave this axis off in the same way we don't have a areal legend for the state sizes.

I can dig it.


A UI for Wolf

This has been discussed already many times over a few places (https://github.com/games-on-whales/wolf/issues/69#issuecomment-2094133261 https://github.com/games-on-whales/wolf/issues/44) and it's getting more and more clear that we need a UI for Wolf. The main goals are:

Configuration: We need an easy way to configure Wolf without editing the config file.
Sharing: Allow users to share a game session with multiple users (instead of making completely isolated sessions
as we are doing right now).
Monitoring: Allow users to see what's the status of the game session (ex: "Downloading docker image", "Container
died", etc.)
Usability: This GUI has to be controllable by keyboard and mouse, whilst at the same time should be usable in a TV
screen even just with a gamepad.

Implementation
I think our "dream solution" here would have:

Ability to run multithreaded directly inside Wolf so that each user will have its own UI state, and we can show what's
happening even before the app container is started.
A way to easily communicate bidirectionally with Wolf (status reports, configuration changes, etc.)

An easy way to inject mouse, keyboard and joypad events without going through the system

Expose direct access to the raw framebuffer where the UI is rendered so that we can feed it directly into the video
encoding pipeline.
(optionally) An easy way to build the UI, possibly noob friendly like HTML+CSS+JS.

I've been looking around for something like this and I think the best candidate is Sciter, more specifically the windowless version of Sciter: Sciter.Lite
There are some examples:

render to OpenGL
render to Bitmap (uses CPU rasterization)

The nice thing is that it seems to tick all the boxes above, the only concern is that it's not open source, and it's not free (albeit just for commercial use which shouldn't concern us). Is there any other alternative that we should consider?

Otherwise, we could just run any normal GUI toolkit (GTK, Qt, Electron, etc.) in a separate process inside the Wolf container, hook it up with our Wayland comp, and communicate with it via a socket or something. This would be a lot more complex and
less efficient, but it would be open source and free.

@ABeltramo, not sure if the above implies this but I would also suggest a rudimentary auth solution with 2 roles, admin and user. User would be able to login and pair devices and this would allow sharing of installed games between paired devices. Admin would do that and the aforementioned config / monitoring.
Also haven't read in depth of Sciter but are you intending for this to be a webapp or desktop app... just first few things I read it looks look as it uses mostly web languages but seems like its to dev desktop app

not sure if the above implies this but I would also suggest a rudimentary auth solution with 2 roles, admin and user. User would be able to login and pair devices and this would allow sharing of installed games between paired devices. Admin would do that and the aforementioned config / monitoring.

Yep proper user management will definitely be added. First we'll have to plug everything together though..

Also haven't read in depth of Sciter but are you intending for this to be a webapp or desktop app... just first few things I read it looks look as it uses mostly web languages but seems like its to dev desktop app

The idea here is that Sciter will allow Wolf to render mutliple GUIs, ideally one per user/session without even having a Desktop and without requiring the user to jump over a browser (which might not be possible on some Moonlight platforms, like TVs/handelds ..).
Everything will be rendered inside Moonlight and controlled with the same mouse/kb/joypad devices.
Ideally this UI will also be easily developed by using the same frameworks as any webapp so that anyone can easily contribute!

This sounds interesting, look forward to seeing it in action.

I was digging around a bit looking to see if it would be possible to use electron for the UI to simply (maybe?) development and contributing and ran into this PR that I'm linking incase anyone finds it useful: https://github.com/electron/electron/pull/42001
Although the PR is marked as closed, it appears to be under active development by the author.

Thanks for the pointer!
I've quickly skimmed thru it, but I can't quite figure out if electron supports running multiple instances from the same process or is it using global state like most of the other solutions? It would be nice to use a fully open source project instead of Sciter, it just seems like such a perfect fit for this use case..

Thanks for the pointer! I've quickly skimmed thru it, but I can't quite figure out if electron supports running multiple instances from the same process or is it using global state like most of the other solutions? It would be nice to use a fully open source project instead of Sciter, it just seems like such a perfect fit for this use case..

I agree Sciter seems to be a great technical fit and would likely be very performant.
Digging a bit deeper on the electron side it does appear you can create multiple windows from the same process: https://jasonsturges.medium.com/multiple-window-electron-app-9dbffde8ce95

I'll dig into this some more and let you know if it goes anywhere

I am curious, is the "dream solution" going to allow users to stream without moonlight?
This is where I was wondering why we would need Electron or Sciter, Why not just use raw HTML, CSS, and JS?
I  might be missing something here I guess.

I am curious, is the "dream solution" going to allow users to stream without moonlight?
This is where I was wondering why we would need Electron or Sciter, Why not just use raw HTML, CSS, and JS?
I might be missing something here I guess.

Happy to be corrected, but I think it's this point which is steering the Sciter / electron discussion:

Expose direct access to the raw framebuffer where the UI is rendered so that we can feed it directly into the video
encoding pipeline.

Both Sciter and electron (maybe) are a way to generate a framebuffer that can be mixed into the existing wolf stream to overlay the UI.

But I dont understand why UI needs to be rendered(or generate raw framebuffer) instead of having traditional Rest APIs and client web pages.

It's actually fairly simple, not every Moonlight client has browser support! Think of TVs, handhelds (Switch, 3DS, PSP), etc. Having our custom UI rendering in Moonlight will allow us to instantly support every client. Also, the flow will not be very smooth right? You have to switch back and forth from the browser to Moonlight, or even worse: pickup your phone to access the browser because you can't do that from your TV!
On top of that you get joypad/remotes support for free via Moonlight because we can't assume that a mouse and keyboard will always be available to navigate the web UI.
This "UI" is still a tad up in the air, we were discussing this just earlier today with @shocklateboy92 and @salty2011 in a call; I think we are going to approach this in a series of steps:
Step 1: expose an API for Wolf
I'm working on it here: https://github.com/games-on-whales/wolf/pull/101
The idea is that we'll expose all the events that are currently powering Wolf over a Linux socket. The type of events and what would be possible it's not yet flashed out but ideally most of the Wolf components will be available over it, ex:

Moonlight pair requests
Audio/Video encoding and pipelines
Virtual devices: joypads, mouse, keyboard, pen, etc.

All this stuff would be initially just to listen for those events when Moonlight clients trigger them but potentially we can also allow applications to trigger them without any Moonlight session. Ex: create a virtual joystick and send inputs from a different application; start a video pipeline that you can view from VLC...
Step 2: create an "admin" web UI
Working on it here: https://github.com/games-on-whales/wolf/pull/105 (but possibly moving it to a separate dedicated project page)
Very early day and needs to be fleshed out, but ideally this would allow you to manage and pair Moonlight clients (without going through the logs), change the settings (without manually editing the config.toml), see the logs...
This will communicate with Wolf via the API created in Step 1 and expose a web UI.
Step 3: create a "user/running" UI
This is what this issue was originally talking about and what I'd really like to build.
In my head the flow is as follows:

You connect via Moonlight to Wolf
From there you pick up a single app that it's available
Wolf starts the stream, instead of running the Docker apps straight away it instead shows a UI (you'll be able to navigate the UI both with mouse and keyboard and joypads all via Moonlight)

It opens up as a netflix-like list of users:

If you pick another user that is running something you can join the session and play together (or even just watch)
Otherwise, you pick another user and it just show a list of apps; same as it is right now in Moonlight and it'll eventually start the app that you pick there
In both cases, when a selection has been made Wolf will switch the video/audio sources in the pipeline from the UI to the actual Docker container running.

It's an intermediary step compared to what we have at the moment so that we can properly support users.
Now, the dream solution is that this UI renders directly in Wolf; this way we don't have to run a Desktop, an additional Docker container and all that stuff that can fail, but we can provide feedback directly to the users.
But, that turns out to be more complicated than expected. So I'm leaning towards a more simple approach: let's just run a fullscreen browser or an Electron app that shows this UI and communicates with Wolf via the APIs. We can build all that and still re-use everything if we ever want to actually embed it in Wolf without the additional container + browser.
I hope this helps clarify it a bit, feel free to share feedback and ideas; they are very welcome!

Yup, it does clarify, Now I understand. Thank you. Super excited for this.

Quick status update: in https://github.com/games-on-whales/wolf/pull/101 I've added a fully functional REST API, you can see the docs for it.
The plan now is to start having fun with Electron (or similar) and build the actual user UI that will then trigger stuff via the Wolf socket..
Stay tuned! :wink:

I spent an afternoon looking at open source ighter weight options (something similar to Sciter) and found egui (rust) https://github.com/emilk/egui/tree/master
Most of the integrations seem to support rendering to a window, which defeats the point of it being lightweight for the purposes of wolf. The skia I integrations https://github.com/lucasmerlin/egui_skia has an example that can render to an image while also being headless, which seems closer to what you are after?
Then there is the whole issue of it being written in rust rather than cpp. From an API perspective you have solved that issue :) but I'm guessing there would also need to be some gstreamer integration that would be a touch point between rust and cpp?

Thanks for looking into it, I think I'm really going to keep it simple to get the ball rolling.
We have a Wayland compositor already, I'll just install Electron in the Wolf container and fire it up when the session starts. Then, via the APIs, the Electron UI can control additional apps, and I'll just swap the "main focused" window from our comp to the newly started app.
I'm going to try to keep it simple this time, we can always overcomplicate things later (as usual).

Thanks for looking into it, I think I'm really going to keep it simple to get the ball rolling.
We have a Wayland compositor already, I'll just install Electron in the Wolf container and fire it up when the session starts. Then, via the APIs, the Electron UI can control additional apps, and I'll just swap the "main focused" window from our comp to the newly started app.
I'm going to try to keep it simple this time, we can always overcomplicate things later (as usual).

Yep, makes sense!


TensorFlow cannot detect my GPU

when I run my code, I found it didn't use the GPU, and just used the CPU.
I check the tf and tf-gpu version is same. my system info as following:
Cuda version (nvcc --version result)
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2018 NVIDIA Corporation
Built on Sat_Aug_25_21:08:01_CDT_2018
Cuda compilation tools, release 10.0, V10.0.130

tf version :
tensorboard          1.14.0
tensorflow           1.14.0
tensorflow-estimator 1.14.0
tensorflow-gpu       1.14.0

other info:
python version: Python 3.6.8
OS version: Ubuntu 16.04.5
kernel version: 4.4.0-131-generic

GPU model and memory (nvidia-smi result)
ps: GPU 1~3 using by pytorch.
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 410.104      Driver Version: 410.104      CUDA Version: 10.0     |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|===============================+======================+======================|
|   0  Tesla V100-PCIE...  On   | 00000000:3D:00.0 Off |                    0 |
| N/A   33C    P0    26W / 250W |      0MiB / 32480MiB |      0%      Default |
+-------------------------------+----------------------+----------------------+
|   1  Tesla V100-PCIE...  On   | 00000000:42:00.0 Off |                    0 |
| N/A   60C    P0   219W / 250W |  13324MiB / 32480MiB |     99%      Default |
+-------------------------------+----------------------+----------------------+
|   2  Tesla V100-PCIE...  On   | 00000000:B1:00.0 Off |                    0 |
| N/A   61C    P0   225W / 250W |  13770MiB / 32480MiB |     99%      Default |
+-------------------------------+----------------------+----------------------+
|   3  Tesla V100-PCIE...  On   | 00000000:B5:00.0 Off |                    0 |
| N/A   61C    P0   222W / 250W |  13392MiB / 32480MiB |     99%      Default |

Installed using virtualenv? yes, use pyenv
when I use following command, and just have the cpu, not exist GPU.
from tensorflow.python.client import device_lib
print(device_lib.list_local_devices())

@Donald-Su, Could you check by installing tenosrflow-gpu==1.14.0. still the error persists or not. Thanks!

@gadagashwini this time I uninstall all the tensorflow* (include tensorboard  and tensorflow-estimator), and install tf-gpu use pip3 install tensorflow-gpu==1.14.0 again. And It's working now. thanks~
Is the reason not uninstall tensorboard  and tensorflow-estimator before It can't use GPU ?


MNT: Move tuners to subpackages

As discussed internally.
Description
All tuners now live in a sub-directory consisting of multiple modules. The
directory structure, e.g. for LoRA, looks like this:
src/peft/tuners
└── lora
    ├── __init__.py
    ├── bnb.py
    ├── config.py
    ├── gptq.py
    ├── layer.py
    └── model.py

Note that I moved the quantized layers, bnb and gptq, to their own respective
modules.
Regarding the changes, no code was actually changed, just moved around. The only
minor change I made was to use absolute imports instead of relative imports,
except for the local files in the same directory:
# instead of this
from ...import_utils import is_bnb_4bit_available
from ..tuners_utils import BaseTuner
from .config import LoraConfig

# do this
from peft.import_utils import is_bnb_4bit_available
from peft.tuners.tuners_utils import BaseTuner
from .config import LoraConfig

To repeat some of the pros and cos we discussed:

more structure
smaller files
if we have to do it eventually, the earlier the better

is a bit of work
messes with git history (git blame)

AFAICT, it does not actually resolve any circular dependency issues.
For some existing modules, the license comment of the top of the file
was missing, I always added it.
Comments
Note that GitHub shows some diffs as movements and some as completely new files.
Not much that we can do about it. This makes review a bit harder but all tuners
were treated the same, only the diff is shown differently.
Also note that only files inside of peft/tuners/ were changed, all the rest is
still the same. In particular, no imports were changed anywhere else. This
should (hopefully) mean that the changes are completely backwards compatible.

I don't think that all methods need to have the exact same structure, only when it makes sense. So your suggestion would be an option.
Also, given some recent issues, we could investigate if moving the bnb layers (and imports) to a submodule could help.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@pacman100 @younesbelkada I finished the PR and it's now ready for a proper review. The original description has been updated to reflect that. Ideally, we can proceed fast with this PR, as it can easily cause merge conflicts.

@pacman100 @younesbelkada
Okay, so I merged the changes from #851 and at the same time fixed a bug and wrote a test for it. As shortly discussed internally, the bug that was introduced is for the case that the model is merged AND adapters are disabled. For that scenario, we need to unmerge first before generating the output, same as we do for the vanilla Linear layer. This step was missing from the code previously.
To catch this bug, I extended the tests to include a test case with merging + disabling. This test fails with the current code but passes with the bugfix.
Moreover, I had to make the tests more precise. So far, they were checking the generated token IDs, but that's very imprecise. On the other hand, checking the logits is also not nice, since they can deviate quite a lot because of the rounding errors. Instead, I'm now checking in probability space, where we can see differences, but the rounding error does not affect them too much.
Unfortunately, this still requires a bit of fiddling with tolerances, and I'm not sure if the ones I found on my machine will generalize. Therefore, it would be really good if you could check the changes. Basically, running pytest tests/ -k "test_4bit_merge and lora" should succeed. On the other hand, we can just go ahead, merge, and see if the nightly GPU tests pass with the given tolerances.


go test: include calens

Why wait 2-3m after you create PR to get the message, when you can (CONTRIBUTING.md: running all tests) go test ./... locally.

Abandoning this for now. Feel free to close, low priority.
Summary of what I tried doing:
changelog/testing.go → changelog/changelog_test.go (unsure if this is the right location/name/etc):
package changelog
import (
    "testing"
    "os/exec" // not in path
    "github.com/restic/calens" // not work
)

func TestChangelog(t *testing.T) {
//    cmd := exec.Command("calens")
//    if err := cmd.Run(); err != nil {
//        t.Fatal(err)
//    }

    go run github.com/restic/calens // ..?
}

After the first is a program, not an importable package, I thought requiring it in go.mod would bring it to path for os executable. I tried, but after searching for over 10m, didn't find a way to execute another external go program without making a mess.
Probably, calens would need to be turned in to a package.

The changelog entry errors are rare enough that it's probably not worth the trouble. Closing this for now.


allow mixing IPV4 and IPV6 CIDR blocks for the AWS ALB

Description
Allow mixing IPV4 and IPV6 CIDR blocks for the AWS ALB.
Motivation and Context
Github started using IPv6 addresses.
If Atlantis is configured to allow GitHub IPs (via alb_ingress_cidr_blocks using "github" provider), terraform would fail with the following error:
Error: Error authorizing security group rule type ingress: InvalidParameterValue: CIDR block 2606:50c0::/32 is malformed

Breaking Changes
No breaking changes.
How Has This Been Tested?
Tested manually using mixed range of IPv6 and IPv4 addresses.

This issue has been resolved in version 3.15.0 :tada:


Load dependencies automatically

Suppose I have a .dll named "Test.dll", it references a .dll in the same folder named "Test2.dll".
Then it should be enough that I include "Test.dll" as a dependency, it should automatically also include "Test2.dll". So it is currently impossible for me to include large projects including all dependencies out-of-the-box, because I would have to enter every single dependency in the script. How can I solve this?

Mhm, a feature request could be to allow folder imports
for example
#r ".\Dependencies*.dll"


[#124] Reset package revision number

yes.   # it.

both.

we've seen it build and run in docker.


Cleanups before internal testing

Some cleanups for the tutorial

LGTM with some suggestions.

Thanks a lot. You implemented all suggestion by yourself, right? Or are there suggestions open?


Get grpc error in tensorflow Java API.

What version of gRPC and what language are you using?
JAVA
What operating system (Linux, Windows,...) and version?
MacOS
What runtime / compiler are you using (e.g. python version or version of gcc)
What did you do?
Please provide either 1) A unit test for reproducing the bug or 2) Specific steps for us to follow to reproduce the bug. If there’s not enough information to debug the problem, gRPC team may close the issue at their discretion. You’re welcome to re-open the issue once you have a reproduction.
I run tensorflow java api to load model in flink cluster, it works fine the first time. But When I run the job the second time in cluster, it turns out to be an error like below:
What did you expect to see?
What did you see instead?
[libprotobuf ERROR external/protobuf_archive/src/google/protobuf/descriptor_database.cc:58] File already exists in database: tensorflow/core/protobuf/eager_service.proto
[libprotobuf FATAL external/protobuf_archive/src/google/protobuf/descriptor.cc:1358] CHECK failed: GeneratedDatabase()->Add(encoded_file_descriptor, size):
libc++abi.dylib: terminating with uncaught exception of type google::protobuf::FatalException: CHECK failed: GeneratedDatabase()->Add(encoded_file_descriptor, size):
Describe the expected behavior
Make sure you include information that can help us debug (full error message, exception listing, stack trace, logs).
See TROUBLESHOOTING.md for how to diagnose problems better.
Anything else we should know about your project / environment?

Please file a complete issue report. You may need to go to https://github.com/grpc/grpc-java


Will scripts for scannet released soon ?

Great Work!
I note that experiment on scannet is mentioned in the paper, will you release scripts for scannet in the future ?

Hi, we conducted depth experiments on scannet based on the codebase of UniMatch, and the view synthsis experiments were not performed on scannet.

Hi, we conducted depth experiments on scannet based on the codebase of UniMatch, and the view synthsis experiments were not performed on scannet.

I see, thanks !
But I am still wondering if depthsplat is able to synthetize new view and reconstruct the whole scene on scannet.

This is an interesting question, feel free to train/evaluate our model on scannet (kindly check https://github.com/cvg/depthsplat/blob/main/DATASETS.md for data preparation). Thanks.

This is an interesting question, feel free to train/evaluate our model on scannet (kindly check https://github.com/cvg/depthsplat/blob/main/DATASETS.md for data preparation). Thanks.

OK, I will try it !


Remove unconventional location for header files

This PR is an alternative approach to #49.
The rationale for this solution is that moving the file, instead of aliasing it, is a much simpler approach and it makes the code base use a more conventional inclusion pattern. While having sub-directories within include and including headers with `-include('my_dir/my_header.hrl') technically works in OTP, it's a non conventional choice that makes it harder to include the file from external applications. Tools such as Erlang LS may require additional tweaking by the user to get code navigation and other features working with the code base, too.
Breaking backward compatibility is probably not a big deal in this case, given that the header file was explicitly marked as internal in the previous implementation. Making the move explicit would also allow users to immediately spot (and correct) the difference at compile time and take the opportunity to cleanup extra paths and directories in their configuration which were only present due to the current setup. So, it feels like a step in the right direction.

I opened this PR to realize immediately after you already have https://github.com/yakaz/yamerl/pull/49 as an alternative solution. Let me check if that works for our use case...

@dumbbell Any opinion on this?

Coverage remained the same at 77.564% when pulling 9a9f7a2e84554992f2e8e08a8060bfe97776a5b7 on erlang-ls:avoid-internal-includes into 39981b9cb9d9edc227cf43a3e19dd16869493553 on yakaz:master.

I agree with you, the breakage should be ok.


[SPARK 24424][SQL] Support ANSI-SQL compliant syntax for GROUPING SET

What changes were proposed in this pull request?
Enhances the parser and analyzer to support ANSI compliant syntax for GROUPING SET. As part of this change we derive the grouping expressions from user supplied groupings in the grouping sets clause.
SELECT c1, c2, max(c3)
FROM t1
GROUP BY GROUPING SETS ((c1), (c1, c2))

How was this patch tested?
Added tests in SQLQueryTestSuite and ResolveGroupingAnalyticsSuite.
Please review http://spark.apache.org/contributing.html before opening a pull request.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1111/
Test PASSed.

Test build #93260 has started for PR 21813 at commit b5ada3f.

Test build #93260 has finished for PR 21813 at commit b5ada3f.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93260/
Test FAILed.

retest this please

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1116/
Test PASSed.

Merged build finished. Test PASSed.

Test build #93266 has started for PR 21813 at commit b5ada3f.

Test build #93266 has finished for PR 21813 at commit b5ada3f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93266/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1136/
Test PASSed.

Test build #93291 has started for PR 21813 at commit ac8f04f.

Test build #93291 has finished for PR 21813 at commit ac8f04f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93291/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1141/
Test PASSed.

Test build #93299 has started for PR 21813 at commit 7cf187d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1145/
Test PASSed.

Test build #93304 has started for PR 21813 at commit e0c57f7.

Test build #93299 has finished for PR 21813 at commit 7cf187d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93299/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1152/
Test PASSed.

Test build #93313 has started for PR 21813 at commit 2ecf3e1.

Test build #93304 has finished for PR 21813 at commit e0c57f7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93304/
Test PASSed.

Merged build finished. Test PASSed.

Test build #93313 has finished for PR 21813 at commit 2ecf3e1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93313/
Test PASSed.

Thanks! Merged to master.

Thank you very much @gatorsmile @viirya


Wi-Fi networks with WPA3 are not supported

Wi-Fi networks using only the WPA3 security protocol are showing the 🚫 symbol next to them, and cannot be joined.

The Qualcomm 845 does seem to support WPA3 at a hardware level. (Source: XDA Developers)
Discord user nelsonjchen said the missing Security Flag might be "NM_802_11_AP_SEC_KEY_MGMT_SAE". (Link to post)

See the network "DingoAteYourBaby" in the attached screenshot, which is only using WPA3. The IOT network current connected, has the exact same settings, on the same Access Point, except it is using WPA2.

https://github.com/commaai/openpilot/blob/f6398ea7864779f621f84df65ded7ee083e72c09/selfdrive/ui/qt/offroad/wifiManager.cc#L141
Probably just needs an extra flag added here.
I would also say this issue probably only applies to networks with WPA3 only.

Great, want to open a PR and test it?

I am by no means a developer, but I did fork and add the flag in both networkmanager.h & wifiManager.cc.
https://github.com/TheOfficialJosh/openpilot/tree/wifi-wpa3
It sees the network and allows me to type in the password, but it does not actually connect.

Tested with two different Wi-Fi networks using only WPA3. It only saves the password, but never connects. Going to guess there's something more than these two lines.
Is there a log file I can provide to help with figuring it out?

I can replicate this on my comma three, and looking at the system logs doesn't give much information. I think we might just have to update the network manager package, which is already on the latest release available in apt for Ubuntu 20.04/agnos...

We build ModemManager from source, might have to do the same for NetworkManager.


mariadb failed to build on 0

https://gist.github.com/c3c5716675e4424f31b23b0decc7c95d

please ignore this issue, wrong repo


move the job seeding to before the bestie deployment

we should check for successful completion of 1) the postgres cluster creation and 2) the seed job in the deployment sub reconciler..

The database seeding job checks waits for postgres to come up. The deployment should check and wait for successful completion of the seed job.


Unable to connect to simulated m2 reader on Tap To Pay for iOS (reader id is null)

I'm trying to implement Stripe Tap To Pay feature on my React Native app. I'm testing on a simulator. When I call discoverReaders I get the list of simulated readers but none of them has id. Since reader id seems to be required for my next call connectLocalMobileReader, it is not able to connect to the reader
I get the following response with discoveryReader: 'localMobile'
didUpdateDiscoveredReaders [{"availableUpdate": null, "batteryLevel": null, "batteryStatus": "unknown", "deviceSoftwareVersion": null, "deviceType": "appleBuiltIn", "id": null, "ipAddress": null, "isCharging": null, "label": null, "location": {"address": [Object], "displayName": "Stripe HQ", "id": "st_simulated", "livemode": false}, "locationId": "st_simulated", "locationStatus": "set", "serialNumber": "APPLEBUILTINSIMULATOR-1", "simulated": false, "status": "offline"}]
I get the following response with discoveryReader: 'bluetoothScan' (I believe I'm supposed to use bluetoothScan)
[{"availableUpdate": null, "batteryLevel": null, "batteryStatus": "unknown", "deviceSoftwareVersion": null, "deviceType": "chipper2X", "id": null, "ipAddress": null, "isCharging": null, "label": null, "location": {"address": [Object], "displayName": "Stripe HQ", "id": "st_simulated", "livemode": false}, "locationId": "st_simulated", "locationStatus": "set", "serialNumber": "CHB20SIMULATOR2", "simulated": true, "status": "offline"}, {"availableUpdate": null, "batteryLevel": null, "batteryStatus": "unknown", "deviceSoftwareVersion": null, "deviceType": "wisePad3", "id": null, "ipAddress": null, "isCharging": null, "label": null, "location": {"address": [Object], "displayName": "Stripe HQ", "id": "st_simulated", "livemode": false}, "locationId": "st_simulated", "locationStatus": "set", "serialNumber": "WPC32SIMULATOR1", "simulated": true, "status": "offline"}, {"availableUpdate": null, "batteryLevel": null, "batteryStatus": "unknown", "deviceSoftwareVersion": null, "deviceType": "stripeM2", "id": null, "ipAddress": null, "isCharging": null, "label": null, "location": {"address": [Object], "displayName": "Stripe HQ", "id": "st_simulated", "livemode": false}, "locationId": "st_simulated", "locationStatus": "set", "serialNumber": "STRM2SIMULATOR1", "simulated": true, "status": "offline"}]
Here is my code:
const {initialize} = useStripeTerminal();
useEffect(() => {
initialize()
},[])
const { discoverReaders, connectedReader, discoveredReaders } =
useStripeTerminal({
onUpdateDiscoveredReaders: (readers) => {
console.log('readers >>>>>>>>>>>>>> ', readers)
setReaders(readers[2]);
},
});
useEffect(() => {
setTimeout(() => {
if(isInitialized){
handleDiscoverReaders();
}
},3000);
}, [discoverReaders]);
const handleDiscoverReaders = async () => {
const {error, readers: discoveredReaders} = await discoverReaders({
discoveryMethod:  'bluetoothScan',//'internet', //'localMobile',
simulated: true,
});
console.log(error, '===');
};
iOS version: 17.2
Stripe version: ^0.0.1-beta.15
Not sure if this is a bug or I'm missing something. Please let me know.
Thanks.

For the connection call you pass the full reader object returned from the discover call, see example: https://github.com/stripe/stripe-terminal-react-native/blob/7535dd89/dev-app/src/screens/DiscoverReadersScreen.tsx#L221-L225
This in general is more integration support than SDK bug, for those reaching out to<EMAIL_ADDRESS>will get the fastest response

Okay great. Thanks a lot. Will try that out. If you could also update the Stripe Doc which still refers to the reader.id that would be great.
https://docs.stripe.com/terminal/payments/connect-reader?terminal-sdk-platform=react-native&reader-type=simulated
const handleConnectBluetoothReader = async (id) => {
const { reader, error } = await connectBluetoothReader({
readerId: discoveredReaders[0].id,
// Since the simulated reader is not associated with a real location, we recommend
// specifying its existing mock location.
locationId: discoveredReaders[0].locationId,
});


Feature: SwiftUI text-based snapshot testing

I would very much prefer a text based "recursiveDescription" of SwiftUI hierarchy. Even if I pull all my business logic out into a Store/Reducer/State, I still have branch logic within the Views.
Personal preference is to exclude frame rects. Just the hierarchy and properties where possible.
I have no suggestion for what this should look like, but here is an issue to track the discussion/progress.

I've also posted on Swift Forums: https://forums.swift.org/t/swiftui-debugdescription/39099

Does this do anything for you?
assertSnapshot(matching: view, as: .dump)

This is also something I'd be interested in, have you tested the approach you are suggesting @darknoon ?

dump doesn't seem to work. I have tried and I only see a description of the store, which takes forever and has a lock and pointer properties that change on every run.

I'm going to convert this to a discussion for further collaboration. We'd definitely be interested in a strategy here! We want to keep issues focussed on bugs, though.


IoT Central sample for Nano RP2040 Connect

Ports ArduinoMqttClient into MQTT interface functions.
Changes return dependency of MQTT interface functions in framework (RESULT_OK/ERROR instead of packet id).
Exposes current time function for user to define.
Updates device data for Nano RP2040 Connect
Uses %2F for client user agent
Adds readme with updated pictures from IoT Central

Note, I don't know the tool to make the screen shots look better (like the others with the cool shadow). Please feel free to edit them!


fix: match type any

What/Why/How?
Fixes missing match for type: any.
Reference
Fixes #785
Testing
Added tests for the method.
Check yourself
I think there is an issue with the prettier config. I did not include the prettier run here as it adjusted so many files and seems also out of date with the current code style in some places.

[ ] Code is linted
[ ] Tested with redoc/reference-docs/workflows
[x] All new/updated code is covered with tests

Security

[x] Security impact of change has been considered
[x] Code follows company security practices and guidelines

This one is invalid, but adding tests was a good idea. I did that in #789 so this one can be closed.


Override state badge color

Based on https://github.com/junalmeida/homeassistant-minimalistic-area-card/pull/104
I'll rebase it when the first one gets merged.
Original commit message:
Allow to override color.
Examples:
Based on state values:
- entity: binary_sensor.main_door_opening
  icon: mdi:door
  state:
      - value: 'on'
        color: green
        icon: mdi:door-open
      - value: 'off'
        color: red
        icon: mdi:door

On entity:
- entity: light.stairs_leds
  icon: mdi:stairs
  color: blue
  tap_action:
      action: more-info

State value settings has higher priority

yes +1 it will be relly nice to change the color and icon on stat changes

@kareemkhalil I'm not sure if my PR will ever be merged. It looks like the original repo is dying, but you can use my fork if you want this type (or more) of functionality.

Thank you Lukas, i used your fork and it is working well 👍 i also star it
thank you for you work
On Sat, 7 Sept 2024, 7:37 pm Lukas Drbal, @.***> wrote:

@kareemkhalil https://github.com/kareemkhalil I'm not sure if my PR
will ever be merged. It looks like the original repo is dying, but you can
use my fork if you want this type (or more) of functionality.
—
Reply to this email directly, view it on GitHub
https://github.com/junalmeida/homeassistant-minimalistic-area-card/pull/105#issuecomment-2335874556,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADKCWKOJFKQDIQSJGVR4BB3ZVMTULAVCNFSM6AAAAABLJCJRRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZVHA3TINJVGY
.
You are receiving this because you were mentioned.Message ID:
<junalmeida/homeassistant-minimalistic-area-card/pull/105/c2335874556@
github.com>

ping

closing in favor of https://github.com/LesTR/homeassistant-minimalistic-area-card/issues/128


Henry throw glitch

It flew all the way to the other screen.
It flew all the way to the other screen.
It flew all the way to the other screen.
It flew all the way to the other screen.

lootdrop saves the day again


Productivity tracker

v1.2: Set up parser for command to track productivity in a day, show default image for productivity level.
v1.3: Add options to track productivity in a week/month. Update imagery to be responsive and show the different levels of productivity.

v1.3 Jelphabot criticism and compliment as encouragement when % of tasks completed


Re-enable tests disabled during LLVM integrate

The LLVM bump here results in some failures related to iree_linalgext_tile op. Specifically,
[build]   IREE_DIALECTS :: Dialect/iree_linalg_ext/roundtrip.mlir
[build]   IREE_DIALECTS :: Dialect/iree_linalg_ext/tile-to-in-parallel.mlir
[build]   IREE_DIALECTS :: Dialect/iree_linalg_ext/tile-to-sequential-for.mlir
[build]   IREE_DIALECTS :: Dialect/linalg_transform/vectorize.mlir

Disabling those for now to land the integrate.

Can you link to the latest failure logs you were seeing? Maybe these? https://source.cloud.google.com/results/invocations/0e821087-dd32-4e93-a848-8ba6262284fe/targets/iree%2Fgcp_ubuntu%2Fcmake%2Flinux%2Fx86-swiftshader-asan%2Fpresubmit/log
I see two ASan failures and one lit test failure in that ^
Note that the ASan build has asserts disabled, so you might need to make lit tests robust against debug being enabled or disabled, like in https://github.com/google/iree/pull/9023/commits/c3e46da64f1d8bec7c68dd16000d460f81c1d2a8

[build]   IREE_DIALECTS :: Dialect/linalg_transform/vectorize.mlir

is interesting since it is failing locally for me but passing on CI

The above fixes the LinalgExt tests, I do not yet have a repro for the Asan bug.


[Feature Request / Question] Search Params at the Layout Level

Hi There!
Thanks for tackeling this problem! Really cool way of approaching it and giving ownership 🙌 Also thank you for all the time on your videos too; Learnt so much over the years!

I have a use case that I wondered if there was already a way to support or if there was any desire to do so? 🤔
In some cases you may want to add a Search Param that can be used anywhere below a certain level in the routing tree, and not sure how to handle this.
For example if you have a client side Modal that you include in layout.tsx at the root level, say to show Notifications ,and it's open state were stored in the URL search params of any route below it like /profile/edit?showNotifications=true or /?showNotifications=true it would be cool to be able to merge that possible search param into all type definitions for routes underneath.
This may take the form of being able to add a layout.info.ts file that defines shared params for the routes below it? Or would there be a better way to handle this?

(p.s. also aware there may be a different way of approaching the example using intercepting routes server side too but I'm actually less of a fan of the modal client side, full page on bare URL navigation convention for some use cases... Maybe some more learning required for me!)

I think you can accomplish this with zod.merge. Have you shared search param schema stored in globally accessible module. Then zod.merge it into each route that has those shared search parameters, along with whatever unique search params the route has. And if it doesn't have any, then just use those global search params straight.

Yep - Figured I could do it manually editing each page.info.ts (using .merge) but means you have to remember to add it to each new page added etc as the default build step would be oblivious.
Was wondering if there was a better way but guess it would add a new level of complexity to the library having to know about a hierarchy...

I'd be ok with adding a level of complexity to get the hierarchal nature of the routes... if it was for more than just this one use case.

I'll have more of a think too, but one to see if others were interested in too then!!
How do you go about telling - Is it worth keeping open and looking for +1's in the form of up votes, or happy to see if people find it in closed?

Sure. Thumbs up the original comment and if we get a bunch we can do it. Though the how would come only after we have some more use cases. So if folks could also comment with other use cases for hierarchal routing that would be great.
Also, are we talking about NextJS, React-Router, or Qwik? Please don't say "all" unless you mean that. What is your specific platform that you are writing in?

For my case it is Only for Next.js I'm working in! 👍


Move console plugin to end

Not sure why I decided to put the console plugin as the first plugin, especially now that we can specify a new one it doesn't make a lot of sense.
Having it at the end allows other plugins to edit the content of the files (for example running black) before they are written on disk.

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

This release moves the console plugin for the codegen command
to be last one, allowing to run code before writing files to
disk.

Here's the preview release card for twitter:

Here's the tweet text:
🆕 Release (next) is out! Thanks to @patrick91 for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)


fix not login and run a cloudImage will failed

fix not login and run a cloudImage will failed
Does this pull request fix one issue?

Describe how you did it
Describe how to verify it
Special notes for reviews

LGTM  @justadogistaken


Allow for custom content in head

I use non-Google analytics (Matomo) and I also have a bunch of IndieWeb items (webmention endpoint, etc.) that belong at the end of the <head> element. Is there a way to include these without editing head.html itself? If not, can there be?

In the latest commit, I add custom head support.
How to use it ?

Create a file named custom_head.html under your site ./layouts/partials/ folder.
Add your 'custom head' to custom_head.html

What do you think about this way? :smiley:

This works perfectly for me, thank you!

It's 100% dome, could it be closed?

@paskal There is nothing in file partial "custom_head.html" .
In my opinion, it doesn't matter if you don't need custom head.

I mean the issue is complete, I had a typo:) Sorry!