reduce CPU usage

After this patch, go-peerstream no longer shows up as a CPU hog.
I would have liked to have removed groups entirely but peerstream doesn't understand the concept of peer IDs so we need some form of general-purpose grouping/tagging mechanism. However, we can, and probably should, get rid of groups on streams and listeners to reduce complexity.

Whoops. Maybe reviewing code on my phone isn't the best idea
On Fri, Oct 13, 2017, 10:25 AM Jakub Sztandera<EMAIL_ADDRESS>wrote:

@Kubuxu commented on this pull request.
In swarm.go
https://github.com/libp2p/go-peerstream/pull/13#discussion_r144505375:

func (s *Swarm) ConnsWithGroup(g Group) []*Conn {
s.connLock.RLock()
conns := make([]*Conn, 0, 1)

for c := range s.conns {

if c.InGroup(g) {

	conns = append(conns, c)

}

for c := range s.connIdx[g] {

conns = append(conns, c)

I would change it to:
cs := c.connIdx[g]conns := make([]*Conn, len(cs))copy(conns, cs)
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/libp2p/go-peerstream/pull/13#pullrequestreview-69171000,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABL4HDOM3ir2h7_KyUSkcpMcbU2ld1knks5sryx7gaJpZM4P3ugv
.

It definitely isn't tested enough (and I should have known better because I fixed at least one "this can't have worked" bugs while working on this...).

"never too small to have bugs" (especially when you turn off the type system and use interface{}).

@Kubuxu can I get another review of this (with my changes)? I managed to introduce too many nasty bugs to trust myself.

I would feel  more confident if we had more than 30% code coverage here: https://ipfs.io/ipfs/QmcAxXjVHqRsLJ5p7sBLyQMp7UPR98qHsSnbX9DgEWacn2#file0

@whyrusleeping I've added quite a few more tests (53.2% coverage). Unfortunately, we still don't have any tests covering listeners.


Added endpoint to get facts (#3437)

Pull request opened by the merge tool on behalf of #3437

Merged into branches iso4 in f27d3569e14b995fcf60e4ec31db4985c2656c6e


[aznude] Add new extractor

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[ ] Improvement
[x] New extractor
[ ] New feature

Description of your pull request and other information
Adds a new extractor for aznude.com. The site hosts sex scenes from movies. Since the clips are quite short, I believe they fall under Fair Use. Plus, they comply with DMCA requests (see here).

@dstftw I've updated the extractor as per your suggestions. Please take a look now.

@dstftw Do we need to make further changes to the extractor?

Read my comments on what you should fix.

@dstftw I have fixed them all. Kindly take another look.

You did not, at least not in this branch: code duplication not fixed, url_prefix not removed in favor of urlojoin.

@DirkGiggler  @dstftw  Any news?

@dstftw Hey, sorry for abandoning the PR. I have updated the extractor and rebased my branch. I have also used this extractor for these past years now without any issues. The main addition I have had to make is that of checking for the lightbox attribute in the anchor tag. It seems to be a good way to distinguish the actual content from the (newly added) recommended content. Anyway, I request you to review the latest code. Thanks! :)


[FEATURE] Players should "see" dealer's first card that's face-up

Is your feature request related to a problem? Please describe.
In Blackjack, players get to see the dealer's first card, which affects decision-making (plays into risk levels of cards player has in hand).  Currently, the setup is for players & dealer to play completely independently, then compare results to determine win.
Describe the solution you'd like
When player making decisions (hit, stand, etc), they can see dealer's first card
Could just have dealer play before players and only show results to players after they play their hand.  Need to consider, though, if there are any "naturals" (i.e. blackjack or 21)
The way I understand the game flow is shown in screenshot in "Additional Context" below.  Flow chart I created from info here: https://bicyclecards.com/how-to-play/blackjack/
Describe alternatives you've considered
Rahul's initial suggestion from our conversation:

after initialising the Table you can use dealer.hand property which will return a list of the cards of the dealer and then you can continue with the players’ choices.

Additional context

To match other examples, this will need to be implemented as a page in the wiki


FAIL: Expected 5 config types for node but got only []

Hi
please I need help with this one
I am having a problem running sgadmin.sh

elasticsearch 2.3.5
search-guard-2 <IP_ADDRESS>
search-guard-ssl <IP_ADDRESS>

elasticsearch:
searchguard.authcz.admin_dn:
- CN=sgadmin
  searchguard.ssl.transport.http.enforce_clientauth: false
  searchguard.ssl.transport.enabled: true
  searchguard.ssl.transport.keystore_filepath: localhost-keystore.jks
  searchguard.ssl.transport.keystore_password: August2016
  searchguard.ssl.transport.truststore_filepath: truststore.jks
  searchguard.ssl.transport.truststore_password: August2016
  searchguard.ssl.transport.enforce_hostname_verification: true
  searchguard.ssl.transport.resolve_hostname: true
  searchguard.ssl.http.enabled: true
  searchguard.ssl.http.keystore_filepath: localhost-keystore.jks
  searchguard.ssl.http.keystore_password: August2016
  searchguard.ssl.http.truststore_filepath: truststore.jks
  searchguard.ssl.http.truststore_password: August2016
  searchguard.ssl.transport.enable_openssl_if_available: true
  searchguard.ssl.http.enable_openssl_if_available: true

Will connect to localhost:9300 ... done
Contacting elasticsearch cluster 'elasticsearch' and wait for YELLOW clusterstate ...
Clustername: elasticsearch
Clusterstate: YELLOW
Number of nodes: 1
Number of data nodes: 1
searchguard index does not exists, attempt to create it ... done
Populate config from /usr/share/elasticsearch/plugins/search-guard-2/sgconfig
Will update 'config' with plugins/search-guard-2/sgconfig/sg_config.yml
SUCC: Configuration for 'config' created or updated
Will update 'roles' with plugins/search-guard-2/sgconfig/sg_roles.yml
SUCC: Configuration for 'roles' created or updated
Will update 'rolesmapping' with plugins/search-guard-2/sgconfig/sg_roles_mapping.yml
SUCC: Configuration for 'rolesmapping' created or updated
Will update 'internalusers' with plugins/search-guard-2/sgconfig/sg_internal_users.yml
SUCC: Configuration for 'internalusers' created or updated
Will update 'actiongroups' with plugins/search-guard-2/sgconfig/sg_action_groups.yml
SUCC: Configuration for 'actiongroups' created or updated
FAIL: Expected 5 config types for node 4EdmSODQRJ-mBc_eWrRF-g but got only []
Done with failures
Thank you
B

Can you pls provide the following infos:

Operating system vendor and version
Do you run elasticsearch within a cloud environment (aws, ...)
Java version and vendor
Complete elasticsearch logfiles (every node) on DEBUG level (from elasticsearch start until sgadmin is finished/fails)

Seems to be a duplicate or at least related to https://github.com/floragunncom/search-guard/issues/182

Hi,
Thank you for your fast reply and for your help.
OS X El Capitan 10.11.4
bento/centos-6.7
openjdk version "1.8.0_101"
OpenJDK Runtime Environment (build 1.8.0_101-b13)
OpenJDK 64-Bit Server VM (build 25.101-b13, mixed mode)
elasticsearch.log.zip
Thanks
B

Hi,
Thanks for fast reply and for your help!
OS X El Capitan 10.11.4
bento/centos-6.7
openjdk version "1.8.0_101"
OpenJDK Runtime Environment (build 1.8.0_101-b13)
OpenJDK 64-Bit Server VM (build 25.101-b13, mixed mode)
Thanks
B
On Thu, Aug 25, 2016 at 8:26 AM, floragunn UG<EMAIL_ADDRESS>wrote:

Can you pls provide the following infos:

Operating system vendor and version
Do you run elasticsearch within a cloud environment (aws, ...)
Java version and vendor
Complete elasticsearch logfiles (every node) on DEBUG level (from
elasticsearch start until sgadmin is finished/fails)

Seems to be a duplicate or at least related to #182
https://github.com/floragunncom/search-guard/issues/182
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/floragunncom/search-guard/issues/203#issuecomment-242302793,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARFBzrrYY_4GxORwnEUcTylNEhqPUV05ks5qjUO5gaJpZM4Jsd2h
.

Seems we found the issue but we cannot reproduce the issue locally so we kindly ask you if you can test https://oss.sonatype.org/content/repositories/snapshots/com/floragunn/search-guard-2/<IP_ADDRESS>-SNAPSHOT/search-guard-2-<IP_ADDRESS>-20160826.200736-47.zip and report back if the problem persists or is gone. It was likely a nasty threading issue. Thanks in advance.

Fixed (in master).


Develop DOI Service User Guide and Training

💡 Description

[ ] write PDS DN user guide @jordanpadams
[ ] prepare a 'mandatory training' for DN users @jordanpadams
[ ] communicate username/password and pds-gamma service to DN users for tests/training @jordanpadams
[ ] present / get feedback from users at a DOI WG @jordanpadams

📆 May status: delayed until end of build due to A&A documentation tasks. No impact on build.

📆 June status: Start delayed 1 sprint to support other documentation work. Low priority task not required for B14.0 delivery.

📆 July status: In work. On schedule.

📆 August status: Deferring due to lack of time to work on this. No impact on delivery to I&T. Will be worked in parallel with I&T and will be needed for delivery in December.

📆 02/2024 status: Deferring due to other priorities. Blocked by bugs in DOI Editor, so this information is not needed at this time.


Update or Parameterize Azure OpenAI Service preview API Version to Prevent Future Deprecation Issue

I've noticed that in the current implementation, the API version for the AsyncAzureOpenAI client is hard-coded as "2023-07-01-preview" :
 # Store on app.config for later use inside requests
        openai_client = AsyncAzureOpenAI(
            api_version="2023-07-01-preview",
            azure_endpoint=endpoint,
            azure_ad_token_provider=token_provider)

To prevent potential issues from using retiring Azure OpenAI API versions, it's important to update the code to use version 2024-02-15-preview or newer by 2 April 2024. Link
I have created a pull request that outlines two possibilities:
PR for updating the hardcoded API version: Link to PR 1399
PR for defining the API version as an environment variable: Link to PR 1397
This issue is for a: (mark with an x)
- [ ] bug report -> please search issues before submitting
- [x] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Thanks for the fix, closing!


fix: 3490 - now accepting not cropped new pictures

Impacted files:

image_crop_page.dart: told the CropPage we're dealing with a brand new picture
new_crop_page.dart: new bool parameter brandNewPicture used when saving the picture; refactored the debug lines
product_image_viewer.dart: told the CropPage we're dealing with an already existing picture

What

Dealing differently with brand new and already existing pictures.

Fixes bug(s)

Fixes: #3490

Codecov Report

Merging #3524 (adf4f66) into develop (d61ca4b) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #3524      +/-   ##
===========================================
+ Coverage    11.05%   11.07%   +0.01%
===========================================
  Files          262      262
  Lines        12978    12955      -23
===========================================
  Hits          1435     1435
+ Misses       11543    11520      -23

Impacted Files
Coverage Δ

packages/smooth_app/lib/pages/image_crop_page.dart
0.00% <ø> (ø)

...th_app/lib/pages/product/product_image_viewer.dart
0.00% <ø> (ø)

...s/smooth_app/lib/tmp_crop_image/new_crop_page.dart
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

I had no way to test but that should be good now!
Sorry for that bug!


Allow Boundary Extractor to accept empty boundaries

orimarko (Bug 63775):
Sometimes I want to get values without using boundaries, For example to extract only values from property file
I don't want to use regular expression, which is heavier on performance
I suggest allowing empty left/right boundaries to enhance faster extraction of response without defining one or both boundaries
First ask
https://stackoverflow.com/questions/50811528/jmeter-boundary-extractor-where-right-boundary-is-end-of-line
OS: All

I would like to share the way to set the Right boundary to the end of the line sign (LF, CRLF). It should be an ASCII representation like:
${__char(10)}
For Windows-style (CRLF) ${__char(13)}${__char(10)}


Multiple separate/non-chained aggregations in one query?

Hey guys,
We're trying out Heroic in addition to a few other databases. Both KairosDB and OpenTSDB have the functionality to make multiple aggregations in the same query, and return them as separate result sets.
More specific, is it possible to fetch the min/avg/max for a given metric, without sending 3 separate queries?
Any input appreciated. Thanks!

Thanks, just tried it out - works great!
For the multiple aggregations enhancement, the easiest(?) solution might be to add support for multiple queries instead. So instead of sending one JSON query object, I can pass an array of query objects. In that case the response would just be an array with the different result sets.

I've added documentation about our batch endpoint: http://spotify.github.io/heroic/#!/docs/api/post-query-batch
Do keep in mind that batches are much more inefficient than spreads for your use-case, since the data will still have to be fetched multiple times from the metric backend.


Broken link for Event Loop and Microtasks

Hi, link for Event Loop and Microtasks is broken; shold be:  https://jakearchibald.com/2015/tasks-microtasks-queues-and-schedules/

thanks! fixed in https://github.com/lrlna/sketchin/commit/de0e0d109794f4a14cbd3d5a42e9931350b51969


filter measurements without countries

Remove measurements which don't have a country.
If the country code is null it means we weren't able to get an AS/country for the IP from the CAIDA data. That's something we should fix in the pipeline, but it's meaningless to dashboard users and adds noise.
Currently we have 17mil measurements with null country codes (over all time) or .5% of the total data.

Is it worth it to maybe try and grab some of these geolocations from other sources? But then without the AS, they may not be useful anyway.

I think we can get both country and AS information from other sources like Maxmind or DBIP. How exactly to integrate multiple sources is a larger piece of work.


Add responsive grid system to Meta Pattern Library

Description
Add responsive grid system to Meta Pattern Library. Currently the Pattern Library stretches full width.

Done.


HDFS-14718. HttpFS: Sort response by key names as WebHDFS does

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
47
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1079
trunk passed

+1
compile
21
trunk passed

+1
checkstyle
16
trunk passed

+1
mvnsite
30
trunk passed

+1
shadedclient
675
branch has no errors when building and testing our client artifacts.

+1
javadoc
18
trunk passed

0
spotbugs
35
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
34
trunk passed

_ Patch Compile Tests _

+1
mvninstall
20
the patch passed

+1
compile
16
the patch passed

+1
javac
16
the patch passed

-0
checkstyle
18
hadoop-hdfs-project/hadoop-hdfs-httpfs: The patch generated 4 new + 42 unchanged - 4 fixed = 46 total (was 46)

+1
mvnsite
24
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
706
patch has no errors when building and testing our client artifacts.

+1
javadoc
15
the patch passed

+1
findbugs
38
the patch passed

_ Other Tests _

+1
unit
262
hadoop-hdfs-httpfs in the patch passed.

+1
asflicense
26
The patch does not generate ASF License warnings.

3155

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1270/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1270

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 8c0a2f3179b2 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 9b8359b

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1270/1/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1270/1/testReport/

Max. process+thread count
620 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1270/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
66
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1083
trunk passed

+1
compile
23
trunk passed

+1
checkstyle
15
trunk passed

+1
mvnsite
29
trunk passed

+1
shadedclient
665
branch has no errors when building and testing our client artifacts.

+1
javadoc
22
trunk passed

0
spotbugs
37
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
36
trunk passed

_ Patch Compile Tests _

+1
mvninstall
19
the patch passed

+1
compile
18
the patch passed

+1
javac
18
the patch passed

-0
checkstyle
12
hadoop-hdfs-project/hadoop-hdfs-httpfs: The patch generated 4 new + 42 unchanged - 4 fixed = 46 total (was 46)

+1
mvnsite
24
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
721
patch has no errors when building and testing our client artifacts.

+1
javadoc
17
the patch passed

+1
findbugs
44
the patch passed

_ Other Tests _

+1
unit
286
hadoop-hdfs-httpfs in the patch passed.

+1
asflicense
28
The patch does not generate ASF License warnings.

3221

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1270/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1270

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux e429fe79a7b9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 6244502

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1270/2/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1270/2/testReport/

Max. process+thread count
616 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1270/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
106
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1366
trunk passed

+1
compile
32
trunk passed

+1
checkstyle
27
trunk passed

+1
mvnsite
43
trunk passed

+1
shadedclient
942
branch has no errors when building and testing our client artifacts.

+1
javadoc
26
trunk passed

0
spotbugs
53
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
51
trunk passed

_ Patch Compile Tests _

+1
mvninstall
26
the patch passed

+1
compile
20
the patch passed

+1
javac
20
the patch passed

-0
checkstyle
17
hadoop-hdfs-project/hadoop-hdfs-httpfs: The patch generated 4 new + 42 unchanged - 4 fixed = 46 total (was 46)

+1
mvnsite
30
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
873
patch has no errors when building and testing our client artifacts.

+1
javadoc
20
the patch passed

+1
findbugs
47
the patch passed

_ Other Tests _

+1
unit
290
hadoop-hdfs-httpfs in the patch passed.

+1
asflicense
31
The patch does not generate ASF License warnings.

4064

Subsystem
Report/Notes

Docker
Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1270/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1270

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux e091ff9f41e6 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / ee7c261

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1270/3/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1270/3/testReport/

Max. process+thread count
610 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1270/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
33
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1252
trunk passed

+1
compile
23
trunk passed

+1
checkstyle
22
trunk passed

+1
mvnsite
31
trunk passed

+1
shadedclient
799
branch has no errors when building and testing our client artifacts.

+1
javadoc
23
trunk passed

0
spotbugs
44
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
41
trunk passed

_ Patch Compile Tests _

+1
mvninstall
23
the patch passed

+1
compile
19
the patch passed

+1
javac
19
the patch passed

-0
checkstyle
16
hadoop-hdfs-project/hadoop-hdfs-httpfs: The patch generated 4 new + 42 unchanged - 4 fixed = 46 total (was 46)

+1
mvnsite
27
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
823
patch has no errors when building and testing our client artifacts.

+1
javadoc
20
the patch passed

+1
findbugs
56
the patch passed

_ Other Tests _

+1
unit
296
hadoop-hdfs-httpfs in the patch passed.

+1
asflicense
31
The patch does not generate ASF License warnings.

3656

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1270/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1270

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 5d3fa81bfa75 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 3329257

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1270/4/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1270/4/testReport/

Max. process+thread count
609 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1270/4/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
44
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1102
trunk passed

+1
compile
26
trunk passed

+1
checkstyle
21
trunk passed

+1
mvnsite
33
trunk passed

+1
shadedclient
716
branch has no errors when building and testing our client artifacts.

+1
javadoc
24
trunk passed

0
spotbugs
46
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
44
trunk passed

_ Patch Compile Tests _

+1
mvninstall
23
the patch passed

+1
compile
21
the patch passed

+1
javac
21
the patch passed

-0
checkstyle
16
hadoop-hdfs-project/hadoop-hdfs-httpfs: The patch generated 4 new + 42 unchanged - 4 fixed = 46 total (was 46)

+1
mvnsite
29
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
768
patch has no errors when building and testing our client artifacts.

+1
javadoc
21
the patch passed

+1
findbugs
47
the patch passed

_ Other Tests _

+1
unit
281
hadoop-hdfs-httpfs in the patch passed.

+1
asflicense
34
The patch does not generate ASF License warnings.

3377

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1270/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1270

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 9697a1ae48b2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 915cbc9

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1270/5/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1270/5/testReport/

Max. process+thread count
624 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1270/5/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
20m 10s
trunk passed

+1 :green_heart:
compile
0m 29s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
0m 26s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
checkstyle
0m 23s
trunk passed

+1 :green_heart:
mvnsite
0m 34s
trunk passed

+1 :green_heart:
shadedclient
14m 47s
branch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 26s
hadoop-hdfs-httpfs in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

+1 :green_heart:
javadoc
0m 26s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+0 :ok:
spotbugs
0m 40s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 39s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 31s
the patch passed

+1 :green_heart:
compile
0m 23s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
0m 23s
the patch passed

+1 :green_heart:
compile
0m 20s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
javac
0m 20s
the patch passed

-0 :warning:
checkstyle
0m 15s
hadoop-hdfs-project/hadoop-hdfs-httpfs: The patch generated 4 new + 43 unchanged - 4 fixed = 47 total (was 47)

+1 :green_heart:
mvnsite
0m 29s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
13m 42s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 23s
hadoop-hdfs-httpfs in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

+1 :green_heart:
javadoc
0m 19s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
findbugs
0m 48s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
5m 10s
hadoop-hdfs-httpfs in the patch passed.

+1 :green_heart:
asflicense
0m 31s
The patch does not generate ASF License warnings.

64m 36s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1270/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1270

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 9022e3aeaa26 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e756fe35909

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1270/3/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-httpfs-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1270/3/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1270/3/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-httpfs-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1270/3/testReport/

Max. process+thread count
643 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1270/3/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m  0s

Docker mode activated.

-1 :x:
patch
0m 20s

https://github.com/apache/hadoop/pull/1270 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/1270

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1270/1/console

versions
git=2.17.1

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


fix(jest-preset): set Jest test environment explicitly

...to jsdom. This is a prerequisite for the upgrade to Jest 27, which
changes its default test environment to node.

Bors merge bot cheat sheet
We are using bors-ng to automate merging of our pull requests. The following table provides a summary of commands that are available to reviewers (members of this repository with push access) and delegates (in case of bors delegate+ or bors delegate=[list]).

Syntax
Description

bors merge
Run the test suite and push to master if it passes. Short for "reviewed: looks good."

bors merge-
Cancel an r+, r=, merge, or merge=

bors try
Run the test suite without pushing to master.

bors try-
Cancel a try

bors delegate+
Allow the pull request author to merge their changes.

bors delegate=[list]
Allow the listed users to r+ this pull request's changes.

bors retry
Run the previous command a second time.

This is a short collection of opinionated commands. For a full list of the commands read the bors reference.

bors merge


[CL Incentives] Add check to only sync uptime accums when necessary

Background
We currently sync uptime accumulators before any operation that uses their values (e.g. tick init, tick crossing etc.). Since a single function is technically capable of triggering many of these updates, we are likely taking on redundant computation in the average case.
Suggested Design

Add a check for LastLiquidityUpdate < ctx.Blocktime() before all uses of updateUptimeAccumulatorsToNow

Acceptance Criteria

New and existing tests should pass

What if instead of having this function be executed in locations such as getTickInfo and crossTick, we move up this call higher in the execution flow. E.g. to updatePosition function or the swap-related functions?
Not sure if this is right but just another idea to explore - if having these tracked be updated is necessary for each block, maybe we have it in "begin block"?

ref: https://github.com/osmosis-labs/osmosis/pull/4399#discussion_r1117820456

What if instead of having this function be executed in locations such as getTickInfo and crossTick, we move up this call higher in the execution flow? E.g. to updatePosition function or the swap-related functions.

Perhaps a simpler approach would be to rename getTickInfo to getOrInitTickInfo, much like what we have in other parts of the CL package.

Not sure if this is right but just another idea to explore - if updating these trackers is necessary for each block, maybe we have it in "begin block"?

We don't necessarily need to update every tracker for every tick each block. In fact, if a pool isn't touched for 1,000 blocks, the incentive accumulators should remain unchanged – this is by design! I think the approach suggested in the issue achieves the minimum number of calls possible all things considered.

This was addressed in an earlier PR (we already skip accumulator updates if no time has elapsed)


Modules/plugins etc. environment

It'd be awesome if for 1.0 there's some sort of an API environment that allows us to easily write modules and plug-ins for webtorrent-desktop.

we might consider that after 1.0. for now we're prioritizing reliability, performance, and a minimalist UX
if we had this feature today, what would you use it for?

Maybe something like #631 , it's better to be a plugin rather than built-in.

#631 is two totally different things. First, the title and description make it sound like it's about live streaming. I think P2P live streaming is a cool idea, but it should be its own separate app.
Second, #631 suggests a kind of discovery or feed feature, where you could find new torrents within WebTorrent Desktop. If we ever add that I think it'll just be part of the main app.
As far as I can tell, none of the popular torrent clients have a plugin system: uTorrent, Transmission, etc. And we want to be clean and minimalist compared to those.

+1 for clean and minimalist
and I mean the second one of #631 😅
When I imagine the plugin system, I think it might be:

Some UI hooks
Expose some api

and of course, it should be under a condition that:

After 1.0
Clean & minimalist

Maybe there's a way to achieve it, anyway, we never thought about a torrent client in the browser while it's true now 😄

I can see a plugin system being used for things like:

search
more casting options
fancier subtitles

But this is def a post 1.0 feature IMO.


Principal does not have access to API/Operation

Please provide us with the following information:

This issue is for a: (mark with an x)
- [X] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Another person has created the site. My task is to just upload content and to rebuild index.
azd auth login
Set-ExecutionPolicy -ExecutionPolicy RemoteSigned -Scope CurrentUser
.../scripts/prepdocs.ps1
I get same result even if I set AZURE_PRINCIPAL_ID="Object id of MY user account"
I get same result even if I set AZURE_PRINCIPAL_ID="Object id of the environment creator user account"

Any log messages given by the failure

Search index gptkbindex already exists
Processing files...
Processing 'C:\Users\timo.riikonen\Documents\Git\azure-search-openai-demo/data\5616-05en.pdf'
Uploading blob for page 0 -> 5616-05en-0.pdf
Extracting text from 'C:\Users\timo.riikonen\Documents\Git\azure-search-openai-demo/data\5616-05en.pdf' using Azure Form Recognizer
Traceback (most recent call last):
File "C:\Users\timo.riikonen\Documents\Git\azure-search-openai-demo\scripts\prepdocs.py", line 313, in
page_map = get_document_text(filename)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\timo.riikonen\Documents\Git\azure-search-openai-demo\scripts\prepdocs.py", line 129, in get_document_text
poller = form_recognizer_client.begin_analyze_document("prebuilt-layout", document = f)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\timo.riikonen\Documents\Git\azure-search-openai-demo\scripts.venv\Lib\site-packages\azure\core\tracing\decorator.py", line 76, in wrapper_use_tracer
return func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\timo.riikonen\Documents\Git\azure-search-openai-demo\scripts.venv\Lib\site-packages\azure\ai\formrecognizer_document_analysis_client.py", line 126, in begin_analyze_document
return self._client.begin_analyze_document(  # type: ignore
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\timo.riikonen\Documents\Git\azure-search-openai-demo\scripts.venv\Lib\site-packages\azure\ai\formrecognizer_generated_operations_mixin.py", line 170, in begin_analyze_document
return mixin_instance.begin_analyze_document(model_id, pages, locale, string_index_type, analyze_request, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\timo.riikonen\Documents\Git\azure-search-openai-demo\scripts.venv\Lib\site-packages\azure\core\tracing\decorator.py", line 76, in wrapper_use_tracer
return func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\timo.riikonen\Documents\Git\azure-search-openai-demo\scripts.venv\Lib\site-packages\azure\ai\formrecognizer_generated\v2022_08_31\operations_form_recognizer_client_operations.py", line 576, in begin_analyze_document
raw_result = self._analyze_document_initial(  # type: ignore
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\timo.riikonen\Documents\Git\azure-search-openai-demo\scripts.venv\Lib\site-packages\azure\ai\formrecognizer_generated\v2022_08_31\operations_form_recognizer_client_operations.py", line 507, in _analyze_document_initial
map_error(status_code=response.status_code, response=response, error_map=error_map)
File "C:\Users\timo.riikonen\Documents\Git\azure-search-openai-demo\scripts.venv\Lib\site-packages\azure\core\exceptions.py", line 109, in map_error
raise error
azure.core.exceptions.ClientAuthenticationError: (PermissionDenied) Principal does not have access to API/Operation.
Code: PermissionDenied
Message: Principal does not have access to API/Operation.

Expected/desired behavior

Text extraction succeeds

OS and Version?

Windows 11

azd version?

1.0.1

Versions

2023-06-08

Mention any other details that might be useful

Thanks! We'll be in touch soon.

Failing command is openai.Completion.create

After running roles.sh to my account it looks like I got to the next line and to the next error.

After running roles.sh and setting the principal id I don't get this error any more.

After running roles.sh and setting the principal id I don't get this error any more.

Where you do get the principal id?

It is user's object I'd
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Zahava Rosenbaum @.>
Sent: Friday, June 23, 2023 12:33:13 AM
To: Azure-Samples/azure-search-openai-demo @.>
Cc: Timo Riikonen @.>; Comment @.>
Subject: Re: [Azure-Samples/azure-search-openai-demo] Principal does not have access to API/Operation (Issue #290)
After running roles.sh and setting the principal id I don't get this error any more.
Where you do get the principal id?
—
Reply to this email directly, view it on GitHubhttps://github.com/Azure-Samples/azure-search-openai-demo/issues/290#issuecomment-1603344329, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BARCGRE26HNWB6OOL4M4I73XMS2ZTANCNFSM6AAAAAAY7DKG4Q.
You are receiving this because you commented.Message ID: @.***>

If anyone else is experiencing this issue, please check the "identity" tab of your deployed app, and make sure it shows the correct role assignments for OpenAI.
Here's what it looks like for a functioning app:

Closing this issue as I don't believe there's an issue with the repo.

how do i do this?

I had to assign an AAD Group to the Cognitive Services OpenAI User Role in the Azure OpenAI resource itself.

running roles.ps1 just does this:
.\scripts\roles.ps1
Environment variables set.
argument --assignee-object-id: expected one argument
WHAT OBJECT ID IS EXPECTING ?

I had to assign an AAD Group to the Cognitive Services OpenAI User Role in the Azure OpenAI resource itself.

I tried this but it didn't work for me. I had to assign the role Cognitive Services OpenAI Contributor rather than User.


[AVM Module Issue]: Cannot use this module if the resource group does not yet exist

Check for previous/existing GitHub issues

[X] I have checked for previous/existing GitHub issues

Issue Type?
Bug
(Optional) Module Version
0.2.0
(Optional) Correlation Id
No response
Description
When defining the resource where the route table is to be created, but that resource group does not yet exist, terraform plan and apply error with:
│ Error: Error: Resource Group "identity-networking-demo-rg-cnc-01" was not found
│
│   with module.udr_identity.data.azurerm_resource_group.parent,
│   on .terraform\modules\udr_identity\main.tf line 1, in data "azurerm_resource_group" "parent":
│    1: data "azurerm_resource_group" "parent" {

Relevant snip:
resource "azurerm_resource_group" "rg_identity_nw" {
  provider = azurerm.identity

  name     = "identity-networking-demo-rg-cnc-01"
  location = var.default_location

  tags = {
    date-created = "2024-07-21"
  }
}

# Create a UDR to the firewall
module "udr_identity" {
  source  = "Azure/avm-res-network-routetable/azurerm"
  version = "~> 0.2.0"

  name                = "addc-demo-rt-cnc-01"
  location            = var.default_location
  resource_group_name = azurerm_resource_group.rg_identity_nw.name
  tags                = { "date-created" : "2024-07-21" }

  enable_telemetry = try(!local.archetypes.disable_telemetry, false)

  routes = {
    "to-firewall" = {
      name           = "to-firewall"
      address_prefix = "<IP_ADDRESS>/0"
      next_hop_type  = "VirtualAppliance"
      # Assumption: Only one firewall (single hub in a single region only)
      next_hop_in_ip_address = module.hubnetworking[0].firewalls.primary.private_ip_address
    }
  }

  providers = {
    azurerm = azurerm.identity
  }
}

Hi @SvenAelterman!
This is expected behavior.
From the Terraform docs, data resource is evaluated during the plan time unless one of the following conditions prevent it:

At least one of the given arguments is a managed resource attribute or other value that Terraform cannot predict until the apply step.
The data resource depends directly on a managed resource that itself has planned changes in the current plan.
The data resource has custom conditions and it depends directly or indirectly on a managed resource that itself has planned changes in the current plan.

One way to solve this would be to add a depends on to the module call:
depends_on = [ azurerm_resource_group.rg_identity_nw ]

Hi @SvenAelterman!
While this is not a bug, it has made me reconsider the usefulness of the data resource, and why it is even there.
Historically in v0.1 we determined the resource location from the resource group, but since this is no longer the case, I think we no longer require the resource group as a data source and can reference the resource group directly by the var.resource_group_name.
I will mark this as an enhancement and add it to the next version.
Thanks for the feedback!

Hi @SvenAelterman! This is expected behavior. From the Terraform docs, data resource is evaluated during the plan time unless one of the following conditions prevent it:

At least one of the given arguments is a managed resource attribute or other value that Terraform cannot predict until the apply step.
The data resource depends directly on a managed resource that itself has planned changes in the current plan.
The data resource has custom conditions and it depends directly or indirectly on a managed resource that itself has planned changes in the current plan.

One way to solve this would be to add a depends on to the module call: depends_on = [ azurerm_resource_group.rg_identity_nw ]

I saw your later comment too, but I have a question about this suggestion about using an explicit dependency. I am already creating an implicit dependency between the UDR and the RG by using the RG's name in the UDR's resource_group_name property.
Would an explicit dependency make a difference?

Hey @SvenAelterman
Absolutely, my interpretation of why this works is that the new resource group has not yet been created, therefore it is not a managed resource by Terraform. So, you are not actually creating a dependency at all, and the data resource is trying to evaluate during the plan time.
However, if you want a real explanation on why this is the behavior in Terraform, I suggest a discussing on the Hashicorp forum ;)

Hey @SvenAelterman
The removal of the data resource is merged and new release 0.2.1 is now out.
Thanks for the useful feedback!


Tested on some GTA games, all good except GTA IV

Hi there!
Recently found this project and tested v0.2.0 on a few games, notably Grand Theft Auto series. Here is what I got:
GTA III, GTA VC - did not work. They are old and use DirectX 8 so this might be expected. Tried d3d8to9, but no luck. Unofficial re-implementations known as re3/reVC worked since they use DX9.
GTA SA - worked with DX9 hook
Bully: SE 1.200 worked with DX9 hook
GTA Trilogy: The Definitive Edition - worked (x64 build with DX11 hook)
GTA V - worked (x64 build with DX11 hook)
GTA IV (The Complete Edition, Steam) - did not work. Tried both DX9 and DX11, tried injecting the hook on game launch or after a few minutes of playing. The game seems to function normally, but the overlay window simply does not appear.
I understand the tool is in its early stages but maybe you can share some clues on where to look at to find a reason why it did not work on GTA IV?
Thanks in advance and good luck with the project.

Hi!
wrt GTA III and VC support: no idea how d3d8to9 may behave, but if DX8 is not that different from DX9 the current DX9 renderer and hook could be adapted to DX8. I also suspect those games may be 32 bit, and that has not been a goal at all of this library (so far -- depends on adoption and interest I guess).
wrt GTA IV: there are a few things to be tried. First of all, use the debugging facilities (e.g. some logging library like simplelog) paired with the AllocConsole/FreeConsole helpers, or a file writer output, to determine whether the hook has found the right functions in the first place. You may check how the practice tool does it for reference.
Afterwards you may want to dig deeper into the game, get a better understanding of which rendering engine it is using, if there are peculiarities about it that hudhook doesn't behave correctly with etc. Can't offer much help there unfortunately, it largely depends on the game.
Hope that helps and thank you!

Hello @x87!
Did you uset the i686-pc-windows-msvc target for the GTA: SA build? I can not inject my dll for that game and I'm curious how you got it to work.

I used https://github.com/ThirteenAG/Ultimate-ASI-Loader

Should be closed by #39, feel free to reopen if it's still not working for you!


Create ubports-initramfs.gz from source

We need to create ubports-initramfs.gz from source, the issue now is that git does not preserve links so we need to do this in Android.mk on build.

But symlinks would work, wouldnt they?

This is all fixed now that #7 is merged!


Fixed multiple imports

Type of change

[x] Refactor
[ ] New feature
[ ] Bug fix
[ ] Optimization
[ ] Documentation Update

Description
According to PEP-8, multiple imports should usually be on separate lines:
https://peps.python.org/pep-0008/#imports
Checklist before requesting a review

[x] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.

Testing

N/A

/assign @bparees

@tisnik @vishnuchalla   is this something we can get black or another formatter to format+enforce for us through our make format and make verify targets?  otherwise we'll be fighting it forever.
i'll merge this one, but if it's something we think is important we're going to want automatic formatting+enforcement or we'll never manage to stick to it.
/approve
/lgtm

@tisnik @vishnuchalla is this something we can get black or another formatter to format+enforce for us through our make format and make verify targets? otherwise we'll be fighting it forever.

@bparees IMHO it can be tested by Ruff at least. I can update Makefile's targets, not a problem, but not sure where to put the dependency. Now it seems that these "devel dependencies" are not specified, right?


No change to state

Hi
I tried using the module but I keep getting:
No changes. Your infrastructure matches the configuration.
After running plan
Missing something.

Hi @raid-rohana-healthy,
Thanks for reporting this. Could you post your code? Best is to post your provider and resource definitions.
Thank You!


Ensure download() passes kwargs to the reader functions

The new LightCurve reader functions contain a number of optional keyword arguments.  For example, the TESS LightCurve reader allows the flux_column parameter to be passed to determine which column should be used to populate the flux column.
At present the download() method of the SearchResult class does not pass kwargs through to these reader functions.  This PR changes this, to allow e.g. the following use case:
lc = lk.search_lightcurve("Pi Men", sector=12).download(flux_column='sap_flux')

(previously, flux_column could not be passed in the example above)

Just in time coding...


Android Basics: Activities and intents: Missing detail activity

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-training-activities-intents?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-kotlin-unit-3-pathway-1%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-training-activities-intents#4
In which task and step of the codelab can this issue be found?
Task 5
Describe the problem
The task describes setting up explicit intent and the class DetailActivity is already implemented. However following steps 1,2, and 3. The DetailActivity class is not found and is required to be created. It seems the code from Git is maybe not aligned to the codelab original version maybe? Without doing any modifications to the code base the code seems to work functionally. Its adding the code from the codelab which breaks the app.
Steps to reproduce?

Go to...
Click on...
See error...
Error is DatialActivity is not available.

Versions
Android Studio version:
Arctic Fox 2020.3.1 Patch 2
API version of the emulator:
Additional information
Include screenshots if they would be useful in clarifying the problem.
/**
* Replaces the content of an existing view with new data
*/
override fun onBindViewHolder(holder: LetterViewHolder, position: Int) {
val item = list.get(position)
holder.button.text = item.toString()
    // Assigns a [OnClickListener] to the button contained in the [ViewHolder]
    holder.button.setOnClickListener {

        val context = holder.view.context   << added
        val intent = Intent(context, DetailActivity::class.java)   << added
        intent.putExtra("letter", holder.button.text.toString())  << added
        context.startActivity(intent)   << added

        // Create an action from WordList to DetailList
        // using the required arguments
        val action = LetterListFragmentDirections.actionLetterListFragmentToWordListFragment(letter = holder.button.text.toString())
        // Navigate using that action
        holder.view.findNavController().navigate(action)
    }
}

DetailActivity should be present in the starter branch of the repo.
(It is not present, however, in the main branch. It might be helpful to check that you were on the starter branch when working through the codelab)


The output of RGB camera and instance segmentation camera in carla0.9.14 is different

Hello, I have placed an RGB camera and an instance segmentation camera in the same location on the TOWN 01 map in version 0.9.14 of Carla.
There is a problem here, the mountains that can be seen in the RGB camera are missing in the instance segmentation camera.
And the vehicles hidden behind the mountain cannot be seen in the RGB camera, but are seen in the instance segmentation camera.
May I ask what the problem is

The semantic segmentation camera renders elements in scene with a different color depending on how these have been tagged. The tags are created by the simulator depending on the path of the asset used for spawning. For example, meshes tagged as Pedestrians are spawned with content stored in "Unreal/CarlaUE4/Content/Static/Pedestrians".
So, back to your problem, the mountains that can be seen in the RGB camera are missing in the instance segmentation camera,
And the vehicles hidden behind the mountain can not be seen in the RGB camera, but are seen in the instance segmentation camera.
That is because the mountains asset is not tagged in right way, You may check it in the CARLA documentation


{} generates invalid source

Describe the issue or request
In TypeSpec, you can declare a plain object using only {} but the C# generator emits erroneous source named simply .cs i.e., just an extension - no file name:
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

// <auto-generated/>

#nullable disable

namespace Azure.AI.Language.Conversations
{
    /// <summary> Initializes a new instance of. </summary>
    internal ()
{
}
}
}

See this comment for more context.
Describe your ideas for solutions
This should be supported and, perhaps, either generate a property-less model with stable name based on the property, or BinaryData if we end up using {} to signify any valid JSON object. See our internal Teams channel discussion for more details.

One thought about how this could conceptually work is to use the same naming convention generation that you use for, say, inline enums. E.g. (though, perhaps not exact):
model Foo {
  bar?: {};
}

You'd generate something like you would if that were an enum e.g., FooBar with no properties.
As for use cases, this could be a placeholder. Maybe we don't want to support this, but in that case I think you'd want to err immediate rather than err downstream when trying to compile source. Easier to diagnose if a TypeSpec author generating an SDK would get a message saying "we don't support {}" or whatever.

This issue is one scenario of anonymous model. There is an issue https://github.com/Azure/autorest.csharp/issues/3623 to track all those.

There is the discussion related to this topic in https://github.com/Azure/typespec-azure/issues/3389


json parsing with arrays of objects

Hi,
Why is the traverse json call parameter flattenArray forced to false on first call when creating the encrypted file this is preventing encryption on object elements contained in an array. Is it done on any purpose?
It would be nice to make it optional so encryption would work on those arrays of objects
Thanks

Hi @mdaouas, sorry for the late reply. Obviously I missed the notification on your issue.
At first look, the arrays are flattened because the secure-config library also uses flattenArray=true on decryption (see line 47 in the secure-config library: https://github.com/tsmx/secure-config/blob/master/secure-config.js#L47). I'll investigate further why this was implemented that way and get back to you.
Kind Regards

Should be possible to add support for encrypted properties of objects in arrays. Impacts at least on the following points:

secure-config: decryption
secure-config-tool: creation of encrypted config file
secure-config-tool: update of hmac values
doumentation and tests

Feature idea support for encrypted properties of objects in arrays was added to the secure-config project.

secure-config 2.1.0 with support for encrypted props of objects in arrays released. Prerequisites to adapt secure-config-tool are set.

Feature branch array-object-encryption created.

Version 2.2.0 with enhancement released.


please solve this.

INFO:Prefetcher:cancelled; prefetcher stopping
INFO:SessionManager:closing down server for rpc://<IP_ADDRESS>:8000
INFO:Controller:shutting down
INFO:Controller:shutdown complete
ERROR:electrumx:ElectrumX server terminated abnormally
Traceback (most recent call last):
File "/electrumx/electrumx_server", line 35, in main
asyncio.run(controller.run())
File "/usr/local/lib/python3.7/asyncio/runners.py", line 43, in run
return loop.run_until_complete(main)
File "uvloop/loop.pyx", line 1501, in uvloop.loop.Loop.run_until_complete
File "/electrumx/electrumx/lib/server_base.py", line 129, in run
await server_task
File "/electrumx/electrumx/lib/server_base.py", line 102, in serve
await self.serve(shutdown_event)
File "/electrumx/electrumx/server/controller.py", line 134, in serve
await group.spawn(wait_for_catchup())
File "/usr/local/lib/python3.7/site-packages/aiorpcX-0.18.7-py3.7.egg/aiorpcx/curio.py", line 255, in aexit
await self.join()
File "/usr/local/lib/python3.7/site-packages/aiorpcX-0.18.7-py3.7.egg/aiorpcx/curio.py", line 213, in join
raise task.exception()
File "/electrumx/electrumx/server/block_processor.py", line 702, in fetch_and_process_blocks
await group.spawn(self._process_prefetched_blocks())
File "/usr/local/lib/python3.7/site-packages/aiorpcX-0.18.7-py3.7.egg/aiorpcx/curio.py", line 255, in aexit
await self.join()
File "/usr/local/lib/python3.7/site-packages/aiorpcX-0.18.7-py3.7.egg/aiorpcx/curio.py", line 213, in join
raise task.exception()
File "/electrumx/electrumx/server/block_processor.py", line 663, in _process_prefetched_blocks
await self.check_and_advance_blocks(blocks)
File "/electrumx/electrumx/server/block_processor.py", line 230, in check_and_advance_blocks
await self._maybe_flush()
File "/electrumx/electrumx/server/block_processor.py", line 368, in _maybe_flush
await self.flush(flush_arg)
File "/electrumx/electrumx/server/block_processor.py", line 358, in flush
await self.run_in_thread_with_lock(flush)
File "/electrumx/electrumx/server/block_processor.py", line 212, in run_in_thread_with_lock
return await asyncio.shield(run_in_thread_locked())
File "/electrumx/electrumx/server/block_processor.py", line 211, in run_in_thread_locked
return await run_in_thread(func, *args)
File "/usr/local/lib/python3.7/site-packages/aiorpcX-0.18.7-py3.7.egg/aiorpcx/curio.py", line 68, in run_in_thread
return await get_event_loop().run_in_executor(None, func, *args)
File "/usr/local/lib/python3.7/concurrent/futures/thread.py", line 57, in run
result = self.fn(*self.args, **self.kwargs)
File "/electrumx/electrumx/server/block_processor.py", line 357, in flush
self.estimate_txs_remaining)
File "/electrumx/electrumx/server/db.py", line 244, in flush_dbs
self.flush_history()
File "/electrumx/electrumx/server/db.py", line 313, in flush_history
self.history.flush()
File "/electrumx/electrumx/server/history.py", line 160, in flush
flush_id = pack_be_uint16(self.flush_count)
struct.error: 'H' format requires 0 <= number <= 65535                                                                                my compose file is
version: "3.7"
services:
electrs:
container_name: electrs
image: lukechilds/electrumx:latest
volumes:
- "../volumes/electrs:/data"
ports:
- "${APP_ELECTRS_PORT}:${APP_ELECTRS_PORT}"
- 50002:50002
- 8000:8000
- 8080:8080
healthcheck:
test: "nc -z localhost 50001"
interval: 30s
timeout: 10s
retries: 3
start_period: 30s
environment:
- DAEMON_URL=http://${APP_BITCOIN_RPC_USERNAME}:${APP_BITCOIN_RPC_PASSWORD}@${APP_BITCOIND_IP}:${APP_BITCOIND_RPC_PORT}
- COIN=Bitcoin
- SERVICES=tcp://:50001,ssl://:50002,wss://:50004,rpc://<IP_ADDRESS>:8000
- REPORT_SERVICES=tcp://vmi204200.contaboserver.net:50001,tcp://vmi204200.contaboserver.net:8000,tcp://vmi204200.contaboserver.net:8080,ssl://vmi204200.contaboserver.net:5000>
- NET=${APP_BITCOIN_NETWORK}
- LOG_LEVEL=debug
- DB_DIRECTORY=/data/db
- FLUSH_COUNT_LIMIT=65535 # Adjust this value as needed
- CACHE_MB=2048
networks:
default:
ipv4_address: "${APP_ELECTRS_IP}"

hi

duplicate of #260

FLUSH_COUNT_LIMIT=65535 # Adjust this value as needed

did you try to adjust this setting?

Yes
On Tue, 30 Apr, 2024, 4:23 pm ThomasV, @.***> wrote:

FLUSH_COUNT_LIMIT=65535 # Adjust this value as needed
did you try to adjust this setting?
—
Reply to this email directly, view it on GitHub
https://github.com/spesmilo/electrumx/issues/261#issuecomment-2084984585,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BIFVKKY547KETW5HFFQM4R3Y75Z2VAVCNFSM6AAAAABG76AHQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBUHE4DINJYGU
.
You are receiving this because you authored the thread.Message ID:
@.***>


Will open a new PR.


Too many open files - Failed to initialize inotify: the user limit on the total number of inotify instances has been reached.

Every now and then [guard] fails to start with the following message:
11:21:41 - INFO - Guard is now watching at '/home/cordawyn/Projects/test'
/home/cordawyn/.rvm/gems/ruby-1.9.3-p327-turbo/gems/rb-inotify-0.8.8/lib/rb-inotify/notifier.rb:66:in `initialize': Too many open files - Failed to initialize inotify: the user limit on the total number of inotify instances has been reached. (Errno::EMFILE)
This happens after returning the computer (notebook) from sleep mode, then launching guard (on a Rails project). To make things worse, it is not 100% reproducible (I'd say, around 80% of attempts).
I figure this might not be exactly rb-notify's bug, but rather that of either inotify or a million other kernel subsystems, but guard+rb-notify seems to be the only combo that manages to surface this issue. If you could point me to a more appropriate responsible party, it would be much appreciated ;-)

I've just stumbled upon the same problem. I think this issue could be not relate to rb-inotify, but the tools we use on our computers. I just tried to increase a limit of user instances. Here is the link with more info:
http://unix.stackexchange.com/questions/13751/kernel-inotify-watch-limit-reached
I had to increase this:
echo 256 > /proc/sys/fs/inotify/max_user_instances

works for me,thx


[BUG] useImport onSucces failure

Describe the bug
I'm using useImport and it imports the records correctly but is throwing an error: "Cannot read properties of null (reading 'filter')". I tracked it down to the createMany API call. I'm using supabase and it returns an empty body. But the useCreateMany hook is expecting a body and so is trying to filter a null value.
Steps To Reproduce

Add useImport hook
Import records
Add onFinish handler to catch errors

Expected behavior
Success response returned since records are imported correctly
Packages
@refinedev/core - 4.47.1
Additional Context
No response

@derekfinlinson Thanks for the issue, we will debug it and return you.

I created a new refine project and only added the import button to the blog posts and got the same error. It does create the records and I get the 201 response as well but I also get this in the second image in the console about an error reading filter which is coming from the createMany call trying to read from the response body when there isn't one.

Hey @derekfinlinson, I believe this will solve the problem. Supabase requires to specify fields
const importProps = useImport({
        meta: {
            select: "*",
        },
});

select: "*",

I encountered the same issue with useCreateMany, but managed to resolve it by specifying the fields. However, it would be beneficial to have this documented for others facing similar issues. Thank you

@endrit-mesh Yes you are right, thank you 🙌


update node backgroundsize to 'contain' vice 'auto' to prevent image size adjusting the node height

Line 2572 should be updated to node.childNodes[1].childNodes[0].style.backgroundSize = 'contain'; vice 'auto' so the images are sized properly and within the node.
v 3.3.10

It all depends depending on the use case - I recommend setting this in CSS as per your needs.


Fix error when import beatmap and add beatmap popup box

Fix #59 and fix #60
From #58 we found some bug when some field value from API have null error lead to error when adding beatmap. This pull request fix this and 500 error when open beatmap that is failed from import function.
Beatmap Info
I just add this to finish the design of beatmap card. I add this so when user want to see detail of beatmap but lazy to get in osu! so just open this and you will see entire detail of beatmap like get in osu!.

Note that some old beatmap that is already add will be show some value as any. Must need to refetch all data to make it show perfectly.

Let's merge!


2019.2.3-Hotfix: Contribution wizard with visibility scripted controls and multiple pages erasing metadata

Checklist

[x] the contributor license agreement is signed
[x] commit message follows commit guidelines
[x] tests are included

Description of change
#1680. Hotfix for #1678.

Closing this, as it needed to be done from the core repo not a fork.


TVMError: Cannot run module, architecture mismatch

When I run "python build.py --model ./dist/models/vicuna-7b --quantization q4f16_0 --target android --max-seq-len 768", I got an issue like
"
[18:13:12] /Users/wenkeyu1/Desktop/mlc-llm/tvm-unity/src/target/llvm/llvm_module.cc:418: Architecture mismatch: module=arm64-apple-macos host=x86_64-apple-darwin22.3.0
Traceback (most recent call last):
File "/Users/wenkeyu1/Desktop/mlc-llm/build.py", line 417, in
main()
File "/Users/wenkeyu1/Desktop/mlc-llm/build.py", line 395, in main
mod = mod_transform_before_build(mod, params, ARGS)
File "/Users/wenkeyu1/Desktop/mlc-llm/build.py", line 278, in mod_transform_before_build
new_params = utils.transform_params(mod_transform, model_params, args)
File "/Users/wenkeyu1/Desktop/mlc-llm/mlc_llm/utils.py", line 254, in transform_params
vm = relax.vm.VirtualMachine(ex, device)
File "/Users/wenkeyu1/Desktop/mlc-llm/tvm-unity/python/tvm/runtime/relax_vm.py", line 96, in init
self._setup_device(device, memory_cfg)
File "/Users/wenkeyu1/Desktop/mlc-llm/tvm-unity/python/tvm/runtime/relax_vm.py", line 137, in _setup_device
self.module"vm_initialization"
File "/Users/wenkeyu1/Desktop/mlc-llm/tvm-unity/python/tvm/_ffi/_ctypes/packed_func.py", line 238, in call
raise get_last_ffi_error()
tvm._ffi.base.TVMError: Traceback (most recent call last):
File "/Users/wenkeyu1/Desktop/mlc-llm/tvm-unity/src/target/llvm/llvm_module.cc", line 389
TVMError: Cannot run module, architecture mismatch
"
Could you please help me solve the problem,Thanks!

[18:13:12] /Users/wenkeyu1/Desktop/mlc-llm/tvm-unity/src/target/llvm/llvm_module.cc:418: Architecture mismatch: module=arm64-apple-macos host=x86_64-apple-darwin22.3.0

It seems indicative of the underlying issue. The module is of ARM architecture, while the host is x86_64.

I am also facing the same issue on a Macbook M1. Initially, I thought I was mistakenly running on x86_64, but after checking the arch command result, it show I am running on ARM64.

Why did this happen? I just follow the instructions from ios/ReadME.md

Does that mean I can't run build.py for ios/android on Mac with intel cpu?

The module is of ARM architecture, while the host is x86_64

@kywen1119 You can definitely run build.py no matter it's an Intel or ARM macbook without problem, but I will need more details to help you with your case. Could you shall all the outputs from build.py? More specifically, those lines may be helpful to me:
https://github.com/mlc-ai/mlc-llm/blob/476fed9400a2933a97b6ffaf8973a38788b8324f/mlc_llm/utils.py#L185-L187

Same problem for me, stdout is
Automatically using target for weight quantization: metal -keys=metal,gpu -max_function_args=31 -max_num_threads=256 -max_shared_memory_per_block=32768 -max_threads_per_block=1024 -thread_warp_size=32
[13:41:20] /Users/runner/work/package/package/tvm/src/target/llvm/llvm_module.cc:418: Architecture mismatch: module=arm64-apple-macos host=x86_64-apple-darwin22.4.0

My device is Apple M1 Pro

My host is actually arm_64 with M1 chip，why host=x86_64？

I have same problem
Weights exist at dist/models/dolly-v2-3b, skipping download. Using path "dist/models/dolly-v2-3b" for model "dolly-v2-3b" Database paths: ['log_db/rwkv-raven-3b', 'log_db/redpajama-3b-q4f16', 'log_db/redpajama-3b-q4f32', 'log_db/rwkv-raven-1b5', 'log_db/dolly-v2-3b', 'log_db/rwkv-raven-7b', 'log_db/vicuna-v1-7b'] [15:00:03] /Users/runner/work/package/package/tvm/src/runtime/metal/metal_device_api.mm:165: Intializing Metal device 0, name=AMD Radeon Pro 5300M [15:00:03] /Users/runner/work/package/package/tvm/src/runtime/metal/metal_device_api.mm:165: Intializing Metal device 1, name=Intel(R) UHD Graphics 630 Target configured: metal -keys=metal,gpu -max_function_args=31 -max_num_threads=256 -max_shared_memory_per_block=32768 -max_threads_per_block=1024 -thread_warp_size=32 Automatically using target for weight quantization: metal -keys=metal,gpu -max_function_args=31 -max_num_threads=256 -max_shared_memory_per_block=32768 -max_threads_per_block=1024 -thread_warp_size=32 [15:00:12] /Users/runner/work/package/package/tvm/src/target/llvm/llvm_module.cc:418: Architecture mismatch: module=arm64-apple-macos host=x86_64-apple-darwin21.6.0 Traceback (most recent call last):   File "/Users/dfq/Desktop/projects/git/mlc-llm/build.py", line 417, in <module>     main()   File "/Users/dfq/Desktop/projects/git/mlc-llm/build.py", line 395, in main     mod = mod_transform_before_build(mod, params, ARGS)           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/Users/dfq/Desktop/projects/git/mlc-llm/build.py", line 278, in mod_transform_before_build     new_params = utils.transform_params(mod_transform, model_params, args)                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/Users/dfq/Desktop/projects/git/mlc-llm/mlc_llm/utils.py", line 255, in transform_params     vm = relax.vm.VirtualMachine(ex, device)          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/Users/dfq/anaconda3/envs/mlc-llm-env/lib/python3.11/site-packages/tvm/runtime/relax_vm.py", line 96, in __init__     self._setup_device(device, memory_cfg)   File "/Users/dfq/anaconda3/envs/mlc-llm-env/lib/python3.11/site-packages/tvm/runtime/relax_vm.py", line 137, in _setup_device     self.module["vm_initialization"](*init_args)   File "tvm/_ffi/_cython/./packed_func.pxi", line 331, in tvm._ffi._cy3.core.PackedFuncBase.__call__   File "tvm/_ffi/_cython/./packed_func.pxi", line 276, in tvm._ffi._cy3.core.FuncCall   File "tvm/_ffi/_cython/./base.pxi", line 181, in tvm._ffi._cy3.core.CHECK_CALL tvm._ffi.base.TVMError: Traceback (most recent call last):   File "/Users/runner/work/package/package/tvm/src/target/llvm/llvm_module.cc", line 389 TVMError: Cannot run module, architecture mismatch
Automatically using target for weight quantization: metal -keys=metal,gpu -max_function_args=31 -max_num_threads=256 -max_shared_memory_per_block=32768 -max_threads_per_block=1024 -thread_warp_size=32
[15:00:12] /Users/runner/work/package/package/tvm/src/target/llvm/llvm_module.cc:418: Architecture mismatch: module=arm64-apple-macos host=x86_64-apple-darwin21.6.0

@hermitgreen, @junrushao
It's because even though you are running on an ARM64 architecture, your installed Anaconda version is x86_64.
Check out the value of platform after running conda info. What you would want in this case is osx-arm64, not osx-64.
Install the MacOS M1/M2 version of Anaconda and try again.

I can confirm. I hit this problem and setting the environment fixed it for me.
Initially conda info showed platform : osx-64.
I then ran:
CONDA_SUBDIR=osx-arm64 conda create -n mlc-llm-env numpy -c conda-forge
conda activate mlc-llm-env
conda config --env --set subdir osx-arm64
reinstalled the packages from the readme and then python build.py --hf-path=databricks/dolly-v2-3b worked for me

@kywen1119 You can definitely run build.py no matter it's an Intel or ARM macbook without problem, but I will need more details to help you with your case. Could you shall all the outputs from build.py? More specifically, those lines may be helpful to me:
https://github.com/mlc-ai/mlc-llm/blob/476fed9400a2933a97b6ffaf8973a38788b8324f/mlc_llm/utils.py#L185-L187

Hi,
My whole logs are listed here
/bin/sh: lscpu: command not found Using path "../../mlc-llm/dist/models/vicuna-7b" for model "vicuna-7b" Database paths: ['log_db/rwkv-raven-3b', 'log_db/redpajama-3b-q4f16', 'log_db/redpajama-3b-q4f32', 'log_db/rwkv-raven-1b5', 'log_db/dolly-v2-3b', 'log_db/rwkv-raven-7b', 'log_db/vicuna-v1-7b'] Target configured: metal -keys=metal,gpu -libs=iphoneos -max_function_args=31 -max_num_threads=256 -max_shared_memory_per_block=32768 -max_threads_per_block=256 -thread_warp_size=1 [10:41:14] /Users/runner/work/package/package/tvm/src/runtime/metal/metal_device_api.mm:165: Intializing Metal device 0, name=AMD Radeon Pro 5300M [10:41:15] /Users/runner/work/package/package/tvm/src/runtime/metal/metal_device_api.mm:165: Intializing Metal device 1, name=Intel(R) UHD Graphics 630 Automatically using target for weight quantization: metal -keys=metal,gpu -max_function_args=31 -max_num_threads=256 -max_shared_memory_per_block=32768 -max_threads_per_block=1024 -thread_warp_size=32 [10:41:24] /Users/runner/work/package/package/tvm/src/target/llvm/llvm_module.cc:418: Architecture mismatch: module=arm64-apple-macos host=x86_64-apple-darwin22.3.0 Traceback (most recent call last):   File "/Users/wenkeyu1/Desktop/desk/mlc-llm/build.py", line 417, in <module>     main()   File "/Users/wenkeyu1/Desktop/desk/mlc-llm/build.py", line 395, in main     mod = mod_transform_before_build(mod, params, ARGS)           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/Users/wenkeyu1/Desktop/desk/mlc-llm/build.py", line 278, in mod_transform_before_build     new_params = utils.transform_params(mod_transform, model_params, args)                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/Users/wenkeyu1/Desktop/desk/mlc-llm/mlc_llm/utils.py", line 255, in transform_params     vm = relax.vm.VirtualMachine(ex, device)          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/Users/wenkeyu1/miniconda3/envs/mlc-llm-env/lib/python3.11/site-packages/tvm/runtime/relax_vm.py", line 96, in __init__     self._setup_device(device, memory_cfg)   File "/Users/wenkeyu1/miniconda3/envs/mlc-llm-env/lib/python3.11/site-packages/tvm/runtime/relax_vm.py", line 137, in _setup_device     self.module["vm_initialization"](*init_args)   File "tvm/_ffi/_cython/./packed_func.pxi", line 331, in tvm._ffi._cy3.core.PackedFuncBase.__call__   File "tvm/_ffi/_cython/./packed_func.pxi", line 276, in tvm._ffi._cy3.core.FuncCall   File "tvm/_ffi/_cython/./base.pxi", line 181, in tvm._ffi._cy3.core.CHECK_CALL tvm._ffi.base.TVMError: Traceback (most recent call last):   File "/Users/runner/work/package/package/tvm/src/target/llvm/llvm_module.cc", line 389 TVMError: Cannot run module, architecture mismatch

Target configured: metal -keys=metal,gpu -libs=iphoneos -max_function_args=31 -max_num_threads=256 -max_shared_memory_per_block=32768 -max_threads_per_block=256 -thread_warp_size=1

Just wanted to double check, are you compiling for Android or iOS? The target looks very much like iOS to me

Target configured: metal -keys=metal,gpu -libs=iphoneos -max_function_args=31 -max_num_threads=256 -max_shared_memory_per_block=32768 -max_threads_per_block=256 -thread_warp_size=1

Just wanted to double check, are you compiling for Android or iOS? The target looks very much like iOS to me

for ios.
python build.py --model ../../mlcllm/dist/models/vicuna-7b --quantization q3f16_0 --target iphone --max-seq-len 768

@kywen1119 The reason is that our quantization system currently assumes the ARM CPU is used on macOS: https://github.com/mlc-ai/mlc-llm/blob/8f1386fe5aeb4342e0d7287863a3b7b2a072ed13/mlc_llm/utils.py#L372
This assumption is definitely unnecessarily strong. To support x86 CPUs, we have to support auto detection of local CPU architecture, which, fortunately, is supported in TVM's LLVM binding. I submitted a PR as the fix: https://github.com/mlc-ai/mlc-llm/pull/387
Let me know if it works for you!

@kywen1119 The reason is that our quantization system currently assumes the ARM CPU is used on macOS:
https://github.com/mlc-ai/mlc-llm/blob/8f1386fe5aeb4342e0d7287863a3b7b2a072ed13/mlc_llm/utils.py#L372
This assumption is definitely unnecessarily strong. To support x86 CPUs, we have to support auto detection of local CPU architecture, which, fortunately, is supported in TVM's LLVM binding. I submitted a PR as the fix: #387
Let me know if it works for you!

Thanks for your patient reply!
The PR works for me, I successfully converted the model.

Thanks!


pallet balances with zero ExistentialDeposit

Does pallet balances support zero ExistentialDeposit? I remember there were some issues regards it but not sure if they still applies after various refactors.
Context: https://github.com/AcalaNetwork/Acala/issues/236

After reading bit more code, seems like ExistentialDeposit = 1 should work?
ExistentialDeposit = 0 means account can never be removed, but with ExistentialDeposit = 1 account can be removed when balance reach to 0.
https://github.com/paritytech/substrate/blob/812d94d42c6d6d7fd28cf18a08d84f14c49d8544/frame/balances/src/lib.rs#L589-L597
Still will like a confirmation.

CC @shawntabrizi

Our balances pallet does not support zero existential deposit. We have parts of our logic which assume it is non-zero, and of course the entire account reaping logic would not work.
It is a design decision and if you need that support you probably want to create a new pallet for that purpose.


add rawContents method

Hi!
I'm using your HTML Parser, thank you.
I found that with this classes i can't get raw content of element. I add this feature in PR.

Merged, thanks. :+1:


Can Raccoon be used via command line?

Hey! Can I download APKs via the command line instead of using the executable? I couldn’t find anything about it.

@ahm750 yes, I was able to java -jar raccoon-4.24.0.jar --help worked for me


Multichoice PromptForChoice does not work as intended in ISE or VS Code.

I have posted some examples here: https://gist.github.com/gerane/b40a4755fc249ed420c49ae8fef947f9
When specifying [Int[]] for Default value in order to take Multiple selections, it breaks the GUI portion of the Prompts and forces it to console.
In ISE you can still use it, but it might be confusing to users to have some prompts in a GUI and some in console.
The bigger issue is in an Editor like VSCode. If the user doesn't have their output open, they won't even see their options. They are in the console, but being prompted by a blank prompt that only has a ":". I think this will really confuse most users.
Here is a gif showing what it looks like.

I'll have to look into this, maybe there's some way for PSES to know how to deal with this appropriately.  Still won't be possible to allow multiple selection with VS Code's selection box, so I'm not sure what the right UI would be in this case...

Yo does it somehow:

From the Usage animated gif on the extension's marketplace page.

Heh, interesting hack.  They're basically showing the same list multiple times with special characters to show the checked state.  Pretty clever.  I think we can replicate that.

I was wondering why PromptForChoice wasn't doing this itself. Odd the way it works.

Could you potentially do this for all prompts to get better formatting and to handle timeouts and errors more appropriately?

Could you give an example of what you mean?  Unfortunately I don't have a lot of control over VS Code's UI

I guess it isn't that bad if you remove the multichoice options. The one quirk is the '-' that shows up for choice options.

Also, when running this from the debugger, we still have this issue where "blank" input is not passed back to PowerShell.  This makes it impossible AFAICT to end a multichoice input from the debug console (without aborting the script).

Best way is likely to reload the window.

@gerane This is not really a Plaster issue. Could you submit this issue to the https://github.com/powerShell/vscode-powershell project?


[BUG]: notEq() missing

What version of drizzle-orm are you using?
0.22.0-7239945
Describe the Bug
The readme file says there's a notEq() function
notEq(column, value)

But there's no reference to it in the codebase.

It's called ne() currently. We'll update the docs. Thanks!


Tried to place key X a Y

I have these 3 routes
get "/members/:id/edit" do |env|
end
get "/members/export" do |env|
end
get "/members/:id/videos" do |env|
end

and they cause this error
Tried to place key ':id/videos' at same level as ':id/edit' (Radix::Tree::SharedKeyError)
[4330602514] *CallStack::unwind:Array(Pointer(Void)) +82
[4330602417] *CallStack#initialize:Array(Pointer(Void)) +17
[4330602376] *CallStack::new:CallStack +40
[4330574217] *raise<Radix::Tree::SharedKeyError>:NoReturn +25
[4331284391] *Radix::Tree(Kemal::Route)@Radix::Tree(T)#add<String, Kemal::Route, Radix::Node(Kemal::Route)>:(Array(Radix::Node(Kemal::Route)) | Kemal::Route | Nil) +1223
[4331284427] *Radix::Tree(Kemal::Route)@Radix::Tree(T)#add<String, Kemal::Route, Radix::Node(Kemal::Route)>:(Array(Radix::Node(Kemal::Route)) | Kemal::Route | Nil) +1259
[4331283153] *Radix::Tree(Kemal::Route)@Radix::Tree(T)#add<String, Kemal::Route>:(Array(Radix::Node(Kemal::Route)) | Kemal::Route | Radix::Node(Kemal::Route) | Nil) +97
[4331282306] *Kemal::RouteHandler#add_to_radix_tree<String, String, Kemal::Route>:(Array(Radix::Node(Kemal::Route)) | Kemal::Route | Radix::Node(Kemal::Route) | Nil) +66
[4331282113] *Kemal::RouteHandler#add_route<String, String, &Proc(HTTP::Server::Context, Nil)>:(Array(Radix::Node(Kemal::Route)) | Kemal::Route | Radix::Node(Kemal::Route) | Nil) +65
[4330575095] *get<String, &Proc(HTTP::Server::Context, Nil)>:(Array(Radix::Node(Kemal::Route)) | Kemal::Route | Radix::Node(Kemal::Route) | Nil) +71
[4330495026] __crystal_main +4210
[4330556728] main +40

The interesting thing is that changing the order of these routes fixes it:
get "/members/:id/edit" do |env|
end
get "/members/:id/videos" do |env|
end
get "/members/export" do |env|
end

The tricky part is when you have 200 routes, and need to figure out the correct order ;) haha.

I've never experienced a situation like this gues it's because of our Radix implementation 😢

Actually, the nice thing about it is that while porting over my rails app, I found a bug in my current routes 😂 It seems this is the winning order for routes
/
/:x
/:x/a
/:x/a/:y
/a/b
/a/b/:x
As long as I keep my routes in this order, my app will still boot. I have yet to test all of the routes to make sure they are doing what I want, but in the mini example above, this does work as expected.

@jwoertink that's great to hear 😄

@jwoertink both :id/videos and :id/edit should have been valid paths for the routing tree, so it appears to be a bug in Radix. Feel free to submit a bug report or even better, a pull request :smile:

@luislavena thanks! I forked it and started working on a PR. I'd like to get your thoughts on direction since the tree parsing is slightly confusing 😂

Closed in favor of https://github.com/luislavena/radix/issues/9

@jwoertink @sdogruyol I've released Radix v0.3.2 to address this bug. Please update to that release and let me know how it goes.
Thank you for your report!
:heart: :heart: :heart:

@luislavena awesome! Now i can release Kemal 0.17.0 👍


Format syntax section for readability

https://github.com/MicrosoftDocs/dataexplorer-docs/issues/148
fixes #148
Add newlines so query expected results are no longer bunched in with the next example output.

@MartinJaffer-MSFT : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@MartinJaffer-MSFT: I'm sorry - only the author of this article, @orspod, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


Active focus text on Forms nav

Description
The active focus on nav link that is not the current page, is not readable (blends with the background).
Steps to reproduce

Go to 'forms'
Tab to the nav  bar
Tab to a nav link that is not the current page
See error

Details

Browser: (Chrome, Edge, Firefox.)
Operating system: (Mac, Windows...)
Environment: (PR)
Language: (English, French...)

Expected behaviour
The text will be readable (meet contrast requirements) when tabbed to.

Resolved in related PR (#3386)


Service Listing: Surrey Libraries Not Found in Surrey

Having AA booth at the Resource Fair for Refugee Claimants at the Guildford Recreation Centre (same building where the Surrey Libraries - Guildford Library is also located), but Surrey Libraries did not show up on search results although it’s listed on bc211
When searching “Public Libraries” - the results are listed in the following order and most of them are not in Surrey:

Fraser Valley Regional Library - Terry Fox Library (Port Coquitlam)
Fraser Valley Regional Library - Pitt Meadows Public Library (Pitt Meadows)
Fraser Valley Regional Library - George Mackie Library (Delta)
New Westminster Public Library (New westminster)
Courthouse Libraries BC - Courthouse Library - Surrey
...see screenshots for the rest of results

When searching “Community and Recreation centres” - see results on attached screenshots, and the Guildford Recreation Centre where I was using the app was not listed in search results.

Next steps:

find out if surrey libraries exits in Sept 2018 BC211 dataset. If no, check March 2019 dataset
if they do not exist in both, direct them to bc211
If they exist in one or both Sept and March datasets, this is a location/search bug.
If they do not exist in March/Sept dataset, we are missing some entries from bc211

We received an email about this issue from PG website's contact form (screen shot is attached).
I confirmed that "Surrey Libraries" (service_id 36761355) is in both Sept 2019 and Mar 2019 datasets, so it looks like it's a location/search bug. I just tested it on the "AA Staging" app (red/blue) from the HiVE, "Surrey Libraries" was included in search results under "Public Libraries". Hopefully it'll be resolved once we release the March 2019 dataset.

Received a follow-up email from Surrey Libraries on Jun 13, 2019.
Issue: Surrey Libraries does not have any service records listed in bc211 database, unlike Fraser Valley Regional Library for example.

Surrey Library appears on 1.3.12 with Taxonomy based Service listings


fix(tests): Add windows tests

:tada: This PR is included in version 2.0.7 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Need to use nav titles in cards

See above - the full titles there should be the nav titles
Page: https://edb-docs-adv-josh-skele-suffgu.herokuapp.com/getting-started/connecting_to_postgres

If no navTitle value exists, we would use title

I believe the idea here is that when a page is like this one where it has children, and we build the cards, we should use the navTitle instead of the title, if there is one. @josh-heyer please confirm

This is correct, @bradnoble @edabot

Live on production


Corrected profile name setup

Hi David,
I noted a couple of small errors in .bin/activate-profiles. It worked for adding one profile, but failed when adding all the profiles in the manifest directory.
Best regards,
Paul

Thanks a lot Paul!  Apparently I haven't used this part of the script very much :)


BREAKING CHANGE: unexpected unpacked result in blockchain

Description
Fixes #600
This pull request fixed the unpacked result of blockchain.*.unpack. It now matches the RPC type, which uses hex format instead of number or BI.
const { version } = blockchain.Transaction.unpack('0x...')

// before
typeof version === 'number' // ❌
version === 0 // ❌

// after
typeof version === 'string' // ✅
version === '0x0' // ✅

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

[x] Unit tests involve both pack() and unpack() in base.blockchain

It works but the solution seems weird, it might be a historical issue but I still wonder why is number allowed when the risk of number is well-known

It works but the solution seems weird, it might be a historical issue but I still wonder why is number allowed when the risk of number is well-known

I found that the problem originated from a large PR at #413. The PR removed the hex format conversion, but the reviewer didn't realize that the return value type had changed. This was because the types were annotated by being inferred from type Transaction = UnpackResult<typeof SomeCodec>. And there are rare scenarios in which Transaction.unpack is used during development because developers typically use the the Transaction with the default verbosity instead of the serialized one

Approved but I'm still worried about the usage of number. My opinion might be kinda extreme, the number should be replaced by string and big number

Approved but I'm still worried about the usage of number. My opinion might be kinda extreme, the number should be replaced by string and big number

It might be not consistent with some blockchain SDK, such as typechain. Lumos's current default number codec draws on some developer conventions from them


Rewarded Twice

Hi,
The Kata Answer the students' questions! 6Kyu awarded me points twice, on the first go when i attempted the problem all went well but after i refactored the code and submitted again the  connection broke but somehow points were rewarded and it showed the solution have been withheld as you have not finished the kata, i attempted with the same code and on the second go all went well but i was awarded points again. Please look into it. My username Gorgoroth
Regards

Duplicate of #1592.

Agreed it is a duplicate of #1592 , should I close this issue ? Please also suggest what needs to be done on my end in regards to the reward points.

Closing as a duplicate of #1592.
@jarch24 there's nothing to be done on your end. The points will be eventually get fixed when the bug is fixed which needs a huge data fix.


Feature/add unused address to wallet api

This builds on #123 and also adds unusedAddress(): Promise<Address> to the WalletApi.
There are  some things missing in this PR, that I just don't know how to implement.
I think the implementation in selectWallet is correct, and I've tested this. However, in selectWalletFrom, selectWalletFromSeed, and selectWalletFromPrivateKey I don't know what the correct implementation would be.
I am willing to attempt to implement the missing functions, but I would probably need a hint, or if you want to, you can take this PR further.

Lucid allows you to select a much wider range of wallets

Ok, I am lacking some fundamental understanding regarding this, sorry.

I would do something like this

Cool. Would this make sense in the context of Lucid? I will update the PR.

Cool. Would this make sense in the context of Lucid? I will update the PR.
That change would make #123 redundant as there should always be either a used or unused wallet if I understand it correctly. (or not redundant, but I can squash them together)

I think it's alright. I feel like no one really has figured out yet how to properly use getUsedAddresses and getUnusedAddresses from CIP-0030. I'm personally not a fan of multi address wallets anyway. It doesn't make any sense.
I like to keep things simple and just have one address to refer to.

Yeah, it does add a lot of complexity with multiple wallets. I updated the PR to take both usedAddress and (if not existing) unusedAddress inside the Wallet.address function, as you recommended. I think this is a much more reasonable change, because it doesn't change the API (even though it does change the public facing functionality, so I guess you could argue it breaks backward compatability according to semver)

@alessandrokonrad I updated the PR according to your feedback.


Missing 'closed_date' attribute for question

According to https://api.stackexchange.com/docs/types/question, Question object has an attribute called closed_date.
But there is no such attribute in the Question model.

Thanks for spotting this, that should be fixed in master now. Let me know if you notice anything else missing!

This was fixed in https://github.com/lucjon/Py-StackExchange/commit/ecb753d68103fefb87dfde2bbfd14ae7bac45b35, closing


Fix file regexp pattern in README

See https://github.com/kimai/kimai/actions/runs/7385039079/job/20089038083

The pull request has only these files changed: https://github.com/kimai/kimai/pull/4514/files

The "blocks.html.twig" file triggers here, because I blindly followed the (wrong pattern?) in the README.
The pattern .*.lock should only match files that end on .lock (like symfony.lock, composer.lock, yarn.lock).
For testing: https://regex101.com/r/mTsQJG/1
Maybe we can further improve on my suggestion, as I am not the biggest regex friend 😁
The README says

In the example above, files with .example extension won't be allowed to be changed.

But the regex also matches 1example.txt.
So maybe the pattern .*\.example$. is even better?

Thanks for your work here @xalvarez 👍


some changes to docs

- What I did
fixed punctuation, grammatical issue in notifications page
- How I did it
editing the markdown files
- How to verify it
biggest grammatical error fixed at this page https://dev3.atsign.wtf/tutorials/at-dude/_4_local_notification_services/
- Description for the changelog

Major grammatical issue in notifications page fixed and minor punctuation changes, will follow through with more edits later

Hi can i get an approving review? not sure how this works


Use UPTEST_CLOUD_CREDENTIALS_2 Github repo secret to enable cross-account resource uptesting

Description of your changes

This PR proposes a change that would allow us to utilize a second IAM user for cross-account resource uptesting when the repo is properly configured with a second credentials environment variable.
A second ProviderConfig.aws named peer is provisioned in a different AWS account than the default ProviderConfig's account for cross-account testing.
NOTE: This PR introduces a breaking change in the expected syntax for the Github repo secret UPTEST_CLOUD_CREDENTIALS, and the corresponding env. variable UPTEST_CLOUD_CREDENTIALS when running uptest locally with the associated make targets. It now has the following syntax:
DEFAULT='[default]
aws_access_key_id = REDACTED
aws_secret_access_key = REDACTED'
PEER='[default]
aws_access_key_id = REDACTED
aws_secret_access_key = REDACTED'

So the value of the env. variable is expected to have the DEFAULT key to be used as the default set of credentials, and another optional key named PEER.
I have:

[x] Run make reviewable test to ensure this PR is ready for review.
[x] Update the vault key for UPTEST_CLOUD_CREDENTIALS
[ ] Change the syntax of the UPTEST_CLOUD_CREDENTIALS secret Github repo secret and add the second IAM user access credentials with the PEER key.
[x] Update the vault key for UPTEST_DATASOURCE
[ ]  Update the UPTEST_DATASOURCE Github repo secret so that it contains the ID of this second account.

How has this code been tested

A second ProviderConfig.aws named peer is now available in the test runtime:

We sync'ed with @ezgidemirel who is on support rotation today and we decided to update the repo secret UPTEST_CLOUD_CREDENTIALS with the breaking new syntax change tomorrow.


[id] Fix successfulJobsHistoryLimit and failedJobHistoryLimit fields in CronJob tasks

successfulJobHistoryLimit and failedJobHistoryLimit should be successfulJobsHistoryLimit and failedJobsHistoryLimit

/retitle [id] Fix successfulJobsHistoryLimit and failedJobHistoryLimit fields in CronJob tasks

/lgtm
/approve