Internet access from UAVCAN networks

In this pull request, I have outlined my vision of how internet access from UAVCAN networks should be implemented. Please read the comments provided in the data type definitions for explanations.
Feedback is welcome.
Application examples

Direct telemetry transmission from UAVCAN nodes with no dependency on external means of broadcasting.
Creation of web API for onboard equipment. For example, a camera vendor can provide a web API for their products that directly interacts with the cameras on board, bypassing all third party logic.
Reception of real-time correction data streams (e.g. RTCM RC-104) for precise positioning applications.
Automatic firmware upgrades directly from vendor's website.

P.S. @EShamaev this is the Internet/LAN access feature we talked about some weeks back. Shall it get merged, you should consider supporting it in your telemetry modems.

I am debating whether the field session_id should be renamed into local_port or alike, in order to retain closer similarity with regular UDP.
Interestingly, despite the fact that incoming packets that enter UAVCAN from the Internet do not carry any information about the source address, it is still possible to perform UDP hole punching and establish direct communication channels between UAVCAN nodes that are physically located on different vehicles.

session_id makes more sense that local_port
With session ID, packets do not need source address at all.
However there might be a problem with UAVCAN <-> Ehternet <-> UAVCAN communications.
The NAT translation will only happen if there was an outgoing packet. So there should be a possibility to setup 'listening' on specific without having any outgoing packet.

The NAT translation will only happen if there was an outgoing packet.

Yes, hence the hole punching technique. It allows hosts to establish a direct communication channel through a single NAT layer on either one or both sides of the link. See https://en.wikipedia.org/wiki/UDP_hole_punching#Flow
However, I don't anticipate high demand for direct links between nodes that belong to different vehicles. Cellular service providers typically do not assign global IP addresses to their subscribers, so communication channels will have to circumvent NATs in provider networks as well, which might be impossible.

This flow assumes the possibility to define both source and target ports and most important - present of one known public server. With assumption of having white IP server, anything can be done with even simpler flows.
However it might be useful to provide one more flag, that will instruct to use session_id as a source port for modem.

This flow assumes the possibility to define both source and target ports.

I don't see why the source port must necessarily be defined. The source port can be chosen arbitrarily by the modem node, and as long as the mapping between this arbitrarily chosen port number P and the pair of (UAVCAN node ID, session ID) is known, UDP hole punching should work. Upon reception of any datagram via the port P the modem node would simply forward it to the specified node. A downside here is that the targeted node would have no way to know where the datagram has come from, since we provide no source address for incoming datagrams, unless the datagram itself contains some means to identify its origin.

With assumption of having white IP server, anything can be done with even simpler flows.

Absolutely. This feature is mostly intended for client-server architectures, where clients are nodes and servers are located on the Internet or LAN. The simplest way to arrange communication between nodes is to use an external server as a broker.

I don't see why the source port must necessarily be defined.

This is only regarding 2 UAVCAN nodes in different networks. Because 2nd node will have no knowledge on the source port of 1st node. So direct communication will not be possible.
Because of this intermediary server S is needed in flow you provided. It advises to nodes the correct full address of each other.

Yes, direct communication can only be established with the help of an external server, this is what I implied in my descriptions above. At any rate, we should not focus on this use case too much. It is possible not by design, but rather as a side effect.

Opening up the uavcan to the internet/lan communications would bring to mind security concerns.  What security concerns are there if the example applications are achieved?

Excellent question, Nick. Yes, there are always security concerns when the Internet is involved; however, they are outside of the scope of UAVCAN I think. What we're offering here is merely a gateway between nodes and external hosts, it is up to the nodes themselves to ensure adequate security.
A possible attack vector that comes to mind is as follows: using a network scanning tool, like Nmap, discover the UDP ports opened by the modem node, and flood them with traffic. The modem node would propagate the traffic into the UAVCAN bus. However, I do not expect this attack to have any significant adverse effect on the operation of the bus, because of this clause:

It is recommended to perform service invocations at the same transfer priority level as was used for broadcasting the latest matching message of type OutgoingUDPPacket. However, meeting this recommendation would require the modem node to implement additional logic, which may be undesirable. Therefore, implementers are free to deviate from this recommendation and resort to a fixed priority level instead. In the case of a fixed priority level, lower priorities should be preferred in order to avoid interference with real-time traffic on the bus. It is advised to use priority level values from 31 to 24, inclusive (remember that numerically higher values correspond to lower priority levels).

It guarantees that the traffic generated by such flooding attack will not affect high-priority communications on the bus.
Please post here if other attack vectors come to mind.

I intend to have this merged in a week or so unless new change propositions are brought up.

The definitions have been updated. I have incorporated the ideas we came up with during the conversation on the mailing list with @olliw42.
The new data types allow the use of transport protocols other than UDP.

Here are just some thoughts I had when considering the DroneCode ecosystem and UAVCAN/dsdl
I have read about the CoAP and it may be a useful implementation somewhere in the ecosystem. It's designed to supervise or control remotely IoT type devices ie. sensors, acutators etc.  The interesting thing is that it runs over UDP packets with an optional DTLS encryption with generally low overhead, multicast, and has a REST model.
Particle.io probably has the best implementation of CoAP, DTLS encryption and web-authentication that I've seen (and its open source!!)

https://github.com/spark/firmware/blob/develop/communication/README.md

As QGC and Pixhawk prefer Qt as the default build environment and IDE,  Qt 5.9 has a serial bus framework for CAN based protocols.  I envision the UAVCAN implementation in QGC may be coupled to this framework in the future:

https://github.com/qt/qtserialbus

Qt is also working on a CoAP implementation:

https://wiki.qt.io/QtCS_2017_CoAP

This could be added to QGC once it is developed.
Now, if I was building a web application to receive UAVCAN data, I would only want to receive it from vehicles that are registered and setup through my application.
I would like to assign them a UUID and a private encryption key for authentication.
I think there should be UAVCAN data fields for these with the UUID stored on every node and a PGP key stored on the communication bridge device.
On system startup, a service would sync with the cloud server through authentication handshakes and a web micro service would be started to handle data transmission.
Considering CoAP, here are some basic data streaming situations:

MAVLINK -> UAVCAN -> CoAP -> Web Service
UAVCAN -> CoAP -> Web Service
UAVCAN -> GCS -> CoAP -> Web Service

Another item to consider, there are soooo many GCS systems (web & ground based) or flight data collection software being developed, there would need to be an OpenAuth type of standardization for IoT devices or UV systems in general.
Hopefully these are useful points.

Thanks, Robbie, this is useful. CoAP seems like an interesting protocol, I never heard of it before. Do you think the UDP transport defined in this PR is sufficient for a full-featured implementation of a CoAP client? If not, what is missing?

Haha not sure Pavel.  @EShamaev and yourself, to me, are more knowledgeable to answer.  Although, implementing CoAP with DTLS can also resolve the security concerns brought by @nbrakeES.
Now, if the UDP transport in this PR IS sufficient for a full-featured CoAP client, what issues could there be at the hardware level?  What issues will there be in industry adoption?
We know it will add more program space and processing overhead, although consider the implications in 5 years where unmanned systems have these protocol layers embedded and they are impossible to change.
Some manufacturers may not implement this because it may not meet a IETF (web protocol), IEEE (electrical & hardware design) and/or ISO (manufacturing quality) standard.  That needs to be addressed.
Sorry, I may have gone off on a tangent to the topic. Although since it's a public post, I hope people reading will contribute their creative thoughts and solutions to developing this technology further.
Big thanks to @pavel-kirienko for spearheading UAVCAN and the many contributors here pushing it forward.
Here are some reference docs:
IETF - RFC 7252 - Official CoAP specification
ARM CoAP Tutorial April 30 2014.pdf
coap-cheatsheet.pdf

Reimplemented in #47, closing.


windows builds fail on MacOS 10.15 catalina

Since upgrading to 10.15 Catalina electron-packager fails to build .exe files for windows. It simply throws this error:

spawn Unknown system error -86

the command i used for my builds:
electron-packager . myapp --overwrite --asar --platform=win32 --arch=ia32 --icon=myapproot/src/assets/icons/windows/icon.ico --prune=true --out=release-builds --version-string.CompanyName=myapp --version-string.FileDescription=CE --version-string.ProductName="myapp"
My electron-packager version is 14.0.6.
Building for mac is still working fine.
Under 10.14 Mojave Windows builds were working too.
Am I doing something wrong or is this a catalina issue?
Hope anyone can help me.
Thank you
Bernhard

This is a duplicate of https://github.com/electron/electron-packager/issues/1055


PyPi package is different from github repo

I was recently checking out the cooltools suite and found that some functions used parts of the bioframe package that are not part of the module that could be installed via pip (i.e. PyPi) version.
I double-checked the version numbers and I have the latest bioframe version.
In particular this affects the bioframe.bedslice function which is used in the cooltools cooltools.eigdecomp.cooler_cis_eigs function to get the part of the phasing track matching the current region under decomposition. There it is used like defined in the repo here and also works as expected when using the cooltools function with a signature of
bedslice(frame, region)

However, when trying to use the bedslice directly it is a completely different function with a signature of
bedslice(frame, chrom, start, end)

Is there any explanation for this?###

We are in the process of refactoring bioframe. A new release of cooltools depending on the new bioframe will follow. If you are installing cooltools from master there was one recent commit that put it out of sync with the bioframe 0.0 series (https://github.com/mirnylab/cooltools/commit/a8ed7763a3ef3f0552a201b72bad4e8954763bcc).
I have an idea, @itsameerkat: let's revert that commit and make a cooltools 0.3.2 release that requires bioframe < 0.1.0. That will ensure cooltools 0.3 works in the future.

@dmalzl cooltools v0.3.2 is now up on PyPI. Please give it a try and re-open if you still encounter problems.


EPG's for Frikanalen is not included in the Norwegian EPG xmltv file

The schedule for Frikanalen is provided in XMLTV format, with one URL per day.
The URL is /xmltv/YYYY/MM/DD for a specific day, and /xmltv/upcoming/ for the scheduled entries from today 00:00 and 7 days forward.
For example this is the URL of today:
https://frikanalen.no/xmltv/2022/01/02
and this is the URL of the coming week:
https://frikanalen.no/xmltv/upcoming/
API: https://frikanalen.no/api/scheduleitems/?date=today
Source: https://frikanalen.no/xmltv/
https://frikanalen.no/schedule

Added via #408


test python 2.7 compatibility

make stable-baselines compatible with python 2.7.
only test_atary are failing because of a csv error in monitor.py.

Hello,
First, I recommend you reading CONTRIBUTING.md.
I'm not sure that python 2 compatibility is something we want. Although I understand that some systems (e.g. ROS) requires python 2, making the connection between SB and the application is bit tedious, my main concern is that python 2 will reach its end of life in 10 months (see countdown).

Hello,
I will check contributing.md out, thanks.
I plan to use this library with ros, that is why I started this work. I think other people of the ros community may be interested by a 2.7 compatibility.

This will be a useful feature. I'm currently working with the gazebo-gym environments and they dont support python3 yet because ros doesn't. :(

@ClementRolinat @HareshMiriyala For working with ROS + stable-baselines, I recommend you looking at the S-RL Toolbox, especially working with real robot. We have created different script for interfacing with ROS/gazebo.
The simplest solution is to communicate with python 2 using a zmq sockets.

@araffin  thanks ! btw, i found gym-gazebo does support python3

Closing this PR because python 2 won't be maintain anymore. But this will still appear in the repo so people can take a look at if they really need to use python 2 ;)


No settings appearing

I don't seem to have any of the settings. I've tried in two 5e games (one is my test game). I was hoping to use the module for a fumble table, but I can't seem to get it to show the settings.

Foundry v10.303
D&D5e v2.2.1
Chrome Version 114.0.5735.198

I'm a little bit busy but I'll see if I can try to get this fixed this coming week.


chore: updated .prettierrc.json to use "auto" for endOfLine

Description
This pull request resolves a compatibility issue related to line endings (endOfLine) when transitioning from "lf" to "auto" for better compatibility with Windows environments.
Linked Issues
No linked issues
Preview / Screenshot

Checklist

[x] I have followed commit guideline to create PR title (https://conventionalcommits.org/en/v1.0.0/)

Using auto for endOfLine in Prettier is not recommended because it can lead to inconsistent line endings within the same project. This inconsistency can cause several issues:

Version control issues: Version control systems like Git treat files with different line endings as modified, leading to unnecessary merge conflicts and noise in the commit history.
Cross-platform compatibility problems: Files with mixed line endings may not work correctly when shared between different operating systems (Windows, macOS, Linux).
Maintainability challenges: Having a mix of line endings in the codebase makes it harder to maintain and work with the code consistently.
Instead, it's better to explicitly set endOfLine to lf (line feed, \n), which is the standard line ending used on Unix-based systems and is widely considered the preferred line ending for cross-platform compatibility. Using lf ensures consistent line endings across the entire codebase, regardless of the operating system used for editing.

Most modern text editors and IDEs can handle lf line endings without any issues, even on Windows, which traditionally uses crlf (carriage return + line feed, \r\n). By configuring Git and your text editor/IDE properly, you can work with your preferred line endings locally while maintaining consistency in the shared codebase.
git config --global core.autocrlf true


[1.5] backport adding grafanaInClusterURL in Kiali helm chart

See also https://github.com/istio/istio/pull/21255

Hi @jotak. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Hi @jotak. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Also removing hardcoded "istio-system" in URL as it's not necessary and would reduce number of default working cases.

Also removing hardcoded "istio-system" in URL as it's not necessary and would reduce number of default working cases.

@jotak: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.5
a5f5c7f89437b8d1f640f470d097518b06bf5c83
link
/test gencheck_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jotak I think you need to run make gen on this one.
Also, I'm not seeing the original PR on master,  is that a cherry pick ?

@fpesce it's not merged in master yet, it's here: https://github.com/istio/istio/pull/21255
It's not exactly a cherry-pick: in 1.5 we already added jaegerInCluserURL ; then in master jaegerInCluserURL and grafanaInCluserURL were added by another user that was merged almost at the same time ... so now I'm trying to make all of these consistent both in master and 1.5, by adding grafanaInCluserURL here.
About make gen, yes for some reason it doesn't worked on my machine (working well on master but not in 1.5) so I ran make operator-proto hoping that would be sufficient. Looks like it isn't...

@fpesce it's not merged in master yet, it's here: #21255
It's not exactly a cherry-pick: in 1.5 we already added jaegerInCluserURL ; then in master jaegerInCluserURL and grafanaInCluserURL were added by another user that was merged almost at the same time ... so now I'm trying to make all of these consistent both in master and 1.5, by adding grafanaInCluserURL here.

@fpesce for some reason, a PR was merged into 1.5 before being merged into master, creating an inconsistent state in the protobufs between master and release 1.5. This should fix that problem.

About make gen, yes for some reason it doesn't worked on my machine (working well on master but not in 1.5) so I ran make operator-proto hoping that would be sufficient. Looks like it isn't...

@jotak we do not use the BUILD_WITH_CONTAINER=1 setting for 1.5 branch. We decided it would be better to enable this after the branch. On reflection, we should have BUILD_WITH_CONTAINER=1 on the release-1.5 branch. It is far too late to change that now though, so we will struggle a bit with this problem for install backports for 1.5 until 1.5 is released.
I'd recommend running BUILD_WITH_CONTAINER=1 make gen to work around the problem.

TL;DR new implementation was directly merged to a release branch without a proper exception.
@fpesce IMO The correct solution involves the following actions:

revert https://github.com/istio/istio/pull/21256
backport https://github.com/istio/istio/pull/21393
backport https://github.com/istio/istio/pull/21255

For more rationale on why the revert is needed, see: https://github.com/istio/istio/pull/21256#issuecomment-593030058
Other approaches can be taken as long as the protobuf is consistent and master is the source of truth for new implementation work.

@sdake I did not realize that these PRs were not in master.
I'll check the impact of reverting something merged 5 days ago. Hoping it'll be doable.

@sdake Also note that master has seen a lot of changes, so if this manual PR is the only way to cherrypick the mentioned changes, we should accept it.

@fpesce @sdake looks like protobuf isn't fixed yet between 1.5 and master:
$ git diff release-1.5 master -- operator/pkg/apis/istio/v1alpha1/values_types.proto

(...)
   TypeMapStringInterface auth = 7;

-  string jaegerInClusterURL = 8;
+  string grafanaInClusterURL = 8;

-  string grafanaInClusterURL = 9;
+  string jaegerInClusterURL = 9;

(...)

I'm going to fix it.

@jotak: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jotak: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.5
a5f5c7f89437b8d1f640f470d097518b06bf5c83
link
/test gencheck_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-local-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jotak: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.5
a5f5c7f89437b8d1f640f470d097518b06bf5c83
link
/test gencheck_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-local-tests_istio_release-1.5

integ-istioio-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-istioio-k8s-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jotak: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.5
a5f5c7f89437b8d1f640f470d097518b06bf5c83
link
/test gencheck_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-local-tests_istio_release-1.5

integ-istioio-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-istioio-k8s-tests_istio_release-1.5

integ-security-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-security-local-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jotak: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.5
a5f5c7f89437b8d1f640f470d097518b06bf5c83
link
/test gencheck_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-local-tests_istio_release-1.5

integ-istioio-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-istioio-k8s-tests_istio_release-1.5

integ-security-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-security-local-tests_istio_release-1.5

integ-conformance-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-k8s-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jotak: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.5
a5f5c7f89437b8d1f640f470d097518b06bf5c83
link
/test gencheck_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-local-tests_istio_release-1.5

integ-istioio-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-istioio-k8s-tests_istio_release-1.5

integ-security-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-security-local-tests_istio_release-1.5

integ-conformance-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-k8s-tests_istio_release-1.5

integ-pilot-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-pilot-local-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jotak: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.5
a5f5c7f89437b8d1f640f470d097518b06bf5c83
link
/test gencheck_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-local-tests_istio_release-1.5

integ-istioio-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-istioio-k8s-tests_istio_release-1.5

integ-security-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-security-local-tests_istio_release-1.5

integ-conformance-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-k8s-tests_istio_release-1.5

integ-pilot-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-pilot-local-tests_istio_release-1.5

integ-galley-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-galley-k8s-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jotak: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.5
a5f5c7f89437b8d1f640f470d097518b06bf5c83
link
/test gencheck_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-local-tests_istio_release-1.5

integ-istioio-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-istioio-k8s-tests_istio_release-1.5

integ-security-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-security-local-tests_istio_release-1.5

integ-conformance-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-k8s-tests_istio_release-1.5

integ-pilot-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-pilot-local-tests_istio_release-1.5

integ-galley-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-galley-k8s-tests_istio_release-1.5

integ-mixer-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-mixer-k8s-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jotak: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.5
a5f5c7f89437b8d1f640f470d097518b06bf5c83
link
/test gencheck_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-local-tests_istio_release-1.5

integ-istioio-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-istioio-k8s-tests_istio_release-1.5

integ-security-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-security-local-tests_istio_release-1.5

integ-conformance-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-k8s-tests_istio_release-1.5

integ-pilot-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-pilot-local-tests_istio_release-1.5

integ-galley-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-galley-k8s-tests_istio_release-1.5

integ-mixer-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-mixer-k8s-tests_istio_release-1.5

integ-security-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-security-k8s-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jotak: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.5
a5f5c7f89437b8d1f640f470d097518b06bf5c83
link
/test gencheck_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-local-tests_istio_release-1.5

integ-istioio-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-istioio-k8s-tests_istio_release-1.5

integ-security-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-security-local-tests_istio_release-1.5

integ-conformance-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-k8s-tests_istio_release-1.5

integ-pilot-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-pilot-local-tests_istio_release-1.5

integ-galley-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-galley-k8s-tests_istio_release-1.5

integ-mixer-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-mixer-k8s-tests_istio_release-1.5

integ-security-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-security-k8s-tests_istio_release-1.5

release-test_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test release-test_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jotak: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.5
a5f5c7f89437b8d1f640f470d097518b06bf5c83
link
/test gencheck_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-local-tests_istio_release-1.5

integ-istioio-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-istioio-k8s-tests_istio_release-1.5

integ-security-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-security-local-tests_istio_release-1.5

integ-conformance-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-k8s-tests_istio_release-1.5

integ-pilot-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-pilot-local-tests_istio_release-1.5

integ-galley-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-galley-k8s-tests_istio_release-1.5

integ-mixer-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-mixer-k8s-tests_istio_release-1.5

integ-security-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-security-k8s-tests_istio_release-1.5

release-test_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test release-test_istio_release-1.5

integ-galley-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-galley-local-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jotak: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.5
a5f5c7f89437b8d1f640f470d097518b06bf5c83
link
/test gencheck_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-local-tests_istio_release-1.5

integ-istioio-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-istioio-k8s-tests_istio_release-1.5

integ-security-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-security-local-tests_istio_release-1.5

integ-conformance-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-k8s-tests_istio_release-1.5

integ-pilot-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-pilot-local-tests_istio_release-1.5

integ-galley-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-galley-k8s-tests_istio_release-1.5

integ-mixer-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-mixer-k8s-tests_istio_release-1.5

integ-security-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-security-k8s-tests_istio_release-1.5

release-test_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test release-test_istio_release-1.5

integ-galley-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-galley-local-tests_istio_release-1.5

integ-pilot-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-pilot-k8s-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jotak: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jotak: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.5
a5f5c7f89437b8d1f640f470d097518b06bf5c83
link
/test gencheck_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-local-tests_istio_release-1.5

integ-istioio-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-istioio-k8s-tests_istio_release-1.5

integ-security-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-security-local-tests_istio_release-1.5

integ-conformance-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-k8s-tests_istio_release-1.5

integ-pilot-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-pilot-local-tests_istio_release-1.5

integ-galley-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-galley-k8s-tests_istio_release-1.5

integ-mixer-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-mixer-k8s-tests_istio_release-1.5

integ-security-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-security-k8s-tests_istio_release-1.5

release-test_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test release-test_istio_release-1.5

integ-galley-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-galley-local-tests_istio_release-1.5

integ-pilot-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-pilot-k8s-tests_istio_release-1.5

e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5

lint_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test lint_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jotak: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.5
a5f5c7f89437b8d1f640f470d097518b06bf5c83
link
/test gencheck_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-local-tests_istio_release-1.5

integ-istioio-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-istioio-k8s-tests_istio_release-1.5

integ-security-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-security-local-tests_istio_release-1.5

integ-conformance-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-k8s-tests_istio_release-1.5

integ-pilot-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-pilot-local-tests_istio_release-1.5

integ-galley-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-galley-k8s-tests_istio_release-1.5

integ-mixer-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-mixer-k8s-tests_istio_release-1.5

integ-security-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-security-k8s-tests_istio_release-1.5

release-test_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test release-test_istio_release-1.5

integ-galley-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-galley-local-tests_istio_release-1.5

integ-pilot-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-pilot-k8s-tests_istio_release-1.5

e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5

lint_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test lint_istio_release-1.5

pilot-multicluster-e2e_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test pilot-multicluster-e2e_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jotak: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.5
a5f5c7f89437b8d1f640f470d097518b06bf5c83
link
/test gencheck_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-local-tests_istio_release-1.5

integ-istioio-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-istioio-k8s-tests_istio_release-1.5

integ-security-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-security-local-tests_istio_release-1.5

integ-conformance-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-k8s-tests_istio_release-1.5

integ-pilot-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-pilot-local-tests_istio_release-1.5

integ-galley-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-galley-k8s-tests_istio_release-1.5

integ-mixer-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-mixer-k8s-tests_istio_release-1.5

integ-security-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-security-k8s-tests_istio_release-1.5

release-test_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test release-test_istio_release-1.5

integ-galley-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-galley-local-tests_istio_release-1.5

integ-pilot-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-pilot-k8s-tests_istio_release-1.5

e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5

lint_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test lint_istio_release-1.5

pilot-multicluster-e2e_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test pilot-multicluster-e2e_istio_release-1.5

e2e-mixer-no_auth_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test e2e-mixer-no_auth_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jotak: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.5
a5f5c7f89437b8d1f640f470d097518b06bf5c83
link
/test gencheck_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-local-tests_istio_release-1.5

integ-istioio-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-istioio-k8s-tests_istio_release-1.5

integ-security-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-security-local-tests_istio_release-1.5

integ-conformance-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-k8s-tests_istio_release-1.5

integ-pilot-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-pilot-local-tests_istio_release-1.5

integ-galley-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-galley-k8s-tests_istio_release-1.5

integ-mixer-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-mixer-k8s-tests_istio_release-1.5

integ-security-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-security-k8s-tests_istio_release-1.5

release-test_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test release-test_istio_release-1.5

integ-galley-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-galley-local-tests_istio_release-1.5

integ-pilot-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-pilot-k8s-tests_istio_release-1.5

e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5

lint_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test lint_istio_release-1.5

pilot-multicluster-e2e_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test pilot-multicluster-e2e_istio_release-1.5

e2e-mixer-no_auth_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test e2e-mixer-no_auth_istio_release-1.5

pilot-e2e-envoyv2-v1alpha3_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test pilot-e2e-envoyv2-v1alpha3_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jotak: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.5
a5f5c7f89437b8d1f640f470d097518b06bf5c83
link
/test gencheck_istio_release-1.5

integ-conformance-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-local-tests_istio_release-1.5

integ-istioio-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-istioio-k8s-tests_istio_release-1.5

integ-security-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-security-local-tests_istio_release-1.5

integ-conformance-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-k8s-tests_istio_release-1.5

integ-pilot-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-pilot-local-tests_istio_release-1.5

integ-galley-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-galley-k8s-tests_istio_release-1.5

integ-mixer-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-mixer-k8s-tests_istio_release-1.5

integ-security-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-security-k8s-tests_istio_release-1.5

release-test_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test release-test_istio_release-1.5

integ-galley-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-galley-local-tests_istio_release-1.5

integ-pilot-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-pilot-k8s-tests_istio_release-1.5

e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5

lint_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test lint_istio_release-1.5

pilot-multicluster-e2e_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test pilot-multicluster-e2e_istio_release-1.5

e2e-mixer-no_auth_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test e2e-mixer-no_auth_istio_release-1.5

pilot-e2e-envoyv2-v1alpha3_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test pilot-e2e-envoyv2-v1alpha3_istio_release-1.5

integ-telemetry-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-telemetry-k8s-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jotak: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-local-tests_istio_release-1.5

integ-istioio-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-istioio-k8s-tests_istio_release-1.5

integ-security-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-security-local-tests_istio_release-1.5

integ-conformance-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-k8s-tests_istio_release-1.5

integ-pilot-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-pilot-local-tests_istio_release-1.5

integ-galley-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-galley-k8s-tests_istio_release-1.5

integ-mixer-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-mixer-k8s-tests_istio_release-1.5

integ-security-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-security-k8s-tests_istio_release-1.5

release-test_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test release-test_istio_release-1.5

integ-galley-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-galley-local-tests_istio_release-1.5

integ-pilot-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-pilot-k8s-tests_istio_release-1.5

e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5

lint_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test lint_istio_release-1.5

pilot-multicluster-e2e_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test pilot-multicluster-e2e_istio_release-1.5

e2e-mixer-no_auth_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test e2e-mixer-no_auth_istio_release-1.5

pilot-e2e-envoyv2-v1alpha3_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test pilot-e2e-envoyv2-v1alpha3_istio_release-1.5

integ-telemetry-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-telemetry-k8s-tests_istio_release-1.5

gencheck_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test gencheck_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jotak: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

e2e-dashboard_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test e2e-dashboard_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jotak: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-local-tests_istio_release-1.5

integ-istioio-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-istioio-k8s-tests_istio_release-1.5

integ-security-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-security-local-tests_istio_release-1.5

integ-conformance-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-k8s-tests_istio_release-1.5

integ-pilot-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-pilot-local-tests_istio_release-1.5

integ-galley-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-galley-k8s-tests_istio_release-1.5

integ-mixer-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-mixer-k8s-tests_istio_release-1.5

integ-security-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-security-k8s-tests_istio_release-1.5

release-test_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test release-test_istio_release-1.5

integ-galley-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-galley-local-tests_istio_release-1.5

integ-pilot-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-pilot-k8s-tests_istio_release-1.5

e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5

lint_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test lint_istio_release-1.5

pilot-multicluster-e2e_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test pilot-multicluster-e2e_istio_release-1.5

e2e-mixer-no_auth_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test e2e-mixer-no_auth_istio_release-1.5

pilot-e2e-envoyv2-v1alpha3_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test pilot-e2e-envoyv2-v1alpha3_istio_release-1.5

integ-telemetry-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-telemetry-k8s-tests_istio_release-1.5

gencheck_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test gencheck_istio_release-1.5

e2e-dashboard_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test e2e-dashboard_istio_release-1.5

unit-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test unit-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jotak: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-local-tests_istio_release-1.5

integ-istioio-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-istioio-k8s-tests_istio_release-1.5

integ-security-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-security-local-tests_istio_release-1.5

integ-conformance-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-conformance-k8s-tests_istio_release-1.5

integ-pilot-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-pilot-local-tests_istio_release-1.5

integ-galley-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-galley-k8s-tests_istio_release-1.5

integ-mixer-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-mixer-k8s-tests_istio_release-1.5

integ-security-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-security-k8s-tests_istio_release-1.5

release-test_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test release-test_istio_release-1.5

integ-galley-local-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-galley-local-tests_istio_release-1.5

integ-pilot-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-pilot-k8s-tests_istio_release-1.5

e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5

lint_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test lint_istio_release-1.5

pilot-multicluster-e2e_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test pilot-multicluster-e2e_istio_release-1.5

e2e-mixer-no_auth_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test e2e-mixer-no_auth_istio_release-1.5

pilot-e2e-envoyv2-v1alpha3_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test pilot-e2e-envoyv2-v1alpha3_istio_release-1.5

integ-telemetry-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-telemetry-k8s-tests_istio_release-1.5

gencheck_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test gencheck_istio_release-1.5

e2e-dashboard_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test e2e-dashboard_istio_release-1.5

unit-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test unit-tests_istio_release-1.5

integ-distroless-k8s-tests_istio_release-1.5
08bf8fa2dbdf60156c83063b579f8183cbcaaa82
link
/test integ-distroless-k8s-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This time codegen seemed to work. Not sure what was wrong last time when it didn't, basically many generated files were quite suspicious with changes where I wouldn't expect them.

/retest

@fpesce @sdake looks like protobuf isn't fixed yet between 1.5 (this PR) and master:
$ git diff release-1.5 master -- operator/pkg/apis/istio/v1alpha1/values_types.proto

(...)
   TypeMapStringInterface auth = 7;

-  string jaegerInClusterURL = 8;
+  string grafanaInClusterURL = 8;

-  string grafanaInClusterURL = 9;
+  string jaegerInClusterURL = 9;

(...)

I'm going to fix it.
[edit: done]

@jotak thanks again for your work. In the future, please submit to master first, such that the backport process is smoother. When submitting to a release branch, it makes it harder for the maintainers to understand what has been done. Can you link your PR for making master consistent with 1.5?
Cheers
-steve

@fpesce @sdake looks like protobuf isn't fixed yet between 1.5 (this PR) and master:
$ git diff release-1.5 master -- operator/pkg/apis/istio/v1alpha1/values_types.proto

(...)
   TypeMapStringInterface auth = 7;

-  string jaegerInClusterURL = 8;
+  string grafanaInClusterURL = 8;

-  string grafanaInClusterURL = 9;
+  string jaegerInClusterURL = 9;

(...)

I'm going to fix it.
[edit: done]

@jotak thanks again for your work. In the future, please submit to master first, such that the backport process is smoother. When submitting to a release branch, it makes it harder for the maintainers to understand what has been done. Can you link your PR for making master consistent with 1.5?
Cheers
-steve

Hi Steve, I double-checked before approving.. Checked again now:
17:36:48 localhost (release-1.5) ~/dev/go/src/istio.io/istio$ git diff release-1.5 master -- operator/pkg/apis/istio/v1alpha1/values_types.proto
diff --git a/operator/pkg/apis/istio/v1alpha1/values_types.proto b/operator/pkg/apis/istio/v1alpha1/values_types.proto
index 726e15e85..0e0c30243 100644
--- a/operator/pkg/apis/istio/v1alpha1/values_types.proto
+++ b/operator/pkg/apis/istio/v1alpha1/values_types.proto
@@ -651,7 +651,8 @@ message STSConfig {

 message IstiodConfig {
   // If enabled, all control plane functionality will be handled by a single deployment.
-  google.protobuf.BoolValue enabled = 1;
+  // Deprecated. This field is always ignored and assumed true.
+  google.protobuf.BoolValue enabled = 1 [deprecated=true];
 }

 // GlobalLoggingConfig specifies the global logging level settings for the Istio control plane components.
@@ -2203,7 +2204,7 @@ message Values {

   MixerConfig mixer = 8;

-  NodeAgentConfig nodeagent = 9;
+  NodeAgentConfig nodeagent = 9 [deprecated=true];

   PilotConfig pilot = 10;

Are you sure you pulled?

@jotak thanks again for your work. In the future, please submit to master first, such that the backport process is smoother. When submitting to a release branch, it makes it harder for the maintainers to understand what has been done. Can you link your PR for making master consistent with 1.5?
Cheers
-steve

I don't have any more PR to master, consistency was achieved here through this PR (unless I'm missing something).

@sdake can you take care that this PR will be included in release 1.5 ? Currently only PR which adds jagerInClusterURL included in 1.5.0-beta.5 what is actually not enough.

@sdake can you take care that this PR will be included in release 1.5 ? Currently only PR which adds jagerInClusterURL included in 1.5.0-beta.5 what is actually not enough.

Hi @voroniys, this change will be in 1.5.0 - it's already on the release branch. It just didn't make the cutoff for the beta.5

@dgn I think this PR didn't make the cutoff for 1.5 but should be in 1.5.1. Can you confirm?
Cheers
-steve

I've testet it with 1.5 - seems to be working.

@sdake No, this was included with 1.5.0- it was merged on Monday, we built the release on Wednesday
@voroniys thanks for testing


fix: pin @babel/core dep in test targets

Issue #, if available:
https://github.com/aws-amplify/amplify-ui/issues/1242
Description of changes:
pin deps until this issue is resolved upstream.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report

Merging #377 (7eacc94) into main (9624d5d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #377   +/-   ##
=======================================
  Coverage   89.63%   89.63%
=======================================
  Files          36       36
  Lines        1244     1244
  Branches      278      278
=======================================
  Hits         1115     1115
  Misses        126      126
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9624d5d...7eacc94. Read the comment docs.

It looks like Babel has already fixed upstream. Running canaries now to confirm if this change is needed.

Yeah, canary succeeds now with the babel fix. Closing this PR.


Update packs for 1.21.3

I'll use this as my opportunity to release the datapacks as mods as well as on Curseforge.
To do:

[x] Format Nix files
[x] Format other files
[x] Bump max version in pack.mcmeta

As a bonus:

I've also updated the pack icon for Detect AFK. It's not good, but it's definitely better than it was.

AFK can now be triggered manually for specific players, if it's been enabled for them. This is using the native trigger functionality.
AFK duration is now tracked in seconds instead of "loops"
The AFK threshold is now configurable in seconds

It's always bugged me that to check rotation you have to access NBT. This data pack is already (in some cases) hundreds of times more efficient than others, but that single NBT check has gnawed at me. But I think I've found a relatively efficient way to check for activity using head rotation without that check using entity positions. I'll need to measure if it's more or less performant, but surely with how inefficient checking NBT is, it's got to be better. Proof of concept works great, so now it's time to make it real... after work tomorrow.

I tried it, but I think I'm going to give up on that experiment. The solution I came up with uses marker entities to track the head angle, but it also ends up being influenced by location, so moving also kicks you out of being AFK.
The only other solution would be to track all the different movement stats, which might be the next thing to try. I think that's still probably faster than the NBT check, but again, have to measure.

After a couple more experiments I've landed on using a predicate that directly checks directional inputs and jumping. I could run it in every tick since it's fairly lightweight, and that would give an extremely accurate picture of when a player has stopped moving, but most players hold down an input for much longer than a second at a time, so checking once per second is close enough and still gets the performance benefits. It scales fairly well as you add more players too. I'll have to do some more perf tests, but so far it seems good.

With one player, the predicate method performs about the same as NBT. With 10 players, NBT is definitely slower, but in absolute terms it's not very much (at 10 players, execution time per "main" line of logic: get nbt = 0.15ms, check predicate = 0.02ms). In the real world, because the NBT check happens in 1/100 ticks and the predicate is 1/20, the difference is negligible. But as a best practice, and partly for maintainability too, I think this a better choice.
Positives of using input:

Simpler code
Faster execution means it can be checked more often (and as a reality of this method, must be checked more often)

Custom values for .ticks_inactive will be higher resolution

Negatives:

Farms where the player is only moving their mouse will now count as being AFK, even though the player technically isn't AFK

I just wish there was a way to detect "use" and "mine" without having to pick a block or item that is being acted upon. Surely the game tracks the totals somewhere???

Realised that detection using player input will count you as AFK if you're a passenger in a boat or using an elytra for more than 3 minutes, but thankfully there's a fix for that, which is to use a scoreboard to track that. I think minecart is also a possibility. The other mounts that don't requier input would be strider and pig, but I think those are rare enough that it's not worth checking.

I ended up using a predicate that checks for if you're a passenger in a boat or camel, which are the only two things in the base game that allow two passengers. Ticks inactive will increment when the mount stops moving. Other forms of transport, you're either the one steering it with inputs or, like minecarts, likely going to take less than 3 minutes total in the vehicle. I still want to minimize possible abuse, so longer than that, I honestly feel like being tagged as AFK is probably fine.


Label text justification

Hi Gabor,
Please consider if you would the following text justification layouts,
The font used is one of the defaults, in my case lv_font_dejavu_20
Layout 1,
Display Module
    Good packets per second : 120.0
    Request count           :   15426391
    Good packets            :   15297303,  99.16%
    Bad packets             :          0,   0.00%
    Not addressed packets   :          0,   0.00%
    No response             :     129088,   0.84%
    Run count               :   30561677
Field Module
    Good packets per second : 113.8
    Request count           :   14630007
    Good packets            :   14515661,  99.22%
    Bad packets             :         31,   0.00%
    Not addressed packets   :          0,   0.00%
    No response             :     114314,   0.78%
    Run count               :   29398852

As I understand things, to achieve this one would need to,
1. Create a label with a "    " (space*4) as a reference point (lbl_ref) at the desired justification point (to the left of where the collumns starting with "Good packets per second" (lbl_desc)) is,
2. Call lv_obj_align(lbl_desc, lbl_ref, LV_ALIGN_OUT_RIGHT_MID. 0. 0)
3. Create a label with a ":"  at the desired location, (also used as a reference point for the label containing 120.0).
4. Create a label with a " " or ","' as a reference point at the desired justification location (to the right of where the collumns starting with "15426391" (lbl_value)) is,
5. Call lv_obj_align(lbl_value, lbl_ref, LV_ALIGN_OUT_LEFT_MID. 0. 0)
6. Create a label with a "%" as a reference point (lbl_ref) at the desired justification location (on the lines containing them.
7. Call lv_obj_align(lbl_value, lbl_ref, LV_ALIGN_OUT_LEFT_MID. 0. 0)
8. Repeat steps above where relivant for each line.

or something similar.
Layout 2,
Display Module
    Good packets per second : 120.0
              Request count : 15426391
               Good packets : 15297303,    99.16%
                Bad packets : 0,            0.00%
      Not addressed packets : 0,            0.00%
                No response : 129088,       0.84%
                  Run count : 30561677
Field Module
    Good packets per second : 113.8
              Request count : 14630007
               Good packets : 14515661,    99.22%
                Bad packets : 31,           0.00%
      Not addressed packets : 0,            0.00%
                No response : 114314,       0.78%
                  Run count : 29398852

As I understand things, to achieve this one would need to,
1. Create a label with a " : " (space : space) as a reference point (lbl_ref) at the desired justification location (to the right of where the collumns starting with "Good packets per second" (lbl_desc)) is,
2. Call lv_obj_align(lbl_desc, lbl_ref, LV_ALIGN_OUT_LEFT_MID, 0, 0)
3. Call lv_obj_align(lbl_value, lbl_ref, LV_ALIGN_OUT_RIGHT_MID, 0, 0)
4. Create a label with a "%" as a reference point (lbl_ref) at the desired justification location (on the lines containing them.
5. Call lv_obj_align(lbl_value, lbl_ref, LV_ALIGN_OUT_LEFT_MID. 0. 0)
6. Repeat steps above where relivant for each line.

or something similar.

Firstly is there a more elegant/efficient way to achieving this type of justification ?
If not, would it be possible to add left, right and perhaps center justification options to label texts in the future ?
I imagine this could be achieved either by adding other LV_LABEL_ALIGN options or adding a justification member to the text struct in lv_style_t.

Thanks in advance for your consideration of this matter and look forward to your response.

Hi,
For me, Layout 2 seems easier to implement in an elegant way. The key is you can use \n in the label's text to add a  line break

Create a label with LV_LABEL_ALIGN_RIGHT for the description with a text like this:

"Good packets per second : \n
Request count : \n
Good packets : \n
..."

Crate a similar label for the values with LV_LABEL_ALIGN_LEFT
Crate a similar label for the percentages with LV_LABEL_ALIGN_LEFT
Set the psotion of the desc label with lv_obj_set_pos(desc, 30, 20) or align it to the   Display Module title wih lv_obj_align(desc, title, LV_ALIGN_OUT_BOTTOM_LEFT, 30, 0)
Align the values to the desc: lv_obj_align(values, desc, LV_ALIGN_OUT_LEFT_TOP, 5, 0);
Align the pcts to the values: lv_obj_align(pcts, values, LV_ALIGN_OUT_LEFT_TOP, 5, 0);

Hi Gabor,
Thanks for your response,
The difficulty with that is one would need to deal with the layout order separatly from the lines.
I often have the need to display a number of eliments in a similar way to what I described above.
For example take the following,

 <.....Value....>
..

..

Sometimes needing the Values to be right, left or center justified.
Where the description and units are static and value changes.
I have created descriptors and code that deals with them to set the layout up and then only update the values when they change. They way I do it is to have 3 separate labels.
Also sometimes different font sizes are involved as well.
As I see it it can be made to work the way that you describe, but it seems unwieldy to me. If there were a way to specify justification of lables, this would be made vastly simpler.

If there were a way to specify justification of lables, this would be made vastly simpler.

Do you mean to specifiy the justification line by line? Or even inside a line?
The current lv_label certainly can't do this. It can justify only the whole label with lv_label_set_aling()
Maybe what you would need is a tabular-like object (it doesn't exists right now) where each call can have different text and justification.

How do you mean: "justification of individual lables and elements inside a line would offer the greatest flexibility"? Let's say we have a  text: "Speed1: 11 km/h". How to configure it? Tell the position of each word or "part"? For example:
"<100:right> Speed1 <100:left>: <150:right>11 <150:left>km/h"
                        100               150
                   Speed |:             11 | km/h

Yes, something of that nature that would be terrific.

As I see it rather looks like a tabular E.g lv_tabular_set_cell_values(tabular1, 3, 7, "mA")  to set the [3;7] cell to "mA". And lv_tabular_set_cell_align(tabular, 3, 7, LV_LABEL_ALIGN_RIGHT ).

If there is support for justification of individual fields then it would pobably do the trick.
Also it would be usefull to have an option to display with or without a table frame.

Also it would be usefull to have an option to display with or without a table frame.

It's just the question of the styles :)

So in a field could occupy a certain width, but each with its own justification option (left, right or centered).

Yes, exactly! If you are interested in implementing this object type, I gladly help in it.

I am in the middle of a project wich needs it at the moment, once I am done I will gladly share it and we can refine it to make it as general purpose/flexible as possible.


Revert "[Snyk] Security upgrade node from 14 to 20.6"

Reverts TheRedHatter/brokencrystals#85

Checkmarx One – Scan Summary & Details – 9c02f4d7-c921-4536-b53d-b40df2927684
No New Or Fixed Issues Found


Description
Create the button component with tokens and new styles. The button should be backwards compatible with v1, this means that the same selectors should be used to style buttons. In addition to that, style default buttons (buttons without classes) as secondary buttons and submit buttons as primary buttons.
Design
https://www.figma.com/design/JIT5AdGYqv6bDRpfBPV8XR/Foundations-%26-Components-Next-Level?node-id=17-163
Tokens

[x] Tokens for this component are ready

Development
The button should be backwards compatible, therefore the current class selectors should stay the same for the new Design. Additionally, buttons without any classes should be styled as follows:

<button>Action</button> or <input type="button" value="Action" /> should be displayed as a secondary buttons
<button type="submit">Submit</button> or <input type="submit" value="Submit" /> should be styled as primary buttons

There are no animated buttons anymore. Remove the animated button styles and create a breaking changeset for these. Also, create an optional migration, because there is no need to update the button html structure, the class btn-animated will not do anything and the span inside does not hurt.
Tasks
### 💻 Tasks
- [x] Review Design (All states present? Possible to implement?)
- [ ] https://github.com/swisspost/design-system/issues/3496
- [ ] HTML/CSS implementation
- [ ] Variants: Primary, Secondary, Tertiary, Icon only
- [ ] Style buttons without classes according to type
- [ ] Remove animated button styles
- [ ] Write optional migration instructions to remove animated buttons from code
- [ ] Documentation in Storybook
- [ ] Visual regression tests
- [ ] Design review

@Vandapanda please add the disabled stroke tokens here as well:

stroke-color
stroke-width
stroke-dasharray

can be found as

post-button-primary/secondary/tertiary-disabled-stroke
post-button-border-width (no changes from enabled to disabled, always has a border just sometimes same color)
post-button-border-style-disabled

See resolution on #3710 for sizing class handling


Some Style Changes

Primarily just some stylistic adjustments.
Not sure if youd want those or not but making this PR just as an option

Readded the keys i missed

Some of these changes look good. Others I question. I will probably go through and cherry-pick ones that I like at some point.

Some of these changes look good. Others I question. I will probably go through and cherry-pick ones that I like at some point.

Curious about which ones you question, but beyond my curiosity that sounds good yeah, glad you found some of it useful.

Added some of these changes in v1.2.1 https://github.com/Nytra/NeosColorMyLogiX/releases/tag/v1.2.1

Added some of these changes in v1.2.1 https://github.com/Nytra/NeosColorMyLogiX/releases/tag/v1.2.1


Take ML course - Jordan, Maria, Vinni, Steven

Course Link
Tentative Plan: Watch vid on Friday, 9/22

Complete.


Cannot load llama model

Using the one that was specified in the feature guide, does not load and leads to the following error. What am I doing wrong?
For reference, command to start langflow is run in the same folder as the models folder is. I do execute the langflow command outside of C, so don't know if that maybe is the reason (models folder is where the command is executed, not at C)
The error is the following:
ValueError: Error building node LlamaCpp: Could not load Llama model from path:
./models/ggml-vicuna-13b-4bit.bin
INFO:     <IP_ADDRESS>:64396 - "POST /validate/node/dndnode_2 HTTP/1.1" 500 Internal Server Error

I encountered the same error.

Try using the complete path.
I used llamacpp model yesterday. I'll give another try and report back.

I encountered the same error as yours a few days ago and I think it was because of model versioning issue.
I then downloaded this one: ggml-vic7b-q4_0.bin and it works now.

I encountered the same error as yours a few days ago and I think it was because of model versioning issue.
I then downloaded this one: ggml-vic7b-q4_0.bin and it works now.

Gonna try this later. If it works, you're a lifesaver!

currently using langflow on my windows laptop.
currently i don't know how to fill the Model Path field, using relative or absolute paths ????
any advice


Open discussions for this repository

Description of request
Hi, I think it would be nice to have a place to discuss Huak.
I wanted to ask what Huak means and how do I pronounce it? 😄
Nice idea to have it all in one tool including pyenv-like features!

Yeah, I meant GH Discussions... but I was not aware of the Discord!


Upgrade Istio Suite of Addons with CNI and Ingress Gateway Addons.

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Added a few comments, I think it is a great start but we will need to solve the use cases I mentioned in the comments.

@shapirov103 All Comments fixed, resolved, please double check and let me know.

/do-e2e-tests

/do-e2e-tests

/do-e2e-tests

/do-e2e-tests

/do-e2e-tests


Does FasterTransformer support flash attention

Hi, does FasterTransformer support flash attention?

Yes. The kernels with xxx_flash_attention_xxx in https://github.com/NVIDIA/FasterTransformer/tree/main/3rdparty/trt_fused_multihead_attention are flash attention kernels.

In the process of using the flash attention, I have two questions. The first question, I found that using FMHA_ ENABLE=ON, there may be precision problem. Is there any way to solve that? The second question, I found that flash attention is implemented by assembly code . Could you provide the source code in C++/CUDA?

No and no.

In the process of using the flash attention, I have two questions. The first question, I found that using FMHA_ ENABLE=ON, there may be precision problem. Is there any way to solve that? The second question, I found that flash attention is implemented by assembly code . Could you provide the source code in C++/CUDA?

No and no.

Is it because the kernels of flash attention cannot be open sourced?

@hujiaxin0 what precision problem are you referring to?

Also, @byshiue it's maybe a little unclear to me how to know whether flash attention is being used - is this exposed in any of the models that are currently in the repo?

@hujiaxin0 what precision problem are you referring to?

By setting the environment variable FMHA_ENABLE=ON, and then the output of model is useless. When unsetting the environment variable FMHA_ENABLE, the the output of model is normal.
I found the reply in this issue https://github.com/NVIDIA/FasterTransformer/issues/548#issuecomment-1499899742, which mentioned that FMHA bring further accuracy concerns.
Since I can't see the internal implementation of the flash attention kernel, I can't debug this problem.
I hope you can give me some advice on debugging this problem. @ankit-db

I'm not an expert on the FMHA environment variable, so I can't really help much here.
That being said, accuracy concerns is totally different than "output is garbage", so I'm guessing you've run into some more problematic issue? @byshiue do you mind clarifying what accuracy concerns are?

how to use fuse mha layer in pytorch ?


fix "password contains '@'" bug

https://github.com/influxdb/telegraf/issues/297

@cornerot why did you close this?

Because https://github.com/influxdb/telegraf/issues/297#issuecomment-150191038


Fuse Support, Inode Cache and Snapshots

Hello!
Thank you so much for this clean repository! I was wondering if there exists any new progress/attempt on Fuse support and Inode Cache. Also, do you ever consider to have listing snapshots, etc. in this implementation?
Thanks!

Thanks. I'm very interested in getting fuse support for the abstract file system interfaces in general but I haven't had the time in recent months to get that project going.  I have some direct use cases for ram caching, though, so that feature will probably get some love in the coming days.
Related,  I'm in the middle of writing a new absfs fillesystem package for metadata that will likely contribute to these other features in one way or another, so I'd say all in all your timing is good and you can expect to see some movement in this repo in the coming weeks.

This is great! I look forward to seeing these features! I have been reading the source of the bolt and since it is CoW, I thought it would be nice to see snapshots exposed as a part of a filesystem.
I will explore more and more on this boltfs and its interactions with bolt to get a clear understanding of CoWfs semantics.

I am really very curious about the interaction of in-ram cache with the bolt's RWTxn's cache where it can read/write.
Saving a node to disk? Crash-safe node updates etc.

I look forward to your changes!

Is there any progress on the issue you mentioned in this thread?

I have been working on this, yes. I've made progress on boltfs performance and general bug fixes. I'm on an experimental branch that I haven't merged in a while, so I'll do some cherry picking push some updates.
I have not started the fuse implementation.  I think that should be a new absfs repo that should base the fuse implementation on top of the absfs interfaces which then gives one the ability to back a fuse mount with any absfs filesystem implementation. I'll go ahead and set up a repo for fuse so that further details and discussion can go there.

Thank you so much for the update. I would be very happy/grateful to look at them, are they in a private repo?

The work I've been doing is all in my local repo.  It's a bit of a mess so I'll just do some clean up and push it here.

Thanks, I look forward to them

Created issues for tracking snapshot feature development #3, and and inode caching #4.  Further discussion of those topics should move to those issues.
I'll keep this issue open for now, but the fuse topic will ultimately move to the new fuse repo once it's been setup.

Great! FUSE is not that urgent for me right now, but I would look forward to seeing your other updates, and seeing those as soon as possible for you would be great :) T


[Documentation] Grammar Fixes

describe your changes...
did basic grammatical fix for better reliability

[x] Read and sign the [CLA][1]. PRs that haven't signed it won't be accepted.
[x] Make sure your PR complies with the [writer's guide][2].
[x] Review the diff carefully as sometimes this can reveal issues.
[x] Do not abandon your Pull Request: [Stale Pull Requests][3].

Thanks but I don't think those changes are either right or necessary.


Remove unused Azure config items from SkyplaneConfig

Removing unnecessary config fields azure_tenant_id and azure_client_secret which were used by the previous version of Azure authentication

@abiswal2001 Please resolve conflicts and merge this PR.

@abiswal2001 Can we merge this?


Test runner: Detect extra property in 'actual' but not in 'expected'.

Also update all expected.json where this would result in errors.

Q
A

Bug fix?
no

Breaking change?
no

New feature?
no

Deprecations?
no

Spec compliancy?
no

Tests added/pass?
Tests modified to check for extra properties. Tests pass.

Fixed tickets

License
MIT

Noticed that extra properties on a node were not resulting in test failures. This meant that if an expected.json was originally created without some properties present, those properties would be left untested.

Hey @andy-ms! It looks like one or more of your builds have failed.

Node v4 - linux
Node v6 - linux
Node v7 - linux
Node vnode - linux

Hey @andy-ms! It looks like one or more of your builds have failed.

Node v4 - linux
Node v6 - linux
Node v7 - linux
Node vnode - linux

Hm, the "babel" tests have lots of failures in travis but show up as passed? https://travis-ci.org/babel/babylon/jobs/210088550


Added HANSENBERG

Homepage: https://hansenberg.dk/
Mails looks like this<EMAIL_ADDRESS>

@AlexanderNorup Could you please provide us with an URL of a page on the official website where an IT-related long-term (>1 year) course is offered by the university.

Sure! Here's a few examples:
Webdeveloper: https://hansenberg.dk/uddannelser/erhvervsuddannelser/teknologi-byggeri-og-transport/grundforloeb-1-gaming/webudvikler/
Data and communications: https://hansenberg.dk/uddannelser/erhvervsuddannelser/teknologi-byggeri-og-transport/grundforloeb-1-gaming/data-og-kommunikation/
Graphics Designer: https://hansenberg.dk/uddannelser/erhvervsuddannelser/teknologi-byggeri-og-transport/grundforloeb-1-medie/mediegrafiker/
The 3 examples above are "industrial educations" (EUD,  Erhvervsuddannelse), and they last a total of 5 years.
The following is an academic education (HTX, tekniske skole), where students choose a "path". Several of these paths include "programming" and "Communications and IT". These educations last 3 years.
https://hansenberg.dk/uddannelser/hansenberg-tekniske-gymnasium/
For reference on the danish education system, please go to: https://en.wikipedia.org/wiki/Education_in_Denmark
(The educations at HANSENBERG, are all "vocational secondary educations", and start at age 15-16)

@AlexanderNorup Thank you for the clarification! Pull request merged.


wrap_dataset_for_transforms_v2 with transforms not working as intended

🐛 Describe the bug
When using the wrap_dataset_for_transforms_v2 wrapper for torchvision.datasets classes it seems that the transform being passed during instantiation of the dataset is not utilized properly. The issue was observed the VOCDetection dataset:

when using RandomCrop, passing it to VOCDetection and wrapping it by wrap_dataset_for_transforms_v2, the image gets cropped, but the bounding boxes are unaffected (image in the middle)
when not passing any transform, but instead applying the transform manually outside of the wrapped dataset, it works as intended (image on the right)
image on the left is the original without cropping

Code to reproduce:
from random import Random
from torchvision.datasets import (
    wrap_dataset_for_transforms_v2,
    CocoDetection,
    VOCDetection,
    Cityscapes
)
from torchvision.transforms import ToTensor
from torchvision.transforms.v2 import Compose, RandomCrop, ToImage, ToDtype
import torch
import matplotlib.pyplot as plt
from torchvision.utils import draw_bounding_boxes

transform1 = ToTensor()
transform2 = Compose([ToImage(), ToDtype(torch.float32, scale=True), RandomCrop((360, 360))])
ds1 = wrap_dataset_for_transforms_v2(VOCDetection("./voc", transform=transform1, download=True))
ds2 = wrap_dataset_for_transforms_v2(VOCDetection("./voc", transform=transform2))
ds3 = wrap_dataset_for_transforms_v2(VOCDetection("./voc"))

fig, ax = plt.subplots(1, 3)

# plot original
sample1 = ds1[0]
img1 = sample1[0]
boxes1 = sample1[1]["boxes"]
img1_w_boxes = draw_bounding_boxes(img1, boxes1, width=3, colors="green")
ax[0].imshow(img1_w_boxes.permute(1,2,0))

# plot wrongly transformed boxes
sample2 = ds2[0]
img2 = sample2[0]
boxes2 = sample2[1]["boxes"]
img2_w_boxes = draw_bounding_boxes(img2, boxes2, width=4, colors="green")
ax[1].imshow(img2_w_boxes.permute(1,2,0))

# properly transform manually
sample3 = ds3[0]
img3 = sample3[0]
boxes3 = sample3[1]["boxes"]
img3, boxes3 = transform2(img3, boxes3) # manual transform
img3_w_boxes = draw_bounding_boxes(img3, boxes3, width=3, colors="green")
ax[2].imshow(img3_w_boxes.permute(1,2,0))

fig.show()

Versions
Collecting environment information...
PyTorch version: 2.5.1
Is debug build: False
CUDA used to build PyTorch: None
ROCM used to build PyTorch: N/A

OS: macOS 15.1 (arm64)
GCC version: Could not collect
Clang version: 16.0.0 (clang-16<IP_ADDRESS>)
CMake version: Could not collect
Libc version: N/A

Python version: 3.12.7 | packaged by conda-forge | (main, Oct  4 2024, 15:57:01) [Clang 17.0.6 ] (64-bit runtime)
Python platform: macOS-15.1-arm64-arm-64bit
Is CUDA available: False
CUDA runtime version: No CUDA
CUDA_MODULE_LOADING set to: N/A
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

CPU:
Apple M3

Versions of relevant libraries:
[pip3] numpy==1.26.4
[pip3] pytorch-lightning==2.4.0
[pip3] torch==2.5.1
[pip3] torchmetrics==1.5.1
[pip3] torchvision==0.20.1
[conda] Could not collect

Hi @liopeer , thanks for the report.
It took me a while to understand what's going on: the issue is with the transform parameter. It should be transforms.
The transform parameter can only transform the input image, it cannot transform the target (where the bounding boxes are).
I would agree it may be a bit surprising, but these 2 parameters were introduced long-before the v2 transform and wrap_dataset_for_transforms_v2. One way to look at it is that even before the introduction of the v2 transforms, using transform=... would not enable you to transform the bounding boxes. So, it's a bit surprising, but I'm not sure we could have gone for something different here.

I think the original problem was addressed, so I'll close it. LMK if you think there's anything we could clarify within the docs @liopeer!

For anyone coming across this: The only thing to make above example work is to change the following line
ds1 = wrap_dataset_for_transforms_v2(VOCDetection("./voc", transform=transform1, download=True))

to
ds1 = wrap_dataset_for_transforms_v2(VOCDetection("./voc", transforms=transform1, download=True))


Record Submit Button time

The submit button is a form of input, and we may want to treat it similar to how we treat prompt inputs - let the user name it and use it later in a condition (ie, the submit time less than xyz, etc)

Complete in https://github.com/Watts-Lab/deliberation-empirica/pull/815


The releases projects should have integration tests

It should be possible to run a test release, either periodically or on PRs, to catch errors before we try to actually perform a real release.

We talked about the practicality of this and it seemed unsure.

This has been discussed quite a few times. We think it's possible but quite difficult and there are alteratives.

Do a pre release right before the real release
Scrub the broken release and make a new one
Dry run has some minor coverage


[Op support] Dot3D support

This commit adds implementation for 3 dimensional dot operation.

[x] I am not making a trivial change, such as fixing a typo in a comment.
[x] I have written a PR description following these
rules.
[x] I have run pre-commit run --from-ref origin/main --to-ref HEAD.
[x] This PR does not need a test because It enables test_dot3d from test_core pytest suit.
[x] I have not added any lit tests.

Difficult to test locally, still investigating some strange fails.
Don't merge, please - maybe I missed something.

Difficult to test locally, still investigating some strange fails.
Don't merge, please - maybe I missed something.

Mostly fixed, in fp16 and out fp16 produces mismatch.


Allow to customize status line in terminal windows

Motivation

readonly, filename, modified... They're boring in terminal windows.
In there, I want to see other informations in the terminal.

Change point

Add a new configuration parameter g:lightline.terminal like g:lightline.active and g:lightline.inactive
Change a function lightline#statusline(inactive) that it can receive terminal parameter.
Hook a new event TerminalOpen to update lightline status.
Add new useful components, termtitle and buftype for terminal mode.

Customizing the statusline in terminal windows is currently available via component functions. The following configuration may be boring, but terminal is nothing but a buffer where buftype is terminal. Adding terminal as a special support target in lightline results into increasing number of special buffers support, help buffer, preview window, etc. As terminal windows can be easily detectable in user's configuration and component functions works well, I cannot accept your pull request.
let g:lightline = {
      \ 'active': {
      \   'left': [ [ 'mode', 'paste' ], [ 'readonly', 'filename', 'modified', 'terminalinfo' ] ],
      \ },
      \ 'component_function': {
      \   'filename': 'LightlineFilename',
      \   'modified': 'LightlineModified',
      \   'terminalinfo': 'LightlineTerminalInfo',
      \ },
      \ }

function! LightlineModified() abort
  return &buftype ==# 'terminal' ? '' : &modified ? '+' : &modifiable ? '' : '-'
endfunction

function! LightlineFilename() abort
  return &buftype ==# 'terminal' ? '' : expand('%:t') !=# '' ? expand('%:t') : '[No Name]'
endfunction

function! LightlineTerminalInfo() abort
  return &buftype ==# 'terminal' ? 'TERMINAL INFORMATION' : ''
endfunction

Adding terminal as a special support target in lightline results into increasing number of special buffers support, help buffer, preview window, etc.

I see. Thanks!


For Word Application:Increase/Decrease Font-Size

Can you please change the hotkeys for:
Increase Font-Size: ctrl+shift+>
Decrease Font-Size: ctrl+shift+<

Are there native shortcut for such functions?
If so, you can assign them to ctrl+shift+> and < by private.xml.


[BEAM-3506] - Add a feature in JdbcIO that allows writing PCollection<Iterable>

This PR adds a feature to JdbcIO that allows PCollection<Iterable> to be the input of a write in addition to the current PCollection. Each Iterable is written to the database as one batch. This allows the user to determine the size of the batches, and also to have different sizes of batches based on the actual data.
Writing data in (large) batches has a significantly positive effect on the performance when writing to cloud databases such as Google Cloud Spanner. This example project illustrates how to use this feature in combination with Google Cloud Spanner: https://github.com/olavloite/spanner-beam-example

Apologies, I forgot about this PR. But yeah, we have a workaround and this issue didn't come up again, so I'm going to close. Thanks!


Update the dependencies

update the vulnerable dependencies needed

Hey Ishaan I would like to contribute to your repo but I am new to all this. Can you guide me ?

Hi. I would like to contribute to this. Happy Hacking!

Hi. I would like to contribute to this. Happy Hacking!

Sure


[#4053] Add unit tests for HTTP and SPDY headers

Motivation:
When attempting to retrieve a SPDY header using an AsciiString key, if the header was inserted using a String based key, the lookup would fail. Similarly, the lookup would fail if the header was inserted with an AsciiString key, and retrieved using a String key. This has been fixed with the header simplification commit (1a43923aa89769ae3711e0d9451abfdee4a4327c).
Extra unit tests have been added to protect against this issue occurring in the future.  The tests check that a header added using String or AsciiString can be retrieved using AsciiString or String respectively.
Modifications:
Added more unit tests
Result:
Protect against issue #4053 happening again.

@Scottmitch - FYI.

@blucas thanks... Cherry-picked into master as e8a4e2af1fa74d0607cf5e0c4d6034059f0f015d

Cherry-picked into 4.1 (e796c99)


iPad Pro not recognised

When emulating an iPad Pro, the "device not recognised" error is thrown. The issue that it links to has been closed, so I am creating a new one. I am using xCode to emulate the device.
The user agent is as follows:
Mozilla/5.0 (iPad; CPU OS 9_2 like Mac OS X) AppleWebKit/601.1.46 (KHTML, like Gecko) Version/9.0 Mobile/13C75 Safari/601.1

Ok, so adding a definition for the iPad Pro in the scream spec helped:
[2048, 2604, 2732, 1920, 1024, 1366, 2, 'iPad Pro']
The values in the spec for the iPhone 6 etc - how where they calculated? I need to set the same ones for window.innerWidth & window.innerHeight for the iPad Pro, but the value of window.innerWidth of the iPhone 6 for instance is much different to what is in the  scream spec. If you could let me know how they where calculated I can make a PR

The values in the spec for the iPhone 6 etc - how where they calculated?

https://github.com/gajus/scream/blob/master/.spec/ruler.js

Capturing these values is not automated though:

Use an emulator to run iPad Pro
Use https://github.com/gajus/scream/blob/master/.spec/ruler.js to capture device information in all states (e.g. https://github.com/gajus/scream/blob/master/.spec/iPhone 6.txt)
Create a spec file https://github.com/gajus/scream/tree/master/.spec
Add definition to https://github.com/gajus/scream/blob/cfde779a7730c0c9c31c18710dfb12989ca8a56e/src/scream.js#L139-L152

Thanks for the help :)
PR submitted: https://github.com/gajus/scream/pull/8