HDDS-1863. Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
50
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
615
trunk passed

+1
compile
349
trunk passed

+1
checkstyle
62
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
790
branch has no errors when building and testing our client artifacts.

+1
javadoc
144
trunk passed

0
spotbugs
412
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
598
trunk passed

_ Patch Compile Tests _

+1
mvninstall
525
the patch passed

+1
compile
342
the patch passed

+1
javac
342
the patch passed

+1
checkstyle
63
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
619
patch has no errors when building and testing our client artifacts.

+1
javadoc
141
the patch passed

+1
findbugs
619
the patch passed

_ Other Tests _

-1
unit
293
hadoop-hdds in the patch failed.

-1
unit
1822
hadoop-ozone in the patch failed.

+1
asflicense
36
The patch does not generate ASF License warnings.

7233

Reason
Tests

Failed junit tests
hadoop.ozone.TestStorageContainerManager

hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures

hadoop.ozone.om.TestScmSafeMode

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.ozone.client.rpc.TestOzoneRpcClient

hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1167

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux a3d800fa42c7 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 6b8107a

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/1/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/1/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/1/testReport/

Max. process+thread count
4662 (vs. ulimit of 5500)

modules
C: hadoop-ozone/tools U: hadoop-ozone/tools

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
67
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
606
trunk passed

+1
compile
369
trunk passed

+1
checkstyle
78
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
874
branch has no errors when building and testing our client artifacts.

+1
javadoc
151
trunk passed

0
spotbugs
417
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
610
trunk passed

_ Patch Compile Tests _

+1
mvninstall
544
the patch passed

+1
compile
358
the patch passed

+1
javac
358
the patch passed

+1
checkstyle
67
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
646
patch has no errors when building and testing our client artifacts.

+1
javadoc
151
the patch passed

+1
findbugs
629
the patch passed

_ Other Tests _

-1
unit
346
hadoop-hdds in the patch failed.

-1
unit
2351
hadoop-ozone in the patch failed.

+1
asflicense
36
The patch does not generate ASF License warnings.

8028

Reason
Tests

Failed junit tests
hadoop.ozone.client.rpc.TestHybridPipelineOnDatanode

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

hadoop.hdds.scm.pipeline.TestRatisPipelineProvider

hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException

hadoop.ozone.client.rpc.TestOzoneRpcClient

hadoop.ozone.om.TestScmSafeMode

hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1167

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 71d21296cc80 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / aebac6d

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/2/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/2/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/2/testReport/

Max. process+thread count
3957 (vs. ulimit of 5500)

modules
C: hadoop-ozone/tools U: hadoop-ozone/tools

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
100
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
675
trunk passed

+1
compile
364
trunk passed

+1
checkstyle
64
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
847
branch has no errors when building and testing our client artifacts.

+1
javadoc
168
trunk passed

0
spotbugs
423
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
612
trunk passed

_ Patch Compile Tests _

+1
mvninstall
548
the patch passed

+1
compile
379
the patch passed

+1
javac
379
the patch passed

+1
checkstyle
82
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
691
patch has no errors when building and testing our client artifacts.

+1
javadoc
165
the patch passed

-1
findbugs
429
hadoop-ozone generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

-1
unit
349
hadoop-hdds in the patch failed.

-1
unit
2045
hadoop-ozone in the patch failed.

+1
asflicense
40
The patch does not generate ASF License warnings.

7959

Reason
Tests

FindBugs
module:hadoop-ozone

Dead store to randomValue in org.apache.hadoop.ozone.freon.RandomKeyGenerator.createKey(long)  At RandomKeyGenerator.java:org.apache.hadoop.ozone.freon.RandomKeyGenerator.createKey(long)  At RandomKeyGenerator.java:[line 683]

Failed junit tests
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory

hadoop.hdds.scm.pipeline.TestRatisPipelineProvider

hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures

hadoop.ozone.client.rpc.TestOzoneRpcClient

hadoop.ozone.om.TestScmSafeMode

hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1167

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux ead716919039 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 60325c9

Default Java
1.8.0_212

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/3/artifact/out/new-findbugs-hadoop-ozone.html

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/3/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/3/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/3/testReport/

Max. process+thread count
4276 (vs. ulimit of 5500)

modules
C: hadoop-ozone/tools U: hadoop-ozone/tools

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
131
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
834
trunk passed

+1
compile
459
trunk passed

+1
checkstyle
93
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
1141
branch has no errors when building and testing our client artifacts.

+1
javadoc
218
trunk passed

0
spotbugs
517
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
766
trunk passed

_ Patch Compile Tests _

+1
mvninstall
722
the patch passed

+1
compile
394
the patch passed

+1
javac
394
the patch passed

-0
checkstyle
39
hadoop-ozone: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
728
patch has no errors when building and testing our client artifacts.

+1
javadoc
163
the patch passed

+1
findbugs
707
the patch passed

_ Other Tests _

-1
unit
348
hadoop-hdds in the patch failed.

-1
unit
2085
hadoop-ozone in the patch failed.

+1
asflicense
44
The patch does not generate ASF License warnings.

9091

Reason
Tests

Failed junit tests
hadoop.hdds.scm.block.TestBlockManager

hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

hadoop.ozone.om.TestSecureOzoneManager

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

hadoop.ozone.om.TestScmSafeMode

hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures

hadoop.ozone.TestMiniOzoneCluster

hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures

hadoop.ozone.client.rpc.TestOzoneRpcClient

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1167

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 8972131a09a7 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 611718f

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/4/artifact/out/diff-checkstyle-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/4/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/4/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/4/testReport/

Max. process+thread count
5261 (vs. ulimit of 5500)

modules
C: hadoop-ozone/tools U: hadoop-ozone/tools

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/4/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

+1

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
82
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
672
trunk passed

+1
compile
419
trunk passed

+1
checkstyle
69
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
1037
branch has no errors when building and testing our client artifacts.

+1
javadoc
183
trunk passed

0
spotbugs
450
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
684
trunk passed

_ Patch Compile Tests _

+1
mvninstall
560
the patch passed

+1
compile
372
the patch passed

+1
javac
372
the patch passed

+1
checkstyle
76
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
722
patch has no errors when building and testing our client artifacts.

+1
javadoc
167
the patch passed

+1
findbugs
648
the patch passed

_ Other Tests _

-1
unit
357
hadoop-hdds in the patch failed.

-1
unit
2072
hadoop-ozone in the patch failed.

+1
asflicense
44
The patch does not generate ASF License warnings.

8341

Reason
Tests

Failed junit tests
hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

hadoop.ozone.om.TestSecureOzoneManager

hadoop.ozone.om.TestScmSafeMode

hadoop.ozone.TestMiniOzoneCluster

hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures

hadoop.ozone.client.rpc.TestOzoneRpcClient

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1167

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux c6debda2dd09 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 611718f

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/5/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/5/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/5/testReport/

Max. process+thread count
5274 (vs. ulimit of 5500)

modules
C: hadoop-ozone/tools U: hadoop-ozone/tools

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/5/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
84
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
604
trunk passed

+1
compile
404
trunk passed

+1
checkstyle
74
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
945
branch has no errors when building and testing our client artifacts.

+1
javadoc
169
trunk passed

0
spotbugs
474
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
681
trunk passed

_ Patch Compile Tests _

+1
mvninstall
585
the patch passed

+1
compile
394
the patch passed

+1
javac
394
the patch passed

+1
checkstyle
75
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
753
patch has no errors when building and testing our client artifacts.

+1
javadoc
186
the patch passed

+1
findbugs
738
the patch passed

_ Other Tests _

+1
unit
359
hadoop-hdds in the patch passed.

-1
unit
2121
hadoop-ozone in the patch failed.

+1
asflicense
44
The patch does not generate ASF License warnings.

8371

Reason
Tests

Failed junit tests
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.ozone.client.rpc.TestOzoneRpcClient

hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

hadoop.ozone.om.TestScmSafeMode

hadoop.ozone.client.rpc.TestCommitWatcher

hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory

Subsystem
Report/Notes

Docker
Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1167

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux c1f6d5f0c2ef 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 32607db

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/6/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/6/testReport/

Max. process+thread count
4797 (vs. ulimit of 5500)

modules
C: hadoop-ozone/tools U: hadoop-ozone/tools

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/6/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
131
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
748
trunk passed

+1
compile
461
trunk passed

+1
checkstyle
103
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
1168
branch has no errors when building and testing our client artifacts.

+1
javadoc
227
trunk passed

0
spotbugs
555
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
812
trunk passed

_ Patch Compile Tests _

+1
mvninstall
706
the patch passed

+1
compile
439
the patch passed

+1
javac
439
the patch passed

+1
checkstyle
93
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
859
patch has no errors when building and testing our client artifacts.

+1
javadoc
217
the patch passed

+1
findbugs
771
the patch passed

_ Other Tests _

+1
unit
411
hadoop-hdds in the patch passed.

-1
unit
3099
hadoop-ozone in the patch failed.

+1
asflicense
47
The patch does not generate ASF License warnings.

10479

Reason
Tests

Failed junit tests
hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory

hadoop.ozone.om.TestSecureOzoneManager

hadoop.ozone.client.rpc.Test2WayCommitInRatis

hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient

hadoop.ozone.client.rpc.TestBlockOutputStream

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

hadoop.ozone.om.TestScmSafeMode

hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures

hadoop.ozone.client.rpc.TestCommitWatcher

hadoop.ozone.TestMiniOzoneCluster

hadoop.ozone.om.TestKeyManagerImpl

hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures

hadoop.ozone.client.rpc.TestOzoneRpcClient

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1167

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux a4622866266d 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 70b4617

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/7/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/7/testReport/

Max. process+thread count
5370 (vs. ulimit of 5500)

modules
C: hadoop-ozone/tools U: hadoop-ozone/tools

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/7/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
45
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
645
trunk passed

+1
compile
369
trunk passed

+1
checkstyle
64
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
188
branch has no errors when building and testing our client artifacts.

+1
javadoc
142
trunk passed

0
spotbugs
414
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
602
trunk passed

_ Patch Compile Tests _

+1
mvninstall
540
the patch passed

+1
compile
348
the patch passed

+1
javac
348
the patch passed

+1
checkstyle
65
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
710
patch has no errors when building and testing our client artifacts.

+1
javadoc
155
the patch passed

+1
findbugs
646
the patch passed

_ Other Tests _

+1
unit
277
hadoop-hdds in the patch passed.

-1
unit
2236
hadoop-ozone in the patch failed.

+1
asflicense
40
The patch does not generate ASF License warnings.

7221

Reason
Tests

Failed junit tests
hadoop.ozone.client.rpc.TestWatchForCommit

hadoop.ozone.om.TestKeyManagerImpl

hadoop.ozone.om.TestOzoneManagerHA

hadoop.ozone.TestMiniOzoneCluster

hadoop.ozone.client.rpc.TestOzoneRpcClient

hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.ozone.om.TestScmSafeMode

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

hadoop.ozone.client.rpc.TestCommitWatcher

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1167

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 26885d0b72d3 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 397a563

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/8/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/8/testReport/

Max. process+thread count
4765 (vs. ulimit of 5500)

modules
C: hadoop-ozone/tools U: hadoop-ozone/tools

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/8/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Thank You @xiaoyuyao and @arp7 for the review.
Test failures are not related to this patch. I will commit this to the trunk.


✨ NEW: Initial implementation of GraphQL mutations

@ltalirz @NinadBhat this is a rough initial implementation of the mutation to create a group, e.g.:
mutation {
  groupCreate(label: "hallo", description: "heya") {
    created
    group {
      id
      uuid
      label
      type_string
      description
    }
  }
}

returns:
{
  "data": {
    "groupCreate": {
      "created": true,
      "group": {
        "id": 19,
        "uuid": "7e345722-892d-4764-b820-b4f12921dc67",
        "label": "hallo",
        "type_string": "core",
        "description": "heya"
      }
    }
  }
}

Codecov Report

Merging #24 (c4abeb4) into master (d115033) will decrease coverage by 0.66%.
The diff coverage is 79.48%.

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   92.09%   91.42%   -0.67%
==========================================
  Files          25       25
  Lines         746      781      +35
==========================================
+ Hits          687      714      +27
- Misses         59       67       +8

Flag
Coverage Δ

pytests
91.42% <79.48%> (-0.67%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

aiida_restapi/graphql/groups.py
84.61% <70.00%> (-15.39%)
:arrow_down:

aiida_restapi/graphql/plugins.py
90.00% <88.88%> (-1.31%)
:arrow_down:

aiida_restapi/graphql/main.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d115033...c4abeb4. Read the comment docs.

Thanks @chrisjsewell
Hm... that does indeed look quite a bit more complicated than simply posting a JSON {"label": "hallo", "description": "heya"} to /groups.

Do we have to create custom "mutation methods" for creating / updating / ... each entity that a user has to learn or can one get around this?
While I understand that it is convenient to have the get_or_create functionality, I would probably first try to keep the API simple, i.e. go for group creation only and implement the get_or_create only later if we really need it

that does indeed look quite a bit more complicated than simply posting a JSON

yes but the point is you get structured schema validation, and control exactly the return data you receive. for /groups or whatever POST method, you have to go to the documentation and find out what is going to return, this is a lot more explicit.
Plus, as with queries, you can perform multiple mutation in a single request.
You can always just write mutation {  groupCreate(label: "hallo", description: "heya") { created } }, if you want to be more concise, but the point is the client controls what they receive, and knows by the structure of the request what the structure of the return JSON will be.

each entity that a user has to learn or can one get around this?

what do they have to learn it, its explicitly in the schema

Do we have to create custom "mutation methods" for creating / updating /

you can create whatever mutation you want, but again IMO explicit is better than implicit

In 4b6005f I have added a skeleton implementation of middleware (see https://docs.graphene-python.org/en/latest/execution/middleware/). This allows you to interject before each query resolution / mutation, to run operations such as authentication.
IMO this is a better approach than having to remember to decorate every one of your requests with some authentication function, i.e. it consolidates the "business logic" in a single place

and my final pitch (lol) is that, as with queries, mutations are fully pluggable

FYI I added some links to the initial comment

Thanks for the links to the docs @chrisjsewell
It seems this is indeed the canonical way in graphql...
Are there conventions for the created field? I see the graphene example using ok.
Do we need to have something like this for every entity type?
Another question that comes to mind here is how to handle files.
E.g. say you post a request that creates two SinglefileData nodes - is there some policy for passing the files with the request that associated them to the right mutation?

Another question that comes to mind here is how to handle files.

I thought exactly the same thing. Graphene specifically mentions https://pypi.org/project/graphene-file-upload/ but not satisfied on the best approach yet


iOS < 8.4 Not Polyfilled

This situation is detected properly, and the polyfill is called, but it does not implement any of the CSS rules.

Well, that's not very nice.  The W3C Media Queries Recommendation states that:

User agents are to represent a media query as "not all" when one of the specified media features is not known.

All of the browsers that I tested prior to iOS have implemented this correctly; in fact for other unknown media features, the Safari in iOS7 seems to respond correctly.  It's just the pointer:coarse media feature that isn't being properly turned into not all and therefor confounding the code.
I may be able to work around this simply by tweaking the regex, which is a bummer - the way it's set up now is a little 'safer' in that it was designed to ensure that both the deprecated handheld media type AND an unknown media query both appeared in the complete media text.

As it turns out, this was fixed pretty easily.  I wish it didn't require an additional function, but I think using the MediaList object rather than the mediaText property is a good move anyway.


[Bug] RegisterFragment.kt line 68

Problem
Crashes under investigation
Devices experiencing this crash:

Samsung - 35%
Xiaomi - 26%
Huawei - 11%

Environment | Data
https://console.firebase.google.com/u/0/project/litewallet-beta/crashlytics/app/android:com.loafwallet/issues/f21cd1d42251075ecb35133dd1d3acc4?time=last-seven-days&sessionEventKey=6035085701CF000170C0B229DE828C89_1510902463886746485
#Screenshot

Firebase

Fixed in https://github.com/litecoin-foundation/loafwallet-android/pull/222


[FLINK-17547] Support unaligned checkpoints for records spilled to files

What is the purpose of the change
Implement SpillingAdaptiveSpanningRecordDeserializer.getUnconsumedBuffer for records spilled to file (currently, UnsupportedOperationException is thrown).
Brief change log

refactor SpillingAdaptiveSpanningRecordDeserializer; extract SpanningWrapper
extract RefCountingFile and move it to flink-core
implement SpanningWrapper.getUnconsumedBuffer using RefCountingFile

Verifying this change

Added unit tests:  SpanningWrapperTest, MemorySegmentFactoryTest, CloseableIteratorTest
Existing integration test: ChannelPersistenceITCase

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

Thanks for the fast response.
I've added two fixup commits to address the issues.

I've rebased the changes to the latest master and squashed the commits.
Azure build in my private account is green.
@flinkbot run azure


add pastas.timeseries.TimeSeries object to a PastaStore using PastaStore.add_oseries()

I think it would be nice to modify PastaStore.add_oseries() in such a way that the series argument can be a pastas.timeseries.TimeSeries object. Now only pandas DataFrame and Series are supported. It can save you some code, for example when adding a Dino csv file to the store.
Now:
series = ps.read_dino(fname)
store.add_oseries(series.series_original, name=series.name, metadata=series.metadata)

Proposed change:
series = ps.read_dino(fname)
store.add_oseries(series)

What are your thoughts on this?

Good idea!
Only problem I can see is that it might become confusing when the user is not getting back a pastas.TimeSeries object when retrieving data. But making it easy to add pastas.TimeSeries is probably worth that potential (minor) confusion.

The name still has to be passed individually, but timeseries and metadata can be taken from the pastas.TimeSeries object.
series = ps.read_dino(fname)
store.add_oseries(series, series.name)

Closed by #40


gke: Bump gke minimum versions

This is to avoid the below issue
ERROR: (gcloud.container.clusters.create) ResponseError: code=400, message=No valid versions with the prefix "1.24" found.

/ci-gke

Full CI is not required, the related job is triggered successfully. Marking this ready to merge for tophat to review.
https://github.com/cilium/cilium/actions/runs/7827285226


[Test][Lit] Tritongpu to llvm

This PR fixes lit based unitest Conversion/tritongpu_to_llvm.mlir for GCN target.x
related Issue #82

@binarman
This PR has been created as a draft.  Do you plan to add anything else to it?

@rsanthanam-amd

This PR has been created as a draft. Do you plan to add anything else to it?

Yes, I want to double check basic_insert_slice_async_v1_multictas test.
Generated code is different for GCN and PTX, so I want to dig deeper to be sure output is correct.

I consider this PR is not draft anymore :slightly_smiling_face:


possible to change page an image appears on with addImage?

Currently when I addImage to my document they end up on the last page in their correct location. Is there a way to select which page the image should be added to?

Use pdf.setPage(...) before calling addImage.

Thank you! This solved my problem.


[BUG] Multiplex Results/People Screen: Clear filters Button always active, regardless of filters in use

Description
The dark blue "Clear filters" button that appears on the Results and the People screens is always active, even if no filters are currently in use.
Steps to reproduce
Navigate to either the "Results" screen or the "People" screen.
Click on the dark blue "Clear filters" button.
Nothing happens.
Expected behavior
The "Clear filters" button should be inactive when no filters are in use.
Additional context
Bug experienced on a MacBookPro running macOS Monterey Version 12.4
Chrome Version 102.0.5005.61 (Official Build) (x86_64)
Screenshot is attached.

Closed: will revisit at a later time. (06/18/2024)


cont layer: allow to set the number of filters at runtime

(implementation essentially copied from con layer)

Thanks for another PR.  Don't forget to update the abstract.h file's documentation :)

Oops! Fixed.

Sweet.  Thanks for the PR :)


Hide edges for collapsed nodes.

Would it be possible to add the ability to hide all edges for collapsed nodes? Would you like to have this functionality as part of this plugin?
If so I can provide a PR, if you could point me to the proper places. From a quick look it seems that I just need to hook into simpleCollapseNode and simpleExpandNode and hide/show all incoming/outgoing edges.
Or maybe in case of this option we can just make nodes invisible, and edges will not be displayed by default. Any ideas, suggestions are welcome.

Thank you for the response. I didn't know abou the ability to style "meta" edges. I think it is sufficient for my use case to hide/style them differently if needed.
One issue that I observe that all edges for nodes related to compound nodes are marked with "meta" class.
E.g if all compound nodes are expanded so there are no visible "meta" edges for compound nodes. Edges for nodes which are inside compound node are still marked as "meta". I think that "meta" marker should be applied only to artificial edges. Is it a bug?

If so, it's a bug. We'll look into this.


Invoke-SMBRemoting Update

Fixed issue where code won't work on Server2012 + code cleanup (removed redundancy)

Excellent work. Tested in lab and works great.


EXC_BAD_INSTRUCTION on dispatch_block_notify

Im getting an EXC_BAD_INSTRUCTION on GCDBlock.notify when in calls dispatch_block_notify.
The calling cod looks like this:
GCDBlock.async(.Default) {
            ... does she work ...
        }.notify(.Main) {

        }

Any idea?
(Im using Xcode 7.0.1)

@ekampf Thanks for the feedback!
Unfortunately, this was a known bug in Swift 2.0 where dispatch_block API is unusable in swift: https://forums.developer.apple.com/message/50922#50922
They have fixed this in Swift 2.1 (XCode 7.1), but there is currently no workaround with swift code.
For now you can just avoid chaining and write it like this:
GCDBlock.async(.Default) {
    // ...
    GCDBlock.async(.Main) {
        // ...
    }
}

Thanks!

Just a heads up, XCode 7.1 was released in the Mac AppStore today which fixes this bug. GCDKit unit tests now work as they did before :+1:

:+1:


Invalid Logo File

Our Logo file is invalid that is why we have this

This is our logo file https://github.com/GDG-Bambili/devfest-mezam/blob/master/app/images/logo.svg
We need to have something similar to the logo file for GDG Ukraine : https://github.com/gdg-x/hoverboard/blob/master/app/images/logo.svg

Yeah, we will build all these designs once our budget is approved. We'll re work the image files for the DevFest. We are doing the best we can without the budget.


Missing documentation for valid enum value bullets

We are missing valid values for the mfaConfigurations options on this resource: https://www.pulumi.com/docs/reference/pkg/aws/cognito/userpool/#inputs.
It trails off after "Valid values:":

The corresponding source documentation is here: https://github.com/terraform-providers/terraform-provider-aws/blob/master/website/docs/r/cognito_user_pool.markdown:
* `mfa_configuration` - (Optional) Multi-Factor Authentication (MFA) configuration for the User Pool. Defaults of `OFF`. Valid values:
    * `OFF` - MFA tokens are not required.
    * `ON` - MFA is required for all users to sign in. Requires at least one of `sms_configuration` or `software_token_mfa_configuration` to be configured.
    * `OPTIONAL` - MFA will be required only for individual users who have MFA enabled. Requires at least one of `sms_configuration` or `software_token_mfa_configuration` to be configured.

I assume we're not properly parsing the indented sub-bullets.
I wasn't sure if there was an existing item tracking this -- if so, please dupe.

Is this because we're missing some "continuation phrases" to match on in this section?
https://github.com/pulumi/pulumi-terraform-bridge/blob/30d7d6a046545b1226f2e1b81f22bab4b3181b96/pkg/tfgen/docs.go#L263-L272
ex: The create_option property here would need to match on "values include" maybe?

This is fixed in current docs.


I set 'view instance-level information' to deny, but the user can view membership and project.

I want know how organization-level permissions work, I set 'View instance-level information' to deny.
The documentation says permission and membership, and project cannot be displayed.
However, the user does not see the permission, but succeeds in displaying the membership and project.
If the documentation is outdated, please correct it.
Steps to reproduce:

PCA step

access to [Organization Settings] - [Permissions]
change users tab.
Search for the user (one of the valid users).
'View instance-level information' change to deny

user step

access to [Organization Settings] - [Permissions]
Select any security group.
Check permissions is not displayed.
Change to the members tab.
Check members is displayed.
Access any project.
Check the project displayed.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 68686c2b-c69a-d9e4-3e21-a46d231b649c
Version Independent ID: 049659da-1772-3166-f909-4feeb8a97730
Content: Permissions, security groups, and service accounts reference - Azure DevOps
Content Source: docs/organizations/security/permissions.md
Service: azure-devops
Sub-service: azure-devops-security
GitHub Login: @KathrynEE
Microsoft Alias: kaelli

@tomaeda - Thank you for your inquiry.  When you set the View instance-level information to Deny, the user is no longer able to view permission information for any other user or group. They receive the following information:

When you set the View project-level information to Deny, the user is no longer able to view the project at all - therefore, not able to sign in or access the project.
I'm in the process of updating the permissions.md article and will update this issue once that is published.

@tomaeda - Closing this issue as article has been updated with https://github.com/MicrosoftDocs/azure-devops-docs-pr/pull/5179.


Add truncate context for audit logging

Scope & Purpose
Fix mistaken "internal" audit logging for truncate operation

[x] :hankey: Bugfix
[ ] :pizza: New feature
[ ] :hammer: Refactoring
[ ] :book: CHANGELOG entry made
[ ] :muscle: The behavior in this PR was manually tested
[ ] :computer: The behavior change can be verified via automatic tests

Backports:

[x] No backports required
[ ] Backports required for:

Enterprise component: https://github.com/arangodb/enterprise/pull/549
Jenkins: https://jenkins.arangodb.biz/view/PR/job/arangodb-matrix-pr/11823/ (blue except unrelated)

LGTM in general, but I also think we should have tests in place that verify the correct logging of the user name (vs. "internal") in case we are dealing with incoming HTTP/VST requests.

please change the OptionsResult constructor so we do not miss passing the options in
diff --git a/arangod/Utils/OperationResult.h b/arangod/Utils/OperationResult.h
index a5e429beaae..78e619ecbdc 100644
--- a/arangod/Utils/OperationResult.h
+++ b/arangod/Utils/OperationResult.h
@@ -67,7 +67,7 @@ struct OperationResult final {

   // create result with details
   OperationResult(Result result, std::shared_ptr<VPackBuffer<uint8_t>> buffer,
-                  OperationOptions options = {},
+                  OperationOptions options,
                   std::unordered_map<int, size_t> countErrorCodes = std::unordered_map<int, size_t>())
       : result(std::move(result)),
         buffer(std::move(buffer)),

https://jenkins.arangodb.biz/view/PR/job/arangodb-matrix-pr/11855/

https://jenkins.arangodb.biz/view/PR/job/arangodb-matrix-pr/11886/


Fortune 500 quote

the Fortune 500 quote might be revised? the list started in 1955, therefore would it be better to simply say:
As of 2015, only 57 companies were still in the Fortune 500 61 years  <!> after the first publication of the list  appeared in 1955 <!>?
In addition, the list of companies might not be necessarily related to agility and this could be a fallacy, since effectively Fortune tracks fiscal outcome

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 77f12999-c1cc-3996-4773-e22583299a75
Version Independent ID: a1b8ac9e-565b-fa98-41af-a4f6e5fd92ce
Content: Examples of agility outcomes - Microsoft Cloud Adoption Framework for Azure
Content Source: docs/cloud-adoption/business-strategy/business-outcomes/agility-outcomes.md
Service: cloud-adoption-framework
Sub-service: strategy
GitHub Login: @BrianBlanchard
Microsoft Alias: brblanch

@eyast Thank you for your feedback! We will review and provide an update as appropriate.

Thanks so much for this feedback! We'll look to clarify this in an upcoming sprint.


Missing unicode_segmentation::GraphemeIndices equivalent struct

unicode_segmentation::Graphemes can be replaced by finl_unicode::grapheme_clusters::Graphemes.
But there is no replacement for unicode_segmentation::GraphemeIndices.
Would you be interested by providing one ?

I can put it on the roadmap. Do you have a use case for this that I can use for benchmarking/testing?

Not really, but termwiz should be able to remove unicode_segmentation (and keep only finl_unicode).
And rustyline could replace unicode_segmentation by finl_unicode.


[WIP][RFC] ciao-image: Add more logging information

In order to improve debugging, we need more logging in ciao-image service. Below the main events that are planned to be logged.

Init information
Errors reporting
Basic information on image CRUD operations

It will fix #779
Signed-off-by: Obed N Munoz<EMAIL_ADDRESS>

Coverage decreased (-0.08%) to 64.843% when pulling aa3d906e7917ade70919351cd76aa41b99643b0f on obedmr:ciao-image into 43401be4f7cc952a14829945777ee642e7c48dd5 on 01org:master.

Coverage decreased (-0.1%) to 64.805% when pulling aa3d906e7917ade70919351cd76aa41b99643b0f on obedmr:ciao-image into 43401be4f7cc952a14829945777ee642e7c48dd5 on 01org:master.

Coverage decreased (-0.2%) to 64.766% when pulling dcf467e0f4ac664efa72efc1b7c7dede15d24e45 on obedmr:ciao-image into 43401be4f7cc952a14829945777ee642e7c48dd5 on 01org:master.

Coverage decreased (-0.09%) to 64.831% when pulling 1cb3caefb328a4c599d9ff22a4aa5718378cc460 on obedmr:ciao-image into 43401be4f7cc952a14829945777ee642e7c48dd5 on 01org:master.

Coverage decreased (-0.1%) to 64.809% when pulling 1cb3caefb328a4c599d9ff22a4aa5718378cc460 on obedmr:ciao-image into 43401be4f7cc952a14829945777ee642e7c48dd5 on 01org:master.

@obedmr It would be nice to see some Info logs in the various commands.  Right now we won't know if an

@markdryan got it. /me improving the PR. thanks

Coverage decreased (-0.1%) to 64.794% when pulling 384446b2219b4db6879d30a025bfc8921c420ec1 on obedmr:ciao-image into 43401be4f7cc952a14829945777ee642e7c48dd5 on 01org:master.

Coverage decreased (-0.1%) to 64.778% when pulling c678d1125e332a94bfcf1afa7e9f4f3196b91f0a on obedmr:ciao-image into 43401be4f7cc952a14829945777ee642e7c48dd5 on 01org:master.

Coverage decreased (-0.2%) to 64.758% when pulling ea4fff0b814f93a70dd5c09340728447680803c5 on obedmr:ciao-image into 43401be4f7cc952a14829945777ee642e7c48dd5 on 01org:master.

Coverage decreased (-0.2%) to 64.705% when pulling 4639ec46e25eb51e2e5f92044f6ba78d2e99a55d on obedmr:ciao-image into 43401be4f7cc952a14829945777ee642e7c48dd5 on 01org:master.

Coverage decreased (-0.2%) to 64.769% when pulling 4639ec46e25eb51e2e5f92044f6ba78d2e99a55d on obedmr:ciao-image into 43401be4f7cc952a14829945777ee642e7c48dd5 on 01org:master.

@markdryan @rbradford, comments applied.

Coverage decreased (-0.1%) to 64.78% when pulling cf52fd80054130dbc7d54df40e4096072876c21c on obedmr:ciao-image into 7140076e4f19aa09e878d45192b405c5f8bad931 on 01org:master.


disease prediction project

I am creating 2 pull request one for the readme and one for the files.


Snark Proposer Bug - Constraint unsatisfied (unreduced)

Proposers are currently unable to produce blocks.
The snark-worker subprocess is showing 'Constraint unsatisfied (unreduced)' errors.
Attaching a log from a version with extra debug output.
coda.log.gz
Correlated PV keys can be obtained here:
https://s3-us-west-1.amazonaws.com/proving-key-2018-10-01/keys-temporary_hack-testnet_postake.tar.bz2
Observed in build 119106 and later (deb available in artifacts)
https://circleci.com/gh/CodaProtocol/coda/119106

Resolved via https://github.com/CodaProtocol/coda/pull/2472


missing requirement

Missing requirement to grant permissions to the service principal on the resource group

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1f33d707-2a5b-e0f7-2649-9b778d57a1da
Version Independent ID: 3584b4b8-c5f5-2170-3f8a-7a9a33025a84
Content: How to create Linux Azure VM Images with Packer
Content Source: articles/virtual-machines/linux/build-image-with-packer.md
Service: virtual-machines-linux
GitHub Login: @cynthn
Microsoft Alias: cynthn

@hensilva maybe I am not fully understanding the issue. We have steps to create a rbac role as needed
https://docs.microsoft.com/en-us/azure/virtual-machines/linux/build-image-with-packer#create-azure-credentials

@hensilva any update on this?

@hensilva I will close this for now. When ready let me know and we can reopen and continue.

I'm really sorry I was unresponsive about this issue. Below I share problems I faced when following the doc:

Had to add "build_resource_group_name": "myResourceGroup" or packer would complain with the error below:

==> azure-arm: Running builder ...
    azure-arm: Creating Azure Resource Manager (ARM) client ...
Build 'azure-arm' errored: Cannot locate the managed image resource group myResourceGroup2.

==> Some builds didn't complete successfully and had errors:
--> azure-arm: Cannot locate the managed image resource group myResourceGroup2.

==> Builds finished but no artifacts were created.

The service principal created earlier and specified in parameters "client_id", "client_secret", "tenant_id" and "subscription_id" must have permissions on the Build resource group created earlier or it will fail. Process of creating service principal is ok, but it must have permissions assigned so it can do work.

#please-close I'm going to stick with the current instructions because they are specific to the task at hand and don't completely open permissions on the entire sub.

I would not consider this closed - the current instructions don't work at all; without any rights assignment packer fails to build any images.
It was a little while ago that I tested but IIRC packer requires rights to the entire sub or it won't work.

@stewartadam I just walked through this again, as written, and it works fine. I am using subscription where I am the owner.
I know that giving subscription level access would work, it just isn't the "least privilege" option.
How are you creating the resource group? Are you trying to use an existing group that you might not have write access to?


chore: static analysis

Configure static analysis in project
Documentation
Static analysis configuration using golangci-lint and sonarcloud

Codecov Report

Merging #70 (ef011d1) into master (be53a9b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #70   +/-   ##
=======================================
  Coverage   10.31%   10.31%
=======================================
  Files          15       15
  Lines         960      960
=======================================
  Hits           99       99
  Misses        848      848
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be53a9b...ef011d1. Read the comment docs.


FAQ review with CP Team

Describe the issue
We want to have a session with the team to give everyone an idea of the types of questions we receive from ministries, and the answers that are being provided to them.
Which Sprint Priority is this issue related to?
The 'Milestone' should clearly list Sprint Priorities - which one is this issue related to?
Additional context
Add any other context, attachments or screenshots
Definition of done

Link to FAQs on team wiki
Presentation given to team by Emily and Sid

Sid working on:

How many questions came in and from which ministries?
Cross-reference the FAQ doc to the questions from the inbox to see if anything's missing
Look at the deck and add content

Sent invite for FAQ review with team on March 17.

Presentation given. Feedback from team captured.


Deflake TokenInvalidator integration test suite

How to categorize this PR?

/area dev-productivity testing
/kind enhancement
What this PR does / why we need it:
Earlier, the token-invalidator controller might have requeued too often which causes some exponential backoff by the underlying rate limiter. Hence, when the Pod is deleted, the controller might still be in the backoff for too long until the timeout for the Consistently hits:
• [FAILED] [10.031 seconds]
TokenInvalidator tests
/Users/root/go/src/github.com/gardener/gardener/test/integration/resourcemanager/tokeninvalidator/tokeninvalidator_test.go:33
  [It] should wait with invalidation until the pods using the static token are deleted
  /Users/root/go/src/github.com/gardener/gardener/test/integration/resourcemanager/tokeninvalidator/tokeninvalidator_test.go:139

  Begin Captured GinkgoWriter Output >>
    STEP: Create Pod 09/20/22 14:06:43.353
    STEP: Create Secret and ServiceAccount with AutomountServiceAccountToken=false 09/20/22 14:06:43.358
    STEP: Ensure token is not getting invalidated yet 09/20/22 14:06:43.364
    {"level":"debug","ts":"2022-09-20T14:06:43.367+0200","logger":"controller-runtime.webhook.webhooks","msg":"received request","webhook":"/webhooks/invalidate-service-account-token-secret","UID":"277aba60-6a8f-45f8-8515-176c12d82df3","kind":"/v1, Kind=Secret","resource":{"group":"","version":"v1","resource":"secrets"}}
    {"level":"debug","ts":"2022-09-20T14:06:43.367+0200","logger":"controller-runtime.webhook.webhooks","msg":"wrote response","webhook":"/webhooks/invalidate-service-account-token-secret","code":200,"reason":"","UID":"277aba60-6a8f-45f8-8515-176c12d82df3","allowed":true}
    {"level":"info","ts":"2022-09-20T14:06:43.372+0200","msg":"Requeueing since there is still at least one pod mounting secret","controller":"token-invalidator","object":{"name":"test-5b79f3ab","namespace":"tokeninvalidator-controller-test-95b0c6c4"},"namespace":"tokeninvalidator-controller-test-95b0c6c4","name":"test-5b79f3ab","reconcileID":"5ce32a6d-d027-41ba-865a-6d5ad465a35b","pod":{"namespace":"tokeninvalidator-controller-test-95b0c6c4","name":"foo"}}
    {"level":"info","ts":"2022-09-20T14:06:43.374+0200","msg":"Requeueing since there is still at least one pod mounting secret","controller":"token-invalidator","object":{"name":"test-5b79f3ab","namespace":"tokeninvalidator-controller-test-95b0c6c4"},"namespace":"tokeninvalidator-controller-test-95b0c6c4","name":"test-5b79f3ab","reconcileID":"c891be31-3133-4ad0-98d3-416419c79b7b","pod":{"namespace":"tokeninvalidator-controller-test-95b0c6c4","name":"foo"}}
    {"level":"info","ts":"2022-09-20T14:06:43.380+0200","msg":"Requeueing since there is still at least one pod mounting secret","controller":"token-invalidator","object":{"name":"test-5b79f3ab","namespace":"tokeninvalidator-controller-test-95b0c6c4"},"namespace":"tokeninvalidator-controller-test-95b0c6c4","name":"test-5b79f3ab","reconcileID":"b8f9db96-5ab1-4289-b507-5feabf5e3e9d","pod":{"namespace":"tokeninvalidator-controller-test-95b0c6c4","name":"foo"}}
    {"level":"info","ts":"2022-09-20T14:06:43.403+0200","msg":"Requeueing since there is still at least one pod mounting secret","controller":"token-invalidator","object":{"name":"test-5b79f3ab","namespace":"tokeninvalidator-controller-test-95b0c6c4"},"namespace":"tokeninvalidator-controller-test-95b0c6c4","name":"test-5b79f3ab","reconcileID":"d4cea27e-4111-4ce9-807d-51cd1b38fb1e","pod":{"namespace":"tokeninvalidator-controller-test-95b0c6c4","name":"foo"}}
    {"level":"info","ts":"2022-09-20T14:06:43.446+0200","msg":"Requeueing since there is still at least one pod mounting secret","controller":"token-invalidator","object":{"name":"test-5b79f3ab","namespace":"tokeninvalidator-controller-test-95b0c6c4"},"namespace":"tokeninvalidator-controller-test-95b0c6c4","name":"test-5b79f3ab","reconcileID":"38a6beff-1831-47cd-be1b-093ba9495815","pod":{"namespace":"tokeninvalidator-controller-test-95b0c6c4","name":"foo"}}
    {"level":"info","ts":"2022-09-20T14:06:43.530+0200","msg":"Requeueing since there is still at least one pod mounting secret","controller":"token-invalidator","object":{"name":"test-5b79f3ab","namespace":"tokeninvalidator-controller-test-95b0c6c4"},"namespace":"tokeninvalidator-controller-test-95b0c6c4","name":"test-5b79f3ab","reconcileID":"6608e248-731f-49b7-9002-1fd7644dfe6a","pod":{"namespace":"tokeninvalidator-controller-test-95b0c6c4","name":"foo"}}
    {"level":"info","ts":"2022-09-20T14:06:43.693+0200","msg":"Requeueing since there is still at least one pod mounting secret","controller":"token-invalidator","object":{"name":"test-5b79f3ab","namespace":"tokeninvalidator-controller-test-95b0c6c4"},"namespace":"tokeninvalidator-controller-test-95b0c6c4","name":"test-5b79f3ab","reconcileID":"72998933-e237-4cd2-9807-283fefe4beb0","pod":{"namespace":"tokeninvalidator-controller-test-95b0c6c4","name":"foo"}}
    {"level":"info","ts":"2022-09-20T14:06:44.016+0200","msg":"Requeueing since there is still at least one pod mounting secret","controller":"token-invalidator","object":{"name":"test-5b79f3ab","namespace":"tokeninvalidator-controller-test-95b0c6c4"},"namespace":"tokeninvalidator-controller-test-95b0c6c4","name":"test-5b79f3ab","reconcileID":"bfc543cd-b5dc-48ef-a2d8-6245b375ca11","pod":{"namespace":"tokeninvalidator-controller-test-95b0c6c4","name":"foo"}}
    {"level":"info","ts":"2022-09-20T14:06:44.661+0200","msg":"Requeueing since there is still at least one pod mounting secret","controller":"token-invalidator","object":{"name":"test-5b79f3ab","namespace":"tokeninvalidator-controller-test-95b0c6c4"},"namespace":"tokeninvalidator-controller-test-95b0c6c4","name":"test-5b79f3ab","reconcileID":"46dbbdb0-2f38-4076-9f53-9296d733afac","pod":{"namespace":"tokeninvalidator-controller-test-95b0c6c4","name":"foo"}}
    {"level":"info","ts":"2022-09-20T14:06:45.949+0200","msg":"Requeueing since there is still at least one pod mounting secret","controller":"token-invalidator","object":{"name":"test-5b79f3ab","namespace":"tokeninvalidator-controller-test-95b0c6c4"},"namespace":"tokeninvalidator-controller-test-95b0c6c4","name":"test-5b79f3ab","reconcileID":"dc979f55-32af-4519-8a01-2d237c2e7f16","pod":{"namespace":"tokeninvalidator-controller-test-95b0c6c4","name":"foo"}}
    STEP: Delete Pod 09/20/22 14:06:48.365
    STEP: Ensure token is now getting invalidated 09/20/22 14:06:48.372
    {"level":"info","ts":"2022-09-20T14:06:48.512+0200","msg":"Requeueing since there is still at least one pod mounting secret","controller":"token-invalidator","object":{"name":"test-5b79f3ab","namespace":"tokeninvalidator-controller-test-95b0c6c4"},"namespace":"tokeninvalidator-controller-test-95b0c6c4","name":"test-5b79f3ab","reconcileID":"719c1522-963b-4db6-bbd2-c884f5aea9a7","pod":{"namespace":"tokeninvalidator-controller-test-95b0c6c4","name":"foo"}}
  << End Captured GinkgoWriter Output

  Timed out after 5.001s.
  Expected
      <bool>: false
  to be true
  In [It] at: /Users/root/go/src/github.com/gardener/gardener/test/integration/resourcemanager/tokeninvalidator/tokeninvalidator_test.go:177

Hence, let's follow the approach from https://github.com/gardener/gardener/blob/master/docs/development/testing.md#writing-integration-tests here:

use a custom rate limiter for controllers in integration tests: example test
this can be used for limiting exponential backoff to shorten wait times
otherwise, if using the default rate limiter, exponential backoff might exceed the timeout of Eventually calls and cause flakes

Which issue(s) this PR fixes:
Fixes #6710
Release note:

NONE

/milestone v1.56

/test pull-gardener-e2e-kind


[BUG] Memory increasing when using FFI functions in rust

When calling an external function (rust -> c#), memory increases with seemingly no end. I'll take a closer look at it asap.

This has been fixed with a rework in how rust interfaces with c# (I was very naive about FFI, and learned a lot). It should be usable and should work well, but performance is not quite where it should be.

Fixed, just forgot to close it. Am looking at ways to improve performance but I've been quite busy with work outside of the project. Any PR's welcome!


[OpaqueValues] Add frontend flag to disable.

To facilitate bringup and in preparation for enabling by default.

@swift-ci please test


Added favicon icon.

#hacktoberfest
Here you go. Made a transparent PNG from the best quality version I could find, then a Favicon.

For issue #43

Replace icon file with original, sorry actually its logo not icon

I don’t understand what you are saying.

I don’t understand what you are saying.

I mean the file "icon.png' should be same as before, we have to just change faviocn file which you did already

The png I provided has a transparent background and is cleaned up a little. I mean you could hand that to an designer and they should be able to recreate it. That’s why I put 2 files in the commit. Just letting you know.


C/C++ options only appear for main project

The C/C++ node does not appear under Configuration Properties for additional projects. It only appears in the Configuration Properties of the main project of a solution.
What if an additional project needs to specify Additional Include Directories or Additional #using Directories?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d320011e-7558-c4fc-04d8-31cbc2fda834
Version Independent ID: 7b598fab-e8c1-d3a0-0fbf-730a7b2511a5
Content: Set C++ compiler and build properties in Visual Studio
Content Source: docs/build/working-with-project-properties.md
Product: visual-cpp
Technology: cpp-tools
GitHub Login: @corob-msft
Microsoft Alias: corob

@hwynn
Every Visual Studio-native C++ project should have a C/C++ node in its Property Pages dialog. Here's how to check if you have a native C++ project:
Select the project in Solution Explorer. You should see a summary of some of its properties in the Properties window, which is directly below the Solution Explorer window in the default VS layout. One of the listed properties should be Project File. Put the cursor in the file name and scroll to the end. A native C/C++ project will have an extension of .vcxproj. If your additional project doesn't have this extension, it's not a native C/C++ project, and the properties listed in the Project Properties dialog will be different. What you'll see depends on the actual project type.
Other project types can include CMake projects, Linux cross-platform projects, or even Android or iOS projects. These aren't considered native C++ projects, even if they build C++ code. They have their own set of Property Pages, and the ones in this documentation for native C++ projects don't apply.
If your project is supposed to be a native C++ project, but it doesn't have a .vcxproj file, you may need to recreate your project as a C++ project.
If your additional project is a .vcxproj file, and if when you right-click on it in Solution Explorer then choose Properties, you get a Property Pages dialog that doesn't include the usual C++ nodes in the Configuration Properties tree, then it's possible but unlikely that your project or solution files have a problem. That's a little outside my expertise, so I'd refer you to Visual Studio's C++ Developer Community to follow up.
For now, I'm calling this a product support issue rather than a documentation issue. If you get back to me with information that's in need of updating on this page, I'll be happy to reopen this issue and do that.

I figured it out. The C/C++ does not appear unless the project has a cpp file in it. Mine had the files in it, but they were not included in the project because I copy/pasted the files into a folder. The files had a little red circle with a dash through them, but I wasn't sure what that meant.

Good to know. I had guessed you'd created the project by the "Open a folder" method, and wasn't aware of the behavior of a project with no .cpp files in it.


Frontend Error When Using rx.accordion. Bug in get_uuid_string_var().

Describe the bug
I have a page on my reflex site that throws a frontend error when I try to use an accordion. I'm using the example code from the docs for the accordion:
rx.accordion.root(
    rx.accordion.item(
        header="First Item",
        content="The first accordion item's content",
    ),
    rx.accordion.item(
        header="Second Item",
        content="The second accordion item's content",
    ),
    rx.accordion.item(
        header="Third item",
        content="The third accordion item's content",
    ),
    width="300px",
)

Here is the error that I get in the terminal:
[Reflex Frontend Exception]
updateWorkInProgressHook@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:16507:13
updateMemo@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:17231:14
useMemo@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:17886:16
useMemo@webpack-internal:///./node_modules/react/cjs/react.development.js:1651:21
Fragment_b6d021fb79c14246d514a7734d93f9a4@webpack-internal:///./pages/max-diff.js:986:90
renderWithHooks@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:16305:27
updateFunctionComponent@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:19583:20
beginWork@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:21596:16
callCallback@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:4164:14
invokeGuardedCallbackDev@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:4213:16
invokeGuardedCallback@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:4277:31
beginWork$1@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:27446:28
performUnitOfWork@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:26552:12
workLoopSync@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:26461:22
renderRootSync@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:26429:7
recoverFromConcurrentError@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:25845:34
performConcurrentWorkOnRoot@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:25745:22
workLoop@webpack-internal:///./node_modules/scheduler/cjs/scheduler.development.js:266:42
flushWork@webpack-internal:///./node_modules/scheduler/cjs/scheduler.development.js:239:14
performWorkUntilDeadline@webpack-internal:///./node_modules/scheduler/cjs/scheduler.development.js:533:21
Here is the error I get in the browser:
Unhandled Runtime Error
Error: Rendered more hooks than during the previous render.
Source
pages/max-diff.js (651:813) @ generateUUID
649 |
650 | <RadixAccordionRoot css={{"borderRadius": "var(--radius-4)", "boxShadow": "0 2px 10px var(--black-a1)", "&[data-variant='classic']": {"backgroundColor": "var(--accent-9)", "boxShadow": "0 2px 10px var(--black-a4)"}, "&[data-variant='soft']": {"backgroundColor": "var(--accent-3)"}, "&[data-variant='outline']": {"border": "1px solid var(--accent-6)", "--divider-px": "1px"}, "&[data-variant='surface']": {"border": "1px solid var(--accent-6)", "backgroundColor": "var(--accent-surface)", "--divider-px": "1px"}, "&[data-variant='ghost']": {"backgroundColor": "none", "boxShadow": "None"}, "--animation-duration": "250ms", "--animation-easing": cubic-bezier(0.87, 0, 0.13, 1), "width": "300px"}} data-variant={classic}>

651 | <RadixAccordionItem className={AccordionItem} css={{"overflow": "hidden", "width": "100%", "marginTop": "1px", "borderTop": "var(--divider-px) solid var(--gray-a6)", "&:first-child": {"marginTop": 0, "borderTop": 0, "borderTopLeftRadius": "var(--radius-4)", "borderTopRightRadius": "var(--radius-4)"}, "&:last-child": {"borderBottomLeftRadius": "var(--radius-4)", "borderBottomRightRadius": "var(--radius-4)"}, "&:focus-within": {"position": "relative", "zIndex": 1}, "&:first-child[data-variant='ghost'], *:where([data-variant='ghost']) &:first-child": {"borderRadius": 0, "borderTop": "var(--divider-px) solid var(--gray-a6)"}, "&:last-child[data-variant='ghost'], *:where([data-variant='ghost']) &:last-child": {"borderRadius": 0, "borderBottom": "var(--divider-px) solid var(--gray-a6)"}}} value={useMemo(generateUUID, [])}>
|                                                                                ^
652 | <RadixAccordionHeader className={AccordionHeader} css={{"display": "flex"}}>
653 | <RadixAccordionTrigger className={AccordionTrigger} css={{"color": "var(--accent-11)", "fontSize": "1.1em", "lineHeight": 1, "justifyContent": "space-between", "alignItems": "center", "flex": 1, "display": "flex", "padding": "var(--space-3) var(--space-4)", "width": "100%", "boxShadow": "0 var(--divider-px) 0 var(--gray-a6)", "&[data-state='open'] > .AccordionChevron": {"transform": "rotate(180deg)"}, "&:hover": {"backgroundColor": "var(--accent-4)"}, "& > .AccordionChevron": {"transition": "transform var(--animation-duration) var(--animation-easing)"}, "&[data-variant='classic'], *:where([data-variant='classic']) &": {"color": "var(--accent-contrast)", "&:hover": {"backgroundColor": "var(--accent-10)"}, "& > .AccordionChevron": {"color": "var(--accent-contrast)"}}}}>
654 | {First Item}

To Reproduce
Unfortunately my website is large and I've not yet been able to reproduce with a minified version yet. I will keep trying though.
Expected behavior
The accordion should be displayed on the site without error.
Specifics (please complete the following information):

Python Version: 3.12.3
Reflex Version: 0.5.9
OS: Ubuntu 24.04

Additional context
Add any other context about the problem here.
The Chakra accordion works so I'm using that for now.

I am also not able to reproduce this in a testing environment, do you have any other insights?

It took me a while but I was able to make a minified version of my code that demonstrates this bug.
import reflex as rx
from typing import List, Dict, Callable
import traceback
import functools

class State(rx.State):

    @rx.var
    def is_token_valid(self) -> bool:
        return True

class MaxDiffState(State):

    uploading_data: bool = False
    uploaded_data: bool = False
    _upload_data_data: bytes = None
    data_csv_file_name: str = ""

    @rx.var(cache=True)
    def title(self) -> str:
        if self.is_token_valid:
            return f"MaxDiff"
        return ""

    @rx.var(cache=True)
    def description(self) -> str:
        if self.is_token_valid:
            return f"This is a tool."
        return ""

    async def handle_data_upload(self, files: List[rx.UploadFile]):
        try:
            self.uploaded = False
            self.uploading = True
            yield

            self.uploaded_data = True
            self.uploading_segment = False

        except Exception as e:
            self.uploading_data = False
            self.uploaded_data = False
            self.data_csv_file_name = ""
            print(traceback.format_exc())
            print("An error occurred:", e)
            yield rx.window_alert("An error occurred. \n\n" + str(e))

def template(page: Callable[[], rx.Component]) -> rx.Component:
    return rx.box(
        rx.vstack(
            rx.center(
                rx.vstack(
                    page(),
                ),
                width="100%",
            ),
        ),
    )

def require_ms_login():
    def decorator(page):
        @functools.wraps(page)
        def _auth_wrapper() -> rx.Component:
            def wrapped_page():
                return rx.cond(
                    State.is_hydrated,
                    rx.cond(
                        State.is_token_valid,
                        page(),
                        rx.text("Please login to access this page.")
                    ),
                    rx.spinner(),
                )
            return template(wrapped_page)
        return _auth_wrapper
    return decorator

def step_or_section_header(header, subtitle) -> rx.Component:
    return rx.chakra.box(
        rx.chakra.vstack(
            rx.chakra.heading(
                header,
            ),
            rx.chakra.text(
                subtitle,
            ),
        ),
    )

def upload(
    text,               # Text to display when no file is selected
    accepted: Dict[str, List[str]],           # Accepted file types
    uploading,          # State for uploading
    handle_upload,      # Function to handle upload
    upload_filename,    # Name of the uploaded file
    alignment,          # Alignment for the button
    id,                 # ID for the upload component
    # progress,           # Progress of the upload
) -> rx.Component:
    return rx.chakra.vstack(
        rx.upload(
            rx.vstack(
                rx.text(
                    text,
                    # "Drag and drop files here or click to select files",
                    # height="100px",
                    # width="200px",
                ),
                rx.cond(
                    rx.selected_files(id),
                    rx.foreach(
                        rx.selected_files(id),
                        rx.text,
                    ),
                    rx.text("No files selected"),
                ),
                align="center",
            ),
            id=id,
            accept=accepted,
            multiple=False,
            width="100%",
        ),
        tool_run_button(
            "Upload File",
            rx.selected_files(id),
            uploading,
            handle_upload,
            alignment,
        ),
        # rx.progress(value=progress),
        rx.chakra.box(
            rx.chakra.span(
                "Uploaded File:",
            ),
            rx.chakra.span(
                upload_filename,
            ),
            width="100%",
        ),
        width="100%",
    )

def tool_run_button(
    text,           # Text to display on the button
    condition_one,  # Condition to check if the button is enabled
    condition_two,  # Condition to check if the button is loading
    click,          # Function to call when the button is clicked
    alignment       # Alignment of the button
    ) -> rx.Component:
    return rx.chakra.box(
        rx.cond(
        condition_one,
            rx.cond(
                condition_two,
                rx.chakra.button(
                    rx.chakra.text(
                        text,
                    ),
                    is_loading=True,
                ),
                rx.chakra.button(
                    rx.chakra.text(
                        text,
                    ),
                    on_click=click,
                ),
            ),
            rx.chakra.button(
                rx.chakra.text(
                    text,
                ),
                is_disabled=True,
            ),
        ),
        display="flex",
        justify_content=alignment,
        width="100%",
    )

def upload_data() -> rx.Component:
    return rx.box(
        rx.vstack(
            step_or_section_header(
                "1. Upload Data CSV",
                "Upload a CSV file containing your maxdiff data.",
            ),
            upload(
                "Upload a CSV file containing your maxdiff data.",
                {"text/csv": ["csv"]},
                MaxDiffState.uploading_data,
                MaxDiffState.handle_data_upload(
                    rx.upload_files(
                        upload_id="max_diff_data_upload",
                    ),
                ),
                MaxDiffState.data_csv_file_name,
                "left",
                "max_diff_data_upload",
            ),
        ),
    )

@rx.page(
    route="/maxdiff",
    title="MaxDiff"
)
@require_ms_login()
def max_diff() -> rx.Component:

    # # This doesn't throw any errors
    # return rx.chakra.accordion(
    #     rx.chakra.accordion_item(
    #         rx.chakra.accordion_button(
    #             rx.chakra.heading("Example"),
    #             rx.chakra.accordion_icon(),
    #         ),
    #         rx.chakra.accordion_panel(
    #             rx.chakra.text(
    #                 "This is an example of an accordion component."
    #             )
    #         ),
    #     ),
    #     allow_toggle=True,
    #     width="100%",
    # )

    # # This doesn't throw any errors
    # return rx.accordion.root(
    #     rx.accordion.item(
    #         header="First Item",
    #         content="The first accordion item's content",
    #     ),
    #     width="300px",
    # )

    # # This doesn't throw any errors
    # return rx.vstack(
    #     rx.accordion.root(
    #         rx.accordion.item(
    #             header="First Item",
    #             content="The first accordion item's content",
    #         ),
    #         width="300px",
    #     ),
    # )

    # # This doesn't throw any errors
    # return rx.vstack(
    #     rx.chakra.accordion(
    #         rx.chakra.accordion_item(
    #             rx.chakra.accordion_button(
    #                 rx.chakra.heading("Example"),
    #                 rx.chakra.accordion_icon(),
    #             ),
    #             rx.chakra.accordion_panel(
    #                 rx.chakra.text(
    #                     "This is an example of an accordion component."
    #                 )
    #             ),
    #         ),
    #         allow_toggle=True,
    #         width="100%",
    #     ),
    #     upload_data(),
    # )

    # # This doesn't throw any errors
    # return rx.vstack(
    #     upload_data(),
    # )

    # This throws a frontend error in terminal and in chrome.
    return rx.vstack(
        rx.accordion.root(
            rx.accordion.item(
                header="First Item",
                content="The first accordion item's content",
            ),
            width="300px",
        ),
        upload_data(),
    )

app = rx.App()

Note: Don't forget to import 'max_diff' in the init.py file.

thanks for the testing scenario! I was able to find the issue, it is related to how default value is being calculated when value prop is missing from rx.accordion.item. I provided a dummy value and the page rendered correctly:
get_uuid_string_var() is causing the issue. Currently I don't know how to fix this UUID generator, but providing a value to accordion item would fix it.
Let me know if it works correctly for you.

Snippet:
return rx.vstack(
        rx.accordion.root(
            rx.accordion.item(
                header="First Item",
                content="The first accordion item's content",
                value="1"
            ),
            width="300px",
        ),
        upload_data(),
    )

Thank you so much for looking into this! I can confirm that adding value="1" to the rx.accordion.item is a good temporary solution for this issue for now. Long term, I think we need to find and fix the root cause of this bug in get_uuid_string_var().

Happy to help :)
I think I have found the root cause and it is in the implementation of useMemo in Reflex. As per the React docs useMemo should only be called at the top level of the component but when I saw the generated React code by Reflex this function get_uuid_string_val() is being called inline and it uses useMemo.
I do not know React much but I will try to fix this bug.

the issue was introduced via this commit https://github.com/reflex-dev/reflex/pull/3708
it works in simple cases, but if the accordion is conditionally rendered in some way, then the number of hook calls is not constant and thus the bug appears.
a potential solution is to move the get_uuid_string_val() call out to a separate hook and then reference that const in the value prop.
haven't tested it but in theory:
index ffaf1645..6cb81b12 100644
--- a/reflex/vars.py
+++ b/reflex/vars.py
@@ -2588,15 +2588,19 @@ def get_uuid_string_var() -> Var:
     """
     from reflex.utils.imports import ImportVar

+    unique_variable_name = get_unique_variable_name()
     unique_uuid_var_data = VarData(
         imports={
             f"/{constants.Dirs.STATE_PATH}": {ImportVar(tag="generateUUID")},  # type: ignore
             "react": "useMemo",
-        }
+        },
+        hooks={
+            f"const {unique_variable_name} = useMemo(generateUUID, [])": None
+        },
     )

     return BaseVar(
-        _var_name="useMemo(generateUUID, [])",
+        _var_name=unique_variable_name,
         _var_type=str,
         _var_data=unique_uuid_var_data,
     )

This at least moves the call to useMemo out of the render path so it cannot be called a mismatching number of times.

@masenf thank you for the solution. I have tested it out and it works.


[Improvement] Unit tests support mocking the ShuffleServerNettyHandler class

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I have searched in the issues and found no similar issues.

What would you like to be improved?
Unit tests support mocking the ShuffleServerNettyHandler class in order to better cover the business code for the netty part.
We can search for TODO skip validating for GRPC_NETTY, needs to mock ShuffleServerNettyHandler in our codes.
How should we improve?
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

This is really important in Netty mode. Anyone is welcome to pick this up.

This is really important in Netty mode. Anyone is welcome to pick this up.

When running in prod, we currently use Netty mode due to https://github.com/apache/incubator-uniffle/issues/1651, so this issue is very important. Because we lack the ability to test Netty business codes using UTs. If you are interested, I can assign this issue to you. That will be of great help.
@maobaolong

@rickyma Will take a look at this issue, thank you!


Issues installing Jira plugin on Jira Server 9.1

Reported here https://community.mattermost.com/core/pl/pw4gs7imhidaugn4rrjbcgueno

Are there any known issues with the Jira plugin concerning Jira Server/Datacenter 9.1? It seems that the application link configuration in Jira 9 has nothing to do with the installation instructions displayed in Mattermost. I upgraded our Jira env last weekend because of some security issues & just found out today that I couldn't create any issues from a message anymore (Error 404). So I uninstalled the instance & retried with a new installation. The instructions describe something different from what I see in Jira:

First screen:

Credentials:
This is a OAuth 2.0 authentication on the Jira side.

When I try the fallback solution from Jira (Create a link to an Atlassian product not an external application) you can configure an OAuth 1.0 connections, but still the needed information from Mattermost is not available:

Apart from the authentication issue, the REST endpoint rest/api/2/issue/createmeta has been removed in Jira 9, which, if use, makes creating Jira issues using REST not working anymore.
Please check:
https://confluence.atlassian.com/jiracore/createmeta-rest-endpoint-to-be-removed-975040986.html

@mickmister @catalintomai Shall I create a new issue for the removal of the REST createmeta endpoint?

@jprusch, yes, please do. Thanks!

Done #865

@catalintomai Is there a timeframe for this issue? Right now Mattermost is not compatible with Jira 9 (Datacenter/Server) with the aspect of creating issues or commenting. Given that Atlassian security issues might lead to an increased upgrade rate to Jira 9, this might become more imminent. Many companies use Mattermost on premise because of security concerns, same is true for hosting Jira on-prem.

Any update?

This issue is clearly documentation related & has now been solved with some help from Mattermost.

Make sure you created an ATLASSIAN application link
Ignore errors on the URL
On the "Link application" dialog, just enter the name (Mattermost) and select "Create incoming link". Leave all other fields empty
On the next page enter the data (public key...)

For more context you might want to read
https://community.mattermost.com/core/pl/pw4gs7imhidaugn4rrjbcgueno
in the Mattermost community

This issue is clearly documentation related & has now been solved with some help from Mattermost.

Closing as completed


Error executing batch_writer

The Lambda function worked great for the first two imports, now when I'm attempting to import a csv with 70 items it's throwing this error.
Here are the log entries:
2022-06-23T21:05:40.424-05:00CopySTART RequestId: aa9ba096-2802-44e5-b66d-2ec2b83bf54f Version: $LATEST | START RequestId: aa9ba096-2802-44e5-b66d-2ec2b83bf54f Version: $LATEST
2022-06-23T21:05:40.521-05:00CopyError executing batch_writer | Error executing batch_writer
2022-06-23T21:05:40.523-05:00CopyEND RequestId: aa9ba096-2802-44e5-b66d-2ec2b83bf54f | END RequestId: aa9ba096-2802-44e5-b66d-2ec2b83bf54f
2022-06-23T21:05:40.523-05:00CopyREPORT RequestId: aa9ba096-2802-44e5-b66d-2ec2b83bf54f	Duration: 97.66 ms	Billed Duration: 98 ms	Memory Size: 3008 MB	Max Memory Used: 78 MB	Init Duration: 498.80 ms | REPORT RequestId: aa9ba096-2802-44e5-b66d-2ec2b83bf54f Duration: 97.66 ms Billed Duration: 98 ms Memory Size: 3008 MB Max Memory Used: 78 MB Init Duration: 498.80
This is the Lambda code I'm using:
`
import json
import boto3
import os
import csv
import codecs
import sys
s3 = boto3.resource('s3')
dynamodb = boto3.resource('dynamodb')
bucket = os.environ['bucket']
key = os.environ['key']
tableName = os.environ['table']
def lambda_handler(event, context):
#get() does not store in memory
try:
obj = s3.Object(bucket, key).get()['Body']
except:
print("S3 Object could not be opened. Check environment variable. ")
try:
table = dynamodb.Table(tableName)
except:
print("Error loading DynamoDB table. Check if table was created correctly and environment variable.")
batch_size = 100
batch = []
#DictReader is a generator; not stored in memory
for row in csv.DictReader(codecs.getreader('utf-8')(obj)):
if len(batch) >= batch_size:
write_to_dynamo(batch)
batch.clear()
  batch.append(row)

if batch:
write_to_dynamo(batch)
return {
'statusCode': 200,
'body': json.dumps('Uploaded to DynamoDB Table')
}
def write_to_dynamo(rows):
try:
table = dynamodb.Table(tableName)
except:
print("Error loading DynamoDB table. Check if table was created correctly and environment variable.")
try:
with table.batch_writer() as batch:
for i in range(len(rows)):
batch.put_item(
Item=rows[i]
)
except:
print("Error executing batch_writer")`
Here is the file we are attempting to upload:
Upload.csv

same issue here lambda is successful with the return of Error executing batch_writer

I can't believe that in six days, nobody has responded to this.

Thanks for your feedback. We updated the code to provide more descriptive errors. Additionally, we fixed a utf-8 codec issue which was causing issues with column name. We have also tested using your csv example above and see that it is now working.


radio and checkbox inputs: wrong error container placement

Parsley  v2.2.0-rc1
For all the inputs in case of error the input gets .parsley-error class and .parsley-errors-list list container is appended right after the input. This is a normal, expected behaviour.
For radios and checkboxes the closest parent gets .parsley-error class and .parsley-errors-list is appended right after the closes parent.
Example: http://jsfiddle.net/58vnaqur/7/
PS
I'm not sure is it a bug or a feature. But if it's a feature it can generate invalid markup if we're using a list to create a form markup (which is a common practice). Take a look: http://jsfiddle.net/58vnaqur/6/
In case of error <ul class="parsley-errors-list"> element is appended directly inside <ul> which is not a valid markup. I know I can wrap checkbox/radio input in additional tag (let's say span), but it's just a workaround.

Yeah, it's a "feature", not a great one though. Suggestions welcome. In the meantime, you probably want to play with classHandler to get something that works for you


Facebook login issue

Hi! youtube-dl won't log in to Facebook to get a private video. I have checked four times that the username and password are correct, but I still get this error.
youtube-dl -v --username<EMAIL_ADDRESS>--password 'password' 'https://www.facebook.com/user/videos/123456789987654321/'
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'--username', u'PRIVATE', u'--password', u'PRIVATE', u'https://www.facebook.com/user/videos/123456789987654321/']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2015.10.24
[debug] Python version 2.7.2 - Darwin-12.6.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 2.5, ffprobe 2.5
[debug] Proxy map: {}
[facebook] Downloading login page
[facebook] Logging in
WARNING: unable to log in: bad username/password, or exceded login rate limit (~3/min). Check credentials or wait.
[facebook]<PHONE_NUMBER>87654321: Downloading webpage
ERROR: The video is not available, Facebook said: "The link you followed may have expired, or the page may only be visible to an audience you're not in."
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 661, in extract_info
    ie_result = ie.extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 291, in extract
    return self._real_extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/facebook.py", line 138, in _real_extract
    expected=True)
ExtractorError: The video is not available, Facebook said: "The link you followed may have expired, or the page may only be visible to an audience you're not in."

Facebook login is fixed. Could you check again?

Closing this ticket for no response for a long time. Feel free to open new issues if problems are still.


Propose a solution for the funding rate

I decided to write an ADR because I came to the conclusion that the original solution reflected in #1069 does not work.
Because none of the solutions discussed in the document are ideal, I want to use this PR as an opportunity to reach consensus before actually implementing a solution to #1069.

After investigating the differences between (1) adapting the margin and (2) adapting the payouts, I have concluded that the effect is equivalent. (1) is obviously much simpler so I think we can merge this ADR in its current state as discussed offline.


style: move unknown flag desc. to misc constant.

This simply moves this line into a new constant that can be easily changed and re-styled for information on an unknown flag.

looks good, thank you!


Feature/bsr basis only

Adds a keyword argument to build_sparse_matrix_from_LO that skips the evaluation of matrix elements and returns an empty sparse array.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

21 of 21 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 89.365%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
4252

Relevant Lines:
4758

💛  - Coveralls


Add support for redis search command FT.EXPLAINCLI

As documented at https://redis.io/commands/FT.EXPLAINCLI

@chayim Closing this issue, since this command is CLI specific