Offer a --fail-on-error flag

Is your feature request related to a problem? Please describe.
There is --fail-on-warning that fails for warnings or errors, but no --fail-on-error only to fail for errors (ignoring warnings)
Describe the solution you'd like
--fail-on-error only to fail for errors (ignoring warnings)
Describe alternatives you've considered
None
Additional context
To make a GitHub Action fail for errors only.

I'm a bit confused, failing on only errors should be the default behavior. --fail-on-warning should turn on failing for warnings, but failing on errors should always be true. Is that not the case? If not, then this is a bug.

I believe it's not failing on errors, we got:
ERROR parsing PUT /monitoring-profiles/{profile-name}/job within monitoring_profile_controller. Endpoint will not be generated.
Incorrect path templating for /monitoring-profiles/{profile-name}/job (Path parameters do not match with path)
ERROR parsing GET /monitoring-profiles/{profile-name} within monitoring_profile_controller. Endpoint will not be generated.
Incorrect path templating for /monitoring-profiles/{profile-name} (Path parameters do not match with path)
ERROR parsing GET /monitoring-profiles/{profile-name}/jobs within monitoring_profile_controller. Endpoint will not be generated.
Incorrect path templating for /monitoring-profiles/{profile-name}/jobs (Path parameters do not match with path)
WARNING parsing PUT /feature-groups/schedule/offline-to-online-etl/bigquery-firestore within feature_group_load_controller.
Cannot parse response for status code 200, response will be ommitted from generated client
Response(description='OK', headers=None, content={'*/*': MediaType(media_type_schema=Schema(title=None, multipleOf=None, maximum=None, exclusiveMaximum=None, minimum=None, exclusiveMinimum=None, maxLength=None, minLength=None, pattern=None, maxItems=None, minItems=None, uniqueItems=None, maxProperties=None, minProperties=None, required=None, enum=None, type=<DataType.ARRAY: 'array'>, allOf=None, oneOf=[], anyOf=[], schema_not=None, items=Reference(ref='#/components/schemas/FeatureGroupLoad'), properties=None, additionalProperties=None, description=None, schema_format=None, default=None, nullable=False, discriminator=None, readOnly=None, writeOnly=None, xml=None, externalDocs=None, example=None, deprecated=None), example=None, examples=None, encoding=None)}, links=None)
WARNING parsing GET /feature-groups/{featureGroup}/load within feature_group_load_controller.
Cannot parse response for status code 200, response will be ommitted from generated client
Response(description='OK', headers=None, content={'*/*': MediaType(media_type_schema=Reference(ref='#/components/schemas/FeatureGroupLoad'), example=None, examples=None, encoding=None)}, links=None)
WARNING parsing GET /service-account/notebook-role/status within service_account_status_controller.
Cannot parse response for status code 200, response will be ommitted from generated client
Response(description='OK', headers=None, content={'text/plain': MediaType(media_type_schema=Schema(title=None, multipleOf=None, maximum=None, exclusiveMaximum=None, minimum=None, exclusiveMinimum=None, maxLength=None, minLength=None, pattern=None, maxItems=None, minItems=None, uniqueItems=None, maxProperties=None, minProperties=None, required=None, enum=None, type=<DataType.STRING: 'string'>, allOf=None, oneOf=[], anyOf=[], schema_not=None, items=None, properties=None, additionalProperties=None, description=None, schema_format=None, default=None, nullable=False, discriminator=None, readOnly=None, writeOnly=None, xml=None, externalDocs=None, example=None, deprecated=None), example=None, examples=None, encoding=None)}, links=None)
WARNING parsing GET /service-account/api-client-role/status within service_account_status_controller.
Cannot parse response for status code 200, response will be ommitted from generated client
Response(description='OK', headers=None, content={'text/plain': MediaType(media_type_schema=Schema(title=None, multipleOf=None, maximum=None, exclusiveMaximum=None, minimum=None, exclusiveMinimum=None, maxLength=None, minLength=None, pattern=None, maxItems=None, minItems=None, uniqueItems=None, maxProperties=None, minProperties=None, required=None, enum=None, type=<DataType.STRING: 'string'>, allOf=None, oneOf=[], anyOf=[], schema_not=None, items=None, properties=None, additionalProperties=None, description=None, schema_format=None, default=None, nullable=False, discriminator=None, readOnly=None, writeOnly=None, xml=None, externalDocs=None, example=None, deprecated=None), example=None, examples=None, encoding=None)}, links=None)
Skipping Integration
autoflake is not in PATH
Skipping Integration
isort is not in PATH
Skipping Integration
black is not in PATH
If you believe this was a mistake or this tool is missing a feature you need, please open an issue at https://github.com/triaxtec/openapi-python-client/issues/new/choose

and it did not end as error

any ideas? @dbanty

I haven't forgotten about you, I've just been on vacation 🏖. I should be able to reproduce and fix it this weekend.

Thank you!

Well I found the issue 😓. Turns out that thing labeled "ERROR" is actually a warning... it can't generate the one endpoint but it can keep generating others so it actually just skips that. Clearly it used to be an error at some point and I never updated the text... confusing. I'm going to update the text for 0.10.5. I should probably have a clearer indication of the level of any given message in a future change.


[HOLD for payment 2023-03-20] Feature request (polish): Improve responsiveness of number pad as native keyboard

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Problem:
When typing on the numpad to input the request money amount, the keyboard is not as responsive as native keyboard.  The keyboard did not catch when the numbers are tapped too fast, but that would not be an issue on a native keyboard.
Solution:
Improving the responsiveness as much as possible to like native keyboard
Context/Examples/Screenshots/Notes:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: @mountiny
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1677753000825879
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01c0e668e5663ee524
Upwork Job ID:<PHONE_NUMBER>319972864
Last Price Increase: 2023-03-06

Hello, I'm Nicolay from Callstack and I'm interested in taking and analysing this issue to work on a fix for it.

Proposal
Please re-state the problem that we are trying to solve in this issue.
A general issue - unnecessary re-renders, and no memoization for the whole BigNumberPad component.
Why that happens? In BigNumberPad is a child component of IOUAmountPage - and when anything fires setState - we re-render all children. Also BigNumberPad has map of Views (our numbers 12 items) - and you can imagine that clicking on one button - force to re-render all this keyboard every time
What changes do you think we should make in order to solve the problem?

We need to use PureComponent instead of Component - which will automatically check if props are equal and not re-render the whole component
The most important we need to re-write this function
longPressHandlerStateChanged={state => this.shouldUpdateSelection = !state} - such implementation force to re-render BigNumberPad even if it extended from PureComponent - such implementation create a new function every time

To see the difference between this implementations i will provide some videos in which you can see how touch event listeners will be renders - in most cases for one button we get 15-20 ms faster work (each dot is a button which pressed) - also you will see that we reduce CPU and memory usages to render that flow. And this is Android - on IOS it will be even faster
Before:
https://user-images.githubusercontent.com/28352309/223165409-c1ecced3-47ff-473e-8e00-05016a830c96.mp4
After:
https://user-images.githubusercontent.com/28352309/223165443-a0be6f10-9af5-43a8-913a-d379646430f2.mp4
Before:
https://user-images.githubusercontent.com/28352309/223165706-f7980b72-5aff-442a-8e04-7837a260e5cb.mov
After:
https://user-images.githubusercontent.com/28352309/223165784-6ea1cb3f-aff5-4185-a8bc-349608c0f757.mov
What alternative solutions did you explore?

Great, that all makes sense to me, feel free to create a PR!

Job added to Upwork: https://www.upwork.com/jobs/~01c0e668e5663ee524

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mananjadhav (Internal)

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.82-4 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/15710

If no regressions arise, payment will be issued on 2023-03-20. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@narefyev91 @mountiny  this is due for payout but I couldn't apply to the Upwork job. Additionally, I don't think I am left with connects (Upwork credits) to apply Upwork job. Can you invite me to the job?

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Hello! Will get post going. @mountiny can you confirm payout amounts?

$1000 for @mananjadhav
That will be it, thanks!

@mountiny @dylanexpensify What about the regression reported here

@mananjadhav I wasnt sure since it was not strictly what we tested for, how does it convey to the price, would it be half? So $500?

Yeah I think it's fair to deduct here as this was a miss.

payment sent, contract ended, thanks all!

Thanks for the honesty Manan, appreciated.

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.88-2 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/16340

If no regressions arise, payment will be issued on 2023-03-31. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@mananjadhav / @mountiny] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@mananjadhav / @mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@mananjadhav / @mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@dylanexpensify] Determine if we should create a regression test for this bug.
[ ] [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:


Performance improvements to json serialization/de-serialization

Q
A

Bug fix?
no

New feature?
yes

New sample?
no

Related issues?
Performance improvements to json serialization/de-serialization

Performance improvements to json serialization/de-serialization

Hi @gautamdsheth, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, MSBOT;

Hi Gautam, there were actually reasons on using the native .NET serializations in the engine when this was originally implemented. We'll have a look if the impact is still there and come back.

Hi Gautam,
We've just merged this PR. AFAIK the original reasons where to not have an additional dependency but in the meanwhile newtonsoft is there, so no harm in switching over to use Newtonsoft. Apologies for the long time it took to process but beter late than not at all. Thanks!


Release rc.9

I update your package to latest version, but code has old imports
Do you recompile jsx?

@retyui I have installed rc.9 for my own project and everything works with material-ui rc.1

@retyui are you sure you updated to rc9?
Everything looks fine on our side:
<EMAIL_ADDRESS>


⚠ ClamAV has degraded performance

In df24f62, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 83 ms

Resolved: ClamAV performance has improved in b2bf110.


Idea: Use drizzle-orm and expose select() API on the client

drizzle-orm is a lightweight wrapper around better-sqlite that provides a typesafe interface, friendly API, and manages migrations / table creation SQL.
Using drizzle-orm internally might help us write type-safe code. We should be able to generate drizzle sql schema declarations from the JSONSchema in @mapeo/schema more easily than trying to write SQL CREATE TABLE statements ourselves. We don't need to expose drizzle to the client for this.
There could also be an advantage to exposing some of the drizzle API to the client, namely db.select(). This would provide a more powerful interface for the client for reading data, vs. the existing proposed datatype API. It would be an alternative for the getByDocId() and getMany() methods. We would not be able to expose the db.insert() method from drizzle, because writing data in Mapeo needs to do much more than just read SQL tables, and for getByVersionId(), we are not reading from SQL tables because those only contain the most recent version.
Whether it is worth doing the latter depends on whether this would provide a better interface for the front-end team? One clear advantage I can think of is being able to write more complex queries without needing to wait for the backend to add indexes and extra methods to support the query, and it avoids us needing to write our own query API.
To implement db.select() on the client we would not be able to use rpc-reflector, because it is a chained method which doesn't really work over RPC (because each step in the chain creates an object that needs to be garbage collected, but the server does not know when the client no longer references each step - see https://github.com/digidem/rpc-reflector/pull/7). However we could implement db.select() on the client using the drizzle custom proxy driver, which serializes the result of something like db.select().from(users).where(and(eq(users.id, 42), eq(users.name, 'Dan'))).all(); to an object that can be passed over RPC with a raw sql statement that can be executed on the server.

generally open to this idea! especially for the near future, the flexibility can be pretty powerful and can even inform what methods the client should expose if we decide to move away from it (i.e. go back to what's currently spec'd).
will also note that I'd like to be cautious about adding another dependency, especially one that dictates how this api gets shaped. more of a general concern and maybe not applicable in this case, but something to point out as I've personally been forming the opinion that deps are Evil™ 😄

Yes, agreed about the addition of more deps. I see this as a complimentary API, rather than a replacement for the current API idea. e.g. we would still have mapeo.observation.getByDocId(), but we have a top-level mapeo.select() for mode powerful queries. The two methods getByDocId() and getMany() would be duplicates of using select() (could switch to using select() internally if we want), but the other methods would not use anything Drizzly.

ah got it! then definitely open to exploring this 👍


exit function with 'return' instead of 'exit'

The given 'exit' will couse the ISE to quit and the user will not be able to see the message that traefik is already initialized.
Maybe we should also change the Write-Host into a Write-Warning. What do you think?

In general - I want to switch to Write-Warning and Write-Information - but that change has a chance of being disruptive.
I am going to setup the containerhelper with pre-release versions which is supported by the gallery so that we can do these things and ship new versions less frequently.
Right now, the main focus has been to make CI/CD pipelines work - test running still has a few hickups - as soon as that is done, my focus will be to catch up on tests and create a pre-release version setup.
Make sense?


Migration of ShinyApp-hosted data QC reports to MoTrPAC Data Hub portal

For the initial phase of this migration, the deliverables will be the following:

To mirror the ShinyApp UIs on the portal as much as feasible
To offer the ShinyApp functionality on the portal as much as feasible
Data source will be static JSON files (converted from generated .txt files) stored in a GCP bucket

Upon initial round of review, the following changes were made given the feedback from the team:

Move the “Phase” button to the far left as the default selected button
Move the ‘PASS1B’ tab to the far left as the default selected phase
Combine the ‘PASS1A/1C’ phases into a single tab, and stack the grid tables
Add color legends to indicate “samples submitted” and “no sample submitted” in the tab views
Add link to the “Help” view at the bottom of the omics QC report tables
Add “NOT AVAILABLE” term and definition to the “Help” view
Rename instance of “NOT_AVAILABLE” to “NOT AVAILABLE” in the tables

Upon the second round of review, the following changes were made given the feedback from David JM and Archana:

Use dark gray color to represent "No sample submitted" status
Swap x-axis and y-axis so that tissues are columns while ome/site/assay labels are for rows
Rename instances referencing "data QC reports" to "QC Data Monitor"

Since the QC report data source are currently static JSON files, I have opted to embed the JSON files in the app (for now) rather than making them publicly accessible through a GCP bucket.


Refactor chat stellar request integration

Use UIRequestInfo pattern, similar to UIPaymentInfo pattern.
cc @buoyad

circle ci expected to fail until this is merged and kbfs patched up to ignore the new notification.

will fix circle ci after merge


Reprovision jenkins-nix-ci as remote builder

Tasks

[x] @vsaimanohar Connect the machine to ethernet
[ ] @vsaimanohar Give the new IP address to Srid
[ ] @srid Add configuration in this repo and deploy
[ ] @srid Setup remote builder

@vsaimanohar Give the new IP address to Srid

Sai says <IP_ADDRESS>

@vsaimanohar Could you add this machine to the same tailscale network also?

This would enable a 2nd i9 machine to do CI builds on, which is going to fasten the CI builds overall.

@srid that ip is internal ip address of 'basantis-mac-studio' , i have tried
~ ipconfig getifaddr en0
empty

ipconfig getifaddr en1
<IP_ADDRESS>

so lets use <IP_ADDRESS> Ethernet ipaddress instead here which is required right?


Update readme

Update readme to include loading multiple files from glob

The only thing I can see is that the github runner version has changed slightly, but I don't see why that would make a difference.
It's failing to build because of an error in commit_info.h, I just can't see what could possible cause that to fail now.

Ok, fixed in #8


VS scraper fails

It seems the structure of the xlsx changed.

I'll disable VS until this is fixed.


extras/timekeeping -- provide POSIX-like interface

Provide POSIX-like timekeeping utilities using system clock
to support monotonic, accurate, timezone-aware time
Implements settimeofday(), gettimeofday(), and adjtime()
Utilizes setenv() and tzset()
See README.timekeeping.md for more details
Examples
Set Time of Day (UTC)
struct timeval tv;
tv->tv_sec =<PHONE_NUMBER>;  /* 2018-02-16T16:20:27+00:00 */
tv->tv_usec = 0;
settimeofday(&tv, NULL);

Get Time of Day (UTC)
struct timeval tv;
gettimeofday(&tv, NULL);

Slew Time
struct timeval tv;
tv->tv_sec = 0;
tv->tv_usec = -50 * 1000;  /* -50 ms */
adjtime(&tv, NULL);

Set Local Time Zone to US Pacific
setenv("TZ", "PST8PDT7,M3.1.0,M11.1.0", 1);
tzset();

Set Local Time Zone to UTC
setenv("TZ", "UTC0UTC0", 1);
tzset();

Highlights
This "extra" splits out the timekeeping functions from those associated with clock discipline. It attempts to address some of the challenges with the integrated clock/SNTP implementation in extras/sntp.
It uses the system clock which should have 15 ppm or better accuracy, significantly better than the ESP8266 RTC and likely better than off-board RTCs. My Adafruit Huzzah on my desk shows around 5-6 ppm drift against NTP broadcast on my local network.
Timekeeping functionality is available without needing SNTP synchronization. If you want to call the moment your program starts ticking as "0 seconds", you can do that.
Timezone functionality is provided through the POSIX-like TZ environment variable using the standard setenv() and tzset() calls. This allows for daylight/summer time to be implemented without further updates by applications, for most locations. The internal clock is always in UTC (or whatever reference chosen) so it does not change when the timezone offset changes. ctime(), localtime(), and their ilk work with the timezone without modification.
The implementation of adjtime() means that the clock discipline can implement monotonic time -- no more backwards jumps.
The timekeeping internals are locked when called through the standard calls, improving robustness in multi-threaded applications. The lock utilizes the same TZ_LOCK as newlib implements, which calls to xSemaphoreTake() so should benefit from task-priority escalation of a blocking task in a FreeRTOS-like manner.
There are no "special" header files required; <sys/time.h>, <stdlib.h>, and <time.h> are sufficient to define the API.
The supplied routines are expected to be consistent with their POSIX counterparts, including a -1 return value on error and setting the instance-specific errno within their "reentrant" implementations.
Even when slew is underway, there are "no" cycles consumed by the timekeeping routines until gettimeofday(), settimeofday(), or adjtime() is called; there are no timers involved with adjtime(). Calculations are done with integer arithmetic to further speed performance. I say "no" in quotes, as the hourly wrap of the system clock needs to be detected. Calling any of the three aforementioned functions will accomplish that, as will simply calling gettimeofday(NULL, NULL).
The routines have been manually tested to confirm utility and correctness. The tests that I used are present in the extras/timekeeping/tests/ directory. Let me know if you would like the tests removed.
Testing With LWIP SNTP app
I've tested these routines using the "new" LWIP SNTP app and the results for broadcast NTP are very good. I see a reasonably consistent ~0.5 ms / min drift against the NTP server, with only occasional deviations up to around 1 ms. As the implementation uses adjtime() to slew the clock, time remains monotonic even when the reference time is "behind" the clock time.
The implementation of LWIP SNTP runs all but the first poll in the tcpip_thread so it is already at high priority.
I can run the example for many hours with a heap size of 192, suggesting that 256 is a "safe" size.
I'm less than thrilled with the performance of the LWIP SNTP app in polling mode, even with RTT compensation in place. As the timekeeping routines work well with the broadcast/listener mode, I suspect the problem is in the LWIP code or networking code. What I am seeing are generally consistent results, with somewhat higher deviation, than with the broadcast mode. Disturbing, however, are larger deviations, that might be clustered around multiples of 5 ms. How much of that is my mind knowing that a "tick" is 10 ms and how much is reality is an open question.
I'd like to look further into the performance of the LWIP SNTP code, including an examination of the WiFi packets, before contributing examples/sntp-lwip or the like.

Please hold on merging this -- not because of the code, but the parameter in one of the SNTP  "tests" related to slew vs. step probably should be larger than its 128-ms value.
Last night my local, broadcast setup saw a single, 250-ms spike. Some late packet, for who knows what reason. That probably shouldn't trigger a step, especially a backwards one. At 500 us/s a single-sample spike would only cause a slew of 32 ms over the typical 64-s broadcast period. Especially for users that don't have local NTP, I think the current 128-ms threshold is too small.

OK, suggestions from @ourairquality incorporated, additional testing and observation over the last several days in various modes with both local and remote "pool" servers.
Good to go now, from my perspective.
The timekeeping routines are unchanged otherwise. I've increased heap on one of the tests to 288 as, at 256, it raised warnings/errors when I referenced an NTP server pool by DNS name. I've added warnings about the SNTP integration not being "production code" as the simplistic slew-or-set approach is not robust to outliers. That said, I haven't seen anything anywhere near as that 225-ms one on my local network. The step threshold is at 125 ms, consistent with the NTPv4 STEPT parameter.
If anyone wants some good bedtime reading, https://www.eecis.udel.edu/~mills/database/reports/ntp4/ntp4.pdf will quickly put you to sleep.
I'm not losing my mind, after all. It seems likely that there is some 10-ms "thing" going on in the lwIP SNTP implementation, resulting in 5-ms errors in the server-to-client delay. I don't see it in broadcast mode at all.
Poll mode, local server, RTT enabled, histogram of error relative to linear fit over 641 samples (over 11 hours). x-axis in milliseconds:

￼

https://api.travis-ci.org/v3/job/347111681/log.txt
[...]
CC /home/travis/build/SuperHouse/esp-open-rtos/extras/bearssl/BearSSL/src/int/i15_reduce.c
CC /home/travis/build/SuperHouse/esp-open-rtos/extras/bearssl/BearSSL/src/int/i15_rshift.c
CC /home/travis/build/SuperHouse/esp-open-rtos/extras/bearssl/BearSSL/src/int/i15_sub.c
CC /home/travis/build/SuperHouse/esp-open-rtos/extras/bearssl/BearSSL/src/int/i15_tmont.c

The job exceeded the maximum time limit for jobs, and has been terminated.


Fixed lenses.kafka: new vars

Included LENSES_KAFKA & LENSES_KAFKA_DEFAULT_METRICS_PORT in NEEDNOQUOTE variables

This change is

Closing this now as it should be against lenses-development/lkd-2.0/2.3. Also enforcing no quotes isn't needed for LENSES_KAFKA_DEFAULT_METRICS_PORT but for LENSES_KAFKA_METRICS_PORT which replaces LENSES_JMX_BROKERS.


Undefined variable if OAuth response body is empty

Whenever the response body is null, the exception is thrown without the $errorText variable being set.
https://github.com/google/google-api-php-client/blob/master/src/Google/Auth/OAuth2.php#L118
  $decodedResponse = json_decode($response->getResponseBody(), true);
  if ($decodedResponse != null && $decodedResponse['error']) {
    $errorText = $decodedResponse['error'];
    if (isset($decodedResponse['error_description'])) {
      $errorText .= ": " . $decodedResponse['error_description'];
    }
  }
  throw new Google_Auth_Exception(
      sprintf(
          "Error fetching OAuth2 access token, message: '%s'",
          $errorText
      ),
      $response->getResponseHttpCode()
  );

Closing, but feel free to re-open if it's still an issue.


DEV: apply black formatting to code base + tests

will need to do this in its own PR

Closing, fixed by #224


Zoom to search

Overview
The features search API includes the extent (outer boundaries) of the
search results in the form [y1, x1, y2, x2], representing the lower left
and upper right corners of the boundaries of the results.
We want to zoom to the extent of the search results, so we have added
this to allow that functionality. If the data from a search includes an extent field
(an array of [y1, x1, y2, x2]) then the map will zoom to fit the boundaries of the extent. The
map will zoom again if the extent changes.
The zoom to search functionality is turned on and off by a checkbox on
the map, which is selected by default. Users are able to disable zoom to
search by unchecking the checkbox.
The state of the checkbox is held in the UI reducer. This seemed like
a logical location as it primarily controls the way information is
presented, not the information itself.
Connects #406
Demo

Notes

The checkbox to disable the filter is currently located on the map and mimics the style of the legend that already exists. This should be reviewed by a designer.

Because there is no hook in the pagination classes to allow additional
data fields to the response, we added the extent directly to the
response data. We attempted an extension of the pagination class to
allow for the addition of the extent data directly, but the current
setup of the classes involved didn't allow for this extension.

Testing Instructions

Run ./scripts/update in Vagrant ssh
Search for facilities - searching with a specific region name will give the most noticeable results
The map should zoom to the search results
Search for a specific facility by name
The map should zoom to the facility
Disable 'zoom to search' with the checkbox on the map
Search for facilities, then a specific facility
The map should not zoom in response to the searches

Checklist

[x] fixup! commits have been squashed
[x] CI passes after rebase
[ ] CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

@designmatty I added you as a reviewer on this commit PR Tai and I wanted to get your input on the design of the new "Zoom To Search" checkbox. Tai did a great job matching it to the style of the existing legend controb, but we would welcome a different design if you think a different approach would be more effective.

@designmatty We merged this to not cause conflicts with our upcoming work on polygonal search. If you have some recommended changes we can implement them in a follow-up PR.

Based on a conversation in Slack, adding a note on context related to this PR for historical reference:
"When adding "zoom to extent" as the default, we wanted to leave the original behavior as an option. Use case was that a researcher might zoom to a part of the world they are specifically interested in and want to play will the filters to see various search results in that area."


pl.stringx.replace returns ""

str = require("pl.stringx")

io.write("Directory: ")
directory = io.read()
directory1 = str.replace(directory, "C", "D")
print(directory1)

Inputting a directory to replace the c drive with the d drive returns ""

seems to work for me?
> print(directory)
C:\hello\world
> print(stringx.replace(directory, "C", "D"))
D:\hello\world
>

is your output consistently wrong? what do you input?

My input was something like "C:\Program files"

@odddollar We need something more than "something like", we're going to need the exact input you were using. I checked with directory = "C:\\Program files\\foo" and it works fine for me. Lets see exactly what you directory variable is set to at the time you pass it to stringx.


Update Posts “license”

Automatically generated by Netlify CMS

👷 Deploy Preview for compassionate-almeida-a2aa5b processing.
🔨 Explore the source changes: 2a6989470bac18af67a4389a47acd46c7ed5b68b
🔍 Inspect the deploy log: https://app.netlify.com/sites/compassionate-almeida-a2aa5b/deploys/61a91bfec42976000766649b


Add missing '/' in source

To avoid the (granted, small) surprise that the commented source does not work when used as is.

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes
Have you signed the CLA already but the status is still pending? Recheck it.


GFW golang.org

Hi,
Because of the nasty GFW from the Chinese government, golang.org can't be accessed from China especially in shell like "go get github.com/tools/godep", so I replace "golang.org/x/tools" with its mirror "github.com/golang/tools".
Would you please accept the pull request for this reason?
Thank you

+1

A workaround for this would be to checkout the github golang tools git repo to $GOPATH/src/golang/x/tools. After that you can use import "golang.org/x/tools..." and  godep save -r ./... as needed.

We could also solve this by using godep on itself. ;)

@kr Yes, perhaps we should.


Bundling doesn't seem to be right

When trying to integrate the Vite plugin, I get this error:
webclient on  update-react-sourcemaps-tool [!] via  v18.16.0
❯ pnpm build

><EMAIL_ADDRESS>build /Users/calebjasik/Git/defined.net/webclient
> vite build && pnpm post-build

failed to load config from /Users/calebjasik/Git/defined.net/webclient/vite.config.ts
error during build:
file:///Users/calebjasik/Git/defined.net/webclient/vite.config.ts.timestamp-1694618874841-ea67fb622aaf5.mjs:3
import { ViteReactSourcemapsPlugin } from "file:///Users/calebjasik/Git/defined.net/webclient/node_modules/.pnpm/@acemarke+react-prod-sourcemaps<EMAIL_ADDRESS>         ^^^^^^^^^^^^^^^^^^^^^^^^^
SyntaxError: Named export 'ViteReactSourcemapsPlugin' not found. The requested module 'file:///Users/calebjasik/Git/defined.net/webclient/node_modules/.pnpm/@acemarke+react-prod-sourcemaps<EMAIL_ADDRESS>is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'file:///Users/calebjasik/Git/defined.net/webclient/node_modules/.pnpm/@acemarke+react-prod-sourcemaps<EMAIL_ADDRESS>const { ViteReactSourcemapsPlugin } = pkg;

    at ModuleJob._instantiate (node:internal/modules/esm/module_job:124:21)
    at async ModuleJob.run (node:internal/modules/esm/module_job:190:5)
 ELIFECYCLE  Command failed with exit code 1.

webclient on  update-react-sourcemaps-tool [!] via  v18.16.0
❯

which matches the errors described in https://arethetypeswrong.github.io/?p=%40acemarke%2Freact-prod-sourcemaps%400.0.5

{
  "compilerOptions": {
    "module": "ESNext",
    "target": "ESNext",
    "moduleResolution": "node",
    "esModuleInterop": true,
    "jsx": "preserve",
    "noEmit": true,
    // Typescript 4.0 allows incremental typechecks: https://devblogs.microsoft.com/typescript/announcing-typescript-4-0-beta/#incremental-with-noemit
    "incremental": true,
    "baseUrl": ".",
    "typeRoots": ["node_modules", "types"], // https://github.com/microsoft/TypeScript/issues/54629#issuecomment-1589593147
    "types": ["vite/client", "vite-plugin-svgr/client"],
    "strict": true,
    "noImplicitOverride": true,
    "skipLibCheck": true,
    "forceConsistentCasingInFileNames": true,
    "noFallthroughCasesInSwitch": true,
    "resolveJsonModule": true,
    "noUncheckedIndexedAccess": true,
    "verbatimModuleSyntax": true,
    "plugins": [{ "name": "typescript-plugin-css-modules" }],
    // If you add any more aliases here, be sure to also add it to .prettierc.cjs
    "paths": {
      "@api/*": ["src/api/*"],
      "@api": ["src/api/"],
      "@assets/*": ["src/assets/*"],
      "@components/*": ["src/components/*"],
      "@global/*": ["src/global/*"],
      "@hooks/*": ["src/hooks/*"],
      "@mock/*": ["mock/*"],
      "@screens/*": ["src/screens/*"],
      "@test-setup/*": ["test-setup/*"],
      "@dn-types/*": ["types/*"],
      "@util/*": ["src/util/*"]
    }
  },
  "include": ["src", "types", "test-setup", "mock", "e2e"],
  "exclude": ["functions/**/*"]
}

I think this is an indication that something's a bit weird somewhere though?

hmm, ok, I may try to muck around and sort it out thenn

I think one pertinent problem may be marking the package.json as module syntax w/ type: 'module' but outputting CommonJS - https://github.com/markerikson/react-prod-sourcemaps/blob/446dd17d335a0f8a69f0af10f89255c7fbfd2b65/tsconfig.json#L8
Since node supports ESM solidly nowadays, maybe we could output ESM instead of CommonJS or outputting both? ex: https://github.com/vitejs/vite/discussions/13928

Updated #10 and it should look good now:
┌───────────────────┬───────────────────────────────────┐
│                   │ "@acemarke/react-prod-sourcemaps" │
├───────────────────┼───────────────────────────────────┤
│ node10            │ 🟢                                │
├───────────────────┼───────────────────────────────────┤
│ node16 (from CJS) │ 🟢 (CJS)                          │
├───────────────────┼───────────────────────────────────┤
│ node16 (from ESM) │ 🟢 (ESM)                          │
├───────────────────┼───────────────────────────────────┤
│ bundler           │ 🟢                                │
└───────────────────┴───────────────────────────────────┘

Okay, published https://github.com/markerikson/react-prod-sourcemaps/releases/tag/0.1.0 !

thx! i'll test today

I just tested this for Sentry and it properly remapped our react build. @markerikson do you think there is a chance we could generate sourcemaps for react-dom/profiling bundle as well? There seem to be a lot of folks (including us at Sentry) that use this in production.

upgrading to 0.1.0 and i'm nearly there! just hit one more snag:
✓ 2586 modules transformed.
computing gzip size (0)...[react-sourcemaps] __dirname is not defined
✓ built in 7.45s
error during build:
ReferenceError: __dirname is not defined
    at loadExistingReactDOMSourcemap (file:///Users/calebjasik/Git/defined.net/webclient/node_modules/.pnpm/@acemarke+react-prod-sourcemaps@0.1.0/node_modules/@acemarke/react-prod-sourcemaps/lib/index.mjs:195:31)
    at file:///Users/calebjasik/Git/defined.net/webclient/node_modules/.pnpm/@acemarke+react-prod-sourcemaps@0.1.0/node_modules/@acemarke/react-prod-sourcemaps/lib/index.mjs:258:12
    at file:///Users/calebjasik/Git/defined.net/webclient/node_modules/.pnpm/@ampproject+remapping@2.2.1/node_modules/@ampproject/remapping/dist/remapping.mjs:132:27
    at Array.map (<anonymous>)
    at build (file:///Users/calebjasik/Git/defined.net/webclient/node_modules/.pnpm/@ampproject+remapping@2.2.1/node_modules/@ampproject/remapping/dist/remapping.mjs:119:38)
    at buildSourceMapTree (file:///Users/calebjasik/Git/defined.net/webclient/node_modules/.pnpm/@ampproject+remapping@2.2.1/node_modules/@ampproject/remapping/dist/remapping.mjs:110:16)
    at remapping (file:///Users/calebjasik/Git/defined.net/webclient/node_modules/.pnpm/@ampproject+remapping@2.2.1/node_modules/@ampproject/remapping/dist/remapping.mjs:186:18)
    at maybeRewriteSourcemapWithReactProd (file:///Users/calebjasik/Git/defined.net/webclient/node_modules/.pnpm/@acemarke+react-prod-sourcemaps@0.1.0/node_modules/@acemarke/react-prod-sourcemaps/lib/index.mjs:233:20)
    at rewireSourceMapsFromGeneratedAssetList (file:///Users/calebjasik/Git/defined.net/webclient/node_modules/.pnpm/@acemarke+react-prod-sourcemaps@0.1.0/node_modules/@acemarke/react-prod-sourcemaps/lib/index.mjs:31:27)
    at Object.writeBundle (file:///Users/calebjasik/Git/defined.net/webclient/node_modules/.pnpm/@acemarke+react-prod-sourcemaps@0.1.0/node_modules/@acemarke/react-prod-sourcemaps/lib/index.mjs:80:11)
    at file:///Users/calebjasik/Git/defined.net/webclient/node_modules/.pnpm/rollup@3.29.3/node_modules/rollup/dist/es/shared/node-entry.js:25539:40
    at async Promise.all (index 0)
    at async PluginDriver.hookParallel (file:///Users/calebjasik/Git/defined.net/webclient/node_modules/.pnpm/rollup@3.29.3/node_modules/rollup/dist/es/shared/node-entry.js:25467:9)
    at async file:///Users/calebjasik/Git/defined.net/webclient/node_modules/.pnpm/rollup@3.29.3/node_modules/rollup/dist/es/shared/node-entry.js:26787:13
    at async catchUnfinishedHookActions (file:///Users/calebjasik/Git/defined.net/webclient/node_modules/.pnpm/rollup@3.29.3/node_modules/rollup/dist/es/shared/node-entry.js:25905:16)
    at async build (file:///Users/calebjasik/Git/defined.net/webclient/node_modules/.pnpm/vite@5.0.0-beta.1/node_modules/vite/dist/node/chunks/dep-e31699fa.js:48096:22)
    at async CAC.<anonymous> (file:///Users/calebjasik/Git/defined.net/webclient/node_modules/.pnpm/vite@5.0.0-beta.1/node_modules/vite/dist/node/cli.js:842:9)
 ELIFECYCLE  Command failed with exit code 1.

maybe it's b/c i have
 build: {
      outDir: '.definednet/build',
      // Generate source maps for sentry, but don't expose them to the public
      sourcemap: mode === 'production' ? 'hidden' : true,
    },

set in my Vite config?
where does __dirname come from? all I see is
https://github.com/markerikson/react-prod-sourcemaps/blob/281e1168a88e80fb095246c5513c002c283c1ee3/src/build-plugin.test.mts#L145
and
https://github.com/markerikson/react-prod-sourcemaps/blob/281e1168a88e80fb095246c5513c002c283c1ee3/src/index.mts#L66

Yeah, __dirname implicitly exists in CJS modules, but not ESM.  But import.meta exists in ESM and not CJS.
I have a tentative fix for that in #12 .

what's the sourcemap viz tool that you use?

ah, https://evanw.github.io/source-map-visualization/

__dirname issue should be fixed:
https://github.com/markerikson/react-prod-sourcemaps/releases/tag/v0.2.0

ayyye yup that was my last issue - i just merged a setup using the Vite plugin w/ a pnpm patch for fixing the __dirname usage


linux/kernel/generic.nix: assert if constraints would be ignored

Description of changes
There appears to be a real mess with the naming of the attribute which contains structured extra configuration:

Nixpkgs' linux kernel expression uses structuredExtraConfig.
NixOS uses extraStructuredConfig.
Nixpkgs' kernelPatches use extraStructuredConfig.

At the moment, if the user uses the wrong convention the configuration constraints are silently dropped.  Let's assert instead so they at least know that their request isn't being respected.  We can try to harmonize the naming later.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

wouldn't it be better to standardize on extraStructuredConfig ?

wouldn't it be better to standardize on extraStructuredConfig ?

Maybe, but that's a separate issue.  This attribute is exposed to users outside of nixpkgs, so we need to add an assert either way.  Unfortunately linux-kernel uses ...-style arguments, so it won't catch spelling errors.
I don't particularly care which spelling is used, but silently ignoring things is strictly worse than either choice.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/improving-custom-configuration-for-alternate-kernels/45240/2


Make Implementation of DAO methods

[x] build all implementations of DAO methods
[x] implement for admin class
[x] implementation faculty class
[x] implement course and corse_plan class
[x] batch class implementation

done ✅


Syntax themes are not working

It looks like the styles do get applied but in such a way that the default colors for Twlight always take precedence:

Browser: Chrome - Version 72.0.3626.119 (Official Build) (64-bit)
Operating System: MacOS - Mojave 10.14
Link to page with the issue: https://github.com/StylishThemes/GitHub-Dark-Script/blob/master/github-dark-script.user.js
Screenshot:

Already fixed by https://github.com/StylishThemes/GitHub-Dark-Script/pull/59

Should be fixed in 2.5.1.

🎉 Thank you!


Creating an address takes a massive amount of time on large wallets

Context

Information
-

Version

Platform

Installation

Steps to Reproduce

Have a large Byron wallet (100K+ transactions, 50K+ UTxO, 50K+ existing addresses).
Import a single address using the /byron-wallets/addresses endpoint

Expected behavior

The address is promptly imported.

Actual behavior

The wallet hangs for several minutes before completing the operation.

Resolution

A possible started would be to look more closely at the strictness of the scanl used in the handler.

QA

Even on a rather "small" wallet, importing 10K addresses took 5s, and then, importing a new address took more than 10s. So there's something quite fishy.

On different runs, it seems like the behaviour is not entirely consistent. Somehow, the stake pool restoration worker also seem to have an impact when creating addresses. Once the wallet is fully synced and done fetching metadata, it seems like creating new addresses is done in a decent amount of time. I have however been very inconsistent in my testing here so I am planning to extend the nightly restoration benchmark to see how this actually performs there.

lgtm


Issue in adding IPV6, IPV4 entries in Firmware->Download location filter

When we are trying to add TFTP IPV4 & IPv6 entries in the download location filter page, we see that the buttons with "+" symbol is frozen and not letting us to add the addresses.
The following is the screenshot of the UI page

adding JIRA ticket [INFOSYS-226] Issue in adding IPV6, IPV4 entries in Firmware->Download location filter - JIRA (rdkcentral.com)


Correct Feedback Link

Hi, the link for feedback on the Product (as opposed to page) now dumps you at the root of the MS communities website, not even in the PowerAutomate area, is this correct? If I'm trying to feedback to MS on a product, I would expect to be taken to a community page at all but more a direct MS idea/suggestion/complaint page? I'm trying to report functionality missing from the product not seeking additional community advice.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 02f1be79-2b3a-31da-7a7d-ace1eac5d1f1
Version Independent ID: fa7c7450-15a6-edc8-5671-f45763267ca6
Content: PowerShell support - Power Platform
Content Source: power-platform/admin/powerapps-powershell.md
Service: power-platform
GitHub Login: @jimholtz
Microsoft Alias: jimholtz

@paulhasell
For product-related feedback, visit https://ideas.powerapps.com.


Flaky test: ZooKeeperRegistrationTest.testConnectionRecovery

ZooKeeperRegistrationTest.testConnectionRecovery: FAILURE
com.linecorp.armeria.server.zookeeper.ZooKeeperRegistrationTest > testConnectionRecovery FAILED
    java.lang.AssertionError: expected:<Expired> but was:<Disconnected>
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.failNotEquals(Assert.java:834)
        at org.junit.Assert.assertEquals(Assert.java:118)
        at org.junit.Assert.assertEquals(Assert.java:144)
        at com.linecorp.armeria.server.zookeeper.ZooKeeperRegistrationTest.testConnectionRecovery(ZooKeeperRegistrationTest.java:137)

@anuraaga how to reproduce this?  I have tried many times, can not see this error.

Will be fixed by #673


Disable trace and debug 'log' messages in release builds

Fafnir is typically run with RUST_LOG=warn,fafnir=info,mimir=info to limit log verbosity during jobs.
However many of these errors are still visible:
ERRO slog-async: logger dropped messages due to channel overflow, count: 271

It seems that some debug and trace messages in dependencies (which are using "log" crate) cause overflow, even if these messages are ignored at runtime.
This PR enables "release_max_level_info" feature on "log" crate to disable these unnecessary log calls at compile time in release builds. Note that a similar feature is already set on "slog" crate, but has no effect on crates that only depend on "log".
I have checked that this change works as expected with RUST_LOG=trace cargo test --release : DEBG and TRCE messages are no longer visible.

This is super weird to be forced to add a sub-dependency to pass features...

This is super weird to be forced to add a sub-dependency to pass features...

Yes. But that's what is recommended by slog-scope documentation
https://docs.rs/slog-stdlog/4.0.0/slog_stdlog/index.html#compile-time-log-level-filtering


What does "accuracy per sequence" mean and how BLEU score is computed?

Description
Hello, I have a question during my using t2t for a text2text problem.
I defined a problem and used my own dataset for training, the tensorboard shows the evaluation metrics, which includes the accuracy, accuracy per sequence, and the BLEU score.
My question is

what's the difference between "accuracy" and "accuracy per sequence"
How is BLEU computed? (For a sequence or a token)

Let's assume that my input is
input1, input2, input3
and the output is
output1, output2, output3, output4
and the ground truth is
truth1, output2, truth3
so, for this training example, what is the score of "accuracy" and "accuracy per sequence"? After reading the metrics.py, I think the "accuracy" is calculated for each token? (1/3 for this example since the output2 is predicted correctly), and "accuracy per sequence" is 0? (because only when the output and ground truth is completely identical (allow for the incorrect of output4) the value can be 1, and the "accuracy per sequence" is calculated as the completely_matched_example/all_example). Is this understanding correct?
For question 2, it is similar to question 1, when calculating the BLEU score, it is calculated for each example and calculate an average for all examples or it is calculated for each token and discard the concept of the "examples" (i.e. input a sentence and output a sentence).

"accuracy" is the percentage of correctly predicted tokens, "accuracy per sequence" is the percentage of correctly predicted sequences (sentences), i.e. sequences where all tokens are correctly predicted.
By default, the T2T evaluation is not autoregressive, ie. it works as in training - the task is just to predict the next token, given all previous tokens are predicted correctly (of course, this is not realistic and it underestimates the error, but it is much faster to compute). So it cannot happen that the predicted output has 4 tokens, but the ground truth just 3 tokens as in your example. This could happen only with --eval_run_autoregressive or in the real decoding (using t2t-decoder, where also the beam search can be taken into consideration).

See the original paper about BLEU for its definition. BLEU is a document-level metric and cannot be decomposed as a function (e.g. weighted average) of sentence-level BLEU scores (nor any token-level scores). The reason is the BLEU brevity penalty.

@martinpopel Thank you very much for your reply.
For question 1, I have understood. But for question 2, after reading the paper, I still have some questions.
Let‘s keep using my example mentioned above, for such an example, we can calculate the BLEU score according to the model output and ground truth. (If I understand correctly, because the model only outputs these few words, these few words (this sentence) are what you call the document-level).
And my question is how is the final score (t2t-bleu.py returned) is calculated? My validation/test set contains many samples like the example I mentioned above, so how is the final BLEU result calculated? Is it an average of all samples?

If your document (test set) contains only a single sentence, you can compute BLEU on it, but it will be very unreliable. Averaging e.g. 1000 sentence-level BLEU scores gives a different value (and much less reliable) than computing one document-level BLEU on the same 1000-sentence test set. By reliability I mean correlation with human judgement. If you need sentence-level MT evaluation, use e.g. chrF score (which is also character level, which may be another advantage for some languages).
For understanding BLEU, it may be easier to read the source code rather than the original paper. Note that for (references, translations) in zip(reference_corpus, translation_corpus): means for each sentence (each pair of system translation and the respective reference translation) in the test set.
Why I called BLEU a document-level metric?
Note that BLEU = brevity_penalty * geometric_mean(precision of unigrams...4grams). If your test set contains a single sentence only and if there is no matching 4gram (which can happen in a single sentence), the 4gram precision is 0 and thus the whole BLEU should be 0. The implementation in T2T uses "smoothing", so the final BLEU will be non-zero, but still very low and unreliable. Another reason is the brevity penalty (BP): if the single sentence has e.g. 4 tokens and the reference 6 tokens, BP=exp(1-6/4)=0.6, so the BLEU score is just 60% of the geometric mean, which seems as a too harsh penalty for being only two tokens shorter than the reference. On the other hand if the single sentence has 6 tokens and the reference 4, the unigram precision can be at most 4/6 (if all 4 tokens are matching the reference), the bigram precision at most 3/5, trigram 2/4 and 4gram 1/3, so the geometric mean (and the final BLEU) will be at most 0.508, which seems again as a too harsh punishment for adding only two extra tokens.

@martinpopel Thanks again for your detailed answer.

If your document (test set) contains only a single sentence, you can compute BLEU on it, but it will be very unreliable. If you need sentence-level MT evaluation, use e.g. chrF score.

I will change the calculation method to document-level and try to use chrF (my corpus is English-only).

For understanding BLEU, it may be easier to read the source code rather than the original paper.

After reading the the source code of BLEU, I found that it calculates the final score by first calculating and adding n-gram overlap for all the sentences in the test set together and calculate the final score for one time instead of doing sentence-level calculation and then doing average. Is this correct?

If your test set contains a single sentence only and if there is no matching 4gram (which can happen in a single sentence), the 4gram precision is 0 and thus the whole BLEU should be 0.

In my experiment, the model will only output a few words, about 2-6. So when calculating the BLEU score, n-gram overlap maybe 0 (4-gram overlap for sentence whose length is 2). For this situation, my previous approach was to set N in the N-gram to max(length_model_output, length_ground_truth) by setting weights, if it is greater than 4, then N is set to 4.
Then I used the sentence-level calculation method to calculate the BLEU score for each sample in the test set separately, and finally take the average value.
I don't know if this is a common practice? What are the disadvantages of doing like this?
(As you said, BLEU score is a document-level metric, so it is better to use document-level calculation method. Doing so will definitely cause some unreliability.)
Another question is if I use the document-level calculation, how to choose the parameter N, since the length of the sentence output by the model is very short (mostly 2-4).

I will change the calculation method to document-level and try to use chrF (my corpus is English-only).

Note that chrF is not available in T2T, but e.g. in sacreBLEU.

Is this correct?

Yes. That's the whole point.

In my experiment, the model will only output a few words, about 2-6.

Then BLEU is not suitable for this task. Restricting n-gram from 4 to 1 or 2 should help a bit, but the suitability is still questionable.
It may be wise to look if someone else does this type of task and what metric they used.
It depends on the task - e.g. when predicting names of cities and the reference answer is "New York", then "New Orleans" is as bad answer as "Miami" despite the one word overlap. In this case, you are probably interested in exact match (accuracy_per_sequence).

@martinpopel Thanks a lot!
I do use exact match as my evaluation metric. In order to make the results more comprehensive, I am also considering other metrics. I used BLEU and ROUGE before, now, I might turn to others...


Made node names in signal methods be lower case

This is to keep consistency with function naming conventions, yes? Since nodes are case sensitive in the scene tree hierarchy, it may cause some confusion if you want to hook two nodes of the same name into the same class with automatic methods (I.E. Node vs node will produce the same auto-generated function.)
I'm in favor of this change though, just pointing out it will create some overlap cases (that already existed before anyway, when dealing with child-of relationships.)

@TheYokai Yes, is for convention sake. And I don't think that overlapping will be much of a problem, as I don't see why somebody would have nodes with the same name but with different casing.

I'm not sure about this change, I think it's good that the name injected in the method prototype is the exact name of your node in the scene tree, it makes things easy to identify. If you prefer it lowercase, it's easy to fix manually, but personally I like to keep it as created or to set a completely custom method name.

@akien-mga I don't see how the name being lower cased makes it any harder to identify anything. It also incentivizes respecting the style guide, which help create good coding habits.

The style guide calls for node names to use PascalCase. As it stands, you can customize the connecting function, but if you're letting the engine name the function automatically it should match the node's name.

@cbscribe Yes, node and class names, not functions. And I don't think that the process being automatic is a good justification.

I disagree with this change. I know functions are usually lower case, but I name my nodes uppercase and I want such signal handlers to reflect that exactly, which also makes them stand out as "functions you should not be calling from code". When I want to connect an existing function then I edit the handler name anyways.
If your convention is different I would at least suggest an option?

I agree with @Zylann, and I don't think it's worth adding an option nobody would ever notice (and thus, use) in the project settings. Keeping the identifier unchanged is much better IMO (especially since if we wanted to do things properly for this feature, it should use camelcase_to_underscore, not lowercase, we can add more inconsistencies).


Problem in add this library to eclipse

why when i add this library(main) to my eclipse project as library
in Android Dependecies /main/
nothing?

Hi,
This library has been developed on Android Studio, I can't say if it can work in Eclipse. But I advice you to start working with Android Studio. Thanks for your time ;)


Name clash in RouDi process removeProcess()

Required information
Operating system:
General issue
Compiler version:
General issue
Observed result or behaviour:
PR #258 cleaned-up some local variable name prefixes. However, that introduced a name clash inside a function rendering a check useless.
Expected result or behaviour:
Do a proper check.
Conditions where it occurred / Performed steps:
In file /iceoryx_posh/source/roudi/roudi_process.cpp inside bool ProcessManager::removeProcess(...) fix
...
auto name = it->getName();
if (name == name)
...

Good catch. I hoped -Wtautological-compare could help here, but it seems it doesn't catch it

Good catch. I hoped -Wtautological-compare could help here, but it seems it doesn't catch it
Yeah, unfortunately it doesn't. Checked it.


[Sticky] Feature Request: Cooldown on reposting sticky message

Please add a config for cooldown/delay for Sticky cog so that the cog posts the sticky only after a set amount of time has passed since the last time it posted it.
Currently it deletes and reposts immediately after each message which makes even small conversations very annoying to hold in the channel. I'm aware this request is like a duplicate of or very similar to #74 but a simple cooldown timer might be strictly easier to implement and will make sticky have utility in more use cases.

Hi @Q-out, thanks for opening this feature request.
I've added a 3-second cooldown to Sticky, so messages should never be posted in a channel more often than 3 seconds at a time.
You're right that this is a much simpler approach than #74, in terms of both implementation and user experience. So I'm sticking with this one over #74 :)


WDS fails to bundle on localhost subdomains

Bug report

What is the current behavior?
Webpack Dev Server fails with an unhandled error when trying to listen to localhost subdomains.
If the current behavior is a bug, please provide the steps to reproduce.

devServer.listen(port, 'my.localhost', err => {
    console.log('Starting the development server...\n');
});

What is the expected behavior?
Webpack Dev Server should catch errors while trying to establish the connection and report the failure.

Other relevant information:
webpack version: 4.29.3 (dev server: 3.1.14)
Node.js version: 11.10.1
Operating System: Mac OSX
Additional tools: n/a
For those interested, I solved the issue by editing (on Mac) /etc/hosts and added this line to the end:
<IP_ADDRESS> my_subdomain.localhost

@aryzing can you create minimum reproducible test repo?


Closing the gdb-server terminal in vscode causes ubuntu to log out

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: V1.64.1
OS Version: ubuntu 20.04

Steps to Reproduce:

open vscode
Install the extension：Cortex-Debug
press F5 to debug
close vscode or close gdb-server, ubuntu will log out

/causedByExtension


@ApiParam inheritance is not working

Q
A

Bug or feature request?
Could be both. Decide for yourself.

Which Swagger-Core version?
Springfox 2.7.0, Swagger 1.5.13

Which Java version?
8

I have an interface which a controller implementation inherits from. The interface looks like this:
	ResponseEntity<SomeDto> createInstance(
			UriComponentsBuilder uri,
			@ApiParam(value = "MyDescription", required = true)
			@PathVariable("id") Integer theId);

However, the ApiParam does not make it into swagger-ui. More precisely, "MyDescription" is not shown in swagger-ui unless I put that into the controller. Shouldn't this be fixed in 1.5.10 already via #1746 ?

If you're using Springfox, the ticket should be opened there.


[multi container] Fix / implement review screen

This introduces the review screen by correctly comparing the service to podSpec instead of pod
based on #1547

The last commit (https://github.com/dcos/dcos-ui/pull/1551/commits/09f513a74c68b7ff46ab554f0b7e6e7dfc1df4ad) looks good and works great! I'm adding my label now but I understand this cannot merge yet :)

Since it depends on #1547 I reviewed the difference between this and #1547. See the diff here, which looks good to me.
Yes, let's wait with merging until #1547 have actually merged.

The last one 💪  @Poltergeist please rebase

@nLight rebased this PR.


List Guild Members Special Endpoint

https://discord.com/developers/docs/resources/guild#list-guild-members

are these being worked on?

I just realized this is already an endpoint, will close :sweat_smile:

This was likely meant to be referring to https://github.com/discord/discord-api-docs/pull/1577 rather than the normal paginated list members endpoint just mislinked

Can someone explain what this issue is about? Do we basically need to work a REST endpoint that we can use to search for guild members? It's kinda similar to lightbulb's get utility command

There is a chunked rest endpoint that we havent implemented yet (check FasterSpeeding's comment). This is fairly easy to do, its just @FasterSpeeding told me he was going to work on it, so I didnt.


add Dockerfile for Prow

Description
This is a Dockerfile for building image used in OpenShift CI (Prow) to run unit tests.
It is intentionally based on the Dockerfile used for building production image
Which issue(s) does this PR fix

Fixes #?

PR acceptance criteria
Please make sure that the following steps are complete:

[ ] GitHub Actions are completed and successful
[ ] Unit Tests are updated and passing
[ ] E2E Tests are updated and passing
[ ] Documentation is updated if necessary (requirement for new features)
[ ] Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Given other dockerfiles follow the pattern of [name/descriptor].Dockerfile
https://github.com/janus-idp/backstage-showcase/tree/main/docker https://github.com/janus-idp/operator/tree/main/docker
perhaps this new file should be called test.Dockerfile or prow.Dockerfile ?

good point. I'll change it


use ancestry in replace_children

the api uses replace_children (https://github.com/ManageIQ/manageiq-api/blob/01bb977042d6b75e73a0e568b4b3fd455b9d0ec7/app/controllers/api/vms_controller.rb#L107) which, as it isn't an ancestry method, wasn't extended to use the gem functionality.
thanks @agrare
this fixes the failing api specs
@miq-bot assign @agrare
@miq-bot add_label bug
broken in https://github.com/ManageIQ/manageiq/pull/20274

rspec ./spec/requests/vms_spec.rb:364 # Vms API Vm edit can edit a VM with an appropriate role has two failing expectations:
     1.3) Failure/Error: expect(vm.reload.children).to match_array(new_vms)

            expected collection contained:  [#<ManageIQ::Providers::Openstack::CloudManager::Vm id:<PHONE_NUMBER>0124, vendor: "openstack", format: ...emory_hot_add_increment: nil, hostname: nil, ems_ref_type: nil, restart_needed: nil, ancestry: nil>]
            actual collection contained:    [#<ManageIQ::Providers::Openstack::CloudManager::Vm id:<PHONE_NUMBER>0122, vendor: "openstack", format: ..._increment: nil, hostname: nil, ems_ref_type: nil, restart_needed: nil, ancestry: "71000000000121">]
            the missing elements were:      [#<ManageIQ::Providers::Openstack::CloudManager::Vm id:<PHONE_NUMBER>0124, vendor: "openstack", format: ...emory_hot_add_increment: nil, hostname: nil, ems_ref_type: nil, restart_needed: nil, ancestry: nil>]
            the extra elements were:        [#<ManageIQ::Providers::Openstack::CloudManager::Vm id:<PHONE_NUMBER>0122, vendor: "openstack", format: ..._increment: nil, hostname: nil, ems_ref_type: nil, restart_needed: nil, ancestry: "71000000000121">]
          # ./spec/requests/vms_spec.rb:389:in `block (3 levels) in <top (required)>'
          # /Users/drewmu/.rvm/gems/ruby-2.5.5/gems/webmock-3.11.1/lib/webmock/rspec.rb:37:in `block (2 levels) in <top (required)>'

should be fixed by the replace_children addition here
     1.4) Failure/Error: expect(vm.parent).to eq(vm_openstack2)

            expected: #<ManageIQ::Providers::Openstack::CloudManager::Vm id:<PHONE_NUMBER>0126, vendor: "openstack", format: n...memory_hot_add_increment: nil, hostname: nil, ems_ref_type: nil, restart_needed: nil, ancestry: nil>
                 got: nil

should be fixed by the save!

rspec ./spec/requests/vms_spec.rb:364 # Vms API Vm edit can edit a VM with an appropriate role has two failing expectations:
     1.3) Failure/Error: expect(vm.reload.children).to match_array(new_vms)

            expected collection contained:  [#<ManageIQ::Providers::Openstack::CloudManager::Vm id:<PHONE_NUMBER>0124, vendor: "openstack", format: ...emory_hot_add_increment: nil, hostname: nil, ems_ref_type: nil, restart_needed: nil, ancestry: nil>]
            actual collection contained:    [#<ManageIQ::Providers::Openstack::CloudManager::Vm id:<PHONE_NUMBER>0122, vendor: "openstack", format: ..._increment: nil, hostname: nil, ems_ref_type: nil, restart_needed: nil, ancestry: "71000000000121">]
            the missing elements were:      [#<ManageIQ::Providers::Openstack::CloudManager::Vm id:<PHONE_NUMBER>0124, vendor: "openstack", format: ...emory_hot_add_increment: nil, hostname: nil, ems_ref_type: nil, restart_needed: nil, ancestry: nil>]
            the extra elements were:        [#<ManageIQ::Providers::Openstack::CloudManager::Vm id:<PHONE_NUMBER>0122, vendor: "openstack", format: ..._increment: nil, hostname: nil, ems_ref_type: nil, restart_needed: nil, ancestry: "71000000000121">]
          # ./spec/requests/vms_spec.rb:389:in `block (3 levels) in <top (required)>'
          # /Users/drewmu/.rvm/gems/ruby-2.5.5/gems/webmock-3.11.1/lib/webmock/rspec.rb:37:in `block (2 levels) in <top (required)>'

should be fixed by the replace_children addition here
     1.4) Failure/Error: expect(vm.parent).to eq(vm_openstack2)

            expected: #<ManageIQ::Providers::Openstack::CloudManager::Vm id:<PHONE_NUMBER>0126, vendor: "openstack", format: n...memory_hot_add_increment: nil, hostname: nil, ems_ref_type: nil, restart_needed: nil, ancestry: nil>
                 got: nil

should be fixed by the save!

LGTM, @kbrock can you eyeball this as well?

LGTM, @kbrock can you eyeball this as well?


Prefer SVG badges to PNGs

because they render better on high resolution displays

^ same failure as #1341 which doesn't appear relevant. This should be safe to merge.


properly diff objects with arrays as attributes on variables

[x] Closes #9153, follow-up to #3728
[x] Tests added
[x] User visible changes (including notable bug fixes) are documented in whats-new.rst

Oops, the property test did find something
first = {'': array([False, False])}, second = {'': array([False, False])}

    def equivalent(first: T, second: T) -> bool:
        """Compare two objects for equivalence (identity or equality), using
        array_equiv if either object is an ndarray. If both objects are lists,
        equivalent is sequentially called on all the elements.
        """
        # TODO: refactor to avoid circular import
        from xarray.core import duck_array_ops

        if first is second:
            return True
        if isinstance(first, np.ndarray) or isinstance(second, np.ndarray):
            return duck_array_ops.array_equiv(first, second)
        if isinstance(first, list) or isinstance(second, list):
            return list_equiv(first, second)
>       return (first == second) or (pd.isnull(first) and pd.isnull(second))
E       ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()

true. To fix that, we'd have to support recursive attrs, which feels a bit much. If anything, I'd raise a ValueError stating that assert_* don't support those.


[Translate Text in Firestore] Translating field with an array of strings does not work on add document but on update.

[READ] Step 1: Are you in the right place?
Issues filed here should be about bugs for a specific extension in this repository.
If you have a general question, need help debugging, or fall into some
other category use one of these other channels:

For general technical questions, post a question on StackOverflow
with the firebase tag.
For general Firebase discussion, use the firebase-talk
google group.
To file a bug against the Firebase Extensions platform, or for an issue affecting multiple extensions, please reach out to
Firebase support directly.

[REQUIRED] Step 2: Configure for a field of array of strings.

Extension name: [Translate Text in Firestore]
Extension version<EMAIL_ADDRESS>Configuration values (redact info where appropriate):

_
_

[REQUIRED] Step 3: It does not translate the text of array of string when create the document.
But when I update the field again, it will translate it.
When I create the document:

When I update the field:

Steps to reproduce:
What happened? How can we make the problem occur?
This could be a description, log/console output, etc.
Expected result
Actual result

Hey I'm looking into this now. Can you share your config values for the extension?

I can't seem to reproduce this. Can you please provide

The extension config for the instance of the extension where this bug occurs
Any relevant logs from the deployed function

I tested it again and found out that this was my problem.
On updating the document I forget to pass the existing translated fields.
Sorry for that...

The issue is resolved?

Yes, thank a lot


extend line highlight to full line when nested inside scroll container

before:

after:

[ ]  test

Also, please rebuild Prism by running npm ci && npm run build.

Thank you for contributing @Bkucera!


Your claim page - should child name be starred out if visitor/prisoner name is?

yes

Verified


Adding React E-commerce Application in example.md

Thanks but we don't want Redux examples on this page.


Add the possibility to pass environment variable as header for the notification module

:pencil: Description
Add the possibility to pass an environment variable in an header value for the notification module.
This is useful when calling an API that has a protected endpoint.
A typical scenario is to pass an API token that is stored in a Kube secret and we want to pass it to the Kube monkey container via an environment variable.
headers = ["api-key:{$env:API_TOKEN}", "Content-Type:application/json"]

{$env:API_TOKEN} will be replaced by the environment variable API_TOKEN value.

Thanks for the contribution. Do you mind updating the example readme so that folks are aware of this feature?


Add new paths for mingw and msys64 for appveyor VS2019 image

Hopefully doens't break other images
Contributor Checklist:

[x] I have created a new test or updated the unit tests to cover the new/changed functionality.
[x] I have updated master/src/CHANGES.txt directory (and read the README.txt in that directory)
[x] I have updated the appropriate documentation

so while changing appveyor anyway, how about flip the py2.7 build to py3.8?


BoundingBox input types cannot be serialised to submit to Slurm cluster

Description
When sending a Bounding Box input type to the WPS server, it fails with an error:
<!-- PyWPS 4.4.0 -->
<ows:ExceptionReport xmlns:ows="http://www.opengis.net/ows/1.1" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.opengis.net/ows/1.1 http://schemas.opengis.net/ows/1.1.0/owsExceptionReport.xsd" version="1.0.0">
  <ows:Exception exceptionCode="SchedulerNotAvailable" locator="" >
      <ows:ExceptionText>Could not submit job: Object of type Crs is not JSON serializable</ows:ExceptionText>
  </ows:Exception>
</ows:ExceptionReport>

This seems to happen when trying to submit jobs to a Slurm cluster - so serialisation is required before submitting to Slurm, and it cannot do that.
Environment

operating system: CentOS7
Python version: Python 3.7.8
PyWPS version: 4.4.0
source/distribution
[ ] git clone
[ ] Debian
[x] PyPI
[ ] zip/tar.gz
[ ] other (please specify):
web server
[ ] Apache/mod_wsgi
[ ] CGI
[x] other (please specify): nginx

Steps to Reproduce
I am connecting from a GUI that posts the request, not sure how to reproduce.
Additional Information
I was able to fix if I make these two hacks to owslib and pywps:
owslib/ows.py
=========

    238 class BoundingBox(object):
    239     """Initialize an OWS BoundingBox construct"""
    240     def __init__(self, elem, namespace=DEFAULT_OWS_NAMESPACE):
    241         self.minx = None
    242         self.miny = None
    243         self.maxx = None
    244         self.maxy = None
    245         self.crs = None
    246         self.dimensions = 2
    247         if elem is None:
    248             return
    249         val = elem.attrib.get('crs') or elem.attrib.get('{{{}}}crs'.format(namespace))
    250         if val:
    251             try:
ADDED LINE:    252                 val = 'urn:ogc:def:crs:OGC:2:84'
    253                 self.crs = crs.Crs(val)
    254             except (AttributeError, ValueError):
    255                 LOGGER.warning('Invalid CRS %r. Expected integer' % val)

pywps/app/WPSRequest.py
==================

    444         # Using OWSlib BoundingBox
    445         from owslib.ows import BoundingBox
    446         bbox_datas = xpath_ns(input_el, './wps:Data/wps:BoundingBoxData')
    447         if bbox_datas:
    448             for bbox_data in bbox_datas:
    449                 bbox = BoundingBox(bbox_data)
    450                 LOGGER.debug("parse bbox: minx={}, miny={}, maxx={},maxy={}".format(
    451                     bbox.minx, bbox.miny, bbox.maxx, bbox.maxy))
    452                 inpt = {}
    453                 inpt['identifier'] = identifier_el.text
    454                 inpt['data'] = [bbox.minx, bbox.miny, bbox.maxx, bbox.maxy]
CHANGED LINE:    455                 inpt['crs'] = '' #bbox.crs
    456                 inpt['dimensions'] = bbox.dimensions
    457                 the_inputs[identifier].append(inpt)
    458     return the_inputs

I don't really know what these hacked lines do but it gets things working.
I'm happy to provide more info and test when I have more time.

I have the same problem now: First I had a general issue with getting the BBOX parameter work, but this was to my own mistake. But now I have the same problem with the CRS not being serializable.
It happens very randomly: I can submit a job with the following input:
<wps:Input>
    <ows:Identifier>area_of_interest</ows:Identifier>
    <wps:Data>
        <wps:BoundingBoxData crs="epsg:4326" dimensions="2">
            <ows:LowerCorner>-90.0 -45.0</ows:LowerCorner>
            <ows:UpperCorner>90.0 45.0</ows:UpperCorner>
        </wps:BoundingBoxData>
    </wps:Data>
</wps:Input>

It gets accepted and runs. After a few more executions I suddenly get this answer:
<?xml version="1.0" encoding="UTF-8"?>
<!-- PyWPS 4.5.1 -->
<ows:ExceptionReport xmlns:ows="http://www.opengis.net/ows/1.1" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.opengis.net/ows/1.1 http://schemas.opengis.net/ows/1.1.0/owsExceptionReport.xsd" version="1.0.0">
    <ows:Exception exceptionCode="NoApplicableCode" locator="" >
        <ows:ExceptionText>No applicable error code, please check error log.</ows:ExceptionText>
    </ows:Exception>
</ows:ExceptionReport>

and the log file tells me:
2022-03-21 08:57:37,137] [ERROR] file=/usr/local/lib/python3.8/dist-packages/pywps/exceptions.py line=48 module=exceptions function=__init__ Exception: code: 500, description: No applicable error code, please check error log., locator:
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/pywps/app/Service.py", line 314, in call
    raise e
  File "/usr/local/lib/python3.8/dist-packages/pywps/app/Service.py", line 304, in call
    response = self.execute(
  File "/usr/local/lib/python3.8/dist-packages/pywps/app/Service.py", line 82, in execute
    return self._parse_and_execute(process, wps_request, uuid)
  File "/usr/local/lib/python3.8/dist-packages/pywps/app/Service.py", line 145, in _parse_and_execute
    wps_response = process.execute(wps_request, uuid)
  File "/usr/local/lib/python3.8/dist-packages/pywps/app/Process.py", line 149, in execute
    wps_response = self._execute_process(self.async_, wps_request, wps_response)
  File "/usr/local/lib/python3.8/dist-packages/pywps/app/Process.py", line 215, in _execute_process
    dblog.store_process(self.uuid, wps_request)
  File "/usr/local/lib/python3.8/dist-packages/pywps/dblog.py", line 192, in store_process
    request_json = request.json
  File "/usr/local/lib/python3.8/dist-packages/pywps/app/WPSRequest.py", line 461, in json
    return json.dumps(obj, allow_nan=False, cls=ExtendedJSONEncoder)
  File "/usr/lib/python3.8/json/__init__.py", line 234, in dumps
    return cls(
  File "/usr/lib/python3.8/json/encoder.py", line 199, in encode
    chunks = self.iterencode(o, _one_shot=True)
  File "/usr/lib/python3.8/json/encoder.py", line 257, in iterencode
    return _iterencode(o, 0)
  File "/usr/local/lib/python3.8/dist-packages/pywps/app/WPSRequest.py", line 442, in default
    encoded_object = json.JSONEncoder.default(self, obj)
  File "/usr/lib/python3.8/json/encoder.py", line 179, in default
    raise TypeError(f'Object of type {o.__class__.__name__} '

To make it execute again or at least not get an  error is to remove the CRS from the BBox input like this:
<wps:Input>
    <ows:Identifier>area_of_interest</ows:Identifier>
    <wps:Data>
        <wps:BoundingBoxData dimensions="2">
            <ows:LowerCorner>-90.0 -45.0</ows:LowerCorner>
            <ows:UpperCorner>90.0 45.0</ows:UpperCorner>
        </wps:BoundingBoxData>
    </wps:Data>
</wps:Input>

I am calling the service asynchronously and have pyWPS integrated into a flask app that is run via gunicorn and exposed via nginx. The same as described in the Howtos for production system. I suspect it has to do if jobs are immediately executed by a worker or put into a local queue. It is all very sporadic and my feeling is that increasing the number of workers helped, but the whole pyWPS interface degrades over a time

Could it be a problem with the BBox input serialisation if it needs to be scheduled via a queue?

My further investigations
The object that is not JSON encodable is urn:ogc:def:crs:EPSG::4326.

fixed by PR #650


Hide status bar or change preferred style

Hey, It seems KVNProgress sets its own status bar style / visibility , disregarding prefersStatusBarHidden() .
Even when the default value is a hidden status bar, using KVNProgress.show or any other method will make the status bar "appear" and then will hide it on dismissal.
Any way to make KVNProgress adhere to the default values of status bar visibility, or at least provide a method to set the visibility and style of the status bar in the KVNProgress view ? :)
Thanks!
Shai

Would be nice!

Unfortunately it seems like this project is heavily unmaintained. I've filed a bunch of reports / issues and no replies have been given. Very sad, since I really like this project.

Just add to the KVNRotationViewController.m:
- (UIStatusBarStyle)preferredStatusBarStyle{
    return UIStatusBarStyleLightContent; //or whatever you preffer
}

@fralways , that wouldn't work I think if one has this case as mine: http://stackoverflow.com/questions/41735911/is-there-a-way-to-call-prefersstatusbarhidden-without-view-controller-based-stat -- I use KVNProgress. Author might be very busy.

As I wrote earlier it seems as if this project isn't maintained. Might just fork this and continue independently until he's able to resolve.

Thanks @freak4pc . Can you share with us your forked project? Can it be use via cocoapods?

Same issue :/


theHarvester: 3.1 -> 3.2.2

Motivation for this change
Update to latest upstream release 3.2.2
Change log: https://github.com/laramies/theHarvester/releases/tag/3.2.2
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109667 run on x86_64-linux 1

3 packages built:

python37Packages.censys
python38Packages.censys
theharvester

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109667 run on x86_64-linux 1

3 packages built:

python37Packages.censys
python38Packages.censys
theharvester

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109667 run on x86_64-darwin 1

1 package marked as broken and skipped:

python39Packages.censys

3 packages built:

python37Packages.censys
python38Packages.censys
theharvester

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109667 run on x86_64-darwin 1

1 package marked as broken and skipped:

python39Packages.censys

3 packages built:

python37Packages.censys
python38Packages.censys
theharvester


RSA Algorithm

RSA algorithm is an asymmetric cryptography algorithm. Asymmetric actually means that it works on two different keys i.e. Public Key and Private Key. As the name describes that the Public Key is given to everyone and the Private key is kept private.
An example of asymmetric cryptography:

A client (for example browser) sends its public key to the server and requests some data.
The server encrypts the data using the client’s public key and sends the encrypted data.
The client receives this data and decrypts it.
Since this is asymmetric, nobody else except the browser can decrypt the data even if a third party has the public key of the browser.

Generating Public Key:

Generating Private Key:

Encryption and Decryption of word "Hi"

Thus i want to add the C,C++,Java,Python Code for the RSA Algorithm
@Kumar-laxmi @zugzwang03  @Arun9739 @Sanjanabharadwaj25 @072arushi please assign me this issue.

refer #416


Dispatch event after token has been changed

1. Why is this change necessary?
Since v<IP_ADDRESS> the SalesChannelContextPersister assigns the new token into the SalesChannelContext, this results that CustomerLoginEvent loses the previous token.
2. What does this change do, exactly?
Dispatch a new event 'SalesChannelContextTokenChangeEvent' which contains both tokens.
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Checklist

[x] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] I have created a changelog file with all necessary information about my changes
[x] I have written or adjusted the documentation according to my changes
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

now please squash your commits to one please :blush:
also your code style needs to be fixed https://github.com/shopware/platform/pull/1357/checks?check_run_id=1143070773
please execute ./psh.phar fix-cs

@mitelg Finally I got this squash into the single commit, I hope everything is correct. (That's my first squash, sorry for the many requests)

thanks for your contribution @maqavelli 👍 🎉 💙


Add tpebs retire latency mean as default value in event JSON files

This change add support for default retire latency values in converted perf JSON files. It loads platform specific retire latency default value in JSON file and insert the mean retire latency data into event JSON files as a new field to each event.
An example as following (the xxxx will be float value in real files):
    {
        "BriefDescription": "Retired load instructions with locked access.",
        "Counter": "0,1,2,3",
        "Data_LA": "1",
        "EventCode": "0xd0",
        "EventName": "MEM_INST_RETIRED.LOCK_LOADS",
        "PEBS": "1",
        "PublicDescription": "Counts retired load instructions with locked access.",
        "RetireLatencyMean": xxxx,
        "SampleAfterValue": "100007",
        "UMask": "0x21",
        "Unit": "cpu_core"
    }

Closing this PR because this code resolves a request that is out dated. We might reopen this PR and/or update it when we revisit TPEBS default value support.


Scripted pipeline

Now this pipeline should have all feature that old pipeline had.
Description of the Change
Rewrite declarative pipeline to scripted pipeline
Benefits
Flexibly
Possible Drawbacks
May appear Blue Ocean visualization problems.
Usage Examples or Tests [optional]
Alternate Designs [optional]

Please, make a test run of the pipeline to check the upload of Docker images and other artifacts. For that replace dev and master branch instances in the code with the name of the current branch. Also make sure you push Docker images with some other tag (not latest or develop or develop-build)

There were some conflict in  load functions(vars =  load ".jenkinsci/vars.groovy"), using def in front helps.
mac-mcst-3 have different curl version that break upload process,  using  curl --http1.1 helps
There are several conflict in build parameter,
ex:
-fuzzing and compiler version,  fuzzing works only with clang
-tests_ and build type Release, tests do not build,
-package and build type  Debug,  *.tar.gz empty , tests empty
-sanitize and   build type Release
-etc
so checkbox becomes useless, you can not select that you want.
there are to solutions that I see:
1.rewrite the cmakeFile
2.reduce options, see: https://soramitsu.atlassian.net/browse/DOPS-202

@bakhtin package are  pushed  successfully.

please, delete image with tag *not-supposed-to-be-pushed
https://hub.docker.com/r/hyperledger/iroha/tags
please, folders PR-1960-20181220*
https://nexus.iroha.tech/#browse/browse:artifacts:iroha%2Fmacos
https://nexus.iroha.tech/#browse/browse:artifacts:iroha%2Flinux%2Fx86_64


Could not resolve "xlsx" vite js

node_modules/tempa-xlsx/ods.js:13:29:
13 │     catch(ee) { return require('xl' + 'sx').utils; }
│                                ~~~~
╵                                "./xlsx"
Use the relative path "./xlsx" to reference the file "node_modules/tempa-xlsx/xlsx.js". Without
the leading "./", the path "xlsx" is being interpreted as a package path instead.
6:30:55 PM [vite] error while updating dependencies:
Error: Build failed with 1 error:
node_modules/tempa-xlsx/ods.js:13:29: ERROR: Could not resolve "xlsx"
at failureErrorWithLog (C:\Users\Yone\Desktop\react-controlasistencia-uadec\node_modules\esbuild\lib\main.js:1566:15)
at C:\Users\Yone\Desktop\react-controlasistencia-uadec\node_modules\esbuild\lib\main.js:1024:28
at runOnEndCallbacks (C:\Users\Yone\Desktop\react-controlasistencia-uadec\node_modules\esbuild\lib\main.js:1438:61)
at buildResponseToResult (C:\Users\Yone\Desktop\react-controlasistencia-uadec\node_modules\esbuild\lib\main.js:1022:7)
at C:\Users\Yone\Desktop\react-controlasistencia-uadec\node_modules\esbuild\lib\main.js:1134:14
at responseCallbacks. (C:\Users\Yone\Desktop\react-controlasistencia-uadec\node_modules\esbuild\lib\main.js:671:9)
at handleIncomingPacket (C:\Users\Yone\Desktop\react-controlasistencia-uadec\node_modules\esbuild\lib\main.js:726:9)    at Socket.readFromStdout (C:\Users\Yone\Desktop\react-controlasistencia-uadec\node_modules\esbuild\lib\main.js:647:7)

Any resolution to this error?


README: Why to prefer dev build, how to switch

It should be stated what build is used by default and provide a justification for it. A newcomer would be likely confused by why we use dev build in production, so I have copied the justification from #50 and referred to it regarding info about how to switch. I suppose this is going to evolve but we should document the current status.

Love it, thanks!

Along those lines, I am confused.
The production version seems to me that it effectively leaves objects immutable, which invalidates the concept of this library.  I understand that the production version is useful when performance is a problem, but from what I can tell it stops delivering making objects immutable.
I could be missing something fundamental.

@InsomniacFury Correct - the production build does not make objects immutable.
The idea is that in development you will have used the immutable guarantees to end up with code that does not mutate anything, and by the time you reach production, the guarantees are implicit by the code you've written, and no longer need to be enforced.
If you want stronger guarantees in production, there's absolutely no reason you can't keep using the dev build. In fact, when the library was first released, the dev build was all there was! :smiley:

@rtfeldman thanks for the response.  That makes sense. I saw that in the docs Safari was called out as having a slow Object.freeze().   Is there any other performance implications that has lead to the production version not actually enforcing the immutability.

@InsomniacFury Just that it does extra work on instantiation - namely freezing and banning methods.


checkSession session_state with code flow and no silent refresh

The issue I have found was with the oidc session management (checkSession) in case of code flow without silent refresh.
When the OP iframe responds with changed, a refresh token is used to get a new set of tokens, in case of error a logout is initiated. However I cannot find in the code where on successfull token refresh, we get the new session_state from OP (as far as the spec this is only received through an auth request, not a req to the token endpoint). This is listed in the oidc spec, that on changed a new id token is recieved together with a new session_state.

I'm not sure if I entirely follow your post. There might also be a small language barrier at play? Perhaps you could clarify a bit more, and perhaps also add a "minimal sample" that demonstrates the situation you're running into? That should help the community help you further. (Mind you, the community is spread thin here on GitHub, there are not too many people answering questions.)
PS. It might also help to check some related issues? Perhaps one of them describes your situation as well?

The below code is in the oauth-service.ts file. This method is fired during OpenID Connect Session Management, when the OP responds with a session changed postMessage.
  protected handleSessionChange(): void {
    this.eventsSubject.next(new OAuthInfoEvent('session_changed'));
    this.stopSessionCheckTimer();

    if (!this.useSilentRefresh && this.responseType === 'code') {
      this.refreshToken()
        .then((_) => {
          this.debug('token refresh after session change worked');
        })
        .catch((_) => {
          this.debug('token refresh did not work after session changed');
          this.eventsSubject.next(new OAuthInfoEvent('session_terminated'));
          this.logOut(true);
        });
    } else if (this.silentRefreshRedirectUri) {
      this.silentRefresh().catch((_) =>
        this.debug('silent refresh failed after session changed')
      );
      this.waitForSilentRefreshAfterSessionChange();
    } else {
      this.eventsSubject.next(new OAuthInfoEvent('session_terminated'));
      this.logOut(true);
    }
  }

when refreshToken() is called it will get new tokens from the OP, however it will not get a new session_state parameter, as this can only be returned in an authorize request, not a token request according to OpenID spec. My question is, how is the session_state supposed to be updated in this scenario?
Below is from oidc spec:

When the RP detects a session state change, it SHOULD first try a prompt=none request within an iframe to obtain a new ID Token and session state, sending the old ID Token as the id_token_hint. If the RP receives an ID token for the same End-User, it SHOULD simply update the value of the session state. If it does not receive an ID token or receives an ID token for another End-User, then it needs to handle this case as a logout for the original End-User. If the original End-User is already logged out at the RP when the state changes indicate that End-User should be logged out, the logout is considered to have succeeded.

Reference: OpenID Connect Session Management section 3.1

Thanks for the clarification! I.... actually don't know the answer to your question. I (or someone from the community, or you yourself) would need to investigate what the answer is. I'll update the labels accordingly!


use upstream information directly

Reviewers (team AND community) are now all listed in https://github.com/conan-io/conan-center-index/blob/master/.c3i/reviewers.yml
Also, the number of reviews required before merge is in https://github.com/conan-io/conan-center-index/blob/master/.c3i/c3i.yml tasks->automatic_merge

Looking into this for an afternoon project, I noted YAML is not in the Golang encoding package... and parsing a large struct for a few fields seems to be problematic for most libraries...
Stumbled on this https://stackoverflow.com/questions/40737122/convert-yaml-to-json-without-struct which seems like it could be used to get the one item
The second one is "easy" but not trivial 🤞
To Do List

[ ] Pick a YAML library
[ ] struct defintion for reviewers
[ ] update matching

I don't know go (at all), but a quick search directs me to https://github.com/go-yaml/yaml