Time serialization can silently drop timezone

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
Originally reported at https://github.com/pydantic/speedate/issues/62
If a time has a tzinfo with a non-trivial offset with e.g. depends on dst, then we can erroneously drop it.
We should almost certainly not do this. I think our best options are either to serialise the timezone name (hard but powerful) or to error (correct but frustrating for users).
A third option would be to assume today and caclulate DST offset based on that, but I think that's also bad tbh.
Example Code
from pydantic import TypeAdapter
from datetime import time
from zoneinfo import ZoneInfo

TypeAdapter(time).dump_json(time(12, 4, 5, 123456, tzinfo=ZoneInfo("America/Fortaleza")))
#> b'"12:04:05.123456"'

Python, Pydantic & OS Version
pydantic version: 2.8.0a1
        pydantic-core version: 2.18.3
          pydantic-core build: profile=debug pgo=false
                 install path: /Users/david/Dev/pydantic/pydantic/pydantic
               python version: 3.12.3 (main, May  8 2024, 09:46:04) [Clang 15.0.0 (clang-15<IP_ADDRESS>)]
                     platform: macOS-14.4.1-arm64-arm-64bit
             related packages: mypy-1.10.0 typing_extensions-4.12.1 pyright-1.1.360
                       commit: c6e8bcf1

Thanks @davidhewitt, I've added this to the v2.8.0 milestone!

Initial Checks

[x]  I confirm that I'm using Pydantic V2

Description
Originally reported at pydantic/speedate#62
If a time has a tzinfo with a non-trivial offset with e.g. depends on dst, then we can erroneously drop it.
We should almost certainly not do this. I think our best options are either to serialise the timezone name (hard but powerful) or to error (correct but frustrating for users).
A third option would be to assume today and caclulate DST offset based on that, but I think that's also bad tbh.
Example Code
from pydantic import TypeAdapter
from datetime import time
from zoneinfo import ZoneInfo

TypeAdapter(time).dump_json(time(12, 4, 5, 123456, tzinfo=ZoneInfo("America/Fortaleza")))
#> b'"12:04:05.123456"'

Python, Pydantic & OS Version
pydantic version: 2.8.0a1
        pydantic-core version: 2.18.3
          pydantic-core build: profile=debug pgo=false
                 install path: /Users/david/Dev/pydantic/pydantic/pydantic
               python version: 3.12.3 (main, May  8 2024, 09:46:04) [Clang 15.0.0 (clang-15<IP_ADDRESS>)]
                     platform: macOS-14.4.1-arm64-arm-64bit
             related packages: mypy-1.10.0 typing_extensions-4.12.1 pyright-1.1.360
                       commit: c6e8bcf1

@davidhewitt
i have something little better then option 3 (even i am fine with erroring out or parsing if that will be consistent across time)
lets call option 4
instead using today  in option 3 use  Unix start of time as "today"
i have done it here and it is preaty stable
however for some reason this may still error out for some timezones (probably  tz didn't exist at midnight 1.1.1970)
and i humby ask it to be an requrement (but if imposible drop it)
since calling same code with same data on different  day may get different serialized result (aka tz switches to DST) and that  is probably not wanted by most users

and i humby ask it to be an requrement (but if imposible drop it)
since calling same code with same data on different day may get different serialized result (aka tz switches to DST) and that is > probably not wanted by most users

I fully agree with this; I think we should almost certainly not have validation which behaves differently depending on the actual date! I listed option 3 just for completeness. I agree with your suggestion of using unix epoch if we were to pick a reference point to convert variable timezones to fixed offsets. But I still think that coercion isn't great and it would be better to either fully support IANA timezones or just error when serializing and force users to think about what they want.

Hello!
While migrating one of our FastAPI apps from pydanticv1 to pydanticv2, I noticed that this behavior differs between the two pydantic versions.
With pydanticv1:
>>> pyenv virtualenv 3.9.5 pydanticv1
>>> pyenv activate pydanticv1
>>> pip install 'pydantic<2'
>>> ipython
In [1]: from datetime import datetime, timezone

In [2]: from pydantic import BaseModel

In [3]: class Foo(BaseModel):
   ...:     dt: datetime
   ...:

In [4]: foo = Foo(dt=datetime.now(tz=timezone.utc))

In [5]: foo.json()
Out[5]: '{"dt": "2024-06-17T15:32:31.825334+00:00"}'

With pydanticv2:
>>> pyenv virtualenv 3.9.5 pydanticv2
>>> pyenv activate pydanticv2
>>> pip install 'pydantic>=2'
>>> ipython
In [1]: from datetime import datetime, timezone

In [2]: from pydantic import BaseModel

In [3]: class Foo(BaseModel):
   ...:     dt: datetime
   ...:

In [4]: foo = Foo(dt=datetime.now(tz=timezone.utc))

In [5]: foo.json()  # or foo.model_dump_json()
Out[5]: '{"dt":"2024-06-17T15:33:09.300525Z"}'

@davidhewitt Concerning the second option and serializing the timezone name, do you have any idea of this output?
Maybe the timezone name into brackets like this 12:04:05.123456 [America/Fortaleza] ?

I think what we should do is support RFC 9557.
It looks like the correct thing to do is to serialize the UTC offset as it was at that instant, plus the timezone name if available:
1996-12-19T16:39:57-08:00[America/Los_Angeles]


Add trace integrations

This PR adds the framework integrations for Laravel, Symfony, and Wordpress using the opencensus extension. Also adds support for tracing memcache(d), mysql, PDO, postgres, grpc, and guzzle.

Looks great so far. Let me know when it's ready for another look.

@tmatsuo Should be ready for another look.


Upgrade Pokertracker.app to v4.14.7

Thank you for the contribution. It needed some fixes, so they were made in 02f626fe335c81cb8feffcc071c29cbcc43f2a40. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.


flutter-in-app-purchases#9 (cloud functions) no longer compiles

It seems that this codelab needs to be updated:
https://github.com/flutter/codelabs/tree/main/in_app_purchases
After struggling to resolve firebase-admin and https imports as per this issue I'm now stuck on the following error, that seems to be pointing back to firebase-admin:
Error: Error occurred while parsing your function triggers.

/Users/.../functions/node_modules/firebase-admin/lib/app/firebase-app.js:174
        this.appStore?.removeApp(this.name);
                      ^

SyntaxError: Unexpected token '.'
    at wrapSafe (internal/modules/cjs/loader.js:1052:16)
    at Module._compile (internal/modules/cjs/loader.js:1100:27)
    at Module._compile (pkg/prelude/bootstrap.js:1394:32)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1156:10)
    at Module.load (internal/modules/cjs/loader.js:984:32)
    at Function.Module._load (internal/modules/cjs/loader.js:877:14)
    at Module.require (internal/modules/cjs/loader.js:1024:19)
    at Module.require (pkg/prelude/bootstrap.js:1338:31)
    at require (internal/modules/cjs/helpers.js:72:18)
    at Object.<anonymous> (/Users/.../functions/node_modules/firebase-admin/lib/app/lifecycle.js:25:24)

Node 19.2.0
NPM 9.2.0
package.json:
{
  "name": "functions",
  "scripts": {
    "lint": "eslint --ext .js,.ts .",
    "build": "tsc",
    "watch": "tsc --watch",
    "serve": "firebase emulators:start",
    "shell": "npm run build && firebase functions:shell",
    "start": "npm run shell",
    "deploy": "firebase deploy --only functions",
    "logs": "firebase functions:log"
  },
  "engines": {
    "node": "14"
  },
  "main": "lib/index.js",
  "dependencies": {
    "camelcase-keys": "^8.0.0",
    "firebase-admin": "^11.0.1",
    "firebase-functions": "^4.0.1",
    "google-auth-library": "^8.0.2",
    "googleapis": "^109.0.0",
    "lodash": "^4.17.21",
    "node-apple-receipt-verify": "^1.12.1"
  },
  "devDependencies": {
    "@types/node-apple-receipt-verify": "^1.7.1",
    "@typescript-eslint/eslint-plugin": "^5.27.0",
    "@typescript-eslint/parser": "^5.27.0",
    "eslint": "^8.16.0",
    "eslint-config-google": "^0.14.0",
    "eslint-plugin-import": "^2.26.0",
    "firebase-functions-test": "^3.0.0",
    "typescript": "^4.7.2"
  },
  "private": true
}

Steps to reproduce:

download the repo from complete
try to compile

You can try to fix like described in this article. It worked for me, but now I am stuck with the camelcase-keys package. But it doesn't seem to be related to firebase-admin. So I consider this progress. Good luck.

same issue

@pavel604 did you get any solutions ?

"camelcase-keys": "^8.0.0" in the package.json has to be "camelcase-keys": "^6.2.2"
I changed the original file as described here:  and it worked.  See:

Yes, my solution is I switched my backend to .Net Core + MySQL. It's free and simple, and I can test everything locally before deploying to the server.
If you don't use Node on regular basis - I suggest that you don't use it at all. I'm not babysitting all these packages. This is a complete chaos 😄

@hpsolver I have downloaded and installed Node from this website a few hours before I deployed the functions, so I assume I use Node 18.12.1 LTS. I hope this helps. As far as I remember I had to install yarn package manager too

Okay thanks @larakreisz

PTAL @miquelbeltran

This will no longer an issue when we move to the Dart implementation: https://github.com/flutter/codelabs/pull/1447

The codelab no longer use cloud functions, we can close this one now.


ADM-452 Data import validation for the cycleTime and classification section

Summary
Data import validation for the cycleTime section
case1 : Compare the key value of the imported data with the name of each object in the response in the board.
（1）When different output values belong to imported data, it indicates that the current column has been deleted.

（2）When the output values before different values belong to the response, it prompts that the current column is a newly added column.

case2：Compare the value values of imported data with fixed columns.
Different values belong to imported data, indicating that the current data does not belong to a fixed column.

Data import validation for the classfication section
Display a warning message when the imported data does not match the targetFields value in the response
After
Data import validation for the cycleTime section
case1:
（1）When different output values belong to imported data, it indicates that the current column has been deleted.

（2）When the output values before different values belong to the response, it prompts that the current column is a newly added column.

case2:
Different values belong to imported data, indicating that the current data does not belong to a fixed column.

Data import validation for the classfication section

Need change with the comments


texlive: Refactors toward working texdoc

The main thing to notice is that texlive is now a package scope. Inside it, texlivePackages contains what was previously lexically-scoped local tl, and the previous interface is provided for compatibility. Evaluations are not slower from the minor testing I did, and may be slightly faster. Please review commit-by-commit.
lib.makeScope' now appears, with the interface of lib.makeScopeWithSplicing but the (non-deprecated) functionality of lib.makeScope, so that the texlive scope may be forwards-compatible with lib.makeScopeWithSplicing.
buildenv now passes through preferLocalBuild and allowSubstitutes so that buildTexliveCombinedEnv doesn't invoke .overrideAttrs to achieve that effect.
I'm not sure about names, so feedback is really appreciated there. I tried to keep callPackage in the child scope unambiguous.
Motivation for this change
While investigating solutions for #118757, working with TeX Live in Nixpkgs was a pain. It's now less of a pain, but still needs work in my opinion to have nice separation between TeX Live, CTAN, and the combination machinery. Something simple like overriding texliveBin works without gymnastics, and changes to helper functions can be experimented with without copying & pasting whole files, closer to the flexibility Nixpkgs provides for Python.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
(No diff detected, stopping review...)
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

This change is

nix-build -A tests.texlive runs without error.

ofborg-eval results in:
nix-env did not evaluate cleanly:
 ["trace: warning: Obsolete attribute `bin\' is used. It was renamed to `texliveBin\'."]

I can't find any package that using bin, so I presume this is from evaluating all of texlive's attributes? I'm not sure what a proper fix for this is. Should lib.warn not be used on bin? (The warning was based on lib.modules.mkRenamedOptionModule.)

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/texdoc-cannot-find-texlive-tlpdb/9303/2

If I understand correctly, texdoc is not yet working even with this PR?


Update GCE and Rackspace default image to Ubuntu 16.04

The default image in GCE driver and Rackspace are still 15.10, which is already EOL, and not available in Rackspace. So just update it to 16.04.
Signed-off-by: Tao Wang<EMAIL_ADDRESS>

Awesome, thanks.
Needs a rebase though.

@nathanleclaire Sure, rebased now.

Thanks!
LGTM


[ux issue] fix "malicious" software warning by using a registered developer account signature for macOS dist

on macOS any application that lacking a signature from a registered developer account will cause macOS to display a "malicious" software warning.
This is super easy to avoid, all you have to do is export the application for "Ad-Hoc" installation and allow Xcode to sign the application using the registered developer account that matches the one to which the application bundle ID is registered.
Here is a very easy walk through and info on non-App Store macOS app dist: https://www.appcoda.com/distribute-macos-apps/

I see this is addressed in the README, however, you can still resolve this by signing the application for macOS.
Here is a Gist demonstrating the process, which you could fully automate: https://gist.github.com/txoof/0636835d3cc65245c6288b2374799c43

Thank you for your advice. Signing the app is easy, but the point is, I don't wan to pay $99/yr to apple for just one non app store opensource app. I will consider buying a develop account if I make more macOS apps in the future.
BTW, although my original intention was to make a macOS app, the current number of windows users are about ten times the number of macOS users. And a microsoft developer account is only $20 for lifetime.😂


hexl failed microsoft seal

the new version 3.7.1 mircosoft seal failed to work with hexl 1.2.2
seal issue 411

ok, it's said to be fixed in pull request #90 4 days ago but nobody informed me here which makes me look stupid.

@lidh15, apologies for the oversight.


Remove unnecessary config line

I'm pretty sure this is a mistake so removing it.

Ah I see yes there is a typo. However, the task_2 key should be there so the config matches the example in the screenshot. [custom_operators.png](..%2F..%2FDesktop%2Fcustom_operators.png) should not. It should be:
    task_2:
      operator: airflow.operators.bash_operator.BashOperator
      bash_command: "echo 2"
      dependencies: [ task_1 ]

We can either reopen the PR and re-add the task_2 key, or remove the rest of the task_2 config and update the screenshot.

Went with the former as it was easier


Decide on Equinix metro for cluster and identify carbon intensity for this location

For #3 we are manually creating an Equinix cluster in their Paris metro (their name for region). This was selected because France has a low average carbon intensity.
Here is the full list of metros.
https://deploy.equinix.com/developers/docs/metal/locations/metros/
We should decide if we're happy with this location or wish to use another?
For calculating the SCI score we need to know the carbon intensity at the location where the cluster is hosted.
https://github.com/Green-Software-Foundation/sci/blob/main/Software_Carbon_Intensity/Software_Carbon_Intensity_Specification.md#location-based-marginal-carbon-intensity
Where do we get the carbon intensity value from?
How often should we update the carbon intensity value?
Using a dynamic value may make it harder to compare between SCI scores.

FYI @nikimanoledaki

cc @vielmetti

Thanks @leonardpahlke - I will consult with our sustainability folks and look for an overall recommendation. We generally have best availability for sponsored project activity in EU in our AM (Amsterdam) metro.
There look to be some data center level sustainability metrics not captured in the document you share, most notably PUE ("Power Utilization Effectiveness") which tracks the efficiency not only of the energy used by the equipment directly but also the efficiency of the cooling used to run it. We track this closely because cooling improvements can make for a better data center even if you don't change any of the compute elements.
Can you review

https://sustainability.equinix.com/environment/operational-sustainability/
https://sustainability.equinix.com/environment/climate-commitments-and-carbon-emissions/

and see which if any of the metrics and answers and questions spelled out there give you any of the answers you need? Note that some of the breakdowns are by region and not by data center.

I will consult with our sustainability folks and look for an overall recommendation. We generally have best availability for sponsored project activity in EU in our AM (Amsterdam) metro.

@vielmetti It would be great to get a recommendation on which EU metro to use. From the docs you posted, in EMEA you purchase 100% renewable energy and have lower emissions than Americas or APAC. So EU suits us well.
A side note but living in Catalonia which has a drought state of emergency I appreciate your focus on water usage as well as carbon!
Moving from Paris to Amsterdam is a simple code change but will involve rebuilding the cluster. So I'd prefer to do it sooner than later.
@JacobValdemar I agree France is not representative and I think Netherlands would be fine as an alternative to Ireland.

For the carbon intensity of the electricity I would recommend to use a static (average for 1 year) location-based carbon intensity

Yes, I also prefer a static annual figure over a dynamic value such as from WattTime. To allow projects to more easily compare their SCI scores.

Also, beware that the lower the carbon intensity is, the more significant the embodied impact will be relative to the operational impact.

Yes, this is an important aspect and we have #40 for this.
@vielmetti Are you able to provide data for embodied carbon per instance type? Help with this would be much appreciated.
cc @nikimanoledaki

@rossf7
Regarding embodied carbon, I have some questions which I will put here but that probably need to be discussed further.
I'm looking at our https://blog.equinix.com/blog/2023/11/06/how-to-talk-about-sustainability-in-the-data-center-industry/ where we discuss "embodied carbon" in the context of whole-building life cycle analysis (WBLCA). Reasonably speaking you want to not just capture the device itself but also the structure it's housed in. I don't know if the comparable analysis for other cloud providers factors that in or just the device itself.
BOAVITZA https://github.com/Boavizta/boaviztapi has readouts for several of the devices we stock, but not all of them.
Also missing from the analysis of #40 is any kind of understanding of networking and how that affects things. At the very minimum you might want to give a proportional usage for top-of-rack switching, but maybe someone has done a lifecycle analysis at the level of "picojoules per bit" to get data from here to there.


Create a pipline maintainer role

This role allows users to elevate themselves to the role of a CI maintainer without granting unnecessary privileges:

create secrets ( eventually would be replaced by SPI generated content )
modify the 'pipeline' service account : would enable specification of pull secrets.

I plan on using this to associate the robot account credentials with a pipeline for every app studio control plane component.

I may need a follow up PR to be able to 'see' the application-service namespace.


In creating an action be able to make extension *ALL or *ANY or use a pattern when specifying extension

Type: Feature Request
When creating an Action, I would like to be able to specify *ALL or *ANY for the extension type and have the Action work for any source type.
What, also, might be good is if you had a way to specify the beginning of a name and have it pattern match against the name like CRT* would only show actions for Create extenrsions so if put a name pattern of iB* it would only show the iBuild extension. Does the ability to do a pattern match on extension already exist maybe?
I am requesting this because my iBuild tool (www.sourceforge.net/projects/iBuild) works with any source type and I want a user to not have to edit the action for a new source type.
Extension version: 2.8.0
VS Code version: Code 1.87.2 (863d2581ecda6849923a2118d93a088b0745d9d6, 2024-03-08T15:20:17.278Z)
OS version: Windows_NT x64 10.0.22631
Modes:

Hi @alcampin
You can try GLOBAL in place of an extension. Let me know if that works.

Yes that does seem to work. Not sure how it works because it brings up
other extensions. Is there documentation on GLOBAL works?
On Tue, Mar 19, 2024 at 2:42 PM barry @.***> wrote:

Hi @alcampin https://github.com/alcampin
You can try GLOBAL in place of an extension. Let me know if that works.
—
Reply to this email directly, view it on GitHub
https://github.com/codefori/vscode-ibmi/issues/1943#issuecomment-2008183384,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF6AT26DX4HJEYANFJAONKDYZCWMTAVCNFSM6AAAAABE6LUZ7KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBYGE4DGMZYGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

@alcampin no docs really for it. It's a special flag that means this action applies to any member/source no matter the extension.

I still like the idea of a pattern. Something like @P RPG would pick
anything with RPG in name or @P IB* would pick anything starting with IB.
On Tue, Mar 19, 2024, 5:04 PM barry @.***> wrote:

Closed #1943 https://github.com/codefori/vscode-ibmi/issues/1943 as
completed.
—
Reply to this email directly, view it on GitHub
https://github.com/codefori/vscode-ibmi/issues/1943#event-12177488281,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF6AT23P63F2IIHMF34EAKDYZDHBPAVCNFSM6AAAAABE6LUZ7KVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGE3TONBYHAZDQMI
.
You are receiving this because you were mentioned.Message ID:
@.***>


A native isProcessRunning function and use that to query state

... more light-weight than asking for the command line.

Makes checking whether a process is running more lightweight and less error prone. Asking for a cmdline is technically not 100% supported; a running process might have clobbered that memory already.


Rename Field Capabilities

Per discussion in #5200 for 8.0.0 we should resolve a naming issue in FieldCapabilitiesResponse where we now have two concepts of "version". The original Version property should be renamed as DocVersion to distinguish it as a special field type. The VersionField added in 7.11.0 can then be renamed to Version.
This is a breaking change, hence it needs to be completed in master for 8.0.0 only.

Code-gen


[Bug]: ValueError:  ****** Could not load OpenAI embedding model. If you intended to use OpenAI, please check your OPENAI_API_KEY. Original error: No API key found for OpenAI. Please set either the OPENAI_API_KEY environment variable or openai.api_key prior to initialization. API keys can be found or created at https://platform.openai.com/account/api-keys  Consider using embed_model='local'. Visit our documentation for more embedding options: https://docs.llamaindex.ai/en/stable/module_guides/models/embeddings.html#modules ******

Bug Description
ValueError                                Traceback (most recent call last)
/usr/local/lib/python3.10/dist-packages/llama_index/core/embeddings/utils.py in resolve_embed_model(embed_model, callback_manager)
58             embed_model = OpenAIEmbedding()
---> 59             validate_openai_api_key(embed_model.api_key)
60         except ImportError:
6 frames
ValueError: No API key found for OpenAI.
Please set either the OPENAI_API_KEY environment variable or openai.api_key prior to initialization.
API keys can be found or created at https://platform.openai.com/account/api-keys
During handling of the above exception, another exception occurred:
ValueError                                Traceback (most recent call last)
/usr/local/lib/python3.10/dist-packages/llama_index/core/embeddings/utils.py in resolve_embed_model(embed_model, callback_manager)
64             )
65         except ValueError as e:
---> 66             raise ValueError(
67                 "\n******\n"
68                 "Could not load OpenAI embedding model. "
ValueError:

Could not load OpenAI embedding model. If you intended to use OpenAI, please check your OPENAI_API_KEY.
Original error:
No API key found for OpenAI.
Please set either the OPENAI_API_KEY environment variable or openai.api_key prior to initialization.
API keys can be found or created at https://platform.openai.com/account/api-keys
Consider using embed_model='local'.
Visit our documentation for more embedding options:
Version
0.10.18
Steps to Reproduce
from llama_index.core import VectorStoreIndex, download_loader
from pathlib import Path
Relevant Logs/Tracbacks
No response

I'm using fine tuned Huggingface LLM instead of Openai. What is the solution above error in this situation?

@sandu345 Did you find any solution for this issue?


Feature/model too many joins

This is a:

[ ] bug fix PR with no breaking changes
[x] new functionality

Link to Issue
Closes #394
Description & motivation
Per the dbt best practices docs, models should bring together a reasonable number (typically 4 to 6) of entities or concepts (staging models, or perhaps other intermediate models) that will be joined with another similarly purposed intermediate model to generate a mart. Having too many models in our mart increases the complexity. We can join two intermediate models that each house a piece of the complexity, giving us increased readability, flexibility, testing surface area, and insight into our components.
This new model, fct_number_of_joins, will identify models that join from seven (7) or more other models and should be refactored into intermediate models each taking some of the joins.
Integration Test Screenshot
The equality test for the new fct_number_of_joins model passed in the integration tests.

Screenshot of the fct_number_of_joins model being built:

I updated the documentation to explain the new model. For the screenshots I had two concerns; When I attached the screenshots they are linked to my repository (not sure if that gets automatically updated or if it's something that a dbt maintainer would have to deal with) and the screenshots are from the new Cloud Lineage diagram, so the look and feel is different from the existing screenshots.
Checklist

[x] I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)

[ ] BigQuery
[ ] Postgres
[ ] Redshift
[ ] Snowflake
[ ] Databricks
[x] DuckDB
[ ] Trino/Starburst

[ ] I have updated the README.md (if applicable)
[x] I have added tests & descriptions to my models (and macros if applicable)

The integration tests look like they're failing because, now that I've introduced this new model, some test models, and the associated seed, it is failing on some other equality tests. I assume I need to update the contents of those seed files to include what I've added.
Is that the correct approach?

Yes, this is a bit annoying, but we need to update a couple of seed files when adding new models in the integration_tests folder. So, please, feel free to update the seeds for the tests that started failing.
This doesn't happen every day so we kept it like this for now, but we know that it is not fun to do 😄

Hey! How would you feel about naming the model fct_too_many_joins or something similar so that the model name describes the problem being flagged?

@b-per Thanks for clarifying, I'll align all the seeds so the equality tests no longer fail. I think I saw a couple discrepancies that weren't just about my new model (when I tested locally in VSCode) so I'll double-check for those as well.
@graciegoheen That's a good suggestion. Now that you mention it, I'm not sure why I didn't name the model that to begin with, seeing as I named both the branch and the PR "too many joins".

Renamed the model from fct_number_of_joins to fct_too_many_joins. Next I'll work on updating the seeds for the integration test.

@b-per @graciegoheen
I've updated the seeds where I saw differences, but two of the tests that are failing on the integration tests here on this PR, equality_fct_undocumented_models and equality_fct_documentation_coverage, both pass when I run them locally:

I'm not sure how to get past this point.

Thanks @BradCr , we will have a look at the CI side

OK, so the tests are also failing for me locally, this is not just CI.
Can you do a dbt build -f (to full refresh the seeds as well) in your integration_tests folder and check if it all works for you locally?
I am thinking that in your screenshots, the tests are passing but it is because the data they use has not been refreshed from your latest changes in the seeds files.

Thanks for checking into it. I'l do the full rebuild and then run the tests again.

@b-per I ran dbt build -f in the integration_tests folder, and I still see the same thing. On my local those two equality tests are passing, but failing on the circleci check. I then even deleted the duckdb file and ran the full build again so it would recreate all the tables from scratch, and still those two tests are passing on my local.
When I run the compile SQL for those two tests on the duckdb database they pass, When I query the fct_ and test_fct_ tables individually, the values in the rows are equal.
However, I do see that there are some other tests failing on my local that I'll need to look at, so I will try to sort those out in the meatime:
23:56:14  Failure in test equality_fct_source_directories (seeds\structure\structure_seeds.yml)
23:56:14  Failure in test equality_fct_test_directories (seeds\structure\structure_seeds.yml)
23:56:14  Failure in test equality_fct_chained_views_dependencies (seeds\performance\performance_seeds.yml)
23:56:14  Failure in test equality_fct_model_directories (seeds\structure\structure_seeds.yml)
23:56:14  Failure in test equality_fct_model_fanout (seeds\dag\dag_seeds.yml)
23:56:14  Failure in test equality_fct_rejoining_of_upstream_concepts (seeds\dag\dag_seeds.yml)
23:56:14  Failure in test equality_fct_test_coverage (seeds\tests\tests_seeds.yml)

It is not super easy to get the resulting duckdb database from the CI, and the logs won't give you much info.
But here is the diff for the 2 tests you mentioned when I run them locally
fct_documentation_coverage:

which_diff
total_models
documented_models
documentation_coverage_pct
staging_documentation_coverage_pct
intermediate_documentation_coverage_pct
marts_documentation_coverage_pct
other_documentation_coverage_pct

a_minus_b
19
4
21.05
20
0
0
75

b_minus_a
16
4
25
20
0
0
75

fct_undocumented_models:

which_diff
resource_name
model_type

a_minus_b
int_model_10
intermediate

a_minus_b
int_model_11
intermediate

a_minus_b
base_model_10
base

@b-per I updated my seeds test_fct_docuimentation_coverage and test_fct_undocumented_models to match the values you showed, then committed those changes. The tests on those models now pass on circleci (but fail on my local). Next it's failing in circleci on the test_fct_chained_views_dependencies test, even though that one passes on my local.
Since it fails fast and doesn't uncover all the errors, I'm worried that it's going to give me one or two errors every time it runs, I'll get your help on what the values are, fix the seed, and then it will give me the next errors and that this process could take a while, especially since I'm not getting the same failures locally.
Any thoughts on what I could do to speed that up? Did I do something to mess up my setup/installation, should I start over with a new branch and add my changes back in? I hate that I'm requiring so much hand-holding here, but I appreciate the help you've given me very much.

We can help getting the test to pass, but, yes, it will be useful to understand why things are different locally for you 😄

Could you do a pip list and share it here? I am especially interested in the versions of dbt-core, dbt-duckdb and duckdb itself. I am thinking that some of the changes might be related to some older DuckDB version
Could you share the config of your DuckDB connection in profiles.yml?
And/Or, could you find me on the dbt community Slack and share with me the DuckDB database file that you get after a dbt run --full-refresh? I can then try to figure out why things are different.

OK, so I spent a bit of time looking at the test results that need to be change but unfortunately, the new model under integration_tests requires changing the majority of the existing tests that we have.
For example, with the new model, there is now no violation of fct_rejoining_of_upstream_concepts anymore.
We should try to get your local version working but I am thinking that the test might need to be updated as well.
I am thinking that we might want to make the number of joins a variable, that defaults to 7, but that we could change to 3 in our integration_tests folder. Otherwise, it will impact way too many other models. (and I also think that people might want to configure themselves a number different from 7)

Also, one of the seeds is the following:
resource_name,resource_type,file_path,join_count
fct_model_10,model,"models\\marts\\fct_model_10.sql",7

This is not going to work with CI as it runs on Linux and the file separator is the Windows one. We should just maybe remove checking that specific column.
This makes me think that some of the discrepancies you see when running locally might be due to you running on Windows when CI runs on Linux and we run those on MacOS at dbt Labs

Thank you for all the suggestions. Here is a list of what I've done and the info you asked for. I did the dbt run --full-refresh and then uploaded the duckdb database to my Google drive. I've messaged that link to you on Slack.
I changed the threshold for fct_too_many_joins to be a variable, defaulted to 7 in the main dbt_project.yml, and to 3 in the integration_tests.
I corrected the test_fct_too_many_joins.csv seed to use forward slashes (I had originally changed it to double-backslash because that's what my build put into the model in the duckdb.)
Contents of pip list, with dbt-code, dbt-duckdb, and duckdb at the top:
Package                   Version

dbt-core                  1.7.5
dbt-duckdb                1.7.1
duckdb                    0.9.2
agate                     1.7.1
annotated-types           0.6.0
attrs                     23.2.0
Babel                     2.14.0
certifi                   2023.11.17
cffi                      1.16.0
charset-normalizer        3.3.2
click                     8.1.7
colorama                  0.4.6
dbt-extractor             0.5.1
dbt-semantic-interfaces   0.4.3
idna                      3.6
importlib-metadata        6.11.0
isodate                   0.6.1
Jinja2                    3.1.3
jsonschema                4.21.0
jsonschema-specifications 2023.12.1
leather                   0.3.4
Logbook                   1.5.3
MarkupSafe                2.1.3
mashumaro                 3.11
minimal-snowplow-tracker  0.0.2
more-itertools            10.2.0
msgpack                   1.0.7
networkx                  3.2.1
packaging                 23.2
parsedatetime             2.6
pathspec                  0.11.2
pip                       23.3.2
protobuf                  4.25.2
pycparser                 2.21
pydantic                  2.5.3
pydantic_core             2.14.6
python-dateutil           2.8.2
python-slugify            8.0.1
pytimeparse               1.1.8
pytz                      2023.3.post1
PyYAML                    6.0.1
referencing               0.32.1
requests                  2.31.0
rpds-py                   0.17.1
setuptools                65.5.0
six                       1.16.0
sqlparse                  0.4.4
text-unidecode            1.3
typing_extensions         4.9.0
urllib3                   1.26.18
zipp                      3.17.0
Duckdb profiles.yml:
integration_tests:
  target: duckdb
  outputs:
    duckdb:
      type: duckdb
      path: '/Users/bcron/python/duckdb/dbt_integration_tests.duckdb'

The fact that I haven't gotten the integration tests to pass is bugging me, so I decided to try something. I created a new branch in my repository to try and get a good, clean baseline test before making any changes. I installed the dbt-duckdb package, ran dbt deps in the root directory and in integration_tests, then ran dbt build -f in root and in integration_tests.
Without any modifications to any models or seeds, I am getting errors on 10 tests. I was able to resolve or explain all but one. Is it possible that some integration_tests seeds in main aren't up to date and need corrections in order to work? It looks like there have been other recent PRs that passed circleci tests just fine, so I've got to assume the issue is on my end, but then I don't understand why it would throw me errors on a new clone.

These three have the single forward slash vs. double backward slash issue, but models and paths are the same, so I imagine they would pass circleci just fine if I leave the seeds alone:

equality_fct_source_directories
equality_fct_model_directories
equality_fct_test_directories

These tests had additional rows in the table that weren't in the seed. When I added those rows to the seeds, the tests pass just fine:

equality_fct_undocumented_models
equality_fct_chained_views_dependencies
equality_fct_model_fanout
equality_fct_root_models
equality_fct_missing_primary_key_tests

This covergae test had different values in the seed vs. the table build by the model. When I changed the values in the seed, the test passes just fine:

equality_fct_documentation_coverage

This covergae test had different values in the seed vs. the table built by the model. When I changed the values in the seed, there is still a weird error:

equality_fct_test_coverage

After updating the test_fct_test_coverage seed, the equality_fct_test_coverage still fails. Here's where it gets interesting. The output of equality_test_fct_test_coverage.sql looks like this:

which_diff
total_models
total_tests
tested_models
test_coverage_pct
test_to_model_ratio
staging_test_coverage_pct
intermediate_test_coverage_pct
marts_test_coverage_pct
other_test_coverage_pct

a_minus_b
18
13
6
33.33000183105469
0.7222
80.0
25.0
0.0
25.0

b_minus_a
18
13
6
33.33
0.7222
80.0
25.0
0.0
25.0

Notice the test_coverage_pct from a_minus_b is showing in this query with 15 decimal places, rather than 2. But when I select * from  each table test_fct_test_coverage and fct_test_coverage independently, both of them show 33.33 as the value. Not sure what's happening here, but perhaps the circleci test would pass?

We saw the same rounding issue here https://github.com/dbt-labs/dbt-project-evaluator/pull/427#issuecomment-1941555822

We saw the same rounding issue here #427 (comment)

Good to know it wasn't just me.

I saw there were a couple of PRs merged and my branch was out of date. I synched my branch, and it now fails the CircleCI tests. It was passing previously.

@BradCr thanks so much for the contribution! sorry this took so long!

@dave-connors-3 No problem, Dave. This was such a fun experience. I'm looking forward to contributing again.
Thank you also @b-per and @graciegoheen for all the help and guidance!


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_3e26683d-274f-4ef4-823d-d922a8f3a419/pull/1 is merged into live branch.
Auto archive content to https://github.com/VSC-Service-Account/docs-archive-test-target_3e26683d-274f-4ef4-823d-d922a8f3a419.git

Docs Build status updates of commit 8a9e234:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-ServiceAccountCannotAccessRepository] Your repository https://github.com/VSC-Service-Account/docs-archive-test-source has enabled Docs Build service account. It seems that at least one of the accounts, e2ebd2, does not have Read permission to the repo. Please ask your repo admin to grant correct permission to service accounts (refer to this document: https://review.docs.microsoft.com/en-us/engineering/projects/ops/engdocs/how-to-grant-service-account-permission-in-your-repository?branch=master#ops-e2e-ppe) and then retry the build. Don't know who to contact? Refer https://repos.opensource.microsoft.com/VSC-Service-Account/repos/docs-archive-test-source/permissions/ to get admin list of the repo if the repo is in one of the organizations Microsoft owns.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Add Distributed Systems course

I have found MIT's 6.824 course on Distributed Systems  https://pdos.csail.mit.edu/6.824/ to be a very high quality unique resource for learning about distributed systems.  Distributed Systems is a Knowledge Area in 2013CS guidelines so perhaps this should be included under the Advanced section, although I'm not quite sure where since the Systems section is currently focused on low level systems.

@atkinew0
Have you seen this issue: https://github.com/ossu/computer-science/issues/721 ? I'm curious about your thoughts after reading through that thread.

As it's been 2 weeks without a response, closing this issue. Please feel free to reopen if you have more to add.

Sorry I missed your message. I can add to the discussion in #721 that I am just over halfway through the course and I have found it a very valuable learning experience.
I have no particular distributed systems background, and keeping in mind it is a graduate level course, the homework assignments are difficult but doable. This is not one of those online courses that lead to frustration because the autograder/assignment instructors/ or whatever are confusing or out of date. In fact there is a lot of very helpful handholding with regards to the design and implementation on the labs. On the other hand I tried the old C++ assignments from the 2013 version and those homework assignments are much more obscure without having seen the relevant lectures.


Add waitForMouseup option to useFocusWithin to evade flashing

Both CSS's :focus-within and the useFocusWithin hook will temporarily declare a "blur" when clicking on an input label of some other control within the container. This leads to the flashing of focused styles for that brief moment. While one might evade this problem by adding tabIndex={-1} to the label element, it still doesn't cover all the other holes, for example, clicking on something leading to a programmatic focus of controls.
One solution (the one we use), is to wait between mousedown and mouseup events. Mousedown will retain the pseudo focus-within state until mouseup, and when the latter event triggers, we just check if document.activeElement is still owned by the subject container. If so, the focus-within continues to be true, and is declared as false otherwise.

Can you provide an example of this behavior via something like a sandbox?

Can you provide an example of this behavior via something like a sandbox?

If needed, please reopen with example code.


🎉Announcement: Internationalization for OHIF Viewer

Quick note! If you use or find this repository helpful, please take the time to star it. It helps us show community adoption and obtain the required funding to keep the project going.

We have recently integrated i18next into the OHIF Viewer and hooked it up with Locize for translation management. Now we need your help to get the app translated into as many languages as possible, and ensure that we haven't missed pieces of the app that need translation. Locize has graciously offered to provide us with free usage of their product.
Once each crowd-sourcing project is completed, I can approve it and merge the changes into the main project. At that point, the language will be immediately available on https://viewer.ohif.org/ for testing, and can be used in any OHIF project. We will support usage through both the Locize CDN and by copying the language directly into the @ohif/i18n package, so that end users can serve the content from their own domains.
Here are a couple examples:
Spanish:
https://viewer.ohif.org/viewer/1.2.840.1136<IP_ADDRESS>2583153.215519.978957063.78?lng=es
Chinese:
https://viewer.ohif.org/viewer/1.2.840.1136<IP_ADDRESS>2583153.215519.978957063.78?lng=zh
Portugese:
https://viewer.ohif.org/viewer/1.2.840.1136<IP_ADDRESS>2583153.215519.978957063.78?lng=pt-BR
Here are some links you can use to sign up to help translate. All you have to do is sign up, translate the strings, and click Save. On our side, we have a dashboard to see how many strings are translated and by whom.
This is a pretty random set of languages, so please post below if you'd like a new language link to be added:
Languages:

French
German
Dutch
Turkish
Chinese
Japanese
Arabic
Hindi
Malay
Russian
Swedish
Italian
Spanish
Ukrainian
Vietnamese
Portugese-Brazil

Soon we will add a Language Selector in the UI to make it more clear how users can switch languages. For now you have to use ?lng=es in the URL. To get back to English, use ?lng=en.
Thanks! Looking forward to seeing which languages get completed first.

Can you post the spanish invitation to Locize?. I want to do little corrections in those files.

Sure, added it above!

@christianvargasforero - Looks like you contributed to the Italian translation, but these words look like they are Spanish to me. Did you click the wrong link?

@christianvargasforero - Looks like you contributed to the Italian translation, but these words look like they are Spanish to me. Did you click the wrong link?

mmm if it was a mistake that I made, without wanting to make the translation into Spanish I did it in Italian by mistake, but I left that project.

I already did the spanish translation on locize. @christianvargasforero
https://github.com/christianvargasforero maybe you can check if that
translation is correct.
El lun., 8 jul. 2019 a las 11:39, Christian Vargas (<
<EMAIL_ADDRESS>escribió:

@christianvargasforero https://github.com/christianvargasforero - Looks
like you contributed to the Italian translation, but these words look like
they are Spanish to me. Did you click the wrong link?
mmm if it was a mistake that I made, without wanting to make the
translation into Spanish I did it in Italian by mistake, but I left that
project.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/OHIF/Viewers/issues/618?email_source=notifications&email_token=AAJ5JMHO25CZXQS77DNGNYTP6NNUNA5CNFSM4H4ZYWU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZNPPAY#issuecomment-509278083,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJ5JMFAYCY76QBVJKQBDOTP6NNUNANCNFSM4H4ZYWUQ
.

--
Juan Fco. Del Solar M.

I already did the spanish translation on locize. @christianvargasforero https://github.com/christianvargasforero maybe you can check if that translation is correct. El lun., 8 jul. 2019 a las 11:39, Christian Vargas (<<EMAIL_ADDRESS>escribió:
…
@christianvargasforero https://github.com/christianvargasforero - Looks like you contributed to the Italian translation, but these words look like they are Spanish to me. Did you click the wrong link? mmm if it was a mistake that I made, without wanting to make the translation into Spanish I did it in Italian by mistake, but I left that project. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#618?email_source=notifications&email_token=AAJ5JMHO25CZXQS77DNGNYTP6NNUNA5CNFSM4H4ZYWU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZNPPAY#issuecomment-509278083>, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJ5JMFAYCY76QBVJKQBDOTP6NNUNANCNFSM4H4ZYWUQ .
-- Juan Fco. Del Solar M.

ok, perfect.
You have to send me the invitation, or how can I do the review?

Please add a Vietnamese language link

@lam0620 - Added it above!

I would like to contribute to the portuguese language of brazil, could you add the invitation ??

@lucasmazevedo - Added it above!

I already did the Chinese translation on locize，you can check it now. And I want to add a Language Selector in UI, I just need the English and Chinese . How can I do it? Thanks!

Thanks @MarlonLiu1991! I've imported the Chinese translations into the project. It looks like there were a number of new keys added since the original links were posted, though, so I have had to add some more strings for translation (e.g. for the Study List). I've updated the link above (it's also here.
Thanks so much @lam0620 - I've imported your contributions into the main project, and now they are visible online: https://viewer.ohif.org/?lng=vi - Your site will get this automatically if window.config.i18n.USE_LOCIZE=true;. We will update the @ohif/i18n package so that Vietnamese and the latest Chinese translations are also available for cases where the Locize CDN is disabled.

Hi, I have done the other Chinese translation, and changed some translations exist, for I dont't have proper Chinese words for them, there are also some words haven't been translated

By the way, is there a way to switch Chinese an English display? My project need this function, and it is not convenient to add "?lng=en/zh" after the url

The plan is to add a language selection dropdown in the User Preferences modal, but that modal seems to have been removed during @dannyrb's changes to extensions.

@swederik you can create a task to add it back? Biggest issue is around changes needed to support updating hotkeys in new setup. You can simply remove those pages of the modal instead of the modal entirely?

@swederik Thanks for donging this, I can use some simple method by refreshing the page, and it works. But I have a problem now, for example, I changed the "Angle": "角度" to "Angle": "角"  in Button.json, after reloading the page it still display"角度“ rather than "角". In other words, it can't change anything just change the Button.json file, do I need to modify other files or I did it in wrong way?Thanks!

So right now the @ohif/i18n package needs to be rebuilt and the main viewer
needs to use the updated version. It's kind of a pain right now but
@dannyrb is working on improving this so . You can use yarn link or yalc to
link the packages so it's a bit easier.
On Thu., Aug. 1, 2019, 11:25 a.m. MarlonLiu1991<EMAIL_ADDRESS>wrote:

@swederik https://github.com/swederik Thanks for donging this, I can
use some simple method by refreshing the page, and it works. But I have a
problem now, for example, I changed the "Angle": "角度" to "Angle": "角" in
Button.json, after reloading the page it still display"角度“ rather than "角".
In other words, it can't change anything just change the Button.json file,
do I need to modify other files or I did it in wrong way?Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/OHIF/Viewers/issues/618?email_source=notifications&email_token=AAEUMMKVPATWMXX3AU2FNDLQCKTZTA5CNFSM4H4ZYWU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3J6V7Q#issuecomment-517204734,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEUMMJKABR3SBBAHI4V7PDQCKTZTANCNFSM4H4ZYWUQ
.

I corrected some Vietnameses and added Japanese

@swederik Thanks for your reply, but so far I don't know how to implement it in the details. I will correct some words' translation in future on the locize

Thanks @lam0620: https://viewer.ohif.org/viewer/1.2.840.1136<IP_ADDRESS>2583153.215519.978957063.78?lng=ja-JP!

@swederik  I changed some translations of words , but when I rebuild the ohif/i18n package  an error occurred: [!] (json plugin) SyntaxError: Unexpected token  in JSON at position 0
src\locales\zh\Common.json
SyntaxError:
Unexpected token  in JSON at position 0
at JSON.parse ()
at Object.transform (D:\MRI_DISPLAY\OHIF\OHIF_NEW _test\Viewers\extensions\ohif-i18n\node_modules\rollup-plugin-json\src\index.js:14:26)
at Promise.resolve.then (D:\MRI_DISPLAY\OHIF\OHIF_NEW _test\Viewers\extensions\ohif-i18n\node_modules\rollup\dist\rollup.js:15429:25)

This post will remain pinned, but I'm going to close it to take it off our "backlog". We've scoped some documentation tasks to help make consuming/contributing to translations in this issue:
https://github.com/OHIF/Viewers/issues/880

Hello,
Please add a link for Georgian language. I'm willing to translate.


Fix webpack template link in README

Summary
Link is broken
Test plan
Click the link, now it works :D

Hi @poteirard. I've just merged an older PR which was addressing the same issue. Thanks for your contribution, though :)


⚠ Bofrost.at has degraded performance

In 98efe11, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1169 ms

Resolved: Bofrost.at performance has improved in b3dc314 after 6 minutes.


Add schematics

Add schematics for generating component, service and directive with Spectator specs.
The PR would add the following schematics:
ng g spectator-component spec-comp
ng g spectator-component spec-comp-host --withHost=true
ng g spectator-component spec-comp-custom-host --withCustomHost=true
ng g spectator-directive spec-directive
ng g spectator-service spec-service
ng g spectator-service spec-data-service --isDataService=true
Tested in a Nx workspace.

Wow, that's was quick. Looks great. I have two questions:

There is no way to use the default CLI schematics and just replace the spec file?
If not, we should make the command shorter or create an alias. Something like:

ng g cs spec-comp
ng g cs spec-comp-host --withHost=true
ng g cs spec-comp-custom-host --withCustomHost=true
ng g ds spec-directive
ng g dse spec-service
ng g dse spec-data-service --dataService=true

At the moment, the schematics execute default cli and put a Spectator spec file in place, I do not know a way to use the cli command and automatically replace the spec
it can support alias. For service, it should be ng g ss some-service, basically add a s after or before the default alias would be easy to remember.

Great, so add the alias option, please. A couple of things I notice:

You need to update the README file with the commands.
You need to add yourself as a contributor, check the command in package.json.
You need to exclude to the folder from Jest. The tests are failing now. If you need help with that lmk.

Thanks!

Aliases added.
I will try to do the rest.
I am not sure if the schematic would work just like this after installing the lib. It works in my nx workspace but it has a different setup. We will need to look into it if it doesn't work.

I will test it before release. You should also extend the default CLI. https://github.com/datorama/akita-schematics/blob/master/src/collection.json#L2

@NetanelBasal I do need help for excluding the folder from Jest. Please help.
Thanks.

I fixed the tests. I'm testing the code, and there is a problem. The test file isn't in the same folder as the component files.

You can test it by running:
ng add<EMAIL_ADDRESS>ng config cli.defaultCollection @netbasal/spectator ng g cs tabs

I launch the schematic with webstorm build in tools, it gave a path. Looks
like using cli on command line don’t do the same. I will try to fix it.
Netanel Basal<EMAIL_ADDRESS>周日上午7:41写道：

I fixed the tests. I'm testing the code, and there is a problem. The test
file isn't in the same folder as the component files.
[image: image]
https://user-images.githubusercontent.com/6745730/54082059-68eab880-4318-11e9-993c-ee2bf641f93a.png
You can test it by running:
ng add<EMAIL_ADDRESS>ng config cli.defaultCollection
@netbasal/spectator ng g cs tabs
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NetanelBasal/spectator/pull/82#issuecomment-471255254,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKY6h-_O3uCGR0cQJAluW3YPccYpdVAWks5vVLcngaJpZM4blR7S
.

@NetanelBasal I am sorry about the bug. I added a function to ensure the path is valid, essentially the same with Angular Cli. Please try it out. It should put the test file into the same folder.


flutter stable failing to serialize cocoon dependencies

json_serializable is causing an infinite loop:
[SEVERE] json_serializable:json_serializable on bin/yaml_converter.dart:

Bad state: Unexpected diagnostics:
/Users/godofredoc/flutter_checkouts/flutter/bin/cache/dart-sdk/lib/core/int.dart:122:18 - Operator declarations must be preceded by the keyword 'operator'.
/Users/godofredoc/flutter_checkouts/flutter/bin/cache/dart-sdk/lib/core/int.dart:122:16 - Methods must have an explicit list of parameters.
/Users/godofredoc/flutter_checkouts/flutter/bin/cache/dart-sdk/lib/core/int.dart:122:18 - A function body must be provided.
package:analyzer/dart/sdk/build_sdk_summary.dart 212:7   _Builder._parse
package:analyzer/dart/sdk/build_sdk_summary.dart 147:36  _Builder._addLibrary
package:analyzer/dart/sdk/build_sdk_summary.dart 143:9   _Builder._addLibrary
package:analyzer/dart/sdk/build_sdk_summary.dart 143:9   _Builder._addLibrary
package:analyzer/dart/sdk/build_sdk_summary.dart 143:9   _Builder._addLibrary
dart:core                                                List.forEach
package:analyzer/dart/sdk/build_sdk_summary.dart 101:20  _Builder.build
package:analyzer/dart/sdk/build_sdk_summary.dart 75:5    buildSdkSummary
package:build_resolvers/src/resolver.dart 389:36         _defaultSdkSummaryGenerator
package:build_resolvers/src/resolver.dart 327:11         AnalyzerResolvers._ensureInitialized.<fn>
package:build_resolvers/src/resolver.dart 334:5          AnalyzerResolvers.get
package:build                                            _DelayedResolver.isLibrary
package:source_gen/src/builder.dart 75:10                _Builder.build

\cc @christopherfujino @CaseyHillers

Seeing this as well. Promoting to P1 as this is blocking cocoon tree.

I have a PR WIP at https://github.com/flutter/cocoon/pull/1246 - I'm finishing the request handlers today (25 tests left to fix), and I expect to have it reviewed and a prod test today.

Blocked on the cocoon nullsafety migration.

This is blocking https://github.com/flutter/cocoon/pull/1350 from landing and resolving https://github.com/flutter/flutter/issues/90151

Casey has a PR ready and he has been fixing small issues before landing it. If everything goes well we will be landing the fix early next week.
@Piinks is this blocking something that we need to land asap?
@keyonghan will it be possible to land flutter/cocoon#1350 with the failing tests?

Casey has a PR ready and he has been fixing small issues before landing it. If everything goes well we will be landing the fix early next week.
@Piinks is this blocking something that we need to land asap?
@keyonghan will it be possible to land flutter/cocoon#1350 with the failing tests?

per internal chat, @Piinks said she would be ok waiting until Monday for Casey's PR to land.

@keyonghan will it be possible to land flutter/cocoon#1350 with the failing tests?

flutter/cocoon#1350 seems safe to land with failing tests, but I would prefer to wait until the null safety lands.

Any updates on when flutter/cocoon#1350 can land? The golden file testing infra is broken while that change is blocked.

(that bug is blocked on the cocoon null safety migration which is underway)

Any updates on when flutter/cocoon#1350 can land? The golden file testing infra is broken while that change is blocked.

We're aiming to land the migration this week as we're in the middle of doing prod validation tests of it
Some of the difficulty is NNBD surfaced some issues that are in prod that we're now catching versus silently failing


Add missing index_index() when reloading OCSP responder

Also, future-proof index_index() return codes by requiring success to return a positive value.

Without this bug-fix, when the OCSP responder is running in "multi" mode, it ceases to be able to find the status for any certificates after it reloads the index file. This affects only master, as the OCSP changes to implement "multi" mode are not in any stable release.

Pushed. Thanks!


Sort AppService tree nodes alphabetically

Its unclear how the appService applications under the subscriptions are sorted and its confusing as it stands currently.  I expected the applications to be sorted alphabetically but that doesnt seem to be case, they are also not sorted based on the latest updated/create time. So how are they sorted?
It would be great if we could sort them alphabetically as it would be the most straightforward way.

This has been fixed on master and will be included in a release soon (within the next week)


fixmove ReplaceVariableByLiteral rule to analyze phase

consider sql with user defined var @t_zone
set @t_zone='GMT';
SELECT
    DATE_FORMAT(convert_tz(dt, time_zone, @t_zone),'%Y-%m-%d') day
FROM
    t
GROUP BY
    1;

@t_zone must be replaced as 'GMT' before EliminateGroupByConstant and NormalizeAggregate rule. So this pr move ReplaceVariableByLiteral rule from rewrite phase to analyze phase and put it before the two rules to make it work.
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


Change channel from candidate to stable

Signed-off-by: Carlo Lobrano<EMAIL_ADDRESS>

/retest

/lgtm


Replace rounding-error prone floating point code with robust integer code

When this package was uploaded to Debian we noticed test failures on i386.
Debian i386 uses the x87 floating point unit which is known to have slightly different floating point behavior from other architectures due to excess precision in it's floating point registers. However when I made the testsuite more thorough I found rounding errors on amd64 as well.
 ---- test_duration_ymdhms stdout ----
 thread 'test_duration_ymdhms' panicked at 'assertion failed: `(left == right)`
   left: `Ok(YMDHMS { year: 1, month: 2, day: 3, hour: 4, minute: 5, second: 6, millisecond: 700 })`,
  right: `Ok(YMDHMS { year: 1, month: 2, day: 3, hour: 4, minute: 5, second: 6, millisecond: 699 })`', tests/lib.rs:977:5

---- test_millisecond stdout ----
thread 'test_millisecond' panicked at 'assertion failed: `(left == right)`
  left: `Ok(Time { hour: 16, minute: 43, second: 0, millisecond: 120, tz_offset_hours: 0, tz_offset_minutes: 0 })`,
 right: `Ok(Time { hour: 16, minute: 43, second: 0, millisecond: 119, tz_offset_hours: 0, tz_offset_minutes: 0 })`', tests/lib.rs:36:5

The problem is that sometimes when a decimal number is converted to floating point and multiplied by 1000 the result is slightly smaller than expected due to floating point rounding. When the resulting slightly smaller number is rounded towards zero in the conversion to integer the result is a number one smaller than expected.
My fix was to avoid floating point completely and implement the milliseconds parsing using purely slicing and integer math.

Updated per review comments.

Merged as 24a84762ec6430b56ab63ce143b037ecb30d4c7f


Split registry value to allow switching registry

Signed-off-by: Julien Garcia Gonzalez<EMAIL_ADDRESS>Currently we deploy to China with quay registry which is slow.

it's my f*** linter in vscode that mix everything
let me try to avoid this

@ced0ps better?


Add unit tests for add  electrical series II (scaling to volts)

I added tests for the add_electrical_series function in the spikeinterface module. Also, some change in the code of the module itself. Relevant to the discussion here is the discussion in https://github.com/catalystneuro/neuroconv/issues/34.

All the tests are wroking save the ones for CED as the interfaces's recorder has heterogeneous offsets:
https://github.com/catalystneuro/neuroconv/issues/8

All the tests are wroking save the ones for CED as the interfaces's recorder has heterogeneous offsets:

Yep, do you want to fix that here by subsetting only to write the neurophysiology channels? (any that have Rhd in the name as I recall)

All the tests are wroking save the ones for CED as the interfaces's recorder has heterogeneous offsets:

Yep, do you want to fix that here by subsetting only to write the neurophysiology channels? (any that have Rhd in the name as I recall)

@CodyCBakerPhD OK, done in the last commit.


looked through 0 jobs

Hi, I am running dr-elephant-2.0.13 and for some reason there are no jobs being analyzed. There are no errors in the logs either. All I see is this in dr.log
====
$ cat dr.log
OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=512m; support was removed in 8.0
Play server process ID is 50848
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/ngs1/app/e0177431/dr-elephant-2.0.13/lib/ch.qos.logback.logback-classic-1.0.13.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/ngs1/app/e0177431/dr-elephant-2.0.13/lib/org.slf4j.slf4j-simple-1.6.6.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/ngs1/app/e0177431/dr-elephant-2.0.13/lib/org.slf4j.slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/ngs/app/ianp/cloudera/parcels/CDH-5.16.2-1.cdh5.16.2.p0.8/jars/slf4j-log4j12-1.7.5.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [ch.qos.logback.classic.util.ContextSelectorStaticBinder]
[info] play - database [default] connected at jdbc:mysql://<IP_ADDRESS>/drelephant?characterEncoding=UTF-8
[info] application - Starting Application...
[info] play - Application started (Prod)
[info] play - Listening for HTTP on /<IP_ADDRESS>:8080
======
and this in applicaton.log
======
$ cat application.log
2020-07-09 22:36:29,100 - [INFO] - from play in main
database [default] connected at jdbc:mysql://<IP_ADDRESS>/drelephant?characterEncoding=UTF-8

2020-07-09 22:36:29,690 - [INFO] - from application in main
Starting Application...

2020-07-09 22:43:02,484 - [INFO] - from play in main
database [default] connected at jdbc:mysql://<IP_ADDRESS>/drelephant?characterEncoding=UTF-8

2020-07-09 22:43:03,074 - [INFO] - from application in main
Starting Application...

2020-07-09 23:49:15,622 - [INFO] - from play in main
database [default] connected at jdbc:mysql://<IP_ADDRESS>/drelephant?characterEncoding=UTF-8

2020-07-09 23:49:16,206 - [INFO] - from application in main
Starting Application...

2020-07-09 23:51:34,027 - [INFO] - from play in main
database [default] connected at jdbc:mysql://<IP_ADDRESS>/drelephant?characterEncoding=UTF-8

2020-07-09 23:51:34,614 - [INFO] - from application in main
Starting Application...

2020-07-09 23:51:36,103 - [INFO] - from play in main
Application started (Prod)

2020-07-09 23:51:36,192 - [INFO] - from play in main
Listening for HTTP on /<IP_ADDRESS>:8080
====

Also, why have 2 conf dirs?

====
$ ls -l conf/ app-conf/
app-conf/:
total 44
-rw-r--r-- 1 e0177431 aplstaff  1684 Jul  9 21:25 AggregatorConf.xml
-rw-r--r-- 1 e0177431 aplstaff  2439 Jul  9 21:26 AutoTuningConf.xml
-rw-r--r-- 1 e0177431 aplstaff  2373 Jul  9 21:37 elephant.conf
-rw-r--r-- 1 e0177431 aplstaff  4699 Jul  9 21:18 FetcherConf.xml
-rw-r--r-- 1 e0177431 aplstaff  1637 Jul  9 17:17 GeneralConf.xml
-rw-r--r-- 1 e0177431 aplstaff 11322 Jul  9 23:51 HeuristicConf.xml
-rw-r--r-- 1 e0177431 aplstaff  2985 Jul  9 17:17 JobTypeConf.xml
-rw-r--r-- 1 e0177431 aplstaff  3189 Jul  9 21:25 SchedulerConf.xml

conf/:
total 12
-rw-r--r-- 1 e0177431 aplstaff 2446 Jul  9 21:35 application.conf
drwxr-xr-x 3 e0177431 aplstaff 4096 Jul  9 17:17 evolutions
-rw-r--r-- 1 e0177431 aplstaff 1040 Jul  9 21:28 log4j.properties
====

mysql tables look okay too
====
$ mysql -u drelephant -p drelephant -e 'show tables;'
Enter password:
+-----------------------------------+
| Tables_in_drelephant              |
+-----------------------------------+
| flow_definition                   |
| flow_execution                    |
| job_definition                    |
| job_execution                     |
| job_saved_state                   |
| job_suggested_param_value         |
| play_evolutions                   |
| tuning_algorithm                  |
| tuning_job_definition             |
| tuning_job_execution              |
| tuning_parameter                  |
| yarn_app_heuristic_result         |
| yarn_app_heuristic_result_details |
| yarn_app_result                   |
+-----------------------------------+
====
I ran the pi-estimator job from the same host as the same user a couple of times without issues so my hadoop client environment seems fine on this host.

Any pointers on what I might be doing wrong that DrE is not seeing any jobs?

@sukh kindly check the Dr.Elephant's logs which would be available logs/elephant/dr_elephant.log and this logs folder would be available just outside the Dr.Elephant folder(where you found logs/application.log).

@sukh I hope you were able to find the issue and now Dr.Elephant is working fine for you. Since this issue has no activity for more than 20 days so I am closing it, kindly feel free to reopen it in case needed.


Added github icon mapping for gitmodules file

By default we've github icon only for 3 files: .gitignore, .gitkeep,.gitattributes. The .gitmodules file provides sensible default URLs for each submodule, and is committed in the repository like any other versioned file. So I've added this mapping.

Hi @SergeyLitvinov, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@aeschli what are you thinking about taking this contribution in nearest update?

We generate the Seti theme from https://github.com/jesseweed and don't want to create our own fork. Please file your pull request against https://github.com/jesseweed. Once accepted, ping me so I can update our theme.

My PR in Seti repository has been approved and merged: https://github.com/jesseweed/seti-ui/pull/377

I updated the Seti theme.

One more PR in Seti repository has been approved and merged: https://github.com/jesseweed/seti-ui/pull/396. So please update Seti theme then you'll have time ;)


AKS cluster automatically enabled new preview feature and I cant disable the add on

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az aks disable-addons
Errors:
The command failed with an unexpected error. Here is the traceback:
cannot import name 'map_azure_error_to_cli_error' from 'azure.cli.command_modules.acs._helpers' (C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\lib\site-packages\azure\cli\command_modules\acs\_helpers.pyc)
Traceback (most recent call last):
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\knack/cli.py", line 231, in invoke
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/__init__.py", line 556, in execute
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/__init__.py", line 515, in load_arguments
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/__init__.py", line 313, in load_arguments
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\knack/commands.py", line 104, in load_arguments
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/command_operation.py", line 125, in arguments_loader
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/command_operation.py", line 59, in get_op_handler
  File "importlib\__init__.py", line 127, in import_module
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 783, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "C:\Users\anschmidt.NORTHAMERICA\.azure\cliextensions\aks-preview\azext_aks_preview\custom.py", line 105, in <module>
    from ._helpers import (
  File "C:\Users\anschmidt.NORTHAMERICA\.azure\cliextensions\aks-preview\azext_aks_preview\_helpers.py", line 7, in <module>
    from azure.cli.command_modules.acs._helpers import map_azure_error_to_cli_error
ImportError: cannot import name 'map_azure_error_to_cli_error' from 'azure.cli.command_modules.acs._helpers' (C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\lib\site-packages\azure\cli\command_modules\acs\_helpers.pyc)

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az aks disable-addons --addons {} --name {} --resource-group {}

Expected Behavior
Environment Summary
Windows-10-10.0.22621-SP0
Python 3.8.9
Installer: MSI

azure-cli 2.33.1 *

Extensions:
aks-preview 0.5.70

Dependencies:
msal 1.16.0
azure-mgmt-resource 20.0.0

Additional Context

Thank you for opening this issue, we will look into it.

@andrewschmidt-a Can you please try using the Azure CLI latest version if that works for you.


render with multiple template engines (gotpl/jsonnet/...)

Command

[ ] check-image-updates
[ ] delete
[X] deploy
[ ] diff
[ ] helm-pull
[ ] helm-update
[ ] list-images
[ ] list-targets
[ ] poke-images
[ ] prune
[ ] render
[ ] seal
[ ] validate
[ ] version

Who are you?
Petr, 42, SRE engineer
I already wrote an KRM function for Kustomize to do similar https://github.com/epcim/render-gotpl-fn and experimenting with how to process grafana/prometheus jsonnet resources on https://github.com/epcim/render-jsonnet-fn/tree/main/example-exec
However kluctl tooling looks better to get these in my current workflow, than continue in KRM container way (that for the purpose becomes complex and need --networking, mount --bind options etc..)
What do you want to do?
Today kluctl supports to render external HelmChart. However there are some other common input resources, that require some "glue" between Kustomize and deployment.

I do have k8s manifests in go templates. What would be the approach to let kluctl to render go templates, while still using kluctl provided attributes.

I do have configurations in Jsonnet templates, generating K8s Kinds. (ie: prometheus). Same use-case as above - how to pre-process them with kluctl arguments (as input data).

To setup HelmChart repo require to host helm repository, with metadata. Technically they are hard to use from just git repository (as url). Having the option to just render gotpl would be a solution (one can just point to subdir of hem/repository/templates) without struggling with helm.

Support to choose prefix of gotpl language, in example Helm uses ".Values" but sbd else. templates contains only "."

Looking for:

is that from your side valid use-case for kluctl?
guidance for implementation

(ie: do we want to support another style of "helm-chart.yml" like "gotpl-source.yml" and "jsonnet-source.yml" ?
Or we rather want one "xyz.yml" that would support multiple structures like HelmChart, JsonnetRender, GotplRender ?
^^ should they support lists (ie, multiple sources)?

Why do you need that?

render gotpl formated manifests as input

render jsonnet formated manifests as input

having the above, defined as concept may open kluctl to other todya/future forms of kubectl specified deployments

I had support for other templating systems in the back of my head since the beginning, but never put more effort into it.
I'm generally open to alternatives, but have the fear of feature creep. There are already so many options available, it will be hard to make everyone happy. The best solution longterm would be a way to make such template/generation systems plugin based, but this would be a completely new field for kluctl and introduces many new problems.
Also, one of the things that is extremely important for me is that kluctl works out of the box without any host-side dependencies, which will make plugin support harder to implement. This is especially important when you look at the flux-kluctl-controller, which later also must be able to deploy projects out of the box without requiring any extra work (e.g. building of custom docker images as with ArgoCD). See https://github.com/kluctl/kluctl/discussions/177 for something that is kind of related to this issue.
I plan to implement another feature in the future that might be able to solve many of the requirements that people have in this regard. It's the "generate" feature which will allow to run "generate" tasks on targets, having all the templating available that is also available when deploying, but with the intention to generate new manifests. "generation" would then be generic and configurable, meaning that you also shell-out to something like jsonnet and generate the actual manifests, which are then meant to be committed to git so that the render/deploy phase can just use these manifests.
The initial reason to implement this was to be able to provide an alternative to the sealed secrets integration, which basically dis exactly this but in a very specific way: seal+commit before deploy, then deploy without needing to seal before.

That all make perfect sense. I am not pushing on it.
Generators are good idea, sufficient for the use-case, and flexibility for end user without compromise kluctl with junk code.
Regarding. plugins, you see how plugins ended up in Kustomize. So better to stay with "weak" integrations for some time.

This might be nice solution https://docs.saltproject.io/salt/user-guide/en/latest/topics/jinja.html#using-renderer-pipes
shebang like
#!jinja|yaml

single files could be rendered/interpolated multiple times, easy to implement, no config (or dedicated file) needed.

@epcim I like that idea and will take it into account when/if I start working on multi template engine support.

@epcim I like that idea and will take it into account when/if I start working on multi template engine support.

when you suggest right place, I could have a look
as mentioned in SOPS issue, possibly all files "copied" to build dir could be inspected for "sops" decryption or the rendering. If you would agree on this or suggest different approach. The doors are open to implementation.
I am probably ok keep "jinja" as final renderer, but have a possibility to override or run sth else (golang, within kluctl binary) before. Either after 5 years with goptl/sprig library - I have to admit I feel less need for jinja, thought I would keep it as it's syntax is better fit for deployment.yml config then any gotpl and sort of brigs worth featrures as well.

I just want to leave a note for Kompose (https://kompose.io/) which would allow us to patch/template upstream docker-compose projects into our clusters.

What about adding more extensions? .yaml -> .yaml.gotmpl (like in tar.gz)
Templating can make .yaml invalid, "unautoformattable" and linter unfriendly.
There are long discussions on ther prettier project about Helm's .tpl and . yaml formatting.

Shebang in file header, as comment  is soft and better imo. Its like filter fn for whole file. That kluctl may understand but dont break other tools. Imo I have seen that implemented in Salt project. File suffixes are not bad either, but probably not the complex/mixed ones.PMi24. 3. 2024 v 22:29, Lucas Fernando Cardoso Nunes @.***>:
What about adding more extensions? .yaml -> .yaml.gotmpl (like in tar.gz)
Templating can make .yaml invalid, "unautoformattable" and linter unfriendly.
There are long discussions on ther prettier project about Helm's .tpl and . yaml formatting.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>


Icon-class will not change

Had a few minutes to look at this today.  'icon-class': will not change.
toaster.pop(  {
type: 'info',
title: 'No Data In Range',
body: 'The date range you selected, returns no recordset.',
show
});
type: 'info',
I can see the toast.type change my Parameter in the console.log
It alway's renders the toasterConfig regardless of what value I populate.
This should really be fixed...

I don't believe that this is actually a bug, but rather a "feature", if you will.  It was implemented at least back as far as version 0.4.2 and is probably an original port from toastr, since that is a toastr feature.
Currently, it works as a fallback.  If the type is not found in the icon-classes array, icon-class is the fallback type, which per the config is always 'info'.
On the other hand, it's possible that what you're looking for is the same type of functionality in #61, which could certainly be implemented.  If this is what you are looking for, please close this issue and +1 on that issue.

Thanks Stabzs.. The functionality shown in #61 is highly desire able and should be part of this project.

Closing this as a duplicate of #61.


remove unused functions and methods

Description
Removes unused:

splitVarGroup (function duplicated in oops and ufo, only ufo version is used in the code base)
LocalIncrement methods (not used after LETKF_OOPS method was removed).

Closing here; reopened on the other side.


fix: force Append and Increment to return results and discard that result before returning it to user

The name of the PR is WIP.
I only checked HBase 2.x behaviour for now.
We still probably need to implement similiar batch-append/increment result ignoring in https://github.com/Unoperate/java-bigtable-hbase-1/pull/116
The tests suddenly refused to be run so I leave it as a draft for now.

This change is

I didn't run the new integration tests yet.
Not implemended for AsyncMirroringBufferedMutator yet - will do it after a PR allowing us to create it from AsyncMirroringConnection.

I realized these tests may as well be unit tests rather than integration tests. Rebased the PR onto master.


sql/postgres: support add enum values before/after exisiting values

Fixed #2252

nice, I can not believe how much fast you have fixed this issue, great team....

❤

Hi @a8m i'm getting this error using atlas version v0.19.1-63b2061-canary .
I added a value and removed two values from notification_type enum
Error: template: schema_diff:2:3: executing "schema_diff" at <sql $>: error calling sql: reordering enum "notification_type" value "info" is not supported


Reorder columns

Can I change the output of the listed todo items?
I'm using it with FZF and would like to show the task content in the second column.
I'm a programmer so I'm happy to contribute to the project if possible.

Hi Josh!  I have a fairly large rewrite of a bunch of the internal components of Ultralist.  once that lands, I think it'd be relatively easy to add functionailty here to accomplish that.
The syntax could probably look like this:
ultralist l columns:id,completed,due,subject,projects,contexts
If you want to implement after my PR is merged, the steps you'd need to take are something like this:

add a columns array of strings to the Filter struct,
populate the Filter with the InputParser (see how it's done for projects or contexts to get an idea of how we'd do it for columns)
pass the filter struct into the ScreenPrinter which could act on which columns were chosen.

I'm hoping to have my big PR done this week.  After that, if you want to take a crack at it, feel free!

oh and btw :100: for the fzf idea!


Changelog: update for 1.1.5

Please makes sure these boxes are checked before submitting your PR, thank you!

[ ] Make sure you follow Element's Contributing Guide.
[ ] Make sure you are merging your commits to dev branch.
[ ] Add some descriptions and refer relative issues for you PR.

真刺激


vector: add afterservices option

Motivation for this change
The vector topology could depend on other services. If those services are not started vector will simply fail.
My first reflex is to provide a configurable parameter for defining the services that vector will depend on.
I had an error in production with loki.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@aanderse thanks for the comment!
I agree with you actually.
However I feel this is a footgun, or at least a nuisance. You shouldn't have to find out that your production config is wrong.
Is there somewhere where it would be appropriate to add a comment? Something in the lines of
remember that vector config defines a topology. Depending on the config you might have to adjust the `systemd.service.vector.requires`

Or something in the like.
The idea being to help people configure vector correctly out of the box.

I'll close this for now.


fix updating data

Hey @QQizi so as I mentioned in the issue, this actually eliminates the optimization logic. The more appropriate fix would be checking the nextProps.bricks is empty, then set the internal dataSource state to an empty array. If you can pull this in and test it on your end, that would be great!
within Masonry.js
  componentWillReceiveProps(nextProps) {
   // Check if it's array and if so, make
    if (!Array.isArray(nextProps.bricks) || nextProps.bricks.length === 0) {
      this.setState(state => ({
           dataSource: state.dataSource.cloneWithRows([])
       }));
    }

@QQizi  Would you be interested in pulling this in? Since you discovered this bug, I would be nice to credit you in some fashion.

@QQizi Going to fix and pr thank your the bug find


Updated user model comments

Updated the comments for the user model to reflect that the admin flag is again saved in the database

I have already told him that it's still the 0.8 source :P


Update args in prlimit exit event

Motivation
we might need to detect changes to system limits: for example in some cases miners update those limits to optimise their activity. At the moment we can detect this type of changes along with the updated values in the exit event but we can't say which is the resource affected.
Feature
I think that the solution here is to add the resource argument to the exit event, in order to define a precise detection and provide useful alerts.
Alternatives
Additional context

ei @Biagio-Dipalma! The request makes sense! We will try to schedule some time for this in the next release. For the moment I will put the milestone
/milestone TBD

Probably we need to do the same for setrlimit syscall

I'm working on this 😄


Nuxt.js

Assigned to @megha070

@megha070 If you are busy can i take up this issue

@sourabh1031  I am really very sorry but I raised a PR for this issue and it has been merged already!!

@megha070 np you have done the work so now you can close the issue by yourself

Thanks a ton !! I was'nt knowing about this!!


release candidate for UraLex 2.0

The CLDF data now comes with a human readable description, see https://github.com/lexibank/uralex/blob/release-2.0/cldf/README.md
Please also check the metadata at https://github.com/lexibank/uralex/blob/release-2.0/README.md

@kasyrj regarding the cognate sets: I just excluded cogn_set value 0 from cognate sets. That's the value in cogn_set when the form is [No equivalent]. So I'd consider this a bugfix.

@kasyrj I adapted the metadata such that it is clear(er) that the releases of this repos on Zenodo are the primary source of the dataset - not derived from a dataset somewhere else. With the changes in .zenodo.json, the correct metadata should show up as "recommended citation" on Zenodo.

@kasyrj it's also nice to see, that CI failed after changing the cognate set count: https://github.com/lexibank/uralex/actions

One additional potential issue: should Missing_UraLex2.0_refs.bib be merged with Borrowing_references.bib?

@kasyrj the bib files could be merged in raw/ already, yes. We didn't do that right away, because I had already made local changes before Mervi added refs in her branch. OTOH, cldf/sources.bib is the merge of all three bib files (minus whatever entries that are not actually cited). And since only the data in cldf/ is guaranteed to have matching references and bibkey, I wouldn't bother making the raw/ more consistent, when the end user should go for the CLDF data anyway.

@MervideHeer I incorporated your changes into this PR - so will close the other two relating to the bib files.

Understood. Thank you!

@xrotwang Although I've been using git for years I haven't been part of big collaborations before: how should I go about reviewing this? Do I just go through the "files changed" tab and confirm that they look okay to me? Are all these subsequent changes showing up there, and should I wait for them to be finished, or will we keep tidying things up even after the 2.0 branch is merged?

@evoling In terms of the data, the PR should be complete. It probably doesn't make much sense to review the data files - that's partly what cldf validate and the tests run by github actions are for. So focusing on the human-readable stuff, READMEs, other metadata should be good enough. If anything is changed from here on, this would show up as commits under this PR and would probably be triggered by discussion here; so you would probably be aware of this.

@evoling I think we should encourage people to cite the dataset, too. I know I have been frustrated when following the link to a "dataset paper" and not finding the actual data there. We also should encourage people to cite exact versions of data they were using. This introduces a bit of a conundrum, though: The DOI to be assigned by Zenodo is not known when we release the repository. That's why we now have this wording: https://github.com/lexibank/uralex/blob/release-2.0/README.md#how-to-cite
Hoping people will visit https://github.com/lexibank/uralex/releases to find

the versioned releases
exact citation info for each version

@MervideHeer see #9 (review) Should the wording be changed to be less of a "note-to-self"?

@evoling
Sorry for the style problem. I think it's good to include the "maximal" citing information. I have now modified the sentence so that it's more directed to the reader. Unfortunately, I can't compile an example full reference just yet because we don't have all pieces of information so we need to live with draft-like instructions.

So it looks like this is good to go?

So it looks like this is good to go?

I looked through our file changes and I see we have made all the changes we wanted. We are:

Merging the "missing" ref entries with the Borrowing_references.bib and deleting the extra bib file.
Adding maximum citing information in all readmes and the documentation: two papers and a mention of the soon-to-be DOI
Using the newly updated CLDF information
@kasyrj and @evoling have seen the changes and contributed their views.

Previously

We added the new main Data.tsv file with loanword info and no "timing" columns. The file parses correctly. We fixed some references later. We added a reference tsv with bib-codes as well as a plain .bib file of the refs. The parts of 2.0 are symmetrical enough in relation to 1.0. We call the folder "raw".
Python codes are updated in raw
The Documentation markdown lives in the correct main folder
We got rid of the ODF in raw

I cannot think of anything else to do anymore and I have crossed over all things from my checklist I summarize above. I'm finished and we are ready.

Perfect. I'll let this sit until tomorrow - off to catch a train now. Tomorrow I can make the release, and provide you with the new DOI.

Perfect. I'll let this sit until tomorrow - off to catch a train now. Tomorrow I can make the release, and provide you with the new DOI.

Sounds good! Just on time so I can add a brand new publication with a DOI into a conference presentation. Thank you for the help and patience. Have a safe trip!