Version Typo

Issue in ./help/support-tools/patches-available-in-qpt-tool/v1-1-34/acsd-51857-slow-cron-job-of-aggregate-sales-report-bestsellers-data-affects-performance.md
Quote:
The patch ID is ACSD-51857. Please note that the issue was fixed in Adobe Commerce 2.4.7.
(...)
Compatible with Adobe Commerce versions:
Adobe Commerce (all deployment methods) 2.4.0 - 2.4.6-p1
Problem:
It should say 2.4.0 - 2.4.6-p2 instead of -p1

@Nurgiel Thank you so much for noticing this and telling us. We have created a Jira ticket for this and assigned to an author have the change made. We will let you know when complete.

@Nurgiel Hello Nurgiel, thank you so much for this suggestion. As you can see change was made to the article here https://experienceleague.adobe.com/docs/commerce-knowledge-base/kb/support-tools/patches/v1-1-34/acsd-51857-slow-cron-job-of-aggregate-sales-report-bestsellers-data-affects-performance.html

@barnato-v, since Adobe Commerce and Magento Open Source released a new version yesterday, the compatible with Adobe Commerce versions information should be updated from

Adobe Commerce (all deployment methods) 2.4.0 - 2.4.6-p2
to
Adobe Commerce (all deployment methods) 2.4.0 - 2.4.6-p3

@Viper9x  thank you for you input!
We have a note in each of the QPT articles mentioning, that a patch might be compatible with other versions. But at this very moment we don't have a policy of going back and updating the specific compatibility version, it is usually specified as it was on the moment of publication (unless we get specific requests for updates from the QPT release team).

@almarchenko I have raised this issue because you guys have updated the information to include 2.4.6-p2. Anyway, never mind, I'm happy with the current information.


Code highlighter doesn’t highlight

Uh. No idea why.

Made it work. Also made the clipboard work. The problem was that they were loaded too late. I added the load of the Javascript to the Component itself. #43


Hand mesh is too small

Describe the bug
With some people, the hand mesh detected by the Hololens 2 is too small. Thus, some gesture and interactions are more difficult to perform (for exemple, the wrist button to access to the main menu appears inside the wrist, making it difficult to reach).
Note: This bug only appears on certain hands. In most cases, the mesh is well dimensioned.
To reproduce
Steps to reproduce the behavior:

Start the Hololens
Look at left wrist
Try to interact with the main menu button
See error

Expected behavior
The button appears on the skin, being accessible by touch.
Screenshots
Using MRC screenshot tools, RA holograms are not well aligned with the video background, thus, it is impossible to take a screenshot of this problem.
Your Setup (please complete the following information)

Unity Version 2018.4.2f1
MRTK Version 2.0.0-RC2

Target Platform (please complete the following information)

HoloLens 2

I think that what you're running into here is a HL2 operating system issue itself (i.e. from looking at the description above this doesn't seem to have anything to do with the MRTK.)
There's a couple of ways forward here:

You could file an issue using device portal (there's a way to file bugs using that, and you can use your desktop keyboard for typing).
You can file an issue through the feedback app on the HL2 itself.

I can follow up with the folks who know more about hand tracking on the OS side, though I'll close this issue out because it's not related to the MRTK


It should be possible to select which version of the CRD API to generate

Feature Request
Right now, the only possible CRD version to generate is v1. Also, the specified value is not actually used to affect the CRD generation in the generated project.

/assign

Hi @metacosm,
Using the --crd-version flag in the create api command from the tutorial docs, I was able to set the CRD version to a value different than v1.
create api command:
operator-sdk create api --plugins quarkus --group cache --version v1 --kind Memcached --crd-version v1beta1

The value of crdVersion can be viewed in the PROJECT file that is generated through these commands.
Note that the only possible options for the crdVersion are v1 and v1beta1, as mentioned in the Operator SDK docs here.
Let me know if you think this needs further investigation. Thanks!

@VenkatRamaraju ok, that's one step. However, if you specifiy the v1beta1 version, that's not what you will get when you actually compile the project and generate the CRD…

@metacosm After some investigation, I made the following changes to the steps in the tutorial to compile the operator with a CRD that has a version v1beta1.

create api command

operator-sdk create api --plugins quarkus --group cache --version v1beta1 --kind Memcached --crd-version v1beta1

While manually creating the crd.yaml file, ensure that spec.versions[0].name is v1beta1.

In the CR (memcached-sample.yaml), change the API version  to cache.example.com/v1beta1

All other steps from the tutorial remain the same.
$ kubectl get crd memcacheds.cache.example.com -o yaml

apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:

   ...

  versions:
  - name: v1beta1
    schema:

   ...

  storedVersions:
  - v1beta1

The CRD is not scaffolded, so I had to make these modifications.

@VenkatRamaraju the problem is that the CRD is generated by the operator sdk when you build your code. The java plugin just doesn't convey the flag information up to the operator sdk so that it can do its job properly. This is the core of this issue: the SDK is not properly configured from the CLI flags. There should be no manual edit steps.

Right now we are not generating the crd.yaml file because we're not using the operator-sdk configuration. That's why the tutorial asks the users to manually create the crd.yaml file. There is a CRD that is generated in the target/kubernetes/ directory but I ran into issues with it trying to install it. That's why we gloss over it in the tutorial: https://github.com/operator-framework/java-operator-plugins/blob/main/docs/tutorial.md#via-quarkus-extension
The --version flag should correspond to the value we use in the @Version : https://github.com/operator-framework/java-operator-plugins/blob/main/pkg/quarkus/v1alpha/scaffolds/internal/templates/model/model.go#L62
The --crd-version flag isn't being used apparently. But since we're not generating the crd through the Go code, I think that's fine.
Given all of that, I'm not sure what the actual problem is. There are only 2 CRD api versions: v1, and v1beta1. The v1beta1 is being deprecated in k8s 1.22.

@metacosm is there a specific file that contained the error?

The problem is that people used to Quarkus and the Java operator SDK extension will expect the CRD to be generated by the extension, not manually. While I agree that the v1beta1 spec is going away, it's still possible to use it at the moment and people using the extension expect to be able to generate both versions of the spec based on their configuration.
Right now, if you specify the crd-version flag to generate the v1beta1 version of the CRD, you're not getting it because the flag value is not properly propagated to the application.properties configuration.
Also, if there are issues with the generated CRD, please let me. Newer versions of the Quarkus extension should generate valid CRDs.

Looking at the code, the CRDVersion field of the createAPIOptions struct needs to be propagated to the applicationproperties.go template. The issue is that the CRD version is set at the API level from the CLI but it's set at the "operator" level in the Quarkus extension (i.e. all APIs for that specific operator are all supposed to generate the same version(s) of the CRD spec).

Can we please get an update on this?

@metacosm do you happen to know the value in the properites file it's looking for? I've scoured through quarkus and fabric8 and can't find the value.

For the quarkus extension for the Java Operator SDK, the property to be set is quarkus.operator-sdk.crd.versions, values are comma-delimited version strings (e.g. v1 or v1,v1beta1).

closing this issue


OLS-83: Use @patch it test-yaml-generator

Description
OLS-83: Use @patch it test-yaml-generator
Type of change

[x] Refactor
[ ] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library
[x] Unit tests

Related Tickets & Documents

Related Issue #OLS-83

Checklist before requesting a review

[x] I have performed a self-review of my code.
[x] PR has passed all pre-merge test jobs.
[ ] If it is a core feature, I have added thorough tests.

Testing

Look at CI
Use make test-unit

/lgtm

/approve


Edit and Continue with static members

It appears Edit and Continue doesn't work with static members: if I edit a static member private static string ReadOnlyString = "foo" to "not-foo", that change will not be reflected in code execution. My guess is that references to static variables are bound too early for this to work. It's true in this simple example, I could just use "edit value" in the debugger, but it's still unintuitive. I think what I can expect from VS here should be documented.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fd0b8848-c2af-28e9-28bf-761d1cdf3d6d
Version Independent ID: 7cc1bef7-ef0c-5c62-2b5f-45910764ba80
Content: Supported Code Changes (C# and Visual Basic) - Visual Studio
Content Source: docs/debugger/supported-code-changes-csharp.md
Product: visual-studio-windows
GitHub Login: @Mikejo5000
Microsoft Alias: mikejo

@elliott-beach Thanks, I'll ask about it.

I'm told that if you already accessed the value of the variable and then changed the original value, then it should not work. Not by EnC reasons but by code execution design. Otherwise, EnC with static values should be supported.
Making a doc edit for this.


Add .vscode/settings.json to synced file list

This pr should be merged after this pr has been merged.

still valid PR @lonegunmanb ?


Add JDK15

See https://github.com/micronaut-projects/micronaut-core/issues/4113

@jameskleeh @JasonTypesCodes if this is the only change needed for JDK15, can any of you please merge this?


NBA Player Data Veracity/Accuracy Issue

I loaded the NBA player data set and noticed a lot of values set at 0. eg. 369 for 0 years experience, 243 player entries with 0 weight and height, and 323 players with a salary of 0. Please note that these are values of 0 and not missing values.
league = "nba"
sport = "basketball"
ep = "players"
q_body = list()
players = ss_get_result(sport=sport, league=league, ep=ep, query=q_body, version=1, walk=TRUE)
players_df = do.call("rbind", lapply(players, function(x) x$players))
table(players_df$years_of_experience)
table(players_df$height)
table(players_df$weight)

@torontosj first - thanks for trying out both the API and R wrapper.
We're defaulting the player salary, height, weight, years of experience to 0 when our data provider doesn't have or send that data in the roster feeds.
But, as you noticed, we should instead set those to nil or missing.
We'll also do some data checking to see what players are missing profile data and see if we can't get our provider to populate them in their rosters then next time the update.
Will likely be able to get an update for the 0/nil issue for that player data by tomorrow morning.

Hey thanks for the response. I haven't had much time to tinker with the wrapper but it is a very cool project and I look forward to using it more in the future. Good luck! :)

FYI - We've corrected this in release promoted early this morning. When the player's height, weight, salary, or years of experience is unknown, the value is NULL/nil and no longer 0.

Nice. I tried loading the NHL and NBA player data sets and I can confirm that I got missing values.


Release Google.Shopping.Merchant.DataSources.V1Beta version 1.0.0-beta01

Changes in this release:
Initial release.

Created release for Google.Shopping.Merchant.DataSources.V1Beta-1.0.0-beta01


data source stackit_network raises error

terraform {
  required_providers {
    stackit = {
      source = "stackitcloud/stackit"
    }
  }
}

provider "stackit" {
  region                   = "..."
  service_account_key_path = "...account_key.json"
  private_key = "-----BEGIN PRIVATE KEY-----\n...\n-----END PRIVATE KEY-----"
}

data "stackit_network" "ext" {
  project_id = "2..."
  network_id = "9..."
}

data "stackit_network" "int" {
  project_id = "2..."
  network_id = "a..."
}

raises following error
  │ mismatch between struct and object: Struct defines fields not found in
  │ object: no_ipv4_gateway and no_ipv6_gateway.

related to PR https://github.com/stackitcloud/terraform-provider-stackit/pull/596

closing in hope of quick PR merge


added a new query param: null_to_none

Currently, the client will return the NULL value as a str type, which is not compatible with most Python clients of databases, a NoneType seems more reasonable.

Thanks for your contribution and sorry for late response. I will review it as soon as possible.


chore(github): update codeowners

@odsod are you admin on this repo? If so, could you update the new team in codeowners as moderator?

@felixmr1 make sure to change the repo ownership too :D

@felixmr1 make sure to change the repo ownership too :D

Jup, hence my previous comment!

not needed anymore :)


Create download-datasets.sh

Please, review vkitii2 ground truth. Create two new directories for:

[ ] rgb images
[ ] ground truth


Add package.json to pin dependencies used in the Docker image

Pull Request
Pull request checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[x] pre-commit was run locally and any changes were pushed
[x] test/test.sh has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue URL:
What is the new behavior?

Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

Supports #295


fix(TestRenderer): import jest from jest globals

Description

Updates import of the jest object to be from the @jest/globals package (which gets installed along with jest). This is recommended by jest in their v27 to v28 migration guide for resolving potential issues in TypeScript projects.
remove import of jest object in lng-test-env.js. Updating that import to be from @jest/globals throws the following error: Do not import @jest/globals outside of the Jest test environment. It looks like jest was being imported to assign jest.fn() to console.error, but don't see anywhere in tests that rely on this. I changed it to be an empty arrow function so that it still removes error messages from CI builds like the existing comment suggests.

References
Reported in LUI5 support channel

Testing
I'm not aware of a way to run into the initial error, but all our tests should still run after this change.

Automation
n/a

Checklist

[x] all commented code has been removed
[x] any new console issues have been resolved
[x] code linter and formatter has been run
[x] test coverage meets repo requirements
[x] PR name matches the expected semantic-commit syntax

:tada: This PR is included in version @lightningjs/ui-components-test-utils-v1.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[SPARK-33212][FOLLOWUP][test-maven][test-hadoop2.7] Add hadoop-yarn-server-web-proxy for Hadoop 3.x profile

What changes were proposed in this pull request?

This adds hadoop-yarn-server-web-proxy as dependency for Yarn and Hadoop 3.x profile (it is already a dependency for 2.x). Also excludes some dependencies from the module which are already covered by other Hadoop jars used by Spark.
Why are the changes needed?

The class org.apache.hadoop.yarn.server.webproxy.amfilter.AmIpFilter is used by ApplicationMaster:
  private def addAmIpFilter(driver: Option[RpcEndpointRef], proxyBase: String) = {
    val amFilter = "org.apache.hadoop.yarn.server.webproxy.amfilter.AmIpFilter"
    val params = client.getAmIpFilterParams(yarnConf, proxyBase)
    driver match {
      case Some(d) =>
        d.send(AddWebUIFilter(amFilter, params, proxyBase))
   ...

and will be loaded at runtime. Therefore, without the above jar Spark Yarn app will fail with ClassNotFoundError.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Existing unit tests. Also tested manually and it worked with the fix, while was failing previously.

Test build #135459 has started for PR 31642 at commit 17a63bd.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40039/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40039/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40039/

Test build #135459 has finished for PR 31642 at commit 17a63bd.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135459/

This seems like a decent workaround, but is it the right long-term fix? It seems like depending on the non-shaded JAR breaks the benefits of leveraging only the shaded hadoop-client-api and hadoop-client-runtime JARs.
Should AmIpFilter be a public class, i.e., is it something AMs are expected to leverage? If yes -- can we get it moved to hadoop-client-runtime? If no -- should we stop using it here and re-implement some of the required logic ourselves?

This is a small jar though and we've striped all its transitive dependencies. Agree that in the long term we should either: 1) consider to re-implement the logic in Spark which allows us to get away from server-side dependency in Hadoop. cc @tgravescs for more insights on this. 2) move the class to hadoop-client-runtime as you suggested.
I need to take a look at the test failures - seems WebAppProxyServlet was pulled from hadoop-yarn-server-web-proxy jar instead of hadoop-client-minicluster.

Retest this please

Thank you for the follow-up, @sunchao !

Test build #135483 has started for PR 31642 at commit 17a63bd.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40063/

Test build #135485 has started for PR 31642 at commit e2d32aa.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40063/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40065/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40063/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40065/

@sunchao . The PR title looks misleading. Which hadoop profile are you testing now?

I checked the Jenkins log. It's testing Hadoop 3.2 correctly. I'll fix the PR title.
[info] Building Spark using Maven with these arguments:  -Phadoop-3.2 -Phive-2.3 -Pyarn -Phadoop-cloud -Pkinesis-asl -Pkubernetes -Phive-thriftserver -Phive -Pspark-ganglia-lgpl -Pmesos clean package -DskipTests

Sorry I wanted to test 2.7 and 3.2 at the same time. Is that possible?

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40065/

Test build #135483 has finished for PR 31642 at commit 17a63bd.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135483/

It's not possible for the single title because one Jenkins run only will pick-up a single profile.
What you need is to run two Jenkins runs. So, you need to trigger twice like the following.

Set the title with test-hadoop3.2 and trigger.
Wait 5 or 10 minutes until Jenkins posts a comment. Then, check the log.
Then, rename the title with test-hadoop3.2 and trigger.
Wait another 5 or 10 minutes until Jenkins posts a comment. Then, check the log.

Then, you will have effectively concurrent two runs (for both profiles)

Test build #135485 has finished for PR 31642 at commit e2d32aa.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135485/

Thanks @dongjoon-hyun . Let me trigger another run for Hadoop 2.7 just to be sure.
Jenkins CI says there're 2 failures in SQL module but I'm guessing they're not related (this PR doesn't touch anything in SQL), although I can't seem to find which two tests are these.

Test build #135519 has started for PR 31642 at commit 1de8590.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40100/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40100/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40100/

Test build #135519 has finished for PR 31642 at commit 1de8590.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135519/

Test build #135525 has started for PR 31642 at commit e2d32aa.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40106/

Test build #135525 has finished for PR 31642 at commit e2d32aa.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135525/

Test build #135532 has started for PR 31642 at commit c31e06d.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40113/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40113/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40113/

Test build #135532 has finished for PR 31642 at commit c31e06d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135532/

Could you confirm which links are the two successful runs (Hadoop 3.2/2.7)?

@dongjoon-hyun Github CI all succeeded (except the flaky tests).
For the Jenkins CI, here are the results:

3.2
2.7

The tests all passed except two in SQL:
Caused by: java.lang.IllegalArgumentException: Unknown key pii
	at org.apache.orc.impl.HadoopShimsPre2_3$NullKeyProvider.getCurrentKeyVersion(HadoopShimsPre2_3.java:71)
	at org.apache.orc.impl.WriterImpl.getKey(WriterImpl.java:871)
	at org.apache.orc.impl.WriterImpl.visitTypeTree(WriterImpl.java:902)
	at org.apache.orc.impl.WriterImpl.visitTypeTree(WriterImpl.java:915)
	at org.apache.orc.impl.WriterImpl.setupEncryption(WriterImpl.java:938)
	at org.apache.orc.impl.WriterImpl.<init>(WriterImpl.java:162)
	at org.apache.orc.OrcFile.createWriter(OrcFile.java:1004)
	at org.apache.spark.sql.execution.datasources.orc.OrcOutputWriter.<init>(OrcOutputWriter.scala:47)
	at org.apache.spark.sql.execution.datasources.orc.OrcFileFormat$$anon$1.newInstance(OrcFileFormat.scala:120)
	at org.apache.spark.sql.execution.datasources.SingleDirectoryDataWriter.newOutputWriter(FileFormatDataWriter.scala:126)
	at org.apache.spark.sql.execution.datasources.SingleDirectoryDataWriter.<init>(FileFormatDataWriter.scala:111)
	at org.apache.spark.sql.execution.datasources.FileFormatWriter$.executeTask(FileFormatWriter.scala:270)
	at org.apache.spark.sql.execution.datasources.FileFormatWriter$.$anonfun$write$15(FileFormatWriter.scala:210)
	at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:90)
	at org.apache.spark.scheduler.Task.run(Task.scala:131)
	at org.apache.spark.executor.Executor$TaskRunner.$anonfun$run$3(Executor.scala:498)
	at org.apache.spark.util.Utils$.tryWithSafeFinally(Utils.scala:1437)
	at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:501)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)
- Write and read an encrypted file *** FAILED ***
  org.apache.spark.SparkException: Job aborted.
  at org.apache.spark.sql.execution.datasources.FileFormatWriter$.write(FileFormatWriter.scala:232)
  at org.apache.spark.sql.execution.datasources.InsertIntoHadoopFsRelationCommand.run(InsertIntoHadoopFsRelationCommand.scala:188)
  at org.apache.spark.sql.execution.command.DataWritingCommandExec.sideEffectResult$lzycompute(commands.scala:108)
  at org.apache.spark.sql.execution.command.DataWritingCommandExec.sideEffectResult(commands.scala:106)
  at org.apache.spark.sql.execution.command.DataWritingCommandExec.doExecute(commands.scala:131)
  at org.apache.spark.sql.execution.SparkPlan.$anonfun$execute$1(SparkPlan.scala:180)
  at org.apache.spark.sql.execution.SparkPlan.$anonfun$executeQuery$1(SparkPlan.scala:218)
  at org.apache.spark.rdd.RDDOperationScope$.withScope(RDDOperationScope.scala:151)
  at org.apache.spark.sql.execution.SparkPlan.executeQuery(SparkPlan.scala:215)
  at org.apache.spark.sql.execution.SparkPlan.execute(SparkPlan.scala:176)

which doesn't look like related as this PR only touches dependencies for YARN.
Also the above succeeded in Jenkins CI if I remove [test-maven].

Thank you for the summary. For those test cases, I'll take a look in this week, @sunchao .

yes AmIpFilter is expected to be used by ApplicationMasters so ideally Hadoop would move it to somewhere easily accessible.


Implement race and ethnicity mapping

🔗 Jira ticket
Link
✍ Description

📷 Design reference

✅ Completion tasks

[ ] Added relevant tests
[ ] Meets acceptance criteria

Still looks good to me, and I like the cleanup work you did!


Make background grid vector based

Currently, the background grid is created using a PNG image. When zooming in and out, the image is distorted.
Replace PNG image with a vector based XAML DrawingImage.
Acceptance criteria:

Image is vector based
Zooming in and out does not distort the background image.

I'm closing this issue as your PR has been merged.


Simulated gyro incorrect

The simulated gyroscope often reports a different measurement to that of the real robot. This seems to be because the gyro is used to reset itself.

Has this been fixed?

Appears to be fixed now


"TestRun" is a strange name as a subclass of "TestRunOptions"

Testing #117304
"TestRun" is a strange name as a subclass of "TestRunOptions".
May be "TestRunStateOptions"?

Or perhaps make TestRunOptions TestRequestOptions? The options can be passed by other extensions when they want to request tests to be run, the 'TestRun' is the options plus mutation methods that is given to the test provider.


preempt improvements

First, commit fixes a bug discovered by @bugadani, where preconfigured interrupts were disabled once the preempt module started.
The second commit reduces the task switching frequency on Xtensa to the same values as on RISCV. This should improve performance as less time will now be spent in the switching code. We should do some profiling at some point to determine the best default value for this (I still think 1000hz could be too high), but for now 1000hz seems reasonable. It's no set to 100hz.
Closes #184

Thanks for doing this!
Results are: this PR closes #184 but I don't think it closes #183 as performance is, while better, still pretty bad.

@bugadani That's odd. Whilst I would expect a loss in perf, I would expect it to be relatively small. I've just pushed a commit which reduces the switching frequency to freeRTOS' default of 100hz. Can you see if this has any affect at all?

Yes, 100Hz has a big difference.

I've tried 8175ecd again and it looks like it works well, too.
It's possible I've been trying the patch accidentally in debug mode yesterday, and that might have caused my perf problems. It would certainly explain some of the weirdness I've seen.

Changes look sane and I gave it a try - works fine except on ESP32
This
https://github.com/esp-rs/esp-wifi/blob/5ce1c7fd99aad9b6a69920ba89943bf322cb2a6d/esp-wifi/src/timer_esp32.rs#L88
is what breaks things.
There are definitely strange things going on with the pre-enabled interrupts on ESP32 (see https://github.com/esp-rs/esp-wifi/pull/186/files#diff-e7c01fb52e0e17b32c13a65823644ff20c6a47e64d12cdf7474b17efce28f83f )
I also think the insane high task-switching frequency was needed in the beginning since there was no yield_task and connecting to WiFi took a very long time ... now things look quite good. But I don't think we should further lower the task-switching frequency (at least not by default)

Yeah, this is really weird. For some reason when keeping the interrupts enabled the WIFI_BB interrupt fires constantly, I guess this was happening before though. With the change we keep the already enabled interrupts enabled, WIFI_BB being one of them.
I disabled the WIFI_BB interrupt (by commenting this section: https://github.com/esp-rs/esp-wifi/blob/8e35b68c4aaed2c6a4d1159dd1c1287a5a2359be/esp-wifi/src/timer_esp32.rs#L57-L62) and everything works just fine...
So I guess the question is what is causing WIFI_BB to fire and how do we clear it?

I'm a bit unfamiliar with each interrupt type, what does the BB interrupt do? Do we actually need it enabled? It seems this is slightly different to the C6 where the can be disabled, but once enabled it just fires continuously (perhaps we're missing some code to clear it?).
Removing it completely feels weird, but if it works.. it works :D.

mhhh if you comment it out and everything works, we might not need it - I remember there were some interrupt numbers mixed up at some point of time in the PAC ... maybe it originates from that. Especially since we delegate WIFI_BB and WIFI_MAC both to ISR_INTERRUPT_1 callback 🤔

Okay, I've removed WIFI_BB from ESP32, are we happy with the task-switching frequency? In my limited testing, 100hz seems to work fine on all the examples I've tried.

I wonder if it's necessary to reduce to 50Hz if debug_asserts are enabled. 100Hz is already lower than any previous values, maybe a single value might work fine for simplicity's sake?

I tested on all targets and it looks fine to me. There is apparently a problem with BLE on ESP32-C2 but I there are problems in the implementation anyways so I would be fine merging this ... probably it increases the pressure a bit to fix ESP32-C2 BLE and also we need to fix that before C6 BLE


Simplify bower path in postinstall script.

Because npm scripts include npm bin-enabled modules in the "path" by default, we can simplify this.

Ah, good catch. Though looking at it now, I realize that we likely don't need a postinstall for Bower at the moment, since we don't actually have any Bower deps; we had previously been using a few libs before trimming down for GitHub.
If you don't mind, could you go ahead and remove the scripts prop altogether? I'm happy to merge after that. Thanks!

@Jahnp Thanks for merging. I didn't get a chance to delete it. Still want that in another PR, if I have time? Or just leave it for now?

@adjohnson916 If you have time and can test to make sure things are still golden after removing the line, that'd be great! I'd be happy to merge it in then. I think it might be related to (this issue)[https://github.com/OfficeDev/Office-UI-Fabric/issues/86], too, so that might be something to watch for.
Thanks again!

Hey @adjohnson916 - thanks for contributing! Can you please sign the Contribution License Agreement located here?
Thanks!

@ericthompson Signed CLA.

Thanks, @adjohnson916!


Add ESLint

ESLint could protect you from many errors. I think every project should use it.

Install our config https://github.com/logux/eslint-config
Add it to package.json

  "eslintConfig": {
    "extends": "@logux/eslint-config/browser"
  }

Add eslint to yarn test and lint-staged

done


UDF framework doesn't clean up the resources used by the user

If the user creates threads in his UDF code, but forgets to destroy them, our UDF framework should destroy those threads. This issue was seen in the issue here #1141 . As a temporary fix, we can tell users to make sure they are destroying all threads, but it can be difficult if user himself is using a third party library.
So, we should try to incorporate logic in the UDF framework, to destroy the resources user has created.

Discussion 1/13: we need further deeper investigation

Discussion 2022.05.12: Related to this issue. We leave it open.

Discussion 2022.12.07: Won't be fixed in the near future.


LFS-701: In the Questionnaire wizard, display all question properties that have a set value in view mode

tested

Updated, please test again.

retested; all good!


Duplicate items

Some items appear as duplicates and also counted twice (when I transfered all the items, I had 2 less than what was displayed within the program)

Thanks.
Please execute in CMD: adb ls /path/to/your/folder so that we can inspect the output for these files.

Hey Alex. unfortunately I deleted the images right after pulling them from my device. Next time I encounter this issue, I will report in again with the a screenshot from ADB explorer and also the command you suggested.


Bug fixes

Cleanup instance from planner on its removal

When instance with missing dependencies gets removed up by deployment planner, we should remove it from the planner's list of instances. Otherwise it would participate in further deployment, and further down will hit the timeout waiting for this instance to hit valid state (Running/Stopped, etc)

Don't schedule service config.update on service in updating-active/activating state. Reconcile process invoked by update/activate operation, can result in some instances being stopped/destroyed. And stop/destroy processes have config.upgrade hooks resulting in subsequent reconcile requests.

At the end of every activate/update process, we double check that the reconcile have been finished successfully, and if not - the process gets rescheduled.
This 2 fixes above are supposed to fix the bugs related to service reconcile slowness, like:
https://github.com/rancher/rancher/issues/2044

Validate service selector on instance.restore

https://github.com/rancher/rancher/issues/2338

I feel like you need better PR titles.  More uplifting like "Vast improvement in functional correctness"

@ibuildthecloud :) will improve the naming in the future PRs


@shaikegross thank you for contributing. While the PR looks perfectly fine, we've intentionally not added this within our code base.

          @shaikegross thank you for contributing. While the PR looks perfectly fine, we've intentionally not added this within our code base.

Please see this comment: https://github.com/asteasolutions/zod-to-openapi/pull/51#discussion_r996428248
TLDR: There is a date-time format but there is also just date. So from a generation standpoint we cannot assume on behalf of the user.
As for:

The only way to do this without having to hack the generator is to c;hange the openapi schema creatd from ZodDate objects to have a format type
That should not be true - you can use the .openapi method to do:

const schema = z.date().openapi({ format: 'date-time' });

Please let me know if that answers your questions and works for you
Originally posted by @AGalabov in https://github.com/asteasolutions/zod-to-openapi/issues/183#issuecomment-1801803273
Great! really appreciate the feedback. just one small thing, was there a place in documentation where I could tell that I can use to format property on any zod object other than string, cause I only saw it mentioned for ZodString

@shaikegross the idea in the line in the README was more towards (we support automatic format from some modifiers of ZodString). In general any property you want can be added using the openapi method:

.openapi({ [key]: value }) - this way we can specify any OpenApi fields. For example z.number().openapi({ example: 3 }) would add example: 3 to the generated schema.

Using .openapi is kind of our way to give manual control to users to do whatever they like - they are always taken with higher priority => it can be used to override stuff as well.
Still thank you for pointing out that there was something you are missing from the documentation. We do plan to improve upon it soon. I'll close this ticket for now. Let me know if I can help with anything else


Python Unit Tests

This PR is meant to provide a basis for testing Python

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.license[bot] seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

This PR doesn't contain much and is really out of date. I'm going to close it.


get list of all modules scanned

Get list of all modules that are scanned instead of getting just count of modules

Thanks, @hett39, This feature is available in the latest Safety version.


Update the Navbar section of the Website

I want to update the Navbar of the website like create a toggle button for Dark Mode and place all the navbar items like wise and all the social media icons with updated icons.

@ANSHIKA-26 Please assign this issue to me. I want to resolve this issue.

please add the required level for this issue and hacktoberbest also


byyear.html is not working, while paper.html works - No style changes from bibere.scss

Thank you for developing this great package, it seems perfect for adding a list of publications to github pages! I am using it as intended, but am currently testing my site locally with the BretFisher/jekyll-serve docker container rather than live on github pages.
I've added  to _includes/head.html, and bibere.scss to _sass/, along with the required _includes/bibere files and demo _data/bibere/ yaml files.
Including paper.html for one paper works okay, though without styling:

However, using byyear.html breaks at the first publication at the  tag:

Am I using bibere incorrectly, or could this be breaking due to the particular docker container I am hosting it in? Any suggestions on how to fix the  section of byyear.html and how to get the bibere.scss to be applied?

The relevant html from the served page is below.

  <meta charset="UTF-8" />
...

...

...

Publications

{% include bibere/paper.html pid=”demselect:emnlp23” %}

        Shivanshu Gupta, Matt Gardner, Sameer Singh.
        Coverage-based Example Selection for In-Context Learning.

        Empirical Methods in Natural Language Processing (EMNLP).

        2023

        Conference

        [ ArXiV, PDF,
        BibTex ]

@inproceedings{demselect:emnlp23,
  author = {Shivanshu Gupta and Matt Gardner and Sameer Singh},
  title = { {Coverage-based Example Selection for In-Context Learning} },
  booktitle = {Empirical Methods in Natural Language Processing (EMNLP)},
  year = {2023}
}

{% include bibere/byyear.html mainAuthor=”sameer” filterAuthor=”sameer” minYear=2023 %}

Publications (grouped by year):
    <a href="[#2023](http://<IP_ADDRESS>:4000/#2023)">2023.

<span id="2023" class="yearGroup">2023</span>
<ul class="papers">

        <li id="posthoc_neurips23">
    <!-- Author --><span class="author">Satyapriya Krishna</span>,&nbsp;<span class="author">Jiaqi Ma</span>,&nbsp;<span class="author"><a href="https://dylanslacks.website/">Dylan Slack</a></span>,&nbsp;<span class="author">Asma Ghandeharioun</span>,&nbsp;<span class="mainAuthor"><a href="http://www.sameersingh.org">Sameer Singh</a></span>,&nbsp;<span class="author"><a href="https://himalakkaraju.github.io/">Himabindu Lakkaraju</a></span>.<!-- Title -->
    <span class="title">Post Hoc Explanations of Language Models Can Improve Language Models.</span>
    <!-- Venue -->
...

...


Disable email and password inputs when the profile doesnt have twinId

Description

Check mnemonic if it has twinId or not, if no it will be redirected to create an account, otherwise it will load email from metadata normally.

Changes
Screencast from 25-08-24 23:52:11.webm
Related Issues

https://github.com/threefoldtech/tfgrid-sdk-ts/issues/3147#issuecomment-2291179960

Checklist

[ ] Tests included
[x] Build pass
[ ] Documentation
[x] Code format and docstrings
[x] Screenshots/Video attached (needed for UI changes)

@amiraabouhadid It was because you used more than 66 characters, there's no limit now

@amiraabouhadid I assume you used a new one so it blocked the other fields till you create an account

@amiraabouhadid I assume you used a new one so it blocked the other fields till you create an account

Yes but then it replaces the mnemonic i placed

@xmonader can you confirm the expected behavior, please


Error in Safari

Describe the bug

Reproduction
Go to:
https://learn.svelte.dev/tutorial/ssr
Wait some sec.
Page reload alone
Wait some sec
Read mode appear some secs
Wait some sec
Page break
Logs
No response
System Info
iPhone 13 Pro Max

Severity
annoyance

The same goes for chrome on the ios. You can avoid it by constantly scrolling at a low speed but it's for sure still annoying.

Duplicate of #416


Building Error

I cant build this project to WindowsNoEditor. My  UE4 Version is 4.12
I created an empty project ,and copy VRGripMotionControllerPlugin to the project and enabled it.
Then I tried to build this project as WindowsNoEditor. And ..BOOM..
I think this issue  might coused by the VRGripMotionControllerPlugin.
How can i fix it ?
this is Editor logs :
 MainFrameActions: 打包 (Windows (64位)): Running AutomationTool...  MainFrameActions: 打包 (Windows (64位)): BuildCookRun.SetupParams: Setting up ProjectParams for D:\Documents\Unreal Projects\test\test.uproject MainFrameActions: 打包 (Windows (64位)): Project.Build: ********** BUILD COMMAND STARTED ********** MainFrameActions: 打包 (Windows (64位)): CommandUtils.Run: Run: D:\Program Files\Epic Games\4.12\Engine\Binaries\DotNET\UnrealBuildTool.exe UE4Game Win64 Development   -remoteini="D:\Documents\Unreal Projects\test" -noxge -generatemanifest -NoHotReloadFromIDE MainFrameActions: 打包 (Windows (64位)): UnrealBuildTool: ERROR: No modules found to build. All requested binaries were already part of the installed engine data. MainFrameActions: 打包 (Windows (64位)): CommandUtils.Run: Run: Took 1.35s to run UnrealBuildTool.exe, ExitCode=5 MainFrameActions: 打包 (Windows (64位)): Program.Main: ERROR: AutomationTool terminated with exception: AutomationTool.AutomationException: Command failed (Result:5): D:\Program Files\Epic Games\4.12\Engine\Binaries\DotNET\UnrealBuildTool.exe UE4Game Win64 Development   -remoteini="D:\Documents\Unreal Projects\test" -noxge -generatemanifest -NoHotReloadFromIDE.   MainFrameActions: 打包 (Windows (64位)): BUILD FAILED PackagingResults:Error: 错误 Unknown Error

Be sure to download the last version of the plugin from https://bitbucket.org/mordentral/ue4-vr-grippable-motion-controller-plugin/downloads . For the rest, I'll release a new version 1.11 in 1-2 days with extensive docs everything should works flawlessly after that


README.md

s/phpise/phpize/
I'm trying to install but when trying to install thrift on CentOS, it blows up on TBinaryProtocol.tcc.
The version that ships with CentOS 6.5 is pretty behind.

Try using thrift 0.9.x, take a look at my posts about similar issue: https://github.com/Orange-OpenSource/YACassandraPDO/issues/47#issuecomment-51669503


packer build crash when no ssh connection available

/kind bug
What steps did you take and what happened:
I am new to packer, and wanted to test it out.
My Nutanix cluster is not directly accessible from my local network, so I am only SSH-tunneling the PRISM interface on port 9440.
From the Ubuntu example, I removed the provisioner and the ssh configuration, so that no direct connection would be theoretically needed (correct me if I am wrong).
See,
--- a/example/build.nutanix.pkr.hcl
+++ b/example/build.nutanix.pkr.hcl
@@ -16,7 +16,7 @@ build {
   }

   provisioner "shell" {
-    only = ["nutanix.centos", "nutanix.centos-kickstart" ,"nutanix.ubuntu"]
+    only = ["nutanix.centos", "nutanix.centos-kickstart"]
     environment_vars = [
       "FOO=hello world",
     ]

--- a/example/source.nutanix.pkr.hcl
+++ b/example/source.nutanix.pkr.hcl
   shutdown_command  = "echo 'packer' | sudo -S shutdown -P now"
   shutdown_timeout = "2m"
-  ssh_password     = "packer"
-  ssh_username     = "builder"
+  ssh_password     = ""
+  ssh_username     = ""
 }

Running PACKER_LOG=1 packer build -debug -force -only nutanix.ubuntu . it crashed.
What did you expect to happen:
I would expect the plugin to handle this case and generate an image without any provisioner step.
Anything else you would like to add:
crash.log
Environment:

packer-plugin-nutanix version (use packer plugins installed):

$ packer plugins installed
/Users/mtrangoni/.config/packer/plugins/github.com/nutanix-cloud-native/nutanix/packer-plugin-nutanix_v0.7.1_x5.0_darwin_arm64

Packer version (use packer version):
Packer v1.9.1
OS (e.g. from /etc/os-release):

$ sw_vers
ProductName:            macOS
ProductVersion:         13.4.1
BuildVersion:           22F82

ssh is mandatory, used to poweroff properly the VM

Hi @mjtrangoni
If you set your communicator to none
It will normally solve your issue


Add quality control to user input

Check that all needed keywords are present.
The ACMEParameters class already does this, but if the user spells "sets" as "set" still doesn't give an error.

Another example is if the user wants a zonal mean xy plot but fill in a 3d variable without specifying the pressure level. should have warning/error message for this kind of behavior too.

Everything is good.


NAN on the evaluation

Hi,
Thank you for the awesome documentation.
However, I have one issue. I am getting NAN during evaluation during training. Could you provide insight ( I am doing a single object detection)

Your model has a mAP of 0.075 for the 'Broiler' class. It seems there may be issues with the annotations in your training set. Additionally, please note that a test set of only 10 images is quite small and may not provide reliable results.

Your model has a mAP of 0.075 for the 'Broiler' class. It seems there may be issues with the annotations in your training set. Additionally, please note that a test set of only 10 images is quite small and may not provide reliable results. NaN results are due to values close to zero, whose division gives NaN when the metric is computed.

Thank you for insights. I found that the bounding box size in the test set doesn't exist for mAPs(32x32) and mAP(forgot size) and because of that, I am getting the NaN error.


#918 fix sorting error in dataset list

Description

Sorting by created doesn't work after sorting by used in
Related Issue :

#918
How Has This Been Tested?

Dataset tab > click created sorting button > check if list is sorted by created time > click used in sorting button > check if list is sorted by used in > click created sorting again > check if list is sorted by created time
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project. it will be added soon
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document. it will be added soon
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Additional Context

run build
deploy to 4

found bug. Reopening PR when fixed

Run build
deploy to 3

Run build
deploy to 3


Keda Http-add-on using Traefik Ingress controller

I am following the walktrhough guide and I am trying to use Traefik Ingress Controller instead of NGINX as suggested.
I am facing issues accessing the interception proxy backend with Traefik. All my requests are failing with 500 Internal Server Error.
After looking into the issue it seems that Traefik is attempting to access the interception proxy backend through HTTPS.
>kubectl -n kube-ingress logs -f --tail=1 rnd-traefik-5db4d59495-5dnph
time="2022-06-22T15:29:52Z" level=debug msg="Serving default certificate for request: \"keda-test.myhost.com\""
time="2022-06-22T15:29:52Z" level=debug msg="vulcand/oxy/roundrobin/rr: begin ServeHttp on request" Request="{\"Method\":\"GET\",\"URL\":{\"Scheme\":\"\",\"Opaque\":\"\",\"User\":null,\"Host\":\"\",\"Path\":\"/\",\"RawPath\":\"\",\"ForceQuery\":false,\"RawQuery\":\"\",\"Fragment\":\"\",\"RawFragment\":\"\"},\"Proto\":\"HTTP/1.1\",\"ProtoMajor\":1,\"ProtoMinor\":1,\"Header\":{\"Accept\":[\"*/*\"],\"Accept-Encoding\":[\"gzip\"],\"Cdn-Loop\":[\"cloudflare\"],\"Cf-Connecting-Ip\":[\"<IP_ADDRESS>\"],\"Cf-Ipcountry\":[\"GR\"],\"Cf-Ray\":[\"71f6059b9cec6f6d-ORD\"],\"Cf-Visitor\":[\"{\\\"scheme\\\":\\\"https\\\"}\"],\"Connection\":[\"Keep-Alive\"],\"User-Agent\":[\"curl/7.68.0\"],\"X-Forwarded-Host\":[\"keda-test.myhost.com\"],\"X-Forwarded-Port\":[\"443\"],\"X-Forwarded-Proto\":[\"https\"],\"X-Forwarded-Server\":[\"rnd-traefik-5db4d59495-5dnph\"],\"X-Real-Ip\":[\"<IP_ADDRESS>\"],\"Xcf-Geoip-Country\":[\"GR\"],\"Xcf-Geoip-Sub-1\":[\"GR-G\"],\"Xcf-Geoip-Sub-2\":[\"GR-13\"]},\"ContentLength\":0,\"TransferEncoding\":null,\"Host\":\"keda-test.myhost.com\",\"Form\":null,\"PostForm\":null,\"MultipartForm\":null,\"Trailer\":null,\"RemoteAddr\":\"<IP_ADDRESS>:25836\",\"RequestURI\":\"/\",\"TLS\":null}"
time="2022-06-22T15:29:52Z" level=debug msg="vulcand/oxy/roundrobin/rr: Forwarding this request to URL" ForwardURL="https://<IP_ADDRESS>:8080" Request="{\"Method\":\"GET\",\"URL\":{\"Scheme\":\"\",\"Opaque\":\"\",\"User\":null,\"Host\":\"\",\"Path\":\"/\",\"RawPath\":\"\",\"ForceQuery\":false,\"RawQuery\":\"\",\"Fragment\":\"\",\"RawFragment\":\"\"},\"Proto\":\"HTTP/1.1\",\"ProtoMajor\":1,\"ProtoMinor\":1,\"Header\":{\"Accept\":[\"*/*\"],\"Accept-Encoding\":[\"gzip\"],\"Cdn-Loop\":[\"cloudflare\"],\"Cf-Connecting-Ip\":[\"<IP_ADDRESS>\"],\"Cf-Ipcountry\":[\"GR\"],\"Cf-Ray\":[\"71f6059b9cec6f6d-ORD\"],\"Cf-Visitor\":[\"{\\\"scheme\\\":\\\"https\\\"}\"],\"Connection\":[\"Keep-Alive\"],\"User-Agent\":[\"curl/7.68.0\"],\"X-Forwarded-Host\":[\"keda-test.myhost.com\"],\"X-Forwarded-Port\":[\"443\"],\"X-Forwarded-Proto\":[\"https\"],\"X-Forwarded-Server\":[\"rnd-traefik-5db4d59495-5dnph\"],\"X-Real-Ip\":[\"<IP_ADDRESS>\"],\"Xcf-Geoip-Country\":[\"GR\"],\"Xcf-Geoip-Sub-1\":[\"GR-G\"],\"Xcf-Geoip-Sub-2\":[\"GR-13\"]},\"ContentLength\":0,\"TransferEncoding\":null,\"Host\":\"keda-test.myhost.com\",\"Form\":null,\"PostForm\":null,\"MultipartForm\":null,\"Trailer\":null,\"RemoteAddr\":\"<IP_ADDRESS>:25836\",\"RequestURI\":\"/\",\"TLS\":null}"
time="2022-06-22T15:29:52Z" level=debug msg="'500 Internal Server Error' caused by: tls: first record does not look like a TLS handshake"
time="2022-06-22T15:29:52Z" level=debug msg="vulcand/oxy/roundrobin/rr: completed ServeHttp on request" Request="{\"Method\":\"GET\",\"URL\":{\"Scheme\":\"\",\"Opaque\":\"\",\"User\":null,\"Host\":\"\",\"Path\":\"/\",\"RawPath\":\"\",\"ForceQuery\":false,\"RawQuery\":\"\",\"Fragment\":\"\",\"RawFragment\":\"\"},\"Proto\":\"HTTP/1.1\",\"ProtoMajor\":1,\"ProtoMinor\":1,\"Header\":{\"Accept\":[\"*/*\"],\"Accept-Encoding\":[\"gzip\"],\"Cdn-Loop\":[\"cloudflare\"],\"Cf-Connecting-Ip\":[\"<IP_ADDRESS>\"],\"Cf-Ipcountry\":[\"GR\"],\"Cf-Ray\":[\"71f6059b9cec6f6d-ORD\"],\"Cf-Visitor\":[\"{\\\"scheme\\\":\\\"https\\\"}\"],\"Connection\":[\"Keep-Alive\"],\"User-Agent\":[\"curl/7.68.0\"],\"X-Forwarded-Host\":[\"keda-test.myhost.com\"],\"X-Forwarded-Port\":[\"443\"],\"X-Forwarded-Proto\":[\"https\"],\"X-Forwarded-Server\":[\"rnd-traefik-5db4d59495-5dnph\"],\"X-Real-Ip\":[\"<IP_ADDRESS>\"],\"Xcf-Geoip-Country\":[\"GR\"],\"Xcf-Geoip-Sub-1\":[\"GR-G\"],\"Xcf-Geoip-Sub-2\":[\"GR-13\"]},\"ContentLength\":0,\"TransferEncoding\":null,\"Host\":\"keda-test.myhost.com\",\"Form\":null,\"PostForm\":null,\"MultipartForm\":null,\"Trailer\":null,\"RemoteAddr\":\"<IP_ADDRESS>:25836\",\"RequestURI\":\"/\",\"TLS\":null}"

What stands out from the above log is that

Traefik is forwarding the request to an HTTPS endpoint ForwardURL="https://<IP_ADDRESS>:8080"
It fails with msg="'500 Internal Server Error' caused by: tls: first record does not look like a TLS handshake".

I tried a ton of Traefik options through annotations with no luck and I didn't manage to force backend's connection to HTTP.
What seemed to work for me is to just edit kubectl -n keda edit svc keda-add-ons-http-interceptor-proxy servive and chang spec.ports[0].name from https to http.
So I changed this value to https: https://github.com/kedacore/charts/blob/main/http-add-on/templates/svc-interceptor-proxy.yaml#L21
Then Traefik used ForwardURL="http://<IP_ADDRESS>:8080" and the scale up worked nicely.
Expected Behavior
Traefik should use ForwardURL="http://<IP_ADDRESS>:8080" since the interception proxy pod is not using HTTPs.
The name of the port should be http and not https.
This will allow Traefik to work without the need to edit proxy port name value. I can file a Pull Request if this is the appropriate solution.
Actual Behavior
Traefik uses ForwardURL="https://<IP_ADDRESS>:8080" because the name of the port is https and not http.
Steps to Reproduce the Problem

Follow the walktrhough guide page
Intead of NGINX register the service to Traefik.
Hit the xkcd pod, 500 Internal Server Error occurs.

Specifications

KEDA Version: 2.7.1
Platform & Version: GKE
Kubernetes Version: v1.23.5
Scaler(s): HTTP-add-on

Traefik documentation [1] mentions the following for the https protocol in backends.

TLS communication between Traefik and backend pods¶
Traefik automatically requests endpoint information based on the service provided in the ingress spec. Although traefik will connect directly to the endpoints (pods), it still checks the service port to see if TLS communication is required. If the service port defined in the ingress spec is 443, then the backend communication protocol is assumed to be TLS, and will connect via TLS automatically.

Traefik code [2] is following this convention
	if portSpec.Port == 443 || strings.HasPrefix(portName, "https") {
		protocol = "https"
	}

I think Keda Http-add-on should use http and not https for port name assignment in [3].
curl https://keda-add-ons-http-interceptor-proxy.keda.svc.cluster.local:8080
curl: (35) error:1408F10B:SSL routines:ssl3_get_record:wrong version number

I am not sure about [4], this must be correct.

[1] https://doc.traefik.io/traefik/v1.5/configuration/backends/kubernetes/#tls-communication-between-traefik-and-backend-pods
[2] https://github.com/traefik/traefik/blob/master/pkg/provider/kubernetes/ingress/kubernetes.go#L596-L598
[3] https://github.com/kedacore/charts/blob/9be0a560a269502dde5db7683f62277592253cc2/http-add-on/templates/svc-interceptor-proxy.yaml#L21
[4] https://github.com/kedacore/charts/blob/9be0a560a269502dde5db7683f62277592253cc2/http-add-on/templates/svc-operator-metrics.yaml#L16


chore(main): release 3.2.0

New release!
3.2.0 (2023-05-15)
Features

plugin: lsp_signature (ca11c59)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/snelling-a/nvim/releases/tag/v3.2.0 :sunflower:


Research and define how can services  be linked to components

With https://github.com/redhat-developer/odo/pull/413  odo can create services.
But odo doesn't have an easy way to configure component so it is able to connect to the service.

Research what is the standard way to connect to services created from a service catalog and how we can implement it.
Define commands that will be used to connect services and components. We should use odo link command for it. Ideally, it should be as simple as running odo link mysql and odo link mysql --component mycomponent

This is an interesting command odo link  that you propose to use to update the supervisord's deploymentConfig in order to add as EnvFrom the secret containing the parameters of a serviceInstance
We have implemented successfully this use case with the function MountSecretAsEnvFrom( - see
From a functional point of view we do :

Search and get the DeploymentConfig to be enhanced
Add `EnvFrom <- Secret generated during service binding
Rollout the DeploymentConfig to have the Env vars available within the pod

The parameters that you should know will be the secretName created during binding step and the name of the deploymentconfig to be enhanced and optionally the namespace

Command developed and code implemented to check if a secret exists like the component and next to add the envFrom to the container of the application
see - https://github.com/redhat-developer/odo/pull/723/files#diff-6025e9b620e9321c03c11bf29e5c4dbdR1435

So the command could be
odo link <name_of_the_component> --secret <secretName>

The user doesn't have to know that it is a secret. From a users point of view, it should look like linking component to the service.
This might be better
odo link <component_name> --service <service_name>
On the background, it will be the same - finding the right Secret and injecting it to the component's DeploymentConfig.
We should also modify current odo link command that allows linking two components as odo link <component_name_1> <component_name_2> to odo link <component_name_1> --component <component_name_2>.
In general odo link command will have a following form odo link <target_component> --<link_type> <source_component>. Target component is optional and if not specified current component will be used.
Thoughts? @cmoulliard @jorgemoralespou

As the information which is needed to link the secret to an application is available from the serviceBinding resource
 oc get servicebinding/dh-postgresql-apb -o yaml
apiVersion: servicecatalog.k8s.io/v1beta1
kind: ServiceBinding
metadata:
  finalizers:
  - kubernetes-incubator/service-catalog
  generation: 1
  name: dh-postgresql-apb
  namespace: cmoullia
apb
  uid: 91ee39ba-c19f-11e8-98df-0a580a800110
spec:
  externalID: 91ee3941-c19f-11e8-98df-0a580a800110
  instanceRef:
    name: dh-postgresql-apb // NAME OF THE SERVICE INSTANCE TO LOOK FOR
  parameters:
    postgresql_database: my_data
    postgresql_password: secret
    postgresql_user: luke
    postgresql_version: "9.6"
  secretName: dh-postgresql-apb // NAME OF THE SECRET TO USE TO CREATE ENVFROM IN DC

, then we can adopt your proposition
odo link <component_name> --service <service_name>

@kadel
What --<link_type> do you envision?

Also, AFAIK:

We should also modify current odo link command that allows linking two components as odo link <component_name_1> <component_name_2> to odo link <component_name_1> --component <component_name_2>

This is how it is defined now, not?
Usage:
  odo link <target component> --component [source component] [flags]

Examples:
  # Link current component to a component 'mariadb'
  odo link mariadb

  # Link 'mariadb' component to 'nodejs' component
  odo link mariadb --component nodejs

What --<link_type> do you envision?

for now --component and --service

This is how it is defined now, not?

Kind of, but I described it in the other way. (Changed source and target component)
In the current implementation, the env variables are injected into the source component.
In my comment, I expected that variables will be injected into <component_name_1> and<target_component>.
Now as I'm looking at this again, I'm a little bit worried that it might be a little bit confusing.
We are not doing a good job describing what is happening in link command, and what I'm describing might be even worse :-(
In all other components, we use --component flag to change a component that command is operation on (from the current one to something else). But what I described in link syntax is using this flag to select the component that information is taken from.

@kadel, not sure what is your concern. In odo everything we do without a specific "qualifier" should be in the context of the current component, hence current naming makes sense IMHO:

odo link --service bla means link current component to service bla.
odo link --service bla --component foo means link foo component to service bla.

Semantically is what/how you would read it. We could maybe change the  --service for --to-service to make it more clear.
Maybe I'm missing the point.

I think that the natural way to read the syntax of the command is from something to something else where the qualifier gives an indication about the type of info to be injected within the Deployment or DeploymentConfig

odo link --component bla --component foo : add service foo address  to component bla -> component-bla.service-foo.svc
odo link --secret bla --component foo : add secret bla to component foo
odo link --service bla --component foo : add secret bla as enfFrom of the service instance bla to component foo

@kadel, not sure what is your concern. In odo everything we do without a specific "qualifier" should be in the context of the current component, hence current naming makes sense IMHO:

@jorgemoralespou
My concern is how to specify when you want to link two components when you don't want to use the current component.
@cmoulliard showed that in his comment

odo link --component bla --component foo : add service foo address  to component bla -> component-bla.service-foo.svc

This command doesn't make sense. We wouldn't be to detect "direction" of the link.

We could assume that by default operates on components.
That would mean following:

odo link foo - create a link in the current component that points to foo component
odo link --service foo - create a link in the current component that points to foo service
odo link foo --component bar - create a link in bar component that points to foo component
odo link --service foo --component bar -  create a link in bar  component that points to foo service

But that looks a bit weird :-(
What if we use --to-component and --to-service

odo link --to-component foo - create a link in the current component that points to foo component
odo link --to-service foo - create a link in the current component that points to foo service
odo link --to-component foo --component bar - create a link in bar component that points to foo component
odo link --to-service foo --component bar -  create a link in bar  component that points to foo

It makes it longer but on the other hand, it makes it clear what is a direction of the link.

I see now.
To me your first implementation doesn't look weird, as the tool is to develop the innercycle or local iterative cycle, which means that a component is the center and front of the tool and everything works on the scope of a component as there is where you'll be putting your code, etc...
We're sometimes biassed by what can be done with openshift, but I think it's important to constrain what we're doing to the current scope, meaning that it's not a deployment tool, it's not an architecture tool, it is a tool to work on code in an interative way. Which means that this use case should be the simpler one.
In any case, I'm fine with other's point of view. I wouldn't reject the second notation, but to me, that one looks more complex/weird :-D
@mjelen @gshipley do you guys want to comment?

I like the 2nd one - clarity beats length - though, I would use from rather then to, or specifically

odo link --from-service mysql - links mysql to current component
odo link --from-service mysql --to-component wordpress - links mysql to wordpress component

odo link --from-service/--from-component=source [--to-service/--to-component=target]

@marekjelen what is from and to? which one is the consumer side and which one is the producer side? In your example, from means the producer side, while in @kadel example to means the producer side, which means that this notation could be confusing, IMHO
And what about consistency with all the other commands. Isn't that important?

@jorgemoralespou every time when there is to/from involved it can be confusing ;) Also what's a producer side? The side getting the credentials? If it gets credentials shouldn't it be receiver and so the side providing the credentials to be a producer?
The function of the link command can be understood in two ways

linking something to my component (e.g. from mysql to my wordpress component)
linking my component to something (e.g. from my wordpress to mysql)

The ambiguity is the main reason why I would rather avoid using from and to, and just stick to what we're using in the other components.

I agree with you. In other commands, we use current component, or component specified by --component flag. And we should follow that here.
The problem is that we have two types of link. One that link component to component and one that links component to service (and in future, there might be more).
For me, the question is how to translate those two types into the link command.
I think that we should have flags that determine if we are linking with service or component.
This is why I proposed --to-service and --to-component. We can try to find better names, something that doesn't have to or from. But we can't use simply --service or --component  as --component is already there.

Can you then provide some examples like a definition of the syntax of the command proposed including latest remarks such --to-service, --to-component ? @kadel

@jorgemoralespou one more point to your list - you can have 2 verbs to separate the use-cases ... e.g. link for services and bridge for components

My 2 cents:
I believe that linking a component to a service should be the only option. As a new comer to odo but as a developer who has been banging with k8s / openshift for quite a while, I find it surprising to have a 'link' between 2 components - services should play this role.
So I would propose:
odo link foo - Links the current component to the foo service
odo link foo --component bar - Links the bar component to the foo service.

@kadel I agree with @geoand and I think that until there is a standard way to define how a component could be linked to another component, we should go this route.
In the future, I would expect though, to be able to define a way to connect to a component, like a binding in a service, and then be able to link to that component by injecting the binding to my component. Sadly, that's not possible today.
I wouldn't go that far as it doesn't make sense, as I think it does, but we should also be aware of the technical challenges.
Maybe we should think a way of creating the binding, so that we can either link to a service and to a component, as if they were a service anyways, as to be honest, linking what it does is injecting a binging into a deployment. We might need to think how to create a binding from a component.

Cool! I will do that as part of #723 if you don't mind
On Mon, Oct 15, 2018, 14:27 Tomas Kral<EMAIL_ADDRESS>wrote:

OK, It makes sense.
Let's do it this way. Let's change odo link to link component with
service only.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/redhat-developer/odo/issues/652#issuecomment-429813904,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AELBv1Ae4nuLgPGKOeQON1kIkLN4SFkQks5ulHEQgaJpZM4WDw_H
.

I also agree on @geoand's s proposition.
Remark : We need a technical document referencing the use cases that we would like to address with the link command like also to discuss the syntax to be adopted for the command or k8s modificitions

I really like this proposal since it unifies the approach and also feels like the proper k8s solution!
Furthermore I agree that the first pass should perhaps exclude the --map, although it should definitely be added later on.
I'm going through the existing odo code ( since I am still new to this codebase :) ) to see what's required to implement it, but so far I don't see any pain points arising

I started playing with this and seems straightforward.
The only complication I see is with the case where the service exposes
multiple ports.
Hopefully I will have something pretty complete on Monday so we can discuss
on something concrete.
On Fri, Oct 19, 2018, 16:23 Tomas Kral<EMAIL_ADDRESS>wrote:

+1
Yes, let's not complicate the first iteration with --map, it would be
better to add that later on.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/redhat-developer/odo/issues/652#issuecomment-431361670,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AELBvyI5dcnHwg7XXKvnmnXcB0z3ghbkks5umdJmgaJpZM4WDw_H
.

The only complication I see is with the case where the service exposes multiple ports.

Ah, completly fogot about that. That might get a little bit tricky.
Do we really need to store port in the Secret?
The user will know what port should be used (it is displayed during component creation, and we should show it in odo describe). The user then can use odo config to create an environment variable with that information.
But I guess this is not that user friendly :-(
Or we could add  optional --port flag for odo link.  New Secret would be created for each component port.  --port would control which secret will be injected.
--port would be only required if the component that we are linking to has multiple ports.
Example:
odo create java backend --port 8080,9090
# two secrets created (for example backend-8080 and backend-9090)

odo create nodejs frontend
odo link --to-component backend --port 8080
# injects Secret backend-8080 to the frontend component

I really like the --port idea!
We can even fail the command when the port is not part of the s2i image.
I propose we proceed with that idea
On Fri, Oct 19, 2018, 21:18 Tomas Kral<EMAIL_ADDRESS>wrote:

The only complication I see is with the case where the service exposes
multiple ports.
Ah, completly fogot about that. That might get a little bit tricky.
Do we really need to store port in the Secret?
The user will know what port should be used (it is displayed during
component creation, and we should show it in odo describe). The user then
can use odo config to create an environment variable with that
information.
But I guess this is not that user friendly :-(
Or we could add optional --port flag for odo link. New Secret would be
created for each component port. --port would control which secret will
be injected.
--port would be only required if the component that we are linking to has
multiple ports.
Example:
odo create java backend --port 8080,9090
two secrets created (for example backend-8080 and backend-9090)
odo create nodejs frontend
odo link --to-component backend --port 8080
injects Secret backend-8080 to the frontend component
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/redhat-developer/odo/issues/652#issuecomment-431452720,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AELBv4Wp1rQ7RalGfru38BMREJlN9YQ-ks5umhd6gaJpZM4WDw_H
.

which secret

Remark: this is not a base64 string which is injected from a k8s secret key but instead a string which is associated to an Env variable [1]. That should be clear and well documented for the developer although this is not the case if you look to the output of the odo link -h command.
I propose to mention that we inject the object's value (where object could be a port, service, ...) as an env variable. Why, developers must know how their code could then use/consume such info.
[1] https://goo.gl/AGz8jo


Reactivate KaaS e2e tests

Related to the https://github.com/SovereignCloudStack/cluster-stacks/pull/177

was re-enabled in different PR


Proposal: StartSpan with functional options

Can I keep working on this? I need this change earlier this week.

Yeah I will be flying now for the next million years 😞 (until Tuesday
afternoon)
On Mon, Apr 16, 2018 at 7:49 PM JBD<EMAIL_ADDRESS>wrote:

Can I keep working on this? I need this change earlier this week.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/census-instrumentation/opencensus-go/pull/696#issuecomment-381691191,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAVT6DnahrFexNolMp550vHx6bsU8hgJks5tpNm3gaJpZM4TQs4r
.

No worries, safe flights :)


Don't use Synchronization.Atomic for deliverExpectationCheckedEvents.

This PR replaces the new use of Atomic<Int> with a Locked<Int> in the implementation of deliverExpectationCheckedEvents. Why? Because we're running into some environments where the Synchronization module isn't available (e.g. older host macOSes) and this is simpler. The performance profile is comparable: on my system, running the repeatedlyExpect() test takes 0.55s instead of 0.49s to call #expect() 1,000,000 times, so it's still a significant win over the implementation we had earlier.
Checklist:

[x] Code and documentation should follow the style of the Style Guide.
[x] If public symbols are renamed or modified, DocC references should be updated.

@swift-ci test


Renamer does not use sorttitle field in movie

What TMM version are you using?
2.7.4 (2016-04-01 19:01) on Linux Mint 17.3 (64-bit) Kernel 3.19.0-32-generic
release, pre-release, nightly, or directly from GitHub/branch?
Release
What is the actual behaviour?
TMM movie renamer was set to use folder name as "$2/$E ($Y)". The movie title, sorttitle, and original title are start with different characters. When use a rename function on tool bar. TMM replaces $2 with the first character from title (removing a/an/the) instead of using that of sorttitle. The behaviour also observed when rename movie files.
What is the expected behaviour?
When rename function is executed, TMM should:

check if sorttitle is not empty. If it's not empty, replace $2 with the first letter in sorttitle
if sorttitle is empty, read the title and create sorting title from title. and then replace $2 with the first character from generated sorting title.

Steps to reproduce:
1 In settings -> movies -> renamer, define folder name as "$2/$E ($Y)"
2 find a movie, and enter names of the title and sort title so that they start with different character. For example, Title="First Love" Sort Title = "A Little Thing Called Love"
3 click "rename" button to let TMM rename it.
4 read the folder name from media files tab. The topmost folder name will be "F", not "L"
The issue can be reproduced every time. If the $2 variable is applied to file name, it will exhibit the same behaviour.
Additional
Have you attached the Logfile from the day it happened?
Your Operating system? (win/mac/linux? version?)

No log files attached
Operating system is Linux Mint 17.3 (based on Ubuntu 14.04 LTS) x86_64 Kernel 3.19.0-32-generic. The system is using KDE 4.x as desktop environment.

$2 is not for the sorttiltle but for the title sorting (I know - weird names, but how should we name it?)

sorttitle is an extra field mainly using for sorting the movie inside Kodi (and also for movie sets)
title sorting is the title without leading A, The, Der, Die, Das ...

So the logic is working as "designed", but not as expected by you..
Why would you need the first letter of the sorttitle in the renamer?

I have some odd naming films (non-english films) which don't started with English characters but I want them the be grouped using English pronunciation. At the moment, It use the first characters in whatever languages the files are named, which sometimes are not even alphabets.
My work around is to write the title the way I want file names to be first; then run renamer; and change it to the correct, non-english names.
Since this is a designed behaviour, I guess it is trivial issue. Let's move on and doing something more important like major bugs and raising kids, then. :)
And, if I forgot in my reply mail, thank you for making such  a great software.


Add the possibility to keep one free core

Seems that on a windows computer taking all the cores is not a good idea because it slow down too much the computer.
Would be nice to add an option:
minFreeCore
So that we could keep one free core if we want.

In the meantime such an option can be used
{maxWorkers : Math.max((navigator.hardwareConcurrency || 1 )-1, 1)}


nixos/cockroachdb: add extraArgs and properly escape shell args

Description of changes
There are a bunch of args to cockroach start that simply can not be set
given the current set of options, so this escape hatch enables their use.
I noticed that the module currently does not escape shell args, which seems like an oversight,
so I fixed it.
However, this is technically a breaking change if people were previously being naughty and passing extra args by abusing the lack of escaping.
I made that change a separate commit so I can drop it if it should not get merged.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Ping maintainers
@thoughtpolice

Yikes, the escapeShellArgs change actually breaks the module, and the test didn't catch it because it's disabled in CI due to lack of precision clocks. Marking this as a draft again until I figure out the fix.

Turns out empty pairs of quotes on the command line are not that good. Fixed that, now nixos/tests/cockroachdb.nix passes for me :)


npm install pdf-viewer-reactjs neither yarn add pdf-viewer-reactjs working

I am using Windows 10 and VS code

Running npm install --save string_decoder or yarn add string_decoder worked for me

Working on updates and fixes, I will release a new version soon

I think would be worth if you create some issues and improvements on the Issues tab and we could help, what do you think? :)

I think would be worth if you create some issues or improvements on the Issues tab and we could help, what do you think? :)

Yes that will help, will do that.

@sanchitwakekar Could you please check if its fixed in the latest update

closing the issue as npm/yarn install is working in windows 10


Steve feedback v2

wtf I don't know why git does this sometimes. It's showing all the commits in steve-feedback-v2 rather than just the diff...

oooh you squashed, I see. That's totally reasonable; it does keep main history clean :+1:

Superseded by https://github.com/Delta456/svelte-color-generator/pull/3


allow local images to be used for TileOverlays

Issue #934
I haven't tried building on iOS yet - so it may already work there. I didn't see anything in the iOS code that restricted the url type.
Here a pull request for my changes to the Android code.

Thanks. I'll check this and iOS later.

The next version allows to use local images for TileOverlay class.
I don't merge your pull request into the current master, but thank you anyway.


Replaces K8s NewDeltaFIFO with NewDeltaFIFOWithOptions

Replaces NewDeltaFIFO() in the k8s pkg with NewDeltaFIFOWithOptions().
Fixes: #25596

/test

cc: @christarazi

/test-vagrant

@joamaki PTAL when you have a moment.

@joamaki this should be a pretty quick review. Do you have time to take a look this week? If not, can you suggest others that can help?

@christarazi when you have a moment, do you mind reviewing or assigning another maintainer to review?


Please add a an open source license to this project

Dear @vinga , @mrlund  and @jaccurekx  ,
I really like your project and made a fork just a few moments ago. Could you please explain what people are allowed to do with your code by adding a license to the README.md? For instance, am i allowed to use the code as a starting point for my own ideas/projects?
Here is a nice website that can help you choose a license. https://choosealicense.com/
Edit: I see in the package.json that the intended license is MIT. https://github.com/kameocode/shadowow/blob/master/package.json
Is this still the case?

Yes, I've added also MIT license file to root directory in #6

thank you @vinga


Chart Explore: Pasting text into Metrics fails and deletes other metrics

Pasting text into Metrics fails and deletes other metrics. This feature is commonly used if metrics are long - user finds them in documentation / from a colleague (via slack) / from previous chart - instead of typing the metric name user wants to paste it. This functionality worked at some point in the past.
Expected results
Existing metric remain, and newly pasted metric (if exists) also is in the Metrics field.
Actual results
Existing metrics disappear.
Screenshots
Step 1: There is some metric in the METRICS field.

Step 2: try to paste new metric, like "test_metric"
Step 3: All metrics disappear. Regardless of if metric that is being pasted exists or not.

How to reproduce the bug

Go to 'Chart Explore'
Click in 'Metrics field'
Paste name of a metric, for example try to paste 'test_metric'
See issue - all existing metrics disappear

Environment
(please complete the following information):

superset version: master

Checklist
Make sure these boxes are checked before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

@zuzana-vej could you please provide a gif that shows the old behavior? do you think #11388 are caused by a same PR?

I can't provide video of old behavior (when pasting a metric into the box worked) because old behavior doesn't work right now (honestly I am not sure how long this has been broken, this might not be feature user uses every day, so it could be couple weeks).
I think they certainly touch the same component, so the regression is likely to be introduced when doing some redesign/changes to the Metrics box.

Can you assign me please?

Can you assign me please?

added to Trello and assigned to you~

tested~fixed.  closing issue thanks! @kgabryje


Updated region list

Updated region list from https://docs.oracle.com/en-us/iaas/Content/General/Concepts/regions.htm, and sorted them in alphabetical order.

Closing, region changes contained here: https://github.com/oracle/oci-grafana-metrics/pull/126


[MALFUNCTION] Service stopped working after update

I attempted update of the service as described in README.md , after wich it stopped trading.
Log output:
[ec2-user@ip-172-31-25-255 trader]$ poetry run autonomy analyse logs --from-dir trader_service/abci_build/persistent_data/logs/ --agent aea_0 --reset-db
--- aea_0 ---
[2024-06-18 13:45:45.926000][WARNING] The same event 'Event.FETCH_ERROR' has been found in several apps:
<class 'packages.valory.skills.decision_maker_abci.rounds.DecisionMakerAbciApp'>
<class 'packages.valory.skills.market_manager_abci.rounds.MarketManagerAbciApp'>
It will be interpreted as the same event. If this is not the intended behaviour, please rename it to enforce its uniqueness.

[2024-06-18 13:45:45.937000][WARNING] The same event 'Event.FETCH_ERROR' has been found in several apps:
<class 'packages.valory.skills.decision_maker_abci.rounds.DecisionMakerAbciApp'>
<class 'packages.valory.skills.market_manager_abci.rounds.MarketManagerAbciApp'>
It will be interpreted as the same event. If this is not the intended behaviour, please rename it to enforce its uniqueness.

[2024-06-18 13:45:45.993000][WARNING] The kwargs={'mech_request_price': None, 'mech_chain_id': 'ethereum', 'mech_wrapped_native_token_address': '0xe91D153E0b41518A2Ce8Dd3D7944Fa863463a97d', 'mech_to_subscription_params': [['base_url', 'https://marketplace-api.gnosis.nevermined.app/api/v1/metadata/assets/ddo'], ['did', 'did:nv:0ea01d5de3b34e3792db825f2a5f5595c393c68b19fd5efdacd00fcc63a53483'], ['escrow_payment_condition_address', '0x9dDC4F1Ea5b94C138A23b60EC48c0d01d172629a'], ['lock_payment_condition_address', '0xDE85A368Ee6f374d236500d176814365370778dA'], ['transfer_nft_condition_address', '0xbBa4A25262745a55f020D0a3E9a82c25bb6F4979'], ['token_address', '0x80A9b55F8604acC26dF2Ac6e07F9dC5B0eAa05Ce'], ['order_address', '0xc7751eff5396a846e7bc83ac31d3cb7d37cb49e4'], ['nft_amount', '100'], ['payment_token', '0x0000000000000000000000000000000000000000'], ['order_address', '0xc7751eff5396a846e7bc83ac31d3cb7d37cb49e4'], ['price', '1000000000000000000']], 'file_hash_to_strategies_json': [['bafybeihufqu2ra7vud4h6g2nwahx7mvdido7ff6prwnib2tdlc4np7dw24', ['bet_amount_per_threshold']], ['bafybeihcly4lt4pqiqhj3kndxitts5yzby77525v4elii23k6skcnbedu4', ['kelly_criterion_no_conf']]], 'strategies_kwargs': [['bet_kelly_fraction', 1.5], ['floor_balance',<PHONE_NUMBER>00000000], ['bet_amount_per_threshold', {'0.1': 0, '0.0': 0, '0.3': 0, '0.2': 0, '0.5': 0, '0.4': 0, '0.7':<PHONE_NUMBER>0000000, '0.6':<PHONE_NUMBER>0000000, '0.9':<PHONE_NUMBER>000000000, '0.8':<PHONE_NUMBER>00000000, '1.0':<PHONE_NUMBER>000000000}]]} passed to params have not been set!

[2024-06-18 13:45:46.186000][INFO] HTTP Server has connected to port: 8000.

[2024-06-18 13:45:46.508000][INFO] Connecting to libp2p node acn.staging.autonolas.tech:9005. Attempt 1

[2024-06-18 13:45:49.916000][INFO] Successfully connected to libp2p node acn.staging.autonolas.tech:9005

[2024-06-18 13:45:49.920000][INFO] Entered in the 'registration_startup_round' round for period 0

[2024-06-18 13:45:49.922000][INFO] Start processing messages...

[2024-06-18 13:45:49.923000][INFO] Entered in the 'registration_startup_behaviour' behaviour

[2024-06-18 13:45:49.924000][INFO] Synchronizing with Tendermint...

[2024-06-18 13:45:52.953000][INFO] local height == remote == 2; Synchronization complete.

[2024-06-18 13:45:52.954000][INFO] Sharing Tendermint config on start-up?: False

[2024-06-18 13:45:53.180000][WARNING] Slashing has not been enabled!

[2024-06-18 13:45:53.181000][INFO] 'registration_startup_round' round is done with event: Event.DONE

[2024-06-18 13:45:53.181000][INFO] Entered in the 'check_benchmarking_mode_round' round for period 0

[2024-06-18 13:45:53.184000][INFO] Entered in the 'check_benchmarking_mode_behaviour' behaviour

[2024-06-18 13:45:54.197000][INFO] 'check_benchmarking_mode_round' round is done with event: Event.BENCHMARKING_DISABLED

[2024-06-18 13:45:54.198000][INFO] Entered in the 'update_bets_round' round for period 0

[2024-06-18 13:45:54.201000][INFO] Entered in the 'update_bets_behaviour' behaviour

[2024-06-18 13:45:54.201000][WARNING] No stored bets file was detected in /root/agent/bets.json. Assuming bets are empty.

[2024-06-18 13:45:54.272000][ERROR] Could not parse the response body!

[2024-06-18 13:45:54.273000][ERROR] Response: ""

[2024-06-18 13:45:54.273000][ERROR] Could not get questions from omen

[2024-06-18 13:45:56.361000][ERROR] Could not parse the response body!

[2024-06-18 13:45:56.362000][ERROR] Response: ""

[2024-06-18 13:45:56.362000][ERROR] Could not get questions from omen

[2024-06-18 13:46:00.445000][ERROR] Could not parse the response body!

[2024-06-18 13:46:00.445000][ERROR] Response: ""

[2024-06-18 13:46:00.446000][ERROR] Could not get questions from omen

[2024-06-18 13:46:08.518000][ERROR] Could not parse the response body!

[2024-06-18 13:46:08.519000][ERROR] Response: ""

[2024-06-18 13:46:08.519000][ERROR] Could not get questions from omen

[2024-06-18 13:46:24.613000][ERROR] Could not parse the response body!

[2024-06-18 13:46:24.613000][ERROR] Response: ""

[2024-06-18 13:46:24.614000][ERROR] Could not get questions from omen

[2024-06-18 13:46:56.718000][ERROR] Could not parse the response body!

[2024-06-18 13:46:56.719000][ERROR] Response: ""

[2024-06-18 13:46:56.719000][ERROR] Could not get questions from omen

--- End ---
[ec2-user@ip-172-31-25-255 trader]$

Also, attaching the output of trades
trades-7.txt
command

@mkuzmentsov does this happen when using an API key for the graph?

@Adamantios yes, when I upgraded the service using instructions, it asked me to provide one, so I provided the key. Also, what I noticed, I tried also recreating service from the scratch, I then copied existing folder with keys to new instance, ran the service, but it didn't ask me to provide the key again.

OK, I see it's set in .trader_runner/.env

@Adamantios you gave me a clue, I created account at https://thegraph.com/ and created an API Key, BUT I didn't notice it used different address, which is NOT agent's address.
I recreated the API key by logging in with my agent's address and it's back in business now.
Thank you!
BTW, any readings on tips how to improve performance of trader service?

@mkuzmentsov I'm glad that it works now. The address that you are using to obtain the API key should not matter. I suspect that it was an issue with the subgraph's indexing. We are looking into solutions because currently the indexers of the graph network are not incentivized to index the omen subgraph and as a result, it is not always operational.
If you ever need to check the status of the subgraph quickly, you can navigate here.

BTW, any readings on tips how to improve performance of trader service?

The performance of the trader service depends mostly on the utilized tool (it selects the answer of the bet) and the strategy (it selects the amount of the bet). As a developer, one can improve the performance by implementing betters tools and strategies. As an operator, one can improve the trader by running it, because it learns how to select the best tools by assigning weights to them, based on the outcomes of the past bets.