Add Kafka topic encryption proposal

Regarding message keys, encryption is applied only to the record value, not the record key. As a result, there is no impact on compaction since message keys are not encrypted.
As an example of the record structure, the javadoc for the Kafka Produce message demonstrates key and value fields being discreet and distinct:
https://kafka.apache.org/10/javadoc/org/apache/kafka/clients/producer/ProducerRecord.html

@chris-giblin thanks for the clarification, I didn't see that spelled out in the propsal, did I miss it?

You are right @tombentley that is not spelled out in the proposal. Will gladly add that.

@tombentley it would be good to elaborate on potential race conditions. Is there an example we could begin with?

@chris-giblin I was thinking of things like:

Producer P1 sends message M1 via sidecar proxy using encryption key K1
Encryption key changes to K2
Producer P1 sends message M2 via sidecar proxy using encryption key K2
Producer P2 sends message M3 via its own sidecar proxy using encryption key K1, because for whatever reason it doesn't know about K2 yet.
Consumer sees enc(M1,K1), enc(M2,K2), enc(M3,K1)

But I guess this is pretty much what you already expected, and consumer can still obtain old keys from the key management system unless they were purposely deleted there. Which makes me wonder how the proxy should handle (at the protocol level) the case where it really doesn't and can't know the key.

@tombentley there many subtleties and options with key rotation, in part arising from Kafka being an immutable store. Starting with a simple case first, let's assume there is one proxy instance,  a sidecar sharing a pod with a kafka broker. It retrieves an AES key from a KMS such as Vault. We change keys and are now encrypting with k2. The topic in question now has a mix of messages in storage, encrypted by k1 or k2.  When decrypting, the proxy needs information on which key was used to encrypt it (we use the record headers to pass this metadata). Using this information, it retrieves the appropriate key, decrypts and forwards to the client.
Now onto the scenario you have described with multiple proxies in play. They would need to be linked into the same key service and be informed when a key changes. Agreed, it is possible for a variety of reasons why that not all proxy instances have switched at the exact same time. However, this does not pose a problem because, as you suggest,  all proxies rely on the encryption metadata in the message to retrieve the right key to use.
In the event the proxy cannot retrieve the key, be it for technical reasons such as network outage or an inconsistency, it should return an error message. This would mean supporting a new set of error conditions.

When decrypting, the proxy needs information on which key was used to encrypt it (we use the record headers to pass this metadata).

@chris-giblin If we are using record headers for this info, it means that we cannot encrypt headers of a Kafka message as I raised before.

@ppatierno Each record header is a name/value pair. We already address  potential collisions with the header names we use and those used by clients. Because we can discern between the two, we can control that “our” headers are not encrypted.
A policy could contain an optional list of  names of headers to encrypt. It conceivably could contain a wildcard, '*', as well, indicating encrypt all headers. All except "ours" would be encrypted.
I agree, this should be clarified in the proposal. We will commit an update in the next 24 hours.

@ppatierno @tombentley I have committed updates to the proposal which clarify much of what we have discussed so far.

@tombentley @scholzj  We have updated the proposal with information on the following topics:

Key rotation
Mention removal of encryption headers from responses
Correct "no performance penalty"
Mention ApiVersions
SASL implications
Coordinating proxy and broker with advertising property
AES-GCM for initial version

@tombentley @ppatierno is there anything more you need from us to complete the review ?

@tombentley @ppatierno is there anything more you need from us to complete the review ?

@SeanRooooney @chris-giblin I think this PR needs a rebase because it has 16 files changed coming from other proposals (i.e. admin server UI, canary and so on).

@SeanRooooney @chris-giblin I think this PR needs a rebase because it has 16 files changed coming from other proposals (i.e. admin server UI, canary and so on).

I can do rebase while merging ... Do it for most proposals.
On Wed, Jan 13, 2021, 08:18 Paolo Patierno<EMAIL_ADDRESS>wrote:

@SeanRooooney https://github.com/SeanRooooney @chris-giblin
https://github.com/chris-giblin I think this PR needs a rebase because
it has 16 files changed coming from other proposals (i.e. admin server UI,
canary and so on).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/strimzi/proposals/pull/19#issuecomment-759256951, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABLFOR3MTRNZFCPDLAQBI6LSZVCLVANCNFSM4TUQR3IQ
.

I can do rebase while merging ... Do it for most proposals.
On Wed, Jan 13, 2021, 08:18 Paolo Patierno<EMAIL_ADDRESS>wrote:

@SeanRooooney https://github.com/SeanRooooney @chris-giblin
https://github.com/chris-giblin I think this PR needs a rebase because
it has 16 files changed coming from other proposals (i.e. admin server UI,
canary and so on).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/strimzi/proposals/pull/19#issuecomment-759256951, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABLFOR3MTRNZFCPDLAQBI6LSZVCLVANCNFSM4TUQR3IQ
.

I can do rebase while merging ... Do it for most proposals.

Thanks, much appreciated!

I can do rebase while merging ... Do it for most proposals.

Thanks, much appreciated!

@tombentley and @ppatierno : thank you for pointing out the corrections and improvements. Done.

@tombentley and @ppatierno : thank you for pointing out the corrections and improvements. Done.

@tombentley is there anything else you need from us for approval ?

@tombentley is there anything else you need from us for approval ?

@scholzj can you rebase or should we ?

I can do the rebase and rename the file etc. But I'm afraid I will need you to fix the DCO signoff :-/: https://github.com/strimzi/proposals/pull/19/checks?check_run_id=1704582165

I can do the rebase and rename the file etc. But I'm afraid I will need you to fix the DCO signoff :-/: https://github.com/strimzi/proposals/pull/19/checks?check_run_id=1704582165

@scholzj I am having difficulty with the sign-off. As per https://github.com/strimzi/proposals/runs/1823797785 I have:
git commit --amend --no-edit --signoff
git push --force-with-lease origin master
Opening the most recent merges, one sees Signed-off-by: C. Giblin<EMAIL_ADDRESS>yet the PR has a number commits with red crosses. I also tried signing off specific commits with:
git commit --amend -s -c 8103...
All this does not seem to result in the required sign-off(s).
Any suggestions how to resolve this?

@chris-giblin I set it to pass, renamed the file to match the latest proposal and merged it. So I guess next we should create the repository.

@scholzj are you going to create the repo ?

@SeanRooooney Sorry, I was off ... I have now created https://github.com/strimzi/topic-encryption


Update InstallCommand.php For Laravel 5

Due to laravel 5 new folder structure some changes made for console commands. Also it is not requried to dump-autoload due to new namespacing.

Sorry for the delay in getting back. I've merged your proposed changes (and some other needed to add L5 support) in master and 1.1.0 release.
Thanks.


Resolving annotation conflicts

Currently, if we apply two annotators which annotate the same element, both are added to the result. Stanford CoreNLP instead overrides the old annotation. Following this, I implemented a method that checks whether there already exist the same elements when adding XML elements. Such duplicate occurs, e.g., when running a joint parser of POS and tree after applying POS tagger.
I plan to push this modification but I was also wondering this overriding method is the best way to resolve conflicts. Maybe it's better also to output some warnings, but this may be future work.

Now CabochaAnnotator replaces the old annotations (chunks and dependencies) if exist.
https://github.com/mynlp/jigg/commit/323a3b0c8e20802e6fcd640a7f1070e1f35dfff5#diff-9b2b4b9eb3146599a3ce60c12afa4ddeR46

Another option:

add an option to remain the old annotations;
distinguish different annotations with the same tag using attribute.

Anyway, each annotation should have an attribute recording the used annotator, e.g.:
<tokens annotator="juman">...</tokens>
<tokens annotator="knp">...</tokens>

I've changed this behavior of cabocha in d17b7511251c21be2f9be0de812227d4375a6b97 to remain the old annotation, because now annotator name (cabocha) is recorded on every element.
It may be better to support some option to decide whether leaving or replacing the old annotation as in -knp.replaceJumanTokens.
Generally, remaining the same type of annotations with different annotators seems to make the lower-level processing a bit complicated, so the default behavior might be better to replace the old annotation.


Added: LeetCode Problems 100 - 199

For Example:

Resources and Guidance

Source code for demo:- 0000-0099.md
Preview on Browser:- .../dsa-problems/leetcode-problems/0000-0099

hey can i add further problems?

Yah sure

can you specify me till how much questions should i upload

hi @Ajay-Dhangar i'd love to work on this!!

It's Done. You can try other


docs: Updated README.md

Updated the Readme with Instagram and TikTok links.

- What I did
Added new links to the Readme file.
- How I did it
Verified the links and added them.
- How to verify it
To verify, it is better to search for @atsigntech in their respective platforms and cross verify the links.
- Description for the changelog
Added the new accounts of different platforms to Readme

Thanks @JustinBenito :)


Change request_ids to be uuids.  requestId must be under 40 character…

Change request_ids to be uuids.  requestId must be under 40 characters.  Using prefix+time can result in requestIds that are too long (i.e. authenticate_user_credential_20170118203).
I considered just shortening the prefixes, but the date string isn't necessarily unique if you're sending multiple requests per second

Let me know what you think here -- I'm happy to go remove all the prefixes from the code or add some logging in to get_request_id to log the prefix+timestamp and uuid to make finding them easier

@stuartparmenter Looks like a good change to me, the only thing may be to keep the prefix but shorten it. The concept behind the prefix was to make it easier when debugging to check what type of call was made when looking at the logs.

I'll update the PR to truncate the strings to make sure they fit.

On Feb 12, 2017, at 8:18 PM, Ryan Casler<EMAIL_ADDRESS>wrote:
@stuartparmenter Looks like a good change to me, the only thing may be to keep the prefix but shorten it. The concept behind the prefix was to make it easier when debugging to check what type of call was made when looking at the logs.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Make swimlanes selectable only from the edge

[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Is your feature request related to a problem? Please describe.
We work with swimlanes a lot. It happens quite often that we want to select objects inside the swimlane but select the swimlane by mistake.
Describe the solution you'd like
The problem would be solved, if swimlanes would only be selectable at the edges.

Is this with or without using a lanecolor (ie on mouse down or up)?

If lane colors are used, events can be disabled by unchecking Pointer Events under Properties in the Style panel.

Yes, we used lane colors in this specific example. Thanks for clarifying :D


MaterialMenu use on dynamic website

Overview of the Issue - if an error is being thrown a non-minified stack trace helps
Use of MaterialMenu in dynamic context I believe currently has a bug or needs a little documentation to clarify usage steps.
I'm not one 100% that I have the right approach but I am utilising componentHandler.upgradeElement on the ul element being used to store the menu.
On inspecting the DOM, it seems to be modified correctly as intended. However, the button used to open/close the menu seems to no longer be wired up. My assumption was that upgrade using MaterialMenu would search for the element with ID stated in the for attribute.
Is there a requirement to upgrade the button element also?
@jh3y

cc @jasonmayes @Garbee

Poking around some of the code and reading other issues, the following will make a menu work on a dynamic set up.
componentHandler.upgradeDom('MaterialMenu', 'mdl-menu');

Although not specific to the added element, it is a current work around for cases where the behaviour is breaking an application.

If you could provide a codepen of the exact setup that isn't working that would be great. It is kinda hard to walk through what the component handler is doing in different situations, especially with menu which I have yet to debug at all.

I've experimented further with the placement of where I am calling the upgrade and I can confirm that I've got it working now so will close the issue.
@jh3y

As a follow up, I believe in its current state if you are not using upgradeDom, then you would have to upgrade each.

You only need to upgrade the MaterialMenu element currently for it to work.
I think when needing to upgrade various elements, probably some kind of loop through an upgrade map could be a suitable solution or being able to pass in DOM fragments to upgradeDom.


Prepare for 4.8.0-m1 release

Prepare for 4.8.0-m1 release

Closing this, since already done via [1].
[1] https://github.com/wso2/carbon-kernel/pull/3433


Kafka Scaling Doc update

Updated Kafka Doc (version 1.4 to 2.1) Added note regarding maxReplicaCount and no. of partitions on a topic.
Fix: #322
Signed-off-by: Ritikaa96<EMAIL_ADDRESS>

@tomkerkhove @zroubalik PTAL

Thanks again @Ritikaa96!

@tomkerkhove changes made as per the comments. PTAL

LGTM, thanks a lot!
In meantime we have a v2.2 folder as well, are you able to update that one as well? If not, no worries because I can pick it up then!

Thanks @tomkerkhove , I'm surely able to update the v2.2 folder. I'll add it right now

@tomkerkhove PTAL

Thanks a ton @Ritikaa96!


Create rice_crop

Added rice_crop to the loot_table injectors for straw

Hello @Mat-a-tat,
Do not use loot table injector for something that is created by the mod. Create an issue about this bug, and I'll make it when I've the time.


Remove the extra " Page" part of the filename when adding pages

please use the user input to create folder name when adding pages instead of adding a " Page" at the end of user input.

And thanks for creating this useful extension <3

Ok am on this now.


Suggestion -  use modern c++

Maybe try rewrite the code in more modern c++ (or make another repository for this).
I didn't look through all the files but it seems that you are using c++98 and its very old c++ standart (try using at least c++11)

Would these changes make the code run faster or reduce the size of the executables?

Some of them actually will make it faster. For example, if you made linked list as a class (and not as global methods) than as part of adding constructors you could add move consturctor which in case you want to transfer ownership of the list to some other list is much faster than copying it. I know its not part of the data stracture implementation but the all point in making it in multiple languages is to show how to implement such things in different languages isn't it (and in such case I think it's important to use best practices when implementing it)?
Another example is using smart pointers like unique_ptr to handle ownership of memory in your code. While this won't make it faster (nor will make it slower) it will save you the need to delete all the allocated on the heap pointers and it will make the code more beautifull.

My recommendation is that we take an algorithm-by-algorithm approach to such a conversion where each pull request modifies only one algorithm and demonstrates that the algorithm is faster, easier to understand, or generates less code than the current version.  Side-by-side benchmarks are much appreciated to demonstrate the efficacy of the new approach.

with the new versions of C++ i observed one thing, earlier i was using C++14 to write codes for codeforces and Codechef problems and on submissions those codes are takiing memory of about 15M but when i compiled those same codes using -std=c++17 flag the memory consumed is decreased to 5M,
i think it will be a good idea to use the C++17 standard

I would like to work on it. Please assign this to me.

Please read CONTRIBUTION.md.  This repo does not assign tasks to people.  Instead it accepts pull requests.

still my pull request for #789  is not accepted. How I'm Supposed to contribute further, As per rule one cpp change per commit.

I think this can be closed now. The C++ standard for compilation, etc have been standardized for each and every file and tested on three platforms.
C++11, though old, allows to implement the algorithms from the repo directly on small microcontrollers running on RTOS and not relying on linux or other larger OS kernels.


Report repeated queries

Your tool seems fantastic to me, but in order to optimize data access through the django ORM, I miss a report on the number of queries that are repeated, since this may be indicative of not having used a select related, prefetch related , or some mistake such as a queryset within a for loop.
I have been using django-queryinspect https://github.com/dobarkod/django-queryinspect, which has been very useful for this purpose, but silk provides many other interesting tools, the ideal would be to have the best of both worlds.
As an advance in terms of analysis, I have seen how it could be carried out using a fork and / or a contribution, but I have been limited by the fact that the SQLQuery#query attribute already has the SQL formatted with the parameters already evaluated (usually ids), which makes it difficult to detect repeated queries. For example, if we have stored:
SELECT * FROM foo WHERE id = 42
SELECT * FROM foo WHERE id = 43

It makes it more difficult to detect repeated queries than if we had stored (in another attribute of the SQLQuery object for example), the query without evaluating:
SELECT * FROM foo WHERE id =?
SELECT * FROM foo WHERE id =?

Before thinking on my own a solution to this need, I would like to know what your opinion is about this feature. Thank you!

I've been testing it and it looks very nice. Thank you!


Handle all commands in comms module

Good catch, yeah I think you're right. I believe we could still run into
portability issues because of endianess even using memcpy - what do you
think?
On Tue, Apr 14, 2020 at 5:52 AM Justin Lebar<EMAIL_ADDRESS>wrote:

@jlebar commented on this pull request.
In controller/src/command.cpp
https://github.com/RespiraWorks/VentilatorSoftware/pull/80#discussion_r407850681
:

+*  @param
+*  @param
+*  @return
+****************************************************************************************/
+static float convIntTofloat(char *data) {

union {

 float f;

 unsigned char byte[4];

} conv;

conv.byte[0] = data[0];
conv.byte[1] = data[1];
conv.byte[2] = data[2];
conv.byte[3] = data[3];

return conv.f;

FYI, using unions for type punning is not legal C or C++. It's undefined
behavior (compiler can do anything) that is actively exploited by the
compiler, unless we build with -fnostrict-aliasing.
memcpy is the only safe way to type pun in C/C++.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/RespiraWorks/VentilatorSoftware/pull/80#pullrequestreview-392586026,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEXLVLG6FYMM6ETO4GC4BWLRMPMYBANCNFSM4MHHKAMA
.


GetStateUp not working

Hello,
The return value of GetStateUp is always as same as GetStateDown. Should the function call in 1033 line in SteamVR_input.cs must be modified into GetStateUp?

Ack, good catch! Sorry about that, we'll get that fixed in the next version.

Thanks again. Released version 2.3.2 with this fix.


Added web3swift in Blockchain from @BANKEX

Project URL

https://github.com/BANKEX/web3swift
Category

Blockchain
Description

Swift implementation of web3.js functionality zap
Interaction with remote node via JSON RPC thought_balloon
Smart-contract ABI parsing book
Interactions (read/write to Smart contracts) arrows_counterclockwise
Local keystore management (geth compatible)
Why it should be included to awesome-ios (optional)
Blockchain applications are hot now, This library provides swift interface with web3 js for iOS developers.
Checklist

[x] Only one project/change is in this pull request
[x] Addition in chronological order (bottom of category)
[x] Supports iOS 9 / tvOS 10 or later
[x] Supports Swift 4 or later
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

          1 Warning

:warning:
Found 6 link issues, a project collaborator will take care of these, thanks :)

Link issues by awesome_bot

Line
Status
Link

25
302
https://twitter.com/awesome_ios redirects tohttps://mobile.twitter.com/awesome_ios

3066
302
https://twitter.com/maxdesiatov redirects tohttps://mobile.twitter.com/maxdesiatov

3079
302
https://twitter.com/objcio redirects tohttps://mobile.twitter.com/objcio

3080
302
https://twitter.com/CocoaPods redirects tohttps://mobile.twitter.com/CocoaPods

3081
302
https://twitter.com/CocoaPodsFeed redirects tohttps://mobile.twitter.com/CocoaPodsFeed

3082
302
https://twitter.com/RubyMotion redirects tohttps://mobile.twitter.com/RubyMotion

  Generated by :no_entry_sign: Danger


Chicago-Kansas City Expressway & Ave of the Saints Shields

Two shields missing in the Midwest are the Chicago-Kansas City Expressway and the Avenue of the Saints. I put them together because both route shields are typically placed either instead of or above their direction blade above the numbered route shield. In the case of the CKC, it is always related to Route 110 (MO/IL), so it should be fairly simple to add to its existing numbered shield if we choose to follow this formatting. Avenue of the Saints does not always follow a consistent numbered route, so this may need to be rendered as a separate shield entirely.

Do we know what the existing state of the tagging is for these routes?

MO/IL 110 are tagged as CKC Expwy as part of their route designation (Missouri / Illinois relations). If it needs a separate relation, I can add that.
Avenue of the Saints is also High Priority Corridor 2. Can it be attached to that or does it need its own relation?

In the case of the CKC, it is always related to Route 110 (MO/IL), so it should be fairly simple to add to its existing numbered shield if we choose to follow this formatting.

So far, in cases where a route is coextensive with another route, we display the shields separately. Examples include U.S. 1–9 in the Northeast and various toll roads. Other styles might generally combine concurrencies into a single shield, but this is a stylistic optimization that shouldn’t affect tagging.
I think we may eventually need to consider adding the capability to render dual shields for a single route (such as for #464), but in this style would still look like two shields rather than a single combined shield.

Avenue of the Saints is also High Priority Corridor 2. Can it be attached to that or does it need its own relation?

If it has a separate identity, it should have a separate relation, even if the geometry is identical.

I will get those two relations created over this weekend and post back here when it is complete.

Both relations are created. Still need to expand CKC through Illinois and expand AotS through...well, basically everything except the interchange with CKC. I'll try to finish that tomorrow, but might be later this week. But they are created and therefore can have shields assigned!
CKC relation
AotS relation

AotS relation is complete from the Minnesota border south to its terminus in St. Louis. I did not extend it north of the Minnesota border because it is not signed in Minnesota. I believe that is the proper protocol, but feel free to correct me if I am wrong.
Should have CKC done by the end of the weekend at the latest.

Got other work done faster than expected, so I was able to finish the CKC relations as well! Both are ready and waiting for their shields!

I was linked to this thread and I had a couple ideas.  Would it make things easier to consider AOTS and CKC like a business route as far as displaying shields goes?  CKC you could probably get by with displaying the text CKC over a MO/IL 110 shield.  At minimum, the same could be done for AOTS.  I've attached a banner that could be used in place of text.  The logo is in the PD thanks to an interesting court case a few years ago.  I've stripped out the words and made the fleur-de-lis larger.

Would it make things easier to consider AOTS and CKC like a business route as far as displaying shields goes?

The code to draw the business route banners only accepts plain text at the moment, but a similar treatment would make a lot of sense for Avenue of the Saints due to the shield’s shape. The CKC shield would also benefit from appearing atop the Route 110 shield, whereas OpenMapTiles currently would sort the CKC shield after the Route 110 shield.
https://github.com/ZeLonewolf/openstreetmap-americana/blob/efff6cdecf68504a02b1343ddc760327f416616f/shieldlib/src/shield_text.mjs#L282-L331
It would be feasible to draw an image in the same spot, but this will require introducing a new option alongside banner inside shield definitions. Another consideration is that anything larger than plain text would exacerbate #340.
Perhaps we could tentatively land the CKC and AOTS shields as-is while we figure out how to lay them out more accurately.

MoDOT’s official state maps mark the Avenue of the Saints with a simple ⚜:


Adding needed setup for building images locally.

Using insecure local registry for building openstack service images
via openstack-helm-images which internally uses loci image building
mechanism. Loci requirements image pull has a bug that's why needed
insecure registry for image building.
For consuming images by k8s artifacts in cassp cluster, publishing
local images to a secure registry server. In image building step,
secure registry server replaces insecure one once image building
step is done.
For using locally build images in osh deploy, set environment variable
to OSH_BUILD_LOCAL_IMAGES=TRUE
Fixed issue of helm update when helm server is already running.
Added upstream reviews in dev-patcher for keystone and nova-placement
api service which has changes related to apache configuration. Issues
were identified as result of image verifications and adding override
value for using apache2 with suse image.

Needs rebase!

It seems that we need to add SLE12-utilities repo for gnu_parallel, see https://github.com/SUSE-Cloud/socok8s/blob/master/playbooks/openstack-osh_hostconfig.yml#L29

On Tue, 2019-02-12 at 14:28 -0800, rajdharwadkar wrote:

rajdharwadkar commented on this pull request.

@@ -0,0 +1,16 @@
+---

+- name: Stop and remove local insecure docker registry

shell: |
docker stop {{ local_registry_name }}
docker rm {{ local_registry_name }}

+- name: Clean docker insecure setting in docker daemon

file:
state: absent
path: "/etc/docker/daemon.json"

Is this been tested ? because I got it working by updating
/etc/sysconfig/docker file . and my deployer is sles12sp3 not sure if
that matters.

The recommended deployer node is Leap or SLE 15.
That might have an impact on the docker version you are using.

Because this was lagging behind, and was increasingly conflicting, with no updates, I have updated my PR which splits this into multiple commits, and separate concerns better.
I believe we should keep this PR for two reasons:

It contains changes that are still not present in other repos, and are not explained (so there is probably a lesson to learn there!)
It contains an image building exercise with the application of upstream patch 633847.

I believe we could resolve the conversations that are fixed in different PRs, not focus on this PR's code but on its reasons, and document it in the PR.

@kantarun is this still valid or van be closed?

It can be closed.


cleanup(build): cut down the number of shared libraries

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap-engine-udig

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:
We're shipping many tiny shared libraries, which isn't really helpful (they're too small to be valuable on their own). Convert them all to static libraries which are then linked directly into libscap.so (for a shared library build).
While I was here:

clean up the scap_engine_savefile build (it's now simply a static library)
clean up modern_bpf libbpf handling (we always have the libbpf target nowadays)
fix libbpf and libelf so they can be linked properly (libbpf is statically linked anyway but needs -fPIC, libelf can be dynamically linked)

Which issue(s) this PR fixes:

Fixes #1201
Fixes #1202
Special notes for your reviewer:
With this PR, I can successfully build a shared library with all the engines: -DUSE_BUNDLED_DEPS=Off -DBUILD_SHARED_LIBS=On -DENABLE_PIC=On -DUSE_BUNDLED_VALIJSON=On -DUSE_BUNDLED_LIBBPF=On -DBUILD_LIBSCAP_MODERN_BPF=On -DBUILD_BPF=On -DBUILD_DRIVER=On -DCREATE_TEST_TARGETS=On
Note 1: looks like Ubuntu 22.04 has a vastly different libbpf API so I need to use the bundled one in all cases
Note 2: why do we have a separate option for ENABLE_PIC? (do we want to be extra clean and use it to conditionally enable -fPIC for libelf?)
Does this PR introduce a user-facing change?:

cleanup(build): scap_platform_util, scap_event_schema, driver_event_schema, scap_engine_util, scap_engine_noop and scap_platform are no longer separate shared libraries

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: gnosek
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [gnosek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cc @dkogan maybe this helps with the Debian build? It will probably need some massaging to backport to 0.11.x but I can help if needed
cc @geraldcombs does this help with the shared macOS build?

Sigh. Right. We need ENABLE_PIC whenever we build shared libs.

Oh. I left a debug msg in. Will remove it once the CI passes (I want to see if -fPIC works now first)

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, gnosek
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,gnosek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 8a31c34a22cc9b430ebfcba9bd8985367ff53c91

/hold

/hold

New changes are detected. LGTM label has been removed.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, gnosek
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP,gnosek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: f8d33a3034eff7b9128a831063d705c3203fecea

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, gnosek
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP,gnosek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/unhold

cc @geraldcombs does this help with the shared macOS build?

It does, thanks! I had to update the way we build our pkgconfig linker flags (#1222) but everything works here otherwise.


Statsd global prefix

Add global prefix for all statsd metrics
Description:
For now, we have the only option to send all metrics with 'envoy.' prefix. But it will be useful to have an option to send all metrics to special branch, for example, 'resources.envoy...'

@Lookyan flagging this as help wanted for now, but were you planning on picking it up?

If somebody wants to do it, it will be perfect. Otherwise I'll come back to it in following 2-3 months.

I can work on this


[WIP] Add docs target to ALL if doxygen is available

@sirpalee I'm trying the CMake  and suggestion improvements as it goes. It is still [WIP], but that way I show you what I am changing, just in case you are working on the same things at the same time.

Make the docs target optional and conditional on the presence of Doxygen. This fixes an install issue where installation would fail if the build was not run with build_all
Remove build_all target, in favor of default build target

It builds, but I cannot run your dev @sirpalee: it fails with
00:00:00   527MB ERROR   | [gpu] Unable to load Optix library, NVIDIA driver 390.48 is either too old or missing the Optix library (CPU-rendering with Optix GPU-denoiser)
Current upstream master branch f1d3f7e7e7ee802bc440bee20ec9c0f2162248d9 does build (abuild) and run correctly.

@charlesfleche yeah, that's probably due to the work I started on using the OptiX denoiser for the beauty. I'll check on using some Arnold API to determine if a supported GPU/driver is available, but I'll have to ask for your help to test is, as I can't go back on driver versions.
If the documentation is enabled (there is a flag in options.cmake to turn it off), I prefer throwing and error rather than a message and returning from the function. That's better than showing a message that people easily miss and then they can't figure out why the documentation is being generated.
I'll get back to you on build_all and adding doxygen to ALL, I had some inconveniences in my current development workflow when doxygen was added to ALL (I'm using CLion) it always ran even if I built a single target. I'll do some research on what's the canonical way of running doxygen.
Thanks for the suggestions and feedback!

I added a new take on generating doxygen documentation. My main concern was that custom targets are always out of date. (see The target has no output file and is always considered out of date even if the commands try to create a file with the name of the target.) This means if we add the doxygen command to ALL, doxygen always runs unless the user explicitly sets BUILD_DOCS to OFF.
I found a workaround. I'm adding a custom command (where dependencies are taken into account), and adding a custom target that depends on the output of my custom command. (the index.html in this case) My custom command depends on the markdown files and I glob the header files from the project. This way doxygen is only regenerated when there is a change to doxyfile, any of the markdown files or any of the header files.
While globbing files is generally frowned up in cmake, luckily we have a new flag (another reason to bump up to 3.12), CONFIGURE_DEPENDS, which will trigger a rebuild when the list of files changes.
I think this approach solves my issue of always rebuilding the documentation and your issue of the documentation not being part of the all target. What do you think?

I've never tried it, but maybe we could use doxygen_add_docs ? I'd expect this function to prevent unecessary doc rebuilds.
https://cmake.org/cmake/help/v3.9/module/FindDoxygen.html#command:doxygen_add_docs
Available in CMake >= 3.9, though.

@charlesfleche yeah, that's probably due to the work I started on using the OptiX denoiser for the beauty. I'll check on using some Arnold API to determine if a supported GPU/driver is available, but I'll have to ask for your help to test it, as I can't go back on driver versions.

Sure, whatever you need.

@charlesfleche I checked the source of doxygen_add_docs and it's just using an add_custom_target. That'll have the same issue of always being out of date.
For now, I'm going to go with the current solution, and use a mix of an add_custom_command and add_custom_target. I'll see if there are ways to simplify the code though.

@charlesfleche I changed how the optix denoiser filters are created and they are now optional. Can you please check ae736c1bbc5d2d9ca064e6e040e198c799ce9e3a ?

Can you please check 0baa374 ?

It works !

What should we do with this PR ? What about reverting the Doxygen related patches, keeping the ones that remove build_all, and upgrade find_package(PythonLibs) to the more modern FindPython ?
Or trash this PR entirely ?

I'm having an hard building with CMake for Houdini, I can't find the right CMake variables to set to find boost. Would you mind to share the CMake command you run to build with this configuration ? Thanks.

I'm fine with going to the new FindPython, I doubt are losing any functionality. I would keep the build_all target, simply for the sake of my workflow, since it doesn't affect anything.
Here is my config of building for Houdini 18.0.247
-DARNOLD_LOCATION=/home/sirpalee/apps/arnold-<IP_ADDRESS>
-DUSD_LIB_PREFIX=libpxr_
-DUSD_INCLUDE_DIR=/opt/hfs18.0/toolkit/include
-DUSD_LIBRARY_DIR=/opt/hfs18.0/dsolib
-DBUILD_USE_CUSTOM_BOOST=ON
-DBoost_INCLUDE_DIRS=/opt/hfs18.0/toolkit/include/hboost
-DBoost_LIBRARIES=/opt/hfs18.0/dsolib/libhboost_python.so
-DTBB_FOUND=ON
-DTBB_INCLUDE_DIRS=/opt/hfs18.0/toolkit/include
-DTBB_LIBRARIES=/opt/hfs18.0/dsolib/libtbb.so
-DCMAKE_INSTALL_MESSAGE=LAZY
-DCMAKE_INSTALL_PREFIX=/home/sirpalee/dist/arnold-usd-houdini

I've removed the doxygen and build_all related patches. I'd however suggest that the build_all may be confusing as the usual ALL target is supposed to be the well known equivalent.
The new patches replace find_package PythonLibs by Python2, which better allow to build against a custom python. And I've updated the document with some cmake examples.


Module 1.4 Assignment

Oddly enough no matter how I create my branch commit and checkout I always end up with master down and new-feature up. I don't think it changes anything :)


It would error if you didnt have the lsb-release command, fixed it by using cat /etc/os-release with AWK

thanks


authenticate status call with auth token header (when exists)

The call to https://api.lbry.tv/api/v2/status gets made without a header so it checks a random SDK. If a user is authenticated, it should pass their token so it checks the right SDK.

This will ensure the right SDK is being checked so the user knows there may be some issues/slowness.


Dependencies

The code should depend on Scipy version >= 1.8.0 in order to use the elliprj function (https://docs.scipy.org/doc/scipy/reference/generated/scipy.special.elliprj.html) which was introduced in this version.

I was installing it today with pip on a mac and it did not upgrade my older version of scipy. When I ran import kerrgeopy I got an error about the ellipjr function not being defined which suggested I upgrade scipy when I looked at the documentation. The solution was to manually upgrade scipy and then everything worked.

That’s interesting. I just tested this in a new environment and pip did update scipy automatically as expected, so I think this may be something specific to your local environment. For now, I’ve added a note about this to the installation instructions in case anyone else runs into the same problem. I was wondering if you happen to still have the terminal output from running pip install kerrgeopy, or if you are able to replicate the issue.


develop on CDN

http://beta.mathjax.org/mathjax/develop/unpacked/MathJax.js
is a copy of today's develop branch. Let's switch the demos over please. (I keep running into rawgit issues).

Closed by #31


fix: Add new release pipeline with production template

Details
Added new yml file for production release using production template and EnableSemanticRelease variable. Also moved the common code between CI and release pipeline to common template.
The new release pipeline will be added mseng ADO as it requires access to key vault for getting github and npm publish tokens.
To create pipeline in mseng ADO, yaml file should be available in main branch so I will create and test the new release pipeline after merging this PR.
Motivation

Context

Pull request checklist

[x] PR title respects Conventional Commits (starts with fix:, feat:, etc, and is suitable for user-facing release notes)
[x] PR contains no breaking changes, OR description of both PR and final merge commit starts with BREAKING CHANGE:
[n/a] (if applicable) Addresses issue: #0000
[n/a] Added relevant unit tests for your changes
[x] Ran yarn precheckin
[n/a] Verified code coverage for the changes made

/azp run

:tada: This PR is included in version 2.11.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Afis module is missing

Hi,
The "asv-drones" project cannot be build, because the Asv.Drones.Gui.Afis module is missing from the solution.
Thanks

Hi.  This project is a proprietary plugin for the program. We are still developing the core of the program, so we have made several configurations for debugging plugins and libraries for ease of debugging. You can just switch to the develop branch and debug configuration. This configuration ignores any projects with plugins and should build.  We will be glad to help you if you fail.

Hi,
Absolutely clear, thank you very much!
According to the information you provided, everything is already working.


Nil pointer exception: certificateRef and TLS can now be left empty

In #4290, I discovered that using a Gateway with an empty certificateRef field would yield a nil pointer exception. I added a couple of unit tests along the way.
Fixes #4290.
Fixed a bug in the "gateway shim" controller that was causing the cert-manager controller to crash
with a nil pointer exception when using the annotation "cert-manager.io/issuer" on a Gateway that
had an empty `tls` block or with `certificateRef` left empty.

/kind bug

/lgtm

/test pull-cert-manager-bazel

/test pull-cert-manager-bazel

It looks like we have some flakiness due to the order of events:
I0803 17:14:34.151059 3741895 reflector.go:225] Stopping reflector *v1.Certificate (10ms) from pkg/mod/k8s.io/client-go@v0.21.2/tools/cache/reflector.go:167
--- FAIL: TestSync (0.14s)
    --- FAIL: TestSync/gateway-shim (0.14s)
        --- FAIL: TestSync/gateway-shim/if_a_Gateway_contains_two_listeners_with_different_Secret_names,_it_should_create_two_Certificates (0.13s)
            sync_test.go:2450: got unexpected events, exp='[Normal CreateCertificate Successfully created Certificate "foo-example-com-tls" Normal CreateCertificate Successfully created Certificate "bar-example-com-tls"]' got='[Normal CreateCertificate Successfully created Certificate "bar-example-com-tls" Normal CreateCertificate Successfully created Certificate "foo-example-com-tls"]'

If you want to reproduce it, you can run:
go test ./pkg/controller/certificate-shim/ -run TestSync/gateway-shim/if_a_Gateway_contains_two_listeners_with_different_Secret_names,_it_should_create_two_Certificates -count 20

As @irbekrm suggested, we should use EqualUnsorted instead of EqualSorted to check the events. As @jakexks mentioned, we should not expect events to arrive in the order they are sent.

Aah I think the reason is not the order of events!
It is due to the fact that we store Gateway TLS stuff into a map in sync.go:
tlsHosts := make(map[corev1.ObjectReference][]string)
for secretRef, hosts := range tlsHosts {
    // Undeterministic order!
}


Update nf-credentialprovider-icredentialprovidercredentialevents-oncr…

…eatingwindow.md
Simple typo

@skbellevue : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Docs for reusable components

relates to #265 and #272
quote from @fschmenger in #265:

First of all I think we need an anchor for documenting reusable components / Wegue API - as all the documentation so far is mostly app-config related. My proposal would be to introduce something like reusable-components.md. We can then use this as the anchor for e.g. ModuleCard or MapOverlay documentation (see #269). Also all the Wegue templates (AppTemplate, AppFooter etc.) with their respective customization options and slots might go in there.

We could get this started partially for some components (ModuleCard, MapOverlay). For the AppTemplate related stuff I think it's worthwhile to wait until #276 is implemented.

I gave this a first draft within #269 to document the MapOvelay class. I tried to mimic the documentation structure of the vuetify UI components, which usually consist of several sections per component (e.g. Props, Events, Slots) and some separated examples.
For a first shot this is just a hardcoded documentation. Since the section will be all about components, it would be nice to come up with a Doxygen like solution, so the documentation lives in the code. There seem to be projects on the web that support vue / vuetify, but I didn't look into those so far. If you have any preferences, let me know.


Web Interface: Default printer should be more visible

After selecting a printer as default printer by clicking "Set as Default" in the web interface it is difficult/unintuitive for users to see which of the printer is actually the default printer. I also had to look twice until I have seen that the "Set as Default" of my selected default printer has gone away.
There should be more visible than only a missing "Set as Default" button. Either the printer marked with the words "Default Printer" somewhere easily visible or at the top of the list "Default Printer: ...".

[master d493c5e] Add indicator for default printer (Issue #182)


fyne-cross does not respect vendoring

Hi,
we're using fyne for our cross-platform Android factory image flasher (https://github.com/AOSPAlliance/device-flasher)
I noticed that fyne-cross builds the application even when there are missing dependencies in vendor (go build fails).
Wanted to ask if this is expected and what should be done.
Thank you

fyne-cross uses by default go modules, and the expected behaviour should be the same as reported here: https://golang.org/ref/mod#vendoring
@Uldiniad could you please report some info that could help to debug like the command executed, the error you're getting, OS ecc ?
I did a quick test building locally your project and I'm getting the following error against android:
gitlab.com/calyxos/device-flasher does not import "github.com/fyne-io/mobile/app"
Extract of the debug output is:
fyne-cross android -debug
...
fyne cli version v1.4.0
/usr/bin/docker run --rm -t -w /app/. -v /code/lucor/device-flasher:/app -v /home/lucor/.cache/fyne-cross:/go -e CGO_ENABLED=1 -e GOCACHE=/go/go-build -e fyne_uid=1000 fyneio/fyne-cross:android-latest /usr/local/bin/fyne package -os android -name device-flasher -icon /app/fyne-cross/tmp/android/Icon.png -appID device-flasher
gitlab.com/calyxos/device-flasher does not import "github.com/fyne-io/mobile/app"

As additional notes:

the apk seems correcly produced under the project root
building against linux do not report any error

/cc @andydotxyz
@Uldiniad please note that the docker base image ships with go 1.13

the tools is meant to run on desktop operating systems, I'm compiling on windows but we the tools is released for darwin, linux and windows targets. thanks for the note on the go version in the docker image.
From golang documentation, "If the vendor directory is present in the main module's root directory, it will be used automatically if the go version in the main module's go.mod file is 1.14 or higher. To explicitly enable vendoring, invoke the go command with the flag -mod=vendor. To disable vendoring, use the flag -mod=mod."
Is it possible to pass -mod=vendor to fyne-cross somehow?

it is not possible to specify the -mod at the moment.
Anyway the issue seems not related to the vendor folder stuff (i.e. removing it go should automatically download all the dependencies) but to the build tag GUI specified into the gui.go and cli.go files.
Removing it from the gui.go file and updating the one into the cli.go file like // +build cli should allow the compilation and you'd find a device_flasher.apk file under your project root.
Please note that you'll get an error like:
[✗] rename /path/to/device-flasher/device-flasher.apk /path/to/device-flasher/fyne-cross/dist/android/device-flasher.apk: no such file or directory

but this is a different bug: the tool is expecting device-flasher.apk but fyne cli generate it as device_flasher.apk

Hi, I am one of the developers working on device-flasher

it is not possible to specify the -mod at the moment.

:( Any ideas if it'll be supported in the future?

Anyway the issue seems not related to the vendor folder stuff (i.e. removing it go should automatically download all the dependencies) but to the build tag GUI specified into the gui.go and cli.go files.

This is exactly what we want to avoid, we specifically vendored the dependencies.
I had a hack in mind involving the -cache option - pointing that to a directory in our source, and then replicating the vendor structure there to make it use those. It'd still download anything missing, but at least it'd use what we already have.

Removing it from the gui.go file and updating the one into the cli.go file like // +build cli should allow the compilation and you'd find a device_flasher.apk file under your project root.
Please note that you'll get an error like:
[✗] rename /path/to/device-flasher/device-flasher.apk /path/to/device-flasher/fyne-cross/dist/android/device-flasher.apk: no such file or directory

but this is a different bug: the tool is expecting device-flasher.apk but fyne cli generate it as device_flasher.apk

GUI tag works fine for windows/darwin/linux with both go build and fyne-cross
It's meant to install an OS on Android devices, but it won't work on Android itself, so we aren't building it for android - which is why the apk build was having issue earlier / why we aren't importing mobile/app from the earlier comment.

Basically, the way testing this is:

make - works (This calls go build with the correct options)
fyne-cross windows -tags "GUI" - works (and for darwin / linux too)

Now, for testing, rm -rf vendor/golang.org - just a directory we picked inside vendor

make - fails (since it can't find packages)
fyne-cross windows -tags "GUI" - still works, since it downloads any missing dependencies like you mentioned earlier.

That last part is what we want to avoid, if possible.

@chirayudesai thanks for the additional details, they helped to understand your use case.
wrt the android issue it is related to how fyne-cross works under the hood.
To compile and generate the apk, it uses the fyne cli tool.
This tool at the moment does not allow to specify any build tag so basically the gui.go file with the "GUI" build constraint is ignored but some of the fyne deps are still compiled due to the GOOS=android constraint hence the warning/error.
As temporary workaround, until the fyne tool is updated, you'd change the build constraints with something like below:

cli.go -> // +build !GUI,!android
gui.go -> // +build GUI android

@chirayudesai thanks for the additional details, they helped to understand your use case.

Glad to hear that. Hope we can figure something out about vendoring.

wrt the android issue it is related to how fyne-cross works under the hood.
To compile and generate the apk, it uses the fyne cli tool.
This tool at the moment does not allow to specify any build tag so basically the gui.go file with the "GUI" build constraint is ignored but some of the fyne deps are still compiled due to the GOOS=android constraint hence the warning/error.
As temporary workaround, until the fyne tool is updated, you'd change the build constraints with something like below:

cli.go -> // +build !GUI,!android
gui.go -> // +build GUI android

Gotcha. We don't compile for android though, so this is not an issue for us at the moment, but it's useful info for anybody else who hits this, and also if we do another project in the future.
Thanks for your super prompt responses!

I'm a little confused about this - if the project does not want to use modules when building then why have a go.mod file?
Is this because there are local modifications committed to the vendor folder perhaps?

I'm a little confused about this - if the project does not want to use modules when building then why have a go.mod file?
Is this because there are local modifications committed to the vendor folder perhaps?

We want to use modules, but we don't want to download them during build-time. We'd like to have our 'vendor' directory created using go mod vendor be used instead. There are no local modifications there (and won't be), we just run go mod vendor to populate it and then commit that.
I think that trying go 1.14 or higher inside the container might work, given how that's supposed to use vendor automatically. See https://golang.org/ref/mod#vendoring

The version landed in devolop supports tags and allows to specify env vars with = chars.
The following should work now:
fyne-cross linux -tags GUI -env "GOFLAGS=-mod=vendor"

Tested the PR https://github.com/fyne-io/fyne-cross/pull/14 and it does resolve this issue

Features released in 1.0.0, going to close the issue. Feel free to re-open if you find any issue.

Features released in 1.0.0, going to close the issue. Feel free to re-open if you find any issue.

Thank you, it works well!

Features released in 1.0.0, going to close the issue. Feel free to re-open if you find any issue.

Thank you, it works well!

I'm a bit confused by this too.
I'm running:
$ fyne package -os ios -appID com.example.fybro -icon Icon.png
github.com/andydotxyz/fybro does not import "github.com/fyne-io/mobile/app"

How is one suppose to use and import github.com/fyne-io/mobile/app?

Actually nevermind. Lock this issue.
Problem: Had an old version of fyne (the cli) installed
$ fyne version
fyne cli version v1.4.2

Updated to v2.1.4 with:
$ go install fyne.io/fyne/v2/cmd/fyne@latest
$ fyne version
fyne cli version: v2.1.4

And packaging now works! 🥳


Move std::thread_local::* into std::thread

Propose moving the contents of std::thread_local::* into std::thread
Rendered

+1 to std::thread_local -> std::thread::local.
Though this is a breaking change, it is also a small one, and if I am reading #911 correctly, then there may be breaking changes to std::thread_local (specially s::t::Key)  anyway.

Good idea.

Both std::thread::local  and std::thread::tls are good places.

tls is an initialism that expands to thread_local_storage, so it'd be a little funny, one could read it as std::thread::thread_local_storage.
On std::thread::local : are we really sure that the only thing that will ever be local to threads is storage? And does local actually describe what we're using? (local is an adjective in it's usage in tls, storage is a noun)

This is a great idea! The fact that thread_local ended up as a separate top-level module was mostly an accident of stabilization history.
A submodule called local is a reasonable idea; I want to chew on it a little bit more. But strong :+1: to merging in some fashion.

@jmesmon When people talk about "thread locals" (note here local is used like a noun), I tend to assume that they are referring to "thread local storage/variables", though technically there are other things that are local to threads. So I am fine with std::thread::local.
Also, I believe we can "repurpose" the module a bit, and actually put other thread local entities inside std::thread::local if we want to.

Since there's very little in thread_local today, I wonder if we could instead import the contents with a prefix: LocalKey and ScopedKey perhaps?

@aturon, LocalKey and ScopedKey are good names. I do wonder if we have plans to add things to std::thread_local/std::thread::local? If not, then we can deprecate std::thread_local and move the two types to std::thread.

@carllerche Can you update the RFC with the LocalKey and ScopedKey proposal? It was discussed by the core team today and is otherwise ready to be accepted.

This RFC, which is a minor organizational tweak, has been approved. The final decision was to use LocalKey and ScopedKey; I updated the RFC accordingly (as per @carllerche's request on IRC).
Tracking issue


chore: remove linter and test calls from pipeline

The sdk generator will do linter and tests individually without breaking the pipeline on the first issue

we can also remove the make lint and make test from the Python SDK steps on the same pipeline below

we can also remove the make lint and make test from the Python SDK steps on the same pipeline below

I've removed the python lint & test as well


Data manipulation in Wiki no links?

Data manipulation
I want to know How to filter an array using an array?

Hmm. The links where working previously...
https://github.com/agershun/alasql/wiki/How-to-filter-an-array-using-an-array

The links are still broken:

I'd make a pull request but unfortunately it's not possible for wiki pages.

Links fixed.

Thanks a lot!


Lol

What is this pain
Lol

#if SOL_IS_ON(SOL_INSIDE_UNREAL_ENGINE_I_)
#ifdef check
#pragma push_macro("check")
#undef check
#endif
#endif // Unreal Engine 4 Bullshit

#if SOL_IS_ON(SOL_COMPILER_GCC_I_)
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wshadow"
#pragma GCC diagnostic ignored "-Wconversion"
#if __GNUC__ > 6
#pragma GCC diagnostic ignored "-Wnoexcept-type"
#endif
#elif SOL_IS_ON(SOL_COMPILER_CLANG_I_)
// we'll just let this alone for now
#elif SOL_IS_ON(SOL_COMPILER_VCXX_I_)
#pragma warning(push)
#pragma warning(disable : 4505) // unreferenced local function has been removed GEE THANKS
#endif                          // clang++ vs. g++ vs. VC++

Have you ever heard of hacks to enable a library to work across different platforms/dependencies etc...?
This is nothing special, unless you were triggered by a word.
Please keep the issue tracker exclusively for issue/discussions.


Fixed names of TRUE, FALSE and NULL constants

See https://3v4l.org/A6El3

Actually this 3 ones are magic in php. You can use them in any case (e.g. tRuE or nuLL).
I'm personally 👎 on this change.

@b1rdex Yes, it works because of the third parametr of function define. However the right names are uppercased.

Thank you for the investigation.
Although formally you are correct, I agree with @b1rdex at this one - these constants are case-insensitive.
Also I don't see how this change will improve PhpStorm code analysis.

@wbars This PR (and my others) helps using this repository as composer package, mostly currently in https://github.com/Roave/BetterReflection
BetterReflection is used in https://github.com/humbug/php-scoper
PHP-Scoper is used in https://github.com/humbug/box
And Box is used to creating PHAR for tools like PHPUnit, PHPStan etc.
So it will really help PHP ecosystem :)


[1.10-rc1] "name is reserved" when multiple links are defined with the same alias

docker version:
Client:
 Version:      1.9.1
 API version:  1.21
 Go version:   go1.4.3
 Git commit:   a34a1d5
 Built:        Fri Nov 20 17:56:04 UTC 2015
 OS/Arch:      darwin/amd64

Server:
 Version:      1.10.0-rc1
 API version:  1.22
 Go version:   go1.5.3
 Git commit:   677c593
 Built:        2016-01-15T18:17:17.209731962+00:00
 OS/Arch:      linux/amd64

docker info:
Containers: 96
Images: 30
Server Version: 1.10.0-rc1
Storage Driver: aufs
 Root Dir: /mnt/sda1/var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 226
 Dirperm1 Supported: true
Execution Driver: native-0.2
Logging Driver: json-file
Kernel Version: 4.1.15-boot2docker
Operating System: Boot2Docker 1.10.0-rc1 (TCL 6.4.1); master : c4985d5 - Fri Jan 15 19:29:39 UTC 2016
CPUs: 1
Total Memory: 996.2 MiB
Name: 1.10.0-rc1
ID: 5FI2:BCQZ:BB7O:3EOF:B4OB:NNHW:32UJ:UG22:G66I:JTFB:STWC:MH4Z
Debug mode (server): true
 File Descriptors: 27
 Goroutines: 45
 System Time: 2016-01-19T11:09:10.738547534Z
 EventsListeners: 0
 Init SHA1:
 Init Path: /usr/local/bin/docker
 Docker Root Dir: /mnt/sda1/var/lib/docker
Username: aanand
Registry: https://index.docker.io/v1/
Labels:
 provider=virtualbox

Provide additional environment details (AWS, VirtualBox, physical, etc.):
VirtualBox boot2docker VM created with the following command:
docker-machine create -d virtualbox --virtualbox-boot2docker-url=https://github.com/tianon/boot2docker-legacy/releases/download/v1.10.0-rc1/boot2docker.iso 1.10.0-rc1

List the steps to reproduce the issue:
$ docker run -d --name upstream-a busybox top
$ docker run -d --name upstream-b busybox top
$ docker run --link upstream-a:upstream --link upstream-b:upstream busybox cat /etc/hosts

Describe the results you received:
Error response from daemon: name is reserved

Describe the results you expected:
Contents of hosts file (as happens on Engine 1.9.1)
Provide additional info you think is important:
This error is returned when I try and create multiple links with the same alias. Arguably, users should never do this, but unfortunately Compose has been doing it for years.
Engine's previous behaviour was that one link would win out - if I run those commands against Engine 1.9, upstream-a seems to win every time, but I don't imagine it matters which one wins.
We can (and probably should) fix it in Compose of course, but that won't help people who, for whatever reason, are stuck with an older version of Compose and a newer version of Engine. So depending on how hard it is, it'd be preferable to have it fixed in Engine.

This really should have errored in prior versions of Docker too... and when I say "should" I mean, based on the old code path I'd expect an error in this case... but there were also some race conditions around name registration that masked errors before as well.
I'm not sure that we can really change this as link names (on the default bridge network) are used as container references and must be unique... so one can lookup a container by /.
With user-defined networks it's no problem as link names are not used as container refs.

I've added this to the milestone since this is a change in behavior since 1.9 and we should decide if we need to handle this case.

Note that this does seem to work with a custom network (and DNS based resolution);
docker network create foozbar
docker run -d --name upstream-a --net foozbar busybox top
docker run -d --name upstream-b --net foozbar busybox top

docker run --net foozbar --link upstream-a:upstream --link upstream-b:upstream ubuntu ping -w 4 upstream
PING upstream (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from upstream-b.foozbar (<IP_ADDRESS>): icmp_seq=1 ttl=64 time=0.171 ms
64 bytes from upstream-b.foozbar (<IP_ADDRESS>): icmp_seq=2 ttl=64 time=0.152 ms
64 bytes from upstream-b.foozbar (<IP_ADDRESS>): icmp_seq=3 ttl=64 time=0.134 ms
64 bytes from upstream-b.foozbar (<IP_ADDRESS>): icmp_seq=4 ttl=64 time=0.157 ms
64 bytes from upstream-b.foozbar (<IP_ADDRESS>): icmp_seq=5 ttl=64 time=0.184 ms

--- upstream ping statistics ---
5 packets transmitted, 5 received, 0% packet loss, time 3997ms
rtt min/avg/max/mdev = 0.134/0.159/0.184/0.021 ms

@thaJeztah Yes, that's expected. User-defined networks don't have the same semantics, and aren't registered as actual links.


Fix merge conflict with branch-22.08

Fixes the merge conflict reported in #6295.  GpuParquetScan.getParquetOptions takes an extra readDataSchema argument in 22.10 and thus had a context conflict with the revert of binary Parquet changes recently in #6292.
NOTE: This must be merged with a merge commit, not squashed!

build


vendor k8s.io v0.19.5

Description

kubernetes/kubernetes#95981 had been backported to 1.19.5.  This fixes a long standing issue with the golang client.
https://github.com/coreos/flannel/issues/1380
Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

None required

I tried the same thing and the build is passing: https://github.com/coreos/flannel/pull/1384 we will just merge that one and close this. @rajatchopra


DBZ-4316 Updated functional ci jobs to work with new downstream source archive

https://issues.redhat.com/browse/DBZ-4316

@jpechane, that's for you :)


Integrate Browserify into Mailman

http://browserify.org/

integrate-browserify branch in coe-google-apps-support/Mailman

This also includes setting up Gulp to work with browserify.


Registration page button type is wrong.

Summary
Button type in register.tsx should be submit. Currently set to type button and does not allow users to register an account.
Steps to reproduce

Go to register page.
Enter user registration information.
Try to submit the form.

A link to a reproduction repository
No response
What OS are you using?
Windows
Your next.config.js file

`next.config.js`
# Paste content of your `next.config.js` file here. Check there is no private info in there.

Builds logs (or link to your logs)

Build logs
# Paste logs here

Function logs

Function logs
# Paste logs here

Same issue.


Revert "Translate 2019-03-07-raw-block-volume-support-to-beta.md"

Reverts kubernetes/website#23060

The previous merge generated 18 commits, which is terrible.


stm32: clock_control: Driver overhaul

In order to driver future evolutions (mainly support for alternate clocks, cf https://github.com/zephyrproject-rtos/zephyr/pull/42097), revise stm32 clock_control driver implementation.
This change is adapted from what was done initially on H7 driver (cf https://github.com/zephyrproject-rtos/zephyr/pull/41585) and extended to other series (common and U5 clock_control drivers). Only MP1 is left aside for now
Mainly, two changes are done:

Break down sysclock initialization in elementary steps easily configurable by device tree
Introduce new bus clock bindings which simplify _on and _off implementation and will be (easily ?) reused for reset control

Based on #44291, which allow to verify no regression is introduced.

Is the stm32f1 really different from the stm32f0 or stm32f3 : except the prediv which is fixed to 2 in case of pll source HSE, could both config_pll_sysclock functions clock config be factorized ?

There's actually one part of the F1 (!SOC_STM32F10X_DENSITY_DEVICE) which is compatible with one part of the F0/F3 (!RCC_PLLSRC_PREDIV1_SUPPORT). So putting them together will allow to factorize those, but we'll need to make 3 different configuration live in one single file. I don't see it as much more simple in the end.

PR is ready for merge, but set as DNM as I will be awk next week and since there is some risk involved for such a change, I prefer it is merged when I am nearby for the after sale support.

Noted, but please notice that this needs a rebase anyway

@nordic-krch could you please take a look?


After 1.1.5 update plugin not working

Hi,
after the update to 1.1.5. errors appear: class/Resizer.php at row 637 - regarding the return type void not being correct. I had to quickly revert back to 1.1.4, because I installed on a production page, so i don't have the exact error message.

Same here, quite critical issue.

Hi guys, fixed - sorry about that.
I really need to figure out a proper way to introduce unit tests to CI :thinking:

@bradietilley Tried 1.1.6 on a test site and it seemd to work. Gonna try a production page soon, will report if it's ok.


fix(cql_auth_data_source): make datacenter feature work

Closes #118
Both example and documentation tell to use datacenter = ...
https://github.com/scylladb/terraform-provider-scylladbcloud/blob/895264835e1ffc64b9ffcd35e50b019fadd5e257/examples/data-sources/scylladbcloud_cql_auth/data-source.tf#L2-L5
While definition has only datacenter_id https://github.com/scylladb/terraform-provider-scylladbcloud/blob/272231752bc100bac5bed861a2f7673333a77afd/internal/provider/cql_auth_data_source.go#L23-L57

Hi @dkropachev
Thank you for your PR. We value your contribution but must consider backward compatibility. Unfortunately, the proposed changes, such as renaming, removing, or adding new attributes, have led to issues as seen in recent bug reports.
To ensure stability for our users, we cannot merge these changes. We encourage exploring alternative solutions that maintain compatibility. Your efforts are appreciated, and we look forward to more contributions.
Best,


chore(deps): sylius 1.12 compatibility

Hi !
This is an attempt to make this plugin compatible with Sylius 1.12.
The changes in src/Controller/Admin/ReportsController.php were necessary since Symfony 6 InputBag now does not accept non-scalar values for its get() method. I believe my changes should still be compatible with older versions of Symfony.
I hand-tested the functionality and it seems to work, but I am not too sure that the automated tests you provide will pass, since a lot of dependencies in require-dev seem outdated. If you want me to update them as well I can give it a try, but I prefered to wait for your opinion on the matter  :)
Admin display

Thank you @JacquesDurand 🚀


Unwrap header safely when validating response.

When the Sec-WebSocket-Accept header is missing in the response, the app crashes due to an unwrapped nil value. With this pull request, the header is safely unwrapped and the app will not crash but simply disconnect.
The header can be missing when some proxy between the client and server eats this header (for whatever reason).

Good point and nice catch. Thanks for the PR, I appreciate it.


⚠ Bofrost.de has degraded performance

In f17ef45, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 774 ms

Resolved: Bofrost.de performance has improved in 47d2aec after 40 minutes.


Import Solution with support for deployment settings

Hi,
when I can see support for an extended version for importing solutions supporting deployment settings? Only Azure DevOps support deployment settings.

@DanielSaager
The Deployment settings feature is a feature of the PowerPlatform CLI, which uses this library already.
There is preprocessing that needs to occur to form the deployment settings into the ImportSolutionAsync commands that this library surfaces,
I would suggest you shy away from the direct replication of that feature outside of the CLI at this time as it has not been finalized and the internal workings are subject to change still.
What specific features are you trying to access?

We have some Tooling in C#  around CI/CD of Power Platform solutions including Apps and Flows. Right now we have no option to deploy to stage / prod without manual interaction.

@DanielSaager
Connection management in deployment automation today is a very fragile system at the moment.  This is an area of active investment, and we should see better support in the future.
That said, if the connection ids and the connector ids preexist, you can send the relationship of connection id to connection reference as part of the solution install now.
To do that, you need to create an instance of a connectionreference like such:
EntityCollection solutionComponetSettings= new EntityCollection();
Entity connRecord = new Entity("connectionreference");
connRecord.Attributes.Add("connectionreferencedisplayname", payloadItm.ConnectionRefDisplayName);
connRecord.Attributes.Add("connectionreferencelogicalname", payloadItm.ConnectionRefLogicalName);
connRecord.Attributes.Add("description", payloadItm.Description);
connRecord.Attributes.Add("connectorid", payloadItm.ConnectorId);
connRecord.Attributes.Add("connectionid", payloadItm.ConnectionId);
solutionComponetSettings.Add(connRecord);

Once you have an array of entities, you then add that to an entity collection, and add the entity collection to the ImportSolutionRequest.
//simplified
Dictionary<string, object> extraParameters = new Dictionary<string, object>();
extraParameters[ImportSolutionProperties.COMPONENTPARAMETERSPARAM] = solutionComponetSettings;
dvClient.ImportSolution(
                            sSolutionImportFilePath,
                            out guSolImportId,
                            extraParameters: extraParameters);

That will send a solution install request along with the connection reference, allowing it to wire up the flow's and other connections as part of the solution import operation.
This works for both Sync and Async Solution import operations.
Moving this over to discussions as its not really an issue :)


Improved unit tests

Removed commented code from the ITs
Moved all setup functions in ITs from @BeforeEach to @BeforeAll (Improved performance a bit and avoids excessive logging)
Added missing properties in both .gitignore and pom.xml

thanks!


GSM modem support for particle_boron board

I was not able to fully test this as the board was constantly crashing shortly after boot. I also saw crashes without these patches so the culprit is most likely elsewhere.

Postponing this to 2.3 in order to do more testing with this board.

Requires more TLC, I removed the milestone as this might not make to 2.3

Is this still an active PR? If so I may be able to attempt to test.

Is this still an active PR? If so I may be able to attempt to test.

I got sidetracked with other tasks so this has not been progressing lately. It would be great if you can try it and give feedback.

Anything a person who wants to see this work can help with? Would love to see this working.

Anything a person who wants to see this work can help with? Would love to see this working/merged.

It would be greatl if more testing is done, and as there is probably changes required, a PR fixing the issues would be nice too (but not mandatory).

Okay, I think there are two issues:

The device definition has an error, should be:

DEVICE_DEFINE(gsm_ppp, GSM_MODEM_DEVICE_NAME, gsm_init,device_pm_control_nop, &gsm, NULL,
	      POST_KERNEL, CONFIG_MODEM_GSM_INIT_PRIORITY, NULL);

The change get the device to 'boot' without errors but never starts.

The other is the modem has not be "powered-up" as the gpio pin haven't been initialised
Not sure how best to address this whilst being flexible.

Billy..

I think there are two issues:
1. The device definition has an error, should be:

DEVICE_DEFINE(gsm_ppp, GSM_MODEM_DEVICE_NAME, gsm_init,device_pm_control_nop, &gsm, NULL,
	      POST_KERNEL, CONFIG_MODEM_GSM_INIT_PRIORITY, NULL);

Hmm, indeed. It seems that commit 5e97d779bba79653a4df3273c918aa3bbe9c7ddf converted earlier DEVICE_INIT() to DEVICE_DEFINE() incorrectly. I will send a fix for this. Thanks for the info.

I will send a fix for this

Fix at #30047

I will send a fix for this

Fix at #30047

I've managed to get the Ublox modem working as PPP but its very messy at the moment. I'll look to tidy up in the next few days.
TLS is not working but it appears the non-secure sockets are just fine.
Will..

Ublox modem working as PPP

That is very good news, thanks for working on this! :+1:


Turn off JS Minification for Heroku

Given the outcome of #123 and #124, we don't take a stand on where
minification should happen.
However, to make sure that Heroku deployments don't take too long, the
generator can disable Rails-side minification.
The benefit of doing this in the generator (as opposed to automatically
in the addon) is that the change will introduce diff noise, which is
explicit and easy to back out of.

@seanpdoyle to be clear, this is only disabling the Rails-side minification, correct? JS is still being minified by Ember?
After reading #123 that was my impression, but wanted to confirm my understanding.

What happens if I'm using Ember for part of my app but using jquery and a few other things for another area of my app? Isn't this eliminating the minification there?

@geoffharcourt that's correct.
There are PRs (https://github.com/rondale-sc/ember-cli-rails-addon/pull/12, https://github.com/rondale-sc/ember-cli-rails-addon/pull/16) that disable minification on the addon side of things, but they do it automatically and implicitly, without giving the consumer the chances to make their decision.
There still a big decision to be made here, but I'd like to test it out on Heroku first to see how it goes.

@drapergeek yes, it is.
Fortunately, since this is a generator, there will be diff noise.
That diff noise could be reverted, and at that point you could manually set minifyJS: false in your Ember app, or do nothing and minify both assets twice.

@drapergeek Ideally, on a greenfield app (like the one Geoff and I are working) you'd keep your assets on the frontend.

@drapergeek Ideally, on a greenfield app (like the one Geoff and I are working) you'd keep your assets on the frontend.

That's an ideal situation. There are definitely cases where you want things to be split.

Fortunately, since this is a generator, there will be diff noise.

That's fine for our case but I worry that others won't see what is happening and they lose speed due to an oversight. Not sure how to rectify that issue while still fixing this problem though.

@seanpdoyle I think a change to the README to clarify would be helpful, but the code side of this looks good.

@drapergeek would you prefer disabling minification in EmberCLI -- relying on the Asset Pipeline for minification?

@drapergeek would you prefer disabling minification in EmberCLI -- relying on the Asset Pipeline for minification?

Definitely not. Of the two options, I significantly prefer this.
This really doesn't affect me since I deploy with ember-cli-deploy anyway. I'd leave on minification for our other stuff. I'm just concerned about others who don't notice what is happening.


:fire: Data validation for get_or_create method

This PR would be the solution to issue #33

Nicely done @MAD-py !


Hot-reloading Hook state

We lose all of the Hook state when we hot-reload. We should keep the Hook state when we hot-reload.

Done https://github.com/pyedifice/pyedifice/commit/1576d6a0f651ab3505a04cbbeb7cbecb01c10e43


[FIX] Update broken link to logo

Pretty self-explanatory 😉

Thank you for your contribution 👍
However, this bug is already solved on the /dev branch (#35), so I prefer to close this PR since the master branch will receive this change soon.

Sounds good @oganexon 👍


Updated WildFly Swarm server to support async

You asked for a Swarm async example, so here is a version. Note that I haven't updated project-defaults.yaml to set pool size. I also just realized that I auto-formatted pom.xml so apologies for what looks like a lot of changes, LOL. Pom.xml changes include adding ejb dependency and updated swarm version. That's all.

Thanks for doing this John!
Why the ejb dependency though? JAX-RS Singleton not sufficient?

I just wrote it the best way I knew how, LOL.

On Sep 15, 2017, at 6:21 PM, Ken Finnigan<EMAIL_ADDRESS>wrote:
Thanks for doing this John!
Why the ejb dependency though? JAX-RS Singleton not sufficient?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/redhat-helloworld-msa/goodbye/pull/3#issuecomment-329935671, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEdc-gk4HS-xjGzB-snFn8gRiVParPcks5siyKxgaJpZM4PZm4-.


port changes from feature/storage/stable branch

/check-enforcer evaluate

/check-enforcer override


make workflows match template

https://github.com/ProjectPythiaCookbooks/projectpythiacookbooks.github.io/issues/96#issuecomment-1308765962

I'll look for that in the other PRs too

@brian-rose in the other cookbooks, the environment name is just "cookbook-dev" so nothing else needs to be changed in the workflows. Is there a reason to give it a repo specific name?

I think it's a decision for individual cookbook authors to make. The reason is to disambiguate that environment from any number of other cookbook environments that an individual might have installed locally.

Makes sense.


Emit number of task list managers started

What changed?
During creation and deletion of Task List Manager gauge metric is emitted with a count of Task List Managers active

Why?
This will expose a number of task list managers created per matching instance

How did you test it?

Potential risks

Coverage decreased (-0.03%) to 61.515% when pulling 24c312da6e6b95bf609b096f4790cf9751d2c5c0 on mantas-sidlauskas:matching_metrics into 6b5c1033fb206f12c0a0e662ff89f5b1f9289170 on uber:master.

Coverage decreased (-0.03%) to 61.515% when pulling 24c312da6e6b95bf609b096f4790cf9751d2c5c0 on mantas-sidlauskas:matching_metrics into 6b5c1033fb206f12c0a0e662ff89f5b1f9289170 on uber:master.


[Port dspace-7_x] Remove unused dependencies from several modules

Description
Manual port of #10032 to dspace-7_x.
This PR is smaller, as not all changes in #10032 can be ported to 7.x

Not all changes to dspace-services POM can be ported to 7.x, as some of these dependencies are necessary for 7.x
The changes to server-boot POM are not applicable to 7.x, as this didn't exist in 7.x

Merging, all tests pass!


md-button: icon button lacks material-icons class

When testing the md-button component (copy paste of example tab), the icon was not shown. After some research it appears to be the class of material-icons which is lacking in the documentation.
At the moment:
<button md-icon-button color="primary">
    <md-icon class="md-24" aria-label="Example icon-button with a heart icon">favorite</md-icon>
  </button>

It should be:
<button md-icon-button color="primary">
    <md-icon class="material-icons" aria-label="Example icon-button with a heart icon">favorite</md-icon>
  </button>

That class should get automatically added to the icon by default. Can you reproduce where it did not?
https://plnkr.co/edit/WiCGNj4TtqRGDxWNOXMh?p=preview


Fix title and add a TOC to the logging concept page

The said page is not about monitoring at all, don't know why it's even mentioned.
Also, added a toc instead a manual analogue.
/cc @chenopis @piosz @fgrzadkowski

This change is

/lgtm


[ARCTIC-1863]Support optimizing for partition evolution iceberg table

Why are the changes needed?
Close #1863 .
Brief change log

Modify com.netease.arctic.server.dashboard.MixedAndIcebergTableDescriptor#collectFileInfo to fix dashboard display error
Fix OptimizingPlaner error when planning partition evolution iceberg table
Modify IcebergRewriteExecutor to write insert file in new spec and write position delete in old spec

How was this patch tested?

[x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before making a pull request

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: zhoujinsong:x: shidayangYou have signed the CLA already but the status is still pending? Let us recheck it.


chore: Use shared workflows

Issue #, if available:
Description of changes: Use shared workflows
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@6fda3c7). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #12   +/-   ##
=======================================
  Coverage        ?   74.69%
=======================================
  Files           ?       20
  Lines           ?      565
  Branches        ?       73
=======================================
  Hits            ?      422
  Misses          ?      136
  Partials        ?        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fda3c7...b48562c. Read the comment docs.


mac m1 使用源码 go build 报错

Thank you very much for finding and sharing these errors
Been busy recently
Have to wait some time

抱歉github上arm编译要付费，短期无法编译arm版本了


🎉 feat: Multiple docker endpoints

@louislam
Hi
I found this project awesome, but a simple thing that is missing is managing multiple instances/servers
So, I have some ideas for that, by setting correct env vars when needed, etc.

Thank you!
Yes, multiple docker hosts feature is definitely a must have feature for this project.
It will be very similar to Portainer's agent, I think.

Of course, let's see if people love my idea of Dockge first.
I will keep testing it for a while. And I will post it to https://www.reddit.com/r/selfhosted/ later if it is stable.

Just realize it is a pull request.
Actually we have Docker host config page in Uptime Kuma, I think I will copy this page to this project, no need to make a new one.

@louislam
Yeah a copy from uptime kuma is awesome.!
So, I will wait for you to add UI :)

And I will post it to https://www.reddit.com/r/selfhosted/ later if it is stable.

Just posted to reddit, hope people will love it. 🐻
https://www.reddit.com/r/selfhosted/comments/17tkq79/dockge_a_fancy_easytouse_selfhosted_docker/

Just posted to reddit, hope people will love it. 🐻 https://www.reddit.com/r/selfhosted/comments/17tkq79/dockge_a_fancy_easytouse_selfhosted_docker/

Love the People responses!

@louislam
Hi
You will copy Uptime Kuma UI? Or do I have to do it?

@louislam Hi You will copy Uptime Kuma UI? Or do I have to do it?

docker-compose on remote hosts is not that straight, I think it has to be studied first.

@louislam Hi You will copy Uptime Kuma UI? Or do I have to do it?

docker-compose on remote hosts is not that straightforward, I think it has to be studied first.

I have some experience on that
It should be Ok since we are using commands in this project 😁

@louislam
Hi
Any updates on UI?

I have studied a bit. Although we can docker-compose via Docker API(tcp://:2375)/Sock, but it cannot create compose files or the stacks dir on the remote server, which is not something that I wanted.
So my direction will be SSH or an Agent.
I think the foundation of this feature should leave to me, I need a very clear plan before we go.

I have studied a bit. Although we can docker-compose via Docker API(tcp://:2375)/Sock, but it cannot create compose files or the stacks dir on the remote server, which is not something that I wanted.
So my direction will be SSH or an Agent.
I think the foundation of this feature should leave to me, I need a very clear plan before we go.

Oh
Like K8s We could follow control-plane/worker setup
So, dockge server will be able to act just like a CP and others are workers (but CP could be usable as a worker for minimal setups)
OR
We can Switch to SSH
But it will be hard to have file manager

it cannot create compose files or the stacks dir on the remote server, which is not something that I wanted.

on my setup, i mounted the stacks directory on the other server with nfs, thus creating a file on server 1 will add them on server 2 too. Could be an idea to do something like this for now?

Hello, I want to make a comment:
It would be good to support docker contexts which are built into docker instead of a custom solution like portainer.
This you can keep the dockge / shell equivalency and do not add a custom layer

Hello, I want to make a comment:
It would be good to support docker contexts which are built into docker instead of a custom solution like portainer.
This you can keep the dockge / shell equivalency and do not add a custom layer
https://docs.docker.com/engine/context/working-with-contexts/

But how do you want to manage your stacks?

But how do you want to manage your stacks?

so, i realize this is not feasible for every setup to do but at my work i have identical machines and i set up password-less ssh login and replicated the directory files exactly on the remote machine. then they were seemless to use with --context.
but i see docker realized this is not trivial as well so they removed the context option from docker compose for V2.

@gbrandt1
You are correct if we do not manage our stacks using this project
@louislam
What about saving stacks in DB (not volume) in a compressed format?
When the UI updates a stack we will update the database, also we have a background job that keeps stack files up to date.
And create files on startup, also remove files on shutdown

Saving in db is not the direction of this project. People love Dockge because of file based and we don't kidnap users' compose files.
Also docker contexts is not able to save the compose files in the target server, so it is not the direction either.
I am implementing the agent mode in #200 which basically keeping Dockge's current design, but adding ability to manage all Dockge instances in one single Web UI.


updated requirements.txt v1

Solves #5

!bounty 250

!bounty 50

@Rex-8 sorry for the confusion the wrong bounty amount was assigned earlier


SQL backend requirement list incomplete?!

Hey, I've noticed that the SQL backend requirement part "Back end databases that will work with Skype for Business Server 2015" was changed. Now it seems to be incomplete and not display all versions which are supported. Could you please update and complete this list as it was on technet before? Thanks. Best Regards Erik

Dokumentdetails
⚠ Bearbeiten Sie diesen Abschnitt nicht. Er ist für die Verknüpfung von docs.microsoft.com zum GitHub-Artikel erforderlich.

ID: 7c475b5d-09ed-7f58-86d4-27f28e33ef7a
Version Independent ID: f0ad50f3-ea93-9424-6de8-a0b778e90b23
Content: Serveranforderungen für Skype for Business Server 2015
Content Source: Skype/SfbServer/plan-your-deployment/requirements-for-your-environment/server-requirements.md
Product: skype-for-business-itpro
GitHub Login: @MicrosoftHeidi
Microsoft Alias: heidip

@3k09 - I will get this over to the right person and get this resolved asap. Thank you very much for taking the time to report. It is appreciated!

@3k09 - this appears to be an issue with how the en-us article is translated. The localization team, @samanthaw , is looking into this. There is also a related issue with German https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/412 that is also being resolved and these should be resolved together.

Here is direct link to the en-us version where the table is not getting truncated: https://docs.microsoft.com/en-us/skypeforbusiness/plan-your-deployment/requirements-for-your-environment/server-requirements  Let's keep this open until resolved. Thank you very much for reporting!

@kenwith Thank you!

@3k09 this is now fixed

Thank you @samanthaw !  Closing this one but if you still see issues feel free to re-open.


[text] Current lyrics line gets hidden under top shadow of the lyrics box

Prerequisites
Before opening an issue, make sure

[x] 1. You have the most recent spicetify version.
[x] 2. Your Spotify version is compatible with the spicetify version you are using.
[x] 3. You have the most recent version of the themes.
[x] 4. You followed the installation instructions for the theme you are using (please go through the entire theme README).

Describe the bug
The currently active line highlighted in the Lyrics box is being at the very top of it and as such also hides partially under its shadow.
To Reproduce
Steps to reproduce the behavior:

Go to 'Now Playing'
Click on 'See Lyrics'
Scroll down to 'highlighted lyrics line'
See error

Expected behavior
The highlighted line should be out of the shadow area, and at best vertically centered in the box.
Screenshots

Logs
Add logs from console. To do that

Run spicetify enable-devtools in terminal
Spotify will be restarted
Hit Ctrl + Shift + I to open DevTools window
Navigate to tab Console
Copy console window content.

Failed to load resource: the server responded with a status of 404 ()
extension.js:1 Initializing Spicetify Marketplace v0.8.5
extension.js:1 Loaded Marketplace extension
xpui.js:1 cosmos-connector:  fetchAdForSlot endpoint=%o sp://ads/v1/ads/hpto
gew4-spclient.spotify.com/remote-config-resolver/v3/configuration:1     Failed to load resource: the server responded with a status of 404 ()
vendor~xpui.js:29 provider:transport resolve error T Object
f @ vendor~xpui.js:29
index.html:1 Uncaught (in promise) T
fullScreen.js:10 marked(): mangle parameter is enabled by default, but is deprecated since version 5.0.0, and will be removed in the future. To clear this warning, install https://www.npmjs.com/package/marked-mangle, or disable by setting `{mangle: false}`.
(anonymous) @ fullScreen.js:10
fullScreen.js:10 marked(): headerIds and headerPrefix parameters enabled by default, but are deprecated since version 5.0.0, and will be removed in the future. To clear this warning, install  https://www.npmjs.com/package/marked-gfm-heading-id, or disable by setting `{headerIds: false}`.
(anonymous) @ fullScreen.js:10
xpui.js:1 Uncaught (in promise) BadGatewayError: GET request to wg://artist/v1/3AkGIMk9xwDj4A5ttNBPiN/desktop?format=json failed with status code 502
    at l.onSuccess (xpui.js:1:2170149)
    at onSuccess (xpui.js:1:2169963)
vendor~xpui.js:29 Uncaught (in promise) TypeError: Request URL cannot be blank.
    at vendor~xpui.js:29:1399271
    at new Promise (<anonymous>)
    at le (vendor~xpui.js:29:1399135)
    at Module.ce (vendor~xpui.js:29:1400358)
    at vendor~xpui.js:29:1388914
vendor~xpui.js:29 NotFoundError: GET request to sp://core-playlist/v1/playlist/spotify%3Aplaylist%3A37i9dQZF1EYkqdzj48dyYq/?responseFormat=protobufJson&start=0&length=0 failed with status code 404
    at l.onSuccess (xpui.js:1:2170149)
    at onSuccess (xpui.js:1:2169963)
onError @ vendor~xpui.js:29
extension.js:1     GET https://raw.githubusercontent.com/3raxton/spicetify-custom-apps-and-extensions/main/manifest.json 404 (Not Found)
R @ extension.js:1
(anonymous) @ extension.js:1
(anonymous) @ extension.js:1
extension.js:1     GET https://raw.githubusercontent.com/TheRandomLabs/Scoop-Spotify/master/manifest.json 404 (Not Found)

Specifics (please complete the following information):

OS: Windows 11 22H2
Spotify for Windows (64 bit) <IP_ADDRESS>6.g7a7fc7f0
Spicetify v2.27.0
xpui_2023-11-06_1699279287548_7a7fc7f
text theme

Hey @harbassan, thanks alot for trying to fix the issue, but I think it went it the wrong direction.

i made a mistake, we havent pushed the actual fix yet.