fix: control panel fields styling (#12236)

SUMMARY
Adjusted METRICS and FILTER to use 4px border radius
Adjusted GROUP BY to keep same margin as METRICS and FILTERS
Adjusted RATIO height, border and box shadow
Adjusted METRICS, FILTERS and GROUP BY border colors
Adjusted search height and box shadow
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

#12236
@junlincc
TEST PLAN
1 - Select a chart
2 - View changes in control panel
3 - Repeat this process for charts with different control panel fields
ADDITIONAL INFORMATION

[x] Has associated issue:
[x] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #12326 (8f0aa0b) into master (2b6a587) will decrease coverage by 11.95%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master   #12326       +/-   ##
===========================================
- Coverage   63.00%   51.05%   -11.96%
===========================================
  Files        1002      466      -536
  Lines       49268    16805    -32463
  Branches     5003     4321      -682
===========================================
- Hits        31039     8579    -22460
+ Misses      18028     8226     -9802
+ Partials      201        0      -201

Flag
Coverage Δ

cypress
51.05% <100.00%> (?)

javascript
?

python
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...rontend/src/explore/components/DatasourcePanel.tsx
88.23% <ø> (+10.96%)
:arrow_up:

...frontend/src/explore/components/OptionControls.tsx
73.68% <ø> (+32.22%)
:arrow_up:

...nd/src/explore/components/controls/TextControl.tsx
66.66% <ø> (+23.80%)
:arrow_up:

superset-frontend/src/components/Select/styles.tsx
93.75% <100.00%> (+29.86%)
:arrow_up:

...uperset-frontend/src/dashboard/util/dnd-reorder.js
0.00% <0.00%> (-100.00%)
:arrow_down:

...rset-frontend/src/dashboard/util/getEmptyLayout.js
0.00% <0.00%> (-100.00%)
:arrow_down:

...dashboard/components/resizable/ResizableHandle.jsx
0.00% <0.00%> (-100.00%)
:arrow_down:

.../src/dashboard/util/getFilterScopeFromNodesTree.js
0.00% <0.00%> (-93.48%)
:arrow_down:

...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx
11.76% <0.00%> (-88.24%)
:arrow_down:

...src/dashboard/components/gridComponents/Header.jsx
10.52% <0.00%> (-86.85%)
:arrow_down:

... and 918 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b6a587...8f0aa0b. Read the comment docs.

Codecov Report

Merging #12326 (8f0aa0b) into master (2b6a587) will decrease coverage by 11.95%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master   #12326       +/-   ##
===========================================
- Coverage   63.00%   51.05%   -11.96%
===========================================
  Files        1002      466      -536
  Lines       49268    16805    -32463
  Branches     5003     4321      -682
===========================================
- Hits        31039     8579    -22460
+ Misses      18028     8226     -9802
+ Partials      201        0      -201

Flag
Coverage Δ

cypress
51.05% <100.00%> (?)

javascript
?

python
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...rontend/src/explore/components/DatasourcePanel.tsx
88.23% <ø> (+10.96%)
:arrow_up:

...frontend/src/explore/components/OptionControls.tsx
73.68% <ø> (+32.22%)
:arrow_up:

...nd/src/explore/components/controls/TextControl.tsx
66.66% <ø> (+23.80%)
:arrow_up:

superset-frontend/src/components/Select/styles.tsx
93.75% <100.00%> (+29.86%)
:arrow_up:

...uperset-frontend/src/dashboard/util/dnd-reorder.js
0.00% <0.00%> (-100.00%)
:arrow_down:

...rset-frontend/src/dashboard/util/getEmptyLayout.js
0.00% <0.00%> (-100.00%)
:arrow_down:

...dashboard/components/resizable/ResizableHandle.jsx
0.00% <0.00%> (-100.00%)
:arrow_down:

.../src/dashboard/util/getFilterScopeFromNodesTree.js
0.00% <0.00%> (-93.48%)
:arrow_down:

...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx
11.76% <0.00%> (-88.24%)
:arrow_down:

...src/dashboard/components/gridComponents/Header.jsx
10.52% <0.00%> (-86.85%)
:arrow_down:

... and 918 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b6a587...8f0aa0b. Read the comment docs.

My scenario:
Built everything with command:
CYPRESS_CONFIG=true docker-compose up
Then opened chart:

Then expanded advanced analytics
I observed Rolling Function glitch:

I compared this to version from different branch:

My scenario:
Built everything with command:
CYPRESS_CONFIG=true docker-compose up
Then opened chart:

Then expanded advanced analytics
I observed Rolling Function glitch:

I compared this to version from different branch:

Could you verify as well situation when we try to click on

And then try to expand dropdowns:
https://user-images.githubusercontent.com/25153919/103895931-7712e700-50f1-11eb-8f80-11f70a90c4ce.mov

Could you verify as well situation when we try to click on

And then try to expand dropdowns:
https://user-images.githubusercontent.com/25153919/103895931-7712e700-50f1-11eb-8f80-11f70a90c4ce.mov

Could you verify as well situation when we try to click on

And then try to expand dropdowns:
dropdown.mov

@adam-stasiak I just confirmed that this is happening in master. Can you open a new issue and remove this comment so we can keep only related issues?

Could you verify as well situation when we try to click on

And then try to expand dropdowns:
dropdown.mov

@adam-stasiak I just confirmed that this is happening in master. Can you open a new issue and remove this comment so we can keep only related issues?

Could you verify as well situation when we try to click on

And then try to expand dropdowns:
dropdown.mov

@adam-stasiak I just confirmed that this is happening in master. Can you open a new issue and remove this comment so we can keep only related issues?

Yes sure :)

Could you verify as well situation when we try to click on

And then try to expand dropdowns:
dropdown.mov

@adam-stasiak I just confirmed that this is happening in master. Can you open a new issue and remove this comment so we can keep only related issues?

Yes sure :)

same style problem at the latest master branch.  so we need new PR fix thit issue.

same style problem at the latest master branch.  so we need new PR fix thit issue.

same style problem at the latest master branch. so we need new PR fix thit issue.

@zhaoyongjie No problem. I'll fix this issue in this PR.

same style problem at the latest master branch. so we need new PR fix thit issue.

@zhaoyongjie No problem. I'll fix this issue in this PR.

agreed, thank you @adam-stasiak for spotting the issue!
if the code looks good and we can confirm the styling issue preexists. let's merge this PR.

agreed, thank you @adam-stasiak for spotting the issue!
if the code looks good and we can confirm the styling issue preexists. let's merge this PR.

thank you @adam-stasiak for spotting the issue!
if the code looks good and we can confirm the styling issue preexists. let's merge this PR.

We can't merge it just yet. Although this is problem exists in master, some inputs became bigger and when we hover them we have some layout problems. I'm fixing this right now and I'll also fix the preexisting problem.

thank you @adam-stasiak for spotting the issue!
if the code looks good and we can confirm the styling issue preexists. let's merge this PR.

We can't merge it just yet. Although this is problem exists in master, some inputs became bigger and when we hover them we have some layout problems. I'm fixing this right now and I'll also fix the preexisting problem.

LGTM, thank you for your fix.
@michael-s-molina @junlincc

LGTM, thank you for your fix.
@michael-s-molina @junlincc

@nikolagigic Accepted all your suggestions. Thanks.
I increased the width (320px to 380px) of both panels to support bigger inputs. We still have the situation of layout flicks when we hover elements because there is no space available for the tooltip icon and this creates a line break. In talks with @junlincc she told me that this is being fixed in another PR where we're going to stack all controls and this line break problem won't happen anymore. So I will limit the scope of this PR to just fixing input styles.
For documentation purposes these images bellow show some examples where a line break happens:

@nikolagigic Accepted all your suggestions. Thanks.
I increased the width (320px to 380px) of both panels to support bigger inputs. We still have the situation of layout flicks when we hover elements because there is no space available for the tooltip icon and this creates a line break. In talks with @junlincc she told me that this is being fixed in another PR where we're going to stack all controls and this line break problem won't happen anymore. So I will limit the scope of this PR to just fixing input styles.
For documentation purposes these images bellow show some examples where a line break happens:

scope of the issue/pr should be limited to styling changes. which are done!
@pkdotson and @mihir174 will open a separate PR to address the layout issue. 🙏 thanks all!

scope of the issue/pr should be limited to styling changes. which are done!
@pkdotson and @mihir174 will open a separate PR to address the layout issue. 🙏 thanks all!

@junlincc I made all the requested changes.

@junlincc I made all the requested changes.

@junlincc I made all the requested changes.

I'm not able to see the latest changes(tried different browsers) when I tested.  @michael-s-molina

@junlincc I made all the requested changes.

I'm not able to see the latest changes(tried different browsers) when I tested.  @michael-s-molina

Hoping E2E tests go through on this new run, will merge if so!

Hoping E2E tests go through on this new run, will merge if so!

@mihir174 want to bring this to your awareness

@mihir174 want to bring this to your awareness

@pkdotson need to confirm the layout issues in advanced analytics are being taken care of 🙏

@pkdotson need to confirm the layout issues in advanced analytics are being taken care of 🙏

rolling window will be fixed in this upcoming pr: https://github.com/apache-superset/superset-ui/pull/895

rolling window will be fixed in this upcoming pr: https://github.com/apache-superset/superset-ui/pull/895

while we tested again, we found blank page of deck.glMultiple Layers. and confirm that this has been an issue, not related to this PR.
This PR is good to go if codes look ok!

while we tested again, we found blank page of deck.glMultiple Layers. and confirm that this has been an issue, not related to this PR.
This PR is good to go if codes look ok!


create a staking package

Not needed for this PR, but we probably want to make a staking package and move these and the Owner struct there eventually.
Originally posted by @ezekiiel in https://github.com/DA0-DA0/dao-contracts/pull/447#discussion_r946032131

Is this still relevant?


building emscripten: "No emscripten cache. Generate it!"

This is going to be a bit of a rambling issue; sorry about that. I'm confused about what exactly the problem is here, there's too many things going on that I'm unfamiliar with.
tl;dr
I don't have emsdk but I do have the manjaro emscripten package; I think raylib is hard-coded to assume I have emsdk, and it's causing problems when try to build for web. But I'm not really certain about anything and don't know the best way to fix it.
emsdk
I'm running Manjaro Linux, and I have the emscripten package installed:
> pacman -Qi emscripten | head -n2
Name            : emscripten
Version         : 3.1.61-1

This installed emcc etc for me:
> emcc -v
emcc (Emscripten gcc/clang-like replacement + linker emulating GNU ld) 3.1.61-git (67fa4c16496b157a7fc3377afd69ee0445e8a6e3)
clang version 19.0.0git (/startdir/llvm-project 7cfffe74eeb68fbb3fb9706ac7071f8caeeb6520)
Target: wasm32-unknown-emscripten
Thread model: posix
InstalledDir: /opt/emscripten-llvm/bin

When I run > ls $(dirname $(which emcc)) I see various other executables, like em++, emrun, emstrip. But I don't have emsdk (> which emsdk says "emsdk not found")
My best guess about what's going on here is that emsdk is "a small package manager for controlling which tools are installed" , and Manjaro doesn't want another package manager around, so the manjaro emscripten package is meant to replace any need for having emsdk.
zig build ... emscripten
My project uses zig 0.13.0 and a recent version of this library (raylib-zig). My build file is minimally modified from the example project, and includes these lines:
    if (target.query.os_tag == .emscripten) {
        const exe_lib = rlz.emcc.compileForEmscripten(b, name, "src/main.zig", target, optimize);
        // ...

I tried to build it with > zig build run -Dtarget=wasm32-emscripten but got panic: Pass '--sysroot "$EMSDK/upstream/emscripten"'. But, I don't have EMSDK! > echo $EMSDK prints nothing.
I figured out where my emscripten cache is by running > emcc main.c on a simple Hello World program:
> emcc main.c
shared:INFO: old sanity: 3.1.55-git|/opt/emscripten-llvm/bin
shared:INFO: new sanity: 3.1.61-git|/opt/emscripten-llvm/bin
shared:INFO: (Emscripten: config changed, clearing cache)
shared:INFO: (Emscripten: Running sanity checks)
cache:INFO: generating system headers: sysroot_install.stamp... (this will be cached in "/home/pancelor/.emscripten_cache/sysroot_install.stamp" for subsequent builds)
cache:INFO:  - ok
cache:INFO: generating system library: sysroot/lib/wasm32-emscripten/libGL-getprocaddr.a... (this will be cached in "/home/pancelor/.emscripten_cache/sysroot/lib/wasm32-emscripten/libGL-getprocaddr.a" for subsequent builds)
system_libs:INFO: compiled 4 inputs in 0.42s
cache:INFO:  - ok
...

Alright, so then I tried > zig build run -Dtarget=wasm32-emscripten --sysroot ~/.emscripten_cache/sysroot but this fails with "panic: No emscripten cache. Generate it!"
This is coming from raylib/src/build.zig, which seems to be assuming that my cache is managed by emsdk? This line: const cache_include = std.fs.path.join(b.allocator, &.{ b.sysroot.?, "cache", "sysroot", "include" }) catch @panic("Out of memory").
I think this means it's looking for ~/.emscripten_cache/sysroot/cache/sysroot/include on my machine and not finding it, because it doesn't exist. I think it should be looking for ~/.emscripten_cache/sysroot/include instead, but it's hard-coded to assume I have emsdk, which I don't.
editing raylib/src/build.zig
I tried hacking at raylib/src/build.zig and using this:
                var dir = std.fs.openDirAbsolute(b.sysroot.?, std.fs.Dir.OpenDirOptions{ .access_sub_paths = true, .no_follow = true }) catch @panic("No emscripten cache. Generate it!");
                dir.close();
                raylib.addIncludePath(std.Build.LazyPath{ .cwd_relative = b.sysroot.? });

which worked(?) but is now giving me error: 'stdlib.h' file not found, error: 'math.h' file not found, etc. pretty similar to #108. Maybe I didn't "fully" generate the emscripten cache somehow, and I need to flesh it out somehow? But, > ls ~/.emscripten_cache/sysroot/include/stdlib.h finds the file -- it exists.
edit: ah! my bad, I needed b.sysroot.? ++ "/include". well, not that exact syntax; see my comment below
questions

Have I misunderstood anything here?
Do I need emsdk?
Do I just need to edit raylib/src/build.zig? I did that above but I feel like I'm probably making this way harder somehow

why do I get error: 'stdlib.h' file not found, when then file exists? (edit: resolved, see below)

oh! I made a mistake with "editing raylib/src/build.zig" -- now that I've changed it to this:
            const cache_include = std.fs.path.join(b.allocator, &.{ b.sysroot.?, "include" }) catch @panic("Out of memory");
            defer b.allocator.free(cache_include);

            var dir = std.fs.cwd().openDir(cache_include, std.fs.Dir.OpenDirOptions{ .access_sub_paths = true, .no_follow = true }) catch @panic("No emscripten cache. Generate it!");
            dir.close();
            raylib.addIncludePath(.{ .cwd_relative = cache_include });

my new error is this:
> zig build run -Dtarget=wasm32-emscripten --sysroot ~/.emscripten_cache/sysroot
run
└─ run /home/pancelor/.emscripten_cache/sysroot/emrun
   └─ run /home/pancelor/.emscripten_cache/sysroot/emcc failure
error: unable to spawn /home/pancelor/.emscripten_cache/sysroot/emcc: FileNotFound
Build Summary: 6/9 steps succeeded; 1 failed (disable with --summary none)

This makes sense, emcc isn't located there. My original questions remain tho -- have I misunderstood anything / is this the best way to go about doing this?

more progress!

edited raylib/src/build.zig to change the sysroot include path
edited emcc.zig to not use hard-coded paths for emcc and emrun
the emscripten webpage opened! and crashed; I added "-sUSE_OFFSET_CONVERTER" as recommended by #108
I added link_step.addArg("--embed-file"); link_step.addArg("res/"); to my personal build.zig to include my game's sprites
the game draws in a web browser! but just for one frame I think. the error is unhelpful: "panic: reached unreachable code"

Ok, so far this doesn't look like a raylib-zig issue. Could you try adding raylib as a dependency directly and building without raylib-zig in between? If the error persists, please take this to the raylib repo (you can reference this issue there, I'm also looking into main raylib issues occasionally)

Any news on that? emcc is totally broken.

Well using pre-released unstable language with raylib bindings to build WASM  was not a good idea after all...

For it was:

Adding to my build.zig: exe.entry = .disabled; , to fix the entry point issue.
Replacing the line in raylib's build.zig in cache folder: raylib.addIncludePath(b.path(cache_include)); with:  raylib.addIncludePath(.{ .cwd_relative = cache_include });
Then running: zig build -Dtarget=wasm32-emscripten --sysroot ../emsdk/upstream/emscripten

@pancelor could you check if these steps work for you, and if so open an issue on the raylib repo?

I tried adding exe.entry = .disabled; I don't know how this would help (I don't think I have an "entry point issue") and my game still fails in the same way (it runs in the browser but crashes with an unhelpful panic message when I try to move the player)
I don't think the --sysroot ../emsdk/upstream/emscripten will help me, because my local emscripten is not laid out in the normal way, as discussed in my initial post.

I think I'm done trying to make this work for now; here's my thoughts on what I think should happen. I realize that just writing them here doesn't do much, but it seems best to write them somewhere, and I don't have the social energy right now to start an additional issue in the raylib repo, so I'll write my thoughts here and then close this.

I think my current bug (the game runs until I move the player, and the JS console says "panic: reached unreachable code") is mostly my fault somehow. Maybe I've misconfigured the emcc args and I wish the error were more helpful, but I think emscripten is mostly working -- I'm just doing something wrong somehow.
I think raylib and raylib-zig should both include emsdk directly as a dependency in build.zig.zon, the way sokol-zig does it. By including the files instead of depending on my system to have emsdk installed, the build is more portable, which is one of the main goals of the zig build system (sources: andrewrk talk, ziglang/zig#18450, found via raysan5/raylib#4010)

note: pacman.zig (which depends on sokol-zig) works great for me: just run zig build run -Dtarget=wasm32-emscripten and it builds emsdk, sokol, and everything else needed to make things work

If either project (raylib or raylib-zig) wants to go against the zig build system philosophy (as far as I understand it) and depend on system-installed binaries like emsdk, then both projects should remove/deprecate the --sysroot arg and add a --sysroot_cache arg which points to the cache directory instead. i.e. make this change:- const cache_include = std.fs.path.join(b.allocator, &.{ b.sysroot.?, "cache", "sysroot", "include" }) catch @panic("Out of memory");
+ const cache_include = std.fs.path.join(b.allocator, &.{ b.sysroot_cache.?, "include" }) catch @panic("Out of memory");

(and various other small changes to support this new path)
This would let things work on my machine; I would pass --sysroot_cache ~/.emscripten_cache/sysroot, people with emsdk would pass --sysroot_cache "$EMSDK/upstream/emscripten/cache/sysroot", and things would work on either system

I think I like the "emcc as a dependency" thing, but this has to start at a raylib level. I can add a small patch that just attempts to find emcc in the PATH, but that won't fix your cache issue. In the meantime I can't even get an emscripten build going WITH emsdk, so I can't work on this too much.


Lock the height

I'm submitting a

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Enhancement
[X] Feature request
[ ] Documentation issue or request

Description
_A feature: how i can fixed the height?

@supertorpez Based on this documentation https://sibiraj-s.github.io/ngx-editor/additional-documentation/resizer.html it supports two options 'basic' and 'stacked'. By default it is 'stacked'.
There is a workaround to hide the resize bar, any value other than the two mentioned options will hide the resizer.
Like ,
<app-ngx-editor resizer="none" [(ngModel)]="htmlContent"></app-ngx-editor>
@sibiraj-s It would be better if you mention this in the documentation.


refactor: introduce new simplifier

Description
This PR adds the initial refactoring of the simplification process.
It changes the entire perspective, to instead of adding simplification functions per CommonModel property, we process the JSON Schema keywords which then affects the CommonModel in some way.
It adds

Simplifier, the new implementation, which is quite similar to the old but different in how it simplifies the models.
Properties simplification, to show how the general principle works.

Files this PR is supposed to replace

https://github.com/asyncapi/generator-model-sdk/blob/master/src/simplification/Simplifier.ts
https://github.com/asyncapi/generator-model-sdk/blob/master/src/simplification/SimplifyProperties.ts
And all related tests have been refactored to have next to no dependencies by using the jest mocking framework.

Questions

Should we just use the general naming of simplification? I think it makes more sense to call it JSON Schema draft 7 simplifications. Where simplification refers to the process of interpreting how validation rules should be converted to CommonModels. Other words we can use instead of simplification? interpretation? processing? Not sure what fits best 🤷

Todo

[x] Refactor docs
[x] Solve code smells
[x] Add logging to the process

Related issue(s)
Related to: https://github.com/asyncapi/generator-model-sdk/issues/64
Blocked by: https://github.com/asyncapi/generator-model-sdk/pull/183

Coverage increased (+0.1%) to 94.748% when pulling 2da048aee5114fd92aa4e69a7fbb7921959de57e on jonaslagoni:feature/initial_simplifier into 9dec1e58ec5da21e8dbd80fc44075c53f156b830 on asyncapi:master.

@czlowiek488 pinging you in case you want to have a look at the refactoring of the simplifier and have some comments.

@czlowiek488 damn what a review, I will go through each of them and address them, thank you 🙏

@all-contributors please add @czlowiek488 for review, ideas

Thanks for the reviews and thoughts @magicmatatjahu  @czlowiek488 🎉

@czlowiek488 do you want me to request more reviews from you? Otherwise, it goes without saying you can always jump into a review of PRs whenever you have time :)

Just ping me if you wish a review, sometimes I can miss other notifications.


Webpack Config Complete, Basic Server and App Component Complete

Added Webpack, Babel and Loader Dev Dependencies
Configured Webpack to build production 'index.html' and 'main.js' bundles - successfully
Added Express, React and React-Dom Dependencies
Configured Express Server to serve bundle at root
Added server, build and start scripts
Created foundational React Component:  and tied to index.html

Looks good


Please update Installation section on README to reflect current version

The README says to install using pod 'AlamofireObjectMapper', '~> 1.0' while the current version is 1.1. The 1.0 is actually incompatible if you are using the latest version of Alamofire.

all done!


Collisions should mix

Collisions between droplets of the same collision group should actually perform a mix. This will likely require a reroute.

Fixed (or made irrelevant) by 096acda


Switch Test Framework

Alternative the following from jasmine:

mocha (NOTE: I used to use it a long time ago, however,  I don't like behavior  of this context on ES2015 later ...)
ava (NOTE: cannot full support on browser  ...)

switch to mocha


Added dedicated server support

This commit adds the ability to connect the NetImgui server to an Unreal dedicated server

Would appreciate this over at https://github.com/IDI-Systems/UnrealImGui. This project doesn't seem to be active so we forked it and are accepting contributions.

I created a pull request in the IDI-Systems fork (net_imgui branch) with this change. The branch was also made up to date with master and I updated the NetImgui Library to latest 1.9 version.

Hi.
I tried the changes to make it work with a dedicated server but we had no success.
I have seen you still rely on Slate to be running for it, but it seems that Slate is not running in dedicated Server, right?
Am I doing something wrong?
Cheers,

This is the whole point of this PR, the dedicated server doesn't package with Slate so the font and texture are created manually instead of using Slate's.


Updated to 4.6, added Init dialog.

TArray<>::FindMatch is deprecated in 4.6.  It is replaced by IndexOfByPredicate().  Unfortunately, I do not possess the required knowledge to make the transition, so I settled for a todo notice in the code.
Updated and compiled for UE4 4.6.0.

Hi @Web-eWorks,
Just to let you know:
I have given my plugin to Epic Games for integration into the upcoming 4.7
But for re-license clarity, I have removed all the code I was not the author, so the init dialog was stripped off :(
Now you can make a similar Pull Request directly to EpicGames.
Cheers!

Hi,
I believe everything will be clear while UE4.7 will be out. They will explain this!
But there will be no download, it will be integrated by default. You will only have to select it on the list of source control.
Only at first it will be marked 'experimental' so there will be an option to tick on a menu.
also you will have to remove my plugin from your project to avoid a clash.

I think what we're going to do actually is enable the plugin by default in 4.7, but put a "Beta!" warning right next to it in the dropdown list where you select your source control provider.  We did leave the plugin marked as "Beta" as well, but thought it was more discoverable if it was enabled by default.  So as of yesterday that's how we've set it up in the 4.7 branch.  We'll see as we get further along with QA testing.

Nice! Will be easier for newcomers :)


[5.2] Use registered UrlGenerator instance in url() helper

For consistency with asset() helper.
It was previously the case but changed in https://github.com/laravel/framework/commit/c0849496ac52e3a1eeb78fbce84e9c095ab87ca7.

Not benchmarked, but maybe it's also faster.

This is a breaking change.

Can you elaborate?

@GrahamCampbell please can you elaborate?

@GrahamCampbell sorry to insist on this (last time, promise). Just curious about this case. Could you provide a breaking scenario?

Someone rebinds the contract. Then this doesn't work, because url us hard bound to the other concretion, not the contract.

Thanks. In such a case though, I suppose the user would rather except url() to use its rebound stuff. But it's your pick, no biggies.

Still, consistency between asset() and url() would be great.


Release 1.0.15

Codecov Report

Merging #39 into master will increase coverage by 0.38%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master      #39      +/-   ##
============================================
+ Coverage     70.65%   71.04%   +0.38%
  Complexity       49       49
============================================
  Files            10       10
  Lines           259      259
  Branches         79       79
============================================
+ Hits            183      184       +1
  Misses           35       35
+ Partials         41       40       -1

Impacted Files
Coverage Δ
Complexity Δ

...idsonroids/gradle/localization/ParserEngine.groovy
71.68% <100%> (+0.6%)
11 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ae6af2...7c1d786. Read the comment docs.


Reduce Exceptions in the ConditionEvaluator

Hello,
this PR should reduce the amount of exceptions that the ConditionEvaluator would throw, if it receives incoming null values for the evaluation.
There are some sections in the code that are not able to handle that properly. I received already the following exceptions (in the form of stack traces on the stderr) in one of my applications:

java.lang.IllegalStateException: Not a JSON Primitive: null
java.lang.UnsupportedOperationException: JsonNull

The SDK is catching all exceptions and additionally prints the stacktrace to the standard error output channel. Unfortunately this can also harm consumers of this library, because some applications might require a specific format of messages that get printed to the error or normal output channels. From my point of view i think it is really worth it to work on the issue (#23), but i think as well, that it is always good to handle errors properly.
I also adjusted the test to let them fail, if exceptions will occur that are not expected to appear under a specific test condition. I'm not really happy with the changes that i had to introduce in the tests, but i couldn't come up with a better solution, unfortunately the SDK is catching every error which makes it hard to check if a specific error occurred.
I hope that you see value in this PR.
All the best,
Norman

Hello @nnusse!
There was a merge conflict with release/0.93 branch.
The test ConditionEvaluatorTest#test_evaluateCondition_testCases() is failing after resolving merge conflict.

It looks good


Give ter-indent a tab or two spaces, and it demands more (inside class/interface)

Here's the code:
export class ContactCreatedEvent extends MutatingEventBase<ContactPayload, BusinessContext> implements MutatingEvent<ContactPayload, BusinessContext> {
    public static type = 'Contact_Created';
    public static version = 0;
    sequence: number;

    constructor(params: MutatingEventParams<ContactPayload>) {
      super(params);
    }

    apply(context: BusinessContext): BusinessContext {
      context.created = true;
      context.sequence = this.sequence;
      return context;
    }
}

Inside es6 classes and interfaces, ter-indent/tslint refuse to indent correctly. Every child line inside the class gives the error [tslint] Expected indentation of 4 spaces but found 2. (ter-indent)  and if I concede and give it another 2 spaces it says [tslint] Expected indentation of 6 spaces but found 4. (ter-indent) Gives the same issue with tabs.
It seems to be classes/interfaces with more than one line inside as this doesn't produce the error on the one line inside:
export interface ICreateContact extends CQRSCommand<IContactPayload, BusinessContext, OperationalContext> {
  payload: IContactPayload;
}

but this does:
export interface ICreateContact extends CQRSCommand<IContactPayload, BusinessContext, OperationalContext> {
  payload: IContactPayload;
  test: string;
}

Neither of these produce the error:
export function test() {
  return null;
}

export function test() {
  console.log('do all the stuff');
  return null;
}

Relevant tslint.json
"indent": [
    true,
    "spaces",
    2
],
"ter-indent": [
    true,
    2,
    { "SwitchCase": 1 }
],

Versions:

VSCode 1.13.1
vscode-tslint 0.16.0
tslint 5.4.3
typescript 2.4.1
Node 8.1.3
Npm 5.1.0
Windows 10

Let me know what other information or debugging steps I can provide to help!

I've gotten this as well, but for me this is only occurring when running tslint within vscode using the tslint-language-service, and not when I use the regular vscode-tslint extension.

So upon further investigation it seems to be this line this.checkNodesIndent(nodesToCheck, indent + indentSize); inside blockIndentationCheck of terIndentRule.js causing the problem. The code treats it as a block and so the nodes inside interface get passed to checkNotesIndent but with a needed indent of 4, which is incorrect. Removing indentSize breaks all indentation errors and allows anything. Removing indent + seems to fix the issue though. Given that I'm not as familiar with the code base and what that might affect, I didn't want to branch and create a PR until someone more experienced can confirm that's the right move. In the meantime I'll just fix it locally in node_modules.

@ethanova , Try running the tests and see if your change breaks anything.

@jmlopez-rod when I run npm test right after pulling down master and npm installing I get this error:
><EMAIL_ADDRESS>test D:\projects\tslint-eslint-rules
> gulp test && gulp self-lint

[14:04:18] Using gulpfile D:\projects\tslint-eslint-rules\gulpfile.js
[14:04:18] Starting 'lint'...
Warning: The 'no-use-before-declare' rule requires type infomation.
D:/projects/tslint-eslint-rules/src/test/rules/ruleTester.ts
ERROR: 264:15  no-shadowed-variable  Shadowed name: 'configFile'

[14:04:20] 'lint' errored after 1.89 s
[14:04:20] Error in plugin 'gulp-tslint'
Message:
    Failed to lint: D:/projects/tslint-eslint-rules/src/test/rules/ruleTester.ts [264, 15]: Shadowed name: 'configFile'.
npm ERR! Test failed.  See above for more details.

After fiixing that error and running the tests, they all work. But after making my change, tests fail as shown in the attached.
postIndentChangeTests2.txt

I hit this earlier today when I tried to extend a config file from a different folder that would hit a different node_modules folder (bad idea, I know; "temporary" hack).
This hints that the problem might be caused by ter-indent loading a different version of typescript than the version of typescript being used by tslint (or, in vscode's case, the builtin typescript). Try setting the typescript.tsdk to point to your project's typescript.

hey @Kovensky thanks for the suggestion. I tried setting "typescript.tsdk": "node_modules/typescript/lib" in my settings.json at the project root, installing typescript there, and restarting which didn't make the error go away.

@ethanova Check in node_modules/tslint to see if you see the subfolder node_modules/typescript. I have come across cases in which some of dependencies (typedoc for instance) depends on very specific version of typescript and it gets quite hard to figure out what version of typescript a dependency is using.

I don't see that unfortunately. I noticed yesterday when I was working with my PATH variable that apparently some version of Visual Studio installed Typescript 1.0 and put that on my PATH. It could be that's what is causing it? I don't have time at the moment to go and delete it from my PATH and check, Unfortunately my PATH is over 2047 characters so I can't manage it from the GUI and haven't had time to clean it up.

Seeing the same problem. Just after we upgraded tslint from 5.5.0 to 5.6.0

Appears to only occur on<EMAIL_ADDRESS>for me.

Is this still an issue? I recall trying this out and I did not encounter the problem. I opened a branch to test this out:
ruleTester.addTestGroupWithConfig(
  'issue-244',
  'indentation inside classes',
  [
    2,
    { SwitchCase: 1 }
  ],
  [
  {
    code: dedent`
    export function test() {
      return null;
    }

    export function test() {
      console.log('do all the stuff');
      return null;
    }
    `
  },
  {
    code: dedent`
    export interface ICreateContact extends CQRSCommand<IContactPayload, BusinessContext, OperationalContext> {
      payload: IContactPayload;
      test: string;
    }
    `
  },
  {
    code: dedent`
    export interface ICreateContact extends CQRSCommand<IContactPayload, BusinessContext, OperationalContext> {
      payload: IContactPayload;
    }`
  },
  {
    code: dedent`
    export class ContactCreatedEvent extends MutatingEventBase<ContactPayload, BusinessContext> implements MutatingEvent<ContactPayload, BusinessContext> {
        public static type = 'Contact_Created';
        public static version = 0;
        sequence: number;

        constructor(params: MutatingEventParams<ContactPayload>) {
          super(params);
        }

        apply(context: BusinessContext): BusinessContext {
          context.created = true;
          context.sequence = this.sequence;
          return context;
        }
    }`
    }
]);

After running the test I get this:
$ gulp test --single ter-indent:issue-244
[14:08:36] Using gulpfile ~/Workspace/tslint-eslint-rules/gulpfile.js
[14:08:36] Starting 'lint'...
Warning: The 'no-use-before-declare' rule requires type information.
[14:08:36] Finished 'lint' after 407 ms
[14:08:36] Starting 'build'...
[14:08:38] Finished 'build' after 1.73 s
[14:08:38] Starting 'test'...

  ter-indent
    1) issue-244 - indentation inside classes

  0 passing (61ms)
  1 failing

  1) ter-indent issue-244 - indentation inside classes:
     AssertionError: Error mismatch in issue-244-3.ts:

      0|
      1| export class ContactCreatedEvent extends MutatingEventBase<ContactPayload, BusinessContext> implements MutatingEvent<ContactPayload, BusinessContext> {
      2|     public static type = 'Contact_Created';
      3|     public static version = 0;
      4|     sequence: number;
      5|
      6|     constructor(params: MutatingEventParams<ContactPayload>) {
      7|       super(params);
      8|     }
      9|
     10|     apply(context: BusinessContext): BusinessContext {
     11|       context.created = true;
     12|       context.sequence = this.sequence;
     13|       return context;
     14|     }
     15| }

     Found:
       [issue-244-3.ts@{[2:0|153] -> [2:4|157]}] ter-indent: Expected indentation of 2 spaces but found 4.
       [issue-244-3.ts@{[3:0|197] -> [3:4|201]}] ter-indent: Expected indentation of 2 spaces but found 4.
       [issue-244-3.ts@{[4:0|228] -> [4:4|232]}] ter-indent: Expected indentation of 2 spaces but found 4.
       [issue-244-3.ts@{[6:0|251] -> [6:4|255]}] ter-indent: Expected indentation of 2 spaces but found 4.
       [issue-244-3.ts@{[10:0|342] -> [10:4|346]}] ter-indent: Expected indentation of 2 spaces but found 4.

      at Test.compareErrors (dist/test/rules/ruleTester.js:97:16)
      at Test.runTest (dist/test/rules/ruleTester.js:72:14)
      at dist/test/rules/ruleTester.js:211:38
      at Array.forEach (native)
      at Context.<anonymous> (dist/test/rules/ruleTester.js:209:37)

[14:08:38] 'test' errored after 537 ms
[14:08:38] Error in plugin 'gulp-spawn-mocha'
Mocha exited with code 1

Those are valid errors, we are specifying the use of two spaces per indent. I'll close this for now but feel free to reopen if the problem can be reproduced.

I am encountering this same error, but in my case it appears to be caused by an interaction between globally-installed and locally-installed packages. Specifically, I was under a project directory generated by Angular's ng new command, which had installed<EMAIL_ADDRESS>but the tslint I was running was the globally-installed<EMAIL_ADDRESS>Some of the relevant dependencies also had differing versions.
I believe the solution is either (1) to only run the locally-installed tslint from node_modules/.bin within the project, or (2) to ensure that all of the local and global versions match. Because I experienced this via vim's Syntastic plugin, which was executing the globally-installed tslint, so it was easier for me to take approach 2 by running npm i tslint@latest tsutils@latest tslint-config-airbnb-base@latest tslint-eslint-rules@latest typescript@latest in the Angular project. An alternative for use with approach 1 would have been to install a vim plugin to allow Syntastic to find and execute the locally-installed tslint instead. (I think I took the lazier approach.)
I am sharing this just in case others like me stumble across this thread in search of help because it was difficult at first for me to find information or decipher what was happening. Thank you to the folks above who shared enlightening tidbits on this.


chore: automated PR to update VHDVersion for 0000.22.2 VHD

This is an automated PR to bump VHDVersion for the VHD release with image version 0000.22.2

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.095%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2255

Relevant Lines:
2851

💛  - Coveralls


Fix the String.Join helper

When passing an actual IEnumerable (as opposed to a hardcoded list in a template) the following exception was thrown:

System.ArgumentException: Object of type '[…]' cannot be converted to type 'System.Collections.Generic.IEnumerable`1[System.Object]'.

Changing the method signature to use IEnumerable instead of IEnumerable fixes this issue.

@0xced
Thank you. Your change makes sense.
I'll merge this PR.
(b.t.w. I still need to fix the CI build...)


dts/bindings: Remove unused property num-irq-priority-bits

We define "arc,num-irq-priority-bits" and "intel,num-irq-priority-bits"
as required properties in the bindings for the interrupt controllers
however we never specify these properties in any .dts files or use them
in any code.
Remove them as stale properties in the binding files.
Signed-off-by: Kumar Gala<EMAIL_ADDRESS>

Indeed that property seems to be just a blind copy-paste from ARM's bindings done here https://github.com/zephyrproject-rtos/zephyr/commit/532e4d22eedde133c38b15808d8eb1201b3635ca so let's drop it now.


fix bug where OffscreenCanvas.getContext is null

Re submission of fix to bug where an iOS webview OffscreenCanvas would return a context of null.

Cheers
Justl a couple of eslint rules to fix
707:9  warning  Expected blank line after variable declarations  newline-after-var
708:9  warning  Expected newline before return statement         newline-before-return
✖ 2 problems (0 errors, 2 warnings)
0 errors and 2 warnings potentially fixable with the --fix option.

Codecov Report

Merging #5942 into dev will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev    #5942      +/-   ##
==========================================
+ Coverage   70.38%   70.38%   +<.01%
==========================================
  Files         208      208
  Lines       10494    10493       -1
==========================================
  Hits         7386     7386
+ Misses       3108     3107       -1

Impacted Files
Coverage Δ

packages/text/src/TextMetrics.js
95.17% <100%> (-0.03%)
:arrow_down:

packages/ticker/src/Ticker.js
88% <0%> (+0.79%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00c4648...f2f7f4d. Read the comment docs.

Cheers!
Just a couple of eslint rules to fix
707:9 warning Expected blank line after variable declarations newline-after-var
708:9 warning Expected newline before return statement newline-before-return
✖ 2 problems (0 errors, 2 warnings)
0 errors and 2 warnings potentially fixable with the --fix option.

Ok the eslint problems are now fixed


[Media Compositions] Regenerating SDK for swagger discriminator changes

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Communication.MediaComposition


Support recursive relationships

@msw/data does not support recursive relationships, but it is useful for mocking social media like Twitter, Facebook, etc.
Test code:
import { factory, manyOf, primaryKey } from '@msw/data'
import { v4 } from 'uuid'

test('supports recursive relationships', () => {
  const db = factory({
    user: {
      id: primaryKey(v4),
      friends: manyOf('user'),
    },
  })
  const firstUser = db.user.create({ friends: [] })
  const secondUser = db.user.create({ friends: [firstUser] })
  db.user.update({
    where: { id: { equals: firstUser.id } },
    data: { friends: [secondUser] },
  })
  expect(secondUser.friends[0].id).toEqual(firstUser.id)
})

Current output:
RangeError: Maximum call stack size exceeded
        at JSON.stringify (<anonymous>)

      55 | function executeQuery(modelName, primaryKey, query, db) {
      56 |     var _a;
    > 57 |     log(JSON.stringify(query) + " on \"" + modelName + "\"");
         |              ^
      58 |     log('using primary key "%s"', primaryKey);
      59 |     var records = db.getModel(modelName);
      60 |     // Reduce the query scope if there's a query by primary key of the model.

      at Object.executeQuery (lib/query/executeQuery.js:57:14)
      at lib/relations/Relation.js:137:57
          at Array.reduce (<anonymous>)
      at Object.get [as friends] (lib/relations/Relation.js:135:50)
          at Function.entries (<anonymous>)
      at removeInternalProperties (lib/utils/removeInternalProperties.js:51:39)
      at lib/utils/removeInternalProperties.js:72:32
          at Array.map (<anonymous>)
      at removeInternalProperties (lib/utils/removeInternalProperties.js:70:50)
      at lib/utils/removeInternalProperties.js:72:32
          at Array.map (<anonymous>)
      // same output continues...
      at removeInternalProperties (lib/utils/removeInternalProperties.js:70:50)
      at lib/utils/removeInternalProperties.js:72:32
          at Array.map (<anonymous>)

Hey, @tkamenoko. Thank you for suggesting this!
I think this library can benefit from supporting recursive relationships. I particularly like your example for its simplicity.
So the infinite cycle is triggered by the removeInternalProperties function that's designed to return developer-friendly data stripped of all internal properties like __type and __primaryKey. When cleaning firstUser it eventually encounters firstUser.friends and understand that it's a relation:
https://github.com/mswjs/data/blob/35077afb48e4bbbfdb353c764f6fcf255138578b/src/utils/removeInternalProperties.ts#L62-L67
So it iterates over all referenced entities and removes internal properties from them as well. What goes wrong is that one of the referenced entities has its own .friends property which now references firstUser (we are still in the .map recursive call right now), and thus the infinity spawns.


decline button

Hi,
I'd like to know the behavior of the decline button: if I click on it, a cookie is set (_cle=declined), and the banner stays displayed? (shouldn't it be hidden?)

+1
Yes, how close the banner if user click on decline button ?

Yes, the banner should close when the decline button is pressed. I'll check this function.
Thank you

https://github.com/Palmabit-IT/angular-cookie-law/pull/18


udFile absorbing functionality

This is pending this MR

Was closed accidentally because target branch was merged and deleted.


Add module global type information APIs

Plus, I kindly thought we should use wasm_runtime_get_import_type and wasm_runtime_get_export_type to implement wasm_module_exports and wasm_module_imports in order to keep the code simple.

Plus, I kindly thought we should use wasm_runtime_get_import_type and wasm_runtime_get_export_type to implement wasm_module_exports and wasm_module_imports in order to keep the code simple.

I think we can do that once all the import/export types exposed in wasm_export.h. After this change lands and globals are exposed, then also memory and tables would need to be exposed. Once functions, globals, memory, and tables are all exposed, then some of the internals of wasm_module_exports and wasm_module_exports can be converted to use those new APIs. Unless maybe I'm missing something, and you see a way to partially convert those function internals?


Fix import path of golint

Same fix as here:
https://github.com/libopenstorage/stork/pull/157#issue-222576593

Already fixed


doc: update PR template

replace changelog PR checklist item with GitHub label item, both to support automatic releases and changelogs with auto
addresses #87

:rocket: PR was released in v1.19.7 :rocket:


Update the SDK

Round 2!
We want this for a myriad of reasons, selfishly I want this to re enable ANCM out of process tests.
Fixes: https://github.com/aspnet/AspNetCore-Internal/issues/2001

@dougbu @livarcocc  seems like version mis match for our targeting pack:
GitHub: https://github.com/dotnet/core
Docs: https://aka.ms/dotnet-docs
HTTPS: https://aka.ms/aspnet-core-https
  Persisting no-op dg to /Users/vsts/agent/2.148.2/work/1/s/build/tasks/obj/RepoTasks.csproj.nuget.dgspec.json
/Users/vsts/agent/2.148.2/work/1/s/build/tasks/RepoTasks.csproj : error NU1102: Unable to find package Microsoft.AspNetCore.App.Ref with version (>= 3.0.0-preview4-19175-38)
/Users/vsts/agent/2.148.2/work/1/s/build/tasks/RepoTasks.csproj : error NU1102:   - Found 163 version(s) in https://dotnet.myget.org/F/aspnetcore-dev/api/v3/index.json [ Nearest version: 3.0.0-preview4-19172-03 ]
/Users/vsts/agent/2.148.2/work/1/s/build/tasks/RepoTasks.csproj : error NU1102:   - Found 132 version(s) in https://dotnet.myget.org/F/dotnet-core/api/v3/index.json [ Nearest version: 3.0.0-preview4-19172-03 ]
/Users/vsts/agent/2.148.2/work/1/s/build/tasks/RepoTasks.csproj : error NU1102:   - Found 102 version(s) in https://dotnetfeed.blob.core.windows.net/aspnet-aspnetcore/index.json [ Nearest version: 3.0.0-preview4-19172-03 ]
/Users/vsts/agent/2.148.2/work/1/s/build/tasks/RepoTasks.csproj : error NU1102:   - Found 28 version(s) in dotnet-core [ Nearest version: 3.0.0-preview4-19121-14 ]
/Users/vsts/agent/2.148.2/work/1/s/build/tasks/RepoTasks.csproj : error NU1102:   - Found 1 version(s) in nuget.org [ Nearest version: 3.0.0-preview3-19153-02 ]
/Users/vsts/agent/2.148.2/work/1/s/build/tasks/RepoTasks.csproj : error NU1102:   - Found 0 version(s) in https://dotnet.myget.org/F/aspnetcore-master/api/v3/index.json
/Users/vsts/agent/2.148.2/work/1/s/build/tasks/RepoTasks.csproj : error NU1102:   - Found 0 version(s) in myget.org aspnetcore-tools
/Users/vsts/agent/2.148.2/work/1/s/build/tasks/RepoTasks.csproj : error NU1102:   - Found 0 version(s) in https://dotnet.myget.org/F/blazor-dev/api/v3/index.json
/Users/vsts/agent/2.148.2/work/1/s/build/tasks/RepoTasks.csproj : error NU1102:   - Found 0 version(s) in https://dotnet.myget.org/F/roslyn-tools/api/v3/index.json
/Users/vsts/agent/2.148.2/work/1/s/build/tasks/RepoTasks.csproj : error NU1102:   - Found 0 version(s) in https://dotnet.myget.org/F/roslyn/api/v3/index.json
/Users/vsts/agent/2.148.2/work/1/s/build/tasks/RepoTasks.csproj : error NU1102:   - Found 0 version(s) in https://dotnetfeed.blob.core.windows.net/aspnet-aspnetcore-tooling/index.json
/Users/vsts/agent/2.148.2/work/1/s/build/tasks/RepoTasks.csproj : error NU1102:   - Found 0 version(s) in https://dotnetfeed.blob.core.windows.net/aspnet-entityframeworkcore/index.json
/Users/vsts/agent/2.148.2/work/1/s/build/tasks/RepoTasks.csproj : error NU1102:   - Found 0 version(s) in https://dotnetfeed.blob.core.windows.net/aspnet-extensions/index.json
/Users/vsts/agent/2.148.2/work/1/s/build/tasks/RepoTasks.csproj : error NU1102:   - Found 0 version(s) in https://dotnetfeed.blob.core.windows.net/dotnet-windowsdesktop/index.json
/Users/vsts/agent/2.148.2/work/1/s/build/tasks/RepoTasks.csproj : error NU1102:   - Found 0 version(s) in https://vside.myget.org/F/devcore/api/v3/index.json
/Users/vsts/agent/2.148.2/work/1/s/build/tasks/RepoTasks.csproj : error NU1102:   - Found 0 version(s) in https://vside.myget.org/F/vsmac/api/v3/index.json
/Users/vsts/agent/2.148.2/work/1/s/build/tasks/RepoTasks.csproj : error NU1102:   - Found 0 version(s) in https://vside.myget.org/F/vssdk/api/v3/index.json
  Restore failed in 16.7 sec for /Users/vsts/agent/2.148.2/work/1/s/build/tasks/RepoTasks.csproj.

Build FAILED.

Not sure what is going on.

@JunTaoLuo

@jkotalik did you search a binary log for the 3.0.0-preview4-19172-03 and 3.0.0-preview4-19175-38 version strings? I don't see either 19172-03 or 19175-38 in any sources in this repo and the build logs show those versions only in the error messages. Would be good to know where those strings are coming from.

The binary logs from the build show 3.0.0-preview4-19175-38 was the build number generated from version.props for the PackageVersion and TargetingPack. 3.0.0-preview4-19172-03 is just the nearest version available on myget: https://dotnet.myget.org/feed/dotnet-core/package/nuget/Microsoft.AspNetCore.App.Ref.
I don't understand why the targeting pack is trying to pull from nuget. Unless I don't understand this at all, the targeting pack should be built as part of this build, correct?

At least from the SDK point of view that is true if you are referring to the same version of the targeting pack that ships with the SDK. If for some reason, you say you want a different version of the targeting pack and we can't find it on disk, we will fetch it using nuget.

We need to get this in ASAP, it's blocking some Razor work I believe (cc @NTaylorMullen). @dougbu do we know what we need to do to either resolve this or get more information?

Current issues:

Dotnet watch tests are failing, I can investigate/disable these for now. I have a feeling it is due to child process spawning
Linux ARM/MSUL failures:

/home/vsts/work/1/s/src/Framework/src/Microsoft.AspNetCore.App.Runtime.csproj(326,5): error : Could not find crossgen /home/vsts/work/1/s/.nuget/packages/runtime.linux-arm64.microsoft.netcore.app/3.0.0-preview4-27524-03/tools/x64_arm64/crossgen

@dougbu @JunTaoLuo thoughts?

@dougbu do we know what we need to do to either resolve this or get more information?

I'm starting to suspect something changed in <Reference> handling code from the SDK and that we need to react. @livarcocc where does the SDK look on disk?

@dougbu targeting packs should show up under the packs folder in the dotnet hive. For instance:
dotnet
packs
Microsoft.AspNetCore.App.Ref
3.0.0-preview4-19172-03
shared
sdk

@livarcocc I meant "where does the SDK look on disk when resolving <Reference/> items?" I seem to remember that infrastructure is in either AspNetCore or BuildTools. But, it must be relying on something in the SDK because otherwise nothing would break when updating the SDK. My question was therefore likely too broad because I'm not sure of the "something".
@jkotalik can you track down (e.g. using the bin logs) where the build looks for the targeting packs and why they're not found? Suggest comparing to builds of our master branch.

@JunTaoLuo should be involved here since he owns the targetting pack stuff now.

Here is the information I gathered from the latest sdk update. The runtime.linux-arm.microsoft.netcore.app isn't getting restored on the latest sdk, therefore causing the CrossGenToolPath to not exist. @JunTaoLuo says he is knowledgeable about this.

I don't see issues with the targeting pack anymore but I'm investigating the crossgen issue

Derp, it's because the path has an incorrect part:
Could not find crossgen E:\A\_work\1\s\.nuget\packages\/runtime.win-arm.microsoft.netcore.app/3.0.0-preview4-27524-03/tools/x86_arm\crossgen.exe Took me longer than I'd admit to spot it. I'll push a fix.

Derp, it's because the path has an incorrect path:
Could not find crossgen E:\A_work\1\s.nuget\packages/runtime.win-arm.microsoft.netcore.app/3.0.0-preview4-27524-03/tools/x86_arm\crossgen.exe Took me longer than I'd admit to spot it. I'll push a fix.

I spent an entire day trying to figure that out, so don't feel bad 😄

Took me longer than I'd admit to spot it.

Dude you don't even want to know how many times that's happened to me ;)

Seems like it's naive to assume the path would be the only issue. Now that all builds are broken, I'll take a deeper dive to see what's going on with crossgen.

I've implemented a workaround to the SDK issue by directly adding a reference to runtime.RID.microsoft.netcore.app to the M.A.App.Runtime package. I think it should be safe since I marked it with PrivateAsset=All but I'd like to run it by someone else as well (which is what this PR is for anyway). I'm seeing the crossgen step passing on all builds now.
Now I'm seeing an error during CodeSign:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\MSBuild\Current\Bin\msbuild.exe /bl:artifacts/logs/build.codesign.binlog /clp:Summary /m /nodeReuse:false /p:KoreBuildVersion=3.0.0-build-20190322.1 /p:SuppressNETCoreSdkPreviewMessage=true /p:RepositoryRoot=F:\workspace\_work\1\s\ /p:SignType= /p:DisableSignCheck=true /p:BuildManaged=true /p:BuildNative=true /p:_RunBuild=True /p:_RunPack=False /p:_RunTests=False /p:_RunSign=True /p:TargetArchitecture=x64 /p:TargetOsName=win /t:CodeSign /verbosity:minimal F:\workspace\_work\1\s\.dotnet\buildtools\korebuild\3.0.0-build-20190322.1\scripts\..\KoreBuild.proj
F:\workspace\_work\1\s\build\repo.targets(138,5): error MSB4018: The "RepoTasks.RemoveSharedFrameworkDependencies" task failed unexpectedly. [F:\workspace\_work\1\s\.dotnet\buildtools\korebuild\3.0.0-build-20190322.1\KoreBuild.proj]
F:\workspace\_work\1\s\build\repo.targets(138,5): error MSB4018: System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified. [F:\workspace\_work\1\s\.dotnet\buildtools\korebuild\3.0.0-build-20190322.1\KoreBuild.proj]
F:\workspace\_work\1\s\build\repo.targets(138,5): error MSB4018: File name: 'System.Runtime, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [F:\workspace\_work\1\s\.dotnet\buildtools\korebuild\3.0.0-build-20190322.1\KoreBuild.proj]
F:\workspace\_work\1\s\build\repo.targets(138,5): error MSB4018:    at RepoTasks.RemoveSharedFrameworkDependencies.Execute() [F:\workspace\_work\1\s\.dotnet\buildtools\korebuild\3.0.0-build-20190322.1\KoreBuild.proj]
F:\workspace\_work\1\s\build\repo.targets(138,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [F:\workspace\_work\1\s\.dotnet\buildtools\korebuild\3.0.0-build-20190322.1\KoreBuild.proj]
F:\workspace\_work\1\s\build\repo.targets(138,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext() [F:\workspace\_work\1\s\.dotnet\buildtools\korebuild\3.0.0-build-20190322.1\KoreBuild.proj]
F:\workspace\_work\1\s\build\repo.targets(138,5): error MSB4018:  [F:\workspace\_work\1\s\.dotnet\buildtools\korebuild\3.0.0-build-20190322.1\KoreBuild.proj]
F:\workspace\_work\1\s\build\repo.targets(138,5): error MSB4018: WRN: Assembly binding logging is turned OFF. [F:\workspace\_work\1\s\.dotnet\buildtools\korebuild\3.0.0-build-20190322.1\KoreBuild.proj]
F:\workspace\_work\1\s\build\repo.targets(138,5): error MSB4018: To enable assembly bind failure logging, set the registry value [HKLM\Software\Microsoft\Fusion!EnableLog] (DWORD) to 1. [F:\workspace\_work\1\s\.dotnet\buildtools\korebuild\3.0.0-build-20190322.1\KoreBuild.proj]
F:\workspace\_work\1\s\build\repo.targets(138,5): error MSB4018: Note: There is some performance penalty associated with assembly bind failure logging. [F:\workspace\_work\1\s\.dotnet\buildtools\korebuild\3.0.0-build-20190322.1\KoreBuild.proj]
F:\workspace\_work\1\s\build\repo.targets(138,5): error MSB4018: To turn this feature off, remove the registry value [HKLM\Software\Microsoft\Fusion!EnableLog]. [F:\workspace\_work\1\s\.dotnet\buildtools\korebuild\3.0.0-build-20190322.1\KoreBuild.proj]
F:\workspace\_work\1\s\build\repo.targets(138,5): error MSB4018:  [F:\workspace\_work\1\s\.dotnet\buildtools\korebuild\3.0.0-build-20190322.1\KoreBuild.proj]

I'm passing the hot potato back to you to re-assign @anurse.

an error during CodeSign

Didn't you see something similar when updating the BuildTools version used in AspNetCore release/2.2? Might be the sign tools package (from Arcade IIRC) has the same bug as what you pulled into that branch originally.

That was MSBuild not being found. This is System.Runtime not being found. I haven't investigated but I wouldn't be surprised if the solution end up being similar. However, this is definitely a different problem.

I meant in the middle of that work, you hit a similar DLL loading issue and the people you contacted said it was due to a sign tool bug

Ooops. Reading closer, this is RepoTasks that's failing and it's built in the previous part of the build.
You're right: Totally different problem.

So it seems like the repo task is being published for the .NET Framework:
RepoTasks -> F:\workspace\_work\1\s\build\tasks\bin\Release\net472\RepoTasks.dll

However, when it's being run as part of code sign, it's trying to load the System.Runtime from .NET Core. This seems strange and I'll keep digging on whether this is the issue.

Latest theories and results:

System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=<IP_ADDRESS> often occurs when loading tools compile for dotnet core from msbuild.exe or loading tools compile for .net framework from dotnet msbuild.
I have confirmed that the published tool on the CI targets .net framework and is invoked from msbuild.exe

I'm at a loss for why this error could be occurring then.

I stand corrected. If the codesign job is run after the x64 and x86 builds, the published RepoTask tool is being published for netcoreapp3.0. That's what's breaking the build. Need to figure out why that's happening.

Okay so apparently the Build Site Extension step publishes the build tool for netcoreapp3.0:
2019-03-31T15:47:44.9399474Z Welcome to .NET Core!
2019-03-31T15:47:44.9400070Z ---------------------
2019-03-31T15:47:44.9401007Z GitHub: https://github.com/dotnet/core
2019-03-31T15:47:44.9401317Z Docs: https://aka.ms/dotnet-docs
2019-03-31T15:47:44.9401525Z HTTPS: https://aka.ms/aspnet-core-https
2019-03-31T15:47:51.5738649Z   Persisting no-op dg to F:\workspace\_work\1\s\build\tasks\obj\RepoTasks.csproj.nuget.dgspec.json
2019-03-31T15:47:59.0651324Z   Restore completed in 7.29 sec for F:\workspace\_work\1\s\build\tasks\RepoTasks.csproj.
2019-03-31T15:48:08.9223418Z   RepoTasks -> F:\workspace\_work\1\s\build\tasks\bin\Release\netcoreapp3.0\RepoTasks.dll
2019-03-31T15:48:09.1437368Z   RepoTasks -> F:\workspace\_work\1\s\build\tasks\bin\publish\

Seems like the publish directory isn't being overwritten in the code sign step and that's why we're seeing the failure. I added a build step that clears this directory as a workaround-ish fix but it would be best if we were able to figure out if updating the SDK changed any behaviour and caused this.

@aspnet-hello triage https://dev.azure.com/dnceng/public/_build/results?buildId=139014&view=logs

This comment was made automatically. If there is a problem contact ryanbrandenburg.
I've triaged the above build.

Got the build working but didn't do full analysis of what changed in the SDK to cause the issues in the first place.

I'll handle merging this at this point.   If they are, suggest removing the tests entirely. If not, suggest marking them as flaky everywhere. (That way, we at least get some scenario coverage.)
Either way, #8267 doesn't look like it justifies skipping the tests entirely. Suggest adding information about the "90% of the time" you mentioned.

9 tests skipped due to failures on helix

/cc @aspnet/brt

handle merging

Please "Squash and merge" 😺

Very nice @JunTaoLuo ! Thanks for digging through the MSBuild muck to solve that!

@aspnet-hello triage https://github.com/aspnet/AspNetCore/pull/8670/checks?check_run_id=90187601

@jkotalik that won't work, you have to post the link to the VSTS build that failed. I'm going to file an issue to have RaaS comment when you give a wrong url (you are not alone in making that kind of mistake).

Yeah messed up copy paste.

Everything passed, but @jkotalik was being impatient with the macOS build and cancelled it (even though it eventually passed ;)). Using admin powers for awesome to force-merge.

🎉


[SPARK-47964][PYTHON][CONNECT] Hide SQLContext and HiveContext in pyspark-connect

What changes were proposed in this pull request?
This PR hides SQLContext and HiveContext in pyspark-connect. They do not exist there.
Why are the changes needed?
To recover https://github.com/apache/spark/actions/runs/8805830494
Does this PR introduce any user-facing change?
No, the main change has not been released yet.
How was this patch tested?
Manually.
Was this patch authored or co-authored using generative AI tooling?
No.

Merged to master.


Adding Puerto Rico

Also noticed, Puerto Rico has TIGER ways for days but isn't part of the US extract. Would it be a good idea to add it to this map? Thanks!

I was wondering about this the other day! Probably should investigate the other US territories.

I think this is fixed with this https://github.com/watmildon/TIGERMap/commit/d741e122f2c6de119126f96500ffd8a77f809ea8
USVI doesn't seem to have any tiger stuff. Let me know if you discover any other things hanging around. It should get generated later tonight.

The site is updated and looks great. Thanks again for pointing it out!


CSS - "opacity" percentage values are bundled incorrectly.

Describe the bug
Using a percentage value for the opacity CSS value will work fine in development with HMR, but the minified bundle will incorrectly set all opacity values to 1%.
Did you try recovering your dependencies?
Can reproduce with a fresh CRA app.
Environment
System:
OS: Windows 10
CPU: (8) x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
Binaries:
Node: 12.13.0 - C:\Program Files\nodejs\node.EXE
Yarn: 1.9.4 - ~\AppData\Roaming\npm\yarn.CMD
npm: 6.12.0 - C:\Program Files\nodejs\npm.CMD
Browsers:
Edge: 42.17134.1038.0
Internet Explorer: 11.0.17134.1
npmPackages:
react: ^16.11.0 => 16.11.0
react-dom: ^16.11.0 => 16.11.0
react-scripts: 3.2.0 => 3.2.0
npmGlobalPackages:
create-react-app: Not Found
Steps to reproduce
(Write your steps here:)

Create a new CRA app.
Open App.css and add opacity: 70% to the .App-header class.
Run yarn start. Inspect the header element and confirm that the opacity is 70%.
Run yarn build. Once the build is finished, open the minified css file in build/static/css. Search for opacity and observe that it is 1%.

Expected behavior
The opacity value should be minified as the same value in the source file.
Actual behavior
The opacity value is 1% no matter what percentage is used.

I also having this issue

Seems to be an issue in https://github.com/NMFR/optimize-css-assets-webpack-plugin
At least when I disable that plugin in CRA's webpack config  the output stays the same.
Note that percentage support  for opacity isn't supported in all browsers https://developer.mozilla.org/en-US/docs/Web/CSS/opacity#Browser_compatibility


General Grievance: Watch 3rdlinemusic.de

General Grievance requests the watch of the watch_keyword 3rdlinemusic\.de. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

3rdlinemusic\.de has been seen in 0 true positives, 0 false positives, and 0 NAAs.


Script editor loses focus (the cursor) when running the project

Godot version:
3.2.2.rc
OS/device including version:
Debian Buster amd64, Radeon RX550
Steps to reproduce:

Open any script in a script editor
Launch a project and close it
Your blinking cursor disappeared from the script editor - I don't even know where is it. (Not only do you have to reach for your mouse, but you don't even remember where you left your cursor.)
(Workaround found) Press F2, then F3 - now your cursor is back.
(More info found) Instead of pressing F2 then F3, just press F3 two or more times to get an error message in the console.

I can confirm this on Godot 3.2.1.

This has been around since 3.0 (at least - I only discovered Godot at 3.0), so it's not a regression, but I could only figure out the workaround now.

Just want to note that this happens on macOS as well and the F-key workarounds do not work.
3.2 on macOS 10.14.6.
It seems to work properly on master (4.0) though.

3.4.4 Stable Linux
That's very annoying.

Reproduced in: v3.5.1.stable.official [6fed1ffa3]
But as stated above: https://github.com/godotengine/godot/issues/39632#issuecomment-655621620

It seems to work properly on master (4.0) though.

Confirmed, it's working as expected in: v4.0.beta5.official [89a33d28f] (in Win 10 22H2)
With the cursor blinking in the script editor:

F5 runs the project.
F8 stops the project

And now the cursor resumes blinking in the script editor, and the script is editable.


Fixed issue with downloading creation script

The EC2 instance failed to download the creation_v2.sh script
Changed from aws s3 cp to wget
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@iatraviscox - I have figured out the issue. It works with taskcat but is failing if you launch it from the landing page due to a mismatch in the policy.
The instance role gets access to: "arn:aws:s3:::aws-quickstart-us-east-1/quickstart-inductive-automation-ignition/*", whereas the s3 command is pulling from aws-quickstart bucket. I'll update the user data to fetch from the regional bucket instead and then it would work. I'll update this PR and test.

/do-e2e-tests

@iatraviscox , @pvirk - just FYI, this is resolved. I verified that the published launch link (https://fwd.aws/jNAg7?) works for creating the stacks.


Removed execution policies for Apple platforms

Execution policies std::execution::* are not yet supported on Apple platform's compilers, so this PR will make this library compile-able there.

I implemented it in the required manner. 50e31f11666de790b3dc717dc720f33c2f7301f9
Again, thank you for your contribution!


Add: Import contribs to prereg Authors section

[OSF-4346]
If a user has more than one contributor on a project, they will have the option to import all of their contributors or to select from a list of their contributors to fill the 'Authorship' question for the prereg challenge form.
The form only appears when the user is on the Authorship question and there is more than one contributor on a project.
The button:

The modal:

After selection:

The placement of the "import contributors" button is very non-obvious: would it make more sense to move it directly next to the text box that it acts upon?
(pinging @caneruguz , because he loves getting emails)

CR1 pass complete. Some code cleanup, some UI suggestions, and a potential bug question. Return to me when ready, please.

On this point: https://github.com/CenterForOpenScience/osf.io/pull/4425#issuecomment-150707203
I agree with @abought. The organization is done with "all buttons go here" logic but that doesn't make meaningful sense since authorship step is above and it's not related to process events like "Save" or "Register"

@abought Comments have been addressed. Import button now appears as such:

After moving the 'Import Contributors' button to a more logical place, there is some odd behavior. You will need to click on the Authors nav tab initially or move to another question and come back to 'Authorship' in order to get the button to appear. I know why this is happening and will be resolved with #4329
Also, the strangeness with some of the questions has to do with $osf.iterObject not being present in this branch. This has also been added in the PR mentioned above. I don't think it is necessary to have in order to review what is going on here but if you do I can add those commits to this PR too.

Also, the strangeness with some of the questions has to do with $osf.iterObject not being present in this branch. This has also been added in the PR mentioned above. I don't think it is necessary to have in order to review what is going on here but if you do I can add those commits to this PR too.

Agreed. I noted it only because of the possible checkbox bug (in case you wanted form items to test that with). Since the selector has been made more specific, we can deal with anything else in testing later.

After moving the 'Import Contributors' button to a more logical place, there is some odd behavior. You will need to click on the Authors nav tab initially or move to another question and come back to 'Authorship' in order to get the button to appear. I know why this is happening and will be resolved with #4329

Can you please add a note to 4329, instructing testers to verify the bugfix works as expected? This is important information that crosses ticket boundaries; if we can't test it now we should make sure to keep track of it.

CR1 complete; moving to CR2. May revisit some refactorings based on status of Lyndsy draft reg changes.

@barbour-em pass finished

LGTM, merging this manually into samchrisinger:feature/prereg-prize
You can close this PR


[FEAT] Password Change Confirmation Email

Description
The Password Change Confirmation feature enables users to securely reset their passwords by verifying a provided reset token and updating their password.  By ensuring that the reset token is valid and that the new password meets security requirements, this feature enhances the overall security of user accounts.
Note: All email-related functionalities, including sending password reset emails, are managed by a centralized email service within the application. This ensures consistency in email templates, delivery, and management, providing a uniform user experience and simplifying email administration across different features.
Acceptance Criteria
Password Change Confirmation Endpoint [POST] /api/v1/auth/confirm-password-reset
Purpose
The primary purpose of the Password Change Confirmation feature is to provide a secure mechanism for users to reset their passwords. This ensures that users can regain access to their accounts if they have forgotten their passwords or if their accounts have been compromised. By verifying the reset token and enforcing password security requirements, the feature enhances the overall security of user accounts.
Requirements

[ ] User Information:
The request must include the user's first name, last name, and the new password.

[ ] Secure Token:
A valid reset token must be provided to confirm the password reset.
The token must be validated for authenticity and expiry.

[ ] Endpoint:
An API endpoint (POST /api/v1/auth/confirm-password-reset) to handle the password reset confirmation.

[ ] Error Handling:
Appropriate error responses for invalid token, expired token, and weak password scenarios.
If the reset token is invalid, the system should respond with an appropriate error message.
If the reset token has expired, the system should respond with an appropriate error message.

Expected Outcome
The system should successfully update the user's password if the reset token is valid and the new password meets the security requirements.
Appropriate error messages should be provided for invalid token, expired token, and weak password scenarios.

Standard Formats for Requests and Responses
Request Formats

Request:

Method: POST

URL: /api/v1/auth/confirm-password-reset
[
    {
        "token": "reset-token",
        "newPassword": "newPassword123",
        "firstName": "John",
        "lastName": "Doe"
   }

]

Successful Response:

Status Code: 200 OK

Response Body (JSON):
[
    {
        "message": "Password has been reset successfully."
   }

]

Error Handling:

Status Code: 400 Bad Request

Error Responses (JSON):
[

   {
        "code": "AUTH_INVALID_TOKEN",
        "message": "The password reset token is invalid or has expired."
    }

]

emails are centralised

does not make sense

I have made some changes sir, please review


Added Material Calendar View

I have added my library Material Calendar View! Hope youn can add it!

Thanks!


How would I go about using this library via Vue?

I've tried import baffle from 'baffle'; let b = baffle('#baffled'); b.start(); but it doesn't do anything at all.

@swwwnsn  It is working fine for me.
for further help you can refer to my repo https://github.com/Junip551/Vue-baffle

Hi, I'm trying to use this in a Nuxt setup, but when I tried to import it in / as plugin I've this error...

and here's import...

@creatpix103  After installing baffle you can directly use baffle, just you need to import it as you have already done. you can look into the implementation in my repo https://github.com/Junip551/Vue-baffle


Improve painter order

Improves the order of painting through the following:

rangeAnnotation painting moved outside of the for loop. extraLines removed from the for loop except when extraLinesOnTop is enabled. probably improved performance.
the order of painting is revised to background → range annotations → grid → extralines → barLine → dots → (optional): extralines  → touchIndicator

I think I can't push to this PR, because it is in your fork.

that shouldn't be the case. you don't have directions below the merge button that let you push to it?

I think I need permission to push on your forked repo.

I think I need permission to push on your forked repo.

I added permissions to my fork but here is what the checkbox says:

I think you might have a duplication:
git push shamilovtim patch-range-annotations the name isn't shamilovtim/patch-range-annotations but only "patch-range-annotations"

also i just noticed that your current branch says 'shamilovtim-patch-range-annotations'. you could try to rename it maybe?

I'm lost :))))

wait for a second

in your terminal you're pushing to my repo named 'shamilovtim' a branch named shamilovtim/patch-range-annotations but your branch is actually named 'shamilovtim-patch-range-annotations' but the real branch name on my repo is only 'patch-range-annotations'
at least i think that's what's going on. i might be wrong. lol

That was a hard work :)

I cloned your repo, then I checked out to the patch-range-annotations branch
then I added imaNNeoFighT/fl_chart as a new remote (I called itneo)
then I ran git fetch neo command
cherry-pick that commit from my remote
rebase your branch with neo/master
force pushed to patch-range-annotations branch

BTW, It's ready to merge in my opinion,
you can have a look at it, and approve my changes to merge.
Thanks!

I haven't tested manually but it looks fine to merge to me


rcp: allow to return promise instead of forcefully synchronous result()

It can be a good integration to add the support for returning Promise for rpc call, along with synchronous result.
for now, it seem we can do:
with ClusterRpcProxy(config) as cluster_rpc:
    set_handler_for_events()
    hello_res = cluster_rpc.service_x.remote_method.call_async("hello")
    hello_res.result()
    teardown_handler()

but if we don't care for the result, but must run some code (cleanup?) after the rpc is finished, without blocking the whole function, it would be nice to do
with ClusterRpcProxy(config) as cluster_rpc:
    set_handler_for_events()
    hello_res = cluster_rpc.service_x.remote_method.call_async("hello")
    promise = hello_res.promise()
    @promise.then
    def after():
        teardown_handler()

this should add a promise method to RpcReply  which return a Promise (generic).
I don't know how to do without blocking. but it seem a good use case.

I just wrote some snippet to achieve this via promise python package:
import eventlet
from promise.promise import Promise

def make_promise(result_async):
    def promise_caller(resolve, reject):
        def promise_waiter():
            resolve(result_async.result())  # will wait for rcp reply
        eventlet.spawn(promise_waiter)
    return Promise(promise_caller)

with ClusterRpcProxy(config) as cluster_rpc:
    set_handler_for_events()
    hello_res = cluster_rpc.service_x.remote_method.call_async("hello")
    promise = make_promise(hello_res)
    @promise.then
    def after(result):
        teardown_handler()

I think the snippet you have here is a perfectly good solution, and it's better for it to live in your application (tailored to your particular use-case) than to become part of the framework.

thanks for the fast reply :smile: .
it's true and I understand why you want to keep it outside the framework, but it may be a good idea to integrate some snippet like this to the doc, showing how nameko can be used along with differents patterns.


fix: align select overlay horizontally

Description
The PR adapts the solution from vaadin/web-components#2153 to the select component so that the select overlay would align right or left depending on how much space is available on both sides and not only depending on whether RTL mode is on (the way it was before).
Fixes https://github.com/vaadin/web-components/issues/3222
Type of change

[x] Bugfix

Checklist

[x] I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
[x] I have added a description following the guideline.
[x] The issue is created in the corresponding repository and I have referenced it.
[x] I have added tests to ensure my change is effective and works as intended.
[x] New and existing tests are passing locally with my change.
[x] I have performed self-review and corrected misspellings.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

The current test failures are caused by poor test coverage of this repo in general and not related to my changes:
Error: Coverage failed


added travis ci

uploaded travis config file and added travis&codecov badges to readme

please note that checks will fail until pull request #35 is accepted

Closing this one, after PR #39, this commit in particular.


GoToDef .Templ templ() instead of .go func ()

Anyone come up with some ways in neovim to jump to the templ()  declaration instead of the golang function?

Hi, there are some suggestions in the following issue: https://github.com/a-h/templ/issues/387

Ahh sorry,  I searched a few times but didn't find anything.  ./doh.


Custom cursor does not follow when using the scroll wheel

Describe the bug
If you leave the mouse static while you are scrolling down the page, the cursor will not follow the movement until you move it again.
To Reproduce
Steps to reproduce the behavior:
1- Scroll without moving the custom cursor
2- See how it stops and comes back again after movement (with the mouse, not the scroll wheel)
Expected behavior
Make the custom cursor follow the default at all times (when enabled).
Desktop (please complete the following information):

OS: Windows 10
Browser: Mozilla Firefox Developer Edition
Version: 89

Hi @Miguelklappes 😄
Thank You for this issue, but i think it's something normal because I'm tracking the mouse-move and not the on-scroll events..
And i think it became a little bit complicated to do that.
Usually is the default behavior, if you scroll with the mouse hover something, the hover still keep in the previous element.
But if You want to try to make a PR with this enhancement, I'm happy to check and review it!
Have a nice day! 😸


Fixes dual vent + Adds dual scrubber

About the PR

The dual vent inherited the wrong base so not sure if it ever worked.
It's visualizer also never worked as it had the wrong component type.
Gave it the same components as the unary pumped vent so it now is APC net and air alarm compliant.
Also added a dual port scrubber - this is using the default scrubber component for now, couldn't get a dual port scrubber component to work in testing so any help with that would be appreciated - it makes the visualizer not work and also might prevent it from taking air from one pipe direction.

Screenshots

Changelog

:cl:

add: Added a dual port scrubber to make atmos piping more compact.
fix: The dual port vent now works correctly.

conflicts, also screenshot?

You coming back to this @Peptide90 ?


add tests for io::timeout

CI failed because of async_await feature block being deprecated in the newer rustc.
Waiting for https://github.com/async-rs/async-std/pull/94 to merge.

@kpp #94 is on track over the day.

ping?


[stable/kured] Autolock is not turned on at deployment time

Describe the bug
If you enable the autolock feature, the lock annotation is not applied until the first time the lock cronjob is run, which if your only allow updates once a week, could be a long time.
Version of Helm and Kubernetes:
Helm: 3.0
Kubernetes: 1.15
Which chart:
stable/kured
What happened:
Autlock annotation was not created at deploy time
What you expected to happen:
Autolock annotation should be created at deployment time to put Kured into a locked state right out of the box, and then removed at the next cron run time.
How to reproduce it (as minimally and precisely as possible):
Deploy Kured and check annotation
Anything else we need to know:

I resolved this by adding the annotation to the "podAnnotations" value, so not really an issue.


Make the testbed generic over RealField.

This leaves all the graphics objects in f32, but allows using an f64 world: Shapes are converted to an f32 representation, and inputs are converted back.

Looks like I forgot some --feature=fluids stuff. Working on it.

Getting some frustrating errors now with the fluids feature:
the trait `nphysics3d::object::collider_set::ColliderSet<N, _>` is not implemented for `nphysics::object::DefaultColliderSet<N>`

the trait `nphysics3d::object::body_set::BodySet<N>` is not implemented for `nphysics::object::DefaultBodySet<N>`

Any ideas?

Turns out salva was pulling in a copy of nphysics from crates.io. The traits and objects in the errors were from different types. Looks like this was already a problem. #260 fixes that.
With #260, this PR now also works fine with --features=fluids.

Thanks 👍


Skip archived repos in org

This is one of my favorite tools. Thank you very much for opening the issues tab.
It would be nice when using
mp init "<org>" --all-repos

to have a flag for --skip-archived so we can skip initializing archived repos.

Thanks for the suggestion and glad you're enjoying using microplane! We'll keep this in mind as a future improvement, and are also open to PRs from the community.

Just hit this one myself, and was thinking about trying to fix it. Archived repos are always read-only right? Maybe we should have it skip archived repos, because you wouldn't be able to push a branch to create a PR.

Yes, archived repos in Github are read-only (docs), so it makes sense to skip them completely.


Slack badge on the README.md is broken.

The slack badge on the README.md is broken. The relevant upstream issue is rauchg/slackin#24. The slackin instance may need to be updated.

But not for me!

Ah, yeah, I imagine this came up—given it's such an old bug—because I had to use a fork of Slackin to fix some Heroku deploy issues. Unsure if those issues have been resolved, but I can look into that soon.

I'm not sure if you redeployed slackin, but it's fixed now. The alignment is still off, but I've fixed that in #20562.


Trainer.preprocess_dataset - KeyError with datasets<2.6.0

I ran the README snippet in a Kaggle notebook (Python 3.7) after running %pip install datasets span_marker transformers. I get a KeyError from trainer.train() / Trainer.preprocess_dataset (see below).
I was able to fix this by upgrading to datasets>=2.6.0. It seems that with the default Kaggle setup datasets==2.1.0 was installed when I ran %pip install datasets span_marker transformers.
I can't see an obvious reason for the change in datasets behaviour in the 2.6.0 release notes so maybe I'm on the wrong track. I thought you might like to know, in case there is a reason and you would like to add a constraint on datasets as a dependency.
Thanks for the package!
Traceback:
---------------------------------------------------------------------------
KeyError                                  Traceback (most recent call last)
/tmp/ipykernel_103/2689077115.py in <module>
     30 )
     31
---> 32 trainer.train()
     33 trainer.save_model("my_span_marker_model/checkpoint-final")
     34

/opt/conda/lib/python3.7/site-packages/transformers/trainer.py in train(self, resume_from_checkpoint, trial, ignore_keys_for_eval, **kwargs)
   1635             resume_from_checkpoint=resume_from_checkpoint,
   1636             trial=trial,
-> 1637             ignore_keys_for_eval=ignore_keys_for_eval,
   1638         )
   1639

/opt/conda/lib/python3.7/site-packages/transformers/trainer.py in _inner_training_loop(self, batch_size, args, resume_from_checkpoint, trial, ignore_keys_for_eval)
   1643         self._train_batch_size = batch_size
   1644         # Data loader and number of training steps
-> 1645         train_dataloader = self.get_train_dataloader()
   1646
   1647         # Setting up training control variables:

/opt/conda/lib/python3.7/site-packages/span_marker/trainer.py in get_train_dataloader(self)
    176     def get_train_dataloader(self) -> DataLoader:
    177         """Return the preprocessed training DataLoader."""
--> 178         self.train_dataset = self.preprocess_dataset(self.train_dataset, self.label_normalizer, self.tokenizer)
    179         return super().get_train_dataloader()
    180

/opt/conda/lib/python3.7/site-packages/span_marker/trainer.py in preprocess_dataset(self, dataset, label_normalizer, tokenizer, dataset_name, is_evaluate)
    170             batched=True,
    171             remove_columns=dataset.column_names,
--> 172             desc=f"Tokenizing the {dataset_name} dataset",
    173         )
    174         return dataset

/opt/conda/lib/python3.7/site-packages/datasets/arrow_dataset.py in map(self, function, with_indices, with_rank, input_columns, batched, batch_size, drop_last_batch, remove_columns, keep_in_memory, load_from_cache_file, cache_file_name, writer_batch_size, features, disable_nullable, fn_kwargs, num_proc, suffix_template, new_fingerprint, desc)
   1971                 new_fingerprint=new_fingerprint,
   1972                 disable_tqdm=disable_tqdm,
-> 1973                 desc=desc,
   1974             )
   1975         else:

/opt/conda/lib/python3.7/site-packages/datasets/arrow_dataset.py in wrapper(*args, **kwargs)
    518             self: "Dataset" = kwargs.pop("self")
    519         # apply actual function
--> 520         out: Union["Dataset", "DatasetDict"] = func(self, *args, **kwargs)
    521         datasets: List["Dataset"] = list(out.values()) if isinstance(out, dict) else [out]
    522         for dataset in datasets:

/opt/conda/lib/python3.7/site-packages/datasets/arrow_dataset.py in wrapper(*args, **kwargs)
    485         }
    486         # apply actual function
--> 487         out: Union["Dataset", "DatasetDict"] = func(self, *args, **kwargs)
    488         datasets: List["Dataset"] = list(out.values()) if isinstance(out, dict) else [out]
    489         # re-apply format to the output

/opt/conda/lib/python3.7/site-packages/datasets/fingerprint.py in wrapper(*args, **kwargs)
    456             # Call actual function
    457
--> 458             out = func(self, *args, **kwargs)
    459
    460             # Update fingerprint of in-place transforms + update in-place history of transforms

/opt/conda/lib/python3.7/site-packages/datasets/arrow_dataset.py in _map_single(self, function, with_indices, with_rank, input_columns, batched, batch_size, drop_last_batch, remove_columns, keep_in_memory, load_from_cache_file, cache_file_name, writer_batch_size, features, disable_nullable, fn_kwargs, new_fingerprint, rank, offset, disable_tqdm, desc, cache_only)
   2341                                 indices,
   2342                                 check_same_num_examples=len(input_dataset.list_indexes()) > 0,
-> 2343                                 offset=offset,
   2344                             )
   2345                         except NumExamplesMismatchError:

/opt/conda/lib/python3.7/site-packages/datasets/arrow_dataset.py in apply_function_on_filtered_inputs(inputs, indices, check_same_num_examples, offset)
   2218             if with_rank:
   2219                 additional_args += (rank,)
-> 2220             processed_inputs = function(*fn_args, *additional_args, **fn_kwargs)
   2221             if update_data is None:
   2222                 # Check if the function returns updated examples

/opt/conda/lib/python3.7/site-packages/datasets/arrow_dataset.py in decorated(item, *args, **kwargs)
   1913                 )
   1914                 # Use the LazyDict internally, while mapping the function
-> 1915                 result = f(decorated_item, *args, **kwargs)
   1916                 # Return a standard dict
   1917                 return result.data if isinstance(result, LazyDict) else result

/opt/conda/lib/python3.7/site-packages/span_marker/trainer.py in <lambda>(batch)
    167         # Tokenize and add start/end markers
    168         dataset = dataset.map(
--> 169             lambda batch: tokenizer(batch["tokens"], labels=batch["ner_tags"], return_num_words=is_evaluate),
    170             batched=True,
    171             remove_columns=dataset.column_names,

/opt/conda/lib/python3.7/site-packages/datasets/arrow_dataset.py in __getitem__(self, key)
    123 class Batch(LazyDict):
    124     def __getitem__(self, key):
--> 125         values = super().__getitem__(key)
    126         if self.features and key in self.features:
    127             values = [

/opt/conda/lib/python3.7/collections/__init__.py in __getitem__(self, key)
   1025         if hasattr(self.__class__, "__missing__"):
   1026             return self.__class__.__missing__(self, key)
-> 1027         raise KeyError(key)
   1028     def __setitem__(self, key, item): self.data[key] = item
   1029     def __delitem__(self, key): del self.data[key]

KeyError: 'tokens'

It looks like the issue is caused by differences in whether any columns not in the input_columns list in Dataset.map are removed in the output or not:
https://github.com/tomaarsen/SpanMarkerNER/blob/fcfa272670bae05b64eb429a746c8e6bc97f1494/span_marker/trainer.py#L161-L165
Relevant datasets PRs:
https://github.com/huggingface/datasets/pull/4971
https://github.com/huggingface/datasets/pull/5006
https://github.com/huggingface/datasets/pull/5008

@pdhall99 Thank you for this detailed report! Based on your last comment, it seems like I could update:
https://github.com/tomaarsen/SpanMarkerNER/blob/fcfa272670bae05b64eb429a746c8e6bc97f1494/span_marker/trainer.py#L163
to
    input_columns=("tokens", "ner_tags"),

with minor modifications to the label normalizers.
I'll work on that today! I'll try to get better defined minimum versions for core dependencies like datasets, much like how SpanMarker needs transformers>=4.19.0.

Tom Aarsen

Solved via 98e38802a85b8903a79598f6fb2b21f2df6f5464.
I'm afraid it'll be included in the upcoming v1.0.0, which has some breaking changes that make <1.0.0 models perform worse or break.