How to revoke the access and refresh token? #help_wanted

I've used this method for revoke the token. But the access token and refresh token again reusable. How to revoke the access and refresh token?
public async Task Revoke(string refreshToken,string accessToken){ var identityService = await DiscoveryClient.GetAsync("http://localhost:5000");

var revocationClient = new TokenRevocationClient(identityService.RevocationEndpoint, "ro.client", "secret"); var response = await revocationClient.RevokeRefreshTokenAsync(refreshToken); var response1 = await revocationClient.RevokeAccessTokenAsync(accessToken); }

Check the logs to see if there was a problem with revocation.

All set on this issue -- can we close?

Closing. If you still have issues, feel free to reopen.


[BUG] Serverside lua targetfinder error

Serverside error:
addons/wire/lua/entities/gmod_wire_target_finder.lua:218: bad argument #1 to 'pairs' (table expected, got number)
   0.  unkown - [C]:-1
    1.  pairs - [C]:-1
     2.  CheckTheBuddyList - addons/wire/lua/entities/gmod_wire_target_finder.lua:218
      3.  CheckPlayers - addons/wire/lua/entities/gmod_wire_target_finder.lua:252
       4.  unkown - addons/wire/lua/entities/gmod_wire_target_finder.lua:268

Your prop protection returned a number instead of a table with the call to CPPIGetFriends

It looks like the problem is this line https://github.com/CFC-Servers/Falcos-Prop-protection/blob/master/lua/fpp/sh_cppi.lua#L23
It's stupid api design, but I guess it's a bug that can be fixed.


Table.at does not see index columns

General Summary

Steps to Reproduce
Run the following:
from Standard.Base import all

from Standard.Table.Data.Column import Column
from Standard.Table.Data.Table import Table

main =
    t = Table.new [['x', [1,2,3]], ['y', [4,5,6]]] . set_index 'x'
    IO.println <| t.at 'x'

Expected Result
(Column org.enso.table.data.table.Column@2ff498b0)

(or similar)
Actual Result
(Error: (No_Such_Column_Error 'x'))

Enso Version
8c9c293f567e4dd4f848cfa686f118c692db4dd3

I was pretty sure that was by design, but of course that design can be changed.
I think this was inspired by Pandas where the behaviour is also like that:
df = pd.DataFrame({"a": [1,2,3], "b": [4,5,6]})
df["a"] # OK
dfi = df.set_index("a")
dfi["b"] # OK
dfi["a"] # KeyError: 'a'
dfi.index # OK


Impossible to compile: debian 8

at debian8  compilation is impossible
its a fresh install  "opensuse build service instance"
32bit log   https://mega.nz/#!INZx2Yqa!YRzIPlrrmxnHCZZam4zeyDjL6jIDC2od8c34hr0MsTo
64bit log https://mega.nz/#!9Qhmib4Q!RWF5ufPfqaFZiSCG7KK_BHCpnpyG5QIRJljbfZwHNC0

I noticed in your logs that you're using an old version of the libav* libraries. Have you seen the note for Debian Jessie users?.
If you want to use Chromium's bundled FFmpeg, then don't apply ffmpeg.patch from build_templates/debian/patches/system/.
Let me know how it goes. I haven't actually tested the patches yet, so if it works that will be helpful for me.

and i've got a very disturbing bug of  ungoogled "a clean opensuse build service xenial vm"
with this log Supervised users aren't enabled
and after the compilation has been aborted

"a clean opensuse build service xenial vm"

Are you saying that you're trying to build on a Ubuntu Xenial machine now? Are you not building on Debian 8 anymore?

Supervised users aren't enabled

What are "supervised users"?

and after the compilation has been aborted

What's the error? Is it related to the code? If so, do you have a log?

New version is out. Please see the new README for info. Let me know if you still have the problem.


checkBox status of nz-tree can not change along with the ‘checkedKeys‘ values？

this is my code

<nz-tree [nzTreeData]="nodes"
         [nzCheckable]="true"
         [nzMultiple]="true"
         [nzDefaultCheckedKeys]="checkedKeys"
         [nzDefaultSelectedKeys]="selectedKeys"
         [nzDefaultExpandAll]="expandDefault"
         (nzClick)="mouseAction('click',$event)">
</nz-tree>

export class AppComponent {}
......
this.http.get(`/api/auth/menu/searchMenuByRoleId`, {roleId: this.selectedRole['roleId']}).subscribe((resp: any[]) => {
            this.checkedKeys = resp;
        });

What is expected?
I am doing this in a modal, when I open a modal,i send a request to the server side then i got a reponse result which assgined to checkedKeys ,i hope the check status can change along with the response result,but it didn't.
What is actually happening?
The first time can change, after that,nothing change. the check status is always the first status.
Environment

ng-alain version: latest
Angular version:latest
Browser:
- [ ] Chrome (desktop) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] IE version XX

About any ng-zorro-antd question, pls going to here.


Getting null pointer exception when toEnvironmentBlock flow has null paramater

Getting null pointer exception when toEnvironmentBlock flow has null paramater in "invocationOnMock" variable in EnvironmentVariableMocker static block
Caused by: java.lang.NullPointerException: Cannot invoke "java.util.Map.entrySet()" because "m" is null
at uk.org.webcompere.systemstubs.environment.EnvironmentVariableMocker.toEnvironmentBlockWindows(EnvironmentVariableMocker.java:83)
at uk.org.webcompere.systemstubs.environment.EnvironmentVariableMocker.simulateToEnvironmentBlock(EnvironmentVariableMocker.java:69)
at uk.org.webcompere.systemstubs.environment.EnvironmentVariableMocker.lambda$static$0(EnvironmentVariableMocker.java:35)
at org.mockito.internal.handler.MockHandlerImpl.handle(MockHandlerImpl.java:111)
at org.mockito.internal.handler.NullResultGuardian.handle(NullResultGuardian.java:29)
at org.mockito.internal.handler.InvocationNotifierHandler.handle(InvocationNotifierHandler.java:34)
at org.mockito.internal.creation.bytebuddy.MockMethodInterceptor.doIntercept(MockMethodInterceptor.java:82)
at org.mockito.internal.creation.bytebuddy.MockMethodAdvice.handleStatic(MockMethodAdvice.java:148)

@pradeep-nagarajan  - can I see the test code you've written and how you're using the EnvironmentVariables stub.

@ashleyfrieze I am using Spring Boot 3 Junit 5 test cases (Jupiter), with @SystemStub annotation using 2.0.2 version, Java 17

Code snippet
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.TestMethodOrder;
import org.junit.jupiter.api.extension.ExtendWith;
import org.springframework.boot.test.context.SpringBootTest;
import uk.org.webcompere.systemstubs.environment.EnvironmentVariables;
import uk.org.webcompere.systemstubs.jupiter.SystemStub;
import uk.org.webcompere.systemstubs.jupiter.SystemStubsExtension;

@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)
@ExtendWith(SystemStubsExtension.class)
public class StubTest {

    @SystemStub
    protected static EnvironmentVariables environmentVariables;

    @Test
    public void test() {
        Assertions.assertNotNull(environmentVariables);
    }

}

@pradeep-nagarajan - that's interesting. And this test is failing? That's odd, because the function that's being called "toEnvironmentBlock" is usually called when something tries to start a process. Does your SpringBoot application invoke any processes?

@ashleyfrieze We are simulating an integration testing via Junit, like using embedded DB (H2).  So, we will bring up the spring boot server (embedded tomcat) to test our APIs. Just FYI, the same setup is working up to 1.2.0 version, where you don't have this change. This NPE is introduced from 2.0.0 version, refer the below file history.
https://github.com/webcompere/system-stubs/commits/main/system-stubs-core/src/main/java/uk/org/webcompere/systemstubs/environment/EnvironmentVariableMocker.java

@pradeep-nagarajan - yes, the EnvironmentMocker is needed for the v2 release train, which you'd need if you were on Java 16 or greater. If you're not on the later Java, then downgrade. I'll fix the NPE.
It would be useful to see what's invoking this though. Can you share more of the call stack?
And have you any other special settings that might be causing multiple processes to be invoked from your test thread?

@ashleyfrieze Please find the full trace, yes we are using embedded mongo DB which starts a process with Spring Boot
Caused by: java.lang.NullPointerException: Cannot invoke "java.util.Map.entrySet()" because "m" is null
at uk.org.webcompere.systemstubs.environment.EnvironmentVariableMocker.toEnvironmentBlockWindows(EnvironmentVariableMocker.java:83)
at uk.org.webcompere.systemstubs.environment.EnvironmentVariableMocker.simulateToEnvironmentBlock(EnvironmentVariableMocker.java:69)
at uk.org.webcompere.systemstubs.environment.EnvironmentVariableMocker.lambda$static$0(EnvironmentVariableMocker.java:35)
at org.mockito.internal.handler.MockHandlerImpl.handle(MockHandlerImpl.java:111)
at org.mockito.internal.handler.NullResultGuardian.handle(NullResultGuardian.java:29)
at org.mockito.internal.handler.InvocationNotifierHandler.handle(InvocationNotifierHandler.java:34)
at org.mockito.internal.creation.bytebuddy.MockMethodInterceptor.doIntercept(MockMethodInterceptor.java:82)
at org.mockito.internal.creation.bytebuddy.MockMethodAdvice.handleStatic(MockMethodAdvice.java:148)
at java.base/java.lang.ProcessEnvironment.toEnvironmentBlock(ProcessEnvironment.java:348)
at java.base/java.lang.ProcessImpl.start(ProcessImpl.java:105)
at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1110)
at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1073)
at de.flapdoodle.embed.process.runtime.ProcessControl.start(ProcessControl.java:177)
at de.flapdoodle.embed.process.types.RunningProcess.start(RunningProcess.java:76)
at de.flapdoodle.embed.mongo.transitions.MongoServerStarter.result(MongoServerStarter.java:119)
at de.flapdoodle.reverse.TransitionWalker.resolve(TransitionWalker.java:58)
at de.flapdoodle.reverse.TransitionWalker.resolve(TransitionWalker.java:46)
at de.flapdoodle.reverse.TransitionWalker.initState(TransitionWalker.java:176)

It's deployed from nexus, just waiting for propagation.

@pradeep-nagarajan - you're good to go. It's showing up on maven central now.


Heatit Z-Dim2 250W

Checklist

[X] It is not in the configuration DB

[X] It was not merged recently or has a pending PR

Which device is missing?
Heatit Z-Dim2 250w
Manufacturer ID
0x019b
Product Type
0x0002
Product ID
0x2201
Firmware Version
1.20
Is the device listed on the Z-Wave Alliance website?
https://products.z-wavealliance.org/products/4666
Do you have a manual?
1444440-Manual_Heatit_Z-Dim2  250W.pdf

Can help with the config file, but as i understand it we need to import it from the zwave db first?

@zwave-js-bot import config 4666 from zwa

solved with merge of #4801


All day event dates incorrect in calendar ListItems created in Graph API

Category

[ ] Question
[ ] Typo
[x] Bug
[ ] Additional article idea

Expected or Desired Behavior
When creating an all-day calendar ListItem, the start time should be 00:00 on the start date, and the end time should be 23:59 on the end date.
Observed Behavior
The resulting ListItem starts at 00:00 on the day before the expected start date. The end date and time are as expected.
Steps to Reproduce
POST https://graph.microsoft.com/v1.0/sites/root:/{sitename}:/lists/{listname}/items

// Single day, all-day event on 8/31/2018
{
    "fields": {
        "Title": "Test Event",
        "EventDate": "2018-08-31T00:00:00",
        "EndDate": "2018-08-31T23:59:00",
        "fAllDayEvent": true
    }
}

Result
"fields": {
    "EventDate": "2018-08-30T00:00:00Z",  // A day earlier than expected
    "EndDate": "2018-08-31T23:59:00Z",
    ...
}

Note that the results are the same if EventDate and EndDate are specified with no time information, e.g. "2018-08-31".
Workaround
Adding a day to the EventDate field causes the created item to be correct. This works even if creating a single-day event, where it's necessary to specify a start date that's later than the end date:
{
    "fields": {
        "Title": "Test Event",
        "EventDate": "2018-09-01T00:00:00",  // Add a day.
        "EndDate": "2018-08-31T23:59:00",
        "fAllDayEvent": true
    }
}

"fields": {
    "EventDate": "2018-08-31T00:00:00Z", // Correct!
    "EndDate": "2018-08-31T23:59:00Z",
    ...
}

Related StackOverflow question here

Hello @mikepowell , could you please tell me what's your language of this code?

The code in the issue text is portions of request and response bodies in JSON format. (I tagged the code blocks as JavaScript because I wanted to add comments, which aren't technically supported in JSON.)
As far as the issue itself I discovered it in C# code that uses the .NET Graph API, but have reproduced the issue using raw REST requests in Graph Explorer.

For now, one of the workarounds is changing the "fAllDayEvent" to "false".

Yes, that works but does not create an all-day event of course. My requirement is to have these events displayed in SharePoint and Outlook as all-day events rather than events with start and end times.

I can confirm that same behavior on our tenant, but it works correctly on our client's tenant. Our tenant was created like a year ago and is on the fast track. Client's tenant was created like 1.5 months ago.

Did you try specifying midnight as the end point?
For example, in C# ?
var start = when.ToUniversalTime().Date;
var end = start.AddDays(1);

The delta on (end - start) is one day, not one day plus a nanosecond for example. So I'd expect this to work for an all-day event.
When specifying 11:59 PM as the end point, the All Day calc may be subtracting 24 hours from the end point going back to the previous day. Just a thought.

The same problem appeared today then creating a new calendar event via MS Graph API. Now 2 days are beeing substracted from the EventDate submitted. Disableing the all day event resultet in a substraction of 1 day of the submitted date.
The request has been made with an app registration using the Microsoft Graph API Endpoint for SharePoint Online.
POST: https://graph.microsoft.com/v1.0/sites/{sitename}/lists/{listId}/items

Body
{
   "fields": {
      "ContentType": "Ereignis",
      "Title": "SharePoint Date Bug",
      "EventDate": "2020-01-03T00:00:00Z",
      "EndDate": "2020-01-12T23:59:00Z",
      "Description": "",
      "fAllDayEvent": true,
      "fRecurrence": false
    }
}

Response ( .. only the field data is shown here)
{
    "fields": {
<EMAIL_ADDRESS>"\"97070c93-8810-4c6c-b86c-61df55d12a0e,1\"",
        "id": "90",
        "ContentType": "Ereignis",
        "Title": "SharePoint Date Bug",
        "Modified": "2020-01-10T05:17:57Z",
        "Created": "2020-01-10T05:17:57Z",
        "AuthorLookupId": "1073741822",
        "EditorLookupId": "1073741822",
        "_UIVersionString": "1.0",
        "Attachments": false,
        "Edit": "",
        "LinkTitleNoMenu": "SharePoint Date Bug",
        "LinkTitle": "SharePoint Date Bug",
        "ItemChildCount": "0",
        "FolderChildCount": "0",
        "_ComplianceFlags": "",
        "_ComplianceTag": "",
        "_ComplianceTagWrittenTime": "",
        "_ComplianceTagUserId": "",
        "AppAuthorLookupId": "24",
        "AppEditorLookupId": "24",
        "EventDate": "2020-01-01T00:00:00Z",
        "EndDate": "2020-01-12T23:59:00Z",
        "fAllDayEvent": true,
        "fRecurrence": false
}

Note that the response event date does not match the request previously sent.
Request =  "EventDate": "2020-01-03T00:00:00Z"
Response = "EventDate": "2020-01-01T00:00:00Z"
Adding days before sending the request to SharePoint cannot be a viable long term solution.
A fix for this problem would be highly appreciated!

I am facing a 1-day shift. When and how does this vary? Do You have any news on this bug?

Passing body like below, should fix it.
{
"fields": {
"Title": "Test11",
"EventDate": "2021-10-28T23:59:00Z",
"EndDate": "2021-10-28T00:00:00Z",
"fAllDayEvent": true,
"fRecurrence": false
}
}

Thank you @majoshimsft
Is that a workaround or is that how it should work? It doesn’t seem logical that I have to make the EventDate (start date) greater than the EndDate. My fear is that when this “bug” is fixed, my calendar dates will be thrown off.
I tried the suggestion nonetheless and instead of creating the event for the date specified, it created it for a day earlier. So, in the example body below, the event was created for 10/29 instead of 10/30 as specified with the dates. Incidentally, MS Support made the same suggestion but I asked them to investigate the issue some more.
"{
"fields": {
"Title": "PTO - Test 4",
"EventDate": "2021-10-30T23:59:00Z",
"EndDate": "2021-10-30T00:00:00Z",
"fAllDayEvent": true,
"fRecurrence": false,
"Category": "Vacation Day"
}
}"

I opened a support case with Microsoft and they indicated that the API was not correctly handling some timezone conversions. Their engineering team has fixed the issue and the fix is expected to roll out completely by end of the month.

Microsoft has delivered a fix. I tested it and it works. I can now specify the exact start and end date for my all day event and they populate the calendar correctly.


add w520 ( copy of t520 )

Description of changes
as far as i can tell these laptops can be configured the same, so i've just cloned the t520 folder
Things done

[ x ] Tested the changes in your own NixOS Configuration
[ x ] Tested the changes end-to-end by using your fork of nixos-hardware and
importing it via <nixos-hardware> or Flake input

Are you still working on this?

sorry this slipped by, i added it to the readme

@mergify queue


Serialization of built Map and Set implementations

The convention in Java collections has been to implement serialization on all collections. Should do this on this codebase as well.
Probably want a judicious use of transient, writeObject, readObject to avoid serializing technically redundant information, and validating deserialized data, for instance the null comparators, and the empty set/empty map instances.

Validate uniqueness of keys in all maps and sets
Validate uniqueness of values in bimap instances.
In the ordered set and ordered map classes, validate existing ordering when deserialized.
In the hashed set and hashed map classes, regenerate the hashcodes when deserialized.

Could even use proxy objects and feed everything back through the builder on deserialization, though this gets complicated when we have collections inside collections.

First cut is checked in. Used readObject() for some validations, though haven't made hard guarantees about uniqueness, since this may slow things down.


Getting error while enter below line of code

Describe the bug
I am getting following error while calling below lines of code
infoViewConfig.presentationContext = .window(windowLevel: UIWindowLevelNormal)
and
attributes.windowLevel = .alerts
error message :
Value of type 'EKAttributes' has no member 'windowLevel'
Value of type 'SwiftMessages.Config' has no member 'presentationContext'; did you mean 'presentationStyle'?

What version of SwiftEnryKit, Xcode, and Swift are you using? Also, what is the Swift version of your target?
This below is not a SwiftEntryKit related issue but another library.

Value of type 'SwiftMessages.Config' has no member 'presentationContext'; did you mean 'presentationStyle'?

I used Swift 4.2, Even I checked with demo application same thing happed to me.

It might be the cached data for your project in the build directory / derived data folder caused this. So I would try the following (I couldn’t reproduce the issue so I’m shooting in multiple directions):

Clean Build + Build Directory.
Quit Xcode
Delete Derived Data.
pod deintegrate, pod cache clean --all and pod install (the last will pod repo update by default in case the cache is already cleaned up).
Open Xcode and run the project.xcworkspace

Also, please verify that your have Xcode 10 which not a beta.
Here is a working host project I've been experimenting with. Please try it and let me know if the attached project and suggested steps work for you.

@huri000 I met the same error, though execute the code you provided above, I have to use 0.6.0 version which compile success

@sivadoddi - Please refer to this thread for a solution.

I believe this issue is resolved (derived from resolving this one). The README installation section was updated with new info regarding the installation process.
Closing for now.


IPP initialization unification

IPPInitSingelton was added to contain IPP related global variables;
OPENCV_IPP env var now allows to select IPP architecture level for IPP9+;
main.cpp was added to some modules to provide single point for dynamic library initialization.
IPP initialization logic was unified across modules;

:+1:


[DAT-18790] added defaultValue snapshotting

Should work for most cases except:
Default value is calculated by a function with multiple arguments like eventDate DATE DEFAULT coalesce(CAST(CURRENT_TIMESTAMP() AS DATE), CAST('2024.09.09' AS DATE))


Fixed issue with Reveal modal being rendered below the backdrop on iOS

Fixes #7380, as well as #7280, #7281.
See example here http://codepen.io/Owlbertz/pen/eJOQVv.

Nice :)

I really wish all PRs would be merge this way :laughing:


Migrate to setup.cfg

Closes #114
Also has more steps in the CI use Make commands instead of using pip directly

I can approve this once the tests pass.


where does feed / signature validation take place when calling feed.append()?

I recently did a test changing feed.secretKey after a few calls to feed.append(), then called feed.append() again. I expected the call to fail. However, it went through without a problem. If I manually called feed.verify() after that, only then did I receive a "Signature verification failed" error:
> await feed.verify(feed.length-1, feed._storage.signatures.toBuffer().slice(-64))
Uncaught Error: Signature verification failed

There was no replication or persistence with this test feed, so maybe that's part of the problem, as I don't expect it would be that easy to potentially corrupt a propagated feed.
But it also seems that by default, performing this sort of action using a key that doesn't match prior transactions should throw an error.
Appreciate any additional insight on this issue.

I believe I found the answer, so closing this ticket. It seems anyone can append(), but if the invalid feed is propagated to another node, it would reject the tampered feed in _verifyAndWrite()  -> _verifyRootsAndWrite(), thus throwing the exception Remote signature could not be verified.

Glad you found an answer! For future reference, it might be good to post issues related to hypercore's internals to the hypercore repo


Update README.md

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you @harshp2124 but we don't have an issue related to this documentation change.


iOS not working

Hello,
This Plugin looks great but I am having an issue with iOS, it works well for Android but when I try to iOS I don't receive anything on call in the background, or my phone is locked. I added to info.plist this code
UIBackgroundModes

audio
fetch
processing
remote-notification
voip

I am using Agora for calls with Firebase as the backend. Not sure if you have any specific instructions for the iOS because I didn't find any.
Thanks

the sender should send VoIP push notifications to iOS, not common APNS

Thank you for your fast response. Do you have any instructions for how it can be done?

also pay attention, if the device had received the VoIP push notification but haven't displayed the CallKit (due to some cases such as crash or something else) about 5 times, the system will ignore the next VoIP notifications, and you need to delete and reinstall your app to make the VoIP notification worked again

any instructions for how it can be done?

it depends on the platform you use for sending the push notifications. for the Connectycube you just need to add the parameter 'ios_voip': 1 to the payload.

sorry, I'm not sure what exactly you mean by which platform. I am using Firebase (FCM Push notifications) and Agora for calls. Do you have any instructions on how can I configure it? Because seems a bit complicated.
Thanks

do you use Agora API for sending the FCM push notifications? if so, you can ask them (or search in the documentation) how to send iOS VoIP push notifications

No, we are not using the Agora API for the FCM Notifications. I will check what I can do and will reply if will find any resolution.
Thanks for your support

no activity for a long time. closing...


itemcharges: Add support for blood essence

I believe I've handled the relevant game messages. You can only have one active at a time so don't need any fancy per-item tracking. I did confirm that as of now if you only use one charge it uses "1" instead of "one". This does not handle the use-case of alching the essence before it runs out of charges which would reset it  however I have a feeling Jagex is going to patch that behavior anyways so probably not worth the effort of handling.

Do you have a log of the chat messages from the essence breaking?

Do you have a log of the chat messages from the essence breaking?

I can confirm they are correct.

It may be good to add a test for this


Brightcove: language plugin

The title is not switching inline with the HTML "lang" attribute on Brightcove video embeds.
BC looking into the issue.

Closing issue—plugin behaving as expected.


Remove libraries from 2018 mock Practical Assessment

Remove libraries from 2018 mock Practical Assessment
Summary: Removes unused libraries leftover from the 2018 mock Practical Assessment. External libraries required for any future PEs (mock or otherwise) should be injected and removed in a similar fashion.
Changelog

Remove pe_lib.js and assert_compiled.js added in PR #409, and all references to these two libraries

Should increase loading speed of frontend due to large size of obfuscated assert_compiled.js

Last updated 20 Aug 2019, 11:45PM

Pull Request Test Coverage Report for Build 3177

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 36.976%

Totals

Change from base Build 3176:
0.0%

Covered Lines:
2640

Relevant Lines:
6406

💛  - Coveralls


Value of fields not define type

Model.fields().attribute.value can get a default value of fields.
But, it doesn't exits that property in the document and the type definition.
Can I use that property? If so, I will send a pull request for defining type that property.
Thanks.

Ah sure! That would be great!


feat(charts): Add optional syslog endpoint setting

it also needs global values.yaml setting

hmm pushed line 36 update and do not see it here, strange

closing in favour of PR #75


Cache labels and series results

Signed-off-by: Ben Ye<EMAIL_ADDRESS>

[x] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Changes
Fixes https://github.com/thanos-io/thanos/issues/3230

Bump Cortex to commit https://github.com/cortexproject/cortex/commit/21bad57b346c730d684d6d0205efef133422ab28
Support labels/series specific cache configuration
Labels & Series API responses can be cached now. Tested on different query API implementation: Thanos querier, Prometheus and Conprof :)

Verification

Conflict fixed. This needs another round of review :)


use method name as its command name if no name defined in Meta of input struct for package gcmd

Codecov Report

Merging #2019 (9255906) into master (5d51e9f) will decrease coverage by 0.04%.
The diff coverage is 77.65%.

:exclamation: Current head 9255906 differs from pull request most recent head 72930df. Consider uploading reports for the commit 72930df to get more accurate results

@@            Coverage Diff             @@
##           master    #2019      +/-   ##
==========================================
- Coverage   76.49%   76.44%   -0.05%
==========================================
  Files         515      514       -1
  Lines       46666    46423     -243
==========================================
- Hits        35698    35489     -209
+ Misses       8998     8977      -21
+ Partials     1970     1957      -13

Flag
Coverage Δ

go-1.15-386
76.41% <77.65%> (-0.02%)
:arrow_down:

go-1.15-amd64
?

go-1.16-386
?

go-1.16-amd64
76.40% <77.65%> (-0.03%)
:arrow_down:

go-1.17-386
?

go-1.17-amd64
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

contrib/drivers/sqlite/sqlite.go
77.77% <ø> (ø)

errors/gerror/gerror_api_option.go
70.00% <ø> (ø)

os/gcmd/gcmd_command_object.go
52.41% <34.28%> (+1.00%)
:arrow_up:

errors/gerror/gerror_api_stack.go
75.38% <75.38%> (ø)

errors/gerror/gerror_error.go
70.73% <80.00%> (ø)

errors/gerror/gerror_api_code.go
82.55% <82.55%> (ø)

errors/gerror/gerror_api.go
90.62% <90.62%> (ø)

contrib/drivers/clickhouse/clickhouse.go
70.23% <100.00%> (ø)

contrib/drivers/pgsql/pgsql.go
66.05% <100.00%> (ø)

errors/gerror/gerror_error_code.go
53.84% <100.00%> (ø)

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d51e9f...72930df. Read the comment docs.


Display views in my applications

how can i see all default views ? because when i put localhost:8000/roles/create there are 404 error

Probably the way you setup the project, your environment not setup correctly, your env variables are not configured correctly, or your routes are mis configured in your application.


Allow manual merging

This my WIP version of #681. It would probably be better to keep the discussion in that PR, but to do that I would need permissions to push to @ticky's fork.

This should be ready now, I think?
I rebased the old PR and investigated and fixed the cucumber failures (with the help of https://github.com/cucumber/aruba/pull/675). I also address some not yet addressed comments about the documentation from the previous PR.

Well, I'm now trying this in my app and it's not quite working as I expect. I need to have a closer look, so this is back to WIP.

Thanks so much @deivid-rodriguez (and @ticky !) for this :green_heart: :tada: :rocket:
As it's WIP atm I haven't taken a look yet, will take one at another time but just wanted to express my gratitude :hugs:

Thanks for your encouraging and positive attitude :) I'll try to get this over the line!

Thanks for pushing ahead with this @deivid-rodriguez! Your changes are looking good to me - I’ll try them out in place of my branch and see if things still work as expected.

Ok, I think I fixed the issue. Previously results were being incorrectly merged using Hash#merge, and the ResultMerger.merge_results was being passed a single incorrectly merged result. Essentially the previous version was merging resultsets correctly at the file level, but not at the line level. See https://github.com/colszowka/simplecov/pull/780/commits/4fedabdf070a7b02dd0872b3df3717ad4a4057ec.
This now works as I expect against my library, I'll look into getting the last fix covered.

@ticky Make sure you use the latest commit too. I think your different runners are correctly merging the set of files that the cover all together, but you might not be properly getting the set of lines covered for each file properly merged. So, I would expect the last commit to increase the total coverage in your application.

All working for us here on 4fedabdf070a7b02dd0872b3df3717ad4a4057ec.
Looks like a minor change in coverage data reporting, but it seems about as expected.
Nice work @deivid-rodriguez :)

@ticky thanks for testing this out! :green_heart:
Really good work @deivid-rodriguez ! I have a (minor) knee surgery tomorrow, not sure if I get to look at this properly before ~Friday/Saturday so please excuse my tardyness but I really want to get this in :)

@PragTob Hope your surgery goes well!
Regarding this PR, I still want to give it another look and try a few extra things, so no rush. Will let you know when I consider it ready for review!

Found one more issue where only the first command_name => coverage_data pair on each result set was getting merged. Fixed by https://github.com/colszowka/simplecov/pull/780/commits/4d3492d99b0ed67af94c4762ff0e592bf823a142.

The failing test is the JRuby flaky one I gotta take care off... chose to not rerun it as I figured you still wanted to update it here

Thanks for the review @PragTob!
I still want to fix some issues with the current implementation. For example, a correct merged report is now generated twice, one inline, and one in the at_exit hook, which is confusing at least. Then I wanted to have a look at test coverage and see how I can improve it. Now I'll also add "Address @PragTob's feedback" to the list :)

Sounds like a plan! :ok_hand:

So I created some unit tests for this, but I run into several issues while creating them that I think might be related to #820. So I think I might've fixed that issue?
What I did was essentially making sure that when reading reports from disk into a hash, or manipulating them, all keys are always symbols. Do we have an regression scenario for #802? If so, I can extract the relevant changes from this PR into a separate PR, and add that regression test in there.

@deivid-rodriguez is the last ticket reference to #802 a mistake and you wanted to do #820 ? If so then we almost have one, I started writing one (generated an old resultset.json, created a project for it etc) but then got sick and took a break :grin: If I don't feel worse tomorrow I'll likely finish it up tomorrow and will check against your branch. Although, imo it's likely that this isn't #820 as I think #820 has to do with the different file structure (extra level) not the keys being symbols.
On a slightly related note I was pondering removing the "symbolization" of keys as it seems to be a waste of memory & run time while we could us them without them being symbolized but I wanted to double check and see how far the symbolization goes.

Yes, I corrected the mistake now. I'm not sure it wasn't #820, but since I ended up removing the symbolize_names_of_coverage_results which is what's crashing there, I figure this issue might be gone.
Regarding removing the symbolization, I think that's a good move, yeah. I was about to do that to fix the issue I was having (some "file name" keys were symbols, and others string, so they wouln't merge fine). But I ended up symbolizing everywhere instead, since it looked simpler to achieve.

Oh, I also made this change: https://github.com/colszowka/simplecov/pull/780/commits/93c771d3758f8ba31382de84b96277bc873ee1bc, because branches: nil was sneaking into merged reports, even if none of the merged reports had any branch information in them. Hopefully it's correct?


Request for new term 'metabolic dysfunction-associated steatotic liver disease'

Label
metabolic dysfunction-associated steatotic liver disease
Synonyms
MASLD
Synonym type
related
Definition
Metabolic dysfunction-associated steatotic liver disease (MASLD, formerly known as nonalcoholic fatty liver disease or NAFLD) is a type of liver disease that is not caused by alcohol. It typically does not cause symptoms in the early stages, but it can cause health problems due to fat accumulation, inflammation, and scarring in the liver.
Parent term
MONDO:0004790 fatty liver disease
Children term(s)
No response
ORCID Identifier
No response
Website URL
https://www.verywellhealth.com/how-dangerous-is-non-alcoholic-fatty-liver-disease-2223390
Additional comments
No response

Hi @tzukuo-evotec, thanks for the ticket. We are focused on a mass obsoletion effort this month, and will look at this more closely in November or later. We appreciate your patience.

Thank you for the message and efforts.

Thank you for the update, @nicolevasilevsky . It looks fine for me. Could you please also ensure that people unaware of the new name can find the disease (e.g., including the old name in the synonyms)? Furthermore, may I know when the change will be accessible to the public?


Add k8s/pkg/apis module for third party software

Description

Motivation and Context
https://github.com/networkservicemesh/networkservicemesh/issues/1962
How Has This Been Tested?

[ ] Covered by existing integration testing
[ ] Added integration testing to cover
[ ] Tested locally
[ ] Have not tested

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

@nickolaev

shall we already call this v0.3.0?

Probably yes, but I think, we need to do it in separate PR.


handling 2 liaisons

What happens if there are two liaisons for a subject? (Marketing: Abigail Morgan, Senta Sellers)

Demo user: "fakeUsers/marketing.json"
{
    "user": "markstu",
    "attributes": {
        "displayName": [
            "Markeing Stu"
        ],
        "muohioeduCurrentCourseSubjectNumber": [
            "MKT101"
        ],
        "muohioeduPrimaryAffiliation": [
            "student"
        ],
        "uid": [
            "markstu"
        ],
        "eduPersonPrimaryAffiliation": [
            "student"
        ],
        "muohioeduPrimaryLocationCode": [
            "oxf"
        ],
        "eduPersonPrincipalName": [
<EMAIL_ADDRESS>        ],
        "muohioeduMajorCode": [],
        "givenName": [
            "Mark"
        ],
        "muohioeduMajor": [],
        "muohioeduPrimaryLocation": [
            "Oxford"
        ],
        "muohioeduPrimaryAffiliationCode": [
            "und"
        ]
    }
}

@Meng-MiamiOH -- I'm wondering if you can take a look at this. I'm working on the problem of displaying two librarians where relevant, and getting Bootstrap to toggle open/closed the "extra" information from LibGuide Widgets.
The code that I'm generating works outside the Dashboard, like in this codePen test:
https://codepen.io/kenirwin/pen/XWMjpyJ
(click the "more" buttons to hide or show more content)
But the same code in the Dashboard isn't working. To set up:

check out the branch "two-librararians"
in the fakeUsers folder, add a "marketing.json" file with the content from the previous comment
in config/fakeUsers.json add and select the fake user, e.g.:

{
    "useFakeUser": true,
    "fakeUserId": "6",
    "fakeUsers": [
        "ken.json",
        "mjf-fac.json",
        "3822.json",
        "employee-in-class.json",
        "fac.json",
        "engine-undergrad.json",
        "marketing.json"
    ]
}

then ./restart

@kenirwin In your codepen demo, I saw that you were using Bootstrap 4.6 which is an older version. I have upgraded Bootstrap to version 5 in order to use the component "offcanvas".
You may modify the collapse feature according to the latest guide at https://getbootstrap.com/docs/5.0/components/collapse/

Thanks, Meng! That worked.
http://miamioh.edu/
Ken Irwin
Web Services Librarian
Miami University
King Library 302
151 S. Campus Avenue
Oxford, OH 45056
O:<PHONE_NUMBER> |<EMAIL_ADDRESS>*Pronouns: he/him/his *
On Mon, May 17, 2021 at 11:35 PM Meng-MiamiOH @.***>
wrote:

@kenirwin https://github.com/kenirwin In your codepen demo, I saw that
you were using Bootstrap 4.6 which is an older version. I have upgraded
Bootstrap to version 5 in order to use the component "offcanvas".
You may modify the collapse feature according to the latest guide at
https://getbootstrap.com/docs/5.0/components/collapse/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Miamiohlibs/Dashboard/issues/4#issuecomment-842799923,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOORIJ2DFTKYYU3ZBLCY2LTOHOA3ANCNFSM43IDK7NA
.

Merged in 63dd044


[Formatter] Improve the line wrapping feature

Description:
The line wrapping feature could be improved with respect to the following aspects.

places where the line wrapping occurs
preserving existing valid line wrapping instances

Steps to reproduce:
Affected Versions:
Swan Lake Preview 5
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

Some of the places that could be improved are (uses the default line length of 120 characters):

Ensure the line break happens at an appropriate place. For instance, in the following example, the line break happens after the equal sign, whereas it should happen before the entire parameter.

Sample:
function foo(int count, int count, int count, int count, int count, int count, int count, int count, int count = 999999999) {
}

Output:
function foo(int count, int count, int count, int count, int count, int count, int count, int count, int count =
             999999999) {
}

Expected:
function foo(int count, int count, int count, int count, int count, int count, int count, int count,
             int count = 999999999) {
}

Even if the character length exceeds 120, still the line wrapping doesn't happen until the next node is reached.

Sample:
function foo(int count, int count, int count, int count, int count, int count, int count, int count, int countttttttttttt = 999999999) {
}

Output:
function foo(int count, int count, int count, int count, int count, int count, int count, int count, int countttttttttttt =
             999999999) {
}

Expected:
function foo(int count, int count, int count, int count, int count, int count, int count, int count,
             int countttttttttttt = 999999999) {
}

Two other scenarios that need to be addressed:
Sample 1:
public type Client client object {
    remote function query(@untainted string|ParameterizedQuery sqlQuery, typedesc<record { }>? rowType = ())
    returns @tainted stream<record { };, Error>;
}

Output:
public type Client client object {
    remote function query(@untainted string|ParameterizedQuery sqlQuery, typedesc<record { }>? rowType = ()) returns @tainted stream<record { };,
    Error>;
}

Expected:
public type Client client object {
    remote function query(@untainted string|ParameterizedQuery sqlQuery, typedesc<record { }>? rowType = ())
    returns @tainted stream<record { };, Error>;
}

Sample 2:
function foo() {
        ReportTable|error reportTable = table key(id) from var student in studentList
                                        where student.gpa >= 2.0
                                        let string degreeName = "Bachelor of Medicine", int graduationYear = calGraduationYear(student.intakeYear), int test = calGraduationYear(student.intakeYear)
                                        select {id: student.id};
}

Output:
function foo() {
    ReportTable|error reportTable = table key(id) from var student in studentList
                                    where student.gpa >= 2.0
                                    let string degreeName = "Bachelor of Medicine", int graduationYear =
                                    calGraduationYear(student.intakeYear), int test = calGraduationYear(student.
                                    intakeYear)
                                    select {id: student.id};
}

Expected:
function foo() {
    ReportTable|error reportTable = table key(id) from var student in studentList
                                    where student.gpa >= 2.0
                                    let string degreeName = "Bachelor of Medicine",
                                    int graduationYear = calGraduationYear(student.intakeYear),
                                    int test = calGraduationYear(student.intakeYear)
                                    select {id: student.id};
}

Related Issue: https://github.com/ballerina-platform/ballerina-lang/issues/29757

The following scenario when there is a RecordTypeDescriptorNode also needs to be addressed.
Actual output:
public isolated function next() returns record {|
                                                HelloResponse value;
                                            |}|grpc:Error? {
    var streamValue = self.anydataStream.next();
    record {|
            HelloResponse value;
    |} nextRecord = {value: <HelloResponse>streamValue.value};
    return nextRecord;
}

Expected output:
public isolated function next() returns record {| HelloResponse value; |}|grpc:Error? {
    var streamValue = self.anydataStream.next();
    record {| HelloResponse value; |} nextRecord = {value: <HelloResponse>streamValue.value};
    return nextRecord;
}

Please note that this is a blocker for https://github.com/ballerina-platform/ballerina-standard-library/issues/1103
@daneshk

@MadhukaHarith92 @daneshk The formatting limitation with inline and expanded blocks given in [1] is now fixed in the latest master branch. The fix is provided with [2].
[1] https://github.com/ballerina-platform/ballerina-lang/issues/26585#issuecomment-822532264
[2] https://github.com/ballerina-platform/ballerina-lang/pull/30251

Closing this issue, since the formatter no longer supports the line wrapping feature, instead, it now allows the user to break new lines at appropriate places as required. i.e. the formatter preserves the user-defined new lines (up to a maximum of one blank line). The indentation of a user-defined new line will be aligned to the nearest tab space.
Related Issue: https://github.com/ballerina-platform/ballerina-lang/issues/30050


ValueError: Dimensions must be equal

Hi mate,
I am trying to run your program on my Characters dataset. But this shows the following error:
Dimensions must be equal, but are 68 and 128 for 'mul_1' (op: 'Mul') with input shapes: [128,68,68], [128,68].
In my case, there are 68 classes. therefore, I have changed depth value from 10 to 68. But still, it shows the error. Can you please help me?

Hi,
if you are still trying to resolve this problem please provide more context. What is the model definition you are using and in which file and line does the error occur. Otherwise, I recommend using the https://github.com/XifengGuo/CapsNet-Keras as I am currently working on other projects and not maintaining this one.
Best regards and sorry for the late answer,
Chris

Hi,
@guddulrk  I have same error. Could you solve the problem.  I'm trying to make a binary classifier and change code like this: digitcaps = caps.dense(primarycaps, 2, 16, ... . I put error lines images below


[typeahead] reopen result dropdown on onFocus (feature request/enhancement)

We have the following use case:

user starts typing, dropdown opens and shows results
user clicks out of the input field (nothing is deleted from the input field), dropdown closes
user clicks back into the typeahead input field (and does NOT start to type anything) and nothing happens. → the desired behavior is: dropdown opens again and shows the same result list as last time (of course, that only happens, if there is anything in the input field)

So, maybe a typeahead-search-on-focus setting?
Behavior is similar to the search field in Firefox.

i have same issue

I agree — this is what makes the most sense. The dropdown was visible when the user was typing before losing focus. So when regaining focus, the user would expect to see it become visible again.
If it's undesirable because of the possible use case of the user tabbing through form fields, and the dropdowns making "too much happen", then at least we could do this: make the dropdown able to be triggered with a "Down" keypress.

+1

+1

+1


feat: check SBML validity

Main improvements in this PR:
Following up on the discussion in #125, saveYeastModel.m now errors if the saved model is not an SBML valid structure.
I hereby confirm that I have:

[X] Tested my code with all requirements for running the model
[X] Selected devel as a target branch (top left drop-down menu)
[X] If needed, asked first in the Gitter chat room about this PR

@edkerk TranslateSBML already prints those errors when called. For instance, if 2 gene labels are removed, the following is printed by saveYeastModel:
The model contains 2 errors.

************************************************************
Line ErrorId Severity Message

122963: (2021203)  Error A <GeneProduct> object must have the required attributes 'fbc:id' and 'fbc:label' may have the optional attributes 'fbc:name' and 'fbc:associatedSpecies'. No other attributes from the SBML Level 3 Flux Balance Constraints namespace are permitted on a <GeneProduct> object.
Reference: L3V1 Fbc V2 Section 3.5
 Fbc attribute 'label' is missing from 'geneProduct' object.

122964: (2021203)  Error A <GeneProduct> object must have the required attributes 'fbc:id' and 'fbc:label' may have the optional attributes 'fbc:name' and 'fbc:associatedSpecies'. No other attributes from the SBML Level 3 Flux Balance Constraints namespace are permitted on a <GeneProduct> object.
Reference: L3V1 Fbc V2 Section 3.5
 Fbc attribute 'label' is missing from 'geneProduct' object.

Error encountered during read.

Error using saveYeastModel (line 28)
Model should be a valid SBML structure. Please fix all errors before saving.


[KOGITO-650] Support for Enum marshalling

Fix: https://issues.redhat.com/browse/KOGITO-650
Adds support for Enum marshalling both using Jandex and Reflection.
Reflection proto generation
As this type of generation has acces to the class and fields declaration, the order can be respected.
Jandex proto generation
However for Jandex proto generation, where the file is read and is not part of the classpath it is not possible to get the fields as they are declared. Fields are sorted lexicographically and in order to have a  reliable marshaller generation, fields have to be declared in order.
public MyEnum {
 YES,
 MAYBE,
 NO
}

This code will result in the following proto file:
syntax = "proto2";
package org.kie.kogito.test;

enum Answer {
	option java_package = "org.kie.kogito.codegen.data";
	YES = 2;
	NO = 1;
	MAYBE = 0;
}

Annotations provide a way to define metadata that is accessible during this step so if the user defines @ProtoEnumValue in each enum value it will be picked up by the generator and used to define the numeric values of each field.
import org.infinispan.protostream.annotations.ProtoEnumValue;

public enum AnswerWitAnnotations {
    @ProtoEnumValue(number = 0)
    YES,
    @ProtoEnumValue(number = 1)
    MAYBE,
    @ProtoEnumValue(number = 2)
    NO
}

Having the following as a result
syntax = "proto2";
package org.kie.kogito.test;

enum AnswerWitAnnotations {
	option java_package = "org.kie.kogito.codegen.data";
	NO = 2;
	MAYBE = 1;
	YES = 0;
}

Marshallers
EnumMarshallers will be generated for each Enum like the one in the example:
import org.infinispan.protostream.EnumMarshaller;

public class AnswerWitAnnotationsEnumMarshaller implements EnumMarshaller<org.kie.kogito.codegen.data.AnswerWitAnnotations> {

    public String getTypeName() {
        return "org.kie.kogito.test.AnswerWitAnnotations";
    }

    public java.lang.Class<org.kie.kogito.codegen.data.AnswerWitAnnotations> getJavaClass() {
        return org.kie.kogito.codegen.data.AnswerWitAnnotations.class;
    }

    public int encode(org.kie.kogito.codegen.data.AnswerWitAnnotations state) {
        if (null == state)
            throw new java.lang.IllegalArgumentException("Invalid value provided to enum");
        return state.ordinal();
    }

    public org.kie.kogito.codegen.data.AnswerWitAnnotations decode(int value) {
        switch(value) {
            case 2:
                return org.kie.kogito.codegen.data.AnswerWitAnnotations.NO;
            case 1:
                return org.kie.kogito.codegen.data.AnswerWitAnnotations.MAYBE;
            case 0:
                return org.kie.kogito.codegen.data.AnswerWitAnnotations.YES;
            default:
                throw new java.lang.IllegalArgumentException("Invalid value provided to enum");
        }
    }
}

Signed-off-by: ruromero<EMAIL_ADDRESS>Many thanks for submitting your Pull Request :heart:!
Please make sure that your PR meets the following requirements:

[x] You have read the contributors guide
[x] Pull Request title is properly formatted: KOGITO-XYZ Subject
[ ] Pull Request title contains the target branch if not targeting master: [0.9.x] KOGITO-XYZ Subject
[x] Pull Request contains link to the JIRA issue
[ ] Pull Request contains link to any dependent or related Pull Request
[x] Pull Request contains description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket

It is a WIP until it persistence profile is added to the integration tests

@ruromero just a note to update docs in here once this is merged.

Should use https://github.com/kiegroup/kogito-runtimes/pull/625

It seems there is the infinispan dependency missing for sprinboot integration tests... org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type 'org.infinispan.client.hotrod.RemoteCacheManager'

@MarianMacik Can you take a look since I changed the integration tests?

@Sgitario would you mind taking a look at this PR, there are some new integration tests regarding persistence for the runtimes.
Thanks.


[BUG] OutlineFilter: If content's alpha<1 , the line will be also alpha<1

like the image:

The part of the fish is semitransparent , the border is also semitransparent.
I think the border's alpha should always be  1.0 .

I have glowFilter that can work like that


Force npm legacy peer dependency handling in create-hops-app

npm@7 introduced new behaviour for peer dependencies and installs them
automatically.
Unfortunately this breaks our integration tests because
react-helmet-async does not yet support react@17.
With this commit we add a CLI flag for the npm install command to force
npm to switch back to the previous behaviour to not automatically
install peer dependencies.
We can remove this again once react-helmet-async support react@17.

Bors merge bot cheat sheet
We are using bors-ng to automate merging of our pull requests. The following table provides a summary of commands that are available to reviewers (members of this repository with push access) and delegates (in case of bors delegate+ or bors delegate=[list]).

Syntax
Description

bors merge
Run the test suite and push to master if it passes. Short for "reviewed: looks good."

bors merge-
Cancel an r+, r=, merge, or merge=

bors try
Run the test suite without pushing to master.

bors try-
Cancel a try

bors delegate+
Allow the pull request author to merge their changes.

bors delegate=[list]
Allow the listed users to r+ this pull request's changes.

bors retry
Run the previous command a second time.

This is a short collection of opinionated commands. For a full list of the commands read the bors reference.

bors merge

bors merge

bors merge-

bors merge

bors merge


Are duplicate reads and issue for Stringtie?

Hello,
I am not sure if this is the right place for my question, but I was wondering if duplicate reads/PCR duplicates are an issue for stringtie and whether you would recommend to remove duplicate reads before performing the assembly?
Thanks,
Jonas

That was fast. Thanks a lot!


[Question] Importance of Reload System Daemons?

could someone explain the importance of reloading system Daemons within unc0ver? how badly does this impact the system? does it break anything within the jailbroken state if system Daemons are not reloaded?
because I have noticed that respringing tends to be super quick & doesnt fail to respring if this option is disabled..
also reloading system Daemons tends to kill the Universal Clipboard function on the iDevice (handoff feature) - probably a bug in the reload function not reloading the service that controls Universal Clipboard from working.

the same problem


0.12.0 CameraListener is not available

Trying to work in the 0.12.0 updates, but when I switch from 0.11.0 it is not possible to locate or import the CameraListener Class.
I have tried running this with both 26/27 target SDKs and appCompatv 26.+ as well as 27.0.0
If I switch back to 0.11.0 it works fine, but I can't seem to see why the Listener would be missing or not located. Is there a new approach for .setCameraListener in 0.12.0 that I am missing?
Also, it looks like 0.11.0 is having an issue with running something on the mainThread. I receive a "view cannot be access from outside the hierarchy" error when loading it the first time after logging into the app. Was hoping my upgrade to 0.12.0 would solve this.
Also - very interesting that the demo app in Github doesn't have example code for the CameraListener. Did I also miss this?
Lastly, I am anticipating and waiting for the pinchToZoom functionality. Is there an update or when this will be released?
Thank you,
Philip

Just to answer the demo app question:  the demo doesn't look like it takes pictures, but the documentation has a pretty good example how to to use the CameraListener.

I understand how the CameraListener functions. I have been using it in my code for some time. The issue is not understanding, but version compatibility. When I upgrade my sdkBuildTools to 26.0.2 (previous 25.0.3) The cameraListener, and .setCameraListener method were both inaccessible.
Due to a deadline crunch, I had to revert back a couple version just so I could deploy. Would really like to progress the changes though. Will wait for Zoom to be available before trying again.
Thanks.

Same problem. I just went back to using implementation 'com.flurgle:camerakit:0.9.17' and that worked. You can keep all the rest of the code the same just change package where appropriate in xml, java, etc.

I've found the same thing. The docs say to use CameraListener, but there is no CameraListener. It was removed in this commit: https://github.com/wonderkiln/CameraKit-Android/commit/093778182e8a7d632b9902b9d0dc6679897ef1d5
Do the docs just need to be changed?

Glad I wasn't crazy here. I am currently running compile 'com.wonderkiln:camerakit:0.10.1' with target SDK 25. When I was running SDK 26, it showed a missing v26.xml property.
Something wonky here in terms of versioning support.

@p-canniff @jproffitt @romeroz @calebdre
We will make some refinements to the documentation as part of our 0.13.0 release (November Release). We will also address many varying issues in this release, including this. Can you outline your ideal outcome, given CameraListener and intended use? If that makes sense.

So I would like my code to run with the CameraListener as it always has. If you made a larger change here I can adapt.
My biggest issue is I can't work in AS 3.0.0 because it has a min. SDK of 26.

@austinkettner It seems you removed CameraListener for a reason. I'm ok with that as long as the documentation reflects how to really use the camera now. It still talks about using CameraListener.
So I just need to know what the correct way to do it now is. I've seen some mentions of using something like @OnCameraKitEvent(CameraKitEvent.class), and I've also seen using a new class called CameraKitEventListener like here: https://github.com/wonderkiln/CameraKit-Android/issues/250. So what is the proper way of doing it now? The documentation should be updated accordingly.

I copied the code from this issue to get it working
https://github.com/wonderkiln/CameraKit-Android/issues/250
private CameraKitEventListener cameraListener = new CameraKitEventListener() {
    @Override
    public void onEvent(CameraKitEvent cameraKitEvent) {
        switch (cameraKitEvent.getType()) {
            case CameraKitEvent.TYPE_CAMERA_OPEN:
                canTakePicture = true;
                break;

            case CameraKitEvent.TYPE_CAMERA_CLOSE:
                canTakePicture = false;
                break;
        }
    }

    @Override
    public void onError(CameraKitError cameraKitError) {

    }

    @Override
    public void onImage(CameraKitImage cameraKitImage) {
        cameraKitImage.getJpeg(); // will return byte[]
    }

    @Override
    public void onVideo(CameraKitVideo cameraKitVideo) {

    }
};

I also used this code which I found from the demo:
// in onCreate
mCameraView.bindCameraKitListener(this);

@OnCameraKitEvent(CameraKitEvent.class)
public void cameraEvent(CameraKitEvent event) {
    if(event.getType().equals(CameraKitEvent.TYPE_CAMERA_OPEN)) {
        // do open event logic here
    }
}

@OnCameraKitEvent(CameraKitImage.class)
public void imageCaptured(CameraKitImage image) {
    // do on image event logic here
}

@OnCameraKitEvent(CameraKitVideo.class)
public void videoCaptured(CameraKitVideo cameraKitVideo) {
    // do on video event logic here
}

@OnCameraKitEvent(CameraKitError.class)
public void onError(CameraKitError cameraKitError) {
    // do on error event logic here
}

So which version of camerakit is currently functional for SDK 25?

A WIP in #318 can you please test that out and provide comments as to what you would like to see from a Listener class?


Jaú Gazette

Spider for gazettes of Jaú - SP

Hey! I've ran your spider and everything worked fine, despite a specific exception that I got for a specific pdf
2020-07-15 23:08:52 [scrapy.core.scraper] ERROR: Error processing {'date': datetime.date(2019, 5, 17),
 'file_urls': ['http://www.jau.sp.gov.br/uploads/imprensa_oficial/2019/05/30/165902/Jornal_Oficial_896.pdf'],
 'files': [{'checksum': 'b7a04c1acf00473424184155bf414332',
            'path': 'full/40152042da5f6a5cde56968d1bcb07951a1815d1.pdf',
            'url': 'http://www.jau.sp.gov.br/uploads/imprensa_oficial/2019/05/30/165902/Jornal_Oficial_896.pdf'}],
 'is_extra_edition': False,
 'power': 'executive',
 'scraped_at': datetime.datetime(2020, 7, 15, 23, 6, 56, 192332),
 'territory_id': '3525300'}
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py", line 654, in _runCallbacks
    current.result = callback(current.result, *args, **kw)
  File "/mnt/code/data_collection/gazette/pipelines.py", line 68, in process_item
    "Unsupported file type: " + self.get_file_type(item["files"][0]["path"])
Exception: Unsupported file type: application/octet-stream

Did it happened to you too?
Also, I noticed that you are using semantic commit messages, and even thought the project ain't using it, I think that you're using the wrong prefixes on your commit. Can you check the link and maybe rebase the branch updating it to use the correct ones? I can help you if you need any help with that!

Hey! I've ran your spider and everything worked fine, despite a specific exception that I got for a specific pdf
2020-07-15 23:08:52 [scrapy.core.scraper] ERROR: Error processing {'date': datetime.date(2019, 5, 17),
 'file_urls': ['http://www.jau.sp.gov.br/uploads/imprensa_oficial/2019/05/30/165902/Jornal_Oficial_896.pdf'],
 'files': [{'checksum': 'b7a04c1acf00473424184155bf414332',
            'path': 'full/40152042da5f6a5cde56968d1bcb07951a1815d1.pdf',
            'url': 'http://www.jau.sp.gov.br/uploads/imprensa_oficial/2019/05/30/165902/Jornal_Oficial_896.pdf'}],
 'is_extra_edition': False,
 'power': 'executive',
 'scraped_at': datetime.datetime(2020, 7, 15, 23, 6, 56, 192332),
 'territory_id': '3525300'}
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py", line 654, in _runCallbacks
    current.result = callback(current.result, *args, **kw)
  File "/mnt/code/data_collection/gazette/pipelines.py", line 68, in process_item
    "Unsupported file type: " + self.get_file_type(item["files"][0]["path"])
Exception: Unsupported file type: application/octet-stream

Did it happened to you too?
Also, I noticed that you are using semantic commit messages, and even thought the project ain't using it, I think that you're using the wrong prefixes on your commit. Can you check the link and maybe rebase the branch updating it to use the correct ones? I can help you if you need any help with that!

I rebased, what do you think?

I rebased, can you check to see if is right? About this error it's seems because of incorrect mimetype from site itself.

I do not use the mime types returned by the web server. We use the magic library in the downloaded file instead. It seems to be a bug in the magic library or the file is malformed:
>>> import magic
>>> magic.from_file("Jornal_Oficial_896.pdf")
'data'
>>> magic.from_file("Jornal_Oficial_896.pdf", mime=True)
'application/octet-stream'
>>>

jvanz@earth:~/Downloads> file Jornal_Oficial_896.pdf
Jornal_Oficial_896.pdf: data
jvanz@earth:~/Downloads> file something.pdf
something.pdf: PDF document, version 1.3

I don't know why CI is failing on black formating.
(diario-oficial) ➜  spiders git:(patch-1) ✗ black sp_jau.py --check
All done! ✨ 🍰 ✨
1 file would be left unchanged.

I don't know why CI is failing on black formatting. 😭
(diario-oficial) ➜  spiders git:(patch-1) ✗ black sp_jau.py --check
All done! ✨ 🍰 ✨
1 file would be left unchanged.

When you use the --check black just checks which files would be changed if you run the black.

When you use the --check black just checks which files would be changed if you run the black.

This is the change you have to make:
-            date = dateparser.parse(date_value, date_formats=["%d/%m/%Y"],).date()
+            date = dateparser.parse(date_value, date_formats=["%d/%m/%Y"]).date()

Are you running black from your host machine?

This is the change you have to make:
-            date = dateparser.parse(date_value, date_formats=["%d/%m/%Y"],).date()
+            date = dateparser.parse(date_value, date_formats=["%d/%m/%Y"]).date()

Are you running black from your host machine?

Yes i run on my machine, i really missed that comma! Thank you!

I rebased, can you check to see if is right? About this error it's seems because of incorrect mimetype from site itself.

I do not use the mime types returned by the web server. We use the magic library in the downloaded file instead. It seems to be a bug in the magic library or the file is malformed:
>>> import magic
>>> magic.from_file("Jornal_Oficial_896.pdf")
'data'
>>> magic.from_file("Jornal_Oficial_896.pdf", mime=True)
'application/octet-stream'
>>> magic.from_file("something.pdf", mime=True)
'application/pdf'
>>>

jvanz@earth:~/Downloads> file Jornal_Oficial_896.pdf
Jornal_Oficial_896.pdf: data
jvanz@earth:~/Downloads> file something.pdf
something.pdf: PDF document, version 1.3

I think file is malformed as you said, do you think we should do some workaround or leave as is?

Yes i run on my machine, i really missed that comma! Thank you!

The black from the host machine does not show nothing wrong as well. But the version from the container does. xD
I think I'll add a make target to run black using the container version...

I think file is malformed as you said, do you think we should do some workaround or leave as is?

For now, I think we can leave as it is. Please, open a issue and put this problem there. Thus, we keep this issue documented and someone can work on that in the future.


Added Maintenance Page  Template

Added Maintenance Page Template

CSS problem

Please review and let me know if its working properly.


[feature] allow empty segment ID when parsing resource identifier

Description
The bgpServiceCommunities API in Network will return ID like below.
{
    "value": [
        {
            "name": "Exchange",
            "id": "/subscriptions//resourceGroups//providers/Microsoft.Network/bgpServiceCommunities/Exchange",
            "type": "Microsoft.Network/bgpServiceCommunities",
            "properties": {

The subscription ID and resource group name are empty. That will cause error when parsing the return value:
Failed BGPCommunityApiTest [6 s]
  Error Message:
   System.ArgumentOutOfRangeException : Invalid resource id.
Parameter name: resourceId
  Stack Trace:
     at Azure.ResourceManager.ResourceIdentifier.Init(ResourceIdentifier parent, ResourceType resourceType, String name, Boolean isChild)
   at Azure.ResourceManager.ResourceIdentifier.AppendNext(ResourceIdentifier parent, List`1 parts)
   at Azure.ResourceManager.Network.Models.BgpServiceCommunity.DeserializeBgpServiceCommunity(JsonElement element) in C:\Users\mingzhehuang\workspaces\azure\azure-sdk-for-net\sdk\network\Azure.ResourceManager.Network\src\Generated\Models\BgpServiceCommunity.Serialization.cs:line 102
   at Azure.ResourceManager.Network.Models.BgpServiceCommunityListResult.DeserializeBgpServiceCommunityListResult(JsonElement element) in C:\Users\mingzhehuang\workspaces\azure\azure-sdk-for-net\sdk\network\Azure.ResourceManager.Network\src\Generated\Models\BgpServiceCommunityListResult.Serialization.cs:line 32

I think we should allow empty ID values. If the return value is like this, then the service should consume it correctly as well.
[Note]: Migrated from ADO 6161

After discussion, we decided to add a directive in autorest.csharp to omit inheritance type replacement, so that BgpServiceCommunity can skip inheriting Resource.


Fix Java versions in build.gradle

The jitpack build is failing because it's using the wrong java version. My guess is that Jitpack read the values from the build.gradle. Changes referenced from Fabric 1.17 example mod.

I'm pretty sure that won't help. See this issue here: https://github.com/jitpack/jitpack.io/issues/4355.

Ah damn, maybe it's time to set up proper maven publishing? I'm willing to offer a spot on my repository (https://maven.florens.be), and I don't doubt plenty of other community members/groups would offer access to theirs when asked.
Regardless, the changes in this PR should probably still be merged.

Trinkets has been on a proper maven for several months (as can be noted in the readme) but you're right, still good to have in the script.

Ah whoops, not sure how I missed that. Thanks!


Enable CSP (frontend)

Enable Content Security Policy (CSP) on the frontend, to help protect against man-in-the-middle attacks and cross site injection.

More info from MUI - https://next.material-ui.com/guides/content-security-policy
More info from MDN - https://developer.mozilla.org/en-US/docs/Web/HTTP/CSP

Note - this will involve an update to the .env file

I'll look into how to set CSP with Heroku.


Support single-module transpilation mode

The compiler does not do emit based on semantic information in most cases. this allows us to provide an api for transpiling a module that does not require typecheck or full program information. just single file syntactic transformation.
This can be helpful in multiple scenarios, including: typescript-simple (https://github.com/teppeis/typescript-simple), JSPM (#2233), es6-module-loader  and as atom extensions.
A new compiler flag (--singeFileTranspilation or --disableFullProgramOptimizations for instance) that will make cases that break single file-transpilation an error namely: 1.Const enums defined in ambient modules and 2.Re-exporting types-only constructs when targeting ES6

:+1: though we need a good name for the flag :)

Proposed implementation #2550.
Regarding the name of the flag: we've already had a long discussion about possible names but all options were non-ideal, Some names that we've tried are: 'separateCompilation', 'singleFileEmit', 'disablGlobalOptimizations', 'safeForTranspile', 'isolated', 'singleFileScope' - we could not pick one since all of them were equally bad. What about moving from the boolean flag and instead have an enum named 'compilationMode' or 'compilationUnit' or something similar? Enum values will be 'program' and 'file' and 'program' will be default.
tsc a.ts b.ts --compilationUnit: file

Was this implemented or not? Something was merged, but Visual Studio Code does not transpile on save. It's major pain to transpile and compile all files each time, it causes a lot of file changes and triggers many webpack/browserify processes, time from edit to F5 is really big.
Only tool doing it at the moment single file transpiling is atom-typescript, but it's not using TSC for that.

@vladima we will need another check for reexporting type-only names in ES6 and in singleFile mode. we also need to update the name of the flag after the next desing meeting discussion.

PR #3208 renames the flag to --isolatedModules

The flag has been renamed to --isolatedModules see PR #3208 for more details.


Add a confirmation dialog to the L keyboard shortcut

The keyboard shortcut L is assigned to finding your location (which might take some time) and then moving the visible viewport to that position. Sometimes when you are typing tags on the keyboard you might miss the TAB and if you type L, then the editor would be stuck into determining your position for a while then jump for a position different from the one you are editing. So it would be great to add a confirmation dialog, or another measure such as disabling the shortcut for a little bit after filing tags manually to avoid such hassle.

Duplicate of #8474; see that issue for workarounds in the meantime.


Reset audio channel command

We will have commands that allow for the configuration of an audio channel to be changed, so providing a simple and convenient way to reset an audio channel back to its defaults would be useful.

Implemented.
A channel is reset by disabling and then re-enabling an active channel.  That will destroy the channel and create a new copy with default values.


Update syn related dependencies to 1.0

Sure, sorry :p I never know which projects have a release process so I always bump versions to avoid asking for releases afterwards. Removed the version bump from every PR targeting your projects

Released in 0.1.5.


Additional real world kivy language import examples

Goal:
Is to prevent people (like me) getting confused by the import syntax by adding 2 real world common examples to this process.

Nice addition, although you could merge it with the original comparison, like this:
To import something from python::

    #:import name x.y.z
    #:import isdir os.path.isdir
    #:import np numpy

Is equivalent to::

    from x.y import z as name
    from os.path import isdir
    import numpy as np

I thought about that, but was worried about mixing theory with practice. Though I admit to being on the fence.

import os.path.isdir

I don't think this is actually valid python, you can only import modules this way.

You are of course completely correct.

Thanks a bunch. :+1:


make container logs in lagoon namespace configurable

Some lagoon services should have log collection enabled to facilitate troubleshooting, whereas others won't need them (or are excessively chatty).
Perhaps adding a label to running pods to control collect/no-collect?

Yes, this whole functionality needs some reworking. Related: https://github.com/uselagoon/lagoon-charts/issues/321

The lagoon-logging chart doesn't disable logs collection from any lagoon-* namespace by default. Which namespaces specifically are you missing logs collection from?


Run as non root user

This patch changes terraform image to run as non root user.
This is mainly made to illustrate the problem with using non-root user.

Things work even wore on GitHub Actions:
images/devtools-terraform-v1beta1/tests/test_image.py::test_prototype_ok
-------------------------------- live log setup --------------------------------
2022-04-21T07:13:26 3097 1[40](https://github.com/coopnorge/engineering-docker-images/runs/6107702373?check_suite_focus=true#step:13:40)517699856192 010:DEBUG    root         test_image:62:ctx_dottf_dir RAPID_TEST = False
2022-04-21T07:13:26 3097<PHONE_NUMBER>56192 020:INFO     root         test_image:77:ctx_dottf_dir workdir = /tmp/tmpcuhfm3l5dottf_dir/terraform_dir
Creating network "terraform_dir_default" with the default driver
Creating volume "terraform_dir_xdg-cache-home" with default driver
Creating terraform_dir_devtools_run ...
Creating terraform_dir_devtools_run ... done
Initializing modules...
╷
│ Error: failed to create local modules directory: mkdir .terraform: permission denied
│
│
╵

1
ERROR


OCPBUGS-17113: rework unstructured types for monitoring

This PR incorporates the following changes:

refactoring the existing functions (and comments) a bit,
cache-based apply for unstructured monitoring types, and,
adding explicit *KnownUnstructured functions for alertmanager and prometheus.

Slack discussion thread for the same.
/cc @dgrisonnet

/jira refresh

/retest

[ ] Additionally, look into utilizing observedGeneration and resourceVersion fields whenever present to better cache based on object spec and metadata changes.

I completely missed that PR, @rexagod is this still relevant?

/retest

Tests seem to be failing since earlier we only checked for spec changes when Applying a resource, unlike now, where we fail-fast if the metadata is the same. This functionality cannot be tested in a unit-test currently since we rely on resourceVersion and generation now, so I'll add an e2e test (which is a bit odd since I don't see those being run in the workflow, given there already exist some of those).

Ah, makes sense.

I'd prefer a single test-e2e target in the aforementioned Prow definition, which would prevent us from having to add a new e2e target every-time it's introduced here, in /release.

/test unit

/test unit

(friendly ping @dgrisonnet)

(friendly ping @dgrisonnet)

cc @deads2k

(bump)

lgtm

Thanks, this
/lgtm

@jan--f Can you please lgtm again, I pushed a fixup commit that I dropped after a while.

/lgtm
:+1:

Rebased, needs /lgtm.

Friendly ping. 🙂
cc @deads2k

/lgtm

/approve

Unfortunately this PR doesn't work as expected, see https://github.com/openshift/library-go/pull/1575#discussion_r1791701946 for more info.


Explain in caveats section that you cannot have properties named type

type is reserved in Rust I believe, so you can't have fields named type

Related: https://github.com/demergent-labs/azle/issues/355

@dansteren look at this, another problem to solve similar to: https://github.com/demergent-labs/kybra/issues/99

Thanks to https://github.com/demergent-labs/cdk_framework/issues/13 we actually CAN have properties named type


Only install requested packages for Debian, CentOS, Fedora

http://tracker.ceph.com/issues/12543
This PR makes it such that install --rgw only installs radosgw, --cli only installs ceph-common, etc.
This does preserve backwards-compatibility. The default is still "everything", where everything is MON, OSD, MDS, and RGW.  This just makes it such that if a user requests specific daemons, we install the minimal set of packages that can satisfy the request.
That set of packages can be different depending on OS.  For example, debian packages have a separate ceph-mds package (enabling it to be installed by itself), but EL/RPM packages do not.
I tested that this didn't break anything by running this sequence of commands on Trusty, CentOS 7, and Fedora 22:
ceph-deploy install --cli <node>
ceph-deploy install --rgw <node>
ceph-deploy install --mon --osd <node>
ceph-deploy install --mds <node>
ceph-deploy install <node>
ceph-deploy install --dev master <node>
ceph-deploy install --dev master --rgw <node>

Except for on Fedora, I could only test with --dev master since there are only F22 packages on gitbuilder.
In each case, I looked at the top-level packages listed by Yum/Apt/DNF to see it was the expected set.  All looked good!

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/ceph-deploy-pull-requests/1712/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/ceph-deploy-pull-requests/1715/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/ceph-deploy-pull-requests/1716/
Test PASSed.

@alfredodeza See if you like this better.  :)


lax.associative_scan: fix docstring examples

Fixes #4165

Oh, looks like there's already some work on this: #3583

How about we kill #3583 in favor of this one? You could steal any useful bits from it.


Update Go to 1.19.1

This version fixes two security issues in the net/http and net/url packages. See the release notes [1] for more details
[1] https://go.dev/doc/devel/release#go1.19.1

/test


Is there a way to load the views that generate the datatable?

I need to change the style of the datatable, but i need to change the html a little bit is there a way to do this?
Thanks in advance

What needs to be changed on the HTML?

It was something to accomplish a specific design, but it was solved in other way. This should be closes :)

Thanks @jh125486 and @pablosalgadom :+1: :clap:


doc: added some missing developer processes (#81066)

Is there a good reason why "Apply SQL Scripts" does not work recursively?

What do you mean exactly? What do you expect?

I’d expected the script to process subdirectories recursively as with the handling of the stored prcedures.
This is not an issue, but not intuitiv.
From: Andreas Herold @.>
Sent: Montag, 21. November 2022 16:24
To: intershop/devenv-4-iom @.>
Cc: Marc Mamin @.>; Comment @.>
Subject: Re: [intershop/devenv-4-iom] doc: added some missing developer processes (#81066) (PR #33)
Is there a good reason why "Apply SQL Scripts" does not work recursively?
What do you mean exactly? What do you expect?
—
Reply to this email directly, view it on GitHubhttps://github.com/intershop/devenv-4-iom/pull/33#issuecomment-1322228545, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXSMXP252PRSP4ZXBUERGXLWJOHX7ANCNFSM6AAAAAASGWNX3I.
You are receiving this because you commented.Message ID: @.***>

Please have in mind, that there is also the command "apply sql-config". This command executes all SQL-scripts from the config directory recursively.
But I will add an issue for "apply sql-scripts" to work recursively, mainly to be able to easily update ALL stored procedures.


Excluded root-level files and .github from Istanbul

What kind of change does this PR introduce?
Excludes files that aren't really part of code coverage from Istanbul instrumentatio
Did you add tests for your changes?
No.
Summary
https://github.com/webpack/webpack/pull/6487 has code coverage calculated as decreasing. Unfortunate.
Does this PR introduce a breaking change?
No.

You know, on second thought, I'll just have this only affect the .github files.

Ping @TheLarkInn  - came across this cleaning up my list of open PRs 😄 think you could take a look?

Thank you!


Set preset target temperature not updating in ac mode

With the changes you have done, I have created the following script to update the comfort target in comfort mode:
service: versatile_thermostat.set_preset_temperature
data:
  temperature: "{{ state_attr('climate.thermostat_livingroom_2', 'temperature') | float }}"
  temperature_away: "27"
  preset: comfort_ac
target:
  entity_id: climate.livingroom_ac_2

It works great in heat mode but in AC mode I have to go to another preset and go back to comfort for it to take the new value into account...
Désolé, je suis ch... :)

Non tu n'es pas ch.... tu veux faire marcher et je te remercie du signalement. Ca améliore la plateforme pour tout le monde.
I don't have really test it but I see it should work out of the box. I will have a look. I'm sure it is very simple.

Hello,
I have published a try to fix the issue. It seems working on my test env. Can you please check with your configuration if it is working ?
If yes I will release the fix.


Adding straight_heater_metal gen and updating its testcase

Adding straight_heater_metal gen and updating its testcase

@atorkmabrains Ready to review