fix: set envs only when passed

Problem
Currently, all TRIVY_XXX environment variables are always passed to entrypoint.sh, which prevents configurations set in trivy.yaml from being correctly applied. This occurs because environment variables take precedence over configuration files.
Proposed Solution
This PR implements a workaround to set environment variables only when values are explicitly provided. However, there's currently no reliable method to determine if a value has been passed in GitHub Actions (see https://github.com/actions/runner/issues/924).
Implementation Details

We now compare input values against their defaults and only set the corresponding environment variables if they differ.
TRIVY_CACHE_DIR is an exception and is always set, as it requires a value different from Trivy's default.

Updated the README to clarify that TRIVY_CACHE_DIR cannot be controlled via trivy.yaml due to this implementation.

Testing
https://github.com/knqyf263/trivy-action-test/actions/runs/11250664411/job/31280013016

I'm encountering the TOOMANYREQUESTS issue https://github.com/aquasecurity/trivy-action/issues/389.
I tried bumping trivy-action to v0.25.0 as people suggested and it didn't solve the problem.
Yesterday v0.26.0 was released where the caching mechanism was added by default but it didn't solve the problem either (well, makes sense as I'm still past the rate limit..).
When I tried adding env variables (on v0.26.0) I encountered this exact problem.
Is this PR going to be merged soon?
All of our CI pipelines that use trivy-action are failing...

TRIVY_DB_REPOSITORY and TRIVY_JAVA_DB_REPOSITORY shouldn't be affected by this problem.

@knqyf263 Then how come I'm experiencing the problem when I set them?
      - name: Trivy vulnerability scan
        uses<EMAIL_ADDRESS>        with:
          scan-type: image
          image-ref: 'FILTERED'
          trivy-config: .trivy/trivy.yaml
        env:
          TRIVY_DB_REPOSITORY: public.ecr.aws/aquasecurity/trivy-db:2
          TRIVY_JAVA_DB_REPOSITORY: public.ecr.aws/aquasecurity/trivy-java-db:1

What I understand is that whenever any TRIVY_XXX variable is set trivy-action would completely ignore action inputs.

What I understand is that whenever any TRIVY_XXX variable is set trivy-action would completely ignore action inputs.

No, only variables defined in input are affected.

I tested and it worked.
https://github.com/knqyf263/trivy-action-test/actions/runs/11272540264/workflow

@knqyf263 Can you test it with trivy-config set too?

No need if it worked :) I'll wait for your merge. Thanks!

I upgraded to 0.27.0 and now a new error was raised...
Error: Bad request -<EMAIL_ADDRESS>is not allowed to be used in FILTERED. Actions in this workflow must be: within a repository owned by FILTERED, created by GitHub, or verified in the GitHub Marketplace.

I know that there's an open issue (https://github.com/aquasecurity/trivy-action/issues/409) about this bug.
Do you have a time estimation for this fix? I'm in the loop of bumping trivy-action versions and being held by new bugs that appear in each new version.


Improvements in some documentation

Small improvements/fixes I suggest related to documented examples.
Note: this is my first PR in this project, so please let me know if there if something is wrong or needed.

Close the PR as it hasn't been updated for a long time.


Added support for HTTP PATCH on Helidon SE

Implementation for https://github.com/oracle/helidon/issues/1172

/oca-checked

/trigger

/trigger

/trigger

/trigger


Tweak wrapper for UMD compatibility and correctly declare dependencies

Can we get the AMD style wrapper tweaked so it's UMD compatible? This will allow the plugin to be loaded via AMD loaders (require.js, almond.js) as well as CommonJS style loaders (node, browserify, webpack).
See: https://github.com/umdjs/umd/blob/master/jqueryPluginCommonjs.js
Also, package.json does not declare jquery as a dependency which seems odd since it's a hard-dependency and won't function correctly when loaded with node/browserify.

+1

I think 2.1.0-rc8 should be good. Let me now :smile:


dcmp: add ACL comparison support

ACL(Access Control List) is widely used in modern file-systems, to support advanced
management.
So here we add a new comparison option named 'ACL' (-o ACL=DIFFER...) to support the ACL
comparison.
Following is a sample to use this feature:
 # getfacl /mnt/lustre/file_1
getfacl: Removing leading '/' from absolute path names
 # file: mnt/lustre/file_1
 # owner: root
 # group: root
user::rw-
user:ntp:rwx
group::r--
mask::rwx
other::r--

 # getfacl /mnt/lustre/file_2
getfacl: Removing leading '/' from absolute path names
 # file: mnt/lustre/file_2
 # owner: root
 # group: root
user::rw-
user:ntp:rwx
group::r--
mask::rwx
other::r--

 # ./install/bin/dcmp /mnt/lustre/file_1 /mnt/lustre/file_2 -o ACL=DIFFER
Files which have different Access Control Listss: [0/0]
ACLs are the same, so no diff found.

change the ACL of file_2 and run dcmp again:
 # setfacl -m u:rpc:rwx /mnt/lustre/file_2
 # getfacl /mnt/lustre/file_2
getfacl: Removing leading '/' from absolute path names
 # file: mnt/lustre/file_2
 # owner: root
 # group: root
user::rw-
user:rpc:rwx
user:ntp:rwx
group::r--
mask::rwx
other::r--

 # ./install/bin/dcmp /mnt/lustre/file_1 /mnt/lustre/file_2 -o ACL=DIFFER
Files which have different Access Control Listss: [1/1]

dcmp detected the diff.

Signed-off-by: Gu Zheng<EMAIL_ADDRESS>

hi @dsikich , could you please review it again? thanks.

Hi @dsikich , how about the updated version?

Hi @dsikich , could you please review it again and merge it?


Emit error event on compile error

This means that the entire browserify session doesn't die if you're
using it via the node api.
I ran into this while using riotify via a gulp watchfile, which would annoyingly stop every time a riot compile failed.

Thanks. It makes sense. @jhthorsen can I merge it?

Yeah.  I've merge this and update Riot ver to 2.1.0. @jhthorsen it's time to npm publish, pls ;)

https://www.npmjs.com/package/riotify # Version 0.1.2 released :smile_cat:
Thanks for the contribution.

Crap! I need more coffee... I updated the CHANGELOG as well. I will try to fix it now.

Oops, sorry I had to notice you. Anyway thanks.

No worries. My bad. (I usually check the log)


⚠ Bofrost.be has degraded performance

In c418858, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1390 ms

Resolved: Bofrost.be performance has improved in 81d6c42.


[RDBMS] BREAKING CHANGE: az postgres flexible-server migration: Move to new backend migration tool and add new Commands

Related command
Added --offline and --online flags to az postgres flexible-server migration create
Changed az postgres flexible-server migration update --cutover to az postgres flexible-server migration update --cutover db1 db2 db3
Added az postgres flexible-server migration update --cancel db1 db2 db3
Removed az postgres flexible-server migration delete
Description
This PR is a breaking change to how Migrations from Sterling to Meru Platforms is done in Postgres.
This changes the backend tool to shift to FMS(Flexible Migration service).
Added new offline and online modes to create migration with.
Added Cancel and cutover functionality for some/all databases involved in the migration.
Removed the Delete migration activity command and test cases.
Testing Guide
Updated the Test recording files with the latest JSON request and responses.
Did manually testing.
History Notes

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

RDBMS

@cpj2195 Can you supplement the details of command/parameter changes as history notes in PR description, including breaking changes? Here's a example:
History Notes

[RDBMS] BREAKING CHANGE: `az postgres flexible-server migration show`: Remove `--level` parameter
[RDBMS] BREAKING CHANGE: `az postgres flexible-server migration delete`: Remove this command, please use ... instead
[RDBMS] `az postgres flexible-server migration create`: Add `--migration-mode` to support ...

Is this feature targeting Ignite release? Our code complete date for Ignite release is 10/8. This PR is now targeting next release milestone on 11/1, please confirm

That's ok @evelyn-ys , we can go for the release in November.


Add source filename in “error from server” message when using kubectl

When I use kubectl create –f, I found that some error messages show the source filename. But “Error from server: …” messages don’t show the source filename. I think this is inconvenient, especially when I create resources from a directory, I don’t know which template file caused the error. Is it necessary to add source filename in “error from server” message when using kubectl? What’s your point?

Thanks, @feihujiang. I believe this can be closed since #10221 was merged.


Ensure Local Filter services are autowired

There is a bug in the instantiation / autowiring of Item and Collection spring services in the AbstractCondition class extended by other condition classes. I think it was accidentally introduced during some Unit and Integration test work in the final stages before merging the Logical Item Filtering pull request.
I have tested and confirmed this simple change (re-enabling the autowired annotation) fixes the issue.
To test:

Build this PR
Run the CLI command against an item using the "simple-demo_filter" (or another filter if you prefer - any will test the fix legitimitely) like this:
${dspace.dir}/bin/dspace dsrun org.dspace.content.logic.TestLogicRunner -f simple-demo_filter -i 123456789/3

If using the simple-demo_filter, it looks for a title containing 'demo', case insensitive. The launcher command should return false if the title does not contain demo, and true if the title does contain demo.
If this fix doesn't work, you will get a NullPointerException when the condition tries to access ItemService.getMetadata()

@tdonohue I have optimistically set a milestone of 7.4 as this bug is preventing item filters from working properly, and the fix is so simple. I hope that's OK.

@kshepherd : perfectly OK.  Just a note for the future, you are welcome to pull any PR over to our currently active project board (which I just did for this one).  Doing so will ensure it's considered for the next release & will prompt me to find reviewers in the next dev meeting.  Since 7.4 is concentrating on bug fixes first, I think it makes perfect sense for this PR to get included in 7.4

@mwoodiupui Thanks, that was something I missed. Unfortunately, after making that change, the Unit Tests are failing again. So I'll have to dig in again.

Just a note:  if you don't have that Item (for example, if you don't have any items because you created a fresh database) then it NPEs at TestLogicRunner:111.  Not an issue with this patch.


When there are more than two groups, when the first of the second groups has only one, the head view will be shifted downward

sorry ,Is my personal reasons, resolved now，thanks.

@ldy694 Why did this happen to you? I might have the same problem, but can't find a solution. Actually for me if the first row can have 2 slots but the next can't the cell on the 3-rd row is shifted to the right.

@unrealmagicdragon Because my constraint is wrong

It looks like @ldy694 solved his issue, so I will close this now. Feel free to reopen it if the issue continues. 👍


Gathering Records - Rank 1

Description:

Short Description of the needed Epic in the below format

As a ministry coordinator

I want to bulk upload records and have them deduplicated

so that I can provide the responsive records for an FOI request

What are the most critical features being built as part of this Epic

Batch upload of records into Object Storage
Deduplication of records

Expected Outcome – Justification why this Feature must be built, what is expected value and justification for priority.

Save LAN storage costs.
Reduce manual time moving records from LAN into system and manual step in Intella.
Sizing

T-shirt size:

[ ] S
[ ] M
[ ] L
[ ] XL
(S=1-2 Sprints, M=2-3 Sprints, L=4-5 Sprints, XL=not sure, probably more than 5 Sprints).

Risks and Assumptions*

[ ] What are assumptions?
[ ] What are the risks?
[ ] Have we done an RFC on a technical approach?
[ ] Are the dependencies (technical, business, regulatory/policy) known?
[ ] Has work on this Epic been prioritized with key stakeholders?

Does not include:
Number of pages
Number of pages deleted
Rank 2 - remove duplicate content
Rank 2 will be another release.

Closing this epic, as it was released in 7.0


bug: <leader>ss failing to open telescope symbol select on .ts files

Did you check docs and existing issues?

[x] I have read all the LazyVim docs
[x] I have updated the plugin to the latest version before submitting this issue
[x] I have searched the existing issues of LazyVim
[x] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
NVIM v0.10.2
Operating system/version
MacOS 15.2
Typescript extra has been enabled to configure LSP.
Describe the bug
I am using the bare-bones LazyVim config, only extras like JSON, markdown, toml, and typescript are enabled additionally.
Bizarre behavior from both telescope.nvim and trouble.nvim. Running <leader>ss fails to return a list of symbols when running on .ts files, while its running fine for the .tsx files in the same monorepo. Similar behavior is displayed by <leader>cs.
What flips me off is that running :Telescope lsp_document_symbols works on .ts files as well.
Error on .ts file (<leader>ss)

Works fine on .tsx file (<leader>ss)

Error from Trouble on .ts file

Telescope after running :Telescope lsp_document_symbols on a .ts file

Steps To Reproduce

Open a .ts file
Press <leader>ss

Expected Behavior
Should open the telescope buffer with a list of symbols to choose from when running <leader>ss on .ts files, if the the typescript extra is enabled and LSP is configured properly. Currently throws an error.
Repro
vim.env.LAZY_STDPATH = ".repro"
load(vim.fn.system("curl -s https://raw.githubusercontent.com/folke/lazy.nvim/main/bootstrap.lua"))()

require("lazy.minit").repro({
  spec = {
    { "LazyVim/LazyVim", import = "lazyvim.plugins" },
    -- add any other plugins here
  },
})

Did you change the LazyVim kind filters?

@folke With lua_ls when I do lua require("telescope.builtin").lsp_document_symbols({symbols = {"Class"}}) then I get a warning [telescope.builtin.lsp_document_symbols]: No results from textDocument/documentSymbol which comes from here. But with vtsls if I do the same in a TS file like the example in the OP, then I get warning [telescope.filter_symbols]: class symbol(s) were not part of the query results which comes from here. So, with lua_ls the result is empty from the server from the beginning and returns early, whereas with vtsls it seems that something is returned and then this line further filters symbols and maybe returns nil somehow that causes vim.tbl_isempty() to error?
Can't quite understand in more detail myself unfortunately.

ok, thank you for investigating. should be reported in telescope

Also this error started happening after commit https://github.com/nvim-telescope/telescope.nvim/commit/85922dde3767e01d42a08e750a773effbffaea3e whereas the previous commit https://github.com/nvim-telescope/telescope.nvim/commit/f06e7a887185796e0d37088237572f8ce03a1553 doesn't show this error. The symbols not showing as OP wants is just because of the stripped down default symbols LazyVim uses. He could add Variable to them or just change the mapping to call Telescope lsp_document_symbols without defining any symbols which should return all of them.
But the error seems to come from Telescope itself. Hope I didn't make any mistake and rushed to conclusions.

You're right:

Yeah I cloned Telescope and added 2 prints before this line. And before that line locations is a table but after utils.filter_symbols is applied then locations = nil. So, something going on in that function.

@folke Trouble has the same issue where for .ts files <leader>cs shows No results for symbols.

@kryptonian41 trouble works perfectly fine. There's no symbols, since we're filtering out a lot of symbol kinds.

@kryptonian41 You should also report it at Telescope repo, so it gets resolved, otherwise will you stay in a previous commit for ever?
As for Trouble, this happens because Trouble by default doesn't show all symbols by default as you can see in the docs (search for modes.symbols.filter.kind and you'll see what it shows by default). Alternatively you can call Trouble lsp_document_symbols toggle to show more symbols if you'd like or change in the Trouble plugin spec modes.symbols.filter.kind and add more symbols to your liking (but because that is a list you would have to copy over the default ones as well except if you're fine with just defining your own).

So, I mentioned in my first comment that I was getting the warning [telescope.filter_symbols]: class symbol(s) were not part of the query results, which meant that we had at least reached the point here in this function.
And I kept thinking about why locations = nil just after the utils.filter_symbols function. I think it's because after these warnings the function doesn't return anything. And I tried in my local forked Telescope repo and added just a return {} after the 2 if-elseif warnings here and it seems to work. I don't get the error about vim.tbl_isempty expected table but got nil. So, between current lines 182 and 183 just add return {}.
@kryptonian41 Maybe you would like to mention that in an issue at Telescope repo. I'm not that familiar with Telescope codebase and not 100% sure if the above addition has potentially other side-effects. But the thing is that if we get to the end of that function it seems to implicitly return nil because it doesn't have a statement to return something explicitly. I'm sure the people over at Telescope repo will know better than me if you explain things to them, like I've already mentioned as well.


Storage: Separate generation of backup config struct from writing it

This will allow us to generate a migration index header containing the same config used for backups.
Also includes a change to include the backup config in the backup index.yaml file to allow the unpack process full access to config to rebuild storage volumes (even for optimized backups) in the future.

Testsuite passed


Update README.md

Description
Adds a badge for the CI of cffconvert validation of CITATION.cff
Related issues:

#21

Instructions to review the pull request

Check that CHANGELOG.md has been updated if necessary

Review online by checking the badge at the top of the main README.md.

Thanks for reviewing!


Implement liveness and readiness probes on the Deployment

There are liveness and readiness probes defined on the envoy-gateway Deployment: https://github.com/envoyproxy/gateway/blob/main/internal/provider/kubernetes/config/envoy-gateway/deploy_and_ns.yaml#L40-L49
However, I don't see any code that implements these, and in my test cluster the pod is not responding to them and therefore not becoming ready / getting restarted regularly.
They need to either be implemented, or removed for now until we're ready to implement them so the pod can at least run.

The probe definitions have been temporarily removed in #238 to unblock running EG in cluster but should eventually be re-added and implemented properly.

I can help on this, assign this to me plz

Great, thanks @Xunzhuo!

@Xunzhuo are you still able to help with this issue?


Post 0.43 upgrade: PerfMonitor has no setter or ivar for its bridge

Description
After upgrading to React Native version 0.43, getting the red screen with error: "PerfMonitor has no setter or ivar for its bridge, which is not permitted. You must either @synthesize the bridge property, or provide your own setter method".

Reproduction Steps
Upgraded from version 0.42.3 using react-native-git-upgrade. There were no conflicts. Then ran "react-native link".
Additional Information

React Native version: 43
Platform: iOS
Development Operating System: MacOS

It looks like this line is swallowing the original exception: https://github.com/facebook/react-native/blob/master/React/Base/RCTModuleData.mm#L149-L153
Can you comment that try-catch to find the real underlying exception?

Hi guys, I'm having the same issue, have you found a way to fix it?

Resetting the simulator + deleting the ios/build folder worked for me.

Awesome, you right. That worked for me!
Thanks

The following steps worked for me.

clean xcode project
stop node package manager
rm -rf node_modules
yarn
restart project in simulator

Running via Xcode helped me.

After trying everything (rm node_module etc, clean, change the version of react-native (higher, lower, ....) dozen times. I can say the only thing WORKING for me is DELETING the IOS/BUILD folder.
Hope that help!.

Another solution is via Xcode menu bar : Product > Clean. Worked for me.

It is odd, because I get this error with RN 0.44.0 and only when running react-native run-ios command from terminal, if I am building using xcode - all is good.

@Mindaugas-Jacionis That's because xcode and react-native store the built binaries in different folders. react-native stores in your-project-folder/ios/build/, but xcode stores in ~/Library/Developer/Xcode/DerivedData

@hyb175 you're awesome! Thanks! :)

@hyb175 Your suggestion worked for me. Thanks.

FWIW… these were the steps I used to fix this issue for me:

stop node package manager
open project in Xcode
clean Xcode project (command-shift-K)
build Xcode project (command-B)  <-- this was the new step
rm -rf node_modules
npm install
restart project in simulator


fix cmd conflict

fix
https://github.com/oceanbase/obdiag/issues/288
https://github.com/yaml/pyyaml/issues/756

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

LGTM


Windows32 Support

Hi,
Thanks for the great resource. Unfortunately, this is not compatible with my current computing setup. Do you plan on adding support for 32bit Windows anytime soon in the future?

Super duper easy. Why don't you just:

replace all the references to rax/rbx/rcx to eax/ebx/ecx etc
switch the system calls to the corresponding interrupts (int 0x80), including changing the calling convention to whatever windows uses
remove all references to r8-r15 (including rewriting any procedures that use them). You might have to use the stack a bit more since the current code bends over backwards to avoid local variables since I'm bad at keeping track of them
redo the entry point at _start to whatever windows does since this is an ELF binary
replace all the sse floating point code with 8087 fpu floating point code if you don't have a processor with SSE
it should work.

Best of luck! Send me your fork if it works!


[7.x] Log Fake

The purpose of this is solely to fake the logger, NOT to provide assertions. All this does is send any generated logs into oblivion.
Here are some PRs that tried this in the past with assertions:
#22523
#25914

https://github.com/timacdonald/log-fake

I still think we need a way native to the framework to disable logging.
I'll put together another PR using the config method.

I still think we need a way native to the framework to disable logging.
https://github.com/timacdonald/log-fake

As a user of Log::channels() and Log::stack(), I expect that I can easily fake Log facade as it's possible with other facades. Having null driver is not enough for Log::channels() and Log::stack() cases.


[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2021-08-01

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No refresh required for updates in this PR

Contribution checklist:

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in a stable version
[ ] Removing properties in a stable version
[ ] Removing API version(s) in a stable version
[ ] Updating API in a stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

No API change from the previous version.

@ayfathim  Do we need to hold on for this PR?

@ayfathim Do we need to hold on for this PR?

Yes, the deployment for new version is in progress. Once completed, we can merge this PR. I will update here, once we are ready

@msyyc : Please merge the PR

@ayfathim Do we need to hold on for this PR?

The PR can be merged now. Our service an ARM Manifest deployment completed

Hi @ayfathim please get approve from reviewers, otherwise I can't merge it:

Changes look fine. ADX team, please go ahead and merge the PR.

Hi @ayfathim please get approve from reviewers, otherwise I can't merge it:

Hi @msyyc : Please merge. All required people have aaproved.


Reloading webview crashes in an edge case [macOS]

Describe the bug
I have a custom menu item to reload webview contents (in tauri). It uses following code:
window.with_webview(|webview| {
          #[cfg(target_os = "macos")]
          unsafe {
            let () = msg_send![webview.inner(), reload];
          }
        });

This worked fine until ~last month which started to cause a panic with this message:

Steps To Reproduce
I tried doing the same thing in custom_protocol example, but I can't reproduce this. Can you guide me through debugging what might cause this based on the stack trace, I'd be happy to help narrow down the issue and provide a Wry example / or move the issue to tauri.
more context: I added this code to wry example to trigger reloads which didn't panic:
  event_loop.run(move |event, _, control_flow| {
    *control_flow = ControlFlow::Wait;

    match event {
      Event::WindowEvent { window_id, ref event, .. } => match event {
        WindowEvent::Focused(_) => {
          #[cfg(target_os = "macos")]
          unsafe {
            let webview = _webview.webview();
            let () = msg_send![webview, reload];
          };
        }
        _ => {}
      }
      _ => {}
    }

Expected behavior
To reload the app without panic.
Screenshots
N/A
Platform and Versions (please complete the following information):
OS: macOS 14.2.1 (23C71)
Rustc: rustc 1.73.0 (cc66ad468 2023-10-03)
Additional context
N/A

Did you register any custom protocol by register_uri_scheme_protocol or register_asynchronous_uri_scheme_protocol?
Since it crash at https://github.com/tauri-apps/wry/blob/52c861bbef00f2762ae837e01b7d36fcb13cd0bc/src/wkwebview/mod.rs#L230 .. I'm suspecting the response is null, but I can't reproduce it either :\

Did you register any custom protocol by register_uri_scheme_protocol or register_asynchronous_uri_scheme_protocol?

I haven't, but tauri registers two of them that we use I think: ipc:// and asset://.


License file

Thanks for making this! I tried to use gstreamer's RTSP server and ran into issues with it not accepting the OPTION verb, whereas your project seems to work out of the box.
One request: without a license file, it's unclear what the project can be used for. When you have a moment, could you add a license file?
Thanks,

Brent

I've added an MIT license there now #4
Are you crafting the RTSP messages with a custom piece of code ?
It might be possible that there is some constraint that my code here is not checking, but I've found gst-rtsp-server to work nicely actually.


XSS

:o

https://stackoverflow.com/a/1732454/432100
i recommend using Preact or similar
it's tiny--only 3kb
if we want to stay with plain JS, i recommend using well-vetted HTML escaping code. Handlebars, for example.
currently, it might be possible for anyone to publish a post that will run arbitrary code in all of their followers' feeds

thanks for the suggestion, but @neauoire is pretty adamant about not including anything we haven't written ourselves. so no frameworks or libraries.
if this is really a security hole, then we'll have to find some other way to close it. cc @0x0ade

We're not using regex to parse HTML tags, but using regex to escape characters. We could as well just use .replace("&", "&").replace("<", "<")...
Handlebars seems to be a complete templating library, way more than we need for HTML escaping. A templating / virtual DOM library would be great to have, but it's a (semi-related but) different issue :)

By the way, something I noticed just now is how the & -> & replace could cause some wreckage when using escape_html more than once. We're only using it when "rendering," though, so we shouldn't be affected by that side effect for now.

The stackoverflow answer talks about parsing HTML, not escaping it, which is a different problem that's more amenable to regex.
The escaping code here follows the OWASP guidelines on XSS prevention (https://www.owasp.org/index.php/XSS_(Cross_Site_Scripting)_Prevention_Cheat_Sheet), with the exception of the forward slash, which does look like an oversight.
If you have a proof-of-concept for getting XSS into rotonde that would be helpful here.

@0x0ade the infinitely recursing substitution you dreaded is actually happening now:

I wonder if the following is still required now that we're escaping URIs when "rendering:" https://github.com/Rotonde/rotonde-client/blob/e91fe04b7d0b783223415957e323a18cb6296d0c/scripts/operator.js#L106
Also, I wonder what actually causes this. The media source should be escaped using escape_attr, which currently only takes the quotation marks (') into account...

@eelfroth #130 fixes the issues on my end - the media in question now displays properly on my portal :)

@0x0ade can confirm. it's fixed!

Fixed


Jackson 2.4.6 incompatible with HDP 2.4

When trying to submit a index_hadoop job to a HDP 2.4 cluster, I get the following error:
Error: class com.fasterxml.jackson.datatype.guava.deser.HostAndPortDeserializer overrides final method deserialize

From looking around, it seems to be a jackson version incomparability issue referenced by #1356.
I've tried building from source with an older version of jackson (2.3.2), but this fails to compile.
Is there a decent workaround for this issue?

The way we worked around this is to replace the HDP jackson jars with the ones from Druid so they both use the same version. This worked for us with Hadoop 2.7.2.

@waltonseymour You may have to look out for two things.

If you are composing a fat lib jar to be submitted to druid, make sure you clean the old jars and libs in druid'd hdfs classpath, as the new jars will not overwrite the old jars having the same filename.
And as Erik suggested, you have to make sure the version of jackson jars in druid's hdfs classpath or hadoop environment, matches with that of the jars come with druid core. You can tweak your build script by eliminating druid's jackson jars with Exclusion Rules and explicitly adding the required jackson jars.

I went down the fat lib jar route but ran into
io.druid.initialization - Could not find artifact org.apache.hadoop:hadoop-client:jar:2.7.1.
I cleaned out the jars from HDFS and tried a number of different things with no luck.
Do I need to recompile druid against Hadoop 2.7.1 also?

As a note, I was able to get druid working with HDP 2.4 by reverting #1989 and recompiling with an older jackson version.

@waltonseymour I have been using a simpler workaround described in this PR: #2815.
You can try it with the following configuration in your task if you want to continue using the Vanilla version of Druid:
    "tuningConfig" : {
      ...
      "jobProperties" : {
        "mapreduce.job.user.classpath.first": "true"
      },
      ...
    }

We are using Hortonwork Hadoop distribution in production. While running this job,  even I set the flag, it didn't work well. Still I am getting this error. My cluster is using Jackson 2.2.3 version and Druid is using 2.4.6 version. Can someone suggest me to solve the problem without replacing Cluster(Shared Cluster) Jackson Libraries ?

@santhoshtangudu have you looked at the steps described in http://druid.io/docs/0.9.2-rc1/operations/other-hadoop.html? It should help with your issue.

We were passing multiple versions of Jackson libraries. I stopped passing multiple versions and then the problem is fixed.
@fjy, thanks for quick help.

@santhoshtangudu How did you stop passing multiple versions?


(sozluk-content/terms): Writing descriptions of empty .mdx files.

The list will be updated as additions are made.

[ ] client-server-communication.mdx
[ ] cloud.mdx
[ ] content-caching.mdx
[ ] creational-pattern.mdx
[ ] database-operations.mdx
[ ] database.mdx
[ ] decision-support-system.mdx
[ ] devops.mdx
[ ] discord-bot.mdx
[ ] function-as-a-service.mdx
[ ] geographic-distribution.mdx
[ ] http-access-control.mdx
[ ] http-methods.mdx
[ ] lean-startup.mdx
[ ] load-sharing.mdx
[ ] machine-learning.mdx
[ ] metric.mdx
[ ] product-development.mdx
[ ] product-management.mdx
[ ] prototyping.mdx
[ ] rate-control.mdx
[ ] reliability.mdx
[ ] resource-allocation.mdx

Any of the items can be done separately, so feel free to take 1 by 1, just comment here that which one you are taking.

I don't know how i missed this but TY so much for this @igdiaysu <3

im taking cloud,http methods, and devops


AIP-131:  The collection whose resources are being listed should map to the URI path

AIP-131 states:

The HTTP verb must be GET. The collection whose resources are being listed should map to the URI path

There's a test today that verifies that parent is in the wildcard match, but nothing to verify that it matches the resource collection that I can see.

likely similar checks should be done for the rest of the standard CRUDL methods.

yes, this exists: https://linter.aip.dev/127/http-template-pattern.


How to place truma.yaml separately in Home Assistant?

Hi Magnus,
I needed to reinstall HA on my Pi4 and placed truma.yaml separately in the /config folder (besides configuration.yaml). Before, I had your truma.yaml code directly inserted in configuration.yaml but that got too large in the meantime, hence placing truma.yaml separately and referring to it from inside configuration.yaml seemed to be good to me. Following this guidance on splitting the HA onfiguration, I thought it works like this:
config/configuration.yaml
# Loads default set of integrations. Do not remove.
default_config:

# Load frontend themes from the themes folder
frontend:
  themes: !include_dir_merge_named themes

automation: !include automations.yaml
script: !include scripts.yaml
scene: !include scenes.yaml

# Truma inetbox2mqtt
#
truma: !include truma.yaml

I can save the configuration.yaml like this, but when I use the HA check of that config, it tells me:

Integration error: truma - Integration 'truma' not found.

I have no idea what I'm missing now. Can you please provide me with a hint? How have you set this up in your HA config? Thank you so much for your help!👍

The truma.yaml is a package in the HA logic.
Please note this description: packages

You can find a German description under the link Schleeh. Hannes rebuilt it just like you and of course found all the trapdoors. This is the basis for his instructions.
If you flash the new version onto your ESP32, there will be no problems. This has already worked for many people without any problems and you have already bypassed the hurdles with the LIN connection.


Fix : Easy Issue (JavaScript/Jasmine)

Pull Request Type
What kind of change does this PR introduce?
[✔ ] Solved an issue/task
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:
What is the current behavior?
Make Simple Jasmine Test Pass
Issue Number: [#1452]
What is the new behavior?
Made the Jasmine test in spec/booltest.spec.js file pass by adding expect and toBe statements inside the test case
Other information

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out our forkcommitmerge.io website repository. The repository contain real issues that you can help to resolve or create some of your own if you see any bugs or want to add new features to the site, etc. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


Telnet Library: Allowing control over connection timeout

When using the open_connection method of the Telnet library we can provide a timeout parameter. That value is used to control the timeout when executing commands (basically read functions). That timeout is only applied after the connection has been established:
    telnetlib.Telnet.__init__(self, host, int(port) if port else 23)
    self._set_timeout(timeout)

As you can see, there is no way to provide a timeout to the connection establishment in the __init__ call. Looks like the telnetlib will use the operating system global timeout socket._GLOBAL_DEFAULT_TIMEOUT that seems to be 2 minutes in my system.
That support should be easy to implement and I can provide a PR if you see that this can be merged.

Sounds good to me. Any objections by @jussimalinen?
Remote library had same issue. You can take a look at how it was fixed.

Sounds good.

Sounds good. :+1:

Does it sounds reasonable to use the same timeout parameter as the connection timeout too? Creating a new connection_timeout parameter does not sound good, and also may cause confusion about the purpose of the timeout parameter itself. What to you think about it?

I'm worried that the current timeout is a bit short, only 3 seconds, to be used for connection. This is especially true if it would be used also when waiting replies in general, not only when connecting, similarly as Remote does. This change would also be backwards incompatible without an easy to keep using system's default timeout.

That is true and if that was the approach chosen I would suggest increasing the default timeout. Anyway, how does a connection_timeout parameter sounds? Can you think on a better name? If you can't, I can go ahead on implementing, improve docs and add tests.

Increasing the default timeout would be backwards incompatible and I'm afraid we needed to increase it quite a lot.
connection_timeout sounds good. I doubt there's a need for a separate keyword for setting it, but I think the library itself should accept the default value and Open Connection should allow overriding it.

Implemented in #2119


Singleton and static keyword

Hi guys, i was wandering what the purpose of using static, if your class marked as Final?
final class Singleton
{
........
/**
     * gets the instance via lazy initialization (created on first usage)
     */
    public static function getInstance(): Singleton
    {
        if (static::$instance === null) {
            static::$instance = new static();
        }

        return static::$instance;
    }

Final has nothing to do with the static keyword.
Static keyword means that the property or value is bound to class not instance. This means that when you have a static attribute, it is shared between all instances of that class. If you have a static method it means you have to call it on the class as a whole not it's instance.
class StaticClass
{
    private static $someAttribute;

    public function setValue(string $newValue)
    {
         static::$someAttribute = $newValue;
    }

    public function getValue(): string
    {
           return static::$someAttribute;
    }
}

class NonStaticClass
{
    private $someAttirbute;

    public function setValue(string $newValue)
    {
         $this->someAttribute = $newValue;
    }

    public function getValue(): string
    {
           return $this->someAttribute;
    }
}

// Static instances shares the $someAttribute value as it belongs to the class not instance
$instance1 = new StaticClass();
$instance2 = new StaticClass();

$instance1->setValue("first");
$instance2->setValue("second");

echo $instance1->getValue(); // "second"
echo $instance2->getValue(); // "second"

// However the non static class instances each has its own value

$instance1 = new NonStaticClass();
$instance2 = new NonStaticClass();

$instance1->setValue("first");
$instance2->setValue("second");

echo $instance1->getValue(); // "first"
echo $instance2->getValue(); // "second"

The final keyword indicates, that the class cannot be extended. That means that no class can be children of the class marked as final. You can also define class methods as final which means that if you inherit the parent class you cannot overload that method.
I hope it is somehow clear and not too much confusing.

Okay, then what is the difference between 2 calls
static::$var
and
self::$var
?

There is a difference that the static and self references class where it is defined,
But if you inherit a class then it gets different. Consider having two classes: class Parent and class Child which extends Parent. If you use both keywords in Parent self will always be pointing to Parent. But the inherited class Children will override static which is then pointing to Children class.
In other words. If you access property with self it will be always pointing to the class in which you reference it, while the static will be pointing to class in which you use it. That is very handy for. eg calling methods in Parent that you don't want to be overridden.
For further reading I would suggest this StackOverflow thread https://stackoverflow.com/questions/5197300/new-self-vs-new-static
Hope it helps

Looks like you almost understood the main question

Hi @permiakov, when a class is final, it makes no difference if you use static or self. So there is no real need for it here, just a personal preference in this case.


Retry after tick

Description
wrike: https://www.wrike.com/open.htm?id=1266417999
The RetryUntilSuccessful action retries the child on the SAME tick, so the flow looks like:

ExePathAction fails
Recover fails (not recoverable error)
RetryUntilSuccessful retries ExePathAction again in the same tick
ExePathAction returns running
RetryUntilSuccessful returns running
We move to the next tick
IsBoolTrue detects that the error is not recoverable, halt the RetryUntilSuccessful and we exit the tree

So we run PF twice before returning
To fix this it is NOT enough to swap the order of the reactive sequence and the retry action, because the reaction will return FAILURE and BT gets stuck in infinity loop on the retry.
We would need to store variables to know if the failure was because of recover or execution, which is a bit messy.
I have created a new decorator with the expected behavior and an unittest for that.

before
after

yup, to me this is the expected behavior. let's PR to upstream too (maybe not marked as bug, not to offend anyone, he he)

I will create an unittest instead of showing our simulation


Fix replacement of strings for some fields (location)

Fix replacement of strings for some fields (such as 'location'). Places to look for:

BibDatabaseTest.circularString
REPLACE_STRING
resolveStrings
considerRefs
resolveForStrings

We worked hard to fix issues at JabRef. Could you please check whether this code quality issue still persists in the recent development versions of JabRef? Pull-Requests on the main repository are more than welcome.
We also have discussions on the architecture going on (https://github.com/JabRef/jabref/pull/2719) to keep improving the code quality.
See https://github.com/JabRef/jabref/wiki/High-Level-Documentation for our aims regarding the architecture.
It would be really nice if you joined our work on JabRef 4.0.


Account for newer Steam path in Linux installer

Description of the Change
Newer Steam installations under Linux change the installation path.  The tModLoader installer can now handle the new path (in addition to the two previous paths already handled).
Alternate designs
At first, I made a patchset (now revoked) that mimic'd the file's format more closely.  I feel that adding support for the new path in the previous format made the code unwieldy.  I feel that this solution is superior.
Why this should be merged into tModLoader
Users with newer Steam installations should be able to install tModLoader as easily as possible.
Benefits
This patch makes tModLoader easier to use for more people.
Possible drawbacks
None that I can see.
Applicable Issues
I did not test the XDG_DATA_HOME variant as I am unfamiliar with that setup.  But I am confident that the code flow for that variant remains unchanged.
Sample Usage
N/A

Functionally it looks fine, but I suggest the following variant using another function and return to reduce nesting and improve readability https://pastebin.com/qimB8sX9

Hi, thank you for the input; I made the edits you suggested.  I ended up deciding against the throw since the other *Info.java files don't do it... I just return null if nothing matches and let the caller handle that (the caller starts out with a null check).
I'm not savvy on the github interface.  I want to see that my amended commit landed in the right place... but there does not seem to be a timestamp or a history (??).  I do see that the "Files changed (2)" button displays the new set of files correctly.
Thanks!

Yeah good choice on the throw, I didn't actually look at the installer code, just reworking the control flow and added in lieu of actually knowing what to do.
With regards to git, it seems like you did an amend commit, and then forcefully overwrote your remote repo? The result is your commit has the right content, but wrong timestamp.
In generally it is extremely inadvisable to perform actions that rewrite a repository's history, once that history has been pushed and is no longer local (hence having to add the -force flag when pushing).
Fortunately, it was just an amend commit with no comments or other directly related stuff in the PR, so everything silently lined up.
What's recommended in this case, is that you just create another commit with the new changes, and when we merge it into the repo there's an option to squash everything down so it looks clean.

Thanks for the insights.  You were both astute and correct: I force pushed an amended commit.
I'm used to the Gerrit frontend for Git (not GitHub).  I was trying to mimic my familiar workflow where committers are responsible for periodically amending their commits (either with rebases or fixes from comments) so that the committer's job is as easy as possible when he decides to pull the trigger.  I did not realize that it was preferable on GitHub for me to just make a second commit (as opposed to amending the first) and to let you take care of the squash.  Thanks for the patience and for the cool software product!

Yeah, using a git frontend is perfectly fine, I'm a fan of TortoiseGit myself, and have used a few others in the past. We also advocate rebasing over merging wherever possible, because the linear history is much cleaner in most cases

Hmmm... please see attached.  Was this my change???  I sure hope not.  It
worked for me before pushing...
Thanks!
On Tue, May 30, 2017 at 8:52 PM, Chicken-Bones<EMAIL_ADDRESS>wrote:

Yeah, using a git frontend is perfectly fine, I'm a fan of TortoiseGit
myself, and have used a few others in the past. We also advocate rebasing
over merging wherever possible, because the linear history is much cleaner
in most cases
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bluemagic123/tModLoader/pull/182#issuecomment-305067653,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Abrfkcd5cmnzppI-r8Nh0Lst7Mj8PM3mks5r_NX8gaJpZM4Npiq8
.


Zoom in and Zoom Out issue

Hi,
I am trying to do zoom in the image but unable to do. As you have not provide this functionality in this.
Please help how can i do this.

Duplicate of #179


Current price of selected coin should be updated periodically and displayed on window

Current price of selected coin should be updated periodically and displayed on window
Price will be updated each share submission

Current price is displayed on window, tested and working. If Europe is selected as region, price is displayed in EUR rather than USD


Issues with lots of output

The code
for number in range(10000):
    print(number)

works the first time you run it on Papyros. However, Papyros stalls the second time you run it. You can still "Terminate" the code though, and run something else. That works fine.

I've done some experimenting regarding this issue on https://github.com/dodona-edu/papyros/tree/issue17/too-much-output.
First off, I noticed indeed that the first run works. Looking at the logs, when executing a second time, the code is sent to the worker but not received, so it is not executed. However, after a long time (around 211 seconds), the message did get through. I'm not sure why it blocks, as all the output messages have been successfully delivered.
When only printing 1000 numbers instead of 10000, the problem does not arise, so I figured it has something to do with the amount of messages sent back and forth. In the mentioned branch, I added a queueing system so that print messages are buffered before being sent over to the main thread. However, queue sizes of 100 or 1000 did not solve the problem, the second run still did not get through in a timely fashion.
A potential alternative is just ignoring too much output and notifying the user that further output is not displayed. Perhaps even writing to a file, something Jupyter notebooks do when too much output is generated. But at this moment I don't see a proper solution as I found no helpful information on the internet either regarding too many messages or data being sent.

@bmesuere @pdawyndt Thoughts on my writings here?

We cannot simply ignore lots of output not working. Given the target audience, this will occur.

I agree, but my research showed that the run-code message seemed to be delayed. I am unsure why this is, and the queueing system I implemented did not solve the issue. The issue is also present in the JavaScript version, so it is not related to Pyodide. It is thus likely to be a Comlink issue, or even something regarding the Messaging system used by WebWorkers (a data or message limit? But queueing would solve the message limit, and I did not find any other clues).
I think we would like to keep displaying messages while running the code, so I can propose the following solutions:

Hacky and simple: if the code hasn't started running a couple of seconds in, restart the backend and retry.
Try a file-based solution where large outputs are written to a file instead of displayed (like Jupyter notebooks)
Ignore displaying long outputs and simply show a truncation warning.

I 'solved' this for Python, was it solved elsewhere for JS?

Indeed, JavaScript still suffers from this issue. Could you elaborate a bit more on how you tackled this problem internally?

There's some buffering in https://github.com/alexmojaki/python_runner/blob/master/python_runner/output.py which combines bits of output together so it doesn't trigger the callback for every print. I think you were on the right track above - either comlink or web workers themselves don't handle huge numbers of messages well, and some kind of queue/buffer to reduce the number of messages is probably the solution.


Multiple marks at the same node not working

Based on the codesandbox: https://codesandbox.io/s/wonderful-ramanujan-jtq41
When I try to add bold, italic and underline at the same element and then save to local storage and console.log(str);
it includes only the first mark I have selected and the other marks aren't saved.

@muhammedmagdi ,
Thanks you for the reporting!

fixed and released in 0.9.1


20170411 093200 remove flask server deps

This PR was used to remove flask server requirements from the API setup.py. When certain users installed the api via pip they were required to install socketio and other deps which in certain cases failed to install correctly.

Coverage increased (+0.03%) to 93.568% when pulling ff37125a9236808bb67f5b3247cb9b426df6bce7 on 20170411-093200-remove-flask-server-deps into 290a983ba3abc5e3a2fd5aa1459260f5d0596117 on master.


No way to get file path.

As in the latest build 1.3.2 , getPath is deprecated, and we now have to use getUri but, in order to get the file path from uri , none of the methods available on internet works. So whats the way to get the file path.

This works for me:
ArrayList<MediaFile> files= data.getParcelableArrayListExtra(FilePickerActivity.MEDIA_FILES);
 files.get(0).getPath();

but then getPath is deprecated in favour of gerUri thus, and on sdk 29+, getPath return null

I am using sdk 29 and it works, have you tried:
android:requestLegacyExternalStorage="true"

I have tried that too, but its unluckily not working in Android 10, returning null for getPath().
Till Android 9 (that is, Pie), its working fine.

i am also facing same issue. even i used your suggestion but no use.

so we should return back to geturi

i have two device with android 10
one of them i can pick a file with path {xiaomi with android one }
second one, get null {Samsung A6
}

Same issue did you get any solution..?

I have same issue in Android 10 device if you have any solution please give me

I have same issue in Android 10 device if you have any solution please give me

I can get file using Uri on android 10 by following this answer


examples not equivalent

Description:
examples not in accordance with each other.
Related issue (if exists):

Coverage remained the same at 97.69% when pulling 6eb5fdf75c85e10bfa22a50bdd84d1d63487311a on calidion:master into 6922b16f4a297a4acbe8ad2b086c947b7c0d8315 on ReactiveX:master.

what does last commit do?

Coverage remained the same at 97.69% when pulling 05e9b621ee5bdf1e9815402b67250b068a576819 on calidion:master into 6922b16f4a297a4acbe8ad2b086c947b7c0d8315 on ReactiveX:master.

sorry, i should create a brach for this files added.

Coverage remained the same at 97.69% when pulling 05e9b621ee5bdf1e9815402b67250b068a576819 on calidion:master into 6922b16f4a297a4acbe8ad2b086c947b7c0d8315 on ReactiveX:master.

@calidion I'd like to suggest PR to include scoped minimal changes.
And also by seeing commits it seems there are some translated docs - while it is great appreciate, current doc folder is intended to publish into http://reactivex.io/rxjs/ directly and not for direct-reading in repo, which needs pipeline setup to have proper localization support for doc page generation.
If it is intended to provide translated documentation, please file an issue with a high-level proposal first to discuss & settle down initial pipelines. Again, appreciate for all effort!

Coverage remained the same at 97.69% when pulling 9035b63eec85552ecbc7ae7ce62d43b7aba9a76e on calidion:master into 6922b16f4a297a4acbe8ad2b086c947b7c0d8315 on ReactiveX:master.

@kwonoj
I have removed these files from master.
Those files are just a start of translation for learning purpose, I would not intend to integrate those files right now:)
sorry for the mistake.
To get better understanding of how RxJS works, I am verifying the code examples from articles inside the doc folder,  then I found this inaccordance. Hope i'm on the way to improve the document. If rxjs will support i18n, I would be glad to contribute.

sorry for the mistake.

: no worries, it is totally fine.

Hope i'm on the way to improve the document

: absolutely, it is one of important goals to fill missing document / improve existing one. Check this out. https://twitter.com/BenLesh/status/811728544543801345 :)

hope i can have some RxJS T-shirts some day:)

@calidion ... t-shirts are absolutely coming for people that contribute docs after my tweet. There's going to be a wait while I get them ordered and shipped, however. Still in the ordering process. It's a little slow over the holidays.

@blesh
I am translating official docs into Chinese,
don't know how to contribute to this project.

@calidion ... Yeah, I'm honestly not sure either. I'll need to check with the ReactiveX documentation folks and see what's been done in the past. I'll also check with the Angular team and see if they're doing anything like this.


Release binary naming

We need to settle on binary names for the following things we publish:

artifact

linux headless client

linux gui client (deb)

windows headless client

windows gui client (msi)

gateway

Note:

Docs need to be updated when these go live
Windows updater checker needs to be updated for windows binary name changes
Some users have already download the old binaries: https://tooomm.github.io/github-release-stats/?username=firezone&repository=firezone

### Tasks
- [ ] How does this affect the headless client standalone vs IPC behavior?

refs #4397

@jamilbk Without thinking of compatibility or how to make Tauri fit this, this would work for me:
For package filenames, brand-product_version_arch.extension

firezone-client-gui_1.0.0-pre.14_amd64.deb
firezone-client-gui_1.0.0-pre.14_amd64.msi
firezone-client-headless_1.0.0-pre.14_amd64.deb
firezone-client-headless_1.0.0-pre.14_amd64.msi

firezone-client-gui_1.0.0-pre.14_amd64.deb installs:

/usr/bin/firezone-client-gui
/usr/lib/firezone-client-ipc
/usr/lib/systemd/systemd/firezone-client-ipc.service

firezone-client-gui_1.0.0-pre.14_amd64.msi installs the equivalent for Windows
firezone-client-headless_1.0.0-pre.14_amd64.deb installs:

/usr/bin/firezone-client-headless
/usr/lib/systemd/systemd/firezone-client-headless.service

firezone-client-headless_1.0.0-pre.14_amd64.msi installs the equivalent for Windows
If the Gateway ever needs deb / MSI it would be similar to the headless client. i.e. firezone-gateway_1.0.0-pre.14_amd64.deb installs:

/usr/bin/firezone-gateway
/usr/lib/systemd/systemd/firezone-gateway.service

Checklist:

exe paths don't need OS, arch, or version
exes not meant for the user to launch are in /usr/lib, outside of $PATH
Token, device ID, etc. are configured separately from the systemd service, which is stored in /usr/lib and so gets wiped whenever the package upgrades
All files start with the firezone- prefix since they'll end up places where files from other organizations live
The headless Client and GUI Client don't conflict, as long as only one of them is configured to auto-start with systemd
package filenames include the full version tag

- [ ] FIREZONE_ID should be in `/etc`, not in the systemd service file in `/usr/lib`. The tests currently set a bad example for this.
- [ ] FIREZONE_DNS_CONTROL can be in the systemd service file, but it should be overrideable somewhere.

The one thing that would need to be addressed is auto upgrades for Gateways.
See:

https://www.firezone.dev/kb/administer/upgrading
https://github.com/firezone/firezone/blob/main/scripts/gateway-systemd-install.sh#L74

I supposed auto upgrades for Clients would need to have a solution as well. We would need some kind of version manifest, like scripts/manifest with key=value pairs declaring the latest version of binaries we can use to build download URLs from.
We could get this from the GitHub unauthenticated API like we currently do for the Windows client.
But while that works as a stop-gap measure today, it won't scale very well because it's IP-based rate limited with very low limits.
Imagine lots of in-office employees not receiving auto-updates, or gateways behind a load-balancer not being auto-updated.
The standard HTTP API with the /releases/download/latest shortcut doesn't appear to be rate-limited.

This could work:

website/manifest contains versions of components
scripts/Makefile update to version components from the website/manifest file
Add a route handler to website to redirect latest to the version on website

Yeah adding a manifest to the website and keeping the binaries themselves on Github for now sounds good
I might use the Windows Client as a guinea pig today to see what breaks if I add the version number to the name. Last time I considered it I thought it wouldn't work, but actually it might.

I think this has been resolved


 Please describe.
Every month some number of apps that have been deemed eligible by Blockstack PBC, and put in "Ready" status on App.co/mining/apps, are subsequently deemed ineligible during the ranking period by one or more app reviewers. Last month this happened to 10-15 apps. This typically happens because of a bug or setup used by a reviewer where they can't authenticate.
How is this problem misaligned with goals of app mining?
App creators and Blockstack PBC don't have clarity of whether or not an app is eligible until after App Reviewers have submitted their rankings. Apps should have a binary understanding of App Mining eligibility at the beginning of each month. If bugs exist in apps, or individual reviewers are unable to assess certain apps, those should be ranked towards the bottom vs. not being eligible.
What is the explicit recommendation you’re looking to propose?
If apps meet all requirements for eligibility, and are deemed eligible by Blockstack PBC at the beginning of an App Mining run, they are eligible for that run. Any App Reviewer who discovers bugs or issues with judging an app will give it a score reflecting this fact, and the ranking will therefore be very low.

Will Blockstack PBC review all apps each month for eligibility?

We already do this, and is reflected on the app.co/mining/apps page with each app's status as either "Ready" or "Not Ready".

Isn't it unfair to payout rewards to app publishers that do not care, that do not fix their bugs, .. ?

@friedger I don't think this is what that ticket is arguing for. Please start a new ticket for that topic.
PBC discussed and feel it is better to set expectations for newly enrolling app miners instead of changing the current process. Next steps: update docs. I will follow up with copy.

My point was that reviewers should be able to flag apps as ineligible when
they can review the app. With this proposal the flagged apps could become
ineligible for next month if Blockstack PBC thinks so with the information
provided by the reviewers
On Tue, 20 Aug 2019, 15:47 Gina Abrams<EMAIL_ADDRESS>wrote:

@friedger https://github.com/friedger I don't think this is what that
ticket is arguing for. Please start a new ticket for that topic.
PBC discussed and feel it is better to set expectations for newly
enrolling app miners instead of changing the current process. Next steps:
update docs. I will follow up with copy.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/blockstack/app-mining/issues/140?email_source=notifications&email_token=AALBYWPBRHVGR2IVVO4YB23QFPYV7A5CNFSM4IJXWGOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4WLCQQ#issuecomment-523022658,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALBYWPC6QO7JHXFBBWBV6TQFPYV7ANCNFSM4IJXWGOA
.

@GinaAbrams Is the proposal accepted or rejected?


Strip + signs from search query strings

[description]:

implement regex to strip + signs from search query strings

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/44e9eefe312ce056190365b1fa36fc90ff23b3ab/


TypeError: Unable to read user config.

After installing pinecone and run init to create a new theme.
I am unable to convert it because it says the config file is invalid.
Unable to read "pinecone.config.js". This is likely due to invalid syntax.

file:///usr/local/lib/node_modules/pinecone-cli/dist/config.js:44
            throw new TypeError('Unable to read user config.');

TypeError: Unable to read user config.
    at resolveConfig (file:///usr/local/lib/node_modules/pinecone-cli/dist/config.js:44:19)
    at async pinecone (file:///usr/local/lib/node_modules/pinecone-cli/dist/index.js:7:20)
    at async file:///usr/local/lib/node_modules/pinecone-cli/dist/cli.js:53:1

Is pinecone.config.js file created? If so, what are the contents?
I am unable to reproduce, trying:
mkdir new-vscode-theme
cd new-vscode-theme
npx pinecone-cli@latest

This creates the following structure:

new-vscode-theme

pinecone.config.js
themes/

_pinecone-color-theme.json
caffe-color-theme.json
caffe-latte-color-theme.json

This may be caused by not having "type": "module" in your package.json.
Node should show a similar warning if so:
(node:84073) Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension.

Ah my bad, you're correct. I did need to put the type to module.


Core dumped at the moment of switching to a new unreaded chat

Description:

8272 IOT instruction (core dumped)  nchat -d /home/dvragulin/.config/chat/telegram -ee

This behavior occurred after the transition from version 3.67 to 4.13. Unfortunately, I can't figure out how this behavior will be properly debugged. There is no information in the logs on this issue.
How to reproduce it:
I press ctrl+F and move on to the next chat. At this point, the application crashes. It does not fall every time, but with a frequency that I could not establish.
Environment:

Version: v4.13
OS / distro: Arch Linux x86_64 / zsh 5.9

Now I'm faced with the fact that it crashes at startup. Can you tell me how to debug this behavior? '-e` does not give any output to stdout...

Hi @dvragulin - thanks for reporting the bug. Unfortunately the logs do not provide sufficient insight for this crash.
Could you help to get the callstack of the first crash you encountered?
1. Determine PID of the crashed nchat instance
List nchat core dumps:
coredumpctl list nchat

It will output something like:
TIME                         PID  UID  GID SIG     COREFILE EXE
Fri 2023-12-29 10:36:42 +08 1651 1000 1000 SIGSEGV present  /usr/local/bin/nchat
Fri 2023-12-29 10:37:25 +08 1666 1000 1000 SIGSEGV present  /usr/local/bin/nchat

Find the timestamp which matches when you encountered the crash and take note of the PID column. (Based on the provided log.txt your crash timestamp should be around 2023-12-28 22:03:22.)
2. Get the callstack of the crash
Use the PID obtained from previous step, e.g. 1666, and use coredumpctl to start gdb:
coredumpctl debug 1666

Get callstacks of all threads in the process:
thread apply all bt

Copy all text starting from Program terminated with signal ... and save in a text file and please help to upload here. See attached crash-callstack-example.txt for an example. Finally quit gdb:
quit

Of course, here's the stdout: stdout.log

The above commit adds some "blind" robustness fixes which may or may not address the crash you are seeing.
In case you still see the crash after above fix, it would be very useful to get callstack from a debug build.

That's it, here's the result of the first run in the debug mode: stdout.log

Thank you 👍 This is very useful information!
It seems like it's a bug in tdlib (which nchat uses for Telegram), more specifically its markdown conversion code.
If you could open your debug core dump again coredumpctl debug nnnnn and run the following it would be very useful:
set print elements 0
f 17
p text
f 11
p text
p result
quit

Getting above info (basically what markdown message it's trying to convert) can help me determine if tdlib has fixed this in its latest code, or whether I should report a bug in the their project. Note: The output from the commands will contain message content, so if you don't want to share it here publicly, you can email it to me (d99kris at gmail dot com) or perhaps censor it (just try not to change the number of characters).
As a temporary workaround for this bug you can try disabling markdown conversion for Telegram. Edit the following file:
~/.nchat/profiles/Telegram_+nnnnnnnnn/telegram.conf

And set:
markdown_enabled=0

@d99kris Indeed, the markdown shutdown solution helped solve the problem. Frankly, I don't even see much difference in the text.
Here I suggest you take a look: stdout.log
I have replaced sensitive text sentences with SomeText in the hope that only the syntax will be enough for you.
Thank you very much for your help and support!

Hi again, many thanks for providing the informtation! 👍
I was now able to reproduce the crash on my machine. It appears the markdown conversion crashes when a link text is bold, underlined and in a block quote. I tested latest version of tdlib, and the crash appears to be fixed there. I've updated nchat to use latest tdlib in b4d1fa5. You should be able to re-enable markdown conversion if you like and use latest nchat. Feel free to re-open this issue if you're still encountering the issue.
FYI - with markdown conversion disabled, all messages look like plain text. For example if someone sends a message:
Message with bold and italic text.
Then nchat will display it as:
Message with bold and italic text.

Whereas if you have markdown conversion enabled, nchat will show it as:
Message with *bold* and _italic_ text.

And similarly when sending messages, with markdown conversion enabled one can do basic formatting and send text like:
Message with *bold* and _italic_ text.

And it should show up in the mobile app like:
Message with bold and italic text.


Update index.js to end the response stream

Fixes #12

@ShaunLWM Is there anything required to get this PR merged?

LGTM. Sorry I must have missed this. Thank you so much for this commit :)


GitHub Action to lint Python code

Test results: https://github.com/cclauss/FConnch/actions

Thanks for the help.


catalog/ingress: build policy from IngressBackend API

Description:
Builds the ingress traffic policies from the IngressBackend
API.
Part of #3779

Affected area:

Functional Area

Ingress
[X]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? no

Did you notify the maintainers and provide attribution?

Is this a breaking change? no

Codecov Report

Merging #3828 (3d387f8) into main (94394bd) will increase coverage by 0.33%.
The diff coverage is 94.73%.

@@            Coverage Diff             @@
##             main    #3828      +/-   ##
==========================================
+ Coverage   67.38%   67.72%   +0.33%
==========================================
  Files         198      198
  Lines       10978    11034      +56
==========================================
+ Hits         7398     7473      +75
+ Misses       3531     3511      -20
- Partials       49       50       +1

Flag
Coverage Δ

unittests
67.72% <94.73%> (+0.33%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/catalog/ingress.go
92.09% <94.73%> (+2.78%)
:arrow_up:

pkg/k8s/announcement_handlers.go
72.97% <0.00%> (-5.41%)
:arrow_down:

...icate/providers/certmanager/certificate_manager.go
86.61% <0.00%> (+0.70%)
:arrow_up:

pkg/catalog/endpoint.go
80.00% <0.00%> (+4.00%)
:arrow_up:

pkg/crdconversion/crdconversion.go
60.86% <0.00%> (+19.56%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94394bd...3d387f8. Read the comment docs.


Link to Linux experimental installer not working and questions - Linux (CentOS 7+): Linux-x86_64.sh (Experimental)

The link in the release 5.4.2 ---> 404.
IMHO, you should put the experimental sh file under spyder/installers/.
By the way, where is it?

Hi @texadactyl could you try again? It takes sometime to build the assets to the GitHub release to the links to work. I tried the link and seems like is working now. The installers are build using github actions after the GitHub release is created: https://github.com/spyder-ide/spyder/actions/runs/3953113492
Also, the installers can be downloaded from the Assets section of the GitHub release:

Ok, found it.
I realize that this is an experiment but a 523 MB shell script seems to be a bit much.  Impractical to inspect.  I would prefer something like spyder/installer/macos or spyder/installer/windows is organized.
What is the script building or installing?  A Linux executable?  Python packages?  If the later, this is already well-covered on pypi.org.

I ran the script for fun.  Unfortunately, it requires conda.  Pity that.  I have nothing against anaconda or miniconda but my partners and I create pypi packages.  One Python package manager is enough to contend with when you are building complex systems.
I'm still interested in answers to my previous questions.

Thanks, Daniel
On Thu, Jan 19, 2023, 12:58 PM Daniel Althviz Moré @.***>
wrote:

It would be nice to see some documentation of the experiment. What are you
hoping to achieve? I am just curious.
Basically we are exploring a migration from the current way we create for
Windows and macOS standalone installer to a conda-based approach. Since the
tool we are using (constructor https://github.com/conda/constructor)
allows to create a installer for Linux we are building it too. We choosed
to put them EXPERIMENTAL since is possible that errors that we are
unaware of appear while using them.
What is the script building or installing? A Linux executable? Python
packages? If the later, this is already well-covered on pypi.org.
In the case of Linux, the script as far as I know installs a standalone
conda executable with an env with Spyder in it (that's way it has such a
file size) and setups some elements like a shortcut to launch Spyder from
that installation/created environment.
Unfortunately, it requires conda. Pity that. I have nothing against
anaconda or miniconda but my partners and I create pypi packages.
The idea of this script and in general the standalone installers is to
offer an easy way for beginners (in Spyder but also Python) to install
Spyder without worrying about how to setup Python or a package manager.
Hopefully these answers make the idea we have behind these experimental
standalone installers based on conda (constructor) more clear and in
general the idea behind why we have the current standalone installers we
have been providing for Windows and macOS that are built using other tools (
pynsist https://github.com/takluyver/pynsist and py2app
https://github.com/ronaldoussoren/py2app).
Pinging @ccordoba12 https://github.com/ccordoba12 and @mrclary
https://github.com/mrclary just in case they want to complement/correct
the answers above or provide more info about the standalone installers
—
Reply to this email directly, view it on GitHub
https://github.com/spyder-ide/spyder/issues/20397#issuecomment-1397525703,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACWLLZBANCUBWN2OWRAQ3ZTWTGMGRANCNFSM6AAAAAAT7TFNOA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thanks, Daniel

What are you hoping to achieve? I am just curious.

Another important idea we hope to achieve, besides what @dalthviz already mentioned, is to allow users to easily install third-party Spyder plugins (e.g. Spyder-notebook or Spyder-unittest) in the installer environment. That's really hard with our current installers because we use pip to build them, Spyder plugins can potentially depend on any Python package, pip is not the best at solving dependencies (but it has improved a lot lately) and if something fails on installation, the installer will be broken. By using conda, we can have a much better control over that.

I realize that this is an experiment but a 523 MB shell script seems to be a bit much

That's not a shell script, it's a shell installer, i.e. it comes with all the necessary conda packages to run Spyder, regardless if they are provided by the user's Linux distro or not (that's why it's so big). Since it's not possible to always count on the presence of Qt, Gtk or another graphical toolkit on Linux, the simplest and most robust way to provide an installer for it is using this method.


add missing defaults to switch statements

When compiling with fips and vs2015 or vs2017, warnings are errors and switch statements without a default case are warnings.
This change adds a SOKOL_UNREACHABLE macro which right now is just defined to SOKOL_ASSERT(false).

Thanks! I've been working on clang only so far, and this doesn't complain in those switch statements (if the switch contains all values in the enum). VS seems to have a bit different behaviour. My goal is of course to have all compilers warning free.


How to Import Save File ? (data.prsv)

Hello,
First of all, thank you for this local and offline port of Pokérogue, it's exactly what I was looking for ^^.
j'ai juste une question, j'ai récupérer sur le site mon fichier data.prsv mais je ne sais pas comment le réimporter et toutes mes recherches sur internet (reddit et autre) n'ont donné rien de clair.
How can I recover my save from my account and reimport it so that I can play locally with everything I've unlocked and my progress?
If possible, I'd like the method for Windows and Android (mine is root).
Edit 05/08/2024 : Ok on android it's works !
I think it's a bug on PC app that don't show import button i don't know why but i report this for you

and on my android:

Thank you in advance for your help!
Have a nice day!

It's seems that window.location.hostname = ''
And in the code of online pokerogue project, they block the importdata feature (to prevent cheating on the "official" server) by making a condition on window.location.hostname
if window.location.hostname is different from 'localhost' (which is the case here), you cannot import data.
So 2 possibilities:

Find a way to have window.location.hostname = 'localhost' in Pokerogue-App
Asking in Pokerogue project to change the condition to make window.location.hostname = '' another case of local game

Unfortunately, I didn't find any workaround for the moment

Strange to propose to export data if we can't import them ?
and in android it's work perfectly as you can see on the screen
But ok i guess

Seems fixed : https://github.com/pagefaultgames/pokerogue/commit/94da7838f81b2da2d852fd0e5ea870fc73af7b4b

Oh! you're right I updated the windows application for offline and it's back ^^.
thanks for your answers!
I confirm ! it works =D

I still don't see the import save option in my menu?

I see that the online site also doesn't work.
so I still think it's a site bug

I see that the online site also doesn't work.
so I still think it's a site bug


README: stimpack -> packs-rails

stimpack has been renamed a while ago. Let's update the link text and URL to avoid confusion and hammer in the new naming. :)

This was done in 2750ced7d88751bb56ce798323fb7df4fb2df07e.


improve sanity check for geodesic distance calc

https://groups.google.com/forum/#!topic/cesium-dev/uTaQKBSzxCU
Based upon the discussion linked above, I think this is a small improvement to the current logic.  The commit message has the details and this description has more: https://en.wikipedia.org/wiki/Geodesics_on_an_ellipsoid#Behavior_of_geodesics
(commit message)

guard Vincenty's inverse computation (surface distance) by the cut locus specific to the ellipsoid (assumed as oblate given min/max radii)

(Wikipedia extract; emphasis mine)

Gauss (1828) showed that, on any surface, geodesics and geodesic circle intersect at right angles. The red line is the cut locus, the locus of points which have multiple (two in this case) shortest geodesics from A. On a sphere, the cut locus is a point. On an oblate ellipsoid (shown here), it is a segment of the circle of latitude centered on the point antipodal to A, φ = −φ₁. The longitudinal extent of cut locus is approximately λ₁₂ ∈ [π − f π cosφ₁, π + f π cosφ₁]. If A lies on the equator, φ₁ = 0, this relation is exact and as a consequence the equator is only a shortest geodesic if |λ₁₂| ≤ (1 − f)π. For a prolate ellipsoid, the cut locus is a segment of the anti-meridian centered on the point antipodal to A, λ₁₂ = π, and this means that meridional geodesics stop being shortest paths before the antipodal point is reached.

Thanks for the pull request @nmschulte!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.
:earth_africa: :earth_americas: :earth_asia:

Digging a bit more this idea may be misguided, even though Cesium seems to render things fine for my case.  I think the tolerance here is due to the nature of the approximation of the integral solution of Vincenty's formula, not necessarily the (maximum) locus length.  Please correct me if so.

@shunter did you want to take a look at this?

Thanks again for your contribution @nmschulte!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

@shehzan10 could you give this a review?

Digging a bit more this idea may be misguided, even though Cesium seems to render things fine for my case. I think the tolerance here is due to the nature of the approximation of the integral solution of Vincenty's formula, not necessarily the (maximum) locus length. Please correct me if so.

I think either @shunter or @fstoner have a better handle on this question than I do.
This code looks fine to me. On the default ellipsoid, maxLambda=3.131059488236545
thus the change is going from 0.0125 to 0.010533165353248108.
When I was doing the ellipsoid rhumb line code, I had a similar question about how 0.0125 was chosen, but this PR has a reasoning behind it. It was also brought up (tangentially) here: https://github.com/AnalyticalGraphicsInc/cesium/pull/7484#discussion_r248724062.
So the only thing I would request is that this change should be applied to EllipsoidRhumbLine as well https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Source/Core/EllipsoidRhumbLine.js#L141.

Thanks again for your contribution @nmschulte!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

@nmschulte can you merge in master?  I think these changes look fine, I'll get them merged in this month after the branch is updated.  Thanks!

Please also add a unit test

@nmschulte can you merge in master? I think these changes look fine, I'll get them merged in this month after the branch is updated. Thanks!

Is it a concern if I rebase these changes instead?  I can include refactor/changes to update EllipsoidRhumbLine as well.

Please also add a unit test

I'll try my best ;).
I'm still concerned that my logic connecting locus length to the approximation algorithm is incorrect and including this change will cause the formula to diverge (spin-lock/Bad Things™).

idea may be misguided, even though Cesium seems to render things fine for my case. I think the tolerance here is due to the nature of the approximation of the integral solution of Vincenty's formula, not necessarily the (maximum) locus length.

@nmschulte yes, a rebase would be fine.
Thanks for pointing out your concern about locus length.  I'm actually not familiar with that at all.  @fstoner  do you have any insight here?

Thanks again for your contribution @nmschulte!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

Thanks again for your contribution @nmschulte!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

Thanks again for your contribution @nmschulte!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

Thanks again for your contribution @nmschulte!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

Thanks again for your contribution @nmschulte!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

Thanks again for your contribution @nmschulte!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

Thanks for the PR @nmschulte, but I'm going to close this due to inactivity.  This check is probably fine, but it's been difficult to verify and get this merged.

Congratulations on closing the issue! I found these Cesium forum links in the comments above:
https://groups.google.com/forum/#!topic/cesium-dev/uTaQKBSzxCU
If this issue affects any of these threads, please post a comment like the following:

The issue at https://github.com/AnalyticalGraphicsInc/cesium/pull/7457 has just been closed and may resolve your issue. Look for the change in the next stable release of Cesium or get it now in the master branch on GitHub https://github.com/AnalyticalGraphicsInc/cesium.


Add Sscrutinizer

https://scrutinizer-ci.com/
example: https://github.com/phpmd/phpmd (see icon)

integration of scrutinizer is completed.


Adds max_page_size, a limit column, and supports the "*" attribute

First off - apologize for bundling these 3 changes for the price of 1. I'm happy to unpack the changes into 3 PRs for the purpose of merging if requested.
The purpose of these changes were us adapting our in-house pagination to this library without having to modify our FE client; as such we had to make three modifications for the following reasons.
Adding a max_page_size
Our pagination size is controlled by the FE, and as such we wanted to prevent abuses by setting up a global maximum of how many records can the FE request.
An alternative to this approach could be configure it on each paginator, but for our purposes a sensible global maximum made more sense.
Adding a limit column
This one was a nitpick from us - but while controlling the direction with after or before seems reasonable, having to further choose whether I want the first 10 records or the last 10 records feels unnecessary when that can be inferred.
For our purposes, having the library support: limit meant that our consumer code has to do less work figuring out which query params to send (and similar to our page_size, our pagination direction is FE controlled, so the end result was not nice).
Supporting select.(["*"]) or not sending a select
This one was indirectly needed by us, we are on at least one instance attempting to order by a virtual column that we are sending on the select. (And then selecting all other columns with *)
Ultimately the BEST approach would be to avoid adding the select when the virtual column (using the aliasing AS column_name) is already selecting it; but this feels complex as it requires interpreting the partial SQL on that subquery. At the very least this gives us a way forward.
If you have questions, objections, require us modifying, adding, or removing tests. Please let me know!
Refactoring into the Cursor class
So this one was again an important one for us. Our pagination right now works using a UUID column, regardless of which ordering column the FE requires.
We felt it redundant to introduce yet another attribute for our FE to handle, when the UUID already refers to a unique tuple of id / order field (by virtue of being part of a record).
As such - the compromise solution we came up with was - by extracting the encoding / decoding to a helper class; we were able to create our cursors on the BE based on the FE information given - rather than require the FE to send the cursor (which would require us exposing it, and the FE consuming and sending it back).
Thank you so much for your time reviewing

Hi @myxoh!
First of all: Thanks a lot for submitting this PR and for contributing back to the library 🎉
Regarding the pull request itself – I think it'd be great to have this split into separate PRs so that it can be reviewed more easily and we can discuss the pros and cons on a case-by-case basis. In general most of these changes make sense to me and I think they'd be a good addition to the gem. Also, it'd be great if you could add the things in the CHANGELOG.md under the [Unreleased] heading so we can then easily include it in the next version 😉
Thanks again and looking forward to adding this functionality!

Hey thanks for taking the time - I've broken down this into 4 MRs:
https://github.com/xing/rails_cursor_pagination/pull/72
https://github.com/xing/rails_cursor_pagination/pull/73
https://github.com/xing/rails_cursor_pagination/pull/74
https://github.com/xing/rails_cursor_pagination/pull/75
I do expect there'll be some conflicts to solve / if you are ready to merge one of them, if nothing else in the changelog - but happy to address when it comes to that

Closing this as new PRs have been opened


This does not work in go client

HI，
I made a sample according to the official website, but the task was received but not executed,code：
c := conductor.NewConductorWorker("http://<IP_ADDRESS>:8080/api", 1, 10000)

c.Start("test1", task.Create_Emr_Task, false)

func Create_Emr_Task(t *task.Task) (taskResult *task.TaskResult, err error) {
//...//
}
Console log：

The task was received but not executed，
Forgive me newbie

@zhou6675021 I see that you are using the go client for this purpose. The concept of acking a task has been deprecated and is no longer used. However, this change has not been propagated to the go client. Once a task is polled, it is expected that it will be executed by the worker and a response will be sent to the server within the responseTimeoutSeconds.
A very simple example to get started with using Conductor is available here. As seen here, the task is polled and a response is sent after with the execution result (ack is not sent).


Light Client: Evidence reporting

Closes #217

[x] Referenced an issue explaining the need for the change
[x] Updated all relevant documentation in docs
[x] Updated all code comments where relevant
[ ] Wrote tests
[ ] Updated CHANGES.md

what's left here? writing tests?

Documentation
Tests
Match the spec more closely (eg. maintain a list of full nodes that haven't been contacted)
Add tags to the code for traceability
Add contracts wherever possible

Could this be exercised by #331 perhaps?

Could this be exercised by #331 perhaps?

You mean the whole fork detector? I guess that would exercise part of it, yes but not the case where the header verifies successfully.

Codecov Report

Merging #336 into master will decrease coverage by 0.3%.
The diff coverage is 0.0%.

@@           Coverage Diff            @@
##           master    #336     +/-   ##
========================================
- Coverage    27.2%   26.8%   -0.4%
========================================
  Files         129     131      +2
  Lines        5040    5112     +72
  Branches     1541    1570     +29
========================================
  Hits         1375    1375
- Misses       2694    2766     +72
  Partials      971     971

Impacted Files
Coverage Δ

light-client/src/evidence.rs
0.0% <0.0%> (ø)

light-client/src/fork_detector.rs
0.0% <0.0%> (ø)

light-client/src/supervisor.rs
0.0% <0.0%> (ø)

rpc/src/client.rs
0.0% <0.0%> (ø)

rpc/src/endpoint/evidence.rs
0.0% <0.0%> (ø)

rpc/src/method.rs
0.0% <0.0%> (ø)

tendermint/src/evidence.rs
25.8% <0.0%> (-7.6%)
:arrow_down:

tendermint/src/abci/transaction/hash.rs
19.0% <0.0%> (-6.8%)
:arrow_down:

tendermint/src/vote.rs
33.9% <0.0%> (-2.0%)
:arrow_down:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be25579...072e1a3. Read the comment docs.