Add tests to custom makemessages command

This change adds a Python test for the v1 app's custom makemessages Django management command, which overrides the default one documented at
https://docs.djangoproject.com/en/1.11/ref/django-admin/#django-admin-makemessages
Our custom makemessages command adds support for block tags like this:
{% trans %}
Multi-line
statement
here
{% endtrans %}

which is not supported in Django templates.
This change also removes support in this command for Django 1.8 now that this project is solely targeted at Django 1.11.
Testing
To test this locally, you can verify that the unit test passes, and then remove our custom makemessages command (including the .pyc file if on Python 2). The built-in command will fail as it does not detect the multi-line Jinja2 tag.
Additionally, you can run through the makemessages workflow documented here to confirm that the command still works.
Checklist

[X] PR has an informative and human-readable title
[X] Changes are limited to a single goal (no scope creep)
[X] Code can be automatically merged (no conflicts)
[X] Code follows the standards laid out in the development playbook
[X] Passes all existing automated tests
[X] Any change in functionality is tested
[X] New functions are documented (with a description, list of inputs, and expected output)
[ ] Project documentation has been updated
[X] Reviewers requested with the Reviewers tool :arrow_right:

When I run tox -r -e fast I get an error on the makemessages test:
CommandError: Can't find msguniq. Make sure you have GNU gettext tools 0.15 or newer installed.

But I seem to have an up-to-date gettext installed (unless these are referring to different tools?):
> brew upgrade gettext
Error: gettext <IP_ADDRESS> already installed

@schbetsy quite honestly I can't remember, but I do have that brew link gettext --force way back in my bash history. This is my local version:
$ gettext --version
gettext (GNU gettext-runtime) <IP_ADDRESS>

Okay, after running brew link gettext --force, this now works for me. How would you feel about adding that to the documentation somewhere before we merge?
I get the feeling we'll get a lot of questions about it after we merge, since people won't be able to run the unit tests locally without doing that command. Should we do anything else to communicate the change?

Yep, I like that plan! And I think the documentation you proposed looks good.

@schbetsy I've updated the documentation and added logic to skip the translation test without gettext.

The documentation looks like this when rendered:

The tests will be skipped if you don't have gettext:
$ brew unlink gettext
$ tox -e fast v1.tests.management.commands.test_makemessages
s
----------------------------------------------------------------------
Ran 1 test in 0.000s

OK (skipped=1)

and pass if you do:
$ brew link --force gettext
$ tox -e fast v1.tests.management.commands.test_makemessages
.
----------------------------------------------------------------------
Ran 1 test in 0.092s

OK


Travis should preload simulator faster

Description
This shortens travis run time and fixes simulator timeout errors.
Notes
simulator bugfix
iOSSimulator: Timed out waiting 120 seconds for simulator to boot
I resolved this by shortening the simulator preload code to open -b 'com.apple.iphonesimulator' --args -CurrentDeviceUDID and by reordering the matrixes so that each simulator is only prelaunced once. This combination solved this issue.
faster build
It speeds up the build a bit. This was confirmed by daniel in #832.
How to test this PR
Here is an (example build) showing the error. You can also test this by checking if this update speeds up Travis builds.
Reviewers
If you've been tagged for review, please "Start a review" with the Github GUI.

[ ] Code review: @saeedbashir
[ ] Code review: @danialzahid94
[ ] Code review: @BenjiLee

Thanks for the pull request, @jaimeohm! I've created OSPR-1536 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.
Feel free to add as much of the following information to the ticket:

supporting documentation
edx-code email threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.
If you like, you can add yourself to the AUTHORS      file for this repo, though that isn't required.     Please see the CONTRIBUTING     file for more information.

Current coverage is 22.87% (diff: 100%)

Merging #839 into master will not change coverage

@@             master       #839   diff @@
==========================================
  Files           675        675
  Lines         56228      56228
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits          12862      12862
  Misses        43366      43366
  Partials          0          0

Powered by Codecov. Last update 449e9ff...c34d1da

May cause problems.


Restore older version(s) in jCenter

I understand that jCenter accidentally removed your uploads.  Could you please restore a few older versions in your jCenter?  For example we're using <IP_ADDRESS>, we can upgrade later but don't have the resources right now.
Thanks

Sorry, no, I don't keep old versions around.
Pre 0.7 versions shouldn't be used any ways though.

@afollestad even <IP_ADDRESS> is missing (which was still working with appcompat v21). Please don't delete old versions from jCenter

Same for me, CI warned me that most of my projects won't build anymore, and upgrading appcompat to 22 requires to fix the themes in all these projects, which would be quite a hassle.
Please reupload and keep atleast the latest version which still depends on appcompat v21, so we have compatibilty here.

I suffered same problem with @ishufuri. (the appcompat/theme issue).
So I fixed(?) this problems by finding aar file of older version in gradle cache directory.
In my case.
Gradle service directory path / caches/modules-2/files-2.1/com.afollestad/material-dialogs/<IP_ADDRESS>
if there's any cached build machine, may the cached library can be found.
Then, create new module (importing aar) and add dependency.

@ishufuri I didn't delete them, the entire library was removed from jCentee by accident.
You should be using the latest at all times though while the library is not yet at version 1.0.

@afollestad Well, that's bad news. In this case I'll have to update my stuff. Luckily it's just some bulk-editing of the style for most of the projects.
For anyone else having the error: AppCompat does not support the current theme features
Removing the android:windowActionBar field in the style and setting the style parent to a NoActionBar-variant has helped getting the project running again.

@ponz Can you please provide an .aar file?

I highly discourage using an old version like that. It's full of bugs and incompatibility issues with hundreds of devices and countless Android versions.
The current version is <IP_ADDRESS>.

And it's hosted on JitPack.io, not Bintray or that Maven service they partner with.


Fix jit memory leaks

Depends on #1022 (not a hard dependency; just the way the PR stack is)
Summary
This PR

fixes some memory leaks I discovered while running leak checking tools on JIT unit tests.
simplifies Node::replaceAllUsesWith

Manual refcount is dangerous, but I think it'll pay off for future optimization pass writers.
Test Plan (required)
Added unit tests, and ran them with leaks tool on MacOS.
make JitNodeTest JitTensorTest
./flashlight/fl/test/JitNodeTest
./flashlight/fl/test/JitTensorTest

Accidentally closed this... Reopen.


Run WMAgent validation for 2.2.0 production release candidate

Impact of the new feature
WMAgent
Is your feature request related to a problem? Please describe.
By-monthly task
Describe the solution you'd like
We need to release a new WMAgent stable version in April/2023, so this issue is meant to keep track of the full validation activity to be carried out in the first weeks of November, once we have a final 2.2.0 tag.
In addition to the validation results, WMAgent release notes and the validation check-list twiki need to be created as well.
Describe alternatives you've considered
none
Additional context
none

Given that we did not have a WMAgent release in this cycle, I decided to repurpose this ticket and move it to the next quarter as well.

Release <IP_ADDRESS> has been created and I am starting to deploy it in production (and the few testbed agents used by other groups). For agent release notes, please refer to: https://github.com/dmwm/WMCore/releases/tag/<IP_ADDRESS>
Developers are - as usual - invited to upgrade their dev/testbed agent to the latest stable release as well.
I am closing this one out.


Rename master branch -> main

This is a best practice for inclusive projects.
See https://github.com/github/renaming for guidance.

who will do that? S

the renaming on github and RTD should be done, I'll check the CI now.

once binder has been fixed we should be able to close this

as far as I can tell, binder works now but the environment is missing pooch. That's not related to the branch rename, though, so I'll close this.


Mesh generations: keeps only one hemisphere

The function mesh_utils.extract_mesh_from_mask call's vedo's mesh.extractLargestRegion() (here) after using marching cubes on a image stack to generate the mesh.
This is a problem for atlases with two hemispheres as brain regions which are not connected along the mid-line  will generate two large meshes and one will be excluded.  This has been fixed by others by selecting the two largest structures, but it remains to be implemented in the atlas generation code.

Going to close this as I assume it's been fixed, we haven't seen any issues generating atlases recently. We can reopen if needed.


strip trailing slash after server url in publish dialog

fixes #441

I could have sworn I reviewed and merged this already.
Anyway. Thank you!

I could have sworn I reviewed and merged this already.

https://github.com/binwiederhier/ntfy/pull/432


Modify search method to always return BatchMatches for batched inputs

In this pull request, I suggest modifying the search method in the Python binding to consistently return BatchMatches for batched inputs, irrespective of the batch size.
Currently, the return type depends on the batch size.  The search method returns a Matches value for a batch size of one, and BatchMatches for larger sizes. This requires extra steps to handle the results, like below:
matches = index.search(queries, ...)
if isinstance(matches, Matches):
    ...
elif isinstance(matches, BatchMatches):
    ...

This is not ideal for batch processing, particularly when the batch size varies. Instead, we should use the query vector's dimension (queries.dim in the example) to decide the return type. If the query vector is 2-dimensional, we can assume it's for batch processing.

:tada: This PR is included in version 2.9.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Current state of TinyLlama

A few ideas.

If at all feasible, I'd seriously consider releasing the 'faulty' 1.5T checkpoint and restarting the project from scratch. The first 0.5 trillion tokens were also trained with the wrong learning rate, so these missteps might compound and really hurt the quality of the final product. If you restart you can also apply all the tricks and tweaks you've learned thus far, and do so from the very start.

You could also continue on from 1.5T and save your funds for a v2 of TinyLlama or some other project. Given where you are right now, there shouldn't be that much of a difference between continuing on from 1.0T vs 1.5T.

Sorry if my suggestions are too intrusive or nonsensical. Regardless of which approach you take, best of luck with TinyLlama!

@tkforall Thanks for your thoughtful suggestions! We had some intense internal discussions and ideas similar to yours were raised. We eventually opted to roll back to the 1.0T checkpoint and continue due to our limited budget. We may plan to restart training from scratch when we have access to more compute in the future.
The faulty 1.5T checkpoint is released here.


Build main page for C core library Doxygen page

I introduced a placeholder landing page in #2551.
It's woeful. Let's start by deciding what we want there.

Can this be closed now that this http://www.grpc.io/grpc/core/ is being linked from our website grpc.io Reference section?


fix: set default value as undefined instead of null

graphql-migrations generates a slightly different abstract database when comparing the existing database to the schema. One sets defaultValue on columns to undefined, and the other uses null. Because of this it is repeating the same migration operations every time.
Verification
Run graphql-migrations on an already up to date database. The number of operations should be 0.

Looking into it


How can I run this app with my own classification network?

Hi.
I want to use your excellent unity-tensorflow classification app with my own classification network.
I simply make .pb file of my network and rename the file type with .byte
However, it doesn't work.
My question is did you test this application with another .pb file??
I think, only the "tensorflow_inception_graph.pb" from tensorflow repository works.

Hi, yes, I did check it with some other MobileNet models as well. There might be several reasons for you to have problems for your model, please check these issues to see if solutions can be applied to your case:
https://github.com/Syn-McJ/TFClassify-Unity/issues/5
https://github.com/Syn-McJ/TFClassify-Unity/issues/6
Let me know if it still doesn't work, I'll be glad to help.

Thanks a lot. I will try :)

Thank you and I fixed my previous error.
But now I have a new error like this.
I think it is because of size of input image.
Any recommendation please ? :)
IndexOutOfRangeException: Index was outside the bounds of the array.
TFClassify.Classifier.TransformInput (UnityEngine.Color32[] pic, System.Int32 width, System.Int32 height) (at Assets/Scripts/Classifier.cs:86)
TFClassify.Classifier+c__AnonStorey0.<>m__0 () (at Assets/Scripts/Classifier.cs:43)
System.Threading.Tasks.Task1[TResult].InnerInvoke () (at <c95265f74fdf4905bfb0d5a4b652216c>:0) System.Threading.Tasks.Task.Execute () (at <c95265f74fdf4905bfb0d5a4b652216c>:0) --- End of stack trace from previous location where exception was thrown --- System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () (at <c95265f74fdf4905bfb0d5a4b652216c>:0) System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) (at <c95265f74fdf4905bfb0d5a4b652216c>:0) System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) (at <c95265f74fdf4905bfb0d5a4b652216c>:0) System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) (at <c95265f74fdf4905bfb0d5a4b652216c>:0) System.Runtime.CompilerServices.TaskAwaiter1[TResult].GetResult () (at :0)
PhoneCamera+c__async0.MoveNext () (at Assets/Scripts/PhoneCamera.cs:112)
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () (at :0)
System.Runtime.CompilerServices.AsyncMethodBuilderCore+<>c.b__6_0 (System.Object state) (at :0)
UnityEngine.UnitySynchronizationContext+WorkRequest.Invoke () (at C:/buildslave/unity/build/Runtime/Export/UnitySynchronizationContext.cs:92)
UnityEngine.UnitySynchronizationContext.Exec () (at C:/buildslave/unity/build/Runtime/Export/UnitySynchronizationContext.cs:53)
UnityEngine.UnitySynchronizationContext.ExecuteTasks () (at C:/buildslave/unity/build/Runtime/Export/UnitySynchronizationContext.cs:74)

Is your problem resolved? I will close this issue if so.


Duplicate Entries & Missing Volumes

A) There are duplicate entries when downloading prices using yf.download. This seems to be a perennial issue and happen almost every day (for many tickers). The below code is retrieved for Dr.Reddy and HindPetro where there is a duplicate entries on 2021-07-09.
yf.download('DRREDDY.NS', period='5d', progress=False)
                   Open         High          Low        Close    Adj Close    Volume
Date
2021-07-05  5576.200195  5596.000000  5531.950195  5537.899902  5512.574707  297341.0
2021-07-06  5539.799805  5561.200195  5514.000000  5539.450195  5514.117676  178108.0
2021-07-07  5529.000000  5614.600098  5515.049805  5562.100098  5536.664062  538508.0
2021-07-08  5540.000000  5588.000000  5449.600098  5466.750000  5441.750000  451167.0
2021-07-09          NaN          NaN          NaN          NaN          NaN       NaN
2021-07-09  5448.000000  5520.250000  5416.950195  5460.299805  5460.299805  460617.0

>>> yf.download('HINDPETRO.NS', period='5d', progress=False)
                  Open        High         Low       Close   Adj Close     Volume
Date
2021-07-05  301.399994  305.799988  298.500000  304.450012  259.252106  4835974.0
2021-07-06  306.500000  309.450012  303.200012  304.549988  259.337250  6501684.0
2021-07-07  306.250000  307.100006  299.500000  306.350006  260.870026  6552189.0
2021-07-08  285.000000  289.399994  283.049988  283.850006  261.100006  9236777.0
2021-07-09         NaN         NaN         NaN         NaN         NaN        NaN
2021-07-09  284.100006  285.000000  278.049988  278.950012  278.950012  2925669.0

How do we fix this? Are there any permanent fix?
B) The volumes for indices are backfilled and not printed point-in-time. In few instance, it is sparse. For example for ^NSEI the volumes were 0 for 2021-07-09, but these are getting backfilled after 2/3 days. And, for ^NSEBANK, it is sparse. How do we address this inconsistency?
>>> yf.download('^NSEI', period='5d', progress=False)
                    Open          High           Low         Close     Adj Close  Volume
Date
2021-07-05  15793.400391  15845.950195  15762.049805  15834.349609  15834.349609  207000
2021-07-06  15813.750000  15914.200195  15801.000000  15818.250000  15818.250000  391400
2021-07-07  15819.599609  15893.549805  15779.700195  15879.650391  15879.650391  329300
2021-07-08  15855.400391  15885.750000  15682.900391  15727.900391  15727.900391  307900
2021-07-09  15688.250000  15730.849609  15632.750000  15689.799805  15689.799805       0

>>> yf.download('^NSEBANK', period='10d', progress=False)
                    Open          High           Low         Close     Adj Close  Volume
Date
2021-06-28  35488.199219  35576.949219  35236.449219  35359.449219  35359.449219       0
2021-06-29  35320.449219  35337.449219  34913.699219  35010.300781  35010.300781       0
2021-06-30  35001.898438  35214.898438  34730.449219  34772.199219  34772.199219       0
2021-07-01  34866.000000  34917.648438  34650.949219  34684.000000  34684.000000  164000
2021-07-02  34728.101562  34894.449219  34632.601562  34809.898438  34809.898438  165600
2021-07-05  35010.949219  35234.300781  34926.398438  35212.000000  35212.000000       0
2021-07-06  35173.601562  35807.449219  35165.550781  35579.148438  35579.148438       0
2021-07-07  35550.601562  35795.750000  35427.648438  35771.300781  35771.300781       0
2021-07-08  35603.250000  35811.000000  35134.648438  35274.101562  35274.101562       0
2021-07-09  35163.750000  35225.199219  34859.898438  35071.949219  35071.949219       0

Please let me know if this still happens with ver 0.1.63

Still, this problem persists as I tried to load at interval ='1m', Period='1d' for 'EURUSD=x' and end up getting just 32 rows. However, this one should load at least above 900rows.
Version:yfinance 0.1.63
Fix it soon.

Please let me know if this still happens with ver 0.1.63

Hi @ranaroussi the duplicate entries (NaN) issue seems fixed. Thanks!
However, the backfilling of volumes for ^NSEI and missing volumes for NSEBANK still continues. Refer below where Friday volumes are backfilled on Monday.
>>> yf.download('^NSEI', period='5d', progress=False)
Open	High	Low	Close	Adj Close	Volume
Date
2021-07-06	15813.750000	15914.200195	15801.000000	15818.250000	15818.250000	391400
2021-07-07	15819.599609	15893.549805	15779.700195	15879.650391	15879.650391	329300
2021-07-08	15855.400391	15885.750000	15682.900391	15727.900391	15727.900391	307900
2021-07-09	15688.250000	15730.849609	15632.750000	15689.799805	15689.799805	243200
2021-07-12	15766.799805	15789.200195	15644.750000	15692.599609	15692.599609	0

Can we have a solution to this volume backfilling issue?

Duplicate date entries issue fixed.
I can't think of any solution to the volume "backfilling" because this is problem in Yahoo's data, and all interval sizes are affected.

Is the backfilling still occurring?


Fs 1163 test domains

Added route for custom domain in test

If the last commit was just for testing we could rewrite it in the history by doing git rebase -i main and dropping it then force pushing, or do a squash and merge so it's not included in the git history.


Create a quicker way to make tags

A few players mentioned that in a day-game with such frequent tags, it was a lot of back-and-forth going to the bot DM for every one. I dunno if it's possible, but it would be cool to have something like a quick-tag command that just takes the tagged player's code and assumes the tagger to be the player entering the command and the time to be "now", like
/qtag |ABC123|
"'OtherUser' has turned zombie!
Tagged by ThisUser at about 07:34 PM"
Could we use modals for this?
FYI, you can't send a modal as the response to a modal. So no chaining modals for error handling.

Feature added in #79
Modal chatbots added


Doctor check for libimobiledevice/Xcode compatibility

libimobiledevice 1.2.0 is incompatible with Xcode >= 8.0. Since the
libimobiledevice tools don't include a --version flag, check for valid
exit code on running idevicename, if an iOS device is connected.

@chinmaygarde @danrubel
This attempts to detect with Xcode 8 + libimobiledevice 1.2.0 (current). See #5937 for more info.
I don't like this much; if you've got ideas on a better solution, I'd like to hear them. In particular, I'm not keen on suggesting an install from head, but not sure what better alternatives we've got. One option might be to deploy compatible versions in the cache, though I'm not sure what implications there might be around licensing, etc.

Alright; filed #6118 to follow up on whether or not it's reasonable to move off libimobiledevice. Landing this in the meantime.


Create Linux installers for the aspnetcore targeting pack

Resolves https://github.com/aspnet/AspNetCore/issues/6501
This creates 3 new build outputs:

aspnetcore-targeting-pack-$(version).tar.gz
aspnetcore-targeting-pack-$(version)-linux-x64.deb
aspnetcore-targeting-pack-$(version)-linux-x64.rpm

Other changes:

Make RPM packaging consistent with other installers. Vendor == Microsoft Corporation (cc @Eilon)
Add shared properties for building the targeting pack (or not building it in a servicing build)

cc @dagood @nguerrera @dsplaisted

@Eilon - are we in 'ask mode' for preview3? I've retargeted this PR to release/3.0-preview3 b/c I believe this is required to complete the SDK's RPM/DEB story for Preview 3

I believe this is required to complete the SDK's RPM/DEB story for Preview 3

We don't have Linux or MacOS installers for the .NET Core targeting pack for preview 3, and it's not in progress yet for 4. I have been working with the understanding that there isn't anything blocked on these until 3.1 comes along--similar to the targeting pack bundle Windows installers (nice EXE installers wrapping the MSIs).
@nguerrera @dsplaisted can you help clear this up?

@dagood @natemcmaster  No need to rush to get these installers for Preview 3 at this point.  We do need them for 3.0, and would like them for preview 4.
The reason we need these is that the SDK package needs to depend on them, which is analogous to bundling the MSIs in the Windows installer.

Ok, thanks for clarification. I've retargeted this PR to master (preview4) since we missed the cutoff for P3.

Many of the renamed files are losing their exec bit.

Intentional for some of the files, like the plaintext ones. I've restored +x permissions on .py and .bats files.
Changes to existing rpm/deb code was done to share common targets/props between multiple .deb and .rpm projects. They mostly build the same way -- take a folder of stuff and put it in a package, but with slightly different names and dependencies.
Still investigating why build fails on CI but passes locally. Added more binlog output so I can investigate

:up: :date: figure out the problem was that AspNeCore.App.Ref.csproj was not getting built. IsPackable was set to 'false' due to new conventions about ref/ folders (cc @pakrym ) CI builds are looking good now.


Add success dot if your code is ok

See: https://github.com/AtomLinter/Linter/issues/412

@hd-deman Can you review this PR? I'm don't know the view layer of Linter.


#695 | Output Text After Speech Services Unavailable

closes #695
Description of Work
The output text at the top of the screen will now reset to the default "Select something below to speak" when navigating back to the app after disabling Dictation or Siri.

Test verified.
iPhone 12 Pro Max, iOS 15.0.2


No images in Model\Product

Please add getImages() method in Product model. Images are avaiable in API.

Unfortunately we don't have plans to develop this PHP client.
We recommend to fork from our repository and extend it in your own.


Errors while saving single-file

Edit: This is for 2.1.1-beta
Making a change to a tiddler on a single file doesn't change the "saved" checkmark, though it appears that it is saving. But making a second change, I get
Error while saving:
XMLHttpRequest error code: 0
and
XMLHttpRequest error code: 412
Errors.

What server logs show up for this one?

The first time you create a tiddler, there's nothing remarkable in the log. The checkmark stays red. Nothing appears to be saving. The 2nd time you create a tiddler, there's something about etags...

[2019-04-19T20:15:39.796-0700] GET     <IP_ADDRESS>       200 <IP_ADDRESS> /Wikis/note
s/notes.html                                     245.136 ms - 3816451
[2019-04-19T20:15:40.008-0700] OPTIONS <IP_ADDRESS>       200 <IP_ADDRESS> /Wikis/note
s/notes.html                                     14.869 ms - 20
[2019-04-19T20:15:40.011-0700] HEAD    <IP_ADDRESS>       304 <IP_ADDRESS> /Wikis/note
s/notes.html                                     15.308 ms - -
[2019-04-19T20:15:40.494-0700] GET                     - <IP_ADDRESS> /Wikis/notes/
favicon.ico                                    - ms - -
412 ifmatch "0-3816451-1555644827000"
412 etag "0-3816602-1555644827000"
412 caused by difference in size
[2019-04-19T20:17:24.897-0700] PUT     <IP_ADDRESS>       412 <IP_ADDRESS> /Wikis/note
s/notes.html                                     48.716 ms - -

I should have mentioned -- this is 2.1.1-beta.

For some reason the file size changed while the file was being edited. Each time it saves it records the file size in an etag and sends it back to the browser. The browser sends the last etag on every save, and if the file size on disk has changed since the last save, the server rejects the browser's save request. This is to prevent edits from overwriting each other, such as when you are working on two computers at the same time. Single file wikis are saved per-wiki, not per-tiddler, so adding a new tiddler on one computer, and then adding a new tiddler on a second computer without first reloading the page to load the first tiddler would actually cause the first tiddler to be lost.

But the error happens every time I run with 2.1.1-beta. It doesn't happen at all if I run with the old version (sorry, I don't know what version it is -- is there a way to tell? It was installed in July 2018.)

I will check this out. I don't know why, but your log indicates the file size is different, which should not be happening. Can you verify that this behavior happens with an empty wiki from this link: https://tiddlywiki.com/empty.html (right click and save as to download).

Yes, it happens with an empty. I will add, in the interest of full-disclosure, that I'm running on top of a drive mapped by cryptomator. However, the save works fine when running the old TS (sometime in July 2018), so it it's not about the file system. So, unless the file check thing is new? Maybe the old TS didn't do the check so wouldn't notice a change?

Ok, I tested on the native file system (windows NTFS) and the same error occurs. So it's something in the new beta.

Hi Arlen22
i have the same problem. it seems, that after a change, the new file is writting but the browser not reload the new wiki.
If i make a change and press the reload button every time after this, is there no error.
Without a reload after changes, the error is every time.
Tested with firefox 67 and Chrome and new empty.htm.
I stand by for testing ;)

Log:
Open your browser and type in one of the following:
http://<IP_ADDRESS>:8080
[]
[2019-05-08T10:19:29.821+-200] GET     <IP_ADDRESS>       200 <IP_ADDRESS> /                                                           11.247 ms - 9205
[2019-05-08T10:19:29.849+-200] GET     <IP_ADDRESS>       304 <IP_ADDRESS> /directory.css                                              2.173 ms - -
[2019-05-08T10:19:29.850+-200] GET     <IP_ADDRESS>       304 <IP_ADDRESS> /assets/icons/files/htmlfile.png                            0.779 ms - -
[2019-05-08T10:19:29.851+-200] GET     <IP_ADDRESS>       304 <IP_ADDRESS> /assets/icons/folder.png                                    0.649 ms - -
[]
[2019-05-08T10:19:34.062+-200] GET     <IP_ADDRESS>       200 <IP_ADDRESS> /empty.html                                                 4.136 ms - 2168427
[]
[2019-05-08T10:19:34.208+-200] OPTIONS <IP_ADDRESS>       200 <IP_ADDRESS> /empty.html                                                 0.991 ms - 20
[]
[2019-05-08T10:19:34.210+-200] HEAD    <IP_ADDRESS>       304 <IP_ADDRESS> /empty.html                                                 0.927 ms - -
[]
[]
412 ifmatch "9699806-2168427-1557303462000"
412 etag "9699806-2170295-1557303591000"
412 caused by difference in size
412 caused by difference in modified
[2019-05-08T10:20:09.225+-200] PUT     <IP_ADDRESS>       412 <IP_ADDRESS> /empty.html                                                 0.846 ms - -
[2019-05-08T10:20:14.619+-200] PUT                     - <IP_ADDRESS> /empty.html                                                 - ms - -
[]
[2019-05-08T10:20:14.628+-200] GET     <IP_ADDRESS>       200 <IP_ADDRESS> /empty.html                                                 2.142 ms - 2170295
[]
[2019-05-08T10:20:14.771+-200] OPTIONS <IP_ADDRESS>       200 <IP_ADDRESS> /empty.html                                                 0.688 ms - 20
[]
[2019-05-08T10:20:14.772+-200] HEAD    <IP_ADDRESS>       304 <IP_ADDRESS> /empty.html

There is a difference in the file size, not just the date modified. I don’t know what would be causing this. Perhaps I’ll have to make a custom diff mode that highlights the differences in a file when there is an Etag error.
Sent with GitHawk

Yes, but i think the difference at file and date is correct because i change tiddler.
I think the problem is , that the file on disk is different the file inside the browser because after a change in a tiddler the TW was automatically saved, but the browser do not noticed this change.

But as long as there is only one browser tab open and it is only open on
one computer, then the browser is supposed to be made aware of the new file
size after it saves its changes. I will check into this and make sure that
this is not a bug in TiddlyServer somehow.
Can you tell me what version of TiddlyWiki the files are using?
On Thu, May 23, 2019 at 3:29 PM MaruKob<EMAIL_ADDRESS>wrote:

Yes, but i think the difference at file and date is correct because i
change tiddler.
I think the problem is , that the file on disk is different the file
inside the browser because after a change in a tiddler the TW was
automatically saved, but the browser do not noticed this change.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Arlen22/TiddlyServer/issues/59?email_source=notifications&email_token=AADLMQEMNES4PESIN5KBQRLPWZBUDA5CNFSM4HHBTXIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWBKJUY#issuecomment-495101139,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADLMQALBHYYF7ICJWK4VBLPWZBUDANCNFSM4HHBTXIA
.

Versions:
First
Tiddlyserver: v2.1.1-beta
TW: 5.1.19 and 5.1.14
Firefox: 66.0.5 (64-Bit)

So if i do a change at Tiddler and close the Tiddler, the TW was correctly saved on disk, i tested.
The "Save-Button" stays on red.
If you now change any or same Tiddler the error came on close or if you hit the "save-Button"
If you reload (with a message of unwritten changes) all is fine to the next change.
I hope you understand my bad english

Yes, I understand. TW 5.1.14 has a bug that must be fixed for each wiki, but 5.1.19 is supposed to work correctly. I will keep this open and investigate it.

Error-msg:
XMLHttpRequest Fehler-Code: 412
and after click okay
Intern Javasript error
TypeError: xhr is undefined

How i fix the bug?
Click on "Fix Put Saver Bookmarklet" and then import "updated Put Saver " ??
I do that, but it doesnt change anything

That is for the bug in 5.1.14. This seems to be a different problem that you are experiencing now.

Yes, i use the 5.1.14 too, so i fixed ist and testet again but it has no effect to the error

I have the same error. When I modify a tiddler that existed before, it can overwrite the file but the browser do not recognize it. When I create a new tiddler I get the error XMLHttpRequest error code: 0
I am using TiddlyServer-2.1, tiddlywiki 5.1.19 and chrome. I am new to tiddlywiki but I really want it start with tiddlyserver.

Ok, I think I found the problem. I pushed a fix to v2.1 branch. Please let me know if it works now. You can download the files as a zip file from the Github repo page.

I did some tests and it is perfect.

same here
thank you so much :D :D :D
The Problem withe the "Save Button" is still alive, but not a problem for me now
best regards

The save button problem is not related to TiddlyServer on single-file wikis. You can investigate it further on the TiddlyWiki user groups if you like.

Which release or pre-release are we supposed to use? None of them seem to have an appropriate date stamp. Or just use the whole branch? Thanks!

Just use branch v2.1 @ latest. v2.1 is the current master branch but I have
it named like this to keep it separate.
On Sat, Jun 1, 2019 at 9:33 PM Marxsal<EMAIL_ADDRESS>wrote:

Which release or pre-release are we supposed to use? None of them seem to
have an appropriate date stamp. Or just use the whole branch? Thanks!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/Arlen22/TiddlyServer/issues/59?email_source=notifications&email_token=AADLMQF4T344INTD3UR2FM3PYJ3BDA5CNFSM4HHBTXIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWXAYAQ#issuecomment-497945602,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADLMQFFRVLJQFM4PM4XDL3PYJ3BDANCNFSM4HHBTXIA
.


how to force all response sounds that use  Uridecodebin in UrlSource?

IMPORTANT: Before you create an issue, please take a look at our Issue Reporting Guide.
Briefly summarize your issue:

detain issu in https://github.com/alexa/avs-device-sdk/issues/406
when response sound use decodebin  by BaseStreamSource , my arm embedd system can't play it sound but the player's progress seem has been running
What is the expected behavior?

the response sound of BaseStreamSource that should be played
What behavior are you observing?

the response sound of BaseStreamSource can't play sound
Provide the steps to reproduce the issue, if applicable:

TZ=UTC ./SampleApp ../../Integration/AlexaClientSDKConfig.json
Tell us about your environment:
NXP in yocto

What version of the AVS Device SDK are you using?
AVS  Device SDK <1.2.0>
Tell us what hardware you're using:

[ ] Desktop / Laptop
[ ] Raspberry Pi
[V ] Other - NXP in yocto

Tell us about your OS (Type & version):

[ ] Linux
[ ] MacOS
[ ] Raspbian Stretch
[ ] Raspbian Jessy
[ V] Other - NXP in yocto

can you try SDK 1.3 if it works for you?

Ok, the issue is not my now issue.Thank

if it is resolved, please close the ticket.


Checkbox resets value field to 1 if using a chunk

I was trying to use check boxes to insert social media icons on a website. (i.e. Show Facebook Icon, Show Twitter Icon, etc). Upon initial setup everything seemed to work fine and displayed on the website as it should, but as soon as I unchecked one of the boxes it reset the value of all check box fields to "1" instead of the chunk name previously in there.
In case it matters, the chunks themselves also had ClientConfig placeholders for the social media URL and name of the link. So the end users ultimately had the options to define the link name, the link url, and a check box to show or not show it on the site.

Hmm @pixelstuff I'm not sure I 100% follow how you had this set up, would you mind sharing your configuration for that field?

Closing due to insufficient information bug.

In CC i made a setting [[++Mysetting]] , set it to checkbox and gave it a value ‘MyValue’.
Now save the configuration and go to client view check my new setting. Now the value ‘MyValue’ appears on the page… Great. Now i unchecked the chekbox and the value ‘MyValue’ is not on the page anymore Still… great.
But when i now check the checkbox again there is the value ‘1’ on the page instead of ‘MyValue’ ???
 I'm inclined to say it should never return "MyValue", only 1 or empty.

that may be so, but the what is the field 'value' for then? and it DOES give that value the first time it is set.

The value holds the (wait for it! :P) value of that field. With multi contexts enabled, the per-context value is stored in a separate table, but the value on the field is what's used for the global mode.
When you uncheck it, the value is set to empty/0. When you check it again, the value is set to 1.
I'd consider it's a bug that the checkbox type allows you to set a non-boolean value (or a value at all, really). The ability to define a value to use instead of 1 would be a separate feature request.

Actualy the same as with a TV. A TV that has input type checkbox returns the set value for that TV not the mere fact its checked or not in in some boolean fashion. :)

If you feel so strongly about it, feel free to open a pull request or at the very least a separate feature request.


Fix accidental dedent for in and when dedent in Ruby comments

I was testing the changes from https://github.com/microsoft/vscode/pull/205397 in Insiders and I noticed that the code was incorrectly being dedented when typing in or when in comments.
We got the parenthesis balance incorrect in the regex. The regex has three outer groups for an or condition and we closed the group incorrectly, which made the last part of the regex skip the \s* part (which verifies that only blank spaces are in the front of the string).
This PR fixes the bug by properly balancing the parenthesis. The tests was also missing the ^ anchor, which I added to match the language configuration.
cc @rebornix

@vinistock thanks for the quick fix! Does it only affect comments? We are in endgame mode so I'm trying to understand if it's worth a candidate or if we should pull back the previous change and merge together with this one.

@rebornix because of the unbalanced parenthesis, it ignores the \s* part, meaning it matches any in|when words - not just comments. Even if you start writing a method call like within and put a space, it will incorrectly dedent.
I don't know what the endgame policies are, but in my opinion it's definitely worth either pulling back the previous change or including this one.


README.md is not showing up in Crates.io

Hey! So I was on your Crates.io page and noticed that there was no README.md! Furthermore, I went over to your GitHub page for this crate and saw that there was indeed a README.md. I am including a screenshot of what I see.

Hi :) Thanks for letting me know but that is quite intentional since that crate (dyncast-impl) is an implementation detail of the main crate (i.e. it is not intended for direct use).


Ff 0721 a

Description of the change(s):

Merge main into 2.0

Why do we need this PR:

Issue reference:

Test API/Unit - Success

/lgtm


Add a login/registration system

To get set up for the application to allow data entry and maintenance of organizations and jobs, we need to allow users to register and login (anonymous users will still be able to search read-only information about jobs and organizations).  They will need to provide an email as a username and a password, stored in the postgres database in a logins table.  There needs to be two kinds of registered users. System administrators will be able to enter/edit all organizations and jobs.  Organization Representatives will only be able to enter/edit their own organization(s) and the associated jobs. I guess an organization rep might be assocated with more than one organization.
Once all this is set up, then we can lock down the Organization and Job create/edit forms so that only authorized users can see and run them.

all done (mostly) :)


feat: Apply character relic sets to the relic tab filter bar

Pull Request

Description

Added 'Select relics' button to RelicsTab. This button filters relics based on the Recommended Character's relic and ornament sets as defined in the Character Optimizer tab.

Related Issue

https://github.com/fribbels/hsr-optimizer/issues/476

Checklist

[X] I have added commit messages that are descriptive and meaningful.
[X] I have tested the changes locally.
[X] I have reviewed the code changes.

Screenshots

Implemented @FI00ds change.

I'm not sure I agree with pulling relics based on the optimizer page, most of the characters are just going to be empty sets since people tend to not choose set filters - This kinda overlaps with: https://github.com/fribbels/hsr-optimizer/issues/247
The ideal workflow should be that we predefine a set of [high / med / low] value relics sets per character and let the user choose a preset that way. The difficulty is just creating and maintaining that relic mapping across 60 characters x 40 sets


Allow people to choose between two wheeled and three wheeled robots

Add a button or dropdown that allows students to choose between a two wheeled or three wheeled robot.
Selecting a different robot should update the robot in the simulator immediately.

Pull request created with this feature in mvp-positions


How to retrieve response?

I made a ajax-form wiath a Polymer paper input, the request works and i can see that i got the response in my dev-tools, is there any way to retrieve that data and use it ?

Yes.  See the documentation for the submitted event, which includes the XMLHttpRequest instance used to send the request on the detail property of the event.


STORM-2385: pacemaker_state_factory.clj does not compile on branch-1.0.x

Code cherry-picked onto this branch in PR #1953 broke this.
1.0.x-branch does not have Pacemaker-HA.

+1

+1

+1

+1


Can’t find ‘3dgs-avatar-release/submodules/simple-knn’

Can’t find ‘3dgs-avatar-release/submodules/simple-knn’

Hi,
Did you clone the submodule also by running git submodule update --init --recursive?

I ran the command, the problem is that the link (submodules/simple-knn) in your code seems to be disabled.

I checked the command and it works on my machine. The code repository is on gitlab so you can't open it directly on github, but it should work with git submodule update

I understand, thanks for your reply.


nunjucks 在解析markdown中的数学公式时有意外表现

When I write a math equation in my markdown file like following
Indicator Function, $I_{\{0<x<1\}}$

It is expected to be shown as

But after hexo-renderer-nunjucks process it become
Indicator Function, $I_{{0<x<1}}$

then it will renderer by latex engine like

which missing {}.
Plugin behave differently from the standard. So it may be considered to process latex equation in $...$ or $$...$ specially.

You can add a space between {{, or
See https://github.com/hexojs/hexo/pull/4518

thank you very much.  I also solved the problem well by using the markdown renderer hexo-renderer-pandoc  replacing hexo-renderer-marked.


Refused to set unsafe header "Host"

This project relies extensively on requests to nginx-proxy having the Host header set. Does this mean it's not possible to access the server from a browser???
Nearly every browser does not allow you to manually set the Host header. If you try, you will get the error Refused to set unsafe header "Host"

A resolution was reached here


Fixes to gauge scaling

Change to use a half scale PWM value
Updated to the config for the new scaling method.

Fixes to gauge scaling

Change to use a half scale PWM value
Updated to the config for the new scaling method.


gl calls failing with malloc errors

glGetShaderInfoLog and glGetProgramInfoLog were giving me the error "malloc: no size given".
I've traced the issue to problems in gl.spec.FIXED. Here is an example of a bad spec. The "infoLog" param specifies "length" when it should be using "bufSize":
...
GetShaderInfoLog(shader, bufSize, length, infoLog)
return		void
param		shader		UInt32 in value
param		bufSize		SizeI in value
param		length		SizeI out array [1]
param		infoLog		Char out array [length]
category	VERSION_2_0
dlflags		notlistable
version		2.0
extension
glxsingle	?
glxflags	ignore
offset		?
...
There are several other functions with similar problems.

Hi,
I know the specfiles are very buggy.
This is quite frustrating. Stuff which isn't checked by a C compiler (such as array bounds)
is often broken. Bug reports to Khronos on this appear to be redirected to /dev/null .
Anyway, do you happen to have a fixed verison which I could pull?
Thanks,
Stephan

Thank you for the prompt response! It's too bad Khronos doesn't seem
to care. I'd love to help work on OpenGL bindings for Racket. I've
already tried sgl and sgl/gl but they're missing shader functions, so
I came here. Perhaps once this is working and tested it can replace
sgl/gl in the main distribution?
So here's what happened. I started going through gl.spec.FIXED looking
for instances of "out array" and fixing them, then I remembered a
strange behavior I had writing my program and realized this is gonna
be a lot hairier than I thought. glGet* functions are typically
supposed to write a value at the pointer passed to them. I'm pretty
sure these should be pointers to a single value, but the spec gives
them types such as:
Int32 out array [COMPSIZE(pname)]
It seems that this specifies an array with a length of the value of
an enumerator. That explains the strange behavior I had, where I got
a vector of 30000-something with the desired value in the first
element when calling one of these functions. I'd love to fix this too
while I'm at it, only I don't know what COMPSIZE does and it might be
important because it's used in a lot of suspicious places. Do you know
what it is? And what does it mean when its arguments are separated
with a slash, as in:
param    pixels    Void in array [COMPSIZE(format/type/width/height/depth)]

Hi sf17k,
On 02/21/2012 06:53 PM, sf17k wrote:

So here's what happened. I started going through gl.spec.FIXED looking
for instances of "out array" and fixing them, then I remembered a
strange behavior I had writing my program and realized this is gonna
be a lot hairier than I thought. glGet* functions are typically
supposed to write a value at the pointer passed to them. I'm pretty
sure these should be pointers to a single value, but the spec gives
them types such as:
Int32 out array [COMPSIZE(pname)]

This means it is an output array (i.e. filled by the GL function) of Int32's
and that the length is somehow dependent on the parameter "pname".
For the glGet* family of functions the actual size of the vector is listed
in specfiles/enum.spec for each enum. During parsing of the specfiles a
hash table pname-map is constructed which maps each enum to the associated
vector size, so that the Racket binding can directly allocate and return a vector
of the correct size.
Unfortunately it seems that not all possible glGet values have an appropriate
vector length declared (especially the more recent ones).
Are you running into one which is missing in particular?

It seems that this specifies an array with a length of the value of
an enumerator. That explains the strange behavior I had, where I got
a vector of 30000-something with the desired value in the first
element when calling one of these functions. I'd love to fix this too
while I'm at it, only I don't know what COMPSIZE does and it might be
important because it's used in a lot of suspicious places. Do you know
what it is? And what does it mean when its arguments are separated
with a slash, as in:
param    pixels    Void in array [COMPSIZE(format/type/width/height/depth)]

So in general COMPSIZE simply means "the size is computed somehow from
the following arguments". It doesn't specify how.
The readspec.rkt understand only the special case "COMPSIZE(pname)" which translates
into a lookup of pname-map as explained above.
The issue you are running into might be that in certain cases the spec contains simply
"pname" where apparently "COMPSIZE(pname)" was intended.
Unfortunately replacing these with COMPSIZE(pname) might not be so useful since it appears
that for these functions, the appropriate enums are also missing a size annotation.
The best solution is probably the following:
I replace all occurrences of [pname] with [*], which is not a valid length expression for readspec.rkt .
Then readspec.rkt will generate bindings which require an explicit vector to be passed in
(of the correct length, as determined from the docs) which is less convenient but
has the distinct advantage that it can be actually made to work.
--
Stephan Houben

The issue you are running into might be that in certain cases the spec contains simply "pname" where apparently "COMPSIZE(pname)" was intended.

Ah, you're right. That's exactly the case with the functions I tried, glGetShaderiv and glGetProgramiv. My mistake not noticing at first.


[문서 번역] README.md

README.md 초안

@iChenLei I will discuss with my team member and tag you again when it's okay to Merge!

@iChenLei please merge


Create the Inventory System

Create and implement an inventory system with UI. The player will be able to hide/unhide the inventory and will be able to pick up items to take them to the npc's he needs. The following scripts will be needed:

[x] Inventory: Manages the items that the player has
[x] Inventory Slot: Used to change the sprite on every slot
[x] Inventory UI: Manages the changes on Inventory Slot script
[x] Item: Script for items
[x] ItemPickUp: used to pick up items, comes from Interactable.cs

EXPECTED RESULT:
Name.cs files on Scripts folder and working properly

This issue was completed on the following commit: 33efdfce65eebf25be24498bdcceea625d82dba2


Replacing the IGGIELNG_LNG data with Europe-Gas-Tracker

yes that would be good

Thanks @fneum for merging 'master' into the branch. I still had some code that needs to be ammend before its done. mainly to do with the missunderstanding snakemake has with HTTP links. Will be done tomorrow

Before/after looks good!

Ah, sorry @virio-andreyana! I thought you were already done. I am currently doing a release and wanted to include this PR. I just pushed some cosmetic changes, but it already looks very good and can be included in the upcoming release.
Have a look at https://github.com/PyPSA/pypsa-eur-sec/pull/289/commits/ece64a73c130577dbd90fc0e817cf083ac108376 what I changed.

I think you accidentally removed the retrieve_gas_infrastructure_data rule
The retrieve_gas_input_locations was no longer needed.
Use of Snakemake's HTTP.remote over direct pandas URL interface. In this way, snakemake can also run offline once downloaded.
Renamed the conversion factors from MCM/d and Mtpa.

Thanks @fneum!


Added Jaxa yaml

added chla and tsm for Jaxa datasets
Please check if I commited only Jaxa or the entire Fork...not sure what's happened, but if you find folders in Capital letters maybe I commited the all the FORK...

Hi @AlessandroScremin ,
Which software are you using for creating the .yaml files? VSCode for example is having a handy yaml language support package that checks your files automatically and highlights errors.
Cheers, Max


Update caveats section

See #481

I propose to remove the to be transparent... sentence in the icomplete section - keep the caveats only at one place. Why not link in the caveats section to the issue #481, then we can dynamically track this?


Bring on par with core

Fixes #152
Checklist

[x] My branch is up-to-date with upstream/develop branch.
[x] Everything works and tested for Python 3.5.2 and above.

Description

This PR enables the agent to adapt to latest changes in core and hydrus.
Change logs

To make reviewing easier I am attaching the snapshot of the redis graph.


feat: allow script sort for run-p

Re-submission of #240
CC/ @keithamus @fisker

@fisker I don't think the Node 12 is about something I've done in this PR, so this one can be merged if everything seems fine to you?

So, you really think my suggestion should only apply to just one?

The node failures we can look into. We may need to drop node 12 support shortly.

So, you really think my suggestion should only apply to just one of the patterns?

@fisker Oh I thought it was meant to only have it on one of the regexes.
Since I'm not that good with regexes, can you please create a change request for the others as well?

The node failures we can look into. We may need to drop node 12 support shortly.

@keithamus The problems with Node v12 CI is because we're always updating to latest npm version, which is v9 & is not supporting Node 12 anymore.
If we remove the "always update to latest version" step, Node 12 is perfectly supported & CI will pass

If you could please rebase, I've dropped that step in CI.

@keithamus CI is passing on Node 12 now 👍

I need more time, but I have to go outside now, will be back in few hours.

except the one's mentioned by run-s/-s/--sequential?

Good, but maybe hard to implement.
Personally I  never run sequential tasks with *, only parallel tasks.

In my personal projects I don't do it either, but I've come across it in open source & work projects
For example: when using Remix, it's important that build:css is ran before build:remix in the Tailwind case: https://remix.run/docs/en/v1/guides/styling#tailwind-css
Don't want to hold back on this PR for that though, so for me this one is approved as well 👍 (can't do it on GitHub, as I created the PR)


ign -> gz : Remove redundant namespace references

Part of: https://github.com/gazebo-tooling/release-tools/issues/784

I think the namespace reduction plan in https://github.com/gazebo-tooling/release-tools/issues/784 is useful for eliminating ignition:: namespaces, but for this library it is just removing sdf:: in lots of places, which looks like noise to me. I would rather just decline this.

I just saw @scpeters 's comment, I'm fine declining this PR if that's preferred.

I have no preferences, but if needed, I can exclude stuff like split from the cleanup, it's not too difficult for me to do (like a 5-10 min job)

@methylDragon , I'll just close this one for expediency. We don't need to put more time into it. Let's focus on ignition:: and ignition::gazebo.


Implement AS search requests

I think it's tracked here
https://datatracker.ietf.org/doc/draft-ietf-regext-rdap-rir-search/

It seems only rdap.db.ripe.net is implementing it as of now


Added cilium support

I already signed CLA but have no permissions to run CI (according to error)

ci check this

@melkosoft can you consolidate your changes between this PR and #2235 and close one of them?

Looks like CI failed on yaml linting: https://gitlab.com/kargo-ci/kubernetes-incubator__kubespray/-/jobs/50670046

Looks like your last commit was using a different email address from the one you used to sign the CLA. Can you edit the author of your last commit? Instructions here: https://stackoverflow.com/a/3042512

Looks like this is missing a few changes that your other two PRs had, was that intentional?

@chadswen Sorry. The changes are submitted by my colleague. He's offline now. So I'm not sure if he'd submitted all changes. I will review his code changes before making another push. Sorry again.

Please ignore other pull requests. I will ask him to close them when he's back online.

We will need to get .gitlab-ci.yml updated with new pipeline jobs before we can successfully test this in CI.

@chadswen Updated .gitlab-ci.yml. And included other changes.

Thanks, starting the new cilium CI job here: https://gitlab.com/kargo-ci/kubernetes-incubator__kubespray/-/jobs/50683327
Also, here's a few features we may want to add:

https://cilium.readthedocs.io/en/latest/kubernetes/install/#running-kubernetes-with-crd-validation-recommended
https://cilium.readthedocs.io/en/latest/kubernetes/install/#mounting-the-bpf-fs-optional
Since cilium requires BPF features that are only in kernel 4.8+, it likely won't work across RHEL 7 and CentOS 7. We probably want to add a precheck in roles/kubernetes/preinstall/tasks/verify-settings.yml for kernel version >= 4.8 when kube_network_plugin == cilium
We will want to update our docs for cilium

This is coming together very nicely, keep up the great work!

@chadswen Thanks for your kindly review. Already added the version check. Will work on the docs later. I'm wondering are CRD validation and BPF FS mounting feature mandatory for this PR to be merged?

Hi, I'm one of the Cilium maintainers. Some comments:
Awesome PR. Great to see this. We will link to the guides in our documentation as soon as this is merged. We will also be happy to add a kubespray specific getting started guide.

https://cilium.readthedocs.io/en/latest/kubernetes/install/#running-kubernetes-with-crd-validation-recommended

CRD validation is enabled by default starting with Kubernetes 1.9. Cilium automatically installs the CRD validation schema if Kubernetes supports it. No work needed here.

https://cilium.readthedocs.io/en/latest/kubernetes/install/#mounting-the-bpf-fs-optional

This is highly recommended to ensure networking is not disrupted when the Cilium pod is restarted. This allows to upgrade Cilium without ever loosing network connectivity.

@tgraf Thanks so much for the feedback and for Cilium! I have wanted to get it into Kubespray ever since attending your DockerCon 17 session last April where it was announced. That session blew my mind, this is huge for me :)
@thoslin Thanks for the fix, CI is now running here: https://gitlab.com/kargo-ci/kubernetes-incubator__kubespray/-/jobs/50695682
I concur with @tgraf on the bpf mount, it would be a very valuable feature for production use, and Kubespray aims for production quality.

BPF mount is in cilium task. I checked it on AWS test cluster with coreos - it is mounting on each node

I tried running the job twice, but there were test failures in two different places:

https://gitlab.com/kargo-ci/kubernetes-incubator__kubespray/-/jobs/50816532 failed at tests/testcases/030_check-network.yml:16
https://gitlab.com/kargo-ci/kubernetes-incubator__kubespray/-/jobs/50832549 failed at tests/testcases/040_check-network-adv.yml:55

@mattymo @rsmitty @bogdando are there any additional tests we should add (kubeadm, probably) or should a different test set be used?

does first error mean that netchecker agent was not running yet?

It's wired There is no line No 21 in roles/kubernetes-apps/network_plugin/cilium/tasks/main.yml

It looks like the test configuration used here is only running tests on two nodes despite provisioning a 3 node cluster. Tests are consistently failing TASK [Get netchecker agents]

Also worth noting, TASK [Check pods IP are in correct network] looks to be reporting the same IP twice, which I don't see in other jobs.

@melkosoft  @thoslin If you get a chance before me, can you deploy netchecker in a Cilium cluster built from this branch and share the response for curl http://localhost:31081/api/v1/agents/ from one of the nodes?

We might be running into this cilium/cilium#2505 see also cilium/cilium#2495

@melkosoft @thoslin, can you rebase from master? Also, it looks like @tgraf pushed an iptables-1.9 image tag earlier today, presumably built from cilium/cilium#2753 which closed cilium/cilium#2505 and cilium/cilium#2495, can we try that image?

We're back in business, looks like iptables-1.9 fixed our issue with accessing netchecker's node port. https://gitlab.com/kargo-ci/kubernetes-incubator__kubespray/-/jobs/51760034
Could you add docs if applicable to kubespray/docs? Similar to Flannel or Calico. We will also need to update README.md
I'd like to hold out until at least the next rc before we merge this, but all network tests passing is a very good sign that we're close.

We're back in business, looks like iptables-1.9 fixed our issue with accessing netchecker's node port. https://gitlab.com/kargo-ci/kubernetes-incubator__kubespray/-/jobs/51760034

Thanks for jumping onto this! I was about to ping everyone here but you are way ahead of me. All fixes are in master and we are crafting a release for end of week.

@chadswen, Could you share the plan for next rc? When it will happen?

@lisaxxfxu Oh sorry, I was referring to the next Cilium RC, not a Kubespray RC. Looks like the v1.0.0-rc3
Docker image tag was updated on Docker Hub, but I'm not sure if that's the final rc3 or not. @tgraf would it be better to wait for a release to show up on the release page, or are the v1.0.0-rc3
and v0.13 image tags already finalized release versions?

Docker image tag was updated on Docker Hub, but I'm not sure if that's the final rc3 or not. @tgraf would it be better to wait for a release to show up on the release page, or are the v1.0.0-rc3
and v0.13 image tags already finalized release versions?

 Will run it through CI now :)

We did it! This is ready for merge.
Thanks so much to @tgraf @melkosoft @thoslin and @jpds for all of the hard work and help across the various iterations of this patch!
Time for me to go play with Cilium in a few clusters! :)
Closes #1965


S3resource

This is a little s3 storage pipelineresource. It fetches or puts artifacts into a bucket, plain and simple.
There is some example yaml which is close to what I am using to work with s3 buckets and artifacts, so it all should work.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[ ] Includes tests (if functionality changed/added)
[ ] Includes docs (if user facing)
[ ] Commit messages follow commit message best practices

See the contribution guide for more details.
Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task and TaskRun to build and release this image

Reviewer Notes
If API changes
are included, additive changes
must be approved by at least two OWNERS
and backwards incompatible changes
must be approved by more than 50% of the OWNERS,
and they must first be added
in a backwards compatible way.
Release Notes
Describe any user facing changes here, or delete this block.

Examples of user facing changes:
- Add S3 Artifact Storage type

I wonder whether we should consider a moratorium on new pipeline resources until the work to make them extensible is complete, so that they can be contributed to the catalog repo instead of into the Pipelines tree. This would also help with versioning and releasing.
If this is something you need to support more urgently though we can put it in here until extensibility lands and we can move it back out with the rest.

I wonder whether we should consider a moratorium on new pipeline resources until the work to make them extensible is complete

@ImJasonH I had thought about waiting to contribute this until the resource refactor was done, but this is already done/working and it feels like the pipelineresources refactor is going to take a little while to become ready. It is a blocker for me so it would be extra nice to land this but I understand the counterpoint as well 😄

Overall I am with @ImJasonH on not adding too much new PipelineResource until the refactoring is done. But if there is an urgent needs to get this merged for the next release I am ok to get it in, it just adds one more thing to migrate later on :stuck_out_tongue_closed_eyes:

@vdemeester Makes sense - Ill will maintain my s3resource fork until there is a way to implement this using new-style s3resource. Should I close this PR?

@vdemeester Makes sense - it would be great to land this, and I would likely handle the task of moving it to the new style resource either way. But, I will maintain my s3resource fork until there is a way to implement this using new-style s3resource. Should I close this PR?

@iancoffey as you already have something done and working, I think we can merge this :wink: (especially if you promise me to work on migrating it to the new style :hugs:)

My 2 cents: since @iancoffey has already done the work here and is using this, I feel like we should go ahead and merge it. If the PipelineResource work was like just one PR merge away I'd agree about waiting, but I think it's a little ways off still (maybe even start of 2020, tho I know @vdemeester is more ambitious than that 😉) so I say we go ahead :D
My concern is a bit different: I'd like to have automated tests for this, but also I don't want to block the PR on that since it'll be a bit of work to get setup and going.

@vdemeester @bobcatfish great input, thanks. Ill fix this branch up today and then perhaps we can look at merging. Im not sure how to fix these tests yet.

I'm also pro merging this one once it's ready. A few object storage services have an S3-too interface, so this would give Tasks access several storage services at once.
One thing that would be nice to have once we refactor resources, is some kind of "duck typing" compatibility between this and the GCS resource, so that the same Task may work with either implementation with no change.

I hadn't seen this before I created #1361, but in #1361 I was able to achieve this with a simpler approach: gsutil allows connecting to a any S3-compatible API when given a boto configuration file.

I hadn't seen this before I created #1361, but in #1361 I was able to achieve this with a simpler approach: gsutil allows connecting to any S3-compatible API when given a boto configuration file.

In fact, with #1361  merged, it is now possible to use the GCS resource to point to an S3 bucket!
For example:
Create the secret (this is for IBM Cloud):
# Create a boto_config
cat <<EOF > boto_config
[Credentials]
aws_access_key_id = $AWS_ACCESS_KEY_ID
aws_secret_access_key = $AWS_SECRET_ACCESS_KEY
[s3]
host = s3.eu-geo.objectstorage.softlayer.net
use-sigv4 = True
[Boto]
https_validate_certificates = True
[GSUtil]
prefer_api = xml
EOF

kubectl create secret generic pipelines-cos-credentials --from-file=boto_config=boto_config

Create the archive.zip file in the bucket, and then run the example:
apiVersion: tekton.dev/v1alpha1
kind: TaskRun
metadata:
  generateName: gcs-resource-
spec:
  taskSpec:
    inputs:
      resources:
      - name: source
        type: storage
    steps:
    - image: alpine
      command: ['unzip', 'source/archive.zip']
    - image: alpine
      command: ['cat', 'file.txt']
  inputs:
    resources:
    - name: source
      resourceSpec:
        type: storage
        params:
          - name: location
            value: s3://tektonstorage/archive.zip
          - name: type
            value: gcs
        secrets:
          - fieldName: BOTO_CONFIG
            secretName: pipelines-cos-credentials
            secretKey: boto_config
---

Sounds good to me! Ill close this PR for now, thanks.

I'm trying to get the same thing to work with artifact storage but it fails with this error AccessDeniedException: 403 SignatureDoesNotMatch...<Message>The request signature we calculated does not match the signature you provided. Check your key and signing method.</Message>
Uploading the artifact works fine, retrieving the an artifact however throws the error message above.
Did you manage to get this to work with artifact storage ?

Nevermind, i finally got around it.
It looks like the S3 bucket has to be in us-east-1 and the use-sigv4 key must not be present in boto config file.


Single-Direction DC/DC Converter

A DC/DC converter that takes input voltage on one side and outputs a regulated voltage on the other side.
(From https://github.com/jrddunbr/ElectricalAge/issues/183)

Don't you mean boost/buck regulators? Since that's what we would want to use here.


Server should indicate when request URL is too long

Ported from  https://github.com/Azure/azure-mobile-services/issues/892

Hi, I spent a day trying to debug a 404 error when my mobile app called my server with a filter that was large. In the old version (Azure Mobile Services) the failure error reported to the client was something like "Request Uri Too Long". The current server just reports a 404 and the request fails to hit the table controller so there is no debugging that you can do.
I probably should have thought of it sooner, but if I had seen the uri too long error I would have increased the querystring and url size in the web.config and been done with it. It would be nice if this was documented somewhere or if the error could be more descriptive than just a 404.

This is an IIS thing - the actual error is 404.14 as according to this table:
HTTP Substatus Description
404.5 URL Sequence Denied
404.6 Verb Denied
404.7 File Extension Denied
404.8 Hidden Namespace
404.10 Request Header Too Long
404.11 URL Double Escaped
404.12 URL Has High Bit Chars
404.13 Content Length Too Large
404.14 URL Too Long
404.15 Query String Too Long
404.18 Query String Sequence Denied
404.19 Denied by Filtering Rule
In the client, we could trap this, but it will still show as a 404.

This is consistent with the following IIS error code table:
HTTP Substatus Description
404.5 URL Sequence Denied
404.6 Verb Denied
404.7 File Extension Denied
404.8 Hidden Namespace
404.10 Request Header Too Long
404.11 URL Double Escaped
404.12 URL Has High Bit Chars
404.13 Content Length Too Large
404.14 URL Too Long
404.15 Query String Too Long
404.18 Query String Sequence Denied
404.19 Denied by Filtering Rule


Non-Explore bug fixes for SOW.2

Summary
Fix map offset on mobile
screwy in all zoom-to-bounds scenarios. and in pitch reset. seems to be off by consistent amt for bounds scenarios and clicked points (although that works in our favor since the popup centers better vertically).
Page title should reset
...after coming from Details, but it's still at the previous:

Gentium Safari error console warning
Check console. Something about ttf MIME type.

I got the page title thing sorted out. It's not super useful at the deep depths like /Explore/Stuff/Thing/Language but otherwise was worth the medium amount of effort.

Probably not going to touch the gentium thing any time soon. Clearly it's not causing any issues as of yet and it's just a warning anyway.


Zoom Clone Using HTML,CSS

Project title

I wish to create a Zoom  landing page clone using HTML, CSS Javascript
Project Description

The project will have sign in, sign up and landing page. I will add functionality after learning more about backend development
Web stack

HTML,CSS, Javascript
Screenshot(mandatory)

N/A (Will work on project)
Additional Context(mandatory)
Are you contributing under any open-source program ?

CodePeak

@aindree-2005 I have assigned you. You can start working.
If you need any help you can reach out us in DC

@aindree-2005 I have assigned you. You can start working. If you need any help you can reach out us in DC

On it ! Glad to be able to contribute to this repo


error instantiating route53 challenge solver: unable to assume role: AccessDenied:

When using the Route53 Solver for ACME, I am attempting to use an IRSA (IAM Role for Service Accounts). However, I have a permissions error, causing sts:AssumeRoleWithWebIdentity to fail.
When this happens, cert-manager goes into an aggressive loop, retrying to delete the challenge:
E1102 10:11:36.594953       1 controller.go:166] cert-manager/challenges "msg"="re-queuing item due to error processing" "error"="error instantiating route53 challenge solver: unable to assume role: AccessDenied: User: arn:aws:sts::80xxxxx assumed-role/eks-ops-cluster-cert-manager/1667383896419927778 is not authorized to perform: sts:AssumeRole on resource: arn:aws:iam::80xxxxx:role/eks-ops-cluster-cert-manager\n\tstatus code: 403, request id: 9dda0692-6906-44b5-a265-48d38ed62008" "key"="monitoring/ops-grafana-tls"
challenge & order remains in pending state
monitoring   ops-prometheus-tls  pending   ops-prometheus.xyz.com   46h
monitoring   ops-prometheus-tls-  pending   46h
Environment details::
eks : 1.23
cert-manager version: 1.8.2  also tried 1.9.0 its  same error
Install method: helm

@prem9966 did you find a solution?

/remove-lifecycle stale

i have the same issue, any solution?
the k8s sa is into cert-manager namespace but certificate is defined in diff namespace (not cert-manager namespace) the AWS role has all needed rights

i have the same issue, any solution? the k8s sa is into cert-manager namespace but certificate is defined in diff namespace (not cert-manager namespace) the AWS role has all needed rights

Same issue here, it looks like that despite following the directions here, the cert-manager isn't using the sa account.
Warning  CleanUpError  17s (x2659 over 5m16s)  cert-manager-challenges  (combined from similar events): Error cleaning up challenge: error instantiating route53 challenge solver: unable to assume role: AccessDenied: User: arn:aws:sts::############:assumed-role/eksctl-############-node-NodeInstanceRole-1Q018K4TZEAIC/i-07014edbf556cb4ce is not authorized to perform: sts:AssumeRole on resource: arn:aws:iam::############:role/serviceaccount
           status code: 403, request id: 56104b58-265b-42eb-838d-6ee928441f81

Btw, I'm using an Issuer, not ClusterIssuer.
issuer.yaml
apiVersion: cert-manager.io/v1
kind: Issuer
metadata:
  name: letsencrypt-staging
  namespace: teleport-cluster
spec:
  acme:
    email: ############
    server: https://acme-staging-v02.api.letsencrypt.org/directory
    privateKeySecretRef:
      name: letsencrypt-staging
    solvers:
    - selector:
        dnsZones:
          - "############"
      dns01:
        route53:
          region: us-west-2
          hostedZoneID: ############
          role: arn:aws:iam::############:role/serviceaccount

@nathan-bowman that appears to be a different issue with a different error than the OP. I've got a similar issue to OP and the serviceaccount is actually being used but is still getting access denied.

/remove-lifecycle rotten

Why is the IRSA role assumed tring to sts:AssumeRole itself.
I've event added sts:AssumeRole to the role so it can assume itself and it still in an aggressive loop

This is definitely a bug but once I added TrustPolicy to allow the role to assumeRole itself it worked:
        {
            "Action": [
                "sts:AssumeRole"
            ],
            "Effect": "Allow",
            "Principal": {
                "AWS": "arn:aws:iam::REDACT:role/cert-manager"
            }
        }

This is in addition to the IRSA trust that was already there.
@munnerz any ideas?

i have the same issue, any solution? the k8s sa is into cert-manager namespace but certificate is defined in diff namespace (not cert-manager namespace) the AWS role has all needed rights

Same issue here, it looks like that despite following the directions here, the cert-manager isn't using the sa account.
Warning  CleanUpError  17s (x2659 over 5m16s)  cert-manager-challenges  (combined from similar events): Error cleaning up challenge: error instantiating route53 challenge solver: unable to assume role: AccessDenied: User: arn:aws:sts::############:assumed-role/eksctl-############-node-NodeInstanceRole-1Q018K4TZEAIC/i-07014edbf556cb4ce is not authorized to perform: sts:AssumeRole on resource: arn:aws:iam::############:role/serviceaccount
           status code: 403, request id: 56104b58-265b-42eb-838d-6ee928441f81

Btw, I'm using an Issuer, not ClusterIssuer.
issuer.yaml
apiVersion: cert-manager.io/v1
kind: Issuer
metadata:
  name: letsencrypt-staging
  namespace: teleport-cluster
spec:
  acme:
    email: ############
    server: https://acme-staging-v02.api.letsencrypt.org/directory
    privateKeySecretRef:
      name: letsencrypt-staging
    solvers:
    - selector:
        dnsZones:
          - "############"
      dns01:
        route53:
          region: us-west-2
          hostedZoneID: ############
          role: arn:aws:iam::############:role/serviceaccount

Remove the "role: arn:aws:iam::############:role/serviceaccount" from your manifest, otherwise IRSA won't be used.

I got the same issue when I tried to create a ClusterIssuer, I reviewed the IAM role and everything was ok, also I saw some events in CloudTrail with the assume-role action with no permission errors.
Then I decided to create an Issuer instead of a ClusterIssuer, but I got another error
re-queuing item due to error processing" err="error instantiating route53 challenge solver: unable to construct route53 provider: empty credentials
Investigating I saw a post where someone mentioned adding an extra argument --issuer-ambient-credentials, that fixed my error for Issuer and ClusterIssuer.
The controller documentation mentions the extra-arguments.
I am using HELM with FluxCD, here just part of the manifest that i am using
apiVersion: helm.toolkit.fluxcd.io/v2beta1
kind: HelmRelease
metadata:
  name: cert-manager
spec:
  interval: 10m0s
  chart:
    spec:
      chart: cert-manager
      version: 1.13.2
      ...
  values:
    serviceAccount:
      annotations:
        eks.amazonaws.com/role-arn: AWS_ARN_ROLE
    securityContext:
      fsGroup: 1001
    extraArgs:
      - --issuer-ambient-credentials

Had same issue. In my case problem is with documentation where clusterIssuer specifies arn:
Since IARSA is defined, does not seem to require IAM arn:
Created pull request to update documentation
https://github.com/cert-manager/website/pull/1466

Had same issue. In my case problem is with documentation where clusterIssuer specifies arn:
Since IARSA is defined, does not seem to require IAM arn:
am
Created pull request to update documentation
https://github.com/cert-manager/website/pull/1466

I got the same issue when I tried to create a ClusterIssuer, I reviewed the IAM role and everything was ok, also I saw some events in CloudTrail with the assume-role action with no permission errors. Then I decided to create an Issuer instead of a ClusterIssuer, but I got another error
re-queuing item due to error processing" err="error instantiating route53 challenge solver: unable to construct route53 provider: empty credentials
Investigating I saw a post where someone mentioned adding an extra argument --issuer-ambient-credentials, that fixed my error for Issuer and ClusterIssuer.
The controller documentation mentions the extra-arguments.
I am using HELM with FluxCD, here just part of the manifest that i am using
apiVersion: helm.toolkit.fluxcd.io/v2beta1
kind: HelmRelease
metadata:
  name: cert-manager
spec:
  interval: 10m0s
  chart:
    spec:
      chart: cert-manager
      version: 1.13.2
      ...
  values:
    serviceAccount:
      annotations:
        eks.amazonaws.com/role-arn: AWS_ARN_ROLE
    securityContext:
      fsGroup: 1001
    extraArgs:
      - --issuer-ambient-credentials

Do you specify the ARN_ROLE on your ClusterIssuer on spec.acme.solvers.dns01.route53?
dns01:
        route53:
          region: us-fake-1
          hostedZoneID: XXXXXXXXX
          role: arn:aws:iam::XXXXXXXXX:role/roleName

In my case I'm using a pod identity association instead of IRSA.

I got the same issue when I tried to create a ClusterIssuer, I reviewed the IAM role and everything was ok, also I saw some events in CloudTrail with the assume-role action with no permission errors. Then I decided to create an Issuer instead of a ClusterIssuer, but I got another error
re-queuing item due to error processing" err="error instantiating route53 challenge solver: unable to construct route53 provider: empty credentials
Investigating I saw a post where someone mentioned adding an extra argument --issuer-ambient-credentials, that fixed my error for Issuer and ClusterIssuer.
The controller documentation mentions the extra-arguments.
I am using HELM with FluxCD, here just part of the manifest that i am using
apiVersion: helm.toolkit.fluxcd.io/v2beta1
kind: HelmRelease
metadata:
  name: cert-manager
spec:
  interval: 10m0s
  chart:
    spec:
      chart: cert-manager
      version: 1.13.2
      ...
  values:
    serviceAccount:
      annotations:
        eks.amazonaws.com/role-arn: AWS_ARN_ROLE
    securityContext:
      fsGroup: 1001
    extraArgs:
      - --issuer-ambient-credentials

Do you specify the ARN_ROLE on your ClusterIssuer on spec.acme.solvers.dns01.route53?
dns01:
        route53:
          region: us-fake-1
          hostedZoneID: XXXXXXXXX
          role: arn:aws:iam::XXXXXXXXX:role/roleName

In my case I'm using a pod identity association instead of IRSA.

So as a couple of users mentioned above we don't need to add the role to  spec.acme.solvers.dns01.route53, just having the hostedZoneID worked perfectly fine.
thanks @danielrive

if you are using EKS pod identity and tried to follow https://cert-manager.io/docs/configuration/acme/dns01/route53/#eks-iam-role-for-service-accounts-irsa, you need to do as detailed above by @yiskaneto and also remove the spec.acme.solvers.dns01.route53.auth to make it work.


[SPARK-46504][PS][TESTS][FOLLOWUPS] Make test_insert more stable by sorting before comparison

What changes were proposed in this pull request?
Make test_insert more stable by sorting before comparison
Why are the changes needed?
this test may fail in some env
Does this PR introduce any user-facing change?
no, test-only
How was this patch tested?
ci and manually check
Was this patch authored or co-authored using generative AI tooling?
no

merged to master


🥢 Multicallable: Use public and virtual

Description
🥢 Use public and virtual to conform to other Solady abstract contract style and permit overrides.
This is based on review of Auth contracts style.
Checklist
Ensure you completed all of the steps below before submitting your pull request:

[x] Ran forge fmt?
[x] Ran forge snapshot?
[x] Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

Changed back to external because of the direct return in assembly.


Borked nodejs/12-oracledb image

https://github.com/oracle/docker-images/blob/master/OracleLinuxDevelopers/oraclelinux7/nodejs/12-oracledb/Dockerfile doesn't actually run yum -y install nodejs node-oracledb-node12.  It also (now) needs to use the Instant Client 21 repo instead of the older repo.

The fix will be like:
RUN yum -y install oracle-nodejs-release-el7 oracle-instantclient-release-el7 && \
    yum-config-manager --disable ol7_developer_nodejs14 && \
    yum-config-manager --enable ol7_developer_nodejs12 && \
    yum -y install nodejs node-oracledb-node12 && \
    rm -rf /var/cache/yum/*

The fix will be like:
RUN yum -y install oracle-nodejs-release-el7 oracle-instantclient-release-el7 && \
    yum-config-manager --disable ol7_developer_nodejs14 && \
    yum-config-manager --enable ol7_developer_nodejs12 && \
    yum -y install nodejs node-oracledb-node12 && \
    rm -rf /var/cache/yum/*

@AmedeeBulle is this in your domain now?

@AmedeeBulle is this in your domain now?

@cjbj I'll submit a fix now. Thanks for catching this.

@cjbj I'll submit a fix now. Thanks for catching this.


How to use

I'm trying to find a good example of how to use this. For example, if you have this file:
{
  "colors": [
    {
      "color": "black",
      "category": "hue",
      "type": "primary",
      "code": {
        "rgba": [255,255,255,1],
        "hex": "#000"
      }
    },
    {
      "color": "white",
      "category": "value",
      "code": {
        "rgba": [0,0,0,1],
        "hex": "#FFF"
      }
    },
    {
      "color": "red",
      "category": "hue",
      "type": "primary",
      "code": {
        "rgba": [255,0,0,1],
        "hex": "#FF0"
      }
    },
    {
      "color": "blue",
      "category": "hue",
      "type": "primary",
      "code": {
        "rgba": [0,0,255,1],
        "hex": "#00F"
      }
    },
    {
      "color": "yellow",
      "category": "hue",
      "type": "primary",
      "code": {
        "rgba": [255,255,0,1],
        "hex": "#FF0"
      }
    },
    {
      "color": "green",
      "category": "hue",
      "type": "secondary",
      "code": {
        "rgba": [0,255,0,1],
        "hex": "#0F0"
      }
    },
  ]
}

What could you do with vj?

@agarrharr Well, there's a few things about your snippet.
The 'white' value was categorized as value, and not hue, and the trailing comma broke json.. I posted an updated version of your json here. https://jqplay.org/s/UDfm0I60UA
The corrected json snippet wouldn't have worked in vj, because the values were all inside the colors array. vj doesn't dig for values, it treats the outermost value as the core. So you would need to pre-process the json array with something like 'jq' to do a expose the [colors] array to the namespace. Then VJ can take it from there.
 black  category hue  code {"rgba"=>[255, 255, 255, 1], "hex"=>"#000"}  type primary
 white  category hue  code {"rgba"=>[0, 0, 0, 1], "hex"=>"#FFF"}
 red  category hue  code {"rgba"=>[255, 0, 0, 1], "hex"=>"#FF0"}  type primary
 blue  category hue  code {"rgba"=>[0, 0, 255, 1], "hex"=>"#00F"}  type primary
 yellow  category hue  code {"rgba"=>[255, 255, 0, 1], "hex"=>"#FF0"}  type primary
 green  category hue  code {"rgba"=>[0, 255, 0, 1], "hex"=>"#0F0"}  type secondary

So the code array is still in an array, if you wanted to exclude that.
 black  category hue  type primary
 white  category hue
 red  category hue  type primary
 blue  category hue  type primary
 yellow  category hue  type primary
 green  category hue  type secondary

That would wrap up the whole thing. If you wanted to include everything in code, you'd need to use jq filter to add the flattened array to the containing array. Here's an example of hex value being taken out of the code array.
 black  type primary  category hue  hex #000  rgba [255, 255, 255, 1]
 white  type primary  category hue  hex #FFF  rgba [0, 0, 0, 1]
 red  type primary  category hue  hex #FF0  rgba [255, 0, 0, 1]
 blue  type primary  category hue  hex #00F  rgba [0, 0, 255, 1]
 yellow  type primary  category hue  hex #FF0  rgba [255, 255, 0, 1]
 green  type secondary  category hue  hex #0F0  rgba [0, 255, 0, 1]

Here's another example using OMDB
 curl -s 'https://www.omdbapi.com/?s=ready&apikey=REDACTED' | jq  '.Search[]' -rc | vj -c Year -p title -s Poster | sort -n
 2000  Title Get Ready to Be Boyzvoiced  Type movie  imdbID tt0248036
 2000  Title Ready to Rumble  Type movie  imdbID tt0217756
 2008  Title Ready  Type movie  imdbID tt1156516
 2011  Title Ready  Type movie  imdbID tt1708532
 2018  Title Ready Player One  Type movie  imdbID tt1677720
 1993–1997  Title Ready or Not  Type series  imdbID tt0106110
 1994  Title Ready to Wear  Type movie  imdbID tt0110907
 2009  Title Ready or Not  Type movie  imdbID tt0892094
 2003  Title Ready, Steady, Charlie!  Type movie  imdbID tt0353161
 2015  Title I'm Not Ready for Christmas  Type movie  imdbID tt5182120

The original json looked like this:
{
  "Search": [
    {
      "Title": "Ready Player One",
      "Year": "2018",
      "imdbID": "tt1677720",
      "Type": "movie",
      "Poster"<EMAIL_ADDRESS>    },
    {
      "Title": "Ready to Wear",
      "Year": "1994",
      "imdbID": "tt0110907",
      "Type": "movie",
      "Poster"<EMAIL_ADDRESS>    },
    {
      "Title": "Ready to Rumble",
      "Year": "2000",
      "imdbID": "tt0217756",
      "Type": "movie",
      "Poster": "https://m.media-amazon.com/images/M/MV5BMTYwMjYyOTA4OV5BMl5BanBnXkFtZTYwMDAyNjE3._V1_SX300.jpg"
    },
    {
      "Title": "Ready",
      "Year": "2011",
      "imdbID": "tt1708532",
      "Type": "movie",
      "Poster"<EMAIL_ADDRESS>    },
    {
      "Title": "Ready or Not",
      "Year": "1993–1997",
      "imdbID": "tt0106110",
      "Type": "series",
      "Poster"<EMAIL_ADDRESS>    },
    {
      "Title": "Get Ready to Be Boyzvoiced",
      "Year": "2000",
      "imdbID": "tt0248036",
      "Type": "movie",
      "Poster": "https://images-na.ssl-images-amazon.com/images/M/MV5BYjc0ZjI5ODAtY2Y3Ni00NGM2LTg1ZmQtNDZkOWVhNGNmN2M3XkEyXkFqcGdeQXVyNDg1NjA2OA@@._V1_SX300.jpg"
    },
    {
      "Title": "I'm Not Ready for Christmas",
      "Year": "2015",
      "imdbID": "tt5182120",
      "Type": "movie",
      "Poster"<EMAIL_ADDRESS>    },
    {
      "Title": "Ready, Steady, Charlie!",
      "Year": "2003",
      "imdbID": "tt0353161",
      "Type": "movie",
      "Poster": "https://m.media-amazon.com/images/M/MV5BMTU1OTg2Mjk4NV5BMl5BanBnXkFtZTcwMDMxNzY5MQ@@._V1_SX300.jpg"
    },
    {
      "Title": "Ready",
      "Year": "2008",
      "imdbID": "tt1156516",
      "Type": "movie",
      "Poster"<EMAIL_ADDRESS>    },
    {
      "Title": "Ready or Not",
      "Year": "2009",
      "imdbID": "tt0892094",
      "Type": "movie",
      "Poster": "https://images-na.ssl-images-amazon.com/images/M/MV5BMTMyODg1NDY4N15BMl5BanBnXkFtZTcwMjk4NzI0MQ@@._V1_SX300.jpg"
    }
  ],
  "totalResults": "361",
  "Response": "True"
}

The data I wanted VJ to work on was in the Search var, so I used jq to output only that. VJ has a -d to set the default container, but I couldn't get it to work. I would love to get spaced/padding/justification on the output, but for now, I've found this really useful tool to summarize lots of JSON data.
Hope this helps!


your results presented at here is not the same in your paper

can you check your results, thank you

If you see the bold note mentioned in the readme below the results table, it clearly says the reasons why the numbers are different from the paper. I am pasting those again here below:
Note that this released baseline model has several improvements (and significantly better results) w.r.t. our EMNLP17 paper results, due to the following enhancements:
Better visual features: (1) ResNet-152 frame-level features (2) ResNeXt-101 motion features
Used SCST approach instead of MIXER for reinforcement leanring
Used better entailment classifier

Thank you, I see it.


Make lagoon list variables return variables for all environments if required.

Currently, if you try to list variables for a project, you get only the variables that have been added on the project level. If no variables have been specified on the project level, you get this:
lagoon list variables -p some-project
Error: graphql: Cannot read property 'id' of undefined

(which means that there are no variables on the project level - see #105)
I just found that if you do specify -e, you might find that there are actually variables on the environment level:
lagoon list variables -p some-project -e master
ID  	PROJECT         ENVIRONMENT	SCOPE 	VARIABLENAME
1234	some-project	master     	global	CLAMAV_HOST
5678	some-project	master     	global	CLAMAV_MODE

There is a --all-projects flag, but there is no --all-environments one, which is what I would like to be the default. In other words, I would expect that when I specify no environment, then a report of all variables for all environments is returned; for the variables that have been defined on a project level, I would expect that to be denoted in the ENVIRONMENT column (something like ALL ENVs?)

@klonos I'm not sure if the default behaviour when no project variables are available is to fall back to displaying all environment variables for all environments.
Having a flag to choose to do this would the better option.
The CLI is also just passing the error response from the Lagoon API directly back to the user, but we may be able to parse this and provide a more customised error response that could instruct the user to try with the --all-environments flag if it exists.

Yup, all that sounds sensible to me @shreddedbacon 👍

I can see value in a unified list of all variables for all environments.


Add tutorial for Media File Bot

I have added the tutorial for the Media File Bot under the Tutorials > Examples > Advanced section. Also, I have updated the link under tutorials overview so that it points to the correct page.
The page looks like this:

Tag #891

@Rohitesh-Kumar-Jain @proudofsimin I think this PR can be added to #1056

@nibble0101 pls  resolve the conflict, and then ping for merge

@sbis04 i have merged #1138

@Rohitesh-Kumar-Jain I have fixed the conflict


Ssh after aws

Attempt 3 to create a clean PR that doesn't have other code. This is narrowed down to crypto package pegging down plus my code changes

@adityadani @harsh-px
For this one I actually started with origin/master: created a new branch
Merged my branch on it and pushed and created the PR


Fix CI after main branch rename

Codecov Report

Merging #13 (0afc5cb) into main (6d2f998) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #13   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           49        49
  Branches         5         5
=========================================
  Hits            49        49

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d2f998...0afc5cb. Read the comment docs.


regenerated docs

with the command cmake --build . --target onnx-mlir-docs

The instructions in the comments in ONNX.td
https://github.com/onnx/onnx-mlir/blob/main/src/Dialect/ONNX/ONNX.td#L15
say to run make onnx-mlir-docs but that doesn't work for me and instead I ran cmake --build . --target onnx-mlir-docs
Is that correct? Should I edit the instructions?
The same goes for make OMONNXOpsIncTranslation: should we change that to cmake --build . --target OMONNXOpsIncTranslation?

@tungld can I ask you to review this PR? among other things it includes the documentation for ONNXShapeTransformOp

I always use make onnx-mlir-docs and make OMONNXOpsIncTranslation, and haven't seen any issue. I call them inside build folder.

I always use make onnx-mlir-docs and make OMONNXOpsIncTranslation, and haven't seen any issue. I call them inside build folder.

I figured out that it's because I build with ninja instead of make on OSX, following the instructions here:
https://github.com/onnx/onnx-mlir/blob/main/docs/BuildOnLinuxOSX.md
I can use ninja onnx-mlir-docs
I can use make if I build with -G"Unix Makefiles" instead of -G Ninja
we might consider changing the instructions to use cmake --build . --target onnx-mlir-docs which should work across ninja and make

Now also regenerated krnl.md, zhigh.md, zlow.md

Jenkins Linux ppc64le Build #10274 [push] regenerated docs (#2264)... started at 09:19

Jenkins Linux s390x Build #11226 [push] regenerated docs (#2264)... started at 09:14

Jenkins Linux ppc64le Build #10274 [push] regenerated docs (#2264)... aborted after 2 hr 0 min

Jenkins Linux s390x Build #11226 [push] regenerated docs (#2264)... aborted after 2 hr 0 min


Why aren't new versions being released to package repos ?

Hi Team,
This is a great alternative to heavy audit log libraries like simple-history. We're trying to move to this after working with simple-history for an year and being frustrated with the schema overhead it brings.
I see that there's active development on this, but the last released package was in 2019, and that version has ref to outdated django-dateutil version which makes it impossible to use. Wondering if there's gonna be a new version out soon?

Hi ! With @hramezani, we will release a new version soon :). We are waiting fo #268 to be closed, first.

@prasadpilla, did you end up making the switch from simple-history to auditlog and if so, were you able migrate the simple-history data over?

@msf-dev, yes we did end up moving, but we didn't bother migrating the existing data. The format is very different, we would've had to do it through a script ourselves.


instanceof fails across realms

Object(true) from an iframe, or from node's vm module, or from any (upcoming ES6) other Realm, will fail the instanceof check - instanceof is basically useless.
You'll need to use Object.prototype.toString.call, at the least.

@ljharb I've updated it to use toString. Thanks for the feedback!


Llama.cpp model identifier stripping will strip too many characters

Hi all,
Version: <IP_ADDRESS> (from PyPi)
Line 21 of models/lmtp/backends/llama_cpp_model.py uses the str method .strip which treats the passed argument as a set of characters to remove, rather than as a prefix to remove.
This results in it removing all leading characters from the set "aclmp:" which caused an issue with my case, where my path began with "model_files" (which promptly became "odel_files" after the strip)
I can work around this by changing the folder name. I'm also happy to submit a PR this evening, or leave it open to beginners.

Fixed by merge of #126


Clarify .encode API in README

I lost a lot of time on this. For some reason I was thinking the syntax was { header => payload } from the examples

Tanks for the documentation improvement. :)


@EqualsAndHashCode should allow for calling superclass if superclass is not Object

We have a lot of JAXB-generated classes from externally supplied schema. We typically want to add equals and hashcode methods to each of these classes. There are packages to automatically add annotations to JAXB-generated classes, but it's not simple to set callSuper to true if and only if the class has no extensions.
Would it be possible for callSuper to have an 'automatic' mode, which calls the superclass method iif that class is not Object?

Now we have lombok.config it might be possible without breaking backwards compatibility.