Remove unsupported implementations

Description
This is an Epic to collect to dos to remove unsupported implementations / config options.

@kobergj for the initial list


feat: add BatchGetItem to appsync-simulator(#5963)

Description of changes

add BatchGetItem to amplify-appsync-simulator (all credit to tan-t)
Added reference to path amplify-e2e-core in amplify-migration-tests package due to errors regarding amplify-e2e-core not being found.

Issue #, if available

Issue 5963
Copied almost all code from PR 5965
Reason I made new PR was because it seemed like a lot of time had passed (9 months) since the original PR had made progress on the failing test. Please let me know if I should have handled this differently and I will correct any issues ASAP
Description of how you validated changes

ran existing unit tests
ran unit test for added utility function
done E2E manual tests and checked that the BatchGetItem operation will returns response like documented

Checklist

[X] PR description included
[X] yarn test passes
[X] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Can you please add E2E tests.

Is there a place where I should put them? I'm trying to figure out where the e2e tests for the other operations have been placed.

Hey, any progress on it?

Hi, same question, because i changed my offline appsync plugin to use this because its "active & maintened" but face this problem too.
To bypass the problem, i have builded the package amplify-appsync-simulator with your code, used npm i && cd package/amplify-simulator && yarn build and commited the change to a repository
Then, i can use it in the serverless-appsync-simulator as dependancies (in a fork too)
Finally, i use this fork in my serverless project !
Thank you very much @behrmans  & others :)

Reason for force-push was branch was so far behind and had trouble rebasing. All seems fine now. I still plan on trying to finish this PR hopefully soon

Codecov Report

Merging #7952 (62bf704) into master (4084827) will increase coverage by 0.01%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #7952      +/-   ##
==========================================
+ Coverage   47.29%   47.31%   +0.01%
==========================================
  Files         665      665
  Lines       32931    32942      +11
  Branches     6641     6645       +4
==========================================
+ Hits        15576    15587      +11
  Misses      15682    15682
  Partials     1673     1673

Impacted Files
Coverage Δ

...psync-simulator/src/data-loader/dynamo-db/index.ts
11.65% <20.00%> (-0.06%)
:arrow_down:

...simulator/src/data-loader/dynamo-db/utils/index.ts
80.00% <100.00%> (+56.92%)
:arrow_up:

...li/src/domain/amplify-usageData/getUsageDataUrl.ts
100.00% <0.00%> (+12.50%)
:arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@behrmans can we move this to draft since its still a work in progress? Or are you ready for review?

Any news about this PR / draft ?

@behrmans are you still working on this?

Closing due to inactivity.


Misalignments caused by new T-shirt sizing UI icons

Description
Here is the list of components that has misalignments issue

[ ] Accordion
[ ] Checkbox
[ ] Assetlist
[ ] Breadcrumb
[ ] Calendar
[ ] Dialog
[ ] Dropdown
[ ] Menu
[ ] Miller
[ ] Pagination button style
[ ] Searchwithin
[ ] Stepper quiet
[ ] Table sorting
[ ] Tabs
[ ] TextArea
[ ] Textfield
[ ] Treeview

Steps to reproduce

Checkout branch poc-new-ui-icon
Build and bootstrap the local dev server with gulp dev
Click the item in the above checklist

Expected behavior
Should match spectrum SVG
Screenshots
VR Result
Environment

Spectrum CSS version:
Browser(s) and OS(s):

Additional context

@jianliao I think we are addressing at least some of these as part of the #757 work?


training data size/volume

Hello! I would like to know the approximate amount of data in the datasets of segmentation, referring segmentation, and VQA, ie, the number of images, masks, and instructions. Thanks!

The semantic segmentation data contains around 200k images and multi-class labels. The referring segmentation data contains about 20k images, but each is annotated with multiple text queries. For VQA data, we use the llava-instruct-150k dataset, which contains 150k question-answer pairs.


Make bigquery functional classes extend info classes

This PR performs the following changes

Make Dataset extend DatasetInfo
Make Table extend TableInfo
Make Job extend JobInfo
Update READMEs and snippets
Update BigQueryExample
Update and add more tests

Since the functional objects should now be serializable, we should add them to SerializationTest

@mziccard took a first pass, looks good!  Just some minor comments from me.

Comments addressed

Looks good, one comment from me about removing the functional class builder() methods entirely.  I also think we should manually test the snippets in the READMEs/package-info to make sure that there aren't any access issues, missing imports, or typos.
I'll take care of comments that referenced Resource Manager (ie removing the package scope builder() methods from Resource Manager's Project class and making sure any Project.staticMethods() are removed as appropriate).

Looks great! I really like this change.
Few nits and suggestions.
Also, unrelated:
Missing some @Override annotation
WriteChannelConfiguration
TableDataWriteChannel
QueryJobConfiguration
LoadJobConfiguration
ExtractJobConfiguration
CopyJobConfiguration
BigQueryImpl
Missing servialVersionUID
Acl.View

Comments fixed and opened #618


docs(ingest/openapi): Downgrade status from CERTIFIED to INCUBATING

cc @shirshanka as you marked this certified in the past
Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Merging through CI failures as this is a docs-only change


[RFC] cmake: Add import_kconfig_property() for making properties from kconfig

This will store each kconfig as a property to the specified target.
Signed-off-by: Øyvind Rønningstad<EMAIL_ADDRESS>

cc @SebastianBoe @hakonfam

This will store each kconfig as a property to the specified target.

why is this needed?

This will store each kconfig as a property to the specified target.

why is this needed?

To allow using the kconfig .config format as a way to quickly add variables/properties to Cmake.
The reason for adding support for setting properties, is that properties can be accessed via generator expressions.
We need it out-of-tree, but I will try to find uses in-tree as well. (Note that the PR is currently a Draft PR)

CC @SebastianBoe
I don't understand what this does. We already have a way to check configuration values from CMake.

It allows one to defer the evaluation of a Kconfig option to Generation time, instead of at Configure time.
I can only see one use-case:
A user wants to evaluate a Kconfig option, but has not yet run Kconfig (the code that evaluates the option is for some reason executed pre-boilerplate.cmake).

It can be used more generally for importing variables into Cmake, typically with other prefixes. For example, a script needs to inject a number of variables into Cmake, so it creates a .config file with a number of label=value lines. This script might run late in Configure time, so there is a need for generator expressions.
Please tell me if there is a better way to do this!

@oyvindronningstad
Note that .config files should only set Kconfig symbols (or you get warnings).
We shouldn't piggyback on them for stuff that isn't related to Kconfig. Cleaner to keep things separate.

Note that .config files should only set Kconfig symbols (or you get warnings).
We shouldn't piggyback on them for stuff that isn't related to Kconfig. Cleaner to keep things separate.

Sorry, I agree. I didn't mean files called .config, but files formatted that way, like it's done for dts
set(GENERATED_DTS_BOARD_CONF      ${PROJECT_BINARY_DIR}/include/generated/generated_dts_board.conf)
...
import_kconfig(DT_     ${GENERATED_DTS_BOARD_CONF})

I looked, but couldn't find any obvious in-tree uses.

@nashif @ulfalizer @SebastianBoe I've moved the PR out of Draft state. Please review/approve/reject.

@nashif @ulfalizer @SebastianBoe I've moved the PR out of Draft state. Please review/approve/reject.

Guys, would be good to move this forward.


Chat - Selected receipt date is changed to priviuse date

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Go to Fab menu
Select scan
Select media
Tap on any receipt
Select user
Tap Request
open receipt when it in Scanning progress
Change the receipt date

Expected Result:
The selected date should be saved
Actual Result:
Selected receipt date is changed to priviuse date
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/78819774/1ccedb48-420a-40ce-a466-4041466911bd

Android: mWeb Chrome

iOS: Native

https://github.com/Expensify/App/assets/78819774/b53f2399-6552-446f-9167-9004cb145798

iOS: mWeb Safari

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/78819774/a1e02f15-8c19-47fb-9cc1-f15a961c8791

MacOS: Desktop

View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Proposal
from: @cooldev900
Please re-state the problem that we are trying to solve in this issue.
The Date of Birth field selects a different date instead of the selected date
What is the root cause of that problem?
It comes from this PR, https://github.com/Expensify/App/pull/29062
The root cause is that it does not take into account the difference between New Date('YYYY-MM-DD') and New Date(Year, Month, Day).
https://stackoverflow.com/questions/25865051/javascript-difference-between-new-datedatestring-vs-new-dateyear-month
https://github.com/Expensify/App/blob/9d79fd12ce8f5d1dcb8870b61a8bc4513f55c935/src/components/NewDatePicker/CalendarPicker/index.js#L208
What changes do you think we should make in order to solve the problem?
We should use a consistent approach when handling dates.
const isSelected = this.props.value === format(currentDate, CONST.DATE.FNS_FORMAT_STRING);
What alternative solutions did you explore? (Optional)

I'm not able to reproduce this

any specific steps??

This is a regression of this PR https://github.com/Expensify/App/pull/29062

Hey guys, I actually reported this issue on Slack before it was posted on Github. You can find my original report at https://expensify.slack.com/archives/C049HHMV9SM/p1697608053386949?thread_ts=1697608053.386949&cid=C049HHMV9SM."

@b4s36t4 Another scenario:

Go to Settings > Profile > Personal Details > Date of Birth
Click on the Date of Birth field and select a date
Observe that the selected date is not saved,
Expected Result: The selected date should be saved in the Date of Birth field.
Actual Result: The Date of Birth field selects a different date instead of the selected date.

https://github.com/Expensify/App/assets/93399543/08ebc5be-81a4-4917-8967-9871859c049c

@waterim the author is looking into this, if they cant find a solution, we can revert

@waterim lets focus on this testing moving ahead, although I swear this worked on our PR maybe there is some prerequisite

@lschurr could you please pay $50 to @tewodrosGirmaA for reporting. thanks!

Yep! I invited you to the job @tewodrosGirmaA - https://www.upwork.com/jobs/~017dd56ff525a2ca36

Hello @lschurr , i accepted the invitation,  Thank you 😊

Payment sent. Closing!


Class Mosquiito\Client not found in my program

using php 5.5 and setting like ur READM.md
but Class Mosquiito\Client not found.
in my php.ini

Should i add this line in my php.ini file?

hi, did you get this working? @dev-chulbuji

Ok, it worked for me when I updated the php.ini for cli. in my case it's here: /etc/php5/cli/php.ini

You spelled "Mosquiito\Client" wrong, its one i and two tt's

Hi, even i am facing the same issue
I am using Ubuntu 16.04 and followed all the above instruction
I am facing same problem and have added the extension=mosquitto.so in my php.ini which is located in /etc/php/php5.6/cli/php.ini
Just to confirm the location of php.ini, i ran below command
command : php --ini
result :


Social Media Manager

We need a Contributor that will love to post updates about KwickerHub on Facebook,Twitter and even Instagram
Be rest assured that you will be come a maintainer and part of our core team.

I would really love to work on this
I can create infographics, banners and short videos on the project.

That will be awesome. how many short videos are we looking at?
If given details to our Twitter, Instagram, Facebook Page can you manage it? Do you have some knowledge about Facebook advertising?

Two videos on Instagram and Twitter
Then infographics and banners on Facebook.
Hmmm about Facebook advertising I will look that up

About managing the pages I can absolutely do that

Hello @johnwinifred We can talk more on a messaging platform like WhatsApp, +2349097441316. i will be closing this issue.

Ok


go: support FreeBSD

Description of changes
Simply marking support and re-downloading the hashes is enough to get everything to work. Tests were done by compiling syncthing.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin
[x] x86_64-freebsd

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Does this only work with native compilation?
This fails for me so far:
nix-build -A pkgsCross.x86_64-freebsd.go
error:
       … while calling the 'derivationStrict' builtin
         at <nix/derivation-internal.nix>:9:12:
            8|
            9|   strict = derivationStrict drvAttrs;
             |            ^
           10|

       … while evaluating derivation 'go-x86_64-unknown-freebsd-1.22.5'
         whose name attribute is located at /home/joerg/git/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:334:7

       … while evaluating attribute 'CC_FOR_TARGET' of derivation 'go-x86_64-unknown-freebsd-1.22.5'
         at /home/joerg/git/nixpkgs/pkgs/development/compilers/go/1.22.nix:104:3:
          103|   # to be different from CC/CXX
          104|   CC_FOR_TARGET =
             |   ^
          105|     if isCross then

       (stack trace truncated; use '--show-trace' to show the full, detailed trace)

       error: infinite recursion encountered
       at /home/joerg/git/nixpkgs/pkgs/os-specific/bsd/freebsd/pkgs/mkDerivation.nix:85:27:
           84|     // lib.optionalAttrs stdenv'.isDarwin { MKRELRO = "no"; }
           85|     // lib.optionalAttrs (stdenv'.cc.isClang or false) {
             |                           ^
           86|       HAVE_LLVM = lib.versions.major (lib.getVersion stdenv'.cc.cc);
┏━ 1 Errors:
┃ error:
┃        … while calling the 'derivationStrict' builtin
┃          at <nix/derivation-internal.nix>:9:12:
┃             8|
┃             9|   strict = derivationStrict drvAttrs;
┃              |            ^
┃            10|
┃
┃        … while evaluating derivation 'go-x86_64-unknown-freebsd-1.22.5'
┃          whose name attribute is located at /home/joerg/git/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:334:7
┃
┃        … while evaluating attribute 'CC_FOR_TARGET' of derivation 'go-x86_64-unknown-freebsd-1.22.5'
┃          at /home/joerg/git/nixpkgs/pkgs/development/compilers/go/1.22.nix:104:3:
┃           103|   # to be different from CC/CXX
┃           104|   CC_FOR_TARGET =
┃              |   ^
┃           105|     if isCross then
┃
┃        (stack trace truncated; use '--show-trace' to show the full, detailed trace)
┃
┃        error: infinite recursion encountered
┃        at /home/joerg/git/nixpkgs/pkgs/os-specific/bsd/freebsd/pkgs/mkDerivation.nix:85:27:
┃            84|     // lib.optionalAttrs stdenv'.isDarwin { MKRELRO = "no"; }
┃            85|     // lib.optionalAttrs (stdenv'.cc.isClang or false) {
┃              |                           ^
┃            86|       HAVE_LLVM = lib.versions.major (lib.getVersion stdenv'.cc.cc);
┣━━━
┗━ ∑ ⚠ Exited with 1 errors reported by nix at 19:06:55 after 0s

All of FreeBSD cross is broken pending https://github.com/NixOS/nixpkgs/pull/327815 but on my staging branch with all my pending PRs merged, I can confirm that I can build go programs for FreeBSD cross successfully :)

But yes, it also works native.


Exam mode: Fix exam test run summary

Checklist
General

[x] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Client

[x] I followed the coding and design guidelines and ensured that the layout is responsive.
[x] Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
[x] I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
[x] I documented the TypeScript code using JSDoc style.

Motivation and Context

Issue #5675
Description

When the exam is submitted during a test run, the user is forwarded to the exam summary page.
Furthermore, the "Review is open" alert is hidden for test runs.
Steps for Testing

Prerequisites:

1 Instructor, 1 Student
1 Exam with multiple exercises of all kind

Log in to Artemis
Navigate to the Exam
Create a Test Run
Participate in the Test Run
Ensure you are forwarded to /course-management/x/exams/x/test-runs/x/summary when the exam is over/you submit the exam
Check that the "Review is open" alert no longer appears on the summary page
Ensure that normal exam conduction is unaffected

Review Progress

Code Review

[x] Review 1
[x] Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Test Coverage

Added a test case for the routing redirect.
Screenshots

@manuelmanso Looks like that was just a flaky test, all green now.

Looks good! Redirection to /course-management/id/exams/id/test-runs/id/summary works and no "Review is open" alert is shown.


Mobile: Redesign input to consider touch events

Also, we might need a combination of possible input triggers, e.g. a key on desktop while something else on mobile

Mouse button is mapped to tap on mobile. So we primarily need key events to have alternatives. Zoom, Rotate and Scroll events are not useful since alternatives are hard on desktop. So:
addAction(..., KeyCode.A, alternative = Touch.SWIPE_RIGHT);


Contact us not visible in dark mode

As you can see the contact us is not visible in dark mode
Please assign this issue to me under the tag of gssoc ext and hacktoberfest

Closed via #719


Remove strace

High-level description
It looks like strace is not used and can be removed.
Corresponding DC/OS tickets (required)

D2IQ-ID JIRA title / short description.

Related tickets (optional)

D2IQ-ID JIRA title / short description.

@mesosphere-mergebot test

@mesosphere-mergebot test all


Fix typo in LGBMClassifier

ha, great find

Coverage decreased (-0.1%) to 80.187% when pulling 8ea0f4f49287974937d9671b8c8a17f75d6638eb on raghavr186:patch-1 into 406d9f3980298a9e5321438e8322572808d179c8 on ClimbsRocks:master.


React hot module replacement doesn’t when using Happypack

Hello there, Happypack breaks somehow Webpack HMR when updating React components like this:
[HMR] The following modules couldn't be hot updated: (Full reload needed)
This is usually because the modules which have changed (and their parents) do not know how to hot reload themselves.

Does anybody know how to make things working well when using both Happypack and Webpack’s HMR? Or what could go wrong?

Are you using webpack-hot-middleware or something else? Can you share some configs please?

Excuse me for loooong delay. I’m using react-hot-loader.

Did you figure this out? It's likely a configuration issue which is hard to help you with if you won't provide the config.
I have recently had to use happypack with a project that uses HMR (with react-hot-loader + webpack-hot-middleware) and it's been working just fine.

I'm also able to use react hot loader 1 (GA version, not beta) with happypack. Need to include 'react-hot' in the jsx loader list and 'webpack/hot/only-dev-server' and 'webpack-hot-middleware/client' at the beginning of the entry list
I also use 'react-hmre' in the babelrc development presets

Thanks for reporting @todd-richmond.
I'm gonna close this since it doesn't look like an issue, but feel free to re-open if you find out otherwise.

@todd-richmond can you share your webpack config?
or what solved your problem?


code style, keep CamelCase: change variable name from podcontroller to podController

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[x] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.
Subject
change variable name from podcontroller to podController like following nodeController
Problem
It's better to keep consistency of code style, declaring variable name camelCase or CamelCase.

Hi @wangchenglong01. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test


Update doc to recommend Miniforge

Closes #1678.
Contributor Checklist:

[x] I have added or updated my entry in the creators.json file
[x] I have added/updated documentation for all user-facing changes

Reviewer Checklist:

[ ] /azp run libertem.libertem-data passed
[x] No import of GPL code from MIT code

26fa4e4ae5a0f4760a4897fa1f0050651c7a8895 👀 sorry !

26fa4e4 👀 sorry !

Haha no worries :)


LOGO on the menu pane do not appear sometimes

## LOGO in the menu pane do not appear sometimes.
LOGO on the menu pane should be changed to FOSSASIA logo from twitter and the bug in it should be fixed that it should appear offline.

It may be due to slow data connection because we have an image there already. Closing this issue


Support for untagged sonar data has bitrotted

I'd like to keep maintaining this code for a while, since sonar is currently deployed on eg Saga and is producing data there in the old format.
TODO here:

[ ] Fix the code
[ ] Fix the tests
[ ] Make sure the tests are run as part of our regular integration tests, there's some way to force cargo test to do this

A tricky problem here is that untagged data do not carry a PID, and the PID is used to construct various keys.  It looks like this may be fixable by copying the job ID into the PID.


Fix/unsync package

https://github.com/kuka-js/kuka/runs/2016042029?check_suite_focus=true
npm ERR! cipm can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.
npm ERR! Invalid: lock file's<EMAIL_ADDRESS>does not satisfy<EMAIL_ADDRESS>

:tada: This PR is included in version @kuka-js/serverless-v1.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix link in docs

It looks like this right now...

@Xantier  Could you do that again please. I'm a dolt


🐦 Tweet about v0.39.0 🐦

Context
I've implemented CI on the chocolatey repos and releasing the v0.39.0 cf https://github.com/adriens/chocolatey-kapp/issues/6
Once moderated, I'd like to retweet the official release annoucement, but for now, I only have the v0.38.0 one.
Action

[x] Can you please tweet about the v0.39.0 release ?

Thanks @adriens for bringing this up.
cc: @microwavables

@adriens here ya go! thank you! https://twitter.com/carvel_dev/status/1433409493291896834?s=20

Thanks, I'll retweet it today 😺

Here we go https://twitter.com/rastadidi/status/1433546675327422465


chore: use ticker instead of sleep in retrier

Overview

Checklist

[ ] New and updated code has appropriate documentation
[ ] New and updated code has new and/or updated testing
[ ] Required CI checks are passing
[ ] Visual proof for any user facing features like CLI or documentation updates
[ ] Linked issues closed with keywords

CI will be fixed by this: https://github.com/celestiaorg/orchestrator-relayer/pull/256


TLS support

Exposes connect.tls.enabled and connect.tls.secret to enable TLS for the Connect server. The connect.tls.secret should contain the name of a secret that contains tls.key and tls.crt value (as is standard for TLS configuration in Kubernetes).
One point for consideration: do we want to use connect.tls.secret or connect.tls.secretName?

Alternative implementation: add an Ingress (which, in combination with external-dns and cert-manager, can auto-provision both DNS and Let's Encrypt certs)

Suggestion for alternative implementation: add an Ingress (which, in combination with external-dns and cert-manager, can auto-provision both DNS and Let's Encrypt certs)

Thank you for your suggestion. We are considering this. Because having the option to use the built-in TLS-feature of Connect has value on its own, I am merging as is for now.

For future ref: this is our ingress definition, works without any issues:
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  annotations:
    cert-manager.io/cluster-issuer: letsencrypt
    kubernetes.io/ingress.class: nginx
    nginx.ingress.kubernetes.io/force-ssl-redirect: "true"
  name: onepassword-connect
  namespace: onepassword
spec:
  rules:
  - host: onepassword.XXXXXX
    http:
      paths:
      - backend:
          serviceName: onepassword-connect
          servicePort: 8080
        path: /
  tls:
  - hosts:
    - onepassword.XXXXXXX
    secretName: onepassword.XXXXXX-certificate


typo in README.md

Hi @JoanFM ,  thank you for fixing this! may I ask you to send us a CLA: https://github.com/triton-inference-server/server/blob/main/CONTRIBUTING.md#contributor-license-agreement-cla ?

Hello,
My first time commenting on GitHub,
So excuse me on wrong people or place I am commenting on in advance.
In this README.md in the first step "Deploying a PyTorch Model" is mentioned to run "python export.py" but the docker does not have such file. Here is the command I used for the docker as suggested:
docker run -it --gpus all -v ${PWD}:/workspace nvcr.io/nvidia/pytorch:22.04-py3
Thanks in advance for your help,
Amir

Hi @amirhp110 , make sure to run docker run -it --gpus all -v ${PWD}:/workspace nvcr.io/nvidia/pytorch:22.04-py3 from the downloaded folder PyTorch. This folder contains export.py: https://github.com/triton-inference-server/tutorials/blob/main/Quick_Deploy/PyTorch/export.py


Facing ssl error while sending https request to opentaxii

Hi,
I am facing ssl error on trying to send a discovery request with https binding, I am using libtaxii as client, what could be the issue? doesnt opentaxii support https? how to make this certificate validation work?
stuck on this issue for quite long time,..any leads would be helpful.
root@vatd:~# discovery_client -u https://<IP_ADDRESS>:9001/services/discovery-a
Request:
Message Type: Discovery_Request
Message ID:<PHONE_NUMBER>629755912
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/libtaxii-1.1.111-py2.7.egg/libtaxii/scripts/init.py", line 375, in call
url.port)
File "/usr/lib/python2.7/site-packages/libtaxii-1.1.111-py2.7.egg/libtaxii/clients.py", line 346, in call_taxii_service2
response = urllib.request.urlopen(req)
File "/usr/lib64/python2.7/urllib2.py", line 154, in urlopen
return opener.open(url, data, timeout)
File "/usr/lib64/python2.7/urllib2.py", line 429, in open
response = self._open(req, data)
File "/usr/lib64/python2.7/urllib2.py", line 447, in _open
'_open', req)
File "/usr/lib64/python2.7/urllib2.py", line 407, in _call_chain
result = func(*args)
File "/usr/lib/python2.7/site-packages/libtaxii-1.1.111-py2.7.egg/libtaxii/clients.py", line 374, in https_open
return self.do_open(self.get_connection, req)
File "/usr/lib64/python2.7/urllib2.py", line 1200, in do_open
raise URLError(err)
URLError: <urlopen error EOF occurred in violation of protocol (_ssl.c:590)>

@VibhavariMandal as I said in the other thread, OpenTAXII does not do SSL verification. It has to be running behind a webserver as recommended in documentation. This webserver will take care of HTTPS setup


Loggin screen fix IE11

TP: https://rockabox.tpondemand.com/entity/10806

@rockabox/qa over to you to set for merge :+1:


sending output via udp

Checklist

[X] I've read the contribution guidelines.
[X] I've searched other issues and no duplicate issues were found.
[X] I've agreed with the maintainers that I can plan this task.

Description
i have managed to run autoware in jetson AGX and everything seems to work well!
the only thing I am looking for is that how to send the output of the lidar via UDP!
what I mean is that I used autoware to detect and track objects using lidar only
is there any way to make the output send thro udp
like xyz
Purpose
to run with a new contral unit
Possible approaches
using autoware with different robot not only a car
Definition of done
autwoare is installed

As mentioned in the support guideline, we are using Github issue as a place to track bugs and tasks. If you have question, GitHub Discussions is a better place.
https://github.com/autowarefoundation/autoware/discussions/categories/q-a
As a short answer to your question, if you want to see the LiDAR data, ROS2 natively supports communication between multiple machines by setting the same ROS_DOMAIN_ID

I opened it the same day I posted this issue!
https://github.com/autowarefoundation/autoware/discussions/2818
could that happned with ROS1?

Checkout http://wiki.ros.org/ROS/Tutorials/MultipleMachines


E2E: Add invalidate cache API command

Summary
This solves the issue where the enterprise features don't immediately unlock after a license is uploaded against a docker image.
Ticket Link
JIRA ticket - https://mattermost.atlassian.net/browse/MM-24765

/update-branch

@prapti Please take a look, thanks


onBegin is not invoked after a Prompts dialog ends

I am using NodeJS v3.2.3.
Code:
bot.dialog('/', new builder.IntentDialog()
  .onBegin(function (session, args, next) {
    console.log("onBegin: " + session.message.text);
    next();
  })
  .matches(/^hello/i, '/hello')
  .matches(/^bye/i, '/bye')
  .onDefault(function (session) {
    session.send("I didn't understand. Say hello to me!");
  }));

bot.dialog('/hello', [
  function (session) {
    builder.Prompts.text(session, "Hi there! How may I help?");
  },
  function (session) {
    session.endDialog("Okay, got it!");
  }
]);

bot.dialog('/bye', [
  function (session) {
    session.endDialog("Good Bye");
  }
]);

Conversation (user input only):
bye -> onBegin is invoked
hello --> onBegin is invoked
thank you
bye --> This does not invoke onBegin

So I looked at the code in Prompts.js and found that all the builder.Prompts convenience methods (text|choice,etc) create a new dialog.
If I invoke endDialog twice after every builder.Prompts, then onBegin will be invoked properly.
e.g. Replacing the /hello dialog above with the one below will fix the problem.
bot.dialog('/hello', [
  function (session) {
    builder.Prompts.text(session, "Hi there! How may I help?");
  },
  function (session) {
    session.endDialog("Okay, got it!");
    session.endDialog();
  }
]);

It's basically because you're using the  version of matches() which launches a dialog but isn't going to automatically end the IntentDialog when that dialog returns. That's by design and I'm happy to dive into why its by design (you're assuming the IntentDialog is always used at the root which isn't always the case.)  To achieve your desired behavior you should use a waterfall to start your dialogs instead:
bot.dialog('/', new builder.IntentDialog()
  .onBegin(function (session, args, next) {
    console.log("onBegin: " + session.message.text);
    next();
  })
  .matches(/^hello/i, function (session) {
     session.beginDialog('/hello');
  })
  .matches(/^bye/i, function (session) {
     session.beginDialog('/bye');
  })
  .onDefault(function (session) {
    session.send("I didn't understand. Say hello to me!");
  }));

I can think about making the simpler form work like that.  To be honest though in v3.5 there's not a lot of need to use IntentDialog anymore.  Can I ask what you're trying to do in onBegin()?

I was just following the documentation:
bot.dialog('/', new builder.IntentDialog()
    .matches(/^add/i, '/addTask')
    .matches(/^change/i, '/changeTask')
    .matches(/^delete/i, '/deleteTask')
    .onDefault(builder.DialogAction.send("I'm sorry. I didn't understand."))
);

What should I use to identify the intent without using IntentDialog ?
I use onBegin mainly for logging.

You'd be better off writing a piece of middleware to do logging. Version 3.5 hasn't shipped yet so I'm still working on re-writing the docs.

Is middleware executed before intent identification?  I wanna log the intent.

Also, does that mean
bot.dialog('/', new builder.IntentDialog()
    .matches(/^add/i, '/addTask')
    .matches(/^change/i, '/changeTask')
    .matches(/^delete/i, '/deleteTask')
    .onDefault(builder.DialogAction.send("I'm sorry. I didn't understand."))
);

is not the right way to build an intent dialog bot even for Version 3.2.3?
Then it is a documentation bug?

Yes...Middleware is run for every incoming request. That's the correct way to use an IntentDialog, I'm just saying that if what your trying to do is log incoming messages you should use middleware for that.

I want to log after the intent is identified. So I don't think middleware can be used.

What is the way to write this in version 3.5, then? If not using IntentDialogs?

In 3.5+ you'd add a triggerAction() to each of your dialogs and to enable logging you can add an onSelectAction handler for your trigger that logs the fact your dialog as triggered.

Closing this for now. Please feel free to add further comments.


How to get data into vector of user-defined type from a Json object

Anyone here who can help me on urgent basis,i shall be very very thankful to him/her, I am in a big trouble due to this kindly help me
i want to store "Configurations" data into  vector result.
where
class myclass{
string name;
string def;
string type;
string validation;
};

and my Json data is in nlohmann::Json object "Jdata" is as follows
{
    "Configuration":[
                                 {
	                               "Name":"FirstName",
	                               "Def":"DB('F_NAME')",
	                               "Type":"String",
	                               "Validation":""
                                 },
                                {
	                              "Name":"Age",
	                              "Def":"RANGE(MIN,MAX)",
                                      "Type":"Integar",
	                              "Validation":""
                                 },
                                {
	                              "Name":"DAY",
	                              "Def":"ENUM('MON','TUE','WED','THU','FRI','SAT','SUN')",
	                              "Type":"String",
	                              "Validation":""
                                }

                            ],
	"Input Configuration":[{"Name":"Fields"},{"Name":"Options"}]
}

please @nlohmann  kindly help me or assign anyone else who can help me

Please see https://github.com/nlohmann/json#arbitrary-types-conversions.

@nlohmann  could you please expand on your answer. I did check out the arbitary type conversion but it is not giving me enough information. How do we parse json into a std::vector... the get_to doesn't accept std::vector...

You can only parse into a JSON value (the parse function returns json, and the conversions go from/to json). In the example, after parsing the JSON`, you could have code like:
std::ifstream myinput("myfile.json");
auto j = json::parse(myinput);

std::vector<myclass> v = j["Configuration"];


setState calls that are ignored by shouldUpdate do not update self.state

If a state update is started by calling self.setState in a stateful component that has shouldUpdate defined, and shouldUpdate returns false, the state update is completely discarded.
This is a behavior divergence from React, where state will be updated but the component will not be re-rendered.
Here's a React code sample that demonstrates this difference:
class App extends React.Component {
  constructor() {
    super();
    this.state = { x: 6 };
  }

  shouldComponentUpdate() {
    return false;
  }

  render() {
    return (
      <button onClick={ () => this.setState({ x: 5 }) }>
        click: { this.state.x }
      </button>
    );
  }

  componentDidMount() {
    setInterval(() => {
      console.log(this.state)
    }, 1000);
  }
}

React.render(<App />, document.getElementById('app'));

Before clicking the button, {x: 6} should be printed repeatedly, but after clicking it, {x: 5} will be printed instead without the button updating its text.
The equivalent code using Roact would continue to print {x: 6} even after the button is pressed.

Should just be a matter of moving these 2 lines to before L433, right?
https://github.com/Roblox/roact/blob/deaa8000220252f6edc27ec15e5704266560ebe5/src/Component.lua#L450-L451


mqtt light (2nd entry) not showing on home assistant

light:

platform: mqtt_json
name: mqtt_json_light_1
state_topic: "home/rgb1"
command_topic: "home/rgb1/set"
brightness: true
rgb: true
effect: true
effect_list: [colorfade_slow, colorfade_fast, flash]
optimistic: false
qos: 0
name: mqtt_json_light_2
state_topic: "home/rgb2"
command_topic: "home/rgb2/set"
brightness: true
rgb: true
effect: true
effect_list: [colorfade_slow, colorfade_fast, flash]
optimistic: false
qos: 0

Can you/anyone please assistant me what I am doing wrong.
I had compile the code no error, home assistant load perfectly but LED Switch is showing only for mqtt_json_light_2.
thanks
AA

@AAli77 For future reference, when you post your code on Github you can wrap it in three backtick (`) characters to make Github format it as code and keep the original formatting. You can also use the code button in the comment editor (< >). For example:
```
# CODE
```

To your question:
Here's a sample of multiple mqtt_json lights from my own configuration.
If I'm reading your configuration correctly, it looks like you are only listing the platform once and you have both lights in the same list item. Note how in my configuration the - platform: mqtt_json line is repeated at the beginning of each light. That lets Home Assistant know you are creating a second light.

Thank you Sir, I will try your code. And also thanks a lot for your quick response


[RFE] Create a yaml replacement for Restricted Admin

Is your feature request related to a problem? Please describe.
The built in Global Role "Restricted Admin" has been in the process of being deprecated for several versions. It's an important role for certain use cases like Harvester and hosted Rancher. Before fully deprecating we need a replacement.
Describe the solution you'd like
Global Roles have had a lot of work done in the last 2 releases to enhance their functionality with new fields. Those fields can completely replicate the restricted admin functionality.
We would like a yaml that can be applied that provides the same experience as Restricted Admin. That way we can simply apply it for use cases where it's necessary.
Describe alternatives you've considered
Keeping Restricted Admin is not really an option because it has repeatedly been found to have security issues or bugs.
In 2.10 we don't have the capacity to add the new fields into the UI to allow users to configure it themselves, and that method also could lead to incorrectly made Restricted Admin replacements.
Additional context
Add any other context or screenshots about the feature request here.

@raulcabello lets put it here: https://github.com/rancherlabs/engineering-infra/tree/main/docs
I will also create a issue for docs team to add to prime docs

I successfully created a custom role inspired from Restricted Administrator role:
https://ranchermanager.docs.rancher.com/how-to-guides/new-user-guides/authentication-permissions-and-global-configuration/manage-role-based-access-control-rbac/custom-roles
https://ranchermanager.docs.rancher.com/how-to-guides/new-user-guides/authentication-permissions-and-global-configuration/manage-role-based-access-control-rbac/global-permissions
I created custom role without any resource, then I edited as yaml and I added the rules: section from Restricted Administrator yaml, and added
inheritedClusterRoles:
- cluster-owner

It seems to work.
You can find a resulting new-restricted-admin.yaml example.
new-restricted-admin.zip

Related dashboard: https://github.com/rancher/dashboard/issues/12146

Validated on v2.10-head id 14a48bc successfully.
Added qa-task for automation.

this was resolved in 2.10 but that milestone was closed so I cannot add it to it


Network Graph Analysis learning spike

Goals:

[ ]

@cdolfi I think this should be closed- should create a spike later to address this

@JamesKunstle sure that sounds good to me


Navbar toggle button not working on "About" and "Login" page.

🐛 Bug Report
The navbar toggle button for small screen sizes is not working in the "about" and "login" pages.

The navbar is not expanding on clicking the icon.
I would like to work on this issue.

/assign


Add Glide task

This adds a separate task to allow using Glide as the dependency manager instead of GoDep.

If it's alright, I have two suggestions:

The copyright info on the files you made has your name -- I would rather all files be consistent and say "HandcraftedBits", but I'll add a CONTRIBUTORS file with your information.
I'd like to use this as a basis to create a more generic dependency task that lets you select between multiple tools, in this case godep and glide, rather than a separate task for godep and a separate task for glide.

Does that sound reasonable?  Thanks for the contribution BTW.

That's perfectly fine by me. I'll take a look at this again to find a good way to combine them.

Hi,
Correct me if i'm wrong as I am new to Glide, but I think you might have to update the test runner as well. One issue I encountered with it, when running tests, is that if you use the flag -v ./..., it will run the test inside the vendor folder unless you do something like go test $(glide nv)


SSL error while batch load from http uri file

Bath load from a https uri fails with SSL error.
Error:Failed to sample data:javax.net.ssl.SSLHandshakeException:sun.security.validator.ValidatorException:PXIX path building failed:sun.security.provider.certpath.SunCertPathBuilderException:unable to find valid certification path to requested target
Affected Version
0.18.0
Description
Single node druid implementation
Http uri is ssl enabled and i have the certificates added to truststore file. But ibhave confusion on the druid parameter tp which the truststore should be added in.
I have tried adding the truststore in following 2 ways but they didn't work
Option1:druid.indexer.runner.javaOpts= -Djavax.net.ssl.trustStore=/path/truststore.jks -Djavax.net.ssl.trustStorePassword=
Option2:druid.client.https.trustStorePath=/path/truststore.jks(added password and type too)
But both options didn' work.
Please help with proper way to mention the certificate for https URI in druid configuration

*Batch load
Sample Https uri: https:///path/testfile.json


Tag and push all releases to supermarket

Would be nice if it's not too much trouble, so we're not pulling from github in our berksfiles

Give me some time to evaluate this part of workflow. I've never release on / push to Chef supermarket. Can you give me some references to do this?

Hm. I've been doing it a complicated way, but you instigated me to do some research, and this seems much better (though I haven't used it):
https://github.com/sethvargo/stove

see: https://supermarket.chef.io/cookbooks/test-helper

FYI: stove was really helpful which is so easy ...

Yay!


Integration test for 'istioctl proxy-config'

Mitigates https://github.com/istio/istio/issues/20714 by ensuring that istioctl proxy-config can handle Envoy configuration for the version that auto-inject is using.

@esnible: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
4fc26c1cea8d6269406a828e69d4570def003b6a
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@esnible: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
4fc26c1cea8d6269406a828e69d4570def003b6a
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
4fc26c1cea8d6269406a828e69d4570def003b6a
link
/test integ-pilot-k8s-tests_istio

integ-istioio-k8s-tests_istio
00a4abac589b1eb69732652d6108c1c0b3b7aced
link
/test integ-istioio-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-istioio-k8s-tests_istio
00a4abac589b1eb69732652d6108c1c0b3b7aced
link
/test integ-istioio-k8s-tests_istio

integ-pilot-k8s-tests_istio
00a4abac589b1eb69732652d6108c1c0b3b7aced
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
00167a509af26fa9d7f70c7d58abc8cd3619cbb7
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn I traced the flakiness to use of a global variable for the namespace.  The flakiness also affected the TestDescribe test.  The istioctl tests should be good now.  Please re-review.

/retest

@howardjohn Can you re-review?

On the commit that claims to fix the flake, the test failed: https://prow.istio.io/view/gcs/istio-prow/pr-logs/pull/istio_istio/20876/integ-pilot-k8s-tests_istio/7845, so I think the flake is still an issue.
/test integ-pilot-k8s-tests_istio

@howardjohn I don't think the test is flakey.
I noticed that creating this test made another test flakey and have mitigated it.  The problem is there is a global "namespace" flag in istioctl which can cause problems if tests are run in parallel.
Do you have any ideas on how to get it to flake?  Or can we mark it as "maybe flakey" so we can get more information?

/test integ-pilot-k8s-tests_istio

You can see from this that one the same commit, the test failed 1 time and passed 2 times. That seems to imply its flaky to me

@howardjohn I need your guidance.  https://prow.istio.io/view/gcs/istio-prow/pr-logs/pull/istio_istio/20876/integ-pilot-k8s-tests_istio/7845 shows TestDescribe failing.  This is a problem because at that point it hadn't changed.  Adding TestProxyConfig made TestDescribe fail because the framework ran the two tests in parallel and they shared a global namespace variable.
I believe this has been mitigated.  If not, I want to just eliminate the global variable but I wasn't sure if that change should be part of a test PR.  I did make a small change to make it unlikely the global variable sharing could cause trouble.  The other possibility is to serialize the tests somehow, but I thought that would slow things down for everyone.

https://github.com/istio/istio/pull/21311 @esnible I spent a few days debugging why test add to mesh remove from mesh is flaky (#21003) and I noticed some times it failed because test described failed, and sometimes it ran a bit too fast before all containers are up running.  So I end up making sure the service is callable before running any istioctl cmds.

@howardjohn The commit that fixed the flake caused another test to flake.  The sum total of this PR has not flaked.

@esnible: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
30c1fa3f8b43d9d2a95d13f8fd25b7669c8a1c03
link
/test integ-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@esnible: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
30c1fa3f8b43d9d2a95d13f8fd25b7669c8a1c03
link
/test integ-local-tests_istio

lint_istio
9c8b2dbe2e59700fd019a3919e3822858ed44fc7
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test lint_istio

@liamawhite @ayj Need review for istioctl changes from @wg-user-experience-maintainers
The istioctl change is to keep the -o <value> output format local to each command instead of being shared, which helps with test flakes when tests with different output format run in parallel out of the same binary.


Replace Future#promise in favor of Future#then

Current coverage is 100.00%

Merging #1 into develop will not affect coverage as of 84b1335

@@            develop      #1   diff @@
=======================================
  Files             1       1
  Stmts           244     244
  Branches         63      64     +1
  Methods           0       0
=======================================
  Hit             244     244
  Partial           0       0
  Missed            0       0

Review entire Coverage Diff as of 84b1335

Powered by Codecov. Updated on successful CI builds.


View list of volunteer and elderly befriendee contacts

As a voluntary organisation manager, I can view a full list of volunteer and elderly befriendee contacts, so that I can keep track of the volunteers I am managing as well as the elderly befriendees we are serving.

Add two boxes for both Person types

#47


Warnings in registry-k8s logs

The logs of registry-k8s contains the following warnings from time to time:
W1129 08:04:22.757792       1 warnings.go:70] unknown field "status"
W1129 08:04:28.957701       1 warnings.go:70] unknown field "status"

It seems a warning cannot be printed out because of the unknown field.
I observed the same behavior in NSM 1.10.0 up to 1.11.2-rc.1 when just running the kernel2ethernet2kernel example, but I found it in logs received from other environments too.

Hi
I think the problem is the missing status here:
diff --git a/apps/registry-k8s/crd-nse.yaml b/apps/registry-k8s/crd-nse.yaml
index fde462a8dd8..3367c6d78a6 100644
--- a/apps/registry-k8s/crd-nse.yaml
+++ b/apps/registry-k8s/crd-nse.yaml
@@ -26,3 +26,5 @@ spec:
           properties:
             spec:
               x-kubernetes-preserve-unknown-fields: true
+            status:
+              x-kubernetes-preserve-unknown-fields: true

In a bit more detail, the structs used in
types.go
does not match the ones in
crd-nse.yaml
Now its a bit weird as NetworkService struct too has a Status field and no warning was printed out, I guess kubernetes is not so fussy about an empty struct.
Also I couldn't really find where or how these Status fields are used in nsm, so If they aren't used anywhere, then removing them from the struct could also be a possible fix.
(I checked both, either adding the upper field to the yaml, or removing the Status field from types.go, seemed to make the warnings disappear)

Hello, @arp-est,
Thanks for doing this.
From my point of view, the problem with generating status fields comes from https://github.com/networkservicemesh/sdk-k8s/blob/771dae1f75a5a96c110a4fceccef4bf4e80ea36c/pkg/tools/k8s/gen.go#L19-L24.
We can start by looking at the K8S generator and trying to play with it to prevent generating status fields.
If it's not possible, then we can merge your suggested patch with adding the status field to both nses and ns.
After that, I think we could create a separate ticket with removing x-kubernetes-preserve-unknown-fields: true and defining the nse/ns model schemes.

I'll summarize my findings,
So I think that removing the staus field, could be as simple as removing them from types.go.
Now I see that at the top in 'types.go' it states in a comment that "// Code generated by client-gen. DO NOT EDIT.", but
based on the docs I've read up so far, and actually running the code generator I came to the conclusion that this comment is likely false.
According to these documents:
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-api-machinery/generating-clientset.md
https://www.redhat.com/en/blog/kubernetes-deep-dive-code-generation-customresources
The client-gen is only used to generate stuff under the 'client' folder, and the deepcopy function and is based on the contents of types.go.
Also when running gen.go, you can observe the same behaviour, that the deepcopy, and client code is generated, but types.go is not.
Thirdly the license headers are also different, the dates do not match, let's say between the deepcopy and types.go.
A bit different topic, but here, they frame the stentence in a way, that having a status field is the recommendation, while not necessary.
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#objects

All objects that represent a physical resource whose state may vary from the user's desired intent SHOULD have a spec and a status. Objects whose state cannot vary from the user's desired intent MAY have only spec, and MAY rename spec to a more appropriate name.

So overall I think its a lot less painful to just go with the first thought, and add the field to the crd yamls :'D
What do you think?

Fixed with version v1.14.0.
@arp-est Thanks!


In-memory cache (BaseCache) not thread-safe

Hi,
I'm using requests-cache to create an in-memory cache, using BaseCache. BaseCache is not thread-safe, as a simultaneous remove_old_entries() and save_response() or delete() might cause the following error:

RuntimeError: dictionary changed size during iteration

Initially, I've solved this by putting a lock on my code which calls clear() on the cache, and get() and send() on the requests module. However, this problem came back to haunt me once a 3rd party module which also imports and uses requests was introduced. Since I don't want to go hunting every possible inner use of the requests module, I feel that this needs to be solved inside the BaseCache.

Hi @borisdan, I'm not the repo owner, but I have collaborator access via Code Shelter, and I'm trying to blow the dust off this project after being dormant for awhile. I merged your PR #85 ; do you have any other thoughts on improving the thread-safety of BaseCache or any of the persistent backends? Any pointers or additional PRs would be appreciated!

Great @JWCook ! Excellent initiative. I don't have any more outstanding items at the moment.
Is there a plan to do a new release soon?

Yes! I'm not sure how soon, which depends on how much help I can get, but I've started putting the most relevant maintenance issues under the v0.6 milestone.


Check if vibration duration is > 0 on Android

If you would call OS.vibrate_handheld(0) (can e.g. happen when downcasted from float) the game would crash with an exception. I opted to fix it on the Java side, so we don't break behaviour on iOS (which ignores the duration and just vibrates for a fixed amount of time).

Thanks for the fix!

Cherry-picked for 3.4.

Cherry-picked for 3.3.4.


Tech request: Blockbaud

ran into wappalyzer not detecting this today:
https://www.blackbaud.com/
i'll try to take a closer look at this at some point to find some clear identifiers, but i haven't worked with this so can't say for sure right now.

You were probably running into the bug many people were with the last major update: Issue https://github.com/AliasIO/wappalyzer/issues/3159
The site you listed is running Sitefinity for its CMS and Marketo for marketing automation (among other analytics & tracking tools).

Added, thanks!


Add functionality to set/get state of embed suppression

Pull Request Etiquette

[x] I have checked the PRs for upcoming features/bug fixes.
[x] I have read the contributing guidelines.

Changes

[x] Internal code
[x] Library interface (affecting end-user code)
[ ] Documentation
[ ] Other: _____

Description
Adds the possibility to check for and set Embed suppression via 3 new methods on Message.
Also adds a new Enum: MessageFlags that cand hold various flags (like suppression state).
This PR is on hold until the suppression endpoint is confirmed stable and ready:
https://github.com/discordapp/discord-api-docs/pull/1003

Any update on this?

Uh... gonna fix the conflicts but as far as i remember, it was basically done

@MinnDevelopment should be ready to review


Automatic segment redefines filtering

Hi Ruslan
After having managed to read in our custom variable record length files, we move on to efficiently loading the data into Spark.
Therefore, we intend to use automatic segment redefines filtering.
Imagine the following set-up:
.option("segment_field", "SEGMENT")
.option("segment_id_level0", "0")
.option("segment_id_level1", "1")
.option("segment_id_level2", "2")
.option("redefine_segment_id_map:0", "HEADER_RECORD => "0")
.option("redefine_segment_id_map:1", "DATA_RECORD => "1")
.option("redefine_segment_id_map:2", "TRAILER_RECORD => "2")

Note that SEGMENT field values as well as the correspondent maps are tested and correct.
This example is following the guide in the docs closely. In fact, we would not need to specify the SEGMENT field values explicitly, they are already given.
From above setting we would expect the following outcome:

However, this is the effective output:

So, no setting irrelevant info to NULL.
If you'd need real data and metadata, you could use the material I sent you before. Together with our custom header parser implementation, it should be possible to reproduce the issue.

Thanks for raising the issue. Will try to reproduce the issue without a custom header parser first. If it won't work, will ask you for your custom header parser implementation.
What is the size of the header in your custom record header parser? For RDWs it is 4 bytes. But if I remember correctly you have a much bigger header.

Checked the code and the corresponding test. The way how segment id to redefine maps work should not be affected by a custom record header parser. So maybe this issue is related to something different. Could I ask you to post the exact dataframe reader command you use (with the paths renamed or removed)? I'd like to see how the combination of options affects automatic segment cleanup.
The above options look like not exact since it contains an additional double quote symbol in
.option("redefine_segment_id_map:0", "HEADER_RECORD => "0")

My bad with the options. Since I use a foldLeft to hover over the options (BTW: the option values for Cobrix mostly are String typed, sometimes also Boolean, such that I need to use
Seq[(String, Either[String, Boolean])], this is just a conversion typo.
In the meantime I was able to check automatic field filtering with standard fixed record length files. It does not work either. So I presume it has nothing to do with the additional custom parser options like "rhp_additional_info"
So, I would like to start with this simpler example. Find below my complete dataframe reader options:
(spark read).format("cobol")
      .option("copybook", "path")
      .option("ebcdic_code_page", "cp037")
      .option("encoding", "EBCDIC")
      .option("is_record_sequence", "false")
      .option("schema_retention_policy", "collapse_root")
      .option("segment_field", "SEGMENT")
      .option("segment_id_level0", "000")
      .option("segment_id_level1", "050")
      .option("segment_id_level2", "999")
      .option("redefine_segment_id_map:0", "HEADER_RECORD => 000")
      .option("redefine_segment_id_map:1", "DETAIL_RECORD => 050")
      .option("redefine_segment_id_map:2", "TRAILER_RECORD => 999")
      .load("fileName")

Thanks, will try to run using your options.
Yeah, currently segment-redefine mapping does not work with fixed record length files. It is in the backlog for fixing. There is a possible workaround for that in #78.

I confirm that the workaround works fine for fixed record length files. Nice! So let me clean up this loose end and come back to you with more insight in the variable record length file case later.

Cool, will keep both #78 and this issue open until the mappings are implemented for fixed record length files.

Redefines filtering is now working for both fixed and variable record length files, by using option ("generate_record_id", "true"). I have not found any indication that options for custom header parser and redefines filtering are impeding one another, or that there is a bug at your end. Instead, I had to tweak the code on our side to make it work for variable record length. We are approaching an E2E ingesting solution for our special COBOL files here, thanks to your support.

The segment-redefine mapping for fixed record length files is almost done. Will create the PR today most likely. This should improve performance for your case and "generate_record_id", "true" can be removed. Will let you know once a snapshot version is deployed to Maven.

Deployed snapshot 0.5.5-SNAPSHOT


Support for NSDate record property

movieRecord["timestamp"] = NSDate()
Saving results in:
"serverErrorCode"
      - .1 : BAD_REQUEST
      - .0 : "reason"
      - .1 : Invalid value, expected type TIMESTAMP.

I would guess the NSDate isn't being converted to the correct JSON.

The bug was line 391 the TIMESTAMP should be milliseconds, from the docs
Date/Time
Number
A date or time value. Represented as a number in milliseconds since epoch.
Fix is to multiply timeIntervalSince1970 by 1000


Upgrade the Compose file format version to 3.5

Description

Upgrade Compose file format version to 3.5
Motivation and Context

Since Laradock requires Docker Engine >= 17.12
https://github.com/laradock/laradock/blob/89c9cfe09941bead05d63ec3c0fe9b9173ce0526/DOCUMENTATION/content/getting-started/index.md#L7-L10
Upgrading the Compose file format version to 3.5 will allow users to use more features.
https://github.com/docker/docker.github.io/blob/f4b16104d317e08247b567a68c3c26c0e788a5d1/_includes/content/compose-matrix.md#L1-L8

For example, setting workdir for exec is not supported in API < 1.35.
Types of Changes

[ ] Bug fix (non-breaking change which fixes an issue).
[x] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).

Definition of Done Checklist:

[x] I've read the Contribution Guide.
[x] I've updated the documentation. (refer to this for how to do so).
[x] I enjoyed my time contributing and making developer's life easier :)

Sorry, it doesn't solve the "workdir" issue.
The compose file format version needs to be greater than 3.6 to use the option.

Sorry, it doesn't solve the "workdir" issue.
The compose file format version needs to be greater than 3.6 to use the option.


Viewport should fallback to Canvas Renderer if WebGL fails to load

Until WebGL can be used in Dynamo without having to have a custom built we should use the canvas renderer if WebGL cannot be loaded.  This would allow Dynamo 2.0 users to use the plugin immediately without any additional modifications.
Dynamo 1.3 should be able to run WebGL as it still uses the old library.  I believe CEF would have to be included in the extension for this to work.  I previously created a 1.3 branch that doesn't include any of the 2.0 API changes.  This requires some testing.

781dcb06b25f5b01d94f514a0daf773519f5a954 enables Canvas Renderer when WebGL cannot be detected.  Filing a separate task for 1.3 build.


Wintertodt interrupt options

Adds interrupt options for full inv and idle

I believe there is a general 'user is idle' interrupt so having a wintertodt one is pointless?


Feature: New "Get card" CTA design on User Profile page

Type of feature
🍕 Feature
Current behavior
Right now, the "Get Card" CTA is shown in the header in user profile pages:

Suggested solution
Because we are shipping lists and want to incentivize usage, we want to replace the current "Get Card" CTA with a "Add to list" one, as mentioned in this issue -->  #1828
In order to avoid hiding the "Get Card" action behind the 3 dot menu, I propose this new button design below the User Profile:

Here's some more options for the icon design:

We could also add a gradient for a fake "holographic" look

Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Contributing Docs

[X] I agree to follow this project's Contribution Docs

@bdougie any thoughts? this is a quick idea and mock so very much open to feedback.
The rationale behind doing a fun icon is to make users curious about what that is, given that the dev cards are meant to be kind of an easter egg in a way

l like it. I prefer A or B. They are both easier to decipher as a small icon. Though maybe B is preferred overall. Also the gradient is a nice touch.

I like A and also like A as a holographic icon.

FWIW when I showed my 10 year old he said option A.

A it is! 🍕🍕 🍕
Here's the SVG for the inner icon:

CSS for the gradient: background: conic-gradient(from 180deg at 50% 50%, #FF6A06 0deg, #FF6492<PHONE_NUMBER>7627869deg, #FFE22C<PHONE_NUMBER>5255737deg, #FC620D 360deg, #FF7E33 360deg);

@OgDev-01

here's what we want for the look:
- button should be 46px x 46px
- stroke 2px
- svg 20x26px aprox


New logo in sign in page

Who is this PR for?
All users
What problem does this PR fix?
Replacing old logo with new logo
Screenshot (if adding a client-side feature)

Checklists
Which features or pages does this PR touch?

[x] Sign in page

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

[x] Manual testing made more sense here

👍 :shipit:


shallow clone limits fetch refspec to single branch

When straight-vc-git-default-clone-depth is set to an integer, the presence of the --depth option to git clone results in a fetch refspec which is limited to the branch fetched:
remote.origin.fetch=+refs/heads/master:refs/remotes/origin/master

(Incidentally, git clone does this even without the --single-branch option which straight.el passes in this case.)
The (minor) problem with this is that if the user of straight.el wants to contribute development of that package, and the package has a workflow which involves other branches (e.g. Orgmode incorporates the latest changes onto a maint branch), then a straight git fetch origin (or equivalent via magit or some other UI) will not fetch any other branches.
Arguably this is working as intended, but it does violate the Principle of Least Surprise - or at least it feels that way to me since it caused me more than a few minutes of head-scratching, and as a former contributor to git I'm not exactly a git newbie.
I've found what seems to be a reasonable solution to this: simply change --single-branch to --no-single-branch. This will make all upstream branches available, but the clone depth is still respected so it's usually not a significantly larger download.
For example, try:
git clone --depth 1 --no-single-branch --no-tags --branch master https://code.orgmode.org/bzg/org-mode.git

and you will see that it fetches one commit only per branch, and that the refspec is set up nicely for fetching of all branches in the future:
remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*

Directions to reproduce
Set straight-vc-git-default-clone-depth to 1 and then clone any package via straight.el as normal.

OK, I had no idea that it was possible to convert an issue to a PR, but apparently I managed to do it by accident anyway!  I submitted the issue first, then used Forge's "create pull request from issue" feature, which magically turned this into a PR.  I then incorrectly assumed that the PR's description had been copied over from the previously created issue, so I edited it to match the commit message, which effectively ditched the original issue report.  I'll change it back now.

Looks like some manual work is required to change the base branch to develop, would you mind taking care of that?

Done!

Thanks!


Updated to used external window handle to create window for windows p…

…latform

Cool, thanks.
Have you tested this?

I am using this in my project and it's working great

I think this change should be there in main repository too or at least support for external handlers


Update the extrapolation benchmarks on new bio models

Things are now a bit better.
Multistate:

Multisite2:

Are all of these small enough that a single BLAS thread is not gimping the non-parallel methods?

The ones that I am testing are 9 ODEs and 66 ODEs.

okay that's fine. Those would be faster without BLAS threading. I'm curious though, don't the parallel methods just avoid BLAS entirely already?

Yeah, they do. I just do it for comparison purposes for the non-parallel methods.

Curious to know though what these Bio models are for.

It came up in https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>2135v1
One of the benchmarks segfaulted?

This may get cut since it seems those benchmarks might be non-stiff.

Yeah not sure about the segfault; this was the plot I got for multisite2.jmd:

This may get cut since it seems those benchmarks might be non-stiff.
Okay, I saw the PR for it too

Just with benchmarking, it does seem non-stiff:
julia> @benchmark sol = solve(oprob,Vern9(),reltol = 1e-10,abstol=1e-10)
BenchmarkTools.Trial: 1755 samples with 1 evaluation.
 Range (min … max):  1.812 ms … 43.078 ms  ┊ GC (min … max): 0.00% … 85.37%
 Time  (median):     2.405 ms              ┊ GC (median):    0.00%
 Time  (mean ± σ):   2.833 ms ±  2.622 ms  ┊ GC (mean ± σ):  7.46% ±  7.61%

           ▂▃▅█▅▃▁
  ▆▅▆▆▆▄▃▃▅████████▆▅▅▅▄▄▃▃▃▃▃▄▃▃▄▄▄▄▄▄▃▄▃▃▄▄▄▄▄▃▃▄▃▃▃▃▃▁▂▁▂ ▄
  1.81 ms        Histogram: frequency by time        4.22 ms <

 Memory estimate: 1.59 MiB, allocs estimate: 2823.

julia> @benchmark sol = solve(oprob,ImplicitHairerWannerExtrapolation(min_order = 4, threading = OrdinaryDiffEq.PolyesterThreads()),reltol = 1e-10,abstol=1e-10)
BenchmarkTools.Trial: 595 samples with 1 evaluation.
 Range (min … max):  5.940 ms … 63.859 ms  ┊ GC (min … max): 0.00% … 43.17%
 Time  (median):     8.424 ms              ┊ GC (median):    0.00%
 Time  (mean ± σ):   8.389 ms ±  3.400 ms  ┊ GC (mean ± σ):  1.05% ±  2.39%

    ▃▄▅            ▁  ▁  ▁▁▄▄▆█▆█▄▆▅▃▁ ▂
  ▅████▇▅▃▃▃▃▃▃▅▃▃▄██▇█▇▅███████████████▇█▅▆▄▅▃▄▃▃▁▂▁▃▃▂▂▂▁▃ ▄
  5.94 ms        Histogram: frequency by time        11.1 ms <

 Memory estimate: 1.10 MiB, allocs estimate: 10040.


Fix issue #37 'Code example for testing produces an error'

Here you have, I hope the pull request is correct.

Coverage remained the same at 100.0% when pulling c56987b29edc9c4680c941e663ae57ae3de0d01d on JavierLopezMunoz:fix-testing-code-example into 2aea5aaccd40b10c1d49e6c67f9e63fbe9fe9e47 on GoogleCloudPlatform:master.

Thanks @JavierLopezMunoz!


Feature auto package#966

I add a module can auto package to impoove install chunjun the issue address [no.966]
(https://github.com/DTStack/chunjun/issues/966)

@FlechazoW


Feature request: add the ID of the PR in the issue title

Hello team,
Currently all the issue opened by the bot have the same title Copilot Usage. Adding the ID of the associated PR (e.g. Copilot Usage - PR#33) might be a small improvement to not get lost into the multiple opened/closed issues.

That's a great request @ghsioux!! Originally the thought was maintaining the same name for the sake of homogeneity. I received no objection from the current users towards this change, so I'll proceed and merge the pull request


The "locale" field in settings needs to be converted to lowercase

Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.
Version
v4
Describe the bug
The current default value of Locale in Emulator Settings is en-US. However, it does not match the default value of adaptive dialog SDK, which is en-us.
To Reproduce
Steps to reproduce the behavior:

Create a bot using new ChoiceInput(){                              Property = "dialog.FindCalendarEntry_Choice",                              Prompt = new ActivityTemplate("[EnterYourChoice]"),                              Choices = new List<Choice>()                              {                                  new Choice("First One"),                                  new Choice("Second One"),                                  new Choice("Third One")                              }                          },
Run the bot with Bot Framework Emulator.
See the error.

Expected behavior
Hopefully, the default value is en-us, instead of en-US.
Screenshots

[bug]

@ZhaoqingCui could you please share the contents and name of the LG file you used to get this repro? So we can get an exact repro and be 100% sure we fixed this.
Also, what build are you using? Thanks

I think it is not relevant to LG file. new ChoiceInput(){                                 Property = "turn.CreateCalendarEntry_Choice",                                 Prompt = new ActivityTemplate("[EnterYourChoice]"),                                 Choices = new List<Choice>()                                 {                                     new Choice("Confirm The First One"),                                     new Choice("Confirm The Second One"),                                     new Choice("Confirm The Third One")                                 },                                 Style = ListStyle.SuggestedAction                             },  You can view the file below to see the sample dialog.
AddContactDialog - Copy.zip
By using ChoiceInput(), we have to change the default Locale 'en-US' to 'en-us', which is confusing and weird, to make the bot work.

I asked about the lg file because I created a test with a dialog just like yours and it worked. What build are you using?

I asked about the lg file because I created a test with a dialog just like yours and it worked. What build are you using?

I guess it is fixed somehow. I am going to close this issue. Thanks a lot, guys.


MM-37092 Update Splash Screen to align with new branding

Summary
This PR reworks the layout of the splash screen and the image files have been updated to align with new branding.
Ticket Link
Jira Ticket: https://mattermost.atlassian.net/browse/MM-37092
Checklist

[ ] Added or updated unit tests (required for all new features)
[x] Has UI changes
[ ] Includes text changes and localization file updates

Device Information
This PR was tested on:

iOS simulator
iPhone 11 actual device running iOS 14.6
Google Pixel device running Android 11

Screenshots

Release Note
<!--
Add a release note for each of the following conditions:
```release-note
Updated the layout and logo used in the splash screen
```

Building app in separate branch.

Are we expecting this to include dark mode too?

Are we expecting this to include dark mode too?

@enahum do we currently support dark mode? It doesn't look like it. I was just looking to update the splash screen with the new branding colors. To be honest this was much more complicated than I expected it to be already. Adding dark mode support for this might be out of my depth, but I can try to look in to it

Quedtion is, do we want to include it with this Pr or not.. I could help during the week if that is the case. Gekidou branch does has support for it

I wouldn't see it as a high priority right now since the rest of the app doesn't yet support it, but I say let's go for it if it's easy to do

I see some files added in this PR that I really doubt if we need them, going to have to take a deeper look at this.

Ya, that's entirely possible. Working out the Android splash screen was way more complicated than I imagined. I could have just swapped out the images, but I wanted to see if we could do just the transparent logo cantered in the middle instead of what we had previously. This might help us for dark mode too.

Now for our discussion about dark mode, will the color of the logo remain as in this PR or will it need to be modified for that?

The logo will need to be white for dark mode, so I'll need to provide the assets for that

Building app in separate branch.

Building app in separate branch.

Building app in separate branch.

@enahum just a heads up that I simplified everything and reduced the number of files changed here.

Building app in separate branch.

Awesome @matthewbirtch I'll be reviewing some time this week. Do we need to add the file changes into the release assets as well?

Awesome @matthewbirtch I'll be reviewing some time this week. Do we need to add the file changes into the release assets as well?

I don't really know. Do those automatically get updated some other way? I assumed they needed to be updated manually, but I don't recall know how that works

Awesome @matthewbirtch I'll be reviewing some time this week. Do we need to add the file changes into the release assets as well?

I don't really know. Do those automatically get updated some other way? I assumed they needed to be updated manually, but I don't recall know how that works

The files under the aseets folder

The files under the aseets folder

Is there more to this statement? I'm not sure what you're saying :)

Awesome work @matthewbirtch I've added the missing pieces. We should add this work to Gekidou once this PR is merged

Thanks @enahum. I guess we should get this reviewed by QA and PM

PM if you want in case there is feedback around the designs.. QA is not really needed as they won't be able to test the splash screen for release builds, which I did.

Removing QA as per Elias's comments


fixing IAM role for the worker

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

added reference to pod IP automation blog to have the pod routing.


Versioning vs postgresql-migrations

sorry if this isn't an appropriate place, but I was just wondering how this compares to
https://gitlab.com/depesz/Versioning
seems like semi similar concept except versioning seems to expect you to either call each of the relevant scripts yourself or write some kind of tool to do so? And also keeps track of dependencies between migrations - this doesn't seem to do that? I guess in practice you copy the migrations sql in this project into beginning of every migration file? do you keep a separate folder that has rollbacks? (but I don't see code in this repo that deletes from the applied_migrations table)

had a conversation w/gpt4 about this
https://chat.openai.com/share/7efbd567-cfaf-40c5-997a-7ceb1edeac37

Thanks for asking! Yes, this file forms the basis of an ongoing migrations file in a project, so it gets copied in and then later extended. Simple and has been effective in practice.
I don't do rollback migrations at all — I don't really believe in them for various reasons, including that they rarely get tested, down/up migration pairs often aren't idempotent etc., and are also not usually the best way of resolving bad deploys.
I haven't looked at Versioning at all, but depesz knows his stuff, so I imagine it's good. There are many other more featureful migration tools around, e.g. sqitch, and the one in this repo has much more modest/minimal goals.


tncid doc

fixes #5368

🏷 Type of documentation

[ ] new bid adapter
[ ] update bid adapter
[ ] new feature
[ ] text edit only (wording, typos)
[ ] bugfix (code examples)
[ ] new examples

📋 Checklist

[ ] Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself
[ ] For new adapters check submitting your adapter docs

@ChrisHuie can you clean this up please, this adapter has no documentation


Is this correct under Configure a distribution point?

"The distribution point must be running Windows Server, version 1709. There's no client prerequisite."
According to the referenced article, shouldn't this be Windows Server 2016 instead of Windows Server, version 1709?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b49b7692-2fba-a5b6-cc24-3b2621b7f5dd
Version Independent ID: bbc48abf-20cb-18f4-0db4-467cb0408b30
Content: Manage distribution points - Configuration Manager
Content Source: sccm/core/servers/deploy/configure/install-and-configure-distribution-points.md
Product: configuration-manager
GitHub Login: @aczechowski
Microsoft Alias: aaroncz

Thanks @g4m3c4ck for the feedback. I'm assuming you're referring to the LEDBAT setting? The part you reference is technically accurate right now. SCCM 1806 currently only supports Windows Server version 1709 with this setting. While Server 2016 technically supports LEDBAT, it's not yet supported with SCCM.
This issue is already tracked via issue #702, so I'm closing this issue as a duplicate.


bug(python): Hybrid search syntax broken?

LanceDB version
v0.13.0
What happened?
I'm trying to update the integration in the llama-index repo
Currently, unit tests for the hybrid search are failing. It seems like support for passing in both the query text and vector was removed/changed ? And If I use the following syntax from the docs
vector_query = [0.1, 0.2, 0.3, 0.4, 0.5]
text_query = "flower moon"
results = table.search(query_type="hybrid")
                .vector(vector_query)
                .text(text_query)
                .limit(5)
                .to_pandas()

I get a not-implemented error for .vector(vector_query)
Any help would be appreciated!
Are there known steps to reproduce?
Run unit tests for the llama-index integration

Hi @logan-markewich, yes we've updated the hybrid search api with a breaking change. Limiting version should be good for now. I'll update llama-index integration and send you guys a PR this week!

@logan-markewich https://github.com/run-llama/llama_index/pull/16057/


The convert script has been renamed

$ ../convert.py mediawiki_dump.xml
bash: ../convert.py: No such file or directory
$

Oops. Yes, the old script name no longer exists, but this wasn't the right replacement - 54634c086bc794832506d03146dfee44ee981150


Directory is not deleted

VSCode Version: 1.12.1
OS Version: WIN7

Steps to Reproduce:

Delete directory
Refresh
Directory still exists

http://pl.tinypic.com/r/167mepx/9

Please see if you can find any logged output that could help us find the source of the issue:

run code --verbose from the command line and attach the output
in Code select Help | Toggle Developer Tools and select the Console
attach any output you see in the Console you can find

Thanks!

vebose

←[93m[main 07:42:03]←[0m Starting VS Code in verbose mode
←[93m[main 07:42:03]←[0m from: c:\Program Files (x86)\Microsoft VS Code\resources\app
←[93m[main 07:42:03]←[0m args: { _: [ 'C:\praca\dev' ],
help: false,
h: false,
version: false,
v: false,
wait: false,
w: false,
diff: false,
d: false,
goto: false,
g: false,
'new-window': false,
n: false,
'unity-launch': false,
'reuse-window': false,
r: false,
performance: false,
p: false,
'prof-startup': false,
verbose: true,
logExtensionHostCommunication: false,
'disable-extensions': false,
disableExtensions: false,
'list-extensions': false,
'show-versions': false,
nolazy: false }
←[93m[main 07:42:04]←[0m IPC#vscode-machineId
[3876:0516/074205.621:INFO:CONSOLE(28)] "Overwriting extension <<.handlebars>> to now point to mime <<text/x-handlebars>>", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[3876:0516/074205.621:INFO:CONSOLE(28)] "Overwriting extension <<.hbs>> to now point to mime <<text/x-handlebars>>", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[3876:0516/074205.631:INFO:CONSOLE(28)] "Ctrl+Alt+ keybindings should not be used by default under Windows. Offender: ", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[3876:0516/074205.631:INFO:CONSOLE(28)] "Ctrl+Alt+ keybindings should not be used by default under Windows. Offender: ", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[3876:0516/074205.632:INFO:CONSOLE(28)] "Ctrl+Alt+ keybindings should not be used by default under Windows. Offender: ", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[3876:0516/074205.632:INFO:CONSOLE(28)] "Ctrl+Alt+ keybindings should not be used by default under Windows. Offender: ", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[3876:0516/074205.632:INFO:CONSOLE(28)] "Ctrl+Alt+ keybindings should not be used by default under Windows. Offender: ", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[3876:0516/074205.632:INFO:CONSOLE(28)] "Ctrl+Alt+ keybindings should not be used by default under Windows. Offender: ", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
←[93m[main 07:42:06]←[0m IPC#vscode-workbenchLoaded
[3876:0516/074209.304:INFO:CONSOLE(28)] "%c[File Watcher]", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[3876:0516/074209.382:INFO:CONSOLE(28)] "%c[File Watcher]", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[3876:0516/074209.516:INFO:CONSOLE(28)] "%c[File Watcher]", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[3876:0516/074209.516:INFO:CONSOLE(28)] "%c[File Watcher]", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[3876:0516/074209.638:INFO:CONSOLE(28)] "%c[File Watcher]", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[3876:0516/074209.638:INFO:CONSOLE(28)] "%c[File Watcher]", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[3876:0516/074209.781:INFO:CONSOLE(28)] "%c[File Watcher]", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[3876:0516/074210.523:INFO:CONSOLE(28)] "%c[File Watcher]", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[3876:0516/074210.682:INFO:CONSOLE(28)] "%c[File Watcher]", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[3876:0516/074212.427:INFO:CONSOLE(28)] "%c[File Watcher]", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[3876:0516/074212.427:INFO:CONSOLE(28)] "%c[File Watcher]", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[3876:0516/074212.549:INFO:CONSOLE(28)] "%c[File Watcher]", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[3876:0516/074212.550:INFO:CONSOLE(28)] "%c[File Watcher]", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[3876:0516/074212.853:INFO:CONSOLE(28)] "%c[File Watcher]", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[3876:0516/074220.972:INFO:CONSOLE(29)] "%c[Extension Host]", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (29)
[3876:0516/074232.720:INFO:CONSOLE(29)] "%c[Extension Host]", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (29)
[3876:0516/074232.720:INFO:CONSOLE(29)] "%c[Extension Host]", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (29)
[3876:0516/074232.775:INFO:CONSOLE(29)] "%c[Extension Host]", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (29)
[3876:0516/074232.775:INFO:CONSOLE(29)] "%c[Extension Host]", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (29)
[3876:0516/074232.966:INFO:CONSOLE(29)] "%c[Extension Host]", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (29)
[3876:0516/074232.966:INFO:CONSOLE(29)] "%c[Extension Host]", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (29)
[3876:0516/074232.971:INFO:CONSOLE(29)] "%c[Extension Host]", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (29)
[3876:0516/074232.972:INFO:CONSOLE(29)] "%c[Extension Host]", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (29)
[3876:0516/074232.975:INFO:CONSOLE(29)] "%c[Extension Host]", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (29)
[3876:0516/074232.976:INFO:CONSOLE(29)] "%c[Extension Host]", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (29)
[3876:0516/074232.979:INFO:CONSOLE(29)] "%c[Extension Host]", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (29)
[3876:0516/074303.158:VERBOSE1:CONSOLE(8299)] "Main._createAppUI: 18.910ms", source: chrome-devtools://devtools/bundled/inspector.js (8299)
[3876:0516/074303.183:VERBOSE1:CONSOLE(8304)] "Main._showAppUI: 22.985ms", source: chrome-devtools://devtools/bundled/inspector.js (8304)
[3876:0516/074303.235:VERBOSE1:CONSOLE(8305)] "Main._initializeTarget: 12.288ms", source: chrome-devtools://devtools/bundled/inspector.js (8305)

console.log
log.txt
i dont see anything unusual ...


motion not sending a stop, max_capture and losing footage

Hi there,
I'm having some issues where for whatever reason motion isn't sending a stop capture. This seems particularly frequent when there is a change in period and the change of settings seem to trigger a recording (even tho I turn motion off before changing settings).
As a result for example this morning I had a 1.9GB file and growing. I caught it on time, but if I didn't and it actually got into the "busy period" I'd probably lost footage. While I'm trying to determine why motion is doing that, I was looking for alternative solutions and ran into Max_Capture, which would put a limit to the runaway recording. The problem however is that if I really had any legit prolonged period of movement, longer than Max_Capture, I would still end up losing footage as Motion would not send another start command since internally it's still going.
Is that a correct understand of how that'd play out? Something I'm thinking is to issue a stop and immediately another start as a way to truncate the file basically. The other benefit of this is that longer recordings would be split up and not be a massive CPU hit once they get passed on to MP4Box.
thoughts?

Yes. Both external motion and internal motion will only issue a start after they issue a prior stop.
The schedule Max_capture starts a timer after issuing a start to raspimjpeg and then will issue a stop itself if no stop request has come in from motion. When the stop eventually come in afterwards then schedule will ignore it.
I think there is more opportunity for altering this behaviour with the internal motion detection. E.g. at the moment a stop received from outside like pressing the web button or a max_capture time out does not affect the internal detection which will continue to look for a stop condition. It would be fairly easy to change this or have a flag so that a capture stop command, rest the internal motion detection back to the off state and it would then retrigger if motion detection conditions persisted. I can see a case for wanting either behaviour so a flag may be the way to handle that.

agreed, that would be desirable/good design. I've been unfortunately pulled elsewhere and not having been able to make any progress with the algorithm I'm stuck using external motion detection as I need despeckle to filter out noise from the grass/wind. If I manage to find some time I'll try to prototype this in python and it works share it/try an implementation in C.