forgejo: 7.0.4 -> 7.0.5

Description of changes
https://codeberg.org/forgejo/forgejo/releases/tag/v7.0.5
https://codeberg.org/forgejo/forgejo/src/branch/forgejo/RELEASE-NOTES.md#7-0-5
diff: https://codeberg.org/forgejo/forgejo/compare/v7.0.4...v7.0.5
While updating using nix-update forgejo --version 7.0.5 I this time got this error reproducibly:
[…]
Running phase: patchPhase
applying patch /nix/store/z37y57cp2n3fai1sjvr7221k41hprrf5-static-root-path.patch
patching file modules/setting/server.go
applying patch /nix/store/jczl89zs3xlhz4bsrrwrd681mqklimb3-f01dc4b271f54201e60a7c795d784813eac3f7ce.patch
patching file cmd/dump_test.go
Reversed (or previously applied) patch detected!  Assume -R? [n]
Apply anyway? [n]
Skipping patch.
4 out of 4 hunks ignored -- saving rejects to file cmd/dump_test.go.rej
error: builder for '/nix/store/f24g98pj9lkfy9x0vpq41xjjbbhnsjbg-forgejo-7.0.5-go-modules.drv' failed with exit code 1;
       last 10 log lines:
       > source root is source
       > Running phase: patchPhase
       > applying patch /nix/store/z37y57cp2n3fai1sjvr7221k41hprrf5-static-root-path.patch
       > patching file modules/setting/server.go
       > applying patch /nix/store/jczl89zs3xlhz4bsrrwrd681mqklimb3-f01dc4b271f54201e60a7c795d784813eac3f7ce.patch
       > patching file cmd/dump_test.go
       > Reversed (or previously applied) patch detected!  Assume -R? [n]
       > Apply anyway? [n]
       > Skipping patch.
       > 4 out of 4 hunks ignored -- saving rejects to file cmd/dump_test.go.rej
       For full logs, run 'nix log /nix/store/f24g98pj9lkfy9x0vpq41xjjbbhnsjbg-forgejo-7.0.5-go-modules.drv'.
error: 1 dependencies of derivation '/nix/store/xb0fkn7dpj3dgahrdl0qyx8d43np8d5x-forgejo-7.0.5.drv' failed to build
copying path '/nix/store/brm9jikmbfb7ph9cxzgmvxlvhsixss5f-unit-systemd-udev-settle.service' from 'https://cache.nixos.org'...
building '/nix/store/dzsqb8qs5lj6y3szk0w2s62k3qzxpm30-X-Restart-Triggers-sshd.drv'...
error: 1 dependencies of derivation '/nix/store/p2gkfajw68b2m3kwk0b1arq2bas4n64s-nixos-tmpfiles.d.drv' failed to build
error: 1 dependencies of derivation '/nix/store/3p2vkn820jnxsg4g8v5z5668ynvgzy4f-system-path.drv' failed to build
error: 1 dependencies of derivation '/nix/store/70b9ng125cpvgxg2bgiariwd85g2clkk-system-path.drv' failed to build
error: 1 dependencies of derivation '/nix/store/7givnx9h9gmnxgscgxswl8bhr9v084vz-system-path.drv' failed to build
error: 1 dependencies of derivation '/nix/store/q5afxp6hm9f9vgard18iap0qpc5mdcw7-system-path.drv' failed to build
error: 1 dependencies of derivation '/nix/store/qw4i8y08am80d2gcz4zck1y7qiycpbal-system-path.drv' failed to build
error: 1 dependencies of derivation '/nix/store/vz3mkxr6ygashphy7fcq5mzx6jvnz787-system-path.drv' failed to build
error: 1 dependencies of derivation '/nix/store/68szvga8rgf1jzsiq67g80yn1d7ynv4w-unit-forgejo-dump.service.drv' failed to build
error: 1 dependencies of derivation '/nix/store/78ylqklmg3d509g8ca33vavr67s16vin-unit-forgejo.service.drv' failed to build
error: 1 dependencies of derivation '/nix/store/lhk534ydyg922giyqjd0k5qkh69y1i08-unit-forgejo.service.drv' failed to build
error: 1 dependencies of derivation '/nix/store/r709304229nvhg3d0749xyx6kr38hyzr-unit-forgejo.service.drv' failed to build
error: 1 dependencies of derivation '/nix/store/b9nlf7hm01673rl2hhb5bgl0mdbz37ll-unit-script-forgejo-secrets-start.drv' failed to build
building '/nix/store/9wiwk5y2bmhjx1qvxz2a72bvnv83j1ql-unit-systemd-udev-settle.service.drv'...
building '/nix/store/kar8k49q344z8a5hjzaj94vk0vcgl78v-unit-systemd-update-utmp.service.drv'...
building '/nix/store/01gssqaps442813pxy1jgiaagkcjchf8-unit-systemd-user-sessions.service.drv'...
error: 1 dependencies of derivation '/nix/store/2ykkvdkaib340nxv69x4p623c9r33c6s-nixos-system-server-test.drv' failed to build
copying path '/nix/store/92jnqy9gyvq63cjvrm40mdpj36nmjxdc-unit-systemd-update-utmp.service' from 'https://cache.nixos.org'...
error: 1 dependencies of derivation '/nix/store/c3yf26w8v21zymdc9r3kw36icjbfp5q6-nixos-system-server-test.drv' failed to build
error: 1 dependencies of derivation '/nix/store/sdng5w6p7lzc34lchp7nv9llypfggvn1-nixos-system-server-test.drv' failed to build
error: 1 dependencies of derivation '/nix/store/qaly6qcgrx3z3xfyp9fa0ydd38p1si7c-nixos-test-driver-forgejo-mysql.drv' failed to build
error: 1 dependencies of derivation '/nix/store/kzvz8m4cd9dh5jyn5xh2yq27rkxc3i0a-nixos-test-driver-forgejo-postgres.drv' failed to build
error: 1 dependencies of derivation '/nix/store/psrrxa85f4cbb0pjwl25498yrhnzr6rh-nixos-test-driver-forgejo-sqlite3.drv' failed to build
error: 1 dependencies of derivation '/nix/store/gax0bahlb0yvqg44xhk38n2bqwrfw3ql-vm-test-run-forgejo-mysql.drv' failed to build
error: build of '/nix/store/axqmymdy5dg3a26m6v8zqg0x3qi347w3-vm-test-run-forgejo-postgres.drv', '/nix/store/gax0bahlb0yvqg44xhk38n2bqwrfw3ql-vm-test-run-forgejo-mysql.drv', '/nix/store/z5xk44pqlga1pkj5adrwmd6vw23ifdaa-vm-test-run-forgejo-sqlite3.drv' failed

These choices are not really choices, but are automatically forcefully negated:
[…]
Reversed (or previously applied) patch detected!  Assume -R? [n]
Apply anyway? [n]
[…]

While running nix-build --attr pkgs.forgejo.passthru.tests I get quite the same errors.
PS: I'm not sure how to handle this, but I figured it's better to notify someone than to not do anything about it.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@emilylange Oh, I see. Hopefully, everything should be working properly now.
PS: Thanks for not just applying it, I learned quite a lot. :)

Oh, I may have done something wrong again. I am not familiar with the GitHub review process.

@ofborg build forgejo

❯ nix-build -A forgejo.passthru.tests --argstr system aarch64-linux
/nix/store/icy4n8nfxbn7m978l4qkl2hzz3bw8zmm-vm-test-run-forgejo-mysql
/nix/store/ryhv2v4ybq8566j5h53y1hqxxdrs55sf-vm-test-run-forgejo-postgres
/nix/store/5z632wcjrz424ywcg0a739a65i7gjwkc-vm-test-run-forgejo-sqlite3


More networks support and add subscan apikey config

added 3 more networks (edgeware, crab, and darwinia)
put a userInput.json.sample in the config folder
add a subscan_apikey config item and update methods to support it.  Leaving the item blank works as it did.

Would love to see this merged!

Hey guys,
sorry I am swamped right now, I try to check this out asap.


Broken by CURLI rework

Hi,
@*INC has gone away and one should be using $*REPO.repo-chain now.
I'm just working on fixing some of my own modules in this regard at the moment,  but if it doesn't get fixed before I'll try and send a PR.
Thanks.

With the recent addition of %?RESOURCES to rakudo, this module is probably not very useful anymore - I recommend using %?RESOURCES if at all possible.

Hi,
absolutely.  I had hand-coded the bits to find a co-installed dynamic library in my own modules, and have just replaced all of this with three lines of code.
I'll close this as I am sure on top of this.


[SPARK-33505][SQL][TESTS] Fix adding new partitions by INSERT INTO InMemoryPartitionTable

What changes were proposed in this pull request?

Add a hook method to addPartitionKey() of InMemoryTable which is called per every row.
Override addPartitionKey() in InMemoryPartitionTable, and add partition key every time when new row is inserted to the table.

Why are the changes needed?
To be able to write unified tests for datasources V1 and V2. Currently, INSERT INTO a V1 table creates partitions but the same doesn't work for the custom catalog InMemoryPartitionTableCatalog used in DSv2 tests.
Does this PR introduce any user-facing change?
No
How was this patch tested?
By running the affected test suite DataSourceV2SQLSuite.

Test build #131438 has started for PR 30449 at commit dc0c6d8.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36044/
Test FAILed.

Test build #131438 has finished for PR 30449 at commit dc0c6d8.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131438/
Test FAILed.

Test build #131439 has started for PR 30449 at commit ff0f1f8.

Thanks, @MaxGekk .

I think it would be nice to check that insert into the same partition doesn't fail. I will add one more insert into.

Test build #131443 has started for PR 30449 at commit 362e8b8.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36046/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36046/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36046/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36049/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36049/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36049/
Test FAILed.

Test build #131439 has finished for PR 30449 at commit ff0f1f8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131439/
Test PASSed.

Test build #131443 has finished for PR 30449 at commit 362e8b8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131443/
Test PASSed.


ActivateAndServe example with systemd

https://godoc.org/github.com/miekg/dns#Server.ActivateAndServe
reads

ActivateAndServe starts a nameserver with the PacketConn or Listener configured in *Server. Its main use is to start a server from systemd.

Fine. Do you have an example in which context systemd plays a role there or how to use this function in conjunction with systemd? I'm guessing you mean socket activation.
Do you just do the usualy socket and service combo and listen via net.Conn and pass it to the server? I don't get why systemd, what does systemd have to do in all this?

close without and answer, nice

would you like an asshat to go with that ignorance


Spans being dropped before export due to Lambda Shutdown Request

Describe the bug
I'm running the AWS Otel Lambda Layer using Node in eu-west-2. When running the request on infrequent lambdas, the Otel collector successfully starts, the lambda runs but no export is performed until a period of time passes when the lifecycle event shutdown happens. At this point not data is forwarded on.
I'm using a configuration YAML file with Honeycomb. This has a queue for enabling retries as without I constantly get dropped traces.
What did you expect to see?
I expect the collector to flush my traces to honeycomb before the shutdown event occurs.
Environment
receivers:
  otlp:
    protocols:
      grpc: # on port 4317
      http: # on port 4318

exporters:
  otlp:
    endpoint: "api.honeycomb.io:443"
    headers:
      "x-honeycomb-team": "$HONEYCOMB_API_KEY"
    sending_queue:
      num_consumers: 4
      queue_size: 100
    retry_on_failure:
      enabled: true

service:
  pipelines:
    traces:
      receivers: [otlp]
      exporters: [otlp]

I'm hoping my limited understanding of OTEL is the issue here!

It's worth noting that on the Lambdas that have frequent traffic I successfully get some traces however, I can't be confident that I get 100%.
My ENV Vars for reference:
    OTEL_PROPAGATORS                            = "tracecontext"
    OTEL_SERVICE_NAME                           = "SOMETHING"
    OPENTELEMETRY_COLLECTOR_CONFIG_FILE         = "/var/task/${var.file_name}/config.yaml"
    AWS_LAMBDA_EXEC_WRAPPER                     = "/opt/otel-handler"
    OTEL_LAMBDA_DISABLE_AWS_CONTEXT_PROPAGATION = true
    OTEL_TRACES_SAMPLER                         = "always_on"


Strict keys in HashMap

It's very powerful feature in typescript by strict value type in HashMap declaration. However looks like the same feature is missing for key values. I tried defined as type of string or enums but getting errors.
type Keys1 = "key1" | "key2";
enum Keys2 {key1, key2}
const map1: {[key: string]: Keys1 | null} = {
    "key1": "key1",
    "key2": "key2",
    "key3": "key3"  //That is working!!!
                    // Property '"key3"' is incompatible with index signature.
                    // Type '"key3"' is not assignable to type '"key1" | "key2" | null'.
};

const map2: {[key: string]: Keys1 | null} = {
    "key1": "key1",
    "key2": "key2",
    "key3": null //I would like to strct and get error
};

const map3: {[key: Keys1]: boolean} = {  //[ts] An index signature parameter type cannot be a union type.
                                        //Consider using a mapped object type instead.
                                        //(parameter) key: "key1" | "key2"
    "key3": true
};

const map4: {[key: Keys2]: boolean} = {  //[ts] An index signature parameter type must be 'string' or 'number'.
                                        //(parameter) key: Keys2
    "key3": true
};

Use mapped types:
const map3: { [key in Keys1]: boolean } = {
    "key3": true
};

const map4: { [key in Keys2]?: boolean } = {
    [Keys2.key1]: true
};

Thank you! I didn't know we can use "in" as data type declaration.


Adjust height for all days in a week if the height of a day ViewContainer is increased

In my project, I need to add optional views in the day view without increasing the height for every cell. Currently the library does this but the rest of the days of the week leave space below them. Is there a workaround to increase the height of the days in a particular week?

Thank you for creating this great library!

How are you adding/removing the extra view? Is this a view in the cell that is just shown and hidden as needed?

Correct. I'm setting the view from View.GONE to View.VISIBLE.

In that case, this would be happening because the check view is at the bottom and other views are above it. How about you make the white background the main view, let's say maybe a FrameLayout, then you add the check view inside it with a bottom gravity. This way, the white background is responsible for the cell height and not the check view which will still be correctly positioned at the bottom and there won't be an extra space when the check view is set to GONE

If you use a bottom gravity, then the cell height will not increase. For example, I would like all view heights to be 100dp, but when one view increases to 112dp, I would like to only notify the views in that week to increase the height to 112dp.
`

<LinearLayout
    android:id="@+id/calendarDayBackground"
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:orientation="vertical">

    <LinearLayout
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:layout_marginLeft="1dp"
        android:layout_marginTop="@dimen/padding_half"
        android:layout_marginBottom="@dimen/padding_quarter"
        android:orientation="vertical">

        <TextView
            android:id="@+id/calendarDayText"
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            android:layout_gravity="center_horizontal"
            android:gravity="center_horizontal"
            android:padding="@dimen/padding_half"
            android:textColor="@color/usuallydarknavy"
            android:textSize="18sp"
            tools:text="22" />

    </LinearLayout>

    <View
        android:id="@+id/reservedSpace"
        android:layout_width="match_parent"
        android:layout_height="50dp"
        android:elevation="3dp" />

    <FrameLayout
        android:id="@+id/calendar_applied_event"
        android:layout_width="match_parent"
        android:layout_height="12dp"
        android:layout_gravity="bottom"
        android:background="@color/bpBlue"
        android:visibility="gone"
        tools:visibility="visible">

        <ImageView
            android:layout_width="wrap_content"
            android:layout_height="match_parent"
            android:layout_gravity="center"
            android:src="@drawable/ic_check_white" />
    </FrameLayout>

</LinearLayout>

`

I think I am a bit lost. How are you able to get all the cells in the selected week in the screenshot you shared to have a different height than other weeks? The empty bottom spacing aside, how are you changing the height?
I think just setting the checkmark view to VISIBLE/GONE would not be sufficient as the container's height is actually fixed. Could you clarify this?

I'm using a linearlayout that wraps the height. When the calendar_applied_event is set to visible, the height will change. I'm also not specifying "dayHeight".  By doing this, the container's height seems to be dynamic.

Interestingly, I am not able to get that to happen in the examples, looks like I'm missing something but not exactly sure what. Anyway, I am just trying to illustrate that you can notify all days on a row by setting a flag, then you can reload all views in that row and adjust them accordingly.
 Normally, you would keep a reference to the selected view, then the next step would be finding all the days in that week, keep a reference to it and then reload them and in the binding, check if you're binding a view in the reference and update accordingly. Something like this:
val selectedDate = LocalDate.now()
val weekFields = WeekFields.of(Locale.getDefault()) // OR WeekFields.of(DayOfWeek.MONDAY, 1)
val selectedWeekRow: Int = selectedDate.get(weekFields.weekOfMonth())
val month = YearMonth.of(selectedDate.year, selectedDate.month)
val datesToWeek = (1..selectedDate.yearMonth.lengthOfMonth()).map { month.atDay(it) }.filter {
    it.get(weekFields.weekOfMonth()) == selectedWeekRow
}
datesToWeek.forEach { calendarView.notifyDateChanged(it) }

exFiveCalendar.dayBinder = object : DayBinder<DayViewContainer> {
    override fun create(view: View) = DayViewContainer(view)
    override fun bind(container: DayViewContainer, day: CalendarDay) {
        if (day.date in datesToWeek) {
            if (day.date == selectedDate) {
                // Show blue checkmark view
            } else {
                // Make blue checkmark view INVISIBLE so its space is still available.
            }
        } else {
            // Make blue checkmark view GONE so its space is no longer available.
        }
    }
}

This is rough but it gives an idea of what needs to be done. Of course, you also need to reload all the previously expanded days so you can reset them accordingly in the binder, or if you want to go extreme, just reload the current month.

Perfect! That solved the issue. Thank you very much for you help.
I don't think I'm doing anything else special to make the height adjustable. Just not setting the height and making the layout height wrap the content did it for me. Either I really appreciate you taking the time to help solve this.

So, I figured it out, the view height really does change if you set the day view width but have the CalendarView height/width as match_parent.
I finished up my illustrations and you can see it in the gif.

Here's the full code:
private var selectedDate: LocalDate? = null
private val datesInSelectedWeek = mutableListOf<LocalDate>()

class DayViewContainer(view: View) : ViewContainer(view) {
    lateinit var day: CalendarDay
    val textView = view.calendarDayText
    val checkView = view.calendar_applied_event

    init {
        view.setOnClickListener {
            if (day.owner == DayOwner.THIS_MONTH && selectedDate != day.date) {
                val previousWeekDates = datesInSelectedWeek.toList() // Copy
                updateSelectedWeek(day.date)
                val currentWeekDates = datesInSelectedWeek.toList() // Copy, not really needed here
                previousWeekDates.forEach { calendarView.notifyDateChanged(it) }
                currentWeekDates.forEach { calendarView.notifyDateChanged(it) }
            }
        }
    }
}

calendarView.dayBinder = object : DayBinder<DayViewContainer> {
    override fun create(view: View) = DayViewContainer(view)
    override fun bind(container: DayViewContainer, day: CalendarDay) {
        container.day = day
        container.textView.text = day.date.dayOfMonth.toString()

        if (day.owner == DayOwner.THIS_MONTH) {
            container.textView.setTextColorRes(R.color.example_5_text_grey)
            if (day.date in  datesInSelectedWeek) {
                if (selectedDate == day.date) {
                    container.checkView.visibility = View.VISIBLE
                } else {
                    container.checkView.visibility = View.INVISIBLE
                }
            } else {
                container.checkView.visibility = View.GONE
            }
        } else {
            container.checkView.visibility = View.GONE
            container.textView.setTextColorRes(R.color.example_5_text_grey_light)
        }
    }
}

fun updateSelectedWeek(selectedDate: LocalDate) {
    val weekFields = WeekFields.of(Locale.getDefault()) // OR WeekFields.of(DayOfWeek.MONDAY, 1)
    val selectedWeekRow: Int = selectedDate.get(weekFields.weekOfMonth())
    val month = YearMonth.of(selectedDate.year, selectedDate.month)
    datesInSelectedWeek.clear()
    datesInSelectedWeek.addAll((1..month.lengthOfMonth()).map { month.atDay(it) }.filter {
        it.get(weekFields.weekOfMonth()) == selectedWeekRow
    })
    this.selectedDate = selectedDate
}

Note that if you have in/outDates, then you have to check for that and add them to the datesInSelectedWeek values and then bind accordingly. This is useful for the first and last week rows on the calendar. Calculating this is a bit tricky so I will be adding a feature in the library over the weekend to get the CalendarMonth for a date. The CalendarMonth holds all days in each month as val weekDays: List<List<CalendarDay>> so this saves you two things:

You will no longer need all of the logic in updateSelectedWeek method as you can just get all the dates in the row using weekDays.first { it.any { it == selectedDate } } from the CalendarMonth class.

No extra logic for getting the in/out dates in a row as this is included in the weekDays property of the CalendarMonth class.


worker: release messages without defer

defer causes the function calls to occur at the termination of the
function, rather than at the end of the current block. This causes
defers within a loop to build up a large list of calls in memory and
doesn't run them until the worker terminates, causing a memory leak.
This also fixes a nil pointer dereference when the result is nil - for
example, if runTaskFunc's taskFunc.Call calls a worker function with no
return value.

The lint error appears to be unrelated to my change.


new function Combinations returns combinations of n elements

Hi, I add a function to limit number of element of every combination.
For example:
{
    name: "Three items, n = 2",
    in:   []string{"A", "B", "C"},
    n:    2,
    out: [][]string{
        {"A", "B"},
        {"A", "C"},
        {"B", "C"},
    },
},

Pull Request Test Coverage Report for Build 36

23 of 23 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 33:
0.0%

Covered Lines:
40

Relevant Lines:
40

💛  - Coveralls


Update compatibility with<EMAIL_ADDRESS>

Looks like seneca changed how log payload is defined.
In older versions "level" was a string, e.g., "debug", "fatal", etc.  This is now a number, 200, 500 - and the "level_name" is the name.  This fix should be backwards compatible.  (Unfortunately this is NOT mentioned in the changelog of 3.14.0)
I also didn't include the package-lock.json that was generated from npm i -- it might be a good idea to include this if/when this PR is merged
Fixes #2

So far, it seems like @blueshirts is not interested in merge this fix 😕
For now, we'll work with a modified private version of the module.

So far, it seems like @blueshirts is not interested in merge this fix confused

mmHmm.  Went ahead and forked the library to apply this change in our environment.


train_on_inputs flag

Hi! I noticed that there is a parameter for masking the inputs when computing the loss (for stage 1). By default in the code it is false. Is this the desired setup for training on the math task, and if so could you elaborate why? Thank you

Hello, sorry for the late reply. Given that this repository has been around for a while, we recall that this parameter was discovered during our experiments to train Llama1. Setting "train_on_inputs" to true worked better for the vanilla Llama1, aiding in instruction following, but overall, the performance was still quite poor. For models like Alpaca and Vicuna, this parameter had little effect, so we did not revert it to false for those models.


Update CompileTimeErrorCode.NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER under enhanced_enums

Given the following code:
abstract class C implements Enum {
  int get values => 0;
}
enum E implements C {
  a
}

The analyzer produces two diagnostics at the name of E:
error: Missing concrete implementation of 'getter C.values'. (non_abstract_class_inherits_abstract_member at [test_package] lib/test.dart:4)
error: An instance member named 'values' can't be inherited from 'C' in a class that implements 'Enum'. (illegal_enum_values_inheritance at [test_package] lib/test.dart:4)

The second is valid, but the first should not be reported because it would be wrong for the user to add a concrete implementation of values. The code should special case values when it's being inherited from a class that implements Enum.
Interestingly enough, there are no diagnostics reported if values is replaced by index. I'm not sure whether this is expected.

@scheglov @srawlins

We treat index as a concrete field of class Enum, which is extended by every enum declaration, so it is implemented.

https://dart-review.googlesource.com/c/sdk/+/233968


How to use?

Hi,
so I am trying to compile the Foundation 6.3.0 and I am getting only:
/**
 * Foundation for Sites by ZURB
 * Version 6.3.0
 * foundation.zurb.com
 * Licensed under MIT Open Source
 */

but nothing else.
When I check Compiler::getParsedFiles() all files are there with correct paths.
This is my testing code:
use Leafo\ScssPhp\Compiler;

$scss = new Compiler();
$scss->addImportPath(realpath('../vendor/zurb/foundation/scss'));
echo $scss->compile('@import "foundation.scss";');
kint( $scss->getParsedFiles() );

What am I doing wrong? I don't get any exceptions either.

Aaah, lol. I should have used echo $scss->compile('@import "foundation.scss"; @include foundation-everything(true);');


UNAVAILABLE: server(s) 3D Semantic-Segmentation result submission against the validation set

I have submitted for evaluation against the Validation Set, by uploading the semantic-segmentation result file to the challenge server.
However, I am gating an error message (see fig below).
Has anyone met a similar problem/error, what can be the cause and the appropriate solution?
Thank you.

I had the same error when size of loaded file was too (unexpectedly?)large.

I had the same error when size of uploaded file was too (unexpectedly?)large.

May I ask how you solved it? Can you please give me some insight?
Thank you.

@awethaileslassiein in my case it was a local error when i processed the validation split several times


Add arm64v8 for debian 11 and 12

See https://github.com/docker-library/mongo/blob/beb88756b4622286e9346c2646a54e6dad23e8f2/versions.sh#L145 for where these values are pulled straight from the upstream-published data -- in other words, these aren't listed because the builds don't actually exist (see also https://github.com/docker-library/mongo/blob/beb88756b4622286e9346c2646a54e6dad23e8f2/versions.sh#L198-L218 which is why we end up with Ubuntu-based images -- they're the only ones where these architectures are supported).


Modifying CLI login implementation to Support cellery hub

Purpose

This is implementation is to support CLI login operation via github or google federated authentication.
If the user operated in the headless mode user can provide the username and password/ token to login to the CLI

Test environment

Mac OS Mojave  v10.14.4
wso2is-5.7.0

Codecov Report

Merging #335 into master will decrease coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #335      +/-   ##
==========================================
- Coverage   65.58%   65.36%   -0.23%
==========================================
  Files          28       28
  Lines         712      716       +4
  Branches       48       51       +3
==========================================
+ Hits          467      468       +1
- Misses        212      214       +2
- Partials       33       34       +1

Impacted Files
Coverage Δ

...ang/src/main/java/io/cellery/impl/CreateImage.java
80.41% <0%> (-0.78%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5895e85...c2cd2d7. Read the comment docs.


Changes for Ledger

From Nate at Obsidian Systems via Victor from Ledger:
Use newer logo on import account
Replace:

With these two:

Add "Verify address" button
There are two address related commands that the Ledger app respond to. https://github.com/obsidiansystems/ledger-app-pocket/blob/develop/docs/apdu.md
GET_PUBKEY is used in your wallet already. During the "Import Account" the wallet polls the Ledger app for the first 5 addresses (or more if requested). This view is the result of that interaction:

He is requesting an additional button in your wallet (after import) that will use VERIFY_ADDRESS instead. The difference between the two is that the "verify" version prompts the user after displaying the address on the device. I suggest this new button replace "Export Keyfile" shown here as it is unused/non-functional:
Image

Log Out on Top Right Corner
This button is non-functional

Fixed in #feat: update ledger


[IOS] Can't recognize the purchase after Registering a card because of non-registered card

Our clients who couldn't get coins after purchase increases.
because Clients didn't register card or write wrong informations, IAP let them go to ios-play-store and force to input new card infos. After that, Purchase was successful(money came out) on ios-playstore. And return to our application, it didn't recognize that. As you can see Above the picture, client try again to purchase.. but it can't
try {
                const {sendIapReceipt} = this.props
                const purchase = await RNIap.buyProduct(item.iapItemName)
                const receipt = purchase.transactionReceipt
                if (receipt) {
                    sendIapReceipt({receipt}).then(result => {
                        Toast.show('결제가 완료되었습니다.', Toast.SHORT)
                    }).catch(err => {
                        alert('결제 오류가 발생했습니다. 고객센터에 연락해주세요.')
                    })
                }
            } catch (e) {
                Toast.show(e.toString(), Toast.SHORT)
                const subscription = RNIap.addAdditionalSuccessPurchaseListenerIOS(async (purchase) => {
                    const receipt = purchase.transactionReceipt
                    const {sendIapReceipt} = this.props
                    if (receipt) {
                        sendIapReceipt({receipt}).then(result => {
                            Toast.show('결제가 완료되었습니다.', Toast.SHORT)
                        }).catch(err => {
                            alert('결제 오류가 발생했습니다. 고객센터에 연락해주세요.')
                        })
                    }
                    subscription.remove();
                });
            }

Yeah, this was one of the critical issues we've faced in #307 and I've supported this in #348. You can go over the readme and see how to add this feature.
Also, I hope your company can participate as a backers of our module because this becomes quite large to be handled by just me. I am spending quite a few times maintaining this but I am still seeing quite many issues not covered yet that needs some dev's participation. I'm planning to participate in issue hunter if some backers support this.
P.S. As a billing library update, it is just a burden for me to handle migration to cover an issue like #391. Hope there is some help out there to maintain this.

I just looked into this again, and I think you are facing a different problem. Are you really sure that you are not getting the value out of addAdditionalSuccessPurchaseListenerIOS? I think you want the customers to actually rebuy the item. Looks like the products should be consumable but I think it is currently non-consumable.

Closed for inactivity.


NO-ISSUE: drop scripts/logic folder as it is deprecated

Many thanks for submitting your Pull Request :heart:!
Please make sure your PR meets the following requirements:

[ ] You have read the contributors guide
[ ] Pull Request title is properly formatted: [KOGITO|RHPAM-XYZ] Subject
[ ] Pull Request contains link to the JIRA issue
[ ] Pull Request contains description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket
[ ] Your feature/bug fix has a testcase that verifies it
[ ] You've tested the new feature/bug fix in an actual OpenShift cluster
[ ] You've added a RELEASE_NOTES.md entry regarding this change

How to retest this PR or trigger a specific build:

(Re)run Jenkins tests
Please add comment: Jenkins [test|retest] this

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

PR job #56 was: FAILURE
Possible explanation: Pipeline failure or project build failure
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/56/display/redirect
See console log:

Console Logs
	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:623)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:852)	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:158)	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:151)	at hudson.remoting.UserRequest.perform(UserRequest.java:211)	at hudson.remoting.UserRequest.perform(UserRequest.java:54)	at hudson.remoting.Request$2.run(Request.java:377)	at hudson.remoting.InterceptingExecutorService.lambda$wrap$0(InterceptingExecutorService.java:78)	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)	at java.base/java.lang.Thread.run(Thread.java:829)	Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to builds29		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1784)		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)		at hudson.remoting.Channel.call(Channel.java:1000)		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:143)		at jdk.internal.reflect.GeneratedMethodAccessor1498.invoke(Unknown Source)		at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)		at java.base/java.lang.reflect.Method.invoke(Method.java:566)		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:129)		at com.sun.proxy.$Proxy228.execute(Unknown Source)		at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1226)		at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1309)		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:129)		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:97)		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:84)		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)		at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)		at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)		at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)		at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)		at java.base/java.lang.Thread.run(Thread.java:829)[Pipeline] deleteDir[Pipeline] }[Pipeline] // dir[Pipeline] }[Pipeline] // dir[Pipeline] }[Pipeline] // script[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Declarative: Post Actions)[Pipeline] script[Pipeline] {[Pipeline] sh+ wget --no-check-certificate -qO - 'https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/56/api/json?depth=0'[Pipeline] readJSON[Pipeline] sh

@rgdoliveira can you please rename your fork to: repository 'https://github.com/rgdoliveira/incubator-kie-kogito-images.git/' not found
We currently have an issue in this pipeline here: #1729

ok, thanks for letting me know, I just renamed it

Can you sen a force push to refresh the CI? 😬

PR job #58 was: ABORTED
Possible explanation: Most probably a timeout, please review
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/58/display/redirect
See console log:

Console Logs
08:24:33 INFO Trying to validate file kogito-swf-devmode-image.yaml as [Lorg.kie.cekit.image.descriptors.image.Image;08:24:33 INFO File multi images [kogito-swf-devmode-image.yaml] loaded and validated[Pipeline] sh+ ./cekit-image-validator-runner kogito-task-console-image.yaml__  ____  __  _____   ___  __ ____  ______  --/ __ \/ / / / _ | / _ \/ //_/ / / / __/  -/ /_/ / /_/ / __ |/ , _/ ,< / /_/ /\ \   --\___\_\____/_/ |_/_/|_/_/|_|\____/___/   08:24:37 INFO Provided param is a regular file, analyzing it...08:24:37 INFO Trying to validate file kogito-task-console-image.yaml08:24:37 INFO Trying to validate file kogito-task-console-image.yaml as org.kie.cekit.image.descriptors.image.Image08:24:37 INFO File image [kogito-task-console-image.yaml] loaded and validated[Pipeline] }[Pipeline] // dir[Pipeline] }[Pipeline] // script[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Build & Test Images)[Pipeline] script[Pipeline] {[Pipeline] dirRunning in /home/jenkins/jenkins-agent/workspace/KIE/kogito/main/pullrequest/kogito-images.build-and-test/incubator-kie-kogito-images[Pipeline] {[Pipeline] dirRunning in /home/jenkins/jenkins-agent/workspace/KIE/kogito/main/pullrequest/kogito-images.build-and-test/incubator-kie-kogito-images/githubscm-prepare-commit-incubator-kie-kogito-images[Pipeline] {[Pipeline] echo[INFO] Resolving Repository https://github.com/rgdoliveira/incubator-kie-kogito-images:logic_folder. CredentialsID: 399061d0-5ab5-4142-a186-a52081fef742[Pipeline] checkoutThe recommended git tool is: NONEAborted by Roberto Oliveira[Pipeline] deleteDir[Pipeline] }[Pipeline] // dir[Pipeline] }[Pipeline] // dir[Pipeline] }[Pipeline] // script[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Declarative: Post Actions)[Pipeline] script[Pipeline] {[Pipeline] sh+ wget --no-check-certificate -qO - 'https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/58/api/json?depth=0'[Pipeline] readJSON[Pipeline] sh

@ricardozanini I rerun the PR job via Jenkins UI in https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images-pr/view/change-requests/job/PR-1733/
It is running again

PR job #60 was: UNSTABLE
Possible explanation: This should be test failures
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/60/display/redirect
See console log:

Console Logs
[Pipeline] }[Pipeline] // stage[Pipeline] }[Pipeline] }[Pipeline] // stage[Pipeline] }[Pipeline] }[Pipeline] // stage[Pipeline] }[Pipeline] }[Pipeline] // stage[Pipeline] }[Pipeline] }[Pipeline] // stage[Pipeline] }[Pipeline] }[Pipeline] // stage[Pipeline] }[Pipeline] }[Pipeline] // stage[Pipeline] }[Pipeline] }[Pipeline] // stage[Pipeline] }[Pipeline] }[Pipeline] // stage[Pipeline] }[Pipeline] unstableWARNING: Tests on kogito-swf-devmode seems to have failed[Pipeline] }[Pipeline] // stage[Pipeline] }[Pipeline] }[Pipeline] // stage[Pipeline] }[Pipeline] // parallel[Pipeline] }[Pipeline] // dir[Pipeline] }[Pipeline] // script[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Declarative: Post Actions)[Pipeline] script[Pipeline] {[Pipeline] sh+ wget --no-check-certificate -qO - 'https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/60/api/json?depth=0'[Pipeline] readJSON[Pipeline] sh

PR job #62 was: FAILURE
Possible explanation: Pipeline failure or project build failure
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/62/display/redirect
See console log:

Console Logs
From https://github.com/rgdoliveira/incubator-kie-kogito-images * branch              logic_folder -> FETCH_HEADhint: You have divergent branches and need to specify how to reconcile them.hint: You can do so by running one of the following commands sometime beforehint: your next pull:hint: hint:   git config pull.rebase false  # merge (the default strategy)hint:   git config pull.rebase true   # rebasehint:   git config pull.ff only       # fast-forward onlyhint: hint: You can replace "git config" with "git config --global" to set a defaulthint: preference for all repositories. You can also pass --rebase, --no-rebase,hint: or --ff-only on the command line to override the configured default perhint: invocation.fatal: Need to specify how to reconcile divergent branches.[Pipeline] }[Pipeline] // withCredentials[Pipeline] echo        -------------------------------------------------------------        [ERROR] Can't merge source into Target. Please rebase PR branch.        -------------------------------------------------------------        Source: git://github.com/rgdoliveira/incubator-kie-kogito-images logic_folder        Target: feebea2e [NO-ISSUE] Remove MongoDB leftovers duo to ASF restrictions (#1732)        ------------------------------------------------------------- [Pipeline] }[Pipeline] // dir[Pipeline] }[Pipeline] // script[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Validate CeKit Image and Modules descriptors)Stage "Validate CeKit Image and Modules descriptors" skipped due to earlier failure(s)[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Build & Test Images)Stage "Build & Test Images" skipped due to earlier failure(s)[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Declarative: Post Actions)[Pipeline] script[Pipeline] {[Pipeline] sh+ wget --no-check-certificate -qO - 'https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/62/api/json?depth=0'[Pipeline] readJSON[Pipeline] sh

PR job #64 was: FAILURE
Possible explanation: Pipeline failure or project build failure
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/64/display/redirect
See console log:

Console Logs
From https://github.com/rgdoliveira/incubator-kie-kogito-images * branch              logic_folder -> FETCH_HEADhint: You have divergent branches and need to specify how to reconcile them.hint: You can do so by running one of the following commands sometime beforehint: your next pull:hint: hint:   git config pull.rebase false  # merge (the default strategy)hint:   git config pull.rebase true   # rebasehint:   git config pull.ff only       # fast-forward onlyhint: hint: You can replace "git config" with "git config --global" to set a defaulthint: preference for all repositories. You can also pass --rebase, --no-rebase,hint: or --ff-only on the command line to override the configured default perhint: invocation.fatal: Need to specify how to reconcile divergent branches.[Pipeline] }[Pipeline] // withCredentials[Pipeline] echo        -------------------------------------------------------------        [ERROR] Can't merge source into Target. Please rebase PR branch.        -------------------------------------------------------------        Source: git://github.com/rgdoliveira/incubator-kie-kogito-images logic_folder        Target: feebea2e [NO-ISSUE] Remove MongoDB leftovers duo to ASF restrictions (#1732)        ------------------------------------------------------------- [Pipeline] }[Pipeline] // dir[Pipeline] }[Pipeline] // script[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Validate CeKit Image and Modules descriptors)Stage "Validate CeKit Image and Modules descriptors" skipped due to earlier failure(s)[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Build & Test Images)Stage "Build & Test Images" skipped due to earlier failure(s)[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Declarative: Post Actions)[Pipeline] script[Pipeline] {[Pipeline] sh+ wget --no-check-certificate -qO - 'https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/64/api/json?depth=0'[Pipeline] readJSON[Pipeline] sh

I just rebased this PR as the test was complaining.
Error message [ERROR] Can't merge source into Target. Please rebase PR branch.

PR job #65 was: UNSTABLE
Possible explanation: This should be test failures
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/65/display/redirect
See console log:

Console Logs
[Pipeline] }[Pipeline] // stage[Pipeline] }[Pipeline] }[Pipeline] // stage[Pipeline] }[Pipeline] }[Pipeline] // stage[Pipeline] }[Pipeline] }[Pipeline] // stage[Pipeline] }[Pipeline] }[Pipeline] // stage[Pipeline] }[Pipeline] }[Pipeline] // stage[Pipeline] }[Pipeline] }[Pipeline] // stage[Pipeline] }[Pipeline] }[Pipeline] // stage[Pipeline] }[Pipeline] }[Pipeline] // stage[Pipeline] }[Pipeline] }[Pipeline] // stage[Pipeline] }[Pipeline] unstableWARNING: Tests on kogito-swf-devmode seems to have failed[Pipeline] }[Pipeline] // stage[Pipeline] }[Pipeline] // parallel[Pipeline] }[Pipeline] // dir[Pipeline] }[Pipeline] // script[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Declarative: Post Actions)[Pipeline] script[Pipeline] {[Pipeline] sh+ wget --no-check-certificate -qO - 'https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/65/api/json?depth=0'[Pipeline] readJSON[Pipeline] sh


Option to hide mouse cursor does not work.

Platform:
MacOS High Sierra
Kap Version:
1.0.1 (<IP_ADDRESS>)
Steps to reproduce
Set mouse cursor to hidden in preferences.
Current behaviour
Mouse cursor is not hidden, even after restart of the app.
Expected behaviour
Mouse cursor should be hidden in recordings.
Workaround
None I know of.
Extra Request
If this is going to be fixed, it would be great to have the mouse cursor hidden, but also show clicks. At the moment you can only set clicks to show if the mouse cursor is set to visible. It would great to have the ability for both combinations.

Seems to be fixed on latest update. Thanks.


[Storage][DataMovement] Rename ErrorHandlingOptions and remove unused types

Went through all public types for the base package and Blobs package to audit type names. I found only ErrorHandlingOptions as something we should rename since it's not actually an options bag. Also removed some left over types from removing async copy.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Storage.DataMovement


Set datatype of counts dataframe in get_expression_data to integer

The issue
In abagen.get_expression_data() we create a counts dataframe that keep tracks of the number of samples from each donor that are assigned to a given region of interest in whatever atlas the user provides. Currently this dataframe is created with float values, but since it's just a tally it would be great if we explicitly set it to be int.
Proposed solution
Modify the instantiation of the dataframe to explicitly set the datatype to int, from:
counts = pd.DataFrame(np.zeros((len(all_labels) + 1, num_subj)),
                      index=np.append([0], all_labels))

to
counts = pd.DataFrame(np.zeros((len(all_labels) + 1, num_subj), dtype=int),
                      index=np.append([0], all_labels))

should do the trick!

Closed with #127


Reloading Stylesheets Agressively

Since it's stylesheets might include other stylesheets, it's hard to
track down which one include which. So easier solution would be Reloaded
all stylesheets that's modified and reload the VC.
Should not have impact the performance.

I think PR #244 is newer right? Closing.


update to zig 0.13.0

just noticed #4 while making this myself but i'll open this PR anyway since it also fixes a test

Hi! thanks for the PR, unfortunately i tend to upgrade all my packages in tandem which are still on 0.12 at the moment. I'm close to finishing tho so i'll spend some time today to wrap that up and do 0.13 soon


[DRAFT] STM32: Add TIM register mappings for STM32G47xxx family

Summary
This is a DRAFT (work in progress) PR.
The STM32G47xxx family's TIM blocks have quite a few features and variations. Rather than increase the ifdef rash in the arch/arm/src/stm32/hardware/stm32_tim.h file, I created a separate file to hold all the definitions (for now).
Possible courses of action:

Rework and merge the register definitions into arch/arm/src/stm32/hardware/stm32_tim.h
or
Move the contents of arch/arm/src/stm32/hardware/stm32_tim.h into one or more new file(s) and turn arch/arm/src/stm32/hardware/stm32_tim.h into an empty header that just includes the correct files.

Impact
Adds register definitions to make it possible to support STM32G47xxx's TIM peripherals.
Testing
nxstyle only.

Finally closing this pull request! @raiden00pl completed this work and integrated it in PR #3544.


Match aws secrets manager support

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary. (https://github.com/fastlane/docs/pull/1179)

Motivation and Context
It adds support for AWS Secrets manager as a storage backend.
S3 is as secure if configured properly, but it has a bad reputation.
Resolves #999999
Description
Added AWS Secrets manager as a storage backend. It follows the same principles as the S3 backend.
Tested through unit tests and inside a live project.
Testing Steps
Configure secrets manager as the backend in the Matchfile.

Do you have any idea why the tests are failing? Locally they all passed.

Do you have any idea why the tests are failing? Locally they all passed.

@stanogn looks like they're primarily failing because the HTTP requests are not being stubbed - see https://app.circleci.com/pipelines/github/fastlane/fastlane/5125/workflows/4a083bb3-8492-4d94-b63b-3ba8ba8a34a7/jobs/87740
for example for one test it says
  10) Match Match::Storage::AWSSecretsManagerStorage#download downloads secrets and strips the aws_secrets_manager_prefix for working_directory path
      Failure/Error: subject { described_class.new(aws_secrets_manager_region: nil, aws_secrets_manager_access_key: nil, aws_secrets_manager_secret_access_key: nil, team_id: 'test_team_id') }

      WebMock::NetConnectNotAllowedError:
        Real HTTP connections are disabled. Unregistered request: PUT http://<IP_ADDRESS>/latest/api/token with headers {'Accept'=>'*/*', 'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent'=>'aws-sdk-ruby3/3.167.0', 'X-Aws-Ec2-Metadata-Token-Ttl-Seconds'=>'21600'}

        You can stub this request with the following snippet:

        stub_request(:put, "http://<IP_ADDRESS>/latest/api/token").
          with(
            headers: {
        	  'Accept'=>'*/*',
        	  'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
        	  'User-Agent'=>'aws-sdk-ruby3/3.167.0',
        	  'X-Aws-Ec2-Metadata-Token-Ttl-Seconds'=>'21600'
            }).
          to_return(status: 200, body: "", headers: {})

        registered request stubs:

        stub_request(:any, "/developer.apple.com\/services-account\/QH65B2\/account\/ios\/identifiers\/.*OMC(s){0,1}\.action/")
        stub_request(:any, "/developer.apple.com\/services-account\/QH65B2\/account\/auth\/key/")
        stub_request(:any, "/appstoreconnect.apple.com\/testflight\/v2/")

if you search the code base for stub_request you can see a few other examples

@stanogn can you merge master in and resolve the merge conflicts? i think it's good to merge otherwise


Look into Gyro Mounting

NavX Omnimount: https://pdocs.kauailabs.com/navx-mxp/installation/omnimount/
If we're planning to use the NavX at an atypical angle, we need to use this calibration procedure... that said, one of the axes has to be perpendicular to the surface, which it currently is not.
Just something to think about, if we intend to use the gyro. Thoughts/input?

Let's see if we can use this in conjunction with #56 in order to keep both the front and back stilts moving at the same speed

I’d look at using encoders for this, I’m not sure if you saw my post in the
duplicate issue of this you created, but the navX will not work in the
position it’s currently mounted
On Fri, Feb 8, 2019 at 22:22 Ashwin Chitoor<EMAIL_ADDRESS>wrote:

Let's see if we can use this in conjunction with #56
https://github.com/FRCteam4909/2019-Deep-Space/issues/56 in order to
keep both the front and back stilts moving at the same speed
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/FRCteam4909/2019-Deep-Space/issues/63#issuecomment-462008904,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEUIR8WIXP5jtv_alYANpK9fKIy3FyUSks5vLj8DgaJpZM4ahm0C
.

We are going to remount the Rio on its angled board so that it is horizontally oriented. The gyros will then work properly, and should provide better control than encoders. (There are two entirely different mechanisms for the front and rear stilts, so getting encoders to align them would be a complicated math problem. Certainly doable, but I think the gyro may be substantially easier to get working.

Tested, working— closing


Support for Runtine: python3.11

Describe the feature
Will you add support for Runtine: python3.11?
https://github.com/boto/botocore/blob/99d6a50ea6c2bf6e78e9dbe8dcb1e23e391f3fc1/botocore/data/lambda/2015-03-31/service-2.json#L5199C1-L5234C1
Use Case
I would like to deploy my new lambdas using python3.11
Proposed Solution
No response
Other Information
No response
Acknowledgements

[ ] I may be able to implement this feature request
[ ] This feature might incur a breaking change

SDK version used
1.30.1
Environment details (OS name and version, etc.)
ubuntu 22.04

Thanks for the feature request — this would need to be supported by Lambda first. They are tracking this feature request here: https://github.com/aws/aws-lambda-base-images/issues/62. Once they support Python 3.11 they will update the service API model file you linked to add that as a runtime enum value. Please refer to that issue for updates going forward.


Implement Format and Interpretation

I tried implementing Format[] and it was terrible. I like the StringForm(format) method (currently implemented) better.


install_v8 missing gclient sync

The install_v8 function of build.sh should also call gclient sync otherwise some key components don't get fetched namely the v8/thrid-party/llvm-build where the build.sh is expecting to find the clang compiler so the build later just fails.

ignore, it is actually called as part of the fetch v8, my prob was missing curl binary which is used by the gclient...


fix prepare_pip_source_args not properly handle user & pw in repo URLs

When the I use a custom source in the Pipfile that is protected by a user & password.
The logic in prepare_pip_source_args tries to manually parse ParseResult.netloc (returned from urlparse) this results in the username being passed as the --trusted-host when verify_ssl is set to false in the Pipfile.
For example, if one of the sources in the Pipfile is<EMAIL_ADDRESS>it will result calling resolver.py with the wrong params (passed via the PIPENV_PACKAGES environment variable) and called from venv_resolve_deps
the value of the  --trusted-host will be the username instead of the host name.
https://github.com/pypa/pipenv/issues/1773

I think one of the builds fail due to an error unrelated to my changes...
http://mercury.home.kennethreitz.org:8080/job/pipenv/201/PYTHON=CPython-2.7.14/console
Installing initially–failed dependencies…
Collecting white==0.1.2

  Could not find a version that satisfies the requirement white==0.1.2 (from -r /tmp/pipenv-tnzIc6-requirements/pipenv-eU03nG-requirement.txt (line 1)) (from versions: )
No matching distribution found for white==0.1.2 (from -r /tmp/pipenv-tnzIc6-requirements/pipenv-eU03nG-requirement.txt (line 1))

/var/lib/jenkins/workspace/pipenv/PYTHON/CPython-2.7.14/pipenv/utils.py:1233: ResourceWarning: Implicitly cleaning up <TemporaryDirectory '/tmp/pipenv-tnzIc6-requirements'>
  warnings.warn(warn_message, ResourceWarning)
Build step 'Virtualenv Builder' marked build as failure```

Hey @asherf thanks for the PR! I was looking at our handling of this within the last few days as I was skimming some of our codebase and I was pretty skeptical that we were handling this. I haven’t had a chance to look over the changes here (been away from my desk all day) but I’ll get through the backlog tomorrow!
Thanks again!


Howto use this database with TokenMint

Hi,
is there an example or howto use this database with TokenMint?

this is a database of deposits for users who pay using shapeshift.  It is not necessary for using TokenMint unless you want to connect it to a shapeshift account.
Right now, the shapeshift feature is not enabled on TokenMint (the button is just disabled, you can enable it if you want).

So if someone want to contribute with BTC or any other tokens they can use shapeshift and TokenMint will convert to ETH and send back ERC-20 tokens? Or is there any other purpose?

that's the only purpose. to keep track of shapeshift transactions.

Do you have any example how to connect TokenMint with token-rs that BTC is converted back to ERC-20 tokens?


IMF DSD ECOFIN_DSD: TIME_FORMAT shows up as attribute and dimension

'''
msg=sdmx.read_sdmx('ECOFIN_DSD.xml')
dsd=msg.structure.ECOFIN_DSD
[(d.id, d.order) for d in dsd.dimensions]
[('DATA_DOMAIN', 1),
('REF_AREA', 2),
('INDICATOR', 3),
('COUNTERPART_AREA', 4),
('FREQ', 5),
('TIME_PERIOD', 6),
('TIME_FORMAT', 1)]
'''
TIME_FORMAT should only occur as attribute. The bug seems to surface only when the DSD is retrieved with defaulted references param, i.e. 'msg=imf.datastructure('ECOFIN_DSD')`

For clarification: TIME_FORMAT should only be rendered as attribute. The dimensions extracted with LXML.etree are as follows:
Out[25]:
[{'urn': 'urn:sdmx:org.sdmx.infomodel.datastructure.Dimension=IMF:ECOFIN_DSD(1.0).DATA_DOMAIN', 'id': 'DATA_DOMAIN', 'position': '1'},
 {'urn': 'urn:sdmx:org.sdmx.infomodel.datastructure.Dimension=IMF:ECOFIN_DSD(1.0).REF_AREA', 'id': 'REF_AREA', 'position': '2'},
 {'urn': 'urn:sdmx:org.sdmx.infomodel.datastructure.Dimension=IMF:ECOFIN_DSD(1.0).INDICATOR', 'id': 'INDICATOR', 'position': '3'},
 {'urn': 'urn:sdmx:org.sdmx.infomodel.datastructure.Dimension=IMF:ECOFIN_DSD(1.0).COUNTERPART_AREA', 'id': 'COUNTERPART_AREA', 'position': '4'},
 {'urn': 'urn:sdmx:org.sdmx.infomodel.datastructure.Dimension=IMF:ECOFIN_DSD(1.0).FREQ', 'id': 'FREQ', 'position': '5'},
 {'urn': 'urn:sdmx:org.sdmx.infomodel.datastructure.TimeDimension=IMF:ECOFIN_DSD(1.0).TIME_PERIOD', 'id': 'TIME_PERIOD', 'position': '6'}]

This is an error in the data returned by the IMF source. The data:
import pandasdmx as sdmx
sdmx.Request('IMF').datastructure('ECOFIN_DSD', tofile='debug.xml')

$ xmllint --format debug.xml >debug-format.xml

contains a definition for a <str:Attribute id="TIME_FORMAT"> but no Dimension with that ID.
Later, in the constraints for specific data flows, it includes both:
      <str:ContentConstraint urn="urn:sdmx:org.sdmx.infomodel.registry.ContentConstraint=IMF:01R_CONSTRAINT(1.0)" isExternalReference="false" agencyID="IMF" id="01R_CONSTRAINT" isFinal="false" type="Allowed" version="1.0">
        <com:Name xml:lang="en">01R_CONSTRAINT</com:Name>
        <str:ConstraintAttachment>
          <str:Dataflow>
            <Ref package="datastructure" agencyID="IMF" id="01R" version="1.0" class="Dataflow"/>
          </str:Dataflow>
        </str:ConstraintAttachment>
        <str:CubeRegion include="true">
          ...
          <com:KeyValue id="TIME_FORMAT">
            <com:Value>PT1M</com:Value>
            <com:Value>P6M</com:Value>
            <com:Value>P3M</com:Value>
            <com:Value>P1M</com:Value>
            <com:Value>P1Y</com:Value>
            <com:Value>P7D</com:Value>
            <com:Value>P1D</com:Value>
          </com:KeyValue>
        </str:CubeRegion>
      </str:ContentConstraint>

and
      <str:ContentConstraint urn="urn:sdmx:org.sdmx.infomodel.registry.ContentConstraint=IMF:CBS_CONSTRAINT(1.0)" isExternalReference="false" agencyID="IMF" id="CBS_CONSTRAINT" isFinal="false" type="Allowed" version="1.0">
        <com:Name xml:lang="en">CBS_CONSTRAINT</com:Name>
        <str:ConstraintAttachment>
          <str:Dataflow>
            <Ref package="datastructure" agencyID="IMF" id="CBS" version="1.0" class="Dataflow"/>
          </str:Dataflow>
        </str:ConstraintAttachment>
        <str:CubeRegion include="true">
          ...
          <com:Attribute id="TIME_FORMAT">
            <com:Value>P6M</com:Value>
            <com:Value>P1Y</com:Value>
            <com:Value>P3M</com:Value>
            <com:Value>P1M</com:Value>
          </com:Attribute>
        </str:CubeRegion>
      </str:ContentConstraint>

Note the difference between <com:KeyValue> and <com:Attribute>. The XML schema—in particular, SDMXCommon.xsd—shows:
<xs:complexType name="CubeRegionType">
  <xs:annotation>
    <xs:documentation>CubeRegionType defines the structure of a data cube region. This is based on the abstract RegionType and simply refines the key and attribute values to conform with what is applicable for dimensions and attributes, respectively. See the documentation of the base type for more details on how a region is defined.</xs:documentation>
  </xs:annotation>
  <xs:complexContent>
    <xs:restriction base="RegionType">
      <xs:sequence>
        <xs:element name="KeyValue" type="CubeRegionKeyType" minOccurs="0" maxOccurs="unbounded"/>
        <xs:element name="Attribute" type="AttributeValueSetType" minOccurs="0" maxOccurs="unbounded"/>
      </xs:sequence>
    </xs:restriction>
  </xs:complexContent>
</xs:complexType>

and later:

CubeRegionKeyType is a type for providing a set of values for a dimension for the purpose of defining a data cube region.

AttributeValueSetType defines the structure for providing values for a data attribute.

At a rough count, <com:Attribute id="TIME_FORMAT"> (the correct usage) occurs 19 times, and <com:KeyValue id="TIME_FORMAT"> (the incorrect usage) occurs 39 times.

For this specific content, namely:

<com:KeyValue> is used with a specific ID.
The DSD (if one is in the message or supplied by the user) does not have a Dimension with this ID.
The DSD (if one in the message or supplied by the user) has an Attribute with the same ID.

…I can imagine at least three behaviours:

Interpret the <com:KeyValue> as specified in the standard—referring to a Dimension object, although one that may not be explicitly defined in the current message.
Interpret the situation as an error and refuse to parse the message.
Interpret the situation as this particular IMF mistake and cover for it, i.e. use the Attribute even though the XML element unambiguously indicates a Dimension.

(1) is the current behaviour. This is essential to parsing any message where the DSD is not included or supplied by the user, e.g. many DataMessages: a Dimension object must be created for every dimension that is referred to by KeyValue XML elements; a DataAttribute object for every attribute referred to by Attribute XML elements, etc.
I assume, due to the fixation on this particular DSD, that (2) is undesirable.
(3) is the start of a very slippery slope of introducing workarounds and special treatment for non-IM content. One workaround becomes the excuse for a second and third, and then the possibilities for them to interact in weird ways (and produce behaviour that's unintelligible to the user) multiplies geometrically. I, at least, have no time whatsoever for maintaining that kind of code.

Your interpretation ignores how the chapter on Content constraints in the technical notes (Part 6 of the SDMX Standard?) specifies the cascade of constraints attachable at each of the three Levels (DSD, Dataflow and ProvisionAgreement). It is stated therein that a constraint must not be interpreted so as to extend the set of codes allowed at the higher Levels. The Absence of a TIME_FORMAT Dimension in the DSD thus dictates what I consider as the only reasonable behavior: ignore any KeyValue of a CubeRegion not matchd by any constrainable Dimension defined by the DSD. The same would obviously  hold true if a DSD-Level constraint yielded a codeset <= the one defined by a lower-level constraint, say, at Dataflow-level. The latter would not Change a bit notwithstanding that it would in the Absence of a more restrictive DSD-level constraint.
I am puzzled by how you describe the construction of the KeyValue from a dataset absent the DSD. In v0.9 I construct the ordered set of Dimension IDs from some SeriesKey, i.e. the KeyValues which are descendents of a SeriesKey  node rather than the set of all keyValues found somewhere in the dataset.
Summing up, I do not see any error in that StructureMessage from the IMF merely because the KeyValue for TIME_FORMAT is redundant in this particular context. In a different context, i.e. applied to a DSD, or Dataflow structured by it, which happens to define a TIME_FORMAT Dimension, it makes perfect sense (notwithstanding that the com:Attribute of the same ID would then be regarded as redundant). I assume that the sets of Dimension IDs and Attribute IDs must be disjoint although this is not explicitly stated anywhere. But otherwise, structure-specific datasets would be ambiguous. Part of the Beauty of SDMX is the reusability of artefacts. The lax usage of TIME_FORMAT in the constraint you Quote is the consequence of that reusability.
The above understanding is compatible with the Schema you Quote.
The current behavior is untenable also because it results in two dimensions with order 1 (wherever the order Attribute of TIME_FORMAT "Dimension" Comes from).
Finally, we may merely see the tip of the iceberg here. The "fixation" on this particular DSD is simply due to my time constraints.

To add:
If the DSD did not define a TIME_FORMAT Attribute in its AttributeDescriptor either, the same constraint being attached to the dataflow, you wouldn't even know the codelist representing These ficticious components. OK, you might still settle for the codes included in the constraint. But what if the constraint is excluding, i.e. subtracting some codes from the codelist referenced by the Dimension or Attribute through their Concept-identities?
The current algorithm seems to be partially flawed. Dimensions and Attributes are simply to be constructed from "members" of the respective descriptors, that's it.

ignore any KeyValue of a CubeRegion not matchd by any constrainable Dimension defined by the DSD

Let's call this idea behaviour (4). It seems like a reasonable approach. It would require changing .get(...) here to item indexing [...]: https://github.com/dr-leo/pandaSDMX/blob/3d2507d6232132eb2313b0eba6f4e3c2423f742e/pandasdmx/reader/sdmxml.py#L1283-L1285
This will raise KeyError when the component (dimension or attribute) is missing, which must then be handled. What should the code do when if it chooses to ignore elements of a message? Log a warning?

I am puzzled by how you describe the construction of the KeyValue from a dataset absent the DSD. In v0.9 I construct the ordered set of Dimension IDs from some SeriesKey, i.e. the KeyValues which are descendents of a SeriesKey node rather than the set of all keyValues found somewhere in the dataset.

These are the same thing. A DataSet only has one DimensionDescriptor; "all KeyValues found somewhere in the dataset" must appear in it.

I do not see any error in that StructureMessage from the IMF merely because the KeyValue for TIME_FORMAT is redundant in this particular context. In a different context, i.e. applied to a DSD, or Dataflow structured by it, which happens to define a TIME_FORMAT Dimension, it makes perfect sense (notwithstanding that the com:Attribute of the same ID would then be regarded as redundant).

The XML snippets are constraints for particular dataflows, e.g. 01R in the first example; read the <str:ConstraintAttachment> tag. These dataflows are defined (elsewhere in the same message) as being structured by ECOFIN_DSD:
      <str:Dataflow urn="urn:sdmx:org.sdmx.infomodel.datastructure.Dataflow=IMF:01R(1.0)" isExternalReference="false" agencyID="IMF" id="01R" isFinal="false" version="1.0">
        <com:Name xml:lang="en">Exchange Rates and International Reserves (01R) for Collection</com:Name>
        <com:Description xml:lang="en">Exchange Rates and International Reserves (01R) for Collection</com:Description>
        <str:Structure>
          <Ref package="datastructure" agencyID="IMF" id="ECOFIN_DSD" version="1.0" class="DataStructure"/>
        </str:Structure>
      </str:Dataflow>

All three of these objects—01R_CONSTRAINT, 01R, and ECOFIN_DSD—have URNs, meaning that the definitions in this message are complete, final, and globally unique.
So there's a few possibilities:

IMF (or someone else) has a DSD (other than ECOFIN_DSD) that has a TIME_FORMAT Dimension, and a dataflow structured by it (other than 01R) that refers to 01R_CONSTRAINT. This other dataflow is not included in the <str:ConstraintAttachment> of 01R_CONSTRAINT, yet IMF does maintain the otherwise-useless KeyValues for usage in this other dataflow and other DSD.
IMF has plans to someday issue new versions of 01R and/or ECOFIN_DSD to add a TIME_FORMAT Dimension without revising 01R_CONSTRAINT.
It's an error; IMF meant to constrain the TIME_FORMAT Attribute.

I guess one can't know without asking, but in my view Ockham's razor applies.

I assume that the sets of Dimension IDs and Attribute IDs must be disjoint although this is not explicitly stated anywhere. But otherwise, structure-specific datasets would be ambiguous.

The standards don't oblige anyone to produce or convey structure-specific XML. What you seem to have identified is a binary choice that data providers must make for each DSD: either have disjoint component IDs, or be unable to produce structure-specific XML.

The "fixation" on this particular DSD is simply due to my time constraints.

That's understandable! But, in your view, how many/which other particular queries will need the same amount of attention before #145 can be addressed?

Does Ockham's Razor apply?
I couldn't care less. It is not our Job to second-guess the IMF's
reasons for providing redundant, if confusing, stuff in its Messages,
or worse, to contrive algorithms to exhaust all artefacts within an
SDMX message. We get lots of unused codes in codelists, validate keys
in the elusive hope that there will be data for some data Point etc.
Our self-inflicted task is simply to implement an SDMX 2.1-compliant
Client. And this means we must not invent components out of the blue
only to Prevent some constraint from being what it is: useless
according to the rules of the standard.
I don't know why such exception is raised. I thought a constraint is
attached to a DSD, Dataflow or ProvisionAgreement. Here, each
constraint is attached to some ConstrainableArtefact, whether or not
there is something to constrain.
In v0.9, the source of all my biases, I have implemented the cascading
algorithm for constraints as a method of the message class. I still
believe this is the best place, except Maybe outside any class. It
starts from the dimensions described by the DSD structuring the
present dataflow, takes the codelists as startingpoints, converts them
to sets for Efficiency, so I work with Hashes of strings rather than
Code instances. I check if there are constraints attached to the DSD,
Strip off any codes from the codesets as specified by the relevant
constraints, do the same for constraints attached to the Dataflow and
in Theory, provisionagreements. - As a pragmatic, though not
standard-compliant decision, I disregarded constraints on Attributes
as those are merely useful to dataset providers, while v0.9 only wants
to be a tool for data consumers.
I assume you know all that. therefore, I wonder how a constraint in
v1.0dev can be incomplete or lacking some key merely because the
dataflow or DSD it is attached to does not mirror all the keyvalues or
Attribute IDs present in the constraint.
A constraint is a self-contained artefact. It can live without being
useful. If the artefact it is attached to is not present in the
current message, query it! - I think SDMX even supports requests for
bare constraints much like a datastructure may reference a ton of
concepts/codelists not present in the message just because the
references param was set to None.
On 22/04/2020, Paul Natsuo Kishimoto<EMAIL_ADDRESS>wrote:

ignore any KeyValue of a CubeRegion not matchd by any constrainable
Dimension defined by the DSD

Let's call this idea behaviour (4). It seems like a reasonable approach. It
would require changing .get(...) here to item indexing [...]:
https://github.com/dr-leo/pandaSDMX/blob/3d2507d6232132eb2313b0eba6f4e3c2423f742e/pandasdmx/reader/sdmxml.py#L1283-L1285

This will raise KeyError when the component (dimension or attribute) is
missing, which must then be handled. What should the code do when if it
chooses to ignore elements of a message? Log a warning?

I am puzzled by how you describe the construction of the KeyValue from a
dataset absent the DSD. In v0.9 I construct the ordered set of Dimension
IDs from some SeriesKey, i.e. the KeyValues which are descendents of a
SeriesKey node rather than the set of all keyValues found somewhere in the
dataset.

These are the same thing. A DataSet only has one DimensionDescriptor; "all
KeyValues found somewhere in the dataset" must appear in it.

I do not see any error in that StructureMessage from the IMF merely
because the KeyValue for TIME_FORMAT is redundant in this particular
context. In a different context, i.e. applied to a DSD, or Dataflow
structured by it, which happens to define a TIME_FORMAT Dimension, it
makes perfect sense (notwithstanding that the com:Attribute of the same ID
would then be regarded as redundant).

The XML snippets are constraints for particular dataflows, e.g. 01R in the
first example; read the <str:ConstraintAttachment> tag. These dataflows
are defined (elsewhere in the same message) as being structured by
ECOFIN_DSD:

  <str:Dataflow

urn="urn:sdmx:org.sdmx.infomodel.datastructure.Dataflow=IMF:01R(1.0)"
isExternalReference="false" agencyID="IMF" id="01R" isFinal="false"
version="1.0">

    <com:Name xml:lang="en">Exchange Rates and International Reserves

(01R) for Collection</com:Name>

    <com:Description xml:lang="en">Exchange Rates and International

Reserves (01R) for Collection</com:Description>

    <str:Structure>

      <Ref package="datastructure" agencyID="IMF" id="ECOFIN_DSD"

version="1.0" class="DataStructure"/>

    </str:Structure>

  </str:Dataflow>

All three of these objects—01R_CONSTRAINT, 01R, and ECOFIN_DSD—have
URNs, meaning that the definitions in this message are complete, final, and
globally unique.

So there's a few possibilities:

IMF (or someone else) has a DSD (other than ECOFIN_DSD) that has a
TIME_FORMAT Dimension, and a dataflow structured by it (other than 01R)
that refers to 01R_CONSTRAINT. This other dataflow is not included in
the <str:ConstraintAttachment> of 01R_CONSTRAINT, yet IMF does
maintain the otherwise-useless KeyValues for usage in this other dataflow
and other DSD.

IMF has plans to someday issue new versions of 01R and/or ECOFIN_DSD
to add a TIME_FORMAT Dimension without revising 01R_CONSTRAINT.

It's an error; IMF meant to constrain the TIME_FORMAT Attribute.

I guess one can't know without asking, but in my view Ockham's razor
applies.

I assume that the sets of Dimension IDs and Attribute IDs must be disjoint
although this is not explicitly stated anywhere. But otherwise,
structure-specific datasets would be ambiguous.

The standards don't oblige anyone to produce or convey structure-specific
XML. What you seem to have identified is a binary choice that data providers
must make for each DSD: either have disjoint component IDs, or be unable to
produce structure-specific XML.

The "fixation" on this particular DSD is simply due to my time
constraints.

That's understandable! But, in your view, how many/which other particular
queries will need the same amount of attention before #145 can be
addressed?

--

You are receiving this because you authored the thread.

Reply to this email directly or view it on GitHub:

https://github.com/dr-leo/pandaSDMX/issues/171#issuecomment-617788501

There are a couple recurring tangents here that we don't need to discuss:
One is use or application of ContentConstraints.

The Reader, as the name implies, reads XML and produces the SDMX-IM Python objects they represent. That's it. ContentConstraints may contain MemberValues, which are unrelated to Codes.
The use of a ContentConstraint in combination with other objects only happens if and when it is needed. Only at this point, and only if there is a MemberSelection for a Component that has a local representation enumerated by a CodeList, does the relationship between MemberValues and Codes become relevant.

A constraint is a self-contained artefact. It can live without being useful. If the artefact it is attached to is not present in the current message, query it!

This also isn't relevant here. As I said above (https://github.com/dr-leo/pandaSDMX/issues/171#issuecomment-617788501), Constraint 01R_CONSTRAINT is in the message. It is attached to data flow 01R only, which is also in the message. That data flow is in turn structured by ECOFIN_DSD.
So about the actual issue and solution:

[B]ehaviour (4) […] seems like a reasonable approach. It would require changing .get(...) here to item indexing [...]: https://github.com/dr-leo/pandaSDMX/blob/3d2507d6232132eb2313b0eba6f4e3c2423f742e/pandasdmx/reader/sdmxml.py#L1283-L1285
This will raise KeyError when the component (dimension or attribute) is missing…

I don't know why such exception is raised. I thought a constraint is attached to a DSD, Dataflow or ProvisionAgreement. Here, each constraint is attached to some ConstrainableArtefact, whether or not there is something to constrain.

To explain this single line of code and the suggested change to getattr(dsd, kind[0])[elem.attrib('id')]:

getattr(dsd, kind[0]):

getattr() is a Python built-in method.
dsd is the DSD that the ContentConstraint is attached to. In the case we are discussing, this object exists in the current message, and we have a reference to it.
kind[0] is either the string 'attributes' or 'dimensions'.
So this fragment is equivalent to dsd.attributes (i.e. the AttributeDescriptor) or dsd.dimensions (DimensionDescriptor). A DSD instance always has these objects, though they may be empty.

[elem.attrib('id')]:

elem.attrib('id') is the XML id attribute of the com:KeyValue or com:Attribute tag.
[ ] is element lookup. In ComponentList (the parent of AttributeDescriptor and DimensionDescriptor), this is provided as a convenience to look up a specific component, which are stored in the .components attribute.

So overall this suggested code, in the example under discussion, is equivalent to:dsd.attributes.components['TIME_FORMAT']

I hope you understand why this will raise KeyError. Remember, 01R_CONSTRAINT can be linked through 01R to ECOFIN_DSD—that's not the issue. It's that ECOFIN_DSD lacks an Attribute of this name 'TIME_FORMAT'.

This is why I went on to say:

This will raise KeyError when the component (dimension or attribute) is missing, which must then be handled. What should the code do when if it chooses to ignore elements of a message? Log a warning?

The basic programming principle here is: avoid silent failure to handle input; this is confusing to the user. I think a reasonable behaviour would be something like:
log.warning("'ECOFIN_DSD' has no Attribute 'TIME_FORMAT', wanted by <ContentConstraint: 01R_CONSTRAINT>.data_content_region -- 7 keys ignored')

Even if you don't want to write this, I still need your answer before writing anything, in order to avoid offending other preferences and rehashing this issue.

Thanks for the explanation. I agree with your proposal to raise a warning in case a key or attribute mentioned by a constraint is not mirrored by the DSD. I have no strong feelings how such warning should be recorded. I think by default it should merely be logged, but I happily leave it up to you. The main benefit is that IMF dataflows will hopefully be processed without hiccups so #119 can be closed.


Initial draft of C# stress test client

Currently only support one overall gauge and I still need to test it, but it should be good for initial review.

friendly ping?

I addressed all the comments. PTAL.

LGTM. Can be merged.

C core test flakes are known and unrelated (this PR is only touching C# code).


operators pmem-csi-operator (1.0.0)

Signed-off-by: Amarnath Valluri<EMAIL_ADDRESS>Thanks submitting your Operator. Please check below list before you create your Pull Request.
New Submissions

[x] Are you familiar with our contribution guidelines?
[x] Have you packaged and deployed your Operator for Operator Framework?

[x] Is your submission signed?
[x] Is operator icon set?

Updates to existing Operators

[x] Did you create a ci.yaml file according to the update instructions?
[x] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[x] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[x] Have you tested an update to your Operator when deployed via OLM?
[x] Is your submission signed?

Your submission should not

[x] Modify more than one operator
[x] Modify an Operator you don't own
[x] Rename an operator - please remove and add with a different name instead
[x] Modify any files outside the above mentioned folders
[x] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[x] Description about the managed Application and where to find more information
[x] Features and capabilities of your Operator and how to use it
[x] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[c] Human readable name and 1-liner description about your Operator
[c] Valid category name1
[c] One of the pre-defined capability levels2
[c] Links to the maintainer, source code and documentation
[c] Example templates for all Custom Resource Definitions intended to be used
[x] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

/merge possible

/merge possible


Overflow content choice

Why the scrollbar to manage the overflow content is put in the modal/alert rather than on the windows (with overflow:auto ) ? On Tablet or mobile device, when the scrollbar is attach to the device screen, i think that it's better and simply to scroll content (in the case where the content overflow the height of the screen) ?
Actually :

Can be maybe better ? :

Moreover, i noticed that you have added a new theme. If we want put many text it's not very pretty...

when you think to do this ?

Hello @usb248 Thanks for the suggestion,
I will implement this in the next release.
:)

Ok nice, Why we can't choice the width of alert/confirm/dialog other than by modifying CSS ?

Yes i will be adding choice of width,
https://github.com/craftpip/jquery-confirm/issues/27
bootstrap columns will be provided to set the widths.

So, cool ! I wait your release ;).
An other improvement which can be very nice. Adding hash tracking by manupulating browser history (by adding #hash... ) like this similar plugin http://vodkabears.github.io/remodal/.

Hello @usb248 The overflow feature you said is added in the new release,
Other feature about tracking with #hash, what is a practical usage with this?
Thanks

When we press back/next button (on some the mouse, or browser windows to navigate in the browser history), the alert/confirm/dialog come back
When we refresh the page, the alert/confirm/dialog don't disappear, it remains displayed.


camera intrinsics calculation

Hey Brady, thanks for the great work and the open-sourced code!
I found the calculation of rescaled intrinsics is a bit wired here:
https://github.com/bradyz/cross_view_transformers/blob/8d1d688711c3d7a85004f86da3f0874c38619489/cross_view_transformer/data/transforms.py#L135
Shouldn't the scaling factor be w_resize and h_resize instead of w and h?

Nice catch!
I don't know how long this bug was in here but I'll patch this in this week along with some of the other issues.
Thanks for your careful eye


Rapier integration broken?

It seems like the integration needs to be updated for rapier 0.13. Also, how are you supposed to run the example? The crate was commented out of the cargo workspace.

It works, thanks!


Moderated Orders

Coverage remained the same at 60.413% when pulling bda470b53bd748babfb236698e2bb2988ec5ca54 on cpacia:master into 4b191064859a523e00e51e78a0bb9280a0f846f1 on OpenBazaar:master.

Coverage remained the same at 60.413% when pulling 351f797edf6665bcb1db8cd5563770dbe5360b4c on cpacia:master into 4b191064859a523e00e51e78a0bb9280a0f846f1 on OpenBazaar:master.

Coverage remained the same at 60.413% when pulling 915459ebe590e7fccb03a1a3c48544cb565109a0 on cpacia:master into 4b191064859a523e00e51e78a0bb9280a0f846f1 on OpenBazaar:master.

Coverage remained the same at 60.413% when pulling 4d76819a7c19fc8844d3f093462e86f7fb083f21 on cpacia:master into 4b191064859a523e00e51e78a0bb9280a0f846f1 on OpenBazaar:master.

Coverage remained the same at 60.413% when pulling 75868c709f98175eaa0eef9b215beaf3d8cdb50b on cpacia:master into 4b191064859a523e00e51e78a0bb9280a0f846f1 on OpenBazaar:master.

Coverage remained the same at 60.413% when pulling 15d5253e2010831f864bb5c7557e830a6349083f on cpacia:master into 4b191064859a523e00e51e78a0bb9280a0f846f1 on OpenBazaar:master.

Coverage remained the same at 60.413% when pulling ea769073182c4511b183c6c177f7ddde214c24b9 on cpacia:master into 4b191064859a523e00e51e78a0bb9280a0f846f1 on OpenBazaar:master.

Coverage remained the same at 60.413% when pulling f16b19a36e3d0bfc6973af318df5b0014ffd7c39 on cpacia:master into 4b191064859a523e00e51e78a0bb9280a0f846f1 on OpenBazaar:master.

@cpacia this lgtm


not working

Hi there, are you using Hyper 2.0?
If so, this plugin wont work because the underlying terminal emulator has changed (to xterm). I'll need to refactor in order support the new xterm api.

@danieldelcore Is the plain to deprecate this entirely? iTerm triggers are super useful for on-the-fly syntax highlighting, really helpful when connected to a firewall or switch and looking through the config, or when writing more configs. I haven't found another project that emulates iTerm triggers.

Hi @ljstella, I'm really happy to see that you want to use this!
Unfortunately the new terminal emulator, xTerm, introduced in v2.0.0 has a drastically different api. We're no longer able to inspect the terminal output and render triggers because everything is now rendered to a canvas.
It does, however, have basic support for file paths but no options for customisation... 😭
If you find a way to get around this i would love to hear about it or review your pull requests.

We could hook into this api and customise the link matcher: https://xtermjs.org/docs/api/terminal/interfaces/ilinkmatcheroptions/

FYI, i did some tinkering over the weekend and managed to refactor the plugin to work on v2. I'm going to do some polishing and do a major version bump.
CC @ljstella @csrgxtu

Gladly, i can remove the deprecation 🎉

Wonderful! I'm looking forward to a version that works with v2! I would really like to be able to click a link like /path/to/file.js:123 and have it open in my $EDITOR at the exact relevant line. Any way I could make that work even today? Or is there some work still left before that is possible? Or perhaps I should downgrade to v1 in the meantime?
Also, relevant issue: https://github.com/zeit/hyper/issues/413


Add support for ReactEvent.Keyboard.stopImmediatePropagation binding

@sinap-fb Are you sure that this actually exists on React Synthetic Events?
It is neither in the React docs (https://reactjs.org/docs/events.html) nor in the TypeScript typedefs (https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react/index.d.ts).
I think it only exist on the underlying nativeEvent, but that is currently only typed as
  @get external nativeEvent: Type.t => {..} = "nativeEvent" /* Should return Dom.event */

Also it is not Keyboard-specific as far as I can see.

Closing. @sinap-fb feel free to ping me if this is still relevant for you.


Add HOWTO: implement global norm clipping?

This was actually a question on Optax so not relevant for us.

This was actually a question on Optax so not relevant for us.


Box AP of new ViT-L model doesn't match

Hi! I evaluated the newly release ViT-L model on LVIS with the following command:
bash tools/dist_test.sh projects/configs/co_dino/co_dino_5scale_vit_large_lvis.py data/co_dino_5scale_vit_large_lvis.pth 2 --eval bbox

and the performance doesn't match what's released in the table:
Evaluating bbox...
 Average Precision  (AP) @[ IoU=0.50:0.95 | area=   all | maxDets=300 catIds=all] = 0.644
 Average Precision  (AP) @[ IoU=0.50      | area=   all | maxDets=300 catIds=all] = 0.795
 Average Precision  (AP) @[ IoU=0.75      | area=   all | maxDets=300 catIds=all] = 0.694
 Average Precision  (AP) @[ IoU=0.50:0.95 | area=     s | maxDets=300 catIds=all] = 0.559
 Average Precision  (AP) @[ IoU=0.50:0.95 | area=     m | maxDets=300 catIds=all] = 0.741
 Average Precision  (AP) @[ IoU=0.50:0.95 | area=     l | maxDets=300 catIds=all] = 0.786
 Average Precision  (AP) @[ IoU=0.50:0.95 | area=   all | maxDets=300 catIds=  r] = 0.600
 Average Precision  (AP) @[ IoU=0.50:0.95 | area=   all | maxDets=300 catIds=  c] = 0.656
 Average Precision  (AP) @[ IoU=0.50:0.95 | area=   all | maxDets=300 catIds=  f] = 0.649
 Average Recall     (AR) @[ IoU=0.50:0.95 | area=   all | maxDets=300 catIds=all] = 0.782
 Average Recall     (AR) @[ IoU=0.50:0.95 | area=     s | maxDets=300 catIds=all] = 0.674
 Average Recall     (AR) @[ IoU=0.50:0.95 | area=     m | maxDets=300 catIds=all] = 0.870
 Average Recall     (AR) @[ IoU=0.50:0.95 | area=     l | maxDets=300 catIds=all] = 0.912
OrderedDict([('bbox_AP', 0.644), ('bbox_AP50', 0.795), ('bbox_AP75', 0.694), ('bbox_APs', 0.559), ('bbox_APm', 0.741), ('bbox_APl', 0.786), ('bbox_APr', 0.6), ('bbox_APc', 0.656), ('bbox_APf', 0.649), ('bbox_mAP_copypaste', 'AP:0.644 AP50:0.795 AP75:0.694 APs:0.559 APm:0.741 APl:0.786 APr:0.600 APc:0.656 APf:0.649')])

What did I miss? Thanks

Sorry, I found a bug in the config. The attention mask should be disabled:
model = dict(
    type='CoDETR',
    with_attn_mask=False,
    backbone=dict(

Thank you! The fix worked for me. Now I get
Evaluating bbox...
 Average Precision  (AP) @[ IoU=0.50:0.95 | area=   all | maxDets=300 catIds=all] = 0.680
 Average Precision  (AP) @[ IoU=0.50      | area=   all | maxDets=300 catIds=all] = 0.812
 Average Precision  (AP) @[ IoU=0.75      | area=   all | maxDets=300 catIds=all] = 0.723
 Average Precision  (AP) @[ IoU=0.50:0.95 | area=     s | maxDets=300 catIds=all] = 0.589
 Average Precision  (AP) @[ IoU=0.50:0.95 | area=     m | maxDets=300 catIds=all] = 0.774
 Average Precision  (AP) @[ IoU=0.50:0.95 | area=     l | maxDets=300 catIds=all] = 0.822
 Average Precision  (AP) @[ IoU=0.50:0.95 | area=   all | maxDets=300 catIds=  r] = 0.645
 Average Precision  (AP) @[ IoU=0.50:0.95 | area=   all | maxDets=300 catIds=  c] = 0.689
 Average Precision  (AP) @[ IoU=0.50:0.95 | area=   all | maxDets=300 catIds=  f] = 0.685
 Average Recall     (AR) @[ IoU=0.50:0.95 | area=   all | maxDets=300 catIds=all] = 0.806
 Average Recall     (AR) @[ IoU=0.50:0.95 | area=     s | maxDets=300 catIds=all] = 0.699
 Average Recall     (AR) @[ IoU=0.50:0.95 | area=     m | maxDets=300 catIds=all] = 0.892
 Average Recall     (AR) @[ IoU=0.50:0.95 | area=     l | maxDets=300 catIds=all] = 0.936
OrderedDict([('bbox_AP', 0.68), ('bbox_AP50', 0.812), ('bbox_AP75', 0.723), ('bbox_APs', 0.589), ('bbox_APm', 0.774), ('bbox_APl', 0.822), ('bbox_APr', 0.645), ('bbox_APc', 0.689), ('bbox_APf', 0.685), ('bbox_mAP_copypaste', 'AP:0.680 AP50:0.812 AP75:0.723 APs:0.589 APm:0.774 APl:0.822 APr:0.645 APc:0.689 APf:0.685')])


feat: add Google Nearby Messages

Add cross-platform communication via Google Nearby Messages API.

@pmigueld Can you please take care of the merge conflict in package-lock.json?


fix npe

fix npe and set version to 1.5.2

Pull Request Test Coverage Report for Build 98

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 67.739%

Totals

Change from base Build 97:
0.02%

Covered Lines:
2591

Relevant Lines:
3825

💛  - Coveralls


Add usage examples to docs

Checked modules are complete.

[ ] affine
[ ] contrast
[ ] corners
[ ] definitions
[ ] drawing
[ ] edges
[ ] filter
[ ] gradients
[ ] haar
[ ] hog
[x] hough
[x] integral_image
[x] local_binary_patterns
[x] map
[ ] math
[x] morphology
[ ] noise
[x] pixelops
[ ] property_testing
[x] rect
[x] region_labelling
[ ] stats
[ ] suppress
[ ] union_find
[ ] utils

I will work on this.
Is it preferred to keep all example usages within examples/, or as an example comment, such as the example within src/region_labelling.rs::connected_components.

Great! Thus far I've only been adding doctests (so the latter). There's scope for adding more to /examples too - the main goal was improving the rustdoc documentation, but unit tests aren't great for showing visual effects so more /examples would also help.
Nearly all of the functions in this library have trivial APIs (pass in an image to transform, plus a few options, get an image back), so the doctests should ideally help clarify what the function does rather than just how to call it.
If you've not got much experience with rustdoc doctests, the lines starting # might be a bit confusing. These are hidden in the final docs, but we need them in most of the tests so that we can import the gray_image (and rgb_image, etc.) macros for use in the tests.
It might not be possible to add helpful doctests for all functions, but we can certainly add more than we have now. Most of the current doctests started life in the tests module in the file containing the function and were just moved into doctests with some comments added. There might be a few more tests lying around that can just be moved.
Thanks!

Where are rgb_image and similar macros defined? Sorry for resurrecting an old issue.