[Bug] Segmentation fault occurs and the machine with openEuler os was automatically reboots

Checklist

[x] 1. I have searched related issues but cannot get the expected help.
[x] 2. The bug has not been fixed in the latest version.

Describe the bug
In my A40/T4 card environment, when the service of lmdeploy is run, after the service address is printed out, a Segmentation fault occurs and exits without any other error message. The most important point is that about a minute after the above error occurred, my machine was automatically restarted very quickly, which is very confusing!
Reproduction
lmdeploy serve api_server internlm2-chat-7b --tp 2 --log-level DEBUG
Environment
sys.platform: linux
Python: 3.10.14 (main, May  6 2024, 19:42:50) [GCC 11.2.0]
CUDA available: True
MUSA available: False
numpy_random_seed:<PHONE_NUMBER>
GPU 0,1,2,3,4,5,6,7: NVIDIA A40
CUDA_HOME: None
GCC: gcc (GCC) 10.3.1
PyTorch: 2.2.2+cu121
PyTorch compiling details: PyTorch built with:
  - GCC 9.3
  - C++ Version: 201703
  - Intel(R) oneAPI Math Kernel Library Version 2022.2-Product Build 20220804 for Intel(R) 64 architecture applications
  - Intel(R) MKL-DNN v3.3.2 (Git Hash 2dc95a2ad0841e29db8b22fbccaf3e5da7992b01)
  - OpenMP 201511 (a.k.a. OpenMP 4.5)
  - LAPACK is enabled (usually provided by MKL)
  - NNPACK is enabled
  - CPU capability usage: AVX512
  - CUDA Runtime 12.1
  - NVCC architecture flags: -gencode;arch=compute_50,code=sm_50;-gencode;arch=compute_60,code=sm_60;-gencode;arch=compute_70,code=sm_70;-gencode;arch=compute_75,code=sm_75;-gencode;arch=compute_80,code=sm_80;-gencode;arch=compute_86,code=sm_86;-gencode;arch=compute_90,code=sm_90
  - CuDNN 8.9.2
  - Magma 2.6.1
  - Build settings: BLAS_INFO=mkl, BUILD_TYPE=Release, CUDA_VERSION=12.1, CUDNN_VERSION=8.9.2, CXX_COMPILER=/opt/rh/devtoolset-9/root/usr/bin/c++, CXX_FLAGS= -D_GLIBCXX_USE_CXX11_ABI=0 -fabi-version=11 -fvisibility-inlines-hidden -DUSE_PTHREADPOOL -DNDEBUG -DUSE_KINETO -DLIBKINETO_NOROCTRACER -DUSE_FBGEMM -DUSE_QNNPACK -DUSE_PYTORCH_QNNPACK -DUSE_XNNPACK -DSYMBOLICATE_MOBILE_DEBUG_HANDLE -O2 -fPIC -Wall -Wextra -Werror=return-type -Werror=non-virtual-dtor -Werror=bool-operation -Wnarrowing -Wno-missing-field-initializers -Wno-type-limits -Wno-array-bounds -Wno-unknown-pragmas -Wno-unused-parameter -Wno-unused-function -Wno-unused-result -Wno-strict-overflow -Wno-strict-aliasing -Wno-stringop-overflow -Wsuggest-override -Wno-psabi -Wno-error=pedantic -Wno-error=old-style-cast -Wno-missing-braces -fdiagnostics-color=always -faligned-new -Wno-unused-but-set-variable -Wno-maybe-uninitialized -fno-math-errno -fno-trapping-math -Werror=format -Wno-stringop-overflow, LAPACK_INFO=mkl, PERF_WITH_AVX=1, PERF_WITH_AVX2=1, PERF_WITH_AVX512=1, TORCH_VERSION=2.2.2, USE_CUDA=ON, USE_CUDNN=ON, USE_EXCEPTION_PTR=1, USE_GFLAGS=OFF, USE_GLOG=OFF, USE_MKL=ON, USE_MKLDNN=ON, USE_MPI=OFF, USE_NCCL=1, USE_NNPACK=ON, USE_OPENMP=ON, USE_ROCM=OFF, USE_ROCM_KERNEL_ASSERT=OFF,

TorchVision: 0.17.2+cu121
LMDeploy: 0.5.0+
transformers: 4.41.2
gradio: Not Found
fastapi: 0.111.0
pydantic: 2.8.0
triton: 2.2.0

+---------------------------------------------------------------------------------------+
| NVIDIA-SMI 535.86.10              Driver Version: 535.86.10    CUDA Version: 12.2     |
|-----------------------------------------+----------------------+----------------------+
| GPU  Name                 Persistence-M | Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp   Perf          Pwr:Usage/Cap |         Memory-Usage | GPU-Util  Compute M. |
|                                         |                      |               MIG M. |
|=========================================+======================+======================|
|   0  NVIDIA A40                     On  | 00000000:0B:00.0 Off |                    0 |
|  0%   52C    P0              84W / 300W |      4MiB / 46068MiB |      0%      Default |
|                                         |                      |                  N/A |
+-----------------------------------------+----------------------+----------------------+
|   1  NVIDIA A40                     On  | 00000000:0C:00.0 Off |                    0 |
|  0%   53C    P0              85W / 300W |      4MiB / 46068MiB |      0%      Default |
|                                         |                      |                  N/A |
+-----------------------------------------+----------------------+----------------------+
...

Error traceback
HINT:    Please open http://<IP_ADDRESS>:23333 in a browser for detailed api usage!!!
HINT:    Please open http://<IP_ADDRESS>:23333 in a browser for detailed api usage!!!
HINT:    Please open http://<IP_ADDRESS>:23333 in a browser for detailed api usage!!!
Segmentation fault

my lmdeploy is installed by pip install lmdeploy

Is it because the system is openEuler? There doesn't seem to be this problem on centos and ubuntu systems.

The Python package is compiled with manylinux2014_x86_64 and I only have the server with CentOS 7 or Ubuntu 22.04. Maybe it's a corner case and hard for me to reproduce because I don't have the environment.

Is it because the system is openEuler? There doesn't seem to be this problem on centos and ubuntu systems.

Can you try to build the project from source? Here is the guide: https://lmdeploy.readthedocs.io/en/latest/build.html

The Python package is compiled with manylinux2014_x86_64 and I only have the server with CentOS 7 or Ubuntu 22.04. Maybe it's a corner case and hard for me to reproduce because I don't have the environment.

It is almost certain that the kernel version (5.10.0-<IP_ADDRESS>.oe2203.x86_64) is the reason. Because it seems that upgrading or downgrading the kernel version will solve the problem.

Is it because the system is openEuler? There doesn't seem to be this problem on centos and ubuntu systems.

Can you try to build the project from source? Here is the guide: https://lmdeploy.readthedocs.io/en/latest/build.html

That doesn't seem to be necessary, as it seems that upgrading or downgrading the kernel version will solve the problem.


go-ethereum: 1.10.26 -> 1.11.0

Description of changes
Release notes:
https://github.com/ethereum/go-ethereum/releases/tag/v1.11.0
Things done

I haven't run nixos/tests/geth.nix as it fails when not on Linux: error: assertion '(stdenv).isLinux' failed.
Haven't run nixos/tests/geth.nix yet

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[x] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Why not https://github.com/ethereum/go-ethereum/releases/tag/v1.11.4 ?

Actuallly, 1.11.5 is already out with support for Shanghai upgrade:

Geth v1.11.5 enables the Shanghai upgrade on Wednesday, April 12, 2023 10:27:35 PM UTC

https://github.com/ethereum/go-ethereum/releases/tag/v1.11.5
Can we maybe get 1.11.5 into master before the 10th?

For those that want 1.11.5 before this gets merged sometime in the next 2-3 months you can use this:
# Can't use overrideAttrs due to how buildGoModule overwrites arguments.
pkgs.go-ethereum.override {
  buildGoModule = args: pkgs.buildGo120Module ( args // rec {
    version = "1.11.5";

    src = pkgs.fetchFromGitHub {
      owner = "ethereum";
      repo = args.pname;
      rev = "v${version}";
      sha256 = "sha256-QFqPAWW0L9cSBvnDwJKtwWT2jZFyr+zhYaS+GF/nQ9g=";
    };

    vendorSha256 = "sha256-Y1srOcXZ4rQ0QIQx4LdYzYG6goGk6oO30C+OW+s81z4=";

    subPackages = [
      "cmd/ethkey"
      "cmd/clef"
      "cmd/geth"
      "cmd/utils"
    ];
  });
}

Narrowed down subPackages since most of it is useless to most people.

@jakubgs Apologies, I've been away for the last 2 weeks. Happy to switch to 1.11.5, I'll sort that out today.

Why not 1.11.4?

I went for 1.11.0 on the assumption that we should have derivations for all versions of a package, but looking at previous PRs it seems this isn't the case. Having all versions of a package available can help limit complexity & risk when upgrading. Though now I see this would significantly increase the workload for updating every package and only benefit very risk-averse users.
If smaller version bumps are needed, is the right way to set up an override similar to the one you've given for 1.11.5?

we should have derivations for all versions of a package

No, that's not how it should work. If Nixpkgs held all versions of all packages it would be ridiculously big. It's already big enough while holding only the most recent versions. If people need a specific version they should indeed just override, or ping nixpkgs they use to a specific commit or a fork they've created.

Testing dependent packages with nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD" fails, seems like a MySQL package for Common Lisp so I'm not sure it's related to this change.
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
$ git -c fetch.prune=false fetch --no-tags --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
remote: Enumerating objects: 29, done.
remote: Counting objects: 100% (27/27), done.
remote: Compressing objects: 100% (17/17), done.
remote: Total 29 (delta 12), reused 15 (delta 9), pack-reused 2
Unpacking objects: 100% (29/29), 16.95 KiB | 159.00 KiB/s, done.
From https://github.com/NixOS/nixpkgs
   d59c85209d3..64a5b00d023  master     -> refs/nixpkgs-review/0
$ git worktree add /Users/daviddunn/.cache/nixpkgs-review/rev-e0205290f5319e219401a6ecbc5d42ac3e93112a/nixpkgs 64a5b00d0235a6abd85f0ed5e33775ab6febd9db
Preparing worktree (detached HEAD 64a5b00d023)
Updating files: 100% (34337/34337), done.
HEAD is now at 64a5b00d023 Merge pull request #224462 from wegank/scalp-mirror
$ nix-env --option system aarch64-darwin -f /Users/daviddunn/.cache/nixpkgs-review/rev-e0205290f5319e219401a6ecbc5d42ac3e93112a/nixpkgs -qaP --xml --out-path --show-trace --no-allow-import-from-derivation
error:
       … while querying the derivation named 'cl-mysql-20200610-git'

       … while evaluating the attribute 'nativeLibs' of the derivation 'cl-mysql-20200610-git'

       at /Users/daviddunn/.cache/nixpkgs-review/rev-e0205290f5319e219401a6ecbc5d42ac3e93112a/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:302:7:

          301|     // (lib.optionalAttrs (attrs ? name || (attrs ? pname && attrs ? version)) {
          302|       name =
             |       ^
          303|         let

       error: attribute 'mysql-client' missing

       at /Users/daviddunn/.cache/nixpkgs-review/rev-e0205290f5319e219401a6ecbc5d42ac3e93112a/nixpkgs/pkgs/development/lisp-modules/ql.nix:59:22:

           58|     cl-mysql = super.cl-mysql.overrideLispAttrs (o: {
           59|       nativeLibs = [ pkgs.mysql-client ];
             |                      ^
           60|     });
$ git worktree prune
Traceback (most recent call last):
  File "/nix/store/q76l69048llcd3p6q4zzb8maj4f69j82-nixpkgs-review-2.8.0/bin/.nixpkgs-review-wrapped", line 9, in <module>
    sys.exit(main())
  File "/nix/store/q76l69048llcd3p6q4zzb8maj4f69j82-nixpkgs-review-2.8.0/lib/python3.10/site-packages/nixpkgs_review/__init__.py", line 10, in main
    cli.main(command, args)
  File "/nix/store/q76l69048llcd3p6q4zzb8maj4f69j82-nixpkgs-review-2.8.0/lib/python3.10/site-packages/nixpkgs_review/cli/__init__.py", line 301, in main
    return cast(str, args.func(args))
  File "/nix/store/q76l69048llcd3p6q4zzb8maj4f69j82-nixpkgs-review-2.8.0/lib/python3.10/site-packages/nixpkgs_review/cli/rev.py", line 12, in rev_command
    return review_local_revision(f"rev-{commit}", args, commit)
  File "/nix/store/q76l69048llcd3p6q4zzb8maj4f69j82-nixpkgs-review-2.8.0/lib/python3.10/site-packages/nixpkgs_review/review.py", line 497, in review_local_revision
    review.review_commit(builddir.path, args.branch, commit, staged)
  File "/nix/store/q76l69048llcd3p6q4zzb8maj4f69j82-nixpkgs-review-2.8.0/lib/python3.10/site-packages/nixpkgs_review/review.py", line 263, in review_commit
    self.start_review(self.build_commit(branch_rev, reviewed_commit, staged), path)
  File "/nix/store/q76l69048llcd3p6q4zzb8maj4f69j82-nixpkgs-review-2.8.0/lib/python3.10/site-packages/nixpkgs_review/review.py", line 147, in build_commit
    base_packages = list_packages(
  File "/nix/store/q76l69048llcd3p6q4zzb8maj4f69j82-nixpkgs-review-2.8.0/lib/python3.10/site-packages/nixpkgs_review/review.py", line 335, in list_packages
    subprocess.run(cmd, stdout=tmp, check=True)
  File "/nix/store/n3qask6wrby75704dz3vcwnd3f9vkab8-python3-3.10.9/lib/python3.10/subprocess.py", line 526, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['nix-env', '--option', 'system', 'aarch64-darwin', '-f', '/Users/daviddunn/.cache/nixpkgs-review/rev-e0205290f5319e219401a6ecbc5d42ac3e93112a/nixpkgs', '-qaP', '--xml', '--out-path', '--show-trace', '--no-allow-import-from-derivation']' returned non-zero exit status 1.


Problems with getting a steady fps

Hello. I had a quick question about overall game play. I was loading up a OoT randomizer just to see what the seed had to offer. I loaded it up and had a steady fps while making a save file. The sound was a little bugged but I figured that was just normal. So after I loaded up the file it got from 60fps and dropped to like 20-30 fps. Whenever I moved 10 fps was gone and I couldn't stand it. Idk if its just me or if it the game, code, the site itself, etc. I also tried a regular game with no randomizer on. Same problems. I tried other games than OoT, same problem occurred. I was hoping you could look into this and if people are having these same problems please comment blow.

Hi @MRMRMEATS , my guess is you probably need some higher specs to run the emulator. What specs is your computer? I'm running on a 3.6 ghz i7 Desktop and a 1060 graphics card and Ocarina of Time runs fine for me. Though I have also tested it on some older laptops where it is unplayable like your are describing. There are some games in general that don't run very well for me such as Perfect Dark and Beetle Adventure Racing which have frequent slowdowns, but Ocarina has always maintained a steady 60fps on my computer. It's also possible that rom hacks may not run very well because the emulator does employ a lot of game specific hacks by detecting which game is being played. Try running vanilla Mario 64 and see how that performs, since that tends to be one of the more easier to emulate games. It could also be your graphics card since WebGL uses hardware acceleration when available, though most likely it's the CPU that is the bottleneck.


Using fields option doesn't return attributes that contain underscore

When using fields: { movie: [:name_with_underscore] }  - the attribute will not be returned.

I've ran into this issue as well. I believe if you try fields: { movie: [:nameWithoutUnderscore] }, it should work. I haven't tested the fields array explicitly, but I have dealt with this issue when the resource name is two words (e.g. instead of movies, something like fields: { movieName: [:name] })

It seems Netflix has abandoned this project. The community created a new fork to continue supporting this project. Please refer https://github.com/fast-jsonapi/fast_jsonapi


Label cleanup

Currently there are two work-labels:
Werk_Link
and
Anno
as a sub-item. This differentiation seems unnecessary and all Anno-Labels could be changed to Werk_Link and the Anno-Label deleted

jetzt muss ich gleich schaun, was das jubiläums issue war; ahh #200 die fackel personen ....

Ah, es gibt Jubiläumsissues? Zählt auch "25 offene Issues"? Dann bemühe ich mich…


[Event Request] Page Resource Capacity Settings

I need an event in the action UpdateCapacity to use another calendar. So the publisher event should be here:

Thank you very much

@AlexanderYakunin Can you estimate when the event will be implemented?

We implement 100's events monthly based on their order of creation and our capacity, so I'd expect within a month with current number of active requests. Anyway, you request is missing event specification with needed parameters and therefore will not go to processing before you add this.

@BITSchmitt when requesting an event please use text instead of pictures and provide desired call of event and its signature so we do not have to guess then parameters you need.
Do you need something like this to change the CustomCalendarChange record or?
OnUpdateCapacityOnBeforeSetCalendar(Rec, CustomizedCalendarChange); with CustomizedCalendarChange being var

@Vadim-Stepanenko Thank you for your hint, I will keep ist in mind.
Yes, I want to change the CustomeCalendarChange but with another var parameter isHandled:
if not Confirm(Text004, false, TableCaption, "No.") then
exit;
OnUpdateCapacityOnBeforeSetCalendar(Rec, CustomizedCalendarChange, isHandled);
if not isHandled then begin
if CompanyInformation.Get then begin
CompanyInformation.TestField("Base Calendar Code");
CalendarMgmt.SetSource(CompanyInformation, CustomizedCalendarChange);
end;
end;


Google ReCaptcha v3 issues

The token appears to expire after a few minutes. I execute on page load and populate a hidden form field. By the time the user submits the form the token is expired.
Can we have an API to configure the timer? Something like this.
It's very bad if ReCaptcha fails and the user can't able to submit the form.
{message='ReCaptcha V3 Verification Failed', captchaJSON={"success":"false","error-codes":[""timeout-or-duplicate""]}

You should execute recaptcha to get token and immediately check its token with your backend request (with priv key). Recaptcha token expiry time is 2 minutes.


Camera lerp + velocity = quick teleport (noticable in an example)

In this example: Phaser 3 example
there is a slight quick random teleportation, the sprite stops and teleports quickly.
To reproduce it, go in one direction for a few seconds and watch the sprite closely. (it seems to happen more often if you lose the window focus and come back to it)
It occurs when the camera is set to follow a sprite and lerp is not (1,1).
roundPixels true or false doesn’t fix it.
This issue wasn't present in Phaser 2.
Tested on two computers, on mobile, chrome and firefox.

Hi @Kosmoon,
I checked the example and played the lerp value a bit,
i can say even if lerp is 1, there is a slightly seeable effect on small teleport like you said.

var config = {
    type: Phaser.AUTO,
    parent: 'phaser-example',
    physics: {
        default: 'arcade',
        arcade: {
            debug: true,
        }
    },
    scene: {
        preload: preload,
        create: create,
        update: update
    }
};

...

function create ()
{
    .... //same with example
    this.cameras.main.startFollow(player, true, 1, 1);
}

With debug mode on you can see even clear :)
So I wondered if we make the same example without physics how would it be:
var config = {
    type: Phaser.AUTO,
    parent: 'phaser-example',
    scale: {
        mode: Phaser.Scale.FIT
    },
    physics: {
        default: false,
    },
    scene: {
        preload: preload,
        create: create,
        update: update
    }
};

var player;
var cursors;

var game = new Phaser.Game(config);

function preload ()
{
    this.load.image('bg', 'assets/pics/the-end-by-iloe-and-made.jpg');
    this.load.image('block', 'assets/sprites/block.png');
}

function create ()
{
    //  Set the camera and physics bounds to be the size of 4x4 bg images
    this.cameras.main.setBounds(0, 0, 1920 * 2, 1080 * 2);

    //  Mash 4 images together to create our background
    this.add.image(0, 0, 'bg').setOrigin(0);
    this.add.image(1920, 0, 'bg').setOrigin(0).setFlipX(true);
    this.add.image(0, 1080, 'bg').setOrigin(0).setFlipY(true);
    this.add.image(1920, 1080, 'bg').setOrigin(0).setFlipX(true).setFlipY(true);

    cursors = this.input.keyboard.createCursorKeys();

    player = this.add.image(400, 300, 'block');

    this.cameras.main.startFollow(player, true, 0.05, 0.05);
}

function update ()
{

    if (cursors.left.isDown)
    {
        player.x -= 5;
    }
    else if (cursors.right.isDown)
    {
        player.x += 5;
    }

    if (cursors.up.isDown)
    {
        player.y -= 5;
    }
    else if (cursors.down.isDown)
    {
        player.y += 5;
    }

}

With same example if you remove all of physics and simulate same effect with only changing x, y values, its worked quite okey.

Hi @halilcakar thank you for the reply.
Indeed, i noticed too that it's only occuring when the sprite has a velocity applied to it.
You will probably  agree with me that removing physics is not an acceptable solution.

Yea I just wanted to check another scenario 😃

Hey y'all,
I am dealing with this issue as well. For me, I perceived it as my background moving instead of the character moving. Its actually pretty tough to determine what is moving when the "skip" or "teleport happens". I've noticed it on static images that are not being tracked on the camera, but also the tracked sprite.
Here is the solution I have so far that improves both the background/static image jitter as well as the player sprite teleport problem. Still looking to perfect the config and update loop for the best quality. Any additional insight (especially a working code snippet) is greatly appreciated.
https://github.com/photonstorm/phaser/issues/4664

I think this is not exactly a bug but a natural consequence of  how fixed-step physics interacts with the camera lerp.
For me it happens when there are 2 physics step per frame instead of 1. That's rare but normal. So the body delta doubles, the camera interpolates to a position behind it, then closes the gap over a few frames. You see a stutter.

#4989

Nice find @samme !! It actually works. I hope that does not break something else in my code but adding: https://github.com/photonstorm/phaser/pull/4989/commits/7e4c08c27087b4fa0025d07b5644c7e404466ec5
to my phaser.min.js did the trick.
This guy is a genious :)

s = e * 0.001;  a = true;  this._elapsed = 0;
minified

#4989 is not an acceptable solution because we may not want our game to have faster physics on higher framerate monitors, especially if the game is multiplayer.

I don't think #4989 is an acceptable solution because we may not want our game to have faster physics on higher framerate monitors, especially if the game is multiplayer.

You are right, i ended up reverting the change and had to keep the glitchy bug because i want a consistant physic behavior in my game.

Out of curiosity @Kosmoon,
Did you try this workaround?
https://github.com/photonstorm/phaser/issues/4664#issuecomment-592060468
I have not been working with phaser recently since i am engaged in another project; yet am still interested in this problem because it really bugs me.
The main things I noticed that will help, not solve the problem completely are:

Don't directly track a physics object with the camera.

While this is not a knock out solution, i noticed a significant decrease in stutters/skips.
Finally an additional concept not in that code snippet is to only update the camera lerp every 5 or 10 frames instead of very frame. This has a side effect of making the camera drag even more, which might be acceptable depending on your game. I think I settled on updating camera lerp once every 4 frames.

Turning off fixedStep won’t make physics run faster (or slower). It will still simulate 1 physics second per game second, only the delta interval varies.

I don't know for Arcade but with PlanckJS I can see speed variations between 60 Hz and 144 Hz monitors when using a variable time step. (Looks like PlanckJS doesn't like variable time step very much https://github.com/shakiba/planck.js/issues/74).

Turning off fixedStep won’t make physics run faster (or slower). It will still simulate 1 physics second per game second, only the delta interval varies.

I have some level in my game to test consistancy. Like "auto levels" in Mario maker. They are broken when fixedStep is turned off.
Also, testing fixedStep on and off in chrome inspector with device toolbar toggled and switching between "online" and "low-tier mobile" is an easy way to see the difference.

Out of curiosity @Kosmoon,
Did you try this workaround?
#4664 (comment)
I have not been working with phaser recently since i am engaged in another project; yet am still interested in this problem because it really bugs me.
The main things I noticed that will help, not solve the problem completely are:

Don't directly track a physics object with the camera.

While this is not a knock out solution, i noticed a significant decrease in stutters/skips.
Finally an additional concept not in that code snippet is to only update the camera lerp every 5 or 10 frames instead of very frame. This has a side effect of making the camera drag even more, which might be acceptable depending on your game. I think I settled on updating camera lerp once every 4 frames.

Interesting mate !
Using a dummy non-physic fake player followed by the camera don't fix it for me.
What do you mean by "only update the camera lerp every 5 or 10 frames instead of very frame." and how can you achieve that?

What do you mean by "only update the camera lerp every 5 or 10 frames instead of very frame." and how can you achieve that?

Here is a quick pseudo code snippet:
  create() {
    this.frame = 0
    ...
  }

  update (time, delta) {
    this.frame++
    this.chara.update({
      time,
      delta,
      pointer: this.pointer
    })

    if (this.frame % 5) { //only run every 5 frames
      this.cameraFocus.x = Math.round(this.chara.x)
      this.cameraFocus.y = Math.round(this.chara.y)
    }
  }
}

What do you mean by "only update the camera lerp every 5 or 10 frames instead of very frame." and how can you achieve that?

Here is a quick pseudo code snippet:
  create() {
    this.frame = 0
    ...
  }

  update (time, delta) {
    this.frame++
    this.chara.update(...)

    if (this.frame % 5 === 0) { //only run every 5 frames
      this.cameraFocus.x = Math.round(this.chara.x)
      this.cameraFocus.y = Math.round(this.chara.y)
    }
  }
}

Also @Kosmoon, what version of phaser are you using? I was having issues on 3.21.0 then upgraded to 3.22.0. The upgrade did not fix it for me and my scene unfortunately, just curious what version you are on.

I'm using the last version: 3.24.1
updating the cameraFocus every 5 updates made it worst for me.

I'm using the last version: 3.24.1
updating the cameraFocus every 5 updates made it worst for me.

Oh bummer, welp. I suppose it only works for me since its a slower moving top-down view. If you need faster camera response times, then I don't think the skip-frame technique works very well.

I think I have an idea to solve this problem:

Create a dumb game object that the camera is going to follow.
Save position of real followed object in an array with each physic step.
Each render update, get and remove (shift) the first position of this array.

With a bit of luck frames with 2 and the ones with 0 physic steps per second will cancel each other and the camera will not fall behind. This is only possible if screen framerate >= amount of physic steps per second.

If you don't want to use fixedStep = false, you can scroll the camera during the physics step instead.
See worldStep() etc. in https://codepen.io/samme/pen/OJNBomM.

Any solutions to this? Having the same problem. Tried a few solutions but no to avail.

I'm not seeing this happen at all any more. There was a quite large fix added in 3.60 that resolved camera following (without physics), and if you set the camera lerp to 1:1 in the 'follow user controlled sprite' example the following is perfect with no stuttering. With a lerp value, the camera is clearly lerping, but I'm not witnessing any teleporting. If someone can re-create and demonstrate the issue with v3.80 then I'll happily take another look, but for now I'm suspecting this has been resolved via all the numerous updates that took place in the 4 years since the issue was opened.
The Camera is positioned in the preRender step - so it doesn't matter how many physics updates happened prior to that (0, 1 or more), it's always going to use the followers final x/y positions now.

hi @photonstorm , I'm having this issue on 3.70, but in my case I'm not using any physics from Phaser, since I'm creating a multiplayer game the player movement is coming 100% from the server and the position is been set "manually" and not using any speed applied on Phaser.
What I found is:

If I set the camera to exact follow the player movement 1:1, the player animation looks ok, but the background jitter (visible here: https://demo.reldens.com/).
If I set the camera with a lerp (0.2, 0.2) to make the camera movement slower, the background works fine but the player animation jitter.

As said, since I'm setting the position arriving from the server into the sprites, so I need to interpolate the position updates "on my own" in order to make the player movement smooth (but again, this is just changing the sprite X and Y). At this point, is where I'm trying to apply the fix on my code in order to keep the background working, but apparently even the slow camara would still make the player sprite jitter no matter what I do.
In result: as soon the camera movement goes of the player "focus" the jitter is visible on the player sprite, as soon the camare get the player as focus, the background jitter.
Unfortunately I don't have a extracted version to show the issue, but if I can't fix it on my own I will try to extract a an example to show.

UPDATE: I've managed to fix my player jitter with the interpolations, though the issue persist with the background if I set the camera following the player without any interpolation :(
hi @photonstorm , I'm having this issue on 3.70, but in my case I'm not using any physics from Phaser, since I'm creating a multiplayer game the player movement is coming 100% from the server and the position is been set "manually" and not using any speed applied on Phaser.
What I found is:

If I set the camera to exact follow the player movement 1:1, the player animation looks ok, but the background jitter (visible here: https://demo.reldens.com/).
If I set the camera with a lerp (0.2, 0.2) to make the camera movement slower, the background works fine but the player animation jitter.

As said, since I'm setting the position arriving from the server into the sprites, so I need to interpolate the position updates "on my own" in order to make the player movement smooth (but again, this is just changing the sprite X and Y). At this point, is where I'm trying to apply the fix on my code in order to keep the background working, but apparently even the slow camara would still make the player sprite jitter no matter what I do. In result: as soon the camera movement goes of the player "focus" the jitter is visible on the player sprite, as soon the camare get the player as focus, the background jitter.
Unfortunately I don't have a extracted version to show the issue, but if I can't fix it on my own I will try to extract a an example to show.

I am having the same issue as you. Did you ever figure out a solution?

Not yet, I'm going to tackle as soon I get some time, in between I've posted a few videos on the phaser discord server showing the issues but didn't got any replies. Ref: https://discord.com/channels/244245946873937922/416623653741133837/1230053213453942855

Follow up on https://github.com/phaserjs/phaser/issues/6810


suggestion insertAdjacentHTML/insertAdjacentText should enumerate the valid string parameters

TypeScript Version:  2.2.2.
It would be nice to have string parameters as typed set of string
type insertAdjacentPlace = 'beforebegin' | 'afterbegin' | 'beforeend' | 'afterend'

Should be working as descried, see InsertPosition. Fixed by https://github.com/Microsoft/TSJS-lib-generator/pull/246


Switch to using LAMMPS GPU Package

Better performance on our problem type

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.215%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
4063

Relevant Lines:
9858

💛  - Coveralls


Fixed installation dm_control on M1

Hello,
after successfully installing the dm_control package I get an error about the Mujoco version, I must use lib from 2.1.1 because only this version is compiled for M1 and is not allowed.
(base) ➜ martin@MacBook-Pro-uzivatela-Martin  ~  python3
Python 3.9.7 | packaged by conda-forge | (default, Sep 29 2021, 19:24:02)
[Clang 11.1.0 ] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from dm_control import suite
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/martin/miniforge3/lib/python3.9/site-packages/dm_control/suite/__init__.py", line 24, in <module>
    from dm_control.suite import acrobot
  File "/Users/martin/miniforge3/lib/python3.9/site-packages/dm_control/suite/acrobot.py", line 20, in <module>
    from dm_control import mujoco
  File "/Users/martin/miniforge3/lib/python3.9/site-packages/dm_control/mujoco/__init__.py", line 18, in <module>
    from dm_control.mujoco.engine import action_spec
  File "/Users/martin/miniforge3/lib/python3.9/site-packages/dm_control/mujoco/engine.py", line 42, in <module>
    from dm_control.mujoco import index
  File "/Users/martin/miniforge3/lib/python3.9/site-packages/dm_control/mujoco/index.py", line 88, in <module>
    from dm_control.mujoco.wrapper import util
  File "/Users/martin/miniforge3/lib/python3.9/site-packages/dm_control/mujoco/wrapper/__init__.py", line 20, in <module>
    from dm_control.mujoco.wrapper.core import callback_context
  File "/Users/martin/miniforge3/lib/python3.9/site-packages/dm_control/mujoco/wrapper/core.py", line 65, in <module>
    raise Error("MuJoCo library version ({0}) does not match header version "
dm_control.mujoco.wrapper.core.Error: MuJoCo library version (210) does not match header version (211)

This isn't a necessarily a safe change (it is in this particular instance, but generally speaking you won't be able to use bindings from one version of MuJoCo with a library with a newer version.)
The dm_control source code has been updated to work with MuJoCo 2.1.1 but we're currently working on updating some of dm_control's dependencies before pushing it out to PyPI. In the meantime, you can install the latest version of dm_control from GitHub's head via pip install git+git://github.com/deepmind/dm_control.git.
A number of dm_control's dependencies do not ship prebuilt wheels for ARM64. The one that is going to be most annoying is h5py since that needs a local installation of HDF5 that's built from source. If you have Homebrew install this is straightforward (brew install hdf5). If you don't want to install HDF5 locally, it's safe to comment out the h5py dependency from dm_control's setup.py (unless you need to use our motion capture data).


Support GCS

[x] I hereby verify that I am a sponsor.
Sponsorship is required before you can submit feature requests. See https://github.com/sponsors/Genbox

Describe the feature
Google Clouds Storage, GCS, also has an S3 compatible API, but it requires some tweaking to be supported by SimpleS3.
I have made the following work:
            ServiceCollection services = new ServiceCollection();
            services.AddAmazonS3(config =>
            {
                config.Credentials = new StringAccessKey("GOOG...", "IjqO...");
                config.RegionCode = "eu";
                config.Endpoint = new Uri("https://storage.googleapis.com");
                config.NamingMode = NamingMode.PathStyle;
            });

            var service = services.First(s => s.ImplementationType?.Name == "ChunkedContentRequestStreamWrapper");
            services.Remove(service);

            ServiceProvider provider = services.BuildServiceProvider();
            AmazonS3Client client = provider.GetRequiredService<AmazonS3Client>();

Notes:

It does not seem that GCS supports the streaming API, I was able to remove ChunkedContentRequestStreamWrapper and make it work
GCS does seem to support DNS-based path styles
GCS has a limited API coverage

They have both virtual and path style naming documented here: https://cloud.google.com/storage/docs/request-endpoints#xml-api

I've tested virtual and path style naming and it seems to work. I could not find any docs on support for streamed chunking, so I've disabled it by default by setting PayloadSignatureMode = SignatureMode.FullSignature; - which is the same as removing the ChunkedContentRequestStreamWrapper service.


Incorrect User Profiles Displayed in the Profile Page when navigating from the Threefold Team Page

Upon logging in and navigating to the Threefold Team page, a concerning issue has been identified. When clicking on any card representing a team member, all profiles displayed appear to be identical and belong to the Codescalers Admin user. This discrepancy in user profiles hinders the ability to access and view accurate information about different team members.
Screencast from 01-21-2024 10:43:32 AM.webm

Closed as fixed, please if you notice that the issue still exists open it again.


Why doing Key and Query Masking ?

Nice Job!
But in paper doesn't describe Key and Query Masking , can you give me some hint about that ?
thanks!

The encoder leaves artifacts, which are non-zeros, for paddings. It doesn't make sense, a query attends to those, so before applying softmax for getting score, I overwrote them with very very small numbers. As a results they will have score 0. Likewise, queries for paddings should not have any values, so they are masked with zeros.

But why do you put (-2**32+1), it is a huge num, not small nums
thanks for your time

The usage of the masking is judged by whether the summation of the keys or queries at the last dimension is zero. However, the padding part, which is originally embedded with zeros, is added by positional embedding, so they will never be zero. Thanks!!!!

@darongliu You have raised a very important point. We have to create a mask before the positional encoding, otherwise the whole padding doesn't work.

@zhedongzheng  Does this mean that this piece has a problem?

No, I think it will not cause great performance drop. It is still a good implementation.

@darongliu  Doesn't that mean that the query mask and key mask are useless?


Toggling interactive mode in PHPSpec

Now I've started using PHPSpec I've noticed that by default it runs in interactive mode. Is there a way of working out which strategies do and don't support interactive mode? Trying to work out the best way users can decide which mode they want to use

By "interactive" mode you mean that it doesn't exit by itself? If that's the case, I think for vim-test it would be much better if it wasn't interactive by default, and that people can enable it if they want to.

In interactive mode it can ask for user input, for example if you run a spec and the class being tested doesn't exist it will ask if you want to create the file.

Aha, I see. Well, instead of checking in the runner if the current strategy is in the list of strategies that can support interactive mode, I think it's much better to just let users choose whether they want the interactive mode, depending on their preferences and if they're using a supportive strategy.
let test#php#phpspec#options = '--no-code-generation'

What do you think?

I agree


Small improvements to CustomNumberInput

Describe your changes
When editing artifacts, I felt it was inconvenient to enter substat, so I tried to improve the following points.

The selection color is the same color as the background color, making it difficult to see.

It is easier to change the value if the value is selected when the input element is focused

NOTE: The selection color is "red", but any color can be used as long as it contrasts with the element's background color.
Issue or discord link

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

[x] I have commented my code in hard-to understand areas.
[x] I have made corresponding changes to README or wiki.
[x] For front-end changes, I have updated the corresponding English translations.
[x] I have run yarn run mini-ci locally to validate format and lint.
[x] If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

This is a stopgap implementation and not very smart.
It would be nice if it could be configured with mui. . .
Also, it would be nice if the input element could be made ready for input immediately after changing the substat item.

Oops, my apologies for the oversight.
I forgot to import useRef.
I'm sorry for any inconvenience caused.

Since CustomNumberInput is marked as deprecated and will likely be phased out in the near future,
I will be closing this PR. thanks

Thanks for the contribution, I appreciated that you found something you found unsatisfying and made an active effort to change it.


Add a status when Atom is downloading a new update

When I know there is a new update available for Atom, I can run "Check for Update" in the Help menu. Sometimes it is already running. The problem is lack of feedback: it seems, if it found an update, and is now downloading one, it doesn't tell the user it is doing this. Which would be useful.
Instead, as it is downloading the update, it simply looks like it is stuck checking for one. It would be nice if the Menu item could change to something like "Downloading Update (1.0.2) 43%..." or similar while it is doing this, to give feedback to the user that something is actually going on.

Checking Update and Downloading Update should be displayed correctly (but without a version number and %) - what are you seeing instead?

I am running Windows 7 x64, with atom installed from atom.io installer.
I am always only seeing a greyed out Checking for Update while I am pretty sure there is the new update being downloaded. After it is completely finished, (takes a while for me with ADSL over in Australia) IIRC it updates to text that a new update is ready to be installed (been a week since it happened, sorry).
I can quite clearly remember never seeing a Downloading Update text.

Seconding @Ivoz's observations. Never seen downloading update...

I'm seeing Downloading Update right now as I'm updating to 1.0.3...

Does this also happen with auto-updates or only when you click "Check for updates"?  In my case, Atom started auto-updating and displayed "Downloading update".

A percentage or other progress indicator would indeed be nice.
I didn't pay attention when I just updated, so not sure which text it displayed actually.

I can report I see Downloading Update now, on 1.0.2 -> 1.0.3

I'm guessing this could have been fixed by something in 1.0.2, haven't verified that yet though.
It seemed to take a while to show up, though. I would have thought a 'new version check' would normally be a <1 second network operation after which you'd quickly update the text.
I'd still advocate making the text more detailed, as a cosmetic upgrade. Adding ellipses at the end, for instance, is a common standard for indicating that something is ongoing. So text like Downloading Update... (<new_version_>) would be cool.

@Ivoz Is there any reason you closed this?

@50Wliu PR to implement this was closed in #8483 so I thought this wasn't wanted. If I'm wrong I can leave it open, would be nice to see.

All that #8483 did was add ellipses to the context menu, not add a download percentage or version.  I haven't had time to look into that yet but I'll try to investigate this week.

Unfortunately I'm too busy to realistically take a look at fixing this, so I'm going to unassign myself so that others can take a shot at it.


Pose calibration

I have followed all steps and everything is tracking but when I do pose calibration with the mat the trackers don't sample.

@renegade406 That sounds like the colour calibration is not set correctly for magenta (check the masked view) or the controller isn't stable enough (place it upright on a the mat on a table or something if you cannot hold it still enough).

I will try recalibration for magenta in the masked view that is probably why.

Worked like a charm thank you.


[Feature Request] Disable transition (animation) option in checkbox, radio and tree node

Existing Component
Yes
Component Name
Checkbox, Radio & Tree Node
Description
It would be great if there is a way to disable animation/transition when
-checkbox checked
-radio checked
-tree node expand collapse
this animation feels slow as a user experience and overall application seems slow due to that (this should be on last priority anyway :)).

Sorry, we have no plan to support this.

overwrite css style

overwrite css style

Well, yes of course I can disable transition by css, but the Transition component itself takes time to render. Here's a graph when I try to expand a large tree (with transition: none !important;)

@lianzhao Thank for your advice, we have consider this.


New rule: UntaggedRule

This rule will check if a configurable list of tags has been set. If not, the resource will be marked for deletion.

SimianArmy-pull-requests #183 FAILURE
Looks like there's a problem with this pull request

NetflixOSS » SimianArmy » SimianArmy-pull-requests #11 FAILURE
Looks like there's a problem with this pull request

SimianArmy-pull-requests #184 SUCCESS
This pull request looks good

NetflixOSS » SimianArmy » SimianArmy-pull-requests #12 SUCCESS
This pull request looks good

In janitor properties, UntaggedRule is set to enabled by default:
simianarmy.janitor.rule.untaggedRule.enabled = true

This seems overly aggressive as unleashing this without first making sure your infrastructure is appropriately tagged will cause janitor to start cleaning up everything.
Should we default it the other way to false so it isn't so destructive out-of the-box?


lines-areas-labels-base-template.stylx tags are not being updated by conversion process

From @abouffard on November 4, 2014 17:51
When I run the SQLite script here:
https://github.com/ArcGIS/military-features-pro-data/blob/master/source/utilities/style-utilities/merge-stylx-utilities/SqliteMergeStylx.sql
The resulting stylx file is not reflecting the geometry exception tags (gct_arrow, etc) that are now part of the control measures in the points-only stylx file (generated with the JMSML export csv)  The following line is an example of the tags we want in the final stylx:
https://github.com/abouffard/joint-military-symbology-xml/blob/master/samples/imagefile_name_category_tags/Military-All-Icons.csv#L893
So the line and area control measures in the manually maintained stylx (https://github.com/ArcGIS/military-features-pro-data/blob/master/data/core_data/stylxfiles/mil2525d-lines-areas-labels-base-template.stylx) are not getting their tags updated on merge,
@csmoore, if you'd like to look at this and can come up with an answer faster than I, please do so.  Otherwise, I am happy to research SQL(ite) and modify the script accordingly.
Copied from original issue: ArcGIS/military-features-pro-data_RETIRED_DONT_USE#93

From @csmoore on November 4, 2014 18:48
So the more generic problem is that the tags from the mil2525d-lines-areas-labels-base-template.stylx are not getting updated with the latest tag values from the updated spreadsheets.
The solution might be as simple as adding a step like this line:
https://github.com/ArcGIS/military-features-pro-data/blob/master/source/utilities/style-utilities/merge-stylx-utilities/SqliteMergeStylx.sql#L55
and change expression
NameJoin.styleItemUniqueId = ITEMS.Key
to something like
NameJoin.styleItemUniqueId LIKE ITEMS.Key + '%'
(assuming you can use "like" in this expression - that wildcard on the end "%" is somewhat important because it ensures that only IDs that startwith that Id will match-just so it doesn't match items in the middle)

While I was looking at/debugging SQL merges already, I figured I better take a look at this, addressed in https://github.com/csmoore/military-features-data/commit/bb65f5ee13d87774fbeedd174b532ce650b6da5f - but this script will need tested somewhat closely/diligently to make sure this mass update doesn't have some side effect I didn't notice.

Update sql script is done, we just need to thoroughly test - moving this to the next milestone

I have been manually updating the tags as I created new symbols, is there a way we can test to make sure the tags updated in the latest version of the mil2525D stylx? Or alternatively @csmoore is there any way I can get the update sql script to run?

Mentioned in the commit above - but the script to test is here: https://github.com/Esri/military-features-data/blob/master/data/mil2525d/utilities/style-utilities/merge-stylx-utilities/SqliteUpdateTemplateStylxTags.sql
It needs to be tested somewhat thoroughly though, something like: 1) export all the current ITEM tags/table as csv/xls 2) run the script 3) export again as csv & 4) do a diff against the 2 csv's to make sure nothing broke

Assigning to @abouffard to verify (he wrote the original issue).

Autoclosing - unverified

Just an update to officially close this out as verified - @Dbarnes1 did verify this, found an issue, and made a fix with #156


New version: Splashtop.SplashtopBusiness version <IP_ADDRESS>

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

I approved this in error - while the version is <IP_ADDRESS> it has <IP_ADDRESS> in the path.


3rd day with update on issue

Describe the problem
Pallamf
Hi.  I went in today, and it locked up again when unpausing the game.  I think I know how to get it to work, and am sharing here for completeness.
The other day, I disabled 81 tiles.  Went in, the game worked, came off pause.  25 tiles were unlocked.
I added purchase it.  Went in, the game worked, came off pause.  25 tiles were unlocked.
oday, I tried to open the game, and it locked when trying to unpause. (File a) )
Then, I tried safe mode with all 3 buttons enabled.  The game came off pause, but only went for 1 day, then locked up (perhaps when the first car spawned? ) (File b) )
I then disabled 25 tiles.  Went in, the game worked, came off pause and continues to run.  25 tiles are unlocked.  (File c) )
I attached the 3 player files related to the above 3 attempts.
Steps to reproduce

Log files

a)
Player remove 81 - add purchase it.log
b)
Player Safe mode with purchase it.log
c)
Player disabled Purchase It.log
Savegame?

Screenshots?

Notes or questions?

There's no errors in the logs, so I think we're going to have to try process of elimination to see if we can narrow down the cause.
I use almost all the same mods you use, so if it's mod related issue then it will be one of the mods you use that I don't use. Here's a list of those mods:

Parallel Road Tool
Resize It
Roundabout Builder
Smart Intersections
Pause On Load
Speed Slider
Net Picker
Network Extensions 2 (don't remove this)
Mods List
Undo Mod

Could you try disabling those mods (except NExt2), then exit to desktop, then relaunch + load your save and see what happens?

@pallamf Did you get chance to try without those mods?

@aubergine10  It took me a while to figure it out.  I was not able to reproduce the locking right away.  The short answer is it's "Pause on Load", but only if I play right away.
If I start up and let the game sit for about 30-45 seconds before taking it off pause, it'll work.  If I try to play sooner than that, it doesn't work, or if I try to resume a game, it locks.
When I removed Pause on Load, CS plays as expected.
To confirm, I readded Pause on Load, and the locking behavior started again.

@aubergine10 It took me a while to consistently reproduce the problem.  In short, it's "Pause on Load", but only if try to play within 30-45 seconds of loading.
If I load a game with POL, and play right away, or resume, it locks.  But if I let a game sit for 30-45 seconds before taking it off pause, it'll work.
Once I figured that out, I removed POL, and the game functioned normally.
I added POL back in, and it locked up as previously described.

Ah, the recent update must have broken that mod.
Thanks for the update!


During Ctrl+multiple file selection, file contents should be shown for every recent click

Issue Type: Feature Request
While working on a large number of version controlled files, i often like to revert the changes to multiple files.
The way i do it is to click on the Source Control tab on the left, and then hold down the control button, and select whichever file i want. Once i finish my multi-file selection, i revert my changes. However, during this file-by-file selection while holding down the ctrl button, i would like to see the actual file contents displayed on the right, so that i won't accidentally revert a file that is unintended to be.
Here are 2 GIF's to explain.

Just clicking whichever file you want normally.

Holding down Ctrl button and then selecting files. Notice, the end user will not be able to see the contents of the file, so there is a possibility that, a wrong file might be reverted accidentally

Expected fix: while holding down Ctrl button and during multiple file selection, the file should be displayed on the right

VS Code version: Code 1.29.1 (bc24f98b5f70467bc689abf41cc5550ca637088e, 2018-11-15T19:13:36.375Z)
OS version: Windows_NT x64 10.0.14393

Two ways to achieve this:

Click the Open File inline action to see each file. This will not clear the current selection.
Right-click each file and run Open Changes. This will also not clear the current selection.

works for now. Thank you


TDP: bindEvents Cannot read property 'addEventListener' of null

Bug
TDP calls bindEvent, but searchContent is undefined as its ID tdp-search-facets-and-results is not found in the DOM at https://github.com/cfpb/teachers-digital-platform/blob/master/teachers_digital_platform/js/tdp-analytics.js#L244 when visiting https://www.consumerfinance.gov/practitioner-resources/youth-financial-education/curriculum-review/tool/
Current behavior

Uncaught TypeError: Cannot read property 'addEventListener' of null error is thrown when visiting https://www.consumerfinance.gov/practitioner-resources/youth-financial-education/curriculum-review/tool/

Expected behavior

No error in the dev console should be thrown on https://www.consumerfinance.gov/practitioner-resources/youth-financial-education/curriculum-review/tool/

Steps to replicate behavior

Visit https://www.consumerfinance.gov/practitioner-resources/youth-financial-education/curriculum-review/tool/
Note error in dev console.

Screenshots

This also appears on https://www.consumerfinance.gov/practitioner-resources/youth-financial-education/journey

This looks like it was fixed. Do we have a PR reference for the fix?


Feature: Custom reset password form

Adds the ability to customize the ResetPasswordForm component with own onSubmit() function and content markup.
For documentation, see: https://github.com/stormpath/stormpath-sdk-react/blob/feature-custom-reset-password-form/docs/api.md#resetpasswordform
Before reviewing
Before this is reviewed we need to merge in #19 (Feature: Custom registration form). The same discussion as in #19 also applies to this PR.
Also, the example is currently not handling the change password link in the email from the password reset request. So simply ignore this when reviewing this PR. The important thing to review is that the form works as expected.
How to verify

Clone this repo and checkout this branch.
Build this project by running $ npm run build.
Run $ npm link to make this the module to link to when running $ npm link react-stormpath.
Clone the React example project.
Run $ npm link react-stormpath to link to our SDK.
Run $ npm start to host the example project.
Open up your browser and navigate to http://localhost:3000/.
Navigate to the reset password page and try to reset the password for an existing user.
Customize the ResetPasswordForm on the ResetPasswordPage component according to the following docs: https://github.com/stormpath/stormpath-sdk-react/blob/feature-custom-reset-password-form/docs/api.md#resetpasswordform.
Repeat steps 6 to 8.

I'm getting a build error on this branch as well:
Hash: f912d353a67e0c056bc9
Version: webpack 1.12.12
Time: 4855ms
                 Asset    Size  Chunks             Chunk Names
stormpath-sdk-react.js  255 kB       0  [emitted]  main
    + 79 hidden modules

ERROR in ./src/components/ResetPasswordForm.js
Module not found: Error: Cannot resolve 'file' or 'directory' ../utils in /Users/robert/projects/stormpath-sdk-react/src/components
 @ ./src/components/ResetPasswordForm.js 22:13-32

><EMAIL_ADDRESS>build-min /Users/robert/projects/stormpath-sdk-react
> NODE_ENV=production webpack -p src/index.js umd/stormpath-sdk-react.min.js

Hash: 503ccd11fe50c7ddee53
Version: webpack 1.12.12
Time: 6516ms
                     Asset    Size  Chunks             Chunk Names
stormpath-sdk-react.min.js  103 kB       0  [emitted]  main
    + 79 hidden modules

WARNING in stormpath-sdk-react.min.js from UglifyJs
Side effects in initialization of unused variable state [./~/react-router/lib/Link.js:106,0]
Condition always true [./~/react-router/lib/Redirect.js:49,0]
Condition always true [./~/history/lib/createMemoryHistory.js:69,0]
Condition always true [./~/react-router/lib/IndexRedirect.js:49,0]
Condition always true [./~/react-router/lib/IndexRoute.js:46,0]
Condition always true [./~/react-router/lib/Route.js:50,0]

ERROR in ./src/components/ResetPasswordForm.js
Module not found: Error: Cannot resolve 'file' or 'directory' ../utils in /Users/robert/projects/stormpath-sdk-react/src/components
 @ ./src/components/ResetPasswordForm.js 22:13-32

@robertjd Same as #21. The reason I wrote in "Before reviewing" that we need to merge #19 (Feature: Custom registration form) before reviewing is that #19 contains the base functionality for custom forms (that this depends on). So before we can review/test this, we need to merge #19 in and do a rebase.

Oh, my bad!  I just looked at #19 again.  Please see latest comment from me.

I've rebased with master locally, and when I run this I get errors on the forgot-password page:

@timothyej Yeah, this because we merged the custom Registration form PR that contained an issue. But I have fixed that now. So please try again.

I've verified that this works as advertised :+1:


Doc: access policy fix and expansion

Fixes https://github.com/edgedb/edgedb/issues/6389 where a user noticed that the syntax declaration for access policies makes it look like annotations should be outside the braces when they should be inside, and that we don't have any access policy examples that show where annotations belong either so it took some experimentation to figure it out.
In our current example there is a bit of new learning to do so instead of declaring a new annotation at the same time, it uses the built-in errmessage to show where to add such notes and then mentions in the breakdown below that other annotations can go in this space as well. Plus adds an example where you might see this error: where an app is configured wrongly such that a user is allowed to try to write a post but is prevented by the access policy.

Looks good. A few minor changes, and this is ready to go!

Okay, I think I got them all!

@raddevon Forgot all about this PR! In the meantime a small merge conflict popped up but has now been resolved.

Okay, just added https://github.com/edgedb/edgedb/pull/6573/commits/f005df87bfee937cb942a9fe106177d8cdc6b821 on which operations return empty sets vs. which will show errors. Adding this is pretty nice as it allows a more thorough explanation on update read vs. update write in the section in which they are introduced.


Failed upload has different response in Web UI vs Ajax interface

Uploading a broken zip through the Web UI has a visual message telling users that the upload failed. However, doing it through the Ajax interface still tells you the same thing, but is accompanied with a HTTP 200 response (success). This causes scripts to break as they should be expecting 400 (bad request).

There are many other problems similar to this that need to be addressed. The issue to fix that is filed at #795


Exapand "encapsed" support

Support for curly syntax is not complete - see
https://github.com/glayzzle/php-parser/issues/101

I know the parser doesn't fully handle the curly's - should we just comment out that test case or something for now? would be good to keep the tests passing if we can

You could use https://facebook.github.io/jest/docs/en/configuration.html#testpathignorepatterns-array-string

What we've done for prettier is to keep those as github issues. Committing code that's not working is usually a bad idea: people get confused as to why it's there and not working.


Youtube in header

Who is this for?
Conte t producers who want to add video to pages.
What is it doing for them?
Adding Youtube embeds as the media in the BasicHeader.
Using the storybook version really makes you think about the API to your component, I'm liking it.
Waiting on:
https://github.com/wellcometrust/wellcomecollection.org/pull/2631

@wellcometrust/experience-dev out of WIP.


Work with vanilla zsh settings

Zsh is very customisable and some of the customisations will break the
completion function.  Restore the state to its default for the duration
of the function.

Thanks, looks good to me. Can you give me a set of options that breaks the function as an example? I would like to reproduce the problem locally, and confirm that the patch fixes the issue.

I wish I knew that off-hand.  I'll look round for some likely candidates, but my .zshrc is quite well customised by now...

I have found the culprit in my case: setopt posix_builtins

I tested with this extremely minimal zshrc
[ -f ~/.fzf.zsh ] && source ~/.fzf.zsh
setopt posix_builtins

but fuzzy-completion seems to work just fine. vim ~/**<tab>, cd **<tab>, etc. Am I missing something?

Ah, it needs a couple of options.  Try this:
setopt all_export posix_builtins
. ~/.fzf.zsh

Oh yeah, now I can reproduce. Looks like CTRL-R also seems to break with those options. Should we do the same for fzf-history-widget as well?

Ah, yes, fzf-history-widget needs it too.  And it probably makes sense to do the same for fzf-cd-widget and fzf-file-widget too, even though they work with this particular configuration, as they may well break with some other configuration, or if they get changed.

So, what do you think?
diff --git a/shell/completion.zsh b/shell/completion.zsh
index 9b9dba3..ccd18ce 100644
--- a/shell/completion.zsh
+++ b/shell/completion.zsh
@@ -46,7 +46,7 @@ __fzf_generic_path_completion() {
   tail=$6
   fzf="$(__fzfcmd_complete)"

-  setopt localoptions nonomatch
+  setopt nonomatch
   dir="$base"
   while [ 1 ]; do
     if [[ -z "$dir" || -d ${~dir} ]]; then
@@ -142,8 +142,8 @@ _fzf_complete_unalias() {
 }

 fzf-completion() {
+  emulate -L zsh
   local tokens cmd prefix trigger tail fzf matches lbuf d_cmds
-  setopt localoptions noshwordsplit noksh_arrays

   # http://zsh.sourceforge.net/FAQ/zshfaq03.html
   # http://zsh.sourceforge.net/Doc/Release/Expansion.html#Parameter-Expansion-Flags
diff --git a/shell/key-bindings.zsh b/shell/key-bindings.zsh
index 9b2353a..dbafafb 100644
--- a/shell/key-bindings.zsh
+++ b/shell/key-bindings.zsh
@@ -27,6 +27,7 @@ __fzfcmd() {
 }

 fzf-file-widget() {
+  emulate -L zsh
   LBUFFER="${LBUFFER}$(__fsel)"
   local ret=$?
   zle redisplay
@@ -38,9 +39,10 @@ bindkey '^T' fzf-file-widget

 # ALT-C - cd into the selected directory
 fzf-cd-widget() {
+  emulate -L zsh
+  setopt pipefail 2> /dev/null
   local cmd="${FZF_ALT_C_COMMAND:-"command find -L . -mindepth 1 \\( -path '*/\\.*' -o -fstype 'sysfs' -o -fstype 'devfs' -o -fstype 'devtmpfs' -o -fstype 'proc' \\) -prune \
     -o -type d -print 2> /dev/null | cut -b3-"}"
-  setopt localoptions pipefail 2> /dev/null
   local dir="$(eval "$cmd" | FZF_DEFAULT_OPTS="--height ${FZF_TMUX_HEIGHT:-40%} --reverse $FZF_DEFAULT_OPTS $FZF_ALT_C_OPTS" $(__fzfcmd) +m)"
   if [[ -z "$dir" ]]; then
     zle redisplay
@@ -57,8 +59,9 @@ bindkey '\ec' fzf-cd-widget

 # CTRL-R - Paste the selected command from history into the command line
 fzf-history-widget() {
+  emulate -L zsh
+  setopt pipefail 2> /dev/null
   local selected num
-  setopt localoptions noglobsubst pipefail 2> /dev/null
   selected=( $(fc -l 1 |
     FZF_DEFAULT_OPTS="--height ${FZF_TMUX_HEIGHT:-40%} $FZF_DEFAULT_OPTS +s --tac -n2..,.. --tiebreak=index --bind=ctrl-r:toggle-sort $FZF_CTRL_R_OPTS --query=${(q)LBUFFER} +m" $(__fzfcmd)) )
   local ret=$?

(Reference: http://zsh.sourceforge.net/Guide/zshguide02.html)

That looks good to me (although I haven't run it). The -L option to emulate is certainly the right way to go.

Alright, let's push the fix and see if anyone complains.


Update MD file on new branch 2017-11-13_08-29-51

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/content1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[BUG] FfmpegOutput class : audio_samplerate parameter not used (typo)

In the FfmpegOutput class, implemented in picamera2/picamera2/outputs/ffmpegoutput.py, the audio_samplerate paramter is not used in the start() method due to a typo on line 62, where the bitrate variable is use instead:
'-sample_rate', str(self.audio_bitrate),
It is probably a typo, the correct line should be:
'-sample_rate', str(self.audio_samplerate),

Oops, thanks for pointing that out. I'll patch that up right away!

That's been merged onto our "next" branch now so it'll be in the next release. Thanks again.


Remove CustomCache requirement

I revisted this today, and while testing, I didn't run into any issues with the Web Cache API this time. 🤷
@do-me @VarunNSrivastava If possible, could you test this example project locally too? Just to make sure it doesn't break anything.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

It's working locally for me.

I think it was crashing before because I was doing a local check before downloading from the Hub. Either that, or there was a Chrome bug fix in the past 2 months (which I doubt 😅).
@VarunNSrivastava Thanks for the info! I'll get these changes merged soon.


[11.x] Use PHP 8.4 array helpers

PHP 8.4 introduces new array search functions for finding items matching criteria or determining if any/all of them pass. See also https://php.watch/versions/8.4/array_find-array_find_key-array_any-array_all.
This PR introduces these helpers in the Arr and Collection classes to use 'modern' logic for the case where these functions are available. If in the future the minimal PHP version is 8.4, this will allow for further simplification by removing the old logic altogether.
Requires #52633 to be merged or to be merged into #52633.

Hi there, can you rebase this PR to php84 as we working on proper support to PHP 8.4 on that branch.

If the current code is working I would just leave it. 🤷♂


[dif/otp_ctrl] OTP followups

[ ] Use the correct lock registers (CHECK_REGWEN vs. CHECK_TRIGGER_REGWEN).

Closing as obsolete.

Not obsolete, actually. Sorry I didn't notice this was assigned to me.

It looks like there is more to do here than initially expected. The lock code is from back when regwen was rw1c, but it's now rw0c. There might need to be an audit for other such changes.


helm: Simplifying enablement of otel tracing

Solves #918
PR is based on top of #924 as changes from that PR as essential here.
Breaking changes:

args section is moved to extraArgs to note that arguments may be added using other parameters
tracing section moved to openTelemetry

Enhancements:

enabling OT tracing can be done just with openTelemetry.enable parameter and do not require setting any other parameters
tracing port name changed to reflect its relation to OpenTelemetry

bors r+


v0.8.5_28: Country names with the population are merged with each other

SEVERITY: Minor
MODULE: Mountain Chart
Platform:  MAC / Safari 8.1
RELEASE: v0.8.5
STEPS TO REPRODUCE:

Navigate URL: http://static.gapminderdev.org/vizabi/release/v0.8.4/preview/Mountainchart.html
Mountain chart page will be loaded
Select any 4 to 5 curves for different countries
Note that country names with the population are merged with each other

ACTUAL RESULTS:
Country names with the population are merged with each other
EXPECTED RESULTS:
There should be space between every two consecutive country names with the population for better visibility
SCREENSHOT:

So, please CSS style the font size, to be smaller in this situation

@olarosling it's sligtly more tricky
this happens because of incorrect fix #777 for the issue #755 (spacing was set to 0.7 of label box height)
fixed now


As State Admin, I need to maintain list of pictures of resource provider organizations.

From @czdiana2321 on June 4, 2018 21:50
USER-> Directory/Topic
Acceptance Criteria:

State Admin is able to provide list of pictures of resource provider organizations like location
State Admin is able to update list of pictures of resource provider organizations.
Images should be part of the Resource metadata not a separate bucket

Copied from original issue: Microsoft/Access2Justice#131

@KellyeDC  We don’t need this for pilot.


[Feature]  Enhacing the feedback form

Description
The feddback form is taking too much space on footer and hence the footer is lokking too large so would to like adjust the feedback form at footer with low space with better UI enhance
Screenshots

Checklist

[X] I have checked the existing issues.
[X] I have read the Code Of Conduct
[X] The changes don't break the code
[X] Please attach the screenshots and video of the development work once it is done

@swaraj-das PLEASE assign this issue to me as would like to contribute with you !!

Is this issue assign to me??

Is this issue assign to me??

Yes assigned now.


[Ubuntu] Remove duplicated line with Python version from report

Description
As Python 2.7 has been removed from Ubuntu we don't require to separate items for Python version in software report. This PR removes one of that items.
Related issue: -
Check list

[ ] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

/azp run ubuntu2004,ubuntu2204


Update the documentation to include sharding.

What is your question?
I didn't know this package existed until @jmcdo29 told me about it on the nestjs discord. It seems you support more than the @discord-nestjs/core package. I made a recommendation to them about adding documentation for sharding, I created a simple explanation here.
I think adding something similar to your documentation would be extremely beneficial. It would also be worth your time to add examples using discord-hybrid-sharding and discord-cross-hosting packages I mentioned in the explanation above as this is super important for bots that require scale.
I would be more than happy to contribute to the documentation if this suits you!

Hi @KieronWiltshire, thank you for your question!
Adding this information has long been planned, glad you asked!
Of course, you can contribute to the documentation, just create PR here, replies to this issue!
Happy Coding!


Upgrade embedded Kotlin from  to 1.6.10

See

https://kotlinlang.org/docs/whatsnew16.html
https://github.com/JetBrains/kotlin/releases/tag/v1.6.0
https://github.com/JetBrains/kotlin/releases/tag/v1.6.10

Doing this in a 7.x we need to keep script compilation and kotlin-dsl plugin to target Kotlin 1.4 language and api for backwards compatibility.

@bot-gradle help

Currently, the following commands are supported:
@bot-gradle test <BuildTrigger1> <BuildTrigger2> ... <BuildTriggerN>

A trigger is a special build for this PR on TeamCity, common triggers are:

SanityCheck/CompileAll/QuickFeedbackLinux/QuickFeedback/PullRequestFeedback/ReadyForNightly/ReadyForRelease
Shortcuts: SC/CA/QFL/QF/PRF/RFN/RFR
Specific builds:

PT: PerformanceTest, all performance tests for Ready For Nightly stage.
APT: AllPerformanceTest, all performance tests, including slow performance tests.
AST: AllSmokeTestsPullRequestFeedback
AFT: AllFunctionalTestsPullRequestFeedback
ASB: AllSpecificBuildsPullRequestFeedback
ACC: AllConfigCacheTestsPullRequestFeedback
ACT: AllCrossVersionTestsReadyForNightly
AFTN: AllFunctionalTestsReadyForNightly
ACTR: AllCrossVersionTestsReadyForRelease
AFTR: AllFunctionalTestsReadyForRelease

@bot-gradle test and merge

queues this PR for testing and merges if all tests pass by:

Creating a merge commit from your PR branch HEAD and the target branch
Running a ReadyForNightly build against the merge commit
When it passes, fast-forward the target branch to this merge commit (i.e. merge the PR)

The merge commit is called a pre-tested commit, which means that it fully tests the integration
of your branch HEAD and latest master, instead of only testing your branch HEAD.
@bot-gradle cancel

cancel a running pre-tested commit build or remove it from queue

@bot-gradle clean

clear the conversation history

@bot-gradle help

display this message

To run a command, simply submit a comment.  For detailed instructions see here.

@bot-gradle test RFN APT ACC

Sorry some internal error occurs, please contact the administrator @blindpirate

@bamboo could you please take a first look before the publication of the plugins?

@bot-gradle test RFN APT ACC

Sorry some internal error occurs, please contact the administrator @blindpirate

@bot-gradle test APT ACC

Sorry some internal error occurs, please contact the administrator @blindpirate

I'm looking

@bot-gradle test APT ACC

OK, I've already triggered the following builds for you:

AllPerformanceTestsReadyForRelease build
AllConfigCacheTestsPullRequestFeedback build

Thanks Bo!

@bot-gradle test APT ACC RFN

OK, I've already triggered the following builds for you:

AllPerformanceTestsReadyForRelease build
AllConfigCacheTestsPullRequestFeedback build
ReadyForNightly build

@bot-gradle test APT ACC RFN

OK, I've already triggered the following builds for you:

ReadyForNightly build

@bot-gradle test RFN

@bot-gradle test RFN APT

OK, I've already triggered the following builds for you:

ReadyForNightly build
AllPerformanceTestsReadyForRelease build

@bot-gradle test and merge


[FLINK-23009][kinesis] Upgrade Guava for Flink Connector Kinesis

What is the purpose of the change
Upgrade Guava dependency for Flink Connector Kinesis. The connector was using Guava 18.0 which is quite old and has been flagged by some security tools as noted in another ticket https://issues.apache.org/jira/browse/FLINK-22774
This PR also makes the flink-sql-connector-kinesis use the Guava dependency transitively through the flink-connector-kinesis dependency.
Brief change log

Bumped Guava for Flink Connector Kinesis from 18.0 (inherited from parent) to 29.0-jre

Verifying this change
This change is already covered by existing tests, such as FlinkKinesisProducerTest.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): yes
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

@flinkbot run azure

@flinkbot run azure

integration test KinesisTableApiITCase is failing. I believe it's not related to the changes here. Might be a flaky test, will look into it

integration test KinesisTableApiITCase is failing. I believe it's not related to the changes here. Might be a flaky test, will look into it

there was a ticket for this issue already: https://issues.apache.org/jira/browse/FLINK-22492

LGTM, merged. Agree flaky test is captured in the jira


We need a strong meaningful name for this project

"go-adapter" says nothing about what this pkg actually does.
So in order for this to work as an open-source project, we'll need a better descriptive name.
Currently, I am thinking about this project as a helper for the fasthttp routing lib, so maybe fasthttpio or fhio would be one option.
Another possibility would be to have this code inserted on the routing pkg itself, which would be nice as well.

Another option:

RequestUnmarshaller
RequestDecoder
HTTPDecoder


Perf: Query: Removes two allocs from query execution

See commits.

release/2.1 branch?

@smitpatel Yeah, definitely for the other one.


Create logging_to_mysql.md

From issue #470

Hey, would you be up to reviewing each other’s work?

@Tahasp Hi, sorry I have already found teammate to review my work.

Hi Tien, the PR looks good overall, I like the visuals and images you included, especially the video.
One thing you could add is you can explain your logs table in Step 2. For instance, the user might not know what a level is or why it needs to be added. You have a pretty good explanation for users table in part 3, maybe you can do something similar for logs table.
On a similar note, since you are adding a users table, but not all logging requires a user, you can add a section explaining a use case where someone would need a users table, and explain that this tutorial will be most helpful in similar cases.

@OliviaYZhou Hi Olivia, thank you for your review and I have made changes based on your suggestion.

Hi Tien, I've seen the changes and they look great. The explanations make the tutorial clearer. This will be a great guide for anyone who wants to create logging using mysql.


loading config file during installation

loading config file to related config path during pip installation
version unification - we need to edit one place to bump the version all over the code now
version bump

+1


[Tickets] Single closed threads still shown in Ticket Overview.

Just noticed today that one of the closed threads is still visible in ticket overview:

Currently from what I found, it's only one out of the 60 tickets we have open right now and the ticket itself closed without any issues so it is a rare occurrence. If I close any other ticket, the only thing that changes is the ticket overview number on the thread that is already closed.

Seems it resolved itself eventually.


Fix typos in fastfat comments

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: QuintenJohnson sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Spam & thread hang

Description
Server has been running fine for weeks (still daily restarts) and then it randomly died. Starting spamming luckperm messages saying "unloading user data for" and blocked the main thread which led to everyone being timed out.
Reproduction steps
I have no idea how to reproduce this error.
Expected behaviour
To not spam messages and block the thread.
Environment details
Latest Tuinity (1.16.5)
LuckPerms version: 5.3.16
https://pastebin.com/fTuymg89
Any other relevant details
None

Disable debug-logins in the LP config.yml


Setup preferences

Codecov Report

Merging #115 (ef22bbd) into main (657ff01) will increase coverage by 0.01%.
The diff coverage is 74.46%.

@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   74.03%   74.04%   +0.01%
==========================================
  Files          35       41       +6
  Lines        1779     1826      +47
  Branches      253      254       +1
==========================================
+ Hits         1317     1352      +35
- Misses        344      356      +12
  Partials      118      118

Impacted Files
Coverage Δ

...kotlin/com/alexvanyo/composelife/HiltTestRunner.kt
0.00% <0.00%> (ø)

...mposelife/preferences/di/PreferencesProtoModule.kt
0.00% <0.00%> (ø)

...elife/preferences/DefaultComposeLifePreferences.kt
44.44% <44.44%> (ø)

...yo/composelife/preferences/PreferencesDataStore.kt
83.33% <83.33%> (ø)

...elife/algorithm/ConfigurableGameOfLifeAlgorithm.kt
90.90% <90.90%> (ø)

...elife/preferences/di/TestPreferencesProtoModule.kt
100.00% <100.00%> (ø)

...om/alexvanyo/composelife/ComposeLifeApplication.kt
0.00% <0.00%> (-100.00%)
:arrow_down:

...exvanyo/composelife/algorithm/HashLifeAlgorithm.kt
83.48% <0.00%> (+0.22%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 657ff01...ef22bbd. Read the comment docs.


Only allow integer steps on axis

Is there an option to only allow integer values for the steps on a bar chart? So it never, for instance, has steps of "0.5" when the bar chart is showing "things" that cannot exist in quantities less than 1

+1

+1


{CI} Drop service connections in azure devops public project

Related command

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Thank you for your contribution! We will review the pull request and get back to you soon.


[flutter_tools] disable SWR optimization on dev

Description
The oct-nov period where this feature was enabled show a large variance in hot reload times compared to prior months, and not an average improvement. its possible this is related to null safety work, but to be sure - disable this feature so that we can gather stats for december/jan

Possible outcomes:

if performance starts to improve on dev after a release where this was landed, then back to the drawing board
If performance gets worse or stays the same, well then it is probably null safety related and we should proceed with moving this forward


VSO 8207235: Reflect.apply and Reflect.construct require argumentsList params (and the value must be an array or array-like object).

Thanks @Cellule for the help. Mind giving a quick review?
/cc @jdalton

I am just wondering if object and arrays are the only structures to be considered ArrayLike.
Otherwise, the error message bothers me a little because Reflect.apply doesn't expect the arguments object. It expects an ArrayLike object.
If we don't want to create a new error message for this case, I don't particularly mind.

See:
https://tc39.github.io/ecma262/#sec-reflect.apply
https://tc39.github.io/ecma262/#sec-createlistfromarraylike
https://tc39.github.io/ecma262/#sec-ecmascript-language-types
According to the spec, if I'm reading it correctly, there is no spec type for Array or TypedArray, and they are classed as special kinds of Object.
CreateListFromArrayLike requires that the input type is an Object -- any array-like object will do. There's no problem with passing an Object with no keys that look like array indexes, the resulting array will be empty. Passing an array-like Object or Array or TypedArray works.
I'm going to test native arrays and refactor the condition to a new method called  JavascriptOperators::IsArrayLike
I'll also create a new error to improve the message.

Okay, good call. It looks like the previous condition didn't cover TypedArray.
Improved check, added tests, and added a new error code.

FYI, I just merged a change to isolate Wasm related error messages, so you will have to rebase on release/1.4 and change the value of your new error message

@Cellule - just noticed and fixed, thanks!

At https://tc39.github.io/ecma262/#sec-createlistfromarraylike
The main check is If Type(obj) is not Object, throw a TypeError exception.
The current implemented check is insufficient because it misses a lot of other types that returns "object" to typeof
I suggest doing Typeof(argArray, scriptContext) == scriptContext->GetLibrary()->GetObjectTypeDisplayString() instead which will check if the typeof argArray is object
I tested with types like Promise, Proxy, Error and more which all return "object" to typeof, but were not allowed in Reflect.apply

@Cellule how's this look?

Humm, typeof null === "object", but from the spec, null doesn't have the object type... this is weird

@Cellule Type(null) is Null in the spec, but indeed typeof null === 'object' in JS. The Type abstract operation isn't the same as typeof.

Yeah that's what I see... I don't know if we have something in our code that matches the spec Types.
https://tc39.github.io/ecma262/#sec-typeof-operator-runtime-semantics-evaluation clearly shows the different spec type and why I was wrong to suggest to use typeof operator since Functions are accepted (Object type with typeof returning "Function") and null is not accepted (Null type with typeof returning "object")

Yeah apparently I forgot to rebuild before re-running the tests locally.

Okay, I think I got it... Try JavascriptOperators::IsObjectType that should give us what we need

@Cellule Looking good so far.


fix: correct the order of the deletion routine

The goal of this PTAL is to fix concurrent issues that may happen because of the order that the deletion is being made

@rsafonseca do you have any thoughts on this? The way we are configuring now, we are locking the sync while we are deleting a single cluster.


provision: fix the error message when a distro image is not found

Signed-off-by: Kefu Chai<EMAIL_ADDRESS>

should fix the error message like: http://pulpito.ceph.com/kchai-2019-12-18_08:14:51-rados-wip-kefu-testing-2019-12-18-1155-distro-basic-mira/4613679

@susebot run deploy

@tchaikov @toabctl the deploy test failed due to openstack glitch, however I would avoid merging PRs before receiving a report from the bot about successful tests if requested the test. No action required now, I hope changes are non-destructive.


fix: upgrade packages + convert to function components with hooks

Upgrade packages
Convert class components to function components and reimplement lifecycles with useState and useEffect hooks (deprecation warnings in the console)

Oof, this got stale but it's still pretty great.  Can we take this off-hold?

Superceded by this PR: https://github.com/dhis2/dashboards-app/pull/1177


Build: BuildVSIX.ps1 currently failing

Currently getting this output when trying to build
PS C:\GitHub\sqlops-mssql-instance-insights> .\BuildVSIX.ps1
Error: Command failed: npm list --production --parseable --depth=99999
npm ERR! missing: sqlops@github:anthonydresser/sqlops-extension-sqlops, required by<EMAIL_ADDRESS>
Error: Missing publisher name
Error: Missing publisher name
Error: Missing publisher name
Error: Missing publisher name
Error: Missing publisher name
Error: Missing publisher name
Error: Missing publisher name
Error: Missing publisher name
Error: Missing publisher name
Error: Missing publisher name
^CTerminate batch job (Y/N)? y
PS C:\GitHub\sqlops-mssql-instance-insights\node_modules\ajv>

Current version
PS C:\GitHub\sqlops-mssql-instance-insights> vsce -V
1.39.0
PS C:\GitHub\sqlops-mssql-instance-insights>

The package is up to 1.44.0 @ https://www.npmjs.com/package/vsce
``
PS C:\GitHub\sqlops-mssql-instance-insights> npm view vsce version
1.44.0
PS C:\GitHub\sqlops-mssql-instance-insights>

Will update package.json and use the latest to see if that helps.

Updated package.json then ran npm update vsce -g which has brought it up to 1.44.0
Here is the transcript.
PS C:\GitHub\sqlops-mssql-instance-insights> npm update
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

removed 310 packages and moved 27 packages in 15.836s
PS C:\GitHub\sqlops-mssql-instance-insights> vsce -V
1.39.0
PS C:\GitHub\sqlops-mssql-instance-insights> npm update vsce
PS C:\GitHub\sqlops-mssql-instance-insights> vsce -V
1.39.0
PS C:\GitHub\sqlops-mssql-instance-insights> npm update vsce -g
C:\Users\matt_\AppData\Roaming\npm\vsce -> C:\Users\matt_\AppData\Roaming\npm\node_modules\vsce\out\vsce
+<EMAIL_ADDRESS>updated 10 packages in 6.065s
PS C:\GitHub\sqlops-mssql-instance-insights> vsce -V
1.44.0
PS C:\GitHub\sqlops-mssql-instance-insights>

Problem was with this line of BuildVSIX.ps1
# Get the packages to build in this repo
$packageFiles = Get-ChildItem -Path $scriptPath -Recurse -Filter 'package.json'

This is legacy code due to the fact that we had multiple packages in the one repo originally. Now that we are using "advanced" extensions which also include npm modules we need to add some exclusions to restrict the recursive nature. In the future we might need to extend this to exclude additional paths or be configurable.,
The code has been changed to
# Get the packages to build in this repo (ignore the node_modules though)
$packageFiles = Get-ChildItem -Path $scriptPath -Recurse -Filter 'package.json' -File | Where-Object DirectoryName -NotLike "$(Join-Path -Path $($scriptPath) -ChildPath 'node_modules')\*";


Deletion of someone else' datasets

In Codabench > Resources > Datasets >
I can see delete option for datasets which I don't know about. I am not trying to attempt the deletion but it seems critical.
Here is a screenshot:

Good catch. Maybe it is submissions made on competition you manage?
I think it is a problem with the listing. The actual deletion seems impossible:

I have checked and it looks like I am not the admin of this competition. Yes, looks like listing issue.

I think datasets of other people should not be listed (except maybe if you are organizer of a benchmark that use the dataset?)

This happens when a dataset is public. Otherwise everything is ok.
Just one small problem: if a dataset is public and I am not the owner, I can still make it private. Should this be changed?

OK, so it is not really a bug. The problem is that, once we have many users and many public datasets, this will clutter the resources interface for everybody. I guess there should be a tab "public datasets" or something like this.

if a dataset is public and I am not the owner, I can still make it private. Should this be changed?

When you try to make it private, it works? If so, yes, this should be changed.


How to use backitup with CIFS/SMB-Network-Share

Hi.
When using backitup to backup to a network share I get the error: Permission denied.
My guess was a permission issue with the docker-container so I added the the Container capability SYS_ADMIN to allow the mount-command.
But now I get this one: mount: /opt/iobroker/backups: cannot mount //server/Public/ioBroker-Backup/Standard read-only.
According to google-research this can be related to problems with the cifs-utils-Package.
So, just one question: Should a backup using backitup and a network-share just work or is it something which does need some kind of configuration using iobroker within docker?

maybe not fixing this particular issue but as a solution to the problem i would suggest to use the adapter to do local backup and then run a cronjob within you're host-instance to move the file from the docker-volume to your NAS or the location you want to store it

Yeah. After some research I got that mounting within a docker-container seems not be a common thing. So I wrote a service for the host which mounts the SMB-backup-location into the iobroker/backup-folder.
I tried to avoid this as I want my containers to be as host-independent as possible.

And it doesn't work on reboot because the docker-container is starting up to fast. So I'm going @fzzybllz way using a cronjob.
Looks like this is more reliable then a service which starts maybe/maybe not in time.


no conn, hlsvp or url_encoded_fmt_stream_map information found in video info

The broadcast has started, and can be viewed through the browser.
$ youtube-dl --verbose "https://www.youtube.com/watch?v=6beCycCN_Ao"
[debug] System config: [u'--prefer-free-formats']
[debug] User config: []
[debug] Command-line args: [u'--verbose', u'https://www.youtube.com/watch?v=6beCycCN_Ao']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2015.05.10
[debug] Python version 2.7.9 - Linux-4.0.1-300.fc22.x86_64-x86_64-with-fedora-22-Twenty_Two
[debug] exe versions: none
[debug] Proxy map: {}
[youtube] 6beCycCN_Ao: Downloading webpage
[youtube] 6beCycCN_Ao: Downloading video info webpage
[youtube] 6beCycCN_Ao: Extracting video information
ERROR: no conn, hlsvp or url_encoded_fmt_stream_map information found in video info; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/youtube_dl/extractor/youtube.py", line 882, in _real_extract
    raise ValueError('No stream_map present')  # caught below
ValueError: No stream_map present
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/youtube_dl/YoutubeDL.py", line 650, in extract_info
    ie_result = ie.extract(url)
  File "/usr/lib/python2.7/site-packages/youtube_dl/extractor/common.py", line 273, in extract
    return self._real_extract(url)
  File "/usr/lib/python2.7/site-packages/youtube_dl/extractor/youtube.py", line 1110, in _real_extract
    raise ExtractorError('no conn, hlsvp or url_encoded_fmt_stream_map information found in video info')
ExtractorError: no conn, hlsvp or url_encoded_fmt_stream_map information found in video info; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

I got the same error yesterday and I can download it today. Maybe it's a temporary server issue in youtube. Can you download it now?

Yes, although it's much less interesting now as I was hoping to use youtube-dl to stream it to my media player. Thanks for the review though.

You can use -o - to stream to media players via pipes. For example:
youtube-dl -o - "https://www.youtube.com/watch?v=6beCycCN_Ao" | vlc -

Note: vlc is my daily-use player. Parameters can be different for other players.

I meant streaming the live video. It's finished now, and ended up watching it in a web browser :/


feat(test-tooling): containers#pruneDockerResources() observability

Description
As a contributor I want to have a way to see what is the outcome of the docker resources pruning so that it is easier for me to debug infrastructure/hardware related CI failures that I encounter.
A good example of such issue is when the GitHub CI Action started failing because the disk was full with docker images that we created in the test cases.
It is particularly hard to debug these failures because the test runner will show a particular test failing and that failure of that test case will not be reproducible on any other machine unless that machine also has the disk full issue.
Acceptance Criteria

The pruning method can log it's own results for itself via a log level parameter
The pruning method also returns the outcome of the pruning process so that callers can either log that for themselves or pass it further up to their callers when applicable.

cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo @jagpreetsinghsasan

Is this for local tests or github's?


Error: init() got an unexpected keyword argument 'seed'

I run tools/dist_train.sh configs/cstr.py 4 and error:
File "tools/train.py", line 49, in
main()
File "tools/train.py", line 44, in main
runner = TrainRunner(train_cfg, inference_cfg, common_cfg)
File "tools/../vedastr/runners/train_runner.py", line 18, in init
train_cfg['data']['train'])
File "tools/../vedastr/runners/base.py", line 105, in _build_dataloader
dict(dataset=dataset))
File "tools/../vedastr/dataloaders/samplers/builder.py", line 7, in build_sampler
sampler = build_from_cfg(cfg, DISTSAMPLER, default_args)
File "tools/../vedastr/utils/common.py", line 13, in build_from_cfg
return obj_from_dict_registry(cfg, parent, default_args)
File "tools/../vedastr/utils/common.py", line 78, in obj_from_dict_registry
return obj_cls(**args)
File "tools/../vedastr/dataloaders/samplers/dist_balance_sampler.py", line 77, in init
super(BalanceSampler, self).init(dataset=dataset, **kwargs)
TypeError: init() got an unexpected keyword argument 'seed'
How to solve this problem? Thank in advance.

Hi, please use PyTorch whose version is larger than 1.6.0.  ( I will update the requirements. )

Thank you for your reply @ChaseMonsterAway . Besides that, can i ask you a question? I can train model in case insensetive by changing character and sensitive = True, right?


Backport:Global DNS: not able to setup alidns

backport https://github.com/rancher/rancher/issues/21305

Available in UI index 2.2.86

Tested with rancher v2.2.5-rc11 from July 10
This version can add alidns in Global DNS and add it successfully.