Revisit default bundling behavior

This is in response to the resolution in #20 and #89:

No plans to include bundling in the default template at this time. We will revisit in the future.

If you currently create a new ASP.NET Core application and you are not using an SPA-template (which uses Webpack for building), then you are in the unfortunate situation that the project appears to be using the bundling and minification feature yet that’s not what’s actually happening.
The following things are there:

A bundleconfig.json is in the project root that is configured to produce the site.min.css and the site.min.js files.
The wwwroot folder contains pre-built versions of those exact bundled files.
The _Layout.cshtml contains environment tag helpers that switch to the minified bundles on non-Development builds:<environment include="Development">
    <link rel="stylesheet" href="~/css/site.css" />
</environment>
<environment exclude="Development">
    <link rel="stylesheet" href="~/css/site.min.css" asp-append-version="true" />
</environment>

…

<environment include="Development">
    <script src="~/js/site.js" asp-append-version="true"></script>
</environment>
<environment exclude="Development">
    <script src="~/js/site.min.js" asp-append-version="true"></script>
</environment>

So the user is made to believe that bundles are being created and that for production builds, those minified versions will be used automatically. Since minified files are also nested in the solution explorer, users are unlikely to actually look inside the files to verify that they actually do contain the desired contents.
Yet, the problem is that with Visual Studio 2017, Visual Studio Code, or when running dotnet from the command line, there is by default nothing that is actually consuming that bundleconfig.json file to generate those files. So users will end up with the default bundle files which contain mostly nothing.
Instead, users are apparently expected to do one of the following three things:

Install the Bundler & Minifier VS extension to get the bundling done by Visual Studio
Add the BundlerMinifier.Core NuGet package to get the dotnet bundle command.
Add the BuildBundlerMinifier NuGet package to actually get a build task automatically added that will bundle the files automatically on every build.

By the indications mentioned above, the user is likely to expect this to work out of the box, just like everything in the templates already runs out of the box. Yet, they actively need to add a bundling method without being told to do so. The only thing that comes close to a hint is when you happen to open the bundleconfig.json in Visual Studio. Then, VS suggests you to look for “helpful extensions”, without actually clearly saying that this is in any way required. Not to mention that users that are not using VS are completely left in the dark.
So I would very strongly suggest that we actually do include the BuildBundlerMinifier package in the default templates, to make the bundling that is clearly configured and expected to work actually work. If we cannot do that since the package is not an “official” Microsoft package, then I would suggest to get rid of the bundling in the templates altogether.

We periodically close 'discussion' issues that have not been updated in a long period of time.
We apologize if this causes any inconvenience. We ask that if you are still encountering an issue, please log a new issue with updated information and we will investigate.


PR for #37

gofmt -s -w . solves a ton of issues automatically.

Looks like the project is at an A+. Shall this issue be closed?

Yeah, the rating is standardized and well supported now.
Closing this one!


CI: K8sPolicyTest: Zero exit code despite curl timeout

/home/jenkins/workspace/Cilium-PR-K8s-1.16-net-next/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:518
HTTP ingress connectivity to "<IP_ADDRESS>" from k8s3 host
Expected command: kubectl exec -n kube-system log-gatherer-jlcvv -- curl --path-as-is -s -D /dev/stderr --fail --connect-timeout 5 --max-time 20 <IP_ADDRESS> -w "time-> DNS: '%{time_namelookup}(%{remote_ip})', Connect: '%{time_connect}',Transfer '%{time_starttransfer}', total '%{time_total}'"
To have failed, but it was successful:
Exitcode: 0
Stdout:
 	 time-> DNS: '0.000019()', Connect: '0.000000',Transfer '0.000000', total '5.001828'
Stderr:

/home/jenkins/workspace/Cilium-PR-K8s-1.16-net-next/src/github.com/cilium/cilium/test/k8sT/Policies.go:1660

33a8f534_K8sPolicyTest_Multi-node_policy_test_validates_fromEntities_policies_with_remote-node_identity_disabled_Allows_from_all_hosts_with_cnp_fromEntities_host_policy.zip
Looks like it might be yet another instance of https://github.com/cilium/cilium/issues/12511, as the request was sent from k8s3 (outsideNode) to any of k8s{1,2}.

Looks like it might be yet another instance of #12511, as the request was sent from k8s3 (outsideNode) to any of k8s{1,2}.

Seems different to me: the request succeeded when it was expected to fail. #12511 is the other way around.
Given it's a test of the host policies, could be related to https://github.com/cilium/cilium/issues/15575.

This is actually a bit weird:
Expected command: kubectl exec -n kube-system log-gatherer-jlcvv -- curl --path-as-is -s -D /dev/stderr --fail --connect-timeout 5 --max-time 20 <IP_ADDRESS> -w "time-> DNS: '%{time_namelookup}(%{remote_ip})', Connect: '%{time_connect}',Transfer '%{time_starttransfer}', total '%{time_total}'"
To have failed, but it was successful:
Exitcode: 0
Stdout:
 	 time-> DNS: '0.000019()', Connect: '0.000000',Transfer '0.000000', total '5.001828'

So curl clearly failed because the total time for the curl command is just a bit more than the timeout (5s). Despite that, it returns a zero exit code and is therefore detected as "successful", an unexpected result.

Also happened for test K8sPolicyTest Namespaces policies Tests the same Policy in different namespaces (cf. https://github.com/cilium/cilium/issues/15758).

Also happened in https://jenkins.cilium.io/job/Cilium-PR-K8s-1.21-kernel-4.9/1435/testReport/junit/Suite-k8s-1/21/K8sPolicyTest_Basic_Test_checks_policies_with_named_ports/.
/home/jenkins/workspace/Cilium-PR-K8s-1.21-kernel-4.9/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:518
Unexpected connection from "app3-5d69599cdd-hx7nh" to 'http://<IP_ADDRESS>/private'
Expected command: kubectl exec -n<PHONE_NUMBER>50k8spolicytestbasictestchecksallkindofkubernetespoli app3-5d69599cdd-hx7nh -- curl --path-as-is -s -D /dev/stderr --fail --connect-timeout 5 --max-time 20 http://<IP_ADDRESS>/private -w "time-> DNS: '%{time_namelookup}(%{remote_ip})', Connect: '%{time_connect}',Transfer '%{time_starttransfer}', total '%{time_total}'"
To have failed, but it was successful:
Exitcode: 0
Stdout:

Stderr:

/home/jenkins/workspace/Cilium-PR-K8s-1.21-kernel-4.9/src/github.com/cilium/cilium/test/k8sT/Policies.go:483

Interestingly, that occurrence didn't even have the timing output from curl. But we can validate that we hit the timeout by checking timestamps for commands in test-output.log.

Haven't seen it in awhile, closing.


Security - tracing support refactoring

[ ] when tracing is enabled, security traces usernames logged in - this should be optional (may leak information to wrong audience)
[ ] tracing propagation has issues when security is in place - traces are disconnected probably due to wrong parent SpanContext being used
[ ] security client extension should auto-register similar to Tracing extension

Required by MP 2.2 as tracing propagation is part of the spec and it must work both when security is present and when it is not.

Related to #560

Use the same tracing for security in all integrations:

[x] Jersey
[x] WebServer
[ ] gRPC


Test issue.

Describe what scenario you think is uncovered by the existing examples / articles
A clear and concise description of the problem that you want explained.
Describe why existing examples / articles do not cover this case
Explain which examples / articles you have seen before making this request, and
why they did not help you with your problem.
Additional context
Add any other context or screenshots about the documentation request here.

This is a test issue.


High CPU and memory usage which eventually crashes docker.

Original issue #214673 described similar behavior as mine.
These vscode-server/bin processes seem to be infinitely spinning up until OOM.

Originally posted by @mliudev in https://github.com/microsoft/vscode/issues/214673#issuecomment-2164001700
devcontainer.json
// For format details, see https://aka.ms/devcontainer.json. For config options, see the
// README at: https://github.com/devcontainers/templates/tree/main/src/typescript-node
{
    "name": "Node.js & TypeScript",
    // Or use a Dockerfile or Docker Compose file.

Some more info is that there appears to be an infinite loop of port forwarding. Not sure what this port is being forwarded for:
devcontainer log
[18539 ms] Port forwarding connection from 52832 > 58319 > 58319 in the container.
[18539 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[18612 ms] Port forwarding 52832 > 58319 > 58319 stderr: Connection established
[18638 ms] Port forwarding connection from 52833 > 58319 > 58319 in the container.
[18639 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[18641 ms] Port forwarding connection from 52834 > 58319 > 58319 in the container.
[18641 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[18644 ms] Port forwarding connection from 52836 > 58319 > 58319 in the container.
[18644 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[18674 ms] Port forwarding connection from 52837 > 58319 > 58319 in the container.
[18674 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[18724 ms] Port forwarding 52833 > 58319 > 58319 stderr: Connection established
[18724 ms] Port forwarding 52834 > 58319 > 58319 stderr: Connection established
[18743 ms] Port forwarding 52836 > 58319 > 58319 stderr: Connection established
[18760 ms] Port forwarding 52837 > 58319 > 58319 stderr: Connection established
[18766 ms] Port forwarding connection from 52839 > 58319 > 58319 in the container.
[18767 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[18940 ms] Port forwarding 52839 > 58319 > 58319 stderr: Connection established
[18948 ms] Port forwarding connection from 52846 > 58319 > 58319 in the container.
[18948 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[19049 ms] Port forwarding 52846 > 58319 > 58319 stderr: Connection established
[19056 ms] Port forwarding connection from 52848 > 58319 > 58319 in the container.
[19056 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[19130 ms] Port forwarding 52848 > 58319 > 58319 stderr: Connection established
[19158 ms] Port forwarding connection from 52850 > 58319 > 58319 in the container.
[19158 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[19240 ms] Port forwarding 52850 > 58319 > 58319 stderr: Connection established
[19322 ms] Port forwarding connection from 52852 > 58319 > 58319 in the container.
[19322 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[19415 ms] Port forwarding 52852 > 58319 > 58319 stderr: Connection established
[19422 ms] Port forwarding connection from 52854 > 58319 > 58319 in the container.
[19423 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[19473 ms] Port forwarding 52854 > 58319 > 58319 stderr: Connection established
[19478 ms] Port forwarding connection from 52856 > 58319 > 58319 in the container.
[19478 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[19536 ms] Port forwarding 52856 > 58319 > 58319 stderr: Connection established
[19544 ms] Port forwarding connection from 52858 > 58319 > 58319 in the container.
[19544 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[19604 ms] Port forwarding 52858 > 58319 > 58319 stderr: Connection established
[19613 ms] Port forwarding connection from 52860 > 58319 > 58319 in the container.
[19613 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[19716 ms] Port forwarding 52860 > 58319 > 58319 stderr: Connection established
[19726 ms] Port forwarding connection from 52863 > 58319 > 58319 in the container.
[19726 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[19821 ms] Port forwarding 52863 > 58319 > 58319 stderr: Connection established
[19830 ms] Port forwarding connection from 52865 > 58319 > 58319 in the container.
[19830 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[19905 ms] Port forwarding 52865 > 58319 > 58319 stderr: Connection established
[19912 ms] Port forwarding connection from 52871 > 58319 > 58319 in the container.
[19913 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[20003 ms] Port forwarding 52871 > 58319 > 58319 stderr: Connection established
[20016 ms] Port forwarding connection from 52873 > 58319 > 58319 in the container.
[20016 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[20103 ms] Start: Run in container: cat /proc/1925/environ
[20127 ms] Port forwarding 52873 > 58319 > 58319 stderr: Connection established
[20138 ms] Port forwarding connection from 52875 > 58319 > 58319 in the container.
[20138 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[20188 ms] Port forwarding 52875 > 58319 > 58319 stderr: Connection established
[20196 ms] Port forwarding connection from 52877 > 58319 > 58319 in the container.
[20196 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[20245 ms] Port forwarding 52877 > 58319 > 58319 stderr: Connection established
[20252 ms] Port forwarding connection from 52879 > 58319 > 58319 in the container.
[20253 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[20303 ms] Port forwarding 52879 > 58319 > 58319 stderr: Connection established
[20310 ms] Port forwarding connection from 52881 > 58319 > 58319 in the container.
[20310 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[20375 ms] Port forwarding 52881 > 58319 > 58319 stderr: Connection established
[20383 ms] Port forwarding connection from 52883 > 58319 > 58319 in the container.
[20383 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[20484 ms] Port forwarding 52883 > 58319 > 58319 stderr: Connection established
[20492 ms] Port forwarding connection from 52885 > 58319 > 58319 in the container.
[20492 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[20546 ms] Port forwarding 52885 > 58319 > 58319 stderr: Connection established
[20552 ms] Port forwarding connection from 52887 > 58319 > 58319 in the container.
[20553 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[20608 ms] Port forwarding 52887 > 58319 > 58319 stderr: Connection established
[20614 ms] Port forwarding connection from 52889 > 58319 > 58319 in the container.
[20614 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[20669 ms] Port forwarding 52889 > 58319 > 58319 stderr: Connection established
[20676 ms] Port forwarding connection from 52891 > 58319 > 58319 in the container.
[20677 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[20776 ms] Port forwarding 52891 > 58319 > 58319 stderr: Connection established
[20783 ms] Port forwarding connection from 52893 > 58319 > 58319 in the container.
[20784 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[20858 ms] Port forwarding 52893 > 58319 > 58319 stderr: Connection established
[20866 ms] Port forwarding connection from 52899 > 58319 > 58319 in the container.
[20866 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[20943 ms] Port forwarding 52899 > 58319 > 58319 stderr: Connection established
[20957 ms] Port forwarding connection from 52901 > 58319 > 58319 in the container.
[20958 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[21015 ms] Port forwarding 52901 > 58319 > 58319 stderr: Connection established
[21022 ms] Port forwarding connection from 52903 > 58319 > 58319 in the container.
[21022 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[21168 ms] Port forwarding 52903 > 58319 > 58319 stderr: Connection established
[21177 ms] Port forwarding connection from 52905 > 58319 > 58319 in the container.
[21178 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[21274 ms] Port forwarding 52905 > 58319 > 58319 stderr: Connection established
[21282 ms] Port forwarding connection from 52907 > 58319 > 58319 in the container.
[21282 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[21358 ms] Port forwarding 52907 > 58319 > 58319 stderr: Connection established
[21377 ms] Port forwarding connection from 52909 > 58319 > 58319 in the container.
[21377 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[21442 ms] Port forwarding 52909 > 58319 > 58319 stderr: Connection established
[21452 ms] Port forwarding connection from 52911 > 58319 > 58319 in the container.
[21452 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[21597 ms] Port forwarding 52911 > 58319 > 58319 stderr: Connection established
[21608 ms] Port forwarding connection from 52913 > 58319 > 58319 in the container.
[21608 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[21706 ms] Port forwarding 52913 > 58319 > 58319 stderr: Connection established
[21716 ms] Port forwarding connection from 52916 > 58319 > 58319 in the container.
[21716 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[21769 ms] Port forwarding 52916 > 58319 > 58319 stderr: Connection established
[21801 ms] Port forwarding connection from 52918 > 58319 > 58319 in the container.
[21801 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[21903 ms] Port forwarding 52918 > 58319 > 58319 stderr: Connection established
[21911 ms] Port forwarding connection from 52924 > 58319 > 58319 in the container.
[21911 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[21988 ms] Port forwarding 52924 > 58319 > 58319 stderr: Connection established
[21995 ms] Port forwarding connection from 52926 > 58319 > 58319 in the container.
[21996 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[22063 ms] Port forwarding 52926 > 58319 > 58319 stderr: Connection established
[22075 ms] Port forwarding connection from 52928 > 58319 > 58319 in the container.
[22075 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[22145 ms] Port forwarding 52928 > 58319 > 58319 stderr: Connection established
[22155 ms] Port forwarding connection from 52930 > 58319 > 58319 in the container.
[22155 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[22253 ms] Port forwarding 52930 > 58319 > 58319 stderr: Connection established
[22333 ms] Port forwarding connection from 52932 > 58319 > 58319 in the container.
[22333 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[22417 ms] Port forwarding 52932 > 58319 > 58319 stderr: Connection established
[22422 ms] Port forwarding connection from 52934 > 58319 > 58319 in the container.
[22423 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[22514 ms] Port forwarding 52934 > 58319 > 58319 stderr: Connection established
[22523 ms] Port forwarding connection from 52936 > 58319 > 58319 in the container.
[22523 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[22634 ms] Port forwarding 52936 > 58319 > 58319 stderr: Connection established
[22639 ms] Port forwarding connection from 52938 > 58319 > 58319 in the container.
[22640 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[22701 ms] Port forwarding 52938 > 58319 > 58319 stderr: Connection established
[22707 ms] Port forwarding connection from 52940 > 58319 > 58319 in the container.
[22708 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[22765 ms] Port forwarding 52940 > 58319 > 58319 stderr: Connection established
[22773 ms] Port forwarding connection from 52942 > 58319 > 58319 in the container.
[22773 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[22856 ms] Port forwarding 52942 > 58319 > 58319 stderr: Connection established
[22907 ms] Port forwarding connection from 52948 > 58319 > 58319 in the container.
[22908 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[22973 ms] Port forwarding 52948 > 58319 > 58319 stderr: Connection established
[22979 ms] Port forwarding connection from 52950 > 58319 > 58319 in the container.
[22979 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[23034 ms] Port forwarding 52950 > 58319 > 58319 stderr: Connection established
[23043 ms] Port forwarding connection from 52952 > 58319 > 58319 in the container.
[23043 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e
[23146 ms] Port forwarding 52952 > 58319 > 58319 stderr: Connection established
[23157 ms] Port forwarding connection from 52954 > 58319 > 58319 in the container.
[23157 ms] Start: Run in container: /root/.vscode-server/bin/4849ca9bdf9666755eb463db297b69e5385090e3/node -e

Not sure how this gets triggered, but removing "runArgs": ["--network=host"], from the config probably works around it. Could you try that?
Does the Ports view show a port being forwarded?
Could you append the full log?


improve wallet page

Title: [Persona name] should (not) be able to [action]
Currently:
[What happens now in the regression]
Expected:
nominalizer balance data
STEPS TO REPRODUCE:
[If needed, add steps to reproduce]
REFERENCE:
[Link or attach screenshot(s) to story if relevant]
Possible fixes:
(If you can, link to the line of code that might be responsible for the problem)
Related issues

Related Merge Requests

/label ~bug

Moved it here:
https://github.com/KomodoPlatform/dicoapp-e/issues/15


[Codegen] Add lane distribution for scf.forall

This adds a new type of mapping id, iree_gpu.lane_id, and an op to distribute forall ops mapping to it. Lane mapped forall ops require that the thread count exactly matches with the subgroup count, so this is added downstream due to incompatibility with upstream lowerings, however this should be upstreamed in the future.

I am probably going to be rewriting some of this upstream... Why do we need a separate op here. I think the forall op is meant to map to any device mapping attribute right?
I know we stay away from GPU dialect, but we should just build the thread id/land id support in there.

I think the device mapping stuff upstream trying to combine relative mappings and x/y/z direct mappings is written in a very strange way right now so I wanted to avoid propagating it. This patch mainly is just adding the attribute and a way to lower an scf.forall with the mapping. I can send the mapping upstream if you want, but I figured it would be easier to do after your work.
 The reason for the transform op is that the upstream logic for resolving the scf.forall ops is hard coded for warps/threads right now.

Ill need some help unwinding this when I get to the upstream changes.

Yeah that can be squarely in my court.


Fix subflow module with internal subflow

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Proposed changes

Installing SUBFLOW module that contains internal subflows causes following error on deploy of a flow containing the SUBFLOW instance:
TypeError: Cannot read property 'configs' of undefined
    at new Subflow (/Users/nisiyama/src/Curry/Git/node-red-hitachi/packages/nod\
e_modules/@node-red/runtime/lib/flows/Subflow.js:79:24)
    at Object.createSubflow [as create] (/Users/nisiyama/src/Curry/Git/node-red\
-hitachi/packages/node_modules/@node-red/runtime/lib/flows/Subflow.js:544:12)
    at SubflowModule.start (/Users/nisiyama/src/Curry/Git/node-red-hitachi/pack\
ages/node_modules/@node-red/runtime/lib/flows/Flow.js:216:55)
    at SubflowModule.start (/Users/nisiyama/src/Curry/Git/node-red-hitachi/pack\
ages/node_modules/@node-red/runtime/lib/flows/Subflow.js:313:15)
    at Object.createNode (/Users/nisiyama/src/Curry/Git/node-red-hitachi/packag\
es/node_modules/@node-red/runtime/lib/flows/util.js:130:21)
    at Flow.start (/Users/nisiyama/src/Curry/Git/node-red-hitachi/packages/node\
_modules/@node-red/runtime/lib/flows/Flow.js:205:48)
    at start (/Users/nisiyama/src/Curry/Git/node-red-hitachi/packages/node_modu\
les/@node-red/runtime/lib/flows/index.js:371:33)

This seems to be caused by missing information of internal subflows.
This PR try to fix this issue.
Example subflow module:
subflow.tar.gz
Checklist

[x] I have read the contribution guidelines
[ ] For non-bugfix PRs, I have discussed this change on the forum/slack team.
[x] I have run grunt to verify the unit tests pass
[ ] I have added suitable unit tests to cover the new/changed functionality

Coverage decreased (-0.07%) to 67.304% when pulling 7631a2d62b35e39c00156121d96d97897b8e5eb2 on node-red-hitachi:fix-subflow-start into 0e02d03d9a87aa2fb47f7dd8623ce037b2199271 on node-red:master.

Thanks for this.
I have investigated the issue to understand what was happening and have identified a different fix - https://github.com/node-red/node-red/commit/7df1a03b4b348fdbbba2336d7cfadda2a2485f76#diff-c8984c95b8dfc2071cea5ea7527a067bc5d0f3a64168839143bad011f3e9766d
The createNode function in lib/flows/util.js already does the work to parse the subflow module configuration. However it was not including the internal subflows on the subflow definition passed to createModuleInstance. So rather than re-parse the flow as your change proposes, this uses the already-parsed flow.
The commit also fixes handling of credentials in subflow modules - an issue that was hidden in my testing but I found when I imported your subflow module example.


get output do not select merge plan

it selects the last plan as default. It should consider the merged one by default.

should be fixed with the new version


using jmm server via webbrowser

Hello,
I installed JMM server, started it using Mysql.
Jmm Desktop work without problem, but PlexPlugin isn't (telling about bad user - im using Default).
I narrow problem to point where I cannot access JMMserver from http://ip:8111/jmmserver not http://<IP_ADDRESS>:8111/jmmserver nor /video/jmm they give Error 404 (page not found)
I was looking for documentation for this but I cannot found anything. Server is on Win7 x64 - so its not lookback restriction from win8/8.1.
http://localhost:8111/JMMServerBinary?singleWsdl did work, but Im not sure is it the right path or not.

From Source I see someone did comment out that /jmmserver,
Is there any docs for /JmmServerREST ?

https://github.com/japanesemediamanager/jmmserver-webui

The initial issue wasn't about jmmwebui, I will close it as it was more of the issue with legacy api than anything else, as the legacy api could be used in browser anyway.


Example code gives json request parse error

As the old voice_request is marked deprecated, I'm using a text_request to send audio data as instructed here, using a wav file (Unsigned 8 bit, or Signed 16 bit Little Endian, Rate 16000 Hz). However, this gives me the following result:
{
  "error": {
    "code": "002",
    "errorId": "ab6473fe-a57a-49ed-8a08-21a58570be78",
    "message": "json request parse error"
  }
}

What am I doing wrong?

Just forgot about voice request. It won't work for you.

The README says it is possible to do speech recognition through this python api. How do I do that then?

@rokusottervanger No way. This api has been removed.

Apparently, using Google Cloud Speech API is the way to go now. Maybe this should be updated in the documentation...


Pelorus-Operator 0.0.6 with fresh patches and updated release scripts

This change includes Pelorus-Operator 0.0.6 which refreshes patches, updated linting of the charts so they now must match the pelorus-operator charts.
Also it consists of change where failing patches were allowing to proceed with pelorus-operator creation.
To create release it's enough to type: make release
The RC releases are still two step as the create_pelorus_operator must have explicit rc version to be passed for the operator rc version.

Can you provide a operator test image for this PR?

/lgtm

/test 4.11-e2e-openshift


feat(protocol-designer): mix tools advanced settings and mix batch edit

closes AUTH-930 AUTH-926
Overview
Adds advanced settings for the mix tools and wires up the batch edit mix tools.
Test Plan and Hands on Testing
Create a protocol and make a mix step, check out page 2 of the mix step and try each of the advanced settings to make sure it works as expected
then make another mix step
finally, command + click on both mix steps and see the batch edit mix tools and make sure each setting works as expected
Changelog

adds advanced settings fields to the mix tools page 2
wires up the batch edit mix tools

Risk assessment
low

this looks good and works well. there is a bug when selecting multiple selected steps' respective overflows but we can address this in a followup

@ncdiehl11 oof ya good catch!! i can make a ticket in RQA


Question about the adaptive attack ?

Hey, Ziyi.
We proposed the IT-Defense recently, which utilized the network’s property (such as permutation invariant of input point cloud for Pointnet) to defend attacks. But we don't know how to design an adaptive attack for our defense, could you give any suggestions?
Best wishes!
Jinlai

Hi! Maybe we can go to the issue session of your repo and chat using Chinese. Do you think that works?

That's ok!
Thanks.

或者也可以加我微信聊，我的微信是cuge1995。
我后面的Mesh Attack也很大程度上受益于你开源的baseline，超级感谢！


CodeQuality Sonar Widget Blanks out after some time

Hi Recently, we came across this issue where a configured sonar widget on the dashboard keeps blanking out after the start of a new cron job starts for getting the data for the widgets. Though in the database we can see that the entry for the same is there but for some reason it does not diplay the details on the UI and displays, no data found and everytime after some while we have to go and reconfigure the widget.

At looking at the DB states we found out that the _id element of the collector_items documents for the Sonar Collector keeps changing which possibly causes this issue. So there might be some issue in the collector code for Sonar.


Feature/cu nkd4h2 UI improvements

Texture are not clamped to border causing a repetition of texture. -> Replaced all of them
Canvas Displayer Animation not working correctly with the UI Update. -> Fixed
Button texture isn't the correct one for Menus. -> Replaced to a new one. (Level 1 Scene -> Skill Button/ButtonPressed needs to be changed to take the new Textures from Textures\UI\Skill Widgets\Buttons).

Task linked: CU-nkd4h2 UI Improvements


Anonymous contribution

This PR is actually contributed from another source that does not have access to git. This was submitted via email.
Code looks good, so adding it as a PR.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Multi-stage builds?

Docker now supports multi-stage builds to avoid putting build-only intermediate files and executables in the final output image. Might be worth investigating how that can help here?

Speaking of which, I'm trying to do multi-stage:
FROM racket/racket:8.8-full AS racket

FROM ghcr.io/stefan-hoeck/idris2-pack:nightly-230330 AS idris2-racket
ONBUILD COPY --from=racket /usr/bin/raco /usr/bin/raco
ONBUILD COPY --from=racket /usr/bin/racket /usr/bin/racket
ONBUILD COPY --from=racket /usr/share/racket /usr/share/racket
ONBUILD COPY --from=racket /usr/lib/racket /usr/lib/racket

but I get this error with raco:
RUN pack --cg racket build function.ipkg
/usr/bin/raco: Unrecognized command: exe

apt works just fine, so I'm wondering which files I missed COPYing.


Remove premium checks and their variables

Remove the premium checks as we already have the Premium containers and code in place.
@stefanotorresi @lee-martin Is this the good moment to do this?

Hmm, I'd like to have the premium version running in the demo environment first.

Hmm, I'd like to have the premium version running in the demo environment first.

Are we sure we want to have the Premium version on demo? It would expose already all the code

Hmm, I'd like to have the premium version running in the demo environment first.

Are we sure we want to have the Premium version on demo? It would expose already all the code

Good question, let me ask upwards. I would personally go for it regardless, but maybe we need to remove the implementation from the catalog.

All right, we can keep the demo as it is. No worries. Go forward with the latest list of premium checks we got from Diego.

@stefanotorresi New changes based on the list provided by @diegoakechi done


Deployment Template VM Size is not available in most regions

Tried deploying to North Europe, US East, West Europe but VM wasn't available.
Got UK South to work (which is the region the book used)

Got the same. Workaround for me was to deploy the pentest VM to japan and the exercises to eastasia. Do not forget to edit the exercises scripts before running them if you do that (location = "eastasia").

Is this still an issue? I just checked in my own subscription in the central US region and the VM size was available.

No its no longer an issue for me given I used Japan.


A question about reconstruction.py

During the image reconstruction phase, I encountered such an error, have you ever encountered it？
Traceback (most recent call last):
File "/mnt/sda/songzengyu/code/MindDiffuser-main/Image reconstruction/Reconstruction_new.py", line 417, in
main()
File "/mnt/sda/songzengyu/code/MindDiffuser-main/Image reconstruction/Reconstruction_new.py", line 392, in main
samples = sampler.decode(z_enc, c, 35, unconditional_guidance_scale=5.0, unconditional_conditioning=uc, )
File "/home/songzengyu/.conda/envs/ldm/lib/python3.8/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "/mnt/sda/songzengyu/code/stable-diffusion-main/ldm/models/diffusion/ddim.py", line 238, in decode
x_dec, _ = self.p_sample_ddim(x_dec, cond, ts, index=index, use_original_steps=use_original_steps,
File "/home/songzengyu/.conda/envs/ldm/lib/python3.8/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "/mnt/sda/songzengyu/code/stable-diffusion-main/ldm/models/diffusion/ddim.py", line 177, in p_sample_ddim
e_t_uncond, e_t = self.model.apply_model(x_in, t_in, c_in).chunk(2)
File "/mnt/sda/songzengyu/code/stable-diffusion-main/ldm/models/diffusion/ddpm.py", line 987, in apply_model
x_recon = self.model(x_noisy, t, **cond)
File "/home/songzengyu/.conda/envs/ldm/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/home/songzengyu/.conda/envs/ldm/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl
return forward_call(*args, **kwargs)
File "/mnt/sda/songzengyu/code/stable-diffusion-main/ldm/models/diffusion/ddpm.py", line 1410, in forward
out = self.diffusion_model(x, t, context=cc)
File "/home/songzengyu/.conda/envs/ldm/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/home/songzengyu/.conda/envs/ldm/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl
return forward_call(*args, **kwargs)
File "/mnt/sda/songzengyu/code/stable-diffusion-main/ldm/modules/diffusionmodules/openaimodel.py", line 732, in forward
h = module(h, emb, context)
File "/home/songzengyu/.conda/envs/ldm/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/home/songzengyu/.conda/envs/ldm/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl
return forward_call(*args, **kwargs)
File "/mnt/sda/songzengyu/code/stable-diffusion-main/ldm/modules/diffusionmodules/openaimodel.py", line 85, in forward
x = layer(x, context)
File "/home/songzengyu/.conda/envs/ldm/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/home/songzengyu/.conda/envs/ldm/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl
return forward_call(*args, **kwargs)
File "/mnt/sda/songzengyu/code/stable-diffusion-main/ldm/modules/attention.py", line 258, in forward
x = block(x, context=context)
File "/home/songzengyu/.conda/envs/ldm/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/home/songzengyu/.conda/envs/ldm/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl
return forward_call(*args, **kwargs)
File "/mnt/sda/songzengyu/code/stable-diffusion-main/ldm/modules/attention.py", line 209, in forward
return checkpoint(self._forward, (x, context), self.parameters(), self.checkpoint)
File "/mnt/sda/songzengyu/code/stable-diffusion-main/ldm/modules/diffusionmodules/util.py", line 114, in checkpoint
return CheckpointFunction.apply(func, len(inputs), *args)
File "/home/songzengyu/.conda/envs/ldm/lib/python3.8/site-packages/torch/autograd/function.py", line 553, in apply
return super().apply(*args, **kwargs)  # type: ignore[misc]
File "/mnt/sda/songzengyu/code/stable-diffusion-main/ldm/modules/diffusionmodules/util.py", line 127, in forward
output_tensors = ctx.run_function(*ctx.input_tensors)
File "/mnt/sda/songzengyu/code/stable-diffusion-main/ldm/modules/attention.py", line 213, in _forward
x = self.attn2(self.norm2(x), context=context) + x
File "/home/songzengyu/.conda/envs/ldm/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/home/songzengyu/.conda/envs/ldm/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl
return forward_call(*args, **kwargs)
File "/mnt/sda/songzengyu/code/stable-diffusion-main/ldm/modules/attention.py", line 180, in forward
sim = einsum('b i d, b j d -> b i j', q, k) * self.scale
File "/home/songzengyu/.conda/envs/ldm/lib/python3.8/site-packages/torch/functional.py", line 380, in einsum
return _VF.einsum(equation, operands)  # type: ignore[attr-defined]
RuntimeError: einsum(): subscript b has size 48 for operand 1 which does not broadcast with previously seen size 80

I have not encountered this issue before. From the error message you provided, it seems that there is a problem with the input feature dimensions on line 392 of the Reconstruction_new.py file. What are the dimensions of the input 'z_enc' and 'c'?

Their dimension is here,zenc[5,4,64,64],c[5,15,768]。Because I was told that cuda memory was insufficient when 982 test data were loaded, I chose 5 sets of data

Our model reconstructs images one by one and cannot process in parallel; therefore, the dimensions of zenc and c should be [1, 4, 64, 64] and [1, 15, 768] respectively. Try reconstructing just one image to see if the error still occurs.

Ok, I see. Thank you for your reply. I'll have a try


feat(verification): improve transient error handling

Addresses (part of) #1640
This improves the handling of transient Kubernetes API errors which may occur during the verification step of a Stage's current Freight.
It does this by selectively returning errors which should be retried, causing the reconciler to not leave the Verifying phase and allowing it to retry the action it performed on the next reconciliation attempt.
To allow the reconciler to distinguish a creation error from a failed attempt to retrieve results, closer inspection is performed on the existence of an AnalysisRun reference in the VerificationInfo.

This LGTM after merge conflicts are resolved.
I may be PR'ing something similar for Promotions shortly.

Has been rebased.


runner: Fix build and use ErrorPrinter

Commit c822dc13 broke the 'runner' crate due to changing the API in
gml::front for error handling and instruction -> source location
conversion.
This commit just copies the new usage from the 'playground' crate.
'cargo build' followed by 'cargo run' works as expected, and prints the
output of the built-in test script. Changing the script to produce a
syntax error or runtime error (I did division by zero) prints out the
correct error message with a line number.

Thanks for catching this! I actually fixed this locally a few days ago and just haven't pushed yet... didn't realize anyone was watching. :)

I keep telling myself I'm going to actually learn Rust so I can contribute :)

I do hope with the next push to have the engine and gml-meta crates in a state where people can implement GML APIs without getting blocked on infrastructure work everywhere. I guess that ought to include a README/docs/CI/etc. as well!

Looking forward to it! Please also consider adding a LICENSE!


Compinit with zsh, zplug from Homebrew in multi-user setup

Type:

[x] Bug
[ ] Enhancement
[ ] Feature Request
[x] Question

zplug --version: 2.4.1
zsh --version: 5.3.1
uname -a: Darwin Tarkin-2.local 16.6.0 Darwin Kernel Version 16.6.0: Fri Apr 14 16:21:16 PDT 2017; root:xnu-3789.60.24~6/RELEASE_X86_64 x86_64

Minimal zshrc (with less than 30 lines)
Create a minimal reproducing set of configurations for this issue. Please remove all unnecessary parts!
source ~/.zplug/init.zsh

if zplug check || zplug install; then
  zplug load --verbose
fi

Step to reproduce

Install zsh and (optionally) zplug via Homebrew.
You need to be on a Mac with multiple user accounts (for example a work and a personal account).
Launch zsh. zplug will load and run compinit without the -u flag, causing an insecure directories warning to show -- always.

Description
In the above setup, I can't find a way to not have compinit yell at me for insecure directories. If you run Homebrew you have to set the owner of at least some directories under /user/local to one of your two accounts or potentially to a third account that's used exclusively for Homebrew operations. In this case whenever you're launching zsh on an account other than the "Homebrew owner" account, compinit will complain about insecure directories. I've seen a PR that tries to address this for when you are in working with sudo (#396).
Do you have a recommended approach for addressing this issue? Otherwise, could we add some kind of override that, when active, will always run compinit -u?
Thanks!

@felixjung I hit this as well on one of my machines. To fix it, its pretty simple. You need to make the zsh directories non-writable.
Run compaudit in a shell. It will list out the offending directories. For me I had to run the following for 2 directories:
chmod g-w /usr/local/share/zsh/site-functions
chmod g-w /usr/local/share/zsh

Thanks @jsmestad. I'm luckily no longer running two users on one machine 😅 Not sure if this would have also worked in my case.

compinit will gripe under two conditions:

the current user OR root doesn't own the files
the files are group writable

This means in a multi-user setup:

the user that owns files in /usr/local will be fine (assuming the files are not group writable)
the user that doesn't own the files will never be fine because the files would need to be owned by root and brew will not allow that

So we really need a way to pass -i/-u to fix this issue for secondary accounts. As it currently is it seems zplug will always gripe on secondary users if using brew to install zsh.

I ran into this issue too, (using Homebrew with multi-user directory permissions) took me a while to figure out what was causing it. Ran ag compinit on all relevant directories to locate the line that was invoking compinit.
For anyone else with this problem you need to make the following change to /usr/local/opt/zplug/base/core/load.zsh
https://github.com/zplug/zplug/blob/fdc2bf46a6cc29430b947362f20d3a643edc0f3a/base/core/load.zsh#L34
diff --git a/load.zsh b/load.zsh
--- a/load.zsh
+++ b/load.zsh
@@ -1,34 +1,34 @@
-compinit -d "$ZPLUG_HOME/zcompdump"
+compinit -u -d "$ZPLUG_HOME/zcompdump"

What is the implication of applying the -u fix as 2 posts above? That fixes it for me.
Without a fix, whenever I log in, I always get prompted with 'y/n' and if I type a command without answering it, obviously the first letter gets consumed and gets answered as 'n' unless the first letter was 'y' causing all the file completions to fail in that session.


Unable to import in "modules" mode

Hello,
I'm starting with vite but I'm unable to import @mojs/core
I investigate a bit and here's what I found:
Vite seems to look for the package.json module field, but after looking for it inside the node_modules folder, I can't find it

If I look inside the repo, that file is inside ./src/mojs.babel.js while only dist is published to npm

Thanks!

Hi @Armaldio,
Thanks for opening the issue.
As of today, there is no ESM build available inside the dist folder, only UMD.
This field is just here to "prepare" the next release, where we will provide an ESM version too.
I guess the only way to fix right now it to remove it.
Let me check and I get back to you as soon as possible.
Thanks! :wink:

Hi @Armaldio,
I just published a new version on NPM.
You should be able to use it and get no errors, let me know if it's not the case.
Happy coding with mojs! :tada:

If works fine, many thanks!


python310Packages.denonavr: 0.11.1 -> 0.11.2

Changelog: https://github.com/ol-iver/denonavr/releases/tag/0.11.2
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 223158 run on x86_64-linux 1

3 packages built:

home-assistant-component-tests.denonavr
python310Packages.denonavr
python311Packages.denonavr


deconz component not update states in 0.73

Home Assistant release with the issue: 0.73

Last working Home Assistant release (if known): 0.72.1
Operating environment (Hass.io/Docker/Windows/etc.): Hass.io

Component/platform: https://www.home-assistant.io/components/deconz/

Description of problem:
The entities does not reflect the state and i can't turn the entities off for example lights.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

Traceback (if applicable):

Additional information:
Here is the debug output :
2018-07-05 20:48:48 DEBUG (MainThread) [pydeconz.websocket] Websocket starting
2018-07-05 20:48:48 ERROR (MainThread) [pydeconz.websocket] Unexpected error None
2018-07-05 20:48:48 DEBUG (MainThread) [pydeconz.websocket] Websocket starting
2018-07-05 20:48:48 DEBUG (MainThread) [pydeconz.websocket] Reconnecting to deCONZ in 15.

We've done some initial testing and for some reason the web socket can't connect to deconz. Donnib have tried this from two different machines with same issue. I've tried it native and in docker on my Mac, without any issue so far.

I have the same issue with 0.72.1 as well btw, does throw quite a lot of exceptions all over anyway
Sorry, don't have much time currently to dive into it, maybe on Sunday-eve I will find some time.

@mathos77 that's interesting because in my tests the problem goes a way with 0.72.1 and i have tried many times.

@mathos77 are you running hassio?

This at least rules out any issue with the change in web socket implementation

I got the problem both with deConz on 2.05.21 and the latest 2.05.31 so it doesn't seem to be the problem with incompatibility with deConz, it's something in HASS/deconz component that causes this.

I actually have a different issue.
2018-07-06 07:41:41 ERROR (MainThread) [homeassistant.core] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/src/app/homeassistant/data_entry_flow.py", line 68, in async_init
    return await self._async_handle_step(flow, step, data)
  File "/usr/src/app/homeassistant/data_entry_flow.py", line 100, in _async_handle_step
    result = await getattr(flow, method)(user_input)
  File "/usr/src/app/homeassistant/components/deconz/config_flow.py", line 169, in async_step_import
    title='deCONZ-' + self.deconz_config[CONF_BRIDGEID],
KeyError: 'bridgeid'

Never changed the config, since I updated the container, was there a change in the config section, as it currently simply looks like:

@mathos77 that is solved in 0.73. It was a small misstake from my part.

@mathos77 i was about to ask you if you were sure it wasn't a different issue, good to know

@Kane610 i have some time today until 15 if you need more of my help

@donnib in your non hassio docker, if you could try to get more information from the error would be great!
It is this if that fails https://github.com/Kane610/deconz/blob/603c1c347e1e1ae24830c97db0fd14036ab7526f/pydeconz/websocket.py#L57
So it travels down to the https://github.com/Kane610/deconz/blob/603c1c347e1e1ae24830c97db0fd14036ab7526f/pydeconz/websocket.py#L64 and breaks
async with self.session.ws_connect(url) as ws:
self.state = STATE_RUNNING
async for msg in ws:
if msg.type == aiohttp.WSMsgType.TEXT:

I just created a new issue before I saw this one:
https://github.com/home-assistant/home-assistant/issues/15337
I am running hassbian though. But I suspect the root cause could be the same.

@ACrazyConcept it's the same, doesn't matter what architecture or where you run HASS, have spent quite some time with @Kane610 to try figuring out the problem but were not able too. At the time i was the only one having this issue. @Kane610 could not reproduce this in his setup. I suspect more people will come with this issue. You may close the other issue ?

@ACrazyConcept @mathos77 are you running deconz on a pi or x86?

My current investigation points to there being a difference between running deCONZ on host and inside of a container. Where it works with the container

@Kane610 hi it is me Sand from the discord chat whose pydeconz you fixed ;)

Great! So I know you're running deconz without docker. My hypothesis still holds up

Hi @Kane610 , I am running docker natively on the pi. Never got the Raspbee to properly work in a container.
Yet, the API should not be affected right.....perhaps....I know what it is, did you change the WebServer port detection ? I am running it on a different WS port than the default.

@mathos77 there is no change in management of ws port, it is still retrieved from deconz.
I am pretty certain it actually is a difference in system packages that is the reason behind this issue.
It would be great if you'd try just running deconz in docker with the same config path as your current deconz and see if it works with web sockets. Regardless if it actually connects to raspbee or not

okay, I will do that, just tomorrow, I am currently not @home

Absolutely

@Kane610 I do not have the issue with 0.73.0 (just updated the container, and deCONZ is just running on the pi (native)

You just broke my hypothesis :)
What os is the pi running?

Rasbian, just a regular pi install

I encountered this issue on hass.io upgrading from 0.72.0 to 0.73.0.
Deconz is 2.05.23 running natively on Raspbian (I'm running the SD card image provided by Dresden Elektronik). FWIW I'm using a Raspbee.
Fortunately I have nightly snapshots and rolling back to 0.72.0 resolved the problem.

@aherbjornsen would you mind going over to using deconz in a docker container?

@Kane610  That is not an ideal solution. I'm running deconz on the Raspbian image supplied by Dresden Elektronik, and I feel that this is something that should work with hass.io. I'm very comfortable with it and it has been running extremely stable for me since last November.

Allright @xhemp
This is my docker compose, in the volumes section you can see how to reuse your current deconz config and database
version: '2'
services:
deconz:
container_name: deconz
image: marthoc/deconz
restart: unless-stopped
network_mode: host
devices:
- /dev/ttyUSB0
environment:
- DECONZ_WEB_PORT=
- DECONZ_WS_PORT=
- DEBUG_INFO=1
- DEBUG_APS=0
- DEBUG_ZCL=0
- DEBUG_ZDP=0
- DEBUG_OTAU=0
volumes:
- /home//.local/share/dresden-elektronik/deCONZ:/root/.local/share/dresden-elektronik/deCONZ

Thanks @Kane610 .
It works well running with docker on 0.73:
2018-07-08 16:16:53 DEBUG (MainThread) [pydeconz.websocket] Websocket starting
2018-07-08 16:16:53 DEBUG (MainThread) [pydeconz.websocket] Websocket running

I am not sure if something changed between 0.73 and 0.73.1 but I was able to use deCONZ natively (no docker) on 0.73.1.

Yes that sounds weird indeed

Very!
For the sake of it, I tried downgrading to 0.73 (not 0.73.1) to test and it worked as well so I have no idea why it didn't work before on 0.73, though.

I've created an issue with deCONZ developers.
https://github.com/dresden-elektronik/deconz-rest-plugin/issues/684

So it seems that old system dependencies is the issue here. You guys need to use a newer QT5, 5.7 to be more precise.

For me Deconz is not working in 0.73.1 (hassio). I'm running Deconz on a separate PI (not docker). Deconz version 2.05.23 and use a Raspbee. Is there already a known fix? I'm downgrading my hassio to 0.72.1 for the moment.

@try2fly you need to upgrade your raspberry to use debian stretch or similar modern release so you can fill the requirement I posted above

@Kane610 Ok thanks, I'm running jessie on the Pi. I'll first try to update this. If it still fails then I'll update to stretch.

@Kane610 Thanks for the effort to solve this.
I upgraded my Deconz Pi from Jessie to Stretch and 0.73.1 is running fine now.

Great to hear @aherbjornsen

I'm upgrading to stretch at the moment, in the hope that it solves the problem. However, if it does - I suggest to update pydeconz to choose between aiohttp and legacy websocket implementation based on the version of the underlying software, to avoid forcing users to upgrade their distros.

Release of pydeconz doesn't matter since there is no changes related to this issue after 39.
QT5.71 should be enough (https://github.com/dresden-elektronik/deconz-rest-plugin/issues/684)
Since you already run home assistant in docker wouldn't it be easier to go over to the deConz container?

@Kane610 aha - the qt5 issue is with the deConz installation, not HA/pydeconz?
I have two rpi's running deConz, each with a Conbee stick on the opposite ends of my house both running Strech / QT5.7.1 / 2.05.32.
(Since pydeconz in HA only can handle 1 instance, I'm getting sensor values using REST from the other)

@jkinghed yes it is system dependencies to deConz that is the issue here.

@Kane610 I have too many rpi's, it turns out.. Was looking at the wrong one, but after upgrading the correct rpi to Stretch I can confirm it works OK in HA.
Thanks for your input and assistance!

Great! Thanks for double checking @jkinghed

@Kane610 I fixed the issue as described, i upgraded by deconz to use the latest rPi image with Stretch.

While the original issue opener solved it by upgrading to Stretch, the issue still needs a solution. Jessie is a supported platform for both Home Assistant and the Deconz REST plug-in. It's unreasonable to expect everyone who uses this component to suddenly upgrade their whole Raspberry Pi system - especially since it worked perfectly with pydeconz 38 and earlier.
@Kane610, since you're the maintainer of pydeconz, I repeat the suggestion to check the underlying OS version, and fall back to the older websocket implementation if required. It would create an unnecessarily large code in the library, though. Another option (since it doesn't seem the HA component uses new features from the updated version) could be to perform the test on the HA component side, and install an older (v38) version of pydeconz when running on Jessie.

@aronsky there is no common way to verify OS or QT version from pydeconz since it is deCONZ which is affected by the system version, which can be run on any computer. I've asked for a comment from the developer of deconz on limiting supported QT5 versions. Depending on their response, I will add a legacy option for web sockets in pydeconz manually configured through the components setup.

@Kane610 thank you! I appreciate all the work you've done on the component, it does an admirable job in my home.

@Kane610 thank you for your work!
I had the same issue with non updating states with a newly installed deconz on a separate windows machine. It took a while to figure out: the websocket port was closed.
For anyone with the same issues: the deconz websocket can be configured on any free port in the config (mostly its deconz.local:443). So you have to open that port on the Firewall you are using. If 443 is used by your webserver deconz will choose another port.
PS: to find out what port is used by the websocket of deconz: curl http://deconz.local/api/APIKEY/config/

@cptpl4net thanks! Though the issue you are mentioning is different from the one in this issue which is about different behavior in deconz depending on system dependency versioning.


Better documentation

The documentation is very poor.
Would be nice to enhance it a little bit.
Any good contribution is welcome!

I would like to contribute to the doc purpose. Please guide me as I am new to OSS contributions...

I would like to contribute to the doc purpose. Please guide me as I am new to OSS contributions...

Hello @anwaysomani
This project is outdated.
I'm not sure even if this is still working. If you want, you could test the deployment to be sure if the installation process described in the README is still valid. The original idea of the issue was to write a better installation process.


Actually create parent directories.

Without the -p switch, it will error out, as it does not create the full path.

Actually didn't know this was not a default behaviour, thanks bro lgtm :+1:


Field focus when adding navigation items

If you add a new nav item and press [enter], the focus moves to the "url" field on a new line. It should move to the "label" field

I can look at this. I think I can just use some jQuery and set the focus on the last gh-blognav-line input. After adding a new nav item.


sys/linux: add netlink seg6 descriptions

I create a new pull request to re pull https://github.com/google/syzkaller/pull/1000

Please run make generate and commit changed files, CI is broken by this change:
https://travis-ci.org/google/syzkaller/jobs/495951628

Codecov Report

Merging #1005 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #1005      +/-   ##
=========================================
+ Coverage   67.68%   67.7%   +0.02%
=========================================
  Files         114     114
  Lines       20362   20362
=========================================
+ Hits        13782   13787       +5
+ Misses       5933    5927       -6
- Partials      647     648       +1

Impacted Files
Coverage Δ

prog/target.go
55.07% <0%> (-7.25%)
:arrow_down:

prog/mutation.go
93.43% <0%> (-2.04%)
:arrow_down:

prog/any.go
89.39% <0%> (+0.7%)
:arrow_up:

pkg/csource/csource.go
73.7% <0%> (+6.72%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c95f070...6df5151. Read the comment docs.

Thanks!


EE44 - Moving Development Content

https://github.com/google/earthenterprise/issues/44
Moved the development content (build instructions) off the opengee page and provided a link to the main GitHub page in its place. All the content is already in the Github wiki (and up to date) so any user can quickly navigate and find it there.
Also, added a small fix so that when the Develop tab is selected on opengee the "Develop" tab is highlighted. This previously always highlighted Documentation.
To verify this change

Go to: https://tst-ahernandez.github.io/earthenterprise/index.html
Navigate to the Develop tab
Verify that the page content is updated with all the build instructions removed

Hey @tst-ahernandez I think the intent was to also move the other content (GETTING STARTED WITH GOOGLE EARTH ENTERPRISE and HOW TO CONTRIBUTE) to the Wiki, since they are developer docs and only use opengee.org for user docs.

Can you also add a link to the description of the PR to the issue this is fixing? That will automatically tie the two together under the issue history.

Updated per the previous comments. Ready for testing.

@tst-ahernandez I'll start by apologizing about being nit-picky here. :) This isn't really a ding against the PR, but may effect the link. But, I think on the Wiki, either the content on the Getting started page and the Home page should be swapped (Getting started section is more like an intro) or it should all be combined on the Home page. And if you decide to move "How to Contribute" to its own page, it should probably just be called "How to Contribute" rather than anything else. I think the simplest thing to do would be to move everything to Home and link there, and get rid of "Getting Started".
Also, can you update the wording according to Andrei's suggestion?

I've updated the wiki with the changes as requested.

The only thing left to do is to update the link on the website to point to the new wiki page

Updated!


Fix Lighthouse Score

Setup PWA correctly
Set accessibility settings
Center Text

ok cool i dont understand any of this


Saving Data

Initial cut of "Saving Data" section of docs/index.rst

basic saving
cascade delete
explicit values in generated columns

@ajcvickers could you take a quick scan of this one? http://ef.readthedocs.org/en/staging/saving/index.html

:shipit:


[szip] CMake Error: try_run() invoked in cross-compiling mode

Operating system
Linux and macOS Cross-compile arm64 binaries using x64 containers
Compiler
No response
Steps to reproduce the behavior
see https://github.com/MaaAssistantArknights/MaaDeps/actions/runs/6335612832/job/17207088613 and https://github.com/MaaAssistantArknights/MaaDeps/actions/runs/6335612832/job/17207089437
Linux and macOS Cross-compile arm64 binaries using x64 containers
Failure logs
-- Looking for 13 include files unistd.h, ..., fcntl.h
-- Looking for 13 include files unistd.h, ..., fcntl.h - found
-- Looking for 14 include files unistd.h, ..., inttypes.h
-- Looking for 14 include files unistd.h, ..., inttypes.h - found
CMake Error: try_run() invoked in cross-compiling mode, please set the following cache variables appropriately:
   HAVE_DEFAULT_SOURCE_RUN (advanced)
   HAVE_DEFAULT_SOURCE_RUN__TRYRUN_OUTPUT (advanced)
For details see /home/runner/work/MaaDeps/MaaDeps/vcpkg/buildtrees/szip/maa-arm64-linux-rel/TryRunResults.cmake
CMake Error: try_run() invoked in cross-compiling mode, please set the following cache variables appropriately:
   TEST_LFS_WORKS_RUN (advanced)
   TEST_LFS_WORKS_RUN__TRYRUN_OUTPUT (advanced)
For details see /home/runner/work/MaaDeps/MaaDeps/vcpkg/buildtrees/szip/maa-arm64-linux-rel/TryRunResults.cmake
-- Performing TEST_LFS_WORKS... no
-- Performing Other Test HAVE_OFF64_T - Failed

Full log:
config-maa-arm64-linux-out.log
buildtrees.zip
Additional context
No response

This is the standard szip cmake behaviour, not a port bug. They rely on try-run or user input for certain configuration elements.
If you really want to try it out, you can pass the suggested options from your custom triplet file, e.g.
if(PORT STREQUAL "szip")
    list(APPEND VCPKG_CMAKE_CONFIGURE_OPTIONS
        -DTEST_LFS_WORKS_RUN=TRUE
        -DTEST_LFS_WORKS_RUN__TRYRUN_OUTPUT=
        -DHAVE_DEFAULT_SOURCE_RUN=0
        -DHAVE_DEFAULT_SOURCE_RUN__TRYRUN_OUTPUT=
endif()

These are the value the portfile applies for Android/iOS/macOS cross targets.
i.e. "macOS Cross-compile arm64 binaries using x64" shoudl already work.
What do you want to use it for? hdf5 has the same problem.

This is the standard szip cmake behaviour, not a port bug. They rely on try-run or user input for certain configuration elements.
If you really want to try it out, you can pass the suggested options from your custom triplet file, e.g.
if(PORT STREQUAL "szip")
    list(APPEND VCPKG_CMAKE_CONFIGURE_OPTIONS
        -DTEST_LFS_WORKS_RUN=TRUE
        -DTEST_LFS_WORKS_RUN__TRYRUN_OUTPUT=
        -DHAVE_DEFAULT_SOURCE_RUN=0
        -DHAVE_DEFAULT_SOURCE_RUN__TRYRUN_OUTPUT=
    )
endif()

These are the value the portfile applies for Android/iOS/macOS cross targets. i.e. "macOS Cross-compile arm64 binaries using x64" shoudl already work.
What do you want to use it for? hdf5 has the same problem.

But, according to the action provided above, szip DOES configured on Windows while targetting arm64. Is there any difference between win and other os?

@dg0yt
I've found this in portfile.cmake of szip. It seems that we've already provided a preset configuration for mac target, just like you've mentioned above. But we still failed building on mac. Could you please give us some suggestions?

I've found this in portfile.cmake of szip.

That's what I said: "These are the value the portfile applies for Android/iOS/macOS cross targets."

Szip is built on mac

So my claim is confirmed: "macOS Cross-compile arm64 binaries using x64" shoudl already work."

but hfd5 don't.

And that's why I wrote early: "What do you want to use it for? hdf5 has the same problem."
It is a know issue for years. hdf5 1.15 will come with some improvements, but ATM there are still some try_run tests left.

After some of tries, I've managed to pass the configuring step. However I'm stuck in the build step, as it tries to run some arm binary. I decided to setup qemu and set the CMAKE_CROSSCOMPILING_EMULATOR. But I cannot get the libc6:arm64 installed, as apt update keeps failed. Is there any option to let hdf5 static link those detecting programs?

      - uses<EMAIL_ADDRESS>        if: runner.os == 'Linux' && matrix.arch == 'arm64'
        with:
          arch: arm64
          packages: 'libc6:arm64'


Look up correct property from request body object

Also add some type-checking

Checklist

[ ] Tests written for all new code
[x] Linter has been satisfied
[x] Sign-off given on the changes (see CONTRIBUTING.md)

This PR indeed fixes matrix-org/matrix-rust-sdk#1093 and turt2live/matrix-bot-sdk#256.
Here's one way to trigger it:

create an encrypted room
invite a E2EE-capable bot to it
exchange some messages
invite any other user the room

Also, this seems to happen only when using bot-style / CS-API bots, not appservice-style bots, which makes sense since the problem happens during /sync.

I've opened https://github.com/turt2live/matrix-bot-sdk/pull/288 to cover the bug while we wait for the rust-sdk to have better types.


Increasing memory usage when using the Equipment Status HUD

Hello there !
I've been recently using your mod (which is great!) and found out that I started to have issues with my memory and CPU usage.
I did notice that after some time (1/2 hours) my game was running out of memory, fluctuating a lot at the highest limit (2GB here).
I also suspected an abnormal amount of GC, which was confirmed when I started to see my CPU ramping a lot in this situation.
After some testing, It seems to be related to the Equipment Status HUD feature and on how object' lifecycle are handled (EquipmentInfoStack class).
Setup

Win 11
JRE 20
Minecraft with Fabric mod loader 1.20.1
simple-hud-enhanced+1.20-1.20.1-v3.1.0.jar

Testing
With jvisualvm I've started to monitor my game and see if I could find a suspicious class using a lot of memory.
First test, with the option activated, we can see an increase in my memory usage, and a lot of live object for the EquipmentInfoStack. context: was playing as usual on an SMP server for 1+ hour

Second test, with the EquipmentStatus HUD option deactivated (didn't changed anything else on my setup). context: was afk on the same SMP server for 1+ hour

Expected behaviour
Using the Equipment Status HUD option should not cause indefinite increase in memory usage.
Additional context
Feel free to ask me anything, I hope I didn't forget anything :)
Regards,

Thanks for this amazing detailed bug report. I observed this, too, and just found the issue: my code constantly adds armour or items the payer is holding to a list controlled by EquipmentInfoStack Class. I just keep adding to it, and it never gets unallocated. In theory, if you keep cycling items, this should speed up the process of data allocation.
But the only thing that makes me doubt it is that this class should not run if you disable the option in settings.
// Draw Equipment Status
        if (config.toggleEquipmentStatus) {
            Equipment equipment = new Equipment(context, config);
            equipment.init();
        }

public void init() {
        // Get Armour and Hand Item from Inventory and Offhand
        equipmentInfo = new ArrayList<>(
                Arrays.asList(
                        new EquipmentInfoStack(this.player.getInventory().getArmorStack(3)),
                        new EquipmentInfoStack(this.player.getInventory().getArmorStack(2)),
                        new EquipmentInfoStack(this.player.getInventory().getArmorStack(1)),
                        new EquipmentInfoStack(this.player.getInventory().getArmorStack(0)),
                        new EquipmentInfoStack(this.player.getOffHandStack()),
                        new EquipmentInfoStack(this.player.getMainHandStack())
                )
        );

        // Remove Air Blocks from the list
        equipmentInfo.removeIf(equipment -> equipment.getItem().getItem().equals(Blocks.AIR.asItem()));

        // Check showNonTools
        if (!config.equipmentStatus.showNonTools) {
            equipmentInfo.removeIf(equipment -> equipment.getItem().getItem().getMaxDamage() == 0);
        }

        if (config.equipmentStatus.showDurability) {
            // Draw Durability
            getDurability();
        }

        // Draw Items
        draw();
    }

Note: I am working on text scaling, I am going to finish the new scaling text code and then create a potential fix for this issue.

Hey !
I've been reading some of the code, and I think the problem comes from the parent object named Equipment, we can confirm this with my previous screens where we can see the number of instances increasing for Equipment (test 1 with the option active).
Just an hypothesis here, but could the non-deletion of these instances be linked to the context parameter in the constructor of Equipment ? Can it, somehow, avoid the deletion of Equipment instances ?
Looking forward to hearing more about your findings when you will work on this issue 👀

It seems my v4.0.0 Update has worked without much issue. I will now spend all the time that I allocate to open sauce on this. Will start testing in the coming days. Ill write when I have an update.

Compiled Code for Testing:
simple-hud-enhanced+1.20-1.20.2-v4.1.0.zip

Please Test this new update to check if the issue is fixed.

Hello there,
Sorry I wasn't able to get back to you sooner, I was on holidays.
I just tested the new version (4.1.0), but it seems that the problem persists 👀
Please find my new tests enclosed. On my side I will not be able to test future binaries since I'm very busy :(
Regards
FIRST TEST: 1GB memory, Equipment HUD ENABLED, 1 hour AFK
![0](https://github.com/SoRadGaming/Simple-HUD-Enhanced/assets/70151737/9159276d-117f-4a42-8b7d-1b2c995b045c)
![1](https://github.com/SoRadGaming/Simple-HUD-Enhanced/assets/70151737/ab7f808c-c8a8-49db-9eec-bfeb4fafc124)
![2](https://github.com/SoRadGaming/Simple-HUD-Enhanced/assets/70151737/163fa739-4a74-48b7-b96c-95d35c8c37c3)

SECOND TEST: 1GB memory, Equipment HUD DISABLED, 1 hour AFK
![disable-0](https://github.com/SoRadGaming/Simple-HUD-Enhanced/assets/70151737/15fad2ca-3656-4d79-a10b-14d7c5cd9406)
![disable-1](https://github.com/SoRadGaming/Simple-HUD-Enhanced/assets/70151737/cd6fa8d0-dd67-4f4f-82d8-419ee290ca15)
![disable-2](https://github.com/SoRadGaming/Simple-HUD-Enhanced/assets/70151737/4392287e-a891-42e6-8af9-2d85ef812cce)

I finally found the issue; it seems v4.1.0 has improved but has not been fixed. The Equipment class extends the Hud class which causes its instances never to be garbage collected.
Here is the jar With the Fix; in my testing, it seems to have fixed the problem.
simple-hud-enhanced+1.20-1.20.2-v4.2.0.zip

Yup, the memory leak seems to be fixed, I now have an expected memory curve with my game !
Thanks for the fix <3

I will release the update and some improved async code (still in progress); thanks for all the help. What do you prefer as a contributor name, Antonio or alerouzic?

alerouzic is fine 👍


axios is accidentally in dev dependencies

:tada: This issue has been resolved in version 1.2.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Enable enhanced monitoring

Creating the monitoring role in the module seems to work.
(README not updated)

Yeah, with the current code, I get:
Error running plan: 1 error(s) occurred:

* module.mysql.aws_db_instance.main_rds_instance: 1 error(s) occurred:

* module.mysql.aws_db_instance.main_rds_instance: Resource 'aws_iam_role.rds_monitoring' not found for variable 'aws_iam_role.rds_monitoring.arn'

OK, I think this is ready to merge.
I've pruned it back to the most simple implementation possible - ie. just add the additional parameter.
The module user is responsible for making sure that the specified role exists.

LGTM, sorry for the delay in response! Will you be able to adapt this PR to fit nicely in https://github.com/terraform-aws-modules/terraform-aws-rds and submit PR there instead?

https://github.com/terraform-aws-modules/terraform-aws-rds/pull/6


12 vs 24 hr time option

I used to see my calendar in my preferred 12hr clock format, but I can't seem to figure out how to change it from the latest update that is showing all appointments in military time. Please help

add the option:
hoursFormat: 12h

currently waiting on a module being updated before this will be automatic based on HA settings

This fixed it. Much appreciated!


Exception of type 'System.StackOverflowException' was thrown.

Hi
I've been experimenting with trill and have come across an issue that looks like a bug. If i run the following code I get a stack overflow error.
SensorReading[] historicData = new[]
       {
                new SensorReading { Time = 1, Value = 0 },
                new SensorReading { Time = 2, Value = 20 },
                new SensorReading { Time = 3, Value = 15 },
                new SensorReading { Time = 4, Value = 30 },
                new SensorReading { Time = 5, Value = 45 },
                new SensorReading { Time = 6, Value = 50 },
                new SensorReading { Time = 7, Value = 30 },
                new SensorReading { Time = 8, Value = 35 },
                new SensorReading { Time = 9, Value = 60 },
                new SensorReading { Time = 10, Value = 20 }
            };

            var streamable1 = historicData
                .ToObservable().ToTemporalStreamable(r => r.Time, r => r.Time + 1);

            var output = streamable1.TumblingWindowLifetime(3)
                   .Aggregate(
                   w => w.Count(),
                   w => w.Average(v => v.Value),
                   (count, avg) => new { Count = count, Avg = avg });

            Console.WriteLine("Output =");
            output.ToStreamEventObservable().ForEachAsync(e => Console.WriteLine(e)).Wait();

It might be that I'm using the linq incorrectly but I've tried various changes and it looks like if i want a tumbling window and also an aggregate with a lambda, like average, max or min, i get this error.
Thanks, Jonathan

Hi @JonathanKeav , I'm not seeing any exception when running this on the latest master with a dummy definition of SensorReading. What is the stack trace of the exception?

Hi Peter
I'll give you a brief overview of what i have done so far. I am using the trill samples solution which comes with version 2<IP_ADDRESS> added as a nuget package. I added my own project to this trill samples solution with the code supplied in the original issue above and i see a stack overflow error. So today i updated the trill samples solution to use the latest nuget package, version 2<IP_ADDRESS>, but i still have the same error.
I then created a .net core 3.0 console app, downloaded the latest master from here, built and referenced that and i am still getting the same error when i run a linq query like this
var output = streamable1.TumblingWindowLifetime(3)
.Aggregate(
                   w => w.Count(),
                   w => w.Average(v => v.Value),
                   (count, avg) => new { Count = count, Avg = avg });

Below is a screenshot of the error which occurs in StreamMessagePool class in StreamMessagePoolColumnar.cs.

The error details that appear in the screenshot are all that there are. Selecting "View Details" does not provide any further information.
Thanks, Jonathan

StackOverflowException usually means there are too many nested function calls, so a screenshot of the exception text does not really help. Can you please provide the stack trace itself to see what all of thee nested function calls are?

Hey @peterfreiling2 ,
I was able to reproduce this with his code sample.
Data is here
https://gist.github.com/AlgorithmsAreCool/68654a12ac7b9d2af49ac052985d556d

@peterfreiling2
https://github.com/microsoft/Trill/blob/4d8b4f8daa4f2ca67316139914e3aaa98cc44bf9/Sources/Core/Microsoft.StreamProcessing/Operators/SnapshotWindow/Tumbling/SnapshotWindowTumblingPipeSimple.cs#L198-L202
🤔🤔🤔

@AlgorithmsAreCool thanks! Yes, looks like a typo. The repro requirements missing from the original code sample was that we needed row-based execution, and an aggregate state that implements IDisposable.

@AlgorithmsAreCool or @JonathanKeav , would either of you be able to check in the fix? As @AlgorithmsAreCool mentioned, the recursive call to DisposeState should instead be a call to DisposeStateLocal

@peterfreiling2  Made a PR #123

Thanks @AlgorithmsAreCool and @JonathanKeav !


libdeltachat: 1.87.0 -> 1.93.0

Description of changes
https://github.com/deltachat/deltachat-core-rust/blob/1.93.0/CHANGELOG.md

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 187364 run on x86_64-linux 1

5 packages built:

deltachat-cursed
kdeltachat
libdeltachat
python310Packages.deltachat
python39Packages.deltachat


Fix overflow problems with QueryPerformanceCounter() by using doubles

This is needed for PR #1376 in platform.

I'm not completely convinced of the reasoning in this pull request.  What, exactly, was overflowing?

See my philosophical post :p http://sf-github.leap.corp/leapmotion/platform/pull/1370.

I'll have a look, but recommend you completely justify here as well.  This is a public repository, after all.

Excerpted:
There are no severe problems inherent with QPC. Boost has always used QPC, and VS2015's std::chrono will use QPC. Yes, it has some bugs with multithreading and some hardware-specific defects, but for our timing purposes (μs for long intervals) it's the best we can get. The issues only arise from improper handling of its output. I dug a bit deeper and compared Walter's profiling_clock (which was based on a StackOverflow answer) to Boost's high_resolution_clock.
Walter's class:
count *<PHONE_NUMBER>L / frequency

Even though the final result fits into 64 bits, the value of (count * 1e9) can easily overflow, and is certainly what was causing the visualizer bug. On a typical Windows box where the QPC frequency is 3.58 MHz, it only takes 2^63/(3.58e6 * 1e9) = 2576 seconds of system uptime before overflow happens. So all the time, basically.
Boost avoids this by using doubles:
(int64_t)(count * (double)(1000000000L / frequency))

(An even more accurate way would be:)
(int64_t)(count * (1e9 / (double)frequency))

The dynamic range of doubles means that it will not overflow. The 52-bit mantissa means it won't have rounding errors either. Since neither of these problems are present, this value is accurate to the frequency of QPC itself.
So the solution is to change Walter's class to use doubles, but keep the use of profiling_clock. There's a million other ways you could do it. You could use a 128-bit int. But this works and is the simplest.

"It works" isn't usually sufficient for me, but in this case I can't think of a better answer.  Let me think about this for a little while, and if I can't come up with a better idea, we can merge it.
Note that we won't be able to cut another release of autowiring in time for a release of Leap, we will need to make use of an alternative workaround to fix the problem in develop.

Ok, I'll just resurrect Utility/profiling_clock.h in the platform branch.

Roger that.

(I hope one of your ideas isn't having some hybrid where you use a GetTickCount-based timer to correct for jitters in the QPC-based timer. That would get messy fast.)

No, I wouldn't want to mix any counter types.
I was thinking about using the Windows Multiply128 function to get what I want.  This code is all Windows-only, anyway, so it would technically do the trick.

Yeah, I was considering that. It would be a cleaner solution, I was just scared when I saw winnt.

The function can be forward declared, leave it to the user to provide the necessary link libraries.

Hm, that's a good point.

There's no over-the-counter Divide128 though. :(

A clever trick would be to find the modular inverse of g_Frequency and then multiply that by 1e9 statically.  The extended euclidian algorithm is both fast and sufficiently simple for this purpose, sample code is near the bottom.  The only caveat is that g_Frequency must be relatively prime to 2^64--a quality easy enough to assure if we are OK with nudging its value by a tiny bit if it happens to have no other factors than 2.

If
1e9*mod_inv(g_Frequency)

is the value you're calculating, I don't think it will work. One can't declare that 1e9*mod_inv(g_Frequency) is a substitute for 1e9/g_Frequency (the desired value).
One can only say that:
g_Frequency * (1e9*mod_inv(g_Frequency)) ≡ g_Frequency * desired_value     (mod 2^64)
which means that you would need to carry around g_Frequency everywhere downstream to properly interpret it.

Now that I think of it, using doubles is always within 1 nanosecond of a 128-bit integer divide, and that's due to the latter's truncation. It has 52 bits of precision so the value is basically dead on, for up to 9.2 billion seconds (2^63/1e9) of system uptime. That's longer than this country has existed.

Yep, I did that math out as well.  Surprisingly often in theoretical physics you need to multiply one extremely large number by another extremely small number; a typical solution is to extract logarithms and do the math out that way; the approach we are using here is basically the same.

It's OK if the quantity 1e9*mod_inv(g_Frequency) overflows.  The real problem is that the modular inverse trick only works for exact division; if you want standard quotient/remainder division, you need a more complex multiplication.

Dude. It's got 99 problems, but overflowing ain't one.
I didn't say overflowing was an issue, I just meant that you cannot interpret (1e9*mod_inv(g_Frequency)) meaningfully without g_Frequency itself.

This is turning out to be the exact opposite of a clever trick ;)

Yeah, logarithms is definitely the right way to think of it.

There is no better way to do this, they all wind up being the same thing, and 52 bits of precision is more than enough for our purposes.


new target: Perl5

added target for Perl

@jgabriels thanks for the contribution. our test suite is stable on master if you would kindly rebase and add output fixtures and fix and linting issues. See #128 for inspiration.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@darrenjennings
I'm following this issue because @jgabriels and I just discussed it.
Has anything changed since your last comment in 2019, or is the process still the same?

@wbraswell No, this PR needs to be recreated under the new directory structure and TypeScript codebase.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Closing, uses old way of adding a target.


Certificate error during artefact download when behind SSL proxy

Agent version and platform
Version of your agent? 2.126.0 on Windows 2016
VSTS type and version
VSTS online, local agent
What's not working?
During artefact download stage of release task, error is "Failed in getBuild with error: Error: unable to get local issuer certificate"
This is a new issue, seemingly caused by VSTS upgrade recently as it used to work fine. It is not clear from the error if this comes from git or the agent itself (I am not clear how the artefact is retrieved and the logs don't say).
The proxy also proxies SSL and so we need generally to have our proxy root CA certs installed. They are installed in the windows cert store by default on every server and work as expected. I tried adding the CA certs to the agent git system, global and user ca bundle. No difference. I tried configuring the agent to ignore sslverification. No difference. The agent runs as a custom domain user. Tried adding the CA certs to the agent service user .gitconfig CA bundle location. No difference.
I am at a loss - where do extra CA certs need to go to allow the agent to fetch build artefacts?

@plk not sure whether will work, but can you try the following thing.

download a new copy of the agent
put your CA cert chain under the root of the agent folder, the cert better be .pem
configure agent with config.cmd --sslcacert ./locationtoyourcert.pem

see whether it help.

Many thanks - this now works for artefact download.

@plk cool, glad you unblock, i will close the issue and update the doc.

Thanks @TingluoHuang for taking care of this.

neither has this issue been resolved nor is the workaround feasible for any kind of corporate environment which potentially needs dozens, maybe even hundreds of agents deployed in a reliable, semi-automated manner. This issue needs to be reopened, the entire topic really is a pain regarding Azure DevOps server 2019 server. It is possible to work around with YAML pipelines but apparently not with release pipelines.


Update sbt to 1.3.7

Updates org.scala-sbt:sbt from 1.3.4 to 1.3.7.
Release Notes/Changelog
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ]

labels: library-update, semver-patch

Made obsolete by #38.


[SPARK-15198][SQL] Support for pushing down filters for boolean types in ORC data source

What changes were proposed in this pull request?
It seems ORC supports all the types in  (PredicateLeaf.Type) which includes boolean types. So, this was tested first.
This PR adds the support for pushing filters down for BooleanType in ORC data source.
This PR also removes OrcTableScan class and the companion object, which is not used anymore.
How was this patch tested?
Unittest in OrcFilterSuite and OrcQuerySuite.

Let me please cc @liancheng and also @tedyu who suggested this change.

Test build #58049 has started for PR 12972 at commit f225fe5.

Test build #58049 has finished for PR 12972 at commit f225fe5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58049/
Test PASSed.

Merged build finished. Test PASSed.

Please excuse my ping, @liancheng

Test build #59364 has started for PR 12972 at commit bdb645b.

Test build #59364 has finished for PR 12972 at commit bdb645b.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59364/
Test FAILed.

retest this please

Test build #59366 has started for PR 12972 at commit bdb645b.

Test build #59366 has finished for PR 12972 at commit bdb645b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59366/
Test FAILed.

retest this please

Test build #59368 has started for PR 12972 at commit bdb645b.

Test build #59368 has finished for PR 12972 at commit bdb645b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59368/
Test FAILed.

Test build #59374 has started for PR 12972 at commit e080192.

Test build #59374 has finished for PR 12972 at commit e080192.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59374/
Test PASSed.

Sorry for the late review, this LGTM except for one minor comment on the test case. Thanks for fixing it!

Thank you so much.

Test build #59436 has started for PR 12972 at commit d8e1641.

Test build #59436 has finished for PR 12972 at commit d8e1641.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59436/
Test PASSed.

Merged build finished. Test PASSed.

Test build #59452 has started for PR 12972 at commit 1af9d56.

Test build #59452 has finished for PR 12972 at commit 1af9d56.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59452/
Test PASSed.

Hi @liancheng, I guess you missed this. I will cc in case.

Test build #61229 has started for PR 12972 at commit 30bb40a.

Test build #61229 has finished for PR 12972 at commit 30bb40a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61229/
Test PASSed.

Merged build finished. Test PASSed.

Hi @liancheng ! Could you take a quick look please?

Test build #61534 has started for PR 12972 at commit 5338f71.

ping @liancheng ...

Test build #61534 has finished for PR 12972 at commit 5338f71.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
public final class JavaStructuredNetworkWordCount
trait ConsumerStrategy[K, V]
 class DirectKafkaInputDStreamCheckpointData extends DStreamCheckpointData(this)
class KafkaRDDPartition(
trait HasOffsetRanges
trait CanCommitOffsets
class OptionUtils(object):
class DataFrameReader(OptionUtils):
class DataFrameWriter(OptionUtils):
class DataStreamReader(OptionUtils):
class DataStreamWriter(object):
public class UDFXPathUtil
 public static class ReusableStringReader extends Reader
case class XPathBoolean(xml: Expression, path: Expression)
case class TypedFilter(
case class ShowFunctionsCommand(

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61534/
Test PASSed.

@yhuai Could you please take a look?

LGTM, merging to master. Sorry for leaving this PR for so long...

No problem! thank you!


Are some triple in freebase is wrong?

in file "FreebaseQA_fb_extract.txt", there some wrong triple , just like ,"m.03_bjc	type.object.type	government.governmental_jurisdiction". This cause the freebase enviroment can not be imported into virtuoso. Could you please upload the db of  the virtuoso or through other ways . Thanks.

If I recall, we used the Freebase dumps provided by Google (https://developers.google.com/freebase) to create FreebaseQA, so there shouldn't be any incorrect triples? In fact, I just checked the example you provided and I was able to find it.

@kelvin-jiang Could you provide a mapping from mid to its name? m.03_bjc seems to an invalid id. Many ids in FreebaseQA_fb_extract.txt are not found in Freebase/Wikidata Mappings or Freebase Easy.

Hi @hankcs, I took a look into m.03_bjc. It is not that it is an invalid ID, but instead it does not appear in the sources you linked for some reason. Using the full Freebase dataset, m.03_bjc is the Freebase MID for Akrotiri and Dhekelia, which in Wikidata is Q37362.
For why it isn't in the Freebase/Wikidata Mapping set, maybe it is because this MID doesn't satisfy this condition?

The data has been created based on the Wikidata-Dump of October 28, 2013, and contains only those links that have at least two common Wikipedia-Links and not a single disagreeing Wikipedia-Link. Furthermore, the lines are sorted by the number of common Wikipedia-Links (although in Turtle this does not really matter).


how to set android video config like ios?

"react-native-video": "^5.0.2",

Video in IOS  is better than in Android.
I want to set video config to make video in android works  as if it works in ios.
which config I should set?

Any update, ios is taking a lot to play large size videos