Question

Is it possible to implement a solution similar to: 155 without using XmlElementAttribute?  I know 155 has the choice attribute but in my case I haven't been using that.  I've just decorated the property with XmlElementAttribute and the possible types the property can be.
I've looked at Issue 180 also trying to understand how Extensions work.  In that example I was trying to understand how a custom serializer is implemented for one property.
I made up a failing test, can exs namespace be eliminated?  I realize that will mess up deserialization but in this case that's ok.
https://gist.github.com/dbeattie71/2b1bf92d90ecbe49f635a8906b34fcba

Hi @dbeattie71 thanks for writing in and asking about this.
I am trying to better understand what you are facing here.  Are you concerned about the extra namespace attribute(s) -- exs in this case?
Also, it would be valuable to know if you have encountered a scenario where the default serialization did not work and/or what you do not like about the current serialization result.  That is, if it's more than just the extra namespace attributes.
Currently in v2 we cannot do away with the exs namespace (not without a lot of work that is -- but PRs are welcome 😄), but for v3 this is certainly something we can keep in mind when/while we're designing it.
When it comes to namespaces we are using the underlying classic System.Xml.XmlReader and System.Xml.XmlWriter` infrastructure that helps resolve these namespaces and properly resolve these entities.  These of course are based on the XML standard/specification and help keep attributes properly identified and separated from their hosting elements.
For v3 we're looking at writing our own implementation of such concerns, so we will be able to be much more flexible in how we read/write objects and their respective properties.

So I want to walk you through your serialization, @dbeattie71 as I am interested in this topic as of late.
As above, you have this as (with the quotes corrected for XML syntax compliance):
<?xml version="1.0" encoding="utf-8"?>
<SubjectRequest>
	<Subject2>
		<Message>message1</Message>
		<Message2>message2</Message2>
	</Subject2>
</SubjectRequest>

The first thing to note is that there is no SubjectRequest.SomeInterface property.  So you would need to specify it as such:
<?xml version="1.0" encoding="utf-8"?>
<SubjectRequest>
	<SomeInterface>
		<Subject2>
			<Message>message1</Message>
			<Message2>message2</Message2>
		</Subject2>
	</SomeInterface>
</SubjectRequest>

Conceivably, we could now use the implicit types to serialize the remaining Subject2 tag.  Since implicit types are keyed by the name, we could find the one that exists at this name and then try to deserialize it.
The reason I am interested in this is due to my recent research into TOML/YAML "configurations" in Jekyll and Hugo.  Everything is very "clean" these days without much decoration.  I understand the appeal of this, which is why we have implicit typing in the first place.  However in this case we still spill out namespaces because the type could be anything.  Let me see if we can simply dispatch a lookup to implicit types and re-reroute the processing through there.

The exs isn't a big deal as I have some code that removes namespaces.  Adapted from https://github.com/BizTalkComponents/ManageMessageNamespace.  The docs for the request I'm building are here http://www.byallaccounts.net/manuals/dataconnect/dataconnect_v4_ultra_user_guide.pdf.  For some reason if the request is sent with any namespace info, it gets rejected.  Possibly because they add they're own.
This https://gist.github.com/dbeattie71/8efae93d7e1e5d31df0de6dea671256a is a snippet of whats created when converting their DTD to XSD and then using xsd.exe.  I'm trying to emulate what happens when the Item property is an object and decorated with XmlElementAttribute.
I'm guessing that what xsd.exe creates should be like #155 and have a XmlChoiceIdentifierAttribute but some things in DTD probably don't exactly map to XSD.
So what I'm after is being able to create SubjectRequest and set SubjectRequest.SomeInterface to any type that implements it and when SubjectRequest is serialized, have the element name of the type that implemented ISomeInterface.
Chances are I'm making this more difficult than it is but I was also trying to understand how extensions work as they seem really flexible and thought I could just make an extension that for a certain property, spit out a different element name.
Somewhat off topic but you might be interested in https://github.com/Cinchoo/ChoETL
For Extensions, I've been basically trying to understand the anatomy of an extension.  Looking at Issue180 and all the other extensions.

Ah OK cool thank you for those links and for the pointer to ChoETL.  I'll check it out. 😄
I think I see now what you're driving at.  I have checked in an example here:
https://github.com/wojtpl2/ExtendedXmlSerializer/blob/master/test/ExtendedXmlSerializer.Tests/ReportedIssues/Issue186Tests.cs
You could possibly simply set the name.  However, that is a static name and there isn't at present a way to dynamically set the name during runtime.  But, conceivably you could create a new serializer for each request and set the name as prescribed.  Let me know if that is closer to what you are looking to do.
The other option as well if you have not considered it is to use XSLT.  You should be able to easily set the name of the property name with that as well.

Thanks, that makes sense.  I didn't think about xslt, that may be more flexible.  I've also seen people set an ignored property to what they want the element name to be and then use XmlAttirubteOverrides to set the ElementName to the property.  I might play with that and extensions and see what I can come up with.

Yeah for sure.  Sorry I can't be much more help ATM.  The v2 codebase is pretty much set in stone until v3 unless it's a pretty obvious feature that can be handled by an extension.  In this case we're sort of tied up because of the attributes and namespacing.  Please do let us know what you find.  FWIW we do not make use XmlAttributeOverrides in our current implementation but most attributes do have support.  Please let me know if you have any further questions and I'll do my best to help you... hopefully better than I have thus far. 👼

No problem, thanks.  I enjoy looking through the code and figuring out how things work.

Closing this issue for now.  Please do not hesitate to add a new issue or to comment here if you have further thoughts/questions/concerns about this issue/project. :)


Open VR / Steam VR support

Hey would it be possible to get OpenVR support for Xenko?
I am going through the API docs and seeing that there is no direct support for OpenVR.
https://github.com/ValveSoftware/openvr

What exactly do you mean by "OpenVR support"? Xenko is using OpenVR as one of their VR backends:
https://github.com/xenko3d/xenko/tree/master/sources/engine/Xenko.VirtualReality

Oh my bad. I was looking through the API docs and saw that there was no mention of OpenVR.
https://doc.xenko.com/3.0/en/api/Xenko.VirtualReality.html


Tags are not inherited

Current behavior
Tags added above a feature are not inherited by the scenarios according to the spec https://cucumber.io/docs/cucumber/api/#tags
I have the following before step
 Before({ tags: '@basic' }, () => {   console.info('Before basic'); });
When I put the @basic tag above the Feature in the feature file the Before-step is not executed. If I put the @basic tag above the Scenario in the feature file it is executed.

Desired behavior
Tags should be inherited by the child elements

Test code to reproduce

Versions

Cypress version: 4.9.0
Preprocessor version: 2.5.2
Node version: 13.11.0

This appears to be fixed in #557, which is released with version 4.2.0. Specifically, these lines seem to do the trick :smile:

Due to personal reasons, the previous maintainers of this package are stepping down and handing the reigns over to me, a long-time contributor to the project and a user of it myself. This is a responsibility I'm very excited about. Furthermore, I'd like to thank @lgandecki ++ for all the work that they've done so far.
Read more about the transfer of ownership here.
The repository has however moved and all outstanding issues are being closed. This is not a reflection of the perceived importance of your reported issue. However, if after upgrading to the new version, you still find there to be an issue, feel free to open up another ticket or comment below. Please make sure to read CONTRIBUTING.md before doing so.


issue on offline export sequence/part

I noticed there have been couple of issues on offline export, and I apologize if mine is a duplicate.
the demo you gave works pretty well, well I run into a problem using Tone.part and Tone.Sequence in Offline context
In my demo below, the offline context seems abandon all the notes after 2 second.
https://jsfiddle.net/gztLy5cn/2/
I did find a workaround though by triggering notes one by one without Part/Sequence.

try removing part.loop = false in the Offline func for now

https://github.com/Tonejs/Tone.js/blob/dev/Tone/event/Part.js#L360
Look like testLoopBoundries is called when loop is set for all conditions:
https://github.com/Tonejs/Tone.js/blob/dev/Tone/event/Part.js#L418


Fix options of doc.extendSelections.

The options argument of doc.extendSelections has currently no effect, because it is passed to clipPosArray instead of extendSelections.

Indeed! Merged as d9042e7


Angular 9 Update Issue - Already being initiated

I updated to Angular 9 and code started breaking at below.
ERROR Error: An image viewer is already being initiated on the element.
at ImageViewer._findContainerAndImageSrc (ImageViewer.js:239)
at new ImageViewer
Do you have new updates for Angular 9?
Thank you

If i add "enableIvy": false then it is working fine in Angular 8 w/o any issue. I load this component dynamically so i each it destroy and recreate the new component like below
ngAfterViewInit() {
this.wrapper = document.getElementById('image-gallery');
this.viewer = new ImageViewer(this.wrapper.querySelector('.image-container'));
$(document).ready(function () {
  document.getElementById('imgdoc').addEventListener('click', function () {
    toggleFullscreen(document.getElementById('image-gallery'));
  });
});

}
and then call the load function when i have the data from API.


Sensor broken?

First, I appologize because this is probably not an 'issue' with your library... but I'm looking for some help.
I'm using the GP2Y0A21YK sensor with your library. The example gives an output like below, but...
During these couple of seconds I did not touch anything. This same pattern comes back over and over again, even though the sensor input does not change - it's just pointing at a white wall.
Now, when I first connected the sensor I accidentally switched +5V and GND, maybe for a minute. I felt the sensor got hot and fixed the mistake.
Should I conclude the sensor is broken?
Many thanks for some advice!
Distance in centimeters: 255
Distance in centimeters: 255
Distance in centimeters: 67
Distance in centimeters: 28
Distance in centimeters: 15
Distance in centimeters: 15
Distance in centimeters: 15
Distance in centimeters: 15
Distance in centimeters: 15
Distance in centimeters: 15
Distance in centimeters: 15
Distance in centimeters: 15
Distance in centimeters: 15
Distance in centimeters: 15
Distance in centimeters: 15
Distance in centimeters: 16
Distance in centimeters: 17
Distance in centimeters: 16
Distance in centimeters: 19
Distance in centimeters: 27
Distance in centimeters: 40
Distance in centimeters: 255
Distance in centimeters: 255
Distance in centimeters: 255
Distance in centimeters: 255
Distance in centimeters: 255
Distance in centimeters: 255
Distance in centimeters: 255
Distance in centimeters: 255
Distance in centimeters: 255
Distance in centimeters: 255
Distance in centimeters: 255
Distance in centimeters: 255
Distance in centimeters: 255
Distance in centimeters: 255
Distance in centimeters: 60
Distance in centimeters: 30
Distance in centimeters: 17
Distance in centimeters: 15
Distance in centimeters: 15
Distance in centimeters: 15
Distance in centimeters: 15
Distance in centimeters: 15
Distance in centimeters: 15
Distance in centimeters: 15
Distance in centimeters: 15
Distance in centimeters: 15
Distance in centimeters: 15
Distance in centimeters: 15
Distance in centimeters: 17
Distance in centimeters: 16
Distance in centimeters: 17
Distance in centimeters: 22
Distance in centimeters: 31
Distance in centimeters: 67
Distance in centimeters: 255
Distance in centimeters: 255
Distance in centimeters: 255
Distance in centimeters: 255
Distance in centimeters: 255

I am afraid your sensor is broken.

Thanks man! :o)
On 29 June 2015 at 16:22, jeroendoggen<EMAIL_ADDRESS>wrote:

I am afraid your sensor is broken.
—
Reply to this email directly or view it on GitHub
https://github.com/jeroendoggen/Arduino-distance-sensor-library/issues/8#issuecomment-116696487
.

--
Free
+32 498 91 44 31
Twitter: @FreeWillaert
https://twitter.com/intent/follow?original_referer=https%3A%2F%2Fabout.twitter.com%2Fresources%2Fbuttons&region=follow_link&screen_name=FreeWillaert&tw_p=followbutton
Website: http://sitcom.be
LinkedIn: https://www.linkedin.com/in/freewillaert
https://www.linkedin.com/in/freewillaert
--
By the way.....
http://facebook.com/dekaasstolp - whether you like it or not :o)
sitcom bvba
Diestsesteenweg 111
3010 Kessel-Lo
BE0895.067.696


[Proposal] Allow existing store modules to be provide additional properties like the customActions, etc.

Current state
Currently, if the namespace for a service resolves to the namespace of an existing store module that is not a service module, the existing module is overwritten without consideration of its setup. This behavior may be confusing for some users and probably hurts adoption, as it makes it difficult to go from a working store with its own custom service interactions to a working store that uses feathers-vuex, since they are silently incompatible.
Proposal
I'd like to propose adding a flag to the vuexOptions object (perhaps respectExisting) that would instruct new service-modules to take on the state/getters/actions/mutations of any modules with the same resolved namespace that exist in the store.
I've made a POC: https://github.com/jskrzypek/feathers-vuex/compare/feat-array-namespaces...feat-respect-existing (this is based on my PR #35)
Alternatives
The other possible fix I can think of would be to automatically nest the service module on the existing module, though this can result in unpredictable namespaces.
What do you think?

Maybe feathers-vuex services can be prepended by and underscore or something like that?
Although a solution like that is not very elegant...

That's not the best because then it would make it more awkward for consumers to use in the simple example where they have no custom modules, etc.
One reason I thought about this issue was that I find the current solution with the customActions, etc added to the options passed to the service or the global modules options to be awkward and hard to maintain.
Right now to use feathers-vuex alongside custom modules or to add actions/getters/mutations/state right now we have to migrate all of our store modules and logic moving out of the clean structure dictated by vuex and into wherever we are calling the feathersVuex plugin.
I want to be able to manage the rest of my store as normal and then slowly add logic that exposes or integrates the actions/getters/mutations/state that feathers-vuex builds for my services.

Maybe you can rename the modules that you already have until you fully migrate to this solution.
Other problem is that you have to be careful of not naming a store module like one of your services.

@ellipticaldoor I found a way around that specific problem, you currently can give specific namespaces to feathers-vuex before it clobbers your existing modules, you just need to do it in the initial call to feathers-vuex.
you can do it like this:
const feathersClient = feathers()
  .configure(hooks())
  .configure(socketio(socket))
  .configure(auth({ storage: window.localStorage }))
  .configure(rx(RxJS, {idField: '_id'}))
  .configure(feathersVuex(store, {
    idField: '_id',
    auth: {
      userService: '/users'
    }
  }, {
    'messages': { namespace: 'feathersMessagesServiceModule' },
    'users': { namespace:  'feathersUsersServiceModule' }
  }))

or to illustrate the arguments to feathersVuex better:
const feathersVuexOptions = {
  idField: '_id',
  auth: {
    userService: '/users'
  }
}

const feathersVuexModules = {
  'messages': 'feathersMessagesServiceModule', // or { namespace: 'feathersMessagesServiceModule'  },
  'users': 'feathersUsersServiceModule' // or { namespace:  'feathersUsersServiceModule' }
}

const feathersClient = feathers()
  .configure(hooks())
  .configure(socketio(socket))
  .configure(auth({ storage: window.localStorage }))
  .configure(rx(RxJS, {idField: '_id'}))
  .configure(feathersVuex(store, feathersVuexOptions, feathersVuexModules))

I've released the 1.0.0 beta, which include the ability to customize the store and fixes the "clobbering" of state, etc.  Please check out the details here: https://github.com/feathersjs/feathers-vuex/issues/40.  I'm closing this issue.  Feel free to reopen after trying the new version, if needed.


Adds new example NN API. Removes old.

fixes #259

by snapshotting do you mean checkpointing? that will be done every N steps or every so many minutes - not every step.
I think the printing backoff isn't working because TF's tensor.data() is actually synchronous, same for DL CPU. It probably only happens when using webgl. However, given that we can't test it, I've removed that code.
I've also updated the maxSteps to 3k.
Another important point is that this network hasn't been tested on GPU yet - while nn_example has.. Ideally this example would default to using GPUs without additional code.


Property $app with generic class Slim\App does not specify its types: TContainerInterface

Following this PR https://github.com/slimphp/Slim/pull/3322, PHPStan is yelling on one of our project.
The error is:

Property Tests\OurProject\BaseTestCase::$app with generic class Slim\App does not specify its types: TContainerInterface

Here is the code:
<?php

namespace Tests\OurProject;

use PHPUnit\Framework\TestCase;

class BaseTestCase extends TestCase
{
    /** @var \Slim\App */
    protected $app;

    protected function setUpApp(bool $mockedClient = false): void
    {
        $this->app = require __DIR__ . '/../src/App.php';

PHPStan throw that error on the line protected $app;.
What type or change I need to apply to resolve it?
Poke @limarkxx

As App has a getContainer(): ?ContainerInterface method, the generic doc block enables you to specify what type is actually returned when this method is called. i.e. if you are using PHPDI and write:
$container = $this->app->getContainer();
$entries = $container->getKnownEntryNames();

PHPStan has no way of knowing that $container is an instance of PHPDI which has a getKnownEntryNames() method and so will complain.
To tell PHPStan this we change: /** @var \Slim\App $app */ to /** @var \Slim\App<DI\Container> $app */ and now PHPStan knows this.
If you want to use just PSR ContainerInterface methods, then you hint as /** @var \Slim\App<\Psr\Container\ContainerInterface> $app */
If you are not using a container at all, then hint with: /** @var \Slim\App<null> $app */

Awesome, thanks for that great explanation.
I'm not so familiar with template & generics.


CQA Retrieval Tasks file loading error

Beir==2.0.0
mteb==1.1.0
INFO:mteb.evaluation.MTEB:Loading dataset for CQADupstackEnglishRetrieval
INFO:beir.util:Unzipping cqadupstack.zip ...
ERROR:mteb.evaluation.MTEB:Error while evaluating CQADupstackEnglishRetrieval: File is not a zip file

Hm works fine for me: https://colab.research.google.com/drive/18XXbYxYwHAV4sBIT_vO_WhRpGLGkN_f5?usp=sharing
maybe a corrupted download & just need to delete & retry

Yep, it worked but for those that will face it make sure that you delete it from the cache as well.


Fix package name

Proposed changes
Unable to install pacakage with the name github.com/deepgram-devs/deepgram-go-sdk, the package is internally named as go-sdk instead of ddepgram-go-sdk as per the github repository.
Types of changes
What types of changes does your code introduce to the Vonage for Visual Studio Code extension?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update or tests (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Further comments
Let me know if this change is valid. Or any other alternatives are considered.

@Mr-Destructive This is a good idea. Thanks for the contribution. Are you ready for it to be reviewed or do you want it to stay in Draft status?


Add system integration test for onboarding

Adds a system test for onboarding the 10101 lightning wallet from an external lnd node.
This will also help us to ensure that we stay compatible with lnd in the future.
I've replaced the chopsticks faucet with our proxy faucet as we will also need to reach lnd and it doesn't make sense to use different faucets for that. However, we can't simply remove chopsticks yet, as it also initialises the regtest network with a wallet and blocks.
resolves #170

bors r+

bors retry

I guess for this test to run on github actions we need to address the macaroons.db. It shouldn't be mounted directly for two reasons.

It will make your workspace dirty everytime you run docker-compose up
Github Actions seems to mount the file in a special way, which will results into the error shown below.

lnd           | 2023-02-27 09:28:09.993 [INF] CHDB: Swapping old DB file from /root/.lnd/data/chain/bitcoin/regtest/temp-dont-use.db to /root/.lnd/data/chain/bitcoin/regtest/macaroons.db
lnd           | 2023-02-27 09:28:09.993 [ERR] LTND: Shutting down because error in main method: unable to open databases: unable to obtain database backends: error opening macaroon DB: rename /root/.lnd/data/chain/bitcoin/regtest/temp-dont-use.db /root/.lnd/data/chain/bitcoin/regtest/macaroons.db: device or resource busy
lnd           | unable to open databases: unable to obtain database backends: error opening macaroon DB: rename /root/.lnd/data/chain/bitcoin/regtest/temp-dont-use.db /root/.lnd/data/chain/bitcoin/regtest/macaroons.db: device or resource busy

I guess for this test to run on github actions we need to address the macaroons.db. It shouldn't be mounted directly for two reasons.
1.  Github Actions seems to mount the file in a special way, which will results into the error shown below.

lnd           | 2023-02-27 09:28:09.993 [INF] CHDB: Swapping old DB file from /root/.lnd/data/chain/bitcoin/regtest/temp-dont-use.db to /root/.lnd/data/chain/bitcoin/regtest/macaroons.db
lnd           | 2023-02-27 09:28:09.993 [ERR] LTND: Shutting down because error in main method: unable to open databases: unable to obtain database backends: error opening macaroon DB: rename /root/.lnd/data/chain/bitcoin/regtest/temp-dont-use.db /root/.lnd/data/chain/bitcoin/regtest/macaroons.db: device or resource busy
lnd           | unable to open databases: unable to obtain database backends: error opening macaroon DB: rename /root/.lnd/data/chain/bitcoin/regtest/temp-dont-use.db /root/.lnd/data/chain/bitcoin/regtest/macaroons.db: device or resource busy

@holzeis : I've fixed it by removing the macaroons. See the commit messages :)

@luckysori / @da-kami : would be cool if one of you could give this a try locally so that we can get it merged :)

The added test passes for me locally with:

Fresh docker container pull of the complete environment after removing everything.
Calling curl -d '{"address":"bcrt1qylgu6ffkp3p0m8tw8kp4tt2dmdh755f4r5dq7s", "amount":"0.1"}' -H "Content-Type: application/json" -X POST http://localhost:3000/faucet after 10 secs wait
Running the test.

Note that the mulit-hop test failed:
test tests::dlc_collaborative_settlement::given_dlc_channel_present_when_dlc_settled_collaboratively_then_sibling_channel_operational ... ok
test tests::dlc_non_collaborative_settlement::given_dlc_channel_present_when_dlc_settled_non_collaboratively_then_sibling_channel_operational ... ok
test tests::single_hop_payment::single_hop_payment ... ok
test tests::multi_hop_payment::multi_hop_payment ... FAILED
test tests::just_in_time_channel::just_in_time_channel ... ok
test tests::add_dlc::given_lightning_channel_then_can_add_dlc_channel ... ok
test tests::onboard_from_lnd::onboard_from_lnd has been running for over 60 seconds
test tests::onboard_from_lnd::onboard_from_lnd ... ok

I can provide the logs, but I think this failure is unrelated to this PR.

@da-kami : did you also try to use the faucet manually?

@da-kami : did you also try to use the faucet manually?

I did the three steps I listed https://github.com/get10101/10101/pull/173#issuecomment-1449322383 - and I think step two is calling the faucet manually. Or are you referring to something else?
I tried to replicate what the ci action does locally.

Right, then my question doesn't matter :)
bors r+

bors retry

I've fixed the startup of the containers. Looks like -d was removed by accident.
bors retry


add force redirect from HTTP to HTTPS

http://www.paulirish.com/2010/the-protocol-relative-url/

Just so you know, HTTPS breaks the weather example. :disappointed:
A current workaround is to access that example over HTTP, but forcing the redirect would make that untenable. (That particular example is also non-trivial to fix because the free version of the OpenWeatherMap API only works over HTTP. :sob: )
I'm not sure if there are any other examples that fetch resources from other sites over HTTP, but those might break too.
Also, if anyone wants to tinker with the example snippets in ways that might cause mixed-content warnings when p5js.org is on HTTPS, then their tinkering would fail as well. We ran into this kind of problem a lot when Thimble was hosted over HTTPS, and I think it's part of why a lot of tinkering sites like JS Bin and CodePen remain served over HTTP to this day (though I could be wrong).


WIP: This doesn't pass tests but starts a discussion about issue #547

Fixes #547
Problem: The Uri parser doesn't demand the entire input satisfy the Uri criteria causing invalid uri's to truncate to "" which appears to be a valid Uri (at least by the parser rules).
Solution: This is solved by adding the EOI rule to the end of the parsers requiring the parser to consume all the input to be valid.
This breaks two tests in UriParserSpec: they allow invalid and invalid uri or query to essentially truncate to the valid portion. This seems wrong to me.

It's another discussion of strict vs. lenient.  Imagine a request comes in with such a malformed query string: should the server say that's a 400, or should the service get a chance to try to recover?

Also, looks like a candidate for a v0.12.4 to me.

What do we want to do in this situation? I think its generally a bad idea to try and guess what someone really wanted when they send bad data: robust recovery is usually case specific.
+1 to this being v0.12.4, it was just simpler to throw it up against master for now.

I think I'm okay making this a 400.  I was imagining that services could try to recover gracefully, but we need to pass some URI down to them... and now we're deciding.

Alright, I'll change those tests to 'require a failure' and re-target this against a v0.12.4 branch.

Note: See https://github.com/http4s/http4s/tree/release-0.12.4

Closed by 538d3e771ff8c73b92a133a6c6e7b73e17be2f96


mup setup error

Hey,
I started getting this error as soon as I run mup setup:
/usr/local/lib/node_modules/mup/node_modules/cjson/index.js:223
        throw err;
        ^

SyntaxError: Unexpected token '
' at 1:2
{

 ^
File: "/Users/username/Projects/mtr-app/private/mup.json"
    at SyntaxError (native)
    at Object.parseJSON (/usr/local/lib/node_modules/mup/node_modules/cjson/node_modules/json-parse-helpfulerror/node_modules/jju/lib/parse.js:732:13)
    at Object.parse (/usr/local/lib/node_modules/mup/node_modules/cjson/node_modules/json-parse-helpfulerror/index.js:10:13)
    at Object.exports.parse (/usr/local/lib/node_modules/mup/node_modules/cjson/index.js:90:28)
    at Object.load (/usr/local/lib/node_modules/mup/node_modules/cjson/index.js:220:24)
    at Object.exports.read (/usr/local/lib/node_modules/mup/lib/config.js:12:25)
    at Object.<anonymous> (/usr/local/lib/node_modules/mup/bin/mup:20:23)
    at Module._compile (module.js:435:26)
    at Object.Module._extensions..js (module.js:442:10)
    at Module.load (module.js:356:32)

Any ideas what this could mean? Thanks!

I'm getting some similar. I run mupx init and got this error:
Errors prevented startup:
While building the application:
error: Syntax error in mup.json

Anything I did work.

You should post your settings files here. It sounds like either a control character was typed maybe your newlines have carriage returns or something. CR vs LF?
You can also try cutting your file in repeated halfs to isolate the offending line(s). Similarly put one line/word/char at a time into a working file until you get the error and isolate the bad character.
Sometimes even notepad can help to purify or detect non Ascii chars in a text file.

Thanks @MasterJames, the solution was rewriting and removing all comments, just removing comments didn't work.

Here's an example of my mup file:
{

  "servers": [

    {

      "host": "<IP_ADDRESS>.1",

      "username": "root",

      "password": "password"
    }

  ],

  "setupMongo": true,

  "setupNode": true,

  "nodeVersion": "0.10.40",

  "setupPhantom": true,

  "appName": "app",

  "app": "/Users/username/Projects/mtr-app",

  "env": {

    "ROOT_URL": "http://app.com"
  },

  "deployCheckWaitTime": 120

}

I'm thinking you should be able to remove the square box characters.
I know Webstorm has a way to set the CR vs LF vs CR/LF (carrage return /r, line feed /n) per file.


Syntax highlighting slightly diminished?

When using this package, my syntax loses some fidelity (appears less colorful). Is there a possibility to retain the selectors from the regular C++ package shipping with Atom, while extending the feature set to C++14?
I think the changes are:

local variables and class methods now have the same color
class member variables have no distinguishing color, i.e. are "default" colored (grey in my case)

I don't know of a way to extend one syntax package with another. Could you post some example code demonstrating the differences you are seeing?

Here two screenshots comparing the regular C++ and the C++14 plugin:

I think the default highlighting isn't even entirely consistent, but with the complexity of C++, I tend to welcome any means of visual separation within the code. If in fact, you consider your plugin be more sensible in its distinction of elements, then I certainly respect that. It does fix the highlighting issues it's supposed to.

You're right that it can be difficult to be completely consistent when highlighting C++, but I can see how these additions, especially highlighting the member variables, would be nice. I will keep this in mind for future improvements.


6681:should allow for comments in bulk permissions screen

resolves #6681

#6704

Thanks, this looks awesome!  Will give it a spin and merge.

@davidwatkins73  can you please direct me where to find the change logs on waltz

Fantastic collaboration @ralphmensah and @davidwatkins73 😸

Hi @davidwatkins73 i noticed in creating a change log we get a person by using the userId (which turns out to be the email)
    public int updateRoles(String userName, String targetUserName, UpdateRolesCommand command) {
        LOG.info("Updating roles for userName: {}, new roles: {}", targetUserName, command.roles());

        Person person = personService.getPersonByUserId(targetUserName);
        if(person == null) {
            LOG.warn("{} does not exist, cannot create audit log for role updates", targetUserName);
        } else {
            ImmutableChangeLog logEntry = ImmutableChangeLog.builder()
                    .parentReference(mkRef(EntityKind.PERSON, person.id().get()))
                    .severity(Severity.INFORMATION)
                    .userId(userName)
                    .message(format(
                            "Roles for %s updated to %s.  Comment: %s",
                            targetUserName,
                            sort(command.roles()),
                            StringUtilities.ifEmpty(command.comment(), "none")))
                    .childKind(Optional.empty())
                    .operation(Operation.UPDATE)
                    .build();
            changeLogService.write(logEntry);
        }

        return userRoleDao.updateRoles(targetUserName, command.roles());
    }

this particular code breaks at line:
Person person = personService.getPersonByUserId(targetUserName);
since the user is not found in the person table.
this also happens for individual role changes.

PS: this is a user i created using the `add new user+` link in the individual user admin page

I am currently trying to use the same approach in writing the changelog to the changelog table

Hey @davidwatkins73 and @JWoodland-Scott 👋🏻
Would you mind taking a look at the following comment raised by @ralphmensah as he's super eager to move forward with the pull request and get it merged into Waltz.
https://github.com/finos/waltz/pull/6704#issuecomment-1685873202
Kind regards,
James.

Hi @ralphmensah,
Thanks for reaching out. We usually expect all users of Waltz to have a record in the person table and make an implicit join between email on person and the user_name on user. However, as you point out, this doesn't always work particularly well when users are created through the UI.
You could fix this short term by adding the person record in for the user; long term we already have an existing issue #6477 which looks to better improve this process and link the two data points together.
As the edit/owner permissions are a combination of the person's involvement to the entity and the roles a user may have (not dependent on the entity), these two will stay connected. Hence the changelog often links back to the person record and when displaying in the 'Changes' section we try to look up the person record for the change.

Hi @ralphmensah,
Thanks for reaching out. We usually expect all users of Waltz to have a record in the person table and make an implicit join between email on person and the user_name on user. However, as you point out, this doesn't always work particularly well when users are created through the UI.
You could fix this short term by adding the person record in for the user; long term we already have an existing issue #6477 which looks to better improve this process and link the two data points together.
As the edit/owner permissions are a combination of the person's involvement to the entity and the roles a user may have (not dependent on the entity), these two will stay connected. Hence the changelog often links back to the person record and when displaying in the 'Changes' section we try to look up the person record for the change.

thanks for the reply. This provided in depth knowledge on what exactly needed to be done, Kindly review my latest commit

Sorry for the delay in getting back to you.
@ralphmensah are you happy with what needs to be done on this? More than happy to jump on a call/screenshare if you'd like to go through in more detail.

Thanks for the reply, kindly review my latest commit

Changes look great.  We will merge this and demo to the team that requested it.  Will let you know if they have any feedback.


Header change CL/sycl to sycl/sycl

Existing Sample Changes
Description
Change all  the headers from CL/sycl.hpp to sycl/sycl.hpp
Fixes Issue#
External Dependencies
Type of change

[X] Implement fixes for ONSAM Jiras

How Has This Been Tested?

[X] Command Line

report error msg: sycl/sycl.hpp file not found
In file included from /home/intel/test/oneAPI-samples/AI-and-Analytics/End-to-end-Workloads/LidarObjectDetection-PointPillars/src/pointpillars/anchorgrid.cpp:18:
/home/intel/test/oneAPI-samples/AI-and-Analytics/End-to-end-Workloads/LidarObjectDetection-PointPillars/include/pointpillars/anchorgrid.hpp:20:10: fatal error: 'sycl/sycl.hpp' file not found
#include <sycl/sycl.hpp>
^~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [CMakeFiles/LidarObjectDetection-PointPillars.dir/build.make:63: CMakeFiles/LidarObjectDetection-PointPillars.dir/src/pointpillars/anchorgrid.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:105: CMakeFiles/LidarObjectDetection-PointPillars.dir/all] Error 2
make: *** [Makefile:84: all] Error 2


Align log with execution apis

Signed-off-by: nikolay<EMAIL_ADDRESS>Description:

Related issue(s):
Fixes #

https://github.com/hashgraph/hedera-json-rpc-relay/issues/337

Notes for reviewer:

Checklist

[ ] Documented (Code comments, README, etc.)
[x] Tested (unit, integration, etc.)

Codecov Report

Merging #343 (2289b56) into main (bbc34c6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #343   +/-   ##
=======================================
  Coverage   62.29%   62.29%
=======================================
  Files           9        9
  Lines         870      870
  Branches      142      142
=======================================
  Hits          542      542
  Misses        290      290
  Partials       38       38

Impacted Files
Coverage Δ

packages/relay/src/lib/eth.ts
64.25% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbc34c6...2289b56. Read the comment docs.


Dependencies in lower case so Bower installs them too

Normally installing a component will install its dependencies too, and apparently bower.json is case-sensitive so normalize doesn't get installed.

And I forgot to mention, bower install boneless isn't working since the package name is already taken. Have you registered the package yet?

Hey @diagramatics thanks for that pick up, and I am not 100% sure on whether we have registered this yet, as we haven't really finalised it. @whatsnewsaes Have you registered this yet?

Running bower search boneless shows only one from rish/boneless, which is sadly name-squatted.

Yeah i just did the same search, I'll have a chat with @whatsnewsaes about this, and how we should move forward, though I will merge in this PR and open up a new issue to discuss this further


enable read of README.rst without Unicode error in py3

Fixes #127

when to merge this ?

soon please?


What is the orientation of files in the anat output directory?

I assume it is the dwi data orientation. Could you confirm?

T1w and derived images retain the voxel grid of the original T1w image. As of 0.5.0 it's actually the DWI data that are transformed to overlap the T1w information, not the other way around as it was previously (since the T1w is more likely to be used as the central reference in multi-tool / multi-modality workflows). But that's a purely rigid-body translation that is applied to the image header; no re-gridding takes place.
So there's no guarantee of common orientation between the T1w and DWI image axes. The only guarantee is that upon selecting any arbitrary location in scanner space, and independently transforming that location into voxel coordinates in the T1w and DWI data, you should be sampling image data from the same biological location. This is fine for tractography since sampling data from the FOD image and the 5TT image are entirely independent, so there's no issue with the scanner2voxel transformations being different.

Thanks for the explanation. Very useful.
But ... I'm actually still using 0.4.2 :-) How do things work there?

T1w was transformed to align with DWI rather than the other way around; but still only a rigid-body transformation altering the image header.


Add support for the X-Robots-Tag noml header

See https://noml.info/
diff --git a/README.md b/README.md
index 12fd5e6..f9b65d1 100644
--- a/README.md
+++ b/README.md
@@ -21,7 +21,7 @@ For better performance, it's highly recommended to set up a fast dns resolver, s

 ## Opt-out directives

-Websites can pass the http headers `X-Robots-Tag: noai`, `X-Robots-Tag: noindex` , `X-Robots-Tag: noimageai` and `X-Robots-Tag: noimageindex`
+Websites can pass the http headers `X-Robots-Tag: noai`, `X-Robots-Tag: noindex` , `X-Robots-Tag: noimageai` , `X-Robots-Tag: noimageindex` and `X-Robots-Tag: noml`
 By default img2dataset will ignore images with such headers.

 To disable this behavior and download all images, you may pass --disallowed_header_directives '[]'
diff --git a/img2dataset/main.py b/img2dataset/main.py
index 94f32df..bc71418 100644
--- a/img2dataset/main.py
+++ b/img2dataset/main.py
@@ -111,7 +111,7 @@ def download(
 ):
     """Download is the main entry point of img2dataset, it uses multiple processes and download multiple files"""
     if disallowed_header_directives is None:
-        disallowed_header_directives = ["noai", "noimageai", "noindex", "noimageindex"]
+        disallowed_header_directives = ["noai", "noimageai", "noindex", "noimageindex", "noml"]
     if len(disallowed_header_directives) == 0:
         disallowed_header_directives = None

I think it would be fair to respect noml as well as noai. Of course, it is just a proposal, but there is almost no cost if this gets implemented.
On the other hand, it could be argued that the typical use case for this piece of software is not to crawl for search engines, so perhaps consider removing noindex and noimageindex from the default set? Of course, I can see people who advocate opt-in instead of opt-out (#293) getting even more angry with such change.


openh264: 2.3.0 -> 2.3.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/cisco/openh264/releases.
meta.description for openh264 is: "A codec library which supports H.264 encoding and decoding"
meta.homepage for openh264 is: "https://www.openh264.org"
meta.changelog for openh264 is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.3.1 with grep in /nix/store/b79z59gh7anq36flc6z7an5l58dawkf8-openh264-2.3.1
found 2.3.1 in filename of file in /nix/store/b79z59gh7anq36flc6z7an5l58dawkf8-openh264-2.3.1

Rebuild report (if merged into master) (click to expand)

676 total rebuild path(s)

676 package rebuild(s)

First fifty rebuilds by attrpath
ChowKick
MIDIVisualizer
adapta-gtk-theme
alfaview
alfis
almanah
amberol
apostrophe
aravis
arcanPackages.all-wrapped
arcanPackages.arcan
arcanPackages.arcan-wrapped
arcanPackages.durden-wrapped
arcanPackages.ffmpeg
arcanPackages.pipeworld-wrapped
arcanPackages.prio-wrapped
arcanPackages.xarcan
ashpd-demo
astroid
audio-recorder
authenticator
aws-workspaces
bada-bib
balsa
banking
baobab
baresip
bespokesynth
bespokesynth-with-vst2
birdfont
blanket
bookworm
bottles
brasero
brasero-original
bubblemail
byzanz
cadence
calls
cambalache
cargo-tauri
cawbird
celluloid
chatty
chrome-gnome-shell
cinnamon.cinnamon-common
cinnamon.cinnamon-control-center
cinnamon.cinnamon-gsettings-overrides
cinnamon.cinnamon-screensaver
cinnamon.pix

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/b79z59gh7anq36flc6z7an5l58dawkf8-openh264-2.3.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A openh264 https://github.com/r-ryantm/nixpkgs/archive/5e54883ea53a6635cb0035ba122c66441a34a7d8.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/b79z59gh7anq36flc6z7an5l58dawkf8-openh264-2.3.1
ls -la /nix/store/b79z59gh7anq36flc6z7an5l58dawkf8-openh264-2.3.1/bin

Pre-merge build results
NixPkgs review skipped

Maintainer pings

@ofborg eval

@GrahamcOfBorg eval


Mods system rework

Notes from Bob:

mods need to pull from 2 folders, local (user-installed) and remote (auto-installed)
local should be down to user preference (though, will need to be disabled on server join if not compatible with server we're joining), remote should be disabled until required server join, then enabled, then disabled again on leave
we need to move more of the server required mod loading/unloading to native as well, loading is currently in script and unloading doesn't quite exist yet, but both should be more native
a couple more assets also can't currently be reloaded at all at runtime well, not super required for autodownloading to work at all, but specifically being able to properly unload/reload weapon/playersettings/etc scripts would be very nice, and potentially models too though this seems very unlikely since it doesn't like valve source can do it

https://discord.com/channels/920776187884732556/1025040519560167514/1060355733981503609

TODOs
Directories architecture

[x] Use mods from local and remote directories (#403)
[x] Put auto-downloaded mods into remote mods directory (#545)
[x] Use thunderstore mod string as folder name so that we can have different versions at the same time (#535)

Dynamic mod activation

[x] Add new mods entries to enabledmods.json if needed (#410)
[ ] Enable mod only when joining server
[ ] Disable mod when leaving server
[ ] Dynamically reload mods' assets (weapons/models/playersettings)

Miscellaneous

[ ] Display a warning message (on UI) with malformed mods (#415)

Work on mod system has been split between #746 and https://github.com/R2Northstar/NorthstarLauncher/pulls?q=is%3Aopen+is%3Apr+label%3AMAD, closing this.


Connection to CRM is cached in onpremise using AD authentication

Connect to a crm organization
Run the who am I command
Note down the org, BU, userid etc
Use a different connectionstring
Run the who am I command
It still shows the first org details

Both orgs are onpremise and hosted on the same server.

Hi Ganesh,
the previously opened connection is reused, I guess to improve performance.
Just add „RequireNewInstance=true“ to your connection string and the world suddenly is a better place (phun intended).
See here for further details: https://msdn.microsoft.com/en-us/library/mt608573.aspx#Parameters
Best,
Norbert

On 23. Mar 2018, at 09:52, gceganesh<EMAIL_ADDRESS>wrote:
Connect to a crm organization
Run the who am I command
Note down the org, BU, userid etc
Use a different connectionstring
Run the who am I command
It still shows the first org details
Both orgs are onpremise and hosted on the same server.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Got it figured already.... Got a bit confused that crm still maintains the
connection even after you call the ServiceClient.Dispose
On Fri, 23 Mar 2018, 23:49 iNSidemen<EMAIL_ADDRESS>wrote:

Hi Ganesh,
the previously opened connection is reused, I guess to improve performance.
Just add „RequireNewInstance=true“ to your connection string and the world
suddenly is a better place (phun intended).
See here for further details:
https://msdn.microsoft.com/en-us/library/mt608573.aspx#Parameters
Best,
Norbert

On 23. Mar 2018, at 09:52, gceganesh<EMAIL_ADDRESS>wrote:
Connect to a crm organization
Run the who am I command
Note down the org, BU, userid etc
Use a different connectionstring
Run the who am I command
It still shows the first org details
Both orgs are onpremise and hosted on the same server.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/WaelHamze/xrm-ci-framework/issues/96#issuecomment-375818419,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXGgrCPuKlkhPBEYG_bAsxMp8GazWp6fks5thXwKgaJpZM4S4wJJ
.


[6.2] HHH-16172 BasicCacheKeyImplementation must be public to support externalization.

https://hibernate.atlassian.net/browse/HHH-16172
Original HHH-16172 fix neglected to make this class public so that it can be instantiated outside the org.hibernate.cache.internal package.

@Sanne FYI

Thanks @pferraro !


Add name as an alias for display_name

Pull Request Type

Feature addition

Description
Purpose of the PR is to give a shorter version of display_name. I was considering other options first, like "dname", but was thinking what of this name actually is. It's just someone's name and name isn't used by anything else. I can't think of a better purpose for it, and both "name" and "username" together makes sense to me.
Changes

Added name property to interactions/models/discord/user.py (and user.pyi)

I'd argue name is extremely vague if you didn't know it was an alias of display_name - I know many people would just consider it an alias of username or tag instead.
Plus, I'm against added aliases like this in general. There's a purpose to aliases (largely when names can be spelt differently across different variants of English), but short aliases like this feel unnecessary when you can do name = user.display_name if you really needed a short name.
I'm against this PR, but I'll let other contributors decide.

I'd argue name is extremely vague if you didn't know it was an alias of display_name - I know many people would just consider it an alias of username or tag instead.
Plus, I'm against added aliases like this in general. There's a purpose to aliases (largely when names can be spelt differently across different variants of English), but short aliases like this feel unnecessary when you can do name = user.display_name if you really needed a short name.
I'm against this PR, but I'll let other contributors decide.

Agreed

I'm also against this alias since name alone would be ambiguous here. It could be any of nickname, global_name, and username (actual fields in the Discord API). Or library-defined fields display_name and tag. The current display_name is good enough because it states its specific meaning: name as displayed by the Discord client.


Separate media type for STAC?

Do we need a way to distinguish links to STAC and OGC API - Records somehow?
A link to a STAC JSON file with relation type child looks exactly like a link to OGC API - Records, although they are not fully compatible. They both would look as follows:
{
  "href": "./catalog.json",
  "rel": "child",
  "type": "application/json"
}

I could see a world where STAC and Record JSON files will be mixed in one catalog (actually, I'm currently working on a project that would benefit from it).
The only way I could distinguish them right now consistently, is probably to load the files and check whether stac_version is present (STAC) or not (=> likely Records, but could also be something else).
Thoughts?
Records is adding explicit media types: https://github.com/opengeospatial/ogcapi-records/issues/276
Should we also add explicit media types that could be used? application/stac+json?

How would this work for Items, which are currently application/geo+json? Changing that type (which is auto-detected by tooling e.g. for display) would remove functionality we currently get for free.

Maybe the better way is application/geo+json; application=stac-item and  application/json; application=stac-collection etc? That at least keeps the main media type (although I'm sure many implementations don't parse media types and only compare strings for equallity).

(although I'm sure many implementations don't parse media types and only compare strings for equallity). [sic]

Yeah this is a downside, I usually just see == in tooling when checking media types.
One benefit of application/json; application=stac-collection is you can actually know (probably) whether you're getting a collection or catalog when you're resolving a child.

We want to have a discussion about this so we can close and have some sort of clear statement regarding our stance on this.

Should mention somewhere (best practices) that if you mix OGC API Records and STAC that clients cannot tell from the type alone if the target is a STAC Item or an OGC Record.

Not sure where this left off in the sprint. can we arbitrarily and legitimately add a profile to a media type, e.g., application=stac-collection ?

I think we concluded that media types are difficult to extend for us. Maybe Records gets a separate media type or we just use an additional field to indicate it? Ultimately, you'd not need it anway if STAC is a profile of Records....

Explicit types for STAC would be amazing!
Currently, many processes return application/geo+json without distinction.
For backward compatibility of servers expecting and already supporting this type, I believe application/geo+json; application=stac-item and application/json; application=stac-collection are more appropriate than application/stac+json.

Changing the media type in 1.1 is likely breaking in a lot of implementations, as such we need to to this in 2.0.
Here's a related discussion on the do and don'ts: https://github.com/opengeospatial/ogc-feat-geo-json/issues/129


Monthly rfc5545 mapping needs a BYSETPOS

If, for example, a transaction initially occurred on 29/Jan and was set to repeat monthly the next occurrence should be the last day of Feb and BYSETPOS makes it easy (BYMONTHDAY=28,29,30,31;BYSETPOS=-1 ) to select the last valid day.

I added the invalid label as the examples were recently removed but we'll want to add them back in at some point in the future.
Closing this ticket for the time being.


Added Prolog Implementation of Einstein Puzzle

A question about your repo, how do you change the name a folder from Prolog to Prolog/warreee if there is only one subfolder in a language folder?
Thanks

how do you change the name a folder from Prolog to Prolog/warreee if there is only one subfolder in a language folder?

GitHub does that automatically if there's only one subfolder in a folder. And it doesn't change the name of the folder itself, if you hover one of these shortcuts, a tooltip will say "This path skips through empty directories". The folders are still there GitHub just saves you some extra clicks.

Yeah, it's just a visual and UX delicacy on Github's front-end. Forgot when they added it but it caused a hiccup in my thoughts as well lol, then I discovered there was no real change when I pulled the repo.


Relnotes fine-tuning

Changes made by this PR:

Swapped Win32 & WinRT links.
Removed spurious horizontal rule.
Moved member lists into tabs.
Added WinRT 1369-prerelease drag/drop interop links.
Normalized whitespace.

Learn Build status updates of commit 3205cf7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/release-notes.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 59819fa:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/release-notes.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


{ polymorphic: true } breaks when opting in to isNewSerializerAPI

My code and api looks like this:
// car.js
export default DS.Model.extend({
  engine: DS.belongsTo('foo', { async: true, polymorphic: true })
});

//engine.js
export default DS.Model.extend();

// vee-eight-engine.js
export default Engine.extend();

"car": [{
   "engine": { "id": 1, "type": "veeEightEngine" }
}]

This fixed it for me:
"car": [{
   "engine": { "id": 1, "type": "veeEightEngine" }
}]

should be
"car": [{
   "engine_id": { "id": 1, "type": "veeEightEngine" }
}]

@martndemus thank you for posting solution.
I have a strange issue with records duplication http://i.imgur.com/8czceUn.gif (http://i.imgur.com/8czceUn.gif)
did you face something like that?


fix getRpcport bug

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.qizheng09 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Do windowing in the Fn API runner itself.

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage decreased (-0.01%) to 69.546% when pulling 54c8a597c0635560afbdbfb1b1f33cb8a4d3b81f on robertwb:fn-api-windowing into a92c45f9347e326e71afdc9057cac7e053b6c3e6 on apache:master.

LGTM, thanks Robert!


Allow to register common transformation

When a model and a facade implements an interface like TimestampableInterface, BlameableInterface, it would be great to have the corresponding transformation process.
It could be done with a trait to use or a component which handle those transformations.

This will worsen the transformation readability, we are not going to do it


refactoring method getBlock()

Description
Renamed getBlock(String blockId) to getActiveBlock(String blockId) since it's only getting active block via its blockId. Making this refactor to prepare for a new function getHiddenBlock() for feature - adding hidden questions to pdf.
Checklist
General
Read the full guidelines for PRs here

[x] Added the correct label: < feature | enhancement | bug | dependencies | infrastructure | ignore-for-release | database >
[x] Assigned to a specific person, civiform/developers, or a more specific round-robin list.
[ ] Created unit and/or browser tests which fail without the change (if possible)
[x] Performed manual testing (Chrome and Firefox if it includes front-end changes)
[ ] Extended the README / documentation, if necessary

Instructions for manual testing
If instructions are needed for manual testing by reviewers, include them here.
Issue(s) this completes
Part of #6288

please either remove or update the release notes section of the PR description
add the ignore-for-release tag since this does not change behavior

removed the released notes section. added ignore-for-release tag.


feat(poll angular $digest) waitForAngular insufficient for complex apps

I have an open issue on ngScenario which I think applies to protractor as well. Our app has a lot of asynchronous processing (via socket.io) and lazy-loaded states/code via ui-router, as far as I can tell waitForAngular() really only waits for angular processing and $http requests to idle. At least when I try to test our login (which works under karma/ngScenario with the polling function I implemented in the pull request) it sporadically fails under protractor:
// from our testing library:
module.exports.login = function login(username, password, expectFail) {

   var ptor = protractor.getInstance();

   it('should ' + (expectFail ? 'not ' : '') + 'log in', function() {
      console.log('login', username + '/' + (password || "''"));

      // navigate to '/' and wait for the login
      ptor.get('/');

      ptor.waitForAngular();

      element(by.model('user.name')).sendKeys(username);
      if (password) element(by.model('user.password')).sendKeys(password);

      element(by.id('login-button')).click();

      ptor.waitForAngular();

      if (expectFail) {
         expect(element(by.id('login-failed-alert')).getText()).toBeTruthy();
      } else {
         expect(element(by.xpath('//div[@wt-embed="AppLauncher"]'))).toBeTruthy();
         expect(element(by.id('logout-menu-item'))).toBeTruthy();
      }
   });
}

With the ptor.waitForAngular() calls I can get the logins to pass 2/3rds of the time, without them it seldom passes.
For complex cases like this I think polling on $digest with positive success and failure cases and a timeout is probably the best way to go (though I'd be glad to hear of a simpler solution). How hard would this be to add to protractor?

Ping. Running into a similar issue as described in this ticket. Doesn't seem to have gotten any follow up to @yxh10 's question in September. Any word?

@bvaughn Hi Brian. I have been following ng-conf. Seems that zone.js is gonna be used in Angular 2. It looks really awesome. I assume it has not been updated because it is ready for production, and Angular team may not see the need to add more features for @btford. But that is just my guess. :)

Thanks for the updated info.

You are welcome! :) @bvaughn


Exclude not working in the Vitest Workspace Config

Describe the bug
When adding a test.exclude at the workspace level, it is ignored. However, if I put the same `test.exclude at the package level in a vitest config, it works.
Reproduction
https://stackblitz.com/edit/github-xucvwt?file=vitest.workspace.ts,packages%2Fclient%2Ftest%2Fmemory2048.test.ts
System Info
npx envinfo --system --npmPackages '{vitest,@vitest/*,vite,@vitejs/*}' --binaries --browsers

  System:
    OS: macOS 14.5
    CPU: (12) arm64 Apple M2 Max
    Memory: 263.83 MB / 64.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.15.1 - ~/.volta/tools/image/node/20.15.1/bin/node
    Yarn: 1.22.19 - ~/.volta/bin/yarn
    npm: 10.8.2 - ~/.volta/tools/image/npm/10.8.2/bin/npm
  Browsers:
    Chrome: 127.0.6533.73
    Chrome Canary: 123.0.6270.0
    Edge: 127.0.2651.98
    Safari: 17.5
  npmPackages:
    @vitest/coverage-v8: ^2.0.5 => 2.0.5
    vitest: ^2.0.3 => 2.0.4

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

None of the configuration options are inherited from the root-level config file.
https://vitest.dev/guide/workspace.html#configuration

Okay, but shouldn't this
{
    test: {
      exclude: [...configDefaults.exclude, 'test/memory2048.test.ts'],
    },
  },

prevent test/memory2048.test.ts from running when ran from the root level?

No, that just creates a new project with that setting. It's not applied to other projects.
This would work:
import { defineWorkspace, configDefaults } from 'vitest/config';

export default defineWorkspace([
  {
    extends: './packages/client/vitest.config.ts',
    test: {
      name: 'Client',
      root: './packages/client',
      exclude: [...configDefaults.exclude, 'test/memory2048.test.ts'],
    },
  },
  {
    test: {
      name: 'Server',
      root: './packages/server',
      exclude: [...configDefaults.exclude, 'test/memory2048.test.ts'],
    },
  },
]);

Ah, okay, I misunderstood how that config worked. It seems a little burdensome to require a vitest.config at each package level with manual extension in order to support a monorepo with a shared config.

It seems a little burdensome to require a vitest.config at each package level with manual extension in order to support a monorepo with a shared config.

Yep. Any improvement ideas are welcome.
Similar issue came up here too: https://github.com/vitest-dev/vitest/discussions/6194#discussioncomment-10121949


projects.yml

Currently, eslint-canary seems to use projects.yml of the current working directory. Is this intentional?
I tried:
$ pwd
C:\Users\t-nagashima.AD\Documents\GitHub\eslint
$ npm install -g eslint-canary
...
$ eslint-canary .
Error: ENOENT: no such file or directory, open 'C:\Users\t-nagashima.AD\Documents\GitHub\eslint\projects.yml'

Oops, that's not intentional 😕


clickhouse.com docs is partially down

Sorry for posting it here, but

Some pages are not styled:
https://clickhouse.com/docs/en/sql-reference/functions/in-functions/
I've seen some pages 404 for all page. Can't find now.

Please recheck the site.

I reverted the latest changes.


Wildcard Tokens with a lot of images don't fit on the page.

As title. Would be nice to have a scroll bar for tokens with a lot of images.

Used to be one dont know why it stoped working

Fixed in V0.1.6 thx for letting us know


Go-to setpoint type

Adds a "Go-to" setpoint type which streams a position and (optional) heading setpoint, meant to be handled by a position and heading smoother on the flight controller. Main idea: dump in whatever position and heading you want, and they will be smoothly followed by the autopilot. Additional fields for velocity and heading rate limits are included.
An example mode using the Go-to setpoint type is included:
https://github.com/Auterion/px4-ros2-interface-lib/assets/8026163/76795ebc-13b9-4637-b7f7-867e773047fa
Depends on: https://github.com/PX4/PX4-Autopilot/pull/22375
Docs: https://github.com/PX4/PX4-user_guide/pull/2935

@bkueng made quick minimal changes - but the rest i think we just do in a follow up to enable folks quickly on a working example for goto, ok for you?


runtime: specialize memhash32, memhash64

memhash32 and memhash64 are defined as:
func memhash32(p unsafe.Pointer, h uintptr) uintptr {
	return memhash(p, h, 4)
}
func memhash64(p unsafe.Pointer, h uintptr) uintptr {
	return memhash(p, h, 8)
}

The generic memhash implementation contains a lot of mechanism that can be skipped when the size is known. A quick hack up of a specialized memhash64 on amd64, with aeshash manually disabled, shows nice gains:
name                  old time/op    new time/op    delta
MapPopulate/1-8         76.7ns ± 4%    75.1ns ± 4%     ~     (p=0.055 n=10+10)
MapPopulate/10-8         613ns ± 3%     570ns ± 3%   -6.94%  (p=0.000 n=10+9)
MapPopulate/100-8       7.93µs ± 2%    7.31µs ± 3%   -7.85%  (p=0.000 n=9+10)
MapPopulate/1000-8      97.0µs ± 3%    89.1µs ± 2%   -8.20%  (p=0.000 n=10+9)
MapPopulate/10000-8      843µs ± 3%     759µs ± 2%  -10.02%  (p=0.000 n=10+9)
MapPopulate/100000-8    9.19ms ± 4%    8.69ms ± 2%   -5.38%  (p=0.000 n=10+9)

The specialized code is small, both in terms of lines of code and machine code. For non-aeshash architectures, this seems like an easy, significant win.
Leaving for someone else to implement all the way through and benchmark on a non-aeshash architecture, due to my limited cycles.
cc @martisch @philhofer @randall77

I assume that the MapPopulate benchmark only calls one of these function variants over and over. Is there a benchmark that calls all versions in a way that they are mixed?
Perhaps my understanding of caching is wrong, but I seem to recall that splitting a function into many could have costs if a program needs all variants and thus has a harder time keeping all the code cached.

I'd bet this would be an improvement regardless, but it doesn't hurt to try a mixed benchmark.

@mvdan it is correct that more binary code can generate more icache pressure however for hot code it can be a trade off that is worth it. e.g. see all the specialized map functions (which are high in the top hot code paths after garbage collection functions).
In some cases e.g. stringconcatX/memequalX it can also save stack space because the len argument is implicit in the function call and does not need to be provided and thereby safes instructions at every call site. Also the function itself is more constrained and can be simpler and needing less icache than the general version. I do not expect the memequal32/64 functions to be very large. But they are also called indirectly so wont save much at the call site. However the call to memhash itself generates some instructions that wont be needed anymore.
Note that we already inline many memcopy and other calls with direct instructions to save function call overhead and not needed size checks but bloat the binary a bit as a tradeoff. Same with inlining.
Getting back to joshs requests:
I am happy to have a look on 386/amd64. Have to work through some of the other queued up go1.10 work before :)
I have a G3220 Haswell Pentium that does not support AES (apart from a zoo of older go supported machines down to dual pentium mmx) where i tested the internal/cpu package.

@martisch I didn't mean to "assign" anything to you, just thought you might be interested. :) This is actually a good new contributor issue (thus labeled Suggested).

@josharian I did not see it as assignment ( my use of "request" was likely a bad choice ) Just wanted to express high interest, but sadly will not have time for it right away :) So anybody else who has time earlier feel free to work on it after stating interest.


Use -PrerunAllTests in RerunFlakyTest builds

Instead of previous --rerun because --rerun only works
with DistributionTest.

@bot-gradle test and merge

OK, I've already triggered a build for you.


tokens_per_minute seem not to reflect in engine

The configuration of tokens_per_minutes in settings.yaml seems not to be adapted by the indexing engine. I've tried setting it to both 50000 and 50_000 (as per the commented example) but I see the same outcome in index-engine.log = 0.
I repeatedly hit 429s, no matter what I do.
The content of settings.yaml:
llm:
  api_key: ${GRAPHRAG_API_KEY}
  type: azure_openai_chat # or azure_openai_chat
  model: gpt-4o
  model_supports_json: true # recommended if this is available for your model.
  # max_tokens: 4000
  # request_timeout: 180.0
  api_base: https://redacted.openai.azure.com/
  api_version: 2024-02-15-preview
  # organization: <organization_id>
  deployment_name: gpt4o
  tokens_per_minute: 50000 # set a leaky bucket throttle
  # requests_per_minute: 20 # set a leaky bucket throttle
  # max_retries: 10
  # max_retry_wait: 10.0
  sleep_on_rate_limit_recommendation: true # whether to sleep when azure suggests wait-times
  # concurrent_requests: 25 # the number of parallel inflight requests that may be made

contents of {run_id}\reports\index-engine.log:
    "llm": {
        "api_key": "REDACTED, length 32",
        "type": "azure_openai_chat",
        "model": "gpt-4o",
        "max_tokens": 4000,
        "request_timeout": 180.0,
        "api_base": "https://redacted.openai.azure.com/",
        "api_version": "2024-02-15-preview",
        "proxy": null,
        "cognitive_services_endpoint": null,
        "deployment_name": "gpt4o",
        "model_supports_json": true,
        "tokens_per_minute": 0,
        "requests_per_minute": 0,
        "max_retries": 10,
        "max_retry_wait": 10.0,
        "sleep_on_rate_limit_recommendation": true,
        "concurrent_requests": 25
    },
    "parallelization": {
        "stagger": 0.3,
        "num_threads": 50
    },

it seems this problem only occurs for llm.tokens_per_minutes but not for embeddings.llm.tokens_per_minutes - the setting of the latter is properly reflected in the indexlog.

It seems that no matter what I enter, the value that is leveraged by the index engine is the hardcoded one in configs\defaults.py in LLM_TOKENS_PER_MINUTE.
To prove so, I commented this line - Pydantic would complain that tokens_per_minute is not int, because it's None.
https://github.com/microsoft/graphrag/blob/daca75ff7925b93cd8b282ff067c6bdc76484e94/graphrag/config/create_graphrag_config.py#L122

I find update it to tpm and rpm in setting.yaml will work.

yes - but it seemed strange because the same key is used for llm.embeddings.tokens_per_minute and that seems to be working fine.

Hi folks!
Thanks for following up on this and providing workarounds. This has been fixed in #373
Will include it a part of the next version release, in the meantime, if you use the source directly please pull from latest main to address this.
Will leave the issue open until we release the next version.

0.2.0 is now live


Update build system

Based on https://peps.python.org/pep-0621/

Makes sense to me. Also the setup.cfg can be totally removed because setuptools automatically scans for the contents in the src folder since v61.0.0. Would probably only need the setuptools>=61 as build dependency, but I did not test this, yet.


Feature/query options

Codecov Report
Patch coverage has no change and project coverage change: -0.07 :warning:

Comparison is base (3b4f4d7) 88.90% compared to head (00b1a68) 88.84%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #5153      +/-   ##
==========================================
- Coverage   88.90%   88.84%   -0.07%
==========================================
  Files          78       78
  Lines        2911     2913       +2
  Branches      829      829
==========================================
  Hits         2588     2588
- Misses        275      277       +2
  Partials       48       48

Impacted Files
Coverage Δ

packages/react-query/src/useQuery.ts
50.00% <0.00%> (-50.00%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

from testing this, it seems like queryOptions needs to take the return type of select into account?
eg

export function fetchConfigOverridesQueryOptions(hostId: string, { suspense } = { suspense: false }) {
  return queryOptions({
    queryKey: hostQueryKeys.configOverrides(hostId),
    queryFn: () => Hosts.getConfigOverrides(hostId),
    suspense,
    select: mapOverridesToForm,
  });
}

where
export function mapOverridesToForm({ data: { overrides } }: Successful<Hosts.HostConfigOverrideResult>): FormData {

means that I get this error with a vendorized version of this PR:
Type 'UndefinedInitialDataOptions<{ data: HostConfigOverrideResult; metadata?: Metadata | undefined; }, unknown, FormData, (string | readonly [...string[], "detail", string])[]>' is not assignable to type 'UseQueryOptionsForUseQueries<{ data: HostConfigOverrideResult; metadata?: Metadata | undefined; }, Error, { data: HostConfigOverrideResult; metadata?: Metadata | undefined; }, (string | readonly [......[]])[]>'.
  Type 'UndefinedInitialDataOptions<{ data: HostConfigOverrideResult; metadata?: Metadata | undefined; }, unknown, FormData, (string | readonly [...string[], "detail", string])[]>' is not assignable to type 'Omit<UseQueryOptions<{ data: HostConfigOverrideResult; metadata?: Metadata | undefined; }, Error, { data: HostConfigOverrideResult; metadata?: Metadata | undefined; }, (string | readonly [......[]])[]>, "placeholderData">'.
    Types of property 'refetchInterval' are incompatible.
      Type 'number | false | ((data: FormData | undefined, query: Query<{ data: HostConfigOverrideResult; metadata?: Metadata | undefined; }, unknown, { ...; }, (string | readonly [......[]])[]>) => number | false) | undefined' is not assignable to type 'number | false | ((data: { data: HostConfigOverrideResult; metadata?: Metadata | undefined; } | undefined, query: Query<{ data: HostConfigOverrideResult; metadata?: Metadata | undefined; }, Error, { ...; }, (string | readonly [......[]])[]>) => number | false) | undefined'.
        Type '(data: FormData | undefined, query: Query<{ data: HostConfigOverrideResult; metadata?: Metadata | undefined; }, unknown, { data: HostConfigOverrideResult; metadata?: Metadata | undefined; }, (string | readonly [......[]])[]>) => number | false' is not assignable to type 'number | false | ((data: { data: HostConfigOverrideResult; metadata?: Metadata | undefined; } | undefined, query: Query<{ data: HostConfigOverrideResult; metadata?: Metadata | undefined; }, Error, { ...; }, (string | readonly [......[]])[]>) => number | false) | undefined'.
          Type '(data: FormData | undefined, query: Query<{ data: HostConfigOverrideResult; metadata?: Metadata | undefined; }, unknown, { data: HostConfigOverrideResult; metadata?: Metadata | undefined; }, (string | readonly [......[]])[]>) => number | false' is not assignable to type '(data: { data: HostConfigOverrideResult; metadata?: Metadata | undefined; } | undefined, query: Query<{ data: HostConfigOverrideResult; metadata?: Metadata | undefined; }, Error, { ...; }, (string | readonly [......[]])[]>) => number | false'.
            Types of parameters 'data' and 'data' are incompatible.
              Type '{ data: HostConfigOverrideResult; metadata?: Metadata | undefined; } | undefined' is not assignable to type 'FormData | undefined'.
                Type '{ data: HostConfigOverrideResult; metadata?: Metadata | undefined; }' is missing the following properties from type 'FormData': lighthouse, listen, tun, loggi

Though this is only when passed to useQueries!

if I pass the configs inline,
 const [{ data: savedData, isPending }, { data: featureFlags }] = useQueries({
    queries: [
      {
        queryKey: hostQueryKeys.configOverrides(hostId),
        queryFn: () => Hosts.getConfigOverrides(hostId),
        suspense: true,
        select: mapOverridesToForm,
      },
      {
        queryKey: orgQueryKeys.featureFlags(),
        suspense: true,
        queryFn: ({ signal }) => Org.getFeatureFlags({ signal }),
        // 10 minutes
        staleTime: 600000,
      },
    ],
  });

they typecheck, except signal is untyped

hmm yeah, seems to be an issue with useQueries typings. can you file an issue?
https://www.typescriptlang.org/play?#code/JYWwDg9gTgLgBAbzgVwM4FMCKz1WO1OAXzgDMoIQ4ByAARgEMA7VRgYwGsB6KdBtmAFoAjjigBPagFgAULLhsILeL1TIANvAC8KDNlz5UACgTy450QYIAuOAG0z586ZlO3cSxIDS6cbbvUpBAQ1AC6ADSO7p7iAGJMtiZwqMAA5kwM6sQAlHBaAHxwAAoUIMAYAHSqEOoAbuhGgcHU2ZGu7kRtbhFmRNkA3EA

made the issue, thx: https://github.com/TanStack/query/issues/5342

is the resolution for "useQueries" with this PR still tbd?
my issue got closed - idk whether there's plans to fix the useQueries types?

it's labelled as a known limitation

well, the second type error is covered by that, but the first problem in https://github.com/TanStack/query/pull/5153#issuecomment-1522517570 is that the output of the queryOptions function doesn't typecheck to useQueries. I'll wait to file an issue til I can try the prereleased version instead of my copy of this PR though.


Split server and client into separate crates

Hyper would be more useful in form of two pluggable modules: client and server. Obviously one may need an HTTP client only. A server without need for an HTTP client is not impossible to imagine. Hyper could be used in such cases now but it would carry over all the unused dependencies together. And to not depend on what you aren't using is a very good idea.

I would go even further and suggest a 3-way split: http , server and client. The hyper-http crate would jut implement the protocol in a network-agnostic way.

I'm going to close this in favor or #894, as there is more discussion there.


docs: fixing repoStatus tag icons

What I did

Fixed the rh-tag icon situation in the repoStatus tables since they were either not showing or the positioning and spacing was off.

For example:

Testing Instructions

Double check the Design/code status page and at least one element's Overview page to ensure the status tables look ok.
Double check code is quality

Should look something like this:

@adamjohnson I prefer iconName. Thanks!

@markcaron hey do we need icon variable if we're not using it?


inject firebase and GoogleSignIn

Hi!
I'm trying to inject a FirebaseAuth and GoogleSignIn instance but I just can not figure out how to do it
If I use :
@Register.singleton(FirebaseAuth)
the injector.g.dart it is not created and get this error in the terminal:
Error running InjectorGenerator
Invalid argument(s): the constructor FirebaseAuth.null does not exist
I'm using this tutorial as reference: https://bloclibrary.dev/#/flutterfirebaselogintutorial?id=app

Untested, use at your own risk: container.registerInstance(FirebaseAuth.instance);

thanks !!!! it works.
And for the record, if someone checks the tutorial I'm using as reference, I have to use:
container.registerInstance(FirebaseAuth.instance);     container.registerInstance(GoogleSignIn());
I just hope it does not give me an unexpected error in the future jajajaja

@camh3190 this is indeed the correct way for registering something like this.


Elytrian bug make it unplayable

I'm hosting a bisect 1.16.5 server for me & my friends & anyone with the Elytrian origin just can't glide. The elytra item works but anyone with the origin just appears to begin to glide for a fraction of a second then immediately return to the normal standing position & just fall. Thus, the origin is useless until I can fix this.
If anyone has any clue how I could fix this that would be very helpful & much obliged.

Are you sure Origins is installed correctly on the server and the client?
Just to be sure - could you update to the most recent Origins version (0.5.1)?
If you did all this and the bug still persists, please send me a list of all installed mods as well as a server log if possible.

will do

That didn't help.
The releavent mods are:
caelus
Customizable eytra
Origins
Extra Origins
Origins Classes
Mob Origins
Phkui

alright, I'm just gonna remove them all & try adding them one by one till it works,
will let you know when I find the problem mod
(I removed all but origins & it worked so it is a mod thing)

OKAY!
I've found the mod
It appears that Oh The Biomes You'll Go is causing it not to work for some reason

Is there a way I can fix this cause I'd like to have both going

I have determined the problem mod to be Adorn

ALRIGHT NEVER MIND AGAIN!
I'm not sure what's going on but I'll remove some mods, it'll work, then I'll add everything but those mods again & it don't
I'm not so sure it's a mods issue anymore

i had the same problem on my side for me it was trinkets (so artifact) because origin adds your elytra in a virtual chestplate but trinket make that you need to put your elytra in a cape slot

and caelus make it bug too

Closed, see #191 (and by extension #195)


Add showCancel option to setupDefaultOption of UploadField trait

The file upload form had a Cancel button displayed to the left of the Browse button(bootstrap-fileinput@4.5.2).
But this Cancel button does not work.
In previous versions the Cancel button was not displayed.
So I added an option to hide the Cancel button by default.
Bootstrap File Input Options - showCancel

Thanks！


vscode-eslint does not work for dotnet-core/react projects in vscode

dotnet-core comes with react templates since netcore 2.0 which can be used to setup the project with a dotnet-core back end and a react front end. To work on this project, the project can be opened in VS code from the root directory with sln file. This allows for appropriate launch and debug configurations to be used for launching the dotnet project with react appropriately.
The ESLint plugin is somehow able to correctly locate the local eslint installation with the following vscode workspace settings, however it fails to find plugins specified in the eslintrc.json file. I am able to execute eslint correctly from the ClientApp folder. Is there some way to check the node_modules location that the ESLint plugin is using.
{
  "eslint.format.enable": true,
  "editor.codeActionsOnSave": {
    "source.fixAll.eslint": true,
  },
  "eslint.packageManager": "npm",
  "eslint.enable": true,
  "editor.tabSize": 2,
  "eslint.run": "onSave",
  "[javascript]": { "editor.defaultFormatter": "dbaeumer.vscode-eslint" },
  "eslint.options": {
    "configFile": "ConfigApp/ClientApp/.eslintrc.json",
  },
}

Here is the project structure
netCoreApp
│   netCoreApp.sln
│
└───netCoreApp
    │   appsettings.Development.json
    │   appsettings.json
    │   netCoreApp.csproj
    │   netCoreApp.csproj.user
    │   Program.cs
    │   Startup.cs
    │
    ├───ClientApp
    │   │   .eslintrc.json
    │   │   package-lock.json
    │   │   package.json
    │   │   README.md
    │   │
    │   ├───node_modules
    │   └───src
    │           App.css
    │           App.js
    │           index.css
    │           index.js
    │
    ├───Controllers
    │       SampleDataController.cs
    │
    └───Properties
            launchSettings.json

Since the workspace for vscode is the root folder, the eslint plugin cannot find the plugin modules located in netCoreApp/ClientApp/node_modules and gives the following error
[Info  - 7:34:06 PM] Failed to load plugin 'react' declared in '--config': Cannot find module 'eslint-plugin-react' Require stack: - C:\__Repos__\netCoreApp\__placeholder__.js

Even the stack is empty and I cannot see any errors.
This error is not specific to the react plugin, when that is removed, an error is thrown for the next plugin. All the plugins specified in .eslintrc.json are installed in the node_modules folder
However, it is correctly able to locate eslint installation from the same location.
I generated this project using Visual Studio 2017 react-redux template. I can setup a sample project if needed, for reference.

I tried to read through the suggestions on #696 but nothing has worked for me so far.

@ydsood can you please provide me with a GitHub repository I can clone that demos what you are experiencing.

Here's a sample repository https://github.com/ydsood/TestESLint.git.
I have committed the .vscode folder so you can have the same setup for launch and ESLint settings. I do not have a global installation for ESLint and use the node_modules location for generating the eslintrc.json using the following command
XXXXX\XXXXX\TestESLint\ClientApp> node_modules/.bin/eslint --init

Here's the error I am seeing on the ESLint output
[Info  - 2:01:41 PM] ESLint server stopped.
[Info  - 2:01:42 PM] ESLint server running in node v12.8.1
[Info  - 2:01:42 PM] ESLint server is running.
(node:7488) UnhandledPromiseRejectionWarning: Error: Failed to load plugin 'react' declared in '--config': Cannot find module 'eslint-plugin-react'
Require stack:
- XXXXX\XXXXX\XXXXX\TestESLint\__placeholder__.js
Referenced from: XXXXX\XXXXX\XXXXX\TestESLint\TestESLint\ClientApp\.eslintrc.json
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:717:15)
    at Function.resolve (internal/modules/cjs/helpers.js:74:19)
    at Object.resolve (XXXXX\XXXXX\XXXXX\TestESLint\TestESLint\ClientApp\node_modules\eslint\lib\shared\relative-module-resolver.js:44:50)
    at ConfigArrayFactory._loadPlugin (XXXXX\XXXXX\XXXXX\TestESLint\TestESLint\ClientApp\node_modules\eslint\lib\cli-engine\config-array-factory.js:959:39)
    at ConfigArrayFactory._loadExtendedPluginConfig (XXXXX\XXXXX\XXXXX\TestESLint\TestESLint\ClientApp\node_modules\eslint\lib\cli-engine\config-array-factory.js:779:29)
    at ConfigArrayFactory._loadExtends (XXXXX\XXXXX\XXXXX\TestESLint\TestESLint\ClientApp\node_modules\eslint\lib\cli-engine\config-array-factory.js:725:29)
    at ConfigArrayFactory._normalizeObjectConfigDataBody (XXXXX\XXXXX\XXXXX\TestESLint\TestESLint\ClientApp\node_modules\eslint\lib\cli-engine\config-array-factory.js:660:25)
    at _normalizeObjectConfigDataBody.next (<anonymous>)
    at ConfigArrayFactory._normalizeObjectConfigData (XXXXX\XXXXX\XXXXX\TestESLint\TestESLint\ClientApp\node_modules\eslint\lib\cli-engine\config-array-factory.js:596:20)
    at _normalizeObjectConfigData.next (<anonymous>)
(node:7488) UnhandledPromiseRejectionWarning: Error: Failed to load plugin 'react' declared in '--config': Cannot find module 'eslint-plugin-react'
Require stack:
- XXXXX\XXXXX\XXXXX\TestESLint\__placeholder__.js
Referenced from: XXXXX\XXXXX\XXXXX\TestESLint\TestESLint\ClientApp\.eslintrc.json
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:717:15)
    at Function.resolve (internal/modules/cjs/helpers.js:74:19)
    at Object.resolve (XXXXX\XXXXX\XXXXX\TestESLint\TestESLint\ClientApp\node_modules\eslint\lib\shared\relative-module-resolver.js:44:50)
    at ConfigArrayFactory._loadPlugin (XXXXX\XXXXX\XXXXX\TestESLint\TestESLint\ClientApp\node_modules\eslint\lib\cli-engine\config-array-factory.js:959:39)
    at ConfigArrayFactory._loadExtendedPluginConfig (XXXXX\XXXXX\XXXXX\TestESLint\TestESLint\ClientApp\node_modules\eslint\lib\cli-engine\config-array-factory.js:779:29)
    at ConfigArrayFactory._loadExtends (XXXXX\XXXXX\XXXXX\TestESLint\TestESLint\ClientApp\node_modules\eslint\lib\cli-engine\config-array-factory.js:725:29)
    at ConfigArrayFactory._normalizeObjectConfigDataBody (XXXXX\XXXXX\XXXXX\TestESLint\TestESLint\ClientApp\node_modules\eslint\lib\cli-engine\config-array-factory.js:660:25)
    at _normalizeObjectConfigDataBody.next (<anonymous>)
    at ConfigArrayFactory._normalizeObjectConfigData (XXXXX\XXXXX\XXXXX\TestESLint\TestESLint\ClientApp\node_modules\eslint\lib\cli-engine\config-array-factory.js:596:20)
    at _normalizeObjectConfigData.next (<anonymous>)
(node:7488) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:7488) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:7488) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
(node:7488) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Since validation needs to happen in the TestESLint/ClientApp directory (even in the terminal to work correctly the setting you need to use is
  "eslint.workingDirectories": [
    "./TestESLint/ClientApp"
  ]

The eslint.options setting needs to be removed.


Azure Storage Code Modifications and Integration Tests Added

add the package dependency in setup.py file

Made necessary changes


How to install Specific version of ImageMagick?

hi,
i have already install ImageMagick 7.1
when i run bellow code it will install 7.1. but i want to install ImageMagick 6.9.10. so how can i install ImageMagick 6.9.10?
t=$(mktemp) && \ wget 'https://dist.1-2.dev/imei.sh' -qO "$t" && \ bash "$t" && \ rm "$t"
thank you

Hi,
simply execute imei.sh with --imagemagick-version 6.9.10-97
However, is there a specific reason for 6.9.10 (where the latest version has been released in Feb 2020, while the latest version is 6.9.12). If not, the OS maintainers version may fit your needs.

where can i place --imagemagick-version 6.9.10-97 in bellow code?
git clone https://github.com/SoftCreatR/imei && \ cd imei && \ chmod +x imei.sh && \ ./imei.sh

after "$t"

get error:
Verifying installation        [FAILURE]

Did you remove any previous installation?
However, please execute identify -version and see, if the installation was successful anyways. Maybe, there's a bug in the verification process.


added "pro git" to git->books

Thank you @aviaryan for the contribution. Look forward for more contributions!


Synthesis failed for Google.Cloud.DocumentAI.V1

Hello! Autosynth couldn't regenerate Google.Cloud.DocumentAI.V1. :broken_heart:
Please investigate and fix this issue within 5 business days.  While it remains broken,
this library cannot be updated with changes to the Google.Cloud.DocumentAI.V1 API, and the library grows
stale.
See https://github.com/googleapis/synthtool/blob/master/autosynth/TroubleShooting.md
for trouble shooting tips.
Here's the output from running synth.py:
2021-03-19 22:43:29,368 autosynth [INFO] > logs will be written to: /tmpfs/src/logs/Google.Cloud.DocumentAI.V1
2021-03-19 22:43:29,858 autosynth [DEBUG] > Running: git config --global core.excludesfile /home/kbuilder/.autosynth-gitignore
2021-03-19 22:43:29,862 autosynth [DEBUG] > Running: git config user.name yoshi-automation
2021-03-19 22:43:29,865 autosynth [DEBUG] > Running: git config user.email<EMAIL_ADDRESS>2021-03-19 22:43:29,868 autosynth [DEBUG] > Running: git config push.default simple
2021-03-19 22:43:29,872 autosynth [DEBUG] > Running: git branch -f autosynth-Google.Cloud.DocumentAI.V1
2021-03-19 22:43:29,876 autosynth [DEBUG] > Running: git checkout autosynth-Google.Cloud.DocumentAI.V1
Switched to branch 'autosynth-Google.Cloud.DocumentAI.V1'
2021-03-19 22:43:30,090 autosynth [DEBUG] > Running: git rev-parse --show-toplevel
2021-03-19 22:43:30,097 autosynth [DEBUG] > Running: git log -1 --pretty=%H
2021-03-19 22:43:30,101 autosynth [DEBUG] > Running: git remote get-url origin
2021-03-19 22:43:30,136 synthtool [ERROR] > Failed executing git checkout master:

error: Your local changes to the following files would be overwritten by checkout:
	google/cloud/dialogflow/v2/answer_record.proto
	google/cloud/dialogflow/v2/conversation.proto
	google/cloud/dialogflow/v2/conversation_profile.proto
	google/cloud/dialogflow/v2/participant.proto
Please commit your changes or stash them before you switch branches.
Aborting

Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 354, in <module>
    main()
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 189, in main
    return _inner_main(temp_dir)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 312, in _inner_main
    git_source.enumerate_versions(sources, pathlib.Path(temp_dir))
  File "/tmpfs/src/github/synthtool/autosynth/git_source.py", line 202, in enumerate_versions
    source_versions = enumerate_versions_for_source(git_source, temp_dir)
  File "/tmpfs/src/github/synthtool/autosynth/git_source.py", line 166, in enumerate_versions_for_source
    local_repo_dir = str(synthtool_git.clone(remote))
  File "/tmpfs/src/github/synthtool/synthtool/sources/git.py", line 85, in clone
    shell.run(["git", "checkout", "master"], cwd=str(dest), check=True)
  File "/tmpfs/src/github/synthtool/synthtool/shell.py", line 39, in run
    raise exc
  File "/tmpfs/src/github/synthtool/synthtool/shell.py", line 33, in run
    encoding="utf-8",
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 438, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['git', 'checkout', 'master']' returned non-zero exit status 1.

Google internal developers can see the full log here.

Autosynth passed, closing! :green_heart: