Upload to a Graphql (Graphcool) file endpoint

i am facing problems with uploading to graphql(Graphcool) file endpoint.
RN - 0.45.1
react-native-fetch-blob - 0.10.5
snippet - (this one actually shows me the upload progress) -
    RNFetchBlob.fetch('POST', GRAPHCOOL_FILE_ENDPOINT, {
                'Accept': 'application/json',
            'Content-Type': 'multipart/form-data'
        },[
            {
                name: dates + 'mp4',
                filename: dates + 'mp4',
                type: 'video/mp4',
                data: RNFetchBlob.wrap(this.state.selectedVideo[0].uri)
            }
        ]).uploadProgress((written, total) => {
            console.log('uploaded', written/total)
        }).then((res) => {
            console.log(res);
            this.setState({
                textCamera:'',
                cameraActivityIndicator: false
            });
            this._onRefresh();
        }).catch((err) => {
            console.log(err);
        })

acutalluy i have tried with a lot of alterations -
{
  filename: dates + '.mp4',
  type: 'video/mp4',
  uri: this.state.selectedVideo[0].uri
}

{
  filename: dates + '.mp4',
  type: 'video/mp4',
  data: RNFetchBlob.wrap(this.state.selectedVideo[0].uri)
}

the app crashes using the above.
only the snippet version shows me the progress, altought the file upload is complete and i also get a response but there is no file created at the endpoint.
can anyone help me here?

@michaelspeed , I'm wondering if that's because the file is large which exceeds the heap size limitation. How large are the files ?

i say we tried with small 3mb and large 10-50mb files. i dont think its about the  size, coz for the first one -  {                 name: dates + 'mp4',                 filename: dates + 'mp4',                 type: 'video/mp4',                 data: RNFetchBlob.wrap(this.state.selectedVideo[0].uri)             }
we get a upload progress, and the rest it just crashes

@michaelspeed , how does the URI looks like ?

///var/mobile/Containers/Data/Application/61725713-1F1A-4118-BB93-0DADB39F62D4/tmp/trim.08E78A1E-0C3D-4FC6-8A13-8913483259BA.MOV
using react-native-image-picker library

Hey! I think I've found a workaround:
RNFetchBlob.fetch('POST', FILE_ENDPOINT, {
'Accept': 'application/json',
'Content-Type': 'multipart/form-data'
}, [{
name: 'data', // !!!HERE!!! must call "data"
filename: 'anything_you_want',
data: base64data
}])

i can confirm the above is working!
i am closing this issue! if anyone has a better options they can reopen the issue!


Ensure libdispatch is always initialized before CoreFoundation

This has been causing async functions to not return when using static linking.
rdar://96642321

@swift-ci test

@swift-ci test macos

@swift-ci test

@millenomi Does this change look reasonable to you? Happy to provide more details if you have any questions.

cc @parkera


Runtime dispatch (version 3)

This is a follow-up on  PR 227
https://github.com/lemire/simdjson/pull/227
This version appears to work on CLANG + GCC.
However, the performance is terrible.
cc @ioioioio

Note that amalgamation may not work yet.

Thanks to @jkeiser, it appears to work under Visual Studio.

@lemire I decided to update the full C# port of simdjson (the one based on System.Runtime.Intrinsics). Should I wait this PR or can work with the actual master? (it seems it should support both SSE and AVX and it should not be a problem to implement AVX/SSE switch with JIT).

@EgorBo I don't think so. I think this most useful for the wrapper.

This looks good except for the mysterious terrible performance...

Ah. Ok. The code was slow because in the parse executable, dispatching was only enabled for part of the test.

@ioioioio  Would you look at this PR?

Looks good. I was changing simddetection.h's name the other day (since now it does more), but it seems like I had not finished the job. Now it's done.


Feature/new add container experience

This is the continuation of https://github.com/concrete5/concrete5/pull/8810 addressing issue #8478

I removed hasAddTemplate() and supportsInlineAdd() from the COntainer entity and hard-coded the values
I finally was able to see the duplicate search and removed it
I added the success message and title when adding containers.

Thank you, this looks good.


ops integration-tests build error

For a fresh build, on MacOS, following the build instructions, running cd ops/ && docker-compose build is giving:
 => [base 19/20] COPY ./integration-tests ./integration-tests                                                                                0.7s
 => ERROR [base 20/20] RUN yarn build                                                                                8.7s
------
 > [base 20/20] RUN yarn build:
#26 0.284 yarn run v1.22.19
#26 0.313 $ yarn lerna run build
#26 0.451 $ /opt/mantle/node_modules/.bin/lerna run build
#26 0.781 lerna notice cli v4.0.0
#26 0.783 lerna info versioning independent
#26 0.820 lerna info Executing command in 10 packages: "yarn run build"
#26 2.289 lerna info run Ran npm script 'build' in '@mantleio/core-utils' in 1.5s:
#26 2.289 $ tsc -p tsconfig.json
#26 3.012 $ tsc -p tsconfig.json
#26 3.012 lerna info run Ran npm script 'build' in '@mantleio/hardhat-deploy-config' in 2.2s:
#26 4.957 lerna info run Ran npm script 'build' in '@mantleio/common-ts' in 2.7s:
#26 4.957 $ tsc -p tsconfig.json
#26 5.032 lerna info run Ran npm script 'build' in '@mantleio/sdk' in 2.7s:
#26 5.032 $ tsc -p tsconfig.json
#26 8.309 lerna$ tsc -p tsconfig.json
#26 8.309  info run Ran npm script 'build' in '@mantleio/replica-healthcheck' in 3.3s:
#26 8.422 lerna ERR! yarn run build exited 1 in '@mantleio/integration-tests'
#26 8.422 lerna ERR! yarn run build stdout:
#26 8.422 $ hardhat compile
#26 8.422 Downloading compiler 0.8.9
#26 8.422
#26 8.422 info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
#26 8.422 lerna ERR! yarn run build stderr:
#26 8.422 An unexpected error occurred:
#26 8.422 SyntaxError: /root/.cache/hardhat-nodejs/compilers/linux-amd64/list.json: Unexpected end of JSON input
#26 8.422     at JSON.parse (<anonymous>)
#26 8.422     at /opt/mantle/node_modules/jsonfile/index.js:33:18
#26 8.422     at /opt/mantle/node_modules/graceful-fs/graceful-fs.js:123:16
#26 8.422     at FSReqCallback.readFileAfterClose [as oncomplete] (node:internal/fs/read_file_context:68:3)
#26 8.422 error Command failed with exit code 1.
#26 8.422 lerna ERR! yarn run build exited 1 in '@mantleio/integration-tests'
#26 8.422 lerna WARN complete Waiting for 4 child processes to exit. CTRL-C to exit immediately.
#26 8.457 error Command failed with exit code 1.
#26 8.457 info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
#26 8.550 error Command failed with exit code 1.
#26 8.552 info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
------
executor failed running [/bin/sh -c yarn build]: exit code: 1
ERROR: Service 'deployer' failed to build : Build failed

which intermittently also gives:
#26 16.14 lerna ERR! yarn run build exited 1 in '@mantleio/contracts'
#26 16.14 lerna ERR! yarn run build stdout:
#26 16.14 $ yarn build:contracts && yarn autogen:artifacts && yarn build:typescript
#26 16.14 $ hardhat compile --show-stack-traces
#26 16.14 running task
#26 16.14 end task
#26 16.14 Downloading compiler 0.8.9
#26 16.14 Downloading compiler 0.5.17
#26 16.14
#26 16.14 info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
#26 16.14 info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
#26 16.14 lerna ERR! yarn run build stderr:
#26 16.14 Error HH501: Couldn't download compiler version 0.8.9+commit.e5eed63a. Please check your internet connection and try again.
#26 16.14 HardhatError: HH501: Couldn't download compiler version 0.8.9+commit.e5eed63a. Please check your internet connection and try again.

It seems like hardhat can't download/find/access the solc compilers at /root/.cache/hardhat-nodejs/compilers/linux-amd64/tmp-solc-linux-amd64-v0.8.9+commit.e5eed63a perhaps they need to be copied into the container first


Cant install on Linux

npm ERR! err.code.match is not a function
Seems like the package is not compatible with latest nodejs on Linux anymore.
Since its also not updated anymore: here is my warning donr use it.

That's not from the library's code, you sure it's not something with your environment

seems to work again, probably was.


DevTools failed to load SourceMap: Could not load content for

I suppose what it's a problem with browser plugins. The problem exactly with our source maps ?


fix: close temporary file after creating it

This fixes "The process cannot access the file because it is being used by another process" errors on Windows.
The file is still automatically deleted by the os.unlink call later in the function.
Updates #5606
Fixes #5642
Pull Request Checklist
Before submitting, make sure you've checked the following:

[x] Target branch: dev
[x] Description: See above.
[x] Changelog: See below.
[x] Documentation: No documentation to update.
[x] Dependencies:: No new dependencies.
[x] Testing:: Manually verified in a Windows VM that calling os.unlink(temp_file.name) before calling temp_file.close() causes this error, and that calling temp_file.close() before os.unlink(temp_file.name) does not.
[x] Code review:: OK.
[x] Prefix: fix

Changelog Entry
Fixed

Fix "The process cannot access the file because it is being used by another process" issue when adding functions/tools on Windows.

I do not have a real Windows machine to test this on beyond the manual test described above, but per this comment by @tcgumus it sounds like this PR fixes the issue.

yes fixed my issue on windows.

Thanks for taking a look!


visualize: mention that we are not limited with ascii

See https://github.com/iterative/dvc/issues/1561#issuecomment-459641862 .

Fixed.


[Feature]: Minor suggestions for tutorial

What would you like to see added to the NWB GUIDE?
The single session tutorial runs really nicely! Great work @CodyCBakerPhD @garrettmflynn !!
I have a few minor suggestions:

On the dataset generation page,

I think the italicized text would look better as code instead of italics. Same for in the single session tutorial page.

In the single session tutorial
"Upon launching the GUIDE, you’ll begin on the Conversions page."
"Conversions" -> "Convert"? There is no page named "Conversions". I'm sure people will figure it out but it's nice to have a 1:1 match.

Under "Project Setup", the "Note" seems like a lot of detail and not critical for the tutorial

"NeuroPixel" -> "Neuropixels"

"with an age of P30D." ->
"with an age of P30D, which represents 30 days old"

Do you have any interest in helping implement the feature?
No.
Code of Conduct
Yes
Did you confirm this feature was not already reported?
Yes

the italicized text would look better as code instead of italics.

It should have been. Very common mistake since italics is a single backtick whereas code is double
Can you open a PR for that?

Under "Project Setup", the "Note" seems like a lot of detail and not critical for the tutorial

The second point is extremely important for using the GUIDE on their own data however, so I would rather they get exposed to it sooner rather than later. Otherwise our app could overload their system (no current stress tests to ensure ample disk space is available beyond what we hope h5py/zarr would normally do)
The tutorial itself will not have this problem of course (unless they are REALLY full already on home drive - has been seen in occasional user tests...)
The point about SSD is also a think to know earlier rather than later, and counters user concerns over write speed (even applying to the tutorial)


Test Corrections (Remove-test-event only)

Related Issue or Background Info
First phase of corrections that allows a user to mark a test as deleted. PR includes work to prep for actual changes, but that should happen in a near sprint. #527
It prepares for #576
Changes Proposed Overview

Update liquibase postgres schema (including data migration to fill in new columns)
Update models
Update repositories
Update graphql schema
Update graphql resolvers
Update services (including datahub upload)
Update tests
Included new AccessRestriction dependency injection.
Fixed a datetime crash when "" date passed from client

Changes Proposed Details
Schema updates:

Added new TEST_CORRECTION_STATUS type 'ORIGINAL', 'CORRECTED', 'REMOVED'
Added new columns to test_order and test_event: correction_status reason_for_correction  Initial values are correction_status:'ORIGINAL' and reason_for_correction:null  - Added the following columns to just test_event:   - The missing patient_answers to test_event Initial values are updated from test_order This is a jsonb data copy of the date directly into the TestEvent`
New column test_order_id to test_event which is a foreign key reference back to the originating order. Initial value mapped back from from test_order
 - New column prior_corrected_test_event_id which key to a different entry in the test_event table. This is for the "chaining" of corrections that the DataHub api wants.

graphql schema

Added  correctionStatus: String and reasonForCorrection: String to both TestOrder and TestResults.
Added correctTestMarkAsError mutation

Datahub upload

Added Corrected_result_ID
Updated Test_result_status

Added tests

Basic tests for new fields
Tests for TextEvent copying over data from TestOrder
Service level tests for actually doing Corrections

Additional Information

TestEvent and TestOrder need to basically have the same fields. While the Remove action does not need to have the Reason string, the future Edit will need it. That behavior will put the reason and the CorrectionStatus into the TestOrder, then the Order will be placed back into the Testing Queue. When it's resubmitted, the logic will see it's CorrectionStatus and atomically create a replacement TestEvent and copy over the Reason and CorrectionStatus.
In order to do this big change, I had to roll back to point on the main branch where unit tests were working and not update. Then when everything I merged forward. This makes the delta change in github look massive.
Merged 6hr ago, but it looks like there are already merge conflicts.  Need to re-merge.
Please double check I got the AccessControl injections correct. This was the primary conflict.
Still need to test DataHub uploads, but need to wait for their release to handle new columns.

@dmethvin-gov The smoke test for client is failing on a line you added in this changelist.

@dmethvin-gov The smoke test for client is failing on a line you added in this changelist.

@timothybest-usds @benwarfield-usds I did a slight refactored of this PR to convert patient_answers_id in TestEvents to patient_answers_data (jsonb).
It simplified things, which is a good sign. The TestOrder has a reference to PatientAnswers which has a jsonb field of the actual data. When an TestEvent is created, it copies this field. It is then used when Datahub uploader runs. When a TestEvent is corrected+removed, this value is copied between TestEvents.
The liquibase includes sql to copy the test_order->patient_answers.ask_on_entry into every existing TestEvent. The initial startup may take extra time to run the liquibase db "migration".
It would be great if we had some way to verify liquibase data migration on production-like data. I tested it manually by making date on the main branch, then switching to this branch and running the new code. Would be nice if there was some way to unit test liquibase updates, but that's a complex problem.

@timothybest-usds @benwarfield-usds I did a slight refactored of this PR to convert patient_answers_id in TestEvents to patient_answers_data (jsonb).
It simplified things, which is a good sign. The TestOrder has a reference to PatientAnswers which has a jsonb field of the actual data. When an TestEvent is created, it copies this field. It is then used when Datahub uploader runs. When a TestEvent is corrected+removed, this value is copied between TestEvents.
The liquibase includes sql to copy the test_order->patient_answers.ask_on_entry into every existing TestEvent. The initial startup may take extra time to run the liquibase db "migration".
It would be great if we had some way to verify liquibase data migration on production-like data. I tested it manually by making date on the main branch, then switching to this branch and running the new code. Would be nice if there was some way to unit test liquibase updates, but that's a complex problem.


Adjust Transaction graph to show instant rollbacks, not cumulative

.transaction.active
The number of currently active transactions.
and
.transaction.rollbacks
The total number of rolled back transactions.
Showing a total number of rolled back TXs only grows with time.  It should show the number of rollbacks in that period.  Do some simple math to make sure that it only spikes when rollbacks are occurring.

Fixed by v0.14.0


Merged to last master

Hi, tanks for your job! What's status of this branch, can it be used in production? I noticed all test passed without errors.
PS did you notice faster execution of lambda?

This was an experimental branch that is now long out of date and shouldn’t be considered production quality. Merging from it to main would cause problems


How I can use this for models with multiple input?

Hi, I'm trying use this ONNX Infernce Code for model with 2 input. 2 Img [3224224] as input.
I changed code by adding convert to tensor for second img and for run, i changed to this:
session.Run(Ort::RunOptions{nullptr}, (inputNames.data()),
                (inputTensors.data(),inputTensors2.data()),2, outputNames.data(),
                outputTensors.data(),1);

but not worked, and got this error:
...
terminate called after throwing an instance of 'Ort::Exception'
  what():  input name cannot be empty
Aborted (core dumped)

and by trying to run this code (without any change) got this error:
...
Segmentation fault (core dumped)

How i can? Can you help me? please?

Please follow the API exactly when you run inference. Although I cannot reproduce your error because I have no model, I think you did not use the data structure correctly.


[objc] Add more generated comments in headers

The comments covers NSObject protocol support for

- (bool)isEqual:(id _Nullable)other;
- (NSUInteger)hash;

and all @protocol where we link to the subclassing limitation.

Build and tests passed.


DOC: Dev branch docs render Dev TOC while viewing API Reference

Issue with current documentation:
When viewing https://scipy.github.io/devdocs/reference/index.html I see the table of contents for the developer guide, not the reference table of contents.
This is not an issue with the stable builds.
The issue persists after clearing the browser cache, so I assume that's unrelated.
Idea or request for content:
It would be nice if the correct table of contents was displayed. It's curious that this isn't an issue for stable, so hopefully isn't related to how hosting is handled.
Additional context (e.g. screenshots, GIFs)
https://scipy.github.io/devdocs/reference/index.html looks like:

https://docs.scipy.org/doc/scipy/reference/index.html looks like

Hey @ivirshup, thanks for reporting. Yes I noticed this. It happears from time to time and I also suppose it's some sort of caching happening here. Not sure though. We are in the process of updating the doc (🤞) hopefully that would "fix" something.


State-level Gini coefficients

As you go about this important work, keep in mind the kinds of requests we have received asking for Tax-Calculator to generate state-level information.  This request was for the ability to generate Gini coefficients by state.

Many thanks. Comments of this nature are extremely helpful.
Don
On Tue, Feb 13, 2018 at 6:55 PM, Martin Holmer<EMAIL_ADDRESS>wrote:

As you go about this important work, keep in mind the kinds of requests we
have received asking for Tax-Calculator to generate state-level
information. This request
https://github.com/open-source-economics/Tax-Calculator/issues/1003 was
for the ability to generate Gini coefficients by state.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/open-source-economics/PUF-State-Distribution/issues/5,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGPEmIujbCXEWkP5pB7J0BrxfkYlg-T2ks5tUiEDgaJpZM4SEl1P
.


authManager.checkAuthOnRefresh not working

// src/angularJwt/services/authManager.js

function checkAuthOnRefresh() {
        // When a location change is detected
        $rootScope.$on('$locationChangeStart', function () {
          var tokenGetter = config.tokenGetter;
          var token = null;
          // Try to get jwt token...
          if (Array.isArray(tokenGetter)) {
            token = $injector.invoke(tokenGetter, this, {});
          } else {
            token = config.tokenGetter();
          }
          if (token) {
            if (!jwtHelper.isTokenExpired(token)) {
                     // If token and not expired authenticate, ok lgtm
                     authenticate();
            }
            // But what happens if not? when token had expired or there is no token?
            // Shall an 'unauthenticated' event be fired?
          }
        });
      }

But there´s more... if checkAuthOnRefresh fires unauthenticated event every time that a locationChangeStart is produced the user won't be able to go to the login page.
( Because redirectWhenUnauthenticated will be fired with another locationChangeStart causing an infinite loop. )

The issue is that it's not always the case that an expired JWT (or not having a JWT) should necessitate a redirect to the login page. Many apps have routes that don't require authentication. So if a user was at one point authenticated, but now has an expired JWT, they shouldn't be redirected to the login page immediately if they are on a public route.
The better detection for this is if the user tries to access secured resources from the server. If they are at a route that accesses secured resources and they refresh the page, a 401 will be returned from the next call to the server and they will be redirected to the login page because redirectWhenUnauthenticated is there.

It would be nice if this method could provide a callback so that we could hook into it - e.g. When the token is expired, then I need to remove it from localstorage OR if I am using RefreshTokens then I could make a another call to Auth0.
Currently I use this code to achieve this -
    jwtInterceptorProvider.tokenGetter = function (jwtHelper) {
        var token = localStorage.getItem('id_token');
        var refreshToken = localStorage.getItem('refreshToken');
        if (token) {
            if (!jwtHelper.isTokenExpired(token)) {
                //valid stored token - use it
                return localStorage.getItem('id_token');
            } else {
                console.log('id_token has expired - removing from localstorage')
                localStorage.removeItem('id_token');
            }
        }
    }

There's now a tokenHasExpired event being fired on page refresh if the token's expiry has passed. This can be picked up and used on page refresh, but it sounds like you're needing a hook for basically any time a request gets made.
Perhaps we can look at providing a config option for something like onTokenExpiry where you can provide a function to do whatever you like. It might be just as well to handle it in your tokenGetter at the end of the day though.
I'm going to close this particular issue but please feel free to open another one with the request for the hook you're after. PRs also welcome :)

Has anyone confirmed that this 'tokenHasExpired' event works?
I have tried this on the run block and it is not working. If I use authManger
authManager.redirectWhenUnauthenticated('/login');

however, that works. It redirects, but if I try to alert or console.log on the event, nothing happens

@chenkie I have resources returning 403s and the app is not redirecting.  Does authManager.redirectWhenUnauthenticated() only work with 401s?


Linuxbrew

Included requrements.txt to base_install.sh. Fixed broken link to clean_cache.sh

@RoranDangerous

This pull request and https://github.com/Metannotate/Metannotate/pull/12 share commits which they really shouldn't... Remove these commits...
Also this branch is called linuxbrew but has no content related to linuxbrew? It should have a different name.


Add target for installing latest build from latest release branch

When something breaks in a release, the upgrade job on devel will continue to fail even after it's fixed in the release branch. This is because the upgrade job uses curl -L get.submariner.io | VERSION=latest bash, which gives the latest release but not any updates to that release branch, to install subctl for the first deploy.
We have the release-0.12 and similar targets to install the latest build from some release branch, but if we use that in CI it would need to be updated for each release. Better to add a stable get.submariner.io target to get this "latest build from latest release branch".

If we add this target, I think it would make sense to run the current subctl latest upgrade job periodic-only and using this new subctl latest-prerelease in PR-triggered CI.

@dfarrell07 can we move it out from 0.13?


Downloads about the model

Hello, your program turned out very well. But there is no usable model for the Celebm database to run, can you provide one?

Hi, celebm face parsing model is available , try it out here


Implement L.Label

So this is a first naive approach, just hit the "it works" point.
Basically, I've extracted common methods of L.Popup to L.PopupBase, and made L.Label inherit from it.
The API is quite similar to Leaflet.Label plugin, but options are not exactly the same.
Here are the main supported option at this stage:

static should the label appear on mouseover or be permanent (not sure about the naming, maybe permanent would be better)
followMouse should the label follow the mouse or only appear at the layer center
direction left, right or auto, just like in Leaflet.Label
clickable should the label be clickable (in this case, it's a event target for the source it is attached to)

There is for sure a lot more work to be done (more factorisation, custom events…), but I wanted to push a first version to start discussion and feedback.
There is a debug page in debug/map/label.html.
TODO

[x] unittests
[x] custom events
[x] check with FeatureGroup
[ ] attaching labels to the map directly?
[ ] factorize enough so one can create a new class inheriting from L.PopupBase, customize initLayout and it works™ (for a FancyLabel or WhizzyPopup plugin for example)

Preview

@mourner @IvanSanchez feedback more than welcome :)

Wow, you're fast! Taking a look on Monday. Looks pretty cool.

Neat. +1 Anything else needed?

Hey, Santa Claus, can you send me a review for XMas? :)

Was just working on something very similar. This is PR is great and I would love to see it merged. Nice work!

ping @hyperknot for a review :)

Well, it needs a huge rebase, thanks to @IvanSanchez :p

Merged with master! So ready for review again :)
Note: I've not rebase, because (due to merge with leafdoc branch) the diff was huge, and I want to be sure I've not made a mistake during the merge. We'll rebase when ready for merging.

As discussed in IRC:

added top and bottom directions support
made the styling a bit more neutral and integrated with other Leaflet styling

Comments welcome :)

Added documentation.

I've looked at Label, my biggest questions are:

at the moment I believe it mostly is a port of Leaflet.Label, but I am not sure that defaults for a specific plugin are good defaults for core Leaflet. For example I am surprised that the default Label is a hover/popup style label. Is that really what most Leaflet users would think about when they want a Label? Do they need a direction by default?
in my idea the default use case of a label would be a static text on a map, with no interactivity and no direction by default. but this is only my idea, we should discuss what is it for others and possibly ask users (if only here).
i'm thinking about PopupBase, if we believe this is the right solution we have to be quite future proof here, to make sure that we are not artificially limiting either popup or label by having this hybrid parent class. In my opinion many of the popupbase options are very specific to popup right now.

Those are valid points, and I think mainly what L.Label should be by default is a matter of taste, and thus I can't argue.
So I'm gonna close here and extract back this work to a separate module (thus more opinionated).
Let's see after that if we can reintegrate it as new version of Leaflet.Label.

One plus point for the separate module is that you can target more modern browsers, independent from Leaflet core. For example you can make it IE9+ or IE10+ compatible and just state it in the readme.

@yohanboniface don't give up. :) I don't think we're ready to dismiss the idea of a common base for both label and popup, it just needs more review/discussion.
The Popup-specific options @hyperknot mentioned could be moved down to Popup — things like autoPan, width/height, closeButton etc. We could rename PopupBase to something like DivOverlay that has no label/popup specifics. And make Label simpler — e.g. assume simple single-line labels that don't need autopanning and buttons that open to the left or to the right.

it just needs more review/discussion.

The thing is that this PR has been opened last October, and there have been no really interest in reviewing/discussing.
On the other hand it's now two years since a new version of uMap because I've based my devs on the Leaflet master trunk which was not stable enough to have a release. Label is the last thing I needed to publish that new uMap (rc) version.
Next week-end we have the French SotM, and I want to talk about the new uMap version, thus I want to push it live. So I need to move forward, so I think I'll dedicate my energy to a separate module for now. Two years is way too much. Including for my sanity. And I know you know what I mean ;)
Anyway, thanks for kindly reopening, and thanks @perliedman for your review :)

Moved options. Rebased.
Some tests are skipped in Travis but will be fixed when #4705 will be merged (by loading CSS).


Fix excerpt separator being shown in blog posts

Remove the excerpt separator <!--more-->, as it is being show in the blog posts:

Signed-off-by: jonasrosland<EMAIL_ADDRESS>What this PR does / why we need it:
Fixes the issue mentioned here: https://github.com/heptio/velero/issues/1575

Codecov Report

Merging #742 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #742   +/-   ##
=======================================
  Coverage   42.59%   42.59%
=======================================
  Files          70       70
  Lines        4029     4029
=======================================
  Hits         1716     1716
  Misses       2208     2208
  Partials      105      105

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3324bc4...2563c5f. Read the comment docs.


[WIP] Agent logs format

What does this PR do?
Change the logs format in text and JSON
before:
{"time":"2019-01-02 14:39:13 UTC","level":"INFO","file":"runner.go","line":"324","func":"work","msg":"Done running check kubelet"}

after:
{"agent":"core","time":"2019-01-02 14:46:02 UTC","level":"INFO","file":"pkg/collector/runner/runner.go","line":"324","func":"work","msg":"Done running check kubelet"}

Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?

closing in favor of #2959


Access Control fix for Swift 2.1

Extension doesn't work in Swift 2.1, I don't know about more earlier language versions.
Please, check it. Thank you.

Sorry for the slow response, but thanks for this!


xds: Match the client's version if higher than the server's

When Cilium restarts but the xDS clients survive, they keep
requesting the last version they had received from the previous
Cilium instance.
Handle this case by bumping the server's resource version to
match the clients'.
Signed-off-by: Romain Lenglet<EMAIL_ADDRESS>

test-me-please

test-me-please

CI build failure:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/3376/execution/node/63/log/
21:37:41 RuntimeValidatedPolicies
21:37:41 /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:306
21:37:41   TestsEgressToHost
21:37:41   /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:306
21:37:41     Tests egress with CIDR+L4 policy to external https service [It]
21:37:41     /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:338
21:37:41
21:37:41     Expected to be able to access /public in host Docker container
21:37:41     Expected
21:37:41         <string>: 000
21:37:41     to contain substring
21:37:41         <string>: 200
21:37:41
21:37:41     /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/runtime/Policies.go:1111

Known issue: #4188

test-me-please

test-me-please


asking for unnecessary permissions

Asks for root after every update but it doesn't need it (has separate permission to set/clear do not disturb).
Asks for storage to write sound files that are not even used.

After app. update, application is restarted. Therefore ask for root is reuired in start of app.
PPP installing phoneprofiles_silent.ogg to folders: Alarms, Notifications, Ringtones, for using it by user. This tone can be used if device has merged ringing and notification volumes and in profile is configured notification volume=0.

On 12 May 2017 2:02:24 AM AEST, Henrich Gron<EMAIL_ADDRESS>wrote:

After app. update, application is restarted. Therefore ask for root
is reuired in start of app.
PPP installing phoneprofiles_silent.ogg to folders: Alarms,
Notifications, Ringtones, for using it by user. This tone can be used
if device has merged ringing and notification volumes and in profile is
configured notification volume=0.

--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/henrichg/PhoneProfiles/issues/1#issuecomment-300836532

I understand why it re-asks (that's a security feature of the su app). I don't understand why it asks for root when it doesn't need it. I don't use any settings that require root. I do set/clear the do not disturb state but gave the app permission to do that (via settings) so it works without root.
I have Android 6, so my volumes are merged but I do not set ringtone or notification volumes to a zero value. I do set the ringer to vibrate only and do not disturb but this is a separate setting. So I do not need the files, yet it still tries to write them.
I switched from another profiles app that didn't handle do not disturb and PhoneProfiles works fine. I just don't like it when apps ask for permissions they don't need and write files all over my storage. I can deny these permissions to PhoneProfiles so in practice there's no issue. But the re-asking for root happens on every upgrade and PhoneProfiles even tried to get me to re-enable the storage permission so it could write files that were not needed.
Sent from my Android

"Grant root" is added is in application Settings -> Permissions. This opens "Grant root" dialog with checkbox "Never ask again". Answer "No" with "Never ask again" checked and grant will never be asked after PP upgrade. Answer "Yes" and this opens SuperSU or Magisk Manager. ;-)
This will be in next version.


Ability to publish and acknowledge messages atomically

I have a consumer that transforms messages consumed on one topic and produces messages on another topic. Clearly I cannot acknowledge the consumed message until I have published the transformed message.
The issue I have is in how to handle a situation where for message cannot be acknowledged due to some spurious situation where the produced message has already been sent, because if the acknowledgement fails them the message will be redelivered despite the fact that it has been consumed.
I appreciate that Pulsar is designed to run in an HA environment but we all know that High Availability is not Total Availability, therefore the scenario where the message cannot be acknowledged after the transformed message is possible.
How can I can I handle that possibility? As a minimum, I would need to be able to publish and acknowledge atomically, but what if I needed to publish to more than one topic before acknowledging? In that scenario, there could be a failure between the two message publishes, meaning that one message has been published, the second has not, and the consumed message cannot be acknowledged either.
Surely, for a 100% fault tolerant system, there must be a transactional ability whereby a producer and a consumer can enlist in a single transaction and commit when all operations are successful?
This seems to be a fundamental feature requirement  of a system like this?
I'm sorry if I've missed anything in the documentation that covers this.

@Mrdigs your use case can be addressed by using transactions in #2664 . transactions is under development, it is planned for 2.5 release.

This is a duplicate of #2664


[tools] Dynamic imports to load web component

Requested results:

Baseline testing (lighthouse)
Blog post of recommended approaches of how to load WCs on your site (SPA vs. CMS, etc)

Resources:

btopro video on dynamic imports
dimport, is an ESModule polyfill allowing you to run import, export, and import() in any browser – even IE.
It offers 3 modes, with varying backwards reach. They vary in size from 675B to 1.14 kB

GitHub: https://github.com/lukeed/dimport
Demo: https://dimport.now.sh

POC by @kylebuch8  https://github.com/kylebuch8/optimized-loading
Notes: https://docs.google.com/document/d/1ZsOr-x72901ahwCRGyEIxMdqLlAVmQX6RaSsXz2PQCA/edit#heading=h.njozdg7grea0

Proof of concept last month validated this approach as a good fallback for CMS experiences where authors can add components but don't necessarily know how/where to load assets from.  What can PFE do to make this easier to implement?

[ ] Documentation on how to use autoloaders OR
[ ] Possibly our own variant of the autoloader (cc @kylebuch8)
[ ] An automatically generated registry pointing to unpkg listing all components available (good for demo/upstream use)


implement content

Link to documents coming asap

closed via https://github.com/coverified/website/pull/4


Wider content and sticky or similiar right column behavior on side by side mode

Wider content and sticky right column on side by side mode
Feature description
I would like to be able to scroll the left and right columns independently on side-by-side mode.
How the feature is useful
When you change any option, config files are regenerated and sometimes i want to see what changes does clicking an option.
Currently I have to scroll many times, to change an option, scroll to see the changes and scroll back to the options area.

Thanks, very nice!


Support for TLS1.2

PSDepends thrown the following error when using an HTTPS download link:
Exception calling "DownloadFile" with "2" argument(s): "The request was aborted: Could not create SSL/TLS secure channel."
At C:\Users\randr\Documents\WindowsPowerShell\Modules\PSDepend\0.2.0\Private\Get-WebFile.ps1:7 char:5
+     $webclient.DownloadFile($URL, $Path)
+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
    + FullyQualifiedErrorId : WebException

The PSDepends configuration used:
@{
    # Set up a mini virtual environment...
    PSDependOptions = @{
        AddToPath = $True
        Target = 'BuildOutput\Modules'
        Parameters = @{
        }
    }

    #...

    #File Download
    'https://github.com/AutomatedLab/AutomatedLab/raw/develop/LabSources/Tools/WinSATAPI.dll' = @{
        DependencyType = 'FileDownload'
        Target = '.\DLLs\WinSATAPI.dll'
    }
}

Good catch!  Mind using [Net.ServicePointManager]::SecurityProtocol = [Net.ServicePointManager]::SecurityProtocol -bor [Net.SecurityProtocolType]::Tls12?  This will add tls12 to current set of options vs. replace - just in case this runs in an interactive session and someone has some niche dependency on another protocol in that list.
Also!  I think your's is more concise as is, but if you end up pulling more than a few files, the github type might be worth looking at
Thanks!

Whee!  Alrighty, hope you don't mind the change, merging and deploying now!


Develop

Three new modules:

canopy_zpd_mod -- zero plane displacement height and total surface roughness length basd on Massman et al. (2017)
canopy_eddyx_mod -- calculates the estimated eddy diffusivity coefficient (Kest(z/hc)) for vertical diffusion of tracers within the canopy based on Makar et al. (2017). Note:  This should be used to scale the first model layer resolved model diffusivity (Kmod(z1)) to get canopy diffusivity (Kcan(z)) such as     Kcan(z) = [Kmod (z1)/Kest(z1/hc)]  * Kest(z/hc)]
canopy_phot_mod -- photolysis attenuation, currently Beer's law direct beam attenuation as used in Makar et al. (2017)

Tables of input parameter and settings in README
Fixed bugs and other issues
Added a LU_OPT in namelist for using different land use/veg mapping (currently only VIIRS LU)
Added user options for LAI, forest fraction, and canopy height thresholds for contiguous forests
Added simple stem (woody) area index for PAI calculation (PAI = LAI + WAI)
Added MOST and RSL effects to above canopy wind profile.

@zmoon there is already an open review pending for this PR, and no way to send reminder/refresh really.  Your initial comments on this PR were spot on, and I know I added more commits, but they should be relatively straightforward.  Do you mind reviewing this sometime later next week or the following?

@drnimbusrain I guess the re-request button isn't showing because I still have a pending one like you pointed out. For sure I can review later next week!

The namelist param info in readme might work better as tables. I like the idea though.

@zmoon Thank you for the README comment.  I also like the use of tables as well.  Let me know.

@zmoon Thank you for your excellent review!  I think I have addressed all your comments and made the necessary changes, with exception of implementing all submodules as elemental subroutines.  If you agree, we can resolve all conversations and merge this PR into Main, and add the elemental possibility as a new larger issue.  This way we can start to work on the issues to further improve these codes incrementally with your help.

Hey Zach
Yes,  this was a quick calc of DX, I'll add the haversine formula,  and
break this out into its own submodule
On Tue, Sep 27, 2022, 2:48 PM Zachary Moon @.***> wrote:

@.**** commented on this pull request.
In canopy_driver.F90
https://github.com/noaa-oar-arl/canopy-app/pull/20#discussion_r981600810
:

@@ -210,13 +211,32 @@ program canopy_driver
z0ghcm, cdrag, pai, canBOT(i), canTOP(i), canWIND(i, loc))
end do

-! ... calculate wind adjustment factor dependent on canopy winds and fire type
+! ... calculate wind adjustment factor dependent on fires (FRP), canopy winds,
+!                                                        flameh, and fire type

       if (flameh_opt .eq. 0) then

           if (nlon .eq. 1) then      !single lon point -- reset to user value

               flameh = flameh_set

           else                       !calculate flameh

               dx     = dlon*111000.0  !convert lon grid to distance (m)

Yes, it is more robust now. What I was alluding to though is that the
value of dx in such a lat/lon grid changes with latitude. And we could
account for that. But maybe that can wait until we set up to work with 2-d
array inputs (e.g. loaded from netCDF files).
—
Reply to this email directly, view it on GitHub
https://github.com/noaa-oar-arl/canopy-app/pull/20#discussion_r981600810,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGLFYNSHLFQL4DC7QWKFE7LWAM6PLANCNFSM57MJFB4Q
.
You are receiving this because you were mentioned.Message ID:
@.***>


Adding types and queries for flyctl host issues notification

Including a new type to map the results from App Host Issues query.
This is used by flyctl incidents hosts list command, as well as the background task that check for any unresolved host issue affecting the app.

This one is required for https://github.com/superfly/flyctl/pull/3605

@dangra Thanks for the review! Is it safe now to cut a release with scripts/bump_version.sh?


Add flexbug 16

Closes #176.

@philipwalton BTW animating flex-basis, also doesn't work in IE11 but it does in Edge 16. I don't have Edge 15 available to test in.

@dotnetCarpenter thanks! I updated the README.


pipe separated annotation extensions with only one object

malformed GO annotations, do we need a check for this?
mf.gaf:PomBase	SPAC17G6.04c	cpp1	contributes_to	GO:0004660	PMID:10617635	IDA		F	protein farnesyltransferase beta subunit Cpp1		protein	taxon:4896	20140227	PomBase	|has_substrate(PomBase:ras1)
mf.gaf:PomBase	SPAPB1A10.04c	cwp1	contributes_to	GO:0004660	PMID:10617635	IDA		F	geranylgeranyltransferase I and farnesyltransferase alpha subunit Cwp1		protein	taxon:4896	20140227	PomBase	|has_substrate(PomBase:ras1)

It looks like a bug in the code that moves the contributes_to to the qualifier column.  I'll investigate.

Did you see this problem in the Canto GAF export file?

yes. It could be in the curation. I will check...

Ah it was due to the removal of the contributes_to qualifier as you suspected...

Moving to the Canto tracker.


pixman: use gccStdenv on aarch64

aarch64-darwin in particular:
https://hydra.nixos.org/build/197830077
Things done

Built on platform(s)

[ ] no rebuild x86_64-linux
[ ] no rebuild aarch64-linux
[ ] no rebuild x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@ofBorg build pixman

I doesn't work :-(

I suppose in the worst case we could split aarch64-darwin away, using the older version with security patch (we patch on 22.05).

Probably because gccStdenv has this:
      # Remove libcxx/libcxxabi, and add clang for AS if on darwin (it uses
      # clang's internal assembler).
      extraBuildInputs = lib.optional stdenv.hostPlatform.isDarwin clang.cc;

If the gcc assembler can't work on darwin, it seems like we would need to downgrade.

@ofBorg build pixman

FWIW the gccStdenv stuff was put together in 2017 (including using clang for AS), so who knows how it should be today: a5168fe4570acaed5ff306789be5d038f4b95662

@ofBorg build pixman

Still doesn't seem to work: https://logs.nix.ci/?key=nixos/nixpkgs.200156&attempt_id=2cc36828-c17d-42ed-84cc-2c87f908a937

I haven't tried this one:
@ofBorg build pixman

But really... someone actually interested in aarch64-darwin should be solving such problems.

https://logs.nix.ci/?key=nixos/nixpkgs.200156&attempt_id=8beea391-ccbf-476c-be0f-e6351f6cadeb
I guess I'm giving up 🤷🏽

I was able to get it to build by disabling ARM64 Neon on aarch64-darwin. This is using the default, clang-based stdenv.
diff --git a/pkgs/development/libraries/pixman/default.nix b/pkgs/development/libraries/pixman/default.nix
index 49f5fbe8815..39753ac5492 100644
--- a/pkgs/development/libraries/pixman/default.nix
+++ b/pkgs/development/libraries/pixman/default.nix
@@ -18,7 +18,8 @@ stdenv.mkDerivation rec {

   buildInputs = [ libpng ];

-  configureFlags = lib.optional stdenv.isAarch32 "--disable-arm-iwmmxt";
+  configureFlags = lib.optional stdenv.isAarch32 "--disable-arm-iwmmxt"
+   ++ lib.optional (stdenv.isAarch64 && stdenv.isDarwin) "--disable-arm-a64-neon";

   preConfigure = ''
     # https://gitlab.freedesktop.org/pixman/pixman/-/issues/62

@ofBorg build pixman

Thanks.  OfBorg confirmed success, so I pushed it there with you as author.


Translatebooknames

Worked on #147  created UI based translation of book names. please review the code.

Translations need to updated in the app for the new strings.

Translations need to updated in the app for the new strings.

added all translation


Unrecognized input header in Ping Tests

Running swarm on Vagrant. For tests like TestNetworkAddDeleteNoGatewayVXLAN, the checkPing test gives an Unrecognized input header error sometimes.
Error:  value errors.errorString = &errors.errorString{s:"Ping6 failed from (container: 28eb21589f6ec219c613bb6dd6e77e4e024a933aa99fcc312061117a5bffd002 (name: "net1-1-srv3-1" ip: <IP_ADDRESS> ipv6: 1001:1::5 host: netplugin-node2)) to 1001:1::4: "Unrecognized input header\n" - Process exited with: 1. Reason was:  ()"}
... value errors.errorString = &errors.errorString{s:"Ping failed from (container: 8bc44e2410f0133e409a618687d3bc5ed84d65ee1378732d90c9ee00ce3fc36a (name: "net0-0-srv0-0" ip: <IP_ADDRESS> ipv6:  host: netplugin-node1)) to response: "ping: bad address 'response'\n" - Process exited with: 1. Reason was:  ()"}

@apoorva11029 : are you still seeing this error now ?
We use swarm 1.2.0.


Allow @field to have a multiline description

https://github.com/sumneko/lua-language-server/issues/1514

Has allowed.

oh

I believe the request was for multi-line comments on a @field, not a @class.

This works:
---Some class description
---@class test
---Some field description
---@field test_field string

That seems backwards to have the description on top...


Remove "Insipiration", Update "Colors"

Removed Inspiration section as per @jancborchardt 's request in #269
Update Colors section to only link to open source tools.

Note: "Blend" isn't open source but is an awesome tool for generating gradients, I would advise on keeping it in.
Let me know if you still want it removed.


Project dependencies.

[ ] Why do we need drape and drape_frontend for world_roads_builder_tool ?

Don't ask, just fix it :)


Cannot focus space due to an error with the scripting-addition. Ventura 13.2 with HEAD

So I am running the beta of Ventura and seem to have trouble focusing a space
yabai -m space --focus 3
cannot focus space due to an error with the scripting-addition.

I've installed the HEAD version as explained here to do https://github.com/koekeishiya/yabai/issues/1532
Certifying to the new location rather that what which was pointing too and updating sudoers file as well but get a syntax error of
/etc/sudoers:62:13: syntax error
sudo visudo -f /private/etc/sudoers.d/yabai

with the -f underlined
 /opt/homebrew/Cellar/yabai/HEAD-03b2483/bin/yabai -m space --focus 3
cannot focus space due to an error with the scripting-addition.

If there is anything else I can provide let me know.

I'm not sure what happened but it works now

It worked for a moment but then the issue returned

I don't know what happened but it started again. Didn't mean to close the first time.

For the record, I encountered the same issue. It turns out I didn't read the docs carefully enough and blindly copied the line sudo visudo -f /private/etc/sudoers.d/yabai into /etc/sudoers. This was fixed once I removed removed that line from /etc/sudoers and added privileges to /private/etc/sudoers.d/yabai.


ExplicitStringVariableFixer - add failing test case with execution operators

What should be the fix? Converting variable or leaving it untouched? Because definitely not RuntimeException: Index invalid or out of range.
Ping @Slamdunk

How come? For:
<?php
$x = '"foo"';
var_dump(`echo $x`);
var_dump(`echo ${x}`);
var_dump(`echo {$x}`);

I'm getting:
string(4) "foo
"
string(4) "foo
"
string(4) "foo
"

Ah, the value of the variable must be shell escaped to work, didn't remember that!
So, backtick to me is a beast, I propose:

Leave backtick operator untouched
Run backtick to shell exec fixer with higher priority, and thus creating the appropriate integration tests
Point this out in this fixer description

Suppressed by https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/4036


How can i get data in specific time interval from GET /api/v2/k?

I need to get data in specific time interval, for example from 'timestamp1' to 'timestamp2'. How can i do this? For now I can specify only one interval boundary using the 'timestamp' parameter, but this is not enough
peatio version: 1.8.25

OK. I will check this.

Closed via #1342.


Handle all relative links internally

Details
When a New Expensify link is handled in the app we currently open it in a new tab by default. If we use the target="_self" attribute then the link refreshes the page. This is happening because react-navigation is not set up to handle internal links. As a workaround, we will replace any links that begin with https://new.expensify.com with links that target the Navigation.navigate() method so we can navigate internally.
Fixed Issues
$ https://github.com/Expensify/App/issues/5157
Tests / QA Steps

Send a message to another user with a link like https://new.expensify.com/settings
Tap the link and verify the settings page opens and the app does not reload

Tested On

[x] Web
[ ] Mobile Web
[ ] Desktop
[x] iOS
[ ] Android

Screenshots

Web

Mobile Web

Desktop

iOS
https://user-images.githubusercontent.com/32969087/132744112-8941af5f-aea8-42ff-972d-cf3c4802c782.mp4
Android

This actually does not need to hold on anything. I'll just update the test steps.

@aldo-expensify hope you don't mind I'm adding you to this PR since you are assigned to this one already and it is kind of related https://github.com/Expensify/Web-Expensify/pull/31861

Updated :)

Updated :)

Cool!, I thought you were going to keep your initial code.
Anyway, just wanted to say that when I'm commenting about code styling stuff like this, I'm just mentioning it in case it makes sense to you. If you don't agree, it is not my intention to push you into writing code that aligns with my subjective opinion of what "is better". 😬

Looks good to me, tested on web.

Anyway, just wanted to say that when I'm commenting about code styling stuff like this, I'm just mentioning it in case it makes sense to you. If you don't agree, it is not my intention to push you into writing code that aligns with my subjective opinion of what "is better"

Of course! It was a perfect suggestion + the NAB also makes this clear.
In case it wasn't obvious I had to make this joke because I didn't read half of the code you gave me 😂

🚀 Deployed to staging by @marcaaron in version: 1.0.95-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


UX Terms of use why are chapters not linked?

Where to find the issue
Terms of use (Android App)
Describe the issue
The terms of use have a lot of text. So if a user wants to read a special chapter he needs to scroll all the way down.
Suggested change
The easiest way was that you link all chapters. The content will scroll down automatically. Maybe you can also implement an "back to top" button, so that the user must not scroll all the way up.

Thanks, @mrascher-cosee for this UX improvement suggestion. We will discuss that with our colleagues and get back to you once we have an update.
Mit freundlichen Grüßen/Best regards,
SW
Corona Warn-App Open Source Team

In the meanwhile we received feedback from our UX team:

Thank you for the valuable input. In a future version we will provide usability improvements to navigate the terms of use text.

As a consequence, we'll move this issue to cwa-backlog for future follow-ups.
Mit freundlichen Grüßen/Best regards,
SW
Corona Warn-App Open Source Team


removed backslashes from parsing examples

Hi,
The parsing examples in Pony docs contain redundant backslashes which provoke compilation errors.
One example, taken from here:
doc.parse(\"\"\"{"key":"value", "property: true, "array":[1, 2.5, false]}\"\"\")?

The idea for the commit is from @srenatus who helped me find the error in the first place.
All potential errors in this commit are mine.
Cheers,

This does not compile, as the docs is inside a triple-quoted string. If we want to write triple-quotes inside a triple-quoted string, we need to escape. Actually I (having written this doc) assumed this would be gracefully turned into proper quotes by the pony docgen process (the pony lexer handles those escapes). So i would state that the bug is that string escapes that are applied to pony strings in general are not properly handled by docgen.

I suppose we could also fix the example to not use triple quotes, but some heavy escaping. It would be a stopgap until nested triple quotes are somehow supported, and would make the docs correct and copyable. What do you think?

This requires this RFC to be addressed:
https://github.com/ponylang/rfcs/issues/52
For a full solution. In the meantime, a workaround of some sort would be needed.

I suggest a temporary workaround of not using triple-quotes for these JSON string literals, and just escaping the single-quotes inside the JSON. For example:
doc.parse("{\"key\":\"value\", \"property\": true, \"array\":[1, 2.5, false]}")?

@brakmic would you be able to fix the build issues here?

@aturley Not sure how. Wasn't following this thread in a while.
Do we now have a proper workaround?

My comment above is the best bet for the foreseeable future: https://github.com/ponylang/ponyc/pull/3124#issuecomment-479084868

@jemc Ok, let's try it again :)

@brakmic Thank you! 🎉


Refactor espup

As discussed in https://github.com/esp-rs/espup/discussions/154 we are going for a minimal approach, hence I refactored what we have, and here is the resulting behavior:

espup install installs under $RUSTUP_HOME/toolchain/<toolchain_name>:

Xtensa Rust (if any Xtensa target is provided)
Nightly Rust (if any RISC-V target is provided)
Xtensa LLVM clang
GCC for the provided targets (to be served as linker in no_std apps)

This would be removed once LLD can be used

espup update will update the Xtensa rust under  $RUSTUP_HOME/toolchain/<toolchain_name>:

It will use latest if no -v/xtensa_version is provided
If the semver of the version trying to install is the same as the version installed it won't install it but it will print a warning message (as we use an extended version of semver and they might be differences)

espup uninstall  will delete $RUSTUP_HOME/toolchain/<toolchain_name>

Other changes:

Added an option (-s/--std) that avoids installing GCC (it will be installed by esp-idf-sys)
You can modify the Xtensa toolchain name (defaults to esp) by using the -a/name option
[Windows]: Environment variables are automatically injected into your system when installing and cleared when uninstalling
Removed the config file
Dependencies cleanup
Removed -x/--llvm-version option as we only supported one version.
By default, only libs or LLVM are installed, you can opt-in to install the whole llvm with -e/--extended-llvm
Other minor improvements like error naming, logs updated, running some commands in parallel...
cd.yml now also publishes to crates.io

Few important things to note, once we merge it and release a new version:

We will need to update instructions on the book
The Xtensa toolchain action also requires an update since the --profile-minimal option is gone (we use it by default)

* The Xtensa toolchain action also requires an update since the `--profile-minimal` option is gone (we use it by default)

This is a bit problematic, given that any deployments using the current version of the toolchain will start failing once this is published.

* The Xtensa toolchain action also requires an update since the `--profile-minimal` option is gone (we use it by default)

This is a bit problematic, given that any deployments using the current version of the toolchain will start failing once this is published.

Will it pick-up the new version automatically?
Maybe we could re-add that option and print a warning that this is deprecated and a no-op now? I know that is ugly

This is a bit problematic, given that any deployments using the current version of the toolchain will start failing once this is published.

If they are pinned to 1.5.0 it will. Shall we keep the flag even though it does nothing?

I think for the time being maybe just adding a deprecation warning and having it not do anything as @bjoernQ mentioned is fine. I just don't want to keep breaking CI and forcing users (and us) to update over and over, you know?

Forget what I've said about xtensa-toolchain, we are actually not using that flag, even though at some point we did  but it looks like when removing the install.sh I forgot to add it, so xtensa-toolchain would work with no changes required.

Merged the PR, created a pre-release, and tested the action in different repos:

esp-hal
esp-flasher-stub

Ran the CI 5 times in each repo with no issues.
I also had to merge #188 as it was causing some transient errors, as we had in the past (#137).


chore: allow serivce tokens to access builds api

Changes

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1587  👈 (View in Graphite)
#1586
#1585
#1580
#1548
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Fix tests and GH cache issue

Currently since we're equipping our shells with both x64_64 and aarch64 gcc and glibc, which results in quite a large cache size, if we were to upload to and fetch the GH cache, we would easily run into GH cache throttling and rate limiting issues.
Therefore, allowing the nix-setup interface to control the use of the GH cache and disabling it in certain scenarios would be better.

@potsrevennil Seems fine, but can you squash the history and write a commit message summarizing the change please?


Remove inclusion of deprecated FrameGrabber header

Fix warning:
 [4/53] Building CXX object plugins\camera\CMakeFiles\gz-sim-yarp-camera-system.dir\CameraDriver.cpp.obj
C:\Users\runneradmin\micromamba\envs\gzyarppluginsdev\Library\include\yarp/dev/FrameGrabberInterfaces.h(11) : warning:"<yarp/dev/FrameGrabberInterfaces.h> file is deprecated"
[5/53] Building CXX object libraries\device-registry\CMakeFiles\gz-sim-yarp-device-registry.dir\DeviceRegistry.cc.obj

not sure why, but somehow the warning was printed just on Windows.

Rebased on main. Merging 🚀


Unable to import classes from other files or use methods from other files

Whether they're kts or kt files, I'm unable to use classes from other files in the same folder -- even if I include them at the top.
E.g.
SomeClass.kt:
object SomeClass {
   fun doSomething() { ... }
}

class SomeClass2 {
   fun doSomething() { ... }
}

main.kts
@file:Include("SomeClass.kt")

// Doesn't work
SomeClass.doSomething()

// Also doesn't work
SomeClass2().doSomething()

If I use --idea, IJ suggests adding import SomeClass.SomeClass at the top, but that doesn't help when I try to run it again from the CLI.

I'm also unable to use functions defined in other .kts files, even though the README shows that being possible. Regular functions and extension functions both.

Oh, the issue was that classes in other included files shouldn't be imported at all. What IJ suggests is totally wrong.


add ability to set what .env file to load

pyqwe is able to load .env files with the extra pyqwe['dotenv'] installed.
I'd like to see the ability to set what envs file to load, or maybe have the option of multiple env files.
Proposed:
[tool.pyqwe]
__envs__ = [".env", ".other.env"]
group = [
    "@sync",
    "*:echo '{{ ENV1 }} 1'",
    "*:echo '{{ ENV2 }} 2'",
    "*:echo '{{ ENV3 }} 3'"
]

and or
[tool.pyqwe]
__env__ = ".env"
group = [
    "@sync",
    "*:echo '{{ ENV1 }} 1'",
    "*:echo '{{ ENV2 }} 2'",
    "*:echo '{{ ENV3 }} 3'"
]

done in #5


Allow getting merge requests which would close an issue

See https://github.com/gitlabhq/gitlabhq/blob/master/doc/api/issues.md#list-merge-requests-that-will-close-issue-on-merge
Please merge asap, thank you

Hello, could you add an unit test and fix code style according to styleci?

Thanks @fbourigault, I've sorted those now. Thanks.

Thank you!

Thanks. Would you mind releasing 9.4.0 with this included so I can clean up my composer file?


Support for GRPC

The Problem
Adding interfaces to you enable GRPC

closes #278
The Solution
Generated interfaces for GRPC.

Hi @janus, I've invited you to be a collaborator on the repo. Can you make a branch directly off the main repo so that the team also can help push to the branch? That way we can give feedback and help make changes directly in the branch.

Hi @janus, I've invited you to be a collaborator on the repo. Can you make a branch directly off the main repo so that the team also can help push to the branch? That way we can give feedback and help make changes directly in the branch.

Hi @janus, I've invited you to be a collaborator on the repo. Can you make a branch directly off the main repo so that the team also can help push to the branch? That way we can give feedback and help make changes directly in the branch.

Sure, and thanks. I would do that once I get back to my laptop.

Hi @janus, I've invited you to be a collaborator on the repo. Can you make a branch directly off the main repo so that the team also can help push to the branch? That way we can give feedback and help make changes directly in the branch.

Sure, and thanks. I would do that once I get back to my laptop.

Hi @janus, thanks for this! I'm curious how I can go about testing this. Can you write up some docs on it? For example we have example HTTP requests here: modules/server-node/examples. Would be great if we can have something similar for this.

Okay....I would.

Hi @janus, thanks for this! I'm curious how I can go about testing this. Can you write up some docs on it? For example we have example HTTP requests here: modules/server-node/examples. Would be great if we can have something similar for this.

Okay....I would.

Hi @janus, I've invited you to be a collaborator on the repo. Can you make a branch directly off the main repo so that the team also can help push to the branch? That way we can give feedback and help make changes directly in the branch.

Sure, and thanks. I would do that once I get back to my laptop.

Never mind, this is not necessary. I am able to check out your fork. Just leave it as is.
https://stackoverflow.com/questions/5884784/how-to-pull-remote-branch-from-somebody-elses-repo

Hi @janus, I've invited you to be a collaborator on the repo. Can you make a branch directly off the main repo so that the team also can help push to the branch? That way we can give feedback and help make changes directly in the branch.

Sure, and thanks. I would do that once I get back to my laptop.

Never mind, this is not necessary. I am able to check out your fork. Just leave it as is.
https://stackoverflow.com/questions/5884784/how-to-pull-remote-branch-from-somebody-elses-repo

Hey @janus, How it's going?

Hey @janus, How it's going?

Hi, @janus, are you working on this issue anymore? The progress has been slow and unresponsive recently.

Hi, @janus, are you working on this issue anymore? The progress has been slow and unresponsive recently.

Hi, @janus, are you working on this issue anymore? The progress has been slow and unresponsive recently.

Sorry , I had light fever.  I am getting back to work.

Hi, @janus, are you working on this issue anymore? The progress has been slow and unresponsive recently.

Sorry , I had light fever.  I am getting back to work.

@janus Don't worry, We picked up the task on our end. We are merging this pr. Thanks for your hard work!

@janus Don't worry, We picked up the task on our end. We are merging this pr. Thanks for your hard work!

@janus can you share the exact command you used to generate the TS types from the proto files?

@janus can you share the exact command you used to generate the TS types from the proto files?

@janus can you share the exact command you used to generate the TS types from the proto files?

Sure... Once I get to my computer

@janus can you share the exact command you used to generate the TS types from the proto files?

Sure... Once I get to my computer

@janus can you share the exact command you used to generate the TS types from the proto files?

protoc  --plugin node_modules/.bin/protoc-gen-ts --ts_out modules/server-node/server/generated --ts_opt optimize_code_size  modules/server-node/server/proto/vector.proto

@janus can you share the exact command you used to generate the TS types from the proto files?

protoc  --plugin node_modules/.bin/protoc-gen-ts --ts_out modules/server-node/server/generated --ts_opt optimize_code_size  modules/server-node/server/proto/vector.proto

@sanchaymittal   Don't forget to follow this links, https://github.com/timostamm/protobuf-ts/blob/v1.0.0/MANUAL.md#googleprotobufany
and
https://github.com/improbable-eng/ts-protoc-gen

@sanchaymittal   Don't forget to follow this links, https://github.com/timostamm/protobuf-ts/blob/v1.0.0/MANUAL.md#googleprotobufany
and
https://github.com/improbable-eng/ts-protoc-gen

Thanks for your generosity.  I would find a way of paying you back.

Thanks for your generosity.  I would find a way of paying you back.

Thanks for the links! That's exactly what we needed! I think I have things generally set up in our app now, so I will begin writing out tests and building it. Do you have experience with grpc-web? Would like to hear your thoughts.

Thanks for the links! That's exactly what we needed! I think I have things generally set up in our app now, so I will begin writing out tests and building it. Do you have experience with grpc-web? Would like to hear your thoughts.

Thanks for the links! That's exactly what we needed! I think I have things generally set up in our app now, so I will begin writing out tests and building it. Do you have experience with grpc-web? Would like to hear your thoughts.

Sorry for late reply. I have not done grpc-web before, but I don't think it is all that hard. And I was also thinking that it would reduce duplication if applied in this task.  Should I research it?

Thanks for the links! That's exactly what we needed! I think I have things generally set up in our app now, so I will begin writing out tests and building it. Do you have experience with grpc-web? Would like to hear your thoughts.

Sorry for late reply. I have not done grpc-web before, but I don't think it is all that hard. And I was also thinking that it would reduce duplication if applied in this task.  Should I research it?

Hi @janus take a look at this: https://github.com/connext/vector/pull/326
I redid the protobuf and started building out the client and server. If you have a good idea of how to implement grpc-web into this we can chat about another bounty.

Hi @janus take a look at this: https://github.com/connext/vector/pull/326
I redid the protobuf and started building out the client and server. If you have a good idea of how to implement grpc-web into this we can chat about another bounty.

Can we work together on this? Leave monetary part aside. I want to see this work.

Can we work together on this? Leave monetary part aside. I want to see this work.


Store IID of ML-EID in NVM.

IID in ML-EID is chosen at random, but should be persistent over reboots. This PR adds this feature.

Codecov Report

Merging #1423 into master will decrease coverage by -0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1423      +/-   ##
==========================================
- Coverage   69.18%   69.14%   -0.04%
==========================================
  Files         184      184
  Lines       26982    26986       +4
  Branches     3402     3402
==========================================
- Hits        18668    18660       -8
- Misses       6889     6891       +2
- Partials     1425     1435      +10

Impacted Files
Coverage Δ

include/openthread/types.h
100% <ø> (ø)
:white_check_mark:

src/core/thread/mle.hpp
94.44% <ø> (ø)
:white_check_mark:

src/core/thread/mle.cpp
80.7% <100%> (-0.74%)
:x:

src/core/thread/lowpan.hpp
86.84% <0%> (-13.16%)
:x:

...d_party/mbedtls/repo/library/memory_buffer_alloc.c
60.64% <0%> (-2.59%)
:x:

src/core/thread/lowpan.cpp
92.29% <0%> (-1.44%)
:x:

third_party/mbedtls/repo/library/ctr_drbg.c
72.05% <0%> (-0.74%)
:x:

src/core/thread/network_data_leader_ftd.cpp
67.99% <0%> (-0.47%)
:x:

src/core/thread/mle_router.cpp
79.8% <0%> (-0.43%)
:x:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de48acf...57b77fe. Read the comment docs.


remove references to previous inchi license

As mentioned https://github.com/IUPAC-InChI/InChI/issues/8#issuecomment-1953631931
the INCHI-1-SRC/LICENCE.pdf file should be removed
Additionally, here is a list of places to review and eventually have the license replaced/removed
> grep -rl "InChI-Trust Licence" *
INCHI-1-DOC/misc/announce.txt
INCHI-1-DOC/misc/banner-v105-from-alan-2016-02-18.txt
INCHI-1-DOC/misc/banner-v105-final-2016-02-18.txt
INCHI-1-DOC/CHANGELOG.md
INCHI-1-DOC/FAQ/html/inchi-faq.html
INCHI-1-DOC/FAQ/doc/inchi-faq.doc
INCHI-1-DOC/External-contributors/External-contributors
INCHI-1-DOC/readme.txt
INCHI-1-SRC/INCHI_BASE/redundant/aux2atom.h
INCHI-1-SRC/INCHI_BASE/src/sha2.c
INCHI-1-SRC/INCHI_BASE/src/sha2.h
INCHI-1-SRC/INCHI_API/demos/inchi_main/readme.txt
INCHI-1-SRC/INCHI_API/demos/mol2inchi/readme.txt
INCHI-1-SRC/INCHI_API/demos/mol2inchi/src/moreutil.c
INCHI-1-SRC/INCHI_API/demos/mol2inchi/src/mol2inchi.h
INCHI-1-SRC/INCHI_API/demos/mol2inchi/src/moreutil.h
INCHI-1-SRC/INCHI_API/demos/mol2inchi/src/mol2inchi.c
INCHI-1-SRC/INCHI_API/demos/python_sample/readme.txt
INCHI-1-SRC/INCHI_API/demos/readme.txt
INCHI-1-SRC/INCHI_API/demos/test_ixa/readme.txt
INCHI-1-SRC/INCHI_API/demos/test_ixa/src/moreitil.h
INCHI-1-SRC/INCHI_API/demos/test_ixa/src/moreutil.c
INCHI-1-SRC/INCHI_API/demos/test_ixa/src/test_ixa.h
INCHI-1-SRC/INCHI_API/demos/test_ixa/src/test_ixa.c
INCHI-1-SRC/readme.txt

Please note, the license of files with no explicit text defaults to the one included in the package so removing all the license info from headers is an option to avoid this kind of issues in the future

@giallu A supporting «+1» from my side because this compilation could help the maintainers to remove the obstacles which prevent an update of the inchi executable in Debian (package tracker).  This then would propagate into Debian's relatives (Ubuntu, Mint, etc), too.  See the corresponding ticket over there, filed by July 17th.

@nbehrnd yeah, as a (former) Fedora package maintainer I am very much familiar with issues like this...
@JanCBrammer would you consider a PR with these changes implemented?

So, there is a little complication here in sha2.h/c because they are are Copyright (C) Brainspark B.V.
Someone has to contact the copyright holder and get permission to relicense or, alternatively, a new implementation should be added.

@JanCBrammer would you consider a PR with these changes implemented?

Absolutely!

I have some correspondence from 2010 where we previously got agreement from the copyright owner to change the licence to the text below (including the proviso that it only applies to the InChI implementation). As this includes the reference to the MIT license (e.g. to dual license), I need to dig a bit further to find out why we didn't go through with this at the time, and updated the bespoke license

Change the text in the file 'readme.txt' in the INCHI-1-API archive/directory
(directory with source files).
Currently it is:
"The portion of this distribution, the files sha2.c and sha2.h
are Copyright (C) 2003-2006  Christophe Devine and are distributed under
the terms of the GNU Lesser General Public  License, version 2.1
as published by the Free Software Foundation (see heading comments in
these files).
LGPL text is included (the file LICENSE) in this distribution."
Suggested replacement:
"The portion of this distribution, the files sha2.c and sha2.h,
were originally written by Christophe Devine who then transferred the
copyright to Paul Bakker for PolarSSL library (http://www.polarssl.org/).
As allowed by Paul Bakker and Christophe Devine, these files are distributed
with the InChI software under the terms of either the GNU Lesser General
Public  License, version 2.1, or MIT license. Note that this licensing is
only valid in combination with the InChI software package and not for the
files sha2.c and sha2.h in its own.
LGPL and MIT license texts are included (the files LICENSE and MIT-LICENSE)
in this distribution."
3
Place the text of MIT license (from http://www.opensource.org/licenses/mit-license.php)
in the file MIT-LICENSE in the INCHI-1-API archive/directory (directory with
source files).
4
Change the heading comments in the files sha2.c and sha2.h.
Currently it is:
/*

FIPS-180-2 compliant SHA-256 implementation

Copyright (C) 2003-2006  Christophe Devine

This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License, version 2.1 as published by the Free Software Foundation.

This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
Lesser General Public License for more details.

You should have received a copy of the GNU Lesser General Public
License along with this library; if not, write to the Free Software
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
MA  02110-1301  USA
*/

Suggested replacement:
/*

FIPS-180-2 compliant SHA-256 implementation

Copyright (C) 2010  Paul Bakker.
Originally written (2003-2006) by Christophe Devine.

This code is free software; you can redistribute it and/or
modify it, as a part of the International Chemical Identifier (InChI)
software, under the terms of either:
a) the GNU Lesser General Public License as published by the Free Software
Foundation
http://www.opensource.org/licenses/lgpl-2.1.php
or
b) MIT license
http://www.opensource.org/licenses/mit-license.php
modify it under the terms of the GNU Lesser General Public
License, version 2.1 as published by the Free Software Foundation.
Note that this licensing is  only valid in combination with the InChI
software package, for all other cases contact Paul Bakker.

*/

I'm wondering whether InChI's SHA-256 implementation could be replaced with a library call (e.g. from libcrypt) or with a less problematic implementation.
Implementations I found so far:

musl's crypt/crypt_sha256.c (public domain)
libxcrypt looks like a mishmash of 2-Clause BSD, public domain and LGPL-2.1
OpenSSL's implementation (Apache License 2.0)

OK, I have reviewed the discussions from 2010. At the time, we shied away from dual licensing as at that point it wasn't easy for others to contribute to the open source code, so individual fixes may not have been donated back to the codebase.  We are no longer in that position, so it sounds like either:
a) we use the existing implementation, which would require some text acknowledgement as suggested/agreed above (obviously removing the LGPL references). readme.txt and in the headers of the sha routines?
b) we replace the implementation - was also suggested back in 2010, but not with any specifics. Presumably comes with a testing overhead
Let me know if you wish me to reconfirm text in a) with the copyright owner

Implementations I found so far:

musl's crypt/crypt_sha256.c (public domain)
libxcrypt looks like a mishmash of 2-Clause BSD, public domain and LGPL-2.1
OpenSSL's implementation (Apache License 2.0)

Also https://github.com/amosnier/sha-2 has a very liberal and compatible license.

OK, I have reviewed the discussions from 2010. At the time, we shied away from dual licensing as at that point it wasn't easy for others to contribute to the open source code, so individual fixes may not have been donated back to the codebase. We are no longer in that position, so it sounds like either: a) we use the existing implementation, which would require some text acknowledgement as suggested/agreed above (obviously removing the LGPL references). readme.txt and in the headers of the sha routines? b) we replace the implementation - was also suggested back in 2010, but not with any specifics. Presumably comes with a testing overhead
Let me know if you wish me to reconfirm text in a) with the copyright owner

I would definitely opt for solution a).
The reason is simple: how can one know if the licences of the above proposed new solutions are not be changed, and that SHAx .c/,h files/sections will not have to be rewritten each time that happens?
Rewriting a licence seems less time wasting than rewriting the same code all over again so it could fit the new licence and/or GitHub solution.

I would definitely opt for solution a). The reason is simple: how can one know if the licences of the above proposed new solutions are not be changed (or that these GitHub repositories will not just be deleted by the author), and that SHAx .c/.h files/sections will not have to be rewritten each time that happens? Revising a licence seems less time wasting than rewriting the same code all over again so it could fit a new licence and/or GitHub solution.

This is a sensible concern; I think one long term solution is to get those files (with their current license) and add them to the repo replacing the current implementation. You need to do this exactly once unless at a later point in the future you want to get some updated code where they actually changed the license (which seems unlikely, at least with the repo I linked)
Since there is a nice regression test suite in inchi this change looks also not that risky, given it can be checked against an arbitrary number of compounds

Update on the SHA code:
Copyright was sold to ARM and now expressed in the Mbed-TLS project - which is dual licensed as Apache or GPL
SHA code here
I believe Apache is compatible with MIT - although the Mbed-TLS code is newer than the one we are reusing, is it sensible/acceptable to bring across the Apache license to the SHA code? I ask inchi-discuss for more comment if we need more views.

I believe Apache is compatible with MIT - although the Mbed-TLS code is newer than the one we are reusing, is it sensible/acceptable to bring across the Apache license to the SHA code? I can ask inchi-discuss for more comment if we need more views.

As far as I know yes, they are compatible but the implementation needs to updated to the one with the correct license, you can't just stick the new license to the old implementation.
Of course everything needs to tested for regression so I guess the amount of work to do is the same as any other replacement code. At this point it seems someone needs to approve one of the implementations mentioned

Thanks @giallu @nbehrnd - I can see the issue of applying a new license to old code.
I guess ahead of any investigation/swapping of replacement code, we could apply the text agreed in 2010 but not used. which I think is what is there in your latest update

I guess ahead of any investigation/swapping of replacement code, we could apply the text agreed in 2010 but not used. which I think is what is there in your latest update

Correct. I have used the text you provided in https://github.com/IUPAC-InChI/InChI/issues/33#issuecomment-2255659013 to update the license of those two files.
I am not sure how the additional restriction "this is valid only in conjunction with the Inchi library" is going to fly with the legal teams usually behind larger distros, but the current text is a blocker so I would start from merging this change

@kiddr Thanks to work by @merkys, InChI 1.07.1 was admitted today into Linux Debian's branch testing (note by Debian's package tracker, the monitor by repology).  The contents of this branch prepares the next release of Debian 13/trixie itself; other distributions closely related (e.g., Ubuntu, Mint) typically benefit from this, and update their repositories within a couple of days, too.
The many others may prepare an update when deemed suitable for them.

Thanks a lot for making the update of InChI library possible! By the way, some files under INCHI-1-SRC/INCHI_API/demos/python_sample/ still contain the previous InChI Trust license.


S3 KMS encryption not supported

The plugin does not seem to support uploads into S3 buckets that have SSE KMS encryption enabled.
I had to explicitly override the logic for getHandleUpload function.
    const kmsKeyId = process.env.S3_KMS_KEY_ID
    const sse = kmsKeyId ? ServerSideEncryption.aws_kms : ServerSideEncryption.AES256

    if (file.buffer.length > 0 && file.buffer.length < multipartThreshold) {
      await getStorageClient().putObject({
        Bucket: bucket,
        Key: fileKey,
        Body: fileBufferOrStream,
        ACL: acl,
        ServerSideEncryption: sse, // new param
        SSEKMSKeyId: kmsKeyId, // new param
        ContentType: file.mimeType
      })

      return data
    }

That KMS key is set as a default encryption key for the bucket, I'm not sure if it matters, though.

This plugin is now being maintained in the Packages Directory of the Payload Monorepo. This repo will soon be archived and all open issues will be closed. This issue, however, will be transferred over.


Remove coordinator in Druid Cluster config (#5164)

The coordinator host is only used to get the version of druid, which can be replaced by calling broker.
This change removes the need to configure a coordinator in the Druid Cluster.
After

Codecov Report

Merging #6443 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #6443      +/-   ##
==========================================
- Coverage   73.37%   73.36%   -0.01%
==========================================
  Files          67       67
  Lines        9587     9584       -3
==========================================
- Hits         7034     7031       -3
  Misses       2553     2553

Impacted Files
Coverage Δ

superset/connectors/druid/views.py
67.58% <ø> (ø)
:arrow_up:

superset/connectors/druid/models.py
82.41% <100%> (-0.07%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b2c650...97bc2fc. Read the comment docs.


Updated to Godot4

Hi,
I updated this addon to Godot 4, I tested on my local development (macOS M1),
I will test on my linux machine but I can test on the windows,
Hope this can be helpful

@jotson I think in this case you can create a separate entrance by manually uploading it once and creating a new entrance with 4.0 as a specified version and then use the ID in the upload CI/CD instead of the 3.x one🤔

I've no idea...
Maybe a secondary branch to hold the 4.0 version while isn't stable.
And create a new entry in the asset library... Right?

@shinspiegel Hey shin! Just merged this into new branch godot4
Please give it a whirl and make sure it still works for you on your mac. I'll be testing it here on my linux workstation. If it looks good I'll setup a new asset library entry for it.

So I tested it on Win10 and noticed several things:
This here gets out of bounds if minimized too much

The font of Gravity8 doesn't get applied to the spawned character effects:

OH MY GOD!
There is much more to fix it.
I'll take another look and double-check for some rough-edges...
Thanks for the images @paddy-exe  :D


Update to nalgebra 0.27.1 to avoid RUSTSEC-2021-0070

statrs's latest version is 0.14.0. (Even though the website says it is 0.13.0, in the README.md and the link to the docs in the "About" section at the top right.)
statrs 0.14.0 depends on nalgebra 0.26. nalgebra has a RUSTSEC-2021-0070 advisory against it. Among other things, this causes cargo deny to fail.
Version 0.27.1 of nalgebra fixes the advisory.
It would be very helpful if statrs could have its dependency on nalgebra updated to 0.27.1, and then a new version of statrs (0.14.1 or 0.15.0) be released. Thank you.

Was the fix backported to nalgebra 0.26? If no, this will be a breaking change, and we will have to release statrs 0.15 to fix it, because nalgebra is part of the public interface.

@troublescooter Should we already release 0.15?

Thank you for the fast response. As far as I can tell, the fix has not been backported to nalgebra 0.26. The most recent 0.26 release is 0.26.2, which was released on April 27. 0.27.0 was released on June 2, and 0.27.1 was released on June 4. (The exact dates may vary slightly depending on your timezone.) The advisory is dated June 6.

A 0.15 release would be great. This issue has been closed because of #142, but until there's a new release the problem hasn't been fully addressed in a way that is useful to ordinary statrs users.

Thanks for the ping, 0.15 is now up.

Thank you! I see 0.15 is present on crates.io, docs.rs, and it is named in the README. But some of the GitHub widgets still show 0.14 and 0.13:

I'm not sure why that is.

The doc link was in the Cargo.toml and releases track the tags/releases done on Github. I don't know about the crates.io widget, the rest is now fixed. Thanks!

I don't know about the crates.io widget, the rest is now fixed.

I guess we have to wait until shields.io updates the image.


Feature Request: environment dependent variables in step parameters

Currently, Gauge supports environment specific properties on the step implementation side.
For my project I am looking for a way to use placeholders also in the spec definition.
I am thinking of something like this:
table:${env}/params.csv
Or this:
* open page "https://${domain}/home.html"
It would empower our testers, and make the steps more explicit in many cases because some parameters should not be hidden behind the implementation.
The alternative would be to "build" the spec file for the respective environment, which I would like to avoid.
Thank you for considering

This will help solve https://github.com/getgauge/gauge/issues/1083

I second this request!!
I also require this functionality. In fact, i was about to raise a feature request for this.
We keep our test data under env/some-env/data which is environment specific data. its hard to create dynamic specs which references the data files without hard coding an environment like default.
i would like to be able to do the exact thing as proposed in the description where we specify the env as a placeholder in the spec which gets injected with the actual runtime env passed in thru -e=xyz.
* This is a step with data <file:/env/${env}/data/mydata.csv>

Thanks

but cannot you not use the path to the data in the env/some-env/user.properties and then not define it in the step, but simply load it in the implementation ?
as a tester i would rather read
* open webpage
rather than
* open page "https://${domain}/home.html"
the first is way more intuitiv and readable

We have a step implementation library for a set of different projects. Our testers are happy, because they can reuse many parts.
At the moment placeholders in some steps' parameters are replaced in that library, but it would be much better to have it globally.

We are also loading  "table:src/testdata/test.csv" at scenario level rather than step level. Kindly implemented this feature so we can load environment based csv file.

Unfortunately file contents are required while parsing the spec files to check for parameters, so Gauge cannot support loading the cdv's dynamically.
The workaround to this is to generate csv per environment outside gauge and then run the Gauge specs.
Also gauge will not be adding environment variable syntax to it's specs.

I support this feature.
Suppose, We have this step:

Enter  into current web-element

Sometimes, I want to use it like this:

Enter "Hello" into current web-element

But sometimes, I want to enter variable name instead of explicit text, or even combine them, like:

Enter "Hello ${username}" into current web-element

NB. username var is not only env-dependent but also changes form run to run, so it's impossible hard-code it into env.properties files.


One extra achivement

Its counting me as having some achievement that i dont have. i have 1141 currently and it counts 1142, and no this isn't user error.

Can give more details?

Can give more details?

I found out its just paimon moe having dupe achievements. nothing wrong with the scanner


It doesn't like toml formatted config, or I can't figure out the format.

I have a json config that works:
{ "domain": "tarv.xyz", "token": "/etc/zeronsd/token", "hosts": "/etc/zeronsd/hosts", "wildcard": true }
If I convert that to toml through some website that does json to toml:
domain = "tarv.xyz"
token = "/etc/zeronsd/token"
hosts = "/etc/zeronsd/hosts"
wildcard = false

I get an error:
[2022-02-22T22:26:05Z ERROR zeronsd::cli] invalid type: string "domain = \"tarv.xyz\" token = \"/etc/zeronsd/token\" hosts = \"/etc/zeronsd/hosts\" wildcard = false", expected struct Launcher at line 1 column 1

Edit:
Oh sorry! with --config-type=toml, it works.
It seems detect json and yaml automatically without using that flag.

that's because JSON is also valid YAML (honest; look it up). Closing this one as invalid. Ha!

that's because JSON is also valid YAML (honest; look it up). Closing this one as invalid. Ha!

good grief!


Markers don't show up on initial page load after MAP_READY

I'm submitting a ...

[ ] question
[x] any problem or bug report

OS:

[x] Android
[ ] iOS
[ ] Browser

Phonegap Version: cli-9.0.0
Plugin Version: current
Plugins:

cordova-plugin-whitelist
cordova-plugin-splashscreen
cordova-plugin-googlemaps

Current behavior:
Hey!
When i load a map on Android and set markers after MAP_READY was fired, the markers don't show at the first page load. When i reload the page the markers will show up. I think it's because the map images are in the cache. When i add a timeout to the MAP_READY event, the markers show up also at the first load.
[Android]
Without setTimeout, no markers show up on the initial load of the page:
var myMarkers = [
{position: {lng: 115.140923, lat: -8.656873}},
{position: {lng: 115.128372, lat:-8.657434}}
];

var mapDiv = document.getElementById("spot-map");

var spotMap = plugin.google.maps.Map.getMap(mapDiv, {
mapType: plugin.google.maps.MapTypeId.HYBRID,
camera: {target: {lat: -8.660232, lng: 115.130257}, zoom: 14},
controls: {compass: false, myLocation: true, myLocationButton: false, indoorPicker: false, zoom: false},
gestures: {scroll: false, tilt: false, rotate: false, zoom: false}
});

spotMap.on(plugin.google.maps.event.MAP_READY, function(){
var bounds = [];
var markers = myMarkers.map(function(options){bounds.push(options.position);return spotMap.addMarker(options);});
});

When i add a timeout, it works:
spotMap.on(plugin.google.maps.event.MAP_READY, function(){
setTimeout(function(){
var bounds = [];
var markers = myMarkers.map(function(options){bounds.push(options.position);return spotMap.addMarker(options);});
},1000);
});

Looks like the MAP_READY event is to fast?!

Could you clean up your post?
https://github.com/mapsplugin/cordova-plugin-googlemaps/issues/2661

And what version number of this plugin do you use?

Current version (2.7.1 from npm)

Could you try the multiple_maps branch version?
You can specify https://github.com/mapsplugin/cordova-plugin-googlemaps#multiple_maps

Same issue. I open the page with the map at the first time and no markes show up. I go back to the previous page and open the page with the map a second time and the markers show up.

Markers works with this version but now i can't open a second map. When i open the first page, the map and the markers load. I go back and open another page with other coordinates, the map shows the first map (position) and i can't scroll or zoom.

Ok, could you share your project files on GitHub repository? I need to know more details about your code.

ping


feat: Drawerifies the payments

Also adds in some helpful placeholders / formatters for user info and
images

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#61  👈
#60
#55
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jhechtf and the rest of your teammates on  Graphite

Merge activity

Jun 7, 5:56 PM EDT: @jhechtf started a stack merge that includes this pull request via Graphite.


Documented GFXReconstruct PR Process

Adding some info on our process to the CONTRIBUTING.md guide.
Co-authored-by: Andrew Cox<EMAIL_ADDRESS>

CI gfxreconstruct build queued with queue ID 9652.

I will merge this without further review by end of day if there are no CI failures. Effectively, I am the reviewer of the original source document.

CI gfxreconstruct build # 2363 running.

I needed somewhere to put the images and chose to create a new directory structure: docs/img and place then in the leaf of that.

CI gfxreconstruct build # 2363 failed.

CI gfxreconstruct build queued with queue ID 10582.

Should be ready now if it passes CI.

CI gfxreconstruct build # 2374 running.

CI gfxreconstruct build # 2374 passed.