can i get my photo labels in album

Hi, can i get my photo labels in album, forexample:
1.heic, cat
2.png, dog
thx

I'm sorry I don't quite understand the question.  I think you may be asking if you can get the labels associated with photos in a particular album.  If so, here are some possible solutions.

Use jq which can be installed via brew install jq to parse the json output of osxphotos query:

osxphotos query --album "Album Name" --json | jq '.[] | .original_filename, .labels'
gives output similar to this:
"41578245374_61d718bd40_o.jpg"
[
  "Boat",
  "Dock",
  "Harbor",
  "Machine",
  "Mast",
  "Outdoor",
  "Pole",
  "Sky",
  "Vehicle",
  "Water",
  "Watercraft"
]
"Pumkins1.jpg"
[]
"[2020-08-29] AAF035.jpg"
[
  "Blue Sky",
  "Outdoor",
  "Palm Tree",
  "Plant",
  "Sky",
  "Tree"
]

Alternatively, to get the exact format you asked for, a simple python script that can be run with osxphotos run will give you the output.  Save the script below into a file called album_names.py then run it with:

osxphotos run album_labels.py "Test Album"
Pumkins2.jpg,
Pumkins1.jpg,
41578245374_61d718bd40_o.jpg, Boat,Dock,Harbor,Machine,Mast,Outdoor,Pole,Sky,Vehicle,Water,Watercraft
[2020-08-29] AAF035.jpg, Blue Sky,Outdoor,Palm Tree,Plant,Sky,Tree

"""Print name of all photos in a Photos album and their associated labels"""

import click

import osxphotos

@click.command()
@click.argument("album_name")
def album_labels(album_name):
    """Print name of all photos in a Photos album and their associated labels"""
    photosdb = osxphotos.PhotosDB()
    album = [album for album in photosdb.album_info if album.title == album_name]
    if not album:
        raise click.ClickException(f"Album '{album_name}' not found")

    # could be more than one album with same name so process them all
    for a in album:
        for photo in a.photos:
            print(f"{photo.original_filename}, {','.join(photo.labels)}")

if __name__ == "__main__":
    album_labels()

Finally, I assume by labels you mean what osxphotos refers to as labels which are the automated categories/labels assigned by Photos as it does image classification on each photo.  If you mean user assigned keywords, you'd have to replace labels with keywords in the above examples.

I'm sorry I don't quite understand the question. I think you may be asking if you can get the labels associated with photos in a particular album. If so, here are some possible solutions.

Use jq which can be installed via brew install jq to parse the json output of osxphotos query:

osxphotos query --album "Album Name" --json | jq '.[] | .original_filename, .labels'
gives output similar to this:
"41578245374_61d718bd40_o.jpg"
[
  "Boat",
  "Dock",
  "Harbor",
  "Machine",
  "Mast",
  "Outdoor",
  "Pole",
  "Sky",
  "Vehicle",
  "Water",
  "Watercraft"
]
"Pumkins1.jpg"
[]
"[2020-08-29] AAF035.jpg"
[
  "Blue Sky",
  "Outdoor",
  "Palm Tree",
  "Plant",
  "Sky",
  "Tree"
]

Alternatively, to get the exact format you asked for, a simple python script that can be run with osxphotos run will give you the output.  Save the script below into a file called album_names.py then run it with:

osxphotos run album_labels.py "Test Album"
Pumkins2.jpg,
Pumkins1.jpg,
41578245374_61d718bd40_o.jpg, Boat,Dock,Harbor,Machine,Mast,Outdoor,Pole,Sky,Vehicle,Water,Watercraft
[2020-08-29] AAF035.jpg, Blue Sky,Outdoor,Palm Tree,Plant,Sky,Tree

"""Print name of all photos in a Photos album and their associated labels"""

import click

import osxphotos

@click.command()
@click.argument("album_name")
def album_labels(album_name):
    """Print name of all photos in a Photos album and their associated labels"""
    photosdb = osxphotos.PhotosDB()
    album = [album for album in photosdb.album_info if album.title == album_name]
    if not album:
        raise click.ClickException(f"Album '{album_name}' not found")

    # could be more than one album with same name so process them all
    for a in album:
        for photo in a.photos:
            print(f"{photo.original_filename}, {','.join(photo.labels)}")

if __name__ == "__main__":
    album_labels()

Finally, I assume by labels you mean what osxphotos refers to as labels which are the automated categories/labels assigned by Photos as it does image classification on each photo. If you mean user assigned keywords, you'd have to replace labels with keywords in the above examples.

I'm sorry I don't quite understand the question. I think you may be asking if you can get the labels associated with photos in a particular album. If so, here are some possible solutions.

Use jq which can be installed via brew install jq to parse the json output of osxphotos query:

osxphotos query --album "Album Name" --json | jq '.[] | .original_filename, .labels'
gives output similar to this:
"41578245374_61d718bd40_o.jpg"
[
  "Boat",
  "Dock",
  "Harbor",
  "Machine",
  "Mast",
  "Outdoor",
  "Pole",
  "Sky",
  "Vehicle",
  "Water",
  "Watercraft"
]
"Pumkins1.jpg"
[]
"[2020-08-29] AAF035.jpg"
[
  "Blue Sky",
  "Outdoor",
  "Palm Tree",
  "Plant",
  "Sky",
  "Tree"
]

Alternatively, to get the exact format you asked for, a simple python script that can be run with osxphotos run will give you the output.  Save the script below into a file called album_names.py then run it with:

osxphotos run album_labels.py "Test Album"
Pumkins2.jpg,
Pumkins1.jpg,
41578245374_61d718bd40_o.jpg, Boat,Dock,Harbor,Machine,Mast,Outdoor,Pole,Sky,Vehicle,Water,Watercraft
[2020-08-29] AAF035.jpg, Blue Sky,Outdoor,Palm Tree,Plant,Sky,Tree

"""Print name of all photos in a Photos album and their associated labels"""

import click

import osxphotos

@click.command()
@click.argument("album_name")
def album_labels(album_name):
    """Print name of all photos in a Photos album and their associated labels"""
    photosdb = osxphotos.PhotosDB()
    album = [album for album in photosdb.album_info if album.title == album_name]
    if not album:
        raise click.ClickException(f"Album '{album_name}' not found")

    # could be more than one album with same name so process them all
    for a in album:
        for photo in a.photos:
            print(f"{photo.original_filename}, {','.join(photo.labels)}")

if __name__ == "__main__":
    album_labels()

Finally, I assume by labels you mean what osxphotos refers to as labels which are the automated categories/labels assigned by Photos as it does image classification on each photo. If you mean user assigned keywords, you'd have to replace labels with keywords in the above examples.

Great work, it solved my question exactly! thx very much!
I can get the labels associated with photos in my mac albums now. But, is that a way that  i can get all labels that photo APP support, maybe it stores in someone sqlite table. thx

is that a way that i can get all labels that photo APP support. thx

I do not know of a way to get all the labels supported by Photos.app but you can easily find all the labels associated with photos in your Photos Library by doing this:
Run osxphotos repl
Then at the prompt (>>>) type photosdb.labels and it will print out a list of labels, for example:
>>> photosdb.labels
['Water', 'Underwater', 'Jellyfish', 'Animal', 'Document', 'Table', 'Furniture', 'Container', 'Bottle', 'Interior Room', 'Bar', 'Drinking Glass', 'Drink', 'Liquor', 'Utensil', 'Tableware', 'Blue Sky', 'Sky', 'Plant', 'Tree', 'Palm Tree', 'Outdoor', 'Sunset Sunrise', 'Umbrella', 'Cloudy', 'Beach', 'Water Body', 'Ocean', 'Land', 'Cord', 'Food', 'Pizza', 'Child', 'People', 'Clothing', 'Grass', 'Dock', 'Mast', 'Harbor', 'Watercraft', 'Boat', 'Machine', 'Vehicle', 'Pole', 'Wine', 'Wine Bottle', 'Vase', 'Flower', 'Art', 'Flower Arrangement', 'Bouquet', 'Camera']

To see a count of how many photos are associated with each label, you can do this:
>>> photosdb.labels_as_dict
{'Sky': 7, 'Outdoor': 7, 'Water': 4, 'Plant': 4, 'Cloudy': 4, 'Drink': 3, 'Blue Sky': 3, 'Tree': 3, 'Palm Tree': 3, 'Underwater': 2, 'Jellyfish': 2, 'Animal': 2, 'Table': 2, 'Furniture': 2, 'Container': 2, 'Utensil': 2, 'Sunset Sunrise': 2, 'Land': 2, 'Wine': 2, 'Wine Bottle': 2, 'Document': 1, 'Bottle': 1, 'Interior Room': 1, 'Bar': 1, 'Drinking Glass': 1, 'Liquor': 1, 'Tableware': 1, 'Umbrella': 1, 'Beach': 1, 'Water Body': 1, 'Ocean': 1, 'Cord': 1, 'Food': 1, 'Pizza': 1, 'Child': 1, 'People': 1, 'Clothing': 1, 'Grass': 1, 'Dock': 1, 'Mast': 1, 'Harbor': 1, 'Watercraft': 1, 'Boat': 1, 'Machine': 1, 'Vehicle': 1, 'Pole': 1, 'Vase': 1, 'Flower': 1, 'Art': 1, 'Flower Arrangement': 1, 'Bouquet': 1, 'Camera': 1}

By the way, you can also run osxphotos inspect and it will display lots of information about which ever photo is selected in Photos (and you can change the selection to see the info for the new photo).  In the inspect window, labels are called "Categories".


Push to Docker Hub

Instant of everyone need to build the image, it could be useful if we could just pull the image from Docker Hub or some other Docker Registry (quay? Google Cloud Registry?)

Hi,
I have pushed it to https://hub.docker.com/r/samdotli/rendertron/ but I need to figure out how to properly push a repository instead. Also any idea on how I can get to be an unnamed one?

I'll look into Google Cloud Registry as well.

With 2.0.0, it feels like the project is making backward progress to support users who want to use docker.  Why not publish a docker image that is built by installing puppeteer and rendertron?  It would be simpler for users than cloning the repo and building rendertron natively.
I've also opened a request for puppeteer to publishes their images, https://github.com/GoogleChrome/puppeteer/issues/3072.  When/if that is done, the Dockerfile for rendertron would be simple:
FROM puppeteer:latest

WORKDIR /home/pptruser
ENV WORKDIR /home/pptruser

COPY . .

RUN npm install || \
  ((if [ -f npm-debug.log ]; then \
      cat npm-debug.log; \
    fi) && false)

RUN npm run build

ENTRYPOINT [ "npm" ]
CMD ["run", "start"]

It'll be a little ugly to have puppeteer build logic + rednertron build logic but until puppeteer publishes their images, I think the result is worth it.


Page change indicator

Hello
Is it possible to show indicator when page chagned in webview?

No, it's not possible.

Bad. It is best to escape from this plugin.


Populate BlockTemplate fields using a new state request

Motivation
Whatever is not fixed values(https://github.com/ZcashFoundation/zebra/issues/5452), coinbase transaction(https://github.com/ZcashFoundation/zebra/issues/5453) or mempool transaction(https://github.com/ZcashFoundation/zebra/issues/5454) will be state or Rust API values.
Tasks
Return state values in the getblocktemplate RPC method response:

previousblockhash
height
defaultroots

chainhistoryroot

target (same as bits, but in a different format)
mintime

These values should come from a new state request based on recent best blocks. We want to use a single state request for performance.
Return local node clock value in the getblocktemplate RPC method response:

curtime - using the same standard library time function as the time field consensus rule check

Related Tickets
Depend on https://github.com/ZcashFoundation/zebra/issues/5451
Can depend on https://github.com/ZcashFoundation/zebra/issues/5452 for identification

@oxarbitrage I think the fields we need here are:
New state request based on recent best blocks:

previousblockhash
height
defaultroots

chainhistoryroot

target (same as bits, but in a different format)
mintime

Standard library time function:

curtime

Can I edit the ticket, or did you want to?

Please feel free to edit any of the getblocktemplate tickets. I did some some work already in the first one but none in the rest of them.

Hey team! Please add your planning poker estimate with Zenhub @arya2 @conradoplg @dconnolly @oxarbitrage @teor2345 @upbqdn

PR #5659 populates all of these fields except defaultroots.chainhistoryroot (and the 5 fields that are copies of it).
@mpguerra @oxarbitrage did you want to split that out into a separate ticket?

I think @oxarbitrage is working on them in a separate PR so I think it's ok to just keep it in this ticket.


[Event Request] Codeunit 1002 Job Create-Invoice - CreateSalesInvoice

Could we please have a supplement at publisher OnBeforeGetInvoiceNo in function CreateSalesInvoice  - Codeunit 1002 Job Create-Invoice?

[External] CreateSalesInvoice(VAR JobPlanningLine : Record "Job Planning Line";CrMemo : Boolean)
IF NOT CrMemo THEN BEGIN
  GetSalesInvoiceNo.SetCustomer(JobPlanningLine."Job No.");
  GetSalesInvoiceNo.RUNMODAL;
  IsHandled := FALSE;

// >>>>>>>>
//OnBeforeGetInvoiceNo(JobPlanningLine,Done,NewInvoice,PostingDate,I//nvoiceNo,IsHandled);
//
OnBeforeGetInvoiceNo(VAR JobPlanningLine,Done,NewInvoice,PostingDate,InvoiceNo,IsHandled);
// <<<<<<<<
  IF NOT IsHandled THEN
    GetSalesInvoiceNo.GetInvoiceNo(Done,NewInvoice,PostingDate,InvoiceNo);
END ELSE BEGIN
  GetSalesCrMemoNo.SetCustomer(JobPlanningLine."Job No.");
  GetSalesCrMemoNo.RUNMODAL;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Process for Getting Miniseed From IRIS and Submitting StationXML to IRIS

@kujaku11  had the question about: "How do the miniseeds arrive when a request spans more than one epoch?"  Jared has tested receiving data into MTH5 via miniseed, but his only examples were for continuous data;
@timronan To run some tests on  what happens when you request miniseed for data that has a gap.
Also, does the size of the gap matter? Nan-filling? etc.

The fundamental method to access data_availability and to simultaneously build queries for a run can use this form:
wget "https://service.iris.edu/fdsnws/availability/1/query?format=text&net=BK&sta=PKD&cha=BQ2&starttime=2004-09-25T00:00:00&endtime=2004-09-30T00:00:00&orderby=nslc_time_quality_samplerate&includerestricted=false&merge=samplerate,quality&nodata=404" --output-document rover.txt
Note that the url can be made by:
rover_query_url()
And then we can make
cmd = f'wget "{url}" --output-document rover.txt'
execute_subprocess(cmd)
But we can probably find a python interface that will directly dump the wget output into a dataframe.

We can also look at Obspy, they have tools to get the StationXML and the miniseed files (client.get_waveforms) for this, the user just needs to know network and station, etc.


Separate Window for Color Palette Editor

Is your feature request related to a problem? Please describe.
Editing colors on the palette editor page blocks the view from the scene editor, changes cannot be observed in realtime.
Describe the solution you'd like
Detach the palette editor from the main GBS window for it to be placed freely on same or even different monitors. That way any color changes could be viewed in the affected scene instantly, making color editing a breeze.
Describe alternatives you've considered
There isn't any. Right now one has to trial and error the colors by switching menus back and forth, which is very time-consuming.
Additional context
None

+1
(Sorry to  +1 without anything constructive to add but) it would be fantastic to see your game scene while tweaking the colours. Quite frustrating otherwise.
Also, if it were to display the hex code for the chosen colour, that'd be handy to copy paste it into other palettes.

This was noted during the private beta too, whether a side bar or detached window (although would be nice and resizable, might not stay on top).
For now, the shortcut to edit palette by long pressing a palette in draw mode at least takes you to the right page.

I think it would be best to make the detached window optional. It could be in the View or Window menu to show the color palettes window but otherwise allow the user to use it just like they do now

This was noted during the private beta too, whether a side bar or detached window (although would be nice and resizable, might not stay on top).
For now, the shortcut to edit palette by long pressing a palette in draw mode at least takes you to the right page.

I think it would be best to make the detached window optional. It could be in the View or Window menu to show the color palettes window but otherwise allow the user to use it just like they do now

I would suggest making not only the color palettes removable, but all the different views right away. This would also help to make better use of multiple screens.


[CommonVoice recipe]: Inference from different format yaml

Hi Guys,
Thanks for the great work in Speechbrain, Now I'm trying to training my own model from CommonVoice Fr recipes/train_fr.yaml
Now I got a checkpoint, and I want to Inference using EncoderDecoderASR class
from speechbrain.pretrained import EncoderDecoderASR
asr_model = EncoderDecoderASR.from_hparams(source="speechbrain/asr-crdnn-commonvoice-fr",
savedir="pretrained_models/asr-crdnn-commonvoice-fr")
asr_model.transcribe_file("speechbrain/asr-crdnn-commonvoice-fr/example-fr.wav")

But it seems like that there is no MODULES_NEEDED entities encoder, decoder in  CommonVoice Fr recipes/train_fr.yaml
HPARAMS_NEEDED = ["tokenizer"]

MODULES_NEEDED = [
    "encoder",
    "decoder",
]

How can I declare encoder, decoder modules in train_fr.yaml ? should I need to conjugate some module(like a transformer) in the  train_fr.yaml ?
Thanks :)

I solved this issue based on https://huggingface.co/speechbrain/asr-transformer-aishell yaml file. I built "encoder", "decoder" based on this yaml and now I can infer from my one model. hope to help someone has a same issue with me


I could use more guidance on recommended spacing

I could use more guidance on recommended spacing for at least the following points:

I see there is a gutter size recommendation ( = horizontal spacing). Is there any vertical spacing recommendation?

how much space should I put before / after headings, other content?
are there recommendations for spacing to put between the levels of the typography hierarchy?
at page level?
at section level?

spacing can be done using padding or margin. When to use what? Is there a recommended approach? Do you start with the page size and work from the outside to the inside? Or do you start with the smallest control and build around that?
I find there is a lot of topic overlap between this page and https://docs.microsoft.com/en-us/windows/uwp/design/style/spacing#fluent-standard-sizing

Could you please add guidance for that to the documentation?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0ce8de2d-cfd8-202a-87a8-14d67ef7a328
Version Independent ID: c6ed23c1-f6e0-1433-e90f-7f539e3e3060
Content: Alignment, margin, and padding for layout - UWP applications
Content Source: windows-apps-src/design/layout/alignment-margin-padding.md
Product: uwp
Technology: design
GitHub Login: @jwmsft
Microsoft Alias: jimwalk

Also, on https://docs.microsoft.com/en-us/windows/uwp/design/controls-and-patterns/forms#spacing there is written in the text what size elements should have and what margin they should have.
I would find it much easier to digest all information if there could be (more) visual schemes with recommend sizes & margins in these docs. It is very difficult to keep an overview of spacing recommendations as it is now, and a lot is unclear.
Besides, it seems that there was information in this UWP design guidelines PDF that is not available anymore online in the online documentation.

Please also see this older Reddit thread where people ask for the same:
https://www.reddit.com/r/WPDev/comments/6x0m97/uwp_design_guidelines_with_control_dimensions/
It would be great if you could somehow address this need.

Spacing between controls, similar to internal guidance for the Settings app.  Your Phone is an application with inadequate vertical spacing between elements.

@chigy this is the topic that was discussed during todays focus group on design systems. Could you please share this with your colleagues?
cc @niels9001

Material Design's documentation includes redlines and values for sizes and positions.
WinUI could do with some of this, included in it's controls and layout sections.
For things like app settings, I would like to see some guidelines, matching those used by the Windows Settings app.

Is there any update to give on this?

Thank you for this feedback. I know this will be an unsatisfying response, but the scope of the request here is too large to be tracked via a GitHub issue. I'm going to close this issue and track this request via an internal internal work item.


Upgrade aws-sdk-go to latest version to get SSO credential support

Issue #, if available: https://github.com/aws/aws-xray-daemon/issues/147
Description of changes: See issue
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Can you resolve the conflicts?

Tests ran with no issue. Docker starts.


Egypt Air A320

Hi The Egypt Air A320 livery looks cool but not loading. Is it only with me or with everyone? If it is a general issue if you could kindly fix it 🙏thank you

Thank you, it's fixed now


add RestrictedExpression::new_entity_uid()

Description of changes
Adds a new constructor to go with the other similar ones
Issue #, if available
Fixes #350
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):

[x] A backwards-compatible change requiring a minor version bump to cedar-policy (e.g., addition of a new API).

I confirm that this PR (choose one, and delete the other options):

[x] Updates the "Unreleased" section of the CHANGELOG with a description of my change (required for major/minor version bumps).

I confirm that cedar-spec (choose one, and delete the other options):

[x] Does not require updates because my change does not impact the Cedar Dafny model or DRT infrastructure.

Disclaimer
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Downstream DRT failure is because https://github.com/cedar-policy/cedar-spec/pull/156 is not merged yet. Merging this


Missing .gltf?

First off, thanks for making this! Great to have a toy example. Second, I am just getting started in creating for MSFS, so sorry if I've missed anything basic in what I write here. I also recognize that this project is a couple years old and might be long forgotten at this point.
So - FlyingBrick.gltf appears to be missing, even though it's referenced by the model.
But you do include the .blend file so I thought I'd just cook up the gltf myself. I did that using the Blender MSFS extension in Blender 3.6, which has been successful for a different custom model. I merged the two resulting xml files together - yours and the generated one - to make this:
<?xml version="1.0" encoding="utf-8" ?> <!-- -*- nxml-child-indent: 4; tab-width: 4; indent-tabs-mode: nil -*- -->

<ModelInfo>
    <LODS>
        <!-- Highest LOD -->
        <!-- Minimum display size in % (should be bounding sphere vertical screen size, sphere will often be slightly larger
             than you expect) -->
        <!-- Default minSize is 0 -->
        <LOD minSize="10" ModelFile="FlyingBrick.gltf"/>
    </LODS>
    <Behaviors>
        <Include ModelBehaviorFile="Asobo\Exterior.xml"/>
		<Include ModelBehaviorFile="Asobo\Common.xml"/>
		<Component ID="HANDLING_Yokes">
			<UseTemplate Name="ASOBO_HANDLING_Yoke_Template">
				<NODE_ID>HANDLING_Yoke</NODE_ID>
			</UseTemplate>
        </Component>
        <Component ID="GEARS">
            <UseTemplate Name="ASOBO_GEAR_Base_Template">
			    <ANIM_NAME>Front_left_leg</ANIM_NAME>
			    <ID>0</ID>
            </UseTemplate>
            <UseTemplate Name="ASOBO_GEAR_Base_Template">
			    <ANIM_NAME>Front_right_leg</ANIM_NAME>
			    <ID>1</ID>
            </UseTemplate>
            <UseTemplate Name="ASOBO_GEAR_Base_Template">
			    <ANIM_NAME>Rear_left_leg</ANIM_NAME>
			    <ID>2</ID>
            </UseTemplate>
            <UseTemplate Name="ASOBO_GEAR_Base_Template">
			    <ANIM_NAME>Rear_right_leg</ANIM_NAME>
			    <ID>3</ID>
            </UseTemplate>
        </Component>
        <Component ID="HACKS">
            <Animation Guid="" Name="BONE1" Length="200" Type="Sim" TypeParam="AutoPlay">
                <Parameter>
                    <Code>
                        (A:ELEVATOR POSITION, position) sign
                        (A:VELOCITY BODY Z, knots) *
                        100 +
                    </Code>
                </Parameter>
            </Animation>
        </Component>
    </Behaviors>
</ModelInfo>

And this builds, which is great. However:

Half the model is clipped away
On the runway, it spawns in a "beached" location and needs the "Back to Fly" command right away (from which it falls ... like a brick 😛  )
It does not appear to fly or be controllable in any way. When I go full-throttle I can see the indicator move on the engine dial, but the brick just keeps falling

Here's what that clip looks like:

There's a very good chance that I have gotten something wrong in the package setup or gltf export here, but if nothing else this issue writeup might help the next person who runs into this.
To go from .blend -> .gltf, I roughly followed this guide, which worked out in the case of the other custom aircraft I made and flew: https://forums.flightsimulator.com/t/how-to-creating-a-simple-aircraft-using-blender-and-the-sdk/594482

Oh, I only just realized that the models/.gitignore includes the .gltf. Is that intended?

You get the glTF file by exporting from Blender. It is not "source code". A software project on GitHub would not include object files either.


DVC 2.9.3 has a bug in the dvc daemon patch

Describe the bug
There's a bug in the dvc daemon patch updated in PR #155094, here the relevant lines
+    cmd = [ "@dvc@" , "daemon", "-q"] + args
+    env = None
     env[DVC_DAEMON] = "1"

this causes env to be Noned and being indexed the line after that, which raises an error when running dvc init or other commands
Traceback (most recent call last):
  File "/nix/store/c4m423nh1nqqrx793qrlxxm1m8vzwkli-dvc-2.9.3/bin/.dvc-wrapped", line 9, in <module>
    sys.exit(main())
  File "/nix/store/c4m423nh1nqqrx793qrlxxm1m8vzwkli-dvc-2.9.3/lib/python3.9/site-packages/dvc/main.py", line 98, in main
    analytics.collect_and_send_report(args, ret)
  File "/nix/store/c4m423nh1nqqrx793qrlxxm1m8vzwkli-dvc-2.9.3/lib/python3.9/site-packages/dvc/analytics.py", line 37, in collect_and_send_report
    daemon(["analytics", fobj.name])
  File "/nix/store/c4m423nh1nqqrx793qrlxxm1m8vzwkli-dvc-2.9.3/lib/python3.9/site-packages/dvc/daemon.py", line 108, in daemon
    env[DVC_DAEMON] = "1"
TypeError: 'NoneType' object does not support item assignment

Steps To Reproduce

Get a dev shell with dvc 2.9.3, I used nix shell nixpkgs/nixos-unstable#dvc
git init a repository, then dvc init it as well

Expected behavior
DVC initializes the repository without errors.
Notify maintainers
@fabaff @CMCDragonkai
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
 - system: `"x86_64-linux"`
 - host os: `Linux 5.15.12-100.fc34.x86_64, Fedora, 34 (Server Edition)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.6.0`
 - channels(root): `"nixpkgs"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`

Currently dvc fails to build on master / unstable due to asyncssh being too modern for scmrepo - here's a flake I made resolving the issue + including this patch if anyone wants to carry it forward: https://gist.github.com/TheAncientGoat/0cc387f48b9a43906610174dfc9e7a1f

https://github.com/iterative/scmrepo has to be updated to support the latest version. Might be as easy as just removing the version restriction and re-building it; could help to create an issue on their side if that doesn't work

There is a bit of a chain to get it working again. The next staging merge will bring us a step closer as gpgme will get support for Python 3.10 and will allow us to update scmrepo.
Unfortunately, it can't be fixed in staging at the moment because gfortran has issues.


[UI] Text invisible in dark mode

Current Behavior
In dark mode, the text "operator" is invisible as the background color, as well as text color, is white.
Desired Behavior
In dark mode, the text color should be black so as to be visible.
Screenshots/Logs
Environment

Browser: Chrome Safari Firefox
Host OS: Mac Linux Windows
Meshery Server Version: stable-v
Meshery Client Version: stable-v
Platform: Docker Kubernetes

Contributor Guides and Handbook

🎨 Wireframes and designs for Meshery UI in Figma
🖥 Contributing to Meshery UI
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

If this issue is acceptable, I would like to work on this.


fixes #88: emit events on month/year/decade changes

Emit these events: changedMonth, changedYear and changedDecade.  Along with "opened" this should cover all the cases in which the selected month/year/decade changes.
@charliekassel: feel free to change the name of the events or implement it in a different way, but I agree that it would be useful to be able to react to navigation.

Coverage increased (+0.007%) to 99.655% when pulling a0a8ac31d72bdba1b10ada7335b40f409c74a297 on alberanid:master into 1f6f2ca0fac17e9bed00785beea2d794577733b1 on charliekassel:master.

Looks good! Thanks for your contribution

Events are not emitted when the user manually changes the year for example.


Mercury fixes

Some small issues found while working with the code on T10
@MerlinSmiles @QCoDeS/core

@jenshnielsen are you sure that your changes of [self.axes.index(ax)] to [0] actually work?
the _ATOB makes setpoint and field a len(ax) array, no?

while youre at it, maybe we want to change this function:
    def _carttosphere(self, field):
        field = np.array(field)
        r = np.sqrt(np.sum(field**2))
        if r == 0:
            theta = 0
            phi = 0
        else:
            theta = np.arccos(field[2] / r)
            phi = np.arctan2(field[1],  field[0])
            if phi<0:
                phi = phi+np.pi*2
        return [r, theta, phi]

basically adding:
            if phi<0:
                phi = phi+np.pi*2

to make sure phi is always positive?

and maybe we want to define if we run the magnet in current or field mode, and then remove all the ...C guys

@MerlinSmiles you are probably right but unfortunately it doesn't take that code path for other parameters such as z field

now I see the issue, yes its only going there for the 'current' version of sending the field.
A note on the side, using the current parameters instead of tesla parameters gives you one decimal place higher in resolution on the magnet.

Agreed with @MerlinSmiles in Slack


500 on /boot after restarting KERIA for existing agent. 400 is expected.

Problem - Actual Behavior
An HTTP 500 is being returned from the /boot endpoint for an agent that already exists. The problem is that in the self.agency.agents call here is empty after server startup. It seems like this list should be populated with all of the known agents. If that is not yet the case then this issue can be marked as a feature request rather than a bug.
Expected Behavior
Return a 400 Bad Request status when I try to re-create the same identifier.
Suggestion
Ideally the return status would be a 409 since 409 Conflict makes more sense than 400 Bad Request due to the fact that a 400 typically means the request is improperly formatted and 409 is a nice way to distinguish improperly formatted requests from identifier conflicts.
Reproduction steps

Start KERIA.
Create an agent using SignifyTS.
Shutdown KERIA.
Start up KERIA.
Try to make the same agent again with SignifyTS.
Observe the 500 error that gets returned.

https://github.com/WebOfTrust/keria/pull/181 addresses this.


Enhance symbols fallback for windows

Currently karma-mocha-reporter uses overdue copy of sindresorhus/log-symbols . Compare karma-mocha-reporter/symbols.js with log-symbols/index.js.
It makes sense to update symbols.js or use log-symbols npm package.

Good point. There was a reason why we add the symbols in code instead of using the log-symbols package directly. Will check this.

Published as v2.2.4


Fixed error in spice2.yaml file.

Added in test to check dataset download.  The tests will be skipped ( only will run if --run_data_download is passed to the CLI).  This test will take a lot of time so I'm sure this is not something we would want to do with any frequency. It might be worth creating separate tests (instead of parameterize) to make it easier to just specifically test a given dataset.
It might also be better to make this NOT a pytest test and just a separate piece of code that gives more options to check/test very specific datasets and versions and give more descriptive outputs.  Having something like that in the dataset module, where people can more easily query available datasets and versions.
Status

[ ] Ready to go

That PR has high priority; the CI tests for all other PRs are failing since some of the hashes for the datasets have changed in the remote location. @chrisiacovella , is this PR ready for review?


new(libsinsp/tests): add basic dup/dup2/dup3 tests

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap-engine-udig

/area libscap

/area libpman

/area libsinsp
/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:
This PR adds some basic testing to libsinsp handling of dup/dup2/dup3 to guard against regressions such as the one fixed here: https://github.com/falcosecurity/libs/pull/508
In addition, it adds add_event_sinsp_next as a shorthand to run add_event + next_event (@FedeDP / @Andreagit97 will be happy).
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: LucaGuerra
Once this PR has been reviewed and has the lgtm label, please assign andreagit97 for approval by writing /assign @andreagit97 in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Updated the PR according to the comment above.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 9fb0887fde88f9688f7ab2d2307b83171c7dc547

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP,LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Stop bumping go directive unless necessitated by other dependencies

This repo by itself should not be enforcing minimum on other repositories importing it. Stop spreading "minimum virus"
toolchain version used will be defined outside of go.mod ideally, such as by installing a newer compatible go toolchain to ci/cd/development env.
Failing that, toolchain directive should be used instead of go directive for bumping versions to not cascade minimum versions to importing dependencies.

toolchain directive, in contrast to the go directive, applies only to the current module (the one defined by the go.mod file). It suggests the toolchain to be used when in that very module, and doesn't propagate to other modules.

High profile repos that have removed/reduced minimum go patch version per user requests

https://github.com/grpc/grpc-go/pull/7831 motivation

Being proactive to prevent following from reoccuring

https://github.com/kopia/kopia/issues/4292
https://github.com/vmware-tanzu/velero/issues/8397
https://github.com/kubevirt/kubevirt-velero-plugin/pull/292#issuecomment-2482634796
https://github.com/chainguard-dev/sdk/issues/147

@kaovilai ➜ /workspaces/apko (main) $ go mod graph | grep<EMAIL_ADDRESS>chainguard.dev/apko<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
Nothing in this repo necessitated 1.23.1. In fact, it is shown that the lowest required by other deps is 1.23.1 as required by<EMAIL_ADDRESS>


www.reddit.com  REJECT  quad9-dnscrypt ?

hi team Quad9DNS.
pc.. win81 32b .. dnscrypt-proxy.exe
it's ok  .. ?
[2024-10-22 11:41:21]	<IP_ADDRESS>	www.reddit.com	A	REJECT	41ms	quad9-dnscrypt-ip4-filter-alt
www.reddit.com  REJECT ?

Quad9 is not filtering reddit (see https://www.quad9.net/result/?url=www.reddit.com ), so it is uncertain where that reject message is coming from.  See a similar ticket where the name was in a local file:
https://github.com/DNSCrypt/dnscrypt-proxy/discussions/2654

Thanks for the quick response and clarification.

I blocked ".fastly.net" and consequently "www.reddit.com" did not work.. it was my mistake, sorry for the inconvenience.
c,md:  dnscrypt-proxy -resolve "www.reddit.com"
`dnscrypt-proxy -resolve "www.reddit.com"
Resolving [www.reddit.com] using <IP_ADDRESS> port 53
Resolver      : <IP_ADDRESS>
Canonical name: reddit.map.fastly.net.
IPv4 addresses: -
IPv6 addresses: -
Name servers  : no name servers found
DNSSEC signed : no
Mail servers  : no mail servers found
HTTPS alias   : -
HTTPS info    : -
Host info     : This query has been locally blocked by dnscrypt-proxy
TXT records   : -`


EasyRTC npm install failed PhantonJS node install.js not found

npm ERR! Linux 4.4.0-101-generic
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "install"
npm ERR! node v4.2.6
npm ERR! npm  v3.5.2
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn

npm ERR<EMAIL_ADDRESS>install: `node install.js`
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node install.js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the phantomjs-prebuilt package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node install.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs phantomjs-prebuilt
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls phantomjs-prebuilt
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /root/easyrtc/npm-debug.log

Using Digital Ocean Ubuntu 16.06
apt install nodejs
apt install npm
git clone easyrtc.git
npm install
On my MacOS everything is fine...

I did try with every node version from 6 to 9 and none has worked!?

I did deploy a CentOS 7.4 on Digital Ocean and it worked as follow
yum install bzip2
git clone easyrtc.git
npm install
Some bug must be with Ubuntu 16.06

work on node 8.9.0 and npm 5.5.1 for me.

What worked for me was to:

uninstall npm
install nvm
run: nvm install 8.9.0

Now I have node version 8.9.0 and npm version 5.5.1  and finally I could to install<EMAIL_ADDRESS>Good luck!


Update for log4j update release

Need to update the documentation for release that fixes the Log4Shell vulnerability.

I previously updated the software and made a release.  Close this issue.


Add secure random to LazySingletons

A new class, LazySingletons was added in #3531 which hosts singleton suppliers. This PR adds a supplier to that class for a SecureRandom object and replaces the creation of new SecureRandom objects with that supplier.

The fact that it's a SecureRandom vs. just a Random is expressed in the type, either way, so I don't think putting the SECURE in the name (or even just S) helps make the calling code any more readable over RNG

I agree. I think that RANDOM and RNG are my top choices for renaming but I'm leaning towards RANDOM just so it is a bit clearer what the variables type is. Also it seems like when we created SecureRandom objects throughout the code, we often use "random" as the variable name so it would be more consistent with what is already present.

The fact that it's a SecureRandom vs. just a Random is expressed in the type, either way, so I don't think putting the SECURE in the name (or even just S) helps make the calling code any more readable over RNG

I agree. I think that RANDOM and RNG are my top choices for renaming but I'm leaning towards RANDOM just so it is a bit clearer what the variables type is. Also it seems like when we created SecureRandom objects throughout the code, we often use "random" as the variable name so it would be more consistent with what is already present.

I'm fine with RANDOM, but if you wanted to, you could also go with SRANDOM, just to make it super clear. While the local uses may have not cared what type of random it was (they were probably just using SecureRandom to avoid a spotbugs warning), we have to also consider how the LazySingletons class presents itself, even when the callers don't necessarily care.


facetCut tests

test: implement MockFacet skeleton and initial facetCut tests
Resolves: #838

@rndquu @molecula451 I covered initial edge cases for the diamond facet cut. I am still working to cover add / replace / remove diamond facet cut operations, therefore switched this pull request to a draft. I will let you know when it is ready for the review.

@rndquu , @molecula451 pull request ready for review, this one bumps test coverage to 76.6%
Development branch coverage: 70.9
PR branch coverage: 76.6

good work, can you mock a library instead? and import the struct, storage selectors etc from there? also the interface? @gitcoindev

good work, it's nice the coverage increased but can you mock a library instead? and import the struct, storage selectors etc from there? also the interface? Basically the whole diamond pattern are library importing would be much better architected (the test) @gitcoindev

hi @molecula451 thank you. Did I understand correct that you mean to create test/diamond/facets/DiamondCutFacet.t.sol and move test implementation with all imports there ?

@gitcoindev re-checking this notice the lack commenting, at least a header comment explaining the intention, for future reference when reading the code


Quantized inception-resnet-v2 doesn't predict the images correctly

I did quantization on inception-resnet-v2 model using https://www.tensorflow.org/performance/quantization#how_can_you_quantize_your_models. Size of freezed graph(input for quantization) is 224,6 MB and quantized graph is 58,6 MB. I ran some tests for quantized graph and the predicted output is totally wrong. I ran accuracy test for certain dataset wherein, for freezed graph the accuracy is 97.4% whereas for quantized graph it is 0%.
Is there a different way to quantize the model for inception-resnet versions? or, for inception-resnet model, quantization is not support at all?

I met with a similar problem like this. Try using graph_transform instead of quantize_graph
https://github.com/tensorflow/tensorflow/tree/master/tensorflow/tools/graph_transforms
Be sure to use quantize_weights and quantize_nodes successively in the command for graph transform.

@kwotsin : With this I understand I need to use command like this? Eight-bit Calculations - https://github.com/tensorflow/tensorflow/tree/master/tensorflow/tools/graph_transforms#eight-bit-calculations
Isn't it?

This question is better asked on  StackOverflow since it is not a  bug or feature request. There is also a larger community that reads questions there. Thanks!


Can you write new tiddlys from the webpage?

Hello!
I was wondering how this works. Does this code allow you to write a new entry and save it so github from the website? Or what are the steps you take to add entries? Thanks

Hi @juilie
This is a workflow to create Tiddlywiki from Node.JS! So, you can edit a single tiddler and you will see the updated index.html is there.
New way to do this is GitHub Actions.


Allow/Deny auto restart when players are online

Importance: 0/10
2
Problem:
I don't really have a problem with it, others may have it.
Solution:
Add a function in the restarter.yml to allow or deny an automatic restart when players are on the server for that moment.

Yeah I remember that you already created that issue: #137
Closing bc of duplicate.

Ok, but can you also respond to it???

@Minionguyjpro I stopped adding new features to autoplug a while ago.
You can either add it yourself, or hire a developer, or hire me. Id do it for 50€


Dynamically change strand of composite plot to match weblogo

When the '-' strand is selected, reverse sort the x-axis and change label and colors between R1 forward and R2 reverse

e.g. color and legend for the first array will change from (blue, R1 Forward) to (red, R1 Reverse).


Add relevant tag to domain document

As of 3.0, the tag is determined for each event as they come in.  The tag should actually be associated with the domain beforehand as the lookup for the relevant tags are done for every event and this is not efficient.  Will require rewrite of the domain doc class and logic to add the relevant tag at domain doc save time.

Each tag has now been written to the threat index for each event and is searchable and able to create visualizations based on the tag.


'Last command' proxy object doesn't work

Run a simple command such as Safar → Open
Search for the 'last command' proxy and right arrow into it.

Observe the "[Action missing: (null]" message. The icon seems to be right, which is nice!

I’m going to guess this is related to #555. Assigning to me.


Feature request: Results per resolution

It would be nice if there was an option to limit the number of results per resolution than all results. This is because some resolutions have many streams and if you go with limiting to 10 links you wouldn't get all the resolutions but ones that fit in those 10 places. Example is torrentio which has this option. I hope the message isn't confusing. This feature would be soon nice to have : )

Agreed! Just found this due to Torrentio being down and after setting it up, this was the first feature I thought of.

done https://github.com/g0ldyy/comet/commit/b2ecc867c0e5b05116e4079a495509f013f8766d


Use target table in GUI

Update the GUI to use the target table where possible.
The goal is to shrink the reliance on the chroma_core_managedtarget
table so we can start removing it's fields.

Signed-off-by: Joe Grund<EMAIL_ADDRESS>

This change is

Landed as 39b28591ccedcb97529ccd23e484b5b728ea540b


fix: race condition on repaint with alt screen

I didn't realise at the time, but the tea.Program and the renderer share
the mutex. This make the code difficult to reason about - it turns out
the program sometimes acquires the lock and then calls the
setAltScreen method of the renderer which in turns calls repaint.
That causes a deadlock as repaint is trying to acquire the lock too.

Yeah, sharing that mutex feels awkward. I think we'll clean that up.


aktualizr: Get garage-sign from the new AWS bucket.

Depends on https://github.com/advancedtelematic/aktualizr/pull/1619.

I'm confused how this passed... it should've broken on fetching garage-sign, since the new link is empty now.

Probably because of caching. The file and hash haven't changed.

Probably because of caching. The file and hash haven't changed.

Oh yeah, of course!

To confirm: failed as expected when testing locally without the benefit of that file being cached.

Now depends on https://github.com/advancedtelematic/aktualizr/pull/1622.


Adapts to support Scala 3

@mdedetrich  didn't know how to add a commit to your branch so I'm creating a PR for it

@nvollmar You forgot to run scalafmt, can you do so and rebase and merge

Ah just pushed 😆

@nvollmar Scalafmt still failed, have to run scalafmtSbt (specifically project/Common.scala)

@nvollmar Same tests from my version are still failing

[error] Error during tests:
[error] 	org.apache.pekko.management.cluster.bootstrap.SelfAwareJoinDeciderIPv6Spec
[error] 	org.apache.pekko.management.cluster.bootstrap.SelfAwareJoinDeciderSpec

Maybe you forgot to bring in your changes when rebasing?

I'll look into it. You could cherry-pick the changes you need and merge to master if like to get things forward.

I think you will be able to figure out quicker then me what the relevant changes are, if it takes too long Ill look into cherry picking. Just ping me when you want to rerun the tests.

Now it should be working

@mdedetrich all good now :) Adding the type annotations for the ports fixed the issue, though I don't yet understand why it is an issue on Scala 3...

I understand why, Scala 3's type inference doesn't work the same way and I it was inferring it to Object/Any instead of an Int which is likely what caused typesafe config to fail (since if you ask for an int it expects an int).


closes #203 adtte clean ups in line with admiral

Please add "Closes #" to the title of the pull request. Then the
issue is closed automatically once it is merged to main.
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

[x] Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
[x] Updated relevant unit tests or have written new unit tests - See Unit Test Guide
[x] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
[x] Update to all relevant roxygen headers and examples
[x] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
[x] Address any updates needed for vignettes and/or templates
[x] Update NEWS.md
[x] Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
[x] Address or fix all lintr warnings and errors - lintr::lint_package()
[x] Run R CMD check locally and address all errors and warnings - devtools::check()
[x] Link the issue so that it closes after successful merging.
[x] Address all merge conflicts and resolve appropriately
[x] Pat yourself on the back for a job well done!  Much love to your accomplishment!

The following line requests to update the man pages by the "Man Pages" workflow.
/roxygenize

@bundfussr was going to wait til the workflows run but they'll fail anyway until https://github.com/pharmaverse/admiralonco/pull/194 is merged, so feel free to review this anytime.

@bundfussr i noticed the spell check workflow failed. i remember hearing some updates here to the wordlists, but dont remember the exact details. want me to update the wordlist in this PR or is it already being taken care of elsewhere?

@bundfussr i noticed the spell check workflow failed. i remember hearing some updates here to the wordlists, but dont remember the exact details. want me to update the wordlist in this PR or is it already being taken care of elsewhere?

@rossfarrugia , I did some fixes in https://github.com/pharmaverse/admiralonco/pull/194/files#diff-735340626a484475fb3abdf013331613f4b7fbf657a918c4f35d6a7bedc7766b. This should solve the issue. So no need to do anything in this PR (unless I missed something).

thanks Stefan - looks good to me!


Added bevy_ecs support to CameraRig

In order for bevy to use the CameraRig as a component, Sync + Send (thread-safe) is currently required. This addition should not inhibit its usage in other engines.

Looks good, thank you!


improve messaging  for list upload feature if genes are not found:

Unknown identifiers: SPBC32F12.17  Only extant systematic identifiers can be supplied. Names may not be recognised due to genes merges (use the simple search to check this), or deprecation (check https://www.pombase.org/status/new-and-removed-genes)

Update https://www.pombase.org/status/new-and-removed-genes
i) SPBC36.13 was on the opposite strand to SPNCRNA.1391
ii) SPCC794.16   low complexity homopolymeric region on the opposite strand to SPNCRNA.6762
iii) SPBC32F12.17  was on the opposite strand to SPNCRNA.1550
iv) remove SPCC1672.14 - it looks OK

It this what you are thinking of?:

yes, it could all be part of the red text? then it can't be ignored.
Maybe change the text to
Only the current unique systematic identifier for a gene is recognised by the list upload. Systematic IDs may be changed to synonyms if features are merged.  Locate the current ID via the simple search to update your input list if required. Others  identifiers could be removed from the gene set entirely (check the new and removed gene list for details).
to be completely explicit

Hi Val.
I tried red first but thought it was a bit hard to read.  What do you think?:

good point. Also the comment I wrote only applies to a systematic ID list.
More edits
Only the current unique systematic identifier OR the primary symbol for a gene is recognised by the list upload. Systematic IDs may be changed to synonyms if features are merged. Gene names may be relegated to synonyms if name ambiguities exist. Locate the current ID or gene symbol via the simple search and update your input list if required. Occasionally systematic identifiers are removed from the gene set if they are not considered to be coding (check the new and removed gene list for details).

I've changed the text on my desktop.  It's here if you'd like to have a look:
https://desktop.kmr.nz/query/start_from/gene_list

another set of edits (sorry)
Only the current unique systematic identifier OR the primary symbol for a gene is recognised by the list upload.
Troubleshooting: Occasionally systematic IDs may be changed to synonyms when features are merged. Gene names may be relegated to synonyms if name ambiguities exist. To locate the current ID or gene symbol use the "simple search" in the header. Occasionally  identifiers are removed from the gene set if they are no longer considered to be coding (check the new and removed gene list)

I've lost track: should we make the text red?

I don't know. Maybe it is a bit jarring. we can do it in black I guess.

We could also have a slightly red colour if that's better.  Or just leave it black while we think about it.

OK!

That's done for tonight's update.  It's on the dev site already: http://dev.pombase.kmr.nz/query/start_from/gene_list

This change is deployed now I'm going to close this issue.  Please reopen if it needs tweaks.


[FEATURE] image config display enhancement

Is your feature request related to a problem? Please describe.

create a image by download from url
click config show:

edit config show:

Describe the solution you'd like

show url in image config if the image source type is download
Describe alternatives you've considered

Additional context

Verified fixed on master-714ee3fb-head (23/01/09). Close this issue.
Result

Can display URL in the image config page when created from download url.

Can display file name in the image config page name when uploaded from file.

Test Information

Test Environment: 1 node Harvester on local kvm machine
Harvester version: master-714ee3fb-head

Verify Steps

Download an image from URL
After finish, open the edit page
Click the config tab
Check the content
Upload an image from file
Repeat step 2 - 4


TimeoutPoller leaks memory when query frequency is high

Driver version
com.microsoft.sqlserver:mssql-jdbc:10.2.0.jre17
SQL Server version
Microsoft SQL Server 2019 (RTM-CU9) (KB5000642) - 15.0.4102.2 (X64)
Jan 25 2021 20:16:12
Copyright (C) 2019 Microsoft Corporation
Developer Edition (64-bit) on Windows Server 2019 Datacenter 10.0  (Build 17763: ) (Hypervisor)
Client Operating System
Ubuntu 20.04.4 LTS
JAVA/JVM version
openjdk version "17.0.2" 2022-01-18
OpenJDK Runtime Environment (build 17.0.2+8-86)
OpenJDK 64-Bit Server VM (build 17.0.2+8-86, mixed mode, sharing)
Table schema
Not applicable
Problem description
Any "TimeoutCommands" entered into the "TimeoutPoller" is retained in the poller until the entire Timeout period has elapsed. The command is not removed when it's completed or closed. In our application the default timeout period is (or was) 1800 seconds, and the ArrayList retaining these commands grew very large when the SQL query volume was high. On our culprit server, the memory usage peaked at 17 Gb when the VM ran out of memory.
I do realize that the timeout can be shortened dramatically on my side. But I still don't think it's a good idea to retain commands to a fixed timeout period, as this means I need to "tune" this in order to get an acceptable middle line between working properly; a.e. long running queries are not canceled, while I don't run out of memory due to completed queries (as most of them complete quickly). They should be removed when they are complete.
Expected behavior
The poller should check if the command is complete, and remove it from the poller if so. Suggested patch to the code (not testet, nor verified if it is thread-safe and race condition free):
diff --git a/src/main/java/com/microsoft/sqlserver/jdbc/TimeoutPoller.java b/src/main/java/com/microsoft/sqlserver/jdbc/TimeoutPoller.java
index 6c53d4d7..ab69c836 100644
--- a/src/main/java/com/microsoft/sqlserver/jdbc/TimeoutPoller.java
+++ b/src/main/java/com/microsoft/sqlserver/jdbc/TimeoutPoller.java
@@ -61,7 +61,10 @@ final class TimeoutPoller implements Runnable {
                     while (timeoutCommandIterator.hasNext()) {
                         TimeoutCommand<TDSCommand> timeoutCommand = timeoutCommandIterator.next();
                         try {
-                            if (timeoutCommand.canTimeout()) {
+                            if (timeoutCommand.getCommand().getRequestComplete()) {
+                                timeoutCommandIterator.remove();
+                            }
+                            else if (timeoutCommand.canTimeout()) {
                                 try {
                                     timeoutCommand.interrupt();
                                 } finally {

Actual behavior
The server VM runs out of memory when there are a lot of queries within a short(-ish) time period.
Error message/stack trace
We get OutOfMemoryExceptions... Stack traces for those are not related to the driver... However, here is a screenshot from my profiler:

Any other details that can be helpful
No, I think the cause is pretty clear...
JDBC trace logs
Not really applicable here.

Hi @johnny-egeland,
Thank you for reaching out, we will be taking a look shortly.

@johnny-egeland
The suggested change in logic sounds reasonable. Implementation would still need testing. Will try to test your PR soon.

@v-zhangw The suggested change was the simplest way I could come up with, and it seems to have some side effects on the Windows and Mac tests? Looking briefly at it, I can't really tell why, as I can't exactly think of any reasons why something would have a dependency on a completed command being present in the TimeoutPoller specifically. I mean, commands only get added there when a queryTimeout is used, and it is not by default. I run Ubnutu myself, so I'm not sure I can reproduce the test problems myself. In any case, I don't have time to look any closer at it for the time being. But I will take a look as soon as I can unless you get around to it first.

@v-zhangw The Pull-Request suddenly seems OK now. Not sure why it has changed. Let me know if I need to make any changes, or if you have any suggestions for a better approach for fixing the issue.

I created another pull request using a slightly different approach to fix this:
https://github.com/microsoft/mssql-jdbc/pull/1789
This handles removal of the command from the poller on command completion. This means it does not need to wait until the next timeout poller tick to free up memory. However, the downside (as an ArrayList is used to retain the commands), is another list scan to find the entry to remove. So this will perform slightly worse CPU wise, while being somewhat better memory wise.

this is obsoleted by PR#1794


Internal Server Error on the form section of the demo StoryBook

When I navigate to https://salad-storybook.fly.dev/salad_ui_component/form, I get an Internal Server Error. Other pages seem to work fine.
I cloned the main repo and the storybook repo to try to take a look, but I think there are some steps missing in the instructions. I get a number of errors when I try to start it.
The library is looking great!

Thank you, maybe some recent change cause this issue.

this issue has been fix, thanks


Components API doesn't behave as documented

The documentation for the components API endpoint doesn't match the current code.
Here's the sample from the doc:
{
    "data":{
        "id":1,
        "name":"API",
        "description":"This is the Cachet API.",
        "status_id":1,
        "status":"Operational",
        "incident_count":0,
        "created_at":1425630835,
        "updated_at":1425719658
    }
}

And what you're actually getting with the current master:
{
    "data":
    {
        "id": "2",
        "name": "API",
        "description": "This is the Cachet API.",
        "link": "link",
        "status": "1",
        "order": "2",
        "group_id": "0",
        "created_at": "2015-07-22 16:47:20",
        "updated_at": "2015-07-28 17:46:15",
        "deleted_at": null
    }
}

status is a numeric ID and there's no textual representation of the status. It would be really useful to have a human readable message, for example to announce a partial outage on a site.

The documentation is out of date here. I'll update it as soon as I can. Sorry for this.

Thanks.
Are we supposed to parse the list of incidents to find the ones for a component instead of getting the status?

Are we supposed to parse the list of incidents to find the ones for a component instead of getting the status?

Sorry, do you mean that you want to find incidents for a certain status?

I would like to get the status (human readable) for a component from the API. As far as I understand I can only get that from the incidents API, not the components API (you only get a numeric status ID)

Docs are being updated.

Docs are done :) We've now added status_name.


Better designs for the streamlit dashboard

Improve the designs for the streamlit dashboard.

Best package improve up to date in future it help for ML-AI engineer student as well as professional profile


Redux Form Examples 404: Not Found

404: Not Found

I found at least one that works.
https://redux-form.com/8.2.0/examples/

The link to version 8.3.8  (the latest version as of this writing) examples is broken as well. Here:  https://redux-form.com/8.3.8/examples/


Hash value vanishes

When rehashing a mod version that is not first in the list, the hash value fades out, but does not fade back in.
I am using Google Chrome 45.0.2454.101 m
My server is behind CloudFlare, if that helps at all.

i have the same problem.
but i get a error "Error: Missing Post Data"
and all my mods do have the same hash.
i had a look inside the code. and it is trying to call /mod/rehash/ via ajax. but there is no view for this url.
i did enter the hash when i created the modversion.

@Andreas-Halemba Your issue is fixed in dev and will be push released soon. CloudFlare redirecting without the POST data fucks things up
@skwerlman What message do you get when you rehash?

"MD5 hashing complete."
Just realized I forgot to mention this, but refreshing the page shows the hash again.

Screenshots of the issue:

@skwerlman Sorry for the delay! Can I get more info about the individual rehash request? I need info/screenshots from Chrome Dev Tools, specifically the Network tab, with the individual rehash request selected. I can details steps to do so if needed. Thanks!

Looking at the response, it looks like I'm getting the hash for the first mod listed rather than for the mod I'm rehashing.
I'll test again with developer mode enabled on cloudflare to see if that's the issue.

interesting, can you dump an output of the html code of that page then?

https://github.com/skwerlman/solder-page-dump

any progress on this? anything else i can provide to help out?

@skwerlman Apologies for the delays. IRL work has affected my workflow. I will be revisiting this.

Looking at the response, it looks like I'm getting the hash for the first mod listed rather than for the mod I'm rehashing.

Same problem as https://github.com/TechnicPack/TechnicSolder/issues/545, closing this one as duplicate.


After enabling real time popup, routing start/stop icons are not clickable

... and if then clicked yellow "route" button, start/stop isons disappear (in left top corner of the window)

This should no longer be a problem now that we are not using transitive.js anymore.

It may become a problem again once we go back to Nominatim. Suggestion would be to implement realtime into transitive.js, but that sounds insane...

Making progress with transitive.js...


run test on Python 2.6 also

Coverage remained the same at 92.888% when pulling 551e2046b3ad82473f031b0137f4f2acf8a412dd on python_2.5_2.6 into 646b5f4192a7d0296acc6f737017abc1d70f0df5 on master.

Coverage decreased (-0.4%) to 92.505% when pulling ee1f125e70f0a8ad507cb602012226e3fdefcdcd on python_2.5_2.6 into 646b5f4192a7d0296acc6f737017abc1d70f0df5 on master.

Coverage decreased (-0.8%) to 92.128% when pulling fd1327b17bca1befc5f040531acc92b5287fda2c on python_2.5_2.6 into 646b5f4192a7d0296acc6f737017abc1d70f0df5 on master.


when marking a word that is inside a textarea, the word gets marked but disapears

when trying to mark a word that is inside a textarea, the word does get wrapped by the mark tags,
but it doesn't appear on screen after the marking.
Is there a possible fix for this?
thanks in advance

Duplicate of https://github.com/julmot/mark.js/issues/94


add required indicator

This PR fixes #16621

add required indicator for server and user name
previously for integrated auth mode, we will show user name/password as disabled, I am changing the code to hide the fields to be consistent with the behavior of other fields.
code refactoring

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

7 of 26 (26.92%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 41.43%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/base/browser/ui/inputBox/inputBox.ts
2
3
66.67%

src/sql/workbench/browser/modal/dialogHelper.ts
5
9
55.56%

src/sql/workbench/services/connection/browser/connectionWidget.ts
0
14
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
26406

Relevant Lines:
57819

💛  - Coveralls

LGTM. Is password not a required field?

@kburtram SQL Server does allow SQL Login without password.


Upgrade to dat-node@1. Fixes #168

Major changes:

moved from emitting events on the dat instance, which isn't an eventemitter any more, to an emitter at dat.events
no need to persist dat.owner any more
make dat.stats a getter to the underlying hyperstats instance
no need to manually close dat.db() any more

thanks for the review so far, @joehand!

Looks good! Hopefully it was relatively seamless to use the new dat-node 😬

@joehand after the versioning confusing yes it was :)
I would just also keep master the current stable version, otherwise it's confusing to look at the repo's code and see a different version from what you're using.

We found multiple regressions, the first was with importing a dat and then reopening the window it would crash because .dir was renamed to .path. We've fixed this with the changes we've pushed
The second issue is that we cannot delete dats that we create and the window freezes without throwing an error. We created a dat that was ~50mb. We weren't able to fix this but tracked it down to the remove method in data-manager. dat.close() never calls a callback (cc/ @joehand)

We found multiple regressions, the first was with importing a dat and then reopening the window it would crash because .dir was renamed to .path. We've fixed this with the changes we've pushed

Ah, thanks for catching this bug and fixing it!

dat.close() never calls a callback (cc/ @joehand)

I've seen this too, in https://github.com/datproject/dat-node/issues/84. @joehand could you run the app and see if you can reproduce? Otherwise we could also try to create a node only gist of this happening.


Trying to import from local module called "exceptions" is caught

Looks like this might be a bit of a bug?
Environment

Python 3.6.0
isort 4.2.5

Steps to Reproduce

Save the following code to a file called test.py:

from some_local_module import test
from exceptions import TestException

raise TestException

Run isort:  $ isort

Saw
isort flagged the import of TestException because it thought it should come before some_local_module.
Expected
There shouldn't be an issue because there is no longer an exceptions module in Python 3. I expected the isort command to pass.

This is... complicated... you could technically call it a bug, but is also acting based on the expected outcome giving the design. It is hard, at times, for isort to correctly identify where stdlib modules are located to correctly automatically determine if an import is part of the stdlib because of the various places within a system they can be located. To get around this, there is a master list of all imports that have ever been known as being part of the stdlib. One of the key design goals of isort is to be able to run on any highly used version of Python, over very large complex code bases all at once, that may contain different pieces that are designed to run on different Python runtimes, without having to run isort on that same Python version. That makes it impossible for isort to even have a mapping of Python version -> stdlib import names - without say requiring a user to set a flag.
As an alternative: You could easily solve your given problem without an upgrade to isort by doing isort --project exceptions to explicitly identify that module name as a project level import locally.
Thanks!
~Timothy

@timothycrosley, makes sense!  Thanks for the detailed response!


Vietnamese translation

Summary of changes
I added Vietnamese translation for timex lib

Coverage increased (+0.007%) to 72.07% when pulling e881f303d2f867d2a151a53509fd1f11df877e7a on theanht1:vi-translation into 78bee8d285a8585123e6422776296d38607ab568 on bitwalker:master.


destructn after intro doesn't work

The following code fails with Hypothesis not found. It works replacing the ;; with a dot.
Theorem exists_example_2 : forall n,
  (exists m, n = 4 + m) ->
  (exists o, n = 2 + o).
MProof.
  intros n;; destructn 0.

Can't reproduce.


docker-entrypoint.sh overwrites .conf settings, sometimes incorrectly

We've had a pretty interesting day tracking down why our almost-ready-to-go-live Neo4j instance was running out of memory on a 32GB machine with a 10GB page size set in our neo4j.conf. We discovered that the neo4j-wrapper.conf running in the container had changed at container runtime and had different memory settings than what were baked into the image's config files.
The docker-entrypoint.sh script invariably overwrites settings in the config files based on (undocumented?) environment variables, for example:

$NEO4J_dbms_memory_heap_maxSize
$NEO4J_dbms_memory_pagecache_size
et al...

This was really surprising to us and hard to track down. We were using COPY commands in our FROM neo4j:enterprise Dockerfile to copy our customized .conf files into our derivative image, but these files' settings were being overwritten without any obvious cause (until we looked in the ENTRYPOINT).
Our workaround was to define these environment variables in our Dockerfile:
# NEO4J_dbms_memory_heap_maxSize is in megabytes
ENV NEO4J_dbms_memory_heap_maxSize   10000

# NEO4J_dbms_memory_pagecache_size is in kilobytes
ENV NEO4J_dbms_memory_pagecache_size 9000000

Furthermore, we noticed that dbms.memory.heap.initial_size setting was being set to the value intended for dbms.memory.heap.max_size, and that there is no way to set the initial size via these variables. Even if we set the setting's value in our config file, this entrypoint would just overwrite it. We'd probably need to COPY in our own customized /docker-entrypoint.sh in to get around this bug.
I noticed that the two separate config files (neo4j.conf and neo4j-wrapper.conf were being merged together in Neo4j 3.1 but maybe along with 3.1 we could figure out a better way to manage these config settings for the Docker image?
It seems standard practice across Dockerized services to respect config files first and then overwrite a setting iff an environment variable was actually defined. Modifying the config file in the container at container initialization time is probably not the most elegant option for making the environment variable overrides, either.
Thoughts?

@jicksta I'm sorry that you've had trouble with this behaviour. I can see that it's surprising if you are deriving your own image from the standard one and copying in config files -- we hadn't considered that case when designing the configuration mechanism.
The intended way of providing your own complete config files to the image is via a /conf volume. If you were to add config files to /conf in your derived image, you would find that they don't get modified and you won't need to define the environment variables.
Neo4j itself does not have any way of injecting configuration via environment variables, so the only way that the Docker image can provide this is by modifying the config files. We hope to enhance Neo4j so that it can take config from the environment natively, but we won't be able to do that for 3.1.
The environment variables that the image responds to are documented here. You'll see that the only ones we provide default overrides for are the memory-related settings. This is because Neo4j's default behaviour is tuned for a server deployment where Neo4j is the only resource-hungry software running on the server; so by default Neo4j will consume the majority of the available memory. We consider that to be inappropriate for container deployment, so we've limited the default memory usage.
On the specific question of initial vs maximum heap size, our standard recommendation for Neo4j is to configure them to be the same. This gives much more predictable memory consumption, avoiding problems where servers run out of memory under load due to individual queries. We decided to bake this recommendation into the Docker image to simplify things for operators.

@benbc

The intended way of providing your own complete config files to the image is via a /conf volume. If you were to add config files to /conf in your derived image, you would find that they don't get modified and you won't need to define the environment variables.

I'll give this a try. I should add tho that AFAIK it's pretty common to COPY config files into a derivative image. Volumes can bring their own hassles, so I'm not sure why having a volume for just /conf would be helpful to our particular use case.
Also thanks for the link the to documentation about the env variables.

On the specific question of initial vs maximum heap size, our standard recommendation for Neo4j is to configure them to be the same. This gives much more predictable memory consumption, avoiding problems where servers run out of memory under load due to individual queries. We decided to bake this recommendation into the Docker image to simplify things for operators.

Consider that most folks using dockerized Neo4j in production would probably have Neo4j wired up into a local Docker-Compose (or similar) system running on a local development environment. We want to set the initial memory size to be something smaller so we can have a Neo4j instance running in the local devmode cluster that doesn't suck up precious laptop memory resources unless necessary.

@jicksta The /conf volume is intended for direct users of the standard Neo4j image, not for people extending the image. I only mention it because it gives you a simpler workaround for your problem.

@jicksta I take your point about Compose etc. However we think that simplifying the surface and removing the possibility for nasty surprises in production is more important in this case.

@benbc I am still having trouble with this, despite using a /conf volume as directed. This is how I'm running Neo4j:
docker run -d \
    --publish 7474:7474 \
    --publish 7687:7687 \
    --restart=always \
    --volume /ebs/xvdi/conf:/conf \
    --volume /ebs/xvdi/data:/data \
    --volume /ebs/xvdi/logs:/logs \
    neo4j

In /ebs/xvdi/conf/neo4j.conf I have uncommented and modified these lines:
dbms.memory.heap.initial_size=1G
dbms.memory.heap.max_size=1G

But Neo4j is only allocating 512M, judging by the output of docker top:
$ sudo docker top eager_swartz
UID                 PID                 PPID                C                   STIME               TTY                 TIME                CMD
root                1731                1714                1                   Oct24               ?                   00:00:26            /usr/lib/jvm/java-1.8-openjdk/jre/bin/java -cp /var/lib/neo4j/plugins:/var/lib/neo4j/conf:/var/lib/neo4j/lib/*:/var/lib/neo4j/plugins/* -server -Xms512M -Xmx512M -XX:+UseG1GC -XX:-OmitStackTraceInFastThrow -XX:+AlwaysPreTouch -XX:+UnlockExperimentalVMOptions -XX:+TrustFinalNonStaticFields -XX:+DisableExplicitGC -Djdk.tls.ephemeralDHKeySize=2048 -Dunsupported.dbms.udc.source=tarball -Dfile.encoding=UTF-8 org.neo4j.server.CommunityEntryPoint --home-dir=/var/lib/neo4j --config-dir=/var/lib/neo4j/conf

This is with the official 3.2.5 CE image.

I did some more digging in my running container.
It looks like docker-entrypoint.sh makes a copy of /conf/neo4j.conf and overwrites my un-commented lines.
https://github.com/neo4j/docker-neo4j/blob/a846084502aa63bd5bf29a1fd67105a4d4c734f8/src/3.2/docker-entrypoint.sh#L93-L106
This directly contradicts the documentation, which states:

Any configuration files in the /conf volume will override files provided by the image. This includes values that may have been set in response to environment variables passed to the container by Docker.

Please advise.

@spacecowboy @srbaker 👆 (sorry, I'm not sure who the right people are to ping)

Sorry you're having trouble with this @adamrothman. We'll take a look and get back to you.

Hi @adamrothman Apologies that it took a while to reply to you. We think the documentation is at fault here. It should instead say

Any configuration files in the /conf volume will override files provided by the image. Environment variables passed to the container by Docker will still override the values in configuration files in /conf
volume

With the updated documentation, your work around will be the correct way to achieve what you want.

Updated instructions can be viewed here
https://neo4j.com/docs/operations-manual/current/installation/docker/#docker-conf-volume


ClearCodec error when connecting windows8.1 with remoteFX

Logs -
[11:25:12:969] [80313:b031d000] [INFO][com.freerdp.channels.drdynvc.client] - Loading Dynamic Virtual Channel rdpgfx
[11:25:13:497] [80313:b05a7000] [WARN][com.freerdp.gdi] - avc420_decompress failure: 0, ignoring update.
[11:25:14:360] [80313:b05a7000] [ERROR][com.freerdp.codec.clear] - vBarEntry->count 25 != vBarHeight 8
[11:25:14:361] [80313:b05a7000] [ERROR][com.freerdp.codec.clear] - clear_decompress_bands_data failed!
[11:25:14:361] [80313:b05a7000] [ERROR][com.freerdp.gdi] - clear_decompress failure: -1
[11:25:14:363] [80313:b05a7000] [ERROR][com.freerdp.channels.rdpgfx.client] - context->SurfaceCommand failed with error 1359
[11:25:14:363] [80313:b05a7000] [ERROR][com.freerdp.channels.rdpgfx.client] - rdpgfx_decode failed with error 1359!
[11:25:14:363] [80313:b05a7000] [ERROR][com.freerdp.channels.rdpgfx.client] - rdpgfx_recv_wire_to_surface_1_pdu failed with error 1359!
[11:25:14:364] [80313:b05a7000] [ERROR][com.freerdp.channels.rdpgfx.client] - Error while parsing GFX cmdId: RDPGFX_CMDID_WIRETOSURFACE_1 (0x0001)
[11:25:14:364] [80313:b05a7000] [ERROR][com.freerdp.channels.rdpgfx.client] - rdpgfx_recv_pdu failed with error 1359!
[11:25:14:364] [80313:b05a7000] [ERROR][com.freerdp.channels.drdynvc.client] - drdynvc_order_recv failed with error 1359!

Checked the similar issue #3527 , it looks the same issue is still there? Tested on the latest version. Connected from an iOS client, does it matter?
@akallabeth

@wizwizcao Could you please clarify what latest version is and what you mean by iOS client? Did you use the iOS client of FreeRDP or did you use FreeRDP as the server?

@akallabeth Thanks for the quick response. For latest version, it just means the current code of FreeRDP. For iOS client, use the iOS client. The server is windows 8.1. And one more thing to clarify is this issue is occurred when GFX is enabled, not remoteFX actually. It is running fine with remoteFX but no GFX.

Patching some logging, and it shows this would happen in the "VBAR_CACHE_HIT" process right after a "SHORT_VBAR_CACHE_MISS".

@wizwizcao Ok, that clarifies a bit, but current code is you compiled the client yourself from master branch?  Just download the code and compile. First run the openssl script to setup the libraries, and then run command cmake -DCMAKE_TOOLCHAIN_FILE=cmake/iOSToolchain.cmake -DIOS_PLATFORM=SIMULATOR -DWITH_IOSAUDIO=ON -GXcode to build the Xcode project. Then open the project in Xcode, build and test.
It was working fine with either remoteFX or gfx enabled. But when I turned both of them on, the errors occurred.
I've tried restart the windows8.1 but did not work :-|

@wizwizcao Ok, downloaded from where? Please be more specific, otherwise I can just guess what is going on.

@akallabeth from the git home. I guess I'd better do a clone to make sure everything is up-to-date;)

@wizwizcao Oh, just scrolled though your logs again, did you activate AVC420/H264?

@akallabeth Oh yes, I did some test with AVC420/H264 activated. And some test with no AVC420/H264. This issue could happen in both scenarios.

@akallabeth Tried aFreeRDP and no clear codec problem. Noticed that android has no h264 in default. So, this issue is caused by the AVC420/H264 activated in iOS side? Is there any work around to iOS h264 for now?

@wizwizcao ClearCodec/H264 use both the same paths. There must be some different issue leading to this. Since a similar issue has been solved some months ago I assume you have an older version (maybe 1.1 branch?) but I can not be entirely sure.

@akallabeth not exactly. Right after this issue detected, the current master has been git-cloned to my machine. Went through the same building steps, and the issue reproduced. Steps as following:

git clone the master code
run OpenSSL-DownloadAndBuild.command to build the openssl libraries
run cmake -DCMAKE_TOOLCHAIN_FILE=cmake/iOSToolchain.cmake -IOS_PLATFORM=SIMULATOR -GXcode
open the Xcode project (Xcode v8.2.1)
set executable scheme iFreeRDP
build and run
add a connection/bookmark for a windows 8.1 host
in the Performance configuration, enable remoteFX, GFX, H264
connecting

The connection itself is ok, I can hear the music is playing, but just no pictures. And the error messages will come out, e.g.
24:41:194] [32837:006b8000] [ERROR][com.freerdp.codec.clear] - vBarEntry->count 10 != vBarHeight 16
[19:24:41:196] [32837:006b8000] [ERROR][com.freerdp.codec.clear] - clear_decompress_bands_data failed!
[19:24:41:198] [32837:006b8000] [ERROR][com.freerdp.gdi] - clear_decompress failure: -1
[19:24:41:202] [32837:006b8000] [ERROR][com.freerdp.channels.rdpgfx.client] - context->SurfaceCommand failed with error 1359
[19:24:41:203] [32837:006b8000] [ERROR][com.freerdp.channels.rdpgfx.client] - rdpgfx_decode failed with error 1359!
[19:24:41:203] [32837:006b8000] [ERROR][com.freerdp.channels.rdpgfx.client] - rdpgfx_recv_wire_to_surface_1_pdu failed with error 1359!
[19:24:41:204] [32837:006b8000] [ERROR][com.freerdp.channels.rdpgfx.client] - Error while parsing GFX cmdId: RDPGFX_CMDID_WIRETOSURFACE_1 (0x0001)
[19:24:41:204] [32837:006b8000] [ERROR][com.freerdp.channels.rdpgfx.client] - rdpgfx_recv_pdu failed with error 1359!
[19:24:41:204] [32837:006b8000] [ERROR][com.freerdp.channels.drdynvc.client] - drdynvc_order_recv failed with error 1359!

Not sure if someone else can try to reproduce this issue.

Btw, in Android client, if enable the h264 with openh264, there will be numbers of white or black blocks. Just like some frame data get lost.
If do some update on the iOS code to prevent the clearcodec function breaking, i.e. comment out the return FALSE;
if (vBarEntry->count != vBarHeight)
{
    WLog_ERR(TAG, "vBarEntry->count %"PRIu32" != vBarHeight %"PRIu32"", vBarEntry->count,
				         vBarHeight);
    //return FALSE;
}

The screen view can be rendered, with numbers of white or black blocks, just like Android with openh264 ;(

@wizwizcao Does it work in MSTSC? There are some artefacts that seem to be server related.

@wizwizcao And what kind of H264 decoder do you use? OpenH264 is required for iOS too.

@akallabeth Good catch! OpenH264 is not included in iOS. Let me figure out. Any guide docs would be great appreciated.
Btw, the MSTSC client is working fine, connecting the same windows 8.1. But it seems no AVC/H.264 codec processing? Checked the bandwidth.

Hi @akallabeth ,
The issue is still there after OpenH264 enhanced in iOS.
And it also can be reproduced when connecting to windows 10.
And it happens just in random. Sometime everything is working fine, which looks really weird to me.

@wizwizcao and only on iOS, no others?

@akallabeth so far, yes. 'cause I only checked iOS and Android. Not sure if Android is 100% ok, I've seen its screen get into mess sometime ago, need some time and more test to confirm.

@akallabeth What's happening is, for somehow, the clearcodec bitmap stream sent to client just like:
A...PDU#0
A...PDU#1
A...PDU#2
A...PDU#3
B...PDU#0
B...PDU#1
B...PDU#2
B...PDU#3

And this error occurred after the B...PDU#0(or could be any following B...PDUs) received.
Well, in debugging, we can find the VBarStorage and the ShortVBarStorage have been enriched by the A...PDUs, stored in the same clear. However, the B...PDUs seems recount the VBAR_CACHE_HIT vBarIndex from zero. Thus, it take some A...PDU by mistake, and that's why this error came out.
If simply add a code logic to reset the V-Bar Storage Cursor and the Short V-Bar Storage Cursor to zero once a zero sequenceNumber received, this issue looks not there any more. Please note this is just a test to verify, not a fix.
I assume the B...PDUs would contain a CLEARCODEC_FLAG_CACHE_RESET flag to indicate the V-Bar Storage Cursor and the Short V-Bar Storage Cursor should be reset to zero, but actually not.
So, currently, I am curious that is this kind of PDU data/messages correct? If correct, is this a bug in current clearcodec? If not correct, how to let the host send the right version?

@wizwizcao Ok, that could explain the issue. I've reread the spec [MS-RDPEGFX] but nowhere I could find that kind of reset mentioned there. Maybe I'm missing something or you just found the bug. (I assume your server end is windows 8.1 as mentioned earlier?)

@akallabeth agreed. [MS-RDPEGFX] just mentioned the cursors need to be reset when the flag CLEARCODEC_FLAG_CACHE_RESET meet, i.e. section<IP_ADDRESS>. And the FreeRDP implementation is ok according to this doc.
What's happening is, the remote connections I am doing these days just tell me these kind of B...PDUs recounted the VBarIndex from 0, with no CLEARCODEC_FLAG_CACHE_RESET flag. And I noticed this issue only occurred in the first-time rendering the desktop, right after the remote connection established. If the first-time rendering is ok, then the following operations/processes would be fine.
And yes, my server end is windows8.1, and windows10 has been tested too. This issue could happen in both.

@wizwizcao You could try reverting 6fec7e591d06dc6375e83688e55baf538001b8f5 and see if it works for you. There was an issue with resetting at that time, maybe this patch just hid another issue.

@akallabeth Reverting 6fec7e591d06dc6375e83688e55baf538001b8f5 could work for me for now, for both windows8.1 and windows10.
Actually, I've seen the similar issue as #3642 when connecting to a windows8.1 virtualized on a windows server 2012 r2. I guess there is something not on the right way, but 6fec7e591d06dc6375e83688e55baf538001b8f5 may not be a thoroughly fix.

One quick update, when GFX+H.264 are working, turning off remoteFX and this issue is no longer there. And we'd better not reverting the 6fec7e591d06dc6375e83688e55baf538001b8f5.

I also met clear code error with following error (but no vbar errors), on latest master(1dbd2d28d94f0ac21b3b000eaaa8fa9d1fb638e4)

/opt/freerdp-nightly/bin/xfreerdp /v:<IP_ADDRESS> /u:Administrator /p:ldap4$ /rfx /f /gfx-h264
[11:04:46:124] [5173:5174] [INFO][com.freerdp.client.common.cmdline] - loading channelEx drdynvc
[11:04:46:479] [5173:5174] [INFO][com.freerdp.gdi] - Local framebuffer format  PIXEL_FORMAT_BGRX32
[11:04:46:479] [5173:5174] [INFO][com.freerdp.gdi] - Remote framebuffer format PIXEL_FORMAT_BGRA32
[11:04:46:523] [5173:5174] [INFO][com.winpr.clipboard] - initialized POSIX local file subsystem
[11:04:46:565] [5173:5174] [INFO][com.freerdp.channels.drdynvc.client] - Loading Dynamic Virtual Channel rdpgfx
[11:04:49:538] [5173:5183] [ERROR][com.freerdp.gdi] - clear_decompress failure: -1

However, it works fine with /gdi:sw.

still an issue?

Codecs have been hardened, should artifacts still apply after 2.0.0-rc4 please reopen/create a new issue.


Recognize arm64.

macOS ARM chips define this.

Thanks for the PR. Unfortunately, I cannot find that macro in https://sourceforge.net/p/predef/wiki/Home/.


Feat(Release): Update SDK to use Beta API version 2023-02-14

New Features:
Image export jobs


WIP Home page fe

Link to Ticket
Description of Changes Made
To do: include the event promo block. Possibly remove unneeded streamfield blocks.
How to Test
Screenshots

Expand to see more

MR Checklist

[ ] Add a description of your pull request and instructions for the reviewer to verify your work.
[ ] If your pull request is for a specific ticket, link to it in the description.
[ ] Stay on point and keep it small so the merge request can be easily reviewed.
[ ] Tests and linting passes.

Unit tests

[ ] Added
[ ] Not required

Documentation

[ ] Updated build docs
[ ] Updated editor guidelines (https://docs.google.com/document/d/1PAWccdQ4tfaZsrEWmpDhvP3GH5RRmBOARFVp4b-kje8/edit?usp=sharing)
[ ] Not required

Browser testing

[ ] I have tested in the following browsers and environments (edit the list as required)

Latest version of Chrome on mac
Latest version of Firefox on mac
Latest version of Safari on mac
Safari on last two versions of iOS
Chrome on last two versions of Android

[ ] Not required

Data protection

[ ] Not relevant
[ ] This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Accessibility

[ ] Automated WCAG 2.1 tests pass
[ ] Manual WCAG 2.1 tests completed
[ ] I have tested in a screen reader
[ ] I have tested in high-contrast mode
[ ] Any animations removed for prefers-reduced-motion
[ ] Not required

Sustainability

[ ] Images are optimised and lazy-loading used where appropriate
[ ] SVGs have been optimised
[ ] Perfomance and transfer of data considered
[ ] If JavaScript is needed alternatives have been considered
[ ] Not required

Pattern library

[ ] The pattern library component for this template displays correctly, and does not break parent templates
[ ] The styleguide is updated if relevant
[ ] Changes are not relevant the pattern library

Closing in order to recreate against the sprint 5 branch


Dashboard: default to last selected device

closes #45

Device sorting is already implemented here: https://github.com/commaai/new-connect/blob/cc11f95348d92f78b8d6527430b944b68758f78e/src/api/devices.ts#L5


UnhandledPromiseRejectionWarning: Unauthorized (401) Maximum credits exceeded

I integrated sendGrid and everything worked fine, but now I receive the following error message below every time I try to send emails.
Although my limit was not exceeded (only 102 emails were sent this month, and a limit is 100 emails per day)
(node:2233) UnhandledPromiseRejectionWarning: Unauthorized (401)
  Maximum credits exceeded
    null
    null
    at Request.http [as _callback] (node_modules/@sendgrid/client/src/classes/client.js:124:25)
    at Request.self.callback (node_modules/request/request.js:185:22)
    at Request.emit (events.js:189:13)
    at Request.<anonymous> (node_modules/request/request.js:1161:10)
    at Request.emit (events.js:189:13)
    at IncomingMessage.<anonymous> (node_modules/request/request.js:1083:12)
    at Object.onceWrapper (events.js:277:13)
    at IncomingMessage.emit (events.js:194:15)
    at endReadableNT (_stream_readable.js:1125:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)
(node:2233) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:2233) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

The following code is used to send the email:
const sgMail = require('@sendgrid/mail');
const { SENDGRID_API_KEY } = process.env;

const forgotPasswordMail = (to, first_name, last_name) => {
  sgMail.setApiKey(SENDGRID_API_KEY);
  const msg = {
    to,
    from<EMAIL_ADDRESS>    subject: 'Your password reset request',
    templateId: 'd-71746df705c44a8b9d5bb5c10d861754',
    dynamic_template_data: {
      first_name,
      last_name,
    }
  };
  sgMail.send(msg);
}

Technical details:

node version: v10.15.3

Closing as duplicate of #970
See my comment there to follow-up.

Facing the same issue. Per day limit is also not reached but I receiving
ResponseError: Unauthorized
at node_modules/@sendgrid/client/src/classes/client.js:146:29
at processTicksAndRejections (node:internal/process/task_queues:94:5) {
code: 401,
response: {
headers: {
server: 'nginx',
date: 'Fri, 30 Jul 2021 07:43:50 GMT',
'content-type': 'application/json',
'content-length': '76',
connection: 'close',
'access-control-allow-origin': 'https://sendgrid.api-docs.io',
'access-control-allow-methods': 'POST',
'access-control-allow-headers': 'Authorization, Content-Type, On-behalf-of, x-sg-elas-acl',
'access-control-max-age': '600',
'x-no-cors-reason': 'https://sendgrid.com/docs/Classroom/Basics/API/cors.html',
'strict-transport-security': 'max-age=600; includeSubDomains'
},
body: { errors: [Array] }
}
} {
errors: [ { message: 'Maximum credits exceeded', field: null, help: null } ]
}

Hi @sanmithapalanisamy! SendGrid Support has the tools to help debug these kinds of issues. Please open a new support ticket to get help with this 401 error.

I am facing the same issue: {"errors":[{"message":"Maximum credits exceeded","field":null,"help":null}]}
Any kind of help will be appreciated.
Thanks!