Where's SPICE gone

Trying to sort SPICE data and it's producing corrupt analysis trees
GRSI [0] new TBrowser
Created a GRootCanvas.
GCanvasInit called.
(class TBrowser*)0x17594d0
GRSI [1] Error in TFile::ReadBuffer: error reading all requested bytes from file analysis35661_000.root, got 240 of 300
Error in TFile::Init: analysis35661_000.root failed to read the file type data.
(class TFile*)0x1648cd0
Also during the file construction SPICE and S3 arent listed, where they were before.
Any thoughts? I have done a hard reset to the master.
Attempting to make analysis trees.
Closing after Sort.
Found 1 trees with 20263829 total fragments.
Sorting tree[1]: fragment35651_000.root
starting
TGRSIRunInfo Status:
RunNumber:    35651
SubRunNumber: 000
RunStart:<PHONE_NUMBER>
RunStop:<PHONE_NUMBER>
RunLength:    840
TIGRESS:      true
SHARC:        false
TRIFOIL:      false
TIP:          false
CSM:          false
GRIFFIN:      false
SCEPTAR:      false
PACES:        false
DESCANT:      false
Build Window   = 200
Moving Window  = TRUE
AddBack Window = 15.0
Array Position = 110

==============================

parsed 10944 lines.
Successfully read 912 TChannels from File
AnalysisTreeBuilder:  read in 912 TChannels.
Tree Index not found, building index on TriggerId/FragmentId... done!
MEM_SIZE =<PHONE_NUMBER>4
created output file: analysis35651_000.root
created AnalysisTree
terminate called after throwing an instance of 'std::out_of_range'
what():  vector::_M_range_check

Likely just not being written to the tree. Can you point me in the direction of a Midas file so that I can try? Thanks for testing this stuff out by the way I'm expecting quite a few bugs on the tigress side at this point.

On Oct 21, 2015, at 2:54 AM, jsmallcombe<EMAIL_ADDRESS>wrote:
Trying to sort SPICE data and it's producing corrupt analysis trees
GRSI [0] new TBrowser
Created a GRootCanvas.
GCanvasInit called.
(class TBrowser)0x17594d0
GRSI [1] Error in TFile::ReadBuffer: error reading all requested bytes from file analysis35661_000.root, got 240 of 300
Error in TFile::Init: analysis35661_000.root failed to read the file type data.
(class TFile)0x1648cd0
Also during the file construction SPICE and S3 arent listed, where they were before.
Any thoughts? I have done a hard reset to the master.
Attempting to make analysis trees.
Closing after Sort.
Found 1 trees with 20263829 total fragments.
Sorting tree[1]: fragment35651_000.root
starting
TGRSIRunInfo Status:
RunNumber: 35651
SubRunNumber: 000
RunStart:<PHONE_NUMBER>
RunStop:<PHONE_NUMBER>
RunLength: 840
TIGRESS: true
SHARC: false
TRIFOIL: false
TIP: false
CSM: false
GRIFFIN: false
SCEPTAR: false
PACES: false
DESCANT: false
Build Window   = 200
Moving Window  = TRUE
AddBack Window = 15.0
Array Position = 110
==============================
parsed 10944 lines.
Successfully read 912 TChannels from File
AnalysisTreeBuilder: read in 912 TChannels.
Tree Index not found, building index on TriggerId/FragmentId... done!
MEM_SIZE =<PHONE_NUMBER>4
created output file: analysis35651_000.root
created AnalysisTree
terminate called after throwing an instance of 'std::out_of_range'
what(): vector::_M_range_check
—
Reply to this email directly or view it on GitHub.

The problem is that Spice and S3 were a late addition and those branches are no longer being constructed. I will put them back in. Can you test it once I merge it? Also send me a computer and path to a midas file or a sample midas file so that I can try testing it as well.

As a heads up I have changed the "GetHit" functions that you guys were using to "GetSiLiHit" as we will eventually move these over to TGRSIDetectorHits and the GetHit returns a base TGRSIDetectorHit with not all of the same functionality of the SiLiHit. I have also added error handling on the hit vectors so maybe that will give some more detail on where it's failing.

This could also be an issue with Tigress. It was switched to a clones array and I am unsure of how much that was tested.

It was tested as a clones array. It should be OK.  If I can find some free
time I will try to push a more comprehensive tigress this week.
On Oct 21, 2015 9:48 AM, "Ryan Dunlop"<EMAIL_ADDRESS>wrote:

This could also be an issue with Tigress. It was switched to a clones
array and I am unsure of how much that was tested.
—
Reply to this email directly or view it on GitHub
https://github.com/GRIFFINCollaboration/GRSISort/issues/532#issuecomment-149901613
.

Data is in midtig02_data/tiguser/SPICETestAnalysis/Sdata/SPICETestAugust2015
That was for run35661_000.mid
I can compile the currently, same issue as Henderson in the next thread.
We are trying to do development of analysis for both Tigress+Tip and Tigress+Spice at this end, obviously we don't want to work on incredibly out of date version, so do we have an ETA on when we can work on these detector classes without them being re-written every 5 minutes?

The detector classes are, for the most part, not going to change anymore. The leangrsi side of things was evolving quickly because we did an overhaul. The detector classes shouldn’t have been touched on the master branch for the last 4 or 5 months.
Things should not bother you at least to the point that you can’t develop. As long as you write code that interfaces into the class through functions and you don’t touch the actual data members, we shouldn’t have a problem with you developing anything. If you are talking about doing actual analysis sorting, it should probably be exterior from those classes anyway which requires interfacing, and shouldn’t affect your code. There could be changes in the very near future with Tigress/sharc/tip/Sili/S3 as we make these leaner, but those changes won’t affect code, they will only affect a written root file so it might require a quick fragment->analysis rebuild which are pretty quick with the lean version. What level of development are you talking about? Can you give me a list of detector systems you are working on and the priority in which they should be fixed?

On Oct 21, 2015, at 2:21 PM, jsmallcombe<EMAIL_ADDRESS>wrote:
Data is in midtig02_data/tiguser/SPICETestAnalysis/Sdata/SPICETestAugust2015
That was for run35661_000.mid
I can compile the currently, same issue as Henderson in the next thread.
We are trying to do development of analysis for both Tigress+Tip and Tigress+Spice at this end, obviously we don't want to work on incredibly out of date version, so do we have an ETA on when we can work on these detector classes without them being re-written every 5 minutes?
—
Reply to this email directly or view it on GitHub https://github.com/GRIFFINCollaboration/GRSISort/issues/532#issuecomment-149984011.

How is this problem looking now? Still there?

"For the most part" is not overly reassuring. 4 months? You changed TSiLi today!
We don't just want to interface with the code we want to bloody edit it, these are our detectors and we want to be able to add and change data members, which we aren't going to do while you bugger about with underlying classes.
TTigress, TTip, TSiLi, TS3 and TRF at the moment.
We are looking at adding our own wave function fitting algorithms at the Fragment->Detector stage.
As for the sorting problem:
Spice and S3 are at least in the list now, but the vector  error
terminate called after throwing an instance of 'std::out_of_range'
what():  vector::_M_range_check
Remains and the output files are still unreadable.

Adding functionality to fit waveforms is completely in line with the way
things are set up.  In fact, this is already done for the RF where the
phase is extracted by fitting a waveform stored in the fragment.  Similar,
the TTriFoil class does a very primitive wave form analysis to set the
"tbeam' variables.  This is nothing new.   I have talked with Aaron about
adding this to tip as well but as there is little evidence that SFU will
switch there analysis I have never felt the pressure to put it in.
You absolutely do not want to change data members on the fly.  It will
break the analysis for everyone else.  The code as it stands is provides a
frame work to get to the data.  You are more than welcome to clone it and
change it as you wish, however you should fork it and do it on your own
branch. The farther you drift from what people are trying to provide, the
more on your own you will be.  I highly encourage you to contribute by
submitting ideas and/or code updates to the main repo.  To be fair, Ryan
did not change the TSiLi class today, he simply brought it back after a
complicated merge.  He is volunteering his time to take care of this repo
which we gave to him because we thought (still think) that he is doing an
excellent job.  It wasn't so long ago that such a frame work did not exists
for anyone at TRIUMF, believe me this problems are minuet compared to the
issues just a few years back.
Now, the error you post is because something is trying to call a hit which
does not exists.  If you tell me a file and computer I can take a closer
look.
On Wed, Oct 21, 2015 at 6:16 PM, jsmallcombe<EMAIL_ADDRESS>wrote:

"For the most part" is not overly reassuring. 4 months? You changed TSiLi
today!
We don't just want to interface with the code we want to bloody edit it,
these are our detectors and we want to be able to add and change data
members, which we aren't going to do while you bugger about with underlying
classes.
TTigress, TTip, TSiLi, TS3 and TRF at the moment.
We are looking at adding our own wave function fitting algorithms at the
Fragment->Detector stage.
As for the sorting problem:
Spice and S3 are at least in the list now, but the vector error
terminate called after throwing an instance of 'std::out_of_range'
what(): vector::_M_range_check
Remains and the output files are still unreadable.
—
Reply to this email directly or view it on GitHub
https://github.com/GRIFFINCollaboration/GRSISort/issues/532#issuecomment-150040340
.

I'm a fairly bad coder but I'm pretty sure I can add a data member to TSiLiHit without the world exploding.
If you are so worried about people breaking the code when making changes then more documentation on the code flow and style is required. Tell us how to add things that won't break the code, dont tell us not to add things to the code.
There are enough of us in the tigress group that want the SFU code implemented that we are going to do it. We dont need your permission, nor you to do it for us. We just need a stable framework and instructions on what not to break.
Data is midtig02 data/tiguser/SPICETestAnalysis/SPICETestAugust2015/run35661_000.mid
I am currently working on smilodon

No one told you not to add things.  What I said was to fork it and add what
you want.  When you fork it you have your own personal copy where you can
added what you want, where you want, when you want.  The issue to adding
things to the code as I see it, is it can physically change on going
analysis for people.  I find this to be very bad thing.
Yes, I think the sfu stuff should be in.  However you should really check
what has already been done.  It's all there made freely available to you
and everyone else.  Fortunately for all those doing analysis with the code,
you do need someone with ownership and know how before anything will make
it into the main repo.  This is not to prevent you from adding things or
praticipating but to keep the broken to a minimum.  Again, on your own fork
you can go nuts and add every future or class you can come up with.  If you
think it is good when it is done, push it upstream and let others look at
it.  That is how collaborative coding works.
On Wed, Oct 21, 2015 at 7:01 PM, jsmallcombe<EMAIL_ADDRESS>wrote:

I'm a fairly bad coder but I'm pretty sure I can add a data member to
TSiLiHit without the world exploding.
If you are so worried about people breaking the code when making changes
then more documentation on the code flow and style is required. Tell us how
to add things that won't break the code, dont tell us not to add things to
the code.
There are enough of us in the tigress group that want the SFU code
implemented that we are going to do it. We dont need your permission, nor
you to do it for us. We just need a stable framework and instructions on
what not to break.
Data is midtig02
data/tiguser/SPICETestAnalysis/SPICETestAugust2015/run35661_000.mid
I am currently working on smilodon
—
Reply to this email directly or view it on GitHub
https://github.com/GRIFFINCollaboration/GRSISort/issues/532#issuecomment-150048328
.

The point is that there are base data member that exist for a detector system. Charge, timestamp, etc. You can set those with Setters, you can get those with getter functions. If you are adding variables that are not base variables, you need to add them as transient members (much like how we do with energy). That way nothing breaks in the root files, and things run much more quickly. That is what I mean by interfacing, your function shouldn’t have to access the non transient data members.
So your “I'm a fairly bad coder but I'm pretty sure I can add a data member to TSiLiHit without the world exploding. If you are so worried about people breaking the code when making changes then more documentation on the code flow and style is required. Tell us how to add things that won't break the code, dont tell us not to add things to the code.” The answer is, you must be extremely careful how you add non-transient data members (in any program!) because it changes I/O.
I tagged the old version as well, and I said the master would not have bugs on the tigress side that would need testing and ironing out. If this is causing problems, please feel free to branch off the old working tag. I brought this back in line because git work had stalled on the master anyway and once the bugs are ironed out this code will be much better.

On Oct 21, 2015, at 7:01 PM, jsmallcombe<EMAIL_ADDRESS>wrote:
I'm a fairly bad coder but I'm pretty sure I can add a data member to TSiLiHit without the world exploding.
If you are so worried about people breaking the code when making changes then more documentation on the code flow and style is required. Tell us how to add things that won't break the code, dont tell us not to add things to the code.
There are enough of us in the tigress group that want the SFU code implemented that we are going to do it. We dont need your permission, nor you to do it for us. We just need a stable framework and instructions on what not to break.
Data is midtig02 data/tiguser/SPICETestAnalysis/SPICETestAugust2015/run35661_000.mid
I am currently working on smilodon
—
Reply to this email directly or view it on GitHub https://github.com/GRIFFINCollaboration/GRSISort/issues/532#issuecomment-150048328.

 I'm not a total fuckwit. Cheers.

Here’s the deal: We had not touched the master for a long time. When we bring in a new version of the code there will be bugs. People need to test to find those bugs. If you don’t like that it’s broken, go back to an old commit, it is very simple to pick your commit. Bugs always occur when big changes happen. You can wait until they are ironed out before moving up to the newest commit. If you want to develop you can, and your changes can be merged, you don’t always have to be on the newest commit to do so.
As long as you don’t directly touch the existing non-transient (transient ends in //! in the header) data members (there shouldn’t be a reason to as they are the absolute basic, should never change, straight out of the data stream variables), then it doesn’t matter if you code on an old version and then bring it into the new version. That is the point of writing encapsulated code. Otherwise, we would always be waiting on someone to finish what they want. If you want to directly add data members, go for it, but you will definitely be slowing the ROOT IO down https://github.com/GRIFFINCollaboration/GRSISort/issues/312 https://github.com/GRIFFINCollaboration/GRSISort/issues/312. I put in a lot of time figuring this issue out, and it does indeed make a very large change in the amount of resources consumed.

 I'm not a total fuckwit. Cheers.

—
Reply to this email directly or view it on GitHub https://github.com/GRIFFINCollaboration/GRSISort/issues/532#issuecomment-150052835.

If you check out the 2.3.23 version, you will be at where the code was last Thursday. That code had not been updated for a month. The current version of master was leangrsi merged with that master version, which was sure to cause bugs because they had been diverged for 6 months. If you had not been told the fact that the master has moved beyond 2.3.23, and 2.3.23 was instead still called master, I'm not sure we would even be having this discussion. This move was to get Tigress in a state where it worked much much better than it does now. At some level I feel like you are attacking us for trying to enhance code that you do not have to use at this point, and we can let you know when it is bug free.
Checking out the old version and developing there is really not a huge issue as we have already made all of merge conflicting decisions. If you want to be working on the most up-to-date code, you always have to merge something, and if we encapsulate the code properly we shouldn't have to worry about updating different aspects of the same class at the same time. This is because if I need the energy for example, using GetEnergy should return the energy, and I really shouldn't care how it became the energy. Using fEnergy, on the other hand, may not work because of the details on how fEnergy actually becomes energy. We have done this quite often on other classes in the code (TPPG, TScaler for example) This is what I meant by use "interfacing functions" and not the direct members.
To be honest, there isn't a lot of documentation on the innards of the code because we are low on the number of people actively developing said innards. Most of this is to get code out there for people to be able to do their own analyses (myself included). I have spent some time writing documentation to be able use the code and analysis classes, but unfortunately, we just do not have the man power to also document how the code behaves in the background.
I'll be in Vancouver starting Thursday through Sunday. If you want to sit down with Vinzenz and I we can plan how to attack this with the most efficiency. I can lay out the way the detector classes work etc. We will be in the Griffin counting room. Until then, if you take a look at the way Griffin, Sceptar and Descant are coded, it should be able to give you a good idea for how we want Tigress et al to look (waveform processing included). It should give you an idea of what I mean by minimally touching the non-transient members, and not including more members than necessary.

I just changed something to do with the RF (even though run info says it’s not there) and it ran all the way through. I’m not sure if this is an intermittent problem or not. Is there supposed to be an RF in these data?

On Oct 21, 2015, at 7:36 PM, Ryan Dunlop<EMAIL_ADDRESS>wrote:
Here’s the deal: We had not touched the master for a long time. When we bring in a new version of the code there will be bugs. People need to test to find those bugs. If you don’t like that it’s broken, go back to an old commit, it is very simple to pick your commit. Bugs always occur when big changes happen. You can wait until they are ironed out before moving up to the newest commit. If you want to develop you can, and your changes can be merged, you don’t always have to be on the newest commit to do so.
As long as you don’t directly touch the existing non-transient (transient ends in //! in the header) data members (there shouldn’t be a reason to as they are the absolute basic, should never change, straight out of the data stream variables), then it doesn’t matter if you code on an old version and then bring it into the new version. That is the point of writing encapsulated code. Otherwise, we would always be waiting on someone to finish what they want. If you want to directly add data members, go for it, but you will definitely be slowing the ROOT IO down https://github.com/GRIFFINCollaboration/GRSISort/issues/312 https://github.com/GRIFFINCollaboration/GRSISort/issues/312. I put in a lot of time figuring this issue out, and it does indeed make a very large change in the amount of resources consumed.

 I'm not a total fuckwit. Cheers.

—
Reply to this email directly or view it on GitHub https://github.com/GRIFFINCollaboration/GRSISort/issues/532#issuecomment-150052835.

There should be RF in all of the data from the SPICE experiment I believe.

So I definitely got this problem the first time I tried to run the code on this file in Guelph. However, every time since then I have not received the error. This makes me think that it is an initialization problem in one of the Detector classes. RF tells me it doesn't exits, so I'll look into that problem as well.

I am working with some RF data from the recent TIP experiment and the RF seems to be there. I will check what I see for the SPICE data now.

It’s actually frustrating that it failed first try and I can’t get it to fail anymore.

On Oct 22, 2015, at 1:26 PM, jhenderson88<EMAIL_ADDRESS>wrote:
I am working with some RF data from the recent TIP experiment and the RF seems to be there. I will check what I see for the SPICE data now.
—
Reply to this email directly or view it on GitHub https://github.com/GRIFFINCollaboration/GRSISort/issues/532#issuecomment-150297254.

This is the vector out of range error? I fixed that by re-adding the GetTime() function to TTigress (probably should've clarified that this was why it was necessary, woops).

Haha ok. well I'm glad to hear it’s working now. We’ll try to get the detector classes nice, clean and stable in the next week.

On Oct 22, 2015, at 1:28 PM, jhenderson88<EMAIL_ADDRESS>wrote:
This is the vector out of range error? I fixed that by re-adding the GetTime() function to TTigress (probably should've clarified that this was why it was necessary, woops).
—
Reply to this email directly or view it on GitHub https://github.com/GRIFFINCollaboration/GRSISort/issues/532#issuecomment-150297756.


How do you build an Android package or run it in an emulator?

I'm new to react-native. Could you update README with steps to build the app (or run it in an emulator) please?

Nevermind. It wasn't hard to find.
It's react-native android-run  for anyone who comes here with the same question.


Please invite me to the community

Name
Derrick Robel
Additional Context
Please invite me to the GitHub Community Organization

Invitation sent to join the GitHub Organization. Welcome to Infraform 🎉Please check your mail to accept the invitation sent by GitHub! 🤖About usInfraform is a remarkable open-source solution tailored for serverless platforms, aimed at empowering creators to craft their infrastructure solutions. 💻 We're thrilled to welcome you into our vibrant community! ✨ We eagerly anticipate your valuable contributions! 🤓 Don't forget to explore our community on Github and connect with us on LinkedIn 💜 Feel free to spread the word about our community to like-minded individuals interested in development, DevOps, technology, and collaborative contributions. 👉💜👈


Crash when using Optifine/OptiFabric 1.19.2

Minecraft: 1.19.2
Mod: ExtraSounds-2.3.1+1.19.2-1.19.1
Details
When using OptiFabric 1.13.16 and Optifine 1.19.2_HD_U_H9, the game crashes after launching. I know this for a fact as I have tested removing all mods and only using ExtraSounds with and without Optifine/OptiFabric on these versions.
PLEASE attach your latest.log (and crash log if your game crashes), makes it much easier to troubleshoot, thank you!
You can also run the game with the -Dextrasounds.debug=true Java launch parameter to see more info about what's going on.
latest.log

You can't expect OptiFine/OptiFabric support.
https://lambdaurora.dev/optifine_alternatives/
https://fabricmc.net/wiki/community:optifine_alternatives
https://github.com/TheUsefulLists/UsefulMods
https://fabulously-optimized.gitbook.io/modpack/readme/give-up-optifine
https://github.com/skywardmc/additive/wiki/Give-up-OptiFine


Add windows CI 2.x

Signed-off-by: Amit Galitzky<EMAIL_ADDRESS>Description
Describe what this change achieves.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

3 failings tests in windows:
- org.opensearch.ad.ml.CheckpointDaoTests.testDeserializeRCFModelPreINIT
 - org.opensearch.ad.ml.CheckpointDaoTests.testDeserializeRCFModelPostINIT
 - org.opensearch.ad.ml.CheckpointDaoTests.testDeserializeTRCFModel

Codecov Report

Merging #704 (cfa7021) into 2.x (038fc54) will decrease coverage by 0.33%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x     #704      +/-   ##
============================================
- Coverage     79.24%   78.91%   -0.34%
+ Complexity     4257     4234      -23
============================================
  Files           301      301
  Lines         17872    17872
  Branches       1897     1897
============================================
- Hits          14163    14104      -59
- Misses         2809     2860      +51
- Partials        900      908       +8

Flag
Coverage Δ

plugin
78.91% <ø> (-0.34%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...rch/ad/transport/ForwardADTaskTransportAction.java
94.06% <0.00%> (-3.39%)
:arrow_down:

...ansport/handler/AnomalyResultBulkIndexHandler.java
83.87% <0.00%> (-3.23%)
:arrow_down:

...java/org/opensearch/ad/task/ADBatchTaskRunner.java
81.76% <0.00%> (-2.74%)
:arrow_down:

...ain/java/org/opensearch/ad/task/ADTaskManager.java
75.69% <0.00%> (-2.19%)
:arrow_down:

...ava/org/opensearch/ad/task/ADHCBatchTaskCache.java
90.12% <0.00%> (-1.24%)
:arrow_down:

...rch/ad/transport/AnomalyResultTransportAction.java
80.18% <0.00%> (-0.70%)
:arrow_down:

...opensearch/ad/indices/AnomalyDetectionIndices.java
71.93% <0.00%> (-0.38%)
:arrow_down:

Btw, do you know if we want to support for 3.0 as well? Wondering if it's worth front-porting there, and if it's not ready, could just add the changes, but have them commented out in the workflow file for now until that's possible.

Btw, do you know if we want to support for 3.0 as well? Wondering if it's worth front-porting there, and if it's not ready, could just add the changes, but have them commented out in the workflow file for now until that's possible.

Actually now that I check 3.0 has just been fixed. I can either forward this or close this. merge into main and backport to 2.x

Btw, do you know if we want to support for 3.0 as well? Wondering if it's worth front-porting there, and if it's not ready, could just add the changes, but have them commented out in the workflow file for now until that's possible.

Actually now that I check 3.0 has just been fixed. I can either forward this or close this. merge into main and backport to 2.x

Front porting should be fine.

Btw, do you know if we want to support for 3.0 as well? Wondering if it's worth front-porting there, and if it's not ready, could just add the changes, but have them commented out in the workflow file for now until that's possible.

Actually now that I check 3.0 has just been fixed. I can either forward this or close this. merge into main and backport to 2.x

Front porting should be fine.

missed this haha, I guess we will merge the other one already.


DRAFT Ruff: create config file and run auto format & fixes

Closing draft - merged Robocop will support Ruff by default.


Add activities header to the guide instead of putting it under approaches

In the guide, under each objective the activities file is being nested under the approaches header. This should have its own header because it has more activities than the smaller "approaches" section includes.

Added styling on how to include the "activities" in the test branch


Fix duplicate project board when hitting enter key

When hitting the enter key to create a new project column, the request is sent twice because the submit event and key up event are both triggered.
Probably a better solution is to rewrite these parts of the code to avoid using native jQuery but reuse the form-fetch-action class. But it's beyond my ability.

I was unable to create a backport for 1.20. @lng2020, please send one manually. :tea:
go run ./contrib/backport 27746
...  // fix git conflicts if any
go run ./contrib/backport --continue


remove accidental debug output

when handling $elemMatch, FIELD WOO! was logged to console.

woops... accidentally made this PR against my own fork.


"Dorobanți" are villages in "Dorobanți" common, "ARAD" county

Precondition
Empty the search bar after every step

Steps 1
Acces to the link https://peviitor-ro.github.io/ui.orase/
Expected result
The page opens

environment: test
browse: Opera
device:laptop
OS: Windows 10
Steps to reproduce:
1.Open the website
2. Type in the search bar  "Dorobanți"
Expected results:
1.The location is listed in the drop down menu as  "Dorobanți, ARAD(Dorobanți)"
Actual result:

The location is listed in the drop  down menu as "Dorobanți, ARAD"

Fixed! Poti sa retestezi.


[1pt] PR: Stop trimming outlet levelpaths in waterbodies outside of HUC

Segments of levelpaths that terminate in waterbodies are removed from the levelpath (#671). If there is a waterbody downstream of the HUC then the outlet reaches may be trimmed such that the outlet no longer reaches the edge of the DEM, which causes a number of cascading issues originating in the pit-filling such that reverse flow in the DEM-derived reaches can result in erroneous flowlines and inundation. This PR stops trimming levelpaths outside of the HUC. Fixes #1280.
Changes

src/

derive_level_paths.py: Adds WBD as an input to stream_network.trim_branches_in_waterbodies()
stream_network.py: Selects only segments intersecting the WBD as candidates for removal if they end in waterbodies

Testing
Tested on branch<PHONE_NUMBER> of HUC 12010005.
Deployment Plan (For developer use)
How does the changes affect the product?

[x] Code only?
[ ] If applicable, has a deployment plan be created with the deployment person/team?
[ ] Require new or adjusted data inputs? Does it have start, end and duration code (in UTC)?
[ ] If new or updated data sets, has the FIM code been updated and tested with the new/adjusted data (subset is fine, but must be a subset of the new data)?
[ ] Require new pre-clip set?
[ ] Has new or updated python packages?

Issuer Checklist (For developer use)
You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.

[x] Informative and human-readable title, using the format: [_pt] PR: <description>
[x] Links are provided if this PR resolves an issue, or depends on another other PR
[x] If submitting a PR to the dev branch (the default branch), you have a descriptive Feature Branch name using the format: dev-<description-of-change> (e.g. dev-revise-levee-masking)
[x] Changes are limited to a single goal (no scope creep)
[x] The feature branch you're submitting as a PR is up to date (merged) with the latest dev branch
[x] pre-commit hooks were run locally
[x] Any change in functionality is tested
[x] New functions are documented (with a description, list of inputs, and expected output)
[x] Placeholder code is flagged / future todos are captured in comments
[ ] CHANGELOG updated with template version number, e.g. 4.x.x.x
[x] Add yourself as an assignee in the PR  as well as the FIM Technical Lead

Merge Checklist (For Technical Lead use only)

[ ] Update CHANGELOG with latest version number and merge date
[ ] Update the Citation.cff file to reflect the latest version number in the CHANGELOG
[ ] If applicable, update README with major alterations

Branch<PHONE_NUMBER> (v<IP_ADDRESS>) has an incomplete flowline (yellow) due to its outlet being clipped by a lake outside of the HUC boundary. There are missing catchments (brown polygons) where the DEM-derived reaches (yellow line) deviate from the NWM streams (blue) leaving the red dashed reaches remaining after snapping the crosswalk from the middle of the DEM-derived reach to the nearest NWM stream with a 100 meter max snap distance.

After this patch, the DEM-derived reaches and catchments are complete all the way down to the outlet at the HUC boundary.


CONNECT_CR_CERT:certificate verify failed

Downloaded fresh copy via Git and attempted to build with docker-compose build.
Running into the following error:
  [Composer\Downloader\TransportException]
  The "https://packagist.org/packages.json" file could not be downloaded: SSL operation failed with code 1. OpenSSL Error messages:
  error:14007086:SSL routines:CONNECT_CR_CERT:certificate verify failed
  Failed to enable crypto
  failed to open stream: operation failed

Any ideas on how to troubleshoot this? I can get to https://packagist.org/packages.json just fine from the host machine.
Thank you.

I split the RUN command into multiple RUN's to see which one was throwing the error.
It ended up being /bin/sh -c php /bin/composer.phar global require "hirak/prestissimo:^0.3"
Looks like even though packagist.org was allowed by our filter Docker didn't like that it was proxied...
It is working now.


[OpenSSL] add 3.2

https://www.openssl.org/news/openssl-3.2-notes.html

Duplicate of #4145?

Yes, closing this PR in favor of the older one.


Application complete: Users were unclear that they had finished or what the reference number means

Impact: Users are left feeling unsure they have successfully completed the process.
Evidence: “No payment successful screen.”
“Why do I want a reference number?”
“Payment confirmation – other online service end with this.”
“Want a payment receipt – would rather get this automatically than have to sign up for it.”

Duplicate of #237


Unable to resolve service for type 'Microsoft.Framework.Notification.INotifier'

With a simple app, when I try to add Application Insights, following the Getting Started instructions, I see

Unable to resolve service for type 'Microsoft.Framework.Notification.INotifier' while attempting to activate 'Microsoft.ApplicationInsights.AspNet.TelemetryInitializers.OperationNameTelemetryInitializer'

Detailed stack trace:
System.InvalidOperationException: Unable to resolve service for type 'Microsoft.Framework.Notification.INotifier' while attempting to activate 'Microsoft.ApplicationInsights.AspNet.TelemetryInitializers.OperationNameTelemetryInitializer'.
   at Microsoft.Framework.DependencyInjection.ServiceLookup.Service.PopulateCallSites(ServiceProvider provider, ISet`1 callSiteChain, ParameterInfo[] parameters, Boolean throwIfCallSiteNotFound)
   at Microsoft.Framework.DependencyInjection.ServiceLookup.Service.CreateCallSite(ServiceProvider provider, ISet`1 callSiteChain)
   at Microsoft.Framework.DependencyInjection.ServiceProvider.GetResolveCallSite(IService service, ISet`1 callSiteChain)
   at Microsoft.Framework.DependencyInjection.ServiceLookup.ClosedIEnumerableService.CreateCallSite(ServiceProvider provider, ISet`1 callSiteChain)
   at Microsoft.Framework.DependencyInjection.ServiceProvider.GetResolveCallSite(IService service, ISet`1 callSiteChain)
   at Microsoft.Framework.DependencyInjection.ServiceProvider.GetServiceCallSite(Type serviceType, ISet`1 callSiteChain)
   at Microsoft.Framework.DependencyInjection.ServiceProvider.b__7_0(Type key)
   at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory)
   at Microsoft.Framework.DependencyInjection.ServiceProvider.GetService(Type serviceType)
   at Microsoft.Framework.DependencyInjection.ServiceProviderExtensions.GetService[T](IServiceProvider provider)
   at Microsoft.Framework.DependencyInjection.ApplicationInsightsExtensions.AddServicesToCollection[T](IServiceProvider serviceProvider, ICollection`1 collection)
   at Microsoft.Framework.DependencyInjection.ApplicationInsightsExtensions.<>c__DisplayClass8_0.b__0(IServiceProvider serviceProvider)
   at Microsoft.Framework.DependencyInjection.ServiceLookup.FactoryService.Invoke(ServiceProvider provider)
   at Microsoft.Framework.DependencyInjection.ServiceProvider.ScopedCallSite.Invoke(ServiceProvider provider)
   at Microsoft.Framework.DependencyInjection.ServiceProvider.SingletonCallSite.Invoke(ServiceProvider provider)
   at Microsoft.Framework.DependencyInjection.ServiceLookup.ConstructorCallSite.Invoke(ServiceProvider provider)
   at Microsoft.Framework.DependencyInjection.ServiceProvider.ScopedCallSite.Invoke(ServiceProvider provider)
   at Microsoft.Framework.DependencyInjection.ServiceProvider.<>c__DisplayClass8_0.b__0(ServiceProvider provider)
   at Microsoft.Framework.DependencyInjection.ServiceProvider.GetService(Type serviceType)
   at Microsoft.Framework.Internal.ActivatorUtilities.ConstructorMatcher.CreateInstance(IServiceProvider provider)
   at Microsoft.Framework.Internal.ActivatorUtilities.CreateInstance(IServiceProvider provider, Type instanceType, Object[] parameters)
   at Microsoft.AspNet.Builder.UseMiddlewareExtensions.<>c__DisplayClass2_0.b__0(RequestDelegate next)
   at Microsoft.AspNet.Builder.Internal.ApplicationBuilder.Build()
   at Microsoft.AspNet.Hosting.Internal.HostingEngine.BuildApplication()
   at Microsoft.AspNet.Hosting.Internal.HostingEngine.Start()
   at Microsoft.AspNet.Loader.IIS.RuntimeHttpApplication.ApplicationStart(IHttpApplication application)
   at Microsoft.AspNet.Loader.IIS.HttpApplicationBase.InvokeApplicationStart(IHttpApplication application)

Any ideas on what to check?

I believe you have a mismatch of runtime and Application Insights packages. INotifier was introduced in beta7 as far as I remember. If you are still running beta 6 or earlier - please download earlier version of Application Insights NuGet package.

Hm, @SergeyKanzhelev
"dependencies": {
"Microsoft.AspNet.Server.IIS": "1.0.0-beta7",
"Microsoft.AspNet.Server.WebListener": "1.0.0-beta7",
"Microsoft.AspNet.Diagnostics": "1.0.0-beta7",
"Microsoft.AspNet.Diagnostics.Abstractions": "1.0.0-beta7",
"Microsoft.Framework.Logging.Debug": "1.0.0-beta7",
"Microsoft.ApplicationInsights.AspNet": "1.0.0-beta7",
"Microsoft.Framework.Configuration.Json": "1.0.0-beta7"
},

I believe this will be resolved with this check-in https://github.com/aspnet/Announcements/issues/68 and you will not have this problem in beta8.

Oh, interesting. So you are using beta7. Let me dig into this

Do you use MVC package in your app?

No, I don't.
This is all I have in the app: https://gist.github.com/avodovnik/e432fa135152041f0e86

Ok. I repro-d it with your app. I'll take a look now

Hey @Upendras, override of constructor that we discussed seems to be working. See https://github.com/Microsoft/ApplicationInsights-aspnet5/blob/sergkanz/appWithoutMvc/src/Microsoft.ApplicationInsights.AspNet/TelemetryInitializers/OperationNameTelemetryInitializer.cs#L29. I need to clean up functional tests for empty app I created and we can release a hotfix.

@avodovnik, we have fix in master. You can use compile your own version easily. We will be shipping version of beta8 package soon. For beta 7 for now you can use this workaround:

Insert this line in ConfigureServices:

services.AddMvc();

Include reference to MVC in packages.json:

"Microsoft.AspNet.Mvc": "6.0.0-beta7"

Sorry for inconvenience. Hope you'll like Application Insights

@SergeyKanzhelev thanks for the feedback! Looks like it's working - first events sent!


Added "Erlend Axelsson" in Contributors.md - Erlend Axelsson

@erlend-axelsson, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added Facebook share and tweet feature to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.


Create gallery examples

Convert examples.ipynb to individual gallery examples.

Closed with 973d5084a3276c8ffce65217db89462ae1b82674. Still working on adding thumbnails to gallery.

While it might be possible with nbshpinx (https://github.com/spatialaudio/nbsphinx/issues/668), I couldn't figure out how, so have resorted to save figures from gallery examples as .png's, and adding them to a gallery.md.
As part of PR https://github.com/mdtanker/antarctic_plots/pull/56


PNPM support

Right now, only npm and yarn lock files are supported

I don't see a way to use both systems at the same time (and this way get a pnpm-lock.yaml file)
Even pnpm users can consume this program or why do you need a pnpm (besides using pnpm for your projects)?

Hello !
Yes that's it.
I've only use license-report alongside yarn in the past lol.
Didn't know it wasn't supposed to support it 🤔
Is the lock-file mandatory ? Direct dep' and 1-level depth could suffice with only package.json maybe ?

The problem is, where to find the installed version; package.json only gives a rough orientation for that :-). So instead of scanning the node_modules folder and as it is a good practice to use a lock file, I took the package-lock.json, but this makes it not usable for users of other installation systems.
I have to look, if I find a better solution without bloating the whole program - so give me some time.

fixed by pr #95


GraphQL Java 17.0-beta1 is available

Hi,
we just released GraphQL Java 17.0-beta1. See https://github.com/graphql-java/graphql-java/releases/tag/v17.0-beta1 for the release notes.
We did release a beta to get early feedback from projects like DGS. It would be great if you could try it out let us know.
Thanks!

Sorry, the bug label is wrong :-)

Thanks @andimarek, I'm looking into it!

@andimarek I've done testing with 17.0-beta1 and it's looking good. This includes experimenting with spring-graphql, which is working fine now that it's only using the new graphQLContext instead of also setting context.
I have no further concerns about 17.0.


Cannot build

Good morning,
In freshly cloned repo, the gstreamer v0.9 crate required by ascii-star does not build for me with neither compiler toolchain:
$ cargo build
… <hundreds of dependencies build sucessfully> …
error[E0596]: cannot borrow `**func` as mutable, as it is behind a `*const` pointer
   --> /home/joz/.cargo/registry/src/github.com-1ecc6299db9ec823/gstreamer-0.9.1/src/iterator.rs:419:8
    |
415 |     let func = func as *const &mut (FnMut(T) -> bool);
    |         ---- help: consider changing this to be a mutable pointer: `*mut &mut dyn std::ops::FnMut(T) -> bool`
...
419 |     if (*func)(value) {
    |        ^^^^^^^ `func` is a `*const` pointer, so the data it refers to cannot be borrowed as mutable

error[E0596]: cannot borrow `**func` as mutable, as it is behind a `*const` pointer
   --> /home/joz/.cargo/registry/src/github.com-1ecc6299db9ec823/gstreamer-0.9.1/src/iterator.rs:435:5
    |
431 |     let func = func as *const &mut (FnMut(T));
    |         ---- help: consider changing this to be a mutable pointer: `*mut &mut dyn std::ops::FnMut(T)`
...
435 |     (*func)(value);
    |     ^^^^^^^ `func` is a `*const` pointer, so the data it refers to cannot be borrowed as mutable

error[E0596]: cannot borrow `**func` as mutable, as it is behind a `*const` pointer
   --> /home/joz/.cargo/registry/src/github.com-1ecc6299db9ec823/gstreamer-0.9.1/src/iterator.rs:453:11
    |
447 |     let func = func as *const &mut (FnMut(U, T) -> Result<U, U>);
    |         ---- help: consider changing this to be a mutable pointer: `*mut &mut dyn std::ops::FnMut(U, T) -> std::result::Result<U, U>`
...
453 |     match (*func)(accum.take().unwrap(), value) {
    |           ^^^^^^^ `func` is a `*const` pointer, so the data it refers to cannot be borrowed as mutable

   Compiling tokio-threadpool v0.1.10
   Compiling tokio-tcp v0.1.3
error: aborting due to 3 previous errors

For more information about this error, try `rustc --explain E0596`.
error: could not compile `gstreamer`.
warning: build failed, waiting for other jobs to finish...
error: build failed

$ rustc -V
rustc 1.42.0 (b8cedc004 2020-03-09)

Updating the gstreamer dependency to v0.15 solves this, but the heavily-changed interface  causes ascii-star build to fail nonetheless.
Is there a way around this?

@AntonHermann In your (more active) branch the same dependency is used. Does it still work for you?

closed as fixed, thanks for the PR.  the feature branch is merged into master now as well.


Prioritise community fund proposals by paid fee

CFund proposals are stored using LevelDB, being the hash of the proposal the key. This causes proposals to be randomly prioritised when, for example, there are no enough funds on the fund and the consensus protocol needs to decide which proposal is the first with right to claim coins.
To solve this CCFundDB::GetProposalIndex() should sort the vector based on the paid fee of the proposal, so proposals with a higher fee are prioritised.
┆Attachments: cfund: prioritise proposals by fee

➤ alex v commented:
https://github.com/NAVCoin/navcoin-core/commit/5fa006aba6023afc6131c9ab8b82e3033bd95235

➤ alex v commented:
waiting for the other 2 pull requests to be approved to open a new one


Persistant solution throughout upgrades?

Thanks for this great fix!
I find that when Dropbox (automatically) updates itself, the icon directory gets overwritten and I have to apply the fix again.
Do you know of a workaround for this?

No, unfortunately I don't have an automatic fix. I think I set up a script that I could manually run to reapply the icons after.

I suppose that's easy enough to do. Thanks again!


Support for multiline math formulas

For now, Verso supports inline math and display math but the latter can only use inline code block:

$`\sum_{i=0}^{10} i`

$$`\sum_{i=0}^{10} i`

It doesn't seem possible to use a multiline code block after $$ per my tests.
B.T.W. Previously I learned this syntax from Verso manual in the README but now it's 404, so I found it again in UsersGuide.Markup.

It looks like I made a mistake in the CI script that releases the user's guide when I added the HTML rendering. Fixing that is tracked in #57 - in the meantime, running generate.sh in the repository root will get you both renderings. Sorry about that, and thanks for noticing!
Verso inherits the sharp distinction between inline and block elements from Markdown. Right now, both forms of math are inline elements, while multiline code blocks are block elements. Would you expect a multiline math formula to be inline or block?
That is, does
We can see this because:
$```
\begin{array}
...
\end{array}
```

mean the same thing as
We can see this because:

$```
\begin{array}
...
\end{array}
```

?
I would tend to think that it should not, and that multiline math should still be an inline element. In other words, this would extend the concrete syntax, but not the abstract syntax. Do you agree?
Another alternative would be to relax the parser for the existing math syntax to allow newlines within the backticks, so long as there's no completely blank lines. That is, I could write:
Here's some math: $`
\begin{cases}
...
\end{cases}
` and it's great.

but not
Here's some math: $`
\begin{cases}

...

\end{cases}

` and it's great.

Would that be sufficient for your needs?

Would you expect a multiline math formula to be inline or block?

IIUC, one can't make an inline math formula with mutiple lines in the source in Markdown, so this question doesn't really make sense to me. I tried it here:
$
\LaTeX
$

renders to:
$
\LaTeX
$

Does ... mean the same thing as ... ?

It took me a while to notice the empty line. If I recall and interpret correctly, most markdown flavors will consider the first case invalid (renders verbatim), and consider the second case a block, here I tried it again with Github's flavor:
> Case 1: Here is a multi-line formula, followed in an inline manner $$
\LaTeX
> $$

renders to:

Case 1: Here is a multi-line formula, followed in an inline manner $$
\LaTeX
$$

> Case 2: Here is a multi-line formula
>
> $$
\LaTeX
> $$

renders to

Case 2: Here is a multi-line formula
$$
\LaTeX
$$

Would that be sufficient for your needs?

Probably, yes. I would like to add some context though.
These are what I would expect from writing math formulas in Markdown or Verso or a mark up in general:

I should be able to copy something from a LaTeX file, paste them into some syntax surrounding it, without modifying it;
The surrounding syntax should be intuitive for someone familiar with LaTeX.

Markdown itself breaks expectation 1, consider the following:
> The definition of the Lipschitz group $\\{ x \in \mathop{\mathcal{C}\ell} | x \text{ is invertible and } x v x^{-1} ∈ V \\}$

renders (correctly) to

The definition of the Lipschitz group $\{ x \in \mathop{\mathcal{C}\ell} | x \text{ is invertible and } x v x^{-1} ∈ V \}$

but it requires extra escaping for \, if I just copy it from the originally LaTeX, most markdown flavors won't work as it expects extra escaping rules for Markdown. This is also where doc-gen4 is broken for all non-trivial formulas as discussed on Zulip here, and I hope that Verso could come to rescue.
The syntax in Verso seems to break expectation 2:
I would expect similar things like a $, $$ pairs or \[, \] pairs, and also intuitively accepts a mixture of them and the code block syntax as in the Verso manual, but the mixture is expected to be: inline math mixing with inline code, multiline math mixing with multiline code block, not a mixture that mix everything together, like
$`
\LaTeX
`

which I believe would cause much more trouble in the future, parser-wise or cognition-wise. And I would only use

Inline $`\LaTeX`

Multiline,

$$`
\LaTeX
`

so I wouldn't confuse myself.

Replies cut up by topic :-)

I should be able to copy something from a LaTeX file, paste them into some syntax surrounding it, without modifying it

This makes sense. Part of the reason for using ` around math in Verso is in order to not require extra escapes - this is consistent with how code literals work.

I wonder what would happen if someone writes: ... Does the backtick between blahs terminates the formular abruptly?

Yes. The way to work around this is to use more backticks to start and end the formula, just as with code literals. So $$`` \LaTeX blah blah ` blah ``  won't be terminated early.

the mixture is expected to be: inline math mixing with inline code, multiline math mixing with multiline code block, like ...

The difficulty here is that Verso, like Markdown and HTML, has a distinction between "block-level" and "inline-level" content. Block-level content is things like paragraphs, lists, and headers; inline content is things like text, hyperlinks, and boldface. Paragraphs cannot contain blocks. Math is an inline element, whether it's in display mode or not (that is, whether it's $foo$ or \begin{displaymath}foo\end{displaymath}, to be pedantic and verbose about it). If multiline math is a block element, then it can't logically be part of a paragraph; if it's inline, then it can be. Hence the question about the blank line above. Does that cast some light on what I was going after?
In Verso and Markdown, multiline code blocks are blocks; they are logically distinct from the paragraphs that surround them. Should there be a block-level math element? Or should a math element standing alone be a paragraph that contains a single inline bit of math? I think the latter makes sense, probably, as it's more flexible.
Really, it's a problem that a high degree of Markdown compatibility has made it impossible for Verso to have a single logical paragraph that contains some text, then a bulleted list, then more text, then a formula, then some text. I've got a workaround planned for this, for when it really matters.  Web typography typically hides this because paragraphs don't get indented, but it's not great for other output forms that we want to support.

Sorry that I didn't reply months ago, as I was quite confused by the block level discussion, then distracted by other things. I've used some other authoring tools in the last few months including Hugo, Quarto, Typst and Forester, with this issue in mind, and somehow rereading this issue makes sense to me now.
It seems very reasonable that Verso regards math as an inline element, regardless of whether it's multiple line math.
But there is a detail in one of your early questions I didn't notice before:

relax the parser for the existing math syntax to allow newlines within the backticks, so long as there's no completely blank lines

Months ago I would say this subtle behavior (not allowing blank lines in multiple line math) is unintuitive and error-prone, but taking how Verso has to process Lean and other syntax into account, now I would say this is also reasonable, as long as if a user makes such a mistake unintentionally, the error message is clear on how to fix it.
B.T.W. I wonder if there's progress or some other thinking on this topic lately. I'm aware that this might not be a high priority issue. Thanks!

Hi @david-christiansen , I just tried the latest Verso, it seems that something like
$$`
\f\relax{x} = \int_{-\infty}^\infty
    \f\hat\xi\,e^{2 \pi i \xi x}
    \,d\xi
`

is still not working?
(which allows multiline input for display math)
I can see @lecopivo has tried to work around this limitation in lecopivo/scientific-computing-lean 's Meta.Latex, but it's ideal to have built-in support for this.

Inspired by the workaround (which use less Verso-native plain text for the math block), my workaround mimics one variant of GFM math syntax:
import Verso
import VersoManual

open Lean.MessageSeverity

open Verso Doc Elab in
@[code_block_expander math]
def Manual.math: CodeBlockExpander
  | _args, str => do
    return #[(← `(Doc.Block.para #[Doc.Inline.math Doc.MathMode.display s!"{$str}"]))]

so one can write
```math
f'(x) = \lim_{h → 0} \frac{f(x+h) - f(x)}{h}
```


excluded_exceptions option is not being unsetted

As reported in https://github.com/getsentry/sentry-php/issues/1017#issuecomment-628871050, the anti-deprecation layer in this bundle is using the IgnoredErrorException but it's not unsetting the excluded_exceptions.

Note: https://github.com/getsentry/sentry-php/issues/1017#issuecomment-629608574

Closing this as its being handled well in 4.0.

Closing this as its being handled well in 4.0.


Not all EBSs data is pulling out of Cloudwatch

Hi,
I'm having an issue that I don't know how to debug.
We are running the latest version and trying to collect the EBS burst balance metric from Cloudwatch.
I see a different number of results per each query and the bottom line is that we can't get the BurstBalance metric for all volumes we have.
When I look at our EBS volumes list in AWS console I see about 336 volumes.
in Cloudwatch metrics, when I run MetricName="BurstBalance" I see get 631 results
when I run count (aws_ebs_info) in our Prometheus I get 140 results
When I run count (aws_ebs_burst_balance_average) I get 124 results
Version: v0.24.0-alpha
Config:
discovery:
  exportedTagsOnMetrics:
    ec2: ['Name', 'Cluster']
  jobs:
  - type: ec2
    regions:
      - eu-central-1
    metrics:
      - name: StatusCheckFailed
        statistics:
          - Sum
        period: 600
        length: 60
      - name: StatusCheckFailed_Instance
        statistics:
          - Sum
        period: 600
        length: 60
      - name: StatusCheckFailed_System
        statistics:
          - Sum
        period: 600
        length: 60
  - type: ebs
    regions:
      - eu-central-1
    metrics:
      - name: BurstBalance
        statistics:
          - Average
        period: 600
        length: 600

we also run with flags:
--decoupled-scraping --labels-snake-case
AWS IAM policy:
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Sid": "AllowReadingMetricsFromCloudWatch",
            "Effect": "Allow",
            "Action": [
                "cloudwatch:ListMetrics",
                "cloudwatch:GetMetricStatistics",
                "cloudwatch:GetMetricData",
                "tag:GetResources"
            ],
            "Resource": "*"
        }
    ]
}

similar to #283

I'm seeing this even when searching with a tag:
      discovery:
        jobs:
        - type: ebs
          length: 120
          period: 60
          addCloudwatchTimestamp: true
          regions:
          - us-east-1
          awsDimensions:
          - VolumeID
          searchTags:
          - Key: KubernetesCluster
            Value: "my-cluster.ue1.example.com"
          metrics:
          - name: BurstBalance
            statistics:
            - Sum
            - SampleCount
            - Minimum
            - Maximum
            - Average

returns only aws_ebs_info results and nothing for burst balance.

oh, interestingly i fixed by own problem by removing the awsDimensions key and replacing it with the following under discovery:
        exportedTagsOnMetrics:
          ebs:
          - VolumeId

Closing this as it seems to refer to a really old version of yace. If you can still reproduce the issue with the latest realease please feel free to reopen.


Please list filenames of images with corrupt EXIF data

Hi,
when I run sigal on my image gallery, I see the following error message:
Collecting albums //usr/lib/python3/dist-packages/PIL/TiffImagePlugin.py:788: UserWarning: Corrupt EXIF data.  Expecting to read 12 bytes but only got 8.
  warnings.warn(str(msg))
Collecting albums, done.

I would like to inspect/fix the affected images, but unfortunately sigal does not display their filenames.

Hi,
The warning comes from Pillow, but if you run sigal in verbose mode (-v) it would print the filenames.

Unfortunately, it does not:
$ sigal build --verbose
INFO: Reading settings ...
INFO:       Source : /var/www/html/photos-export-sigal/pictures
INFO:  Destination : /var/www/html/photos-export-sigal/_build
INFO:        Theme : photoswipe
INFO: Using 2 cores
/usr/lib/python3/dist-packages/PIL/TiffImagePlugin.py:788: UserWarning: Corrupt EXIF data.  Expecting to read 12 bytes but only got 8.
  warnings.warn(str(msg))
INFO: Skip empty album: <Album>(path='2010-2011', title='2010-2011')
[...]

Hmm, maybe in debug mode then: sigal build -d -n 1

Thanks for the suggestions!
Unfortunately debug mode still does not display filenames:
$ sigal build -d -n 1
INFO - Reading settings ...
DEBUG - Settings file: sigal.conf.py
DEBUG - Rewrite source : pictures -> /var/www/html/photos-export-sigal/pictures
DEBUG - Rewrite destination : _build -> /var/www/html/photos-export-sigal/_build
DEBUG - Settings:
[...]
INFO -       Source : /var/www/html/photos-export-sigal/pictures
INFO -  Destination : /var/www/html/photos-export-sigal/_build
INFO -        Theme : photoswipe
DEBUG - Plugin paths: []
DEBUG - Registered plugin sigal.plugins.extended_caching
INFO - Using 1 cores
DEBUG - Loaded cache with 74795 entries
/usr/lib/python3/dist-packages/PIL/TiffImagePlugin.py:788: UserWarning: Corrupt EXIF data.  Expecting to read 12 bytes but only got 8.
  warnings.warn(str(msg))
INFO - Skip empty album: <Album>(path='2010-2011', title='2010-2011')

Annoying! We already catch some warnings from Pillow, so I guess we could just convert all warnings to logging messages and add the file name.
https://github.com/saimn/sigal/blob/964c27f9464f7bf8b2573bb7bfced3e6101229f3/sigal/image.py#L65-L81

@LaurentBonnaud - Just pushed a commit to convert all pillow warnings to logging message with the filename. If you can give a try, would be great!

Thanks for the patch!
I am currently on holiday and will test this as soon as I am back...

I upgraded sigal to version 2.1.1, but unfortunately I am still getting the PIL warning without a filename (the output did not change).

Hum, maybe it happens only when reading EXIF ... could you with the exif-warnings branch ? (or applying the patch locally, https://github.com/saimn/sigal/tree/exif-warnings ; the commit is https://github.com/saimn/sigal/commit/fbdac965a9e3fda0a490db626d4e2f58f285ff10)

Thanks a lot for this new patch!
The warning is now caught, but there is still no filename:
Reading settings ...
Source : /var/www/html/photos-export-sigal/pictures
Destination : /var/www/html/photos-export-sigal/_build
Theme : photoswipe
Using 2 cores
PILImage reported a warning for file <PIL.MpoImagePlugin.MpoImageFile image mode=RGB size=4896x2752 at 0x7FEFE52F5790>
<class 'UserWarning'>: Corrupt EXIF data.  Expecting to read 12 bytes but only got 8.

Indeed, fixed in 5f0929cf0e075a9b8d1fe17745d9b9b3b97c7d6c and this is now in master.
Thanks for the help to improve those warnings!

Indeed, fixed in 5f0929c and this is now in master.

I tested this new version and I could locate the affected file :>.

Thanks for the help to improve those warnings!

Thanks for the fix!


The dates are not displayed correctly on day & week view of time tracking page

Description
The dates are not displayed correctly on day & week view of time tracking page
Environment
Linux / MacOS / Android / IOS / Windows
Mozilla / Chrome / Safari

What is the expected behaviour?
The dates should be displayed as 3rd Oct . Without the 0 for dates between 1-10 of each month.
What is the current behaviour?
The dates are displayed as 03rd Oct.
How to reproduce the issue?

Login in to Miru with you credentials.
Go to time tracking page's day and week view

Screenshots or Screencast

Please provide any traces or logs that could help here.
Any possible solutions?
If the bug is confirmed, would you be willing to submit a PR?

please assign me this issue. I would do this.

@Gismo1337 Assigned the ticket to you. Let me know if you need any help :). Thanks for taking this up

@akhilgkrishnan unassign me to this task. to setup the enviroment as a windows user drives me crazy. not enaugh lifetime left for this.

@akhilgkrishnan unassign me to this task. to setup the enviroment as a windows user drives me crazy. not enaugh lifetime left for this.

@Gismo1337 Yeah I understand. But handling a rails app on windows is kind of crazy🤠. Also I know we are lacking on the documentation. We will work on improving those ASAP.

I'd like to work on this

@aaj013 Assigned the ticket to you. Let us know if you need any help on this

@aaj013 Assigned the ticket to you. Let us know if you need any help on this

Hope this is what expected.


Cross-class Action Setup Macro Issue

This appears to be recent that is happening when creating the Cross-class Action Setup Macros.
The word "on" is added at the end of each skill. Putting this in a macro will not activate the abilities, making us have to remove the word "on" manually for each line.

I don't understand this comment. It works for me. My issue is that the cross-class macro doesn't include abilities the class naturally knows which makes these only suited for the currently selected class; instead of suitable for all crafting classes.

When I was informed of the feature in the game, the example I was given had "on" at the end of each action. Does that not work?

The macro is generated for the sequence that you've created, which is for a specific class and recipe, thus it doesn't include those abilities as you mentioned.

It appears it works now... My bad. Earlier today it was not assigning the class abilities, I may have just been doing something wrong. 👍
Sorry. :)

@doxxx OIC. I have been using it to create cross-class macros for recipes of the same level/difficulty. I ended up just finding the unique abilities for the sequence and wrote my own ability macro. Still a great tool, thanks!


when using cronet channel, gRPC server streaming request timed out when server returns error code

What version of gRPC and what language are you using?
v1.33.2 C++
What operating system (Linux, Windows,...) and version?
IOS, Android ( we use same c++ code in both IOS and Android)
What runtime / compiler are you using (e.g. python version or version of gcc)
gcc Apple clang version 12.0.0
What did you do?
Please provide either 1) A unit test for reproducing the bug or 2) Specific steps for us to follow to reproduce the bug. If there’s not enough information to debug the problem, gRPC team may close the issue at their discretion. You’re welcome to re-open the issue once you have a reproduction.
We are using cronet channel with gRPC-C++ library. The cronet channel creation example code.
std::shared_ptrgrpc::ChannelCredentials cronetChannelCredentials =
grpc::CronetChannelCredentials([Cronet getGlobalEngine]);
auto channel = grpc::CreateChannel(target, cronetChannelCredentials);
We send server streaming request with grpc::ClientAsyncReader. Server returns error with error code PERMISSION_DENIED when failed to authenticate user request.
What did you expect to see?
From client side, we expect server streaming request finished with PERMISSION_DENIED error code.
What did you see instead?
From client side, server streaming request timed out with DEADLINE_EXCEEDED error code.
Make sure you include information that can help us debug (full error message, exception listing, stack trace, logs).
The issues are not only applied to PERMISSION_DENIED error, we have similar request timeout for other error codes too.
We found this issue only happens when server streaming request uses cronet channel. No issue if ssl channel is used. Client received PERMISSION_DENIED when we switch to ssl channel for the same scenario.
In addition, for the same cronet channel, if server returns some responses before returns PERMISSION_DENIED error code, client can receive the PERMISSION_DENIED error code from gRPC-c++ library instead of timeout.
We suspect there is an edge case not handled well from grpc cronet transport layer. More specifically, we suspect it's related to trailer only response stream.
See TROUBLESHOOTING.md for how to diagnose problems better.
Anything else we should know about your project / environment?
We use cronet channel with gRPC-C++ library. We think it can be reproduced from cronet channel with gRPC-objc library too because gRPC-objc library uses the same grpc cronet transport code with gRPC-C++.

Hi Qing, sorry for the late reply. I just found that when having grpc_status in your response header, we would treat it as a trailer-only response case. But in your case, we didn't have an OP_RECV_TRAILING_METADATA in our OP storage, so the grpc_status was not read. I may still need to figure out why we missed an OP_RECV_TRAILING_METADATA.


Outdated cask: rar

[x] Insert the name of the cask in the title, after the :.
[x] Insert the name of the cask and a link to it in the body of this issue: rar).
[x] Insert the new version of the app: still at 5.5.b5

The SHA is mismatched, perhaps the app was updated in place?

Old SHA256: a0ae92f5cf0c16cccbc2067292396135e16477594ce026eae9120ad82769470e
Current SHA256: 99faff246f31f873166ea8f0c5e163408b9698637da1807c290cfc7a45497b5a
Download URL unchanged: http://www.rarlab.com/rar/rarosx-5.5.b5.tar.gz

I followed the instructions for repairing a bad cask  SHAsum mismatch by following the instructions for updating a cask with cask-repair but cask-repair is failing for me on Sierra. I get to the "Is everything correct?" prompt and every time I hit y it just brings me back to the prompt with an additional red dot on the screen.
link to asciicast below on asciinema

rar was updated to a beta version for a security fix, it seems to be updated in place frequently. https://github.com/caskroom/homebrew-cask/pull/36412
The cask-repair error is an open issue at https://github.com/vitorgalvao/tiny-scripts/issues/88


static analysis

update to sbt 0.13.8
add socrata-sbt-plugins
use version.sbt for sbt-release
fix some (now) fatal warnings
address style warnings and errors

ok to merge @splittingfield ?


Rewrite template for general READMEs

https://trello.com/c/Psf7EzPB/204-move-away-from-startupsh
This continues the changes from https://github.com/alphagov/govuk-developer-docs/pull/3159.

@jonathanglassman I think I've addressed all your comments (with a follow-up PR planned for one of them).
Do you think this is ready to go?
I might ask a GOV.UK dev to review as well, so we've got a couple of perspectives.

@jonathanglassman I think I've addressed all your comments (with a follow-up PR planned for one of them).
Do you think this is ready to go?
I might ask a GOV.UK dev to review as well, so we've got a couple of perspectives.

@benthorner LGTM, thanks for your time and expertise

This looks great, nice work 👍


New mapping for Mad Catz Fightpad SFxT

Hello,
A while ago, I gave a mapping for the Mad Catz Fightpad SFxT (Street Fighter x Tekken) controller.
I hadn't used mine in a while, tried it again today and noticed that some buttons were not mapped correctly (e.g. the right trigger, which is implemented as a button on the controller, is now recognized as a button and not an axis as before). I'm not sure if there have been changes in SDL2 or the kernel or whatever (I'm on Ubuntu MATE 18.10) that explains this. The buttons that changed are Start (b7 → b9), Guide (b8 → b10), Back (b6 → b8), Left Trigger (a2 → b6) and Right Trigger (a5 → b7).
Here is an updated mapping:
03000000ad1b00002ef0000090040000,Mad Catz Fightpad SFxT,a:b0,b:b1,back:b8,dpdown:h0.4,dpleft:h0.8,dpright:h0.2,dpup:h0.1,guide:b10,leftshoulder:b4,lefttrigger:b6,rightshoulder:b5,righttrigger:b7,start:b9,x:b2,y:b3,platform:Linux,

Does this follow our template? https://github.com/gabomdq/SDL_GameControllerDB/raw/master/data/mapping_guide.png

The buttons placement is similar to the Sega one on your template (with LB and LT in addition, on the side of the controller, LT being treated as a button too) but I don't really understand your question or what this template is for. Here is a photo of the same model: https://media.ldlc.com/ld/products/00/01/03/55/LD0001035519_2.jpg
Since I first contributed the mapping and now, the buttons haven't changed, except that LT and RT, while implemented physically as buttons, were still seen as axis by SDL. Now they're seen as buttons and have taken the place of others in the order, so some have been "shifted". I just took the old line from the DB on GitHub and replaced the wrong values by the correct ones, if that's what you're asking.

What I'm asking is, do your changes follow the template. Are the 'Z' and 'C' buttons mapped to 'RB' and 'RT'? Please open a PR to discuss your change.

Errr... sorry but I'm completely lost in GitHub. If I do a pull request, it asks me to compare branches (?). Do I choose to compare master and buttons, then leave a comment with the new mapping? When I compare these two, all the mappings in the db that appears show as empty (they have the list of buttons with nothing set).

It seems my reply didn't go through. Sorry for the delay.
You want to merge into our master SDL_GameControllerDB/master from your master terzag/master. Buttons is an old prototype branch.
Feel free to make mistakes, you can always close and reopen your pull request. If there are issues I will point them out. cheers

Oh, there might be a small misunderstanding there: I don't have a "clone" (or "fork", or whatever is the right term) of you repo, I just looked at your gamecontrollerdb.txt, copied the line (313) and opened the bug report with the new buttons values.

Well you will need to fork the repo if you want to send a PR to fix your issue.


[update] use JAVA_HOME to exec java

Pull Request Test Coverage Report for Build 4619

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 38.788%

Totals

Change from base Build 4616:
0.01%

Covered Lines:
11461

Relevant Lines:
29548

💛  - Coveralls

@ilibx can you share more details in your PR description?

@burgerkingeater for what?

@burgerkingeater merge one commit need PR ?

@ilibx can you provide the reason why you need those changes? Changing product code to accommodate testing is not a good idea to begin with.

@djaiswal83 i want manage it with ambari, but it can not be started by default as the java env, so i change the start cmd


Iterating values(::ProductSector) fails if getindex is not defined for one of the factors

Because of the implementation here, iteration now fails for sectors that did not define a getindex (sector types that don't easily have a linear order).
I bumped into this while attempting to update SUNRepresentations, where this is the case.
While I could attempt to figure out a linear order for SUNIrrep (which is probably doable with the same manhattan indexing used for product sectors), we should either update our interface to reflect that this is required, or provide an alternative way of iterating.
Additionally, this is not covered in our testcases, since the newsector we define does provide an implementation for getindex and findindex.

I also agree that the slow fallback was what I was leaning towards. I'd say it's just a matter of having a nice way to have a fallback when required, and that should do the trick. Your suggestion (or almost the same) is also what I would come up with, so that is probably fair


Code Standards: Use long-form array syntax when declaring arrays

Is your enhancement related to a problem? Please describe.
As per the WordPress PHP Coding Standards, arrays should be declared using array() syntax. If we're following these standards, we should identify any instances where we're declaring arrays using shorthand syntax and convert them to the long-form version.
Designs
No response
Describe alternatives you've considered
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@roseg43 why long form syntax? It's common to use the short form array syntax in JavaScript. I'd say being able to use the same syntax across languages to accomplish similar things makes things more accessible. All this to say, please let me keep my brackets 🤣

@smithtimmytim 😆 It's because scaffold uses the 10up - Default phpcs ruleset via https://github.com/10up/phpcs-composer. This ruleset extends https://github.com/WordPress/WordPress-Coding-Standards, and the WPCS states:

Using long array syntax ( array( 1, 2, 3 ) ) for declaring arrays is generally more readable than short array syntax ( [ 1, 2, 3 ] > ), particularly for those with vision difficulties. Additionally, it’s much more descriptive for beginners.
Arrays must be declared using long array syntax.

I linked the rule in the issue description if you want to explore more!

@roseg43 the 10up-wp-scaffold uses 10up-default PHP coding standards which extends WordPress core standards and allows short array syntax.
See: https://github.com/10up/phpcs-composer/blob/master/10up-Default/ruleset.xml#L61

I'm going to close this issue.
Whilst Core still requires the long array syntax, the 10up PHPCS rules specifically allow the short array syntax.
https://github.com/10up/phpcs-composer/blob/2d03ba19ad5259275aa4f2287340e3d7d270196b/10up-Default/ruleset.xml#L72-L73
I feel that most engineers now lean towards using the short array syntax, so changing that seems like it will add a bunch of overhead for no real gain.


Add info about cycles and serialization

@divega @ajcvickers could one of you take a look at this

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Pr/393

Description

Test Steps

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thank


Error!Connect bitpay

Fatal Error: The BitPay payment extension was not installed correctly or the files are corrupt. Please reinstall the extension. If this message persists after a reinstall, contact<EMAIL_ADDRESS>with this message. in /alidata/www/phpwind/myshop/vqmod/vqcache/vq2-system_library_bitpay.php on line 34
Fatal error: Uncaught Error: Class 'Bitpay\PrivateKey' not found in /alidata/www/phpwind/myshop/vqmod/vqcache/vq2-system_library_bitpay.php:134 Stack trace: #0 /alidata/www/phpwind/myshop/vqmod/vqcache/vq2-system_library_bitpay.php(66): Bitpay->generateId() #1 /alidata/www/phpwind/myshop/admin/controller/extension/payment/bitpay.php(333): Bitpay->getPairingUrl() #2 /alidata/www/phpwind/myshop/vqmod/vqcache/vq2-system_storage_modification_system_engine_action.php(79): ControllerExtensionPaymentBitpay->connect() #3 /alidata/www/phpwind/myshop/admin/controller/startup/router.php(26): Action->execute(Object(Registry), Array) #4 /alidata/www/phpwind/myshop/vqmod/vqcache/vq2-system_storage_modification_system_engine_action.php(79): ControllerStartupRouter->index() #5 /alidata/www/phpwind/myshop/system/engine/router.php(67): Action->execute(Object(Registry)) #6 /alidata/www/phpwind/myshop/system/engine/router.php(56): Router->execute(Object(Action)) #7 /alidata/www/phpwind/myshop/system/framework.php(188): Router->dispatch(Objec in /alidata/www/phpwind/myshop/vqmod/vqcache/vq2-system_library_bitpay.php on line 134

I am new to the installation. After reviewing the install function. My question is do I need to manually create a private key?

The issue is related to using VqMod.
Quick fix is to disable VqMod.
We are looking to fix the issue in the BitPay plugin, but I can't provide a timeline yet.

Fixed in release v2.2.1


Remove error notifications from NavigationFragment

Description
MA-2967
Since the navigation drawer usually isn't being displayed, it doesn’t make sense to have it show error notifications to the user. Even when the drawer is open and on display, there's no appropriate area to show a data loading error that’s associated with it. Therefore, this pull request removes the Snackbar error notification logic from calls made by NavigationFragment.
Note that the drawer was also added automatically to many Activities where it wasn’t even used, and was always blocked from opening, and where cases showing an error was completely inappropriate. This was because the default layout of the BaseSingleFragmentActivity included the drawer’s layout, and subclasses that didn’t support it (which were the majority) blocked it on a case-by-case basis.
Reviewers
If you've been tagged for review, please "Start a review" with the GitHub GUI.

Code review: @miankhalid, @BenjiLee

Current coverage is 18.97% (diff: 100%)

Merging #876 into master will not change coverage

@@             master       #876   diff @@
==========================================
  Files           470        470
  Lines         19969      19969
  Methods           0          0
  Messages          0          0
  Branches       2920       2920
==========================================
  Hits           3790       3790
  Misses        15728      15728
  Partials        451        451

Powered by Codecov. Last update d21f65e...465705c

Overlay message 'You are not connected to the Internet. Please check your Internet connection' is still appearing on Edit Profile & Discussion Topics, Threads, Responses and Comments screens

As I commented on the ticket, I don't see an issue with the error being shown in those screens, since they do load data from the server.

(and don't go away even when a user is back online)

This is a different issue that isn't mentioned in the ticket, and doesn't seem to be a release blocker. I'll try to address it by adding a refresh button in #866.

Point # 2 is still not addressed: In online mode on comment screen when user tap on report button twice or thrice app shows overlay of internet 'Connection error. Please check your Internet connection' .

I forgot about this point, but I can't reproduce this now. I'll add a comment on the ticket to that effect.

As I commented on the ticket, I don't see an issue with the error being shown in those screens, since they do load data from the server.

Ok, lets see what Mubashar says about that.

I can't reproduce this now. I'll add a comment on the ticket to that effect.

It quite easy to reproduce, just tap on report for a comment and before the response arrives tap on report of another comment. Just requires quick tapping.

It quite easy to reproduce, just tap on report for a comment and before the response arrives tap on report of another comment.

I managed to reproduce the issue by following these instructions, thanks! It seems that any report action would cause any previous ongoing report calls to be cancelled, and since OkHttp throws an IOException in the case of cancellation, this was being interpreted and displayed as a network error. I have fixed the former issue in commit 4f655319065a846f5c29a2935d3325f3a1bfd838 (and opened MA-3004 for a more proper and global fix), and the latter in commit 8d69d2206d90178fe8a2ba9d1b592ae550fef07b.


Question: Adding to SublimeText

This is awesome, finally a lint for Cython!!!
How to go about making this work with SublimeText?

thanks! what do I need to do for that?

@MarcoGorelli http://www.sublimelinter.com/en/master/index.html

@MarcoGorelli https://github.com/SublimeLinter/SublimeLinter/discussions/1925

not sure what I have to do here, but I'd take a PR if you wanted to make one if anything needs to change on cython-lint's side

closing then, but feel to make a PR either here or to sublime, happy to help out if needed


JSON access-log output does not consider TeeFilter for requestContent

Hi everybody,
I am using dropwizard-json-logging library and noticed that when using "requestContent" in the includes section of the "JSON access-log" layout that the requestContent is directly printed out without further processing. Without the usage of the layout option the the TeeFilter (https://logback.qos.ch/manual/layouts.html#AccessPatternLayout) would be considered for printing out the request content.
Because of this difference in behavior I think it is a bug and it would be great if the TeeFilter could also be considered if using the JSON access-log layout
Best
Andy

For my own understanding, let me know how far off I am interpreting your question.

When given the dropwizard config that uses json logging and includes requestContent

server:
  requestLog:
    appenders:
     - type: console
       layout:
         type: access-json
         includes:
           - statusCode
           - requestContent

One would expect that the request content is logged to the console
Instead the content is always "" (verified this), as the content stream will be consumed to deserialize the body
A workaround is to register a TeeFilter in one's application (which buffers the entire contents)

@Override
public void run(Configuration config, Environment env) throws Exception {
    env.servlets().addFilter("tee", new TeeFilter())
        .addMappingForUrlPatterns(EnumSet.allOf(DispatcherType.class), true, "/*");
}

You are suggesting that Dropwizard should automatically register a TeeFilter-like structure whenever json access logging is enabled and prints the request contents

If the last bullet point is true then yes this would be a feature request

Thank you for your response and sorry for not beeing precise enough.

When given the dropwizard config that uses json logging and includes requestContent
One would expect that the request content is logged to the console
Instead the content is always "" (verified this), as the content stream will be consumed to deserialize the body

No this is not my point and it is not the case. When using your dropwizard config, the requestContent is printent to std-out. However, it is directly printed to std-out without consideration of any configured TeeFilter. This behavior is different if you use the regular request log such as:
server:
  requestLog:
    appenders:
      - type: console
        logFormat: '"requestContent":{%requestContent}'

When using this dropwizard configuration any configured TeeFilter is considered for printing the requestContent to std-out. This behavior is also documented in here https://logback.qos.ch/manual/layouts.html#AccessPatternLayout under the requestContent variable.
A particular use case where I use the TeeFilter configuration is to stip away confidential data embedded in the requests content, when logging the request.
To be clear I do not suggest any behavioral change for registering the TeeFilter. I just want to point out that the TeeFilter is considered for printing and modifying the request content in case of the regular request access log, but not considered if the access-json is used as layout option.
Best regards
Andy

Ok I think I'm catching on. Can you give an example of a TeeFilter modifying contents so that I can play with it on my end?

Sure:
public class ExtendedTeeFilter extends TeeFilter {
    @Override
    public void doFilter(ServletRequest request, ServletResponse response, FilterChain filterChain) throws IOException, ServletException {
        super.doFilter(request, response, filterChain);
        request.setAttribute(AccessConstants.LB_INPUT_BUFFER, "this is a test".getBytes(UTF_8));
    }
}

Make also sure to register in the Dropwizard run method via
environment.servlets().addFilter("teeFilter", ExtendedTeeFilter.class).addMappingForUrlPatterns(null, false, "/*");

Strangely enough, I can't replicate this with your example. The json access-log takes into account the modified contents.
With the config I posted earlier, I see
{"requestContent":"this is a test","status":200}

in the logs

Let me know the current status of this, else I will close this issue.


console.log in .min.js

I think someone forgot a console.log in .min.js https://github.com/daniel-nagy/md-data-table/tree/v0.8.14 and master
It can be found after this line, but its only present on the minified version
https://github.com/daniel-nagy/md-data-table/blob/master/dist/md-data-table.js#L126

I was just about to open a issue for that ! It's showing up when testing which is pretty annoying

:+1:

I also noticed this.
I am successfully using the following override in my bower.json to avoid seeing the console.log.
"overrides": {
    "angular-material-data-table": {
      "main": [
        "dist/md-data-table.js",
        "dist/md-data-table.min.css"
      ]
    }
  }

Who is planning to fix this? :see_no_evil:

It is a little annoying. Would love to see it go away.

+1

@daniel-nagy plz?

This issue has been open for over 18 months.  Is there any plan to fix it?


Spell Library GUI doesn't show up on Divine Journey 2 Server

General Information
Describe the bug:

Spell Library GUI doesn't show up when pressing the keybind on servers although the server recognizes the key is being pressed
Server host and client both experience issue

To Reproduce:
Log in to a roots (3.1.7) supporting server and press the spell library keybind while holding a staff
Nothing shows up

Environment Versions
Encountered while running roots 3.1.7
Mystic Mods Versions

MysticalWorld v1.11.0
MysticalLib:1.13

Other Versions:

Forge: <IP_ADDRESS>60
Minecraft: 1.12.2

Additional Information
-Changing keybind doesn't fix the issue
-The issue isn't in the server recognizing the input as not holding the staff prompts a message stating you need a wand to access the spell library

Downgrading to Version 3.1.6 fixes the issue
Upgrading to Version 3.1.8 does not fix the issue.

same, shows up an error:
[16:08:32] [Client thread/FATAL] [minecraft/Minecraft]: Error executing task java.util.concurrent.ExecutionException: java.lang.NullPointerException 	at java.util.concurrent.FutureTask.report(FutureTask.java:122) ~[?:1.8.0_392] 	at java.util.concurrent.FutureTask.get(FutureTask.java:192) ~[?:1.8.0_392] 	at net.minecraft.util.Util.runTask(SourceFile:531) [h.class:?] 	at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1088) [bib.class:?] 	at net.minecraft.client.Minecraft.run(Minecraft.java:3942) [bib.class:?] 	at net.minecraft.client.main.Main.main(SourceFile:123) [Main.class:?] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_392] 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_392] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_392] 	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_392] 	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?] 	at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?] 	at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:87) [NewLaunch.jar:?] 	at org.prismlauncher.EntryPoint.listen(EntryPoint.java:130) [NewLaunch.jar:?] 	at org.prismlauncher.EntryPoint.main(EntryPoint.java:70) [NewLaunch.jar:?] Caused by: java.lang.NullPointerException 	at epicsquid.roots.world.data.UUIDRegistry.getDataInternal(UUIDRegistry.java:25) ~[UUIDRegistry.class:?] 	at epicsquid.roots.world.data.SpellLibraryRegistry.getData(SpellLibraryRegistry.java:15) ~[SpellLibraryRegistry.class:?] 	at epicsquid.roots.world.data.SpellLibraryRegistry.getData(SpellLibraryRegistry.java:19) ~[SpellLibraryRegistry.class:?] 	at epicsquid.roots.GuiHandler.getClientGuiElement(GuiHandler.java:127) ~[GuiHandler.class:?] 	at net.minecraftforge.fml.common.network.NetworkRegistry.getLocalGuiContainer(NetworkRegistry.java:276) ~[NetworkRegistry.class:?] 	at net.minecraftforge.fml.common.network.internal.FMLNetworkHandler.openGui(FMLNetworkHandler.java:111) ~[FMLNetworkHandler.class:?] 	at net.minecraft.entity.player.EntityPlayer.openGui(EntityPlayer.java:2550) ~[aed.class:?] 	at net.minecraftforge.fml.common.network.internal.OpenGuiHandler.process(OpenGuiHandler.java:50) ~[OpenGuiHandler.class:?] 	at net.minecraftforge.fml.common.network.internal.OpenGuiHandler.lambda$channelRead0$0(OpenGuiHandler.java:43) ~[OpenGuiHandler.class:?] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_392] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_392] 	at net.minecraft.util.Util.runTask(SourceFile:529) ~[h.class:?] 	... 12 more

So problem are in UUIDRegistry#getDataInternal(), probably beacuse gui are client-side, while MapStorage are server side, easiest workaround is to just change:
if (storage == null) {  	throw new NullPointerException("Map storage is null"); }
to:
if (storage == null) { 	return null; }
but, its definetly not the best way, but works for me, no desyncs or any other troubles.


Imbed Google Maps

If there is time and feasibility, imbed google map widget for goof panties and community fridges


Pages module

First of, thanks for sharing your work, it looks amazing!
I am trying to create a pages module, but I am not sure how to go about it.
Documentation states that 'Pages are unstructured data models most often used for static content, such as an About page [...]', which I understand should not be prefixed with 'pages'. I also don't know how to arrange it in page/subpage/... convention. Do you maybe have any more detailed docs about it?
I will also need pages to have different page templates with different fields. I read #54 and will try to implement it somehow, but I would appreciate if you have any ideas how to do that or where to start?
Also related: is it/or would be possible to implement a sort of addons system. For example a 'pages' addon that would scaffold all of this (tree structure, templates, ...) and leave user to populate template' fields, because it seems like something that a lot of projects requiring CMS would actually need.
Thanks for your help!

Thank you @noxify the gists works perfectly! Now, I just need to figure how to make block(s) not flexible (so I don't need to have pages table with 50 columns) and I have everything :)
Your solutions for pages prefix doesn't work in my case, but I might need to try again, as there was no change after implementing either or both of those ($indexOptions, $permalinkBase).
Thanks again for your help, you are awesome! 👍

Has anyone used this nested module stuff? Is there a way to get nested slugs?
F.e. i have the following items:

Item A - Nesting Depth 1

Item B - Nesting Depth 2

And now i want to have the slug /en/item-a/item-b) for the Item B and /en/item-a for the Item A.
Did anyone do this? Maybe someone could help?

Has anyone used this nested module stuff? Is there a way to get nested slugs?
F.e. i have the following items:

Item A - Nesting Depth 1

Item B - Nesting Depth 2

And now i want to have the slug /en/item-a/item-b) for the Item B and /en/item-a for the Item A.
Did anyone do this? Maybe someone could help?

Have you solved this yet?

Has anyone used this nested module stuff? Is there a way to get nested slugs?
F.e. i have the following items:

Item A - Nesting Depth 1

Item B - Nesting Depth 2

And now i want to have the slug /en/item-a/item-b) for the Item B and /en/item-a for the Item A.
Did anyone do this? Maybe someone could help?

Have you solved this yet?

Have you solved this yet?

Has anyone used this nested module stuff? Is there a way to get nested slugs?
F.e. i have the following items:

Item A - Nesting Depth 1

Item B - Nesting Depth 2

And now i want to have the slug /en/item-a/item-b) for the Item B and /en/item-a for the Item A.
Did anyone do this? Maybe someone could help?

Have you solved this yet?

Have you solved this yet?

Some time has passed; not sure if anyone else has any input on how to get the nested slugs to work?

Personally I think this is the killer feature missing in Twill. I know there are workarounds but from my experience it's not perfect (see here: https://spectrum.chat/twill/general/subpage-permalinks~e3c1932b-6a6c-4221-a5a9-70e6b99bf96d). I think there should be native support for multi-level pages and dynamic permalinks built in to Twill.
Often clients just want a quick and straightforward way of adding pages in a parent-child hierarchy, and therefore I tend to lean towards WordPress for that.
Can we expect to have this feature anytime soon?

Hi @ifox is this page nesting feature now available? Could you please provide steps to prepare nested pages for frontend?


Finish content resolvers for CraftCMS

Finish content resolvers for CraftCMS for the folllowing content field types:

[ ] image
[ ] audio
[ ] video
[ ] document
[ ] relation
[ ] relation array
[ ] taxonomy terms

Closing since strict content model removed from 0.8.*


The model building convention code for mitigating the trigger breaking change adds HasTrigger to all tables

The model building convention code for mitigating the trigger breaking change does not work for me, specifically:
entityType.GetDeclaredTriggers()
Always returns an empty list even for tables that have a trigger and in any case, calling All on an empty list returns true, so you end up adding the HasTrigger to every table whether they have a trigger or not.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f1b683ae-c697-ebc8-d0aa-648d7573136e
Version Independent ID: f1b683ae-c697-ebc8-d0aa-648d7573136e
Content: Breaking changes in EF Core 7.0 (EF7) - EF Core
Content Source: entity-framework/core/what-is-new/ef-core-7.0/breaking-changes.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @ajcvickers
Microsoft Alias: avickers

It's not entirely clear what this code example is doing. Does GetDeclaredTriggers() check the actual database for triggers? It returns null on all of my entities even though I do have triggers attached. If it's just returning information from the DbContext then why do I also has to HasTrigger to tell the model something it already knows?

GetDeclaredTrigger() does not check the database for triggers - it only checks the EF model for triggers which have previously been configured on the entity's table. The point here is to add a trigger configuration to tables that haven't been configured with one.

calling All on an empty list returns true, so you end up adding the HasTrigger to every table whether they have a trigger or not

I am not seeing that happening: for a table that already has a trigger configuration in OnModelCreating, the convention doesn't add a second one. If a trigger is already configured on a table and has a name (that's the GetDatabaseName check), the convention skips it.

GetDeclaredTrigger() ... checks the EF model for triggers which have previously been configured on the entity's table. The point here is to add a trigger configuration to tables that haven't been configured with one.

Sorry, I'm obviously missing a crucial detail here that makes that sentence make sense. That sounds like a chicken and egg situation. We want to inform EF about triggers that it doesn't know about, so we do that by asking EF for the triggers we're trying to tell it about?

See here for further explanation.
The example is not explained clearly enough IMO and causes confusion (given the preceding context about only calling HasTrigger for specific tables). But it is doing what it says once you know its intended purpose. Therefore this issue can be closed. Ideally, someone can add some clarifying text to the page to avoid anyone else wasting time on it.


The Slang Programming Language (formerly known as ObjectiveScript)

https://github.com/slang-lang/slang

Reopen to close as completed. The language is currently in the transition from ObjectiveScript to Slang. Let it alone. Maybe someday someone will submit a ticket about adding it when the transition is completed. But now I think it shouldn't be added.

He said it's production ready: https://github.com/slang-lang/slang/issues/4#issuecomment-1293209553

Thanks!


Linux vendor updates

Deletion check failed because a previously malformed file snuck in and got taken out:
0s
Run cloudsecurityalliance/gsd-tools/actions/deletion-check@main
Run $GITHUB_ACTION_PATH/check.sh
removed files
2015/GSD-2015-.json
You shall not change history.
Error: Process completed with exit code 1.