HADOOP-16830. Add public IOStatistics API.

Hadoop-common side of the patch

API definition
interface
tests
implementation
wiring up of the IO core classes

hadoop common part of #2069 : API and impl,
While this is isolated for review, know that I'll be doing my changes on #2324 and cherry-picking here. It's just isolated for ease of review/to scare people less.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
markdownlint
0m  1s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 10 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
30m 45s
trunk passed

+1 :green_heart:
compile
21m 32s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
19m 19s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
0m 59s
trunk passed

+1 :green_heart:
mvnsite
1m 45s
trunk passed

+1 :green_heart:
shadedclient
20m 24s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 34s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m 38s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
2m 45s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 42s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  2s
the patch passed

-1 :x:
compile
22m  3s
root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

-1 :x:
javac
22m  3s
root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

-1 :x:
compile
19m 42s
root in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.

-1 :x:
javac
19m 42s
root in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.

-0 :warning:
checkstyle
0m 53s
hadoop-common-project/hadoop-common: The patch generated 17 new + 142 unchanged - 4 fixed = 159 total (was 146)

+1 :green_heart:
mvnsite
1m 31s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
16m 50s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 34s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

-1 :x:
javadoc
1m 40s
hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)

-1 :x:
findbugs
2m 50s
hadoop-common-project/hadoop-common generated 8 new + 0 unchanged - 0 fixed = 8 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
10m  5s
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 55s
The patch does not generate ASF License warnings.

180m 35s

Reason
Tests

FindBugs
module:hadoop-common-project/hadoop-common

Inconsistent synchronization of org.apache.hadoop.fs.statistics.IOStatisticsSnapshot.counters; locked 60% of time  Unsynchronized access at IOStatisticsSnapshot.java:60% of time  Unsynchronized access at IOStatisticsSnapshot.java:[line 183]

Inconsistent synchronization of org.apache.hadoop.fs.statistics.IOStatisticsSnapshot.gauges; locked 60% of time  Unsynchronized access at IOStatisticsSnapshot.java:60% of time  Unsynchronized access at IOStatisticsSnapshot.java:[line 188]

Inconsistent synchronization of org.apache.hadoop.fs.statistics.IOStatisticsSnapshot.maximums; locked 60% of time  Unsynchronized access at IOStatisticsSnapshot.java:60% of time  Unsynchronized access at IOStatisticsSnapshot.java:[line 198]

Inconsistent synchronization of org.apache.hadoop.fs.statistics.IOStatisticsSnapshot.meanStatistics; locked 60% of time  Unsynchronized access at IOStatisticsSnapshot.java:60% of time  Unsynchronized access at IOStatisticsSnapshot.java:[line 203]

Inconsistent synchronization of org.apache.hadoop.fs.statistics.IOStatisticsSnapshot.minimums; locked 60% of time  Unsynchronized access at IOStatisticsSnapshot.java:60% of time  Unsynchronized access at IOStatisticsSnapshot.java:[line 117]

org.apache.hadoop.fs.statistics.IOStatisticsSnapshot's readObject method is synchronized  At IOStatisticsSnapshot.java: At IOStatisticsSnapshot.java:[lines 241-254]

Inconsistent synchronization of org.apache.hadoop.fs.statistics.MeanStatistic.samples; locked 93% of time  Unsynchronized access at MeanStatistic.java:93% of time  Unsynchronized access at MeanStatistic.java:[line 261]

Inconsistent synchronization of org.apache.hadoop.fs.statistics.MeanStatistic.sum; locked 91% of time  Unsynchronized access at MeanStatistic.java:91% of time  Unsynchronized access at MeanStatistic.java:[line 261]

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2323

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux c43559ab4697 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c8c1cc43d35

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

compile
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/1/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

javac
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/1/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

compile
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/1/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt

javac
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/1/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/1/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/1/artifact/out/diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt

findbugs
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/1/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/1/testReport/

Max. process+thread count
2630 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

I see the problem. This PR only includes the common changes, but as that moved some fs.impl methods to being public in a new package, the uses in the s3 code won't build.
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  19:15 min
[INFO] Finished at: 2020-09-21T20:50:29Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project hadoop-aws: Compilation failure: Compilation failure:
[ERROR] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/DynamoDBMetadataStore.java:[82,32] error: cannot find symbol
[ERROR] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/DynamoDBMetadataStore.java:[1637,25] error: package FunctionsRaisingIOE does not exist
[ERROR] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/DynamoDBMetadataStore.java:[1638,10] error: lambda expression not expected here
[ERROR] -> [Help 1]
[ERROR]

Briefly I will reinstate the delete class from fs.impl so everything builds again

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  7s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
markdownlint
0m  1s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 10 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
31m 35s
trunk passed

+1 :green_heart:
compile
21m  3s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
17m 53s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
0m 48s
trunk passed

+1 :green_heart:
mvnsite
1m 23s
trunk passed

+1 :green_heart:
shadedclient
18m 32s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 30s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m 27s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
2m 17s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 14s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 51s
the patch passed

+1 :green_heart:
compile
20m 12s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

-1 :x:
javac
20m 12s
root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 20 new + 2054 unchanged - 0 fixed = 2074 total (was 2054)

+1 :green_heart:
compile
17m 44s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

-1 :x:
javac
17m 44s
root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 20 new + 1950 unchanged - 0 fixed = 1970 total (was 1950)

-0 :warning:
checkstyle
0m 48s
hadoop-common-project/hadoop-common: The patch generated 20 new + 141 unchanged - 4 fixed = 161 total (was 145)

+1 :green_heart:
mvnsite
1m 24s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
15m 52s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 29s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

-1 :x:
javadoc
1m 27s
hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)

-1 :x:
findbugs
2m 24s
hadoop-common-project/hadoop-common generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
10m 15s
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 47s
The patch does not generate ASF License warnings.

171m  3s

Reason
Tests

FindBugs
module:hadoop-common-project/hadoop-common

Inconsistent synchronization of org.apache.hadoop.fs.statistics.IOStatisticsSnapshot.counters; locked 80% of time  Unsynchronized access at IOStatisticsSnapshot.java:80% of time  Unsynchronized access at IOStatisticsSnapshot.java:[line 115]

Inconsistent synchronization of org.apache.hadoop.fs.statistics.IOStatisticsSnapshot.gauges; locked 80% of time  Unsynchronized access at IOStatisticsSnapshot.java:80% of time  Unsynchronized access at IOStatisticsSnapshot.java:[line 116]

Inconsistent synchronization of org.apache.hadoop.fs.statistics.IOStatisticsSnapshot.maximums; locked 80% of time  Unsynchronized access at IOStatisticsSnapshot.java:80% of time  Unsynchronized access at IOStatisticsSnapshot.java:[line 118]

Inconsistent synchronization of org.apache.hadoop.fs.statistics.IOStatisticsSnapshot.meanStatistics; locked 80% of time  Unsynchronized access at IOStatisticsSnapshot.java:80% of time  Unsynchronized access at IOStatisticsSnapshot.java:[line 119]

Inconsistent synchronization of org.apache.hadoop.fs.statistics.IOStatisticsSnapshot.minimums; locked 80% of time  Unsynchronized access at IOStatisticsSnapshot.java:80% of time  Unsynchronized access at IOStatisticsSnapshot.java:[line 117]

org.apache.hadoop.fs.statistics.IOStatisticsSnapshot's readObject method is synchronized  At IOStatisticsSnapshot.java: At IOStatisticsSnapshot.java:[lines 241-254]

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2323

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux 0de6be7071fb 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6b5d9e2334b

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

javac
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/2/artifact/out/diff-compile-javac-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

javac
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/2/artifact/out/diff-compile-javac-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/2/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/2/artifact/out/diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt

findbugs
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/2/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/2/testReport/

Max. process+thread count
3223 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/2/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  4s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  2s

No case conflicting files found.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 10 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
29m  3s

trunk passed

+1 :green_heart:
compile
19m 28s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
16m 49s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
0m 57s

trunk passed

+1 :green_heart:
mvnsite
1m 28s

trunk passed

+1 :green_heart:
shadedclient
17m  5s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 39s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m 36s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
2m 17s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 15s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 52s

the patch passed

+1 :green_heart:
compile
18m 46s

the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

-1 :x:
javac
18m 46s
/diff-compile-javac-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 20 new + 2055 unchanged - 0 fixed = 2075 total (was 2055)

+1 :green_heart:
compile
16m 52s

the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

-1 :x:
javac
16m 52s
/diff-compile-javac-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt
root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 20 new + 1948 unchanged - 0 fixed = 1968 total (was 1948)

-0 :warning:
checkstyle
0m 55s
/diff-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 4 new + 141 unchanged - 4 fixed = 145 total (was 145)

+1 :green_heart:
mvnsite
1m 26s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m 11s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 38s

the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m 35s

the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

-1 :x:
findbugs
2m 24s
/new-findbugs-hadoop-common-project_hadoop-common.html
hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
10m  5s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 54s

The patch does not generate ASF License warnings.

161m 46s

Reason
Tests

FindBugs
module:hadoop-common-project/hadoop-common

org.apache.hadoop.fs.statistics.IOStatisticsSnapshot's readObject method is synchronized  At IOStatisticsSnapshot.java: At IOStatisticsSnapshot.java:[lines 241-254]

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2323

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux c96eef23ca40 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 18f9d77c46f

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/3/testReport/

Max. process+thread count
2467 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/3/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

findbugs
module:hadoop-common-project/hadoop-common
--
  | org.apache.hadoop.fs.statistics.IOStatisticsSnapshot's readObject method is synchronized At IOStatisticsSnapshot.java: At IOStatisticsSnapshot.java:[lines 241-254]

The synchronized was lifted from TreeMap writeObject. When I turn it off I'll be reasonably confident that findbugs will start complaining about unsynchronized accesses to field. Let's see. If it blows up then I'll just disable the check here
checkstyles are on the uses of the now deprecated methods; will move them on
[WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/CallableSupplier.java:[34,32] [deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been deprecated
[WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/DynamoDBMetadataStore.java:[82,32] [deprecation] FunctionsRaisingIOE in org.apache.hadoop.fs.impl has been deprecated
[WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/DynamoDBMetadataStore.java:[83,32] [deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been deprecated
[WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/RetryingCollection.java:[24,32] [deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been deprecated
[WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/CallableSupplier.java:[68,16] [deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been deprecated
[WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java:[436,51] [deprecation] FAST_UPLOAD in Constants has been deprecated
[WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/DynamoDBMetadataStore.java:[829,13] [deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been deprecated
[WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/DynamoDBMetadataStore.java:[1637,6] [deprecation] FunctionsRaisingIOE in org.apache.hadoop.fs.impl has been deprecated
[WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/DynamoDBMetadataStore.java:[1637,25] [deprecation] CallableRaisingIOE in FunctionsRaisingIOE has been deprecated
[WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/RetryingCollection.java:[103,18] [deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been deprecated
[WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/RetryingCollection.java:[121,18] [deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been deprecated
[WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/select/ITestS3SelectMRJob.java:[33,32] [deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been deprecated
[WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ILoadTestS3ABulkDeleteThrottling.java:[48,32] [deprecation] FunctionsRaisingIOE in org.apache.hadoop.fs.impl has been deprecated
[WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ILoadTestS3ABulkDeleteThrottling.java:[49,32] [deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been deprecated
[WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/ITestDynamoDBMetadataStoreScale.java:[52,32] [deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been deprecated
[WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/select/ITestS3SelectMRJob.java:[212,22] [deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been deprecated
[WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ILoadTestS3ABulkDeleteThrottling.java:[320,21] [deprecation] FunctionsRaisingIOE in org.apache.hadoop.fs.impl has been deprecated
[WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ILoadTestS3ABulkDeleteThrottling.java:[320,40] [deprecation] CallableRaisingIOE in FunctionsRaisingIOE has been deprecated
[WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ILoadTestS3ABulkDeleteThrottling.java:[324,16] [deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been deprecated
[WARNING] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/ITestDynamoDBMetadataStoreScale.java:[535,13] [deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been deprecated

For DurationTrackers in IOStatisticsStore() if we add a tracker in a try block, what happens to it in case of failure should be looked at to avoid inaccurate values for the trackers.

I was thinking about failure reporting myself

we may want to count failures
any failure which with a longer or shorter duration than successful operations Will skew the results. Example: network failures -> long durations; auth failures -> short ones.

At the same time, try-with-resources is nice. What to do?
For each set of duration stats, we add counter/mean/min/max of failures
on a failure, those statistics are updated instead.
Issue: how best to record a failure, given we can't get at the try-with-resources classes in catch or finally? I'd initially thought we could set it in the catch(), but it'd be out of scope.

Pessimistic: assume that all attempts are failure, make last operation in every try clause set the success flag. Ugly.
Move construction out of try-with-resources and instead explicit catch and finally.  Doable.
object = DurationTrackerFactory.track("statistic", () ->
  s3.listObjects());

Then in that code we'd put the code of option #2 in
Fancy curried-function-Haskell-elitism option
Duration tracker takes a function and returns a new one
FunctionRaisingIOE<A, B> track(String, FunctionRaisingIOE<A, B> inner)

you'd get a function back which you could then apply at leisure.
DurationTrackerFactory.track("statistic", () ->
  s3.listObjects()).apply();

Maybe worth doing both. I could also look at adding into the S3A Invoke code, as every iteration of a retried operation we'd want the statistic updated.

At the same time: this gets complex fast. Could we make the design of this a followup?

Update: you will get the ability to wrap a Callable, CallableRaisingIOE or functionRaisingIOE with a duration tracking, which then returns a new instance of the same
submit(unboundedThreadPool,
          trackDurationOfCallable(
              listingContext.getDurationTrackerFactory(),
              OBJECT_LIST_REQUEST,
              () -> listObjects(request)));

When there's a failure we update the failure count, move timings into the failures section. Attempts are counted for both, so success == attempts - failures.

error. This is solved when I add ".mean" at the end of the DurationTracker stat name. The same with Max(".max" has to be added) and Min(".min" has to be added) to fetch their values.
Was thinking if we could add it to the getter rather than having to append with stat name.

I'm a bit reluctant to, as then people would ask about failures next. What could be handy would be something in the support class to get all stats for a duration (or null), with some struct to contain them all. e.g
fetchDurationStatistics(IOStatistics, key) -> {count, min, max ,mean, failed, failed.min, failed.max, failed.mean), and you'd then work off that. Seem good?
Troublespot: what if only some of the values were found? they'd be null in the result. Maybe we'd let you ask for the success/failure stats separately, deal with it that way, and have some boolean isComplete() probe to check all are set

In IOStatisticsBinding class we have methods for tracking duration but, I am not able to wrap it around a normal function.
There are 3 methods for tracking durations which are for Callable, CallableRaisingIOE, and FunctionRaisingIOE<A, B>. We should add 1 more for a normal function too.

@mehakmeet

duration tracking for classic function. Issue: are the names of the trackDuration calls correct now?
class DurationStatisticSummary to store and extract duration stats from a statistic.
which is used in the tests to verify that the new functions all work

Yetus: javac is all about the deprecation changes fixed in #2324
checkstyles from new tests & code
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/FunctionsRaisingIOE.java:41:   * @deprecated use {@link org.apache.hadoop.util.functional.FunctionRaisingIOE}: Line is longer than 80 characters (found 81). [LineLength]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/FunctionsRaisingIOE.java:54:   * @deprecated use {@link org.apache.hadoop.util.functional.BiFunctionRaisingIOE}: Line is longer than 80 characters (found 83). [LineLength]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/FunctionsRaisingIOE.java:65:   * @deprecated use {@link org.apache.hadoop.util.functional.CallableRaisingIOE}: Line is longer than 80 characters (found 81). [LineLength]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/statistics/BufferedIOStatisticsInputStream.java:51:  /**: First sentence should end with a period. [JavadocStyle]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/statistics/package-info.java:28: * {@link org.apache.hadoop.fs.statistics.IOStatisticsSource#getIOStatistics()} .: Line is longer than 80 characters (found 81). [LineLength]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/functional/RemoteIterators.java:412:    /**: First sentence should end with a period. [JavadocStyle]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/statistics/TestDurationTracking.java:112:        (Integer x) -> x);: 'lambda arguments' has incorrect indentation level 8, expected level should be one of the following: 10, 12. [Indentation]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/statistics/TestDurationTracking.java:200:  /**: First sentence should end with a period. [JavadocStyle]

will fix those

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 31s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  2s

No case conflicting files found.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 11 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
28m 46s

trunk passed

+1 :green_heart:
compile
19m 34s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
16m 50s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
0m 57s

trunk passed

+1 :green_heart:
mvnsite
1m 29s

trunk passed

+1 :green_heart:
shadedclient
17m  1s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 39s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m 36s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
2m 18s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 16s

trunk passed

-0 :warning:
patch
2m 38s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 50s

the patch passed

+1 :green_heart:
compile
18m 53s

the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

-1 :x:
javac
18m 53s
/diff-compile-javac-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 20 new + 2050 unchanged - 0 fixed = 2070 total (was 2050)

+1 :green_heart:
compile
16m 47s

the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

-1 :x:
javac
16m 47s
/diff-compile-javac-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt
root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 20 new + 1946 unchanged - 0 fixed = 1966 total (was 1946)

-0 :warning:
checkstyle
0m 57s
/diff-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 5 new + 141 unchanged - 4 fixed = 146 total (was 145)

+1 :green_heart:
mvnsite
1m 26s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m  6s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 37s

the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m 32s

the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
2m 21s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
9m 46s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 55s

The patch does not generate ASF License warnings.

160m 36s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2323

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux 28081b443bf7 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b361f29dda0

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/8/testReport/

Max. process+thread count
2599 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/8/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 31s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 11 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
29m 20s

trunk passed

+1 :green_heart:
compile
19m 42s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
16m 58s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
0m 57s

trunk passed

+1 :green_heart:
mvnsite
1m 29s

trunk passed

+1 :green_heart:
shadedclient
16m 56s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 37s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m 34s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
2m 16s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 13s

trunk passed

-0 :warning:
patch
2m 36s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 52s

the patch passed

+1 :green_heart:
compile
18m 59s

the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

-1 :x:
javac
18m 59s
/diff-compile-javac-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 20 new + 2050 unchanged - 0 fixed = 2070 total (was 2050)

+1 :green_heart:
compile
16m 58s

the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

-1 :x:
javac
16m 58s
/diff-compile-javac-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt
root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 20 new + 1946 unchanged - 0 fixed = 1966 total (was 1946)

-0 :warning:
checkstyle
0m 55s
/diff-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 4 new + 141 unchanged - 4 fixed = 145 total (was 145)

+1 :green_heart:
mvnsite
1m 28s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m 11s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 36s

the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m 36s

the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
2m 22s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
9m 45s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 56s

The patch does not generate ASF License warnings.

161m 40s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2323

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux 32ccda09dff3 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 82522d60fb5

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/9/testReport/

Max. process+thread count
1410 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/9/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

javac failures on newly deprecated static fs.impl.FutureIOSupport methods I'm retaining to avoiding breaking things; checkstyle on 4 javadoc lines which are too wide because they reference other classes
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/FunctionsRaisingIOE.java:41:   * @deprecated use {@link org.apache.hadoop.util.functional.FunctionRaisingIOE}: Line is longer than 80 characters (found 81). [LineLength]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/FunctionsRaisingIOE.java:54:   * @deprecated use {@link org.apache.hadoop.util.functional.BiFunctionRaisingIOE}: Line is longer than 80 characters (found 83). [LineLength]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/FunctionsRaisingIOE.java:65:   * @deprecated use {@link org.apache.hadoop.util.functional.CallableRaisingIOE}: Line is longer than 80 characters (found 81). [LineLength]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/statistics/package-info.java:28: * {@link org.apache.hadoop.fs.statistics.IOStatisticsSource#getIOStatistics()} .: Line is longer than 80 characters (found 81). [LineLength]

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
29m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  2s

No case conflicting files found.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 11 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
29m 53s

trunk passed

+1 :green_heart:
compile
22m 24s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
20m 48s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
0m 58s

trunk passed

+1 :green_heart:
mvnsite
1m 38s

trunk passed

+1 :green_heart:
shadedclient
19m 36s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 35s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m 43s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
2m 50s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 47s

trunk passed

-0 :warning:
patch
3m 11s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 57s

the patch passed

+1 :green_heart:
compile
24m 10s

the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

-1 :x:
javac
24m 10s
/diff-compile-javac-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 20 new + 2050 unchanged - 0 fixed = 2070 total (was 2050)

-1 :x:
compile
5m 14s
/patch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt
root in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.

-1 :x:
javac
5m 14s
/patch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt
root in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.

-0 :warning:
checkstyle
0m 36s
/buildtool-patch-checkstyle-hadoop-common-project_hadoop-common.txt
The patch fails to run checkstyle in hadoop-common

-1 :x:
mvnsite
0m 37s
/patch-mvnsite-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
0m 43s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 33s

the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m 45s

the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
2m 57s

the patch passed

_ Other Tests _

-1 :x:
unit
10m 52s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 54s

The patch does not generate ASF License warnings.

182m 10s

Reason
Tests

Failed junit tests
hadoop.ipc.TestRPCCallBenchmark

hadoop.metrics2.source.TestJvmMetrics

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2323

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux 57087f185719 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b92f72758bf

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/10/testReport/

Max. process+thread count
1421 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/10/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.1.3

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Also, should use java.io.UncheckedIOException for the wrapper class for an IOE. That's new in Java8, but as its public API there, what we should adopt. This is good, even if its a bit more work

This PR won't merge right now due to the move to shaded Preconditons. The PR #2324 has been rebased; I'll be rebuilding this PR from that one as a trunk + one big fat patch

Closing as nobody was reviewing this and its impossible to maintain the interface and impl branches. The combined -common and -aws changes make for a bigger pr, but each patch has gone in separately, It will be possible to merge the changes into Hadoop as two separate patches


Compile Python control flow syntax

The auto-graph feature in TensorFlow 2 lets tf.function() compile Python if/for/while statements into a graph. This feature can be a big productivity win because one never has to manually create symbolic control flow operations.
Specifically, statements whose conditionals evaluate to tensor types are compiled into symbolic control flow operations like tf.cond()/tf.while_loop(). All other statements are traced so that only the selected branch of an if/else statement is added to the graph and so that loops are unrolled statically, and get re-traced when the Python function inputs change.
Has this functionality been discussed and considered for JAX as well? It's the main reason I'm not using JAX at the moment.

I don't think we want autograph style evaluation of Python control flow to JAX by default for JIT compiled functions. My experience has been that parsing Python control flow can be error prone.
But this definitely seems like something that could be explored with an explicit decorator in jax.experimental. If we're lucky, perhaps we could even reuse some of the TF autograph code.
Note also jax.experimental.loops, which exists for a similar purpose, but isn't quite as magical.

So @superbobry and a former intern actually prototyped implementing this as a library on top of JAX using (a bunch of private symbols in) TF AutoGraph. They implemented support for if -> cond and for -> scan (where appropriate). The code is not OSS but I can link you an internal copy since you are a Googler, feel free to ping me on chat if you want to take a look.
IIRC the feedback at the time was that this was a cool demo, but that functional control flow in JAX was actually not all that complicated (no control deps or side effecting ops to reason about) so autograph was not a big win (unlike TF) and that one of the benefits of JAX was not having these layers of indirection between users and the library. I'm sure Sergei will correct me if I am misremembering.

So @superbobry and a former intern actually prototyped implementing this as a library on top of JAX using (a bunch of private symbols in) TF AutoGraph. They implemented support for if -> cond and for -> scan (where appropriate). The code is not OSS but I can link you an internal copy since you are a Googler, feel free to ping me on chat if you want to take a look.
IIRC the feedback at the time was that this was a cool demo, but that functional control flow in JAX was actually not all that complicated (no control deps or side effecting ops to reason about) so autograph was not a big win (unlike TF) and that one of the benefits of JAX was not having these layers of indirection between users and the library. I'm sure Sergei will correct me if I am misremembering.

Thanks for the context. I think autograph functionality is a productivity win for prototyping algorithms that go beyond simple feed forward networks.
Personally, it would be hard to convince myself to give the switch from TF 2 to JAX another try if it meant I need to go back to manually writing control flow ops, which was one of the major pain points in TF 1.

Thanks for the context. I think autograph functionality is a productivity win for prototyping algorithms that go beyond simple feed forward networks.
Personally, it would be hard to convince myself to give the switch from TF 2 to JAX another try if it meant I need to go back to manually writing control flow ops, which was one of the major pain points in TF 1.

In my opinion this would be most interesting for writing numerical computing primitives like ODE solvers. Right now we use a bunch of nested functions instead of for/while loops, which is rather awkward. In principle, this could let us directly JIT compile code from a library like SciPy.
So two other transformations that would be great to have would include:

while -> while_loop
x[i] = y -> x = x.at[i].set(y)

In my opinion this would be most interesting for writing numerical computing primitives like ODE solvers. Right now we use a bunch of nested functions instead of for/while loops, which is rather awkward. In principle, this could let us directly JIT compile code from a library like SciPy.
So two other transformations that would be great to have would include:

while -> while_loop
x[i] = y -> x = x.at[i].set(y)

The prototype was joint work with @mdanatg and IIRC we were able to re-use most of the AutoGraph internals (with a few hacks here and there). I'm not sure how modular and reusable AutoGraph currently is, but perhaps Dan could comment.

The prototype was joint work with @mdanatg and IIRC we were able to re-use most of the AutoGraph internals (with a few hacks here and there). I'm not sure how modular and reusable AutoGraph currently is, but perhaps Dan could comment.

The main caveat is that many symbols which were intended to be a user-facing API within AutoGraph are still private in TF. I wanted for a long time to distribute it as a separate PIP independent of TF, but never had the chance to set it up. If we had that, it would have its own API and things would be more straightforward.
AutoGraph itself is fairly reusable if you can easily adhere to the operator contract for control flow (see here, here and the tests). The interface was optimized to preserve Python semantics. So you probably need to do a bit of adaptation to fit your own control flow APIs (like we do to handle the TF control flow). IIRC, that's where we had to hack things a bit last time as well. At any rate, that will give you a clean separation where you reuse practically all non-TF bits, as the TF dependencies are concentrated in the implementations of the respective operators.
Another path that's been tried for other purposes is to transform the intermediate code generated by AutoGraph, which already transformed control flow to functional form, so it's mainly a matter of renaming functions and moving bits of AST around.
The two alternatives are dual - with AutoGraph generating things like: ag__.if_stmt(...), the main difference is whether you supply a custom implementation for if_stmt or whether you transform that to lax.cond(...).

The main caveat is that many symbols which were intended to be a user-facing API within AutoGraph are still private in TF. I wanted for a long time to distribute it as a separate PIP independent of TF, but never had the chance to set it up. If we had that, it would have its own API and things would be more straightforward.
AutoGraph itself is fairly reusable if you can easily adhere to the operator contract for control flow (see here, here and the tests). The interface was optimized to preserve Python semantics. So you probably need to do a bit of adaptation to fit your own control flow APIs (like we do to handle the TF control flow). IIRC, that's where we had to hack things a bit last time as well. At any rate, that will give you a clean separation where you reuse practically all non-TF bits, as the TF dependencies are concentrated in the implementations of the respective operators.
Another path that's been tried for other purposes is to transform the intermediate code generated by AutoGraph, which already transformed control flow to functional form, so it's mainly a matter of renaming functions and moving bits of AST around.
The two alternatives are dual - with AutoGraph generating things like: ag__.if_stmt(...), the main difference is whether you supply a custom implementation for if_stmt or whether you transform that to lax.cond(...).

Hey! What's the current status of this?

An idea for a syntax that makes control flow faster to write/edit/read while keeping it clear to the user what's happening:
def cond_example(pred, true_fun, false_fun, *operands):
  if lax.inline_cond(pred):
    return true_fun(*operands)
  else:
    return false_fun(*operands)

def scan_example(f, init, xs):
  carry = init
  ys = []
  for x in lax.inline_scan(xs):
    carry, y = f(carry, x)
    ys.append(y)
  return carry, lax.inline_stack(ys)

def while_example(cond_fun, body_fun, init_val):
  val = init_val
  while lax.inline_while(cond_fun(val)):
    val = body_fun(val)
  return val

Without JIT compilation, the new functions lax.inline_cond(), lax.inline_scan(), lax.inline_stack(), lax.inline_while() have trivial implementations.

@danijar how do you imagine implementing these helper functions? would this still need some form of AST or byte-code rewrite?

Yes exactly, we'll need to look at the AST like autograph does.
Maybe this should be an explicit function transformation in JAX? I'm still quite new to JAX so I don't know what the best way to make this available to users is.


Sent notification base on phone number

I want sent notification to user phone number, how to do it?
@derBeukatt @tek08 @efraespada @ralmarri12 @gooldeer

I think it can't be done 😅
You send a push notification to a token, so you must link the token to a phone number.

Hi! Sorry for taking so long to respond to your issue on GitHub. I was focused on releasing the new 0.7.0 version of awesome_notifications and awesome_notifications_fcm and i didn't had time enough to do both. But now I can answer all your questions.
So now i'm asking you to recreate this topic using the new issue template. There's a lot of missing informations that i need to understand your problem, and all the instructions are already in the new issue template. Also, remember to check beforehand if your issue was posted by another user.
So I will automatically close all previous issues so far.
Sorry for the inconvenience and i will be waiting for your new issue request.
Thank you so much for your support!


Fix additional incompatibilities with TruffleRuby

Context
This is similar to changes in https://github.com/open-telemetry/opentelemetry-ruby-contrib/pull/60 that replace usage of fork with usage of spawn. According to the TruffleRuby docs:

You cannot fork the TruffleRuby interpreter. The feature is unlikely to ever be supported when running on the JVM but could be supported in the future in the native configuration.

This PR fixes #44 and possibly #42 ~(I can't reproduce issues with the rails gems, so I want to see if errors arise in CI)~ I see the errors in the CI checks now.
Question: Is it better to open separate PR's for each fix or group them?
Would you prefer that I fix each gem in its own PR or is it okay to group them into one PR like this?

Would you prefer that I fix each gem in its own PR or is it okay to group them into one PR like this?

I think for circumstances like this, where the fixes are relatively trivial and small, grouping in one PR is fine. 😄
Also, thank you!


Better detection of threadsafe ActiveResource

@alexaitken @kevinhughes27 @ch33sybr3ad
Fixes https://github.com/Shopify/shopify_api/issues/194
Problem
ShopifyAPI::Base.headers behaves differently, depending on whether we've detected that we're using the threadsafe version of ActiveResource, or the non-threadsafe version of ActiveResource.
Right now, we're detecting that based on the version number of the activeresource gem. This isn't a sustainable solution, because:

It assumes that the "pre" string is "threadsafe", which is only defined in Shopify's fork of ActiveResource. Now that core ActiveResource contains the threadsafe changes, we should start to work with that instead of just our own fork.

It only works with major version 4, and core ActiveResource is now at version 5

Solution
Instead of detecting the version string, directly check that the methods we want to use are available on ActiveResource::Base
Food for Thought
This is still an unsatisfying solution. The best thing would be to not override the headers method at all. Is this change really necessary? If it is necessary, is this something that can be pushed to core ActiveResource?
Compared to the ActiveResource::Base.headers, it seems like the behaviour in ActiveResource is to merge the class's headers with the superclass's headers. The behaviour in ShopifyAPI is to return either the superclass's headers or the class's headers.
This was originally added here: https://github.com/Shopify/shopify_api/pull/19
Looks like it was to support oauth changes

ping @alexaitken @kevinhughes27 @ch33sybr3ad
I added testing for Rails 5 (and also testing for Rails 4.2, which had a Gemfile but travis wasn't running it)

lgtm

I've also added a version bump to 4.2.0 to this PR
@alexaitken @ch33sybr3ad any concerns?

LGTM

Thanks for working on this!
Is there something I need to do to get Rails 5 working?
Steps to reproduce:

Create a new Rails 5.0.0.beta3 app.
Add shopify_api to the Gemfile
Run bunde install

Expected:
Shopify API gem to install.
Actual:
Bundle  attached file.
Seems there might be dependency issue here.
Bundle suggesting running `bundle update

Thanks for your efforts on this guys!
Do users need to do something special to get this going on Rails 5?
Bundler blocks this gem when I try on a new Rail 5 app, please see below attachments.
Steps to repro:

Create a new Rails 5.0.0.beta3 app.
Add gem 'shopify_api', '>= 4.2' to the Gemfile
Run bundle install

Expected
Shopify API gem to install.
Actual
Bundler blocks install
Please see output
Apparently activemodel, activesupport, and thor have dependency issues.
Bundler output suggests running bundle update but no difference.
Hopefully I'm posting this in the right place - apologies if not.

ActiveResource hasn't released a new gem in a while, which means trying to use rubygems out of the box will only pick up ActiveResource 4.0, which isn't compatible.
Try adding:
gem "activeresource", github: "rails/activeresource"
gem 'rails-observers', github: 'rails/rails-observers'

to your gemfile, to use the recent code in these projects. Once Rails 5 releases, I expect ActiveResource and Rails Observers will release new compatible gems.

Ah, of course.
Thanks Peter! That seems to have done the trick.


This project is not on active development anymore

Sorry guys. The project is not on active development anymore.
I suggest you to use another python package. Thanks!
You can follow the discussion in here:
https://web.facebook.com/groups/1174547215919768/permalink/1734663919908092/

Shameless plug, you can use the fastText python binding I have created: https://github.com/vrasneur/pyfasttext
Vincent


Update to procedure for Azure AD SSO integration with AppNeta Performance Manager

@gmalange : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi @jeevansd.
Just wondering what the review status is for this PR.
Thanks!

@gmalange It seems you have added these images in the common folder. Can you please add them in the app specific folder? Also note that the image names should in small letters and you can use "_" in the names as needed. Please dont use space here.

@v-hagamp  and @v-rant please track this.

Hi @jeevansd.
It's not clear to me where the app specific folder is. The source .md file (appneta-tutorial.md) file is in articles/active-directory/saas-apps. All the .png files referenced in that document are in the "common" folder so I added the new .png files there as well. Please let me know the name of the app specific folder you are referring to.
Also, all the .png files I created have lowercase file names and use "-" to separate words (no spaces). This is consistent with the majority of the file names in "common" (some use "_" to separate words). Maybe I am missing something. Is there a specific filename I use that you are referring to that does not meet the criteria?

I don't see an app-specific folder created yet, so I'll move the commit to a new pull request in the private repo and merge it from there (with the folder created and the image file moved). I'll post here when the new PR is created. Thanks.

Thanks  a lot @ktoliver

The updates have been merged in a new PR in the private repo. I would look for them be live with the next publishing to live, this afternoon. We'll close this PR.


Log server error response when websocket handshake fails

It's very difficult to troubleshoot websocket connection issues between agent and server like this one:

Any errors (auth, malformatted headers, etc...) occuring during the websocket handshake are returned in the HTTP response to the client using the DefaultErrorWriter passed to the websocket Upgrader instance. They are never logged in the server log.
https://github.com/rancher/norman/blob/6c7654a69fb674058c6a4c9ce9e9dcf7d5113bdc/pkg/remotedialer/server.go#L21-L24

The client in the agent gobbles up this error because it does not evaluate the HTTP response body and instead logs a helpful (not) bad handshake error.

Finally there is a bug where the server tries to write the HTTP error response twice (the Upgrader has at this point already written the response):
https://github.com/rancher/norman/blob/6c7654a69fb674058c6a4c9ce9e9dcf7d5113bdc/pkg/remotedialer/server.go#L65-L68
Since writing the header for the same response object a second time is not allowed, the response never reaches the client and following warning is logged in server:

http: multiple response.WriteHeader calls

@StrongMonkey

Found another bug in current implementation of the DefaultErrorWriter. The status code is always 200 OK because one can't change the header after writing to the body.
https://github.com/rancher/norman/blob/5217a0efca14080d205d518ec9e25a14f4180d5c/pkg/remotedialer/server.go#L21-L24
Example here: https://play.golang.org/p/SIia1rAct1b

LGTM

remotedialer moved to its own repo Im going to close. If you havent already, open up a pr there if you want to move this forward


beam: tooling upgrade (rebar3, hex2nix, relx, etc)

Motivation for this change
This change upgrades all Beam tooling to the newest versions and:

makes the tooling depend on explicit non-automatically generated Hex packages => this makes upgrading hex-packages.nix to no longer break tooling necessary to do the upgrade at cost of minimal duplication;
since buildRebar3 depends on rebar3 port compiler package (pc), make it into an explicit manually defined package;
redo rebar3 hermeticity patch to make it smaller and more robust;
upgrade hex-pm-registry-snapshot;
adds @gleber to CODEOWNERs for beam-related packages.

Part of #11748
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS)
[x] Tested using sandboxing (option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

CC @ankhers @ericbmerritt

@gleber There appears to be a conflict with the code owners file. If you fix that, I can run nox on my mac.

@ankhers Rebased onto 90b3d2d, now it merges. Please take a look

On Linux with sandboxed builds:
$ git log -n 6 --oneline
c041770 Add gleber to CODEOWNERs of beam-related packages.
52f8bec hex2nix: 0.0.5 -> 0.0.6
b8adacf relx-exe: 3.18.0 -> 3.23.1
c806641 pc: 1.2.0 -> 1.6.0
adbc1ed rebar3: 3.3.2 -> 3.4.3
90b3d2d qtox: drop gtk2 dependency
$ nix-shell -p nox --run "nox-review wip --against 90b3d2d"
==> We're in a git repo, trying to fetch it
Building in /tmp/gleber/nox-review-zvt88czh: hexRegistrySnapshot lfe rebar3 rebar3-open hex2nix relxExe
... [snip] ...
Result in /tmp/gleber/nox-review-zvt88czh
total 0
lrwxrwxrwx 1 gleber gleber 56 Sep 11 23:07 result -> /nix/store/6z1389kpniviix3z9qshkvvh6kx6jq87-hex-registry
lrwxrwxrwx 1 gleber gleber 53 Sep 11 23:07 result-2 -> /nix/store/6br5zdw59cf31jjnx4c55yldfa0p353c-lfe-1.2.1
lrwxrwxrwx 1 gleber gleber 56 Sep 11 23:07 result-3 -> /nix/store/v17rfryiaiw50jxl5v3fqqab8c990ib0-rebar3-3.4.3
lrwxrwxrwx 1 gleber gleber 56 Sep 11 23:07 result-4 -> /nix/store/j4xv8qr5pqmxbws8jx1pxl7d1kyckx83-rebar3-3.4.3
lrwxrwxrwx 1 gleber gleber 57 Sep 11 23:07 result-5 -> /nix/store/rqrc51l49sxigddjnnxnszv97sp21qpq-hex2nix-0.0.6
lrwxrwxrwx 1 gleber gleber 59 Sep 11 23:07 result-6 -> /nix/store/6xcsvpi5w50z0cnrvr0p65q6yq9shgwi-relx-exe-3.23.1

Also builds on NixOS

Nox just finished and it builds on MacOS.

Thanks!


Let it be a bug only when it's reproducible with official runner image

A custom runner image can break runners and ARC in interesting ways. Probably it's better to clearly state that ARC is not guaranteed to work with every custom runner image in the wild.

Thanks for your review! Merging.


setBadge() does not work with incrementing variable

Unless I am just using this very improperly, the setBadge function does not seem to be working when a variable is passed in. I can call cordova.plugins.firebase.messaging.setBadge(5), and when I get a notification in the background, the badge is set to 5.
However, I attempted to set a variable that won't get reset to 0 until a certain function is called in my index.js file that will tally up the amount of unread notifications, like so:
var notificationCount = 0;
Then call setBadge() like so:
cordova.plugins.firebase.messaging.setBadge(++notificationCount)
Now when I get a notification, the badge only updates on the first notification I receive. All other notifications do not seem to call this function.
Is there a better way to tally the amount of notification I've received since opening the app?

Check your js code, this issue is not related to this plugin.


Move the search bar down, move Add/Hide Tokens #3444

Closes #3444

Looks ok. In case you missed it, don't forget "Copy Address" https://github.com/AlphaWallet/alpha-wallet-ios/issues/3444#issuecomment-972764762

Seems the PR is restricted to changing the Wallet tab's navigation button for now and not the search bar yet. Do you mean if I take over this PR and merge in the navigation button changes, and you can start a different one for the search bar change?

i.e. I'll scope down this PR to:
Add copy address functionality to Wallet tab navigation button (so there's an actionsheet)

@hboon its ready to review

Force pushed after rebase master


fix: remove Debian LLVM PPA repo (Linux runners only)

resolves #265
Users that expect the PPA to be present after running cpp-linter-action can set the environment variable KEEP_DEBIAN_LLVM_PPA to true, on, or 1. By default, the PPA is removed.

I don't intend to get this out in the next release. I still want to test this in the test repo to be sure there is no undesired behavior or side effects.


Jacuzzi J345

Just want to say thanks for the progress thus far on this project!
So far this is the only thing that has gotten any valid responses from hot tub. I am looking forward to more progress towards Home Assistant interfacing.
I can control all aspects of the J345 connected with the factory Prolink Wifi module, the lasted version of the ProLink app is terrible and I cannot reliably control my hot tub.
Looking forward to more developement.

You're welcome and thank you for the feedback on using it with your J345.  Currently I am working on understanding the differences between encrypted and unencrypted control boards. I haven't tried integrating with HomeAssistant but from HyperactiveJ's work it looks like that is not too difficult.
Do you have problems with Prolink randomly "going to sleep" -- not responding to connection requests?  That is one of my biggest complaints at this point and it is apparently true with their phone app too.  I haven't been able to connect with my tub for several weeks now.

So far I haven't noticed any issues with sleep but to be honest I haven't monitored it that much.
If it were in part of my Home Assistant setup I would've noticed it.
I mainly used the Prolink for keeping track of water changes but the app is totally useless after the last update for me.
I tried using HyperactiveJ's "Encrypted" Sundance 780" stuff but couldn't get much from my tub. So I'll assume mine is unencrypted?

If your system works with jacuzzi.py then it is definitely not encrypted.
Jackbrown1993's system is not encrypted but he is using a generic wifi to RS485 box. HyperactiveJ's system is encrypted and he uses the RS485 box.  My system is unencrypted and uses the Prolink box.
HyperactiveJ also has worked out the interface to HomeAssistant. I am pretty sure that is completely unrelated to the encryption and interface box issues.  Shouldn't be hard to make jacuzzi.py to work with that part of his code, but I haven't tried yet.
pddc had an unencrypted system and Prolink. But he shorted out the control board and the replacement he bought was encrypted. I believe he now has an unencrypted control board too.  And he got the RS485 box to see if he could abandon Prolink. So I think pddc has all options.

By the way do you know that the Prolink app maintenance timers (like the water change timer) are nothing more than simple countdown timers, correct?
In other words the app doesn't try to do anything fancy like keep track of how much the tub is being used, etc.  They simply count down to zero and then warn you.  So conceivably you could do the same thing all in Home Assistant, without actually connecting to the tub at all.

Yeah I figured that but it was convenient, plus I would use the app to check on temps. Like I say it is totally unusable for me now.

Understood. And I feel your pain. :-)

I've been keeping an eye on all of the options but haven't seen too many updates on any. Guess it's not hot tub weather for most working on their projects.

Yes I suspect others are busy with summer obligations.
My limitation is that I do not have a spa with both Prolink and an encrypted controller -- so I am relying on others who do to perform any testing of the encrypted interface.  Non-encrypted with Prolink is mostly working as far as I know.
The encryption/decryption part works but plenty of basic control & monitoring of an encrypted controller does not.  It just requires brute-force working through the differences between encrypted status and command messages to resolve the bugs.  Hard to do without having the actual controller to test changes on.
Similarly, I don't have a direct RS485 interface (yet anyway) so I have to rely on others who do in order to test anything there.  It looks like @HyperactiveJ has most of that worked out so I'm not directing my attention there currently.
HyperactiveJ also has worked out the interface to Home Assistant (using mqtt).  I think it should be relatively straightforward to do the same with jacuzzi.py -- I'm pretty sure it is just repackaging the commands and replies into mqtt format.

Presently I just have the Prolink adpater, I think it's not encrypted.
I tried Jackbrown1993's but I can only get the temp from the tub and nothing else.
I thought about trying a RS485 adapter but just haven't yet.


⚠ Turnos 24x7 has degraded performance

In 5c0ea95, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 981 ms

Resolved: Turnos 24x7 performance has improved in d4af43c.


Az account does not support switching between accounts

Is your feature request related to a problem? Please describe.
I have a couple of accounts in my tenant. az account set only allows for the current account to switch between subscriptions.
Describe the solution you'd like
I would like to be able to see all available contexts and switch between them. Refer to Az PowerShell's Get-AzContext -ListAvailable and Set-AzContext.
If you run az account list you will only see the "unique" subscriptions, not the full list available accounts.

@jiasli for awareness

Could you explain what you mean by "accounts"? "account" is only an Azure CLI concept, which is either a subscription account or tenant account (--allow-no-subscriptions).
If you are referring to user account, yes, Azure CLI current only uses subscription ID the primary key for selection. This was discussed in https://github.com/Azure/azure-cli/issues/15005.

Thanks for the follow up. Issue #15005 is exactly describing what I would expect. Apparently it was already raised more than a year ago. Could you please prioritize?
I am also experiencing something related to my requirement:
As soon as I switch the az cli context then in every session the context is switched. Ideally other sessions keep their own context until the session is restarted. I guess you can use non persistent local environment variables for this which get flushed when a session is terminated.


Troubleshoot connectivity issues with the Java agent

cc @trask @heyams @mattmccleary

Learn Build status updates of commit 552f3a1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

support/azure/azure-monitor/app-insights/java-standalone-troubleshoot.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Install Script

Not sure if you're hard pressed on piping a file to sh, but if you're not and you're willing to require that users have golang already installed...
Then just get them to execute wget https://github.com/itsabot/abot/abot_install.go && go run abot_install.go
The script puts abot in the GOPATH, and runs cmd/setup. If you want it to do more, just let me know.

Hey Nathan, thanks for making this. I would like to have a single installer via sh, though, so I can't merge this in.
Installing Go and Postgres 9.5 seem to be big sticking points for new Abot developers, so the purpose of this install script will be to automate the process with defaults.

No worries, writing  a bash script is just more of a pain in the butt. Anyway, how did you want to handle setting up postgres? You would need to require sudo to run apt-get/yum/pacman, and to enable the systemd job.

That's precisely what we'll do. The script is open-source and available for everyone to read before running. I'm taking inspiration Heroku's cli tool install process, which does the same thing.

Ahh, okay then. So what distros did you want to focus on? ubuntu, arch, fedora?

Ubuntu and OSX to start.  I assume most people running Arch and Fedora will be able to install the dependencies themselves, whereas Ubuntu seems to be the "starter" distro.

Are we assuming they have homebrew installed on OSX?

Heroku uses an actual installer for OSX. I'm not sure of the pros/cons with that approach on the platform, so it's worth some research. We probably should not assume that another dependency, eg Homebrew, is installed.

K, I have a script for ubuntu done. Only question, is if we're installing golang for them, where do we put their GOPATH?

That's a great question. We could either prompt the user with a sensible default (~/go) or place it there if and only if the directory doesn't exist. It's easy enough for the user to change after-the-fact, too.

Here's the install script for Ubuntu.
The workflow for installing would be:
wget <url>
source ./install.sh

@njaremko are you sure the .sh was committed? I only see an empty commit.

Yeah it's install.sh in the root of the project.

This is a good start. A few notes:

Can we eliminate setting a password for Postgres altogether? If we eliminate the password I believe you can just call cmd/setup.sh without any args, since everything will use the default settings.
The script doesn't need to run go get ...glock. That happens in cmd/setup.sh.
I'm still weighing whether we should be installing homebrew on Mac.

I set a password in postgres for security reasons, but if you think people will only use this script for local stuff then I guess we could remove it.
If you don't go get ...glock you get an error saying glock isn't installed...so might wanna look into that hahaha
Yeah, but it's the only way to have an install script on mac, otherwise we'll have to look into an actual installer.

That's absolutely a reasonable approach for Mac, especially since the Ruby VM is installed by default in OSX. I'll test out the script, and if all's good, we'll get this merged!

Need to set a postgres password or it won't connect. So I've added it back in.

@egtann is that gpg key that is causing builds to fail yours?
Because if it is, you should submit it to: https://pgp.mit.edu/ to fix this.

Any status updates?

Yup. This'll be the final piece I handle with the v0.2 release. We're quickly approaching it, though!
In the end it'll have to be available via itsabot.org/install.sh, so you might want to move the PR over to the itsabot.org repo. Along with it, it'd be helpful to create a handler that serves the static file at that URL.


Novabbe ma hai fatto uno shutdown timer

ti piace?

Yessir
Il lun 9 gen 2023, 23:39 Enrico @.***> ha scritto:

ti piace?
—
Reply to this email directly, view it on GitHub
https://github.com/enricoferraiolo/Shutdown-Timer/issues/5#issuecomment-1376432554,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALOMZIGJAYYSX5O4DCJ2JSDWRSHQVANCNFSM6AAAAAATV3OCEU
.
You are receiving this because you authored the thread.Message ID:
@.***>


chore(video, audio): update definition for document automation

Because

we want to automate documentation script

This commit

add the chinese title for the components

@chuang8511
We don't need to maintain multi-language documentation support in components. I'll close this PR.


[CHERRY-PICK][BEAM-7916] Add ElasticsearchIO query parameter to take a ValueProvider (#9285)

Cherry-picked from release-2.14.0, where it was merged by mistake.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Run Java PreCommit


Got the error Undefined symbol: OBJC_CLASS$_GMSNavigationTermsAndConditionsOptions

During building iOS project process,  I got the error Undefined symbol: OBJC_CLASS$_GMSNavigationTermsAndConditionsOptions when invoked the method used to show terms and condition dialog if needed.
Environment details

Xcode Version 15.4
SwiftUI
iOS Navigation SDK version 9.1.0(injected by Package Dependencies tool)

Code example
func requestTermsAndConditions() {
        GMSNavigationServices.showTermsAndConditionsDialogIfNeeded(with: .init(companyName: "companyNameABC")) { termsAccepted in
            // TODO: Not Implemented
        }
    }

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Updated:
Upgraded iOS Navigation SDK to version 9.1.1 solved this issue.


Firestore 7.2 fails to build on Apple M1

Step 0: Are you in the right place?

For issues or feature requests related to the code in this repository
file a Github issue.

If this is a feature request please use the Feature Request template.

For general technical questions, post a question on StackOverflow
with the firebase tag.
For general (non-iOS) Firebase discussion, use the firebase-talk
google group.
For backend issues, console issues, and other non-SDK help that does not fall under one
of the above categories, reach out to
Firebase Support.
Once you've read this section and determined that your issue is appropriate for
this repository, please delete this section.

[REQUIRED] Step 1: Describe your environment

Xcode version: 12.2 (12B45b)
Firebase SDK version: 7.2.0
Installation method: CocoaPods
Firebase Component: Firestore
Laptop Chip: Apple M1

Podfile
platform :ios, '13.0'

# Uncomment this line if you're using Swift
#use_frameworks!

def core
  pod 'Bolts', '1.9.0'
end

$firebase_version = '7.2-M1'
def firebase_sdk
  pod 'Firebase/Core', $firebase_version

  pod 'Firebase/Analytics', $firebase_version
  pod 'Firebase/Crashlytics', $firebase_version
  pod 'Firebase/Performance', $firebase_version
  pod 'Firebase/Auth', $firebase_version
  pod 'Firebase/DynamicLinks', $firebase_version

  pod 'Firebase/Messaging', $firebase_version
  pod 'Firebase/RemoteConfig', $firebase_version
  pod 'Firebase/Storage', $firebase_version
  pod 'Firebase/Functions', $firebase_version

  pod 'Firebase/Firestore', $firebase_version
end

target 'Project' do
  core
  firebase_sdk
end

[REQUIRED] Step 2: Describe the problem
Firestore build fails.
Steps to reproduce:
Build fails with an error:
/Pods/gRPC-Core/src/core/ext/filters/client_channel/xds/xds_api.cc:37:10: fatal error: 'envoy/api/v2/cds.upb.h' file not found

Part of that header:
#include "src/core/lib/iomgr/error.h"
#include "src/core/lib/iomgr/sockaddr_utils.h"

#include "envoy/api/v2/cds.upb.h"
#include "envoy/api/v2/core/address.upb.h"

I noticed that missed files actually located at $(GRPC_SRC_ROOT)/src/core/ext/upb-generated path, added the path to the User Header Paths for gRPC-Core target.
After that Pods were completed successfully, but another errors appear during project compilation:
Showing Recent Errors Only
/Pods/Headers/Public/abseil/absl/time/time.h:77:10: 'chrono' file not found
Could not build Objective-C module 'Darwin'

Everything works fine if Firebase is removed from the podfile.
Also the project compiles OK on Intel based laptop.
Relevant Code:
// TODO(you): code here to reproduce the problem

Hi @akopanev, sorry for the troubles you're seeing. I just tested on my M1 Mac mini and was unable to reproduce (using a clean project and the Podfile you provided).
Perhaps this is something wrong in Xcode's cache, can you clear derived data and try a clean build? If that doesn't work, we'll likely need a project that can reproduce the issue to make any further progress.
Thanks!

@ryanwilson thanks for swift reply!
I've also created an empty project, added podfile and reproduced the error.

Hmm, even with your sample project (thanks for providing) I'm unable to reproduce. It could be a CocoaPods cache issue. Can you try using the pod cache clean command? You may also need to clean the cache at ~/Library/Caches/CocoaPods/

Thanks a lot @ryanwilson, cleaning the pods cache resolved the issue.

Happy to hear, thanks!


Tests never exit while timeouts or intervals are running in the background

Steps to reproduce
Run this code in tape:
var test = require('tape');

setInterval(function() {
    // I'm not really doing anything
}, 250);

test('Tape will not exit while a setInterval is running', function (t) {
    t.plan(1);
    t.equal(true, true);
    t.end();
});

Expected result
The test exits successfully.
Actual result
The test never exits.

You'll find this has nothing to do with tape. All node/io.js programs work this way. Here is a repro that also never exits:
setInterval(function() {
    // I'm not really doing anything
}, 250);

Yes, I know that is the case. I didn't say this was caused by tape, just that I expect tape to exit when it's done testing.
Mocha exits just fine, with a similar testcase.
setInterval(function() {
}, 250);

describe('intervals', function() {
    it('exits just fine', function() {
    });
});

That's... bizarre. I have no idea how Mocha does that. Maybe it force-exits the process (very bad practice).


[A11y]API Keys button is rendered using the wrong HTML Element type.

Original: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1554272
Repro Steps:

Hit https://www.nuget.org and press Enter key.
Navigate to "Sign in" control and hit enter.
Navigate to "Sign in with Microsoft" control and hit enter.
Select “API Keys” from the Profile Dropdown and hit enter.
Navigate to "Create" button and hit enter.
Enter Values in "Key Name" and "Glob Pattern" field and hit enter on Create button.
Navigate to "Manage" control and hit enter.
Verify that whether the API keys are defined as button or heading.

Actual Result:
For 'API keys' button, it was defined as a H1 heading instead of button.
Expected result:
For API keys, it should be defined as button only.
User Impact:
Users might be able to get confused that the button is defined as heading.
Notes:
Updating this to a button and restyling to match should be sufficient.

Replied to the ADO bug and requested clarification as the specified headers appear in other pages and seem to just be needed as headers, not buttons.

ADO bug closed.


Merge develop branch

This changes contains few commits to improve pytoport:

add requirements.txt file, it's a common usage in Python community projects
conform PEP8 python standard coding style
Fix the warning below emit by portlint after generating a port if description argument in setup() function is not well formed
update readme accordingly changes

$ portlint -a
WARN: Makefile: COMMENT should begin with a capital, and end without a period

Thanks for the contribution!
Would it be possible for you to instead of having a requirements heading as you do, change it to "Installation" with subheadings for FreeBSD and 'From source' with your requirements info?
In general, we want people to use the package manager so they don't end up polluting their environment, but for those of us who know what we're doing, we use virtualenv or venv anyway so it doesn't hurt. :smile:

FYI, it's works into a virtualenv (i.e. not install from ports or pkg or can be used on other systems) that's the main reason why I added the requirements.txt file, otherwise I really don't mind. Sure, I can update the changes if you really want.

@bbqsrc Updated!

Thanks, there's a couple of typos but I'll fix those. :+1:


cache issues when using @defer directive and @urql/exchange-graphcache

Describe the bug
I’ve run into a pretty weird issue while using urql and I could really use some help.
The main problem is that when my app sends a query with defer or when it receives chunked data, it seems to be the last request that’s ever fired.
For example, when I open my app and navigate through random pages, everything works just fine. But when I go to a page that uses defer and then move to another random page, I get a bunch of runtime errors due to missing data. It looks like the query was resolved (cache hit), but an API request was never fired. When I refresh the page, everything works again.
After some debugging, I narrowed it down to have something to do with @urql/exchange-graphcache (if I remove the exchange it works fine). Based on the logs and urql devtools, there’s a cache hit for those queries when I there shouldn’t be. Also, when I remove defer usage, logs from the same flow show cache misses.
Do you have any suggestions what could be causing this?
Urql dev tools:

There's no API call for the last four queries
The fifth one (from the bottom) is the one with defer directive

Here's a PR to GraphQL Hive with adding defer to one of the queries (and necessary setup): https://github.com/kamilkisiela/graphql-hive/pull/1964
Reproduction
https://github.com/kamilkisiela/graphql-hive/pull/1964
Urql version
@urql/core: 4.0.4
@urql/exchange-graphcache: 6.0.1
Validations

[X] I can confirm that this is a bug report, and not a feature request, RFC, question, or discussion, for which GitHub Discussions should be used
[X] Read the docs.
[X] Follow our Code of Conduct

This is a great description btw :+1: If I could have every bug report in this format, I'd be happy beyond belief haha
Some follow-up questions before I look into this tomorrow, are you navigating before the deferred query completes? Does the bug happen either way? I basically realised just now that we have no test case covering this.
Also to clarify, I'm not sure, off of a cursory glance whether I could reasonably run the entire GraphQL Hive API and UI just to reproduce this, so, unless this is really simple, I'd carefully point out and hazard a guess that I'll have to start looking at this without a reproduction at first. There's not a lot of code-paths for @defer however, so that should be alright
Lastly, can you confirm for me please that the cache hit response you're getting has the deferred fields null'ed out rather than missing? I'd assume that that's a prerequisite for this being marked as a hit, but I may be wrong, depending on where the bug is located.
Best case, this is an old regression from the deep-diffing code that keeps results reference equal 🤔

Still experiencing the same issue!


Test still passes when trying to use dependencies in Jasmine "it" without using inject()

Let's say I write something like this by mistake, the test run by Karma still passes
   it('should test my directive', function($compile) {
      scope.data = data;
      element = angular.element('<my-directive></my-directive>');
      $compile(element)(scope);
      scope.$digest();

      expect(<something>).toEqual(<something>);
    });

Obviously it should be inject(function($compile){...}) and the first 4 lines can be put inside beforeEach, but I just want to point out the issue. I only notice the issue when I read Jasmine report on my browser.

I'm not sure the fault lies with karma if this passes, in theory, without the inject it should simply throw an error, as expect(<something>) is no valid javascript, or is this run through a perprocessor?

No, it is just a normal expect, something like this:      expect(element.find('li').eq(0).text()).toEqual('China Doll');
When I tried something like this, it throw " TypeError: $compile(...) is not a function":
it('should test my directive', function($compile) { });

but it won't throw any error if I do sth like this:
it('should test my directive', function($compile) {
  $compile(element)(scope);
});

Cause it might think $compile is the 'done' function that you can
optionally pass into every it function. And from its perspective you called
done so you're "async" test has completed.
On Fri, Jul 10, 2015 at 2:33 PM Nghi Le<EMAIL_ADDRESS>wrote:

No, it is just a normal expect, something like this:
expect(element.find('li').eq(0).text()).toEqual('China Doll');
When I tried something like this, it throw " TypeError: $compile(...) is
not a function":
it('should test my directive', function($compile) { });
but it won't throw any error if I do sth like this:
it('should test my directive', function($compile) {
$compile(element)(scope);
});
—
Reply to this email directly or view it on GitHub
https://github.com/karma-runner/karma/issues/1490#issuecomment-120488975
.

--

Tim

Closing, as this has nothing to do with karma, if you want a different behaviour you will have to modify/change jasmine


Issue with Comparison operators

Issue Description
Under the section Comparison Operators the first item on the list is not a valid comparison operator. I understand you explained its purpose as an assignment operator but for clarity, kindly remove it from the section of comparison operators. Thanks!

could you please raise a PR
On Thu, 8 Aug, 2024, 8:27 am Martin, @.***> wrote:

Issue Description
Under the section Comparison Operators
https://github.com/sanskaarz/LearnJS?tab=readme-ov-file#comparison-operators
the first item on the list is not a valid comparison operator. I understand
you explained its purpose as an assignment operator but for clarity, kindly
remove it from the section of comparison operators. Thanks!
—
Reply to this email directly, view it on GitHub
https://github.com/sanskaarz/LearnJS/issues/11, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWMBJ6FMPALQTD5AYF6OT3LZQLNARAVCNFSM6AAAAABMFR7XQ6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ2TINZWHEYTENY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


add basic xds proxy test

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[X ] Does not have any changes that may affect Istio users.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
bd7470d7dc924f9736e72b3da503920574248c2e
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
bd7470d7dc924f9736e72b3da503920574248c2e
link
/test lint_istio

gencheck_istio
bd7470d7dc924f9736e72b3da503920574248c2e
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
e92140de00e6b8cd5e3d9b5004df69ff50e89c8a
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio


Include in Experiment parameter_secret_values: section to don't expose values in logs

Sometimes we could need to define a property as a token value and for security reasons we don't want to expose this in logs on exceptions.

PD: Or any other solution will be fine :-)

After discussing this issue with Jesus, we decided to use a solution that allows users to specify which metadata should be omitted from the log.


Cython getting pulled in by pip?

Noticed this in the Travis logs. Any reason we aren't installing it via conda if we need it?

Didn't know we needed it, but seems like it's a dependency of h5py? Should probably be added to Conda's requirements file then.

Fixed by #131.


Add a few missing stubs for ROCm/HIP build

Follow-ups of #2426 and #2578. Seems to close #2681 based on https://github.com/cupy/cupy/issues/2681#issuecomment-559912154.

pfnCI, test this please.

Jenkins CI test (for commit 87a5cfd7bfad66219ef52dd57d6c8ab9ce61fbdc, target branch master) succeeded!

LGTM!


Rename homeassistant.util.async to .async_

"async" is (going to be) a reserved word.
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

This is not true. It's fine in package names.

It's not fine in Python 3.7.
dev /tmp$ python3.6 t.py
dev /tmp$ python3.7 t.py
  File "t.py", line 2
    from foo.async import bar
                 ^
SyntaxError: invalid syntax
dev /tmp$ python3.7 -VV
Python 3.7.0b1 (default, Feb  1 2018, 07:36:28)
[GCC 7.3.0]
dev /tmp$

https://bugs.python.org/issue30406

Sorry, my bad !


Missing requirements.txt

Install would be much easier with a requirements.txt file
This can be easily done with:
pip freeze > requirements.txt
There are required packages missing from the listed dependencies is the README.md
Thanks!

Yup! missed that one, I do remember it was PyTorch 0.3, not sure of others. If you are able to run this project, do me a favor open a PR adding a requirements.txt file :)


Update audit log message while fail to adding peers to channel

Type of change

Bug fix

Description

Update audit log message and status code while fail to add peers to channel.

this does fix the error code part of the log, but the issue says they find the message itself misleading. with your PR the msg will still read as peer “Org1Peer” has joined the channel “mychannel” even if it failed.
open to ideas, but i would suggest switching to a different log message string if the status var is "error"

In case of error passing "error" string as a parameter in method call
https://github.com/ckpaliwal/fabric-operations-console/blob/audit-log-message/packages/apollo/src/components/JoinChannelModal/JoinChannelModal.js#L414