Support "build" mode (multi project) Typescript

Can we have a support for this?
https://github.com/Microsoft/TypeScript/issues/3469#issuecomment-400439520

It'd be great to support that but there could be some potential complications. I'll add this to our list of potential enhancements.
For reference, here is that information on the TypeScript website: https://www.typescriptlang.org/docs/handbook/project-references.html

I want to support this - but in order to move forward with it, I will need at least one example project using it... closing as unactionable for now. If someone has a project using this that isn't horrible to install, please open a new issue about this so that we can work through any remaining issues.


Fixed Issue 2868, libvirt resize notify failure

Description
Fixed for https://github.com/apache/cloudstack/issues/2868
Incorrect diskpath information was being sent to virsh blockresize, so the block device size was never refreshed to reflect the new disk size.
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

Fixes: #2868

Screenshots (if appropriate):
This was tested on Centos 7 with Ceph backend storage. Virtio-blk driver was used in the VM. Ubuntu 16.04 and Centos 7 VMs were tested.
Disk was 106GB:

Resize was used via the ACS GUI to resize the block device on ceph to 150GB.
The VM picks up the change immediately:

How Has This Been Tested?
Yes, see above.
Checklist:

[X] I have read the CONTRIBUTING document.
[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
Testing
[ ] I have added tests to cover my changes.
[ ] All relevant new and existing integration tests have passed.
 I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2331

@blueorangutan test

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-3058)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33016 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2878-t3058-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 64 look OK, 3 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_03_vpc_privategw_restart_vpc_cleanup
Failure
1202.41
test_privategw_acl.py

test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL
Failure
398.20
test_vpc_redundant.py

test_02_VPC_default_routes
Failure
166.99
test_vpc_router_nics.py

Test LGTM, will merge this.


Add hack for fwdansi change.

This is a hack to fix a test failing on CI.
The issue is that fwdansi 1.1 was published with a change on how it processes reset codes. I have filed https://github.com/kennytm/fwdansi/issues/2 with some details on some of the issues.
This is just a workaround to get the test to pass.  I'm not too happy with it, but other choices seemed less than ideal.  Am happy to consider them, though:

Remove fwdansi, and give up supporting color on Win 7/8, old 10.
Change Shell so that it knows whether or not the console supports ANSI, and only use fwdansi when necessary.  This means Win 10 would stop using fwdansi, but 7/8 would continue to use it. It is a little awkward – I think it would have to call wincolor::set_virtual_terminal_processing and see if it succeeds.
Wait for a change to fwdansi to make resets more transparent.

I am very tempted by the first choice.  rustc's color output has been broken on win 7/8 for a long time, and only a very small number of people have complained.  I have spent way too much time dealing with something I think nobody really uses.
cc @kennytm

r? @Eh2406
(rust_highfive has picked a reviewer for you, use r? to override)

@bors: r+
FWIW I consider myself pretty un-versed on the intricacies of how all this works here, but I'm happy to defer to you! You've definitely been investigating and follow this far more than I have. I'd be down for perhaps radical (ish) things here to fix our support as well, but should probably happen in a separate issue

:pushpin: Commit 8149c7fbbf6414575b9b19453a2b127da3f435c0 has been approved by alexcrichton

@bors: p=100

:hourglass: Testing commit 8149c7fbbf6414575b9b19453a2b127da3f435c0 with merge 776ba5fc0bcb18460c8dabaced4ad7e3f60007d2...

:sunny: Test successful - checks-azure
Approved by: alexcrichton
Pushing 776ba5fc0bcb18460c8dabaced4ad7e3f60007d2 to master...


I got some error when I compile rmpe server.

I got this error.

It said "Could not find a configuration file for package "cppzmq" that is compatible
with requested version "".  "

same here


ml_pipeline not found

Hi, working with Rstudio 3.4.2 and Spark 2.2.0, "local" on Windows, trying to use ml_pipeline() function but looks like it is not there (even help doesn't find docs).
sc <- spark_connect(master = "local", spark_home = "c:\users\xxxxxxl\xxxx\spark",version="2.2.0")
library(dplyr)
library(sparklyr)

ml_pipeline()
Error in ml_pipeline() : could not find function "ml_pipeline"

@pierma63 are you using the development version of sparklyr? The pipeline feature isn't on CRAN yet.

Realized it wasn't in CRAN afterward, then used the dev version . Thanks


the argument list of signal is meaningless

Tested versions

Reproducible in: 4.3.stable, 4.2.2.stable

System information
Godot v4.3.stable - Windows 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4070 Ti (NVIDIA; <IP_ADDRESS>94) - 13th Gen Intel(R) Core(TM) i7-13700K (24 Threads)
Issue description
extends Control

signal test_signal
signal test_signal2
signal test_signal3(a, b, c, d, e, f, g)
signal test_signal4(a, b, c, d)

@onready var button: Button = $VBoxContainer/Button
@onready var button_2: Button = $VBoxContainer/Button2
@onready var button_3: Button = $VBoxContainer/Button3
@onready var button_4: Button = $VBoxContainer/Button4

func _ready():
    test_signal.connect(func(): print("test_signal"))
    test_signal2.connect(func(a): print("test_signal2:", a))
    test_signal3.connect(func(a, b): print("test_signal2:", a, b))
    test_signal4.connect(func(a, b, c): print("test_signal2:", a, b, c))

    button.pressed.connect(func(): test_signal.emit())
    button_2.pressed.connect(func(): test_signal2.emit(1))
    button_3.pressed.connect(func(): test_signal3.emit(1, 2))
    button_4.pressed.connect(func(): test_signal4.emit(1, 2, 3))

This code snippet can run without any error or warning. It seems that the signal object does not check the parameters when emit and connect. So, the argument list of signal is actually meaningless.
I think the number of parameters should at least be checked for correctness at compile time.
Steps to reproduce
see issue.
Minimal reproduction project (MRP)
signal-args.zip

Thank you for reporting, this is already tracked in:

https://github.com/godotengine/godot/issues/54333

We prefer to keep things in one place, so closing this


Instructions on how to build from source, please

And thank you.
Looks like colored is a git submodule, but there is no .gitmodules file present, so I cannot build pista from source. Instructions would also be a good idea, in general, even if it is trivial. That way others can know if they are overlooking something simple.

alright, i think its good to go now. i dont know why .gitmodules was not created when i did git submodule add.
to install rust and cargo,
$ curl https://sh.rustup.rs -sSf | sh
Rust is installed now. Great!

# check if you have the right version
$ rustc --version
rustc 1.36.0 (a53f9df32 2019-07-03)

# update if you dont have the right version
$ rustup update

to install pista from source,
$ git clone https://github.com/nerdypepper/pista --recurse-submodules
$ cargo install --path ./ --force

# check if pista is installed
$ ~/.cargo/bin/pista -V
Pista 0.1.2

it seems to be working fine on my linux vm, let me know if you need anything.

If you change cargo install --path ./ --force to cargo install --path pista --force then it will work, without having to add a cd pista in between. Thanks for creating this and staying on top of things.

ah thats right, ill fix that.
cheers!

I was looking for a BUILD file.
It is not so easy.
First, I had to use --recurse-submodules which is not trivial.
Second, and it is not explain even in this issue, I had to install "libssl-dev".


Update README.md

Added a blurb about Trello itself, and included additional examples.

coverage: 100.0%. remained the same
when pulling 53ed8168eba622b562190e2907828b9bc4821fc4 on jessat-readme-update
into dbae52854e46e86539653253302ef54b5bfbfeb5 on master.

Addresses #19


ks pkg install broken

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

kind bug

/kind feature

What happened:
ks pkg install  don't work with helm.
What you expected to happen:
working stuff
How to reproduce it (as minimally and precisely as possible):
➜   ks version
ksonnet version: 0.13.1
jsonnet version: v0.11.2
client-go version: kubernetes-1.10.4
➜   ks pkg install helm-stable/hlf-couchdb
INFO Retrieved 0 files
Anything else we need to know?:
previous version OK.
➜   ./ks pkg install helm-stable/hlf-couchdb
INFO Retrieved 11 files
➜   ./ks version
ksonnet version: 0.13.0
jsonnet version: v0.11.2
client-go version: kubernetes-1.10.4
Environment:
Mac OS

ksonnet version (use ks version):
Kubernetes version (use kubectl version):

previous version OK.
➜  hyperleger-test ./ks pkg install helm-stable/hlf-couchdb
INFO Retrieved 11 files
➜  hyperleger-test ./ks version
ksonnet version: 0.13.0
jsonnet version: v0.11.2
client-go version: kubernetes-1.10.4

Same problem here under linux, impossible to install packages at all.
I've also tried with the compiled version from the master branch from around  a week ago - same problem.
Details for my system are:
ksonnet version: dev-2019-02-02T00:03:55+0100
jsonnet version: v0.11.2
client-go version: kubernetes-1.10.4
go version go1.10.4 linux/amd64

Any hints for fixes would be greatly appreciated.

ksonnet version: 0.13.1
jsonnet version: v0.11.2
client-go version: kubernetes-1.10.4

Kubernetes version v1.13.2
looks like the KS client is ancient in KS terms xD. Maybe there is an incompatibility.

:crossed_fingers: kubeflow will switch to helm
The team behind ksonnet is stepping back from the project. As a result, work on ksonnet will end and the GitHub repositories will be archived. You can read more about our decision here.


Improve release process

The scripts and jar with dependencies should be automatically pushed to Github.
A docker image with the proper tag should be pushed to docker hub.

closing old issue


GET /opening-hours/dates/{servicePointId}/all-openings

Wrongly attributed in commit.  The commit closed #56, not this issue.


Monitor methods don't always execute in presence of Failures?

I've golfed this down from a much larger example in the Terminal::Print module, but this version is completely independent and self contained, and tested against both OO::Monitors 1.0 and 1.1 (both with 'no precompilation' at the top to take that out of the equation).
  These glitches seem to depend both on Grid being a monitor instead of a normal class, and the Failure creation (and defanging) in the inner loop.
There are also a couple occasional bugs that produce mysterious errors or outright crashes, also mentioned in the comments below.
use OO::Monitors;

# Only shows glitches when a monitor instead of a class
# class Grid {
monitor Grid {
    has $.w;
    has $.h;
    has @.grid;

    method change-cell($x, $y, $s) {
        @!grid[$y][$x] = $s;
    }

    # Very weird occasional crash bug if this is commented out:
    #    Cannot resolve caller infix:<div>(Nil, Int)
    # method Str() { '' }
}

my $w    = +q:x{ tput cols  };
my $h    = +q:x{ tput lines };
my $grid = Grid.new(:$w, :$h);

for ^10 {
    # Occasionally produces "Use of Nil in numeric context"
    $grid.grid = [ [ 'BUG' xx $grid.w ] xx $grid.h ];

    for ^$grid.h -> $y {
        for ^($grid.w div 2) -> $x {
            Failure.new() // '';  # Triggers glitches
            # Exception.new() // '';  # Doesn't glitch

            $grid.change-cell($x * 2,     $y, ' |');
            $grid.change-cell($x * 2 + 1, $y, ''  );
        }
    }

    # ANSI command here just makes image easier to watch, but can be removed
    print ^$h .map({ "\e[{ $_ + 1 };1H" ~ $grid.grid[$_].join });
    sleep 1;
}

So, the good news is that I can reproduce it. I've golfed it further to still get the errors, but eliminate most I/O and the sleep, to make it quicker/easier to examine, and a smaller test case.
use OO::Monitors;

# Only shows glitches when a monitor instead of a class
# class Grid {
monitor Grid {
    has $.w;
    has $.h;
    has @.grid;

    method change-cell($x, $y, $s) {
        @!grid[$y][$x] = $s;
    }

    # Very weird occasional crash bug if this is commented out:
    #    Cannot resolve caller infix:<div>(Nil, Int)
    # method Str() { '' }
}

my $w    = 90;
my $h    = 25;
my $grid = Grid.new(:$w, :$h);

for ^10 {
    $grid.grid = [ [ 'BUG' xx $grid.w ] xx $grid.h ];

    for ^$grid.h -> $y {
        for ^($grid.w div 2) -> $x {
            Failure.new() // '';  # Triggers glitches

            $grid.change-cell($x * 2,     $y, ' |');
            $grid.change-cell($x * 2 + 1, $y, ''  );
        }
    }

    die "BUG" if (^$h .map({ "\e[{ $_ + 1 };1H" ~ $grid.grid[$_].join })) ~~ /BUG/;
    say "OK";
}

So far, I've found:

It's not sensitive to any of the MoarVM dynamic optimization features (so, that excludes a whole class of issues)
It's not a data race because there's only a single thread running
It shows up both with and without precompilation
The number of iterations before the issue appears changes with small changes to the program
It's sensitive to how often we GC (tweaking GC nursery size moves iteration count; for example 15711 bytes reliably makes it produce BUG the first iteration)
However, none of our GC debugging mode, our fixed size allocator debug mode, or valgrind have anything to say about it

I've then started to gut OO::Monitors to see what elements produce the issue. I got it down to:
class MetamodelX::MonitorHOW is Metamodel::ClassHOW {
    method add_method(Mu \type, $name, $meth) {
        my &callsame := CORE::<&callsame>; # Workaround for RT #127858
        my $leaving = 0;
        $name ne 'BUILDALL' && $meth.wrap(-> \SELF, | {
            LEAVE $leaving++;
            callsame
        });
        self.Metamodel::ClassHOW::add_method(type, $name, $meth);
    }

    method compose(Mu \type) {
        self.Metamodel::ClassHOW::compose(type);
    }
}

my package EXPORTHOW {
    package DECLARE {
        constant monitor = MetamodelX::MonitorHOW;
    }
}

With a small GC nursery, commenting out the LEAVE line hides the BUG, though leaves the "Use of Nil in string context" reliably happening. Without the Failure being created, both are gone even with the Failure being produced.
Weird? Oh yes. Enough hunting for today, will continue tomorrow or Wednesday.

Tracked down to an issue involving callsame and finalizers, which is why Failure triggers it (it has a DESTROY method). Seems the LEAVE just made it a bit more likely to happen, but wasn't particularly involved. Fix ongoing in all of MoarVM/NQP/Rakudo.

Fixed in MoarVM/NQP/Rakudo HEAD. I managed to golf a reproduction all the way down to something that could be added as an integration test.


SOLR-16273: Prometheus Metric Exporter is very slow when collecting large amounts of sample data

https://issues.apache.org/jira/browse/SOLR-16273

Description
MetricFamilySamples from prometheus contains a List of samples and a "contains" check is called to avoid added duplicate metrics. With large lists, this reduces the prometheus exporters performance with large amounts of collections or lots of metrics scraping
Solution
Add in a Hashset into MetricSamples.java as a cache and cache the whole metric as a string and check against the cache instead of checking against the List with contains.
Tests
Update unit tests where cache is implemented and verify no duplicate samples were added to a metric family.
Checklist
Please review the following and check all that apply:

[x] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
[x] I have created a Jira issue and added the issue ID to my pull request title.
[x] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
[x] I have developed this patch against the main branch.
[x] I have run ./gradlew check.
[x] I have added tests for my changes.
[ ] I have added documentation for the Reference Guide

Hi everyone, this should be ready for review now.

Hello, is there any other additional comments or suggestions to review for improving this PR?

@dsmiley I noticed you've done some work with the prometheus exporter. Would you have any input for these changes?

@dsmiley Thanks for reviewing with suggestions. I made the changes accordingly.
Only part I did not change was for adding a higher level test.
I also thought about doing this earlier in development but getting duplicate metrics is caused from more than 1 collection. The current configuration for CloudScraperTest is using 1 collection so I would need to refactor all the tests with another collection and anything using that configuration so I felt that a unit test to catch the duplication was suffice and easiest to test for without potentially breaking tests.
I know you said it is not critical but if you feel strong on adding a high level test to catch duplication, I can go forward with that doing that.


Atom modifies random lines in files tracked by source control when saving.

Prerequisites

[ X] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
Atom modifies random lines throughout the file on save or CMD + s
Steps to Reproduce

Modify a line in a file which is being tracked in source control
Save the file
An unexpected line will appear as modified

Expected behavior: Only lines that have been manually modified should show a yellow indicator as being modified
Actual behavior: A line which was not modified by me shows as changed in source control after saving the file.
Reproduces how often: [Has happened to me on both my work and home laptops]
Versions
1.18.0
Additional Information

Actual line modified

Random line which shows as modified after CMD+S

And the resulting diff in version control

Without additional information, I am going to guess that Atom is removing trailing whitespace.  To turn off this feature, go into the Whitespace settings and disable the "Remove Trailing Whitespace" option.

I think that was the issue. Thanks


Remove 70s timeout for integration test to default 45s

Most integration tests should take between 1-2s max, with some outliers being closer to 10s. 45s is a safe max to allow for slow CI runners. 70s is too large and not appropriate for integration tests- tests which take this long should be moved to e2e.

/test-version-skew

I am happy to take this PR in master AFTER integration tests are stable.

I am happy to take this PR in master AFTER integration tests are stable.

Integration tests looks stable


Is it possible to run the framebuffer & UART example through qemu?

I am having trouble viewing both the framebuffer animation and connecting to the UART socket.
The command I am using to build is
./build.sh rpi3bp
And running qemu:
qemu-system-aarch64 -M raspi3b -kernel build/kernel.armc-014.rpi3bp.img -serial stdio
I care not so much about viewing the framebuffer but would like to see the output of the printf commands but nothing is spat out :/
Any help would be appreciated, thanks

Hi @F1r3Hydr4nt ,
Thanks for creating an issue. A few things, we do not compile for the aarch64 64-bit archtecure so you need to use qemu-system-arm instead to run a 32-bit kernel.
Also, we're using the mini uart which is not the default output for qemu, so we need to tweak the options a little bit to get the output of the UART we're using the tutorials. My qemu-system-arm version doesn't support raspi3b, so here I show the full emulation command I can use to get the graphics and UART output:
$ ./build.sh rpi1 && cd build

$ qemu-system-arm -M raspi1ap -kernel kernel.armc-014.rpi1 -serial null -serial mon:stdio

------------------------------------------
Valvers.com ARM Bare Metal Tutorials
Initialise UART console with standard libc
CORE Frequency: 700MHz
ARM  Frequency: 700MHz
Board Revision: 0x00900021 rpi-1A+ BCM2835 512MB Sony UK
Firmware Version: 346337
MAC Address: 52:54:00:12:34:57
Serial Number:<PHONE_NUMBER>000000
Initialised Framebuffer: 640x480 32bpp
Pitch: 2560 bytes
Framebuffer address: 1C100000

My intention was to do this in Part-6 so we don't have to use physical SD cards all the time! Let's get it in the tutorials to get everyone emulating.

Thanks for the swift response @BrianSidebotham
Another option I am considering for quick debugging is network booting, although I am putting this on the long finger until I get gdb running!
Cheers

Yes, it looks like gdb remote works OK for debugging.

:+1:

Works with qemu too!
If necessary for my objective will share aarch64 build instructions, thanks again.


We need more and better examples for this project (TZ-308)

Please consider urgently adding more examples for this project. The examples provided often don't work, have zero documentation / commenting and very limited functionality.
Combine that with the very poor documentation and this project becomes essentially unusable.
I'm very disappointed with this project overall. I'm a huge fan of the ESP32 products, and have used them for many years. I was very excited when Espressif first announced their Zigbee hardware, but two years later and two hardware releases and it seems it remains unusable in its current state.
Please urgently add some more examples with proper comments and documentation, in particular dealing with groups, scenes etc.

@baylf2000 Please find the current examples and documentation from the following links:
Examples: https://github.com/espressif/esp-zigbee-sdk/tree/main/examples
Documentation: https://docs.espressif.com/projects/esp-zigbee-sdk
Could you kindly review these resources and submit GitHub issues with specific requirements for the examples?

Hello @baylf2000,
We have added the necessary examples to the ESP-Zigbee-SDK, which should provide you with a lot of valuable insights into using the SDK. We encourage users to refer to these examples when developing their own projects. We have included comments for every user API, so please be patient when working with this SDK.
If you encounter any examples that frequently do not work, please let us know, and we will promptly address the issue.
For the group and scene cluster, we offer user APIs that you can find in the esp-zigbee-sdk. If you find these APIs insufficient, please create an issue to let us know.
Furthermore, if you have any questions or need support while using this SDK, please don't hesitate to open an issue here. We are committed to helping you resolve any concerns as quickly as possible.

@xieqinan @chshu
Here are my urgent suggestions:

The coordinator roles should be removed from all examples, especially the simple HA examples. Lights and Switches are NOT ever coordinators. There should be a simple standalone coordinator example.
Remove the complex LED functionality from the lighting examples. The example should toggle a pin HIGH/LOW at most. All that added complexity just makes the example difficult to understand and difficult to adapt to other purposes.
ALL examples should ALWAYS set model id and manufacturer name by default. Without those attributes set these examples won't work with common coordinators like zigbee2mqtt, which very many people use for testing.
Group handling is a very important aspect of properly designed Zigbee devices, yet there are NO examples anywhere in the Espressif SDK for handling group actions.
Overall the Espressif documentation in poor. Doxygen generated pages are of little help to users looking to get started. If you look at the documentation of your competitors like Silicon Labs, Nordic, Microchip etc, they all have advanced, detail documentation for their stacks. I understand Espressif has only recently entered this market, but the only way developers will start using your products is if you provide proper detailed English documentation.

I have been a HUGE fan of Espressif for a very long time. I really hope they can improve this aspect of their product, as if they do so I believe their 802.15.4 products will do just as well as their Wifi products, or even better.

@baylf2000 Thank you for your suggestions. Here is some feedback:

Initially, we did have a standalone coordinator example, but it required three devkits to set up the demo (coordinator, light, switch). So, we combined the coordinator and switch into a single example. It's easy to change the role by modifying the esp_zb_role configuration.

The light example works as-is with the LEDs on the devkit. You can simply replace it by integrating your own LED driver, for example: turn on/off.

Your suggestion is well-received, and we will add model IDs and manufacturer names to the examples.

Could you please create a new GitHub issue and describing your group use case? We will provide you with some code snippets to assist in unblocking your development.

We place a high value on documentation. Zigbee is a very mature protocol with a long history, and there are indeed many useful documents available. Our current documentation primarily focuses on the SDK itself. Please feel free to provide detailed requirements for further documentation improvements.

We look forward to collaborating with you on Zigbee SDK and products!

@chshu @xieqinan

1. Initially, we did have a standalone coordinator example, but it required three devkits to set up the demo (coordinator, light, switch). So, we combined the coordinator and switch into a single example.

I am certain you will find that customers looking to Zigbee aren't trying to have two dev kits communicate with each other. They are trying to have devices join to and communicate with existing networks.

It's easy to change the role by modifying the [esp_zb_role].

Unfortunately that is not all that is required. The switch/coordinator example does not allow the device to respond to requests for model id and manufacturer despite the correct additions to the basic cluster list, even after modifying the device to a router.

2. The light example works as-is with the LEDs on the devkit. You can simply replace it by integrating your own LED driver, for example: [turn on/off](https://github.com/espressif/esp-zigbee-sdk/blob/main/examples/esp_zigbee_HA_sample/HA_on_off_light/main/esp_zb_light.c#L88).

If you want to keep those examples, that's great. However I strongly suggest adding simpler examples without all the extra code required to deal with the LEDS.

4. Could you please create a new GitHub issue and describing your group use case? We will provide you with some code snippets to assist in unblocking your development.

Sir I've provided all the information required already. Simple use cases for allowing a device to join to, be removed from and operate as part of a Zigbee group. I can't be any more detailed than that.

5. We place a high value on documentation. Zigbee is a very mature protocol with a long history, and there are indeed many useful documents available. Our current documentation primarily focuses on the SDK itself. Please feel free to provide detailed requirements for further documentation improvements.

I'm sorry, but what you have produced so far suggest you place little value at all on documentation. Your current "documentation" is almost entirely auto-generated Doxygen files, generated from poorly commented header files only. Even the most experienced developers will struggle as they are unable to work around the poor documentation by examining detailed source code due to the use of binary libraries. This is not acceptable for a company hoping to sell their devices to international developers.
May I suggest you take a look at https://www.nxp.com/pages/jn516x-7x-zigbee-3-0:ZIGBEE-3-0, and from there, for example  https://www.nxp.com/docs/en/user-guide/JN-UG-3113.pdf. These are properly documented products. SL, TI, Microchip and others all have very detailed, written documentation on all aspects of their Zigbee offerings, not auto-generated Doxygen files.


first implem of recursive search

There is also small formating issues, you can use cargo fmt to fix that: https://github.com/rust-lang-nursery/rustfmt

Now, just abstract that between a:
fn get_objs_and_deps<R, F>(reader: &mut OsmPbfReader<R>, pred: F) -> Result<HashMap<OsmId, OsmObj>>
    where R: Read + Seek,
          F: FnMut(&OsmObj) -> bool
{
   unimplemented!()
}

See http://texitoi.github.io/osmpbfreader-rs/osmpbfreader/index.html for error handling.


Add validation for valid UTF-8 in BadgeApp

Cover justitication & other fields like names.

Some helpful info maybe at http://stackoverflow.com/questions/8635578/how-to-check-whether-the-character-is-utf-8

Done!


More Content and Polish for Whats New

For #2892

Add more gifs and images for new layers
Add glTF section
Fix formatting

Coverage remained the same at 62.483% when pulling bb449d82a218435ae69d291c819914f50af0615d on tgorkin/whats-new into ec7fe2b89ee21fa14e876274977c0157b5d63cd0 on master.


AXIS variables

Couldn't find AXIS variables, like for example AXIS_FLAPS_SET, is this intentional? Can they be added?

I don't see those listed in the SDK docs (https://docs.flightsimulator.com/html/Programming_Tools/SimVars/Simulation_Variables.htm), can you point me in the right direction?


Can't have multiple vue-draggable components on same page

Describe the bug
When multiple components on the same page contain v-drag-and-drop directives, events are fired in the context of the last such component on the page rather than the one where the interaction occurs.
To Reproduce
Following codesandbox (forked from one of the examples) demonstrates this behavior: https://codesandbox.io/s/o4vv7qz52z
In this fork, the main App.vue contains two components:
  <VueDraggable id="vd1"/>
  <VueDraggable id="vd2"/>

Inside VueDraggable.vue, an onDrop event handler is registered like this:
  options: {
    reactivityEnabled: true,
    onDrop: event => {
      console.log("onDrop fired", event, this.$el);
    }
  }

Expected behavior
When dragging items within the first (top) component, it is expected that this.$el in the console log references
, and in the second (bottom) component it should reference
.
However, in fact this in the event handler always references the second component (with
).

Additional context
I'm not sure if this is related to #12. The symptoms are different - this does refer to the Vue component, just the wrong one. And the solution linked in that issue doesn't help.

Hi @sgarner,
Thanks for the feedback.
I'll check this and let you know if anything changes.

Hi @sgarner,
I've published new version 2.0.1 which should fix the issue.
Tested on your CodeSandbox example and everything works as expected.
Please, check updated version and let me know if you have further issues.
Thanks again for the feedback. :)

I have a similar problem!
In the codesandbox that I changed a little bit to have two instance components (and the vue-draggable is in the 2.0.0 version), and the drag and drop between the elements from the instances work as expected.
But in my Vue project, that the vue-draggable is in 2.0.3 version, the drag between the two instances doesn't work.
In the onDragend sometimes the droptarget is null, sometimes the droptarget is the same origin where I pick the element, which is wrong.


How to pass in extra configuration to ssh?

Hi
I am just wondering how do I pass in extra configuration flag when I use this? Suppose I want to pass in the -i flag or -o flag while using sshcode?

i do beleive there is a flag for that, check --help

It seems like there is this --ssh-flags option to pass in extra configs.


Unable to access jar file?

I know nothing about GitHub or coding so I'm sorry if I'm missing something really obvious. I tried renaming the folder and moving it from downloads to desktop but I can't get anything to work. What am I doing wrong?

Hey, you probably want to download the .jar file from here: https://github.com/MaxiHuHe04/iTunes-Backup-Explorer/releases/latest. You get a single file which you can run using the java -jar command.
If you have an M1/M2 Mac and this gives you some error message like "incompatible architecture" or "UnsatisfiedLinkError", download and install another Java distribution from here: https://www.azul.com/downloads/?version=java-21-lts&os=macos&architecture=arm-64-bit&package=jdk-fx#zulu.

Thank you!
I'm getting "UnsatisfiedLinkError" after downloading the Java distribution and I think it's because I'm not sure how to properly install it. It's downloaded to my desktop but no Setup Wizard shows up when I double click the folder; only the folder's contents show up. Entering "<zulu21.30.15-ca-fx-jdk21.0.1-macosx_aarch64>/bin/java -version21.0.1" yields "Operation not permitted" and "<installation_folder/bin/java -version21.0.1" yields "No such file or directory." Do you know what I'm doing wrong?

I don't have a Mac, so I can't try. But you probably want to select the .dmg file instead of .zip/.tar.gz when downloading Zulu. Here is an installation guide: https://docs.azul.com/core/zulu-openjdk/install/macos


[OCPCLOUD-1496] Add tests for updating status of ControlPlaneMachineSet

This PR adds some additional testing around the status updates to dictate how the log messages will be output when updates are and aren't required.

/test all


PKCS #11 MISRA Fixes

This commit contains various MISRA fixes and logic refactors.
Some MISRA violations that were fixed:
* 8.7
* 20.7
* 21.16
* 7.2
* 8.3
* 8.4
* 8.6
* 8.7
* 8.9
* 16.3
* 17.7
* 12.1
* 13.1
* 14.2
* 14.3
* 14.4
* 15.7
* 16.1
* 11.4
* 10.4

Description

Checklist:

[ ] I have tested my changes. No regression in existing tests.
[ ] My code is Linted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/bot run checks

/bot run checks

The suppression of misra_c_2012_rule_10_5_violation occurs 53 times, like this one:
- CK_BBOOL xResult = CK_FALSE;
+ /* coverity[misra_c_2012_rule_10_5_violation] */
+ CK_BBOOL xResult = ( CK_BBOOL ) CK_FALSE;

Wouldn't it be better to add unsigned definitions of true and false?
    #define CK_FALSE_UNSIGNED  0U
    #define CK_TRUE_UNSIGNED   1U

The suppression of misra_c_2012_rule_10_5_violation occurs 53 times, like this one:
- CK_BBOOL xResult = CK_FALSE;
+ /* coverity[misra_c_2012_rule_10_5_violation] */
+ CK_BBOOL xResult = ( CK_BBOOL ) CK_FALSE;

Wouldn't it be better to add unsigned definitions of true and false?
    #define CK_FALSE_UNSIGNED  0U
    #define CK_TRUE_UNSIGNED   1U

Addition:
    #define CK_FALSE_UNSIGNED  ( ( CK_BBOOL ) 0U )
    #define CK_TRUE_UNSIGNED   ( ( CK_BBOOL ) 1U )

should also avoid the need for a cast.

These definitions are from the PKCS #11 standard.
The exception from MISRA:
"An integer constant expression with the value 0 or 1 of either signedness may be cast to a type which is defined as essentially Boolean. This allows the implementation of non-C99 Boolean models."
It would be best to use the standard, rather than implementing new data types in my opinion

/bot run checks

@gkwicker @aggarg apologies, I had to rebase to bring in the latest uncrustify config.

/bot run checks


linux cannot download Python-Language-Server 0.5.31

0.5.31 is available for osx and win, but linux still seems to be 0.5.30.
osx stable
https://pvsc.blob.core.windows.net/python-language-server-stable?restype=container&comp=list&prefix=Python-Language-Server-osx-x64
win stable
https://pvsc.blob.core.windows.net/python-language-server-stable?restype=container&comp=list&prefix=Python-Language-Server-win-x64
linux stable  0.5.31 missing
https://pvsc.blob.core.windows.net/python-language-server-stable?restype=container&comp=list&prefix=Python-Language-Server-linux-x64

This should be fixed.


[Doc Improvement][Teams Store branding updates - II][3315913]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/build-and-test/debug.md
92
8
link
:white_check_mark:

msteams-platform/concepts/build-and-test/deep-link-application.md
92
16
link
:white_check_mark:

msteams-platform/concepts/build-and-test/manage-your-apps-in-developer-portal.md
96
12
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/add-default-install-scope.md
92
4
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/apps-publish-overview.md
100
0
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/apps-upload.md
97
3
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/common-reasons-for-app-validation-failure.md
92
18
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/app-growth/app-growth-lifecycle.md
94
6
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/app-growth/gain-traction.md
91
22
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/app-growth/launch-app.md
91
29
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/app-growth/scale-app.md
89
25
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/overview.md
90
13
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/teams-store-ranking-parameters.md
100
0
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/create-partner-center-dev-account.md
93
7
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/publish.md
92
14
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/resolve-submission-issues.md
91
6
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/build-and-test/debug.md
92
8
link
:white_check_mark:

msteams-platform/concepts/build-and-test/deep-link-application.md
92
16
link
:white_check_mark:

msteams-platform/concepts/build-and-test/manage-your-apps-in-developer-portal.md
96
12
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/add-default-install-scope.md
92
4
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/apps-publish-overview.md
100
0
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/apps-upload.md
97
3
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/common-reasons-for-app-validation-failure.md
92
18
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/app-growth/app-growth-lifecycle.md
94
6
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/app-growth/gain-traction.md
91
22
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/app-growth/launch-app.md
91
29
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/app-growth/scale-app.md
89
25
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/overview.md
90
13
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/teams-store-ranking-parameters.md
100
0
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/create-partner-center-dev-account.md
93
7
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/end-user-purchase-experience.md
100
3
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/include-saas-offer.md
93
14
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/monetize-overview.md
100
1
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/submission-checklist.md
95
26
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/publish.md
92
14
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/resolve-submission-issues.md
91
6
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/build-and-test/debug.md
92
8
link
:white_check_mark:

msteams-platform/concepts/build-and-test/deep-link-application.md
92
16
link
:white_check_mark:

msteams-platform/concepts/build-and-test/manage-your-apps-in-developer-portal.md
96
12
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/add-default-install-scope.md
92
4
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/apps-publish-overview.md
100
0
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/apps-upload.md
97
3
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/common-reasons-for-app-validation-failure.md
92
18
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/app-growth/app-growth-lifecycle.md
94
6
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/app-growth/gain-traction.md
91
22
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/app-growth/launch-app.md
91
29
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/app-growth/scale-app.md
89
25
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/overview.md
90
13
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/teams-store-ranking-parameters.md
100
0
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/Test-preview-for-monetized-apps.md
98
1
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/create-partner-center-dev-account.md
93
7
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/end-user-purchase-experience.md
100
3
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/include-saas-offer.md
93
14
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/monetize-overview.md
100
1
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/submission-checklist.md
95
26
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/teams-store-validation-guidelines.md
94
100
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/publish.md
92
14
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/resolve-submission-issues.md
91
6
link
:white_check_mark:

msteams-platform/concepts/design/design-teams-app-artwork-store.md
91
3
link
:white_check_mark:

msteams-platform/concepts/design/design-teams-app-fundamentals.md
100
0
link
:white_check_mark:

msteams-platform/concepts/design/design-teams-app-icon-store-appbar.md
94
5
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/build-and-test/debug.md
92
8
link
:white_check_mark:

msteams-platform/concepts/build-and-test/deep-link-application.md
92
16
link
:white_check_mark:

msteams-platform/concepts/build-and-test/manage-your-apps-in-developer-portal.md
96
12
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/add-default-install-scope.md
92
4
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/apps-publish-overview.md
100
0
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/apps-upload.md
97
3
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/common-reasons-for-app-validation-failure.md
92
18
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/app-growth/app-growth-lifecycle.md
94
6
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/app-growth/gain-traction.md
91
22
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/app-growth/launch-app.md
91
29
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/app-growth/scale-app.md
89
25
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/overview.md
90
13
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/teams-store-ranking-parameters.md
100
0
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/Test-preview-for-monetized-apps.md
98
1
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/create-partner-center-dev-account.md
93
7
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/end-user-purchase-experience.md
100
3
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/include-saas-offer.md
93
14
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/monetize-overview.md
100
1
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/submission-checklist.md
95
26
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/teams-store-validation-guidelines.md
94
100
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/publish.md
92
14
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/resolve-submission-issues.md
91
6
link
:white_check_mark:

msteams-platform/concepts/design/design-teams-app-artwork-store.md
91
3
link
:white_check_mark:

msteams-platform/concepts/design/design-teams-app-fundamentals.md
100
0
link
:white_check_mark:

msteams-platform/concepts/design/design-teams-app-icon-store-appbar.md
94
5
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/build-and-test/debug.md
92
8
link
:white_check_mark:

msteams-platform/concepts/build-and-test/deep-link-application.md
92
16
link
:white_check_mark:

msteams-platform/concepts/build-and-test/manage-your-apps-in-developer-portal.md
96
12
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/add-default-install-scope.md
92
4
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/apps-publish-overview.md
100
0
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/apps-upload.md
97
3
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/common-reasons-for-app-validation-failure.md
92
18
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/app-growth/app-growth-lifecycle.md
94
6
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/app-growth/gain-traction.md
91
22
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/app-growth/launch-app.md
91
29
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/app-growth/scale-app.md
89
25
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/overview.md
90
13
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/teams-store-ranking-parameters.md
100
0
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/Test-preview-for-monetized-apps.md
98
1
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/create-partner-center-dev-account.md
93
7
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/end-user-purchase-experience.md
100
3
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/include-saas-offer.md
93
14
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/monetize-overview.md
100
1
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/submission-checklist.md
95
26
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/teams-store-validation-guidelines.md
94
100
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/publish.md
92
14
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/resolve-submission-issues.md
91
6
link
:white_check_mark:

msteams-platform/concepts/design/design-teams-app-artwork-store.md
91
3
link
:white_check_mark:

msteams-platform/concepts/design/design-teams-app-fundamentals.md
100
0
link
:white_check_mark:

msteams-platform/concepts/design/design-teams-app-icon-store-appbar.md
94
5
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/build-and-test/debug.md
92
8
link
:white_check_mark:

msteams-platform/concepts/build-and-test/deep-link-application.md
92
16
link
:white_check_mark:

msteams-platform/concepts/build-and-test/manage-your-apps-in-developer-portal.md
96
12
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/add-default-install-scope.md
92
4
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/apps-publish-overview.md
100
0
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/apps-upload.md
97
3
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/common-reasons-for-app-validation-failure.md
92
18
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/app-growth/app-growth-lifecycle.md
94
6
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/app-growth/gain-traction.md
91
22
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/app-growth/launch-app.md
91
29
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/app-growth/scale-app.md
89
25
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/overview.md
90
13
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/teams-store-ranking-parameters.md
100
0
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/Test-preview-for-monetized-apps.md
98
1
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/create-partner-center-dev-account.md
93
7
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/end-user-purchase-experience.md
100
3
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/include-saas-offer.md
93
14
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/monetize-overview.md
100
1
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/submission-checklist.md
95
26
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/teams-store-validation-guidelines.md
94
100
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/publish.md
92
14
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/resolve-submission-issues.md
91
6
link
:white_check_mark:

msteams-platform/concepts/design/design-teams-app-artwork-store.md
91
3
link
:white_check_mark:

msteams-platform/concepts/design/design-teams-app-fundamentals.md
100
0
link
:white_check_mark:

msteams-platform/concepts/design/design-teams-app-icon-store-appbar.md
94
5
link
:white_check_mark:

msteams-platform/toolkit/publish.md
96
5
link
:white_check_mark:

msteams-platform/toolkit/toolkit-v4/publish-v4.md
94
6
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/build-and-test/debug.md
92
8
link
:white_check_mark:

msteams-platform/concepts/build-and-test/deep-link-application.md
92
16
link
:white_check_mark:

msteams-platform/concepts/build-and-test/manage-your-apps-in-developer-portal.md
96
4
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/add-default-install-scope.md
92
4
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/apps-publish-overview.md
100
0
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/apps-upload.md
97
2
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/common-reasons-for-app-validation-failure.md
93
13
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/app-growth/app-growth-lifecycle.md
94
5
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/app-growth/gain-traction.md
91
21
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/app-growth/launch-app.md
91
26
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/app-growth/scale-app.md
89
20
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/overview.md
90
10
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/teams-store-ranking-parameters.md
100
0
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/Test-preview-for-monetized-apps.md
98
1
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/create-partner-center-dev-account.md
93
5
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/end-user-purchase-experience.md
98
1
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/include-saas-offer.md
93
9
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/monetize-overview.md
100
0
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/submission-checklist.md
95
6
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/prepare/teams-store-validation-guidelines.md
94
78
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/publish.md
92
13
link
:white_check_mark:

msteams-platform/concepts/deploy-and-publish/appsource/resolve-submission-issues.md
91
6
link
:white_check_mark:

msteams-platform/concepts/design/design-teams-app-artwork-store.md
91
3
link
:white_check_mark:

msteams-platform/concepts/design/design-teams-app-fundamentals.md
100
0
link
:white_check_mark:

msteams-platform/concepts/design/design-teams-app-icon-store-appbar.md
94
5
link
:white_check_mark:

msteams-platform/toolkit/publish.md
96
3
link
:white_check_mark:

msteams-platform/toolkit/toolkit-v4/publish-v4.md
94
4
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.


hi sir...!!!

sir i have a question..!!! please can u tell me how to send the processed data from the server to client via using ratchet . i mean how to send the data from server or after performing the function's on the php side.

there is a send method on the ConnectionInterface: https://github.com/ratchetphp/Ratchet/blob/master/src/Ratchet/ConnectionInterface.php


:zap: GitHub GraphQL API

This PR replaces queries to GitHub's REST API by a single GraphQL query.
The REST API required additional queries for nested attributes. In particular, we needed one query per contributor to extract user information. This resulted in extremely slow performances for large open-source projects.
Improvements:
When using the GraphQL endpoint, we can specify the desired schema of the response with a single query. This provides a major speedup proportional to the number of contributors in the target repository (e.g., query time for Renku: 1.04s instead of 38.7s with REST).
Caveats (so far):

Contributors are not available in GraphQL. I used mentionableUsers instead. In cases where the repo belongs to an organization, this will include all organization members.
mentionableUsers, user organizations (affiliations) and repositoryTopics are paginated (note this is also the case in the REST API). This is currently set to arbitrary thresholds (100 for contributors and affiliations, 10 for topics).
Token authentication is mandatory (while REST allowed for 60 unauthenticated requests).

Example pre-PR output
@prefix schema: <http://schema.org/> .
@prefix xsd: <http://www.w3.org/2001/XMLSchema#> .

<https://github.com/SDSC-ORD/gimie> a schema:SoftwareSourceCode ;
    schema:CodeRepository "https://github.com/SDSC-ORD/gimie" ;
    schema:author <https://api.github.com/orgs/SDSC-ORD> ;
    schema:contributor <https://api.github.com/users/cmdoret>,
        <https://api.github.com/users/martinfontanet>,
        <https://api.github.com/users/rmfranken>,
        <https://api.github.com/users/sabinem>,
        <https://api.github.com/users/sabrinaossey> ;
    schema:dateCreated "2022-12-07"^^xsd:date ;
    schema:dateModified "2023-01-31"^^xsd:date ;
    schema:description "Extract linked metadata from repositories"^^xsd:string ;
    schema:downloadUrl "https://api.github.com/repos/SDSC-ORD/gimie/tarball" ;
    schema:keywords "fair-data"^^xsd:string,
        "git"^^xsd:string,
        "linked-open-data"^^xsd:string,
        "metadata-extraction"^^xsd:string,
        "python"^^xsd:string,
        "scientific-software"^^xsd:string ;
    schema:license "https://spdx.org/licenses/Apache-2.0" ;
    schema:name "SDSC-ORD/gimie"^^xsd:string ;
    schema:programmingLanguage "Makefile"^^xsd:string,
        "Python"^^xsd:string ;
    schema:version "v0.2.0"^^xsd:string .

<https://api.github.com/orgs/SwissDataScienceCenter> a schema:Organization ;
    schema:description "An ETH Domain initiative for accelerating the adoption of data science" ;
    schema:name "SwissDataScienceCenter" .

<https://api.github.com/orgs/koszullab> a schema:Organization ;
    schema:description "" ;
    schema:name "koszullab" .

<https://api.github.com/users/cmdoret> a schema:Person ;
    schema:affiliation <https://api.github.com/orgs/SDSC-ORD>,
        <https://api.github.com/orgs/SwissDataScienceCenter>,
        <https://api.github.com/orgs/koszullab> ;
    schema:identifier "cmdoret" ;
    schema:name "Cyril Matthey-Doret" .

<https://api.github.com/users/martinfontanet> a schema:Person ;
    schema:affiliation <https://api.github.com/orgs/SDSC-ORD> ;
    schema:identifier "martinfontanet" .

<https://api.github.com/users/rmfranken> a schema:Person ;
    schema:identifier "rmfranken" .

<https://api.github.com/users/sabinem> a schema:Person ;
    schema:affiliation <https://api.github.com/orgs/SDSC-ORD> ;
    schema:identifier "sabinem" ;
    schema:name "Sabine Maennel" .

<https://api.github.com/users/sabrinaossey> a schema:Person ;
    schema:identifier "sabrinaossey" ;
    schema:name "sabrinaossey" .

<https://api.github.com/orgs/SDSC-ORD> a schema:Organization ;
    schema:description "" ;
    schema:legalName "Swiss Data Science Center - ORD" ;
    schema:logo <https://avatars.githubusercontent.com/u/114115753?v=4> ;
    schema:name "SDSC-ORD" .

Example post-PR output
@prefix schema: <http://schema.org/> .
@prefix xsd: <http://www.w3.org/2001/XMLSchema#> .

<https://github.com/SDSC-ORD/gimie> a schema:SoftwareSourceCode ;
    schema:CodeRepository "https://github.com/SDSC-ORD/gimie" ;
    schema:author <https://github.com/SDSC-ORD> ;
    schema:contributor <https://github.com/caviri>,
        <https://github.com/cmdoret>,
        <https://github.com/ksanao>,
        <https://github.com/martinfontanet>,
        <https://github.com/rmfranken>,
        <https://github.com/sabinem>,
        <https://github.com/sabrinaossey>,
        <https://github.com/supermaxiste> ;
    schema:dateCreated "2022-12-07"^^xsd:date ;
    schema:dateModified "2023-01-31"^^xsd:date ;
    schema:description "Extract linked metadata from repositories"^^xsd:string ;
    schema:downloadUrl "https://github.com/SDSC-ORD/gimie/archive/refs/tags/v0.2.0.tar.gz" ;
    schema:keywords "fair-data"^^xsd:string,
        "git"^^xsd:string,
        "linked-open-data"^^xsd:string,
        "metadata-extraction"^^xsd:string,
        "python"^^xsd:string,
        "scientific-software"^^xsd:string ;
    schema:license "https://spdx.org/licenses/Apache-2.0" ;
    schema:name "SDSC-ORD/gimie"^^xsd:string ;
    schema:programmingLanguage "Python"^^xsd:string ;
    schema:version "v0.2.0"^^xsd:string .

<https://github.com/EPFL-Data-Champions> a schema:Organization ;
    schema:description "Cross-disciplinary community around research data, voluntary EPFL's researchers and staff with keen interest in research data." ;
    schema:legalName "EPFL Data Champions" ;
    schema:logo <https://avatars.githubusercontent.com/u/78474394?v=4> ;
    schema:name "EPFL-Data-Champions" .

<https://github.com/caviri> a schema:Person ;
    schema:affiliation <https://github.com/SDSC-ORD> ;
    schema:identifier "caviri" ;
    schema:name "Carlos Vivar Rios" .

<https://github.com/cmdoret> a schema:Person ;
    schema:affiliation <https://github.com/EPFL-Data-Champions>,
        <https://github.com/SDSC-ORD>,
        <https://github.com/SwissDataScienceCenter>,
        <https://github.com/koszullab> ;
    schema:identifier "cmdoret" ;
    schema:name "Cyril Matthey-Doret" .

<https://github.com/koszullab> a schema:Organization ;
    schema:description "" ;
    schema:legalName "Romain Koszul Laboratory" ;
    schema:logo <https://avatars.githubusercontent.com/u/9391430?v=4> ;
    schema:name "koszullab" .

<https://github.com/ksanao> a schema:Person ;
    schema:affiliation <https://github.com/SDSC-ORD>,
        <https://github.com/SwissDataScienceCenter> ;
    schema:identifier "ksanao" ;
    schema:name "Oksana Riba Grognuz" .

<https://github.com/martinfontanet> a schema:Person ;
    schema:affiliation <https://github.com/SDSC-ORD>,
        <https://github.com/SwissDataScienceCenter> ;
    schema:identifier "martinfontanet" .

<https://github.com/rmfranken> a schema:Person ;
    schema:affiliation <https://github.com/SDSC-ORD> ;
    schema:identifier "rmfranken" .

<https://github.com/sabinem> a schema:Person ;
    schema:affiliation <https://github.com/SDSC-ORD> ;
    schema:identifier "sabinem" ;
    schema:name "Sabine Maennel" .

<https://github.com/sabrinaossey> a schema:Person ;
    schema:affiliation <https://github.com/SDSC-ORD>,
        <https://github.com/SwissDataScienceCenter> ;
    schema:identifier "sabrinaossey" ;
    schema:name "sabrinaossey" .

<https://github.com/supermaxiste> a schema:Person ;
    schema:affiliation <https://github.com/SDSC-ORD> ;
    schema:identifier "supermaxiste" .

<https://github.com/SwissDataScienceCenter> a schema:Organization ;
    schema:description "An ETH Domain initiative for accelerating the adoption of data science" ;
    schema:legalName "Swiss Data Science Center" ;
    schema:logo <https://avatars.githubusercontent.com/u/25008760?v=4> ;
    schema:name "SwissDataScienceCenter" .

<https://github.com/SDSC-ORD> a schema:Organization ;
    schema:description "" ;
    schema:legalName "Swiss Data Science Center - ORD" ;
    schema:logo <https://avatars.githubusercontent.com/u/114115753?v=4> ;
    schema:name "SDSC-ORD" .

Great, it looks wonderful. The only problem I faced was related to the scope of the Token.
It's necessary to add read:org to the Token, while the actual gimie version can run with the default token. I would recommend that this should be added to README.md.
I also saw in the graphQL query a limit on the number of mentionableUsers(first: 100), organizations(first: 100), and repositoryTopics(first: 10). Maybe this should be a parameter or at least declared? Is there any similar limit in the actual gimie version?
The speed achieved is impressive. Great work.

I've been doing some research on mentionableUsers and its definition seems quite obscure in GH documentation: A list of Users that can be mentioned in the context of the repository. The fact that contributors are mixed in an organization's repos is undesired. What do you think about having both methods depending if the repo belongs to a user vs. an organization?

Great, it looks wonderful. The only problem I faced was related to the scope of the Token.
It's necessary to add read:org to the Token, while the actual gimie version can run with the default token. I would recommend that this should be added to README.md.
I also saw in the graphQL query a limit on the number of mentionableUsers(first: 100), organizations(first: 100), and repositoryTopics(first: 10). Maybe this should be a parameter or mentioned in the README? Is there any similar limit in the actual gimie version?
The speed achieved is impressive. Great work.

Yes, the REST API is paginated so the current version of gimie would also have this issue. We could work around this by adding logic for pagination (multiple queries with limit + offset) but this would be a story for another day ;)
Adding it + the required token scope in the README is a good idea!

@caviri OK it looks like we're now getting the actual contributors. :tada:
Main changes:

Get list of commit (by batches due to pagination of GraphQL API)
Retrieve set of committers (aka contributor)
Fetch metadata about each contributor
Added tests/test_github.py for integration test on a few repositories with different setups

What do you think?

:rocket: Managed to restore full speed using a combination of GraphQL and REST:

Query list of contributor IDs with REST (1 query) -> select node_id from the response
Query GraphQL for the list of nodes with ids: $node_ids. Fortunately REST's node_id matches GraphQL ids!

So in two queries we get deep metadata about all contributors! It takes 2.5s for Renku (vs 38s with REST).


Breadcrumb support/example

Add an example for breadcrumb from current site tree defined, and current "active" item found.
Should be possible right?
I am wondering if the data for this tree could also be coming from a DB and GUI backend
Where you define it via DB tables and Tree behavior and then just let it generate the "menu" tree of the library, and let it then match/work.
Would that make sense for a larger app with many controllers? As it could auto-find possible Tree items and then propose already a CRUD default. Then you just need to arrange and customize it.

Sure, that should be possible, the helper doesn't care about where the data comes from, I have for example a CMS running where the menu structure can be built in the backend, which the helper uses to generate the menu.
It's just a matter of configuration, and overcoming possible limitations with regards to rendering, like for example adding screen reader only data for active items (that's of course not limited to breadcrumbs).
I'm not sure though what exactly you're asking for with regards to the support/example? Support for gathering site tree information? An example that builds a navigation from dynamic data?

Last part, an example in docs here, would suffice for most cases.

I see. I'm not really sure what such an example should look like, I can't think of anything other than iterating over a set of records, but is that really something that needs to be explained? Maybe for threaded data an example of nested iterating would be helpful.
Do you have any specific problems in mind that should be covered?

Well, I saw some open PRs on the main repo that haven't been processed for some reason

https://github.com/KnpLabs/KnpMenu/pull/257

but I also saw that there is already existing functionality inside, e.g. https://github.com/KnpLabs/KnpMenu/blob/13e3e32946e24427fdc8074eda7d704f6e4b28e7/src/Knp/Menu/Util/MenuManipulator.php#L225

Oh, so you're talking about creating breadcrumbs from an existing menu?
Ie when you have a menu with nested items, and want to create breadcrumbs for a specific path, being it the path of a manually chosen node, or the one that holds the current active item (assuming the menu is configured in a such a way that there is only a single active item)?

That is now the question. If the docs could recommend a strategy, e.g. when you have the active item, and thus the path back to the root element.
I think one then just passes it on to the Html helper method and it should work this way.

I'll have a look at it, surely the menu helper could provide functionality to assist with that, like extracting paths, finding the active item, etc.

Ok, this revealed quite some flaws, given that the "current" state of an item isn't stored in the menu items themselves (unless marked manually) but in the matcher, being able to retrieve the current item would require quite some changes so that the helper retains the matcher used for the menu. This won't play nicely with custom renderers, and it might require the menu to be rendered first in any case, as people are allowed to pass custom matchers to render().
There seems to have been quite some discussion about retrieving the current item over at the KnpMenu repository, and the consensus seems to be to iterate over all menu items and issue matching checks (again), using the matcher that is used for rendering the menu.
Furthermore for a breadcrumb navigation, I certainly see the possibility that people would like to include the menus root item, however it's currently not possible to pass menu item specific configuration options to that item.
That's quite some problems that need to be solved carefully in order to not create lots of side effects and possibly more problems further down the road. Long story short, it will unfortunately take some time 😞

Looking at this further, I think support for determining the current item will need to be split into minor an major changes.
As a first step in the next minor, determining the current item by matching again (ie no matcher reuse unless the matcher is created and passed manually) could be introduced (to be fair, it's relatively inexpensive, matching through 1000 items with the UriVoter takes about 0.0006 seconds on my not overly optimized dev machine).
In a second step in the next major, which would take some more time, reusing matchers could be introduced, which will require quite some breaking changes.

If you're interested, here's a first implementation for extracting paths and retrieving the current item:
https://github.com/icings/menu/tree/4.x/feature/paths-and-current-item
Quick example, say you have a menu like this:
$mainMenu = $this->Menu->create('main');
$mainMenu->addChild('Library', ['uri' => ['controller' => 'Library', 'action' => 'index']]);
$mainMenu['Library']->addChild('Web', ['uri' => ['controller' => 'Web', 'action' => 'index']]);
$mainMenu['Library']['Web']->addChild('Data', ['uri' => ['controller' => 'Data', 'action' => 'index']]);
$mainMenu->addChild('Projects', ['uri' => ['controller' => 'Projects', 'action' => 'index']]);
$mainMenu->addChild('Settings', ['uri' => ['controller' => 'Settings', 'action' => 'index']]);
// ...

You could extract/create a breadcrumbs navigation from it based on the current item like this:
$crumbs = [];
$currentItem = $this->Menu->getCurrentItem('main');
if ($currentItem) {
    $crumbs = $this->Menu->extractPath($currentItem);
}

$crumbsMenu = $this->Menu->create('breadcrumbs', [
    'templates' => [
        'menu' => '
{{items}}
',
    ],
    'currentAsLink' => false,
]);

$crumbsMenu->addChild('Home', ['uri' => ['controller' => 'Pages', 'action' => 'display', 'home']]);
foreach ($crumbs as $crumb) {
    $crumbsMenu->addChild($crumb);
}

As can be seen, an additional Home item is prepended for the crumbs navigation. Often breadcrumb navigations do have a "Home" entry, however as mentioned earlier, the root item of a menu currently isn't configurable via the menu creation options, and I'm not sure whether it actually should be, as it kind of represents the menu wrapper element, not a menu entry element.
Assuming the Data item is the current item, the above example would render the following HTML for the breadcrumbs menu:

        Home

        Library

        Web

        Data

I am currently thinking of using a DB backend and build in your plugin as frontend part.
https://github.com/dereuromark/cakephp-navigation
Right now I can auto extract already controller actions and build a basic tree menu from it (convention based off index as root of each controller).
Now I just need to extract the tree, and programmatically create the Menu as per your API and I should have menu + breadcrumbs then as DB driven solution.

I see, that should work fine. I can push a quick 3.x backport of it if you'd like to try it with your plugin?

If you are interested to support this also in 3.x, that would be most welcome.

Sure, for the time being the 3.x branch will receive the same feature updates as the 4.x branch if possible... and while I'm saying that I notice that I still haven't backported the class inheritance/consuming feature 😬

I see that it uses v2 vs v3 of the menu builder library. There arent that big of differences?

Not really, AFAICT there aren't any new features or notable changes to the API, it's mainly the requirement of PHP 7.2+, introduction of strict types, and dropping deprecated code.

Here we go: https://github.com/icings/menu/tree/3.x-feature/paths-and-current-item
Now I'll have to think long and hard about the root item stuff before I'll continue this.

So after thinking about this for some time, I cam to the conclusion that keeping the current behavior of root menu items is the best way forward for now.
I'll go over this again, add some docs, and publish releases for 4.x and 3.x soon.


Add nrf21540_ek shield definition

This PR adds the nRF21540 EK Board shield definition. It is a continuation of
https://github.com/zephyrproject-rtos/zephyr/pull/31523
which was targeted to upstream Zephyr but due to lack of use cases there, it was rejected.

Would it be possible to move this PR to sdk-nrf to minimize delta between upstream and sdk-zephyr and to place shield description in the same repository FEMs are described: https://github.com/nrfconnect/sdk-nrf/tree/master/dts/bindings/radio_fem

Would it be possible to move this PR to sdk-nrf to minimize delta between upstream and sdk-zephyr and to place shield description in the same repository FEMs are described: https://github.com/nrfconnect/sdk-nrf/tree/master/dts/bindings/radio_fem

@hubertmis I don't think that we support a shield extension in sdk-nrf. So we would need to add such possibility probably from cmake level but I might be wrong. @tejlmand Do you have opinion about it ?

Also, open-source BLE Controller supports nRF21. Perhaps we could use it to justify putting shield description to upstream Zephyr. Thoughts?

Also, open-source BLE Controller supports nRF21. Perhaps we could use it to justify putting shield description to upstream Zephyr. Thoughts?

Discussed offline. Opensource controller does not use device tree. It's not justification enough.

I would prefer to add this shield to sdk-nrf to avoid noup patches to sdk-zephyr, but if it would require serious changes in the build system to support shields in that repository, I'm OK to merge this patch to deliver it quicker.

@tejlmand What is your opinion about this ?

Continued in sdk-nrf https://github.com/nrfconnect/sdk-nrf/pull/5263


OSX clRetainContext

Hi,
On OSX, as part of an OpenGL view integration with a shared OpenCL context, clRetainContext() shouldn't be called - as the application does not own the context. If you create your own OpenCL context separately - this is fine.
I've removed this previously from my own build for the reason that OS X blows up if you attempt this, it may be worth adding something around this.
Nick

Please look at: https://www.khronos.org/registry/cl/sdk/1.0/docs/man/xhtml/clRetainContext.html
It is valid and required for libraries to use this. The calling application has to make sure there is a matching destroyPlan for every createPlan call, so library can internally release the context.

Hi Bragadeesh,
This is a OS X special - rather than standard OpenCL. I understand what you're pointing at, however when you use OpenGL sharing with OpenCL under OS X, you are provided with a context and don't explicitly create one yourself.
"Note: Since this context is created by OpenCL, you should not retain/release it. (You should retain/release any contexts that you explicitly create.)"
https://developer.apple.com/library/mac/documentation/Performance/Conceptual/OpenCL_MacProgGuide/UsingGCDwOpenCL/UsingGCDwOpenCL.html
In the example, the context is obtained rather than clCreateContext using:
cl_context context = gcl_get_context();
It's this subtly that causes a problem when using shared contexts.
I hope that helps,
Nick

Hi bragadeesh - was this fixed? I just see this going from open, to clarification then closure without a comment.
Nick

Nick,
No, nothing is done in the library for this, this sounds like an apple opencl/opengl interop issue. This has to be fixed on the stack. I understand the design restriction on apple side. But this has to be addressed by a special fork of the code, which you are already doing. We cannot change library code for this since we are in conformance with opencl.

Ok, understood - as long as others know that they will have the same problem on OSX.

It makes sense to annotate the issue in your readme. At the moment, your build instructions say only generate Linux makefiles. Your readme is therefore going to give OSX users an incorrect expectation. Minimally the readme should refer to this issue, in my opinion.

A note in the readme referencing this issue would be very helpful to others facing the same problem.


fix things + add maintainer

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

closes #5 #4 #3 #2 #1

@conda-forge-admin please rerender


storage-resize-images: HEIC support

[READ] Step 1: Are you in the right place?
yes
[REQUIRED] Step 2: Extension name
This feature request is for extension: storage-resize-images
What feature would you like to see?
I'd love to see support for resizing and converting heic images, as they are the standard format of Apple iOS devices.
How would you use it?
Upload some heic photos to firebase storage and have them resized and converted by the extension (just as it is like for jpg, png, etc)

Thanks for the feature request @lud-hu. According to Sharp documentation "Support for patent-encumbered HEIC images requires the use of a globally-installed libvips compiled with support for libheif, libde265 and x265" which unfortunately isn't possible on Google Cloud Functions.

Is there a way to upload .heic image from iphone to firebase storage using Unity, or at least convert it through Unity and then upload it in firebase?


dotnet-hosting-2.1 package missing on Ubuntu 18.04

dotnet-hosting-2.1 package missing on Ubuntu 18.04
I've registered the feed and followed the other instructions at https://www.microsoft.com/net/download/linux-package-manager/ubuntu18-04/runtime-2.1.0, but the package is still not found.
General
shravan@ubuntu:~/Desktop$ sudo apt-get install dotnet-hosting-2.1
Reading package lists... Done
Building dependency tree
Reading state information... Done
E: Unable to locate package dotnet-hosting-2.1
E: Couldn't find any package by glob 'dotnet-hosting-2.1'
E: Couldn't find any package by regex 'dotnet-hosting-2.1'

It is also missing for Ubuntu 16.04.

Sorry about that, the correct package name is aspnetcore-runtime-2.1. Fixing up the site.
This was called dotnet-hosting in 2.0 but has been changed. Still not a great name so will be looking at a better option for this package.

@leecow can you also amend this on page for CentOS describes runtime download? Seems to be same issue there: dotnet-hosting instead of aspnetcore-runtime

@SergeyChanaev - yes, I have an issue logged with @rowanmiller to make the change.

Closing this issue as it's a dupe of https://github.com/dotnet/core/issues/1620

Fixed on the live site

Anyone want to update the Linux section on this document??
https://github.com/dotnet/core/blob/master/release-notes/download-archives/2.1.1-download.md


Test with ldc-0.15.2-beta2

Another "let's test and report regression" P.R.

@klickverbot : I get the following from Travis:
$ ldc2 --version
ldc2: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.18' not found (required by ldc2)

Any idea ?

The problem is that I did not link against static libstdc++.so. Don't know how this happened. I'll create a new binary.

I still build with Ubuntu 12.04. But somehow I did lost the build script with the -static-libstc++ switch. (It was not properly integrated so I did not commit the change.)

@redstar : Any chance to get another beta which works with Travis ?

Yeah a beta that works with Travis is much more likely to get test coverage

I rebuild the Linux binaries.  Because I just retried and got the same error (see below). The hash correspond to the one you posted recently on the NG.
geod24@barsoom2 ~ % md5sum ldc2-0.15.2-beta2-linux-x86_64.tar.xz
18e4d0aec88ebbc58365bdc67b15cc7c  ldc2-0.15.2-beta2-linux-x86_64.tar.xz
geod24@barsoom2 ~ % tar -xf ldc2-0.15.2-beta2-linux-x86_64.tar.xz
geod24@barsoom2 ~/ldc2-0.15.2-beta2-linux-x86_64 % ldd bin/ldc2
	linux-vdso.so.1 (0x00007ffca7123000)
	libconfig.so.8 => /home/geod24/ldc2-0.15.2-beta2-linux-x86_64/bin/libconfig.so.8 (0x00007f1b310e6000)
	libpthread.so.0 => /usr/lib/libpthread.so.0 (0x00007f1b30ec9000)
	libdl.so.2 => /usr/lib/libdl.so.2 (0x00007f1b30cc5000)
	libstdc++.so.6 => /usr/lib/libstdc++.so.6 (0x00007f1b30943000)
	libm.so.6 => /usr/lib/libm.so.6 (0x00007f1b3063f000)
	libgcc_s.so.1 => /usr/lib/libgcc_s.so.1 (0x00007f1b30429000)
	libc.so.6 => /usr/lib/libc.so.6 (0x00007f1b30087000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f1b312f0000)
geod24@barsoom2 ~/ldc2-0.15.2-beta2-linux-x86_64 % md5sum ./bin/ldc2
e8f648ebdaeb7ed8274e419fb0597f28  ./bin/ldc2

Hm. The binary in my build does not depend on libstdc++, but the binary in archive does. I need to check the build scripts again.

The LDC 0.15.2 release has been abandoned, I've opened #1289 to test 0.16.0-beta1.


Setup travis ci

Issue/Task Number: 62-setup-travis-ci
Overview
Setup android travis-ci to run 3 things:

android lint

kotlin lint

unit test

generate code documentation (limited to some public files that users need to know)

Changes
N/A
Implementation Details

Install android components.
Add necessary environment variable in travis-ci setting.

Add script to create secret.json before running tests.

Run android lint

Run kotlin lint

Run unit test

Run generate code documentation

Deploy code documentation to gh-pages if the PR is merged.

Remove secret.json complete tests

Usage
The CI will automatically build whenever the branch is push, add new commit or open PR.
Impact
No more PR like fix test or fix lint.

Ready for review

Ready for review

Ready for review

Ready for review


Update DNS-SD advertisements on fail-safe timeout

When we remove a fabric during a pending add with fail-safe timeout, we aren't updating DNS-SD adevertisements.  In addition to the obvious consequence of continuing to advertise a now-stale identity, this can also leave the advertisement slots full if the failed fabric addition was to the Nth slot in an N-fabric device.
This then breaks advertisement when recommissioning to the Nth slot thereafter for builds that do not set this:
CHIP_CONFIG_MINMDNS_DYNAMIC_OPERATIONAL_RESPONDER_LIST
For those builds, this condition persists until reboot or some other action triggers DnssdServer::StartServer.
This commit fixes the problem by moving the DnssdServer::StartServer call from the RemoveFabric invoke handler to the server's OnFabricRemoved callback.  That will result in server restart both for RemoveFabric invocations and fail-safe expiry.
Fixes #23169

Is there a test that could be added to make sure this never regresses again?

Is there a test that could be added to make sure this never regresses again?

It's not obvious to me how we would unit test.  It is difficult because some of the communication between the fabric table and dns-sd server runs through the app server.  That actually is probably the source of this bug in a way: the app shouldn't need to know how to tell the dns-sd server what to do / when to do things (particularly not when the dns-sd server's source of truth is the fabric table anyway).
It would probably make more sense for the dns-sd server to register for fabric table add / update / remove callbacks directly so that the dns-sd can just 'do the right thing' based upon the state of the fabric table.  And without the app in the middle, unit testing dns-sd server + fabric table seems plausible.
But absent such a refactor, perhaps we could add an integration test to make sure from the commissioner side, advertisements disappear after a fail-safe timeout.  ttl will complicate things, but it still may be doable.
Can somebody point me to the existing commissioning integration tests?

Is there a test that could be added to make sure this never regresses again?

It's not obvious to me how we would unit test. It is difficult because some of the communication between the fabric table and dns-sd server runs through the app server. That actually is probably the source of this bug in a way: the app shouldn't need to know how to tell the dns-sd server what to do / when to do things (particularly not when the dns-sd server's source of truth is the fabric table anyway).
It would probably make more sense for the dns-sd server to register for fabric table add / update / remove callbacks directly so that the dns-sd can just 'do the right thing' based upon the state of the fabric table. And without the app in the middle, unit testing dns-sd server + fabric table seems plausible.
But absent such a refactor, perhaps we could add an integration test to make sure from the commissioner side, advertisements disappear after a fail-safe timeout. ttl will complicate things, but it still may be doable.
Can somebody point me to the existing commissioning integration tests?

Discussed offline.  Adding something to our existing Python testing could work, but would have some inherent variability across platforms, and could also be unreliable.
And per my assessment above, DnssdServer + FabricTable are not easily unit tested for this particular interaction because the app cluster server is sitting in the middle.
I therefore think it is not feasible for me to add a regression test immediately and we should probably merge this obvious fix as is.


pkg/k8s: add conversion for DeleteFinalStateUnknown objects for CiliumNode

:warning: :warning: ~This PR is being merged against #8460 for easier review~ :warning: :warning:
~Do not merge until #8460 is merged first.~

This change is

test-me-please


Add support for Facebook videos

Hi, seems like live facebook video links aren't working. Any idea on how to overcome this ?

Facebook videos aren't currently supported, but it looks possible using the embedded video player API. I'll repurpose this issue to add support for Facebook videos.

any updates/progress on this one?

I have attempted it but the result was very buggy, especially when trying to switch from one FB video to another. Maybe some support is better than none, so I'll consider adding basic support and a note that some bugs remain with the API.


'base_url' incorrectly marked as required argument for CosmosDBManagementClient

base_url was marked as required on the page. It took me an hour to figure out what to put in. And in the end it turns out I can leave it as empty.
I still don't understand the purpose of this argument, but please at least mark it as optional!!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 151742ca-142e-bf48-6009-f6e7960ceefe
Version Independent ID: 3db06378-6c32-1ba2-0d21-ee89e5f59dd0
Content: azure.mgmt.cosmosdb.CosmosDBManagementClient class
Content Source: docs-ref-autogen/azure-mgmt-cosmosdb/azure.mgmt.cosmosdb.CosmosDBManagementClient.yml
GitHub Login: @lmazuel
Microsoft Alias: lmazuel

thanks for your feedback @duanqn! we'll improve the doc experience ASAP

@duanqn the base_url argument needs to be set when working with sovereign clouds which defaults to Azure Public Cloud. While required, that signature does mention a default value of None, which is why you don't have to pass this in.
Also, it looks like this is the case for most docs. @lmazuel @yunhaoling @msyyc Could you share any insights on this?

Hi, according to latest code, base_url is optional. It seems that the doc is out of date and I think we need to contact doc team to update. Thanks for your feedback!

@duanqn This issue is being tracked internally

@duanqn the base_url argument needs to be set when working with sovereign clouds which defaults to Azure Public Cloud. While required, that signature does mention a default value of None, which is why you don't have to pass this in.
Also, it looks like this is the case for most docs. @lmazuel @yunhaoling @msyyc Could you share any insights on this?

Yes, I noticed the default value of None, but only after I wasted an hour on this. I don't quite understand the logic of "required with a default value". It's simply optional, and we should document as optional.
Thanks for the explanation about this argument. Some examples about this argument would be helpful (i.e. the exact URL to put in). If this is an inherited argument perhaps we can link to its document.

If users don't put this parameter in, it will be set default value: https://management.azure.com(example). base_url is mainly used for authentication and resource management. So most azure users, they don't need to input it.


update dependencies to clear CVEs

Description
Update dependencies:
solrj from 8.11.2 to 8.11.3 to address: CVE-2023-50298
azure-identity from 1.11.4 to 1.12.2 to address: CVE-2024-35255
This PR has:

[x] been self-reviewed.

[ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[ ] added documentation for new or modified features or behaviors.
[ ] a release note entry in the PR description.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[x] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[ ] been tested in a test Druid cluster.

This is still a draft. The preferred solution will be to update azure-sdk-pom instead of the individual dependency.

closing in favor of #17576 17576


GGIR logo requirements

I am talking to a graphics designer to design a logo for GGIR. Here are the requirements I have in mind.
Feedback welcome! @m-patterson @jhmigueles ?
Intended application of the logo:

Online documentation.
Laptop sticker
Used inside PowerPoint presentations.
On my own website and possibly other websites

Text:
GGIR (in capitals)
Subtitle: R package for accelerometer data analysis.
Lay man summary of what GGIR is, such that designer can keep this in mind:
GGIR is free software  to analyse data collected with wearable movement sensors.
For example, it can detect how long a person has slept or how active a person has been.
GGIR is primarily used by movement- and sleep researchers, passionate about understanding and improving human health.
Shape / Colour preferences:
I do not have a strong preference. The style should be distinct from my Accelting logo to avoid the impression that GGIR is an exclusive product by me. In terms of shape: We should not copy the tidyverse hectogon, because GGIR is not tidyverse. However any other simple but recognisable shape could work.
What are core strengths of GGIR that we want the logo to radiate?

Broad spectrum of functionalities / Modifiability
Open / Transparent
Control for researcher
Ease of use (despite the learning curve, you can learn GGIR without prior programming experience)
Evidence based
...

It could be that the designer complains that the subtitle 'R package for accelerometer data analysis.' is too long.
In that case we could maybe shorten it to 'R package for accelerometry'.
Not using a subtitle has the risk that the logo becomes incomprehensible when presented without context. This is not a problem all the time, e.g. when it is used in our package documentation... but it is generally helpful to have a logo that is self-explanatory.

I think an important strength of GGIR is that it is used to get useful insights from remotely captured health data, which is pretty important in the context of the world today, so I would suggest adding the following bullet point to the 'core strengths' section:

Analyze remotely captured health data

Thanks @jeremy-dai :) I am actually hiring a designer to work on this, but it is good to know that you are looking at alternatives.

Closing this issue, because we have a logo now. I am now going to open a separate issue for integrating this in GGIR.

Closing this issue, because we have a logo now. I am now going to open a separate issue for integrating this in GGIR.


Solver preprocessing

Added a couple pre-processing steps intended to partially address #1091 by simplifying optimization problem.
The pruning complexity depends on number of variables, so we minimize the number of variables by eliminating linearly dependent parameter values. Also, we simplify the optimization formula by combining affine expressions like (kokomi) atk + 1000 atk_ + .1 hp + 3000 hp_ --> ~r1 into single read operations.
Empirical test shows some improvement. Old runtime:

New runtime:

Closed due to discussion on discord. Will re-introduce features in a future PR.


Cannot switch between monitoring cluster preset modes from UI

In:

Save or applying from presets does not apply it to config.
Applying the preset freezes the page and no network calls are made

Caused by an old browser version