Undefined symbols for architecture arm64:   "_swift_FORCE_LOAD$_swiftCompatibility56"

Description
When running lottie-react-native @5.1.6 with react-native 0.72.2, we can't build the app on iOs. We get the following error message:
ld: warning: Could not find or use auto-linked library 'swiftCompatibility56' ld: warning: Could not find or use auto-linked library 'swiftCompatibilityConcurrency' Undefined symbols for architecture arm64:   "__swift_FORCE_LOAD_$_swiftCompatibility56", referenced from:       __swift_FORCE_LOAD_$_swiftCompatibility56_$_Lottie in Lottie(AnimatedButton.o)       __swift_FORCE_LOAD_$_swiftCompatibility56_$_Lottie in Lottie(PreCompLayer.o)       __swift_FORCE_LOAD_$_swiftCompatibility56_$_Lottie in Lottie(SolidLayer.o)       __swift_FORCE_LOAD_$_swiftCompatibility56_$_Lottie in Lottie(GradientRenderLayer.o)       __swift_FORCE_LOAD_$_swiftCompatibility56_$_Lottie in Lottie(ShapeContainerLayer.o)       __swift_FORCE_LOAD_$_swiftCompatibility56_$_Lottie in Lottie(TextLayer.o)       __swift_FORCE_LOAD_$_swiftCompatibility56_$_Lottie in Lottie(LottieAnimationViewBase.o)       ...      (maybe you meant: __swift_FORCE_LOAD_$_swiftCompatibility56_$_Lottie, __swift_FORCE_LOAD_$_swiftCompatibility56_$_lottie_react_native )   "__swift_FORCE_LOAD_$_swiftCompatibilityConcurrency", referenced from:       __swift_FORCE_LOAD_$_swiftCompatibilityConcurrency_$_Lottie in Lottie(AnimatedButton.o)       __swift_FORCE_LOAD_$_swiftCompatibilityConcurrency_$_Lottie in Lottie(PreCompLayer.o)       __swift_FORCE_LOAD_$_swiftCompatibilityConcurrency_$_Lottie in Lottie(SolidLayer.o)       __swift_FORCE_LOAD_$_swiftCompatibilityConcurrency_$_Lottie in Lottie(GradientRenderLayer.o)       __swift_FORCE_LOAD_$_swiftCompatibilityConcurrency_$_Lottie in Lottie(ShapeContainerLayer.o)       __swift_FORCE_LOAD_$_swiftCompatibilityConcurrency_$_Lottie in Lottie(TextLayer.o)       __swift_FORCE_LOAD_$_swiftCompatibilityConcurrency_$_Lottie in Lottie(LottieAnimationViewBase.o)       ...      (maybe you meant: __swift_FORCE_LOAD_$_swiftCompatibilityConcurrency_$_Lottie, __swift_FORCE_LOAD_$_swiftCompatibilityConcurrency_$_lottie_react_native ) ld: symbol(s) not found for architecture arm64 clang: error: linker command failed with exit code 1 (use -v to see invocation)
This error also occurs on the "lottie-react-native": "next" version.
Expected behavior: : the app should build on iOs
Actual behavior: : it does not build.

I'm on<EMAIL_ADDRESS>and<EMAIL_ADDRESS>build error:
SwiftCompile normal arm64 .../node_modules/lottie-react-native/src/ios/LottieReactNative/PlatformColor.swift (in target 'lottie-react-native' from project 'Pods')

<module-includes>:1:9: note: in file included from <module-includes>:1:
#import "lottie-react-native-umbrella.h"
        ^
.../ios/Pods/Headers/Public/lottie_react_native/lottie-react-native-umbrella.h:13:9: note: in file included from .../ios/Pods/Headers/Public/lottie_react_native/lottie-react-native-umbrella.h:13:
#import "Bridging.h"
        ^
.../node_modules/react-native/ReactCommon/react/bridging/Bridging.h:10:10: error: 'react/bridging/AString.h' file not found
#include <react/bridging/AString.h>
         ^
<unknown>:0: error: could not build Objective-C module 'lottie_react_native'

** BUILD FAILED **

The following build commands failed:
        SwiftCompile normal arm64 Compiling\ PlatformColor.swift /Users/coreycole/cdev/BlueCanoeReactNative/node_modules/lottie-react-native/src/ios/LottieReactNative/PlatformColor.swift (in target 'lottie-react-native' from project 'Pods')
        SwiftCompile normal arm64 /Users/coreycole/cdev/BlueCanoeReactNative/node_modules/lottie-react-native/src/ios/LottieReactNative/PlatformColor.swift (in target 'lottie-react-native' from project 'Pods')
(2 failures)

Are you using XCode beta?

What is your XCode version?

Hi @matinzd, my Xcode version is 14.3.1
And my swift version is
swift-driver version: 1.75.2 Apple Swift version 5.8.1 (swiftlang-<IP_ADDRESS>.5 clang-14<IP_ADDRESS>.100) Target: arm64-apple-macosx13.0

Have you tried creating bridging headers for Swift? It seems that swift is not enabled on your project.
Refer to this thread in stackoverflow:
https://stackoverflow.com/a/41788055

Yes, I created a bridging-header in this project several years ago already! I'll try to create a new one but I don't think that should be necessary, since lottie is the only package where that Swift error occurs. Other packages requiriung bridging headers compile fine.

I recreated a bridge-header file, and made sure to select all the targets of my group. It worked!
Thansk @matinzd

@antoinedelp  can you share the steps you performed, including the content of the header file?


Filter Service Catalog Items during deployment

https://bugzilla.redhat.com/show_bug.cgi?id=1227045
At deployment time using some user selections the services that get deployed can be controlled by calling an Automate method. The Automate method takes the following three parameters

The Service Provision Task
The Parent Service
The Current Service Template being evaluated

The method controls if the service gets included/excluded by setting  the attribute 'include_service' to true/false respectively.

@gmcculloug  @tinaafitz
Please Review

@mkanoor bump

@gmcculloug Please review

@mkanoor Had a few cleanup comments but overall this looks good.  I would like to see more detail in the PR description to document the automate entry point for this as well as the the path it resolves to the filtering method.  A very simple example of what the filtering method would need to set would be useful as well.

@gmcculloug
Please review made PR changes

@gmcculloug
Moved filter file into service_template folder.

:+1:


Start towards properties depending on specific hash collisions found by peers vs. mere existence of hash collisions

So far, our proofs depend on an assumption that hash collisions don't exist.  But they do!  We have required hash collisions to be put in context of a ReachableSystemState just to remind ourselves that we cannot assume lack of hash collisions "for free".  But this did not mean much because nothing connected the specific hash collisions to that ReachableSystemState.
This PR makes the first steps towards doing so, dealing with one important class of potential hash collisions: those on BlockIds, requiring properties to depend only on the assumption that these hash collisions do not exist in the specific state for which a property is proved.  This is achieved by defining a notion of a hash being in the state (e.g., a Proposal that has the same hash as a Block already stored in the BlockTree, but with different BlockData.  See LibraBFT.ImplShared.Util.HashCollisions.HashCollisionFound.
This requires us to capture the fact that we validate new Proposals "off the wire" before handling them, and propagate this information "down the stack" in order to connect it with an assumption that a hash collision does not exist *in the ReachableSystemState in which the Proposal is handled.  This validity of Proposals is propagated down via module parameters, and the lack of hash collisions is propagated through arguments to the specific contract properties that require them.
There is room for improvement streamlining this, especially in LibraBFT.Impl.Properties.VotesOnce.  There are also still a number of uses of meta-sha256-cr, which does not tie the hash collision to the ReachableSystemState.  Addressing these will likely require the addition of more kinds of specific hash collision.  When we have eliminated all uses of meta-sha256-cr, and proved all properties, we will then know that we have a precise and narrow summary of the possible hash collisions, the absence of which our proofs require.

Closing as this was merged together with #160.

Superseded by #167


Support Function.name for anonymous functions. ES2015 "Inferred function names"

Which version of PhantomJS are you using? Tip: run phantomjs --version.
2.1.1

What steps will reproduce the problem?
Create issue.js file with next content:

var f = function() {};
var object = {
someMethod: function() {}
};

console.log(f.name); // "f"
console.log(object.someMethod.name); // "someMethod"

Run phantomjs.exe issue.js
f.name and object.someMethod.name return empty strings.

Which operating system are you using?
Windows 10

Did you use binary PhantomJS or did you compile it from source?
binary

Please provide any additional information below.
Are there any plans to add that support?
Please see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/name "Inferred function names" sections.

Function.name for normal functions works fine.

PhantomJS is abandoned. The maintainer recommends you use Chrome Headless instead.
https://groups.google.com/forum/#!topic/phantomjs/9aI5d-LDuNE


eth0 DHCP fails after profiler start/stop

Issue @wifinigel identified in profiler package also affects profiler2. https://github.com/WLAN-Pi/profiler/issues/14

boot WLAN Pi (no ethernet cable plugged in)
start/stop profiler from FPMS
Plug in WLAN Pi ethernet port to switch port that has DHCP available
DHCP address not received.

airmon-ng check kill will kill dhclient. we need to start dhclient back up at exit.

I thought #38 would fix this because it removes airmon-ng check kill from the interface prep func, but it doesn't appear to. Need to do more testing.


[x] Improve code coverage generation (turn off sccache in code coverage by default, better warnings/logging, refactor)

Motivation
Fix code coverage since the last rust update broke it.
Have you read the [Contributing Guidelines on pull requests]
Yes
Test Plan
Run by pushing code to gha-test-1 branch, results:
Runs:
https://github.com/diem/diem/runs/2814501836?check_suite_focus=true
Results:
https://ci-artifacts.diem.com/coverage/unit-coverage/2021-06-13-7ba68db8/index.html
Related PRs
None
If targeting a release branch, please fill the below out as well

Justification and breaking nature (who does it affect? validators, full nodes, tooling, operators, AOS, etc.)
Comprehensive test results that demonstrate the fix working and not breaking existing workflows.
Why we must have it for V1 launch.
What workarounds and alternative we have if we do not push the PR.

prior build shows the line coverage test in test-code-coverage job failing when set to 90% for common/logger since the crate is only at 82%

/land

/cancel

/land


ReactHotPlate bug

[x] I have read the contribution documentation for this project.
[x] I agree to follow the code of conduct that this project follows, as appropriate.
[x] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Please describe your issue:
After setting up the project with electron-forge init --template=react the hotplate do not work due to the below error, this error is not an issue if it was to be running via react-scripts start.

Console output when you run electron-forge with the environment variable DEBUG=electron-forge:*. (Instructions on how to do so here). Please include the stack trace if one exists.
C:\Users\skizu\git\bar\node_modules\react-proxy\modules\createClassProxy.js:180 Uncaught TypeError: Cannot redefine property: enumValues
    at Function.defineProperty (<anonymous>)

What command line arguments are you passing?
npm start

What does your config.forge data in package.json look like?
{
  "name": "bar",
  "productName": "bar",
  "version": "1.0.0",
  "description": "My Electron application description",
  "main": "src/index.js",
  "scripts": {
    "start": "electron-forge start",
    "package": "electron-forge package",
    "make": "electron-forge make",
    "lint": "echo \"No linting configured\""
  },
  "keywords": [],
  "author": "skizu",
  "license": "MIT",
  "config": {
    "forge": {
      "make_targets": {
        "win32": [
          "squirrel"
        ],
        "darwin": [
          "zip"
        ],
        "linux": [
          "deb",
          "rpm"
        ]
      },
      "electronPackagerConfig": {},
      "electronWinstallerConfig": {
        "name": "bar"
      },
      "electronInstallerDebian": {},
      "electronInstallerRedhat": {},
      "github_repository": {
        "owner": "",
        "name": ""
      },
      "windowsStoreConfig": {
        "packageName": "",
        "name": "bar"
      }
    }
  },
  "dependencies": {
    "electron-compile": "^6.4.1",
    "electron-devtools-installer": "^2.2.0",
    "enumify": "^1.0.4",
    "immutability-helper": "^2.2.2",
    "moment": "^2.18.1",
    "node-fetch": "^1.7.1",
    "react": "^15.6.1",
    "react-ace": "^5.0.1",
    "react-dom": "^15.6.1",
    "react-hot-loader": "^3.0.0-beta.7"
  },
  "devDependencies": {
    "babel-cli": "^6.24.1",
    "babel-plugin-transform-async-to-generator": "^6.24.1",
    "babel-plugin-transform-class-properties": "^6.24.1",
    "babel-plugin-transform-es2015-classes": "^6.24.1",
    "babel-preset-env": "^1.5.2",
    "babel-preset-react": "^6.24.1",
    "electron-prebuilt-compile": "1.6.11"
  }
}

Please provide either a failing minimal testcase (with a link to the code) or detailed steps to
reproduce your problem. Using electron-forge init is a good starting point, if that is not the
source of your problem.

I cannot reproduce this. Here are my repro steps, based on your description:
electron-forge init --template=react test-gh-256
cd test-gh-256
$EDITOR package.json # replace dependencies & devDependencies with that is in the issue summary
npm install
npm start

Expected: Exception thrown (Uncaught TypeError: Cannot redefine property: enumValues)
Actual: React Electron app opens normally.

Could you please provide either a failing minimal testcase (with a link to the code) or detailed steps to reproduce your problem?

As the reporter has not responded to the request for additional information this issue will be closed.  If further information can be provided at some point in the future, comment on this issue with the requested information and if appropriate the issue will be reopened.


Multiple services with the same UUID using attribute tables (IDFGH-911)

Environment

Development Kit: none
Module or chip used: ESP32-WROOM-32
IDF version: v3.1.1-1-g70f4e5e62
Build System: Make
Compiler version: 1.22.0-80-g6c4433a
Operating System: Linux
Power Supply: external 3.3V

Problem Description
Hi all,
I'm trying to make a profile with 2 services with the same UUID (same service table) using the attribute tables.
The function that create that (esp_ble_gatts_create_attr_tab()) is ok because there is an argument srvc_inst_id, and so I can call it 2 times with different service instances. My problem is that in the event generated (ESP_GATTS_CREAT_ATTR_TAB_EVT) I can't find a reference to the service instance in order to save the handles in different places: gatts_add_attr_tab_evt_param contains only a esp_bt_uuid_t not a esp_gatt_srvc_id_t like the gatts_create_evt_param (ESP_GATTS_CREATE_EVT) where instance ID can be found.
Is there a way to resolve this or can't be done using attr tables?
Thanks!
Expected Behavior
    /**
     * @brief ESP_GATTS_CREAT_ATTR_TAB_EVT
     */
    struct gatts_add_attr_tab_evt_param{
        esp_gatt_status_t status;       /*!< Operation status */
        esp_gatt_srvc_id_t service_id;  /*!< Service id, include service uuid and other information */
        uint16_t num_handle;            /*!< The number of the attribute handle to be added to the gatts database */
        uint16_t *handles;              /*!< The number to the handles */
    } add_attr_tab;                     /*!< Gatt server callback param of ESP_GATTS_CREAT_ATTR_TAB_EVT */

Actual Behavior
    /**
     * @brief ESP_GATTS_CREAT_ATTR_TAB_EVT
     */
    struct gatts_add_attr_tab_evt_param{
        esp_gatt_status_t status;       /*!< Operation status */
        esp_bt_uuid_t svc_uuid;         /*!< Service uuid type */
        uint16_t num_handle;            /*!< The number of the attribute handle to be added to the gatts database */
        uint16_t *handles;              /*!< The number to the handles */
    } add_attr_tab;                     /*!< Gatt server callback param of ESP_GATTS_CREAT_ATTR_TAB_EVT */

A workaround would be turn it into a synchronous call meaning do not call esp_ble_gatts_create_attr_tab the second time until you receive ESP_GATTS_CREAT_ATTR_TAB_EVT from the first call.

Good idea! Thank you. I'll follow this way at the moment, however I think the modification should be introduced in the IDF for completeness.

@frazan-un, Thanks for your reminder,  I will modify the IDF.

@frazan-un , The commit is ceb00f7a4190e47b912444d2829575602d9b2a28,  please try, thanks.

@frazan-un Thanks for reporting the issue, feel free to reopen if the issue still exists. Thanks.


feat(bindings/nodejs): fs Operator

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
fs operator

🤔 Why does CI/check always fail... I have added a license header to them.

thinking Why does CI/check always fail... I have added a license header to them.

I'm guessing the filename changed, so the ignore is not working.

🤔 Why does CI/check always fail... I have added a license header to them.

@tisonkun Is this a bug? I run this license header check on my local machine, but it still fails.
the failed file

https://github.com/datafuselabs/opendal/blob/73c4b37458caf94e56b6bf05cea7fdd46a0fa50c/bindings/nodejs/index.js

@suyanhanx You can run docker run -it --rm -v $(pwd):/github/workspace -u $(id -u):$(id -g) ghcr.io/korandoru/hawkeye-native:v1 format to auto fix. I guess it's about the comment style. We don't have preference here but keep consistent.

A valid patch:
diff --git a/bindings/nodejs/index.js b/bindings/nodejs/index.js
index bf4ce80..b03101a 100644
--- a/bindings/nodejs/index.js
+++ b/bindings/nodejs/index.js
@@ -1,16 +1,18 @@
-// Copyright 2022 Datafuse Labs
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//     http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
+/*
+ * Copyright 2022 Datafuse Labs
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */

const { Operator, Scheme } = require('./generated')

Yes. I ran. It's the comment's style problem.


Docs: Remove note about DLQs

Type of change

Documentation

Description

Docs: Remove note about DLQs
Checklist

[ ] Update/write design documentation in ./documentation/design
[ ] Write tests and make sure they pass
[x] Update documentation
[ ] Check RBAC rights for Kubernetes / OpenShift roles
[ ] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
[ ] Reference relevant issue(s) and close them after merging
[ ] Update CHANGELOG.md

Can one of the admins verify this patch?


redundant dockerfile issue with build

https://github.com/devcontainers/cli/issues/791 Redundant Dockerfile required in order to push to correct repo

if --image-name is provided in the cli then it should not push to cli-generated-image. The cli should push to user provided repository.

if we pass this argument value then it is stored in the additionaImageNames parameter which is used to check the additional names are provided. if yes, then it should not use cli-generated-image accordingly modification have been incorporated.

@prathameshzarkar9 I see you removed the test. Our hope was that we could have the test just without the --push option. Are you going to add it back? Thanks.


UI - Hidden features checkbox as user role

Description
Fixes https://github.com/apache/cloudstack/issues/5591

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[x] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[x] Minor
[ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@blueorangutan ui

@blueorangutan ui

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5597 (SL-JID-771)


remove IngestionTrackingContext from createAsset

Summary
remove IngestionTrackingContext from the create asset method to align with https://github.com/linkedin-multiproduct/metadata-models/pull/1039
Testing Done
Checklist

[X] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.06%. Comparing base (fccedcf) to head (3e60b88).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #405   +/-   ##
=========================================
  Coverage     68.06%   68.06%
  Complexity     1450     1450
=========================================
  Files           137      137
  Lines          5665     5665
  Branches        621      621
=========================================
  Hits           3856     3856
  Misses         1554     1554
  Partials        255      255

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add Google group doc.

This adds the Google group documentation to the readme. Should resolve issue #9

@gneatgeek @sambao21  I plan to merge this within the next day or so unless I get some feedback to change up the verbiage or link.

:+1:

:+1:


metamask is not connected

If I install both metamask and coinbase, connect to metamask will prompt "metamask is not connected"

Ooh, I haven't used coinbase browser extension before. Let me find out the solution.

It may be because the browser considers Coinbase wallet as the default wallet, not MetaMask.


[Bug] - Insomnia 6.0 JSON beautify break with HTML fields

Hi,
I just update my Insomnia version to 6.0. But something is wrong : when you get a JSON response with a HMTL field, the preview tab do weird things.
Look at it :

A previous version of Insomnia :
In Insomnia 6.0

Configuration

Insomnia Version: 6.0
Operating System: Windows 10 Pro

Details
Return in a JSON, a field with HTML tag on it.

You can test with this a GET on this URL : http://www.elysee.fr/chronologie/download/json
Look at entity 18628 or 18414.

Oh, this was fixed a while ago


Creating approle and login using terraform

Hey @bamdadd, I'm going to close this one for now as we have a terraform module for creating app roles and it might make more sense to use that to solve this problem.


RFC: chrome.bluetooth: implement lowEnergy for Android

Please consider this a rough-draft/RFC level pull request.  I've implemented what I need for now for access to a device I'm working with, and it appears to working/stable.  This includes:

LE connection
gatt service enumeration
characteristic enumeration
write characteristic
characteristic notifications

What is the best way to get this upstreamed?  Should I break the pull requests up?  Should I finish up the rest of the implementation (disconnect, getDescriptor, readCharacteristicValue, stopCharacteristicNotifications, onServiceRemoved, onDescriptorValueChanged` I think are the big missing ones) first?  Does the code look generally agreeable?  I've tried to crib from the iOS side of this plugin, while matching this coding style as much as possible.
So, guidance + critiques welcome.

Thanks again for contributions, but I'm a bit confused, have you seen our bluetoothLowEnergy plugin?
If that plugin is missing functionality, I think any additions you add belong there.  Let me know if I misunderstand, then I will take a look.

huh, it does seem like I'm the one confused here.  I think what happened, perhaps, is that I did cca plugin add org.chromium.bluetoothLowEnergy, and it looks like I got an old version that didn't have a source directory.  Damn :)  I'll switch to the latest code and verify things are working as intended.

For the record, the reason I took this approach (clobbering bluetooth) is because that seems to be how the iOS side of things works.  I assumed there was a reason for that.

So you've got the old source because we have not updated the latest plugin versions to the cordova plugin registry.  Andrew tried to do that last week, but there is a problem with the registry at the moment.
For iOS, I think the reason Rui (an intern from last term) took that approach was because the implementation was far more tightly coupled, and it was just impractical to split out.

got it - makes sense about the coupling.
Going to close this, the code on master seems to generally be working for me.  Thanks!


Unicode characters break tokenizer

When injesting model with multiple-bytes unicode characters, it prints failed to tokenize string!, and seems to ignore all tokens prior to said characters. That's bad for not only emoji support, but also languages like japanese and chinese.
I haven't tried it yet, but I think implementing the fix proposed in this PR for llama.cpp could solve this issue.

Good catch!
Will update it soon.

I think I got it working, by fixing tokenizer conversion in convert-pth-to-ggml, and making streaming_fn expecting py::bytesinstead of std::string should I make a PR for it?

We went for ASCII for the initial approach because we wanted a working solution for stop words. Therefore, support for Unicode has to work in tandem with stop words. If you can also add support for Unicode stop words, it would be much appreciated.

I just read the Pybind11 docs and found that they convert the python Unicode string to UTF-8 string. I think we've to handle it properly in C++
"pybind11 will encode the Python string to UTF-8"

We have to fix the tokenizer to iterate grapheme rather than character.

You can try Unicode branch and see if your Unicode string works.

You can try Unicode branch and see if your Unicode string works.

This branch still has issues with Chinese:

I check it on my laptop. The reason is very clear for the gibberish to me, and I did talk to @PotatoSpudowski about it.
This is all due to the vocabulary. There might be cases where the Unicode or character does not exist inside the model vocab.

Doesn't seem to be missing character, I tried the converter from alpaca.cpp (https://github.com/antimatter15/alpaca.cpp/blob/master/convert-pth-to-ggml.py#L102), the model/tokenizer worked fine:

But when I tried the same model with fastLLaMa, it crashed right away:

ok. I think I checked the wrong model (LLAMA 7B). Could tell me which model are you using?

I think I have an idea of what's happing. Maybe stream token function might be sending invalid Unicode to the py11bind.

I had the same issue, and it seems that some tokens are actually only single bytes from multi-byte unicode characters. Any python really doesn't like that.
My fix was to turn the streaming callback into this monstrosity:
streamed_char_bytes = b''
def stream_token(x: bytes) -> None:
    """
    This function is called by the llama library to stream tokens
    """
    if(len(x)==0):
        return
    global streamed_char_bytes
    bit = x[0]>>7
    if bit > 0:
        streamed_char_bytes = streamed_char_bytes + x
        try:
            print(streamed_char_bytes.decode("utf-8"), end='', flush=True)
            streamed_char_bytes = b''
        except UnicodeDecodeError:
            pass
    else:
        if(len(streamed_char_bytes)>0):
            print('�')
        streamed_char_bytes = b''
        try:
            c = x.decode("utf8")
            print(c, end='', flush=True)
        except UnicodeDecodeError:
            print('�')
            ```
           I also edited the `bridge.cpp` file accordingly.

The fix i'm thinking of requires me to fix buffer inside the bridge.cpp. The buffer will wait for character to become valid. That should make this monstrosity obsolete and make python much simpler. I'll try to fix it by tomorrow.

This one: https://huggingface.co/Sosaka/Alpaca-native-4bit-ggml/tree/main

Try now. I fixed it. My approach was simple. I took the last invalid/partial UTF-8 codepoint and prepended it to the next token, and so on. It might look like the stream token is running slow, but it's not. This approach introduces the interdependence of two tokens on each other, which makes it wait a little longer inside the buffer before it becomes valid.

Ok your modifications  to bridge.cpp seems to work fine, but I couldn't get it to output emojis properly without changing the tokenizer conversion in convert-pth-to-ggml.py (and then converting the models again).
diff --git a/convert-pth-to-ggml.py b/convert-pth-to-ggml.py
index fd934e7..8e2c556 100644
--- a/convert-pth-to-ggml.py
+++ b/convert-pth-to-ggml.py
@@ -112,11 +112,27 @@ for p in range(n_parts):
     fout.write(struct.pack("i", ftype))

     # Is this correct??
-    for i in range(32000):
-        # TODO: this is probably wrong - not sure how this tokenizer works
-        text = tokenizer.decode([29889, i]).encode('utf-8')
-        # remove the first byte (it's always '.')
-        text = text[1:]
+    for i in range(tokenizer.vocab_size()):
+        # # TODO: this is probably wrong - not sure how this tokenizer works
+        # text = tokenizer.decode([29889, i]).encode('utf-8')
+        # # remove the first byte (it's always '.')
+        # text = text[1:]
+        # fout.write(struct.pack("i", len(text)))
+        # fout.write(text)
+
+        if tokenizer.is_unknown(i):
+            text = " \u2047 ".encode("utf-8")
+        elif tokenizer.is_control(i):
+            text = b""
+        elif tokenizer.is_byte(i):
+            piece = tokenizer.id_to_piece(i)
+            if len(piece) != 6:
+                print(f"Invalid token: {piece}")
+                sys.exit(1)
+            byte_value = int(piece[3:-1], 16)
+            text = struct.pack("B", byte_value)
+        else:
+            text = tokenizer.id_to_piece(i).replace("\u2581", " ").encode("utf-8")
         fout.write(struct.pack("i", len(text)))
         fout.write(text)

Mega work @amitsingh19975
Thank you for picking this up!
Keeping this issue open for now! @stduhpf I will test the changes you suggested and add it accordingly!

@stduhpf tokenizer has been updated so this can be closed!


fix: Use COPY instead of ADD for files and folders

Description
Although ADD and COPY are functionally similar, generally speaking, COPY is preferred. That’s because it’s more transparent than ADD. COPY only supports the basic copying of local files into the container, while ADD has some features (like local-only tar extraction and remote URL support) that are not immediately obvious.

Codecov Report

Merging #3426 (5b1048a) into master (6169281) will decrease coverage by 1.67%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3426      +/-   ##
==========================================
- Coverage   12.30%   10.62%   -1.68%
==========================================
  Files          37       37
  Lines        3162     3162
==========================================
- Hits          389      336      -53
- Misses       2690     2759      +69
+ Partials       83       67      -16

Flag
Coverage Δ

gointegrationtests
?

unittests
10.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

mesheryctl/internal/cli/root/system/check.go
1.58% <0.00%> (-21.04%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6169281...5b1048a. Read the comment docs.

Thanks, @iamrajiv. It's good to have you here and contributing.
I wonder what value this change truly provides. Do we need to be able to extract tars or retrieve from remote URLs?
What isn't transparent about the ADD of files from ui to ui (for example)?
Not strictly required, but as a practice opening an issue first and having a suggested change/enhancement/bug confirmed before submitting a PR will spare you effort to the extent changes in the PR aren't warranted.

Hi, @leecalcote. No COPY can't handle remote URLs and can't auto-extract tar files. I thought we do not need it.

@iamrajiv this is a good PR to review in the Meshery CI call this week (on Thursday) - https://meet.layer5.io. // @ramrodo

@iamrajiv this is a good PR to review in the Meshery CI call this week (on Thursday) - https://meet.layer5.io. // @ramrodo

Added to the Agenda (July 22th)

Hey @iamrajiv, could you attend to the DCO check as well?

@bariqhibat I tried to sign in DCO but it is not passing I don't know why. For the last commit I did this git commit -s -m"formatted readme" but DCO failed.

@bariqhibat I tried to sign in DCO but it is not passing I don't know why.

Hi @iamrajiv, you need to make sure every single commit must be signed. In your case, the older commits are not signed so it's still showing the fail.


infix to postfix conversion

Have you read the Contributing Guidelines on Pull Requests?
Yes
Description
Conversion of infix expression to postfix expression using C++.
Related Issues or Pull Requests
Issue #617
@siddharth25pandey  @SKAUL05  my request to review the file added with respect to the issue #617

Kindly review this PR  @SKAUL05   @siddharth25pandey  @iamrajiv @atarax665  @Abhijit2505

@iamrajiv i have moved the program to cp section as per your suggestion.

@prasadvpatil resolve the merge conflicts.

@iamrajiv i have resolved the merge conflicts. Please do review.


Impossible to select field in Chinese

OrientDB Version, operating system, or hardware.

v2.2.17

Operating System

Linux

Expected behavior
Select 地點 From Town
Return the field 地點 from the Vertex Town
Actual behavior
Select 地點 From Town
com.orientechnologies.orient.core.sql.parser.TokenMgrError: Lexical error at line 1, column 8. Encountered: "\u5730" (22320), after : ""
Steps to reproduce
Create a Vertex Town
Create a field named 地點 for the Vertex Town
Select 地點 From Town

Hi @oger-p
This seems to be a problem with the parser, I'll check it asap
Thanks
Luigi

Is there a plan in which version to fix this bug？

Actually I don't know if this can be considered a bug. Without back-tick, the only accepted characters are A-Za-z0-9_$, the purpose of the back-tick is exactly to allow any other character for identifiers. I guess we can just close this issue, unless you need further help...
Thanks
Luigi

After run below command:
CREATE EDGE 包含 FROM #26:0 TO #22:0
the edge name becomes %E5%8C%85%E5%90%AB in database, the right one should be 包含

Ok, the problem here seems to be at a lower level. Let me check it...
Thanks
Luigi

Hi @oger-p
I just checked it, unfortunately this is a limitation of the schema in v 2.2, I cannot change it without breaking everything.
Good news is that this is already fixed in v 3.0, that will be RC in two or three weeks
Thanks
Luigi

When Chinese used, I even cannot create a vertex named in Chinese.
com.orientechnologies.orient.core.sql.parser.TokenMgrError: Lexical error at line 1, column 28.  Encountered: "\u821e"
UTF-8 is used by default in the python source file.


Feat/lesq 348/lesson overview info

Description

[x]  Year - Tier - Exam board
[x]  Pupil Lesson outcome added to header
[x]  Add new tag for new content in header
[x]  Change download button icon
[x]  Remove the extra lines between the last component and footer
[x]  Make sure the the last resource item has a 56px bottom padding so there is a gap between that and the footer
[x]  Make the divider lines between the components pink #DEB7D5
[x]  Correct typo on copyright box. Title should be Licence not License
[x]  Remove the Additional materials iframe and implement the workaround design ([bottom of this frame](https://www.figma.com/file/3i0y2PHT6pECaGgvLhoN8z/Lesson-page-July-2023?type=design&node-id=2393-74473&mode=design&t=6RPaPfV6RNLVrVJd-4))

How to test

Go to https://deploy-preview-1972--oak-web-application.netlify.thenational.academy/teachers/programmes/history-secondary-ks3/units/the-norman-conquest-how-do-we-know-about-the-impact-of-the-conquest-on-england/lessons/norman-changes-to-english-land-tenure

Checklist

[ ] Added or updated tests where appropriate
[ ] Manually tested across browsers / devices
[ ] Considered impact on accessibility
[ ] Design sign-off
[ ] Approved by product owner

Looks like we are fetching the wrong field as tiers aren't capitalised https://deploy-preview-1972--oak-web-application.netlify.thenational.academy/teachers/programmes/english-secondary-ks4-edexcel/units/macbeth-and-masculinity-the-struggle-for-power/lessons/duncan-as-a-father-figure

This is an MV issue - agreed with Verity to make it a backlog ticket

The approach for doing the Year - Exam board - Tier thing is different here than it is on the lesson listing page, would it make sense to make them consistent? (Yours is inside one span)

Ugh didn't notice the existing component. Will change it

Having the "bullet" read out by the screen reader isn't necessary (I thought I had commented about that on the PR for lesson listing page but maybe it got missed)

what bullet ?

There is a visual cue to say you will be moved to another page for downloading a, but not an accessible one... maybe that is a ticket for another day as all the links on the page will need a solution

it's a button as link so the screen reader knows it goes to another page ?

The ticket says 56px of padding but it seems to be 80px

was inconsistent with the Figma. Checked with monika and she tolkd me 80px

I feel like the sentence explaining the absence of additional materials is missing a "the". "We're sorry, but THE preview is not currently available".. might just be me overthinking though!

Just following instructions here

@jack-skerrett-oak and @kimon-satan  I've approved 80px looked beet on the site. And if we need "the" then we should add it.

:tada: This PR is included in version 1.268.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Port maping of node red

Can i mount the node red adapter internaly on port 1880, but externally to another port ex: 1888

Sorry, don't get it. Is that a question? Please add some more, detailed information. Thank you.
Regards,
André

Closed for no response.


Test on Matt's computer

@mksoccer please create a project based on this template and create issues if you encounter any problems (or a PR with updated documentation, if you see it is currently wrong). Please work with @varunagrawal and @ProfFan to resolve those issues and review your PRs.

Where is MatlabWrap found? I am having trouble implementing this template given that I am getting the following output with cmake:
cmake ..
-- pybind11 v2.6.0 dev1
CMake Error at CMakeLists.txt:44 (include):
include could not find load file:
MatlabWrap

-- GTSAM include directory:  /usr/local/lib/cmake/GTSAM/../../../include
========== Configuration Options ==========
-- Project:                  example_matlab
-- MATLAB Root:              /usr/local/MATLAB/R2020b
-- Mex Compiler:             /usr/local/MATLAB/R2020b/bin/glnxa64/mex
CMake Error at CMakeLists.txt:91 (matlab_wrap):
Unknown CMake command "matlab_wrap".
-- Configuring incomplete, errors occurred!

You need to install the wrap project first.

I should add that to the README, good catch.

I thought I had the wrap project installed first, but I guess I do not...

I thought you could do it with the wrap inside GTSAM?? We should allow for that, as that will be the 99% use case.

I currently do have wrap inside of GTSAM, which is why I don't understand why its not recognized.

Depends on how you've installed GTSAM. If you've done some custom path stuff, you need to update your PATH and other variables so that CMake can find it.

I found that I needed to tell cmake to install the new project in the same path (for me /Users/dellaert) and then things work.
I recommend never to install in default /usr/local. It hides a bunch of issues our users will experience if they have no root access.

^^ yep precisely what I meant by updating the paths. The CI is configured to use a local path so I don't believe this would be a problem.

I think I have installed GTSAM is a very crude manner and am not sure I have the paths correctly established. I just had to download wrap and install again in order to get it to register the matlab toolbox.
I am now getting the following error:
cmake ..
-- pybind11 v2.6.0 dev1
-- GTSAM include directory:  /usr/local/lib/cmake/GTSAM/../../../include
========== Configuration Options ==========
-- Project:                  example_matlab
-- MATLAB Root:              /usr/local/MATLAB/R2020b
-- Mex Compiler:             /usr/local/MATLAB/R2020b/bin/glnxa64/mex
-- Building wrap module example
-- Installing Matlab Toolbox to /usr/local/gtsam_toolbox
-- Configuring done
CMake Error at /usr/local/lib/cmake/gtwrap/MatlabWrap.cmake:251 (add_library):
Cannot find source file:
target_sources-NOTFOUND

Tried extensions .c .C .c++ .cc .cpp .cxx .cu .m .M .mm .h .hh .h++ .hm
.hpp .hxx .in .txx
Call Stack (most recent call first):
/usr/local/lib/cmake/gtwrap/MatlabWrap.cmake:79 (wrap_library_internal)
/usr/local/lib/cmake/gtwrap/MatlabWrap.cmake:57 (wrap_and_install_library)
CMakeLists.txt:91 (matlab_wrap)
CMake Error at /usr/local/lib/cmake/gtwrap/MatlabWrap.cmake:251 (add_library):
No SOURCES given to target: example_matlab_wrapper
Call Stack (most recent call first):
/usr/local/lib/cmake/gtwrap/MatlabWrap.cmake:79 (wrap_library_internal)
/usr/local/lib/cmake/gtwrap/MatlabWrap.cmake:57 (wrap_and_install_library)
CMakeLists.txt:91 (matlab_wrap)
CMake Generate step failed.  Build files cannot be regenerated correctly.

So I had to remove the build folder and recreate it, but now I am getting stuck with the following error at the sudo make -j8 step:
make -j8
Scanning dependencies of target example_matlab
[ 11%] Building CXX object CMakeFiles/example_matlab.dir/example/PrintExamples.cpp.o
[ 22%] Linking CXX shared library libexample_matlab.so
[ 22%] Built target example_matlab
[ 33%] Generating wrap/example/example_wrapper.cpp
Scanning dependencies of target SayGoodbye
Scanning dependencies of target SayHello
[ 55%] Building CXX object CMakeFiles/SayHello.dir/SayHello.cpp.o
[ 55%] Building CXX object CMakeFiles/SayGoodbye.dir/SayGoodbye.cpp.o
Ignoring classes: []
any suggestions?

So I had to remove the build folder and recreate it, but now I am getting stuck with the following error at the sudo make -j8 step:
make -j8
Scanning dependencies of target example_matlab
[ 11%] Building CXX object CMakeFiles/example_matlab.dir/example/PrintExamples.cpp.o
[ 22%] Linking CXX shared library libexample_matlab.so
[ 22%] Built target example_matlab
[ 33%] Generating wrap/example/example_wrapper.cpp
Scanning dependencies of target SayGoodbye
Scanning dependencies of target SayHello
[ 55%] Building CXX object CMakeFiles/SayHello.dir/SayHello.cpp.o
[ 55%] Building CXX object CMakeFiles/SayGoodbye.dir/SayGoodbye.cpp.o
Ignoring classes: []
any suggestions?

Is this a linking issue here?

I wonder if this is because of linking with GTSAM. I would have to take a closer look to figure this out. I can get on a call later tonight (after 10 pm) or tomorrow.

Yeah, I just managed to get past that error by directly editing the CMakeLists.txt such that I made this change:
`#target_link_libraries(${CONVENIENCE_LIB_NAME} gtsam)
target_link_libraries(${CONVENIENCE_LIB_NAME} /home/matt/Documents/gtsam-project-matlab/build)'.
Now, I am getting the following error:
`make -j8
-- pybind11 v2.6.0 dev1
-- GTSAM include directory:  /usr/local/lib/cmake/GTSAM/../../../include
========== Configuration Options ==========
-- Project:                  example_matlab
-- MATLAB Root:              /usr/local/MATLAB/R2020b
-- Mex Compiler:             /usr/local/MATLAB/R2020b/bin/glnxa64/mex
-- Building wrap module example
-- Installing Matlab Toolbox to /usr/local/gtsam_toolbox
-- Configuring done
WARNING: Target "example_matlab_wrapper" requests linking to directory "/home/matt/Documents/gtsam-project-matlab/build".  Targets may link only to libraries.  CMake is dropping the item.
WARNING: Target "example_matlab_wrapper" requests linking to directory "/home/matt/Documents/gtsam-project-matlab/build".  Targets may link only to libraries.  CMake is dropping the item.
WARNING: Target "testExample" requests linking to directory "/home/matt/Documents/gtsam-project-matlab/build".  Targets may link only to libraries.  CMake is dropping the item.
WARNING: Target "SayGoodbye" requests linking to directory "/home/matt/Documents/gtsam-project-matlab/build".  Targets may link only to libraries.  CMake is dropping the item.
WARNING: Target "example_matlab" requests linking to directory "/home/matt/Documents/gtsam-project-matlab/build".  Targets may link only to libraries.  CMake is dropping the item.
WARNING: Target "SayHello" requests linking to directory "/home/matt/Documents/gtsam-project-matlab/build".  Targets may link only to libraries.  CMake is dropping the item.
-- Generating done
-- Build files have been written to: /home/matt/Documents/gtsam-project-matlab/build
[ 33%] Linking CXX shared library libexample_matlab.so
[ 33%] Built target example_matlab
[ 33%] Generating wrap/example/example_wrapper.cpp
Scanning dependencies of target SayHello
Scanning dependencies of target SayGoodbye
[ 33%] Building CXX object CMakeFiles/SayGoodbye.dir/SayGoodbye.cpp.o
[ 33%] Building CXX object CMakeFiles/SayHello.dir/SayHello.cpp.o
Ignoring classes: []
Scanning dependencies of target example_matlab_wrapper
[ 33%] Building CXX object CMakeFiles/example_matlab_wrapper.dir/wrap/example/example_wrapper.cpp.o
In file included from /usr/local/include/gtwrap/matlab.h:25,
from /home/matt/Documents/gtsam-project-matlab/build/wrap/example/example_wrapper.cpp:1:
/usr/local/include/gtsam/base/Vector.h:29:10: fatal error: Eigen/Core: No such file or directory
29 | #include <Eigen/Core>
|          ^~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/example_matlab_wrapper.dir/build.make:68: CMakeFiles/example_matlab_wrapper.dir/wrap/example/example_wrapper.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:141: CMakeFiles/example_matlab_wrapper.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 33%] Linking CXX executable SayHello
[ 33%] Linking CXX executable SayGoodbye
[ 33%] Built target SayHello
[ 33%] Built target SayGoodbye
make: *** [Makefile:141: all] Error 2
`
which is no good either.

That's because of the above hack. I highly recommend getting the GTSAM install working properly (even if it means installing to /usr/local/lib), that way everything should flow nicely.

How would I know if it is or is not properly installed in /usr/local/lib? It appears I have all the proper files in that location, but is their another way to verify?

Regardless, I am down for a call tonight to revolve this to make sure I have the correct installation location, and procedure

I'll message you once I get back.

I'll message you once I get back.

Sounds good.


PKHeX web

Hi there, I have been having some issues on PKHeX web, because I have a MacBook and it's very complicated to download PKHeX I tried the web version, but every time I try to insert my save file or the Pokemon game I play on city, it says that the file is too large, and I don't know what to do anymore.
I hope to hear back from you soon.
Thank you
Best wishes

Oliver

hello is your nature changing working as mine isnt ?

Hi there, I have been having some issues on PKHeX web, because I have a MacBook and it's very complicated to download PKHeX I tried the web version, but every time I try to insert my save file or the Pokemon game I play on city, it says that the file is too large, and I don't know what to do anymore. I hope to hear back from you soon.
Thank you Best wishes  Oliver

What's the name of the file you're loading into the app? It only supports save files.
Save states are not supported

hello is your nature changing working as mine isnt ?

To avoid confusion we usually open a new issue if it is voor related to any other opened, but I see that editing nature is indeed not working... Will look into it
Issue tracker: https://github.com/arleypadua/PKHeX.Everywhere/issues/95

Sorry about that I'll be sure top post in future sorry again
On Fri, 15 Nov 2024, 8:40 am Arley Pádua, @.***> wrote:

hello is your nature changing working as mine isnt ?
To avoid confusion we usually open a new issue if it is voor related to
any other opened, but I see that editing nature is indeed not working...
Will look into it
Issue tracker: #95
https://github.com/arleypadua/PKHeX.Everywhere/issues/95
—
Reply to this email directly, view it on GitHub
https://github.com/arleypadua/PKHeX.Everywhere/issues/92#issuecomment-2478240606,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A5J6LSKE2Z4ASC22CCEAJ332AWXQZAVCNFSM6AAAAABRPTM57OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZYGI2DANRQGY
.
You are receiving this because you commented.Message ID: <arleypadua/PKHeX
<EMAIL_ADDRESS>

Closing this as it doesn't seem to be an issue related to pkhex web


resolves #22 - display preselected workspace in dropdown menu

All select2 type components do not show already selected options in dropdown.
This is likely confuse users. What is the use case here?

The problem is, we cannot switch back to Workspace 1 after creating a task in Workspace 2. In other words, Workspace 2 and 3 are shown in the dropdown menu even when Workspace 2 is selected. We can type in the name of Workspace 1 to switch to it, but it's not user-friendly.
For multi-selectable fields such as projects and tags, "do not show already selected options in dropdown" is retained even after this solution is applied.


Feature: Intelligent copy/paste shortcuts

Hi!
I'm using the latest release of terminus (Alpha 42). Currently you cannot copy with ctrl+c without removing the "interrupt" shortcut from most shells. So you can either copy text or close programs, but not both. The same problem is for paste.
It would be nice if you could add a kind of "intelligent" copy/paste mode like:
Click ctrl + c while text is marked: Copy the text
Click ctrl + c while no text is marked: Input will be sent to shell
I know there's also a different key combination, but it's not so fast and handy. Also, you could add a config option, so people can choose the current if they (for whatever reason) want so.

This is a fantastic idea! Will certainly implement


[RFC] Admission Control mechanism for Cluster Manager APIs

Is your feature request related to a problem? Please describe.
Today, Cluster Manager can be overwhelmed by sending too many requests which can cause its memory/ CPU to spike and also making its transport busy. This can have unwanted effect on the cluster with critical operations like health checks failing, node-joins/ left processing getting delayed etc. There are circuit breakers which operate based on heap memory usage and would start rejection after a certain threshold is breached. But, it can allow lot of incoming requests as it takes into account incoming request size which would be 0 for most of the get requests. Also, APIs like _cluster/health, _cluster/state which are critical for cluster functioning are not tripped over but their response payload size could be really big potentially in MBs as well. The circuit breakers also don’t handle any prioritization.
OpenSearch already supports Indexing and Search Back Pressure with intelligent resource tracking. The proposal is to build smart admission control for Cluster Manager APIs (eventually back pressure).
Describe the solution you'd like
Cluster Manager availability is critical to overall availability and stability of the cluster. The proposal here is to provide more Intelligent request rejection mechanism which takes into account the pending requests in transport thread pool queue, consider other resources like cpu, handles prioritisation during rejection etc.
For write APIs, there is ClusterManager Task Throttling which should provide protection against too many tasks but few tasks spiking up the resource usage could cause impact. Though in the first phase, the plan is to focus on read APIs only.
In future, there should also be mechanism to cancel the read requests related to admin operation like _cat, _nodes/stats, _cluster APIs which are running for long duration.

I am looking for feedback from the community to evolve this feature from an idea to concrete proposal.

@shwetathareja can you please confirm if this change can be included in 2.x without breaking existing API? Basically can this change be added in a backward compatible manner in 2.x line?
We are evaluating if this change requires 3.0 release or can be included in 2.x line so need your inputs.

@bbarani this feature will be controlled using admission control settings and threshold and can be done in backward compatible manner in 2.x. We will not enable it by default to prevent any breaking change for users in 2.x and will do it once we have 3.0


Use f-strings instead of percent operator or str.format()

Convert all % and str.format() expressions or disable pylint
check where str.format() is more readable.
Partially fixes #6171

The equality of original and new string formatting has been checked by adding assertion checks and printouts in 5ae55fea6139becde908921705891a98dc0b0742.
All assertions passed in a locally run pytest and were thereafter removed in 6909b545c785103d07b7081ce88aba9630f273c7 and 787b1ffe60e18291415d8d441a193fdc57d913ec.


Capistrano should get the release date from the remote system.

Capistrano behaves very badly if any cap commands happen from a system that has an incorrect clock.
Capistrano should use the clock for the deploying system so that if two cap commands happen in rapid succession from two different system (one with an incorrect clock) things will work right.
This came up with https://github.com/carlhuda/bundler/issues/1142 as an example.
Rollbacks won't work right, for example, if the deploying systems have skewed clocks.

You probably need to make sure that clocks are synchronized on all systems you work with.
Thanks to ntp and openntpd, this should be a very simple undertaking nowadays.
If capistrano reads remote server time, how should it behave in a situation like the following:

There are servers A, B and C, all out of sync time-wise
Command X is run on servers A and B
Then, command Y is run on servers B and C

If capistrano read time from the first server, for example, in this case A for X, then by the time Y is run the time would be entirely different anyway.

  It's a VM, so it happens some times.
I was assuming that if you talked to multiple servers then it would get the time from each server and use that for the commands on each server.  Using something like an environmental variable.
At the very least, it makes the concept of 'last' and 'current' suspect, since the timestamps can't be guaranteed to always going forward.
If figuring out which clock is accurate or using the server's clock isn't feasible, you could at least scan the existing timestamps and ensure that the new timestamp is greater than any of the existing ones (across all servers).
Ciao!


Support detecting region from FIPS URLs

Attempt to fix #1662

@harshavardhana Could you please take a look? Thanks. (Apologies if pinging you directly wasn't the right thing to do. I checked the Contributor's guide and couldn't find what I should be doing to request reviews)

@harshavardhana Thanks a lot for the quick action on this one. Much appreciated.
BTW, is a new patch release planned anytime soon? Asking because this issue essentially prevents users from using FIPS endpoints for the GitLab Runner cache - https://gitlab.com/gitlab-org/gitlab-runner/-/issues/29112


increased default font size

I increased the default font size from 16 to 19. I think it looks a little more readable at small sizes, but not sure that it does a ton.

@ebrillhart please check in victory-chart and victory-pie for any font sizes described in defaultStyles if it makes sense for all of the font sizes to be the same you can change the default prop here, otherwise adjust the defaultStyles individually in components

closing to implement default font size on individual components


SQLException: The prepared statement has been finalized

Hi, when I execute the query ";" in the JDBC and get the "The prepared statement has been finalized" error, but there is no error when I execute the query ";" in the cli.
Reproducible test case:
...
Connection connection = connection = DriverManager.getConnection("jdbc:sqlite:sample.db");
Statement statement = connection.createStatement();
statement.executeUpdate(";");
...

The stack trace:
java.lang.AssertionError: ;
        at Sample.Main(Sample.java:17)
Caused by: java.sql.SQLException: The prepared statement has been finalized
        at org.sqlite.core.NativeDB.throwex(NativeDB.java:406)
        at org.sqlite.core.NativeDB.step(Native Method)
        at org.sqlite.core.DB.execute(DB.java:962)
        at org.sqlite.core.CoreStatement.exec(CoreStatement.java:74)
        at org.sqlite.jdbc3.JDBC3Statement.execute(JDBC3Statement.java:41)

SQLite3 JDBC version:
<IP_ADDRESS>
Is it expected?

I'm wondering why you would execute a single command containing only ; though.

It may be randomly generated by my application when converting external data to SQL query.

I just tried the following:
@Test
    public void issue731() throws Exception {
        Connection conn = getConnection();
        Statement stmt = conn.createStatement();
        stmt.executeUpdate(";");
        stmt.close();
        conn.close();
    }

And i don't get any exception.
Can you try with the latest snapshot version to confirm on your side?

@bajinsheng - I think you made a mistake in your test case that fails - I think you intended to call executeQuery(), not executeUpdate(). executeQuery() is a noop. See: https://www.sqlite.org/c3ref/exec.html
I think the bug here is that we throw the wrong error from the wrong place.
Internally, sqlite3 gives us a null pointer from sqlite3_prepare_v2 (https://www.sqlite.org/draft/c3ref/prepare.html) when we create this query.
Oddly enough, I don't get an error from the return code from this function. I don't see that the sqlite3 documentation defines the return code for this scenario, but it's definitely possible that I am missing something.
From the docs:

*ppStmt is left pointing to a compiled prepared statement that can be executed using sqlite3_step(). If there is an error, *ppStmt is set to NULL. If the input text contains no SQL (if the input is an empty string or a comment) then *ppStmt is set to NULL. The calling procedure is responsible for deleting the compiled SQL statement using sqlite3_finalize() after it has finished with it. ppStmt may not be NULL.

Anyways, the exception is thrown because the pointer is set to null with a successful return code. When we try to use it, we check whether it's null first, and throw the already closed exception if it is.
@gotson - I think the issue here is that we should be checking for null in the prepared statement made with sqlite3_prepare_v2. If it is null, we should throw an SQLException that ";" is an invalid query, rather than bombing later. Alternatively we could return a empty ResultSet. What do you think? I haven't seen anything within the JDBC spec for what to do when a noop query is run.

@pyckle i was thinking that in doubt we should check what's the behaviour with another JDBC driver, maybe the PostgreSQL one. What do you think?
I know SQLite itself is usually following the PG implementation.


Fix favorites module qa-functional tests.

Fix favorites module qa-functional tests.

Looks good and is merged. Thank you!


"Capitalize" is not working properly.

Problem description.

In the string: "GERENTE DE TECNOLOGIA DA INFORMAÇÃO," when using the capitalCase method, it returns as follows: "Gerente De Tecnologia Da Informa O," which means it's removing the "Ç" and the "ã".
How can I solve this, knowing that this string is dynamically returned from the API?

This has been fixed with<EMAIL_ADDRESS>Please update and let me know if you still see any issues.


fix regression introduced by register-with-taints pr

What this PR does / why we need it:
Fix E2E regression introduced by #1222
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

fix "registerWithTaints" variable not available in some cases
add a 1.5 kube-proxy template file like other addons

Special notes for your reviewer:
Release note:

This change is

I marked it as P1, since it is a fix of regression.

Thanks @rjtsdl, LGTM. After we get https://github.com/Azure/acs-engine/pull/1249 to add the missing e2e coverage we can rebase this branch to run with those tests.

@seanknox, one question in my mind is, if #1249 will have better coverage, considering the fix is not in before that, the e2e test for #1249 can never pass, right?
So i thought, we should get this in first, and let #1249 rebase on that.


Investigate issue with self-hosted Visual Studio TFS

A user reports the button not showing up in a self hosted version of Visual Studio TFS. Desk case no. 320883

Discussed the issue with the user. It seems that the self hosted Visual Studio had different design. The integration with visualstudio.com does not work with self hosted one. Unless different integration is created for self-hosted version, toggl button cannot be used.


Switch OTLP endpoints to ingest v2

Description
Closes https://github.com/quickwit-oss/quickwit/issues/5209
How was this PR tested?
Integration tests

Integration tests are hanging for OTLP are hanging on shutdown
[INFO  quickwit_ingest::ingest_v2::ingester] decommissioning ingester

Likely related to https://github.com/quickwit-oss/quickwit/issues/5068

After some further analysis, it seems that the ingester decomissioning freeze happens when we stop the cluster right after the first ingestions. Likely race condition:

indexer has no shard, no ingest v2 indexing pipeline is scheduled
indexer receives events, creates a shard
the control plane is shut down before rebuilding the indexing plan, so the pipeline is never scheduled for the shard
the indexer hangs on shutdown because the shard is never indexed

Adding a wait after the ingest to give time to the control plane to schedule an indexing pipeline works but:

the indexing pipeline sometimes becomes irresponsive (no extra logs)
when the indexing goes through, the decommissioning of the indexer still fails. Tries to create a workbench right in the middle of the teardown:

[INFO  quickwit-indexing] index-doc-batches; index_id=otel-logs-v0_7 source_id=_ingest-source pipeline_uid=01J47CHTZPH4SX2J4D6HSVY5RH workbench_id=01J47CJDJEAQBP1NHP0GJTGDMP

Note: the issue mentioned above

on some runs, the indexing pipeline becomes irresponsive (no extra logs)

was not addressed. I didn't manage to consistently reproduce or get more logs.


Server side validation for premium features & limit

Right now access to most premium features is only validated on the client side and there are some ways to circumvent it.
https://ptb.discord.com/channels/730045476459642900/1101585464265281556/1243995812137009163

The same goes for regular limits like the message count limit.


Questions: Methodology for storage

Hi, I am working on a tool to calculate the CO2 emissions of storage on the Cloud, how would I calculate this and what parameters would be appropriate?
Thing I don't understand.
Cloud Providers like AWS and GCP keep backups in order to never loose user data, in the Energy Coefficients, it says the watt hours for HDD is 0.65 WH. Does that account for storing backups or literally storing the files in object storage? Also, regarding networking, how do we know how many times the Data moves between geographical locations? Please be more detailed with what the numbers mean. Thank you in advance.

Hi @ziadomalik, thanks for your question!
Have you taken a look at our deep dive into the storage methodology? You can find details on how we go about calculating storage usage here.
We also do account for storage backups across cloud providers. We refer to these number of backups created as replication factors and it represents the amount of replicated instances that is created by default for that service across regions. Some of these can be cross-located or co-located depending on the approach. The energy coefficient for HDD and SDD devices is for storing on a single instance, and we multiply the emissions for that single instance by the matching replication factor to get the total emissions across each backups for that service.  Our section on replication factors in the storage methodology goes over this in more detail and includes a linked spreadsheet of what factors we use for each supported service.
As for networking, we currently aren't exposed to how many times data moves between geographical locations. Instead, we're utilize how much data (in gigabytes) has been transferred in egress. This information is included as part of the usage that we pull from the billing data of each cloud provider. We then multiply this quantity by our chosen coefficient 0.001 kWh/Gb and the PUE (Power Usage Effectiveness) of that cloud provider. There's a lot of ongoing studies on the best way to go about this, so much like the rest of our methodology we're open to feedback or contributions to improve it.
Hopefully this helps! I'm going to close this issue for now, but feel free to reply with any additional questions and I'm happy to reopen it and address them.

Thank you bro @4upz-tw U a real one.


CVE-2023-3635: Upgrade okhttp/okio dependency

https://osv.dev/vulnerability/GHSA-w33c-445m-f8w7
Simple bumping up okhttp to 4.12.0 should do.

We have addressed the vulnerability mentioned in GHSA-w33c-445m-f8w7 by updating the okhttp dependency to version 4.12.0, as suggested. Thank you for the guidance.

Thank you for addressing it! Works good.


[Apiserver decouple] Second part

What this PR does / why we need it:
See design spec for detailed information.
Please notice that this PR would address Phase 2 of the design spec.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

Coverage increased (+0.5%) to 40.489% when pulling 808ddf83111906424e941f16af276b078791a882 on leonwanghui:second-part into 3acb0c2b8fb64b4431a7c6b9bf059a58c95f0948 on opensds:development.

This patch contains quite big changes with below items:

Merge controller and dock protobuf definition into model protobuf located in model module.
Move all logic about status machine into controller module, except that some database operations when deleting volume group still remains in dock module.
Change CreateAttachmentOpts and UpdateAttachmentOpts definition in protobuf to CreateVolumeAttachmentOpts and UpdateVolumeAttachmentOpts.
Make some changes of volume group operations with dock driver interface, to make it more standard.
Create pkg/model/proto/response.go file for Generating GenericResponse struct easily.
Add some status operations in pkg/db/db.go.
Simplify the ControllerGrpcServer construction by removing pkg/controller/server.go.
Update e2e_test.go to make e2e test output more elegant.

@leonwanghui Can you address my comments, please?  Also need a rebase.

@wisererik Please review this.

@leonwanghui please rebase your PR, thanks

LGTM


python311Packages.google-cloud-tasks: 2.16.1 -> 2.16.2

Changelog: https://github.com/googleapis/google-cloud-python/blob/google-cloud-tasks-v2.16.2/packages/google-cloud-tasks/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 290843 run on x86_64-linux 1

2 packages built:

python311Packages.google-cloud-tasks
python311Packages.google-cloud-tasks.dist


Kirby Air Ride Incorrect Texture Name

Game Name?
Kirby Air Ride
Game ID?
GKY/KHPE01
Input device ID?
Xinput/0/Gamepad
Dolphin version?
5.0-21200
Operating System?
Windows 11
Describe the bug.
Firstly I just want to preface I added KHPE01.txt [Kirby Air Ride Hack Pack] as an additional file in GameID and it worked great.
Regardless on line 2166 "tex1_168x32_74cd9021a1965cf0_14.png" in the "UniversalDIT_Flat.json" should be renamed to "tex1_168x32_40eebf538b65fc35_371c6161b7b43c36_8.png" along with the corresponding file as it does not apply the settings texture at all Custom Textures Notification supports that with 7 being loaded before the fix.
Before:

I also tried to fix the transparency issue for the icons being applied it seems it may be a Dolphin issue on how it applies a file with transparency to a dynamic texture.
Expected behavior.
This is after the fix 8 Custom Textures were Loaded:

This is not a bug, simply other textures are used that are not present in the pack yet.
I could fix this when I have time or you could create a pull request, to support Kirby Air Ride Hack Pack.


Fix/issue 687

Changes
fix: #687
convert backward slash in webmodules path on Windows.
related PR: #661 (forgot to convert backward slash before send response.)
Testing
pass

Thanks for filing! I did some digging and this ended up being caused by a regression elsewhere in the codebase. Added a PR to fix the root issue here: https://github.com/pikapkg/snowpack/pull/731, will work to get this fixed asap. Thanks for your patience!


Error when no lights visible with only the remote control

Hello,
i have a little test setup with one light and one remote control.
When the light was not visible for a while by the tradfri gateway, i got the following error when calling has_light_control:
File "/home/pi/PI_Drivers.py", line 272, in
ikea_drv.lights = [dev for dev in ikea_drv.devs if dev.has_light_control]
File "/usr/local/lib/python3.5/dist-packages/pytradfri-2.2.1-py3.5.egg/pytradfri/device.py", line 51, in has_light_control
return (ATTR_LIGHT_CONTROL in self.raw and
TypeError: argument of type 'NoneType' is not iterable
So there is one device, however not a device with light_control.
The script should catch this.
Ofcourse this is a minor bug.
Thanks for this nice module!
Rudy

Can you please paste the code you're using to cal has_light_control?

i added the test with dev.raw to work around the bug.
Here is the code, apologies for not being pep8 format.
		# ikea_drv.gen_obj = yield from api_factory(ikea_it.ip, ikea_it.secret) #async
		ikea_drv.gen_obj = api_factory(ikea_it.ip, ikea_it.secret) #sync
		ikea_drv.gateway = Gateway()
		ikea_drv.dev_cmd = ikea_drv.gateway.get_devices()
		#ikea_drv.dev_cmds = yield from ikea_drv.gen_obj(ikea_drv.dev_cmd) #async
		#ikea_drv.devs = yield from ikea_drv.gen_obj(*ikea_drv.dev_cmds) #async
		ikea_drv.dev_cmds = ikea_drv.gen_obj(ikea_drv.dev_cmd) #sync
		ikea_drv.devs = ikea_drv.gen_obj(*ikea_drv.dev_cmds) #sync
		ikea_drv.lights = [dev for dev in ikea_drv.devs if dev.raw is not None and dev.has_light_control]
		ikea_drv.sensors = [dev for dev in ikea_drv.devs if dev.raw is not None and not dev.has_light_control]
		ikea_drv.tsk_cmd = ikea_drv.gateway.get_smart_tasks()
		#ikea_drv.tasks = yield from ikea_drv.gen_obj(ikea_drv.tsk_cmd) #async
		ikea_drv.tasks = ikea_drv.gen_obj(ikea_drv.tsk_cmd) #sync
		ikea_drv.grp_cmd = ikea_drv.gateway.get_groups()
		#ikea_drv.grp_cmds = yield from ikea_drv.gen_obj(ikea_drv.grp_cmd) #async
		#ikea_drv.groups = yield from ikea_drv.gen_obj(*ikea_drv.grp_cmds) #async
		ikea_drv.grp_cmds = None if not ikea_drv.lights else ikea_drv.gen_obj(ikea_drv.grp_cmd) #sync
		ikea_drv.groups = [] if not ikea_drv.lights else ikea_drv.gen_obj(*ikea_drv.grp_cmds) #sync
		if type(ikea_drv.groups)!=list: ikea_drv.groups=[ikea_drv.groups] # one group

PRs are always welcome if there’s functionality missing in the lib or if there’s a bug. 😊 Please make a stab at it and become a contributor.

@rudyvan given it any thought to contribute a fix to the main library?

i think the change in device.py should be as follows:
@property
def has_light_control(self):
    return (self.raw is not None and ATTR_LIGHT_CONTROL in self.raw and
                len(self.raw.get(ATTR_LIGHT_CONTROL)) > 0)

alternatively the conditional could be shortened as:
return (self.raw is not None and len(self.raw.get(ATTR_LIGHT_CONTROL,"")) > 0)

i don't know github that well to start a branch and ask for a pull

@rudyvan that's a pity! I didn't know much either when I started this project but there are many out there to help. In short: you fork a repo (from the github web page), create a new branch (can be done using the desktop app), switch to that branch (can also be done using the desktop app), make the changes in the device.py, test functionality, check in the code and then make a pull request based on that branch.

@rudyvan https://opensource.guide/how-to-contribute/#opening-a-pull-request
if you're interested. Everyone's welcome! Plus if you make 4 contributions
in during Hacktober you get a free t-shirt 👍
On Sun, 15 Oct 2017, 4:09 pm Patrik<EMAIL_ADDRESS>wrote:

@rudyvan https://github.com/rudyvan that's a pity! I didn't know much
either when I started this project but there are many out there to help. In
short: you fork a repo (from the github web page), create a new branch (can
be done using the desktop app), switch to that branch (can also be done
using the desktop app), make the changes in the device.py, test
functionality, check in the code and then make a pull request based on that
branch.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ggravlingen/pytradfri/issues/59#issuecomment-336718090,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA1TO4NGgpHMCXEfiGglQVKDn1T00mTlks5ssiA2gaJpZM4PiRSU
.


How can i sign in with @yahoo.com.vn instead @gmail.com

I used with gmail , it works... But i can not sign in with my old Fb account which end @yahoo.com.vn
Is anyone suggest any solution ?? Thank in advance

Hello, every email should work. Please, what is output from console ?

output says "wrong username or password", but when i try to sign in with gmail, it works...I have already signed in with gmail, just report can not sign in with yahoo..thank for answer!!

Nothing more? Then you really have wrong username or password.

are you sure that you don't have any extra characters? maybe spaces?

@aqquan2017 Do you have \ character in your password?

i just have _

does using this email address on facebook.com work? maybe you are using address that is not confirmed

yep gmail address is already work...just for you guy know i cant sign in with @yahoo.com, may be problem come from my fb account...Yahoo is very old

so... is it  @yahoo.com or @yahoo.com.vn? and can you login on facebook.com (manually - in browser) with that address?

it normally work in browser...and it @yahoo.com.vn

I'm almost 100% sure that you just have a typo somewhere.... double check it
or try with clean project like another user did recently #688

https://drive.google.com/drive/u/0/folders/1AmWcuA89R2aUswvx_l3IWvCMtUdrNQDk
you can see problem here...video inside

Yeah, we don't process the email in any way as far as I can tell. You can check if the browser escapes it or something by watching the login request go through in the browser and comparing it to the one we make.

Can we close it?

thank for your help...i doing great...close!!

Thanks everyone


[CI] Implement caching for faster builds

We're already implemented it for @timemates/timemates-sdk, but we also need it there

closed within #42


AzureFileCopy Source attribute do not support patterns

The problem is that Source parameter of AzureFileCopy task do not support expressions like **/*.zip
So I do not able to copy several files by one step.

Closing this. Please reopen if required.


Need a reports map

With a reports map it's easier to find out which areas has the highest number of reports and It'll be easier to filter the areas that civilians need to stay alert

Added #92 Commit: 68819da


fix init_parser_plugins for python 3.12

Hotfix for users on python 3.12, which broke because the entry points no longer return as a dictionary in that version, so  .select(group='lute.plugin.parse') is used instead.
Additional logic was added to handle version differences, both in terms of fetching the entry points from the method and processing them (a catch for None was added)
Solves:

https://github.com/LuteOrg/lute-v3/issues/424

Code included in updated #426 , cheers!


Fix updating of NumTombstones in block.Delete(..)

Fixes https://github.com/prometheus/tsdb/issues/384
Signed-off-by: Ganesh Vernekar<EMAIL_ADDRESS>

I would say something like this would be a bit more clear and better to avoid races:

// TombstoneReader gives access to tombstone intervals by series reference.
type TombstoneReader interface {
	...
        // Total returns the total count of Tombstones.
	Total() uint64
}

func (t *memTombstones) Total() uint64 {
	t.mtx.RLock()
	defer t.mtx.RUnlock()

	var total uint64
	for _, intvs := range t.intvlGroups {
		total += uint64(len(intvs))
	}
	return total
}

func (pb *Block) Delete
....
pb.meta.Stats.NumTombstones = pb.tombstones.Total()

There wont be any race condition in the current change, but what you proposed looks good. I will add that function.

LGTM
ping @gouthamve

Thanks!


Sqlite Location

My test app is almost running fine. I managed to drop the db in the corret folder when i do ... start and it works like a charm. However, when i do a build, I cannot seem to get the location where the context expects the sqlite db to be. I have dropped it in almost every folder but it appears stuck there.
My DbContext is simply

optionsBuilder.UseSqlite("Data Source=assistant.db;", x =>
            {
                x.SuppressForeignKeyEnforcement(false);
                x.UseRelationalNulls(true);
            });
When i run dotnet project.dll, it executes fine without any error. If i start the electon app however, the error occurs

In the past we had an issue with path locations, but it seems you have tried everything possible location for the db? https://github.com/ElectronNET/Electron.NET/issues/72
Another issue related to SqlLite https://github.com/ElectronNET/Electron.NET/issues/82
If nothing helps: Could you provide a very simple demo application?

As i work on the sample demo app, It may interest you that when i run dotnet eletronize start it actually expects the sqlite db to be in the .bin folder in the node_modules. I am surprised such a folder could be created because i cannot manually create such a folder, but it works at that point. I observed that appeared to be the working folder.
when i try dotnet electronize build /target win7-x86, such folder is not created and it fails at that point.

https://github.com/kwakuduahc1/Electron.git
Kindly find the demo application there. I used automatic migrations and it seems to work now. It creates the database and that seems to work. I copied the db into the folder where the sample project created the db and that still fails. I am investigation and would share any development.
The trick was to use automatic migrations


Received warning 'normed' kwarg is depreciated and changed to 'density' kwarg

for idx, feature in enumerate(list(dataset.columns)[:-1]):
fg = sns.FacetGrid(dataset, hue='Survival Status', size=5)
fg.map(sns.distplot, feature).add_legend()
plt.show()
Thanks

Hi @harshit0712, thanks for reaching out to us. Can you provide the following information, so we can better understand what the issue is?

OS version and python version you're using
FlowCal version
An explanation of the code you sent. In particular, it is not clear what part of that code is a FlowCal object or function. It would also be useful if you described what the expected behavior from the code you sent is, and what the actual behavior is.

Thanks.


configure lobsters.dev

I picked up lobsters.dev to serve as a backup domain in case of registrar/registry issues. With the general motivation of "better to have it and not need it", we should edit the DNS records to point to the prod server, add it to the config here, and it to /about.

I've copied over the zone file from lobste.rs to lobsters.dev. I did not include the acme record for Let's Encrypt, or the domainkey becaues it looked like a hash based on domain name.

Welp, latter was identifying a public key, no hash of the domain like I assumed, so I've copied it at @alanpost's direction.

FYI the certificate presented by lobsters.dev right now is for lobste.rs (only), which combined with HSTS means that browsers refuse to load lobsters.dev.
Adding lobsters.dev as an alt on the certificate might be one solution, although I'm not sure if there are downsides.

With the server rebuild last month I configured certbot to request a cert for lobsters.dev. A few minutes ago I committed 5ac42b3 to serve a placeholder page.


Success URL appended with ? despite it has already query params in it

Problem
Unable to log in to dApps. The success URL after request sign-in method is appended with ? despite it has already query params in it.
Just found this on testnet. However, by the time I write this issue, it still working normally on mainnet
Expected Behavior
Wallet returns correct URL which results in successful login on dApps
Steps to reproduce

Wallet.requestSignIn from current URL appended with params ex: https://paras.id/search?q=query
Connect the near account to dApps
The URL changes to: https://paras.id/search?q=query?account_id=...&public_key=...&all_keys=... with double ?, which resulted in failed login

If I'm not mistaken a few days ago was still normal, perhaps this may be the cause: https://github.com/near/near-wallet/blob/master/packages/frontend/src/redux/actions/account.js#L210

We're experiencing the same problem. Bumping this issue ^

Thanks for the report folks!
@esaminu Could be related to the recent query-string changes, especially since this is only on Testnet -- could you investigate?

Also looks related: experiencing issues sining in when there are already url params in the redirect url.
For example signing in from https://testnet.rainbowbridge.app/transfer

@MaximusHaximus @esaminu The fix improved it, but at login, when redirecting to https://testnet.rainbowbridge.app/transfer, the /transferpath was removed and redirected to https://testnet.rainbowbridge.app instead

I have a weird behavior now. I develop a browser extension, where callback url looks like chrome-extension://ogcojbmjgfbdhgoedagklhoginpblbon/callback.html?request_id=af67c1511c3648588f390acd8d574507&success=true and after authorization the wallet redirects me to chrome-extension://invalid/

Thanks guys! Pathname that was omitted in previous PR has been readded in #2451 😃

Thanks guys! Pathname that was omitted in previous PR has been readded in #2451 😃

We're waiting the release ;)


Use shared notification center delegate

Initial implementation.
Tests pending.

Exciting stuff mate!!

It seems this travis failure isn't related to this PR.
I've tested it with the demo app on iOS and haven't run into any issues. @EddyVerbruggen if you could validate it, it would be amazing!
Once this and https://github.com/EddyVerbruggen/nativescript-plugin-firebase/pull/1272 are properly tested I'll release<EMAIL_ADDRESS>prior to the merge.

I tried @edusperoni's version and it resolved my issues with the appdelegate being overwritten. Haven't experienced any other issues. Keen to get this merged.

Works like a charm, thanks! And sorry for the delay.


V1.4 updates

Still running some conformance tests and looking for more actionable changes in the release notes. I will update the default hyperkube image once a non pre-release version is out.
Notably, I noticed we can now curl the static assets in yaml and not json.

@pbx0 can you also update the addon manifests in the Documentation?

lgtm

Are we planning on doing a release to cover these or wait for it to shake out a few days?
This is the only way we get the docs updated cleanly.

@robszumski I imagine we will wait a few days before cutting a coreos-kubernetes release. I guess we'll try to coordinate the doc sync for when we cut the release?
I plan to merge this soon -- just re-running a few tests for a sanity check.

FWIW I would lean towards cutting a release as soon as possible. Not sure what waiting really gets us (previous releases are still there). /cc @colhom


remove static route for custom vpc

Pull Request

[x] Make sure you have followed Kube-OVN Code Style.

What type of this PR
Examples of user facing changes:

Features
Bug fixes
Docs
Tests

Which issue(s) this PR fixes
Fixes #3646
WHAT
copilot:summary
copilot:poem
HOW
copilot:walkthrough

docs update: https://github.com/kubeovn/docs/pull/151

@zcq98 please fix the golangci-lint error


Fixing missing BungeeCord version

Dane can't spell.
Fixes the BungeeCord download issue for all BungeeCord Versions.

Oh dear.
Will write an additional migration to cover updating the existing services and then pull.

This was a mistake on my part, please re-create this PR for the develop branch, not master.


[CP] Automatically delete temporary video and image files generated during the process

Added because too many temporary files generated by the process

Resolved


Server sending wrong timestamp to client

I'm replicating this issue first opened on client repository (in https://github.com/OpenBazaar/openbazaar-desktop/issues/757):
v.2.0.9
This happens when a sale is done with vendor offline.
When vendor goes online again the following notification appears:

I understand that it means that notification has just arrived a few seconds ago, but when you read the sentence it seems that someone has just bought something. On this case, customer had bought 4 days before.

I guess this is a broader issue of how notifications are supposed to be displayed. Currently the notification list is sorted by timestamp. So I put a different timestamp on the notification it risks going down farther in the list and having the user miss it. @morebrownies


[TRIVIAL] Add consensus tests to CMake (RIPD-1482)

@mellery451 noticed that the consensus unit tests were missing from the non-unity CMake builds.

Codecov Report

Merging #2153 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2153      +/-   ##
===========================================
- Coverage    69.01%   69.01%   -0.01%
===========================================
  Files          684      684
  Lines        50468    50468
===========================================
- Hits         34833    34830       -3
- Misses       15635    15638       +3

Impacted Files
Coverage Δ

src/ripple/app/ledger/PendingSaves.h
93.54% <0%> (-6.46%)
:arrow_down:

src/ripple/server/impl/BaseWSPeer.h
67.5% <0%> (-0.63%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b0d482...1539be3. Read the comment docs.

Merged into 0.80.0-b1


Duplicate SSA variables

examples/then.spkl produces the following optimized SSA:
main: Graph {
    inputs: [],
    assignments: [
        [v6] <- [] I32(
            0,
        ),
        [] <- [v6] PrintlnI32,
        [v6] <- [] I32(
            2,
        ),
        [] <- [v6] PrintlnI32,
        [v6] <- [] I32(
            4,
        ),
        [] <- [v6] PrintlnI32,
    ],
    outputs: [],
}

Reduced example:
fn case : bool → do
  then
    1 println
  end
end

fn main : → do
  true case
  true case
end

main: Graph {
    inputs: [],
    assignments: [
        [v1] <- [] I32(
            1,
        ),
        [] <- [v1] PrintlnI32,
        [v1] <- [] I32(
            1,
        ),
        [] <- [v1] PrintlnI32,
    ],
    outputs: [],
}

We're not refreshing nested graphs during inlining!

Fixed.

Fixed it again.


Add YAHS

This PR adds YAHS.
Installation sequence for tool-installers

[x] Test using @galaxybot test this
[x] Inspect CI output for expected changes
[ ] Deploy using @galaxybot deploy this if test install was successful
[ ] Merge this PR

@galaxybot test this

@galaxybot deploy this


Upgrade maven-javadoc-plugin 3.5.0 -> 3.6.0

This PR contains the following updates:

Package
Type
Update
Change

maven-javadoc-plugin
build
minor
3.5.0 -> 3.6.0

[ ] If you want to rebase/retry this PR, check this box

Suggested commit message:
Upgrade maven-javadoc-plugin 3.5.0 -> 3.6.0

See:
- https://github.com/apache/maven-javadoc-plugin/releases/tag/maven-javadoc-plugin-3.6.0
- https://github.com/apache/maven-javadoc-plugin/compare/maven-javadoc-plugin-3.5.0...maven-javadoc-plugin-3.6.0


First zoom doesn't move scale to within scaleExtent

I'm not sure this would be considered a bug, but it certainly caught me off guard and took a lot of time to track down. Panning/dragging works fine, the problem is only with zoom. The problem seems to happen with mouse wheel or pinch zoom.
Here's my (relevant) code for a d3 map visualization:
const limit = 10; // in my real situation, this isn't a constant but determined from a map projection fit to the containing client bbox

const zoom = d3
  .zoom<SVGSVGElement, unknown>()
  .scaleExtent([limit, limit * 10])
  .on("zoom", (event) => updateMap(event));

svg.call(zoom);

svg
  .on("wheel", (event) => event.preventDefault())
  .on("dblclick.zoom", () => {
    zoom.transform(svg, d3.zoomIdentity);
    resetProjection();
    updateMap();
  });

What happened:
While testing on a touch device, I saw that the first pinch zoom on the map did not zoom in, it only panned. On inspection, this is because the event.transform.k being emitted was constant (limit), and not increasing as I pulled my fingers apart. However, after zooming or panning once, the next zoom would work just fine (k would increase).
I eventually figured out that d3-zoom's "internal k" was increasing (as opposed to the emitted transform.k, clamped to scaleExtent), but since it starts off at 1 by default, and limit was a lot higher than that, I simply needed to keep pulling my fingers apart -- like the entire width of my screen -- until the emitted transform.k started increasing.
So I think the scale isn't truly (internally) getting clamped to the scaleExtent until after the first zoom (or pan) completes. I'd expect the transform to be instantiated to values within the scaleExtent, translateExtent, etc.
The solution to all this, for me, is to manually set the scale to the lower limit, right after initializing zoom and also on the double click reset: zoom.scaleTo(svg, limit);

Is this maybe linked to note 8 of the README (introduced here)?

No, that is about ignoring events when trying to go beyond the scaleExtent while currently within it, i.e. trying to zoom in above the upper scale limit, or zoom out below the lower scale limit. This is about starting below the lower scale limit and trying to go up to it.
Technically the k being emitted is clamped to the lower scale limit, but whatever d3-zoom is doing internally to track the progression of zoom isn't working quite right. On every tick of zooming in (one mouse wheel notch, or one touchmove event for pinch zoom), the scale should first be brought to within the scaleExtent, then increased/decreased from there based on the relative "delta k" since the last tick.
I'll try to decipher the code and find the source of the issue.


Allow specifying the full listen address in config

Adapted from the changes suggested by @hsblhsn in #66 but I decided it was better to allow the newer config field to fully specify the listen addresses and fallback to just the port on the unspecified address if that was all that was provided.

Codecov Report

Merging #70 (0a30f95) into main (6632659) will increase coverage by 0.19%.
The diff coverage is 69.23%.

@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
+ Coverage   66.33%   66.53%   +0.19%
==========================================
  Files          24       24
  Lines        2513     2519       +6
==========================================
+ Hits         1667     1676       +9
+ Misses        727      724       -3
  Partials      119      119

Impacted Files
Coverage Δ

config.go
7.08% <69.23%> (+7.08%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6632659...0a30f95. Read the comment docs.


Remove service and route plugins.

Service plugin functionality is now included in kubernetes.go
Route plugin functionality is now included in the openshift plugin

/lgtm


ID for margin orders

Describe the problem:
When placing margin orders, the response does not return a ID.
Observed Results:

Placed margin order - did not get an ID in response
I recommend that an order ID be returned in JSON response

Relevant code exceptions or logs
Code Sample, a copy-pastable example
API_KEY, SECRET_KEY = "####", "####"
bitbnsObj = bitbns(API_KEY, SECRET_KEY)
bitbnsObj.placeMarginOrders({'symbol': 'BTC', 'side': 'placeOrder', 'type': 'BORROW', 'qnty': 0.00102, 'days': 1, 'rate': 0.000001})

logs, a copy-pastable example
{
 'status': 1,
 'error': 'Successfully placed borrow order for Margin trading.',
 'code': 200
}

id has been added now


Decide what kind of pizza we want.

Need to choose the pizza. Pizza template:

Size:
Bread Type:
Cheese Type:
Sauce:
Toppings:

Size: Large
Bread Type: White bread
Cheese Type: Mozzarella cheese
Sauce: Tomato sauce
Toppings: Pepperoni, Mushrooms, Green Peppers

Size: Extra- Large
Bread Type: White Bread
Cheese Type: Marble Cheese
Sauce: Garlic Sauce
Toppings: Pepperoni & Donair


Crashes when I try to paste

Describe the bug
When I try to paste using the hotkeys, it crashes discord. It crashes even if the paste field for a hotkey is empty.
To Reproduce
Use any of the F-keys
Infomation (please complete the following information)
Discord channel: Canary
OS: Windows 11
Mod: Powercord
Discord language: English

Oh this was solve a while ago, I forgot to close lol


merge package from arlac77/npm-package-template-esm-only

package.json

chore(scripts): cover@#overwrite c8 --temp-directory build/coverage ava && c8 report -r lcov --temp-directory build/coverage
chore(scripts): posttest@markdown-doctest
chore(engines<EMAIL_ADDRESS>
.travis.yml

chore(travis): remove node versions 10.15.2,11.10.1
chore(travis): add node versions -10,-11,10.15.3,11.11.0

Codecov Report

Merging #479 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #479   +/-   ##
=======================================
  Coverage   74.36%   74.36%
=======================================
  Files           2        2
  Lines         476      476
=======================================
  Hits          354      354
  Misses        122      122

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02f8c38...5e06449. Read the comment docs.

Coverage remained the same at 71.972% when pulling 5e0644901c147444631f2cc7cd1c5761856f4bec on template-sync-1 into 02f8c381465fd0397bcb3bb6ea53714f6ee9f8f1 on master.

:tada: This PR is included in version 3.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: