Avoid double effects transition when using fingerprint unlock

When using different effects for the home screen and lock screen, turning off the screen will trigger the change to the lock screen effects. However, because the screen is off, the transition won't run until the screen turns back on.
This leads to a situation where if you use a fingerprint to both turn on the screen and unlock the device, you see a transition to the lock screen effects, then back to the home screen effects instead of immediately seeing the home screen effects.

Also valid to normal unlock without fingerprint. The transition from home settings to lockscreen settings is just not useful, and becomes a distraction in most cases. Should be removed.

mb about # 686. So why should this be removed?  The transition is too much delayed right now.

We've removed the transition to the lock screen effects - Muzei will instantly be on the lock screen effects when you turn your screen on.

wow, thanks for this. I've been "suffering in silence" for a while. I love Muzei but that's one thing that really annoyed me.


false negative for indent rule on class properties

Static class properties break the indent rule for static class properties, class member fields, and all following class members.
For example, gIven the following .eslintrc.js:
module.exports = {
  root: true,
  extends: 'airbnb',
  parser: 'babel-eslint',
  rules: {
    'react/prefer-stateless-function': 'off',
  },
};

The following class definition is fine, as expected:
import PropTypes from 'prop-types';
import React from 'react';

export default class Foo extends React.Component {
  static propTypes = {
    title: PropTypes.string,
  }

  static defaultProps = {
    title: 'Bar',
  }

  render() {
    const {
      title,
    } = this.props;

    return (

        {title}

    );
  }
}

However, the following is (unexpectedly) fine as well:
import PropTypes from 'prop-types';
import React from 'react';

export default class Foo extends React.Component {
    static propTypes = {  // indentation doesn’t matter
      title: PropTypes.string,
    }

      static defaultProps = {  // indentation doesn’t matter
        title: 'Bar',
      }

      render() {  // indentation must be aligned with defaultProps.
        const {
          title,
        } = this.props;

        return (

            {title}

        );
      }
}

The same goes for class members
import PropTypes from 'prop-types';
import React from 'react';

export default class Foo extends React.Component {
      state = {  // indentation doesn’t matter
        title: 'Bar',
      }

      render() {  // indentation must be aligned with state.
        const {
          title,
        } = this.state;

        return (

            {title}

        );
      }
}

I would expect the indent rule to warn about indentation of properties as well.
I reported this here, because it’s about stage-X syntax, which is not supported by ESLint natively.

I'm seeing this as well, and haven't found a good solution for it yet.
class Create extends Component {
                    state = {
                      clearVisible: false,
                    }
            clearForm = () => {
              this.setState((prevState) => ({
                clearVisible: !prevState.clearVisible,
              }))
            }
  openDialog = () => {
    this.props.setCreateVisibility(true)
  }
  closeDialog = () => {
    if (this.props.create.fields.anomalyId) {
      this.props.clearCreateForm()
    }
    this.props.setCreateVisibility(false)
  }

Seems like any class property or arrow function's indentation doesn't matter, and the last one will dictate the indentation level of any regular class function declarations after it.

I'm also seeing this.

Same here, anybody found a solution yet?

same too, and static class properties break the space-infix-ops rule as well

Thank you for the issue. Now that @babel/eslint-parser has been released, we are making this repository read-only. If this is a change you would still like to advocate for, please reopen this in the babel/babel monorepo.


Basic Foundation 6 Install with SASS

Ok, so I have pored over the documentation and searched the corners of the web but I can't wrap my head around what feels like it should be simple. I am building a site using Drupal 8 and would like to use Foundation 6 as the basis for my custom theme. I prefer SCSS over vanilla CSS.
What are the bare minimum files I should be downloading? I don't need a compiler or templates or any of that. Just the SCSS and JavaScript. I would like to have the entire framework available to me and I'll just load what I need as I need it.
In other words, is there some kind of zip file I can just download and stick somewhere without all of these myriad node_modules folders, etc? jQuery is already part of Drupal so I don't need that either. Just Foundation as it stands.
This was a cinch with Foundation 5 but with 6 it seems so convoluted. Maybe I'm just not understanding? (Very possible, nay likely. :) )
Thanks much!
P.S. Of course ideally I would have used Composer for this, since Drupal 8 does, but as another issue points out, Packagist isn't cooperating with Zurb on that.

Did you see in the documentation? You can install foundation with npm and then use it for create a basic or full foundation build.

As well?
php composer.phar require zurb/foundation-sites

https://github.com/zurb/foundation-sites#setup
You will receive all scripts and components... No?

I did end up finding my way by picking apart the Foundation for Sites download. :) Thanks very much for your reply. When composer finally gets worked out, I'll switch to that method. Thanks again!

Any pointers as to how you "picked it apart". I'm about to do the same thing... Want to use as much of the built in Foundation goodness as possible...


Future-proof auto dependency handling

Today I've upgraded to Vagrant 1.7.3 and VirtualBox 5.0 and now my VMs refusing to mount. This problem is very common and waste so much time.
I think we should make plugin future-proof and handle it for user automatically pull package list from OS repo, install/upgrade linux headers, dkms, gcc, etc.
 apt-get update && apt-get install -y linux-headers-generic > /dev/null
 yum install -y yum-plugin-fastestmirror && yum update -y && yum install -y kernel-devel dkms build-essential
smth like that. What do you think?

Hi @evrial ,
that's actually what all current installers (try) to do. You probably ran into some common issue where the way of guessing the correct name of the kernel herders package (matching the installed kernel version) does not work out. This issue is especially hard on centos, where older kernel header packages are removed from their repositories.
For example the ubuntu installer runs apt-get install -y  linux-headers-$(uname -r), the centos installer runs yum install -y kernel-devel-$(uname -r).
I'm very open for suggestions how to make this better. (Although I still don't like any options that would require to upgrade the installed kernel)


Added android release workflow

Creates a new release with an apk, every time a new commit gets pushed.
(This is the pull request to #13)
You will need to add a personal access token to an account that has access to create releases in this repository.

Then add the generated token as a secret to this repo and name it GH_TOKEN.

If you have any questions feel free to ask me :)

Hi @ecrax, is the flutter test working in the Action?

Hi @ecrax, is the flutter test working in the Action?

Yes it worked for me.


Allow arbitrary number of prop objects to be passed to mergeProps

Currently mergeProps only allows 2 arguments to be passed in at a time, which results in extra nesting whenever there are more than 2 prop objects that need to be merged, as seen in this example.
So instead of:
let props = mergeProps(mergeProps(buttonProps, hoverProps), focusProps)

You can just do:
let props = mergeProps(buttonProps, hoverProps, focusProps)

@devongovett mentioned on twitter that the team ran into issues with TypeScript handling an arbitrary number.
I was able to find a solution on stackoverflow that helped me solve this, which I cited in the source code.
Please let me know if any more testing needs to be done or if there are any other steps I should take on this PR.

Wow, awesome! Thanks for tackling this.

Thank you! 😍


Vertica urns lack database name

with Vertica URNs don't contain database name
In my case I'm trying to build a joint lineage between Vertica and dbt, and they don't connect. If I understand correctly, it's because tables described by dbt have urn of urn:li:dataPlatform:vertica,dbaname.schema.table, but tables ingested from Vertica have urns of urn:li:dataPlatform:vertica,schema.table.
Originally posted by @heyromnivan in https://github.com/datahub-project/datahub/issues/5483#issuecomment-2079250670

0.13.1
It does look like an issue to me as this makes Vertica basically incompatible with any other metadata source. Even though Vertica itself doesn't allow multiple databases, it still has a database concept and external tools (dbt, BI tools) are all designed to take db name into account when constructing urns.
The only way I found is to make a custom source extending VerticaSource and overriding get_identifier method.
from datahub.ingestion.source.sql.vertica import VerticaSource, VerticaConfig
from vertica_sqlalchemy_dialect.base import VerticaInspector

@platform_name("Vertica")
@config_class(VerticaConfig)
# copy here all the decorators from the latest version of VerticaSource
class MyVerticaSource(VerticaSource):
    def get_identifier(self, *, schema: str, entity: str, inspector: VerticaInspector, **kwargs) -> str:
        db_name = self.get_db_name(inspector)
        return f'{db_name}.{schema}.{entity}'

This can only be used with CLI ingestion which cannot be scheduled or run through DataHub UI, so it has to be automated with some external tool.


[FR] make it possible to install without prompting user

Linux, bash
Provide optional flag for install script, so all the defaults would be selected. This way it'd be easier to install it by custom scripts that shouldn't depend on user interaction.

Already possible:
yes n | ~/.fzf/install

So that's what yes is for. Cheers.

Thanks @justinmk.
You also can use ./install --all.
> ./install --help
usage: ./install [OPTIONS]

    --help               Show this message
    --bin                Download fzf binary only; Do not generate ~/.fzf.{bash,zsh}
    --all                Download fzf binary and update configuration files
                         to enable key bindings and fuzzy completion
    --[no-]key-bindings  Enable/disable key bindings (CTRL-T, CTRL-R, ALT-C)
    --[no-]completion    Enable/disable fuzzy completion (bash & zsh)
    --[no-]update-rc     Whether or not to update shell configuration files

    --32                 Download 32-bit binary
    --64                 Download 64-bit binary

./install --bin is another useful option for those who don't want the extra stuff.


Aspect Ration Swapper Button

Feature Idea
Request for an aspect ration swap button as discussed on discord here....
https://discord.com/channels/1243166023859961988/1243185862234210389/1283634215753093186
Other
No response

duplicate of https://github.com/mcmonkeyprojects/SwarmUI/issues/210


Node v6: v8::ObjectTemplate::Set() with non-primitive values is deprecated  and will stop working in the next major release.

Operating System and Hardware: OS X 10.11.4,  2015 Macbook Pro
NodeJS Version: v6.0.0
Serialport version: v3.0.1 or master
Python Version: 2.7.10
Expected behavior
No warning message
Actual behavior
Using this library on node v6, or even just running npm test prints this near the top of the output:
(node) v8::ObjectTemplate::Set() with non-primitive values is deprecated
(node) and will stop working in the next major release.

==== JS stack trace =========================================

Security context: 0x3f87617c9fa9 <JS Object>#0#
    1: .node [module.js:568] [pc=0x2a635285c24] (this=0x30a892bf1239 <an Object with map 0x1493c7842bb9>#1#,module=0x268b6bb69539 <a Module with map 0x1493c78181b9>#2#,filename=0x268b6bb69511 <String[61]: /Users/nfriedly/node-serialport/build/Release/serialport.node>)
    2: load [/Users/nfriedly/node-serialport/node_modules/coffee-script/lib/coffee-script/register.js:~40] [pc=0x2a6352134e2] (this=0x268b6bb69539 <a Module with map 0x1493c78181b9>#2#,filename=0x268b6bb69511 <String[61]: /Users/nfriedly/node-serialport/build/Release/serialport.node>)
    3: tryModuleLoad(aka tryModuleLoad) [module.js:415] [pc=0x2a634a3899d] (this=0x3f8761704189 <undefined>,module=0x268b6bb69539 <a Module with map 0x1493c78181b9>#2#,filename=0x268b6bb69511 <String[61]: /Users/nfriedly/node-serialport/build/Release/serialport.node>)
    4: _load [module.js:407] [pc=0x2a634a345e2] (this=0x30a892bf12b9 <JS Function 1: v8::Template::Set(v8::Local<v8::Name>, v8::Local<v8::Data>, v8::PropertyAttribute)
 2: SerialportPoller::Init(v8::Local<v8::Object>)
 3: init
 4: node::DLOpen(v8::FunctionCallbackInfo<v8::Value> const&)
 5: v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&))
 6: v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::Isolate*, v8::internal::(anonymous namespace)::BuiltinArguments<(v8::internal::BuiltinExtraArguments)1>)
 7: v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*)
 8: 0x2a63490961b
 9: 0x2a635285c24
(node) v8::ObjectTemplate::Set() with non-primitive values is deprecated
(node) and will stop working in the next major release.

==== JS stack trace =========================================

Security context: 0x3f87617c9fa9 <JS Object>#0#
    1: .node [module.js:568] [pc=0x2a635285c24] (this=0x30a892bf1239 <an Object with map 0x1493c7842bb9>#1#,module=0x268b6bb69539 <a Module with map 0x1493c78181b9>#2#,filename=0x268b6bb69511 <String[61]: /Users/nfriedly/node-serialport/build/Release/serialport.node>)
    2: load [/Users/nfriedly/node-serialport/node_modules/coffee-script/lib/coffee-script/register.js:~40] [pc=0x2a6352134e2] (this=0x268b6bb69539 <a Module with map 0x1493c78181b9>#2#,filename=0x268b6bb69511 <String[61]: /Users/nfriedly/node-serialport/build/Release/serialport.node>)
    3: tryModuleLoad(aka tryModuleLoad) [module.js:415] [pc=0x2a634a3899d] (this=0x3f8761704189 <undefined>,module=0x268b6bb69539 <a Module with map 0x1493c78181b9>#2#,filename=0x268b6bb69511 <String[61]: /Users/nfriedly/node-serialport/build/Release/serialport.node>)
    4: _load [module.js:407] [pc=0x2a634a345e2] (this=0x30a892bf12b9 <JS Function 1: v8::Template::Set(v8::Local<v8::Name>, v8::Local<v8::Data>, v8::PropertyAttribute)
 2: SerialportPoller::Init(v8::Local<v8::Object>)
 3: init
 4: node::DLOpen(v8::FunctionCallbackInfo<v8::Value> const&)
 5: v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&))
 6: v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::Isolate*, v8::internal::(anonymous namespace)::BuiltinArguments<(v8::internal::BuiltinExtraArguments)1>)
 7: v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*)
 8: 0x2a63490961b
 9: 0x2a635285c24

Steps and/or code to reproduce the issue
clone the repo, run npm install && npm test on node.js v6

I'm pretty sure it's this line causing the trouble: https://github.com/voodootikigod/node-serialport/blob/master/src/serialport_poller.cpp#L71 but I'm not yet sure what the appropriate change is.

Op, sorry I see now that this is already covered in the readme. I was using it indirectly (via particle-cli) and didn't catch that at first.

@nfriedly particle-cli depends on serialport ^2.0.1, not 3.0.1. This issue should be fixed on master. Did you really clone master and see the issue?

I cloned particle-cli master and bumped it to use node-serialport v3.0.1 hoping that would fix it, but I still saw the same issue.
Then I cloned node-serialport master and just did npm install; npm test and saw that it to had the same issue cropping up in the test output.

(I then spent about 20 minutes fiddling around with c++ and nan, hoping to send a PR rather than a bug report before admitting that I didn't know what I was doing...)

A few things need to be taken into account here.

<EMAIL_ADDRESS>was published on npm yesterday.
After<EMAIL_ADDRESS>was published on npm, the fix for the deprecation warnings was pushed to master on Github.
This means<EMAIL_ADDRESS>on npm and master on Github are different.
Bumping the version number for serialport in particle-cli will not change anything as this will result in<EMAIL_ADDRESS>being installed from npm which doesn't contain the fix.
serialport uses pre-compiled binaries.
This usage of pre-compiled binaries has an unfortunate side effect. Cloning the repo and doing npm install will not actually compile the source code in the cloned repo. It will download the outdated pre-compiled binaries for<EMAIL_ADDRESS>
After cloning the repo do npm install --build-from-source rather than npm install and everything should function as expected.

Aah, yes, you are correct @fivdi: with --build-from-source I can run the tests locally and do not get any warnings logged. Should we close this now or wait until the next release comes out?

Ok, cool! (Well, bummer about the CI issues, but cool otherwise.)
If you update this once 3.0.2 does get released, I'll send a PR to particle-cli with the update :)

beautiful, thanks!

Hey, so I sent the PR to particle-cli and it's passing on node v5 and v6 but failing on v4 and older: https://travis-ci.org/spark/particle-cli/builds/127913574
Here's the relevant bit:
$ node --version
v4.4.3
$ npm --version
2.15.1
$ nvm --version
0.31.0
30.85s$ npm install
npm WARN deprecated<EMAIL_ADDRESS>Jade has been renamed to pug, please install the latest version of pug instead of jade
npm WARN deprecated<EMAIL_ADDRESS>graceful-fs v3.0.0 and before will fail on node releases >= v6.0. Please update to<EMAIL_ADDRESS>as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.
><EMAIL_ADDRESS>install /home/travis/build/spark/particle-cli/node_modules/serialport
> node-pre-gyp install --fallback-to-build
module.js:327
    throw err;
    ^
Error: Cannot find module 'nopt'
    at Function.Module._resolveFilename (module.js:325:15)
    at Function.Module._load (module.js:276:25)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/home/travis/build/spark/particle-cli/node_modules/serialport/node_modules/node-pre-gyp/lib/node-pre-gyp.js:14:12)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)

This might not actually be a serialport issue, but I thought I'd ask here first since you were just working with this. Any ideas?

Yep, all green now. Thanks!

Haha, bugs all around! :bug:


New SXSG file formats (.pac)

Heya, while snooping around the SXSG files, I found 2 new file formats (maybe there's more that I've missed)
Thought I could contribute by adding support for them for pacs!
ResIcuData (.icu) is located in raw\hedgehog\unicode.pac and ResClipmapOcean (.cob) is in raw\stage\w12b10\w12b10_trr_density.pac

Hey, thanks a lot!
I had generated new pac info for this game, and noticed some new file types, but somehow, in my frenzy to get everything going that day, I just completely forgot to add that info to HedgeLib and committed v405 support thinking that I already had! ...Huge mistake on my part!!!
So thanks for drawing my attention to this!
I'll merge this now, and then add in any additional missing types, if any, from the info that I had generated.

No problem!


[ASK] NCFDataset need memory > 100G to serve 1.6 million record df

Description

I have a rating dataframe with 1618496 rows.  but when I started to use the NCF method from the recommenders library, the kernel restarted when it reached data = NCFDataset(train=train, test=test, seed=SEED) and I notice the memory on the monitor hit 100G, and then it can't afford more to complete this line.
So please how to overcome this issue? and how people use it with big dataframe how to deal with it? is there any option use to handle big data?
Other Comments

Process from monitor window:

Working on a fix right now and summarizing everything in the issue https://github.com/microsoft/recommenders/issues/1561. We'll do a PR soon. I'll close this one


Reproduce Result in Kitti dataset

Hello @Nicholasli1995 thank you for your implementation. I have several questions.

What split (train and validation split) did you use for this code? is it subcnn split?
during the inference using testing set do you use ROI from the object detection algorithm?
Is it still use the calibration or this system can automatically generate it?
How to produce the similar table as in paper? I see that you use AOS, AP, also something like Easy, Medium, Hard. However when I tried to use validation set evaluation and use kitti_eval_offline I only got some plots, and statistic informations in txt and final result as here.

python inference.py --cfg "../configs/try_KITTI_inference:test_submission.yml"

Wrote prediction file at ../result/gt_box_test/data/007025.txt
Warning: 007025.png not included in detected images!
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `car_detection.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `car_orientation.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `car_detection_ground.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `car_detection_3d.pdf'.
Thank you for participating in our evaluation!
Loading detections...
number of files for evaluation: 1634
  done.
save ../result/submission/plot/car_detection.txt
car_detection AP: 93.934082 84.951851 67.594185
save ../result/submission/plot/car_orientation.txt
car_orientation AP: 93.664360 84.683617 67.141930
save ../result/submission/plot/car_detection_ground.txt
car_detection_ground AP: 41.456226 31.880611 24.876181
save ../result/submission/plot/car_detection_3d.txt
car_detection_3d AP: 29.933027 24.017235 18.650723
Your evaluation results are available at:
../result/submission

It only produce AP no AOS. Is it because you use testing set then evaluate directly on KITTI evaluation systems so they will provide you the detail result? Suppose we want to measure in Validation set, which value must I use? because there are many information such as car_detection AP car_orientation AP car_detection_ground AP car_detection_3d AP. So in specific how to produce table 1 as in paper if we use validation set?
-Thank you-

Hello @Nicholasli1995 thank you for your implementation. I have several questions.

What split (train and validation split) did you use for this code? is it subcnn split?
during the inference using testing set do you use ROI from the object detection algorithm?
Is it still use the calibration or this system can automatically generate it?
How to produce the similar table as in paper? I see that you use AOS, AP, also something like Easy, Medium, Hard. However when I tried to use validation set evaluation and use kitti_eval_offline I only got some plots, and statistic informations in txt and final result as here.

python inference.py --cfg "../configs/try_KITTI_inference:test_submission.yml"

Wrote prediction file at ../result/gt_box_test/data/007025.txt
Warning: 007025.png not included in detected images!
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `car_detection.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `car_orientation.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `car_detection_ground.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `car_detection_3d.pdf'.
Thank you for participating in our evaluation!
Loading detections...
number of files for evaluation: 1634
  done.
save ../result/submission/plot/car_detection.txt
car_detection AP: 93.934082 84.951851 67.594185
save ../result/submission/plot/car_orientation.txt
car_orientation AP: 93.664360 84.683617 67.141930
save ../result/submission/plot/car_detection_ground.txt
car_detection_ground AP: 41.456226 31.880611 24.876181
save ../result/submission/plot/car_detection_3d.txt
car_detection_3d AP: 29.933027 24.017235 18.650723
Your evaluation results are available at:
../result/submission

It only produce AP no AOS. Is it because you use testing set then evaluate directly on KITTI evaluation systems so they will provide you the detail result? Suppose we want to measure in Validation set, which value must I use? because there are many information such as car_detection AP car_orientation AP car_detection_ground AP car_detection_3d AP. So in specific how to produce table 1 as in paper if we use validation set?
-Thank you-

The split files used in this study are detailed at https://github.com/Nicholasli1995/EgoNet/blob/master/docs/preparation.md and can be accessed at https://drive.google.com/drive/folders/1YLtptqspOFw08QG2MsxewDT9tjF2O45g.
Yes. This repo does not include object detection and any object detector can be used. My prepared detections for the test set are available at https://drive.google.com/drive/folders/1atfXLmsLFG6XEtNnwZuEYLydKqjr7Icf.
This systems uses KITTI camera intrinsic parameters.
car_orientation AP is AOS. car_detection_ground AP is AP_BEV. car_detection AP is AP_2D.


/listofseries does not load in a new dev environment

When page /listofseries is loaded on new project, list_of_series.html.twig line 87 requires visitingSpeakerSeries to exist.
Normally, the series record is injected via SermonsController.php:168
In prod, this works as there is a database series called "Visiting Speakers"
In a new dev environment, this series doesn't exist so the page breaks.
I suggest,

make the code optional (or not hard code!)
Create a Fixture to Seed a local database with default series such as Visiting Speaker

done 2.


Filter compiled folders

This Pull Request introduce the heuristic.is_compiled_file filter that excludes compiled folders like:

dist/: generated after python setup
build/: generated after python setup
/__pycache__/: generated after python execution
/.*egg-info/: generated after python setup
/node_modules/: generated by npm install (Node JS)
/target/: generated by mvn install (Apache Maven)

We added this filter in the default settings and completed the filters documentation.
Everything is working fine, but note that the keyword plugin has a bug in the master branch (solved in #420) that can cause fails on the tests if you run all of them with tox.

@pablosantiagolopez : detect-secrets already runs on git tracked files by default already. In our experience, it does not trigger on these types of files since they are not tracked by git.
Given this, in your experience, is this still needed?

 I'm sorry, I didn't notice that because I usually use the --all-files option. This code will stay in this branch of my fork, so it can be merged if needed. In this moment I think that this Pull Request is unuseful so I close it.
Thank you!


Re-add support for PyTorch version 1.x

untyped_storage() support was added in PyTorch 2.0.

/te-ci


IndexError: tuple index out of range with SAC

When I try running an experiment with SAC, such as
python -m spinup.run sac --hid "[64, 64]" --env Pong-ram-v0 --epochs 100
I get the following error
line 140, in sac     act_dim = env.action_space.shape[0] IndexError: tuple index out of range
Is this due to SAC needs a continuous action space?

I'm just getting started with this library, but based on my experience today, I would say "yes." The "tuple index out of range env.actionspace.shape[0]" error appears when you're trying to run SAC on an environment with a discrete action space. For an example of a continuous action space you can try the environment called
MountainCarContinuous-v0
Hope this helps.


fix: move markdown formatting around desired word

@ZuBB, the formatting characters you refer are created by GitBook (the internal tool we use to create the final pages) and we don't really have control over them (they're automatically created)
So there's no sense on removing them as they will re-created in the next build.
Thanks anyway for contributing to the docs.

hi @juanmaguitar!
I understand it. although current formatting (\_\*\*\_absolutely) seems do not produce what it meant to. <-- just my 5c

You're right @ZuBB
I didn't realize what this was generating in the final HTML I'm reopening this PR.
Thanks again for your PR. I'm approving and merging it 👍


quictls: 3.1.5 -> 3.3.0

Update package quictls to version 3.3.0.
Changelog:
https://github.com/quictls/openssl/blob/openssl-3.3.0-quic1/CHANGES.md#openssl-33

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 349325

x86_64-linux

:white_check_mark: 20 packages built:

angieQuic
angieQuic.doc
curlHTTP3
curlHTTP3.bin
curlHTTP3.debug
curlHTTP3.dev
curlHTTP3.devdoc
curlHTTP3.man
haproxy
nginxQuic
nginxQuic.doc
ngtcp2
ngtcp2.dev
ngtcp2.doc
quictls
quictls.bin
quictls.debug
quictls.dev
quictls.doc
quictls.man

x86_64-darwin

:x: 2 packages failed to build:

angieQuic
angieQuic.doc

:white_check_mark: 16 packages built:

curlHTTP3
curlHTTP3.bin
curlHTTP3.dev
curlHTTP3.devdoc
curlHTTP3.man
haproxy
nginxQuic
nginxQuic.doc
ngtcp2
ngtcp2.dev
ngtcp2.doc
quictls
quictls.bin
quictls.dev
quictls.doc
quictls.man

aarch64-darwin

:white_check_mark: 18 packages built:

angieQuic
angieQuic.doc
curlHTTP3
curlHTTP3.bin
curlHTTP3.dev
curlHTTP3.devdoc
curlHTTP3.man
haproxy
nginxQuic
nginxQuic.doc
ngtcp2
ngtcp2.dev
ngtcp2.doc
quictls
quictls.bin
quictls.dev
quictls.doc
quictls.man

expected https://hydra.nixos.org/build/275046351

It's not common with migrations away from finalAttrs, but if the maintainer prefers it than so be it

finalAttrs is a tool, which trades evaluation speed for propagating values correctly when overriding. A consensus on whether it is strictly preferred is yet to be established. In this case i don't see the need for finalAttrs for the sake of correctness.

I thought it would be easier that way.

A valid reason in my eyes


Use MySQL Protocol instead of JDBC to connect MySQL on Sharding-Proxy

Closed. reason just ref #1893


Add a GHA to generate the two root folder JSON files and push to the gh-pages branch

Currently, a PR to update an OCABundle must execute the GHA to generate the root level JSON bundles — which is a pain.  A better solution would be to have a GHA that does that on each merge. That too is a bit of a pain if the GHA has to push the result back to the protected main branch.  I think a good way to resolve this is to have a GHA generate the files and push them to the gh-pages branch such that they get published to the GH Pages along with the OCA Explorer.  They would be removed from the main branch.
The impact of this is that all of the software that relies on the current location of the JSON files would have to be updated to use the new location.  That’s OK for now — we can manually keep the JSON files up to date on main as well for a short time while the transition is made.

@esune -- since this is a breaking change, I'd like to get this done sooner than later so that we break fewer installations.
I think the GHA should be trivial...

Realize that the JSON files in the root and the OCA Bundles must have the same root path, so if the generated file is on a different branch, the OCABundles folder must also be copied onto the that branch.
So options that I see:

Somehow make the GHA generate the JSON files so that they continue to be on main in a way that contributors putting in PRs don't see/edit the files.  I'm not sure if that is a permitted pattern, but I could be wrong.
Generate the files onto another branch and copy the OCABundles folder onto that branch as well.  If doing this one, probably best to use the gh-pages branch so that later (in a different PR) we can put the site documentation onto the branch (and hence, published to a website), and we can move the OCAExplorer onto that same branch.

For the purpose of updating ocabundles.json and ocabundleslist.json I wonder if a post-merge action that updates the main branch would suffice (something like this). The only question I have is about the DCO sign-off signature, since it will be an automated agent, but my guess is that is won;t be required OR there should be something that can be used as "signer"...

Not that the example you pointed to does NOT update main, but deliberately targets another branch. I think targetting main for such automation is difficult, because a user may or may not update the targetted files.  We explicitly DON’T want the files updated manually, because we want the READMEs updated.  Perhaps possibly, but I think it is messy.
Regards DCO, I know we do this in Hyperledger, so it must be possible.
Hmmm….as I write this, I realize that the daily AATH GHA targets main.  We could look at what it does.
https://github.com/hyperledger/aries-agent-test-harness/blob/main/.github/workflows/generate-summary-results.yml
The painful part of that one is that it runs on cron and the PR is created everytime.  We want to trigger on a merge, so that it was generated right after a merge.

I'm sure we can use the pr merge as a trigger and then, if necessary, go through the creation and automatic merge of a new PR (if it goes down to that).

Yes — easy minimum.  I’ll look at the larger idea of using gh-pages branch.  I need to understand combining mkdocs-material and OCA Explorer on a single site.  I think I know how to do it, but need to verify.  I’ve never done GHA development — in particular, how to do local testing.

For local testing, this might help (not for every scenario though): https://github.com/nektos/act

Addressed in #115


Relocate Latest Work to cutting-edge for Post Development.

From the time I made this PR, keep in mind that I was trying to commit changes in latest which shouldn't be. But I'm doing it since I have to deploy v1 branch later on. Please wait while I complete every element that needs to be updated.

By this point, any future post-work development will be now pointed to a cutting-edge branch.


3 implement the orchestrator functionality

Merge request is based on the directory restructuring and requires manual effort because it differs from main branch

@eloinoel can you do Rebase and Merge that will not create a new commit.


Integration with external logs storage when displaying traces

Many organizations have log aggregation setups, such as shipping all logs to Elasticsearch. For logs corresponding to traced transactions, it may not be feasible or desired to direct them all to the tracing backend. As long as the logs are labeled with trace/span IDs, it is possible to reassemble the logs from the logging backend when viewing traces in Jaeger UI.
This ticket is to track the design and implementation details of such solution.
The high level design is something like this:
+--------------+        +--------------+         +--------------+
|              |        |              |         |              |
|  Jaeger UI   |------->| jaeger-query |-------->|  logs query  |
|              |        |              |         |              |
+--------------+        +--------------+         +--------------+
                                                        |
                                     +------------------+--------------------+
                                     |                  |                    |
                             +--------------+    +--------------+    +--------------+
                             | logs storage |    | logs storage |    | logs storage |
                             | Elasticsearch     |   Kafka      |    |    HDFS      |
                             |              |    |              |    |              |
                             +--------------+    +--------------+    +--------------+

The log query service is meant to serve as an abstraction of different log storage types.
Open questions

what is the API of the log-query service
does jaeger-query retrieve logs when returning the trace to the UI or on-demand per-span

@yurishkuro
We will go this road with our centralized logging and are currently drafting an architecture. Based on the ideas you have at the moment, do you think it is necessary to stick to the current log format of a span:
"logs": [
        {
          "timestamp": 1400,
          "fields": [
            {
              "key": "error",
              "type": "string",
              "value": "something bad happened"
            }
          ]
        }

or would it just be necessary to store the spanId and implement an abstraction layer with a specified interface, which does the transformation. We currently only would need to know if the format is given or we a free to log what is necessary (inlcuding spanId) in our opinion.

I think logs must store trace ID, not just span ID, because it's quite easy to get clashes in span IDs with the current 64bit length.
The format of the logs storage doesn't matter at all, it's the function of the adapter to understand the format when responding to the "log query" service.
Finally, the plan above was only meant to search for logs by trace/span ID, not by keywords. The latter is possible but a lot more complicated.

I'm a bit surprised logs don't already contain trace+span IDs.  Is that really so?  If yes, we may take a crack at that, esp. if somebody can point us to where in Jaeger we may want to start.  Somewhere in Agent land, I imagine?

@otisg I updated the title to make it clearer what this ticket is about. It is not about producing the logs, but rather retrieving them from an external log storage (like ELK, that's outside the scope of Jaeger) when you view a trace in the Jaeger UI.
In order for that approach to work it does require changing how applications are producing the logs into that 3rd log storage, specifically, as I mentioned above, it requires the application to associate the current trace/span IDs with each log message. How the application does it is also outside the scope of this ticket, I am afraid, because it's tightly coupled to the specific logging framework the application is using. E.g. in Java it is possible to give the tracer an extended ScopeManager that not only stores the spans in thread-local, but also sets MDC that can be used by the logging framework to enrich the log lines. In Go it requires a change in the logging API, e.g. as was done in the HotROD demo app: https://github.com/jaegertracing/jaeger/tree/master/examples/hotrod/pkg/log

Aha, aha, I see.  The logs that Jaeger client already supports and sends to collector already have/inherit the trace/spanIDs because the logs are an integral part of the same trace structure that ends up being stored in the backend together with traces.  Is there a way to route logs to a different endpoint?  For example, if I have my ES cluster, I may prefer to route all my logs there instead of storing them together with traces.  When you implement the functionality you've described here, Jaeger's UI will be able to get logs from such external ES cluster. Other "logs UIs" (e.g. people may have their Kibanas, etc.) will then also be able to get those logs (those that got collected with Jaeger) from such ES clusters.
Would such log routing be a welcome addition to Jaeger?

Is there a way to route logs to a different endpoint?

Conceptually nothing prevents it as the Storage API in Jaeger collectors takes the spans and does whatever it wants with them, so you could have an implementation of that api that only pays attention to the logs in the span and sends them somewhere else. Such storage can be combined with other normal trace storage by using a composite SpanWriter.
Having said that, I am not seeing a lot of value in doing that, because most people do not emit logs using Span.log API. They do it using normal logging APIs, so the problem is usually the reverse, how to get those normal logs either (a) associated with the current span or (b) forwarded to the tracing system (maybe in parallel with normal log, which is what HotROD example is doing).

Any update on this? We've found it valuable to store HTTP headers and body for both requests and responses.
These are certainly larger than 64kb in some cases. We don't mind using Span.log or any other custom reporting logic, as we have complete control over the code doing the request processing.

Hi
Can we somehow modify format of logs?
I want to use sidecar filebeat container to deliver them to logstash but it would be nice to change logs format to fit my needs.
Is that right issue for question or should I open feature request for that?

Which logs are you referring to?

jaeger logs, all components.

This is off-topic for this ticket. Feel free to open another one. Zap logger can be configured with different formatter, but I don't think it's worth doing in the code. Jaeger logs are already log-integration-friendly, being encoded as JSON messages.

Is this similar to how StackDriver traces shows trace spans with logs?

Somehow, the idea is to query log storage and attach logs containing traceid/spanid to the spans showed in jaeger UI.

HI all,
are there any accepted solutions for this ticket?
For me, this is mostly an issue of managing storage capacity, as I am sending application logs (trace and span enriched) to ELK, and Jaeger is also picking them and storing them in Jaeger DB (again ES).
It would be better if somehow Jaeger could query (through standardized interface like logs query above) logs for certain trace+span combination.
Also, is there a way to block sending app logs to Jaeger (only traces and spans with meta data) but allowing logs to go to ELK?
I am using jaeger in SpringBoot app (that uses slf4j and logback as log provider)

As we will be transitioning to an OpenTelemetry based collector, wondering if this is something that could be supported there?
Currently there is support for metrics and tracing receivers/exporters - may be logging can be supported as an additional category, and a processor could be used to split out the logs from the tracing data and export it to a logging system (with the appropriate context metadata).

If I understood correctly, your proposal is to have jaeger act as facade for logging? Then all logs would go through jaeger, and then jaeger marks them and sends them to logging receiver?
for me, if there can be a flag that says "don't send app logs to jaeger", this would be good enough to minimize storage requirements (let's think of this as MVP)
and currently I am marking logs that go to ELK with trace and span ID through MDC and logstash-logback encoder setting, so it is not an issue to query app ELK logs by these fields (if I want to achieve functionality to see logs belonging to trace+span in Jaeger GUI).

If I understood correctly, your proposal is to have jaeger act as facade for logging? Then all logs would go through jaeger, and then jaeger marks them and sends them to logging receiver?

Not quite - what I am suggesting is OpenTelemetry Collector adds logging as a third dimension to the information it is able to collect and export.
Then, as part of processing the tracing data (not necessarily Jaeger) that is handled by the OpenTelemetry Collector, a processor is created that can split off the logs received via the tracing data, and exports it to a logging exporter instead of a tracing exporter.

Looks like logs may become part of OpenTelemetry at some point: https://github.com/open-telemetry/oteps/blob/master/text/0092-logs-vision.md

This ticket is still valid though: this is about getting Jaeger UI to retrieve logs from an external provider. I think @rubenvp8510 had this in his queue some time ago.

Still no news?
Similar functionality was implemented by DataDog and logz.io
https://docs.datadoghq.com/tracing/connect_logs_and_traces
https://docs.logz.io/user-guide/distributed-tracing/correlate-traces

Not yet, but if you have free cycles to contribute code for this feature, feel free to send a draft PR with a PoC based on @yurishkuro's proposal.


multiple to: destinations

I'm generating several java modules at once, and although they have different paths, they would essentially have the same files.

will be resolved via #322


Improve styles pattern

Style structure: What do you think about improving that?
How about using a simple bootstrap?

attention: a lot of CDNs have been used.

@marlusantos cool


Fix kiegroup references and add github pages settings

In this PR, we fix all the old repo references when building the documentation website. Also added the .asf.yaml file to follow the best practices and configure the repository accordingly. See https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-GitHubPages

Aside, we also need to fix the DNS in sonataflow.org and change it to apache.github.io. I'm working on it.


Banner: Mis-alignment

Describe the bug
The banner alignment is covering the main text. It just happened recently
Expected behavior
The banner should not cover the main text in preview mode
To Reproduce
Steps to reproduce the behavior:

Install Community Plug-in: Banners
Copy an image link
Command palette: Banners: Paste banner from clipboard
See error in Reading mode

Screenshots

Reading mode: I have Heading 1 (iOS Apps) & Heading 2 (Owned)

Preview mode: The Heading 1 is covered by the banner & The Heading 2 is partially covered.

Pop-up window: It's fine with this one.

OS
Where does the bug occur?

[x] Desktop
[ ] Mobile

Obsidian Version: v0.14.6

Hmm, does this still happen if you use the default theme? Some themes conflict with how Banners work, so if that's the case, which theme are you using?

I'm using ITS theme. And I contacted to ITS theme author and she mentioned the error was due to Breadcrumb plug-in. If I disable Breadcrumb Trail view, the banner is working fine.

Ah yeah, that's been a known plugin that has a conflict with this one. I've been meaning to do some compatibility fixes with plugins like those, but for now, this can be a workaround that might help your case

Any news on that?

Oh yeah, it was because of BreadCrumb view that pushes that Banner further down and covers the first few lines. It's fixed now with CSS below, in case you wanna try out.
.obsidian-banner {
	transform: translateY(60px);  /* or whatever amount you need to move it */
}

It doesn't really solves my issue because the amount of shift I need  is dynamic.
In BreadCrumbs, sometimes I have 1 line, and sometimes more (see image below).
Is there a CSS way to make it shift downwards dynamically?

As far as I know, you just have to calculate and type in the amount of px to move it, and it would be fixed amount. I don't use many Banners in every of my note so it does not bug me that much.

As far as I know, you just have to calculate and type in the amount of px to move it, and it would be fixed amount. I don't use many Banners in every of my note so it does not bug me that much.

Just to avoid confusion of future readers, I use multiple lines in breadcrumbs, not multiple banners.
In any case, thank you :)


[Issue] RSpec Test Suite Errors Out During Test Initialization

Problem Description
When I run rspec, it appears to error out before even getting a chance to run the tests. Here is the complete output from my terminal.
Replication Steps
(assuming Docker desktop is already installed)

git config --global core.autocrlf false
git clone https://github.com/expertiza/reimplementation-back-end.git
cd reimplementation-back-end
sudo docker compose up
(open shell window attached to the app container)
rspec

It appears that going into each /spec/routing/*_spec.rb file and changing the reference to each controller from ControllerName to Api::V1::ControllerName (e.g. CoursesController to Api::V1::CoursesController) fixes this issue.
However, after modifying the 5 problematic files, rebuilding the containers, and rerunning rspec, I'm now seeing the following test results:
284 examples, 263 failures, 5 pending
I'm unsure if those results are related to this fix or if there is a deeper issue with the codebase.


testkit target

Codecov Report

Merging #20 (0668b7b) into develop (2b3cabb) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop      #20   +/-   ##
========================================
  Coverage    92.28%   92.28%
========================================
  Files           50       51    +1
  Lines          959      959
========================================
  Hits           885      885
  Misses          74       74

Impacted Files
Coverage Δ

Core/Tests/Components/ButtonTests.swift
100.00% <ø> (ø)

Core/Tests/Components/EmptyViewCellTests.swift
100.00% <ø> (ø)

Core/Tests/Components/FontTests.swift
100.00% <ø> (ø)

Core/Tests/Components/TextFieldTests.swift
100.00% <ø> (ø)

...tKit/Sources/Extension/UIEdgeInsetsExtension.swift
100.00% <ø> (ø)

...stKit/Sources/Extension/SnapshotingExtension.swift
100.00% <100.00%> (ø)

TestKit/Sources/Extension/UIViewExtension.swift
95.65% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b3cabb...0668b7b. Read the comment docs.


Php 7.x

Coverage decreased (-45.01%) to 52.038% when pulling da6971bad28fde2453ad05cb650ef921db1a1783 on demvsystems:php-7.x into 883ac0b2cb6c83f177abdd61dfa33eaaa7b23043 on weew:master.


CMAK can not connect after ZooKeeper enabled ACL

cmak-<IP_ADDRESS>
zookeeper-3.6.4
java openjdk version "11.0.10" 2021-01-19 LTS
After ZooKeeper enable ACL / use addauth digest admin:*****
I can not modify cluster settings ( but could create topic on CMAK UI), show error
Yikes! KeeperErrorCode = NoAuth for /kafka-manager/mutex [Try again.]
Note: NOT enable any SASL, only enbaled ZooKeeper ACL.
How to add ACL auth in CMAK to connect ZooKeeper ACL?
Thanks very much for you help!

I have found work around step
login to zookeeper, then enther ACL auth, like addauth digest admin:*****
manual create znode on /kafka-mamager
create /kafka-manager/mutex ""
create /kafka-manager/mutex/locks ""
create /kafka-manager/mutex/leases ""
Then try again config cluster from UI , it works!


Is it possible to have multiple versions.properties, e.g: versions-dev.properties and versions.properties

[x] I have read the guidelines for submitting issues

⚠ Is your feature request related to a problem? Please describe

Previously we've a similar versioning approach for our dependency but placed in the ~/.gradle/versions.properties (we also have on-premis CI server, to store this version)
We update the version inside ~/.gradle/versions.properties by following triggers:

if merged
daily builds successful

💡 Describe the solution you'd like

Is it possible to distinguish the versions.properties based on our current environment, e.g:

versions-dev.properties will use latest alpha development
versions.properties used if we ready to release, and to preserve and increment the stable versions if hotfixes occurred

🤚 Do you want to develop this feature yourself?

[ ] Yes
[ ] No
[x] I'm not sure where to start 😄

Look at the options available in the refreshVersions { … } block, you should already have what you're looking for.


Meta Description Missing From LTS "ghost_head" Helper

Issue Summary
One of the suggested changes for migrating themes to Ghost 1.0 is removing the meta description from default.hbs.
In Ghost 1.0, this description is instead added in the {{ghost_head}} helper - https://github.com/TryGhost/Ghost/blob/master/core/server/helpers/ghost_head.js#L109
In the Ghost LTS branch, this addition is missing -
https://github.com/TryGhost/Ghost/blob/lts/core/server/helpers/ghost_head.js#L95
Unfortunately, this means that any themes that are updated to full 1.0 compatibility are now missing their "description" meta when rendered on the LTS version.
Solution
Since the latest LTS version is meant to provide forward compatibility with 1.0 themes, the meta description should be added to the {{ghost_head}} helper.

Hey @triestpa!
Yes, this is one thing we're aware of. The problem with your suggested solution is, that for users who don't migrate their theme to 1.0 compatibility, the meta-description would be outputted twice, if we'd include it in {{ghost_head}} for LTS.
The usage of the {{meta_description}} in HTML <head> is deprecated in Ghost 1.0, but will not cause a fatal error, which means it'll still possible to upload and activate a it t Ghost 1.0.
tl;dr:

If Ghost includes meta-description in the {{ghost_head}} helper for LTS, it'll be outputted twice for themes that are not migrated to 1.0.
If it's removed in a migrated theme, because it'll be deprecated in Ghost 1.0, there'll be no meta-description in LTS versions.
If it's left in the migrated theme, it'll be fine in LTS versions but outputted twice on Ghost 1.0.

@ErisDS What are your thoughts on that?

@AileenCGN I agree with your assessment.
Ghost LTS is forwards compatible in so much as 1.0.0 themes will not cause fatal errors, so as to ease the migration process. That is - it is now possible to upload a 1.0.0 theme to LTS and it will not cause errors, whereas previously it would have.
There is no good solution for making the meta description back or forwards compatible, therefore the change happens in a major version bump. This is correct behaviour IMO.

Ok fair enough, thanks for the clarification!


Wrong package name

Hi,
First, thank you for developing this MLKit plugin for flutter :)
I'm trying to configure your plugin but it seems that it don't take my package name
When I launch my app, I have this error :

What went wrong:
Execution failed for task ':mlkit:processDebugGoogleServices'.

No matching client found for package name 'com.azihsoyn.flutter.mlkit'

Could you tell me if there is a place to give my package name ?
Thank's

Hi! Thank you for trying my package and sorry for the inconvenience.
You may build for android. Please try following step.

change applicationId in <root>/android/app/build.gradle

    defaultConfig {
        // TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html).
        applicationId "<your application id>" // here
    }

change package name in <root>/android/app/src/main/AndroidManifest.xml

<manifest xmlns:android="http://schemas.android.com/apk/res/android"
    package="<your application id>"> // here

configure firebase
https://firebase.google.com/docs/android/setup?authuser=1

In add application phase, you need use same application id at step 1, 2.
Thanks.

Hi,
Thank you for your response
Unfortunately, i've already set my package name in both build.gradle and manifest according to my firebase project but i still have this error.
I encounter an other issue with the google-services.json file.
It says that is missing from the searched location :

What went wrong:
Execution failed for task ':mlkit:processDebugGoogleServices'.

File google-services.json is missing. The Google Services Plugin cannot function without it.
Searched Location:
flutter/.pub-cache/hosted/pub.dartlang.org/mlkit-0.1.0/android/src/nullnull/debug/google-services.json
flutter/.pub-cache/hosted/pub.dartlang.org/mlkit-0.1.0/android/src/debug/nullnull/google-services.json
flutter/.pub-cache/hosted/pub.dartlang.org/mlkit-0.1.0/android/src/nullnull/google-services.json
flutter/.pub-cache/hosted/pub.dartlang.org/mlkit-0.1.0/android/src/debug/google-services.json
flutter/.pub-cache/hosted/pub.dartlang.org/mlkit-0.1.0/android/src/nullnullDebug/google-services.json
flutter/.pub-cache/hosted/pub.dartlang.org/mlkit-0.1.0/android/google-services.json
I cant make another issue about this if you want

Otherwise, did you try your plugin outside your plugin project ?
I mean that you're maybe not in a real app configuration ? and it could help you for understanding those issues
Thank you

OK.

add plugin to <project root>/android/build.gradle

buildscript {
    // ...
    dependencies {
        // ...
        classpath 'com.google.gms:google-services:3.2.0' // google-services plugin
    }
}

allprojects {
    // ...
    repositories {
        // ...
        maven {
            url "https://maven.google.com" // Google's Maven repository
        }
    }
}

enable plugin in <project root>/android/app/build.gradle

apply plugin: 'com.android.application'

android {
  // ...
}

dependencies {
  // ...
  compile 'com.google.firebase:firebase-core:11.8.0'

  // Getting a "Could not find" error? Make sure you have
  // added the Google maven respository to your root build.gradle
}

// ADD THIS AT THE BOTTOM
apply plugin: 'com.google.gms.google-services'

https://firebase.google.com/docs/android/setup
I hope this help you.
Thanks.

Hi,
Sorry for my late answer but i still have the issue :(
I've just create an empty Flutter project and add the dependency in pubspec.yaml for simplicity
The Google Services Plugin continues searching for google-services.json in the cache folder of mlkit flutter plugin (the same folders that I've mentionned in my previous answer).
Did you try your plugin in a separate project ?
Maybe there is a parameter to indicate to your plugin where is the google-services.json file?
Thank you for your time :)

Hi, @PsyOhm23 !
I'm very sorry... It was flutter_mlkit's bug.
https://github.com/azihsoyn/flutter_mlkit/pull/15/files#diff-7ae5a9093507568eabbf35c3b0665732L40
Now it fixed, so please use flutter_mlkit ^0.2.2.
Thank you for reporting!

Great work....!!!!!!!!!!

Thx 😁


Would it be possible to use the Cake Contrib Icon for your NuGet Package?

Thanks again for creating this Cake Addin, we really appreciate the effort that you have put in to creating it.
We, the Cake Team, recently announced a new Cake Contrib Icon, details of which can be found here:
http://cakebuild.net/blog/2017/06/new-cake-contrib-icon
Would you consider changing the nuspec file for your NuGet Package to use this new Cake Contrib Icon?  If so, the recommended URL to use is:
https://cdn.rawgit.com/cake-contrib/graphics/a5cf0f881c390650144b2243ae551d5b9f836196/png/cake-contrib-medium.png
Details of the above URL can be found in the repository here:
https://github.com/cake-contrib/graphics
Please let me know if you have any questions.

@tomstaijen in the referenced change, you seem to be using the URL to the blog post about the new Icon, rather than the URL to the icon itself.


improving the advanced indexing notebooks

This PR should address issue #206 .
I created and added a schematic image to explain different indexing types. I also added more examples to the notebook for more clarify.

I am not sure why the preview of notebook is failing. There is a duplicate label warning :
 WARNING: duplicate label: indexing-1; other instance in /home/runner/work/xarray-tutorial/xarray-tutorial/fundamentals/02.1_indexing_Basic.ipynb

But I don't see any similar titles.

👏🏾 :clap: i love this image!
we should get it in the main docs too.

@negin513 just a heads up - I added a couple commits to sync with the latest environment and enable the website preview link, so you can see your changes here https://xarray-contrib-xarray-tutorial-preview-pr-264.surge.sh/intermediate/indexing/advanced-indexing.html

I think meshgrid is an alternative to ix_. I won't have time to review but thanks Negin!

Thanks @scottyhq for great comments . I have added  the following:

Added a dropdown note box about how to achieve numpy orthogonal indexing.
added %config InlineBackend.figure_format='retina' for rendering


Make make_blob_url be able to make URL for snapshot

When copy blob from snapshot, URL of the snapshot is needed,
this commit make make_blob_url accept 'snapshot' as parameters,
and return the URL of the snapshot if 'snapshot' is present.

Hi @yanheven, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, AZPRBOT;

:shipit: /cc @rambo-msft please sign off.

@rambo-msft can some one act one this PR? @yanheven has rebased it onto the dev following the instructions and we had all signed off on the original PR.

@erezvani1529 Done


Event Frame Attributes - Interpolated Values

Hi,
Currently, the event frame attribute downloader only allows plot or recorded values  but not interpolated values. Can you please add this option in the future, that can enable the user to download the attributes of event frames at any sampling rate?


Updated SQL file on Homework-5 branch

I added the codes for the questions in homework-5
I did some modifications on tables

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I added new functionality to the product_units table by creating a new column (current_quantity) and updated it with the latest quantity from the vendor_inventory table.
What did you learn from the changes you have made?
I learned how to use UPDATE with subqueries, manage COALESCE to handle NULL values, and apply ALTER TABLE in SQLite. I also learned that SQLite doesn't support aliases in UPDATE statements.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I initially considered using a temporary table to store the last quantity per product, but I decided to use a subquery within the UPDATE statement for simplicity.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
I faced a syntax error due to trying to use an alias in the UPDATE statement, which SQLite doesn't support. I resolved it by using the full table name instead of an alias.
How were these changes tested?
I tested the changes by running the queries in the SQLite environment and verifying that the output matched the expected results
A reference to a related issue in your repository (if applicable)
No related issues in the repository.
Checklist

[x] I can confirm that my changes are working as intended

HW5 marked.


Rate Limit Requests

This is important so we do not get IP banned.

Added a throttle to the Exchange class.  We just need to confirm it's added for every new call.


Downtime messages begin at midnight the day before

Update the messaging to reflect this.
cc @vinayvinay

Won't that lead to some confusion as people aren't necessarily clear on whether "midnight on Wednesday 31 December" means the beginning of Wednesday, or the end of Wednesday?

Yes, perhaps. If that is the case we can easily move to 1am.

how about just: 'A downtime message will show from Wednesday 31 December'?


captureBlockSnapshots cause problem

Describe your idea
I didn't use debug mode before, so I didn't find the problem. I thought Skybuilder used some weird way to place the blocks. Finally, I found that the reason was the use of this.level.captureBlockSnapshots = true; I don't know why you want to use this, which resulted in the block's onplace method not being called, which is an initialization method of the block state. I don't think this is a good call. Of course BlockEntity can solve it. It's just that I need to do some extra unnecessary coding work. The most important thing is to cause trouble.

I also use structuretemplate.placeInWorld to place the template and it works always well.

Here is the reason for doing this: https://github.com/MelanX/SkyblockBuilder/commit/bfc8f2754c60699ecb90ab2718e1bdbdf2aa1142
If you have a better idea how I can achieve that gravel isn't falling, torches in mid air aren't droping, I'm really interested in this. Using it was never a problem since blocks were placed when creating the template -> onPlace is called -> BlockState is initialized.

it's really a worldgen problem, i have ever seen the scene in desert biomes. The block don't fall until neighbor changes. if there are not tick counter and then level.scheduleTick would not work.

What exactly do you mean?

the gravel fallen because the scheduleTick method of ServerLevel was called during onplace to register a timer to check whether it is floating. Just make it unregisterable.

For example, i use the removeContainer(new ChunkPos(-2,-2)) in debugger at here.

Now the sand floating in the air.

  ((LevelTicks<Block>)level.getBlockTicks()).removeContainer(new ChunkPos(pos));
I thought I had to use AT to change it, but it seems that there is no need to change it, the default is public.
You can addContainer after you place the template.

Oh wait, that would also remove the scheduled tick from your block...

The way I write it is just to standardize it, and there is actually no need for scheduled.

But having said that, I think this feature should probably be allowed to be set by users?

Sounds like a good idea.


cleanup of signed/unsigned vars and const usage

Try to avoid mixing signed/unsigned vars and also be more strict with "const" usage.

I've re-run the tests locally and they finish ok. Is this some race conditions within the tests?
(I'm rather new to zephyr.)
best regards,
Florian La Roche

The change to arch/arm64/core/mmu.c` is wrong.

I'll review over the weekend to check things again.


ipyaggrid unable to handle NaT in date column correctly

here's a 3 liner example on how to reproduce the error:
import pandas as pd
from ipyaggrid import Grid

df = pd.date_range(end=pd.Timestamp.today().floor('d'), periods=10).rename('date').to_frame().reset_index(drop=True).rename_axis('index')
df.iloc[0, 0] = np.nan
Grid(
    grid_data=df,
    index=True,
    grid_options={
        'columnDefs': [{'field': col} for col in df.reset_index()]
    }
)

you can see that it works ONLY if you comment this line df.iloc[0, 0] = np.nan
Thanks
Gio

I don't know if it can help anyone, but using a valueFormatter in the column_defs that takes care of the NaT solves the problem. That being said, I think this bug should still be fixed.
Thanks
Mario


False Positive: PartialFunctionInsteadOfMatch

When using ten or more list map { case _ => } in row PartialFunctionInsteadOfMatch triggers false positive.
Can be easily reproduced by copying additional list.map {                        case i: Int =>                        case s: String =>                      } in PartialFunctionInsteadOfMatchTest

I've released a new version with this change.


Multiple players using discord cannot hear each other

Is it possible to trick Simple Voice Chat into thinking discord users have the mod on their client?

I'm not really sure what you mean. Players that use the /startdiscordvoicechat command should appear as speaking. Is there an issue with multiple bots?

Hey, I made a small oversight when adding multiple bots functionality. The issue with multiple bot users not being able to hear each other should be fixed, could you try using the latest version (1.2.0) from https://modrinth.com/mod/simple-voice-chat-discord-bridge/versions and tell me if it fixed the problem or not?

Yes, it works now!

Sorry to reopen this so quickly, but it appears that after a player dies, nobody can hear them anymore?

Hm ok, I'm going to move that to a new issue but I'll work on investigating that.


tileloadstart event and fixed crossorigin handling

As a counterpart to the tileloaded event on the layer, this adds a tileloadstart event.
Only slightly related, but nonetheless important: this change includes a fix for a typo and improves handling of the crossorigin attribute for CORS image requests, which fixes a Firefox issue that @fredj will like to get the canvas-to-greyscale example working in Firefox.

@ahocevar: thanks a lot !

Works great on chrome and firefox, please merge


Enable wake support for Minecraft using Optifine client

Feature Request
Feature Information:
I can wake my sleeping Minecraft servers with the vanilla 1.19.2 client but not Optifine.
I've tried several versions, and they all get:

Can you download a copy of the latest Optifine client OptiFine 1.19.2 HD U H9 and check to see why it can't wake a sleeping MC server on AMP when it tries to connect?
Note: the servers wake fine when Wake from sleep is set to When the server is pinged, but not When a user joins the server.
I confirm:

[x] that I have searched for an existing feature request matching the description.

Sleep is only supported on servers that can be connected to with the official, unmodified client. The behaviour of sleep is not verified against modified or unofficial clients.


Can't use scss files normally

Bug Report or Feature Request (mark with an x)
- [x] bug report
- [ ] feature request

Versions.
@angular/cli: 1.4.7
node: 6.10.0
os: win32 x64
@angular/animations: 4.3.3
@angular/common: 4.3.3
@angular/compiler: 4.3.3
@angular/core: 4.3.3
@angular/forms: 4.3.3
@angular/http: 4.3.3
@angular/platform-browser: 4.3.3
@angular/platform-browser-dynamic: 4.3.3
@angular/router: 4.3.3
@angular/material: 2.0.0-beta.8
@angular/cdk: 2.0.0-beta.8
@angular/cli: 1.4.7
@angular/compiler-cli: 4.3.3
@angular/language-service: 4.3.3
typescript: 2.3.4
Repro steps.
I'm struggling to use sass in fresh angular project. I created project with --style=scss flag from CLI and then updated .angular-cli.json file content with "styleExt": "scss" and "styles": ["styles.scss"]. Project building was successfull but styles from files like xyz.component.scss were not compiled and thus not included in styles bundle.
I managed to add components style files to .angular-cli.json file "styles": ["styles.scss", "./path/to/file/xyz.component.scss"] but this resulted in runtime error: Error: Uncaught (in promise): Expected 'styles' to be an array of strings.
To avoid this error I deleted styleUrls: ['./xyz.component.scss'] from @Component annotations in xyz.component.ts files.
Now everything works good but I don't understand whats going on with those scss files. Why I must delete reference to them from @Component? (they are referenced automaticly when using ng g component cli command). Are there any other options to make it work without referencing .scss files in .angular-cli.json and use @Component reference instead?

Global styles and component styles are two very different things.  Global styles are bundled and linked directly from the application's index.html.  Component styles are part of the component itself.  See the relevant angular documentation for more information. (The CLI supports styleUrls as CSS, SASS/SCSS, LESS, or stylus files).

Thanks for reply! Is there any way to use .scss styles as component styles? For project described in question, (ng) component generator creates file xyz.component.scss as well as styleUrls: ['./xyz.component.scss'] in annotation @Component but scss file styles aren't working. Also in case of global styles: Is it possible to automaticly merge .scss files from given paths to one global file?

For global styles, the styles property in .angular-cli.json bundles all referenced files.
For component styles, the generate command is creating everything you need to get started.  styleUrls: ['./xyz.component.scss'] means the component will use the SCSS file as a source for styles.  The CLI also allows multiple stylesheet file formats to be mixed in both an application and an individual component (e.g., both a CSS and SCSS file in .angular-cli.json; or even SCSS, CSS, and stylus files in a single styleUrls array).
Could you elaborate on what you mean by not working?  Component styles are scoped (advanced configuration withstanding) to the component.  In fact, the styles are only present within the page when the component itself is present.
Also of note is that auto-prefixing and, in production builds, minification is handled automatically for all referenced stylesheet files.

In my case component styles are not working. Styles defined in xyz.component.scss are omitted thus not making any changes in view representation of component. In chrome tools styles defined in xyz.component.scss are missing. So it's not working for me "out of the box" when creating components. Is there anything I can do to make it work?

Ever since 1.4 -style=scss doesn't work anymore. It's 1.4.7 and it's stil not fixed.
Likewise --routing was made away with.
Why remove working and useful functionality? And at the same time introduce something new that isn't documented AT ALL

@Darkoon Can you provide an example of what you are attempting?  I put together a quick SCSS example application using version 1.4.7.  You can find it here.  Run ng serve --open and it will show example works! in blue.
Steps used to create it were:

ng new scss-example --style=scss
cd scss-example/src/app
ng generate component example
edit example/example.component.scss to contain p { color: blue; }
replace the content of app.component.html with <app-example></app-example>

@dalu both of those features exists and work in version 1.4.7 and i'm unsure of what you are referring to in your last statement.  But if you are running into problems, ensure the latest version of @schematics/angular is installed (may need to delete the project's package lock file) and please open a separate issue with the template details if the problems persist.

@clydin , I'm referring to this:
# ng new --help
ng new <options...>
  Creates a new directory and a new Angular app eg. "ng new [name]".
  aliases: n
  --dry-run (Boolean) (Default: false) Run through without making any changes. Will list all files that would have been created when running "ng new".
    aliases: -d, --dryRun
  --verbose (Boolean) (Default: false) Adds more details to output logging.
    aliases: -v, --verbose
  --skip-install (Boolean) (Default: false) Skip installing packages.
    aliases: -si, --skipInstall
  --skip-commit (Boolean) (Default: false) Skip committing the first commit to git.
    aliases: -sc, --skipCommit
  --collection (String) Schematics collection to use.
    aliases: -c <value>, --collection <value>

and this
wrk ~ # npm update -g @schematics/angular
wrk ~ # npm uninstall -g @schemantics/angular
up to date in 0.036s
wrk ~ # npm install -g @schemantics/angular
npm ERR! code E404
npm ERR! 404 Not Found: @schemantics/angular@latest

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2017-10-14T20_29_53_009Z-debug.log

0 info it worked if it ends with ok
1 verbose cli [ '/usr/bin/node',
1 verbose cli   '/usr/bin/npm',
1 verbose cli   'install',
1 verbose cli   '-g',
1 verbose cli   '@schemantics/angular' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose npm-session 27f83eef5074d71a
5 silly install loadCurrentTree
6 silly install readGlobalPackageData
7 http fetch GET 404 https://registry.npmjs.org/@schemantics%2fangular 820ms
8 silly fetchPackageMetaData error for @schemantics/angular@latest 404 Not Found: @schemantics/angular@latest
9 verbose stack Error: 404 Not Found: @schemantics/angular@latest
9 verbose stack     at fetch.then.res (/usr/lib/node_modules/npm/node_modules/pacote/lib/fetchers/registry/fetch.js:42:19)
9 verbose stack     at tryCatcher (/usr/lib/node_modules/npm/node_modules/bluebird/js/release/util.js:16:23)
9 verbose stack     at Promise._settlePromiseFromHandler (/usr/lib/node_modules/npm/node_modules/bluebird/js/release/promise.js:512:31)
9 verbose stack     at Promise._settlePromise (/usr/lib/node_modules/npm/node_modules/bluebird/js/release/promise.js:569:18)
9 verbose stack     at Promise._settlePromise0 (/usr/lib/node_modules/npm/node_modules/bluebird/js/release/promise.js:614:10)
9 verbose stack     at Promise._settlePromises (/usr/lib/node_modules/npm/node_modules/bluebird/js/release/promise.js:693:18)
9 verbose stack     at Async._drainQueue (/usr/lib/node_modules/npm/node_modules/bluebird/js/release/async.js:133:16)
9 verbose stack     at Async._drainQueues (/usr/lib/node_modules/npm/node_modules/bluebird/js/release/async.js:143:10)
9 verbose stack     at Immediate.Async.drainQueues (/usr/lib/node_modules/npm/node_modules/bluebird/js/release/async.js:17:14)
9 verbose stack     at runCallback (timers.js:785:20)
9 verbose stack     at tryOnImmediate (timers.js:747:5)
9 verbose stack     at processImmediate [as _immediateCallback] (timers.js:718:5)
10 verbose cwd /root
11 verbose Linux 4.13.5-1-ARCH
12 verbose argv "/usr/bin/node" "/usr/bin/npm" "install" "-g" "@schemantics/angular"
13 verbose node v8.7.0
14 verbose npm  v5.5.1
15 error code E404
16 error 404 Not Found: @schemantics/angular@latest
17 verbose exit [ 1, true ]

@Darkoon it should just work as shown in the repro that @clydin setup. Can you provide a reproduction where it does not work?
@dalu the issue you are describing is open as https://github.com/angular/angular-cli/issues/7723.

@clydin, @filipesilva Thanks for help. I finally resolved this issue by uninstalling angular-cli and reinstalling it again in 1.4.7 version. Sorry for problem!

same issue here. i tried reinstalling approach but got the same result scss is not affecting change in the other components that is nested under app/


Provide versions / releases

It would be great if you could provide versions with git tags, so one can build packages for linux distributions.

@hashworks you can always use @latest as version tag

Hi Hashworks, thanks for raising the issue. Here you go: https://github.com/maxmunzel/kvass/releases/tag/v1.0.0


train_agent_async without evaluation

After this PR, If eval_interval is set to None, no evaluator nor eval_env will be created and the agent will not be evaluated.

Coverage decreased (-0.04%) to 71.148% when pulling 78dfffc3392e45bca15cedaf56f43f430b4b9116 on muupan:train-agent-async-wo-evaluator into 03c2ff975e1fca64c67d6ad1a1daaa9638d04e66 on pfnet:master.


Added FKB

Hmm. I suppose we should make a tag of FKB to go with this. I can make, say, a geos/v1.0.0 tag so that way it's "fixed" (even though FKB is pretty much fixed anyway).


Watcher runs wrong task

One of the watchers seems to run gulp.start('assets-copy') while this task is actually named 'copy-assets'.

you are right.
fixed in develop. will be in the next release.


Enhancement: OpenTelemetry integration

So, as the title says. We need to consider how to best support OpenTelemetry. We might need to add some hooks to allow for optimal instrumentation. We should also consider creating an OT instrumentationn library, see for example: https://opentelemetry-python-contrib.readthedocs.io/en/latest/instrumentation/fastapi/fastapi.html

@cofin do you want to take this one?

Yep.  I'll take a look at it over the weekend.

Un-assigning for now until we dial in the instrumentation enhancements we've been discussing.

@cofin - are u doing this?

I had planned to, but I don't have the bandwidth currently. I can try to pick it back up soon or hand off.

It would be good if you could do this when you have bandwidth. We need this - and I too am somewhat busy 😉

Understood. I need it soon as well, so I'll make some time for it. I'll ping you on discord when I'm getting started.

@seladb you interested in picking this one perhaps?

Sure @Goldziher I think I can take it! Might take me some time though because I'm busy with other stuff at the moment

@Goldziher @cofin I looked up the OT integration with FastAPI and here is what I understand:

The instrumentation class is implemented in the OT repo (and NOT in the FastAPI repo):

https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/instrumentation/opentelemetry-instrumentation-fastapi/src/opentelemetry/instrumentation/fastapi/__init__.py

The way it's used is outside of the FastAPI app: import fastapi
 from opentelemetry.instrumentation.fastapi import FastAPIInstrumentor

 app = fastapi.FastAPI()

 @app.get("/foobar")
 async def foobar():
     return {"message": "hello world"}

 FastAPIInstrumentor.instrument_app(app)

What the instrumentor does is add a middleware to the app:

https://github.com/open-telemetry/opentelemetry-python-contrib/blob/744851b3cf3a58471e44c3a20f143275fa16cdce/instrumentation/opentelemetry-instrumentation-fastapi/src/opentelemetry/instrumentation/fastapi/__init__.py#L184

This is an API that Starlite doesn't have. Actually FastAPI doesn't have it either - it inherits it from the Starlette app:

https://github.com/encode/starlette/blob/858629f5188bc79d452600b1eb90eaa0045f6454/starlette/applications.py#L165

Then the instrumentor adds a middleware that is implemented in the OT repo (and NOT in the FastAPI repo):

https://github.com/open-telemetry/opentelemetry-python-contrib/blob/744851b3cf3a58471e44c3a20f143275fa16cdce/instrumentation/opentelemetry-instrumentation-asgi/src/opentelemetry/instrumentation/asgi/__init__.py#L368

It also maintains a list of all instrumented apps, I'm not sure for what purpose (looks like something internal to how OT works);

https://github.com/open-telemetry/opentelemetry-python-contrib/blob/744851b3cf3a58471e44c3a20f143275fa16cdce/instrumentation/opentelemetry-instrumentation-fastapi/src/opentelemetry/instrumentation/fastapi/__init__.py#L243

I think this design doesn't fit Starlite. Do you have any design in mind?
What do you think should be implemented on the Starlite side what on the OT side?

Hmm, we should start with opening an issue in the open telemtry app.
As for what to do - you can see this draft PR of mine in the sentry repository, it does basically the same: https://github.com/getsentry/sentry-python/pull/1597

@Goldziher I have to say I don't fully understand the architecture of these integrations (both OT and Sentry) 😕
Wouldn't it be easier to add an "OT plugin" or "Sentry plugin" to the Starlite repo that handles the instrumentation (e.g add a middleware, listen to relevant events, etc.)? I'm not familiar with our current plugin system, but it sounds feasible...
Or maybe expose Starlite's plugin in easy-to-use APIs that will provide everything these integrations need?
I assume there are solid answers to why these suggestions are not feasible, so I apologize in advance for my lack of knowledge...

I started work on this @seladb --> https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1388
If you find the time, you're welcome to help with this. Tests are not in place yet etc.

Thanks @Goldziher ! I can see you're on top of this so I can probably work on some other tasks 😃
Let me know if you need my help, but TBH I still don't really understand the design...

Hello 👋 ,
I am one of the co-maintainers of OpenTelemetry. The instrumentations are maintained in our repo for various reasons. We could provide some value fast without putting in a lot of effort to convince and implement the tracing directly in third-party libraries. Ideally, the direction we would like to see in the long term is the support baked directly, and users who install the SDK will have the real spans out of the box.
I think it's best for starlite to ship the support directly with some middleware or plugin mechanism. I am not very familiar with the starlite internal but I would be willing to review the OTEL parts if you decide to implement the changes here.

Fwiw, the falcon also showed interest in adding support directly https://github.com/falconry/falcon/issues/1828. If package authors adopt OTEL gradually, we can start deprecating the instrumentation package that monkey patch the original packages, which is in the best interest of everyone.

Fwiw, the falcon also showed interest in adding support directly https://github.com/falconry/falcon/issues/1828. If package authors adopt OTEL gradually, we can start deprecating the instrumentation package that monkey patch the original packages, which is in the best interest of everyone.

Hi, sure this would be easier than finishing the OTEL instrumentation . We should make it a separate package in that case.

@srikanthccv - can you assist with reviewing the PR linked above?

@Goldziher, I took a quick look at the pull request. I will review it again tomorrow when I am on my computer. I see that you are extending the ASGI instrumentation middleware. Are your contrib components also follow the rules of semver? because the upstream middleware is still in beta and can possibly introduce breaking changes as it gets improved.

@Goldziher, I took a quick look at the pull request. I will review it again tomorrow when I am on my computer. I see that you are extending the ASGI instrumentation middleware. Are your contrib components also follow the rules of semver? because the upstream middleware is still in beta and can possibly introduce breaking changes as it gets improved.

Hi, we are following semver of course.


ipyaladin viewer style sheet issue in marimo notebooks

Describe the bug
I am attempting to use ipyaladin (an astronomical sky survey viewer, and more) in marimo.  They use AnyWidget so I thought it would be fun to try in marimo. However, I ran into an issue that the icons for the widget appeared huge and did not appear on the image visualization. The area that registers clicks was also directly below the image. See screenshot for an idea of what's going on - the screenshot is at 30% zoom in my browser.
This issue is also posted to the ipyaladin repo. Through the marimo discord, it was suggested this is a stylesheet issue, potentially with ShadowDOM.

Environment
{
"marimo": "0.8.2",
"OS": "Windows",
"OS Version": "10",
"Processor": "Intel64 Family 6 Model 151 Stepping 2, GenuineIntel",
"Python Version": "3.10.6",
"Binaries": {
"Browser": "128.0.6613.84",
"Node": "v18.18.2"
},
"Requirements": {
"click": "8.1.7",
"importlib-resources": "5.12.0",
"jedi": "0.18.1",
"markdown": "3.6",
"pymdown-extensions": "10.8.1",
"pygments": "2.18.0",
"tomlkit": "0.13.0",
"uvicorn": "0.30.1",
"starlette": "0.37.2",
"websockets": "12.0",
"typing-extensions": "4.12.2",
"ruff": "0.5.2"
}
}
Code to reproduce
import marimo
__generated_with = "0.8.2"
app = marimo.App(width="full")
@app.cell
def __():
import marimo as mo
from ipyaladin import Aladin
return Aladin, mo
@app.cell
def __(Aladin, mo):
aladin = Aladin(target="ngc4151", fov=2)
aladin = mo.ui.anywidget(aladin)
aladin
return aladin,
if name == "main":
app.run()

Hi Marimo team, ipyaladin team here :slightly_smiling_face:
We'd love to make things better on our side, but it is a bit out of our expertise. Do you have good readings on how to proceed? Or maybe other anywidgets that do stylesheets correctly so that we could get inspiration?

We have a dirty solution where we import Aladin's style sheet in the widget for now.

:crossed_fingers: I think we can support Marimo this in the next version

Looks like this was fixed upstream: https://github.com/cds-astro/aladin-lite/pull/194
Closing as completed


Multiple partial charges calculators with Amber's antechamber

[x] Tag issue being addressed
[ ] Add tests
[ ] Update docstrings/documentation, if applicable
[ ] Update changelog

Codecov Report

Merging #15 into master will increase coverage by 1.03%.
The diff coverage is 94.28%.


Adding Copyrights header to the code source

This commit import tooling from https://github.com/DataDog/datadog-agent repo to automatically scan and add copyrights header to all the code source.

/merge


[BugFix]Fix some bug about binlog config

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

fix bug, can not load editlog of modify_binlog and modify binlogAvailableVersion
fix bug, if only binlog_enable is set , then binlog config can not set successfully
fix bug, binlogAvailableVersion can not set successfully when binlog_enableis false
change the logic of setBinlogConfig
fix the logic of checkIsPartitionChanged
optimize some code, such as the format of log info

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto backported to target branch

[ ] 2.5
[ ] 2.4
[ ] 2.3
[ ] 2.2

[FE PR Coverage Check]
:heart_eyes: pass : 19 / 23 (82.61%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/binlog/BinlogManager.java
2
6
33.33%
[74, 78, 81, 97]

:large_blue_circle:
com/starrocks/catalog/OlapTable.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/common/Config.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/server/LocalMetastore.java
10
10
100.00%
[]

:large_blue_circle:
com/starrocks/leader/ReportHandler.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/binlog/BinlogConfig.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/alter/SchemaChangeHandler.java
2
2
100.00%
[]

run starrocks_admit_test

run starrocks_admit_test

[FE PR Coverage Check]
:disappointed: fail : 16 / 21 (76.19%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/binlog/BinlogManager.java
2
6
33.33%
[74, 78, 81, 97]

:large_blue_circle:
com/starrocks/server/LocalMetastore.java
9
10
90.00%
[2390]

:large_blue_circle:
com/starrocks/catalog/OlapTable.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/leader/ReportHandler.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/binlog/BinlogConfig.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/alter/SchemaChangeHandler.java
2
2
100.00%
[]

[FE PR Coverage Check]
:disappointed: fail : 16 / 21 (76.19%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/binlog/BinlogManager.java
2
6
33.33%
[74, 78, 81, 97]

:large_blue_circle:
com/starrocks/server/LocalMetastore.java
9
10
90.00%
[2390]

:large_blue_circle:
com/starrocks/catalog/OlapTable.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/leader/ReportHandler.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/binlog/BinlogConfig.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/alter/SchemaChangeHandler.java
2
2
100.00%
[]

[FE PR Coverage Check]
:disappointed: fail : 16 / 21 (76.19%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/binlog/BinlogManager.java
2
6
33.33%
[74, 78, 81, 97]

:large_blue_circle:
com/starrocks/server/LocalMetastore.java
9
10
90.00%
[2390]

:large_blue_circle:
com/starrocks/catalog/OlapTable.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/leader/ReportHandler.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/binlog/BinlogConfig.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/alter/SchemaChangeHandler.java
2
2
100.00%
[]

[FE PR Coverage Check]
:disappointed: fail : 17 / 24 (70.83%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/binlog/BinlogManager.java
2
7
28.57%
[74, 78, 81, 97, 272]

:large_blue_circle:
com/starrocks/server/LocalMetastore.java
9
11
81.82%
[2390, 4194]

:large_blue_circle:
com/starrocks/catalog/OlapTable.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/leader/ReportHandler.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/binlog/BinlogConfig.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/alter/SchemaChangeHandler.java
2
2
100.00%
[]

run starrocks_admit_test

run starrocks_admit_test

[FE PR Coverage Check]
:heart_eyes: pass : 33 / 41 (80.49%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/binlog/BinlogManager.java
2
7
28.57%
[74, 78, 81, 97, 272]

:large_blue_circle:
com/starrocks/server/LocalMetastore.java
11
13
84.62%
[2168, 4194]

:large_blue_circle:
com/starrocks/alter/SchemaChangeHandler.java
8
9
88.89%
[1427]

:large_blue_circle:
com/starrocks/catalog/OlapTable.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/leader/ReportHandler.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/catalog/TableProperty.java
7
7
100.00%
[]

:large_blue_circle:
com/starrocks/binlog/BinlogConfig.java
1
1
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 33 / 41 (80.49%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/binlog/BinlogManager.java
2
7
28.57%
[74, 78, 81, 97, 272]

:large_blue_circle:
com/starrocks/server/LocalMetastore.java
11
13
84.62%
[2168, 4194]

:large_blue_circle:
com/starrocks/alter/SchemaChangeHandler.java
8
9
88.89%
[1427]

:large_blue_circle:
com/starrocks/catalog/OlapTable.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/leader/ReportHandler.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/catalog/TableProperty.java
7
7
100.00%
[]

:large_blue_circle:
com/starrocks/binlog/BinlogConfig.java
1
1
100.00%
[]

run starrocks_admit_test

run starrocks_admit_test


Trace are not being injected in netty error logs

When an error in thrown the trace are not being injected in netty error logs.

Expected Behavior
Traces should be injected in error logs.
Actual Behavior
Traces are not being injected.
Your Environment
java: 17
spring-boot: 2.7.2
spring-boot-starter-webflux using reactor netty http 1.0.21
spring-cloud-starter-sleuth: 3.1.3

I see the same behaviour if using DECORATE_QUEUES, but using DECORATE_ON_EACH as the Reactor Instrumentation type preserved the trace id.

@samueldlightfoot DECORATE_QUEUES seems to not pass the traces when using flatMap DECORATE_ON_EACH will. But it seems in any case that the trace are not passed to the error log of the webClient which make it very complicate to hunt down the error afterward.

I would suggest using DECORATE_ON_EACH. Of course it means a big performance drop but it should work most of the time. Sleuth and Reactor instrumentation works most of the time - most likely you found a problematic spot where it doesn't work well. Have you tried the latest snapshots of sleuth?

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.