Make cstore_fdw postgresql 9.6 compatible

There are few api changes in postgresql 9.6 regarding foreign tables.
cstore_fdw does not compile under 9.6devel. Changes detected so far are
1 - additional PathKey parameter in create_foreignscan_path()
2 - Struct RelOptInfo is changed. List *reltargetlist is replaced by struct PathTarget *reltarget
3 - function pull_var_clause() has now 2 parameters instead of 3
4 - can not locate BTREE_AM_OID which is now at catalog/pg_am.h
Looks like items 1 and 2 are the ones with the most impact.
There are additional PG 9.6 changes that enable parallel scans, or in place aggregation These need to be considered for new feature development.

Does cstore support parallel workers yet?  I have been trying it out with 9.6 but the max_parallel_workers_per_gather setting seemed to have no impact on explain analyze or performance.

No, not yet. It is in our todo list though.


Play services dependency set to 8.1.0+.

@herby thanks, will test and merge tonight

@herby I bumped the version in npm. also you should be able to create issues now


Add support for PatternMatchMapping formatting

Summary
Adds support for PatternMatchMapping -- i.e., cases like:
match foo:
    case {"a": 1, "b": 2, **rest}:
        pass

Unfortunately, this node has three kinds of dangling comments:
{  # "open parenthesis comment"
   key: pattern,
   **  # end-of-line "double star comment"
   # own-line "double star comment"
   rest  # end-of-line "after rest comment"
   # own-line "after rest comment"
}

Some of the complexity comes from the fact that in **rest, rest is an identifier, not a node, so we have to handle comments after it as dangling on the enclosing node, rather than trailing on **rest. (We could change the AST to use PatternMatchAs there, which would be more permissive than the grammar but not totally crazy -- PatternMatchAs is used elsewhere to mean "a single identifier".)
Closes https://github.com/astral-sh/ruff/issues/6644.
Test Plan
cargo test

We may want to instead change the rest in **rest to a Pattern, to simplify the comment handling -- I've put that change up here (https://github.com/astral-sh/ruff/pull/6838). If that seems like a reasonable idea, I'll merge that first, then rework this PR.


Fix Event Hub Namespace & Update Documentation

The Logging with Event Hub lab has some discrepancies with respect to the Event Hub namespace that need to be fixed to avoid confusion.

Fixed and deployed.


HTMLPurifier Attr.EnableID option required to save page anchors

Page anchors added with this plugin will be removed on save by the default HTMLPurifier settings. You may want to document that the the Attr.EnableID option should be set to true in order to keep page anchors.
It's worth mentioning that IDs are disallowed by default because:

without proper configuration, user input can easily break the validation of a webpage by specifying an ID that is already on the surrounding HTML.

More information here: http://htmlpurifier.org/live/configdoc/plain.html#Attr.EnableID
HTMLPurifier settings can be modified by creating a .json file in config/htmlpurifier/ (e.g. config/htmlpurifier/Standard.json). Then, this config can be selected when setting up a Redactor field within the field's Advanced options.

Craft's starter project now includes config/htmlpurifier/Default.json out of the box with Attr.EnableID set to true.
https://github.com/craftcms/craft/commit/c0f495ed7b2e9ded2889c3ea27328f616f0b2c2f


Cannot run buckaroo: "No such file or directory"

Description
When I run buckaroo quickstart (or any other command) I see the following message:
Error: Os { code: 2, kind: NotFound, message: "No such file or directory" }

I followed the installation instructions to install buckaroo 2.2.0 (using wget) and buck 2<IP_ADDRESS> (using homebrew).
Your Environment
$ uname -a
Darwin Nicks-MacBook-Pro.local 18.2.0 Darwin Kernel Version 18.2.0: Thu Dec 20 20:46:53 PST 2018; root:xnu-4903.241.1~1/RELEASE_X86_64 x86_64

I cannot reproduce this on Linux, will try macOS.

I did a clean install on macOS and did not hit this issue.
To me this looks like a Warp issue.
Please could you try clearing you Warp cache folder?
rm -rf ~/Library/Application\ Support/warp

That did the trick, thanks!

Awesome! :tada:


mAP evaluation

Hi, thanks for your interesting work! I'm wondering when would you share the evaluation code for calculating the Mean Average Precision (mAP)? Thanks so much!

https://github.com/frostinassiky/gtad/blob/master/evaluation/eval_detection.py

Thank so much for your quick response!


Change the css based on how many windows are open

1 window: take all width
2 windows: each of them are 50%
3 windows: each of them are 33%
others: each takes max-width = XXrem

Fixed in adeadee7bf92453c65fd63c4cac83571c83a3345


Failure when I train lora dreambooth for stable diffusion 2.1

I noticed that there is a comment in the lora dreambooth example
export MODEL_NAME= "CompVis/stable-diffusion-v1-4" #"stabilityai/stable-diffusion-2-1"
I have trained stable diffusion 1.4 successfully. But when I just change the model name to stable diffusion 2.1, the model failed to generate a normal image:

What should I do if I want to train lora dreambooth for stable diffusion 2.1?

I have resolved this issue.
The example in train_dreambooth.py initialize the noise scheduler by:
noise_scheduler = DDPMScheduler(         beta_start=0.00085,         beta_end=0.012,         beta_schedule="scaled_linear",         num_train_timesteps=1000,     )
The default value of prediction_type is "epsilon" here and in sd1, but "v_prediction" in sd2.1.


JDBC Connector (Kyuubi Hive JDBC->Spark SQL) does not support time travel queries

Using version 2.5.0
I created a JDBC Resource that utilizes kyuubi's JDBC Hive Compatible driver using a Spark engine and Iceberg storage.  Running AS OF queries using DBeaver to retrieve data works fine, but the same query in Starrocks generates an error.  It would be great if setting a property, e.g. on the creation of the external resource and/or on the creation of the jdbc external table would push the entire query down to the driver.

create external resource kyuubijdbc
properties (
    "type"="jdbc",
    "jdbc_uri"="jdbc:kyuubi://<IP_ADDRESS>:10009",
    "driver_url"="https://repo1.maven.org/maven2/org/apache/kyuubi/kyuubi-hive-jdbc-shaded/1.6.1-incubating/kyuubi-hive-jdbc-shaded-1.6.1-incubating.jar",
    "driver_class"="org.apache.kyuubi.jdbc.KyuubiHiveDriver",
    "user"="scott",
    "password"="tiger"
);

show resources;
--drop resource kyuubijdbc;

create database sparkjdbc;
use sparkjdbc;

--drop table mysampleext;
create external table mysampleext (
    `id` bigint NULL,
    `data` varchar (200) NULL
) ENGINE=jdbc
properties (
    "resource"="kyuubijdbc",
    "table"="my_catalog.iceberg.mysample"
);

select * from mysampleext;

SELECT * FROM mysampleext VERSION AS OF<PHONE_NUMBER>536337515;

https://github.com/StarRocks/starrocks/pull/13707
As you can see, starrocks pass the temporal clause to MySQL external table in this PR.
This is the only kind of table that starrocks will pass the temporal clause to.
If starrocks can pass the temporal clause to JDBC, does it work for you?

Hi @imay ,
Yes, that is exactly what I am looking for, thank you.  Is this something that can be implemented without too much difficulty?
Regards,
Chris


SSL certificate error when accessing https://www

Hossain, I read your article  on how to use a custom domain for GitHub Pages and I am using it for my websites.
It works mostly good for a minor exception. When trying to access the site with https://www. https://www.hossainkhan.com/ the browser shows a big warning. At least Firefox. This is part of the message:

Warning: Potential Security Risk Ahead
Firefox detected a potential security threat and did not continue to www.hossainkhan.com. If you visit this site, attackers could try to steal information like your passwords, emails, or credit card details.....
Websites prove their identity via certificates. Firefox does not trust this site because it uses a certificate that is not valid for www.hossainkhan.com. The certificate is only valid for the following names: www.github.com, *.github.io, *.githubusercontent.com, *.github.com, github.com, github.io, githubusercontent.com
Error code: SSL_ERROR_BAD_CERT_DOMAIN

I have the same problem and I didn't find the solution yet. GitHub Pages documentation on how to do this is not clear. Already contacted GitHub support 1 day ago but no answer yet. Maybe changing the repository to xxxx.github.io?

@martinmorando That is a good find. The security error is actually unacceptable at this age of web.
This error is also visible in Chrome.
I don't know the solution at the moment, I will google it and also try to contact github support and update it here and in the article.

Checked that if you try www.hossainkhan.com, then github auto redirects to HTTPS due to settings in the repo. However, this does not solve the actual issue in case someone manually puts it.

I'm not sure if the allowed domain list is actually an issue. Because none of the custom domain falls under that. Usually before custom domain the project URL is like https://amardeshbd.github.io/repo-name/ or in my case https://amardeshbd.github.io/hossainkhan.com/

@martinmorando did you enforce HTTPS?
https://help.github.com/en/github/working-with-github-pages/securing-your-github-pages-site-with-https

@amardeshbd I contacted  support. This is what Steve Graff, GitHub Developer Support, answered (I'm sharing with his permission):

Thanks for reaching out about this! We don't currently support creating a certificate that covers both your root domain and your www subdomain. We only generate a certificate for the exact domain that you specify in the custom domain input box. I will add your +1 to that feature request internally though!
If you've set up a CNAME record for the www subdomain that points to your GitHub.io address username.github.io then we will redirect traffic from the www subdomain to your apex domain, but only if you use a protocol-less, or http://, link. If you explicitly specify https://www.example.com you will still encounter a certificate error.

So, there's nothing we can do about it as long as we keep using GitHub Pages. Maybe you can reach them out so they add another +1 to that feature.
P.D: I had disabled "enforce HTTPS" on that website temporarily. Now I activated again, thanks for the reminder.

hi @martinmorando I got a similar response from Simon. Looks like nothing can be done at the moment.
Just need to make sure, the explicit https://www URL does not leak out in the web, in that way this should not be an issue.

Simon Giesemann (GitHub Developer Support)
Feb 14, 5:28 AM UTC
Hi Hossain,
Thanks for reaching out about this! We don't currently support creating a certificate that covers both your root domain and your www subdomain. We only generate a certificate for the exact domain that you specify in the custom domain input box. I will add your +1 to that feature request internally though!
If you've set up a CNAME record for the www subdomain that points to your GitHub.io address username.github.io then we will redirect traffic from the www subdomain to your apex domain, but only if you use a protocol-less, or http://, link. If you explicitly specify https://www.example.com you will still encounter a certificate error.
Cheers,
Simon
GitHub Support

Exactly, otherwise it would negatively impact on SEO. We can close this issue on your repository if you agree.


Add ability to specify a post-track callback function.

Hi, are you able to provide feedback on this PR?

Sorry, I'm not actually sure right now. I've been so swamped that I haven't had time to look into this any further, and I see that there is a lot of change desired for the angulartics project including some big changes to the way it's written. I have to find the time to go over this fork as well as see how I can help with some of the desired larger changes.


notification template as env var

Summary

How did you test your changes?

thanks @vishnumad can you approve this as well?


Using Multi GPU support

While using tgm, I have come across one or two places in the code where the creation of new tensor has to be done on the device in the context otherwise the multi gpu training gives an error.
Should I give a pull request or perhaps you could think of better ways to solve this.
for example in torchgeometry/core/conversions.py in line 97-100, I changed the code as follows
device_points = points.device
scale: torch.Tensor = torch.tensor(1.) / torch.clamp(z_vec, eps)
scale = scale.to(device_points)

@Msabih could you give us more information about your error, a screenshot of what you get, the devices you use, etc. I don't see why multi gpu should be a problem, since scale is derived from z_vec and this directly from points.

I was getting the typical error that these two tensors must be on the same devices. I will rebuild the library and get back to you with the error message. I am using multiple nvidia TX 1080 GPUs.
I didnt read the whole code, just got to the point of error, printed the device names of the tensors and scale was one device: 0 whereas I was using 6 and 7.

@Msabih could you give us more information about your error, a screenshot of what you get, the devices you use, etc. I don't see why multi gpu should be a problem, since scale is derived from z_vec and this directly from points.

@edgarriba

/torchgeometry/core/conversions.py", line 98, in convert_points_from_homogeneous
return scale * points[..., :-1]
RuntimeError: binary_op(): expected both inputs to be on same device, but input a is on cuda:0 and in put b is on cuda:6

It's interesting. How do you copy your tensors to cuda outside of the functions? Could you provide a small script so that we can reproduce the issue? Which torch version do you use? I'm fine with your fix, but we have been using this function in cuda multi gpu an no errors like this one. Would like to see why it happens first. /cc @bhack

It's interesting. How do you copy your tensors to cuda outside of the functions? Could you provide a small script so that we can reproduce the issue? Which torch version do you use? I'm fine with your fix, but we have been using this function in cuda multi gpu an no errors like this one. Would like to see why it happens first. /cc @bhack

So I am taking a list of devices and giving it to the DataParallel as argument. Later on images are taken to first GPU for training like images = images.to(self.devices[0])

Ok I see. Last, just to fully understand, if you print points, zvec and scale devices what do you get?

@Msabih can you provide a unit test script where this can be reproduced ?

@Msabih can you provide a unit test script where this can be reproduced ?

Okay, I will do it in a day as I find time. Just to note, I think this problem will not occur if multiple GPUs were used using DistributedDataParallel but only using DataParallel. Because I have switched to using DDP even on single machine with multiple GPUs as it distributes the load equally and is consistent. I did'nt try the perspective transform in that setting but I am pretty sure that this error will not come over there.
However to reproduce this issue on DataParallel, I will make a small test script.

awesome. So DDP seems the way to go in general right ?

awesome. So DDP seems the way to go in general right ?

Yes in general that is the case. But users may use DataParallel just because its easier or there could be a genuine use case. One use case is that Distributed Data Parallel takes more memory( its multiplied by number of nodes) if your Data Loader loads all the dataset at once however Data Parallel uses same amount of memory as single process use case. Another usecase might be if the cluster has free GPUs but is limited in terms of CPU Cores.
You might want to read this use case.
https://github.com/NVIDIA/apex/issues/269
For this library, pushing scale to the same device would work for all cases, Single, DataParallel and Distributed Data Parallel.

@Msabih could you contribute with this patch and a quick test ?

@Msabih @bhack was this solved ? Otherwise I'm closing it.


ResolvedProjectScans in ResolvedWithEntry does not preserve column aliases.

Hello,
I noticed that if a column does not contain a transformation, columnList in ResolvedProjectScan in ResolvedWithEntry does not preserve column aliases. I have added an example below.
Such as,
with base as(
select
 a.id as t_id,
 ifnull(a.name,"") as calculated_name
 from table a
)

In the column list tableName of the column t_id returns table it's name returns id. However, tableName of calculated_name returns base and it's name is calculated_name.
Is this expected behavior?
Thanks in advance.

That is the default behavior of ZetaSQL, but you can change it by setting the createNewColumnForEachProjectedOutput option in your AnalyzerOptions.
AnalyzerOptions options = new AnalyzerOptions();
options.setCreateNewColumnForEachProjectedOutput(true);
options.setLanguageOptions(BigQueryLanguageOptions.get());  // If you're analyzing for BigQuery

Thanks for the quick response.

I have tried the setCreateNewColumnForEachProjectedOutput and setPreserveColumnAliases methods. However, it does not change anything. There are some problems I cannot understand. Such as user-defined functions cannot be found even if they are in the catalog, table names do not include schema and project name and the columns in with queries do not include aliases.
This column alias problem affects the lineage methods.

Lineage should work well even without column aliases not preserved, unless there's some bug you're encountering that I don't know about. Lineage ultimately doesn't care about the aliases you used in the middle of your query if no computation was done in the middle.
As for tables and UDFs, maybe I can help you take a closer look at what you're working on. Can you provide any code snippets of things that don't work as you expect so that we can take a look?

Sounds good! I'm closing the issue then.
Not much to comment about the column aliases bit on my end. The createNewColumnForEachProjectedOutput option should project a new column (which will take the alias) for all outputs of ResolvedProjectScans. Feel free to share a snippet to reproduce if you see a different behavior.


Migration from Integration Studio to VSC MI extension

Description:
Different Issues when migrating a project from Integration Studio with the VSC extension:

Some Versions don't migrate data sources and data services from integration studio to the extension
Some Versions (e.g.v0.9.24062409) don't display data sources and data services that were migrated even though the files exist
Some Versions (e.g. v0.9.24071508) migrate and display the data source and data service correctly but don't migrate Sequences
Some Versions (e.g.v0.9.24062409) don't offer the ability to create a data source or data service

Suggested Labels:
inconsistency
Suggested Assignees:
Affected Product Version:
v0.9.24071508
v0.9.24062409
Other versions as well
OS, DB, other environment details and versions:
Steps to reproduce:

migrate a project that has a data source and data service artifact from integration studio to vsc

Related Issues:

Closing this issue as the aforementioned behaviours cannot be observed in the latest v1.1.0 release. Please reopen if the problem persists.


I get some error when I'm using tensorflow at the window anaconda

Please

go to Stack Overflow for help and support:
http://stackoverflow.com/questions/tagged/tensorflow
If you open a GitHub issue, here is our policy:

It must be a bug or a feature request.
The form below must be filled out.

Here's why we have that policy: TensorFlow developers respond to issues. We want to focus on work that benefits the whole community, e.g., fixing bugs and adding features. Support only helps individuals. GitHub also notifies thousands of people when issues are filed. We want them to see you communicating an interesting problem, rather than being redirected to Stack Overflow.

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
TensorFlow installed from (source or binary):
TensorFlow version (use command below):
Bazel version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:
Exact command to reproduce:

You can collect some of this information using our environment capture script:
https://github.com/tensorflow/tensorflow/tree/master/tools/tf_env_collect.sh
You can obtain the TensorFlow version with
python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
Describe the problem
Describe the problem clearly here. Be sure to convey here why it's a bug in TensorFlow or a feature request.
I installed it at the window.
When I'm test sample code and print it describes messages.
I repeated it.
At that time it succesfully well.
How can I solve this it?
Is it installed well?
Source code / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached. Try to provide a reproducible test case that is the bare minimum necessary to generate the problem.
(C:\Users\KBS\Anaconda3) C:\Users\KBS>activate tensorflow
(tensorflow) C:\Users\KBS>python
Python 3.5.3 | packaged by conda-forge | (default, May 12 2017, 16:16:49) [MSC v.1900 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.

import tensorflow as tf
a=tf.constant('a')
sess=tf.Session()
print(sess.run(a))
E c:\tf_jenkins\home\workspace\release-win\device\cpu\os\windows\tensorflow\core\framework\op_kernel.cc:943] OpKernel ('op: "BestSplits" device_type: "CPU"') for unknown op: BestSplits
E c:\tf_jenkins\home\workspace\release-win\device\cpu\os\windows\tensorflow\core\framework\op_kernel.cc:943] OpKernel ('op: "CountExtremelyRandomStats" device_type: "CPU"') for unknown op: CountExtremelyRandomStats
E c:\tf_jenkins\home\workspace\release-win\device\cpu\os\windows\tensorflow\core\framework\op_kernel.cc:943] OpKernel ('op: "FinishedNodes" device_type: "CPU"') for unknown op: FinishedNodes
E c:\tf_jenkins\home\workspace\release-win\device\cpu\os\windows\tensorflow\core\framework\op_kernel.cc:943] OpKernel ('op: "GrowTree" device_type: "CPU"') for unknown op: GrowTree
E c:\tf_jenkins\home\workspace\release-win\device\cpu\os\windows\tensorflow\core\framework\op_kernel.cc:943] OpKernel ('op: "ReinterpretStringToFloat" device_type: "CPU"') for unknown op: ReinterpretStringToFloat
E c:\tf_jenkins\home\workspace\release-win\device\cpu\os\windows\tensorflow\core\framework\op_kernel.cc:943] OpKernel ('op: "SampleInputs" device_type: "CPU"') for unknown op: SampleInputs
E c:\tf_jenkins\home\workspace\release-win\device\cpu\os\windows\tensorflow\core\framework\op_kernel.cc:943] OpKernel ('op: "ScatterAddNdim" device_type: "CPU"') for unknown op: ScatterAddNdim
E c:\tf_jenkins\home\workspace\release-win\device\cpu\os\windows\tensorflow\core\framework\op_kernel.cc:943] OpKernel ('op: "TopNInsert" device_type: "CPU"') for unknown op: TopNInsert
E c:\tf_jenkins\home\workspace\release-win\device\cpu\os\windows\tensorflow\core\framework\op_kernel.cc:943] OpKernel ('op: "TopNRemove" device_type: "CPU"') for unknown op: TopNRemove
E c:\tf_jenkins\home\workspace\release-win\device\cpu\os\windows\tensorflow\core\framework\op_kernel.cc:943] OpKernel ('op: "TreePredictions" device_type: "CPU"') for unknown op: TreePredictions
E c:\tf_jenkins\home\workspace\release-win\device\cpu\os\windows\tensorflow\core\framework\op_kernel.cc:943] OpKernel ('op: "UpdateFertileSlots" device_type: "CPU"') for unknown op: UpdateFertileSlots
b'a'
print(sess.run(a))
b'a'

This error was only present in TensorFlow 1.0 for Windows. Upgrading to the latest stable release (1.1) or release candidate (1.2rc0) will get rid of these messages.


Feature Request:  Make source_pd in filter_pd() optional

Feature Idea
Make source_pd in filter_pd() optional and remove logic handling source_pd == NULL in derive_param_*() functions.
Relevant Input
No response
Relevant Output
No response
Reproducible Example/Pseudo Code
No response

Discussed at team meet today and we agreed to put this one on hold for now and run by testers for feedback later. Generally there's a feeling that making source_pd optional here makes the function too loose, and it then only opens up more questions.
One possible option would be to move filter_pd to admiral core level and name it something more generic and change source_pd argument to something like source_end_date, but the feeling at the moment is some of us quite liked the simplicity of calling this PD and having it onco specific as it resonates with our very common need as onco TA users.
The other point then mentioned is around whether we make clearer in our vignettes that not only PD dates could be used here - e.g. a user could even choose to take the minimum of PD and NACT date.

I think the two last items are contradicting each other. If we suggest that source_pd should be used for other dates as well, why do we name it source_pd?
As a user I would be confused and it requires extra work from my side. For example, if I am reviewing an ADRS script where source_pd is set to the minimum of PD and NACT date, I would wonder if the results will be correct. So I need to look at the documentation and code of the derive_param_*() function. I would need to verify that there are no checks verifying that at the specified date PD occurred. I would also need to verify that source_pd is used to restrict the source data only but not for example to identify subjects with PD. I would need to do the same when I am the programmer writing the ADRS script. To be on the safe side I would need to repeat this after each admiralonco release.

Yes good point. On reflection I actually prefer the approach outlined at https://pharmaverse.github.io/admiralonco/test/articles/adrs.html#input for how to deal with NACT either via ANL01FL or up front pre-processing to filter out records you don't want. Then leave source_pd to just be for PDs. It's much clearer this way. FYI @amitjaingsk

The admiralonco functions are superseded by derive_extreme_event(). I would not expect that we develop them further. Thus I am closing this issue.


Add label in order to render comments

I have added a label to display comments' content in form 0205. The expected result can be seen in the following screenshot:

To test it:

open sdx-console,
load 023.0205.json survey,
within the "Data to send" text area assign "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Donec et mattis elit, porta blandit sapien." to the 146 key,
click the Submit button,
from the Receiver section click on the Images tab and open the most recent image.

Fixes #27


SUSE Support and crmsh

Hello Team,
I am working on sap-linuxlab (community.sap_install) and our plan is to make sure that role sap_ha_pacemaker_cluster, which consumes fedora.linux_system_roles, is correctly working on SUSE systems.
I noticed that groundwork for adoption of non-pcs steps was already done thanks to Sean in #122, so adoption would consist of:

splitting of main.yml based on os_family, because it contains pcs related tasks directly (non-generic names)
creating variables for Suse
creating separate tasks under shell_crmsh for crmsh, corosync, sbd
replicating cluster setup for SUSE from sap-linuxlab/community.sles-for-sap/cluster

There are few things that I wanted to ask for clarification, before proceeding with any changes in fork:

Are there any ongoing efforts for SUSE support, or is this free range to pickup?
ha_cluster and idempotency?

Are there any ongoing efforts for SUSE support, or is this free range to pickup?

Not that I know of - @sean-freeman or @berndfinger might know.

ha_cluster and idempotency?

The role is not currently idempotent for all operations - not sure which are idempotent and which are not - I don't know if you can make the crmsh implementation idempotent without making the pcs implemetation idempotent

@richm I had started porting some code in line with the mentioned Ansible Role draft (keeping to the scope of ha_cluster to accept config and execute, i.e. not adding any of the commands for a specific platform). However there were other priorities in the SAP LinuxLab Open-Source initiative that needed attention first, so I would probably classify this as free range.
I would probably suggest that ha_cluster is psuedo-idempotent in the sense that, if you execute with the same variables you will arrive at the same outcome. However if on multiple runs some variable is changed, it will alter the config file, and the cibadmin will (without mercy or checks) replace any existing config with that new definition.

Thank you both for your comments, I will proceed with with work on my end to see how this can be implemented.

if you execute with the same variables you will arrive at the same outcome. However if on multiple runs some variable is changed, it will alter the config file, and the cibadmin will (without mercy or checks) replace any existing config with that new definition.

That's correct. When you run the role repeatedly with the same variables, you'll get the same outcome and the role should not even restart cluster daemons and thus it should not disrupt cluster operations. However, the role removes any cluster configuration not specified in the role variables. This applies to CIB, corosync and other cluster components. Changing some components' (corosync, sbd) configuration results in restarting those daemons.

@sean-freeman @tomjelinek @berndfinger Lot of idempotency is coming from fact that cluster config will be rebuilt using all those CIB tasks and then remain untouched if they are same.
How would this work combined with sap_install if you re-run them both @sean-freeman ? sap_ha_pacemaker_cluster is where all resources and pacemaker config is created and I dont see anywhere ha_cluster_resource_primitives or __sap_ha_pacemaker_cluster_resource_primitives are defined in examples, so I would assume it would result in CIB being replaced regardless.
If this destructive behavior in combination with sap_ha_pacemaker_cluster is expected, then there is not much value for us in implementing CIB steps under crmsh.

@tomjelinek Thinking about my comment / on re-visit to this GH Issue, it is a good idea to give the end-user a choice on how ha_cluster handles config changes?
The following would warrant a separate GH Issue to be raised.
Perhaps "Feature Request: ha_cluster_config_change_then_halt" would protect an end-user in case of config drift / the variables changed by accident (for whatever reason), and the end-user performs re-run but does not want to replace the working config. By default I imagine such a variable would be false, to preserve the "psuedo-idempotence" and not create a breaking change.
In case such a feature exists already and I cannot see it, please excuse me and please correct me.
As @marcelmamula perceives, and other end-users may also, the behaviour of ha_cluster could be considered "destructive" as there is no safety net in case any variable was changed.

@marcelmamula Best to move any continued discussion specific to SAP, into the sap_install GH Issues or Discussions. Will answer here for posterity.
On it's own, the Ansible Role sap_ha_pacemaker_cluster is relatively benign but does the heavy lifting on inputs/config that should be executed, and all the execution to configure Linux Pacemaker is done by Ansible Role ha_cluster (at the moment some is done from pcs PCMK Shell and other commands at the cib PCMK homogenous binaries level).
The Ansible Role sap_ha_pacemaker_cluster really does 2 things only:

Prepare input variables for Ansible Role ha_cluster is executed
Prepare OS dependencies (i.e. OS Packages for Fence/Resource Agents and CLIs) required for SAP and the chosen target Infrastructure Platform

The 'private' var (prefix __) referenced __sap_ha_pacemaker_cluster_resource_primitives, is generated on-the-fly based upon an end-user request to configure different SAP Software scenarios (SAP HANA, SAP NetWeaver ABAP ASCS/ERS etc), and a given target Infrastructure Platform (e.g. AWS, GCP, MS AZ, IBM Cloud, IBM PowerVC etc etc).
So the same applies.... if an end-user:

does not change variables for sap_ha_pacemaker_cluster, then ha_cluster is executed and nothing changes (as @tomjelinek confirms)
accidentally alters variables for sap_ha_pacemaker_cluster, then ha_cluster is executed and the new config pushed.... which could be destructive (that would depend on exactly what vars were altered).

Thank you @sean-freeman  for lengthy explanation even though I managed to get to explanations in meantime.
@tomjelinek @sean-freeman  I was asking about destructiveness and idempotence mainly because whole cib creation sequence is using pcs working on temporary configuration xml, leaving whole cluster intact. This is not possible with SUSE crm unless you start doing some extensive jinja2 changes without running crm configure
But end is most likely same, because even crm_diff at end of cib build considers all changes as changes and pushes them as patch.

Yes @sean-freeman , My comment was mainly about -f to do changes in xml separate from live cluster cib.

@marcelmamula Isn't 'Shadow CRB usage' the equivalent ?

@sean-freeman You are correct, shadow cib is possible, but it is limited to interactive crm configure mode, because you have to do all changes before commit. I tried using it on command line as ansible would, but shadow was not kept after commands.

@tomjelinek I have started going through Contribution documentation and I have hit snag with tox availability on SUSE. Would it be fine with doing linting check and leave rest of tests for git actions when PR is submitted?
Also ha_cluster is not using FQDN module names so all new tasks I added contain them to avoid linting errors. Are you planning to switch to FQDN roles in future?

@marcelmamula As long as your code passes CI eventually, it doesn't really matter to me whether you test locally or use git actions in a PR.
I think that not using FQDN names in a role for its own modules is a system roles convention.
@richm Could you comment on these two questions?

@tomjelinek Thank you.
My FQDN question was mainly about usual ansible.builtin modules that are triggering warning.

@sean-freeman

Perhaps "Feature Request: ha_cluster_config_change_then_halt" would protect an end-user in case of config drift / the variables changed by accident (for whatever reason), and the end-user performs re-run but does not want to replace the working config. By default I imagine such a variable would be false, to preserve the "psuedo-idempotence" and not create a breaking change.
In case such a feature exists already and I cannot see it, please excuse me and please correct me.

This looks like Ansible check mode to me. The ha_cluster role supports check mode, even though some tasks are impossible to be done in check mode. You also need to know a bit about how the role works, that it builds configuration in temp files and then pushes it to cluster / nodes.

@marcelmamula Sorry for being late to the pcs -f / crm -c discussion. Does the crm -c approach work for you?
I don't think you need to strictly follow pcs at all costs. Some parts of the role are very pcs specific, e.g. pcsd configuration. There was no demand for crmsh support when the role got started, so it wasn't designed with crmsh in mind.

I have tested out multiple approaches and settled down with crm -c and crm_diff on cib vs shadow. It seems to be working good including rc == 1 check.
Example for cib group:
ansible.builtin.command:
    cmd: |
      crm -c {{ __ha_cluster_crm_shadow }} configure group
      {{ resource_group.id | quote }} {% for resource in resource_group.resource_ids %}
      {{ resource | quote }} {% endfor %} \
      {% if resource_group.meta_attrs[0].attrs | default(False) %}
        meta {% for attr in resource_group.meta_attrs[0].attrs -%}
          {{ attr.name | quote }}={{ attr.value | quote }} {% endfor %}
      {% endif %}

There are some pcs specific like tickets, sets and others so I will leave them as empty placeholders for now or remove completely wherever possible.

@tomjelinek I have started going through Contribution documentation and I have hit snag with tox availability on SUSE.

you can't install python pip, then do pip install --user tox, on SUSE?

Would it be fine with doing linting check and leave rest of tests for git actions when PR is submitted?

Yes, I suppose so, but it will be painful to debug, if you find some odd issue, and have to iterate repeatedly by pushing new code to a PR, and cannot reproduce the error locally.

Also ha_cluster is not using FQDN module names so all new tasks I added contain them to avoid linting errors. Are you planning to switch to FQDN roles in future?

In general, you can use the short name for Ansible built-in modules/plugins, and use the FQCN for non-built-in modules/plugins.  The Ansible team have told me that short names for built-ins will be supported for the foreseeable future.  If/when Ansible changes to require the use of FQCN for everything, we will have tooling to automatically convert everything, because we will have to do that for the other 29 system roles at the same time.

@tomjelinek Thank you. My FQDN question was mainly about usual ansible.builtin modules that are triggering warning.

That should not be happening with ansible-lint because we suppress that warning - https://github.com/linux-system-roles/ha_cluster/blob/main/.ansible-lint#L16
What is the message you are seeing? Is it from ansible-lint?

@richm @tomjelinek
FQDN:
It seems my lint config was inherited from top folder, which does not have fqcn-builtins. Do you have any issue with me keeping all new files with fqdn?
Tox/Testing:
pip3 tox can be installed fine, issue starts with Use yum or dnf to install standard-test-roles-inventory-qemu since this is in fedora repo only. That package seems to be requirement to actually test using tox.

@richm @tomjelinek FQDN: It seems my lint config was inherited from top folder,

Not sure what you mean by that.

which does not have fqcn-builtins. Do you have any issue with me keeping all new files with fqdn?

Yes, you can use ansible.builtin.xxx instead of xxx.  That should not cause any issues.

Tox/Testing: pip3 tox can be installed fine, issue starts with Use yum or dnf to install  since this is in fedora repo only. That package seems to be requirement to actually test using tox.

It is a requirement to use qemu.  But it is possible to install the qemu and kvm and seabios packages separately.  So if you want to be able to run
tox -e qemu-ansible-core-2.16 -- --image-file /path/to/suse.qcow2 tests/tests_crmsh.yml

then you will need to install the qemu, kvm, seabios, whatever other packages you need to run qcow2 based VMs on your development platform.
You do not need standard-test-roles-inventory-qemu in order to run tox -e collection,ansible-lint-collection

Thank you @sean-freeman @richm @tomjelinek for https://github.com/linux-system-roles/ha_cluster/pull/186.
I will close this issue and further changes will go separately from this original issue.


error running build tasks

**I'm submitting a  bug report. I try to run any of build goals and at the end i get errors.
For example for build:universal-prod and build:spa-prod i have faced the below error  :
...
[09:17:59] Starting 'build:universal-prod'...
[09:17:59] Starting 'bundle:universal-browser-prod'...
(node:15988) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead
(node:15988) DeprecationWarning: Tapable.apply is deprecated. Call apply on the plugin directly instead
[09:18:04] 'bundle:universal-browser-prod' errored after 4.94 s
[09:18:04] TypeError: Cannot read property 'outputOptions' of undefine
...

for build:universal-dev i have faced the below error:
Error: ./src/server/server.ts
Module build failed: Error: Angular Compiler was detected but it was an instance of the wrong class.
This likely means you have several @ngtools/webpack packages installed. You can check this with `npm ls @ngtools/webpack`, and then remove the extra copies.
    at Object.ngcLoader (J:\Java\speed-samaneh\exhibition\front\node_modules\@ngtools\webpack\src\packages\ngtools\webpack\src\loader.ts:39:11)

    (1) error(s) total.

[* ] Bug report

For Tooling issues:

Node version: v8.9.4
Platform: Windows

Any idea about these errors?

@hadirsa just run both command just after a successful execution of yarn.
Which tool did you use to install the deps? NPM or YARN?

@fulls1z3, i use yarn,  also i tried to install deps with npm and i got the same error.
I tried to run build:* with yarn and npm and only build:spa-dev works fine.
I run these goals right after yarn or npm install, am i doing wrong?

@hadirsa it's best to clone a fresh version from the repository and just execute these commands (as i've succeeded here):

git clone https://github.com/ng-seed/universal
yarn
npm run build:universal-dev
or
npm run build:universal-prod

@fulls1z3 , i did as you said but the errors are the same as i said before but with npm install every thing works fine. Is there any issue with yarn? Didn't you face any issues with yarn?

@hadirsa actually I just had time to review issues, and i had some other issues with yarn. As a result, I deleted it totally and installed a new version. Now, things are more or less fine.


[Docs] order: update the description of the pathGroupsExcludedImportTypes option

Motivation: #2156

#1665 I read this issue and knowing why we had this PR, but I think they use pathGroupsExcludedImportTypes in the wrong way. If we need to let pathGroup works, sometimes we have to add pathGroupsExcludedImportTypes as [].

@Mairu @Akiq2016 @yola-0316 PTAL.

Sorry, I missed this PR when it was opened, but yes the changes are correct and the current documentation is wrong. Using patterns as excluded types works accidentally because the default types are removed.

it's very unfortunate that the fork was deleted, making this PR unrecoverable, so now we need #3036 as a duplicate :-/
please never delete a fork that has open PRs.


Consider expected behavior after a user loads new layers after an analysis

What should we display when a user has run an analysis or an exposure analysis and then they begin to activate other layers. Should we keep results displayed or toggle them off? If we toggle them off, we should implement a quick way to retrieve the results without having to execute the analysis again.

From a user perspective when you "Run Analysis" there is a need to compare the analysis layer with other layer that is why I think there is value to leave the analysis layer active. On the other end. We need to keep the application behavior consistent. As of now in PRISM we can only have one admin_level_data layer active. The question I have here do we qualify any analysis layer as admin_level_data? Or we treat analysis layer as its own type.
If 'Analysislayer is its own type then they should remain present when anotheradmin_level_datalayer is activated and the opposite is true if we consideranalysislayer similar or equal toadmin_level_data`

This was resolved when we added results as a new layer https://github.com/WFP-VAM/prism-app/pull/819


Re-factor Examples to use the Executor API?

Why don't the simpler examples:

Classifier
-VAE Text
-Seq2Seq+Attention

utilize the Executor API for training instead of the main() function and for-loops? There exists executor calls for the transformers.
Does the executor not work for these applications?

Thank you for your interest in Texar-PyTorch! The vae_text, seq2seq_attn, and sentence_classifier examples are definitely possible to implement with the Executor APIs. However, since Texar aims to be versatile and general purpose framework, we believe that it's also beneficial to demonstrate how to implement models using the usual training loops. This is also why we have several different versions of training scripts for examples like bert.
That said, if you're willing to contribute, you're more than welcome to create a pull request add your implementation of examples using the Executor API!


Switch from Travis to GitHub Actions

Thought I would try a quick lift and shift from Travis to GitHub Actions.
I've reproduced exactly the Travis config in GitHub Actions config, however there's a bunch of scope for replacing some of the CI scripts with Actions from the Marketplace. Conda setup, for example, is done like this in the distributed Windows CI.

Ended up using the Conda setup action to get things to pass. The script wasn't working for some reason.
Build is now successful. https://github.com/jacobtomlinson/dask-jobqueue/actions/runs/116941234
I think checks only report here once merged.

Github limits free use of actions to 2,000 minutes / month / org. Is this something that could become problematic?

My understanding is that PRs count against the user's limit, not the orgs. So we only need to worry about minutes spent testing master. But that is still something to bear in mind.
I think it is also possible for Dask to fund things like this is it brings enough benefit to the community. And in my opinion better and fast CI, leads to a better contribution experience, leads to more contributions is a benefit to us. To buy another 2,000 minutes is only $16. But perhaps @mrocklin could weigh in here?

Github limits free use of actions to 2,000 minutes / month / org. Is this something that could become problematic?

From this:

GitHub Actions usage is free for public repositories. For private repositories, each GitHub account receives a certain amount of free minutes and storage, depending on the product used with the account.

so if I understand things correctly the 2000 minutes / month / org is only for private repositories, right?

GitHub Actions usage is free for public repositories.

Jumped right to the table.  Thanks for point this out!

OK I am going to merge this one, I have no informed opinion on whether Travis or Github Actions is significantly better so I am going to fully trust @jacobtomlinson on this one. Thanks a lot for the PR!

It looks like the Github Actions CI is running on master as Jacob said: https://github.com/dask/dask-jobqueue/actions/runs/122951522


time-vary growth discrepancy

In the 1st year with time-vary growth parameters, the design is that those new growth parameters will affect in-season growth for that year and growth to the start of the next year.
However, examination of model output indicates that for the first age after Amin, the size at that age is affected already at the beginning of the year with the time-vary parameters.
In a limited test, if Amin = 1 (or presumably 1 .0 or higher), the calculations work correctly.
But if Amin = 0.0 or 0.01, the first age after Amin is getting updated with the current year's growth parameters.

Initial finding is that the lack of synchrony in updating growth at the correct time step was introduced when density-dependent parameter option was worked on.  At that time, it was found necessary to create wt_at_age before the time-vary parameter call was made.  This used the length-at-age which already had been projected to the beginning of the relevant year using the previous year's growth parameters.  Then to calculate wt_at_age, it was necessary to call Make_AgeLength_Key.  ALK relies on a flag (nseas*Nsubseas) to know which ALKs need updating that year.
The problem was that this new call to Make_AgeLength_Key turned off that flag.  So, later in that year loop after the growth parameters may have been updated, the flag was off.
The flag works like below
ALK_idx=(s-1)*N_subseas+subseas;
if(ALK_subseas_update(ALK_idx)==1) //  so need to calculate
{
ALK_subseas_update(ALK_idx)=0;  //  reset to 0 to indicate update has been done
So, since for density-dependence we only need season 1 subseas 1 updating, add this in top of the year loop in function: get_time_series in SS_popdyn.tpl
      ALK_subseas_update(1)=1;  // do 1st subseas of 1st season;  ADD THIS LINE for 3.30.17

All other subseasons are within the year, so do not get ALK calculation until after growth is updated with any time-varying growth parameters.
Still hunting down a fringe issue before I submit this for full testing.
Rick

This is now resolved, after two days of sleuthing.  A modification of simple's control.ss with time blocks for growth was create to aid in the testing.  Several anomalies were found in the order in which ss_popdyn was calling get_growth2() and get_growth3().  Most of the problem was due to lack of calls to growth3 following up on growth2 and prior to calling Make_AgeLength_KeyKey().  This then interacted with how the linear portion of growth below Amin was updated.  I will commit this testing branch soon.

I tested with a time varying growth model and  I see no difference at all between MEAN_BODY_WT(Begin) report:48 and MEAN_SIZE_TIMESERIES report:49 between 3.30.16 and the issue#154_smrybio branch or between the current main branch and issue#154_smrybio branch. Perhaps this is good, but it is confusing why this time varying growth discrepancy is not showing up? Unless the issue was observed as a result of work on a different branch, perhaps https://github.com/nmfs-stock-synthesis/stock-synthesis/tree/natmort-maturity?

I observed the issue while working on the fix for the smrybio branch.  Perhaps the problem was created and subsequently solved all while working within the smrybio branch.
My suggestion for a code review of growth module stands as it still seems to me that some configurations may still create anomalies especially as time-vary growth transitions from the young fish linear growth phase to the growth curve.


feat(automation): add GH release updates

the github action has comments to explain what is going on
Dockerfile was changed to make verifying what changed in the release easier
sorted github releases in dockerfile
added a short explanation on each binary we add
runs on a daily cronjob

closes https://github.com/openshift/ocm-container/pull/92

Not a big deal, but var names TOOL_SHORT_URL could be renamed as TOOL_URL_SLUG

done @T0MASD

if this is not acceptable, I'll add this repo to openshift/release and put the script there. I started checking how to add the credentials

Ok, so I'll close the PR and make another with changes that will make it easier for me later

@rafael-azevedo
See PR https://github.com/georgettica/ocm-container/pull/76


[BUG] Create icon not working

🔵 Describe the bug:
The "create icon" function show correctly the question mark in gse, but it stays as the first spell in the macro panel and in the toolbar. I actually succeeded to make the icon be question mark by opening the macro panel and gse panel, delete and recreate icon in gse, switch the macro panel to general and then character macro again, but it switch back at the "broken" one at the first reload. This is not letting me see the spell i'm casting while in combat but i can only see the first spell of the macro.
🔵 To reproduce: (Steps to reproduce the behavior)

Go to gse, select a macro
Click on delete icon
Click on create icon
Open macro panel
See the macro with the uncorrect icon
Reopen GSE and the macro have the uncorrect icon instead of the question mark icon

🔵 The error:
No error detected in BugSack
🔵 Screenshots:

after reload:

🔵 Expected behavior:
Icon should remain question mark in macro panel and on the toolbar should change with the current spell while in combat.
🔵 GSE.lua file:
GSE.lua.txt
🔵 Desktop (please complete the following information):

OS: Windows 10 pro 64bit
Game Version: retail <IP_ADDRESS>000

🔵 GSE Version:

Version: 3.0.45 (not alpha)
Downloaded From: CourseForge client

🔵 Additional context:
I actually have this problem since i switched to GSE3, didn't have that problem with previous version. The only macros i have in my screen with the right icon are macros that were compiled with gse2 and i didn't open and save in gse3. Some macros with the issue are macros i used in gse2 and saved in gse3 after the switch (MARV'SBM, ST_-_BM_RAIDING), others are macros i imported from wowlazymacros 2 weeks ago (EA_BMH_AOE and EA_BMH_ST) and they all have the same issue.
I tried even without opening the macro panel and drag directly the icon from gse panel to toolbar, but it still resets at the reload.

Mate this really depends on the content of your macro.
for example - If your macro has a bunch of castsequences it will do … something but it won’t often update the icon due to some WoW limitations.  Opening and closing the macro from GSE2 to GSE3 won’t make a difference as the macro has already been converted to GSE 3.
moving this to a discussion as it’s actually not a bug but The result of what is in your macro.


container_spec_memory_limit_bytes value 0 is sent for no limit pods/containers

Proposal
**container_spec_memory_limit_bytes value is set to 0 for no limit pods or containers. Why is this important?,
**
“Nice to have” is not a good use case. :)
Bug Report
** we are calculating memory utilization using  (sum(container_spec_memory_limit_bytes{container!="POD",container!=""
}) by ( namespace, pod) !=0 > bool 1) * 100 * (sum(container_memory_usage_bytes{container!="POD",container!=""}) by ( namespace, pod)/sum(container_spec_memory_limit_bytes{container!="POD",container!=""}) by ( namespace, pod)) this query  so for some pods/containers for which limit is not there for example prometheus-k8s-0 container_spec_memory_limit_bytes is set as 0 and the total memory utilization is more the 1000 always, **
**What did you expect to see?
By running docker stats I can see that container_spec_memory_limit_bytes is set to remaining avilable memory of the node, so if there is no limit please set this to avilable memory of the node or something in sync with docker stats
**
container_spec_memory_limit_bytes is set to zero 0 when limit is not there on container
Kubernetes latest

System information:
insert output of uname -srm here

Prometheus version:
insert output of latest here

Alertmanager version:
insert output of latest here (if relevant to the issue)

Prometheus configuration file:

insert configuration here

Alertmanager configuration file:

insert configuration here (if relevant to the issue)

Logs:

insert Prometheus and Alertmanager logs relevant to the issue here

Thanks for your report. It looks as if this is actually a question about usage and not development.
To make your question, and all replies, easier to find, we suggest you move this over to our user mailing list, which you can also search. If you prefer more interactive help, join or our IRC channel, #prometheus on irc.freenode.net. Please be aware that our IRC channel has no logs, is not searchable, and that people might not answer quickly if they are busy or asleep. If in doubt, you should choose the mailing list.
Once your questions have been answered, please add a short line pointing to relevant replies in case anyone stumbles here via a search engine in the future.


Fix false positive with lambda argument and call chain (indent)

Description

Fixes #1202
Checklist

[x] tests are added
[x] CHANGELOG.md is updated

@t-kameyama Any chance we can get a release for this?
Thanks.


operator [N] [CI] postgres-operator-krestomatio (0.3.7)

Thanks submitting your Operator. Please check below list before you create your Pull Request.
New Submissions

[x] Are you familiar with our contribution guidelines?
[x] Have you packaged and deployed your Operator for Operator Framework?

[ ] Have you tested your Operator in all supported installation modes?

[x] Is your submission signed?
[x] Is operator icon set?

Updates to existing Operators

[x] Did you create a ci.yaml file according to the update instructions?
[ ] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[ ] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[ ] Have you tested an update to your Operator when deployed via OLM?
[ ] Is your submission signed?

Your submission should not

[x] Modify more than one operator
[x] Modify an Operator you don't own
[x] Rename an operator - please remove and add with a different name instead
[x] Modify any files outside the above mentioned folders
[x] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[ ] Description about the managed Application and where to find more information
[x] Features and capabilities of your Operator and how to use it
[ ] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[x] Human readable name and 1-liner description about your Operator
[x] Valid category name1
[x] One of the pre-defined capability levels2
[x] Links to the maintainer, source code and documentation
[x] Example templates for all Custom Resource Definitions intended to be used
[x] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

/hold cancel

/merge possible

/merge possible

/merge possible


Cant download Release Files

Cant download Release Files just errors. Nothing on my end. Only reason i was going to use KeePass. Now it Defeats the point.

Can you be more explicit? What release files are you referring to?

https://github.com/JanisEst/KeePassBrowserImporter/releases/tag/v1.0.9
Download works fine.


Include @babel/plugin-transform-runtime by default

Hi,
First, thanks for a great tool – a lifesaver!
But I've encountered the not so uncommon Uncaught ReferenceError: regeneratorRuntime is not defined-error while writing async/await code.
It's not a big issue in itself – I was able to solve it with a custom babel.config.js according to your instructions (though  jsBabelPresetOptions and jsBabelOverride doesn't seem to be applied, but that's probably a separate issue).
I've made a repo reconstructing my issue and solution here (in that repo you can also see that jsBabelPresetOptions and jsBabelOverride doesn't get applied).
I just needed to add @babel/plugin-transform-runtime to the list of plugins and the problem was solved.
Therefore this is not as much an issue as it is a question – what do you think about adding @babel/plugin-transform-runtime to @wpackio/babel-preset-base by default?
My suggestion is to use something similar to what create-react-app is doing in their preset.
I would be happy to support with a PR if you're interested, even though I'll have to get acquainted with the code first 😄.

Hello,
First of all thank you for giving the feedback and investigating on this issue. When I was working on the last release, the transform-runtime did came to my mind. But I had another pressing issue at hand (improving typescript typecheck performance), so I didn't look much into it.
So I am super glad that you brought this up and yes, please send me a PR with the changes you think would be useful (i.e, adding @babel/plugin-transform-runtime and @babel/runtime to @wpackio/babel-preset-base.)
Also
It's not a big issue in itself – I was able to solve it with a custom babel.config.js according to your instructions (though jsBabelPresetOptions and jsBabelOverride doesn't seem to be applied, but that's probably a separate issue).
I've made a repo reconstructing my issue and solution here (in that repo you can also see that jsBabelPresetOptions and jsBabelOverride doesn't get applied).
Maybe the doc is a bit misleading, but when you use your own babel config, then the system completely bypasses all js and ts related babel configuration.

Also can you please confirm that if this works?
const pkg = require('./package.json');

module.exports = {
  // ...
  // Keep babel config to false, turn it on if you want the system to
  // catch babel.config.js for overall replacement
  useBabelConfig: false,
  // The below is meant to be passed as options for @wpackio/babel-preset-base
  // so obviously it won't work
  jsBabelPresetOptions: {
    plugins: ['@babel/plugin-transform-runtime'],
  },
  // This should work now
  jsBabelOverride: defaults => {
    return { ...defaults, plugins: ['@babel/plugin-transform-runtime'] };
  },
  // ...
};

I'll be happy to look into a PR to add the runtime plugin! I'll probably get something going later this week (a holiday is coming up here in Sweden 😄).
Regarding

Also can you please confirm that if this works?
const pkg = require('./package.json');

module.exports = {
  // ...
  // Keep babel config to false, turn it on if you want the system to
  // catch babel.config.js for overall replacement
  useBabelConfig: false,
  // The below is meant to be passed as options for @wpackio/babel-preset-base
  // so obviously it won't work
  jsBabelPresetOptions: {
    plugins: ['@babel/plugin-transform-runtime'],
  },
  // This should work now
  jsBabelOverride: defaults => {
    return { ...defaults, plugins: ['@babel/plugin-transform-runtime'] };
  },
  // ...
};

The docs ain't fuzzy on that point, I have tried with useBabelConfig: false as well.
But the strange thing is that I can't get that to work either. I've tried with useBabelConfig: false and all possible combinations of jsBabelPresetOptions and jsBabelOverride. As you can see in my repro I've even thrown in an Error, but it doesn't throw 🤔 even with useBabelConfig: false.
I'm not really acquainted with where the config gets defined, but I might look into that one as well later! It's not a stressing issue since the custom babel.config.js works fine.

As you can see in my repro I've even thrown in an Error, but it doesn't throw 🤔 even with useBabelConfig: false.

Then it is indeed an error. I have some pressing work at my disposal, so maybe we can come back at it after a week or so.

As you might have noticed I've provided a PR (#483) to add the runtime plugin.
But I just want to mention that the issue with the babel overrides not being applied is probably solved – I found out that it was an "issue" with caching...
I didn't change the source code between build scripts and therefore babel didn't bother to process that file again. Once I changed the source the overrides were applied.
So no need to worry about that anymore 😄

Hey @adambrgmn, thanks for the PR. I have merged and published in version 3.4. Also glad to know that there isn't an issue with the babel config options 👍.
You did a wonderful job on the PR. Do let me know if you'd like to be a collaborator in this repo 😃

Looks like there is a regression.

We pass noRuntime with defaulting to false to nmJsRules (node_modules transpile).
It has default useESModules to true.
It fails for most of the npm packages, because those are CJS, not ESModules.

Hence it throws errors like
./src/app/admin/components/AppWrap/index.tsx
Attempted import error: '@rehooks/component-size' does not contain a default export (imported as'useComponentSize').
 @ ./src/app/admin/screens/index.tsx
 @ ./src/app/admin/index.tsx
 @ multi ./src/app/admin/index.tsx webpack-hot-middleware/client?path=__wpackio&name=admin&dynamicPublicPath=true&overlay=true&reload=true&overlayStyles=%7B%22zIndex%22%3A999999999%2C%22fontSize%22%3A%2214px%22%2C%22fontFamily%22%3A%22Dank%20Mono%2C%20Operator%20Mono%20SSm%2C%20Operator%20Mono%2C%20Menlo%2C%20Consolas%2C%20monospace%22%2C%22padding%22%3A%2232px%2016px%22%7D

Possible solutions

Pass noRuntime as true for nmJsRules.
Maybe use useESModules as false for nmJsRules.

@adambrgmn do you know what CRA is doing?

Also by looking at CRA source code, having useESModules always set to true will cause jest to fail. So I think we need a fallback here.

Looks like I got it to solve by adding sourceType: 'unambiguous' to babel config of nmJsRules per this comment

Hopefully release 3.5.0 resolves this.


fix(table): table-misaligned when frozen columns

PR
PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our Commit Message Guidelines
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #129
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@all-contributors please add @awspi for code


allow for monthly "last day of month" rules to be created

-1 is an acceptable value for monthly rrules, according to the docs.  This allows you to create rules that trigger on the last day of every month.
^ To generate a rrule for the use case of "a date on the specified day of the month, unless it is beyond the end of month, in which case it will be the last day of the month" use the following:
'''
rrule(MONTHLY, bymonthday=(some_day, -1), bysetpos=1)
'''

I'm not sure about the approach here - I think we'd be better off just explicitly allowing -1 in the bymonthday checks, rather than adding a parameter to validate_iterable_ints. Would you mind modifying that? If not, I'll try to get a change (plus tests) in for this.

Closing old request.


Remove throws clause from MockMaker constructor

This makes using the MockMaker by framework integrators a lot easier.
Internally catch any potential exceptions and rethrow with an
IllegalStateException like the other cases in this constructor
This removes the exception clause that was originally introduced in #111

Looks fine to me


Authorization again

Why I have to authorize my app to use the twitter account when I login? I want to replicate the Facebook plugin behavior; after I accept to login with twitter, then I only press on login with twitter button and the app login using my twitter account without asking me again.
Is that possible?
I'm using Angular 2 + Ionic 2 + Firebase 3,
this is my code and it works fine, but it ask for authorization every time I login:
 signInWithTwitter() {
    if (this.platform.is('cordova')) {
      TwitterConnect.login().then((result) => {

        let credentials = (firebase.auth.TwitterAuthProvider as any).credential(result.token, result.secret)

        let providerConfig = {
          provider: AuthProviders.Twitter,
          method: AuthMethods.OAuthToken,
          remember: 'default',
          scope: ['email'],
        };

        this.af.auth.login(credentials, providerConfig).then((authData) => {
          this.nav.push(TabsPage, { af: this.af, uid: authData.uid });
        }).catch((error) => {
          alert(error);
        });
      }).catch((e) => {
        alert(e);
      });
    }
  }

That's just the way Twitter's library works. It's actually the exact
opposite behavior on iOS then on Android.
On Sep 5, 2016 9:29 PM, "Alejandro"<EMAIL_ADDRESS>wrote:

Why I have to authorize my app to use the twitter account when I login? I
want to replicate the Facebook plugin behavior; after I accept to login
with twitter, then I only press on login with twitter button and the app
login using my twitter account without asking me again.
Is that possible?
I'm using Angular 2 + Ionic 2 + Firebase 3,
this is my code and it works fine, but it ask for authorization every time
I login:
signInWithTwitter() {
if (this.platform.is('cordova')) {
TwitterConnect.login().then((result) => {
    let credentials = (firebase.auth.TwitterAuthProvider as any).credential(result.token, result.secret)

    let providerConfig = {
      provider: AuthProviders.Twitter,
      method: AuthMethods.OAuthToken,
      remember: 'default',
      scope: ['email'],
    };

    this.af.auth.login(credentials, providerConfig).then((authData) => {
      this.nav.push(TabsPage, { af: this.af, uid: authData.uid });
    }).catch((error) => {
      alert(error);
    });
  }).catch((e) => {
    alert(e);
  });
}

}
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ManifestWebDesign/twitter-connect-plugin/issues/33,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAiMuJdoha00VawGPKtSZO4IDvUabvUTks5qnOwugaJpZM4J1c8k
.

So, it is not a way to know if the user already sign in with twitter to prevent the user to accept again the permission?
I only try with android, as yoy say with iOS i will not need to do it, that's right?

Unfortunately that's correct. They'll have to authorize every time.
On Sep 7, 2016 8:27 PM, "Alejandro"<EMAIL_ADDRESS>wrote:

So, it is not a way to know if the user already sign in with twitter to
prevent the user to accept again the permission?
I only try with android, as yoy say with iOS i will not need to do it,
that's right?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ManifestWebDesign/twitter-connect-plugin/issues/33#issuecomment-245483676,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAiMuAV3ejQiGeLqRnn71bvPY8iz-Lf2ks5qn4CcgaJpZM4J1c8k
.

@alejandrocao How are you able to make your twitter connect/authentication work?
I'm also using the exact same code as yours but everytime I click login to Twitter, it says "Failed Login Session". I exactly followed the steps to install this one. I'm running this in a Android Simulator. Unlike Facebook, where I'm redirected to Facebook's Login Page after clicking "Login to Facebook", Twitter doesn't even redirect me to its Login Page but instead just shows "Failed Login Session"


Changelog for v0.3.0 is missing

When I update from v0.2.0 to v0.3.0 then my code does not work anymore. Hence my guess that breaking changes have been introduced but without seeing a changelog, I have reverted to v0.2.0 for now.
(And according to sem-versioning, I think it should have been version 3.0 instead. Because there are breaking changes.)

@binarykitchen:

Major version zero (0.y.z) is for initial development. Anything may change at any time. The public API should not be considered stable.

source
+1 to changelog though :D

Thank you for pointing this out. We will add changelog for 0.3.0 soon.

@cesarandreu re: initial development vs versioning, i disagree, based on this comment https://github.com/dominictarr/semver-ftw/issues/2#issuecomment-13874220
firstly, we already use this fixed-data-table package in production, so it's not just an experiment. it's already serious. secondly, anytime you introduce breaking changes, the major version shall be incremented, no matter what. this to reflect the breakage.

@binarykitchen a changelog for version v0.3.0 has been added - most notably, support for React 0.12 has been discontinued.
You can find it here: https://github.com/facebook/fixed-data-table/releases

thx, looking good


Display preselected values

Is there any way to display preselected value in v-tree

you can set node init property, document


Document how to use regtest

One can setup a regtest wallet, but docs for how to actually get coins into the wallet, generate blocks etc would be very helpul.
I assume bitcoin-cli is needed, but that does not seem to be automatically downloaded alongside bitcoind. That would be helpful as well.

note: i wrote this tool to control a regtest:
https://github.com/pythcoiner/Minta

related to #1159