Update URL of ISO 29500 to use the latest ISO 29500 standard

The current URL of ISO 29500 is quite obsolete: http://go.microsoft.com/fwlink/?LinkId=194337
That URL will redirect to ISO/IEC 29500-1:2008 page. Usually, an ISO spec always get refreshed for 4 to 5 years, this means the ISO standard is not the latest based on the current status of  ISO/IEC 29500-1:2008.
Screenshot:

The latest ISO 29500 standard is now 29500-1:2016 for part 1. This PR updates the link to point to 2016 standard: https://www.iso.org/standard/71691.html
Screenshot:

Currently, the page said its state is "Now".

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: eriawan sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/how-to-accept-all-revisions-in-a-word-processing-document.md
:white_check_mark:Succeeded

docs/how-to-add-a-comment-to-a-slide-in-a-presentation.md
:white_check_mark:Succeeded

docs/how-to-add-a-new-document-part-that-receives-a-relationship-id-to-a-package.md
:white_check_mark:Succeeded

docs/how-to-add-a-new-document-part-to-a-package.md
:white_check_mark:Succeeded

docs/how-to-apply-a-style-to-a-paragraph-in-a-word-processing-document.md
:white_check_mark:Succeeded

docs/how-to-apply-a-theme-to-a-presentation.md
:white_check_mark:Succeeded

docs/how-to-calculate-the-sum-of-a-range-of-cells-in-a-spreadsheet-document.md
:white_check_mark:Succeeded

docs/how-to-change-the-fill-color-of-a-shape-in-a-presentation.md
:white_check_mark:Succeeded

docs/how-to-copy-the-contents-of-an-open-xml-package-part-to-a-document-part-in-a-dif.md
:white_check_mark:Succeeded

docs/how-to-create-a-package.md
:white_check_mark:Succeeded

docs/how-to-create-a-spreadsheet-document-by-providing-a-file-name.md
:white_check_mark:Succeeded

docs/how-to-create-a-word-processing-document-by-providing-a-file-name.md
:white_check_mark:Succeeded

docs/how-to-create-and-add-a-character-style-to-a-word-processing-document.md
:white_check_mark:Succeeded

docs/how-to-create-and-add-a-paragraph-style-to-a-word-processing-document.md
:white_check_mark:Succeeded

docs/how-to-delete-a-slide-from-a-presentation.md
:white_check_mark:Succeeded

docs/how-to-delete-all-the-comments-by-an-author-from-all-the-slides-in-a-presentatio.md
:white_check_mark:Succeeded

docs/how-to-delete-text-from-a-cell-in-a-spreadsheet.md
:white_check_mark:Succeeded

docs/how-to-get-a-column-heading-in-a-spreadsheet.md
:white_check_mark:Succeeded

docs/how-to-get-all-the-external-hyperlinks-in-a-presentation.md
:white_check_mark:Succeeded

docs/how-to-get-all-the-text-in-a-slide-in-a-presentation.md
:white_check_mark:Succeeded

docs/how-to-get-all-the-text-in-all-slides-in-a-presentation.md
:white_check_mark:Succeeded

docs/how-to-get-the-contents-of-a-document-part-from-a-package.md
:white_check_mark:Succeeded

docs/how-to-get-the-titles-of-all-the-slides-in-a-presentation.md
:white_check_mark:Succeeded

docs/how-to-get-worksheet-information-from-a-package.md
:white_check_mark:Succeeded

docs/how-to-insert-a-chart-into-a-spreadsheet.md
:white_check_mark:Succeeded

docs/how-to-insert-a-new-slide-into-a-presentation.md
:white_check_mark:Succeeded

docs/how-to-insert-a-new-worksheet-into-a-spreadsheet.md
:white_check_mark:Succeeded

docs/how-to-insert-a-picture-into-a-word-processing-document.md
:white_check_mark:Succeeded

docs/how-to-insert-text-into-a-cell-in-a-spreadsheet.md
:white_check_mark:Succeeded

docs/how-to-merge-two-adjacent-cells-in-a-spreadsheet.md
:white_check_mark:Succeeded

docs/how-to-move-a-paragraph-from-one-presentation-to-another.md
:white_check_mark:Succeeded

docs/how-to-move-a-slide-to-a-new-position-in-a-presentation.md
:white_check_mark:Succeeded

docs/how-to-open-a-presentation-document-for-read-only-access.md
:white_check_mark:Succeeded

docs/how-to-open-a-spreadsheet-document-for-read-only-access.md
:white_check_mark:Succeeded

docs/how-to-open-a-spreadsheet-document-from-a-stream.md
:white_check_mark:Succeeded

docs/how-to-open-a-word-processing-document-for-read-only-access.md
:white_check_mark:Succeeded

docs/how-to-open-a-word-processing-document-from-a-stream.md
:white_check_mark:Succeeded

docs/how-to-open-and-add-text-to-a-word-processing-document.md
:white_check_mark:Succeeded

docs/how-to-remove-a-document-part-from-a-package.md
:white_check_mark:Succeeded

docs/how-to-remove-hidden-text-from-a-word-processing-document.md
:white_check_mark:Succeeded

docs/how-to-replace-the-header-in-a-word-processing-document.md
:white_check_mark:Succeeded

docs/how-to-replace-the-theme-part-in-a-word-processing-document.md
:white_check_mark:Succeeded

docs/how-to-retrieve-comments-from-a-word-processing-document.md
:white_check_mark:Succeeded

docs/how-to-search-and-replace-text-in-a-document-part.md
:white_check_mark:Succeeded

docs/how-to-set-the-font-for-a-text-run.md
:white_check_mark:Succeeded

docs/working-with-paragraphs.md
:white_check_mark:Succeeded

docs/working-with-runs.md
:white_check_mark:Succeeded

docs/working-with-wordprocessingml-tables.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@davidchesnut
Any update on review of my PR?
Do I have to do anything else? I hope this repo is active.

Guys, is this repo still active? It's been 5 days without any updates at all.
Please confirm the review of this PR of mine.
cc @davidchesnut


Adding Picard RnaSeqMetrics to Mapping Pipeline

While the RNASeqQC Pipeline provides a rough estimation of RNASeq biases, I thought it might be useful to implement the picard RNASeqQC metrics in the mapping pipeline, to give a more quantifiable/numerical assessment of biases that can then be used for downstream analysis. Please let me know if you support/object this addition, and I will start implementing it in a similar manner as other picard metrics are already handled.

Given this is specific to RNAseq I suspect it would be better to implement this properly in the RNAseq QC pipeline, rather than introduce a protocol/method specfic task in to the generic mapping pipeline.

I'd agree except that we're only mapping a subset of reads so the Picard metrics will be very inaccurate. The mapping pipeline already performs some tasks only when using a spliced aligner so it wouldn't make it any less generic.

I like that solution & it would does make sense to combine the picard tools in the already available MappingQC module. Making the function/method splice dependent might not cater for the few occasions where RNASeq is done on an unspliced genome? I'm open to both avenues.

I don't think the Picard tool is suitable when you have an unspoiled genome. Many of the stats relate to intronic read etc.

May I make a change to the pipeline_mapping pipeline.ini?
The Picard RNASeqMetrics function requires information on strandedness. It would make sense to add this to the general options. We also have three mappers in the pipeline that require strandedness (hisat and tophat 1/2).
I would remove the strandedness option from the tool-specific options and add it to the pipeline.ini general options and populate all tools that use it from there.
To it would make sense to have just one option for strandedness, and I would use the HISAT nomenclature for the pipeline.ini. i.e. "RF", "FR" for paired-end, "F" and "R" for single-end. Default: none.
I am open to other suggestions.

This seems like a good idea to me.
The user would optionally provide strandedness under the "general" section and the mappers would take the strandedness parameter and convert it to the correct strandedness option. Is that right?
Take care with the tool specific strandedness options. They sometimes seem a bit backwards!

They are indeed & I would appreciate someone checking the commit once it's ready.
I will put a also put a detailed explanation in the pipeline.ini.

Very happy to check (I'll need to re-read the relevant sections of the manuals again though!)

Sounds great, it might be good to include this link in the ini as a reference - as it's by far the best explanation of the different libraries that I've come across.
http://sailfish.readthedocs.org/en/master/library_type.html


Add D-Bus parser to README

I recently completed a parser for the D-Bus wire format using nom.
I added it to the README in case it's a useful reference to someone.

nice work!


Roll engine a4afd19a97e2..1baf08134353 (1 commits)

https://github.com/flutter/engine/compare/a4afd19a97e2...1baf08134353
git log a4afd19a97e2..1baf08134353 --no-merges --oneline
1baf08134 Roll src/third_party/skia a63cf8e80aa5..6bdfb6fba352 (1 commits) (flutter/engine#6911)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

@liyuqian : New roll has been created by https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Auto-roller completed checks. About to merge.


WordPress preset: set requireCamelCaseOrUpperCaseIdentifiers to ignoreProperties

In the WordPress preset, I think it makes sense to set requireCamelCaseOrUpperCaseIdentifiers to ignoreProperties, as many WP-internal properties used in AJAX calls are snake_case.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/27242154-wordpress-preset-set-requirecamelcaseoruppercaseidentifiers-to-ignoreproperties?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github).

Ok that sounds fine and we were about to release a new version anyway.
Also did you see https://github.com/jscs-dev/node-jscs/issues/1811?


upload files

Upload of macOS and Windows scripts and sensors to disable Office macros
Signed-off-by: Mathieu Beaugrand<EMAIL_ADDRESS>

Can this one be deleted? Contains PII in the commit message


Python codegen: big cleaning and paving the way towards transforms

What
Note: as usual, review commit-by-commit (the bulk of the changes are in the first commit). This time, reviewers might want to spend some time on the auto-generated code, though, as this is a major focus of this PR.
This PR has the following aims:

Enforce and exploit the decision that a component must be a struct of one, and exactly one, field, which may be a datatype (in which case the component is known as "delegating", as its implementation delegates to the datatype) or a native type (e.g. float, int, etc.).
Significantly polish the Python SDK, with the goal of a cleaner, fully typed user-facing API, and a streamlined implementation. Part of this is achieved using attrs (see below).
Improve the from_similar() hook and introduce several others. The proposed mechanisms consist of storing the so-called (hand-coded) overrides in the _overrides sub-packages in each of the archetypes, components, and datatypes packages. These overrides are discovered by the code generator by "parsing" (well, "brute-force extracting symbols" from) _overrides/__init__.py [1]. The following hooks are currently implemented:

xxx_native_to_pa_array() (where xxx is the lower-cased name of the corresponding object): this is the primary way to flexibly convert native input into the Arrow array form of the component.
xxx_yyy_converter (yyy is a field name): optional converter function a given field of a native objects (e.g. Color). This enables the object to flexibly accept native input for the given field.
xxx_as_array: optional __array__() magic function for native objects (e.g. Point2D). This function enable the object to be interpreted as array data by Numpy, which can considerably simplify the implementation of, e.g., xxx_native_to_pa_array (Point2D is a good example).

This PR also introduces the following changes:

So far, the archetypes and log_any() were pulled into the rr namespace. This PR now pulls all component- and datatype-related symbols in rr.cmp and rr.dt, respectively. This is intended as a temporary solution, to avoid name clashes with the legacy API [2].
The attrs dependency is introduced as it allows much more flexibility than the standard library dataclass, in particular with the converter feature which I use extensively. Introducing new deps is always a tough call. In the case of attrs, it's most probably safe as this is one of the most common and well maintained package of the ecosystem (110+M dl/month).
Native objects automatically get __str__(), __int__(), or __float__() functions when they contain a single field of the related type.
The Point2D component now delegate to a new Point2D datatype, defined as a struct of two floats. This is done such as to avoid breaking compatibility with the current viewer. The long-term goal is to use the Vec2D datatype instead.
The CI now uses Python 3.11 for linting (and linting only, i.e. not testing, etc.)

Addressing union types is a non-goal of this PR. This will be part of the next PR (transforms). As such QuotedObject::from_union() is most likely broken.
TODO/TBD:

PyCharm's typechecker isn't happy with the Archetype, with is irritating. This could apparently be addressed by using xxxArrayLike instead of xxxArray annotations for archetype's fields. I'm curious how VSCode fares, though.
Maybe passing None as args to the archetype should set None instead of empty arrays (they aren't logged either way).
Maybe the notion of delegating vs. non-delegating component should be promoted to the langauge-agnostic code?

[1] I actually prototyped and tested an approach based on PyO3. It sorta worked, until I tried to import stuff (Numpy, ...) for the overrides. The codegen would somehow be given access to a venv with the required deps, etc. Hell no.
[2] Name clashes also exist internally to the new API, e.g. components.Point2D vs. datatypes.Point2D. This will have to be addressed before we can pull "everything" into the rr namespace.
Checklist

[x] I have read and agree to Contributor Guide and the Code of Conduct
[x] I've included a screenshot or gif (if applicable)
[x] I have tested demo.rerun.io (if applicable)

PR Build Summary
Docs preview
Examples preview

Yeah my vim isn't too happy either... :(

Yeah my vim isn't too happy either... :(

The situation here is a bit weird typing-wise TBH (due to the args being extracted from the big arrays, etc.). How does it look in api_demo/main.py (whatever the new name is)?

Here's what I get for the roundtrip test:

Here's test_api:


fr_FR e164PhoneNumber provider

Updated fr_FR phoneNumber provider to make it compliant with fr_FR phone number scheme

Please see #1851


Use rustc-hash for deterministic hashing

In Meta, buck depends strongly on deterministic builds in order to generate correct output. Unfortunately, the default hash for std::collections::HashMap is not deterministic, and so it causes issues for us when depended on in proc-macros.
My fix here is to use rustc-hash which provides determinism while not changing to a different data structure like index map or tree map.

I don't think this is worth the additional dependency: Can we use BTreeMap instead?

I don't think this is worth the additional dependency: Can we use BTreeMap instead?

Done!


Fix testfolder name

Coverage decreased (-0.04%) to 82.095% when pulling 04261405db4aa5cdc210852e236c2d8f355552c3 on fix/testfolder into e242eca012f954c24660a378f794cfff7c8ae2b6 on main.


Collect better playback metrics from clients

We need to collect playback time as well as buffering events duration, among other things.
Watchman API spec

Frontend part

discussion recap:
cache doesn't have a clear / distinct value for HLS streams (m3u8 could be cached, segment files might not be for instance)
Rename format to protocol - better descriptor of data
Rename rate to bandwidth - rate is ambiguous, could refer to video playback rate, or viewer download rate for instance.
Will use existing schema definitions for now though

Fields have been renamed.

Are we still going to be using the other endpoint to track time to start? Or should that be brought in here with an initial call on playback start?

We'll probably combine it but I want to address one thing at a time.


/brapi/v1/maps/{mapDbId}/positions?linkageGroupId variable naming

In the response object: should the variable 'linkageGroup' rather be named 'linkageGroupId' to correspond to the naming in the call? Or should both be named: 'linkageGroupDbId' to be consistent with other id names?

Open Question: Are you teams using linkageGroupId to represent a linkageGroupDbId as in a reference to a record in a database, or are you using it more like a linkageGroupName as in a reference to a particular group in a chromosome? Should both DbId and Name be available to query on or returned in the results?
I've reached out to a handful of people privately to see if I can get a consistent answer.

My understanding was that all ¨-DbId¨were referring to a record in a database, while ¨-Name¨ would refer to a convenience name of a linkage group.

Yup @c5sire that is my understanding as well. Everyone I have talked to has agreed that the linkageGroupId parameter was assumed to mean linkageGroupName, or more specifically a chromosome number or subsection. It is NOT used as a database primary key.
For now, for version 1.1, we will change the name “linkageGroupId” to “linkageGroupName” and add a description in the documentation to clarify it as convenience genomic data instead of database key.
If anyone actually needs to track a "linkageGroupDbId" and can show me a good use case for it, we can add it later.


Prepare for multiple viewers

Now there is a single node and a single url that shows the ui of that node.
The want to have multiple nodes, each have it's own url.
The urls will be relative to the index.html, eg /LigandsAndProteinsViewer .
This means that Jetty should return the contents of index.html when a url is not found as static file or some rest resource.
See http://stackoverflow.com/questions/34245969/jetty-custom-error-pages-when-running-as-embedded-server for solution.

See https://github.com/ReactTraining/react-router/blob/master/docs/guides/Histories.md#configuring-your-server


Fix building error at backtrace

I get this error when builind backtrace:
error[E0308]: mismatched types
--> /folk/prj-rust-dev/bpang/ala-diab-pb19l/fix_bugs/latest/.cargo/git/checkouts/backtrace-rs-fb1f822361417489/e745627/src/symboli
ze/dladdr.rs:38:73
|
38 |                         Some(SymbolName::new(slice::from_raw_parts(ptr, len)))
|                                                                         ^^^ expected usize, found u64
help: you can convert an u64 to usize and panic if the converted value wouldn't fit
It shows the 'size_t' is expected to be defined as "usize".

r? @gnzlbg
(rust_highfive has picked a reviewer for you, use r? to override)

r? @gnzlbg

There is no libc function in that error message.

Depending on how the things are defined in the C header, this line might have a bug:

https://github.com/rust-lang/backtrace-rs/blob/master/src/symbolize/dladdr.rs#L38

Instead of len, it should be len as _.

There is no libc function in that error message.

Sorry, I should paste more code:
             unsafe {
                    let len = libc::strlen(self.inner.dli_sname);
                    Some(SymbolName::new(slice::from_raw_parts(ptr, len)))
                }

Depending on how the things are defined in the C header, this line might have a bug:

https://github.com/rust-lang/backtrace-rs/blob/master/src/symbolize/dladdr.rs#L38

Instead of len, it might need to be len as _. Hard to tell without seeing the headers.

I see the size_t is defined as usize almost for every targets:
$ grep "pub type size_t" * -rn
cloudabi/mod.rs:14:pub type size_t = usize;
fuchsia/mod.rs:23:pub type size_t = usize;
hermit/mod.rs:29:pub type size_t = usize;
sgx.rs:16:pub type size_t = usize;
switch.rs:16:pub type size_t = usize;
unix/mod.rs:19:pub type size_t = usize;
vxworks/mod.rs:28:pub type size_t = usize;
wasi.rs:16:pub type size_t = usize;
windows/mod.rs:16:pub type size_t = usize;

It seems the fail is caused by some network issue.

E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?

@bors: r+

:pushpin: Commit ea0a512079782cea977cedd483cae79c51ed15cc has been approved by gnzlbg

:hourglass: Testing commit ea0a512079782cea977cedd483cae79c51ed15cc with merge 56850068dcb7851213bf233ceae159a0229d533d...

:sunny: Test successful - checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure
Approved by: gnzlbg
Pushing 56850068dcb7851213bf233ceae159a0229d533d to master...


Hardcoded X11 include path on Linux?

I am attempting to build a Linux desktop app with Flutter on NixOS, which does not conform to the Filesystem Hierarchy Standard. The location of header files is atypical.
$ pkg-config --cflags-only-I x11
-I/nix/store/4c7g0zcz8rkyk0s11xa67xvab45a9g7s-libX11-1.8.1-dev/include -I/nix/store/4wglnplxrmkkazsrpshya8dy37mcsc6f-xorgproto-2021.5/include

It appears that CMake (or something else in the build process) is not using pkg-config to find some X11 header files, as building fails with errors like fatal error: 'X11/Xlib.h' file not found when the X11 / xorgproto headers are not in /usr/include.
Steps to Reproduce

Set up a Linux system (such as NixOS) with the X11 header files in an atypical location, but available through pkg-config
flutter run

Logs

Logs

[ +575 ms] [2/5] Building CXX object CMakeFiles/demo.dir/flutter/generated_plugin_registrant.cc.o
[  +21 ms] [3/5] Building CXX object CMakeFiles/demo.dir/my_application.cc.o
[        ] FAILED: CMakeFiles/demo.dir/my_application.cc.o
[   +4 ms] /nix/store/r3q7chdpb8xl2zas24iwy9s0fvd0g4sk-clang-wrapper-11.1.0/bin/clang++ -DAPPLICATION_ID=\"com.example.demo\"
-I/home/user/code/demo/linux/flutter/ephemeral -isystem /nix/store/yn0p0lyai1xpjbcvn4wmvcyk94rinykp-at-spi2-core-2.46.0-dev/include/atk-1.0 -isystem
/nix/store/fmqcm52w0p5jmzdbjjskwjiwyj9kqic9-glib-2.74.1-dev/include -isystem /nix/store/fmqcm52w0p5jmzdbjjskwjiwyj9kqic9-glib-2.74.1-dev/include/glib-2.0 -isystem
/nix/store/5rj03qmq4i4vb872r3bb0vhsk2xcv57m-glib-2.74.1/lib/glib-2.0/include -isystem /nix/store/1ad1ffvapcbrf3r3n4cm1mljc7ngy4hv-cairo-1.16.0-dev/include/cairo
-isystem /nix/store/v2lzlm6dkp9f5kjva1sza5d3hfr2k8jg-freetype-2.12.1-dev/include/freetype2 -isystem
/nix/store/v2lzlm6dkp9f5kjva1sza5d3hfr2k8jg-freetype-2.12.1-dev/include -isystem
/nix/store/i02xdrkl35m3ikcpq9s4i9cr6vzi74a2-gdk-pixbuf-2.42.10-dev/include/gdk-pixbuf-2.0 -isystem
/nix/store/8qrnvlkh53ysq0h31wpx5sc86jyfyjjp-gtk+3-3.24.34-dev/include/gtk-3.0 -isystem /nix/store/1f8dphpnccz5a01flrdnnqj02vdcgh0d-pango-1.50.11-dev/include/pango-1.0
-isystem /nix/store/dmvif836x5k9w7nnyjh7pygyzqkkjhkz-harfbuzz-5.2.0-dev/include/harfbuzz -g -Wall -Werror -MD -MT CMakeFiles/demo.dir/my_application.cc.o -MF
CMakeFiles/demo.dir/my_application.cc.o.d -o CMakeFiles/demo.dir/my_application.cc.o -c /home/user/code/demo/linux/my_application.cc
[   +1 ms] In file included from /home/user/code/demo/linux/my_application.cc:5:
[        ] /nix/store/8qrnvlkh53ysq0h31wpx5sc86jyfyjjp-gtk+3-3.24.34-dev/include/gtk-3.0/gdk/gdkx.h:30:10: fatal error: 'X11/Xlib.h' file not found
[   +1 ms] #include <X11/Xlib.h>
[        ]          ^~~~~~~~~~~~
[        ] 1 error generated.
[        ] ninja: build stopped: subcommand failed.
[  +11 ms] Building Linux application... (completed in 2,696ms)
[   +1 ms] Exception: Build process failed

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.3.8, on NixOS 22.11 (Raccoon) 6.0.7-zen1, locale en_AU.utf8)
[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/docs/get-started/install/linux#android-setup for detailed instructions).
      If the Android SDK has been installed to a custom location, please use
      `flutter config --android-sdk` to update to that location.

[✓] Chrome - develop for the web
[✓] Linux toolchain - develop for Linux desktop
[!] Android Studio (not installed)
[✓] Connected device (1 available)
[✓] HTTP Host Availability

! Doctor found issues in 3 categories.

Hi @hacker1024, looks like this issue has been fixed at #95711. Please try switching to the latest master channel and check if the issue is solved.


Fix typo in port

The app runs on port 8081, not 8001.

@abrookins Can you check this?

Looks great. Thanks, @mgarod!


Integrated Terminal drop box does not change to Task terminal when a task is run

Version: 1.28.0-insider
Commit: 5ba5f14c954682df46f04a541f0b272166605366
Date: 2018-09-26T07:28:12.336Z
Electron: 2.0.9
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64
KDE Neon Bionic 18.04
Steps to Reproduce:

Add a "bash" Integrated terminal
Run Task when the bash terminal is being selected
When task is complete, You will noticed that the terminal drop box is still selecting the "bash" terminal.

Does this issue occur when all extensions are disabled?: Yes

@alexr00 this is pretty old at this point, might already be fixed?

I can't reproduce it, so it seems fixed.


Shrink Silkworm and possibly animated texture?

Please?!@

I think silkworm size is perfect. Great visibility.


Feature Request: Hide Completed Items

I'm evaluating a PBI that has been carried over from a prior sprint.
This means the completed items from that show up, but due to the Estimated Effort being locked, it will recreate the work-item as a duplicate. This makes it hard to seperate out my new planning from prior work.
Can we consider an option to "hide completed" items in the synced items from Azure DevOps to avoid this conflict?

Much better from my point of view would be marking completed tasks with strike-through formatting (if possible) and even move them at the end of tasks.
Maybe support for collapsing would be an idea, too.

Not using any more so feel free to close if needed.  Cheers

I definitely still like to see that feature :)

The original idea of the extension was to just initially plan the sprint, not to manage it. The reasoning was simple: adding many User Stories with a bunch of tasks at once was cumbersome and frustrating.
Therefore it never contained any features for closed tasks nor anything like that was ever planned. It was supposed to solve our problems back in the days and it did :)
I published this mainly for our teams back then but since this is a very generic problem I was happy others found it useful too.
Unfortunately last time I worked with Azure DevOps was couple of years ago so I naturally lost interest in developing it. Also my life priorities have shifted in last 2-3 years as the world has changed since then. I was doing that in my spare time only so that basically means I cannot promise any changes in near future but I'm open to small bugfixes, PRs or a new maintainer.
This may and probably will change as soon as I change the company I work for and I will get back to Azure DevOps struggle again.
However it's kinda the best place I've been in so far so you know... ;)


Email source fixed, no duplicates in each iteration

One mail was repeated in each iteration previously which has been removed now.

Thank you @namanjuneja771 for working on it. @GirishPatel will review it.
Just more context for @GirishPatel

Using.Email source with state giving 1 duplicate email on each run. Which we suspect due to incorrect loop condition. @namanjuneja771 with his PR fixing that bug.

@namanjuneja771 Thank you very much for fixing the bug.


Custom JHLite - instructions in markdown

We need to check if the instructions in markdown work well.
The last time I tried (v1.0.0 if I remember well), I need to do some changes and the Cucumber tests didn't work (probably related to upgrade to last version of Spring Boot)
To do here:

check the instructions and update if necessary
if there are some bugs, it needs to be fixed

@pascalgrimaud : I'm going to work on this issue, is it ok?

Yes plz go ahead @renanfranca


Could you show more details about how you do segmentation recognition in the video?

I tried everything here but could only recognize one word at a time. How can I recognize a few more words or a sentence at a time like you do in the youtube video?  I would really appreciate for your help, thank you.

@reno5566  hi there, could you share your make_pickle.py for me? I'll very appreciate for that. thank you!!

@welson320 I'm working on it, seems don't need make_pickle now

@reno5566  Then how are you trainig RNN with the .txt files.

please share your segment.py file so we can test your 'bird like bird' example.

anyone have segment.py ?
please share me, tks


System scan is one body behind

When scanning unmapped system latest planet doesn’t show up. E.g. after scanning 4 bodies only 3 show up.
Once system is fully scan you have to honk again for it to mark as completed in app, otherwise is stays at 90ish percent.

Seem like the latest update addressed the issue.

It's a little bit janky honestly in that there is a delay while data gets submitted to ESDM.
I did add some client code to try and fix this but I don't think I finished implementing it fully and sometimes you need to either (a) honk (in game) or (b) tap on the progress icon on the map in ICARUS Terminal to get it to refresh.


Add project icon

@swankjesse placeholder until Square designers make something better

This is funny but I’m eager to revert this!


Doc changes sample apps - Add 3 apps and change installation.md flow

Pull Request Template
Description
Please include a summary of the change. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[ ] This change requires a documentation update.

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Additional Context (Please include any Screenshots/gifs if relevant)
...
Checklist:

[ ] My code follows the style guidelines of this project.
[ ] I have performed a self-review of my own code.
[ ] I have made corresponding changes to the documentation.
[ ] I have added corresponding tests.
[ ] Any dependent changes have been merged and published in downstream modules.

@TvisharajiK Deploy has failed please check once via npm run build locally to test the changes


TEXT field update fails for some text patterns.

Describe the bug
When TEXT is input in EDIT dialog and has some specific patterns, "Update" causes Syntax error.
To Reproduce

Create a MySQL/MariaDB database table having TEXT.
Open "DATA" tab and insert a new record.
Open EDIT dialog and input a string "{ 1; }". (double quote is not included )
Click Update

Expected behavior
The content is successfully updated.
Screenshots
Desktop (please complete the following information):

OS: Ubuntu
Version 21.04

Additional context
String  "{ 1 }" has no problem.

Hello @since19861019 ,
As always, thank you for supporting this project with your precious reports.
I just solved.


Necessary changes to host a blind test with data collection.

Just collects a few variables, such as Username, Ping, Totallatency and one secret variable :^).

finally


Can't create Goods Issue

Failed to load resource: the server responded with a status of 500 (Cannot read property 'id' of null) /api/inventory/goods-issue:1

done

fixed


Dependabot PRs

Please merge all the dependabot PRs and make sure that everything still works.  See the PRs list.

Project has reached EOL


Rendering lag

Every few seconds, the rendering will freeze and then jump ahead a few frames.

This actually seems to be specific to my browser. Closing.


Metadata header not signed error

Describe the bug
when i don't pass metadata everything is okay, but when I pass Metadata to tuspy and request to tusd it's can't create multipart upload becase:
[tusd] 2022/07/27 16:51:07 event="RequestIncoming" method="POST" path="" requestId=""
[tusd] 2022/07/27 16:51:07.762881 event="HookInvocationStart" type="pre-create" id=""
[tusd] 2022/07/27 16:51:09.617961 event="HookInvocationFinish" type="pre-create" id=""
[tusd] 2022/07/27 16:51:11 event="ResponseOutgoing" status="500" method="POST" path="" error="s3store: unable to create multipart upload:
AccessDenied: There were headers present in the request which were not signed
        status code: 400, request id: 1705AF045D965B3B, host id: " requestId=""

To Reproduce
Steps to reproduce the behavior:

Export AWS configs
Run tusd server: tusd --hooks-http http://<IP_ADDRESS>:43211/upload/tusd -s3-bucket=tusd -s3-endpoint=https://s3.staging.ir
Upload snippet code:

tus_client = TusClient(url=tus_url)
tus_storage = filestorage.FileStorage("storage_file")
uploader = tus_client.uploader(
    file_path,
    chunk_size=500000,
    store_url=True,
    url_storage=tus_storage,
    metadata={
        "space_id": "1",
    },
)
uploader.upload()

See error

[tusd] 2022/07/27 16:59:53.323126 Using 'https://s3.staging.ir/tusd' as S3 endpoint and bucket for storage.
[tusd] 2022/07/27 16:59:53.323240 Using 0.00MB as maximum size.
[tusd] 2022/07/27 16:59:53.323245 Using 'http://<IP_ADDRESS>:8000/upload/tusd' as the endpoint for hooks
[tusd] 2022/07/27 16:59:53.323250 Enabled hook events: pre-create, post-create, post-receive, post-terminate, post-finish
[tusd] 2022/07/27 16:59:53.323263 Using <IP_ADDRESS>:1080 as address to listen.
[tusd] 2022/07/27 16:59:53.323266 Using /files/ as the base path.
[tusd] 2022/07/27 16:59:53.323289 Using /metrics as the metrics path.
[tusd] 2022/07/27 16:59:53.323331 Supported tus extensions: creation,creation-with-upload,termination,concatenation,creation-defer-length
[tusd] 2022/07/27 16:59:53.323432 You can now upload files to: http://<IP_ADDRESS>:1080/files/
[tusd] 2022/07/27 17:01:12 event="RequestIncoming" method="POST" path="" requestId=""
[tusd] 2022/07/27 17:01:12.095351 event="HookInvocationStart" type="pre-create" id=""
[tusd] 2022/07/27 17:01:14.493380 event="HookInvocationFinish" type="pre-create" id=""
[tusd] 2022/07/27 17:01:15 event="ResponseOutgoing" status="500" method="POST" path="" error="s3store: unable to create multipart upload:
AccessDenied: There were headers present in the request which were not signed
        status code: 400, request id: 1705AF911E32B420, host id: " requestId=""

Expected behavior
create multiple upload parts and go on.
Setup details
Please provide following details, if applicable to your situation:

Operating System: linux
Used tusd version: 1.9.1
Used tusd data storage: minio version:2021-02-19T04:38:02Z.
Used tusd configuration: tusd --hooks-http http://<IP_ADDRESS>:43211/upload/tusd -s3-bucket=tusd -s3-endpoint=https://s3.staging.ir
Used tus client library: tuspy 1.0.0

Does the upload work if you configure tuspy to use the https://tusd.tusdemo.net/files/ endpoint? If yes, it might indicate a problem with your S3-compatible storage.

@Acconut sorry for the wrong data in the setup details, tusd data storage is minio version:2021-02-19T04:38:02Z.
yes, it's uploaded on https://tusd.tusdemo.net/files/ and I figured out what is the root problem it's for using _ in a metadata's key, in my example when I remove _ in space_id has been okay.
now I don't know if it's an issue about Unicodeing metadata in tusd or minio issue.
I tested with another s3 storage compatible(arvanCloud object storage) and this issue happens with SignatureDoesNotMatch error.

can happen from aws-sdk-go? because there was the same issue on another sdk (aws-sdk-net)

Ok, so to summarize:

You can upload to https://tusd.tusdemo.net/files/ (which uses AWS S3)
You cannot upload when tusd uses Minio or ArvanCloud
The error only occurs when an underscore is present in the metadata key

For now, this looks to me to be a bug in the Minio storage. I wasn't able to find a concrete issue for the aws-sdk-go, but this issue describes the reason why underscores are problematic: https://github.com/localstack/localstack/issues/459#issuecomment-346756560
I would recommend you to not user underscores in the metadata key for now. In addition, I am wondering if tusd should strip underscores from the metadata key by default now. Any thoughts on this?

Could you try uploading to AWS S3 using tusd on your own and see if that works?

sorry, I don't have AWS S3 account and I can't create it because of my religion.

I am wondering if tusd should strip underscores from the metadata key by default now. Any thoughts on this?

can you reproduce this scenario and see the metadata header that tusd send to an S3 server?


”Apalina”, ”Iernuțeni” are listed in the drop-down menu

Description:
When user writes ”Apalina”, ”Iernuțeni” the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Apalina"

Expected results
The location appears in the drop-down menu as "Sat Apalina, MUREȘ (REGHIN)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Iernuțeni"

Expected results
The location appears in the drop-down menu as "Sat Iernuțeni, MUREȘ (REGHIN)".


feature request: @volar/monaco auto insert closing quotes / brackets

vscode / builtin monaco will auto insert closing quotes / brackets, like typing ( will result in () with caret between it.
I doubt whether this feature related to @volar/monaco or @vue/repl itself

It seems @vue/repl lacks of language configuration when integrate textmate


Keymap not loaded.

Does not load the keymap specified in /etc/vconsole.conf. This is problematic in LUKS when combining password with special charcters and a non US keyboard.
Analogus are sd-vconsole in mkinitcpio and rd.vconsole in dracut.

Please try changes from vconsole branch. With it you can add vconsole: true to the config file to enable the early-user console configuration.

Yes, that worked flawlessly. Thank you!
However I've noticed that (don't know if this is introduced in this version or was already there before) config does not default to /etc/booster.yml but has to be set through the appropriate flag.

Yes, that worked flawlessly. Thank you!

Great to hear it!

However I've noticed that (don't know if this is introduced in this version or was already there before) config does not default to /etc/booster.yml but has to be set through the appropriate flag.

booster's default config path is (and always was) /etc/booster.yaml.


Significant issue: Representation of tempo changes is incorrect in Midi file

I must take issue with the reply to a separate post in the Euterpea1 project -  https://github.com/Euterpea/Euterpea/issues/31 That reply said:

The effect of the Tempo modifier you have observed is not a bug; you're seeing the intended behavior. Tempo modifiers to allow for musical structures that do not adhere to the standard MIDI notion of beats and measures. The scaling of the offsets also allows for easier integration with MIDI streams. If you want write a MIDI file with a specific tempo, you can construct the music value as for 120bpm and then, within Euterpea 2, you can use a combination of the perform and toMidi functions to access the intermediate Midi type (which belongs to Codec.Midi) and alter timeDiv as desired.

My understanding is that is NOT how tempo should be handled in Midi files. I would expect any tempo modifier to correspond to a marked change in tempo within the music, to allow for faster and slower sections within a single piece of music without breaking the structure of the music in terms of beats and bars. Indeed, I would hope that later enhancements could allow for changing time signatures, although that would need the addition of a further Control constructor, such as “TimeSig Rational”.
This means that writing Midi files is different from playing to a Midi device in that tempo changes should NOT scale the durations, but simply insert the appropriate “Set Tempo” (FF 51 03 tt tt tt) meta event, with a restoring meta event at the end of the tempo-modified section. This is further divergence of the representation of Midi used for playing from that used for exporting.
Maybe this is pushing Euterpea into capabilities beyond its pedagogical role. But either we need to accept significant limitations in the music that it can handle, or we need to push for such fixes and enhancements. It seems so close!

The explanation from the other thread is still the same for Euterpea 2.

Maybe this is pushing Euterpea into capabilities beyond its pedagogical role. But either we need to accept significant limitations in the music that it can handle, or we need to push for such fixes and enhancements. It seems so close!

This is a case where trying to support too many specific features will ultimately detract from generality and simplicity in other parts of the system. Euterpea has had many altered versions made by people over time for specific purposes (for example, I wanted microtones at one point a long time ago, so I made an altered version specifically for that with additional constructors and such). That is the alternative I would recommend if you require these kinds of features.


cannot find macro jsonapi_model! in this scope

I'm looking for a little guidance on what would seem to be a very contrived and easy example. I have an extremely bare-bones application defined in src/main.rs as follows:
#[macro_use] extern crate jsonapi;

use jsonapi::model::*;

#[derive(Debug)]
pub struct Person {
    pub id: i32,
    pub name: String
}

jsonapi_model!(Person; "person");

fn main() {
    let user = Person { id: 1, name: "World".to_string() };
    println!("{:?}", user);
}

Upon compilation I receive the following error
cannot find macro `jsonapi_model!` in this scope

What am I missing here? I feel like I've copied the necessary includes and macro imports (based on what I was seeing in the tests directory) yet I cannot get this to compile. I am running rustc 1.22.1. Any help would be greatly appreciated.

@JadedEvan Sorry that took a bit longer, the recently published v0.5.4 and 0.6.0 both contain the macro.


Missing required variables to enabled HTTPS

SUMMARY

The https part of the data structure used by the JWS role is missing a couple of variables to allow enabling HTTPS.
ISSUE TYPE

Bug Report

ANSIBLE VERSION

COLLECTION VERSION

STEPS TO REPRODUCE

EXPECTED RESULTS

ACTUAL RESULTS

Fixed by [PR49|https://github.com/ansible-middleware/jws-ansible-playbook/pull/49]


Command to maximize current view vertically

A command to collapse all views inside the sidebar (Explorer) except the currently focused one. Useful, for example, when the vertical space is limited but you still want to use both files and outline views.

Duplicate of https://github.com/Microsoft/vscode/issues/48201


dart2js crashes on function type bounds

Consider the following program:
class C<X extends Function(Y), Y extends Function(Z), Z> {}

main() {
  print(new C());
}

When compiling this program with dart2js and dart2js --checked (version 2.0.0-dev.7.0) we get the following crash:
Internal Error: The compiler crashed when compiling this element.
class C<X extends Function(Y), Y extends Function(Z), Z> {}
^^^^^
The compiler is broken.

When compiling the above element, the compiler crashed. It is not
possible to tell if this is caused by a problem in your program or
not. Regardless, the compiler should not crash.

The Dart team would greatly appreciate if you would take a moment to
report this problem at http://dartbug.com/new.

Please include the following information:

* the name and version of your operating system,

* the Dart SDK build number (2.0.0-dev.7.0), and

* the entire message you see here (including the full stack trace
  below as well as the source location above).

The compiler crashed: NoSuchMethodError: Class 'FunctionTypeAnnotation' has no instance getter 'typeName'.
Receiver: Instance of 'FunctionTypeAnnotation'
Tried calling: typeName
#0      Object.noSuchMethod (dart:core-patch/dart:core/object_patch.dart:46)
#1      TypeResolver.resolveNominalTypeAnnotation (file:///b/build/slave/dart-sdk-linux-dev/build/sdk/pkg/compiler/lib/src/resolution/type_resolver.dart:233)
#2      TypeDefinitionVisitor.resolveTypeVariableBounds (file:///b/build/slave/dart-sdk-linux-dev/build/sdk/pkg/compiler/lib/src/resolution/class_hierarchy.dart:78)
#3      ClassResolverVisitor.visitClassNode (file:///b/build/slave/dart-sdk-linux-dev/build/sdk/pkg/compiler/lib/src/resolution/class_hierarchy.dart:148)
#4      ClassNode.accept (file:///b/build/slave/dart-sdk-linux-dev/build/sdk/pkg/compiler/lib/src/tree/nodes.dart:539)
#5      CommonResolverVisitor.visit (file:///b/build/slave/dart-sdk-linux-dev/build/sdk/pkg/compiler/lib/src/resolution/resolution_common.dart:32)
#6      ResolverTask.resolveClassInternal.<anonymous closure>.<anonymous closure> (file:///b/build/slave/dart-sdk-linux-dev/build/sdk/pkg/compiler/lib/src/resolution/resolution.dart:668)
#7      CompilerTask.measure (file:///b/build/slave/dart-sdk-linux-dev/build/sdk/pkg/compiler/lib/src/common/tasks.dart:63)
#8      ResolverTask.resolveClassInternal.<anonymous closure> (file:///b/build/slave/dart-sdk-linux-dev/build/sdk/pkg/compiler/lib/src/resolution/resolution.dart:660)
#9      CompilerDiagnosticReporter.withCurrentElement (file:///b/build/slave/dart-sdk-linux-dev/build/sdk/pkg/compiler/lib/src/compiler.dart:1129)
#10     ResolverTask.resolveClassInternal (file:///b/build/slave/dart-sdk-linux-dev/build/sdk/pkg/compiler/lib/src/resolution/resolution.dart:658)

With a fresh dart2js from commit dfc356eb0ac8ae17a34648809ca7c339d43092e6 we get a different crash:
Internal Error: The compiler crashed when compiling this element.
class C<X extends Function(Y), Y extends Function(Z), Z> {}
^^^^^
The compiler is broken.

When compiling the above element, the compiler crashed. It is not
possible to tell if this is caused by a problem in your program or
not. Regardless, the compiler should not crash.

The Dart team would greatly appreciate if you would take a moment to
report this problem at http://dartbug.com/new.

Please include the following information:

* the name and version of your operating system,

* the Dart SDK build number (build number could not be determined), and

* the entire message you see here (including the full stack trace
  below as well as the source location above).

The compiler crashed: type 'FunctionTypeAnnotation' is not a subtype of type 'NominalTypeAnnotation' of 'bound' where
  FunctionTypeAnnotation is from file:///usr/local/google/home/eernst/devel/dart/work/sdk/pkg/compiler/lib/src/tree/nodes.dart
  NominalTypeAnnotation is from file:///usr/local/google/home/eernst/devel/dart/work/sdk/pkg/compiler/lib/src/tree/nodes.dart

#0      NodeListener.endTypeVariable (file:///usr/local/google/home/eernst/devel/dart/work/sdk/pkg/compiler/lib/src/parser/node_listener.dart:1127:35)
#1      Parser.parseTypeVariable (package:front_end/src/fasta/parser/parser.dart:1953:14)
#2      Parser.parseTypeVariablesOpt.<anonymous closure> (package:front_end/src/fasta/parser/parser.dart:2647:16)
#3      Parser.parseStuff (package:front_end/src/fasta/parser/parser.dart:2667:28)
#4      Parser.parseTypeVariablesOpt (package:front_end/src/fasta/parser/parser.dart:2644:12)
#5      Parser.parseClassOrNamedMixinApplication (package:front_end/src/fasta/parser/parser.dart:1416:13)
#6      Parser.parseTopLevelKeywordDeclaration (package:front_end/src/fasta/parser/parser.dart:511:14)
#7      Parser.parseTopLevelDeclarationImpl (package:front_end/src/fasta/parser/parser.dart:425:14)
#8      Parser.parseTopLevelDeclaration (package:front_end/src/fasta/parser/parser.dart:397:9)
#9      PartialClassElement.parseNode.<anonymous closure>.<anonymous closure> (file:///usr/local/google/home/eernst/devel/dart/work/sdk/pkg/compiler/lib/src/parser/partial_elements.dart:391:32)
#10     CompilerTask.measure (file:///usr/local/google/home/eernst/devel/dart/work/sdk/pkg/compiler/lib/src/common/tasks.dart:63:44)

This seems to imply that the relevant part of the implementation is under active development, which might mean that it needs to be fixed (even though this is not dart2js --use-kernel, that is, "it's a legacy dart2js crash").

handled by the CFE


identity: Wait for initial set of security identities before restoring endpoints

Fixes: #5290

This change is

test-me-please

Hit https://github.com/cilium/cilium/issues/5292

test-me-please

Kafka DNS resolution issue. Not sure what the right issue is to assign to, we have a lot of DNS related CI flakes.

test-me-please

test-me-please

CI failure: Unable to build endpoints due to builds taking too long. Unlikely related to these changes.

test-me-please

test-me-please

backport-pending/1.1 should get its tag pushed to needs-backport/1.1 because I pulled it out of the backports due to it apparently introducing a flake.

@jrfastab I am doing 1.1 backports - do you know exactly what the notion of the flake is that caused this to no longer be backported?

@ianvernon this fell off my queue, I don't recall what the specific issue was I bisected to this patch and removed. After removing it the CI passed successfully.

Dropping needs-backport/1.1 as per discussion with @tgraf.


Date validation does not work when using nlohmann traits

Creating a token is fine...
    auto token = jwt::create<nlohmann_traits>()
            .set_issuer(jwt_issuer)
            .set_issued_at(std::chrono::system_clock::now())
            .set_expires_at(std::chrono::system_clock::now() + std::chrono::seconds{3600})
            .sign(jwt::algorithm::hs256{jwt_secret});

... however when running verify, nlohmann_traits throws a bad cast during the expiry check here -
https://github.com/Thalhammer/jwt-cpp/blob/7715cc2eff8bae88e3fcbb1a70f64f726023057a/tests/NlohmannTest.cpp#L54-L58
It seems nlohmann::json is returning the val.type() as unsigned long long (uint64_t which is probably correct for a date). However, jwt-cpp is expecting a signed long long (int64_t).
A workaround is to also allow json::value_t::number_unsigned and then cast to the signed version. Shouldn't be an issue unless the expiry date is 300 billion years from now? :-)
Platform is MSVC 2019 on Windows 10 and nlohmann::json 3.8.0.

Thanks for this report! I'll look into it shortly

From https://travis-ci.com/github/prince-chrismc/jwt-cpp/builds/190847927

unknown file: Failure
C++ exception with description "std::bad_cast" thrown in the test body.
[  FAILED  ] NlohmannTest.Bug103Expiration (0 ms)
It's a bug!

It's a bit of a weird one. The JSON schema doesn't really have the concept of unsigned integers. However, nlohmann::json is returning the value as an unsigned int. Does it do that for any positive integer, and any negative integer becomes a signed int?
I guess this is one challenge of schemaless formats (ref https://github.com/nlohmann/json/issues/305 too.)
There's some discussion re JWT and JSON date issues here - https://stackoverflow.com/questions/49220571/json-web-token-and-the-year-2038-bug
One suggestion - perhaps separate the struct nlohmann_traits {... out into separate include? I extracted it from your test file and included it as a separate header for my project.

One suggestion - perhaps separate the struct nlohmann_traits {... out into separate include? I extracted it from your test file and included it as a separate header for my project.

Yep... needs a little refactor :speak_no_evil: It's also in the readme and an example which is not so pleasant to maintain :exploding_head:

It's a bit of a weird one. The JSON schema doesn't really have the concept of unsigned integers. However, nlohmann::json is returning the value as an unsigned int. Does it do that for any positive integer, and any negative integer becomes a signed int?

That's been my experience with the library (though I rarely pass numbers in JSON), and it matches with the docs... https://github.com/nlohmann/json/blob/486812904f29a86f18c9fd78b34fecd6b25a6ae7/include/nlohmann/detail/value_t.hpp#L30-L32
JSON has only a "number" type which can be anything from a C++ perspective, in order to respect the precision I suspect nlohmann/json needs to use the closest C++ type and performs the implicit conversions when you "get" the value.


You've used my code without permission

Hi Michael,
I'm the creator of https://github.com/LMDDGTFY.
I'm honored that you like my work enough use it on your own project, but I'd like to request that you revert your code back to what it was before June 15, 2015, as you have not asked permission to use my code, and the code you copied was an early release not yet fully working.
P.S.
I believe DuckDuckGo requires you to have some form of an "unofficial site" notice. You removed this when you copied my code. When creating my project, I got permission from DuckDuckGo to use the mascot (Dax) and name on the site:

[...] For now, our only request is that you signify "unofficial" near the name/logo

Hello Zeke Y,
I apologize for misusing your code. I must have been working on multiple projects that night and I thought I remember seeing a LICENSE file in the https://github.com/lmddgtfy project. It appears that according to mine and your git commit history that, that isn't true. I thought at most I had forgot to upload the LICENSE file when publishing your code.
Anyways, I've reverted the changes per your wish as without a license file it would be unauthorized use of your code, and I do apologize for that. I hope we can work out an agreement in the future so your code can be reached by many others on https://lmddgtfy.net/

Regrading the P.S., the reason that was removed is because even though DuckDuckGo doesn't officially operate, run, nor maintain lmddgtfy.net, it has been given the blessing of having permission to use the logos and operate in its manner from several sources:

The supposed "used with permission" from the original project hosted by mikejs.
The listing of lmddgtfy.net on duck.co's community site, https://duck.co/help/add-ons/lmddgtfy
and a personal e-mail correspondence with Weinberg and myself about making changes to Apache logs to increase privacy for lmddgtfy.net.

If DuckDuckGo would officially like https://lmddgtfy.net/ to add a "unofficial site" I'd be more than happy to add it.

@myano Thanks for reverting, and doing it so quickly :)
re:

I hope we can work out an agreement in the future so your code can be reached by many others on https://lmddgtfy.net/

I'm sure we can work out some sort of deal, but I'd kind of like more attribution than just "created by Zeke Y" if I made the whole entire UI. I don't really know yet how I'll do it. I think I'll look into some licenses soon and decide on one, then go license my code.

If DDG is fine with you not having the notice, I don't mind at all either. I just thought maybe you didn't realize they wanted you to have the unofficial site notice :)

@myano If you'd like to help me with the project, I've created a to do list of the stuff that needs to happen before it's released.
Sorry I haven't looked at licenses yet, I'm going to try and do that soon.

@myano Could you take a look at what I've got right now? The footer just says "copyright 2015 LMDDGTFY", but the word LMDDGTFY links to /about.html, which says that I made it, we both maintain it (since I'm planning on helping out with the code in the future, but we could change that bit if you want), and that you pay for the hosting and stuff.

@myano I've added a license file now, using the MIT license. All good?

@KK4OXJ Howdy, I'm sorry I haven't responded yet. I'm willing to have whatever attribution you'd like on the page you'd like as long as I can point out that it is hosted and also maintained by me as well. Which sounds like it will work for the two of us.
I looked at the to do list and it seems the last issue is the Apple devices problem. I don't own any mobile Apple devices and can't really help out with that, but I'm willing to help with other things that come up as time goes along.
The MIT License works for me.
 If so would you like to submit a pull request against my project to preserve the git history?
(Also, when moving it over to https://lmddgtfy.net/ as I mentioned early I'll remove the "unofficial site" notice because of the points mentioned previously.)

@myano

Are you ready to have the code live on https://lmddgtfy.net/ ?

Your call. The site is functional on Apple devices, but it doesn't look right on them yet. Do you want to push it live now, or would you like to wait until we fix the two problems on Apple devices left?

PR submitted!

@KK4OXJ Awesome, thank you very much.
I made a few small tweaks that you can see in the git history. Mostly just cleaning up a few things. Nothing major was changed.


Revamp Demo Application

Revamp the Streamlit demo to follow these steps

Visit https://decenter-ai.streamlit.app/
Enter model name
Upload training dataset
Select training script
Click train
Model training commences
After training is done , you can download your trained model

[ ] Remove the side bar from appearing at default when a user visits the demo

[ ] Remove the Version section and the demo section

[ ] The model name box should say "Enter Model Name" by default and should be editable

[ ] The Training script Box should be empty by default until the user clicks the dropdown button so select a training script

[ ] Please remove these, They are of no use

[ ] Change these to "Demo V1" "Demo V2" "Demo V3"

@Dineshjnld build this app in this repo

completed 5 tasks
remaining: 6th task and closing the side bar


Expanded API, exposing map as unmodifiable collection…

So that users can get all the classes via getClasses() and utilize the Map interface. Included unit testing for ClassFileManager, JUnit as a dependency in the test scope.
Adds various add* methods. Constructors have been modified but signatures are not changed.

I had suspicions that the ClassFileManager was a little barebones and I'm glad that you've added additional functionality to it. Thank you for your pull-request.


Unable to upgrade to 1.22.x, ER_CANNOT_ADD_FOREIGN on table posts_authors

Issue Summary
A very similar problem to the one described at #9539 (definitely related to #9426), but this time with MySQL database and Linux as host OS (running Ghost as a Docker container). Trying to upgrade Ghost 1.21.x to Ghost 1.22.x will result on a database migration error.
[22:35:20] Running database migrations [started]
[22:35:33] Running database migrations [failed]
[22:35:33] The database migration in Ghost encountered an error.
A ProcessError occurred.

Message: The database migration in Ghost encountered an error.
Help: https://docs.ghost.org/v1/docs/troubleshooting#section-general-update-error
Suggestion: ghost update --rollback
--------------- stderr ---------------
[2018-05-01 22:35:33] ERROR

NAME: MigrationScriptError
CODE: ER_CANNOT_ADD_FOREIGN
MESSAGE: alter table 'posts_authors' add constraint 'posts_authors_post_id_foreign' foreign key ('post_id') references 'posts' ('id') - ER_CANNOT_ADD_FOREIGN: Cannot add foreign key constraint

Steps to Reproduce

Run ghost update -V on a version 1.21.x blog. In this case it was version 1.21.2.
Error will show up.

I also tried to run knex-migrator manually to get more detail about why the problem is happening and it looks like the database table post_authors gets created and immediately deleted, so when the ALTER TABLE query is sent, there is actually no table where it could be applied. I'm attaching the knex log to this issue.
Technical details:
Debug Information:
OS: linux, v4.13.0-1011-azure
Node Version: v6.13.0
Ghost-CLI Version: 1.7.2
Ghost version: 1.21.2
Database: MySQL 5.7
Environment: production
Command: 'ghost update -V'
Logs:
ghost-cli-debug-2018-05-01T22_35_33_311Z.log
knex-migrator.log

Hey @cmilanf!
Sorry for having trouble. I am unable to reproduce this.

I also tried to run knex-migrator manually

Can you please try again and run knex-migrator with DEBUG=knex:query,knex-migrator:*? That might give use some more details.

A very similar problem to the one described at #9539

I don't think this is related.

You were right, it was not related. Thanks to the debug information I was able to see that the --init parameter was sliping into my script when the database already existed. Removing it made the migration work as expected:
2018-05-02T10:15:31.682854081Z ************started migration***********
2018-05-02T10:15:39.927877974Z [2018-05-02 10:15:39] INFO Creating database backup
2018-05-02T10:15:40.454413947Z [2018-05-02 10:15:40] INFO Database backup written to: /home/site/wwwroot/data/1.ghost.2018-05-02.json
2018-05-02T10:15:40.483938395Z [2018-05-02 10:15:40] INFO Adding table: posts_authors
2018-05-02T10:15:44.575474387Z [2018-05-02 10:15:44] INFO Adding `posts_authors` relations
2018-05-02T10:15:46.074203163Z [2018-05-02 10:15:46] INFO Finished database migration!
2018-05-02T10:15:46.098487307Z ************migration ended***********

I still wonder why ghost-cli didn't work though... But the problem is solved and the issue can be closed.
Thanks for your help @kirrg001

@cmilanf Thanks for coming back and happy you sorted it out!

I still wonder why ghost-cli didn't work though

I wonder too. I'll re-test migrating from 1.21 to 1.22.5, because we have updated one of our dependencies.

Thank you @kirrg001 for the additional help offer, but I am not able to hand over the whole database, even if I know it is just for testing and bug hunting purposes :)
I will try again in next upgrade with ghost-cli to see if I have the problem again. knex-migrator worked as expected.


VS code thinks my file is a folder, opens a new empty instance instead of going to the file

Does this issue occur when all extensions are disabled?: Yes

VS Code Version:  1.73.1
OS Version: Windows 11

Steps to Reproduce:

Use Git bash as your default terminal
Run yarn types
Ctrl+Click a filename that has a TS error
Expected behavior: Opens file inside the same VS Code instance
Actual behavior: Every now and then, I have to restart VS Code because it doesn't open files anymore. Instead, it opens a second, empty, VSCode instance on top of the one I am working in.

No

Please note that whenever this bug pops up, in my terminal, the Ctrl+Click hint says "Open this folder"
Rebooting solves it temporarily

Is that the integrated terminal in VS Code or an external one?

The integrated terminal. (Which I configured to use git bash by default.)

Sounds like an issue with the integrated terminal to sometimes trigger the "Open Folder" flow, which does involve opening a new window.

Are we talking about different "windows"? Normally, whenever I do Ctrl+Click, I just stay in VSCode. It does not open a new window (=new VSCode instance). I do expect it to open a new tab with the file I clicked, but staying inside the current VSCode instance

Can you post a screenshot of the path in question with the mouse hovering over it to show the tooltip like this?

Trust me, the Ctrl+Click hint really really says "Open this folder". I'm having the demo effect right now, it hasn't occurred for a few days. I'll post a screenshot as soon as it happens again.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!

@Tyriar The error occurred again today and I managed to create a screenshot

When I click, it opens a new empty VSCode instance. (I could live with it if at least it jumped to my file in that new instance, but it does not.)


Review if LCD.getInstance could return a Graphics2D object

Currently LCD is returning a GraphicsLCD object but in order to integrate the project with many algorithms developed by third party, it could be interesting to return a Graphics2D object. GraphicsLCD is similar but not the same.

That simply means to scrap the leJOS emulation. You can then create Graphics2D from the buffer that JavaFramebuffer creates for you. Then you can draw it through flush call (or similar, I don't remember).
We can create some sort of Java2DLCD which would encapsulate this.
You can get the JavaFramebuffer through LCD.getInstance().getFramebuffer()

Reviewing the case, I think that we have a simple solution in front of our eyes. I will explain:
Graphics2D, is an Abstract class so, it is not possible to use directly and it is not an Interface.
https://docs.oracle.com/javase/7/docs/api/java/awt/Graphics2D.html
In our case, we have a good Interface: GraphicsLCD with many methods:
https://github.com/ev3dev-lang-java/lejos-commons/blob/master/src/main/java/lejos/hardware/lcd/GraphicsLCD.java
But it is true, that it doesn't have all methods that Graphics2D provides. So the simple solution to grow the Display support:

Add on demand, the pending methods that we find or the community.

In that case, we don't have to add more complexity.
In my case, I find one pending method for a Fractal example:
    public void drawOval(int x, int y, int width, int height) {
        g2d.drawOval(x, y, width, height);
    }

This missing method is used in this local example:
https://www.youtube.com/watch?v=iD5OcfiN3f0
At the end, in Desktop we have AWT. In our case, we have the display to manage the Framegrabber. So adding the missing methods is enough.
@JakubVanek Ok?

No. I don't want to extend the leJOS abstraction. The user should use Graphics2D directly.

If we ensure that all non-deprecated functionality in our GraphicsLCD works, then I'm OK with adding it there - then there is no reason for me to deprecate GraphicsLCD itself.

I will add the support for the new method in the different parts.
    public void drawOval(int x, int y, int width, int height) {
        g2d.drawOval(x, y, width, height);
    }

Resolved the discussion


fix: 修复 tabbar 插入 item 后 hidden 状态丢失问题

Types

[x] 🐛 Bug Fixes

Background or solution
containerId 同时也是入参的名字，导致之前这里漏了取当前遍历项的 containerId
Changelog

修复 tabbar 插入 item 后 hidden 状态丢失问题

Codecov Report

Merging #442 (5495571) into main (4fc3bac) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #442   +/-   ##
=======================================
  Coverage   59.32%   59.32%
=======================================
  Files        1188     1188
  Lines       72928    72929    +1
  Branches    15095    15095
=======================================
+ Hits        43264    43268    +4
+ Misses      27031    27029    -2
+ Partials     2633     2632    -1

Impacted Files
Coverage Δ

...s/main-layout/src/browser/tabbar/tabbar.service.ts
62.63% <100.00%> (+0.10%)
:arrow_up:

packages/core-common/src/node/port.ts
43.93% <0.00%> (-3.04%)
:arrow_down:

...erences/src/browser/preference-settings.service.ts
79.86% <0.00%> (+0.69%)
:arrow_up:

...kages/theme/src/browser/workbench.theme.service.ts
71.21% <0.00%> (+0.89%)
:arrow_up:

packages/monaco/src/browser/schema-registry.ts
71.11% <0.00%> (+2.22%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fc3bac...5495571. Read the comment docs.

/publish


Report durations and numbers with consistent significant figures

Currently reporters use a fixed number of digits after a decimal to report test duration and other numbers, though the number of digits varies from 0 (whole numbers) all the way to 6. Since tests have a huge range of execution time, this can result in not-very-useful numbers in both directions: giving microsecond precision on a test that takes two minutes is unnecessary information that's harder to parse; on the other hand a test that takes some microseconds is, in some places, truncated to 0.00.
This PR changes reporting to include 3 significant figures on all numbers (barring any that I missed). 3 seems like at least as much precision as is significant in these reports - the amount of time tests take always varies more than this (in my experience).
I also split durations into hour/minute/second rather than always just reporting seconds.
Before:
test_0001_fast_test   PASS (0.00s)
test_0002_slow_test   PASS (105.00s)

Finished in 105.09427s

After:
test_0001_fast_test   PASS (0.00114s)
test_0002_slow_test   PASS (1m 45s)

Finished in 1m 45s

MeanTimeReporter before:
Finished tests in 103.051912s, 0.0194 tests/s, 1.0092 assertions/s.
2 tests, 102 assertions, 0 failures, 0 errors, 0 skips

Minitest Reporters: Mean Time Report (Samples: 5, Order: :avg :desc)
Avg:<PHONE_NUMBER>5 Min: 101.051376   Max: 105.07253    Last: 103.051096   Description: slow
Avg: 0.001024625  Min: 0.000411     Max: 0.001939     Last: 0.000629     Description: fast

After:
Finished tests in 1m 44s, 0.0192 tests/s, 1.01 assertions/s.
2 tests, 102 assertions, 0 failures, 0 errors, 0 skips

Minitest Reporters: Mean Time Report (Samples: 5, Order: :avg :desc)
Avg: 102       Min: 101        Max: 105       Last: 104        Description: slow
Avg: 0.00115   Min: 0.000411   Max: 0.00194   Last: 0.000437   Description: fast

I notice this would conflict with https://github.com/minitest-reporters/minitest-reporters/pull/340 but it could supersede that. This does not have the round issue that PR fixes.


Implement File handling: JSON, .csv, .jpeg, .png

Need to be able to handle images and text files

Types of Files:

[ ] JSON
[ ] CSV
[ ] JPEG
[ ] PNG

CSV file handling is done. Need to improve JSON handling and connect JPEG file handling to the report


AES CTR-DRGB: use platform specific AES-CTR support

Next try to get HW supported AES-CTR for CTR-DRBG's generate operation.
Related:

My original 2017 PR: https://github.com/openssl/openssl/pull/4530
(was rejected/stalled due to not using EVP and worries about internal state's counter increment not exactly matching the NIST pseudo-code/reference implementation)

Today's PR: https://github.com/openssl/openssl/pull/10456
(tries to do the same only for x86)

This one uses EVP, keeps internal state counter in sync with reference implementation and should already pass the test suite.
TODO:

simplyfiy if-statement in generate for loop - done.
look at performance especially for small chunks - done.
add test case(s) that cover counter wrapping (think my old PR had that one) - done.

Not looking good ...
                 master         this PR
[bytes]         [bytes/sec]    [bytes/sec]
   16              6044.29k       4689.63k
   24              8809.23k       6837.68k
   32             11773.52k       8431.58k
   64             22041.49k      16890.84k
  256             63664.31k      68692.49k
  512             97853.70k     140839.77k
16384            184698.47k    2066346.26k

master (16 bytes)
  16.22%  openssl  libc-2.17.so        [.] __strcmp_sse42
  13.17%  openssl  libcrypto.so.3      [.] aesni_ecb_encrypt
  10.73%  openssl  libcrypto.so.3      [.] EVP_CIPHER_block_size
   8.21%  openssl  libcrypto.so.3      [.] OSSL_PARAM_locate
   5.00%  openssl  libcrypto.so.3      [.] cipher_generic_block_update
   3.97%  openssl  libcrypto.so.3      [.] cipher_generic_get_params
   3.92%  openssl  libcrypto.so.3      [.] aesni_set_encrypt_key
   3.44%  openssl  libcrypto.so.3      [.] EVP_EncryptUpdate
   2.87%  openssl  libpthread-2.17.so  [.] pthread_rwlock_unlock
   2.14%  openssl  libpthread-2.17.so  [.] pthread_rwlock_wrlock
   2.07%  openssl  libcrypto.so.3      [.] OPENSSL_cleanse
   1.91%  openssl  libc-2.17.so        [.] __memset_sse2
   1.53%  openssl  libcrypto.so.3      [.] fillblock
   1.52%  openssl  libcrypto.so.3      [.] EVP_CIPHER_CTX_key_length
   1.48%  openssl  libcrypto.so.3      [.] ctr_df
   1.45%  openssl  libc-2.17.so        [.] _int_free
   1.41%  openssl  libcrypto.so.3      [.] EVP_CIPHER_CTX_reset
   1.32%  openssl  libcrypto.so.3      [.] strcmp@plt
   1.04%  openssl  libc-2.17.so        [.] _int_malloc
   1.02%  openssl  libpthread-2.17.so  [.] pthread_rwlock_rdlock

this PR (16 bytes)
  14.60%  openssl  libc-2.17.so        [.] __strcmp_sse42
   9.59%  openssl  libcrypto.so.3      [.] aesni_ecb_encrypt
   8.20%  openssl  libcrypto.so.3      [.] EVP_CIPHER_block_size
   7.42%  openssl  libcrypto.so.3      [.] OSSL_PARAM_locate
   5.97%  openssl  libcrypto.so.3      [.] aesni_set_encrypt_key
   3.54%  openssl  libcrypto.so.3      [.] cipher_generic_block_update
   3.37%  openssl  libcrypto.so.3      [.] OPENSSL_cleanse
   3.29%  openssl  libpthread-2.17.so  [.] pthread_rwlock_unlock
   3.21%  openssl  libcrypto.so.3      [.] cipher_generic_get_params
   2.89%  openssl  libc-2.17.so        [.] __memset_sse2
   2.77%  openssl  libpthread-2.17.so  [.] pthread_rwlock_wrlock
   2.63%  openssl  libcrypto.so.3      [.] EVP_EncryptUpdate
   2.32%  openssl  libcrypto.so.3      [.] EVP_CIPHER_CTX_key_length
   2.10%  openssl  libcrypto.so.3      [.] EVP_CIPHER_CTX_reset
   1.92%  openssl  libc-2.17.so        [.] _int_free
   1.53%  openssl  libcrypto.so.3      [.] EVP_CipherInit_ex
   1.52%  openssl  libc-2.17.so        [.] _int_malloc
   1.27%  openssl  libc-2.17.so        [.] malloc
   1.22%  openssl  libcrypto.so.3      [.] strcmp@plt
   1.07%  openssl  libcrypto.so.3      [.] ctr_df
   1.07%  openssl  libcrypto.so.3      [.] fillblock

master (16384 bytes)
  21.53%  openssl  libc-2.17.so        [.] __strcmp_sse42
  18.58%  openssl  libcrypto.so.3      [.] aesni_ecb_encrypt
  16.59%  openssl  libcrypto.so.3      [.] EVP_CIPHER_block_size
  10.78%  openssl  libcrypto.so.3      [.] OSSL_PARAM_locate
   7.44%  openssl  libcrypto.so.3      [.] cipher_generic_block_update
   6.19%  openssl  libcrypto.so.3      [.] cipher_generic_get_params
   5.23%  openssl  libcrypto.so.3      [.] EVP_EncryptUpdate
   2.30%  openssl  libcrypto.so.3      [.] fillblock
   1.82%  openssl  libcrypto.so.3      [.] strcmp@plt
   1.47%  openssl  libcrypto.so.3      [.] drbg_ctr_generate
   1.47%  openssl  libcrypto.so.3      [.] cipher_hw_aesni_ecb
   1.14%  openssl  libcrypto.so.3      [.] trailingdata
   1.07%  openssl  libcrypto.so.3      [.] OSSL_PARAM_set_uint64

this PR (16384)
  51.91%  openssl  libcrypto.so.3      [.] aesni_ctr32_encrypt_blocks
   6.49%  openssl  libc-2.17.so        [.] __strcmp_sse42
   5.39%  openssl  libc-2.17.so        [.] __memset_sse2
   4.45%  openssl  libcrypto.so.3      [.] aesni_ecb_encrypt
   3.54%  openssl  libcrypto.so.3      [.] EVP_CIPHER_block_size
   3.23%  openssl  libcrypto.so.3      [.] OSSL_PARAM_locate
   2.56%  openssl  libcrypto.so.3      [.] aesni_set_encrypt_key
   1.65%  openssl  libcrypto.so.3      [.] cipher_generic_block_update
   1.42%  openssl  libcrypto.so.3      [.] OPENSSL_cleanse
   1.41%  openssl  libpthread-2.17.so  [.] pthread_rwlock_unlock
   1.38%  openssl  libcrypto.so.3      [.] cipher_generic_get_params
   1.21%  openssl  libcrypto.so.3      [.] EVP_EncryptUpdate
   1.19%  openssl  libpthread-2.17.so  [.] pthread_rwlock_wrlock

The overhead of managing 2 EVP contexts instead of one (ECB and CTR) makes this PR slower than master for generate operations < ~250 bytes. Afterwards, there is a performance gain, but its several dimensions smaller that the old PR's which used the low level interfaces. The high amounts of strcmp catches the eye but even if that could be reduced its still a lot of overhead: aes HW has become so fast these days that even a deep callstack is payed with >1% per frame.

Hopefully #10461 will get rid of the EVP_CIPHER_block_size() performance issue..

Updated the performance data with fixup included. Looks slightly better.

Combining multiple EVP_EncryptUpdate calls improves the rand generation performance by 30%. The code changes is available here.

But still seems like a factor 2 slower than the original PR.

@raja-ashok  may i push your commit to this branch such that it is included in this PR ?

@p-steuer Yes please.

pushed raja's optimization and a small strict-warnings fixup and updated my second post with performance numbers and sampling results (https://github.com/openssl/openssl/pull/10461 not included, i ll do that once its merged and this PR rebased).
Perf looks strictly better than current master. However, small chunks are still a lot slower than old master (for small chunks) and my old PR. Lets see how it looks after   https://github.com/openssl/openssl/pull/10461 is merged.

Merged https://github.com/openssl/openssl/pull/ (was "ready to merge") and rebased this one.
Updated performance numbers and sampling data in my second post.

@raja-ashok test_rand fails with your changes. Looking into it.

Pushed a fixup. Test suite should be passed now. I had to undo the changes to ctr_df to make it work. Updated second post numbers.

So is this ready to be reviewed, it's still marked as WIP, or do you intend to make other changes?

I intend to add a test case for counter wrapping. Otherwise the code itself is ready to be reviewed. Removing the WIP .

Good work with the speedup.
I think this code could do with some general comments - to make it obvious that you are still following the steps required to do the algorithm for DRBG-CTR.

ping @p-steuer

Simplyfied code a little, squashed everything and added a test case for 32-bit counter wrap.
@slontis , @mspncp  okay , i ll add some comments
.. and i ll provide some final performance numbers.

think travis fails (evp tests fail) are not due to this PR.

Rebased and put an extensive description of the changes in the commit message (I chose this option over putting comments in the code because i found the present code base to already deviate from the standards exact pseudo code).
I ll provide some perf data tomorrow and this should be ready to go.

type             16 bytes     64 bytes    256 bytes   1024 bytes   8192 bytes  16384 bytes

x86_64 (CPUINFO: OPENSSL_ia32cap=0x7ffaf3ffffebffff:0x29c6fbf)
rand pre -patch     10049.06k    37961.03k   125751.81k   296885.25k   485537.11k   518548.14k
rand post-patch      9492.44k    37744.90k   122006.19k   507212.80k  2046580.05k  2672421.55k

s390 (z15)
rand pre -patch         7577.56k    27961.56k    88870.05k   192584.85k   294301.02k   305119.23k
rand post-patch        8381.95k    33294.24k   131116.87k   514722.31k  3110873.25k  4649911.60k

For small sizes, the overhead (strcmp,malloc..) of managing 2 ctx seems to eat up the theoretic perf. gain, at least for x86 (samples from x86_64, 16 byte size):
pre patch
  17.56%  openssl  libcrypto.so.3      [.] aesni_ecb_encrypt
   9.44%  openssl  libcrypto.so.3      [.] cipher_generic_block_update
   7.02%  openssl  libcrypto.so.3      [.] aesni_set_encrypt_key
   5.85%  openssl  libcrypto.so.3      [.] EVP_EncryptUpdate
   5.13%  openssl  libpthread-2.17.so  [.] pthread_rwlock_unlock
   4.20%  openssl  libcrypto.so.3      [.] OPENSSL_cleanse
   3.63%  openssl  libpthread-2.17.so  [.] pthread_rwlock_wrlock

post patch
   8.97%  openssl  libc-2.17.so        [.] _int_malloc
   8.50%  openssl  libcrypto.so.3      [.] aesni_set_encrypt_key
   5.95%  openssl  libc-2.17.so        [.] __strcmp_sse42
   5.75%  openssl  libpthread-2.17.so  [.] pthread_rwlock_unlock
   5.35%  openssl  libpthread-2.17.so  [.] pthread_rwlock_wrlock
   5.17%  openssl  libcrypto.so.3      [.] OPENSSL_cleanse
   5.14%  openssl  libcrypto.so.3      [.] ctr_update
   5.13%  openssl  libcrypto.so.3      [.] EVP_CIPHER_CTX_key_length
   3.56%  openssl  libcrypto.so.3      [.] _aesni_encrypt3
   3.09%  openssl  libcrypto.so.3      [.] EVP_CIPHER_CTX_reset
   3.05%  openssl  libcrypto.so.3      [.] aesni_ecb_encrypt
   2.99%  openssl  libcrypto.so.3      [.] OSSL_PARAM_locate
   2.82%  openssl  libcrypto.so.3      [.] cipher_generic_block_update

The x86_64 timings are a bit worrying.
I'm guessing but I'd expect small generations to be common.

I'm guessing but I'd expect small generations to be common.

yes, that also bothers me. id like to be strictly better with this PR in all cases. i ll see what i can do

#11102 is probably also going to help, I guess I should merge that.
I have some other ideas, but didn't find the time for them yet.

Can you explain where the malloc and strcmp come from?

I see a lot of calls to drbg_ctr_uninstantiate()?

@p-steuer which performance tool are you using to obtain the function-level statistics?

linux perf tools: https://perf.wiki.kernel.org/index.php/Main_Page
For example:
perf record <some command>
perf report # shows function level statistics

@kroeckx here are the expanded call-graphs for malloc and strcmp:
+   86.92%     0.00%  openssl  openssl             [.] _start                                                                                ◆
+   86.92%     0.00%  openssl  libc-2.17.so        [.] __libc_start_main                                                                                ▒
+   86.92%     0.00%  openssl  openssl             [.] main                                                                                ▒
+   86.91%     0.02%  openssl  openssl             [.] speed_main                                                                                ▒
+   86.90%     0.00%  openssl  openssl             [.] do_cmd                                                                                ▒
+   82.14%     0.17%  openssl  libcrypto.so.3      [.] RAND_DRBG_bytes                                                                                ▒
+   81.34%     0.37%  openssl  libcrypto.so.3      [.] RAND_DRBG_generate                                                                                ▒
+   81.01%     0.45%  openssl  libcrypto.so.3      [.] drbg_ctr_generate                                                                                ▒
+   76.70%     4.97%  openssl  libcrypto.so.3      [.] ctr_update                                                                                ▒
+   54.62%     2.51%  openssl  libcrypto.so.3      [.] EVP_CipherInit_ex                                                                                ▒
+   14.99%     0.53%  openssl  libcrypto.so.3      [.] CRYPTO_zalloc                                                                                ▒
+   13.22%     4.25%  openssl  libcrypto.so.3      [.] EVP_CIPHER_CTX_key_length                                                                                ▒
+   11.83%     0.00%  openssl  libc-2.17.so        [.] __GI___libc_malloc (inlined)                                                                                ▒
+   11.43%     3.00%  openssl  libcrypto.so.3      [.] EVP_CIPHER_CTX_reset                                                                                ▒
+   11.09%     1.91%  openssl  libcrypto.so.3      [.] EVP_EncryptUpdate                                                                                ▒
-   10.72%    10.72%  openssl  libc-2.17.so        [.] _int_malloc                                                                                ▒
   - 10.16% _start                                                                                ▒
        __libc_start_main                                                                                ▒
      - main                                                                                ▒
         - 10.16% do_cmd                                                                                ▒
              speed_main                                                                                ▒
              RAND_DRBG_bytes                                                                                ▒
              RAND_DRBG_generate                                                                                ▒
              drbg_ctr_generate                                                                                ▒
              ctr_update                                                                                ▒
            - EVP_CipherInit_ex                                                                                ▒
               - 6.33% aes_256_ecb_newctx                                                                                ▒
                    CRYPTO_zalloc                                                                                ▒
                    __GI___libc_malloc (inlined)                                                                                ▒
                    _int_malloc                                                                                ▒
               - 3.83% aes_256_ctr_newctx                                                                                ▒
                    CRYPTO_zalloc                                                                                ▒
                    __GI___libc_malloc (inlined)                                                                                ▒
                    _int_malloc                                                                                ▒
     0.56% _int_malloc                                                                                ▒
+   10.66%     1.34%  openssl  libcrypto.so.3      [.] cipher_generic_get_ctx_params                                                                                ▒
+   10.51%     2.81%  openssl  libcrypto.so.3      [.] OPENSSL_init_crypto                                                                                ▒
+   10.39%     0.47%  openssl  libcrypto.so.3      [.] engine_table_select_int                                                                                ▒
+    9.90%     2.90%  openssl  libcrypto.so.3      [.] OSSL_PARAM_locate                                                                                ▒
+    9.57%     0.35%  openssl  libcrypto.so.3      [.] aes_256_ecb_newctx                                                                                ▒
+    8.99%     0.55%  openssl  libcrypto.so.3      [.] cipher_hw_aesni_initkey                                                                                ▒
+    8.81%     2.61%  openssl  libcrypto.so.3      [.] cipher_generic_block_update                                                                                ▒
+    8.50%     8.50%  openssl  libcrypto.so.3      [.] aesni_set_encrypt_key                                                                                ▒
+    8.50%     0.00%  openssl  libcrypto.so.3      [.] __aesni_set_encrypt_key (inlined)                                                                                ▒
+    6.71%     0.79%  openssl  libcrypto.so.3      [.] aes_256_ctr_newctx                                                                                ▒
-    6.55%     6.55%  openssl  libc-2.17.so        [.] __strcmp_sse42
     6.54% _start                                                                                ▒
        __libc_start_main                                                                                ▒
        main                                                                                ▒
        do_cmd                                                                                ▒
        speed_main                                                                                ▒
        RAND_DRBG_bytes                                                                                ▒
        RAND_DRBG_generate                                                                                ▒
      - drbg_ctr_generate                                                                                ▒
         - 5.60% ctr_update                                                                                ◆
              EVP_CipherInit_ex                                                                                ▒
              EVP_CIPHER_CTX_key_length                                                                                ▒
              cipher_generic_get_ctx_params                                                                                ▒
              OSSL_PARAM_locate                                                                                ▒
              __strcmp_sse42                                                                                ▒
         - 0.94% EVP_CipherInit_ex                                                                                ▒
              EVP_CIPHER_CTX_iv_length                                                                                ▒
              cipher_generic_get_ctx_params                                                                                ▒
              OSSL_PARAM_locate                                                                                ▒
              __strcmp_sse42                                                                                ▒
+    5.94%     0.57%  openssl  libcrypto.so.3      [.] cipher_hw_aesni_ecb                                                                                ▒
+    5.87%     0.53%  openssl  libcrypto.so.3      [.] CRYPTO_clear_free                                                                                ▒
+    5.76%     0.21%  openssl  libcrypto.so.3      [.] CRYPTO_THREAD_unlock                                                                                ▒
+    5.58%     2.39%  openssl  libcrypto.so.3      [.] aesni_ecb_encrypt                                                                                ▒
+    5.55%     5.55%  openssl  libpthread-2.17.so  [.] pthread_rwlock_unlock                                                                                ▒
+    5.55%     0.00%  openssl  libpthread-2.17.so  [.] __GI___pthread_rwlock_unlock (inlined)                                                                                ▒
+    5.54%     5.54%  openssl  libcrypto.so.3      [.] OPENSSL_cleanse                                                                                ▒
+    4.83%     0.08%  openssl  libcrypto.so.3      [.] RAND_bytes_ex                                                                                ▒
+    4.58%     0.54%  openssl  libcrypto.so.3      [.] CRYPTO_THREAD_write_lock                                                                                ▒
+    4.05%     0.00%  openssl  libpthread-2.17.so  [.] __GI___pthread_rwlock_wrlock (inlined)                                                                                ▒
+    4.04%     4.04%  openssl  libpthread-2.17.so  [.] pthread_rwlock_wrlock                                                                                ▒
+    3.59%     1.50%  openssl  libcrypto.so.3      [.] ctr_BCC_update.part.2                                                                                ▒
+    3.34%     0.10%  openssl  libcrypto.so.3      [.] OPENSSL_CTX_get0_public_drbg                                                                                ▒
+    3.26%     0.15%  openssl  libcrypto.so.3      [.] openssl_ctx_get_data                                                                                ▒
+    3.14%     3.14%  openssl  libcrypto.so.3      [.] _aesni_encrypt3                                                                                ▒
+    2.48%     2.48%  openssl  libc-2.17.so        [.] _int_free                                                                                ▒
+    2.47%     2.47%  openssl  libc-2.17.so        [.] __memset_sse2                                                                                ▒
+    2.18%     0.61%  openssl  libcrypto.so.3      [.] EVP_CIPHER_CTX_iv_length

So I tried 'valgrind --tool=callgrind ./apps/openssl speed -bytes 16 rand',
and it showed for 14147 calls to RAND_bytes():
%self called function
8.90  77813  _int_malloc
7.39  85014  OPENSSL_cleanse
6.90  56614  ctr_BCC_block.isra.0
6.27  70760  aesni_set_encrypt_key
4.10  424570 OSSL_PARAM_locate
3.88  127372 cipher_generic_block_update
3.41  427106 __strcmp_sse2_unaligned
3.04  77812  _int_free
3.03  84910  EVP_CipherInit_ex
3.02  141522 EVP_EncryptUpdate
2.89  28302  ctr_XOR.part.0
2.61  70897  OPENSSL_init_crypto
2.59  84916  _aesni_encrypt3
2.40  127372 aesni_ecb_encrypt
1.95  101610 _memset_sse2_unaligned
1.81  28302  ctr_update
[...]

The problem was that I used EVP_CipherInit_ex with a non-null cipher argument even when updating the key/iv. This lead to the cipher objects being erased and re-allocated on every call.
Now that its fixed, the theoretical perf. gain shows up also at smaller sizes:
x86_64
type          16 bytes     64 bytes    256 bytes   1024 bytes   8192 bytes  16384 bytes
rand pre      11174.77k    41708.71k   136128.51k   321467.73k   536630.61k   559355.22k
rand post     16731.10k    64872.32k   237013.85k   794792.96k  2609661.60k  3103227.90k

(#11102 was already included for above measurement. It helps both pre- and post- perf perf.)

red cross due to timeouts

So i think this one is ready to go. Please re-review.

One of the Travis jobs timed out in test_rand_extra so probably the number of data generated in this test should be reconsidered.

I adressed the uint8_t -> unsigned char thing, disabled 2/3 test vectors in test_rand_extra to decrease runtime and rebased.

this time travis red cross looks unrelated to this PR

One build still timed out, so I included the test case in rand_test but commented it out.

hmm the build time outs at fuzz test now, dont know why.

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests.  Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

merged.
master: 28bdbe1aaa474ae8cd83e520d02e463e46ce89d9 4d6d787c4937706676355ce241c6e538475295d2


Added AUTHORS_NG.rst

In our last meeting, it was recommended to add a new authors file for Kytos-ng. I've added a section describing our team, authors, and contributors we've had in version 2022.1, I suppose this way it makes clearer who currently is part of the team maintaining Kytos-ng. If you have any other suggestions or want to change any other personal detail, please let us know.

Shouldn't Daniela and Luis be included as contributors?

Included here https://github.com/kytos-ng/kytos/pull/170/commits/7b156e979896917da40e444ad4a5ca2db70c411d

LGTM

Appreciated your review, Antonio.


An instance of analyzer DataBuilderGenerator cannot be created

I would like to try out your Source Generator. I got the following warning in Visual Studio 16.8 on a project running .NET 5. The generation of a Builder does not seem to work.
Warning	CS8032	An instance of analyzer DasMulli.DataBuilderGenerator.DataBuilderGenerator cannot be created from <path>/DasMulli.DataBuilderGenerator.dll: Method 'Initialize' in type 'DasMulli.DataBuilderGenerator.DataBuilderGenerator' from assembly 'DasMulli.DataBuilderGenerator, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' does not have an implementation..	My.UnitTests		1	Active	System.TypeLoadException: Method 'Initialize' in type 'DasMulli.DataBuilderGenerator.DataBuilderGenerator' from assembly 'DasMulli.DataBuilderGenerator, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' does not have an implementation.
   at System.Reflection.RuntimeAssembly.GetType(RuntimeAssembly assembly, String name, Boolean throwOnError, Boolean ignoreCase, ObjectHandleOnStack type)
   at System.Reflection.RuntimeAssembly.GetType(String name, Boolean throwOnError, Boolean ignoreCase)
   at Microsoft.CodeAnalysis.Diagnostics.AnalyzerFileReference.Extensions`1.GetAnalyzersForTypeNames(Assembly analyzerAssembly, IEnumerable`1 analyzerTypeNames, Boolean& reportedError)

My Package Reference is added in the same way you described in the Readme.
<PackageReference Include="DasMulli.DataBuilderGenerator" Version="*" PrivateAssets="All" />

Hi! Yes there has been a breaking change between the preview tooling shipped in 16.7 and 16.8. There is already a 2.0.0-preview package available that adapted to that API change. (AFAIK NuGet now supports *-* as version b/c * won‘t give you this version...).


[Bug]: Unresolvable type reference or unsupported built-in utility type

Reproduction
Using inertiajs Vue with Laravel
Describe the bug
I am getting the below error:
[plugin:vite:vue] [@vue/compiler-sfc] Unresolvable type reference or unsupported built-in utility type
resources/js/Components/ui/drawer/Drawer.vue
4  |  import { useForwardPropsEmits } from 'radix-vue'
5  |
6  |  const props = withDefaults(defineProps(), {
|                                         ^^^^^^^^^^^^^^^
7  |    shouldScaleBackground: true,
8  |  })
System Info
as above

Contributes

[ ] I am willing to submit a PR to fix this issue
[ ] I am willing to submit a PR with failing tests

here is the error screenshot, it was all working all sudden it start throwing this error.

@Rukhsar could you provide minimal reproduction?

Same problem, just started a project and run npx shadcn-vue@latest add, toggle all, fails

@Rukhsar You have to set "typescript": true in your components.json file.