Structural changes to make subclassing spiders easier

MappingSpider is an extension of FilterSpider that creates filters for the spider based on the start_urls attribute.  By subclassing MappingSpider, we can create spiders in a manner similar to spiders
extended from CustomSpider.  However, instead of targeting specific URLs for conversion into PageItems, we instead pass URLs into FilterSpider's parse method, which treats those URLs as starting points for further crawling.
For certain sites, particularly sites where the path to syllabi is mostly GET requests behind a handful of form elements and/or POST requests, or sites where syllabi and other important information are distributed in odd ways, creating mappers can be more productive than creating custom spiders.
Lots of words for a tiny addition; the current implementation of this is actually simpler than I was originally thinking.  What I have here should work, though it is hard to properly test - I've added a mapper as an example.  I do have some concerns about how the filters are made, where they should be made and what they're made from, but those relate to structural questions about the repository as a whole that we may want to address later rather than sooner.  In any case, I think this code should be open for discussion.

@HarrisonGregg I added start_requests to MappingSpider.  Does the documentation I have look okay?

This looks like the right approach, I'm glad it was so
Let's move make_params() https://github.com/opensyllabus/osp-scraper/blob/master/osp_scraper/tasks.py#L33 to a top-level parameters.py. We'll have more of these eventually & we're using them outside tasks.py now, so it's time for a module.
The MappingSpider name was confusing to me. It's more like a PreambleSpider or PrefixSpider or something. Thoughts?

Sorry about the lite documentation.  When I was writing this, I felt the behavior was fairly straightforward, but I really should at least approach docstrings like was done in CustomSpider.
@wearpants I was thinking that working on this class was going to expose the need for some changes to the structure of the repository.  Should I open a ticket/pull request to discuss this issue separately?  I have some miscellaneous thoughts.
In terms of the name, I'm not super attached to MappingSpider.  I just chose it because it's the term we were using to discuss the idea (though I admit that even along those lines MapperSpider or MapSpider would be better).  One of the nice things about including the word 'map' is that it allows for sensible naming of the subclasses in a way that differentiates them from children of CustomSpider, e.g., class UTexasMapper(MappingSpider), whereas I don't feel like you could have quite the same thing with PreambleSpider or PrefixSpider.  On the other hand, though, I agree that something like PrefixSpider is more consistent with the language used in the project.

I elaborate in the docstrings.  Do they look alright now?
Also, quick thing I realized: I currently set ROBOTSTXT_OBEY to False (copy-paste from CustomSpider).  Is this problematic, given the broad crawls that each mapper may end up doing?  Or should we keep the setting and maybe use more restrictive filters?

I suppose it would be better not to ignore robots.txt by default.  There could be some sites that have a robots.txt that limits the crawling, but doesn't stop it altogether, that we want to respect.

I removed the ROBOTSTXT_OBEY setting.

Let's move make_params() https://github.com/opensyllabus/osp-scraper/blob/master/osp_scraper/tasks.py#L33 to a top-level parameters.py. We'll have more of these eventually & we're using them outside tasks.py now, so it's time for a module.

This still needs to happen.

@jodizzle @HarrisonGregg see the latest commit - I hoisted the file types to a class attribute, which makes FilterSpider easier to subclass. I think we can just extend start_requests in individual spiders, and so don't need a separate MappingSpider class.
I haven't had a chance to really test this, but I hope the intent makes sense.

@wearpants The bigger issue with subclassing FilterSpider directly is that currently FilterSpider doesn't actually create any filters itself.  This is part of the issue that MappingSpider is trying to solve.
However, I think I agree with you that there isn't that much of a need for a separate MappingSpider class.  Instead, we should just focus on refactoring the structure of FilterSpider and make_params.  Currently, adding something like
@classmethod
def from_crawler(cls, crawler, *args, **kwargs):
    spider = super().from_crawler(crawler, *args, **kwargs)
    spider.filters = make_params(getattr(cls, 'start_urs', []) + kwargs.get('start_urls', []))['filters']
    return spider

to FilterSpider would probably be sufficient, but I think the nature of make_params should be changed as well.  Rather than have a parameters.py, change make_params to just make_filters and move it into filterware.py, then edit any dependent pieces like bin/edu_repo_crawler.py accordingly.  Having a method like the current make_params that returns start_urls and allowed_file_types doesn't seem too helpful anyway.  Does that sound reasonable?

This sounds like the right direction, and would let us roll up customspider
as a filter spider subclass as well... Ill make some sketches in that
direction
On May 10, 2017 7:29 PM, "jodizzle"<EMAIL_ADDRESS>wrote:

@wearpants https://github.com/wearpants The bigger issue with
subclassing FilterSpider directly is that currently FilterSpider doesn't
actually create any filters itself. This is part of the issue that
MappingSpider is trying to solve.
However, I think I agree with you that there isn't that much of a need for
a separate MappingSpider class. Instead, we should just focus on
refactoring the structure of FilterSpider and make_params. Currently,
adding something like
@classmethoddef from_crawler(cls, crawler, *args, **kwargs):
spider = super().from_crawler(crawler, *args, **kwargs)
spider.filters = make_params(getattr(cls, 'start_urs', []) + kwargs.get('start_urls', []))['filters']
return spider
to FilterSpider would probably be sufficient, but I think the nature of
make_params should be changed as well. Rather than have a parameters.py,
change make_params to just make_filters and move it into filterware.py,
then edit any dependent pieces like bin/edu_repo_crawler.py accordingly.
Having a method like the current make_params that returns start_urls and
allowed_file_types doesn't seem too helpful anyway. Does that sound
reasonable?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/opensyllabus/osp-scraper/pull/79#issuecomment-300640736,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAe2ANMNolddAgOT8PJ4CqsaZsy2CXR8ks5r4khggaJpZM4NLBH3
.

@wearpants I pushed two commits that summarize what I was thinking.
One of the annoying parts of implementing start_requests in individual scrapers/mappers is that depth and hops_from_seed need to be set to 0, which is currently automated by start_requests in the superclasses.  So currently, either explicit setting of depth and hops_from_seed or something similar to this will be required in each mapper:
    def start_requests(self):
        for r in super().start_requests():
            r.callback = self.start_map
            yield r

This could probably be addressed by adding a method to FilterSpider or by some other structural changes.
I don't really see the value in making CustomSpider a subclass of FilterSpider like you suggest, since CustomSpider instances do no filtering and several of the CustomSpider methods they make use of seem pretty distinct.  What would CustomSpider inherit from FilterSpider?

I can see both sides for whether CustomSpider should subclass FilterSpider.  If it did, that would allow us to not distinguish between "mappers" and full custom spiders.  Mappers would just be custom spiders that used parse from FilterSpider as a callback.  The potential problems I see are in regards to filters.  If we left custom scrapers set the filters to allow all, then a "mapper" would need to change the filters somehow so the scraper didn't get out of control.  If we don't leave custom scrapers as allow all, then we might need to change existing ones somehow so they don't break.

@HarrisonGregg , that's pretty much what I'm thinking re: "mappers" using parse from FilterSpider.
Maybe we add a method to FilterSpider that generates the filters, so that it could be extended/overridden in subclasses. Something like:
    @classmethod
    def from_crawler(cls, crawler, *args, **kwargs):
        spider = super().from_crawler(crawler, *args, **kwargs)
        spider.filters = cls.make_filters(spider.start_urls)
        return spider

    @classmethod
    def make_filters(cls, start_urls):
        ...
        return filters

Thoughts?

Alternatively, we could just put an allow_all flag in FilterSpider.  FilterSpider would set it to False, CustomSpider would set it to True, and mappers subclassing CustomSpider would set it to False again.

Another option I considered was modify the pipelines to treat the absence of a .filter attribute on a spider as an "allow all" flag or always-true-filter. This would also let the pipeline play nice with other 3rd-party spiders. Needs more investigation though.

I pushed some more commits that I think address the miscellaneous suggestions.
This PR is pretty old and broad at this point, so I suggest that we freshen things up and keep the history clean by breaking it into several new PRs:

One PR to address the moving of make_params -> make_filters and the related changes that streamline the filter creation process and remove unnecessary bits like url_to_prefix_params.  (This could be two PRs, depending on how it was done).  These changes should be mostly accomplished by the commits on this branch, and so we could just transplant that work to a new branch.
One PR to change the class hierarchy of the spider classes in order to make room for the mapping spider idea.  This would still need substantial decision making.

Regarding the second bullet, the main (but not definitive) idea that seems to have surfaced (starting at @HarrisonGregg's comment) is that we should have CustomSpider inherit from FilterSpider, and have mappers just be subclasses of CustomSpider that callback to the FilterSpider parse method and crawl according to a set of filters.  How to best accomplish this still needs some discussion; a couple approaches have been suggested in the comments.
Thoughts on this plan?

sounds good
On Mon, Jun 19, 2017 at 8:47 AM, jodizzle<EMAIL_ADDRESS>wrote:

I pushed some more commits that I think address the miscellaneous
suggestions.
This PR is pretty old and broad at this point, so I suggest that we
freshen things up and keep the history clean by breaking it into several
new PRs:

One PR to address the moving of make_params -> make_filters and the
related changes that streamline the filter creation process and remove
unnecessary bits like url_to_prefix_params. (This could be two PRs,
depending on how it was done). These changes should be mostly accomplished
by the commits on this branch, and so we could just transplant that work to
a new branch.
One PR to change the class hierarchy of the spider classes in order
to make room for the mapping spider idea. This would still need substantial
decision making.

Regarding the second bullet, the main (but not definitive) idea that seems
to have surfaced (starting at @HarrisonGregg
https://github.com/harrisongregg's comment
https://github.com/opensyllabus/osp-scraper/pull/79#issuecomment-302301045)
is that we should have CustomSpider inherit from FilterSpider, and have
mappers just be subclasses of CustomSpider that callback to the
FilterSpider parse method and crawl according to a set of filters. How to
best accomplish this still needs some discussion; a couple approaches have
been suggested in the comments.
Thoughts on this plan?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/opensyllabus/osp-scraper/pull/79#issuecomment-309429243,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAe2ADAj1OZyGgWAqSqPn0e8aV4JbM2kks5sFm3fgaJpZM4NLBH3
.


Submission History reads azure storage table when report not found in postgresql database

User Story
As a sender to the new submissions api
I want to use the submissions history api,
so that I can view the history for all successful and failed submissions.
Description/Use Case
The submissions api does not connect to the postgresql database. Instead, it inserts to a table in the azure storage account. That table has information includes submission status and details which could include error information. The information in that table should be used in the submission history response.
Dev Notes
The submissions api currently inserts to the submission table in the azure storage account(not in postgresql) and uploads a file to the blob storage. Then a queue message is added to the FHIRReceive queue. The current submission history expects records to exist for action and report_file. Since the submission micro service does not connect to postgresql it cannot verify the client_id supplied in the submission. The FHIRReceive step does the verification. If a sender is not found, then no record is made of the submission in postgresql. The only records are in the storage account table.
With that in mind, the submission history needs to be updated to review that table when no report exists in the postgresql database.
Acceptance Criteria

[ ] When a report is not in postgresql the submission history responds appropriately with detail from submission table

Hey team! Please add your planning poker estimate with Zenhub @adegolier @arnejduranovic @brick-green @david-navapbc @jack-h-wang @jalbinson @mkalish @thetaurean


nan_to_num

Hi everyone,
when extracting the pointcloud I often see formulations where the np.nan_to_num function is applied to the xyz values.
For example here https://github.com/zivid/zivid-python-samples/blob/master/source/sample_utils/display.py#L54-L93 in line 59.
 xyz = np.nan_to_num(xyz).reshape(-1, 3)
Why is this approach chosen?
Would it not make sense to simply delete those nan values?
In my code I went for this version:
    frame = zivid.Frame(path)
    point_cloud = frame.point_cloud()
    xyz = pointcloud.copy_data("xyz") # Get point coordinates as [Height,Width,3]
    rgba = pointcloud.copy_data("rgba") # Get point colors as [Height,Width,4]
    rgb = rgba[:, :, 0:3]
    xyz = np.nan_to_num(xyz).reshape(-1, 3)
    zero_index = np.where((xyz[:,0]!=0 ) & (xyz[:,1]!=0 ) & (xyz[:,2]!=0 ) == True ) #remove zero values
    xyz = xyz[zero_index]
    rgb = rgb.reshape(-1, 3)
    rgb = rgb[zero_index]

Is there a reason for your approach to keep them as zero values or do you have a better idea than mine?
Thank you!

Hi @christinaionescu, thanks for taking an interest in our code! This code is intended for use with our Zivid 3D cameras which produce an organized point cloud, including color. We usually want to maintain the organization to simplify lookup between the 2D image and 3D-coordinates. The reason we use nan_to_num is that some external tools, such as Open3D visualization, don't support nan-values.
Zero is a useful value as it's impossible to get a point inside the camera (in the camera origin). For visualization I agree that it's a bit silly to keep these values, and indeed we remove the organization when we reshape to a list of coordinates.

Hi,
yes I completely understand why you do it this way if the organization is relevant.
In my case I want to perform pointcloud registration so I reshape it anyways to transform the data to a pointcloud. Here, it can influence the pointcloud registration algorithm if I have many points set to zero instead of just deleting them. This is why it was relevant to me :)
Thank you for your answer and best regards

That makes perfect sense! Thanks :)


Istio ingress static IP support for GCP

After applying this ingress resource in a GKE cluster,
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: static-ip
  # Assumes a global static ip with the same name exists.
  # You can acquire a static IP by running
  # gcloud compute addresses create test-ip --global
  annotations:
    kubernetes.io/ingress.global-static-ip-name: "test-ip"
    kubernetes.io/ingress.class: "istio"
spec:
  tls:
  # This assumes istio-ingress-certs exist with tls.key and tls.crt
  - secretName: istio-ingress-certs
  backend:
    # This assumes http-svc exists and routes to healthy endpoints.
    serviceName: http-svc
    servicePort: 80

The address returned by kubectl get ing static-ip seem to depend on the ephemeral external ip of the istio-ingress service but is different from the gcloud provisioned test-ip. My expected behavior is for the ingress controller to use the global-static-ip-name test-ip.

@ayj this is a GCP issue, can you comment?

kubernetes.io/ingress.global-static-ip-name is not supported by Istio ingress controller.

Are there workarounds for this? Seems pretty limiting to not be able to use static IP with Istio ingress.

@vaikas-google the work around is to go in the cloud management UI and switch the ip from ephemeral to static after the ingress is up
for instance:

Aha, ok, thanks!
On Thu, Feb 22, 2018 at 6:10 PM Laurent Demailly<EMAIL_ADDRESS>wrote:

@vaikas-google https://github.com/vaikas-google the work around is to
go in the cloud management UI and switch the ip from ephemeral to static
after the ingress is up
for instance:
[image: screen shot 2018-02-22 at 6 09 21 pm]
https://user-images.githubusercontent.com/3664595/36574666-a9693d4e-17fb-11e8-8a79-af87d8a8a19c.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/1024#issuecomment-367887900, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AKwedOA1LN6HwBy-Odp6Hc4sL8tnVguvks5tXh4kgaJpZM4Pt3KL
.

Can we also add the kubernetes.io/ingress.global-static-ip-name ? ( in the
helm templates, where
it can be set in values.yaml ). Probably P2 since we have a workaround -
which should be documented.
On Fri, Feb 23, 2018 at 7:27 AM, Ville Aikas<EMAIL_ADDRESS>wrote:

Aha, ok, thanks!
On Thu, Feb 22, 2018 at 6:10 PM Laurent Demailly<EMAIL_ADDRESS>
wrote:

@vaikas-google https://github.com/vaikas-google the work around is to
go in the cloud management UI and switch the ip from ephemeral to static
after the ingress is up
for instance:
[image: screen shot 2018-02-22 at 6 09 21 pm]
<https://user-images.githubusercontent.com/3664595/
36574666-a9693d4e-17fb-11e8-8a79-af87d8a8a19c.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/1024#issuecomment-367887900, or
mute
the thread
<https://github.com/notifications/unsubscribe-auth/AKwedOA1LN6HwBy-
Odp6Hc4sL8tnVguvks5tXh4kgaJpZM4Pt3KL>
.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/1024#issuecomment-368040466, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAFI6tSm68mDN8qGQXZX9r0RozLAG2Q1ks5tXtjRgaJpZM4Pt3KL
.

We need to support it before we add it, no?

@denseidel Not sure if that what you're asking, but if you just want to attach an existing (regional) static IP address to your istio-ingress, you can add spec.loadBalancerIP to your istio-ingress service. More info in Kubernetes docs: https://kubernetes.io/docs/concepts/services-networking/service/#type-loadbalancer
If you use the Helm chart to deploy Istio, these are the changes that are needed to be made (link to  a commit in my fork of the Istio Helm chart): https://github.com/exekube/charts/commit/5fc335371bf799b795cf0547b3504fb4626d24b3
@ldemailly should I submit a PR with the changes to the Helm chart? The feature is very useful for having an ephemeral cluster with a permanent static IP address (and permanent DNS records for it).

Yes please!

https://github.com/istio/istio/pull/4955 has been merged ✅
You can now reserve a regional static IP address (https://cloud.google.com/compute/docs/ip-addresses/reserve-static-external-ip-address), then bind it to Istio ingress service like this:
# values.yaml
ingress:
  enabled: true
  ...
  service:
    loadBalancerIP: <IP_ADDRESS> # (your static IP address)

that's great progress, thanks, any way to do it by the name of the reserved ip instead of the actual address ?

Can anyone give a link for example YAML on how to use istio ingress in GKE with static IP? I've already tried with regional static IP, no success.

Google has documentation on how to change the IP of LB provisioned with Istio on GKE clusters using the addon: https://cloud.google.com/anthos/gke/docs/on-prem/archive/1.1/how-to/add-ons/istio#configure_an_external_ip_address
Which is basically patching the istio-ingressgateway:
kubectl patch service istio-ingressgateway --patch '{"spec":{"loadBalancerIP": "<STATIC_IP>"}}' --namespace istio-system

For those using Terraform, my workaround is to patch the gateway using the local-exec provisioner and kubectl. Not pretty but functional (based on https://github.com/hashicorp/terraform-provider-kubernetes/issues/723#issuecomment-669350926):
resource "null_resource" "istio-load-balancer-ip-patch" {
  provisioner "local-exec" {
    command = <<EOH
cat >/tmp/ca.crt <<EOF
${base64decode(google_container_cluster.my_cluster.master_auth[0].cluster_ca_certificate)}
EOF
  kubectl \
  --server="https://${google_container_cluster.my_cluster.endpoint}" \
  --token="${data.google_client_config.default.access_token}" \
  --certificate_authority=/tmp/ca.crt \
  patch service istio-ingressgateway --patch '{"spec":{"loadBalancerIP": "${var.istio_load_balancer_ip}"}}' --namespace istio-system
EOH
  }
}


Update Co-role groups and the last three

Co Role

Co Agent Patient - Co Patient Agent
Co Agent Instrument - Co Instrument Agent
Co Agent Result - Co Result Agent
Co Patient Instrument - Co Instrument Patient
Co Result Instrument - Co Instrument Result

Participle
Pertainym
Derivation

Hi,
can you try and find examples were both words are in Princeton wordnet?   For example 'bread knife' instead of 'ice saw',   'pastry cook' instead of 'novel writer', ...   Also, 'guitar player' is in wordnet but has not been linked.
Then I think it will be good to go.

Hi,
can you try and find examples were both words are in Princeton wordnet? For example 'bread knife' instead of 'ice saw', 'pastry cook' instead of 'novel writer', ... Also, 'guitar player' is in wordnet but has not been linked.
Then I think it will be good to go.

But I cannot find guitar player in Princeton wordnet, it only returns guitarist... do you mena to link guitar player with guitarist?

It says "your query returned result".   So you did find a synset, which has
two words associated with it: 'guitarist' and 'guitar player'.   We choose
the most-frequent, shortest, unique name as the label so we call the
concept "guitarist", but it includes both 'guitarist' and 'guitar player'.
So please use it.
On Sat, Oct 31, 2020 at 3:34 PM yoyo-go<EMAIL_ADDRESS>wrote:

Hi,
can you try and find examples were both words are in Princeton wordnet?
For example 'bread knife' instead of 'ice saw', 'pastry cook' instead of
'novel writer', ... Also, 'guitar player' is in wordnet but has not been
linked.
Then I think it will be good to go.
But I cannot find guitar player in Princeton wordnet, it only returns
guitarist... do you mena to link guitar player with guitarist?
[image: image]
https://user-images.githubusercontent.com/56577574/97773790-bec74080-1b8d-11eb-93a0-f46f40fc7d12.png
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/globalwordnet/gwadoc/pull/53#issuecomment-719897355,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIPZRRKV7XTLACHBJXNDP3SNO4GTANCNFSM4S4WMSHA
.

--
Francis Bond http://www3.ntu.edu.sg/home/fcbond/
Division of Linguistics and Multilingual Studies
Nanyang Technological University

Got it! Example links are added now.
Seems like the branch has conflicts again, do I need to make a new PR just like last time did?

It says "your query returned result". So you did find a synset, which has two words associated with it: 'guitarist' and 'guitar player'. We choose the most-frequent, shortest, unique name as the label so we call the concept "guitarist", but it includes both 'guitarist' and 'guitar player'. So please use it.
…
On Sat, Oct 31, 2020 at 3:34 PM yoyo-go @.***> wrote: Hi, can you try and find examples were both words are in Princeton wordnet? For example 'bread knife' instead of 'ice saw', 'pastry cook' instead of 'novel writer', ... Also, 'guitar player' is in wordnet but has not been linked. Then I think it will be good to go. But I cannot find guitar player in Princeton wordnet, it only returns guitarist... do you mena to link guitar player with guitarist? [image: image] https://user-images.githubusercontent.com/56577574/97773790-bec74080-1b8d-11eb-93a0-f46f40fc7d12.png — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#53 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIPZRRKV7XTLACHBJXNDP3SNO4GTANCNFSM4S4WMSHA .
-- Francis Bond http://www3.ntu.edu.sg/home/fcbond/ Division of Linguistics and Multilingual Studies Nanyang Technological University

There are a few additions I want to make, so I will not close the issue yet.


pass state space matrices, instead of transfer function, in signal.lti()

sys_tf currently takes num & den arguments for constructing lti system in https://github.com/capsulecorplab/SwingPy/blob/45eef0141ff128fefdf9491fd5d4d4aafac1e35b/swingpy/dancer.py#L41
but should also be able to take state space matrices
"State Space matrices"
A = [[0,1],[-wn**2,-2*z*wn]]
B = [[0],[wn**2]]
C = A[0]
D = B[0]

(see signal.lti)
However, response dynamics are incorrect for sys = signal.lti(A,B,C,D)

Fixed issue as of https://github.com/capsulecorplab/SwingPy/commit/3bd219bd610b9f61abe6732559286b432854bff2
C-matrix should've been [1, 0] (position), instead of [0, 1] (velocity)


(maint) Ensure CI runs all module tests

This didn't actually work. AppVeyor's doing something funky.

CLA signed by all contributors.

Is this ready to go?

Might need a rebase. I'll double check.

Rebase looks clean. I pushed it up anyway.


[11.x] Add support for verbose exception messages in RequestException

Context:
In the current implementation, when a third-party service returns a long response message, Laravel's HTTP client automatically truncates the message in exceptions. While this is useful in many cases, it can be limiting when detailed information from the response is needed for debugging or logging purposes.
Changes Introduced:
This PR introduces a new feature that allows developers to choose whether they want the full response message or a truncated version when handling exceptions thrown by the HTTP client. The main changes include:

New Attribute isVerbose:
Added a boolean attribute isVerbose to the RequestException class, which determines if the exception message should include the full response body or a truncated summary.

New Method enableVerboseMessage in Response:
Introduced a method enableVerboseMessage() in the Response class, which allows developers to enable the verbose exception message mode.

Modified toException Method:
The toException() method in the Response class now passes the isVerbose flag when creating a RequestException instance, allowing the exception to contain the full message if verbosity is enabled.

Enhanced Exception Message Preparation:
Updated the prepareMessage() method in RequestException to conditionally include either a truncated summary or the full response body based on the isVerbose attribute.

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!


Flow to ask for help

STEP 1

Step 2

Step 3

Step 1 could be split into actions:

Sign-Up: fields from Ansprechpartner -> submit creates accounts in Firebase backend #45 -> forward to Step 3
Create request: fields from "Wo wird Hilfe gebraucht" -> submit creates new entry for account -> forward to Step 2

We could have another page for Login. For now could forward to the above "Create request" page on successful login. As @roblen45 can help us with the implementation of accounts in the backend now, it seems to be a good task to begin with.
What do you think?

Done with https://github.com/ImmunHelden/ImmunHelden.de/issues/45


[WFLY-19064][WFLY-19065] Update the EE 11 preview to use current EE 11 releases

https://issues.redhat.com/browse/WFLY-19064
https://issues.redhat.com/browse/WFLY-19065

/retest

/retest

/retest


Add commas to the example JSON

Noticed this when i copied some of the example code into my editor.
Just a quick fix:)

Thanks for taking care of this @chribjel !


Sound emoji logarithmic interpolation does not pass end frequency

The sound expression code is not passing the end frequency for logarithmic interpolation like it does with the other interpolation functions:
https://github.com/lancaster-university/codal-microbit-v2/blob/master/source/SoundExpressions.cpp#L226
However, the implementation is expecting it:
https://github.com/lancaster-university/codal-microbit-v2/blob/master/source/SoundSynthesizerEffects.cpp#L102
As a result sounds that use logarithmic interpolation either play as clicks or don't play at all.

@finneyj FYI

May be related to https://github.com/microsoft/pxt-microbit/issues/4720 - possibly not dealing with never reaching the end frequency?

Added an end frequency parameter as per the other interpolation options, see https://github.com/lancaster-university/codal-microbit-v2/blob/master/source/SoundExpressions.cpp#L228

See https://github.com/microsoft/pxt-microbit/issues/4720#issuecomment-1150483219 for more details, but I'm going to call this done for now.


Consider using functools.reduce instead of implementing your own _reduce()

source/code/configuration/instance_schedule.py implements _reduce()
According to https://docs.python.org/3.0/whatsnew/3.0.html#builtins , one should use functools.reduce instead.

As this code is currently designed for Python 2 we decided to go for this lightweight version independent implementation

I'm 90% sure functools.reduce works in Python 2

the 8 lines of Python we used to get the similar functionality work  100% in Python2 and reduce the footprint of another library and any version dependencies

functools.reduce is part of standard library since 2.6
If you need to support earlier versions, dismiss the issue.
If 2.6+ is OK for you, you definitely should use functools.reduce and stop copy+pasting between projects.

Thanks for your feedback. As mentioned before, we preferred to have the 8 lines of code rather than having the footprint of another library, as the code is only used internally in a single method and is not meant as a replacement for the reduce function in general.  If you think functool works better for you you can always fork the repository and use this library

footprint of another library

Irrelevant argument because it's standard library, as I mentioned: "functools.reduce is part of standard library since 2.6"

Thanks for for feedback, we’ll consider it for future development


CORS

Is there an existing issue for this?

[X] I have searched the existing issues

Package Version
0.2.9
Current Behavior
Access to fetch at 'https://cloudflare-eth.com/' from origin 'https://xxxx.vercel.app' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.
POST https://cloudflare-eth.com/ net::ERR_FAILED
Expected Behavior
Successfully read contract
Steps To Reproduce
const NFTId = () => {
  const provider = useProvider()
  const [{ data, error, loading }, read] = useContractRead(
    {
      addressOrName: '0xe538B351070C02d17b5878D3017932A68606fbaE',
      contractInterface: passABI,
      signerOrProvider: provider,
    },
    'totalSupply',
    {
      args: [0],
    }
  )
  console.log(data)
  return (

      {loading
        ?
        null
        : data}

  )
}

Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)
No response
Anything else?
No response

Hi! Can you create a CodeSandbox (template) with this or post the ABI?

I think I found the issue. The problem is that the web app failed to call the view function of the contract and the web app is keep retrying this. I found that useContractRead is set to default to read mainnet contract.
If I would like to read a contract from rinkeby, how should I configure it?

Set up the ethers.js provider so it is chain-aware.

I faced similar issue, I used useBlocknumber() to check if my app is connected to a correct chain.
For me I was running on mumbai testnet, it returns an undefined for block number. The solution was to follow configure chains' instruction, and add in chains that I wanted to connect, i.e. [chain.mainnet, chain.polygonMumbai], instead of feeding in custom RPC (error-prone).

My situation was caused by an old, broken RPC URL that was hard-coded.


How do I build this?

Tried emailing you but your account doesn't have obvious email address and user@github bounced because of "organizational settings"?
I cloned your "build llvm with musl" repo, but after reading the README I'm not entirely sure how to run the build? It seems to want me to download another one of your projects and... create a chroot to run it in maybe?
I have my own build script that was building a musl-based llvm Hexagon cross compiler (based off the build plumbing the Hexagon guys checked into the kvm test suite: their test involved building a compiler to build their vm image), but when I tried to run it again llvm died trying to link the rtsanitizer code to libc, which obviously didn't exist yet because you need a compiler to build the C library with. (There was also some discussion on the toybox mailing list about this in... July of last year, I think? I can dig up a link if you're curious.)
How do I build your toolchain project, and have you checked for regressions recently?
Rob

I also am also testing a new design of my s6+s6-rc bootscripts. S6 is hard to develop [for me] due to lack of examples and I couldn't setup a VM to test it faster.

I'm, um, weird.
https://landley.net/aboriginal/about.html
https://speakerdeck.com/landley/developing-for-non-x86-targets-using-qemu
https://landley.net/toybox/faq.html#mkroot
http://youtu.be/SGmtP5Lg_t0
https://www.youtube.com/watch?v=Sk9TatW9ino

I admit, CMLFS & MLFS are not for beginners. For CMLFS, begin the build by reading 0-Preparation in the top level of the repo directory.
I suggest doing a build of LFS first...which can then be used as the host to build CMLFS.


bug: Collection : last item not visible (RC version)

Type: bug
Platform: ios 8 webview
Hi,
I just updated the ionic version on my project and now have this bug :
I have a collection with items that having dynamic and different height. With the last version of ionic, the last item is not entirely visible. It just cut on the bottom. I can see it if I over scroll but not when I release the mouse.
note : the datas are loaded from a sqlite database = asynchronously
Thanks guys.

Greetings @Alkashi!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

Can you provide a demo of this?

Well, I have to extract a part of my huge app for this.
I'll try to make it quickly to provide it here as soon as it's done.
Thx.

Hi,
Sorry for the delay.
You can see what I mean in the chats tab here : http://houcin1.free.fr/dev/ionic/#/tab/chats
Each item has a different height
If you you scroll at the bottom you'll see that sometimes, its not entirely visible.
The ionic version used here is the 1.0.0-rc.2
Thanks in advance for your feedback

I have a similar problem. The last element of collection-repeat gets clipped.

Hmm, just tested this with the nightly builds and wasn't able to reproduce it. Could you verify that it was fixed there?

Greetings @Alkashi!
My sensors indicate a reply was requested, but we have not received one yet, I am using my robot powers to close this issue. However, if you are still experiencing this issue, please feel free to reopen it by creating a new issue, and include any examples or necessary information.
Thank you for allowing me to assist you.


Allow ActivityBar to be moved/undocked out of VSCode Window (To a 2nd Monitor)

Please allow the activity-bar to be undocked outside of theVSCode Window
so that we can move it to a separate monitor (left side monitor) and use the main monitor for code.
(I know we can toggle it visibility using (CMD+B) or collapse it, but we need it to be fully opened and to show its content but in a separate monitor.

/duplicate https://github.com/microsoft/vscode/issues/193267

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


feature #4092

making --debugfailed to continue it's work even if we suffix it with --fail

Hi @claudius96 !
Would you be interested in/have time to look into this? I'm cleaning up old PRs from the repo. Thank you for the work you put into this feature. :)


Clarification on Activity Log Data

The article mentions, "Two data types -- Usage and AzureActivity -- are retained for 90 days by default, and there is no charge for for this 90 day retention. These data types are also free from data ingestion charges."
Activity Log Data is retained for 90 days even outside of Log Analytics.  Can you confirm that Activity Log Data is stored in Log Analytics for 90 days regardless if your current retention is set to 30 days?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a73a8a62-95c6-9ec9-9199-695ad1e5e8a9
Version Independent ID: 6089f013-8b5b-661c-9ee4-d6b267737357
Content: Manage usage and costs for Azure Monitor Logs
Content Source: articles/azure-monitor/platform/manage-cost-storage.md
Service: azure-monitor
GitHub Login: @MGoedtel
Microsoft Alias: magoedte

Thanks for your comment. The feedback has been shared with the content owner for further review. Thanks for your patience.

@ElanShudnow - I can confirm that this information is correct even though it defies logic :)  I had similarly asked the PG this early on and the docs are correct.  Hope that helps.  #please-close


Refactor reference implementation of pooling.cc

share code with the cmsis implementation
groundwork needed to add in Xtensa implementation

BUG=https://github.com/tensorflow/tflite-micro/issues/205

Tagging @bhanuprakashbv @nyadla-sys @vp-cad @SJOSHI768


Incorrect Cred id on send_presentation on Admin API is returning a 500 Internal Server Error

Issue
Tested thought the Admin API and setup and sent through the send-presentation operation, where the cred_id is incorrect for the credential.
{
   "presentation": {
      "comment": "This is a comment for the send presentation.",
      "requested_attributes": {
         "address_attrs": {
            "cred_type_name": "Schema_DriversLicense",
            "revealed": true,
            "cred_id": "d413f359-9595-4ab6-94cf-1aa191d2c884"
         }
      }
   }
}

Outcome
The response from the Admin API is 500 Internal Server Error.
However, the logs in the agent is showing the errors below.
2020-08-26 22:04:38,911 aries_cloudagent.core.dispatcher ERROR Handler error: presentation_exchange_send_presentation
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/aries_cloudagent/holder/indy.py", line 275, in get_credential
    self.wallet.handle, credential_id
  File "/usr/local/lib/python3.7/site-packages/indy/anoncreds.py", line 923, in prover_get_credential
    prover_get_credential.cb)
indy.error.WalletItemNotFound

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/aries_cloudagent/protocols/present_proof/v1_0/routes.py", line 927, in presentation_exchange_send_presentation
    comment=body.get("comment"),
  File "/usr/local/lib/python3.7/site-packages/aries_cloudagent/protocols/present_proof/v1_0/manager.py", line 297, in create_presentation
    await holder.get_credential(credential_id)
  File "/usr/local/lib/python3.7/site-packages/aries_cloudagent/holder/indy.py", line 281, in get_credential
    credential_id, self.wallet.name
aries_cloudagent.wallet.error.WalletNotFoundError: Credential d413f359-9595-4ab6-94cf-1aa191d2c884 not found in wallet aca-py352817
2020-08-26 22:04:38,912 aries_cloudagent.admin.server ERROR Handler error with exception: Credential d413f359-9595-4ab6-94cf-1aa191d2c884 not found in wallet aca-py352817
2020-08-26 22:04:38,912 aiohttp.server ERROR Error handling request
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/aries_cloudagent/holder/indy.py", line 275, in get_credential
    self.wallet.handle, credential_id
  File "/usr/local/lib/python3.7/site-packages/indy/anoncreds.py", line 923, in prover_get_credential
    prover_get_credential.cb)
indy.error.WalletItemNotFound

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/aiohttp/web_protocol.py", line 418, in start
    resp = await task
  File "/usr/local/lib/python3.7/site-packages/aiohttp/web_app.py", line 458, in _handle
    resp = await handler(request)
  File "/usr/local/lib/python3.7/site-packages/aiohttp/web_middlewares.py", line 119, in impl
    return await handler(request)
  File "/usr/local/lib/python3.7/site-packages/aries_cloudagent/admin/server.py", line 146, in ready_middleware
    raise e
  File "/usr/local/lib/python3.7/site-packages/aries_cloudagent/admin/server.py", line 136, in ready_middleware
    return await handler(request)
  File "/usr/local/lib/python3.7/site-packages/aries_cloudagent/admin/server.py", line 161, in debug_middleware
    return await handler(request)
  File "/usr/local/lib/python3.7/site-packages/aiohttp_apispec/middlewares.py", line 45, in validation_middleware
    return await handler(request)
  File "/usr/local/lib/python3.7/site-packages/aries_cloudagent/admin/server.py", line 253, in apply_limiter
    return await task
  File "/usr/local/lib/python3.7/site-packages/aries_cloudagent/protocols/present_proof/v1_0/routes.py", line 927, in presentation_exchange_send_presentation
    comment=body.get("comment"),
  File "/usr/local/lib/python3.7/site-packages/aries_cloudagent/protocols/present_proof/v1_0/manager.py", line 297, in create_presentation
    await holder.get_credential(credential_id)
  File "/usr/local/lib/python3.7/site-packages/aries_cloudagent/holder/indy.py", line 281, in get_credential
    credential_id, self.wallet.name
aries_cloudagent.wallet.error.WalletNotFoundError: Credential d413f359-9595-4ab6-94cf-1aa191d2c884 not found in wallet aca-py352817

Expected Outcome
The Admin API would return the `Credential d413f359-9595-4ab6-94cf-1aa191d2c884 not found in wallet aca-py352817' instead of the Internal Server error.
Workaround
Use the correct cred id, or if the purpose is to cause an error, then watch the logs in the agent instead.
Test Cases Found or Affected
T005-AIP10-RFC0037 - Present Proof where the verifier rejects the presentation of the proof
Severity
Medium
Business Priority
Medium
@sklump

https://github.com/hyperledger/aries-cloudagent-python/pull/700 addresses.


bug: Menu does not animate open when closed without animation

Bug Report
Ionic version:

[x] 4.11.10
Current behavior:

When an ion-menu gets opened with animation and then gets closed with no animation.
Then when you open it again it does not animate...
Expected behavior:

Ion-Menu should open with animation when it was closed without animation
Steps to reproduce:

just create the sample project with a menu.
then programmtically with a click handler close the menu using it's reference with the parameter false (no animation) and then open it again.
Related code:
menu.close(false);
menu.open(true); // no animation

insert short code snippets here

Other information:

Ionic info:

insert the output from ionic info here

Thanks for the issue. Can you try this on the latest version of Ionic Framework? (v5.0.1)

Hi, yes i just tried it with that latest 5.0.1
Still is there.
I guess some CSS style properties get not resetted correctly when closing without animation.
because when you open then it pops in without animation, when you close it then with animation, after that it opens up again with animation.
So i guess something gets not resetted corretly when closing without animation, but with this shadow-dom stuff everything becomes a black box and workaround/debugging gets hard...

Can you provide a repo with the code required to reproduce this issue? I am unable to reproduce this on Ionic Framework 5.0.1.

it's pretty easy, just use the sidemenu starter project of ionic:
ionic start test sidemenu
inside app.component.html
replace
<ion-menu contentId="main-content" type="overlay">       <ion-content>         <ion-list id="inbox-list">           <ion-list-header>Inbox</ion-list-header>
with
<ion-menu #menu contentId="main-content" type="overlay">       <ion-content>         <ion-list id="inbox-list">           <ion-list-header (click)="menu.close(false)">Inbox</ion-list-header>
after that open the menu, click on the inbox header (the menu closes without animation) and then open the  menu again (it gets opened without animation)

Thanks for the follow up. I am following those steps, but am unable to reproduce the behavior you are describing. Opening the menu and clicking the header does indeed close the menu without the animation, but opening it again after that is opening the menu with the animation. What browser/device are you testing this on?

ok that's strange...
i use chrome version 79.0.3945.130 with the developer tools opened

Can you provide a full repo with the code required to reproduce this issue?

here is the repo:
https://github.com/nickwinger/ionicMenuBug.git
but as i have written above, it's just the little html change

Looks like the key was testing this on Windows 10 -- Chrome for macOS does not exhibit this behavior.
Can you try the following dev build and let me know if it resolves the issue? npm i<EMAIL_ADDRESS>

it's working with this version, you fixed it ^^

Thanks for the issue. This has been resolved via https://github.com/ionic-team/ionic/pull/20627 and will be available in an upcoming release of Ionic Framework.


more statistics

Like in the original game, it would be nice if the game logged on which turn you solved the word. So you would see in stats that you have solved for example 12 words on the 3rd try, 20 on 4th try and so on.
Timestamp when you start to solve a word and when you get it solved. Add these to statistics too, as in how long it took you to solve each wordle and count average times, show your best time etc. These are not in the original game but I think they would add value.
Make separate statistics for the daily words and the basic game/chain mode. For example the original game only has the daily word mode and has stats and it's nice. Currently this version accumulates stats independent in which mode you solve them.
I don't remember how this kind of thing is to be handled, but I copypasted the idea from the Lojban fork in case it gets implemented in one of the versions. Would be nice in both
https://github.com/La-Lojban/valsr/issues/8

The changes I merged yesterday were actually done in preparation for features like this - now multiple games can actually exist in the state, and user can switch between them without resetting them. Previously even the streak was in global state - now that is tracked for each game separately. I was yesterday also refactoring the state a bit more, and I'm probably going to be merging that today too - sorry for the turbulence this maybe causing to your fork if you plan on rebasing it on top of this.
I've been preemptively storing the daily word solves in localStorage in hopes of implementing better statistics for them later on, but just haven't got to it. The update merged yesterday moved these to localStorage keys as game|{"DailyWord": "2022-01-24"}|"Daily"|5, and if the UI had a way to do so these games could be restored fully. The solve statistics could also be constructed from this data, but timestamps for solves are missing.

A timed mode is something I've been working on but I haven't been happy with the implementation I have yet.

Nice! No problem with the turbulence don't mind the fork just do anything you want.


Update ref to release to be version-bump

Description
Update incorrect ref to release to be version-bump in documentation.
Fixes (issue #)

Thanks for updating this!
(Could be just my machine but)I think we need a few more tweaks. the output from Lerna seems out of date as well, this could lead to confusion.
These are the options we get from lerna.

Currently the docs say to select "Custom" but there are 2 options that match Custom.
I think we want to encourage "Custom Version" or "Custom Prerelease" to be clear.

It might actually make sense to prefer the prerelase option, you can enter "-beta" and it will auto target the version number and append the beta tag. (I feel like that could be automated as well)


Revert "RDK-31355 Popup and Notification Windows"

Reverts rdkcentral/RDKShell#83

https://jenkins.cmf.code.rdkcentral.com/job/github-triggered/3017/ started

https://jenkins.cmf.code.rdkcentral.com/job/build-component-rdk-next-platform/6955/ started.

Smoke tests for ['build-brcm-refboard'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/81522/

Smoke tests for ['build-brcm-refboard'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/81562/


Handle Internal errors in aggregators

<file name="C:\Users\a00543375\Desktop\diKTat\diktat-rules\src\test\kotlin\org\cqfn\diktat\util\DiktatRuleSetProvider4Test.kt">
	<error line="1" column="1" severity="error" message="Internal Error (diktat-ruleset:kdoc-comments). Please create a ticket at https://github.com/pinterest/ktlint/issues (if possible, provide the source code that triggered an error) (cannot be auto-corrected)" source="" />
</file>

Such errors should be properly handled

This is when exception is not handled on our side and is thrown up to ktlint. We could probably wrap ktlint's rules to catch all exceptions, or do you have something else in mind?

@Cheshiriks forget everything I just told you, we are doing it differently.

@Cheshiriks forget everything I just told you, we are doing it differently.

Create a wrapper around ktlint's Rule:    abstreact class DiktatRule(val warnings: Set<Warnings>, id: String) : Rule(id) {
        override fun visit() {
            if (check()) return
            else logic()
         }

       abstract fun check(): Boolean // whether this rule should be executed, checks if all warnings from `warnings` are disabled
       abstract fun logic(node: ...)  // previously `visit`
    }

Inside DiktatRule::visit wrap everything in try-catch and output custom message if unhandled error is encountered
Probably, terminate application instead of simply logging Internal Error

Create a wrapper around ktlint's Rule:    abstreact class DiktatRule(val warnings: Set<Warnings>, id: String) : Rule(id) {
        override fun visit() {
            if (check()) return
            else logic()
         }

       abstract fun check(): Boolean // whether this rule should be executed, checks if all warnings from `warnings` are disabled
       abstract fun logic(node: ...)  // previously `visit`
    }

Inside DiktatRule::visit wrap everything in try-catch and output custom message if unhandled error is encountered
Probably, terminate application instead of simply logging Internal Error

If we perform this refactoring (checking whether rule should be executed before visit method), we might gain a performance boost. It would be interesting to measure it (at least at first see whether CI checks have become faster). If so, we can create a map of rules to boolean status - whether they are enabled, according to both enabled and disabledChapters.

If we perform this refactoring (checking whether rule should be executed before visit method), we might gain a performance boost. It would be interesting to measure it (at least at first see whether CI checks have become faster). If so, we can create a map of rules to boolean status - whether they are enabled, according to both enabled and disabledChapters.


[BUG] RuntimeError: 'weight' must be 2-D when two models are used

Describe the bug
My training involves two models, in which model A will update parameters, and model B is only used to generate results. Due to resource problems, I have to enable the zero3 strategy, and the sharding of both models at the same time will cause some errors, so how can I make model B not participate in the sharding? I use the deepspeed launcher.

Hi @nomadlx, do you know how to solve the issue? I also encounter this problem.


What is Container orchestration?

Container orchestrations refer to the automation management of container lifecycles through microservices within multiple clusters. Through container orchestration, resources are shared effectively among containers; there is a redundancy reduction, ensures availability of containers, scaling up containers, resource allocation, among others. Docker Swarm and Kubernetes are tools needed for container orchestration.
Through this article, you will learn everything you need to know about container orchestration.
Key takeaways
What is container orchestration?
Why we need container orchestration?
How does container orchestration work?
Kubernetes orchestration vs Docker orchestration
Enabling Docker Swarm
Enabling Kubernetes

Thank you for the topic suggestion @molly80, however we've already got several previously published articles covering the proposed topic areas, including:

https://www.section.io/engineering-education/history-of-container-technology/
https://www.section.io/engineering-education/breaking-down-kubernetes-vs-docker-swarm/
https://www.section.io/engineering-education/what-is-kubernetes/

Please select a different topic area to explore. Thank you.


In Apify.metamorph() use custom JSON stringification that handles functions well

From @metalwarrior665:
Metamorph to web-scraper doesn't work. I have to stringify the function which wasn't clear to a user.
From @mtrunkat:
It's because JSON.stringify() doesn't preserve function. We could write own method that first traverses tree and calls toString() on functions to simplify it to users.

This is already done.


A wildcard '*' cannot be used in the 'Access-Control-Allow-Origin' header when the credentials flag is true.

When using the cors plugin I always get the following error
Response to preflight request doesn't pass access control check: A wildcard '*' cannot be used in the 'Access-Control-Allow-Origin' header when the credentials flag is true.
I'm using a very basic s-function config:
{
  "functions": {
    "eio": {
      "custom": {
        "excludePatterns": [],
        "envVars": [],
        "cors": {
          "allow": {
            "origin": "*"
          }
        }
      },
      "handler": "modules/falcor/eio/handler.handler",
      "timeout": 6,
      "memorySize": 1024,
      "eventSourceArn": "",
      "endpoints": [
        {
          "path": "falcor/eio",
          "method": "GET",
          "authorizationType": "none",
          "apiKeyRequired": false,
          "requestParameters": {},
          "requestTemplates": {
            "application/json": ""
          },
          "responses": {
            "400": {
              "statusCode": "400"
            },
            "default": {
              "statusCode": "200",
              "responseParameters": {},
              "responseModels": {},
              "responseTemplates": {
                "application/json": ""
              }
            }
          }
        }
      ]
    }
  }
}

and I have added the plugin to the s-project.json. Its clearly doing something because the OPTION method gets created in the API gateway which wouldn't happen witth adding the cors plugin.

What do you think about an option to allow you to pass back the host that is making the request in the Access-Control-Allow-Origin header -- in other words, instead of * it just looks at who's calling and returns that host name -- this would allow authenticated requests to come from anywhere.

What do you think about an option to allow you to pass back the host that is making the request in the Access-Control-Allow-Origin header -- in other words, instead of * it just looks at who's calling and returns that host name -- this would allow authenticated requests to come from anywhere.

@chadkouse Thanks for reaching out! That is indeed something I've been thinking about and it definitely could be an interesting addition for authorized requests! I'll create an issue for this.

@chadkouse Thanks for reaching out! That is indeed something I've been thinking about and it definitely could be an interesting addition for authorized requests! I'll create an issue for this.


Update to 1.11.0, fix TextTooltip.

There's some sort of huge-width bug in 1.11.0 relating to Tooltip, TooltipManager, or just TextTooltip. I brought back the working width-setting code from 1.10.0, and it's in Main.fixTooltip(). It is called in a lot of places now... On the plus side, this is the only bug I've encountered so far, and it doesn't affect libGDX's UITest, so it hopefully can be worked around in most cases.

Thank you so much! This is a great fix. Now to fix libGDX...


gulp compile-build failing

VSCode Version: Master checkout
OS Version: Windows 10

Steps to Reproduce:

run ./node_modules/.bin/gulp compile-build
it fails:

[13:19:28] [check semantics] C:/REPOS/monaco/vscode/extensions/json/server/node_modules/vscode-nls/lib/main.d.ts
[13:19:28] [tsb] time: 1686ms mem: 159MB Δ75
[13:19:28] Finished 'compile-extension-build:vscode-api-tests' after 7.26 s
[13:19:28] Finished 'compile-extension-build:javascript' after 7.3 s
[13:19:28] Finished 'compile-extension-build:php' after 7.33 s
[13:19:28] Finished 'compile-extension-build:typescript' after 7.81 s
[13:19:28] Finished 'compile-extension-build:json-server' after 7.88 s
[13:19:28] Starting 'compile-extensions-build'...
[13:19:28] Finished 'compile-extensions-build' after 3.52 μs
[13:19:39] [emit code] C:/REPOS/monaco/vscode/src/vs/workbench/services/files/node/watcher/win32/watcherService.js
[13:19:39] [emit code] C:/REPOS/monaco/vscode/src/vs/workbench/services/files/node/watcher/win32/watcherService.d.ts
[Error: File vs\workbench\services\files\node\watcher\win32\watcherService.d.ts does not have sourcemaps.]

Background
I'm trying to automate monaco builds (https://github.com/basarat/monaco) for alm. Thanks for a great editor :rose:

This is the exactly line that is throwing this error https://github.com/Microsoft/vscode/blob/5030d8dded95291191a0509612e95def68c1246b/build/lib/nls.ts#L61-L63
I replaced it with
    if (!f.sourceMap && !f.path.endsWith('.js')) {
          console.error('shouldnt be here in the first place');
          return;
    }

    if (!f.sourceMap) {
        return this.emit('error', new Error(`File ${ f.relative } does not have sourcemaps.`));
    }

As you can see it is called for a bunch of .d.ts files:

@basarat I'm thinking you're running with gulp compile-build with SET VSCODE_BUILD_DECLARATION_FILES=1.

Indeed I am. Didn't make the mental connection that it had to be off for the main build 🌹

With 8fd51f85b99158addb59c0ce66ce8709e7029ccb, there is no more need to run special scripts to generate the monaco.d.ts, it will always be up-to-date in our master and the build will fail if it is not up-to-date.

awesomesauce :rose:


Npm audit fix

What
bumps the following dependencies to address vulnerabilities

css-select
css-what
path-parse
svgo

Tested locally.
4 vulnerabilities (1 moderate, 3 high)

npm audit fix
added 10 packages, removed 22 packages, changed 39 packages, and audited 2035 packages in 32s

found 0 vulnerabilities

How to review
test pass
Who can review
not @kr8n3r

🚨⚠ Please do not merge this pull request via the GitHub UI ⚠🚨

No bumps in the main package.json? I assume all deep dependencies.

yeah all deep deps


[website] Kepler example

Pull Request Test Coverage Report for Build 931982328

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 21.534%

Totals

Change from base Build 930518091:
0.0%

Covered Lines:
139

Relevant Lines:
555

💛  - Coveralls


Add S3 profiles & controller mgr cfg to RamenConfig

Use of the S3 profile specified in RamenConfig by DRPC and VRG will be a follow on PR.

Also, I am not sure how we are to load the config file on demand, i.e which function/inerface to use for the same.

Also, I am not sure how we are to load the config file on demand, i.e which function/interface to use for the same.

I've added an interface to LoadRamenConfig().


do a better job surfacing SingularityDeployResult in the UI

The message field of SingularityDeployResult contains useful information for diagnosing a failed deploy, we need to do a better job surfacing it in the UI. This could be as simple as including the message field in the Deploy History table on the request page.
/cc @eherot

:+1:
Not just "useful" but also the only way to tell if you've asked for resources you don't have (which I suspect devs will do a lot in our relatively small cluster.

#629 should solve this once and for all


Cookbook fails to run with error undefined method `win_install_dir'

Cookbook fails to run on Ubuntu machine with error undefined method `win_install_dir'
is this attribute newest addition to ark resource?

I think easiest way to fix this is to update metadata.rb and Berkfile to use latest version of ark

Versions were bumped and this should no longer be an issue.


Indoor mode

Hi,
I am submitting a little larger pull request. I am not sure if its possible to be merged as is, but I did my best and will be happy to cooperate further to make it so.
I’ve been engaged in OpenStreetMap since 2008 and for the time being I’ve led many workshops, written some school works and worked on getting the Czech community together on openstreetmap.cz. Last summer I had to come up with a topic for my final engineer thesis, so I decided to use the effort already invested in indoor mapping and chose to update the iD editor accordingly. Let me elaborate...
Current work-in-progress proposal is called Simple Indoor Tagging. I didn’t want to rely on WIP, so I realized there is already an accepted solution – the level=* tag.
There are two challenges for indoor:

making underlying background map (this is addressed by Simple Indoor’s indoor=* area features)
display ways – the accessibility of places – and this kind of was the nature of OSM from the beginning. Until we had all the landuse=* areas, OSM started with highways + pois.

Drawing highways=* for indoor feels very natural – corridors usually repeats every floor even in multi-storey buildings, it displays clear accessibility information, can be already used for routing and also works with parking highways. The logic is also very simple - when a level=* feature is in viewport - show “Indoor” button, and let the user filter on these.
Several examples (my build):

Shopping mall in Prague - underground parking, main foot passages and few shops POIs
University building in Aachen - complete room plans with Simple Indoor (older proposal version with optional level=* xor repeat_on=*). Another building here.
Berlin main railway station - several underground floors + indoor=* features
University campus Prague - mapping in progress ;-)
Another shopping mall - only POIs

Well, i think I made my point - let’s discuss the technical background :-)

Some thoughts / questions:

Is it ok, to call it indoor mode? It doesn't fit with current “modes” terminology, where modes are exclusive.
I think the philosophy of iD is to show disabled buttons for “availible” actions. I chose to hide the button completely, where there isn't any level=* features on screen. Would you agree?
Current level=* allows only separate values by semicolon, I borrowed three useful tagging from SimpleIndoor. Is it ok to use these? Should i maybe make new official proposition?

ranges – level=0-12 or -3--1 for features spaning several floors.
repeat_on – for repeating the same (possibly multilevel) feature on other floors - ie. doors,toilets
min/max_level – when set on building, the building spans through these levels. It helps as a visual cue, and also for the renderers.

I had to unclip the building-outline shape, because a building completely covered with indoor=* areas, couldn't be clicked anyway. Kind of addresses the issue #2225.
I submitted my original development commits, rebased to current master. Is it appropriate to squash the commits into one or few?
Although I tried to abide the current code style and wrote some test, tell me if i should change something globally. Easiest would be to comment the code in the specific commits..

Something to do in future

if agreed, I would like to add level indicator as shown here https://github.com/zbycz/iD/wiki/devnotes-zbycz – but rather use another svg layer instead of filters.
once proposition is accepted – enable switching over floating point level values (ie. level=1.5). But even now - any string value could be written in the level chooser, so it “works”.
add icon for ‘highway=elevatorandindoor=corridor+stairs=yes` as these had to be distinguished easily.
Unfortunately I found later, I developed very similar changes as Panier’s id-indoor fork. Although he added many more indoor presets, which could be eventually merged here.
Create a level switcher in osmbuildings.org 3D viewer ;-)   .. well, distant future indeed.

Changelog until now:

added iD.ui.IndoorMode control ui
added filtering using features.indoor_different_levels
added .indoor-mode class for svg surface
added general preset for indoor=* when indoor-mode enabled
added several map styles for enabled .indoor-mode
added indoor_levels as general field for building, using iD.ui.preset.range

btw, it was a pleasure to work with iD codebase, also d3 is so very amazing :-)

Wow, impressive work @zbycz!    I really like this and would like to see this merged in some form.
I'll need some time to think about how to present the UI in a way that doesn't clutter things up too much.
I'll try to answer your questions now:

Is it ok, to call it indoor mode? It doesn't fit with current “modes” terminology, where modes are exclusive.

I think it's ok to call it indoor mode.  (People will call it that anyway).  You're right it's not technically a "mode" like the other exclusive drawing modes.

I think the philosophy of iD is to show disabled buttons for “available” actions. I chose to hide the button completely, where there isn't any level=* features on screen. Would you agree?

I'm leaning towards having the button smaller but available, maybe just an icon with tooltip, and it can transition open to reveal the indoor drawing controls when active.  (I'm struggling with this same problem on #2699 - it's cool and useful, but where to put it?)

Current level=* allows only separate values by semicolon, I borrowed three useful tagging from SimpleIndoor. Is it ok to use these? Should i maybe make new official proposition?
ranges – level=0-12 or -3--1 for features spaning several floors.
repeat_on – for repeating the same (possibly multilevel) feature on other floors - ie. doors,toilets
min/max_level – when set on building, the building spans through these levels. It helps as a visual cue, and also for the renderers.

The right thing to do is to make a proposal and loop in the OSM tagging list.  At this point, indoor editing is not solidly established, so I think you have a good chance of pushing the community in a sane direction.

I had to unclip the building-outline shape, because a building completely covered with indoor=* areas, couldn't be clicked anyway. Kind of addresses the issue #2225.

Makes sense.. Yes I agree that in "indoor mode" the building outline should not render as an area, as this covers up the indoor features.

I submitted my original development commits, rebased to current master. Is it appropriate to squash the commits into one or few?

It would be better to squash them into fewer commits, but I'm not super picky about this.

Although I tried to abide the current code style and wrote some test, tell me if i should change something globally. Easiest would be to comment the code in the specific commits..

I'll try to review it in more detail, but what I saw at a quick glance looks great!  And the tests are much appreciated...

Thanks, @bhousel !
I will make the proposal next week, in the meantime I am looking forward to your code comments 👍  Once we're done, I will sqash the commits in fewer.
ad button positioning) the more buttons, the more the user think how complex the software is (aka Norman: The design of everyday things) - and I think iD should stay "simple". But also its a bad practise for controls to disappear unexpectedly.
I completely agree with a smaller icon expanding to full control. What about placing Indoor-mode button in a dropdown menu "Tools" on the right of the top toolbar. It could be left closed forever, or left toggled opened. It would be a nice drawer for more useful tools in the future (including the #2699).

What about placing Indoor-mode button in a dropdown menu "Tools" on the right of the top toolbar. It could be left closed forever, or left toggled opened. It would be a nice drawer for more useful tools in the future

I've been playing around with making the UI more responsive and supporting something like a "drawer" for more commands or options on existing commands.
I don't really like it.. Maybe @samanpwbb has ideas?
The problem is it either bumps down the other things in the layout, or it overlaps them.  So we'd either need to 1. position the other UI stuff differently or 2. be ok about having them move (eh) or 3. something else.

I'm glad to see the opportunity of integrating indoor editing in main iD version. Feel free to reuse any custom part of iD-indoor, like presets or level parser (which handles lot of level-related tags) ;)

Indoor mode would work well as a Map data filter:

If the auto-tagging piece of this PR is mandatory, we can add a note about it in the filter panel:

Hi, just letting you know, we have moved a little further. I created official proposal and submited RFC to tagging list.
In near future i will create new pull-request based on current master, thus I am closing this one.

Hi, just letting you know, we have moved a little further. I created official proposal and submited RFC to tagging list.
In near future i will create new pull-request based on current master, thus I am closing this one.

Great!  We are thinking a lot about plugins lately and I would love to find a good way to merge your work into iD to make indoor editing easy for everyone.

Progress?

@TheAdventurer64 As I've mentioned before, any progress on an issue will be shown there. If you have any substantive questions or comments feel free to voice them.


Fixes #778 - Exemplars should be sorted before sending to Cloud Ops.

Fixes #778
We discovered that using the fixed-sized reservoir does not guarantee exemplar order, but this is required in Cloud Operations for most distribution types.
cc @franciscovalentecastro

codecov failure is https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/issues/790


Details veiw

I would like to see a static page of 1 record (/details/1) rather than a popup.
Am i missing something or is the 'details view' not available in this platform (entity?).  ie:  moves/details/1
Is it jquery or client side stuff instead of entity???
Advise.  Love the platform so far!!!

I think i've answered your question in VS gallery


how to install cpr:x64-windows-static-md

i installed cpr like this :
.\vcpkg.exe install cpr:x64-windows-static-md
this is my current packages :
cpr:x64-windows-static-md                          1.5.2            C++ Requests is a simple wrapper around libcurl ...
curl:x64-windows-static-md                         7.74.0#7         A library for transferring data with URLs
curl[non-http]:x64-windows-static-md                                Enables protocols beyond HTTP/HTTPS/HTTP2
curl[schannel]:x64-windows-static-md                                SSL support (Secure Channel)
curl[ssl]:x64-windows-static-md                                     Default SSL backend
curl[sspi]:x64-windows-static-md                                    SSPI support
curl[winssl]:x64-windows-static-md                                  Legacy name for schannel
zlib:x64-windows-static-md                         1.2.11#10        A compression library

and this my current vcpkg config :

but when I try to build it I get LNK2001 error  :
Severity	Code	Description	Project	File	Line	Suppression State
Error	LNK2001	unresolved external symbol __imp_closesocket	imgui-prime	D:\project\imgui\libcurl.lib(memdebug.c.obj)	1
Error	LNK2001	unresolved external symbol __imp_accept	imgui-prime	D:\project\imgui\libcurl.lib(memdebug.c.obj)

seems it looking for ibcurl.lib in my project folder instead of vckpg folders.
so am I do something wrong ? sorry I am very new to vckpg .

my bad it all work now


Autogenerate from metadata?

Describe the idea or improvement
Autogenerate device configs from metadata
Describe the solution you'd like
Would it be possible to autogenerate configs from metadata or is there some limitation?
I would imagine a list of actions, methods, property, propmonitor, let the user select what to enable
Additional context
I'm noticing that mantaining a config per device is a bit unmantainable(?) so this could be a friendly alternative

It is already being done automatically. The device specific files are not really needed, but some devices have special handling or different values for properties so this is more or less handled there.


Support dask types

This adds support for passing dask objects to fit.
Todo:

[ ] Tests

What is the behavior when I pass a dask.dataframe or dask.array?  Do we not just coerce to a numpy array or pandas dataframe?

No "chunked" work is done, so dask.array/dask.dataframe objects will be computed before being passed to fit. The main point of this PR is to:

Allow inputs to be dask objects, merging in their graphs to the graph produced by the *SearchCV obect. This also allows the input data to already be on the workers (perhaps even scattered) removing the need to serialize it.
Prevent/minimize any computation that needs to be done before building up the graph. We need to know how many splits there are beforehand. Some CV methods require knowledge of the input data before determining this (which may require computation). We specialize on the builtin CV types to avoid doing this if possible.
Adds the refit step to the graph, removing the need for multiple calls to compute. This also allows the input data to be serialized only once (if needed).


feature request: support coverage.py's dynamic contexts?

Description
Thank you for creating this project!  It's especially nice to have pytest-esque support for unittest test-parameterization, for projects that are using unittest.
I've have found the "dynamic contexts" feature of coverage.py to be extremely useful - it tracks which tests exercised which lines of code in a project.  Unfortunately though, something about the way dynamic contexts are determined seems to be incompatible with tests that are parameterized using this library.
I am not quite sure of the best way forward, but it would be really great to see parameterized tests showing up in the dynamic context documentation that coveragage.py can produce (I use it to generate HTML coverage documentation).
Might you be interested in updating unittest-parametrize to (optionally?) generate dynamic context info that's compatible with coverage.py?
The key parts of a .coveragerc that enables this feature are:
[run]
dynamic_context = test_function

[html]
show_contexts = True

Yeah that seems like a fair extension. I won't have time to work on it but if you can make a PR that would be welcome.
It would be good to also see if and how pytest handles it.

I think pytest has a bit of an advantage since parameterization is built into pytest itself.  That means there are only two libraries that need to cooperate (pytest & coverage), and the pytest-cov plugin handles that cooperation by (effectively) extending pytest.  Per the coverage documentation I linked above:

The pytest plugin pytest-cov has a --cov-context option that uses this [calls the Coverage.switch_context() method to set the context explicitly] to set the dynamic context for each test.

Without having yet looked at the unittest-parametrize code, I am thinking that that approach would be the best thing to do here as well.  It would add a coverage dependency, so should probably be implemented as an extra, unless you are OK adding coverage as a base dependency.

Yes, that looks like the right way. But does it work with parametrized tests in pytest?
And yeah, make it an optional dependency. I'm not sure using the "extras" mechanism will be helpful, we can just try import coverage, and if that succeeds, use it.

Just thinking more, this seems like something that should live in the unittest runner, so it can run for every test method. Then it should “just work”, no? unittest-parametrize modifies the test class before the runner ever reads it, so the generated parametrized test methods look like regularly defined ones.

I have been thinking about this a lot, and trying to understand what the issue is that causes this problem in the first place.  coverage has built-in support for computing a "dynamic context" for each unittest test-case, and I don't really understand, as I think you're saying too, why that's not working in the case of unittest-parameterized-modified test-cases.
The approach that pytest-cov uses is not quite appropriate for unittest-testcase since pytest-cov is a pytest plugin that actually starts coverage, so it has access to the coverage.Coverage() object at runtime, so it can call Coverage.switch_context()
If the actual root problem were clear, one option would be to register a coverage "Dynamic Context Switcher" plugin that provides a method to compute dynamic context - but that method would, as far as I can tell, essentially recapitulate what coverage is already doing by default, in coverage.context.should_start_context_test_function() (so we shouldn't need a plugin).
I wonder if @nedbat might be able to weigh in here and explain what the actual root of the problem might be.


Changed raw DB queries to Schema notation

Having the raw DB calls breaks migrations for database connections with prefixed table names.

Thank you


Visual Studio compiler switch changes:  Stack probing, string pooling.

CLA: trivial
This is truly a trivial change.  If you agree, please remove the "hold: cla required" tag.  On request, I will email a CLA.
Changed use of two compiler switches for Visual Studio (Windows):  /Gs0 removed.  (Nondefault stack probing.)  /GF removed for debug but not release.  (String pooling.)  Both changes are to fix problems stepping through code for "openssl.exe s_server -WWW".

Are the 40Mbytes of files really required?
I'm very hesitant adding that much to the repository, it represents a double digit percentage increase in the size of OpenSSL.

No, the intended change is only a couple of edits.    (I'm new at this.)  Please deny and close my pull request.  I
will submit another one, making sure that it doesn't contain other things.

NOTICE:  This conversation will be published on IDEAFARM.COM.  (Click
"privacy" there.)
On Wed, Jun 17, 2020 at 8:18 PM Pauli<EMAIL_ADDRESS>wrote:

Are the 40Mbytes of files really required?
I'm very hesitant adding that much to the repository, it represents a
double digit percentage increase in the size of OpenSSL.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/openssl/openssl/pull/12163#issuecomment-645746236,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXLIORU2UDZVOPVSM2B663RXGBQBANCNFSM4N7G6TWQ
.

I'll have to let somebody knowledgeable about Visual Studio sort this one out -- more knowledge is zero (or possibly below due to misconceptions :)
It doesn't seem like your ICLA went through properly.  Could you please email<EMAIL_ADDRESS>and confirm the email address you are using for github?  Thanks.

This PR contains unintended changes, so I am closing it, with intent to open a new PR.


Question: where is the logic for distributing SWIV incentives?

Hello,
I am working on a safety module for another protocol, and doing research on how others implement it. In your docs, I see the following:
APR Explained
The yields that SSM stakers (stkSWIV holders) recieve are comprised of a number of revenue streams.
- Swivel Protocol Fees: The SSM earns 50% of all fees currently generated on the Swivel protocol. The fee share is variable dependent on future governance proposals.
- Balancer LP Fees: As all deposits are also providing liquidity, the SSM also earns all fees generated by an 80/20 Balancer pool comprised of SWIV/ETH.
- SWIV Incentives: Each epoch a given amount of SWIV are allocated in incentives to the SSM.
- External Incentives: Each Balancer Pool is eligible for incentives through balancers veBAL gauge system.

However, in the stkSWIV.sol contract I can't find any logic related to accruing SWIV rewards to stakers. For comparison, the Aave SM contains this _updateCurrentUnclaimedRewards function.
Where are the yields? Am I missing something?

For protocol fees, anything earned by Swivel is managed separately, where we purchase SWIV/ETH with proceeds and use the donate method (we could just send them to the safety module as well but this allows our backend to track donations). -- https://github.com/Swivel-Finance/SSM/blob/main/src/stkSWIV.sol#L704
Then for SWIV Incentives, we do all our calculations off-chain and utilize a modified merkle drop contract for distribution --
https://github.com/Swivel-Finance/destributor
This allows us to combine multiple avenues of earning our incentives (some from the safety module, some from our platform) into 1 merkle tree which we overwrite every epoch.
++ Distributing protocol incentives in this way isolates the safety module to just dealing with BPTs -- if you otherwise wanted to keep the module just in BPTs, you would have to sell some of your incentives for ETH or whatever your pair might be.

Aaaand for balancer incentives, we plan to claim them using https://github.com/Swivel-Finance/SSM/blob/main/src/stkSWIV.sol#L782 to then exchange into SWIV/ETH BPTs to donate

I see, thanks for the clarification


Update news and blog post index pages

Specifically, add the date to each item in the list, and add the author to the blog posts.

Done in commit 4cca6c149ff65a383c1b0952bb2da1274fb096d1.


Problem with fork

I tried the fork:
https://github.com/jaredballou/7dtd-server/commit/9fcb06c2f7cb5ab976b4d1c5eef2df52d5c75eb8
https://hub.docker.com/r/jballou/7dtd-server/
There is an error and i commented on the commit, https://github.com/jaredballou/7dtd-server/commit/9fcb06c2f7cb5ab976b4d1c5eef2df52d5c75eb8#commitcomment-21871251
Do you got any info on this project?
Do you plan on update yours?

@jammsen Sure thing, I'll let you know once it's fixed. :)


fix: revision 223 OSRS js5

May fix #145 , not sure if we can put this code here or if we should create some separate classes for this functionality much like how there are separate ones for NXT.

May fix https://github.com/openrs2/openrs2/issues/145 , not sure if we can put this code here or if we should create some separate classes for this functionality much like how there are separate ones for NXT.

Yeah, it did need separate classes to avoid breaking the 550 support. I did that in f472125200509a5a2f6c44ae0813a9120711b9a8


test: mine proofs

Tailoring test cases to phase4 changes and mine samples for stats tests

please make stats fixtures less files and/or number them 001,002 etc
and submit as a separate PR so that we can see logic changes better

If I do that, the CI starts to mine again the samples that are missing.
All samples are located in a separated folder under the test/mined-witnesses , so I kindly ask you to ignore the changes in that folder.
The different round samples are numbered and prefixed with the related test name e.g. stats-0.json, stats-1.json and so on.


Does the code support the newest LLaVA 1.5 pretrained weight?

Current not. I can see it will be useful.


Use the new webmozart assertions

Puli BETA 3 had a BC break causing Resource to no longer work. This PR fixes that.

The API is, or has, changed also. The getPaylload method is being removed from the Resource interface/


(cargo-release) version 0.2.8

I'm deeply regretting that cargo-deny is the package I picked, because it takes ~10 minutes on some architectures. Maybe we actually don't want to check that CC is set correctly, if this is what it does to our CI times :/ .

I jumped the gun on making my PR because some arches hadn't finished building yet. Once the cargo-deny builds had finished, I hit "rerun" on the jobs that failed/auto-cancelled, and it was fine.


[Feature] Re-introduce nightly support for Markdown docs

🚀 Feature
https://github.com/AleoHQ/snarkOS/pull/868

This is going to be possible shortly: https://github.com/rust-lang/rust/releases/tag/1.54.0.

Closed by #1007


Connecting multiple tours

I have several tours that kick off from the same drop down menu.  They have different names, but I can't figure out how to link specific button to specific tours?  What is the syntax for that?

Give an attribute value="tour_name" on each drop down choices and then retrieve the value selected with jquery to launch the right tour


Convert HTTPVersion to a struct

As per the proposal from @paulofaria, convert HTTPVersion from (Int, Int) to a struct.
This allows the addition of Hashable, Equatable and CustomStringConvertible protocols - which haven't yet been added but can be if we're happy to move to a struct.

Merging based on approval from @tanner0101 and discussion on the mailing list.


Trying to reconfigure fzf to not do fuzzy-matching

Category

[x] fzf binary
[ ] fzf-tmux script
[ ] Key bindings
[ ] Completion
[ ] Vim
[x] Neovim
[ ] Etc.

OS

[x] Linux
[ ] Mac OS X
[ ] Windows
[ ] Windows Subsystem for Linux
[ ] Etc.

Shell

[ ] bash
[x] zsh
[ ] fish

I installed FZF and configured it for fuzzy search, but I realize I don't want that and want strict searching instead. How do I go about changing that? I tried reinstalling fzf but that didn't work. Where does fzf store configuration files outside of ~/.fzf?

The answer can be found on the README page.


fix/Pie Chart focus update

Posted this issue the other day : https://github.com/Abhinandan-Kushwaha/react-native-gifted-charts/issues/428
It was pretty annoying and by continuing my development, I found an other small issue about the focused thing on the pie chart.
I used a useEffect so each time a re-render was needed, it would check again some stuff to re-render correctly the chart and the focused part.
I put comment in the code too, just to help explain what I did. Maybe it's overkill. You can delete them if you want 😁
Let me know if you have any questions.

Thanks @AphroMad for this much-needed PR. It works like a charm. I will merge it and release a new version today or tomorrow.

Thanks @AphroMad for this much-needed PR. It works like a charm. I will merge it and release a new version today or tomorrow.

Hey ! Cool to know,
let me know when you're merging it so I'll use the main branch instead !


fixing headers

PR Checklist
Please review the guidelines for contributing to this repository.

[x] I am requesting to pull a topic/feature/bugfix branch (right side). In other words, not master.
[ ] I have run npm test against my changes and tests pass.
[x] I have added or edited necessary documentation, or no docs changes are needed.

Description

Fixes: #

I don't think everything should be at the same level here; the original arrangement was hierarchical.


Cleanup #14

Hopefully this will be a bit easier to navigate. It at least makes displaying on the index.html page straightforward. There are some files I haven't used, like view_helpers.py and daily_update.py, but can either delete them now or put some stuff into them not sure what yet. I also integrated your changes to run.py into data_helpers.py and run.py can be safely deleted. Just wanted to let you look over this before I do that!
The process for getting new data from GA using  total_clicks as an example:
add the name of what we want it to represent in choice_dict in views.py
choice_dict = {
        "clicked_issues":"",
        "top_cities":"",
        "least_clicked":"",
        "most_clicked":"",
        "recently_clicked":"",
        "total_page_views":"",
        "viewed_issues":"",
        "total_clicks":""
    }

add GA request info to choice_dict (just realized this name might make it confusing) in data_helpers.py for whatever info you're trying to get. If that particular query isn't needed, just pass in None
"total_clicks": {
 'metrics':'ga:totalEvents',
 'dimensions':None,
 'sort':None,
 'filters':'ga:eventCategory=@Civic Issues',
 'max_results':None,
 'fields':None
}

add an elif statement in the get_analytics_query function for what it's doing with the response it got from the GA request
elif choice == "total_clicks":
 results = edit_request_query(choice)
 total_clicks = results["rows"][0][0]
 return total_clicks

and that's it!
In index.html you can render it by accessing choice_dict choice_dict['total_clicks']

I tried to unlink references to run.py and once db fetching edits on your end are done, I can fetch issues from data_helpers.py


fix unsorted series for get_stat_series

fix the issue raised in #150
Issue raised: series should be sorted
Changes
changes in file: datacommons_pandas/df_builder.py
changes in line: L49, L53
Change Description:
changed the return statement of function build_time_series  by adding a suffixing .sort_index()
also changed the docstring last line from " representing a time series satisfying all optional args." to "representing a sorted time series satisfying all optional args."
Test Result
platform darwin -- Python 3.7.10, pytest-6.2.4, py-1.10.0, pluggy-0.13.1
rootdir: /Users/manojbalaji/personal/api-python
collected 45 items
datacommons/test/core_test.py ...........                                                                                [ 24%]
datacommons/test/places_test.py .........                                                                                [ 44%]
datacommons/test/populations_test.py ........                                                                                [ 62%]
datacommons/test/query_test.py ..                                                                                [ 66%]
datacommons/test/set_api_key_test.py ....                                                                                [ 75%]
datacommons/test/stat_vars_test.py ......                                                                                [ 88%]
datacommons_pandas/test/df_builder_test.py .....                                                                                [100%]
Note: Not tested for Python2 since its deprecated

@googlebot I fixed it.

closed it as google-cla didn't work, recreated again


Sample with .Net 4.5.2 Web API and reporting to ElasticSearch/Http

Hi guys,
I would to know if I can build metric listener for Web API project .Net 4.5.2 which doesn't using Owin (or can use only Startup.cs). I have looked into your old examples, but those nuget packages are not existing any more.
Thank you for your help in advance,
Martin Bodocky

App Metrics core packages target netstandard1.6 so yes that would be possible.


Stylistic cleanup and (start of) Py2/3 compatibility

Many minor changes in whitespace, indentation, imports, etc. to clean up the code à la pep8. No code behavior should change.
Added a compat.py module with standardized Py2/3 compatible built-ins, and replaced the Py2-only equivalents in all modules:xrange => compat.range_, unicode => compat.unicode_, etc.
Replaced all print statements with print() functions via from __future__ import print_function
Replaced sets of string literals in blocks.pyx with explicit bytes, compatible with Py3 in addition to Py2

Unfortunately, something has changed in the code's behavior, and 1 test out of 39 now fails. Specifically, the kohlschuetter_css_model model's extracted content fails to match the actual content in test_models(), even after 5 tries. I don't understand why this is.
One other note: scipy.weave is Py2 only, so its use in arias.py is incompatible with Py3. It looks like the recommendation is to use Cython directly, but I didn't want to muck around with that just yet.

Wow, thanks for the cleanup!  This all looks good to me.
A few general comments:

the arias / scipy.weave stuff is old and can be completely depreciated.  We should just rip it all out (also conveniently makes upgrading to PY3 easier).
the loop of 5 tries in the unit tests for model output is for models that use the weninger features.  These use a k-means algorithm for features that isn't deterministic, but most of the time one of the 5 iterations matches the checked in gold standard.  In your case, the kohlschuetter_css_model is deterministic so this shouldn't be an issue.

(also: FWIW, we decided in the end to eliminate the CSS features from the recommended models (content_extractor, content_comments_extractor etc) since they only added a small increase in F1 but added significant run time, and were slightly overfit to our training data).

Hi @matt-peters , happy to help! I'll rip out arias/scipy.weave in a separate PR, but probably best to keep this one limited in scope. It's already touching lots of files... Would you prefer to also strip away the CSS features, or maybe try to make those features more performant?

Agree on leaving the arias changes for another PR.
For the CSS features: even though they aren't used in the recommend models, I'd like to leave them in for two reasons:

others may want to make a different accuracy / speed tradeoff
they were used in the original paper so they would be useful for others who wanted to reproduce those results.

As for the errors, agree those are strange.  Do all of the tests pass on the master branch in your local dev environment?  If so, then we can conclude that the changes you made are causing them to fail.  The mismatch between numpy array sizes is strange.  That error is getting thrown when computing the features before the model is even being called.  Changing the dimensionality shouldn't impact that at all since the number of features is a public attribute that the ContentExtractionModel uses to allocate the properly amount of space and pack all the different feature instances into one array.  In the CSSFeatures class the nfeatures attribute is computed dynamically so it's not obvious to me at a glance what the problem is.

Hey @matt-peters , so, all tests run successfully in my branch after the 2nd of 3 commits, but test_models test fails after the changes introduced in the 3rd commit, as discussed. I've reverted one change at a time and re-run the failing test case, but nothing changes the outcome. Also, just looking at the changes, I can't see anything that would change the code's behavior at all. I'm at a total loss.

Thanks for the sleuthing!  I left a comment above that I believe will fix it.

Okay, that last commit should do it. All tests now pass locally, although Travis CI has failed for a reason that doesn't appear related to this PR.

Hey @matt-peters , just checking in. How should I proceed on this PR? I have another couple coming (removing arias, etc.), but don't like to pile up PRs.

I've been out of the office much of this week so haven't had a chance to work on this yet.  Would love to get the Travis build fixed before merging.

OK I just fixed the Travis build problem in #35 -- rebase your branch and the build should pass.

Hurray! All checks have passed. Thanks for the travis fix.

Thanks the the perseverance on this!


ci: use latest Alpine Azure CLI image

Our Azure CLI versions of the runner image are failing to build currently. It looks like the problem is that Microsoft switched from Alpine to cbl-mariner after v2.63.0. For now I'm pinning to that version since our build process expects Alpine.
The reason I created this PR is because another PR I opened currently has failing checks: https://github.com/spacelift-io/runner-terraform/actions/runs/10769454833/job/29860697729.
I noticed that the Azure docs have a warning about the deprecation of the Alpine based image:

I guess one potential solution would be to pull the binary from there:
FROM COPY --from=mcr.microsoft.com/azure-cli:latest usr/local/bin/azcli usr/local/bin/azcli

I guess one potential solution would be to pull the binary from there:
COPY --from=mcr.microsoft.com/azure-cli:latest usr/local/bin/azcli usr/local/bin/azcli

Whether it works or not is another question. 🙂

Yeah - I just wanted to focus on fixing the build first, and then we can revisit in future. I didn't want to go down a rabbit hole on this right this second.

I'm going to have to cherry-pick this change into https://github.com/spacelift-io/runner-terraform/pull/57. The problem is that the Trivy check is failing due to rate-limiting, so we have a bit of a circular dependency going on 😓