[$500]  Mark down - Live preview for code block with strikethrough is incorrect

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.45-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Launch New Expensify app
Go to any chat
Type ~Code~
Note that live mark down preview
Send the text

Expected Result:
The live mark down preview for ~Code~ should correctly show the actual mark down
Actual Result:
The live mark down preview for ~Code~ is incorrect. It shows that the strikethrough is applied, when strikethrough does not work with code block in the sent text
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/dd57a2e1-3d63-4a0a-b56a-b6e08b4be49b
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~012e80f0cbfad42ad6
Upwork Job ID:<PHONE_NUMBER>765831680
Last Price Increase: 2024-02-29

We think that this bug might be related to #vip-vsp
CC @quinthar

@puneetlath  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@brandonhenry live markdown is only on mobile right now, FYI. I'm able to reproduce it there.

Proposal
Please re-state the problem that we are trying to solve in this issue.
The live markdown shows a preview of a strikethrough + code fence markdown, but when sent, the strikethrough is not applied.
What is the root cause of that problem?
One of the differences between the live markdown and the sent markdown is that the live markdown set shouldKeepRawInput to true.
In ExpensiMark rule, strikethrough won't be converted to HTML if it includes a <pre> (codefence) tag.
https://github.com/Expensify/expensify-common/blob/77d0b150ba6bfbe7a64b3c3e30b65592b2e58c4a/lib/ExpensiMark.js#L294-L298
However, if shouldKeepRawInput is enabled, it will convert codefence to <pre data-code-raw ...> which fails the condition above
https://github.com/Expensify/expensify-common/blob/77d0b150ba6bfbe7a64b3c3e30b65592b2e58c4a/lib/ExpensiMark.js#L46-L50
What changes do you think we should make in order to solve the problem?

I'm pretty sure we want to keep the old behavior, that is to prevent strikethrough being converted to HTML when it contains a codefence.

To fix it, instead of checking whether it includes the opening tag (i.e., <pre>), we can check whether it includes the closing tag (i.e., </pre>) as we did for h1 here.
We need to apply the fix to all occurrences (bold, strikethrough, italic, link)
What alternative solutions did you explore? (Optional)

Use a regex to check whether it contains pre tag that optionally has an attribute (we can take the codefence regex here).
Allow strikethrough (italic, bold, and link) + codefence by removing the <pre> tag checking

Reviewing today.

Thanks for the proposal @brandonhenry. I think you missed to include italics / links in your proposal which in my opinion should be removed as well. Also, I think for consistency, we should follow the pattern already established in the h1 parsing.
As such, I think @bernhardoj's proposal looks better to me.
🎀 👀 🎀 C+ reviewed

Sounds good 👍🏾

The expensify-common PR is here
cc: @allroundexperts

I am reviewing this Melv

Copying the comment from the PR to here for visibility.

Is the next step to open an App PR to apply this expensify-common update?

@puneetlath @allroundexperts we would need to update the expensify-common version in react-native-live-markdown, but I think it would make sense to have the same version of expensify-common in App too.
react-native-live-markdown already has the latest version of expensify-common (dc8ea98), except our recently merged commit (9e47e1f). I think we need a help from SWM team to update the package as react-native-live-markdown latest version is 0.1.28 and if we update it, that would be 0.1.29 which is 24 patch version apart from the current version in the App (0.1.5).
I see that this issue will update the react-native-live-markdown to the latest version, but I don't see the App PR yet (@robertKozik cmiiw). I think we can hold for that issue or ask them to include our expensify-common update to react-native-live-markdown.

Thanks @shubham1206agra. I see that https://github.com/Expensify/App/pull/38152 bumps react-native-live-markdown to a higher version which includes our fix too. Let's hold for that instead.
@puneetlath @allroundexperts

Looks like that was merged. Can you test that everything is working as expected with our changes in this issue?

Here is the retesting result, all works fine (as the live markdown is now available on Web, I have included the web result too):

Android
https://github.com/Expensify/App/assets/50919443/8786f34d-83a7-4497-b720-02d2e3d7cad3

iOS
https://github.com/Expensify/App/assets/50919443/1828db93-72f8-420f-b1a5-8e3a78333cc6

Android mWeb
https://github.com/Expensify/App/assets/50919443/d97d3aa6-fe84-42b0-b92d-24ddae0c9a02

iOS mWeb
https://github.com/Expensify/App/assets/50919443/5c9ea072-627b-4a47-94c6-2e2d8adb2b9a

Desktop
https://github.com/Expensify/App/assets/50919443/740985fe-38d6-4a8e-a974-fb8028279337

Web
https://github.com/Expensify/App/assets/50919443/81744ba4-ce99-46b9-8449-b7d1f70e43a8

Ok great! So we can pay according to when that PR goes to production.

Payment summary:

C - $500 - @bernhardoj - to be paid via Upwork
C+ - $500 - @allroundexperts - to be paid via NewDot

@bernhardoj can you please accept the Upwork offer? https://www.upwork.com/nx/wm/offer/101349515

@bernhardoj has been paid. @allroundexperts please request on NewDot.
Thanks everyone!

$500 approved for @allroundexperts


motion / FIFO1 not working anymore - need debugging help

Hi,
I've missed couple of versions and now in my docker version motion triggered events are not working anymore after the update.
In the schedule log I can see
Executing macro /var/www/macros/motion_event.sh "1"
when in
motion_external = 2
Also I can see
Start capture requested from Pipe
But no capture is made.
Issuing
echo "im" > FIFO1
does not do anything while
echo "im" > FIFO11
creates an image.

FIFO is the main command pipe for raspimjpeg to accept commands
FIFO1 is a special pipe used to communicate motion detections FROM raspimjpeg back to the scheduler so that it can determine what to do when motion events occur. "1" signals a motion start, "0" signals a motion stop, "9" indicates raspimjpeg has changed settings so scheduler should restart.
FIFO11 (and FIFO12, .... FIFO20) are secondary command pipes that are equivalent to the main FIFO and can be used by other applications to avoid commands getting mixed up.
motion_external is set to 2 Settings can be
0 internal (recommended method for detection)
1 external use the older external motion process
2 monitor
monitor turns on internal and runs motion detection scripts BUT does not issue motion events to the scheduler via FIFO1. This is intended for use where you want to run motion scripts to do various things but not cause the scheduler to do anything. You won't get the normal scheduler starting and stopping captures when in this mode.
So first of all change the motion detect mode under camera settings back to internal

motion_external was 0 before. I was just experimenting a bit and wanted to check if the motion_event.sh script gets triggered. That's the case. What should I see in log when normal motion gets detected?

A motion triggered recording looks like
{2019/04/26 08:30:03} send smd 1 [2019/04/26 08:30:03] Start capture requested from Pipe [2019/04/26 08:30:03] Send ca 1 {2019/04/26 08:30:03} Capturing started {2019/04/26 08:30:14} send smd 0 [2019/04/26 08:30:14] Stop capture requested [2019/04/26 08:30:14] Send ca 0 {2019/04/26 08:30:14} Capturing stopped {2019/04/26 08:30:14} Add /var/www/media/vi_0002_20190426_083003.mp4 to Box Queue at pos 2 {2019/04/26 08:30:14} Executing macro /var/www/macros/end_vid.sh "/var/www/media/vi_0002_20190426_083003.h264"  {2019/04/26 08:30:14} Start boxing /var/www/media/vi_0002_20190426_083003.h264 to /var/www/media/vi_0002_20190426_083003.mp4 Queue pos 2 {2019/04/26 08:30:15} Finished boxing /var/www/media/vi_0002_20190426_083003.mp4 from Box Queue at pos 2 {2019/04/26 08:30:15} Removed item from Box Queue
I notice that your commands are ca 1 and ca 0. I have ca 1; and ca 0; where the semicolon terminates a command. It is possible a change has meant that is required at the end of commands. I'll check that.

Awesome. Looks like that was the issue!


feat: add rateLimit event

Closes #349

I guess Commit 9bc52d2 has unnecessary changes to this PR

I guess Commit 9bc52d2 has unnecessary changes to this PR


TrackedArray missing types

A tracked array's type from a consumer app only has these properties: https://github.com/pzuraq/tracked-built-ins/blob/master/addon/-private/array.ts#L110-L121
but we can use all of these: https://github.com/pzuraq/tracked-built-ins/blob/master/addon/-private/array.ts#L9-L32
but typescript is not aware of them, cause Proxies and TS are.. not great :upside_down_face:
Since Object.setPrototypeOf(TrackedArray.prototype, Array.prototype); is a thing, I wonder if the TrackedArray class should extend from Array? idk

This is resolve by v1.1.1 (via #56)!


Add a named symbol to represent ⪰

Description
This is a feature request from https://discord.com/channels/1054443721975922748/1235249773876084778
Specifically, it requests a new named symbol (like #sym.arrow) to represent ⪰.
This issue shall discuss a proper name for ⪰.
Use Case
With this new feature, we can use something like #sym.gt.curly.seq (suggested by naoppy, the author of that discord thread) to represent ⪰:
#sym.gt.curly.seq

$ gt.curly.seq $

At the same time, some relative symbols shall be added? They are ⪯, ⪱, ⪲.

Maybe they can be named:

⪰: #sym.gt.curly.seq
⪲: #sym.gt.curly.seq.not
⪯: #sym.lt.curly.seq
⪱: #sym.lt.curly.seq.not


mux-demo: remove dependency on io-sim

The mux-demo doesn't depend on the io-sim package.
I believe this is the only reason cardano-node needs to list io-sim as a
source-repository-package. In cardano-node, the tests are disabled for all
dependencies, but we can't disable building executables in dependencies, e.g.,
mux-demo.

bors merge

Uggh, I was wrong. ouroboros-network has an internal ouroboros-protocol-tests library which also depends on io-sim, but Cabal seems to build all internal libraries, even when they're only needed for tests. This means cardano-node will still need to list io-sim as a source-repository-package.


fix: import path bug

Pull Request Test Coverage Report for Build 526251960

9 of 9 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 95.72%

Totals

Change from base Build 526213864:
0.1%

Covered Lines:
798

Relevant Lines:
821

💛  - Coveralls


[utf8-range] New port

[x] Changes comply with the maintainer guide
[x] The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
[x] Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
[x] The versioning scheme in vcpkg.json matches what upstream says.
[x] The license declaration in vcpkg.json matches what upstream says.
[x] The installed as the "copyright" file matches what upstream says.
[x] The source code of the component installed comes from an authoritative source.
[x] The generated "usage text" is accurate. See adding-usage for context.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is in the new port's versions file.
[x] Only one version is added to each modified port's versions file.

All features passed with following triplets:
x86-windows
x64-windows
x64-windows-static
Due to the following declaration, this port download from https://github.com/protocolbuffers/protobuf instead of https://github.com/protocolbuffers/utf8_range.
As of November 9, 2023, utf8_range has moved into the protobuf repo here. All further development is happening there, and this repo is no longer being updated.

Due to the following declaration, this port download from https://github.com/protocolbuffers/protobuf instead of https://github.com/protocolbuffers/utf8_range.
As of November 9, 2023, utf8_range has moved into the protobuf repo here. All further development is happening there, and this repo is no longer being updated.

With this new port building from the protobuf report, does it need to be de-vendored from the protobuf port?

@Cheney-W , @vicroms
@dg0yt is right. This library is automatically installed alongside regular protobuf builds. If we add it as a port, we have to patch protobuf to consume it instead. I suggest we remove this port again, can that be done?


Converting an empty string to undefined

We're having trouble creating an optional email field.  Our JSON schema has type: 'string', format: 'email', which means that the field, if present, is validated on server side to be an email address.
We want the field to be optional, so that if the user does not type anything, it is left missing.  What is currently happening is that the empty text field is converted into an empty string, which fails the email validation server-side.
Is there a way instruct Angular schema form to convert an empty string into a missing value?  I'd think this would have other uses as well wrt optional fields.
Overall there seems to be a disparity between how JSON schema validation and Angular schema form interprets 'required' fields:  A JSON schema will validate a required field if it is an empty string, but Angular schema form interprets a required field to mean a non-empty string.

@plaa I believe this is more of an Angular behaviour than a ASF behaviour from memory. There are a few ways to do it, you can have a tick box in the form definition that determines if the email is required, such as say, contact method, this allows you to set a destroy behaviour to remove the value from the form.
Please re-open if you do not feel the question has been answered sufficiently.


[ci] check the chart version was bumped

This PR adds a checker into ci. The checker does confirm whether it updates the chart version was bumped and cause an error if the chart version didn't bump. As a result, we can prevent to merge the chart didn't bump version.
Execution examples

PASSED: bumped the version
https://github.com/chatwork/charts/compare/check-version-was-bumped...50f900c
https://circleci.com/gh/chatwork/charts/903
========================================
[php] diff version
-version: 0.13.3
+version: 0.13.4
========================================

FAILED: did not change the version
https://github.com/chatwork/charts/compare/check-version-was-bumped...ab8f24a
https://circleci.com/gh/chatwork/charts/904
========================================
[php] diff version

========================================
You must bump the Chart version!

FAILED: changed the version to lower
https://github.com/chatwork/charts/compare/check-version-was-bumped...90446a5
https://circleci.com/gh/chatwork/charts/905
========================================
[php] diff version
-version: 0.13.3
+version: 0.13.2
========================================
You must bump Chart version!

PASSED: added a new chart
https://github.com/chatwork/charts/compare/check-version-was-bumped...5d92d6d
https://circleci.com/gh/chatwork/charts/906
========================================
[new-chart] diff version
+version: 0.0.1
========================================

PASSED: bumped the version and stripped quotes
https://github.com/chatwork/charts/compare/check-version-was-bumped...7665d88
https://circleci.com/gh/chatwork/charts/907
========================================
[twistlock-console] diff version
-version: "0.0.3"
+version: 0.0.4
========================================

Thank you for the wonderful PR!
I was in trouble with this problem.


Fix the flickering of the line gutter icon when saving

Before
After

Also fixes some missing hints when refocusing the editor while editing externally.

Thanks!


Psi4 Harness

Psi4 calculations now run through QCEngine

Codecov Report

Merging #17 into master will increase coverage by 0.29%.
The diff coverage is 19.35%.

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   44.61%   44.91%   +0.29%
==========================================
  Files          78       77       -1
  Lines       12782    12697      -85
==========================================
  Hits         5703     5703
+ Misses       7079     6994      -85

Impacted Files
Coverage Δ

qcdb/intf_psi4/__init__.py
100% <100%> (ø)
:arrow_up:

qcdb/intf_psi4/runner.py
32.89% <18.03%> (+13.89%)
:arrow_up:

qcdb/intf_psi4/worker.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ff034d...3e3c202. Read the comment docs.


Master

new aNights Black Agents sheet with fixes and smaller

This commit has a bunch of things wrong with it. I think your best bet is going to be to start your branch over from scratch. You'll want to copy all of your work to a separate location, delete your branch, and fork from master again. Then copy your changes back to your new, fresh, branch.

You are adding a second folder for Night Black Agents v2. Instead of making a new folder, make changes to the original folder.

understood. I will do all that.
Thank you for your checking of my work.
2016-05-31 18:03 GMT+02:00 Phil<EMAIL_ADDRESS>
This commit has a bunch of things wrong with it. I think your best bet is
going to be to start your branch over from scratch. You'll want to copy all
of your work to a separate location, delete your branch, and fork from
master again. Then copy your changes back to your new, fresh, branch.

You are adding a second folder for Night Black Agents v2. Instead of
making a new folder, make changes to the original folder.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Roll20/roll20-character-sheets/pull/1656#issuecomment-222736270,
or mute the thread
https://github.com/notifications/unsubscribe/ASdEVPIwSe6PnKU3-pJtWravemm7gEBfks5qHFvkgaJpZM4Il2cj
.


Fix: version32.rc was not created on Windows

version32.rc was not created on Windows. The if condition has been corrected.

+1

pushed at 7839b73 thanks!


resourceFolder of a folder is it's parent

Testing #107638
resourceFolder of a folder is it's parent. I find this slightly confusing.
I thought a resourceFolder of a folder resource is itself.
Maybe resourceDirname would be a better name to allign better with Node and then users might not be surprised
https://nodejs.org/api/path.html#path_path_dirname_path
Sorry for not providing this feedback earlier. Just my 2 cents

Yeah, I am with you. It tripped me up at first as well. I will rename to resourceDirname as you suggest. Thanks!

Great, thanks!


Fix battery drain for mobile clients

Regarding too frequent IDLE notifications mobile clients like k9mail have a massive battery drain.
More info:
https://github.com/k9mail/k-9/issues/1290
https://peterkieser.com/2011/03/25/androids-k-9-mail-battery-life-and-dovecots-push-imap/
P.S. Please correct me if I have to add additional changes. I've read contributing guide, but this change doesn't affect tests and build step.

As mentioned on http://wiki.dovecot.org/Timeouts after login client idle timeout is set to 30 minutes, so it wouldn't affect desktop clients and others.

Thanks @huncode


Cannot input space in the terminal sometimes.

iPhone11
iOS15.3.1
I run some commands in the terminal, after then I cannot input space sometimes. This will be solved after restarting the app.
By the way, I hope the app will support copying and pasting in the terminal.

I can confirm this

I can confirm this with Chinese keyboard.


feat(satellite,electric): Implement distributed tracing using OpenTelemetry in the client

This is a follow-up to https://github.com/electric-sql/electric/pull/1370.
Besides adding OT to the client, here we also implement the passing of client's tracing context to the server in RPC calls across the network boundary. The GH Actions workflows that run E2E tests are updated to enable the export of client traces to Honeycomb.io where each test gets its own ci.test_file attribute and a bunch of other CI-related attributes.

@msfstef Can you help me out here with addressing Kevin's feedback?
I see there are merge conflicts but haven't rebased so as not to mess up code comments from Kevin.

👋 we've been working the last month on a rebuild of the Electric server over at a temporary repo https://github.com/electric-sql/electric-next/
You can read more about why we made the decision at https://next.electric-sql.com/about
We're really excited about all the new possibilities the new server brings and we hope you'll check it out soon and give us your feedback.
We're now moving the temporary repo back here. As part of that migration we're closing all the old issues and PRs. We really appreciate you taking the time to investigate and create this improvement!


[FOLLOW UP] Support row_number() filters for GpuWindowGroupLimitExec

This is a follow up task for #10500.
#10500 added support for running WindowGroupLimitExec. This allows the Spark Plugin to pre-filter rows that may be eliminated by filters on the result of RANK() and DENSE_RANK.
It would be good to implement a similar optimization can be done for ROW_NUMBER() filters as well.   This isn't a big stretch.  The main challenge is that ROW_NUMBER() is currently implemented as a window function instead of a group scan.

I'm working on this now.
For the moment, I will not be addressing the shortcoming in CUDF that row_number runs as a window function, currently.  That is left to be addressed in the future.

I've been looking at this some more.  It appears that the query plan for RANK() and ROW_NUMBER() do not behave similarly on Apache Spark 3.5.0, with regard to the application of WindowGroupLimit and pre-filtering.
Here is the kind of query we're running:
SELECT * FROM (
  SELECT *,
         RANK() OVER (ORDER BY oby) rnk,
         ROW_NUMBER() OVER (ORDER BY oby) rnum
  FROM mytable
)
WHERE rn < 4

Here's the Apache Spark plan when running RANK():
== Physical Plan ==
*(3) Filter (rn#117 < 4)
+- Window [rank(oby#11L) windowspecdefinition(oby#11L ASC NULLS FIRST, specifiedwindowframe(RowFrame, unboundedpreceding$(), currentrow$())) AS rn#117], [oby#11L ASC NULLS FIRST]
   +- WindowGroupLimit [oby#11L ASC NULLS FIRST], rank(oby#11L), 3, Final
      +- *(2) Sort [oby#11L ASC NULLS FIRST], false, 0
         +- Exchange SinglePartition, ENSURE_REQUIREMENTS, [plan_id=436]
            +- WindowGroupLimit [oby#11L ASC NULLS FIRST], rank(oby#11L), 3, Partial
               +- *(1) Project [id#9L AS oby#11L, 1 AS gby#13]
                  +- *(1) Range (200, 300, step=1, splits=64)

This is as expected:  WindowGroupLimit is introduced for both partial and final aggregation.  DENSE_RANK() behaves identically.
The same optimization does not seem to be present for ROW_NUMBER():
== Physical Plan ==
*(2) Filter (rn#135 < 4)
+- Window [row_number() windowspecdefinition(oby#11L ASC NULLS FIRST, specifiedwindowframe(RowFrame, unboundedpreceding$(), currentrow$())) AS rn#135], [oby#11L ASC NULLS FIRST]
   +- TakeOrderedAndProject(limit=3, orderBy=[oby#11L ASC NULLS FIRST], output=[oby#11L,gby#13])
      +- *(1) Project [id#9L AS oby#11L, 1 AS gby#13]
         +- *(1) Range (200, 300, step=1, splits=64)

There is no WindowGroupLimit at all for ROW_NUMBER().
The optimization can't be applied the same way as we have done with RANK().
I'll check other Spark versions, to see where this might come in.


Opening Todo with trouble breaks Trouble

When I run :TodoTrouble, the todos are showed perfectly, but when i run :Trouble i only see my todos, instead of code errors.
Even :TroubleRefresh doesnt fix it. In case it may be a configuration issue, my config is at https://github.com/Tesohh/nvim.

:Trouble document_diagnostics


Correct reference project name

Purpose
Correct reference project name in using-scheduled-tasks.md

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


test: use active deployment templates for acc tests

Description

Update acceptance tests with active deployment templates
Update instance configurations according to updated templates
Remove deprecated templates tests
Related Issues

Rel: https://elasticco.atlassian.net/browse/CP-9159
Motivation and Context

We need to fix the acceptance tests since we now block deprecated deployment templates in the cloud.
How Has This Been Tested?

:loading:
Types of Changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactoring (improves code quality but has no user-facing effect)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation

Readiness Checklist

[x] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[x] I have added tests to cover my changes
[x] All new and existing tests passed

@gersonsosa , it seems there are still some DT and IC related failures in acc tests.

@dimuon I discussed this with @andrew-moldovan and we think we can merge this changes now and create a separate issue I will pick immediately to fix the bug with the apm component since the bug was already present in the provider, I created this issue https://elasticco.atlassian.net/browse/CP-9334

finally is green, I'll enable some of the tests I skipped here after https://elasticco.atlassian.net/browse/CP-9334 is fixed


astropy 5.2 ModuleNotFoundError

I've setup a new environment using environment-dev.yaml and encountered a ModuleNotFoundError: No module named 'astropy._erfa' Error when import rascil (rascil==0.7.0) was called. This was caused by astropywhere the version wasastropy==5.2(release 12.12.2022). However, as soon as I've downgraded toastropy==5.1.1` the error didn't occur anymore.
Since the error is thrown through RASCIL I think we should specify the version also in the RASCIL build (and if possible not in  environment-dev.yaml). In addition, we have to check whether it is also an issue in RASCIL 0.7.1 #157 )

This is now updated via Rascil and #236 will include the removal of astropy as dependency in Karabo. The version of astropy will be defined only in our rascil-build.

Nice. I merged the PR and therefore close this issue.


[Question]: max_token auto adjust for completion requests but not chat requests

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
I recently ran into an issue where our gpt 3 turbo requests were producing too many tokens which would put us over the limit causing an error. After looking into solutions i noticed that completions automatically adjust the max token limit for the request while chat requests don't.
I was curious if i was missing some alternative way of handling this case or if there was a specific reason why the functionality existed for one version but not the other.

To clarify on the specific situation we were encountering this problem: we were using TreeSummarize on doucments with GPT 3.5 turbo and midway through summarizing a document we would encounter this issue of too many tokens being used for a request.


When will the code be released?

The authors are working on the NeurIPS submission now. We will release the code in mid or late May.

谢谢


cache content and source requests

these requests could be easily cached in either HTML local storage or Websession storage.

Source code is already cached as current source code editor content is stored in a local session storage to allow user to switch sections without loosing edited source code. I don't think content needs to be cached as the the first request will get most of expensive resources and the next display will produce almost just cache hits.


fix(json-schema): handle array type without items keyword

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fix issue in which an array without an items keyword causes an error in
FormlyJsonschema.toFieldConfig().
What is the current behavior? (You can also link to an open issue here)
fix #2884
What is the new behavior (if this is a feature change)?
FormlyJsonschema.toFieldConfig() now returns {} for items in an array without an items keyword, instead of throwing an error.
Please check if the PR fulfills these requirements

[x] The commit messages follow our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
[x] A unit test has been written for this change.
[x] Running npm run build produced a successful build. (Unit testing can be done by running npm test;)
[x] My code has been linted. (npm run lint to do this. npm run build will fail if there are files not linted.)

An equivalent patch would most likely also work for the v5 branch. I had trouble getting v5 to build and was unsure of the protocol to suggest a patch that would work on multiple branches, so that assertion remains untested at the moment.

close in favor of #2914


refactor: migrate backfill tests to deterministic integration tests

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Part of #12957

Refactor the background ddl tests. Moved them to deterministic tests, to make the tests more stable and maintainable.
Improve trace level logging of no_shuffle_backfill to debug some bug.
Fix error log of FlowControlExecutor, previously it used to wrong number to indicate cardinality.
Found a bug: progress.finish is called before yielding barrier which comes after snapshot read finished. This means the materialized view will be made visible to user, and could be inconsistent with upstream table, if downstream is not yet flushed when user reads from it.
Fixed the bug by waiting for the next barrier, before calling progress.finish. I'm not sure if this is the best way 🤔 .

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Now just fixing the main-cron test. Seems like workload is too heavy

PTAL again @chenzl25 @BugenZhao

The PR description needs to be changed as well.

A related issue https://github.com/risingwavelabs/risingwave/issues/9178


XCode 10 and Swift 4.2 fails to build

Xcode10 fails to build . Whether there is an update plan

It would be awesome if someone replies to this thread. We would like to know if there is an update plan and  if so, its timeline.

BTW there is already pull request which fixes this issue: https://github.com/xmartlabs/XLPagerTabStrip/pull/617/commits/7b63bd0c01b01cd278a132d53fe73e17d439d4fa
So I guess they would do the merge as soon as it is tested.

Please release update for XCode 10 and swift 4.2 support...

Hi all, just merged a PR that should fix this. Try out the master branch


Improve API for raster creation?

While greenwich uses new raster creation under the hood all the time, I am wondering whether it would be worthwhile to expose it a little bit more conveniently to the user of the package, e.g. in order to create rasters from numpy arrays.
Do you think that it would be worth working on or are the few cases where you actually would create rasters from scratch sufficiently covered by the Python GDAL bindings?

I think raster generation is mostly covered here. To your example, going from ndarray to Raster can be achieved in a fairly straightforward manner using frombytes() like:
raster.frombytes(arr.tobytes(), (10, 10, 3), gdal.GDT_Float32)

Let me know if you have any other specific uses which may not be accounted for.

Ok. Close this for now.


New-ADServiceAccount documentation regarding SamAccountName is incorrect

The documentation for SamAccountName states the following:
-SamAccountName <String>
    Specifies the Security Account Manager (SAM) account name of the user, group, computer, or service account. The maximum length of the description is 256 characters. To be compatible with older operating systems, create a SAM account name that is 20 characters or less. This parameter sets the SAMAccountName for an account object. The LDAP display name (ldapDisplayName) for this property is "sAMAccountName".

The maximum length for this property is actually 14 characters or less (15 characters if you include the '$' that is automatically appended to the SamAccountName).  If you attempt to create a gMSA service account with a SamAccountName greater than this limit the following error message is displayed:
New-ADServiceAccount : The service account has a samAccountName attribute of 'gsvc-Automation-DNS' which is too long; the samAccountName attribute must not be longer than 15 characters
At line:1 char:1

New-ADServiceAccount 'gsvc-Automation-DNS' -DNSHostName 'gsvc-Automat ...

  + CategoryInfo          : InvalidArgument: (CN=gsvc-Automat...,DC=trow,DC=com:String) [New-ADServiceAccount], ArgumentException
  + FullyQualifiedErrorId : ActiveDirectoryCmdlet:System.ArgumentException,Microsoft.ActiveDirectory.Management.Commands.NewADServiceAccount

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 61e1e7e8-00f1-6b10-e19e-fdab4eb9d493
Version Independent ID: e66770b5-1cf3-617d-d7f6-6d334501075a
Content: New-ADServiceAccount (ActiveDirectory)
Content Source: docset/windows/addsadministration/New-ADServiceAccount.md
Product: w10
Technology: powershell-windows
GitHub Login: @AndreaBarr
Microsoft Alias: v-anbarr

The maximum length for this property is actually 14 characters or less (15 characters if you include the '$' that is automatically appended to the SamAccountName).

This is not true, the real fact is :
The maximum length for this property is actually 15 characters or less (16 characters if you include the '$' that is automatically appended to the SamAccountName).


Regression: SQLite fails to create create AUTO_INCREMENT big_integer

Description
Upgrade from sea-orm-migration = 0.11.3 to sea-orm-migrations = 0.12.6 breaks SQLite table creation with AUTOINCREMENT is only allowed on an INTEGER PRIMARY KEY
Steps to Reproduce

Create a simple SQLite table with big_integer as the index.

async fn up(&self, manager: &SchemaManager) -> Result<(), DbErr> {
        manager
            .create_table(
                Table::create()
                    .table(UserIden::Table)
                    .if_not_exists()
                    .col(
                        ColumnDef::new(UserIden::Id)
                            .big_integer() // <--- Works fine in sea-orm 0.11.3
                            .not_null()
                            .auto_increment()
                            .primary_key(),
                    )
                    .col(
                        ColumnDef::new(UserIden::Name)
                            .text()
                            .unique_key()
                            .not_null(),
                    )
                    .col(ColumnDef::new(UserIden::Pwd).text().not_null())
                    .col(ColumnDef::new(UserIden::Salt).text().not_null())
                    .col(ColumnDef::new(UserIden::IsAdmin).boolean().not_null())
                    .to_owned(),
            )
            .await
}

Everything works fine and the table is created correctly.

Upgrade sea-orm

Upgrade sea-orm / sea-orm-migrations to 0.12.6 and run the code above again. Now, the table creation breaks with AUTOINCREMENT is only allowed on an INTEGER PRIMARY KEY.
Expected Behavior
SQLite table is created with a big_integer index.
Actual Behavior
Table creation fails with AUTOINCREMENT is only allowed on an INTEGER PRIMARY KEY.
Reproduces How Often
Always
Workarounds
Instead of big_integer, integer can be used and the code works again. Unfortunatly that is not an option as the all database table are already created with big_integer, such that a migration to integer would break all of the production databases.
Versions
Upgrade from 0.11.3 to 0.12.6

Remark: The code works fine for PostgreSQL, it only affects SQLite.

Thank you for your report. Yes I am aware, and is tracked in https://github.com/SeaQL/sea-query/issues/689
The workaround is to change it to integer() for primary keys. I probably would fix it soon.

Thanks for the feedback. I looked here for an existing issue and didn't find one. Haven't though of looking in the sea-query repo. As the issue is already tracked, I'll close this one as a duplicate.

No worries!

Hey guys, any updates on this?
At 0.12.15, the table is created correctly but the generated struct Model has the primary key field of type i32 but not i64

You can try 1.0-rc

the issue still exists 1.1.2


Update readme

Description
Slight update to our readme since we now support more cloud providers. Also removed markdown separators as I find them useless, if it's an issue I can undo those changes.

Codecov Report

Merging #1306 (9ef1e41) into main (1e9a3fe) will increase coverage by 9.61%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1306      +/-   ##
==========================================
+ Coverage   72.32%   81.94%   +9.61%
==========================================
  Files         469      398      -71
  Lines       17412    14414    -2998
==========================================
- Hits        12594    11812     -782
+ Misses       4511     2309    -2202
+ Partials      307      293      -14

Impacted Files
Coverage Δ

pkg/terraform/plugin_client.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/remote/aws/client/s3_client_factory.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/remote/aws/init.go
0.00% <0.00%> (-95.57%)
:arrow_down:

pkg/remote/google/init.go
0.00% <0.00%> (-77.78%)
:arrow_down:

pkg/remote/google/repository/storage.go
0.00% <0.00%> (-76.93%)
:arrow_down:

...g/remote/google/repository/cloudresourcemanager.go
0.00% <0.00%> (-76.93%)
:arrow_down:

pkg/remote/github/init.go
0.00% <0.00%> (-76.32%)
:arrow_down:

pkg/remote/terraform/provider.go
6.08% <0.00%> (-68.25%)
:arrow_down:

pkg/terraform/provider_factory.go
0.00% <0.00%> (-62.50%)
:arrow_down:

pkg/resource/google/google_project_iam_member.go
46.15% <0.00%> (-53.85%)
:arrow_down:

... and 116 more


Action annotation from NuScenes

Hello! Amazin work!
I was wondering, how did you extract high-level action commands for NuScenes ("stop", "turn right" and so on). i have red some details in Section C.2, but can you also give details on the time conmsidered for such actions, or what do you mean for forawrd driving distance from nuscenes?
Moreover, do you think that the same approach as yours with SVD+ControlNet would work?
I have also seen that all other works uses others form of conditioning (e.g., bounding boxes of other objects, lane in BEV, ...). Are you using rgb frames only (+ actions) instead?
Thank you very much!

Yes, I think that different types of conditions exhibit different characteristics, and certain solutions are better suited for specific condition signals. However, as long as you training continues long enough, I think that multiple approaches can yield satisfactory results.
For additional action projections, I simply expand the dimension of the cross-attention layers to enable longer key and value inputs. You may refer to the implementation here:
https://github.com/OpenDriveLab/Vista/blob/main/vwm/modules/attention.py#L319-L324
I will release the scripts together with the necessary JSON files for training on nuScenes. I took a little rest this week, but I will work on releasing more stuffs as soon as possible.
Hope these are helpful :)

Hi, we have released all the scripts for training and sampling. Any feedback is appreciated!

Yes, we have provided all translated actions on nuScenes here.

BTW, you can also generate the ground truth trajectory and command on your own using the following code:
https://github.com/OpenDriveLab/ST-P3/blob/main/stp3/datas/NuscenesData.py#L505-L532

Thank you very much!!

Actually, I'm not very familiar with those specific parameters, and I didn't notice Kappa before. I choose steering angle just to follow previous works (DriveGAN, DriveDreamer, etc.) and because it is directly available from CAN bus. I may consider Kappa as a feature in future versions. The method should be the same.

"traj": [
2.842170943040401e-14,
0.0,
0.004099807857556925,
1.721318810349203,
0.003575851106660366,
3.6442674844633984,
0.003844690624902114,
6.042236588326432,
0.019102743037507253,
8.828964143841404
],
I think this traj should be cmd 0, but in nuscenes.json, its action is cmd 3

Hi @zxduan90,
Sorry for the confusion. The mapping between displacements and commands is: "turn right" -> 0, "turn left" -> 1, "stop" -> 2, "go straight" -> 3. Therefore, the given translation is correct.

Hi @zxduan90,
Sorry for the confusion. The mapping between displacements and commands is: "turn right" -> 0, "turn left" -> 1, "stop" -> 2, "go straight" -> 3. Therefore, the given translation is correct.

@Little-Podi Thanks for replay.

I'm closing this issue due to its inactivity. Free feel to reopen it if you have further questions.


Port to Azure Functions (Isolated)

Azure Functions (isolated .NET worker) can now also have middleware, but that middleware model is specific to Functions.
Need to reimplement and push as a separate package.

Done


Enable Go Modules

Fortunately the library is pre-1.0.0, so adding go modules here is trivial.

Awesome, thanks for adding this!


Add tooltip to <.button>

Ported the same tooltip from icon_button to button.

Sorry we do changelog stuff a bit different in Petal Components.. see instructions in release.exs. Just need to create a RELEASE.md file in the root dir

Oh cool, do you want me to fix it up or are you doing it? :)

I just added the RELEASE.md for your other PR - so maybe just pull the latest and move your changes off CHANGELOG into RELEASE

Done!

released in v1.2.3

Had to revert this commit due to issues with icons in buttons:

Oh whoops, let me take a look, will issue a new PR if I've got a fix.


S2U-50: Microsoft Collaborative Documents

s2u-50 in capital letters please, in the commit, S2U-50

Good job! And this is all with the Microsoft work!


minialloc: resolve inconsistent verification failures on darwin

Closes https://github.com/dashpay/bls-signatures/issues/54

"Fixes" don't hold up to repeated CI runs, closing


As a employee, I want to know the population distribution within each continent, including the total population, the population of people living in cities, and the population of people not living in cities.

For the population reports, the following information is requested:
The name of the continent/region/country.
The total population of the continent/region/country.
The total population of the continent/region/country living in cities (including a %).
The total population of the continent/region/country not living in cities (including a %).


Clarify what can be set with trusted_facts

Closes #653

Coverage remained the same at 91.761% when pulling fcfed241ccf4a2e11a5e6641feeeccc46147f6a4 on jeefberkey:trusted_facts into f40038ca014cc70356fc680c19c88207a2bbf5f9 on rodjek:master.


View: Rename View Menu Item

Testing #16783
Should we name the context menu Additional Views vs Additional Viewlets
I'm not massively passionate but it may make more sense to the user i.e. viewlet is to some degree our own internal language vs the way we show it in the menu or the command palette.
For instace we in this image we use the word view bar so it fells like it would be more consistent.

Yes, makes sense.


Enhance startswith argument usage for python 3.5 compatibility

Connect #300.

Coverage remained the same at 90.777% when pulling 9bbd8aad6b6c1de4ee24bbf2dcbb1be5831ddb72 on jangsutsr:issue300 into fb6540b605fab703307c11f4544ba6c3e4ad5e1c on ansible:master.


Sending Mavlink Data with msg_act_bytes = str(controls).encode('utf-8')

Recently I tried to send with the Socket which is Data from Mavlink.
def send_data(data, ip='<IP_ADDRESS>', port=12345):
# Create a UDP socket
sock = socket.socket(socket.AF_INET, socket.SOCK_DGRAM)
    try:
        # Send data
        sock.sendto(data, (ip, port))
    finally:
        # Close the socket
        sock.close()
msg_act_bytes = str(controls).encode('utf-8')
send_data(msg_act_bytes)
print('msg_act_bytes:', msg_act_bytes)

And it is printing Well inside the program as
msg_act_bytes: b'[-1.2000000476837158, -1.2000000476837158, -1.2000000476837158, -0.10000000149011612, -1.2000000476837158, -1.2000000476837158, -1.2000000476837158, -1.2000000476837158, -1.2000000476837158, -1.2000000476837158, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0]'

By Following the Tutorial, I change data from
#pragma once
#include "Serialization/Archive.h"
#include "UDPData.generated.h"
USTRUCT(BlueprintType)
struct FUDPData {
GENERATED_USTRUCT_BODY()
UPROPERTY(EditAnyWhere, BlueprintReadWrite, Category = "UDPCommunication")
float float1 = 0.0f;
UPROPERTY(EditAnyWhere, BlueprintReadWrite, Category = "UDPCommunication")
float float2 = 0.0f;
UPROPERTY(EditAnyWhere, BlueprintReadWrite, Category = "UDPCommunication")
float float3 = 0.0f;
UPROPERTY(EditAnyWhere, BlueprintReadWrite, Category = "UDPCommunication")
float float4 = 0.0f;
UPROPERTY(EditAnyWhere, BlueprintReadWrite, Category = "UDPCommunication")
float float5 = 0.0f;
UPROPERTY(EditAnyWhere, BlueprintReadWrite, Category = "UDPCommunication")
float float6 = 0.0f;
UPROPERTY(EditAnyWhere, BlueprintReadWrite, Category = "UDPCommunication")
float float7 = 0.0f;
UPROPERTY(EditAnyWhere, BlueprintReadWrite, Category = "UDPCommunication")
float float8 = 0.0f;
UPROPERTY(EditAnyWhere, BlueprintReadWrite, Category = "UDPCommunication")
float float9 = 0.0f;
UPROPERTY(EditAnyWhere, BlueprintReadWrite, Category = "UDPCommunication")
float float10 = 0.0f;
UPROPERTY(EditAnyWhere, BlueprintReadWrite, Category = "UDPCommunication")
float float11 = 0.0f;
UPROPERTY(EditAnyWhere, BlueprintReadWrite, Category = "UDPCommunication")
float float12 = 0.0f;
UPROPERTY(EditAnyWhere, BlueprintReadWrite, Category = "UDPCommunication")
float float13 = 0.0f;
UPROPERTY(EditAnyWhere, BlueprintReadWrite, Category = "UDPCommunication")
float float14 = 0.0f;
UPROPERTY(EditAnyWhere, BlueprintReadWrite, Category = "UDPCommunication")
float float15 = 0.0f;
UPROPERTY(EditAnyWhere, BlueprintReadWrite, Category = "UDPCommunication")
float float16 = 0.0f;
UPROPERTY(EditAnyWhere, BlueprintReadWrite, Category = "UDPCommunication")
float float17 = 0.0f;
UPROPERTY(EditAnyWhere, BlueprintReadWrite, Category = "UDPCommunication")
float float18 = 0.0f;
UPROPERTY(EditAnyWhere, BlueprintReadWrite, Category = "UDPCommunication")
float float19 = 0.0f;
UPROPERTY(EditAnyWhere, BlueprintReadWrite, Category = "UDPCommunication")
float float20 = 0.0f;
UPROPERTY(EditAnyWhere, BlueprintReadWrite, Category = "UDPCommunication")
uint8 uint1 = 0;
UPROPERTY(EditAnyWhere, BlueprintReadWrite, Category = "UDPCommunication")
uint8 uint2 = 0;
UPROPERTY(EditAnyWhere, BlueprintReadWrite, Category = "UDPCommunication")
uint8 uint3 = 0;
UPROPERTY(EditAnyWhere, BlueprintReadWrite, Category = "UDPCommunication")
TArray controls;
FUDPData() {
controls.Init(0.0f, 20);
}
};
FORCEINLINE FArchive& operator<<(FArchive &Ar, FUDPData &Structure)
{
Ar << Structure.float1;
Ar << Structure.float2;
Ar << Structure.float3;
Ar << Structure.float4;
Ar << Structure.float5;
Ar << Structure.float6;
Ar << Structure.float7;
Ar << Structure.float8;
Ar << Structure.float9;
Ar << Structure.float10;
Ar << Structure.float11;
Ar << Structure.float12;
Ar << Structure.float13;
Ar << Structure.float14;
Ar << Structure.float15;
Ar << Structure.float16;
Ar << Structure.float17;
Ar << Structure.float18;
Ar << Structure.float19;
Ar << Structure.float20;
Ar << Structure.uint1;
Ar << Structure.uint2;
Ar << Structure.uint3;
Ar << Structure.controls;
return Ar;
}
And I tried to build

I would like to recieve the data msg_act_bytes: b'[-1.2000000476837158, -1.2000000476837158, -1.2000000476837158, -0.10000000149011612, -1.2000000476837158, -1.2000000476837158, -1.2000000476837158, -1.2000000476837158, -1.2000000476837158, -1.2000000476837158, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0]'
and print it. I will be glad it you can help me with your plugin for this issue.

@extall can you help me this issue? I search almost all documentation including
https://nerivec.github.io/old-ue4-wiki/pages/udp-socket-sender-receiver-from-one-ue4-instance-to-another.html#Post_4.12
I am new for unreal engine as well as plugin.
Could you help me for this issue? Thanks~


Correction for raw affiliation IRSTEA, UMR TETIS, Montpellier cedex 5, France

Correction needed for raw affiliation IRSTEA, UMR TETIS, Montpellier cedex 5, France
raw_affiliation_name: IRSTEA, UMR TETIS, Montpellier cedex 5, France
new_rors: 026tc4g97;0458hw939
previous_rors: 026tc4g97
works_examples: W4255742959
contact: 39ad2796e9e4fa11f54274669cbc9afc:3ee0707ce23007ad5b0bab21f533c0264bfc @ inrae.fr

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


[TumbleBit] GET connect call should connect to the server

Right know GET connect just provides a cached response, however it should download TB information every time, because the Tumbler might have changed its parameters and that could  have further implications.

https://github.com/BreezeHub/Breeze/pull/9


Issue #26 Switch-to-projects/packages: support for packages built from multiple projects

This commit implements the custom JSON convertor and updates the corresponding functions to support a list of project paths instead of a single path. This fixes issue #26 for switching between projects and packages.
I have tested switching between projects and packages with my own solution that includes the nuget package "OPCFoundation.NetStandard.Opc.Ua" built from UA-.NETStandard and with the Nswag project. This all seems to be working fine.

Awesome, thanks for the PR. Looks good! Will review and merge soon - i’m in holidays so might take some days :-)


Setup script improvements: install Node & don't run migrations

A setup script should install all necessary dependencies. We weren't installing the version of Node here. However, this introduces another dependency on nodenv, which we don't install as part of the script - should we?
Running the migrations failed for me running locally, due to not having a NODE_ENV variable set at the time of running the script. It runs as part of npm run start:dev anyway with the right env variables, so it should be fine to remove here.

LGTM 👍

/rebase


Edit: Removed ticket / issue.

Edit: Removed ticket / issue. Thanks

@geraldb Hey—sorry I was in mountains few days—feel free to add your projects via a pull request. 😄

@IonicaBizau  Thanks for the great list. Keep it up. No worries. Cheers.


custom sort?

What's the easiest way to do a custom sort of a dataframe? For example, I have a column with string values like 10/04/2014 04:10:10 p.m. and I would like to sort them by the date that represents (ascending).
If this is not easily possible, consider this a feature request. Thanks for a useful package.

Hi @dtenenba,
Adding support for more types has been brought up earlier. Please see this thread
https://github.com/kniren/gota/pull/27
Since above is not yet available. If I were to do the custom sort, my quick and dirty way would be to -
range over df.Col("mytimecolumn").Records() converting the value to time.Time and sorting the resultant array. Then use maps to create a new dataframe that is sorted the way you need.
This solution of course does not keep in mind that your data set has duplicate rows in "mytimecolumn".
Thanks to kniren.


Vehicle stopped in planning simulator near roundabout

Checklist

[X] I've read the contribution guidelines.
[X] I've searched other issues and no duplicate issues were found.
[X] I'm convinced that this is not my fault but a bug.

Description
While testing our map in planning_simulator, I realized that the vehicle stopping always while turning roundabout.
Then we realized that after the vehicle stopped, the drivable area marker changed. I added a video to see the problem.
https://github.com/autowarefoundation/autoware.universe/assets/45468306/16b9d479-7868-477a-b6e8-37409d82d8dc
Expected behavior
The vehicle should not change its velocity to zero.
Actual behavior
The vehicle stops at the nearby roundabout and after that drivable area marker changes and starts driving. I think it is because of some bugs in the drivable area package.
Steps to reproduce

Versions

Possible causes

Additional context
No response

@brkay54 Thank you for creating the issue.
Could you create a scenario and share it here (under steps the reproduce section) with the HD-Map you used to create the scenario?

Looking at the lanelet2 map and symptoms, I think it could be the same problem as in https://github.com/autowarefoundation/autoware.universe/issues/3368#issuecomment-1508048547

@beyzanurkaya
Could you create a scenario and share it here (under steps the reproduce section) with the HD-Map you used to create the scenario?

@mehmetdogru
This one is the 14th November Autoware Test;
https://github.com/autowarefoundation/autoware.universe/assets/32412808/8e1be247-e42b-4b4d-afb6-ed5d3569c0ba
This one is the today Autoware Test;
https://github.com/autowarefoundation/autoware.universe/assets/32412808/a18ab6e2-5136-40a3-9356-7c02f2d896fa
Then this was the commit that solved this problem: https://github.com/autowarefoundation/autoware.universe/commit/32f0547d62e0e031708dc92ea59de254e1de56a5


[#857] Fix some regressions in JPQLNext parser

Fixes #857

Not really, the cases that you mention did not change compared to before your parser rework commit so I did not touch them.
I would need to disable expression caching to create a test case that triggers this behavior - ok?

True but the cases I mentioned should also allow object results.
You shouldn't need a cache to reproduce this. If you do, that would be a bug.

True but the cases I mentioned should also allow object results.

Ok, I will apply the changes then.

You shouldn't need a cache to reproduce this. If you do, that would be a bug.

Expression caching itself is a bug at the moment. The cache keys need to consider the various flags that influence behavior of parsing and the expression visitor which is currently not the case. If it was implemented that way, those regressions (and possibly the additional cases you mentioned) would have come up with the existing tests I think.
I can fix the expression caching in the course of this issue.

Please create constants for the bit masks

Checkstyle issues: https://travis-ci.org/Blazebit/blaze-persistence/jobs/592945474#L953


BPTC - CompressorSIMD.cpp doesn't compile

CompressorSIMD.cpp in BPTCEncoder doesn't compile. Multiple errors

Thanks for the feedback. We'll look into this. The current SIMD branch on master hasn't been updated in quite some time. We started a separate ground-up rewrite a few years ago, but that hasn't come close to being finished. In the meantime, if you'd like a fast, good SIMD compressor, I suggest you take a look at the ISPC compressor from Intel.

It wasn't so hard to fix the SIMD files issues. I had a weird problem though. If I use the fast floating point mode in Visual Studio 2015, the generated texture is pixelated. If I use precise, it works as expected. I tried to change some fpu settings, but I'm not a SSE guru, so I didn't have any luck, will just live with the precise mode.
I don't want to deal with the  ISPC compiler if possible. Also, I need something easy to hack that can give me reasonable result very fast. I was able to tweak FasTC to be a lot faster and still get decent result. It's nothing clever, just more error tolerance. But for my purpose, if I can get slightly worse result for 10x speed up, I would take it. On the Sponza scene for example, the NVIDIA driver can compress the 160 MB textures in 10 sec. The quality is pretty bad of course.  Currently, I'm getting 30 sec with FasTC on 6 core machine, which is not bad. My multi-threading is not optimal, since I load and compress in the same thread, so there is a lot of idling at the end. With better MT, it should be like 20 sec.

Hi, sorry I haven't responded in a while.
How did you compile it in the first place?  Did you hack the CMake file?

No, I made a project in Visual Studio. Then tried to match the changes from the non-SIMD version. It wasn't much work, but of course, I'm not sure if everything was working.


Litters Detail view and tabs

Need to address if we will use Files and More tab on the Litter view, or if we will ditch them.

also, the Export button in the menu should probably be removed

Also remove upload button from desktop view, and export from mobile menu.


License missing

Package doesn't have license.
I'm trying to package dnsx for Fedora. blackrock is a dependency formapcdir  that is a dependency for dnsx. In order to create the package for Fedora a license is required.

thank you for pointing it out @mikelolasagasti, added now.

Mac M1, error
:40:6: invalid operation: r << (r & 4) (shift count type int64, must be unsigned integer)
crypto/x509
/usr/local/go/src/crypto/x509/root_cgo_darwin.go:16:10: fatal error: 'CoreFoundation/CoreFoundation.h' file not found
#include <CoreFoundation/CoreFoundation.h>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.


Motion with shift + { and shift + } doesn't work properly

I have tried multiple files with different languages/syntax.
Using shift + } doesn't always seem to work while shift + { sometimes jumps to the previous empty line and somewhere in the middle of a code block.
In a coffeescript file (for example) the cursor jumps back and forth to the beginning and end of the file.
I myself and most probably a bunch of other 'VIM' users heavily depend on this functionality as it makes the user able to navigate very quickly through code. I really, really miss this functionality as in going back to gvim itself.

Agreed, I miss it too.
Technically base vim doesn't get shift+} right either...  it needs Ruby, Python, CoffeeScript, etc language files to override the binding and add some smarts.
I'm not sure vim-mode has a plan on how to allow per-language customization yet.  It's time to start that discussion.

As stated in the README, this package is no longer maintained and is deprecated. We recommend that people use the vim-mode-plus package instead. Because of this, we are archiving this repository and closing all issues and pull requests. Thanks very much for your support and contributions!


[AIRFLOW-214] Fix occasion of detached taskinstance

Dear Airflow Maintainers,
Please accept this PR that addresses the following issues:

AIRFLOW-214

For some reason occasionely taskinstances could become
detached from the database session. Now it uses a fresh session
to ensure the taskinstances stay attached.

[Current coverage][cc-pull] is 67.72%

Merging [#1574][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master      #1574   diff @@
==========================================
  Files           116        116
  Lines          8285       8285
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           5611       5611
  Misses         2674       2674
  Partials          0          0

Powered by Codecov. Last updated by [275aa15...5d72c7b][cc-compare]
[cc-base-branch]: https://codecov.io/gh/apache/incubator-airflow/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/apache/incubator-airflow/compare/275aa15faec0eb98e870709e2fb2a146b5a809cd...5d72c7bc32e12afeb017c62247e9c269edf08dc6
[cc-pull]: https://codecov.io/gh/apache/incubator-airflow/pull/1574?src=pr

Is there a JIRA for this?

Assuming this has something to do with parts of process_dags being dropped out of the transaction session?

Yes. Need to create Jira for it.

According to the JIRA, it's unclear why this is happening. Is this PR a guess? :)

The PR works, that is for sure. I do not understand why the task can get detached in the first place. Session should be consistent and it happens right after dagrun.get_task_instances. It does not happen every time but I could replicate it with example_skip_dag, but couldnt fix it by keeping the current session.

LGTM
Saw this in the test failures:
======================================================================
FAIL: Test that the scheduler handles queued tasks correctly
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/apache/incubator-airflow/tests/jobs.py", line 306, in test_scheduler_pooled_tasks
    self.assertEqual(ti.state, State.QUEUED)
AssertionError: u'scheduled' != u'queued'

But this is related to a separate PR that @jlowin and I are on, I believe.

+1


Pass TLS context

This builds on @terrycojones PR #394 for adding an ssl= keyword argument to ApplicationRunner by adding a similar corresponding Twisted API, and examples using a self-signed certificate for both asyncio and Twisted.
Essentially we just export the underlying asyncio or Twisted APIs so autobahn's API becomes no more unstable that either of those.
Python's documentation recommends using ssl.create_default_context and only exposes an API that allows you to set ssl= kwarg (which is precisely what the asyncio version of this is doing).
Twisted's documentation recommends using a CertificateOptionsinstance  as the sslContextFactory= kwarg to SSL4ClientEndpoint which is just what this code does.
Note if we merge/take this PR, #394 should be closed and remain unmerged (all terry's changes are in here, with correct author information). Or vice versa.

LGTM. I'm happy to close my pr, just let me know.


Clean up and bug fixes

Due to updates to the top command in 4.17:

Fixes a bug where the regex used for ram would cause a stacktrace
Fixes a bug where the regex for cpu usage would cause a stacktrace

These where older bugs and have never actually worked

Fixes a bug where onboard sensors where not displayed
Fixes a bug where total ram was returned instead of available
Fixes a bug where only cpu used by userspace was reported

Just to make things a bit easier to read.

Clean up of overly nested loops

Do you guys want this as one large issue or as several issues ?

Hi @tehhobbit,
It's fine fixing them in one single PR. But it would be great to open an issue per bug. Doing so, you can then create a new test case per issue providing the specific mock data, as you see on your device (what triggered the bug in your case). For example: for issue #58 https://github.com/napalm-automation/napalm-eos/tree/develop/test/unit/mocked_data/test_get_bgp_neighbors/issue58_neighbor_down, creating the dir name using the issue ID and a very brief description. That way, will be easier on the long term to see what happened, why some lines of code are present etc. Additionally (but not mandatory), if you have new lines, you can also add a short inline comment in your code.
Does this make sense to you?
Also, make sure pylama is happy (line 476 might be too long - max len is 100 as per https://github.com/napalm-automation/napalm-eos/blob/develop/setup.cfg)

Coverage decreased (-0.2%) to 79.231% when pulling 73d5f8bdecdfcbf8619925bb9a0dfebcb6a8620d on tehhobbit:derp into 49d4f54d0dec4177cb05cfc5a9ec6e7ade5d800f on napalm-automation:develop.

For the mock data I am a bit unsure how to do that, since we would have to try the same test with multiple versions of data ( one for older EOS releases and one for newer EOS releases) I have added data to cover the on board sensor case.

@tehhobbit  napalm-eos is one of the few napalm drivers (yet) using the new testing framework that allowing us to test multiple scenarios, multiple OS versions etc.
Let's look again at the example #58: under napalm-eos/test/unit/mocked_data/test_get_bgp_neighbors/ (https://github.com/napalm-automation/napalm-eos/tree/develop/test/unit/mocked_data/test_get_bgp_neighbors) you will see two directories:

normal
issue58_neighbor_down

All tests have the dir normal and anything under must stay unchanged (unless drastic changes such as different commands - as you had in https://github.com/napalm-automation/napalm-eos/pull/76, or other exceptional cases).
Now, for any bug, you only need to do mkdir <test_case_name> and place the same files as you see under normal but with a different content.
Is this more obvious now?

Yes, please, add a new test case. Should be fairly easy to add and I think @mirceaulinic is guiding (ask if you have questions). That will allow us to ensure we do regression tests and that we also test corner cases.
Thanks for the fixes, keep them coming ;)

Yes, please, add a new test case. Should be fairly easy to add and I think @mirceaulinic is guiding (ask if you have questions). That will allow us to ensure we do regression tests and that we also test corner cases.
Thanks for the fixes, keep them coming ;)

Yes, please, add a new test case. Should be fairly easy to add and I think @mirceaulinic is guiding (ask if you have questions). That will allow us to ensure we do regression tests and that we also test corner cases.
Thanks for the fixes, keep them coming ;)

Yes, please, add a new test case. Should be fairly easy to add and I think @mirceaulinic is guiding (ask if you have questions). That will allow us to ensure we do regression tests and that we also test corner cases.
Thanks for the fixes, keep them coming ;)

Coverage decreased (-0.2%) to 79.231% when pulling c9a32a17ac6d4adf496a2fedfc0922524df8e059 on tehhobbit:derp into 49d4f54d0dec4177cb05cfc5a9ec6e7ade5d800f on napalm-automation:develop.

Coverage decreased (-0.2%) to 79.231% when pulling ce8c5d494603e3c607bc8c6a18ed6e61b57327b1 on tehhobbit:derp into 49d4f54d0dec4177cb05cfc5a9ec6e7ade5d800f on napalm-automation:develop.

Thx for the last commit, now we are talking. Shouldn't you revert the changes to the "normal" test case, though?

You mean having the new ones as normal and the exception as it used to be ?

As pointed out above, what is under the normal dir should remain unchanged, i.e.: exactly the content from https://github.com/napalm-automation/napalm-eos/tree/develop/test/unit/mocked_data/test_get_environment/normal
You only need to add new mock data, not change the existing one in this case.

Well that is how it is now. So I gather no further changes are needed. The reason for asking is that Arista have changed the output for all future versions making the old behaviour obsolete and for a fact not the normal case.

Well that is how it is now. So I gather no further changes are needed. The reason for asking is that Arista have changed the output for all future versions making the old behaviour obsolete and for a fact not the normal case.

Well, thanks Arista for that : (
However, we can't just adapt the code and break older versions so the patch here has to support both scenarios. Probably a couple of helper methods that are called depending on the version would do.

Added https://github.com/napalm-automation/napalm-eos/issues/84 for data that is actually wrong (removed in the current PR). In regards to breaking change, nothing of this breaks when I have tested across 4.14 - 4.17 both chassis and fixed formfactor.

Ok, reviewed the code again. I just realized you just added data to the normal case, you didn't actually changed the test itself. Sorry for the confusion.


Add meetup 93

Thanks @kouts but it seems your approval is not enough? :/ maybe we need an approval from someone else in the team?


Support partials

Hi there.
I'm pretty happy with requirejs-handlebars ease of use, but I can't find a way to use partials in my templates.
SlexAxton's plugin allows using partials by replacing slashes with underscores in their path:
{{> path_to_template }}
But I can't make it work with requirejs-handlebars. I've tried using regular slashes to no success as well.
Is there a known way use partials with the plugin? Thanks!

Do not Support partials,hope for supporting


Doc secret configuration

Summary

Provide information on how to configure secrets.
Use Cases

Users should not provide secrets directly in their server configuration. Doc how to provide secrets to Liberty's configuration.
Checklist

[X] I have viewed, signed, and submitted the Contributor License Agreement.
[X] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[X] I have added an integration test, if necessary.
[X] I have reviewed the styleguide for guidance on my code quality.
[X] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@dmikusa I think this change is good to merge.


Fixed an issue where utf-8 text could not be sent.

Fixed an issue where utf-8 text could not be sent.
in label, and notification.
works for me.

I think the solution is not a right one. Created #30 to track this.

self.sock.write(data, 'binary');
then the unicode string is broken. but
self.sock.write(data, 'utf-8');
this is ok.
please review.


Support for mobile and TV apps?

First of all thanks for all the effort you put into this. It works really well and it is much appreciated. I was just wondering if there was any way to get it working with the TV/android apps?

I've noticed it is working in mobile and I haven't been able to check it further on the TV app. But I'll close this for now as don't want to waste anyone's time.


Debug using NodeJS is resulting in vscode using "read only content from NodeJS"

VSCode Version: Code 1.12.2 (19222cdc84ce72202478ba1cec5cb557b71163de, 2017-05-10T13:13:11.413Z)
OS Version: Darwin x64 16.6.0
Extensions: none

Steps to Reproduce:

Open up NodeJS project, file is in UTF-8
Set Debug config as
{
"version": "0.2.0",
"configurations": [
{
"name": "Debug Function",
"type": "node",
"request": "attach",
"port": 5858
}
]
}
Run debug
Stop debug
Make code change to index.js
Restart debug to reproduce issue.

@ajayp  how do you start your node.js program?
Make sure that you run your program from the same directory as the VS Code workspace.

@weinand - Apologizes for the delay, was away for a bit but back niow,
I am using ngrok on my machine with the Google Functions Emulator https://github.com/GoogleCloudPlatform/cloud-functions-emulator/wiki/Debugging-with-Visual-Studio-Code
The emulator is running from the same directory as my codel
I am not sure if this answers your question fully, in future, I will be responding in a more timely manner.

@weinand - not sure how much this helps, the issue is not present in version 1.2.1 of vscode which is the version I rolled back to.

I can confirm this issue on VS Code 1.13.1. I think there is something wrong with the debug configuration, as the debugger is not running from the source maps it seems, but from what it finds in your project folder.
I have a React Native project with a bunch of Node shims, but when I run the debugger on my Jest unit tests the shims are not there, code is jumping to node internal objects (fs, etc.), not shims.
My configuration is:
        {
            "type": "node",
            "request": "launch",
            "name": "Launch Current TestSuite",
            "program": "${workspaceRoot}/node_modules/.bin/jest",
            "args": [
                "--runInBand",
                "--no-cache",
                "${file}"
            ],
            "runtimeArgs": [
                "--debug-brk=<IP_ADDRESS>:5858"
            ],
            "port": 5858,
            "sourceMaps": true
        }

What version of node are you using?
In general it should not be necessary to explicitly set the debug port. So these lines should be removed:
"runtimeArgs": [
   "--debug-brk=<IP_ADDRESS>:5858"
],
"port": 5858,

Instead if you want to control whether debug protocol is used, add a "protocol": "legacy" or "protocol": "inspector" attribute. With this the correct debug port and debug options are passed to node.
"sourceMaps": true is not needed because that's the default anyways. But you might want to specify the location of the generated code via the "outFiles" attribute, e.g. something like this:
  "outFiles": [
    "${workspaceRoot}/out/**/*.js"
  ]

Thanks for your help! I had significant problems with node v8, so I downgraded to 7.10.1 and thought I had it working.
The details are in this stackoverflow post.
I removed the superfluous configuration, but it still gives the same results and my unit tests succeed, where they should in fact fail (there are fs.readFileSync calls coming through, while fs is mocked out).
        {
            "type": "node",
            "request": "launch",
            "name": "Launch Current TestSuite",
            "program": "${workspaceRoot}/node_modules/.bin/jest",
            "args": [
                "--runInBand",
                "--no-cache",
                "${file}"
            ],
            "outFiles": [
                "${workspaceRoot}/android/app/build/intermediates/assets/debug/*.bundle"
            ]
        }


Wrong unsubscribe from event

Hello,
can it be, that the Setter in Property "DefaultProvider" in https://github.com/SeriousM/WPFLocalizationExtension/blob/f8fce632fe897a17109dffd7de57479aa347dd3b/WPFLocalizeExtension/Engine/LocalizeDictionary.cs does a wrong unsubscribe?
Line 794: defaultProvider.ValueChanged += new ValueChangedEventHandler(ValueChanged);
should be: defaultProvider.ValueChanged -= new ValueChangedEventHandler(ValueChanged);
Thanks
Tobias

Hi Tobias, you're absolutely right! Thank you!


Issue1380 syntax check lock script

To help prevent loss of funds due to syntax errors in lock scripts they should be validated when the transaction is validated, prior to being executed with the corresponding unlock script.
Taken over from PR https://github.com/bosagora/agora/pull/2060 which @AndrejMitrovic created but was not yet merged due to ci failures.

Looks like this one is ok now.


Make order of min/max count consistent in SHACL

We normalize that min always comes first for easier diffs.

@changqin26 FYI


HBase version querying

A function and/or magic property to enable HBase time range filtering, i.e. restrict queries to triples within a specified time range.

First I would need to know a reason for that filtering. Do you need multiple versions of triples stored and query across them, or do you want to implement a basic transaction system based on a timestamp, or is there another reason?
Thanks,
Adam

I'm afraid architecture of the internal HBase timestamp system is not so robust so it can allow requested functionality without significant performance drawback.
HBase timestamps are used in Halyard in a very limited case (mainly within one bulk operation), where it is expected that HBase (with configuration to retain just the latest triple states) will remove old versions of the triples during compaction process and recover the performance ASAP.
Theoretically it might be possible to configure HBase to "retain all" records and somehow model a time-constrained queries, however the performance will be very poor and there I see no option to mode time ranges.
Let me give you an example:
You are for example recording one changing value in time - let say temperature, every hour:
37, 38, 37, 35, 34, 35, 37
In this case you'll have to store 7 triple insertions and 6 triple deletions.
Whenever you will query for the temperature, HBase will have to crawl through all the values and filter out what you need (based on the requested timestamp).
Practically it might make sense to use the timestamps as a limited transactional support (as you described "don't get results from an update I might be running"). However even for that purpose there might be drawbacks - the server compactions. In case your actual update is directly writing to HBase, compaction may already remove the older records and your query (restricted by the timestamp) may get incomplete data.
We may still elaborate on this solution (as you are interested) and find some boundaries where it may work without race conditions.
However I would rather recommend you to use Halyard bulk updates and bulk loads, which are transactional. Bulk operation data are indexed into a standalone HBase files and bulk-loaded to HBase at the final stage as almost atomic operation. Running Halyard bulk load or bulk update is not producing any "dirty" data and not affecting actual queries (except for multi-stage SPARQL updates, where each stage represents standalone bulk operation).
If I can summarise it - Halyard model is not designed to support time (or version) as another queryable dimension (next to the subjects, predicates, objects, and named graphs). In order to do so - it would require significant architecture and implementation effort.

Thanks for your response. Given the temperature example, I imagine that working by only inserting data, no deletions, and using timestamp filtering to scope it.  And, assuming the min versions for a column family is set to something like 10, e.g. "alter ‘t1′, NAME => ‘f1′, MIN_VERSIONS => 10".
I think by default, hbase returns only the latest version, so "select ?t where {?s rdf:value ?t}" would just see 37. To retrieve older values, I imagine a query like
"select ?t where {?s rdf:value ?t filter(timerange(30, 50000, 4)}" where the timerange function would get translated to scan.setMaxVersions(4); scan.setTimeRange(30, 5000);
This is what I sort of have in mind, though it doesn't allow the actual timestamps to be returned. Maybe they could be returned as named graphs, say "select ?g ?t where {graph ?g {?s rdf:value ?t} filter(timerange(30, 50000, 4)}" where ?g could have values like halyard:/timestamp/4221. Or better for ever inserted triple "graph ?g {?s ?p ?o}", there is also a triple "graph ?v {?s ?p ?o}" where ?v=strcat(?g, ';timestamp=', insertionTimestamp).

Adding service parameters to request specific HBase timestamp might be possible, however it is still far from making Halyard a kind of versioned RDF store. Original intent of the TimeAwareHBaseSail was to support Change Data Capture faster paralel replay of the events backlog using SPARQL Update, without prior sorting and bottleneck of in-time-order processing, or without custom complex MapReduce tool. For that case both (event backlog and final graph) are still represented as standard RDF, there are no data persistent in any hidden dimension, and everything can be exported to any other RDF system. And I would recommend anyone to model the data into standard RDF, instead of start with proprietary tweaking of the system to support another time/version dimension.
Regarding the implementation - you propose to change the way how delete and insert HBase key-values are diferentiated in time. Actual Halyard implementation exclusively uses least significant bit, where original timestamp is shifted by one bit.This assures deterministic order of deletes and inserts with the same timestamp in any situation. As the timestamp might be also just sequence of versions, your simplified solution would produce conflicting timestamps between insert and delete of two subsequent triple versions.
-------- Původní zpráva --------Od: pulquero<EMAIL_ADDRESS>Datum: 28.01.19  9:06  (GMT+01:00) Komu: Merck/Halyard<EMAIL_ADDRESS>Cc: Adam Sotona<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Předmět: Re: [Merck/Halyard] HBase version querying (#47)
Here is my branch https://github.com/pulquero/Halyard/tree/versioning, hopefully I haven't overlooked anything.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/Merck/Halyard","title":"Merck/Halyard","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/Merck/Halyard"}},"updates":{"snippets":[{"icon":"PERSON","message":"@pulquero in #47: Here is my branch https://github.com/pulquero/Halyard/tree/versioning, hopefully I haven't overlooked anything."}],"action":{"name":"View Issue","url":"https://github.com/Merck/Halyard/issues/47#issuecomment-458031730"}}}
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/Merck/Halyard/issues/47#issuecomment-458031730",
"url": "https://github.com/Merck/Halyard/issues/47#issuecomment-458031730",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]

Yes, service parameters allow finer-grained scoping of the data to be queried so should probably be considered in its own right, independently from a versioned RDF store. I can fix the bitshifting, just need to bitshift back-and-forth between user provided timestammps and halyard timestamps.
For versioned RDF then, essentially we want to write something like
?s [halyard:timestamp ?t; ...]
halyard:timestamp would be a magic property that does something similar to my TimestampFunction. The presence of such a property sets maxVersions=MAX_VALUE for all scans. Every triple is versioned through the timestamp of its subject. For performance, filters involving ?t could be identified and converted to time ranges on scans involving ?s as a subject. Export is possible with
construct {
?s ?p ?o.
?s halyard:timestamp ?t.
} where {
?s ?p ?o.
?s halyard:timestamp ?t.
}
All this should automatically apply to SERVICE too, so no need to have service params as well.

I now have a working prototype that includes support for INSERT/DELETE on the above mentioned branch.  +
                    "  }" +
                    "}" +
                    "WHERE {" +
                    "  ?change :context   ?targetGraph ;" +
                    "          :timestamp ?t ." +
                    "  OPTIONAL {" +
                    "    ?change :deleteGraph ?delGr ." +
                    "    GRAPH ?delGr {" +
                    "      ?deleteSubj ?deletePred ?deleteObj ." +
                    "    }" +
                    "    (?deleteSubj ?deletePred ?deleteObj ?targetGraph) halyard:timestamp ?t ." +
                    "  }" +
                    "}"

                    "PREFIX : <http://whatever/> " +
                    "PREFIX halyard: <http://merck.github.io/Halyard/ns#> " +
                    "INSERT {" +
                    "  GRAPH ?targetGraph {" +
                    "    ?insertSubj ?insertPred ?insertObj ." +
                    "  }" +
                    "  (?insertSubj ?insertPred ?insertObj ?targetGraph) halyard:timestamp ?t ." +
                    "}" +
                    "WHERE {" +
                    "  ?change :context   ?targetGraph ;" +
                    "          :timestamp ?t ." +
                    "  FILTER (halyard:forkAndFilterBy(2, ?change))" +
                    "  OPTIONAL {" +
                    "    ?change :insertGraph ?insGr ." +
                    "    GRAPH ?insGr {" +
                    "      ?insertSubj ?insertPred ?insertObj ." +
                    "    }" +
                    "  }" +
                    "}"


How to manually set certificate information (i.e., Server_Name, City, Org, etc)?

Can these entries be changed from their defaults during initial installation and generation of the certificate authority and subsequent certificates?

I've done some digging, because my curiosity was sparked by the ca_info.txt file in the repo.

PiVPN began as a rough merger of the code at OpenVPNSetup.

(README.md from PiVPN)
In the original project, the user had the ability to change the certificate information exactly as you suggested:

If you wish to enter identifying information for the CA, replace the default values in the file ca_info.txt (CO for country, ST for state/province/territory, ORG for organization, etc.) before executing the setup script; however, this is not required, and you may leave the ca_info.txt file as-is. After this, the script will prompt you in the command line for input in similar identifying information fields as it generates your server certificate. Enter whatever you like, or if you do not desire to fill them out, skip them by pressing enter; make sure to skip the challenge field and leave it blank.

(README.md from OpenVPN-Setup)
Since then, however, the line of code that used ca_info.txt in the certification generation process was modified by commit 0b96cae. Presumably to simplify the installation process, but let's ask @0-kaladin. So ca_info.txt can be deleted from the repo if I'm not mistaken.


feat: add treeartifact_permits_uplevel symlinks feature

A feature gate for https://github.com/bazelbuild/bazel/pull/21263

Let's wait a bit until https://github.com/bazelbuild/bazel/pull/21263 is actually in 7.1.

I don't know the release cadence for this repo. When can i expect a new release? (just for my curiosity)

@thesayyn I pushed a new release: https://github.com/bazelbuild/bazel-central-registry/pull/1518

Thank you @fmeum!


chore: ABI parser - API alterations

Summary
import type { Abi, AbiSpecification } from '@fuel-ts/abi'
import { AbiParser } from '@fuel-ts/abi'

const jsonAbi: AbiSpecification = '{ "specVersion": "1" }'
const abi: Abi = AbiParser.parse(jsonAbi);

Checklist

[X] All changes are covered by tests (or not applicable)
[X] All changes are documented (or not applicable)
[X] I reviewed the entire PR myself (preferably, on GH UI)
[X] I described all Breaking Changes (or there's none)

@nedsalk and I have agreed on merging this.


port: -D also accepts port names

Could you explain why you want to be able to do this?

The previously mentioned problem has been fixed. Commits can be squashed before merging.


Swell couldn't handle missing observation data files during fetching.

I purposely removed the IASI Metop-B and Metop-C observation data files from the R2D2 location, and it crashed during fetching. The error message in the job.err file within the GetObservations-geos_atmosphere directory is as follows:
File "/discover/nobackup/projects/gmao/advda/JediOpt/core/r2d2/sles12_skylab7/lib/python3.10/site-packages/r2d2/queries/fetch.py", line 23, in action
database.fetch_data(source, target, request, archive_side_request)
File "/discover/nobackup/projects/gmao/advda/JediOpt/core/r2d2/sles12_skylab7/lib/python3.10/site-packages/r2d2/database/db_manager.py", line 87, in fetch_data raise FileNotFoundError(f'Could not find {source} in {" or ".join(self.fetch_order)}')
FileNotFoundError: Could not find ncdiag.x0048v2.ob.PT6H.iasi_metop-b.2021-12-11T21:00:00Z.nc4 in wgu or gmao-shared
2024-11-20T16:51:24Z CRITICAL - failed/ERR

Missing files handling has multiple steps: 1) r2d2 fetch should ignore missing obs, 2) get_observations.py task should handle missing observations as it serves multiple purposes beyond fetching obs such as combining obs if needed, varBC, and aircraftBC cycling.  Hence, this multi-purpose design requires careful modification, 3) UFO filters (which there are multiple PRs in SWELL currently)
I'm working on number 1 (this one is handled) and 2 (it broke atmosphere side) in the following PR as ODAS has lot of missing obs (due to temporal data sparsity):
https://github.com/GEOS-ESM/swell/pull/444
FYI @rtodling @mranst @ashiklom for visibility


⚠ Cioos National CKAN has degraded performance

In 11ac755, Cioos National CKAN (https://catalogue.cioos.ca/) experienced degraded performance:

HTTP code: 200
Response time: 5565 ms

Resolved: Cioos National CKAN performance has improved in 555a878 after 7 minutes.


Make it possible to execute scripts from file with arguments with -b option.

I changed the code a small bit so that it is possible to provide arguments to uuu scripts.
I did this by re-using some of the buildincmd code.

This is how to use it:

script.lst.txt

combine into one commit with small modify, add error message.


SHARE filters are slow

It takes up to an hour to filter out all the eligible files for SHARE. Perhaps these filter models can be tweaked to use Solr more? It happens when we pass GenericFile.all as the parameter. Likely, the culprit is that when filtering the files it has to call for the id and that makes a call to Fedora? Needs more investigation.

duplicate of #248


Update to version 1.0.2. Timestamp column added. Row mismatch after sort fixed

Added timestamp field in table.

I've accepted your requested and updated the Bapp. Bumped your version number to 0.0.4 and tweak the pom.xml to not include version in the jar file name. You can pull those tweaks from our repository.


Admin: The path to edit a user is missing a /

I am on /app/admin/users and I click on the three dots to edit a user, the link is incorrect and missing a / so I am now on a 404.

Fixed by #48


Remove 'Ethnicity' from the backlog

This has now been released as the Ethnic groups pattern.

You can preview this change here:
Built with commit c26a6b10300d6e7129f4a0636b755aeb3f1a530e
https://deploy-preview-992--govuk-design-system-preview.netlify.com


chore(master): release 1.0.0

:robot: I have created a release beep boop
1.0.0 (2023-02-18)
⚠ BREAKING CHANGES

Update something

Features

initial commit (7bb7e20)
initial commit (a88203a)
update ci-cd workflow (5a8dac0)
update ci-cd workflow (6a5ee48)
update version (b31fdad)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/pvduc-dev/plana-ui/releases/tag/v1.0.0 :sunflower:


Supports azblob storage

What type of enhancement is this?
API improvement, Configuration
What does the enhancement do?
Supports azblob storage by opendal

https://opendal.apache.org/docs/rust/opendal/services/struct.Azblob.html

Implementation challenges
No response

Thanks @QuenKar


The 'CommandShowTomatoStatusBarPackage' did not load correctly. in VS 2019 v 16

| LegacySitePackage failed for package [CommandShowTomatoStatusBarPackage]Source: 'djfoxer.HealthyWithVS' Description: Object reference not set to an instance of an object. System.NullReferenceException: Object reference not set to an instance of an object.   at djfoxer.HealthyWithVS.Services.MainService.TogglePomodoroTimerStatusBar() in C:\Users\Scorpion\Desktop\healthyWithVS-master\djfoxer.HealthyWithVS\djfoxer.HealthyWithVS\Services\MainService.cs:line 25   at djfoxer.HealthyWithVS.CommandShowTomatoStatusBar..ctor(Package package) in C:\Users\Scorpion\Desktop\healthyWithVS-master\djfoxer.HealthyWithVS\djfoxer.HealthyWithVS\StatusBar\CommandShowTomatoStatusBar.cs:line 64   at djfoxer.HealthyWithVS.CommandShowTomatoStatusBarPackage.Initialize() in C:\Users\Scorpion\Desktop\healthyWithVS-master\djfoxer.HealthyWithVS\djfoxer.HealthyWithVS\StatusBar\CommandShowTomatoStatusBarPackage.cs:line 76   at Microsoft.VisualStudio.Shell.Package.Microsoft.VisualStudio.Shell.Interop.IVsPackage.SetSite(IServiceProvider sp)
-- | --

Thank you, I need to investigate it deeper and install VS2019.

Fixed in 0.5 version, commit: https://github.com/djfoxer/healthyWithVS/commit/0299f0b248e829c7085d95dc4cc5b35a7887322b


Btcpay day riga 2022

Linkcheck test fails because it seem it can't crawl Twitter, so not related to this PR. @dennisreimann should we exclude twitter links from the check?


⚠ LPDM Handbook (hosted on Divio) has degraded performance

In 3d0949f, LPDM Handbook (hosted on Divio) (https://repohubdev.tk) experienced degraded performance:

HTTP code: 500
Response time: 5169 ms

Resolved: LPDM Handbook (hosted on Divio) performance has improved in 192c220.