CIF-1657: [React Components] Clean up the unit tests warnings

The unit tests for the React Components module all pass, but they throw a lot of warnings regarding missing props and the ever present "Warning: An update to XXXX inside a test was not wrapped in act(...)."
Description
This change fixes the warnings above. It also fixes a styling issue for AccountDetails/editForm due to empty editForm.css
Motivation and Context
We must cleanup these warnings as they can potentially hide some implementation issues.
How Has This Been Tested?

running unit test
verify if components render correctly

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[X] All unit tests pass on CircleCi.
[X] I ran all tests locally and they pass.

Refactored the unit tests so they all use the custom render (from utils/test-utils.js) which wraps the mock component with MockedProvider, ConfigContextProvider, UserContextProvider and I18nextProvider. The render's options parameter is extended with the following props:

config - provides configuration object for ConfigContextProvider
userContext - provides initialState for UserContextProvider
mocks - provides mocks data for MockedProvider


LAZ-perf or LAZ-zip for write

Hi,
I am new to these tools, but by reading the README I understand:

that LAZ-perf makes a performance when reading LAZ especially when reading from a browser.
it is not clear if LAZ-perf browser features are only available if the LAZ was written initially with LAZperf or if it is also working with any LAZ.
it is not clear if LAZ-perf is more performant than LASzip (when building LAZ from a LAS for example) ?

Would it be please possible to clarify this and maybe put this details into the README ?
Regards

that LAZ-perf makes a performance when reading LAZ especially when reading from a browser.

It used to be the case that LAZperf was better when used in a browser but I don't know if this is true anymore. You'd have to test. It could be that improvements in webassebly have eliminated this advantage.

that LAZ-perf makes a performance when reading LAZ especially when reading from a browser.

There's nothing special about a LAZ file written with lazperf. The data encoding is necessarily identical.

it is not clear if LAZ-perf is more performant than LASzip (when building LAZ from a LAS for example)

I don't think it's much different on standard CPUs/platforms. If there is a performance advantage to LAZperf, it's when used in a browser with web assembly.

@abellgithub's history about laz-perf is correct. It was originally developed as an alternative implementation so it worked better when compiling to WASM. Martin changed the implementation of the LASzip library so that particular advantage was not as relevant.
laz-perf does have a few other significant advantages, however:

It's API is much clearer and easier to use
It supports multi-threaded reads
PDAL is moving to using it exclusively for LAZ support at PDAL 2.4+

With Martin's recent death, LASzip is likely to move into more of a pure maintenance mode. The LASzip library hadn't changed significantly in a number of years anyway, and LASzip is the implementation inside of all of LAStools. There are no plans to move the compression approach forward in any significant way.
We plan to continue to maintain laz-perf for PDAL and for other WASM consumers like laslaz.js, which is used by Potree, deck.gl and many others.

thanks for the details.
Otherwise, for simple LAS to LAZ conversion I observe PDAL+LASzip being a lot slower than LAStools2.0/las2las64 despite the fact they both use not more than one core.
Is there some plan improving LAZperf writing performance to match these ?

This is a consequence of PDAL more than laz-perf.

Is there some plan improving LAZperf writing performance to match these ?

As always, performance patches will always be reviewed 😄

:smile:
thanks


Fix grep status

Also adds success_codes parameter to TurbiniaTask.execute() to allow specification of multiple acceptable return codes for a "successful" status.

Tests will be fixed by https://github.com/google/turbinia/pull/353


Allow virtual HTML for viteServer.transformIndexHtml()

Clear and concise description of the problem
Astro Needs for transformIndexHtml()
Astro generates HTML on-the-fly from .astro files. That means that we convert something like:

  <Component client:hydrate />

into:

Hello, World!

This all happens in-memory via a Vite plugin for HTML.
When serving the request through dev, we try and call viteServer.transformIndexHtml() on that HTML. Vite then transforms that into:

Hello, World!

So it creates that proxied module, but then it goes to try and load that module from disk, and fails with:
Internal server error: No matching html proxy module found from /Users/drewpowers/Code/snowpackjs/astro/examples/framework-react/src/pages/index.astro?html-proxy&index=0.js

The issue is that the original


[New Snap] SCI

Checklist
All items in the list below needs to be satisfied.

[x] Is the Snap repository publicly accessible and linked in this ticket? https://github.com/sci-domains/snaps
[x] Is the Snap distributed on npm and linked in this ticket? https://www.npmjs.com/package/@secure-ci/snap
[x] Has an audit been performed and the audit report attached or linked in this issue? [Audit relaxed]
[x] Is a complete list of discovered vulnerabilities from the audit documented in this issue?
[x] For vulnerabilities that have been deemed necessary to be addressed, are the links to the fixes attached to this issue?
[x] For vulnerabilities that have been deemed not necessary to be addressed, is a reason for each of them documented in this issue?
[ ] The corresponding pull request in this repo has been merged.

The Audit has been skipped for this Snap.

Code review:

Panel uses text() repeatedly instead of row() [Not a Blocker]

Version to be allowListed: 0.0.11


Writing to a file outside the vault

Thanks for putting together this plugin!
I wanted to ask if you would be open to considering a setting that can read the output folder path as an absolute path, as opposed to the current approach which always interprets it as a relative path?
My experience, but this may not be an intuitive approach, is that if the directory is specified with a leading /, then it is interpreted as absolute. If it is not specified with a leading /, then it is relative.
Alternatively, there could also be a radio button that specifies whether the output folder path is relative or absolute.
Either way, if this is something you are open to, that would be great! And if you're lacking the bandwidth, I can try and submit a PR based on the approach you prefer. (although it will take me a minute to figure out the ropes of Obsidian plugin building)

Honestly, totally open to this approach, as exporting directly into my quarto website would make a lot of sense, thought I don't know if it might lead to any permission issues?  Either way, worth a try. I'll have a think, but very welcome to try and do a PR in the interim!

I'm dropping this here just for both of our references!
Here's a Quarto plugin that exports things to outside the vault: https://github.com/bingryan/obsidian-markdown-export-plugin

Fixed in 1.0.5!


Opt out of special functionality

If validation is off, we now don’t change things to graph objects. If
the user attempts to do certain things, a validation error will likely
pop up. But the normal creation of plots and things shouldn’t cause
issues.

@chriddyp , got a better idea of how to do this for now? until we get graph reference synced, we want to not raise validation errors.
I didn't want it to be default, but it's quite simple to turn them off now:
py.update_plot_options(validate=False). This will now not validate anything. You just need to have that once at the top of your script/notebook.
//cc @jackparmer

Is this going to be a non-blocking a warning instead of a blocking error? It would annoying to have to do this:
py.update_plot_options(validate=False)
Every time you make a map.

Also, can the warning say something to the tune of: "Many maps and 3d features do not yet have syntax validation - These warnings are normal if you're making a map or 3d graph." Its pretty confusing and embarrassing to demo otherwise.

@jackparmer , yup, i can change the warning to be less embarrassing-sounding for sure. Or, would you rather there was no warning? I don't really mind since it's set by the user anyhow.
I just really don't want to turn off the errors by default.
It would take a fair amount of work to safely short-circuit all the errors. We can't just take the errors out because then we wouldn't know if we were ever in a stable state or not to run some function.
The other thing that we could easily do is allow folks to just set this in their config file (we're planning on doing it anyways).
That way you wouldn't here a peep when you're demoing, but you also won't know if you typed something in wrong.

Ok, if its a big hassle to make


How to Disable Hangfire logging in NLog?

I am trying to disable Logging with NLog for Hangfire jobs, I tried this but it didn't work:
  "Logging": {
    "LogLevel": {
      "Default": "Information",
      "Hangfire" : "None"
    }

I am using ASP.NET Core 3.1 Web API Project
NLog version: 4.7.6
NLog.Web.AspNetCore version: 4.10.0
Hangfire version: 1.7.27
Cannot I disable it from appsettings.json? Instead of using NLog Logging Rules & Filters, or using some custom NoOpLogger for Hangfire like this??
Note: I am using only one rule for my NLog target:
var rule= new LoggingRule("*", LogLevel.Trace, LogLevel.Fatal, myCustomTarget)
StackOverFlow Question:
https://stackoverflow.com/questions/69936676/how-to-disable-hangfire-logging-in-nlog

This is the NLog-core-repo, and it sounds like a Hangfire support question:
https://docs.hangfire.io/en/latest/configuration/configuring-logging.html
Though I have never used Hangfire then I will be nice. How to do setup Hangfore for logging?
Using this:
services.AddHangfire(config => config.UseXXXStorage());
Or this:
GlobalConfiguration.Configuration.UseNLogLogProvider()

@snakefoot thanks for your help
I used this method:
services.AddHangfire(config => config.UseSqlServerStorage(Configuration.GetConnectionString("HangfireConnection"));
and did NOT add any extra config for NLog support like the line you mentioned
GlobalConfiguration.Configuration.UseNLogLogProvider()
However, hangfire supports NLog automatically, which mentioned here.

If your application uses one of the following libraries, no manual action is required in the most cases. Hangfire knows about these loggers and uses reflection to determine the first available one (in the order defined below) and to call the corresponding methods when logging. And since reflection is used, there are no unnecessary package or assembly references.
Serilog
NLog
Log4Net
EntLib Logging
Loupe
Elmah

And yes sure, I checked environment-specific appsettings.json, delete all logging and kept it in one file only to avoid surprises.
Forget to mention that the logging disabled for all levels except for Error level (exception).
To be more specific, the name of the logger that keep logging things is Hangfire.AutomaticRetryAttribute,  even though I set it  to "None" for Hangfire in appsettings.
Found its code here, the log statement is at line 280:
_logger.WarnException(
                    $"Failed to process the job '{context.BackgroundJob.Id}': an exception occurred. Retry attempt {retryAttempt} of {Attempts} will be performed in {delay}.",
                    failedState.Exception);

I can easily turn it off using some loggerNamePattern with Logging Rules, but I am really wondering why it is acting like this, and suspected it may be a bug in NLog, that's why I opened the issue here, not on Hangfire repo.

If the logging goes through LibLog instead of Microsoft LoggerFactory, then Microsoft LoggerFactory-filters will not apply.
If you have ideas or suggestions for how to improve NLog, then you are more than wellcome to create pull-requests and share your ideas.
Notice that with NLog 5.0 then NLog will actually try to ignore all Microsoft LoggerFactory-filters by default, and only respect the NLog loggingrules. One can still explicitly enable the old behavior by setting NLogAspNetCoreOptions.RemoveLoggerFactoryFilter  = false

Closing issue since for Hangfire and not for NLog-core. Better to continue the discussion at https://github.com/HangfireIO/Hangfire/issues/1809


not working on windows xp

this component does not work on windows xp
here how i use it on windows xp
const os=require('os'),diskusage=require('diskusage')
class DiskUsage{
     freeSpace(callback){
       if (os.platform() == 'win32' && os.release().substring(0, 2) == '5.') {
           //if windows xp
           console.log('getting disk space from windows xp')
           var cmd = require("cmd-exec").init();
           cmd
               .exec("fsutil volume diskfree " + rootPath)
               .then((res) => {
                   var cc = res.message.trim().replace('\n', '').split('\r');
                   callback( parseInt(cc[0].split(':')[1]))
               })
               .fail((err) => {
                    console.log('error getting free space from windows xp:',err)
                   callback(0) ;
               })
       }
       else {
           console.log('getting disk space from os')
          callback( diskusage.checkSync(process.cwd()))

       }
   }
}

module.exports=DiskUsage

Windows XP should theoretically work, the package uses GetDiskFreeSpaceW which is supported back to Windows XP. I suspect the issues you are having with Windows XP are related to NodeJS and/or node-gyp.
What specific error message are you seeing when trying to use this package on Windows XP?

Closing due to no response. Windows XP is out of scope for active support, but if someone wants to point me in the right direction for getting it working on Windows XP, happy to investigate.


Use the computed value ambient_accum for ambient_light in scene_forward_mobile.glsl

Currently in scene_forward_mobile.glsl, ambient_accum is computed as a result of the reflection_process but is never used. When asked on the IRC, it was suggested that this is probably an oversight.
This PR aims to fix that by making use of the computed value ambient_accum similar to what has been done in scene_forward_clustered.glsl.

Have you created a test scene to verify that the change looks correct? If so, can you please provide before and after picture? If not, can you please make a test scene and upload before and after pictures?

Seems to fix #56555.
Before:

After:

Thanks!


Fix docs example to run unittests

During development, I tried to run unit tests according to documentation, but I get this error:
defectdojo@dccdeec6caf6:/app$ python manage.py test dojo.unittests.test_gitleaks_parser.TestGitleaksParser
[12/May/2021 15:47:00] INFO [dojo.models:3363] enabling audit logging
System check identified no issues (0 silenced).
E
======================================================================
ERROR: test_gitleaks_parser (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: test_gitleaks_parser
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/unittest/loader.py", line 153, in loadTestsFromName
    module = __import__(module_name)
ModuleNotFoundError: No module named 'dojo.unittests.test_gitleaks_parser'

----------------------------------------------------------------------
Ran 1 test in 0.001s

FAILED (errors=1)

With this call, I was able to run the tests successfully:
python manage.py test dojo.unittests.tools.test_gitleaks_parser.TestGitleaksParser

Correcting this inaccuracy.

Can you tell me why there is a conflict here? I can't figure it out

@ansidorov restarting to test but you still have conflicts

@ansidorov In the last 2 weeks there have been lots of changes to the documentation, while changing the documentation theme to Docsy. With this lots of files have been moved from content to content/en, including the file you have changed. Please rebase your changes to the current dev branch.

@StefanFl Thank you very much. I realised where I made a mistake. Updated the PR


Write band descriptions in save_cog_with_dask

The xarray and rioxarray packages use a dataset's long_name attribute to store band names.  This PR saves those band names in COGs written with save_cog_with_dask.  The names are written to be as compatible as possible with GDAL's band name writes.
This mechanism may also be used to write other GDAL metadata.
Resolves #138.

thanks for this, we just need to make sure that extra metadata is written even when stats computation is not happening.
Also I'm a bit uncertain about source of description data: attribute long_name: list[str].

For YX data long_name: str will be a more expected format than long_name: list[str], that's easy enough to fix.
I'm not too keen on attributes that apply per element along some dimension, that's what coordinates are for in xarray, but I can see how attribute can be easier to interface with from the user perspective.

Thanks for the review, looks like I'll need to do a bit more thinking about the approach.  More to come.

Also I'm a bit uncertain about source of description data: attribute long_name: list[str].

This one was tricky to track down but there are two significant places where it's general practice.  First, Xarray's documentation recommends using it:

While you’re setting up your DataArray, it’s often a good idea to set metadata attributes. A useful choice is to set data.attrs['long_name'] and data.attrs['units'] since xarray will use these, if present, to automatically label your plots. These special names were chosen following the NetCDF Climate and Forecast (CF) Metadata Conventions.

Second, rioxarray writes band names to the long_name attribute when opening TIFF files via rioxarray.open_rasterio and writing TIFF files via `.  I could not find any specific documentation for which attribute is used, only a general allusion here:

Why use rioxarray.open_rasterio() instead of xarray.open_rasterio?
...
6. It loads raster metadata into the attributes.

Inspection of attributes after calling that function reveals that long_name is used.

I'm not too keen on attributes that apply per element along some dimension, that's what coordinates are for in xarray, but I can see how attribute can be easier to interface with from the user perspective.

Definitely agree with you on this.  I added checks to ensure that the correct number of band names are present if we use long_name as the source of our band names.


Unify the path comparer for relative path and absolute path.

To make code cleaner, need to unify the path comparer for relative path (RelativePathEqualityComparer.cs) and absolute path in FileHelper.cs file.

may not need it now as not using the absolute path equality comparer now.


Could you please explian more about how to config redis?

Not redis in itself.
For instance, I connect redis with flask using an url:
redis://:@localhost:6379/1
But how should I config redis server in this project?
I saw an sample file but not quite sure what I can do with it...
Thank you very much.

Ok, although I don't understand how it works. But I modified model/connection.py and it works:
Simply delete UNIX part

MAX_CONNECTIONS = 10
CONNECTION_POOL = tornadoredis.ConnectionPool(max_connections=MAX_CONNECTIONS,
wait_for_available=True)


Tear down connections on prolonged loss of UDP heartbeat

Addresses #373 - detect udp connectivity breakage.
Once a connection moves to the established state indicating that the remote peer has received one of our heartbeats a timer is started. If we do not receive a UDP heartbeat from the remote peer within this time (default is three times the slow heartbeat interval) the connection is terminated:
connection shutting down due to error: timed out waiting for UDP heartbeat

At this point the existing connection resumption mechanism takes over. In normal operation, the timer is reset each time we receive a heartbeat.
Implementation notes:

It would be possible to merge establishedTimeout and heartbeatTimeout into a single timer; we would simply adjust duration and error messages depending on conn.established state.
Alternatively, the heartbeat timeout could run at the same time as the established timeout rather than being kicked off once we know our heartbeat has got through to the other side.

What is the rationale for starting the heartbeat timer when becoming 'established'? The latter tells us that our heartbeats did get through, which says nothing about the other direction, which is what the timer is watching for.
Wouldn't it be better to instead start the timer after sending 'established' to the other side?

Wouldn't it be better to instead start the timer after sending 'established' to the other side?

Or, why not start the timer straight away? That would simplify the code since then a) the timer would always exist, and b) we won't have to check for a condition to start it.
I think that would also allow us to get rid of the 'established' timeout, i.e. we could rely on the heartbeat timeout to tear down the connection instead.

I was thinking of the case where we are originating from behind NAT; there's no way we can receive a heartbeat from the remote peer until our outbound connection is established, so I deferred starting the timer until that had happened.
I like the idea of simplifying down to a single timer very much, although it would have the effect of slightly reducing the rigour of the test (e.g. timely delivery of the established message over the TCP channel would no longer be checked) - are you happy with that? If not, I'd suggest treating the two cases as completely orthogonal and start both timers in run so that we can eliminate the conditional checks...

there's no way we can receive a heartbeat from the remote peer until our outbound connection is established

"almost established", i.e. our UDP packet must have made it across, but the Established TCP message may not have turned up yet.
So technically the initiating side should have a slightly longer timeout, but I can't imagine it's worth the hassle.

timely delivery of the established message over the TCP channel would no longer be checked

The ReadTimeout puts an upper bound on that.

Above commits address comments to date.

Great. Does it work? How have you tested this?

Confirmed with manual testing on two digital ocean VMs by using
iptables -I FORWARD 1 -p udp --dport 6783 -j DROP

to prevent weave related UDP traffic from being forwarded to the docker0 bridge. Tried the following cases:

UDP traffic is blocked prior to launch; ensure that connection establishment times out but continues retrying
Remove block; ensure connection establishes
Restore block; ensure weave notices within configured timeout, tears down connection but continues retrying
Remove block; ensure connection restablishes
Left running for half an hour to observe stability

I used a combination of docker logs weave and weave status to observe the state on both peers at each step.
Would feel a lot more comfortable with #229 in place! It could use soak/torture testing...


implement physical_limit.cpp for support limit

What problem does this PR solve?

implement physical_limit.cpp & physical_merge_limit.cpp
fixed build logical_plan for limit
add python test script for limit
support stream sink for physical_sink.cpp
fix column binding miss on order by functions

select c1, c2 from t1 order by c1 + c2, c1;

fix physical_limit offset
fix lazy load output_names wrong on join
remove RetainColumnByIds
fix remapper error when Project has no first column or column order is reverse order

select c3, c2, c1 from select3;
select c2, c3 from select3;

Issue link: https://github.com/infiniflow/infinity/issues/362
What is changed and how it works?
kould=> SELECT * FROM test_limit limit 10;
 c1 | c2
----+----
  0 |  1
  2 |  3
  4 |  5
  6 |  7
(4 rows)

kould=> SELECT * FROM test_limit limit 2 offset 2;
 c1 | c2
----+----
  4 |  5
  6 |  7
(2 rows)

Code changes

[x] Has Code change
[ ] Has CI related scripts change

Check List
Tests

[x] Unit test
[x] Integration test
[x] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Note for reviewer

@mergify queue


Remove song from queue

Contact Details
No response
Your request
As a user I want to remove a song from the queue by it's index.

Resolved #3217e2f


Use theme colors / Support dark mode

Currently, colors seem to be hardcoded from constants. Using some sane values from Theme.of(context).colorScheme could prove useful. Using this would also automatically support dark themes. The screenshot below is taken with dark mode enabled.

I can provide a minimal reproducible example if desired.

Duplicate of #227, apologies


Kernel is dead message when starting Spyder

Description
What steps will reproduce the problem?

Error triggered while testing macOS installer build as part of the Spyder 6 beta2 release (rc0). The error shows up after Spyder starts when the installation process finishes
Traceback
Traceback (most recent call last):
  File "/Users/daniel/Library/spyder-6/envs/spyder-runtime/lib/python3.11/site-packages/spyder/plugins/ipythonconsole/widgets/status.py", line 106, in <lambda>
    lambda sw=shellwidget: self.on_kernel_start(sw)
                           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/daniel/Library/spyder-6/envs/spyder-runtime/lib/python3.11/site-packages/spyder/plugins/ipythonconsole/widgets/status.py", line 136, in on_kernel_start
    mpl_backend = shellwidget.get_matplotlib_backend()
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/daniel/Library/spyder-6/envs/spyder-runtime/lib/python3.11/site-packages/spyder/plugins/ipythonconsole/widgets/shell.py", line 734, in get_matplotlib_backend
    blocking=True).get_matplotlib_backend()
                   ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/daniel/Library/spyder-6/envs/spyder-runtime/lib/python3.11/site-packages/spyder_kernels/comms/commbase.py", line 610, in __call__
    self._comms_wrapper._send_call(call_dict, self._comm_id, buffers)
  File "/Users/daniel/Library/spyder-6/envs/spyder-runtime/lib/python3.11/site-packages/spyder/plugins/ipythonconsole/comms/kernelcomm.py", line 146, in _send_call
    raise RuntimeError("Kernel is dead")
RuntimeError: Kernel is dead

Versions

Spyder version: 6.0.0b2.dev174  (standalone)
Python version: 3.11.9 64-bit
Qt version: 5.15.8
PyQt5 version: 5.15.9
Operating System: macOS-11.6.8-x86_64-i386-64bit

Dependencies
# Mandatory:
aiohttp >=3.9.3                   :  3.9.5 (OK)
asyncssh >=2.0.0,<3.0.0           :  2.14.1 (OK)
atomicwrites >=1.2.0              :  1.4.1 (OK)
chardet >=2.0.0                   :  5.2.0 (OK)
cloudpickle >=0.5.0               :  3.0.0 (OK)
cookiecutter >=1.6.0              :  2.6.0 (OK)
diff_match_patch >=20181111       :  20230430 (OK)
github >=2.3.0                    :  2.3.0 (OK)
intervaltree >=3.0.2              :  3.1.0 (OK)
IPython >=8.13.0,<9.0.0,!=8.17.1  :  8.25.0 (OK)
jedi >=0.17.2,<0.20.0             :  0.19.1 (OK)
jellyfish >=0.7                   :  1.0.4 (OK)
jsonschema >=3.2.0                :  4.22.0 (OK)
keyring >=17.0.0                  :  25.2.1 (OK)
nbconvert >=4.0                   :  7.16.4 (OK)
numpydoc >=0.6.0                  :  1.7.0 (OK)
parso >=0.7.0,<0.9.0              :  0.8.4 (OK)
pexpect >=4.4.0                   :  4.9.0 (OK)
pickleshare >=0.4                 :  0.7.5 (OK)
psutil >=5.3                      :  5.9.8 (OK)
pygments >=2.0                    :  2.18.0 (OK)
pylint >=3.1,<4                   :  3.2.3 (OK)
pylint_venv >=3.0.2               :  3.0.3 (OK)
pyls_spyder >=0.4.0               :  0.4.0 (OK)
pylsp >=1.11.0,<1.12.0            :  1.11.0 (OK)
pylsp_black >=2.0.0,<3.0.0        :  2.0.0 (OK)
pyuca >=1.2                       :  1.2 (OK)
qdarkstyle >=3.2.0,<3.3.0         :  3.2.3 (OK)
qstylizer >=0.2.2                 :  0.2.3 (OK)
qtawesome >=1.3.1,<1.4.0          :  1.3.1 (OK)
qtconsole >=5.5.1,<5.6.0          :  5.5.2 (OK)
qtpy >=2.4.0                      :  2.4.1 (OK)
rtree >=0.9.7                     :  1.2.0 (OK)
setuptools >=49.6.0               :  70.0.0 (OK)
sphinx >=0.6.6                    :  7.3.7 (OK)
spyder_kernels >=3.0.0b7,<3.0.0b8 :  3.0.0b7 (OK)
superqt >=0.6.2,<1.0.0            :  0.6.7 (OK)
textdistance >=4.2.0              :  4.6.2 (OK)
three_merge >=0.1.1               :  0.1.1 (OK)
watchdog >=0.10.3                 :  4.0.1 (OK)
yarl >=1.9.4                      :  1.9.4 (OK)
zmq >=24.0.0                      :  26.0.3 (OK)

# Optional:
cython >=0.21                     :  3.0.10 (OK)
matplotlib >=3.0.0                :  3.8.4 (OK)
numpy >=1.7                       :  2.0.0 (OK)
pandas >=1.1.1                    :  2.2.2 (OK)
scipy >=0.17.0                    :  1.13.1 (OK)
sympy >=0.7.3                     :  1.12.1 (OK)

Operating System: macOS-11.6.8-x86_64-i386-64bit

I see that you're using Mac 11, but the installers require Mac 12 or newer now. So, this could be the cause of the error.
Let me check on my VM (which has Mac 14) to see what I find.

Could it be worthy to somehow validate the OS version and prevent installing from the installer if it is not supported?

Could it be worthy to somehow validate the OS version and prevent installing from the installer if it is not supported?

Good idea but I don't know if that's possible. @mrclary, what do you think?

I think this is possible. Either using our pre-install.sh script which is run by constructor at install time, or using __osx>=12 virtual package in the base environment specs. I'll test them to see what happens.

Hmm...
Well, __osx>=12 in the base environment specs did not seem to do anything.
Using pre-install.sh to check macOS version successfully aborts the install process.
@jaimergp, do you know if there is a more elegant way for constructor to verify os version at the beginning of the install process?

Two issues with using pre-install.sh:

The script does not raise the error until after packages are already unzipped, i.e. there is some install time (and cleanup) before the user is made aware of any error. Ideally, the os version should be checked at the same time that the install location is checked, avoiding unnecessary install actions.
The user is alerted to an error but not the reason for the error. The reason can only be determined by inspecting the install.log.

Well, __osx>=12 in the base environment specs did not seem to do anything.

That's because the solver runs on the build machine, not the target installation machine.
That said we should detect that and add it as a check at installation time, but right now we don't have that logic.
Also, I think the PKG installers have a way to check this natively, so maybe you can hack something together while we come up with something on the constructor side.

Giving it a try at https://github.com/conda/constructor/pull/809


Wait no running pods for kube-apiserver are present before scaling down etcd on hibernation

How to categorize this PR?

/area robustness
/kind enhancement
What this PR does / why we need it:
In the hibernation flow etcd is scaled down before it is ensured that there are no running kube-apiserver pods. This PR fixes this. The kapi hvpa is now deleted before the scale down of the kube-apiserver.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

NONE

@plkokanov @rfranzke Thank you for the review! I addressed the comments. PTAL

/lgtm


Cow: Watch askeva.io(?<!askeva)

Cow requests the watch of the watch_keyword askeva\.io(?<!askeva). See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Rejected by tripleee in Charcoal HQ. Reason: 'duplicate / superseded by a different watch'


ER- and PR-specific LOINC codes for NuclearPositivity and AverageStainingIntensity?

We currently don't have LOINC terms for NuclearPositivity and AverageStainingIntensity, currently sub-elements of ProgesteroneReceptorStatus. We have a couple of options to address this:
1. Use existing receptor-specific LOINC codes.
This requires small model changes to make it clear that the elements are now specific to progesterone receptor, e.g. ProgesteroneReceptorNuclearPositivity. This may become a bigger issue if we want to use these elements in the context of EstrogenReceptorStatus. See issue #100.
2. Request new, receptor-agnostic LOINC codes.
Because LOINC codes are test-specific, not general terms, this may be a hard sell, especially since the more specific codes already exist.

Upon further review, it seems we have already gone down that path for HER2byIHC, where NuclearPositivity has been replaced with CompleteMembraneStainingPercent and the existing LOINC codes have been used.
So now we have ProgesteroneReceptorStatus with NuclearPositivity and AverageStainingIntensity and HER2byISH with CompleteMembraneStainingPercent. I don't see a reason for these elements not to be modeled in the same way.

May, what do you think?

@mlterryMitre, any input?

@rutemartins and @markkramerus -
If we follow the LOINC survey approach like CAP did, then we could still ask for LOINC codes as it relates to a survey, so that would be Option 2.
But that's just my opinion.  This is something to delve in deeper for buy-in with the standards community as we get representatives more deeply involved in LOINC committees and the FHIR Orders and Observations WG.
So maybe option 1 for Sept 2018 ballot and have us work through Option 2?

I agree #2 is a hard sell.  LOINC for tests is the standard, so we might have to live with the measurement and test method being precoordinated.  Let's double check with SOLOR, if possible, and see whether SOLOR also precoordinates the test with the result. For the ballot, we can use temporary local codes. Does that make sense?

I checked with Susan Matney, and she agrees with approach #1. In other words, there should be separate LOINC codes for "ER average staining intensity" and "PR average staining intensity".

resolved as of commit 52b240aa016781c890539bdffc6d44a17aa640e6 to dev6.


Custom sortArrowIcon and sortArrowAnimationDuration

I'm still working on this pull request but wanted to check something with you on the widget testing. I've added a file called "sort_arrow_test.dart" to the test folder to show a problem I'm facing but don't know how to solve.
When I run an app using DataTable2 with these new custom icon parameters, it seems to work. I can use whatever icon I choose and the durations look to execute properly. The icon also rotates 180 degrees each time I click the column header to sort. The problem I have during testing is that when I use tester.tap(), the test will arrive at onSort and execute the code there but the "ascending" parameter does not toggle. I can see in the normal app's debugging that this parameter will toggle each time it is called because of sort = !sort and then the table is rebuilt with the updated sort. However, the test does not rebuild DataTable2 after onSort is called.
I have also tried with a stateful widget in the test so that I could try setState() with sort = !sort but that apparently isn't the issue. I don't know why the test doesn't rebuild DataTable2() so that ascending will toggle the icon. Since it doesn't toggle, I can't yet test for the rotation of the icon. Can you see anything I'm doing wrong in this test?

@hootyjeremy, please check my last commit, now you can get arrow updates in the tests:

The problem you had is related to the fact that data table is stateless and needs to be rebuilt in the onSort event, that's why you have to wrap in into a stateful widget, I used StreamBuilder for that. Now you can proceed with finilizing the tests.
Few notes on code organisation and refactoring. This single test doesn't deserve a separate file sort_arrow_test.dart, please move the test to custom_features_test.dart under group('DataTable2', () {}). Beside please reuse the existing buildTable()method from test_utils.dart by adding those 2 new params as optional ones - no need to duplicate code and introduce another version of buildTable(), let's keep it cleaner.

Thanks for the info on the StreamBuilder for the tests. I have added these to the tests which show that the custom icon can be applied and it's rotation will be correct not before the custom duration, but after.
From my previous pull request, you had requested that I update example/lib/screens/data_table2.dart with the custom arrow. I made an attempt but I'm not sure if this is what you had in mind. Please let me know if it isn't.

I am not sure what happened here. Let me scrap this one and start fresh with a good working folder. I am getting the tests passing here now. Still very new to GitHub and and collaborating versions.


Issue52 featured fragment for both en and jp languages

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fixes #52
Test URLs:

Original: https://www.sunstar-foundation.org/newsroom

Before: https://main--sunstar-foundation--hlxsites.hlx.live/en/fragments/featured-articles-newsroom

After: https://issue52-featured-fragment--sunstar-foundation--hlxsites.hlx.page/en/fragments/featured-articles-newsroom

Before: https://main--sunstar-foundation--hlxsites.hlx.live/fragments/featured-articles-newsroom

After: https://issue52-featured-fragment--sunstar-foundation--hlxsites.hlx.page/fragments/featured-articles-newsroom

[ ] New Blocks introduced in this PR
If yes, please provide details below

Block Name
Documentation

For e.g. cards
doc-link

[ ] New variations introduced in this PR

Variation Name
Documentation

For e.g. cards (grid)
doc-link

Why this PR contains ja to jp changes ?

Closing this PR since the changes are already taken care by https://github.com/hlxsites/sunstar-foundation/pull/69


Load scripts in parallel to reduce total page load time by ~2 seconds

I noticed that the loading was a bit slow due to the serial loading of the scripts:
https://user-images.githubusercontent.com/1167575/195853315-650fb495-4e5b-4d69-8049-2b6555cf2007.mp4
This patch should cut load time down from ~4 seconds to ~2 seconds. It assumes that all scripts other than index.js can be loaded in parallel.
Please feel free to close this pull request if you'd rather implement this in a different way (e.g. by bundling the scripts).
Thanks for all your work on this project!

Ahh, it should have been document.head.appendChild rather than document.body.appendChild. I've made that change, but I now realise that there are dependencies between the scripts. E.g. at the top of gzip.js there's this line:
var zip = zip || require('./zip');

And since we're now loading the scripts in parallel it's possible for gzip.js to load before zip.js which will cause an error on the web saying "require is not defined". Does zip need to be assigned synchronously here? If not you could move all those assignments to the top of index.js. If you use var during assignment, then that will make them available globally - i.e. to all scripts, no matter which script you declared them in.
If those assignments are needed synchronously (i.e. the immediate execution of the gzip.js script as the page loads requires the zip variable to be assigned), then either a refactor may be needed, or you could load the scripts in a sequence of several batches, based on their dependencies. If you have a long sequence of dependencies then that might defeat the purpose of this change.
Ideally you don't need the assignments like var zip = zip || require('./zip'); until you get to index.js, so you could just move them all to the top of index.js.

Ideally you don't need the assignments like var zip = zip || require('./zip'); until you get to index.js, so you could just move them all to the top of index.js.

Required for the Electron desktop app.

@lutzroeder Could you do something like this?
if (typeof window === 'undefined') { // i.e. only in Electron
  var zip = zip || require('./zip');
}

The var makes zip hoisted, so it will be available as a global within the script in Electron.


fix: Add database-name parameter to RDS module & VPC CIDR block

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

AWS CodeBuild CI Report

CodeBuild project: IDFModuleTestsInfrastructur-59JoFoVH64CI
Commit ID: 0c54a88e0dbe95fe5f8f5fb43d50943c476d6a31
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

CHANGELOG is missing

AWS CodeBuild CI Report

CodeBuild project: IDFModuleTestsInfrastructur-59JoFoVH64CI
Commit ID: c12bd55fdcd3135e723e9c433d3288c09ca1c9e7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: IDFModuleTestsInfrastructur-59JoFoVH64CI
Commit ID: 777f6b00c1a7ab6f8e94c31a716bce0215ea744f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


mc_forecast dosen't work because historical observations depends on AGWeatherNet which doesn't work

After trying a lot with deep_mc notebook , it depends on a backend call to retrieve agweathernet data somehow which obviously doesn't work & limits the workflow scope, it would be great to show an example file of how the data is downloaded & pre-processed to be able to replace it with more generalized historical weather api ( Like : Microsoft Azure Weather Rest API or openweather historical  weather) ,
the error is found after running historical_dataset = utils.get_csv_data(path=file_path)
result :
Cell In[11], line 1
----> 1 historical_dataset = utils.get_csv_data(path=file_path)

File ~/farmvibes-ai/notebooks/deepmc/notebook_lib/utils.py:20, in get_csv_data(path, date_attribute, columns_rename, frequency)
     10 def get_csv_data(
     11     path: str,
     12     date_attribute: str = "date",
     13     columns_rename: Dict[str, str] = {},
     14     frequency: str = "60min",
     15 ):
     16     """
     17     Read data from CSV file using Pandas python package.
     18     """
---> 20     data_df = pd.read_csv(path)
     21     data_df[date_attribute] = pd.to_datetime(data_df[date_attribute])
     23     if columns_rename:

File ~/anaconda3/envs/deepmc-pytorch/lib/python3.8/site-packages/pandas/util/_decorators.py:211, in deprecate_kwarg.<locals>._deprecate_kwarg.<locals>.wrapper(*args, **kwargs)
    209     else:
    210         kwargs[new_arg_name] = new_arg_value
--> 211 return func(*args, **kwargs)

File ~/anaconda3/envs/deepmc-pytorch/lib/python3.8/site-packages/pandas/util/_decorators.py:331, in deprecate_nonkeyword_arguments.<locals>.decorate.<locals>.wrapper(*args, **kwargs)
    325 if len(args) > num_allow_args:
    326     warnings.warn(
    327         msg.format(arguments=_format_argument_list(allow_args)),
    328         FutureWarning,
    329         stacklevel=find_stack_level(),
    330     )
--> 331 return func(*args, **kwargs)

File ~/anaconda3/envs/deepmc-pytorch/lib/python3.8/site-packages/pandas/io/parsers/readers.py:950, in read_csv(filepath_or_buffer, sep, delimiter, header, names, index_col, usecols, squeeze, prefix, mangle_dupe_cols, dtype, engine, converters, true_values, false_values, skipinitialspace, skiprows, skipfooter, nrows, na_values, keep_default_na, na_filter, verbose, skip_blank_lines, parse_dates, infer_datetime_format, keep_date_col, date_parser, dayfirst, cache_dates, iterator, chunksize, compression, thousands, decimal, lineterminator, quotechar, quoting, doublequote, escapechar, comment, encoding, encoding_errors, dialect, error_bad_lines, warn_bad_lines, on_bad_lines, delim_whitespace, low_memory, memory_map, float_precision, storage_options)
    935 kwds_defaults = _refine_defaults_read(
    936     dialect,
    937     delimiter,
   (...)
    946     defaults={"delimiter": ","},
    947 )
    948 kwds.update(kwds_defaults)
--> 950 return _read(filepath_or_buffer, kwds)

File ~/anaconda3/envs/deepmc-pytorch/lib/python3.8/site-packages/pandas/io/parsers/readers.py:605, in _read(filepath_or_buffer, kwds)
    602 _validate_names(kwds.get("names", None))
    604 # Create the parser.
--> 605 parser = TextFileReader(filepath_or_buffer, **kwds)
    607 if chunksize or iterator:
    608     return parser

File ~/anaconda3/envs/deepmc-pytorch/lib/python3.8/site-packages/pandas/io/parsers/readers.py:1442, in TextFileReader.__init__(self, f, engine, **kwds)
   1439     self.options["has_index_names"] = kwds["has_index_names"]
   1441 self.handles: IOHandles | None = None
-> 1442 self._engine = self._make_engine(f, self.engine)

File ~/anaconda3/envs/deepmc-pytorch/lib/python3.8/site-packages/pandas/io/parsers/readers.py:1735, in TextFileReader._make_engine(self, f, engine)
   1733     if "b" not in mode:
   1734         mode += "b"
-> 1735 self.handles = get_handle(
   1736     f,
   1737     mode,
   1738     encoding=self.options.get("encoding", None),
   1739     compression=self.options.get("compression", None),
   1740     memory_map=self.options.get("memory_map", False),
   1741     is_text=is_text,
   1742     errors=self.options.get("encoding_errors", "strict"),
   1743     storage_options=self.options.get("storage_options", None),
   1744 )
   1745 assert self.handles is not None
   1746 f = self.handles.handle

File ~/anaconda3/envs/deepmc-pytorch/lib/python3.8/site-packages/pandas/io/common.py:856, in get_handle(path_or_buf, mode, encoding, compression, memory_map, is_text, errors, storage_options)
    851 elif isinstance(handle, str):
    852     # Check whether the filename is to be opened in binary mode.
    853     # Binary mode does not support 'encoding' and 'newline'.
    854     if ioargs.encoding and "b" not in ioargs.mode:
    855         # Encoding
--> 856         handle = open(
    857             handle,
    858             ioargs.mode,
    859             encoding=ioargs.encoding,
    860             errors=errors,
    861             newline="",
    862         )
    863     else:
    864         # Binary mode
    865         handle = open(handle, ioargs.mode)

FileNotFoundError: [Errno 2] No such file or directory: './data/Palouse/training.csv'

Also , the default environment seems to be missing unfoldN package

Thanks for reaching out for the issue identified.
The deepmc showing the example to execute the notebook using AgWeatherNet station (Palouse) data. Based on station name the path of source is derived. Please make sure to have the data available at below path prior to execution.
f"./data/{STATION_NAME}/training.csv"
Attaching the sample data downloaded from AGWeatherNet.
palouse_agweathernet.csv
For the missing package "unfoldN", we will the missing packages.

Hello, please also bear in mind that we need historical data from the weather station for which you want to make more accurate forecast. Relying on OpenWeather or other data source that have low spatial resolution could lead to a degradation in performance.

Thank you ionnes ,  indeed it's our goal to use deepmc to drive our weather station predictions more over we are trying to train the system to the errors between weather station actual's & predictions versus weather services actual's & predictions  in the hopes to deliver a superior weather service eventually , I think that the system offers an opportunity for correlating spatial & temporal errors in weather services after enough training

How does AgWeather register a 'No value' value? Thanks in advance,

Hi, @aialves. Are you seeing any issue with the workflow itself due to no values?
The AgWeather API documentation has additional information on how they handle these values.


fix: remove visibility change event listener on feed teardown

Description
This PR makes sure we remove the visibilitychanged event listener when we tear down the feed instance.

I am encountering this issue in react native , with lastest version of sdk, How to resolve this?

Hi @Yogeshwar267, could you file a new issue in this repo with more information on the issue you’re seeing? Please include details on how to reproduce the issue so we can get it fixed quickly. Thanks!


Issue 1956

Rating Component

Close #1956

Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md

Branch conflicts are not resolved

@pranjay-poddar Resolved.

Closing due to unresolved branch conflicts


Manifest merger failed

Describe the bug
I received this bug when import the module from gradle.
Manifest merger failed : Attribute application@appComponentFactory value=(android.support.v4.app.CoreComponentFactory) from [com.android.support:support-compat:28.0.0] AndroidManifest.xml:22:18-91
	is also present at [androidx.core:core:1.1.0-alpha04] AndroidManifest.xml:22:18-86 value=(androidx.core.app.CoreComponentFactory).
	Suggestion: add 'tools:replace="android:appComponentFactory"' to <application> element at AndroidManifest.xml:14:5-45:19 to override.

It seems this module use AndroidX in developing.
Does there is a way to use this module without AndroidX ?
I have read the similar issue #22.
But the solution is not suitable to me.
To Reproduce
Steps to reproduce the behavior:

Add jaiselrahman:FilePicker to project

dependencies {
    implementation 'com.github.jaiselrahman:FilePicker:1.2.2'
}

Try build code to phone

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
Here is the merged Manifest.

Here is my project's  build.gradle file
// Top-level build file where you can add configuration options common to all sub-projects/modules.

buildscript {
    ext.kotlin_version = '1.3.30'
    repositories {
        google()
        jcenter()
        maven { url 'https://jitpack.io' }
    }
    dependencies {
        classpath 'com.android.tools.build:gradle:3.4.0'
        classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
    }
}

allprojects {
    repositories {
        google()
        jcenter()
    }
}

task clean(type: Delete) {
    delete rootProject.buildDir
}

Here is my app's  build.gradle file
apply plugin: 'com.android.application'
apply plugin: 'kotlin-android'
apply plugin: 'kotlin-android-extensions'
apply plugin: 'kotlin-kapt'

allprojects {
    repositories {
        maven { url 'https://jitpack.io' }
    }
}

android {
    compileSdkVersion 28
    defaultConfig {
        applicationId "......................."
        minSdkVersion 21
        targetSdkVersion 28
        versionCode 1
        versionName "1.0"
        testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
    }
    buildTypes {
        release {
            minifyEnabled false
            proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
        }
    }
}

buildscript {
    ext.supportLibraryVersion = '28.0.0'
    ext.butterknifeVersion = '8.8.1'
    ext.glideVersion = '4.7.1'
    ext.jdeferredVersion = '2.0.0-beta1'
}

dependencies {
    implementation fileTree(dir: 'libs', include: ['*.jar'])
    implementation"org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
    implementation 'com.android.support:appcompat-v7:28.0.0'
    implementation "com.android.support:appcompat-v7:$supportLibraryVersion"
    implementation "com.android.support:support-v4:$supportLibraryVersion"
    implementation "com.android.support:design:$supportLibraryVersion"
    implementation 'com.android.support.constraint:constraint-layout:1.1.3'

    implementation "com.jakewharton:butterknife:$butterknifeVersion"
    kapt "com.jakewharton:butterknife-compiler:$butterknifeVersion"

    implementation 'io.reactivex.rxjava2:rxkotlin:2.2.0'
    implementation 'io.reactivex.rxjava2:rxandroid:2.1.0'

    implementation 'org.immutables:gson:2.7.1'
    implementation 'com.squareup.okhttp3:okhttp:3.12.0'
    implementation 'com.github.bumptech.glide:okhttp3-integration:4.9.0'
    implementation "com.github.bumptech.glide:glide:$glideVersion"
    kapt "com.github.bumptech.glide:compiler:$glideVersion"

    implementation 'com.github.jaiselrahman:FilePicker:1.2.2'

    implementation "org.jdeferred.v2:jdeferred-core:$jdeferredVersion"
    implementation "org.jdeferred.v2:jdeferred-android:$jdeferredVersion"

    testImplementation 'junit:junit:4.12'
    androidTestImplementation 'com.android.support.test:runner:1.0.2'
    androidTestImplementation 'com.android.support.test.espresso:espresso-core:3.0.2'
}

Android info (please complete the following information):

Device/Emulator Nexus 5X (Android 8.1.0)
API level 27

I found it maybe this commit 21c0bb975efb3adb955c40ff3f6e1128adc89596 cause the problem.

You can use the older version 1.1.1, but if you have to use newer version you have to migrate to androidx.

Yeah, I tried the older version 1.1.1 I got another exceptions
java.lang.NoSuchMethodError: No virtual method optionalCenterCrop()Lcom/bumptech/glide/request/RequestOptions; in class Lcom/bumptech/glide/request/RequestOptions; or its super classes (declaration of 'com.bumptech.glide.request.RequestOptions' appears in /data/app/................/split_lib_dependencies_apk.apk)
        at com.jaiselrahman.filepicker.adapter.FileGalleryAdapter.<init>(FileGalleryAdapter.java:75)
        at com.jaiselrahman.filepicker.activity.FilePickerActivity.onCreate(FilePickerActivity.java:100)
        at android.app.Activity.performCreate(Activity.java:7009)
        at android.app.Activity.performCreate(Activity.java:7000)
        at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1214)
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2731)
        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2856)
        at android.app.ActivityThread.-wrap11(Unknown Source:0)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1589)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loop(Looper.java:164)
        at android.app.ActivityThread.main(ActivityThread.java:6494)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)

It seems glide version not match for the project (version too old).

I found another way to solve the problem by using fork project. 😘
I fork the project and revert the commit 21c0bb975efb3adb955c40ff3f6e1128adc89596
then apply the new gradle dependencies with new jitpack path
dependencies {
    implementation 'com.github.j796160836:FilePicker:master_without_androidx-SNAPSHOT'
}

Details is in here.
https://github.com/j796160836/FilePicker/tree/master_without_androidx
It works like a charm.

Great!

I found another way to solve the problem by using fork project. 😘
I fork the project and revert the commit 21c0bb9
then apply the new gradle dependencies with new jitpack path
dependencies {
    implementation 'com.github.j796160836:FilePicker:master_without_androidx-SNAPSHOT'
}

Details is in here.
https://github.com/j796160836/FilePicker/tree/master_without_androidx
It works like a charm.

Please pardon my ingorance.
I used that, and still got the same "Manifest merger failed with multiple errors, see logs".
It's a pretty simple project, doesn't use AndroidX, and the min SDK version is 15.
The only 3rd party lib used is https://github.com/SUPERCILEX/poi-android (used for dealing with XLSX files).
Here is my source code: http://<IP_ADDRESS>/tmp/v1/StockChecker.zip

@anta40  You just have to remove the line tools:replace="android:appComponentFactory" from manifest file.

@jaiselrahman
I am also getting the same error
java.lang.NoSuchMethodError: No virtual method optionalCenterCrop()Lcom/bumptech/glide/request/RequestOptions; in class Lcom/bumptech/glide/request/RequestOptions; or its super classes
Version used :implementation 'com.github.jaiselrahman:FilePicker:1.1.1'
Please help to resolve the issue without migrating to androiX

Which glide version are you using?
Make sure you are using glide version 4.9.0 or greater. See #19.

I am not using Glide.
But I am using another picker for single image selection.
implementation 'gun0912.ted:tedbottompicker:2.0.1'
Which also uses Glide may be because of it the issue is occurring.

Which version of the library are you using?

implementation 'gun0912.ted:tedbottompicker:2.0.1'
implementation 'com.github.jaiselrahman:FilePicker:1.1.1'

Try using the latest version along with
tools:replace="android:appComponentFactory" in the manifest file <application .../> tag.

Or you can use the following version
implementation 'com.github.j796160836:FilePicker:master_without_androidx-SNAPSHOT'

Okay. I will check once


Add cloudflare cache

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Resolves https://github.com/sveltejs/kit/issues/3862.
Add cache to dynamically generated pages at the edge by using the cloudflare cache api. Pages that have a cache policy (maxage) will be stored.

@johnwalshuk You aren't checking for the max-age(time nor even is it present) as far as i can see

@johnwalshuk You aren't checking for the max-age(time nor even is it present) as far as i can see

Cloudflare inspects the response headers automatically. See https://developers.cloudflare.com/workers/runtime-apis/cache/#headers

Didn't know that, but still, relying on it isn't really advisable.

@PH4NTOMiki why?
The only things to be wary of are invalid parameters and errors. But there's a try/catch in place already so both can be ignored in this case.
Personally I manually check before any calls to cache.put just to be sure, but what's here (after suggestion) should be okay for general use. If anything needs to be added, it's appending 'private=Set-Cookie' when there's a cookie present.

@lukeed okay, if you say that, then I stand corrected. but as you said personally, checking it is nice, and it's clearer what's going on in the code.

how can I disable this feature?

@jahir9991  > how can I disable this feature?
I'm not sure if it's the right solution (or if we had the same problem 😅).
But after adding the following headers, the Responses aren't cached any more:
headers: {
  "Cache-Control": "no-store",
  "max-age": "no-cache",
}

The cache-control header is the only relevant header here

how can configure it for disable cache  in global layer

You can use a global handle hook to ensure Cache-Control headers are doing what you want:
// src/hooks.js

/** @type {import('@sveltejs/kit').[Handle](https://kit.svelte.dev/docs/types#sveltejs-kit-handle)} */
export async function handle({ event, resolve }) {
  event.request = new Request(event.request);
  event.request.headers.set('cache-control', 'no-cache');

  let response = await resolve(event);

  response = new Response(response.body, response);
  response.headers.set('cache-control', 'no-cache');

  return response;
}

untested, but should work based on docs


Net - peer database

AElf.Kernel -> Node -> Network -> Peers
Chosen a simple CRUD rather than a database for simplicity.


Add use-proxy support to health extra args

This fixes #2828, and resolves the concerns in #2838.
Specifically, it adds an env of USES_PROXY_PROTOCOL, and when present, passes the --use-proxy argument to mc-health

Only resurrected it because I had a server stay on all day and surprise me


How to save cognito user to dynamodb?

as the title says, I wanna know how to save the newly registered user into dynamodb users table?

It might be better to post this over on the forums - https://discourse.serverless-stack.com
But really quickly, you could do this by using Cognito User Pool triggers or you can make an API in your backend and call that after the user signs up.


Docker can't connect to MySQL

I setup the whole stuff on a complete Debian 10 with the guide and everything works.
Now I would use the docker container instead, but it is not possible to connect to the DB with <IP_ADDRESS>:
powerdns_admin | sqlalchemy.exc.OperationalError: (MySQLdb._exceptions.OperationalError) (2002, "Can't connect to MySQL server on '<IP_ADDRESS>' (115)")
or with localhost
powerdns_admin | sqlalchemy.exc.OperationalError: (MySQLdb._exceptions.OperationalError) (2002, "Can't connect to local MySQL server through socket '/run/mysqld/mysqld.sock' (2)")
My config (If I use mysql connect from console with these settings its working)
     - SQLALCHEMY_DATABASE_URI=mysql://powerdnsadmin:XXX@localhost/powerdnsadmin

If you are running PDA on docker, please change the MySQL host address. It not localhost or <IP_ADDRESS> anymore.

Aaa yeah had to change from localhost to the real server IP, and the MariaDB Server also configure to listen on that not on localhost.
Now it's running, thanks.


[WIP] Add testing guide (DO NOT MERGE)

Adds a testing guide which gives some insight into how to navigate the
Bazel targets.

I think I want to update this and turn it into more of a developer guide for contributors.

This issue has useful info on running a debugger.
https://github.com/google/gvisor/issues/590


Rename num_classes to classes for keras_cv landing page

This is reflective of the API change being made in https://github.com/keras-team/keras-cv/pull/657

@fchollet

https://pypi.org/project/keras-cv/ is out, so this is ready.


No module named 'bids.grabbids'

Hi,
it seems there is some confusion with PyBIDS.
I am using Python3.7 and installing pybids as
 pip3 install bids
Unfortunately when try something e.g. python3 CLI.py  I get

No module named 'bids.grabbids'

googleing people suggest pip3 install pybids==0.6.5
which doesn't work and creates even more mess in my environment. Do you confirm everything is fine in the pybids use?

Hi, This command line application was built with an older version of pybids (0.6.5 to be specific).
Indeed, using pip3 install pybids==0.6.5 should solve the issue.
But, you cannot directly run python3 CLI.py, the library doesn't allow this.
You will be presented with the following error if you try to do it:
CLI.py should not be run directly. Please `pip install` rsHRF and use the `rsHRF` command

I suggest creating a separate python environment, perhaps with conda (or virtualenv, etc.) and then installing rsHRF into that environment. Then, you can use this library as a command line application.
To install the library and to see how to use it, you can refer the docs here: http://bids-apps.neuroimaging.io/rsHRF/
You can also use the docker image.
We might want to upgrade to the latest version of pybids, but that is a discussion for another day perhaps.

Dear @alecrimi
thanks for the interest in the code. Dear @madhur-tandon, thanks a lot for the quick response!
Hopefully this suggestion will work.
Also, we are preparing the release of an updated version (cc @AmoghJohri ). If you are interested you could beta test this one, then we can update the docker and the pip. Let us know, and talk soon!


--skip-open flag for glasskube serve command

Is your feature request related to a problem? Please describe.
The glasskube serve command always opens a new browser tab. In cases where the command is often stopped and restarted (like development), this can be annoying.
Describe the solution you'd like
The command should have a flag --skip-open (shorthand: -s). When it is set, the page should not be opened in the browser.
Describe alternatives you've considered
Additional context

Hello @christophenne , I'm interested in working on this issue. Would it be okay for me to pick it up?

@mahiro72 yes, sure


Provide source maps for written (sourced) ASTNodes

Status
WIP, as it is a POC. Requesting for review and feedback.
Changes

[X] Tweaked ASTWriter and subcomponents to also allow to get each written node source respectively during the single writing pass.
[X] Introduced ASTSourceMapComputer class to compute sourcemap for each node.

Notes

I'm aware that tests are broken. This is due to necessity for a debug output for the computed source map. To check the results use following:sol-ast-compile sample.sol --source --with-source-map

I'm currently interested in the edge-case samples, like following:pragma solidity 0.7.5;

contract Test {
    uint i = 1;

    function main() public {
        uint i = 1;

        i = 1;

        {
            i = 1;
        }

        i = 1;
        i = 1;
    }
}

Concerns

We have an issue with meta-nodes, that are produced by Solc anyway. Like return ParamaterList for an empty returns of the function. They are actually was ignored as there is nothing to write. Current approach expects that each node is detectable, but this case would require a special care.

Codecov Report

Merging #16 (7985291) into master (70f7556) will decrease coverage by 0.81%.
The diff coverage is 73.15%.

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage   93.44%   92.63%   -0.82%
==========================================
  Files         199      199
  Lines        3755     3803      +48
  Branches      492      499       +7
==========================================
+ Hits         3509     3523      +14
- Misses        158      190      +32
- Partials       88       90       +2

Impacted Files
Coverage Δ

src/ast/writing/writer.ts
42.30% <18.18%> (-42.70%)
:arrow_down:

src/bin/compile.ts
89.92% <53.33%> (-4.61%)
:arrow_down:

src/ast/writing/ast_mapping.ts
94.24% <94.05%> (+0.07%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33585fb...7985291. Read the comment docs.

Codecov Report

Merging #16 (7985291) into master (70f7556) will decrease coverage by 0.81%.
The diff coverage is 73.15%.

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage   93.44%   92.63%   -0.82%
==========================================
  Files         199      199
  Lines        3755     3803      +48
  Branches      492      499       +7
==========================================
+ Hits         3509     3523      +14
- Misses        158      190      +32
- Partials       88       90       +2

Impacted Files
Coverage Δ

src/ast/writing/writer.ts
42.30% <18.18%> (-42.70%)
:arrow_down:

src/bin/compile.ts
89.92% <53.33%> (-4.61%)
:arrow_down:

src/ast/writing/ast_mapping.ts
94.24% <94.05%> (+0.07%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33585fb...7985291. Read the comment docs.


Attach SDK product to each release as a resource for non-source-build devs to understand the state of source-build

I think source-build should:

Save the built SDK in the rolling build pipeline. (For some distro, probably CentOS.)
Upload the built SDK to the GitHub release.

OR have some way to trace the GitHub release back to the AzDO build to find this artifact. (Not useful to external contributors, but maybe storage space is a concern?)

Since I don't actively work on it, I don't have completed source-builds laying around (especially multiple branches!), but I fairly often want to know the current state of the source-build project to avoid breaking it, or to understand how source-build puts some things together. (And maybe find a bug.)
At the moment I'm particularly interested in 3.1.0-preview1.
@crummel @dseefeld @adaggarwal

Also related #1321.

[Triage] This appears to be covered by #1321


Add centos ci script

The added script sets up a worker machine, builds the software and runs the tests.

This change is

@kbsingh I've copied over your changes from kbsingh/almighty-core#1 to this repo.

Comments from Reviewable

We're currently not running test-integration in this setup?

Comments from Reviewable

No, but I commented here, that this should be doable. Let's start with something that worked for KB and add it later. It's really simple to add integration tests later.

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable


Deploying prisma to CloudFlare pages using Nuxt/Nitro and node-postgres (pg) is using the wrong(vercel) wasm path

Bug description
Deploying prisma to CloudFlare pages using Nuxt/Nitro and node-postgres (pg) seems to be using the wrong wasm path as if the current runtime has been detected as vercel.
It also happpens locally when using nitro with the cloudflare-pages present
Error:
Building Nuxt Nitro server (preset: cloudflare_pages)                                                                          nitro 11:55:06 PM

[nitro 11:55:07 PM]  ERROR  Error: Could not load /Users/.../node_modules/.prisma/client/query_engine_bg.wasm?module (imported by node_modules/.prisma/client/wasm-edge-light-loader.js): ENOENT: no such file or directory, open '/Users/.../node_modules/.prisma/client/query_engine_bg.wasm?module'

How to reproduce

Create a nuxt app with prisma
Set the cloudflare preset nuxt.config.ts:

nitro: {
    preset: 'cloudflare-pages'
  },

run  npx nuxi build

Expected behavior
Cloudflare is not detected as edge-light runtime and loads the correct wasm.
Prisma information

// Add your schema.prisma

// Add your code using Prisma Client

Environment & setup

OS: macOS
Database: Postgre with adapter-pg

Prisma Version
5.11.0

Hi @langleyd
This is a bug on Nitro's side. There is unfortunately no workaround we can do on our side. We've already reported it here, you can follow the progress on Nitro repo.
There is also another problem in nitro's wasm handling and we are working with them to fix it as well.

Hi @langleyd, may you please try this new unofficial version of Prisma, and report back with the results on your Nuxt app? 5.15.0-integration-client-dynamic-wasm-imports.1
You can quickly install it via:
pnpm add -D<EMAIL_ADDRESS>pnpm update "@prisma/*" 5.15.0-integration-client-dynamic-wasm-imports.1

(please double check that prisma generate has run before retrying).
Thanks!

Hi @langleyd, may you please try this new unofficial version of Prisma, and report back with the results on your Nuxt app? 5.15.0-integration-client-dynamic-wasm-imports.1
You can quickly install it via:
pnpm add -D<EMAIL_ADDRESS>pnpm update "@prisma/*" 5.15.0-integration-client-dynamic-wasm-imports.1

(please double check that prisma generate has run before retrying). Thanks!

Bad news (thanks @SevInf for the internal report): apparently, the application works locally with pnpm dev, but it fails once built with

[10:54:40 AM]  ERROR  Could not load /private/tmp/prisma-driver-adapters-nuxt/node_modules/.pnpm/@prisma+client@5.15.0-integration-client-dynamic-wasm-imports.1_prisma@5.15.0-integration-client-dynamic-wasm-imports.1/node_modules/.prisma/client/query_engine_bg.wasm?module (imported by node_modules/.pnpm/@prisma+client@5.15.0-integration-client-dynamic-wasm-imports.1_prisma@5.15.0-integration-client-dynamic-wasm-imports.1/node_modules/.prisma/client/wasm-edge-light-loader.js): ENOENT: no such file or directory, open '/private/tmp/prisma-driver-adapters-nuxt/node_modules/.pnpm/@prisma+client@5.15.0-integration-client-dynamic-wasm-imports.1_prisma@5.15.0-integration-client-dynamic-wasm-imports.1/node_modules/.prisma/client/query_engine_bg.wasm?module'

Update: this issue goes away when using the version mentioned here + setting
nitro: {
  experimental: {
    wasm: true
  }
}

in the nuxt.config.js configuration file.

Hi @langleyd, we're closing this issue via https://github.com/prisma/docs/issues/6054 + https://github.com/prisma/team-orm/issues/1164. You can now refer to this documentation: https://www.prisma.io/docs/orm/overview/databases/database-drivers#nuxt.
We also recommend using Prisma 5.15.0 on Nuxt @ Edge. Thanks!


Version tags

@peremato , when this package gets registered, Julia Registrator won't like the fact that it's already at version 0.1.2.
I would suggest to revert to version 0.1.0, if possible, until package registration.
CC @moelf

I increased the version number on my failed attempts to register. It required Geant4_julia_jll be registered and some issue with the compat section. According to the mail I got I should re-attempt without changing the version.

Error while trying to register: Register Failed
@oschulz, it looks like you don't have collaborator status on this repository.

@oschulz  Before re-trying the registration I need to sort out the problem https://github.com/JuliaRegistries/General/pull/80960#issuecomment-1495267235 registering Geant4_julia_jll I have asked Mosè Giordano, but  perhaps you have an idea. https://github.com/JuliaPackaging/Yggdrasil/pull/6490#issuecomment-1495388772

Regarding the name "geant4_julia_jll",
write a comment like
[noblock]

Regarding "Lowercase package name geant4_julia_jll contains the string julia"  - I tried to follow naming conventions for similar packages in Yggdrasil". Could this be merged manually?

on https://github.com/JuliaRegistries/General/pull/80960 .
But like you say, the package loading problem needs to be figured out first. @giordano is the expert here ...
Mosè, do you see what's going wrong there?

I answered at https://github.com/JuliaPackaging/Yggdrasil/pull/6490#issuecomment-1495715943

Congrats!

I suggest you add Julia TagBot to your GitHub actions, @peremato , it'll automatically created releases on the repo after Registrator is done with it's job.


userload.co

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I remove or skip any mandatory* field

Checklist

[X] I'm reporting a new site support request
[X] I've verified that I'm running yt-dlp version 2022.08.14 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that none of provided URLs violate any copyrights or contain any DRM to the best of my knowledge
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[ ] I've read about sharing account credentials and am willing to share it if required

Region
any
Example URLs
https://userload.co/f/8cf1e4c373ca
Provide a description that is worded well enough to be understood
Please add suppor for this site. I've searched for "is:issue userload" and didn't find any requests. No login is required for downloading the video.
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[debug] Command-line config: ['-vU', 'https://userload.co/f/8cf1e4c373ca']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version 2022.08.14 [5593720] (zip)
[debug] Python 3.8.10 (CPython 64bit) - Linux-5.4.0-124-generic-x86_64-with-glibc2.29 (glibc 2.31)
[debug] Checking exe version: ffmpeg -bsfs
[debug] Checking exe version: ffprobe -bsfs
[debug] exe versions: ffmpeg 4.2.7, ffprobe 4.2.7
[debug] Optional libraries: certifi-2019.11.28, pycrypto-2.6.1, secretstorage-2.3.1, sqlite3-2.6.0
[debug] Proxy map: {}
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version: 2022.08.14, Current version: 2022.08.14
yt-dlp is up to date (2022.08.14)
[debug] [generic] Extracting URL: https://userload.co/f/8cf1e4c373ca
[generic] 8cf1e4c373ca: Downloading webpage
WARNING: [generic] Falling back on generic information extractor
[generic] 8cf1e4c373ca: Extracting information
[debug] Looking for Brightcove embeds
[debug] Looking for embeds
ERROR: Unsupported URL: https://userload.co/f/8cf1e4c373ca
Traceback (most recent call last):
  File "/usr/local/bin/yt-dlp/yt_dlp/YoutubeDL.py", line 1441, in wrapper
    return func(self, *args, **kwargs)
  File "/usr/local/bin/yt-dlp/yt_dlp/YoutubeDL.py", line 1517, in __extract_info
    ie_result = ie.extract(url)
  File "/usr/local/bin/yt-dlp/yt_dlp/extractor/common.py", line 666, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/bin/yt-dlp/yt_dlp/extractor/generic.py", line 3077, in _real_extract
    raise UnsupportedError(url)
yt_dlp.utils.UnsupportedError: Unsupported URL: https://userload.co/f/8cf1e4c373ca

I looks to me like the given URL is pirated content. An I wrong?

No, the material was free at the time it was copied to other sites.
Anyway... https://www.youtube.com/static?gl=US&template=terms
"You are not allowed to [...] access, reproduce, download, distribute, transmit, broadcast, display, sell, license, alter, modify or otherwise use any part of the Service or any Content except: (a) as expressly authorized by the Service; or (b) with prior written permission from YouTube and, if applicable, the respective rights holders."
Do you REALLY want to go down that hole?

Free doesn't mean you have the right to redistribute the content


Migrated project to use browserify, PushPlugin then became totally flaky

Very odd behaviours since I migrated to browserify: everything works fine but notifications. I am targeting android only. I have tested with v1.1.1 and also with the latest on this repository and the issue remains. If I revert to my commit pre-migration to browserify, it works fine again. I have also tried to keep PushNotification related logic outside of browserify but no luck.
I have added logs before PushNotification.init, after and around all my push.on() calls. This initialisation will stop randomly in the middle and only rarely print the last log proving it completed properly.
Once loaded, I send a series of notifications to my device and observe randomly one of the below outputs for each notification. I don't do anything beside sending notifications to the device and each notification gets a different treatment by the plugin.
Output 1:
V/GCMBaseIntentService( 8663): Intent service name: GCMIntentService-GCMIntentService-12

Output 2:
V/GCMBroadcastReceiver( 8663): onReceive: com.google.android.c2dm.intent.RECEIVE
V/GCMBroadcastReceiver( 8663): GCM IntentService class: com.adobe.phonegap.push.GCMIntentService
V/GCMBaseIntentService( 8663): Acquiring wakelock

Output 3:
V/GCMBroadcastReceiver( 8663): onReceive: com.google.android.c2dm.intent.RECEIVE
V/GCMBroadcastReceiver( 8663): GCM IntentService class: com.adobe.phonegap.push.GCMIntentService
V/GCMBaseIntentService( 8663): Acquiring wakelock
D/PushPlugin_GCMIntentService( 8663): onMessage - context: android.app.Application@33b3eeaf
D/PushPlugin( 8663): key = from
D/PushPlugin( 8663): key = goal
D/PushPlugin( 8663): key = user
D/PushPlugin( 8663): key = title
D/PushPlugin( 8663): key = message
D/PushPlugin( 8663): key = collapse_key
D/PushPlugin( 8663): key = foreground
V/PushPlugin( 8663): extrasToJSON: {XXX payload XXX}
>> [here logs of 0, few are all of the registered callbacks on 'notification'] <<
V/GCMBaseIntentService( 8663): Releasing wakelock <-- may or may not be printed

Output 4:
[here logs of 0, few are all of the registered callbacks on 'notification']

In case that helps, output of a successful open+registration (though it didn't print the console.log of my 'registration' callback …but it did run at least part of it as it updated the view with the registration-id):
V/WindowManager( 1299): Adding window Window{25f75615 u0 com.hozana.hozanaapp/com.hozana.hozanaapp.MainActivity} at 3 of 7 (before Window{eee8da0 u0 Starting com.hozana.hozanaapp
})
I/ActivityManager( 1299): Displayed com.hozana.hozanaapp/.MainActivity: +570ms (total +2m33s180ms)
D/JsMessageQueue( 8663): Set native->JS mode to OnlineEventsBridgeMode
I/chromium( 8663): [INFO:CONSOLE(1776)] "Could not find cordova.js script tag. Plugin loading may fail.", source: file:///android_asset/www/cordova.js (1776)
I/chromium( 8663): [INFO:CONSOLE(7)] "PUSH: config: init", source: file:///android_asset/www/js/NotificationHandler.js (7)
I/chromium( 8663): [INFO:CONSOLE(18)] "PUSH: config: install callback", source: file:///android_asset/www/js/NotificationHandler.js (18)
I/chromium( 8663): [INFO:CONSOLE(26)] "PUSH: config: DONE", source: file:///android_asset/www/js/NotificationHandler.js (26)
V/PushPlugin( 8663): execute: action=init
V/PushPlugin( 8663): execute: data=[{"android":{"senderID":"ZZZZZZZ"},"ios":{},"windows":{}}]
V/PushPlugin( 8663): execute: jo={"senderID":"ZZZZZZZ"}
V/PushPlugin( 8663): execute: senderID=ZZZZZZZZZ
D/GCMRegistrar( 8663): resetting backoff for com.hozana.hozanaapp
V/GCMRegistrar( 8663): Registering app com.hozana.hozanaapp of senders ZZZZZZZZZ
D/PushPlugin( 8663): no icon option
D/PushPlugin( 8663): no iconColor option
I/GCM     ( 1722): GCM config loaded
V/GCMBroadcastReceiver( 8663): onReceive: com.google.android.c2dm.intent.REGISTRATION
V/GCMBroadcastReceiver( 8663): GCM IntentService class: com.adobe.phonegap.push.GCMIntentService
V/GCMBaseIntentService( 8663): Acquiring wakelock
V/GCMBaseIntentService( 8663): Releasing wakelock
D/TaskPersister( 1299): removeObsoleteFile: deleting file=106_task.xml

Sometimes, during this phase, I see (this has always been the case even before I moved to browserify):
W/PluginManager( 8136): THREAD WARNING: exec() call to PushNotification.init blocked the main thread for 40ms. Plugin should use CordovaInterface.getThreadPool().

I already spent 2 days on this, I am more than happy to do anything that can help investigate this.
Thanks!

@behaghel any update on this?

Hi mac,
I update to the latest plugin. I am able to build my project usins ionic CLI. but when I import android project in eclipse, AndroidManifest file gives error, since application id is not populated. I know you provided push.gradle to do this task but I May be doing something wrong while importing kindly correct me.

Hi @macdonst,
Thanks for looking into it, let me resume my work on that this weekend. I
will get back to you with an update then.
--
Hubert
On Wed, Dec 9, 2015 at 7:57 AM Naveenbc<EMAIL_ADDRESS>wrote:

Hi mac,
I update to the latest plugin. I am able to build my project usins ionic
CLI. but when I import android project in eclipse, AndroidManifest file
gives error, since application id is not populated. I know you provided
push.gradle to do this task but I May be doing something wrong while
importing kindly correct me.
—
Reply to this email directly or view it on GitHub
https://github.com/phonegap/phonegap-plugin-push/issues/83#issuecomment-163144398
.

Can't reproduce anymore, closing.


the method ValidateStruct called tiwce when the field is Struct

this is one please call the ValidateStruct
if (valueField.Kind() == reflect.Struct ||
(valueField.Kind() == reflect.Ptr && valueField.Elem().Kind() == reflect.Struct)) &&
typeField.Tag.Get(tagName) != "-" {
var err error
structResult, err = ValidateStruct(valueField.Interface())
if err != nil {
errs = append(errs, err)
}
}
and then this called typeCheck method
resultField, err2 := typeCheck(valueField, typeField, val, nil)
in the typeCheck mtehod called the ValidateStruct one more time
case reflect.Struct:
return ValidateStruct(v.Interface())
i get the validate error info like this.
memory must not be null.;memory must not be null.;

Thank you for your investigation, it seems to be fixed in #330


Define xrange for Python 3

Thank you so much for your pull request. However, the branch has been updated and those lines are no longer valid.
Regards

Coverage remained the same at 89.863% when pulling c8be0af0c92fd8efdb7aa8ff83ec37b7914410c3 on cclauss:patch-1 into bb0d9fe7780467edddc04e7236f6480410437058 on astorfi:master.

Coverage remained the same at 89.863% when pulling c8be0af0c92fd8efdb7aa8ff83ec37b7914410c3 on cclauss:patch-1 into bb0d9fe7780467edddc04e7236f6480410437058 on astorfi:master.

Thank you for your modifications!

However, Please explain why you think this may change the code in a meaningful way? What advantages this may add except for the Python versioning?
Thanks

Coverage remained the same at 89.863% when pulling 0cbec8f2d033725d36d4402a75985eed3f6052ff on cclauss:patch-1 into bb0d9fe7780467edddc04e7236f6480410437058 on astorfi:master.

@astorfi Sorry that I did not reply sooner...  This change should still be made because xrange() was removed in Python 3.  https://docs.python.org/3/whatsnew/3.0.html#views-and-iterators-instead-of-lists  Given that Python 3 is now 8 years old, several operating systems are removing Python 2 and only providing Python 3 and this line will throw an exception if it is run on Python 3.
A different workaround would be:
try:
    xrange          # Python 2
except NameError:
    xrange = range  # Python 3

and other workarounds are discussed at http://python-future.org/compatible_idioms.html#lists-versus-iterators
https://stackoverflow.com/questions/135041/should-you-always-favor-xrange-over-range and https://stackoverflow.com/questions/15014310/why-is-there-no-xrange-function-in-python3 might also be of interest.

@cclauss Thank you so much for your explanations ... However, we had decided to eliminate the multiple_GPU operation in test phase ... So please advise on the parts of the code if any Python 2.x specific code is observed.
Thanks


Add test for C++ client with proxy

We need to have test for C++ client library with proxy.
This will mean to also start up a proxy instance during unit tests, same as we're starting standalone broker now.

This is fixed by #1124


Why is this API so complicated?

The complexity is just unbelievable. Why do we need to create so many types of tokens, juggling between so many different systems, each token with different kinds of expiry dates, to use in too many APIs? The amount of work to get this reliably done is just HUGE! Look at how Apple did this: they have just one API to verify the receipt with a secret password, and that's all.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a1bdee9e-2095-4423-62c5-0beb5520dfd3
Version Independent ID: fad19d6f-2fa3-ff54-925a-020fe65cadbc
Content: Manage product entitlements from a service - UWP app developer
Content Source: windows-apps-src/monetize/view-and-grant-products-from-a-service.md
Product: windows
GitHub Login: @mcleanbyron
Microsoft Alias: mcleans

Thanks for your feedback. I have forwarded it to the engineering team that owns this API.


[fastai] addressed normalization bottleneck in fastai

Description of changes:
fastai Normalize processor is not optimal: on the datasets with large number of continuous variables, it takes significant amount of time to perform normalization.

Job PR-1389-1 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1389/1/index.html

Job PR-1389-2 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1389/2/index.html

Job PR-1389-3 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1389/3/index.html

Job PR-1389-4 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1389/4/index.html

Closed in favor of #1409


User doesn't get the recording export

From<EMAIL_ADDRESS>/ Tiena Danner
Project: https://arbimon.org/p/sperlingskauz-rufphanologie/overview

first of all - this is an amazing platform, thanks for putting in the work and providing such powerful tools for free in biodiversity research!

However, I seem to be having a technical issue with exporting data from the project, i.e., I would like to download/export the data of the pattern matching results over the full project (all validated instances) from the recordings (explore --> recordings --> export --> export data). It says I should receive an e-mail with the exported data. The e-mail does not seem to come through though (it's not in the spam folder - I checked). My colleagues seem to experience the same problem.

I fixed the job on Friday, 3 report were processed by export job


Logical fallacy ToS clause addition

1. What's the name of the policy?
Github ToS
2. Is this issue related to a specific section within one of our policies (e.g. the Terms of Service)? If so, please include a link to the section or subsection.
N/A
3. Did you already open a pull request? If so, please include a link to the PR.
No
4. Sometimes it's easier to just put your feedback text into an issue. If that's how you'd prefer to contribute, this is the section to do that.
I would like to add a clause to the Github ToS that makes the use of logical fallacies in thread (discussions, issues, PRs, et al) a breach of the ToS, including (but not exclusively limited to) the list of logical fallacies found at https://en.wikipedia.org/wiki/List_of_fallacies.
5. Why do you think this section or language needs improvement?
It is not uncommon for developers and contributors to deteriorate a discussion into using irrational arguments to justify their positions with regards to bugs, feature request, improvements, and suchforth.
Debates and positions taken on either side should be subject to their own merits, standalone, and use of a logical fallacy to attempt to invalidate an opposing party's position should subsequently invalidate the position of the party that used the fallacy.
Our job as programmers is to translate human requirements into logic trees that a computer can understand, to better facilitate the use of the software between humans. If we cannot agree to block out logical fallacies, then our software projects are more likely to fail, due to human reasons rather than technical merit.

The problem here is that, quite often, people who use logical fallacies don't even know the name for what they're doing and may even think that they're making a valid argument.
While this idea is well-intentioned, it has so much potential for unintended consequences and disproportionate response that, were it to be adopted, I'd start considering a move to BitBucket or GitLab.

So, my view on this is in the mindset of "Rule #14": "do not fight with trolls, it means that they win".
By codifying banning the use of logical fallacies, it's easier to close a discussion, issue, or PR, due to breach of ToS, rather than have to spend time educating the opposing party as to why their argument is tautologically flawed. It's an easy way to avoid "Rule #14" issues on contentious topics.

The problem is that, by disallowing logical fallacies, you target the mechanism, regardless of intent.
Better to try to target the intent, regardless of mechanism, by making the against the ToS to do something such as "actively incite discord to non-constructive ends". (IANAL, so I'm sure someone more skilled could come up with a better phrasing.)

I like this improvement. Hopefully Github has lawyers that can parse this intent :-)

Hell, let's make "submitting buggy pull requests" against the ToS. Or maybe "utterly misguided issue tickets."

@codegecko By codifying banning the use of logical fallacies, it's easier to close a discussion, issue, or PR, due to breach of ToS

You can employ a Code of Conduct to your repositories, so you can close them by violation of your repository code of conduct. See the GitHub article:

Adding a code of conduct to your project

let's make it a bannable offense to be uninformed about something

I think the general consensus here is that (1) owners of individual repositories or projects are already empowered and (2) banning trolling is more intuitive and less prone to banning people we'd like to keep than banning logical fallacies.
So we either closer this and mark as already done, or we can trolling. What is the consensus if those were the only options?

Fair enough. Happy to close.


tracing: simplify tracing infra and support json output

Enable output tracing log events in a JSON format  by setting the RUST_LOG_JSON envvar.

What do the logs look like?
Also, how are fields added to the logs?

What do the logs look like?
Also, how are fields added to the logs?

You can look at the format of the output from tracings docs:
https://docs.rs/tracing-subscriber/latest/tracing_subscriber/fmt/format/struct.Json.html#example-output

Do we plan to remove open telemetry support?
I don't see problems with the PR but defer entirely to others about to best handle logs

It's not currently being used by anything that I'm aware of so I opted to remove it to clean up a large number of dependencies that were being added due to this as well as simplify our logging infra.


Saml2SecurityTokenHandler no longer throws a NullReferenceException when the Signature is missing and RequiredSignedTokens is false

Fixes #824.

:shipit: