T2

Tangrowth @ Rocky Helmet
Ability: Regenerator
EVs: 248 HP / 252 Def / 8 SpD
Relaxed Nature

Sleep Powder
Earthquake
Sludge Bomb
Giga Drain

Tyranitar @ Assault Vest
Ability: Sand Stream
EVs: 80 Atk / 176 Def / 252 SpD
Impish Nature

Stone Edge
Fire Punch
Pursuit
Superpower

Rotom-Wash @ Leftovers
Ability: Levitate
EVs: 248 HP / 252 Def / 8 Spe
Bold Nature
IVs: 0 Atk

Volt Switch
Hydro Pump
Defog
Pain Split

Alakazam @ Focus Sash
Ability: Magic Guard
EVs: 252 SpA / 4 SpD / 252 Spe
Timid Nature
IVs: 0 Atk

Psyshock
Hidden Power [Fire]
Focus Blast
Energy Ball

Conkeldurr @ Assault Vest
Ability: Guts
EVs: 36 HP / 252 Atk / 220 SpD
Adamant Nature

Drain Punch
Mach Punch
Knock Off
Ice Punch

Scizor @ Choice Band
Ability: Technician
EVs: 252 HP / 252 Atk / 4 SpD
Adamant Nature

Knock Off
Bullet Punch
U-turn
Superpower

Tangrowth @ Rocky Helmet
Ability: Regenerator
EVs: 248 HP / 252 Def / 8 SpD
Relaxed Nature

Sleep Powder
Earthquake
Sludge Bomb
Giga Drain

Tyranitar @ Assault Vest
Ability: Sand Stream
EVs: 80 Atk / 176 Def / 252 SpD
Impish Nature

Stone Edge
Fire Punch
Pursuit
Superpower

Rotom-Wash @ Leftovers
Ability: Levitate
EVs: 248 HP / 252 Def / 8 Spe
Bold Nature
IVs: 0 Atk

Volt Switch
Hydro Pump
Defog
Pain Split

Alakazam @ Focus Sash
Ability: Magic Guard
EVs: 252 SpA / 4 SpD / 252 Spe
Timid Nature
IVs: 0 Atk

Psyshock
Hidden Power [Fire]
Focus Blast
Energy Ball

Conkeldurr @ Assault Vest
Ability: Guts
EVs: 36 HP / 252 Atk / 220 SpD
Adamant Nature

Drain Punch
Mach Punch
Knock Off
Ice Punch

Scizor @ Choice Band
Ability: Technician
EVs: 252 HP / 252 Atk / 4 SpD
Adamant Nature

Knock Off
Bullet Punch
U-turn
Superpower


Child bounties comments

Only comment changes, no logic impacted.

Use uniform notion of parent and child, no "master" or "general" entity referenced.
README updated to match comments.

bot merge

bot merge


corpus: Add XtensaEB

Xtensa cores can be configured both as little as well as big endian. This adds Xtensa's big endian variant to the corpus, using permissively-licensed code compiled from https://github.com/qca/open-ath9k-htc-firmware. Detection seems to be working properly, I ran it against a proprietary firmware (not in the corpus) which I know to be for a big endian Xtensa core and it picked it up.
I'm a bit unsure if I should rename the existing Xtensa corpus to XtensaLB, maybe (to match the format of other ISAs) they should also be changed to XTENSAel and XTENSAeb. This is just the minimal change to add the new corpus.

Thanks. I merge your pull request now, and I might improve the naming in the future. But the naming is not that important...


Enable Link-Time Optimization (LTO)

Hi!
I noticed that in the Cargo.toml file Link-Time Optimization (LTO) for the project is not enabled. I suggest switching it on since it will reduce the binary size (always a good thing to have) and will likely improve the application's performance a bit.
I suggest enabling LTO only for the Release builds so as not to sacrifice the developers' experience while working on the project since LTO consumes an additional amount of time to finish the compilation routine. If you think that a regular Release build should not be affected by such a change as well, then I suggest adding an additional dist or release-lto profile where in addition to regular release optimizations LTO will also be added. Such a change simplifies life for maintainers and others interested in the project persons who want to build the most performant version of the application. Using ThinLTO should also help to reduce the build-time overhead with LTO. If we enable it on the Cargo profile level, users, who install the CLI tool with cargo install, will get the LTO-optimized version "automatically". E.g., check cargo-outdated Release profile.
Basically, it can be enabled with the following lines:
[profile.release]
lto = true

I have made quick tests (Fedora 41, Rustc 1.82) by adding lto = true to the Release profile. The binary size reduction is the following:

lyricist: from 4.8 Mib to 3.2 Mib
req (I don't think that it's important but anyway): from 1.2 Mib to 922 Kib.

Thank you.

Hi @zamazan4ik
Thank you very much for bringing this to my knowledge. I did not know about this. I have merged this into my main branch.
And I am closing this issue.


Allow Compose Preview Support to set Rules for automatically generated tests

Currently, roborazzi's Compose Preview Support automatically generates a Test file for each Preview collected by ComposablePreviewScanner. I believe that the Compose Preview Support currently automatically generates a Test file for each Preview collected by ComposablePreviewScanner. However, the automatic generation has the disadvantage that the initialization process that needs to be performed before the Test cannot be configured (e.g., see example in this article is (It may be easier to understand).
So I wondered if I could add more parameters that would allow me to set additional Rules.
roborazzi {
  generateComposePreviewRobolectricTests {
    // ...
    additionalRules = listOf(
      "com.example.myapp.SomeRule",
    )
  }
}

Currently, roborazzi's Compose Preview Support automatically generates a Test file for each Preview collected by ComposablePreviewScanner. I believe that the Compose Preview Support currently automatically generates a Test file for each Preview collected by ComposablePreviewScanner. However, the automatic generation has the disadvantage that the initialization process that needs to be performed before the Test cannot be configured (e.g., see example in this article is (It may be easier to understand).
So I wondered if I could add more parameters that would allow me to set additional Rules.

roborazzi {

  generateComposePreviewRobolectricTests {

    // ...

    additionalRules = listOf(

      "com.example.myapp.SomeRule",

    )

  }

}

Have you checked the ComposePreviewTester?
https://github.com/DeNA/android-modern-architecture-test-handson/blob/main/docs/handson/VisualRegressionTest_Preview_ComposablePreviewScanner.md#composepreviewtesterの実装
It has a testRuleFactory that looks like what you are looking for

Thanks. Yes, we have this. However, the blog in Japanese mentions that Roborazzi doesn't support @HiltAndroidTest for preview tests. I'm not sure if we need to support it, though. Anyway, if you encounter this kind of issue, please let us know by creating an issue. We’d like to understand your use cases. I'll close this issue for now.


javadoc

The javadoc should not be in the repository itself.
The readme.markdown should contain to a link to the javadoc instead.
Additionally the javadoc is very incomplete...

Always adding javadocs for new features/refactored methods, but cant to this for old ones!
Added link in readme


Multiple Data Types With AddElementsFromHDFS/SampleDataForSplitPoints

The AddElementsFromHdfs and SampleDataForSplitPoints operations allow users to specify mutliple input paths but only a single mapperGenerator.
There will be situations where we want to add multiple data types (from different hdfs directories) to a Gaffer graph. We should be able to specify pairs of input path(s) to mappergenerators.
This will also be more efficient because we will be correctly sampling from the full data range for the table split points in Accumulo. And we can consolidate multiple bulk-loads into a single job.

Merged into develop.

Migration notes
Within AddElementsFromHdfs and SampleDataForSplitPoints Input paths and MapperGenerators are now supplied as pairs, so multiple can be supplied.
Instead of using .inputPath() or inputPaths() along with a single .mapperGenerator() class name it is now possible to supply the inputPath and mapperGenerator as a pair, or map of multiple pairs.  You can do this by using addInputMapperPair(inputPath, mapperGeneratorClassName) or adding multiple as a map; addInputMapperPairs(Map<String, String> inputPath, mapperGeneratorClassName).


getInitialState support for ES6 classes

@dryganets Classes are es6

Also there's new static getDerivedStateFromProps which may handle similar case and even more handle all props updates.

Yep, I mentioned getDerivedStateFromProps.
It is static, so it is impossible to override the behavior in in subclasses.

@dryganets
class Foo extends React.Component {
  static getDerivedStateFromProps(props) {
    return { /* ... */ }
  }
}

class Bar extends Foo {
  static getDerivedStateFromProps(props) {
    const state = Foo.getDerivedStateFromProps(props)
    /* ... */
    return state
  }
}

@j-f1, this might be good enough solution.
The drawbacks are:

In this case, only static context of the class is available.
No inheritance. Need to mention exact class instead of super call everywhere

No inheritance. Need to mention exact class instead of super call everywhere

Turns out this isn’t necessary. You can use super just fine in class methods, and it executes the class method of the parent class.

Convenient, but doesn't seem all that necessary when it's only one extra line to accomplish this on your own:
state = this.getInitialState()

getInitialState() {
 // ...
}

And to fix the inheritance problem just add:
this to the state in constructor.
Later on just ignore this field of state in shouldComponentUpdate and you could access this like this:
state.this.blablabla


[Bug] Can't run test-runner on playwright's offical docker images > 1.24.2

Describe the bug
Playwright supplies docker images with browsers + deps pre-installed. These are very useful in CI.
Up to and including version 1.24.2 it works fine to run test-storybook --url [...]. Next minor 1.25.2 and all versions above produce this error:
57Error: Executable doesn't exist at /ms-playwright/chromium-1005/chrome-linux/chrome
58╔═════════════════════════════════════════════════════════════════════════╗
59║ Looks like Playwright Test or Playwright was just installed or updated. ║
60║ Please run the following command to download new browsers:              ║
61║                                                                         ║
62║     npx playwright install                                              ║
63║                                                                         ║
64║ <3 Playwright Team                                                      ║
65╚═════════════════════════════════════════════════════════════════════════╝ Failed to launch browser.

Running npx playwright install doesn't help (it's not supposed to be needed with that image for the record, the official playwright image has deps and browers pre-installed).
Steps to reproduce the behavior

Run test-storybook in playwright's docker image tagged v1.24.2-focal - Success
Run test-storybook in playwright's docker image tagged v1.25.2-focal - Failure

Expected behavior
test-storybook shouldn't pose special requirements on the playwright versions, or at least clarify what they are.
Screenshots and/or logs
[test-storybook] Detected a remote Storybook URL, running in index json mode. To disable this, run the command again with --no-index-json
57Error: Executable doesn't exist at /ms-playwright/chromium-1005/chrome-linux/chrome
58╔═════════════════════════════════════════════════════════════════════════╗
59║ Looks like Playwright Test or Playwright was just installed or updated. ║
60║ Please run the following command to download new browsers:              ║
61║                                                                         ║
62║     npx playwright install                                              ║
63║                                                                         ║
64║ <3 Playwright Team                                                      ║
65╚═════════════════════════════════════════════════════════════════════════╝ Failed to launch browser.
66    at executablePathOrDie (/builds/redacted/service/frontend/frontend/node_modules/playwright-core/lib/server/registry/index.js:297:15)
67    at Object.executablePathOrDie (/builds/redacted/service/frontend/frontend/node_modules/playwright-core/lib/server/registry/index.js:313:43)
68    at Chromium._launchProcess (/builds/redacted/service/frontend/frontend/node_modules/playwright-core/lib/server/browserType.js:204:39)
69    at async Chromium._innerLaunch (/builds/redacted/service/frontend/frontend/node_modules/playwright-core/lib/server/browserType.js:131:9)
70    at async Chromium._innerLaunchWithRetries (/builds/redacted/service/frontend/frontend/node_modules/playwright-core/lib/server/browserType.js:109:14)
71    at async ProgressController.run (/builds/redacted/service/frontend/frontend/node_modules/playwright-core/lib/server/progress.js:101:22)
72    at async Chromium.launch (/builds/redacted/service/frontend/frontend/node_modules/playwright-core/lib/server/browserType.js:84:21)
73    at async BrowserServerLauncherImpl.launchServer (/builds/redacted/service/frontend/frontend/node_modules/playwright-core/lib/browserServerImpl.js:49:21)
74    at async PlaywrightRunner.launchServer (/builds/redacted/service/frontend/frontend/node_modules/jest-playwright-preset/lib/PlaywrightRunner.js:69:44)
75    at async PlaywrightRunner.getTests (/builds/redacted/service/frontend/frontend/node_modules/jest-playwright-preset/lib/PlaywrightRunner.js:90:36)

After poking around a bit I can get it to work in some environments and not in others. Does anyone know what/where decides exactly which version of chrome it'll target? Because chromium-1005 doesn't exist in the image, but a newer version does.
So I'm guessing something somewhere is having some cache troubles. I can actually solve it via symlinking so it thinks it runs the old version, when it in fact runs the new.

The browsers are defined in a JSON file on<EMAIL_ADDRESS>and in my case if I change chromium from:
{       "name": "chromium",       "revision": "1055",       "installByDefault": true,       "browserVersion": "112.0.5615.29"     },
To:
    {       "name": "chromium",       "revision": "1064",       "installByDefault": true,       "browserVersion": "114.0.5735.35"     },
it fixes the tests.

Noticed that the issue was due PNPM or some other lock file getting an older version o Playwright.
I forced the new version via overrides and now it's working:
  "pnpm": {
    "overrides": {
      "<EMAIL_ADDRESS>"~1.34.3"
    }


[core] Fix IsKeyPressedRepeat() for PLATFORM_DRM direct input

Changes

Fixes IsKeyPressedRepeat() for PLATFORM_DRM direct input by adding the missing CORE.Input.Keyboard.keyRepeatInFrame to PollKeyboardEvents() (R1712).

Reference

Issue spotted by @larry104 at #3569#issuecomment-1832811076.

Code example
#include "raylib.h"

int main(void) {
    InitWindow(800, 450, "test");
    SetTargetFPS(60);
    while (!WindowShouldClose()) {
        BeginDrawing();
        ClearBackground(RAYWHITE);

        if (IsKeyPressedRepeat(KEY_ONE)) {
            DrawText("1 is repeat", 20, 20, 20, BLACK);
            TraceLog(LOG_INFO, "1 is repeat");
        }
        if (IsKeyPressedRepeat(KEY_TWO)) {
            DrawText("2 is repeat", 20, 40, 20, BLACK);
            TraceLog(LOG_INFO, "2 is repeat");
        }

        EndDrawing();
    }
    CloseWindow();
    return 0;
}

Environment

Tested on Raspberry Pi 3 Model B 1.2 (2015) with Linux (Raspberry Pi OS 12 Bookworm 32-bit armhf).

Edits

1: added line marks.

@ubkp thanks for the review!

I just compiled against the latest master branch but it seems the fix is not working properly. If I for instance press the down cursor sometimes it does something and sometimes not. Also the repeat interval seem randomly sometimes fast sometimes slow. As I mentioned the repeat works via ssh keyboard even when just using "IsKeyPressed" and it's super reliable.

Maybe it has to do with my app ... it seemed smoother with an ssh keyboard.
Is the IsKeyPressedRepeat supposed to detect also a single press? Or do I need something like this?
if (IsKeyPressedRepeat(KEY_UP) || IsKeyPressed(KEY_UP)) {..}


#141: Updated readme with recent changes

Fixes #141.

Great suggestion!
I created a ticket #143 not to forget it.


x/build/cmd/coordinator: doesn't seem to be reporting the right elapsed time for aix-ppc64 trybot

When I look at https://farmer.golang.org/try?commit=37ab01eb right now, at Fri 10 Apr 2020 06:48:51 PM UTC, I see
aix-ppc64 | (running) | aix-ppc64 rev 37ab01eb (trybot set for Id0c34c2); running; http://power8-aix-host1 reverse peer power8-aix-host1/<IP_ADDRESS>:52500 for host type host-aix-ppc64-osuosl, 2h37m19s ago ...
                      |   2020-04-10T16:39:15Z finish_write_go_src_tar after 5.48s
                      |   2020-04-10T16:39:15Z make_and_test
                      |    2020-04-10T16:39:15Z make src/make.bash
                      |  +7692.8s (now)

The timestamps are more than 50,000 seconds ago, not 7692 seconds ago.
Why do we see the wrong elapsed time?
And what is happening with the AIX builder?
Thanks.
CC @dmitshur

The timestamps are more than 50,000 seconds ago

Which timestamps are you referring to? The ones I see in the snippet above are from 3~ hours ago:
t, err := time.Parse(time.RFC3339, "2020-04-10T16:39:15Z")
if err != nil { panic(err) }
fmt.Println(time.Since(t))
// Output: 3h5m32.054424s

For context, aix-ppc64 is a reverse builder and there is only one instance. The coordinator was redeployed 3.5 hours ago (farmer.golang.org displays "Uptime 3h35m55s."). It seems https://farmer.golang.org/try?commit=37ab01eb was the first trybot run that picked up the aix-ppc64 builder, but the builder is stuck on:
Building Go cmd/dist using /opt/freeware/lib/golang. (go1.13 aix/ppc64)
Building Go toolchain1 using /opt/freeware/lib/golang.

Building Go toolchain2 using go_bootstrap and Go toolchain1.

It might be worth canceling that trybot run (by deleting the Run-TryBot+1 vote) and letting it try again, perhaps the next time it won't get stuck. But if that doesn't help, then there must be something up with the builder.
/cc @trex58

I'm sorry, you're right, I did misread the timestamps.  I'll close this issue.

Again, it gets stuck in the same place.
https://farmer.golang.org/try?commit=efd5d44c

Building Go cmd/dist using /opt/freeware/lib/golang. (go1.13 aix/ppc64)
Building Go toolchain1 using /opt/freeware/lib/golang.

Building Go toolchain2 using go_bootstrap and Go toolchain1.


Fix a few typos and formatting in README

I've taken the liberty of providing a few corrections to the README which I noticed while reading.

Thanks :)


Cannot import azure providers

Describe the bug
If I take the example with azure provider it looks like modules are not found.
To Reproduce
Steps to reproduce the behavior:

python -v venv myenv
source  myenv/bin/active
pip install  architectures graphviz
python arch1.py
See error

Traceback (most recent call last):
  File "arch1.py", line 4, in <module>
    from architectures.providers.azure.ai import CognitiveServices
ModuleNotFoundError: No module named 'architectures.providers.azure'

Expected behavior
Import providers
Desktop (please complete the following information):

OS:Fedora
python : Python 3.9.6 (default, Jul 16 2021, 00:00:00)
Version 34

Hi @bigg01.  Thanks for the feedback!  I was able to replicate this issue and it appears when the package is published to PyPi it does not include the provider folders.  I tested adding an init.py file to each to see if that would allow them to be discovered as packages as part of the publishing process, but that did not seem to work.
I'm in the middle of a life changing even with my second child just being born (sorry about the delayed response), but once I come off of FMLA / PTO I will look into this a bit more.

@bigg01
I was able to fix this issue and a few more so thank you so much for the input!  It is making our package better.
The major changes were:

Adding __init__.py files to each of the providers so that setuptools.find_packages() could find and ship them
Adding a MANIFEST.in file to recursively include all static content (i.e. icon png files)
Adding an __init__.py file to the icons folder so they will install when running pip install architectures
Adding the install_requires attribute to setup.py so that graphviz is automatically installed since i saw you were having to run pip install architectures graphviz

Please let me know as you test this if you come across any issues.  At this point, I was able to resolve all of the issues stated as part of release 0.2.7 and test locally with similar steps to yours.  The release number jumped up so much because I created a lot of unstable releases along the way before going to test.pypi.org for testing.
Thanks again!


Hack in branch support

Works, but kinda nasty. Would appreciate some feedback

What is the goal?

What is the goal?

I would much rather see: requires "x >= #hashX & <= #hashY | >= #hashA & <= #hashB". Then we can use tiny packages more effectively that are not tagged.

The goal was actually langserver which uses branches, so either its lockfile must be used or branches need to work https://github.com/nim-lang/langserver/blob/master/nimlangserver.nimble#L12

Branches are pretty common during development and team work as well. It's really handy to change requires "foo" to requires "foo#feature-branch" so others can work with it as well.

If desired, needs to be redone again now that we have the new dependency graph. Sorry.


Update CI testing

Thank you @Apollon77

I do such PRs from time to time whenever we have "basic" stuff ... bt nuw with adapter-core and iobroker-testing it will be not that often :-)


Add go-plugin sink to Heapster

Add Go-Plugin sink for event and metrics to help integrate "eclectic" monitoring systems without any modifications on Heapster codebase.

Cf https://github.com/hashicorp/go-plugin
Edit: Example included in docs

This change is

/ok-to-test

Is there anything i need to do to make this PR evolve?

I rebased my PR and add some cleanup on riemann metric sink tests https://github.com/kubernetes/heapster/pull/1951/commits/115411f2604b2dab7db4aa49563d735d7db0f572 (unreleated to this PR subject but cause fail on go vet)
/assign @piosz


Dependabot PRs missing secrets

Jobs kicked off by Dependabot have been failing on missing secrets.  Dependabot has its own secrets section, so with a little setup, problem solved!

Also, update docs with this info.


Child app loading twice when using internal redirect from another app

When you launch a page from the text button links on the Home page, its content appears twice, e.g.
function result (SolarMach page)
function result (SolarMach page)
This only occurs from the text button links in the center of the page, not from the links in the complex nav.

this bug has been fixed, please update to version 1.0.8 and look at example repo for more features.


Build a package to list non strict php requires

https://twitter.com/Ocramius/status/1415064387572928514

Please assign this to me, I will allocate some time to work on it

Gosh, I often think about this one @Ocramius and still intend to work on it
Can you explain my how I can access the entire composer package list ?

I suggest you look at the packagist index structure 👍

Will close here: not tracking it in this project, specifically :)

Sure, I really do not know why I can't get to writing code for this. I think about it quite often
That's strange
Anyway, to be continued

Also I am thinking we should maybe search in the source code to know if the library did commit things to have PHP 8 support for example
Not really sure how to do this correctly

3 years later and I still think about this task
A haunting ghost 😂
But I think I finally made peace with it, I have too much tasks to do already and will probably never do it

@williamdes it's fine: I have an infinite tasklist as well, and it's just the nature of our lives :-)
From my end, I think it's more valuable to invest time in moving people to Nix derivations, than to keep banging my head against poorly designed composer.json files.

@williamdes it's fine: I have an infinite tasklist as well, and it's just the nature of our lives :-)

Yeah, exactly.

From my end, I think it's more valuable to invest time in moving people to Nix derivations, than to keep banging my head against poorly designed composer.json files.

Well, maybe this list will be interesting to have when PHP 9 comes to life with its breaking changes.
If you need some help or anything around Debian/Ubuntu packaging of php tools, let me know I already maintain some of them.


Fix #823: Support virtual coordinate in mozc_renderer to fix its window position on HiDPI displays

Description
Qt6 applications use virtual coordinates. Since IBus use the device pixel coordinate system to represent a position of a pre-edit area, mozc_renderer converts it to the virtual coordinate.
Issue IDs
#823
Steps to test new behaviors (if any)
A clear and concise description about how to verify new behaviors (if any).

OS: Linux
Steps:

Enable display scaling on a desktop environment (e.g. 125%)
Start a GTK application (e.g. gedit)
Type some keys with ibus-mozc enabled and the candidate window is now shown under the cursor.

Additional context
See #823

Hi ftake,
We have been running the internal process to accept your PR.
Thank you for your contribution.

Thank you for your review comments and I'm sorry to be late. I revised the code.

We have merged your PR.
Thank you for your contribution!


Add a cache eviction policy：Evicting cache data by the slowest markDeletedPosition

Motivation
We found a problem: even if we adjusted the cache eviction size and time a lot, there would still be some misscaches when the client restarted.The corresponding configuration is as follows:
managedLedgerCacheSizeMB=40960
managedLedgerCacheEvictionTimeThresholdMillis=1800000
The current cache eviction strategy is to evict according to the read position, so there may be a miss cache when the data is pushed again.
In our scenario, there are tens of thousands of clients, and they are deployed on k8s. In order to save resources, they may dynamically expand or shrink, so that data re-pushing will happen from time to time:

Modifications
Therefore, to improve the cache hit rate , I think a new cache eviction strategy should be added: evict data according to the markdelete position.
Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?

[ ] doc-required
(If you need help on updating docs, create a doc issue)

[x] no-need-doc
(Please explain why)

[ ] doc
(If this PR contains doc changes)

@eolivelli @Technoboy-
PTAL,thanks!

@eolivelli @Technoboy-  @codelipenghui
PTAL,thanks!

Make sense, especially if you have some numbers to share.
Can you please add a test case ?
cc @merlimat @rdhabalia WDTY?

OK ,I will fix!

markDeletedPosition is better than readPosition in normal case. Maybe we can use markDeletedPosition by default.
OK, I aggree.

Make sense to me.
A test to cover this is better.

use readPosition iff overall cache usage is over some threshold (like 85%)?

In the scenario of message re-pushing, this way of dynamically adjusting the eviction policy is not suitable. I can reopen a discussion about dynamically adjusting the eviction policy later.

Make sense. IMO, markDeletedPosition is better than readPosition in normal case. Maybe we can use markDeletedPosition by default, and use readPosition iff overall cache usage is over some threshold (like 85%)?

Fixed. PTAL,thanks!


Confusing Example

The first example is extremely confusing. The variable name is identical to the setting name, plus the leading '@'.
@@@
DECLARE @CONCAT_NULL_YIELDS_NULL VARCHAR(3) = 'OFF';
IF ( (4096 & @@OPTIONS) = 4096 ) SET @CONCAT_NULL_YIELDS_NULL = 'ON';
SELECT @CONCAT_NULL_YIELDS_NULL AS CONCAT_NULL_YIELDS_NULL;
@@@
Suggest using @SAVE_SETTING for a variable name, instead of @CONCAT_NULL_YIELDS_NULL, to make it obvious what the code is doing.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2e46a55a-b416-67c1-3452-6bcd520f9177
Version Independent ID: 19cf9124-8bce-7c8e-d798-a2c73e808b34
Content: SET CONCAT_NULL_YIELDS_NULL (Transact-SQL) - SQL Server
Content Source: docs/t-sql/statements/set-concat-null-yields-null-transact-sql.md
Product: sql
Technology: t-sql
GitHub Login: @CarlRabeler
Microsoft Alias: carlrab

@deanis74  Thank you for the feedback.
The documentation has been updated and is pending review.

That reads much better.


Changes to Clearing Operations

Changed folder name to Clearing Operations tools

The last two commits are broken into Arcmap and then ArcGIS Pro.

Those files should be removed.


sap.uxap.AnchorBar indicator does not work with sections that use showTitle="false"

OpenUI5 version: 1.36.5
Browser/version (+device/version): Chrome 49 / IE 11 tested
URL (minimal example if possible):
https://plnkr.co/edit/sLaAuKpvI9qvgDmYSddM?p=preview
Steps to reproduce the problem:

Click on the links in the anchor bar to scroll to different sections of the object page
Observe the scrollspy indicator (gray line below the section link in anchor bar)

What is the expected result?
Scrollspy indicator should always update after you clicked on a section link.
What happens instead?
If section has showTitle="false", this does not work properly. See example.

Hi pgutheil,
thanks for reporting, Opened internal issue<PHONE_NUMBER> for this one.
Best Regards,
Martin

Hi pgutheil,
Thanks for reporting the issue.
The bug has been fixed and the fix will be available in the following versions:
1.38.1
1.36.7
1.34.12
Thanks again and regards,
Dimo


Travis should build more that the default test suite

refs #57

[x] refactor tox.ini
[x] add the django16 suite to the travis.yml

Could we support right now Django 1.7 and 1.8 ? It would be perfect if you can add them to tox or Travis check, thanks

@rodo, yup, it's perfectly testable. Will amend the PR

@rodo quick update: I've tested locally and it's not automagic: builds using django 1.7 or 1.8 fail. I think we'll need to work a bit more on this. I'll open a separate issue.

Ok thanks for the test, so I merge this version and look forward for other version


Sketch measure not working for sketch 52.1

Sketch measure not working for sketch 52.1 Latest Version can you please fix ASAP

I gave it a try to fix it here:
Fix for Sketch v52 and v52.1 - With Inspector / Mark Property (and more) working
You can get the file from the fork. Give it a try and see if it works for you:
Repository
Download the zip file from the fork
I hope it helps someone out there :)

But with toolbar 2.0 (Beta) does not work.

But with toolbar 2.0 (Beta) does not work.

@Mihkach: that's because the toolbar 2.0 uses the SMFramework API and the last time (9c2a5ff2d448b3849b595853621a659197e04a15) @utom updated the SMFramework, was for Sketch v50, which still uses the outdated properties and methods not available anymore for v52+. Since the toolbar 2.0 is a beta feature, it is not worth it for me to update the SMFramework in Xcode only for the toolbar 2.0.  Thanks for reporting 😉

I gave it a try to fix it here:
Fix for Sketch v52 and v52.1 - With Inspector / Mark Property (and more) working
You can get the file from the fork. Give it a try and see if it works for you:
Repository
Download the zip file from the fork
I hope it helps someone out there :)

I tried this, but there was another problem: When met the exported file with the knife icon, I find the exported html can not measure spec for each item. I have to eliminate the export records every time. That's a troublesome thing. 💔

Please note, that there are now 11 Issues that basically say the same thing: Sketch Measure is broken with the latest releases of Sketch.
Posting yet another issue saying exactly the same thing IS NOT HELPFUL. You can simply add your own experience, or frustration, by leaving a comment in one of the many existing issues.
These issues are #468, #469, #471, #472, #475, #476, #477, #479, #481, #482 and this one.
Sketch Measure developers: please review the fix from @ellunium, which might enable you to close these 11 issues at once.


Dead link replaced in README.md

GitHub Issue (If applicable): #

PR Type
What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tested code with current supported SDKs
[x] Docs have been added/updated which fit documentation template. (for bug fixes / features)
[ ] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
[ ] Wasm UI Tests are not showing unexpected any differences
[x] Contains NO breaking changes
[ ] Updated the Release Notes
[ ] Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

/azp run


fix(selection-list): highlight on lists with 1 section

Details

On lists with only 1 section, after selecting one item in the list, the next available item was being focused.
Simplified the logic to do nothing in this case.
Fixed Issues

$ https://github.com/Expensify/App/issues/25884
PROPOSAL:
Tests

[ ] Verify that no errors appear in the JS console

In Workspace -> Members (multiple-selection list with only 1 section):

[ ] Selecting or de-selecting an item should maintain the highlight in the same item

In Workspace -> Members -> Invite (multiple-selection list with multiple sections), nothing is changed. Selected items are moved to the top, and highlight goes to the first un-selected item.
Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console

In Workspace -> Members (multiple-selection list with only 1 section):

[ ] Selecting or de-selecting an item should maintain the highlight in the same item

In Workspace -> Members -> Invite (multiple-selection list with multiple sections), nothing is changed. Selected items are moved to the top, and highlight goes to the first un-selected item.
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Pinging @Santhosh-Sellavel here because he reviewed all the other SelectionList refactor PRs

Awesome, thank you @allroundexperts!
For context: Shawn said here to change to this behavior

Looks good to me, thanks!

Hey @allroundexperts, what is the expected behavior though?

I got you, this is new behavior and I don't have enough information to answer that. We'll need @shawnborton to check this

Yeah, the only highlight we want to remain is the highlight used when moving around with the arrow keys. The highlight indicates what row is active in terms of arrow navigation. And we decided that it is weird that if you check or uncheck a row that your active row would change. Basically you should not lose position of your active row as you toggle things on or off if you are using the arrow keys.
So I think @allroundexperts is right above.

@shawnborton

Basically you should not lose position of your active row as you toggle things on or off if you are using the arrow keys.

Ok, so if I understand correct, while you're navigating with the keyboard, either activating or deactivating you should never loose the active row.
The problem currently is when clicking/pressing. If I click to activate, the row should get highlighted. If I click to deactivate, the highlight should disappear.
Is that how it should behave ⬆ ?

I think that makes sense. Although, how does click to highlight work today?

@shawnborton @allroundexperts I understand the source of confunsion now. When clicking the item, it was showing an "active" highlight, same as if you were hovering it, which is not the same as the highlight for when you're moving with the arrow keys. I removed that, which fixes what @allroundexperts mentioned above, and makes it much cleaner.
Also included in the commit a fix for the Enter hotkey event, which was not working as expected when we had accessibility selection active.
Here's a video in action:
https://github.com/Expensify/App/assets/26878038/06ea4575-df3b-44b7-af7b-9edd777d27de

That looks perfect, thanks!

@allroundexperts Friendly reminder here

@allroundexperts Ok - sent fixes, please review again!

Heads up: I'll be OOO from tomorrow until Tuesday - if anything urgent comes up, someone from Callstack can continue

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.75-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.75-12 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


ScrollToTopExamples: Correct Setup section button positioning

Description
While examining the "Scroll To Top Examples" page, I spotted an inconsistency in the positioning of the button. Expected at the bottom right of Setup section container, it appeared at the bottom right of the entire page due to a CSS positioning conflict. The position attribute of the absolute class was being overridden by the .mud-scroll-to-top class.
To resolve this and avoid future issues, I strengthened the specificity of several position attributes by adding !important in the _position.scss file:
.absolute {
    position: absolute !important;
}

.fixed {
    position: fixed !important;
}

.relative {
    position: relative !important;
}

.static {
    position: static !important;
}

.sticky {
    position: sticky !important;
}

How Has This Been Tested?

Automated Testing: Ran all related unit tests, all of which passed successfully.
Manual Testing: Verified the corrected positioning and functionality of the button on the "Scroll To Top Examples" page within the designated container.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)

Visual Demonstrations
To provide clearer context:
Before the Fix:

After the Fix:

Checklist:

[x] The PR is submitted to the correct branch (dev).
[x] My code conforms to the project's code style.
[ ] I've introduced relevant tests.

Awesome! Thanks a lot!


flutter downgrades to the wrong version

We are releasing our new app but 1.20 is causing to much issues for us to release.
I want to go back from 1.20.1 to 1.17.5 but the flutter tool forces us to go back to 1.17.4 instead of 1.17.5 on the stable channel
flutter version 1.17.5 is a deprecate command so we can't use that

Have you tried doing it manually
https://flutter.dev/docs/development/tools/sdk/releases

A full reinstall? Yeah that worked. But I would expect that the downgrade command would do that for you

I have also downgraded to 1.17.5 using downgrade and version commands on windows. Are you doing this on windows?

I am using a mac. Our buildserver is a mac mini

And now our buildserver downgrades to 1.17.1 😑

Hi @vanlooverenkoen
Jus tried to reproduce, i had to install 1.17.5 -> upgraded to 1.20.1 and then flutter downgrade 1.17.5
tahatesser@Tahas-MacBook-Pro ~ % flutterp downgrade 1.17.5
Downgrade flutter to version 1.17.5
? [y|n]:

@TahaTesser
~/Documents/work(:|✔) % flutter doctor -v
[✓] Flutter (Channel stable, 1.20.1, on Mac OS X 10.15.4 19E287, locale en-BE)
    • Flutter version 1.20.1 at /Users/vanlooverenkoen/flutter
    • Framework revision 2ae34518b8 (7 days ago), 2020-08-05 19:53:19 -0700
    • Engine revision c8e3b94853
    • Dart version 2.9.0

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/vanlooverenkoen/Library/Android/sdk
    • Platform android-30, build-tools 29.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.1

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 48.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.47.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.13.2

[✓] Connected device (2 available)
    • SHIELD Android TV (mobile) • <IP_ADDRESS>:5555                   • android-arm64 • Android 9 (API 28)
    • iPhone 11 (mobile)         • 93B47E6A-8DAA-43C9-9ED8-1A3D266D3218 • ios           • com.apple.CoreSimulator.SimRuntime.iOS-13-5 (simulator)

• No issues found!
~/Documents/work(:|✔) % flutter downgrade 1.17.5
Downgrade flutter to version 1.17.4
? [y|n]:

@vanlooverenkoen flutter version is deprecated but it will still work.

Yes indeed. But I also create this ticket to make sure it will be fixed in the future.

flutter upgrade will store the current version (before upgrading) to a file .flutter_tool_state in a user's home directory. Then if you issue the command flutter downgrade, it will read that version, and then git reset the repo to that tag.
It seems either you were on version 1.17.5 issued flutter upgrade and the tool erroneously recorded 1.17.4 as the last tool version, in which case we should fix that.
Or, you were previously on version 1.17.4, and this is working as intended. Can you confirm which version you were previously on?

Hmm that sounds strange. Because on our build server we had 1.17.5
For 1 build we need to use 1.20.1 so we did a flutter upgrade.
next build we needed 1.17.5 => flutter downgrade went to 1.17.4
next build we needed 1.20.1 again => flutterr upgrade
next build we needed 1.17.5 => flutter downgrade went to 1.17.0 🤷
I have no idea why

I do think we should have a command flutter select 1.20.1 and it automaticly uses that specific version. (as flutter version did)

@vanlooverenkoen you can do flutter reset --hard 1.20.1

You mean that that is the recommended command to select a specific version?

Yes. If you don't mind having a detached HEAD, even easier is git checkout 1.20.1, which is essentially what flutter version did.

So what is the difference between flutter version 1.20.1 and  flutter reset --hard 1.20.1

So what is the difference between flutter version 1.20.1 and flutter reset --hard 1.20.1

flutter version 1.20.1 will detach your git HEAD, your channel will be reported as unknown, and you will not be able to flutter upgrade to a new version (because you're not on a channel). Maybe other things break too? This is one of the reasons we're deprecating the flutter version command.

Hi @vanlooverenkoen
Hope this answers your issue, thanks christopherfujino
Closing, as this isn't an issue with Flutter itself and depends flutter_tool_state and not take a version, it just reverts based on history. If you disagree, please write in the comments and I will reopen it.
Thank you

I think for now it is clear for me. We will do some extra testing to make sure it is doing what we expect

@vanlooverenkoen you can do flutter reset --hard 1.20.1

~/Documents/work(:|✔) % flutter reset --hard 1.20.1
Could not find a command named "reset".

Run 'flutter -h' (or 'flutter <command> -h') for available flutter commands and options.

Reset is not found

@vanlooverenkoen you can do flutter reset --hard 1.20.1

~/Documents/work(:|✔) % flutter reset --hard 1.20.1
Could not find a command named "reset".

Run 'flutter -h' (or 'flutter <command> -h') for available flutter commands and options.

@TahaTesser & @christopherfujino
Failed to use the reset command.

Sorry, I meant git reset --hard 1.20.1.

Alright. I do think flutter needs a way to select a specific version. And I would expect flutter downgrade 1.17.5 to go to the correct one. Not downgrade to a version you previously installed.
I don't think we want to be using git to make sure we have the correct version.

@TahaTesser I think this ticket should be reopened.
Because I can not find any reason why I would want to go to 1.17.4 instead of my selected version 1.17.5
For when downgrading I don't want to be using a version I previously installed. But go to the correct version.

@TahaTesser I think this ticket should be reopened and marked as a bug.
Because I can not find any reason why I would want to go to 1.17.4 instead of my selected version 1.17.5
For when downgrading I don't want to be using a version I previously installed. But go to the correct version.

flutter downgrade is working as intended. If you believe it should work in another way, please file a feature request outlining the desired behavior and the rationale. Thanks!

So to be clear the inteded behavour of flutter downgrade is to go back to a previous installed flutter version. even if you selected an other version?

So to be clear the inteded behavour of flutter downgrade is to go back to a previous installed flutter version. even if you selected an other version?

Correct, flutter downgrade does not supporting selecting an arbitrary version. From the help descriiption:
~/git$ flutter help downgrade
Downgrade Flutter to the last active version for the current channel.

Global options:
-h, --help                  Print this usage information.
-v, --verbose               Noisy logging, including all shell commands executed.
                            If used with --help, shows hidden options.
-d, --device-id             Target device id or name (prefixes allowed).
    --version               Reports the version of this tool.
    --suppress-analytics    Suppress analytics reporting when this command runs.
    --packages              Path to your ".packages" file.
                            (required, since the current directory does not contain a ".packages" file)

Usage: flutter downgrade [arguments]
-h, --help    Print this usage information.

5k+error


Allowing markup with code examples?  Alas, no.

I've come to the conclusion that it is impossible to generically allow markup inside code blocks that have syntax highlighting.
I'll try to explain why:

Syntax highlighting depends on being able to compile a given piece of source code.
Code with markup inside of it is not valid source code, so the markup needs to be removed before the code ca be compiled and syntax highlighted.
Removing the markup makes it impossible to trace back where the additional handling for the markup needs to take place, except for the original content of the markup.

My current implementation depends on being able to find the original content.  However, since the markup has no relation with the AST, and thus with the syntax highlighting, it is very likely it cannot be found, so the markup handling / substitution can not be applied.
When I originally implemented this, I tested without active highlighting, and without recursive markup.  An example:
mB<y> $a V<=> 42;

would be perfectly legal markup.  The markup would be removed, the code compiled and syntax highlighted`, and we'd get with HTML highlighting:
my $a = 42;

Now, for the V<> handling, it would look for the first "=" in the result (as the markup was around the first = in the source), and then does the substitution { "<V>" ~ .atoms ~ "</V>" }
<span style<V>=</V>"color:magenta;">my $a = 42;

instead of:
my $a <V>=</V> 42;

It gets worse with the mB<y> case.  And even worse still with recursive markup.
I've now spent about a week on this, and I don't see a solution.  And restricting markup to entities matching the AST, is not a solution either, as you can't really tell from the code how the AST will be built, or can we guarantee that that will always stay the same.
So I think we either need to disallow markup in code blocks altogether, or that specification of :allow implies :!syntax-highlighting.  In which case source code should be treated as documentation (which basically means a no-op, as any renderer will have already got the AST for that).

@coke @finanalyst @thoughtstream
Comments?  Am I missing something that would allow markup and syntax highlighting?

@thoughtstream,  @lizmat has unfortunately come to the conclusion I arrived at quite a long time ago - that :allow and highlighting are generally incompatible. I was sincerely hoping to be found wrong, and Liz has found a way to get some partial resolution. But not a generic solution.
I have found it very difficult to handle :allow type options when an external highlighter is used for other languages, such as Haskell or Python.
However, the specification does permit the renderer to choose how to resolve a conflict when both :allow and :lang are given.
So, I think I shall adopt @lizmat's suggestion for Rakuast::RakuDoc::Render, namely that :allow implies :!syntax-highighting.
@coke, FWIW, there are only four sources in docs that contain :allow apart from the two (three)  documents that specify :allow. @cfa (I think) removed :allow markup from most of the other sources about a year and a half aog.
Here is the output from rak in my local docs, which contains a symlink to rakudoc.rakudoc source:
$ rak ':allow' . --files-with-matches
Language/pod.rakudoc
Language/operators.rakudoc
Language/rakudoc.rakudoc
Language/quoting.rakudoc
Language/create-cli.rakudoc
Language/modules.rakudoc
Type/RakuAST/Doc/Block.rakudoc

I agree that it seems impossible to annotate the AST of a =code block with mark-up.
Because the structure of a mark-up block need not align with the syntactic structure
of the contained code (or even with its lexical structure).
In my view, being able to deliberately and explicitly highlight the important parts
of a code block with B<> or I<> is extremely important, whereas being able
to have code auto-syntax-coloured is merely "nice to have" (for some people).
Being able to explicitly highlight specific parts of a code block enables an author
to focus their readers' attention on the key point of the code sample.
So :allow is a vital tool for effective communication in technical writing.
But having explicitly highlighted code also be syntax-coloured actually
undermines the goal of focusing the readers' attention, because
syntax-colouring injects a vast amount of distracting visual noise into the code
(which, of course, is my personal opinion of all syntax-colouring...even when
the code isn't being deliberately highlighted via mark-up! ;-)
Hence, I have no problem with us specifying that a renderer may treat
:allow and :syntax-highlightingas being mutually exclusive.
And that a renderer may assume that :allow implies :!syntax-highlighting.
However, I don't think it's necessary to specify that :allow
and :syntax-highlighting must always be treated as mutually exclusive.
Or that a renderer must ensure that :allow implies :!syntax-highlighting.
After all, someone might  eventually find a way to accommodate
simultaneuous explicit markup and automatic syntax-colouring.
And there's no need for us to forbid them from providing both, if they can.
Damian

@thoughtstream @lizmat It seems to me that we are all in agreement here in principle. Would you please look at the current document to ensure that the text does in fact clearly convey this agreement?

@thoughtstream A bit of a mix-up on my end. I saw that Liz had approved the PR, and for some reason thought it had been merged. So I did not differentiate between the PR and the current document. My mistake.
I have just reviewed the new text including the PR and I think that it reflects this thread correctly. So I am merging it.
Closing this issue as resolved

No worries, @finanalyst.
I'm just happy the issue is resolved.


Example code for gettings started with library

Added example code for getting started with using types,  load and store with libsimdpp.

Thanks for this! I couldn't have figured out this library without your example.


feat: Support point operation in pointcloud annotation

1.fix bugs during switching annotation tools
2.totally support adding and editing point annotation in pointcloud view

:tada: This PR is included in version 1.0.0 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


Modify build_visit to support Ubuntu 20.

We should update build_visit to support Ubuntu 20. Matt tried it on Ubuntu 20 and build_visit failed to apply a patch for Qt, so that is at least one issue.

Would you also be able to provide pre-built executables for Ubuntu 20.04 (as for older Ubuntu versions)?
Both the Ubuntu19 and Ubuntu18 versions of VisIt 3.1.2 do not work due to the following error which occurs when launching the gui.
/usr/local/visit/3.1.2/linux-x86_64/bin/gui: error while loading shared libraries: libicui18n.so.xx: cannot open shared object file: No such file or directory

where xx is 60 for the Ubuntu18 version and 63 for the Ubuntu19 version. Surprisingly an Ubuntu18 version of VisIt 3.0.1 that I installed before upgrading to Ubuntu 20.04 from 18.04 still seems to work fine!

Yes, I plan to modify build_visit for ubuntu 20 and then provide a pre-built ubuntu 20 version. I should have it ready by early to mid next week.

I made a pre-built version available at:
https://github.com/visit-dav/visit/releases
under the 3.1.2 release.

Thanks. I have just installed it and it seems to work fine for me.

Awesome! Thanks for the feedback.


Can't run getting_started.py of KerasNLP

Issue Type
Bug
Source
binary
Keras Version
3.5.0
Custom Code
No
OS Platform and Distribution
Linux Ubuntu v22.04
Python version
3.10.12
GPU model and memory
No response
Current Behavior?
Can't run getting_started.py since the following exception occurred.
raise errors.NotFoundError(
tensorflow.python.framework.errors_impl.NotFoundError: Could not find directory aclImdb/train
Standalone code to reproduce the issue or tutorial link
You can reproduce this issue by the following procedures.
1. wget https://github.com/keras-team/keras-io/blob/master/guides/keras_nlp/getting_started.py
2. Modifying os.environ["KERAS_BACKEND"] = "tensorflow"
3. python3 getting_started.py

Relevant log output
python3 getting_started.py
2024-08-27 09:51:31.822249: I tensorflow/core/util/port.cc:153] oneDNN custom operations are on. You may see slightly different numerical results due to floating-point round-off errors from different computation orders. To turn them off, set the environment variable `TF_ENABLE_ONEDNN_OPTS=0`.
2024-08-27 09:51:31.866790: I external/local_xla/xla/tsl/cuda/cudart_stub.cc:32] Could not find cuda drivers on your machine, GPU will not be used.
2024-08-27 09:51:32.213257: I external/local_xla/xla/tsl/cuda/cudart_stub.cc:32] Could not find cuda drivers on your machine, GPU will not be used.
2024-08-27 09:51:32.580303: E external/local_xla/xla/stream_executor/cuda/cuda_fft.cc:485] Unable to register cuFFT factory: Attempting to register factory for plugin cuFFT when one has already been registered
2024-08-27 09:51:32.865270: E external/local_xla/xla/stream_executor/cuda/cuda_dnn.cc:8454] Unable to register cuDNN factory: Attempting to register factory for plugin cuDNN when one has already been registered
2024-08-27 09:51:32.948846: E external/local_xla/xla/stream_executor/cuda/cuda_blas.cc:1452] Unable to register cuBLAS factory: Attempting to register factory for plugin cuBLAS when one has already been registered
2024-08-27 09:51:33.527574: I tensorflow/core/platform/cpu_feature_guard.cc:210] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations.
To enable the following instructions: AVX2 AVX512F AVX512_VNNI FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags.
2024-08-27 09:51:36.060021: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT
Traceback (most recent call last):
  File "/home/andyueng/samba/workspace_Python/TensorFlow/KerasNLP/getting_started.py", line 128, in <module>
    imdb_train = keras.utils.text_dataset_from_directory(
  File "/home/andyueng/.local/lib/python3.10/site-packages/keras/src/utils/text_dataset_utils.py", line 149, in text_dataset_from_directory
    file_paths, labels, class_names = dataset_utils.index_directory(
  File "/home/andyueng/.local/lib/python3.10/site-packages/keras/src/utils/dataset_utils.py", line 530, in index_directory
    for subdir in sorted(tf.io.gfile.listdir(directory)):
  File "/home/andyueng/.local/lib/python3.10/site-packages/tensorflow/python/lib/io/file_io.py", line 768, in list_directory_v2
    raise errors.NotFoundError(
tensorflow.python.framework.errors_impl.NotFoundError: Could not find directory aclImdb/train

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."


fix: avoid double-clicking and disable the save/create button during lock time

Issue
CP from https://github.com/gravitee-io/gravitee-ui-particles/pull/411
Description
A small description of what you did in that PR.
Additional context

🧪  Gravitee.io Automatic Prerelease @gravitee/ui-schematics
npm install<EMAIL_ADDRESS>
yarn add<EMAIL_ADDRESS>

🧪  Gravitee.io Automatic Prerelease @gravitee/ui-particles-angular
npm install<EMAIL_ADDRESS>
yarn add<EMAIL_ADDRESS>

🧪  Gravitee.io Automatic Prerelease @gravitee/ui-policy-studio-angular
npm install<EMAIL_ADDRESS>
yarn add<EMAIL_ADDRESS>

📚  View the storybook of this branch here

:tada: This PR is included in version 12.21.1 :tada:
The release is available on:

npm package (@latest dist-tag)
npm package (@latest dist-tag)
npm package (@latest dist-tag)
npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add funtionality to allow Non-technical people to add more people or request updates without writing code

We need to be able to add a form on the platform that allows users to send in new data and missing people without the need to write code. This allows us to be able to crowdsource more data and real-time data for missing people.

@Slam256 has expressed interest in picking this up

This is crucial to the site though I had a couple of reservations/ questions. This change might/will be an additional layer of verification to address potential issues such as:

Duplication of entries
Validation of the submitted entries (almost similar to above)
Prevent malicious actors from spamming the platform with incorrect information.

Additionally, we need to define the specific data required for submission, including mandatory fields and optional data points.
Finally, we should evaluate the implications of this functionality on our current website implementation. What adjustments or enhancements will be necessary to integrate this feature seamlessly?

interesting questions raised here

Someone can create a google form where to allow non technical users to submit data

How can that be connected to adding the data to the "wall", we need to automatic the process

The public can be given a form to submit data regarding missing persons.
we would to add authentication for approved users to be able to verify the records entered by the public.
a dashboard or an excel sheet would be used to look through the data.
This process can't be fully automated (unless by AI that we need ti train) because we need. to verify the data entered by users, never trust a user.

@Musacoli  I think we can proceed to close this.

Shouldn't we first wait for the API implementation to be completed

This is being tested. We'll mark it as closed after we've finished testing and moving over to the new implementation.

We've a new way where authorised and authenticated users can add more people and update the data.


Updated regex for image urls to unclude query params.

This closes #55 Better image regex by @mouradhamoud

Hi @robman87 , I have sent you an invite for collaborator. If you are fine with it, you can accept it or else just ignore. I will really appreciate some help on this module. 😄

Thank you @ritz078, I gladly accept your invitation :)


Document a workflow for editing JupyterBook within JupyterLab

Base on my explorations of #17, I have a the framework for how I think editing a JupyterBook within a JupyterLab environment could work.
To complete this task

[x] #22
[x] Create a repo2docker based image with JupyterBook , git extension, and myst jupyterlab extensions
[x] Write up new documentation within the Community Showcase Handbook (@jnywong)
[x] Test this documentation by making an edit to the Community Showcase Handbook (@colliand)

I like that #22 is completed and love the loom video! When will the editing workflow be documented and available for testing? I'd like to use it and integrate into various grant-funded projects.

I agree that the loom video was very instructive to familiarise myself with this workflow! I've tested this on the Community Showcase Hub and currently using this workflow to develop the technical content there to onboard Hub Champions (e.g. see GH comment here)

There are two paths to pursue here when it comes to authoring/editing JupyterBooks.

Document the already working JupyterBook tooling available to support in-JupyterLab authoring/editing of JupyterBooks (using sphinx)
Resolve https://github.com/executablebooks/mystmd/issues/302 to support in-JupyterLab authoring/editing of JupyterBooks (using myst start)

Giving that there is already a established set of JupyterBooks out there, it makes sense to me that we fully document using the existing JupyterBook tooling a processing for editing JupyterBooks with the sphinx tooling.
I will create a new separate issue for a myst based workflow.

@jnywong Would you add a new section to the Community Showcase Handbook something like
'Sharing your content with JupyterBook'
and then add a specific page that documents the workflow for editing an existing JupyterBook from a git repo within the Community Showcase JupyterHub.  The content could follow what I demo'd in that loom video or whatever workflow that has evolved from that this that you are using to author/edit JupyterBook content.
Once @jnywong  has this process documented and available on https://2i2c.org/community-showcase , @colliand should test that workflow and provide feedback.

Also related https://github.com/2i2c-org/community-showcase/pull/63

I'm going to consider this work as completed in this sprint, but feel free to re-open if you feel otherwise.


profile image not displaying when deployed to website

Hi! Thanks for this amazing academic website.
I am having trouble displaying the profile image.
The website can be built and deployed successfully, but the profile image of "about" just displays "named_by_me.jpg", not the context of the picture.
Meanwhile, there were no problems when compiling locally, the web looks perfectly normal.
I am not able to understand the error; could someone please help.
system: windows 11 with docker desktop.
Thanks

Going on like this.

If it is working locally, maybe you forgot to add the image on the server?

@george-gca I have pushed the changes to the forked repository. Am I missing some steps?

having same issue with project images

oka figured it out!
Do not put the relative path of the image.
Only simply put the direct image name.

okay figured it out.
The solution was just to change format of images into .jpg

@swaradgat19 is it working?

@george-gca Yes it is working. My base URL was incorrect

what is the baseurl in the config yml


Spectum download timeout on Travis CI.

With all the proposed refactorings it would be good it the continuous integration (Travis CI) worked.
Currently, it times out trying to download the PHOENIX-ACES spectra so the tests never run.
A hack I used for my project was to save the required spectra to Dropbox and download it from Dropbox. I am sure there should be a better way though.

The tests will definitely be rewritten as we go through some of the overhaul (#103). In some sense, it might be worth removing all failing tests from the CI. However, it's weird that the wget always times out. I have 3 grad apps due tomorrow but I can investigate the tests over the weekend and trying to get a more stable baseline to build from for moving forward.

Haha it's good to prioritize grad apps!
Related to the timeout issue, it isn't great that we ping the Goettingen servers every time we run CI (but then again, it is a server and we are testing the integration with it, and only 27 spectra at that).
A public dropbox link or a google drive link might be a good solution. Zenodo might work here too. Thanks for the suggestion.
Also, I agree the tests will need to be built back up. They should reflect the changes to the API and could use to be quite a bit more thorough then they are now. As the overhaul is progressing, I think it makes sense to start the tests over from scratch, focusing on unit tests that we can make pass as we implement the API. Then it probably makes sense to focus on a few more functional tests.

So After speaking with Travis CI support it turns out their backend does not support FTP for security reasons
https://blog.travis-ci.com/2018-07-23-the-tale-of-ftp-at-travis-ci
I'm going to see if there is another method of reaching the PHOENIX libraries without adding a python dependency.

Tim Hussar very graciously added a reverse proxy to his server so that all of the PHOENIX models can be accessed via HTTP. The URLs looks like http://phoenix.astro.physik.uni-goettingen.de/data/HiResFITS/PHOENIX-ACES-AGSS-COND-2011/... now. (notice the extra 'data/' directory). I have removed the skips for the tests in tests/test_grid_tools.py and have confirmed that Travis is working properly with them. I have also made sure Travis caches these files to not only limit strain on the Gottinghem server but also to increase the speed of our CI tests.

Fantastic on both accounts, thanks!


fix(quantic): hide timeframe facet when results do not match the specified timeframes

https://coveord.atlassian.net/browse/SFINT-4253
This PR fixes a visibility corner case with the timeframe facet.
Suppose you have a timeframe facet (without with-date-picker):

and search results are returned
but no search results are matching the timeframes declared on the facet

Since an end user can't use the facet to refine the search results, it should be hidden.
On the other hand, when with-date-picker is specified, the facet should remain visible because an end user could still use it to refine the search results.

LGTM but that intercepting function might be useful for future facet tests so could maybe go in page-objects/search.ts

The function is quite coupled with the timeframe facet tests. But yes, we could eventually have functions similar to this one that could be shared between the test suites.


BUG: pytest register_assert_rewrites of internal modules

Otherwise, import scipy_doctest emits obscure warnings from pytest on reimports.

This is needed for https://github.com/scipy/scipy/pull/21017 which intends to (partially) fix https://github.com/scipy/scipy/issues/20960 . Am going to merge and cut the 1.3 release quickly to unblock the scipy issue.
I checked locally that scipy, numpy and pywavelets seem to be OK with this.


Quit to Project List shortcut wrong for macOS

Godot version
4.0.dev
System information
macOS 12.3 macbook air m1 2020 base specs
Issue description

Quit to Project List shortcut says "Shift+Alt+Q" but I don't have an Alt key. Cmd+Shift+Q log me out of my mac. Cmd+Ctrl+Q locks my mac. Cmd+Option+Q does nothing.
Relevant code is:
https://github.com/godotengine/godot/blob/master/editor/editor_node.cpp#L6624
Both
ED_SHORTCUT_AND_COMMAND("editor/quit_to_project_list", TTR("Quit to Project List"), KeyModifierMask::CMD + KeyModifierMask::SHIFT + Key::Q);

and
ED_SHORTCUT_OVERRIDE("editor/quit_to_project_list", "macos", KeyModifierMask::SHIFT + KeyModifierMask::ALT + Key::Q);

Cmd+Option+Q seems like a possible option instead.
I could make the PR
Steps to reproduce
Have macOS.
Use Godot.
Minimal reproduction project
No response

Did you mean to close this?


is_alpha different for char and u8

The return values for is_alpha for char and u8 are different. For u8 it`s implemented in nom as
fn is_alpha(self)    -> bool {
  (*self >= 0x41 && *self <= 0x5A) || (*self >= 0x61 && *self <= 0x7A)
}

and for char
fn is_alpha(self)    -> bool { self.is_alphabetic() }

which uses the std library function is_alphabetic for char. But this will also return true for non-Latin characters (see here), which is not true for the nom function is_alpha for u8.

this is coherent with the way chars work. Most formats have specific needs for their basic tokens, and they can't all be supported in nom.


How to make SWRevealViewController works like covering the main view not as default pushing the main view ?

Is there any parameter in the class I can modify to make that happen ?

Use right view controller as front and front view controller as menu

https://github.com/iDevelopper/PBRevealViewController

Thanks but it sounds another library ?

Yes, 1. is the solution with SWRevealViewController, 2. is the solution with another library.

Good, but what exactly should I do with the storyboard
I have this:

the segue from Reavel View Controller to menu is (sw_rear).
the segue from Reavel View Controller to Home is (sw_front).

what should I change ?

With SWRevealViewController?

yes

sw_front from Reveal View Controller to menu.
sw_right from Reveal View Controller to home.

forgive me, but I should explain more:
I want Menu VC to cover Home VC and the configuration right now is :

the segue from Reavel View Controller to menu is (sw_rear).
the segue from Reavel View Controller to Home is (sw_front).

with these configuration Menu push the Home when I make gesture or tap the button of menu
when I make your changes I got the Menu as the landing view and if I go to Home from the menu I cant go back by the gesture.

You have to check some parameters like rightViewRevealWidth, rightViewRevealOverdraw etc...
And add the reveal pan gesture to the reveal controller view.
This is a bit complicated and I recommend to switch to the other library witch is very similar.

Oh, thanks for helping

thanks a lot, and by the way your PBRevealViewController is awesome.


[Element Move Unit] Doesnt work well in Instances

Move Unit will often cause units to move to the middle of the map when used in an instance.

BeardLib issue


Login error

What steps will reproduce the problem?
I go to the freeflowpages website, click on login via IYO, insert my email and password, and then get a warning message and I cannot login.
What is the expected result?
Login without warning.
What do you get instead?

Additional info

Q
A

HumHub version
1.?

PHP version

Operating system

Note: Please use the community site for any questions on customizing HumHub.
Note: Also provide the full error stacks from Administration --> Information --> Logging and errors from your browser console if possible.

works now


pip install doesn't work

when use pip install dblp
report an error
Collecting dblp
Using cached dblp-0.1.0.tar.gz (3.3 kB)
Preparing metadata (setup.py) ... error
error: subprocess-exited-with-error
× python setup.py egg_info did not run successfully.
│ exit code: 1
╰─> [6 lines of output]
Traceback (most recent call last):
File "", line 2, in
File "", line 34, in
File "/tmp/pip-install-f4zi1g3d/dblp_bb60d643fe3c44fb91aa69fc47bef1fa/setup.py", line 12, in
long_description=open('README.md').read(),
FileNotFoundError: [Errno 2] No such file or directory: 'README.md'
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed
× Encountered error while generating package metadata.
╰─> See above for output.
note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

Seems that pip install dblp does not install this library. (See: https://pypi.org/project/dblp/)
This library may not have published to pip.

Thank you for bringing this issue to my attention. The dblp repository is intended as a tool script and was not designed for distribution via PyPI. The error occurs because the package metadata is not set up for a proper PyPI release. To resolve this, you can clone the repository directly and use it manually.


Cannot build Python C extensions on windows-2022

Description
When we try to build Python C extensions on windows-2022, the build fails see GitHub Actions log with the following error message:

error: Microsoft Visual C++ 14.0 or greater is required. Get it with "Microsoft C++ Build Tools": https://visualstudio.microsoft.com/visual-cpp-build-tools/
221

This worked on windows-2019. We noticed it because windows-latest just bumped to windows-2022.
Virtual environments affected

[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[ ] macOS 10.15
[ ] macOS 11
[ ] Windows Server 2016
[ ] Windows Server 2019
[X] Windows Server 2022

Image version and build link
20220220.1
Is it regression?
No response
Expected behavior
The Python C extension should be built without errors.
Actual behavior
The build fails with the error message noted above.
Repro steps
Build any Python C extension. See https://github.com/astropy/pytest-doctestplus/blob/main/.github/workflows/python-tests.yml

@lpsinger thanks, we will take a look!

@dsame this issue looks similar to https://github.com/actions/virtual-environments/issues/5125 which you are looking at. Could you please confirm?

@lpsinger could you please share the simple project/yml which allows to reproduce the issue in case it's still actual?

@lpsinger this yml doesn't work for me without additional steps: https://github.com/nikolai-frolov/image-testing/actions/runs/1910180528. Please provide a simple example.

See https://github.com/lpsinger/github-actions-windows-2022-python-c-extension. This is as simple as I can make it.

Given the number of issues linked, not sure if "It is a tox issue" applies in all cases but at least, for the minimal reproducer shared by @lpsinger, it is https://github.com/tox-dev/tox/issues/2382.
Installing tox from main solves the issue: https://github.com/mayeut/github-actions-windows-2022-python-c-extension/runs/5799864485?check_suite_focus=true

Speaking for astropy/pytest-doctestplus (source of the original post), it is undesirable for us to be using dev tox but we'll be happy to try this tox fix out once it is released. Thanks!

Hello @lpsinger,
Can you please try to re-run you build with windows-latests without other changes?
I forked and reverted your repo to the failed commit https://github.com/astropy/pytest-doctestplus/commit/feea9835dd345d2efc9907a4be9f92b0fbe37289
and the build passed https://github.com/akv-platform/pytest-doctestplus/actions/runs/2149804973
also i run the build the repo head and it passed as well https://github.com/akv-platform/pytest-doctestplus/runs/5975846421?check_suite_focus=true
JFI: i suspected there's some issue with the tox could not find build tools due to something related to this setting https://docs.python.org/3/distutils/apiref.html#module-distutils.msvccompiler but i am not able to investigate the problem because it is reproduced not.

Working again now. Thanks!


added function

new function added to obtain thorax values from from c3d files

plz black the files ;)

Did you corrected all the gravity vector in every .bioMod #6 ?
Also could you rename .biomod into .bioMod ?

Can you push the new .c3d files ? #7

I think the function you created is related to #8

@thasaarah black your code, add the c3d, and I'll merge this :+1:


Improve documentation of Pass3bVerifier

This pull request adds some missing documentation to Pass3bVerifier.
It also corrects some indentation.

@garydgregory I made the changes you requested, both where you pointed them out and elsewhere.
This is ready for you to take another look.


Reorganize tests to support many

There were a few tasks that needed to be done to support running many
tests. First, I created a folder structure wherein new tests can be
added for hooks and plugins. Second, I updated the .travis.yml file to
reflect the new change. Specifically, the file now uses the Test
Discovery feature of the unittest module.
Closes #9.

Taeber, due to the encrypted credentials accessible only to the the CTSIT user, the Travis tests cannot run to completion.  Could you add your 9-add-test-suite branch to the https://github.com/ctsit/redcap-extras repo?  This should allow travis to run the tests and verify they are self-consistent.
Thanks,
Philip


Change early return for clear session only if current state is alread…

…y logged out
Scope of change
Right now as described in the issue https://github.com/nhost/nhost-dart/issues/32, if the refresh token expires then when the Auth is initialized, it is in AuthenticationState.inProgress state and since the refresh token is expired, the package tries to log the user out so that they can be logged in back which would generate a new refresh token. However due to the false early return condition the user doesn't fully get logged out, since the session is not clear and refresh token is not deleted from the local storage. This pr is to fix that and only do early return if the user already has been logged out before.
Testing
Unfortunately most of the authentication  tests of this package are more integration tests than unit tests. Ideally i would like to be able to mock out the dependencies of Auth like authStore, session, httpClient, etc and make sure in unit tests that the correct methods of those dependencies are called. For example in this case make sure that session.clear is called and authStore.remove is called if the auth state is not loggedOut. However such tests do not exist right now.

@shyndman this could be a potential fix for the issue https://github.com/nhost/nhost-dart/issues/32. Additionally i have observed some limitations of the test above. Would like to know what you think. I can even look into create those kind of tests for Auth if we decide on it.

lg. Just fix that nit and I'll merge. Thanks!

Also, you make a good point on testing. httpClient can currently be overridden (which is how the integration tests work), but perhaps more should be exposed.

lg. Just fix that nit and I'll merge. Thanks!

Updated.

Also, you make a good point on testing. httpClient can currently be overridden via NhostClient(httpClientOverride:) (which is how the integration tests work), but perhaps more should be exposed.

Okay if you agree and want, I can try to take a look at those when i get some time. It would be helpful as this package matures to have more unit testing in addition to integration tests.


Any plans for AdminLTE run fully locally?

Hi! After a little research in the Issues list, I found that some users requested, or would like to see, AdminLTE run on localhost, without internet.
I found this same problem trying to run AdminLTE on a environment filled with firewall rules, which blocked the download of the following plugins/css/extensions:

https://maxcdn.bootstrapcdn.com/font-awesome/4.3.0/css/font-awesome.min.css
https://code.ionicframework.com/ionicons/2.0.1/css/ionicons.min.css
http://cdnjs.cloudflare.com/ajax/libs/raphael/2.1.0/raphael-min.js
https://cdnjs.cloudflare.com/ajax/libs/moment.js/2.10.2/moment.min.js

Is there any plan about running AdminLTE without downloading external dependencies?
Download them all manually and change AdminLTE.css is a workaround, but when an AdminLTE update comes, it will override these changes.
These are the issues I found about this topic: #290 #48 #301 #162 #133
Best regards,
Rafael.

Rafael,
Just my two cents; But I would agree that the bower.json file should be updated to include the dependency's; Beyond that the files included should only be used as templates for coding your own pages.
As such; the links to the CDN are simply a way for the author to minimize the package size and allow 99% of users who don't have firewall issues to instantly view the examples. And to include those dependency's in the package itself would be overkill; especially for people that use multiple packages. Image if every package owner included all required dependency's in their package; you would end up with tens of copies of jquery.min.js
Running:
bower install raphael moment ionicons font-awesome jquery jquery-ui adminlte -S
cp bower_components/adminlte/pages ./
cp bower_components/adminlte/*.html ./

Should get you started; From there yes you'll have to replace the CDN links but it won't break on update unless the HTML gets changed. Running bower update will then allow you update all the packages and dependency's without downloading everything multiple times just because one package got updated.
To replace the CDN links look at using sed. The example below won't work past the index page unless you are running a local webserver; but should give you the idea.
sed 's,https://maxcdn.bootstrapcdn.com/font-awesome/4.3.0/css/font-awesome.min.css,./bower_components/font-awesome/css/font-awesome.min.css,g'
sed 's,https://code.ionicframework.com/ionicons/2.0.1/css/ionicons.min.css,./bower_components/ionicons/css/ionicons.min.css,g'

Hello Will!
Using bower and sed as you said could solve this problem, I'll try that.
I hope your contribution can be made into a future AdminLTE release, so those who need a complete offline instalation can use an out-of-the-box solution.
Thanks for the reply,
Rafael.


Package and dependents broken by localStorage when sandboxed

I happened to be on requirebin and required nanobus, and it is broken with the following error:
node_modules/nanotiming/index.js:9 Uncaught DOMException: Failed to read the 'localStorage' property from 'Window': The document is sandboxed and lacks the 'allow-same-origin' flag.
How do you feel about having a try/catch around the localStorage access?

Oh oops, yeah that'd be good. PR welcome! :D
On Sun, Jul 2, 2017, 15:23 Johnny Hauser<EMAIL_ADDRESS>wrote:

I happened to be on requirebin and required nanobus, and it is broken
with the following error:
node_modules/nanotiming/index.js:9 Uncaught DOMException: Failed to read
the 'localStorage' property from 'Window': The document is sandboxed and
lacks the 'allow-same-origin' flag.
How do you feel about having a try/catch around the localStorage access?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/yoshuawuyts/nanotiming/issues/6, or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWles3sukSIV5KurI8ncI0uGVpVn-5Bks5sJ5nlgaJpZM4OLlS-
.


Modify LPFi token list

I'm submitting a ...
[ ] bug report
[ X ] feature request
[ ] question about the decisions made in the repository
[ ] question about how to use this project

Summary
Updated LPFi token logo, changed mint address, PR: https://github.com/solana-labs/token-list/pull/25641

Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

Need to pull manual

Why don't you make PR?

Hi, @kise999
We made PR but it has automerge-error.
Can you please do merge manually from your side? thank you.


⚠ Bofrost.com has degraded performance

In 4ee37be, Bofrost.com (https://www.bofrost.com) experienced degraded performance:

HTTP code: 200
Response time: 2099 ms

Resolved: Bofrost.com performance has improved in 9be7117 after 9 minutes.


Would like title to be a render prop

Desired Behavior
either via the title prop, or an options prop, there should be a prop I can use to render a component instead of just the string title.
Current Behavior
Only a string is available to use for the title

Also with a little guidance id be willing to submit a PR

I believe this is existing behavior. This works for me.
const title = (
  <React.Fragment>
    <Tooltip title="Add Something">
      <Button variant="fab" mini color="primary" >
        <AddIcon />
      </Button>
    </Tooltip>
  </React.Fragment>
)
return (
  <MUIDataTable
    title={title}
    data={data}
    columns={columns}
    options={options}
  />
);

@psdao1102 I concur with @rcfish, the functionality already exists. The code does not currently favor strings over components; either will work: https://github.com/gregnb/mui-datatables/blob/master/src/components/TableToolbar.js#L150.


Update android cordova plugin

@Mr-Leshiy
Feedback from the app team:

The chain-wallet-libs dependency that Alex shared with us is working good though! Doing some final tests, hoping it will be >finished this week.

Let's wait for the final checks and merge!


Added LocalMassDeleteFileDeleteThreshold policy to use-group-policy.md

https://github.com/MicrosoftDocs/OfficeDocs-SharePoint/issues/1823

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@kaarins PR has been copyedited and is ready for final review, could you please check and merge? Thanks!