Allow all instance labels in target groups

With the blackbox exporter, the instance label will commonly
be used for things other than hostnames so remove this restriction.
https://example.com or https://example.com/probe/me are some examples.
@fabxc

I don't think I understand.
This reverts us back to pre-v0.14 in which we explicitly moved to hostnames from full URLs.
How is this supposed to relate to the scrape config's scheme and metrics path fields?

This is for a different use case, where the instance label ends up as a URL parameter on an exporter via relabelling rather than where prometheus is scraping it directly.
The scheme and metrics path would still apply as-is.

With this you can validly configure a target group that results in targets being scraped like https://http://my.domain/my/path//metrics.
We defined the instance label to contain <hostname>:<port> – always. For the record, that implies that relabeling may rewrite it but the result has to fit this schema again.
Can you please explain what you want to do? I cannot infer that from the above.

https://github.com/prometheus/blackbox_exporter#prometheus-configuration has an example configuration. I'd like to have https in the instance label the user passes in.
This restriction only exists for target groups, other SD methods don't have it.

What about moving this assertion at the end of the target evaluation, after the relabeling is done? An invalid target would then appear as CRITICAL: invalid target format: .....

That'd make sense.

You could continue to fail fast during config load if a target is not valid and no relabel rules for address are used.

Are there any objections to me merging this? It's causing problems for users of the blackbox exporter.

@fabxc is on vacation today. I'm on a conference. I'll have a look ASAP (but currently just backlogging many things, sorry...)

@brian-brazil can you add a test to ensure unexpected hostnames will be reported as an error? I'd also still prefer to error immediately in case no relabel rules are present. This will reduce the feedback loop for new users as Prometheus won't even start with an invalid config.

I see the use case. I think it might be potentially confusing. That this field in the target group maps to the instance label is not immediately obvious.
FileSD will be the only SD mechanism that supports this.
What's the proposal for solving this for probing targets coming from other mechanisms?
Why would this not apply to static/file targets?

FileSD will be the only SD mechanism that supports this.

Currently everything except target groups supports it, I want to make everything support it.

What's the proposal for solving this for probing targets coming from other mechanisms?

That should already work via relabelling.

Why would this not apply to static/file targets?

I'm not sure I understand the question. This restriction currently only exists in the config parsing code of target groups.

Currently everything except target groups supports it, I want to make everything support it.

The other SD mechanisms only provide host/port tuples as well, unless you fiddle around in the code.

That should already work via relabelling.

Exactly, so the question below was, why would it not work via relabeling for static targets? Looking at the blackbox exporter README, that seems pretty straightforward.
I'm not sure why we would mess with our definitions to make things easier for a single downstream tool.

I don't get it...
In https://github.com/prometheus/blackbox_exporter#prometheus-configuration , you could set instance to whatever you want in the relabel step. If I understand correctly, that would be the way you'd do it in the general case of an arbitrary SD mechanism.
Why isn't the same good enough for static configuration?
Or even: Shouldn't the relabeling look the same no matter if I use SD or static configuration?

Or even: Shouldn't the relabeling look the same no matter if I use SD or static configuration?

Yes, the problem is that the current state restricts what can be supplied as inputs to relabelling which then makes the required configs much more complicated to workaround that.

The other SD mechanisms only provide host/port tuples as well, unless you fiddle around in the code.

The current SD mechanisms can in theory provide any value for instance, however static targets can't as they have a check that it not applied to any other SD mechanism. This is inconsistent.

Exactly, so the question below was, why would it not work via relabeling for static targets?

Consider how you'd supply the following currently:
    target_groups:
      - targets:
        - http://mywebsite.com
        - https://mywebsite.com
        - https://mywebsite.com/subservice
    relabel_configs:
      - source_labels: [__address__]
        regex: (.*):80
        target_label: __param_target
        replacement: ${1}

As it stands, that'd require either very awkward relabelling or a scrape_config per target.
I'm proposing to make the above work as you'd expect.

What you want to do is clear to me by now, but...

The current SD mechanisms can in theory provide any value for instance, however static targets can't as they have a check that it not applied to any other SD mechanism. This is inconsistent.

How? They set __address__ to <host>:<port>. Other labels are all prefixed. They do not provide an instance label at all, nor could they (unless we did some odd changes to the implementations).

How? They set address to :

Most work that way (unless something weird is going on), but that's not the case for file SD and target groups where the idea of "target" may be more complex than host:port due to this use case as the target is a service rather than one instance.

Yes, but the question was how the path would look for other SDs for which you repeatedly stated they already support the behavior, which is not the case as you seem to agree with now.
So I'm confused about the reasoning here. I'm also not against it per se as we can indeed do the check later. But we have to get the facts straight bevor changing our interface. For the target group case it also is no longer a static but a runtime error. Also not that problematic but something to be aware of.

Yes, but the question was how the path would look for other SDs for which you repeatedly stated they already support the behavior, which is not the case as you seem to agree with now.

I meant that existing SDs already have sufficient flexibility, as instance host:port is all that you want in those cases. Something like probing all the application ports of some instances just needs the host:port of each instance for relabelling, not a list of URLs that the service exposes.

For the target group case it also is no longer a static but a runtime error. Also not that problematic but something to be aware of.

Yeah, I'm just in the middle of handling code review comments (I was at a conference all week) and will add @grobie's suggestion to bail if there's no relabel rules and someone has bad targets. That should cover the main potential source of user error.

The change has been updated.

LGTM

Agreed that we could do an even stricter check.
Generally fine with this :+1:


Grid continues to jump and disorient

We need to remove the grid I think, and re-evaluate how it's used. Right now it is too confusing.

Related https://github.com/KittyCAD/modeling-app/issues/2039

It's been decided, we are removing the grid.

The jumpiness of the grid can be avoided by just running the gridlines off the ends of the viewer in every direction. Zooming in and out could reveal finer and finer minor grid lines within each square so that the coarseness of the grid is always appropriate for whatever scale you're working in

(my gif isn't very smooth. The squares-within-a-square should probably also gain or lose transparency as you zoom in/away)

This would also make it a lot easier to distinguish up from down if the user has spun the camera around a lot

The scale indicator could live in the bottom right corner of the screen with the units indicator, rather than move around with the grid

Sorry if you're still seeing the grid the intent was to be off by default :)

he likes the grid :)

Ah ok, grid is back on :)
This involves 2 engine changes and 1 modeling-app change:

We need engine to do the new drawing logic

We need engine to report scale changes as some event

We need modeling-app to use these events to display the current scale

I'll open the issues when I get around to it, I may even try to do it myself

actually it turns out he just wanted something on empty scene, I pointed him to https://github.com/KittyCAD/modeling-app/issues/2880 @nicboone8 let us know if you'd still even use the grid with that, if not, we can close :)

Oh much easier then

yea, disabling the primary grid makes sense to me in that case. The sketch grid is still pretty useful


Make python run_integration_test.sh handle multiple tarballs

Will take the last one in alphanumerical order, instead of passing all
on the command line and effectively using the first and oldest.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

R: @markflyhigh

run python postcommit

@aaltay for merge

I will merge it. But @markflyhigh can also merge it now that he is a committer :)


Daemon receives garbage on sending nothing

When the socket is open from cli but it closes the connection without sending a message, the daemon receives garbage.

please  give more details


(3.x) GitHub actions and some other improvements

Hello, @stevenosloan @siegy22 ! 👋
Thank you for your hard work on this gem.
I opened this PR to propose some changes and improvements, such as:

Replacement of Travis CI to fully integrated CI/CD with Github Actions. It includes tests, lints, and deploy to Rubygems. The last one (deploy to Rubygems), once configured, can be made by "Actions" tab, dispatching the workflow manually or be triggered by a release/tag creation on repo. The two option are possible;

Example of CI output: https://github.com/pedrofurtado/slack-notifier/actions/runs/1331169528

Configuration to rubocop run in all files except specs and gemspec, and fixes of offenses;
Dockerfile for other devs pull repo, make changes and test it in PC easily;
Renames of some special files (CHANGELOG, README for example) and some text changes;
Exclusion of feature for multiple-channel message sending, because Slack does not provide this anymore;
README improvements

Let me know what you think about 🍻 🤝
PS: Some secrets are required to be configured, for Rubygems deploy. I can explain for you the steps to be done 👍
PS 2: The gem internal structure was changed, because of this I've changed version to 3.x 🔍
PS 3: Dont worry the amount of files changed 😄 , the gem keeps stable and with test suite running well in Rubies from 2.0 until 3.0, JRuby and TruffleRuby 🎉

👀

Thank you very much for working on this, I need @stevenosloan to respond first if he's willing to give maintenance control to me. 😄

@siegy22 🎉 🤝

Any news about this MR? 👀 😄

@siegy22 sorry about that, you should have an invite to be a maintainer -- I *thought* I'd done that when I split this off to an org instead of my personal, but that appears not to have been the case 😬

Any news about this PR? 👀 😄

@stevenosloan Can you re-send the invitation, I tried accepting it, but it was already expired 😞


Implement pre-fetching in map() and gen()

This adds a prefetch setting which enables async downloading of objects to the cache before running a generator or mapper UDF (see #40). The default is to use 2 workers, but it can be disabled using .setting(prefetch=0). Note that it has no effect if caching isn't enabled (caching is disabled by default).
In order for this to work, AbstractWarehouse.dataset_select_paginated() is now required to be thread-safe, so query result pages are now buffered as a list in that function.

Does this implementation mean that we now won't start (at least the very first row) UDF until file is fetched? Before it was doing this "on-demand" I guess - when file is needed. I wonder how big of an issue it can be in certain scenarios (and especially if we decide to do prefetch for batches (agg, batch mapper)).

Yes, the File object is only passed to the UDF once prefetching is complete, but note that in this PR you need to specify cache=True to activate prefetching, which you probably wouldn't do in cases where prefetching is suboptimal.


Crash due to null mutex in QUICBidirectionalStream::generate_frame

Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x000000000075d777 in Mutex_lock (location=..., ahandler=0x0, m=0x0, t=0x2abfa3220000) at /usr/local/src/trafficserver/iocore/eventsystem/I_Lock.h:320
320	  if (m->thread_holding != t) {
[Current thread is 1 (Thread 0x2abfa4604700 (LWP 20265))]

#2  0x00000000007829b6 in MutexLock::MutexLock (this=0x2abfa4603320, location=..., ahandler=0x0, am=..., t=0x2abfa3220000) at /usr/local/src/trafficserver/iocore/eventsystem/I_Lock.h:439
#3  0x0000000000b14d3b in QUICBidirectionalStream::generate_frame (this=0x2abfb4216400, buf=0x2abfa46034c0 "蜽", level=QUICEncryptionLevel::ONE_RTT, connection_credit=4611686018427349604, maximum_frame_size=1140, current_packet_size=6, seq_num=811) at QUICBidirectionalStream.cc:374
#4  0x0000000000ac771d in QUICStreamManager::generate_frame (this=0x2abfa616e100, buf=0x2abfa46034c0 "蜽", level=QUICEncryptionLevel::ONE_RTT, connection_credit=4611686018427349604, maximum_frame_size=1140, current_packet_size=6, seq_num=811) at QUICStreamManager.cc:451
#5  0x0000000000a423fd in QUICNetVConnection::_packetize_frames (this=0x2abfb3efa640, packet_buf=0x2abfa46036a0 "\360\066`\244\277*", level=QUICEncryptionLevel::ONE_RTT, max_packet_size=1280, frames=std::vector of length 1, capacity 1 = {...}) at QUICNetVConnection.cc:1693
#6  0x0000000000a41465 in QUICNetVConnection::_state_common_send_packet (this=0x2abfb3efa640) at QUICNetVConnection.cc:1529
#7  0x0000000000a3e255 in QUICNetVConnection::state_connection_established (this=0x2abfb3efa640, event=2501, data=0x2abfa1f05980) at QUICNetVConnection.cc:900

This is similar to #7115. The stream was reset. will_generate_frame can return true even if write_vio is not available because the stream may want to send some frames that don't require write_vio. However,  current code tries to acquire the lock regardless of the necessity of write_vio at the top of generate_frame.


No return access token from either loginRedirect or acquireTokenSilent

Library

[ ]<EMAIL_ADDRESS>or<EMAIL_ADDRESS>[X]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>
Framework
I'm using Vue if that is what is meant by framework
Description
I am unable to obtain an access token post successful login. I have tried multiple different scopes and understand that if there is no resource scope requested then it stands to reason that no access token should be returned.
I have read over the issue #2315 thread a couple of times, which has been helpful but ultimately didn't offer a solution for me, aside from hinting at the possibility that there is an issue/bug with b2c itself - which is of course disappointing
Version:
vue2.6.12
MSAL Configuration
const msalConfig = {
  auth: {
    clientId: "xxxxxx",
    authority: "https://xxxxx.b2clogin.com/xxxxx.onmicrosoft.com/B2C_1_signupsignin",
    knownAuthorities: ["xxxx.b2clogin.com"],
    redirectUri: "http://localhost:8080/user/login"
  },
  cache: {
    cacheLocation: "sessionStorage",
    storeAuthStateInCookie: false,
  },
};

Reproduction steps
// Some Vue scaffolding omitted - most of this is called in the beforeMount event hook...

let request = {
     scopes: ["https://xxxxx.b2clogin.com/xxxxx.onmicrosoft.com/user.read"],
      } // I've tried a number of different versions of this including a simple "user.read". I have granted my app api permissions to the microsoft graph api

this.$msal.loginRedirect(request) // This returns no access token although I am expecting it to with the scope I have requested

this.$msal.handleRedirectPromise().then(this.handleResponse).catch(err => {
            // Login failed
            console.log(err)
            //this.$router.push('/error')
        })

// this.handleResponse: - again, this fails to return an access code.
let request = {
                scopes: ["https://xxxxx.b2clogin.com/xxxx.onmicrosoft.com/user.read"], // Same scope as requested originally
                account: this.$msal.getAccountByLocalId(resp.account.localAccountId)
            }

            let res = await this.$msal.acquireTokenSilent(request).catch(error => {
                console.warn("silent token acquisition fails. acquiring token using redirect");
                console.log(error)
                if (/*error instanceof this.$msal.InteractionRequiredAuthError ||*/ error.errorMessage.includes("AADB2C90077") || error.errorMessage.includes("AADB2C90117")) {
                    // fallback to interaction when silent call fails
                    return
                    //return this.$msal.acquireTokenRedirect(request);
                } else {
                    console.warn(error);
                }
            })
            if (res.accessToken) {
                return res.accessToken
            } else {
                console.log("no access")
                //return await this.$msal.ssoSilent(request)
            }

Expected behavior
As I am requesting a resource scope, I am expecting an access_token...
Browsers/Environment

[ ] Chrome
[ ] Firefox
[X] Edge
[ ] Safari
[ ] IE
[ ] Other (Please add browser name here)

@JTInfinite Are you trying to obtain an access token for MS Graph or is user.read a custom scope you configured on your B2C tenant? You cannot obtain tokens for MS Graph using delegated permissions when using a B2C tenant, this is documented here.
Can you try creating a custom scope on your app registration and see if that gets you an access token back?

@tnorling yes, I am trying to obtain a token for MS Graph. I've reread the documentation you sent and I think its becoming more clear...
I created a custom scope on my app registration and included it as the scope in the loginRedirect and the subsequent acquireTokenSilent and nothing changes...no token:

Forgive the redacting - I'm not entirely sure what is sensitive
Thanks for your assistance thus far!

Hi @tnorling - I've managed to get an access token for a customer scope working. I had to create a webAPI app registration which exposed an endpoint and scope etc..etc..
I'm abit confused now between the scopes and permission section on the webapi app. What does my custom scope relate to? How do I expose microsoft graph through my webapi app to my client app?
Thanks!

I am at the stage where I've written an API and am using the b2c registered app secret to get the MS Graph token.
What I don't understand is where the user login and subsequent tokens come into this? How can I make it so an access token from my logged in user is used to access my api, which in turn accesses ms graph?

@JTInfinite Can you clarify what data you're interested in getting from MS Graph and what Identity providers you are using for B2C?

@tnorling Thanks for getting back to me.
I've managed to get an access token from my SPA. I've managed to get an azure function to request an access token to use to retrieve a list of users in my B2C directory.
I'm now working through the docs to understand how to protect the azure function API with B2C.
I've run through this two part documentation:
https://docs.microsoft.com/en-us/azure/active-directory-b2c/tutorial-single-page-app-webapi?tabs=app-reg-ga
...but it uses express and my translation into Azure function doesn't return anything...never used passport.js before.
I'm now on this doc:
https://docs.microsoft.com/en-us/azure/api-management/howto-protect-backend-frontend-azure-ad-b2c
which seems to be taking me down a APIM route.
I wonder if you can point me in the right direction: SPA -> Login -> Protected Azure Function API -> Get data (from multiple sources)?
The documentation for B2C is almost cryptic.

I managed to protect an azure function using the B2C access token.
Still not 100% sure as the webapi registered app in B2C uses the implicit grant flow.
Anyway, at least I have a working system now.

@JTInfinite instead of translation you can perhaps use the azure-function-express library? There is a sample here featuring that.

@derisen thanks - that looks really cool. Wish i'd found it 2 days ago!

Sorry about that, missed this thread : )


Error.humanReadableText is inaccessible

When I am trying to catch error and then use humanReadableText value it says it's internal property and therefore is not accessible

Thanks for the report, I made Error CustomStringConvertible so you can print(error) or read error.description to access the message.


Add TODOs Badge to README

Hi there! I wanted to propose adding the following badge to the README to indicate how many TODO comments are in this codebase:

The badge links to tickgit.com which is a free service that indexes and displays TODO comments in public github repos. It can help surface latent work and be a way for contributors to find areas of code to improve, that might not be otherwise documented.
The markdown is:
[![TODOs](https://img.shields.io/endpoint?url=https://api.tickgit.com/badge?repo=github.com/dapr/dapr)](https://www.tickgit.com/browse?repo=github.com/dapr/dapr)

Thanks for considering, feel free to close this issue if it's not appropriate or you prefer not to!

Hey @patrickdevivo thanks for bringing this up.
I personally could do with a badge like that.
I want to hear from a few other maintainers to see what they think.
/cc @amanbha @LMWF @youngbupark @artursouza


Add MakeRelative alias to DirectoryPath and FilePath

What You Are Seeing?
MakeAbsolute is a useful alias to transform a relative path into an absolute path based on the current WorkingDirectory, but there's not an equivalent alias for doing the opposite, that is, transform an absolute path into a relative path.
What is Expected?
I'd like Cake to provide a MakeRelative alias that transforms an absolute path into a relative path, which is useful when printing messages to the console log, for ease of reading.
e.g.
// Environment.WorkingDirectory => "C:/Working/"

var relativePath = MakeRelative("C:/Working/build/MyApp.csproj");
// relativePath should be "./build/MyApp.csproj"

What version of Cake are you using?
0.38.4

ps: I'm happy to send a PR that adds this feature.

Might be a good edition
Example of code making path relative
https://github.com/cake-build/cake/blob/80d787c5c9c0e102e088ef1a41c0f2e1ae95e790/src/Cake.Common/IO/Zipper.cs#L225-L233
A MakeRelative alias should take rootPath as the last parameter and be optional, that way it could default to working directory but you could also specify a path.

@augustoproiete @devlead Better to use the RelativePathResolver which was made for this: https://github.com/cake-build/cake/blob/develop/src/Cake.Core/IO/RelativePathResolver.cs
The method above should probably be rewritten to use that as well...

Fixed by #2923


open Encrypted xlsx with XSSF

The supplied spreadsheet seems to be an Encrypted .xlsx file. It must be decrypted before use by XSSF, it cannot be used by HSSF
workbook = WorkbookFactory.Create(fs);
dll version <IP_ADDRESS>

duplicate with #161


Expose option to set historic feed error callback handler

#688

Can't +1 on ZenHub atm for some reason, but LGTM

Thanks for the reviews guys :)


Can't get deatils of orderer_local after restart of test-network and operations console

First run and associating identities are ok but when I stop everything and open them again I can’not reach details
1- I start test-network and console using the commands;
./setupNerwork.sh up
./setupConsole.sh up
2- I create assets using the command;
./createAsset.sh

3- I login http://localhost:3000/ , import assets and save
4- I associated  all identities and displayed details successfully

5- I logout the console and stop  both console and test-network
./setupConsole.sh down
./setupNetwork.sh down
6- I start the  test-network and console again using the following commands;
~/fabric-operations-console/fabric-samples/test-network$ ./network.sh up -ca -s couchdb
or  ./setupNetwork.sh up
./setupConsole.sh up

7- I get the following error when I open orderer_local details;
“Unable to get channel information from orderer_local. The associated identity does not have administrative privilege. Ensure that the associated identity has administrative privilege.”

8- For ordererca-local,  I also get error saying “Unable to retrieve the list of users”

@varadgit  Any idea?

@turantk when you "down" and "up", it is going to create new containers and new certificates. You will need to redo the ./createAsset.sh, clear identities from wallet in browser and create new ones and associate with components.

@varadgit  Thank you very much for your answer. I would like to say that you doing a great job.

closing


Fix sacct parsing for jobs cancelled before starting

Example sacct output for the case which causes failure:
[root@control cloud-user]# sacct --format jobid,start,end --starttime=2023-01-01
JobID                      Start                 End
------------ ------------------- -------------------
...
4            2023-04-19T12:40:19 2023-04-19T12:40:19
4.batch      2023-04-12T15:45:20 2023-04-19T13:53:32
5                           None 2023-04-19T13:17:06
6                           None 2023-04-19T13:17:06
7            2023-04-19T13:54:08 2023-04-19T13:54:08

Once merged this fix will be deployed by running ansible/monitoring.yml on any appliance, as pytools_gitref which installs this is defaulted to main.

Here's how a cancelled-before-start job appears in the dashboard:

The generated link is something like:
http://<IP_ADDRESS>:3000/node/control/3000/d/openhpc-slurm?orgId=1&from=&to=1683278314000&var-job_id=72&var-host_filter=None\ assigned
Which means the start time in the linked dashboard is the default (15mins before) and the Host regex filter is None\ assigned, which filters to nothing. I think this is good enough.


Run failed, Exception: The given key ... was not present in the dictionary

Hi,
I am having an error while analyzing my samples. The error occurred also when performing the analysis on other computer.
I am using MM version 0.0.320
The search reported the following error: "Run failed, Exception: The given key ... was not present in the dictionary", where the "..." key is a peptide sequence.
I found that peptide in the database I am using (Mouse_SP_2022, downloaded from UniProt). I tried using either the FASTA or XML formats, also I tried to remove the protein containing that peptide, but still have the same issue (for a different peptide).
Any ideas what is the problem and how to solve it?
Thanks

is there any way to share your data with me? i'd like to try and search them to reproduce your error.

@trishorts Yes, of course.
You can download the raw files here: https://owncloud.incpm.weizmann.ac.il/index.php/s/tKAYbbZ5xl7oiU1


Synchronizing blobs in Azure cloud storage with local filesystem (like azcopy's sync)

Package Name: azure-storage-blob
Package Version: 12.5.0
Operating System: Ubuntu 18.04 LTS
Python Version: 3.6.9

Describe the bug
A clear and concise description of what the bug is.
I listed this issue as a bug, although it is not one, but it's a feature that I either couldn't find in the Azure SDK for Python, no matter how deep I went in documentation, so please bare with me.
We have been using azcopy for manipulating with files in Azure storage till now, but now we are using the Python SDK to do so. The thing is, azcopy has a feature that let's you sync your files in Azure storage with the local filesystem and I wanted to know if there is a way to do the same thing with the Python SDK. I want the same functionality azcopy sync command has, but for the Python SDK. If that does exist, please point me at it so I can start using it.
To Reproduce
Steps to reproduce the behavior:
N/A
Expected behavior
A clear and concise description of what you expected to happen.
I wrote the expected behavior on the bug description above.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

I have same issue

@xiafu-msft Couldn't help but notice you added the feature-request label to this issue. Are you trying to say that this doesn't exist as of the current version of Azure Python SDK? An output would be truly appreciated. Thank you.

Hi @bsherifi, this feature does not currently exist. Currently you would have to manually download and upload those files. However, we have had a discussion about your suggestion and it seems like an interesting feature to add. We will have further discussions internally and will update this issue once we open a PR or have any updates :)

Hi @bsherifi
Thanks for reaching out!
Just curious, have you thought about calling azcopy command in python script? Currently Python SDK doesn't support that feature.

Thanks for your reply @tasherif-msft. It will be so good to have a feature like that in order to completely replace azcopy with Python functionalities considering there's a SDK for it. Looking forward to this one.
@xiafu-msft Thanks for your reply too. And, yes, I actually have a solution like the one you mentioned but I was thinking to make something completely in Python and independent from azcopy.

Hi @bsherifi, we have had some internal discussions regarding this. Currently it will not be in our short term plans to implement azcopy-like feature such as sync within our SDK. However I will mark this as a feature request and will leave open for our long term backlog. Sorry for the inconvenience!
Let me know if you need anymore help :)

Hi @bsherifi, we have had some internal discussions regarding this. Currently it will not be in our short term plans to implement azcopy-like feature such as sync within our SDK. However I will mark this as a feature request and will leave open for our long term backlog. Sorry for the inconvenience!
Let me know if you need anymore help :)

Hi @bsherifi I will close this issue as there is a duplicate https://github.com/Azure/azure-sdk-for-python/issues/6306 to track.


Update README.md

Added link to Ingress Prime scraper site. Https://xgress.com

I'm not going to put a giant ad for your website at the top of the README, above the project name no less lol

Thanks
Sent from my iPhone

On May 9, 2019, at 3:24 PM, Zetaphor<EMAIL_ADDRESS>wrote:
I'm not going to put a giant ad for your website at the top of the README, above the project name no less lol
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks for what? I rejected the PR lol


Job is dead error comes up every launch

Every time I launch neovim I'm given the following error
[ncm2_core@yarp] Job is dead. cmd=['python3', '-u', '/.../pythonx/yarp.py', '/tmp/nvimL5FRdr/0', 2, 'ncm2_core']. What can I do about this?

@Kyle-Thompson: odd, i have neovim installed via pip and pip3, and still getting this

@megalithic try removing completely from your system with pip3 uninstall neovim and sudo pip3 uninstall neovim. Upgrade to the latest version, and install user only, pip3 install neovim --user, perform a :checkhealth after starting neovim.

I'm having a similar error. I have followed suggestion to completely uninstall and reinstall neovim, I'm on mac, tried using macports as well as pyenv / virtualenv, but the error persists.

I am having same error on FreeBSD. Uninstalling all pip2 neovim/pynvim modules and reinstalling all pip3 modules didn't help.
But on my system, root's nvim works as expected.
user:
## Python 2 provider (optional)
  - INFO: `g:python_host_prog` is not set.  Searching for python2 in the environment.
  - INFO: Executable: /usr/local/bin/python2
  - INFO: Python version: 2.7.15
  - INFO: pynvim version: 0.3.2
  - OK: Latest pynvim is installed.

## Python 3 provider (optional)
  - INFO: Using: g:python3_host_prog = "/usr/local/bin/python3"
  - INFO: Executable: /usr/local/bin/python3
  - INFO: Python version: 3.6.8
  - INFO: pynvim version: 0.3.2
  - OK: Latest pynvim is installed.

root:
## Python 2 provider (optional)
- WARNING: No Python executable found that can `import neovim`. Using the first available executable for diagnostics.
- ERROR: Python provider error:
  - ADVICE:
	- provider/pythonx: Could not load Python 2:
		/usr/local/bin/python2 does not have the "neovim" module. :help provider-python
		/usr/local/bin/python2.7 does not have the "neovim" module. :help provider-python
		python2.6 not found in search path or not executable.
		/usr/local/bin/python does not have the "neovim" module. :help provider-python
- INFO: Executable: Not found

## Python 3 provider (optional)
- INFO: Using: g:python3_host_prog = "/usr/local/bin/python3"
- INFO: Executable: /usr/local/bin/python3
- INFO: Python version: 3.6.8
- INFO: pynvim version: 0.3.1 (outdated; from ~/.local/lib/python3.6/site-packages/neovim)
- WARNING: Latest pynvim is NOT installed: 0.3.2

Both user and root are using the same config (ln -s /home/user/... /root/...) but python modules are in separate dirs (~/.local).

Honestly why does it even matter to install through Pip vs through Homebrew?  You could execute the job manually in another terminal and see how it goes.

It doesn't exactly. Most of the command doesn't fit (gets truncated), and I don't see it when i enable logging.

@hiphamster  Unfortunately It's hard to debug in this case.
This is different issue than the one posted by Kyle-Thompson, you should open a new  issue. And maybe a docker image for reproducing the issue, since there's no enough debugging information from your describtion.

@thefallenidealist The job is dead message prints the full command startting the job. You could execute the job manually in another terminal and see how it goes.

Tried that a few days ago and that worked. But not inside nvim. Anyway, rebooted machine and works as expected.
Updated root's pynvim and plugins and it is still working.
I'll try tomorrow on Win10 machine, I think there were also same error messages.

I tried this with the nvim installed by brew on Mac OSX.
The command I tried the so the debug log(I linked vim to nvim):
vim -V9myVim.log

I can see the exact error is the module neovim does not exist.
I tried install the module manually, it got failed due to the ssl issue.  As some one suggested I ran the command to reinstall python:
brew reinstall python

then
sudo pip3 install --upgrade neovim

after that reopen nvim, the error is gone. Hope this could help!

brew reinstall python

then
sudo pip3 install --upgrade neovim

after that reopen nvim, the error is gone. Hope this could help!

Seems the python re-install is the key here. I just ran the brew reinstall command and afterwards tried a:
brew upgrade vim

the latter did not do any changes because nvim was up to date. But still the issue is gone for me now, the only perceivable change being the python reinstallation.

I had the same issue and followed the suggestion of @roxma . Executing the command directly in terminal showed:
...
ModuleNotFoundError: No module named 'jedi'
...
So I did a pip install jedi and it worked. Maybe this is helpful to others

After installing nvim via pip as per the comments above, I was still getting the error. I had to specify the path to my python installation in ~/.config/nvim/init.vim:
let g:python3_host_prog = '/path/to/bin/python3'
let g:python_host_prog='/path/to/bin/python2'
This solved the issue, hope it helps.

I had same issue. Checking which pythons were executable
which python2
=> /usr/local/bin/python2
which python3
=>  /usr/bin/python3

It looks like python3 was pointing to MacOS python. After running brew reinstall python I got the correct path and issue resolved

I tried this with the nvim installed by brew on Mac OSX.
The command I tried the so the debug log(I linked vim to nvim):
vim -V9myVim.log

I can see the exact error is the module neovim does not exist.
I tried install the module manually, it got failed due to the ssl issue. As some one suggested I ran the command to reinstall python:
brew reinstall python

then
sudo pip3 install --upgrade neovim

after that reopen nvim, the error is gone. Hope this could help!

everyone this is helping

In my arch linux system, all I had to do is install/update the python-neovim package. No "pip install" was required.

In my arch linux system, all I had to do is install/update the python-neovim package. No "pip install" was required.

@Esternome tks
brew reinstall python && sudo pip3 install --upgrade neovim
It's was enough 👍

In my case  reinstalling python  (in CentOs), pointing to the right python3, or upgrading neovim did not solve the problem. The pythonx folder contains only the yarp.py and no neovim.api. I installed neovim with miniconda.

In my arch linux system, all I had to do is install/update the python-neovim package. No "pip install" was required.

Same for me: sudo apt-get install python3-neovim did the job :)

@megalithic try removing completely from your system with pip3 uninstall neovim and sudo pip3 uninstall neovim. Upgrade to the latest version, and install user only, pip3 install neovim --user, perform a :checkhealth after starting neovim.

thx, solve my problem in Windows.
I tryng install ncm2 plugin I was not successful because this conflict, but I reinstalled neovim with pip solve my problem.


Simplify drivers read/write methods

From Issue #78 this refactors the DriverInterface and all the drivers.
Removes executeReadCommand(), executeWriteCommand(), runReadCommand(), runWriteCommand() and replaces them with runCommand() and executeCommand()
This pr also moves the logic for passing a builder to the driver into AbstractDriver from the Neo4j and Orient drivers. It introduces ensureCommand($command, $scriptLanguage) which will proccess a builder, make sure the language is supported, and pass back a command. If a command is handed, it simply returns the command.

Can you pull a branch or two and run the full test suite? Sometime overnight, my Gremlin transaction tests started failing and I can't figure out why. The builds are passing, and every branch is failing, including master, which I know was working yesterday.
I've restarted and such. I just want to make sure its a local problem.

The tests fail for me too.
This is the develop branch.

S............................................................S.  63 / 112 ( 56%)
...EF........S...............SS...................

Time: 21.43 seconds, Memory: 24.00Mb

There was 1 error:

1) Spider\Test\Unit\Drivers\Gremlin\DriverTest::testTransactions | it commits properly on transactional graph
Trying to get property of non-object

/opt/appserver/webapps/spider/tests/Unit/Drivers/BaseTestSuite.php:291
/opt/appserver/webapps/spider/vendor/codeception/specify/src/Codeception/Specify.php:97
/opt/appserver/webapps/spider/vendor/codeception/specify/src/Codeception/Specify.php:50
/opt/appserver/webapps/spider/tests/Unit/Drivers/BaseTestSuite.php:304

--

There was 1 failure:

1) Spider\Test\Unit\Drivers\Gremlin\DriverTest::testTransactions | it rollbacks properly on transactional graph
failed to return an EMPTY array
Failed asserting that an array is empty.

/opt/appserver/webapps/spider/tests/Unit/Drivers/BaseTestSuite.php:267
/opt/appserver/webapps/spider/vendor/codeception/specify/src/Codeception/Specify.php:97
/opt/appserver/webapps/spider/vendor/codeception/specify/src/Codeception/Specify.php:50
/opt/appserver/webapps/spider/tests/Unit/Drivers/BaseTestSuite.php:269

--

There were 5 skipped tests:

1) Spider\Test\Integration\QueryBuilder\WithNeo4jTest::testDrop
Cypher processor needs traversal logic before being able to drop.

/opt/appserver/webapps/spider/tests/Integration/QueryBuilder/WithNeo4jTest.php:45

2) Spider\Test\Unit\Drivers\Gremlin\DriverTest::testFormatTree
Tree is not yet implemented as gremlin-server doesn't currently support it

/opt/appserver/webapps/spider/tests/Unit/Drivers/Gremlin/DriverTest.php:254

3) Spider\Test\Unit\Drivers\Neo4J\DriverTest::testFormatTree
Tree is not yet implemented as gremlin-server doesn't curently support it

/opt/appserver/webapps/spider/tests/Unit/Drivers/Neo4J/DriverTest.php:216

4) Spider\Test\Unit\Drivers\OrientDB\DriverTest::testFormatTree
Tree is not yet implemented as orient doesn't currently support it

/opt/appserver/webapps/spider/tests/Unit/Drivers/OrientDB/DriverTest.php:239

5) Spider\Test\Unit\Drivers\OrientDB\DriverTest::testFormatPath
Path is not yet implemented as orient doesn't currently support it

/opt/appserver/webapps/spider/tests/Unit/Drivers/OrientDB/DriverTest.php:244

FAILURES!
Tests: 112, Assertions: 554, Errors: 1, Failures: 1, Skipped: 5.

Scott

That's exactly what fails for me, too. Could you try the master branch? Do you get the same results?

The PR looks good. I'll give the tests a spin

ok so all the tests passed initially and then failed on the subsequent re-run, which makes me think there's an issue in loading/unloading of fixtures. I'll give it a closer look.

You can check the last commit. It was a forgotten runWriteCommand that was left in the cleaning up process for transactions (leaving the vertices there and failing the tests). That's why it carried out to the other branches as well.
Since Travis is rebuilt each time these lingering vertices don't fail the tests. However you guys will need to clean your gremlin DBs.
If you're lazy you can simply comment the following locally:
https://github.com/spider/spider/blob/simplify-drivers/tests/Unit/Drivers/BaseTestSuite.php#L274-L293
Then run the tests again. it should clear things up.

Scrutinizer gives 5 new issues, do we want to fix those now or later in a cleanup PR?

I fought with scrutinizer for a bit, but everytime I fixed one, it would open up 2 new ones. Many of the issues aren't legitimate or they are style things we need to discuss. I'm opening an issue to throw around ideas and then we can cleanup the develop branch.

Does "clean gremlin dbs" mean re-install or is there a command to run?

it means g.V().remove().iterate(). You can do what I described in the "lazy" comment if all you're looking to do is correct this issue.


[Template] attribute does not work on event if the {this} placeholder is missing

This issue is very similar -- but not equal to -- issue #3101.
If the Template attribute is set to events' add/remove methods and they are missing (at least) the {this} reference, then the {value} reference does not get replaced correctly, instead, a template like:
"doSomething({value})"

Will output
"doSomething({0})value_here;"

So, the placeholder is always replaced by {0} and the value (and semicolon) always appended to the template.
Steps To Reproduce
Deck reproducing the issue:
https://deck.net/1eda98a239c8c94e831b97aa8ffe44ed
Deck just adding the {this} placeholder to the template:
https://deck.net/d0d594ae5fec664f47abc7727899bada
Expected Result
Lines 11 and 13 of the output javascript should read:
            program.test.events.addHandler(Demo.Program.Handler);
            program.test.events.removeHandler(Demo.Program.Handler);

Actual Result
But lines 11 and 13 read:
            program.test.events.addHandler({0});Demo.Program.Handler;

            program.test.events.removeHandler({0});Demo.Program.Handler;

Additional information
Notice regardless of the {this} placeholder in the template, the beginning of the template is always prepended by program. when output.
Originally reported at: https://github.com/bridgedotnet/Bridge/issues/3101#issuecomment-365966431 by @TriEdgeAI.

Issue has been fixed! It will make it to the next Bridge version (see attached milestone).


AttributeError: 'MultiheadAttention' object has no attribute 'Wqkv'

Hi! I also encontered such issue. You need to install flash-attn (e.g., flash-attn==1.0.2) to let the self_attn equipped with layer .Wqkv()


Older solution doesn't work with vcpkg, no host-triplet option

I've recently rebuilt vcpkg and new VS2019 projects work fine with vcpkg, and give me options like this:

However when I opened an older VS2019 project I used to use for vcpkg testing, none of my includes to vcpkg headers were found. In the project settings, I noticed the "host triplet" option is missing, is this a clue? Could project settings be screwed up somehow?

Hi @jdx-john
Thanks for posting this issue.
Could you please try to integrate your project again? Please also check if the libraries required for old project are listed in the same repo with the libraries required for new project.

@NancyLi1013 reintegrating was what I tried first (and re-starting VS). The libraries used are ones we are already using in other projects against the same triplet.

So you used the same integration with these two projects, right?
Could you please try to run bootstrap-vcpkg.bat and reintegrate the project?
If still the same problem, please try to remove integrate and reintegrate. Then restart VS.

Maybe the same as #18337, there is also a workaround you could try

@NancyLi1013 yeah everything is the same - and other old projects work just fine. Reintegration etc don't help. It's only a throwaway test project so it's not really a problem but I am curious. I might look at the vcxproj file to see if something has got messed up. If I find anything I'll report back.

Thanks for posting this issue. This issue hasn’t been updated in three months. Please reopen this issue if this is still a problem for you.


Supporting ALL Messenger Webhook Events

Bot Info

SDK Platform: .NET
SDK Version: 3.14
Active Channels: Facebook Messenger

Issue Description
I have built a bot that supports the facebook handover protocol.
So, if a user wants to talk to a human, they click a button and the code will pass_thread_control to a facebook page/app. When the user wants to come back and talk to the bot they have to say a keyword like "QUIT". To make this work I have to subscribe to "message_echoes" in the facebook developer options of the app. What this does is that facebook will send messages to the bot even if it doesn't have thread control. Unfortunately, botframework throws those events away, never making it to my actual code to process.
I want to know if we can have botframework support all these different events and forward them to my bot /api/messages endpoint.
I found another issues here where the person had to build a proxy infront of botframework to handle those messages. I would like to avoid this if possible.
Thanks!

Hi @odannyc
Thank you for taking the time to post this feature request.  We've created an issue specifically for Facebook Messenger Feature Requests: https://github.com/Microsoft/BotBuilder/issues/4360  Please contribute to the discussion on that page.


Add removeListenerWhileNotifying benchmark for ChangeNotifier

This is a PR to reland #71986. This is a prerequisite to get https://github.com/flutter/flutter/pull/71947 merged.
This was reverted because it caused microbenchmarks to fail, see https://github.com/flutter/flutter/issues/74448 and https://github.com/flutter/flutter/pull/74450.
I am not entirely sure why the JSON got cut off in the middle there, but I assume it is because some devices truncate log messages that are too long. I was not able to reproduce this exception though, on my machine and my android devices this benchmark still succeeds.
So I added the changes the @letsar added in his original PR and made sure that the JSON string is much shorter now by rounding all double values to 2 decimal places (anything more than that is insignificant anyway).
Pre-launch Checklist

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I signed the [CLA].
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. (If you consider the benchmarks tests)
[x] All existing and new tests are passing.

@letsar you probably need to consent to this PR, otherwise, the bot will complain.

@googlebot I consent

I found another way to shorten the JSON. By setting _kScale = 1024; instead of 1000, due to _kNumIterations = 65536; to calculations produce numbers with less decimal digits in their representational string.
Before:
{"add1":427.4139404296875,"add2":157.7911376953125,"add3":339.385986328125,"add4":609.8480224609375,"add5":696.685791015625,"notify0":197.3114013671875,"notify1":161.0565185546875,"notify2":202.45361328125,"notify3":283.0963134765625,"notify4":337.5396728515625,"notify5":398.98681640625,"remove1":188.4613037109375,"remove2":585.3271484375,"remove3":929.779052734375,"remove4":932.830810546875,"remove5":1062.652587890625,"removeWhileNotify1":683.2275390625,"removeWhileNotify2":1733.245849609375,"removeWhileNotify3":1613.128662109375,"removeWhileNotify4":1935.760498046875,"removeWhileNotify5":2554.26025390625}

after:
{"add1":261.96875,"add2":171.21875,"add3":331.515625,"add4":551.421875,"add5":618.65625,"notify0":175.640625,"notify1":159.203125,"notify2":283.65625,"notify3":263.25,"notify4":333.765625,"notify5":438.4375,"remove1":178.703125,"remove2":634.265625,"remove3":1124.25,"remove4":783.296875,"remove5":994.390625,"removeWhileNotify1":703.9375,"removeWhileNotify2":1604.625,"removeWhileNotify3":1519.546875,"removeWhileNotify4":1966.046875,"removeWhileNotify5":2533.703125}

I'm now optimistic that along with the shortened names, this is enough to avoid the cut-off issue.

The scale translates the value from ms to ns. With scale = 1024 that translation is no longer correct.
You can run them locally as follows:
# from the .../flutter/dev/devicelab directory
../../bin/cache/dart-sdk/bin/dart bin/run.dart -t tasks/microbenchmarks.dart

More details here: https://github.com/flutter/flutter/tree/master/dev/devicelab
Can you check if that passes without the scale change?

The scale translates the value from ms to ns. With scale = 1024 that translation is no longer correct.

Oh, yeah of course.

Can you check if that passes without the scale change?

Yes, it passes, but that also did pass before. It's probably a device-specific issue, so it may or may not pass on the CI.

@knaeckeKami I believe these tests are failing because this PR is not synced to the latest master. Can you rebase it to the latest master and see if that makes all the tests pass? Thanks!

done, but now web_e2e_test is failing...

Looks like a flake. I restarted the test.


Updated hab conf

updated habitat_confirmations.xls with QA'd data
updated csvs
tried to do as little script editing as possible to limit conflicts! But I did update  0100-extract-inputs.R with:

fixed the full_join which wasn't working because not all the keys were being matched so it was just adding rows to the end instead of actually joining the data.
updated with str_detect instead of %like%
updated to pull as much data as possible from step 4 instead of form_fiss_2023.

updated fiss_site_tidy.R with time correction.

fixed the full_join which wasn't working because not all the keys were being matched so it was just adding rows to the end >instead of actually joining the data.

I think Some other input must have been missing or incorrect for the full join not to function in 2023 if it is the same in all the past repos. ... We should try again with all the columns next time and watch out for this. Can you check a couple past running reports and make an issue in fish_passage_template_reporting and reference that PR change? Off to a meeting

Figured out the issue. The reason it didn't work for me is because step_2_fish_coll_data was partly filled out but the join by columns were not filled out, therefore not all the keys matched, so it wouldn't join (instead added rows to the bottom)
In the typical workflow, step_2_fish_coll_data is empty when this code is run, because it is being run to build hab_con_fish_summary.csv which is used to populate step_2_fish_coll_data, so this isn't an issue. step_2_fish_coll_data should get populated by the csv and then then the rest of the data is hand bombed. But this wasn't the case for me because I had already populated step_2_fish_coll_data with the ef data (but was missing sampling_method, method_number, and haul_number_pass_number so didn't join), but needed to re run with the updated site names and temp/cond/turb data.
I ran this code in the skeena 2022 report and all works well. I think we can disregard my edits and revert back to og script


General: Temporarily bypass ngsw-worker when uploading a file

Note: Please test it first on Chromium Browsers (Google Chrome, Arc etc.)!
Checklist
General

[x] I tested all changes and their related features with all corresponding user types on a test server.
[x] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

[x] Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
[x] I strictly followed the server coding and design guidelines.
[x] I documented the Java code using JavaDoc style.

Motivation and Context

Right now when users want to add an attachment on Chromium browsers (such as Chrome and Arc), they get a 404 Not Found error and their attachment is not uploaded. This is an issue occurring in Chromium's version 130, 132 and it is fix in version 132. However since it may take time until the release, a temporary solution was needed to tackle this problem.
See: https://issues.chromium.org/issues/374550348
Description

In one of the Chromium forum comments, it is stated that a work around can be used by bypassing the service workers.
See: https://issues.chromium.org/issues/374550348#comment20
This is first tried on Chrome by bypassing service workers manually and shown that it is working.

After that Angular's "ngsw-bypass" header flag is found to fix the problem.
See: https://angular.dev/ecosystem/service-workers/devops#bypassing-the-service-worker
Fixes #9732 and #9168 and #9646
Steps for Testing

Prerequisites:

1 Instructor

Log in to Artemis
Navigate to Course Administration
Navigate to Lecture -> Attachments -> Add an attachment
Observe that it is added correctly
Edit Attachment and add another
Observe that it is added correctly
Navigate to Lecture -> Attachment Units -> Add an Attachment Unit
Observe that it is added correctly
Edit Attachment Unit and add another
Observe that it is added correctly
Create a Lecture > click Automatic Unit Processing
Observe that the file is added without an error

Testserver States

[!NOTE]
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress

Performance Review

[ ] I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance even for very large courses with more than 2000 students.
[ ] I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance even for very large courses with more than 2000 students.

Code Review

[ ] Code Review 1
[ ] Code Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Test Coverage

Screenshots

Summary by CodeRabbit

Bug Fixes

Implemented a temporary workaround for a file upload issue in Chromium by adding a custom header to HTTP POST and PUT requests in the attachment services.

These changes enhance the file upload experience while maintaining existing functionality.

Tested on TS5. Almost everything worked. I just noticed two bugs but I am not sure if they are related to this PR though:

When clicking twice on the upload button for the unit while it's loading, it is added twice. Is this intended?

2. The tooltip says you can add png files as file. But when trying to add one, I receive an error.

Hello, this are not related to this PR but I think both of them are not intended :) You can open an issue with them


Memory dump doesn't support space (0x20)

0x10:<PHONE_NUMBER>657274206d657373616765    ??revert?message

It should read ??revert message.

@owocki sure:
in the above example,
0x10:<PHONE_NUMBER>657274206d657373616765    ??revert?message
the decoded text should be ??revert message so we should be able to decode to a space instead of ?

@yarn300 -- Can you please provide me steps to reproduce this locally? Would be easier for me to wrap this up quickly if you can point me in the right direction. Thanks :)

Compile, execute and debug the following:
contract C {
  function f() {
    revert("revert message");
  }
}

In the remix debugger there is an option to show the memory layout. Just click "debug" on the transaction and have a look at the memory.

@axic -- Running the above contract is actually printing out the following in the debugger Memory. Let me know if I'm missing something here.
0x0:<PHONE_NUMBER>0000000000000000000000 ????????????????
0x10:<PHONE_NUMBER>0000000000000000000000 ????????????????
0x20:<PHONE_NUMBER>0000000000000000000000 ????????????????
0x30:<PHONE_NUMBER>0000000000000000000000 ????????????????
0x40:<PHONE_NUMBER>0000000000000000000000 ????????????????
0x50:<PHONE_NUMBER>0000000000000000000080 ????????????????

On the side note, I had to add public keyword for the function f() in order to avoid Solidity error.

@axic @yann300 -- I see that the issue description is quite old and lot might have changed in the code because of which I'm seeing the above behaviour. I can fix the original issue of replacing space with ? but would like to know your thoughts on how to handle the above debug behaviour as it isn't quite clearer to me on what's happening. Thanks :)

The issue is saying that space should be displayed as space and not as the ? wildcard which is put there for any non-printable character.
To expand on the issue a tiny bit, I think it is safe to say that every single printable ASCII character should be printed and everything else replaced with ?.

@yann300 @axic let me know if/when this should be paid out!

@owocki the PR is merged ;)


Add example on how to catch events

Merged, and edited the docs and code to match current style. Thanks! Much appreciated.


MAINT: sparse: simplify COO ctor

This change unpacks the tuple in one go, catching TypeError for non-iterables and ValueError for invalid lengths. It also removes a bare except clause which was likely never triggered.
Related to a similar cleanup in #5222.

+1 if the Py3 issue is fixed. I was actually looking at this after I'd written #5222 and wondered if I should make this change as well.

Thanks! Parens added, travis is happy.

Merged, thank you!


[HOLD for payment 2024-08-20] Bank account - Unable to proceed after website step when website is auto populated

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.19-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:
Precondition:

User is logged in with Expensifail account.

Go to staging.new.expensify.com
Go to workspace settings > Workflows
Click Connect bank account > Connect manually
Proceed to Step 4 - Enter Company's Tax ID page
Enter Tax ID > Next
Note that the website field is auto populated with https://www.applause.expensifail.com./
Without editing the field, click Next.

Expected Result:
The setup will proceed to the next step.
Actual Result:
The setup is stuck on the same website step until user adds some edit to it.
Workaround:
Unknown
Platforms:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/70e8bf3d-5929-41a3-8ab6-8e9bf3c81496

View all open jobs on GitHub
Issue OwnerCurrent Issue Owner: @RachCHopkins

Looks related to #46796 (Not 100% sure).
@hannojg Can you look into this?

Hmm, on the first look it doesn't appear to me as related. The PR only changed the composer of the report page.

Yeah, none of the components used on the respective page with the bug was touched by the mentioned PR. I don't think the PR is related.

Repro'd locally - reverted this locally and it resolved the issue if while I was still on the add website page. But, of course, re-introduced the bug of skipping the website form if I restarted adding a bank account
cc: @bernhardoj @neil-marcellini

@suneox I'm still able to reproduce the issue
https://github.com/user-attachments/assets/14a20bb5-fe03-4713-a9ec-d4d0f48754c4

I found the issue. This happens specifically after removing this code.
What happen in this issue is that, when we press Next, the website draft Onyx data is still empty. It's only filled once we type into the text input. The linked code purpose is to save the generated website to the website draft Onyx.
But if we re-add that, then the website step gonna be skipped again because when we are at the tax ID step (step before the website step) and press next, the website step is mounted, the generated website is saved to the draft, then, a loading view is shown and then the step is remounted which will skip the website step because it's now contains a valid website.
We need to wait for https://github.com/Expensify/App/issues/45278 before we can re-add the above logic back. Every time a step (not sub-step) view is mounted, the initial sub-step will be evaluated and https://github.com/Expensify/App/issues/45278 will prevent the step to be re-mounted every time we save a sub-step.

That works. I'll prepare a PR for that.

@suneox @NikkiWines The PR is here: https://github.com/Expensify/App/pull/47314

Fix is being CP'd 👍

@IuliiaHerets can you please retest this on staging? 🙏

Confirmed this is fixed in staging!

@Beamanator sorry for delay. Website field is not auto populated now, but when enter it manually, Next button works
https://github.com/user-attachments/assets/548b92aa-86ac-4a8b-a039-ca7be92b87c5

I was offline. Thanks for handling the PR!

This should be on prod now cc: @RachCHopkins

@NikkiWines sorry I'm a little new to this, is this the standard $250? I believe @bernhardoj is paid via newdot manual requests, so we don't need an upwork job. And does anyone else need to be paid here?

I am confused. It says hold for payment and I am being tagged. Do I simply... close the issue?


optimisation of variant calling

Dear Jared
I've got Nanopore reads from 10 individuals I try to call SNPs with nanopolish variants for but have got a maximum of 16 threads available to me for that.  I've divided the ref into 50kb chunks as recommended and run several batches in parallel. Is it better to run fewer batches with more threads each or more batches with fewer threads? I could run one batch with 16 threads or 16 batches with 1 thread each and am wondering which dataset would be likely to be first to complete?
I have got nanopolish 0.9.0 installed but haven't noticed a huge amount of speed increase for that particular task.
Kind regards,
Anne

Hi Anne,
How big is the genome, how much coverage do you have for each sample and what SNP rate do you expect?
Jared

Hi Jared
genome: ~39Mb, coverage between 50x and 250x on average.
Anne

How long does it take to call on a 50kb segment for a single sample?
Jared

I've seen everything between 30 min and 1 day pass between samples of 50kb.
Anne

That indeed seems much too long. Can you paste the command and send me an output VCF file by email? It will help me figure out the problem.

We haven't got the parallel library installed so I'm creating a file full of batch coordinates  with nanopolish_makerange.py, divide it into however many parts I want to run in parallel and loop over them, which should in theory do the same thing:
lines=cat /data/anne_webb/fungi/fungus/variants/contig_bits_reference1.txt
for line in $lines; do
nanopolish variants --ploidy 1 -x 100000 -w $line -o ./fungus_72.$line.vcf -r /data/anne_webb/fungi/fungus/fungus_isolates_basecalled/fungus_72_albacore_trimmed.fastq -b /data/anne_webb/fungi/fungus/alignments/fungus_72_albacore_to_ref_bwa-mem_sorted.bam -g /data/anne_webb/fungi/fungus/reference_chromosomes/ref.fasta -t 4
done
(real file names anonymised)
Anne

Hi Jared
I’ll send you three. The first took 6 hrs to emerge, the second 5 and the third only 2hours.
Many thanks for looking into this!
Kind regards,
Anne
From: Jared Simpson<EMAIL_ADDRESS>Sent: 27 February 2018 15:47
To: jts/nanopolish<EMAIL_ADDRESS>Cc: Anne Webb<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [jts/nanopolish] optimisation of variant calling (#345)
How long does it take to call on a 50kb segment for a single sample?
Jared
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/jts/nanopolish/issues/345#issuecomment-368923168, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMTQYve40FXAc0h_38cSmyAJufizKqUtks5tZCOPgaJpZM4SVGqV.
This email and any files transmitted with it may contain confidential or privileged information which are intended for the addressee only. Access to this email by anyone else is unauthorised and any disclosure, copying, distribution or any action taken or omitted to be taken or reliance on it, is prohibited and may be unlawful. If you are not the named addressee or the person responsible for delivering the message to the named addressee, please delete the email and any attachments and contact<EMAIL_ADDRESS>For any information about NIAB or The Arable Group Limited, or for a copy of the Terms of Business, please contact +44 (0)1223 342200 or visit www.niab.com The NIAB group is comprised of the following distinct legal entities, all registered at Huntingdon Road, Cambridge, CB3 0LE : NIAB is a Charitable Company Limited by Guarantee | Registered in England : 3395389 | Registered Charity : 1064230 NIAB Trading Ltd | Registered in England : 07390289 The Arable Group Limited is a Charitable Company Limited by Guarantee | Registered in England: 192460 | Registered Charity: 212059 TAG Consulting Limited | Registered in England : 5110993 | NIAB EMR . Tel. 01732-843833. Registered in England No. 09894859. Charity registration No.1165055 | East Malling Services registered office: New Road, East Malling, Kent ME19 6BJ. Tel 01732-843833 Registered in England: 2335037
Disclaimer
The information contained in this communication from the sender is confidential. It is intended solely for use by the recipient and others authorized to receive it. If you are not the recipient, you are hereby notified that any disclosure, copying, distribution or taking action in relation of the contents of this information is strictly prohibited and may be unlawful.
This email has been scanned for viruses and malware, and may have been automatically archived by Mimecast Ltd, an innovator in Software as a Service (SaaS) for business. Providing a safer and more useful place for your human generated data. Specializing in; Security, archiving and compliance. To find out more visit the Mimecast website.

Hi Anne,
With that script I believe all tasks will be run at the same time - so in effect you'll use 4*N threads, where N is the number of 50kb regions. This might explain why it is so slow.
Jared

I don't believe it does, it produces 1 empty vcf file at a time which sits there until the process has run its course, then it gets filled with data and the next empty one appears, which suggests to me that it's iterating over the lines in succession.
Anne

Oh yeah you're right sorry. I'll take a look at the VCF files and get back to you.

Is it still slow without the -x 100000 option? This may slow it down considerably.

It used to be fairly slow, but it's been a while since I've run it without that option as I was getting lots of warnings about missed variant calls.

It looks like removing the -x 100000 option increases speed considerably!

Great, I'm glad to hear that.


.. operator is not highlighted properly

Description:
In [1..endValue] 1. is highlighted as a number but .. is an operator
Affected Product Version:
0.974.0
OS, DB, other environment details and versions:
vscode and cmposer

Now the operator has been changed to "..."


about eureka replication configuration?

it works as excepted with the following yml config.
eureka:
  instance:
    hostname: peer2
  client:
    serviceUrl:
      defaultZone: http://peer1:8761/eureka/

But the replication does not work as expected with the following config.
eureka:
  instance:
    hostname: peer2
  client:
     service-url:
     default-zone: http://peer1:8761/eureka/

The main differences are "serviceUrl" and "service-url",  "defaultZone" and "default-zone".
So shall I always use the first yml config for replication?

service url is a map, so the keys inside of it (defaultZone) are case sensitive.

but eureka client can successfully register to server with the following yml config
eureka:
  client:
     service-url:
     default-zone: http://peer1:8761/eureka/

Peer 1 is probably localhost? Which is the default

@spencergibb
hostname "Peer1" is mapping to <IP_ADDRESS>.
And I use eclipse with spring tool suite to edit the yml file, the property name is default to lower case with eclipse's autocomplete intelligence (e.g.  service-url, default-zone, enable-self-preservation, .., and so on).
so I' better use  camelCase style to set the property according to the docmentation, right?

defaultZone is case sensitive

So yes, peer one is localhost so it happens to work

Thanks for your quick response. ^^^^


Fixed optional decoding from decoder

try Entity(from: decoder) should be try? Entity(from: decoder) if the property is optional?

Sorry, I found this change is not needed.


Login UI Revamp

What is the current behavior?
Remove the main background Image
Remove the big card in the page and make the form fit like the login screen, both the sides have to stretch to the entire screen just like the reference image
The right background image does match the theme but does not match the purpose of fire short, maybe you could use a minimalistic vector design background, the animation is perfect!
Reduce Login Text size, make it center-aligned with the form
The main Fireshort logo should be removed to be just text like the logo you see in the admin panel on the top or on the loading screen.
What is the new behavior?
Changes applied, please have a look
Other information?

@niyasmhdth thanks for the changes, looks like you have opened a new PR any reason? Also can you please share the screenshot of the login screen now?

@niyasmhdth thank you for the changes here are the screenshots of the page currently:

As you can see even on a normal screen size the right side feature cards are cut off from the screen
The card is still present, it should be completely removed from and the form and the right side should fit the entire screen
The page is not at all responsive for smaller screens, after a certain point the right side should disappear and the form should take up the entire space on the page

@monizb there was an issue for my local git, so did a new PR, I'm new to git so sorry about that, Ok I'll work on the responsive side 👍🏽


about addArrowAnnotation

Is there a way to change the arrow's color? thanks!

Hey, how are you putting an arrow?

Oh, is it not in the source file? I have a function called addArrorAnnotation in the source file. It might be my lab colleague who added it.

Can you share it with me? I've been struggling with this for a few days trying to implement the function


WPA2 Enterprise not connecting

Hi, anyone was able to connect with a WPA2 enterprise network using Rust?
I'm trying with this code, but not luck by now:
`
let mut esp_wifi = EspWifi::new(modem, sysloop.clone(), None)?;
let mut wifi = BlockingWifi::wrap(&mut esp_wifi, sysloop)?;
unsafe {
    let ret1 = esp_idf_sys::esp_eap_client_set_ca_cert(CA_CERT.as_ptr(), CA_CERT.len() as i32);
    let ret2 = esp_idf_sys::esp_eap_client_set_identity(EAP_ID.as_ptr(), EAP_ID.len() as i32);
    let ret3 = esp_idf_sys::esp_eap_client_set_username(EAP_USERNAME.as_ptr(), EAP_USERNAME.len() as i32);
    let ret4 = esp_idf_sys::esp_eap_client_set_password(EAP_PASSWORD.as_ptr(), EAP_PASSWORD.len() as i32);
    let ret5 = esp_idf_sys::esp_eap_client_set_certificate_and_key(CLIENT_CERT.as_ptr(), CLIENT_CERT.len() as i32, CLIENT_KEY.as_ptr(), CLIENT_KEY.len() as i32, std::ptr::null(), 0);
    info!("Wifi Enterprise: {}:{}:{}:{}:{}", ret1, ret2, ret3, ret4, ret5);
    esp_idf_sys::esp_wifi_sta_enterprise_enable();
}

wifi.set_configuration(&Configuration::Client(
    ClientConfiguration {
        ssid: SSID.try_into().unwrap(),
        password: PASS.try_into().unwrap(),
        auth_method: AuthMethod::WPA2Enterprise,
        channel,
        ..Default::default()
    }
))?;

info!("Connecting wifi...");

wifi.connect()?;`

And the full log is:
Full log:
I (691) rust_esp32_c3_demo::wifi_wpa2: Starting wifi...
I (693) phy_init: phy_version 1150,7c3c08f,Jan 24 2024,17:32:21
I (736) wifi:mode : sta (7c:df:a1:b1:58:0c)
I (737) wifi:enable tsf
I (741) rust_esp32_c3_demo::wifi_wpa2: Scanning...
I (5845) rust_esp32_c3_demo::wifi_wpa2: Found configured access point UTFPR-SERVIDOR on channel 1
I (5846) rust_esp32_c3_demo::wifi_wpa2: Wifi Enterprise: 0:0:0:0:0
I (5854) rust_esp32_c3_demo::wifi_wpa2: Connecting wifi...
I (8270) wifi:new:<1,0>, old:<1,0>, ap:<255,255>, sta:<1,0>, prof:1
I (8538) wifi:state: init -> auth (b0)
I (9539) wifi:state: auth -> init (200)
I (9541) wifi:new:<1,0>, old:<1,0>, ap:<255,255>, sta:<1,0>, prof:1
I (9542) wifi:new:<6,0>, old:<1,0>, ap:<255,255>, sta:<6,0>, prof:1
I (9546) wifi:state: init -> auth (b0)
I (9557) wifi:state: auth -> assoc (0)
I (9573) wifi:state: assoc -> run (10)
I (20862) wifi:state: run -> init (0)
I (20864) wifi:new:<6,0>, old:<6,0>, ap:<255,255>, sta:<6,0>, prof:1
I (20865) wifi:new:<6,0>, old:<6,0>, ap:<255,255>, sta:<6,0>, prof:1
I (20868) wifi:state: init -> auth (b0)
I (20943) wifi:flush txq
I (20943) wifi:stop sw txq
I (20944) wifi:lmac stop hw txq
I (20946) esp_idf_svc::wifi: EspWifi dropped
I (20947) esp_idf_svc::netif: Dropped
I (20949) esp_idf_svc::netif: Dropped
I (20955) wifi:Deinit lldesc rx mblock:10
I (20959) esp_idf_svc::nvs: NvsDefault dropped
I (20963) esp_idf_svc::eventloop: System event loop dropped
Error: ESP_ERR_TIMEOUT
I (20971) main_task: Returned from app_main()
E (21871) wifi:timeout when WiFi un-init, type=11
Any ideas on this issue?

I'm seeing similar behavior. I didn't see it right away, as my main development machine is kept on rustc 1.75.0-nightly (8edb9b87e 2024-01-02), and my secondary machine is at 1.77.0-nightly(424037dcb 2024-03-18).
On the older version, wifi is able to connect without much issue.
On this newer version of rustc, I get the same behavior:
I (628) kasa_remote::wifi: Starting wifi...
I (628) phy_init: phy_version 620,ec7ec30,Sep  5 2023,13:49:13
I (668) wifi:mode : sta (48:27:e2:7f:c3:64)
I (678) wifi:enable tsf
I (678) kasa_remote::wifi: Connecting wifi...
I (18098) wifi:flush txq
I (18098) wifi:stop sw txq
I (18098) wifi:lmac stop hw txq
I (18098) esp_idf_svc::wifi: EspWifi dropped
I (18098) esp_idf_svc::netif: Dropped
I (18098) esp_idf_svc::netif: Dropped
I (18108) wifi:Deinit lldesc rx mblock:10
I (18118) esp_idf_svc::eventloop: System event loop dropped
Error: Could not connect to Wi-Fi network: ESP_ERR_TIMEOUT
I (18118) main_task: Returned from app_main()

@Paumanok, I don't think that's the case. I can connect to a personal network. My problem is with the WPA2 Enterprise network.
I tried the Rust version 1.75 and I have the same issue.

@Paumanok, I don't think that's the case. I can connect to a personal network. My problem is with the WPA2 Enterprise network. I tried the Rust version 1.75 and I have the same issue.

So I did some more testing after my original response, I was able to connect to my home router's WPA2 network. My issue was in a raspberry pi I've been using as a development network, which it can no longer connect to, which is WPA-PSK.
I was unable to downgrade to 1.75 manually as well, as the 1.75-nightly is no longer available. Standard 1.75 didn't work.
I'm wondering if there was some regression that may have a common cause.

Coming back to say, beginner mistake and I didn't downgrade the actual esp toolchain.
going back to 1.75 via
espup uninstall
espup install --toolchain-version <IP_ADDRESS>

Fixed my wifi connection for now, but the issue is still there with 1.77

did you do your test always with a debug build or did you build with --release. Its unlikely that there is something in the compiler itself that is causing it, probably more of a site effect.

ALL: Read this: https://github.com/esp-rs/esp-idf-svc/issues/304#issuecomment-2365053299


[BUG] Mouse moves when i move camera in roblox

I am playing roblox but when i move the camera the mouse moves too it started after playing one game and it's so annoying!!!

This is a Roblox issue, Not a Bloxstrap issue. Restarting your PC will temporarily fix the problem. There is no permanent solution yet.


Make gitpod initialize on startup

I think Codespaces makes this obsolete now that everyone can use it.

@dsyer Is Codespaces free?

Hmm maybe not. If is for me but maybe individuals with no special org permissions can’t see it yet. I think Microsoft plan to open it up but maybe not yet? Let us know what your experience is.

@dsyer Where have you seen the plan of open sourcing it? I currently can't have access to the Codespaces buttons.


⚠ Bofrost.at has degraded performance

In 43ebf4e, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1768 ms

Resolved: Bofrost.at performance has improved in ac56c8c.


Array opcodes

I should make some opcodes for things like arr[x] = c for 2d arrays (setting a constant to a row/column) (setrow/setcol that outs a 2d array and takes a constant and an index)

hmm this is cute:
kArr = setrow(getrow(kArr, 0) + 2, 0)

can I define a udo with the same name? kinda overloading setrow and setcol?
[jetrow voice] I am setrow! lol

can I define a udo with the same name? kinda overloading setrow and setcol?
you can, but should you? be confusing as fuck to people who see some code that uses a known opcode in some unusual fuckery

I'm just gonna define a lazy setrow/col(inputArray, val, index)

I should define my own setrow/setcol udo's anyways (input arrays and everything) to test the segfault in test/2dArr.csd
test that and then overload them with constant versions

dimension! (my new word for "this plan is fucked")

dimension! (my new word for "this plan is fucked")

lenarray(getrow(arr, 0))
lenarray(getcol(arr, 0))

you ever think about how the length of the column is the number of rows and the length of the row is the number of columns? it's so cute!

int32_t set_cols_init(CSOUND *csound, FFT *p) {
     int32_t siz = p->in->sizes[0];
     int32_t col = *((MYFLT *)p->in2);
     tabensure2D(csound, p->out, siz, col+1);
     return OK;
 }

so if my greek isn't totally gone this means that it will set something according to the i-time length of the input column, which in the case of using a fillarray-generated array it won't exist, that's why the segfault happens? I gotta try to edit this sometimes and see how it goes?

currently in test/2dArr2.csd, move them to opcodes
check out genarray-setrow/setcol combinations

i'm set for now, will reopen if i need more

...i-time length of the input column, which in the case of using a fillarray-generated array it won't exist...

lmao! silly girl! you didn't understand the why behind the why!
i think if that k-variable was inited it would've had no problem working with it.

means that it will set something according to the i-time length of the input column

this is because setrow/setcol will generate output arrays if they don't exist, that's why they need to error check against the input arrays


Segmentation violation / unexpected fault address in runtime

What version of Go are you using (go version)?

$ go version
go version go1.12.6 darwin/amd64

Does this issue reproduce with the latest release?
This is the latest release
What operating system and processor architecture are you using (go env)?
$ go env
GOARCH="amd64"
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOTOOLDIR="/usr/local/Cellar/go/1.12.6/libexec/pkg/tool/darwin_amd64"
GOROOT="/usr/local/Cellar/go/1.12.6/libexec"

Expected output: byte array / map[int][]byte should return from function / pointer deallocation should work
Output:
unexpected fault address 0x165649f
fatal error: fault
[signal SIGSEGV: segmentation violation code=0x1 addr=0x165649f pc=0x109ecee]

Proof of Concept:
https://gist.github.com/Varunram/4dd7af00be21e018906e1fb64318aec8
Note to reviewers: Since I don't know under which category this bug falls under, please change the issue title, thanks!

There are 2 separate issues in your code-

In b := tx.Bucket(bucketName), it returns nil if bucket does not exist. So that is the cause of your first segfault.

Now to the real issue, see the documentation of (*bucket).Get - https://godoc.org/github.com/boltdb/bolt#Bucket.Get

The returned value is only valid for the life of the transaction.

So the underlying slice is cleared when the tx finishes. You need to fix it by initializing arr and then copying to it.
if arr == nil {
	arr = make([]byte, len(x))
}
copy(arr, x)

instead of arr = x
I will go ahead and close this since this is working as intended and not an issue with Go.

@agnivade The bucket creation bug was on me - I created the bucket inside the test function, so that was why it returned an error. But your fix regarding the slice still stands. (ie you could copy the slice onto the map and it should work fine). Thanks for the response!


[10.x] listen method in Dispatcher should return void

I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework.
Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.
Thanks!


[Documentation]  :  Wanted To Add Contributing.md

I wanted to add the contributing.md file which will help the contributors to easily contribute. It will also help them understand the correct way of following coding practices and other important things.
Wanted to do the following changes :-

Enhance the project structure
Add code of conduct section
Add star our repository section
Add need help with the basics section
Add first pull request steps section
Add additional method of contributing through GitHub desktop section
Add good coding practices section
Add the pull request rules section
Add the thank you section

@milansamuel609  it is already there

@milansamuel609 it is already there

Actually I have not seen it just saw the Readme.md file. But no issue 👍 .


Mapping using hostname does not work

Describe the bug
Using "hostname" in mapping does not work, but "host" works.
To Reproduce
Steps to reproduce the behavior:

Install emissary-ingress using helm chart:

helm repo add datawire https://app.getambassador.io
helm repo update
kubectl apply -f https://app.getambassador.io/yaml/emissary/3.3.0/emissary-crds.yaml
kubectl wait --timeout=90s --for=condition=available deployment emissary-apiext -n emissary-system

helm install -n emissary --create-namespace \
     emissary-ingress datawire/emissary-ingress && \
 kubectl rollout status  -n emissary deployment/emissary-ingress -w

Notice deployment " emissary-ingress-agent" and "emissary-ingress" are using different version of the image:

apiVersion: apps/v1
kind: Deployment
metadata:
  name: emissary-ingress-agent
  namespace: default
  labels:
    app.kubernetes.io/name: emissary-ingress-agent
    helm.sh/chart: emissary-ingress-8.3.0
    app.kubernetes.io/instance: emissary-ingress
    app.kubernetes.io/part-of: emissary-ingress
    app.kubernetes.io/managed-by: Helm
    product: aes
spec:
 ...
    spec:
      serviceAccountName: emissary-ingress-agent
      containers:
      - name: agent
        image: docker.io/emissaryingress/emissary:3.1.0
...
apiVersion: apps/v1
kind: Deployment
metadata:
  name: emissary-ingress
  namespace: default
  labels:
    app.kubernetes.io/name: emissary-ingress
    helm.sh/chart: emissary-ingress-8.3.0
    app.kubernetes.io/instance: emissary-ingress
    app.kubernetes.io/part-of: emissary-ingress
    app.kubernetes.io/managed-by: Helm
    product: aes
spec:
  replicas: 3
  selector:
    matchLabels:
      app.kubernetes.io/name: emissary-ingress
      app.kubernetes.io/instance: emissary-ingress
  strategy:
    type: RollingUpdate

  progressDeadlineSeconds: 600
  template:
    metadata:
      labels:
        app.kubernetes.io/name: emissary-ingress
        helm.sh/chart: emissary-ingress-8.3.0
        app.kubernetes.io/instance: emissary-ingress
        app.kubernetes.io/part-of: emissary-ingress
        app.kubernetes.io/managed-by: Helm
        product: aes
        profile: main
  ...
      containers:
        - name: emissary-ingress
          image: docker.io/emissaryingress/emissary:3.3.0

Configure a mapping using "hostnmae"
Observe the mapping doesn't work

Change the mapping to use "host"
Observe the mapping now works.

Expected behavior
Routing using the mapping should work.
Versions (please complete the following information):

Ambassador: [e.g. 3.3.0]
Kubernetes environment: EKS
Version: 1.23

Additional context
Add any other context about the problem here.

Additionally, "hostname" in Host doesn't work.
The following configuration fails to work:
apiVersion: getambassador.io/v3alpha1
kind: Listener
metadata:
  name: emissary-ingress-listener-8443
  namespace: emissary
spec:
  port: 8443
  protocol: HTTPS
  securityModel: SECURE
  hostBinding:
    namespace:
      from: ALL
    selector:
      matchLabels:
        external-hosts: "true"
---
apiVersion: getambassador.io/v3alpha1
kind: Host
metadata:
  name: host-external
  namespace: emissary
  labels:
    external-hosts: "true"
spec:
  hostname: "server.example.com"  <<<<<<<<< Removing this line it will work.
  acmeProvider:
    authority: none
  tlsSecret:
    name: emissary-selfsigned-cert
    namespace: emissary
  selector:
    matchLabels:
      external-mapping: "true"
---
apiVersion: getambassador.io/v2
kind: Mapping
metadata:
  name: server
  namespace: emissary
  labels:
    external-mapping: "true"
spec:
  # host: "server.example.com"
  prefix: /
  service: server:3002

When "hostname" is removed from Host and "host" is enabled in Mapping it will start working.

Update: once I started using "apiVersion: getambassador.io/v3alpha1" for Mapping, the "hostname" field does work.
However, "hostname" field in Host still does not work.
This is the updated code:
apiVersion: getambassador.io/v3alpha1
kind: Listener
metadata:
  name: emissary-ingress-listener-8443
  namespace: emissary
spec:
  port: 8443
  protocol: HTTPS
  securityModel: SECURE
  hostBinding:
    namespace:
      from: ALL
    selector:
      matchLabels:
        external-hosts: "true"
---
apiVersion: getambassador.io/v3alpha1
kind: Host
metadata:
  name: host-external
  namespace: emissary
  labels:
    external-hosts: "true"
spec:
  hostname: "server.example.com"  <<<<<<<<< Removing this line it will work.
  acmeProvider:
    authority: none
  tlsSecret:
    name: emissary-selfsigned-cert
    namespace: emissary
  selector:
    matchLabels:
      external-mapping: "true"
---
apiVersion: getambassador.io/v3alpha1
kind: Mapping
metadata:
  name: server
  namespace: emissary
  labels:
    external-mapping: "true"
spec:
  hostname: "server.example.com"  <<<<<<<<< This works after removing hostname from Host
  prefix: /
  service: server:3002


kernel/timeout: Remove "clock_always_on", replace with "SLOPPY_IDLE"

This is an oddball API.  It's untested.  In fact testing its proper
behavior requires very elaborate automation (you need a device outside
the Zephyr hardware to measure real world time, and a mechanism for
getting the device into and out of idle without using the timer
driver).  And this makes for needless difficulty managing code
coverage metrics.
It was always just a hint anyway.  Mark the old API deprecated and
replace it with a kconfig tunable.  The effect of that is just to
change the timeout value passed to the timer driver, where we can
manage code coverage metrics more easily (only one driver cares to
actually support this feature anyway).
Signed-off-by: Andy Ross<EMAIL_ADDRESS>

Sorry, could have sworn I fixed that.  Fixed now.


net::ERR_NAME_NOT_RESOLVED

https://pokeres.bastionbot.org/images/pokemon/{pokemon.id}.png not work

That's not our domain

Yeah I saw a moment later, they use this page to show better images than the actual ones, but I have to re-read the documentation to use the correct one

No need for the docs
The image URLs are in the sprites property of the pokemon endpoint
https://pokeapi.co/api/v2/pokemon/bulbasaur


DLRM ubench failing, possibly due to FBGEMM API update

Traceback (most recent call last):
  File "dlrm/ubench/dlrm_ubench_train_embeddingbag_driver.py", line 207, in <module>
    global_elap, global_bytes = run_emb(args, run_dataset)
  File "dlrm/ubench/dlrm_ubench_train_embeddingbag_driver.py", line 104, in run_emb
    requests = bench.split_table_batched_embeddings_benchmark.generate_requests(
TypeError: generate_requests() got an unexpected keyword argument 'weights_precision'

due to https://github.com/pytorch/FBGEMM/commit/4c581375

cc: @jianyuh @nrsatish


chore(guidelines): Fixes guidelines and blueprints to follow the changes done for themes

Closes #337

Deploy preview for pf-next ready!
Built with commit 440bff8879fef353b32999b0b18bb05a8890dbd2
https://deploy-preview-381--pf-next.netlify.com


vault: 1.5.5 -> 1.6.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/hashicorp/vault/releases.
meta.description for vault is: "A tool for managing secrets"
meta.homepage for vault is: "https://www.vaultproject.io/"
meta.changelog for vault is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.6.0 with grep in /nix/store/la60hv6132bgplgk1k9qr9ac8mazha0s-vault-1.6.0

directory tree listing: https://gist.github.com/f8eedf213299c8e4c1eb16dd741de774

du listing: https://gist.github.com/cc6fcca143ca1817d6d8c8620b0dca98

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
vault

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/la60hv6132bgplgk1k9qr9ac8mazha0s-vault-1.6.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A vault https://github.com/r-ryantm/nixpkgs/archive/e22d0c28beb128cecb72572c39b40112aa3a4ab3.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/la60hv6132bgplgk1k9qr9ac8mazha0s-vault-1.6.0
ls -la /nix/store/la60hv6132bgplgk1k9qr9ac8mazha0s-vault-1.6.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Are the test freezes related to the update?

vault 1.6.0 is already on master.


Allow running native hosts messaging as default when binary is renamed

This change uses jsonapi listen as default action if the binary is renamed / copied to gopass_native_host or gopass_native_host.exe . This makes gopass compatible with windows browsers, which require an executable and not a script to be called.
I would test this a bit with some windows users and add automated setup and / or documentation later on. Does that make sense?

LGTM, Thanks a lot!


--first doesn't match from very beginning

--first --pattern 44xmr also produces other addresses like ones starting with 444xmr..
To reproduce: while ! monero-vanity --first --pattern 44x | grep -A99 -B99 ' 444x' ; do clear; done
This is a very minor issue that's easily worked around by adding ^ to the pattern, but may be worth fixing at least in the docs.

Right, what --first actually does is give you full control over the regex, it should be more  clear.
PR to fix is welcome.


Vuex template types.d.ts file integration

It would be cool if the vuex template could also contain types.d.ts out of the box. Let me know if you need a PR for it.

Hi, I'll look into it. Sorry I haven't seen the issue until now

AFAIK this is already implemented in v1.3.0. If the implementation doesn't suit you feel free to reopen the issue


Error during send_web_push/2 - HTTPoison

This issue is a bit tricky and might be an result of me changing deps for JOSE from 1.8 to 1.11.1.
In the best of worlds, the problem should have been isolated (The dep seems to be unrelated, but my options to isolate the problem is limited in how to proceed doing just that)
The reason for me upping the version on Jose dep was that I needed support for JWK from_der (private key). After making that feature change to the code, I was able to start using send_web_push but entered an unexpected problem.
WebPushEncryption.send_web_push(body, sub1) WebPushEncryption.send_web_push(body, sub1) {:error,  %HTTPoison.Error{    id: nil,    reason: {:options,     {:sslv3, {:versions, [:"tlsv1.2", :"tlsv1.1", :tlsv1, :sslv3]}}}  }}
During some searches on the subject, some solutions suggests that this could be resolved by adding a option to the request.
In this case the post made by HTTPoison in web_send_push function.
Will include a PR with suggested solution.
You have to pardon me if I have made any erroneous assumptions or mistakes (started coding in Elixir this Tuesday so not even 7 days yet) a lot new tech to learn at the moment.

thank you @danhper for this great project!


add linting

@AsfaMumtaz Image is available for testing. docker pull stakater/workshop-excercise:SNAPSHOT-PR-47-3c7c42fe