README.md: WebStorm/PhpStorm support

This (hopefully) fixes feross/standard#247
Before merging: dear WebStorm/PhpStorm users, can you try to reproduce my steps and share an outcome here?

@feross, it might be time to have a docs/ folder for standard to refactor the ever-growing README.md.
docs/editor-integration.md
docs/webstorm.md
docs/formatter.md
...

These instructions are currently too long to add to the middle of the current readme.
@jelz Can you create a docs/ folder and put these into a webstorm.md file that's linked from the readme?

@feross If you wish I can extract all IDE/editor support docs (not only my WebStorm instruction) into separate files.
Either way I'll take care of this PR tomorrow in the evening or during the weekend, depending on my workload.

Let's leave the other editor's instructions where they are since they're pretty short. I like that most users can follow the instructions without needing to go to any other pages.
Thanks - looking forward to your updated PR.

Updated and rebased onto master.

LGTM. Thanks!


Cannot use "Select All" on iOS

When I try to use the "Select All" button from the long-press contextual menu on iOS, the cursor goes to the end of my script but my text isn't selected.
The problem appears in the version 5.25.0.
If you want to try it :

Fiddle with version 5.24.0 when it worked : https://jsfiddle.net/az1ke5zz/3/
Fiddle with version 5.25.0 when it doesn't work anymore : https://jsfiddle.net/az1ke5zz/4/

After some deeper research, it looks like the commit that broke the functionality is  1d00df9e9e6ced8516a3400e3f4bdb8147ab514d and more specifically the removal of the following CSS :
.CodeMirror-gutter-wrapper {
  -webkit-user-select: none;
  -moz-user-select: none;
  user-select: none;
}

What was the reason for removing it ?

Interested in this as well. Seems like add that back in fixes the issue.

Also interested in this fix.

I cannot answer your question, but we are working on a rewrite (CodeMirror 6) that will overhaul input handling and could address this issue. We are currently raising money for this work: See the announcement for more information about the rewrite and a demo.
Note that CodeMirror 6 is by no means stable or usable in production, yet. It is unlikely that we pick up this issue for CodeMirror 5, though.


formatCode

how to formatCode when init data

An editor instance was returned in mounted，you can use  editor.trigger('', 'editor.action.format')


Create and map new route: private domains not available

Stratos Version
4.0.1
Frontend Deployment type

[x ] Cloud Foundry Application (cf push)

Backend (Jet Stream) Deployment type

[x] Cloud Foundry Application (cf push)

Expected behaviour
A private domain can be used for "Create and map new route"
Actual behaviour
A private domain is not available from the ui so that i can't choose the private domain for mapping the route
Steps to reproduce the behavior
Share a private domain with an organization.
Then try to create and map a route using the private domain.
Log output covering before error and any error statements
no logs available

Hi @PG2000 Thanks for raising this. I've tried to reproduce this locally with no joy. Could I confirm...

Where you created the private domain? We don't have domain management in stratos and the cli creates a private domain with an org already assigned (just trying to match your steps exactly)
What type of Cloud Foundry are you using (KubeCf, cf-for-k8s, etc)?

HEy @richard-cox
to answer your questions:

The domain exists already within our platform for a long time and is mapable over the cli

if i do this:
cf target -o some-org -s some-space

cf domains

`Getting domains in org some-org as xxxx...
name                                          status   type   details
apps.internal                                 shared          internal
dev.example.io            owned`

cf map-route my-app dev.example.io

then i can map the route.
in Stratos i try to map this route to an app over the ui and didn't see the domain dev.example.io

We're using PCF

Which version of the cli are you using?
In my ageing 6.51.0 it looks like the cli makes two requests, v2/shared_domains and /v2/organizations/<org guid>/private_domains rather than directly with v2/spaces/<space guid>/domains.
Could you try the following?
cf curl /v2/spaces/<space guid>/domains

You can find the space guid, after targeting the org, with cf space <space name> -v and look for similar requests

I'm using the cf api Version 6.53
yes you're right. He did two requests
If i try:
cf curl /v2/spaces/<space guid>/domains
then it doesn't show the dev.example.io

Unfortunately, at the moment, yes. I've asked the core cf api team what the expected behaviour of that endpoint should be. Depending on the answer this may be an issue you will need to take up with PCF directly.

Ok, we think we've worked it out (see https://cloudfoundry.slack.com/archives/C07C04W4Q/p1605173226207800 for details). The domain that's missing in stratos is likely to be a shared private domain, these aren't shown in a number of domain endpoints (see https://github.com/cloudfoundry/cloud_controller_ng/issues/595 for details). I think this is an oversight and seems to be addressed in v3 of the api. We don't currently support this but will do in the future, unfortunately I cannot provide a timeline.
If you'd like to confirm the missing domain is a shared private one you can run the following command
cf curl v2/organizations/<org guid that contains your space>/private_domains

You should see the missing domain there and it will have a different owning_organization_guid to the one in the url

thx a lot for figuring this out. @richard-cox


chore: Optimizing the solution for supporting tenant config on admin settings

Description
Optimizing the solution for supporting tenant config on admin settings
PR fixes following issue(s)
Fixes # (issue number)
Type of change

Chore (housekeeping or task changes that don't impact user perception)

Testing
How Has This Been Tested?

[x] Manual
[ ] Jest
[ ] Cypress

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test


IndexRedirect not found

these are my routes:
<Route component={Index} path="/">
  <IndexRoute component={Home} />
  **<Route path="polls" component={Polls}>
    <IndexRedirect to="active" />
    <Route path="active" tab="active" component={About} />
    <Route path="popular" tab="popular" component={About} />
    <Route path="new" tab="new" component={About} />
    <Route path="create" component={About} />
  </Route>**
  <Route path="polls/:id" component={Chart} />
  <Route component={Login} path="login" />
</Route>

I have in my navbar a Link to "/polls" which redirects me to "/polls/active". Perfect!
However, when I copy the entire url (in my case: http://localhost:3000/polls), and paste it into the address bar and press enter, I get a 404 not found.
When I removed the children (<Route path="polls" component={Polls} />) I didn't have this problem.
Any ideas?

Are you using server side rendering? If so, how do you have that set up? It sounds like you're not handling the redirect case properly.
I'm going to close this because it's not a bug report. You'll have better luck posting on Stack Overflow or on Reactiflux.


Missing highlights with diffNuisances latex format

The automatic highlighting of extreme nuisances in diffNuisances doesn't work for nuisances with underscores when using the latex format option. I solved it locally by moving L324 after L328 (so the underscore replacement only affects the printout and not the lookup)
https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/blob/f402bff923cd3ee28119b7bf19ed6ec127c0e990/test/diffNuisances.py#L324-L328

Dear @aminnj ,
Thanks for pointing this out. Do you think you could make a pull request to the 81x-root606 branch with your fix?
Thanks

Sure! done: https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/pull/524


Game broken

When attempting to access this at https://GH-DEV-WS-MNIT.github.io/github-games-byklearning, I am getting a 404. This could be caused by a couple of things:

GitHub Pages needs to be enabled on the  branch. You can fix this in the repository settings.
The index.html file is incorrectly named inde.html. We will fix this together in class.

Can you fix the first bullet, please?

renamed the index.html file name from inde.html


Readme fix

**Issue reference: https://github.com/RajVarsani/html-archives/issues/10
**Proposed changes: Fix Readme file typo's
**Type of change: Made changes in Readme file
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Other (please specify)
[ ] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

Additional info (if any):

Great work spotting the bugs and resolving them!
Kudo to you @con-artist
Thanks for your contribution.


Problem with using target lib in nuxt

Version
3.2.0
Environment info
macOS 10.14.2
node 10.14.1
vue-cli-servise 3.2.0

Steps to reproduce

build components using vue-cli-service build --target lib ./src/index.ts and in vue.config.js css.extract=false
import builded component in nuxt page (universal mode)

What is expected?

all works as expected

What is actually happening?

error in browser http://joxi.ru/LmGap0bCwwRW0A

I have private repository with vue components. And cannot provide source code
It is simple SFC with template(html), script(lang=ts) and style(lang-scss)

You're accessing document, which is not available during SSR.
This is not a problem with vue-cli - you just have to write  our component in a way that works with SSR.
since you can't share source, i can't tell you how to do that either.

Well, you can always wrap your component in a <no-ssr> component:
https://nuxtjs.org/api/components-no-ssr
Or you fix your component's business logic/implementation to only access document when it actually exists.

It's added by vue-cli-service build --target
I don't extract css, for minimal project build, when I don't use all components.
I have repo with minimal build https://github.com/dschewchenko/vue-components

Maybe I may to have 2 bulid targets. One for node(vue-style-loader) and second for browser. And how I can do it with vue-cli?

It's as easy as
// vue.config.js
module.exports = {
  configureWebpack: {
    target: 'node'
  }
}

@sodatea I know that it's easy. But I don't know to make 2 different builds using vue-cli

use an environment variable and run the command twice
use this plugin: https://github.com/jkzing/vue-cli-plugin-multi-compiler/

@dschewchenko Please нelp me solve this problem! I'm very upset

up?


Indicated when updated version is available

Since we use service workers, users may be using a cached version of Lumen without realizing that there are updates available (You need to refresh a couple of times to clear the service worker cache).
We should indicate when updates are available and make updating to the latest version easy.
From rosebud.app:

why not use vitePWA? it provides a simple way to display the update prompt (and many other things).

@Pkcarreno That sounds awesome. I hadn't heard of vitePWA. Are you interested in opening a PR?

Sure!
In order to make it work properly we have to migrate the manifest and the workbox to the vitePWA config and remove any reference to manual injection of SW, the config should look like this:
vitePWA({
  //...
  manifest: {
    //...
  },
  workbox: {
    //...
  }
})

vitePWA is responsible of generating the workbox and the injection process, so the execution of npm run build:service-worker should be removed from the workflow.
For the end user there shouldn't be any difference when using the app, but I would still do some testing before launching it.
After that migration we can start implementing the update prompt. For this do you have any idea of how it should look like?
In this app I worked 2 update flows, the first one is an alert with sonner where it shows suddenly that there is an update, if the user doesn't click during the seconds that it is shown it remains as a button in the menu with the action to update. The idea of these flows I took from Todoist.
Btw, I just discovered this app and I think it's great, good job 👍

@Pkcarreno Oh sorry, I didn't realize you were waiting on me for the design. Do you want to take a stab at the design and I can review?

@colebemis for sure! I'll take a look at it over the weekend.


Second Review of Rate Base

Hi again @jrea-rmi  let's do this review again! Follow up #3479
This that are still in progress:

#3309
#3530 (the files below have a first draft of breaking down the utility type but not the null rate base tags.. progress in #3532)

Jon, if you'd rather wait until those two things are wrapped up just let us know!
Files:

out_ferc1__yearly_rate_base.pkl.zip
out_ferc1__detailed_balance_sheet_assets.pkl.zip
out_ferc1__detailed_balance_sheet_liabilities.pkl.zip
forest_as_table_core_ferc1__yearly_balance_sheet_assets_sched110.pkl.zip
forest_as_table_core_ferc1__yearly_income_statements_sched114.pkl.zip

Plotz

by input table & utility

@cmgosnell  This is looking pretty dang good. Here's what I see so far.
Checks that looked correct:

most steam, nuclear, hydro, other_production, transmission, distribution values match very closely between old & new results. Differences are most common in nuclear & steam, likely because of ARCs (outstanding question for RMI as to how we want to deal with these)
I checked several cases of the utility type breakdown of records that correspond to all utility types. These all looked correct! (SCE, Duke Progress, Duke Florida in 2020. Consumers across multiple facts.).

Checks that didn't match expectation

cash_working_capital calculation didn't match what I expect.
Duke Florida 2020 should be<PHONE_NUMBER>/8 = 343,599,001 but it is 188,515,086.4
Duke Progress 2020 should be<PHONE_NUMBER>/8 = 368,607,898 but it is 201,277,526.4
Consumers 2014 should be<PHONE_NUMBER>/8 = 367,268,734.8 but it is 180,603,569
the ratio for each of these is 1.82, 1.83, 2.0. Is there a fraction being applied to records with is_breakdown_tags_in_rate_base = True?

Questions for Catalyst:

should records with null ending_balance be removed?
only a few corrections have non-null tags_rate_base_category. At least some of these cases could be labeled - for example, xbrl_factoid "distribution_plant_correction" for utility_id_ferc1 230 in year 2021 could be labeled as tags_rate_base_category="distribution". Should other corrections have tags_rate_base_category="other"?
what's the purpose of the column "is_breakdown_tags_in_rate_base"? All cases that are True are either cash_working_capital or corrections. Why is cash_working_capital labeled True here? Are these correction records cases where part of the correction corresponds to something in rate base, and part corresponds to something out of rate base? If so, can we estimate the amount of that correction that's in rate base, using fraction of that xbrl_factoid that's in rate base?

Review still to do:

detailed comparisons of why the "other" category is very different compared to previous results. We changed many tags, so I'm not surprised, but detailed review will give more confidence in updated results.

Major outstanding questions for RMI:

what tags do we want to use for ARCs and AROs? In the current output, AROs are not in rate base and ARCs are included in the category of their ferc class. If ARCs are included, AROs probably should be too. Last time, we included both and separated ARCs to be differentiated as their own category rather than steam/nuclear/hydro/other.

hey @jrea-rmi  thanks for all of this!

cash_working_capital calculation didn't match what I expect.
Duke Florida 2020 should be<PHONE_NUMBER>/8 = 343,599,001 but it is 188,515,086.4
Duke Progress 2020 should be<PHONE_NUMBER>/8 = 368,607,898 but it is 201,277,526.4
Consumers 2014 should be<PHONE_NUMBER>/8 = 367,268,734.8 but it is 180,603,569
the ratio for each of these is 1.82, 1.83, 2.0. Is there a fraction being applied to records with is_breakdown_tags_in_rate_base = True?

Yes! This is_breakdown_tags_in_rate_base indicates that this record got broken up between in rate base and not in rate base bc it wasn't labeled w/ tags_in_rate_base == "yes" which is silly because we are building that factoid from semi-scratch. I will add the tags_in_rate_base == "yes" into the creation of the cash_working_capital factoid and this breakdown will no longer be applied! good catch!

should records with null ending_balance be removed?
I certainly could remove them! That seems like a fine idea especially at this stage.

only a few corrections have non-null tags_rate_base_category. At least some of these cases could be labeled - for example, xbrl_factoid "distribution_plant_correction" for utility_id_ferc1 230 in year 2021 could be labeled as tags_rate_base_category="distribution". Should other corrections have tags_rate_base_category="other"?

All of the corrections got the same tag as their parent fact. So this distribution_plant_correction is correction the distribution_plant xbrl_factoid's calculation and the correction inherited all of the tags and attributes of the parent. We could either add tags for all the corrections (or just add em to their parents) or we could attempt to propagate the existing tags. We are currently propagating the just the tags_in_rate_base tag to any child facts or parent facts which have children that all share the same tag. I wasn't sure if we should do this tag propagation for the other tags. I'll pull out a list of all of the unlabeled corrections to see if that will be easier to tag and go poke at just applying the tag propagation to other tags to see how challenging & effective it would be.

what's the purpose of the column "is_breakdown_tags_in_rate_base"? All cases that are True are either cash_working_capital or corrections. Why is cash_working_capital labeled True here? Are these correction records cases where part of the correction corresponds to something in rate base, and part corresponds to something out of rate base? If so, can we estimate the amount of that correction that's in rate base, using fraction of that xbrl_factoid that's in rate base?

You've got the right idea here generally. The two is_breakdown_* columns indicates whether or not an xbrl_factoid as originally reported is being broken down either as in rate base or not in rate base or broken down from utility_type total into various non-total/non-null utility types  #3532. It makes sense that only the corrections have this in_rate_base breakdown because you gave me a pretty complete tagging on the most granular xbrl_factoids and the correction records are always generated from factoids that are less granular.

Sounds good on most of these!
The 3 current non-correction xbrl_factoids with null tags_rate_base_category have tags_aggregatable_utility_type = gas. We never comprehensively made tags_rate_base_category for gas rate base. So open to suggestion. With a quick review, it seems like these 3 facts could all get a tag of net_utility_plant.
Here are my suggested tags for the 15 correction factoids without categories.
{
'utility_plant_net_correction': 'utility_plant_correction',
'utility_plant_net_subdimension_correction': 'utility_plant_correction',
'accumulated_depreciation_subdimension_correction': 'utility_plant_correction',
'depreciation_utility_plant_in_service_off_by_amortization_of_other_utility_plant_utility_plant_in_service_correction': 'utility_plant_correction',
'electric_plant_in_service_and_completed_construction_not_classified_electric_correction': 'utility_plant_correction',
'production_plant_correction': 'utility_plant_correction',
'depreciation_utility_plant_in_service_subdimension_correction': 'utility_plant_correction',
'utility_plant_and_construction_work_in_progress_correction': 'utility_plant_correction',
'accumulated_provision_for_depreciation_amortization_and_depletion_of_plant_utility_subdimension_correction': 'utility_plant_correction',
'accumulated_provision_for_depreciation_amortization_and_depletion_of_plant_utility_correction': 'utility_plant_correction', 'utility_plant_and_construction_work_in_progress_subdimension_correction': 'utility_plant_correction',

'deferred_debits_correction': 'other_deferred_debits_and_credits',
'deferred_credits_correction': 'other_deferred_debits_and_credits',

'assets_and_other_debits_correction': 'correction',
'liabilities_and_other_credits_correction': 'correction'
}

The outstanding question I have is the one on cases where is_breakdown_tags_in_rate_base=True. If these are all corrections, and part of that line is in rate base and part is not, it's hard to tell whether we should include some value in our rate base estimate. A default could be to exclude from rate base - so take them out of this rate base table, though they'd stay in the balance sheet breakdown table. An upgrade to that default would be if we can find out for that given utility, if all components within the xbrl_factoid that is being corrected are in rate base or not, then the correction should be labeled as fully in or out of rate base. A questionable case would be if the xbrl_factoid being corrected does really have mixed in rate base or not components, and we could calculate the fraction of that correction that should be in rate base.
That may also have implications for the 15 correction tags I listed above. Considering the last 4, I think all of these would either be simply excluded from rate base or we calculate the fraction of them that should be included.

hey @jrea-rmi !! thank you for this suggestions and tags. I would suggest adding the tags w/o the _correction suffix if that is okay with you. Mostly because right now we don't add correction into any of the tags. We could! but i would want to do it across the board.
I appreciate the extra insight into the is_breakdown_tags_in_rate_base break down. For all/any of these we can directly tag them as in or out of rate base for sure so I will add "no"s for those last four! These correction records are the corrections for the leafy/granular records across the detail tables that feed into this rate base table but yea i think you are totall right that these broken down corrections are not necessarily connected to the in_rate_base==True xbrl_factoids. we could check weather factoid x has any children in the tree that are in_rate_base==True. but there aren't that many of these so I would suggest just id-ing them like you just did here with these last four because adding those tags will be very straightforward!

okay @jrea-rmi  i tagged the last four facts as not in rate base and because we propagate tags to related facts when all other children or parent facts get the same in_rate_base tag most of these is_breakdown_tags_in_rate_base corrections got automatically tagged as not in rate base! so your hunch on all these was spot on.
Here is a new version of the table:

out_ferc1__yearly_rate_base.pkl.zip

Right now (w/ that new tag addition and dropping all null ending_balance) there are only two xbrl_factoids that are is_break_down_tags_in_rate_base==True:
out_ferc1__yearly_rate_base[
    out_ferc1__yearly_rate_base.is_break_down_tags_in_rate_base==True
].xbrl_factoid.value_counts()

xbrl_factoid
current_and_accrued_liabilities_correction    94
liabilities_and_other_credits_correction       4
Name: count, dtype: Int64

okay @jrea-rmi  i did a tiny bit of digging into these two remaining partially in rate base correction factoids. From my vantage it seems like these are truly partially in rate base but I'd love to get your opinion!
liabilities_and_other_credits_correction  (xbrl link)
this is the correction record for the seed node of the liabilities graph (which is to say it is the least granular/total of all of the other totals/calculated fields. So these 4 correction records represent some error found between the liabilities' seed node and the first layer of calculation sub-components. since there are definitely liabilities in the rate base table overall it would seem to make sense that these corrections should be partially included.
current_and_accrued_liabilities_correction (xbrl_link)
this guy is the correction record one of the calculated fields in first layer of the liabilities graph. Since you originally gave me in_rate_base labels for all of the leaves/most granular factoids of the graph, i can see that current_and_accrued_liabilities has three sub-components that are tagged as in_rate_base=="yes" ( tax_collections_payable, customer_deposits and taxes_accrued).

so cool, glad you pushed this ahead!
One of the outstanding tag questions on our side was with ARCs/AROs. We still have some questions on how these are accounted for, and it might unfortunately involve components of regulatory assets and liabilities, which are messy free-form tables.
So sorry for late review here, but for now, until we have time to embark on an accounting project, we think it makes sense to change back to
yes, asset retirement obligations are in rate base, with tags_rate_base_category of AROs or asset_retirement_obligations or another naming convention you like.
yes, asset retirement costs are in rate base (that's the way you currently have it), but with tags_rate_base_category of asset_retirement_costs rather than with tags_rate_base_category matching tags_aggregatable_plant_function

Hi @jrea-rmi! Just wanted to clarify --

yes, asset retirement costs are in rate base (that's the way you currently have it), but with tags_rate_base_category of asset_retirement_costs rather than with tags_rate_base_category matching tags_aggregatable_plant_function

By this do you mean replace the steam, nuclear, hydro etc. rate base category tags with asset_retirement_costs for all of the asset_retirement_costs_for_XYZ factoids?

Hi @jrea-rmi! Just wanted to clarify --

yes, asset retirement costs are in rate base (that's the way you currently have it), but with tags_rate_base_category of asset_retirement_costs rather than with tags_rate_base_category matching tags_aggregatable_plant_function

By this do you mean replace the steam, nuclear, hydro etc. rate base category tags with asset_retirement_costs for all of the asset_retirement_costs_for_XYZ factoids?

yes. Uday likes to consider these separate from the technology because of how they're accounted for and their ratepayer impacts. So that's how we'd use it - but if you feel strongly otherwise, or think other users want to label as the technology, then we can just change the label in our own processing after getting it from you.

okay @jrea-rmi i did a tiny bit of digging into these two remaining partially in rate base correction factoids. From my vantage it seems like these are truly partially in rate base but I'd love to get your opinion!
liabilities_and_other_credits_correction (xbrl link)
this is the correction record for the seed node of the liabilities graph (which is to say it is the least granular/total of all of the other totals/calculated fields. So these 4 correction records represent some error found between the liabilities' seed node and the first layer of calculation sub-components. since there are definitely liabilities in the rate base table overall it would seem to make sense that these corrections should be partially included.

Proposal: keep this correction as is - partially in rate base.

current_and_accrued_liabilities_correction (xbrl_link)
this guy is the correction record one of the calculated fields in first layer of the liabilities graph. Since you originally gave me in_rate_base labels for all of the leaves/most granular factoids of the graph, i can see that current_and_accrued_liabilities has three sub-components that are tagged as in_rate_base=="yes" ( tax_collections_payable, customer_deposits and taxes_accrued).

Proposal: keep this correction as is - partially in rate base.

one last null tags_rate_base_category
gas_stored_underground_noncurrent (xbrl link is a component of assets_and_other_debts and is a leafy/granular factoid but it does not have a tags_rate_base_category. It's not a huge deal - there are only 350 records with any ending_balance in there from 31 utilities but it'd be nice to have them all tagged!

Request: Do you have a tags_rate_base_category for this? nbd if you don't.

Sorry for delayed response on this. My answers are...
I agree, yes, these two corrections appear to be partially in rate base. And it's difficult to determine what fraction, because we don't know what the source of the discrepancy is between subtotal & total values. If you think of a way to estimate it that seems legitimate, that's great. If not, RMI will probably just leave it out when we use the table.
We don't have a tags_rate_base_category for this, because it's relevant to gas utility operations, not electric. But it's in the balance sheet section of "Utility Plant", so I suggest labeling as net_utility_plant.


Issue with k8s.io/docs/reference/access-authn-authz/extensible-admission-controllers/

For the first example, when apply -f, meet a problem:
Error from server (BadRequest): error when creating "webhook.yaml": ValidatingWebhookConfiguration in version "v1" cannot be handled as a ValidatingWebhookConfiguration: illegal base64 data at input byte 10
How should I resolve this?
the first example:
apiVersion: admissionregistration.k8s.io/v1
kind: ValidatingWebhookConfiguration
metadata:
name: "pod-policy.example.com"
webhooks:

name: "pod-policy.example.com"
rules:

apiGroups:   [""]
apiVersions: ["v1"]
operations:  ["CREATE"]
resources:   ["pods"]
scope:       "Namespaced"
clientConfig:
service:
namespace: "example-namespace"
name: "example-service"
caBundle: "Ci0tLS0tQk...<caBundle is a PEM encoded CA bundle which will be used to validate the webhook's server certificate.>...tLS0K"
admissionReviewVersions: ["v1", "v1beta1"]
sideEffects: None
timeoutSeconds: 5

/kind support
The caBundle attribute takes a base64-encode PEM. The example shows you this.

/assign


Timer issue after minimizing and opening up activity

If i switch to another app while playing, after switching back the game runs much to fast for a while... Please fix that

Closed by #8


Works Items

Please suggest, is there any rest API to get all work items of a particular project i.e issue, epic or task at once.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 53c20906-b0c0-c465-4862-62853807e5cc
Version Independent ID: dd24d086-323f-1d88-5129-7ef575a09101
Content: Work Items (Azure DevOps Work Item Tracking)
Content Source: docs-ref-autogen/5.1/wit/Work%20Items.yml
Product: devops
Technology: devops-ref
GitHub Login: @wnjenkin
Microsoft Alias: whjenkin

The APIs seem to be lacking around work items in general. I'd love to see some development in this area to make it easier to get all etc.

Mr IthaKurunathan
I am facing the same issue. I need to download the attachment in the work item and send it to other team members. All I have is the project name. I need to write a powershell script and push attachments in the work items and send them to team. This process will wake up and run once in 10 mts.
I spent lot of time and I could not figure it out.  Instead of, Probably I may write a query like
"SELECT * FROM WORKITEM WHERE AREA_PATH = $ProjectName"

As a follow up to this, the current correct approach is to use the Query By Wiql endpoint. This allows you to send queries to get a list of work item IDs.
You then need a second request to [List Work Items(https://docs.microsoft.com/en-us/rest/api/azure/devops/wit/work items/list?view=azure-devops-rest-5.0), which takes a list of IDs and returns an array of associated work items.

I have created the following Powershell script to download the attachment.  This script downloads the file. But the file is empty.  Will you please help me?
function GetUrl() {
param(
[string]$orgUrl,
[hashtable]$header,
[string]$AreaId
)
# Build the URL for calling the org-level Resource Areas REST API for the RM APIs
$orgResourceAreaUrl = [string]::Format("{0}/_apis/resourceAreas/{1}?api-preview=5.0-preview.1",$orgUrl, $AreaId)
# Do GET on this URL(This returns an object with a locationUrl field)
$results = Invoke-RestMethod -Uri $orgResourceAreaUrl -Headers $header

if ("null" -eq $results) {
	$areaUrl = $orgUrl
}
else {
	$areaUrl = $results.locationUrl
}
return $areaUrl

}
To display some information, use the cmdlet called Write-Host. e.g.
Write-Host "Wecome to Powershell and AzureDevOps" -ForegroundColor Yellow
$orgUrl = "https://dev.azure.com/xxxxxxxxxx"
$personalToken = "aofk4uearkrm2blb7emzoknmdc5iwa6olqpo2ctznkgpghgckp3q"
Write-Host "Setup authentication" -ForegroundColor Yellow
Convert the token to base64
$token = [System.Convert]::ToBase64String([System.Text.Encoding]::ASCII.GetBytes(":$($personalToken)"))
$header = @{authorization  = "Basic $token"}
Area ids. Withig the organization we have many areas. Microsoft assigned ids for these areas.
We need to identify the area id. Use this url to get the areaid.
https://docs.microsoft.com/en-us/azure/devops/extend/develop/work-with-urls?view=azure-devops&tabs=http#resource-area-ids-reference
Using above link, pickup the "core" id and use it
$coreAreaId = "79134c72-4a58-4b42-976c-04e7115f32bf"
$dvopsurl = GetUrl -orgUrl $orgUrl -header $header -AreaID $coreAreaId
$projectsUrl = "$($dvopsurl)_apis/projects?api-version=5.1"
Now we have constructed all needed token to invoke the REST API
List projects withing the organization
$projects = Invoke-RestMethod -Uri $projectsUrl -Method Get -ContentType "application/json" -Headers $header
Display the list of work items for each project
$projects.value | ForEach-Object {
$project = $_.name
#WorkItem Area ID
$wrkItemAreaId = "85f8c7b6-92fe-4ba6-8b6d-fbb67c809341"
$wrkItemBaseUrl =  GetUrl -orgUrl $orgUrl -header $header -AreaID $wrkItemAreaId

#GET https://vsrm.dev.azure.com/{organization}/{project}/_apis/release/definitions?api-version=5.1
$wrkItemDefUrl = "$wrkItemBaseUrl/$project/_apis/wit/wiql?api-version=5.1"

$WIQL = "SELECT [System.Id], [System.Title] FROM WorkItems WHERE [System.TeamProject] = '$project'"
$body = @{ query = $WIQL }
$bodyJson = @($body) | ConvertTo-Json

#Get the list of work items
$resultWrkItems = Invoke-RestMethod -Uri $wrkItemDefUrl -Method Post -ContentType "application/json" -Headers $header -Body $bodyJson
$workItems = $resultWrkItems.workItems

# If this project contains work item
if ($workItems.count -gt 0) {

	#URL for WorkItems: https://dev.azure.com/xxxxxxxxxx/EDS/_apis/wit/workitems?ids=22&$expand=all&api-version=5.1
	Write-Host "found " $workItems.Count " work items for this project: " $project  -ForegroundColor Red

	#For each work item id, get the workitem details
	$workItems.Id | ForEach-Object {
	    $workItemDetailUrl = "$wrkItemBaseUrl/$project/_apis/wit/workitems?ids=$_&`$expand=relations&api-version=5.1"

		#Pull the workitem details
		$resultWrkItemsDetails = Invoke-RestMethod -Uri $workItemDetailUrl -Method Get -ContentType "application/json" -Headers $header

		#Attachments details are in the relations attribute
		Write-Host "My count" $resultWrkItemsDetails.value.relations.count
		# if there is an attachment, download it
		if ($resultWrkItemsDetails.value.relations.count -ne 0) {

			$resultWrkItemsDetails.value.relations.url | ForEach-Object {
				$attacmentbaseUri = $_
				$attafmentUrl = "$attacmentbaseUri"+"?api-version=5.1"

				#Write-Host $attafmentUrl
				# GET https://dev.azure.com/fabrikam/_apis/wit/attachments/{id}?api-version=5.0
				$LocalPage = "C:\PowerShellUnload\testDownload.txt"

				(Invoke-RestMethod -Uri $attafmentUrl -Method Get).Content | Out-File -FilePath $LocalPage -Force

			}

		}

	 }
}

}


Failing to omit files through setup.cfg

Describe the bug
In my setup.cfg file, I specify that i want to omit my test files when measuring coverage:
[coverage:run]
omit = *tests/*

While this worked a few version ago (at least in 6.5), current version (7.1.0) does not omit the tests files.
This can be fixed with the following setup
[coverage:run]
omit = my_package/tests/*

Although it is possible to make everything work (as specified), I am surprised that my previous configuration no longer works.
To Reproduce
I'm using python 3.8.14 with coverage 6.5 and pytest 7.2.1.
The command used is:
coverage run -m pytest --cov=my_package --cov-fail-under=95 --cov-config=setup.cfg
Expected behavior
I would expect that omit through *tests/* would omit every files contained in my_package/tests/

The interpretation of wildcards changed between 6.x and 7.x.  It will work if you use omit =  */tests/* I think.  In 6.x, * would match a directory separator, but now it does not.

I think we could use a more complete description of the wildcard changes, and how to adjust settings when moving from 6.x to 7.x.

Working on this for the Pycon2023 sprints

@paxnovem added migration notes in commit d6e621aa.  I hope that will avoid future confusion.


fix: adapt dag tests to current environment

The current go-ipfs doesn't yet support running all those tests,
but at least part of them. Fix the tests that work and skip the
ones that are not yet supported.

No need for review at the moment. I just figured out that they are also run by js-ipfs. I need to accommodate that fact.

Ready for review.

@diasdavid I think I've addressed everything, please re-review.

@diasdavid I did run the current code (with the most recent fix) on js-ipfs and on js-ipfs-api (one time on master and one time with my changes for the DAG API which will then actually run the test). All passed as expected.


Add dockerfile + readme directions

I hope this makes it a little easier for some people to get started
lmk
nate

Can one of the admins verify this patch?

Thanks for the contrib! We have a Dockerfile for relayer here: https://github.com/apache/incubator-tuweni/blob/master/dist/docker/relayer.Dockerfile

ah, ok I missed that. This was part of my first steps of figuring out how to make a test harness for hobbits for this bounty: https://github.com/PegaSysEng/BountiedWork/issues/7
I could do a couple things:

Adapt the new README directions to reference the existing dockerfile
Update the existing dockerfile to use a multistage build. The benefit would be to remove the strict gradle build dependency by using gradle inside the first docker build container
Just close this PR, no changes

let me know which option(s) make sense

sounds good!


chore(spanner): fix mutation only case in rw mux with aborted error

This PR fixes the following scenario.
In a mutation-only scenario for a read-write transaction using multiplexed sessions, an explicit BeginTransaction RPC is triggered after the user operation completes.
However, if an ABORT occurs during this BeginTransaction RPC, the client retry mechanism performs an explicit BeginTransaction before the user operation begins. This behavior causes issues in multiplexed sessions because, in mutation-only cases, the BeginTransaction requires a mutation key to generate a precommit token. This precommit token is essential for committing the transaction.
Currently, since the BeginTransaction during a retry is executed before the user operation, no mutation key is available, and consequently, no precommit token is included in the transaction response. This leads to commit failures with an error as shown below
com.google.cloud.spanner.SpannerException: INVALID_ARGUMENT: io.grpc.StatusRuntimeException: INVALID_ARGUMENT: A Commit request for a read-write transaction on a multiplexed session must specify a precommit token.

The fix involves performing a BeginTransaction RPC for mutation-only cases with multiplexed sessions after the user operation completes, regardless of whether it is an initial operation or a retry.

However, if an ABORT occurs during this BeginTransaction RPC

Is this something that can actually happen?


west failed due to empty value in self.path

Tested with west 0.8.0 on FreeBSD system
If self.path is changed to use manifest-repo, everything is working fine
Error message
-- west build: generating a build system
-- Application: ....
-- Zephyr version: 2.4.0 (/home/sdalu/ZephyrProjects/zephyr)
-- Found west (found suitable version "0.8.0", minimum required is "0.7.1")
CMake Error at /home/sdalu/ZephyrProjects/zephyr/cmake/zephyr_module.cmake:48 (message):
  Traceback (most recent call last):

    File "/home/sdalu/ZephyrProjects/zephyr/scripts/zephyr_module.py", line 326, in <module>
      main()
    File "/home/sdalu/ZephyrProjects/zephyr/scripts/zephyr_module.py", line 266, in main
      meta = process_module(project)
    File "/home/sdalu/ZephyrProjects/zephyr/scripts/zephyr_module.py", line 99, in process_module
      module_path = PurePath(module)
    File "/usr/local/lib/python3.7/pathlib.py", line 642, in __new__
      return cls._from_parts(args)
    File "/usr/local/lib/python3.7/pathlib.py", line 674, in _from_parts
      drv, root, parts = self._parse_args(args)
    File "/usr/local/lib/python3.7/pathlib.py", line 658, in _parse_args
      a = os.fspath(a)

  TypeError: expected str, bytes or os.PathLike object, not NoneType

Call Stack (most recent call first):
  /home/sdalu/ZephyrProjects/zephyr/cmake/app/boilerplate.cmake:150 (include)
  CMakeLists.txt:6 (include)

Manifest used in T3 configuration. manifest is put in it's own manifest-repo directory
manifest:
  remotes:
    - name: zephyrproject-rtos
      url-base: https://github.com/zephyrproject-rtos

  projects:
    - name: zephyr
      remote: zephyrproject-rtos
      revision: v2.4.0
      import: true

  self:
    path:

.west/config file
[manifest]
path = manifest-repo
[zephyr]
base = zephyr

  self:
    path:

Can you explain why this is here? The semantics of self: path: foo are to place the manifest repository at path foo during west init, so leaving this as an empty string is not going to lead to good results.
Do you still see this if you delete this entire self: map?

@tejlmand either way I think we need to avoid a stack trace here. Need to see if it's a zephyr_module.py issue or if west.manifest should reject this manifest completely

Building fine without the self: section.
For the:
  self:
    path:

I don't remember exactly where I got it but I think it was the recommended way in previous (2.0 ?) documentation for T3 forest topology

I don't remember exactly where I got it but I think it was the recommended way in previous (2.0 ?) documentation for T3 forest topology, and it was working fine that way before 2.4

This manifest is not well-formed; if you can point to some documentation that recommends doing it that way, I will fix it. I don't see any in master.
I think this is therefore not a bug, but a malformed manifest. I've sent a PR to west which rejects this kind of manifest so it doesn't cause confusion in the future: https://github.com/zephyrproject-rtos/west/pull/446

Since https://github.com/zephyrproject-rtos/west/pull/446 is merged, I'm going to close this. I think I've answered the questions about best practices around self: path: in the PR comments there as well -- there's no "one size fits all" answer; it's really up to the user. Please LMK if you think any docs are still missing and I will send an update.


Less compiles for R

Refs #79
Tested with
docker run -ti --rm -v $PWD/environment.yml:/environment.yml condaforge/mambaforge bash

followed by the install instructions
Only compiles BayesianTools and regenoud.

Regenoud could be installed from https://packagemanager.posit.co/client/#/repos/2/packages/rgenoud to have one compile less.


x-logo refs #52919

I've confirmed these changes are reflected on both EDA and genomics sites (including orthomcl).


pdfarranger: 1.8.2 -> 1.9.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for pdfarranger is: "Merge or split pdf documents and rotate, crop and rearrange their pages using an interactive and intuitive graphical interface"
meta.homepage for pdfarranger is: "https://github.com/pdfarranger/pdfarranger"
meta.changelog for pdfarranger is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.9.0 with grep in /nix/store/p5jflp2zflc5azqabxbl7d1mpavvqk71-pdfarranger-1.9.0
found 1.9.0 in filename of file in /nix/store/p5jflp2zflc5azqabxbl7d1mpavvqk71-pdfarranger-1.9.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
pdfarranger

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/p5jflp2zflc5azqabxbl7d1mpavvqk71-pdfarranger-1.9.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A pdfarranger https://github.com/r-ryantm/nixpkgs/archive/bf0a78ded0d94b3a58e45f46bb8b9189a4089908.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/p5jflp2zflc5azqabxbl7d1mpavvqk71-pdfarranger-1.9.0
ls -la /nix/store/p5jflp2zflc5azqabxbl7d1mpavvqk71-pdfarranger-1.9.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

pdfarranger

Maintainer pings
cc @symphorien for testing.

Result of nixpkgs-review pr 191858 run on x86_64-linux 1

1 package built:

pdfarranger


demo app gives 404 on /accounts/login/after email confirmation

Step 1: sign up for an account at http://localhost:8000/signup/, the terminal gives the following output with a confirmation link:
[15/Mar/2016 21:12:20] "GET /admin/ HTTP/1.1" 200 7482
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Subject: [<IP_ADDRESS>:8000] Please Confirm Your E-mail Address
From: webmaster@localhost
To: [removed email address]
Date: Tue, 15 Mar 2016 21:14:52 -0000
Message-ID<EMAIL_ADDRESS>
Hello from <IP_ADDRESS>:8000!

You're receiving this e-mail because user [removed email address] at localhost has given yours as an e-mail address to connect their account.

To confirm this is correct, go to http://localhost:8000/account/confirm-email/czgttjbduondjtg0mnnictufdyp8mty3tfkgvk9lw6gkewgvccrbsj1vjmlzffqc/

Thank you from <IP_ADDRESS>:8000!
localhost
-------------------------------------------------------------------------------

Step 2: visit the URL mentioned and click the verify button. The user is then redirected to /accounts/login/ which results in a 404:
[15/Mar/2016 21:14:53] "POST /rest-auth/registration/ HTTP/1.1" 201 50
[15/Mar/2016 21:15:01] "GET /login/ HTTP/1.1" 200 5103
[15/Mar/2016 21:15:07] "POST /rest-auth/login/ HTTP/1.1" 200 50
[15/Mar/2016 21:15:39] "GET /account/confirm-email/czgttjbduondjtg0mnnictufdyp8mty3tfkgvk9lw6gkewgvccrbsj1vjmlzffqc/ HTTP/1.1" 200 4578
[15/Mar/2016 21:15:44] "POST /account/confirm-email/czgttjbduondjtg0mnnictufdyp8mty3tfkgvk9lw6gkewgvccrbsj1vjmlzffqc/ HTTP/1.1" 302 0
Not Found: /accounts/login/
[15/Mar/2016 21:15:44] "GET /accounts/login/ HTTP/1.1" 404 3884

+1

Seems like you're missing this in your urls:
url(r'^accounts/', include('allauth.socialaccount.urls'))

Did the above answer resolved your issue? @Kyle-Falconer @kstratis

@mariodev possibly, but I'm not running this right now so I can't test it.
The point of it was this was the demo app, so it should have been included and working out of the box.


Water polygons sometimes missing boundary line

Lake Merced in SF shows a water boundary line around one of the two lakes, but both lakes should have a boundary.
Might be related to MultiPolygons (the missing boundary is from a MultiPolygon)?

Seeing similar lack of water boundary features south of Washington DC around: 12/38.6837/-77.1095. Most look to be tagged riverbank and not part of relations.

Lake Merced
This appears to be happening because the geometry is duplicated as part of the import: Osm2pgsql usually deleted "superseded" member geometries of relations, but will keep a constituent member geometry of a relation in the database if it has tags which aren't present on the relation. That's happening here, as the largest part of Lake Merced is tagged with a wikipedia tag.
I have a patch which fixes this by unioning all geometries together before separating each feature's boundaries. Unfortunately, it's about 3x slower than the existing implementation and I can't think of a way to speed it up, as most of the time is spent in the unary_union operation. Given that the exterior boundaries is already one of the slowest operations we perform on a tile, this means it could make the whole process about 2-3x slower.
Alternatives such as simply excluding relations (or non-relations) won't work, as water polygons are sometimes mapped as either, and constituent parts are generally superseded. What's the trade-off between getting it right and getting it fast?
@rmarianski can you think of anything I've missed / any other ideas worth trying?
South of DC
@nvkelso, I can't find the area you mention - I've checked along from Pohick Bay to Gravelly Point - I can't see any missing boundaries. Could you point out a particular feature that's missing that I can check, please?

In this case would the issue be resolved if the wikipedia tag were placed on the relation? And would that be more correct to do anyway? Even so, I imagine that in the general case there are legitimate scenarios where constituent ways would have tags that won't exist on the relation. Do we have any insights into how prevalent these cases are?
In terms of speedups, I can try to take a look at the patch to see. But if you're already grouping the "related" features and only performing the union on those, I can't really think of speedups. Maybe if we aren't already using a spatial index, we could try that? Or a quick inline bbox test before calling union to filter out cases where they obviously wouldn't combine?

Lake Merced in SF

That sounds slow enough to not do, and prefer the data fix (moving the Wikipedia tag onto the relation instead of the part).
Is this type of tagging funk common enough that we need to protect against it in our code base, or do one-off fixes in the data (or create a medium sized list of places to go fix using a tasking tool)? Or do we change our import process?

South of DC

Tile:
http://vector.mapzen.com/osm/all/13/2339/3142.topojson?api_key=vector-tiles-HqUVidw
Ah, looks like this is a stylesheet issue where the {riverbank, boundary} combo is only rendering at zoom 14+ as a thin line (I was viewing it at zoom 13).
But why is the circled "A" area showing a water boundary line in the middle of the water (for both ocean and riverbank)? Is there a way to drop that?

In this case would the issue be resolved if the wikipedia tag were placed on the relation?

Yes.

And would that be more correct to do anyway? Even so, I imagine that in the general case there are legitimate scenarios where constituent ways would have tags that won't exist on the relation.

In this case, perhaps. The relation really ought to cover all the separate bodies of water which are called Lake Merced and have the wikipedia and name tags only on the relation. That would fix this case, but you're right that there may be others for which the tag on the way is legitimate and correct, so we need to handle this case.

Do we have any insights into how prevalent these cases are?

Looks like there are 3,059 cases in North America, out of 3,129,464 landuse polygons, so about one in 1,000 - it's pretty rare, but it might be very obvious in some cases.

But why is the circled "A" area showing a water boundary line in the middle of the water (for both ocean and riverbank)? Is there a way to drop that?

The exterior_boundaries is supposed to... but it turns out in this case that there's a very, very small gap between the ocean and the riverbank (about 1cm in Mercator coordinates). This gap isn't present in the OSM data, so it likely comes from numerical precision artefacts due to the different processing pipelines (osm2pgsql vs. osmcoastline + shp2pgsql). A 1cm error represents about 0.0000001% relative error (on the same order as float epsilon), so it could easily have come from either pipeline.
One way to fix this would be to buffer the geometries by ~1cm before unioning them, but that would make the process even slower than the 3x. One thing I'll try is to snap the coordinates to a 5cm grid and see if that helps. Another way would be to pin and manually edit the ocean shapefile, but that's pretty unpalatable from a maintenance point of view.
The "right" fix is to maintain the topology, as the ocean and riverbank correctly share nodes... but we can't implement that in the short term.

Is this type of tagging funk common enough that we need to protect against it in our code base, or do one-off fixes in the data (or create a medium sized list of places to go fix using a tasking tool)?

I think we'll need to protect against it in the code - in some instances having an extra tag on the member way will be correct. It's possible that we can hack around it... it just might be a little ugly.

Or do we change our import process?

Ultimately, yes, I think that's the right answer. But not something we should try and do quickly - I'm sure we can fix this problem "good enough" in the short term.

With mapzen/TileStache#76 and #326,
Lake Merced

Indian Head

Visually checks out :+1:
You mentioned before that one approach took 3x as long as the current method. How much longer do  changes in this PR take?

For a pretty small sample, I'm seeing slowdowns of between 25-50% from the snapping, mostly. I'd prefer it to be quicker, but 25-50% slower is much better than 200% slower :wink:

@nvkelso - are we okay with the 25-50% slower performance?

Yes, pending perf testing on dev before we take it to prod.

@rmarianski Can you please look into profiling tile generation speed impact of this change before we take it to prod?

Verified.


Windows/JDK8/J9 production 0.11.0 builds currently failing

Reason unclear but the resulting java execution is resulting in:
The application has failed to startt because it's side-by-side configuration is incorrect. Please see the application event log or use the command line sxstrace.exe tool for more detail
In the build log when trying to execute it we get:
Finished building OpenJDK for target 'images'
'/tmp/tmp.kJ76onEiGA/workspace/./build//src/build/windows-x86_64-normal-server-release/images/j2sdk-image' found
/cygdrive/c/Users/jenkins/workspace/SXA-jdk8_j9_win64_build/sbin/build.sh: line 353: /tmp/tmp.kJ76onEiGA/workspace/./build//src/build/windows-x86_64-normal-server-release/images/j2sdk-image/bin/java: Accessing a corrupted shared library
 Error executing 'java' does not exist in '/tmp/tmp.kJ76onEiGA/workspace/./build//src/build/windows-x86_64-normal-server-release/images/j2sdk-image'.
Relocating workspace from /tmp/tmp.kJ76onEiGA to /cygdrive/c/Users/jenkins/workspace/SXA-jdk8_j9_win64_build/workspace
Data at: /cygdrive/c/Users/jenkins/workspace/SXA-jdk8_j9_win64_build/workspace

Related issues: https://github.com/AdoptOpenJDK/openjdk-build/issues/719 https://github.com/AdoptOpenJDK/openjdk-build/issues/690
Related PRs: https://github.com/AdoptOpenJDK/openjdk-build/pull/726
Doing test builds under https://ci.adoptopenjdk.net/view/work in progress/job/SXA-jdk8_j9_win64_build/3/console for now

Worked ok at https://ci.adoptopenjdk.net/view/work in progress/job/SXA-jdk8_j9_win64_build/3 with
TAG: jdk8u192-b12
configure_args: --with-milestone=fcs
BRANCH: openj9-0.11

Testing at https://ci.adoptopenjdk.net/view/work in progress/job/SXA-jdk8_j9_win64_build/4 with
TAG: jdk8u192-b12_openj9-0.11.0
configure_args: --with-milestone=fcs
BRANCH: openj9-0.11

Testing at https://ci.adoptopenjdk.net/view/work in progress/job/SXA-jdk8_j9_win64_build/5 with just ADDITIONAL_FILENAME_TAG set

Testing at https://ci.adoptopenjdk.net/view/work in progress/job/SXA-jdk8_j9_win64_build/6 with
TAG: jdk8u192-b12_openj9-0.11.0
configure_args:
BRANCH: openj9-0.11

Testing at  https://ci.adoptopenjdk.net/view/work in progress/job/SXA-jdk8_j9_win64_build/9 with
TAG:
configure_args: --with-milestone=fcs
BRANCH: openj9-0.11
ADDITIONAL_FILENAME_TAG: jdk8u192-b12_openj9-0.11.0

Parameter has been added to expose ADDITIONAL_FILENAME_TAG which we will use for the production builds https://github.com/AdoptOpenJDK/openjdk-build/pull/732

Re-opening as I'm still hitting issues:

configure: Found Microsoft Visual Studio 2010
configure: Rewriting VS_ENV_CMD to "/cygdrive/c/progra~2/micros~4.0/vc/bin/amd64/vcvars64.bat"
configure: Trying to extract Visual Studio environment variables
Setting environment for using Microsoft Visual Studio 2010 x64 tools.
configure: Setting extracted environment variables
/cygdrive/c/cygwin64/tmp/tmp.UD5miaHsOB/workspace/build/src/build/windows-x86_64-normal-server-release/vs-env/set-vs-env.sh: line 2: syntax error near unexpected token `('
/cygdrive/c/cygwin64/tmp/tmp.UD5miaHsOB/workspace/build/src/build/windows-x86_64-normal-server-release/vs-env/set-vs-env.sh: line 2: `VS_INCLUDE="c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\INCLUDE;c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\ATLMFC\INCLUDE;C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\include;C:\Program Files\Debugging Tools for Windows (x64)\sdk\inc; "'
configure exiting with result code 2
Relocating workspace from /tmp/tmp.UD5miaHsOB to /cygdrive/c/Users/jenkins/workspace/SXA-jdk8_j9_win64_build/workspace
Data at: /cygdrive/c/Users/jenkins/workspace/SXA-jdk8_j9_win64_build/workspace
total 8.0K

This appears to only be the case when the TAG variable is set, which we may not need any more now that we're using the ADDITIONAL_FILE_NAME_TAG

11 was built with the pre branch of my openjdk-build repo. 14 will be built with what was hopefully the same as 9

I think the variable issue with the ) was down to having the jenkins agent started as the wrong user. Now passing that point running as jenkins

@sxa Can this be closed?

The build pipelines are now passing, so I'd say yes


Fix Dockerfile

Fix mock Dockerfile for #12

can you rebase or close this please?

I didn't notice new Dockerfile, I'm going to close this.


Issue with k8s.io/docs/tasks/run-application/run-stateless-application-deployment

This is a Bug Report
Problem:
This is similar to the the issue here:
https://github.com/kubernetes/website/issues/14514
Though I believe I know the cause...the nginx:1.7.9 container will crash on modern kernels with vsyscall disabled.  For example on Debian buster kernel 5.4.0-0.bpo.2-amd64 this happens:
[ 8470.383161] nginx[25332] vsyscall attempted with vsyscall=none ip:ffffffffff600400 cs:33 sp:7fff541ba6a8 ax:ffffffffff600400 si:49a159 di:0
[ 8470.383165] nginx[25332]: segfault at ffffffffff600400 ip ffffffffff600400 sp 00007fff541ba6a8 error 15
[ 8470.383166] Code: Bad RIP value.

This issue is extremely annoying to troubleshoot. There are no container logs indicative of any error and kubectl describe pod/nginx-xxxx shows no errors other than these events:
9m17s       Normal    Created                   pod/nginx-deployment-54f57cf6bf-xqpdp    Created container nginx
9m16s       Normal    Started                   pod/nginx-deployment-54f57cf6bf-xqpdp    Started container nginx
9m17s       Normal    Pulled                    pod/nginx-deployment-54f57cf6bf-xqpdp    Container image "nginx:1.7.9" already present on machine
47s         Warning   BackOff                   pod/nginx-deployment-54f57cf6bf-xqpdp    Back-off restarting failed container

This is the previous bug's description which is true, as is the recommended solution.
The tutorial mentions to create a deployment with nginx version 1.7.9 - doing so will result in a CrashLoopBackoff of the pods.
Proposed Solution:
Using a different version, e.g. 1.15 will result in a running pod.
Page to Update:
https://kubernetes.io/docs/tasks/run-application/run-stateless-application-deployment/

This seems worth fixing at some point.
/priority backlog

/assign

#19198 has resolved this issue, though #19622 wasn't merged.
Please feel free to open if this is still an issue.
/close


Observability DA feedback

existing_resource_group -> use_existing_resource_group
Make region a dropdown picker in ibm_catalog.json with supported regions
existing_kms_guid -> Ask for CRN instead
Parse the KMS region from the KMS key crn, or instance CRN and remove the kms_region variable
Make existing_cos_kms_key_crn a required variable in ibm_catalog.josn so it shows in required list in Projects to improve user experience, even though its not actually required if you use the DA to create the key

PR Merged


Large white bar for K9 statuses after latest Sprint S8 firmware update

Expected behavior
When new mail arrives status line should show info about latest email in a single line
Actual behavior
Displays double or triple line status in white box, with no info about email.
Steps to reproduce

Upgrade phone to Sprint kernel 4.4.153-16125356 #2 Jul 4 23:06:25 KST 2019  (Samsung Galaxy S8)
Receive new mail
Swipe down from top to view statuses, large white entries appear for new mail

Environment
K-9 Mail version:
5.600
Android version:
See screen captures
Account type (IMAP, POP3, WebDAV/Exchange):
POP3

Duplicate of #4079


Patch for updated manifests post CAPI bump v1.7.2

Issue #, if available:
Description of changes:
Patch for updated manifests post CAPI bump v1.7.2
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


update embedded hal to v1.0 rc2

The release candidates of embedded-hal should only contain minimal changes until the full release of 1.0 It's likely that pca9535 does not need any further adjustments once 1.0 is released.
fixes #2

Tests passing on HW


The ReplaceAll method does not match expectations

Describe the bug
This behavior does not correctly replace the text in each item, but instead replaces it all with newText.
https://github.com/Wenveo/Noisrev.League.IO.RST/blob/ca00d9c30517a6e8a93e1d73323ba804c17dbf2a/Noisrev.League.IO.RST/RSTBuilder.cs#L356-L364
Just like:
// itemText = "This is a text"
// ReplaceAll("a", "b");
// itemText = "b"

Expected behavior
Able to correctly replace the text of each item.
// itemText = "This is a text"
// ReplaceAll("a", "b");
// itemText = "This is b text"

wow, thx!
It was really bug :D


Add Frosted Glass Effect

Added the frosted glass effect in the resources/index.css after testing the same in /dist folder.

How do I test this properly? I tried setting a background to the html and the card background is not blurry.

I applied the following under resources/index.css in "root" for color-mode="light" (line 7) to check if it works for background image:
:root[color-mode="light"] {
    background-image: url(https://i.stack.imgur.com/fhEwl.png);
    background-size: cover;
    background-attachment: fixed;
   /* rest of the code */
}

I was able to achieve the following result:

Please let me know if this was not the actual requirement or if you were looking for something different.. I am really new to open source and I would love to understand your requirements better :)

Thanks. Looks great!
Turns out that CSS property backdrop-filter is only supported on Chrome-based browsers at the moment. When tested on Firefox, it is translucent without a blur. Can you replicate the same effect using the regular CSS filter property?

Thank you :) I am going to try for regular CSS and send a PR.

Are you still working on this? @sebanti10

Closing due to inactivity


Build Issues Xcode 10.1, ios12, cinder 0.9.1

Looking for help with the following build env:
Xcode 10.1
ios12
cinder 0.9.1
For now getting tons of *.h files missing between old to new Cinder library upgrade. Working through them, will post progress update once i have a running build

@jharohit Hi!  Wondering if you managed to fix all the Xcode 10 build issues?  I'm making some progress but it feels a bit like unwrapping an onion!

Actually I managed to get it to build, sadly it crashes repeatedly on launch with the latest sdks.

how did you go ?


Fast Walking: Inconsistent & Discrepant operation.

Part of your Fast Walking description says "Materials on which players will walk faster."
This does not apply to just players, it is all mobs. Including hostile.
Numerous of my players have been attacked by super-fast spiders, as the speed effect is not the same exponent for each mob. Players speed effect vs Spider speed effect vs etc speed effect is different.
Add an option to make Fast Walking work only on players.

See #228

Players speed effect vs Spider speed effect vs etc speed effect is different.

They all get the same Speed I buff as if you had thrown a speed I potion on them.
Closing as duplicate of #227.


Add test for Gradle builder

Adds a workflow_dispatch test for the Gradle builder.
It depends on a few changes to the builder that I will push shortly.

Not sure why shellcheck complains: I don't see any errors.

Not sure why shellcheck complains: I don't see any errors.

Yeah, don't worry about it for now. I'll take a look at it later.


[Fix #3457] Clear a warning and prevent regression

This adds a test that fails if loading Rubocop's lib files emits any warnings.
The documentation for MagicComment produced:
lib/rubocop/magic_comment.rb:124: warning: `frozen_string_literal' is ignored after any tokens

fixes #3457

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Used the same coding conventions as the rest of the project.
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] All tests are passing.
[x] The new code doesn't generate RuboCop offenses.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

This naive approach adds about 1 second to the test run (on my laptop).
I didn't attempt the more sophisticated option proposed by @backus.

I just learned that Ruby used to warn about private attributes. So, I just publicized them ¯_(ツ)_/¯

The second commit message is not consistent with our message guidelines.

Yeah. I was going to squash once I knew it fixed the build.
What's your opinion on that change versus whitelisting the warning?

The warning seems pretty odd to me, as there's certainly value in having private attributes, but I'm fine with the changes. Any idea which is the Ruby version that dropped this warning?

Any idea which is the Ruby version that dropped this warning?

It was removed in 2.3.0, and wasn't back ported to any other version.

What's your opinion on that change versus whitelisting the warning?

I'd personally much prefer a whitelist. 😅


Misleading error message from create call

Discussed in https://github.com/prisma/prisma/discussions/11393
Relevant code, schema, message

I will take a look into why the error message was pointing in the wrong direction.

Invalid `prisma.user.create()` invocation:

{
  data: {
    email<EMAIL_ADDRESS>    person: {
    ~~~~~~
      create: {
        first_name: 'William',
        last_name: 'Albright',
        hubspot_id: null
      }
    }
  }
}

Unknown arg `person` in data.person for type UserUncheckedCreateInput. Did you mean `person_id`? Available args

Seems like it should be on hubspot_id

I will try to fix it!

I tried to reproduce this bug.
But it looks it does't  now.

Reproduction
As for current (4.4.0-dev.45) snapshot, compile-time error is reported correctly, however, if it is ignored, runtime validation in client is missing completely and all we get is quite unhelpful message from engine's validator:
Failed to validate the query: `Unable to match input value to any allowed input type for the field. Parse errors: [Query parsing/validation error at `Mutation.createOneUser.data.UserCreateInput.person.PersonCreateNestedOneWithoutUserInput.create`: Unable to match input value to any allowed input type for the field. Parse errors: [Query parsing/validation error at `Mutation.createOneUser.data.UserCreateInput.person.PersonCreateNestedOneWithoutUserInput.create.PersonCreateWithoutUserInput.hubspot_id`: A value is required but not set., Query parsing/validation error at `Mutation.createOneUser.data.UserCreateInput.person.PersonCreateNestedOneWithoutUserInput.create.PersonUncheckedCreateWithoutUserInput.hubspot_id`: A value is required but not set.], Query parsing/validation error at `Mutation.createOneUser.data.UserUncheckedCreateInput.person`: Field does not exist on enclosing type.]` at `Mutation.createOneUser.data`

Fixed in latest dev, error message now is:
Invalid `prisma.user.create()` invocation in
/Users/serhii/projects/prisma/reproductions/workbench/index.ts:21:36

  18 const prisma = new PrismaClient()
  19
  20 for (const u of userData) {
→ 21   const user = await prisma.user.create({
         data: {
           email<EMAIL_ADDRESS>           person: {
             create: {
               first_name: "William",
               last_name: "Albright",
       +       hubspot_id: String
             }
           }
         }
       })

Argument `hubspot_id` must not be null.


Cover art Spotify

The Album cover picture in Spotify is not correctly displayed: when skipping a song or selecting a different one using directly the phone the album cover picture is the one from the first song that has been played. This doesn't happen when skipping/browsing songs using the iDrive (here the cover is correctly updated).

Hmmm I don't experience this. Can you explain more about your situation?

What version of Spotify are you running?
What version of AAI are you running?
Did you grant access to Browse Your Spotify Library?

This Browse Your Spotify Library permission enables the protocol which allows for fetching the coverart directly from Spotify. Otherwise it relies on the ability to Control Active Music Apps, and Spotify's coverart in this mode is less reliable and sometimes doesn't show anything. It seems to only provide coverart if it is already cached, and so it successfully shows coverart if you play multiple songs from the same album or skip to a previous song you recently played.
I haven't heard of any situation where it would display the wrong coverart, it would either display the correct coverart or the placeholder image.

What version of Spotify are you running?
<IP_ADDRESS>6
What version of AAI are you running?
the latest on 28 jul
Did you grant access to Browse Your Spotify Library?
I cannot grant acces.  The AAI says could not find spotify app    and    spotify web api authorized.
THnks a alot

Very curious! Are you running a modded version of Spotify? AAIdrive doesn't care, and it shows those permission checkboxes if it sees any Spotify installed at all. The Spotify App SDK is the code that is complaining that it can't find the Spotify app, and it is unable to connect to modded Spotify apps.

Are you still experiencing this?

No more, there were some problem related to the modded version: solved by subscribing to Premium xD. Thank you so much for the support, and congratulations for this beautiful project!

Glad to hear it! Thank you for the kind words!


Add xunit.core to the windows runner

xunit.core is missing from the Windows runner.

@dotnet-bot test this again, please

@dotnet-bot test this

:+1:

@dotnet-bot re-test this

Will re-open to try and re-trigger Jenkins builds.


Invecible Command

title says it all

@Agarian #1299

Invecible?

https://www.youtube.com/watch?v=N_2cv89SlpY

Sorry I cannot support you with custom code.

@Fan7asy  why no?

This is an issue's section.

@MiraMiPalo This is the issues section, meaning it is for issues, from what i can see here, there's no issue.

If you can't do it, learn

and the section of custom code? xD

?

lol gaver have a multiogar

https://youtu.be/vJX9aYeJFXc

@MiraMiPalo send me please
skype : yt.rememberme.br
discord : ﾑﾶの尺ﾉﾶᴸᵉᵍᵉⁿᵈ#9554

@MiraMiPalo give me command plzz

@MiraMiPalo
give me command plzz

dame el código por favor


Update connection-setup.md

Merge the initial sync scenario to this doc

I moved this to the working repo.


enable ~ expression in datasets

enabled ~ expression in datasets, e.g.
datasets.MNIST('~/.torch/data/mnist', train=True, download=True,...)

will save data in /home/USER_NAME/.torch/data/mnist instead of current CURRENT_DIR/~/.torch/data/mnist.

It's my first pull request ever, so if something wrong or something insufficient, let me know. Thank you.

Hi,
Thanks for the PR!
I have one concern about os.path.expanduser: it seems that it is broken for python 2.7 for Windows when you have unicode characters in the path.
For that reason, I think it would be better not to merge this PR, given that it could break user code once we get PyTorch Windows-compatible.
Any thoughts on that?

we will not be supporting python 2.7 on windows. We will only be supporting py3+, so not a problem.


Web Animation API enabled by default in Fx47

Web Animation API enabled by default in Firefox 47 as of January 29th.

Nice, thanks!


Run shell inline on remote machine, with docker-compose fails the build on regular docker-compose output

Environment

Server - VSTS

Issue Description
I'm running a docker-compose command on a remote server using the remote shell script task, and it looks like very line docker-compose output to the console is tagged as an error by the Shell script Task in VSTS. The operation happens correctly inside docker and my container is also getting created but release is getting failed.
Error logs

This repo doesn't contain a remote shell script task.  That task should have an option like the shell script task in this repo whether stderr output should be treated as an error.  docker compose writes status to stderr (like git does).


Bing Maps support?

Is there a reason gwt-ol3 does not provide wrappers for Bing maps (supported in OL)?
https://openlayers.org/en/latest/apidoc/ol.source.BingMaps.html
I've created a patch, basicaly just two additional simple JsInterop wrappers:
ol.source.BingMaps extends ol.source.TileImage
and
ol.source.BingMapsOptions extends ol.source.TileImageOptions
It works and if there are no issues that I'm not aware of (license?) I can provide a pull request.

Hello Gordan,
nope there is no special reason. It is only not implemented yet. Pull requests are welcome. Please also provide a test and an example. You can copy the license header from one of the other files.
Regards
Tino


Data Sources?

Having issues overlaying v0.8.0.iso with my own kernel cmdline values
Is your feature request related to a problem? Please describe.
What does data sources even mean?  Attempting to boot from USB, very little documentation as to what "data sources" relates to aside from "cloud provider" - is this a config file in a bucket?   What does provider matter for?
Describe the solution you'd like
A simple way to create a bootable USB device to provision k3os server & agent nodes with a cloud config.yaml
Describe alternatives you've considered
booting from usb with cloud config pointed at a gist to no avail.
Additional context
Regularly am unable to mount sdb device when installing from ISO USB.  Issue relates to not having a partition on a disk, in this particular scenario /dev/sda
mount /.base: wrong fs type, bad option, bad superblock on /dev/sdb3

@Kampe referencing https://github.com/rancher/k3os/blob/master/README.md#k3osdata_sources:

k3os.data_sources
These are the data sources used for download config from cloud provider. The valid options are
aws
gcp
openstack
packet
scaleway
vultr
cdrom

Emphasis mine. I agree that it is a bit poorly named but it is by now fairly standard usage in this context (cloud-init/cloud-config/user-data/meta-data). With a configured data-source, we treat any readable user-data from it as either a script (if a shebang line is detected) to be executed or config.yaml to be merged with other config from your system. That said, data-sources are not relevant to your use case because you are booting from USB.
The simplest way to boot with your custom config is to place it at /k3os/system/config.yaml on your USB media. If you are re-mastering the ISO, you can drop your config.yaml at images/07-iso/config.yaml and it will show up at /k3os/system/config.yaml in the ISO.

Should be noted that the gist file needs to be the raw gist .yaml file, documentation leads me to believe any gist is acceptable.

@luthermonson: quiso seems to be nice tool, but is unable to produce the 'config' file that linuxkit/metadata is looking for.
@dweomer, @zimme: how about modifying @ibuildthecloud's forked version of linuxkit/metadata to look for a file called 'user-data' in provider_cdrom.go?
I'm trying to use k3os with the 'cloud-init' feature of Proxmox.
This is a screen dump of the content of the ISO.

I've forked another ISO building tool, to create cloudinit-for-k3os.
k3os-build.sh creates a hard link from user-data to config before making the ISO image.
With that, it IS now possible to use k3os.data_sources=cdrom when installing k3os.
Stay tuned, for more to come. And keep listening to #66.

a suggestion would be to look at the python implementation of the cloud-init/cloud-config package that is used by debian/ubuntu etc and do a pr to update linuxkit/metadata's cdrom provider to work the same way.
This is what I did for hetzner and scaleway

so, yeah, I dunno where I am remembering user-data.txt from but linuxkit/metadata looks for config at the root of the ISO: https://github.com/linuxkit/linuxkit/blob/master/pkg/metadata/provider_cdrom.go#L12

As of linuxkit v0.8 it seems to be possible to use "user-data" as a file name.
This has been modified a few weeks ago here and is now implemented in linuxkit v0.8

Hey @gfeun,
The linuxkit v0.8 solution you mention, seems and reads as an interesting approach. However, how can we benefit from that within K3OS?
Thank you

Hey @larssb,
My use case was to inject configuration in my k3os VMs using cloud init.
The problem was that the typical "user-data" filename was not recognised by k3os on boot when using cloud init cdrom data source. linuxkit 0.8 introduced support for user-data filename for cloud init.
Since linuxkit v0.8 is now included inside k3os (https://github.com/rancher/k3os/blob/7279320fef0478564b0c4a435e57e2ae1e629ef7/images/20-progs/Dockerfile#L6)  this should be solved but I have not tested.

Aaah then this solution by @pagong does not sound to be necessary to use anymore.
Am I right?

Don't know this specific project but according to the readme you are right:
That's why this fork is needed: create a hard link from user-data to config before making the ISO image.

Due to my day job, I didn't have much time lately to try out k3os 0.11.1. ☹
If k3os is using the fixed, upstream linuxkit, then my little tool is no longer needed.


I just launch your script from LaunchBar and my profile comes right up near-instantly.  It works whether I have Chrome closed, open, etc.  Thank you.


Support to integrate Supabase db

Is your feature request related to a problem? Please describe.
When I input supabase link into the schema, I couldn't sync the database.
Describe the solution you'd like
No
Describe alternatives you've considered
Refactor the schema parameters
Additional context
No

So, the solution is add host, port, database, user, password. Let users add connections information instead of URI.


Option to block NSFW results

Closes #56
Added the option -s, which limits the anime fetched from the API to only SFW (Safe For Work).
This option can be used with the other options for fetching anime.

@all-contributors please add @sameersecond for code and docs


Guard against work being queued on an already-disposed ThreadedTaskScheduler

Addresses https://github.com/ppy/osu/runs/7422392920?check_suite_focus=true#step:5:41
We already catch in all other cases.
Checking microsoft examples, generally TaskScheduler implementations don't even implement IDisposable, which means they will act similarly at process exit (dropping work). I think keeping the IDisposable implementation allows us better control and don't see it as an issue, so I'm not going to touch that. Logging should be enough IMO.

I've updated this to ensure that tasks which are queued are eventually run (even if that run is synchronous).

Let's hope we don't run into any deadlocks doing it this way.


refactor(esl-toggleable): update API with before show/hide livecycle hooks

Closes https://github.com/exadel-inc/esl/issues/1677
NOTE: creataed as an alternative to https://github.com/exadel-inc/esl/pull/1679 initial implementation

:tada: This PR is included in version 4.13.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


matlabengineforpython (>=R2016b) is not a proper PEP440 requirement

This poses problems when parsing the package with packaging >= 22:
[   29s]   File "/usr/lib/python3.10/site-packages/packaging/requirements.py", line 35, in __init__
[   29s]     parsed = parse_requirement(requirement_string)
[   29s]   File "/usr/lib/python3.10/site-packages/packaging/_parser.py", line 64, in parse_requirement
[   29s]     return _parse_requirement(Tokenizer(source, rules=DEFAULT_RULES))
[   29s]   File "/usr/lib/python3.10/site-packages/packaging/_parser.py", line 82, in _parse_requirement
[   29s]     url, specifier, marker = _parse_requirement_details(tokenizer)
[   29s]   File "/usr/lib/python3.10/site-packages/packaging/_parser.py", line 116, in _parse_requirement_details
[   29s]     specifier = _parse_specifier(tokenizer)
[   29s]   File "/usr/lib/python3.10/site-packages/packaging/_parser.py", line 205, in _parse_specifier
[   29s]     parsed_specifiers = _parse_version_many(tokenizer)
[   29s]   File "/usr/lib/python3.10/site-packages/packaging/_parser.py", line 223, in _parse_version_many
[   29s]     version_token = tokenizer.expect("VERSION", expected="version after operator")
[   29s]   File "/usr/lib/python3.10/site-packages/packaging/_tokenizer.py", line 136, in expect
[   29s]     raise self.raise_syntax_error(f"Expected {expected}")
[   29s]   File "/usr/lib/python3.10/site-packages/packaging/_tokenizer.py", line 161, in raise_syntax_error
[   29s]     raise ParserSyntaxError(
[   29s] packaging._tokenizer.ParserSyntaxError: Expected version after operator
[   29s]     matlabengineforpython (>=R2016b)
[   29s]                              ^
[   29s]
[   29s] The above exception was the direct cause of the following exception:
[   29s]
[   29s] Traceback (most recent call last):
[   29s]   File "/usr/lib/rpm/pythondistdeps.py", line 561, in <module>
[   29s]     main()
[   29s]   File "/usr/lib/rpm/pythondistdeps.py", line 372, in main
[   29s]     dist = Distribution(f)
[   29s]   File "/usr/lib/rpm/pythondistdeps.py", line 86, in __init__
[   29s]     self.requirements = [Requirement(r) for r in self.requires or []]
[   29s]   File "/usr/lib/rpm/pythondistdeps.py", line 86, in <listcomp>
[   29s]     self.requirements = [Requirement(r) for r in self.requires or []]
[   29s]   File "/usr/lib/rpm/pythondistdeps.py", line 68, in __init__
[   29s]     super(Requirement, self).__init__(requirement_string)
[   29s]   File "/usr/lib/python3.10/site-packages/packaging/requirements.py", line 37, in __init__
[   29s]     raise InvalidRequirement(str(e)) from e
[   29s] packaging.requirements.InvalidRequirement: Expected version after operator
[   29s]     matlabengineforpython (>=R2016b)
[   29s]                              ^
[   29s]
[   29s] The above exception was the direct cause of the following exception:
[   29s]
[   29s] Traceback (most recent call last):
[   29s]   File "/usr/lib/rpm/pythondistdeps.py", line 564, in <module>
[   29s]     raise RuntimeError("Error: pythondistdeps.py generator encountered an unhandled exception and was terminated.") from exc
[   29s] RuntimeError: Error: pythondistdeps.py generator encountered an unhandled exception and was terminated.

Also note that for current R2022b the version is 9.13:
% pip install /opt/matlab/R2022b/extern/engines/python
Processing /opt/matlab/R2022b/extern/engines/python
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Building wheels for collected packages: matlabengineforpython
  Building wheel for matlabengineforpython (pyproject.toml) ... done
  Created wheel for matlabengineforpython: filename=matlabengineforpython-9.13-py3-none-any.whl size=16719 sha256=7c659fd449bc9528ebe9a27e9ca497fbab9d747e778923b6bcccc7ef39067aab
  Stored in directory: /tmp/pip-ephem-wheel-cache-gxnfvkim/wheels/34/7e/2e/13063070365bf553ba73e7ffb8ff597aec643123c55a9bad83
Successfully built matlabengineforpython
Installing collected packages: matlabengineforpython
Successfully installed matlabengineforpython-9.13

MathWorks even releases it on PyPI as matlabengine (!) and has it in a public GitHub repo;

https://pypi.org/project/matlabengine
https://github.com/mathworks/matlab-engine-for-python

Ref: https://peps.python.org/pep-0440/

Thanks for the report; now fixed.


Odometry problem with some Kitti sequences

Hi. First of all, I would like to appreciate your excellent work. Thank you making it open source and sharing it. I have tested the algorithm with several kitti sequences. The interesting thing is that it works with some of the kitti sequences good, while with other sequences it gives very inaccurate results. Namely, the base_link starts to jump around and so, the results are awful. I attached picture below as an example.

So, I started to debug the code. After a bit of debugging I think I found the problem and even I partially solved it, but I am sure that it is not correct solution and also, it doesn't completely solves the problem.

Problem is not external IMU parameters, because it is the same for every Kitti sequences (I checked with calibration files also)
Problem is not with bag file's IMU or Lidar datas, because I have checked them. Also, they work with Fast-LIO
Problem is with LIDAR Odometry. As it is not correct, it directly affect to IMU odometry and base_link starts to jump around. After a bit of debugging I have seen it is related from scan2MapOptimization. Namely, during optimization, R and T is not converging. I mean, it converges, but for a few frames, so LIDAR odometry becomes non-accurate. I did some experience on that. I have increased convergence threshold from 0.05 to 0.5 (deltaR and deltaT) and also, maximum iteration number (iterCount) to 50. These parameters are in LMOptimization method. The results became better. Now the base doesn't jump around in a crazy way. While it is surely far more better result than previous case, it is still not that correct result.
So, please can you provide me a solution for that problem? What should I do? How can I make optimization process better. Is it related because of not being able to match the features? Thank you very much.

Hi，I also encountered the same problem, with the trajectory experiencing the same drift. Have you solved this problem and can you provide a solution


Run SonarCloud only on pull requests to master

Run SonarCloud less often to reduce build times for normal CI builds.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: BETONMICHAel sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Scroll trembling and menu active menu

Hi, have a little problem here, will be grateful for your help!
I used your scrollify.js on wordpress site http://doktor.hekko24.pl.
The Wordpress itself has Jupiter theme installed. So there is the question:

When i scroll my website I see page trembling - on your demos there's not. I guess it's because of a complicated Jupiter layout or there is another reason?

The most important thing. I need my stick menu link to be active while I scroll the page. I tried to achieve it in different methods, but i think that it's something wrong with my scrollify.js setup.

Thanks!

This question should be posted on Stackoverflow.com


[Regression] - V2 - CLA Not Signed - Request failed error is displayed when trying to identify user without LFID as cla manager designee

Prerequisite

Create a CLA group with CCLA enabled (Tested with project level CLA Group)
Add github repository for the CLA group
Generate template

Steps to Follow

Login to Github as corporate contributor
Navigate to the repository used in prerequisite
Create PR
CLA check fails
Click on CLA NOT SIGNED
Contributor is redirected to Contributor Console
Click on Proceed as a Corporate Contributor
Select Company that has not signed CLA for the project and the company does not have company owner
Click Proceed
Click No
Enter name and email of user who does not have LFID
Observed Request Failed error is displayed. However email is sent to the user

Verified that the issue is fixed


Group JSON Data for x axis

Hi,
I have something like this:
//----------------------------------------------------------------------------------------------------------------

Hi! This is more of a support question — would you mind please asking instead on the C3 Google Group or Gitter channel? Thanks!


Error detected while processing /Users/foo/.vimrc:

I followed all the steps for macOS on README and if I try to open vim (not neo) or run vim +PlugInstall +qall I get a lot of errors:
Error detected while processing /Users/foo/.vimrc:
line   25:
E117: Unknown function: plug#begin
line   30:
E492: Not an editor command: Plug 'scrooloose/nerdtree'
line   31:
E492: Not an editor command: Plug 'jistr/vim-nerdtree-tabs'
line   32:
E492: Not an editor command: Plug 'tpope/vim-commentary'
line   33:
E492: Not an editor command: Plug 'tpope/vim-fugitive'
line   34:
E492: Not an editor command: Plug 'ctrlpvim/ctrlp.vim'
line   35:
E492: Not an editor command: Plug 'vim-airline/vim-airline'
line   36:
E492: Not an editor command: Plug 'vim-airline/vim-airline-themes'
line   37:
E492: Not an editor command: Plug 'airblade/vim-gitgutter'
line   38:
E492: Not an editor command: Plug 'sheerun/vim-polyglot'
line   39:
E492: Not an editor command: Plug 'vim-scripts/grep.vim'
line   40:
E492: Not an editor command: Plug 'vim-scripts/CSApprox'
line   41:
E492: Not an editor command: Plug 'bronson/vim-trailing-whitespace'
line   42:
E492: Not an editor command: Plug 'Raimondi/delimitMate'

Ps: I already have git and ctags installed.

Do you have this file at your home directory? ~/.vim/autoload/plug.vim

I do not even have the ~/.vim directory, let alone the ~/.vim/autoload/.

@glaucocustodio it's strange, @lerrua also uses macOS and it works. Can you share your generated .vimrc with us, @lerrua can replicate this issue.

@glaucocustodio are you using El Capitain or Sierra?

@cassiobotaro Is this a duplicated issue? #204

@vmesel maybe, but are different OS...

@glaucocustodio Related issues were resolved by reinstalling vim, apparently macos changes symbolic links when updated, replacing vim installed with homebrew with macos native vim.
If bug persists, feel free to reopen this issue or open a new one.
Thanks to report!

I have the same problem, but on linux.
I'm using a fresh install of elementary OS 0.4
VIM 7.4
My generated.vim content: https://gist.github.com/beeblebrox3/7d4a0886633eefbb41fd4cde812f21c4
I have the same problem on Mint 18, also on a fresh install.

@beeblebrox3
Verify that you have already installed all dependencies: sudo apt-get install git exuberant-ctags ncurses-term curl
Linux tip: use vim-nox instead of vim: sudo apt-get install vim-nox
After copy .vimrc into $HOME run the follow command vim +PlugInstall +qall

Oh, I didn't know about this dependencies. But no success :(
Thanks, @cassiobotaro

@beeblebrox3 delete  ~/.vim directory, install dependencies and try again. If error persists let's schedule a call...

Didn't work, but I did something that worked.
I downloaded the vim-plug with
curl -fLo ~/.vim/autoload/plug.vim --create-dirs https://raw.githubusercontent.com/junegunn/vim-plug/master/plug.vim
And run vim, but got the error "Cannot find color scheme 'molokai'", like on issue #107. But vim opened. Then I run :PlugInstall and looks like is working now. I will try on my work computer (the one with mint) to see if works there too.
Thanks, @cassiobotaro .

I just had this same issue. I tried to install my bootstrapped vimrc without installing the dependencies and got the same error log in the beggining of the issue. I installed the dependencies, deleted my .vim folder but still got the same behavior.
After that, I installed the  vim-plug using the command suggested by @beeblebrox3, got the same error regarding molokai but everything worked fine

I run command :   vim +PluginInstall +qall,
note:my mac system os MacOS Mojave
an error happened
Error detected while processing /Users/xp/.vimrc:
E117: Unknown function: vundle#begin
E492: Not an editor command: Plugin 'VundleVim/Vundle.vim'
E492: Not an editor command: Plugin 'scrooloose/nerdcommenter'


New Game: Booster Chess

Play 3 games, with cards to help you win. At the beginning, divide the cards into 3 sets, one per game. One version allows black to gerrymander the 3 sets and is unfair. The other version uses define and combine, so it should be fair.
How to use the cards? Maybe play your own pieces to add a boost, like in Adrenaline Chess and play your opponent's pieces to hobble them. (Ranged pieces can only move one space, or half their potential.) Matching colour checkers are boosts, and opposite colour checkers are hobbles. A hobble is removed after making one hobbled move. Play cards and add checkers at the end of your turn.

Hobbles conflict with Gerrymander design? Recycle cards of your own colour after you've played everything in your hand? Draw one card at the end of each turn?

Giving up on Gerrymander idea for now, focus on booster vs. hobble.

Dropped boosting, and just kept hobble in Tar Pit Chess. Closing this one for now.


AMCBLDC – Complete the STATUS msg

As of now, we only send the quadrature voltage and a flag reporting the status of the external e-stop.
However, the STATUS message has many more flags that are meant to be transmitted, although many are not yet handled internally.

xref:

https://github.com/robotology/icub-firmware/issues/360#issuecomment-1544022704.


Reduce Replacement: WorldTracker

These changes are in the current m4a-ppe branch -- y'all can use that branch for testing if you'd prefer to download 1 version of files instead of 5 or 6 different ones.  I'll leave the pull requests all separated, however.
Was looking at the WorldTracker issue mentioned in #122 - in an attempt to solve compat issues with the black death scenario. Unfortunately the issues with that scenario go beyond just whatever was going on with WorldTracker, but these changes at the very least accomplish the goal of reducing the full-on replacing of files.
The version of WorldTracker that CQUI had in place was not entirely up to date with the one currently in the game.  The only things it really did was to add tool tips to the Research and Civics panels on the left side.  The changes in this file implement those tool tips and otherwise things seem to work fine.
Tested with Base, EXP1, EXP2

@the-m4a Please see my comments in the issue #122 first.

@the-m4a Please check your issue with BlackDeath scenario.

Cleaned up the modinfo conflict, thanks for the review @Infixo


error installing yeoman generator

npm ERR! Darwin 14.3.0
npm ERR! argv "node" "/usr/local/bin/npm" "install" "-g" "generator-mobileangularui"
npm ERR! node v0.12.2
npm ERR! npm  v2.11.2
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>postinstall: node install.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script 'node install.js'.
npm ERR! This is most likely a problem with the unicode package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node install.js
npm ERR! You can get their info via:
npm ERR!     npm owner ls unicode
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /Users/hannade/Developer/yoRDC/npm-debug.log

@drkhannah yo mobileangularui has been updated since that. But please post this kind of issues to the right repo: https://github.com/mcasimir/generator-mobileangularui