Crash on android when call init()

When I call function OneSignal.init(), my app crashes immediately
My code
componentDidMount() {
    OneSignal.init('7b5d2490-xxxxxxxxxxxxxxxxxxxxx');
    ...
}

"react": "16.3.1",
"react-native": "0.55.4",
"react-native-onesignal": "^3.2.0",

Android log:

05-09 10:03:30.068: D/FirebaseApp(4036): com.google.firebase.auth.FirebaseAuth is not linked. Skipping initialization.
05-09 10:03:30.072: E/AndroidRuntime(4036): FATAL EXCEPTION: pool-7-thread-1
05-09 10:03:30.072: E/AndroidRuntime(4036): Process: com.appartment_app, PID: 4036
05-09 10:03:30.072: E/AndroidRuntime(4036): java.lang.IllegalStateException: Default FirebaseApp is not initialized in this process com.appartment_app. Make sure to call FirebaseApp.initializeApp(Context) first.
05-09 10:03:30.072: E/AndroidRuntime(4036): 	at com.google.firebase.FirebaseApp.getInstance(Unknown Source)
05-09 10:03:30.072: E/AndroidRuntime(4036): 	at com.google.firebase.iid.FirebaseInstanceId.getInstance(Unknown Source)
05-09 10:03:30.072: E/AndroidRuntime(4036): 	at com.google.firebase.iid.FirebaseInstanceIdService.zza(Unknown Source)
05-09 10:03:30.072: E/AndroidRuntime(4036): 	at com.google.firebase.iid.FirebaseInstanceIdService.handleIntent(Unknown Source)
05-09 10:03:30.072: E/AndroidRuntime(4036): 	at com.google.firebase.iid.zzc.run(Unknown Source)
05-09 10:03:30.072: E/AndroidRuntime(4036): 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)
05-09 10:03:30.072: E/AndroidRuntime(4036): 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588)
05-09 10:03:30.072: E/AndroidRuntime(4036): 	at java.lang.Thread.run(Thread.java:818)
05-09 10:03:30.136: D/ReactNative(4036): ReactInstanceManager.detachViewFromInstance()
05-09 10:03:30.419: D/EGL_emulation(4036): eglMakeCurrent: 0xedb13fc0: ver 2 0 (tinfo 0xea1bcc40)
05-09 10:03:30.420: E/Surface(4036): getSlotFromBufferLocked: unknown buffer: 0xf407eec0
05-09 10:03:33.523: I/Process(4036): Sending signal. PID: 4036 SIG: 9

Hi @building-software-2018 , are you only using react-native-onesignal as a dependency, or does your application have other dependencies as well? Are you using Firebase analytics?

@Nightsd01 related to #489, i've added OneSignal.init() to my code and app crashes with same error.
Before adding OneSignal.init() from android logcat, i've seen "OneSignal.init not called".
I'm using
compileSdkVersion 23
buildToolsVersion "23.0.1"
minSdkVersion 16
targetSdkVersion 22
compile "com.android.support:appcompat-v7:23.0.1"
classpath 'com.android.tools.build:gradle:2.2.3'
I tried to update to latest versions or, at least, get those used on example project and my app doesn't build anymore with this error
 Task :react-native-google-analytics-bridge:compileDebugJavaWithJavac E:\Progetti\TruckyV2\node_modules\react-native-google-analytics-bridge\android\src\main\java\com\idehub\GoogleAnalyticsBridge\GoogleAnalyticsBridgePackage.java:8: error: package com.google.android.gms.tagmanager does not exist import com.google.android.gms.tagmanager.ContainerHolder;

@shardick that would be an issue with the google analytics bridge. Try defining your google play services version in android/gradle.properties like this:
googlePlayServicesVersion=11.8.0

@Nightsd01 fixed now, using this comment
https://github.com/idehub/react-native-google-analytics-bridge/issues/238#issuecomment-381555995
for @building-software-2018 , this is my root build.gradle
`
// Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript {
repositories {
jcenter()
google()
mavenLocal()
}
dependencies {
classpath 'com.android.tools.build:gradle:3.0.1'
    // NOTE: Do not place your application dependencies here; they belong
    // in the individual module build.gradle files
}

}
allprojects {
repositories {
configurations.all {
resolutionStrategy.eachDependency { DependencyResolveDetails details ->
def requested = details.requested
if (requested.group == 'com.google.android.gms') {
details.useVersion '12.0.1'
}
}
}
mavenLocal()
jcenter()
google()
maven {
url "https://jitpack.io"
}
maven {
url 'https://maven.google.com'
}
maven {
// All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
url "$rootDir/../node_modules/react-native/android"
}
}
}
subprojects {
afterEvaluate {project ->
if (project.hasProperty("android")) {
android {
compileSdkVersion 26
buildToolsVersion '26.0.2'
}
}
}
}
`
in app build.gradle
compileSdkVersion 27
buildToolsVersion "27.0.3"
compile "com.android.support:appcompat-v7:27.1.0"
compile, run, load and subscribe on OneSignal after OneSignal.init

@building-software-2018 if you’re still having this issue could you post your full app/build.gradle?
Sent with GitHawk

@building-software-2018 Due to a lack of response I'll assume you were able to fix the issue. If you're still having this problem please feel free to respond and I'll reopen

same issue

Hi all,
I've faced the same issue, app crashes on opening when OneSignal.init() is called.
Apart onesignal I also use react-native-maps (found a ticket that can be conflict when using both libs, but in my case all is configured properly) and react-native-deviceinfo.
What possible reasons can be?

Hello @aramknyazyan I have same issues and I know it's a clash with react-native-maps. Have you been able to resolve this?

Hi @kenshinman, I didn't waste my time on it, just switched to react-native-push-notification :)

same issue. My build.gradle is:
`buildscript {
repositories {
maven { url 'https://plugins.gradle.org/m2/' } // Gradle Plugin Portal
}
dependencies {
classpath 'gradle.plugin.com.onesignal:onesignal-gradle-plugin:[0.10.0, 0.99.99]'
}
}
apply plugin: 'com.onesignal.androidsdk.onesignal-gradle-plugin'
apply plugin: "com.android.application"
import com.android.build.OutputFile
/**

The react.gradle file registers a task for each build variant (e.g. bundleDebugJsAndAssets
and bundleReleaseJsAndAssets).
These basically call react-native bundle with the correct arguments during the Android build
cycle. By default, bundleDebugJsAndAssets is skipped, as in debug/dev mode we prefer to load the
bundle directly from the development server. Below you can see all the possible configurations
and their defaults. If you decide to add a configuration block, make sure to add it before the
apply from: "../../node_modules/react-native/react.gradle" line.

project.ext.react = [
// the name of the generated asset file containing your JS bundle
bundleAssetName: "index.android.bundle",

// the entry file for bundle generation
entryFile: "index.android.js",

// whether to bundle JS and assets in debug mode
bundleInDebug: false,

// whether to bundle JS and assets in release mode
bundleInRelease: true,

// whether to bundle JS and assets in another build variant (if configured).
// See http://tools.android.com/tech-docs/new-build-system/user-guide#TOC-Build-Variants
// The configuration property can be in the following formats
//         'bundleIn${productFlavor}${buildType}'
//         'bundleIn${buildType}'
// bundleInFreeDebug: true,
// bundleInPaidRelease: true,
// bundleInBeta: true,

// whether to disable dev mode in custom build variants (by default only disabled in release)
// for example: to disable dev mode in the staging build type (if configured)
devDisabledInStaging: true,
// The configuration property can be in the following formats
//         'devDisabledIn${productFlavor}${buildType}'
//         'devDisabledIn${buildType}'

// the root of your project, i.e. where "package.json" lives
root: "../../",

// where to put the JS bundle asset in debug mode
jsBundleDirDebug: "$buildDir/intermediates/assets/debug",

// where to put the JS bundle asset in release mode
jsBundleDirRelease: "$buildDir/intermediates/assets/release",

// where to put drawable resources / React Native assets, e.g. the ones you use via
// require('./image.png')), in debug mode
resourcesDirDebug: "$buildDir/intermediates/res/merged/debug",

// where to put drawable resources / React Native assets, e.g. the ones you use via
// require('./image.png')), in release mode
resourcesDirRelease: "$buildDir/intermediates/res/merged/release",

// by default the gradle tasks are skipped if none of the JS files or assets change; this means
// that we don't look at files in android/ or ios/ to determine whether the tasks are up to
// date; if you have any other folders that you want to ignore for performance reasons (gradle
// indexes the entire tree), add them here. Alternatively, if you have JS files in android/
// for example, you might want to remove it from here.
inputExcludes: ["android/", "ios/"],

// override which node gets called and with what additional arguments
nodeExecutableAndArgs: ["node"],

// supply additional arguments to the packager
extraPackagerArgs: []
]
*/

project.ext.react = [
entryFile: "index.js"
]
apply from: "../../node_modules/react-native/react.gradle"
/**

Set this to true to create two separate APKs instead of one:

An APK that only works on ARM devices

An APK that only works on x86 devices

The advantage is the size of the APK is reduced by about 4MB.
Upload all the APKs to the Play Store and people will download
the correct one based on the CPU architecture of their device.
*/
def enableSeparateBuildPerCPUArchitecture = false

/**

Run Proguard to shrink the Java bytecode in release builds.
*/
def enableProguardInReleaseBuilds = false

android {
compileSdkVersion 27
buildToolsVersion "27.0.3"
defaultConfig {
    applicationId "com.nativebasekitchensink"
    minSdkVersion 16
    targetSdkVersion 25
    versionCode 1
    versionName "1.0"
    ndk {
        abiFilters "armeabi-v7a", "x86"
    }
}
splits {
    abi {
        reset()
        enable enableSeparateBuildPerCPUArchitecture
        universalApk false  // If true, also generate a universal APK
        include "armeabi-v7a", "x86"
    }
}
buildTypes {
    release {
        minifyEnabled enableProguardInReleaseBuilds
        proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"
    }
}
// applicationVariants are e.g. debug, release
applicationVariants.all { variant ->
    variant.outputs.each { output ->
        // For each separate APK per architecture, set a unique version code as described here:
        // http://tools.android.com/tech-docs/new-build-system/user-guide/apk-splits
        def versionCodes = ["armeabi-v7a":1, "x86":2]
        def abi = output.getFilter(OutputFile.ABI)
        if (abi != null) {  // null for the universal-debug, universal-release variants
            output.versionCodeOverride =
                    versionCodes.get(abi) * 1048576 + defaultConfig.versionCode
        }
    }
}

}
dependencies {
compile project(':react-native-onesignal')
compile project(':react-native-vector-icons')
compile fileTree(dir: "libs", include: ["*.jar"])
compile "com.android.support:appcompat-v7:23.0.1"
compile "com.facebook.react:react-native:+"  // From node_modules
}
// Run this once to be able to run the application with BUCK
// puts all compile dependencies into folder libs for BUCK to use
task copyDownloadableDepsToLibs(type: Copy) {
from configurations.compile
into 'libs'
}
`
working correctly on ios and if i remove the call then everything else works (besides onesignal/pushes of course).

I have the same issue, I'm only using this packages:
"native-base": "^2.4.3",
"react-native-image-slider": "^2.0.3",
"react-native-onesignal": "^3.2.5",
"react-native-photo-view": "^1.5.2",
"react-native-router-flux": "^4.0.0-beta.28"
Tried everything the problem still accures. App work fine If I remove:
componentWillMount() {
    OneSignal.init("00000000000");
    OneSignal.addEventListener('received', this.onReceived);
    OneSignal.addEventListener('opened', this.onOpened);
    OneSignal.addEventListener('ids', this.onIds);
}

bump. anyone else experiencing this or have a fix for it?

If your app is getting the push notification and crashing immediately, you have to add the following line in your app\bulild.gradle
compile 'com.google.firebase:firebase-messaging:17.1.0'
you may also want to add the following line in your componentDidMount() :
OneSignal.registerForPushNotifications();


Touchscreen troubles

I've been working hard to enable interrupt-driven touch events but without success. This is what I've discovered:

With LittlevGL (the currently used graphic library), any touch event crashes the application
It works with the Adafruit GFX library, but then the RTT console and logging must be disabled (otherwise the program crashes immediately) and it requires a switch to C++ and dependency on Arduino library functions.

So, how should we proceed?

Live without logging, introduce bloat and switch to Adafruit GFX?
Drop touch and focus on other things, but then how should user interaction take place? We've got the button, but how far does that take us?
Fix the crashes, rewrite the driver or do other hard work?

I've now pushed an experimental "tap to crash" branch (enable-touchscreen). Sometimes the debug log prints the following message before freezing the application:
assertion "p_cb->state != NRFX_DRV_STATE_UNINITIALIZED" failed: file "WEST_TOPDIR/modules/hal/nordic/nrfx/drivers/src/nrfx_spi.c", line 347, function: nrfx_spi_xfer

I just looked inside cst816s_trigger.c and discovered the CONFIG_CST816S_TRIGGER_GLOBAL_THREAD. Using this instead of OWN_THREAD made it work!


Convert locked balances

We should be able to convert locked balances from tfchain

Blocked by https://github.com/threefoldfoundation/tft-stellar/issues/118


Display route distance

Hello,
Does it support route distance calculation ?
Thanks.

duplicate and closing in favor of #62


Fix exclamation mark

Hi @dj1yfk,
I noticed that the encoding of the exclamation marks does not match the ones listed in the Wikipedia article. I took that opportunity to fix some other minor issues.

Sorry for the late reaction. Guess it's the right thing to do to use the "official" exclamation mark sign.
If anyone wants to have the "Scandinavian" version of it (..--.), it's easy enough to patch it :-)


added features

Added/Changed a couple of things:

Save Folder : Import recipe in a specific directory (Does a check for existing folder and creates if it doesn't exist)
Save in currently opened file : Added option to import into an active file (if no active file, follows folder settings)
Changed command to appear globally (as the new settings take care of the import location)
Added link to README in template description (minor ik lol)
Reordered settings page for convenience

BTW, thank you for this amazing plugin.

This looks awesome. Thanks so much for taking the time to do it @Flxp49 . I'm away from the computer for a couple more days, but will definitely go through this when I get back!

Truly excellent work here. Thanks again for taking the time, and please don't hesitate to contribute anything in the future, it really helps. I'll get this in the next release.
If you have any other ideas of how to improve it, please create an issue and i'd be happy to make a plan to get them in.


New handling of external libraries

Similar to #437
Ninja support:

[ ] Do we still need byproduct creation for ninja support or does it work now without? @reinago @schulzch

Only tested with the default turned on plugins. The following need to be adapted:

[ ] tracking
[ ] adios2
[ ] snappy
[ ] IceT

Platforms:

[ ] Tested on Linux
[ ] Tested on Travis
[ ] Tested on Appveyor

Only downside I can see so far is that initial configure step takes a lot of time now. Subsequent ones not, however.

Ninja has to know how to obtain a dependency, i.e., the BYPRODUCT has to be specified properly

Only downside I can see so far is that initial configure step takes a lot of time now. Subsequent ones not, however.

Isn't this exactly what we want (move build time to configuration time). If it only slows down the frist configuration, but not subsequent ones: even better! Anyway, do we have (handweavy) numbers on this?


Finished connecting to voice event

General Troubleshooting
Hey there! Before you report a bug or suggest a new feature,
please make sure to follow these steps first!

[x] I have checked for similar issues.
[x] I have updated to the latest JDA version.
[x] I have checked the branches or the maintainers' PRs for upcoming features/bug fixes.

This is not the place to learn Java. Please refer to StackOverflow
for your general programming questions.

Issue
Issue Type

[ ] Bug Report
[x] Feature Request

For questions join the official JDA discord server: https://discord.gg/0hMr4ce0tIl3SLv5

Description
Right now, when the bot joins a voice channel, a GuildVoiceJoinEvent is fired. When this event is fired, the bot has not actually joined any channel yet - it's connection status is still NOT_CONNECTED and it's still attempting to connect. This creates some difficulty with handling audio sending right off the bat.
I propose another event be added, like GuildVoiceReadyEvent (which obviously fires for only the bot) when the audio connection is established and audio is ready to be sent.

This is completely unneeded as ConnectionListener and ConnectionStatus already exist.
Register your ConnectionListener with an AudioManager via AudioManager#setConnectionListener before starting a connection.


remove cxx TM autolinking

Summary:
Changelog: [iOS][Android][Breaking]
this was a meaningful exploration, but since we have support in TM for jsi runtime access and that's been widely advertised and accepted, let's get rid of this. it's a bit hacky and hard to use (shown by no one using it), so i want to stop any possibility of its usage.
if interested in accessing jsi::Runtime via a native module, please consider the following options:

[Android] BindingsInstaller: https://github.com/facebook/react-native/pull/44526
[iOS] RCTTurboModuleWithJSIBindings: https://github.com/facebook/react-native/pull/44486
C++ TurboModules (no autolinking): https://github.com/reactwg/react-native-new-architecture/blob/main/docs/turbo-modules-xplat.md

For what it's worth, I actually liked the simplicity of this API as it didn't rely on any React Native auto-linking / code generation to "pick up" and call into it. All you needed was some C++ code calling into this function "on load". Looking at https://github.com/search?q=registerCxxModuleToGlobalModuleMap&type=code it also seems other notable packages were toying around with it) and I had a branch of realm where I was also contemplating using it.
Although I understand the desire to avoid fragmentation, I'm a bit sad to see it go 😞

but since we have support in TM for jsi runtime access and that's been widely advertised and accepted, let's get rid of this.

What does this mean?
There seems to be a couple of projects out in the wild that actually relies on this, like https://github.com/mrousavy/react-native-mmkv/blob/12c051704e0db363f9f63d2b30dbf291151f90d4/package/ios/MmkvOnLoad.mm#L18, cc @mrousavy), and I was going to make my own C++ TM using this method. Instead of using this, what would be the recommended approach?

woah - I use this in a lot of libraries! I use this in react-native-mmkv, nitro (the upcoming "Nitro Modules" library), and a few others that fully rely on this.
Any chance we can keep this?

I need access to jsi::Runtime and std::shared_ptr<CallInvoker> in my modules. I don't think the other APIs you suggested have this feature.
Also, Nitro is a CxxTurboModule (both on iOS and Android) that does not use CodeGen - this means that on Android, it is not built by CodeGen's CMake project, but instead built by it's own build.gradle's externalNativeBuild spec.
This would completely break that flow..

sorry all i apologize, i did not realize that there was actually interest in using this, i thought it was so unwieldy that no one would understand how to use it! but this is a good opportunity now to see if we can come up with a more formalized replacement.
the main reason i wanted to get rid of it is because it was extremely hacky, didn't work in it's original form without updating the compiler, and @mrousavy had to add that +load in order to get things to actually work. i don't think he even used the macro. (also apologies, i didn't know you actually committed to using this, thought it was just prototyping!). and i was skeptical it would lead us to a place where we would find a safer autolinking solution.
since TM now has the installJSIBindings flow, i thought that we can use TM as a forwarding layer to a shared C++ layer which kinda can fulfill the role of reusing shared code. but i understand that we can't leverage the lifecycle management of TM within a pure C++ environment.
let me follow up to these comments to see if we can reintroduce this in a form that is more stable.

I need access to jsi::Runtime and std::shared_ptr<CallInvoker> in my modules. I don't think the other APIs you suggested have this feature.
Also, Nitro is a CxxTurboModule (both on iOS and Android) that does not use CodeGen - this means that on Android, it is not built by CodeGen's CMake project, but instead built by it's own build.gradle's externalNativeBuild spec.
This would completely break that flow, and I don't think there's any alternatives?..

thanks for surfacing this marc. i see the callsite in +load on iOS. how does the registration work on android? do you actually use the macro, or just the C++ methods like registerCxxModuleToGlobalModuleMap?

Feels like this could've been a discussion. Some developers were already building on top of this. For instance we had a C++ only TurboModule in the works for create-react-native-library.

yes, in hindsight that appears to be the case! i'm sorry for the churn. do you have examples of how you were using the API to register your modules?

No worries thanks @philIip !! :)

do you actually use the macro, or just the C++ methods like registerCxxModuleToGlobalModuleMap? how did you register in Android?

Yea on iOS I use +load, but on Android I have to create a dummy Java package which does nothing except loading the C++ library. This calls JNI_OnLoad, which then calls the register... func, same way as on iOS.
I'm not so sure about the installJSIBindings - does this also contain the CallInvoker? I'd need that too

(it has to be a dummy Java package for autolinking to initialize it)

No worries thanks @philIip !! :)

do you actually use the macro, or just the C++ methods like registerCxxModuleToGlobalModuleMap? how did you register in Android?

Yea on iOS I use +load, but on Android I have to create a dummy Java package which does nothing except loading the C++ library. This calls JNI_OnLoad, which then calls the register... func, same way as on iOS.
I'm not so sure about the installJSIBindings - does this also contain the CallInvoker? I'd need that too

i see, so there's no usage of the RCT_EXPORT_CXX_MODULE_EXPERIMENTAL macro? that's the part i mainly found problematic, because it would often get stripped by the compiler. i'd like to get rid of that, would that be okay? it shifts the burden of the actual link onto the library, but it seems like that's already the case for you.

Yep the macro is not used! I can also create the revert PR with just the macro removed if that lifts some work off your shoulders! Thanks

Created a PR here: https://github.com/facebook/react-native/pull/46360


[META] Implementing Resource Permissions

Description
Coming from https://github.com/opensearch-project/security/issues/4500 and its discussions, this meta issue aims at tracking the implementation of the feature by breaking it down into smaller tasks.
Tasks

[ ] opensearch-project/OpenSearch#14751
[ ] opensearch-project/security#4562
[ ] Introduce a feature flag for initial release to allow seamless upgrade experience
[ ] Implement end-to-end testing and ensure backwards compatibility
[ ] Remove feature flag in the next release and mandate the feature
[ ] Modify relevant tests to ensure no authorization without relevant resource permissions

[Triage] Marking this issue as triaged. Please ensure that all items in the checklist have associated issues to track implementation.


Content projection into In-Component modal

I want to ask whether it is possible to inject the ng-content and a component together into a modal via NzModalService.create function.
Actually inside a modal component, I want to use <ng-content select="[anElement]"></ng-content>. I'm curious, whether it is possible or not.

you can pass a TemplateRef as the component Input to the modalService.create(Component)


Typeahead vulnerable to cross-site scripting attack

Plunker showing XSS with onClick and onMouseOver: http://plnkr.co/edit/STR8SfgvtUdNopDS5Lam?p=preview
Plunker seems to protect against automatically running a script tag, but I was able to reproduce that locally -- the alert runs after the typeaheadHighlight filter's strong tag moved beyond the closing angle bracket of the script tag.
Previous issue: https://github.com/angular-ui/bootstrap/issues/3175

Your use case is similar to, but not identical to the one I created in #3175 . In our case, the vulnerability seemed to be caused by an artificial condition we were introducing (which is why I closed it). I'd agree that this is substantially different, and appears to be an exploitable attack vector.

I wasn't careful about describing the script and strong tags and half of my comment got sanitized (I've now corrected this).  I cross referenced the tickets.

I suspected this was a potential problem, which is why #4073 exists. The problem at its core is the custom bind-html-unsafe directive, which is a bit of a hack - we are in the process of getting rid of this last vestige present in the typeahead component.

This issue should now be fixed in master due to #4073 being resolved.


Use case

Hey Sony!
I like pocketbase and currently builing an app based on it.
I was wondering what are the benefits of using Docker or Docker Compose in this use case over the single file execution.
Just being curious about it :)

Hi @vinyll thanks for the question. Why Docker? Ya it depends on the requirements. I have all services runs on Docker containers, such as Nginx,  PHP, MySQL, so by dockerized Pocketbase to so I can run many Pocketbase instances for different projects on containers.


Deny Muted users permissions to send messages in threads

Purpose
Currently, those with the Muted role only have the ADD_REACTIONS, SEND_MESSAGES, and SEND_TTS_MESSAGES denied. With the introduction of threads, we also need to prevent them from creating threads, sending messages in them, and using slash commands.
Proposed Solution
Deny the additional relevant permissions (full list here) in the applyMute handler.
Acceptance Criteria
Please list the requirements the implementation of this feature should meet.

[ ] Users with the Muted role should not be able to create private or public threads, nor send messages in existing threads.
[ ] They also should not be able to use slash commands.

Will work on this after the mute commands are ported over to v13.


Improve merging of proxy config proxyMetadata

This is useful for pod annotation overrides and for
shared_user_mesh_config. Basically if the top level sets a proxy
metadata, which may be for critical fields like CA_ADDRESS, anyone below
it will override them completely which will often lead to breakages.
This allows a deeper merge
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
994b04d31151fff01c5693d4916ae6a6fb99b206
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
994b04d31151fff01c5693d4916ae6a6fb99b206
link
/test unit-tests_istio

integ-pilot-multicluster-tests_istio
994b04d31151fff01c5693d4916ae6a6fb99b206
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
afb8b14d5b7cca1e76f81b174ea12c9d3a9717e6
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

In response to a cherrypick label: new pull request created: #33529

In theory yes it can. Previously we used replace semantics which means if the users knows what they are doing they can do everything including removal of prior keys.
Merge semantics are more natural, but if have provided proxy config with the knowledge of replace semantics then it will break you.
we need to identify specific keys as examples to see if this is academic or a real breakage.

@howardjohn can you look at my and @mandarjog comments? I want to make sure we cover any upgrade issues that may arise due to this change.

@nrjpoddar I feel about the same as Mandar. Like any behavioral change, included pure bug fixes, this could impact a user. However, I find it unlikely. The most common case of mesh-wide proxyMetadata is to configure control plane access (CA address, and the root cert configs - required for external Istiod). The problem that arises is then that essentially for external istiod, you cannot set the proxy metadata on a per-pod basis (since you will break control plane access).
I have never seen any case of someone intentionally unsetting a variable. In the case that they are, this is something still support, they just need to do it explicitly rather than implicitly.


Replace grunt-autoprefixer with grunt-postcss

https://github.com/nDmitry/grunt-autoprefixer was deprecated in favor of https://github.com/nDmitry/grunt-postcss
Btw. I was only able to generate working source map when generating source map in sass.js and also in PostCSS

Fixed in be418f55c34cc283d74d9c13b630de3fa52beb5b


⚠ Secret Website 3 has degraded performance

In 8066f62, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 13277 ms

Resolved: Secret Website 3 performance has improved in fb906b1.


CodePlayground.get_codes doesn't return data.

This method as the name suggest get_codes() sounds like it should return something but it doesn't.

Issue fixed

I think we should also fix other similar methods also that doesn't return the data

All done.


can Rubicon extend from Base?

Is your enhancement request related to a problem? Please describe
it seems like we've reimplemented nearly all the Base functionality on the Rubicon object at this point
Describe the solution you'd like
we should just inherit from the Base if possible
Describe alternatives you've considered
keep the duplicated code as-is

no - we will leave this as is


bug: Long dynamic header titles are cutoff

Type: bug
Platform: ios 7 webview
In multiple Ionic apps where I need to set the view title dynamically, I use this markup:
<ion-view>
    <ion-nav-title ng-bind="category.name"></ion-nav-title>
    <ion-content>
    ...snip...

That works great until it encounters a view title that too long to fit in the bar (easier to test on smaller devices like iPhone 4/5).  With a long value, it displays just like one character and the ellipsis.
I fix it by adding this to my scss:
// Longer ion header titles intermittently have crazy large right values on iOS
.platform-ios,
.platform-browser {
  .title.title-center.header-item {
    right: 26px !important;
  }
}

This seems like it might just be an issue with the Angular lifecycle of things, and might not be a clean fix on the Ionic side. (Similar to the issue of why view-title="{{category.name}}" has issues.)

Codepen demo please

http://codepen.io/davidfrahm/pen/vNPoVa
Make the viewport really small, reload the page, then click the button to navigate to the view with long/broken title

Any news on this?
Same issue as #945 which was reopened. No feedback on that one either

+1

+1. I met the same problem

+1 . Yes, this issue has no longer fixed completely for long time

+1

+1

thanks @DavidFrahm for the codepen! We are definitely gonna have to take a look at this. It looks like the title is overflowing way too early, is that the issue you all are describing?

@jgw96 Yes, that sounds like one way to look at it.  Honestly, it's been a long time and I've just become used to it and always use the CSS workaround in all my projects.

Happens for me too

annoying..

Here is my workaround.
//Hack to fix squashed title on iOS
// ionic issue #4661
.platform-ios {
  .title.title-center.header-item {
    left: 49px!important;
    right: 49px!important;
  }
}

.platform-android {
  .title.title-left.header-item {
    right: 68px!important;
  }
}

Great thanks!

Only problem I find with this workaround is that long titles will overlap the "Back » button. Would there be a way to do like native, to make header title go to the left (screenshot 2).

What screenshot? I am having no issue with back button overlap with this solution.

Hello everyone,
This fix will be in the nightly build tonight.
Full disclosure - there are several fixes we could do make with the header, this is a start.  If you dynamically add buttons next to this, you may still run into problems.  That is a separate issue that we need to fix as well.
Please test and let me know how it goes.  The easiest way to test is to download the nightly ionic.bundle.js file and place it in your project's lib/ionic/js directory, and then make sure your html file is importing the file correctly.
If needed, we'll reopen this.
Thanks,
Dan

Hello,
Thanks for this fix, I waited for it but in my case it does not work. So, I searched for what was happening and I found out that on the method  "self.titleTextWidth", if I comment the break inside the "for" loop (js/angular/controller/headerBarController.js, line 1154), it works (As the element retrieved is always the one in my previous page with the current code).
Maybe the cause of the problem is that I always have tabs at the bottom of my page and they are always here after navigation.
Thanks in advance.
Regards
Magalie

The issue is actually that it use the first element with the nav-bar-title class, but it can be the one hidden (cached) from the previous screen, used for animations. A proper fix is:
      var children = angular.element(element).children();
      for ( var i = 0; i < children.length; i++ ) {
        var child = angular.element(children[i]);
        if ( child.hasClass('nav-bar-title') && !child.hasClass('hide') ) {
          element = children[i];
          break;
        }
      }

Thanks @magaliegimenes for the hint!

Facing this issue on Ionic 3.9.2 after using the SideMenu starter project


Form  Switch Toggle Button "Value"  gets reassigned to "Null"

On trying to  access the bool output 'value' of a Form Switch Toggle Button in  Form.onSaved() , the changed bool value gets  reassigned to Null .
The Switch Button works and the value changes to true/false when the button is toggled , but on Form Submit the value is reassigned to Null .
This value can be used to create conditional onSave() statements.
How to get the last state of the Switch 'value'?

OUTPUT :
I/flutter (11255): _toggleState = true
I/flutter (11255): _toggleState = false
I/flutter (11255): _toggleState = true
I/flutter (11255): Form.onSaved() _toggleState = null

CODE  :
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'IntraClass Switch State -> NULL',
      theme: ThemeData(
        primarySwatch: Colors.orange,
      ),
      home: MyHomePage(title: 'IntraClass Switch State -> NULL'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  final String title;
  MyHomePage({Key key, this.title}) : super(key: key);

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  String _switchCase = 'OFF';
  bool _toggleState = false;
  String _passData;

  final _formKey = GlobalKey<FormState>();

  void _attemptChange(bool newState) {
    setState(() {
      _toggleState = newState;
      newState ? _switchCase = 'ON' : _switchCase = 'OFF';
      print('_toggleState = $_toggleState ');
    });
  }

  Widget build(BuildContext context) {
      return Scaffold(
        appBar: AppBar(
          title: Text(widget.title),
        ),
        body:
            Center(child:
              Form(
                key: _formKey,
                child: Column(
                  children: [
                    Text('Form with Switch Toggle Button :'),
                    Container(
                      decoration: BoxDecoration(
                        color: const Color(0xff7c94b6),
                        border: Border.all(
                          color: Colors.orange,
                          width: 8,
                        ),
                        borderRadius: BorderRadius.circular(12),
                      ),
                      child: Column(
                        children: [
                          Text('Form implementation Pending .....'),
                          Divider(thickness: 2,),
                          Container(height: 20,),
                          Row(
                            mainAxisAlignment: MainAxisAlignment.center ,
                            children: [
                              Text('Switch     '),
                              Text('$_switchCase'),
                           FormField(
                             builder: (FormFieldState fieldState){
                             return Switch(
                              value: _toggleState,
                              onChanged : _attemptChange,

                           );},
//Value gets reassigned to Null
                           onSaved: (_toggleState){ _passData = _toggleState;  print('Form.onSaved() _toggleState = $_toggleState ');},
                           ),
          ],),
                        ],
                      ),
                    ),

                  Padding(
                  padding: const EdgeInsets.symmetric(vertical: 16.0),
                  child: ElevatedButton(
                  onPressed: () {

                  if (_formKey.currentState.validate()) {
                  _formKey.currentState.save();

                  Navigator.push(
                  context,
                  MaterialPageRoute(
                  builder: (context) => PageOne(_passData)));

                  }
                  },
                  child: Text('Submit'),
                  ),

                ),
                  ],  ), ),
        )
      );
    }}

class PageOne extends StatelessWidget {
  String _passData;

  @override
  Widget build(BuildContext context) {
    return Center(child: Container(child :Text('PassedData-> _toggleState = $_passData '),));
  }

  PageOne(this._passData);
}

FLUTTER DOCTOR :
```
Microsoft Windows [Version 10.0.19042.867]
(c) 2020 Microsoft Corporation. All rights reserved.
F:\Script\Flutter\flutterDevExamples\mentalMathUnlimited0\mental_math_unlimited>flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel dev, 2.1.0-10.0.pre, on Microsoft Windows [Version 10.0.19042.867], locale en-US)
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
[√] Chrome - develop for the web
[X] Visual Studio - develop for Windows
X Visual Studio not installed; this is necessary for Windows development.
Download at https://visualstudio.microsoft.com/downloads/.
Please install the "Desktop development with C++" workload, including all of its default components
[√] Android Studio (version 4.1.0)
[√] VS Code (version 1.54.3)
[√] Connected device (4 available)
! Doctor found issues in 1 category.

How to get the last state of the Switch 'value'?

@starzar
I think your question is better suited for support channels like StackOverflow. Please see https://flutter.dev/community for resources and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
Closing from here, since this is more of a how to question rather than a bug or feature request. If you disagree or think this is a bug in framework, write in comments and I'll reopen it.
Thanks.


kaldialign-0.3 install failed

Hi,
when using 'pip install --verbose kaldialign' install kaldialign, failed to install 0.3 version, finally version 0.2 install successfully.  logs:
Using pip 21.2.4 from /opt/conda/lib/python3.9/site-packages/pip (python 3.9)
Collecting kaldialign
Downloading kaldialign-0.3.tar.gz (10 kB)
Running command python setup.py egg_info
Traceback (most recent call last):
File "", line 1, in
File "/tmp/pip-install-5vs591nx/kaldialign_3f7ed57b6e6d4a979465eb5b17e32acb/setup.py", line 111, in
f.write(f"version = '{get_package_version()}'\n")
File "/tmp/pip-install-5vs591nx/kaldialign_3f7ed57b6e6d4a979465eb5b17e32acb/setup.py", line 102, in get_package_version
with open("CMakeLists.txt") as f:
FileNotFoundError: [Errno 2] No such file or directory: 'CMakeLists.txt'
WARNING: Discarding https://files.pythonhosted.org/packages/06/4d/cddae8f15576630c55aeadd58631d400eb366358581dd7b57e0896cba6f0/kaldialign-0.3.tar.gz#sha256=071d16089f206d6c11025858fff78bb1991b2eaea718ff13a0d9d9e69a7107ef (from https://pypi.org/simple/kaldialign/). Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
Downloading kaldialign-0.2.tar.gz (39 kB)
Running command python setup.py egg_info
running egg_info
creating /tmp/pip-pip-egg-info-uvo1szfh/kaldialign.egg-info
writing /tmp/pip-pip-egg-info-uvo1szfh/kaldialign.egg-info/PKG-INFO
writing dependency_links to /tmp/pip-pip-egg-info-uvo1szfh/kaldialign.egg-info/dependency_links.txt
writing requirements to /tmp/pip-pip-egg-info-uvo1szfh/kaldialign.egg-info/requires.txt
writing top-level names to /tmp/pip-pip-egg-info-uvo1szfh/kaldialign.egg-info/top_level.txt
writing manifest file '/tmp/pip-pip-egg-info-uvo1szfh/kaldialign.egg-info/SOURCES.txt'
reading manifest file '/tmp/pip-pip-egg-info-uvo1szfh/kaldialign.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
adding license file 'LICENSE'
writing manifest file '/tmp/pip-pip-egg-info-uvo1szfh/kaldialign.egg-info/SOURCES.txt'
Building wheels for collected packages: kaldialign
Running command /opt/conda/bin/python -u -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-5vs591nx/kaldialign_5cb4433a854e4cb6b79bdc79fdb925d8/setup.py'"'"'; file='"'"'/tmp/pip-install-5vs591nx/kaldialign_5cb4433a854e4cb6b79bdc79fdb925d8/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(file) if os.path.exists(file) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, file, '"'"'exec'"'"'))' bdist_wheel -d /tmp/pip-wheel-ss39jva6
running bdist_wheel
running build
running build_py
creating build
creating build/lib.linux-x86_64-3.9
creating build/lib.linux-x86_64-3.9/extensions
copying extensions/init.py -> build/lib.linux-x86_64-3.9/extensions
running build_ext
building 'kaldialign' extension
creating build/temp.linux-x86_64-3.9
creating build/temp.linux-x86_64-3.9/extensions
gcc -pthread -B /opt/conda/compiler_compat -Wl,--sysroot=/ -Wno-unused-result -Wsign-compare -DNDEBUG -O2 -Wall -fPIC -O2 -isystem /opt/conda/include -fPIC -O2 -isystem /opt/conda/include -fPIC -I/tmp/pip-install-5vs591nx/kaldialign_5cb4433a854e4cb6b79bdc79fdb925d8/extensions -I/opt/conda/include/python3.9 -c extensions/align.cpp -o build/temp.linux-x86_64-3.9/extensions/align.o -std=c++11 -Wno-register -Wno-unused-function -Wno-unused-local-typedefs -funsigned-char
gcc -pthread -B /opt/conda/compiler_compat -Wl,--sysroot=/ -Wno-unused-result -Wsign-compare -DNDEBUG -O2 -Wall -fPIC -O2 -isystem /opt/conda/include -fPIC -O2 -isystem /opt/conda/include -fPIC -I/tmp/pip-install-5vs591nx/kaldialign_5cb4433a854e4cb6b79bdc79fdb925d8/extensions -I/opt/conda/include/python3.9 -c extensions/kaldi_align.cpp -o build/temp.linux-x86_64-3.9/extensions/kaldi_align.o -std=c++11 -Wno-register -Wno-unused-function -Wno-unused-local-typedefs -funsigned-char
g++ -pthread -B /opt/conda/compiler_compat -Wl,--sysroot=/ -shared -Wl,-rpath,/opt/conda/lib -Wl,-rpath-link,/opt/conda/lib -L/opt/conda/lib -Wl,-rpath,/opt/conda/lib -Wl,-rpath-link,/opt/conda/lib -L/opt/conda/lib build/temp.linux-x86_64-3.9/extensions/align.o build/temp.linux-x86_64-3.9/extensions/kaldi_align.o -o build/lib.linux-x86_64-3.9/kaldialign.cpython-39-x86_64-linux-gnu.so
/opt/conda/lib/python3.9/site-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
warnings.warn(
installing to build/bdist.linux-x86_64/wheel
running install
running install_lib
creating build/bdist.linux-x86_64
creating build/bdist.linux-x86_64/wheel
creating build/bdist.linux-x86_64/wheel/extensions
copying build/lib.linux-x86_64-3.9/extensions/init.py -> build/bdist.linux-x86_64/wheel/extensions
copying build/lib.linux-x86_64-3.9/kaldialign.cpython-39-x86_64-linux-gnu.so -> build/bdist.linux-x86_64/wheel
running install_egg_info
running egg_info
writing kaldialign.egg-info/PKG-INFO
writing dependency_links to kaldialign.egg-info/dependency_links.txt
writing requirements to kaldialign.egg-info/requires.txt
writing top-level names to kaldialign.egg-info/top_level.txt
reading manifest file 'kaldialign.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
adding license file 'LICENSE'
writing manifest file 'kaldialign.egg-info/SOURCES.txt'
Copying kaldialign.egg-info to build/bdist.linux-x86_64/wheel/kaldialign-0.2-py3.9.egg-info
running install_scripts
adding license file "LICENSE" (matched pattern "LICEN[CS]E*")
creating build/bdist.linux-x86_64/wheel/kaldialign-0.2.dist-info/WHEEL
creating '/tmp/pip-wheel-ss39jva6/kaldialign-0.2-cp39-cp39-linux_x86_64.whl' and adding 'build/bdist.linux-x86_64/wheel' to it
adding 'kaldialign.cpython-39-x86_64-linux-gnu.so'
adding 'extensions/init.py'
adding 'kaldialign-0.2.dist-info/LICENSE'
adding 'kaldialign-0.2.dist-info/METADATA'
adding 'kaldialign-0.2.dist-info/WHEEL'
adding 'kaldialign-0.2.dist-info/top_level.txt'
adding 'kaldialign-0.2.dist-info/RECORD'
removing build/bdist.linux-x86_64/wheel
Building wheel for kaldialign (setup.py) ... done
Created wheel for kaldialign: filename=kaldialign-0.2-cp39-cp39-linux_x86_64.whl size=34661 sha256=9207ced32458ee21917bcba83b5d369dc19c0c040a41685b338b035b51aefa30
Stored in directory: /root/.cache/pip/wheels/ab/6e/ec/548bcab54d6c93f3a31ab3283cbad1e8512fd14c05b5d1ce20
Successfully built kaldialign
Installing collected packages: kaldialign
Successfully installed kaldialign-0.2

I'm dealing with the same problem as you. I want to build the Docker image in icefall, but no CMakeLists.txt found from version 0.3.
Step 8/10 : RUN git clone https://github.com/k2-fsa/icefall /workspace/icefall && 	cd /workspace/icefall && 	pip install -r requirements.txt
 ---> Running in c7878173aedc
Cloning into '/workspace/icefall'...
Looking in indexes: https://pypi.org/simple, https://pypi.ngc.nvidia.com
Collecting kaldilm
  Downloading kaldilm-1.13.tar.gz (46 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 46.2/46.2 kB 8.8 MB/s eta 0:00:00
  Preparing metadata (setup.py): started
  Preparing metadata (setup.py): finished with status 'done'
Collecting kaldialign
  Downloading kaldialign-0.3.tar.gz (10 kB)
  Preparing metadata (setup.py): started
  Preparing metadata (setup.py): finished with status 'error'
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [8 lines of output]
      Traceback (most recent call last):
        File "<string>", line 36, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/tmp/pip-install-9bykkuml/kaldialign_b2fddaefd195433ea5eb1a44223ea4a7/setup.py", line 111, in <module>
          f.write(f"__version__ = '{get_package_version()}'\n")
        File "/tmp/pip-install-9bykkuml/kaldialign_b2fddaefd195433ea5eb1a44223ea4a7/setup.py", line 102, in get_package_version
          with open("CMakeLists.txt") as f:
      FileNotFoundError: [Errno 2] No such file or directory: 'CMakeLists.txt'
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.
The command '/bin/sh -c git clone https://github.com/k2-fsa/icefall /workspace/icefall && 	cd /workspace/icefall && 	pip install -r requirements.txt' returned a non-zero code: 1

Same Error here. after installing it from the source
   import _kaldialign ModuleNotFoundError: No module named '_kaldialign'

Same Error here. after installing it from the source

@ahmedalbahnasawy what is your operating system?

@xiangxyq
https://github.com/pzelasko/kaldialign/pull/5 should fix your issue.

@xiangxyq The problem was just resolved. You can install and use kaldialign-0.4 from now on.


Convert Atom packages list to JSON task fails

fatal: [default]: FAILED! =>
{
	"failed": true,
	"msg": "the field 'args' has an invalid value ([]), and could not be converted to an dict. Error was: Extra data: line 3 column 1 - line 3 column 48 (char 10047 - 10094) The error appears to have been in '/etc/ansible/roles/ferrarimarco.atom/tasks/debian.yml': line 29, column 3, but may be elsewhere in the file depending on the exact syntax problem. The offending line appears to be:- name: Convert Atom packages list to JSON  ^ here"
}

This is due to an invalid JSON input


Add collections meta data alternate link(s) for supported MIME types.

Resolves #81

I'm not sure that config.SupportedContentTypes is the right place for that, but nothing jumped out at me for where to put it.


[WIP][GLUTEN-5471][VL]feat: Support read Hudi COW table

What changes were proposed in this pull request?
Support read hudi COW tables. Fixes #5471
How was this patch tested?
Unit tests, integration tests.

@yma11 @stream2000 @leesf if any of you're interested and have bandwidth, would you like to take over this PR (or open new one) and move forward? I'm bit short on availability.

@yma11 @stream2000 @leesf if any of you're interested and have bandwidth, would you like to take over this PR (or open new one) and move forward? I'm bit short on availability.

@xushiyan Thanks for your changes. I will address the comments based on your PR.

@yma11 @stream2000 @leesf if any of you're interested and have bandwidth, would you like to take over this PR (or open new one) and move forward? I'm bit short on availability.

@xushiyan Thanks for your changes. I will address the comments based on your PR.

@yma11 thanks. any plan on your side to make change and get this merged?

@yma11 @stream2000 @leesf if any of you're interested and have bandwidth, would you like to take over this PR (or open new one) and move forward? I'm bit short on availability.

@xushiyan Thanks for your changes. I will address the comments based on your PR.

@yma11 thanks. any plan on your side to make change and get this merged?

I will do it next week. Thanks.


question about population growth rate

We are trying to disambiguate some head-melty stuff in PHIPO related to growth of populations both yeast form and hyphal growth and what can be inferred from this.
We have
cell population growth phenotype
defined like FYPO
A cell phenotype that affects the rate or extent of cell population growth.
I was expecting to see this defined as an increase/decrease  in the number of individuals so that it would not be confused with an increase/decrease in size of the individuals. Would that make sense? It seems that we need to be more specific about the 'type' of growth.
Or maybe 'cell population growth' is really only  ever applying to an increase in the number of individuals that this is unnecessary? (it gets a bit murky when looking at hyphal commonly size because colony size can be more directly related to  the growth of individual hyphae).
@CuzickA

We have never had to make a distinction in FYPO because (clue's in the name) for fission yeast it's felt safe to leave it implicit that population growth in an increase in the number of cells. Even for size mutants what's assayed for populations stays coupled to the number of cells in the population rather than to individual cells enlarging.
I can easily edit definitions for the FYPO population growth terms, to make it explicit that they refer to cell numbers, but I don't think the FYPO terms necessarily provide much guidance for species and contexts where it's less straightforward to tell whether numbers, individual size, or both is/are relevant.
Note, also, that when people talk about population size for "big" organisms (humans, mice, trees, etc.) they pretty much only mean how many individuals, not how tall or fat they are. Still not sure how much that helps with things like hyphae, though.

Thanks. The response helped us. I mainly just wanted to check that these terms could only  refer to an increase in the number of cells. We have an alternative solution for the hyphal colony size problem.
We can make the def more explicit in PHIPO. No need to do anything here unless you think it might be useful to make the defs less self-referring for people like me. I thought I knew what it meant but I needed to check.

OK, glad it helped. What I'll probably do in FYPO is add some details to one or a few high-level population growth term defs, but not bother doing it for all the descendants.

That makes sense...

OK, def edits done


Added array dtype in loader.py

I was trying qri.get('xristosk/bandcamp_artists').body but I received RuntimeError: Unknown type: "array".
Traceback:
---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
<ipython-input-2-221d49128db4> in <module>
----> 1 df = qri.get('xristosk/bandcamp_artists').body
      2 df.head()

~/datasets/notebooks/qri/dataset.py in body(self)
    115         if self.body_component is None:
    116             ref = dsref.Ref(self.username, self.name)
--> 117             df = loader.instance().load_body(ref, self.structure)
    118             self.body_component = df
    119         return self.body_component

~/datasets/notebooks/qri/loader.py in load_body(self, ref, structure)
     66         columns = [e for e in structure.schema['items']['items']]
     67         col_names = [c['title'] for c in columns]
---> 68         types = {c['title']: pd_type(c['type']) for c in columns}
     69         header = 0 if structure.format_config.get('headerRow') else None
     70         df = None

~/datasets/notebooks/qri/loader.py in <dictcomp>(.0)
     66         columns = [e for e in structure.schema['items']['items']]
     67         col_names = [c['title'] for c in columns]
---> 68         types = {c['title']: pd_type(c['type']) for c in columns}
     69         header = 0 if structure.format_config.get('headerRow') else None
     70         df = None

~/datasets/notebooks/qri/loader.py in pd_type(t)
    127     elif t == 'bool':
    128         return 'bool'
--> 129     raise RuntimeError('Unknown type: "%s"' % t)

RuntimeError: Unknown type: "array"

As a possible fix, I added array as a dtype in the pd_type function. It worked fine for this case.

Would you be able to squash these commits? There's a couple of duplicate commit messages, including another unrelated change. Aside from that looks good!

I did a cherry-pick, this change has now become commit 705c80434bc291fb1eaa93e138f1dce6ee5b1789. Closing this PR.


Table needs reformatting for detail views

Also the "Snatch" and "Clean and Jerk" do not line up


Renames 'Office 365 CLI' to 'CLI for Microsoft 365'. Closes #1635

Renames 'Office 365 CLI' to 'CLI for Microsoft 365'. Closes #1635

Coverage remained the same at 100.0% when pulling 2ee72968e1efdfc0d8086e0e920e53df8df8cee2 on waldekmastykarz:rename-cli into 3cd2138030fb26f354403ceaaa489cc4bd11f849 on pnp:v3.

Merged manually. Thank you 👏


Run lint on each commit

To prevent re-introducing lint errors, run full linter on each commit. This doesn't just check changed files, but it's quite fast, so I think there's no harm in running over all files.

Codecov Report

Merging #236 into main will decrease coverage by 0.02%.
The diff coverage is 49.81%.

@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
- Coverage   59.29%   59.26%   -0.03%
==========================================
  Files          95       95
  Lines       11720    11767      +47
==========================================
+ Hits         6949     6974      +25
- Misses       4771     4793      +22

Impacted Files
Coverage Δ

blocks/functional_examples.js
83.33% <ø> (ø)

blocks/functional_parameters.js
73.52% <ø> (-0.76%)
:arrow_down:

blocks/lists.js
5.26% <0.00%> (-0.03%)
:arrow_down:

blocks/loops.js
32.98% <0.00%> (ø)

blocks/math.js
21.48% <0.00%> (ø)

blocks/text.js
11.92% <0.00%> (-0.06%)
:arrow_down:

core/connections/connection.js
69.31% <0.00%> (-0.07%)
:arrow_down:

core/ui/block_space/block_limits.js
92.30% <ø> (ø)

core/ui/block_space/block_space.js
65.82% <ø> (ø)

...ore/ui/block_space/scroll_on_block_drag_handler.js
29.87% <ø> (-0.90%)
:arrow_down:

... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0a2b0f...1267ac9. Read the comment docs.


CentOS binaries are not building

CentOS build can't find golang package. I can't recall if we had some magic for that, and why it stopped working.

I recall CentOS 7 never having golang package, but I think we had some magic to reuse the golang binary from a different target

https://build.opensuse.org/project/show/systemsmanagement:terraform:unstable

Can you list out exact steps followed while packaging CentOS distribution?

Hi @rsjethani you will need to have obs knowledge on obs system, if you want to take this issue I will help on the road with all the infos

Hi @rsjethani you will need to have obs knowledge on obs system, if you want to take this issue I will help on the road with all the infos

Can you list out exact steps followed while packaging CentOS distribution?

@rsjethani We just build the source in a .spec file against various distributions. Here is the spec:
https://build.opensuse.org/package/view_file/systemsmanagement:terraform:unstable/terraform-provider-libvirt/terraform-provider-libvirt.spec?expand=1
The result ends as a rpm. There is one step that copies the binary into a OTHER directory. That is used to also output plain tarballs with the binary (non-rpms).

Thanks @MalloZup @dmacvicar I will start by understanding obs and rpm basics

This may help you: https://duncan.codes/tutorials/rpm-packaging

On centos7 golang is available via epel-release repo

I see the binaries are being built again... but I don't recall we did anything to fix it

no we didn't. to me is that on the obs side the unresolvable pkg for centos7 was fixed and consequently it fixed also our sub-problem.
thx for closing it :tulip:


Torodb 384 Check BSON types

Codecov Report

Merging #165 into devel will increase coverage by 0.81%.
The diff coverage is 19.81%.

@@             Coverage Diff             @@
##             devel     #165      +/-   ##
===========================================
+ Coverage     20.4%   21.21%   +0.81%
- Complexity    1909     1993      +84
===========================================
  Files          866      888      +22
  Lines        27721    28117     +396
  Branches      2406     2416      +10
===========================================
+ Hits          5656     5965     +309
- Misses       21647    21719      +72
- Partials       418      433      +15

Impacted Files
Coverage Δ
Complexity Δ

...stgresql/converters/jooq/binding/JsonbBinding.java
0% <ø> (ø)
0 <0> (ø)
:x:

...ain/java/com/torodb/d2r/model/DocPartDataImpl.java
96% <ø> (+4%)
14 <0> (+1)
:white_check_mark:

...stgresql/converters/jooq/MaxKeyValueConverter.java
0% <0%> (ø)
0 <0> (?)

...ckend/postgresql/meta/PostgreSqlSchemaUpdater.java
0% <0%> (ø)
0 <0> (ø)
:x:

.../torodb/backend/AbstractIdentifierConstraints.java
0% <0%> (ø)
0 <0> (ø)
:x:

.../torodb/backend/converters/jooq/DataTypeForKv.java
0% <0%> (ø)
0 <0> (ø)
:x:

...om/torodb/backend/udt/record/Decimal128Record.java
0% <0%> (ø)
0 <0> (?)

...s/jooq/MongoJavascriptWithScopeValueConverter.java
0% <0%> (ø)
0 <0> (?)

...backend/postgresql/PostgreSqlDataTypeProvider.java
0% <0%> (ø)
0 <0> (ø)
:x:

...end/postgresql/converters/sql/JsonbSqlBinding.java
0% <0%> (ø)
0 <0> (?)

... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edf8a98...aa31fa7. Read the comment docs.


Fix sign-compare error

Newer GCCs will fail comparing a __time_t with an unsigned int on i686; do the necessary type coercion since we know this will be safe rather than having to use __time_t everywhere (its implementation is arch-specific anyway).
psi-notify.c: In function 'suspend_for_remaining_interval':
psi-notify.c:546:26: error: comparison of integer expressions of different signedness: '__time_t' {aka 'long int'} and 'unsigned int' [-Werror=sign-compare]
  546 |     if (remaining.tv_sec >= cfg.update_interval) {
      |                          ^~
cc1: all warnings being treated as errors

see the Fedora scratch builds:
https://koji.fedoraproject.org/koji/taskinfo?taskID=44743766
it succeeds on x86_64, fails on i686:
https://kojipkgs.fedoraproject.org//work/tasks/3799/44743799/build.log
Fixed scratch builds:
https://koji.fedoraproject.org/koji/taskinfo?taskID=44745335
(it errors out now on s390x, but our s390x builder is a bit flaky and even if it is a real issue it seesms unrelated)
Signed-off-by: Michel Alexandre Salim<EMAIL_ADDRESS>

This change is

Thanks for the report! __time_t is an inner implementation typedef of time_t so that's the type to use (GCC reports a confusing type, but anyway).
However, a better solution is really just to store c->update_interval as time_t, which should be fine. :-)
If you change the update_interval parser and the Config struct, I think that's all there should be to it. Thank you!

Also good poke about other architectures, I just added ppc64le, s390x, and arm64 to the Travis build matrix. Seems they all pass, which is good :-)

oh, Travis has s390x! nice. Looks like Fedora has a newer compiler since it throws an error that Travis didn't catch (#15). Will revise this one - I started using time_t but it requires more changes (you can't use '%d' to display it) but agreed, that's cleaner

I don't think the issue is a newer compiler. I'm now running GCC 10 + -D_FORTIFY_SOURCE=2 when running tests on s390x and it doesn't throw this: https://travis-ci.com/github/cdown/psi-notify/jobs/338382709
I suspect something else is going on here.

Great, thank you again!


fixes viewshed gradient calculation issue

fixes some critical bugs in viewshed calculation.

Looks good to me. Ready to merge?

yes

Looks good to me. Ready to merge?

Yes its good to go.


[bug] Need to be able to delete and clear text

Describe the bug
Sometimes text can not get cleared

May also be relevant but if you delete all the text in an element the element goes away from the canvas but still exists in the layers. Kinda an edge case. Framer removes the text layer entirely if there's no text in it.

I wonder if we actually should remove the node in this case. It could be there for placeholder purposes or have some styling attached to it. May leave it empty until emerging request for removing the node entirely