What's the point of Denomination::MilliSatoshi?

Its incredibly confusing to have a MilliSatoshi Denomination, implying Amounts might support it, but instead if you try to use it you get an error. It seems like it just sets the wrong impression but doesn't really add any value since you can't really safely use it anywhere? ISTM it should be dropped.

Oh, I always assumed it was used by lightning. If LDK doesn't use it then why did we add it originally?

Lol, I also assumed that somehow it was used by the LN people. I'm happy to drop it.

So do we want an Amount that fully supports LDK or are you guys resigned to keeping your own?

The inner u64 inside Amount is private so we can put what ever we want in there, for example (excluding the obvious perf hit) times it by 1000 and make it represent milistats. To save us hanging ourselves we'd probably want a Satoshi type and not use u64s ever.

By the way, fedimint also defines its own type:
/// Represents an amount of BTC inside the system. The base denomination is
/// milli satoshi for now, this is also why the amount type from rust-bitcoin
/// isn't used instead.
pub struct Amount {
    pub msats: u64,
}

I sincerely hope that no one is doing enough amount construction in an inner loop that this is noticeable :).

@yancyribbons had this situation once running some sort of exhaustive coin selection algo.
@tcharding : My viev is:

Amount should represent an on-chain amount. No millisats. If we tried to support millisats in Amount we would run into error cases when we tried to put this object on-chain, as Matt says.
We could additionally support some sort of LightningAmount which probably we'd just copy straight from ldk. But it may make more sense for users who want Lightning amounts to just use ldk.
Fedimint's notion of sub-satoshi amounts is, I suspect, different from that of Lightning. Maybe they have the same range and in theory they could share a type, but I'm not sure that will always be the case, given the iteration that Fedimint is doing on amount privacy, denominations, etc. So while I appreciate the desire for "the whole ecosystem to have one Amount type" I don't really think this is possible.

Ouch, that hurts. @dpc and @TheBlueMatt you guys are long in the tooth enough to know that upstreaming is the best way to reduce your workload - the bitcoin::Amount hands down should support LDK and Fedimint.
Since we only just did the last release there is no rush but here is the issue: https://github.com/rust-bitcoin/rust-bitcoin/issues/2824

Cool, thanks. I consider myself schooled. I didn't see the above message before opening an issue (now closed), or chiding @dcp and @TheBlueMatt about not upstreaming, I've deleted it, my sincere apologies.

Amount should represent an on-chain amount. No millisats. If we tried to support millisats in Amount we would run into error cases when we tried to put this object on-chain, as Matt says.

"on chain" just means what we spit out of consensus_encode, right? That is not tied to the internal representation of Amount.
The privacy stuff in Fedimint is in the future so I don't have an opinion on that. I believe we can technically support LDK, Fedimint, and on-chain users with a single Amount type. I see no reason that if msats are a thing then that the Amount type should not be able to support them.

"on chain" just means what we spit out of consensus_encode, right? That is not tied to the internal representation of Amount.

Right.

The privacy stuff in Fedimint is in the future so I don't have an opinion on that. I believe we can technically support LDK, Fedimint, and on-chain users with a single Amount type. I see no reason that if msats are a thing then that the Amount type should not be able to support them.

Vacuously agreed. msats are not a thing :) There is no such thing as a millisatoshi except as an accounting fiction in non-bitcoin protocols.

msats are not a thing

Ok, if that is our position then this issue is aptly named. Shall we just remove all mention of it?

ISTM it should be dropped.

lol, @TheBlueMatt said exactly that right at the start - don't mind me ...

Fedimint's notion of sub-satoshi amounts is, I suspect, different from that of Lightning.

Fedimint's Amounts are the way they are, precisely to be compatible with LN. I was actually going to propose LightnintAmount after getting to keyboard, but I see it was already mentioned. It would most probably work for Fedimint. And even if it doesn't, I think it makes sense to have both "on chain amount" and "ln amount" as interoperable concepts, and projects can always have From back-and-forth for interoperability.
Though I must say having a custom Amount in a project is not a big deal really anyway.
Ping @elsirion for more Fedimint PoV on the matter.

Fedimint's notion of sub-satoshi amounts is, I suspect, different from that of Lightning.

It's the same as lightning. As @dpc mentions LN's support for it is the reason for Fedimint support.

… given the iteration that Fedimint is doing on amount privacy, denominations, etc.

Optionally blinded amounts will likely result in us creating an enum over either some blinded amount commitment or a plain amount, both being msat denominated.

I think its rather universally accepted at this point that msats were a mistake in LN and we shouldn't have done them. I'd encourage fedimint to drop them if at all possible at this point :)

Hopefully not to derail the discussion, but any good authoritative link to read more about it? I heard it before, but never investigated it. In Fedimint msats seem entirely practical without many (any?) downsides. And for stuff like micropayments etc. could work great. So I wonder if the problems that made it a mistake in LN, do actually apply to ECash.

The ligthning amount already exists in the ln_types crate. Perhaps you guys could finally start using it. :) Ping me if you want access permissions/transfer/whatever. I don't have much time lately but I'm slowly going back. And BTW I'll be at BTC Prague in case someone is attending too.
Also, @TheBlueMatt FYI msat is parsed correctly if you have multiples of thousand. This is intentional but I'm not claiming it to be practical. I guess displaying sats as msats is a more sensible use case.

I sincerely hope that no one is doing enough amount construction in an inner loop that this is noticeable :).

@yancyribbons had this situation once running some sort of exhaustive coin selection algo.

The rust BnB coinselection algo I wrote suffered performance problems (when compared to bitcoin cores BnB selection) when using Amount types.  However I tracked the issue to the use of checked arithmetic which was default.  It didn't have anything to do with construction of an amount type (done outside of the hot path).
TLDR the unchecked arithmetic variants on Amount fixed the perf problems I was experiencing with coin-selection.
@apoelstra thanks for the mention, however you made I very minor spelling mistake with your mention :).  Just happened to notice this conversation and was reading through it out of interest.


Hierarchical blobs fails with Azurite

Storage Explorer Version: 1.4.0
Platform/OS Version: Windows 10
Architecture: ia32
Regression From:
Steps to Reproduce:

Install Azurite 2.6.5 and launch Storage Explorer
Browse Azurite Emulator

Expected Experience:
The blobs are displayed in hierarchical view and can be opened.
Actual Experience:
The blobs are displayed in a flat view with full filename. Trying to opening a file gives a 404 exception.
Using the .NET SDK, the blob are correctly written/read to Azurite.

You're using backslashes "\" to separate "folders". However, we default for forward slashes "/" for folder delimiters. Try renaming your blobs to use forward slashes.

It works thanks. Strange that Azure Storage Emulator is accepting "" and "/" to separate "folders".
Anyway, I fixed my code..

I think you mean Storage Explorer only accepts "/" to separate folders?
Here's a useful documentation page that may be hepful.


Fix make generate slowness on Docker for Mac

What this PR does / why we need it:

Defines $GOFILES used in make generate with glide novendor which is much faster than previous go list ... + sed method. make generate and make build now finishes quickly on Docker for Mac.
Ensure .git/ is added to containers, needed for developers and how acs-engine version derives version.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #1101
Special notes for your reviewer:
Release note:

This change is

@wbuchwalter @sozercan can you see if these changes fixes the slow make generate inside a container issue for you?

LGTM 👍
One feature request, let's mount _output folder so it doesn't get lost after exiting container

One feature request, let's mount _output folder so it doesn't get lost after exiting container

Good idea, though I'm worried that when _output grows Mac users will have the same problem that mounting vendor/ has...
$ find _output/ -type f | wc -l
    3638

[k8s: weeping-donkeymgmt]
seknox at greentara in ~/src/go/src/github.com/Azure/acs-engine on remove-unused-rebase.sh [$]
$ find vendor -type f | wc -l
    3840

Granted, I create a lot of clusters, so I may be atypical. :)


Issue with /docs/getting-started-guides/ubuntu/

This is a...

[ ] Feature Request
[x] Bug Report

Problem:
I opend the doc of getting-started-guides for ubuntu, but the web showed a 404 error.
Following this: http://kubernetes.io/docs/getting-started-guides/ubuntu/
Proposed Solution:
pls chk the url and web link is alright.
Page to Update:
http://kubernetes.io/...
NA

all

NA

thanks for reporting, looks like this page was just fixed :)


Allow immediate destruction of pose graph

If the pose graph work queue gets clogged up, libcartographer users are forced to wait until it gets fully processed when they are destroying Cartographer. Change this to drop all queued tasks if the user is destructing.
If the user wishes to wait until everything gets processed, they can call RunFinalOptimization. Alternatively, we could expose WaitForAllComputations for achieving the same thing without running that additional optimization.
I have made the change only for 3D in this PR, I can replicate when (if? :-)) it's approved.

I think that you should retain the old behavior by default as some users may depend on the current behavior.

I think that you should retain the old behavior by default as some users may depend on the current behavior.

 In cartographer_ros, the offline node calls RunFinalOptimization, so it is not affected.
I do not see a case where users could even theoretically depend on the results of work queue being fully processed - if you are destructing, you cannot access the data in the pose graph anyway, so effects of everything in the work queue being processed are not observable to you.

 In cartographer_ros, the offline node calls RunFinalOptimization, so it is not affected.

If someone relies on LocalSlamResultCallback and/or GlobalSlamOptimizationCallback being called even if I think that is unlikely.

Such users can call RunFinalOptimization explicitly. I think the benefit of others not having to SIGKILL Cartographer when the work queue is clogged is more important.


Will this work on mac os?

Not supported since I haven't found a use case for running aws cli on any machine other than Linux.
To mix Linux and macOS builds, you can have one job with a Linux runner to do the aws cli calls, and on macOS job can consume the outputs of the Linux job.
If you need help with writing this kind of GitHub Actions Workflow, let me know and I'll comment with an example.
For now I'm keeping this issue open, I'll close it in a few days


[Add] Unreal Sensei - Mega Tutorials Playlist under game-development category

Site URL
https://youtube.com/playlist?list=PLKPWwh_viQMGQkQfKKD5lF96efA3_RWt-&si=k4te9WjQlnYO85d5
Description of the above provided site
This playlist by Unreal Sensei provides a complete tutorial to get started with Unreal Engine and develop realistic games.
Category
Youtube
Sub Category
Game Development
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)
[X] I am participating in Hacktoberfest 2023

@SargamPuram
I have assigned you the issue. Please proceed with it, and don't hesitate to tag me @Anmol-Baranwal or @CBID2 if you require any assistance.


Anvil repairing

Whenever you rename an item in an anvil, it gets repaired.

Problem should be resolved

The issue still persists in the new update

That's strange, I'll take a closer look

Now in the latest version the item gets 0 durability

Forgot to close this issue, this has already been fixed


Getting classpath error: unable to find org.aspectj.lang.JoinPoint when running instrumentation tests

Getting this error message when running instrumentation tests (androidTest) both in my project and in AspectJX-Demo project:
Execution failed for task ':app:transformClassesWithAspectTransformForDebugAndroidTest'.
> classpath error: unable to find org.aspectj.lang.JoinPoint (check that aspectjrt.jar is in your classpath)

* Exception is:
org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':app:transformClassesWithAspectTransformForDebugAndroidTest'.

check that your dependencies contains
compile 'org.aspectj:aspectjrt:1.8.9'

My dependencies contain AspectJ. And as I said, I'm getting same error in
your demo project.
On Nov 6, 2016 11:20 PM, "firefly1126"<EMAIL_ADDRESS>wrote:

check that your dependencies contains
compile 'org.aspectj:aspectjrt:1.8.9'
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/HujiangTechnology/gradle_plugin_android_aspectjx/issues/19#issuecomment-258763423,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFZfc4kqTir8FA2xXLgSdlq1g7A65HlAks5q7tEhgaJpZM4KqHTS
.

it seem that,not  compatible with instant run.
i encounter the same  problem.foud that demo can build release apk,but when deploy debug version to real phone or emulor,it's just not work. then i turn off instant run,it fix!

When I run instrumental tests on my CI server, I have the same error. There is no instant run.

Facing this on CI server. Instant run is not involved

version 1.0.10 has solved this problem. It can support AndroidTest


Major update for v2

Great work, I was writing something similar in Python haha.
I think we can create 2 additional columns in the final csv:

final_code: to maintain a record of the final code snippet, to help us check how much the AI generated code was changed
prompts_given:  we can calculate the number of prompts used to generate the code snippet (unsure about this, potential research point)

The code is extracted under the sample/data/chat which is linked to the GPT Chat ID.
I think this one need to update this repo https://github.com/HolmesJJ/gpt-playground-chat-extraction.


Support dative bonds

Here's a mailing list thread: http://www.mail-archive.com/rdkit-discuss%40lists.sourceforge.net/msg05094.html
Input/output can currently only be done using the v3K CTAB format, so some attention will need to be paid to ensure that other formats do the right thing (probably not including any bonds at all).

RDKit supports dative bonds, including as an extension to SMILES.


Contour 1.5+ is struggling with scale-100

See: https://github.com/knative/serving/pull/9125

I think the main change in this was the switch to Contour 1.7, though a few other changes have accumulated since.

1.8 was just released: https://github.com/projectcontour/contour/releases/tag/v1.8.0

Ok, new staged PR to repro the break: https://github.com/knative/serving/pull/9200

I refactored scale test a bit to try and make debugging things a bit easier.

After investigating this a bit, it looks like we are never able to successfully probe certain routes.  I haven't gone deeper into why yet.
I saw at least one instance where we failed-over mid probe due to chaos, and it looks like the failover took the full 15s for there to be a new lease holder (likely need the K8s patch for leaderelection).  For good measure, I'm trying scale-100 with chaos disabled, but I don't think it's the cause because after the failover the probes pick up and are still seeing 404s.
In an effort to bring us as far forward as I can, and narrow the search for potentially breaking Contour changes, I have opened PRs to try against contour 1.5 and 1.6 as well (we know 1.7 hit this too, since that's what I tried first).

1.5: https://github.com/knative/serving/pull/9209
1.6: https://github.com/knative/serving/pull/9210
1.8: https://github.com/knative/serving/pull/9200

Looks like it started in 1.5 :(

Started a thread on this in Contour slack: https://kubernetes.slack.com/archives/C8XRH2R4J/p1598722245143600

Looking at a failure with a bit more instrumentation...
I see the following probe failures immediately prior to things timing out:
    kubelogs.go:197: E 18:37:42.981 contour-ingress-controller-577bf7cc7f-r66m5 [status/status.go:397] [serving-tests/scale-to-n-scale-100-069-of-100-vyyiymqy] Probing of http://scale-to-n-scale-100-069-of-100-vyyiymqy.serving-tests failed, IP: <IP_ADDRESS>:80, ready: false, error: unexpected status code: want 200, got 404 (depth: 0)

I see this hostname first queued for probing ~90 seconds prior:
    kubelogs.go:197: I 18:36:11.835 contour-ingress-controller-577bf7cc7f-zlfxm [status/status.go:266] [serving-tests/scale-to-n-scale-100-069-of-100-vyyiymqy] Queuing probe for http://scale-to-n-scale-100-069-of-100-vyyiymqy.serving-tests, IP: <IP_ADDRESS>:80 (depth: 0)

In the final wave of probes, these are the hosts+pod-ip that are still serving 404s, sorted:
 http://scale-to-n-scale-100-069-of-100-vyyiymqy.serving-tests failed, IP: <IP_ADDRESS>:80
 http://scale-to-n-scale-100-069-of-100-vyyiymqy.serving-tests failed, IP: <IP_ADDRESS>:80
 http://scale-to-n-scale-100-069-of-100-vyyiymqy.serving-tests failed, IP: <IP_ADDRESS>:80
 http://scale-to-n-scale-100-069-of-100-vyyiymqy.serving-tests failed, IP: <IP_ADDRESS>:80
 http://scale-to-n-scale-100-069-of-100-vyyiymqy.serving-tests failed, IP: <IP_ADDRESS>:80
 http://scale-to-n-scale-100-069-of-100-vyyiymqy.serving-tests failed, IP: <IP_ADDRESS>:80
 http://scale-to-n-scale-100-069-of-100-vyyiymqy.serving-tests failed, IP: <IP_ADDRESS>:80

 http://scale-to-n-scale-100-069-of-100-vyyiymqy.serving-tests.svc failed, IP: <IP_ADDRESS>:80
 http://scale-to-n-scale-100-069-of-100-vyyiymqy.serving-tests.svc failed, IP: <IP_ADDRESS>:80
 http://scale-to-n-scale-100-069-of-100-vyyiymqy.serving-tests.svc failed, IP: <IP_ADDRESS>:80
 http://scale-to-n-scale-100-069-of-100-vyyiymqy.serving-tests.svc failed, IP: <IP_ADDRESS>:80
 http://scale-to-n-scale-100-069-of-100-vyyiymqy.serving-tests.svc failed, IP: <IP_ADDRESS>:80
 http://scale-to-n-scale-100-069-of-100-vyyiymqy.serving-tests.svc failed, IP: <IP_ADDRESS>:80
 http://scale-to-n-scale-100-069-of-100-vyyiymqy.serving-tests.svc failed, IP: <IP_ADDRESS>:80

 http://scale-to-n-scale-100-069-of-100-vyyiymqy.serving-tests.svc.cluster.local failed, IP: <IP_ADDRESS>:80
 http://scale-to-n-scale-100-069-of-100-vyyiymqy.serving-tests.svc.cluster.local failed, IP: <IP_ADDRESS>:80
 http://scale-to-n-scale-100-069-of-100-vyyiymqy.serving-tests.svc.cluster.local failed, IP: <IP_ADDRESS>:80
 http://scale-to-n-scale-100-069-of-100-vyyiymqy.serving-tests.svc.cluster.local failed, IP: <IP_ADDRESS>:80
 http://scale-to-n-scale-100-069-of-100-vyyiymqy.serving-tests.svc.cluster.local failed, IP: <IP_ADDRESS>:80
 http://scale-to-n-scale-100-069-of-100-vyyiymqy.serving-tests.svc.cluster.local failed, IP: <IP_ADDRESS>:80
 http://scale-to-n-scale-100-069-of-100-vyyiymqy.serving-tests.svc.cluster.local failed, IP: <IP_ADDRESS>:80

It looks like the same 7 envoy pods for all 3 cluster-local hostnames are failing to probe...

It is notable that there are 12 total envoy pod ips to probe, which makes me wonder if maybe the contour instance these envoys are talking to is wedged or something?  I think the default configuration runs 2 contours (leader and read replicas), so I wonder if one is behind and serving bad configs?

For grins, I'm going to try a run with it hardcoded to a single replica...

The contour logs are just filled with:
contour-external/contour-cbbbcbb98-w7xs4[contour]: time="2020-08-29T18:37:47Z" level=error msg="failed to set status" context=contourEventHandler desc="valid HTTPProxy" error="Operation cannot be fulfilled on httpproxies.projectcontour.io \"scale-to-n-scale-100-069-of-100af2ea634c22591b4bc7dfbe9f2e9ad84\": the object has been modified; please apply your changes to the latest version and try again" name=scale-to-n-scale-100-069-of-100af2ea634c22591b4bc7dfbe9f2e9ad84 namespace=serving-tests status=valid

Occasionally I see one of these as well:
contour-internal/contour-7fd855dbf6-7st2j[contour]: time="2020-08-29T18:36:42Z" level=error msg="failed to set status" context=contourEventHandler desc="valid HTTPProxy" error="Operation cannot be fulfilled on httpproxies.projectcontour.io \"scale-to-n-scale-100-061-of-1003d89be7e56bfb5f935cb6184cdb511bb\": StorageError: invalid object, Code: 4, Key: /registry/projectcontour.io/httpproxies/serving-tests/scale-to-n-scale-100-061-of-1003d89be7e56bfb5f935cb6184cdb511bb, ResourceVersion: 0, AdditionalErrorMsg: Precondition failed: UID in precondition: f8cdbf6f-c1ce-4913-8cf2-7c270cb489fe, UID in object meta: " name=scale-to-n-scale-100-061-of-1003d89be7e56bfb5f935cb6184cdb511bb namespace=serving-tests status=valid

This now has status updates commented out: https://github.com/knative/serving/pull/9209
I'm running this to try and establish baseline latencies with 1.4 during scale-100: https://github.com/knative/serving/pull/9212
I have also started a git bisect of Contour 1.5 to try and narrow down an offending change: https://github.com/knative/serving/pull/9213

So 1.8 with status updates disabled is >2x faster than where we are today at the tail of scale-100.  I've pushed a PoC change to https://github.com/knative/serving/pull/9214 that brings back status updates without the initial Get 🤞

With some further instrumentation we found some additional bits of fun, and I reworked the short-term fix here: https://github.com/projectcontour/contour/pull/2864
Discussing this, I think we also got a handle on why these problems slow the DAG rebuilds and envoy updates: https://github.com/projectcontour/contour/issues/2857#issuecomment-684193224

I'm pretty sure we have this sorted out and once @youngnick et al cut 1.8.1 (hopefully tomorrow?) I will update https://github.com/knative-sandbox/net-contour/pull/232 and it should close this out.

/assign


🧑💻: Add Search Bar Functionality

:red_circle: Title :Search Bar
:red_circle: Enhancement Aim :I want to add search bar in every projects section
:red_circle: Changes : adding search bar
Screenshots 📷

:white_check_mark: To be Mentioned while taking the issue :

Full name : MANKALA VAISHNAVI
What is your participant role? (Mention the Open Source Program name. Eg. GSSOC, SSOC, JWOC, etc.)GSSOC

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

@VaishnaviMankala19 Not required. I'm focusing on creating a chatbot which can provide all the details of the project. It'll able to filter, explain, redirect, and guide the user. If you're able to do, raise the issue and mention to me on discord server.


Thank you and are you gonna add more configuration options?

Dear developer,
Thank you so much for your effort in extracting the menu bar from yabai. So far I see we can configure the time format to show the date on the menu bar. I am wondering if you have a plan to add more configuration options? For example, to add some components showing the CPU/MEM/HD info, or the volume info which is probably the must-have component in the menu bar.
Also, could you please share your plans to develop this amazing and must-have project for yabai users?
Thank you very much. Stay safe and healthy.

Yes, but to do so we need more dynamic blocks modules (each drawing, like the date, would be a block) and you can then choose the blocks you want to display (and their order).
Anyway, I didn't have time to do it yet.

Thank you. Looking forward to perfecting it.

Hi @somdoron,
yabai has removed its built-in status bar. Spacebar is so far the most promising solution. We really hope you can continue developing it. Thanks.

It would be great to have something as extensible as Polybar / i3blocks for MacOS

Wow, extensibility like Polybar/i3blocks is too luxurious. I just hope some basic configs and customizations could be added. I am not familiar with macOS API. Seems I should learn it and make some contributions. Also, I hope there could be other contributors to make this bar sexier. :)


go_1_17: 1.17.6 -> 1.17.7

Motivation for this change
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@jonringer Any objection to sending this to master? It's a security update and I don't really see ~1000 rebuilds on each platform making hydra much worse than it already is.

I think it was ~1300 rebuilds or so last time. Should be fine as the next staging-next wont be for a while.


document issue #177 about overriding default sort order

The feature to override the default sort order was not yet documented, so I added it.

Thank you. The documentation part of the app is not that clean :/
I could not figure out for a long time. Lately I try to make the app self documented and keep all the options in the app. (i.e.: documentations like this should show app in the app eventually). Like I will add a popup in the settings around sorting that would show the same text.


taglib: 1.13.1 -> 2.0.2

Description of changes
Changes: https://github.com/taglib/taglib/releases/tag/v2.0 https://github.com/taglib/taglib/releases/tag/v2.0.1 https://github.com/taglib/taglib/releases/tag/v2.0.2
Removing the cmake workaround from https://github.com/NixOS/nixpkgs/pull/245926#issuecomment-1656200044 as it is now fixed upstream.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Probably has to wait until 24.11 is branched off

NixOS 24.11 has released

Build of easytag fails with this update:
src/tags/gio_wrapper.cc:354:36: error: 'ulong' is not a member of 'TagLib'; did you mean 'ulong'?
  354 | GIO_IOStream::removeBlock (TagLib::ulong start, TagLib::ulong len)
      |                                    ^~~~~
/nix/store/wv0igx96mykkhfx7y1rd3iy9i0152h4r-glibc-2.40-36-dev/include/sys/types.h:148:27: note: 'ulong' declared here
  148 | typedef unsigned long int ulong;
      |                           ^~~~~
src/tags/gio_wrapper.cc:354:57: error: 'ulong' is not a member of 'TagLib'; did you mean 'ulong'?
  354 | GIO_IOStream::removeBlock (TagLib::ulong start, TagLib::ulong len)
      |                                                         ^~~~~
/nix/store/wv0igx96mykkhfx7y1rd3iy9i0152h4r-glibc-2.40-36-dev/include/sys/types.h:148:27: note: 'ulong' declared here
  148 | typedef unsigned long int ulong;
      |                           ^~~~~
make[2]: *** [Makefile:2941: src/tags/easytag-gio_wrapper.o] Error 1
make[2]: Leaving directory '/build/easytag-2.4.3'
make[1]: *** [Makefile:3280: all-recursive] Error 1
make[1]: Leaving directory '/build/easytag-2.4.3'

Thanks for taking a look. Yeah it does seem like packages without explicit support for 2.0 will break.
Guess will need to preserve the 1.x version for these packages...


Update README & Wiki

Definitely need to update the README to help people understand what Operations is all about. Off the top of my head, these are the things which need improving or better guidance.

[x] Better / simpler / shorter examples of Operation subclasses
[x] Example usage of provided conditions, observers, operations.
[x] Device Capability permissions, including when to use AuthorizedFor or GetAuthorizationStatus.
[x] Links to & compatibility with other Advanced NSOperations style frameworks.
[x] Improved guides/info on writing custom Operation subclasses, what methods to override, how to manage cancellation.
[x] When & how to use GroupOperation - other methods for scheduling & dependency management.
[x] Use of built in logging capabilities
[x] When & how to use mutual exclusivity

Current coverage is 64.79%

Merging #136 into development will not affect coverage as of 1eb30dc

@@            development    #136   diff @@
===========================================
  Files                48      48
  Stmts              2511    2511
  Branches              0       0
  Methods
===========================================
  Hit                1627    1627
  Partial               0       0
  Missed              884     884

Review entire Coverage Diff as of 1eb30dc

Powered by Codecov. Updated on successful CI builds.

I haven't actually added all this info to the README, but instead wrote an entire programming guide on readme.io. I'm sure that over the next week this will be improved, and any missing bits completed.


working CSS V2 Content

V2 CSS Content!
...
It's done!
...
(falls over)

@jshcrowthe and @straker please check this out 🐼

👍

@straker thanks for the feedback. I made those changes.


Quest passthrough no longer working in StereoKitTest

Description
It looks like something might have changed in a recent SK preview version (v3.7-preview.7) that broke the StereoKitTest passthrough demo! When I try to run the StereoKitTest project on my Quest 2, the passthrough no longer works as expected. Where I expect to see passthrough video, I see black pixels.
I noticed this when I was updating one of my projects to the latest SK preview, but the passthrough wasn't working. I did some sleuthing, and it looks like the breaking change was commit bf0869c092a6c11b0641d6cce3c0ea2e4c71dfa2. Before this commit, the passthrough was working in the StereoKitTest project.
Platform / Environment

Windows 11
Meta Quest 2
Quest Link
SK version: a commit between 3.7-preview.6 and 3.7-preview.7

Logs or exception details
Nothing super interesting in the logs here, but including them just in case:
[SK diagnostic] Initializing StereoKit v0.3.7-preview.6 Win32 x64...
[SK diagnostic] Initializing Platform
[SK diagnostic] sk_gpu: Requesting debug Direct3D context.

[SK diagnostic] OpenXR depth LSR ext enabled!
[SK diagnostic] Set color space to XR_COLOR_SPACE_REC709_FB
[SK diagnostic] Creating view: PrimaryStereo color:rgba32_sRGB depth:depth32 blend:Opaque
[SK diagnostic] Setting view: PrimaryStereo to 1568x1568
[SK diagnostic] Bounds updated: 3.82x5.55 at (0.0,-1.2,0.0) (0.00,0.00,0.00,1.00)
[SK diagnostic] Initializing Audio
[SK info] Using audio backend: WASAPI
[SK diagnostic] Initializing Assets
[SK diagnostic] Initializing Defaults
[SK diagnostic] Initializing World
[SK diagnostic] Initializing Sprites
[SK diagnostic] Initializing Lines
[SK diagnostic] Initializing UI
[SK diagnostic] Initializing Renderer
[SK diagnostic] Initializing Physics
[SK diagnostic] Initializing Input
[SK info] Initialization successful
[SK info] XrTime:<PHONE_NUMBER>
[SK diagnostic] sprite_create: Atlased sprites not implemented yet! Switching to single.
[SK info] Starting Scene: DemoWelcome
[SK diagnostic] OpenXR session begin.
[SK info] App focus changed to: Active
[SK info] Starting Scene: DemoFBPassthrough
[SK info] xrEndFrame [XR_ERROR_HANDLE_INVALID]
[SK info] Bye!
[SK info] Session Performance Report:
[SK info] ______________________________________________________
[SK info] |         System | Initialize |   Update |  Shutdown |
[SK info] |________________|____________|__________|___________|
[SK info] |       Defaults |    78.80ms |          |    0.19ms |
[SK info] |     FrameBegin |            |  0.104ms |           |
[SK info] |          Input |    11.78ms |  0.053ms |    0.06ms |
[SK info] |        Physics |     3.34ms |  0.066ms |    0.05ms |
[SK info] |       Renderer |     2.94ms |  0.000ms |    0.20ms |
[SK info] |             UI |     6.09ms |  0.012ms |    0.28ms |
[SK info] |       Platform |   819.67ms |          |  103.75ms |
[SK info] |            App |   134.05ms |  1.221ms |           |
[SK info] |      Animation |            |  0.000ms |    0.00ms |
[SK info] |          Lines |     0.77ms |  0.019ms |    0.01ms |
[SK info] |        Sprites |     1.26ms |  0.000ms |    0.17ms |
[SK info] |           Text |            |  0.020ms |    0.01ms |
[SK info] |         UILate |            |  0.000ms |           |
[SK info] |          World |     1.02ms |  0.001ms |    0.01ms |
[SK info] |    FrameRender |            |  0.827ms |           |
[SK info] |         Assets |     3.35ms |  0.002ms |    0.01ms |
[SK info] |          Audio |   176.97ms |  0.004ms |    4.67ms |
[SK info] |________________|____________|__________|___________|

C:\Git\StereoKit\StereoKit\bin\x64_Debug\StereoKitTest\StereoKitTest.exe (process 24676) exited with code 0.
To automatically close the console when debugging stops, enable Tools->Options->Debugging->Automatically close the console when debugging stops.
Press any key to close this window . . .

It looks like reverting commit bf0869c092a6c11b0641d6cce3c0ea2e4c71dfa2 on the latest develop does fix the passthrough issue. I can go ahead and make a PR of that change if that's at all helpful?
Swapchain formats are a bit beyond my depth at this point! So I'm not sure if doing a simple revert here is the best fix for this particular issue. But at least it's an option to get the FB passthrough working again, short term.

Thank you for pinning this down to the exact commit! I had a bit of a local Android build blocker that I just found my way through, so I'll be investigating this a bit deeper pretty soon :)
I was so excited about getting rid of that hack 😩 It looked like it behaved fine, but I guess it was a little optimistic! Also interesting that this still seems to work fine on standalone Quest.

This should be fixed in 0.3.7-preview.1570!


Responder renders default error template when Html errors

Problem statement
If Html encounters an error while attempting to render, nothing helpful happens for the user or developer. The browser may throw an error (like Chrome's "this page is broken") or simply show a blank page.
What this does

*Responder.Html renders a template (an "error template") provided by the user (through configuration) when Html hits an unhappy path.
http/template.NewParser merges many different fs.FS into a single cache of HTML templates that can be opened during runtime.
ranger provides a default error template by embedding it (and an fs.FS) at compile-time. This - and other future defaults - can be overwritten by matching the path to a template exactly. There are two different kind of filesystems that one could use to accomplish this: the OS and an embedded filesystem.

In non-Production environments, here's what developers see with that default error template:

Production looks like this, given resp.Responder is initialized with a ContactErrMsg (likely to be refactored to a value passed in a ranger.Config):

Follow-ups

I'm using the URLs for logos & the favicon found on xyplanningnetwork.com. This is brittle, but there's no simple solution at the moment. http/router is constrained to OS-level files for assets. This may need to be reconsidered, or, opened up further so we can images, specifically, and maybe CSS files as well.
For non-production environments, let's see what additional stack trace information would help debugging.

TODO:

[x] Make the default error template more purty
[x] Can the default template be approached more as a layout where the user provides a partial that gets shown to their end user?
[x] Include other default templates?

Some of the TODOs were passed on in an effort to narrow the scope of what's possible and instead provide the canonical one path developers can follow.

@profsmallpine before I jumped over to session store stuff, wanted to get this out of my head. It's ready for another review.


Program incompatible with mysql5.6

When the program installation starts, an error "error 1709: index column size too large. the maximum column size is 767 bytes" is reported
I think the length of a column is so long that the index is invalid. But this should be a small problem. I hope the official team can change the length a little.

@ComradeProgrammer

please set innodb_large_prefix=1 in mysql configuration file (for example, my.ini usually)

ok


Mustache Spec compliance

Since Mustache implementations should strive to be template compatible, this change adds basic compliance testing against the formalized Mustache Spec.  This is currently set up against v1.1.2 of the spec, without support for the optional lambda module.

How could this be integrated into the test suite that gets run when we run rake?

Closing this as #301 was merged which fixed testing against the spec


Cross-link "scoped service" in hosted services

Fixes #11064

New warning on this one (not touched by this PR) ...
aspnetcore/tutorials/first-mvc-app/adding-model.md
Duplicate tab id: (visual-studio, 2),(visual-studio-code, 2),(visual-studio-mac, 2).


[Spanish] localize 'Containerization'

Localize the content/en/containerization.md document to Spanish

Hello! Can you assign me this issue? This and https://github.com/cncf/glossary/issues/576
Thanks!


Action Button

Hello goedh452, (I am using Google Translate)
a BIG thank you for this module which works at the top.
I am not an expert in programming but I do it at my own pace ...
I wish I could turn my lights on / off on the Magic Mirror but I can't see my "Actions" devices created with url.
Thank you

I do not use Domoticz anymore so won't be able to maintain this module.


Whitespace in questionnaire answer codes

Hey,
The answers in most questionnaires have whitespace before non-0 'code's.
E.g.
in phq-8 question 1
        "select_choices_or_calculations": [
            {
                "code": "0",
                "label": " Not at all "
            },
            {
                "code": " 1",
                "label": " Several days "
            },
            {
                "code": " 2",
                "label": " More than half the days "
            },
    .....

Also in "patient_determined_disease_step" there is a "\r" before each answer code. Is there any reason we can't remove that whitespace? The schemas appear to consider the answer values as integers, at least the whitespace doesn't carry over into the exported CSV files.

cc/ @kerzmaximilian  is this the normal output of the REDcap data-dictionary processing? Is there any reason for the padding?

For Reference this is introduced by REDCap, and is now cleaned up.
cc/ @CallumSa


issue: #146 adding URL to book an appointment button

Completes issue #146
Changes in this pull request:

added URL to book an appointment button

looks like there's an issue with nodejs.org right now, let's see if it's better tomorrow


changes for 1.1

An initial edit @errordeveloper. We need to update the Apache image for this though, but I've edited this as is and also swapped out 1.01 for 1.02.

+1
On Tue, 25 Aug 2015 18:02 Anita Buehrle<EMAIL_ADDRESS>wrote:

Merged #41 https://github.com/weaveworks/guides/pull/41.
—
Reply to this email directly or view it on GitHub
https://github.com/weaveworks/guides/pull/41#event-391914073.


Stopping search prematurely and immediately

A search can be stopped by setting the external boolean registered with RegisterExternalBooleanAsLimit() to true. But with a heavy model, it can still take some times.
CpModelBuilder modelBuilder;
for (int i = 0; i < 10000; ++i)
{
	auto x = modelBuilder.NewIntVar({0, 1000});
	auto y = modelBuilder.NewIntVar({0, 1000});
	modelBuilder.AddLessThan(x, y);
}

This code is solved, in average, in:

0.523544s by default;
0.501957s when the external boolean is set to true after 50 ms;
0.386621s when the presolve is disabled;
0.417718s when the presolve is disabled and the external boolean is set to true after 50 ms.

Is there any way to stop the search (almost) immediately? Why does the solving time sometimes increases when the external boolean is set to true?

Because we do not check the limit after every instruction. Checking the
limit is expensive, and we limit the rate of checks.
Furthermore, be careful with user time and wall time. It could explain the
difference between 47 ms and 50 ms.
We will try to improve precision, but a few Ms of delay is not worth
slowing down the solver for.
Le sam. 24 août 2019 à 14:12, Amaury Dalla Monta<EMAIL_ADDRESS>a écrit :

A search can be stopped by setting the external boolean registered with
RegisterExternalBooleanAsLimit() to true. But with a heavy model, it can
still take some times.
CpModelBuilder modelBuilder;
for (int i = 0; i < 10000; ++i)
{
auto x = modelBuilder.NewIntVar({0, 1000});
auto y = modelBuilder.NewIntVar({0, 1000});
modelBuilder.AddLessThan(x, y);
}
This code is solved, in average, in:

0.523544s by default;
0.501957s when the external boolean is set to true after 50 ms;
0.386621s when the presolve is disabled;
0.417718s when the presolve is disabled and the external boolean is
set to true after 50 ms.

Is there any way to stop the search (almost) immediately? Why does the
solving time sometimes increases when the external boolean is set to true?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/issues/1517?email_source=notifications&email_token=ACUPL3OFMV52TTL5YZ27PKLQGEQUJA5CNFSM4IPGA5SKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HHFUDPA,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACUPL3LENVM5J2UYOCGQQ7LQGEQUJANCNFSM4IPGA5SA
.

I understand checking is expensive, but we are talking about a solving time of 500 ms here, despite the boolean being set after 50 ms. That's one order of magnitude of difference.

I've just tried the same experiment with a real model, and stopping takes 20 s, despite being requested to stop after 50 ms. That makes pretty much any parallelization impossible, for instance. Is there any other solver step or options, that could be the cause and need to be disabled?

Can you send me the proto of the model ?

I can't seem to find again the parameters leading to the model with a stopping time of 20 s. Here is one needing around 2 s for that, if it helps.


Allow "Features" to be inherited

Right now, since the Features annotation is not annotated with the "@Inherited" annotation, one cannot take advantage of the fact that most features have a test superclass and must instead annotate each specific subclass. Would it be possible to add the annotation?

@afelisatti nice call, should be done in 1.5.2

fixed in Allure 2 adaptors. You can send us a pull request if you want to have this in Allure 1, but I recommend you to migrate to new adaptors. https://github.com/allure-framework/allure-java/issues

Hi, @baev. I'm not sure when we would migrate so I've opened a PR for Allure1. Thanks!


40 character 160 bit hex currency code

Hello, Im trying to understand how to get this value in order to run the BOT, can you please offer some orientation in how to obtain this value?
I have coins from https://xumm.community/tokens, where i can get token_currency_name and the token_issuer.
I'm missing how to get:
const TOKEN_CURRENCY = '5041524300000000000000000000000000000000'; //40 character 160 bit hex currency code
Thank you.

Solved this, apparently from documentation https://xrpl.org/currency-formats.html i dont need that value, i can put directly the currency code and xrpl library can understand this.
Thank you!

correct, the script just assumes it's a non-standard currency code since these are so common for xrpl tokens. a standard currency code can use the ascii value instead of the 160 bit hex value.


serve local flask server to the web

Hi,
I was trying to work with ngrok to serve the flask server in the web and basically forward my local version to the web.
Using the pyngrok package leads to the following error which is kinda clear. But maybe there's a workaround?:
pyngrok.exception.PyngrokNgrokInstallError: "darwin_x86_64_arm" is not a supported platform
Pyngrok
flask-ngrok has problems with the auth-token which is probably related to the v2 - v3 upgrade of ngrok.
Flask-Ngrok

I was wondering if someone has another solution to make it work or had the same issues.
Best,
Patrick

Found a solution.
Installing ngrok and calling a subprocess in another Thread via Python.
like ngrok http 5000
New version coming soon.


Feature: Is there a way to check score based on rick levels

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Is there a way to get score based on risk levels. (HIGH, MEDIUM, and LOW)
ex: scorecard --repo=https://github.com/name/reponame --checks Branch-Protection --show-details for HIGH only

Thanks for the issue, and sorry for the late reply!
Unfortunately today there is no way to filter results by score. But this sounds like a useful feature to have!
Our current implementation assigns checks a risk, and we don't distinguish between scores. However, we have this on our roadmap for this year. Probably Q4, though.
There's a similar issue https://github.com/ossf/scorecard/issues/1321
We'll post updates as we get closer to getting this feature landed.
Thanks!


About

The About section of repo states that

About
This is a PhD work for cellular genetic algorithm in Python.

It should be
Cellular Genetic Algorithms in Python.

I've updated the About section to 'Cellular Genetic Algorithms in Python' as you suggested. Thank you for the feedback!


Manual focus triggers flash

What are you trying to achieve or the steps to reproduce?
I've implemented focus on tap using focus method and flash toggle.
If flash is on, then camera will activate flash while focusing and then deactivate it, just like when it is taking a photo.
I expect it only to focus, without turning on flash.
fotoapparat.focus().whenAvailable {
            Timber.tag(TAG).d("focus state is $it")
        }

How did you initialize FA?
        return Fotoapparat
                .with(context)
                .into(renderer)
                .previewScaleType(ScaleType.CENTER_CROP)
                .photoSize(AspectRatioSelectors.wideRatio(SizeSelectors.biggestSize()))
                .lensPosition(LensPositionSelectors.lensPosition(LensPosition.BACK))
                .focusMode(Selectors.firstAvailable(
                        FocusModeSelectors.autoFocus(),
                        FocusModeSelectors.fixed()
                ))
                .flash(FlashSelectors.off())
                .logger(Loggers.loggers(Logger { Timber.tag(CameraImpl.TAG).d(it) }))
                .cameraErrorCallback({ errorSubject.onNext(it) })
                .build()

What was the result you received?
When camera is focusing, flash is activated.
What did you expect?
When camera is focusing, flash is not activated, like on default google camera.
Context:

FA version: 1.5.0
Devices/APIs affected: Seems to be not device specific (Tested on  Nexus 5x, Samsung A5, Xiaomi redmi 4, Samsung S5)
any other relevant information:

Thanks for working on this lib! :)

Thanks! I have seen few things with camera1 & flash so far...
Related : #99


test: fix Infinite loop during VM provisioning

Fixes: #16871
An environment variable in the Jenkins file has been set up to provide a timeout for polling of Cilium Pods.
Signed-off-by: Gaurav Genani<EMAIL_ADDRESS>

#17031 (comment) wasn't addressed :)

Hi @christarazi. I have fixed it here Here.

test-me-please


Magic methods not setup after upgrading 2.0.rc3 to rc6 ("assert" etc)

The busted tests in awesomeWM appear to fail after upgrading busted from 2.0.rc3 to rc6 (previously we suspected Lua 5.2 vs. Lua 5.1):

spec/wibox/test_utils.lua:51: attempt to index global 'assert' (a function value)

(full build: https://travis-ci.org/blueyed/awesome/builds/51226266).
The "magic" setup of assert, spy etc does not appear to work as expected.
This appears to have regressed between 2.0.rc3-0 (which I was using locally, with Lua 5.2) and 2.0.rc6-0 (current).
The issue reference in awesomeWM is: https://github.com/awesomeWM/awesome/pull/139

Bisected it to 7e98bade28b560000b755fca9e0e2b0bb1254694:

commit 7e98bade28b560000b755fca9e0e2b0bb1254694
Author: Oscar Lim<EMAIL_ADDRESS>Date:   Wed Dec 31 01:52:26 2014 -0800

Restrict luassert variables to busted environment

The luassert variables assert/spy/mock/stub should only be visible
inside a busted context. Other modules outside of busted should be free
to reuse these variable names without interfering with the test
environment. If other modules need to use luassert, they should
explicitly `require` it. Otherwise, `assert` should default to the
builtin Lua `assert`.

I guess that's a "won't fix" then.. :)

To clarify things: it looks like the issue is, that assert is being used from a test/spec helper in this case: https://github.com/awesomeWM/awesome/blob/master/spec/wibox/test_utils.lua
Error → spec/wibox/test_utils.lua @ 51
./spec/wibox/layout/align_spec.lua
spec/wibox/test_utils.lua:51: attempt to index global 'assert' (a function value)
Error → spec/wibox/test_utils.lua @ 51
./spec/wibox/layout/flex_spec.lua
spec/wibox/test_utils.lua:51: attempt to index global 'assert' (a function value)
Error → spec/wibox/test_utils.lua @ 51
./spec/wibox/layout/fixed_spec.lua
spec/wibox/test_utils.lua:51: attempt to index global 'assert' (a function value)

I am reopening the issue, because I am not so sure anymore if this should or should not work - although the latter seems more likely.

If you are using a helper module for your tests/specs then you should explicitly require 'luassert' in your helper module instead of relying on any kind of special setup by busted.  This also makes your test helpers more robust in the event you may need to reuse them in another testing framework.
The same would go for luassert.spy, luassert.stub, luassert.mock.
local assert = require 'luassert'
local spy = require 'luassert.spy'
local mock = require 'luassert.mock'
local stub = require 'luassert.stub'

or alternatively, with the latest updates in git
local assert = require 'busted'.assert
local spy = require 'busted'.spy
local mock = require 'busted'.mock
local stub = require 'busted'.stub

My apologies, I just don't know enough about Lua and Busted, but does #335 affect things here?  It seems to be related.

Yes, #335 enables the following:
local assert = require 'busted'.assert
local spy = require 'busted'.spy
local mock = require 'busted'.mock
local stub = require 'busted'.stub

Thanks for clarifying @o-lim!

@jszakmeister - confirm that it works for you, and I'll close out. Thanks, @o-lim!

@ajacksified
FWIW, it "works" for me (the original reporter), as in "I understand what you did there".

@ajacksified No worries.  I thought maybe the situation had changed with a recent commit and it would be magically available.  But I understand what's going on now.  Thanks!

Closing the issue.  Thanks for all the clarification! :)


Feature/2.0/append

in chunk_engine alongside write_array, implement append_array.

The line between the structure and chunking sections are getting more and more blurred. Would it be possible to formalize precisely where the boundaries are? [if this doc already exists. please link it]

I'm expecting some merge conflicts with #898 but I'll leave that up to you

there is, but i think im going to merge it into this PR myself once the refactor is complete since it's become broadened in scope anyways.

tests may fail due to benchmarks timing out (we are going to fix them in a separate PR)

Minor changes.
I don't see tests or benchmark tests for append_array. Can we add those please?
You can basically do a for loop where you are appending to the dataset.

you should read the description.


comment config working on arch but not on linux (arch)

Hi - first of all, this is my first attempt at raising an issue on gh - so please let me know if there is anything I can do to be more helpful!
I have an nvim config I'm sharing between two computers, one Mac / one Arch, and everything is working great on both except for comment on my Arch machine despite working great on my mac. I've been searching to see if there is something I'm missing but am coming up with nothing - is this a known bug/ dependency issue maybe?
I'm importing comment using packer with a standard use statement, and then this is my config file:
local setup, comment = pcall(require, "comment")
if not setup then
	return
end

comment.setup()

Perhaps it's a case sensitivity issue ignored by mac.
I think the require argument should be "Comment" instead of "comment".


[6.4.x] JBPM-5277 - getTasksAssignedAsPotentialOwner doesn't allow groups searching, only actorid

This fixes the problem with the list of accepted commands which was not updated before and causes fails of all requests with GetTasksByGroupCommand.

It seems that this fixes the problem only partially.

+1 to merge
could you please back port this to 6.5.x and master?

@livthomas reading your comment - are you still working on the other part or need help with it? I'll wait with merge for now...

@livthomas I believe you need to add it here as well https://github.com/livthomas/droolsjbpm-integration/blob/e86ee5803da4ba95ba95ee14af96cd0632ae35b9/kie-remote/kie-remote-client/src/main/java/org/kie/remote/client/jaxb/JaxbCommandsRequest.java#L129

Although it would not be trivial, a test could be written to make sure that the two places contain the same elements. This seems to me like a major potential source of bugs.

@mswiderski I have added it to some other places where it should be but I need to test it in Business Central in order to verify it really works.
@triceo Actually, it is much more complicated as you can see from the latest fix.

I have just tested it in Business Central and it works.

@livthomas could you please create PRs for upper branches?

@mswiderski Sure, I am working on it.


dynamic task spawning + grouped execution

[Short description explaining the high-level reason for the pull request]
Changes
See commit history
How I tested this
Heavily unit tested
Notes
See checklist in comments for what's missing/not present.
Checklist

[x] PR has an informative and human-readable title (this will be pulled into the release notes)
[ ] Changes are limited to a single goal (no scope creep)
[x] Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
[x] Any change in functionality is tested
[x] New functions are documented (with a description, list of inputs, and expected output)
[x] Placeholder code is flagged / future TODOs are captured in comments
[x] Project documentation has been updated if adding/changing functionality.

OK, massive PR. Getting there. Tasks remaining:
[ ] Decisions
- [ ] How to do results builder?
- [ ] What to call Parallel?
[ ] Quality/prod-readiness
- [ ] Add documentation
- [ ] Consolidate the end_to_end tests
- [ ] Audit the structure of the new code, maybe move more old stuff into execution
- [ ] Ensure telemetry is present
[ ] Missing features
- [ ] Results builder in the new driver (open whether it'll be a new node or not)
- [ ] Beef up multiprocessing to allow for serialization
[ ] Improvements
- [ ] Evaluate/plan for async integration
- [ ] Evaluate/plan for spark integration with mappartitions + subgroups
- [ ] Ray TaskExecutor
- [ ] Joblib TaskExecutor
[ ] Release/Post
- [ ] Version bump
- [ ] Social media
- [ ] TryHamilton on orchestration (TBD on pyodide with Parallel[])

OK, after thinking a bit I want to make the following design changes

Unify to one driver
Pass the Executor into the driver
Have StandardExecutor TaskExecutor
Have them each be able to validate a function graph

This way we don't have to bifurcate. We'll still use the DriverBuilder, and can have all sorts of flexibility on execution (even with spark), including ones that build off of others (E.G. spark/async on top of task-based, etc...).

Do all the examples in the examples folder run?

Yep until I get rate limited :)

okay hold up -- I found some examples that seems to have changed behavior...

and it seems like this needs to be rebased.


High memory usage uploading large files

Uploading large files (e.g. 500 MB) will use a lot of memory receiving the upload.
This occurs with nodejs 0.6.1 on Linux x86_64 and nodejs 0.6.2 on Windows 32-bit.

I upload 500 MB file it uses almost 500 MB. It seems to be related to the use of fs.WriteStream. If I use fs.writeSync it works fine. formidable is using fs.WriteStream which will start buffering in memory if kernel buffer if full - writeStream.write() will return false in this case. http://groups.google.com/group/nodejs/browse_thread/thread/c8956eb9a564f1f9

I am using the upload.js example.

It could also be related to the fact that i'm testing using localhost as well as over a gigabit network so writing the uploaded data to disk may be the bottleneck that is causing it to start buffering to memory.

If you could try in 0.4 to make sure that'd be awesome.
Formidable tries to pause reading from the network if the disk can't catch up. So that should not be the issue.

In file.js File.prototype.write, it has this._writeStream.write(buffer, function() { ... });.
http://nodejs.org/docs/v0.4.0/api/streams.html#writable_Stream says that there is no 2nd callback parameter.
I can also confirm that the write function is repeatedly returning false meaning it is buffering into memory.

With all due respect, fs.WriteStream#write takes a callback. I know because I've implemented it : ).
https://github.com/joyent/node/blob/v0.4/lib/fs.js#L1070
Can you please test against 0.4?
--fg

Yes I edited that comment after I realised. I fixed the issue now, see https://github.com/felixge/node-formidable/pull/110.


batching and compression for signalling messages

Related issue:
https://github.com/uProxy/uproxy/issues/1490
This introduces SignalBatcher, which can be used to batch and compress signalling channel messages. The uProxy frontend should be able to use this, removing a bunch of tricky logic from the frontend.
I'm seeing a great reduction in size:

description
size (bytes)
percent reduction

unbatched signalling channel messages (JSON)
1208
0%

batched messages (JSON)
1104
8.6%

gzipped messages (binary)
589
51.2%

Since there's a lot of redundancy in signalling messages (e.g. the word candidate like 50 times) I would not expect the final result to grow much beyond ~1000 characters even when many more STUN servers are queried. That's well under the ~2000 that starts to pose a problem in Hangouts.
Summary of changes:

have churn emit a NO_MORE_CANDIDATES signal when it's done (should be harmless to existing clients)
SignalBatcher can be attached to your signalling channel queue and it groups by NO_MORE_CANDIDATES messages
update copypaste sample to use SignalBatcher

Review status: 0 of 13 files reviewed at latest revision, 8 unresolved discussions, some commit checks pending.

src/bridge/onetime.ts, line 36 [r1] (raw file):
Would this to be better off as part of the Bridge interface?

src/bridge/onetime.ts, line 87 [r1] (raw file):
This seems a little scary to me, because it loses all other providerNames after the first.  Maybe it would be better to make this use for (var providerName in message.signals)?

src/bridge/onetime.ts, line 94 [r1] (raw file):
This also seems scary, if there are already multiple signals in one message.  I would prefer a loop.

src/bridge/onetime.ts, line 100 [r1] (raw file):
Doing this as a callback is pretty unusual for us.  Why not a Promise ... or just stay synchronous and use the return value of addToBatch?

src/bridge/onetime.ts, line 130 [r1] (raw file):
Deserves a comment.  Is this just to try to hint the garbage collector?  (That shouldn't be necessary...)

src/copypaste-socks/freedom-module.ts, line 105 [r1] (raw file):
encodedMessage is a string, though, right?  So why call toString?

src/copypaste-socks/polymer-components/getter.html, line 33 [r1] (raw file):
Numeric comparison on a string?

src/copypaste-socks/polymer-components/getter.ts, line 21 [r1] (raw file):
Seems like maybe an error should be thrown here?  Silently ignoring the input seems bad.

Comments from the review on Reviewable.io

Review status: 0 of 11 files reviewed at latest revision, 8 unresolved discussions, some commit checks pending.

src/bridge/onetime.ts, line 36 [r1] (raw file):
Right now, nothing in Bridge needs this. I'm reluctant to push it "down" (to a more important class) until there's a clear need. Good question, though.

src/bridge/onetime.ts, line 87 [r1] (raw file):
It's safe given that addToBatch raises an exception if called with signals having >1 providerName. That said, it's straightforward to add some checks. Performance isn't exactly key here, so I extracted out the code to check that messages just have provider and call it here, too.

src/bridge/onetime.ts, line 94 [r1] (raw file):
See above.

src/bridge/onetime.ts, line 100 [r1] (raw file):
I'm keeping in mind things like renegotiation, which could lead to a new batch of signalling messages (I'm sure we don't support renegotiation well today but if we ever did move to use this SignalBatcher for every-day peerconnection negotiation, it would become important).
A Promise approach won't work if there can be multiple batches, and using addToBatch's return value is problematic because of PeerConnection's use of handler queues.

src/bridge/onetime.ts, line 130 [r1] (raw file):
Not GC, this is in anticipation of another batch (see comment above).
I did move the statement and a comment in the interest of clarity, though.

src/copypaste-socks/freedom-module.ts, line 105 [r1] (raw file):
Right, good catch. Fixed.

src/copypaste-socks/polymer-components/getter.ts, line 21 [r1] (raw file):
Right...I've re-introduced the consumeInboundText function which sends the box content to the freedom module for validation before enabling the button. Should be a lot better.

src/copypaste-socks/polymer-components/getter.html, line 33 [r1] (raw file):
Oops! Not relevant now that I've introduced a round-trip to the freedom module for validating the input box's contents (see below).

Comments from the review on Reviewable.io

Review status: 0 of 11 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

src/copypaste-socks/polymer-components/getter.ts, line 23 [r1] (raw file):
Hmm.  parseInboundMessages takes a mandatory string argument.  If it's actually not mandatory, maybe its type signature should be changed to make that an optional argument?

Comments from the review on Reviewable.io

Review status: 0 of 11 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

src/copypaste-socks/polymer-components/getter.ts, line 23 [r1] (raw file):
I did update the function's signature in copypaste-api.ts, can you take another look?

Comments from the review on Reviewable.io

:+1:


value/date not set after clicking a date

    = date-picker date=startDate valueFormat='YYYY-MM-DD' allowBlank=true

after I click the date, the input field doesn't show anything. If I type a date, the startDate is updated

+1


The Dock Position Box does not work anymore

Godot version:

eeee47196c19dc271d6fcf8981946a1a29efd16a
OS/device including version:

Linux
Issue description:

My fault, sorry.


Completes download, restarts, runtime error

[*] 236.0 MB / 236.0 MB @ 0 bytes/s [##################] [100%, 0s left]
[*] 236.0 MB / 236.0 MB @ 267 kB/s [##################] [100%, 0s left]
<class 'RuntimeError'> cannot join thread before it is started
URL [https://streaming.lemonstream.me/*****] from https://gostream.is/film/rick-and-morty-season-1-9011/watching.html?ep=127301.

Fixed.


skrub improperly selected dir

Not a true error if one knows what they are trying to do but rm will remove a directory whether or not it has a trailing slash.
$ mkdir Empty
$ skrub Empty
events.js:160
      throw er; // Unhandled 'error' event
      ^

Error: EISDIR: illegal operation on a directory, open '/Users/{}/Code/Empty'
    at Error (native)

$ skrub Empty/
$

File globbing issues belong with the file-globbing library globby or more likely the pattern matching library globby uses called minimatch.
If this issue truly pertains to this project feel free to reopen. Thanks! 👍


OpenOCD does not work on USB3.0 ports on Windows

I had a hard time trying to follow the hardware setup chapter on Windows 10.
OpenOCD would just not see the STM32F3DISCOVERY board even though it shows up fine on device manager and works fine with the ST software.
It turns out USB 3.0 capable ports do not work with OpenOCD, it fails with "Error: open failed".
Please add a note in the book to use USB 2.0 USB port (which works) as a workaround until the issue with OpenOCD is (hopefully) resolved.

Can you add issue link here?

I don't have a proper issue link, OpenOCD guys don't take this seriously ;(
There are several reports of this in their bug database over the years, and they don't care... It may do with them using prehistoric version of libusb and not willing to update.
I will post a link if I pursue this in the future, meanwhile I'm more interested in writing embedded Rust than fixing openocd, obviously :)

Here is one [(https://sourceforge.net/p/openocd/tickets/249/)]

I just hit this today :(

ooof, frustrating, and definitely something we should note or perhaps, move away from OpenOCD for this section.
As other alternatives, for ST boards (and the STM32F3DISCOVERY) you may also be able to use stlink-org/stlink or the official ST utils to interact with the existing debugger firmware or  flash the debugger with jlink firmware and use the JLink tools, either of which should be usable without openOCD.

I am happy to report that the latest version of openocd I got from https://xpack.github.io/blog/2023/01/30/openocd-v0-12-0-1-released/ seems to be working fine with USB3 port on Windows 11! I guess this issue can be closed now


Update performance-guidance.md

@WilliamDAssafMSFT thanks for combining the two sections. It was a good idea. I've added some more insights and tips to optimize connection pooling

@WilliamDAssafMSFT
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@WilliamDAssafMSFT thank you for your constructive and spot-on feedbacks. Yes, I wrote those on Wikipedia to raise awareness but you are absolutely right that the doc should be more precise, actionable. I've edited it to accommodate your feedbacks. Please let me know your advice.

@WilliamDAssafMSFT thanks for edits. Can you please sign it off?

@azarboon Hi! This remains in review by a few others on the product group. Will update when ready.

@dimitri-furman thank you. I accomodated your feedback.

Just an update, @azarboon. Some of this guidance needs to be more nuanced. We are discussing internally. Holidays are slowing the conversation. Will be updating.  No action imminent.

Just an update, @azarboon. Some of this guidance needs to be more nuanced. We are discussing internally. Holidays are slowing the conversation. Will be updating. No action imminent.

Thanks for feedback.


Cannot call CircleImage  View by id to use it.

I have an Error it's occur when i try to call the image by its ID
-XML code :
 <de.hdodenhof.circleimageview.CircleImageView         android:id="@+id/setup_image"
-Java file
`import de.hdodenhof.circleimageview.CircleImageView;
public class SetupActivity extends AppCompatActivity {
private CircleImageView setupImage;

protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_setup);
    //the error happen when i write this lone
    setupImage = findViewById(R.id.setup_image);`

----------Error:
E/AndroidRuntime: FATAL EXCEPTION: main                   Process: com.example.mohamed.photo_blog, PID: 8120                   java.lang.RuntimeException: Unable to start activity ComponentInfo{com.example.mohamed.photo_blog/com.example.mohamed.photo_blog.SetupActivity}:  java.lang.ClassCastException: android.support.constraint.ConstraintLayout cannot be cast to de.hdodenhof.circleimageview.CircleImageView                       at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2799)                       at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2864)                       at android.app.ActivityThread.access$900(ActivityThread.java:181)                       at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1475)                       at android.os.Handler.dispatchMessage(Handler.java:102)                       at android.os.Looper.loop(Looper.java:145)                       at android.app.ActivityThread.main(ActivityThread.java:6126)                       at java.lang.reflect.Method.invoke(Native Method)                       at java.lang.reflect.Method.invoke(Method.java:372)                       at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1399)                       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1194)                    Caused by: java.lang.ClassCastException: android.support.constraint.ConstraintLayout cannot be cast to de.hdodenhof.circleimageview.CircleImageView                       at com.example.mohamed.photo_blog.SetupActivity.onCreate(SetupActivity.java:33)
Appreciate the help.

The exception says: [..]ConstraintLayout cannot be cast to [..]CircleImageView so it seems findViewById(R.id.setup_image) returns a ConstraintLayout - that's not an issue with this library. Please double-check your IDs and maybe clean the project.

what do you mean by check your IDs and maybe clean the project?

Make sure that (a) @+id/setup_image is only used once, at the correct place and (b) you are inflating the correct layout. Use "Clean Project" from the "Build" menu in Android Studio.

thank you so much you save the rest of my day
Have a nice day bro


Add warning for users

closes #13

I also added a small fix for the start_time of the environment. Currently, the start_time gets None as the initial value, causing errors for systems that utilize the time before the run method of the environment. @EserSteffen, can you check the changes and approve the merge?

This was included in #20


Create a new pull request by comparing changes

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 95.841%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
2034

Relevant Lines:
2085

💛  - Coveralls


I get code : "UNIMPLEMENTED" in IonicVue

I get code : "UNIMPLEMENTED" when i try to use this plugin with IonicVue.
Specific error that i get is : "CapacitorGoogleMaps" plugin is not implemente on android
In template i have :
And in mounted hook i have :
CapacitorGoogleMaps.create({
width: 200,
height: 200,
x: 20,
y: 20,
latitude: -33.86,
longitude: 151.20,
zoom: 12,
});

I regenerated apk file and it worked. Closed

I'm getting this same error on iOS using the next branch. Any suggestions?


Add int64 Tdim support for ExpandDims

This fix tries to add int64 Tdim support for ExpandDims.
In array_ops.cc, ExpandDims registers both int32 and int64 support for Tdim. However, only int32 kernel for ExpandDims has been supported.
This fix addresses the discrepancy by adding the support of int64 Tdim for ExpandDims.
Additional tests has also been added to cover the changes.
Signed-off-by: Yong Tang<EMAIL_ADDRESS>

Can one of the admins verify this patch?

Jenkins, test this please.


Update container from unsupported Ubuntu version.

Tested the docker build locally, but not with EB.

Wrong destination for the default site in nginx on Ubuntu 18.04 😞


Some dynamic things on the site aren't working

No interaction when moving mouse on left pillar
No "last updated" time on posts
etc.

I believe the "updated" is not working because of the git permission issues in the container:
fatal: detected dubious ownership in repository at '/workspaces/mattpopovich.com'
To add an exception for this directory, call:

        git config --global --add safe.directory /workspaces/mattpopovich.com

The interaction on the left pillar makes me think we are missing a js file or something. I tried to build the site on a different computer that builds jekyll-theme-chirpy with interaction and there was no interaction for mattpopovich.com

Left pillar interaction was an issue with upstream repo, fixed in https://github.com/cotes2020/jekyll-theme-chirpy/issues/849


Antd Select component onMouseDown events should not propagate (or should be configurable)

Describe the bug
Rendering this component inside another that has a MouseEvent handler causes that handler to fire when the antd Select component's dropdown items are clicked. For ancestors like modals, this causes the modal to close as most modals would have MouseEvent handlers for closing on click outside (see codesandbox).
I have created two separate PRs to address this.

https://github.com/xrutayisire/react-js-cron/pull/49 - provides full control to the user to specify select props for all field types
https://github.com/xrutayisire/react-js-cron/pull/50 - simply ensures that onMouseDown on antd Select components does not propagate the event

To Reproduce
Steps to reproduce the behavior:

Use Cron component inside a Modal (our issue is with Sanity modal component)
Select an element from any dropdown/select in the Cron component
The modal will close

Expected behavior
Clicking an item in a Select dropdown should not close the modal.
Screenshots
If applicable, add screenshots to help explain your problem.
CodeSandbox
https://codesandbox.io/s/nervous-james-uprzgq?file=/src/App.js
Versions (please complete the following information):

react-js-cron version 3.0.1
Ant Design version: 5.2.3
React version: 18.2.0
OS: -
Browser chrome

Additional context
Add any other context about the problem here.

Hi,
Thank you for the bug report. If you can check up the MRs pipelines and I can release a new version after this!
Thanks a lot!

No activity since Mars and now master changed. If you still need the feature, please update the PRs. Ensure everything is fine and create new PRs. Thanks for the contribution!

This is still an issue. I am trying to use this with ShadCN AlertDialog and the clicks don't register.

Sorry, I don't have time for this PR.
You can take the code, update it following the recommendations and I would approve it 🙂


The demo on Windows System has uglily looklike，like css radial-gradient

The image is copy from Windows System, Chrome browser, when you Dropping a Element and mousemove but not mouseup, the element will has a opacity, and like css radial-gradient.
I want this looklike in Macbook Chrome browser.

especially the element has a dark background color,the element will very very uglily .

Where you able to find a solution for this?

I think this is out of the scope of the script itself, since it is a Windows behaviour. When you drag and move things around in Windows, it shows the dragged item around the cursor with a radial fade effect, like on the image you posted. You can try it out by dragging any image around a webpage, it will cause the same effect.
There is nothing you can do about this.


Fix/enable autoscaling

Github completely lost it on a weird manual merge. Closing and fixing later, master will be fixed witgh @hrjn 's #12

Closing again as merge has no change.


DataArray.unstack() leaving dimensions 'in order'

It's documented that when you .unstack() a DataArray, "New dimensions will be added at the end."
I'm using .unstack() kind of like np.reshape(), to split one dimension into two. From this perspective, it's surprising that new dimensions go at the end, rather than in place of the old dimension. This also means that either the new array is no longer C-contiguous, or the .unstack() operation has had to copy all the data to rearrange it. It appears I'm not the only one to think this: the code sample in #2419 (about adding a reshape method) does the same workaround that I do: unstack and then carefully reorder the dimensions.
First, I'd like to understand: why the end? It seems like there's an obvious place to put unstacked dimensions (ab, c -> a, b, c), but presumably there's some reason it doesn't work that way.
Then, is there anything one can do with xarray today to 'unstack' a dimension while keeping the order, short of using .transpose() afterwards to recreate the desired order? And if not, is there any potential to add a feature for that?
I guess this might touch on missing data: unstack() can create and handle 'gaps', whereas reshape() can't. If so, is there some more limited operation that could only unstack a perfectly regular multiindex - where it's guaranteed to separate into 2 dimensions without creating gaps?

Thanks for the issue @takluyver
I mostly think (others should weigh in) that we don't spend much effort on dimension order. (Would a dimension order change always be a regression?). That's mostly because of one of xarray's great strengths: you don't need to worry about the order, because you can reference dimensions by name.
I imagine that unstack dimension order wasn't carefully chosen to be at the end vs in place; and we'd take a PR to make that change.

Thanks, it makes sense that dimension order conceptually doesn't matter so much once they're labelled. Though I'd say that as Xarray has public APIs for accessing dimensions by position, changing how something like .unstack() orders them probably is a breaking change.
I'm providing an API for other people to access data as a DataArray, and I'd like to have the dimensions in the order that makes it C contiguous, as a hint about what kinds of operations will be efficient. I know some users also go 'what is this complicated thing?' and extract the numpy array from it, in which case the order is more important.
So another option that would work for me would be a separate method that rearranges the dimensions to the order that makes the array C contiguous.

This also means that either the new array is no longer C-contiguous, or the .unstack() operation has had to copy all the data to rearrange it.

The former. As a core design principle, xarray does not care about dimensions order, and any user code that implicitly relies on it should be considered a bad design.
The .transpose() method mostly only exists for when people need to access the numpy .data object directly with a numpy function.

So I'm understanding correctly: does numpy's behavior even satisfy your reqs? https://docs.scipy.org/doc/numpy/reference/generated/numpy.swapaxes.html

then a view of a is returned

i.e. the array's underlying layout doesn't change, only the view...

@max-sixty - I certainly want to avoid copying the data unless it's necessary. But I'd like to present the axes in the 'real' memory order, from the largest stride to the smallest.
I appreciate that it shouldn't matter for program logic, but it can definitely matter for performance, and I know some users are going to use axes by position rather than by name, so I do consider it an important part of the API.

I think I see your point @takluyver — that by returning the new axes at the end it's both surprising and no longer a contiguous array.
But then +1 re your final point about unstack being unable to return a view on missing data.
I don't think it's impossible to carefully manage the dimensions order & contiguous-ness in this case. It may take someone who can champion it, though

If it's easier, a method for "transpose these dimensions to the order which makes the data contiguous" would meet my needs.
I'm happy in principle to work on either feature, but when I've looked into contributing to xarray before, I've been a bit overwhelmed by complexity - I think I'm currently using a pretty small fragment of what it can do.

I think it should be pretty reasonable to do that in a few lines, for numpy-backed arrays at least! Get the underlying numpy array, sort the .strides to get the memory order, map to dimension names, and pass them to transpose?

This sounds useful to me


ticdc lag reached 5min when run ha_pdleader_time_offset last for 10m

What did you do?
http://perf.pingcap.net:3000/d/C1q8KDMVz/ha-test-summary?orgId=1&var-tag=All&var-case_name=All&var-testbed=endless-ha-test-tps-1658429-1-754
http://perf.pingcap.net:3000/d/WOw1JWmVk/ha-test-case-detail?orgId=1&refresh=10s&var-case_id=2610638
run ha_pdleader_time_offset last for 10m
What did you expect to see?
No response
What did you see instead?

Versions of the cluster
git hash
92cc5155c8224ae787898379016e1a7dfc4649b7
current status of DM cluster (execute query-status <task-name> in dmctl)
No response

/remove-area dm
/area ticdc

/assign overvenus

/severity major

/unassign @overvenus
/assign @asddongmen

The time drift of the PD affects TiCDC's checkpoint lag calculation. However, this only results in a metric calculation error and does not impact the actual replication progress. @Lily2025

I think we can close this issue per the comment above.

lgtm

/remove-label affects-7.1


Update examples that are linked to

(This plugin is great and I'm looking forward to using it!)
Examples such as the borders are slightly out of sync with the examples in master and the docs. This is slightly confusing because I often view-source on examples.

These have been updated


TLS 1.3 not supported due to old libssl

I cannot enable TLSv1.3 on my server, because the version of libssl is 1.1.0f, and 1.1.1 or newer is required for TLSv1.3 support. A quick search of the Debian Package site indicates that they only support libssl1.1.1 on "sid" right now. I'm not sure if you want to compile libssl and include it yourself, or how to you want to handle it, but it would be great to have full TLSv1.3 support in the Docker image.
Thanks for all the hard work you do. It's really appreciated.

Yeah we don't really want to also compile openssl from source, so we'll have to wait until it can be installed in a stable distribution of Debian.

FWIW OpenSSL 1.1.1 is now included in Debian Buster, which should be released in the first half of 2019. I'm running a version of your Dockerfile based on debian:buster-slim and TLS 1.3 and 1.2 are working fine.

This will be fixed in #124


[ZEPPELIN-5629] spark.driver.extraJavaOptions setting in %spark.conf does not work well

What is this PR for?
The value of spark.driver.extraJavaOptions setting in %spark.conf will override the its initial value provided by zeppelin. It should append instead of override.
This PR fix this bug.
What type of PR is it?
[Bug Fix]
Todos

[ ] - Task

What is the Jira issue?

Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-5629

How should this be tested?

CI passed

Screenshots (if appropriate)
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

@huage1994 Could you rebase to the lastest master?

@huage1994 Could you rebase to the lastest master?

Yeah sure


merge from template-arlac77-github

.github/workflows/update_package_lock.yml

chore: add chrome remove chromium (jobs.update_package_lock.strategy.matrix.browser)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.206%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
109

Relevant Lines:
109

💛  - Coveralls


[iOS][Idea] Add dynamic tab animation in timeline screen.

Idea Description
In iOS app, the date selection doesn't displayed in the header View element was accompanied by an animation.
I think it would be better to add an animation when selecting a date like the Android app.
Reference images and links

@RyuNen344 @takahirom
Would you mind if I closed this issue?

@fumiyasac
yes, please 🙏


Added ToChar function

I added a ToChar() function. Amongst other uses, this is needed to extract strings from datetime objects.

Coverage increased (+0.006%) to 98.321% when pulling a7faa920ad6c580a506908c1aed7973725fa4701 on add_to_char_function into b217a7a343ab4250c05cdbbe7c0cf7e4995d3c4a on master.


felix/bpf: include RPF and wg chains again.

Since commit
https://github.com/projectcalico/calico/commit/cabb7c129bd476e9fc339bd02d285e457ed2993f
the prerouting raw chain does not include the RPF and wg chains as those
are removed by the chains generated by StaticBPFModeRawChains(). Hence
we do not enforce RPF when RPF is disabled or set to lose.
Description

Related issues/PRs

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

None required

@neiljerram I force-pushed as it is a complete rework. Also includes a test that works for any dp.


Could you be a solution to this Tailscale issue?

Hi @almeidapaulopt
Just found TSDProxy featured in Tailscale's newsletter. I was wondering: am I misunderstanding something, or is TSDproxy exactly what's needed as a workaround for Tailscale's feature request https://github.com/tailscale/tailscale/issues/1543 ? That issue has nearly 600 reactions on it, so I think you might be helpinga lot of people if you confirm TSDproxy can do the trick :)

Hi @almeidapaulopt
Just found TSDProxy featured in Tailscale's newsletter. I was wondering: am I misunderstanding something, or is TSDproxy exactly what's needed as a workaround for Tailscale's feature request https://github.com/tailscale/tailscale/issues/1543 ? That issue has nearly 600 reactions on it, so I think you might be helpinga lot of people if you confirm TSDproxy can do the trick :)

Right now it just uses the TailScale TLS a DNS so No. But, without a deep analysis, it seems possible to do it. A lot of work, but it can be done.


Add click package to cuvs-bench conda recipe

This package is available in dependencies.yaml, but due to an oversight was not added to conda metas.

@jameslamb fully agree with your comment, adding tests is in the backlog and something I've wanted to get to as bandwidth permits. I even added unit code pytests, but haven't had time to fully check them and enable them, it something we plan to do as soon as we can alongside as benchmarks like you suggest in a follow up :)

@jameslamb we have a test suite that we'll be focussing on getting ready this release https://github.com/rapidsai/cuvs/tree/branch-24.12/python/cuvs_bench/cuvs_bench/tests. Until then, if it's okay with you, let's merge this PR.

if it's okay with you, let's merge this PR.

Yeah totally fine.

we have a test suite that we'll be focussing on getting ready this release

Sure, I understand. I think it'd be worth adding something lightweight like the test_version.py I mentioned in https://github.com/rapidsai/cuvs/pull/408#pullrequestreview-2373821599 sooner (instead of waiting to add the full test suite you want). Having some minimal validation that the conda packages are at least installable and importable would be useful.
You're not getting that kind of coverage from conda mambabuild because all the conda builds here are done with --no-tests.
https://github.com/rapidsai/cuvs/blob/f62b217f97c9e14b340f11bcbfe556fcad9ed816/ci/build_python.sh#L35-L39

@jameslamb yes, appreciate your suggestion here. I can do a quick follow on to add the minimal test and that will act as a placeholder in CI until the full test suite is ready.

/merge


cmd ref: get and import are getting confusing

WARNING: RANTish
#912 will soon merge the updates to the behavior of dvc get and dvc import, which now completely support dealing with regular Git repos (no DVC involved at all).
I forget what was the reason to implement that on the core repo but I'm sure there were good motives, however, it's made them confusing or at least difficult to explain.
We should probably revisit the command references again and explain again:

Focus mostly on the DVC-related features and
only note somewhere about regular Git repo support.

This way we'll avoid confusing phrases and paragraphs like  `url` (location which can be a path) and `path` (also location) (both HTTPS or SSH supported) to DVC project (which can be a DVC repo, which is a Git repo) or Git repo (we mean a plain repo without DVC inside) ... – exagerated.

I don't know how it can be confusing, tbh. It's as simple as - it can download any file or directory from any Git or DVC repo. I think we are just overcomplicating and overthinking this. Just think about the essence of what it does first, would people who read this understand this, being precise and consistent - third.
Btw, ironically, it was initiated by the ticket you created (after the discussion in the dvc list ticket) :).


Dockerized the application by creating Dockerfile and updated the readme

Related Issue

Dockerized the project.

Closes: #409
Describe the changes you've made
I have updated this project to run in docker.

Added a dockerfile to dockerize the project.
Have taken all the best practises to run this project in docker.
Updated the readme for how to run this using docker.

Mention any unusual behaviour of your code (Write NA if not)
NA

Checklist:

[ x] My code follows the guidelines of this project.
[x ] I have performed a self-review of my own code.
[x ] I have commented my code, particularly wherever it was hard to understand.
[ x] My changes generate no new warnings.
[ ] Any dependent changes have been merged and published in downstream modules.

Okkh ill add it right now

I have updated the readme with the images of project running in my system.