add iterget function/generator

this is useful if you want to retrieve a very large number of notes/references/invitations/groups but don't want to make all the network calls upfront or store them in memory.
(it's been useful to me as I've been working with the DBLP data)
This should make the _get_all() function sort of useless. If you like this change we can remove that function.

So, let's remove _get_all

@melisabok @mohituniyal I added a test, but I'm not sure if I'm setting it up correctly. Maybe we can discuss at our meeting?

@melisabok @mohituniyal is this ok to merge?


Wrong bootstrap button usage in challenge.

Challenge Name

https://www.freecodecamp.org/challenges/create-a-bootstrap-button
Issue Description

The button doesn't render in chrome. In Firefox and Safari a grey area appears, but it doesn't seem to be an actual bootstrap button (see screenshots). A default button is created by adding the classes btn and btn-default to the button element. Usage according to the documentation http://bootstrapdocs.com/v3.3.1/docs/css/#buttons:
<!-- Standard button -->
<button type="button" class="btn btn-default">Default</button>

Browser Information

Browser Name, Version: Chrome 66.0.3359.117
Operating System: MacOS 10.13.2
Mobile, Desktop, or Tablet: Desktop

Your Code

imho wrong:

<button class="btn">Like</button>

Screenshot

the button isn't visible in chrome:

there is a buttonlike gray area rendered in Firefox, but it doesn't have a style which is documented in the bootstrap documentation:

Valid bootstrap (v3.3.1) buttons:

You have right, it seems that there is a second class missed, which gives the button proper colors. I've also found it as strange when walked through the course but left it without a word. However, even the mistaken one renders good in Chrome 66.0.3359.117 64-bit one ran on Windows 10.

Everything is fine in my Chrome
Version 59.0.3071.115 (Official Build) (64-bit)
Win10

The rendering issue with chrome is seemingly macOS only.


[M4] Initiate peer review

Review initiated here: https://github.com/UBC-MDS/software-review-2023/issues/31


Changes in 0.5

With #78 there were some name changes:

IntersectionDomain -> IntersectDomain
DifferenceDomain -> SetdiffDomain

There are three trio's of functions:

union, uniondomain and UnionDomain
setdiff, setdiffdomain and SetdiffDomain
intersect, intersectdomain and IntersectDomain

The idea is similar in all three cases. The union function is the generic Julia function that is invoked with the cup symbol. If one of the arguments is a Domain, then uniondomain is invoked. The latter can also be invoked directly: the difference is that uniondomain treats all its arguments as if they are domains, even if they are not <:Domain. So this allows you to create the union of an interval and a vector, for example. Finally, UnionDomain always returns a UnionDomain type, whereas uniondomain may do some simplifications and return something else (that is functionally equivalent to the actual union).
For intervals, uniondomain differes from union, with the latter following IntervalSets (which throws error if two intervals do not overlap) and uniondomain always returning something that represents the union.
This makes uniondomain, intersectdomain and setdiffdomain potentially type-unstable (this is unavoidable and was already the case with set operations). For type-stability, use UnionDomain.

interval_map(a,b,c,d) is no longer exported. A new mapto function is in the works which is more general: mapto(a..b, c..d) returns a map from a..b to c..d. The idea is that this will work for many other domains as well. It works by associating domains with a canonicaldomain, which allows automatic discovery of maps between many more domains than you explicitly program (for example from any interval a..b to a circle). Needs some more work, though.

There is now a special type for rectangles and cubes. The ProductDomain and ProductDomain{T} constructors now recognize when a list of intervals is given and they return a more specialized type. Boxes are simple and relevant enough to support better, I thought. I find working with abstract constructors very convenient for that purpose. Most functionality is implemented at the abstract level, so extending is very easy, and it is always the case that the result is <:ProductDomain.

There is a UnitCube (a product of UnitInterval), but also [-1,1]^d has its own stateless type now, as do all the other fixed intervals:
const ChebyshevProductDomain{N,T} = FixedIntervalProduct{ChebyshevInterval{T},N,T}

I revised the hierarchy of unit balls, unit spheres and unit simplices. Again, an abstract constructor: UnitBall(Val(3)) and UnitBall(3) replace the previous EuclideanUnitBall (now just an alias) and VectorUnitBall (again just an alias).

The in and approx_in functions are now implemented using promotion. It is functionally the same as before, but cleaner, and it allows concrete domains to intervene when necessary (for example by being more flexible in membership, or more strict).

I probably left out a few things. I could not get deprecations to work correctly and I simply left them out... We are going from 0.4 to 0.5 series so that is probably fine.

I had packages downstream relying on the changes so I released v0.5... Hopefully it will be straightforward to update ApproxFun @dlfivefifty. It should be fine, except for having to import components and ncomponents from DomainSets (or from CompositeTypes) now.

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/36088
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.5.1 -m "<description of version>" fe5cb0a8ca754859702d78962216144c440a4d62
git push origin v0.5.1

Update: I've changed the canonical domain of an interval to be [-1,1] rather than [0,1]. This will be in 0.5.3.

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/44774
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.5.5 -m "<description of version>" 64984430e78c97f14294fb1378451ec3e8ffea53
git push origin v0.5.5


Problem with Export to XLS

Hi, how are you?
Sorry, but, i have the next error:

As you see, when i export to xls, i obtain a bad export, with chinese o japanese characters, any times don't get any characters, and other issues, but, when i export to cvs, all is good.
Japanese characters are in a datetime field, see the cvs field:

Nothing error, all is well.
Can you help me?

The problem appears to be three places where strings are incorrectly converted to Unicode by silently ignoring errors:
https://github.com/kennethreitz/tablib/blob/develop/tablib/formats/_xlsx.py#L140
https://github.com/kennethreitz/tablib/blob/develop/tablib/formats/_xlsx.py#L145
https://github.com/kennethreitz/tablib/blob/develop/tablib/formats/_xlsx.py#L148
I noticed this with some Arabic documents but it will apply to any character which is outside of US-ASCII.
In very casual testing, I fixed this by replacing the unicode() call with col.decode('utf-8'). That should probably be a function which does a type-check for incoming unicode/bytestring/everything else but it's probably worth looking into whether we can normalize bytestrings to unicode on the way in rather than having to special-case it in every encoder.

I can't seem to find a solution that doesn't require edits to tablib's source as @acdha mentioned.  Any plans to fix this?

@chris-allen, @SalahAdDin I don't know if this is still relevant but I stopped working on this due to other challenges, the most pressing one being the use a different XLSX library for performance reasons as our data export sizes increased. I just got permission to release that code over here — all it does is export data but it does work with Unicode text and uses xlsxwriter, which I found to be very CPU/memory-efficient: https://pypi.python.org/pypi/django-tabular-export

Do you recommend use the other package instead this package?

@SalahAdDin all I can say is that it worked for my project. tablib does a LOT more but I didn't need those extra features as much as I needed performance and Unicode support.

Is there any plan to fix this? I met an error when export to xls file, it looks well at first, but when you try to open the exported xls file, it says "Excel could not open xxx.xls because some content is unreadable. Do you want to open and repair this workbook?", after repair,  some cells is empty, I lost   some data. I'm not sure if it's related with the issue here.

JFYI, use the latest revision(master branch) with xlwt v1.2.0, everything works well, seems it fixed my issue.

Closing as fixed. If it's still a problem with the newest release, please leave a comment. Thanks!


mix css broken in hot

when declaring
<link href="{{ mix('/css/app.css') }}" rel="stylesheet" type="text/css" />
it doesn't work during "hot" developing

https://github.com/JeffreyWay/laravel-mix/issues/549 Fixed it for me.
 .webpackConfig({
    devServer: {
      contentBase: 'public'
    },

Well... there is similar declaration in the app I'm working, and it works:
<link href="{{ mix('css/app.css') }}" rel="stylesheet" type="text/css" />

Just try removing the leading / - maybe this is the cause of the issue.

I'm having the same issue as well
Attempting to access the file gives me 404. This happens when I'm doing less and css compile at the same time.
const { mix } = require('laravel-mix');

mix
  .less('resources/assets/less/main.less', 'public/css')
  .js([
    'resources/assets/js/app.js'
  ], 'public/js/app.js')
  .options({
    processCssUrls: false
  })

mix.styles([
    'resources/assets/fonts/nucleo-webfonts/mini/css/nucleo-mini.css',
    'resources/assets/fonts/nucleo-webfonts/glyph/css/nucleo-glyph.css',
    'resources/assets/fonts/nucleo-webfonts/outline/css/nucleo-outline.css',
    'public/css/main.css'
], 'public/css/all.css')

if (mix.config.inProduction) {
  mix.version()
}

While the http://localhost:8000/css/main.css works the http://localhost:8000/css/all.css doesn't.
Is there anything to debug this hot server? I'm not well versed using webpack

For mixing styles, it's best to use npm run watch with mix.browserSync().


Access database support by odbc driver

Just like mssql support

Good! Where can I find a demo code?

This does not be implemented yet.


Subfolder

Hi, i tried nginx proxy_pass, rewrite, modifying the source and webpacking it back; nothing got it to work in a subfolder in reverse proxy.
Anyone got a working example ?

Hi, I'm also having some trouble with this.
Just to be sure, what do you mean with not working? I can get the webpage to appear with the following nginx config (I'm not totally comfortable with nginx so there may be some stuff missing/ wrong, just fyi, last two lines are intentional to only allow local network):
location /ytdl/ {
    proxy_set_header Host $host;
    proxy_set_header X-Forwarded-Proto $scheme;
    proxy_pass http://localhost:3000;

    allow <IP_ADDRESS>/24;
    deny all;
}

I enter a link to download and it seems to start but it hangs forever...
Just wanted to know if this was the same behaviour you were seeing.
Will try to investigate further to get some debug info if I find the time (+ I would have to dive in javascript as well :)...).


getdownloadlinks method issue

It unable to find links for videos released more than two years ago
please fix it
thank you for your lib 🌺

Probably a duplicate of #109. Please leave a comment there.


[windows UI] channel status selector is getting cut off

windows 10 64 bit
the box for displaying / choosing  "All / online / pending / closing"  is to small and gets cut off.

@justsomedude4242 Could you update to the last version and check if the problem is solved

Should be resolved in master. Closing this


Node to node encryption

As a user, I need all my node traffic to be sent encrypted in order to safeguard my privacy.
Currently, we have a single way to receive / exchange data: HTTP REST queries.
In the future, we want to move to a binary protocol, but should still be using SSL to transmit data.
Some method might still be exposed via REST and it should be over HTTPS.

Probably based on the validator's key and https://libsodium.gitbook.io/doc/key_exchange
See #1897

would it be possible to have some of the enpoints configured as not encrypted? For example the crawler in #251 could be implemented in a much simpler/more efficient way if we had no encription on the FullNode.getNetworkInfo method

It probably needs to be its own interface then.


Minor SDN updates

@dansisson @sethmanheim
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Cart JS calls unnecessarily complex

When modal cart actions are performed the Javascript makes multiple server calls.
Separate requests to /getTotalItems and /getTotal could be combined easily.
Ultimately there should only be one server side call needed per cart action.

Addressed by https://github.com/concrete5-community-store/community_store/commit/116920696121ec34ff73aaa464fe08d01751dedf


fix-issue-286

Q
A

Bug fix?
yes

New feature?
no

BC breaks?
no

Deprecations?
no

Has tests?
no

Fixed tickets
#286

follow up to #291 - still had the issue in a CI run, since a closure was set, but that closure returned null on CLI runs

again, this is only relevant for 1.0, since the BC break is ok for 2.*

thx


[STM32F3xx] bug fix multiple ADC channels using multiple ADC blocks

When two or more analogue inputs are initialized on more than one ADC HW block the initialisation fails with:
Cannot initialize ADC
The reason is the reusage of just one ADC_HandleTypeDef for all initializations (in mbed\targets\hal\TARGET_STM\TARGET_STM32F3\analogin_api.c). After the first (successful) ADC initialisation AdcHandle.State is set to HAL_ADC_STATE_READY).
But for the next ADC block initialisation the AdcHandle.State has to be reset so that the HAL initializes it (in mbed\targets\cmsis\TARGET_STM\TARGET_STM32F3\stm32f3xx_hal_adc_ex.c line 424). When this state is not reset the HAL returns with an initialization error. And this error induces the above mbed error message.
The error message can be reproduced just with AnalogIn in1(xx); AnalogIn in2(yy); where xx and yy belongs to two different ADC blocks.

@bcostm @adustm

Bump for review

I didn't check it but it looks ok to me. Another solution would be to create a table of AdcHandle variables as already done with the STM32F4 Serial api.


cancelling a mapSeries should stop processing of the iterable

Bluebird v3.5.0
Node v8.1.2

Cancelling a mapSeries promise does not stop processing of the iterable if processing is in between one of the functions in the iterable.
The mapSeries only stops processing if one of the promises was pending that the time of the cancel.
let Promise = require('bluebird')
Promise.config({cancellation:true})

let func = function funcFunc(i){
  console.log('running func',i)
  return i
}

let prom = function prom(i){
  return new Promise((resolve,reject,onCancel)=>{
    console.log('runing promise 2 sec delay',i)
    let timer = setTimeout(function(){
      resolve('promise done')
    },2000)
    onCancel(()=>{
      console.log('onCancel',i)
      clearTimeout(timer)
    })
  })
}

let prom2 = prom
let prom3 = prom

let queue = [prom,prom2,prom3]

let series = Promise.mapSeries(queue,(func,i,l)=>{
    return func(i)
  }).then(function(done){
    console.log('then done',done)
  }).catch(function(e){
    console.log('catch',e)
  }).finally(function(){
    console.log('finally')
  })

setTimeout(function(){
  console.log('canceling...this does not stop propgation of the mapSeries...prom2 and prom3 are still called')
  series.cancel()
},2000)

Make sure cancellation is turned on: http://bluebirdjs.com/docs/api/promise.config.html


How do you import files programmatically?

Im looking at the cloud functions example and this is not going to work for me: https://github.com/GoogleCloudPlatform/deploymentmanager-samples/blob/master/examples/v2/cloud_functions/python/cloud_function.yaml#L4
I cant force user to have to manually define EVERY file their function needs like this with explicit imports. I also want to use deployment manager to deploy multiple functions in a single stack which exacerbates this problem
How do you dynamically/programmatically import files? So I can just say all files under this folder? Or programmatically import files inside of the cloud_function.py script?

This is the feature you are looking for:
https://cloud.google.com/sdk/docs/release-notes#cloud_deployment_manager
Turn on the glob imports flag:
gcloud config set deployment_manager/glob_imports True
Then use glob style imports in your yaml or schema files:
imports:
- path: templates/simple_frontend.py
  name: simple_frontend.py

# Helper classes
- path: helper/*.py

# Configuration files
- path: configs/*.yaml
- path: configs/*/*.yaml

You can see it in action here:
https://github.com/GoogleCloudPlatform/deploymentmanager-samples/tree/master/community/hierarchical_configuration/Basic
and here:
https://cloud.google.com/deployment-manager/docs/at-scale
On an other note, please take a look at the CFT Cloud Functions template.

@ocsig yup thats what i wanted thanks!


validating params with multiple values and displaying them in the UI

Issue
I have two related issues connected with describing params in the Joi schema that may have multiple values. For example, how do describe name as in the query string ?name=Glenn&name=Rob&name=punkish&version=2 so that it

validates, and
displays in the Hapi-Swaggered docs interface as multiple select input field like so

┌───────────────┬─┐
│     Glenn     │ │
├───────────────┤ │
│    punkish    │ │
├───────────────┤ │
│     Mike      │ │
├───────────────┤ │
│      Rob      │ │
└───────────────┴─┘

To be clear, it doesn't have to be a multi-select box. It can also be a list of checkboxes. As long as the user is able to select multiple values for that param, it would be fine
update: I am able to get partway to my destination with the following declaration
const schema = {
    names: {
        query: Joi.object({
            name: Joi.string()
                .description('Names of folks')
                .valid('Glenn', 'punkish', 'Mike', 'Rob')
                .default('Glenn')
        })
    }
}

The above validates, but creates only a single select box in the Swagger interface. Interestingly, I can't do the following
const names = ['Glenn', 'punkish', 'Mike', 'Rob'];
const schema = {
    names: {
        query: Joi.object({
            name: Joi.string()
                .description('Names of folks')
                .valid(names)
                .default(names[0)
        })
    }
}

Seems like Joi has changed (I could swear I used to be able to do the above) and now I have also tried Joi.array().items() to no avail.
Environment
Hapi-Swagger 11.0.1
Hapi 18.4.0
Joi 16.1.8

running into a similar problem -- I've been using the following joi schema to validate query params with multiple values but like @punkish described, this only shows up as a single select:
Joi.alternatives(Joi.string()).try(, Joi.array().items(Joi.string()))

I def won't have time to look into this but hopefully someone takes the charge via PR.


fix: restore function args correctly

What this PR does: bug fix, restore function args correctly
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Codecov Report

Merging #69 (5ac1996) into master (0555257) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master      #69   +/-   ##
=======================================
  Coverage   21.97%   21.97%
=======================================
  Files          44       44
  Lines        8173     8173
=======================================
  Hits         1796     1796
  Misses       6121     6121
  Partials      256      256

Impacted Files
Coverage Δ

pkg/runtime/xxast/ast_function.go
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0555257...5ac1996. Read the comment docs.


errors: As can loop endlessly

Preface: I don't think this behavior is necessarily dangerous, nor am I really sure it needs to be fixed, but wanted to hear others thoughts on it.
errors.As can enter an infinite loop if the error chain it is unwrapping contains a loop (here is an incredibly obvious example, the same thing would happen if loopErr self-referenced). While my example is quite obviously a "user did something silly" issue, the longer and more complex an error chain becomes the higher the likelihood something like this could happen and cause errors.As to sit in a tight loop when the caller tries to unwind it. Since errors.As isn't using recursion it won't cause a stack overflow and the only indication of an issue will be that the program appears to just halt.
I think in an ideal world errors.As would prevent this from happening. Obviously doing full on loop detection is a bit overkill for a relatively simple stdlib function, but adding a panic when the inner for loop exceeds some maximum number of iterations (i.e. 1000, likely to be significantly larger than any real world error chain) would at least let the user know there is something bad happening.

I don't think the stdlib should be placing arbitrary limits on unwrapping errors

Test should be able to detect that there is a bad loop and time out. At which point the code causing the loop will be detected and can be fixed by the programmer.
If we put a limit on the depth it will be too low for some and to large (oom before reaching the limit) for others. An existing case similar to the problem is that fmt Stringer can get into an infinite recursion too.

This is a dup of https://github.com/golang/go/issues/34957, where I closed it saying

cycle detection should not be the responsibility of the errors package. On further thought, it makes sense to see how these functions are used in the wild before preemptively documenting its behavior.

Ah! Not sure how I missed that during my search. It sounds like there haven't been huge numbers of people hitting this issue since your issue, so documentation is probably not hugely necessary, but it does sound like it could perhaps save someone a headache if they hit this in a hypothetical feature... Either way not opposed to just closing this out if everyone is ambivalent.

I'll close this as a duplicate of #34957, but please feel free to continue discussion there, or let me know if I am mistaken.


Registry key path in 'Registering Filter Handlers' doc seems incorrect

Link to article:
https://docs.microsoft.com/en-us/windows/desktop/search/-search-ifilter-registering-filters
(This document doesn't have a comments section or a way to edit the text and submit a PR for it)
Problem:
The second and third code blocks indicate that the CLSID subkey should fall under the .txt subkey, but this seems incorrect. I can't find any examples of this in the registry on my machine, and the example code associated with this documentation has the CLSID subkey at the same level as the .txt subkey: https://github.com/microsoft/Windows-classic-samples/blob/master/Samples/Win7Samples/winui/WindowsSearch/IFilterSample/Dll.cpp#L196 .
It seems like the fix would be to remove the .txt line from both code blocks and adjust the indentation accordingly.

Also, it looks like {89BCB740-6119-101A-BCB7-00DD010655AF}l should be replaced with {89BCB740-6119-101A-BCB7-00DD010655AF} on that page (in other words, the trailing l deleted)

Also, under step 3 in the section titled "Finding a Filter Handler for a Given File Extension", the diagram appears to be missing the PersistentAddinsRegistered subkey in the path.

@GrantMeStrength Can you please take a look at this issue?

Investigating.


Add formatter and CI formatting check

Closes #56
Reformats the project using the RFC style formatter. Specifies the formatter package in the flake. Adds a check to CI on pull request that fails if nix files are not properly formatted.

Cool! Some quick ideas, I am on my phone right now so can't do a proper review yet:

add a .git-blame-ignore-revs file (obviously that has to be done in a second commit)
maybe add instructions about formatting to the README? I don't think we have a "contributing" section yet but maybe we should...

 When I nix fmt I get this warning:

Passing directories or non-Nix files (such as ".") is deprecated and will be unsupported soon, please use https://treefmt.com/ instead, e.g. via https://github.com/numtide/treefmt-nix

See: https://github.com/NixOS/nixfmt/issues/151
So we either have to depend on https://github.com/numtide/treefmt-nix (not a fan of adding a flake dependency for such a trivial thing), or roll our own with something like find -name '*.nix' or git ls-files -- '*.nix'.

To be honest, you would probably be better off using a more stable formatter like alejandra or nixpkgs-fmt. The readme for the rfc formatter indicates it is still extremely unstable software.

What about something like this for formatting/checking all files? This should handle both tracked and untracked files, and also respect .gitignore:
git ls-files --cached --others --exclude-standard -z -- '*.nix' | xargs -0 nixfmt

Regarding nixfmt, I fear that it's in the "technically experimental but all other reasonable options are already deprecated" territory, same as flakes. They are already reformatting huge swaths of nixpkgs with it, look at this PR from 5 days ago (+706,935 -433,885): https://github.com/NixOS/nixpkgs/pull/322537
If it's good enough for nixpkgs, I don't see why it would not be good enough for us.

What about something like this for formatting/checking all files? This should handle both tracked and untracked files, and also respect .gitignore:
git ls-files --cached --others --exclude-standard -z -- '*.nix' | xargs -0 nixfmt

Regarding nixfmt, I fear that it's in the "technically experimental but all other reasonable options are already deprecated" territory, same as flakes. They are already reformatting huge swaths of nixpkgs with it, look at this PR from 5 days ago (+706,935 -433,885): NixOS/nixpkgs#322537 If it's good enough for nixpkgs, I don't see why it would not be good enough for us.

I suppose something like that would work just fine. For now it seems this is only a warning, so maybe it's not worth worrying over?

Also .git-blame-ignore-revs might be problematic, because it will also ignore relevant changes from the reformat commit like the ci.yml or the formatter definition... maybe we should split it into two commits, the first just adds the formatter and CI but does not change anything else, and then the next one is just a pure reformat commit.

Hey, (a) nixfmt maintainer here! We very intentionally deprecated that recursive mode, because the details get tricky, but it's all behavior generic for all formatters, making it perfect for treefmt. This includes:

Specifying the files to format, in particular also avoiding "files" like .git/logs/refs/remotes/foo/bar.nix.
Formatting files efficiently in parallel.
Avoiding formatting of files that don't need it (using a cache).

If you want to see treefmt-nix in practice, you can check out the config in nixfmt itself. The definition of nixfmtEval is here, then you can build treefmtEval.config.build.check source to get something that fails in CI with a good error and add treefmtEval.config.build.wrapper to the development shell to get a locally runnable treefmt command.
Anyways, totally up to you how you want to handle it, but feel free to let us know of any problems or suggestions for improvement in the nixfmt issue tracker :)
Oh and you can consider nixfmt stable, we plan to make the 1.0 release very soon, the formatting should only change in minor ways going forward.

@infinisil wow, definitely did not expect you to comment here, thank you for chiming in :) It's good to hear that nixfmt will be "officially" stabilized soon.
Yeah, fine, I did check out treefmt and treefmt-nix since you are recommending it. I read through some of the code in both, my only nitpick is that the flake example in the treefmt-nix readme is broken. (treefmtEval is an attrset of systems but the code is trying to refer to its config attribute.) Other than this both projects seem reasonable, I did not find anything objectionable.
(xargs does apparently have a parallel option, so my one-liner would only be missing caching from the features you listed if I used that.) But I do get the value proposition of treefmt and treefmt-nix now, and in fact they seem like something I might want to use in future projects with more complex formatting requirements using multiple formatters.
And at that point I might as well start using it here already. Getting some experience with it and learning any of its quirks on a simpler project is probably more valuable than avoiding the extra dependency in favor of the one-liner that technically would also work in this particular scenario.
I updated the PR to use treefmt-nix.


Curious behavior with grant_on_alls: it keeps adding new resources

I am using titan-core==0.8.9
As per title, I am observing a weird behavior any time I run my plan and apply for a yaml that include the grant_on_alls block. The behavior is the following:

I create the grants included in the grant_on_alls block using an apply command
I run a plan command on the same yaml file and the same resources (grants in this cases) are scheduled for creation

Here's the file:
roles:
  - name: data_engineer_internal_role
    comment:  "Role dedicated to data engineers in the data team"

role_grants:
  - role: data_engineer_internal_role
    to_role: accountadmin

grants:
  # Grant USAGE on databases
  - to_role: data_engineer_internal_role
    priv: USAGE
    on_database: TEST
  - to_role: data_engineer_internal_role
    priv: USAGE
    on_warehouse: DEV_TESTS

grant_on_alls:
  # Grant USAGE on all schemas in each database
  - to: data_engineer_internal_role
    priv: USAGE
    on_all_schemas_in_database: TEST
  - to: data_engineer_internal_role
    priv: SELECT
    on_all_tables_in_schema: TEST.MY_SCHEMA

  # Grant SELECT on all existing tables in schema
  - to: data_engineer_internal_role
    priv: SELECT
    on_all_tables_in_schema: TEST.ALESSIO_TITAN_DEV

  # Grant SELECT on all existing view in schema
  - to: data_engineer_internal_role
    priv: SELECT
    on_all_views_in_schema: TEST.ALESSIO_TITAN_DEV

future_grants:
  # Grant USAGE  on future schema in the databases
  - to: data_engineer_internal_role
    priv: USAGE
    on_future_schemas_in_database: TEST

  # Grant SELECT on future tables in each schema
  - to: data_engineer_internal_role
    priv: SELECT
    on_future_tables_in_schema: TEST.MY_SCHEMA

And here the plan results:
python -m titan plan --config snowflake/rcdev/roles/data_engineer_internal_role.yml
[titan:SECURITYADMIN] >
        SELECT
            CURRENT_ACCOUNT_NAME() as account,
            CURRENT_ACCOUNT() as account_locator,
            CURRENT_USER() as user,
            CURRENT_ROLE() as role,
            CURRENT_AVAILABLE_ROLES() as available_roles,
            CURRENT_SECONDARY_ROLES() as secondary_roles,
            CURRENT_DATABASE() as database,
            CURRENT_SCHEMAS() as schemas,
            CURRENT_WAREHOUSE() as warehouse,
            CURRENT_VERSION() as version
            (1 rows, 0.21s)
[titan:SECURITYADMIN] > SHOW TAGS IN ACCOUNT    (err 2, 0.19s)
[titan:SECURITYADMIN] > SHOW GRANTS TO ROLE SECURITYADMIN    (10 rows, 0.22s)
[titan:SECURITYADMIN] > SHOW GRANTS TO ROLE PUBLIC    (0 rows, 0.27s)
[titan:SECURITYADMIN] > SHOW GRANTS TO ROLE SYSADMIN    (3 rows, 0.18s)
[titan:SECURITYADMIN] > SHOW GRANTS TO ROLE USERADMIN    (5 rows, 0.20s)
[titan:SECURITYADMIN] > SHOW ROLES IN ACCOUNT    (7 rows, 0.18s)
[titan:SECURITYADMIN] > SHOW FUTURE GRANTS TO ROLE DATA_ENGINEER_INTERNAL_ROLE    (2 rows, 0.18s)
[titan:SECURITYADMIN] > SHOW GRANTS OF ROLE DATA_ENGINEER_INTERNAL_ROLE    (1 rows, 0.73s)
[titan:SECURITYADMIN] > SHOW GRANTS TO ROLE DATA_ENGINEER_INTERNAL_ROLE    (11 rows, 0.24s)
[titan:SECURITYADMIN] > SHOW DATABASES IN ACCOUNT    (3 rows, 0.20s)
[titan:SECURITYADMIN] > SHOW PARAMETERS IN DATABASE TEST    (20 rows, 0.18s)
[titan:SECURITYADMIN] > SHOW SCHEMAS IN ACCOUNT    (24 rows, 0.35s)
[titan:SECURITYADMIN] > SHOW PARAMETERS IN SCHEMA TEST.MY_SCHEMA    (20 rows, 0.20s)
[titan:SECURITYADMIN] > SHOW WAREHOUSES IN ACCOUNT    (2 rows, 0.22s)
[titan:SECURITYADMIN] > SHOW PARAMETERS FOR WAREHOUSE DEV_TESTS    (3 rows, 0.22s)

» titan core
» Plan: 4 to add, 0 to change, 0 to transfer, 0 to destroy.

+ urn::XXXX:grant_on_all/DATA_ENGINEER_INTERNAL_ROLE?priv=USAGE&on=database/TEST.<SCHEMA> {
  + priv         = "USAGE"
  + on_type      = "SCHEMA"
  + in_type      = "DATABASE"
  + in_name      = "TEST"
  + to           = "DATA_ENGINEER_INTERNAL_ROLE"
  + grant_option = False
}

+ urn::XXXX:grant_on_all/DATA_ENGINEER_INTERNAL_ROLE?priv=SELECT&on=schema/TEST.ALESSIO_TITAN_DEV.<TABLE> {
  + priv         = "SELECT"
  + on_type      = "TABLE"
  + in_type      = "SCHEMA"
  + in_name      = "TEST.ALESSIO_TITAN_DEV"
  + to           = "DATA_ENGINEER_INTERNAL_ROLE"
  + grant_option = False
}

+ urn::XXXX:grant_on_all/DATA_ENGINEER_INTERNAL_ROLE?priv=SELECT&on=schema/TEST.ALESSIO_TITAN_DEV.<VIEW> {
  + priv         = "SELECT"
  + on_type      = "VIEW"
  + in_type      = "SCHEMA"
  + in_name      = "TEST.ALESSIO_TITAN_DEV"
  + to           = "DATA_ENGINEER_INTERNAL_ROLE"
  + grant_option = False
}

+ urn::XXXX:grant_on_all/DATA_ENGINEER_INTERNAL_ROLE?priv=SELECT&on=schema/TEST.MY_SCHEMA.<TABLE> {
  + priv         = "SELECT"
  + on_type      = "TABLE"
  + in_type      = "SCHEMA"
  + in_name      = "TEST.MY_SCHEMA"
  + to           = "DATA_ENGINEER_INTERNAL_ROLE"
  + grant_option = False
}

Once the plan is applied the grants are created. However, the next time you try to run a plan, titan brings up these 4 resources again for creation. Is this a wanted behavior? If yes, why?
Thanks,
Alessio

The GrantOnAll resource is currently designed to always run. I made this decision awhile back, I should be able to clean this up in an upcoming release.

Ok thanks for explaining @titan-teej.

The GrantOnAll resource is currently designed to always run. I made this decision awhile back, I should be able to clean this up in an upcoming release.

Hey @titan-teej, sorry for bringing this back to life. I work with Alessio at RevenueCat, and we have started using Titan to manage users, roles, and permissions. Fantastic work, by the way!
Our current Github Action takes around ~15 minutes to apply the plan, mainly because it constantly reapplies GRANT ALL statements.
Is it possible to skip the application of GRANT ALL statements with a flag? That would make our pipeline faster and less confusing (we expect a 0 changes plan after applying one).
If this feature is totally out of your roadmap in the short/mid-term, let us know, and we'll try to contribute.
Thanks again!


Page readahead

SQLite benefits from kernel readahead whereas we don't. Let's implement readahead in userspace.

@penberg  does implementing readahead  in the userspace means storing more than one page in the buffer pool? Could you point me to any reference where I can read about it or code to try to understand how this should be implemented?

I'll take a shot at this. We have more context to do page lookup in userspace than the kernel does, so we ideally should be able to do better here.


Update README.md

I ran into some trouble with a wonky error that Meteor.publish can only return certain values. Ultimately the fix was just poor quality coffeescript and I thought I'd save the next person a little time.

Ran into this problem myself some time ago. Although this message would be ok, I feel that being more obvious about that Counts.publish actually returns a handle would have been enough for me.
Meteor.publish('publication', function() {
  var handle = Counts.publish(this, 'name-of-counter', Posts.find());
  handle.stop();
});

Something like this by the information about the function returning a handle would have done it for me.


sd: install man page and shell completions

Motivation for this change
Add manual page and shell completions to sd pacakge.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 129214 at 055dc300 run on aarch64-linux 1

2 packages built successfully:

sd
slides


cmp - organize for editable install

This is a great project! I am currently working with PEER at UC Berkeley to develop a new optimized Python interface for OpenSees that eliminates some of the existing vulnerabilities to global state corruption. I've started working on integrating this new interface into your package, but first, I needed to move the files into a subdirectory of src in order to run a local editable install with pip. Do you have a different installation method that would work for editable installs? If not, this pull request may ease future collaborations.
The changes are:

move everything under src/ to a subdirectory named src/planesections/
add a minimal pyproject.toml file to allow editable install (pip install -e .)

Hey, thanks for your PR! I'm really interested to see what changes are coming down the pipeline with the OpenSees interface!
I tried to make a system that allowed users to get type-hints and docstrings for opensees functions, but gave up on it..
To answer your question, I haven't used editable installs before, but I don't see any issue with implementing these changes.
I do want to do a bit of research before pulling anything into the main package - once I do that I'll follow up with any other changes I think should happen.

Thanks for considering the change! Take your time looking into it, and let me know if you have any better ideas! I'm just looking for a way to install locally.
In case it helps, this is a nice resource for laying out Python packages: https://packaging.python.org/en/latest/discussions/src-layout-vs-flat-layout/

Hey, made a few changes to the pyproject.toml to match my old setup.py. After review, this works more easily than what I've been doing - in the next few days I'm going to confirm I can successfully upload to pypi under the new scheme then merge this in. Thanks for the suggestion!

Hey @claudioperez, I've confirmed I can still upload to PYPI with this setup, and am satisfied nothing is broken. This should be ready to merge, can you confirm everything is good on your end before I make the jump?

Yeah, everything looks great!


Allow hardware keys as a second factor, + eslint

feat: template and client-side changes in preparation for u2f token setup, eslinted lib/controllers
fix: some text copy and styling
style: eslint library.js
feat: u2f integration

Remaining tasks to :100::

[ ] Test NFC use of the key, mobile testing
[ ] Error handling on registration and signing
[ ] Best practice handling of key counter when signed, deny when counter lower than expected

It looks like NFC won't work unless I switch from U2F to Webauthn :disappointed:

Tested and working against https://community.nodebb.org

Sponsored by @ylothar and keeb.it


In next.js I get "ReferenceError: window is not defined" when i run dev or build

⨯ ..\node_modules\react-ios-pwa-prompt-ts\dist\react-ios-pwa-prompt-ts.js (1879:58) @ window
⨯ Internal error: ReferenceError: window is not defined
at Qi (../../../../node_modules/react-ios-pwa-prompt-ts/dist/react-ios-pwa-prompt-ts.js:4093:106)

This library requires use of the browser.
I'm not super familiar with next.js, but are you using a client side component?

Following up on some data based on the following article and thread lead me to believe this is an issue of using context in next, being that your client component is being pre-rendered on the server.
I think this is not an issue with the component library provided here.
Feel free to comment and reopen this issue if it does end up being a problem with this libraries implementation!
Supporting info:
https://blog.sethcorker.com/question/how-to-solve-referenceerror-next-js-window-is-not-defined/
https://stackoverflow.com/a/75692565


Improved Readability of ReadMe

Improved Readability of ReadMe file , fixed the issue with images breaking the lines on multiple occurrences , add the bold tag where necessary and improved the spacing.
Case #19

Hey, looks good!


feat: support reading/writing a wallet mnemonic from the mobile app [WIP]

Description
This branch is to support testing two way communication between the mobile app and the web app. This is not currently intended to be merged, but I'm making it a draft PR in case anyone wants to provide feedback early in the process.
Notice

[X] Have you followed the guidelines in our Contributing guide?
[X] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[X] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)
See https://github.com/shapeshift/mobile-app/issues/10 and https://github.com/orgs/shapeshift/projects/12/views/1
Risk
None, just don't merge it
Testing
If you don't know how, then don't worry about it.
Screenshots (if applicable)

as discussed if this gets you unblocked and is easy to remove later let's go ahead and get this in once those two small changes are made above
tested and verified no regressions in ephemeral environment


Clean up PVCs that are not owned by VRG but present in protected pvcs list

This helps in solving https://github.com/RamenDR/ramen/issues/1335

Needs envtests to the added. This section hase some tests around this functionality that either is not validating for the current behavior or does not test the same and may need modifications and addition appropriately.

pvcStatusDeleteIfPresent seems to be doing the same when invoked for a PVC that should no longer be protected. Can you check if that function is not doing the required operation correctly?
Also, instead of clearing the PVCs from the protectedPVCs list at the end of pvcsDeselectedUnprotect it would be easier to do it how (or what seems to be intended) per PVC that is unprotected in pvcStatusDeleteIfPresent

In function 'pvcsDeselectedUnprotect' , PVC list is retrieved by 'listPVCsOwnedByVrg' method. Can we consider PVCs not having owner labels for 'pvcsOwned' list here?  In the subsequent for loop, PVCs currently filtered out by recipe selector and still present in 'protectedPVC' list of vrg are cleaned up both from S3 store and vrg status as well.

pvcStatusDeleteIfPresent seems to be doing the same when invoked for a PVC that should no longer be protected. Can you check if that function is not doing the required operation correctly?
Also, instead of clearing the PVCs from the protectedPVCs list at the end of pvcsDeselectedUnprotect it would be easier to do it how (or what seems to be intended) per PVC that is unprotected in pvcStatusDeleteIfPresent

Responding to this after discussing with @Annaraya-Narasagond for PVCs that were not Bound they do not have the owner label, but are in the protectedPVCs list and hence need garbage collection.

@ShyamsundarR @Annaraya-Narasagond : In function 'pvcsDeselectedUnprotect' , PVC list is retrieved by 'listPVCsOwnedByVrg' method. Can we consider PVCs not having owner labels for 'pvcsOwned' list here? In the subsequent for loop, PVCs currently filtered out by recipe selector and still present in 'protectedPVC' list of vrg are cleaned up both from S3 store and vrg status as well.

This maybe an overkill as we would be listing and processing all PVCs in said namespace. It does resolve the issue, but increases the scope of processing that we can avoid.

Needs envtests to the added. This section hase some tests around this functionality that either is not validating for the current behavior or does not test the same and may need modifications and addition appropriately.

@asn1809 Assume envtests are still pending as part of this PR. Current changes LGTM!


Upgrade to v1.0.0-beta21

This might also fix #7 and #6

done in 0.5.1 / https://github.com/saltcorn/tabler/commit/b080cda7c5fe9bcb44293b8470e7fa4dc2e2bd14


bug: user reported error with transformers on --list-workload

java -jar nb.jar --list-workloads
1513 ERROR [main] ERRORHANDLER Error while getting workloads:Error while scanning path '/activities/baselinesv2/cql-tabular2.yaml':Error applying string transforms to input
1513 ERROR [main] ERRORHANDLER for the full stack trace, run with --show-stacktraces
Scenario stopped due to error. See logs for details.

A sanity check was added previously which invalided some existing workloads. This should have been done as a warning, but was implemented as an error instead. This check has been rolled back for now to restore functionality of --list-workloads and --list-scenarios


Architecture of valuenet

Do you check the correctness of the value network?
According to the code, hidden layers 2 to 12 are identical to that of policy network, rather than “2 to 11”, stated in the paper.

The paper is confusingly worded. They say "Hidden layers 2 to 11 are identical to the policy network, hidden layer 12 is an additional convolution layer..."
Thanks for looking at it carefully - let us know if you find anything else that is suspect :)

Do you train the value network using KGS dataset? Does the mse approach that described in the paper?
I've been training the value network. The mse of training set can quickly down to 0.1, but the mse of validation set remains 0.5~0.6.

Unfortunately we haven't tried training the value network yet.. We only recently got into the 45% range with supervised training accuracy.
The value network isn't trained directly on a dataset. To clarify, we're doing supervised learning using the GoGoD dataset, then the value network is trained based on games of self-play when the trained policy network plays against itself.
It could be that if you're training the value net directly on the KGS dataset (I assume you're training it to map from a given position to the end result of the game) then you may be experiencing this problem that Silver et al refer to in the paper:

The naive approach of predicting game outcomes from data consisting of complete games leads to overfitting. The problem is that successive positions are strongly correlated, differing by just one stone, but the regression target is shared for the entire game. When trained on the KGS data set in this way, the value network memorized the game outcomes rather than generalizing to new positions, achieving a minimum MSE of 0.37 on the test set, compared to 0.19 on the training set...

Then they go on to explain how they generate a new dataset for training that helps "mitigate" that problem.

There is something wrong with the architecture of the value network, according to the paper "hidden layer 14 is a fully connected linear layer with 256 rectifier units"

@wlike with the last commit, is the value network looking like what you interpreted from the paper?

Yes, at least for now.

@wrongu yes, at least for now.


Vlv2TbltDevicePkg/PlatformPkg: add reserved section

Signed-off-by: Michał Żygowski<EMAIL_ADDRESS>

@krystian-hebel please review.

If everything is fine, it is good time to start distinguishing branches into features and prepare documentation about each one.


png: add support for 16-bit PNG files.

Note: libpng.load now returns two arguments. The first argument is the result tensor,
and the second argument is the color bitness. It will be either 8 or 16. For images
with smaller color bit depth (for example, 4), the value is upgraded to 8 bits.
See also #74 and #75.

this looks pretty good to me overall

have to tested this on both 8-bit and 16-bit stuff? can you add some simple tests (even just to display a couple of images for sanity checks) to the test folder

@soumith thanks for your comments.
re: tests. I would like to add PNG tests to torch/image/test dir, just like you have for PPM, PGM and JPG.
One thing that I failed to figure out myself, is how to run these tests. I don't see them hooked up in CMakeLists.txt. Am I missing something?

we just run them manually with the interpreter. For example:
th test_compress_jpg.lua

@soumith I have made the first draft for test_png.lua, please take a look at the commit above.
I generate real PNG files of a very small size and load them with different options:
gray16-1x2.png: PNG image data, 1 x 2, 16-bit grayscale, non-interlaced
gray3x1.png:    PNG image data, 3 x 1, 8-bit grayscale, non-interlaced

I also plan to  cover color images, but I would like to hear your feedback on the test code first. Is there a better way to specify a Tensor literal?

yes, gave example in in-line comments.

@soumith thank you!
I have added all the tests I wanted (8-bit / 16-bit, gray / RGB) and fixed a bug with 16-bit RGB images in the process of doing that.
Please, take another look!

Hi @soumith,
is there anything I can do to improve this CL?
I would appreciate any feedback.
Thanks! :)

no, this looks perfect, I'm sorry for the delayed response, sometimes things get lost in the haystack. thanks again for the PR.

@soumith thanks!


added tags to allow proper formatting of coloured text in cleaned fields

Thanks. But if you would like to pass more tags and attributes, you can modify the bleach setting as your code.

Thanks. But if you would like to pass more tags and attributes, you can modify the bleach setting as your code.


smt init fails if yaml is not defined

Running smt init fails with the following error:
Traceback (most recent call last):
  File "/home/travis/miniconda/envs/test-environment/bin/smt", line 7, in <module>
from sumatra import commands, __version__
  File "/home/travis/miniconda/envs/test-environment/lib/python2.7/site-packages/sumatra/commands.py", line 24, in <module>
from sumatra.projects import Project, load_project
  File "/home/travis/miniconda/envs/test-environment/lib/python2.7/site-packages/sumatra/projects.py", line 47, in <module>
from sumatra.recordstore import DefaultRecordStore
  File "/home/travis/miniconda/envs/test-environment/lib/python2.7/site-packages/sumatra/recordstore/__init__.py", line 19, in <module>
from . import serialization
  File "/home/travis/miniconda/envs/test-environment/lib/python2.7/site-packages/sumatra/recordstore/serialization.py", line 13, in <module>
from sumatra import programs, launch, datastore, versioncontrol, parameters, dependency_finder
  File "/home/travis/miniconda/envs/test-environment/lib/python2.7/site-packages/sumatra/parameters.py", line 62, in <module>
class ParameterSet(with_metaclass(abc.ABCMeta, object)):
  File "/home/travis/miniconda/envs/test-environment/lib/python2.7/site-packages/sumatra/parameters.py", line 66, in ParameterSet
casts = (yaml.load, )  # good behavior for all bool, at cost of dependency
NameError: name 'yaml' is not defined

Looking into the source code I figured that in ParameterSet casts=(yaml.load) is executed without checking if yaml_loaded is True.

I just experienced the same problem, I had to manually install pyYAML (I guess it's not in the dependences)

Can confirm both problem and solution.
pip install pyyaml
did the trick.

Yes, thanks, pip install pyyaml did the trick. But I guess this should only be a workaround.
Otherwise the whole try catch block in sumatra.parameters
 try:
    import yaml
    yaml_loaded = True
except ImportError:
    yaml_loaded = False

doesn't make much sense :-)

Fixed in master in 7f7f0a1 and in the 0.7 branch in 82361cf


Sometimes WMI returns "__InstanceCreationEvent" for a process's name

Not sure why this is happening, but sometimes when a process is added, WMI reports the process name as "__InstanceCreationEvent". It doesn't always happen. I've seen it with ScriptedSandbox64.exe and TrustedInstaller.exe, which are both accessible. I haven't seen it with Notepad.

Somehow this no longer repros with 9713a6de22b84788719980d3547ce48485913ec3. I'm guessing there's a lifetime issue with the way I use wil::unique_variant and wil::unique_bstr.


fix: preview item for nuxt3

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[x] Bugfix
[ ] Feature
[ ] Refactoring

Context

[x] Currently preview media not works on nuxt3. this is an attempt to fix that

Did your issue had any of the "$" label on it?

[x] My DOT address: Payout

Copilot Summary

🤖 Generated by Copilot at 6a9d265
Refactored GalleryItem and GalleryItemPreviewer components to enhance fullscreen mode and code quality. Used provide function and NeoModalExtend component from external library. Improved media item and modal appearance.

🤖 Generated by Copilot at 6a9d265

Sing, O Muse, of the skillful refactorer
Who reshaped the GalleryItem component
And made it more reusable and readable
With provide function and props as helpers.

notes: to test the changes on nuxt3 branch:

go to nuxt branch
git cherry-pick 6a9d26525ca67a53d3a65d17c8647cc170014cba
run

GalleryItemPreviewer kinda works if you change v-model="isFullscreen" to :value="isFullscreen"

The Go Back button still doesn't work. IMO, emit and useVModel are not needed in that component

it's okay to change the v-modal to :value if that works. seems like the Go Back button still doesn't work with those changes only

Yup I have some problem with useVModel composable

actually, my goal is to use the same code between nuxt2 and nuxt3 as possible. to reduce line diff between main and nuxt branch. but, let's move on 👍🏻


Extract fields from unzipped XML?

It seems like you could extract field codes directly from the exploded XML source of the document. That would save the mammoth.js dependency, and should work (with a bit of tweaking maybe?) for both *.docx and *.odt source files.

@fbennett, yes, I didn't bother once I got mammoth.js to work, but it would be a lot cleaner to just unzip the files and loop over the relevant XML elements.
Looks like https://gildas-lormeau.github.io/zip.js/index.html might be a decent library for reading the files (*.odt is also just a zip file? See https://gildas-lormeau.github.io/zip.js/core-api.html#zip-reading-example in particular). And just some XPath for the XML (https://developer.mozilla.org/en-US/docs/Introduction_to_using_XPath_in_JavaScript)?

Any particular reason you're interested in supporting *.odt documents?

No pressing need, was only thinking of completeness and convenience. (To my surprise, the cite-extraction code in Juris-M still works after the migration to 5.0, so that alternative is still open to an LO user.)

and should work (with a bit of tweaking maybe?) for both *.docx and *.odt source files.

@simonster, can I bug you for a second? I wasn't sure if you still follow zotero-dev, and I have a question about how Zotero citation metadata is embedded in .odt files, which is probably your code. See https://groups.google.com/forum/#!topic/zotero-dev/vImXuhjsFw0


changed transfer/send to call

Removed the transfer and send methods and instead used the call method as per the audit report

closes #36


fix(dao minimized, dao grid card): add one word labels below the icons for easier navigation (issue #102)

Verified on dev. Implemented


Bug: Docker image won't run on ARM64 systems with non 4KB page size

This is because the default build option in jemalloc uses the host page size, even when cross-compiling. See https://github.com/jemalloc/jemalloc/issues/467#issuecomment-2054282344 for details.
The --with-lg-page option must be set to fix this.
Running the ARM64 images on such devices results in an immediate seg fault.
This affects lots of ARM64 devices like Macs with Apple Silicon and Raspberry Pi 5 running Raspberry Pi OS (Ubuntu on RPI 5 uses 4KB page size so it still works).

Hi @xJonathanLEI , could you please describe in more detail how to reproduce this?
I tried on macbook pro m2 with page size 16384 and I don't have this bug.

Are you running with Docker Desktop on macOS? I'm pretty sure it uses a Linux VM whose page size is still 4KB.
Dojo and Pathfinder both had the same bug but both have resolved.

Yeah Docker Desktop works by running a Linux virtual machine. The macOS page size has nothing to do with the VM page size. You can run getconf PAGESIZE inside the container to find out.
Here are the Dojo and Pathfinder issues for your reference:
https://github.com/eqlabs/pathfinder/issues/1982
https://github.com/dojoengine/dojo/issues/1913


Add sourcetypename metric field

Not needed for now.

Looks like we'll likely need this after all.


Unable to move chart into right end with only visible whitespace items

Lightweight Charts™ Version: 4.1.4
Steps to reproduce:

Create a chart instance
Add series with only whitespace data, which contains time values per each second (for simplicity). From 9:00 to 11:00 unix time.
Add series with actual data. From 9:45 to 10:15 unix time (thus placing it in the middle of whitespace timeline)
Try to reach left and right end of timeline.

Actual behavior:
Chart supports infinity moving to left side while whitespace series data is present (as expected).
But moving chart forward into right side cause locking move when last bar of main series data riches starting point of timescale.
Expected behavior:
Charts able to move left and right side freely while whitespace is present at timescale.
Screenshots:
https://github.com/tradingview/lightweight-charts/assets/1912057/83d37d49-f020-49d9-a132-93046dcbb635
JSFiddle link:
https://jsfiddle.net/njw3bed9/1/

One solution to this is to have all of the area that you want scrollable as whitespace data and the very last data a line data with a NaN value.
Like so:
const whitespaceStartDate = "1970-01-01";
const whitespaceEndDate = "2100-01-01";
const whitespaceDateDataset: ((WhitespaceData | SingleValueData) & Numbered)[] =
  new Array(
    getNumberOfDaysBetweenTwoDates(
      new Date(whitespaceStartDate),
      new Date(whitespaceEndDate),
    ),
  );
// Hack to be able to scroll freely
// Setting them all to NaN is much slower
for (let i = 0; i < whitespaceDateDataset.length; i++) {
  const date = new Date(whitespaceStartDate);
  date.setUTCDate(date.getUTCDay() + i);

  const number = date.valueOf() / ONE_DAY_IN_MS;
  const time = dateToString(date);

  if (i === whitespaceDateDataset.length - 1) {
    whitespaceDateDataset[i] = {
      number,
      time,
      value: NaN,
    };
  } else {
    whitespaceDateDataset[i] = {
      number,
      time,
    };
  }
}


Debian repo release

It seems to me that https://www.justwatch.com/gopass/releases/binary-amd64/Release wasn't updated with new v1.7 realease, it's timestamp is still in January. While I see a new version package in the repository via web interface, apt refuses to update it. Could you please take a look? Thanks.

Thanks for raising this issue. The Debian Repo situation is a little annoying at the moment. I plan to look into some alternatives soon.
Meanwhile I'll try to fix the existing repo.

In that light, revisiting snaps might be an option. #16

Personally I don't get the point of snaps (so far). But if someone wants to contribute, feel free.

There is already Debian repo deployment script in the project. It's simpler to fix it (I hope), rather than urge users to use completely different packaging option.
BTW, there are many "good" alternatives beside snaps: AppImage, flatpak, docker, nix, linuxbrew and other similar things, you name it. They are all equally good from technical point of view, but there is common problem with them - they are not brew of Mac world. Every one of them contains only 2.5 packages which are not in official Debian repositories, not stable and hardly tested (because of luck of community). So, no, it's not an option for me (as Debian/Ubuntu user), I'd rather compile package from sources myself, than will use several different package managers on the single Debian system (and I will have to, if I start to use any of them, because neither of them provide a complete solution at the moment). So, please, keep supporting Debian repo. All other options are up to you.

We'll keep supporting Debian packages for sure!
I'm currently looking into hosting the packages with bintray and adding this to our (semi-automated) release workflow.
We'll also keep supporting brew for MacOS. I don't think snap is important for us, but if someone disagrees and creates a proper PR we can support that, too. There was a snap PR in the past but I wasn't able to successfully build a gopass snap package with the scripts/documentation in that PR so I wasn't to able to merge it back then. If someone creates a working PR we will re-evaluate it.

We've implemented preliminary Bintray support in our release workflow and will continue to extend and polish this with the next releases. This way we should be able to keep our Debian Repo always up to date.

I switched to the new repo and got the 1.8.0-alpha release (which also seems to have some workflow breaking bugs for us). Oddly I couldn't "see" the 1.7.2 release that is also there and on my initial attempt to manually download to downgrade I discovered that there is a : getting adding before the deb package name in the URL that was causing issues.
Right now I'm working through what broke in the change from 1.6.10 to 1.8 and whether it came up in 1.7.2 or not and will file appropriate bugs as necessary.

The new repo only contains any new releases. I will try to backfill the old ones eventually.
Please be sure to file individual issues for any breaking bugs you encounter. Thanks!

@dominikschulz
I'm not re-opening this issue, it's just a question. I'm curious is it difficult to make through into official Debian repository? I've seen some old version in "unstable" and "testing", but no new updates and seems no progress into "stable". What blocks it? Is it some requirement from Debian side or lack of resources or project is just not too stable yet. Personally I would prefer to stick to the current version (1.7.x) as it has everything I currently need and works for me. Now I'm a bit worry about possible breaking updates )). Especially, because I had to switch to go get, while you were migrating onto new repo ('cause I experienced issues with keys and repo availability during unattended OS installation). I'm considering to switch back to repo usage, but would prefer a bit outdated version, but from official repo. Not "that outdated", though )), 'cause I get used to yaml metadata function in the json API.
So, if anything can be done from the community side to make it into official Debian repo, please let us know. I'm not experienced in that matters, but probably someone of us, users, would be able to help. Thanks!

@nikolay-turpitko Thanks for asking. In fact I think it might be almost impossible to get this gopass into any official Debian/Ubuntu distribution. Because in fact there is a completely different password manager with a similar name packaged as gopass in Debian already. It was uploaded some time after we announced gopass to the public (there may have been an ITP before that, but we failed to find it when researching for possibly conflicting names).
So if someone is very experienced with the complicated Debian policies regarding package naming and conflict resolution and has a lot of endurance he or she might be able to help.
The best recommendation I give right now is to raise an issue in the Debian and/or Ubuntu Bugtrackers and complain about this there, because then it will come attention to the people who could actually do something about this.

@dominikschulz Thanks for explanation. I haven't realized that these are two completely different packages. I thought it's the same but older version. Yeah, now I see, it's probably complicated indeed. Name conflict can be, probably, resolved, if you package it as gopasspw (as you recently renamed git repo), but I don't know much about other policy, regarding similar functionality. Raising an issue I would try, though I have couple of issues both on Debian and Ubuntu unanswered from March )).  There is something wrong with their mailing/notification system setup, preventing it to send notifications originated from my email account. (OK, I know what's wrong, but it is irrelevant here - https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=754809, my email provider prevents them to use my email address, when they trying to send notifications, and I receive spam prevention alerts, don't know what can I do about it, though). So, if someone else will rise an issue, I'll add my +1.


[Feat]: Add ability to set umask (from environment variable)

Is your feature request related to a problem? Please describe.
I'm currently encountering frustration trying to bring zot up on OpenShift Local on my laptop due to permissions issues.
Specifically, I'm trying to get it to run while pulling the registry out to a directory within my home directory so it can be persistent between instantiations of the virtual machine.
The problem is that OpenShift Local is "opinionated" in what it runs its users under. I've tried both precreating the directory the registry is to be put in with 777 (or even 2777) permissions, and allowing OpenShift to do so. In the first case, when I try to push a docker image, I get an error (will recreate it in just a bit to put as a comment.) In the second case, zot will not even start (because it can't write the index.db)
(I'm reporting to you, but I know enough go that I'll try to send you a PR this weekend if you don't get to it before then. My understanding is that it should be a single-digit number of lines as far as the go code that is compiled to the zot binary is concerned - the question I haven't looked at yet is where to put said lines. You'll also see some Helm chart improvements from me in a few days.)
I'll come back after I sanitize zot's logs (just the URL's being hit, I promise) and attach those as well.
docker-output.txt
kubectl-neat-output.txt
ls-output.txt
Describe the solution you'd like
I'd like the ability to get the files group-read/writable - and being able to set the umask to 002 might help with that.
Describe alternatives you've considered
No response
Additional context
No response

And it turns out zot is returning a 415 because docker is sending its manifest with the "application/vnd.docker.distribution.manifest.v2+json" content-type and OCI-style doesn't like that! The permissions aren't the cause of the problem I'm having. Still, I see myself needing the group-writability for another reason: OpenShift sets a retrievable-but-different UID, so the persistence would still need a way to change the file ownership otherwise. But lower-priority than it was.

@csjewell https://github.com/project-zot/zot/issues/724

Thank you, @rchincha ... that will help with my original problem, but not the one I'm still having (where I cannot really do persistence because the permissions aren't right - right now I have to do persistentVolumeReclaimPolicy: Recycle
where I'd really like to use Retain, instead) - what I may do is create a Wolfi zot-image with a small Go re-runner in front of it as described in https://github.com/GoogleContainerTools/distroless/issues/1217. I'll put the code up for that when I'm done.

(I do note that it looks like there's already a Wolfi image described at https://images.chainguard.dev/directory/image/zot/versions - I'll double-check it first and see if it solves the problem already.)


169521 [Geos En pt br uk][High][Newsroom] Common Modules - Hero-hero article for legacy got updated but not for franklin

Steps to Reproduce: | Analysis & Proposed Solution: | Location of the Element:
Priority: 3 - Medium
1.Open both the URL
Legacy
https://newsroom.accenture.com/
https://newsroom.accenture.pt/
https://newsroom.accenturebr.com/
https://newsroom.accenture.co.uk/
Franklin
https://main--accenture-newsroom--hlxsites.hlx.live/
https://main--accenture-newsroom-pt--hlxsites.hlx.live/
https://main--accenture-newsroom-br--hlxsites.hlx.live/
https://main--accenture-newsroom-uk--hlxsites.hlx.live/
2.Observe the hero article for the legacy and franklin, for legacy page it is now updated to latest article but for franklin it is not updated.
Actual:
Legacy article is updated.
Franklin: Franklin page hero article need to be update as per the legacy
Note:
For the other geos mentioned on the bug heading (pt br uk)
There is no hero section for the legacy but for franklin it needs to be update (not sure)
Also, for the other geos i do not see any update on the legacy itself with the latest article ((But this need to be check)
Legacy page

Franklin page

Azdo Link: https://dev.azure.com/accenturecio26/WebContentDigAssetMgmt_PR1093/_workitems/edit/169521
CC: @ravkiran @amol-anand @raymond-h-dev

[ ] Authoring
[ ] en
[ ] br
[ ] pt
[ ] jp
[ ] de
[ ] uk
[ ] es
[ ] it
[ ] sg
[ ] fr
[ ] Ready for test

@zozo-j is this authoring issue? now the home pages of legacy and Franklin looks same but the Franklin site should be authored to add the new link https://www.accenture.com/pulseofchange

This is an authoring issue. need to update the index page for each geo. we are not importing the index page, just the news articles. Please go ahead and update the index page with the right hero article, title, link etc..


Default TCP send buffer size too low

On a 1920x1080x32bpp display shared over a ~300mbit 802.11ac wifi network, the performance of xrdp is kind of lackluster with the default TCP send buffer size of 32768 bytes.
The defaults set in xrdp.ini are as follows:
[Globals]
#tcp_send_buffer_bytes=32768
#tcp_recv_buffer_bytes=32768
tcp_nodelay=true
tcp_keepalive=true

When uncommented, xrdp uses these values to set the send and recieve buffer sizes.
This results in send/recieve buffers of 65536 bytes each, respectively, since the (Linux) kernel doubles the value requested (tcp man page). Besides being printed in the log output, this can be independently confirmed by
$ ss -lnm sport 3389
Netid                State                 Recv-Q                Send-Q                                 Local Address:Port                                 Peer Address:Port                Process
tcp                  LISTEN                0                     2                                            <IP_ADDRESS>:3389                                      <IP_ADDRESS>:*
	 skmem:(r0,rb65536,t0,tb65536,f0,w0,o0,bl0,d0)

I noticed that xrdp wasn't even close to saturating the link speed, which is what prompted this investigation.
By setting tcp_send_buffer_bytes to something a little more generous (e.g., 4194304):
[Globals]
tcp_send_buffer_bytes=4194304

And increase the corresponding sysctl limit to 2x the requested buffer size:
$ sudo sysctl -w net.core.wmem_max=8388608

We get much improved performance (seamless window dragging, smooth scrolling, full screen FHD video playback).
I think this should be written somewhere - maybe in the wiki, in the man pages, or briefly mentioned as a comment in the stock xrdp.ini.
Hope this helps someone.

Thanks! This is very helpful.

Does it make sense to set the value to 32 MiB (33554432 bytes) or does a too high value have negative effects?

Shouldn't XRDP just leave that value out and use the kernel default?
I think the kernel autosizes that value depending on the congestion window and the receive window which is adjusted by packet loss signals or other methods (in BBR).
If I understand correctly, the kernel uses up to 6 MiB by default.
The size should be the BDP (Bandwidth-Delay Product) and that calculation should be small for a WiFi net.
In terms of interactivity I think setting net.ipv4.tcp_notsent_lowat (also can be set by the application) to for example 16 KiB is beneficial.
Maybe apps can also select a preferred congestion algorithm, which in this case, BBR should be a good option.
Also we can help users by writing some doc about suggested kernel settings to improve interactivity and performance.

If you leave the values out of the config file, xrdp will use the kernel defaults.

FWIW, some example BDP calculations for buffer size 32768:

262mbps @ 1ms RTT
26mbps @ 10ms RTT
13mbps @ 20ms RTT
5mbps @ 50ms RTT

Regularly seeing xrdp pushing 50-100mbps under load test, allowing the OS to auto-scale the buffer size is desirable, and I'm not sure if it's even possible after setsockopt pins the value.

Thanks @rowlap
There's a Linux workaround for the current behaviour in this post which is part of issue #2905.
A fix is in PR #2910 which I'm hopeful we'll merge for v0.10.x


404 error when trying to download mssql.

Hey there,
I'm following the instructions from: https://docs.microsoft.com/en-us/sql/linux/quickstart-install-connect-ubuntu?view=sql-server-ver15
I'm using a 2GB Raspberry Pi 4B, running Ubuntu 20.04.2 LTS (GNU/Linux 5.4.0-1028-raspi aarch64). I am accessing the server via ssh connection over the internet, using a Windows CMD line.
I run: wget -qO- https://packages.microsoft.com/keys/microsoft.asc | sudo apt-key add -
This outputs OK
I then run: sudo add-apt-repository "$(wget -qO- https://packages.microsoft.com/config/ubuntu/20.04/mssql-server-2019.list)"
This outputs:
E: Malformed line 1 in source list /etc/apt/sources.list.d/mssql-server.list (type) E: The list of sources could not be read.
From what I can understand, https://packages.microsoft.com/config/ubuntu/20.04/mssql-server-2019.list is giving a 404 error.
When I run nano /etc/apt/sources.list.d/mssql-server.list
I see:
GNU nano 4.8                          /etc/apt/sources.list.d/mssql-server.list
<title>404 Not Found</title>

404 Not Found

nginx/1.16.1

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5634d572-0020-808b-693a-13addc8861d9
Version Independent ID: 136bab7d-d4d1-1e82-ba89-be2020bc784b
Content: Ubuntu: Install SQL Server on Linux - SQL Server
Content Source: docs/linux/quickstart-install-connect-ubuntu.md
Product: sql
Technology: linux
GitHub Login: @VanMSFT
Microsoft Alias: vanto

The issue likely stems from the ARM processor on the Raspberry Pi 4, there isn't an ARM image available for SQL Server on Linux at this moment.
However - there is an Azure SQL Edge container that runs on ARM and will likely support your IOT scenario. - https://docs.microsoft.com/en-us/azure/azure-sql-edge/disconnected-deployment

Hmmm. Had a go with that alternative, which requires Docker. Run into this whilst trying to install Docker which might be related:
sudo apt-get install docker-ce docker-ce-cli containerd.io
Reading package lists... Done
Building dependency tree
Reading state information... Done
Note, selecting 'moby-containerd' instead of 'containerd.io'
Package docker-ce is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source
However the following packages replace it:
  moby-engine moby-cli moby-engine:armhf moby-cli:armhf moby-engine:amd64 moby-cli:amd64 docker-ce-cli:amd64

E: Package 'docker-ce' has no installation candidate
E: Unable to locate package docker-ce-cli ```

Do I need to install moby-engine instead? This is my first time setting up a Ubuntu server, so it's very possible I've done something wrong.

A similar issue I've found, [https://github.com/MicrosoftDocs/azure-docs/issues/14254](url) I think I'll try and follow their solution of using Azure SQL Edge.

I don't have an RPI handy at the moment, but have a few troubleshooting ideas:

You may need to add the repository for docker-ce before running apt-get: https://docs.docker.com/engine/install/ubuntu/#set-up-the-repository
alternatively, you can try their install script: https://docs.docker.com/engine/install/ubuntu/#install-using-the-convenience-script
lastly, moby-engine and moby-cli are the underlying projects to docker and are preferred in some examples (https://dbafromthecold.com/2020/04/22/running-azure-sql-edge-on-a-raspberry-pi/)

I had a few issues trying to get Docker to work, as well as a few dependancies.
The simple solution I used in the end was to use mysql-server, following instructions from here: Guide. It just worked. (Even tho I'm using ubuntu 20.04)


Unable to display accents

This is about issue  #98
This issue was not fixed.
The problem is happening with TTF and regular fonts.
doc = new PDFDocument;
doc.pipe(fs.createWriteStream('output.pdf'));
//doc.font('fonts/RobotoCondensed-Regular.ttf');
doc.font('Courier');
doc.text('Autenticação: ');
doc.end();
The result is:
Autentica��o

So you should choose a font that contains glyphs for the codepoints you want to display. Characters that are not in the font have a substitute glyph displayed, because there is no glyph for the codepoint of interest.
Many fonts are have a glyph repertoire that is limited to a particular code page, often the one the font designer uses. Only a few fonts have a broad repertoire. While browsers, and some other software, will do automatic font substitution to find a font that has a glyph for a code point that is missing in the selected font, PDF software typically doesn't do such automatic substitutions. Typeset documents typically are more interested in a uniform look, rather than the laissez-faire "just find the character somewhere, so the user can read it, rather than make them find a font that matches" approach that browsers take.


feat: add --airports and --airports-tz-filter

Add import for FAA Airport information csv from https://github.com/mborsetti/airportsdata
Add parsing from timezones, such as "America/Chicago,America/New_York"
Fix display of lat lon for CUSTOM

Here is the local view, pretty cool if a bit "busy".

haHa!, now I don't need to find the state lat/lon lines. Just show all airports


New friendly SQL

1.1.0 introduced several friendly SQL features:

[ ] max_by(n), etc.
[ ] IN for maps and lists
[ ] Unpacked Columns
[ ] query and query_table Functions

cc @Maxxen

See also the post at https://www.linkedin.com/posts/bill-wallis_sqlwithbill-sql-activity-7240070805810745344-a14p/
• Specifying CTE column names with the CTE name
• Using a VALUES statement in the anchor part of the recursive CTE
• Using a VALUES statement in a join
• Specifying column names in the join alias
• Creating a LIST using square brackets (LIST is a data type in DuckDB)
• Accessing the last item in a list with [-1] like in Python
• Extending a list easily with LIST_APPEND
• FROM-first syntax (where SELECT * is optional)

max_by(n) (https://duckdb.org/docs/sql/functions/aggregates.html#max_byarg-val-n), IN lists (https://duckdb.org/docs/sql/expressions/in.html), query/query_table  (https://duckdb.org/docs/sql/functions/utility.html#queryquery_string_literal), *COLUMNS (https://duckdb.org/docs/sql/expressions/star.html) are all documented by now.


Travel Vlog Summary Template Page

Reference
Footer Wave Reference
Instructions

Make the cards square in shape
Add a title like "Trip to the X" before the cards
For the purpose of the demo, replace the "section 1", "section 2", etc texts with "Day 1", "Day 2", "Day 3", etc
All the images should be placed inside ./assets/images/travel/trip1/
Take the images from unsplash. ( For example tourist spots in New Delhi)
Name the images properly
Do not add a tab in the Nav Bar. The page would be accessed directly with ./travel_temp.html
The CSS file should be ./assets/css/travel_temp.css and the Js should be ./assets/js/travel_temp.js
To add or remove cards and the details for the same, it should be done from a JSON variable inside conf_temp.js. Check out research.js for reference.

Please assign it to me.

Assigned for 3 days

Hey @smaranjitghose ,
This is how the design should look ?

Increase the height of the image of whatever. So that it can be looked at carefully. Also, try adding an image in portrait mode also.


Fix nav.item not applying active class correctly for Ember 3.12-beta

Was caused by the CP not recomputing when router.currentURL changes.

Why not wait for a bugfix upstream?

Yes, I think we should do that, i.e. not merge this. I created the PR to show the workaround, and for the case that this new "behavior" is somehow not considered a bug. But after the bug has been (kind of) confirmed, we should probably only merge this as a workaround in case the upstream bug fix is not ready for the next stable Ember release.

As the upstream bug is not fixed yet, I am going to merge this to get our builds green again. As commented in the code, we should remove this again when fixed in Ember.


Add quirks for Tuya multigang switches

This PR add quirks for Tuya multigang switches.
It should correct the management of the On/Off cluster for the multiswitch devices that make use of the Tuya cluster (0xEF00) for command/status reporting.
The MODELS_INFO of those devices that have been reported or an issue has been reported have been added.
For those devices whose number of gangs is not clear, they have been defined as 1-gang devices until someone report correct info.

Codecov Report

Merging #1166 (51881ad) into dev (4682b81) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1166      +/-   ##
==========================================
+ Coverage   80.39%   80.41%   +0.02%
==========================================
  Files         203      203
  Lines        5581     5587       +6
==========================================
+ Hits         4487     4493       +6
  Misses       1094     1094

Impacted Files
Coverage Δ

zhaquirks/tuya/ts0601_switch.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4682b81...51881ad. Read the comment docs.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

6 of 6 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 80.419%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
4493

Relevant Lines:
5587

💛  - Coveralls

We have doubts about the characteristics of the following devices:

_TZE200_vhy3iakz
_TZ3000_uim07oem

I have found both one and multiple reference but only 1 gang for them that is verified.
Z2M is having all of then in the same and no clue how many gangs.
I shall looking more in deCONZ but they dont have do many implanted (then more request that is being slated).
I think its better letting them as 1 gang until user doing request for them.


Fix execution reconcile

How to categorize this PR?

/area robustness
/kind bug
/priority 3
What this PR does / why we need it:
This pull request fixes issues of the reconcile logic of the execution controller.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

/test


Scorecard external plugins are not currently supported with v1alpha2

Type of question
operator-sdk scorecard future support for external plugins
Question
What did you do?
When running operator-sdk scorecard version 0.13 and 0.14 got the following error:
Error: error validating plugin config: revert to v1alpha1 to use external plugins: external plugins are not currently supported with v1alpha2
What did you expect to see?
Support for external plugin
What did you see instead? Under which circumstances?
see above
Environment

operator-sdk version: 0.13.0 and 0.14.0

operator-sdk version
operator-sdk version: "v0.14.0", commit: "4fb185b9d45682473b4951c9788f845ba2fa5b12", go version: "go1.13.3 linux/amd64"

Kubernetes version information:

Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.6", GitCommit:"96fac5cd13a5dc064f7d9f4f23030a6aeface6cc", GitTreeState:"clean", BuildDate:"2019-08-19T11:13:49Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"14+", GitVersion:"v1.14.6+dea7fb9", GitCommit:"dea7fb9", GitTreeState:"clean", BuildDate:"2019-11-19T17:18:37Z", GoVersion:"go1.12.12", Compiler:"gc", Platform:"linux/amd64"}

Kubernetes cluster kind:

Additional context
Add any other context about the question here.

@joelanford wondering if you can comment on this

Yep, so in v1alpha2 we introduced --selector so that callers could select just a subset of the scorecard tests to run (e.g. required vs. recommended) and --list so that callers could see which tests were selected without actually running them.
In v1alpha1 these features don't exist so the external plugin interface (and external plugins) have no way of answering the question "What labels do you have?" to support the selector flag and they have no way of getting information from the plugin without actually running the plugin.
For that reason and because there are a bunch of other fundamental questions to answer about the exact use cases of external scorecard plugins, the decision was made to drop support for them in v1alpha2 and to revisit in a later version of the scorecard after we have a better understanding of the use cases.

@joelanford thanks


Training on Windows using new AMD ROCm

Hi!
Can you PLEASE finally add an AMD GPU support for training, due to the release of AMD ROCm for Windows?
https://rocm.docs.amd.com/en/latest/release/windows_support.html
Thanks <3

Would love to see this as well!

Same, i don't know why they didn't add this feature already, i've seen so much people on internet trying to get it working on AMD GPUs

The main reason it hasn't been working for Training on Windows, but works to a degree on Linux is PyTorch and other pip packages hasn't been ported over to work with ROCm and Windows yet as they were waiting for dependencies to be updated not too long ago. As well as AMD just made ROCm available for Windows not too long ago.
That being said, I'm unsure if any progress has been made with PyTorch and the other pip packages, and would love to see Windows support :)


Make bat a function that runs batcat if it exists

On Debian and Ubuntu the bat binary is renamed to batcat to
avoid a name clash with the bacula package.
See: https://github.com/sharkdp/bat/issues/982
If batcat is present, it is almost certainly what should be used.
Unintentionally invoking bacula with likely invalid arguments is almost certainly not intended behavior. This should help with Debian, Ubuntu, Linux Mint, and other derivatives.
To solve this, this shell function named bat overrides the native bat command from $PATH with batcat if batcat is a valid command.

Thanks a lot for making me aware of this, it's not how I would like this issue to be solved, though, so I'll close this issue and fix it myself.

Should be fixed with af365ec43fd8d39f8d699b6c7ccd1199b09dee51.

No problem. Seems good :P


Deploy to Azure button

Deploy to Azure button will open azure portal with ready made form to start the installation of KONG to Azure. No need to run the .ps1 script.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


It is failure to autoscale service instance.

In GitLab by @luotian-github on Sep 28, 2018, 19:08
I don't know how to generate the logs data in the kibana.

In GitLab by @luotian-github on Nov 8, 2019, 08:00
click "confirm", then get failure?

In GitLab by @luotian-github on Nov 8, 2019, 08:00
it is OK in your test environment when I tested the autoscale, see the above screenshot

In GitLab by @luotian-github on Nov 8, 2019, 08:00
I know how to reproduce it

In GitLab by @luotian-github on Nov 8, 2019, 08:00
Add limit and checking on frond-end for hpa-name.
PR#1766

In GitLab by @liyanq528 on Nov 8, 2019, 08:00
fixed #1767

In GitLab by @wknet123 on Nov 8, 2019, 08:00
fixed issue #1753

In GitLab by @sokril on Nov 8, 2019, 08:28
closed

In GitLab by @sokril on Nov 8, 2019, 08:28
assigned to @luotian-github

In GitLab by @liyanq528 on Nov 12, 2019, 02:58
mentioned in merge request !1108

In GitLab by @liyanq528 on Nov 13, 2019, 08:03
mentioned in merge request !792

In GitLab by @liyanq528 on Nov 13, 2019, 11:26
mentioned in merge request !1076


upperTersity param not working in printDuration

I am trying to limit the upperTersity to days, but its taking the default value of weeks. The code is -
final playTime = Duration(minutes: value); // value = 14966
final humanizedTime = printDuration(
    playTime,
    abbreviated: true,
    tersity: DurationTersity.hour,
    upperTersity: DurationTersity.day,
); // output = 1w, 3d, 9h

I have tested the tersity param and its working. upperTersity is not working with any value of DurationTersity, it is always giving weeks

Thanks for the bug report. I have fixed it and pushed it to pub.dev as 3.0.11.


Include timing stats in workbench query results

(Migrated from https://openrdf.atlassian.net/browse/SES-2110)
It would be useful to include some basic execution timing stats (e.g. elapsed server-side wall-clock time) in the query results page of the workbench.

This is marked as a "good first issue" but I've just realized this is probably not straightforward - especially if we want it to report server-side elapsed time. The response document is in one of several standardized formats, and AFAIK none of these formats have an option to carry this kind of metadata. So getting the server time back to the frontend would have to be done by some custom extension, possibly a response header.
It might be easier to go with client-side time at first.

I could have sworn I saw query time on the result set of workbench in an older (3.x?) but I no longer see it.  Did I imagine it?  If not, agree this would be great to have.


[propose_downstream job] Allow to specify more branches

Looking at this PR I'm wondering whether it would be more user-friendly if there was a way how to specify all branches in one job, i.e.
- job: propose_downstream
  trigger: release
  metadata:
    dist_git_branches:
    - master
    - f30
    - f29

instead of
- job: propose_downstream
  trigger: release
  metadata:
    dist_git_branch: master
- job: propose_downstream
  trigger: release
  metadata:
    dist_git_branch: f30
- job: propose_downstream
  trigger: release
  metadata:
    dist_git_branch: f29

what should happen when the first update fails? should it continue or break?

what should happen when the first update fails? should it continue or break?

fail, the same as when copr-build fails in one target/chroot

I'm personally not much in favor of these simplifications

ok

Let's leave this open, the fact that I don't like the idea doesn't mean that we shouldn't do it. I'd say we just need to discuss this.

I personally don't need this and there are some .packit.yaml related proposals in https://github.com/packit-service/packit/issues/574 so closing.


App compound - DAI in mainnet

In mainnet, whenever you withdrawn locked DAI from the app compound the "Interest earned" balance is reduced by the amount withdrawn.
URL with the safe: https://safe-team-mainnet.staging.gnosisdev.com/app/#/safes/0xB7526726EE1031AF7d700B0351EE5a20dd910177/apps
(who ever check this ask Franco Venica, to make you owner of the safe)

The etherscan URL of the tx
https://etherscan.io/tx/0xd5a5f47bb655646fdf84168df529d0290e6440a1631d3f65a98d7a6024db6fbe

Issue moved to gnosis/safe-react-apps #11 via ZenHub


[azure-messaging-eventhubs-cpp] publish version 1.0.0-beta.9

Update vcpkg ports for Azure SDK release. This release may contain multiple ports.

Adding azure-messaging-eventhubs to release
cc: @LarryOsterman

Thanks for the update!


Lots of warnings after latest Flutter upgrade

Hi,
I just upgraded flutter and when building my app now, your library produces a lot of warnings:
../../../snap/flutter/common/flutter/.pub-cache/hosted/pub.dartlang.org/youtube_player_flutter-8.0.0/lib/src/widgets/youtube_player_builder.dart:40:20: Warning: Operand of null-aware operation '?.' has type 'WidgetsBinding' which excludes null.

'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../snap/flutter/common/flutter/packages/flutter/lib/src/widgets/binding.dart').
WidgetsBinding.instance?.addObserver(this);
^
../../../snap/flutter/common/flutter/.pub-cache/hosted/pub.dartlang.org/youtube_player_flutter-8.0.0/lib/src/widgets/youtube_player_builder.dart:45:20: Warning: Operand of null-aware operation '?.' has type 'WidgetsBinding' which excludes null.
'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../snap/flutter/common/flutter/packages/flutter/lib/src/widgets/binding.dart').
WidgetsBinding.instance?.removeObserver(this);
^
../../../snap/flutter/common/flutter/.pub-cache/hosted/pub.dartlang.org/youtube_player_flutter-8.0.0/lib/src/widgets/youtube_player_builder.dart:51:43: Warning: Operand of null-aware operation '?.' has type 'SchedulerBinding' which excludes null.
'SchedulerBinding' is from 'package:flutter/src/scheduler/binding.dart' ('../../../snap/flutter/common/flutter/packages/flutter/lib/src/scheduler/binding.dart').
final physicalSize = SchedulerBinding.instance?.window.physicalSize;
^
../../../snap/flutter/common/flutter/.pub-cache/hosted/pub.dartlang.org/youtube_player_flutter-8.0.0/lib/src/player/raw_youtube_player.dart:43:20: Warning: Operand of null-aware operation '?.' has type 'WidgetsBinding' which excludes null.
'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../snap/flutter/common/flutter/packages/flutter/lib/src/widgets/binding.dart').
WidgetsBinding.instance?.addObserver(this);
^
../../../snap/flutter/common/flutter/.pub-cache/hosted/pub.dartlang.org/youtube_player_flutter-8.0.0/lib/src/player/raw_youtube_player.dart:48:20: Warning: Operand of null-aware operation '?.' has type 'WidgetsBinding' which excludes null.
'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../snap/flutter/common/flutter/packages/flutter/lib/src/widgets/binding.dart').
WidgetsBinding.instance?.removeObserver(this);

Looks like this package may no longer be supported :(

Looks like this package may no longer be supported :(

Oh dear, guess I will have to make my own fork then and update it, unless you know of a currently maintained fork that someone else has already made?

Thanks so much, will test it shortly.


File list reports

Need to add functionality to allow for a file list dump from cloud based storage endpoints.

S3

[x] "Prefix" switch.
[x] Time delta to mask timestamps.

Azure

[ ] "Prefix" switch.
[ ] Time delta to mask timestamps.

General

[ ]  Output path
[ ]  Output filename

All time module impotrs have been changed to datetime module.
Added two functions: to obtain UTC current time and to mask timestamps according to given delta in days.
Added logic to S3's list-objects function to output a file list instead of storage stats when the 'reports' sub-command is called.
Added to the reports sub command the following swithces:

'-p, --path, --prefx' to specify where to start recursively making a file list from.
'-o' Directory where to output the file.
'--delta' Number of days from the current day's 00:00 to mask timestamps of files. So if the user wants all files that uploaded up to a day ago, it would be: --delta 1

An example of how to use it:
dynafed-storage reports -c /etc/ugr/conf.d/endpoints.conf e --delta 1 -p rucio

Added support for Azure. Tested delta mask and prefix in the Azurite storage emulator.

Filename is at the moment "StorageEndpointID.txt"

Issue when directory in path does not exist when given in the '-o' switch. Need to either create the directory or fail and let the user know.

The script now fails when the path does not exist or the user has no write permissions to path.


Fixing the broken main build

Currently working on possible fixes to the main build failures.

Change Description

[ ] My PR includes a link to the issue that I am addressing

Solution Description

Code Quality

[ ] I have read the Contribution Guide
[ ] My code follows the code style of this project
[ ] My code builds (or compiles) cleanly without any errors or warnings
[ ] My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Bug Fix Checklist

[ ] My fix includes a new test that breaks as a result of the bug (if possible)
[ ] My change includes a breaking change

[ ] My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

[ ] I have added or updated the docstrings associated with my feature using the NumPy docstring format
[ ] I have updated the tutorial to highlight my new feature (if appropriate)
[ ] I have added unit/End-to-End (E2E) test cases to cover my new feature
[ ] My change includes a breaking change

[ ] My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

[ ] Any updated docstrings use the NumPy docstring format

Build/CI Change Checklist

[ ] If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
[ ] If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

[ ] Any new or updated docstrings use the NumPy docstring format.
[ ] I have updated the tutorial to highlight my new feature (if appropriate)
[ ] I have added unit/End-to-End (E2E) test cases to cover any changes
[ ] My change includes a breaking change

[ ] My change includes backwards compatibility and deprecation warnings (if possible)

Error is saying a mismatched end line in the bindings file
https://github.com/lephare-photoz/lephare/actions/runs/12395343329/job/34600829019