Display Book Name in Search Results

Describe the feature you'd like
In search results, when a page or chapter is listed, also display the name of the containing book. This could be similar to how pages are listed in the ctrl+k link browser.
Describe the benefits this feature would bring to BookStack users
When multiple pages with the same name are contained in different books, it is unclear in the search results which result is desired.

Thanks for the suggestion.
This is planned for the #1153 design update.

Wonderful, thank you.

As of the latest release:
https://www.bookstackapp.com/blog/beta-release-v0-26-0/
This is now implemented, Both book and, if applicable, chapter will be shown for a page or chapter.
Will therefore close this issue.


Fixed typo

charaters -> characters

+1

This is already fixed in the develop branch. Will be merged into master with next release.
Thank you for the reminder.


Output bigwigs with macs2 p-value signal for every base-pair

I am looking for the MACS2 p-value signal for every base-pair, similar to the bigwigs available from ROADMAP or EPIMAP.
Had a discussion with @JoseEspinosa and he thinks it may be available using the --bdg option when calling MACS2 but this is not a parameter that is currently available:
https://github.com/nf-core/chipseq/blob/6924b669422215f9021144b251e83fc9929be1fe/main.nf#L1135-L1145

Just getting into nextflow and this would be very helpful for us as well. This has to be done after the initial callpeak command. Use bdgcmp command to compare the two bedgraphs originally generated by macs2 with the -B/--bdg and --SPMR options
This is how we have typically done this for histone mods:
macs2 callpeak -t x_norm_sorted.bam -cy-Input_norm_sorted.bam -n x -f BAM -g hs --keep-dup all --nomodel -p 1e-2 --broad --nomodel --extsize  -B --SPMR
macs2 bdgcmp -t x_treat_pileup.bdg -c y_control_lambda.bdg -o "x_ppois.bdg -m ppois -S  <value calculated based on whether the chip or input larger/million reads>

Just to add to @jcotney solution, ENCODE also have a pipeline to produce this data (which could be replicated in nextflow I guess):
https://github.com/ENCODE-DCC/chip-seq-pipeline2

Just to add to @jcotney solution, ENCODE also have a pipeline to produce this data (which could be replicated in nextflow I guess):
https://github.com/ENCODE-DCC/chip-seq-pipeline2

This is exactly what the portion of our pipeline is based on.  I think the current scale factor files that are generated for the igv sessions could be used to apply the value for the "-S" option.  This routine could be added as an option to the overall pipeline with something like --generate-pvalue-bigwig ?

Yes, after reading a little bit my first comment was wrong. Probably we can leave this for the next iteration version 2.1. Ping @drpatelh to know which is his take on this, since it is also true that with version 2.0 of the pipeline it would be possible to tweak the parameters of macs2 callpeak and generate the pvalues tracks outside the pipeline.


layer.conf: Mark master as dunfell (3.1) compatible

Signed-off-by: Codrin Ciubotariu<EMAIL_ADDRESS>Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thank you for your contribution!


Check if upadate is available

Whenever running knowledge-clustering, check if an update is available.
See https://stackoverflow.com/a/62571316/19340201.
Print something like
[notice] A new release of knowledge-clustering is available: [old version | in red] -> [new version | in green]
[notice] To update, run: [python -m pip install --upgrade knowledge-clustering | in green]

Implemented in #1f67853.


Migrate to Material UI v4

Hi,
Material UI v4 has come out a few months ago (https://medium.com/material-ui/material-ui-v4-is-out-4b7587d1e701).
So, please migrate mui-downshift to support Material UI v4.
Currently the following warning is displayed in console when installing a package:
warning "... ><EMAIL_ADDRESS>has incorrect peer dependency "<EMAIL_ADDRESS>warning "... ><EMAIL_ADDRESS>has incorrect peer dependency "<EMAIL_ADDRESS>
Here you can find the migration guide - https://material-ui.com/guides/migration-v3.

See: https://github.com/techniq/mui-downshift/pull/80 and https://github.com/techniq/mui-downshift/pull/83.
I currently don't have the time to do the work myself, and await a PR that does not have errors / regressions.   #83 was getting close but still had some errors.  Most of the discussion was taking place in #80 but the best PR is #83.


Consider BLNS: &'static [&'static str]

With a fixed sized array, adding or removing a string is theoretically a breaking change, e.g. a user could write:
let x: [&str; 484] = BLNS;

and so changing the length would be a breaking change. (That said, I guess this is unlikely to actually happen.)
By instead defining the value as the following the length is no longer part of the type, and so there's no risk at all.
pub const BLNS: &'static [&'static str] = &[...];

This should also allow writing just for x in BLNS { ... } without the iter().

Totally makes sense, I haven't given much thought of that.
Thanks.


Improve ansible playbook documentation

Expand the README.md in ansible with more information about the variables that are used by the playbooks.

LGTM


#fn changed the query to retrieve table information

Description
When retrieving additional information from an Oracle table, the query was modified because of a permissions problem.
Related Issue :
How Has This Been Tested?

create oracle workbench
open scheam browser
see information tab without error

Need additional checks?
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.

Additional Context

run build
deploy to 1

run build
deploy to 1


Supports the $gte $lte operator , and add tests.

Thanks @vampireslove,
I real dont remember How a forgott to use 'lte' and 'gte' :)
More tests are very welcome, as much as new operators.
[]'s


LIME-254 - "or" divider on licence issuer screen displaying as English (Welsh Translation).

Proposed changes
What changed

Welsh translation added for radio button dividers
See:  https://github.com/alphagov/di-ipv-cri-dl-front/pull/78

Why did it change

Translation was not supported prior to this ticket.

Issue tracking

LIME-254

See https://github.com/HMPO/hmpo-components/pull/139


rd

Purpose/implementation Section
What changes are being implemented in this Pull Request?
What was your approach?
What GitHub issue does your pull request address?
Tell potential reviewers what kind of feedback you are soliciting.
New Content Checklist

[ ] New content/chapter is in an Rmd file with this kind of format and headers.

[ ] New content/chapter contains Learning Objectives and are in the correct format.

[ ] Bookdown successfully re-renders and any new content files have been added to the _bookdown.yml.

[ ] Spell check runs successfully in Github actions style-n-check).

[ ] Any newly necessary packages that are needed have been added to the Dockerfile and image.

[ ] Images are in the correct format for rendering.

[ ] Every new image has alt text and is in a Google Slide.

[ ] Each slide is described in the notes of the slide so learners relying on a screen reader can access the content. See https://lastcallmedia.com/blog/accessible-comics for more guidance on this.

[ ] The color palette choices of the slide are contrasted in a way that is friendly to those with color vision deficiencies.
You can check this using Color Oracle.

is it possible to get some details of the error? @cansavvy

This check is not because of anything you did -- it's because of a fix that I deployed related to other improvements to OTTR. I just filed a PR that should address the problem.
For future reference, you can click on the Details button on any check and it will give you more information about the check and how it failed.


Solve icon props issue to not pass template string as a value.

Iconify props icon only accepts string so when I want to show conditional icons that time I use template string but It gives me an error:
'props' must be a string literal.
So I check the code and simply change the props to get string or template strings as props.
I changed src/Iconify.tsx file and add  TemplateStringsArray as a Iconify icon props.

You cannot assign varible to ‘icon’ prop.
https://github.com/oktaysenkan/react-native-iconify?tab=readme-ov-file#iconify-icon-prop-must-be-a-string-literal

What about the conditional rendering icons, every time I need to write the same multilines code?

Can you share the code? I would help you.


Testcafe fails to restart browser after encountering chrome error code 5

What is your Scenario?
When automating our code in development we sometimes run into different error codes (like chrome error code 5) and TestCafe doesn't appear to handle them properly.  The test in question basically just hangs and when running it via CircleCI it either hits the run timeout or kills the job eventually since it doesn't know how to handle it.
What is the Current behavior?
It would be nice if we can catch chrome errors that do make it impossible to continue the test and then be able to handle them accordingly (like restarting the browser).
What is the Expected behavior?
Based upon the documentation it mentions that "If a browser stops responding during test execution, TestCafe restarts the browser and reruns the current test in a new browser instance."
This doesn't appear to occur so the chrome window hangs until eventually a timeout is hit.
What is your public website URL? (or attach your complete example)
We can run through it together if necessary.
What is your TestCafe test code?
The request is mainly to handle the errors so I'm not sure how much this will help.
test
  .meta({ created_on: '04/13/22', created_by: 'Justin Grabenbauer', updated_on: '', updated_by: '' })
  .meta({ scope: 'regression', priority: 'low', showstopper: '', github_ID: '723' })
  .after( async t => {
    await ThemesPageObjects.edit_theme_name(t.ctx.updated_theme, t.ctx.default_theme)
    await HelperObjects.wait_for_flash_alert()
  })
  ('user_can_edit_theme_name', async t => {

    // Purpose: To verify that a theme name can be edited.

    t.ctx.default_theme = 'Dnd - change theme name'
    const default_theme = t.ctx.default_theme
    t.ctx.updated_theme = 'Dnd - updated theme name'
    const updated_theme = t.ctx.updated_theme

    await WorkspaceMainNavPageObjects.navigate_to_workspace_settings()
    await SettingsPageObjects.navigate_to_themes_page()

    if (await Selector('td').withText(updated_theme).visible == true) {
      await ThemesPageObjects.edit_theme_name(updated_theme, default_theme)
      await HelperObjects.wait_for_flash_alert()
    }

    await ThemesPageObjects.edit_theme_name(default_theme, updated_theme)
    await HelperObjects.wait_for_flash_alert()

    await t
      .expect(Selector('td').withText(updated_theme).visible).ok()
})

Your complete configuration file
require('dotenv').config()
const CustomRequestHooks = require('./pom/custom_request_hooks')

// Agnostic for all environments
let skipped_tests = [

    // Located in apps_page_tests.js
    'user_cannot_access_sites_when_feature_is_disabled', // 07-28-22
    'user_cannot_access_settings_when_feature_is_disabled', // 07-28-22

    // Located in billing_page_tests.js
    'user_can_navigate_to_billing_page', // 08-22-22

    // Located in blog_page_tests.js
    'user_can_add_a_gif_to_blog', // 08-16-22
    'user_can_create_a_blog_post', // 08-04-22
    'user_can_edit_blog_settings', // 07-06-22

    // Located in clean_up_scripts.js
    'clean_up_copies_of_funnels',
    'clean_up_copies_of_funnel_pages',
    'clean_up_copies_of_pages',
    'clean_up_products',
    'clean_up_site_pages',
    'clean_up_workflows',
    'dismiss_notifications',
    'clean_up_collaborators',

    // Located in collaborators_page_tests.js
    'user_can_navigate_to_collaborators_page', // 07-21-22

    // Located in the collections_page_tests.js
    'user_can_navigate_to_collections_page',

    // Located in courses_page_tests.js
    'optin_user_can_navigate_through_course', // 06-07-22
    'manually_added_user_can_navigate_through_course', // 06-07-22
    'user_can_update_courses_lesson_path',
    'user_can_update_courses_module_path',
    'newly_enrolled_user_receives_verification_email',
    'user_can_log_into_customer_center_with_magic_link',
    'courses_back_button_navigates_to_previous_page',
    'user_can_preview_existing_course',

    // Located in funnels_page_tests.js
    'user_can_create_a_new_funnel', // 08-04-22
    'user_can_clone_a_funnel',
    'user_can_navigate_through_funnel',
    'page_views_and_unique_views_values_are_correct', // 05-31-22

    // Located in funnel_workflow_builder_page_tests.js
    'user_is_able_to_remove_a_node', // 05-31-22
    'user_can_add_and_remove_a_decision_path', // 05-31-22
    'user_is_able_to_add_and_remove_a_product_from_funnel', //08-04-22
    'user_can_add_and_remove_a_split_test', // 05-31-22
    'user_can_add_a_new_workflow', // 08-04-22
    'user_can_add_an_existing_workflow', // 08-04-22

    // Located in inventory_page_tests.js
    'user_can_navigate_to_inventory_page', //08/30/22

    // Located in logout_page_tests.js
    'user_can_logout_from_settings_page', // 06-08-22

    // Located in marketing/broadcasts_page_tests.js
    'user_can_create_new_broadcast', // 06-20-22

    // Located in marketing/templates_page_tests.js
    'user_can_create_broadcast_template', // 06-13-22

    // Located in orders/order_page_tests.js
    'user_can_partially_fulfill_order', // 08/11/22

    // Located in pages_page_tests.js
    'user_can_filter_page_types_with_tabs', // 05/27/22
    'user_can_pin_a_page_from_edit_page', //07-29-22

    // Located in reporting_page_tests.js
    'opt-ins_by_landing_page_report_displays', // 06/21/22

    // Located in sites_overview_page_tests.js
    'user_can_add_header_to_site', // 07-06-22

    // Located in themes_page_tests.js
    'user_can_edit_theme_name', // 08-08-22

    // Located in top_main_nav_page_tests.js
    'clicking_notifications_will_open_notifications_alert', // 06/01/22

    // Located in workflows_page_tests.js
    'user_can_create_a_workflow', // 08-23-22
    'user_can_restore_an_archived_workflow' // 08-23-22
]

// Production specific scripts needing to be skipped for various reasons
let production_skipped_tests = [
    'user_can_navigate_to_order_tags_page', // Link disabled through Launch Darkly as of 08/29/22
    'user_can_navigate_to_payments_ai_dashboard', // Production PAI account not set up as of 08/29/22
    'user_is_able_to_navigate_to_the_inbox_page' // Inbox link is not activated in production as of 08/31/22
]

// Scripts that need to run with a single concurrency
let isolated_tests = [
    // Located in sites_overview_page_tests.js
    'user_can_make_site_public',
    'user_can_edit_site_name',
    'user_can_make_site_password_protected',
    'user_can_make_site_private',
    'user_can_edit_site_domain',
    'changing_site_domain_updates_funnel_urls',
    'changing_site_domain_updates_blog_urls',
    'changing_site_domain_updates_course_urls',
    'user_can_add_header_to_site',

    // Located in account_details_page_tests.js
    'user_can_edit_account_name',
    'user_can_edit_account_password',
    'user_can_change_account_language',

    // Located in general_page_tests.js
    'user_can_edit_workspace_details',

    // Located in blog_page_tests.js
    'user_can_edit_blog_settings',

    // Located in themes_page_tests.js
    'user_can_promote_theme_to_live_from_index_page',
    'user_can_promote_theme_to_live_from_overview_page'
]

// Scripts specific for Applitools integration
let visual_tests = [
    // Located in dashboard_checks.js
    'applitools_check_on_dashboard',

    // Located in editor_checks.js
    'applitools_check_in_editor',
    'user_is_able_to_change_the_checkout_element_style',

    // Located in login_checks.js
    'applitools_check_on_login_page_with_magic_link',
    'applitools_check_on_login_page_with_password'
]

// Filter that joins the skipped scripts with the production skipped tests
let production_filter = skipped_tests.concat(production_skipped_tests)

// Filter that joins ALL filtered scripts so that they are not run for a full suite
let full_filter = skipped_tests.concat(isolated_tests).concat(visual_tests)

let build_filter = () => {

    // Purpose: To set the suite that we want to run. (isolated, regression, sanity)

    var filter = {}

    switch(process.env.ENV) {
        case 'production':
            if(process.env.SCOPE) {
                filter = {
                    testGrep: `^(?!.*(${production_filter.join('|')})).*$`,
                    testMeta: {
                        scope: process.env.SCOPE
                    }
                }
            }
            break
        case 'staging':
            if(process.env.SCOPE) {
                filter = {
                    testGrep: `^(?!.*(${skipped_tests.join('|')})).*$`,
                    testMeta: {
                        scope: process.env.SCOPE
                    }
                }
            } else {
                filter = {
                    testGrep: `^(?!.*(${full_filter.join('|')})).*$`
                }
            }
            break
    }

    return filter
}

let determine_concurrency = () => {

    // Purpose: To set concurrency dependant on the scope that is passed

    let concurrency = 5
    if (process.env.SCOPE == 'isolated') {
        concurrency = 1
    }
    return concurrency
}

module.exports = {
    assertionTimeout: 5000,
    browsers: [
        "chrome:headless --window-size=1920,1159 --allow-insecure-localhost"
    ],
    concurrency: determine_concurrency(),
    cache: true,
    clientScripts: [
        "scripts/hide_notifications.js",
        "scripts/click_expand_all_for_courses_details_page.js"
    ],
    disableMultipleWindows: true,
    filter: build_filter(),
    hooks: {
        request: CustomRequestHooks
    },
    hostname: "localhost",
    pageLoadTimeout: 30000,
    quarantineMode: {
        successThreshold: 1,
        attemptLimit: 2
    },
    reporter: [
        {
            name: "spec",
            output: "artifacts/reports/spec_results"
        },
        {
            name: "xunit",
            output: "artifacts/reports/xunit_results.xml"
        },
        {
            name: "testrail"
        }
    ],
    runExecutionTimeout: 1800000,
    screenshots: {
        path: "artifacts/screenshots",
        pathPattern: "${TEST}_${DATE}_${TIME}.png",
        takeOnFails: true,
        thumbnails: false
    },
    selectorTimeout: 5000,
    skipJsErrors: true,
    skipUncaughtErrors: true,
    src: "tests/**",
    ssl: {
        pfx: "ssl/testingdomain.pfx",
        rejectUnauthorized: true
    },
    testExecutionTimeout: 240000,
    videoEncodingOptions: {
        aspect: "16:9",
        framerate: 30
    },
    videoOptions: {
        failedOnly: true,
        pathPattern: "${TEST}_${DATE}_${TIME}.mp4",
        singleFile: false
    },
    videoPath: "artifacts/recordings"
}

Your complete test report
Running tests in:
 - Chrome <IP_ADDRESS> / Monterey 12

 settings - themes
 ✖ user_can_edit_theme_name (screenshots: /Users/justingrabenbauer/cf2-test-cafe-poc/artifacts/screenshots/user_can_edit_theme_name_2022-09-08_11-23-30.png)

   1) The specified selector does not match any element in the DOM tree.

         | Selector('input')
         |   .withAttribute('data-testid', 'theme_custom_name')

      Browser: Chrome <IP_ADDRESS> / macOS 10.15.7
      Screenshot: /Users/justingrabenbauer/cf2-test-cafe-poc/artifacts/screenshots/user_can_edit_theme_name_2022-09-08_11-23-30.png

         28 |        // Param: updated_theme_name - String - the updated theme name
         29 |
         30 |        await t
         31 |            // Once the theme search works then we can just search and click the visible 'a' for theme-settings
         32 |            .click(Selector('td').withText(theme_name).sibling('td').find('a').withAttribute('data-testid', 'theme-settings'))
       > 33 |            .typeText(this.txt_field_theme_name, updated_theme_name, { replace: true, paste: true })
         34 |            .click(this.btn_update_theme)
         35 |    }
         36 |
         37 |    async click_theme_image(theme_name) {
         38 |

         at <anonymous> (/Users/justingrabenbauer/cf2-test-cafe-poc/pom/settings/themes/themes_page_repo.js:33:14)
         at asyncGeneratorStep (/Users/justingrabenbauer/cf2-test-cafe-poc/pom/settings/themes/themes_page_repo.js:1:285)
         at _next (/Users/justingrabenbauer/cf2-test-cafe-poc/pom/settings/themes/themes_page_repo.js:1:623)
         at <anonymous> (/Users/justingrabenbauer/cf2-test-cafe-poc/pom/settings/themes/themes_page_repo.js:1:788)
         at <anonymous> (/Users/justingrabenbauer/cf2-test-cafe-poc/pom/settings/themes/themes_page_repo.js:1:529)
         at ThemesPageObjects.edit_theme_name (/Users/justingrabenbauer/cf2-test-cafe-poc/pom/settings/themes/themes_page_repo.js:24:59)
         at <anonymous> (/Users/justingrabenbauer/cf2-test-cafe-poc/tests/settings/themes_page_tests.js:161:31)
         at asyncGeneratorStep (/Users/justingrabenbauer/cf2-test-cafe-poc/tests/settings/themes_page_tests.js:10:315)
         at _next (/Users/justingrabenbauer/cf2-test-cafe-poc/tests/settings/themes_page_tests.js:10:653)

   2) - Error in test.after hook -
      The specified selector does not match any element in the DOM tree.

         | Selector('input')
         |   .withAttribute('data-testid', 'theme_custom_name')

      Browser: Chrome <IP_ADDRESS> / macOS 10.15.7
      Screenshot: /Users/justingrabenbauer/cf2-test-cafe-poc/artifacts/screenshots/user_can_edit_theme_name_2022-09-08_11-23-30.png

         28 |        // Param: updated_theme_name - String - the updated theme name
         29 |
         30 |        await t
         31 |            // Once the theme search works then we can just search and click the visible 'a' for theme-settings
         32 |            .click(Selector('td').withText(theme_name).sibling('td').find('a').withAttribute('data-testid', 'theme-settings'))
       > 33 |            .typeText(this.txt_field_theme_name, updated_theme_name, { replace: true, paste: true })
         34 |            .click(this.btn_update_theme)
         35 |    }
         36 |
         37 |    async click_theme_image(theme_name) {
         38 |

         at <anonymous> (/Users/justingrabenbauer/cf2-test-cafe-poc/pom/settings/themes/themes_page_repo.js:33:14)
         at asyncGeneratorStep (/Users/justingrabenbauer/cf2-test-cafe-poc/pom/settings/themes/themes_page_repo.js:1:285)
         at _next (/Users/justingrabenbauer/cf2-test-cafe-poc/pom/settings/themes/themes_page_repo.js:1:623)
         at <anonymous> (/Users/justingrabenbauer/cf2-test-cafe-poc/pom/settings/themes/themes_page_repo.js:1:788)
         at <anonymous> (/Users/justingrabenbauer/cf2-test-cafe-poc/pom/settings/themes/themes_page_repo.js:1:529)
         at ThemesPageObjects.edit_theme_name (/Users/justingrabenbauer/cf2-test-cafe-poc/pom/settings/themes/themes_page_repo.js:24:59)
         at <anonymous> (/Users/justingrabenbauer/cf2-test-cafe-poc/tests/settings/themes_page_tests.js:145:29)
         at asyncGeneratorStep (/Users/justingrabenbauer/cf2-test-cafe-poc/tests/settings/themes_page_tests.js:10:315)
         at _next (/Users/justingrabenbauer/cf2-test-cafe-poc/tests/settings/themes_page_tests.js:10:653)
         at <anonymous> (/Users/justingrabenbauer/cf2-test-cafe-poc/tests/settings/themes_page_tests.js:10:818)

 1/1 failed (40s)

 Warnings (2):
 --
  The "browsers", "concurrency", and "filter" options from the configuration file will be ignored.
 --
  The file at "/Users/justingrabenbauer/cf2-test-cafe-poc/artifacts/screenshots/user_can_edit_theme_name_2022-09-08_11-23-30.png" already exists. It has just been rewritten with a recent screenshot. This situation can possibly cause issues. To avoid them, make sure that each screenshot has a unique path. If a test runs in multiple browsers, consider including the user agent in the screenshot path or generate a unique identifier in another way.

Screenshots
https://www.loom.com/share/fc77538c41ab489590fc937ec3e3b827
Steps to Reproduce

Run the test (with me on a call if that's fine)
Verify that the chrome error 5 has occurred

TestCafe version
1.20.1
Node.js version
16.4.0
Command-line arguments
ENV=staging testcafe "chrome '--window-size=1920,1159'" -t 'user_can_edit_theme_name' -c1
Browser name(s) and version(s)
Chrome <IP_ADDRESS>
Platform(s) and version(s)
Monterey 12.5
Other
No response

The automatic browser restart mechanism works only when TestCafe retains control over the browser process. Error code 5 is a different case. With such an error, control over the browser is lost.
Therefore, the best thing we can do is try to find out why the browser is down.
Would you please clarify it this behavior is reproduced during manual testing or only with the help of TestCafe?
If the former, then we will not be able to help. If this happens only with TestCafe, then we need an example to help us understand the problem.


Colour Tags detector

Add colour: building:colour and roof:colour to Issue detector to detect missing # sign on 3 or 6 digit hex value.

@guylamar2006 We don't have great field-level validation right now but once we have that and #6037 we can do this.

can this also be #2836?

can this also be #2836?

I see that as the general mechanism and this as a specific case that could be done separately, but either way I suppose.


LUT makes scene turns completely black on Samsung Galaxy S7

Color grading demo on Samsung Galaxy S7 (exynos) using Google Chome, only LUTs with prefix png/ are working as intended.
Other LUT types like neutral- or cube/ makes the scene turns completely black.
I have to tick both 3D texture and tetrahedral filter to make all LUT types work.
The document stated: Tetrahedral interpolation produces highly accurate results, but is slower than hardware interpolation so I'm hesitated to this config because I need to get the most out of performance.
(The default config working fine on Galaxy S20 exynos, the problem only occurs on S7)

Thanks for the report.
The S7 doesn't seem to support FloatType textures which the cube/3dl and neutral LUTs use by default. You can convert these textures into UnsignedByteType textures via LookupTextured3D.convertToUint8().
I'll add checks for OES_texture_float and OES_texture_float_linear to the demo to make it more robust.


Best way to embed to be able to send/receive messages by embedding application

First of, good work on your project!
I'm using your moquette implementation in a project of mine and are embedding it. But, I'm not able to find a method so that i'm able to embed it in such a way my server application is receiving the messages and my server application can inject messages to be send out.
Currently i'm putting code of mine inside your code (custom listener implementations) to be able to receive the messages and inject qos0 message to be send out.
Is there an object living somewhere where i can register a listener to receive messages from clients and post my messages to to be broadcasted?
Next to this, authentication (if possible) should be handled by my app as also the certificate handling.
If not, can this then be handled as a feature request?
Cheers,
John.

Hi John
at the moment Moquette provides a mechanism (interceptor) to intercept
certain king of events,but you can't inject.
The interceptors are registered by configuration providing the class name,
this pat of Moquette is not completely developed, so any suggestions could
help.
You should open a feature request, providing more details possibles on the
request.
Thanks a lot
Andrea
On Tue, Oct 13, 2015 at 2:53 PM, johnsirach<EMAIL_ADDRESS>wrote:

First of, good work on your project!
I'm embedding your moquette implementation in a project of mine and are
embedding it. But, I'm not able to find a method so that i'm able to embed
it in such a way my server application is receiving the messages and my
server application can inject messages to be send out.
Currently i'm putting code of mine inside your code (custom listener
implementations) to be able to receive the messages and inject qos0 message
to be send out.
Is there an object living somewhere where i can register a listener to
receive messages from clients and post my messages to to be broadcasted?
If not, can this then be handled as a feature request?
Cheers,
John.
—
Reply to this email directly or view it on GitHub
https://github.com/andsel/moquette/issues/110.

Currently i have quite a dirty method with a custom listener inside ProtocolProcessor which
called with (quick write)
SimpleMessaging.getInstance().getProcessor().addExternalListener(this);
and is handled with a
handleFromBroker(String clientId, String topic, ByteBuffer message);
And injecting messages is done with (replaced the vars):
                PublishMessage message = new PublishMessage();
                message.setTopicName(new StringBuilder("/hooks/devices/")
                                        .append(device.getId())
                                        .append("/")
                                        .append("groupname")
                                        .append("/")
                                        .append("controlname").toString());
                message.setRetainFlag(false);
                message.setQos(AbstractMessage.QOSType.MOST_ONE);
                message.setPayload(ByteBuffer.wrap(somebytes));
                SimpleMessaging.getInstance().getProcessor().processInternalPublish(message);

processInternalPublish hands it over to the publisher.
It's a quick and dirty, but it works, it is running for months now, and it's time for updating, so was hoping there was a mechanism in place.
P.S. not seeing an enhancement option, am i blind or.....
It would then be multiple enhancements by the way. To correctly embed moquette I should be able to pass certs from the server's key store (which my users create to run ssl connections already running on the server) where moquette is being embedded in and take over/implement auth mechanisms

Hi John
I've just a question, if I well understood you need some "signalling
mechanism" of a publish received, you apply some logic. Then there other
cases where you need to publish a message, but for publish you could use a
local client connected to the broker that actually do the publishing stuff.
Instead, if you need a mechanism to "host" code executed inside the
broker, then it's a more complex scenario, because the broker is an
autonomous system that is run on top of Netty's event loops. If we need
such a plug system, problably (this is planned) the broker need to use some
observer/observable concept that don't break the threading (the rule is
don't stop the event loop with long synchronous operations), I mean that I
would use RxJava or Reactor for this job, because the broker can't trust
the client code to starve in JDBC connections or such long running tasks.
What do you think?
Andrea
On Wed, Oct 14, 2015 at 11:59 PM, johnsirach<EMAIL_ADDRESS>wrote:

Currently i have quite a dirty method with a custom listener inside
ProtocolProcessor which
called with (quick write)
SimpleMessaging.getInstance().getProcessor().addExternalListener(this);
and is handled with a
handleFromBroker(String clientId, String topic, ByteBuffer message);
And injecting messages is done with (replaced the vars):
            PublishMessage message = new PublishMessage();
            message.setTopicName(new StringBuilder("/hooks/devices/")
                                    .append(device.getId())
                                    .append("/")
                                    .append("groupname")
                                    .append("/")
                                    .append("controlname").toString());
            message.setRetainFlag(false);
            message.setQos(AbstractMessage.QOSType.MOST_ONE);
            message.setPayload(ByteBuffer.wrap(somebytes));
            SimpleMessaging.getInstance().getProcessor().processInternalPublish(message);

processInternalPublish hands it over to the publisher.
It's a quick and dirty, but it works, it is running for months now, and
it's time for updating, so was hoping there was a mechanism in place.
P.S. not seeing an enhancement option, am i blind or.....
It would then be multiple enhancements by the way. To correctly embed
moquette I should be able to pass certs from the server's key store (which
my users create to run ssl connections already running on the server) where
moquette is being embedded in and take over/implement auth mechanisms
—
Reply to this email directly or view it on GitHub
https://github.com/andsel/moquette/issues/110#issuecomment-148215362.

Yes, you are correct, having Reactor for this would be a nice solution for handling messages received, currently data is being "copied" and passed to the server receiving thread to stay out of the broker's way as much as possible and without references. If this can be replaced by a more proven and more robust way everyone profits from, why not.
For me personally, and maybe also for others embedding moquette it would be very nice to have a mechanism to inject messages, certificates and handle the authentication.
Moquette is now serving messages from my system almost immediately from the internal event bus  with only translation to a /hook/#/# topic and a semantic topic like /home/floor/room/#/# standing in between.
My eventually feature requests would then be:
1: Possibility to supply certificates for ssl (from my code)
2: Possibility to listen for published and possibility to inject messages (from my code)
3: Handle the authorization. (also from my code)
What is the best way, do three feature requests, or just one as "Enhancing moquette embedding" ?

Hi John,
the best is to create 3 feature request.
I don't understand very well what you mean "supply certificates for ssl"?
Do you mean that at runtime you need to add certificates, or just to set
your certificate at broker bootstrap (as it does loading from filesystem)
but provided by you in some fashion (perchaph byte[] I suppose)
Thanks
Andrea
On Thu, Oct 15, 2015 at 2:11 PM, johnsirach<EMAIL_ADDRESS>wrote:

Yes, you are correct, having Reactor for this would be a nice solution for
handling messages received, currently data is being "copied" and passed to
the server receiving thread to stay out of the broker's way as much as
possible and without references. If this can be replaced by a more proven
and more robust way everyone profits from, why not.
For me personally, and maybe also for others embedding moquette it would
be very nice to have a mechanism to inject messages, certificates and
handle the authentication.
Moquette is now serving messages from my system almost immediately from
the internal event bus with only translation to a /hook/#/# topic and a
semantic topic like /home/floor/room/#/# standing in between.
My eventually feature requests would then be:
1: Possibility to supply certificates for ssl (from my code)
2: Possibility to listen for published and possibility to inject messages
(from my code)
3: Handle the authorization. (also from my code)
What is the best way, do three feature requests, or just one as "Enhancing
moquette embedding" ?
—
Reply to this email directly or view it on GitHub
https://github.com/andsel/moquette/issues/110#issuecomment-148368026.

I will do three requests then.
With supplying the certificate it would be nice to have the possibility to supply a loader like (very abstract) moquette->setCertificateLoader(MyLoader);

I close the issue because splitted in 3 feature request (#133, #114 , #115)


FFI for PEP 590 Vectorcall

https://www.python.org/dev/peps/pep-0590/
This was tested on 3.7 using _PyCFunctionFast and 3.8
using PyObject_Vectorcall. Extending pyo3-derive-backend
to generate code using vectorcall is not done here.
This exposes PyObject_Vectorcall with a link_name to the
underscored name on 3.8 because it is expected to be stabilized
on 3.9.
This fixes the "fast" objects being new in 3.7, not 3.6.

Thanks!
Vectorcall looks really nice and I want to use it in PyO3 internally in the future.


[DARGA] Updated translation catalogs from Zanata

@chessbyte I made few french corrections, can you merge it for 5.6.2. Thanks


NPM dependencies

Why we can't have any NPM dependency in our custom template? I think this feature is required.

Your question is not clear, can you provide more details?

@LinusBorg this is not question, this is almost requesting a require feature.
See this repo: https://github.com/elegantweb/nwjs-vue
Try to install it using vue init elegantweb/nwjs-vue
You will see it says: string module not found or something similar.
This is cause we can't have any npm dependency in our package.json file this means vue-cli doesn't run npm install over template.

He wants to use custom packages in the meta.js https://github.com/elegantweb/nwjs-vue/blob/master/meta.js#L1
I remember it was for security reasons. We don't want a malicious template to mess up someone's computer because of a package they require

@posva Yes, exactly, but security reasons? really?
1- If anyone wants to mess up, he can do even with pure node.
2- I don't think people will run vue with administration privileges (sudo).
So the security is not good reason at all.

😆  never make assumptions about what people will or will not do in security. People will always do what you expect less, especially dumb things like running a command with sudo when they shouldn't

@posva Yes, but security reason doesn't work here :D I think we have to add this feature, this is required.

We'll come up with something for next version (see #589 ), but the current model of vue-cli makes this not secure


Refactor command class

Codecov Report

Merging #44 (08d0add) into beta (786fdee) will not change coverage.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##              beta       #44    +/-   ##
==========================================
  Coverage   100.00%   100.00%
==========================================
  Files           20         8    -12
  Lines          590       106   -484
  Branches        82        14    -68
==========================================
- Hits           590       106   -484

Impacted Files
Coverage Δ

lib/PathCommand/constants.ts
100.00% <100.00%> (ø)

lib/PathCommand/index.ts
100.00% <100.00%> (ø)

lib/PathCommand/utils/index.ts
100.00% <100.00%> (ø)

lib/PathCommand/utils/isValidCommandType.ts
100.00% <100.00%> (ø)

lib/PathCommand/utils/isValidPathCommandParams.ts
100.00% <100.00%> (ø)

lib/PathCommandList/index.ts
100.00% <100.00%> (ø)

lib/index.ts
100.00% <100.00%> (ø)

lib/parser/index.ts
100.00% <100.00%> (ø)


Feature request: linting workflow

I have recently started using micro.publish to publish to micro.blog more often, and I ran into an issue I'm hoping you could help with.

I use a plugin to pull scripture quotations into blockquotes, although this could happen with vanilla Obsidian.
The plugin labels the blockquotes (Obsidian calls these callouts).
Micro.blog supports block quotes but not callouts—they are supported in a newer version of Hugo, but I don't know when that will be implemented (I've been on the micro.blog forum about this as well).

One solution for me would be to simply run a linter or regex to remove the labels from blockquotes before posting—I use both the Linter and Regex Pipeline plugins. If there was a way I could trigger either of those automatically as part of my publishing workflow, that would be boffo.
I may already be able to do this with the Commander plugin or anything that lets me define Obsidian macros or workflows—I may even be able to do it with Templater, since that lets me run Javascript code. (I'm in IT, but I know only rudimentary JavaScript.)
Judging from your blog, this has been an eventful year, and Obsidian didn't make it into your December 2024 defaults. If you could find time to do this, I'd buy you several cups of coffee. ☕

Update: I learned that the Commander plugin supports simple macros, and I created one to do the following:

Run a series of regex replacements via the Regex Rulesets plugin

Remove level 1 header (I use the post/page title instead)
Remove %% comments
Remove labels on blockquotes/callouts (these are supported in the most recent version of Hugo, but I haven't tweaked my post styling to take advantage of that yet).

pause one second
Publish post via micro.publish
pause one second
Undo edits (one undo restores everything removed in the first step)

I discovered that the undo step worked fine when I ran the process manually, but it didn't work properly in the macro. I added the pauses, and that fixed the problem—likely the publish and undo steps were colliding. I did notice that the undo step executes while I'm still in the micro.publish dialogue, but the post still publishes correctly. The plugin must dump the text into a buffer which isn't affected by the undo command.
I'd still love to have the ability to preprocess text before publishing, but using Commander and Regex Rulesets allows me to do what I need and probably gives me more flexibility than preprocessing native to the micro.publish plugin would.

Oops. Meant to click "Close with comment".


[LI-HOTFIX] Use JFrog Api key instead of password

TICKET = N/A
LI_DESCRIPTION = DEPENG-2065.
This is advised by dep engineering
EXIT_CRITERIA = When not using JFrog for publishing

The new secret has been created.


Refactor Semantic-MathML and Semantic-Collapse

This moves the MakeMML call from Semantic-Collapse to Semantic-MathML so that the enrichment is done completely by Semantic-MathML.  The rest of Semantic-Collapse is broken into two parts:  Semantic-Complexity, which does the complexity computations and adds the mactions based on that, and Semantic-Collapse, which does the automatic collapsing based on container width.  All three actions can be enabled and disabled separately (though the latter ones rely on the former ones, so disabling an earlier phase effectively disables the later ones).
I've updated the lab pages to configure the new features, and cleaned up some of the code there (in particular, the getting and setting of the options).

I'll have to fix the conflicts with the accessibility_menu PR that I just merged.

OK, it should be ready to merge, now.

I think I just screwed that up by merging PR #75.

The Struik example is now not working anymore. I assume that has to do with the option
SemanticCollapse: {autoCollapse: true},
no longer exists.
Btw., in TeX.html and MathML.html is a misspelled option:
AssistiveMML: {diabled: true},
That never seemed ot have made a difference...

in TeX.html and MathML.html is a misspelled option:
AssistiveMML: {diabled: true},
That never seemed ot have made a difference...

Thanks.  I'll fix it.  Turning off AssistiveMML was just because it was not needed for theses tests.  Leaving it enabled isn't a problem (just takes a bit longer to process).

The Struik example works for me (I did remove the unwanted configuration, though that should not have prevented it from working).  Can you test again with the updates to see if you still have trouble?  Remember to clear cache first.

I have made the other changes you suggested, so I'm ready for another review, or a merge.

Removed two merge conflicts. O/w lgtm.

Thanks.


Project No Longer Builds

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
18.12.1
Amplify CLI Version
10.7.1
What operating system are you using?
MacOS
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No.
Describe the bug
Updated package.json file. Previously working application now does not build.
Error: node_modules/@aws-sdk/util-retry/dist-types/AdaptiveRetryStrategy.d.ts:1:20 - error TS2305: Module '"@aws-sdk/types"' has no exported member 'RetryErrorInfo'.

1 import { Provider, RetryErrorInfo, RetryStrategyV2, RetryToken, StandardRetryToken } from "@aws-sdk/types";
                     ~~~~~~~~~~~~~~

Error: node_modules/@aws-sdk/util-retry/dist-types/AdaptiveRetryStrategy.d.ts:1:36 - error TS2724: '"@aws-sdk/types"' has no exported member named 'RetryStrategyV2'. Did you mean 'RetryStrategy'?

1 import { Provider, RetryErrorInfo, RetryStrategyV2, RetryToken, StandardRetryToken } from "@aws-sdk/types";
                                     ~~~~~~~~~~~~~~~

Error: node_modules/@aws-sdk/util-retry/dist-types/AdaptiveRetryStrategy.d.ts:1:53 - error TS2305: Module '"@aws-sdk/types"' has no exported member 'RetryToken'.

1 import { Provider, RetryErrorInfo, RetryStrategyV2, RetryToken, StandardRetryToken } from "@aws-sdk/types";
                                                      ~~~~~~~~~~

Error: node_modules/@aws-sdk/util-retry/dist-types/AdaptiveRetryStrategy.d.ts:1:65 - error TS2305: Module '"@aws-sdk/types"' has no exported member 'StandardRetryToken'.

1 import { Provider, RetryErrorInfo, RetryStrategyV2, RetryToken, StandardRetryToken } from "@aws-sdk/types";
                                                                  ~~~~~~~~~~~~~~~~~~

Error: node_modules/@aws-sdk/util-retry/dist-types/StandardRetryStrategy.d.ts:1:20 - error TS2305: Module '"@aws-sdk/types"' has no exported member 'RetryErrorInfo'.

1 import { Provider, RetryErrorInfo, RetryStrategyV2, StandardRetryToken } from "@aws-sdk/types";
                     ~~~~~~~~~~~~~~

Error: node_modules/@aws-sdk/util-retry/dist-types/StandardRetryStrategy.d.ts:1:36 - error TS2724: '"@aws-sdk/types"' has no exported member named 'RetryStrategyV2'. Did you mean 'RetryStrategy'?

1 import { Provider, RetryErrorInfo, RetryStrategyV2, StandardRetryToken } from "@aws-sdk/types";
                                     ~~~~~~~~~~~~~~~

Error: node_modules/@aws-sdk/util-retry/dist-types/StandardRetryStrategy.d.ts:1:53 - error TS2305: Module '"@aws-sdk/types"' has no exported member 'StandardRetryToken'.

1 import { Provider, RetryErrorInfo, RetryStrategyV2, StandardRetryToken } from "@aws-sdk/types";

Expected behavior
Application should build.
Reproduction steps

updated package.json file with npm update -g npm-check-upgrades
run ng build

Project Identifier
project identifier: 57d9c35c7fe718a21c0bb7bab86f4f1b
Log output

# Put your logs below this line

Additional information
package.json file is listed below:
{
  "name": "elyc-online",
  "version": "0.0.0",
  "scripts": {
    "ng": "ng",
    "start": "ng serve",
    "build": "node --max_old_space_size=8196 node_modules/@angular/cli/bin/ng build",
    "test": "ng test",
    "lint": "ng lint",
    "e2e": "ng e2e"
  },
  "browser": {
    "crypto": false
  },
  "private": true,
  "dependencies": {
    "@angular-material-extensions/password-strength": "^12.0.2",
    "@angular/animations": "^15.0.3",
    "@angular/cdk": "^15.0.1",
    "@angular/common": "^15.0.3",
    "@angular/compiler": "^15.0.3",
    "@angular/core": "^15.0.3",
    "@angular/forms": "^15.0.3",
    "@angular/material": "^15.0.1",
    "@angular/platform-browser": "^15.0.3",
    "@angular/platform-browser-dynamic": "^15.0.3",
    "@angular/router": "^15.0.3",
    "@aws-amplify/api-graphql": "^3.0.5",
    "@aws-amplify/cli": "^10.7.2",
    "@aws-amplify/core": "^5.0.14",
    "@aws-amplify/ui-angular": "^3.2.7",
    "@aws-sdk/client-cognito-identity-provider": "^3.267.0",
    "@aws-sdk/client-s3": "^3.267.0",
    "@aws-sdk/s3-request-presigner": "^3.267.0",
    "@aws-sdk/types": "3.267.0",
    "@stripe/stripe-js": "^1.46.0",
    "@types/stripe-checkout": "^1.0.4",
    "@types/stripe-v3": "^3.1.27",
    "aws-amplify": "^5.0.14",
    "aws-amplify-angular": "^6.0.60",
    "aws-rum-web": "^1.12.0",
    "hammerjs": "^2.0.8",
    "libphonenumber-js": "^1.10.14",
    "rxjs": "^7.6.0",
    "stripe": "^11.2.0",
    "tslib": "^2.4.1",
    "zone.js": "~0.12.0"
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "^15.0.2",
    "@angular/cli": "^15.0.2",
    "@angular/compiler-cli": "^15.0.3",
    "@angular/language-service": "^15.0.3",
    "@types/jasmine": "^4.3.1",
    "@types/jasminewd2": "^2.0.10",
    "@types/node": "^18.11.11",
    "codelyzer": "^6.0.2",
    "jasmine-core": "^4.5.0",
    "jasmine-spec-reporter": "^7.0.0",
    "karma": "^6.4.1",
    "karma-chrome-launcher": "^3.1.1",
    "karma-coverage-istanbul-reporter": "^3.0.3",
    "karma-jasmine": "^5.1.0",
    "karma-jasmine-html-reporter": "^2.0.0",
    "mock-amplify-auth": "^2.2.0",
    "protractor": "~7.0.0",
    "schematics-scss-migrate": "^1.3.15",
    "ts-node": "~10.9.1",
    "tslint": "~5.20.1",
    "typescript": "~4.8.4"
  }
}

Before submitting, please confirm:

[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

Hey @ianfmc :wave: thanks for raising this! I'm going to transfer this over to our JS repo for better assistance


childNode.data is undefined

I'm testing the client version from Chrome, using jQuery:
Sometimes this line doesn't work because .data is undefined.
        childNode.data = doThis(childNode.data, childNode);

When it happens everything fails.

Fixed in #28.

#28 was merged and this should be fixed. Closing for now.


New packaging org

Warning

Code to deploy in new packaging org
Quick Actions removed
Fields changed from master-detail to lookup in Affiliation, Program Enrollment, Course Enrollment, and Relationship

Info
Issues

@daveperry ~ This is ready to be reviewed and merged. The master job will fail, since the new packaging org is not yet configured in Jenkins. I was going to do it myself, but it seems like @jlantz has tightened security and I'm not able to. Anyway, getting this merge will at least let me clean up the other two open pull requests.


Weather Enhancements

Add following weather enhancements:

Add fog
Add sunshine
Add lightning
More realistic clouds

Add Sleet and Hail?

Completed enhancements, closing


PubSub use of connection pool

We use go-redis in a production application for our notification protocol between microservices. Initially, we ran into an issue when using more than (I think) 8 pub/sub clients with the same redis client. After some investigating we realized that pub/sub wasn't returning the connections to the connection pool. There are two workarounds: use a single pub/sub for all subscriptions and route the messages to the correct recipients on our own, or increase the maximum number of connections of the pool.
I have just spent some time going through the code of v5 and it does look to me that the pub/sub is now correctly working with the connection pool? Or am I mistaken and we will still need to allocate one connection per pub/sub, permanently?
One a side note, it would be really nice if you could add comments to your code. I, for instance, would certainly have contributed to the project already if it was easier to find my way around the functions. Not even all the public functions are properly commented, which is a real shame. In my opinion, you should even have a lot more than that.

It definitely works - https://github.com/go-redis/redis/blob/v5/pool_test.go#L80-L91. But connection is not returned to the pool until you close subscription with pubsub.Close.

Or am I mistaken and we will still need to allocate one connection per pub/sub, permanently?

Every PubSub allocates one connection. So if you have multiple subscriptions you should keep that in mind.

In my opinion, you should even have a lot more than that.

Agreed. Not that comments will write themselves ;)

Correct me if I'm wrong, but I don't think it really works that way. From what I can see, closing the pubsub does nothing but closing the underlying base client. This includes closing the connection pool and will make all other pubsubs derived from the same client fail as well, at least as far as I can tell?
Another comment would be that it does not make sense to me why you stopped pubSub() to be exposed publicly. When you initialize an application, you might not know any channels you want to subscribe to yet.
I don't mean to be rash, but I don't think the pubsub API is well designed in terms of making use of Go mechanics, either.  What about returning a channel for each subscription/pattern (or batch of subscriptions/patterns)? I think it would allow more elegant code for pubsubs.
Finally, what is the reason behind creating and using one connection for each pubsub? Personally, I would think the pubsub either needs better support to route the messages of different channels to different consumers, or the pubsub should be an abstraction, with the underlying implementation sharing a connection / connection pool. Right now, it's somehow in-between, which doesn't seem to make too much sense to me.
Looking forward to hear your comments.

at least as far as I can tell?

baseClient has it's own pool of 1 connection used for the PubSub.

Probably, but I don't think it is that bad. E.g. you can do
pubsub, err := client.Subscribe("some_dummy_channel")
pubsub.Subscribe("real_channel")

Probably client.Subscribe() should be changed to not require any channels. Overall I don't see a big problem here.

What about returning a channel for each subscription/pattern (or batch of subscriptions/patterns)?

i was thinking about returning one channel for all subscriptions. Anyway both can be done in user space.

needs better support to route the messages of different channels to different consumers, or the pubsub should be an abstraction

You can build this in user space on top of PubSub and share it with everyone. Current PubSub is a minimal set of API that provides you access to Redis channels without any overhead for routing/channels etc. I think that is right foundation.

The dummy channel idea is not clean at all, though.
It would be nice to have subscribe just work without channel, I tried that and I think it panicked.
If you do this in user space, you will have trouble cleanly shutting down because of the blocking calls. So you actually have to use the low level function that is recommended against with timeout. By the way, did you consider implementing things like timeouts with contexts yet? That could work really nice with pubsub as well imo.
If you think having a minimal implementation is the way to go (and I actually happen to agree), then I still believe you can't have it use one connection per subscription.
Anyway, thanks a lot for your feedback, it's appreciated.


Target Manager

Description of the feature request:
Add a GUI for managing targets. This is a prerequisite for multi-project repo and caching.
Which category does this issue belong to?
No response
What underlying problem are you trying to solve with this feature?
Easier management of project view targets and better caching integration in the future.
What operating system, Intellij IDE and programming languages are you using? Please provide specific versions.
All
Have you found anything relevant by searching the web?
No response
Any other information, logs, or outputs that you want to share?
No response

Quick update: instead of creating a new window/modal, I'll add gutter buttons that can be used to add new directories, and enable/disable individual targets. This would later be integrated with my still-in-design "quick sync" feature. This is what I could do experimenting yesterday:

This button currently takes you to the Add Directory modal that already exists.

Quick update

Next I'll:
1- Temporary button that appears asking to resync OR just reload directory structure (we use that a lot!).
2- A button to automatically scan for new folders/targets and add them to file.
The I would focus on smarter management for caching.

honestly I'm not sure if the "Add Directory to Project" button would be that useful if users can just add a new line there, but the gutter icons are pretty cool!

I agree if you look at the button alone, but now imagine with me having a complete target manager there right on the editor. I think that the next iterations would make my idea clearer. And I'm still open to suggestions 😄


Missing name property in FeatureCollection

In the ED-318 (Open Consultation version), the data model includes a "name" property of the FeatureCollection. See lines 461/462:

This property is missing in current Json schema.

resolved

resolved


Replace portfolio link

This addresses and closes #7717 issue with the stray-bullet link.
Also updates the example portfolio to something we can adjust and keep updated more easily.
I know this means I'm submitting myself to all sorts of questions from campers, but if I can't handle that... what on earth am I good for anyway hahaha

edit: added a change in the hikes lecture routes file to clear a warning about props alphabetical order.

:+1:


Pin Flake8 to 3.3.0

High Level Description
Backport to 1.9

TestUpgrade.test_mesos_task_state_remains_consistent failed: https://teamcity.mesosphere.io/viewLog.html?buildId=720658
@sambatyon do you happen to know (why) this is expected?

So this tests checks that after an update no fields are removed from the mesos task state. Now, the issue I had to dealt with was unrelated with this failure.
@mellenburg pointed out to me, while I was working on the test, that it might be flaky on exactly that point: https://teamcity.mesosphere.io/project.html?projectId=ClosedSource_Dcos_IntegrationTests_CloudIntegrationTests&tab=testDetails&testNameId=7561668161787586690#analysis

@mesosphere-mergebot bump-ee

That's the only PR against the 1.9.3 branch that is ready to land, and it's a requirement to land so that the code-quality check of other PRs against the 1.9.3 branch can go green.

Corresponding JIRA ticket: https://jira.mesosphere.com/browse/DCOS_OSS-1477


Implement empty placeholder for tag list

We need to have some sort of placeholder text for tag list that are empty.
Current behaviour:

Namespace list:


Updates coqa_conversational_question_answering to set number_of_shots=0

OK, abandoning this as our instructions say explicitly to set this to -1 if shots is not applicable to your task.


Chef supermarket release without GitHub update

Looks like the latest version of this cookbook on the supermarket is 2.0.0 (with some major changes that broke our cookbooks, but that's a different discussion), but the corresponding changes have not been pushed to this repository.

@Poohblah Sorry about the lack of github update. I pushed to the wrong repo. I've updated the source repo and released 2.0.1 with additional documentation


refactor: reverts when owner wrongly sends ethers

closes #227

I took the liberty to:

fix cancelSwap (was not sending eth after expiration)
feat more tests for cancel swap
added more documentation for functions in the interface
fixed test names
fixed variable names
identation

Making a ninja patch because we need this features for yesterday


Option of adding Custom host in config file is present but not mentioned in the documentation

Great catch, added it to the docs, thanks for reporting!
https://zenoml.com/docs/configuration#host


[Feature Request] Search in the response

Users can search in response

CTRL-F in the response window brings up a search prompt (with regex support)

@smdedar As @emptyflask pointed out, you should be be able to click on the response view and hit ctrl/cmd + f to search the response

I'm closing this issue because the requested feature is already available in Bruno.


Need endpoint to save exit registration details

Currently these details consist only of email.

we can save them in the settings.exit_client.reg_details struct, unless you mean something different

Oh yea, my bad lol. Was sleepy.


Support circular references in persistState

Should fix #262.

We're getting a lot of errors when redux dev tools is open.
Any change this can be merged if the fix works?

@stoikerty, did you try this patch. Does it solve the issue?

I would hope it does. I'm willing to try out the patch, not sure how though since it's a chrome extension. How do I do it?

I forgot to mention, the error started to appear after we started using redux-form.

Then it's not related to this PR (unless you added debug_session in the url). Could you please open an issue there with an example repo or jsfiddle to reproduce? Do you experience this problem also with our example?

Sorry, I thought they were both tightly coupled. I am getting the same error on the example page as well. Should I still create a new issue in the other repo?
gif for the example you provided:

@stoikerty, on the settings page (click the last button from the bottom) is the checkbox for serialization checked?

Yes it is.

@stoikerty, checked on Chrome 51, 52 and Canary and cannot reproduce it, also looking in the lifted state don't see any circular reference. Most likely you have another instance (tab with a Redux app) opened, so the error comes not from this example.
Could you please check that and open an issue on the extension repository, so we can discuss it there?

@zalmoxisus You're right, it was caused through another tab. Really strange, I thought being in incognito would prevent any overlap. I'm willing to open an issue, but I have a feeling we might have a circular reference that is not related to redux-form.
I will investigate, if I can't resolve the issue I'll create an issue in the extension repo with an example/jsfiddle to reproduce it.

@stoikerty, alternatively you can install jsan from npm and try to reproduce the problem by executing jsan.stringify(store.liftedSore.getState()) from your app.

thanks, I'll check that out

@stoikerty, issues with circular references should be fixed in extension v2.4.0. Thanks to @kolodny for working on this. Please confirm.
Of course when adding debug_session to the url, persistState will still throw till we merge this pr.

@zalmoxisus I can confirm the error has now disappeared. Thanks for the update, much appreciated.


[ZEPPELIN-2222] Add Network Visualization

What is this PR for?
This issue is about a new network visualization that can leverage the Property Graph Model (https://github.com/tinkerpop/gremlin/wiki/Defining-a-Property-Graph), but also simple graphs in order to provide a set of base apis that can be used by graph dbs (like Neo4j) or graph processing frameworks (like GraphX or Giraph).
What type of PR is it?
[Feature]
Is related to the #1582
Todos

[x] - Added the intepreter apis to manage graphs (under the pakage org.apache.zeppelin.interpreter.graph)
[x] - Added the frontend apis to manage graphs (via d3js)

What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2222
How should this be tested?
You can download this notebook to test the PR
Screenshots (if appropriate)

Video

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? Yes

@conker84 Pretty graph! I have one question.

It's looks like new display system works with backend interpreter.
And enabled when we click the network visualization icon.

So, what happens when we click 'table` or other visualization icons in the situation? (the screenshot you attached.)

@1ambda the graph is flatten by javascript apis so we can leverage the other visualizations provided by Zeppelin
I'll add a video asap to show how it works!

@conker84 FYI, you can simply just take a GIF using software called LICEcap, and upload it directly here with drag and drop :)

I will test and give you feedback soon.

Hi guys any news/feedback?

Hi guys i'm still here, let me know if i can do something to simplify the review!

@conker84 Thanks for this nice contribution. We introduced Spell in the latest release. Spell helps you contribute this kind of wonderful visualization as easier than now. @1ambda Can you guide to convert it to Spell?

@jongyoul thanks for the answer, i checked the Spel and the Visualization and i understood they are front-end only. This contribution is a mixed front/back-end becouse it want to provide a set of base api in order to enable graph-databases's  exploration (like Neo4j or others) with Zeppelin.
This contribution is the first step of #1582 the second is to implement the Neo4j Interpreter on top to the GraphResult apis.
If you guys think there is a more valuable solution to this i'm happy to talk about!

I think this is introducing a new result type from interpreter on the backend side that could be useful for this new Neo4J interpreter and other graph-base ones in the future?

Yes it is!

Really sorry for late reply. I missed notification for a while.

Spell might use JSON output of neo4j interpreter utilizing sigma.js, vis.js
Having default network display system using generalized graph model (Property Graph Model) would be good idea.
Personally, hope to get more refined, pretty graph UI instead of d3 network.

The #1582 initally was with sigma.js but i found a strange memory consuption that broke the browser after the #1529 so i migrated to d3 network visualization, i chose d3 instead of vis.js in order to reduce project's dependencies.

It's just my opinion. Thus, it's ok to use d3 if you think it's reasonable 👍

We are talk about graphdb, the UI is an important part of the PR, as well as the new interpreter apis!
I'm looking forward to your feedback.

UI can be improved in the following PRs. So it's ok not to resolve the whole things in this PR.

Let me know if you want go ahead with this PR or i have to close it!

Ok! So i'll rebase the code ASAP.

FYI, i didn't mean you have to create other PRs. Others can improve UI.

Done!

@conker84 you should rebase based on master, not other branch. Currently, your change mixed with others.

Is it now ok?

I think i made some error with git commits please can someone help me?

Do you mean the conflicts ? You need to do git rebase

Yes i made the rebase but it starts from the history dc7b100 instead of 43352ae and i can't understand why.

Thanks

Please rebase it upon upstream master branch

Is it now ok?

Hi, @conker84
Here is failed JOB and looks irrelevant. But could you make CI green?

https://travis-ci.org/conker84/zeppelin/jobs/227364420

you can click restart button in travis.

i tried but it still fails...

Regarding to continuous-integration/appveyor/pr — AppVeyor build failed, you should rebase. Since master has .appvepor.yml file.

In case of Jenkins, you are failing to profile 3 (selenium test)

raw log

Tests in error:
  AuthenticationIT.testGroupPermission:190->AbstractZeppelinIT.pollingWait:94 Â» Timeout
  InterpreterIT.testShowDescriptionOnInterpreterCreate:69 Â» ElementNotVisible El...

They might be flaky tests. You can simply pass them by clicking restart button in travis.

It should be ok now

Hi, could you please update me about the status of the review? Thanks!

No news?

@conker84 Hi, I have a question. I'm not sure but classes under org.apache.zeppelin.interpreter.graph is used only for testing it. Can you verify it? If it does, can you move these classes under test?

@jongyoul this contribution is the result of the split of #1582 in two little PR; the classes under org.apache.zeppelin.interpreter.graph provide the basic abstraction that can be used by graph dbs (like Neo4j, OrientDB, ArangoDB etc...) or graph processing frameworks (like GraphX or Giraph) and they will be used by the second part of the contribution which is the Neo4j interpreter, if you think is more appropriate I can move these classes into the second contribution.

Still no news?

Hi guys,
i'm still waiting an answer, maybe there is no interest to this PR, it's ok for me but just give me some feedback. Sorry if i bother you but I need this with the Neo4jIntepreter for a small PoC that i have to develop so I need infos in order to plan my work.
Thanks

Oh, I'm sorry for the late reply. I think you'd better to move those classes into another PR

Thanks, Will merge it after CI become green

Can you make CI green?

looks like everything is green on travis but jenkins isn't picking them up
https://travis-ci.org/conker84/zeppelin/builds/240773799

@felixcheung Yes, I already checked it but I was confused the branch name is master. :-) Thanks

@conker84 I found it's your first contribution. Thank you.

Congrats! And thanks!

Thank you guys now I'll proceed with the second part of the original PR. The Neo4j's interpreter:)

@conker84 Hi, could you take care this issue might be related without NETWORK viz?

https://issues.apache.org/jira/browse/ZEPPELIN-2663

  <div ng-if="type == 'TABLE' || type == 'NETWORK'" class="btn-group">
    <button type="button" class="btn btn-default btn-sm"
            ng-repeat="viz in builtInTableDataVisualizationList track by $index"
            ng-if="viz.supports.indexOf(type) > -1"
            ng-class="{'active' : viz.id == graphMode && !config.helium.activeApp}"
            ng-click="switchViz(viz.id)"
            tooltip-placement="bottom" uib-tooltip="{{viz.name ? viz.name : ''}}"
            ng-bind-html="viz.icon">
    </button>
  </div>

Hi @1ambda I created the #2421


DRUP-13: Front page config

Sets up a 'frontpage' content type.
Testing:

[ ] Pull down the project builder: git clone git@github.com:fourkitchens/sous-project.git
[ ] Edit the composer.json from the 'sous-project' to use this branch. ~Line 30 should read: "fourkitchens/sous": "dev-drup-13--front-ct",
[ ] Run lando start
[ ] Run lando composer install
[ ] Visit the site: https://sous-project.lndo.site/ and run through install process.
[ ] Verify that you can create a frontpage: https://sous-project.lndo.site/node/add/frontpage

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add ability to pass ViewBag to renderer

I would like the ability to pass a ViewBag to the renderer so that data can be passed to layouts. The RazorLightEngine already has this capability via RazorLightEngine.Parse<T>(string key, T model, ExpandoObject viewBag) (https://github.com/toddams/RazorLight/blob/master/src/RazorLight/RazorLightEngine.cs#L57) but UsingTemplateFromFile() calls RazorLightEngine.ParseString().

@judowalker  would the context pattern used here https://github.com/lukencode/FluentEmail/pull/252 meet your requirements?

@judowalker  would the context pattern used here https://github.com/lukencode/FluentEmail/pull/252 meet your requirements?

@SimonCropp I think the idea of the ViewBag would be to help pass data to the Layout file.
https://github.com/lukencode/FluentEmail/issues/82

@SimonCropp I think the idea of the ViewBag would be to help pass data to the Layout file.
https://github.com/lukencode/FluentEmail/issues/82


Proposal: change appcast :sha256 to :checkpoint

Refs https://github.com/caskroom/homebrew-cask/pull/16948. If agreed upon, steps:

[ ] Deprecate :sha256 in appcast.
[ ] Add :checkpoint (or other name) to appcast.
[ ] Change all casks in main repo to use :checkpoint.
[ ] Change all casks in versions repo to use :checkpoint.
[ ] Add sourceforge appcasts.
[ ] Update documentation.
[ ] Update details in https://github.com/caskroom/homebrew-cask/issues/16529.
[ ] Update details in https://github.com/caskroom/homebrew-cask/issues/16689.
[ ] Update cask-repair.
[ ] Update find_sparkle_appcast.

Discussed names:

:checkpoint
:control
:value
:version
:update
:identifier
:update_id
:id

The documentation is flexible - I also don't mind having a distinct stanza name.
Not a huge fan of checkpoint, but maybe another maintainer will chime in with a better one.
Otherwise, +1 to the proposal - it seems like a lot of work up-front, but if it makes for an easier and more reliable update mechanism down the road, it's worth it.

:+1: But I think a simple script to compute this value should be on that list

But I think a simple script to compute this value should be on that list

cask-repair would be that script. Otherwise, if you want to do it manually, the instructions (where we explain what the value represents) would tell you to get it with curl "{{appcast_url}}" | sed '/<pubDate>/d' | shasum --algorithm 256 (or to add get_checkpoint() { curl "{{appcast_url}}" | sed '/<pubDate>/d' | shasum --algorithm 256; }` to your shell’s startup files.

Added discussed names to the top post.
Personally, I’m more inclined for :control or :checkpoint. Even if not completely accurate, if we’re going for an identifier that represents a custom value that we’re the ones making up, might as well have a distinctive name, since that will both help to talk about it, and find it in code.
We need more opinions/ideas, here, just so we can move on and actually do it, as this small decision is holding up too much.

Agreed on the unique name point - that's nice in documentation.

I thought I cared about the name, but as long as it's documented, it really doesn't matter to me. :checkpoint is fine.

I’m in the same “camp” of not really caring that much about what the final name ends up being (though I usually do, and have some I prefer) as long as well are fine with it.
@adityadalal924 seems to be fine with :checkpoint as well, considering the distinctive name argument. What about you, @Amorymeltzer?

Mmm, I like :id

@vitorgalvao For updating documentation, is https://github.com/caskroom/homebrew-cask/issues/16690 something you are actively working on, or should this update be separate from that?

@adityadalal924 #16690 is about breaking it up, so for additions (this case) it should be separate.

Closing, as adding sourceforge appcasts is already an issue (and isn't particularly relevant to the switch).


Improve error / readability of Verify-Links.ps1

First I love Verify-Links.ps1 and anything that automatically catches errors.
That said, the errors it's generated on a recent checkin (#1787) were hard to follow for me.  At issue is the readme.md is pointing to non-existant .c files which is a good catch
Found 97 links on page file:///D:/a/_work/1/s/sdk/samples/iot/README.md
##[warning][404] broken link ***/blob/master/sdk/samples/iot/paho_iot_pnp_sample.c
##[warning][404] broken link ***/blob/master/sdk/samples/iot/paho_iot_pnp_with_provisioning_sample.c
##[warning][404] broken link ***/blob/master/sdk/samples/iot/paho_iot_pnp_component_sample.c

The issue is I thought that the issue was in the files themselves and links they have, and not the readme.  It'd make it easier if maybe:

There could be something to more clearly tie the warning to the error in the readme.md.  I thought the "found 97" meant success.  So like putting in "/blah/blah/iot/readmemd: broken link .../pnp_sample.c..
The ***/blob/... also threw me because I thought it was pointing at the file itself having broken links.  Could we have the error instead have the actual URL as is in the file, so the fully qualified http://.../pnp_sample.c so this pops more?

Thanks for the feedback.
The ***/ is a side-effect Devops treating the string https://githb.com/Azure/azure-sdk-for-c as a secret. I'll see if I can figure out what is marking that as a secret
Instead of "Found 97 links" would it be better if it said something like Checking 97 links found on page file:///D:/a/_work/1/s/sdk/samples/iot/README.md?
Also did you see the summary at the bottom of the log? We try to group all the failures together there as well.

Ahh - I didn't see the summary at the bottom, I think I just zeroed in on the errors!  But yes that would've solved this problem for me.

Instead of "Found 97 links" would it be better if it said something like Checking 97 links found on page file:///D:/a/_work/1/s/sdk/samples/iot/README.md?

I do; I think I would've mentally mapped this up a bit clearer with that.


[Migration] OAuth2 Error response redirection behavior is changed

The default behavior of the error response redirection in OAuth flow is changed in order to compliant with the OAuth2 specification.
A new configuration is introduced to have backward compatibility.
Added property,
<RedirectToRequestedRedirectUri>true</RedirectToRequestedRedirectUri> under the <OAuth> tag in <CARBON_HOME>/repository/conf/identity/identity.xml file

Reported Issue - https://github.com/wso2/product-is/issues/5277
Fix - https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/1118

Therefore the migration client and documentation should be updated accordingly

Added at https://is.docs.wso2.com/en/latest/setup/migrating-what-has-changed/#redirecting-to-callbackurl-in-oauth-flow-errors


Add style guideline about single line conditions

This PR adds a bit more into the Conditional Statements section of our JavaScript guidelines. It aims to formalise against the use of inline conditional blocks, which do not lend themselves well to readability.

🍍

:+1:


Azure Service Bus vs RabbitMQ

Issue description
In article https://docs.microsoft.com/en-us/dotnet/architecture/microservices/multi-container-microservice-net-applications/integration-event-based-microservice-communications (and others preceding it) it is mentioned that RabbitMQ is a lower-level messaging bus implementation than Azure Service Bus:

(...) RabbitMQ, a messaging broker transport, is at a lower level than commercial products like Azure Service Bus, NServiceBus, MassTransit, or Brighter. Most of these products can work on top of either RabbitMQ or Azure Service Bus.

In what sense is RabbitMQ a lower level product? How can the other, commercial, products work ON TOP OF RabbitMQ or Azure Service Bus - what does that even mean?
Edited by Thraka to add doc details

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b037f198-3ee2-28f4-4d93-0999e5d3d3ef
Version Independent ID: 9bd96308-c726-fcee-850e-a38fd22ff555
Content: Implementing event-based communication between microservices (integration events)
Content Source: docs/architecture/microservices/multi-container-microservice-net-applications/integration-event-based-microservice-communications.md
Product: dotnet-architecture
Technology: microservices
GitHub Login: @nishanil
Microsoft Alias: nanil

I am not a Microsoft fan but you may misunderstand the statement. Stating lower-level for Rabbit MQ does not mean it is underestimated. I understand from lower-level that it is not a more plug-and-play system than the other commercial products which generally uses Rabbit MQ at back-end. It is like preferring C# instead of C with which you must implement lots of fundamental libraries such as http clients or service bases.
As a supporting argument, in this article, it is stated that:

Of course, you could always build your own service bus features on top of lower-level technologies like RabbitMQ and Docker, but the work needed to “reinvent the wheel” might be too costly for a custom enterprise application.

Hi @Loreno10, thanks for the feedback.
Thanks @ccerhan for your comment too 😊, that's indeed the case.
Lower-level here means that it includes the core features, and then some, but there are other features that are important for production deployments that you'd have to implement yourself.
That's why the Additional resources section in the article includes some production-grade offerings.
You can also take a look at the wiki page from eShopOnContainers about Asynchronous messaging for more information.
Hope this helps.

Closing this issue now but feel free to comment, will reopen if needed.


On Key Pressing, Characters are going out of screen.

Bug : On Key Pressing, characters are going out of screen.

Info :

Steps to reproduce : Simply, directly run the main.py file. Use one finger, to point to character and two fingers(index and middle) to press a key.

Working on it.

Great issue and looking forward for you to fix it


dom: Added function to load SVG document from std::string

Added function load(std::string& s) in order to load SVG doms from an std::string.

The PR looks good, thanks for contribution!


i always meet this error,why?

user_cloud-oauth2-server_1 | 2016-10-22T06:16:58.659398136Z 2016-10-22 06:16:58.659  WARN 1 --- [           main] ationConfigEmbeddedWebApplicationContext : Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'springSecurityFilterChain' defined in class path resource [org/springframework/security/config/annotation/web/configuration/WebSecurityConfiguration.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [javax.servlet.Filter]: Factory method 'springSecurityFilterChain' threw exception; nested exception is org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type [org.springframework.boot.autoconfigure.security.oauth2.resource.UserInfoRestTemplateFactory] is defined
user_cloud-oauth2-server_1 | 2016-10-22T06:16:58.751738128Z 2016-10-22 06:16:58.751  INFO 1 ---

Same error after upgrade from Brixton.RC2 to Camden.SR2 and Spring Boot from 1.3.6.RELEASE to 1.4.1.RELEASE.


websocket: bad handshake

Hi Team, may be there is a problem with RPC or port somewhere:
websocket: bad handshake (HTTP status 429 Too Many Requests)

@samboluy You can wait for it to automatically switch to other RPC nodes, or run your own RPC node, using the following two methods:
https://docs.cess.cloud/core/storage-miner/multi-buckets#run-rpc-nodes-through-the-cess-nodeadm-program
https://docs.cess.cloud/core/storage-miner/multi-buckets#run-the-cess-node-program-directly


d8: Python uses spaces for indent

https://www.python.org/dev/peps/pep-0008/#tabs-or-spaces says:

Spaces are the preferred indentation method.
Tabs should be used solely to remain consistent with code that is already indented with tabs.
Python 3 disallows mixing the use of tabs and spaces for indentation.
Python 2 code indented with a mixture of tabs and spaces should be converted to using spaces exclusively.

This file has a mix of spaces and tabs, so let's use spaces.

Will be updated from build.sh repo once this is resolved: https://github.com/wunderkraut/build.sh/pull/43


Fixing typo issue

Find the typo!
tes_isssue.txt

tes_isssue.txt

my first issue

tes_isssue.txt
Does this qualify as a PR? I am not able to locate this file in the original repo

tes_isssue.txt
Fixed

tes_isssue.txt
i corrected it!!

fixed
tes_isssue (1).txt


chain_demo.py result error?

to make sure result trustworthy, i change (x,y) coordinate in chain_demo.py like this
x = torch.ones((1, N), device=torch.device('cuda')) * 394.0
y = torch.ones((1, N), device=torch.device('cuda')) * 93.0

the gifs generated in root/ as flowing，chain_out_1.gif looks good,but chain_out_2.gif and chain_out_3.gif seems wrong,
what should i do to get right result? please
chain_out_1.gif

chain_out_2.gif

chain_out_3.gif

This is a great test, and I think you did it correctly. Some points are harder to track than others, and what you are seeing here is simply success/failure of the current model.

thanks for reply, how to optimize further if i want apply the model in my situation?

The simplest thing is: if you have access to some synthetic data that looks like your target data, finetune the model on that data. For example, if you want the model to excel at tracking dogs, you can train it on dogs. Right now it's more of a general-purpose machine, and making it 100% reliable is an open research problem.

The simplest thing is: if you have access to some synthetic data that looks like your target data, finetune the model on that data. For example, if you want the model to excel at tracking dogs, you can train it on dogs. Right now it's more of a general-purpose machine, and making it 100% reliable is an open research problem.
yeah,100% reliable is an open research problem,https://github.com/deepmind/tapnet/issues/7#issuecomment-1361243826 should also can not agree with any more,thanks all u guys


UL-10-accounts-can-be-classified

Basic setup for classifying accounts setup and methods to make double entry written.
Pending tasks:

More testing
Default set of accounts need to be created when user is registered.

Merge into main.


dts is not effective

in the remote set dts to true is not generated dts file

Thanks for your feedback @userxiaya
This is a duplicate of #112
I close this one, let's continue there.


fix:  VRDR Java Library address interpretation

Reported by Maryland:
https://chat.fhir.org/#narrow/stream/179301-Death-on-FHIR/topic/Address.20mismatch

The _city and _district extensions need to be added to the city and district elements, not to the address. Using the code shared:
Extension cityCode = new Extension("http://hl7.org/fhir/us/vrdr/StructureDefinition/CityCode", new PositiveIntType("37000"));
`decedentsHome.getCityElement().addExtension(cityCode);

The same goes for other extensions like _district or _state.


Prepare dataset & create directories

This commit sets up the necessary dataset and directories for the project.

Download and clean the required dataset
Establish directory structure for better code organization

Changes include:

Addition of /data folder containing cleaned dataset files
Creation of /src, /models, and /notebooks directories for code organization

I'm sory but I can't merge your change to the main branch, since the main branch is where we publish stable codes and prepare for release. So plz PR your work to the alg-dev branch or develop branch.
btw, you'd better delete your .idea fold in commit.


#2 Improved the login page ui

Added design for login page
This is how it is looking now

@Asymmentric please review this design and merge it.

@Asymmentric any updates?

Thank you for the contribution @k-deepak04. I tested the UI and it is impressive.


→ right arrow not rendered correctly anymore

Right Arrow (→) Symbol Not Rendering Correctly
Description:
The right arrow symbol (→ →) is no longer rendered correctly in certain environments.
Affected Platforms:

GMail (screenshot below)
Mailtrap
Possibly other platforms

Additional Issue:
The copyright symbol (© ©) also appears to be affected.
Screenshot (GMail):

Hi @cypris75,
Unfortunately, I can't reproduce. Both symbols work fine for me:

Most likely, you're HTML encoding the result of mailGenerator.generate(email); before passing it into your mailing library (e.g. nodemailer), or your mailing library automatically HTML encodes any e-mail body you pass into it.
Please investigate further, and consider trying out nodemailer to confirm it's your mailing library that is the cause of the issue:
// Send the e-mail with your favorite mailer
transporter.sendMail({
    from<EMAIL_ADDRESS>    to<EMAIL_ADDRESS>    subject: 'Mailgen',
    html: emailBody,
    text: emailText,
}, function (err) {
    if (err) return console.log(err);
    console.log('Message sent successfully.');
});


No module named colorama

Traceback (most recent call last):
File "zero-tool.py", line 2, in
from colorama import Fore
ImportError: No module named colorama
Tried installing colorama and it was already installed

dont use python3

tnx


Update to deploy Spfx sample and new sample to remove spfx package

Update existing sample and new sample script for retracting SPFx packages from hub site and associated sites.

Good Morning @reshmee011 - thank you for the update and new sample ill socialize individually 😃 - this will be live shortly 🎉😁


Removal of no longer managed entries fail if already manually removed.

This is kind of an issue for those of us that like me prefer to configure my flatpaks interactively, then dump it into a nix file so my desired state is declarative.
During the removal of [packages] (https://github.com/gmodena/nix-flatpak/blob/8bdc2540da516006d07b04019eb57ae0781a04b3/modules/installer.nix#L111) the module assumes that the saved state is perfect, and will fail if the user have manually uninstalled the package beforehand. A simple check beforehand to make sure it is installed, something like ${pkgs.flatpak}/bin/flatpak info "$APP_ID" && ${pkgs.flatpak}/bin/flatpak uninstall --${installation} -y $APP_ID  would fix this.
It seems the remotes already have this style of check implemented, just a tiny bit differently than what I did above. https://github.com/gmodena/nix-flatpak/blob/8bdc2540da516006d07b04019eb57ae0781a04b3/modules/remotes.nix#L31-L35
PS: not sure if anyone cares, but this is currently my setup to "save" the live flatpaks to nix:
flatpak.nix
{
  home.packages = with pkgs; [
    flatpak

    (pkgs.writeShellApplication {
      name = "zzz-save-flatpak2nix";
      runtimeInputs = with pkgs; [
        flatpak
        gnused
        coreutils
        nixfmt
      ];

      derivationArgs = {
        nativeBuildInputs = [ pkgs.installShellFiles ];
      };
      excludeShellChecks = [ "SC2145" ];
      text = builtins.readFile ./save-flatpak2nix.sh;
    })
  ];

...

  # Use the shell script zzz-save-flatpak2nix to update desired remotes and packages from live system.
  services.flatpak = import ./flatpak2nix.nix // {
    enable = true;
...
  };
...

save-flatpak2nix.sh
#!/usr/bin/env bash

# Start
export LC_ALL=C
OUTPUT+="# Generated by $0\n"
OUTPUT+="{\n"

###
# Remotes
OUTPUT+="remotes = [\n"

OUTPUT+="$(flatpak remotes --columns=name,url | sort | sed -E 's/(.*)\t(.*)/{\nname="\1";\nlocation="\2";\n}\n/')"

OUTPUT+="];\n"

###
# Packages
OUTPUT+="packages = [\n"
readarray -t apps < <(flatpak list --app --columns=origin,ref)
readarray -t runtimes < <(flatpak list --runtime --columns=origin,ref)

OUTPUT+="\n###\n# Apps\n"
app_output=""
for app in "${apps[@]}"; do
  readarray -t -d $'\t' fpkg < <(echo -n -e "$app")

  if [ "${fpkg[0]}" == "flathub" ]; then
  	app_output+="\"${fpkg[1]}\"\n"
  else
  	app_output+="{origin=\"${fpkg[0]}\";appId=\"${fpkg[1]}\";}\n"
  fi
done
OUTPUT+="$(echo -e "$app_output" | sort -r)\n"

OUTPUT+="\n###\n# Runtimes that directly extends an app\n"
runtime_output=""
for runtime in "${runtimes[@]}"; do
  readarray -t -d $'\t' fpkg < <(echo -n -e "$runtime")
  extends="$(flatpak info -m "${fpkg[1]}" | sed -n -E -e '/ExtensionOf/,/^$/s/ref=((app|runtime)\/)?(.*)/\3/p')"

  if [ -n "$extends" ] && grep "$extends" <<<"${apps[*]}" >/dev/null; then
  	if [ "${fpkg[0]}" == "flathub" ]; then
  		runtime_output+="\"${fpkg[1]}\"\n"
  	else
  		runtime_output+="{origin=\"${fpkg[0]}\";appId=\"${fpkg[1]}\";}\n"
  	fi
  	#else
  	# if [ "${fpkg[0]}" == "flathub" ]; then
  	# 	runtime_output+="#\"${fpkg[1]}\"\n"
  	# else
  	# 	runtime_output+="#{origin=\"${fpkg[0]}\";appId=\"${fpkg[1]}\";}\n"
  	# fi
  fi
done
OUTPUT+="$(echo -e "$runtime_output" | sort -r)\n"
OUTPUT+="];\n"

# Fin
OUTPUT+="}"
echo -e "$OUTPUT" | tee "$HOME/code/nixos-config/home/$USER/apps/flatpak2nix.nix"
sync
nixfmt "$HOME/code/nixos-config/home/$USER/apps/flatpak2nix.nix"

example snippet of flatpak2nix.nix
{
  remotes = [
    {
      name = "Slicer";
      location = "https://rafaelpalomar.github.io/org.slicer.Slicer-flatpak-repository";
    }
    {
      name = "flathub";
      location = "https://dl.flathub.org/repo/";
    }
  ];
  packages = [

    ###
    # Apps
    {
      origin = "Slicer";
      appId = "org.slicer.Slicer/x86_64/master";
    }
    "xyz.tytanium.DoorKnocker/x86_64/stable"
    "rocks.koreader.KOReader/x86_64/stable"
    "rest.insomnia.Insomnia/x86_64/stable"
...

    ###
    # Runtimes that directly extends an app
...
    "io.github.ungoogled_software.ungoogled_chromium.Codecs/x86_64/stable"
    "com.jeffser.Alpaca.Plugins.AMD/x86_64/stable"
  ];
}

Hey @thomasfinstad

This is kind of an issue for those of us that like me prefer to configure my flatpaks interactively, then dump it into a nix file so my desired state is declarative.

Ah cool. This is a workflow I did not really consider. Thanks for sharing your setup!

the module assumes that the saved state is perfect, and will fail if the user have manually uninstalled the package beforehand.

This is more of a design decision. If you intend to "tamper" with the state, nix-flatpak assumes you’ll run it with uninstallUnmanaged=false.
Initially, I wanted the module to flag any inconsistencies with expected behavior. However:

A simple check beforehand to make sure it is installed, something like ${pkgs.flatpak}/bin/flatpak info "$APP_ID" && ${pkgs.flatpak}/bin/flatpak uninstall --${installation} -y $APP_ID would fix this.

+1.
As you pointed out, this behavior is already implemented in other parts of the codebase. I'm okay with relaxing the strictness and having the module log or warn about state mismatches instead of hard failing during removal.

@gmodena Thanks for the feedback, glad the suggested change is acceptable.

This is more of a design decision. If you intend to "tamper" with the state, nix-flatpak assumes you’ll run it with uninstallUnmanaged=false.

I think I might have explained how the problem occur a bit poorly, so while the problem sounds like it will be fixed, I just wanna try to clarify exactly what the problem is so remove any chance of a X/Y problem type situation.
I have uninstallUnmanaged=false in my config already.

add a flatpak to nix-flatpak list
rebuild nix
manually flatpak uninstall the package
remove the flatpak from the nix-flatpak list
rebuild nix ERROR

On step 5 nix-flatpak finds the flatpak in the old state and so tries to remove it, but it is already gone.
Perhaps I mean the json file when I say state and you mean the system live state when you say state and that is the miscommunication, but either way I hope its a bit more understandable exactly what my use-case / workflow is and how I bump into the mentioned issue.

@thomasfinstad thanks for clarifying.
Just to confirm: we are on the same page, and I can repro your workflow.

Were you able to reproduce it on your own system?

Were you able to reproduce it on your own system?

Yep. There's a fix the linked PR (warn-on-uninstall-missing branch).
From a previous comment:

This is more of a design decision. If you intend to "tamper" with the state, nix-flatpak assumes you’ll run it with uninstallUnmanaged=false.

Here I was wrong.  The issue you reported is  triggered when uninstallUnmanaged=false, as the state management logic does not reconcile the state in this scenario.
This is definitely a bug. Thank you very much for flagging it!


move sed commands for update-version to Justfile

quoting, shelling out to sed, and getting sed parameters to function dynamically within make was a nightmare. As a result, I am attempting a switch to just, at least for this target. make calls just here, hopefully allowing for backwards compatibility (provided that you have just installed 😅 )

Yes! So true 😅 Although I must admit, I was struggling with the bashism to get sed args to be passed in properly. (they kept getting interpreted as sed -i " ' '" 😱 )


View Revoked Credential Detail

As a Holder I WANT to know if my credential has been revoked  SO THAT
Scenario: Holder's credential is revoked
Given the holder has a credential revoked
When the holder is viewing the credential list
Then the UI of the revoked credential changes to that of the UI of a revoked credential

AFJ should reconcile the revocation registry entries and flag credential as revoked


Scroll back to top button

Prerequisites
Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

[x] I am running the latest version
[x] I checked the documentation and found no answer
[x] I checked to make sure that this issue has not already been filed

Expected Behavior
There will be a scroll back to top button which will take directly to top from button
Current Behavior
There is no scroll back to top button
Steps to Reproduce
A button will be created which will work as scroll back to top

step 1
step 2
you get it...

Context
Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

Firmware Version:
Operating System:
SDK version:
Toolchain version:

Failure Logs
Please include any relevant log snippets or files here.

Prerequisites
Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

[x]  I am running the latest version
[x]  I checked the documentation and found no answer
[x]  I checked to make sure that this issue has not already been filed

Expected Behavior
There will be a scroll back to top button which will take directly to top from button
Current Behavior
There is no scroll back to top button
Steps to Reproduce
A button will be created which will work as scroll back to top

step 1
step 2
you get it...

Context
Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

Firmware Version:
Operating System:
SDK version:
Toolchain version:

Failure Logs
Please include any relevant log snippets or files here.

Hey deabashish, you can just add the scroll top option.

@Akshay6890 can i work on this issue ? its been more than 15 days there is no update.

@Akshay6890 can i work on this issue ? its been more than 15 days there is no update.

Will see for 3 more days, and then assign it to you if there's no progress.

ok

@Akshay6890 can i work on this issue ? its been more than 15 days there is no update.

Will see for 3 more days, and then assign it to you if there's no progress.

@Akshay6890 kindly assign this to me its been 8 days

@vikasdo @Akshay6890 kindly review my PR