Angular UI not updating after 2.6.0

The UI on the same page as the map stopped updating after upgrading past 2.5.0. I need to update variables that affect the UI outside leaflet on click events from buttons inside marker popups. I have a button in popups, that opens a dialog in the Angular HTML component.
I tried to go around this issue by adding manual calls to ChangeDetectorRef.detectChanges(), and while that worked for the popups, regular Angular UI stopped partly updating.
When the user clicks a button inside the marker popup, a dialog is opened by setting this.dialogOpen = true.
Angular template: <div *ngIf="dialogOpen"><button (click)="dialogOpen = false">Close</button></div>
Clicking the close button does not close the dialog after 2.6.0, unless the user interacts with other page elements that cause a change detection.

@reblace Hey, thanks for your contribution towards this issue !
I believe the 2nd solution you mentioned (the one with NgZone.run()) should also be mentioned in the README.
At first I opted for the detectChanges way, but as the component containing Leaflet also had other child components, they were considerably slowed down.
I was able to solve this by using NgZone.run(), which in my opinion is also way more precise.

@mattdsteele sorry it took so long to look at this.
Your issue is that the Leaflet callbacks are running outside of the Angular zone. There's some details in the README, but basically, Angular uses zones to determine what events to monkey patch in order to automatically perform change detection. When I went to v3 of the ngx-leaflet plugin, I made a change (for the sake of performance) that runs all of the Leaflet code outside of the Angular zone. Without the change, every Leaflet event (including mouse move) triggers change detection, which can get expensive for larger or more complex apps.
The solution is that when you are making an Angular-relevant change inside of a Leaflet event handler, you need to trigger change detection. There's a couple ways to make this happen. You can either run the change inside Angular's zone using:
import { Component, NgZone } from '@angular/core';
import { tileLayer, latLng, Layer, marker, icon, MarkerOptions } from 'leaflet';
import { OnInit } from '@angular/core';

@Component({
  selector: 'app-root',
  templateUrl: './app.component.html',
  styleUrls: ['./app.component.css']
})
export class AppComponent implements OnInit {
  title = 'app';
  options = {
    layers: [
      tileLayer('http://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png', {
        maxZoom: 18,
        attribution: '...'
      })
    ],
    zoom: 5,
    center: latLng(46.879966, -121.726909)
  };
  tooltipClickedTimes = 0;
  layers: Layer[] = [];
  constructor(private zone: NgZone) {} // Inject the Angular zone reference
  ngOnInit() {
    console.log('initting');
    const markerOptions: MarkerOptions = {
      icon: icon({
        iconSize: [25, 41],
        iconAnchor: [13, 41],
        iconUrl: 'assets/marker-icon.png',
        shadowUrl: 'assets/marker-shadow.png'
      })
    };
    const mark = marker(latLng(46.879966, -121.726909), markerOptions);
    mark.addEventListener('click', evt => {
      console.log('clicked tooltip');

      // Make changes inside Angular's zone using the run() function
      this.zone.run(() => {
        this.tooltipClickedTimes++;
      });

    });
    this.layers.push(mark);
  }
  forceUpdate() {
    this.tooltipClickedTimes++;
  }
}

You can also inject a reference to the ChangeDetector and manually trigger change detection as described in the 3.x README: https://github.com/Asymmetrik/ngx-leaflet#a-note-about-change-detection
Over time, I'll add support for event emitters for the various map events, and as part of that I'll be able to ensure that the callbacks are happening inside Angular's zone. But, for now, either of these options is the correct way to handle this.

@bushybuffalo I will add the NgZone.run() method as the preferred method to the README. Thanks!

I've updated the README to include the suggestion to use NgZone.run and with a couple extra pointers to the issue.


Human readable identifier

Alongside with REDCap and RADAR ids, we can create a simple human readable identifier using the concatenation of

RADAR-CNS Work Package (MDD, MS, EPY)
Site (London, Barcelona, Milan, etc..)
REDCap Id
In the Management Portal, this information will be treated as metadata.

The generated value will be unique as long as a site will use a single REDCap instance.

Closed by PR61


Create new Discover category and titles

IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s): 1.2/1.3
Issue: https://issues.redhat.com/browse/RHIDP-3742
Link to docs preview:

Reviews:

[ ] SME: @ mention assignee
[ ] QE: @ mention assignee
[ ] Docs review: @ mention assignee
[ ] Additional review: @mention assignee (by writer)

Additional information:

Looks good to me :)

/cherry-pick release-1.3


create signup page

a signup page that can creat users and conect to the DB
fixes #37

Please fix all the flake8 issues before resubmitting.
The only one that doesn't need to be fixed is "0001_initial.py" line to long, because its a system created file.

You still haven't fixed the flake8 issues

that error: ./ultimatejobweb/models.py:2:1: F401 'django.utils.timezone' imported but unused
ill fix on the next PR


Move Site Extension to nuget.org

Please see https://github.com/Azure/app-service-announcements/issues/87 for detailed announcement.
Important: if your site extension is still relevant, you need to do this before June 1st 2018. Please let me know if you have any questions.
Thanks!

Thanks David.


⚠ Bofrost.at has degraded performance

In 5255b0e, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 900 ms

Resolved: Bofrost.at performance has improved in 4f3ce03.


Download response empty

Trying to use the download file feature but for some reason string inside the responseString { } block is always empty unless I put a breakpoint inside the destination { } block.
Am I using this the wrong way or is there a thread timing issue going on?
"http://httpbin.org/ip".httpDownload().destination { response, url ->
    File(this.filesDir, "test.txt")
}.responseString { request, response, result ->
    val (string, error) = result
    string...
}

(The file seems to be created and written correctly, but I figured I would use the result/string instead of immediately opening and reading the file, assuming it's supposed to be available.)

Hitting this same issue with the .response { request, response, result -> handler.  Created a stackoverflow question about it.

In order to write the content of the file Fuel need to read it from the body of the response. As a result at the point of responseString(...) the body of the response is actually empty.
I don't know if there is a way to not write content to the file, but then the body will content some wrapping code in addition to file content.

@danshev you are right I have a branch in which I have written a failing test that matches what you are saying, I will look in to this further and see if I can find a solution

@danshev  I have a pr that fixes this, I am not sure if my approach has other limitation, however I am sure @kittinunf  will soon let me know

@toemat This should be resolved as of the latest release, can you comment to indicate if you are happy to close?

This is great, thank you for the fix, @markGilchrist 🙏


Overlay issue

Hi,
Just detected an overlay issue while creating a new deck.
Here is a screenshot:

Hi Martin,
Thanks for the report, I will investigate.
-Smeea
On 20/09/2021 12:47, Martin Cuchet wrote:

Hi,
Just detected an overlay issue while creating a new deck.
Here is a screenshot:
overlay
https://user-images.githubusercontent.com/6403098/133983355-efaf11d9-8a35-405b-9d25-7c291ab60826.PNG
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/smeea/vdb/issues/17, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAB3WBORAA6JA6ENRDTG25TUC37M7ANCNFSM5ELSA3GQ.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Fixed in e471e78c7e047812b760c9806510f37830a1439e


Terminating R message box not localized

Tested with French language.
---------------------------
Microsoft Visual Studio
---------------------------
Terminating R will immediately abort calculations and all workspace objects will be discarded. This action cannot be undone.

Are you sure you want to terminate R session?
---------------------------
Yes   No
---------------------------

Text is in resource file. @MikhailArkhipov , do we need to do anything else to make it localized?

file a bug in the loc db.

@huguesv should open bug there or I someone - just register there for access. Then you can close this one.

No repro in latest build:


Functions inside case statements

If you try and use a function inside a case statement the results are potentially unexpected
decoder : Decode.Decoder String
decoder =
    Decode.at [ "example", "foo" ] Decode.string
        |> Decode.andThen
            (\string ->
                case string of
                    "test" ->
                        Decode.succeed "Working"

                    wrappedInAFunc ->
                        Decode.succeed "Working"

                    _ ->
                        Decode.fail <| "Invalid " ++ string
            )

wrappedInAFunc : String
wrappedInAFunc =
    "test"

Will throw:

The following pattern is redundant. Remove it.Any value with this shape will be handled by a previous pattern.

This is because you can't call a function as you need to use  a 'pattern'.
Maybe the error message can check if a function is being used, and if so warn the user about what they are doing as well as telling them the pattern is redundant?
Example Ellie:
https://ellie-app.com/jBM3qQDFMa1/0

It's redundant because pattern matching does not work like in Erlang or Elixir.
In the next release of the compiler, this will be caught because the compiler disallows variable name shadowing. I think that will also be helpful for folks coming from Erlang and Elixir who are expecting pattern matches to work different.


fix: global element not selectable after it's blurred

This bug only happened on component that doesn't use forwardRef.
This happened because we're relying on FindDomNode when the component does not use forwardRef. Unfortunately, for ElementReference, we render the ElementData, instead of Element, which has the FindDomNode fallback.
This commit fix that issue, and we render Element instead of ElementData.

@migueloller I was thinking the same thing. The side effects of the Element component are the ref-handling logic and the component registration. We need the ref-handling effects, and we don't want the component registration. The component registration effect is disabled with isRegisterElementDisabled.
Here's the Element.tsx code. Anything that might cause an issue here?
export const Element = memo(
  forwardRef(function Element(
    { element }: ElementProps,
    ref: Ref<ElementImperativeHandle>,
  ): JSX.Element {
    const elementKey = element.key
    const dispatch = useDispatch()
    const documentKey = useDocumentKey()
    const useFindDomNodeRef = useRef(true)
    const imperativeHandleRef = useRef(new ElementImperativeHandle())
    const findDomNodeCallbackRef = useCallback((current: (() => Element | Text | null) | null) => {
      if (useFindDomNodeRef.current === true) {
        imperativeHandleRef.current.callback(() => current?.() ?? null)
      }
    }, [])
    const elementCallbackRef = useCallback((current: unknown | null) => {
      useFindDomNodeRef.current = false

      imperativeHandleRef.current.callback(() => current)
    }, [])
    const isRegisterElementDisabled = useDisableRegisterElement()

    useImperativeHandle(ref, () => imperativeHandleRef.current, [])

    useEffect(() => {
      if (documentKey == null || isRegisterElementDisabled) return

      return dispatch(
        registerComponentHandleEffect(documentKey, elementKey, imperativeHandleRef.current),
      )
    }, [dispatch, documentKey, elementKey, isRegisterElementDisabled])

    useEffect(() => {
      if (documentKey == null || isRegisterElementDisabled) return

      return dispatch(mountComponentEffect(documentKey, elementKey))
    }, [dispatch, documentKey, elementKey, isRegisterElementDisabled])

    return (
      <FindDomNode ref={findDomNodeCallbackRef}>
        {isElementReference(element) ? (
          <ElementReference key={elementKey} ref={elementCallbackRef} elementReference={element} />
        ) : (
          <ElementData key={elementKey} ref={elementCallbackRef} elementData={element} />
        )}
      </FindDomNode>
    )
  }),
)

We're calling the isRegisterElementDisabled on the ElementReference:
<DisableRegisterElement.Provider value={true}>
  <Element element={globalElementData} ref={ref} />
</DisableRegisterElement.Provider>

Another alternative is to copy the FindDomNode code to the ElementReference.
I'll do more testing later.

Nothing immediately jumps out other than element registration.
My feeling right now is that this is hitting a threshold of complexity where it should probably be re-thought and refactored. I'll leave it up to you whether you want to do that or not.

My feeling right now is that this is hitting a threshold of complexity where it should probably be re-thought and refactored. I'll leave it up to you whether you want to do that or not.

I agree with this. I think refactoring the code should be a separate task so it doesn't block the bug fix.


feat: expose ETH_CALL_DEFAULT_TO_CONSENSUS_NODE relay env in the local config file

Description:

Currently, there is no way to change ETH_CALL_DEFAULT_TO_CONSENSUS_NODE relay's var.
Solution:
Add ETH_CALL_DEFAULT_TO_CONSENSUS_NODE to the local.json config file.
Related issue(s):
Fixes #605
Notes for reviewer:

Checklist

[ ] Documented (Code comments, README, etc.)
[ ] Tested (unit, integration, etc.)

Also, bump the images to the latest ones.


Fix facial expressions get auto-set bug

related: https://github.com/webaverse/app/issues/3389
Issue:
https://user-images.githubusercontent.com/60634884/181650968-8793d554-f6f7-4b56-b75a-0f7e91d13c3c.mp4
Result:
https://user-images.githubusercontent.com/60634884/181650986-dc7fc2af-0dec-4d34-a88f-550c47109711.mp4

@tcm390 though this bug is solved, there is another corner case if you can look into it plz
-In case we select a facial expression lets say 'happy' and then we perform an emote that includes that facial expression lets say 'victory'. The previously set 'happy' facial expression would be reset and would go away. it doesn't happens in case the performed emote doesn't contain the previously selected facial expression.
https://user-images.githubusercontent.com/35926530/181916644-0f8d3d63-2fcf-4754-9e79-023d00b864a2.mp4

maintain user previous facial expression
Result:
https://user-images.githubusercontent.com/60634884/182469129-381e6f68-2a40-45dd-8dff-033ad8f44aef.mp4


refactor/81-add-decltype-where-possible

This will reduce the amount of typing needed for refactoring classes in the
future, as well as make the files smaller.

OBE. I think this is pretty much done for things I that use regularly.


why is the package.json still 1.0.0 when you have dependencies and code changes?

Can you please bump up the versions in your package.json to reflect the recent changes?
Much appreciated, this will help us as consumers of your package to track changes and version control.

I could bump it to 2.0.0 since that is likely the next version to be released.

I was going to post the same issue. One of the upsides of doing it is that at the moment npm audit reports a production vulnerability linked to json-schema-faker. Since the the latest commit have upgraded that library, this fixed the problem. I.e. releasing a new version would allow using this library without npm audit vulnerabilities.

Since I've never followed this approach before, bumping master before you know which version it will apply to, what is the suggested approach?  Is there some npm/semver/package.json documentation somewhere saying how we should do this?

I am trying to understand what the problem is: can't you bump the version in package.json then publish to npm?

I'm not saying there is a problem, I'm asking for details on the convention.

I am sorry, I think there must be something I do noy understand. The convention seems to be to bump the version in package.json, update changelogs, use git tag then run npm publish but you definitely already know this, so I think I might not understand your initial problem.

It seems to me (correct me if I'm wrong) that following semver, and going through the new commits (which do not seem to introduce breaking changes but do introduce new features), it should be 1.1.0.

from my understanding, @whitlockjc is preparing for a v2 release but is not happy that the current code base is stable enough to push something out now. He also thinks the current code base may have drifted too much from v1 that the next update should be a major update.
If the above is correct, I'd recommend releasing the current code base as v2 prerelease (e.g. 2.0.0-alpha.1)
I think regular releases would benefit most users, and if @whitlockjc isn't happy they're stable then doing them as prereleases should hopefully keep everyone happy :-)

https://semver.org

Hum: https://github.com/apigee-127/sway/issues/157
It's my humble opinion that all changes to master should result in a version change and a publish.
A good way of implementing this would be:

Lock master branch (can be done through the configs)
All changes go through PRs and optionally, link these to some very light CI to validate the changes
Version changes can follow the same flow (PR for the package.json change), and then you'd just need to run npm publish

That way, all the users can choose how they receive package updates.

@fed135 I like the idea.  Let's say we're in the spot we are now (nearing v2.0.0 release, master hasn't been managed the way you're suggesting, etc.), how do we get there ASAP?  I'm cool with the whole "all changes go through PRs" bit (although I'm not sure I want to wait to get PRs approved for my own changes), all master changes become some new automatically-versioned, pre-release version that is published.  But...how?  Want to help?

I've just now implement full CI on my new OSS, I can definitly help :)

I'm already using Travis to do CI but we're not doing CD on master and I think that's a cool idea.

#177

seems to me that updating package.json as part of a pull request would be rather tedious. What happens when there are multiple pull requests open at the same time? How do you manage who sets their version to what?
Seems like there's a step missing here.

It is indeed, it's a shortcut that only projects with one or two maintainers can take.
If you're up for it, you could add a next branch to your repo, lock it and mark it as default. PRs will all go to this branch, and when you feel comfortable bumping the package version, you just create a PR from next to master.
This approach is closer to the classic git workflow: https://nvie.com/posts/a-successful-git-branching-model/

package.json is now at 2.0.0.  I'm going to close this for now but I do hope the discussion continues.  Once we have an agreed-upon plan, we'll create an appropriately described/named issue to do the work.


Release 0.2.4

@JuliaRegistrator register(branch=release)

Registration pull request created: JuliaRegistries/General/15243
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.4 -m "<description of version>" c48508d564171d3bd51e8d1a9af312e0703f459e
git push origin v0.2.4


Prepare for Release 0.0.5

Description

Add icon image for package
Updated README

@nagata-yoshiteru I've added a icon image for the vscode store (its the same as my old extension) Let me know if you have something you like better and then we can change it. I've also updated the readme with all of our features.
I think after this is merged in we can reupload the extension. At this point, since this extension has P2, P3 support I'll remove my old extension from the store.
It has been a pleasure working with you! I think after we upload this new release we can stop doing updates for a while unless of course someone logs an issues report. Thank you again for taking me on!

Actually there might be a few other features that I would like to add 😅, but we can probably work on these later:

[ ] Showing the pixel data in the zoom panel for the pixel your mouse is over
[ ] Auto refresh viewer when file has changes

Hello, @BenWeisz!
Thank you for preparing release v0.0.5. I think the icon is excellent and suitable for our extension!
I added a minor update in README.md, CHANGELOG.md, and package.json. So I think we are ready to release v0.0.5! If there is no problem, I will release the update to the store.
After releasing v0.0.5, I also think we can stop doing updates. However, there are also some features I want to add in the future:

[ ] Zoom in and out with Ctrl key + mouse scroll
[ ] Performance improvement for large images
[ ] Support more wide variety of image formats

I have been very exciting to work with you! It's my first time collaborating with others on GitHub, but you are very kind and helpful! So I could work with you very easily. Thank you for collaborating with me!

Awesome! 😃 I'll merge this in and open up a new issue for the features we've suggested for the future. Thank you again!

I've also removed my original extension from the marketplace and will be deleting that repo

I released v0.0.5 in the marketplace now. Thanks!

Hello, @BenWeisz!
I found a tiny issue when loading commented images, and fixed this bug!
Also, I already published the v0.0.6 release.
If you found any issue with this fix, please tell me!
Thanks!

@nagata-yoshiteru Thanks you for fixing that! I'll let you know if I see any other issues


Build error on NVIDIA Jetson TX2

Issue Description
I got the build error after mvn clean install
[ERROR] Failed to execute goal on project nd4j-native: Could not resolve dependencies for project org.nd4j:nd4j-native:jar:0.9.2-SNAPSHOT: The following artifacts could not be resolved: org.bytedeco.javacpp-presets:openblas:jar:linux-aarch64:0.2.19-1.3, org.bytedeco.javacpp-presets:mkl:jar:linux-aarch64:2017.3-1.3: Could not find artifact org.bytedeco.javacpp-presets:openblas:jar:linux-aarch64:0.2.19-1.3 in central (https://repo.maven.apache.org/maven2)
Here's the full mvn clean install output:
https://gist.github.com/iandow/ecdbe5eba5408603a09d052e9e6edd99
Version Information

platform information: NVIDIA Jetson TX2, Ubuntu 16.04:
CUDA version: 8.0.72

Looks like we need a 64-bit version of CUDA and OpenBLAS for ARM to run on that platform.
We will need to create builds for those as well:
https://github.com/bytedeco/javacpp-presets/tree/master/cuda
https://github.com/bytedeco/javacpp-presets/tree/master/openblas
If you have further discussions regarding those, open a thread over there. Thank you!

BTW, @vb216 might be interested in working those builds...

Hi,
Was this resolved ? having the exact same problem :/

need to compile some  javacpp-presents sub projects  first ,  at lestest  opencv cuda  leptonica ffmpeg  hdf5  ,but most of the projects do not support aarch64 or arm64 ,need to change cppbuild.sh .
libnd4j compile cuda version need create swap file first
deeplearing4j at jetson tx2  with cuda's performance  is close to  my MBP  2GHz With cpu

@Spawn32 @jackerxff We only really need OpenBLAS and libnd4j for starters


Mismatch typing of Transaction with sequelize

Versions

sequelize: ^5.12.3
sequelize-typescript: ^0.6.11
typescript: ^3.5.3

I'm submitting a ...

[x] bug report
Reproduce:
I define the model and using transaction like this
import { Column, Table, Model } from "sequelize-typescript";
import { Transaction } from 'sequelize';

@Table
export class Todo extends Model<Todo> {
  @Column
  name: string;
}

const createTodo = async (transaction?: Transaction) => {
  await Todo.create({ name: 'abc' }, { transaction });
}

Actual behavior:
Getting error
Argument of type '{ transaction: Transaction; }' is not assignable to parameter of type 'ICreateOptions'.
  Object literal may only specify known properties, and 'transaction' does not exist in type 'ICreateOptions'.

Expected behavior:
No errors

Hey @phinguyen19 please use sequelize@>=5 together with sequelize-typescript@next (1.0.0-beta.3)

@RobinBuschmann Solved my issue. Thanks.


Adding is_zero() to core::time::Duration

Hello Rust developers,
I apologize beforehand because I think this is a simple RFC, so I'm not going through full requirements of an RFC issue.
Would you please consider adding new function (below) to core::time::Duration?
/// # Checks if this duration is zero
pub fn is_zero(&self) -> bool;

When taking options from users, I find myself many times the need to check if a duration is zero. Perhaps it could be the same for other developers.
Thank you very much for your hard work,

For simple additions like this, you can just submit a pull request to get it added. But why do we need this? How would you implement this?

Though it is trivial to do with value == Duration::from_secs(0), I actually implemented this myself in the rewrite of the time crate. But I agree with @KrishnaSannasi, an RFC isn't necessary for something like this.

I don't think this is sufficient motivation though. Integers, floats and co. don't have a .is_zero() either. What is this actually used for?

@CryZe
Integers can be compared to 0 easily, for example:
let flag: u8 = ...;
if flag > 0 {
    // ...
}

A Duration can't be compared to zero. Comparing a duration to zero can be useful in case the program takes input from user but doesn't allow a zero-duration.

It seems in line with the various is_empty methods already existing.

@shepmaster
Thanks for your input. is_empty() is common to collections (string, vector, set, map, slice...) While a duration is not related to a collection.
However English is not my first language, so I'm not sure.

My point was that is_zero fits in the same conceptual space as is_empty, which we use instead of len() == 0. I agree such a thing could be added.
It would be nice to find a different word besides "zero" though. We have is_empty, not is_len_zero. Unfortunately, nothing obvious is coming up.
Another possibility is creating a const ZERO: Duration = ... in the time module.

I followed full procedure and made this pull request: https://github.com/rust-lang/rfcs/pull/2814

Closing this for the same reason as https://github.com/rust-lang/rfcs/pull/2814 – it is not necessary to go through the full RFC process for this small addition.


[setup] Make setup.py test work correctly

Without this change, running setup.py test depending on the environment either:
1. does nothing:
running test

or 2. incorrectly uses the unittest test collector, which then crashes on importing a module it shouldn't even try to import:
running test
running egg_info
writing dependency_links to click.egg-info/dependency_links.txt
writing click.egg-info/PKG-INFO
writing top-level names to click.egg-info/top_level.txt
reading manifest file 'click.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no previously-included files matching '*.pyc' found under directory 'docs'
warning: no previously-included files matching '*.pyo' found under directory 'docs'
warning: no previously-included files matching '*.pyc' found under directory 'tests'
warning: no previously-included files matching '*.pyo' found under directory 'tests'
warning: no previously-included files matching '*.pyc' found under directory 'examples'
warning: no previously-included files matching '*.pyo' found under directory 'examples'
no previously-included directories found matching 'docs/_build'
writing manifest file 'click.egg-info/SOURCES.txt'
running build_ext
_winconsole (unittest.loader._FailedTest) ... ERROR

======================================================================
ERROR: _winconsole (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: _winconsole
Traceback (most recent call last):
  File "/home/engshare/third-party2/python/3.5.0/gcc-4.8.1-glibc-2.17/4a1fbff/lib/python3.5/unittest/loader.py", line 153, in loadTestsFromName
    module = __import__(module_name)
  File "/home/engshare/third-party2/click/6.6/src/build-gcc-4.8.1-glibc-2.17/build/click/_winconsole.py", line 17, in <module>
    import msvcrt
ImportError: No module named 'msvcrt'

----------------------------------------------------------------------
Ran 1 test in 0.001s

FAILED (errors=1)

With this pull request, setup.py test does the right thing. The pull request also makes pytest and pytest-runner dependencies, both only when invoking setup.py test.
This also potentially simplifies the CONTRIBUTING file, you can just tell people to run setup.py test and it will take care of installing py.test for them.

We do not want to run tests from setup.py.


Define collaboration comments/annotations

From the discussion in #53 an important side-track has spun up:

Also, comments (which you have in content) are a completely separate thing (aka neither content nor asset) that I am working to define (as part of the Collaboration pieces of ACP). A comment (not unlike a layer or artboard) is a container for content/assets, not a type of either.
FYI: The basis for the model for comment is https://www.w3.org/TR/annotation-model/ - the W3C standard model for annotations/comments on which the ACP commenting system (aka RedHawk) is based.
— @lrosenth

This is coming just at the right time, because the type of comment that I had in mind when I suggested /content/usergenerated-comment.schema.json is a type of user generated content that you would make as a reader in response to a blog post or facebook post. (the stuff that people refer to when they say "always skip the comments")
The type of comment that @lrosenth seems to have in mind is more an editorial comment that is part of the production of an asset (but can also be applied to content, as illustrated by annotations in AEM).
It is clear that we have another example of the duality that we've already seen between @noahe's collaboration profile and @kstreete's customer/visitor profile.
Let's identify the commonalities and differences between the approaches taken in collaboration systems and moderation systems and define a schema for collaboration comments/annotations.

One thing that DC is doing right now is defining a review - the "container" for a collaboration workflow.  We aren't (as noted in #8) doing the actual comments but are defining the people, roles, metadata, etc.


Create nuScenes streaming wrapper

Basically, we just need a way to play-back the images from the nuScenes dataset so that they can be ingested in realtime from the processing pipeline.
There are some different ways we can approach this / some different approaches that will work, depending on how streamlined/robust we want the implementation to be.

Could use the nuScenes--ROS wrapper created by the same people who created the ROS2 wrapper around BEVFusion: https://github.com/linClubs/nuscenes2rosbag
The UVA team that made the RACECAR dataset provided a rosbag to nuscenes wrapper: https://github.com/linklab-uva/rosbag2nuscenes/tree/b501b4f1eb81395ec1ee4fdea80035fbda1e9bf6 I'm not sure if it works in the opposite direction though (doubt it).
Use the nuScenes dev-kit in a python script and just grab sequential inputs. This is the most primitive, but probably most simple answer only if if we're not using ROS to stitch these two stages together to create the end-to-end pipeline.

Just made a fork of the nuscenes-->rosbag converter

Okay, note to self: Just realized the nuscenes to rosbag converter is written in ros1 -- so I'll probably have to use a separate docker image to convert this.
Long term, for demoing this / reproducing results, it would probably be wise to just upload the converted rosbag so that we don't have to keep using this.

Managed to build their docker image for melodic by running docker build -t nuscenes2rosbag_ros1 . in the docker/ubuntu_1804_melodic directory within the repo

Was able to create two rosbags from two different scenes within the mini dataset. Will now try and convert those to bags we can use in ros2

Was able to convert the ros1 bags to ros2 db3 files and play them back and visualize in rqt:

As a note: scene 61 is the one for our project. Lots of traffic cones and construction barriers--that's what we want--and that's all we'll need for the demo.

Okay! Success! (kind of)
We got the images feeding into the BEVFusion model and it is outputting 3D object detections!

This is a good step. There will be, however, a bit more massaging necessary to get the output image that is published in the format that we want (the top down BEV of the 3D object detection). Not sure if this is going to involve playing around in the config yet or what.
 While we can do this in the downstream node as well, if it's easy enough to eliminate other object detections from the output BEV image via the config, then that route would probably just be cleaner.

Uploaded the ros bags to Google Drive: https://drive.google.com/drive/folders/1aDFnhStGaMPj4Y8QQ1qwfkTMykZ0i30G?usp=sharing
Also, I ultimately for this task, the "streaming wrapper" that we created is literally just going to be playing back the ros bag!


[bug] video player won't work

EDIT: the flask install part is the minor part of the bug, major part in next comment)
fresh pip install hub, tried to play from a video sample (cool API btw), says flask needs to be installed

after pip installing, actually the video won't play (ubuntu 20.04, using a conda environment on python version 3.7.13, on a jupyter notebook in visual studio code)

yoooo but using ds.visualize works! damn. that shits cool

@nollied Yeah, we currently don't support playing videos on colab :( It works on jupyter notebook and plays the video on a browser if you are running from terminal.

@FayazRahman this was on a local jupyter notebook instance

@nollied Tried on jupyter notebook and it works. But there seems to be an issue with VScode. I tried playing a video directly from a link and it didnt work:
import IPython
html = f"""<video alt="http://commondatastorage.googleapis.com/gtv-videos-bucket/sample/Sintel.mp4" width=500 controls autoplay seek loop>
                    <source src="http://commondatastorage.googleapis.com/gtv-videos-bucket/sample/Sintel.mp4" type="video/mp4">
                </video>
            """
IPython.display.HTML(html)

Closing since its an issue with VScode.


update(sources/drivers): refresh Falco Drivers page with updated info

What type of PR is this?
/kind cleanup
/kind content
Any specific area of the project related to this PR?
/area documentation
What this PR does / why we need it:
This PR tries to refresh the content of the Falco Drivers page with up-to-date info
Which issue(s) this PR fixes:
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Andreagit97
Once this PR has been reviewed and has the lgtm label, please assign jasondellaluce for approval by writing /assign @jasondellaluce in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Despite the little correction I did, lgtm.

ei @vjjmiras thank you very much for this! I would propose also changing the page title from Falco Drivers to Syscall Events since the section is called Event Sources, WDYT? @jasondellaluce

What is actually the source these events are retrieved from, the syscalls or the kernel?
I was thinking of Kernel Events, but that might not be correct, so Syscalls (Linux Kernel) could be a better title.

Good question, the source of these events is the kernel for ebpf and kernel module but this is not true for the userspace instrumentation, so probably we cannot use Kernel Events. I was thinking about Syscall events because all these events are generated when we enable Falco with the so-called syscall source and moreover we already have a dedicated section called Actions for dropped System call events
Probably System call Events is even better to be compliant with the aforementioned section...

/hold until Falco 0.33.0 gets released

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 067e6f3417596f46a321902f504d64b61a3b5562

/unhold


Add more content types as subcontent

Add more content types as subcontent.
Some content types seemed to cause trouble when used as subcontent, and I’ll have to add a workaround or the content type might need changing.

Requested

Matching: Not now. Not actively maintained by H5P Group.
Questionnaire: The currently released version 1.3.5 is not suitable as subcontent in a question-like context. It lacks the resetTask function for instance. The current development version 1.3.7 has that function, but is not working properly - and 1.3 could not be referenced anyway, beacuse of the API change. Will have to wait for the 1.4 version to be available.
JigsawPuzzle: Could give bad UX due to own audio mute button. Would need API to delegate audio handling to parent content type.

A very useful subcontent would also be a combination of text and image. At the moment I have to insert text into my images to achieve this, but that never really looks good and I lose all ability to customise that text through css later (and of course I can't change the text itself).

@citrulluslanatus https://github.com/otacke/h5p-game-map/issues/91

Yes, that would do it :). Thanks! I hope you find the time and funding.


router: Add logging to main function

This is to help diagnose intermittent TestOmniJobs failures, but is also useful in general.

LGTM


[App] Critical: Message: One or more errors occurred. (The SSL connection could not be established, see inner exception.)

[App] Critical: Inner exception: System.Net.Http.HttpRequestException: The SSL connection could not be established, see inner exception.
---> System.IO.IOException: Unable to read data from the transport connection: 远程主机强迫关闭了一个现有的连接。.
---> System.Net.Sockets.SocketException (10054): 远程主机强迫关闭了一个现有的连接。
--- End of inner exception stack trace ---
at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken)
at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.System.Threading.Tasks.Sources.IValueTaskSource<System.Int32>.GetResult(Int16 token)
at System.Net.Http.HttpConnection.ReadAsync(Memory1 destination)    at System.Net.Http.HttpConnection.RawConnectionStream.ReadAsync(Memory1 buffer, CancellationToken cancellationToken)
at System.Net.Security.SslStream.EnsureFullTlsFrameAsync[TIOAdapter](CancellationToken cancellationToken)
at System.Runtime.CompilerServices.PoolingAsyncValueTaskMethodBuilder1.StateMachineBox1.System.Threading.Tasks.Sources.IValueTaskSource.GetResult(Int16 token)
at System.Net.Security.SslStream.ReceiveBlobAsync[TIOAdapter](CancellationToken cancellationToken)
at System.Net.Security.SslStream.ForceAuthenticationAsync[TIOAdapter](Boolean receiveFirst, Byte[] reAuthenticationData, CancellationToken cancellationToken)
at System.Net.Http.ConnectHelper.EstablishSslConnectionAsync(SslClientAuthenticationOptions sslOptions, HttpRequestMessage request, Boolean async, Stream stream, CancellationToken cancellationToken)
--- End of inner exception stack trace ---
at System.Net.Http.ConnectHelper.EstablishSslConnectionAsync(SslClientAuthenticationOptions sslOptions, HttpRequestMessage request, Boolean async, Stream stream, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.ConnectAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.CreateHttp11ConnectionAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.AddHttp11ConnectionAsync(QueueItem queueItem)
at System.Threading.Tasks.TaskCompletionSourceWithCancellation1.WaitWithCancellationAsync(CancellationToken cancellationToken)    at System.Net.Http.HttpConnectionPool.HttpConnectionWaiter1.WaitForConnectionAsync(Boolean async, CancellationToken requestCancellationToken)
at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)
at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.HttpClient.g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
[App] Critical: Message: One or more errors occurred. (The SSL connection could not be established, see inner exception.)

Does this error prevent the app from starting?

Are your system's SSL certificates up-to-date? It appears the app is having trouble making a connection to the module registry

This does not happen in version 4.0, in 5.0 to avoid this error may require a VPN


Searching symbols hangs the UI

Version and Platform (required):

Binary Ninja Version: 3.2.3964-dev
OS: Windows
OS Version: 10 22H2
CPU Architecture: x86

Description
I have an executable with a lot of symbols in it, and when searching in the symbols pane the entire UI hangs. I'd expect the UI to not hang, and instead that the search be done asynchronously in the background.
As far as I can tell this was reported in #1979 and fixed; however in more recent versions this issue seems to have come back, and I did not want to necro a two year old issue.

This is due to the search being done on the main thread. This search needs to be done in a background thread.

Fixed in 3.6.4663-dev.


New article: An Introduction to Matrix Exponentiation

An introductory blog about the basics of matrix exponentiation and its applications.

@geekswaroop Please review my PR

@geekswaroop Please review my PR


unknown record type AF

I tried to validaty my airspace file by OpenairReader
I got ValueError: unknown record type AF.
This tag is used for storing frequencies of the airspace and it's an addition to the original, as written in http://www.winpilot.com/UsersGuide/UserAirspace.asp
validated airspace definition:
AC Q
AN DROPZONE Breclav 119.655
AF 119.655
AG Breclav RADIO
AH FL 95
AL 0 AGL
V X=48:47:27 N 016:53:33 E
DC 2 *NM

is anyone able to extend the reader with these additional tags?

You are using the OpenAir Extended File format. Currently aerofiles is unable to handle this. However, I am willing to extend it so that it can deal with it. Will need probably 1-2 weeks.

There is now a first implementation ready for test. Could you please try?

Thank you for such a quick response. I tested it, it can handle AF record now but it raises another error:
ValueError: could not convert string to float: '2 *NM' in handle_DC_record(self, value). Perhaps it doesn't ignore the '*NM' comment (I use it each time in DC parameter for preventing units mismatch)

Yes, I will take care. However, early on monday

CZ_all_24-08-07.txt
I can provide my file which i am trying to validate. It's quite complex one.

Parser improved for "*" inside lines, openair/reader can now validate files given on command line.
Above example sucessfully validated.

small problem still.
Error in file /home/bubeck/Downloads/CZ_all_24-08-07.txt invalid coordinate form at:  50:16:40 N 013:14:06 E
wait

Should be OK now to parse your example file. Please let me know.

Thank you very much, I was on holiday so I get back to it right now. It works! Also thanks for the hint.


Parse TEST_INSTANCE_PARAMS

Resolves https://github.com/testground/sdk-rust/issues/18

Added a changelog entry. Please point out if something is wrong since my English isn't very good. 😅

Thanks for the review! I bumped up the version to v0.3.0.

@ackintosh let me know in case you want me to cut v0.3.0 right away.

@mxinden Could you cut a new release when you have time? I would use the latest version in https://github.com/sigp/gossipsub-testground. 😃

@ackintosh for sure. Though should we get https://github.com/testground/sdk-rust/pull/22 in first?

Yes, please, after #22 has been merged. 🙏


UndefinedParserError, no parser can be inferred for

Describe the bug
This happens after it worked perfectly then in action evaluating rules step it gets this error however it pass!
In the PR it hangs forever in add-reviewers part as queued and gitstream in progress!.
{   e: UndefinedParserError: No parser could be inferred for file: requirements.txt       at normalize (/node_modules/prettier/index.js:7553:19)       at formatWithCursor2 (/node_modules/prettier/index.js:8822:50)       at /node_modules/prettier/index.js:37832:12       at Object.format (/node_modules/prettier/index.js:37846:12)       at /node_modules/@linearb/gitstream-rule-parser/dist/gitstream-rule-parser.cjs.development.js:1356:35       at Array.every (<anonymous>)       at Context.parseIsFormattingChange (/node_modules/@linearb/gitstream-rule-parser/dist/gitstream-rule-parser.cjs.development.js:1351:56)       at eval (eval at _compile (/node_modules/nunjucks/src/environment.js:633:18), <anonymous>:50:69)       at _callee$ (/node_modules/@linearb/gitstream-rule-parser/dist/gitstream-rule-parser.cjs.development.js:1161:13)       at tryCatch (/node_modules/@linearb/gitstream-rule-parser/dist/gitstream-rule-parser.cjs.development.js:97:17) }

Hi!
can you please add more information?
did the action passed (action is green)?
only the add-reviewer stuck at queued?
the error you add here is not a blocker, and not effected on the evaluation of the add-reviewer action :)


handle openapi encoding section to allow serialize x-www-form-urlencoded properties as json

Example:
      requestBody:
        content:
          application/x-www-form-urlencoded:
            schema:
              properties:
                someObj:
                  $ref: '#/components/schemas/SomeObj'
            encoding:
              someObj:
                contentType: application/json

someObj property should serialize as json string in http client request mapper

Resolved in #122


Tree: Post Order

Add a code file in C++ of Post order Traversal

Could you assign this to me?

Ok I have assigned this issue to you. Read the contributing guidelines and open a PR once done.

@amritansh22 - Updated my code, please check


Release stable version 1.1.6

This issue has been opened to track the release of Cloudbase-Init version 1.1.6.

Python 3.12.x is in a good stable shape and we plan to use it for the next 1.1.6 release.

For this release, we also plan to completely move from opendev to github.

A new tag has been created: https://github.com/cloudbase/cloudbase-init/releases/tag/1.1.6
This version of Cloudbase-Init has the Windows installers built with Python 3.11.9 version.
Stable installers are available at:
https://www.cloudbase.it/downloads/CloudbaseInitSetup_1_1_6_x64.msi
https://www.cloudbase.it/downloads/CloudbaseInitSetup_1_1_6_x86.msi

Published the release on Github: https://github.com/cloudbase/cloudbase-init/releases/tag/1.1.6


Static properties on components break tree-shaking

In our app we are finding that any time a component that uses styled-components has a static property added to it, that component is always included in the bundle even if it's not imported, i.e. tree shaking does not work. For example:
const Wrapper = styled.div`
    color: blue;
`

function MyComponent() {
    return <Wrapper>hi</Wrapper>
}
// this breaks tree-shaking
MyComponent.displayName = 'Foo'

In some cases we're able to remove the displayName or use default function argument values instead of defaultProps, but there are other cases where we do need to use these properties.
This seems to be caused by the way terser (or uglify-js) removes dead code and isn't really an issue in babel-plugin-styled-components per se, but it would be great if babel-plugin-styled-components could include an option to address this.

UPDATE: This only seems to affect class components. Some of our function components were failing to tree-shake as well, but it looks like that was actually because they were being used inside of class components that were affected by this issue.
I also discovered that React.forwardRef() breaking tree-shaking, but that's unrelated to styled-components.

(Note: deleted my previous comment. I got confused in my testing and what I wrote was incorrect. This is an issue for both class components and function components.)

This is very interesting, thank you for digging into this! :pray:
A PR that makes adds the IIFE wrapper (next to the PURE comment) when setting pure: true would be much appreciated, I definitely think the Babel plugin should be doing whatever it can to make tree shaking possible.

Great, glad you are open to including this. I can probably work on a PR for this sometime in the next week or two.

Amazing, can't wait @mbrowne! :pray:

For anyone who's interested, I created a test repo so that others can easily reproduce this issue, and also so that we have something to test against to ensure that my PR (when it's ready) covers all the bases:
https://github.com/mbrowne/CRA-error-template/tree/styled-components-tree-shaking
(be sure to check out this specific branch)
If you run yarn build on my demo, you can see that only Component1 tree-shakes correctly. (Earlier I thought that even that would break, because it seemed like this issue was affecting all of our library components, but fortunately in that simple case it's already working correctly.)

Is this issue actually specific to styled-components? Maybe i've got something goofed in my project i'm in currently, but regardless of using styled-components, if I add a static property (MyComponent.displayName = 'MyComponent') to the function component, then it no longer gets removed during dead code removal. But if I remove the static property then it gets removed. This was also the case prior to me adding babel-plugin-styled-comonents to my project.

@ammmze It isn't only an issue for styled-components. But in order to address it in a different plugin, that plugin would have to be aware of how to detect styled-components, and duplicate all that detection logic that's already included in babel-plugin-styled-components. Also, babel-plugin-styled-components already adds some PURE annotations in order to make tree-shaking work correctly, so it's logical that it should also handle the static properties case (displayName, etc).

Gotcha! So it looks like with the fix you have in the PR, it only seems to take effect for components are literally made from styled components (i.e. export const Foo = styled.div`color: blue`;) or functions that return styled components. Do you have any tips for function components that just return native react elements? Something like below doesn't seem to get wrapped like styled-components and functions that return styled-components.
const Foo = (props) => (<div {...props}>Foo</div>);
Foo.displayName = 'Foo';
export default Foo;

@ammmze Yeah, I had forgotten about that until someone pointed it out to me recently. They told me they're now using both my PR to this repo and my older plugin, babel-plugin-pure-static-props. I still think that all the use cases related to styled-components should be handled by babel-plugin-styled-components, and that other plugins shouldn't be concerning themselves with detecting styled components. But for other use cases, I'm thinking maybe I should un-deprecate babel-plugin-pure-static-props and update it with the efficiency improvements I made as part of this PR.

👍🏻  That is what I'm thinking. I think it makes perfect sense for the babel-plugin-styled-components to apply it to any component is created from styled components (i.e. const Foo = styled.div`color: blue`;), and functions that return styled-components...anything related to styled-components. But for vanilla I think it should be a separate plugin. I did try adding your deprecated plugin, but ran into some issues.
It blew up when it hit an old class component we have in our stuff...

@mbrowne FYI i've forked your project and i'm setting up test fixtures to cover some various use cases and I'll submit a PR when complete


Add/edit promtail directories to monitor for loki

On watchtower-bastion:
/opt/oci-hpc/logs/resize_watch-tower.log
/opt/oci-hpc/logs~

watch-tower-login- /var/log/messages, /var/log/secure

This was done.


add ndjson parsing

Allows use of hyperpipe to copy existing ndjson files (including other hypercore feeds) into a new feed while preserving each item as an entry.
hyperpipe ./feed-db --encoding='json' < my-data.json

Or copy an existing json encoded hypercore:
cat old-feed/data | hyperpipe ./new-feed --encoding='json'

nice!

3.1.0


Added short list command param:

Command-line args:
-s, --shortlist        List all configured environments in shorter format
Example:
supernova --shortlist

region1 (nova) @ https://region1.mycloud.com/v2.0/
region2 (nova) @ https://region2.mycloud.com/v2.0/
region3 (nova) @ https://region3.mycloud.com/v2.0/

Colors are questionable. I'd like a green/darkgreen.

I like the idea -- could you check out the tests to see why they're failing?

Totes

Disregard that test failure -- pip failed to download something. All other tox envs look fine.


HUE-9650 [Django Upgrade] Old-style middleware using settings.MIDDLEW…

…ARE_CLASSES is deprecated

Any idea of how can I make progress for the test failing  TypeError: 'ContentSecurityPolicyMiddleware' object is not callable
https://app.circleci.com/pipelines/github/cloudera/hue/4157/workflows/ace66790-6d4e-4940-9dad-0d69e74a7619/jobs/5654.
File is at https://github.com/cloudera/hue/blob/master/desktop/core/src/desktop/middleware.py#L848

Any idea of how can I make progress for the test failing  TypeError: 'ContentSecurityPolicyMiddleware' object is not callable
https://app.circleci.com/pipelines/github/cloudera/hue/4157/workflows/ace66790-6d4e-4940-9dad-0d69e74a7619/jobs/5654.
File is at https://github.com/cloudera/hue/blob/master/desktop/core/src/desktop/middleware.py#L848

No need to subclass it with the compatibility class like the other middlewares?
https://github.com/cloudera/hue/blob/a3dbdf40d36439f3cf371b4841b34e39a3f9aa8d/desktop/core/src/desktop/middleware.py#L849
(and the middleware below too?)

No need to subclass it with the compatibility class like the other middlewares?
https://github.com/cloudera/hue/blob/a3dbdf40d36439f3cf371b4841b34e39a3f9aa8d/desktop/core/src/desktop/middleware.py#L849
(and the middleware below too?)


disabling/removing break points via browser devtools doesn't seem to work

Your environment

ruby -v: 3.2.1
rdbg -v: 1.7.1

Describe the bug
Breakpoint handling doesn't seem to work well with devtools integration. It seems that breakpoints can be added, but not disabled nor removed (i.e. they get disabled removed in browser devtools, but not in debug gem side in ruby process)
To Reproduce
Expected behavior
Have disable/enable of break points work
Additional context
In case it affects, running app inside docker container, and browser in localhost, rdbg port forwarded from docker container to localhost

Thank you for reporting.
Could you show us the sample program to reproduce this problem?

Unfortunately that may not be possible, since cannot share  app where I was trying this out

I may try sometime, but I already pretty much gave up trying with this "devtools" approach due to #902 (which made approach highly inpractical with docker container, which was having process constantly restarted with "rerun", more precisely multiple processes in different containers), and #901 and #904. Aka. I',m back using just plain CLI with remote debug.

I think that https://github.com/ruby/debug/pull/948 fixes this problem.
If you have any problem, please reopen or mention me. Thank you.


Added ca crt in provider secret [CD]

Originating issue: IBMPrivateCloud/roadmap#59800

/test all

/lgtm

/approve


⚠ Thumbnails API Endpoint has degraded performance

In 484b777, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 200
Response time: 4775 ms

Resolved: Thumbnails API Endpoint performance has improved in 76e6839.


Combining file and prompt uploads

After text-prompt uploads and uploading files to GPT@Azure are complete, try uploading at the same time (so uploading data and blueprints at the same time)

This is not relevant for OpenAI.
Mistral?


when using symlink it assumes .version/.revision-hash are in same directory

% ls -ld ~/src/zsh-syntax-highlighting
drwxr-xr-x  17 lexinator  staff  578 Oct 20 16:51 /Users/lexinator/src/zsh-syntax-highlighting
% ls -l ~/zload/zsh-syntax-highlighting.zsh
lrwxr-xr-x  1 lexinator  staff  64 Dec 19  2014 /Users/lexinator/zload/zsh-syntax-highlighting.zsh -> ../src/zsh-syntax-highlighting/zsh-syntax-highlighting.zsh

% exec zsh
/Users/lexinator/zload/zsh-syntax-highlighting.zsh:33: no such file or directory: /Users/lexinator/zload/.version
/Users/lexinator/zload/zsh-syntax-highlighting.zsh:34: no such file or directory: /Users/lexinator/zload/.revision-hash

I can work around this issue by linking these two additional files into ~/zload.
Update: I forgot to mention this started with v0.3 but works fine with cb5589d.
thanks

Thanks for the report.  Fixed.


Upgrade go-lang 1.21

Pull request

What this PR does / why we need it
Upgrade go-lang 1.21
Which issue(s) this PR fixes

Fixes #
Describe testing done for PR

Additional information or special notes for your reviewer

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (05edaae) 70.10% compared to head (3544ef3) 70.10%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #667   +/-   ##
=======================================
  Coverage   70.10%   70.10%
=======================================
  Files          17       17
  Lines         950      950
=======================================
  Hits          666      666
  Misses        263      263
  Partials       21       21

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Integrate with vgo

Make this package compatible with golang's proposed semantic versioning package manager.

Now has v0.1.0 tag, go.mod file and go.modverify file.


Add users section to website

In response to the[ data collected ](https://github.com/opencontrol/discuss/issues/33 suggest updating the website with the information

Seems like the RedHat entry is sitting below the "please add yourself by PR" block - can you bump it up with the others and then I'll merge this?
Thanks! (And thanks for your patience).

@joshuamckenty better!


feat!: throw error with out of bounds integer values, add custom 'integerValue' type cast option

Fixes #147

[x] Tests and linter pass
[x] Code coverage does not decrease (if any source code was changed)
[x] Appropriate docs were updated (if necessary)

As per discussion, implementation follows design in the document

On default detect if value is out of bounds of Number
Allow user to pass a custom typeCastFunction to be used to convert integer values

Give user an option to specify property names to be converted by typeCastFunction

@crwilcox were we comfortable with making this a major release of datastore? I know we're trying to keep major bumps infrequent, but this seems like a reasonably useful refactor to consider one.

So just a general note, I didn't realize that the type cast function would only apply to integers. Not sure if I missed a separate conversation leading to this PR, but I think this would be useful for all data types, not just integers.

My logic here is, that library doesn't have an issue with correctly obtaining all other value types and if any conversions/manipulations are required, the user can do them after getting the values from this library.
With regards to numeric types there is an issue of obtaining accurate large integer value.
Another point is, I wouldn't want to incorporate third party code more than I have to. Not to subjugate the library to performance impact, bugs, etc... from third party.

@AVaksman makes sense, I might be bikeshedding but if this only applies to integers we might want to revisit the name? Though if no one else feels the same way I don't feel super strongly about it 😄

Refactored to
typeCastConfig => integerTypeCastOptions
typeCastFunction => integerTypeCastFunction

Based on the PR description, I can't really figure out what the breaking change is. Can you add a really clear message in there for the release notes, including before code and after code?

The breaking part is that now in case of integerValue is out of bounds of Number the API will throw an error instead of truncating the value as before.
Users who needed to accurately obtain out of bounds integer values, couldn't. So they probably didn't use this functionality, hence practically speaking this is not breaking change.

@AVaksman ah in that case - can you drop the ! from the commit title and PR title?

Roger that

@jkwlui Does everything look good here for you after the latest fixes?

Quick summary
Would like to hear the thoughts on the approach

Throw on default, let user pass integerTypeCastFunction (currently implemented in this PR)
Return an object Integer similar to Spanner, where

#valueOf would try to convert to Number and throw if out of bounds
#value returns string representation of the value

Combine tow approaches above

do return an Integer object
let user provide integerTypeCast function to be used by #valueOf
still return string via #value

from @stephenplusplus

My vote would go for #3.

@AVaksman maybe it'll just be us deciding 😆 What is your preference?

@stephenplusplus I do like option 3 as well, @bcoe 's vote goes to # 1

@AVaksman @stephenplusplus @bcoe what's the next steps here?

The next step would be to decide between approach in this PR vs #516

I don't see us going back to this after where we landed in #516, so I'll just close for now to avoid any confusion.


#155108851 add favorites

Coverage remained the same at 86.592% when pulling df1e126bec01f563f76e72ef3db2bea720b06c7f on feature/#155108851/add-recipes-as-favorites into bc1ef98ee3cb572a11de7f504d6de992d2d8f796 on develope.


Perplexity

The metric computes the likelihood of generating the text Y after the text X (i.e. P(Y|X))
There is no clear alignment between X and Y, and the notions of reference and prediction as used in Unitxt.
After consulting with Yosi Mass, we think it makes sense to treat them this way:

X = prediction
Y = reference.

I think you also need to commit the json files.

I just pushed them now

Perhaps use this naming convention:
instead of
src/unitxt/catalog/metrics/perplexity/flan/t5/small.json
use
src/unitxt/catalog/metrics/perplexity/flan_t5_small.json
So there will be less directories.

fixed


@LoadBalanced in combination with OAuth2 creates autowiring problem

@LoadBalanced in combination with OAuth2 creates autowiring problem. If you switch on @EnableOAuth2Sso an app that was happily @Autowiring a RestTemplate will suddenly fail because there are 2 load-balanced templates (one oauth2 and one vanilla).

I'm not sure there's is anything we can (or should) do about this. The scenario where user adds spring-cloud-starter-oauth2 to an existing @EnableOAuth2Sso app is what we need to focus on. It will fail to start and Spring will print a message saying that there are 2 beans of type RestTemplate. Leaving it open for discussion.

The usage has changed in Spring Cloud Commons now, so users have to create their own @LoadBalanced rest template beans (and we modify them). This is neater for everyone. Unfortunately (possibly) Spring Boot still creates an @OAuth2RestTemplate bean, but it is @Primary and not @LoadBalanced so it is easy to distinguish from the load balanced one.

@dsyer  What is your proposed solution then?  I am seeing the below and I am not creating any RestTemplate.
2016-04-05T14:46:11.71-0400 [APP/0]      ERR Caused by: org.springframework.beans.factory.BeanCreationException: Could not autowire field: private org.springframework.security.oauth2.client.resource.OAuth2ProtectedResourceDetails org.springframework.boot.autoconfigure.security.oauth2.resource.ResourceServerTokenServicesConfiguration$UserInfoRestTemplateConfiguration.details; nested exception is org.springframework.beans.factory.NoUniqueBeanDefinitionException: No qualifying bean of type [org.springframework.security.oauth2.client.resource.OAuth2ProtectedResourceDetails] is defined: expected single matching bean but found 2: eurekaOAuth2ResourceDetails,configClientOAuth2ResourceDetails

Spring Boot Version - 1.3.3.RELEASE
Spring Cloud Brixton.M5
Spring Cloud Services 1.1.0.M2

You have old versions there. Please upgrade and then open a new issue if you still have problems (and followed the guidelines about creating your own rest template).

Hmm I am one behind, I didn't realize a new version was out.  Let me try and thanks,


Cow: Watch Drop_Notcoin_Robot(?# t.me)

Cow requests the watch of the watch_keyword Drop_Notcoin_Robot(?# t\.me). See the MS search here and the Stack Exchange search in text, in URLs, and in code.

A duplicate of this PR was created, because MS didn't report its creation into chat. Given that there isn't a comment from MS on this PR, presumably MS wasn't notified. That's probably a result of the DNS issues.


ENH: better construction of dict arrays and distance matrices

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

28 of 29 (96.55%)  changed or added relevant lines in 2 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.007%) to 92.112%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/cogent3/util/dict_array.py
8
9
88.89%

Files with Coverage Reduction
New Missed Lines
%

src/cogent3/maths/scipy_optimize.py
2
84.92%

Totals

Change from base Build<PHONE_NUMBER>8:
-0.007%

Covered Lines:
33304

Relevant Lines:
36156

💛  - Coveralls


Fixes for Text-Orientation

My Past PR edited chrome data, not fx ones

Ah yes, should have caught that. Thanks!


Support for Round Lyrics

Is there a way that the next iteration of the Lyrics script could apply controls to multiple text sources, applying the same set of lyrics to two, three, or four boxes, staggered by a page?  So that a single forward-page command would advance all text boxes simultaneously, with controls for staggering?

[lyrics+.lua] Failed to call modified_callback for modified_callback: /run/user/1000/doc/3fb285ec/lyrics+.lua:567: bad argument #1 to 'ipairs' (table expected, got nil)


SDK 0.6.2 - No candidates seen apart from main method's candidate

Describe the bug
On starting the application in Local mode with sdk 0.6.2 a candidate for only the main method is seen.
If other methods are DirectInvoked, no candidates will show up.
Project : unlogged-spring-maven-demo
Reproduction steps

Set sdk version to 0.6.2 for unlogged-spring-maven-demo and start application in Local mode.
Directinvoke any method/Any number of methods

No candidates outside of main method will show up.
Expected behavior
Candidates for other methods invoked should show up.
Additional context
This is not happening on 0.6.1.

Share idea.log

Ide logs ->
idea.log


Argument mismatch between bosh cpi and softlayer CPI for VM deletion

When trying to do a simple deployment to SL, we are getting the following:
D, [2016-04-07 21:54:51 #32412] [] DEBUG -- DirectorJobRunner: External CPI sending request: {"method":"delete_vm","arguments":["17309677"],"context":{"director_uuid":"d4f53e59-f1ea-4290-9789-4cd5a1d4c7d5"}} with command: /var/vcap/jobs/cpi/bin/cpi
D, [2016-04-07 21:54:51 #32412] [] DEBUG -- DirectorJobRunner: External CPI got response: {"result":null,"error":{"type":"Bosh::Clouds::CloudError","message":"Extracting method arguments from payload: Not enough arguments, expected 2, got 1","ok_to_retry":false},"log":""}, err: , exit_status: pid 32429 exit 0

In looking at the code on each side of the junction, it appears that bosh expects to provide only the VM cid see here.
It looks as if the SL CPI, however, is expecting two arguments, both the VM cid and an agent id, and this is causing our deployment to fail.
@ScarletTanager & @swetharepakula, RuntimeOG team

@ScarletTanager  Thanks for your trial !
Due to the specific requirement of SoftLayer infrastructure, bosh-softlayer-cpi-release-v1 could not work with the bosh version from community. As we implemented os_reload function in bosh-softlayer-cpi, there needs to be some changes to bosh release, just like  you mentioned, delete_vm of bosh.  Please try the offerings as follows:
https://github.com/cloudfoundry-incubator/bosh-softlayer-cpi-release/releases
We are looking forward  your comments, thanks!

@jianqiu - thanks for the response.  I have a couple of comments:

I'm decidedly not a fan of the nested tarball approach to packaging - there is no way to see what's really in the release tarball, since you just get more tarballs.  Not only that, but I think you have golang included twice in your release, since I get this (partial output) from tar tzf bosh_softlayer_cpi.tgz in the extracted packages directory:
./golang_1.5.3/
./golang_1.5.3/go1.5.3.linux-amd64.tar.gz

but there is also a golang tarball already present in packages...

in your packaging script, I don't see how the variables BOSH_PACKAGES_DIR and BOSH_INSTALL_TARGET are initialized.  I can try to work around that, but I I think some work/documentation is needed to make this production-ready.

@ScarletTanager

@jianqiu - still getting an error, albeit a different one:
D, [2016-04-08 15:23:04 #3532] [] DEBUG -- DirectorJobRunner: External CPI sending request: {"method":"delete_vm","arguments":["17309677"],"context":{"director_uuid":"d4f53e59-f1ea-4290-9789-4cd5a1d4c7d5"}} with command: /var/vcap/jobs/cpi/bin/cpi
D, [2016-04-08 15:23:04 #3532] [] DEBUG -- DirectorJobRunner: External CPI got response: , err: , exit_status: pid 3549 exit 1
E, [2016-04-08 15:23:04 #3532] [] ERROR -- DirectorJobRunner: Worker thread raised exception: Invalid CPI response - SchemaValidationError: Expected instance of Hash, given instance of NilClass - /var/vcap/packages/director/gem_home/ruby/2.1.0/gems/bosh_cpi-1.3215.3.0/lib/cloud/external_cpi.rb:141:in `rescue in validate_response'

Thanks,
@ScarletTanager

@ScarletTanager
Could you please look into the bosh-softlayer-cpi-release project, we had already made some documents there on how to use bosh-init to deploy bosh director with softlayer-ecpi.
https://github.com/cloudfoundry-incubator/bosh-softlayer-cpi-release/releases

For bosh-softlayer-cpi-release-v1, you need to use customized bosh release (not the version of community), bosh-softlayer-stemcell, our bosh-init.
you can download them from v1.49.0 release notes.

@jianqiu - I am using the community directory with your 2.1.0, about which you state, "from this release, you can use the BOSH release from community."  Is that not actually the case?

@ScarletTanager  That is fine, could you please show me your manifest yaml for bosh director? And how did you use the cpi release? Thanks!

@jianqiu - before we deploy the 2.1 CPI, we need to know whether or not we can expect the delete_vm operation to work - is it still broken in the 2.1 CPI, or should we expect full functionality to be available?

@jianqiu - we are getting this error on bosh-init deploy with the 2.1 CPI and your 2.2 candidate bosh release:
Command 'deploy' failed:
  Installing CPI:
    Rendering and uploading Jobs:
      Rendering job templates for installation:
        Rendering templates for job 'softlayer_cpi/71a8bf55509afc4ba579169135d0ca2baf21f690':
          Rendering template src: cpi.json.erb, dst: config/cpi.json:
            Rendering template src: /root/.bosh_init/installations/0216f9be-251a-41c7-5c50-407eb315b090/tmp/bosh-init-release923838271/extracted_jobs/softlayer_cpi/templates/cpi.json.erb, dst: /root/.bosh_init/installations/0216f9be-251a-41c7-5c50-407eb315b090/tmp/rendered-jobs502132488/config/cpi.json:
              Running ruby to render templates:
                Running command: 'ruby /root/.bosh_init/installations/0216f9be-251a-41c7-5c50-407eb315b090/tmp/erb-renderer174056314/erb-render.rb /root/.bosh_init/installations/0216f9be-251a-41c7-5c50-407eb315b090/tmp/erb-renderer174056314/erb-context.json /root/.bosh_init/installations/0216f9be-251a-41c7-5c50-407eb315b090/tmp/bosh-init-release923838271/extracted_jobs/softlayer_cpi/templates/cpi.json.erb /root/.bosh_init/installations/0216f9be-251a-41c7-5c50-407eb315b090/tmp/rendered-jobs502132488/config/cpi.json', stdout: '', stderr: '/root/.bosh_init/installations/0216f9be-251a-41c7-5c50-407eb315b090/tmp/erb-renderer174056314/erb-render.rb:180:in `rescue in render': Error filling in template '/root/.bosh_init/installations/0216f9be-251a-41c7-5c50-407eb315b090/tmp/bosh-init-release923838271/extracted_jobs/softlayer_cpi/templates/cpi.json.erb' for softlayer_cpi/0 (line 40: #<TemplateEvaluationContext::UnknownProperty: Can't find property 'agent.blobstore.address', or 'blobstore.address'>) (RuntimeError)
	from /root/.bosh_init/installations/0216f9be-251a-41c7-5c50-407eb315b090/tmp/erb-renderer174056314/erb-render.rb:166:in `render'
	from /root/.bosh_init/installations/0216f9be-251a-41c7-5c50-407eb315b090/tmp/erb-renderer174056314/erb-render.rb:191:in `<main>'
':

I have attached our manifest (user/pws scrubbed) here:
rtog-sl-bosh-init.yml.txt
I do see a blobstore.address property in at least one location in our manifest, but I'm not sure in what context that error message is being generated, so I am unsure how to fix.  Can you please take a look?
Thanks,
@ScarletTanager & @jberkhahn, CF RuntimeOG team

@ScarletTanager
Sorry of the misunderstanding for the deploy using bosh-softlayer-cpi-v2.
The main problem is that you are using the wrong manifest yaml, please take this as reference:
https://github.com/cloudfoundry-incubator/bosh-softlayer-cpi-release/blob/develop_v2/docs/bosh-init-usage.md
And I just corrected the manifest for you, please try it again
rtog-sl-bosh-init-V2.yml.txt

@ScarletTanager @jberkhahn
We will update our readme in future.  Sorry for the confusion caused to you.

I am closing this issue as being resolved. If others feel differently, please reopen with reasoning.


For order flow

Fixed address issue and added decrement from inventory feature

Guest checkout is still broken we should get that fixed.


[feature] Rename private-repository input

Is your feature request related to a problem? Please describe.
The private-repository input is unfortunately named, especially considering that it is a boolean flag. private-repository: true makes me think "Yep, I'm using this in a private repository, better set it."
Describe the solution you'd like
Rename the input to something less confusing, whatever that may be. push-to-public-rekor maybe?
Describe alternatives you've considered
The private-repository could be replaced by a dict option as part of making rekor configurable (#372):
rekor-configuration:
  use-public-rekor: false
  rekor-url: https://rekor.blabla.com

Additional context

The private-repository could be replaced by a dict option as part of making rekor configurable (https://github.com/slsa-framework/slsa-github-generator/issues/372):

Big +1 ! We should be doing configurable sigstore instances this quarter, and moving smoothly to a dictionary option would be the best. I would propose something like
sigstore-configuration:
   instance: (staging, pre-production, public [default]) // One of pre-set configured instances
   custom-root: my-custom-tuf-root
   custom-mirror: my-custom-tuf-mirror // TUF repository contains the URLS for the services
   push-to-public: true // If using the public instance, allow private repo push. must be explicitly set for private repos

Either instance of custom-root/custom-mirror are specified.
This forces users to use a whole sigstore TUF instance. so if they want to push to a private repository, they must have a private TUF repository distributing the key material (https://blog.sigstore.dev/sigstore-bring-your-own-stuf-with-tuf-40febfd2badd). It doesn't suffice to just specify the service URLs, you also should validate the signatures they send back with trusted key material. If we didn't want to go that route, we'd need a way to specify the service URLs AND their keys:
sigstore-configuration:
   instance: (staging, pre-production, public [default]) // One of pre-set configured instances
   custom-rekor-url: my-custom-rekor
   custom-rekor-key: custom-rekor-pubkey
   custom-fulcio-url: my-custom-fulcio
   custom-fulcio-ca: custom-fulcio-root
   custom-ctfe-url: my custom-ct
   custom-ctfe-key: custom-ct-key
   push-to-public: true // If using the public instance, allow private repo push. must be explicitly set for private repos

That seems a lot messier. :| A TrustRoot protobuf is being defined in https://github.com/sigstore-protobuf-specs, so we could also use something like a serialized protobuf holding this info, similar to the TUF configuration:
sigstore-configuration:
   instance: (staging, pre-production, public [default]) // One of pre-set configured instances
   custom-trust-root: my-custom-trust-root // Contains service URIs and trusted key material
   push-to-public: true // If using the public instance, allow private repo push. must be explicitly set for private repos

For reference, the suggested flag for allowing recording on the public ledger for npm is --force-public-provenance.
https://github.com/npm/rfcs/blob/main/accepted/0049-link-packages-to-source-and-build.md#what-goes-on-the-public-rekor-ledger


IGVF-375-facets

I changed the boost for the measurement_set schema because boosting a LinkTo field caused searches to crash when faceting on a property of the LinkTo object.
A lot of mapping file changes which you can ignore.

Didn't we rename "boost"?

Well, it’s actually boost_values.

@keenangraham @mingjiecn was it supposed to renamed "include_in_search" or something to that effect

@keenangraham @mingjiecn was it supposed to renamed "include_in_search" or something to that effect

We discussed it for SNO2-17 but it started to get out-of-scope with too many other changes.
I've made a follow-up ticket to make that specific change: https://igvf.atlassian.net/browse/SNO2-29

@gabdank award.name gets used in nearly every object for the Attribution section of the object page. Since we rely on embedding for facets, I just rely on embedding for every property I use that attribute for, so that I don’t both embed and make a separate request to igvfd.

Closing the PR so I can make the changes agreed to at the 2023-03-23 dev meeting, where I only embed those properties needed for faceting. I’ll reopen the PR once all that’s done. I also need to rebase the branch.


Is there a way to use this script with multiple VPN Connections ?

Hi,
I have multiple OpenVPN connection setup in DSM for easy access to different OpenVPN Servers.
I have read that your script only works with one vpn connection added in DSM, so my question is if it is possible to alter the script to use when there are multiple VPN connections.

Yes – version 1.4.0 was just released. With the new VPN_PROFILE_NAME option, you can run multiple instances of the script, each targeting a specific VPN profile.


String.words and String.lines don't return empty list for blank string

Currently String.words is an alias for Elm.Kernel.String.words. Likewise, String.lines is an alias for Elm.Kernel.String.lines.
These functions are defined using the JavaScript string split function as:

String.words: str.trim().split(/\s+/g)
String.lines: str.split(/\r\n|\r|\n/g)

JavaScript's string split always returns at least one substring. This means that:

String.words returns [""] for a zero-length or whitespace-only string.
String.lines returns [""] for a zero-length string.

Is this intentional? IMHO it would be more intuitive if:

String.words: returned the empty list [] for a zero-length or whitespace-only string.
String.lines: returned the empty list [] for a zero-length string. For whitespace-only strings, a more complicated approach is needed.

Currently the documentation for these functions doesn't mention these boundary cases.

I just came across this regarding String.split. As far as I can tell, String.split cannot return an empty list. In my code I am doing this
    case String.split "?" url of
        path :: query :: [] ->
            -- ..
        path :: [] ->
            -- ..
        [] ->
            -- This case is impossible

To me, it is intuitive that String.split "?" "" returns [""]. In the same way that I would expect String.split "?" "hello" to return ["hello"].
What if instead of returning [] in these empty string cases, it returns a non-empty list? Like ("", [])?


Introduce Historical Task Definitions at Devtron UI

Summary
Task definitions should be visible at UI which should include image and config used for that particular deployment, so that one can revert on any historical deployment whenever required.
Motivation
We do have use-cases where we sometimes want to revert our app to last deployed config and image, but not every time we do save configs at our local history, thats why want devtron to provide us the same functionality.
Proposal
According to me, devtron must be logging its task definitions somwhere in EKS cluster, just need to expose the same to UI, like they do for pods.

Hey team! Please add your planning poker estimate with ZenHub @uxarya-d @manish-agrawal-ai @shivani170

In the first phase, dump all configuration changes whether deployment template, config map or secret in the dump table.


Add support for python 3.7

Codecov Report

Merging #66 (78d1d89) into main (d6ef7c0) will decrease coverage by 0.22%.
The diff coverage is 95.00%.

@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
- Coverage   86.99%   86.78%   -0.22%
==========================================
  Files           9        9
  Lines        1776     1793      +17
==========================================
+ Hits         1545     1556      +11
- Misses        231      237       +6


@ExplicitParamInjection change in behavior

I have two similar Test-Classes (in two seperate, but similar projects), one running with weld-junit5:2.0.2.Final (because it has to be compatible with the older API) and a newer Test wich runs with weld-junit5:4.0.1.Final.
These tests use jUnit5's @Nested-classes and additional extensions with parameter-resolvers.
In the older version it sufficed to put @ExplicitParamInjection on the surrounding test-class and it worked for all tests run.
In the newer version i apparently have to put the annotation on every @Nested-class, which is an unexpected and unwelcome bloat.
I would prefer the old behavior, or at least a hint in the annotation's javadoc and/or documentation.

Hello,
the @ExplicitParamInjection annotation isn't said to be 'inherited'  in any way so I am a bit surprised this was working in previous versions. There is only a very simple one-class test for this so we might have easily missed the fact that it previously scanned declaring class as well.
I suppose you could look at it the other way around and imagine a hierarchy of nested classes in which some require this annotation and others don't - with the approach you suggest, there would be no way to only make this option work for one test.
Not saying which one is better, just thinking aloud...
Note that one other way to enable this globally is a system property - https://github.com/weld/weld-testing/tree/master/junit5#explicit-parameter-injection
That way, you'd have it on for all tests (which may or may not be desirable) at all times.

I would prefer the old behavior, or at least a hint in the annotation's javadoc and/or documentation.

We should definitely at least mention it.
We could also consider adding a boolean (defaulting to false) to the annotation which would control if it affects nested classes as well. WDYT @mkouba?

Thanks for having a look at this.
Yes, i have seen no claim that the @ExplicitParamInjection annotation works for nested classes too.
But i think it is sensible to expect that, because this is the usual behavior:

From a java point of view, an inner class is still inside the same context as the outer class: an inner instance can access fields of outer instances

In jUnit, the outer configuration is still true for the nested class, for example @ForEach methods will be executed or @DisplayNameGeneration will be honored and extensions loaded will be applied

Even for weld-junit, the usual behavior matches. Other configurations of the weld extension are still valid inside nested classes, for example producer-methods defined in the outer class or beans included by @AddBeanClasses

Thanks for having a look at this.

Ah, this issue got completely off my radar, thanks for the reminder!
@snv would you care to submit a PR?

We could also consider adding a boolean (defaulting to false) to the annotation which would control if it affects nested classes as well. WDYT @mkouba?

@mkouba ? :)

We could also consider adding a boolean (defaulting to false) to the annotation which would control if it affects nested classes as well. WDYT @mkouba?

Another option is to add boolean flag to control the param injection, i.e. @ExplicitParamInjection(true) (default) and @ExplicitParamInjection(false). This way we could honor the annotation from the enclosing class (like in case of WeldInitiator) and support fine-grained control in the nested test classes.
Although the "Explicit" would be a little bit superfluous here and @ParamInjection would be probably a better fit.

Another option is to add boolean flag to control the param injection, i.e. @ExplicitParamInjection(true) (default) and @ExplicitParamInjection(false). This way we could honor the annotation from the enclosing class (like in case of WeldInitiator) and support fine-grained control in the nested test classes.

Ok, that's very close to what I suggested but has perhaps better default behavior. So +1 and let's do it this way.
@snv if you want to submit a PR with this, let me know. Otherwise I'll add it on my list but no promises in terms of how fast I am going to get to this :)

Although the "Explicit" would be a little bit superfluous here and @ParamInjection would be probably a better fit.

It is what it is and we don't want to break existing apps by changing it.
I am fine with the Explicit part as well because, well, you need to explicitly state qualifiers (even default for instance) to make param injection work. So in my eyes it's pretty close to what it does.

It is what it is and we don't want to break existing apps by changing it.

:+1:

I am willing to give it a try, but can't make any promises about when and how much time i get to invest there.

@snv I found some time to look into this and sent https://github.com/weld/weld-testing/pull/166 which should resolve the issue.
Nested classes will now look into their enclosing class for this annotation unless they explicitly specify it as well.
Classes can also use the newly added parameter to explicitly turn it off.


Typescript: support download prop

The download prop of the <a> tag allows web developers to indicate that a link (<a> tag) is intended to be downloaded as a file, rather than viewed in the browser. It's already possible to pass this prop to the <MenuItem> component; this change just tells Typescript that this is an expected/supported property.

Thanks for the PR! Released version 4.2.3 to include this change.