Use env variable for the sleep image in case of using other image ref…

What type of PR is this?

What this PR does / why we need it:

In Disconnected environment, the images with tags/digests are supported but use of image digest is more preferred because of immutability, consistency and security.
The update suggested in this PR allows to pass a test image as a environment variable which allows to use the image with digest for running  e2e test script in disconnected environment.
Use of environment variable helps to automate this test execution in CI/CD pipeline.

Which issue(s) this PR fixes:

Fixes #
Added provision to use environment variable for the sleep image in case of using other image reference in case of disconnected environment
Special notes for your reviewer:
Does this PR introduce a user-facing change?

My main concern with this is that the user may provide an image with a totally different behavior which has no chance to properly run the test.
In a disconnected environment, I think, you can just label one of your local images as gcr.io/k8s-staging-perf-tests/sleep:v0.1.0 and it will be used in the e2e test.
Ot should be loaded into the kind cluster here https://github.com/kubernetes-sigs/kueue/blob/fc7477d6559e34de2cbd6032ddb661300cc9c9f4/hack/e2e-common.sh#L47.

My main concern with this is that the user may provide an image with a totally different behavior which has no chance to properly run the test.
In a disconnected environment, I think, you can just tag one of your local images as gcr.io/k8s-staging-perf-tests/sleep:v0.1.0 and it will be used in the e2e test.
Ot should be loaded into the kind cluster here
https://github.com/kubernetes-sigs/kueue/blob/fc7477d6559e34de2cbd6032ddb661300cc9c9f4/hack/e2e-common.sh#L47
.

Hello @trasc , Actually the update suggested in this PR allows use of environment variable  to pass same image but with digest which in turn helps to automate this test execution in CI/CD pipeline for disconnected environment.
Thank you for reviewing !

@denkensk @mimowo @kerthcet @trasc May I have your review on this PR?

@denkensk @mimowo @kerthcet @trasc May I have your review on this PR?

Hi, in my opinion you can work around this issue without any code changes, please try my proposal.

In a disconnected environment, I think, you can just tag one of your local images as gcr.io/k8s-staging-perf-tests/sleep:v0.1.0 and it will be used in the e2e test.

@denkensk @mimowo @kerthcet @trasc May I have your review on this PR?

So, IIUC the name of the image on your env is the same, you just want to be able to add the digest due to security reasons? If this is the case, would it work for you just to have an env var to specify the hash?

@denkensk @mimowo @kerthcet @trasc May I have your review on this PR?

Hi, in my opinion you can work around this issue without any code changes, please try my proposal.

In a disconnected environment, I think, you can just tag one of your local images as gcr.io/k8s-staging-perf-tests/sleep:v0.1.0 and it will be used in the e2e test.

Hi @trasc, I greatly value your suggestion and have considered this option to make it work, but it's not feasible!

@denkensk @mimowo @kerthcet @trasc May I have your review on this PR?

So, IIUC the name of the image on your env is the same, you just want to be able to add the digest due to security reasons? If this is the case, would it work for you just to have an env var to specify the hash?

@mimowo Thank you for your suggestion, I think it may work, and i will proceed with updating this PR accordingly!

One more question trying to get to the bottom of your use case.
if you just need the hash to be present on the running image for the pod, then instead of supplying the image as env var would it work for you to read the dijest during the build? For example using docker inspect in bash and supplying it to the runner, or reading inside the runner.
I think passing the dijest might bring overhead to maintenance for you if we have more testing images.

Hi @trasc, I greatly value your suggestion and have considered this option to make it work, but it's not feasible!

Can you elaborate on this?

/ok-to-test

Hi @trasc, I greatly value your suggestion and have considered this option to make it work, but it's not feasible!

Can you elaborate on this?

Hey @trasc @mimowo
Apologies for the late response, I have made changes in above PR exactly as you suggested :
Actually my usecase is particularly related to air-gapped environment where the ImageContentSourcePolicy(ICSP) and ClusterImageSet(CIS) are adjusted such as the images required must be referred to digest rather than tag.
The disconnected cluster pulls images from a specific set of mirrors instead of their original registry location. When ICSP is applied, the cluster uses image digest instead of tag to ensure consistency and immutability of images across different mirrors.
In case of running e2e tests in such disconnected environment, for this PR I considered 3 scenarios :

It will consider gcr.io/k8s-staging-perf-tests/sleep:v0.1.0 as default image for running E2E tests

Incase of providing different image, it can be provided using E2E_TEST_IMAGE environment variable (I guess this might help in preserving kind cluster e2e-test behaviour - https://github.com/kubernetes-sigs/kueue/pull/2570#discussion_r1690951585)

To use image digest version of same default image (I need your opinion on which method to select) :
i)   First way is to use FetchImageDigest() method in util/e2e.go  to fetch image digest of an existing default image similar to below mentioned code snippet, but it requires docker-cli to be installed as a pre-requisite (So skipped)
ii)  As suggested by @mimowo - https://github.com/kubernetes-sigs/kueue/pull/2570#issuecomment-2244595066, used separate E2E_TEST_IMAGE_DIGEST environment variable to specify digest to be used with the default e2e-test-image.. (Used this method)

func FetchImageDigest(image string) (string, error) {
	client, err := dockerClient.NewClientWithOpts(dockerClient.FromEnv)
	if err != nil {
	      return "", err
	}
	imageInspect, _, err := client.ImageInspectWithR(context.Background(), image)
	if err != nil {
	      return "", err
	}
	if len(imageInspect.RepoDigests) > 0 {
	      digest := strings.Split(imageInspect.RepoDigests[0], "@")[1]
	      return digest, nil
	}
	return "", fmt.Errorf("digest not found for image %s", image)
}

3. (I need your opinion on which method to select

I would be leaning to (3. ii). It also means less maintenance on your side as you don't need to pass the dijest as a variable.

(I need your opinion on which method to select

I would be leaning to (3. ii). It also means less maintenance on your side as you don't need to pass the dijest as a variable.

Hey @mimowo,  Is it ok to have docker-cli pre-requisite, because if we follow (3. ii) then docker-cli is mandatory to be installed for running kueue tests
Also still need flag USE_E2E_TEST_IMAGE_DIGEST as an environment variable so that if it is True then will fetch ImageDigest using FetchImageDigest(), otherwise will use image with tag

Hey @mimowo, Is it ok to have docker-cli pre-requisite, because if we follow (3. ii) then docker-cli is mandatory to be installed for running kueue tests

I think including https://pkg.go.dev/github.com/docker/docker/client as a dependency for tests is fine, but I would like to hear from @tenzen-y or @alculquicondor as well.

Also still need flag USE_E2E_TEST_IMAGE_DIGEST as an environment variable so that if it is True then will fetch ImageDigest using FetchImageDigest(), otherwise will use image with tag

That's ok.

Hey @mimowo, Is it ok to have docker-cli pre-requisite, because if we follow (3. ii) then docker-cli is mandatory to be installed for running kueue tests

I think including https://pkg.go.dev/github.com/docker/docker/client as a dependency for tests is fine, but I would like to hear from @tenzen-y or @alculquicondor as well.

Also still need flag USE_E2E_TEST_IMAGE_DIGEST as an environment variable so that if it is True then will fetch ImageDigest using FetchImageDigest(), otherwise will use image with tag

That's ok.

I'm ok with only supporting Docker.
But I know someone can use only PodMan or Lima due to license issues. For such developers, how do they perform E2E testing?

Hey @mimowo, Is it ok to have docker-cli pre-requisite, because if we follow (3. ii) then docker-cli is mandatory to be installed for running kueue tests

I think including https://pkg.go.dev/github.com/docker/docker/client as a dependency for tests is fine, but I would like to hear from @tenzen-y or @alculquicondor as well.

Also still need flag USE_E2E_TEST_IMAGE_DIGEST as an environment variable so that if it is True then will fetch ImageDigest using FetchImageDigest(), otherwise will use image with tag

That's ok.

I'm ok with only supporting Docker. But I know someone can use only Podman or Lima due to license issues. For such developers, how do they perform E2E testing?

@tenzen-y Yes I have this doubt too , that's why I was using 3.(i) to get image digest using env variable

But I know someone can use only Podman or Lima due to license issues. For such developers, how do they perform E2E testing?

I'm a bit surprised that using docker cli package for golang could be an issue. Does it imply using Docker aa a product? Also we use Kind for testing which is based on docker in docker, so I assumed this is a safe library.
I'm not an expert on licensing so Im fine with 3i if this is an issue. WDYT @alculquicondor ?

This PR is getting very complex..., 3.i ) might be simpler.

But I know someone can use only Podman or Lima due to license issues. For such developers, how do they perform E2E testing?

I'm a bit surprised that using docker cli package for golang could be an issue. Does it imply using Docker aa a product? Also we use Kind for testing which is based on docker in docker, so I assumed this is a safe library.
I'm not an expert on licensing so Im fine with 3i if this is an issue. WDYT @alculquicondor ?

Yeah, when I heard this limitation from users, I was surprised as well.
I meant that some companies do not allow employees to use Docker and are forced to use PodMan or Lima.
Actually, Kind supports PodMan, and we can start Kind with Podman: https://kind.sigs.k8s.io/docs/user/quick-start/#creating-a-cluster.
In that case, what happens when we depend on the Docker API? If there are no errors for Podman + Kind or other combinations, I'm ok with auto-detecting of disgust.

I would prefer to avoid the dependency. Why can't we just hard code the digest?

I would prefer to avoid the dependency. Why can't we just hard code the digest?

+1
I think we can just add the digest for "gcr.io/k8s-staging-perf-tests/sleep:v0.1.0@sha256:xxxxxxxxxxxxxxxxxxxx"

I would prefer to avoid the dependency. Why can't we just hard code the digest?

+1 I think we can just add the digest for "gcr.io/k8s-staging-perf-tests/sleep:v0.1.0@sha256:xxxxxxxxxxxxxxxxxxxx"

@alculquicondor @tenzen-y
Do you mean to update existing image gcr.io/k8s-staging-perf-tests/sleep:v0.1.0 to gcr.io/k8s-staging-perf-tests/sleep@sha256:8d91ddf9f145b66475efda1a1b52269be542292891b5de2a7fad944052bab6ea instead of getting digest using environment variable or instead of fetching digest using docker client ?
Just hardcoding image with digest is ok? @mimowo @trasc

Hard-coding sgtm. I still like getting the full name from a helper function to avoid updating so many places in the future if we bump the image

Hard-coding sgtm. I still like getting the full name from a helper function to avoid updating so many places in the future if we bump the image

Having a constant could also do it but it will be harder to keep it in sync with the image we are pushing in the kind clusters during e2e preparation.

3. separate E2E_TEST_IMAGE_DIGEST environment variable to specify digest to be used with the default e2e-test-image
@tenzen-y @alculquicondor @mimowo @trasc
Then using separate E2E_TEST_IMAGE_DIGEST environment variable to specify digest to be used for the default e2e-test-image, this will work, right?
It will just check if E2E_TEST_IMAGE_DIGEST is provided and if yes then will replace image tag with digest is it seems ok?

I would test if the hard-coding works in the way we run tests. If it does I would prefer the simplest (hard-code) for now.

Having a constant could also do it but it will be harder to keep it in sync with the image we are pushing in the kind clusters during e2e preparation.

It's still going to be better than today where we have the literal gcr.io/k8s-staging-perf-tests/sleep:v0.1.0 everywhere.
Still, the E2E test setup should probably set an environment variable with the full image name including sha.

/release-note-edit
NONE

/hold for Aldo's comment.

/lgtm

/retest

@abhijeet-dhumal the e2e tests fail - I'm guessing this is either due to adding the "@sha", or after moving E2E_TEST_IMAGE to the e2e-common.sh. Can you investigate?

/lgtm
Thanks!

@mbobrovskyi  @mimowo  @alculquicondor  @trasc @apodhrad @denkensk @kerthcet @tenzen-y
Thank you all !!
Your continued contributions have been a great help in improving this PR.  I truly appreciate it !  :blush:

/hold for Aldo's comment.

/hold cancel
The comment is addressed along with many other comments asked since then.

/approve
Thank you for the effort and for not getting discouraged by the back and forth before concluding on the final approach!


Forget to clear the _ever_prefetched flag in the CacheBlk::invalidate() function

The function clearPrefetched() doesn't clear the _ever_prefetched flag. It seems that here we need a clearEverPrefetched() like function. When that is applied, there is a slight change in scores(<0.02).
https://github.com/OpenXiangShan/GEM5/blob/6a85ffb479c8c1ecff432ddd5801216b4e829580/src/mem/cache/cache_blk.hh#L205-L209

We will evaluate its impact on performance.

Fixed, use clearAllPrefetched()


Fixes shortcuts steals from browser - Issue #979

As the title says, this simple pull request resolves issue #979, which is about the fact that our shortcut keys as they're implemented now steals the browser shortcut combinations like Ctrl+k to get to the search field and Ctrl+j to get downloads.
Maybe we should think of making a lightweight API for creating keyboard shortcuts. I've done something similar before and it's not really any problem. This would our way of settings shortcuts more "specific" instead of the switch statement we use now.

Nice and simple fix. Thanks!


NodeJS 10+ TimeoutOverflowWarning on MockDate.set

I was hoping to have a PR to give you with a fix instead of just opening an issue, but I've been bashing my head against a wall trying to track this one down. When I use MockDate.set() with NodeJS 10 and up, I get the following sample warning:
(node:63747) TimeoutOverflowWarning:<PHONE_NUMBER>614 does not fit into a 32-bit signed integer.

I've tracked it down to this specific line in set: https://github.com/boblauer/MockDate/blob/master/src/mockdate.js#L76
If I comment that line out, I no longer get the warning. But what's really weird is, if I set now to any integer, I still get the error. Only commenting out or setting to null seems to silence the error.
Would love to understand what exactly is triggering node to throw this error and understand it. My curiosity isn't letting this one go.

Which specific version of Node are you using? Does npm run test fail as well?

Any version of NodeJS 10.0.0 and up displays the warning, while below doesn't.

I'm trying to narrow down the use case out of my app. Will post a sample project here if I get there.

I can't reproduce with 10.9.0 on OSX.

Ok, so I've done some more debugging, and the issue seems to happen in conjunction with using the github API client library. They use the current date in the API request, which is why I'm trying to mock it. Best I can tell, they're doing some math on the results of Date.now() and I think MockDate is returning a string instead of an integer, meaning the math turns into concatenation, leading to the overflow. I'll keep digging.


Update broken links on the bounces glossary page

Expected content
Helpful Knowledge Base articles should link to correct article.
Actual content
The links currently point to Zendesk, which redirects to the SendGrid docs search page. I have to copy-paste the original article title, and search for it manually.
* [Drop Reason: Bounced Address](https://sendgrid.zendesk.com/hc/en-us/articles/203790456)
* [Bounce Forwarding APP](https://sendgrid.zendesk.com/hc/en-us/articles/200181478)
* [Implementing Bounce Notification For Multiple From Addresses](https://sendgrid.zendesk.com/hc/en-us/articles/200185178)
* [Email Activity & Bounces](https://sendgrid.zendesk.com/hc/en-us/articles/200181728)

Link to page:
https://sendgrid.com/docs/Glossary/bounces.html

letting us know about this @duncanleung!
The todo here is to update the links on the bounces glossary page to the latest links. You can add a relative link within our docs like this example: link text

Raised PR #3066


[BugFix] Fix PageCache memory tracking inaccurately when adjust size

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Fix PageCache memory tracking inaccurately when adjust size.
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] I have added user document for my new feature or new function

run starrocks_admit_test

run starrocks_admit_test

@Mergifyio backport branch-2.4


Not sure how to set up.

Hi, sorry that it is probably a dumb question as I am new to using hazard v2 and github but it says "Extract to ZIP to your Desktop and enter the Hazard-Token-Grabber-v2 folder. In there, just run start.bat and follow the instructions that it gives to you." where exactly do I enter the Hazard-Token-Grabber-v2 folder as it just says "In there" I tried putting it in cmd, python but nothing worked, I also tried opening the start.bat folder but something flashed on my screen then closed instantly, I believe thats the thing for the victim but I am unsure. Any help would be greatly appriciated.

I now realise that it means to go into the folder but now I am facing another problem, "just run start.bat" whenever I do this I think it is cmd that opens but it then closes instantly, I tried running as administrator but it did the same, am I doing something wrong?

Probably python not added to path, i'd just recommend you to use Rose-grabber. It got & ui builder & way more features than hazard. I think it should work for you then.


[Bug] Unable to find symbols for ApplicationInfo and InstanceCreateInfo in 0.37.0

Hi, not entirely sure why. But if I use any version of ash in 0.37.0 then you are unable to find symbols for ApplicationInfo and InstanceCreateInfo. There may be more but this is as far as I got without auto-complete before trying to figure out why. The code still builds just fine, you just don't get any auto-complete for functions or traits, etc.

If the code compiles, then this is an issue with whatever tool you're using that is malfunctioning, not with ash.

I thought that might be the case, but it finds it just fine in other versions and I don't know why it wouldn't for the latest. I am just using the Rust extension for CLion (which IIRC uses my rust toolchains rust-analyzer)

You should report a bug with the author of the malfunctioning tool.

Retitled, this can't possibly be an ash bug when it builds successfully (if anything caused by the sheer size of the bindings, it's an inconvenience).
For reference I'm pretty sure rust-analyzer is just fine on the latest ash bindings within vscode, I'm using it right about every day.


feat(streaming): introduce dml executor & dml manager

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Summarize your change

Introduce DML executor, which is responsible for merging the data from its upstream executor and from batch.
Introduce DML manager, which manages the communication between the DML executor and the batch executor.

Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)
#5949

Conflict #6487

Conflict #6487

Resolved.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: xx01cyx:x: UbuntuUbuntu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


BLD: Unpin pydantic as ERT has fixed their issues

Resolves #874
ERT has now solved their issues and closed https://github.com/equinor/ert/issues/9292.
It should be safe to unpin Pydantic in fmu-dataio again.


Add option to generate code excution commands/steps

This is supposed to be fuctinality added to report sub-command.
After quering neo4j and finding vulnerable workflows or actions, it should print an explanation about the exploit, and how it could be exploited - for example -
"Command injection through PR name is possible in this workflow -
PR NAME = 'foo";{bash_command} "'

This may be a feature for the new query library.
How I see it, we can implement an additional field for the each query, like attack-path, that explains the risk in the specified query.
I some queries we should explain the best practice reasoning (like pinned hashes), in other queries (like injection ones), we can show a demonstration for an exploit. This should be an optional field though.
WDYT @oreenlivnicode @elad-pticha ?


PATH environment variable not consistent for Extension Host

VSCode Version: 1.49.0 e790b931385d72cf5669fcefc51cdf65990efa5d
OS Version: macOS Catalina 10.15.6 (19G2021)

Steps to Reproduce:

Unfortunately it seems to be random

Description:
When running an extension locally (Extension Host) the result/value of process.env.PATH varies between it reflecting the PATH I have defined in my shell and just /usr/bin:/bin:/usr/sbin:/sbin
Basically most of the time the value of process.env.PATH corresponds to the results of typing printenv PATH in my terminal window (I use fish as my default shell) but sometimes it just returns /usr/bin:/bin:/usr/sbin:/sbin.
My extension uses execFile in order to run a command line tool that I have installed in a bin folder under my user home dir. however when process.env.PATH only return the "default" directories listed above, the command is not found (ENOENT).
While I appreciate there are several workarounds to this, it took me a while to figure out what was causing execFile to fail since the behaviour happens randomly and I would expect the value of process.env.PATH to be consistent.
Furthermore I never managed to reproduce this using the extension debugger (I ended up having to log the value of process.env.PATH to the extension output channel)

Is this randomness caused by whether you launch via the CLI or the dock? Note you'll need to close the app with cmd+Q in between checking as the environment won't refresh without fully exiting.

I almost always run it from the Dock and when I run it from command line it's usually from the VSCode terminal.
Another way the app is opened is when macOS launches it automatically after a reboot (e.g. if the OS freezes and you need to shut it down holding the power button).
I'll try to see if that is what's causing it, but I'm pretty sure it also happened a few times after running it from the Dock.
Thanks

I can confirm this problem too.

I can confirm that this happens by just launching it from the Dock:

launched VSCode the first time from the Dock and the PATH is wrong (/usr/bin:/bin:/usr/sbin:/sbin)
reloaded window ("Developer: Reload Window")
the PATH is now correct and execFile returns the PID instead of ENOENT
closed VSCode (Cmd +Q)
launched VSCode the second time from the Dock and now the PATH is still correct.

From what I remember using "Developer: Reload Window" does not always work either though (i.e. I'm sure I tried it before and the PATH was still "wrong" after doing it)

Related to #30847. And, the comment, https://github.com/microsoft/vscode/issues/30847#issuecomment-420399383, is helpful.
You can find similar issues searching with the words fish and PATH.

/duplicate #30847


Update to solid-js 1.8.17, and solidjs/router 0.13.3

I updated to the latest Solid-Js version and fixed a few resulting syntax changes

@goswinr I never used SolidJS, so I am not expert of it.
Would you like me to make you a contributor / provides NuGet permission to make release of the packages?
Of course, I will be available to answer your questions and provide feedback but like that I have one less repository to focus on for release etc. and it will probably make it easier to get new releases. 😇

Regarding Fantomas here is the configuration I am using now days.
The [demo/**/*.{fs,fsx}] section is specific to project that are using the Feliz syntax style. If you think it can improve the readability feel free to adopt it.
[*.{fs,fsx}]
max_line_length = 100
fsharp_alternative_long_member_definitions = true
fsharp_multi_line_lambda_closing_newline = true
fsharp_multiline_bracket_style = aligned
fsharp_keep_max_number_of_blank_lines = 1
fsharp_align_function_signature_to_indentation = true
fsharp_max_if_then_else_short_width = 0

[demo/**/*.{fs,fsx}]
fsharp_experimental_elmish = true
fsharp_record_multiline_formatter = number_of_items
fsharp_array_or_list_multiline_formatter = number_of_items

Thanks for your trust @MangelMaxime , I also just started to try out SolidJs. So the first step was to get the samples running with the latest version.  I like it so far. yes, I would be happy to be a contributor and publish packages.

Replaced by https://github.com/fable-compiler/Fable.Solid/pull/18


Parameter store names need hyphens : KEY5 must have a hyphen if "/KEY1/KEY5" must be retrieved by ${KEY1.KEY5}

Type: Bug
Component:
"Parameter Store"
Describe the bug
We are facing an issue while fetching the parameters from the AWS parameter store within Spring application properties.
Artifacts:

Spring Boot version : 2.6.3
Spring cloud for AWS parameter store config :
'io.awspring.cloud:spring-cloud-starter-aws-parameter-store-config:2.4.4'

Please help us with information on the below. We tried retrieving the parameters in the Spring Boot app using the AWS SDK library and then it worked for all use cases.               However, we are looking for a way to retrieve the parameters from the AWS parameters store using application properties. Happy to know that Spring cloud supports this! But as we are facing the below issues, kindly provide the information on the reason for this / how we can get this to succeed.
ISSUE 1
Details

Error when the parameter store name hierarchy has no hyphen (KEY5) in the last level and we are trying ${KEY1.KEY5}. If we have 2 parameters /sample-application/KEY1/KEY5 and /sample-application/KEY2/KEY5, then we can only import /sample-application and then retrieve ${KEY1.KEY5} and ${KEY2.KEY5}. But if KEY5 is not having atleast 1 hyphen ("-"), then it fails:

Spring application.properties:
spring:
  config:
    import: aws-parameterstore:/sample-application

Parameters stored in AWS :
aws ssm put-parameter --name "/sample-application/KEY1/KEY5" --value "Value5" --type String

Printing parameters:
@Configuration
public class Demo{
	@Value("${KEY1.KEY5}")
	private String key5Value;

	@PostConstruct
	private void postConstruct() {
	    System.out.println(key5Value);
	}
}

Result :
Could not resolve placeholder value "${KEY1.KEY5}"

Why does this error appear? Please help us with this.

ISSUE 2
Details
There is no error when the parameter store name hierarchy has a hyphen (KEY-5) in the last level and we are trying ${KEY1.KEY-5}
However, in this case, ${KEY1.KEY5} also reads the parameter with name /KEY1/KEY-5.
/KEY1/KEY5 and /KEY1/KEY-5 are 2 different paramaters in AWS.
But Spring Cloud resolves /KEY1/KEY-5 to ${KEY1.KEY5}.
Is this intended to respond this way?
Spring application.properties:
spring:
  config:
    import: aws-parameterstore:/sample-application

Parameters stored in AWS :
aws ssm put-parameter --name "/sample-application/KEY1/KEY-5" --value "Value5" --type String

Printing parameters:
@Configuration
public class Demo{
	@Value("${KEY1.KEY-5}")
	private String key5WithoutHyphen;

        @Value("${KEY1.KEY5}")
	private String key5WithHyphen;

	@PostConstruct
	private void postConstruct() {
	    System.out.println(key5WithoutHyphen);
	    System.out.println(key5WithHyphen);
	}
}

Result :
Value5
Value5
The ISSUE 1 doesn't appear if we use the following workaround. No error when the parameter store name hierarchy has zero or more hyphens (/KEY1/KEY4, /KEY/KEY-5) in the last level and we are trying ${KEY4} OR ${KEY-5}
Spring application.properties:
spring:
  config:
    import: aws-parameterstore:/sample-application/KEY1

Parameters stored in AWS :
aws ssm put-parameter --name "/sample-application/KEY1/KEY4" --value "value4" --type String
aws ssm put-parameter --name "/sample-application/KEY1/KEY-5" --value "value5" --type String

Printing parameters:
@Configuration
public class Demo{
	@Value("${KEY4}")
	private String key4Value;

        @Value("${KEY-5}")
	private String key5Value;

	@PostConstruct
	private void postConstruct() {

	    System.out.println(key4Value);
            System.out.println(key5Value);
	}
}

Result :
Value4
Value5

Hey @AshwiniV-PhilipsAccount , thank you for reporting will check it out in following days.

Hey @AshwiniV-PhilipsAccount , sorry for the delay I didn't buy the schedule.
You are missing a / in first case.
Instead:
spring:
  config:
    import: aws-parameterstore:/sample-application

Try :
spring:
  config:
    import: aws-parameterstore:/sample-application/

I tried with spring.cloud.aws 3.0.1 and it works like a charm.
If you specfy /sample-application

Closing due to lack of feedback


Support for using either fixed-width or fixed-height design.

Hi,
Thanks for the useful plugin!
I added support for scaling by height ratio & also reduced the required SDK as I need to use an older version of Flutter and the lib doesn't seem to require newer features.
Thanks again!
Avi

Hey man,
Thanks for your input, I'll take a loot at it!


add dispatcher helper to package and small cleanups

Add AppCompatDispatcherHelper to the package
Use the new helper instead of calling RunOnUIThread
Credits to myself and Laurent Bugnion
Remove dependency on NuGet.CommandLine as it does not seem to be required

Let me know if you want me to split them up.

That's awesome - thanks for doing this.  I just went down the route of the simplest version to get it working so it's good to have some more expansion on this.

You're welcome :) I just stumbled on a bug caused by using the wrong DispatcherHelper and I thought it'd be easier if it was included in your nuget

Nuget package updated to include this.
https://www.nuget.org/packages/JimBobBennett.MvvmLight.AppCompat/


Protein Scoring on Google Colab

Hi Sean,
I've been using the Protein Metrics on Google Colab for the past few days, but for some reason I keep getting errors when I try to calculate scores using ESA-MSA sampler-generated sequences.
The error occurs after I upload a list of sequences and run the Single-sequence metrics.
I'm not too familiar with how codes work on Google Colab, so I was wondering if you would be able to resolve the above issue.
Thanks!
Nam

What metrics are you trying to calculate? What errors are you seeing?

Single sequence metrics should work. Just upload the fasta file of the generated sequences to the "target_seqs" directory.
For structure metrics, you'd need to generate structures using AlphaFold2 or some other model and then upload those to the metrics Colab. We don't run structure prediction in our notebooks, you'll have to do that with ColabFold, or some other service (or locally on your own hardware).
For alignment based metrics, you need to upload reference sequences to the "reference_seqs" folder.

I just did a quick test run. Downloaded "sequences.zip" from here: https://zenodo.org/records/10594384
extracted CuSOD_round2_train.fasta, copied the first 6 sequences into a new file called templates.fasta, used those two files in the sequence generation notebook, and then used the output in the metrics notebook. I only did the single sequence and alignment based metrics, because I didn't want to make AlphaFold structures, but everything seemed to work.


fixed issue #11051

Scope & Purpose
Fix Github issue #11051

[ ] Bug-Fix for devel-branch (i.e. no need for backports?)
[x] Bug-Fix for a released version (did you remember to port this to all relevant release branches?)
[x] The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)
[x] The behavior change can be verified via automatic tests

Related Information

[x] There is a GitHub Issue reported by a Community User: #11051

Testing & Verification
This PR adds tests that were used to verify all changes:

[x] Added new integration tests (i.e. in shell_server / shell_server_aql)

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/8453/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/8463/

Tests blue


ARROW-9979: [Rust] Fix arrow crate clippy lints

This fixes a lot of clippy errors and warnings. We currently have over 600 such, and they tend to cause a lot of noise while working.
This PR only includes changes to arrow, one change to datafusion and integration testing. I've left parquet out to potentially open a separare PR.
Thoughts @andygrove @alamb @jorgecarleitao @paddyhoran?

Thanks @alamb @jorgecarleitao, I've opened https://issues.apache.org/jira/browse/ARROW-9978 to keep track of all clippy work. I'll wait for @andygrove and @paddyhoran's opinions before going ahead with the merge.
It's unfortunately going to be disruptive to existing open PRs, but at the same time I'd like to merge this sooner so I can bank this work (it's the third time I work on clippy lints)


Cover policy communication spec in detail

Split the existing "writing policies" page into a set of dedicated units.

@ereslibre if you are fine with that we can then open two dedicated issues to cover the creation of contents for the "mutating policies" and "context aware policies" pages.

/cc
I will add information about the context aware policies current "protocol"

I will add information about the context aware policies current "protocol"

Great, I would do that with another dedicated PR.
I think we can merge this PR with the missing contents

I've squashed all the suggestions together and added new contents to clarify the points raised by @ereslibre


Comments are executed in Log Analytics

Describe the bug
When the name of an available function is written in the comments, this function is being executed.
I've noticed this because I had a workspace function with an error in it.
When writing some comments in query mentioning this (broken) function, I got an error when running the code. [image 1]

To Reproduce
Steps to reproduce the behavior:

Go to 'Log Analytics'
'Create a new query'
Add a comment that contains the name of a broken workspace function
Select All code, incl. comments
Run the code

Expected behavior
I would expect that everything that is written in a comments block is not being executed by Log Analytics.
This behavior can cause a major performance impact if the code contains multiple workspace function names.
Screenshots
Running when all code (incl. comment) is selected

Running code with only query selected

Running code with only comments selected

Screenshot of mentioned broken function (line 123 is causing the error)

Performance
When running this against a very small dataset the quickest response when comments are selected in 649ms

When running against the same dataset with no comments selected the quickest response in 477ms

This sounds familiar: https://github.com/Azure/Azure-Sentinel/issues/4215.

While LA does not actually replaces function name in strings with the content of the function, it verifies it.
This is a known and hard to fix LA bug. It also happens in comments by the way. We fixed this specific one by fixing the underlying function, so the latest from the repo should indeed help. More generally, we are replacing the function names in strings which we use today with a different string to bump into the issue less.

Closing this issue since we are investigating internally.


⚠ Fetchers has degraded performance

In 53e2fc4, Fetchers ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 325 ms

Resolved: Fetchers performance has improved in caa7b44.


Support Linux-to-Windows cross compile via MinGW

Supports Shaderc https://github.com/google/shaderc/pull/169

Looking for feedback and testing from @AWoloszyn

Rebased and squashed.   Removed the DO-NOT-REMOVE flag. PTAL.

LGTM +2


Expose labelText of searchBar

could you insert a parameter to set the search string 'Search by Country Name'? Tnx

any feedback?

I was quite occupied these days, will update it asap or i will happy to accept a pr.

Fixed. Closing now.


dep: directly use siphash lib in the source

This PR replaces the siphash library dependency to directly use the one saved into the codebase. The reason for this is to allow support on the browser (the npm version doesn't work on the browser :()
See library repo for details.
Brief summary of the change made

Are there any other side effects of this change that we should be aware of?
Describe how you tested your changes?

Pull Request checklist
Please confirm you have completed any of the necessary steps below.

[ ] Meaningful Pull Request title and description
[ ] Changes tested as described above
[ ] Added appropriate documentation for the change.
[ ] Created GitHub issues for any relevant followup/future enhancements if appropriate.

I understand what is happening here, and agree to it. However, I would like to request a few changes in the process to make this more easy to understand.
Could we first add the siphash library to our repo without modifying it? Also, let's try to use a non-minified version.
Then in a second PR, let's start changing the siphash library such that we can use it in the browser.

Very well, I shall see to it.

I understand what is happening here, and agree to it. However, I would like to request a few changes in the process to make this more easy to understand.
Could we first add the siphash library to our repo without modifying it? Also, let's try to use a non-minified version.
Then in a second PR, let's start changing the siphash library such that we can use it in the browser.

Very well, I shall see to it.

Updated and ready for review.  I will create a subsequent PR after this is merged.


Weird UI Click behavior

Description
The onClickEvent in UIElement's is only called in the first drawn UI. This means the click event isn't fired for the top layer of the UI, but instead the bottom layer first.
Steps to Reproduce
Example code in a subclass of UIState in OnInitialize()
base.add(basePanel);
base.add(someText);
base.add(myCustomItemSlot);
I've also tried the following
basePanel.add(someText);
basePanel.add(myCustomItemSlot);
base.add(basePanel);
Expected behavior
Click events should be passed on to all children of a parent if the child falls within the clicked region (i.e. multiple UI Elements are overlapping, they should all receive the click event). Or the UI element that is drawn last (the one that's on top) should receive the click event.
Actual behavior
The first drawn GUI element is given the click event, and UIPanel does not pass the click event onto its children. This means that if you have a CustomItemSlot being drawn ontop of a UIPanel, the click event is fired for the UIPanel, but not the CustomItemSlot.
Reproduction frequency
100% of the time
Versions
tModLoader v<IP_ADDRESS>
Mods
Just the mod where the bug occurs

Overlapping UIElements are not supported by the UI system (within the same level of nesting). Nested elements, however, are.
In your example you should find that this works:
myCustomItemSlot.add(someText);
basePanel.add(myCustomItemSlot);
base.add(basePanel);
If this doesn't work, this question is probably better suited for the discord chat so we can go back and forth quickly: discord.me/tModLoader

Thanks, there was a bug in my code.


Allow nix 0.23.

This crate compiles fine with nix 0.23 too. This change allows both nix 0.22 and 0.23 as dependency.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nastevens (or someone else) soon.
Please see the contribution instructions for more information.


Evolution search results

Hi. Sorry to bother again.
I tried to run your evolution search code, with checkpoints-150000 provided. The results look like this:

which is nowhere near the results shown in paper (over 68 in general).

Trying to dig out why, I found that recalculating BN on 20k images brings little improvement (less than one percent) to validation performance, compared to inheriting BN directly from the supernet. I'm not sure whether there is something wrong here. Have you guys observed a similar phenomenon?
Or, my wild guess is, the supernet you have shared is not a well-trained supernet?

我感觉不用BN重新标定，搜索的子网的精度反而会更好，也许作者为了筛选出更好的，所以需要BN标定？


[Game Crash] This Should Be 2 Player Pop'n Music Here.

Describe how it crashed by giving us those informations:
When i tried to play battle mode, the game crashed.
crashinfo.txt
Explain how we can reproduce the error

Start the game
Play WIth Style "popn"
Join 2 Players
As Music Select Appears, Game crashed

Additional information
https://www.youtube.com/watch?v=97NatSWUMj8

Thanks for reporting this one, I can confirm it was a debug check left behind that wasn't caught before release. We've fixed this and made the 2p pop'n mode a lot more stable on the next alpha. (it also supports all po-mu modes, 3/4/5/7/9)
Proper battle mode will come in the future, but you can now at least play 2 players.
Again, thanks for taking the time to report this and letting us know.


Post Studio :: Gallery

PTI 011
Gallery view of photos

https://invis.io/EW528OEXP

https://github.com/zhangao0086/DKImagePickerController

See attached for decisions per discussion today.
Sharing photos discussed in #13
@Misokate @sshaar08 @kperusko let me know of any misalignment
@brooklynchuck per discussion on Invisionapp will need tweaked copy for this screen per the updated flow

Question: the top copy that says "Design Studio Name" is just a placeholder, right?
Here's the "encouraging" copy:
"Photograph your groups’ results now to automatically save them with this studio template. Share the brilliance. Take a bow."
I believe the album name that all photos will be saved to should be something like:
"[Template Name] DSX photos"
C:

@brooklynchuck thanks! The one snag is the photo album can't dynamically pull in the template name. Would just "DSX photos" be ok as a general album name?

Can we put the date in the album name? That would be helpful, as many times on a phone, you don't see the date something was created without getting deeper into it.
But otherwise, yes, "DSX Photos ##/##/####" or just "DSX Photos".
C:

@brooklynchuck we can only have one album for all dsx photos (similarly to how Instagram just pools all photos in one). So thinking we'll need to go with "DSX Photos"
cc: @kperusko @Misokate


Restore to other hardware could handle VLAN mappings better

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[X] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[X] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Is your feature request related to a problem? Please describe.
When restoring the OPNsense configuration on another hardware platform then where the config backup is created, OPNsense detects and warns that logical interfaces cannot be automaticly mapped to physical interfaces and drops you in the screen to fix that. But when VLAN's are also used, you cannot change the assignments of the physical interface the VLAN maps to. But given the invalid physical ports, you also cannot save any changes.
Describe the solution you like

the config restore fuction should drop me in the VLAN mapping screen when VLANS are detected in use OR
the interface assignment screen should allow me to alter the physical mapping of interfaces too from the logical -> physical ports mapping screen.

Describe alternatives you considered
A clear and concise description of any alternative solutions or features you considered.
Additional context
This issue was detected when migrating a config with VLAN mappings from a pcengines apu device to a DEC740 device.

I'm afraid that's not really fixable, same is more or less the case for other virtual types (laggs, bridges, ..). In theory you should be able to first change the vlans, then apply and go back to the assignments, but if you're connected to the machine using the same interface, it will be a bit fragile.
complex setups are often easier to migrate manually (edit the config.xml and upload with proper interface mappings).


FATAL EXCEPTION: EglRenderer

Describe the bug
My application is one-to-one, but different from the traditional one, the users' video alternates, that is, the first user speaks for 30 seconds and only his video and audio is displayed, then the second user speaks for 30 seconds and only its audio and video is displayed.
The approach I took was to not display the VideoView, I also tried to set the width and height to 0, it works once, but then it has some errors and then it crashes.
One message that appears is visibility resize observer not triggered. Am I using the proper approach? Or should I remove the track from the user and then subscribe to it again?
To Reproduce
Try switching between videos, not playing them and then playing them normally.
Remembering that the video is 100% width and height.
Expected behavior
The videos should alternate smoothly considering what is said in the documentation, that when the video does not appear it is "paused".
Screenshots
FATAL EXCEPTION: EglRenderer
android.opengl.GLException: Failed to create window surface: 0x3000
FATAL EXCEPTION: EglRenderer
Process: br.com.simplevideo, PID: 32500
android.opengl.GLException: Failed to create window surface: 0x3000
at org.webrtc.EglBase14Impl.createSurfaceInternal(EglBase14Impl.java:107)
at org.webrtc.EglBase14Impl.createSurface(EglBase14Impl.java:85)
at org.webrtc.EglRenderer$EglSurfaceCreation.run(EglRenderer.java:76)
at android.os.Handler.handleCallback(Handler.java:790)
at android.os.Handler.dispatchMessage(Handler.java:99)
at org.webrtc.EglRenderer$HandlerWithExceptionCallback.dispatchMessage(EglRenderer.java:103)
at android.os.Looper.loop(Looper.java:164)
at android.os.HandlerThread.run(HandlerThread.java:65)
Device Info (please complete the following information):

Device: Android Emulator
OS: Android 8.1.0
livekit-client: 1.4.1
livekit-react-native: https://github.com/livekit/client-sdk-react-native

Using RTCView directly, this problem does not occur, so I believe that the problem is associated with the visibility detection that occurs in VideoView.

Sorry, could you provide a code snippet of the situation that errors? Seems like you mentioned a couple different attempts.

Does just having one VideoView and changing the track that's played through work?

Closing as stale.


deprecate ExternalLocationReference in favor of DownloadReference

Bug/issue #, if applicable: rdar://111121386
Summary
This PR refactors DownloadReference and ExternalLocationReference to deprecate the latter by incorporating it into the former. Now that there is a property on DownloadReference to prevent rewriting the URL upon encoding, this refactor takes advantage of that to incorporate the original uses of ExternalLocationReference back into DownloadReference.
Dependencies
None
Testing
This is primarily an internal refactor, but there are two major changes in the output: external-assets.json will no longer be generated (its previous contents will now be folded into the downloads property of assets.json, and references that would have used the externalLocation reference type (i.e. @CallToAction(url:_:)) now instead use the download reference type.
Steps:

DOCC_JSON_PRETTYPRINT=YES swift run docc convert --emit-digest 'Tests/SwiftDocCTests/Test Bundles/SampleBundle.docc'
Inspect the resulting built archive:
a. The external-assets.json file should not exist.
b. The assets.json file should contain a download reference with a url of "https://www.example.com/source-repository.git".
c. The rendered JSON for MyExternalSample should contain a reference to "https://www.example.com/source-repository.git" with a reference type of download.

Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

[ n/a ] Added tests
[x] Ran the ./bin/test script and it succeeded
[ n/a ] Updated documentation if necessary

@swift-ci Please test

@swift-ci Please test

@swift-ci please test

@swift-ci Please test


BUGFIX for JGRP-1429 : The timeout of VERIFY_SUSPECT protocol is not guaranteed

Hi Bela,
Here is a pull request for JGRP-1429
Thanks
Karim

The second commit concerns JIRA 1425 (not 1245)
https://issues.jboss.org/browse/JGRP-1425
Thanks

Regarding the VERIFY_SUSPECT change: I use a DelayQueue now to pass SUSPECT events up. I also added a unit test VERIFY_SUSPECT_Test


timeout after login before file select in pupeteer

hi,
This is a great way to automate the uploading of audio files.
It was working fine for couple of days, now it is failing to upload episode into anchor.
Launching puppeteer
Logged in
TimeoutError: waiting for selector input[type=file] failed: timeout 30000ms exceeded
at new WaitTask (/github/workspace/node_modules/puppeteer/lib/cjs/puppeteer/common/DOMWorld.js:505:34)
at DOMWorld.waitForSelectorInPage (/github/workspace/node_modules/puppeteer/lib/cjs/puppeteer/common/DOMWorld.js:416:26)
at Object.internalHandler.waitFor (/github/workspace/node_modules/puppeteer/lib/cjs/puppeteer/common/QueryHandler.js:31:77)
at DOMWorld.waitForSelector (/github/workspace/node_modules/puppeteer/lib/cjs/puppeteer/common/DOMWorld.js:312:29)
at Frame.waitForSelector (/github/workspace/node_modules/puppeteer/lib/cjs/puppeteer/common/FrameManager.js:842:51)
at Page.waitForSelector (/github/workspace/node_modules/puppeteer/lib/cjs/puppeteer/common/Page.js:1285:33)
at /github/workspace/index.js:71:32
at processTicksAndRejections (internal/process/task_queues.js:97:5)
Error: The operation was canceled.

@arumugam6 Can you check if this still happen when using the latest version ?

@arumugam6 We will close this issue after 30 days with no activity

That happened to me and it's probably caused by a secret configured on the wrong place in github. Check this link on how to properly configure secrets for actions: https://stackoverflow.com/questions/67964110/how-to-access-secrets-when-using-flutter-web-with-github-actions/67998780#67998780

I close for inactivity, thanks @weltonrodrigo


fix: dont assume primary key is id

Eloquent will also assume that each table has a primary key column named id. You may define a protected $primaryKey property to override this convention:

I have lots of models with custom ids

Thank you for the PR!
I don't quite understand why is this necessary. Don't you also put the primary key with the custom name in the migrations? Doesn't that work?

@canvural That's assuming that laravel migrations are present.
I have an enterprise application with thousands of database tables, and we manage migrations with https://github.com/skeema/skeema
Laravel migration files shouldn't be a dependency for knowing the  primary key of the model.

@canvural also I believe if a migration defined a custom id field , then id would always be allowed as a property and would not be caught as an error.


Add ETGF space

Add space for ETGF
Etherscan: https://etherscan.io/token/0x74603e780545d02C4257E7D2BE19c74dE7BE1952
CoinGecko: Application Pending (https://www.coingecko.com/en/coins/etg-finance)
Website: https://etgproject.org
Twitter: https://twitter.com/ethereumgoldetg

Name updated
On Sat, Oct 24, 2020, 04:05 Gokai<EMAIL_ADDRESS>wrote:

@gokaiorg requested changes on this pull request.
You should rename your space directory, uppercase are not allowed.
spaces/ETG.Finance/... to spaces/etgfinance/...
In spaces/ETG.Finance/index.json
https://github.com/snapshot-labs/snapshot-spaces/pull/342#discussion_r511278674
:

"filters": {

"defaultTab": "all",

"minScore": 0.01,

"onlyMembers": true

},

"invalids": [

"0x6a36222e45265640B636e6BD2b558d1fB81458E6"

]

The invalids field should be move in filters.
⬇ Suggested change

"filters": {

"defaultTab": "all",

"minScore": 0.01,

"onlyMembers": true

},

"invalids": [

"0x6a36222e45265640B636e6BD2b558d1fB81458E6"

]

"filters": {

"defaultTab": "all",

"minScore": 0.01,

"onlyMembers": true,

"invalids": [

 "0x6a36222e45265640B636e6BD2b558d1fB81458E6"

]

}

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/snapshot-labs/snapshot-spaces/pull/342#pullrequestreview-516153655,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG3JOXQMGVC37RCJE4OTE4LSMI77JANCNFSM4S5INNVQ
.


Add loadBalancerSourceRanges to schema

what
Add loadBalancerSourceRanges to schema
why
The loadBalancerSourceRanges is an existing param in the chart, but passing it to the chart after the schema was added results in - service: Additional property loadBalancerSourceRanges is not allowed error.
tests
Applied with passing the value and without passing the value.

@sviatlo Thanks! i missed it can you please also add it to the values so it will be noticed?

@sviatlo can bump the char version to 4.17.2? thanks.

@roytev should I set it to null or empty array is good enough?

Hi @sviatlo Thanks it looks good!

@roytev @jamengual apologies for bugging you, but could someone please approve a CI run?

@sviatlo Thanks for the contribution!


API (OpenGL) is active but cannot capture frame

Description

After running my application, I found that the Capture Frame button is not working as expected.
Pressing it does not capture any frames.
And there is no message (OpenGL. F12, PrtScrn to capture. Frame: .....) on the top-left corner of my application
The photo below is another application with Renderdoc that works as expected.

Steps to reproduce

I cannot share my application since it is my school project right now.
as the below image shows, the API is active however it cannot capture frame.

here is the log from Renderdoc
renderdoc_failed_to_capture.log
PS: sorry for the poor English
Environment

RenderDoc version: 1.18
Operating System: windows10
Graphics API: OpenGL
GPU: AMD Radeon RX 5600 XT

Without a way to reproduce this there's no way I can investigate what is happening. Are you able to find a demo program which reproduces this problem for you? or either cut down your program sufficiently that you can share it, or find a way to modify a demo program to be close enough to your program to exhibit the problem?
To clarify if you're concerned about sharing the source code for your school project, a binary-only repro case is fine.

Hello, thank you for replying! I have sent a basic version of my project which can reproduce the problem through email.

Thanks for sharing it. The problem is that you use wglMakeContextCurrentARB which it seems I'd never encountered an OpenGL program using before, possibly because it's rare to need separate read and draw DCs.

Thank you for your time. It works now!


Handle dynamic swap fees

Designs:
https://www.figma.com/design/stjMSRgYKmzmau9InfKbCh/V3-new-styles?node-id=7714-455&t=voSnyNAben1LuqkR-1
Swap fees should be positioned last (after any hooks).
Dynamic fees SVG is attached!
Image


[Bug]: Unable to connect to elastic search using default docker compose file since feat: Support Password Access for  ElasticSearch (#1072)

Is there an existing issue for the same bug?

[X] I have checked the existing issues.

Branch name
main
Commit ID
195498daaabaa4e5b1356d96ea66307ee7af89fb
Other environment information
OS: Ubuntu 18.04
That's ancient and I know, I dont want to use this version too. But I dont thing that's relevant.

Actual behavior
...
ragflow-server  |   File "/ragflow/rag/svr/task_executor.py", line 28, in <module>
ragflow-server  |     from api.db.services.file2document_service import File2DocumentService
ragflow-server  |   File "/ragflow/api/db/services/__init__.py", line 18, in <module>
ragflow-server  |     from .user_service import UserService
ragflow-server  |   File "/ragflow/api/db/services/user_service.py", line 22, in <module>
ragflow-server  |     from api.db.db_models import DB, UserTenant
ragflow-server  |   File "/ragflow/api/db/db_models.py", line 32, in <module>
ragflow-server  |     from api.settings import DATABASE, stat_logger, SECRET_KEY
ragflow-server  |   File "/ragflow/api/settings.py", line 35, in <module>
ragflow-server  |     from rag.utils.es_conn import ELASTICSEARCH
ragflow-server  |   File "/ragflow/rag/utils/es_conn.py", line 460, in <module>
ragflow-server  |     ELASTICSEARCH = ESConnection()
ragflow-server  |   File "/ragflow/rag/utils/__init__.py", line 12, in _singleton
ragflow-server  |     instances[key] = cls(*args, **kw)
ragflow-server  |   File "/ragflow/rag/utils/es_conn.py", line 24, in __init__
ragflow-server  |     raise Exception("Can't connect to ES cluster")
ragflow-server  | Exception: Can't connect to ES cluster
ragflow-server  | Traceback (most recent call last):
ragflow-server  |   File "/ragflow/rag/svr/task_executor.py", line 28, in <module>
ragflow-server  |     from api.db.services.file2document_service import File2DocumentService
ragflow-server  |   File "/ragflow/api/db/services/__init__.py", line 18, in <module>
ragflow-server  |     from .user_service import UserService
ragflow-server  |   File "/ragflow/api/db/services/user_service.py", line 22, in <module>
ragflow-server  |     from api.db.db_models import DB, UserTenant
ragflow-server  |   File "/ragflow/api/db/db_models.py", line 32, in <module>
ragflow-server  |     from api.settings import DATABASE, stat_logger, SECRET_KEY
ragflow-server  |   File "/ragflow/api/settings.py", line 35, in <module>
ragflow-server  | Traceback (most recent call last):
ragflow-server  |   File "/ragflow/api/ragflow_server.py", line 26, in <module>
ragflow-server  |     from rag.utils.es_conn import ELASTICSEARCH
ragflow-server  |   File "/ragflow/rag/utils/es_conn.py", line 460, in <module>
ragflow-server  |     from api.apps import app
ragflow-server  |   File "/ragflow/api/apps/__init__.py", line 26, in <module>
ragflow-server  |     ELASTICSEARCH = ESConnection()
ragflow-server  |   File "/ragflow/rag/utils/__init__.py", line 12, in _singleton
ragflow-server  |     from api.db.db_models import close_connection
ragflow-server  |     instances[key] = cls(*args, **kw)
ragflow-server  |   File "/ragflow/rag/utils/es_conn.py", line 24, in __init__
ragflow-server  |   File "/ragflow/api/db/db_models.py", line 32, in <module>
ragflow-server  |     raise Exception("Can't connect to ES cluster")
ragflow-server  | Exception: Can't connect to ES cluster
ragflow-server  |     from api.settings import DATABASE, stat_logger, SECRET_KEY
ragflow-server  |   File "/ragflow/api/settings.py", line 35, in <module>
ragflow-server  |     from rag.utils.es_conn import ELASTICSEARCH
ragflow-server  |   File "/ragflow/rag/utils/es_conn.py", line 460, in <module>
ragflow-server  |     ELASTICSEARCH = ESConnection()
ragflow-server  |   File "/ragflow/rag/utils/__init__.py", line 12, in _singleton
ragflow-server  |     instances[key] = cls(*args, **kw)
ragflow-server  |   File "/ragflow/rag/utils/es_conn.py", line 24, in __init__
ragflow-server  |     raise Exception("Can't connect to ES cluster")
ragflow-server  | Exception: Can't connect to ES cluster
...

Expected behavior
ragflow-server boot without spitting errors
Steps to reproduce
- check out the commit mentioned previously
- remove all docker volume created by ragflow
- `docker-compose down` and `docker-compose rm` if nessary
- `cd docker`
- use `docker-compose up`

Additional information
ehh probably some misconfigured login setting idk

sorry just found this https://github.com/infiniflow/ragflow/issues/1135 I will close this one.

sorry just found this #1135 I will close this one.
#1135  still on going, should not mark it completed , please.


Lodash chain uses any

The lodash _() and _.chain() methods are currently typed as any. It's pretty long-winded, but I can't see any reason why these can't be properly typed?

It's pretty long-winded

That's probably your reason 😅


Issue Template outdated | Aniyomi <IP_ADDRESS>

Describe why this should be added
Your Github-Template for Bugs is still asking to update to the "latest" stable version 0.12.x.x, when it should be <IP_ADDRESS>
Other details
https://github.com/aniyomiorg/aniyomi/releases
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open (or closed) issue.
[X] I have written a short but informative title.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[ ] I have updated the app to version <IP_ADDRESS>.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

I guess the same applies to the 'Meta'-Template

forgot to close in #2933 lol


Fix PresenceChannel->here method format

Current format
[
    {
        "clientId": "1",
        "action": 1,
        "data": {
            "id": 1,
            "name": "John Doe"
        },
        "encoding": null
    }
]

Supposed to be
[
    {
            "id": 1,
            "name": "John Doe"
    }
]

Related to https://github.com/ably/laravel-broadcaster/issues/13

This is mainly to avoid possible bugs who are migrating from pusher/pusher-compatible broadcasters


Open source the JIRA connector

Presuming that at some point we'll be announcing the JIRA connector and open sourcing the work.

Done. Yay!


Animated SplashScreen

I can add animated splashscreen to this application
Assign me this issue with the tag of gssoc-ext

@Vishwajith-Shettigar can you assign this to me, i want to work on it?

@Gopal0Gupta, this has been completed.


Expose "pouchdb-adapters" list for debugging

With this change, the JSON returned for GET / returns e.g.:
{
  /* ... */
  "pouchdb-adapters": ["leveldb"]
}

or:
{
  /* ... */
  "pouchdb-adapters": ["node-websql"]
}

or:
{
  /* ... */
  "pouchdb-adapters": ["memory"]
}

I believe this aids in debuggability, e.g. when you do pouchdb-server --in-memory and want to remember that it's in-memory.
The test fails before the fix but succeeds after.

This is cool. I think in the next release of CouchDB we will ahve a features tag: "features":["geo", "scheduler"]. We could consider putting this in there as well.


Asus ROG Strix GL702VSK - built-in keyboard not working during LUKS decryption

OS: NixOS 23.05.3242.da5adce0ffaf (Stoat) x86_64
Host: ASUSTeK COMPUTER INC. GL702VSK
Kernel: 6.1.47
I used the Calamares installer from the live CD to set up nix on a flash drive with standard partitioning and encryption enabled. Upon booting, it reaches the LUKS decryption step and prompts for a password, but the laptop's built-in keyboard isn't able to type into it. I connected an external keyboard, and everything seems to be working fine beyond that point.
I tried including asus/rog-strix/g733qs, just in case the different laptop model had similar issues, but it didn't and just caused more issues with the installation, so I'm back to square one.
I'm happy to provide any additional information that would help debug or fix this. I may be able to assist with testing, but I'm not thoroughly familiar with NixOS yet.

Probably this response reaches you too late, but you can run lsmod on a booted installer (with working keyboard). Then add boot.debug1devices to the kernel parameters of your installed system (in grub/systemd you can press a key to edit boot entries for one boot only). boot.debug1devices will allow drop you in a rescue shell in which you can also type lsmod and compare if there are drivers missing from the first prompt. This usually helps you to get devices working in initrd.

Also check dmesg in case there is missing firmware. But I have never seen this so far keyboards.

Hope this helps.


Embedding a c6 chimera graph results in empty embedding being returned

Description
Usually if the embedding doesn't fit on the QPU, an error is returned.
To Reproduce
Running the following code returns an empty embedding with no error:
import dwave_networkx as dnx
import minorminer as mm

graph = dnx.chimera_graph(m=6, n=6, t=4)
chimera_graph = dnx.chimera_graph(16)
graph_edges = graph.edges()

emb = mm.find_embedding(graph_edges, list(chimera_graph.edges()))

Expected behavior
I am not exactly sure how this should behave, but presumably the input ends up being too large to be embedded on the provided adjacency.
I was able to get an embedding back quick which I used m=6 and n=5 as in the following:
import dwave_networkx as dnx
import minorminer as mm

graph = dnx.chimera_graph(m=6, n=5, t=4)
chimera_graph = dnx.chimera_graph(16)
graph_edges = graph.edges()

emb = mm.find_embedding(graph_edges, list(chimera_graph.edges()))

Environment:

OS: Windows 10 Pro
Python version: 3.7.1

Additional context
This came up as a problem a community user was facing.

This is the documented signature of minorminer.find_embedding; not a bug.  Moreover, minorminer isn't the right tool for this particular task; you're looking for a coordinate transformation.
It's easier to work with Chimera graphs of different sizes by using coordinate-based node labels
import dwave_networkx as dnx

graph = dnx.chimera_graph(m=6, n=5, t=4, coordinates=True)
coords = dnx.chimera.chimera_coordinates(16)
emb = {v: [coords.int(v)] for v in graph.nodes()}

otherwise,
graph = dnx.chimera_graph(m=6, n=5, t=4)
coords_in = dnx.chimera.chimera_coordinates(m=6, n=5, t=4)
coords_out = dnx.chimera.chimera_coordinates(16)
emb = {v: [coords_out.int(coords_in.tuple(v))] for v in graph.nodes()}

My mistake; this is in fact a documentation bug; that behavior is not clearly documented.


Data sources acronyms

The references to other systems should be spelt out with the acronym in brackets – Stock Information Database (SID); The first one is called “ICES Spatial Facility” and has no acronym.
@neil-ices-dk Should SID, SAG and Advice View also be prefixed with ICES?

@lucalamoni i don't think so, the spatial facility is the only one i know that is specifically prefixed with 'ICES'


Sessionkey is not returned from subadapter

❗ please do not add sensitive information in issues, you can provide extra information via email using issue number as reference ❗
Describe the issue
Sessionkey is not returned from subadapter. IbislocalSender calls adapter with javalistener with returnedSessionKeys="multipart1". In subadapter multipart sessionkey is set with stream. When back in main adapter multipart sessionkey is null.
Reporter
Vinh

To Reproduce
Configure adapter with subadapter where sessionkey is set with stream. See in log that sessionkey is null
Screenshots

Configuration
Input
Pipeline PortalGetDocument_GET_lege_multipart1_sessionkey.zip
Environment
FF! 7.7.1: Ibis4Archive
Running on LPZWNL000033000 using Apache Tomcat/8.5.40
Java Version: Java(TM) SE Runtime Environment (1.8.0_172-b11)
Heap size: 435M, total JVM memory: 1476M
Free disk space: 16GB, total disk space: 236GB
Up since: 2022-05-23 10:05:13 (4h)
Additional Environment
Additional Context

Is the returnedSessionKeys attribute also set on the receiver of the subadapter? That should also write some lines to the log, but those are not in your logging.

yes this has always worked. I am working on a upgrade from FF  7.6-20200416.110009 to FF 7.7.1

yes this has always worked. I am working on a upgrade from FF  7.6-20200416.110009 to FF 7.7.1

Discussed with Ricardo, returnedSessionkeys attributed is moved to receiver not to be configured on listener. Issue can be closed


merged feature branch for netreq crate

…dded monoio feature flags, updated readme

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Priyanshu Singh seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


feat(region) :bucket list uploads

这个 PR 实现什么功能/修复什么问题:
feat(region) :bucket list uploads

是否需要 backport 到之前的 release 分支:
NONE

/area region
/cc @swordqiu  @zexi

/lgtm

Codecov Report

Merging #9319 (ef9d2df) into master (b225575) will increase coverage by 1.50%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #9319      +/-   ##
=========================================
+ Coverage    5.82%   7.32%   +1.50%
=========================================
  Files         839     255     -584
  Lines      130674   34047   -96627
=========================================
- Hits         7609    2495    -5114
+ Misses     122381   31308   -91073
+ Partials      684     244     -440

Flag
Coverage Δ

aFlag
7.32% <ø> (+1.50%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/cloudprovider/objectstore.go
2.06% <ø> (ø)

pkg/mcclient/options/k8s/fed_clusterrole.go

pkg/compute/models/hostwires.go

pkg/compute/models/loadbalancerlisteners.go

pkg/compute/models/usage.go

pkg/cloudcommon/db/quotas/context.go

...g/compute/models/loadbalancercachedcertificates.go

pkg/keystone/models/implied_role.go

pkg/compute/models/loadbalancerqcloudcachedlbb.go

pkg/baremetal/tasks/cdrom.go

... and 574 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b225575...ef9d2df. Read the comment docs.

/lgtm
/approve


Possibility React Native Mac Remote Assistant App?

Just like how Xamarin did it, we could actually relay all the work to a Mac Pro or MacBook, while I'm still handling and using the IDE of my choice on my Windows workstation.
In Xamarin Mac Assistant, all files and commands are remotely executed on the target Mac machine, most of the compilations was done on the Mac side, neat and simple, the only thing annoys me is that the simulator is running in the remote PC, which is a MacBook Pro I have.
So I guess RN can provide a similar functionality like that as well? When I type react-native run-ios it just tells me xcrun is not fond.

It's an interesting idea. It's not on the roadmap, but if someone wants to take a stab at it they can send a PR.


map link

The map link needs to open 'the map' with all the locations (see www.healthsites.io) . Currently it links to the Country data (which also has a map)

Fixed this. Please check in the staging @markherringer


Update podAntiAffinity settings

It is better to have the setting requiredDuringSchedulingIgnoredDuringExecution for the podAntiAffinity to ensure distribution of the Ambassador pods across different nodes, when also the externalTrafficPolicy is set to local.
If not intended to force pod distribution across nodes, then just close the PR and keep the configuration settings as they are.

By default, we set to 3 replicas. So if you're using a 1 node or 2 node setup (which is very common during evaluation), will the requiredDuringSchedulingIgnoredDuringExecution annotation work?

Nope. It only works with at least 3 nodes. Otherwise you would have 1 or 2 pods in pending mode until you spin up a new node.
As I said:

If not intended to force pod distribution across nodes, then just close the PR and keep the configuration settings as they are.

So, you can close the PR cause I unterstand that the majority would run into issues when trying out Ambassador with the proposed config change above.

OK, thanks for the suggestion!


[CH] Respect spark config: spark.sql.caseSensitive

It is false by default. Current implementations are all based on this condition. However, when user requires case sensitive column matching(which rarely happens), it will not work.

We won't support it in the near future because users rarely set spark.sql.caseSensitive to true


Switching out of Terasology makes mouse unusable on Linux

Switching out (alt+tab) out of Terasology on Linux is still bugged. I can't use mouse after that (it doesn't seem to generate any system events, like click, etc), so in order to continue using computer I have to run terminal using keyboard only and pkill java.

using a new version of lwjgl 3 so not sure if this is still applicable.


feature: add new version of Saga designer

What is the purpose of the change
Add Saga designer to the site. Fixes #781
Brief changelog
Move built designer artifacts to static directory, and insert a hyperlink in the "user/mode/saga" doc.
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue filed for the change(usually before you start working on it).  Trivial changes such as typos do not necessitate a GITHUB issue. Your pull request should solely focus on addressing this specific issue without incorporating any other modifications. Each PR should resolve a single issue.
[x] Format the pull request title like doc: add an operations guide document. Each commit within the pull request should contain a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Test your code locally by running npm run build, and make sure it works as expected.
[x] Ensure that no files under the build folder are included in the commit, as well as the package-lock.json and yarn.lock files.

zh-cn
en

@slievrly Accidentally added an unused file, leads to ci failed. Fix it in 26c0399

@slievrly Accidentally added an unused file, leads to ci failed. Fix it in 26c0399

ok.


Read file the Java 8 way

Closes no issues
Reading file the Java 8 way

Build failure was unrelated in this case. Thanks very much!


Flagged as a Virus?

My anti-virus and virus total are flagging Apaca Electron
https://www.virustotal.com/gui/file/2d1baa698e96e9257437ca8a72982720620d4c69d55d9ae807fc8628510405a7/details

Not sure what Trojan.Bulz is. There's no exact description of what Trojan.Bulz actually does. However, I think it could've been flagged because it creates a terminal shell (viruses do that a lot) and runs an executable that uses high amounts of resources.
If you want, you can go through the source code to make sure there are no malicious code. And then build the app yourself.

Update: I found out that it was because of the Squirrel.Windows installer (strange because it doesnt happen on Discord and GH Desktop). I will probably not switch to another installer because Squirrel.Windows has the easiest installation process right now and doesn't require admin permissions.

Thanks for the info! I was just curious as to why it was flagged, better to be safe than sorry. Love the program btw, it makes using alpaca so much more user friendly!


Failing system components are not reported in ManagedResource and Shoot conditions

How to categorize this issue?

/area dev-productivity
/kind bug
What happened:
We saw failing kube-proxy Pods in a Shoot's kube-system namespace. Their statuses were as follows:
status:
  conditions:
  - lastProbeTime: null
    lastTransitionTime: "2022-01-27T22:27:39Z"
    status: "True"
    type: Initialized
  - lastProbeTime: null
    lastTransitionTime: "2022-01-31T14:44:56Z"
    message: 'containers with unready status: [kube-proxy]'
    reason: ContainersNotReady
    status: "False"
    type: Ready
  - lastProbeTime: null
    lastTransitionTime: "2022-01-31T14:44:56Z"
    message: 'containers with unready status: [kube-proxy]'
    reason: ContainersNotReady
    status: "False"
    type: ContainersReady
  - lastProbeTime: null
    lastTransitionTime: "2022-01-27T22:27:27Z"
    status: "True"
    type: PodScheduled
  containerStatuses:
  - containerID: containerd://0837dd14c071a6b57cb12ceb9c61a9fbb29e3c43e584103f6caaf2830e604879
    image: k8s.gcr.io/kube-proxy:v1.21.7
    lastState:
      terminated:
        containerID: containerd://0837dd14c071a6b57cb12ceb9c61a9fbb29e3c43e584103f6caaf2830e604879
        exitCode: 1
        finishedAt: "2022-01-31T15:00:15Z"
        reason: Error
        startedAt: "2022-01-31T15:00:15Z"
    name: kube-proxy
    ready: false
    restartCount: 1046
    started: false
    state:
      waiting:
        message: back-off 5m0s restarting failed container=kube-proxy pod=kube-proxy-operator-v1.21.7-7djlq_kube-system(95d839a3-85f6-4c7f-a7f4-e8b719a1e88e)
        reason: CrashLoopBackOff
[...]

The DaemonSets statuses were as follows:
status:
  currentNumberScheduled: 4
  desiredNumberScheduled: 4
  numberAvailable: 3
  numberMisscheduled: 0
  numberReady: 3
  numberUnavailable: 1
  observedGeneration: 1
  updatedNumberScheduled: 4

However, the shoot-core ManagedResource in the shoot's namespace in the seed was not reporting any issues:
status:
  conditions:
  - lastTransitionTime: "2022-01-27T22:33:17Z"
    lastUpdateTime: "2022-01-27T22:33:17Z"
    message: All resources are healthy.
    reason: ResourcesHealthy
    status: "True"
    type: ResourcesHealthy
  - lastTransitionTime: "2022-01-27T22:33:17Z"
    lastUpdateTime: "2022-01-27T22:33:17Z"
    message: All resources are applied.
    reason: ApplySucceeded
    status: "True"
    type: ResourcesApplied

Consequently, the Shoot's SystemComponentsHealthy condition had status True.
What you expected to happen:
The ResourcesHealthy condition part of the ManagedResource should evaluate to False, eventually causing the Shoot's SystemComponentsHealthycondition evaluating toFalse`.
Anything else we need to know?:
It seems that the health.CheckDaemonSet function is not precise enough to cover such situations.
Environment:

Gardener version: v1.38.4
Kubernetes version (use kubectl version): v1.21.7

/cc @shafeeqes

/assign

Shouldn't
https://github.com/gardener/gardener/blob/ca661c0502eb1f885a2ac3793913025788d5102d/pkg/utils/kubernetes/health/daemonset.go#L58
return an error, since daemonSet.Spec.UpdateStrategy.RollingUpdate = nil and therefore maxUnavailable is 0 ?

@shafeeqes I think this is defaulted to
  updateStrategy:
    rollingUpdate:
      maxUnavailable: 1
    type: RollingUpdate

(at least this is was I see in the kube-proxy DaemonSet in a system).

@rfranzke yes. just checked it.
What about
https://github.com/gardener/gardener/blob/ca661c0502eb1f885a2ac3793913025788d5102d/pkg/utils/kubernetes/health/daemonset.go#L62 ?

We had a joint look at the problem and figured that it's actually much more severe than described here.
Currently, all ManagedResource health checks for shoot resources will always wrongly report healthy although there are critical issues for shoot system components.
Short summary would be:
For the shoot grm, the target client cache is disabled (--target-disable-cache). For the seed grm (responsible for seed components only) this is not set, hence it is not affected.
The shoot grm therefore uses a direct client instead of reading from the cache (memory footprint optimization, https://github.com/gardener/gardener-resource-manager/pull/95). When reading from the direct client, the objects TypeMeta is unset (i.e. no apiVersion and kind fields present in the in-memory object).
Accordingly, this line will always return an empty GroupKind and all health checks are skipped: https://github.com/gardener/gardener/blob/0ae00ae3a9a48d7f6a692191e4aa96e9c79a3608/pkg/resourcemanager/controller/health/health_checker.go#L32-L36
Actually, one must not rely on the TypeMeta to be set when retrieved from a typed client. So that code was based on wrong assumptions when we started using a typed client for the health checks instead of unstructured request.
We don't have an integration test for grm, as output qualification was never prioritized. If we had such a test, we would have been able to catch this issue. Ref https://github.com/gardener/gardener/issues/4805
I will take over this issue and do the following:

check if this was actually working before or if it was already broken since https://github.com/gardener/gardener-resource-manager/pull/95
if not, figure out when this regressed (I have a suspicion that this was regressed by a dependency upgrade)
fix the bug (simple fix)
add a basic integration test for the ManagedResource health check controller
document this learning in the client developer guideline
check if there are other places in our codebase, where such wrong assumptions are made

/assign

Let's raise the priority of this issue according to its severity. Because of this, there will be no alerts and no failing shoot health checks for problems with shoot system components.
/priority 2

I was able to reproduce this behavior with https://github.com/gardener/gardener-resource-manager/tree/v0.25.0 (last grm release before the move to g/g) with --target-disable-cache.
Meaning, shoot system component health checks were basically broken the entire time and could never report failures since https://github.com/gardener/gardener/pull/3268<EMAIL_ADDRESS>😱

Some upstream issues for reference: https://github.com/kubernetes/kubernetes/issues/80609, https://github.com/kubernetes-sigs/controller-runtime/issues/1517
The GroupVersionKind is cleared here: https://github.com/kubernetes/kubernetes/blob/dd5c3a109e2f156774576b7e7a38e104fa5c7202/staging/src/k8s.io/apimachinery/pkg/runtime/helper.go#L254-L256
It's only set when reading unstructured objects, see https://github.com/kubernetes-sigs/controller-runtime/blob/3dafc3c844685e4f672d9e07b88b68ae3f14a842/pkg/client/apiutil/apimachinery.go#L162-L164
or when reading from the c-r cache: https://github.com/kubernetes-sigs/controller-runtime/blob/3dafc3c844685e4f672d9e07b88b68ae3f14a842/pkg/cache/internal/cache_reader.go#L101


Documentation for space-cli

The problem faced currently?
space-cli currently doesn't have documentation around using it to accomplish tasks that it can perform. If we really want a strong CLI tool that can accomplish the tasks that the dashboard can, it would be nice to have some documentation around it. A lot of developers prefer using the cli over web UIs as it just makes them faster. Also having  space-cli alternatives to common actions performed via the web UI would be great.
How can we solve it?
We could put up some documentation for space-cli along with having example space-cli commands to accomplish tasks that are performed by the web UI thereby providing users the choice to switch to cli to do the same operations.

If you want this feature to be implemented, give it a thumbs up reaction, so that we can determine which features are important to you.
👍

This is an important aspect to document.
I really love the way Google Cloud documents its actions. It uses table to differentiate between the web UI and cli. Here's an example: https://cloud.google.com/compute/docs/instances/create-start-instance

That is exactly the type of documentation that I would love to see. Having the choice between the tools and having strong documentation around both would be great :)


Add a paragraph on standard application capabilities to the introduction

Once we have the application parts of the specification completed be sure to add a paragraph on the high-level capabilities this part of the specification provides to section 1.2.

Is this already addressed by section 1.3 Capabilities?

I think I'd like to see a feature list of "built-in features" like pnp, register, file transfer, diagnostics, etc. This will help when comparing feature bullet points between protocols.


Eject with ExpoKit option fails in linux

Is this a bug report?
After running npm run eject:-
Validating project manifest...
It appears you are trying to detach outside of macOS. You will require Xcode to build the resulting artefact.
Downloading iOS code...
Moving iOS project files...
Naming iOS project...
Configuring iOS project...
Error running eject: Error: Cannot configure an iOS app with no bundle identifier.

Have you read the Contributing Guidelines?
(Write your answer here.)
Environment

Steps to Reproduce

(Write your steps here:)

Expected Behavior

(Write what you thought would happen.)
Actual Behavior

(Write what happened. Add screenshots!)
Reproducible Demo

(Paste the link to an example project and exact instructions to reproduce the issue.)

This is not a problem with React Native but Expo. You may want to reach out to Expo team or their forums.

+1

@rishii95 Have you solved this issue?


Issue template improvements

@teto What are your thoughts on including a minimal init.lua?

@elianiva Did you have any other thoughts on the changes and the included init.lua?

@elianiva Did you have any other thoughts on the changes and the included init.lua?

Does everyone like the init.lua? Is it too non-minimal? I wanted to make it fairly "batteries included"

Does everyone like the init.lua? Is it too non-minimal? I wanted to make it fairly "batteries included"


Failure to load more than 43 entries for a Jekyll post collection

Describe the bug
Failure to display more than 43 entries for a collection.
To Reproduce
Steps to reproduce the behaviour. For example:

Go to https://staging.linaro.org/admin/
Click on Older Posts
Compare list of entries with the list of posts in the repo here: https://github.com/Linaro/website/tree/develop/_posts/previous
See error

Expected behaviour
All posts should be displayed so content editors can update older posts and fix broken links.
Applicable Versions:
NetlifyCMS 2.10.4
NetlifyCMS 2.10.2
CMS configuration
https://github.com/Linaro/website/blob/develop/admin/config.yml
Additional context
We require all posts to be listed in a collection for content editors to update and fix broken links in our older posts. I've tried with and without the graphql GH endpoint option toggled with the same result. I've seen these issues which says to me that at some point or another this has worked. Am I missing something or is this feature broken? Any help would be greatly appreciated!!
Kind regards,
Kyle

Hi @kylekirkby, some of those files have an md extension while others have markdown. The CMS shows the md files by default.
You can change the default by following https://www.netlifycms.org/docs/configuration-options/#extension-and-format

@erezrokah - awesome spot! Let me test that now :)

@kylekirkby can we close this?

Yes please close! - thanks for the help on this! Should have seen this myself!


Command Line Tool

I have a suggestion that please make a Command Line Tool that starts MTA SA Server
I suggest that make a Command Line Tool that install full mta sa server and then ask Server Name  , Port , Slots , and after giving that info then it should install that mta sa typescript project and after then when ever we make a Project(scripts) and  then build it, if there will be no problem in that project(scripts), it should automatically start(if haven't started ) and restart(if already start and have some changes).
It will reduce our time and make scripting  more creative!!
I hope you understand

Command Line Tool that install full mta sa server and then ask Server Name , Port , Slots

Where are you going to use this tool?) For development purposes you can locate your resources inside the existing server folder...
Could you provide use-case where this Tool (that installs MTASA Server) can be used for?

it should automatically start(if haven't started ) and restart(if already start and have some changes).

Yes, it's a good idea. Also, I would like to implement watch feature: when the compiling is being executed on change (and is not based on IDEs file watchers).

[ ] Look at TSTL watch API
[ ] Add resource "gate" for linking the development watcher and MTASA Server
[ ] Add post-build script that automatically restarts a resource(s)


refs

https://help.github.com/en/articles/creating-and-highlighting-code-blocks
https://stackoverflow.com/questions/20303826/highlight-bash-shell-code-in-markdown

echo hello

echo 'hello'

echo hello world


⚠ Bofrost.lu has degraded performance

In 72461f2, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1762 ms

Resolved: Bofrost.lu performance has improved in f682a9e after 6 minutes.


Hashing old Block after Restart

On some occasions the log shows that an old block is being mined.
This is part of the log: As you can see, the script acknoledges that Block 792575 was mined and restarts. After the restart it continues to show calculated hashes for Block 792575.
2023-06-02 19:01:04,709 [*] New hash: 000000cf7cae0e2ca0fdc982e77a2d177cb3ed3bbedcc8b304d275d509f6b4cb for block 792575
2023-06-02 19:03:10,300 [*] New hash: 00000a7c39d8d775590364cc181289f09c08fc41a71c57ad561f78fae65332a7 for block 792575
2023-06-02 19:03:35,173 [*] New block 6a5fca7ac0452c1234c241396c93663fccec59e00000ffc70000000000000000 detected on network
2023-06-02 19:03:35,173 [*] Best difficulty will trying to solve block 792575 was 0.004819578340809793
2023-06-02 19:03:35,173 [*] Bitcoin Miner restarted
2023-06-02 19:03:45,512 [*] Working to solve block with height 792575
2023-06-02 19:05:14,620 [*] New hash: 00000c6af823df238fdbc17dad62415acd49e7ec492b99eb4322201d9597c865 for block 792575
2023-06-02 19:06:30,913 [*] New hash: 00000a6f2b0ae7e9b3fa05bcb7d0697f18fee1592ef3ec1c70e8f2f09bb79d2b for block 792575

I did not find any indication on if this is only a logging error or if the block is really being mined.
Any Idea on what could cause this behaviour?

The block height data is retrieved via an API, and sometimes there may be a delay in the provider updating its chain database with the latest block. As a result, the miner might temporarily log an outdated block height, even though it is correctly working on the current block. To allow the API provider more time to update, try to change line 124 from time.sleep(10) to time.sleep(15) before requesting the block height.


Upgrade to latest sbt-houserules

To validate this pull request against other sbt modules, please visit this link.


Provide builtin handling of exposing a C++ constructor

To the extent that constructors "return" a C++ type by value, they're not translatable to Rust because Rust moves (memcpy) are incompatible with C++ moves (which can require a move constructor to be called). Translating an arbitrary constructor to fn new() -> Self would not be correct.
The current workarounds are:

You can bind them unsafely with bindgen which assumes moving without a constructor call is okay;
You can use the "shared struct" approach when possible, which is safely movable in either language; or
You can include! a shim which does the construction behind a unique_ptr or similar.

That last approach would look something like:
// suppose we have a struct with constructor `ZeusClient(std::string)`

// in a C++ header:
std::unique_ptr<ZeusClient> zeus_client_new(rust::Str arg);

// in the corresponding C++ source file:
std::unique_ptr<ZeusClient> zeus_client_new(rust::Str arg) {
  return make_unique<ZeusClient>(std::string(arg));
}

// in the Rust cxx bridge:
extern "C++" {
    include!("path/to/zeus/client.h");
    include!("path/to/constructorshim.h");

    type ZeusClient;

    fn zeus_client_new(arg: &str) -> UniquePtr<ZeusClient>;
}

However, it would be very possible for us to handle at least the special case of types without a move constructor. In the following snippet, CXX would need to: recognize the new function name since that isn't otherwise a legal C++ function name, identify the Self type based on the extern type in return position of the function signature, statically verify there is no move constructor, and emit the constructor as an associated function ZeusClient::new to Rust.
extern "C++" {
    type ZeusClient = path::to::ZeusClient;  // the local def with a cxx::ExternType impl, via bindgen or handwritten

    fn new(arg: &str) -> ZeusClient;  // will verify there is no move constructor
}

Additionally we can consider supporting implicit UniquePtr construction of types which may or may not have a move constructor, with or without an ExternType impl.
extern "C++" {
    type ZeusClient;

    fn new(arg: &str) -> UniquePtr<ZeusClient>;  // okay even with move constructor
}

I would totally love it cxx did this directly. I know you've previously hinted that this should be in the higher-level code generator, but I always hoped you might change your mind and see a home for constructors. It's possible I'll get around to doing something here, though it's unlikely to be for a week or two, and I suspect you'll get there first.

The prospect that I am interested in exploring with this is whether we can let writing a cxx::ExternType impl give you complete free reign with a type, as if it were defined natively in Rust all along. It wasn't satisfying to say we just can't let you call the constructor because "your type might have a move constructor" and "we don't parse your header so we don't know the size of your type" when the situation is "but it doesn't" and "but I can promise (unsafely if necessary) that it's N bytes".
On the UniquePtr one, I am not fully sold at this point but I can see that it's extremely convenient, so I've mostly come around and would accept a PR on it -- but I'd like it to be after I finally get around to reviewing the #[rust_name = "..."] PR (#218) so that one can rename the Rust constructor to MyType::make_unique or whatever as appropriate. That has been next on my priorities after #276 and next to #179.

This issue states that it's safe to make a constructor, which returns a type by value, for a type without a move constructor.
i.e.
fn new(arg: &str) -> ZeusClient;  // will verify there is no move constructor

I don't think that's exactly right - counterexample:
#include <string>

class Contained {
public:
    std::string a;
    uint16_t b;
};

class ZeusClient {
public:
    Contained a;
};

Anything containing a std::string is not safe to represent by value within Rust, because std::string contains a potentially self-referential pointer.
But, I assume your plans for static assertions here involve something like std::is_trivially_move_assignable (TIL!) which seems to do the trick:
#include <iostream>
#include <string>
#include <type_traits>

class SafeStruct {
public:
    uint16_t a, b;
};

class SafeContainer {
public:
    SafeStruct a;
};

class Contained {
public:
    std::string a;
    uint16_t b;
};

class ZeusClient {
public:
    Contained a;
};

int main(void) {
    std::cout << "uint16_t " << std::is_trivially_move_assignable<uint16_t>::value << std::endl;
    std::cout << "string " << std::is_trivially_move_assignable<std::string>::value << std::endl;
    std::cout << "SafeStruct " << std::is_trivially_move_assignable<SafeStruct>::value << std::endl;
    std::cout << "SafeContainer " << std::is_trivially_move_assignable<SafeContainer>::value << std::endl;
    std::cout << "Contained " << std::is_trivially_move_assignable<Contained>::value << std::endl;
    std::cout << "ZeusClient " << std::is_trivially_move_assignable<ZeusClient>::value << std::endl;
    return 0;
}

which prints:
uint16_t 1
string 0
SafeStruct 1
SafeContainer 1
Contained 0
ZeusClient 0

I have not looked up the C++ spec to find out if "trivially move assignable" means what it sounds like it means.
I assume this is what you meant all along anyway, but as I dug into it a little, I thought I ought to post my notes here.

Thanks for clarifying -- yeah that's what I had in mind, "no move constructor" ≈≈ "no user-defined move constructor or nontrivial implicitly defined move constructor".
Rather than is_trivially_move_assignable I think what we want is is_trivially_move_constructible && is_trivially_destructible because every Rust move will conceptually trivially move construct the value in the new place and trivially destroy the old place, from C++'s perspective.
Here is a counterexample which is trivially_move_assignable but would be unsound to move in Rust:
struct Struct {
  Struct();
  ~Struct();
};

static Struct Default;
static Struct *Ptr = &Default; // invariant: always points to valid struct!!

Struct::Struct() { Ptr = this; }
Struct::~Struct() { Ptr = &Default; }

People may have already found this but note that C++ templates can be used so that methods don't need to be created for every constructor of a C++ type.
Eg
template<typename T, typename... Args>
T
construct(Args... args)
{
  return T(args...);
}

Could be used then with fn construct() -> T; or fn construct(x: i32, y: i32) -> T; (then use the #[rust_name = "construct_t"] to rename the methods for Rust so they don't collide).
Obviously you also need to ensure that the T has the right trivial vs opaque correctness with asserts, you could also have another template that returns eg a UniquePtr<T>.
But this greatly reduces the C++ code if you need to define many constructors or similar methods for types and can sortof be used as a workaround until CXX does have proper a way of describing constructors/deconstructors without the C++ glue.


Filtering activity by Recipient

Example from docs
const queryParams = {
  limit: 10, // Min: 10, Max: 100, Default: 25
  page: 2,
  date_from:<PHONE_NUMBER>, // Unix timestamp
  date_to:<PHONE_NUMBER>, // Unix timestamp
  event: [ActivityEventType.SENT, ActivityEventType.SOFT_BOUNCED]
}
mailerSend.email.activity.domain("domain_id", queryParams)
  .then((response) => console.log(response.body))
  .catch((error) => console.log(error));

possibilities of filtering
export interface ActivityQueryParams extends Pagination {
  date_from?: number;
  date_to?: number;
  event?: ActivityEventType[];
}
export interface Pagination {
  page?: number;
  limit?: number;
}

Would it be possible to filter through the api according to "Recipient" ?

Hey @Erikasc recipient filtering isn't available via the api.


Loading mixed (insecure) display content

Describe the bug
Thumbnails are loaded via http
To Reproduce
Load any video in the player and inspect console via Firefox Browser
Expected behavior
Load thumbnails via https
Screenshots

Desktop (please complete the following information):

OS: macos
Browser Firefox
Version 91

#19