Correct format issue on switch statement answers

What type of suggestion is this?
Issue with appearance or rendering
Describe the current issue or suggestion.
Bad answer format on the nested switch statement problem
Describe the solution you'd like.
New lines between outputs
Describe the origin of this idea. Did it come from an online resource, from a lecture, or some other reachable source?
No response
Additional context
No response

For quick reference:

switch-statements-practice.md
switch-statements-practice-answers.md


treewide: rename lib.licenses.apsl{10,20} -> lib.licenses.apple-psl{10,20}

Description of changes
The easy half of #301908. (The harder second half will probably be in several days.)
This renames the two versions of the Apple Public Source License seen in nixpkgs; apsl20 was often confused as being for the widely-used Apache License 2.0. apsl10 is renamed for consistency.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Please squash the commits switching packages to the new name into the commit where it was renamed, and move the commits changing to asl20 so that they happen before the rename, so we don't cause bisection annoyances.

Thanks!


origin-release: speed-up jq install

Somehow missed this change from @mfojtik's branch.

love it
/lgtm


[cordova] Add test resources for usecase-cordova 4.0

Use the latest version of statusbar for StatusBar4.0
Use statusbar 0.1.9 for StatusBar3.6

Impacted tests(approved): new 0, update 1, delete 0
Unit test platform: Crosswalk Project for Android 15.44.365.0
Unit test result summary: pass 1, fail 0, block 0
BUG=https://crosswalk-project.org/jira/browse/XWALK-4351

LGTM


Configure static External IP for Kubernetes Ingress Controller

Hi,
I am looking into using Yarp as ingress controller and need to be able to configure the LoadBalancer IP as static. In Nginx configuration, this is done by setting 'loadBalancerIP' to the requested static IP in the Service manifest. However, this setting is ignored.
Is there a way to apply this using Yarp.Kubernetes.Controller?

As far as I understand, the ingress controller isn't doing anything with the loadBalancerIP. That is, this setting isn't specific to Nginx or YARP, instead, it's your cloud provider that looks for this field and provisions the LB. Are you using the same provider when testing this?

@MahaZupan, you're absolutely correct, thanks a lot for clearing up the responsibility part! Working as expected with new Static IP provisioned by Azure Cloud


Webflux support for actuator endpoints

Currently, the starter is providing webmvc by default. That mean that a project with webflux run tomcat in addition of netty server.
The starter now should not include webmvc neither webflux, and delegates to the developer to choose the stack he prefers

This issue is solved


feat: same type security schemes

Fixes: https://github.com/stoplightio/elements/issues/1588
Shows security keys for auth schemes that occur duplicated.
Unique schemes:

Duplicated schemes:

Beautiful!


[bug] useAppKitProvider() returns walletProvider as undefined

Link to minimal reproducible example
https://github.com/AnesBkdm/walletprovider-issue
Summary
Rebounding on this issue posted by @DaveTheFrontEndDev:
https://github.com/reown-com/appkit/issues/3043
We are using the latest Nextjs packages and AppKit on Etherers v5. useAppKitProvider() returns "undefined", which makes actions like signing a message (login) impossible. Please advise.

List of related npm package versions
"dependencies": {
    "@reown/appkit": "^1.1.2",
    "@reown/appkit-adapter-ethers": "^1.1.2",
    "ethers": "^6.13.3",
    "next": "14.1.0",
    "react": "^18",
    "react-dom": "^18"
  },

Bump, also docs are outdated.

Updating right now the docs.
import { useAppKitAccount, useAppKitProvider,useAppKitNetwork  } from '@reown/appkit/react'
import { ethers, JsonRpcSigner } from 'ethers'

const compactHash = (hash: string) => {
  return hash.slice(0, 7) + '...' + hash.slice(-5)
}

export const ConnectButton = () => {
  const { address } = useAppKitAccount()
  const { chainId } = useAppKitNetwork()
  const { walletProvider, walletProviderType } = useAppKitProvider('eip155')

  async function onSignMessage() {
      if (!walletProvider || !address) {
        throw Error('user is disconnected')
      }
      console.log('Signing message...')

      const provider = new ethers.providers.Web3Provider(walletProvider, chainId)
      const signer = provider.getSigner(address)
      const sig = await signer?.signMessage('Hello AppKit!')
      console.log('Signature:', sig)
  }

  return (
    <div className="column">
      <button onClick={onSignMessage}>Sign Message</button>
      <w3m-button />
    </div>
  )
}

PR -> https://github.com/reown-com/reown-docs/pull/97

Thanks bro, that's great

@rtomas pinging because it's related, https://docs.reown.com/advanced/providers/ethereum is very poor in explaining how to use universal providers. The section that should explain how to use it with appkit is empty in content:

I think it should be at least a team goal to have easy default providers made accessible.


Question : Using Dialogs

Is there any simple sample for how to use the new Dialog directives that are now available? The Azure Function sample seems to not use the Directives.Dialog, but rather a local implementation.
Thanks

Azure function sample uses directives from AlexaSkillsKit.Interfaces.Dialog.Directives namespace. It does so through SpeechletResponseBuilder and its extensions. The magic happens in
SpeechletResponseBuilderDialogExtentions.cs and SpeechletResponseBuilder.cs

Thanks Elven, I will take a look at those code files...


Issue with Dockerfile

I was trying run Juno node with blockifier + cairo native, and got stuck on building the Dockerfile, after that I checked Dockerfile in the cairo native repo from main branch (rev. e9bc96aaa408e388f079c1f95ef8427e1fa52abe), and got strange error:

Dockerfile
FROM debian:12

# Install dependencies
RUN apt update -y && apt install -y lsb-release \
    wget \
    curl \
    git \
    build-essential \
    libclang-dev \
    libz-dev \
    libzstd-dev

# Install LLVM 17
RUN echo "deb http://apt.llvm.org/bookworm/ llvm-toolchain-bookworm-17 main" > /etc/apt/sources.list.d/llvm-17.list
RUN echo "deb-src http://apt.llvm.org/bookworm/ llvm-toolchain-bookworm-17 main" >> /etc/apt/sources.list.d/llvm-17.list
RUN wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | apt-key add -
RUN apt update -y && apt install -y llvm-17 \
    libmlir-17-dev \
    mlir-17-tools \
    libpolly-17-dev

# Install rust
RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | bash -s -- -y
ENV PATH="/root/.cargo/bin:${PATH}"

# Copy cairo_native code
COPY . /cairo_native/

# Compile cairo_native
WORKDIR /cairo_native/
ENV MLIR_SYS_170_PREFIX=/usr/lib/llvm-17
ENV LLVM_SYS_170_PREFIX=/usr/lib/llvm-17
ENV TABLEGEN_170_PREFIX=/usr/lib/llvm-17
RUN make deps
RUN make build

I'm building it with docker build .. Let me know if you need more details! 🙏

thanks for the response a lot!

had the same error and @tcoratger gave me a workaround: docker build --platform linux/amd64 -t image_tag .


Use throw rather than abort() for guid parse failures

Make winrt::guid("...") more useful at runtime by throwing on failure instead of aborting the program. See #991

@kennykerr does a successful run of "C++ for WinRT Xlang Internal Build" include the Clang validation you were asking for?

Yes, you can either validate it locally or run the build once a test has been added.

Oh and the CI build for some reason will only run branches local to this repo.

Does the test infrastructure have any existing support for compile-time negative tests (i.e. code that's expected to not compile)? I can certainly add compile-time and runtime positive tests, as well as a runtime negative test, but I'm not going to bite off setting up test infrastructure for compile-time negative tests if that's not already available...

No negative testing unfortunately.
Just need a test that validates it works in a constant expression (e.g. static_assert) and a runtime test that validates it works successfully (e.g. assert) and unsuccessfully (e.g. throw and catch).

@kennykerr I'm not sure how to trigger the "C++ for WinRT Xlang internal build" pipeline run that's required by policy... Is this even possible, since my changes are coming from a different fork? I don't think I have permission to create a branch in the official microsoft fork.

I've given you Write access so you should be able to push a branch. Then you can go here and build your branch:
https://dev.azure.com/microsoft/Dart/_build?definitionId=31784

Verified offline that Clang works with these changes too. @kennykerr any additional changes needed, or is this ready to merge?

Thanks for approving the changes, @kennykerr! Looks like I'm not authorized to merge, so you may need to complete this PR yourself...

@DefaultRyan or @jlaanstra can you help? I'm on the beach. 😎


use AbortController / AbortSignal for async code

Describe the feature
Use AbortController  when executing two promises usually a timeout with a promise that might never finish and/or finish unpredictably in the future. This might also help with Node 15+ forcefully crashing the process on unhandled promises exceptions, since when the 'stuck' promise decides to work, the state is already different and can cause undefined behavior.
Motivation
As we are moving to Node 15+, it's time to properly address the race conditions that happen when using async code. At the moment, it either piles promises that never complete or just hope they don't execute, leads to very hard to debug racing conditions or stuck runs, the RequestQueue issue being a recurrent one (negative pending requests), before it's too late 😅 (I see you #1100).

Made some progress on this, here is proposed way to handle aborting via AbortController that leverages AsyncLocalStorage to bare the abort controller instances inside the handler.
const storage = new AsyncLocalStorage();

export function tryCancel() {
  const { signal } = storage.getStore().cancelTask;

  if (signal.aborted) {
    // cancel the promise by throwing, this error will be ignored if the promise timed out already
    throw new Error();
  }
}

async function timeout(time, errorMessage) {
  try {
    await setTimeout(time, undefined, { signal: storage.getStore().cancelTimeout.signal });
    storage.getStore().cancelTask.abort();
  } catch {
    // ignore rejections (task finished and timeout has been cancelled)
    return;
  }

  throw new Error(errorMessage); // timeout error that will be shown
}

async function addTimeoutToPromise(handler, time, error) {
  const cancelTimeout = new AbortController();
  const cancelTask = new AbortController();

  const wrap = async () => {
    try {
      await handler();
    } finally {
      storage.getStore().cancelTimeout.abort();
    }
  };

  await new Promise((resolve, reject) => {
    storage.run({ cancelTimeout, cancelTask }, () => {
      Promise.race([
        timeout(time, error),
        wrap(),
      ]).then(resolve, reject);
    });
  });
}

In practice we would need to only add the tryCancel() calls after each await in the handler, rest should be handled automatically.
async function doSomething() {
  await setTimeout(200); // do something async
  tryCancel(); // check if we are aborted

  await setTimeout(200); // do something async
  tryCancel(); // check if we are aborted

  await setTimeout(200); // do something async
  tryCancel(); // check if we are aborted

  await setTimeout(200); // do something async
  tryCancel(); // check if we are aborted
}

await addTimeoutToPromise(
  // we need to pass callbacks, not raw promises, so they are executed after the ALS context is created
  () => doSomething(),
  1000,
  'timed out',
);

If all we care about is cancelling the handler. Sometimes we might want to do some cleanup, so the tryCancel could also have a callback parameter.
Testing script here. Will try to incorporate this into the crawlers now.

Actually throwing works fine, just need to catch that particular error in the wrap handler. This will need to be handled in the browser pool too, so we can cancel as early as possible. We will need a shared ALS instance (for both SDK and browser pool, and possibly other packages once we have it split in the monorepo), so will make this a new package in the apify-shared repo first.
Got it hacked locally and with that repro, it does not even try to open the browser due to the timeout (and keeps retrying without any other error logs), but it literally means we need to do the tryCancel() after every single await on given path.

https://github.com/apify/apify-shared-js/pull/267

// we need to pass callbacks, not raw promises, so they are executed after the ALS context is created

Instead of changing this function, I would create a new one addTimeoutToAsyncFunction or something like that. It's good that we'll do this. I think @pocesar found an issue with the timeouts that the promise can get rejected in between the time where it's created and when the handlers are attached to it inside addTimeoutToPromise leading to unhandled rejections.

Btw, this would be a nice blog post. I don't think there were a lot of good resources about this when we first started looking into it.

It will be a new package, @apify/timeout, I won't be changing the existing implementation of addTimeoutToPromise. I kinda like that name, if we are to pick something else to reduce confusion with the existing method, I would maybe go with something less verbose, like just addTimeout(). addTimeoutToAsyncFunction sounds quite verbose :D Btw the handler does not need to be async, the signature requires it but it will work fine with a regular function too.
Agreed on the blog post, definitely stuff worth sharing, weird that this combo is not mentioned in any articles about abort controller, I guess it's too cutting edge.


Neutral Natures Don't Work

When selecting a neutral nature, it does not adjust the spread and appears to just use whatever the last selected non-neutral nature output.

I'll take a look at this :) Thank you!


[WIP] Set client roles using KC realm json file

related to https://github.com/fabric8io/fabric8-platform/issues/272

The updated fabric8-realm.json isn't valid JSON I'm afraid, I fixed it up locally but then hit another issue so I think maybe there's something missing still
Caused by: com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: Unrecognized field "clientRoles" (class org.keycloak.representations.idm.RolesRepresentation), not marked as ignorable (3 known properties: "application", "client", "realm"])
 at [Source: java.io.FileInputStream@13e15108; line: 67, column: 22] (through reference chain: org.keycloak.representations.idm.RealmRepresentation["roles"]->org.keycloak.representations.idm.RolesRepresentation["clientRoles"])

@rawlingsj i will check it tmw, i missed something then

[merge] awesome!!! thanks @hectorj2f


Notation of imported clusters are modified

SURE-6773
Issue description:
When customer upgraded Rancher from 2.6.10 to 2.6.13, the value of status.driver in clusters.management.cattle.io changed when importing a GKE cluster.
In Rancher 2.6.10, it showed "Imported", but now it shows "GKE". Is this by specification? Same as AKS, EKS.
$ kubectl --kubeconfig=${HOME}/.kube/config-00rancher1 get clusters.management.cattle.io c-wvcvq -o custom-columns=ClusterId:metadata.name,Name:spec.displayName,K8sVersion:status.version.gitVersion,Provider:status.driver,Created:metadata.creationTimestamp,Nodes:status.appliedSpec.rancherKubernetesEngineConfig.nodes[*].address
ClusterId   Name                      K8sVersion         Provider   Created                Nodes
c-wvcvq     ko-prd-import-0619-1835   v1.25.8-gke.1000   GKE        2023-06-19T09:35:34Z   <none>

Repro steps:
Create GKE, AKS, EKS cluster and import it to Rancher.
Workaround:
Is workararound available and implemented? no
Actual behavior:
Showed as "GKE".
Expected behavior:
Showed as "Imported".

Behavior is correct, status provider driver is set based on operator used for orchestrating. Driver imported is used only for importing generic clusters.
This issue is INVALID

closing based on feedback from jira


Use v1 api for CRD

CustomResourceDefinition has been promoted to V1 in 1.16. It adds some new features that are handy, like support for openapi spec in the definition. The beta1 spec might be lined up for deletion at some point too.

In addition to the deprecation / lack of validation / there is also the issue that the CRD name was inherited from an IBM internal deliverable so has an incompatible CRD of the same name leading to issue. Propose to switch name at the same time as introducing v1, expect this will be a breaking change.

In addition to the deprecation / lack of validation / there is also the issue that the CRD name was inherited from an IBM internal deliverable so has an incompatible CRD of the same name leading to issue. Propose to switch name at the same time as introducing v1, expect this will be a breaking change.


How to follow updates?

I love the project! I find myself coming back about every week to see what's new. Is there a better way? Perhaps a community were announcements are done? If not perhaps releasing a changelog and people can sign up to watch? Thanks!

Well hopefully https://github.com/catppuccin/nix/pull/124, should save a bit of hassle when it comes to tracking, otherwise it might be cool to have a changelog.

You might consider infinisil's approach he's been working on. https://github.com/NixOS/nixpkgs-check-by-name/issues/38

Well hopefully #124, should save a bit of hassle when it comes to tracking, otherwise it might be cool to have a changelog.

This repository uses release-please but I don't believe a release has been cut yet for the changelog to exist. I'm not sure what @getchoo's plan is for v1 before merging #65 but I'd personally have probably merged v1 when it got transferred into the organisation

I'm not sure what @getchoo's plan is for v1 before merging https://github.com/catppuccin/nix/pull/65

in all honesty, i'm not sure either. this is an issue i've definitely put to the side over the last few months, as i feel most releases would be fairly arbitrary (with the exception of v1 when the transfer happened...that would've made a lot of sense lol) with the current pace of additions. i also think some aspects of semantic versioning like bumping the major version for public api changes could introduce problems at the scale of so many ports. a good example would be changes in individual ports possibly changing appearance; would that be a breaking change? what about any ports that may be dropped by the org for some reason? would each of those constitute api breakage and a major release?
a solution i've been considering both for solving the problems with versioning and (more on topic with this issue 😆) is possibly having snapshot/date based releases. i think this would be more representative of the project's rapid additions with few (if any) backwards incompatible changes, and give a way to consistently update people on these changes at regular intervals
curious to here what others think would be a good approach here, since i know versioning in nix can be a pretty controversial topic

curious to here what others think would be a good approach here, since i know versioning in nix can be a pretty controversial topic

Two things from me:

Ultimately, I don't mind what versioning scheme we use as long as we're consistent and stick to the rules that we end up defining. Regarding the existing semver versioning, I think it's a very slippery slope if you start to consider the actual changes to themes as breaking changes/features. I think the semver aspect should be purely contained to the actual repository (e.g. changing an existing option or removing an existing port would be a breaking change, adding new ports would be features, etc?)
Datetime based releases seem like a good option if we decide that semver doesn't make enough sense here, but it's worth noting that we'd have to rip out the existing release-please config.

I'm not too involved in the nix ecosystem but my first thoughts are to look at prior art and see what versioning schemes other repositories similar to ours use?

Worth consideration:
https://lobste.rs/s/ynhu2s/effver_version_your_code_by_effort
https://jacobtomlinson.dev/effver/

Ultimately, I don't mind what versioning scheme we use as long as we're consistent and stick to the rules that we end up defining. Regarding the existing semver versioning, I think it's a very slippery slope if you start to consider the actual changes to themes as breaking changes/features. I think the semver aspect should be purely contained to the actual repository (e.g. changing an existing option or removing an existing port would be a breaking change, adding new ports would be features, etc?)
Datetime based releases seem like a good option if we decide that semver doesn't make enough sense here, but it's worth noting that we'd have to rip out the existing release-please config.
I'm not too involved in the nix ecosystem but my first thoughts are to look at prior art and see what versioning schemes other repositories similar to ours use?

I don't particularly think this repo needs releases at all. Since people can pin this flake to a certain commit. But If we really did want releases we could use flakehub.
And in terms of things breaking on this repo, nix provides some nice lib functions for renaming modules and removed ones and so on.

#124 is good enough for me. Feel free to close the issue.

A simple way to be notified of updates would be to follow the Atom feed for commtis to this repository, https://github.com/catppuccin/nix/commits/main.atom, though that of course wouldn't filter new additions from other types of commits.


PropTypes from prop-types package to silence that<EMAIL_ADDRESS>warning

Have to close it because there were no response. But prop-types are added and merged at 1.2.0 with another PR


Incorrect Typings

The ScheduleCampaignParams contains an incorrect typing.
delivery?: "instant" | "scheduled" | "timezone_base this shows that delivery was made optional, whereas it's required when making the request. See the response below:

Looking at it everything was made optional, that implies empty {} can be passed

Fix released in 1.2.1


Generate an otr_dsa if the rest of the config is there

This lets you create new profiles by copying old ones, without having to go
through the slow manual configuration CLI.

thanks!


Unify menu bars for desktop and mobile

Resolved in https://github.com/pill-city/pill-city/commit/c1561ba7cfc2ebb922746be4744fc5998365f8b4


[Feature][Helm] Expose the autoscalerOptions

Why are these changes needed?

The options of the Autoscaler are useful but not exposed to the Helm values.yaml, such as idleTimeoutSeconds and resources.
Related issue number

Closes #665
Checks

[ ] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[x] Manual tests
[ ] This PR is not tested :(

Hi @DmitriGekhtman ,
Would you mind reviewing this PR?

Deferring to @kevin85421 for this one.

Hi @kevin85421 ,
I've merged the master and modified the commits. Please give me some feedback.

Hi @DmitriGekhtman @kevin85421 ,
Thanks for your help. I did learn a lot from your discussions and this PR.
Your recommendation keeps not only the flexibility of autoscalerOptions but the template clear.


Categorical feature imputer

I see RandomForestClassifier in the iterforest module, but I think there is no imputer algorithm for the classification problem. Are you planning to integrate?

Yup, I'm planing to solve this problem these months but not use RF, but i recommand scale data so we can sonsider classification mission as regression (like min-max scale). Thanks for advice:)

By the way, if you are willing to try to solve the problem with the random forest, I really appreciate it.It would be very nice if you contribute this library!

By the way, if you are willing to try to solve the problem with the random forest, I really appreciate it.It would be very nice if you contribute this library!

Thank you very much for your reply. I would love to contribute, I will try it!


Fix: Return no missing intervals for seed models if evaluated at least once

we probably don’t need hooks for seeds

@eakmanrq @tobymao  Even if we do allow hooks for seeds I think the contract is that hooks should run on each evaluation. I think it's pretty clear that seeds are evaluated once and only once (unlike full model kind), so there should be no problem with that.

@izeigerman What is our reasoning then why views would then be evaluated on each cadence? I remember when we discussed this we decided to that because someone might have hooks on the views that they would want to be executed. I just don't see why this is any different than seeds? I think consistency here would be great.

@eakmanrq

because someone might have hooks on the views that they would want to be executed

That's not the only reason though. View might be dependent on something like @latest_ds, so the evaluation won't be the same every time.

Fair but someone might also do other things with hooks on views that have a static definition (just like their seeds). It seems non-intuitive to allow that but not allow that on seeds.

fwiw i think views of seeds are different so i'm fine with it


change real owner of flow not possible: ensure only adds co-owners

Priority
(Urgent) I can't use the CLI
Description
(related to this bug #5372)
while listing the "owners" of a flow returns principals with roleName "Owner" I can only choose "CanEdit" and "CanView" to "ensure" a role.
id                                   roleName permissionType principalType userDisplayName          userEmail
--                                   -------- -------------- ------------- ---------------          ---------
cac85679-*************************** CanEdit  Principal      User<EMAIL_ADDRESS>ab40c16e-%%%%%%%%%%%%%%%%%%%%%%%%%%% Owner    Principal      User          %%%%%%%%<EMAIL_ADDRESS>

m365 flow owner ensure --userId $changeToOwnerId --environmentName $envItem.name --flowName $fl.name --roleName "Owner" --asAdmin --verbose
m365 flow owner ensure doesn't support "Owner" as role ... why?
in v6.4.10 (beta) there supposed to be an add action for m365 flow owner
What options are there to use any CLI to set "main owner" of a flow, scripted?
or do I have to apply a list of m365 actions to achieve the same?
Steps to reproduce
m365 flow owner ensure --userId $changeToOwnerId --environmentName $envItem.name --flowName $fl.name --roleName "Owner" --asAdmin --verbose
Expected results
change the main owner of a flow
Actual results
not supported roleName
Diagnostics
No response
CLI for Microsoft 365 version
v6.10.0
nodejs version
v18.17.0
Operating system (environment)
Windows
Shell
PowerShell
cli doctor
{
  "os": {
    "platform": "win32",
    "version": "Windows 10 Enterprise",
    "release": "10.0.19044"
  },
  "cliVersion": "6.10.0",
  "nodeVersion": "v18.17.0",
  "cliAadAppId": "31359c7f-bd7e-475c-86db-fdb8c937548e",
  "cliAadAppTenant": "common",
  "authMode": "DeviceCode",
  "cliEnvironment": "",
  "cliConfig": {},
  "roles": [],
  "scopes": [
    "AllSites.FullControl",
    "AppCatalog.ReadWrite.All",
    "AuditLog.Read.All",
    "Bookings.Read.All",
    "ChannelMember.ReadWrite.All",
    "ChannelMessage.Read.All",
    "ChannelMessage.Send",
    "ChannelSettings.ReadWrite.All",
    "Chat.Read",
    "Chat.ReadWrite",
    "Directory.AccessAsUser.All",
    "Directory.ReadWrite.All",
    "ExternalConnection.ReadWrite.All",
    "Group.ReadWrite.All",
    "IdentityProvider.ReadWrite.All",
    "Mail.ReadWrite",
    "Mail.Send",
    "Notes.Read.All",
    "Place.Read.All",
    "Policy.Read.All",
    "Reports.Read.All",
    "SecurityEvents.Read.All",
    "ServiceHealth.Read.All",
    "ServiceMessage.Read.All",
    "ServiceMessageViewpoint.Write",
    "Tasks.ReadWrite",
    "Team.Create",
    "TeamMember.ReadWrite.All",
    "TeamsAppInstallation.ReadWriteForUser",
    "TeamSettings.ReadWrite.All",
    "TeamsTab.ReadWrite.All",
    "TermStore.ReadWrite.All",
    "User.Invite.All",
    "User.ReadWrite.All",
    "profile",
    "openid",
    "email",
    "user_impersonation"
  ]
}

Additional Info
No response

Hi @milanholemans,
I might be lucky in fact then, because the flows are all part of a solution.
how is it done then?
but wouldn't it be possible to "replicate" the behaviour of UI?!

I might be lucky in fact then, because the flows are all part of a solution. how is it done then?

For now, it's not possible using CLI unfortunately. But we can try looking into that to enhance the command. If this is something that we should look into, I suggest that you create a new issue to enhance the command so we can have a look at it.

but wouldn't it be possible to "replicate" the behaviour of UI?!

Haven't looked into the API that's being used there yet. But it's probably something we can learn from indeed.

For now, it's not possible using CLI unfortunately. But we can try looking into that to enhance the command. If this is something that we should look into, I suggest that you create a new issue to enhance the command so we can have a look at it.

you mean "enhance" the "ensure" command?! or shouldn't that go into some other area then? comparable to changing an app owner - m365 pa app owner set?! or part of the solution area?

Haven't looked into the API that's being used there yet. But it's probably something we can learn from indeed.

it's couple of patch and post commands I think, but didn't investigate, either

Since it's not a bug, I'm going to close this issue @smadep. If you want us to create a command to set the owner of a flow in a solution, please create a new issue. I think I figured out a way how we can achieve it.


Fix gutterBackgrounds to a fixed gutter

When scrolling horizontally with a fixed gutter, gutter backgrounds were left behind.

Thank you. Merged as 6d1379e


ToDo not available as an API permission anymore?

Sorry, I'm not sure what that is a screenshot of. Please explain what you are trying to do and where you are stuck.

Did you look for Tasks?

Apologies. Yes I see now I need to change 'Task' permissions and that there isnt a 'Todo' permission to change. Thank you


Tswhison/pull libs

Coverage increased (+0.02%) to 80.314% when pulling 6aabd621d8874a650398b0fefffaf78f19c83ef7 on tswhison/pull_libs into 9ac44384e9cb245c66bc3578b78192fae39dec18 on master.


Bug: Objekts in modals aren't visible in Firefox (or related browsers)

I haven't quite figured this out yet, and wasn't worrying about it, but since Nova's indexer has been down for a few days, now it's bugging me.
The position: absolute on these lines definitely is causing issues in Firefox and other FF-based browsers: https://github.com/teamreflex/cosmo-web/blob/707c98e76234f66a9604c5b6f0b41b64ea5aabec/src/components/objekt/objekt.tsx#L43
With that rule on, the image and its parent have a width of 0:

When absolute is removed on the img and its parent:

Tested in Firefox and Floorp with the same result. Tested in Safari and it works fine, and I'm assuming it works in Chrome since that's what most foliks use. I don't really understand why though, I don't see any CSS in there that's Chrome or Webkit specific.
Setting a min-width works just fine, but also throws off the modal layout. I'm an ops eng, not frontend, and I've never touched Tailwind, so I don't want to go breaking your CSS if you might have a quick solution. But I can pull it down and fiddle with it if you want.

god i hate firefox. i'll take a look today, thanks

constraining the container to match the aspect ratio fixed it, i guess firefox doesn't like grid auto columns expanding their cell size or something like that

Thank you!


[AMBARI-24604] Stack advisor error popup with "500 status code" throw…

…n during customize service page of install wizard (dsen)
What changes were proposed in this pull request?
Added the check
How was this patch tested?
manually

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3881/
Test FAILed.
Test FAILured.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3891/
Test PASSed.


Set spotless checking unused imports

Add autoformatter spotless (https://github.com/diffplug/spotless) embedded into build
Apply google format (version 7) format. Version 7 since it still supports java8.
Currently it is set to check unused imports only
Now in case of violations it could being automatically fixed (including removal of unused imports) with mvn spotless:apply (this will be also mentioned in error message).
Here the format fix is the result of mvn spotless:apply

Codecov Report

Merging #220 (753ea12) into master (d064f8d) will decrease coverage by 0.35%.
The diff coverage is 95.97%.

@@             Coverage Diff              @@
##             master     #220      +/-   ##
============================================
- Coverage     94.63%   94.27%   -0.36%
+ Complexity     1854     1851       -3
============================================
  Files           187      187
  Lines          3914     4053     +139
  Branches        392      418      +26
============================================
+ Hits           3704     3821     +117
- Misses          110      124      +14
- Partials        100      108       +8

Impacted Files
Coverage Δ

...et/datafaker/passportnumbers/AmPassportNumber.java
80.00% <ø> (ø)

...et/datafaker/passportnumbers/ChPassportNumber.java
80.95% <ø> (-0.87%)
:arrow_down:

...rc/main/java/net/datafaker/service/FakeValues.java
81.00% <ø> (-0.92%)
:arrow_down:

...java/net/datafaker/service/FakeValuesGrouping.java
92.30% <ø> (+0.64%)
:arrow_up:

.../java/net/datafaker/service/FakeValuesService.java
88.44% <ø> (-0.15%)
:arrow_down:

src/main/java/net/datafaker/service/FakerIDN.java
72.72% <ø> (ø)

.../main/java/net/datafaker/service/LocalePicker.java
90.62% <ø> (ø)

...main/java/net/datafaker/service/RandomService.java
90.90% <ø> (ø)

.../main/java/net/datafaker/service/files/EnFile.java
94.44% <ø> (+1.11%)
:arrow_up:

src/main/java/net/datafaker/Hearthstone.java
84.61% <84.61%> (-15.39%)
:arrow_down:

... and 203 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

I'm not a fan of the formatting. The line breaks seems a bit arbitrary, the javadoc code comments are now  weird, and it seems this formatting is very incompatible with my IntelliJ settings. What are you trying to solve here?

@bodiam
I made some changes, now it checks only for unused imports

I don't mind spotless, but I mind the overly aggressive formatting. I'm not sure about all the options, but maybe there's a compromise to be found here

The main idea idea is automation: instead of complaining only(like e.g. checkstyle ) it could fix violations across the project

Let's do it


not recognized event

Hi
i recoded by this commnd (Win 10 Home last update)
pktmon start  --capture --comp {} --pkt-size 0 -f {}
and save the ETL
when i use the tool here i go error "Input ETL file does not contain a packet capture"
but when i use "PktMon.exe etl2pcap PktMon.etl -o dd.pcap" [inside the system]
Processing...
Packets total:       8
Packet drop count:   0
Packets formatted:   8
Formatted file:      dd.pcap
all good
what the difference ?

Hi, see #24 . Etl2pcapng is built for converting packet captures collected with "netsh trace start capture=yes". Pktmon packet captures can only be converted using pktmon.

tnx for the answer!


fix(coil-extension): fix button color, rm dropshadow

Attempt @ #1817

@sublimator looks like this update still keeps the button as blue. I'm going to check with @fruehle to see if he wants the buttons updated to the Coil Grey800 per the most updated FIgma

@mwill8886
Thanks! Feel free to take over this PR, close it, whatever

Updated PR to match latest figma styles

Changed button to Grey.800 & hover state to black
Updated copy for CoilExploreView & CoilPopupView
Changed x padding on layout


Allow other mixins to call toJSON, parse, validate

By temporarily changing the constructor reference, other mixins on the same model can properly use __super__ to call super methods.

oops, meant to target upstream repo


Respawn player based on number of lives

The player should respawn based on the number of lives in reserve.

Implemented by commits e8c5f05662c4242d5e08cd481cf8caede1e1862d and 90588dbba2f856d99ecea0bfed67bb9971fd3508.


[Snyk] Security upgrade findup-sync from 2.0.0 to 4.0.0

Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):

frontend/package.json

Vulnerabilities that will be fixed with an upgrade:

Issue

Prototype Pollution SNYK-JS-UNSETVALUE-2400660

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Prototype Pollution

Checkmarx One – Scan Summary & Details – ad390fe6-f772-4d67-a727-3bbdd01fa66f
No New Or Fixed Issues Found


update all clis to latest version for v6.4.4

https://github.com/Shippable/pm/issues/10515

I updated CLI Packages current version to latest version

CLI Packages
Current Version
Latest Version
Link for Latest releases

Aws-CLI
1.11.164
1.14.64
https://github.com/aws/aws-cli/releases

Awebcli
3.11.0
3.12.4
https://pypi.python.org/pypi/awsebcli/3.10.0

Azure-CLI
2.0.25
2.0.*
https://github.com/Azure/azure-cli/releases

Verified the latest versions of CLI

@vijayreddy1991 can you first add a list of all the packages that were upgraded in the issue description. i'll close the issue after that

I updated please take a look at it

ok. looks good. closing this now

I updated  latest release version links for CLI Packages

I updated the patch version for Azure-cli


need the ability to prevent unselect

Am using the treeview and need to be able to make it so that once a node is selected, you cannot click on it again to unselect it, (but retain the ability to unselect a node when you select a different node).
So basically a global option is required - something like 'min-selections' so that you can set this to '1' to prevent people from having less than 1 selection. A 'max-selections' option would also be useful for multiselect trees so you can make it so that users cannot select more than X nodes in a single tree.
if min-selections is set to greater than 0, then you cannot unselect any node until you have reached more  than that number of selections.

I'd like to see this functionality as well. I tried using a nodeUnselected handler that reselects the node immediately after it is unselected but unfortunately it stayed unselected.

Same here. I want this functionality.

I have same trouble, read this issue and solve it by setting treeview multiSelect to true and adding code  below to onNodeSelected handler:
if (selectedNodes = $(this).treeview('getSelected')) {
selectedNodes.forEach(function(node) {
if (node.data != item.data) $(this).treeview('unselectNode', node.nodeId);
}, this);
}
so at onNodeUnselected you can handle deselect to keep selection:
if ($(this).treeview('getSelected').length == 0) {
$(this).treeview('selectNode', item.nodeId)
}
actually when multiSelect is false it is also works but have some weird event rotations I unable to realize how to fix
anyway I agreed with other peoples that it is better to have such behavior natively.

Would be nice to have such feature

This is covered by #173


Implement javaEnums extension

Implement javaEnums extension to extend on what javaEnumNames provided.

@joelittlejohn I have additionally changed some of the methods to protected to allow a custom EnumRule to be able to extend the rule in multiple different discrete ways instead of copy-n-pasting or reimplementing it all.
For example in a custom EnumRule I would like to write for my project I would like to even override the Constructor that is generated and add additional fields to the enum.  The actual use case is obscure so I am implementing it outside of this project.

@joelittlejohn can we get this pull request in?

If you could add something to https://github.com/joelittlejohn/jsonschema2pojo/wiki/Reference#extensions that would be great :+1:

I will put it on my todo list.


Improve config page display when values are null

Resolve #
Description:
Referring to this PR - https://github.com/ServiceNow/azimuth/pull/366
Checklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

[x] ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
[x] PRE-COMMIT. You ran pre-commit on all commits, or else, you
ran pre-commit run --all-files at the end.
[x] USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
our users.
[x] DEV CHANGES.

Update the documentation if this PR changes how to develop/launch on the app.
Update the README files and our wiki for any big design decisions, if relevant.
Add unit tests, docstrings, typing and comments for complex sections.

In the future, please don't close and re-open PRs just to rename the branch. It makes us lose our review conversation.

In the future, please don't close and re-open PRs just to rename the branch. It makes us lose our review conversation.

Sure, I was not aware it would create a new branch and close the old one. That's why I did not change the branch names for my other PRs


Fix dependencies in tutorial

Just a small fix to remove the +  before the yew dependency. Assuming it's a mistake?

Technically the '+' was supposed to be there to indicate which lines are new to the snippet, but I think this particular snippet is short enough that it doesn't need it.

Makes sense! The thing that was problematic for me was that I hit the copy button that pops up and the +  came along for the ride.


"This image was ray traced in about 10 hours"

Hello and thanks for the great project.
Can you indicate which tools you used for ray tracing the points in the text file?
Thanks.

https://github.com/fogleman/tracer


Report out # of cores to dashboard on job start, not just job end

Fixes #5750
@ticoann please review and merge

This is actually going to conflict with #5754. Either is simple to change and this request is certainly lower risk/impact.

OK. Thank you for letting me know. Anyway, I will merge the patches after production deployment finished.


Rename all df properties to to_pandas() lru-cached methods

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

5 of 5 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.004%) to 93.899%

Totals

Change from base Build<PHONE_NUMBER>:
0.004%

Covered Lines:
1462

Relevant Lines:
1557

💛  - Coveralls


Add plugin name (in addition to the plugin package name) to plugin metadata (Trac #115)

This would allow us to easily get the plugin name from archive files. These names should also be scraped/stored on the update server so that plugins can be found based on their plugin or package name.
Migrated from http://microfluidics.utoronto.ca/microdrop/ticket/115
{
    "status": "closed",
    "changetime": "2014-04-17T19:39:43",
    "description": "This would allow us to easily get the plugin name from archive files. These names should also be scraped/stored on the update server so that plugins can be found based on their plugin or package name.",
    "reporter": "ryan",
    "cc": "",
    "resolution": "fixed",
    "_ts": "1397763583719301",
    "component": "microdrop",
    "summary": "Add plugin name (in addition to the plugin package name) to plugin metadata",
    "priority": "minor",
    "keywords": "",
    "version": "0.1",
    "time": "2012-08-01T16:00:41",
    "milestone": "Microdrop 1.0",
    "owner": "cfobel",
    "type": "enhancement"
}

Trac update at 20120801T16:06:52:

ryan changed description from "This would allow us to easily get the plugin name from archive files. These names should also be scraped by the update server so that plugins can be found based on their plugin or package name." to "This would allow us to easily get the plugin name from archive files. These names should also be scraped/stored on the update server so that plugins can be found based on their plugin or package name."
ryan changed summary from "Add plugin name (as opposed to the plugin package name) to plugin metadata" to "Add plugin name (in addition to the plugin package name) to plugin metadata"

Trac update at 20120803T05:04:25: cfobel commented:

The git@microfluidics.utoronto.ca:dmf_control_board.git plugin has been updated to change the properties.yml format.  The "name" attributes has been replaced by a "package_name" attribute and a new property has been added, called "plugin_name".  Note that the remaining plugins (e.g., abbott, etc.) must be updated to have their plugin_name values scraped by the plugin repository scraper.
On the update server the following methods have been added to the Plugin jsonrpc API:
-available_plugins()       -> return list of available plugins by
instance name, taken from properties.yml:plugin_name
-package_name(plugin_name) -> return the package name corresponding
to the specified plugin name
-plugin_name(package_name) -> return the plugin name corresponding
to the specified package name

Trac update at 20120808T21:33:39:

ryan changed resolution from "" to "fixed"
ryan changed status from "new" to "closed"

Trac update at 20140417T19:39:43: ryan changed component from "" to "microdrop"


Improve graceful shutdown error reporting

When the node encounters an error, that error is bubbled up to the highest level of async, where we then initiate our graceful shutdown logic for the node. This graceful shutdown logic is supposed to log the error, generate a crash report, and shut things down in a more graceful manner. However, we are seeing that it doesn't always do this well: there seems to be some code paths in which the error will not actually get logged sufficiently before the shutdown finishes. We just end up with logs that say graceful shutdown has started with no other information.
Below is an example of what this looks like in the logs (no error or useful information prior to this).
{"timestamp":"2024-04-21 10:57:00.890593Z","level":"Info","source":{"module":"Exit_handlers","location":"File \"src/lib/exit_handlers/exit_handlers.ml\", line 31, characters 4-15"},"message":"Running async shutdown handler: $description","metadata":{"description":"Close transition frontier, if exists","host":"<IP_ADDRESS>","peer_id":"12D3KooWBtktgL7kvikZScEAioJpv36DVx6vBMECKbMRWc25rT5R","pid":18,"port":8302}}
{"timestamp":"2024-04-21 10:57:00.890632Z","level":"Info","source":{"module":"Exit_handlers","location":"File \"src/lib/exit_handlers/exit_handlers.ml\", line 31, characters 4-15"},"message":"Running async shutdown handler: $description","metadata":{"description":"Remove daemon lockfile","host":"<IP_ADDRESS>","peer_id":"12D3KooWBtktgL7kvikZScEAioJpv36DVx6vBMECKbMRWc25rT5R","pid":18,"port":8302}}

Let's fix this in develop for now so that we don't introduce risk to berkeley or compatible so close to the upgrade.


add .env.example file

This patch updates the README's and adds the .env.example
Happy to rebase this when #3 is landed.

merged #3 if you want to rebase. or i can add these edits separately.

thanks @beeman


python310Packages.aliyun-python-sdk-cdn: 3.7.9 -> 3.7.10, python310Packages.aliyun-python-sdk-config: 2.2.2 -> 2.2.3

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 207939 run on x86_64-linux 1

4 packages built:

python310Packages.aliyun-python-sdk-cdn
python310Packages.aliyun-python-sdk-config
python39Packages.aliyun-python-sdk-cdn
python39Packages.aliyun-python-sdk-config


it has performance issue when we drag&drop on a tree with about 500 rows open all

I'm following the doc, everything is working fine. However if we have a tree with about 500 rows openAll,  it's very slow (responsive) when we drag&drop
Do you have any suggestion on how to improve performance?
Thank you!

yes, When dragging all my custom nodes are keeping re-rendered. Do you know when you are able to improve it by reducing unnecessary rendering during drag operations? Thanks @minop1205

The problem is caused where the top level component in the library is re-rendered during a drag operation.
Therefore, a library modification is required to correct the problem. I am currently working on resolving this issue, but have not yet completed the process.

@minop1205 Any update about this?

@minop1205 Any updates?

@minop1205 Are you continuing to work on this?

Hey everyone! I've uncovered a way to drastically reduce re-renders for our CustomNode component, and in my project, it's resulted in a significant performance boost !
The key is using useFuncImmutable to make the changing handles immutable, allowing React.memo to work.
Hope this helps you out!
type CustomNodeProps = {
  node: TreeNode;
  depth: number;
  isOpen: boolean;
  onToggle: () => void;
  onClick: () => void;
  onCtrlClick: () => void;
};

function useFuncImmutable<T extends (...args: any[]) => any>(fn: T) {
  const ref = React.useRef(fn);
  ref.current = fn;
  return React.useCallback((...args: any[]) => {
    return ref.current(...args);
  }, [])  as T;
}

// reduce rerenders
export const CustomNodeWrapper: React.FC<CustomNodeProps> = (props) => {
  const onToggle = useFuncImmutable(props.onToggle);
  const onClick = useFuncImmutable(props.onClick);
  const onCtrlClick = useFuncImmutable(props.onCtrlClick);
  return (
    <CustomNodeMemo
      {...props}
      {...{
        onToggle,
        onClick,
        onCtrlClick,
      }}
    />
  );
};


Begin supporting nix flakes build system

So far there is:

a default package called yosys
a devShell to compile yosys

None of them work as is. They give the following error when trying to compile:

./kernel/yosys.h:42:10: fatal error: 'map' file not found
#include
^~~~~

This error was reported in https://github.com/YosysHQ/yosys/issues/681.
So this PR only makes sense to merge after all the requested changes are made to https://github.com/YosysHQ/yosys/pull/4234 and it is merged.
Follow up actions would be to:

create a github actions building yosys with nix
include tests in flake.nix

Does it make sense to have a flake without the lock file? Is that even possible?

Does it make sense to have a flake without the lock file? Is that even possible?

I think it doesn't make much sense, because one of the main purposes of nix is to provide reproducibility.
Without the lock file, every time a user builds the package, a new version of nixpkgs would get pulled. Most notably, the version of the compilers and dependencies would not be version controlled.
That's why this PR provides both flake.nix and flake.lock

I think it doesn't make much sense, because one of the main purposes of nix is to provide reproducibility. Without the lock file, every time a user builds the package, a new version of nixpkgs would get pulled. Most notably, the version of the compilers and dependencies would not be version controlled.

I understand the value of reproducibility, but I am not convinced we want to maintain a pinned version of compilers and other dependencies as part of the source tree. I worry that would mean a collection of stale hashes which will get updated irregularly.
If we only include the flake without the lock file, that would still mean others can supply their lock files easily, if they wish to pin the dependencies and establish reproducibility. We will just supply the Nix building instructions as part of the source tree.

The key question is: What happens when the build breaks?
If YosysHQ has someone who can and will fix the build, that makes it no different than any other source of breakage, whether it's broken immediately after a nixpkgs update, or at night when the cronjob runs. (For example upstream changes in iverilog recently broke our builds.)
If YosysHQ does not, then the flake should probably just not be in the repo.

Actually, one advantage of having the flake lockfile be committed that I think no one brought up yet is that it enables people to keep building historical revisions of Yosys in the exact environment that passed CI.
@povik Is this something that will change how you feel about committing the lockfile?

I have created a repo to maintain the flake out of tree: https://github.com/RCoeurjoly/yosys_flake/tree/main.
I think @whitequark is right in that adding flake to this repo would create a burden on YosysHQ maintainers, so better to maintain it out of tree, kind of like how yosys is in nixpkgs right now.
Thoughts?

We have discussed this among Yosys maintainers and have come up with a plan to:

do commit the lock file into the repo
have two Nix CI jobs, one building with the version-controlled lock file and the other with the latest version of inputs
adapt the automation we already have for periodic "Bump version" commits to also update the lock file to a version it can pull from a successfully-completed CI job

Add YosysHQ/abc as a submodule

It should be a submodule. It only isn't a submodule because abc used to be version controlled in Mercurial, which (obviously) prevented that.
I once tried to convert it to a submodule but some other horrors in the Yosys Makefile caused me to waste three days on it, after which I swore I will never attempt to improve Yosys Makefile again. I wish you luck.

While it may make sense to make abc a submodule from a conceptual sense, I think this is too much of change affecting downstream users of Yosys to couple it to the work on the Nix flake.

I disagree with this reasoning. I think it should have been made a submodule years ago instead of whatever the hell it is right now. The current situation has been negatively affecting users of Yosys for long enough that it should just be fixed, and the current time is as good as any.

I suppose we shouldn't not try fixing the status quo because it is the status quo, but it seems valid not to want to couple this to another large task.

@RCoeurjoly How do you feel about converting abc to a submodule?
@povik Generally speaking yes, but it's not like we're under pressure to ship flakes ASAP.

@RCoeurjoly How do you feel about converting abc to a submodule?
@povik Generally speaking yes, but it's not like we're under pressure to ship flakes ASAP.

Yes, my strong preference would be for abc to be a submodule, because it would enable us to compile inside the devShell. Otherwise, if abc is a flake input, working inside the devShell would be very inconvenient.

Then I'd say let's make it into a submodule.

No contest here. Roland, if you want to tackle this, then please go ahead!

I think adding abc as a submodule would be best done in another PR.

Please be aware that use case where user downloads abc.tar.gz from release page and unpacks it in abc directory should also continue to work.

I've written my own shell.nix before noticing this PR. I notice some differences between it and this flake:

I only use clang stdenv, I don't explicitly get pkgs.clang, which may be why I don't need libcxx (but this may just be a shell.nix vs flake thing)
I have some extra packages bc I just copied deps from CI or docs, namely, gawk, pkg-config, boost
For show to work, I have graphviz and xdot
To build docs, I have libfaketime pdf2svg texliveFull (python3.withPackages (ps: [ps.furo ps.sphinxcontrib-bibtex]))

I have tested this with nix-shell --pure to verify it still builds yosys & docs succesfully

How do you deal with the abc dependency?
When trying to create the flake, it was decided that it was better to convert abc to a submodule.
I am working on that here https://github.com/YosysHQ/yosys/pull/4243

I didn't deal with it probably because I built it first with an impure shell which pulled in the dependency. I retried with a pure shell in a fresh checkout and it does indeed fail. I'm definitely in favor of a submodule


zcash proofs w/o icon

@keybase/react-hackers this is to support zcash. There is a temp icon hardcoded and a temp fonticon until we get assets from @cecileboucheron

@MarcoPolo this needs to be re-reviewed w/ the new font stuff


cfg_generator

Move each module to the appropriate package in openunderstand.
Remove duplicated codes and grammars.
Remove absolute paths.


Eloquent abstract Model is missing setKeyType method

Laravel Version: 5.4
PHP Version: 7.0+
Database Driver & Version: MySQL 5.7

Description:
The Eloquent Model class has various public methods to set the protected properties used to match characteristics of the underlying table, such as table name, primary key and primary key type.  Eloquent documentation states to overwrite these protected properties in classes that extends Model.  However, there are public methods provided to overwrite these values during runtime which are extremely useful if you have Eloquent Models that need to operate on multiple tables.  There is setTable and setKeyName and setIncrementing, however, there is no setKeyType method to change the primary key type.
Steps To Reproduce:
Implement a new Eloquent model and attempt to modify it's table characteristics during runtime.  setTable works, setKeyName works and setIncrement works, but working on a table that does not have a int primary key cannot be used when using setTable to point to a table without a int primary key (such as char(16) guid)

I find it odd to do that, but I personally don't have problems with adding such setters, anyways please feel free to open a PR with your proposed changes.

@themsaid The use case is absolutely in dynamic environments where you may want to use a Eloquent model which has utility methods you've written that work across multiple tables, but you want to use the same Model class to operate on them.  The fact that we have setters for the other protected properties validates this kind of use case.

Oh I see, ok let me know if u need any help submitting the PR :)

PR is in: https://github.com/laravel/framework/pull/18354  .  Can we please re-open?  I don't understand why this issue would be closed?

I copied the description into the PR: https://github.com/laravel/framework/pull/18354
Having a PR is enough, no need for a PR and an issue.


Add link to welcome or login page from 'Please log in ...'

When the logout page 'Please log in...' is not redirected properly then user has no way how to go easily away from this page.

it happens by automatic logout

Fixed


Error: The process '/usr/bin/docker' failed with exit code 1

on attempt to save the cache
Error: The process '/usr/bin/docker' failed with exit code 1
    at ExecState._setResult (/home/runner/work/_actions/satackey/action-docker-layer-caching/v0.0.8/dist/ttsc-dist/post.js/index.js:1300:25)
Error: Error: The process '/usr/bin/docker' failed with exit code 1
    at ExecState.CheckComplete (/home/runner/work/_actions/satackey/action-docker-layer-caching/v0.0.8/dist/ttsc-dist/post.js/index.js:1283:18)
    at ChildProcess.<anonymous> (/home/runner/work/_actions/satackey/action-docker-layer-caching/v0.0.8/dist/ttsc-dist/post.js/index.js:1183:27)
    at ChildProcess.emit (events.js:210:5)
    at maybeClose (internal/child_process.js:1021:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:283:5)

  builder-liquibase:
    runs-on: ubuntu-latest
    timeout-minutes: 10
    steps:
      - uses: actions/checkout@v2
        with:
          fetch-depth: 0
      - uses<EMAIL_ADDRESS>
the build appears to have no additional useful information.
It may be relevant that I'm using the cache across 2 jobs... but I'm not certain of that.

derp this has already been reported... I was mislead by the beginning of the other title

@xenoterracide what issue are you referring to?

#49


Implement fetching prow config from directories

At this point, we need to specify each prow config file explicitly in
deployment yaml. This will be a problem for adding sig-release jobs to
pefdash, since these configs are autogenerated by config forker.
With this change, we'd be able to just specify "githubConfigDir" to the
sig-release dir and perfdash will ingest all the configs from that dir.
Testing:

started perfdash locally with
githubConfigDir=path-to-sig-release-configs, verified configs are
fetched
tested that perfadash still works without providing githubConfigDir
flag

/assign @mm4tt

/lgtm
/approve
Thanks!


Support for safari 14+

^^

Related: https://github.com/abhijithvijayan/web-extension-starter/issues/49

👍 as webextension can now be loaded from safari.


Cannot read property 'options' of undefined

Hi there,
I'm using this plugin for box annotations in scatter chart and bar chart only.
I'm getting this error when I refresh the page.(refer below screenshot):

Actually I'm getting the error in this line
var a=t.annotation.options.drawTime;(refer the below screenshot)

My Dependencies:
angular 9+
ng2-charts: ^2.4.2
chart.js: ^2.9.4
chartjs-plugin-annotation: ^0.5.7
I am using minimum 3 charts in each routes.
The annotations which I used in bar chart and scatter chart are working fine. The issue is when I load a page with radar chart. But I haven't used any annotation for radar charts.
Even though I bar& scatter chart  and radar chart are in two different components, It still throws this error.
I referred this link for implementing annotations.
https://valor-software.com/ng2-charts/#/LineChart
Could you guys please look on this and let me a solution or work around for this.

I have found the solution on my own!
I have configured the chartjs-plugin-annotations globally.
By importing and assign the configuration to a variable and using it
`import * as pluginAnnotations from 'chartjs-plugin-annotation';
ChartPlugins = [pluginAnnotations];`
It works like a charm.!


Update Goss version

https://github.com/dockpack/base_git/blob/15daff15b3fce1ea19e21d6ad33f5504cf799823/molecule/default/verify.yml#L10

What is the goss test for this role?


Fixed little error in the title date

Title says 2014, but it should be 2015

Yes, happens sometime ...


auto-fix-vscode-server.description not correct type

This suddenly seems to fail with:
error: A definition for option `systemd.user.services.auto-fix-vscode-server.description' is not of type `attribute set of (boolean or signed integer or string or list of (boolean or signed integer or string))'. Definition values:
       - In `/nix/store/qymv75jbxcvvwynbklna2m6kxzxkx2bh-source': "Automatically fix the VS Code server used by the remote SSH extension"
(use '--show-trace' to show detailed location information)

I tried in on both a server with an older version of NixOS and a VM (with release 23.05) and I could not reproduce your problem. Could you give me more details? What Nixpkgs are you using? How are you using it?

I have this in my home-manager conf:
{
  imports = [
    (fetchTarball "https://github.com/msteen/nixos-vscode-server/tarball/master")
  ];

  services.vscode-server.enable = true;
  services.vscode-server.nodejsPackage = pkgs.nodejs-16_x;
}

and my system:
$ nix-shell -p nix-info --run "nix-info -m":

system: "x86_64-linux"
host os: Linux <IP_ADDRESS>-microsoft-standard-WSL2, NixOS, 22.11 (Raccoon), 22.11.4773.ea4c80b39be
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.11.1
channels(root): "nixos-22.11, nixos-unstable"
channels(nixos): "home-manager-22.11.tar.gz"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

That explains the issue. You are using the NixOS module within Home Manager, and the systemd configuration for both of them differ, as an example the description attribute in your reported error is one of the differences. To solve your issue you need to import the Home Manager module instead as described in the README. The only surprising thing is that you mention it suddenly not working anymore. It should never have worked the way you had it setup. So I am curious what caused that though. Since this should solve your problem. I am closing it for now.

thank you so much!
idk how i overlooked that 🤦


discovery node improvements - bacnet points, cli, integration test

But where does the sequential number go?  Is it just the event_no -- b/c
that's always sequential.   Do you just mean it's a periodic number
generator? (As in, 1-every-10-seconds?)
On Tue, Nov 19, 2024 at 5:57 AM Noureddine @.***> wrote:

@.**** commented on this pull request.
In misc/discoverynode/README.md
https://github.com/faucetsdn/udmi/pull/1029#discussion_r1848414505:

@@ -2,11 +2,41 @@

Notes
-vendor discovery family is a counter which increments every second
+vendor discovery family is actually sequential number generator at one second increments.
For testing. At the moment, I'm forced to have some "vendor" discovery
because that's what sequencer uses, and it makes testing a whole lot
easier, e.g. run "vendor" discovery for ten seconds, should receive ten
events [1,2,3,4,5,6,7,8,9,10], etc.
—
Reply to this email directly, view it on GitHub
https://github.com/faucetsdn/udmi/pull/1029#discussion_r1848414505, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIEPDZC2DFWDUHL4FRQ4AT2BM7VPAVCNFSM6AAAAABSCB54UGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINBVGU2TMNJRHA
.
You are receiving this because your review was requested.Message ID:
@.***>

The sequential number goes into the scan_addr field.
So, to pass sequencer tests (which typically have a scan_duration  of 10 seconds) I need ten devices in the site model with vendor addrs 1,2,...,11 respectively. It might also be occasionally flakey, but does the job.
Really its a test family I've called vendor for convenience


MAINTAINERS: Add Ismo Puustinen(ipuustin) as a REVIEWER

I'd like to invite @ipuustin as a reviewer. He had made many contributions to this project since the begining of this year and demonstrated his deep knowledge in this field.
Needs explicit LGTM from @ipuustin and 1/3 of the runwasi Committers according to https://github.com/containerd/project/blob/main/GOVERNANCE.md.

[x] @devigned
[ ] @cpuguy83
[x] @danbugs

This PR will remain open for 7 days.

LGTM! Thanks!

We got enough votes! Welcome @ipuustin !!

We got enough votes! Welcome @ipuustin !!

Thanks! :-)


RDBES: 6 new code types.

The core group requests to add 5 Code Types from FDI data call: MeshSizeRange, SupraRegion, GeographicalIndicator, ConfidentialityCode and SpecificConditionsTechnical.
I found information for all of them here:
https://datacollection.jrc.ec.europa.eu/dc/fdi
I would keep the CodeTypes as similar as possible, maybe with FDI in front.
Another request was for FisheriesManagementUnit. From Henrik I undesrtood it ws also form FDI but I cant find it. We would need to create a dummy for it until Henrik clarifies, so Ejaz and Kadji can continue the work to prepare for the data call.

Pending agreement of all RMG, we will move forward with prefix FDI- plus exact name of Code Type in FDI data call (capital letters).
Search for description in Annex of data call.
FDI-CONFIDENTIALITY, we will spell them out, YES, NO, etc, because otherwise it would be impossible to distinguish NO and NONE, which both have code N.
For the variable FisheriesMangementUnit, we will create a Code Type, invisible and with a dummy code NA. Pending further information from Henrik.

FDI-CONFIDENTIALITY was created with codes A, N, W, and V, as apparently Yes and No were not needed.
Codes for mesh size range are not invisible, Code Type is, because they were created through bulk upload and they are too many to make invisible quickly.

@HenrikK-N requests to change prefix "FDI-" to "FDI_" due to some incompatibilities in C# that would force some combersome workarounds. Will implement as I believe it is not making any difference in the CodeType.

Hi @odontaster. The Core Group request a rename of the 'Area_nonFAO' [https://github.com/ices-eg/DIG/issues/385] to 'FisheriesManagementUnit' with a description: 'A unit to determine, which stock or substock the information belongs to, when stocks are not only defined by statistical rectangles. Because new codes need to be added, which are not only area information, but also depth information for redfish and spawning time information for herring, and potentially other non-area specific codes need to be added in the future.
The following 7 new codes are requested to be added to the 'FisheriesManagementUnit':
Code                        Description
Reb.Deeper500m  	Used for beaked redfish (Sebastes mentella) caught deeper then 500 m. (deep pelagic stock > 500 m)
Reb.Shallower500m  	Used for beaked redfish (Sebastes mentella) caught shallower then 500 m. (shallow pelagic stock < 500 m)
Cod.CoastN	Used for the Norwegian costal cod caught within 12 nautical miles from the coast line north of 67°N.
Cod.CoastS	Used for the Norwegian costal cod caught within 12 nautical miles from the coast line between 62°N and 67°N.
Cod.1-2		Used for the cod in subareas 1 and 2 (not coastal)
Her.AutumnSpawner Used for autumn spawners herring
Her.SpringSpawner Used for spring spawners herring
Cheers Henrik

Hi @HenrikK-N in advance of what RMG will ask:

Given the description of the code type, should all codes already in there refer to a specific stock? https://vocab.ices.dk/?codetypeguid=d94d4dca-c8d1-40ea-8b82-ff93ae3a7dcf
In that case, maybe all codes should have a prefix for the species, or in the opposite, leave the code without a species part, but state it in the description.
Let me know, thanks

Hi @odontaster. The core group actually suggested that species code should be added in front of the existing codes and description from the former Area_nonFAO, I forgot to write that in the request above. As you remember the argument from the meeting was to clearly show data submitters, that this field is only needed for the few 'special' stocks/species. But I am not sure that is easy for the more general area units, where I know many species have used one area unit code.

The proposed 'FisheriesManagementUnit' looks like a pseudo-duplicate of ICES_Stock, and will not be implemented.
RMG suggests not to include species references in the area codes, and instead all the codes from AreaNonFAO can be linked to the respective specASFIS codes and QC-ed from the data verification unit.
Depth range is not naturally an 'area' reference. We can suggest including a NONFAO area code with more precise geographical reference, like 2127.sp or 2127.dp.
A new field for depth range can be considered for RDBES as an alternative.
For coastal area references in Norwegian sea CoastN and CoastS, we suggest the well-known codes 27.1.coastS and 27.1-2.coastN
Seasonal spawners are better identified by a stock code or timing of the sample.

RDBES core group met to review RMG comments and suggestions:

Regarding the Description of FisheriesManagementUnit, they suggest: "A unit to determine, which stock or substock the information belongs to, when stocks are not only derived from; species, ICES areas, statistical rectangles and quarter."
The core group agreed to remove the reference to species in the codes. They agreed that the way to limit their use to the correct species is by linking the codes to asfis or aphia and also clearly describing the goal of this field in the documentation.
For depth codes they suggest: Deeper500m "Caught deeper than 500 m (deep pelagic stock > 500 m), see applicable species in documentation.
Shallower500m "Caught shallower than 500 m (shallow pelagic stock < 500m), see applicable species in documentation.
For coastal cod codes: they suggest Coast12_67N "Within 12 nautical miles from the coast line north of 67°N, see applicable species in documentation. Coast12_6267N. "Within 12 nautical miles from the coast line between 62°N and 67°N, see applicable species in documentation."
For seasonal spawners: Code: AutumnSpawner. Description: Autumn spawners, see applicable species in documentation.
Code: SpringSpawner. Description: Spring spawners, see applicable species in documentation.

Hi RMG. The Core Group had an additional meeting. The group agreed to the above requests, which Adriana have written, with the following updates:
Code: Deeper500m. Description: Caught deeper than 500 m. (deep pelagic stock > 500 m), see applicable species in documentation. E.g. redfish.
Code: Shallower500m. Description: Caught shallower then 500 m. (shallow pelagic stock < 500 m, see applicable species in documentation. E.g. redfish.
Code: Coast12_67N. Description: Within 12 nautical miles from the coast line north of 67°N, see applicable species in documentation. E.g. northern Norwegian coastal cod.
Code: Coast12_6267N. Description: Within 12 nautical miles from the coast line between 62°N and 67°N, see applicable species in documentation. E.g. southern Norwegian coastal cod.
Code: NotCoast12_62N. Description: Beyond 12 nautical miles from the coast line north of 62°N. E.g. Northeast Arctic cod.
The codes AutumnSpawner and SpringSpawner are no longer requested.

The proposed 'FisheriesManagementUnit' looks like a pseudo-duplicate of ICES_Stock, and will not be implemented.

RMG suggests not to include species references in the area codes, and instead all the codes from AreaNonFAO can be linked to the respective specASFIS codes and QC-ed from the data verification unit.

Depth range is not naturally an 'area' reference. We can suggest including a NONFAO area code with more precise geographical reference, like 2127.sp or 2127.dp.

A new field for depth range can be considered for RDBES as an alternative.

For coastal area references in Norwegian sea CoastN and CoastS, we suggest the well-known codes 27.1.coastS and 27.1-2.coastN

Seasonal spawners are better identified by a stock code or timing of the sample.

Stock reporting (using existing stock codes) should be the basis; RMG will support the use of non-FAO areas with coastal and depth references; however the seasonal spawning cannot fit;

The Core Group will use the Area_nonFAO codes, and request the codes for depth range (2127.sp or 2127.dp) and coastal area (27.1.coastS and 27.1-2.coastN) to be added.


[cxx-interop] Import iterator types that are not typedef-ed

This prevented std::vector<std::string> from being auto-conformed to CxxRandomAccessCollection.
If an iterator type is templated, and does not have an explicit instantiation via a typedef or a using-decl, its specialization will not have an owning Clang module. Make sure we treat it as a part of the Clang module that owns the template decl.
rdar://112762768 / resolves https://github.com/apple/swift/issues/67410

@swift-ci please smoke test


code hygiene: using host functions instead of constructing manually

Description

closes: #XXXX
Commit Message / Changelog Entry
N/A
see the guidelines for commit messages. (view raw markdown for examples)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[x] Targeted PR against correct branch (see CONTRIBUTING.md).
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/).
[ ] Added relevant godoc comments.
[ ] Provide a commit message to be used for the changelog entry in the PR description for review.
[x] Re-reviewed Files changed in the Github PR explorer.
[ ] Review Codecov Report in the comment section below once CI passes.

Codecov Report

Merging #3219 (71245fe) into main (7a52fad) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3219   +/-   ##
=======================================
  Coverage   78.59%   78.59%
=======================================
  Files         177      177
  Lines       12415    12415
=======================================
  Hits         9758     9758
  Misses       2231     2231
  Partials      426      426

Impacted Files
Coverage Δ

modules/core/02-client/migrations/v7/store.go
68.85% <100.00%> (ø)

modules/core/02-client/simulation/decoder.go
100.00% <100.00%> (ø)

...dules/light-clients/06-solomachine/client_state.go
88.28% <100.00%> (ø)


Can't access methods.

Hello! I just pod installed and can't get access to anything from NVActivityIndicatorView except for NVActivityIndicatorViewVersionNumber. Any ideas?

@dspaces1: There is no NVActivityIndicatorViewVersionNumber. You will check with this. Meanwhile, you could try manual installation and let me know if the issue's still there.

I am also facing this issue.

@dspaces1, @ayushgoel: The issue has been fixed. Let's update to the latest version.

Thanks @ninjaprox :+1:


Follow migration of Stencil to 3/24 binaries

There is a pull request https://github.com/kylef/Stencil/pull/64

Stale issue, closing.


Template and view generation

Creating this issue to track creation of standard scaffolding for addict templates and views.
Continuing conversation from #22:
The plan is to create an addict folder in web/templates to house these 5 templates with a shared view at web/views/addict.ex. The templates would be normal forms rather than submitting via javascript.
This approach will add mix addict.gen.view_templates or something similar to #9.

As I stated previously, that's a great idea and it'll be a great base ground for implementing the other mix tasks :+1:

So after looking into this further, we're going to need at least two actions for each bit of functionality we want to support if we're going to use true forms rather than POSTing via javascript. First instance, we will need a show action to render the registration form and a create action to do the POST processing (as our controller actions do currently).
In an effort to keep a RESTful approach, what are your thoughts on following the pattern devise uses and creating multiple controllers each with corresponding show/create/etc. actions? Initially, these controllers would consist of sessions for logging in/out, registrations for registering (and possibly editing an existing account?), and passwords to manage/reset passwords.
If we went this route, we can just leverage our addict :routes helper to generate all applicable routes without burdening the user/dev. All routes would also conform to the pattern of registrations_path(@conn, :show) for rendering the appropriate view template and registrations_path(@conn, :create) for the POST paths.
Thoughts?

Very valid points raised there.
Devise is the de facto standard indeed, and separating concerns into various controllers seems to be the architecturally correct move. The only if is that it'll make overriding default behaviour a bit more verbose with the current scheme of customization we provide though.
Devs will have to create separate controllers for each of the operations they want to customize (register, passwords and session). An alternative would be to be able to specify the controllers for the actions in the Addict configuration parameters. Any idea on different approaches for this?

Hi @trestrantham, what if instead of using two actions, we define a method that returns the selected rendered that can then be overriden?
Then define a JSON renderer controller and a HTML renderer controller that extend the base, and if the user wants to still extend more, they just extend the base  controller

@trenpixster: Overriding the default behavior wouldn't be any different than how it is now done with the routes helper. The developer would only ever need to override the POST actions and they are easily done via addict :routes. We'll be generating the new/show routes via the helper as well but they wouldn't need to be overwritten from a controller perspective. Changes to the template files (web/templates/addict/x) directly would suffice there, right?
Going along with that :point_up: idea, it might not make sense to split everything up into separate controllers. The new/show routes and actions are essentially hardcoded and having the POST actions in a single place for the developer to override is valuable.
I'll try to put something tangible together and push to WIP PR so that we can better talk through what's going on here.
@jxs: I follow at a high level what you are talking about but I'm having a hard time visualizing the actual implementation. Is there any way you could throw together a quick gist to better explain your idea?

I have just read the documentation about choosing the (default render)[http://www.phoenixframework.org/v0.9.0/docs/controllers] via plug.
so @trestrantham my idea is that, if we define the default render plug on the AddictController being json, and then BaseController agnostic , changing just the functions to return conn
what do you think? i can make a gist, give me just a couple minutes

I've added some preliminary code for this feature. There's still some hardcoded cross pollination between Addict and ExampleApp currently to get the example to work. For now, only "/register" route will work for GET requests. The rest of the routes can easily be updated once :register is working as expected.
One of the issues I've been having is determining where the cutoff between package (Addict) and application (ExampleApp) occurs. We know controllers will live fully in Addict (while allowing overriding action and/or controllers by the dev) and templates will live in the host application (copied over to 1example_app/web/templates/addict` via generator).
I'm still unclear of where the view itself goes, though. I've added a stubbed view to the example app in this current example that just uses the Addict view helper, but maybe this should live in the package too?
Layouts are another issue (and are what is currently hardcoded). Although, after talking with José, the best route forward might be to add a scope macro to our routes helper that utilizes conn.private to pass in layout info:
[11:17:28]  josevalim:	addict_scope [layout: ...] do ... end
[11:17:38]  josevalim:	and you convert the scope options to private: [addict: scope_options]
...
[11:19:42]  josevalim:	just call it addict options do ... end
[11:20:24]  josevalim:	and that just expands to scope private: [addict: options] do ... end
[11:20:34]  josevalim:	and now you can access all the addict information inside conn.private.addict

Would love thoughts on this general direction thus far and also on the current items outlined above.
Cheers!

Hi @trestrantham only saw this now, sorry.
what i was suggesting, is what i did on the PR i submitted. Your pr seems nice to me, only have a couple issues,
1 - instead of Addict.AddictController imho controllers be Addict.BaseUser and Addict.User what do you think @trenpixster ?
2- why are the functions on the view in the usingmacro, instead of what was before, having them defined in the main module
cheers :)

@jxs: I commented on your PR with a :+1: and feedback on the approach.
For item 2 above, this PR changes View to be a ViewHelper and I will be adding a mix task to create an ExampleApp.AddictView in addition to the templates. This AddictView will use the helper and provide an entry point for a developer to further customize the views used in addict's templates.

@trenpixster @jxs: This should be ready for review now. I'd like to incorporate changes from #25 as a followup to work done in this branch (probably in a new PR).
This isn't perfect by any means but it could use some eyes on it now.
In my mind what's next in this or separate PRs is:

Add tests
Incorporate changes outlined in #25 specifically render_html
Refactor interactors to include one per process action (login, register, etc.)--these 'top level' interactors can call other interactors as well

Any thoughts on combining AddictController and BaseController until there's a further need to split them apart in the future?

hi @trestrantham i agree on that, haven't yet looked at the rest of the PR sorry! will soon

Hey @trestrantham, I'm really sorry for not giving feedback earlier.
I left some comments on the code, here's some more general feedback:

I agree that we could still have Addict.BaseController and Addict.Controller in the same file to bring context to whoever goes through the code.
Can you update the index.html.eex on the ExampleApp so it links to the several new routes?
Regarding refactoring interactors to include one per process action (login, register, etc.), totally agree with this, but it can be done in another branch, what do you think?
It would indeed be great to have tests in this PR :+1:

Awesome job here! 💚💛💙

Controller should be named UserController otherwise the reverse call is not going to work
$ mix phoenix.routes
 web_socket_path  GET   /phoenix           Phoenix.Transports.WebSocket.upgrade/2
 web_socket_path  POST  /phoenix           Phoenix.Transports.WebSocket.upgrade/2
 long_poller_path  GET   /phoenix/poll      Phoenix.Transports.LongPoller.poll/2
 long_poller_path  POST  /phoenix/poll      Phoenix.Transports.LongPoller.publish/2
       page_path  GET   /                  Myapp.PageController.index/2
           _path  POST  /register          Addict.Controller.register/2
           _path  POST  /login             Addict.Controller.login/2
           _path  GET   /logout            Addict.Controller.logout/2
           _path  POST  /recover_password  Addict.Controller.recover_password/2
           _path  POST  /reset_password    Addict.Controller.reset_password/2

@trestrantham can you give me access to your fork so I can give you a hand with the stuff we're missing? Thanks!

Done. Sorry for the inactivity lately! It's been a busy few weeks for me.

Cool! No problem, same thing on my side :smile:

Nice work guys! What need be done to this pull request be merged?

This would be a unique selling point compared to the other authentication libs. What is the state? What needs to be done (except a rebase)?

I haven't had time in a while to work on this but please feel free to pick up where I left off. I'd start with a rebase and bumping the Elixir and Phoenix dependencies to something recent. If those go smoothly, I'd say this would largely be ready for a merge pending any further feedback from @trenpixster.

@trestrantham I ended up doing a major refactor and implemented a version of this via #68. Thank you so much for all the hard work, I drank quite a bit from this, would love to have you take a look on how it is now :green_heart: Closing this for now!

Your refactor looks great. Glad this made it in!

On Apr 6, 2016, at 5:31 PM, Nizar Venturini<EMAIL_ADDRESS>wrote:
@trestrantham I ended up doing a major refactor and implemented a version of this via #68. Thank you so much for all the hard work, I drank quite a bit from this, would love to have you take a look on how it is now  Closing this for now!
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub


Multi-pass Winograd failed with gfx90a

Currently multi-pass winograd solvers do not work with gfx90a

@Kirpich30000 Please have a look here.

Too vague description.


Cannot import content script

I made a content script src/scripts/content-script.ts:
import { hello } from "./content-script-2";
console.log(hello());
console.log("Hello from content script");

src/scripts/content-script-2.ts
export function hello() {
  return "Hello World";
}

When I open the web page listed in the matches, I get:
Uncaught SyntaxError: Cannot use import statement outside a module

For some reason, I cannot import it even after listing dist/scripts/content-script-2.js in web_accessible_resources

Yes, good point. It's not easy to do as the content-scripts in the manifest are not loaded as js modules.
A workaround would be like in the following gist.
But with this Gist, I think you can structure the app how you like it and use import/exports.
I think I could add something to the snowpack-plugin so it is easier to use/setup but I'm not sure how.
Maybe I'll create the injection script and add it to the project as a utility script. Then the user can remove it from the manifest.json to disable it if there is no content script needed.

Yes, good point. It's not easy to do as the content-scripts in the manifest are not loaded as js modules.
A workaround would be like in the following gist.
But with this Gist, I think you can structure the app how you like it and use import/exports.
I think I could add something to the snowpack-plugin so it is easier to use/setup but I'm not sure how.
Maybe I'll create the injection script and add it to the project as a utility script. Then the user can remove it from the manifest.json to disable it if there is no content script needed.

You can take a note of Rollup's Chrome extension plugin which supports such functionality, at least in Chrome
For Firefox, sadly, a different workaround is needed, perhaps using IIFE directly

You can take a note of Rollup's Chrome extension plugin which supports such functionality, at least in Chrome
For Firefox, sadly, a different workaround is needed, perhaps using IIFE directly

I've been successfully serving my content.js script for the past week+, and just today I noticed that I have a new error, the same as mentioned in the beginning of this Issue by @avi12.


Replacing MAINTAINERS with .DEREK.yml for more granular permissions

Signed-off-by: rgee0<EMAIL_ADDRESS>Migrating to MAINTAINERS to the new model.  Not sure if Derek is gainfully employed on this repo yet but the changes enable anyone forking the repo to more readily understand how to configure this part of the application.
Also added rgee0 and johnmccabe to the maintainers list to be consistent with README.md

Derek close: changes already in place


Generate include file -> prompt, not temp

'Generate' button on target for target include file should prompt user for a path rather than put it in temp directory.

Repeated with #206, the other has more details closing this one.


Reduce unnecessary duplication on HTTPHeader by storing Index reference to original header data.

LGTM. Any other comments?

I don't care too much, but isn't that an unnecessary complication? The values backing the strings are already shared w/ that CoW stuff, right? There is no 'unnecessary duplication' in the previous version.

@helje5 That's right. The actual storage behind the buffer were never copied until mutation happen. But Int is still a one word struct vs String a 3 word struct. So it comes down to if we want to optimize storage overhead or computation overhead.

It doesn't some down to that. It comes down to whether you want to complicate the code for small efficiency gains.
In case efficiency is the goal, I would still recommend to not parse the full header into Swift crap, but only do so on demand. I.e. the storage would be a byte buffer, the C parser would generate pointers into that, and Strings and such super high level objects would only be created if actually requested.
While I'm all in for doing any shenanigans in the implementation, the gains of this particular PR are very little IMO. If you enter Swift String/Dict/Array, all efficiency is essentially lost in the first place and such micro optimisations are just weird. Rather have Swift deal with making String/Dict/Array better if you play at that level (i.e. CoW on strings).

P.S.: Oh, and my opinion is still that header keys and maybe even values should be an enum too (not an actual enum but Int consts to provide extensibility, but well). I like the idea of parsing values of known header (e.g. why store content-length as a String, that is neither, efficient nor type safe).

Closing based on the discussion - we can always revisit in the future.


prop-types package not included in dependencies

as per Migrating from React.PropTypes  propTypes needs to be explicitly imported from 'prop-types' package. Latter is implemented, however prop-types package is missing from package.json dependencies.

Ah, good catch! I've updated this repo accordingly, but I'll leave this open until I:

Patch the relevant course video
Update the course demo that's published under "exercise files".

Thanks!

Resolved.


unreachable code in components: get_parameter()

The code beyond Line 139 is uncerable due to a pair return and exception throwing statements above

It has been resolved by an earlier commit.


🐛 MediaPage within the example app doesn't load on iOS

What's happening?
Thanks for the great library 👏 I've been trying to build something similar to your MediaPage within the example app but found I can't get the video from the recording to load. I haven't gotten to the bottom of this yet... so I wanted to use your example App to see how you got your MediaPage to work. However, there seems to be a bug that the MediaPage doesn't load correctly after recording a video.
Repo steps -

Boot on a real iOS device (in my case an iPhone 15).

Record a video (any duration seems to be fine)

See it gets stuck on the camera page

See there is a console log for Video loaded from the MediaPage but still see the Camera page

Photos on iOS and Android work great

Video actually works on Android

Obviously, it is not a critical thing to the library but I was hoping it would help me figure out why I can't load a file:/// in either Expo AV or react native video.
Reproduceable Code
Just using the example App with no code changes

Relevant log output
LOG  calling startRecording()...
 LOG  called startRecording()!
 DEBUG  state: ACTIVE
 DEBUG  state: END
 LOG  calling stopRecording()...
 LOG  called stopRecording()!
 LOG  Recording successfully finished! file:///private/var/mobile/Containers/Data/Application/413550AA-0793-42F4-A3A2-A432A22212AF/tmp/ReactNative/CCAB62AE-6CE6-4358-A925-8448CCB8E161.mov
 LOG  Media captured! {"path":"file:///private/var/mobile/Containers/Data/Application/413550AA-0793-42F4-A3A2-A432A22212AF/tmp/ReactNative/CCAB62AE-6CE6-4358-A925-8448CCB8E161.mov","duration":1.016757584}

Camera Device
{
  "hardwareLevel": "full",
  "isMultiCam": false,
  "hasTorch": true,
  "sensorOrientation": "landscape-right",
  "supportsLowLightBoost": false,
  "hasFlash": true,
  "name": "Back Camera",
  "minZoom": 1,
  "id": "com.apple.avfoundation.avcapturedevice.built-in_video:0",
  "maxZoom": 129.125,
  "physicalDevices": [
    "wide-angle-camera"
  ],
  "neutralZoom": 1,
  "supportsFocus": true,
  "supportsRawCapture": false,
  "position": "back"
}

Device
iPhone 15 (iOS 17.0.2)
VisionCamera Version
3.6.9
Can you reproduce this issue in the VisionCamera Example app?
Yes, I can reproduce the same issue in the Example app here
Additional information

[ ] I am using Expo
[ ] I have enabled Frame Processors (react-native-worklets-core)
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar issues in this repository and found none.

Hey! I think this has already been fixed. If not, feel free to re-open :)


Set ExistentialDeposits to non-zero values

Currently no accounts are reaped because the ED is zero for all currencies, see this comment.

Related https://github.com/paritytech/substrate/pull/12951

What is the plan for this? The only viable option I see to reap accounts is if all currencies we support (Token, ForeignAsset, LendToken, LpToken, and StableLpToken) are considered to be sufficient currencies?