Method setPosition() unstable

Hi, @alexmercerind
Thanks for the plugin, it is simple, but decent and worked well.
I find that when the duration in setPosition() is longer more than like 20 mins or tap fast forward many times in short time, the plugin will crash.
Also change position take too long time and have some noisy sound.

Hello @stonega!
I'm literally 0% sure about the cause of the bug because I have used @mackron's miniaudio in this project, and made a very simple implementation over it.
I have to see what can I do.

@stonega this may be fixed with the latest version of miniaudio --(https://github.com/mackron/miniaudio/blob/master/miniaudio.h
Can you try dropping that into your pub cache folder for this library?
Windows path -- User\AppData\Roaming\Pub\Cache\hosted\pub.dartlang.org\flutter_audio_desktop-0.0.8\audioplayer

@MichealReed I tested with the latest version, looks like the issue is still there. Thanks for your reply!

@MichealReed I tested with the latest version, looks like the issue is still there. Thanks for your reply!

Hi there @stonega !
The issue is fixed in the vnext branch.
Now, no longer whole file will be loaded into memoery, but in segments (as a stream).
I'll inform you real soon, once I get it working on Windows (will be very easy to do, as Linux implementation is already done).
Thankyou.

Glad to hear that, can not wait to have a test. I have switched to use
Linux these days😉
On Sat, Feb 27, 2021, 20:54 Hitesh Kumar Saini<EMAIL_ADDRESS>wrote:

Hi there @stonega https://github.com/stonega !
The issue is fixed in the vnext
https://github.com/alexmercerind/flutter_audio_desktop/tree/vnext
branch.
Now, no longer whole file will be loaded into memoery, but in segments (as
a stream).
I'll inform you real soon, once I get it working on Windows (will be very
easy to do, as Linux implementation is already done).
Thankyou.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/alexmercerind/flutter_audio_desktop/issues/4#issuecomment-787068553,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AARIH57QD7GH6LSPUWO4C3DTBDTQBANCNFSM4S4GD57A
.

Hi there @stonega !
May you try out the plugin now on Windows or Linux?
Try running example.
There are few API changes.
I'm yet to implement playlists or queues, should be pure Dart side code.


Wrong order on planets position

Good afternoon,
I realized that now this is the right place to report bugs - even if previous - from the previous astrochart repo.
The routines are working great, but I found a small bug. If you look at the chart I send attached, at the red zone, you see that the planets are in the right place but in a litle bit "messy order". For instance, Saturn should be in Neptune's place - the line would be direct and closer and they wouldn't cross each other.
At the time, I changed the collision radius. But it solved one of them. Not all.
I think the question is the order in degrees. Let's say that Mars and Jupiter are respectively in 15 and 10 Taurus. In the routine, Jupiter should be runned first because its longitude is less than Mars, even if in the array is in second, for example.
Has this problem been aproached? If yes, in which line/routine?
Best regards,
Kepler

Good afternoon,
I realized that now this is the right place to report bugs - even if previous - from the previous astrochart repo.
The routines are working great, but I found a small bug. If you look at the chart I send attached, at the red zone, you see that the planets are in the right place but in a litle bit "messy order". For instance, Saturn should be in Neptune's place - the line would be direct and closer and they wouldn't cross each other.
At the time, I changed the collision radius. But it solved one of them. Not all.
I think the question is the order in degrees. Let's say that Mars and Jupiter are respectively in 15 and 10 Taurus. In the routine, Jupiter should be runned first because its longitude is less than Mars, even if in the array is in second, for example.
Has this problem been aproached? If yes, in which line/routine?
Best regards,
Kepler

Hi! Did you find any workaround?

Hi! Did you find any workaround?

Hey @cptolemy ,
This is a known bug, but I don't have time yet to work on it.
Seems that is some cases the collision radius works, but as you mentioned not all the cases are covered.
I will try to take a look in the next week, I have some other cases that this happen also.

Hi!
I made some changes, and here worked for the cases that I have.
I still need to add more tests, but if you want to test, you can use this version

Good afternoon afucher
I am very sorry for the late reply.
Thank you very much - I will test it. Could you please indicate to me what exactly did you changed or added (what routine and/or lines) regarding the original, please?
Regards,
CPtolemy

Sure, you can check the changes here, most of the part was in the placePointsInCollision function.

@cptolemy I made more tests locally and seems that is all good. I merged the solution, but feel free to reopen the issue if you find any error.

Good afternoon afucher,
Thank you very much. It seems to be working very well.
But I will input some more pretty complicated cases when I have the time :)
However, I have the feeling that is solved - the code makes 100% sense. Congratulations.
Regards, and many thanks,
CPtolemy


⚠ Bofrost.es has degraded performance

In 414e1fd, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1743 ms

Resolved: Bofrost.es performance has improved in 071a299 after 6 minutes.


Add Problem # to folder's name

Hi @QasimWani !
I have been manually adding every LeetCode question that I solve. It's easy to follow and search questions if the number is also included in the folder name. I have also attached how I store the questions. I use 4 digits for question number so that files remain sorted. The same thing can be done here on the folder's names.

thanks for bringing this up @varadbhogayata . this has been requested multiple times before. i'm busy af this summer and won't have time for feature updates until late Aug. I can, however, review your PR and merge it if u want to contribute this feature.


"Needs lots [of] improvement"

I found a D!!
The message is Needs lots improvement .. I think it should be  Needs lots _of_ improvement

Thanks, nice catch. Fixed the typo


Explicit capability statements dont play nice with inference

If the user writes an explicit program with inconsistent capabilities, the type checker will not catch the misuse. For example, the following program type checks:
read a[1] as a1;
let x = a1;
a1 = 10;

This is because a1 is not given a linear type and is therefore not consumed by the read.

Subsumed in #46.


Add code coverage

Run the GitHub action with the coverage profile
to generate a code coverage report in target/site/jacoco and associate it to the GH Action runs

Workflow is not ideal. You have to click on the GitHub action run, then Summary. At the bottom of the page, there is a jacoco artifact (which is a zip file) that will be downloaded in your local machine so that you can open the index.html in the unzipped directory.


Removed doubled note in support table concerning HTTP/2

As the title says, in this commit I removed the doubled note in support table concerning HTTP/2.

Sorry about those accidents, the data comparing code sometimes doesn't do very well when there's a large amount of changes. Made sure all your corrections got in now though. Thanks!


refs are still typed as a tuple

This is probably something thats not updated since ReScript is now compiling records to JS objects.

Indeed. Good catch!

Indeed. Good catch!

Fixed in release v3.42.0.

Fixed in release v3.42.0.

Wow! Thanks!

Wow! Thanks!


TRY EXCEPT FINALLY from 5.0

Robot Framework 5.0 introduce new syntax: TRY EXCEPT blocks. We need to handle them.
Things to consider:

Other rules should be able to access TRY, EXCEPT, FINALLY, ELSE blocks. (#574)
Warn when trying to use this syntax as keyword name (Try, Except, finally..) (#570).
Special rules?
Parsing errors - multiple FINALLY, EXCEPT blocks, wrong order (EXCEPT -> TRY, TRY -> FINALLY -> EXCEPT)

I will take care of 2)

Regarding 1. I'm going over the rules and updating the test. Updated so far:

missing-space-after-comment

@bhirsz Do we still need to do something here? I see that points 1, 2 and 4 are completed.
Regarding point 3 - do you have any ideas for new rules related to TRY EXCEPT FINALLY?
If yes, let's create a separate issue for that. If not, let's close this ticket.

Robot Framework itself should catch various issues like double Else branch etc. But we would need to test it and include it at least as a parsing error test. For now I don't have aby ideas for the rules - if we came up with something we can create issue and for now we can close this one.

Ok, closing this one.
I will instead add an issue for reviewing all Robot Framework parsing errors, because there could appear some more we did not include, when we were adding them on our side last time.


Intercepting network request causing InterruptedException when using RxJava approach

Hey guys,
I'm facing java.lang.InterruptedException
Crash stack trace - ExceptionStacktrace.txt
I'm making a network request using RxJava on one of my app's screen (show details fragment for example)
val subscription = interactor.getData(requestDetails)                 .subscribeOn(Schedulers.io())                 .observeOn(AndroidSchedulers.mainThread())                 .subscribe(.......) compositeSubscriptions.add(subscription)
I allow user user to leave that screen immediately after entering it.
When user leaves fragment I'm clearing all my subscriptions:
    override fun onDestroy() {         compositeSubscriptions.clear()         ....     }
Sometimes user may leave the screen while network request is still being intercepted and it may force InterruptedException (Parent job is Cancelling).
Inside hasValidSignedCertificateTimestamp(....) you are launching a new coroutine and block current thread.
val result = runBlocking {             logListDataSource.get()         }
There is a small chance not to finish coroutine job until the thread where coroutine was run on, was dismissed.
Are you aware about this issue or is there any work-around for this?
Did you consider about getting rid of runBlocking {...} block? If you're not providing any context it will get run on the mainThread?

I'm not sure that CoroutineExceptionHandler is gonna solve the issue.
`val handler = CoroutineExceptionHandler { _, _ ->
logger?.log(host, VerificationResult.Failure.LogServersFailed(NoLogServers))
}
    val result = runBlocking(handler + Dispatchers.IO) {
        logListDataSource.get()
    }`

but surrounding runBlocking{...} block with try/catch may help:
val result = try {             runBlocking {                 logListDataSource.get()             }         } catch (e: Exception) {             null         }


[BUG REPORT] - When I press my keybinds. it crashes.

When I press my keybinds. it crashes.

we’re gonna need more info then just saying, they crash

are there any debug logs you can provide us?

frick.

—__—


Is there a gpt2-xl variant for DialoGPT?

Hi!
I have been using both gpt2-xl as well as DialoGPT with great results so far, thanks for making it available.
Question: is there a DialoGPT XL variant? As it appears only medium and large are in the transformers library.
TIA!

Thanks for your interest. Unfortunately, we don't have any plan releasing a larger model than the existing ones. Sorry about that.


updateing liveness probe for glitchtip beat deployment.

What:

Fixing Glitchtip liveness probes https://issues.redhat.com/browse/CSSRE-2058
Why:

Tickets:

Validation:

Dependency

/LGTM


Feature/php doc commentaries

I corrected method commentaries in my code to be more phpDoc-ish.
Can be merged without closer attention.

good job!


OST blue

I snitched the code from this file for this and noticed that DarkBlue and Blue have the same values, which is not correct, right?
https://github.com/HBadertscher/OSTPresentation/blob/056d90a88323b268c48851d7a97f7b3ea7ca8c49/header/OSTColors.sty#L29
https://github.com/HBadertscher/OSTPresentation/blob/056d90a88323b268c48851d7a97f7b3ea7ca8c49/header/OSTColors.sty#L38

Thanks for reporting - you are right of course. I corrected the color.
Side note: in the mean time, the marketing department has changed some colors slightly and added other colors in the official CI. I will update this in a separate commit later.
One more note: here, only the RGB colors are defined - which is fine for slides that are only viewed on a screen. For printing (e.g. a report), using the CMYK-colors is a lot better, as the difference between CMYK and RGB is quite noticable when printing.


Currently the write function lives inside SessionHandle, this is partly awkward as we are throwing the transport instance all over the place.
https://github.com/Foxboron/HyREPL/blob/master/HyREPL/session.py#L40

SessionHandler was removed


adding iOS support for accessibilityLiveRegion

Summary
fixes https://github.com/facebook/react-native/issues/34735.  https://github.com/fabriziobertoglio1987/react-native/pull/5 is an alternative (draft) solution.
The below features will be added in separate PRs:

support for accessibilityValue with accessibilityLiveRegion
over-riding accessibilityLiveRegion in child component https://github.com/facebook/react-native/pull/35432/files#r1041020412

Changelog
[iOS] [Added] - adding iOS support for accessibilityLiveRegion
Test Plan

accessibilityLiveRegion polite => announces after other announcements (queued)
accessibilityLiveRegion assertive => interrupts announcements

https://github.com/facebook/react-native/pull/35432#issuecomment-1335884181
https://github.com/facebook/react-native/pull/35432#issuecomment-1335887071
https://github.com/facebook/react-native/pull/35432#issuecomment-1334331158

Hello I have a question anybody I can speak to

Ok

https://github.com/fabriziobertoglio1987/react-native/blob/a7cc3f9fe7920060a400b9d1ddbef0e1be4011ca/ReactCommon/react/renderer/textlayoutmanager/platform/ios/RCTAttributedTextUtils.mm#L462-L464

The functionality works with https://github.com/fabriziobertoglio1987/react-native/commit/ed4c0a1c83b57e4e147ab2835a7648f10b469412

iOS - testing count change Text component with accessibilityLiveRegion

https://user-images.githubusercontent.com/24992535/205147995-7eecc9e0-dc22-426a-ae5f-48173cefa1fd.mp4

iOS - View changes state/hint

https://user-images.githubusercontent.com/24992535/205149406-f2d9d85b-78c4-4cfa-84fd-8fa2c6c5ea18.mp4

https://github.com/facebook/react-native/blob/8c9ee237cd9b1da86eb19bb7dd4da27be0c9aafe/packages/rn-tester/js/examples/Accessibility/AccessibilityExample.js#L1443-L1477
iOS - parent View has accessibilityLiveRegion set to polite and children announces change in accessibilityState

https://user-images.githubusercontent.com/24992535/205396672-d175bf46-6d43-4423-8aeb-5a74df75b0f4.mp4

iOS - text component with accLiveRegion props.children change (triggered from another component)

https://user-images.githubusercontent.com/24992535/205396807-fb7c1f59-a805-4787-ade8-177f7321f0f3.mp4

iOS - navigating out and back (rerender the entire rootView) does not trigger duplicated announcements

fixed with commit https://github.com/fabriziobertoglio1987/react-native/commit/6171f4bfbe1b9bebebd9c75debfc3927e2b85d8d

P
type
task

4
bug
Parent accessibilityLiveRegion should not over-ride child live region

4.1
refactor
Check diff between the old and the newViewProps field accessibilityProps. Update the value of self.accessibilityLiveRegionAnnouncement.

4.2
refactor
Check diff between the old and the newViewProps accessibilityProps and update self.accessibilityPoliteAnnouncement to “none” “polite” or “assertive”. The accLiveRegionEnabled over-rides childAccLiveRegEnabled in self.accessibilityPoliteAnnouncement.

P
type
task

6
bug
handle nil value of new props (link). Solution: nil value is already converted by cpp to @“none”.

7
bug
Use an array newAccessibilityLiveRegionAnnouncement [“accessibilityState”,“accessibilityLabel”, “accessibilityHint”] to respect correct order in the announcement. The correct order is state, label, role, hint.

7.1
task
STEP 1 - Save new accessibility props in array [“accessibilityState”,“accessibilityLabel”, “accessibilityHint”]

7.2
task
STEP 2 - Generate the new accessibilityLiveRegionAnnouncement using concatenate. array.concat(“ “)

7.4
task
STEP 4 - Add check on accessibility prop type before adding it. For ex. Prop is nil

7.5
task
STEP 5 - Avoid changing value of self.accessibilityLiveRegionAnnouncement using reference to another variable

Tasks with hyperlink

P	type	task
6	bug	"handle nil value of new props (link).
Solution: nil value is already converted by cpp to @“none”."
7	bug	Use an array newAccessibilityLiveRegionAnnouncement [“accessibilityState”,“accessibilityLabel”, “accessibilityHint”] to respect correct order in the announcement. The correct order is state, label, role, hint.
7.1	task	STEP 1 - Save new accessibility props in array [“accessibilityState”,“accessibilityLabel”, “accessibilityHint”]
7.2	task	STEP 2 - Generate the new accessibilityLiveRegionAnnouncement using concatenate. array.concat(“ “)
7.4	task	STEP 4 - Add check on accessibility prop type before adding it. For ex. Prop is nil
7.5	task	STEP 5 - Avoid changing value of self.accessibilityLiveRegionAnnouncement using reference to another variable

P
type
task

9
bug
Use copy instead of reference (link). Verify if solution is solved by using copy instead of readywrite (stackoverflow).

10
bug
Trigger announcement if child or parent prop accLiveRegion is enabled (link1, link2, link3)

Tasks with hyperlink

P	type	task
9	bug	Use copy instead of reference (link). Verify if solution is solved by using copy instead of readywrite (stackoverflow).
10	bug	Trigger announcement if child or parent prop accLiveRegion is enabled (link1, link2, link3)

P
type
task

21
review
Think about Edge Cases that could break the application

22
doc
Update documentation (link)

Tasks with hyperlink

P	type	task
21	review	Think about Edge Cases that could break the application
22	doc	Update documentation (link)

P
type
task

1
bug
Support for accessibilityValue with accessibilityLiveRegion

P
type
task

2
bug
Text, Slider component will default with accessibilityLiveRegion != “none” and randomly announce changes in their accessibility attributes. It could be related to prop aria-liveregion which does not pass the correct default. Changing self.accessibilityLabel to  RCTNSAttributedStringFromAttributedString(data.attributedString).string in RCTParagraphComponentView causes all component to announce on change. Adding prop accLiveRegion to all text component seems to fix the issue.

P
type
task

5
refactor
Move the logic from RCTParagraph updateState to RCTParagraphCompAccProvi accessibilityElement

5.1
task
Verify accessibilityElement method is triggered when text props.children changes while VoiceOver is focused on another element

5.2
task
Move accessibility announcement to RCTParagraph accessibilityElements

Tasks with hyperlink

P	type	task
5	refactor	Move the logic from RCTParagraph updateState to RCTParagraphCompAccProvi accessibilityElement
5.1	task	Verify accessibilityElement method is triggered when text props.children changes while VoiceOver is focused on another element
5.2	task	Move accessibility announcement to RCTParagraph accessibilityElements

P
type
task

6
review
Verify order of announcement for accessibilityValue (add accValue to any component and verify the order).

7
bug
Append accessibilityState checked and other field to accessibilityValue

1
bug
Trigger VoiceOver announcement when adding children (for ex. chatroom)The implementation updates the subview accessibilityLiveRegionAnnouncementType only when accessibilityLiveRegion changes.

1.1
task
Create a test case and reproduce the scenario

1.2
task
Find method triggered when a new children is mounted on a RCTViewComponentView (for ex. mountChildComponentView)

1.3
task
Update subview.accessibilityLiveRegionAnnouncementType

1	bug	"Trigger VoiceOver announcement when adding children (for ex. chatroom)
The implementation updates the subview accessibilityLiveRegionAnnouncementType only when accessibilityLiveRegion changes."
1.1	task	Create a test case and reproduce the scenario
1.2	task	Find method triggered when a new children is mounted on a RCTViewComponentView (for ex. mountChildComponentView)
1.3	task	Update subview.accessibilityLiveRegionAnnouncementType

P
type
task

1
bug
Trigger VoiceOver announcement when adding children (for ex. chatroom)The implementation updates the subview accessibilityLiveRegionAnnouncementType only when accessibilityLiveRegion changes.

1.1
task
Create a test case and reproduce the scenario

1.2
task
Find method triggered when a new children is mounted on a RCTViewComponentView (for ex. mountChildComponentView)

1.3
task
Update subview.accessibilityLiveRegionAnnouncementType

P	type	task
1	bug	"Trigger VoiceOver announcement when adding children (for ex. chatroom)
The implementation updates the subview accessibilityLiveRegionAnnouncementType only when accessibilityLiveRegion changes."
1.1	task	Create a test case and reproduce the scenario
1.2	task	Find method triggered when a new children is mounted on a RCTViewComponentView (for ex. mountChildComponentView)
1.3	task	Update subview.accessibilityLiveRegionAnnouncementType

P
type
task

2
bug
mountChildComponentView is called after updateProps. This may cause new appended view to not announce accessibility hint.

2.1
task
Change the props with the new accessibilityLiveRegionValue in mountChildComponentViewSolution RCTMountingManager Insert will add the view to the page and perform the following tasks in the order: updateProps, finalizeUpdates and mountChildComponentView. For this reason when we search for the view.superView in updateProps, the view is not mounted yet and does not have a parent, but I was not able to modify the props in RCTMountingManager

2.4
task
Retrieve the parent with a loop. Currently superview allways returns nil.Not possible, the view not yet mounted.

2.5
task
Find the logic that triggers RCTPerformMountInstructions in RCTMountingManager and understand how to save the accessibilityLiveRegion from the parent. Use the Debug callstack.DONE, but not possible to update props and trigger this change. Probably we need to move the logic to the right callback when the information are available.

2.6
task
mountChildComponentView does not have old/new props for doing diffing and triggering the announcement

2.7
task
updateProps does not have the parent accessibilityLiveRegion required to trigger the announcement. SOLUTION: adding to the child accessibilityLiveRegionType the value from the parent in RCTMountingManager Insert before to calling updateProps.

P
type
task

1
bug
Children added to parent with accessibilityLiveRegion set will not announce text (link). The solution of modifying RCTMountingManager may not be correct: 1) Props should not be modified on iOS 2) No existing pattern of setting instance variable to change UI behavior of child 3) Requires to change type of parentShadowView. It’s used by all the react-native component

1.1
task
Research discord about cloneElement.

1.2
task
Read about React.cloneElement (performance impact and best practices) (stack1, advanced composition, search)

1.4
task
Add accLiveRegion to children.props in View.js (stackoverflow) using React.cloneElement. Verify for regressions on Android (do not implement logic on android).

1.41
task
Copy TextAnchestor and hasTextAncestor as hasLiveRegion and implement logic to announce Text components (link) without using instance variable.

1.42
task
Search for .Provider in react-native and decide which Provider to use to pass accessibilityLiveRegion to children

1.43
task
Refactor logic to use it with all component

1.5
task
Review diff

P	type	task
1	bug	"Children added to parent with accessibilityLiveRegion set will not announce text (link). The solution of modifying RCTMountingManager may not be correct:

Props should not be modified on iOS
No existing pattern of setting instance variable to change UI behavior of child
Requires to change type of parentShadowView. It’s used by all the react-native component "
1.1	task	Research discord about cloneElement.
1.2	task	Read about React.cloneElement (performance impact and best practices) (stack1, advanced composition, search)
1.4	task	Add accLiveRegion to children.props in View.js (stackoverflow) using React.cloneElement. Verify for regressions on Android (do not implement logic on android).
1.41	task	Copy TextAnchestor and hasTextAncestor as hasLiveRegion and implement logic to announce Text components (link) without using instance variable.
1.42	task	Search for .Provider in react-native and decide which Provider to use to pass accessibilityLiveRegion to children
1.43	task	Refactor logic to use it with all component
1.5	task	Review diff

P
type
task

3
refactor
Minor refactoring duplicated objc logic

3.1
task
Create a method sendAccessibilityAnnouncement in RCTViewComponentView

3.2
task
RCTView and RCTParagraph trigger announcement by calling sendAccAnnouncement

P
type
task

2
refactor
Minor refactoring duplicated objc logic

2.1
task
Create a method sendAccessibilityAnnouncement in RCTViewComponentView

2.2
task
RCTView and RCTParagraph trigger announcement by calling sendAccAnnouncement

P
type
task

3
bug
Verify issue with checked and unchecked. The expected behaviour, if accState is null no announcement should trigger

3.1
task
Announced unchecked but I believe should announce checked because it is true

3.2
task
Verify if finalizeUpdate includes the updated value of self.accessibilityValue

3.3
task
RCTView updateProps sets a boolean variable triggerLiveRegionAccessibilityAnnouncement

3.4
task
RCTView finalizeUpdate announces self.accessibilityLabel, self.accessibilityValue and other accessibility attributes

3.5
task
RCTView sendAccessibilityEventWithOptions composes accessibilityLabel, Hint, State and Value to generate a new announcement

3.6
task
Remove logic from RCTView updateProps that generates accessibilityAnnouncement

3.61
task
Avoid announcing null. Create an empty string and add the accessibility field only if not nil (if statements);

P
type
task

4
bug
Text changes are not announced after last refactor. Adapt logic in RCTParagraphComponent updateState to use RCTView finalizeUpdate logic.

P
type
task

1
bug
Text does not announce other changes (for ex. accessibilityState). Over-rides parent logic (GitHub comment). The text does not change, but triggerLiveRegionAccessibilityAnnouncement is set to YES and the announcement triggers with announcement self.accessibilityLabel.- Even if the text does not change, the change in accessibilityLabel is triggered in super RCTView

1.1
task
Call super finalizeUpdates before triggering the announcement

1.2
task
Remove logic from RCTParagraph finalizeUpdates and verify announcement.

1.3
task
Verify if the change in the disabled accessibilityState triggers RCTParagraph #updateState. There is no change in text and updateState should not trigger.

1.4
task
Trigger change in View accessibilityLabel and verify if accessibilityHint or accessibilityDisabled are announcedHypothesis: Previously experienced issues with accessibilityLabel over-riding all other announcement, could be connected to RCTRecursiveAccessibilityLabel or other logic, but it is not specific to Text component. Reproduces also with a plain View.Result: Was not possible to reproduce the issue with a plain View. Text will announce accessibilityHint, but not changes to accessibilityState. The issue seems to be with UIAccessibilityTraitNotEnabled trait and Text iOS API.

1.5
task
Reproduce issue with accessibilityState disabled on iOS Text component without using accessibilityLiveRegion.

1.6
task
Debug RCTView #finalizeUpdates and understand why self.accessibilityTraits is not equal to UIAccessibilityTraitNotEnabled. Verify the value of self.accessibilityTraits and that it was previously set to NotEnabled.Solution: RCTParagraph over-rides accessibilityTraits (commit) over-rides and returns UIAccessibilityTraitStaticText (documentation). Removing the method fixes the issue. Additionally finalizeUpdates needs to be removed.

1.7
task
Re-implement self.accessibilityTraits in RCTParagraph to return selected/disabled from RCTView parent

1.8
task
Rewrite RCTParagraph finalizeUpdates to avoid over-riding parent announcement

Tasks with hyperlink

P	type	task
1	bug	"Text does not announce other changes (for ex. accessibilityState). Over-rides parent logic (GitHub comment). The text does not change, but triggerLiveRegionAccessibilityAnnouncement is set to YES and the announcement triggers with announcement self.accessibilityLabel.
Even if the text does not change, the change in accessibilityLabel is triggered in super RCTView"
1.1	task	Call super finalizeUpdates before triggering the announcement
1.2	task	Remove logic from RCTParagraph finalizeUpdates and verify announcement.
1.3	task	Verify if the change in the disabled accessibilityState triggers RCTParagraph #updateState. There is no change in text and updateState should not trigger.
1.4	task	"Trigger change in View accessibilityLabel and verify if accessibilityHint or accessibilityDisabled are announced
Hypothesis: Previously experienced issues with accessibilityLabel over-riding all other announcement, could be connected to RCTRecursiveAccessibilityLabel or other logic, but it is not specific to Text component. Reproduces also with a plain View.
Result: Was not possible to reproduce the issue with a plain View. Text will announce accessibilityHint, but not changes to accessibilityState. The issue seems to be with UIAccessibilityTraitNotEnabled trait and Text iOS API."
1.5	task	Reproduce issue with accessibilityState disabled on iOS Text component without using accessibilityLiveRegion.
1.6	task	"Debug RCTView #finalizeUpdates and understand why self.accessibilityTraits is not equal to UIAccessibilityTraitNotEnabled. Verify the value of self.accessibilityTraits and that it was previously set to NotEnabled.
Solution: RCTParagraph over-rides accessibilityTraits (commit) over-rides and returns UIAccessibilityTraitStaticText (documentation). Removing the method fixes the issue. Additionally finalizeUpdates needs to be removed."
1.7	task	Re-implement self.accessibilityTraits in RCTParagraph to return selected/disabled from RCTView parent
1.8	task	Rewrite RCTParagraph finalizeUpdates to avoid over-riding parent announcement

P
type
task

2
bug
remove space announcement

3
bug
Test two level of nesting. Two child views (Text and View component) inside a parent View with accessibilityLiveRegion polite. Result: Both view announce their changes in accessibility state.

P
type
task

4
review
Test android (in particular changes to accessibiliyLiveRegion in JS)

https://user-images.githubusercontent.com/24992535/207097441-dc42bd0c-5138-4ef6-a28b-c5eece70d41f.mp4
https://user-images.githubusercontent.com/24992535/207097463-a79438ee-3d53-4b82-8870-6e845a9353f8.mp4
https://user-images.githubusercontent.com/24992535/207098541-bdea6202-8787-4c98-91f3-3441387921ea.mp4
https://user-images.githubusercontent.com/24992535/207098459-1391809b-e32e-4796-8154-c37ec5651de2.mp4

Nested text does not support accessibilityLiveRegion on iOS and Android

https://user-images.githubusercontent.com/24992535/207142411-5677228f-85b2-4a8c-9693-59138f0780ee.mp4

P
type
task

6
bug
Use correct default in useContext (link)

7
bug
move accLiveRegion prop to separate variable while keeping compatability with web props

8
bug
Nested text does not support accessibilityLiveRegion on iOS and Android (link)

P	type	task
6	bug	Use correct default in useContext (link)
7	bug	move accLiveRegion prop to separate variable while keeping compatability with web props
8	bug	Nested text does not support accessibilityLiveRegion on iOS and Android (link)

fixing issue with Android TextInput not passing accLiveRegion prop

https://user-images.githubusercontent.com/24992535/207151941-f035112c-3235-4ef7-8b27-403b9b9ecbe3.mp4

Android - correctly announcing change of ariaLive in Text component

https://user-images.githubusercontent.com/24992535/207153889-ffe79d88-9394-412d-a5fa-6944b1b9979a.mp4

https://app.circleci.com/pipelines/github/facebook/react-native/18392/workflows/498185fe-7241-47d5-a5b7-6fb22b4010a9/jobs/391153/steps

P
type
task

9
review
Review diff

10
review
Review Circle CI

11
review
Avoid re-implementating RCTIsReactRootView

12
review
check warning messages from linter. Enable linting tool and go through file changes

Just adding a comment here regarding documentation. I think it would be really valuable to add a warning comment to the docs for both Android and iOS cautioning people to reach for polite over assertive in most cases. Marketers can be prone to abusing assertive live regions on the web and in 90%+ of cases (IMO) polite is the better user experience. cc @blavalla


before_filter

does Grape provide a mechanism like before_filter in rails controller?
say:
resources :missions do
  before_filter :authenticate!, :only => [:post]

  post do
    create mission here...
  end

  get do
    return all missions here...
  end
end

@dblock Can you provide an example? @rubencodes @letronje @leondu Did you ever figure this out?

I'd like to set locale for all actions, how can I do that with all API? I tried with BaseAPI, and define like this:
module V1
  class BaseAPI < Grape::API
    before do
      I18n.locale = env['rack.session'][:lang]
    end
  end
end

then others will be extended from this class, but above snippet is never run

@tam-vo It should. Try this in the actual API class, I imagine that will work. Then try again in the base class, if it doesn't work open a new bug please (with a test would be nice).

I wrote two classes for auth and none-auth. But it does not work, please have a look what's wrong with it.
The root Class:
class API < Grape::API
  prefix 'api'
  format :json

  rescue_from :all

  mount AuthLessAPI
  mount AuthRequiredAPI
end

The auth required class
class AuthRequiredAPI < Grape::API

  before do
    error!("401 Unauthorized, 401") unless authenticated
  end

  mount UserAPI
  mount ...
end

The auth less class
class AuthLessAPI < Grape::API
  ... some api ...
end

@birbird You'll have to provide a lot more detail on "it doesn't work". I suggest opening a new issue and making code that clearly demonstrates the problem.

is there any way to scope the filter like before do till some extent, not for all the post/get requests?

Yes, see https://github.com/ruby-grape/grape#before-and-after.

If anyone else comes here, I was having trouble getting callbacks to work in a base grape class that mounted others. The solution for me was to make sure the before/after callbacks are called before the mounting of the other classes are called.
Here's ours:
module Api
  module V2
    class Base < Grape::API
      extend Api::V2::Documentation
      extend Api::V2::Authorization
      include ApiHelper

      after do # must be called before the mount calls below!
        track_request
      end

      mount Api::V2::Endpoints::Auth
      mount Api::V2::Endpoints::Users
    end
  end
end


Refactor dockerfile_functions.sh in their own architecture specific files

@karianna is any summary of https://adoptium.slack.com/archives/CSJ203YTW/p1612259867007300 available ? Also I would like to challange a bit idea of having this in bash instead, let's say python and jinja ? It seems the scripts want to behave like a templating engine to generate Dockerfile's, why not to use more apriopriate tooling ?

https://github.com/adoptium/containers/issues/1 covers most of the conversation that's still partly ongoing (we need to summarise it and then update the README for everyone).
bash is common across all our supported platforms but if you were happy to re-write the scripts in Python we could discuss that for sure.

@karianna after my last issue was merged I started looking for something else I could contribute to this project. Hence I ended up here.
In your comment you mention that "bash is common across all our supported platforms", however in the ticket related to refactoring common_functions.sh (#6 ) you raise the point that python3 is used to parse JSON. So it would be appear that python3 is also supported (and even required) across all the platforms. Would this help motivate a move towards replacing bash with Python 3?

That’s a great question and one to ask in the infrastructure channel on
slack.  They have th elbow ledge of all of our H/W and O/S combinations
On Thu, 25 Nov 2021 at 12:15, Philipp Gerhard @.***>
wrote:

@karianna https://github.com/karianna after my last issue was merged I
started looking for something else I could contribute to this project.
Hence I ended up here.
In your comment you mention that "bash is common across all our supported
platforms", however in the ticket related to refactoring
common_functions.sh (#6 https://github.com/adoptium/containers/issues/6
) you raise the point that python3 is used to parse JSON. So it would be
appear that python3 is also supported (and even required) across all the
platforms. Would this help motivate a move towards replacing bash with
Python 3?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/adoptium/containers/issues/8#issuecomment-979159502,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABME2DORHYB22P5EPIA7RLUNYSGVANCNFSM5B3Z3AMQ
.

--
Cheers, Martijn (Sent from Gmail Mobile)

Python is likely the best option, I'd considered using Python and handlebars to template the Dockerfiles going forwards

closed via https://github.com/adoptium/containers/pull/447


Please push latest version to NPM

NPM has an old version, latest version seems to work correctly but version on NPM is bugged for users with babel-plugin-root-import.

Use fork eslint-import-resolver-babel-plugin-root-import


list of keys?

I cant find a way to logout back to sddm...
Is there a list somewhere? also the way-cooler-bg will just open awindow with the background instead of changing the background, also I think is doing the amazing setup not the i3 how can I switch this? I install with yaourt/pacaur from the arch AUR the git version

Ok I found some keys on the main config in /etc/ so that part is better, but still does not say how to log out back to login window.. only restart way-cooler.

ok so there hidden in gray letters there is how to log out :) so I just need a way to change the background and I am all set :)

Hey @ReK2Fernandez.
You are probably using the latest version of the background program, which requires the latest version of Way to (eg, the master version, not 0.6.2). Try using either an older version of the background program or compile Way Cooler from source at the latest version on github.

@Timidger Thanks for the response... I am using the git version in the arch AUR, I though the -git will always get the latest from github? cheers

You might be using an old version of the background program then, please compile it from source since I think the AUR version of the background program is out of date

@Timidger ok I compiled it and got it working... atr first I created a pacage with the latest tag and still was having the issue so I just cloned the master and compiled that added it to my path and works now.  thanks.. I will try to create a package that grabs the master, but wont have time until after CCC in Germany. ohh BTW how do I lets say run apps that need to run all the time but dont necesary need to be visible on windows just an icon? like keybase run_keybase if not it wont mount the filesystem etc.
same with password managers like enpass for example.. what will be the best way?
thanks

If you're talking about things like tray icons, that isn't supported currently (since we don't have a tray). Some X11 bars might support it. We will support them in our official tray bar in the future.


[FEATURE] author: nil?

Describe the feature you want 描述你的功能需求

Is it possible to disable the author?
Another issue: I used ox-hugo to convert org file to markdown. Then I have
author = ["author"]
instead of
author = "author"
However, the first one gives me an error message:
execute of template failed: template: partials/plugin/link.html:7:16: executing "partials/plugin/link.html" at <safeHTML>: error calling safeHTML: unable to cast []string{"author"} of type []string to string

You can replace all author = into authors = which should solve this problem.

If you mean 'authors = ["xxx"]`, then it does not work...
I found a similar issue in another post:
https://github.com/kaushalmodi/ox-hugo/issues/387

authors = ["xxx"] is supported by DoIt theme and it should work out of the box.
https://hugodoit.pages.dev/theme-documentation-content/#author-setup
If it does not work, can you share the error log for debugging?

Disabling the author is not supported.
You can configure the author information in config.toml once and for all.
[author]
  name = "xxx"
  email = "xxx"
  link = "xxx"

If nothing is configured, a default Author will be displayed and everything will work correctly as well.

authors = ["xxx"] is supported by DoIt theme and it should work out of the box (even without the further configuration mentioned in the docs).
https://hugodoit.pages.dev/theme-documentation-content/#author-setup
If it does not work, can you share the error log for debugging?

This is the markdown file in /content/posts/:
`---
title: "First_post"
author: ["xxx"]
date: 2021-08-02T22:39:25-07:00
draft: true
This is my first post.
and when I runhugo server -D`, I got the following message:
ERROR: 2021/08/05 22:37:50 render of "page" failed: execute of template failed: template: posts/single.html:17:8: executing "posts/single.html" at <partial "head/seo.html" .>: error calling partial: "~/org/diaries_hugo/themes/DoIt/layouts/partials/head/seo.html:129:41": execute of template failed: template: partials/head/seo.html:129:41: executing "partials/head/seo.html" at <safeHTML>: error calling safeHTML: unable to cast []string{"xxx"} of type []string to string

Have you changed author: ["xxx"] into authors: ["xxx"]?

If I use authors : ["xxx"], I got this:
`render of "home" failed: execute of template failed: template: index.html:36:20: executing "content" at <.Render>: error calling Render: failed to execute template ["summary"] v: execute of template failed: template: _default/summary.html:39:16: executing "_default/summary.html" at <partial "meta/author" .>: error calling partial: "~/org/diaries_hugo/themes/DoIt/layouts/partials/meta/author.html:18:22": execute of template failed: template: partials/meta/author.html:18:22: executing "partials/meta/author.html" at <index $.Site.Data.authors $authorID>: error calling index: index of untyped nil
Rebuild failed:
Failed to render pages: render of "page" failed: execute of template failed: template: posts/single.html:17:8: executing "posts/single.html" at <partial "head/seo.html" .>: error calling partial: "~/org/diaries_hugo/themes/DoIt/layouts/partials/head/seo.html:150:26": execute of template failed: template: partials/head/seo.html:150:26: executing "partials/head/seo.html" at <index $.Site.Data.authors $authorID>: error calling index: index of untyped nil`

btw, I found this to disable the author. So I am wondering if you can add the option for us to enable/disable authors. I am asking this because for example, most of us may just to blog for personal thoughts, but not a collaboration.

I have managed to reproduce this error. To fix it, create a file your_site/data/authors/xxx.toml (you might need to create the folder data and authors for it) to let the Hugo .Data work. The name or the content of xxx.toml does not matter, just leave it blank if you want.

There is no technical difficulity to "disable" the author, however it takes some effort to make it look good when author is disabled.

If we simply remove it, then the published need to be capitalized, involving changes in i18n translations. And remove the &nbsp before. It is possible to implement, but I think it is unnecessary. Like what you say, most people use it for personal blog, and it makes perfectly sense for people to sign their name in the front of their blog post. So we provide a simple option in config.toml for you to set that globally and without worrying it in the future. If you don't want to specify your name, then just leave the settings blank, remove all authors or author font matter, then it will show Author.

For which I think is very acceptable.

I have managed to reproduce this error. To fix it, create a file your_site/data/authors/xxx.toml (you might need to create the folder data and authors for it) to let the Hugo .Data work. The name or the content of xxx.toml does not matter, just leave it blank if you want.

I did as you suggested, but still no luck.

I have managed to reproduce this error. To fix it, create a file your_site/data/authors/xxx.toml (you might need to create the folder data and authors for it) to let the Hugo .Data work. The name or the content of xxx.toml does not matter, just leave it blank if you want.

I did as you suggested, but still no luck.

Have you tried restart hugo server?

I have managed to reproduce this error. To fix it, create a file your_site/data/authors/xxx.toml (you might need to create the folder data and authors for it) to let the Hugo .Data work. The name or the content of xxx.toml does not matter, just leave it blank if you want.

I did as you suggested, but still no luck.

Have you tried restart hugo server?

Now it works, since I forgot to change author to authors.

As for the option of disabling author, I tried to delete the following
<span class="post-author">                      {{- $options := dict "Class" "author" "Destination" $authorLink "Title" "Author" "Rel" "author" "Icon" (dict "Class" "fas fa-user-circle fa-fw") "Content" $author -}}                      {{- partial "plugin/link.html" $options -}}                      </span>
in the layouts/posts/single.html, and it no author appears, also "published" with lower case "p".
But I also like your idea, to set
[author]
  name = " "

and it's simpler.
Thank you so much for your time and help here.

For any ox-hugo user coming across this issue thread, you can make ox-hugo export your author list in authors front-matter instead of the default author by adding this at the top of the Org file(s):
#+hugo_front_matter_key_replace: author>authors

This key replacement feature is documented here.
Ref: https://github.com/kaushalmodi/ox-hugo/issues/608#issuecomment-1086930066


Design an e2e test framework

A first look would be to take a look at https://github.com/kubernetes-sigs/e2e-framework.

There are two options.
Local Testing
For local testing, the user needs to run tilt up beforehand so there is a kind cluster running the local changes. Once that's done, the user must expose the following environment property: OCM_TEST_CLUSTER_NAME. The test will then understand that there is already a cluster it should use. It will proceed to run its tests using that cluster. This, however, has certain drawbacks. Although each test should be written so that it cleans up after itself, there could be leftovers that would influence the next test run.
Custom Image
In a CI environment, the Makefile will contain proper plumbing to create and push a test image to the ghcr with a fabricated custom tag that represents that particular build. It will then expose the following environment property: OCM_TEST_IMAGE. It will spin up a cluster for each suite. The suites must contain tests that can run and clean up after themselves.
This approach can also be used locally. A use might build an image in the local registry or any registry that is publicly available and set OCM_TEST_IMAGE so the test will deploy that image into the created test cluster.

Done at https://github.com/open-component-model/ocm-e2e-framework


Flan V2

Do you have the FLAN  V2 dataset as part of the 44M instructions? Which files from the https://huggingface.co/datasets/laion/OIG/tree/main should I take to access the zero shot portion of the FLAN V2.
Thank you.

@LorrinWWW - can you answer @ari9dam - was it flanv2 or v1? you can look in the repo, it's called unified_flan.jsonl https://huggingface.co/datasets/laion/OIG/tree/main
It's a very basic conversion to instruciton.


As a researcher, I want to be able to use metadata submitter API so I can use the service programmatically

Describe the user story

Metadata submitter API has some issues before it can be used independently from the frontend.
Tasks:
List of tasks needed for this user story. The technical description is in the tasks. Additional information, for example, a prototype, Figma files, and pictures are linked here.

[x] As an SD-Submit API user, I want to be able to submit DOI information through a dedicated endpoint so it would simplify my work
[x] As an SD-Submit API user, I want to have access to SD Submit API documentation so I would understand how to create submissions using API
[x] As a researcher I need to see API documentation with schemas up to date so I know what needs to be sent with a request body
[ ] As an SD Submit API user I need to know how submission information is updated so I can change the name and description of my submission
[ ] As a SD Submit API user I need to be able to authenticate through API login.

Testing
Description of how the testing will be done.
Definition of Done
SD Submit API users have the information to perform all needed actions for metadata submission through an API.

i am not sure researchers what to do that, however other 3rd parties or collaborators might want to do that.


Title doesn't get parsed from the front matter

🐛 Bug Report
I have a markdown file:
title: "Title1"
sidebar_label: "Title2"
hide_title: true
---

# Title3

text

The sidebar renders correctly, but the Next/Previous buttons show Title3 instead of Title1. The page itself doesn't show the title at all and starts with the text.
Have you read the Contributing Guidelines on issues?
Yes.
To Reproduce
https://codesandbox.io/s/friendly-elion-dwu3y?file=/docs/manage-docs-versions.md
Expected behavior
I had alpha-69 before and it worked correctly there. The markdown # Title3 should be shown on the page, Title1 should be shown on the paginated navigation.
Actual Behavior
On beta-0, the markdown # title is being shown on the paginated navigation instead of the title specified in the front matter. The markdown

@Mihonarium so what I understand is that you expect hide_title: true to not hide # Title 3 right? (like it used to be a few months ago?)

@slorber right. With title: "Title1" present, I expected # Title3 to be displayed as a regular markdown and not parsed at all.
I think if you make the hide_title: true unnecessary (or default) when there are duplicate titles, it's better to give users the ability (e.g., using hide_title: false) to override this and display duplicate titles if they want this for some reason.

I think if you make the hide_title: true unnecessary (or default) when there are duplicate titles, it's better to give users the ability (e.g., using hide_title: false) to override this and display duplicate titles if they want them for some reason.

Why do you think that, do you have an usecase to show duplicate titles, considering it's not really a good practice?

@Mihonarium according to our doc and this issue: https://github.com/facebook/docusaurus/issues/4929
sidebar_label is supposed to be used in priority for next/previous buttons over title, so we should display Title2 in next/previous buttons and not Title1 as you expect.
It make sense to me, as the navigation is tightly related to the sidebar, and it was the historical behavior we had before. So I'm going to restore this.
Is this a problem for you? In which case I can introduce a new frontmatter like pagination_label to have better decorrelation between sidebar label and pagination label

@slorber Yes, something like pagination_label makes sense then.
Though we need Title1 to be in both the HTML (tab) title and the pagination, so it also would be easier if there's a setting that allows changing the priority from sidebar_label to title.

@Mihonarium Title1 will now always be used in page metadata (tab title).
sidebar_label is optional so if you want Title1 in pagination you can just omit it.
sidebar_label is a better fit for pagination buttons because we have less width for both sidebar + pagination buttons and the sidebar_label is generally a shorter text compared to title which is a longer text used primarily for SEO purpose.

it also would be easier if there's a setting that allows changing the priority from sidebar_label to title

We could introduce a lot of ways to change priority orders of a lot of things in Docusaurus but I think it would be very confusing to have such APIs and add noise for most users.
Can you explain with real-world labels (not Title1) of a concrete use-case why you want
page meta title and pagination labels to be the same, and why sidebar label is not a good fit for pagination labels?
If there's a real need, I'd rather have a pagination_label frontmatter rather than a pagination_label_priority: title: it is simpler to understand and way more explicit.

We definitely need different titles in the pagination buttons and the sidebar, though I agree a pagination_label would be simpler.
At our music recognition API documentation, we use the sidebar as a menu a user can look at without a context and decide where they want to go, and the pagination buttons mostly have less text because the user is already in the context when they look at it.
For this page, we display "Enterprise endpoint" as the pagination button and the HTML/tab <title>, "Music recognition for mixes, long audio and video files" as the sidebar title, and "API Docs for the enterprise endpoint" as the H1 title displayed in the markdown. So the sidebar titles are longer than the ones we display as the tab titles and the pagination.
It's hard for us to conduct SEO experiments since we already hold the 1,0 average position for the "Music recognition API" query on Google, but it seems like the current combination is working.

Thanks
Not sure to understand why you have so different labels in page meta, sidebar, markdown heading, and pagination buttons though 😅
I'll add the pagination_label frontmatter for better flexibility, make sure to double-check everything when you upgrade to the next beta.1 release


Fine grained durations, custom transitions and discussion

Hi,
I'm experimenting with this amazing library and I wanted to talk about some features that I would like to be present.
Most of them concern transitions.
1. Different transition durations per attributes
Let's imagine that we wish the width to change in 100ms and the height in 1000ms (maybe allow this behaviour with delay but that may be too much)
const datum = {
	append: "rect",
-	width: {enter: 100, exit: 0},
+	width: {enter: 100, exit: 0, duration: 100},
	height: 100,
	duration: 1000 // default duration
};

2. Pass transition object instead of duration, delay and ease.
I found myself using the same values in different components, which boils down to something like
const t = {duration: 250, delay: 10, ease: d3.easeQuadInOut};
// later
const ExampleComponent = (c) => ({
	append: "g",
	// ...
	...t,
	...c
})

I feel that it could be more esthetic to directly pass a d3.transition object
const transition = d3.transition()
	.duration(250)
	.delay(10)
	.ease(d3.easeQuadInOut);

// or
// const transition = {duration: 250, delay: 10, ease: d3.easeQuadInOut};

// ...later
const ExampleComponent = (c) => ({
	append: "g",
	// ...
	transition,
	...c
})

Which might also allow for transition chaining shenanigans.
3. Datum components
When using d3-render, I cannot interact the with the component I have currently selected:
const $svg = d3.create('svg')
	.attr('width', "100")
	.attr('height', '100')
	.attr('viewBox', [0, 0, 50, 50]);

render($svg, [/*data*/]);

If I want to animate $svg's attributes, i need to use $svg.transtion()..., where something like this is waay better.
// by the power of d3-render
render(d3.create('svg'), {
	width: 100,
	height, 100,
	viewBox: [0, 0, 50, 50],
	duration: 100,
	children: [/*data*/]
})

4. Self controlled components
This is placed last, because it goes against the data->render flow. Because it might be an interesting case.
I wish my components had a react-like state/props approach. Where I could have some data which is passed down by data and the rest is self managed.
working example : https://observablehq.com/@stardisblue/d3-render-self-controlled-components
In this example, the components are setup using call. But call is not triggered during "update" state. So I cannot do a state/props setup (as in react for example).
This is more a defaultstate/state approach.
Conclusion
This issue might be arguably the worst issue github as ever seen, as it presents no errors to fix and proposes way too much features. I was tempted to make several issues out of this one, but that felt like spam. So here are several features that I will be more that happy to see included. I can pull request you some of them but I feel like these [propositions] need an Okay from your side.

Hi Stardisblue,
Thanks for these suggestions - it is early days for the library so I'm totally up for general discussions.
1. Different transition durations per attributes
I've been thinking about this feature too and I'm glad you raised it. I like the API you have proposed, plus delay and ease could work too:
const datum = {
  append: "rect",
  width: {enter: 100, exit: 0, duration: 100, delay: 100, ease: d3.easeQuadInOut},
  height: 100,
  duration: 1000 // default duration
};

Would it be crazy to also have different enter/exit transitions per attribute too?
const datum = {
  append: "rect",
  width: {enter: { value: 100, duration: 100 }, exit: { value: 0, duration: 200 },
  height: 100,
  duration: 1000 // default duration
};

This feature is certainly worthy of a separate issue for discussion. Feel free to create one if you'd like.
2. Pass transition object instead of duration, delay and ease.
Yes this is a tough one. I did originally think it would be nice to group those in a transition object, but having it flat along with everything else also makes it a bit easier to get started.
Perhaps it is just me, but I quite like destructuring objects like in your example. It also makes overriding the transition settings a bit easier than passing d3.transition, eg:
const t = {duration: 250, delay: 10, ease: d3.easeQuadInOut};

const ExampleComponent = (c) => ({
  append: "g",
  ...t,
  ...c
})

render('svg', [ExampleComponent({
  r: 100,
  // Overrides duration: 250 only
  duration: 500
})]

Not having funky chaining shenanigans is the tradeoff here, but perhaps we can do it by passing an array of transition objects to each attribute. I'll sketch something up in another issue.
3. Datum components
Hmm, this is an interesting one. By design, D3 Render needs a mount point, some div or svg, but can only change the elements inside. Perhaps if you would like control of the svg element, could you try this?:
render('#container', [{
  append: 'svg',
  width: 100,
  height, 100,
  viewBox: [0, 0, 50, 50],
  duration: 100,
  children: [/*data*/]
}])

4. Self controlled components
This is seriously cool what you have done there. I'll have to dig a bit deeper into your code, but it is definitely a something I'd be keen to look into. A React like props/state rendering system would make interaction really nice.
Thanks again for your feedback.

Different enter/exit transitions  would be very useful for my use-case.
I need to have a different transition duration on enter and exit.
const datum = {
  append: "circle",
  r: {enter: { value: 100, duration: 400 }, exit: { value: 0, duration: 50 },
  cx: 100,
  cy: 100,
  duration: 400 // default duration
};

Passing a d3.transition object would have the benefit of being able to pass a promise on transition.end when all the transitions finished.
https://github.com/d3/d3-transition/blob/master/README.md#transition_end
Or how could an api for such use case look like in d3-render?
      svg
        .transition()
        .duration(600)
        .attr('width', width)
        .attr('height', height)
        .end()
        .then(() => {
          this.width = width;
          this.height = height;
        });


Cupy.sparse not recognized

After installing cupy, latest version, tried to comvert a matrix to cupy.sparse.csr matrix. But for unknown reason, sparse is not recognized. Is cupy.sparse really usable?

Ah, please try import cupy.sparse.

Thanks. import cupy.sparse works.


New app: Buienradar (rain radar)

Description
This new app shows the rain radar of Belgium or The Netherlands. The data is provided by Buienradar.nl, a brand of RTL Nederland.
Copilot

🤖 Generated by Copilot at 9bba2b6
Summary
🌧🌍📝

This pull request adds a new applet called Buienradar, which shows the rain radar of Belgium or The Netherlands on the Tidbyt device. It includes the applet code in buienradar.star, the manifest file in manifest.yaml, and the documentation file in README.md.

Buienradar app
Shows the rain on Tidbyt
Autumn is coming

Walkthrough

Create a new applet for displaying the rain radar of Belgium or The Netherlands using the Buienradar API (link, link, link)

Previews
apps/buienradar/buienradar.star:

Note: currently there is no rain in The Netherlands or Belgium, so you will not see anything on the radar in this preview image.


Please consider making a Vapor module! Vapor community needs it

for i in (0..<9000) {
print(self.title)
}

Haha :-) Thanks for the suggestion! I haven't worked with Swift Vapor yet, but I'll certainly look into it.


Fixes bug in Gunning Fog score

Quick fix for #62
Any chance you'd be doing a pip release with this fix soon? If not I'll continue to use the version from Github. Thanks.

@jayantj excellent, thank you! :tada:
I'll try to get a patch release out shortly for this and #65.

Glad to contribute, thank you!


Fix quiz-synchonization

Checklist

[x] I tested all changes and all related features with different users (student, tutor, instructor, admin) locally

Motivation and Context

Fix synchronization for quiz-component in exams.
Before: Submit on every exercise change, also some other problems related to the implementation.
Now: The component is working as expected i.e. it communicated changes correctly in the hasUnsavedChanges() method. It does not apply changes instantly on the locally managed StudentExam, but manages its own copy which is only synched to locally managed StudentExam when updateSubmissionFromView() is called. Another problem was with the initialization of the component, we had introduced some instanceOf checking, but agular does not have type information after deserialization of data -> lead to always submit the first time when exercise was opened in the browser
Description
update quiz-exercise synchronization
fix: do not update submission on initialized exam
fix: synchronize only on changes
fix: separate submission from quiz-exam-submission.component.ts managed objects by using cloneDeep
fix: instance check not working -> check for Answer type instead
Steps for Testing

Preparation

Create a StudentExam, with a MC, DnD and SA quiz, it is okay/wanted to mix different question types in one exercise
Add Students to the Exam
Generate StudentExams
Prepare Exam Start

First Time Opening of exercises - no synch is triggered

If you open the exercises for the first time, make sure that no submission is triggered if you do not change anything and change the exercise via navigation bar / submit and continue button

Synchronization is working

Make changes in the exercises and check whether they are submitted to the backend
Possible changes:

MC: add answer, remove answer, add answer and remove another answer
DnD: add mapping of item to field, remove mapping of item to field, add and remove item to field
SA: add answer to field, remove answer from field, add and remove answer from field

Check via browser console, that updates are only triggered after changes

** I had a lot of errors in my browser console which should not be related to this PR, namely:**

ERROR TypeError: Cannot read property 'some' of undefined
at DragAndDropQuestionComponent.eval (drag-and-drop-question.component.ts?9509:221)
ERROR Error: ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked. Previous value for 'hidden': 'false'. Current value: 'true'.
ERROR TypeError: Cannot read property 'filter' of undefined
at ShortAnswerQuestionComponent.getSubmittedTextForSpot (short-answer-question.component.ts?626f:128)

Despite these errors, the components did function for me as expected

Is it relevant for testing that we put all quiz types in one quiz or would it be interesting have both: A single quiz with all types and multiple quizzes with each type?

Is it relevant for testing that we put all quiz types in one quiz or would it be interesting have both: A single quiz with all types and multiple quizzes with each type?

Updated it in the description, you can do both!

fixed the error with not updating SA answers, was not connected to browser console error -> that one still appears


Added mysql timezone support

See this file for more details:
https://github.com/haruka/shopware-rfc/blob/master/database_timezone.md

Thank you @haruka for this exemplary Pull Request :+1:
We are quite busy with the Shopware 5 Release but we will review this PR soon(ish).

Dear Contributor,
Thank you for your contribution to Shopware. We value your engagement.
Unfortunately we have to close all existing Pull Requests.
This is due to the new Shopware 5 Major Release and a restructuring of the branch names.
If your contribution is still relevant for Shopware 5, a new pull request is highly appreciated.
We are very sorry for this inconvenience.
Greetings from the Shopware Team.


New Contributing Notebook

I have created a new contributing notebook as a final project for the UChicago class ASTR 285: Science With Large Astronomical Surveys. The notebook deals with exoplanets, so I created a new directory under 05_Contrib and updated keywords.txt.

Thanks @mtagliavia!
I'll review this notebook as your final project, and then we can discuss whether or not you want to continue the process of getting it reviewed and included in the data lab examples.


Add todo-to-issue GitHub Action in order to add GitHub Issues from TODOs, etc.

I have found a GitHub Action (alstr/todo-to-issue-action ) that finds TODOs, FIXMEs, etc in coding files and creates GitHub Issues.
What todo-to-issue-action does:

This action will convert newly committed TODO comments to GitHub issues on push.
Optionally, issues can also be closed when the TODOs are removed in a future commit.
Action supports:

Multiple, customizable comments identifiers (FIXME, etc.),
Configurable auto-labeling,
Assignees,
Milestones,
Projects (classic).
todo-to-issue works with almost any programming language.

This action needs the Workflow permissions setting Read and Write permissions under Settings => Actions => General set in order to be allowed to create issues!
Before (or shortly after the merge) the action needs to be updated to point to the main branch (or whatever condition) in order to look at the main branch for TODOs on pushes.
When the TODO, etc. is removed the Issue is closed automatically. This can be configured. The automatic labeling (Fix me, Help Wanted, etc.) of issues also can be configured.
As an example on how to use it, I added a TODO in src/TagzApp.Common/Models/Content.cs. In my testing in my forked repo this worked. This is the Issue it created for #2!
I also added an .editorconfig that sets spaces as intentation for .yml files in the root directory.
Next Step:

add all TODOs, FIXMEs, etc. in changes to the repo

Very cool update,  and will help make it clear how our team collaborates and marks up code


Get-Secret Does Not Pull Updated Password from KeePass DB

NOTE: Not sure if this is an issue with the SecretManagement.KeePass module or the larger Microsoft.PowerShell.SecretManagement module.
Situation:

Start PowerShell session that has a KeePass vault registered already
Store the credentials for one of the KeePass secrets as a variable
Example:
$testCreds = Get-Secret -Vault testVault -Name 'test-creds'
Successfully connect to remote system with saved credential
Update password for 'test-creds' in the KeePass database and save
Attempt to update stored credential in PowerShell session by running the Get-Secret command again
Example:
 $testCreds = Get-Secret -Vault testVault -Name 'test-creds'
Unable to authenticate with remote system using $testCreds
Close PowerShell session
Open new PowerShell session
Store the credentials again
Example:
 $testCreds = Get-Secret -Vault testVault -Name 'test-creds'
Successfully connect to remote system with saved credential

Due to the nature of how keepass works, once you unlock a vault, that vault is persisted in memory for performance, otherwise you have to close and open the vault every single action. I will add a command Refresh-KeepassSecretVault that will remove the connection and allow you to get refreshed info.

I figured out a way to have the refresh work  automatically, since keepass persists the database hash of the last on-disk DB it saved.


Add tests

There need to be tests for Skootrs, especially to mock out some of the actions without needing to create a new github repo each time.

More tests need to be created but a good deal of tests were created for the main functionality.


Blockus update means some compatibility retextures need updating/adding

Blockus has had an update changing the texture of their chiselled purpur block, which means that BE's retexture of it to match its new purpur colour no longer matches. I would like to request that this texture be updated to have the new shape with Better End's purpur colour. The Blockus update also added a new purpur-decorated end stone block that I would like to request be given an appropriate recolour as well.
The relevant Blockus changelog and version download is linked above.

Added in 0.9.7


Not Working

Hi!
Its not working any more. Its not give online status of number which we have not chat before or we are not in contact list of that number. Can You please check and update it.
Thanks

From what I've read online, WhatsApp have made some changes to their API.
The code still works to a certain extent but WhatsApp have locked down some flows, probably due to the Facebook scandal.

do you have a script just for online status for a single or more numbers check?

This script is not working on WhatsApp now; No output Table is displayed on console for participants who are chatting each other. May we have some improvements Jamie on code please?


Folder names are displayed in all caps.

If all the characters in a folder name are lower case letters, then the libaums library is displaying them in upper case characters.

on Running with Storage Access Framework

Problem is consistent and easily reproducible.

Hey, so I tried that.
Unfortunately when I am creating a folder with all caps or with all lower case it still only creates a usual directory entry for both cases. As far as I know the FAT32 spec for the latter case there should be an lfn entry, but apparently, it is not created or there is a bug in my code somewhere.
So if you have any idea this is highly appreciated.

Found it: https://en.wikipedia.org/wiki/8.3_filename#Compatibility


GPU Memory Backends [okina-mmu]

Allows memory backends: std::, CUDA, UVM, Umpire & Debug.
Most of the additions come from the new sedov unit test (4k loc) and the cmake/ctest support for all the tests.
The core of the changes are in the mem_manager.cpp file, inside the MemoryManager class.

[x] Add unit tests
[x] Allow multiple concurrent memory backends
[x] Set default memory backend to use new delete
[x] Add default Umpire names: MFEM_UMPIRE_HOST and MFEM_UMPIRE_DEVICE
[x] Add runtime Umpire Set/Get names
[x] MMU to DEBUG for memory types & class
[x] Sedov Laghos-like test w/ Umpire, uvm & debug
[x] all cmake tests w/ MPI & CUDA
[x] ctest w/ umpire

Review TODO additions:

[x] remove memory types increment and decrement operations
[x] Tie Poly_1D to use MemoryType::HOST
[x] Move MemoryManager::CheckHostMemoryType_ inside the calls
[x] Remove duplicate mt == MemoryType::HOST tests
[x] mt should support all host and device types in Wrap
[x] MFEM_USE_CUDA guard within MFEM_USE_UMPIRE

Review TODO questions:

[x] Removed Umpire config variables to simplify the build systems
[x] Address HOST => wrapped => DEBUG mode (UsePrecomputedSparsity reproducer)
[x] make parallel error: m distclean && m parallel -j && m all -j
[x] miniapps/performance warnings:
style of line directive is a GCC extension
Can be removed without the pedantic option in nvcc and gnu compilers

[x] MFEM_MEMORY=debug ./config/sample-runs.sh -p -dev
[x] MFEM_MEMORY=debug MFEM_CPPFLAGS=-O3 ./config/sample-runs.sh -par -debug

make distclean && make cudebug -j MFEM_USE_UMPIRE=YES
make distclean && make cudebug -j allows to use the debug device

With cmake in ./build:
cmake .. -DMFEM_USE_CUDA=YES -DMFEM_ENABLE_TESTING=YES -DMFEM_ENABLE_EXAMPLES=YES -DMFEM_ENABLE_MINIAPPS=YES -DMFEM_USE_MPI=YES -DMFEM_USE_METIS=YES -DMFEM_USE_UMPIRE=YES && make all tests -j && ctest -j 8 --output-on-failure --schedule-random --progress

PR
Author
Editor
Reviewers
Assignment
Approval
Merge

#1104
@camierjs
@tzanio
@dmed256 + @v-dobrev
12/14/19
02/20/20
⌛due 02/27/20

Did the segfault issue get sorted out?

Yes, Umpire support should be ready soon now.
Still can't initialize it at startup, but it's not a requirement.

@tzanio, @v-dobrev, this PR should now be ready to be reviewed!

Moving the due date to 1/17 to give a bit more time for review...

Some issues from this night's regression tests

make unittest fails because for test_sedov.cpp: e.g. on toss and other machines, see also the error in build-test-basic.

g++ -g -c /usr/WS2/mfem/autotest/toss_3_x86_64_ib/mfem/tests/unit/miniapps/test_sedov.cpp -I/usr/WS2/mfem/autotest/toss_3_x86_64_ib/mfem/tests/unit -I/usr/WS2/mfem/autotest/toss_3_x86_64_ib/mfem  -g -Wall -std=c++11 -I/usr/WS2/mfem/autotest/toss_3_x86_64_ib/mfem -I/usr/WS2/mfem/autotest/toss_3_x86_64_ib/mfem/../gecko/inc -o miniapps/test_sedov.o
/usr/WS2/mfem/autotest/toss_3_x86_64_ib/mfem/tests/unit/unit_test_main.cpp:13:20: fatal error: mfem.hpp: No such file or directory
 #include "mfem.hpp"
                    ^
compilation terminated.
make: *** [/usr/WS2/mfem/autotest/toss_3_x86_64_ib/mfem/tests/unit/unit_test_main.o] Error 1

Do the differences in sample-runs-devices-tux429 look reasonable?

We need to decide what to do about code-style

The changes in this PR are not mirrored in the code-style script in the tests repo, as well as the new PR #1267...

Re-merged in next for testing...

Following https://github.com/mfem/mfem/pull/1259#issuecomment-589887287, I updated the test_sedovunit test to use the GlobalMPISession object in https://github.com/mfem/mfem/pull/1104/commits/c5ddba1a9901d3c194250463ab7929155328ed7b.
Something still seems wrong though, because on my Mac, the run with 2 MPI tasks
Parallel unit tests [ mpirun -np 2 sedov_tests_cpu ... ]:

seems to hang.
cc: @camierjs, @jandrej

mpirun -n 2 ./unit_tests on master runs fine.
mpirun -n 2 ./unit_tests on this branch hangs after the last test is finished.

Thanks @jandrej !

Should be resolved on sedov_tests_cpu now.

Any idea why unittest is still failing (e.g. on toss and tux375)?
g++ -g -c /home/dobrev1/autotest-mfem/tux375/mfem/tests/unit/mesh/test_mesh.cpp -I/home/dobrev1/autotest-mfem/tux375/mfem/tests/unit -I/home/dobrev1/autotest-mfem/tux375/mfem  -g -Wall -std=c++11 -I/home/dobrev1/autotest-mfem/tux375/mfem -I/home/dobrev1/autotest-mfem/tux375/mfem/../gecko/inc -o mesh/test_mesh.o
g++ -g -c /home/dobrev1/autotest-mfem/tux375/mfem/tests/unit/miniapps/test_sedov.cpp -I/home/dobrev1/autotest-mfem/tux375/mfem/tests/unit -I/home/dobrev1/autotest-mfem/tux375/mfem  -g -Wall -std=c++11 -I/home/dobrev1/autotest-mfem/tux375/mfem -I/home/dobrev1/autotest-mfem/tux375/mfem/../gecko/inc -o miniapps/test_sedov.o
g++    -c -o /home/dobrev1/autotest-mfem/tux375/mfem/tests/unit/unit_test_main.o /home/dobrev1/autotest-mfem/tux375/mfem/tests/unit/unit_test_main.cpp
/home/dobrev1/autotest-mfem/tux375/mfem/tests/unit/unit_test_main.cpp:13:20: fatal error: mfem.hpp: No such file or directory
 #include "mfem.hpp"
                    ^
compilation terminated.
make: *** [/home/dobrev1/autotest-mfem/tux375/mfem/tests/unit/unit_test_main.o] Error 1
make: *** Waiting for unfinished jobs....
Building the unit test code failed. Stop.

Any idea why unittest is still failing (e.g. on toss and tux375)?

I think it is fixed now.

Thanks!

Can you resolve the conflicts above, please

Thanks!

Now that the new make style is in master we'll need to update the makefile for the changes in this PR. Maybe we can just call the script after applying astyle? This should show only things related to std::cin/std::cout use.

I've moved the cout and cerr script tests in the style target of the makefile.


Rename incorrectly-named intersectsEntities methods

Fixes #2901
Also renamed param for EntityView#doesNotIntersectEntities to match the CollisionView name - will javadoc in that PR.

hmm, might be better to unify this with isSpaceEmpty shall they act similarly (it takes a box instead)

isSpaceEmpty, afaik, checks for blocks and world borders as well. This one is just for entities.


“Comment Unavailable” text is shown on sent request section when user send request with adding description

Frequency: 100%
Repro App version:  Valora Mainnet build v1.0.0 (14), Test flight build v1.0.0 (15)
Does not Repro on  App version: Test flight Valora v1.0.0(6)
Repro on device: iPhone 6(12.4.7), Samsung Galaxy A5(7.0)
Pre-conditions: Make sure user has verified phone number.
Repro Steps:

Launch the Android app and sign in with a test account.
Launch the iOS app and sign up.
Tap on Request button
Select any contact
Enter valid amount
Tap on Review button
Tap on send button
Go to home page & observe on sent notification

Current Behavior: Comment unavailable text is shown when user sent request adding with description
Expected Behavior:  Entered description should show on sent request section
Investigation: Issue does not repro if user has not verified number.
Impact: User not able to see entered description
Attachment: CommentUnavailable.png

Able to consistently reproduce when the requester & receiver have confirmed number, only requester sees comment unavailable

Verified with latest Android internal build v1.1.0<PHONE_NUMBER>)& iOS test flight build v1.1.0(21) and found that issue is fixed as verified and non-verified users are able to see comment on payment request section.


[docs] Installation info

Tiny addition to the readme.

Just add something like
## Installation
Install this plugin using any plugin/package manager or see [`:h packages`](https://neovim.io/doc/user/repeat.html#packages)

Fixed by 8fd2d8a11bb9b7610b3caedd3601843ceafc119f


Docker support

Hi: wondered if the project could/should have a Dockerfile by default? Working on one now but just throwing out there in case anyone else has considered.

I have sample here. https://gist.github.com/baoduy/9367482e52f192fdaa3d9e489eebed51
Hope it helps.


[FEA] Set concurrentGpuTasks in the plugin on startup based on available GPU memory

General heuristic: concurrentGpuTasks = max(4, available GPU memory / 8GB)

We need to make sure that the docs are clear about the default and they if they set the target batch size they should also set the parallelism because it can be problematic.


Animations

I kind of like this approach:
https://github.com/flekschas/svelte-simple-modal/blob/fabcd9d16c54318e6ba047dcdeb537a66760c179/src/Modal.svelte#L93-L98
It would be similar to how style props are exposed for custom styling (cf. #4)


Missing fsPath or something from element parent causes issues refreshing tree node using onDidChangeTreeData

Issue Type: Bug

I followed the following code sample with a few tweaks for my need like filtering out "." and ".." items.
I called the refresh function with an element of FtpNode and works great until trying to call refresh on the parent node of an element retrieved through the getParent method on line 140. No error is thrown, but an actual refresh of the parent node never happens.

public getParent(element: FtpNode): FtpNode {
    const parent = element.resource.with({ path: dirname(element.resource.path) });
    return parent.path !== '//' ? { resource: parent, isDirectory: true } : null;
}

I believe the issue is with line 141 and the fact that the with method does not return a _fsPath property, which I believe is necessary to properly match I believe on line 543 and reference the URI of the node that needs to be refreshed. I tried setting authority, but that does not fix the issue.
private getHandlesToRefresh(elements: T[]): TreeItemHandle[] {
    const elementsToUpdate = new Set<TreeItemHandle>();
    const elementNodes = elements.map(element => this.nodes.get(element));

For a workaround, I add a reference to the parent to each child node on line 66 so it can be referenced in the FtpNode that is passed into when an item is clicked or selected. I then use this reference to the parent and pass it to the refresh and it works as intended.
public getChildren(node: FtpNode): Thenable<FtpNode[]> {
    return new Promise((c, e) => {
        this._client.list(node.resource.fsPath, (err, list) => {
            if (err) {
                return e(err);
            }

        return c(this.sort(list.filter(entry => entry.name !== '.' && entry.name !== '..').map(entry => ({ resource: Uri.parse(`ftp://${node.resource.fsPath}/${entry.name}`), isDirectory: entry.type === 'd', parent: node }))));
        });
    });
}

VS Code version: Code 1.62.1 (f4af3cbf5a99787542e2a30fe1fd37cd644cc31f, 2021-11-05T09:24:32.081Z)
OS version: Darwin arm64 20.6.0
Restricted Mode: No

System Info

Item
Value

CPUs
Apple M1 (8 x 24)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
1, 2, 2

Memory (System)
16.00GB (0.10GB free)

Process Argv
--crash-reporter-id a8a27011-88a7-44a5-9379-df21cf4a04bb

Screen Reader
no

VM
0%

Extensions (14)

Extension
Author (truncated)
Version

project-manager
ale
12.4.0

tsl-problem-matcher
amo
0.5.0

vscode-eslint
dba
2.2.2

vscode-html-css
ecm
1.10.2

php-debug
fel
1.22.0

go
gol
0.29.0

python
ms-
2021.11.1422169775

vscode-pylance
ms-
2021.11.1

jupyter
ms-
2021.10.1101450599

jupyter-keymap
ms-
1.0.0

jupyter-renderers
ms-
1.0.3

atom-keybindings
ms-
3.0.9

twig
wha
1.0.2

material-theme
zhu
3.13.2

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythontb:30283811
pythonvspyt551cf:30345471
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscorecescf:30384386
pythondataviewer:30285071
vscod805cf:30301675
pythonvspyt200:30340761
binariesv615:30325510
vsccppwtct:30382698
bridge0708:30335490
dockerwalkthru:30377721
bridge0723:30353136
pythonrunftest32:30373476
pythonf5test824:30373475
javagetstartedt:30391933
pythonvspyt187:30373474
vsqsis200:30386379
vsaa593:30376534
vssld246:30386377

@maurice-ellis do you have a complete example I can try out?

@alexr00 , I created a sample here based off the coding sample, unfortunately, the credentials provided do not work, so you have to provide your own.
There is a FTP Explorer view and items have a context menu, Refresh and Refresh Parent. Refresh works with no issues, but Refresh Parent, which attempts to get the parent of the element using the function in the Tree Provider does not refresh at all. You can see the difference between the element coming directly through the command and the element coming from the getParent method and it's missing _fsPath.

It looks like what you're hitting is that the value that you fire onDidChangeTreeData with must be the same object as an object already in the tree, just having an object with the same properties and values is not correct.

@alexr00 I'm not sure why this is closed, this is based on the sample code that Microsoft provides and with it, the getParent function does not work.

getParent is called by VS Code to support TreeView reveal, and it works for that. If you want to refresh a parent tree element, which the sample does not do, then you will need a different implementation of getParent.


Cannot install packages in Atom

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
Cannot install any packages, themes however install normally. This is the error I get:
assert.js:85
  throw new assert.AssertionError({
  ^
AssertionError: Expected there to only be one child in node_modules
    at C:\Users\Mark Mitchell\AppData\Local\atom\app-1.17.2\resources\app\apm\lib\install.js:174:22
    at ChildProcess.onChildExit (C:\Users\Mark Mitchell\AppData\Local\atom\app-1.17.2\resources\app\apm\lib\command.js:51:49)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at maybeClose (internal/child_process.js:877:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)

I have tried on beta, and on stable none worked.
Steps to Reproduce
-Just try to install any package, and it will error. Doesn't matter if it's in safe mode or not.
Expected behavior:  It will install the desired package.
Actual behavior: It does nothing and gives an error.
Reproduces how often: For me at least, it's 100%.
Versions
Atom    : 1.17.2
Electron: 1.3.15
Chrome  : 52.0.2743.82
Node    : 6.5.0
apm  1.17.0
npm  3.10.5
node 6.9.5 x64
python
git 2.13.0.windows.1
visual studio 2013
Windows 10,  10.0.10586 N/A Build 10586

Just to confirm, did installing packages work fine in previous versions but started throwing this error for you as of 1.17.0 and 1.18.0-beta?

@rsese Yes, I do believe so. It worked before and then it stopped, I guess it updated automatically then.

Thanks for confirming - can you try temporarily resetting to factory defaults and see if you still get the same error?
http://flight-manual.atom.io/hacking-atom/sections/debugging/#reset-to-factory-defaults

I tried while reinstalling, I deleted the folder totally. I just tried again, unfortunately I got the same error again.

Also gives the exact same error, I've already tried and just did again.

Not able to repro this on my machine.  I think if this was happening to everybody we'd be seeing a lot more reports. Not sure what could be causing that.

I can understand, but Atom is such a great programm, I would like to install packages too :D
Any ideas how I could fix that then?

The problem is we have no idea what could be causing which would be the first part of figuring out a fix. You could perhaps try unpacking the atom-windows.zip portable version.

No response.

I could not install packages in Atom, either. Nobody else's tips worked for me, so below, I am posting what I did to get it to work.
I am running Fedora. Initially, I downloaded the Atom rpm package from the website, atom.io. I tried to install it by double-clicking it, but apper gave an error at the end.
I resort to Copr. There is a mosquito/atom package there. I enabled the repo and installed. At this point in the story, Atom is installed and working great.
The point of all this was just to edit a ReadMe with Markdown. I had the plain text on the left and the Markdown preview on the right, working spectacularly. Then something happens, an auto-update, I assume. After "the happening", whenever I edited the plain text, the preview would scroll to the bottom -- extremely counter-productive and very annoying. I find the markdown-sync-scroll package, which was created to remedy this exact problem. I try to install the package, and it fails. I get an error about a version being undefined. The last line said "not ok".
I try installing the package from terminal using apm, with and without sudo, same error. I try updating nodejs and doing "npm rebuild". Same error. Uninstalling, reinstalling atom -- same error.
Finally, I sudo dnf remove --purge atom. Then I delete /etc/yum.repos.d/_copr_mosquito-atom.repo. Then I go to the atom/atom ReadMe on github. I follow its link, download, and install that rpm by double-clicking it. This is not the one from the website, atom.io. Again, apper fails. But by luck, somehow I notice that it actually installed anyhow. I purged with dnf and tried to install the package via double-click several times before noticing that it actually does install, despite the apper error.
And this time, packages install. Now, I have Markdown editing how I want it! Yay!


Subentities are not fetched

Is there a reason why

fetchRequest.includesSubentities

is always set to false? I am using a relationship to an abstract entity, this will only work if subentries are fetched.

There are several places where it is used for faster fetch request.

Please provide source file's name.
What is not working for you if you're using abstract entities?


[bug] Thermofloor Z-TRM2FX not identified as climate in HASS

Version
Build/Run method

[X] Docker
[ ] PKG
[ ] Manually built (git clone - npm install - npm run build )

zwavejs2mqtt version: master branch (zwave-js from branch fix-ztrm2 - now merged into master)
Describe the bug
In Home Assistant my Thermofloor z-trm2fx aka Heatit Thermostat TF 056 is not properly identified on the climate plattform. I see all the sensors and switches, but no climate controll. Might this be related to this?
To Reproduce
It's consistent with all 6 of my thermostats, I did also try to exclude and include but no change in HASS.
However I do notice an error in the logs:
zwavejs2mqtt_1     | 2021-01-11 09:38:23.350 ERROR GATEWAY: Error while discovering device climate_thermostat of node 49: Cannot read property 'id' of undefined Cannot read property 'id' of undefined
zwavejs2mqtt_1     | TypeError: Cannot read property 'id' of undefined
zwavejs2mqtt_1     |     at Gateway.valueTopic (/usr/src/app/lib/Gateway.js:868:23)
zwavejs2mqtt_1     |     at Gateway.discoverDevice (/usr/src/app/lib/Gateway.js:1126:16)
zwavejs2mqtt_1     |     at /usr/src/app/lib/Gateway.js:360:40
zwavejs2mqtt_1     |     at Array.forEach (<anonymous>)
zwavejs2mqtt_1     |     at Gateway.onNodeStatus (/usr/src/app/lib/Gateway.js:360:17)
zwavejs2mqtt_1     |     at ZwaveClient.emit (events.js:314:20)
zwavejs2mqtt_1     |     at ZwaveClient.EventEmitter.emit (domain.js:483:12)
zwavejs2mqtt_1     |     at ZwaveClient.onNodeStatus (/usr/src/app/lib/ZwaveClient.js:247:10)
zwavejs2mqtt_1     |     at ZwaveClient.onNodeReady (/usr/src/app/lib/ZwaveClient.js:275:16)
zwavejs2mqtt_1     |     at ZWaveNode.emit (events.js:326:22)
zwavejs2mqtt_1     |     at ZWaveNode.EventEmitter.emit (domain.js:483:12)
zwavejs2mqtt_1     |     at ZWaveNode.onReadyChange (/usr/src/app/node_modules/zwave-js/src/lib/node/Node.ts:441:19)
zwavejs2mqtt_1     |     at /usr/src/app/node_modules/zwave-js/src/lib/node/Node.ts:227:10
zwavejs2mqtt_1     |     at Interpreter.update (/usr/src/app/node_modules/xstate/lib/interpreter.js:255:17)
zwavejs2mqtt_1     |     at /usr/src/app/node_modules/xstate/lib/interpreter.js:125:23
zwavejs2mqtt_1     |     at Scheduler.process (/usr/src/app/node_modules/xstate/lib/scheduler.js:60:13)
zwavejs2mqtt_1     | 2021-01-11 09:38:23.352 INFO ZWAVE: Node 49 ready: ThermoFloor - Z-TRM2fx (Floor thermostat)
zwavejs2mqtt_1     | 2021-01-11 09:38:23.353 INFO ZWAVE: Node 49: interview completed, all values are updated
zwavejs2mqtt_1     | 2021-01-11 09:38:23.353 ERROR GATEWAY: Error while discovering device climate_thermostat of node 49: Cannot read property 'id' of undefined Cannot read property 'id' of undefined
zwavejs2mqtt_1     | TypeError: Cannot read property 'id' of undefined
zwavejs2mqtt_1     |     at Gateway.valueTopic (/usr/src/app/lib/Gateway.js:868:23)
zwavejs2mqtt_1     |     at Gateway.discoverDevice (/usr/src/app/lib/Gateway.js:1126:16)
zwavejs2mqtt_1     |     at /usr/src/app/lib/Gateway.js:360:40
zwavejs2mqtt_1     |     at Array.forEach (<anonymous>)
zwavejs2mqtt_1     |     at Gateway.onNodeStatus (/usr/src/app/lib/Gateway.js:360:17)
zwavejs2mqtt_1     |     at ZwaveClient.emit (events.js:314:20)
zwavejs2mqtt_1     |     at ZwaveClient.EventEmitter.emit (domain.js:483:12)
zwavejs2mqtt_1     |     at ZwaveClient.onNodeStatus (/usr/src/app/lib/ZwaveClient.js:247:10)
zwavejs2mqtt_1     |     at ZwaveClient.onNodeInterviewCompleted (/usr/src/app/lib/ZwaveClient.js:314:16)
zwavejs2mqtt_1     |     at ZWaveNode.emit (events.js:326:22)
zwavejs2mqtt_1     |     at ZWaveNode.EventEmitter.emit (domain.js:483:12)
zwavejs2mqtt_1     |     at ZWaveNode.interview (/usr/src/app/node_modules/zwave-js/src/lib/node/Node.ts:989:8)
zwavejs2mqtt_1     |     at Driver.interviewNode (/usr/src/app/node_modules/zwave-js/src/lib/driver/Driver.ts:860:10)

Expected behavior
An climate entity for each thermostat in HASS
Let me know how I can help! As this device already is present in hass/devices.js I'm all out of clues?

@jkaberg Could you try removing it from devices.js?

@jkaberg Could you try removing it from devices.js?

@robertsLando I tried that just now, and when I do zwavejs2mqtt hangs on the first Thermostat it starts to interview. Adding it back lets z2m start like normal

@robertsLando I tried that just now, and when I do zwavejs2mqtt hangs on the first Thermostat it starts to interview. Adding it back lets z2m start like normal

@jkaberg Are you using dev tag?

@jkaberg Are you using dev tag?

@robertsLando No, I'm building the container myself:
DOCKER_BUILDKIT=1 docker build --build-arg SRC=git-clone-src --build-arg Z2M_BRANCH=master --build-arg ZWJ_BRANCH=fix-ztrm2fx --no-cache -t zwavejs2mqtt .

@robertsLando No, I'm building the container myself:
DOCKER_BUILDKIT=1 docker build --build-arg SRC=git-clone-src --build-arg Z2M_BRANCH=master --build-arg ZWJ_BRANCH=fix-ztrm2fx --no-cache -t zwavejs2mqtt .

@jkaberg COuld you try to rebuild it now? Because I submitted a fix an hour ago about climate discovery that caused an infinite loop in some cases. So it may work now :)

@jkaberg COuld you try to rebuild it now? Because I submitted a fix an hour ago about climate discovery that caused an infinite loop in some cases. So it may work now :)

Sure, built now with (as the fix-ztrm2fx was merged to zwave-js master):
DOCKER_BUILDKIT=1 docker build --build-arg SRC=git-clone-src --build-arg Z2M_BRANCH=master --build-arg ZWJ_BRANCH=master --no-cache -t zwavejs2mqtt .
with compose:
  zwavejs2mqtt:
    image: zwavejs2mqtt
    restart: unless-stopped
    depends_on:
      - mosquitto
    security_opt:
      - seccomp:unconfined
    devices:
      - /dev/serial/by-id/usb-0658_0200-if00:/dev/ttyACM0
    volumes:
      - ${STORAGE_DIR}/zwavejs2mqtt:/usr/src/app/store
      - ./devices.js:/usr/src/app/hass/devices.js

and:
zwavejs2mqtt_1     | 2021-01-11 11:18:56.488 INFO GATEWAY: New climate device discovered: {"type":"climate","object_id":"climate","discovery_payload":{"min_temp":5,"max_temp":40,"temp_step":0.5,"modes":["off","heat","cool","auto"],"mode_state_topic":"64-1-mode","mode_state_template":"{{ value_json.value }}","mode_command_topic":"64-1-mode/set","current_temperature_topic":"49-2-Air temperature","current_temperature_template":"{{ value_json.value }}","temperature_state_topic":true,"temperature_state_template":"{{ value_json.value }}","temperature_command_topic":true},"values":["49-2-Air temperature","64-1-mode","67-1-setpoint-1","67-1-setpoint-2","67-1-setpoint-11"],"mode_map":{"off":0,"heat":1,"cool":2},"setpoint_topic":{"1":"67-1-setpoint-1","2":"67-1-setpoint-2","11":"67-1-setpoint-11"},"default_setpoint":"67-1-setpoint-1"}

And now they all exist in HASS 😄
So my local changes to hass/devices.js consists of removing these lines.

Sure, built now with (as the fix-ztrm2fx was merged to zwave-js master):
DOCKER_BUILDKIT=1 docker build --build-arg SRC=git-clone-src --build-arg Z2M_BRANCH=master --build-arg ZWJ_BRANCH=master --no-cache -t zwavejs2mqtt .
with compose:
  zwavejs2mqtt:
    image: zwavejs2mqtt
    restart: unless-stopped
    depends_on:
      - mosquitto
    security_opt:
      - seccomp:unconfined
    devices:
      - /dev/serial/by-id/usb-0658_0200-if00:/dev/ttyACM0
    volumes:
      - ${STORAGE_DIR}/zwavejs2mqtt:/usr/src/app/store
      - ./devices.js:/usr/src/app/hass/devices.js

and:
zwavejs2mqtt_1     | 2021-01-11 11:18:56.488 INFO GATEWAY: New climate device discovered: {"type":"climate","object_id":"climate","discovery_payload":{"min_temp":5,"max_temp":40,"temp_step":0.5,"modes":["off","heat","cool","auto"],"mode_state_topic":"64-1-mode","mode_state_template":"{{ value_json.value }}","mode_command_topic":"64-1-mode/set","current_temperature_topic":"49-2-Air temperature","current_temperature_template":"{{ value_json.value }}","temperature_state_topic":true,"temperature_state_template":"{{ value_json.value }}","temperature_command_topic":true},"values":["49-2-Air temperature","64-1-mode","67-1-setpoint-1","67-1-setpoint-2","67-1-setpoint-11"],"mode_map":{"off":0,"heat":1,"cool":2},"setpoint_topic":{"1":"67-1-setpoint-1","2":"67-1-setpoint-2","11":"67-1-setpoint-11"},"default_setpoint":"67-1-setpoint-1"}

And now they all exist in HASS 😄
So my local changes to hass/devices.js consists of removing these lines.

Perfect! Thanks :)

Perfect! Thanks :)


Refact/01

I've done some refactoring:

Each audio node has its own file
Modify the interface of AudioBuffer to better fit the specs
Add helper traits on AudioBuffer and ChannelData
Replace SampleRate(u32) with f32
float_eq crate is now in [dependencies] section
Modularize Graph::process and Graph::render

related to #30

I'm closing this pull request, sorry!
Some of your work has been implemented via other PRs, and we have some more tickets lined up to pick up the other issues: #30 and #50
Feel free to open more issues