Market : Notification

Send a notification with a discord webhook when a resource is published or updated really really practical for theme devs or for the public

Unfortunately this can’t be added without exposing our IPs address or provisioning additional resources, which we both want to avoid.
Themes developers are encouraged to have a GitHub repo for their theme, which supports Discord webhook (like we do on Azuriom Discord server, in the changelog channel)


Extra: fish shell syntax

Would be nice to have matching fish shell highlights for the GitHub theme. The shell theme applies to interactively typed commands (e.g. echo -e "Foo\nBar"), not the output of the terminal, which is covered by terminal themes of course.
I'm currently trying the light variant of github-nvim-theme and really like it so far. If you want, I could try creating at least a light variant and maybe extend from there to dark and the sub-variants. Unlike terminal colors, it's not quite so obvious how to display all the items that need to be styled.
Edit: just saw you're generating these from a script, for all variants. Would have to figure out good defaults first I guess, and then apply them across the board.

This turns out to be rather involved, and the fish documentation is not very instructive on how to trigger all these items. I've tried adding descriptions that should help. Some items already have a fitting default color, so could be left out in theory.
One good thing is that fish can use the terminal's palette, so one doesn't need to redefine all colors. For more control, that's possible however.
~/.config/fish/config.fish:
# Theme
source ~/.config/fish/themes/github.fish

~/.config/fish/theme/github.fish:
# GitHub Color palette
# (Taken from 'github-nvim-theme')
set -l comment 6a737d # Too dark?
set -l selection dbe9f9

# Shell highlight groups
# (https://fishshell.com/docs/current/interactive.html#variables-color)

set -g fish_color_normal brwhite  # Default text
set -g fish_color_command brwhite  # `cd`, `ls`, `echo`
# set -g fish_color_keyword red  # `if`   NOTE: default = fish_color_command
set -g fish_color_quote green  # "foo" in `echo "foo"`
# set -g fish_color_redirection magenta  # `>/dev/null`   NOTE: default = magenta
# set -g fish_color_end blue  # ; in `cmd1; cmd2`   NOTE: default = blue
# set -g fish_color_error red  # incomplete / non-existent commands   NOTE: default = red
set -g fish_color_param blue  # xvf in `tar xvf`, --all in `ls --all`
set -g fish_color_comment $comment  # `# a comment` # Question: Where does default come from if not set?
set -g fish_color_selection --background=$selection # Run `fish_vi_key_bindings`, type some text, <Esc> then `v` to select text
set -g fish_color_operator red  # * in `ls ./*`
# set -g fish_color_escape cyan  # \u2586 in `echo \u2586` NOTE: default = cyan
# set -g fish_color_autosuggestion $comment  # Appended virtual text, e.g. `cd  ` displaying `cd ~/some/path`
# set -g fish_color_search_match --background=red   # TODO: How to trigger?

set -g fish_pager_color_completion $fish_color_param # List of suggested items for `ls <Tab>`
set -g fish_pager_color_description green  # (command) in list of commands for `c<Tab>`
set -g fish_pager_color_prefix red --underline  # Leading 'c' in list of completions for `c<Tab>`
set -g fish_pager_color_progress brwhite  # '…and nn more rows' for `c<Tab>`
set -g fish_pager_color_selected_background --background=$selection # Cursor when <Tab>ing through `ls <Tab>`


Memory leak fix.

Fixed a memory leak I added accidentally in #12 and another one that already existed.

@dfirebaugh  Sorry about this


segfault in EquivalenceSet::record_partial_valid_instance

Seeing this segfault at 2 ranks, 6 total GPUs (it has a similar backtrace as the Fill view deletion bug we looked at last time @lightsighter).
(gdb) bt
#0  0x0000200004c7a114 in nanosleep () from /lib64/power9/libc.so.6
#1  0x0000200004c79f44 in sleep () from /lib64/power9/libc.so.6
#2  0x0000200001f36b08 in Realm::realm_freeze (signal=<optimized out>) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/realm/runtime_impl.cc:183
#3  <signal handler called>
#4  0x0000200000ad913c in Legion::Internal::LogicalView::add_valid_reference (this=0x205bcc06e6f0, cnt=<optimized out>) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_views.cc:162
#5  0x0000200000695108 in Legion::Internal::LogicalView::add_base_valid_ref (cnt=1, source=Legion::Internal::AGGREGATOR_REF, this=<optimized out>) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_views.h:2259
#6  Legion::Internal::CopyFillAggregator::record_view (this=<optimized out>, new_view=<optimized out>) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_analysis.cc:5133
#7  0x00002000006c5388 in Legion::Internal::CopyFillAggregator::record_instance_update (this=0x205b68053c60, dst_view=<optimized out>, src_view=0x205bcc06e6f0, src_man=0x205bcc06e968, src_mask=..., expr=0x205b7d73f8a0, tracing_eq=0x0, redop=<optimized out>, helper=0x0)
    at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_analysis.cc:4567
#8  0x00002000006c5600 in Legion::Internal::CopyFillAggregator::record_update (this=0x205b68053c60, dst_view=0x205b7dd8ece0, dst_man=<optimized out>, src_view=0x205bcc06e6f0, src_mask=..., expr=0x205b7d73f8a0, trace_info=..., tracing_eq=0x0, redop=0, helper=0x0)
    at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_analysis.cc:4549
#9  0x00002000006c5870 in Legion::Internal::CopyFillAggregator::record_updates (this=0x205b68053c60, dst_view=0x205b7dd8ece0, dst_man=0x201f6c077a80, src_views=..., src_mask=..., expr=0x205b7d73f8a0, trace_info=..., tracing_eq=0x0, redop=0, helper=0x0)
    at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_analysis.cc:4660
#10 0x00002000006ccfdc in Legion::Internal::EquivalenceSet::issue_update_copies_and_fills (this=0x205bcc05a120, target=0x205b7dd8ece0, target_manager=0x201f6c077a80, source_views=..., aggregator=@0x201f6806df40: 0x205b68053c60, previous_guard=0x0, analysis=0x205bd00723b0,
    track_events=<optimized out>, expr=0x205b7d73f8a0, expr_covers=false, update_mask=..., trace_info=..., redop=0, across_helper=0x0) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_analysis.cc:13807
#11 0x000020000070122c in Legion::Internal::EquivalenceSet::make_instances_valid (this=0x205bcc05a120, aggregator=@0x201f6806df40: 0x205b68053c60, previous_guard=0x0, analysis=0x205bd00723b0, track_events=<optimized out>, expr=0x205b7d73f8a0, expr_covers=<optimized out>,
    update_mask=..., target_instances=std::vector of length 1, capacity 1 = {...}, target_views=std::vector of length 1, capacity 1 = {...}, source_views=std::vector of length 0, capacity 0, trace_info=..., skip_valid_check=false, redop=0, across_helper=0x0)
    at /autofs/nccs-svm1_sw/summit/gcc/9.3.0-2/include/c++/9.3.0/bits/stl_vector.h:1058
#12 0x0000200000701df0 in Legion::Internal::EquivalenceSet::update_set_internal (this=<optimized out>, input_aggregator=<optimized out>, previous_guard=<optimized out>, analysis=<optimized out>, usage=..., expr=<optimized out>, expr_covers=<optimized out>, user_mask=...,
    target_instances=std::vector of length 1, capacity 1 = {...}, target_views=std::vector of length 1, capacity 1 = {...}, source_views=std::vector of length 0, capacity 0, trace_info=..., record_valid=true)
    at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_analysis.cc:13204
#13 0x0000200000702934 in Legion::Internal::EquivalenceSet::update_set (this=0x205bcc05a120, analysis=..., expr=0x205b7d73f8a0, expr_covers=<optimized out>, user_mask=..., deferral_events=..., applied_events=..., already_deferred=<optimized out>)
    at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_analysis.cc:11486
#14 0x0000200000703ba4 in Legion::Internal::UpdateAnalysis::perform_analysis (this=0x205bd00723b0, set=0x205bcc05a120, expr=0x205b7d73f8a0, expr_covers=<optimized out>, mask=..., deferral_events=std::set with 0 elements, applied_events=std::set with 0 elements,
    already_deferred=<optimized out>) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_analysis.cc:7234
#15 0x00002000006e9960 in Legion::Internal::EquivalenceSet::analyze (this=0x205bcc05a120, analysis=..., expr=0x205b7d73f8a0, expr_covers=<optimized out>, traversal_mask=..., deferral_events=std::set with 0 elements, applied_events=std::set with 0 elements,
    already_deferred=<optimized out>) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_analysis.cc:10472
#16 0x00002000006e9dec in Legion::Internal::PhysicalAnalysis::analyze (this=0x205bd00723b0, set=0x205bcc05a120, mask=..., deferral_events=std::set with 0 elements, applied_events=std::set with 0 elements, precondition=..., already_deferred=<optimized out>)
    at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_analysis.cc:5581
#17 0x00002000006e9f1c in Legion::Internal::PhysicalAnalysis::perform_traversal (this=0x205bd00723b0, precondition=..., info=..., applied_events=std::set with 0 elements) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_analysis.cc:5736
#18 0x00002000006ea274 in Legion::Internal::CollectiveCopyFillAnalysis::perform_traversal (this=0x205bd00723b0, precondition=..., version_info=..., applied_events=std::set with 0 elements)
    at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_analysis.cc:6491
#19 0x0000200000ba08dc in Legion::Internal::RegionTreeForest::physical_perform_updates (this=0x27349eb0, req=..., version_info=..., op=0x201edc02aee0, index=<optimized out>, precondition=..., term_event=..., targets=..., sources=..., trace_info=..., map_applied_events=...,
    analysis=<optimized out>, collective_rendezvous=<optimized out>, record_valid=<optimized out>, check_initialized=<optimized out>, defer_copies=<optimized out>) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/region_tree.cc:2147
#20 0x0000200000a6bd30 in Legion::Internal::SingleTask::map_all_regions (this=0x201edc02ad20, must_epoch_op=<optimized out>, defer_args=<optimized out>) at /autofs/nccs-svm1_sw/summit/gcc/9.3.0-2/include/c++/9.3.0/bits/stl_vector.h:1040
#21 0x0000200000a6cfe0 in Legion::Internal::PointTask::perform_mapping (this=<optimized out>, must_epoch_owner=<optimized out>, args=<optimized out>) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_tasks.cc:7321
#22 0x0000200000cb5c10 in Legion::Internal::Runtime::legion_runtime_task (args=0x2000480063b0, arglen=52, userdata=<optimized out>, userlen=<optimized out>, p=...) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/runtime.cc:31855
#23 0x0000200001f157b0 in Realm::LocalTaskProcessor::execute_task (this=0x272e2160, func_id=<optimized out>, task_args=...) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/realm/bytearray.inl:150
#24 0x0000200001f70310 in Realm::Task::execute_on_processor (this=0x200048006230, p=...) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/realm/bytearray.inl:39
#25 0x0000200001f70484 in Realm::KernelThreadTaskScheduler::execute_task (this=<optimized out>, task=<optimized out>) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/realm/tasks.cc:1366
#26 0x0000200001f73524 in Realm::ThreadedTaskScheduler::scheduler_loop (this=this@entry=0x272e23a0) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/realm/tasks.cc:1103
#27 0x0000200001f73d2c in Realm::ThreadedTaskScheduler::scheduler_loop_wlock (this=0x272e23a0) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/realm/tasks.cc:1217
#28 0x0000200001f77400 in Realm::KernelThread::pthread_entry (data=0x205bd4035280) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/realm/threads.cc:781
#29 0x0000200004578ae0 in start_thread () from /lib64/power9/libpthread.so.0
#30 0x0000200004cbe7c8 in clone () from /lib64/power9/libc.so.6

I can't reproduce on Sapling, only Summit. Please coordinate with me to get the debug information via GDB.

This shows up when I compile with -DLEGION_SPY.
Reproducer command (so I remember): GPUS=6 ARGS="-logfile $SCRATCH_DIR/spy-%.log" ./scripts/summit/run_legate_gmg.sh

p/x this->did in frame 4.

I got a different backtrace:
(gdb) bt
#0  0x0000200004c7a114 in nanosleep () from /lib64/power9/libc.so.6
#1  0x0000200004c79f44 in sleep () from /lib64/power9/libc.so.6
#2  0x0000200001f36b08 in Realm::realm_freeze (signal=<optimized out>) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/realm/runtime_impl.cc:183
#3  <signal handler called>
#4  0x0000000000000000 in ?? ()
#5  0x0000200000ad9148 in Legion::Internal::LogicalView::add_valid_reference (this=0x20004c14bee0, cnt=<optimized out>) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_views.cc:162
#6  0x00002000006810c4 in Legion::Internal::LogicalView::add_base_valid_ref (this=<optimized out>, source=<optimized out>, cnt=1) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_views.h:2259
#7  0x00002000006dcf3c in Legion::Internal::EquivalenceSet::record_partial_valid_instance (this=0x205138126410, target=<optimized out>, expr=0x205c00049780, valid_mask=..., check_total_valid=<optimized out>)
    at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_analysis.cc:12616
#8  0x000020000072bba0 in Legion::Internal::EquivalenceSet::record_instances<Legion::Internal::LogicalView> (this=0x205138126410, expr=0x205c00049780, expr_covers=<optimized out>, record_mask=..., target_insts=...)
    at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_utilities.h:2995
#9  0x0000200000700824 in Legion::Internal::EquivalenceSet::overwrite_set (this=0x205138126410, analysis=..., expr=0x205c00049780, expr_covers=<optimized out>, overwrite_mask=..., deferral_events=..., applied_events=..., already_deferred=<optimized out>)
    at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_analysis.cc:16172
#10 0x0000200000700e64 in Legion::Internal::OverwriteAnalysis::perform_analysis (this=<optimized out>, set=<optimized out>, expr=<optimized out>, expr_covers=<optimized out>, mask=..., deferral_events=..., applied_events=..., already_deferred=<optimized out>)
    at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_analysis.cc:8780
#11 0x00002000006e9960 in Legion::Internal::EquivalenceSet::analyze (this=0x205138126410, analysis=..., expr=0x205c00049780, expr_covers=<optimized out>, traversal_mask=..., deferral_events=std::set with 0 elements, applied_events=std::set with 0 elements,
    already_deferred=<optimized out>) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_analysis.cc:10472
#12 0x00002000006e9dec in Legion::Internal::PhysicalAnalysis::analyze (this=0x2051381241b0, set=0x205138126410, mask=..., deferral_events=std::set with 0 elements, applied_events=std::set with 0 elements, precondition=..., already_deferred=<optimized out>)
    at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_analysis.cc:5581
#13 0x00002000006f1408 in Legion::Internal::OverwriteAnalysis::handle_remote_overwrites (derez=..., runtime=<optimized out>, previous=<optimized out>) at /autofs/nccs-svm1_sw/summit/gcc/9.3.0-2/include/c++/9.3.0/bits/stl_vector.h:1040
#14 0x0000200000be9554 in Legion::Internal::Runtime::handle_equivalence_set_remote_overwrites (this=<optimized out>, derez=..., source=<optimized out>) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/runtime.cc:24963
#15 0x0000200000cb4898 in Legion::Internal::VirtualChannel::handle_messages (this=0x20004c000d70, num_messages=<optimized out>, runtime=0x1bc034c0, remote_address_space=<optimized out>, args=<optimized out>, arglen=<optimized out>)
    at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/runtime.cc:12742
#16 0x0000200000cb510c in Legion::Internal::VirtualChannel::process_message (this=0x20004c000d70, args=<optimized out>, arglen=666, runtime=0x1bc034c0, remote_address_space=<optimized out>) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/runtime.cc:11546
#17 0x0000200000cb548c in Legion::Internal::MessageManager::receive_message (this=<optimized out>, args=<error reading variable: value has been optimized out>, arglen=<optimized out>) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/runtime.cc:13207
#18 0x0000200000cb54ec in Legion::Internal::Runtime::process_message_task (this=<optimized out>, args=0x201ffc175cac, arglen=<optimized out>) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/runtime.cc:25930
#19 0x0000200000cb57a0 in Legion::Internal::Runtime::legion_runtime_task (args=0x201ffc175ca0, arglen=682, userdata=<optimized out>, userlen=<optimized out>, p=...) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/runtime.cc:31582
#20 0x0000200001f157b0 in Realm::LocalTaskProcessor::execute_task (this=0x1bba3630, func_id=<optimized out>, task_args=...) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/realm/bytearray.inl:150
#21 0x0000200001f70310 in Realm::Task::execute_on_processor (this=0x201ffc130550, p=...) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/realm/bytearray.inl:39
#22 0x0000200001f70484 in Realm::KernelThreadTaskScheduler::execute_task (this=<optimized out>, task=<optimized out>) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/realm/tasks.cc:1366
#23 0x0000200001f73524 in Realm::ThreadedTaskScheduler::scheduler_loop (this=this@entry=0x1bba3920) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/realm/tasks.cc:1103
#24 0x0000200001f73d2c in Realm::ThreadedTaskScheduler::scheduler_loop_wlock (this=0x1bba3920) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/realm/tasks.cc:1217
#25 0x0000200001f77400 in Realm::KernelThread::pthread_entry (data=0x20004c16cce0) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/realm/threads.cc:781
#26 0x0000200004578ae0 in start_thread () from /lib64/power9/libpthread.so.0
#27 0x0000200004cbe7c8 in clone () from /lib64/power9/libc.so.6

Getting the similar info:
(gdb) f 5
#5  0x0000200000ad9148 in Legion::Internal::LogicalView::add_valid_reference (this=0x20004c14bee0, cnt=<optimized out>) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_views.cc:162
162	        notify_valid();
(gdb) p/x this->did
$2 = 0x80000000000a633

that looks like a valid did

This looks identical to the previous bug. Are you sure you're using the most recent commit? If so, run with -DLEGION_GC capture the logs and print out the distributed ID of the problematic fill view.

Unfortunately it's the same bug (i'm on the most recent collective), but it's a different application. Here's the DID:
(gdb) bt
#0  0x0000200004c8a114 in nanosleep () from /lib64/power9/libc.so.6
#1  0x0000200004c89f44 in sleep () from /lib64/power9/libc.so.6
#2  0x0000200001f46b08 in Realm::realm_freeze (signal=<optimized out>) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/realm/runtime_impl.cc:183
#3  <signal handler called>
#4  0x0000200004be3618 in raise () from /lib64/power9/libc.so.6
#5  0x0000200004bc3a2c in abort () from /lib64/power9/libc.so.6
#6  0x00002000049f7e60 in __gnu_cxx::__verbose_terminate_handler () at ../../../../libstdc++-v3/libsupc++/vterminate.cc:95
#7  0x00002000049f51bc in __cxxabiv1::__terminate (handler=<optimized out>) at ../../../../libstdc++-v3/libsupc++/eh_terminate.cc:48
#8  0x00002000049f5274 in std::terminate () at ../../../../libstdc++-v3/libsupc++/eh_terminate.cc:58
#9  0x00002000049f68cc in __cxxabiv1::__cxa_pure_virtual () at ../../../../libstdc++-v3/libsupc++/pure.cc:50
#10 0x000020000067d5dc in Legion::Internal::DistributedCollectable::perform_downgrade (this=0x205b980f4e20, gc=...) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/garbage_collection.cc:836
#11 0x0000200000678954 in Legion::Internal::DistributedCollectable::process_downgrade_success (this=0x205b980f4e20, to_downgrade=<optimized out>) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/garbage_collection.cc:1168
#12 0x000020000067cf48 in Legion::Internal::DistributedCollectable::handle_downgrade_success (runtime=<optimized out>, derez=...) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/garbage_collection.cc:1192
#13 0x0000200000beb898 in Legion::Internal::Runtime::handle_did_downgrade_success (this=<optimized out>, derez=...) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/runtime.cc:24163
#14 0x0000200000cb8934 in Legion::Internal::VirtualChannel::handle_messages (this=0x200058000bd0, num_messages=<optimized out>, runtime=0x132e3600, remote_address_space=<optimized out>, args=<optimized out>, arglen=<optimized out>)
    at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/runtime.cc:12072
#15 0x0000200000cb9bec in Legion::Internal::VirtualChannel::process_message (this=0x200058000bd0, args=<optimized out>, arglen=32, runtime=0x132e3600, remote_address_space=<optimized out>) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/runtime.cc:11546
#16 0x0000200000cb9f6c in Legion::Internal::MessageManager::receive_message (this=<optimized out>, args=<error reading variable: value has been optimized out>, arglen=<optimized out>) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/runtime.cc:13207
#17 0x0000200000cb9fcc in Legion::Internal::Runtime::process_message_task (this=<optimized out>, args=0x20004c01e51c, arglen=<optimized out>) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/runtime.cc:25930
#18 0x0000200000cba280 in Legion::Internal::Runtime::legion_runtime_task (args=0x20004c01e510, arglen=48, userdata=<optimized out>, userlen=<optimized out>, p=...) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/runtime.cc:31582
#19 0x0000200001f257b0 in Realm::LocalTaskProcessor::execute_task (this=0x114d2130, func_id=<optimized out>, task_args=...) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/realm/bytearray.inl:150
#20 0x0000200001f80310 in Realm::Task::execute_on_processor (this=0x20004c01e390, p=...) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/realm/bytearray.inl:39
#21 0x0000200001f80484 in Realm::KernelThreadTaskScheduler::execute_task (this=<optimized out>, task=<optimized out>) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/realm/tasks.cc:1366
#22 0x0000200001f83524 in Realm::ThreadedTaskScheduler::scheduler_loop (this=this@entry=0x10cbd6d0) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/realm/tasks.cc:1103
#23 0x0000200001f83d2c in Realm::ThreadedTaskScheduler::scheduler_loop_wlock (this=0x10cbd6d0) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/realm/tasks.cc:1217
#24 0x0000200001f87400 in Realm::KernelThread::pthread_entry (data=0x205bac0a4250) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/realm/threads.cc:781
#25 0x0000200004588ae0 in start_thread () from /lib64/power9/libpthread.so.0
#26 0x0000200004cce7c8 in clone () from /lib64/power9/libc.so.6
(gdb) f 10
#10 0x000020000067d5dc in Legion::Internal::DistributedCollectable::perform_downgrade (this=0x205b980f4e20, gc=...) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/garbage_collection.cc:836
836	      notify_local();
(gdb) p/x this->did
$1 = 0x80000000000a815
(gdb)

Logs are in /home/rohany/gmg-spy-gc-*.log.
I also saw a run with this bt, if it helps:
(gdb) bt
#0  0x0000200004c8a114 in nanosleep () from /lib64/power9/libc.so.6
#1  0x0000200004c89f44 in sleep () from /lib64/power9/libc.so.6
#2  0x0000200001f46b08 in Realm::realm_freeze (signal=<optimized out>) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/realm/runtime_impl.cc:183
#3  <signal handler called>
#4  0x0000205c1804c2c0 in ?? ()
#5  0x00002000006c7a18 in Legion::Internal::CopyFillAggregator::record_update (this=0x205c1806a1f0, dst_view=0x205b980bf880, dst_man=<optimized out>, src_view=0x205c1c02d7b0, src_mask=..., expr=0x205b6021c880, trace_info=..., tracing_eq=0x0, redop=0, helper=0x0)
    at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_analysis.cc:4524
#6  0x00002000006c7c20 in Legion::Internal::CopyFillAggregator::record_updates (this=0x205c1806a1f0, dst_view=0x205b980bf880, dst_man=0x201fb4070450, src_views=..., src_mask=..., expr=0x205b6021c880, trace_info=..., tracing_eq=0x0, redop=0, helper=0x0)
    at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_analysis.cc:4660
#7  0x00002000006cf13c in Legion::Internal::EquivalenceSet::issue_update_copies_and_fills (this=0x205b91850060, target=0x205b980bf880, target_manager=0x201fb4070450, source_views=..., aggregator=@0x201fd6e8df00: 0x205c1806a1f0, previous_guard=0x0, analysis=0x205c1806e840,
    track_events=<optimized out>, expr=0x205b6021c880, expr_covers=false, update_mask=..., trace_info=..., redop=0, across_helper=0x0) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_analysis.cc:13807
#8  0x000020000070397c in Legion::Internal::EquivalenceSet::make_instances_valid (this=0x205b91850060, aggregator=@0x201fd6e8df00: 0x205c1806a1f0, previous_guard=0x0, analysis=0x205c1806e840, track_events=<optimized out>, expr=0x205b6021c880, expr_covers=<optimized out>,
    update_mask=..., target_instances=std::vector of length 1, capacity 1 = {...}, target_views=std::vector of length 1, capacity 1 = {...}, source_views=std::vector of length 0, capacity 0, trace_info=..., skip_valid_check=false, redop=0, across_helper=0x0)
    at /autofs/nccs-svm1_sw/summit/gcc/9.3.0-2/include/c++/9.3.0/bits/stl_vector.h:1058
#9  0x0000200000704540 in Legion::Internal::EquivalenceSet::update_set_internal (this=<optimized out>, input_aggregator=<optimized out>, previous_guard=<optimized out>, analysis=<optimized out>, usage=..., expr=<optimized out>, expr_covers=<optimized out>, user_mask=...,
    target_instances=std::vector of length 1, capacity 1 = {...}, target_views=std::vector of length 1, capacity 1 = {...}, source_views=std::vector of length 0, capacity 0, trace_info=..., record_valid=true)
    at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_analysis.cc:13204
#10 0x0000200000705084 in Legion::Internal::EquivalenceSet::update_set (this=0x205b91850060, analysis=..., expr=0x205b6021c880, expr_covers=<optimized out>, user_mask=..., deferral_events=..., applied_events=..., already_deferred=<optimized out>)
    at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_analysis.cc:11486
#11 0x00002000007062f4 in Legion::Internal::UpdateAnalysis::perform_analysis (this=0x205c1806e840, set=0x205b91850060, expr=0x205b6021c880, expr_covers=<optimized out>, mask=..., deferral_events=std::set with 0 elements, applied_events=std::set with 0 elements,
    already_deferred=<optimized out>) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_analysis.cc:7234
#12 0x00002000006ebf20 in Legion::Internal::EquivalenceSet::analyze (this=0x205b91850060, analysis=..., expr=0x205b6021c880, expr_covers=<optimized out>, traversal_mask=..., deferral_events=std::set with 0 elements, applied_events=std::set with 0 elements,
    already_deferred=<optimized out>) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_analysis.cc:10472
#13 0x00002000006ec3ac in Legion::Internal::PhysicalAnalysis::analyze (this=0x205c1806e840, set=0x205b91850060, mask=..., deferral_events=std::set with 0 elements, applied_events=std::set with 0 elements, precondition=..., already_deferred=<optimized out>)
    at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_analysis.cc:5581
#14 0x00002000006ec4dc in Legion::Internal::PhysicalAnalysis::perform_traversal (this=0x205c1806e840, precondition=..., info=..., applied_events=std::set with 0 elements) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_analysis.cc:5736
#15 0x00002000006ec834 in Legion::Internal::CollectiveCopyFillAnalysis::perform_traversal (this=0x205c1806e840, precondition=..., version_info=..., applied_events=std::set with 0 elements)
    at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_analysis.cc:6491
#16 0x0000200000ba405c in Legion::Internal::RegionTreeForest::physical_perform_updates (this=0x267bb1b0, req=..., version_info=..., op=0x200054003590, index=<optimized out>, precondition=..., term_event=..., targets=..., sources=..., trace_info=..., map_applied_events=...,
    analysis=<optimized out>, collective_rendezvous=<optimized out>, record_valid=<optimized out>, check_initialized=<optimized out>, defer_copies=<optimized out>) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/region_tree.cc:2147
#17 0x0000200000a6ef30 in Legion::Internal::SingleTask::map_all_regions (this=0x2000540033d0, must_epoch_op=<optimized out>, defer_args=<optimized out>) at /autofs/nccs-svm1_sw/summit/gcc/9.3.0-2/include/c++/9.3.0/bits/stl_vector.h:1040
#18 0x0000200000a701e0 in Legion::Internal::PointTask::perform_mapping (this=<optimized out>, must_epoch_owner=<optimized out>, args=<optimized out>) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/legion_tasks.cc:7321
#19 0x0000200000cba6f0 in Legion::Internal::Runtime::legion_runtime_task (args=0x205c14077d20, arglen=52, userdata=<optimized out>, userlen=<optimized out>, p=...) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/legion/runtime.cc:31855
#20 0x0000200001f257b0 in Realm::LocalTaskProcessor::execute_task (this=0x26753000, func_id=<optimized out>, task_args=...) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/realm/bytearray.inl:150
#21 0x0000200001f80310 in Realm::Task::execute_on_processor (this=0x205c14077ba0, p=...) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/realm/bytearray.inl:39
#22 0x0000200001f80484 in Realm::KernelThreadTaskScheduler::execute_task (this=<optimized out>, task=<optimized out>) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/realm/tasks.cc:1366
#23 0x0000200001f83524 in Realm::ThreadedTaskScheduler::scheduler_loop (this=this@entry=0x26753240) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/realm/tasks.cc:1103
#24 0x0000200001f83d2c in Realm::ThreadedTaskScheduler::scheduler_loop_wlock (this=0x26753240) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/realm/tasks.cc:1217
#25 0x0000200001f87400 in Realm::KernelThread::pthread_entry (data=0x205c1c018b60) at /autofs/nccs-svm1_home1/rohany/nvidia/legate.core/legion/runtime/realm/threads.cc:781
#26 0x0000200004588ae0 in start_thread () from /lib64/power9/libpthread.so.0
#27 0x0000200004cce7c8 in clone () from /lib64/power9/libc.so.6

Pull and try again. If it fails again, then do the same thing with the logs and the distributed ID.


Create tunnel symbol

Will support BLRI Live map development.

@mtaylorlong already completed this! Organizing issues to keep artwork linked to specific releases moving forward.


Bandwidth metrics per source and per session

Bandwidth metrics per source and per session. Available as Prometheus-compatible metrics.
We are currently working on metrics system and have found out, that there are no metrics on rtsp-proxy level to calculate bandwidth of source and outgoing bandwidth per session.
This is required to properly handle network problems and find the weak spot.

This would be amazing! 😌

Hi @aler9, any plans in near future?

bandwidth metrics are now fully implemented in main and will be available in the next release

take a look at the README for usage:
https://github.com/aler9/rtsp-simple-server#metrics


Windows 10, NVIDIA Broadcast, fails to initialize microphone?

A friend has experienced the following bug:
When NVIDIA Broadcast is enabled and the library is imported her microphone stops working until she changes her audio device in some program. For example, setting it from NVIDIA Broadcast to NVIDIA Broadcast in Discord. This is not discord specific; no program on her machine records audio until she goes from NVIDIA Broadcast to NVIDIA Broadcast is Discord or Windows Audio Settings. After she disabled NVIDIA Broadcast the problem disappeared.
I understand this is fairly vague. It's code I wrote, she's not a programmer, and I don't have this software. What should I send her to gather more information for this?

I would suggest what I'm suggesting in many issues here: let them try a few things and let them report back. And hope that their response gives you more ideas what they could try, and so on ...
I understand this is fairly vague.
Having some of the information mentioned at https://python-sounddevice.readthedocs.io/en/0.4.1/CONTRIBUTING.html#reporting-problems would probably help?

Sorry, I wrote this in frustration in the early AM. I was hoping for a quick "Oh I've seen something like this before, do xyz" or "Sorry, we're waiting on a fix from portaudio" or somesuch. After sleeping on it I had some ideas and am unable to recreate the problem on my own computer, even after installing the same software. So I'll try a few things and have her report back.

@TomatoCo I am getting an issue where even just importing sounddevice will cause discord (but not chrome) to no longer produce audio. The microphone works perfect. This continues until I close or open broadcast (whichever it wasn't at the time of importing). Did you ever find more info on this?


DO NOT MERGE! Fast Forward stable to 87cff0e4ced48cf74abc75268d02c67bec47121a.

This PR will be merged automatically once checks are successful.

Jenkins job auth/postsubmit passed


Error on getting chart data using DataCube

When calling this DataCube.get('chart.data') it's throwing:
TypeError: Cannot read property 'locked' of undefined.

When i call only DataCube.get('chart') i can see that the structure of the array is:

Could it be due to the id coming as  chart.undefined?! What could be missing during initialization?

How do you initialise DC ? Could you post a minimal example here (with your data sample). It looks like the type is missing: https://github.com/C451/trading-vue-js/blob/master/src/helpers/dc_core.js#L94
Plus, there is no data prop when you call DataCube.get('chart')

Apparently was initializing it wrong.  Seems I had to do new DataCube({chart: data}). I was only filling ohlcv and initializing it like new DataCube(data). So fixed it now.
Thanks for fast reply and this great job you've done.

Hi,I have similar problem with this.
Error shows blow:
Uncaught TypeError: Cannot read property 'filter' of undefined
at DataCube.query_search (dc_core.js:322)
at DataCube.get_by_query (dc_core.js:290)
at DataCube.get (datacube.js:64)
at VueComponent.keydown (Toolbar.vue?./node_modules/babel-loader/lib!./node_modules/vue-loader/lib??vue-loader-options:77)
my code making error: let dc = new DataCube()
dc.get('.')
codes and data just use 101 project's.


Can't provision windows server in a vpc

I'm sure I'm just doing something wrong, but when I try to provision a windows instance in a VPC I can't connect. I just get endless: been waiting 30/120 etc... log statments.
Here's the provisioning code:
include_recipe "provision-vpc"
include_recipe "provision-iis::setup-options"
include_recipe "provision-iis::setup-ssh-keys"

aws_security_group "iis-security-group" do
  inbound_rules '<IP_ADDRESS>/0' => [22, 443, 80, 3389]
  outbound_rules [0..65535]         => '<IP_ADDRESS>/0'
  vpc "public-vpc"
end

machine 'test-iis' do
  add_machine_options :bootstrap_options => {
    :subnet => 'public-subnet',
    :security_group_ids => ['iis-security-group'],
    :associate_public_ip_address => true
    }

  recipe 'provision-iis::setup-site'
end

And here's the code provisioning the subnet (yes, I'll fix the terrible security practices once it's working)
aws_route_table 'public-routes' do
  vpc public_vpc
  routes '<IP_ADDRESS>/0' => :internet_gateway
end

aws_subnet "public-subnet" do
  vpc public_vpc
  cidr_block "<IP_ADDRESS>/24"
  route_table "public-routes"
  availability_zone "eu-west-1a"
  map_public_ip_on_launch true
end

The machine has a few extra machine options that are global:
                      'ssh_username' => 'windows',
                      'is_windows' => true,
                      'use_private_ip_for_ssh' => false,
                      'bootstrap_options' => {
                                             'key_name' => 'chefTest',
                                             'image_id' => 'ami-5d62ff2a',
                                             'instance_type' => 't2.small'
                                            }

I can provision linux machines in the same subnet, so the routing etc... all seems to be working. (And I can RDP onto the instances too, using the chefTest key). Is there something specific about windows machines that I'm missing?

Never mind, I was opening the wrong ports for WinRM - I just needed to add 5985 and 5986 to the inbound_rules.


grpc - v1.43 - segmentation fault on "grpc_socket_mutator_mutate_fd"

For an application, I upgraded grpc libraries from v1.36 to 1.43 via source.
After an upgrade, I started getting a segmentation fault with following trace.
(gdb) bt
#0  0x00007ffff69b81d8 in typeinfo for std::invalid_argument () from /opt/sdk/lib64/libstdc++.so.6
#1  0x0000000002675de7 in grpc_socket_mutator_mutate_fd(grpc_socket_mutator*, int, grpc_fd_usage) ()
#2  0x0000000002676d3b in grpc_set_socket_with_mutator(int, grpc_fd_usage, grpc_socket_mutator*) ()
#3  0x000000000267787a in grpc_tcp_client_prepare_fd(grpc_channel_args const*, grpc_resolved_address const*, grpc_resolved_address*, int*) ()
#4  0x0000000002677eec in tcp_connect(grpc_closure*, grpc_endpoint**, grpc_slice_allocator*, grpc_pollset_set*, grpc_channel_args const*, grpc_resolved_address const*, long) ()
#5  0x0000000002795c0e in grpc_core::Chttp2Connector::Connect(grpc_core::SubchannelConnector::Args const&, grpc_core::SubchannelConnector::Result*, grpc_closure*)
    ()
#6  0x000000000263dcf3 in grpc_core::Subchannel::ContinueConnectingLocked() ()
#7  0x000000000263dee1 in grpc_core::Subchannel::AttemptToConnect() ()
#8  0x000000000270f965 in grpc_core::(anonymous namespace)::PickFirst::AttemptToConnectUsingLatestUpdateArgsLocked() ()
#9  0x00000000027100f8 in grpc_core::(anonymous namespace)::PickFirst::UpdateLocked(grpc_core::LoadBalancingPolicy::UpdateArgs) ()
#10 0x0000000002626f40 in grpc_core::ChildPolicyHandler::UpdateLocked(grpc_core::LoadBalancingPolicy::UpdateArgs) ()
#11 0x000000000261b413 in grpc_core::ClientChannel::CreateOrUpdateLbPolicyLocked(grpc_core::RefCountedPtr<grpc_core::LoadBalancingPolicy::Config>, std::optional<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > const&, grpc_core::Resolver::Result) ()
#12 0x000000000261c0e7 in grpc_core::ClientChannel::OnResolverResultChangedLocked(grpc_core::Resolver::Result) ()
#13 0x0000000002623754 in grpc_core::ClientChannel::ResolverResultHandler::ReturnResult(grpc_core::Resolver::Result) ()
#14 0x0000000002769938 in grpc_core::(anonymous namespace)::AresDnsResolver::OnResolvedLocked(grpc_error*) ()
#15 0x0000000002680e5a in grpc_core::WorkSerializer::WorkSerializerImpl::Run(std::function<void ()>, grpc_core::DebugLocation const&) ()
#16 0x0000000002680fc8 in grpc_core::WorkSerializer::Run(std::function<void ()>, grpc_core::DebugLocation const&) ()
#17 0x0000000002767516 in grpc_core::(anonymous namespace)::AresDnsResolver::OnResolved(void*, grpc_error*) ()
#18 0x0000000002670684 in grpc_core::ExecCtx::Flush() ()
#19 0x00000000026c88b7 in grpc_call_start_batch ()
#20 0x000000000217f08a in grpc::internal::CallOpSet<grpc::internal::CallOpSendInitialMetadata, grpc::internal::CallNoOp<2>, grpc::internal::CallNoOp<3>, grpc::internal::CallNoOp<4>, grpc::internal::CallNoOp<5>, grpc::internal::CallNoOp<6> >::ContinueFillOpsAfterInterception (this=0x7fffcbb68cf0)
    at /opt/sdk/include/grpcpp/impl/codegen/call_op_set.h:971
#21 0x000000000217ee60 in grpc::internal::CallOpSet<grpc::internal::CallOpSendInitialMetadata, grpc::internal::CallNoOp<2>, grpc::internal::CallNoOp<3>, grpc::internal::CallNoOp<4>, grpc::internal::CallNoOp<5>, grpc::internal::CallNoOp<6> >::FillOps (this=0x7fffcbb68cf0, call=0x7fffcaee3298)
    at /opt/sdk/include/grpcpp/impl/codegen/call_op_set.h:901
#22 0x0000000000808b79 in grpc::internal::Call::PerformOps (this=0x7fffcaee3298, ops=0x7fffcbb68cf0)
    at /opt/sdk/include/grpcpp/impl/codegen/call.h:68

I have verified the connections with sockets, which seems to work fine.
Any pointers or references to Track down the problems here and solutions ?!
Version of gRPC and language :   1.43 (issue occurs post 1.39)  C++
OS : Linux CentOS
gcc version 10.2.0 (GCC)
What did you do?
Build an C++ client against the 1.43 version of GRPC library.

This one smells a bit odd. Does it fail that way every time you run it, or occasionally (maybe with other errors)? One hypothesis: grpc_socket_mutator_mutate_fd had an API change in 1.39, so I'm wondering if you're building the application against 1.43 headers but linking against an older library. Otherwise, it would help to see a minrepro, and to see how you're building gRPC and the application.

Closing due to lack of response.


Add option to show original component names

As requested in #239

I think this should be moved in the future in some kind of settings panel but looks good imo:


#56: update navigation bar

Closes: #56

@DMCFA I've made some changes, please check it

closes #50 with new layout


Add Iterable.generate, fix List.generate

added Iterable.generate support
fixed List.generate

Resolves https://github.com/ethanblake4/dart_eval/issues/91

Looks good after you remove that settings file

Merged, thank you! :)
FYI if you're planning to work on other issues you should use the new v0.7.0 branch as a base, it has a lot of changes.


Fix ethereum-cryptography bip39 imports

The latest version of ethereum-cryptography has moved some files around and so when using this engine in another project it currently fails with Error: Cannot find module '.../node_modules/ethereum-cryptography/bip39.js'.
Tests in this package were working because yarn.lock is locking ethereum-cryptography to 2.0.0, but if anyone npm installs this package they'll get 2.1.1 because of the ^ flag in package.json.

They might fix this downstream too, see https://github.com/ethereum/js-ethereum-cryptography/pull/87, which fixed other imports but not bip39.

Fixed with https://github.com/ethereum/js-ethereum-cryptography/pull/89/


Adding 2018-02-01 Traffic Manager API version.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[ ] The title of the PR is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[ ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[ ] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[ ] I have read the contribution guidelines.
[ ] My spec meets the review criteria:

[ ] The spec conforms to the Swagger 2.0 specification.
[ ] The spec follows the guidelines described in the Swagger checklist document.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

@fearthecowboy : This references this PR https://github.com/Azure/azure-rest-api-specs-pr/pull/395

Automation for azure-sdk-for-node

Automation for azure-libraries-for-java

Automation for azure-sdk-for-python

Automation for azure-sdk-for-go

@dsgouda  @hrkulkarMsft  unfortunately February branch contribution is hold many months ago. Unfortunately we do not accept such tricks here.
Also no need to push changes dierctly in master - please use Network-2018-05-01 branch and 2018-05-01 branch only to push changes.
Details and scenarios are able by [link](https://microsoft.sharepoint.com/teams/WAG/AzureNetworking/_layouts/OneNote.aspx?id=%2Fteams%2FWAG%2FAzureNetworking%2FOneNotes%2FNRP migrated&wd=target(Hydra %2B SDK.one|96F7B95B-A378-4CA5-903B-C88F894873EF%2FSwagger -> SDK -> PowerShell|71B816ED-DAE5-4907-94D8-DE7EE13278A0%2F)
onenote:https://microsoft.sharepoint.com/teams/WAG/AzureNetworking/OneNotes/NRP migrated/Hydra + SDK.one#Swagger -> SDK -> PowerShell&section-id={96F7B95B-A378-4CA5-903B-C88F894873EF}&page-id={71B816ED-DAE5-4907-94D8-DE7EE13278A0}&end)

Thanks @MikhailTryakhov
This is a little confusing
@hrkulkarMsft does your RP have anything to do with Microsoft.Network? If yes, why is it under its own directory in the repo, if not, why is it named as trafficmanager\Microsoft.Network
We need to make sure the changes you are making here are valid.


feature/shows the currentSearch term after user searches (by typing or clicking)

Description
Changed the "Search Directory" to be stateful so that the user is reinforced of their search query.
Video
Type of change

[X] New feature (non-breaking change which adds functionality)

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have removed unnecessary comments/console logs from my code
[X] I have made corresponding changes to the documentation if necessary (optional)
[X] My changes generate no new warnings
[X] I have checked my code and corrected any misspellings
[X] No duplicate code left within changed files
[X] Size of pull request kept to a minimum
[X] Pull request description clearly describes changes made & motivations for said changes

@Klove-A yeah the headerStyles is text-align: center so I think once we merge the branch that Allison worked on, it should look a lot better

@Klove-A nevermind it is not centered. I will find the right div and get it sorted


Extract Original Drug Indications

It seems that the "outcomes" of a particular drug include the "indications" that it was originally prescribed for. Is there a best-practices of removing the prescribed indications of a drug from the list of side-effects/outcomes for that drug?
For example, the top outcomes for the drug 'Imatinib' (drug_concept_id: 1304107) are: Death,  Nausea, Diarrhoea, Vomiting, Malignant neoplasm progression, Anaemia, Pyrexia, Fatigue, Dyspnoea, Neoplasm malignant, Rash, Oedema peripheral, Chronic myeloid leukaemia. 'Chronic myeloid leukaemia' is an indication for which the drug Imatinib is often used, however it is often listed as an outcome (case_count: 616 in 'standard_drug_outcome_statistics' table).
I've tried filtering this using the 'standard_case_indication' table. However, I get the opposite problem: outcomes often show up as indications. For example, the top indications for 'Imatinib' include Nausea (187 counts), Anxiety (186 counts), Vomiting (98 counts), which look like outcomes to me.
I've included the SQL queries I'm using below. I'm hoping I'm simply querying the database wrong? Maybe I'm getting all symptoms/indications for which these patients were treated, not just indications specific for imatinib? Is there a way to get the drug's specific indications? Thanks in advance.
Extracting outcomes for imatinib
SELECT aeolus.standard_drug_outcome_statistics.*,
drug_concept.vocabulary_id AS 'drug_vocabulary',
drug_concept.concept_code AS 'drug_concept_code',
drug_concept.concept_name AS 'drug_name',
outcome_concept.vocabulary_id AS 'outcome_vocabulary',
outcome_concept.concept_code AS 'outcome_concept_code',
outcome_concept.concept_name AS 'outcome_name'
FROM aeolus.standard_drug_outcome_statistics
    LEFT JOIN concept AS drug_concept ON aeolus.standard_drug_outcome_statistics.drug_concept_id=aeolus.drug_concept.concept_id
    LEFT JOIN concept AS outcome_concept ON aeolus.standard_drug_outcome_statistics.outcome_concept_id=aeolus.outcome_concept.concept_id
WHERE drug_concept_id = 1304107
order by -case_count
LIMIT 10000;

Extracting indications for imatinib
SELECT indi_pt, count(indi_pt) FROM aeolus.standard_case_indication
 LEFT JOIN aeolus.standard_drug_outcome_drilldown ON aeolus.standard_drug_outcome_drilldown.primaryid=aeolus.standard_case_indication.primaryid
 LEFT JOIN aeolus.concept ON aeolus.standard_drug_outcome_drilldown.drug_concept_id=aeolus.concept.concept_id
WHERE drug_concept_id = 1304107
group by indi_pt;

https://github.com/SuLab/biothings.drugs/issues/6

Hi @stuppie
Each indication on the FAERS case should also be linked to the associated drug on the case using the indication table indi_drug_seq and the case drug table drug_seq columns.
You may also want to limit the indications to those associated with the case primary suspect ('PS') drug and not include the indications associated with any secondary suspect drug or concomitant medications.
So your example for extracting indications for imatinib would look like this:
SELECT indi_pt, count(indi_pt)
FROM aeolus.standard_case_indication
LEFT JOIN aeolus.standard_case_drug ON aeolus.standard_case_drug.primaryid = aeolus.standard_case_indication.primaryid
AND aeolus.standard_case_indication.indi_drug_seq = aeolus.standard_case_drug.drug_seq
LEFT JOIN aeolus.concept ON aeolus.standard_case_drug.standard_concept_id = aeolus.concept.concept_id
WHERE aeolus.standard_case_drug.role_cod = ('PS')
AND aeolus.concept.concept_id = 1304107
GROUP BY indi_pt
ORDER BY count(indi_pt) DESC;

Also consider applying a cut-off using either top N results with the order by count desc or filter where count > N. I ran the above SQL for a couple of other drugs and some of the FAERS indications that I saw with lower counts didn't look like accurate drug indications.


F/support pester 5

Pull Request (PR) description

@johlju Two fixes for pester 3 #1550
This Pull Request (PR) fixes the following issues

Fixes SqlRole
Fixes SqlTraceFlag

Task list

[ ] Added an entry to the change log under the Unreleased section of the
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
[ ] Resource documentation updated in the resource's README.md.
[ ] Resource parameter descriptions updated in schema.mof.
[ ] Comment-based help updated, including parameter descriptions.
[ ] Localization strings updated.
[ ] Examples updated.
[X] Unit tests updated. See DSC Community Testing Guidelines.
[ ] Integration tests updated (where possible). See DSC Community Testing Guidelines.
[ ] Code changes adheres to DSC Community Style Guidelines.

This change is

Can you try to rebase the PR against my fork. In your local branch do:
git fetch origin f/support-pester-5
git rebase origin/f/support-pester-5

When everything looks okay. Make sure your changes (commit) to the tests are still there, run
# This will overwrite the commits in the branch in your fork.
git push my --force

Was already trying to do that, but your example made it a lot simpler.
i sometimes get really confused with all the git therms

Appreciate your help! 😃  I'm working on a blog post. I think I can push a draft later today. I will link to it then. 🙂

First draft. Didn't come as far as I hoped, but continue tomorrow. Hopefully it is to some help: https://github.com/dsccommunity/dsccommunity.org/blob/98c4e19b5356e6b3afccb488c3f90f10f90d01db/content/blog/convert-tests-to-pester5-for-dsc-community-repository.md

Almost done, new draft here as the URL changes for each push: https://github.com/dsccommunity/dsccommunity.org/blob/75a808da985c3784358c521525d9e88d443f66d6/content/blog/convert-tests-to-pester5-for-dsc-community-repository.md

Now the blog is posted https://dsccommunity.org/blog/convert-tests-to-pester5-for-dsc-community-repository/

Now the blog is posted https://dsccommunity.org/blog/convert-tests-to-pester5-for-dsc-community-repository/

I'm closing this as they have now been converted in the PR https://github.com/dsccommunity/SqlServerDsc/pull/1550.


GNOME's Archive Manager (file-roller) can't handle zip files by default [missing p7zip dep]

Describe the bug
When opening a zip file, file-roller can't show the content, and can't extract it
To Reproduce
Install GNOME
Expected behavior
File-roller can open the most common archive format without people having to go fishing in nixpkgs
Additional context
Possible solution: add p7zip in depends
Notify maintainers
@hedning
@jtojnar
Metadata

system: "x86_64-linux"
host os: Linux 5.4.109, NixOS, 20.09.3774.a6847cb5460 (Nightingale)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.10
channels(root): "nixos-20.09.3774.a6847cb5460, nixpkgs-git"
channels(afontain): ""
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

The problem seems to exist on master too.
Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute: [ file-roller ]

This is an upstream bug. We have applied a work around in https://github.com/NixOS/nixpkgs/commit/b209b81d7aeea27db4ee94a7588f4a153e74c949.

Hmm, if we have a workaround for the next stable, and there is a manual workaround on current stable, I guess we can close this? Or do we want to backport the workaround? I don't know how long-lived NixOS releases are.

Usually EOL a month after the release of next one. If someone wants to backport this, feel free but personally, I would not bother.


migrate NuGetGallery.Core.Facts to sdk csproj

@SimonCropp
Sorry, this one got merge conflict now.

Could you please address my comment above? If you are unable to work on this anytime soon, please close the and reopen it later when it's ready.


Update chainrulescore.jl

Fixes #150 https://github.com/avik-pal/Lux.jl/issues/92

Thanks for this, @MilkshakeForReal!

Could you tag it?


Magic comments to skip the CI

Describe your issue.
It'd be helpful to have magic incantations to skip (parts of the) CI listed somewhere (in the devguide?). Probably best have them listed by the provider --- our current CI has GHA, Azure, CircleCI, and it's not immediately clear how to e.g. skip a battery of 1.5hr test runs for a doc change.

Documented here: https://scipy.github.io/devdocs/dev/contributor/continuous_integration.html#skipping

Thanks Tirth, this settles it!
The only remaining enhancement request is then to spell out if these comments work if placed in the PR comment not the commit message?

The only remaining enhancement request is then to spell out if these comments work if placed in the PR comment not the commit message?

No, these only work in commit messages. Not sure if it's worth adding them in the PR description since we might want some commits to run the CI and some commit to skip the CI.


Feat/yield2

@0xcodercrane do you have an update on this?

@0xcodercrane do you have an update on this?

yes. I guess the remaining stuff is to refactor structure, resolve conflicts and merge.


spec_test_on_nuttx.yml: enable xip

related changes:
https://github.com/bytecodealliance/wasm-micro-runtime/pull/3662
https://github.com/bytecodealliance/wasm-micro-runtime/pull/3666


Enhancement request: Ability to specify working directory for Pester task

Azure DevOps Extension you are using
richardfennellBM.BM-VSTS-PesterRunner-Task.Pester-Task.Pester@8 (public, unmodified version)
Where are you running it?

Azure DevOps Service

Version of Extension/Task
richardfennellBM.BM-VSTS-PesterRunner-Task.Pester-Task.Pester@8 (public, unmodified version)
Expected behaviour and actual behaviour
I have Pester tests that I need to pass path parameters to it. I use the hashtable syntax using the scriptFolder property to pass those. Because of this I have to pre-pend $(Build.SourcesDirectory\Path), which makes the parameters line very long in yaml.
It would be nice if there was a workingDirectory property that specified from which folder Invoke-Pester gets called.
cc @ChrisLGardner

Tracking this over at https://github.com/pester/AzureDevOpsExtension/issues/9


Hiding some attributes and methods from user end

This can be simply achieved by defining methods/properties by passing Hidden key as true, without changing access permissions. Once we decide which ones are going to be shown, I can modify definitions.

Is this to make the overall GUI more user-friendly? Maybe one idea could be to have a "basic" and "advanced" mode available, where basic would have several things hidden as you mentioned, and advanced would show all of the available ones.

It is more to make CLI more user friendly. When dot operation is used, users can see only those related to them.
Other attributes will still be there. For example, If one types Model.tf, still can access the field. I think help section can be complementary at this point. Otherwise it will require conditional object instantiation, I am not sure if this is possible in Matlab.

Ok! Could you expand on what are some example methods/properties you think should be hidden from the GUI for certain models?

For example (qMT_bSSFP), methods like GetProt, GetFitopt equation and attributes like buttons, xnames fit. @tanguyduval has the complete vision on this.

Oh sorry I understand now - by CLI you meant command line interface, sorry I got confused!

hide buttons property
hide all methods that are not described in qMRusage

xnames is informative, but shouldn't be modified by the user. Idem for voxelwise.


Removed fastlane rake tasks #trivial

No description provided.

          1 Error

:no_entry_sign:
Please provide a summary in the Pull Request description

  Generated by :no_entry_sign: danger

👍


Add more cases to comprehensive parser test.  Mainly for -- .

Another argument parsing library had a problem with -- after --, here I add extra data to test that and various other edge cases in your comprehensive parser test.

@geophree Thanks!
So you just want to expand the "short-circuit option parsing" test data to make sure we don't regress on handling -- after -- in the future?
Not sure this provides a whole lot of value, but I'll buy it for a dollar. LGTM :+1: Thanks!

Yep, that's exactly it.  Your test suite is pretty comprehensive, I figured I'd push it a little closer to "completely" comprehensive.  As I mentioned, another command parser (who shall remain nameless) had a problem with this case.  I submitted a PR to fix their implementation & test as well.  Thanks for making such an awesome arg parsing library!

Ahh, gotcha. Nice work!
Most of the credit for yargs goes to @bcoe, @substack, and @chevex. Indeed, they have built an awesome library. I'm just along for the ride. :wink:
Thanks, again, for contributing back!

@geophree thanks for the contribution and kind words \o/ :tada:
There's nothing better in OSS then having someone add test cases for you.


Link option with title

We can now add a title for links

Instead of prompting for a title can we get the title from the text that the user has highlighted and if no text is selected then just use the URL?  Eventually I want to have a small modal popup like google docs.

Ok with your suggestions. I did this very quickly to fit my needs ;)

how i can set title inside  tag like original text.
I dont want to replace original text. How i can?
thanks


[RayJob] Update the workload status when suspended

What would you like to be added:
When job(rayjob specifically) is suspended transferred from running, the workload status return from kubectl get workload -o wide still marked as Admitted, see
NAME                      QUEUE     ADMITTED BY       AGE
rayjob-rayjob-low-fb3cd   queue-1   cluster-queue-1   29m

Should we update the status synchronously?
Why is this needed:
Completion requirements:
This enhancement requires the following artifacts:

[ ] Design doc
[ ] API change
[ ] Docs update

The artifacts should be linked in subsequent comments.

I guess this is a bug because batch job is worked as expected.
/remove-kind feature
/kind bug


Production issue - Foundation -[NSConcreteFileHandle readDataUpToLength:error:]

Describe your environment

Xcode version: 11.6
Firebase SDK version: 10.1.0
Installation method: CocoaPods (select one)
Firebase Component: Crashlytics, Dynamic Links

Describe the problem
This is crash happening in production ios app detected in crashlytics.
Steps to reproduce:
Unable to reproduce in local enviornment.
Firebase Crashlytics log
Fatal Exception: NSFileHandleOperationException
*** -[NSConcreteFileHandle writeData:]: Operation not permitted

Fatal Exception: NSFileHandleOperationException
0  CoreFoundation                 0x1acd659d4 __exceptionPreprocess
1  libobjc.A.dylib                0x1c0716b54 objc_exception_throw
2  Foundation                     0x1adfbdfec -[NSConcreteFileHandle readDataUpToLength:error:]
3  Foundation                     0x1adf514b0 -[NSConcreteFileHandle writeData:]
4  AcousticMobilePush             0x106b19374 (Missing)
5  AcousticMobilePush             0x106b19b80 (Missing)
6  libdispatch.dylib              0x1ac99d298 _dispatch_call_block_and_release
7  libdispatch.dylib              0x1ac99e280 _dispatch_client_callout
8  libdispatch.dylib              0x1ac97a4f0 _dispatch_lane_serial_drain$VARIANT$armv81
9  libdispatch.dylib              0x1ac97afdc _dispatch_lane_invoke$VARIANT$armv81
10 libdispatch.dylib              0x1ac984800 _dispatch_workloop_worker_thread
11 libsystem_pthread.dylib        0x1f33725a4 _pthread_wqthread
12 libsystem_pthread.dylib        0x1f3375874 start_wqthread

Crashed: com.google.firebase.crashlytics.ios.exception
SIGABRT ABORT 0x00000001d7e2d84c

Crashed: com.google.firebase.crashlytics.ios.exception
0  TSC                            0x104dfbaf8 FIRCLSProcessRecordAllThreads + 392 (FIRCLSProcess.c:392)
1  TSC                            0x104dfbedc FIRCLSProcessRecordAllThreads + 423 (FIRCLSProcess.c:423)
2  TSC                            0x104df2838 FIRCLSHandler + 34 (FIRCLSHandler.m:34)
3  TSC                            0x104dee544 __FIRCLSExceptionRecord_block_invoke + 218 (FIRCLSException.mm:218)
4  libdispatch.dylib              0x1ac99e280 _dispatch_client_callout + 16
5  libdispatch.dylib              0x1ac9810ec _dispatch_lane_barrier_sync_invoke_and_complete + 56
6  TSC                            0x104dedcdc FIRCLSExceptionRecord + 225 (FIRCLSException.mm:225)
7  TSC                            0x104dedfd4 FIRCLSExceptionRecordNSException + 111 (FIRCLSException.mm:111)
8  TSC                            0x104ded8bc FIRCLSTerminateHandler() + 279 (FIRCLSException.mm:279)
9  libc++abi.dylib                0x1c0812154 std::__terminate(void (*)()) + 16
10 libc++abi.dylib                0x1c08120ec std::terminate() + 44
11 libobjc.A.dylib                0x1c0716d88 _objc_terminate() + 10
12 libdispatch.dylib              0x1ac99e294 _dispatch_client_callout + 36
13 libdispatch.dylib              0x1ac97a4f0 _dispatch_lane_serial_drain$VARIANT$armv81 + 568
14 libdispatch.dylib              0x1ac97afdc _dispatch_lane_invoke$VARIANT$armv81 + 404
15 libdispatch.dylib              0x1ac984800 _dispatch_workloop_worker_thread + 692
16 libsystem_pthread.dylib        0x1f33725a4 _pthread_wqthread + 272
17 libsystem_pthread.dylib        0x1f3375874 start_wqthread + 8

Hey @infapednekar, there's nothing in this crashing stack trace that indicates the error is related to Firebase. The report indicating a crash in the com.google.firebase.crashlytics.ios.exception thread is a side-effect of how Crashlytics records crashes.
The actual source of the crash can likely be found by symbolicating these two lines:
4 AcousticMobilePush 0x106b19374 (Missing)
5 AcousticMobilePush 0x106b19b80 (Missing)

Hey @infapednekar, there's nothing in this crashing stack trace that indicates the error is related to Firebase. The report indicating a crash in the com.google.firebase.crashlytics.ios.exception thread is a side-effect of how Crashlytics records crashes.
The actual source of the crash can likely be found by symbolicating these two lines:
4 AcousticMobilePush 0x106b19374 (Missing)
5 AcousticMobilePush 0x106b19b80 (Missing)


Revert "Remove SQL Dependency from Backends"

The original PR got merged into the wrong branch - it was intended for master but it now needs reverting.

Closing as I'm going to merge the logging branch into master, instead of reverting the PR

Closing as I'm going to merge the logging branch into master, instead of reverting the PR


chore: add Trin to used by list

@rakita I tried to make the description short, but concise. There is definitely a lot of confusion on what Trin/The Portal Network is trying to provide. I can share a few tweets people have made if you want :smile:
Maybe I should have included the mission of Portal is to provide full json-rpc access distributed with archival geth level access and of course as light as possible? not sure.
Anyways I hope the description I wrote it good, let me know if anything comes up.

Hi @KolbyML It is nice to see you here. It is up to you and the team to set the description, this one sounds nice, and if for any reason you want to change it just make a new PR.


[Model conversation rendering] Split content fragment + change loop logic

Description
Previously, when providing a conversation to the model for generation, we ignored an older message that would overflow context window, but still add even older messages that would fit (i.e. if they were smaller)
This PR changes as such:

as soon as a message does not fit, the conversation rendering stops (i.e. we don't add older messages);
for content fragment, if the content overflows, it is split and the remaining tokens are used;

Risk
Changes how conversation is rendered which is quite a critical part of our app. Hopefully, the changes are well contained and with a straightforward logic.
Mitigation
Todo:
[] Double check the code
[] Test locally by talking to agents with large content and watching the cuts

Tested locally, merging


Adding event results in 403 forbidden

As TFS administrator I installed the Team Calender extensions but it results in a 403 error with the ExtensionDataCollectionQuery (_https://mytfsserver/tfs/DefaultCollection/_apis/ExtensionManagement/InstalledExtensions/ms-devlabs/team-calendar/ExtensionDataCollectionQuery_) and Documents (_https://mytfsserver/tfs/DefaultCollection/_apis/ExtensionManagement/InstalledExtensions/ms-devlabs/team-calendar/Data/Scopes/Default/Current/Collections/bc6e8cdb-f1dd-4452-a225-765186bcc069/Documents_) requests for the project users. As admin I am able to successfully create events. I cannot find any permissions settings for this extension, am I missing something?

Could send a Fiddler capture of this scenario to<EMAIL_ADDRESS>Thank you.


ArrayIndexOutOfBoundsException parsing class file

I'm getting an ArrayIndexOutOfBoundsException out of MiMa (link to full error):
java.lang.ArrayIndexOutOfBoundsException: 1515
	at com.typesafe.tools.mima.core.BufferReader.nextByte(BufferReader.scala:33)
	at com.typesafe.tools.mima.core.BufferReader.nextChar(BufferReader.scala:48)
	at com.typesafe.tools.mima.core.ClassfileParser.parseMembers(ClassfileParser.scala:216)
	at com.typesafe.tools.mima.core.ClassfileParser.parseFields(ClassfileParser.scala:208)
	at com.typesafe.tools.mima.core.ClassfileParser.parseClass(ClassfileParser.scala:261)
	at com.typesafe.tools.mima.core.ClassfileParser.parseAll(ClassfileParser.scala:68)
	at com.typesafe.tools.mima.core.ClassfileParser.parse(ClassfileParser.scala:59)

The offending jar file is http4s-jawn_2.11-0.13.0a, and the mima version is 0.1.9.
I found a similar issue, but not an answer.  Any idea what might be going on here?  Thanks!

Thanks for reporting. Would be great to isolate the issue and add a test to the regression suite before fixing it. Contribution welcomed! :-)

I've seen a similar issue here: https://github.com/fthomas/refined/pull/154. The problem went away after running mimaReportBinaryIssues before sbt-scoverage's coverage in the CI build.

I'm also seeing it in macro-compat.

We're also see it in Play builds: https://travis-ci.org/playframework/playframework/jobs/134935906#L613

It looks like the BufferReader is reading past the end of the array that's passed in.  I'll add some checks.

One thing that stands out is that in nextBytes the index pointer is being updated before the call to slice, and then buf.slice() will only slice up to the length of the actual array:
  def nextBytes(len: Int): Array[Byte] = {
    bp += len
    buf.slice(bp - len, bp)
  }

https://github.com/typesafehub/migration-manager/blob/master/core/src/main/scala/com/typesafe/tools/mima/core/BufferReader.scala#L41

Is there any activity on this?

@wsargent has a WIP about it, will you have some time to push it over the finish line Will?

@wsargent, I don't think that nextBytes can be the cause here because I've observed this in 0.1.9 and that nextBytes method appears to be unused as of that release.

Also fixed by #129?

yeah, please let us know, y'all, if you ever still see this after upgrading to 0.1.11

optimistically closing, we can reopen if needed


Skip test for missing vendor name in minus version on JDK8 OpenJ9

The vendor name (AdoptOpenJDK) is only present in JDK8 Hotspot
java -version output because AdoptOpenJDK added this functionality
into their fork of the source code.
Until this code gets added to the source for other VMs, we should not
look for it on non-Hotspot JDK8 builds.
Signed-off-by: Adam Farley<EMAIL_ADDRESS>

Test on OpenJ9 JDK8 s390: https://ci.adoptopenjdk.net/job/Grinder/413/console
Other smoke tests failed, but this one passes correctly.

Correcting most of the linter issues. To be updated soon.

@adamfarley merge conflict

@karianna - Merge conflict solved.
Also, all the linter issues I plan to fix have been solved.
The remaining ones are about the lines being too long, the presence of a TODO, and the presence of the number 9. All are listed in the linter tuning issue as things to potentially remove.

Linked to https://github.com/adoptium/temurin-build/issues/2600

A couple of small linter issues that aren't line length related.


stop/start notification timer on window focus change

References and relevant issues
https://github.com/napari/napari/pull/7220#issuecomment-2477654620
Description
This PR stops the notification timer if windows lost focus, and starts the timer for the top one most after gaining focus again.
If a new notification shows, then the previous one timer is stopped and started again if it is closed.
The notification timer is restarted after the mouse leaves the dialog area.
I do not handle the case of hundreds of notifications. Maybe someone will have an idea how to do this properly.

@Czaki tests look borked here, do you want me to take a look or are you still working on this? If you're still working on it, ping me when it's ready.

@Czaki sorry about the delay on this one, I can get to it sometime this week :pray:

I think this is working as intended?
I do notice though that with the plugin manager/no internet case, the warning never auto-dismisses even after closing the manager and interacting with the viewer.
I'm fine with this, because it's essentially the behavior I was implementing.

I do notice though that with the plugin manager/no internet case, the warning never auto-dismisses even after closing the manager and interacting with the viewer.

The timer should be started again when main window get focus.
Maybe the plugin manager emit multiple identical warnings?


Add links to in-repo build-instructions

minor formatting changes

closes #2987

Thank you for your submission. It will be reviewed soon and submitted for processing in CI.

Thank you for your submission. It will be reviewed soon and submitted for processing in CI.

I so totally dislike bots...

What do you like lol?

Thanks for this, @lazaridiscom!
P.S.: not a bot.

Transformers haha

Jenkins Build Summary
Built from this commit
Built at 20190701 - 17:03:06
Test Results

Build Type
Log
Result
Status

msvc.Debug
logfile
1178 cases, 0 failed, t: 570s
PASS :white_check_mark:

gcc.Release -Dassert=ON, MANUAL_TESTS=true
logfile
915 cases, 0 failed, t: 4m54s
PASS :white_check_mark:

docs, TARGET=docs
logfile
1 cases, 0 failed, t: 0m1s
PASS :white_check_mark:

gcc.Debug -Dcoverage=ON, TARGET=coverage_report, SKIP_TESTS=true
logfile
1178 cases, 0 failed, t: 16m24s
PASS :white_check_mark:

clang.Debug
logfile
1178 cases, 0 failed, t: 2m47s
PASS :white_check_mark:

msvc.Debug, NINJA_BUILD=true
logfile
1178 cases, 0 failed, t: 599s
PASS :white_check_mark:

gcc.Debug
logfile
1178 cases, 0 failed, t: 2m55s
PASS :white_check_mark:

clang.Debug -Dunity=OFF
logfile
1177 cases, 0 failed, t: 6m50s
PASS :white_check_mark:

clang.Release -Dassert=ON
logfile
1178 cases, 0 failed, t: 4m45s
PASS :white_check_mark:

gcc.Debug -Dunity=OFF
logfile
1177 cases, 0 failed, t: 11m23s
PASS :white_check_mark:

gcc.Release -Dassert=ON
logfile
1178 cases, 0 failed, t: 4m50s
PASS :white_check_mark:

msvc.Debug -Dunity=OFF
logfile
1177 cases, 0 failed, t: 1110s
PASS :white_check_mark:

gcc.Debug -Dstatic=OFF
logfile
1178 cases, 0 failed, t: 2m54s
PASS :white_check_mark:

gcc.Debug -Dstatic=OFF -DBUILD_SHARED_LIBS=ON
logfile
1178 cases, 0 failed, t: 2m48s
PASS :white_check_mark:

msvc.Release
logfile
1178 cases, 0 failed, t: 403s
PASS :white_check_mark:

gcc.Debug, NINJA_BUILD=true
logfile
1178 cases, 0 failed, t: 2m45s
PASS :white_check_mark:

clang.Debug -Dunity=OFF -Dsan=address, PARALLEL_TESTS=false, DEBUGGER=false
logfile
1177 cases, 0 failed, t: 6m25s
PASS :white_check_mark:

clang.Debug -Dunity=OFF -Dsan=undefined, PARALLEL_TESTS=false
logfile
1177 cases, 0 failed, t: 10m14s
PASS :white_check_mark:

What? Jenkins was on strike?


Add user feedback cards

Add user feedback components; see https://www.figma.com/design/MSr6kVEOuAxmPOkjg7x8PO/PatternFly-6%3A-Patterns-%26-Extensions?node-id=5190-7751&node-type=frame&t=L72Rg7HcSOsY38Xp-0 and https://www.figma.com/design/YV8fXr4jjEjUqhvRzI0tT2/PatternFly-Chat-Extension?node-id=433-15046&node-type=frame&t=zzLT6b7wdhMB1qiz-0. This was a request from Composer.

We'll also want to add a "active" setting for the response actions if we don't get one from PF already.

Add optional timeout.


Remove Mainnet service

Changes:

Remove Mainnet service an use Merge service instead

Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update
[ ] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Other (please describe):

Testing
Requires testing

[x] Yes
[ ] No

In case you checked yes, did you write tests?

[ ] Yes
[x] No

Codecov Report

Merging #86 (6b783b0) into develop (c9ea6f9) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop      #86   +/-   ##
========================================
  Coverage    84.70%   84.70%
========================================
  Files           32       32
  Lines         1863     1863
========================================
  Hits          1578     1578
- Misses         229      230    +1
+ Partials        56       55    -1

Flag
Coverage Δ

unittests
84.70% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

configs/init.go
100.00% <100.00%> (ø)

cli/cli.go
68.90% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add w3client unit tests

@anbenson @joanchenx I wanted to check if these were the kind of unit testing you had in mind with regards to the scraping clients?

Yeah, this sort of thing. JUnit is the right tool here. However, the code under test is in the [implicit] constructor, not in a test itself - generally you want it in the test. For example, if there's an exception raised, you're not going to see a test fail, but something more mysterious.
The general format here I'd expect is to create a client in the constructor or setup, and for each test, feed in some kind of W3Schools URL (or non-W3Schools-URL) and compare the output of the method to an expected Card. You can either override equals or make a custom assert to check each field of a Card.
Other notes:

Why JUnit 4? Why not JUnit 5?
Can you add how to run the test command to the README?

To add on a bit, also add in failure cases too, so an invalid W3Schools URL or a W3Schools URL with missing fields like this URL: https://www.w3schools.com/html/html_quiz.asp which doesn't have a w3-code class.

Yeah, this sort of thing. JUnit is the right tool here. However, the code under test is in the [implicit] constructor, not in a test itself - generally you want it in the test. For example, if there's an exception raised, you're not going to see a test fail, but something more mysterious.
The general format here I'd expect is to create a client in the constructor or setup, and for each test, feed in some kind of W3Schools URL (or non-W3Schools-URL) and compare the output of the method to an expected Card. You can either override equals or make a custom assert to check each field of a Card.
Other notes:

Why JUnit 4? Why not JUnit 5?
Can you add how to run the test command to the README?

JUnit 4 was used in the walkthrough testing guide and JUnit 5 has some overhead with more than one required dependancy.


Add support for the Epsilon Model Generation language

The Epsilon Model Generation language is an application of EPL that uses annotations to automatically generate models:
https://eclipse.dev/epsilon/doc/emg/
We can just reuse our EPL support for it: this makes for a very succint PR :-).

Thanks Antonio!


[authoring] CodeMirror tasklist

Illustrated in the video below:

[x] Bug: Cursor jumps when moving down into block (if in first column)
[x] Bug: Formatting breaks when pressing Enter in front of a bullet that has indented children
[x] Convert indents to natural spaces
[x] Remove checkbox widget (convert back to text) when cursor moves into it (popular request; and similar to Obsidian)
[x] Pressing Enter on an empty last line of the list should end the list (currently have to press Enter three times)
[x] Restore previous position of cursor after clicking on checkbox

https://github.com/dxos/dxos/assets/3523355/e76f6b22-958d-408f-866b-2ed22a5dd290

I get the point, but I do think the behavior implemented here in this GitHub textbox is more intuitive.
- [ ] 1
- [ ] 2
- [ ] 3
- [ ]               << pressing enter here will end the list.

One thing I've been considering is to make that command a bit smarter so that, for the first list item you get the current behavior (single-item lists not super common), but then for others it only goes through the spacing of the rest of the items (no blank line if the list is tight, blank line if not), so you can exit it with two enter presses. Does that sound like it's work for you here?

Well, here is the reason your widgets misbehave and break the cursor. Patch 560f82b5d9 , for some reason, intentionally breaks CodeMirror's hack that prevents precisely this.

Upgrading to @codemirror/lang-markdown 6.2.4 should help with Enter key behavior. Is bumping a dependency just a matter of updating the relevant package's package.json, reinstalling with pnpm to update the package lock, and committing the result?

@richburdon Please see https://github.com/dxos/dxos/pull/5221, https://github.com/dxos/dxos/pull/5222, and https://github.com/dxos/dxos/pull/5223

@richburdon the entire checklist is checked off. can this issue be closed now?


socket.io client 0.9.8 causes KeyError exceptions

The socket.io client v0.9.8 released just yesterday is causing KeyError exceptions in gevent-socketio, when it disconnects/reconnects (eg. refresh a page, or even just leave a page that has a socketio connection).
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/django/core/handlers/base.py", line 114, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "/usr/local/talk2fs/talk2/core/views.py", line 42, in socketio_serve
    }, request)
  File "/usr/src/gevent-socketio/socketio/__init__.py", line 60, in socketio_manage
    socket = environ['socketio']
KeyError: 'socketio'

Other than that, it seems to be working fine.

This is still happening for me, even with the sample apps (at least the pyramid chat one). It's not on disconnect requests, it's on all requests. Downgrading the socket.io client to 0.9.something makes the problem go away.


Adjust the loader position for

(sort of) addresses https://artsyproduct.atlassian.net/browse/AUCT-692
For some reason the loader started working fine... I just needed to add a bit of margin-top to make it look a little nicer. I didn't know what else to do so I just added some typos to the branch name loaoeader.
#skip_new_tests
Screenshot

:rocket: PR was released in v1.18.17 :rocket:


Template Customization Configuration

The following is my proposal for structuring the template customization options:
{
    template: {

        // Replace default partials and register custom partials.
        // Does not require a value in any other option.
        partials: {
            'head': '',
            'nav': '',
            'masthead': '',
            'footer': '',
            'preview': '',
            'tag-details': '',
            'file-path': '',
            'block-title': '',
            'section-color': '',
            'section-typography': '',
            'section-variable': '',
            'section-default': '',
            'my-custom-partial': ''
        },

        // Register custom partials.
        // Requires a value in 'layout' and/or 'partials'.
        helpers: {
            someHelper: fn() {}
        },
        // or
        helpers: require( 'my-big-file-full-of-helpers' ),

        // Replace default layout.
        // Does not require a value in any other option
        layout: '',

        // Requires a value in the 'includes.css' option.
        selectorPrefix: ''
    }
}

Regarding selectorPrefix, see the includes.css option in #43.

Since we have our own Handlebars helpers registered, we should be able to merge user provided helpers with our own (Similar to how partials are registered)
helpers: {
    isEqual: fn(),
    notEqual: fn(),
    toID: fn()
}

If we expose the helpers we have in our Handlebars instance, the user will know what is already available, and if they are potentially overwriting a helper with the same key.
Thoughts? @ryanfitzer @tisAliG

@vbalcom So you're proposing to change the helpers property in my example to be what you show in you example?

@ryanfitzer Yup!

So this could also work:
helpers: require( 'my-big-file-full-of-helpers' )

Ok.
@tisAliG?

I've updated the initial comment to reflect the new form.

#58


Increase curve max size to 1024

Tests pass on Windows x Release
Relates to #356

Where an agent function inputs and outputs message of same name, there is a collision. This needs addressing.

Where an agent function inputs and outputs message of same name, there is a collision. This needs addressing.

We could disable that functionality for now? I don't think that it's supported in Flamegpu 1 (although no reason it shouldn't be supported IMO).

The spatial messaging tests need adjusting, they currently have the
warning.
On Mon, 13 Jul 2020, 16:08 Peter Heywood<EMAIL_ADDRESS>wrote:

Where an agent function inputs and outputs message of same name, there is
a collision. This needs addressing.
We could disable that functionality for now? I don't think that it's
supported in Flamegpu 1 (although no reason it shouldn't be supported IMO).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/FLAMEGPU/FLAMEGPU2_dev/pull/355#issuecomment-657616397,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFVGCW4DBYA52ZROCWISRDR3MPN3ANCNFSM4OYNO4XQ
.

I fixed the spatial message warning issue, so I'll merge this now.


Quizlet shows an error after user granted the permission

Hello,
I just run the Example project, when clicking Login button, it switched to Safari and after I logged in into Quizlet and granted the permission, then I got this error like this image

Hello @tungdx
I've just sent a request to the Quizlet support.

Thanks for your quick reply @maximbilan

@tungdx I've just received a response from the support:

Thanks for reaching out about this — and apologies for the trouble.
We’re not actively maintaining the public-facing Quizlet API, which unfortunately means that we won’t be able to fix issues like the one you’ve run into.
I’m sorry I don’t have better news for you, but hope this helps clear things up.


typo fix

Related to issue https://github.com/CollectionFS/Meteor-CollectionFS/issues/548

Thanks!


Runtime config warning (typo error link)

Environment

Operating System: Darwin
Node Version:     v18.18.0
Nuxt Version:     3.12.1
CLI Version:      3.12.0
Nitro Version:    2.9.6
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      devtools, runtimeConfig, modules, image, sanity, site, seo, build
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Reproduction
I'm not providing a reproduction because there is only a small typo error:
[nuxt] Could not access `nuxt-schema-org`. The only available runtime config keys on the client side are `public` and `app`. See `https://nuxt.com/docs/guide/going-further/runtime-config` for more information.

I noticed that the link redirects to this:
https://nuxt.com/docs/guide/going-further/runtime-config`
Describe the bug
I noticed that the link redirects to this:
https://nuxt.com/docs/guide/going-further/runtime-config`
Additional context
No response
Logs
No response

The warning is probably caused because of this line
const runtimeConfig = useRuntimeConfig()["nuxt-schema-org"] || useRuntimeConfig().public["nuxt-schema-org"];
it is in the .nuxt/dev/index.mjs file

Somehow your terminal considers the last "`" as part of the website.
Maybe we can just add a redirect on nuxt.com to avoid that?


Update .gitignore

add Pycharm .idea

Hello! @Shenliuran , Thanks for your pull request, and I've noticed that you also updated the detectron2 submodule, which should be ignored I thought~ maybe you can restore your change in detectron2 submodule and submit the pull request again~


Update CHANGELOG.md for v1.2.1

Added recent changes prior to next release.
Speaking of which, my access doesn't allow management of actions nor releases, I'm keen to continue managing these.

Speaking of which, my access doesn't allow management of actions nor releases, I'm keen to continue managing these.

Not yet. You will get those in time. I have you at Triage level write now. The next level is 'Write'. Not breaking a release is the most important thing for me, so it will take me some time to get comfortable with the process. I have done the same policy on all my other repos as well.

I don't have the rights to merge PRs


Build corporate dev area

move git stream to that developer portal area, dev forums, and corporate postings based on this git.
All shall be designed to increase GIt use

Priority 2

Good job - consider this completed. We may wish to move them to GIthub though .

👍🏽


Clearer warning flags when using neglect_angles=True

When building in the 'new' part of a unique molecule, we sample from the distribution of bond/angle/dihedral terms, but it's possible to turn off the using of the angle terms. This means that structures can be built with very unphysical angles, which can result in nan's.
neglect_angles=False builds this lovely fused ring system

neglect_angles=True builds this:

This is an example using Mcl1, where the 16th ligand (0 indexing) is the new ligand in a relative free energy calculation.
example.tar.gz
There should be BIGGER warnings when neglect_angles=True is used!!!

code attached,
perses-relative example.yaml would demonstrate, where the kword can be toggled in the yaml


python310Packages.elkm1-lib: 2.0.0 -> 2.0.2

Description of changes
https://github.com/gwww/elkm1/blob/main/CHANGELOG.md#202

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 180756 run on x86_64-linux 1

3 packages built:

home-assistant-component-tests.elkm1
python310Packages.elkm1-lib
python39Packages.elkm1-lib


Update incorrect Dirichlet PDF in documentation

The PDF listed in the documentation of the jax.random.dirichlet function is wrong, the exponent should be \alpha_i - 1 instead of \alpha_i. Here is the Wikipedia article for reference: https://en.wikipedia.org/wiki/Dirichlet_distribution
While the parametrization currently listed would in principle also be a valid parametrization \alpha_i > -1 would need to be allowed but currently result in nan. More importantly, the sampling method used is the one corresponding to Wikipedia's parametrization.

Is there anything that still needs to be done?


Bug: Errors displayed in wrong order when using Validation:SetRule

PHP Version
7.4, 8.0, 8.1, 8.2
CodeIgniter4 Version
4.3.1
CodeIgniter4 Installation Method
Composer (using codeigniter4/appstarter)
Which operating systems have you tested for this bug?
macOS, Windows
Which server did you use?
apache
Database
No response
What happened?
When using many SetRule from Validation service in order :
$validation->setRule('username', 'Username', 'required');
Then
$validation->setRule('password', 'Password', 'required');
Errors are shown in reverse order.
("Password error" then "Username error")
Steps to Reproduce
When using many SetRule from Validation service like that :
$validation = \Config\Services::validation(); $validation->setRule('username', 'Username', 'required'); $validation->setRule('password', 'Password', 'required'); if ($this->validation->withRequest($this->request)->run()) {...}
Submit your form and show errors in view with :
<?= validation_list_errors() ?>
Expected Output
"Username error"
then
"Password error"
Anything else?
The problem seems to be in Validation/Validation.php line 446
When I replace :
$this->setRules($ruleSet + $this->getRules(), $this->customErrors);
By :
$this->setRules($this->getRules() + $ruleSet, $this->customErrors);
It's in the right order (but may cause other problem).

I send PR #7149


Define initial includes for works

The are additional field sets only added to all works in a response when specifically requested.

https://github.com/wellcometrust/wellcomecollection.org/issues/881


discoverd/client: Ensure that AddService is always retried

Move the logic from maybeAddService to AddService so that direct callers of AddService get retries as well. Fixes a intermittent failure while bootstrapping where the flannel wrapper errors out while discoverd is starting.
Thanks to @tianx2 for reporting this.

LGTM


jupiter.sh: Add support for conda channels

By prepolutating a metadata value at cluster creation, it is
possible to setup additional channels from which to pull packages in Conda.

I signed it!

Thanks for the contribution!


fix(tests): add tests to npm ignore

:tada: This PR is included in version 1.3.10 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


(Mostly) Type-check where clauses on associated types

This doesn't yet check that conforming types satisfy the requirements, nor does it do basic sensible-ness checks on the requirements (like associatedtype T where T == Int).

Will address the missing pieces and rebase tomorrow.

'associatedtype T where T == Int' could be equivalent to just 'typealias T == Int'

'associatedtype T where T == Int' could be equivalent to just 'typealias T == Int'

Is it worth allowing it just for that purpose, rather than outlawing it and suggesting a typealias? (At least, once typealiases work well enough...)

'associatedtype T where T == Int' could be equivalent to just 'typealias T == Int'

Is it worth allowing it just for that purpose, rather than outlawing it and suggesting a typealias? (At least, once typealiases work well enough...)

IIRC this is currently accepted but does not require that the typealias be used:
protocol Base {
  associatedtype Assoc
}
protocol Refined: Base {
  typealias Assoc = Int
}
struct Impl: Refined {
  typealias Assoc = Float
}

func test<T: Base>(_: T) -> T.Assoc? { return nil }
print(type(of: test(Impl()))) // Optional<Float>

So at least in Swift 3 mode the associated-type-with-where has a stronger meaning.

@swift-ci Please smoke test.

@swift-ci Please smoke test

I think I've fixed everything, except for the rather ugly and unfortunate last two commits which just paper over bugs. I don't think I'll get time to address these until I get back, but it still might be useful to land this, for those depending on this feature.

We'll deal with the compiler crashers and get this merged

@jrose-apple Do you think that's a bug though? If the RHS of the typealias were an associated type, and not concrete, we'd have to 'merge' the two associated types, ie:
protocol ExpressibleByArrayLiteral { associatedtype Element }
protocol Sequence { associatedtype Iterator : IteratorProtocol; typealias Element = Iterator.Element }
protocol ArrayProtocol :  ExpressibleByArrayLiteral, Sequence {}

We really need to infer ExpressibleByArrayLiteral.Element == Sequence.Iterator.Element here.
Also, this example makes no sense at all:
protocol P {
  associatedtype A
  typealias B = A
}

protocol Q : P {
  typealias A = Int
}

extension P {
  func foo() {
    print(A.self)
    print(B.self)
  }
}

extension Q {
  func bar() {
    print(A.self)
    print(B.self)
  }
}

struct S1 : Q {
  typealias A = Float
}

print("Conformance of S1 to P: "); S1().foo()
print("Conformance of S1 to Q: "); S1().bar()

Note that typealias B is only defined once!
But inside the extension of P, 'B' resolves to the type witness for the associated type A, whereas inside the extension of Q, 'B' resolves to the type alias A, which is always Int.
I feel that the correct behavior is that inside a protocol, 'typealias T = ConcreteType' should always be equivalent to 'associatedtype T where T == ConcreteType', and 'typealias T = AssocType' should always be equivalent to  'associatedtype T where T == AssocType'.
We might be able to hack something up for Swift 3 mode, but it looks more of a consequence of bugs in the generic signature builder than anything intentional.

@swift-ci please smoke test

I feel that the correct behavior is that inside a protocol, 'typealias T = ConcreteType' should always be equivalent to 'associatedtype T where T == ConcreteType', and 'typealias T = AssocType' should always be equivalent to 'associatedtype T where T == AssocType'.

That's a language change. The current behavior is just like anything defined in a protocol extension: it's shadowable and provides a default for associated types. (Okay, that's a bit of a stretch since typealiases in protocol extensions didn't work right in 3.0 IIRC. But I still don't think it's okay to change the meaning of this in Swift 3 mode.)

requiresClassSlow() isn't working properly due to the last commit. I'm testing a fix.

I believe that https://github.com/apple/swift/pull/7799 will address the failures in the standard library.

@swift-ci please smoke test and merge

@swift-ci please smoke test and merge

@swift-ci please smoke test and merge

@swift-ci please smoke test and merge

Cleanups to come, but I'd like to get this PR merged as-is to keep the history.

@swift-ci please smoke test and merge

@swift-ci please smoke test and merge

@swift-ci please smoke test Linux

@swift-ci please smoke test Linux

I'm sorry I missed this. I'm very terrified of validateDeclForNameLookup, because I don't think there's any guarantee that we'd come back and finish validating the decl later. What makes this safe?

Nothing. :)  I think that's what I fixed in the second commit of #7852.


create a 0.9.9 release?

would it be possible to tag a 0.9.9 release so it can be picked up by distributions such as NixOS?

Hi @armijnhemel . I'll work on this, but it's not a quick thing. I have to ensure consistency and I'm particularly worried the fix in 65ce387.