Automatically soft wrap all .tex and .sty files

Love your plugin, but I've got one big issue that keeps me from using it as my main Latex editor: soft wraps, or rather the lack thereof. When I open up one of my .tex files in Intellij what I end up with are whole paragraphs splayed out onto single, 2000+ character long lines. Not the easiest way to write a paper.
From that point I currently have two options (as far as I can tell after extensive googling):

In the menus I open View -> Active Editor and then toggle Use Soft Wraps.
In preferences I go to Editor -> General and then toggle Use soft wraps in editor.

The problem with the first way is that Intellij forgets all about it as soon as the current editor tab is closed or changed, meaning you have to set it for every single file every time you open it. The problem with the second way is that it applies to evvverything in Intellij, including all of my coding projects, which is something I definitely don't want.
Intellij and Latex go great together (Column Selection Mode, for example, is a godsend for formatting Latex tables), and I'd like to use Intellij more in my Latex editing, but I need a better soft wrap solution first.
Now, the thing that has me really weirded out is that it seems like I'm the first guy to ask about this in the issues section. Other folks must have this same problem. Am I missing something really obvious? Or do people generally just muddle through with option 1 or 2?
If it's the muddling one, would it possible to add an option for automagic wrapping of .sty/.tex files to the plugin?

Hi, thanks for the support! I have have the same problem myself and I usually enable soft wraps manually when I open a .tex file. If it helps, right-clicking the gutter and selecting Soft-Wrap Current File is slightly faster for me than using the View menu, but it is still tedious indeed.
We have been looking for ways to enable soft-wraps automatically for LaTeX files, but we have not found a way to get it working. We will keep looking though and we definitely plan to add this in the future.
Thanks for reporting, it gives us a glimpse of what issues to prioritize.

If you want soft wraps depending on what kind of project you have, I guess it makes sense to specify that for each project separately?
In general what I do, is just like with my coding projects, I make sure that not all of my code is on one line! That would be one hell of a program to work with :)
I have IJ set such that when I get to the 100 char line it automatically hard wraps the line. Some people prefer to hit enter themselves.
The quickfix which puts each sentence on a new file could help, especially when you choose the option to apply for all problems in file.


Implement DNS configuration

As per the CNI spec, this is an optional behavior.  https://github.com/appc/cni/blob/master/SPEC.md#result

I'm not sure when or why we would want to supply DNS config?

Kubernetes manage internal dns cluster vis skydns,  containers should be able to access these services by resolving names dns skydns

guys,
cni configured the driver as follows:
/etc/cni/net.d/10-calico.conf
{
"name": "calico-k8s-network",
"type": "calico",
"etcd_authority": "masters.paas.cluster:2379",
"log_level": "info",
"ipam": {
"type": "calico-ipam"
}
}
and create pod test using image python http.server and executed command into container:
curl teste.default.svc.paas.cluster:8080
it works, ie dns is configured via Kubernetes not cni because of that is dns is optional.
in my cluster works fine, without dns cni configuration.

Yeah, I think this is a "move to DNS via CNI if and when k8s does it", so I'm going to close for now.


fix(p-search-dropdown): add selected-extra slot

To Reviewers

[ ] Skipping review is not a problem (style, chore ONLY)
[x] Not that difficult

Type of Change

[ ] New feature
[ ] Bug fixes
[x] Feature improvement

[ ] These changes require a usage change

[ ] Others (performance improvement, refactoring, CI/CD, etc.)

Checklist

[x] Updated Storybook documents
[x] Tested with console(if usages are changed)

Description
SSIA

:tada: This PR is included in version 1.1.0-beta.471 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


DELETE statement isn't committed within on-run-end hook.

Describe the bug
I have added an on-run-end hook to my project, that has a single statement: DELETE FROM ... to do some cleanup. However, when I dbt run, the data is not cleaned up. If I add ; commit; to the end of the statement, i.e. DELETE FROM ...; commit;, and dbt run again, the data is deleted.
Steps To Reproduce
The behaviour I'm trying to account for is like so:
                   ┌ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ┐
┌──────────────┐     ┌──────────────┐       ┌──────────────┐
│              │   │ │              │       │              │ │
│    STREAM    │────▶│    BATCH     │──────▶│    TABLES    │
│              │   │ │              │       │              │ │
└──────────────┘     └──────────────┘       └──────────────┘
                   │                                         │
                     ┌─────────────────────────────────────┐
                   │ │                                     │ │
                     │    DBT                              │
                   │ │                                     │ │
                     └─────────────────────────────────────┘
                   └ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ┘

I have a stream with contains new raw json blobs. With on-run-start, I run INSERT INTO BATCH SELECT RAW FROM STREAM.
BATCH is then a source for dbt, and transforms are made to turn it into some tables.
At the end, on-run-end, I then want to clean up the BATCH table, running DELETE FROM BATCH. This does not commit, however, and I'm left with data in BATCH at the end of a run.
In terms of configuration this looks like:

dbt_project.yml

# Name your project! Project names should contain only lowercase characters
# and underscores. A good package name should reflect your organization's
# name or the intended use of these models
name: "test"
version: "1.0.0"

# This setting configures which "profile" dbt uses for this project.
profile: "dev"

# These configurations specify where dbt should look for different types of files.
# The `source-paths` config, for example, states that models in this project can be
# found in the "models/" directory. You probably won't need to change these!
source-paths: ["models"]
analysis-paths: ["analysis"]
test-paths: ["tests"]
data-paths: ["data"]
macro-paths: ["macros"]
snapshot-paths: ["snapshots"]

target-path: "target" # directory which will store compiled SQL files
clean-targets: # directories to be removed by `dbt clean`
    - "target"
    - "dbt_modules"
# Configuring models
# Full documentation: https://docs.getdbt.com/docs/configuring-models

# In this example config, we tell dbt to build all models in the example/ directory
# as tables. These settings can be overridden in the individual model files
# using the `{{ config(...) }}` macro.
# models:
#     test:
#         # Applies to all files under models/example/
#         example:
#             materialized: view

on-run-start:
    - INSERT INTO BATCH (RAW, TIMESTAMP) SELECT RAW, TIMESTAMP FROM STREAM;

on-run-end:
    - DELETE FROM BATCH [; COMMIT;]

schema.yml

version: 2

sources:
  - name: test
    schema: TEST
    tables:
      - name: BATCH

models/test.sql

{{ config(materialized='table') }}

WITH BATCH_LATEST AS (
  SELECT
    CAST(RAW:object_id AS BIGINT)                   AS OBJECT_ID,
    CAST(RAW:version AS INTEGER)                    AS VERSION,
    CAST(RAW:timestamp AS TIMESTAMP WITH TIME ZONE) AS EMITTED_TIMESTAMP,
    RAW,
    ROW_NUMBER() OVER (PARTITION BY RAW:object_id ORDER BY RAW:version DESC) AS RNK
  FROM {{ source('test', 'BATCH') }}
)
SELECT
  ACCOUNT_ID,
  OBJECT_ID,
  VERSION,
  EMITTED_TIMESTAMP,
  RAW
FROM BATCH_LATEST
WHERE RNK = 1

Expected behavior
I'd expect the data to be deleted without having to commit manually.
Screenshots and log output
Debug log output without ; commit;:
2020-05-28 00:02:02.038969 (MainThread): Using snowflake connection "master".
2020-05-28 00:02:02.039269 (MainThread): On master: /* {"app": "dbt", "dbt_version": "0.17.0b1", "profile_name": "cdp", "target_name": "test", "connection_name": "master"} */
DELETE FROM <...>;
2020-05-28 00:02:02.910266 (MainThread): SQL status: SUCCESS 5 in 0.87 seconds

Debug log output with ; commit;:
2020-05-28 00:04:17.663912 (MainThread): Using snowflake connection "master".
2020-05-28 00:04:17.664125 (MainThread): On master: /* {"app": "dbt", "dbt_version": "0.17.0b1", "profile_name": "cdp", "target_name": "test", "connection_name": "master"} */
DELETE FROM <...>;
2020-05-28 00:04:18.553232 (MainThread): SQL status: SUCCESS 5 in 0.89 seconds
2020-05-28 00:04:18.553514 (MainThread): Using snowflake connection "master".
2020-05-28 00:04:18.553689 (MainThread): On master: commit;
2020-05-28 00:04:18.884134 (MainThread): SQL status: SUCCESS 1 in 0.33 seconds

System information
Which database are you using dbt with?

[ ] postgres
[ ] redshift
[ ] bigquery
[x] snowflake
[ ] other (specify: ____________)

The output of dbt --version:
0.17.0-b1

(This was also the case in 0.16.1).
The operating system you're using: Mac OS
The output of python --version: Python 3.8.1
Additional context
This is my first time using dbt, so I could well be doing something incorrectly...
As a side note, my table 'TEST' (from test.sql) also doesn't have any data in it, but when I run the command outputted by the debug logs (i.e. create or replace table ...) it does work. Maybe there's a 'commit' issue else where, or something I'm doing wrong...

@dlmiddlecote Thanks for the detailed writeup!
Just to clarify my understanding, if you set your on-run-end hook to be:
on-run-end:
    - delete from batch; commit;

It sounds like that works, and it also sounds like you expect that commit should be unnecessary. Is that right?
Snowflake has some odd behavior around transactions. DDL statements (including create ... as, i.e. most dbt models) are always auto-committed. DML statements (including delete, copy, etc) can be rolled back, however, if they occur within a transaction.
I find that it's generally a good practice to include a follow-on commit any time you're asking dbt to run DML, especially if it's from a hook. IMO it's more straightforward than trying to parse out whether the statement is being run within a transaction, whether the autocommit parameter is set for account/user/session, and so on.

Hi @jtcohen6 😊
Yes, that is correct, thank you for confirming.
Okay, thanks so much for the link. That makes more sense now, I’ll just be more liberal with my COMMITing 🎉.
Many thanks!

on-run-end block exhibiting inconsistent commit behaviour across environments
I recently had an issue where a macro with an insert statement in an on-run-end block would always (implicitly) commit when running dbt locally, but never when run in dbt Cloud (as described above for the delete statement). This was fixed by adding a manual commit;, but the issue really confused me during investigation since I assumed it would be related to roles or environments due to the different behaviour between local and dbt Cloud runs.
Can anyone think of why the transaction behaviour would work differently when running locally compared to dbt Cloud? There doesn't seem to be a parameter to configure for this (for example, as part of the profiles.yml setup for my local connection), so I would expect the same behaviour by default.
I'll leave it to the team to determine whether this is expected behaviour from the dbt side, but in any case, I hope this comment saves someone from investigating this edge case in the future!
Further context
The query from Snowflake's query history sits between two transactions when executed by dbt Cloud and is not committed (although the query succeeds and superficially looks like it has committed).

The relevant dbt Cloud debug logs also don't clearly indicate whether any transaction was involved, but look like a successful insert:
insert into ANALYTICS.models_meta.dbt_run_results (...) values (...)
(MainThread): SQL status: SUCCESS 202 in 0.43 seconds

If possible, it might be helpful to include some form of logging on the commit status of the current connection or even statement in the debug logs. Perhaps this could be an optional attribute in profiles.yml for a given connection?

on-run-end block exhibiting inconsistent commit behaviour across environments
I recently had an issue where a macro with an insert statement in an on-run-end block would always (implicitly) commit when running dbt locally, but never when run in dbt Cloud (as described above for the delete statement). This was fixed by adding a manual commit;, but the issue really confused me during investigation since I assumed it would be related to roles or environments due to the different behaviour between local and dbt Cloud runs.
Can anyone think of why the transaction behaviour would work differently when running locally compared to dbt Cloud? There doesn't seem to be a parameter to configure for this (for example, as part of the profiles.yml setup for my local connection), so I would expect the same behaviour by default.
I'll leave it to the team to determine whether this is expected behaviour from the dbt side, but in any case, I hope this comment saves someone from investigating this edge case in the future!
Further context
The query from Snowflake's query history sits between two transactions when executed by dbt Cloud and is not committed (although the query succeeds and superficially looks like it has committed).

The relevant dbt Cloud debug logs also don't clearly indicate whether any transaction was involved, but look like a successful insert:
insert into ANALYTICS.models_meta.dbt_run_results (...) values (...)
(MainThread): SQL status: SUCCESS 202 in 0.43 seconds

If possible, it might be helpful to include some form of logging on the commit status of the current connection or even statement in the debug logs. Perhaps this could be an optional attribute in profiles.yml for a given connection?

@huntdm07 I have to imagine that, somehow, the autocommit parameter is turned on for your local user but off for your dbt Cloud user. Based on that query history, it sure looks like the insert statement is not being run inside an explicit transaction (between a begin and a commit). So long as it succeeds, and autocommit is on, it should be implicitly committed; if it succeeds and autocommit is off, however, it would appear to be successful but implicitly rolled back after completion.
(I'm not sure that's right, it's just the only explanation that makes sense to me right now.)

@huntdm07 I have to imagine that, somehow, the autocommit parameter is turned on for your local user but off for your dbt Cloud user. Based on that query history, it sure looks like the insert statement is not being run inside an explicit transaction (between a begin and a commit). So long as it succeeds, and autocommit is on, it should be implicitly committed; if it succeeds and autocommit is off, however, it would appear to be successful but implicitly rolled back after completion.
(I'm not sure that's right, it's just the only explanation that makes sense to me right now.)


Make use of functions for markdown documentation generator

Re generate_md_files.py
In order to standardize the formatting maybe make use of functions along with a templated approach to writing the docs?

Or maybe Marvin? https://www.askmarvin.ai/

See #2 and #5


[feat|fix] : SDE backend : Hotfix 3.2 with pcf submodel : rel-2.3.0

Description
Added

Added oauth security for sde public api.
BPN url add API path.

Fixed

DT use refactor and PCF issue fix.
Correct dataplane endpoint for digital twin.
DSP endpoint path for digital-twin edc url.
trivy worklow fix.

Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:

[x] DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
[x] Copyright and license header are present on all affected files

@almadigabor  Changes made as per suggested.
#69  is fixed. Changed in uid .

Fixed
#71 Notice.md updated.

Fixed
#70
Please review @sachinargade123

@almadigabor, can you please help us to merge this PR by today?

can you please update the dependencies file? I also open a PR for that 3days ago.

@hzierer,
We have already Updated  Dependencies file.
Reg. your created PR, We have checked it but that is not sufficient, our SDE backend is multi maven model project so it should scan all project and autogenerate dependency file. We will take look and generate DEPEDENCY file automatically.

@almadigabor  Can we merge the PR?

I split the old PR in two separate ones and fixed the dash tool to include the testing scope:
https://github.com/eclipse-tractusx/managed-simple-data-exchanger-backend/pull/72
https://github.com/eclipse-tractusx/managed-simple-data-exchanger-backend/pull/73

So it is reviewed and can be merged now. Correct?

@hzierer
We had already included this #73 changes in here sde-core maven model where actual application jar get build .  May be we don't require this changes.

@hzierer We had already included this #73 changes in here sde-core maven model where actual application jar get build . May be we don't require this changes.

yeah ok, it might be obsolete then. just saw that you are creating two jars and wanted to make sure that theese documents are part of all. But I assume then, that only the on in sde-core is distributed to dockerhub

Ok sure we are closing this PR and we will open new PRs.


mender-nxp: add support for Nitrogen8m from Boundary Devices

https://boundarydevices.com/product/nitrogen8m/
Signed-off-by: Pierre-Jean Texier<EMAIL_ADDRESS>

Thanks to you ;)


ARROW-6440: [Packaging][deb] Follow plasma-store-server name change

@ursabot crossbow package -g linux

xenial, bionic and cosmic are failed.
plasma-store-server failure is fixed but timeout on bionic and cosmic.
Timeout while downloading deb packages on xenial...
These failures are unrelated to this change.
I'll merge this.
We can't use Travis CI to build deb packages because Travis CI resource is poor for these jobs...

@kou on short term we could port the linux packaging builds to azure pipelines, that might solve the timeout issue.

Thanks for working on #5296 !


Add http and websocket severs

Node and Deno already have support for these and it is possible in python.

Closed via #149


libvirt: 9.6.0 -> 9.7.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for libvirt is: A toolkit to interact with the virtualization capabilities of recent versions of Linux and other OSes
meta.homepage for libvirt is: https://libvirt.org/
meta.changelog for libvirt is: https://gitlab.com/libvirt/libvirt/-/raw/v9.7.0/NEWS.rst
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 9.7.0 with grep in /nix/store/47akg0i7dpqj9ivhzjsdpwvq9bar3v1j-libvirt-9.7.0
found 9.7.0 in filename of file in /nix/store/47akg0i7dpqj9ivhzjsdpwvq9bar3v1j-libvirt-9.7.0

Rebuild report (if merged into master) (click to expand)

34 total rebuild path(s)

34 package rebuild(s)

First fifty rebuilds by attrpath
appvm
collectd
diffoscope
docker-machine-kvm
docker-machine-kvm2
gnome.gnome-boxes
guestfs-tools
haskellPackages.libvirt-hs
libguestfs
libvirt
libvirt-glib
libvmi
mgmt
minikube
minishift
multipass
nixops_unstable
perl536Packages.SysVirt
perl538Packages.SysVirt
python310Packages.guestfs
python310Packages.libvirt
python311Packages.guestfs
python311Packages.libvirt
rubyPackages.ruby-libvirt
rubyPackages_2_7.ruby-libvirt
rubyPackages_3_0.ruby-libvirt
rubyPackages_3_1.ruby-libvirt
rubyPackages_3_2.ruby-libvirt
rubyPackages_3_3.ruby-libvirt
vagrant
virt-manager
virt-manager-qt
virt-top
virt-viewer

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/47akg0i7dpqj9ivhzjsdpwvq9bar3v1j-libvirt-9.7.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A libvirt https://github.com/r-ryantm/nixpkgs/archive/0a176dfc4cea922d852a227c4f1c39f30b6eaf09.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/47akg0i7dpqj9ivhzjsdpwvq9bar3v1j-libvirt-9.7.0
ls -la /nix/store/47akg0i7dpqj9ivhzjsdpwvq9bar3v1j-libvirt-9.7.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:

diffoscope

30 packages built:

appvm
collectd
docker-machine-kvm
docker-machine-kvm2
gnome.gnome-boxes
guestfs-tools
libguestfs
libguestfs-with-appliance
libvirt
libvirt-glib
mgmt
minikube
minishift
multipass
ocamlPackages.ocaml_libvirt
perl536Packages.SysVirt
perl538Packages.SysVirt
python310Packages.guestfs
python310Packages.libvirt
python311Packages.guestfs
python311Packages.libvirt
rubyPackages.ruby-libvirt
rubyPackages_3_0.ruby-libvirt
rubyPackages_3_2.ruby-libvirt
rubyPackages_3_3.ruby-libvirt
vagrant
virt-manager
virt-manager-qt
virt-top
virt-viewer

Maintainer pings
cc @fpletz @globin @lovesegfault for testing.

Diffoscope tests are already failing on master.


CC: Adjust version variables

I noticed the Image Assurance version needed to be updated when reviewing the CC docs so I've done that. Also I noticed we still had v3.14 in the variables files for CC and I don't think that is correct so I've updated those too.

The image assurance version and the version for the cloud manifests will need a bump.

I've updated the changes here to include the manifest update that was done today (v3.15.1-0 to v3.15.1-1) and that included an update of image assurance to 1.3.4.
I've updated both the unversioned and the version-3.15 for CC.


not use default ingress controller

If you are reporting a problem, please make sure the following information are provided:
Expected behavior and actual behavior:
I created the ingress class and set it as the default ingress (kubectl annotate ingressclasses nginx ingressclass.kubernetes.io/is-default-class=true), when the ingress in the harborcluster does not set the ingressClassName, the rules cannot be created correctly in the ingress controller .
Hope that the ingress rules can be set correctly when spec.export.core.ingress.controller=default
Steps to reproduce the problem:
expose:
    core:
      ingress:
        host: core.harbor.domain
        controller: default

kubectl apply -f
Versions:
Please specify the versions of following systems.

harbor operator version: [main]
harbor version: [2.5.2]
kubernetes version: [1.24.0]
Any additional relevant versions such as CertManager

/assign

$ kubectl -n ingress-nginx logs -f ingress-nginx-controller-7fb5bc6dc-n8xhw
I0808 05:17:45.314996       7 store.go:477] "removing ingress because of unknown ingressclass" ingress="cluster-sample-ns/harborcluster-sample-harbor-harbor"
I0808 05:17:45.315150       7 controller.go:167] "Configuration changes detected, backend reload required"
I0808 05:17:45.599854       7 controller.go:184] "Backend successfully reloaded"

[root@localhost ~]# kubectl get ingressclasses.networking.k8s.io
NAME    CONTROLLER             PARAMETERS   AGE
nginx   k8s.io/ingress-nginx   <none>       7d13h

[root@localhost ~]# kubectl get ingressclasses.networking.k8s.io nginx -o yaml
apiVersion: networking.k8s.io/v1
kind: IngressClass
metadata:
  annotations:
    ingressclass.kubernetes.io/is-default-class: "true"

this question is weird.

/assign


fix issue #49

Hi Mark,
We have used your great Scala implementation of Handlebars in our product qiaobutang.com , and we'd like to join to make it better ~ :-)
BTW, it's glad to extend the Binding interface, we implemented a new Binding to fill json format values and avoid runtime reflection.

@tomatohf I'm glad to hear you used the Binding interface; I was responsible for those changes and have recently submitted a pull-request to include my play-json integration: https://github.com/SpinGo/handlebars.scala/commit/4a7483460122bfab30fac8a5d1b3340d08f599d7
With which JSON library did you integrate?
Being able to bind to a JSON AST allowed us to seamlessly render handlebars templates in both JS land and Scala land, and it worked out relatively well.
Nice catch on your fix, BTW.

@timcharper We integrated lift-json. And we are also using handlebars as templates in both JS and Scala.

Great; do you have the code somewhere? I could help review it and get it ready for merge. The play-json integration was merged into handlebars primary.

I have the code in our private github repository.
It seems there would be another pull request ? If so, could you please point me out where to put the code.
Or, other way preferred?

You could just post a gist
Sent from my iPhone

On Sep 1, 2015, at 08:18, Tomato<EMAIL_ADDRESS>wrote:
I have the code in our private github repository.
It seems there would be another pull request ? If so, could you please point me out where to put the code.
Or, other way preferred?
—
Reply to this email directly or view it on GitHub.

I just found play-json under the addon folder ...

ok, I will add a gist

Here it is => https://gist.github.com/tomatohf/e54bc169da2a2425343f

Well, lol here we are 5 months later!
I merged your gist and made a few modifications to it; it's here: https://github.com/mwunsch/handlebars.scala
Could you write some tests for it? Just mimic the tests for the play-json bindings. Then we'll be good to merge it in.
Thanks!

Sure, I'm glad to add some tests just like what play-json bindings does in addons directory.
While would it be better do that in a new pull request based on the lift-json branch?

@tomatohf sure! Pull request to lift-json branch would be optimal. Or, you could just amend the commit from the lift-json branch and send a pull request for master.


Res101 demo

After the last resnet accurancy improvment results do you plan to adapt the demo for res101 model?

I think that test_net.py it is aligned more then demo.py that still use the old caffe weights.

Writing a demo is not the hardest thing to do... maybe you can submit a better one than the current?

I have a local hack.. I will try to open a PR next week

Is here https://github.com/endernewton/tf-faster-rcnn/pull/37. I've not added mscoco cause I still don't know its status.

Great! Thanks! I will incorporate it and update the readme later today.

Ender X. Chen
Language Technologies Institute,
School of Computer Science,
Carnegie Mellon University, Pittsburgh, PA
On Mon, Apr 3, 2017 at 5:36 AM, bhack<EMAIL_ADDRESS>wrote:

Is here #37 https://github.com/endernewton/tf-faster-rcnn/pull/37. I've
not added mscoco cause I still don't know its status.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/endernewton/tf-faster-rcnn/issues/35#issuecomment-291094579,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACTwEdZAjMZHMAWivCzJOCkNBznyUaspks5rsL23gaJpZM4Mwckv
.

One question.. why you have used custom nms code and not the tf ones?

Ok probably you could contribute nms gpu upstream for https://github.com/tensorflow/tensorflow/issues/7511 😉

Haha thanks!


Order of rows does not match the source file

At least in the .xlsx I used, the line number is represented as a string in the ets table, so Enum.sort will not work as expected: https://github.com/kennellroxco/xlsxir/blob/master/lib/xlsxir.ex#L125.
I handled this by not using get_lines and accessing the ets table directly. I need the row number to display to the user on any validation error, but I don't necessarily need to process the rows in the order of the source file.
I'm also thinking that the use case of iterating the rows could be implemented considerably more efficiently if it was a special case, avoiding a lot of intermediate representations and transformations.

Thanks Paulo. There was a bug...I intended for rows to be represented as integers in the ETS table but they were in fact strings. I've updated that issue and pushed to the repo, so please re-pull and let me know if it resolved the issue you had.
Do you have any specific suggestions with regard to how I could make the row iterations more efficient? I'm currently looking at ways to implement GenStage.Flow to improve performance.

@kennellroxco Thanks! It solved the issue and get_list now returns the rows in the original order.
I may be a bit biased because I'm currently only needing get_list. But it seems the steps parse xml rows -> load into ets kv -> iterate ets and transform to list -> sort list -> map list do a lot of transformations and build intermediate data structures, when the output of the SAX parser could be the final ordered list, already with the final mapping.
But comparing the times of extract and get_list for a 55K row file, it's actually 30s vs 2s. So it seems it's not worth optimizing the get_list use case, unless the actual parsing could run faster for some reason.

Well I'm hoping to optimize the parsing with GenStage.Flow. I'll let you know when I figure something out so you can give it a try and let me know how it goes. Closing this issue for now. Thanks!


PPrecision should create a string, not a float, in the JSON output

I am hoping this is an error in the Vega-Lite 3.3.0 specification - see https://github.com/vega/vega-lite/issues/5190 for a discussion - but PPrecision should be generating a string rather than a float.
(I've finally integrated your test suite into hvega, where I generate the JSON for each test and then compare it against the checked-in version to ensure the output hasn't changed; it means I have a bunch of JSON files I can easily validate against the Vega Lite schema, which finds the odd strange case like this)

Thanks for raising this over on Vega-Lite. Looks like it will be solved in the next VL release https://github.com/vega/vega-lite/pull/5191 and the elm-vegalite and hvega specs can remain as is.


sepolicy: Allow vold to read the tee_prop

This fixes Encryption on (at least) tone devices

please pr the same on master


Update copyright year (1.1.1)

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

This was merged.


TypeError: Cannot read property 'teams' of undefined

Hi,
I am getting the following error when I Press F5 in the same browser and go to https://localhost:3000/tab
Could you please tell me the solution?
TypeError: Cannot read property 'teams' of undefined
Module../src/index.js
C:/Projects/TeamsProjects/MyTeamsApp/src/index.js:11
8 | import { Provider, themes } from '@fluentui/react-northstar' //https://fluentsite.z22.web.core.windows.net/quick-start
9 |
10 | ReactDOM.render(

11 |
12 |
13 |     , document.getElementById('root')
14 | );
View compiled
webpack_require
C:/Projects/TeamsProjects/MyTeamsApp/webpack/bootstrap:784
781 | };
782 |
783 | // Execute the module function
784 | modules[moduleId].call(module.exports, module, module.exports, hotCreateRequire(moduleId));
| ^  785 |
786 | // Flag the module as loaded
787 | module.l = true;
View compiled
fn
C:/Projects/TeamsProjects/MyTeamsApp/webpack/bootstrap:150
147 | 		);
148 | 		hotCurrentParents = [];
149 | 	}
150 | 	return webpack_require(request);
| ^  151 | };
152 | var ObjectFactory = function ObjectFactory(name) {
153 | 	return {
View compiled
1
https://localhost:3000/static/js/main.chunk.js:532:18
webpack_require
C:/Projects/TeamsProjects/MyTeamsApp/webpack/bootstrap:784
781 | };
782 |
783 | // Execute the module function
784 | modules[moduleId].call(module.exports, module, module.exports, hotCreateRequire(moduleId));
| ^  785 |
786 | // Flag the module as loaded
787 | module.l = true;
View compiled
checkDeferredModules
C:/Projects/TeamsProjects/MyTeamsApp/webpack/bootstrap:45
42 | 	}
43 | 	if(fulfilled) {
44 | 		deferredModules.splice(i--, 1);
45 | 		result = webpack_require(webpack_require.s = deferredModule[0]);
| ^  46 | 	}
47 | }
48 |
View compiled
Array.webpackJsonpCallback [as push]
C:/Projects/TeamsProjects/MyTeamsApp/webpack/bootstrap:32
29 | 	deferredModules.push.apply(deferredModules, executeModules || []);
30 |
31 | 	// run deferred modules when all chunks ready
32 | 	return checkDeferredModules();
| ^  33 | };
34 | function checkDeferredModules() {
35 | 	var result;

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8f876156-cc1e-468f-4647-5143a5de03b1
Version Independent ID: 618f43a3-3371-ad99-13aa-087b9303298c
Content: Get started - Build and run your first app - Teams
Content Source: msteams-platform/build-your-first-app/build-and-run.md
Product: msteams
GitHub Login: @heath-hamilton
Microsoft Alias: lajanuar

@Shuvra17 , We are not able to repro this error at our end, Could you please provide repro steps?

Please feel free to reopen if you have further query on this


Problem with using styled-components from an external library as well as locally

Version
> 2.0
Reproduction
We have a UI library built with styled-components that is for use by our team internally as well as with external developers. While this library depends on styled-components, it does not bundle styled components as part of the npm distribution.
Steps to reproduce
Install an npm library that exports components built with styled-components in a React project that also uses styled-component (Create React App in our case)
Expected Behavior
styled-components should work for both the "local" React app and the imported library components.
Actual Behavior
As soon as the library components are imported to the local React app, the local apps styled-components stop working.
I'm guessing this is related to #1032. The temporary fix we've found is to downgrade to 1.4.

Since the StyleSheet will be responsible for any bugs here, we can assume that it's fine as long as it's a singleton. Since you're not installing it in the dependency, we have to investigate more here. Otherwise I don't have anything to go on in this issue.
My guess is that it's the same as #1032, but you haven't found the cause of the duplication.
What would help is:

npm ls styled-components in the parent, and maybe yarn list styled-components
Webpack Stats if the first doesn't show duplication
An output bundle maybe and the sub-dependency package.json
Last but not least, if all else fails, a reproduction repository

For the record, I've found npm ls and yarn list to be unreliable for this kind of problem. Not sure why but they sometimes don't tell you about duplicates. I find asking the filesystem with something as simple as find node_modules | grep /styled-components/package.json works.

I'm not sure if I run into the same bug as described above. Here is a repo for reproduction: https://github.com/danistefanovic/styled-components-keyframes-bug
Let me know if I should open a new issue for this.

Good day, I'm running into the same issue.
I've already established that there are no duplications of styled-components in the project by using find node_modules | grep /styled-components/package.json and the various other commands.
We've got a component library package that we pull in for our individual projects.
Then we have a feature package (with complex redux) than pull in some of the notification components from above.
When both are included in the project only the component library styles render and not the components from the feature package.

This is very likely a duplicate of #1032, so if anybody wants to tackle #1011 that'd be awesome!
If that ships and you're still running into this issue then it's something else, but until then it's fairly safe to assume those are related. Closing for now, please follow #1032 and #1011 instead.

@wmdmark how are you checking for duplication? Is it possible for you to use source-map-explorer or webpack-bundle-analyzer on your application bundle and provide an output here? npm link symlinks modules together, this is more or less the same thing as lerna does on bootstrap

@wmdmark @mxstbr Have been sitting last 2 days with the same issue and been testing different thing out. Here is a webpack-bundle-analyser output for our build.

Our UI lib (marked with red outline in image) is minified via webpack and has styled-components as a devDependencie / peerDependencie) for development i use npm link to use in in our client. When i do NPM ls i stil do get mutiple dependencies even thoug if should be a peerdependencie from the UI package.

My last option now is to do a replication repo witch i will share if it also fails there. I'll get back to you with the repo!

Can you share the webpack config of your UI lib @mansdahlstrom1? Are you excluding styled-components from the bundle correctly?

wepback config in ui package. Not sure if we are excluding it correctly. In our packages json it's listed as a devDependencie not a Dependencie, We have nothing in our webpack config excluding it
import webpack from 'webpack';

module.exports = function (env) {
  return {
    entry: {
      index: `${__dirname}/src`,
    },
    output: {
      filename: 'bundle.min.js',
      libraryTarget: 'umd',
    },
    module: {
      loaders: [
        {
          test: /\.js$/,
          exclude: /(node_modules)/,
          loader: 'babel-loader',
        },
      ],
    },
    plugins: [
      new webpack.DefinePlugin({
        'process.env': {
          NODE_ENV: '"production"',
        },
      }),
      new webpack.LoaderOptionsPlugin({
        minimize: false,
        debug: false,
      }),
      new webpack.optimize.UglifyJsPlugin({
        beautify: false,
        mangle: {
          screw_ie8: true,
          keep_fnames: true,
        },
        compress: {
          screw_ie8: true,
        },
        comments: false,
      }),
    ],
  };
};

Did a small repo with the same setup as we use https://github.com/mansdahlstrom1/styled-component-with-ui-lib/ AND IT WORKED!!!
So thanks for all the help and fast respons times. Seems like this is not a bug and solvable (at least in my case).

@mansdahlstrom1 you have to mark styled-components as external in the webpack configuration, see https://www.styled-components.com/docs/faqs#running-multiple-applications-on-one-page
That has nothing to do whether it's in the devDependencies or normal dependencies in the package.json. :blush: Hope that helps in resolving it in your actual app!

Can you expand on what you mean with that we have marked styled components as external? Not sure regarding what section in the FAQ's you are referring to either. i've tried with some diffrent solution to exclude it from the UI lib without any luck, including the resolve attributes in webpack config on our UI lib.

@mansdahlstrom1 in your library webpack config you could specify styled-components as external module: https://webpack.js.org/configuration/externals/
That way you are guaranteed it is not in your library bundle.
We should probably expand this FAQ section a little bit more, my bad ;)

That sounds good, PR maybe @gribnoysup? :wink:

Thanks! @gribnoysup & @mxstbr working now!

For anyone else landing running into this and landing here, this part of the Styled Components FAQ solved it for me: https://www.styled-components.com/docs/faqs#duplicated-module-in-node_modules
Specifically:

setting styled-components as a peerDependency in my react library
updating the Webpack config in my react app to prioritize it's own node_modules folder

I'm using create-react-app and react-app-rewired, so my config-overrides.js file now looks like this:
const path = require('path');

module.exports = function override(config, env) {

  config.resolve = Object.assign({}, config.resolve, {
    modules: [path.resolve(__dirname, 'node_modules'), 'node_modules'],
  });

  return config;
};

Hope that helps someone else.

@allexysleeps did you ever find a solution to this? I have the same problem, where all app styles are clobbered after importing 1 component from our private lib

@youngrichard
Hi, I've solve this problem by
adding resolve to webpack.config
in the project that is using this library.
resolve: {
    modules: [
      path.resolve(__dirname, 'node_modules'),
    ],
  },

Also check  #Issue that i've created there are some other options that might help you.
#1740

Webpack aliasing is the way to go here as others have mentioned.

@probablyup what if you don’t have access to the Webpack config? CRA is going to ship monorepo support in 2.0 but does not provide any way for the user to configure Webpack.

Running into this issue too...
Does anyone have any workarounds using rollup to get this working? Setting a custom module directory doesn't seem to play with rollup.

@rovansteen https://github.com/styled-components/styled-components/issues/1076#issuecomment-390837273

@christiannaths thanks, I am aware of that solution. But It is a bit ridiculous that you have to do that to be able to use a library that uses styled components.

Agree, I see that more of a CRA issue though. The solution to update your webpack config seems suitable (but not ideal) to me.

@christiannaths I dunno if I'd see this as a CRA issue... most build tools are trending in the direction of zero config. It seems to me that it would be best if styled-components didn't require manually configuring Webpack to behave as expected in a library scenario. I don't fully understand the underlying issue here but styled-components pre 2.0 worked just fine without any special configuration as do other CSS and JS libraries like glamorous etc. It's a bummer styled-components doesn't.

Point taken

This is just the reality of using a singleton library in a multi repo
scenario. React would have the same issue.
On Wed, Jun 27, 2018 at 2:17 PM Mark Johnson<EMAIL_ADDRESS>wrote:

@christiannaths https://github.com/christiannaths I dunno if I'd see
this as a CRA issue... most build tools are trending in the direction of
zero config. It seems to me that it would be best if styled-components
didn't require manually configuring Webpack to behave as expected in a
library scenario. I don't fully understand the underlying issue here but
styled-components pre 2.0 worked just fine without any special
configuration as do other CSS and JS libraries like glamorous etc. It's a
bummer styled-components doesn't.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/styled-components/styled-components/issues/1076#issuecomment-400798438,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAiy1k-Liz-GziRyYLoxqten3iX_VTQ8ks5uA9pTgaJpZM4OyhVo
.

@probablyup React does not have that issue... we're using React + Lerna in our libs just fine with no zero additional config to make it work (same with glamorous). It's only styled-components post 2.0 giving us this issue (and not just us based on the comments above).

Yes because React is likely getting deduped correctly. It’s when the
library isn’t deduped that these problems occur.
On Wed, Jun 27, 2018 at 3:54 PM Mark Johnson<EMAIL_ADDRESS>wrote:

@probablyup https://github.com/probablyup React does not have that
issue... we're using React + Lerna in our libs just fine with no zero
additional config to make it work (same with glamorous). It's only
styled-components post 2.0 giving us this issue (and not just us based on
the comments above).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/styled-components/styled-components/issues/1076#issuecomment-400825745,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAiy1oe3CIwFimX_eOpFP5-ADc53ApXmks5uA_EOgaJpZM4OyhVo
.

I have read up all conversation, but still can't fix the issue in my case
I have monorepo, using lerna, it contains main app and my own library, both of them should have styled-components. In addition I use babel-plugin-styled-components.
my webpack config
const path = require('path');

/* eslint-disable import/no-extraneous-dependencies */
const webpack = require('webpack');
const WriteFilePlugin = require('write-file-webpack-plugin');
const AutoDllPlugin = require('autodll-webpack-plugin');
/* eslint-enable import/no-extraneous-dependencies */

module.exports = {
  name: 'client',
  target: 'web',
  devtool: 'source-map',
  entry: [
    'babel-polyfill',
    'fetch-everywhere',
    'webpack-hot-middleware/client?path=/__webpack_hmr&timeout=20000&reload=false&quiet=false&noInfo=false',
    'react-hot-loader/patch',
    path.resolve(__dirname, '../src/index.js'),
  ],
  output: {
    filename: '[name].js',
    chunkFilename: '[name].js',
    path: path.resolve(__dirname, '../buildClient'),
    publicPath: '/static/',
  },
  module: {
    rules: [
      {
        test: /\.js$/,
        exclude: /node_modules(?!\/shared-business-logic)/,
        use: 'babel-loader',
      },
      {
        test: /\.(png|jpg|gif)$/,
        use: 'file-loader',
      },
    ],
  },
  resolve: {
    extensions: ['.js'],
  },
  plugins: [
    new WriteFilePlugin(), // used so you can see what chunks are produced in dev
    new webpack.optimize.CommonsChunkPlugin({
      names: ['bootstrap'], // needed to put webpack bootstrap code before chunks
      filename: '[name].js',
      minChunks: Infinity,
    }),

    new webpack.HotModuleReplacementPlugin(),
    new webpack.NoEmitOnErrorsPlugin(),
    new webpack.DefinePlugin({
      'process.env': {
        NODE_ENV: JSON.stringify('development'),
      },
    })
  ],
};

I tried adding following code as part of webpack config ```
alias: {
"styled-components": path.resolve(appFolder, "node_modules", "styled-components"),
}

running into this issue using CRA v2... is there a workaround?

Bump on this as well. Getting issues when I try to upgrade styled-components in my React monorepo.
I have three packages in my monorepo, two apps and one UI kit with components that I import into my apps. All apps have their own package.json file and were each running on the same styled-components v2.4.1. I upgraded each one to 4.4.0 after making sure we weren't using anything in our apps that would break with the change and my app crashed, stating it was unable to find t.button, referencing a component being imported from my UI kit.
I then downgraded back to the old version I was using and kept getting the error. I then removed and again added back styled-components several times, each time with a different version, and still received the same error.
After reading this thread I changed my styled-components to v2.0.0 and I'm now getting a working app.


migrate to pug v2

It has been revealed to us that "Jade" is a registered trademark, and as a result a rename is needed and "Pug" was selected


Added note for debugging with serve configurations

Category

[x] Content fix
[ ] New article
Related issues: mentioned in #2127

What's in this Pull Request?
Added note for debugging with serve configurations as suggested in #2127

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/spfx/extensions/get-started/building-simple-field-customizer.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

thx Chris, appreciated.


I'm interested in this project, so I'd like to share some my knowledge

Hello. I'm the author of a Go's JSON library goccy/go-json.
I commented because this is a very interesting project !
I have read through the contents of the README at this time.
I'm developing the above JSON library with the goal of making it more convenient and faster while maintaining compatibility with encoding/json.
Therefore, I think that it has a similar concept to this project, and I'm very much looking forward to the future of this project.
So, I would like to share some knowledge (mainly performance aspect) when developing goccy/go-json. Is it okay to write it here?
The README mentions not to use unsafe, so I understand the policy differences from the library I'm developing.
Including that, I would like to share my knowledge to find useful points.
Also, I know a lot of other 3rd party JSON library's implementations,
so I would like to share the approach to performance improvement in each library if you want.

Hello, and thanks for reaching out :)
You're right that this library has the same design principles as encoding/json, including no unsafe, but also no code generation. We also don't want this library to be very heavy in terms of code size
And, just like the standard library, it prioritises correctness and API usability over performance. The default behavior is a bit slower for the sake of extra sanity checks, for example, which can be disabled by the user.
Over the past year we've mainly worried about the library's design and actually getting it to work, so optimizations haven't been the biggest worry. The design should still allow for good performance, but I would not expect its current version to be among the fastest json libraries today.
With all that in mind, what kind of knowledge would you like to share, or how would you like to contribute? I believe we are already aware of how other fast json libraries work, at a high level, but perhaps there's some specific detail of one of them that would benefit our design or implementation.
Something else you could try is measuring the performance of this library, and looking into the cases where it's significantly slower than you anticipated. That's something we will transition more towards, as we get more confident that the current design and API are decent.

Thank you for your reply ! :)
I also want the standard library to have a simple implementation.
On top of that, I would like to contribute if there are any points that can be improved in terms of designs or implementation.
Regarding the features, I imagine that you have already thoroughly discussed and selected it from among the many feature requests.
Therefore, I wanted to provide useful information on the implementation side in terms of non-feature aspects (e.g. performance).
At this point, I'm not sure what features you're trying to implement as an option,
However, as an example, I would like to introduce the features that we would be happy to offer as an option, primarily in terms of performance.
(First) encoding/json always sorts when encoding a map value. Many performance-focused libraries supports to encode without sorting as the option, so you might want to consider it.
(Second) In decoding the struct field, encoding/json behaves like a win after ( overwrite with what it find later ), but there is no way to determine the duplicated key. In addition, if options can change this behavior on a first win, it will be a performance advantage and may be considered.
As mentioned above, I was hoping to propose an improvement plan while comparing with other libraries about the problems that encoding/json has.
I couldn't think of a place to share it properly, so I wrote here.
Please let me know if there is a more suitable place.
Also, if you're not currently open to accepting ideas and discussions, I'll refrain from commenting.

Hi @goccy, thanks for offering your knowledge!

At this time, I'm not sure what features you're trying to implement as an option,

A recent example is the decision to reject duplicate names by default. The presence of duplicate entries is almost always a bug and is a potential security hole. There's an obvious performance cost to this, but users can opt out by setting RejectDuplicateNames to false. Even though we plan on enabling it by default, there are a number of tricks that we can play to reduce the performance overhead. For example, when unmarshaling into a struct, we always a convert a JSON object name into a Go struct field index. Assuming that most structs have less than 64 fields, we could use a uint64 bitmap to track which names we saw before.

(First) encoding/json always sorts when encoding a map value

We currently do not plan on sorting map keys anymore for several reasons:

The performance hit (as you noted). Most usages do not actually care about the order. For cases where people care about stable serialization, there's the RawValue.Canonicalize method.
We trying to aim for pure streaming encoding/decoding. Sorting goes against the desire to be purely streaming since it's fundamentally cannot sort a stream.

(Second) In decoding the struct field, ...

Can you elaborate more on the relationship between performance and merging into an existing field?

@dsnet

A recent example is the decision to reject duplicate names by default. The presence of duplicate entries is almost always a bug and is a potential security hole.

We currently do not plan on sorting map keys anymore for several reasons

OK, I see. Thank you.

when unmarshaling into a struct, we always a convert a JSON object name into a Go struct field index. Assuming that most structs have less than 64 fields, we could use a uint64 bitmap to track which names we saw before.

I think this is also good.
First, some of the optimizations used by goccy/go-json are listed at https://github.com/goccy/go-json#how-it-works .
Please take a look if you like. The implementation mentioned here is also close here.
I'm in favor of your implementation as I already know that this implementation is good in terms of performance.
Regarding the implementation, what are your thoughts on improvement performance by caching the encoding and decoding process using the address to the type information ?
Also, what are your thoughts on how to use the memory pool on the library side, such as buffer reuse using sync.Pool ( https://github.com/goccy/go-json#buffer-reuse ) ?

First, some of the optimizations used by goccy/go-json are listed at https://github.com/goccy/go-json#how-it-works .

Thank you for suggesting these, but unfortunately most of these we cannot use since they rely on unsafe one way or another.
We do pre-process marshal/unmarshal functionality for a given type. It's as close to your typeToEncoder map as one can get without using unsafe.

Also, what are your thoughts on how to use the memory pool on the library side, such as buffer reuse using sync.Pool ( https://github.com/goccy/go-json#buffer-reuse ) ?

If possible, we'd like to avoid sync.Pool, but I suspect that we'll end up using them in a few places throughout the module.
That said, safety is a high priority for us. Any use of sync.Pool cannot leak buffers to the user. An example of this is that we can't pool the buffer used when calling io.Reader.Read since we cannot prove that the buffer doesn't escape through a user's implementation of the Read method.
Also, CPU performance isn't the only priority either. Use of sync.Pool tends to reduce CPU utilization by the GC, but sometimes at the expense of a lot more memory. Improper use of sync.Pool can cause pinning arbitrary amounts of memory (see golang/go#27735).
For some cases, we would probably provide an explicit API for reuse (e.g., some Reset method). Thus, more control over buffer reuse can be manually done by the user.

Thank you for your answer. I understood your plan.
At this time, there seems to be no information I have that can be communicated without mentioning new features.
I look forward to the success of this project !
Thank you.

@goccy. I recently updated the benchmarks to include correctness tests and I noticed that goccy/go-json non-deterministically fails on some of them.
I'm using v0.10.2.
See https://github.com/go-json-experiment/jsonbench#correctness
You can reproduce the failures by doing:
while true; do go test -run=Roundtrip///GoJSON; done


ARROW-1561: [C++] Kernel implementations for IsIn

@psuman65 Please run the linter and the format checker to fix some formatting issues, as described here https://github.com/apache/arrow/blob/master/docs/source/developers/cpp.rst#code-style-linting-and-ci. Thanks.

@psuman65 is this ready to review?

@psuman65 is this ready to review?
@fsaintjacques Yes it is ready for review.

@fsaintjacques  @emkornfield  just a reminder, this is ready for review. Thanks!!

Codecov Report

Merging #4235 into master will increase coverage by 0.92%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #4235      +/-   ##
=========================================
+ Coverage   88.27%   89.2%   +0.92%
=========================================
  Files         846     696     -150
  Lines      103662   91821   -11841
  Branches     1253       0    -1253
=========================================
- Hits        91512   81912    -9600
+ Misses      11903    9909    -1994
+ Partials      247       0     -247

Impacted Files
Coverage Δ

go/arrow/ipc/writer.go

go/arrow/math/uint64_amd64.go

go/arrow/memory/memory_avx2_amd64.go

go/arrow/ipc/file_reader.go

js/src/enum.ts

go/arrow/array/builder.go

js/src/Arrow.node.ts

js/src/schema.ts

go/arrow/type_traits_boolean.go

js/src/ipc/node/writer.ts

... and 140 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37e6183...649aae4. Read the comment docs.

@emkornfield @fsaintjacques  this is ready for review.

Ready for review.

This is failing CI due to unchecked Status values. If you compile with clang instead of gcc you will be warned about any Status you don't check

I have fixed the unchecked Status values.

@bkietz and @fsaintjacques are both on vacation this week, I need a reviewer to check the implementation logic where there was prior discussion, and then we can merge if no issues

I'll take a look this evening.
On Wed, Jul 17, 2019 at 3:31 PM Wes McKinney<EMAIL_ADDRESS>wrote:

@bkietz https://github.com/bkietz and @fsaintjacques
https://github.com/fsaintjacques are both on vacation this week, I need
a reviewer to check the implementation logic where there was prior
discussion, and then we can merge if no issues
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/arrow/pull/4235?email_source=notifications&email_token=AEIKYDSHC64W2XUZUY4COW3P76MS3A5CNFSM4HJU7OZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2GYWJY#issuecomment-512592679,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEIKYDS67YQA7P7PURTMOF3P76MS3ANCNFSM4HJU7OZQ
.

@wesm @psuman65 I reviewed and I think there is at least one bug in the implementation, and some duplication in allocations that I think should be fixed before merging.

What is the thinking about having two implementations of IsIn, one in C++ and one in Gandiva? Is there way we can start to share these patterns rather than duplicate? I know Gandiva supports runtime compilation. Isn't there a way we can also have LLVM generate build-time outputs for people who don't want to use runtime compilation to avoid duplication of work/maintenance?

I would like (at some point) to see sharing of implementations between pre-compiled kernels and Gandiva. It's definitely not going to happen in this patch, but we should perhaps have a discussion about beginning to be better about coordinating work so we don't duplicate efforts

+1, LGTM

@psuman65 Can you verify I assigned the JIRA issue correctly to you? https://issues.apache.org/jira/browse/ARROW-1561

@psuman65 Can you verify I assigned the JIRA issue correctly to you? https://issues.apache.org/jira/browse/ARROW-1561

@emkornfield  Yes. Its correct.


[BUG] getHsla() can't parse float Hue

Using hsla color (for example "hsla(240.0384227364303,4.12843378950259%,48.71943371204973%,0.3)") causes (at least in bubble chart) error when you hover over bubbles. It is because the getHsla function parses (idk for what) color with regex that does not support float Hue.
Seems like it was fixed here https://github.com/Qix-/color-string/pull/19/files but your fork looks very outdated. Should I make a PR to chartjs-color repo?
Also consider https://github.com/Qix-/color-string/pull/37

@Nakilon a PR to the chartjs-color repo sounds good to me. @simonbrunel thoughts?

Here https://github.com/chartjs/color-string/pull/2/files

@kurkle is this fixed with the switch to your color implementation?

Looks like no. Will be after couple of minutes :)

Fixed in @kurkle/color v0.13


Manjaro Wayland Sway setup gives 0044:fixme:dbghelp:elf_search_auxv can't find symbol in module

Followed instructions exactly.

Hello @seanluse41,
Can you copy all command line result?
Did you check if any previous command had any problem?

Closed by no reply


FIX? pin julia version to <1.10.1

Temporary fix as 1.10.1 seems to have broken some downloads functionalities : https://github.com/JuliaLang/julia/issues/53339, causing the tests to fail on main

Codecov Report

Merging #682 (b51994f) into main (6f7da9b) will decrease coverage by 0.03%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #682      +/-   ##
==========================================
- Coverage   54.60%   54.57%   -0.03%
==========================================
  Files          45       45
  Lines        2934     2937       +3
  Branches      542      543       +1
==========================================
+ Hits         1602     1603       +1
- Misses       1207     1208       +1
- Partials      125      126       +1


[Helm][Add] Support for k8s affinity & tolerations / ServiceMonitor relabelings and metricRelabelings

Improved helm chart with the following:

Bumping chart/app version to 0.11.0
Added support affinity and tolerations rules
Added support for Prometheus relabeling and metric relabeling via Prometheus OP's ServiceMonitor

Hello there, @Stephan3555 @iamabhishek-dubey
I would like to know when this code will be merged after the approval.
Thank you

Can I have some feedback on this?


vcpkg.targets should not automatically attempt to link in every single installed library

Currently the vcpkg targets file adds *.lib as extra dependencies to the link step, what's more, it adds them before anything that it's possible for the user to specify. This means that the user has absolutely no control what-so-ever over what libraries are searched for symbols. This becomes a significant problem when multiple libraries provide the same symbols. In the case that bit me today, gmock_main.lib includes the symbols for gmock.lib in addition to a main function that correctly starts up gflags and runs the available tests. gmock.lib itself further includes every symbol from gtest.lib in addition to the actual mocking library. This means that, regardless of what the user wanted, if they reference a symbol in gtest, they will always link against gmock.lib, because it comes first in the link order. This isn't a big deal for gtest symbols, but when a program is expecting to link against gmock_main.lib, the only function that gets resolved to there is main, every other function gets resolved to gmock.lib, with the net result that no tests are found by the testing framework and everything is very sad :(
I just spent the last 2 hours cleaning, building, and rebuilding my CMake configuration, target configs and every last one of my tests because of this :(
Adding the vcpkg directories as search directories is fine; adding every library as an input is not.

First, thank you for bringing up the issue with gtest/gmock; I'm sincerely sorry that it cause you so much pain :(. I believe I've fixed the issue on the fix-auto-link branch and it passes my local tests, but I'd like you to try it out first to ensure your projects work exactly as you'd like as well.
MSBuild
What we are trying to implement using *.lib is providing the equivalent of #pragma comment(lib, X) for every library while using MSBuild (scroll down for the situation with CMake). This is a popular technique for libraries which hold Windows as a primary platform (boost, for example), but many cross-platform libraries aren't very interested in implementing and maintaining MSVC specific directives.
In the case of per-project package managers, this is an essential feature (NuGet, conan, hunter, etc). In the general case of system package managers, this is completely impossible because decisions are (rarely, but often enough) made during the link process like the issue you hit above: Do I implement main or does gmock implement main for me? Do I use version X or version Y? In the case of Vcpkg, due to the specific constraints we have placed on the system, the vast majority of libraries (99%+) will not have decisions to be made at link time. All decisions about the binary (version/compiler/flags/etc) are made via the portfile.cmake and the triplet file. We know the exact .lib that matches the #include <openssl/openssl.h> you included and there is no issue with mismatch. The linker will automatically discard any .libs that you don't need, because you aren't importing any of their symbols.
However, there are some pitfalls just like the one you hit above! For some reason, it seems gmock and gtest didn't factor their symbols into uniquely-owning DLLs and instead gtest is a complete subset of gmock. If they were different packages, this would clearly be a violation of the good library citizen contract: don't re-export someone else's symbols! However, since they're both in the same source repository, and the library is quite popular, and the official guidance is to replace your gtest.lib link with gmock.lib when using gmock, this requires an exception. We fully anticipate there to be few, but more of these cases in the future.
To address this issue, I have added a subdirectory of lib\ called manual-link which will always be opted-out of any autolinking we perform. This will allow libraries which step beyond the bounds of a "normal" library (such as defining _main), to always opt-out of automatic linking. This subdirectory will be available on your link path (along with the normal lib) so that you can simply list gmock_main.lib in your AdditionalDependencies when using MSBuild or use it in a target_link_libraries() directive in CMake.
Additionally, you're totally right that some developers will want to use the link line as a "final defense" against pulling in additional dependencies. To this end, I've also added an MSBuild property called VcpkgAutoLink which when set to false will completely disable the automatic linking for your projects (you will still get the include and lib paths).
CMake
Above, I mentioned MSBuild; what about CMake? CMake is designed from the ground up to allow your project to be as platform agnostic as possible, so this functionality should be entirely opt-in for CMake projects, if available, to mimic other platforms as closely as possible. We previously had a bug which would enable the autolinking for MSBuild projects generated via our CMake toolchain -- I have also fixed that bug in 32157f8 so if you're currently using CMake for your projects that should fix the issue for you.
Finally, thanks for also bringing up the issue that we're adding the include and lib paths ahead of the user-specified paths! I believe I've fixed that issue in the above commit as well.

It's taken me a bit to get to testing this, but I'll hopefully be able to later tonight or tomorrow.

Well, I got a chance to test it sooner than I thought I would. Everything builds (and works) as I would expect, although I end up with this as the "Additional Library Directories" for the Visual Studio projects generated by CMake:
C:/Projects/vcpkg/scripts/buildsystems/../../installed/x64-windows/debug/lib/manual-link
C:/Projects/vcpkg/scripts/buildsystems/../../installed/x64-windows/debug/lib/manual-link/$(Configuration)
C:/Projects/vcpkg/scripts/buildsystems/../../installed/x64-windows/lib/manual-link
C:/Projects/vcpkg/scripts/buildsystems/../../installed/x64-windows/lib/manual-link/$(Configuration)

Although it's mostly the ones with $(Configuration) that I question, I wonder, is it really necessary to add the lib paths to the VS projects themselves if they've already been added when CMake ran and did it's configuration? CMake should have already resolved the absolute path to the libraries, and that's what should be getting linked in, so the individual projects shouldn't actually need the library directory set.

I think this is CMake's doing -- we're not automatically adding those as far as I'm aware. I just appended them to CMAKE_LIBRARY_PATH. It shouldn't hurt anything, since we shouldn't have any subdirectories there.

@Everyone, was this issue reported as a bug if so was it fixed?


[AMORO-2] Flink support for Setting/Altering Amoro table properties

Why are the changes needed?

Close #2.
Brief change log

Flink support for Setting/Altering Amoro table properties
Add Tests about change the key properties

How was this patch tested?

[x] Add some test cases that check the changes thoroughly including negative and positive cases if possible
[ ] Add screenshots for manual tests if appropriate
[x] Run test locally before making a pull request

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (not documented)

Thanks for your contribution.
I wonder why use a legacy test to support this new feature, which doesn't quite make sense

It seems a little confusion
As I know, LEGACY Type is for this case
CREATE CATALOG <catalog_name> WITH (
  'type'='arctic',
);

we will have four catalog type in the future
https://github.com/NetEase/amoro/blob/d0f613fc26aafded9f40ed489a8df3dce4dfb86a/mixed/flink/flink-common/src/main/java/com/netease/arctic/flink/catalog/factories/CatalogFactoryOptions.java#L34

So we have Three Test case:

TestLegacyMixedCatalog (tset case for type='arctic')

TestMixedCatalog containe (tset case for type='mixed_iceberg' , type='mixed_hive')

FlinkUnifiedCatalogITCase (tset case for type='unified')

But now, some test cases for type='mixed_iceberg' type='mixed_hive' is below TestLegacyMixedCatalog. It make confusion.
https://github.com/NetEase/amoro/blob/d0f613fc26aafded9f40ed489a8df3dce4dfb86a/mixed/flink/flink-common/src/test/java/com/netease/arctic/flink/catalog/TestLegacyMixedCatalog.java#L111

Maybe we could do some adjust in the future and make TestCase for different Catalog type more clearly @YesOrNo828 HDYT

Thanks for your contribution.
I wonder why use a legacy test to support this new feature, which doesn't quite make sense

It seems a little confusion As I know, LEGACY Type is for this case
CREATE CATALOG <catalog_name> WITH (
  'type'='arctic',
);

we will have four catalog type in the future
https://github.com/NetEase/amoro/blob/d0f613fc26aafded9f40ed489a8df3dce4dfb86a/mixed/flink/flink-common/src/main/java/com/netease/arctic/flink/catalog/factories/CatalogFactoryOptions.java#L34

So we have Three Test case:

TestLegacyMixedCatalog (tset case for type='arctic')
TestMixedCatalog containe (tset case for type='mixed_iceberg' , type='mixed_hive')
FlinkUnifiedCatalogITCase (tset case for type='unified')

But now, some test cases for type='mixed_iceberg' type='mixed_hive' is below TestLegacyMixedCatalog. It make confusion.
https://github.com/NetEase/amoro/blob/d0f613fc26aafded9f40ed489a8df3dce4dfb86a/mixed/flink/flink-common/src/test/java/com/netease/arctic/flink/catalog/TestLegacyMixedCatalog.java#L111

Maybe we could do some adjust in the future and make TestCase for different Catalog type more clearly @YesOrNo828 HDYT

Thank you for your clarification. We will divide it in detail in Flink's unit test compilation

TestLegacyMixedCatalog (tset case for type='arctic')
TestMixedCatalog containe (tset case for type='mixed_iceberg' , type='mixed_hive')
FlinkUnifiedCatalogITCase (tset case for type='unified')

Thanks for your contribution.
I wonder why use a legacy test to support this new feature, which doesn't quite make sense

It seems a little confusion As I know, LEGACY Type is for this case
CREATE CATALOG <catalog_name> WITH (
  'type'='arctic',
);

we will have four catalog type in the future
https://github.com/NetEase/amoro/blob/d0f613fc26aafded9f40ed489a8df3dce4dfb86a/mixed/flink/flink-common/src/main/java/com/netease/arctic/flink/catalog/factories/CatalogFactoryOptions.java#L34

So we have Three Test case:

TestLegacyMixedCatalog (tset case for type='arctic')
TestMixedCatalog containe (tset case for type='mixed_iceberg' , type='mixed_hive')
FlinkUnifiedCatalogITCase (tset case for type='unified')

But now, some test cases for type='mixed_iceberg' type='mixed_hive' is below TestLegacyMixedCatalog. It make confusion.
https://github.com/NetEase/amoro/blob/d0f613fc26aafded9f40ed489a8df3dce4dfb86a/mixed/flink/flink-common/src/test/java/com/netease/arctic/flink/catalog/TestLegacyMixedCatalog.java#L111

Maybe we could do some adjust in the future and make TestCase for different Catalog type more clearly @YesOrNo828 HDYT

Thank you for your clarification. We will divide it in detail in Flink's unit test compilation

Thanks, I had mdde an issue https://github.com/NetEase/amoro/issues/2640, and I will create a PR In recent days.


fix(SP-1221): adding missing dist files

@cesarlugoe we were missing the dist files. That was it

Can we update the documentation to have this present?


Notification Module

Notify.yaml needs to be updated with the following contents
name: Notify
on:
release:
types: [published]
jobs:
notify:
uses: cloud-native-toolkit/action-workflows/.github/workflows/notify.yaml@v1
secrets:
TOKEN: ${{ secrets.TOKEN }}

Updated AND verified the build is successful


UX improvements while deploying k8s on vsphere

Few UX issues are mentioned @ https://github.com/vmware/kubernetes/issues/249
Below issues addressed:

Where ever vCenter Inventory Resource is automatically created by Kubernetes-Anywhere (For example Folder) specify in the prompt, that object will be created if not present in the inventory. And for objects which needs to be present and kubernetes-anywhere can not create, specify in the user prompt with text - "Existing", so user knows that this object should be already present in the inventory. (For example Resource Pool, which can not be created by Kubernetes-Anywhere)

Put a note that all ESX host should have time in sync, else some of the node can remain in pending state for ever due to certificate expired certificate. Node VM inherits time from the esx host.

At present node VMs has sequence node1, node2 ..., instead append some unique char sequence, so that multiple clusters can be deployed in the same working directory folder. with this change -master, -node1 .... VM names will be used.

When user specifies that he wants to deploy 4 node cluster, in the end Kubernetes-Anywhere is waiting for 5 nodes to become healthy. This is because 5th node is the master node, specify this in the message so that user does not get confused.

This also fixes https://github.com/kubernetes/kubernetes-anywhere/issues/375
@divyenpatel, @BaluDontu, @tusharnt, @luomiao

/assign @pipejakob
/assign @madhusudancs
/assign @luxas
/assign @shashidharatd
Hello guys, can you please take a look at changes?

i think phase1/vsphere/kubernetes/terraform.tfstate got included in commit by mistake. can you please remove that from commit.

@rohitjogvmw Any chance we could move from ignition and start using kubeadm for vSphere here instead?

@luxas Yes we can take a look at kubeadm instead of using ignition image, can you share pointers and instructions on how to use it?

@msterin Here is the Interactive session
Make Config
[container]:/opt/kubernetes-anywhere> make config
CONFIG_="." kconfig-conf Kconfig
*
* Kubernetes Minimal Turnup Configuration
*
*
* Phase 1: Cluster Resource Provisioning
*
number of nodes (phase1.num_nodes) [4] (NEW)
kubernetes cluster name (phase1.cluster_name) [kubernetes] (NEW)
SSH user to login to OS for provisioning (phase1.ssh_user) [] (NEW)
*
* cloud provider: gce, azure or vsphere
*
cloud provider: gce, azure or vsphere (phase1.cloud_provider) [vsphere] (NEW)
  *
  * vSphere configuration
  *
  vCenter URL Ex: <IP_ADDRESS> or myvcenter.io (without https://) (phase1.vSphere.url) [] (NEW) <IP_ADDRESS>
  vCenter port (phase1.vSphere.port) [443] (NEW)
  vCenter username (phase1.vSphere.username) [] (NEW<EMAIL_ADDRESS>  vCenter password (phase1.vSphere.password) [] (NEW) Admin!23
  Does host use self-signed cert (phase1.vSphere.insecure) [Y/n/?] (NEW) Y
  Datacenter (phase1.vSphere.datacenter) [datacenter] (NEW) vcqaDC
  Datastore (phase1.vSphere.datastore) [datastore] (NEW) vsanDatastore
  Deploy Kubernetes Cluster on 'host' or 'cluster' (phase1.vSphere.placement) [cluster] (NEW)
    vsphere cluster name. Please make sure that all the hosts in the cluster are time-synchronized otherwise some of the nodes can remain in pending state for ever due to expired certificate (phase1.vSphere.cluster) [] (NEW) cluster-vsan-1
  Do you want to use the existing resource pool on the host or cluster? [yes, no] (phase1.vSphere.useresourcepool) [no] (NEW)
  VM Folder name or Path (e.g kubernetes, VMFolder1/dev-cluster, VMFolder1/Test Group1/test-cluster). Folder path will be created if not present (phase1.vSphere.vmfolderpath) [kubernetes] (NEW)
  Number of vCPUs for each VM (phase1.vSphere.vcpu) [1] (NEW) 2
  Memory for VM (phase1.vSphere.memory) [2048] (NEW) 2048
  Network for VM (phase1.vSphere.network) [VM Network] (NEW)
  Name of the template VM imported from OVA. If Template file is not available at the destination location specify vm path (phase1.vSphere.template) [KubernetesAnywhereTemplatePhotonOS.ova] (NEW) KubernetesAnywhereTemplatePhotonOS
  Flannel Network (phase1.vSphere.flannel_net) [<IP_ADDRESS>/16] (NEW)
*
* Phase 2: Node Bootstrapping
*
kubernetes version (phase2.kubernetes_version) [v1.6.5] (NEW)
bootstrap provider (phase2.provider) [ignition] (NEW)
  installer container (phase2.installer_container) [docker.io/cnastorage/k8s-ignition:v2] (NEW)
  docker registry (phase2.docker_registry) [gcr.io/google-containers] (NEW)
*
* Phase 3: Deploying Addons
*
Run the addon manager? (phase3.run_addons) [Y/n/?] (NEW)
  Run kube-proxy? (phase3.kube_proxy) [Y/n/?] (NEW)
  Run the dashboard? (phase3.dashboard) [Y/n/?] (NEW)
  Run heapster? (phase3.heapster) [Y/n/?] (NEW)
  Run kube-dns? (phase3.kube_dns) [Y/n/?] (NEW)
  Run weave-net? (phase3.weave_net) [N/y/?] (NEW)
#
# configuration written to .config
#

Make Deploy
[container]:/opt/kubernetes-anywhere> make deploy
util/config_to_json /opt/kubernetes-anywhere/.config > /opt/kubernetes-anywhere/.config.json
make do WHAT=deploy-cluster
make[1]: Entering directory '/opt/kubernetes-anywhere'
.
.
.
KUBECONFIG="$(pwd)/phase1/vsphere/kubernetes/kubeconfig.json" ./util/validate
Validation: Expected 5 (workers + master) healthy nodes; found 0. (10s elapsed)
Validation: Expected 5 (workers + master) healthy nodes; found 2. (20s elapsed)
Validation: Expected 5 (workers + master) healthy nodes; found 5. (30s elapsed)
Validation: Success!

[container]:/opt/kubernetes-anywhere> export KUBECONFIG="$(pwd)/phase1/vsphere/kubernetes/kubeconfig.json"
[container]:/opt/kubernetes-anywhere> kubectl get nodes

Hi @luxas,
Let me take that up as a separate change.

Hi @shashidharatd,
Thanks for the review.
I have removed the file.

Hi @luxas,
Let me take that up as a separate change.

Sounds good to me @rohitjogvmw! Can you please file an issue about it so we can track this?
I'd love to sync with you about how we can get that done, I think it will give benefit to both parts so we don't do duplicate work between ignition here and kubeadm which will be the generic solution going forward.
Thanks!

@rohitjogvmw, the changes LGTM, Just rebase the commits to remove merge commit and also remove unnecessary commits.

@shashidharatd  I have rebased.
Can you please merge if all is looking good.


[dev-tool] Use tsx

Packages impacted by this PR
@azure/dev-tool
Issues associated with this PR
Resolves #29672
Describe the problem that is addressed by this PR
With the move to ESM and tshy we've been running into issues using the existing TS_NODE
based loader in dev-tool. Specifically we're seeing errors such as:
[run-samples] Error: Must use import to load ES Module: D:\a_work\1\s\sdk\template\template\samples-dev\getConfigurationSetting.ts
require() of ES modules is not supported.
require() of D:\a_work\1\s\sdk\template\template\samples-dev\getConfigurationSetting.ts from D:\a_work\1\s\common\tools\dev-tool\src\commands\samples\run.ts is an ES module file as it is a .ts file whose nearest parent package.json contains "type": "module" which defines all .ts files in that package scope as ES modules.
Instead change the requiring code to use import(), or remove "type": "module" from D:\a_work\1\s\sdk\template\template\package.json.

ts-node is being phased out for tsx, a modern alternative that handles hybrid scenarios like us in much simpler manner.
This PR switches our loader from ts-node to tsx. Now we can run samples again for both cjs and esm!
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR: (Applicable only to SDK release request PRs)
Checklists

[ ] Added impacted package name to the issue description.
[ ] Does this PR need any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here.)
[ ] Added a changelog (if necessary).

/azp run js - keyvault-certificates - tests

/azp run js - keyvault-secrets- tests

Passing live tests (including samples!):

keyvault-certificates (using ESM and tshy)
keyvault-secrets (using CJS)

/azp run js - template - tests

API change check
API changes are not detected in this pull request.


AVX2 intrinsic run on non-AVX2 supporting hardware

Not sure if this is a Blosc or Zarr (soon to be Numcodecs) issue, but wanted to start here as this is where I'm able to reproduce the issue ATM.
Recently I built a copy of Zarr with its vendored Blosc in the Docker image condaforge/linux-anvil on my Mac with Docker for Mac. Now my Mac supports AVX2 instructions. However, some of the cluster nodes on our cluster do not have AVX2 support, but only have AVX support instead (e.g. Sandy Bridge cores).
When trying to create a simple Zarr array on a Sandy Bridge based node, I noticed that as soon as I tried to store data I would get a crash and a core dump (see code snippet below). It turns out if I disable compression, this problem goes away. However, it will occur if the default compression (LZ4) is enabled. Also if I ran this same code on a node supporting AVX2 instructions (e.g. Haswell cores), then the code ran fine without issues.
Python reproducer:

In [1]: import zarr

In [2]: z = zarr.create(shape=(1,2,3,4), dtype=float)

In [3]: z[:] = 5
Illegal instruction (core dumped)

Looking at the core dump, I can see that an assembly call to vinserti128 (see assembly trace) caused the crash. As noted by the reference, this is an AVX2 instruction. It appears the crash occurred in the Cython compression function. The fact that it occurred in the compression function is not surprising. Though the fact that it occurred in the Cython code is a bit surprising (maybe I'm misreading).
GDB Debugging:

$ gdb python core.23713
GNU gdb (GDB) Red Hat Enterprise Linux 7.6.1-80.el7
Copyright (C) 2013 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-redhat-linux-gnu".
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>...
Reading symbols from /groups/dudman/home/kirkhamj/miniconda/envs/ztest/bin/python2.7...done.

warning: core file may not match specified executable file.
[New LWP 23713]
[New LWP 23716]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
Core was generated by `/groups/dudman/home/kirkhamj/miniconda/envs/ztest/bin/python /groups/dudman/hom'.
 So even if the library was built with AVX2 support, the AVX2 code path would not be used on a machine that does not have AVX2 support. Instead it would use a different code path (perhaps an AVX one). However, based on this error, this appears not to be the case.

@FrancescAlted can you comment? I know in the past you have said that Blosc can be compiled on a machine with AVX2 and then run on a machine without. Source code for the Cython extension that calls blosc_compress/blosc_compress_ctx is here.
@jakirkham could you try running this but first setting zarr.blosc.use_threads = False and then once again with zarr.blosc.use_threads = True and see if you get the error under both. This would establish whether the error occurs when Zarr is calling blosc_compress_ctx or blosc_compress or both.

@jakirkham could you also try the following compressors:

zarr.Zlib(level=1)
zarr.Blosc(cname='lz4', clevel=1, shuffle=0)
zarr.Blosc(cname='lz4', clevel=1, shuffle=1)
zarr.Blosc(cname='lz4', clevel=1, shuffle=2)
zarr.Blosc(cname='zstd', clevel=1, shuffle=0)

In Blosc it's the shuffle filters that use AVX2 so disabling shuffle should avoid any AVX2 instructions.

Setting use_threads as either True or False seems to run into the same issue. Disassembled both cases and found the same line caused the problem in each.
Tried all of the compressors listed above. Only the Zlib compressor did not have issues. All of the other ones with or without shuffle ran into the same issue. Disassembled all of these cases and verified that they all lead back to the same line.

Many thanks. I may be wrong, but the fact that the problem still arises
with Blosc(..., shuffle=0) suggests it is not something to do with the
accelerated Blosc shuffle filters.
On Wednesday, March 1, 2017, jakirkham<EMAIL_ADDRESS>wrote:

Setting use_threads as either True or False seems to run into the same
issue. Disassembled both cases and found the same line caused the problem
in each.
Tried all of the compressors listed above. Only the Zlib compressor did
not have issues. All of the other ones with or without shuffle ran into the
same issue. Disassembled all of these cases and verified that they all lead
back to the same line.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/alimanfoo/zarr/issues/136#issuecomment-283232434, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAq8Qj2oMAp09huzqurCFt0TWoGoR7_Zks5rhOHdgaJpZM4MO-Hl
.

--
Alistair Miles
Head of Epidemiological Informatics
Centre for Genomics and Global Health http://cggh.org
The Wellcome Trust Centre for Human Genetics
Roosevelt Drive
Oxford
OX3 7BN
United Kingdom
Email<EMAIL_ADDRESS>Web: http://purl.org/net/aliman
Twitter: https://twitter.com/alimanfoo
Tel: +44 (0)1865 287721

Hi.  Yes, Blosc has protection against this in runtime, but I have double checked that Blosc has not any call to vinserti128, so the issue should be not inside Blosc itself.  What is probably happening here is that, by compiling the Zarr Cython extension on a machine which has support for AVX2, it is generating AVX2 instructions that cannot be executed in non-AVX2 hardware.  If you absolutely need complete compatibility with non AVX2, then you should avoid generating AVX2 symbols in your compile chain (probably using the flag -msse2, and avoiding -march=native would be useful).

Thanks Francesc.
On Wed, Mar 1, 2017 at 10:35 AM, Francesc Alted<EMAIL_ADDRESS>wrote:

Hi. Yes, Blosc has protection against this in runtime, but I have double
checked that Blosc has not any call to vinserti128, so the issue should be
not inside Blosc itself. What is probably happening here is that, by
compiling the Zarr Cython extension on a machine which has support for
AVX2, it is generating AVX2 instructions that cannot be executed in
non-AVX2 hardware. If you absolutely need complete compatibility with non
AVX2, then you should avoid generating AVX2 symbols in your compile chain
(probably using the flag -msse2, and avoiding -march=native would be
useful).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/alimanfoo/zarr/issues/136#issuecomment-283304842, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAq8QqKzmu3AHsrsDUYtA2ekyse8pF7Bks5rhUn4gaJpZM4MO-Hl
.

--
Alistair Miles
Head of Epidemiological Informatics
Centre for Genomics and Global Health http://cggh.org
The Wellcome Trust Centre for Human Genetics
Roosevelt Drive
Oxford
OX3 7BN
United Kingdom
Email<EMAIL_ADDRESS>Web: http://purl.org/net/aliman
Twitter: https://twitter.com/alimanfoo
Tel: +44 (0)1865 287721

@jakirkham would it help if zarr/numcodecs exposed some option to manually
disable AVX2 compile options, even if AVX2 support is detected on the
compiling machine?
I'm not sure what the best way to do this would be, would need to provide
some option that could be detected within setup.py. An environment variable
(e.g., NOAVX2=True)?
On Wed, Mar 1, 2017 at 11:53 AM, Alistair Miles<EMAIL_ADDRESS>wrote:

Thanks Francesc.
On Wed, Mar 1, 2017 at 10:35 AM, Francesc Alted<EMAIL_ADDRESS>wrote:

Hi. Yes, Blosc has protection against this in runtime, but I have double
checked that Blosc has not any call to vinserti128, so the issue should be
not inside Blosc itself. What is probably happening here is that, by
compiling the Zarr Cython extension on a machine which has support for
AVX2, it is generating AVX2 instructions that cannot be executed in
non-AVX2 hardware. If you absolutely need complete compatibility with non
AVX2, then you should avoid generating AVX2 symbols in your compile chain
(probably using the flag -msse2, and avoiding -march=native would be
useful).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/alimanfoo/zarr/issues/136#issuecomment-283304842,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAq8QqKzmu3AHsrsDUYtA2ekyse8pF7Bks5rhUn4gaJpZM4MO-Hl
.

--
Alistair Miles
Head of Epidemiological Informatics
Centre for Genomics and Global Health http://cggh.org
The Wellcome Trust Centre for Human Genetics
Roosevelt Drive
Oxford
OX3 7BN
United Kingdom
Email<EMAIL_ADDRESS>Web: http://purl.org/net/aliman
Twitter: https://twitter.com/alimanfoo
Tel: +44 (0)1865 287721 <+44%201865%20287721>

--
Alistair Miles
Head of Epidemiological Informatics
Centre for Genomics and Global Health http://cggh.org
The Wellcome Trust Centre for Human Genetics
Roosevelt Drive
Oxford
OX3 7BN
United Kingdom
Email<EMAIL_ADDRESS>Web: http://purl.org/net/aliman
Twitter: https://twitter.com/alimanfoo
Tel: +44 (0)1865 287721

Looks like using an environment variable is the usual way to go to disable features, e.g., sqlalchemy uses "DISABLE_SQLALCHEMY_CEXT" which if set .

+1 for the environment variable.  This is very easy to set without a need to touch any config file.

I've added support for this in numcodecs: https://github.com/alimanfoo/numcodecs/pull/26/files
I don't think it's worth adding to Zarr as numcodecs is ready for a 0.1 release and so I'll be pulling the codecs out of Zarr shortly.

Numcodecs 0.1.0 released. Waiting on conda-forge, then will crack on with #74.

Thanks @alimanfoo and @FrancescAlted. This seems like a reasonable fix.
That said, it would be good if we could still compile the properly guarded code paths with the supported level of SSE and AVX instructions. This way one still can leverage AVX2 instructions on supported hardware, but not on unsupported hardware. I can imagine two approaches to this.
First approach, provide an option to devendor Blosc and use an external implementation. Second approach, build each portion that is properly guarded with the desired level of optimizations and link them with the Python bindings (with standard level of optimization, no AVX and SSE2?). While they are pretty different approaches, I suspect these strategies can leverage each other. Namely numcodecs build system could start treating Blosc as something it builds and then links to.

First approach, provide an option to devendor Blosc and use an external implementation. Second approach, build each portion that is properly guarded with the desired level of optimizations and link them with the Python bindings (with standard level of optimization, no AVX and SSE2?). While they are pretty different approaches, I suspect these strategies can leverage each other. Namely numcodecs build system could start treating Blosc as something it builds and then links to.

Sorry, not sure I understand either option. Could you explain a little?

Basically it would be nice to have some option to specify an externally built Blosc library for Zarr to use.

This discussion probably should be moved to numcodecs, right?

Yep.
On Tue, Oct 24, 2017 at 11:43 PM, jakirkham<EMAIL_ADDRESS>wrote:

This discussion probably should be moved to numcodecs, right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/alimanfoo/zarr/issues/136#issuecomment-339158768, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAq8Qj1MKyccIpmDlW4CvfeXTc9pZ1NUks5svmgdgaJpZM4MO-Hl
.

--
Alistair Miles
Head of Epidemiological Informatics
Centre for Genomics and Global Health http://cggh.org
Big Data Institute Building
Old Road Campus
Roosevelt Drive
Oxford
OX3 7LF
United Kingdom
Phone: +44 (0)1865 743596
Email<EMAIL_ADDRESS>Web: http://a http://purl.org/net/alimanlimanfoo.github.io/
Twitter: https://twitter.com/alimanfoo

This problem has been solved with PR ( https://github.com/zarr-developers/numcodecs/pull/26 ) and PR ( https://github.com/zarr-developers/numcodecs/pull/27 ). So am going to close it out. Thanks to both of you for helping tackle this one.
Independently it would be nice to handle runtime detection and selection of AVX2 instructions. However that is a different problem. Raised as issue ( https://github.com/zarr-developers/numcodecs/issues/67 ).


infinite symlink: /tmp/devenv-XXX/devenv-XXX -> /tmp/devenv-XXX

Describe the bug
Currently it seems that any devenv creates a devenv-XXX directory in /tmp and creates a symlink in there that points to the same directory.
$ ls -l /tmp/devenv-*/
/tmp/devenv-f4c9edc/:
total 0
lrwxrwxrwx 1 bob.vanderlinden users 19 Apr  5 00:03 devenv-f4c9edc -> /tmp/devenv-f4c9edc

Tools like vite will run into errors when recursing into these directories:
Error: ELOOP: too many symbolic links encountered, stat '.../.devenv/run/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1/devenv-4b8b6c1

Are these symlinks cause of a bug or are they intentionally created?
To reproduce
From what I can tell, these symlinks are created for all devenvs (there are tons of /tmp/devenv-* and all consistently have the symlink).
I ran this in a project using:
{
  languages.javascript.enable = true;
}

And which also uses vite.
Version
devenv 1.0.2 (x86_64-linux)

I'm looking into this, but can't see what's creating the symlink.

++++ mkdir -p /run/user/1000/devenv-0fcf29a
++++ ls /run/user/1000/devenv-0fcf29a
devenv-0fcf29a


Increases the Size of Questions of Practice mode

Fixes : #21
here is the issue : https://github.com/eduardconstantin/azure-fundamentals/issues/21

[X] I have read and agree to the Code of Conduct, and have followed the Contributing guidelines.

Summary

@SAGARSINGH-1 for the next PR make sure you create a branch from dev branch, not main.

@SAGARSINGH-1 I can't merge from dev on your branch, you need to do it

Perfect! Thank you!


DisplayThreadDispatcher is Garbage Collected

Hi,
I am trying to use the VlcControl without XAML. It works but sometimes randomly it will through InvalidOperationException with message:
"VlcPlayer not be ready, if you want to use VlcPlay no in XAML, please read this Wiki: "https://github.com/higankanshi/Meta.Vlc/wiki/Use-VlcPlayer-with-other-controls\".
I need to load the control into the view tree programmatically through the C# code. And I followed the wiki article.
Can you please help?

You need use VlcPlayer(Dispatcher customDisplayThreadDispatcher) and VlcPlayer(bool displayWithThreadSeparatedImage) in CS code.
Which constructor did you use?
Can you give me your code which initialize the VlcPlayer.