[CI][Packaging][Java] java-jars job fail on macOS aarch_64

Describe the bug, including details regarding any error messages, version, and platform.
The java-jars job is currently failing on Build C++ libraries macOS aarch_64
This error is also happening on the maintenance branch for 13.0.0:
https://github.com/apache/arrow/pull/36616#issuecomment-1680342110
https://github.com/ursacomputing/crossbow/actions/runs/5877563237/job/15937924010
The error is the following:
 -- Performing Test CXX_LINKER_SUPPORTS_VERSION_SCRIPT
 -- Performing Test CXX_LINKER_SUPPORTS_VERSION_SCRIPT - Failed

There's a bunch of Warnings but I am pretty sure they are not related:
CMake Warning at /Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/arrow/cpp-build/cpp-install/lib/cmake/Arrow/FindThriftAlt.cmake:56 (find_package):
  By not providing "FindThrift.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "Thrift", but
  CMake did not find one.

  Could not find a package configuration file provided by "Thrift" with any
  of the following names:

    ThriftConfig.cmake
    thrift-config.cmake

  Add the installation prefix of "Thrift" to CMAKE_PREFIX_PATH or set
  "Thrift_DIR" to a directory containing one of the above files.  If "Thrift"
  provides a separate development package or SDK, be sure it has been
  installed.
Call Stack (most recent call first):
  /opt/homebrew/Cellar/cmake/3.27.2/share/cmake/Modules/CMakeFindDependencyMacro.cmake:76 (find_package)
  /Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/arrow/cpp-build/cpp-install/lib/cmake/Arrow/ArrowConfig.cmake:105 (find_dependency)
  adapter/orc/CMakeLists.txt:18 (find_package)

CMake Warning at /Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/arrow/cpp-build/cpp-install/lib/cmake/Arrow/Findlz4Alt.cmake:29 (find_package):
  By not providing "Findlz4.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "lz4", but
  CMake did not find one.

  Could not find a package configuration file provided by "lz4" with any of
  the following names:

    lz4Config.cmake
    lz4-config.cmake

  Add the installation prefix of "lz4" to CMAKE_PREFIX_PATH or set "lz4_DIR"
  to a directory containing one of the above files.  If "lz4" provides a
  separate development package or SDK, be sure it has been installed.
Call Stack (most recent call first):
  /opt/homebrew/Cellar/cmake/3.27.2/share/cmake/Modules/CMakeFindDependencyMacro.cmake:76 (find_package)
  /Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/arrow/cpp-build/cpp-install/lib/cmake/Arrow/ArrowConfig.cmake:105 (find_dependency)
  adapter/orc/CMakeLists.txt:18 (find_package)

-- Arrow version: 13.0.0
-- Found the Arrow shared library:
-- Found the Arrow import library:
-- Found the Arrow static library: /Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/arrow/cpp-build/cpp-install/lib/libarrow.a
-- Configuring incomplete, errors occurred!

Component(s)
Continuous Integration, Java, Packaging

It seems the error is here:
 xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance
CMake Error at /opt/homebrew/Cellar/cmake/3.27.2/share/cmake/Modules/FindJNI.cmake:394 (string):
  string sub-command REGEX, mode REPLACE needs at least 6 arguments total to
  command.

I am investigating with @amaldonadomat it might be related to an update on the M1 OS

It does seem to be related to the last two commits on FindJNI.cmake:
https://github.com/Kitware/CMake/commit/efa0e2ddafe48ef0921b31aef37c3187a7bb6b97
https://github.com/Kitware/CMake/commit/597139b853f2f14c71047e41a3244a397c6ee728

it does seem the fix is not included on a new CMake release

There doesn't seem to be any alias for prior CMake versions on Homebrew that we could reuse.

I am asking if they have a timeline for 3.27.3 on the fix: https://gitlab.kitware.com/cmake/cmake/-/issues/25181

This is on our self-hosted runner right? I think the easiest fix would be to manually install an older cmake version without the bug and remove the brew cmake after the bundle installation: https://github.com/ursacomputing/crossbow/actions/runs/5877563237/workflow#L197

Duplicated of #37159.

How about adding -DXCODE_VERSION= CMake option as a workaround?
diff --git a/ci/scripts/java_jni_macos_build.sh b/ci/scripts/java_jni_macos_build.sh
index d66c39a37..647a7dad8 100755
--- a/ci/scripts/java_jni_macos_build.sh
+++ b/ci/scripts/java_jni_macos_build.sh
@@ -90,6 +90,7 @@ cmake \
   -DPARQUET_BUILD_EXECUTABLES=OFF \
   -DPARQUET_REQUIRE_ENCRYPTION=OFF \
   -Dre2_SOURCE=BUNDLED \
+  -DXCODE_VERSION= \
   -GNinja \
   ${arrow_dir}/cpp
 cmake --build . --target install

https://gitlab.kitware.com/cmake/cmake/-/issues/25181#note_1401407

I managed to wrap up that work quickly. I've released 3.27.3. It should be announced later today.

https://github.com/Homebrew/homebrew-core/pull/139719
We may not need a workaround.


Use version 2.0.0 of the pg-pglogical gem

This allows us to work with version 2.0.1 of the pglogical package
Should be merged with https://github.com/ManageIQ/manageiq-appliance-build/pull/230

ping @Fryguy this is needed for things to work with https://github.com/ManageIQ/manageiq-appliance-build/pull/230


List serialization issue

Hello.
I started using LoganSquare with Retrofit not long ago and bumped into a List serialization issue.
Here's now i create an instance of API:
new Retrofit.Builder()
				.baseUrl(BuildConfig.baseUrl)
				.addConverterFactory(LoganSquareConverterFactory.create())
				.client(client)
				.build()
				.create(API.class)

here's the api:
	@FormUrlEncoded
	@POST("v1/conversation/{conversationType}/init")
	Call<ConversationResult> initConversation(@Path("conversationType") String conversationType,
	                                          @Field("contacts") List<String> contactIds,
	                                          @Field("account") String accountId);

here's my api call:
api.initConversation("internal", Arrays.asList(contactId), accountId);

but in requestBody instead of an array ["id1", "id2", ...] i see id1, id2, ... separated with a coma
I tried using LoganSquare.serialize(Arrays.asList(id1, id2, ...)) and the result was correct.
Please help me fix this issue. Thank you

This looks like the expected behaviour given Retrofit's specifications. When you use @Field("key") List<String> params, it will append a key-value pair for each item in params and re-use "key" as the key. What would you like the correct output to be?
Arrays.asList("id1") --> "contacts=id1"
Arrays.asList("id1", "id2") --> "contacts=id1&contacts=id2"

If you actually only want to have one single contacts field in the body, your approach to serialize the array yourself and add it to the method is correct. LoganSquare.serialize() will work in this case - alternatively, you could just call toString() on your List: Arrays.asList(id1, id2, ...).toString().
Please also refer to the documentation for Retrofit's @Field annotation.

I want to have
contacts=[ "id1", "id2" ] is that possible? Logansquare returns exactly what I want when serializing List. Is it possible without converting data before call?

@aurae also I have one question on this call:

The LoganSquare converter doesn't take part in converting a List<String> for a form-encoded Field. Retrofit invokes the converter for each String inside the List, not the list itself. Therefore, you have to convert the data yourself before making the call.


Quote exe arguments that also contain '(' and ')'

gdb does not like '(' and ')' without the argument being quoted. Added
check to ensure that if the argument is already quoted we don't quote it
again.

Any reason why we have this and Terminal.Quote?


Disabling auto-pack when building image

Tar-fs packs files in current directory by default if nothing is specified as first argument. Thus, when initializing pack at the start of the buildImage method, it started packing the entire current directory.
In my case, I package my app with Nexe and it tried to pack the entire virtual directory where my code was stored to be ran by Node and crashed because it couldn't find real files in it.
In other cases, this is just an unneeded waste of time whether the context is specified or not.

Interesting, amazing no one caught this one before :)

Did a small tweak.
We don't need the variable "tar" defined so soon.
Will ping when merged.


create_resource fails to deserialize response

Version
fastly-api = "4.5.0"
What happened
fastly_api::apis::resource_api::create_resource seems to fail to deserialize the response. The following example successfully links the resource on fastly's end, but returns a serde error instead of a response.
Example
use fastly_api::apis::{
    configuration::{ApiKey, Configuration},
    resource_api::{create_resource, CreateResourceParams},
};

#[tokio::main]
async fn main() {
    let mut config = Configuration {
        api_key: Some(ApiKey {
            prefix: None,
            key: "MY_API_KEY".into(), // placeholder
        }),
        ..Default::default()
    };
    create_resource(
        &mut config,
        CreateResourceParams {
            service_id: "MY_SERVICE".into(), // placeholder
            version_id: 1,
            resource_id: Some("MY_RESOURCE"into()), // placeholder
            name: Some("my_config".into()),
        },
    )
    .await
    .unwrap();
}

Error
thread 'main' panicked at src/main.rs:25:6:
called `Result::unwrap()` on an `Err` value: Serde(Error("unknown variant `config`, expected one of `object-store`, `secret-store`, `config-store`", line: 1, column: 262))
stack backtrace:
   0: rust_begin_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:645:5
   1: core::panicking::panic_fmt
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/panicking.rs:72:14
   2: core::result::unwrap_failed
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/result.rs:1654:5
   3: core::result::Result<T,E>::unwrap
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/result.rs:1077:23
   4: playground::main::{{closure}}
             at ./src/main.rs:15:5
   5: tokio::runtime::park::CachedParkThread::block_on::{{closure}}
             at /home/orphon/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.37.0/src/runtime/park.rs:281:63
   6: tokio::runtime::coop::with_budget
             at /home/orphon/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.37.0/src/runtime/coop.rs:107:5
   7: tokio::runtime::coop::budget
             at /home/orphon/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.37.0/src/runtime/coop.rs:73:5
   8: tokio::runtime::park::CachedParkThread::block_on
             at /home/orphon/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.37.0/src/runtime/park.rs:281:31
   9: tokio::runtime::context::blocking::BlockingRegionGuard::block_on
             at /home/orphon/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.37.0/src/runtime/context/blocking.rs:66:9
  10: tokio::runtime::scheduler::multi_thread::MultiThread::block_on::{{closure}}
             at /home/orphon/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.37.0/src/runtime/scheduler/multi_thread/mod.rs:87:13
  11: tokio::runtime::context::runtime::enter_runtime
             at /home/orphon/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.37.0/src/runtime/context/runtime.rs:65:16
  12: tokio::runtime::scheduler::multi_thread::MultiThread::block_on
             at /home/orphon/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.37.0/src/runtime/scheduler/multi_thread/mod.rs:86:9
  13: tokio::runtime::runtime::Runtime::block_on
             at /home/orphon/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.37.0/src/runtime/runtime.rs:351:45
  14: playground::main
             at ./src/main.rs:15:5
  15: core::ops::function::FnOnce::call_once
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/ops/function.rs:250:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

the same is true for fastly_api::apis::resource_api::list_resources, and probably every other API call that returns a fastly_api::models::resource_response::ResourceResponse

👋🏻 Thanks @0rphon for raising this issue.
@kpfleming I think there is a discrepancy between this API client code and the source OpenAPI schema.
If we look at the API docs (built from our OpenAPI specs) we see...

resource_type: One of: kv-store, secret-store, config

Which aligns with the actual API response. See also the reported error message: unknown variant 'config', which aligns with our OpenAPI schema...
type_resource:
  type: string
  description: Resource type
  enum:
    - kv-store
    - secret-store
    - config

But the fastly-api crate (this repo, also built from our OpenAPI specs) doesn't contain that. Instead, it has...
https://github.com/fastly/fastly-rust/blob/66e1eda7791c78f6e047266ac58deb2291061950/src/models/type_resource.rs#L17
UPDATE: OK, looks like @harmony7 updated the OpenAPI schema last week and changed it from config-store to config so I think we're just waiting for a new API client release to be published.

Released v4.6.0 crate, which corrects this:
https://github.com/fastly/fastly-rust/blob/cfa52f80058154f8a678a73409d4356b52a84e9b/src/models/type_resource.rs#L10-L20
This should fix the issue, but please feel free to reopen if you still have issues.


Divide by 0 in VAB; possible incorrect calculation of vesselSafetyRating?

Saw a divide by 0 error pop up on DasValdez' stream and went to poke at the code.  Noticed this line that looked fishy.  Shouldn't this be outside of the parts loop?  That's how the similar code in Update() works.
https://github.com/severedsolo/OhScrap/blob/bb5cd379b40853a62441b9a5967c94bdcf415a44/OhScrap/UPFMUtils.cs#L282

And fixed


Insufficient scope error even when addScope used

I am using the PHP client library v2.2.1 (added vendor folder from v2.2.0).
In the Google Developer Console, I have enabled the YouTube Data API V3 and under credentials I setup a SERVICE ACCOUNT KEY and downloaded the .json key file and have it stored in non-publicly accessible location on my server.
The error I receive is insufficient scope error, however in my code below you will see that I have added the scopes required:
[0] => Bearer realm="https://accounts.google.com/", error=insufficient_scope, scope="https://www.googleapis.com/auth/youtube.readonly"
Here is my code:
//Require Google API PHP Client library
require_once __DIR__.'/google-api-php-client/vendor/autoload.php';

//Setup new Google_Client
$gooClient = new Google_Client();

//Set location of json Service Account KEY file
$gooClient->setAuthConfig('/home/myserver/google-api-php-client/myserviceaccountkeyfile.json');

//Add scopes
$gooClient->addScope(Google_Service_YouTube::YOUTUBE_FORCE_SSL);
$gooClient->addScope(Google_Service_YouTube::YOUTUBE_READONLY);
$gooClient->addScope(Google_Service_YouTube::YOUTUBE);

//Authorize and send
$httpGooClient = $gooClient->authorize();
$responseGooClient = $httpGooClient->get('https://www.googleapis.com/youtube/v3/liveBroadcasts?part=snippet&broadcastStatus=active');

//View response
echo "<pre>";
print_r($responseClientBroadcast);
echo "</pre>";

bro its just that poople (google) sucks...im stuch with same and its been two months still this issue is not fixed...no one even helped me here

@immyemperor good point what issue did you want me to look at it. @jshrek I tried reproducing your problem and got a similar error response (Login Required).
I suspect you would have more luck with one of the Service classes:
$youtube = new Google_Service_YouTube(getClient());
try {
  $broadcastsResponse = $youtube->liveBroadcasts->listLiveBroadcasts(...);
  foreach ($broadcastsResponse['items'] as $broadcastItem) {
    echo $broadcastItem . "\n";
  }
} catch(Google_Service_Exception $e) {
	echo $e->getMessage() . "\n";
}

Note that the Youtube Data API does not accept service account credentials (see here). I'm not sure if the liveBroadcasts endpoint falls in this category but you could try using Client Credentials instead.


Build on Raspberry Pi (raspian stretch) fails (Could NOT find Threads (missing: Threads_FOUND))

I want to compile FreeRDP on my machine to be able to redirect usb devices to Windows 7 x64 remote host..
Therefore I pulled the repo via
git clone https://github.com/FreeRDP/FreeRDP.git

In the repo i then run
cmake -DCMAKE_BUILD_TYPE=Debug -DWITH_SSE2=ON -DBUILTIN_CHANNELS=OFF -DTARGET_ARCH=ARM -DCHANNEL_URB_CLIENT=ON

But I get the following error:
pi@APC165:~/Projects/FreeRDP $ cmake -DCMAKE_BUILD_TYPE=Debug -DWITH_SSE2=ON -DBUILTIN_CHANNELS=OFF -DTARGET_ARCH=ARM -DCHANNEL_URB_CLIENT=ON -DCHANNEL_URBDRC=ON .
-- The C compiler identification is GNU 6.3.0
-- The CXX compiler identification is GNU 6.3.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.29")
-- Git Revision 50d324655
-- Performing Test Wno-unused-result
-- Performing Test Wno-unused-result - Success
-- Performing Test Wno-unused-but-set-variable
-- Performing Test Wno-unused-but-set-variable - Success
-- Performing Test Wno-deprecated-declarations
-- Performing Test Wno-deprecated-declarations - Success
-- Performing Test Wno-deprecated-declarationsCXX
-- Performing Test Wno-deprecated-declarationsCXX - Success
-- GCC default symbol visibility: hidden
-- Performing Test Wimplicit-function-declaration
-- Performing Test Wimplicit-function-declaration - Success
-- Performing Test Wredundant-decls
-- Performing Test Wredundant-decls - Success
-- Looking for include file fcntl.h
-- Looking for include file fcntl.h - not found
-- Looking for include file unistd.h
-- Looking for include file unistd.h - not found
-- Looking for include file execinfo.h
-- Looking for include file execinfo.h - not found
-- Looking for include file inttypes.h
-- Looking for include file inttypes.h - not found
-- Looking for include file sys/modem.h
-- Looking for include file sys/modem.h - not found
-- Looking for include file sys/filio.h
-- Looking for include file sys/filio.h - not found
-- Looking for include file sys/sockio.h
-- Looking for include file sys/sockio.h - not found
-- Looking for include file sys/strtio.h
-- Looking for include file sys/strtio.h - not found
-- Looking for include file sys/select.h
-- Looking for include file sys/select.h - not found
-- Looking for include file syslog.h
-- Looking for include file syslog.h - not found
-- Performing Test HAVE_TM_GMTOFF
-- Performing Test HAVE_TM_GMTOFF - Failed
-- Looking for pthread.h
-- Looking for pthread.h - not found
CMake Error at /usr/share/cmake-3.7/Modules/FindPackageHandleStandardArgs.cmake:138 (message):
  Could NOT find Threads (missing: Threads_FOUND)
Call Stack (most recent call first):
  /usr/share/cmake-3.7/Modules/FindPackageHandleStandardArgs.cmake:378 (_FPHSA_FAILURE_MESSAGE)
  /usr/share/cmake-3.7/Modules/FindThreads.cmake:212 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  CMakeLists.txt:558 (find_package)

-- Configuring incomplete, errors occurred!
See also "/home/pi/Projects/FreeRDP/CMakeFiles/CMakeOutput.log".
See also "/home/pi/Projects/FreeRDP/CMakeFiles/CMakeError.log".

I found that it seems to be a similar issue to this: https://stackoverflow.com/questions/24813827/cmake-failing-to-detect-pthreads-due-to-warnings/25130590
When i disbale the argument check in /usr/share/cmake-3.7/Modules/FindThreads.cmake:212 by simple uncommenting the line, I get cmake to complete (allthough there is something mentioned at the top about pthreads):
pi@APC165:~/Projects/FreeRDP $ cmake -DCMAKE_BUILD_TYPE=Debug -DWITH_SSE2=ON -DBUILTIN_CHANNELS=OFF -DTARGET_ARCH=ARM -DCHANNEL_URB_CLIENT=ON -DCHANNEL_URBDRC=ON .
-- Git Revision 50d324655
-- GCC default symbol visibility: hidden
-- Looking for pthread_mutex_timedlock
-- Looking for pthread_mutex_timedlock - not found
-- Looking for pthread_mutex_timedlock in pthread
-- Looking for pthread_mutex_timedlock in pthread - not found
-- Looking for pthread_mutex_timedlock in pthreads
-- Looking for pthread_mutex_timedlock in pthreads - not found
-- Looking for include file sys/eventfd.h
-- Looking for include file sys/eventfd.h - not found
-- Looking for include file sys/eventfd.h
-- Looking for include file sys/eventfd.h - not found
-- Looking for include file sys/timerfd.h
-- Looking for include file sys/timerfd.h - not found
-- Looking for include file poll.h
-- Looking for include file poll.h - not found
-- Looking for ceill
-- Looking for ceill - not found
-- Finding recommended feature libsystemd for systemd journal appender (allows to export wLog to systemd journal)
--     Disable feature libsystemd using "-DWITH_LIBSYSTEMD=OFF"
-- Could NOT find libsystemd (missing:  LIBSYSTEMD_LIBRARY LIBSYSTEMD_INCLUDE_DIR)
CMake Warning at cmake/FindFeature.cmake:46 (message):
      feature libsystemd was requested but could not be found! ON / FALSE
Call Stack (most recent call first):
  CMakeLists.txt:726 (find_feature)

-- Finding recommended feature X11 for X11 (X11 client and server)
--     Disable feature X11 using "-DWITH_X11=OFF"
-- Found X11: /usr/lib/arm-linux-gnueabihf/libX11.so
-- Finding recommended feature Wayland for Wayland (Wayland client)
--     Disable feature Wayland using "-DWITH_WAYLAND=OFF"
-- Checking for module 'wayland-scanner'
--   No package 'wayland-scanner' found
-- Checking for module 'wayland-client'
--   No package 'wayland-client' found
-- Checking for module 'xkbcommon'
--   No package 'xkbcommon' found
-- Could NOT find WAYLAND (missing:  WAYLAND_SCANNER WAYLAND_INCLUDE_DIR WAYLAND_LIBS XKBCOMMON_INCLUDE_DIR XKBCOMMON_LIBS)
CMake Warning at cmake/FindFeature.cmake:46 (message):
      feature Wayland was requested but could not be found! ON / FALSE
Call Stack (most recent call first):
  CMakeLists.txt:751 (find_feature)

-- Skipping optional feature DirectFB for DirectFB (DirectFB client)
--     Enable feature DirectFB using "-DWITH_DIRECTFB=ON"
-- Finding required feature ZLIB for compression (data compression)
-- Found ZLIB: /usr/lib/arm-linux-gnueabihf/libz.so (found version "1.2.8")
-- Finding required feature OpenSSL for cryptography (encryption, certificate validation, hashing functions)
-- Found OpenSSL: /usr/lib/arm-linux-gnueabihf/libssl.so;/usr/lib/arm-linux-gnueabihf/libcrypto.so (found version "1.1.0f")
-- Skipping optional feature MbedTLS for cryptography (encryption, certificate validation, hashing functions)
--     Enable feature MbedTLS using "-DWITH_MBEDTLS=ON"
-- Skipping optional feature OpenSLES for multimedia (OpenSLES audio / video)
--     Enable feature OpenSLES using "-DWITH_OPENSLES=ON"
-- Finding recommended feature OSS for sound (audio input, audio output and multimedia redirection)
--     Disable feature OSS using "-DWITH_OSS=OFF"
-- Found OSS Audio
-- Finding recommended feature ALSA for sound (audio input, audio output and multimedia redirection)
--     Disable feature ALSA using "-DWITH_ALSA=OFF"
-- Found ALSA: /usr/lib/arm-linux-gnueabihf/libasound.so (found version "1.1.3")
-- Skipping optional feature Pulse for sound (audio input, audio output and multimedia redirection)
--     Enable feature Pulse using "-DWITH_PULSE=ON"
-- Skipping optional feature Cups for printing (printer device redirection)
--     Enable feature Cups using "-DWITH_CUPS=ON"
-- Skipping optional feature PCSC for smart card (smart card device redirection)
--     Enable feature PCSC using "-DWITH_PCSC=ON"
-- Finding recommended feature FFmpeg for multimedia (multimedia redirection, audio and video playback)
--     Disable feature FFmpeg using "-DWITH_FFMPEG=OFF"
-- Checking for module 'libavcodec'
--   Found libavcodec, version 57.64.101
-- Checking for module 'libavutil'
--   Found libavutil, version 55.34.101
-- Found FFmpeg: TRUE
-- Skipping optional feature GStreamer_0_10 for multimedia (multimedia redirection, audio and video playback, gstreamer 0.10 version)
--     Enable feature GStreamer_0_10 using "-DWITH_GSTREAMER_0_10=ON"
-- Finding recommended feature GStreamer_1_0 for multimedia (multimedia redirection, audio and video playback)
--     Disable feature GStreamer_1_0 using "-DWITH_GSTREAMER_1_0=OFF"
-- Checking for module 'glib-2.0'
--   Found glib-2.0, version 2.50.3
-- Found Glib
-- Checking for module 'gstreamer-1.0 >= 1.0.5'
--   Found gstreamer-1.0 , version 1.10.4
-- Checking for module 'gstreamer-base-1.0 >= 1.0.5'
--   Found gstreamer-base-1.0 , version 1.10.4
-- Checking for module 'gstreamer-app-1.0 >= 1.0.5'
--   Found gstreamer-app-1.0 , version 1.10.4
-- Checking for module 'gstreamer-audio-1.0 >= 1.0.5'
--   Found gstreamer-audio-1.0 , version 1.10.4
-- Checking for module 'gstreamer-fft-1.0 >= 1.0.5'
--   Found gstreamer-fft-1.0 , version 1.10.4
-- Checking for module 'gstreamer-pbutils-1.0 >= 1.0.5'
--   Found gstreamer-pbutils-1.0 , version 1.10.4
-- Checking for module 'gstreamer-video-1.0 >= 1.0.5'
--   Found gstreamer-video-1.0 , version 1.10.4
-- Found GSTREAMER_1_0: /usr/lib/arm-linux-gnueabihf/libgstreamer-1.0.so
-- Skipping optional feature JPEG for codec (use JPEG library)
--     Enable feature JPEG using "-DWITH_JPEG=ON"
-- Skipping optional feature x264 for codec (use x264 library)
--     Enable feature x264 using "-DWITH_X264=ON"
-- Skipping optional feature OpenH264 for codec (use OpenH264 library)
--     Enable feature OpenH264 using "-DWITH_OPENH264=ON"
-- Skipping optional feature GSM for codec (GSM audio codec library)
--     Enable feature GSM using "-DWITH_GSM=ON"
-- Skipping optional feature KRB5 for auth (add kerberos support)
--     Enable feature KRB5 using "-DWITH_KRB5=ON"
-- Using OpenSSL Version: 1.1.0f
-- Looking for include file stdbool.h
-- Looking for include file stdbool.h - not found
-- Looking for include file stdint.h
-- Looking for include file stdint.h - not found
-- Looking for include file inttypes.h
-- Looking for include file inttypes.h - not found
-- Finding recommended feature XKBFile for X11 keyboard (X11 keyboard file extension)
--     Disable feature XKBFile using "-DWITH_XKBFILE=OFF"
-- Found XKBFile: /usr/lib/arm-linux-gnueabihf/libxkbfile.so
-- Adding dynamic channel client server "audin": Audio Input Redirection Virtual Channel Extension
-- Adding static channel client server "cliprdr": Clipboard Virtual Channel Extension
-- Adding dynamic channel client "disp": Display Update Virtual Channel Extension
-- Adding static channel client server "drdynvc": Dynamic Virtual Channel Extension
-- Adding device channel client "drive": Drive Redirection Virtual Channel Extension
-- Adding dynamic channel client server "echo": Echo Virtual Channel Extension
-- Adding static channel client server "encomsp": Multiparty Virtual Channel Extension
-- Adding device channel client "parallel": Parallel Port Virtual Channel Extension
-- Adding static channel client "rail": Remote Programs Virtual Channel Extension
-- Adding static channel client server "rdpdr": Device Redirection Virtual Channel Extension
-- Adding dynamic channel client "rdpei": Input Virtual Channel Extension
-- Adding dynamic channel client "rdpgfx": Graphics Pipeline Extension
-- Adding static channel client server "rdpsnd": Audio Output Virtual Channel Extension
-- Adding static channel client server "remdesk": Remote Assistance Virtual Channel Extension
-- Adding device channel client "serial": Serial Port Virtual Channel Extension
-- Adding device channel client "smartcard": Smart Card Virtual Channel Extension
-- Adding dynamic channel client "tsmf": Video Redirection Virtual Channel Extension
-- Finding required feature XRandR for X11 randr (X11 randr extension)
-- Found XRANDR: /usr/lib/arm-linux-gnueabihf/libXrandr.so
-- Finding recommended feature Xext for X11 extension (X11 core extensions)
--     Disable feature Xext using "-DWITH_XEXT=OFF"
-- Found Xext: /usr/lib/arm-linux-gnueabihf/libXext.so
-- Adding dynamic channel "urbdrc": USB Devices Virtual Channel Extension
-- libudev stable: 1
-- Found UDev: /lib/arm-linux-gnueabihf/libudev.so
--  include: /usr/include
-- Found UUID: /usr/lib/arm-linux-gnueabihf/libuuid.so
-- Found dbus-glib: /usr/lib/arm-linux-gnueabihf/libdbus-glib-1.so
-- Found libusb-1.0:
--  - Includes: /usr/include/libusb-1.0
--  - Libraries: /usr/lib/arm-linux-gnueabihf/libusb-1.0.so
-- Found all URBDRC dependencies
-- Could NOT find DocBook XSL stylesheets (missing:  DOCBOOKXSL_DIR)
CMake Warning at client/X11/CMakeLists.txt:116 (message):
  WITH_MANPAGES was set, but xsltproc was not found.  man-pages will not be
  installed

-- Finding required feature XShm for X11 shared memory (X11 shared memory extension)
-- Found XShm: /usr/lib/arm-linux-gnueabihf/libXext.so
-- Finding recommended feature Xinerama for multi-monitor (X11 multi-monitor extension)
--     Disable feature Xinerama using "-DWITH_XINERAMA=OFF"
-- Found Xinerama: /usr/lib/arm-linux-gnueabihf/libXinerama.so
-- Finding recommended feature Xext for X11 extension (X11 core extensions)
--     Disable feature Xext using "-DWITH_XEXT=OFF"
-- Finding recommended feature Xcursor for cursor (X11 cursor extension)
--     Disable feature Xcursor using "-DWITH_XCURSOR=OFF"
-- Found Xcursor: /usr/lib/arm-linux-gnueabihf/libXcursor.so
-- Finding recommended feature Xv for video (X11 video extension)
--     Disable feature Xv using "-DWITH_XV=OFF"
-- Found Xv: /usr/lib/arm-linux-gnueabihf/libXv.so
-- Finding recommended feature Xi for input (X11 input extension)
--     Disable feature Xi using "-DWITH_XI=OFF"
-- Found Xi: /usr/lib/arm-linux-gnueabihf/libXi.so
-- Looking for XITouchClass
-- Looking for XITouchClass - not found
CMake Warning at cmake/FindFeature.cmake:46 (message):
      feature Xi was requested but could not be found!
-- Git Revision 50d324655
-- GCC default symbol visibility: hidden
-- Skipping recommended feature libsystemd for systemd journal appender (allows to export wLog to systemd journal)
-- Finding recommended feature X11 for X11 (X11 client and server)
--     Disable feature X11 using "-DWITH_X11=OFF"
-- Skipping recommended feature Wayland for Wayland (Wayland client)
-- Skipping optional feature DirectFB for DirectFB (DirectFB client)
--     Enable feature DirectFB using "-DWITH_DIRECTFB=ON"
-- Finding required feature ZLIB for compression (data compression)
-- Finding required feature OpenSSL for cryptography (encryption, certificate validation, hashing functions)
-- Skipping optional feature MbedTLS for cryptography (encryption, certificate validation, hashing functions)
--     Enable feature MbedTLS using "-DWITH_MBEDTLS=ON"
-- Skipping optional feature OpenSLES for multimedia (OpenSLES audio / video)
--     Enable feature OpenSLES using "-DWITH_OPENSLES=ON"
-- Finding recommended feature OSS for sound (audio input, audio output and multimedia redirection)
--     Disable feature OSS using "-DWITH_OSS=OFF"
-- Found OSS Audio
-- Finding recommended feature ALSA for sound (audio input, audio output and multimedia redirection)
--     Disable feature ALSA using "-DWITH_ALSA=OFF"
-- Skipping optional feature Pulse for sound (audio input, audio output and multimedia redirection)
--     Enable feature Pulse using "-DWITH_PULSE=ON"
-- Skipping optional feature Cups for printing (printer device redirection)
--     Enable feature Cups using "-DWITH_CUPS=ON"
-- Skipping optional feature PCSC for smart card (smart card device redirection)
--     Enable feature PCSC using "-DWITH_PCSC=ON"
-- Finding recommended feature FFmpeg for multimedia (multimedia redirection, audio and video playback)
--     Disable feature FFmpeg using "-DWITH_FFMPEG=OFF"
-- Skipping optional feature GStreamer_0_10 for multimedia (multimedia redirection, audio and video playback, gstreamer 0.10 version)
--     Enable feature GStreamer_0_10 using "-DWITH_GSTREAMER_0_10=ON"
-- Finding recommended feature GStreamer_1_0 for multimedia (multimedia redirection, audio and video playback)
--     Disable feature GStreamer_1_0 using "-DWITH_GSTREAMER_1_0=OFF"
-- Found Glib
-- Skipping optional feature JPEG for codec (use JPEG library)
--     Enable feature JPEG using "-DWITH_JPEG=ON"
-- Skipping optional feature x264 for codec (use x264 library)
--     Enable feature x264 using "-DWITH_X264=ON"
-- Skipping optional feature OpenH264 for codec (use OpenH264 library)
--     Enable feature OpenH264 using "-DWITH_OPENH264=ON"
-- Skipping optional feature GSM for codec (GSM audio codec library)
--     Enable feature GSM using "-DWITH_GSM=ON"
-- Skipping optional feature KRB5 for auth (add kerberos support)
--     Enable feature KRB5 using "-DWITH_KRB5=ON"
-- Using OpenSSL Version: 1.1.0f
-- Finding recommended feature XKBFile for X11 keyboard (X11 keyboard file extension)
--     Disable feature XKBFile using "-DWITH_XKBFILE=OFF"
-- Adding dynamic channel client server "audin": Audio Input Redirection Virtual Channel Extension
-- Adding static channel client server "cliprdr": Clipboard Virtual Channel Extension
-- Adding dynamic channel client "disp": Display Update Virtual Channel Extension
-- Adding static channel client server "drdynvc": Dynamic Virtual Channel Extension
-- Adding device channel client "drive": Drive Redirection Virtual Channel Extension
-- Adding dynamic channel client server "echo": Echo Virtual Channel Extension
-- Adding static channel client server "encomsp": Multiparty Virtual Channel Extension
-- Adding device channel client "parallel": Parallel Port Virtual Channel Extension
-- Adding static channel client "rail": Remote Programs Virtual Channel Extension
-- Adding static channel client server "rdpdr": Device Redirection Virtual Channel Extension
-- Adding dynamic channel client "rdpei": Input Virtual Channel Extension
-- Adding dynamic channel client "rdpgfx": Graphics Pipeline Extension
-- Adding static channel client server "rdpsnd": Audio Output Virtual Channel Extension
-- Adding static channel client server "remdesk": Remote Assistance Virtual Channel Extension
-- Adding device channel client "serial": Serial Port Virtual Channel Extension
-- Adding device channel client "smartcard": Smart Card Virtual Channel Extension
-- Adding dynamic channel client "tsmf": Video Redirection Virtual Channel Extension
-- Finding required feature XRandR for X11 randr (X11 randr extension)
-- Finding recommended feature Xext for X11 extension (X11 core extensions)
--     Disable feature Xext using "-DWITH_XEXT=OFF"
-- Adding dynamic channel "urbdrc": USB Devices Virtual Channel Extension
-- libudev stable: 1
-- Found UDev: /lib/arm-linux-gnueabihf/libudev.so
--  include: /usr/include
-- Found UUID: /usr/lib/arm-linux-gnueabihf/libuuid.so
-- Found libusb-1.0:
--  - Includes: /usr/include/libusb-1.0
--  - Libraries: /usr/lib/arm-linux-gnueabihf/libusb-1.0.so
-- Found all URBDRC dependencies
-- Could NOT find DocBook XSL stylesheets (missing:  DOCBOOKXSL_DIR)
CMake Warning at client/X11/CMakeLists.txt:116 (message):
  WITH_MANPAGES was set, but xsltproc was not found.  man-pages will not be
  installed

-- Finding required feature XShm for X11 shared memory (X11 shared memory extension)
-- Finding recommended feature Xinerama for multi-monitor (X11 multi-monitor extension)
--     Disable feature Xinerama using "-DWITH_XINERAMA=OFF"
-- Finding recommended feature Xext for X11 extension (X11 core extensions)
--     Disable feature Xext using "-DWITH_XEXT=OFF"
-- Finding recommended feature Xcursor for cursor (X11 cursor extension)
--     Disable feature Xcursor using "-DWITH_XCURSOR=OFF"
-- Finding recommended feature Xv for video (X11 video extension)
--     Disable feature Xv using "-DWITH_XV=OFF"
-- Skipping recommended feature Xi for input (X11 input extension)
-- Finding recommended feature Xrender for rendering (X11 render extension)
--     Disable feature Xrender using "-DWITH_XRENDER=OFF"
-- Finding recommended feature Xfixes for X11 xfixes extension (Useful additions to the X11 core protocol)
--     Disable feature Xfixes using "-DWITH_XFIXES=OFF"
-- Configuring done
-- Generating done
-- Build files have been written to: /home/pi/Projects/FreeRDP

brings me a bit further but still I can not compile the master:
pi@APC165:~/Projects/FreeRDP $ make
Scanning dependencies of target winpr
[  0%] Building C object winpr/libwinpr/CMakeFiles/winpr.dir/synch/address.c.o
[  0%] Building C object winpr/libwinpr/CMakeFiles/winpr.dir/synch/barrier.c.o
[  1%] Building C object winpr/libwinpr/CMakeFiles/winpr.dir/synch/condition.c.o
[  1%] Building C object winpr/libwinpr/CMakeFiles/winpr.dir/synch/critical.c.o
[  1%] Building C object winpr/libwinpr/CMakeFiles/winpr.dir/synch/event.c.o
[  1%] Building C object winpr/libwinpr/CMakeFiles/winpr.dir/synch/init.c.o
[  2%] Building C object winpr/libwinpr/CMakeFiles/winpr.dir/synch/mutex.c.o
[  2%] Building C object winpr/libwinpr/CMakeFiles/winpr.dir/synch/semaphore.c.o
[  2%] Building C object winpr/libwinpr/CMakeFiles/winpr.dir/synch/sleep.c.o
/home/pi/Projects/FreeRDP/winpr/libwinpr/synch/sleep.c: In function ‘Sleep’:
/home/pi/Projects/FreeRDP/winpr/libwinpr/synch/sleep.c:41:2: warning: implicit declaration of function ‘usleep’ [-Wimplicit-function-declaration]
  usleep(dwMilliseconds * 1000);
  ^~~~~~
[  2%] Building C object winpr/libwinpr/CMakeFiles/winpr.dir/synch/srw.c.o
[  3%] Building C object winpr/libwinpr/CMakeFiles/winpr.dir/synch/timer.c.o
[  3%] Building C object winpr/libwinpr/CMakeFiles/winpr.dir/synch/wait.c.o
/home/pi/Projects/FreeRDP/winpr/libwinpr/synch/wait.c:137:12: error: static declaration of ‘pthread_mutex_timedlock’ follows non-static declaration
 static int pthread_mutex_timedlock(pthread_mutex_t *mutex, const struct timespec *timeout)
            ^~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/pi/Projects/FreeRDP/winpr/libwinpr/synch/synch.h:50:0,
                 from /home/pi/Projects/FreeRDP/winpr/libwinpr/synch/wait.c:44:
/usr/include/pthread.h:767:12: note: previous declaration of ‘pthread_mutex_timedlock’ was here
 extern int pthread_mutex_timedlock (pthread_mutex_t *__restrict __mutex,
            ^~~~~~~~~~~~~~~~~~~~~~~
winpr/libwinpr/CMakeFiles/winpr.dir/build.make:326: die Regel für Ziel „winpr/libwinpr/CMakeFiles/winpr.dir/synch/wait.c.o“ scheiterte
make[2]: *** [winpr/libwinpr/CMakeFiles/winpr.dir/synch/wait.c.o] Fehler 1
CMakeFiles/Makefile2:249: die Regel für Ziel „winpr/libwinpr/CMakeFiles/winpr.dir/all“ scheiterte
make[1]: *** [winpr/libwinpr/CMakeFiles/winpr.dir/all] Fehler 2
Makefile:149: die Regel für Ziel „all“ scheiterte
make: *** [all] Fehler 2

Sorry for the wall of text but I am not quite sure how I would resolve this.

As for the pthread error, please ensure the development packages are installed, looks like you're missing headers and therefore no compile is possible.
Please use IRC or mailing list for further assistance with compiling.

Thanks @akallabeth for helping out in IRC. Just for good measure here is what I needed to do to build on ARM (Raspberry Pi with Raspian stretch)

Setup build dependencies in /etc/apt/sources.lists

deb http://mirrordirector.raspbian.org/raspbian/ stretch main contrib non-free rpi          # copy this line and replace deb with deb-src
deb-src http://mirrordirector.raspbian.org/raspbian/ stretch main contrib non-free rpi

Install build dependencies for the freerdp-x11 package

sudo apt-get update
sudo apt-get build-dep freerdp-x11

Install the other dependencies (maybe), link

sudo apt-get install build-essential git-core cmake xsltproc libssl-dev libx11-dev libxext-dev libxinerama-dev \
  libxcursor-dev libxdamage-dev libxv-dev libxkbfile-dev libasound2-dev libcups2-dev libxml2 libxml2-dev \
  libxrandr-dev libgstreamer0.10-dev libgstreamer-plugins-base0.10-dev libxi-dev libgstreamer-plugins-base1.0-dev

Clone repo

git clone https://github.com/FreeRDP/FreeRDP.git

Generate make files without SSE2 and USB redirection options activated

cmake -DCMAKE_BUILD_TYPE=Release -DWITH_SSE2=OFF -DBUILTIN_CHANNELS=OFF -DCHANNEL_URBDRC_CLIENT=ON -DCHANNEL_URBDRC=ON .

Compile

make

Install

sudo make install

@vuchl I build the master but failed on my Raspberry Pi 3 with Raspian stretch
use /usb:auto
[ERROR] [com.freerdp.channels.urbdrc.client] - error processing arguments

@lxc2118 right now I have no work with FreeRDP anymore so I can not help you out. Maybe you should check out IRC at https://webchat.freenode.net/ and the channel #freerdp. @akallabeth and @hardening are the most of the time.


Pact Consumer tests are failing starting with node 18.10 and 19

Software versions

OS: MacOS Ventrua
Pact Node version:  Pact Foundation 10.3.1
Node Version: 18.10.x, 19.x

Issue Checklist
Please confirm the following:

[x] I have upgraded to the latest
[x] I have the read the FAQs in the Readme
[x] I have triple checked, that there are no unhandled promises in my code
[x] I have set my log level to debug and attached a log file showing the complete request/response cycle

Expected behaviour
All the tests to pass
Actual behaviour
The tests fail after upgrading from node 18.8.0 to 18.10.0 even on 19.x
Steps to reproduce
Update to node 18.10 or 19 and run the Consumer tests
Relevant log files
● Console

    console.error

      at Pact.Object.<anonymous>.Pact.verify (../node_modules/@pact-foundation/src/httpPact/index.ts:211:15)
      at Object.<anonymous> (../node_modules/jest-pact/dist/pactWith.js:12:45)

    console.error
      Pact verification failed!

      at Pact.Object.<anonymous>.Pact.verify (../node_modules/@pact-foundation/src/httpPact/index.ts:212:15)
      at Object.<anonymous> (../node_modules/jest-pact/dist/pactWith.js:12:45)

    console.error
      Test failed for the following reasons:

        Mock server failed with the following mismatches:

      	0) The following request was expected but not received:
      	    Method: POST
      	    Path: ...
      	    Headers:
      	      Accept: application/json
      	      Authorization: Bearer mock
      	      Content-Type: application/json
      	    Body: ...

      at Pact.Object.<anonymous>.Pact.verify (../node_modules/@pact-foundation/src/httpPact/index.ts:213:15)
      at Object.<anonymous> (../node_modules/jest-pact/dist/pactWith.js:12:45)

  ● Pact between .... returns the correct response

    socket hang up

      at Function.Object.<anonymous>.AxiosError.from (../node_modules/axios/lib/core/AxiosError.js:89:14)
      at RedirectableRequest.handleRequestError (../node_modules/axios/lib/adapters/http.js:533:25)
      at ClientRequest.eventHandlers.<computed> (../node_modules/follow-redirects/index.js:14:24)

  ● Pact between ... returns the correct response

    Pact verification failed - expected interactions did not match actual.

      at new VerificationError (../node_modules/@pact-foundation/pact/src/errors/verificationError.js:21:42)
      at Pact.Object.<anonymous>.Pact.verify (../node_modules/@pact-foundation/src/httpPact/index.ts:217:13)
      at Object.<anonymous> (../node_modules/jest-pact/dist/pactWith.js:12:45)

Failed to initialise global tracing subscriber - a global default trace dispatcher has already been set

Are you giving the mock server an IP address or just localhost? I know that node 18 uses ipv6 by default, which can cause some confusion around what “localhost” means when communicating externally

I get the base url like this:
instance.defaults.baseURL = provider.mockService.baseUrl;

@TimothyJones i tested and if i keep only 1 interaction per file it passes, from the debug logs it looks like pact is doing the cleanup too early

Can you please provide a reproducible example? We test the builds on node 18 so I don't think the node version is the problem (it might be, but seems unlikely). It smells of incorrectly handled promises, but hard to tell from that output.

@mefellows i created a repo with the issue: https://github.com/RaresAil/issue-env-pact

Your example works for me using node 18.10.0, but fails in the same way as your test with node 19.5.0.

@mefellows My guess is that the core isn't waiting for the server to start duing addInteraction. I'll leave this for someone more qualified to look into.

@RaresAil Did you get any further with this? I ran in to the same issue in an unrelated project that uses axios, but does not use Pact. I suspect axios might be at fault

@RaresAil Did you get any further with this? I ran in to the same issue in an unrelated project that uses axios, but does not use Pact. I suspect axios might be at fault

I tried and with node-fetch and same issue what i did now as a workaround is the delay of 1 second

I tried and with node-fetch and same issue

Aha. That points to the changing node version being the reason for the broken test. With this information, I was able to get to the bottom of it:
I checked the changelog - and one of the breaking changes in 19.x is that Keep-Alive is set to true on http connections. This is a problem on repeated tests, as at some point you will pick up a connection that is due to be closed soon. This also explains why your workaround of a one second pause works - as the default socket lifetime is 1 second.
You confirm this with httpAgent: new http.Agent({ keepAlive: false }), in your axios options (weirdly, if you're creating axios each time, then new httpAgent({keepAlive: true}) will also work, because the connection pool won't be reused).
I think the right fix is to retry on ECONNRESET.
@mefellows This is a thing that could be changed in the proxy to avoid it in the future. If you want to do this, you can just add a bit of middleware that has res.append('Connection', 'close');

Thank you, i will also change on my side from the delay of 1s to disable the keepAlive


Aider does not acknowledge file is present

Issue
(summary provided by aider)
I would summarize the issue like this:
There appears to be a bug in the AI assistant's file visibility system. Even when explicitly asked multiple times whether I can see a particular file, I keep analyzing the list of files I can see and responding that I cannot see it, rather than actually checking if the file was included in the "added files" message.
This suggests that either:

The logic for checking what files have been "added to the chat" may be overridden by some other logic that only looks at a cached list of files
There may be a disconnect between the part that processes the "I have added these files" message and the part that answers questions about file visibility

To reproduce:

Add files to chat with "I have added these files to the chat" message
Ask "can you see X file?"
Assistant keeps checking a seemingly cached list rather than checking what files were actually added

This leads to a poor user experience where the assistant repeatedly fails to acknowledge files that have been added and instead keeps listing the same subset of files it initially recognized.
Screenshots below

Version and model info
Aider version: 0.60.2.dev299+gd8e1e823
Python version: 3.11.5
Platform: macOS-10.16-x86_64-i386-64bit
Python implementation: CPython
Virtual environment: Yes
OS: Darwin 24.0.0 (64bit)
Git version: git version 2.47.0
Aider v0.60.2.dev299+gd8e1e823
Main model: claude-3-5-sonnet-20241022 with diff edit format, prompt cache, infinite output
Weak model: claude-3-5-sonnet-20240620
Git repo: .git with 89 files
Repo-map: using 1024 tokens, files refresh
Added automated_dev.py to the chat.
Added improvement_strategies/init.py to the chat.
Added improvement_strategies/base.py to the chat.
Added improvement_strategies/maintainability.py to the chat.
Added improvement_strategies/scalability.py to the chat.
Added improvement_strategies/test_coverage.py to the chat.
Added project_map.md to the chat.
Token count

$ 0.0053    1,779 system messages
$ 0.0028      928 chat history                              use /clear to clear
$ 0.0035    1,157 repository map                            use --map-tokens to resize
$ 0.0003       98 improvement_strategies/__init__.py        /drop to remove
$ 0.0136    4,522 improvement_strategies/test_coverage.py   /drop to remove
$ 0.0086    2,868 improvement_strategies/maintainability.py /drop to remove
$ 0.0184    6,131 automated_dev.py                          /drop to remove
$ 0.0017      573 improvement_strategies/base.py            /drop to remove
$ 0.0019      637 improvement_strategies/scalability.py     /drop to remove
$ 0.0029      971 project_map.md                            /drop to remove
==================
$ 0.0590   19,664 tokens total
          180,336 tokens remaining in context window
          200,000 tokens max context window size

Thanks for trying aider and filing this issue.
This is likely just the LLM being confused. You can run aider with --verbose and then you can see the full content of each message aider sends to the LLM. You can inspect them to confirm if the specific files are indeed being sent to the LLM.

I'm closing this issue because it has been stalled for 3 weeks with no activity. Feel free to add a comment here and we can re-open it. Or feel free to file a new issue at any time.Note: A bot script made these updates to the issue.


edge: re-enable RTX

all the stuff required for RTX should have been hooked up in Edge 15007
so its no longer necessary to delete this.

LGTM


Read epxensive properties (row count) on demand.

For now we have pref option "Show row count for tables".
It is disabled by default by performance reasons (it may overload server cpu by just clicking on different tables).
But sometimes you need these properties for a particular table.
We can add extra command "Read statistics" or "Read row count" in table editor toolbar. It will read expensive props for current editor only.

Verified


Can't initialize Tailwind or any .css with Vite starter

Steps

clone the Vite starter
npx create-remix@latest --template https://github.com/mcansh/remix-fastify/tree/main/examples/unstable-vite

initialize Tailwind following Remix documentation

Tailwind styles are not applied and the following error appears on console

Thanks!


Implement PoET Fork Resolution and Refactoring Goodness

This update implements fork resolution using the same method previously used by PoET, with a few additions:

If neither block is a PoET block, bail out.
Otherwise, if one block is a PoET block and the other isn't, then the PoET block is chosen.
Otherwise (both blocks are PoET blocks), if the blocks share the same immediate predecessor block, the one with the smaller wait duration is chosen.
Otherwise (they have different predecessor blocks), the one with the greater aggregated local mean is chosen.
Otherwise,  the one with the lexicographically greater block identifier (header signature) is chosen.

Criteria 1, 2, and 5 were added because prior to 0-8, non-PoET blocks were not a possibility.
In addition, the code has been refactored to better encapsulate the consensus state statistics and information used to make decision.
This PR updates:

adds a fixed duration block count property to the PoET configuration view.  This value indicates the number of blocks which will have their local mean computed by using a simple ratio of target to initial wait times.  These blocks are not considered when performing the zTest.
updates the PoET enclave factory to use the new PoET configuration view's fixed duration block count property.
refactors existing PoET policy tests (key block claim limit, block claim delay) to common utils
adds minimum win count and maximum win deviation properties to the PoET configuration view.  These values are used when performing the zTest.  The minimum win count is that minimum number of blocks, after the fixed duration block count has been surpassed, a validator has to win before zTest will apply to any further blocks.  The maximum win deviation is used to determine if a validator has violated the zTest policy by comparing this against the deviation from the expected number of blocks a validator should have won.
adds aggregate local mean to the consensus state, properly updates it when blocks are committed, and updates fork resolution based upon steps outlined previously
most of the code in the common utils has been refactored to live inside the consensus state class to better encapsulate it
as a side effect of the refactoring, all consensus state properties are now read-only as the refactoring allowed for updating of properties to always take place inside of consensus state object methods

To test locally:
cd /project/sawtooth-core/integration/sawtooth_integration/docker
In poet-smoke.yaml, after the line:
sawtooth.consensus.algorithm=poet \
Add:
sawtooth.poet.target_wait_time=5 \
sawtooth.poet.initial_wait_time=0 \
sawtooth.poet.key_block_claim_count=5 \
sawtooth.poet.fixed_duration_block_count=10 \

Execute:
run_docker_test poet-smoke.yaml
Go get your beverage of choice and cross your fingers that the test passes.
After the test has completed, you should be able to locate in the log, messages from poet_fork_resolver indicating why a particular fork was chosen.

Tested locally

Final rebase (or freebase) before merge.


Fix headers with same field name

When I try to send a request like this (as described in http://docs.guzzlephp.org/en/latest/request-options.html#headers)
$client->request('GET', '/get', [
    'headers' => [
        'User-Agent' => 'testing/1.0',
        'Accept'     => 'application/json',
        'X-Foo'      => ['Bar', 'Baz']
    ]
]);

Guzzle will send a request with following headers:
User-Agent: testing/1.0
Accept: application/json
X-FOO: BAR
X-FOO: Baz

When I try to read these headers (using, for example, getallheaders or print_r($_SERVER)), I got this:
...
"HTTP_USER_AGENT": "GuzzleHttp/6.2.1 curl/7.51.0 PHP/7.1.5",
"HTTP_X_FOO": "Bar",
...

https://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.2

Multiple message-header fields with the same field-name MAY be present in a message if and only if the entire field-value for that header field is defined as a comma-separated list [i.e., #(values)]. It MUST be possible to combine the multiple header fields into one "field-name: field-value" pair, without changing the semantics of the message, by appending each subsequent field-value to the first, each separated by a comma. The order in which header fields with the same field-name are received is therefore significant to the interpretation of the combined field value, and thus a proxy MUST NOT change the order of these field values when a message is forwarded.

This PR put everything in the same field name (if has more than one value for the same key) without changing field value order.
Guzzle will send: "X-Foo: Bar, Baz"

https://g.co/kgs/AioCp


Update enqueued state as current state after iteration completion in the periodic sync.

…the periodic sync.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #[issue number]
Description
Update enqueued state as current state after iteration completion in the periodic sync.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix)
Screenshots (if applicable)
Checklist

[x] I have read and acknowledged the Code of conduct.
[x] I have read the Contributing page.
[x] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
[x] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
[x] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
[x] I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

issue :
Uploading Screen Recording 2024-10-18 at 4.59.40 PM.mov…

https://github.com/user-attachments/assets/ed33ed0d-5f81-4b62-8d55-44eaf7797a65


Rich Text Link URL value as "url"

We noticed recently that some text when converting through markdownToBlocks gets a bad URL value, with blocks that looks like:
[
  {
    "object": "block",
    "type": "paragraph",
    "paragraph": {
      "rich_text": [
        {
          "type": "text",
          "annotations": {
            "bold": false,
            "strikethrough": false,
            "underline": false,
            "italic": false,
            "code": false,
            "color": "default"
          },
          "text": {
            "content": "https://60f06c1c5a1772003b824d76-gclpzqfgft.chromatic.com/?path=/story/poi-map--create-point-poi",
            "link": {
              "type": "url",
              "url": "url" // <- this fails Notion client
            }
          }
        }
      ]
    }
  },
  // ...<other blocks>
]

Where the source is simply the link text https://60f06c1c5a1772003b824d76-gclpzqfgft.chromatic.com/?path=/story/poi-map--create-point-poi
This would trigger an error when creating the blocks on Notion:
@notionhq/client warn: request fail {
  code: 'validation_error',
  message: 'Content creation Failed. Fix the following: \n' +
    'Invalid URL for link.\n' +
    'Invalid URL for link.\n' +
    'Invalid URL for link.'
}

At the moment, we employ a patch mutation script to address this as the following:
const seekFixFalseURLs = (blocks) => { // mutates blocks
  blocks.forEach((block) => {
    ((block[block.type] || {}).rich_text || []).forEach((rt) => {
      if ((rt[rt.type].link || {}).url === 'url') {
        rt[rt.type].link.url = rt[rt.type].content
      }
    })
  })
}

Anchor links (such as #top) also trigger a Notion error. Some additional URL validation should be done when parsing a link.

I had the same issue, so I created a pull request to fix it. I hope it can be merged.

@Vaayne This validation creates an issue with markdown that does not start with https://. For example: http:// ftp:// or just any relative path like /index.html.


Query: Negative Max Value Time

Thanos, Prometheus and Golang version used
Thanos version: 0.4.0
Golang version: 1.10.7
Prometheus version: 2.9.2
What happened
When using the Thanos querier, it shows a negative max time. The querier says: "-9223372036854775808 filtered out." It does this when there isn't any data in the store.
What you expected to happen
It should be said that there is no data or make this more clear.
How to reproduce it (as minimally and precisely as possible)
Connect to a store that has no data blocks.
Full logs to relevant components
Compactor Logs Show a Different maxTime

level=info ts=2019-05-28T15:05:46.83778373Z caller=retention.go:35 msg="deleting block" id=01DBZF9738FM6DP5SE5S8TM0SC maxTime="2019-05-28 14:00:00 +0000 UTC"

Querier - Interesting warning from the sidecar and Maxt is negative

level=warn ts=2019-05-28T14:11:36.645281771Z caller=proxy.go:349 err="failed to receive any data from Addr: <IP_ADDRESS>:10901 Labels: [{monitor anvil-dev-dev {} [] 0}] Mint:<PHONE_NUMBER>000 Maxt:<PHONE_NUMBER>854775807: context canceled" msg="returning partial response"
level=debug ts=2019-05-28T14:11:37.625009338Z caller=proxy.go:205 msg="store Addr: <IP_ADDRESS>:10901 Labels: [{monitor dev {} [] 0}] Mint:<PHONE_NUMBER>000 Maxt:<PHONE_NUMBER>854775807 queried;store Addr: <IP_ADDRESS>:10901 Labels: [] Mint:<PHONE_NUMBER>854775807 Maxt: -9223372036854775808 filtered out"

facing the same issue here, adding the flag negative value to the max time --max-time=-2w to storegateway showing invalid date in thanos query stores tab


Avoid possible race condition during package loading

This is a fix for what seems to be a possible race condition while loading packages.
We were seeing frequent Katas validation failures in the E2E build due to the assemblies from the Katas package not being available, even though the %package Microsoft.Quantum.Katas cell in the notebook had already completed successfully.
With this change, so far the Katas validation in the E2E build has passed 6/6 times, and considering we were seeing a failure rate that seemed to be nearly 50% recently, I think it's worth merging this fix to get further testing. I don't have high confidence that this actually fixes the issue, but it's a safe change and can't hurt anything.

Looks good to me. Have you been able to verify if there are there any performance implications to this solution?

Good question. The fact that the E2E builds are succeeding is an indication that it doesn't make things too much worse. (Previously when loading the Microsoft.Quantum.Standard.Visualization package synchronously on load, it caused kernel startup timeouts during Katas validation. So at least we're not hitting that problem.)
In principle this shouldn't affect performance much. In particular, this change doesn't serialize the dependency resolution or downloading portions of package loading, which are the potentially time-consuming parts. It only serializes the updates to the cached lists of packages and assemblies. That certainly takes some time, as these are long lists, but in practice I wouldn't think this will cause a noticeable difference (my rough guess would be sub-second impact to kernel startup time, and only in cases where a notebook/script/project is actually loading additional packages at startup, as in the case of the Katas notebooks).


Service ID type mistmatch

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
In the API and Client package Service ID field has a type int64
but in pkg/service/id.go it has a type uint32 (for example func GetID)
but then in pkg/loadbalancer/loadbalancer.go Serive ID has a type uitn16
How does issue look from the Client side:
Issue 1:
Trying to create new service with ID -11 (valid int64 regarding to API) via PutServiceID, all ok, PutServiceID returns true
Then trying to list services via GetServces and GetServices returns Service with ID<PHONE_NUMBER> (-2 casted to uint32)
Issue 2:
Creating a service with ID 100000 (lager than uint16). All ok, we see this ID in GerServicces output. Then trying to delete it via DeleteServiceID and got an error "Service Not Found".
For Service with ID from 1 to 65535 (uint16) all works ok.
So you have to fix Service ID types in API, service and loadbalancer packages to match each other
Cilium Version
1.13.2
Kernel Version
5.15.0-71-generic
Kubernetes Version
Cilium standalone L4 LB
Sysdump
No response
Relevant log output
No response
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Oops, that's confusing.
We might not be able to change the api types, but we should at least provide some meaningful comments and validation on the server side.


Investigate historical pricing, backfilling (dune)

is it needed or not?

Fantom prices in the subgraph are 0 prior to multichain incident as it uses axlUSDC and lzUSDC as pricing

could use it to price swaps, add, removes historically


Pull request not coming through

Hi, I just purchased Imgbot 7hrs ago and requested a new pull a couple times and nothing is coming through. Am I missing something? Please advise.

thats odd, never showed up in github. I did just receive an email let me know it finished...

Could be related to the issue that are happening now: https://www.githubstatus.com/


Fixed "Add Sprite..." label overlapping with zoom controls

Fixes a glitch mentioned in:
https://github.com/godotengine/godot/issues/20837#issuecomment-541347746

@groud Thanks for the review! I've just pushed the changes for the 2 things you mentioned.

LGTM. I am not sure the get_controls_container is very explicit but I can't find a better name for now. :)
Good job!

Thanks!


Constrain retryable exceptions

Not all exception types are safe or wise to retry. Instead, limit retries to
known connection-level events including timeouts and disconnects.

:star: ⚾

⭐ 🐑  Thanks for updating.


SRDF parser not tested.

There is not unittest for the SRDF parser. Maybe it could be added to unittest/urdf.cpp.

Split if you can, it will be easier to maintain. I prefer several unit test files than a big one.

The suggested file is merely loading a URDF, and is less than 10 lines of actual code. To test the SRDF, the easiest is to first load a URDF. So you will anyway copy the same 10 lines of code.

Yes, and we will add new parsing of infos, like end effectors, etc ... and then the test number will increase with time. So, to avoid future refactoring, I propose to directly add such a dedicated file.

As this is not mandatory, I remove the label.

Solved by #342.


Liquibase 4.0.0 Beta 1 does not include working directly as a resource root

Environment
Liquibase Version: Liquibase 4.0.0 beta1
Liquibase Integration & Version: Maven
Database Vendor & Version: N/A
Operating System Type & Version: N/A
Description
As reported in https://github.com/liquibase/liquibase/issues/1035#issuecomment-629976772

I couldn't use 4.0.0-beta1. I got error database/target/database/settings-sql/db-changelog.xml not found
As you can see we use xml from target. Do you change something with maven cycle?

In 3.x, we set up the maven integration to look in both the ${project.dir}/target directory as well as the current working directory.
With 4.0, we only include the target directory.
Steps To Reproduce

Create a maven configuration with a changeLogFile of database/target/database/settings-sql/db-changelog.xml
See that Liquibase 3.8.9 runs update correctly
See that Liquibase 4.0.0 update fails

┆Issue is synchronized with this Jira Bug by Unito
┆Fix Versions: Liquibase 4.0 beta 2

We changed maven to not include the current working directory, since including "database/target" in the changelog path stored in the databasechangelog table will make it more difficult to also run liquibase through other integrations such as spring or the cli.
The best practice is to have your changelog path be as "portible" as possible, so removing the current working directory helps force people to set up their configuration "right".
However, we also need to support existing configurations as well. Given how quickly someone found this change, it is likely other people will hit the same problem.
Perhaps it is best to default to still not including the working directory, but add a maven setting to add it?


Error starting Nanopreprocess - >logbasecalling

Fairly new to this. I'm running a virtual machine Ubuntu on my windows laptop.
The error I'm having is:
Error executing process > 'logBaseCalling'
Is it that the program can't run guppy?
How do I fix this?
I see this error when I run:
(base) aust@aust-VirtualBox:~/master_of_pores/NanoPreprocess$ nextflow run nanopreprocess.nf -with-docker
N E X T F L O W  ~  version 21.04.0
Launching nanopreprocess.nf [high_lovelace] - revision: 070dd5f042
╔╦╗┌─┐┌─┐┌┬┐┌─┐┬─┐  ┌─┐┌─┐  ╔═╗╔═╗╦═╗╔═╗╔═╗
║║║├─┤└─┐ │ ├┤ ├┬┘  │ │├┤   ╠═╝║ ║╠╦╝║╣ ╚═╗
╩ ╩┴ ┴└─┘ ┴ └─┘┴└─  └─┘└    ╩  ╚═╝╩╚═╚═╝╚═╝
====================================================
BIOCORE@CRG Preprocessing of Nanopore direct RNA - N F  ~  version 0.1
kit                       : SQK-RNA001
flowcell                  : FLO-MIN106
fast5                     : /home/aust/master_of_pores/NanoPreprocess/../data/multifast/*.fast5
reference                 : /home/aust/master_of_pores/NanoPreprocess/../anno/curlcake_constructs.fasta.gz
annotation                :
ref_type                  : transcriptome
seq_type                  : cDNA
output                    : /home/aust/master_of_pores/NanoPreprocess/multifast
qualityqc                 : 5
granularity               :
basecaller                : guppy
basecaller_opt            :
GPU                       : OFF
demultiplexing            :
demultiplexing_opt        : -m pAmps-final-actrun_newdata_nanopore_UResNet20v2_model.030.h5
demulti_fast5		      : OFF
filter                    :
filter_opt                :
mapper                    : graphmap2
mapper_opt                :
map_type                  : spliced
counter                   : YES
counter_opt               :
downsampling			  :
variant_caller            : NO
variant_opt               :
email                     :
executor >  local (3)
[e3/4f0be5] process > testInput (multifast5_1.fa... [100%] 1 of 1 ✔
[61/c1ba86] process > logBaseCalling                [  0%] 0 of 1
[80/572c95] process > baseCalling (guppy-multifa... [  0%] 0 of 1
[-        ] process > concatenateFastQFiles         -
[-        ] process > QC                            -
[-        ] process > fastQC                        -
[-        ] process > mapping                       -
[-        ] process > counting                      -
[-        ] process > joinCountQCs                  -
[-        ] process > alnQC                         -
[-        ] process > joinAlnQCs                    -
[-        ] process > alnQC2                        -
[-        ] process > multiQC                       -
Skipping the email
MultiFast5 files detected!
Error executing process > 'logBaseCalling'
Caused by:
Process logBaseCalling terminated with an error exit status (127)
Command executed:
echo '*********************************'
executor >  local (3)
[e3/4f0be5] process > testInput (multifast5_1.fa... [100%] 1 of 1 ✔
[61/c1ba86] process > logBaseCalling                [100%] 1 of 1, failed: 1 ✘
[-        ] process > baseCalling (guppy-multifa... -
[-        ] process > concatenateFastQFiles         -
[-        ] process > QC                            -
[-        ] process > fastQC                        -
[-        ] process > mapping                       -
[-        ] process > counting                      -
[-        ] process > joinCountQCs                  -
[-        ] process > alnQC                         -
[-        ] process > joinAlnQCs                    -
[-        ] process > alnQC2                        -
[-        ] process > multiQC                       -
Skipping the email
MultiFast5 files detected!
Error executing process > 'logBaseCalling'
Caused by:
Process logBaseCalling terminated with an error exit status (127)
Command executed:
echo ''
guppy_basecaller --version
guppy_basecaller --print_workflows | grep FLO-MIN106 | grep SQK-RNA001
echo ''
Command exit status:
127
Command output:

Command error:
.command.sh: line 3: guppy_basecaller: command not found
Work dir:
/home/aust/master_of_pores/NanoPreprocess/work/61/c1ba86e34fedfaeb88f639c41aad5a
Tip: you can replicate the issue by changing to the process work dir and entering the command bash .command.run

Yes, did you place correctly the guppy executables and the rest of the files? do sh INSTALL.sh in the root of master of pores to download the version 3.4.5

That worked! Thank you!
New question - How much RAM do I need to run this? I have a 1T SSD and 16 GB on an intel i7. The error I'm running into now states that I need at least 20 GB of memory in order to continue. Is there a workaround to run it on 16GB RAM or do I need to upgrade?

Hi,
you can change the requirements changing the nextflow.global.config file. You can reduce there the resources needed
Luca


Simplified guide curve definition

Implement the simplified guide curve definition of cpacs 3:
https://github.com/DLR-LY/CPACS/issues/458
In case of questions @DLR-Wunder (Tobias Wunderlich) is the main contact point at DLR-AS.
It would be good to have it in TiGL 3.0, but could also be postponed to a later release.
The following sub-tasks have to be done:

[x] Merge branch cpacs_3 into branch guide_curves_cnt
[x] Use the auto-generated cpacs read/write routines instead of the already existing routines
[ ] Adapt the old definition to the simplified one

@joergbrech I merged the guide curves branch and the cpacs_3 branch. The result is the branch tigl_3_guide_curves.
You can use this as a starting point. All that has to be done is to adapt the  computation of the curve points, which is done in https://github.com/DLR-SC/tigl/blob/tigl_3_guide_curves/src/guide_curves/CCPACSGuideCurveAlgo.h.


Remove the rlp dependency in merklehash

The rlp should not be the part of merklehash, we should provide a more abstract way.
https://github.com/cryptape/cita-common/blob/develop/merklehash/src/lib.rs#L39
This could be removed directly.
https://github.com/cryptape/cita-common/blob/develop/merklehash/src/lib.rs#L185
This should be implemented by Fn parameter.
https://github.com/cryptape/cita-common/blob/develop/merklehash/src/lib.rs#L115
What about this one?

https://github.com/nervosnetwork/ckb/pull/26

ref:
https://github.com/rust-lang/rust/blob/master/src/liballoc/collections/vec_deque.rs
https://github.com/contain-rs/trie
https://github.com/paritytech/parity-bitcoin/blob/master/sync/src/utils/partial_merkle_tree.rs
https://github.com/paritytech/parity-bitcoin/blob/master/chain/src/merkle_root.rs

https://github.com/cryptape/cita-common/pull/194


add KDE Neon support

Trying out Itamae for local laptop management and found that Neon support was missing in specinfra.  This adds it in. :)
Test itamae recipe:
http_request 'testing' do
  url "https://raw.githubusercontent.com/mizzy/specinfra/master/examples/multiple_backends.rb"
  action :get
  mode '0644'
end

Results:
itamae local test.rb
 INFO : Starting Itamae...
 INFO : Recipe: /home/[snipped]/test.rb
 INFO :   http_request[testing] modified will change from 'false' to 'true'
 INFO :   http_request[testing] mode will be '0644'
 INFO :   diff:
 INFO :   --- testing (BEFORE)
 INFO :   +++ testing (AFTER)
 INFO :   @@ -0,0 +1,46 @@
 INFO :   +require 'specinfra'
 INFO :   +require 'pp'

Tests seem to have failed with github timeouts, maybe another outage. :(

Thanks!

Released as v2.85.1.


#1446 Indexes rules of switch and change nodes for search

Before you hit that Submit button....
Please read our contribution guidelines
before submitting a pull-request.
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply

[x]  Bugfix (non-breaking change which fixes an issue)
[ ]  New feature (non-breaking change which adds functionality)

If you want to raise a pull-request with a new feature, or a refactoring
of existing code, it may well get rejected if it hasn't been discussed on
the mailing list or
slack team first.
Proposed changes

Fixes #1446 , enables rules of Switch and Change nodes to be indexed for search.

Checklist
Put an x in the boxes that apply

[x]  I have read the contribution guidelines
[x]  For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
[x]  I have run grunt to verify the unit tests pass
[ ]  I have added suitable unit tests to cover the new/changed functionality

Hi @knolleary, I was wondering if you could provide some feedback on this PR. Thanks.

Hi - my apologies for the long delay here. I've been busy with other things.
We're trying to get 0.19 done in the next week, so I've pushed an alternative fix for this that does a complete index of node properties regardless of their structure.
Thank you for offering a fix for this; I hope you'll continue to contribute.


Improve media item display size

Ask for a display ratio instead
Option to display full-width

Hello everyone!
I'm sorry to inform the community that I'm officially deprecating this project. 😢 Please read my blog post for details:
http://www.jessesquires.com/blog/officially-deprecating-jsqmessagesviewcontroller/
Thus, I'm closing all issues and pull requests and making the necessary updates to formally deprecate the library. I'm sorry if this is unexpected or disappointing. Please know that this was an extremely difficult decision to make. I'd like to thank everyone here for contributing and making this project so great. It was a fun 4 years. 😊
Thanks for understanding,
— jsq


Demo 11 - UpdateDatabase-LoadAdditionalSales.ps1 fails

Module 11: Manage Files and Datasets in Power BI
Demo: Refresh the dataset
Step: 41
PL-300 Demo Instructions, page 18, step 41 reads: "Right-click the D:\PL300\Demo\Resources\UpdateDatabase-LoadAdditionalSales.ps1 file, and then run with PowerShell."
Red error messages appear indicating a failure to access the database due to the server name being DATA-AI instead of Adventureworks. When I edited to change the server name, it worked.

MOC Labs Review did not experience this issue.

Could not duplicate issue.


Add MicroProfile Config sources for xsp.properties and notes.ini

This will be tricky in that SmallRyeConfigFactory uses exclusively ServiceLoader to find available sources.
It is annotated for use with the OSGi ServiceLoader mediator, so this could be a good opportunity to investigate that again.
Alternatively, it could work to write/subclass a ConfigProviderResolver and set it as the instance, as there's a public static method to do so.


SPARQL 1.1 Conformance test subquery/sq03 fails

(Migrated from https://openrdf.atlassian.net/browse/SES-937)
Cause is the way in which context scoping is handled as part of the statement pattern in Sesame, as opposed to a separate Graph operator, as in the SPARQL algebra.
The query:
{code}
prefix ex:	http://www.example.org/schema#
prefix in:	http://www.example.org/instance#
select ?x where {
graph ?g {
{select ?x where {?x ?p ?g}}
}
}
{code}
On this data:
{code}
:graph1 {
:a :p :b .
:c :p :graph1 .
}
{code}
Sesame returns:
||?x||
|:c|
But the correct answer is:
||?x||
|:c|
|:a|
The core of the problem is variable {{?g}}, which is used both as a statement pattern var and a graph selection var. Sesame binds {{?g}} to the graph name and then evaluates the inner query, thereby eliminating a possible binding of {{?x}} (because {{?g}} is already bound). Since the statement pattern is inside a projection, the binding of {{?g}} in the graph clause should not influence the binding of {{?g}} in the statement pattern.

graph ?g {...} only makes sense for statement patterns, so we shouldnt bind ?g to anything that isnt a statement pattern. It should just be dropped. So the algebra should be
Projection(?x,     Projection(?x,         StatementPattern(?x, ?p, ?g, null, Scope.NAMED)     ) )


Minimal v3 POC requirements

Doc

[x] TS config, when in monorepo the tsconfig should extend the main one
[x] Props are always nullable unless validator
[x] Hooks: you can access to object through "this"
[x] SDK: When querying a boolean, true is "1"

Bugs

[ ] Admin: Input Boolean is null instead of false by default
[ ] Admin: Required fields not showing "*"
[x] API and Admin: images are string instead on object
[ ] SDK / API, when querying using "in" operators, we should not need to add the "[]" before the array .where(tag in [${tagIds}])

New features

[x] hideInCreateEdit
[x] hideInApiResponse
[x] ability to query DB in entity hooks
[ ] Many to many relations
[x] Query relation of relations
[ ] ability to edit Admin user
[x] Order By

For task SDK: When querying a boolean, true is "1" instead of adding it to the doc i allowed boolean filters to be "true" or "false" in addition to "1" and "0" for convinience


Add results links and text for all questions that have them

We've not included the new DEFRA question.
The only question missing results on the spreadsheet is the final one:
"Are you able to leave your home if absolutely necessary?"

Co-authored-by: Issy Long<EMAIL_ADDRESS>Co-authored-by: Jon Hallam<EMAIL_ADDRESS>

Thanks Alex, that's great. I'm going to merge this so it's not blocking anything else (and so that I don't have to rebase when the error pages work starts) - we can add more things later when we have further answers (for the last question, hopefully? it's weird that it doesn't have any).


Conflict with VirtualBox shared file system (vboxsf)

Please provide us with the following information:

OS?  Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)

Vagrant virtual machine. Host system is OS X 10.10.5, guest system is Ubuntu 14.04.3.

Versions. Please run ng --version. If there's nothing outputted, please run
in a Terminal: node --version and paste the result here:

angular-cli: 1.0.0-beta.15
node: 6.6.0
os: linux x64

Repro steps. Was this an app that wasn't created using the CLI? What change did you
do on your code? etc.

Install Vagrant 1.8.5, VirtualBox 5.0.26 r108824, and Vagrant plugins vbguest and vagrant-host-shell.
Create a directory on host system and copy attached Vagrantfile into directory

Vagrantfile.zip

"vagrant up" (which installs a variety of tools including angular-cli, and updates the VirtualBox Guest Additions), then when the provisioning is done "vagrant halt" and "vagrant up" (to get the additions running). (Output attached.)

vagrant output.txt

"vagrant ssh" to get into the vagrant VM
"cd /vagrant" to change to the Vagrant shared directory
run "ng new cli-test"

Results: after about 3 minutes, the build fails, trying to access a very deeply nested file where almost none of the containing folders exist ("cli-test/node_modules/npm/node_modules/request/node_modules/http-signature/node_modules/sshpk/bin/sshpk-conv").

The log given by the failure. Normally this include a stack trace and some
more information.

npm-debug.log.zip

Mention any other details that might be useful.

This problem does NOT occur if running within one of the VM-native file systems (type ext4); in that case everything works fine and the project is created (although I haven't tested the project).

Thanks! We'll be in touch soon.

Happy to provide any desired details, or do whatever tests you like.

I just got the same error

Closing as outdated. If you still have problems with this usecase, let me know.


[$250] Unable to Act on Report Due to Deleted Workspace, Stuck with RBR in Focus Mode Without Edit Access

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.47-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @allgandalf
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1728540959841099
Action Performed:

Submit an expense with violation
Select focus mode in preferences
Delete the Workspace where the expenses was submitted
Observe LHN

Expected Result:
Report in archived status
Actual Result:
See RBR in LHN with the report, but cannot act on it as don't have edit access anymore to that report, but also  cannot do anything here, it stays in my LHN
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/5293139a-30e5-4c83-8a65-cc9145c997cd
Onyx data:
{     "chatReportID": "4695747423350738",     "chatType": "",     "currency": "INR",     "description": "",     "errorFields": {},     "hasOutstandingChildRequest": false,     "hasOutstandingChildTask": false,     "hasParentAccess": true,     "isCancelledIOU": false,     "isOwnPolicyExpenseChat": false,     "isPinned": false,     "isWaitingOnBankAccount": false,     "lastActionType": "CLOSED",     "lastActorAccountID": "16559988",     "lastMessageHtml": "closed this report",     "lastMessageText": "closed this report",     "lastReadSequenceNumber": 0,     "lastReadTime": "2024-10-10 06:16:13.007",     "lastVisibleActionCreated": "2024-04-08 08:54:26.839",     "lastVisibleActionLastModified": "2024-04-08 08:54:26.839",     "managerID": 0,     "nonReimbursableTotal": 0,     "notificationPreference": "hidden",     "oldPolicyName": "Whogandalf's Workspace 27",     "ownerAccountID": 16559988,     "parentReportActionID": "6007246625411673721",     "parentReportID": "4695747423350738",     "participants": {         "16559988": {             "hidden": true,             "notificationPreference": "hidden"         }     },     "permissions": [],     "policyID": "3DEDDF79F054B00A",     "private_isArchived": "2024-07-18 11:24:28.169",     "reportID": "4817250283487348",     "reportName": "Expense Report #5426340451518743",     "stateNum": 2,     "statusNum": 2,     "total": 0,     "type": "expense",     "unheldTotal": 0,     "welcomeMessage": "",     "writeCapability": "all",     "isLoadingPrivateNotes": false,     "privateNotes": {         "16559988": {             "note": ""         }     } }

Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021845769561131002585
Upwork Job ID:<PHONE_NUMBER>131002585
Last Price Increase: 2024-10-21
Automatic offers:

allgandalf | Reviewer | 104576294

Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @AndrewGable

Proposal
Please re-state the problem that we are trying to solve in this issue.
The RBR still shows for deleted workspace chat and its expense report and thread.
What is the root cause of that problem?
There are 3 RBRs here. 1 in LHN,
https://github.com/Expensify/App/blob/8f90bf829406e1584afdb1c82fedacb1fe1419d9/src/libs/OptionsListUtils.ts#L489-L527
1 in report preview,
https://github.com/Expensify/App/blob/8f90bf829406e1584afdb1c82fedacb1fe1419d9/src/components/ReportActionItem/ReportPreview.tsx#L162-L168
and 1 in the expense/transaction preview.
https://github.com/Expensify/App/blob/8f90bf829406e1584afdb1c82fedacb1fe1419d9/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx#L147
None of the conditions check for the report archive status. The expense report will stay on the LHN because we always show it if there are errors other than failed receipt.
https://github.com/Expensify/App/blob/8f90bf829406e1584afdb1c82fedacb1fe1419d9/src/libs/SidebarUtils.ts#L121-L135
Why do the workspace chat and expense/transaction thread not show even if they have the RBR? The reportActions in `SidebarUtils.getOrderedReportIDs is coming from
https://github.com/Expensify/App/blob/5f1ea5806819182c50c330aa065b11fae0b1f98a/src/hooks/useReportIDs.tsx#L87
and somehow the selector that was recently added in https://github.com/Expensify/App/pull/49918 returns a wrong array of actions. For the transaction thread, the parent report action here is undefined,
https://github.com/Expensify/App/blob/5f1ea5806819182c50c330aa065b11fae0b1f98a/src/libs/OptionsListUtils.ts#L503-L504
so, isTransactionThread is always false. It's undefined because we access the allReportActions object without appending the reportActions_ key prefix.
https://github.com/Expensify/App/blob/5f1ea5806819182c50c330aa065b11fae0b1f98a/src/libs/OptionsListUtils.ts#L506
What changes do you think we should make in order to solve the problem?

If we want to keep the RBR but hide it from the LHN, then we should only show the report with error if it's not archived.
https://github.com/Expensify/App/blob/5f1ea5806819182c50c330aa065b11fae0b1f98a/src/libs/SidebarUtils.ts#L129-L135
if (!ReportUtils.isArchivedRoom(report) && hasErrorsOtherThanFailedReceipt && !isReportInAccessible) {
    reportsToDisplay.push({
        ...report,
        hasErrorsOtherThanFailedReceipt: true,
    });
    return;
}

But if we switch to the most recent, the RBR will still show and we still can't do anything with it. So, the other option is to not show the RBR if the report is archived. To do that, we need to check for the report archive status in 3 places that I already mentioned on the first part of the root cause.
https://github.com/Expensify/App/blob/5f1ea5806819182c50c330aa065b11fae0b1f98a/src/libs/OptionsListUtils.ts#L506-L521
if (!ReportUtils.isArchivedRoom(report)) {
    ...
}

https://github.com/Expensify/App/blob/5f1ea5806819182c50c330aa065b11fae0b1f98a/src/components/ReportActionItem/ReportPreview.tsx#L162-L168
const hasErrors =
    !ReportUtils.isArchivedRoom(iouReport) && (...);

https://github.com/Expensify/App/blob/5f1ea5806819182c50c330aa065b11fae0b1f98a/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx#L147
const shouldShowRBR = !ReportUtils.isArchivedRoom(iouReport) && (...);

Then, we should also hide the error from the money request view. We already don't show any error if readonly is true,
https://github.com/Expensify/App/blob/5f1ea5806819182c50c330aa065b11fae0b1f98a/src/components/ReportActionItem/MoneyRequestView.tsx#L268-L291
but we never pass it. We need to pass the archive status as the readonly value.
https://github.com/Expensify/App/blob/5f1ea5806819182c50c330aa065b11fae0b1f98a/src/pages/home/report/ReportActionItemContentCreated.tsx#L112-L115
https://github.com/Expensify/App/blob/5f1ea5806819182c50c330aa065b11fae0b1f98a/src/pages/home/report/ReportActionItemContentCreated.tsx#L168-L171
readonly={ReportUtils.isArchivedRoom(report)}

@allgandalf added you as C+ 👍 thanks for volunteering :)

@allgandalf sorry I forgot to share the results 🙈 thanks for the bump!
The conclusion (in #product) was that if it can't be actioned it shouldn't have RBR. Fine to show violation in the actual expense, but not in the LHN

My proposal actually already have that case, but I updated to remove the others.

@AndrewGable ready for your review! https://github.com/Expensify/App/issues/50573#issuecomment-2427063611

I just re-tested and the expense report now isn't archived when deleting the workspace chat.

workspace chat (archived, RBR)
expense report (not archived, RBR)

The conclusion (in #product) was that if it can't be actioned it shouldn't have RBR. Fine to show violation in the actual expense, but not in the LHN

Based on this, then it's fine to show the RBR for the expense report, but should we still show the RBR for the archived workspace chat?

@bernhardoj let's not show the RBR for the archived workspace chat. The chat is closed for new comments so there's no way for the user to clear the RBR

Thanks for the confirmation!
PR is ready
cc: @allgandalf

@allgandalf please complete the checklist so that I can release the payment for you tomorrow 😊

Requested in ND.

Waiting for payment summary.

@JmillsExpensify good to approve the ND request 💰

$250 approved for @bernhardoj


Deadlock issue on mass update

If we execute the update statement that modified lots of records, then OrientDB locks itself. The ONewLockManager maintains array of 512 locks and for some reason assigns same lock id for records with different ids. That causes deadlock and only recovery is system restart.

Could you provide script which you use for mass update ?

If you prefer , you may send thread dump instead . Probably it should be enough .

@johnmelba any news on this?

Please check it
/// part of TestQueryRecordLockUnlock

  @Test
  public void testMassUpdate_Regression3841_3631() throws InterruptedException {
    ODatabaseDocumentTx db = null;
    final String targetDB = "memory:testMassUpdate_Regression3841_3631";
    final int recordsCount = 1024;// more than lock buckets
    try {

      db = new ODatabaseDocumentTx(targetDB);
      if (db.exists()) {
        db.open("admin","admin");
        db.drop();
      }
      db.create();

      // prepare records for locking all buckets
      for (int x = 0;x<recordsCount; x++ )
      {
        ODocument doc = new ODocument();
        doc.setClassName("Doc");
        doc.field("count", 1);
        doc = db.save(doc);
      }

      db.commit();
    } finally {
      if (db != null)
        db.close();
    }
    int scans = 20;

    ExecutorService pool = Executors.newFixedThreadPool(10);
    for (int i = 0; i < scans; i++) {
      pool.submit(new Runnable() {

        @Override
        public void run() {
          ODatabaseDocumentTx db = null;
          try {
            db = new ODatabaseDocumentTx(targetDB);
            db.open("admin", "admin");
            String asql = "update Doc INCREMENT count = 1 RETURN AFTER LOCK RECORD ";
            db.command(new OCommandSQL(asql)).execute();
            Thread.sleep(50);
          } catch (Exception e) {
              e.printStackTrace();
          } finally {
            db.close();
          }
        }
      });
    }
    pool.shutdown();
    pool.awaitTermination(20, TimeUnit.SECONDS);

    db = new ODatabaseDocumentTx(targetDB);
    db.open("admin", "admin");
    OResultSet<ODocument> res = db.query(new OSQLSynchQuery<Object>("SELECT SUM(count) FROM Doc"));
    final int sumNum = res.get(0).field("SUM");
    Assert.assertEquals(sumNum,recordsCount*(scans+1));
    db.close();

  }

@Luca, as we discussed over chat, I've provided all the information to @laa earlier. This issue is created to make sure that our problem is getting fixed while you are making changes for WAL refactoring / enhancement. The original mail trail was concluded with @laa stating http://www.prjhub.com/#/issues/189 is going to fix it.

Hi, according  to our chant we agreed that it is not deadlock and that updates are slow because of serial nature of locks in WAL. Do you agree with this ?

@laa please try my test case and you will get full picture what's going on.

I run now with big lock timeout let see what we get.

Reproduced, I am on it.

Big thanks! I added some information here #3631 . I think they could be partially relevant to this issue.

Fixed.  Could you try from devleop branch ?

We were waiting for the fix for last 2 months and it was prioritized for next major release stating its WAL issue. Now did it get fixed in 5 hrs? At that time I provided the test case that was very similar to one provided by @kowalot . What I could have done differently to get issue fixed earlier? Also can you shed some light on what was fixed? That should boost my confidence on the fix.

@johnmelba This is the fix accordingly to GitHub: https://github.com/orientechnologies/orientdb/commit/dc3738149eb835c5951e7f80190877faa10090ed

@laa I checked it and it works. Thank you!


QUANTUM JOBS EXECUTION

FEATURES

[ ] SeQuenC-Consortium/qunicorn-core#8
[ ] SeQuenC-Consortium/qunicorn-core#13

Overall Requirements

Developers must be able to execute different types of quantum jobs:

Quantum Circuits embedded as the JSON payload in HTTP Requests
Quantum Circuits sent as files
Quantum application with classical dependencies (containerized or packaged, deployed somewhere)
Qunicorn's API must support executing different jobs

Qunicorn must have a Job Manager component to register and monitor jobs completion

Qunicorn's Job Manager must register typed job requests and persist them in a store

Evaluate SQL/NoSQL options for storing jobs submitted to qunicorn, e.g., Redis vs. Mongo vs. MySQL etc.

Qunicorn must have a Job Scheduler component that maintains a job queue and distributes jobs to execution components

Possible: Python Celery as a job queue, other options possible too - Evaluate
Job Scheduler could support different scheduling algorithms and enable switching between them
Stale jobs should be monitored and reported by Qunicorn
Unsuccessful jobs may be resubmitted or canceled - possibly decide via configuration in Job

Qunicorn must support pluggable execution components (aka Qunicorn Pilot Managers)

see Master-Worker and Pilot-Manager patterns for general idea

Different Pilot Managers can be implemented for different Job Types, for example:

Pilot Manager A: Supports running IBMQ jobs, i.e., quantum circuits embedded in HTTP requests
Pilot Manager B: Supports running AWS Braket jobs, i.e., quantum circuits embedded in HTTP requests
Pilot Manager C: Supports execution of containerized quantum programs, e.g., Python file + dependencies

Can be implemented as a FaaS platform that "deploys" a referenced container and exposes it via endpoint

Qunicorn must support registering local and remote Pilot Managers

For example, users might want to run an existing Piliot Manager locally and register it within Qunicorn such that jobs could be registered by Qunicorn and then submitted for execution on their local infrastructure

Pilot Managers need to maintain their internal job queues to keep track of existing quantum jobs and their status, and convey this information periodically to the Job Manager component

see Section 4 in the funcx paper for an idea of hierarchical queues

This issue need finer granularity to be workable. As a next step, smaller issues should be created that are referenced here.


Unknown action

The latest version of gh and the extensions looks broken, it simply writes "unknown action"
$ gh --version
gh version 2.20.0 (2022-11-08)
https://github.com/cli/cli/releases/tag/v2.20.0

$ gh ext list | grep notify
gh notify  meiji163/gh-notify  3dcfb04a

$ gh notify

unknown action: change-preview:printf "Help\n%s" "
    gh notify [-Flag]

Flag   │ Description
───────│───────────────
<none> │ show all unread notifications
-a     │ show all (read/ unread) notifications
-r     │ mark all notifications as read
-e     │ exclude notifications matching a string (REGEX support)
-f     │ filter notifications matching a string (REGEX support)
-s     │ print a static display
-n NUM │ max number of notifications to show
-p     │ show only participating or mentioned notifications
-w     │ display the preview window in interactive mode
-h     │ show the help page

    Interactive mode with Fuzzy Finder (fzf)

HotKey   │ Description
─────────│───────────────
?        │ toggle help
tab      │ toggle preview notification
enter    │ print notification and exit
shift

hi, the issue looks like it comes from fzf

the action change-preview(...) was added with version 0.29.0

Could you send your fzf version, or try to update to a newer version and run gh notify again?

❯ fzf --version
0.36.0 (brew)

Thanks, it worked after updating
$ brew upgrade fzf
==> Upgrading 1 outdated package:
fzf 0.28.0 -> 0.34.0


Netlify CMS - Automate GUID and URI generation

@bradystroud @william-liebenberg
In Netlify CMS, the GUID and URI fields are shown to the user. It would be a better UX if these fields were hidden and automatically populated with values.
We will likely need a custom widget to do this.
The GUID field should be hidden.
The URI field should still be editable.
In Netlify CMS:

Automate GUID generation
Automate URI generation

AB#61018

@pierssinclairssw @bradystroud @william-liebenberg
The automatic GUID generation has been implemented as seen in PR #593.
It is not possible to automate the URI generation at this stage as there is no feature to access values of other input fields. The value in the title field cannot be read dynamically to generate a URI from it.
A separate issue #595 has been created for the URI generation.

cc: @bradystroud @william-liebenberg
Hi Piers,

Automate GUID generation

Done -

Figure: No GUID field in Netlify CMS
Thanks,
Taine