Complex URL not parsed properly

We had a case where a complex URL (generated by Kibana) was not properly parsed:
Here is the original URL, as reported downstream:

http://elk.canda.biz/app/kibana#/discover?_g=()&_a=(columns:!(_source),index:'deve-*',interval:auto,query:(query_string:(analyze_wildcard:!t,query:'*')),sort:!('@timestamp',desc))

This is how Parsedown handles it (notice how the trailing )) are not part of the hyperlink).

This is reproducible in http://parsedown.org/demo

Bug according to the GitHub flavoured markdown spec: regarding trailing punctuation, parentheses are permitted as part of the link if they balance (which they do in this case)
(@erusev which means that the implementation ending the link at the word boundary, with an optional any number of /s is going to cause bugs here)
Notably, the CommonMark style autolink implementation, which includes surrounding angle brackets, does not have this restriction currently in Parsedown.
So using
<http://elk.canda.biz/app/kibana#/discover?_g=()&_a=(columns:!(_source),index:'deve-*',interval:auto,query:(query_string:(analyze_wildcard:!t,query:'*')),sort:!('@timestamp',desc))>
could be used as a work around until this is fixed.

Thanks for the feedback and for the proposed workaround.
Although it does work on the demo, it doesn't in our case so I need to find out what kind of extra processing is taking place on our end.

@dregad as a workaround you can always put the link into < and > which should render it correctly.
For fixing the detection of the URL using balanced parenthesis you can use this regex: https://github.com/cebe/markdown/blob/641bd1a98efe932c65225ca9fb23b4846e20221e/inline/UrlLinkTrait.php#L25-L31

I encountered a similar issue recently, and I believe it's how parsedown handles matching () inside of a link destination.
First, here's an example from the GitHub-flavored Markdown specification:

Any number of parentheses are allowed without escaping, as long as they are balanced:
[link](foo(and(bar)))

link

After toying with the Parsedown demo, these are my findings:
A matching pair of parentheses parses correctly as long as there is some text between them:
[link](https://www.derp.co/(derp)y)  => link
However, if there is a matching pair of parentheses without text between them, Paresedown breaks:
Source: [link](https://www.derp.co/()y)
Expected: link
Actual:[link](https://www.derp.co/()y)

FWIW, parens fail to render correctly when the link is enclosed in italics: https://github.com/erusev/parsedown/issues/375#issuecomment-633156058

For another workaround, you can replace () in a URL with %28%29.


Homebrew cask

Could one of the contributors register the desktop version as a homebrew cask for Mac users?
Details here: https://github.com/caskroom/homebrewcask/blob/master/doc/development/adding_a_cask.md
Ideally after setting this up, Mac users can run brew cask install graphql-playground, which will subscribe to new releases via brew update.

Someone has already submitted an issue to add this to home-brew over at #142. But I think adding it as a cask is better.
In addition, I haven't found where the app is using the built-in Electron updater. It's pretty easy to add. If this is something that sounds helpful, I'll be glad to submit a PR! It'd help everyone because they wouldn't need to check GitHub for updates!

That sounds very interesting! @DevanB that would be really cool, I would love to see a PR for that!
Have you also looked into https://github.com/zeit/hazel? And did you already use the built-in Electron updater? You can also join our slack and ping me there, I'm @tim2 there so we can discuss this!

@timsuchanek For sure, I'm on the Slack team; I'll ping you there!

Added to cask here: https://github.com/caskroom/homebrew-cask/pull/41771


python3Packages.sendgrid: 6.9.1 -> 6.9.2

Motivation for this change
Update to latest upstream release 6.9.2
Change log: https://github.com/sendgrid/sendgrid-python/releases/tag/6.9.2
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 148348 run on x86_64-linux 1

2 packages built:

python38Packages.sendgrid
python39Packages.sendgrid


bug

line 160
imagedEventHandlers[imageElement] = imageElementClickHandler;
when there has two or more  img element is the same then can not unbind it because the imageElementClickHandler is not the same
can change it to
imagedEventHandlers[galleryID+'__'+imageIndex] = imageElementClickHandler;
?

Hi, finally I've found some time to look at it. Indeed you were right. The code was prone to memory leaks and undefined behavior if more than one image had the same href. Now the hash is more unique and it should work as long as there won't be multiple same images in one gallery (may be improved in the future).
Thanks for reporting that!


get dynamic client from cache

What type of PR is this?
kind/enhancement
kind/performance
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Codecov Report

Merging #708 (302eb5a) into main (e2ffa5f) will decrease coverage by 0.68%.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main     #708      +/-   ##
==========================================
- Coverage   13.60%   12.92%   -0.68%
==========================================
  Files          66       76      +10
  Lines        7492     8710    +1218
==========================================
+ Hits         1019     1126     +107
- Misses       6391     7499    +1108
- Partials       82       85       +3

see 49 files with indirect coverage changes


Consider using JSON convertion for path and query parameters

When an enum value is passed in the path or query, the EnumMemberAttribute is ignored because the value is serialized with ToString().
public enum Operation
{
    [EnumMember("set")]
    Set,
    [EnumMember("update")]
    Update,
}

public enum Value
{
    [EnumMember("one")]
    First,
    [EnumMember("two")]
    Second,
}

public async Task DoAsync(Operation operation, Value value)
{
    // path = {operation}
    // value is a query parameter
}

Called with DoAsync(Operation.Set, Value.First) will result in the Set?First URL instead of set?one.
It would be great if the JSON serializer was used to serialize values to path and query.

Should this have a setting for retro-compatibility?

I think it is fine to just fix it. If this is how web api behaves, the generated spec is always incorrect and we will not break someones code... Adding settings for every change makes the project/codebase too complicated...

I was asking as it will break clients generate on previous versions that used, for example, a custom enum name generator.

You are right but without without minor breaking changes it is very hard to evolve the project. And i think in this case it is fine because custom name generators are not that common and introducing legacy settings makes the codebase and usage more complicated.. what do you think?

Json.NET doesn't seem to expose the enum conversion based on the EnumMemberAttribute. It will always be quoted.


undefined reference to `json_object'

i am using jannson on cortex M7 processor and have successfully installed it.
static json_t* root;
root = json_object();
This is the sample program i was trying to build and i get the undefined reference error. i do not get any error on the json_t only on this object and any other objects i use for example jason_integer().
I do use the -ljansson flag on my cmake file.
I am somehow able to link to jansson.h but not to the value.c file that contains the definition of json_object().
Please do help me with this issue.
Thanks in advance
Celia Joseph

on giving the path to libjansson.a file in the target_link_options() in the cmake file, i was able to solve this issue.


Feature/add file

Adds file indexing support:

Text
PDF
CSV
Image

Adds preview of file indexing and URL indexing

Good to go


odo project commands for  docker pushTarget

all odo project * commands need to work properly with docker pushTarget

[ ] create
[ ] delete
[ ] get
[ ] set
[ ] list

/area local
/kind epic

we are not going to add new features to docker/local workflow and hence closing this issue


Grouping Copyrights, License and Release checks in 1 job

Suggested change to merge 3 repo check jobs in one.

Is this ready for review @adrienbernede?

@tzanio Not yet, I am testing it, and improving a bit.

Thank you @mlstowell for getting involved in the testing!

Thank you @mlstowell for getting involved in the testing!

I am a strong advocate for testing. I tend to focus more on unit tests partly because I haven't yet learned much about GitHub workflows and the like. I, for one, am very glad we have you on the team to help us with such things, @adrienbernede!


Hybrid domains not saved in All-caps in the DB

Is your suggestion related to an experience ? Please describe.
Hybrid domains (Application/Internal) are not saved in all-caps but in PascalCase whereas other domains including PRIMARY are saved in all-caps in the DB. For consistency it is better to adhere to one case(all-caps) when saving all domains in the Database.
When this improvement is being implemented, in-order to avoid any bug regressions in future it is required to revert the fix done in [1] which was done to fix the issue [2]. Because changing the Application domain from PascalCase to All-caps in the DB will automatically fix the issue in performing the DB search.
[1] https://github.com/wso2/carbon-kernel/pull/3105
[2] https://github.com/wso2/product-is/issues/12445

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Fix SW-19523

1. Why is this change necessary?
New cronjobs are never 'active', because the 'end' date is never set.
2. What does this change do, exactly?
Setting the 'end' date of new cronjobs, so the 'active' flag will actually be useful. As a result, plugins which are set active in the cronjob.xml file, will actually be executed / activated. (Which is the expected behavior)
3. Describe each step to reproduce the issue or behaviour.
Install any plugin with cronjob.xml, and look at the configuration of the cronjobs. It will show as 'not active' in configuration, even though you may have included <active>true</active> within the XML.
4. Please link to the relevant issues (if any).
https://issues.shopware.com/issues/SW-19523
5. Which documentation changes (if any) need to be made because of this PR?
None, this fixes a bug.
6. Checklist

[x] [N/A] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

hey @EtienneBruines
there is already an open PR regarding this issue https://github.com/shopware/shopware/pull/1217

@mitelg Oops; apologies. Forgot to check the past few weeks. Wasn't there a month ago :sweat_smile:


Allow build with cyclonedx-python-lib 6.0.0+

get_instance() has been renamed to make_outputter() and removed in 6.0.0.
Fixes #705.

Thanks.


Modal property does not work

Noty version: 3.0.1
Browser: Chrome
OS: Windows 10

Hello, as I understand "modal" property hasn't been implemented yet. Or it is bug?
Thank you!

@MaximStone Yes, not implemented yet. Will be implemented in next release.

Impemented in v3.1.0-beta

I like to know if there cuould a posibility to use noty with an overlay for notify the user something like [procesing...] for a process that may take some time?
noty.show -> start ... end -> noty.hide
without the posibility for user to interact


Server takes long time to send final result during continuous speech

I am running the kaldi-gstreamer server using GMM models on a local machine and it works for decoding my real-time speech. However, the final result appears after a relatively long time. After measuring the average time it takes for the server to send a final result while using it in real-time, I found it to be about 200 seconds (more than a minute and half). Is this normal? How can I optimize the time it takes to return final results? Would switching to a more powerful machine result in noticeable difference?
Also, in this issue you mentioned that the default time it takes to send hypotheses is 0.5 seconds and it is possible to change interval at which the decoder sends hypotheses using traceback-period-in-secs property. However after trying to set it using the sample_worker file, I am getting an error that says there is no such property of OnlineGmmdecodefaster element. How can I change the time interval that the decoder sends hypotheses?
I have attached my sample_worker.yaml file for the sake of clarity.
sample_worker.txt

Is you speech very 'continuous', i.e., without pauses? It's possible that in this case endpointing is never triggered and at the end, the final result has to be generated by decoding a huge lattice. Is the final result generation time dependent on the length of the speech?
The traceback-period-in-secs property is only valid  when using nnet2/nnet3 based models (and the corresponding GStreamer plugin).


[SPARK-41062][SQL] Rename UNSUPPORTED_CORRELATED_REFERENCE to CORRELATED_REFERENCE

What changes were proposed in this pull request?
This PR proposes to rename UNSUPPORTED_CORRELATED_REFERENCE to CORRELATED_REFERENCE.
Also, show sqlExprs rather than treeNode which is more useful information to users.
Why are the changes needed?
The sub-error class name is duplicated with its main class, UNSUPPORTED_SUBQUERY_EXPRESSION_CATEGORY.
We should make the all error class name clear and briefly.
Does this PR introduce any user-facing change?
No
How was this patch tested?
./build/sbt “sql/testOnly org.apache.spark.sql.SQLQueryTestSuite*”

cc @MaxGekk @srielau

+1, LGTM. Merging to master.
Thank you, @itholic.


Calling 'get' also returns partial results

For example:
    comptime var radix = StringRadixTree(u32){};
    comptime _ = radix.insert("await", 0);
    comptime _ = radix.insert("awaitable", 1);
    comptime _ = radix.insert("async", 2);

    try testing.expect(radix.get("aws") == null);

This test will fail; and as per my understanding the call to get should only return the value if the match is complete. For incomplete matches we have getLongestPrefix right?

Landed in 08e0bba


Missing comments in the phaser.comments.d.ts file in release v2.7.3

Hi Phaser Team,
I have updated from v2.7.2 to the latest v2.7.3 and detected that the typescript/phaser.comments.d.ts has no longer any comments. I find them realy helpfull. I have taken a look into the master branch and it is still without comments.
unfortunately the v2.7.2 tag does not exists here.
I have used npm  for installing it.
best regards
Alex

This issue should also be fixed with pull request #33

@photonstorm this issue can be closed as it has been fixed with pr #33

@samme please close this ticket also


Backend port not closed properly when terminating process

To duplicate:

cd backend
npm run dev and let it start
Close the window/prompt
Run npm run dev (or npm start) again
Get error

node:events:492
      throw er; // Unhandled 'error' event
      ^

Error: listen EADDRINUSE: address already in use :::3001
    at Server.setupListenHandle [as _listen2] (node:net:1751:16)
    at listenInCluster (node:net:1799:12)
    at Server.listen (node:net:1887:7)
    at Function.listen (...\backend\node_modules\express\lib\application.js:635:24)
    at Object.<anonymous> (...\backend\server.js:25:5)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Module._load (node:internal/modules/cjs/loader:960:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)

Possible useful read: https://github.com/remy/nodemon/issues/1109

Issues seems to be related to the closing after using npm run dev (related to nodemon).

Issue seems to be isolated to MINGW64 (terminal launched via SourceTree), which does not prompt for batch job termination upon Ctrl + C.
Using other terminals (eg. Command Prompt) seems to resolve the issue.


Chatty Incognito links don't open in Chrome

I'm investigating the cause at the moment, but I'd bet that it's tied to the getAll() call in background.js. Firefox seems to honor the form of the invocation, but it seems the webextension-polyfill causes Chrome some consternation.

It seems that was the last side-effect from the namespace change that I somehow missed (not too many nsfw threads these days). It's surprising it even worked in Firefox given the incorrect form of the invocation in both browser.windows.getAll() and browser.windows.create().


Add package definition on data collection protocol

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ ] Question or discussion
[ ] Bug
[x] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?

Bug

Which version of SkyWalking, OS, and JRE?

Which company or project?

What happened?
If possible, provide a way to reproduce the error. e.g. demo application, component version.

Requirement or improvement

Please describe your requirements or improvement suggestions.

This requirement had derived from this issue. https://github.com/SkyAPM/cpp2sky/issues/36
In short, we should add package definition to the proto of data collection protocol, to avoid conflict between existing class definition like Commands. This feature will cause breaking change so we should discuss carefully. My consideration is to introduce proxy layer to rewrite :path.

What is the impact for current service? if it makes things incompatible, then it is hard to ask all agents and users to upgrade in short term.
In most languages, there are already namespace for generated codes, the skywalking proto will generate codes separately with user codes. Does cpp have any solution about this?

What is the impact for current service?

If the users code space contains class whose name is the same as what we defined in the protocol, it conflicts (maybe won't compile?), this was exactly what I encountered in the Python agent.
In the Python agent, we solve this by generating the codes, and modifying its namespace (top package name in Python's term) to skywalking, https://github.com/apache/skywalking-python/blob/master/tools/codegen.py
I am not sure whether this is feasible in C++.

I knew if there could be conflict in the user codes. But in java, dotnet, even go, there is some package name options used today to avoid this issue. I don't know what are available for other languages.

I mean this, https://github.com/apache/skywalking-data-collect-protocol/blob/master/language-agent/Tracing.proto#L21

The conflict is tricky if those proto files have to generate with other protos, like envoy, AFAIK.

I knew if there could be conflict in the user codes. But in java, dotnet, even go, there is some package name options used today to avoid this issue. I don't know what are available for other languages.

There is no option for Python https://developers.google.com/protocol-buffers/docs/reference/python-generated#package hence we have to do it on our own.
And seems there is no dedicated option for C++, C++ uses package option as per https://developers.google.com/protocol-buffers/docs/reference/cpp-generated#package

The conflict is tricky if those proto files have to generate with other protos, like envoy, AFAIK.

I checked, proto files from Envoy, OpenCensus, Jaeger all have an package declaration.
https://github.com/apache/skywalking/blob/08b31adf60fee5452574e3a45945d9afb457083a/oap-server/server-receiver-plugin/receiver-proto/src/main/proto/jaeger/model.proto#L17
https://github.com/apache/skywalking/blob/08b31adf60fee5452574e3a45945d9afb457083a/oap-server/server-receiver-plugin/receiver-proto/src/main/proto/opencensus/proto/resource/v1/resource.proto#L17
https://github.com/apache/skywalking/blob/08b31adf60fee5452574e3a45945d9afb457083a/oap-server/server-receiver-plugin/receiver-proto/src/main/proto/prometheus/client_model/metrics.proto#L16

I mean they will ask. Anyway, this thing makes sense to me, but the requirement will make the OAP has to adopt service with and without package name, if they are not compatible with previous versions

Quick conclusion: adding package name changes the service name, that breaks all existing agents, I'm still wondering whether we could solve it in cpp2sky side, but package name definitely needs to be added someday when we decide to have break changes

@Shikugawa From the discussion, I think the cpp sdk would share the grpc client with others, so, once the compiling passed, there would never have a conflict on the runtime.
Please correct me if I got something wrong.

@wu-sheng Sure. It would be C++ dedicated problem and no critical solution to avoid this. Maybe in this case, users should use original namespace on thair application. Fortunately, Envoy do that and no problem had caused. https://github.com/envoyproxy/envoy/blob/master/source/extensions/tracers/skywalking/skywalking_types.h#L11
But, to determine package name could be good following with other training software. thank you for discussion.

Quick conclusion: adding package name changes the service name, that breaks all existing agents, I'm still wondering whether we could solve it in cpp2sky side, but package name definitely needs to be added someday when we decide to have break changes

There are ways to provide this compatibility:

we should be able to add package to data messages, this doesn't break wire compatibility (unless we use protobuf.Any, which I don't think this is the case).
make a compat service that have same signature in server-side only, keep with current implementation.
add package to protobuf service, which shares the underlying implementation with 2.

In this way the server would be able to handle both version of service, and it won't break wire compatibility.

FYI this is a dup of https://github.com/apache/skywalking/issues/5266 that we've discussed before.

Quick conclusion: adding package name changes the service name, that breaks all existing agents, I'm still wondering whether we could solve it in cpp2sky side, but package name definitely needs to be added someday when we decide to have break changes

There are ways to provide this compatibility:

we should be able to add package to data messages, this doesn't break wire compatibility (unless we use protobuf.Any, which I don't think this is the case).
make a compat service that have same signature in server-side only, keep with current implementation.
add package to protobuf service, which shares the underlying implementation with 2.

In this way the server would be able to handle both version of service, and it won't break wire compatibility.

Does it means to provide interception layer on the OAP that handles both current message and next version message (with package) ?

No, both version of server using same proto of the data, so it only handles different version of URL on the wire.

we should be able to add package to data messages, this doesn't break wire compatibility (unless we use protobuf.Any, which I don't think this is the case).

In this case, I think it is better for cpp sdk hosts its own and modified trace.proto and common.proto? And verified by e2e with skywalking 8.3.0

make a compat service that have same signature in server-side only, keep with current implementation.

This seems needing a little more coding than generating directly, right?

In this case, I think it is better for cpp sdk hosts its own and modified trace.proto and common.proto? And verified by e2e with skywalking 8.3.0

That can happen in data-collection-protocol directly and won't break anything? The problem is the service package, and it's depends on trace.proto and common.proto. Hosting only those two doesn't solve the issue.

I mean, you said only change message package name would not break anything, right? How about we try this first?

Yeah sure, let's have a separate branch in data-collection-protocol, and point cpp2sky there?

Hey @Shikugawa , I pushed a branch with package in the message, can you take a look? And I'll test the others in other agents and the main repo
https://github.com/apache/skywalking-data-collect-protocol/tree/add-pkg-name

@kezhenxu94 Thank you for your working. LGTM but I have pretty worry in this. The package name seems mostly jvm language way. It will cause on C++ like too-long namespace, such as
::grpc::ClientWriterInterface< ::org::apache::skywalking::apm::network::language::agent::v3::SegmentObject>

Can you shorten this?

@wu-sheng maybe only keep the prefix org.apache.skywalking.v3 to be org.apache.skywalking.v3.SegmentObject? @Shikugawa is that short enough?

@kezhenxu94 I can tolerate it. Thanks.

@kezhenxu94 I can tolerate it. Thanks.

Done

I have asked to make the package name shorter package skywalking.v3;.

A new PR will be supported by @kezhenxu94 to recheck the compatibility with other existing agents.


Add [:each | each key matchesRegex: '^123$']  support

Add MQField>>#matchesRegex:, add MQRegexCondition and test case. Sadly a ton of changes I have no way to influence (or what can I do to have the change reduced to what I actually modified?)

@noha What do you think about this protocol?

Is ok for me.
Don't we need a matchesRegexIgnoreCase: ?

I don't know if it looks ok because I have trouble finding the code through all the diffs in metadata. How do you guys read the diff? From the image?

With a lot of patience :)
Yes is annoying, that's why I support Dale's suggestion (switch to metadata-less), problem is that it requires latest filetree versions then people using (to develop) Pharo 3 and 4 will have some problems.
But is a problem just for developers, users will still be able to load... is just that they will have packages with the form Package.cypress.1

Any guide to have less metadata? This was with a recent Pharo5 image.
For ignore case ... we have a slight issue in protocol. For mongodb we would pass the regexp.. and then use /i to indicate we want to ignore the case.. for pharo that doesn't work.. we would need to modify the argument in the mongotalk case. Is this something we want?

The noise in the diffs because of the metadata is impressive, but @zecke highlighted the important parts and looks fine IMHO (but I don't have experience in this part of Mongo so I wait for others)


make different icons to understand that there are different functions.

Sorry, not sure I understand what you mean. Where exactly do you want icons?

This was released in 1.6.0


♻ remove duplicated time provider behaviour

now and clock fields are both present in the InstallerController struct for the same purpose.
This PR migrates all now calls to clock.Now.

/remove-lifecycle stale

@dgrisonnet
@tkashem
Reckon we can get a look at this?

@dgrisonnet
@tkashem
Reckon we can get a look at this?


AppBuildConfig.h file is missing

Hi, I am trying to build an matter exemple. Unfortunately AppBuildConfig.h file is missing. How can I add it ?
I suppose it is generated by the BUILD.gn file. But I am not really experimented with it.

Hi, I am trying to build an matter exemple

Which exact example?  What exact commands are you running?
AppBuildConfig.h is generated at compile time, normally...


Show aircraft's full route on hover of strip

What about something like this to address #407? Hovering over the strip will show the route?

Note: Don't mind the white scribble, the screen capture always excludes the mouse cursor, so I drew it in to show where the cursor was.
Thoughts, anyone? I'm not sure if I really like it. More ideal might be a right-click that toggles the strip expanding a bit in height to show the route on a third, smaller row... I just don't know if I can achieve the latter...
Demo: erikquinn.github.io/atc/b/show-route-on-hover

Even though I like it, I prefer the idea of the strip expanding to show the route. I also think this would limit the usage of the 'Say Route' command, which is already quite useless. I'm not sure if the 'sr' command was originally meant as a temporary solution, but this feature would be completely replacing it.

I prefer this in comparison to the 'sr' command, it's just a whole lot easier. Plus, it saves the woman on the voiceover from speaking too much - she already talks extremely slow.

Haha, poor woman! I agree, it's a better option, I just wanted to now if @erikquinn 's intentions were to eventually get rid of the 'sr' command.

Oh yeah, it was 100% a temporary solution. It can get the axe. lol
Thanks for the feedback guys. I think I agree, just wanted to toss this up here and get your thoughts. I'll close this now, and we can find another solution sometime.
EQ


Add note about versioning

Adding a note to the docs on ensuring that the notary client and server/signer are the same version, also fixed a small typo
Signed-off-by: Riyaz Faizullabhoy<EMAIL_ADDRESS>

Would be good to include an example: i.e. if you're using notary 0.2, ensure you are using a server and signer tagged with an equal or higher version than 0.2

LGTM!  Thank you for adding this!!

LGTM


Unify image ignore list for building and publishing Garden Linux images

What would you like to be added:
We have an exclude list for image variants here but we don't take this into account here.
We could now just copy that ignore list there, but this would then need maintenance in two places if anything changes. It would be nice to only maintain this ignore list in a single place.
Why is this needed:
Currently we have failed jobs in the 'release publish' job for 1592. This is not bad but it looks bad and is confusing. We should only attempt to publish the images we really build, but avoid hard to maintain double exclude lists.

@fwilhe Is it planned to publish OpenStack ARM64 in the future? We are currently in the progress of enabling ARM64 on our OpenStack cluster and would like to use shoots there as well in the future.

Hi @berendt
thanks for letting us know that this is interesting for you. I can't make any promises, but we'll look into why we disabled this at the time.


Update unit tests from JUnit 4 to JUnit 5

JUnit 5 has been the new standard for unit tests for quite a while now (since 2017). The big challenge for updating from version 4 to version 5 is that the order of the parameters in the various static assert statements such as assertEquals or assertNull has changed. Optional arguments such as the String message were at the front, where optional arguments are typically at the back. JUnit 5 puts these optional arguments at the back, leading to a massive number of changes in the unit test code. The package structure has also changed considerably.
JUnit 5 can be included as:
<dependency>
    <groupId>org.junit.jupiter</groupId>
    <artifactId>junit-jupiter-engine</artifactId>
    <version>5.10.0</version>
    <scope>test</scope>
</dependency>

dsol-core uses the Waiter class in its tests, because the simulation execution is a concurrent, multi-threaded target to test that could timeout. The assertThat method in Waiter is dependent on the hamcrest library. Therefore, include the following dependency in the dsol-core pom file:
<dependency>
    <groupId>org.hamcrest</groupId>
    <artifactId>hamcrest</artifactId>
    <version>2.2</version>
    <scope>test</scope>
</dependency>

All updates have been carried out, and all unit tests pass after the upgrade.


Fix indentation to render a list as a list

Instead of as the markdown for that list in a code block. Expecially since it contains a link to dotenv.
It is the the code block just above "Connect your database": https://www.prisma.io/docs/concepts/components/preview-features/sql-server/sql-server-start-from-scratch-typescript/

Seems the page has quite a lot of indentation problems - I'll merge this PR and fix the rest in my current branch.
Thanks for pointing it out!


Regent: Detect how many dimensions Legion was compiled with

To properly interface with Legion's newly implemented support for a variable number of index space dimensions, Regent needs to know the value of the LEGION_MAX_DIM constant that Legion was compiled against when it calls terralib.includec on legion_c.h.
One option would be to autodetect this by inspecting libregent.so, the way it's done for CUDA and OpenMP, and add an -f flag so the user can set it manually when auto-detection isn't available (and do a dynamic consistency check, when the code starts running).
A cleaner option might be to have the Makefile generate a legion_defines.h header, like the one generated by CMake. This has also been suggested as a way to communicate the link flags that Legion's runtime.mk infers to the compiler (see https://github.com/StanfordLegion/legion/pull/341).

As of ff00fb898db725ec0abb6ce804ff1efb9461e161 we generate legion_defines.h which includes the value for LEGION_MAX_DIM so that it no longer needs to be set on the command line. -flegion-dim is no longer required or supported.


Dynamic Link on a desktop web browser

How to configure parameter for the desktop if deeplink get open on the browser to avoid following screen

As per the firebase documentation ofl parameter is required ?
https://firebase.google.com/docs/dynamic-links/create-manually#parameters

Hi ,
Tried out fallbackUrl ... But on the desktop it is not working...

Hi there! Sorry for the late response. Can you clarify what exactly are you using as the config? Of course you can hide your concrete URLs.
As I understand you should set the uri to make it work in the browser. This is the config that I use in my app:
        const configuration: LinkConfig = {
          domainUriPrefix: '<base-prefix>',
          uri: linkParameter ? `${uri}?${linkParameter}` : uri,
          androidParameters: {
            packageName: '...',
            fallbackUrl: '<base-url>',
          },
          iosParameters: {
            fallbackUrl: '<base-url>',
            bundleId: '...',
            appStoreId: '...',
            ipadBundleId: '...',
            ipadFallbackUrl: '<base-url>',
          },
          webApiKey: this.coreConfig.dynamicLinkApiKey,
          socialMeta,
        };

The uri is the base-url you want to have called in the Web. I also sometimes include additional queryParameter I attach with the linkParameter param.

Hi there! Sorry for the late response. Can you clarify what exactly are you using as the config? Of course you can hide your concrete URLs. As I understand you should set the uri to make it work in the browser. This is the config that I use in my app:
        const configuration: LinkConfig = {
          domainUriPrefix: '<base-prefix>',
          uri: linkParameter ? `${uri}?${linkParameter}` : uri,
          androidParameters: {
            packageName: '...',
            fallbackUrl: '<base-url>',
          },
          iosParameters: {
            fallbackUrl: '<base-url>',
            bundleId: '...',
            appStoreId: '...',
            ipadBundleId: '...',
            ipadFallbackUrl: '<base-url>',
          },
          webApiKey: this.coreConfig.dynamicLinkApiKey,
          socialMeta,
        };

The uri is the base-url you want to have called in the Web. I also sometimes include additional queryParameter I attach with the linkParameter param.

with given config also getting same output in browser as Invalid Dynamic Link

Hm, hard to tell to say whats the issue. I can share the concrete link with you: https://pantrist.page.link/MffBXeBdPQDNRqsB6
This is a link I created using this plugin with the parameter:
        const configuration: LinkConfig = {
          domainUriPrefix: 'https://pantrist.page.link',
          uri: `https://pantrist.app/receipts/receipt?uuid=1684583906794dsqcgwv8q`,
          androidParameters: {
            packageName: '...',
            fallbackUrl: '<base-url>',
          },
          iosParameters: {
            fallbackUrl: '<base-url>',
            bundleId: '...',
            appStoreId: '...',
            ipadBundleId: '...',
            ipadFallbackUrl: '<base-url>',
          },
          webApiKey: this.coreConfig.dynamicLinkApiKey,
          socialMeta,
        };

Basically the plugin only takes the prefix of your dynamic link and uses your uri to generate a Hash for the link like in the example.

Hello sir ...
issue is solved :)
"Maybe the issue is that you use a concrete link as a domainUriPrefix? Like https://pantrist.page.link/sharing instead of https://pantrist.page.link"
This flow help me in rearranging configs ... and it works as required , applnk opens on the desktop browser with given web page and opens the app in mobile devices in android
But in ios getting same issues as described in issues/17


Prevent loading NCL libraries multiple times by design

The best way to achieve this is probably to write a custom load function, see also the discussion in #241.

According to the NCL documentation, multiple load statements do not add much to the computational burden. Implementing this feature seems to be not worthy the effort.


[hi] Update /docs/tutorials/kubernetes-basics/ to align with English

This https://kubernetes.io/hi/docs/tutorials/kubernetes-basics/ should align with the English one https://kubernetes.io/docs/tutorials/kubernetes-basics/
Why is this needed?
https://kubernetes.io/hi/docs/tutorials/kubernetes-basics/ looks like stale.
The issue it solves: #42735

@aj11anuj sorry for the late reply. I will update all mentioned changes by EOD.
Thanks!

@Vikash-8090-Yadav  most of the changes are not required.
Can you summarise intent of all these changes?

hey @Vikash-8090-Yadav, are you still working on this issue!!

hey @Vikash-8090-Yadav, are you still working on this issue!!

Yah.

Hey @kundan2707 ,@divya-mohan0209 I raise this PR because The hindi version seems to be outdated as compared to english and mentioned on the website.
Do lmk if this a valid Contribution.
Ps: Sorry for late response.

@Vikash-8090-Yadav
not agree with content is outdated.

closing as no change required.
Feel free to reopen if it is really necessary

/close


fix: close automation redirects of HttpUrlConnection, same issue with…

… FileDownloader#1295

Codecov Report

Merging #329 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
+ Coverage   83.81%   83.81%   +<.01%
==========================================
  Files          74       74
  Lines        4151     4153       +2
  Branches      672      673       +1
==========================================
+ Hits         3479     3481       +2
  Misses        398      398
  Partials      274      274

Impacted Files
Coverage Δ

...ownload/core/connection/DownloadUrlConnection.java
90.69% <100%> (+0.22%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86caf12...3af0876. Read the comment docs.


chore(Workflow Cards): Styling fix

Signed-off-by: Oum Kale<EMAIL_ADDRESS>
Proposed changes
This PR will fix Cards Styling for Pre-Defined Workflow
Types of changes
What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

[ ] New feature (non-breaking change which adds functionality)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices applies)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have read the CONTRIBUTING doc
[x] I have signed the commit for DCO to be passed.
[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have added necessary documentation (if appropriate)

Dependency

Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

/merge


provide npm package

would be nice if one could install it via npm, to make deployments to CI easier

done over at https://github.com/balupton/cloudflare-stout-npm

Thanks for taking the initiative, @balupton!
I'd also love to have an official package that I can safely use for a production app -- any chance @zackbloom could set that up on npm? That would really make things easier for our project. Thank you both.

Anyone at the cloudflare team care to have the npm package and repo transferred to them? I've moved away from stout, so don't really care about maintaining the npm package anymore. The maintenance of it is easy, just run the ./update command any time a new stout release is published.


Can't see source on a live share debug session

Issue Type: Bug
Start live share session, start debug session, set a breakpoint, run.
The remote session fails to open the file with an error: "Unable to open '': Cannot read property 'create' of null."
Extension version: 1.0.3577
VS Code version: Code 1.52.1 (ea3859d4ba2f3e577a159bc91e3074c5d85c0523, 2020-12-16T16:34:46.910Z)
OS version: Windows_NT x64 10.0.19041
Remote OS version: Linux x64 4.19.104-microsoft-standard

System Info

Item
Value

CPUs
AMD Ryzen 7 3700X 8-Core Processor              (16 x 3600)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.95GB (21.54GB free)

Process Argv
--crash-reporter-id 1988e9e3-0203-4a22-96f0-fe8b446cc639

Screen Reader
no

VM
0%

Item
Value

Remote
WSL: Ubuntu

OS
Linux x64 4.19.104-microsoft-standard

CPUs
AMD Ryzen 7 3700X 8-Core Processor (16 x 3600)

Memory (System)
25.02GB (23.98GB free)

VM
0%

A/B Experiments
vsliv368:30146709
vsreu685:30147344
openlogontheside:30221877
python383:30185418
pythonvspyt617cf:30244267
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30211401
wsl2prompt:30224612
pythonvsdeb440:30248342
unusedprompt:30224610
folderexplorercf:30224615
openfilemenu:30224647
pythonvsded773:30248341
pythonvspyt600cf:30251589

Screenshots:
Left is host, right is joined session.

After hitting run, it stopped properly on the breakpoint, but the source didn't load on the remote session to step through.

Relevant part of launch.json if that matters:
        {
            "name": "g++ (stdin)",
            "type": "cppdbg",
            "request": "launch",
            "program": "${fileDirname}/${fileBasenameNoExtension}",
            "args": [],
            "stopAtEntry": false,
            "cwd": "${workspaceFolder}",
            "environment": [],
            "externalConsole": false,
            "MIMode": "gdb",
            "setupCommands": [
                {
                    "description": "Enable pretty-printing for gdb",
                    "text": "-enable-pretty-printing",
                    "ignoreFailures": true
                }
            ],
            "preLaunchTask": "g++ build active file",
            "miDebuggerPath": "gdb"
        },

Also tasks.json:
{
	"version": "2.0.0",
	"tasks": [
		{
			"type": "shell",
			"label": "g++ build active file",
			"command": "g++",
			"args": [
				"--std=gnu++14",
				"-DDBG",
				"-g",
				"${file}",
				"-o",
				"${fileDirname}/${fileBasenameNoExtension}"
			],
			"options": {
				"cwd": "/usr/bin"
			},
			"problemMatcher": [
				"$gcc"
			],
			"group": "build"
		}
	]
}

Hi,
Same error here when we are performing debug of C++ code.
Extensions installed:

ms-vscode.cpptools
matepek.vscode-catch2-test-adapter
llvm-vs-code-extensions.vscode-clangd

Our lunch.json
{     "version": "0.2.0",     "configurations": [         {             "name": "(gdb) Attach to running backend",             "type": "cppdbg",             "request": "attach",             "program": "${workspaceFolder}/cmk/ENV/component/pack/MDW/bin/otf_be",             "processId": "${command:pickProcess}",             "MIMode": "gdb",             "miDebuggerPath": "/xxxxx",             "setupCommands": [                 {                     "description": "Enable pretty-printing for gdb",                     "text": "-enable-pretty-printing",                     "ignoreFailures": true                 }             ]         }     ] }
Thanks

Thanks for reaching out. Your logs may provide us with helpful information. You can access them via the Live Share: Export Logs command from the command palette (ctrl + shift + p) and attach them to this issue.
@jramsay assigning to you  but feel free to reassign if it is not your area.

Here are the guest session logs. I tried generating logs from the host but they came up empty. Should I collect different logs from there?
guest.zip

hmm not sure why your host logs might came up empty. We will let you know if guest logs are not sufficient enough.

Hello,
I generate some logs, if it can help you to investigate.
If needed I can privide a record of the issue.
When I attach the debuger, the debug panel opens on both side (host and guest).
Then I trigger the test. The execution stops at the first breakpoint, but only the host can use the debug panel, and variable are not visible on guest side.
Then the host click on continue button on the debug panel.
Finally it unlocks the situation on guest side. He can see the variables, and use the debug panel.
debug-host.zip
debug-guest.zip

Do you have any news to share about this issue?

We had a problem with an action that closed some issues unexpectedly. Apologies for that!

Hi, there have been few improvements in Live Share debugging experience. Can you please let us know if you are still facing issues while debugging?

Closing this as stale and we've made improvements in this area. If you feel it deserves to stay open, then clarify your use case and contact us to let us know how severe it is for you.


Uncaught TypeError: ayahIds.first is not a function

hmmm weird...

okay all ayahIds.first() need to be replaced with this.getFirst() and all ayahIds.last() to this.getLast()... must have happened with the merge conflicts

I can fix it or if you'd like to jump on it?

Please move forward to fix this, what about eslint errors?

okay sounds good. Inshallah the eslint errors will be fixed in that PR/relating PRs


Enable x-platform docker images

Supporting arm64 & amd64 for now
https://github.com/dfoxg/kratos-admin-ui/issues/159

Oh crap, it looks like I missed proper env var use there and now the build is failing due to that.
Let me fix that, will publish another PR soon


Uncaught Error: ENOENT: no such file or directory, open '/home/daniel/.atom/packages/sync-setting...

I was editing a .less file.
Got a notification about an update, ran the update of the plugin.
This error was thrown.

Atom Version: 1.5.4
System: Ubuntu 14.04.4
Thrown From: sync-settings package, v0.7.0
Stack Trace
Uncaught Error: ENOENT: no such file or directory, open '/home/daniel/.atom/packages/sync-settings/node_modules/github/api/v3.0.0/routes.json'
At fs.js:549

Error: ENOENT: no such file or directory, open '/home/daniel/.atom/packages/sync-settings/node_modules/github/api/v3.0.0/routes.json'
    at Error (native)
    at Object.fs.openSync (fs.js:549:18)
    at Object.module.(anonymous function) [as openSync] (ATOM_SHELL_ASAR.js:137:20)
    at Object.fs.readFileSync (fs.js:397:15)
    at Object.fs.readFileSync (ATOM_SHELL_ASAR.js:385:29)
    at Object.module.exports (/home/daniel/.atom/packages/sync-settings/node_modules/github/api/v3.0.0/index.js:22:33)
    at new module.exports (/home/daniel/.atom/packages/sync-settings/node_modules/github/index.js:184:26)
    at Object.SyncSettings.createClient (/home/daniel/.atom/packages/sync-settings/lib/sync-settings.coffee:198:18)
    at Object.SyncSettings.checkForUpdate (/home/daniel/.atom/packages/sync-settings/lib/sync-settings.coffee:46:8)
    at Immediate._onImmediate (/home/daniel/.atom/packages/sync-settings/lib/sync-settings.coffee:32:8)
    at processImmediate [as _immediateCallback] (timers.js:374:17)

Commands
     -0:37.4.0 settings-view:check-for-package-updates (atom-workspace.workspace.scrollbars-visible-always.theme-monokai-seti.theme-seti-ui)

Config
{
  "core": {
    "autoHideMenuBar": true,
    "disabledPackages": [
      "preview",
      "preview-plus",
      "tool-bar",
      "meteor-api",
      "pigments",
      "linter-tidy"
    ],
    "themes": [
      "seti-ui",
      "monokai-seti"
    ]
  }
}

Installed Packages
# User
angularjs, v0.3.4
atom-beautify, v0.28.26
atom-html-preview, v0.1.16
atom-ternjs, v0.13.2
color-picker, v2.1.1
csslint, v1.1.4
language-babel, v2.15.5
linter, v1.11.3
linter-csslint, v1.3.2
linter-jshint, v2.0.2
minimap, v4.20.0
monokai-seti, v0.7.0
open-recent, v5.0.0
package-sync, v1.0.0
react, v0.14.1
seti-ui, v0.9.1
sync-settings, v0.7.0
term3, v0.21.2

# Dev
No dev packages

Duplicate of https://github.com/Hackafe/atom-sync-settings/issues/194.
In the above error report you have shared your personalAccessToken. You must revoke it to prevent abuse.

Thanks for letting me know, I didn't notice that. I've removed that part from my original issue report, and I'll also revoke the token.


Helm Chart: allow advanced/custom configuation of output plugins

Is your feature request related to a problem? Please describe.
I use fluentd with the elsticsearch output plugin, installed from Helm chart. The related part of my Helm chart values.yaml is as follows:
fluentd:
  ...
  output:
    es:
      enable: true
      host: ...
      port: 9200
      logstashPrefix: k8s_logs_sb
      buffer:
        enable: true
        type: file
        path: /buffers/es

Now I'm experiencing some performance issues with ES calls failing due to timeout (read timeout reached), therefore I need to perform some configuration tuning.
This is however not so easy with your Helm chart as it doesn't allow anything beyoned the above to be configured by default (and many parameters aren't even supported in the fluentd ClusterOutput or Output resource so it isn't possible to specify them in custom resources either).
Describe the solution you'd like
Would it be possible to add at least some custom output plugin configuration section where one would directly specify the plugin parameters (in this case those documented at https://github.com/uken/fluent-plugin-elasticsearch#configuration) that would be then added to the generated configuration?
This would be useful for both fluentd and fluentbit output plugins and for the custom resources Output and ClusterOutput as well.
Describe alternatives you've considered
I (rather temporarily) added the request_timeout parameter to the config via editing the fluentd-config secret and restarting the fluentd statefulset, but that isn't quite straightforward (one needs to decode tbe base64 encoded config, modify it, reencode and save it).
Additional context
No response

I'm also encountering the issue https://github.com/uken/fluent-plugin-elasticsearch/issues/785 which could be remedied with setting suppress_type_name true but again it's currently impossible to specify it via Helm chart values.
As there's quite a lot of possible settings, it would be probably easier to add some "custom" configuration section instead of directly supporting each setting supported by the particular plugin.

@hostalp I have the same problem

@hostalp @tanmx, we already have the custom plugin feature that might solve your problem in a different way, see https://github.com/fluent/fluent-operator/blob/master/docs/best-practice/custom-plugin.md .
But what you mentioned is a custom section feature for existing strong-typed plugins like es and we'd like to see a proposal and a following PR from the community.

@benjaminhuo thanks a lot, customplugin olve my problem

@tanmx could you please show how you used it in addition to your previous fluentd configuration?
I'm trying to add the following configuration to my fluentd opensearch output:
  <endpoint>
    url https://my-domain-endpoint.us-west-2.es.amazonaws.com
    region "#{ENV['AWS_REGION']}"
    assume_role_arn "#{ENV['AWS_ROLE_ARN']}"
    assume_role_web_identity_token_file "#{ENV['AWS_WEB_IDENTITY_TOKEN_FILE']}"
  </endpoint>

By applying this:
apiVersion: fluentd.fluent.io/v1alpha1
kind: Fluentd
metadata:
  name: fluentd
  namespace: fluent-system
  labels:
    app.kubernetes.io/name: fluentd
spec:
  globalInputs:
    - forward:
        bind: <IP_ADDRESS>
        port: 24224
  replicas: 1
  image: kubesphere/fluentd:v1.15.3
  resources:
    limits:
      cpu: 500m
      memory: 500Mi
    requests:
      cpu: 100m
      memory: 128Mi
  fluentdCfgSelector:
    matchLabels:
      config.fluentd.fluent.io/enabled: "true"
---
apiVersion: fluentd.fluent.io/v1alpha1
kind: ClusterFluentdConfig
metadata:
  labels:
    config.fluentd.fluent.io/enabled: "true"
  name: fluentd-config
spec:
  clusterFilterSelector:
    matchLabels:
      filter.fluentd.fluent.io/enabled: "true"
  clusterOutputSelector:
    matchLabels:
      output.fluentd.fluent.io/enabled: "true"
  watchedNamespaces:
    - default
    - fluent-system
    - observability-system
---
apiVersion: fluentd.fluent.io/v1alpha1
kind: ClusterOutput
metadata:
  name: cluster-fluentd-output-os
  labels:
    output.fluentd.fluent.io/scope: "cluster"
    output.fluentd.fluent.io/enabled: "true"
spec:
  outputs:
    - customPlugin:
        config: |
          <match **>
            @type opensearch
            host my-domain-endpoint.us-west-2.es.amazonaws.com
            port 443
            logstash_format  true
            logstash_prefix  logs
            scheme https
            <endpoint>
              url https://my-domain-endpoint.us-west-2.es.amazonaws.com
              region "#{ENV['AWS_REGION']}"
              assume_role_arn "#{ENV['AWS_ROLE_ARN']}"
              assume_role_web_identity_token_file "#{ENV['AWS_WEB_IDENTITY_TOKEN_FILE']}"
            </endpoint>
          </match>

But when I apply it throws the following error:
error: error validating "fluentd.yaml": error validating data: ValidationError(ClusterOutput.spec.outputs[0]): unknown field "customPlugin" in io.fluent.fluentd.v1alpha1.ClusterOutput.spec.outputs; if you choose to ignore these errors, turn validation off with --validate=false


error in docker pull

Following the instructions from ReadMe - but getting the below error:
$ sudo docker pull crossbario/autobahn-cpp:clang
Pulling repository docker.io/crossbario/autobahn-cpp
Tag clang not found in repository docker.io/crossbario/autobahn-cpp

The docker pull crossbario/crossbar succeeded though

Additionally below error is happening with other commands from read me:
$ docker run -it crossbario/autobahn-js node /root/client.js ws://<IP_ADDRESS>:8080/ws realm1
Unable to find image 'crossbario/autobahn-js:latest' locally
latest: Pulling from crossbario/autobahn-js

4d06f2521e4f: Already exists
9826b741c0da: Pull complete
8509b76ffdf7: Pull complete
af571db96534: Pull complete
4e608817ffca: Pull complete
Digest: sha256:804b5f77048b76cae715cf42597e222bf04c641f5347aa1a264937647a1f1cc5
Status: Downloaded newer image for crossbario/autobahn-js:latest
module.js:328
    throw err;
    ^

Error: Cannot find module '/root/client.js'
    at Function.Module._resolveFilename (module.js:326:15)
    at Function.Module._load (module.js:277:25)
    at Function.Module.runMain (module.js:442:10)
    at startup (node.js:136:18)
    at node.js:966:3

Thanks for the catches!

autobahn-cpp:clang does not exist, so removed the reference in the README
/root/client.js is now just client.js (and works)

Thank you. The client.js worked.
About the autobahn-cpp, the command docker pull crossbario/autobahn-cpp:gcc worked.
But, the ReadMe does not contain much info on how to use this autobahn-cpp docker once it is downloaded. For example, what is the run command for this autobahn-cpp docker (similar to the js one) ? Say, I want to play with the callee and caller examples of the cpp


tsc with outDir option is not copying the JS import node_modules to outDir

I have the tsconfig.json as follow:
{
    "compilerOptions": {
        "sourceMap": true,
        "module": "commonjs",
        "target": "es6",
        "declaration": true,
        "outDir": "./bin"
    },
    "files": [
        "app.ts" // and some other files...
    ]
}

The project has some dependencies in node_modules like firebase that I import like that:
import Firebase = require('firebase');

The problem is that the TS modules imported in similar way:
import {myType} from 'myModule/myModule';

are copied (in fact they are compiled) to outDir but not JS modules.
I think it's not intuitive/consistent that I have to copy in separated task JS modules to outDir. I checked wiki page and github issues and I do not see any reference to my scenario.

JavaScript files are never compiled/copied unless you set allowJs. That said, I'm pretty sure that's not what you really want. Code in NPM packages installed under node_modules should stay there. Your deployed app should also install the NPM package as part of deployment, and the modules will be resolved at runtime by Node.


#161420783 Create a db-powered endpoint for store owners to create products

What does this PR do?
This PR creates the endpoint for store owners to create products
Description of Task to be completed
The main tasks to be completed are:
Creation of an endpoint for store owners to create products
Connect it to the database
How should this be manually tested?

Create  a virual enviroment with the command
$ virtualenv -p python3 env

Activate the venv with the command
$ source env/bin/activate

Install git
sudo apt install git

clone this repo
$ git clone https://github.com/codeMarble254/Store-Manager-v1.git"

cd into the folder Store-Manager-V1

export required enviroment variables
$ export FLASK_APP=run.py
$ export DB_NAME="storemanager"
$ export DB_HOST="fill in your localhost"
$ export DB_USER="fill in the db user"
$ export DB_PASSWORD="fill in your db user password"
$ export SECRET_KEY="<your key>"

create the dev database
createdb storemanager

create the testing database
$ createdb test_db

Switch to the current branch
$ git checkout ft-create-product-v2-161420783

install requirements
$ pip install -r requirements.txt

now we are ready to run.
8.now we are ready to run.
for tests
export APP_SETTINGS="testing"
pytest app/test/v2 -v --cov=app/test/v2

for the application run
export APP_SETTINGS="development"
$ flask run
If you ran the application you can test the  api end points using postman as follows

Endpoint
functionality
contraints(requirements)

post /api/products
Create products
User authentication

What are the relevant pivotal tracker stories?
#161420783

Pull Request Test Coverage Report for Build 128

176 of 178 (98.88%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.6%) to 98.876%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

app/test/v2/test_users.py
83
85
97.65%

Totals

Change from base Build 67:
1.6%

Covered Lines:
176

Relevant Lines:
178

💛  - Coveralls

Pull Request Test Coverage Report for Build 128

176 of 178 (98.88%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.6%) to 98.876%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

app/test/v2/test_users.py
83
85
97.65%

Totals

Change from base Build 67:
1.6%

Covered Lines:
176

Relevant Lines:
178

💛  - Coveralls


DB Connection Issues

BookStack Version: v0.14.3
PHP Version: PHP 7.0.13
MySQL Version: mysql  Ver 15.1 Distrib 10.1.21-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2

Expected Behavior
We'd like to enable some type of DB connection pooling or be able to safely refuse the connection.
Actual Behavior
Our installation of Bookstack (5 users) is using 450 connections within a given hour, putting our DB host in an higher-than-comfortable operating state.
Thanks Dan

Hi @Ethanb00. Fist up I'll admit I'm not too knowledgeable on the technicalities of database connections so I may need some help understanding this issue.
From what I'm aware of, A connection is essentially 'released' back once the query has executed so it's not 'using them up' in any way. 450 does not sound absurd to me although I don't really have  a baseline for what that value should be. Does the action of creating new connections really put a strain on a database server?

Thanks for writing back @ssddanbrown.
Mostly our issue comes from the memory allocations required since there is a new connection required for each database action. We've added some parameters to MariaDB to minimize the impact, but it's not a particularly efficient process.
Essentially, I don't think the connections to the DB are timing out correctly.

Since I have not heard of any similar issues arise over the last 3 years, I'm going to close this off, but I'll try to keep it in mind in the event I see other similar issues filed in the future or if I'm doing DB optimization work.
If anyone comes across this in the future and can pin-point any particular issue, feel free to open a new issue referencing this one.


Removed requirement of Android hooks

@dpa99c your thoughts on this, please.

@sagrawal31 Thanks, I'll give this a test and report back.
FYI I'm moving house next week so fairly busy packing my entire life into boxes right now but I will try to get back to you ASAP 😀

As I've outlined in #63, I've determined the cause of the uninstall issue and it's not related to the Android hook scripts removed by this PR.
Therefore I'm not sure merging this PR is necessary unless it adds other benefits?

@sagrawal31 Is there any benefit to merging this PR now (since #63 was fixed by removing the <resource-file> to copy the dummy google-services.json to the Android project)?
I guess it's cleaner than using the hook scripts but I'm always nervous of using the apply plugin in non-root Gradle configs to due the possibility of version conflicts with other plugins...

@dpa99c In my view, using custom gradle file will keep the repository clean and readable as Android developers (who even have bare knowledge) will be able to understand the gradle file.
But if you feel, there might be a chance in future of conflict then take the call and close this MR. We can revisit this in the future if needed.

Thanks @dpa99c 😄

@sagrawal31  No worries - I had another look at this and decided your approach is less fragile than those hook scripts. If any issues arise due to the extra Gradle config, we'll tackle them as they come up.
I'm back from vacation/moving house now so I'll try to address the outstanding issues and do a new patch release in the next few days.

I'm glad our thoughts are in sync. 👍
By the way, I'm also back from vacation/moving to a new house.


Attack on Titan PC

This game (attack on titan) has awful deadzone defaults an no options so I gave this Durazno software a try but I can't seem to get it working.
It is a x64 game so I'm using the x64 xinput1_3.dll (of course I tried the 32 bit as well).  I also tried all the other names.  But I think it's xinput1_3.dll because Durazno log says this:
= Durazno Log Opened =
DllMain: DLL_PROCESS_ATTACH
XInputLoadLibrary: C:\WINDOWS\system32\xinput1_3.dll
XInputGetProc: XInputGetStateEx
So it seems to be detecting the file but the settings I do make no difference in the game.
I followed the link in the readme to the x360ce wiki; game is brand new so no listing there.  (By the way, you need to update the URL in the readme to https://github.com/x360ce/x360ce/wiki/Compatibility-List)
Anyway I think I might need to do the hookmask thing they mention on that page but I have no idea how to do this in Durazno:

HookLL
Many XACT games (that is, the Xbox360/PC cross platform games) require HookLL to run properly. As they do not load the xinput runtime directly, Dinput8 wrapper is required to redirect back to the local X360CE binary instead of loading the default xinput1/9_x binary.

If you got the log then it's correctly in place, there's no hooking in Durazno though it's a simple wrapper. You might wanna try with XInput Plus.

Thanks bro I'll try the program.  Is it only in Japanese?
On Aug 27, 2016 11:18 AM, "KrossX"<EMAIL_ADDRESS>wrote:

If you got the log then it's correctly in place, there's no hooking in
Durazno though it's a simple wrapper. You might wanna try with XInput Plus
https://sites.google.com/site/0dd14lab/xinput-plus.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/KrossX/Durazno/issues/17#issuecomment-242923066, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AQbV0y0nGcX7oLs0DMycLle5zNaJXZRJks5qkFVggaJpZM4Jur98
.

It does work in english too if I remember correctly.

Yeah it worked thanks


Create visual-metronome-extended plugin.

Adds functionality similar to the visual-metronome plugin that lets you configure and switch between different tick cycles with a hotkey.
https://user-images.githubusercontent.com/107812648/174500100-194cb182-0490-4f7c-a0fc-afec935729a5.mp4

This should probably just be an edit to the existing visual-metronome plugin, instead of a brand new plugin that essentially copies it.

I looked into making these changes to the existing plugin but it looked like it would be a little messy vs a simplified version with just the functionality I needed.
Feel free to close this PR if you want and I can reach out to the existing plugin's maintainer to see if we can work something out.

We'd appreciate at least reaching out to them and seeing if they would like to incorporate these changes instead of having a second plugin doing nearly the same thing. @vincent0955

I looked into making these changes to the existing plugin but it looked like it would be a little messy vs a simplified version with just the functionality I needed.
Feel free to close this PR if you want and I can reach out to the existing plugin's maintainer to see if we can work something out.

hey, some people asked and were looking forward to this feature, idk if you still wanna work something out. But if you want to make a pull request ill merge it, or if not then I'll try to implement it.

Closing due to inactivity.


Change Date columns types to Datetime

Context
Since updating the last_cached column to have the type timestamp so that we could store more precise times, we should update the rest of the date columns to timestamp as well for more uniformity
The only column that comes to mind that should be updated is broken_source_url_as_of but there may be others
Requirements

Any columns utilizing the date type should be updated to timestamp
On the application side, formatting should be updated to accept the time portion of timestamp in addition to the date
We should also be able to streamline the following if-elif statement from utilities/common.py:

if key == "last_cached" and value is not None:
    data_dict[key] = value.strftime("%Y-%m-%d %H:%M:%S")
elif isinstance(value, datetime.date):
    data_dict[key] = value.strftime("%Y-%m-%d")

Tests

Existing tests should point to any problems when updating particular columns to a new type

would dates without a time just be set to 00:00:00 in a migration? Do we need to change anything upstream in Airtable/

would dates without a time just be set to 00:00:00 in a migration?
Yes! Dates are automatically set to 00:00:00 when converted to timestamp
Do we need to change anything upstream in Airtable?
I imagine eventually, once we merge the v2 database with Airtable (assuming I'm thinking about this correctly)

I just went and scanned through our various database tables, and we have successfully taken care of this!


Decaffeinate apm cli spec

The "successor" of https://github.com/pulsar-edit/ppm/pull/20 with a little twist: semicolons added and template strings preserved.
It's easier to run a diff in e.g VSCode, it maps the lines better.

Light approval.
The code here looks solid. Some great decaf work opting for implicit functions rather than anonymous ones. Otherwise the other changes found don't seem of extreme significance, but mainly focusing on readability.
Other than waiting for tests to complete, this should be good to do.

Thank you for the feedback.
Honestly, I don't know the API very well, this expect, for example. If you could give me some pointers what further changes you'd like to see, I can dive deeper into it.

@2colours
So for expect and it and things like beforeEach, beforeAll and that sort of thing you'll find in the spec files are all globals of jasmine.
Which is the testing framework listed here.
I'd love to link directly to some docs, but part of the hard thing is it looks like the Jasmine used in much of Atom's stuff was forked from a fork from a fork, ad nauseam. So means the docs aren't super clear.
But for understanding the basic principles, and the general syntax patterns we would expect feel free to look at their docs


How to install [Comfyui-3D] missing node types? I am trying to use the Animate Anyone workflow but keep on getting these errors

These are the errors I'm getting after installing all the missing custom nodes for Anyone Anyone https://github.com/MrForExample/ComfyUI-AnimateAnyone-Evolved
" When loading the graph, the following node types were not found:
[ComfyUI-3D] Animate Anyone Sampler
[ComfyUI-3D] Load UNet2D ConditionModel
[ComfyUI-3D] Load UNet3D ConditionModel
[ComfyUI-3D] Pose Guider Encode
[ComfyUI-3D] Load Pose Guider
Nodes that have failed to load will show as red on the graph. "
Anyone have a solution for this? I'm on cuda version 11.7, windows 11. Fresh install of comfyui as well

run requirements command again. Make sure to save the models or you'll lose them.

I'm having the exact same issue, I tried running requirements command and succeeded but it still will not work for me on comfy ui

if you are still having this issue see below. worked for me. found at https://openart.ai/workflows/TtH6TaVEU5qv8WTLKDE8
When loading the graph, the following node types were not found:
[ComfyUI-3D] Animate Anyone Sampler
ImageCASharpening+
[ComfyUI-3D] Load UNet2D ConditionModel
[ComfyUI-3D] Load UNet3D ConditionModel
[ComfyUI-3D] Pose Guider Encode
[ComfyUI-3D] Load Pose Guider
ImageCrop+Nodes that have failed to load will show as red on the graph.
Solution: rebuild the nodes

double click on canvas and search for "guider", you will find
these
 - Pose Guider Encode

 - Load Pose Guider

double click on canvas and search for "unet", you will find

these
-Load UNet2D ConditionModel
-Load UNet3D ConditionModel

double click on canvas and search for "animate", you will find
 - Animate Anyone Sampler

connect the red(failed nodes) to the new one and delete the old ones


Add Smarty language

When will this be merged?

@vkbansal When @LeaVerou will have time to review it.

I’m a bit uncomfortable with the whole replacing content with __SMARTYXXX___ tokens and then adding content back etc, but whatevs, better to have an imperfect language definition than none at all.


Feature/pratyush1718/navbar

Tracking Info
Resolves #3
Changes
Add a bottom nav bar component per figma designs. Also added stack navigation for different button clicks on the nav bar.
Testing
Tested using android emulator, ss below

TODO

Alright linter issues and package.json/package-lock.json merge conflict are all taken care of, so this concludes my commits to the branch as of now.


M3-5795: Phone Verification Component

📝 Description

Adds the phone verification component to the Login & Authentication page
Allows users to verify a phone number and edit it
Adds libphonenumber-js package to both manager and @linode/validation for phone number validation and parsing

🧪 How to test

Turn on the MSW to test the flow
Try adding a phone number to your account at /profile/auth

@HanaXu leaving flag in that order because it will match login. Also will not autofocus because it creates extra accessibility complexity and issues for users who have no verified phone number when they visit the page


Dev server doesn't work with nitro: false option

Environment

Operating System: Darwin
Node Version:     v18.15.0
Nuxt Version:     2.17.0
Nitro Version:    2.5.1
Package Manager<EMAIL_ADDRESS>Builder:          webpack
User Config:      head, css, plugins, components, buildModules, modules, axios, build, bridge, serverHandlers, devServerHandlers, devServer, typescript, nitro
Runtime Modules<EMAIL_ADDRESS>Build Modules<EMAIL_ADDRESS>
Reproduction
https://github.com/deleteme/nuxt2-bridge-nitro-bug
Describe the bug
The nuxi dev command starts a local development server.
Nuxt Bridge has a nitro option, described as "Use legacy server instead of Nitro". When Nitro is disabled with nitro: false, this dev server is broken.
Demo of the bug
Also notice that initially during building, "Nuxt 2.17.0 with Nitro 2.5.1" momentarily appears at the top of the output. The "with Nitro" part is unexpected and suggests that the nitro: false config option isn't working correctly.
https://github.com/nuxt/bridge/assets/9389/8cd9c10f-c95f-474a-a951-1cac31085869
Additional context
This reproduction git repository contains a fresh Nuxt 2 project via (yarn create nuxt-app), with Nuxt Bridge being the only additional package.
This bug was encountered while evaluating Nuxt Bridge. I wanted to know if Nuxt Bridge works (or what parts of it work) in a brand new Nuxt 2 app to determine if it's suitable for use in the migration of a large Nuxt 2 app to Nuxt 3.
Logs
After running `yarn dev`:

✔ Client
  Compiled successfully in 1.84s

✔ Server
  Compiled successfully in 1.61s
ℹ Waiting for file changes

When making a request to localhost:3000:
 ERROR  [unhandledRejection] Cannot read properties of undefined (reading 'onError')

  at toNodeHandle (node_modules/nuxi/dist/chunks/index2.mjs:498:23)
  at Server.serverHandler (node_modules/nuxi/dist/chunks/dev.mjs:118:31)
  at Server.emit (node:events:525:35)
  at Server.emit (node:domain:489:12)
  at parserOnIncoming (node:_http_server:1072:12)
  at HTTPParser.parserOnHeadersComplete (node:_http_common:119:17)

This isn't a bug, it was a misunderstanding of how to use the option.
In addition to changing the Nuxt config to have nitro: false, the original nuxt script tasks in package.json need to be restored so that nuxi is no longer called.
https://github.com/nuxt/bridge/pull/835


Soil moisture estimation

Looking for high resolution soil moisture estimation and downscaling algorithm

Hi @asniyori, Earth Engine has a couple soil moisture datasets:

SMAP L3 Radiometer Global Daily 9 km Soil Moisture
SMAP L4 Global 3-hourly 9-km Surface and Root Zone Soil Moisture

They are 9km, so not high resolution, however. I'm not sure about whether there are established methods for downscaling these data.

👍


Cf/Org/Space filters are not updating on endpoint change

Requires a bit more testing, but seen when..

have connected endpoint, visit pages with filters on
delete endpoint
add another endpoint with a different name
revisit pages with filters on and the old endpoint is still shown

No longer an issue, see src/frontend/app/store/reducers/pagination-reducer/pagination-reducer-clear-pagination-type.ts


SLIM-1475 Updates HLS 5 connection tests to verify IC increments

When communicating with HLS 5, the invocation counter stored with the
E-meter encryption key should be incremented. While this should be done
with an amount of the number of times the key has been used to encrypt
data, the tests only verify for any increment.

retest this please


ZEPPELIN-3111. Refactor SparkInterpreter

What is this PR for?
This is for the refactoring of SparkInterpreter. See design doc. https://docs.google.com/document/d/1AfGg3aGXonDyri1jrP4MMFT4Y4j3wpN1t8kL-GAKSUc/edit?usp=sharing
What type of PR is it?
[Refactoring]
Todos

[ ] - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-3111

How should this be tested?

Unit test is added.

Screenshots (if appropriate)
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

Thanks @Leemoonsoo , will merge it if no more comments

In this PR a change was made to bin/interpreter.sh script. In line 124 SPARK_APP_JAR="$(ls ${ZEPPELIN_HOME}/interpreter/spark/spark-interpreter*.jar)" used to be SPARK_APP_JAR="$(ls ${ZEPPELIN_HOME}/interpreter/spark/zeppelin-spark*.jar)"
This change was not updated in bin/interpreter.cmd, meaning that spark interpreter fails in windows.

Thanks @alonshoham  feel free to create a PR for that.

@alonshoham Sorry I didn't notice you created the ticket, I have fixed via this commit, https://github.com/apache/zeppelin/commit/8b2f4a7bd89aa69661e09ef9ad73c04d862029ff
Could you help verity it ?

Your commit looks OK.
Notice that I mentioned another problem in the ticket with interpreter.cmd
On Wed, Oct 3, 2018 at 9:55 AM Jeff Zhang<EMAIL_ADDRESS>wrote:

@alonshoham https://github.com/alonshoham Sorry I didn't notice you
created the ticket, I have fixed via this commit, 8b2f4a7
https://github.com/apache/zeppelin/commit/8b2f4a7bd89aa69661e09ef9ad73c04d862029ff
Could you help verify it ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/zeppelin/pull/2709#issuecomment-426530737, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AP-5fM7nTPBvjF0z939KUeSGV9T73Ui3ks5uhF90gaJpZM4RG0hm
.


License for the codebase

This codebase has no license. It would be great if could you add a license.  Almost all source code files have a license, but not all of the source code files, unfortunately. It may be easier if in addition to the individual copyrights/licenses you have a central license file that includes all existing licenses and clarifies what license applies to the rest.

Sorry for missing License, I have updated it. :)

Let’s see if there are any other issues about license now. All the code and weights are available for everyone to use freely. I’m also preparing to train some larger models, like 2.8B and 7B, if that would be beneficial for the open-source community. Thanks for your remainder!


 Upgrade hapi Fhir version to 7.0.0

Description of what I changed

Upgraded HAPI FHIR Version to 7.0.0
Made the property name hapi.fhir.version to be same in both bunsen/pom.xml and pipelines/pom.xml files, so that dependabot upgrades the version in both the files simultaneously.
Added a dependency hapi-fhir-caching-caffeine, this was mandatory otherwise there was this below error being thrown

java.lang.RuntimeException: HAPI-2200: No Cache Service Providers found. Choose between hapi-fhir-caching-caffeine (Default) and hapi-fhir-caching-guava (Android)

	at ca.uhn.fhir.sl.cache.CacheFactory.getCacheProvider(CacheFactory.java:41)
	at ca.uhn.fhir.sl.cache.CacheFactory.build(CacheFactory.java:46)
	at org.hl7.fhir.r4.hapi.ctx.HapiWorkerContext.<init>(HapiWorkerContext.java:65)
	at org.hl7.fhir.r4.hapi.fluentpath.FhirPathR4.<init>(FhirPathR4.java:31)
	at com.google.fhir.analytics.view.ViewApplicator.<init>(ViewApplicator.java:66)
	at com.google.fhir.analytics.view.ViewApplicatorTest.applyViewOnResource(ViewApplicatorTest.java:72)
	at com.google.fhir.analytics.view.ViewApplicatorTest.emptyForEachOrNullWithUnion(ViewApplicatorTest.java:103)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

E2E test

TESTED:
Please replace this with a description of how you tested your PR beyond the
automated e2e/unit tests.
Checklist: I completed these to help reviewers :)

[x] I have read and will follow the review process.

[x] I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.

[ ] My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.

[ ] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)

[x] I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.

[ ] All new and existing tests passed.

[x] My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command git pull --rebase upstream master

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (master@ba2ccd8). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #971   +/-   ##
=========================================
  Coverage          ?   50.44%
  Complexity        ?      673
=========================================
  Files             ?       91
  Lines             ?     5519
  Branches          ?      709
=========================================
  Hits              ?     2784
  Misses            ?     2473
  Partials          ?      262

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Hi @bashir2, this PR is ready for review, it contains changes for upgrading the HAPI library to 7.0.0

Thanks @bashir2 for the review. I have addressed the review comments, will merge the changes once the build completes.


typos

Description

Web App -> Blazor -> Component (should be a component)There are typos in this tab

Page URL
https://learn.microsoft.com/en-us/aspnet/core/blazor/components/?view=aspnetcore-8.0
Content source URL
https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/blazor/components/index.md
Document ID
31ad18df-1904-bbdd-cfed-8d0d0267c10e
Article author
@guardrex

It isn't clear what this feedback refers to. If the feedback is that they want singular ToC entry names, we'll stick with what we have.


[CodeCompletion] Let FindLocalVal walk into ExprPattern

Some conditions in control flow statements are parsed as expression patterns, then resolved to "pattern"s later in Sema. In code completion, they might not be type checked at all. Previously, when collecting visible declarations for completion candidates, it didn't walk into ExprPattern, and thus it didn't find the variables inside. Use standard Pattern::forEachVariable() that looks into ExprPattern instead of using its custom recursive logic.
rdar://86050684

@swift-ci Please smoke test

@swift-ci Please smoke test

Nice cleanup!


Migrate FAQ and misc content to ops section

This change migrates the traffic-management FAQ
and the network related misc (previously troubleshooting)
content to the traffic-management ops guide

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: john-a-joyce
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sdake
If they are not already assigned, you can assign the PR to them by writing /assign @sdake in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Deploy preview for preliminary-istio failed.
Built with commit 25a87ee7e84d4d5221b311f5aa19c15bcf41fc59
https://app.netlify.com/sites/preliminary-istio/deploys/5b5f1ec8c6aed67258a21f54

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: john-a-joyce, sdake
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content/OWNERS [sdake]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


fix(utils): event listener patches break when passed an object implementing EventListener

Per https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener:
listener
The object that receives a notification when an event of the specified type occurs.
This must be an object implementing the EventListener interface, or simply a JavaScript function.

where EventListener is:
void handleEvent(
  in Event event
);

At present, zonejs breaks if a patched addEventListener is passed an object with a handleEvent method, because zone.bind is called on the handler, which it of course expects to be a function.

@vicb, @btford: can someone take a look at this please?

@matthewjh could you please add tests for adding / removing listeners ?

@vicb I had trouble finding where to put the tests for this but I think I've got it now (zone.js/test/patch/element.spec.js). Will push some tests today. :)

@vicb Done tests. Can you take another look please?
Cheers, Matt.

lgtm with a few comments

:+1: Thanks for your comments, Victor. I've addressed them all.
@vicb

Done. No problem.
@vicb

landed as af88ff8a01c1d5b445eeb212569dde5a88c8e509
Thanks !


Empty post request fails

When trying to send post request without any fields i get error
Caused by: java.lang.IllegalArgumentException: method POST must have a request body.
            at com.squareup.okhttp.Request$Builder.method(Request.java:236)
            at retrofit.client.OkClient.createRequest(OkClient.java:59)
            at retrofit.client.OkClient.execute(OkClient.java:53)

Thisi s known issue since okhttp 2.4 and was supposed to bi fixed in 2.5 (but isn't)
My fast and nasy workaround in OkKttpStack.java was
if (postBody == null) {
    builder.post(RequestBody.create(MediaType.parse(request.getBodyContentType()), ""));
} else {
    builder.post(RequestBody.create(MediaType.parse(request.getBodyContentType()), postBody));
}

Ok I will try to workaround it.

#8 fix it