use the new feature of the crc crate for more throughput in sctp

The crc crate has released finally released a new version featuring an improved algorithm that greatly increases performance. The new algorithm uses a few Kb more of lookup tables which is why it has to be enabled explicitly. This PR bumps the version of the crc crate to the required level and enables that new algorithm.
Crc performance is a significant bottleneck in the sctp throughput as showcased by the throughput example:
Before:
Throughput: 67238910 Bytes/s, 1026 pkts, 1026 loops
Send 1031 pkts
Throughput: 68025330 Bytes/s, 1038 pkts, 1038 loops
Send 1038 pkts
Throughput: 68484075 Bytes/s, 1045 pkts, 1045 loops
Send 1049 pkts
Throughput: 68353005 Bytes/s, 1043 pkts, 1043 loops
Send 1046 pkts
Throughput: 68746215 Bytes/s, 1049 pkts, 1049 loops
Send 1050 pkts
Throughput: 67632120 Bytes/s, 1032 pkts, 1032 loops
Send 1037 pkts

After:
Throughput: 85523175 Bytes/s, 1305 pkts, 1305 loops
Send 1311 pkts
Throughput: 86768340 Bytes/s, 1324 pkts, 1324 loops
Send 1325 pkts
Throughput: 86899410 Bytes/s, 1326 pkts, 1326 loops
Send 1328 pkts
Throughput: 86440665 Bytes/s, 1319 pkts, 1319 loops
Send 1319 pkts
Throughput: 86637270 Bytes/s, 1322 pkts, 1322 loops
Send 1323 pkts
Throughput: 86899410 Bytes/s, 1326 pkts, 1326 loops
Send 1328 pkts

Edit: About the formatting CI: I can only reproduce one of the two fixes locally, but that one isn't related to this PR. The one related to this PR I can't reproduce locally (cargo fmt just doesn't produce this output for me...?!)
Do you want me to fix these two? I'd be glad to do it but I don't want to clutter the PR either

please fix cargo fmt check


:py3 command does not work in macvim launching from dock

Describe the bug
:py3 command works correctly in mvim which launches from terminal, but does not work in mvim launching from dock.
To Reproduce
Detailed steps to reproduce the behavior:

launch macvim from dock
:py3 import subprocess
:py3 print( subprocess.Popen('rg ""', shell=True, stdout=subprocess.PIPE).stdout.read() )
show nothing

Expected behavior

launch macvim from terminal
:py3 import subprocess
:py3 print( subprocess.Popen('rg ""', shell=True, stdout=subprocess.PIPE).stdout.read() )
show the rg output lines

Screenshots
The wrong one:

The correct one:

Environment (please complete the following information):
Vim version:

OS: [e.g. Ubuntu 18.04, Windows 10 1809, macOS 10.14]

Additional context
I installed macvim by brew cask install macvim

➜  ~ /Applications/MacVim.app/Contents/bin/vim  --version
VIM - Vi IMproved 8.1 (2018 May 18, compiled Oct 30 2019 11:57:56)
macOS version
Included patches: 1-2234
Compiled by<EMAIL_ADDRESS>Huge version with MacVim GUI.  Features included (+) or not (-):
+acl               +file_in_path      +mouse_urxvt       -tcl
+arabic            +find_in_path      +mouse_xterm       +termguicolors
+autocmd           +float             +multi_byte        +terminal
+autochdir         +folding           +multi_lang        +terminfo
-autoservername    -footer            -mzscheme          +termresponse
+balloon_eval      +fork()            +netbeans_intg     +textobjects
+balloon_eval_term +fullscreen        +num64             +textprop
+browse            -gettext           +odbeditor         +timers
++builtin_terms    -hangul_input      +packages          +title
+byte_offset       +iconv             +path_extra        +toolbar
+channel           +insert_expand     +perl/dyn          +transparency
+cindent           +job               +persistent_undo   +user_commands
+clientserver      +jumplist          +postscript        +vartabs
+clipboard         +keymap            +printer           +vertsplit
+cmdline_compl     +lambda            +profile           +virtualedit
+cmdline_hist      +langmap           +python/dyn        +visual
+cmdline_info      +libcall           +python3/dyn       +visualextra
+comments          +linebreak         +quickfix          +viminfo
+conceal           +lispindent        +reltime           +vreplace
+cryptv            +listcmds          +rightleft         +wildignore
+cscope            +localmap          +ruby/dyn          +wildmenu
+cursorbind        +lua/dyn           +scrollbind        +windows
+cursorshape       +menu              +signs             +writebackup
+dialog_con_gui    +mksession         +smartindent       -X11
+diff              +modify_fname      -sound             -xfontset
+digraphs          +mouse             +spell             +xim
+dnd               +mouseshape        +startuptime       -xpm
-ebcdic            +mouse_dec         +statusline        -xsmp
+emacs_tags        -mouse_gpm         -sun_workshop      -xterm_clipboard
+eval              -mouse_jsbterm     +syntax            -xterm_save
+ex_extra          +mouse_netterm     +tag_binary
+extra_search      +mouse_sgr         -tag_old_static
-farsi             -mouse_sysmouse    -tag_any_white
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
  system gvimrc file: "$VIM/gvimrc"
    user gvimrc file: "$HOME/.gvimrc"
2nd user gvimrc file: "~/.vim/gvimrc"
       defaults file: "$VIMRUNTIME/defaults.vim"
    system menu file: "$VIMRUNTIME/menu.vim"
  fall-back for $VIM: "/Applications/MacVim.app/Contents/Resources/vim"
Compilation: clang -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_MACVIM -Wall -Wno-unknown-pragmas -pipe  -DMACOS_X -DMACOS_X_DARWIN  -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: clang   -L. -fstack-protector-strong -L/usr/local/lib -L/usr/local/opt/libyaml/lib<EMAIL_ADDRESS>-L/usr/local/opt/readline/lib -L. -fstack-protector-strong -L/usr/local/lib -L/usr/local/opt/libyaml/lib<EMAIL_ADDRESS>-L/usr/local/opt/readline/lib  -L/usr/local/lib -o Vim -framework Cocoa -framework Carbon       -lm  -lncurses -liconv -framework AppKit   -fstack-protector  -L/System/Library/Perl/5.18/darwin-thread-multi-2level/CORE

brew install macvim also doesn't work properly

@hujianxin Thank you for an issue,
Could you check PATH environment variable in ViM while run from terminal and from dock. I suspect that values are different.
If this is a case, you can alter /etc/paths and/or /etc/paths.d to make your py3 in PATH. This is likely not a bug, but difference in values of environment variables.

Could you ensure, that rg program is in your PATH in both cases? You can do it by :echo $PATH in MacVim and if not, edit /etc/paths and/or /etc/paths.d, then login-logout

Hi, I can ensure rg is in PATH.

Could you print out the $PATH from py3 as you run the command from there?

Sure!
:py3 print(os.environ[PATH'] )

@eirnym

Have you checked both runs, from terminal and from dock?

Yes, I have checked the following situations

terminal macvim: works
terminal nvim: works
vimr(gui nvim) lanched from dock: works
macvim launched from terminal: works
macvim launched from doc: not work

And, not just I met this issue, other guy met it either.

Actually, I'm using LeaderF extension which privides Fuzzy file finding function like FZF. this extenssion does not work in macvim launched from dock. So I checked py3 print( subprocess.Popen('rg ""', shell=True, stdout=subprocess.PIPE).stdout.read() ) , and found something different macvim launched from terminal and launched from dock.

I use this extension as well, but in most cases launch MacVim from terminal.
now when I run MacVim from dock:

rg '' | cat in terminal works as expected
:!rg '' works as expected
if I execute subprocess.Popen('rg ""', shell=True, stdout=subprocess.PIPE).stdout.read()) it will fail as it requires stderr
if I execute  subprocess.Popen('rg ""', shell=True, stdout=subprocess.PIPE, stderr=subprocess.PIPE).stdout.read()) it will exit with no errors and no output. Probably some environment variables or path or .... I don't know
if I pass incorrect folder or a folder explicitly, everything works fine as expected.

after a bit of searching and practicing to run it, I've found that  this pattern of rg usage is involved: command | rg [OPTIONS] PATTERN. Basically, rg sees that your input is an empty buffer (NOT closed and NOT terminal), so it thinks, that your want to grep the output of previous command which is an empty buffer as it is closed at the beginning when MacVim is running (and most others macOS apps) and subprocess just passes it to rg as it was.
the : passes the stdin as terminal (even a dummy one), so rg works as you expect it.

You can reproduce it with a simple program, where if stdin is not closed, it will print out a lot of output:
import sys
import subprocess

sys.stdin.close()
print(subprocess.Popen(
    "rg '.*'",
    shell=True,
    cwd='/bin/',
    stderr=subprocess.PIPE,
    stdout=subprocess.PIPE,
    stdin=subprocess.DEVNULL)
      .communicate())

I have the same issue. The fix was to add to my vimrc:
set pythonthreedll=/usr/local/Cellar/python/3.7.6_1/Frameworks/Python.framework/Versions/3.7/Python
set pythonthreehome=/usr/local/Cellar/python/3.7.6_1/Frameworks/Python.framework/Versions/3.7/

What version are you using @RStankov ? If you are using the latest version (165), you should use 3.8 instead. MacVim will automatically use the right python DLLs if that's the case.

I'm on latest 165, this was the Python, I had 🤷♂
Will download 3.8 to see if this will be needed. Thanks :)

Yeah the way Vim works with Python / other scripting languages is by linking against specific libraries. You could technically provide Python 3.7 to Vim by doing what you did in https://github.com/macvim-dev/macvim/issues/1003#issuecomment-674527401 by modifying pythonthreedll, but it could lead to subtle bugs as the API could have changed in small ways, and as such it's ideal to use the same Python version that Vim is linked against.

@ychin  tanks for clarification.

@hujianxin @RStankov Could you tell if this is still an issue for you?

@eirnym It isn't an issue anymore. Seems to be working

@eirnym I still have this issue.

I see, it works as expected, but stdin is still open for some reason with no input. You should add stdin=subprocess.DEVNULL if you want it to work more portable.
I can't find any information in documentation for ViM, that for :py3 (or any other language) stdin is closed. More, that in ViM's documentation, it's stated, that input is not supported could lead even to crash:
							*python-input*
	Input (via sys.stdin, including input() and raw_input()) is not
	supported, and may cause the program to crash.  This should probably be
	fixed.
`

Therefore, I threat MacVim's behaviour as a fix for a problem with python input rather than "py3 is not working"

Sorry I haven't been following this issue too much, but after reading up on it and testing it out I agree with @eirnym that you should probably just add stdin=subprocess.DEVNULL to the subprocess call. It's not clear where stdin should come from anyway, and per the documentation it's not really a supported feature.
Also, from playing around with it, when you launch subprocess this way, the stdin that you are using is actually from the terminal. This seems… not ideal because that means the Python code is using your terminal stdin that MacVim is inheriting from. I will probably fix this in the future so even terminal-launched MacVim will not work.'
@hujianxin can you just ask LeaderF to fix their subprocess call to pass a null stdin?
I'm also not sure why VimR works. It may just make a dummy stdin.

Issue has been fixed in the LeaderF.


[native_assets_builder] Fix flaky test

Hopefully fixes https://github.com/dart-lang/native/issues/1810.

coverage: 87.97%. remained the same
when pulling 98c535c22fae72f49aa17343511eb79569f436a5 on fix-flake
into f7af11e48f1dd196194702fd7003a28724d2845c on main.


Native browser tooltip for title shows on first keyboard focus in IE/Edge (in addition to Bootstrap's custom tooltip)

IE11 and Microsoft Edge show a native tooltip for focusable elements with a title attribute when focused with the keyboard (while other browsers generally only show the native tooltip when hovering with the mouse). Bootstrap's tooltips blank out the title attribute on when they're focused/hovered, but not fast enough for IE11/Edge not to see them and trigger the native tooltip, meaning that when navigating with the keyboard in IE11/Edge, the first time an element with a tooltip is focused, both the native tooltip and the bootstrap tooltip are shown simultaneously. If the user focuses another element and then returns to this element, no native tooltip is shown (as by that point the title is empty).

(note that in this screenshot, a special red focus outline was forced using a custom stylesheet, for clarity)
Likely solution would be to blank the title out directly when they're initialised, rather than relying on this to happen when they're first focused/hovered.

Isn't it arguably a bug that IE11/Edge doesn't close the native tooltip when the title attribute is modified?

It's more of a race condition, I'd say. IE11/Edge are just a tad quicker at displaying the native tooltip before the attribute is blanked. Once a native tooltip is shown, I don't think (though I'd have to test if necessary) any browser modifies it "live" if the attribute itself is changed.

As tooltips are opt-in and require an explicit script initialisation anyway, it shouldn't be a problem blanking the title as part of the step though, i think.

Unless I'm mistaken, the source of the problem is
      if (this.config.selector) {
        this.config = $.extend({}, this.config, {
          trigger  : 'manual',
          selector : ''
        })
      } else {
        this._fixTitle()
      }
    }

which, if I understand it correctly, only runs _fixTitle() if there was no explicit selector given on initialisation. Taking the docs as an example, we do have a selector, but the elements do also have an actual title. Wonder if _fixTitle() should be run regardless of selector...worst case, it may simply run and produce no result?

As tooltips are opt-in and require an explicit script initialisation anyway, it shouldn't be a problem blanking the title as part of the step though, i think.

It wouldn't work in event delegation cases (unless we started using mutation observers/events), because some tooltipped elements might not yet exist at the time of the explicit initialization call.

Wonder if the advice for those cases should be to go straight for using data-original-title instead of title. But yeh, fair enough. Still wouldn't call IE11/Edge behavior a bug as such, just a difference in implementation which we can't currently account for.

Closed via #19434


Add a helm chart

What this PR does / why we need it:
It is currently pretty complicated to rollout the service. This PR adds a helm chart to easily deploy the oidc-webhook-authenticator.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you @iss0 for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.


Fetch the public PRs of a user

Remove the api folder
Fetch the public PRs of the user and display it

@bipulthapa Let's delete the yarn-error.log file and put it in .gitignore


Cannot open node.lib

I'm trying to install this: https://github.com/pagarme/node-rsa-keygen

I opened the cmd in administrator mode, same problem. Node.lib is there but node-gyp can't open it? It is like MSBUILD problem no?

I reinstalled node-gyp with node-gyp-install and it solved the issue. Please note I removed .node-gyp directory first from C:/Users/user_name/


Content settings not available for Norway

I cannot find the Content Settings described under Step 3. Is this available for customers in Norway?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a9cfd814-0551-a1c9-1001-0bdf2a028c6b
Version Independent ID: d6ee9a96-33f1-0dcb-5bb7-f5695a3a1987
Content: Quick set up for Microsoft Search
Content Source: MicrosoftSearch/quick-set-up.md
Service: mssearch
GitHub Login: @dawholl
Microsoft Alias: dawholl

Hi, thank you for your feedback. Please see the updated content available at:
https://docs.microsoft.com/en-us/microsoftsearch/

The link posted by you loads a marketing page about search. Don’t see any changes to the original article. Is this Content Setting page available for customers in Norway? I still don’t see it. The article is misleading.

Sorry for the confusion, but that is the landing page for support content on docs.microsoft.com. That's where we keep all of our ITPro and Admin help content.
https://docs.microsoft.com/en-us/microsoftsearch/setup-microsoft-search <-- Here's the direct link to the new set up content. We moved the Microsoft Search in Bing portal to the Microsoft 365 admin center and the content is completely different. Again, sorry for any confusion.


Tweak Wagtail logo hover animation in docs

I think our little pet Wagtail logo bobs down too slow when you hover it, so I made it behave exactly as in the Wagtail admin (without the "playful" mode of course).
Also, isn't the "pet the wagtail" action on the Wagtail admin logo an Easter egg?

@acarasimon96 thanks for the tweak, merged in.
I think its nice to have a bit of an animation on the docs also, also serves as a visual hover state of an interactive element :)


An official release to ease packaging

We are using SDL_gpu successfully and the library seems pretty stable. Would you be opposed to doing an official release, maybe even with the version number 1.0?
My team is currently creating distribution packages for SDL_gpu for NixOS, Arch and Gentoo and it's kind of a hassle with the git version.

I'm not opposed at all.  My schedule for this summer is just not predictable.
I'd like to set up a schedule for autopackaging a source bundle for regular releases.  Getting to v1.0 is part of my plan for this coming academic year, as I'll have some time/funding to work with, too.  If I get some time before then, I'll follow up on this issue.

Ah, that sounds truly excellent. Shall I close the issue, or keep it open as a reminder?

Let's keep it open and I'll verify with you that the solution meets your needs before closing.


Baby's first edit

OPS Build status updates of commit 8dfd43d:
:clock10: Preparing: average preparing time is not available, there is no data for this repository.

OPS Build status updates of commit 8dfd43d:
:clock10: Incremental building: average incremental building time is not available, there is no data for this repository.

OPS Build status updates of commit 8dfd43d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

enterprise-graph/TOC.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit c0bb2b6:
:clock10: Preparing: average preparing time is 35 sec(s)

OPS Build status updates of commit c0bb2b6:
:clock10: Incremental building: average incremental building time is 8 sec(s)

OPS Build status updates of commit c0bb2b6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

enterprise-graph/TOC.yml
:white_check_mark:Succeeded

enterprise-graph/index.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Payload mode run_command does not work.

Testing payload mode run_command did not work on a fresh install of DotNetNuke 07.03.04. I will submit a PR with a fix.

Thank you for the PR!


Recorder restore not working with PostgreSQL in 0.50.2

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
0.50.2
Python release (python3 --version):
Python 3.4.2
Component/platform:
recorder
Description of problem:
When using PostgreSQL as the backend DB, input_boolean values do not survive a restart.
Expected:
set value on an input_boolean variable then restart HA.  After HA comes back up, the UI should still have that same value.
Problem-relevant configuration.yaml entries and steps to reproduce:
history:
recorder:
  db_url: postgres://@/homeassistant
  purge_days: 3

Traceback (if applicable):

Additional info:

Same issue as here https://github.com/home-assistant/home-assistant/issues/7464


[Transforms] Capture "this" with "_this" when it doesn't need

Expected:
        function inner2() {
            var x = function () { return _super.sayHello.call(this); };
        }

Actual:
        function inner2() {
            var _this = this;
            var x = function () { return _super.sayHello.call(_this); };
        }

Failed tests:

tests\cases\compiler\superErrors.ts

Fix in latest commit

This is actually correctly emitted as x is declared using arrow function


⚠ Bofrost.be has degraded performance

In d08bc4d, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1951 ms

Resolved: Bofrost.be performance has improved in 678e6b5.


Add Image Validation

[x] Ensures all profile images are square, i.e. Image Height == Image Width
[x] Updates Validation Tool to .NET 5.0
[x] Fixes Profile Photo Naming

[x] Removed capitalization from Phoummala's profile image
[x] Removed capitalization from Pierre's  YAML

Docs Build status updates of commit c8d39e2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

validation/AdvocateValidation.csproj
:white_check_mark:Succeeded

validation/ImageService.cs
:white_check_mark:Succeeded

validation/Program.cs
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit ec4e281:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.github/workflows/VerifyAdvocateYAML.yml
:white_check_mark:Succeeded

validation/AdvocateValidation.csproj
:white_check_mark:Succeeded

validation/ImageService.cs
:white_check_mark:Succeeded

validation/Program.cs
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit e26a0ef:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.github/workflows/VerifyAdvocateYAML.yml
:white_check_mark:Succeeded

validation/AdvocateValidation.csproj
:white_check_mark:Succeeded

validation/ImageService.cs
:white_check_mark:Succeeded

validation/Program.cs
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 31ef506:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.github/workflows/VerifyAdvocateYAML.yml
:white_check_mark:Succeeded

advocates/media/profiles/phoummala-schmitt.png
:white_check_mark:Succeeded
View

advocates/media/profiles/pierre-roman.jpg
:white_check_mark:Succeeded
View

validation/AdvocateValidation.csproj
:white_check_mark:Succeeded

validation/ImageService.cs
:white_check_mark:Succeeded

validation/Program.cs
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit b1f536c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.github/workflows/VerifyAdvocateYAML.yml
:white_check_mark:Succeeded

advocates/media/profiles/phoummala-schmitt.png
:white_check_mark:Succeeded
View

advocates/media/profiles/pierre-roman.jpg
:white_check_mark:Succeeded
View

advocates/pierre-roman.yml
:white_check_mark:Succeeded
View

validation/AdvocateValidation.csproj
:white_check_mark:Succeeded

validation/ImageService.cs
:white_check_mark:Succeeded

validation/Program.cs
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

CC @MaximRouiller

Docs Build status updates of commit 821ed80:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.github/workflows/VerifyAdvocateYAML.yml
:white_check_mark:Succeeded

advocates/media/profiles/phoummala-schmitt.png
:white_check_mark:Succeeded
View

advocates/media/profiles/pierre-roman.jpg
:white_check_mark:Succeeded
View

advocates/pierre-roman.yml
:white_check_mark:Succeeded
View

validation/AdvocateValidation.csproj
:white_check_mark:Succeeded

validation/ImageService.cs
:white_check_mark:Succeeded

validation/Program.cs
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit c33b2c3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.github/workflows/VerifyAdvocateYAML.yml
:white_check_mark:Succeeded

advocates/media/profiles/phoummala-schmitt.png
:white_check_mark:Succeeded
View

advocates/media/profiles/pierre-roman.jpg
:white_check_mark:Succeeded
View

advocates/pierre-roman.yml
:white_check_mark:Succeeded
View

validation/AdvocateValidation.csproj
:white_check_mark:Succeeded

validation/ImageService.cs
:white_check_mark:Succeeded

validation/Program.cs
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Fixes #494


Adjust windows opacity?

Thanks for making this great software.
It's more modern, easy-to-use, and elegant than yabai.
The only thing preventing me from switching from yabai to aerospace is the ability to change a window's opacity.
I'm uncertain whether this aligns with the objectives of aerospace.

See

https://github.com/nikitabobko/AeroSpace/issues/330
https://github.com/nikitabobko/AeroSpace/issues/452


Read .publicodes.yaml files same as .publicodes

Hello,
We renamed all .publicodes rules files to .publicodes.yaml to be interoperable with my team which uses VS Code and others IDE as IntelliJ (Webstorm etc).
If the extension can understand .publicodes and .publicodes.yaml every developer will be happy :)

Hi, isn't it possible to configure Intellij IDEs to consider .publicodes files as YAML files? Otherwise, it seems fair to me to support .publicodes.yaml I'll look at it :)
(Did you manage to run the VSCode extension? What's your OS?)

Sure we can with IntelliJ but rules are plain YAML, I suppose the need for a custom extension is only for the VS Code extension. When we use "dumb" text editor (Vim, Emacs...) it guess the content by the extension and it's painfull to add a specific handling.


PDF to PDF redirection not working

Required Information

[ ] AEM Version, including Service Packs, Cumulative Fix Packs, etc:_AEM Cloud
[ ] ACS AEM Commons Version: 5.3.4 (also tried with 5.7.0)
[ ] Reproducible on Latest? yes

Expected Behavior
While using PDF to PDF redirection in Dev Environment. It should hit 308/307/302/301 as set redirection in MANAGE REDIRECT.
Actual Behavior
PDF to PDF redirection does not work in Dev environment. It is not hitting 308/307/302/301 as seen in the logs even when we try with the latest version of ACS Commons.
Steps to Reproduce

Set a PDF to PDF redirection in your environment ( preferably your DEV environment where we have a fully functioning Dispatcher)
Publish the redirection.
Use the redirection in PUBLISH.

Links
Not required

Sorry - can you detail what feature youre using? Is it Redirect Manager? If so, can you provide exactly the rule set you're using, and what the resulting response is?

There are non-obvious gotchas with respect to redirecting assets.

page redirects are typically organised by context, e.g. when user requests a page in /content/we-retail/* , Redirect Manager will lookup rules in /conf/we-retail

This is not the case with assets. DAM folders are not contextual and Redirect Manager will fallback to the default /conf/global configuration. This means you need to define your asset rules under /conf/global/* .

It's a good idea to flush the Dispatcher and CDN caches after activating redirects. Redirect Manager operates in AEM, i.e. the request needs to reach AEM to be evaluated.

Hi Yegor,
Thank you for the explanation. We were able to achieve the PDF to PDF/HTML redirections.
Regards,
Dhruv


Render to STDOUT

Sometimes it would useful to be able to render to stdout instead of having to create a file.

Hey @1fox1,
thank you for opening this issue.
I think it makes perfectly sense to have such a feature. Could be really useful when creating new aviator.yml files and to validate the results.
I added a --dry-run flag to aviator. It is global and will print any file that used to be written to a file to stdout instead. At the same time it omits any defined executor.
I will release a new version very soon (which will include this feature).

Hi @1fox1,
the new release is now available: https://github.com/JulzDiverse/aviator/releases/tag/v1.5.0

Thanks very much Julz.

I wanted to use the output in a pipe to a second command.
As the merge info as below is also rendered to stdout it is not possible.
I think it would cut down on the possible need for certain executors, for example I wanted to try this out https://get-kapp.io/ (its the deployment tool from ytt guys)
Sorry for not being clear in my request. --dry-run I didn't think of and is very useful.
`SPRUCE MERGE:
b.yml
a.yml
to: afile
RESULT:`


🐛 Bug ➾ typo 'udpate' in last step of NFT Scaffold.

🚥 Status (Internal Taqueria Team Use Only)

[ ] 🔬 Investigated and Verified
[ ] ⚗ Solution Identified and Designed
[ ] 🧫 Dev Implementation of Fix
[ ] 🧪 Fix Tested and Validated
[ ] 🏆 PR Merged

🆘 What happened?
found a typo in the console log running apply in the NFT Scaffold
🆘 Steps to Reproduce?

taq scaffold https://github.com/ecadlabs/taqueria-scaffold-nft nft-scaffold
cd nft-scaffold
npm run setup
cd taqueria
touch .env
Get your Pinata JWT token from your Pinata account
Insert the JWT from Pinata into the .env file echo “pinataJwtToken=eyJhbGc…” >> .env
cd …
npm run start:taqueria:local
npm run apply
observe the last step of the console log says 'udpate' instead of the more usual 'update'.

🪵 Relevant log output
No response
🐘 How impactful is this bug?
🐜 Minor annoyance
⏱ Prevalance
everytime
💻 Operating System
Windows -> Linux VM
🕸 System Architecture
x64
🌮 Taqueria Version
v0.22.0
🌿 Node.js Version
v18.4.0
☎ Contact Details
<EMAIL_ADDRESS>Code of Conduct

[X] I agree to follow this project's Code of Conduct

Closed by https://github.com/ecadlabs/taqueria-scaffold-nft/pull/11


(A11y severity 2) Label page number input in document preview

The page number text box does not have an associated label. Because there is no text next to this field that informs the user to the purpose of the textbox (e.g., "Enter page number "), the label will need to be hidden off-screen using CSS (see webaim.org/techniques/css/invisiblecontent/) or the field given a descriptive title or aria-label attribute.

To @nicolaasmatthijs for review. I think the aria-label attribute is even cleaner than adding a .sr-only <label>, but sr-only will work if you want to go that way instead.

This looks good. Merged.


Add command for managing service users

This implements a new sdpctl command for managing service users on Appgate SDP Collective. It has support for creating, reading (list and get), updating and deleting service users. The command also has support for disabling and enabling service users.
Creating and updating service users can be done either by prompt, flags or by reading a pre-defined JSON file. The UX here could probably use some work though.
Basic usage:
# creating a user
>sdpctl service-users create
? Name for service user: <service-user-name>
? Passphrase for service user: <passphrase>
? Confirm your passphrase: <passphrase>
New service user created:
{
  [...]
  "id": "<uuid>",
  "name": "<service-user-name>",
  [...]
}

# create user non-interactively
> echo <passphrase> | sdpctl service-users create --name <service-user-name>
New service user created:
[...]

# create from file
> sdpctl service-users create --from-file=<path-to-json-file>
New service user created:
[...]

# listing users
> sdpctl service-users list

# disable user
>sdpctl service-users update <uuid> disable

# removing a user
> sdpctl service-users remove <uuid>

Demo:

Fixes: SA-19919

e2e ok: https://got-testrail.agi.appgate.com/index.php?/plans/view/1061662

I will test it out.

Some feedback, we should not support passing passphrases via command line arguments.
It should be environment variables and even better via stdin/file descriptior.
Typo here:
  # create service user with flag input
  > sdpctl service-users create --name=<service-user-name> --passphrase=<service-user-passphrase

Some feedback, we should not support passing passphrases via command line arguments. It should be environment variables and even better via stdin/file descriptior.

The flag can be easily removed, but there''s support for passing in password via sdtin already:
echo <passphrase> | sdpctl service-users create --name <name>

Ah nice I missed that. Yes I think we shouldn't have password flags in general.

e2e: https://got-testrail.agi.appgate.com/index.php?/plans/view/1063849


code element does not wrap

to reproduce:

go to localhost:8000/donate locally
click on show other ways to donate.
decrease the screen size below 400px

I'd like to work on this :)

@nik72619c Thanks for your interest in this but it will be fixed with https://github.com/freeCodeCamp/freeCodeCamp/pull/37189. I pushing changes to it.
@nik72619c You can keep looking for "help wanted" open issues to help us: https://github.com/freeCodeCamp/freeCodeCamp/issues?q=is%3Aissue+is%3Aopen+label%3A"help+wanted".

Okay, thanks a lot !

Thanks @vkWeb, did you have a chance to test it on that specific case?

@ahmadabdolsaheb Yes, I've tested. PR #37189 will fix this issue.

It looks like a good plan with solid guidelines. Thanks!

Hello world hope you can help me out there thanks so much I love to see you sweetie hope you’re having fun I hope

SJT023E.docx

Resolved with #37189.

thanks


Fix flex direction of lead-gen columns

Due to a change elsewhere in the columns.css, the flex direction is now by column. It should be by row for widths greater than 900px.

This was addressed in https://github.com/hlxsites/Vonage/pull/102.


Water Sensors- JKB

Site JKB went down completely 07/12/2022 at 10am. Last transmission shows poor signal strength. Can we reset? Do we have data collection in the meantime?

Emailed Ryan about this on 12 July with the recommendation to check the to see that the data has been logged, and to reset the system.

Do we have a status update on this site?

Rep 1 sensors are sending data to the tech dashboard, but are not filling in the chart view
@brianwdavis @mikahpinegar


Replace L2 migration bash script with a Foundry script

I'd replace this file with a forge script (like Migrations.s.sol), so we have all this code already written in solidity and we can combine it to just one migration after the mainnet transition is done.

Originally posted by @martinvol in https://github.com/celo-org/celo-monorepo/pull/11107#discussion_r1670521608
These calls can go into a Foundry script:
https://github.com/celo-org/celo-monorepo/blob/a9060489576bc930ffa84904c6c45ebcc1f36f59/packages/protocol/scripts/foundry/create_and_migrate_anvil_l2_devchain.sh#L28-L36
https://github.com/celo-org/celo-monorepo/blob/a9060489576bc930ffa84904c6c45ebcc1f36f59/packages/protocol/scripts/foundry/create_and_migrate_anvil_l2_devchain.sh#L38-L44
https://github.com/celo-org/celo-monorepo/blob/a9060489576bc930ffa84904c6c45ebcc1f36f59/packages/protocol/scripts/foundry/create_and_migrate_anvil_l2_devchain.sh#L69-L78
As of https://github.com/celo-org/celo-monorepo/pull/11107, I found that this call cannot go into a Foundry script, because The CeloDistributionSchedule does not implement the receive function nor does it allow ERC20 transfers. An "admin"-like RPC call is the only way I managed to give the CeloDistributionSchedule a balance. During the actual L2 genisis on Mainnet, the Celo client (VM) would set the balance in a priviledged call:
https://github.com/celo-org/celo-monorepo/blob/a9060489576bc930ffa84904c6c45ebcc1f36f59/packages/protocol/scripts/foundry/create_and_migrate_anvil_l2_devchain.sh#L47-L55
Although something like this might work, need to confirm:
https://github.com/celo-org/celo-monorepo/blob/015002a5deff86d5ab646ee811fdabf133fbd4d0/packages/protocol/test-sol/unit/common/CeloDistributionSchedule.t.sol#L305

Marked this PR as ready for review:

#11177

Done in https://github.com/celo-org/celo-monorepo/pull/11177


Can I  combine two keys  to mapping anther key  ?

I  want to use  "s + hjkl"  to map to  arrows , can it be possible ? and how ?

I think you're waiting for issue #16 to be addressed; currently not possible, but might be in the future. Hopefully in the short-term future :)

No, that's a different issue; it's addressing the inverse of what @Menq is asking for. Karabiner used to have this legacy functionality, but not sure if there is a private.xml to edit anymore. This article describes the legacy funcationality: https://coolaj86.com/articles/home-row-arrow-keys-on-os-x-with-karabiner.html

@wwwjfy could help us, he's already done the inverse (mapping one key to multiple).


Make an article about difference between cupy and numpy

I made an article about difference between cupy and numpy.
fix #557, #583, #610, #815
related to #520

LGTM 👍


fix #240, update requirements

Dynamically fetch certificate based on cerifi.where() tied to current env.

just found this PR causing higher chance to fail at Searches. Thus, close to rework


[feature request]: dilated convolution layer

Hi, dilated convolution (https://github.com/fyu/dilation) is very useful in recently developed networks such as enet (https://github.com/e-lab/ENet-training).
Could you please add support to dilated convolution?

Hi @gwangsc we will have a look at it. There are some other things in the backlog but we definitely want to keep adding new layers!

@gwangsc we are also open to contributions if you want to implement the feature youself

New RNN performance shaders added to Metal in iOS 11.0 beta, should be fun to work with!


tf2-py: backport python3 fixes

A change before the v0.5.16 release broke python3 compatibility
and that triggers a build failure when ROS_USE_PYTHON3 = "yes".
To fix the build, backport two python3 related patches on top
of v0.5.16.
Signed-off-by: Mikko Ylinen<EMAIL_ADDRESS>

It generally looks good to me. I will need to just run some test builds, e.g., before and after. Just a stylistic comment: I usually use SRC_URI += ... after the require .inc line rather than SRC_URI_append. For uniformity, I would suggest to keep just that one pattern we already have rather than start mixing the two patterns in meta-ros if there are no good technical reasons for that.

I added the issue with report in the issue tracker under #551. If you change the commit, you can add (resolves #551) to the commit message header and this helps us to keep track of issue and correction.

The issue #551 is resolved with this patch, as I ran bitbake core-image-ros-world successfully on this build configuration with ROS_USE_PYTHON3 = "yes":
Build Configuration:
BB_VERSION        = "1.34.0"
BUILD_SYS         = "x86_64-linux"
NATIVELSBSTRING   = "ubuntu-14.04"
TARGET_SYS        = "i586-oe-linux"
MACHINE           = "qemux86"
DISTRO            = "nodistro"
DISTRO_VERSION    = "nodistro.0"
TUNE_FEATURES     = "m32 i586"
TARGET_FPU        = ""
meta              = "pyro:1009498f23ad319825c00ba60a4693d15aada553"
meta-oe
meta-multimedia
meta-python       = "pyro:5e82995148a2844c6f483ae5ddd1438d87ea9fb7"
meta-ros          = "mythi-python3-v1:fd0eff3bf6767ea2f5dca474c00881119896e256"

@bulwahn v2 pushed

Okay, this looks good to me.


Have xctool output unprocessed xcodebuild log?

There are numerous 'reporters' available that convert the xcodebuild output but I don't see any option to have an unchanged/unprocessed output?  Is this something that's possible without writing my own reporter?

We don't have such a reporter. And it doesn't make anymore sense since we have deprecated build features in xctool and as a result we don't parse xcodebuild output anywhere anymore.


Doc issue with "Get activation IDs"

The REST API docs for "Get activation IDs" (https://console.ng.bluemix.net/apidocs/98-ibm-bluemix-openwhisk?&language=node#get-activation-ids) include this argument:
Name: Name of item
But what is an item? If it means the action name, then it should be rewritten to say that:
Name: Name of action
Also, it should clarify if it will support partial matches. Imagine I've got 3 actions called doFoo, doGoo, doZoo. Can I match "do" to all 3? Or imagine I've got somepackage/doFoo. Would me asking for doFoo match or must I provide the package too?
Of course, that's all assuming I'm right that 'item' is action. If I'm not, well, it still needs explaining. :)
If you do change it to action, don't forget to change the code sample text too.

ibm doc issue.


Add Attribute Blink.

Thank you for your contribution @Extollite !
Merged and released to v4.0.2 ;)


missing round_end

Some demos have missing round_end events.  round_officially_ended seems to always trigger though.  Here's a demo where it happens multiple times: https://www.hltv.org/download/demo/28964

I noticed this too, and not while parsing, but watching normally through
the game client. I'm not sure, but I think this is an issue caused by
server plugins used by the tournament organizers. If thats indeed the case,
there's nothing we can do, except finding the round end through other means.
On Fri, Jun 2, 2017 at 1:21 AM, econoraptor<EMAIL_ADDRESS>wrote:

Some demos have missing round_end events. round_officially_ended seems to
always trigger though. Here's a demo where it happens multiple times:
https://www.hltv.org/download/demo/28964
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ValveSoftware/csgo-demoinfo/issues/20, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AEfhwHYnYpW_brVo_HbxKAZDpg5CS4Qqks5r_43dgaJpZM4Nt0F7
.

This happens on Valve's MM servers too. And it's not only round_end events missing, but could be any event (eg kills, etc).

Probably because on Valve servers GoTV relay isnt on the same host as the game server. Since UDP is used, some packets may be missing.


Crash when trying to backup my own gallery

Due to a layout change on Pixiv, when I try to download anything from my own gallery, pixivutil2 crashes.
The crash seems to happen because it calls to the manage page and not the gallery home page.
Since the manage page does not display the artist name or show an avatar, there is no file for pixivutil to download and therefore, it crashes. :(

can you provide the log file? You can delete the old log file, recreate the crash, and then upload the pixivutil.log here.

2017-09-21 00:51:46,417 - PixivUtil20170813-beta1 - INFO - ###############################################################
2017-09-21 00:51:46,417 - PixivUtil20170813-beta1 - INFO - Starting...
2017-09-21 00:51:46,420 - PixivUtil20170813-beta1 - INFO - Setting log level to: DEBUG
2017-09-21 00:51:46,420 - PixivUtil20170813-beta1 - INFO - No default cookie jar available, creating...
2017-09-21 00:51:46,421 - PixivUtil20170813-beta1 - INFO - Using default factory (mechanize 3.x ?)
2017-09-21 00:51:46,421 - PixivUtil20170813-beta1 - INFO - using default DB Path: I:\pixivutil\db.sqlite
2017-09-21 00:51:46,424 - PixivUtil20170813-beta1 - INFO - Only process member where day last updated >= 7
2017-09-21 00:51:46,424 - PixivUtil20170813-beta1 - INFO - Using Username: latexity
2017-09-21 00:51:46,424 - PixivUtil20170813-beta1 - INFO - Trying to log with saved cookie
2017-09-21 00:51:49,561 - PixivUtil20170813-beta1 - INFO - Login successfull.
2017-09-21 00:51:49,561 - PixivUtil20170813-beta1 - INFO - Logged in using cookie
2017-09-21 00:51:59,349 - PixivUtil20170813-beta1 - INFO - Member id mode.
2017-09-21 00:52:04,773 - PixivUtil20170813-beta1 - INFO - Processing Member Id: 539661
2017-09-21 00:52:04,789 - PixivUtil20170813-beta1 - INFO - Member Url: https://www.pixiv.net/member_illust.php?id=539661&p=1
2017-09-21 00:52:06,565 - PixivUtil20170813-beta1 - ERROR - Error at process_member(): (<type 'exceptions.IndexError'>, IndexError('list index out of range',), <traceback object at 0x03E30260>)
2017-09-21 00:52:06,565 - PixivUtil20170813-beta1 - ERROR - Traceback (most recent call last):
File "PixivUtil2.py", line 389, in process_member
File "PixivHelper.pyc", line 344, in createAvatarFilename
File "PixivHelper.pyc", line 138, in makeFilename
IndexError: list index out of range
2017-09-21 00:52:06,565 - PixivUtil20170813-beta1 - ERROR - Error at process_member(): 539661
Traceback (most recent call last):
File "PixivUtil2.py", line 389, in process_member
File "PixivHelper.pyc", line 344, in createAvatarFilename
File "PixivHelper.pyc", line 138, in makeFilename
IndexError: list index out of range
2017-09-21 00:52:06,565 - PixivUtil20170813-beta1 - DEBUG - Sanitized Filename: Error page for member 539661.html
2017-09-21 00:52:06,586 - PixivUtil20170813-beta1 - ERROR - Dumping html to: Error page for member 539661.html
2017-09-21 00:52:06,586 - PixivUtil20170813-beta1 - ERROR - Traceback (most recent call last):
File "PixivUtil2.py", line 389, in process_member
File "PixivHelper.pyc", line 344, in createAvatarFilename
File "PixivHelper.pyc", line 138, in makeFilename
IndexError: list index out of range
2017-09-21 00:52:06,591 - PixivUtil20170813-beta1 - ERROR - Unknown Error: list index out of range
Traceback (most recent call last):
File "PixivUtil2.py", line 1884, in main
File "PixivUtil2.py", line 1661, in main_loop
File "PixivUtil2.py", line 1311, in menu_download_by_member_id
File "PixivUtil2.py", line 389, in process_member
File "PixivHelper.pyc", line 344, in createAvatarFilename
File "PixivHelper.pyc", line 138, in makeFilename
IndexError: list index out of range
2017-09-21 00:52:08,292 - PixivUtil20170813-beta1 - INFO - EXIT: -1
2017-09-21 00:52:08,293 - PixivUtil20170813-beta1 - INFO - ###############################################################

I assume, you are member=539661?
Can you upload Error page for member 539661.html here? I don't have any uploaded artwork, so I cannot really test your case.

another way is by creating dummy account and do the download via that account.
Your private images won't be visible though.

Since I cannot upload html files, here is a screenshot of the error page cleaned for privacy (black boxes)
When trying to download from your own page, it calls to the artist "manage" page. On the "manage" page there are no name or avatar image displayed in the upper left. So, when pixivutil2 tries to download that information like it does for an artist main page, the program crashes because the data it is looking for is not there.

You can upload after zipping it. Please note that the application is not supporting to download your own artwork yet. I can code to skip the avatar, but other small differences might break the app again.
The alternative is by creating dummy account and download your own artwork using that account.

I understand now. :) I will have to make a dummy account then
Error page for member 539661.zip
Here is the html error file in case it will help you better with finding the problem

Should be fixed with limitation (member info will not be downloaded).
It is recommended to use another account to download the images.


backend/wayland: mpv stuttering when presentation-time feedback is enabled

Run Sway nested in Sway
Start mpv
The video stutters

Running with --wayland-disable-vsync=yes fixes it.

Does it still happen with my fork/old versions from before September last year?

Yes, your fork works fine.

Just seeing this issue right now, I know why this happens. It's just the heusteric that mpv is using for detecting if the window is hidden (wayland-disable-vsync ignores said heuristic).  In the nested sway case, the display's refresh rate reported is a apparently 0 hence the problem. I could very easily just set it to some random number (60 or whatever) if the display refresh rate being 0 is desirable.

The Wayland protocol allows a zero refresh rate for outputs where it doesn't makes sense: https://gitlab.freedesktop.org/wayland/wayland/-/blob/4c2105312379b62dc84f6eaaf26e2ab293d51b92/protocol/wayland.xml#L2566
So yeah some kind of fallback would be welcome! If you don't have time, I can look into it too.

https://github.com/mpv-player/mpv/pull/8741 should fix it.

Thanks!


Conjure: Add method for ignoring Qualtrics columns not needed for analysis

I think the keep/drop is a better approach than ex-ante screening out, but if you disagree @rbyh please re-open.


chore(deps): bump bulk-import plugins

Description
Bump the versions of the bulk import plugins, to fix some of the issues reported so far. And also to unblock the QE test automation.
Which issue(s) does this PR fix

https://issues.redhat.com/browse/RHIDP-3864
https://issues.redhat.com/browse/RHIDP-3865
https://issues.redhat.com/browse/RHIDP-3901
https://issues.redhat.com/browse/RHIDP-3884

PR acceptance criteria
Please make sure that the following steps are complete:

[ ] GitHub Actions are completed and successful
[ ] Unit Tests are updated and passing
[ ] E2E Tests are updated and passing
[ ] Documentation is updated if necessary (requirement for new features)
[ ] Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer
/cc @debsmita1 @subhashkhileri @invincibleJai @ciiay

/cherry-pick 1.3.x
Just so we don´t forget.

/test e2e-tests

/test e2e-tests

E2E tests should be fixed with https://github.com/janus-idp/backstage-showcase/pull/1576 according to @subhashkhileri .

/test all

/test e2e-tests

LGTM but tests are failing

Yeah, just discussed this with @subhashkhileri.
ae9e6c2 (#1605) should fix the tests.

/lgtm


Force API versioning in the client library.

Remove dependencies on docker's version packages.
Allow empty version as a fallback to latest version.
/cc @dnephin, @tiborvass
Signed-off-by: David Calavera<EMAIL_ADDRESS>

LGTM

LGTM


Allow to specify C++ standard version used via CMAKE_CXX_STANDARD CMake option

Fix for https://github.com/artivis/manif/issues/274 .
@GiulioRomualdi, when you have time can you check that this version works fine if you pass -DCMAKE_CXX_STANDARD=17 to manif's CMake options? Thanks!

Great, thanks! The corresponding upstream PR is https://github.com/artivis/manif/pull/275 .


CS0246	The type or namespace name 'GSResponse' could not be found (are you missing a using directive or an assembly reference?)	GigyaSDK.Android

I am trying to build the Gigya components for the solution: GigyaSDK.Android.sln and getting an error related to the GSResponse assembly. Also I see there is no reference to the Gigya SDK. Can anyone help me to fix this issue. Any blogs or articles on  Gigya integration with Xamarin is much appreciated.

Hi. I am also facing same issue.
Were you able to find a solution for your problem?

Here is what worked for me...

Downloaded the latest Android SDK for Gigya (JAR) from Gigya website.
Copy the JAR to the "Jars" folder in the "GigyaSDK.Android" project and set its BuildAction as "EmbeddedJar".
Update the entire solution with the latest Xamarin packages from NuGet.

Hope this helps.

Thanks a lot for the help
On Tue, Jun 13, 2017 at 11:33 PM, ASN1234<EMAIL_ADDRESS>wrote:

Here is what worked for me...

Downloaded the latest Android SDK for Gigya (JAR) from Gigya
website.
Copy the JAR to the "Jars" folder in the "GigyaSDK.Android" project
and set its BuildAction as "EmbeddedJar".
Update the entire solution with the latest Xamarin packages from
NuGet.

Hope this helps.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/xamarin/XamarinComponents/issues/156#issuecomment-308199772,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADKZlPMrdEA4f-6nsnoDIh1ABdvdHTw8ks5sDs70gaJpZM4NfZ5F
.


applied some threading love.

AbstractGatewayService.java: instead of (potentially) starting a new executeQueue thread every time queueJob is called, only start it once in onCreate and more
importantly have it interrupted by onDestroy. this means a new thread is started when service is created and asked nicely to stop when service is destroyed
(Mock)ObdGatewayService.java: try to handle the thread interruption by bailing out when thread is interrupted and catching InterruptedException (and re-throwing it),
no need for isQueueRunning flag anymore.
This resolves issue where multiple executeQueue threads are reading from stream at same time resulting in garbage out. in theory it should only have started new
thread when none is running and stopped when the queue was empty but this is wasn't always working. also no need to stop the thread when queue is empty it will
happily sit and wait for it to be refilled again so we can just have one thread.

hey have a look at this, i'm sure the logic of interrupting and catching can be improved but this seems to work as it is. might help towards resolving #40

Tbh, I dislike explicit threading on Android. That's why you have stuff like AsyncTask. Anyway, the code looks good and so I'm merging it.
Closes #40


How to train on COCO/own dataset?

First off, I would like to say thank you for sharing this amazing work.
Will you be adding instructions or scripts to train and test on own dataset?
Is it correct to say the dataset should be a COCO like format with the inclusion of track_id in the annotation?

Some debugging indicates that img_ids is empty due to this condition
and abs(img_info["frame_id"] - frame_id) > 0
in
def _load_pre_data_AFE(self, video_id, frame_id, sensor_id=1):
img_infos = self.video_to_images[video_id]
    if "train" in self.split:
        img_ids = [
            (img_info["id"], img_info["frame_id"])
            for img_info in img_infos
            if abs(img_info["frame_id"] - frame_id) <= self.opt.max_frame_dist_AFE
            and abs(img_info["frame_id"] - frame_id) > 0
            and (
                not ("sensor_id" in img_info) or img_info["sensor_id"] == sensor_id
            )
        ]

yes we have plans to add scripts to train and test on your own dataset but if you have dataset in coco format you can modify the current code to make it work for your own dataset with no much work I think.


Search now requires Authenication

https://myanimelist.net/modules.php?go=api#animemangasearch
It looks like the search function now needs authentication as well

GetUserListAsync aswell

Thanks for notifying me and the pull request. However I believe you can still get the user list without being authenticated.


Clicking outside of the popup boundaries

Hey there,
In Android, you can dismiss the popup by clicking outside of the popup box.
Is there any way I can disable this behaviour, or alternatively, handle this action somehow?

I recommend you read the document before ask question 🙄
On Sun, 11 Feb 2018 at 11:12 PM, Dror-Bar<EMAIL_ADDRESS>wrote:

Hey there,
In Android, you can dismiss the popup by clicking outside of the popup box.
Is there any way I can disable this behaviour, or alternatively, handle
this action somehow?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jacklam718/react-native-popup-dialog/issues/98, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFPXbp5UNxdLLaHKsbmBbrD4BjcPDii_ks5tTwN6gaJpZM4SBXze
.

Haha, I have read it a few times in the past. Of course I read right through it. My apologize jacklam!

@Dror-Bar  Thanks 😉


Support For tr Keyboard Layout. (tr_tr)

Hello,I've Been Looking For tr_tr Keyboard Layout But I Couldn't Find It.Then I Tried to Do It Myself But Couldn't Figure Out How to Do.
Is There Any Way I Can Make It Myself Or Do I Have To Wait?
Sorry For Taking Your Time.

Can you try this page to generate a layout, and tell me how it goes ?
https://www.neradoc.me/layouts/

I'm Pretty Sure I Did Something Wrong But I Cant Figure Out What.This Is The Code.py File
from adafruit_hid.keyboard import Keyboard
import keyboard_layout_win_tuq
from keycode_win_tuq import Keycode
import time
import digitalio
from board import *

keyboard = Keyboard(usb_hid.devices)
# type with a layout
layout = keyboard_layout_win_tuq.KeyboardLayout(keyboard)
layout.write("Bonjour le monde")
# shortcuts with keycodes
keyboard.send(Keycode.LEFT_CONTROL, Keycode.A)
keyboard.send(Keycode.DELETE)

duckyCommands = ["WINDOWS", "GUI", "APP", "MENU", "SHIFT", "ALT", "CONTROL", "CTRL", "DOWNARROW", "DOWN",
"LEFTARROW", "LEFT", "RIGHTARROW", "RIGHT", "UPARROW", "UP", "BREAK", "PAUSE", "CAPSLOCK", "DELETE", "END",
"ESC", "ESCAPE", "HOME", "INSERT", "NUMLOCK", "PAGEUP", "PAGEDOWN", "PRINTSCREEN", "SCROLLLOCK", "SPACE",
"TAB", "ENTER", " a", " b", " c", " d", " e", " f", " g", " h", " i", " j", " k", " l", " m", " n", " o", " p", " q", " r", " s", " t",
" u", " v", " w", " x", " y", " z", " A", " B", " C", " D", " E", " F", " G", " H", " I", " J", " K", " L", " M", " N", " O", " P",
" Q", " R", " S", " T", " U", " V", " W", " X", " Y", " Z"]

keycodeCommands = [Keycode.WINDOWS, Keycode.GUI, Keycode.APPLICATION, Keycode.APPLICATION, Keycode.SHIFT, Keycode.ALT, Keycode.CONTROL,
Keycode.CONTROL, Keycode.DOWN_ARROW, Keycode.DOWN_ARROW ,Keycode.LEFT_ARROW, Keycode.LEFT_ARROW, Keycode.RIGHT_ARROW, Keycode.RIGHT_ARROW,
Keycode.UP_ARROW, Keycode.UP_ARROW, Keycode.PAUSE, Keycode.PAUSE, Keycode.CAPS_LOCK, Keycode.DELETE, Keycode.END, Keycode.ESCAPE,
Keycode.ESCAPE, Keycode.HOME, Keycode.INSERT, Keycode.KEYPAD_NUMLOCK, Keycode.PAGE_UP, Keycode.PAGE_DOWN, Keycode.PRINT_SCREEN,
Keycode.SCROLL_LOCK, Keycode.SPACE, Keycode.TAB, Keycode.ENTER, Keycode.A, Keycode.B, Keycode.C, Keycode.D, Keycode.E, Keycode.F, Keycode.G,
Keycode.H, Keycode.I, Keycode.J, Keycode.K, Keycode.L, Keycode.M, Keycode.N, Keycode.O, Keycode.P, Keycode.Q, Keycode.R, Keycode.S, Keycode.T,
Keycode.U, Keycode.V, Keycode.W, Keycode.X, Keycode.Y, Keycode.Z, Keycode.A, Keycode.B, Keycode.C, Keycode.D, Keycode.E, Keycode.F,
Keycode.G, Keycode.H, Keycode.I, Keycode.J, Keycode.K, Keycode.L, Keycode.M, Keycode.N, Keycode.O, Keycode.P,
Keycode.Q, Keycode.R, Keycode.S, Keycode.T, Keycode.U, Keycode.V, Keycode.W, Keycode.X, Keycode.Y, Keycode.Z]

def convertLine(line):
    newline = []
    print(line)
    for j in range(len(keycodeCommands)):
		    if line.find(duckyCommands[j]) != -1:
		    	newline.append(keycodeCommands[j])
    print(newline)
    return newline

def runScriptLine(line):
    for k in line:
        kbd.press(k)
    kbd.release_all()

def sendString(line):
    layout.write(line)

def parseLine(line):
    if(line[0:3] == "REM"):
        # ignore ducky script comments
        print("")
    elif(line[0:5] == "DELAY"):
        time.sleep(float(line[6:])/1000)
    elif(line[0:6] == "STRING"):
        sendString(line[7:])
    elif(line[0:13] == "DEFAULT_DELAY"):
        defaultDelay = int(line[14:]) * 10
    elif(line[0:12] == "DEFAULTDELAY"):
        defaultDelay = int(line[13:]) * 10
    else:
        newScriptLine = convertLine(line)
        runScriptLine(newScriptLine)

kbd = Keyboard(usb_hid.devices)
layout = KeyboardLayoutUS(kbd)

# sleep at the start to allow the device to be recognized by the host computer
time.sleep(.5)

# check GP0 for setup mode
# see setup mode for instructions
progStatus = False
progStatusPin = digitalio.DigitalInOut(GP0)
progStatusPin.switch_to_input(pull=digitalio.Pull.UP)
progStatus = progStatusPin.value
defaultDelay = 0
if(progStatus == True):
    # not in setup mode, inject the payload
    duckyScriptPath = "payload.dd"
    f = open(duckyScriptPath,"r",encoding='utf-8')
    print("Running payload.dd")
    previousLine = ""
    duckyScript = f.readlines()
    for line in duckyScript:
        line = line.rstrip()
        if(line[0:6] == "REPEAT"):
            for i in range(int(line[7:])):
                #repeat the last command
                parseLine(previousLine)
                time.sleep(float(defaultDelay)/1000)
        else:
            parseLine(line)
            previousLine = line
        time.sleep(float(defaultDelay)/1000)

    print("Done")
else:
    print("Update your payload")

Don't put the sample code in the ducky code, follow the changes over there (changing "da" to "tuq")
https://github.com/dbisu/pico-ducky/issues/10#issuecomment-910684858

I Tested Almost Every Single Key And It Seems to Be Working Perfectly Fine.Thanks A Lot!
Here Are The Files If Anyone Needs It:
tr_keyboard_layout.zip

Ok, I'll integrate them in the repository in a future release. Thanks for testing. 👍


Fix elasticsearch status bug

Fixed in https://github.com/OT-CONTAINER-KIT/logging-operator/pull/2


fetch nominal income and calculate CC tx fee

we currently hardcode fees and have no idea of nominal income.
On the send page we should show the correct fee, be it CC or another CC or native

I see two options for this:
Option 1.

If online, try fetching the fee details with the rpc query_asset_fee_details
If offline, compute an estimate based on the nominal income

Option 2.
If we want to support being offline, then we might as well implement only 2. from Option 1 above to simplify the code.

what about caching the vaule for offline times, assuming that we're online every now and then and the fees are quite static anyway...?

Agreed


Weird NETHER_BRICK and NETHER_BRICK_ITEM items

There are two items for Nether Bricks which both look like the nether brick block.
They have completely empty recipes, and pressing r on a nether brick (item) that you got by smelting netherrack (the ingot looking one) leads you to a recipe for one of the two.

I don't think you can smelt netherrack?

@Luk-ESC can you test it now?

Fixed in #1147


ARROW-14211: [C++][Compute] Fixing thread sanitizer problems in hash join node

Fixing 3 issues:

one in SchemaProjectionMaps - I simplified all of the code to get rid of thread synchronization at all
one in TaskScheduler - added (unnecessary) mutex
one in HashJoinImpl - switching from shared byte vector to local bit vectors and merge (for recording if a match for a hash table row has been seen)

@github-actions crossbow submit -g cpp

@github-actions crossbow submit -g cpp

@github-actions crossbow submit -g cpp

@github-actions crossbow submit -g r

@bkietz Are you available to give a quick review on this? If CI is ok, it would be nice to have this fix in 6.0.0.

@github-actions crossbow submit -g cpp -g r

OK.
I merge this.


Cant Figure out why my Prefixes/Suffixs wont work

Hello!
first off, i want to say i love LuckPerms. it's made my life so much easier on managing my sponge Server.
Recently found an issue though. I've been doing some updating, and suddenly all my suffixes are gone. I've installed the VaultChatformatter like it says on the Wiki, and I'm pretty sure i have the correct version of everything on my sponge server (1.12.2) , but something isn't adding up.
I run the commands like normal, and LP shows it accepts the command, but then nothing after.
My Current versions are as follows:
Luckperms version:  LuckPerms-sponge-4.1.73
VaultChatFormatter version:  most recent one from their website
Vault: 1.6.6
Sponge-forge version: spongeforge-1.12.2-2611-7.1.0-BETA-3002.jar
As well, here is a paste-bin of the start up of my server, in case that information is important:
https://pastebin.com/euxU8vXi
Please let me know if you need any more information, or what i need to do to fix this issue.
Thank you for your time :)

Vault and VaultChatFormatter are Bukkit plugins and won't run on Sponge.
I suggest using Nucleus.

Is there anything else I'll need ot install besides Nucleus to get the prefixes to work? I want to make sure i do this right. :)

Sweet :)
On Wed, Apr 25, 2018 at 9:22 AM, Luck<EMAIL_ADDRESS>wrote:

Nope :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lucko/LuckPerms/issues/941#issuecomment-384347456,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AbyZOnQ_8HfATCWv1sWUCxeRDoOVIsN8ks5tsKLegaJpZM4Tjs-Y
.


New Tax models

I want to merge this change because...

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-4845 Create database models

@L3str4nge  You added lable 3.0 but this should go to 3.1


chore: import repository https://github.com/borderx/jkx-golang2.git

this commit will trigger a pipeline to generate the CI/CD configuration which will create a second commit on this Pull Request before it auto merges

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


adding view tap extension

Current coverage is 74.25% (diff: 0.00%)

Merging #35 into master will decrease coverage by 5.52%

@@             master        #35   diff @@
==========================================
  Files             8          8
  Lines            94        101     +7
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits             75         75
- Misses           19         26     +7
  Partials          0          0

Powered by Codecov. Last update ff3f0dd...0ca74c5


Suggestion: add quat_to_axis_angle

I looked for this but couldn't find a quat_to_axis_angle. While I assume this can be obtained by applying the quaternion on a forward pointing vector and getting the angle manually, this is more cumbersome than a single call. Also, this might be me just misunderstanding things, but to me it's not obvious what sort of vector would align with the axis of a non-rotating quaternion in mathc's coordinate system since this is not specified. (Is it 0,0,-1? Or 1,0,0? ...) I might be wrong, but I think this knowledge is required to implement this manually in a way such that the quat_from_axis_angle reverses back to the same quaternion.

Ok, I  think quat_from_vec3 is actually doing what I thought quat_from_axis_angle did. Maybe a one-line comment about what each quaternion function does could help beginners like me? E.g. I thought quat_from_vec3 takes a look-at vector and then provides the roll rotation, but reading more code and other quaternion libs APIs I assume now it's just taking the x,y,z,w notation that is common. Does it though? I don't find it completely obvious, so a one-liner explaining it might be nice

In any case, I think this suggestion is probably not meaningful and mostly stemmed from me being confused by  the lack of documentation


offline cannot start label-studio

label-studio start
=> Database and media directory xxx/.local/share/label-studio
=> Static URL is set to: /static/
=> Database and media directory: xxx/.local/share/label-studio
=> Static URL is set to: /static/
Can't read version file: ls-version_.py. Fall back to: version_.py
[2024-08-20 15:12:13,399] [root::read_py::61] [WARNING] Can't read version file: ls-version.py. Fall back to: version_.py
[2024-08-20 15:12:13,648] [root::read_py::61] [WARNING] Can't read version file: ls-version.py. Fall back to: version_.py
*** WARNING! ***

Port 8080 is in use.
Trying to start at 8081

Performing system checks...
System check identified no issues (1 silenced).
August 20, 2024 - 15:12:13
Django version 3.2.19, using settings 'label_studio.core.settings.label_studio'
Starting development server at http://<IP_ADDRESS>:8081/
Quit the server with CONTROL-C.
[2024-08-20 15:12:16,382] [django.server::log_message::161] [INFO] "GET / HTTP/1.1" 302 0
[2024-08-20 15:12:16,382] [django.server::log_message::161] [INFO] "GET / HTTP/1.1" 302 0
[2024-08-20 15:12:53,805] [django.server::log_message::161] [INFO] "GET / HTTP/1.1" 302 0
[2024-08-20 15:12:53,805] [django.server::log_message::161] [INFO] "GET / HTTP/1.1" 302 0
[2024-08-20 15:13:29,125] [django.server::log_message::161] [INFO] "GET / HTTP/1.1" 302 0
[2024-08-20 15:13:29,125] [django.server::log_message::161] [INFO] "GET / HTTP/1.1" 302 0
the redirect page show 404

Hi @kiddliao - did you access your Label Studio instance at http://localhost:8081? It looks like 8080 is bound by something else, and I wonder if there might be some kind of conflict there. See if you can kill whatever process is currently occupying port 8080, then restart label studio and try accessing it at http://localhost:8080. If that doesn't help, please post a screenshot of what you're getting when you access localhost:8080 and perhaps that will help us debug further.

Closing this issue as unanswered. Feel free to reopen.


Handle overflow

Hi,
Great project first of all. Thank you so much.
Is it possible to handle the overflow some way? I am trying to insert equations to some text.
Here is an example text with equation: r' \text {What is the value of } \frac {20} {30} \text {in decimal?} '
The problem is that the whole thing is one line and it is clipped of or overflowed the container. I want it to have the behavior of a normal text widget, like, automatically create new lines so that the texts wont overflow or clipped out of the container.
Is there a built-in option for that? If there is not, what would I have to do to achieve the same behavior?
Thanks a lot for your help.

Thank you for liking this library!
Currently there is still no support for auto-wrap features. The reasons are discussed in https://github.com/znjameswu/flutter_math/issues/8 . This is somewhat non-trivial due to Flutter's layout system. However this is definitely on the roadmap. I'm still trying to come up with a good design for it.
For now, you can probably mitigate this problem by using a smaller fontSize / wrap it inside a scrollable.

Oh, there was already filed a similar issue., I am closing this then. Looking forward for the feature to be implemented. Thanks.


Sometimes freezes Firefox when in about:addons

I am testing it out with Firefox Developer Editition for debugging my add-on.
So when I am in about:add-ons it often freezes Firefox. Also, it ignores my breajkpoint.
STR:

Debug add-on.
Set breakpoint somewhere in code that is to be called in the settings.
Go to settings page of add-on.
-> First issue: Breakpoint does not trigger, but is just ignored.
Press F5 in the browser to reload the options page OR click on "extensions" on the left to get to the overview.
-> Freezes.

Firefox log:
JavaScript warning: resource://devtools/shared/base-loader.js -> resource://devtools/server/actors/inspector/walker.js, line 1612: DebuggeeWouldRun: debuggee `self-hosted:582' would run
JavaScript warning: resource://devtools/shared/base-loader.js -> resource://devtools/server/actors/inspector/walker.js, line 1612: DebuggeeWouldRun: debuggee `self-hosted:582' would run
JavaScript warning: resource://devtools/shared/base-loader.js -> resource://devtools/server/actors/utils/event-loop.js, line 118: DebuggeeWouldRun: debuggee `chrome://global/content/bindings/general.xml:15' would run

Firefox 62

The breakpoint not being hit when the code runs for the first time is a known weakness of the debug protocol. There are two workarounds:

reload (which is not a good option in this case, due to the bug you described)
use a debugger statement

As for the reloading bug: I could reproduce it, but the behavior seems very sporadic and I'm not sure what the issue really is and if I can fix it. I'll keep trying though (when I find the time).
One observation: It seemed to happen less frequently when I added "sourceMaps": "client" to the configuration. That seems weird, since you're not using sourcemaps, but it's not entirely impossible. On the other hand the sporadic behavior makes diagnosing and narrowing down this bug very difficult, so maybe this was just coincidence.


Well put together walkthrough of C#

It walks you into the basics of C# that will later be used as the fundamentals for developing code. Compared to most coding tutorials this is one of the best ones that I have come across. If there is questions on the topics covered there are links leading the viewer to more information about it and they may go as deep as they want.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3d841900-8699-af9b-f879-c5cf9b54f21e
Version Independent ID: 2d85eae9-01e1-17af-b282-715ec3dc0dcb
Content: Hello World - Introduction to C# interactive C# tutorial
Content Source: docs/csharp/tutorials/intro-to-csharp/hello-world.yml
Product: dotnet-csharp
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Thanks again for the nice comments 😄 Glad these helped you!


Add missing License and Copyright headers

Add license headers to all files/fix them up with the correct template.

@mattfarina we need some directions here, should we go with a standard apache license header or some suse specific thing?

@mattfarina we need some directions here, should we go with a standard apache license header or some suse specific thing?

For license, we should choose a standard one (Apache, GPL, ...). For copyright, we need to use the standard SUSE copyright line.

https://opensource.suse.com/suse-open-source-policy.html gives some directions, esp. about copyright:

Copyright
The code you contribute upstream or publish as Open Source as part of your job at SUSE in your work time is copyrighted or
otherwise owned by SUSE. Use “SUSE LLC” when attributing the copyright. Use your<EMAIL_ADDRESS>email address for
contributions.


Comments on message fields end up on struct fields instead of getter methods when code is generated

What version of protobuf and what language are you using?
> protoc --version
libprotoc 3.14.0
> protoc-gen-go --version
protoc-gen-go v1.25.0

Using Go (and example related to Java too, see explanation).
What did you do?
Created message definition. Added a comment to the message's field:
syntax = "proto3";

package mypackage;

option go_package = ".;goprotos";

enum ImpressionType {
    SEARCH = 0;
    RECOMMENDATION = 1;
}

message MyMessage {
    // The impression type of the message. Guaranteed to be there.
    ImpressionType impression_type = 1;
}

Ran the protoc compiler:
#!/bin/bash

PROTO_FILE="proto/mypackage.proto"
SRC_DIR="."

GO_DST_DIR="generated/go"
rm -r $GO_DST_DIR
mkdir -p $GO_DST_DIR
protoc -I=$SRC_DIR --go_out=$GO_DST_DIR $SRC_DIR/$PROTO_FILE
echo "Generated Go."

Observed the generated code:
// Code generated by protoc-gen-go. DO NOT EDIT.
// versions:
// 	protoc-gen-go v1.25.0
// 	protoc        v3.14.0
// source: proto/mypackage.proto

package goprotos

import (
	proto "github.com/golang/protobuf/proto"
	protoreflect "google.golang.org/protobuf/reflect/protoreflect"
	protoimpl "google.golang.org/protobuf/runtime/protoimpl"
	reflect "reflect"
	sync "sync"
)

const (
	// Verify that this generated code is sufficiently up-to-date.
	_ = protoimpl.EnforceVersion(20 - protoimpl.MinVersion)
	// Verify that runtime/protoimpl is sufficiently up-to-date.
	_ = protoimpl.EnforceVersion(protoimpl.MaxVersion - 20)
)

// This is a compile-time assertion that a sufficiently up-to-date version
// of the legacy proto package is being used.
const _ = proto.ProtoPackageIsVersion4

type ImpressionType int32

const (
	ImpressionType_SEARCH         ImpressionType = 0
	ImpressionType_RECOMMENDATION ImpressionType = 1
)

// Enum value maps for ImpressionType.
var (
	ImpressionType_name = map[int32]string{
		0: "SEARCH",
		1: "RECOMMENDATION",
	}
	ImpressionType_value = map[string]int32{
		"SEARCH":         0,
		"RECOMMENDATION": 1,
	}
)

func (x ImpressionType) Enum() *ImpressionType {
	p := new(ImpressionType)
	*p = x
	return p
}

func (x ImpressionType) String() string {
	return protoimpl.X.EnumStringOf(x.Descriptor(), protoreflect.EnumNumber(x))
}

func (ImpressionType) Descriptor() protoreflect.EnumDescriptor {
	return file_proto_mypackage_proto_enumTypes[0].Descriptor()
}

func (ImpressionType) Type() protoreflect.EnumType {
	return &file_proto_mypackage_proto_enumTypes[0]
}

func (x ImpressionType) Number() protoreflect.EnumNumber {
	return protoreflect.EnumNumber(x)
}

// Deprecated: Use ImpressionType.Descriptor instead.
func (ImpressionType) EnumDescriptor() ([]byte, []int) {
	return file_proto_mypackage_proto_rawDescGZIP(), []int{0}
}

type MyMessage struct {
	state         protoimpl.MessageState
	sizeCache     protoimpl.SizeCache
	unknownFields protoimpl.UnknownFields

	// The impression type of the message. Guaranteed to be there.
	ImpressionType ImpressionType `protobuf:"varint,1,opt,name=impression_type,json=impressionType,proto3,enum=mypackage.ImpressionType" json:"impression_type,omitempty"`
}

func (x *MyMessage) Reset() {
	*x = MyMessage{}
	if protoimpl.UnsafeEnabled {
		mi := &file_proto_mypackage_proto_msgTypes[0]
		ms := protoimpl.X.MessageStateOf(protoimpl.Pointer(x))
		ms.StoreMessageInfo(mi)
	}
}

func (x *MyMessage) String() string {
	return protoimpl.X.MessageStringOf(x)
}

func (*MyMessage) ProtoMessage() {}

func (x *MyMessage) ProtoReflect() protoreflect.Message {
	mi := &file_proto_mypackage_proto_msgTypes[0]
	if protoimpl.UnsafeEnabled && x != nil {
		ms := protoimpl.X.MessageStateOf(protoimpl.Pointer(x))
		if ms.LoadMessageInfo() == nil {
			ms.StoreMessageInfo(mi)
		}
		return ms
	}
	return mi.MessageOf(x)
}

// Deprecated: Use MyMessage.ProtoReflect.Descriptor instead.
func (*MyMessage) Descriptor() ([]byte, []int) {
	return file_proto_mypackage_proto_rawDescGZIP(), []int{0}
}

func (x *MyMessage) GetImpressionType() ImpressionType {
	if x != nil {
		return x.ImpressionType
	}
	return ImpressionType_SEARCH
}

var File_proto_mypackage_proto protoreflect.FileDescriptor

var file_proto_mypackage_proto_rawDesc = []byte{
	0x0a, 0x15, 0x70, 0x72, 0x6f, 0x74, 0x6f, 0x2f, 0x6d, 0x79, 0x70, 0x61, 0x63, 0x6b, 0x61, 0x67,
	0x65, 0x2e, 0x70, 0x72, 0x6f, 0x74, 0x6f, 0x12, 0x09, 0x6d, 0x79, 0x70, 0x61, 0x63, 0x6b, 0x61,
	0x67, 0x65, 0x22, 0x4f, 0x0a, 0x09, 0x4d, 0x79, 0x4d, 0x65, 0x73, 0x73, 0x61, 0x67, 0x65, 0x12,
	0x42, 0x0a, 0x0f, 0x69, 0x6d, 0x70, 0x72, 0x65, 0x73, 0x73, 0x69, 0x6f, 0x6e, 0x5f, 0x74, 0x79,
	0x70, 0x65, 0x18, 0x01, 0x20, 0x01, 0x28, 0x0e, 0x32, 0x19, 0x2e, 0x6d, 0x79, 0x70, 0x61, 0x63,
	0x6b, 0x61, 0x67, 0x65, 0x2e, 0x49, 0x6d, 0x70, 0x72, 0x65, 0x73, 0x73, 0x69, 0x6f, 0x6e, 0x54,
	0x79, 0x70, 0x65, 0x52, 0x0e, 0x69, 0x6d, 0x70, 0x72, 0x65, 0x73, 0x73, 0x69, 0x6f, 0x6e, 0x54,
	0x79, 0x70, 0x65, 0x2a, 0x30, 0x0a, 0x0e, 0x49, 0x6d, 0x70, 0x72, 0x65, 0x73, 0x73, 0x69, 0x6f,
	0x6e, 0x54, 0x79, 0x70, 0x65, 0x12, 0x0a, 0x0a, 0x06, 0x53, 0x45, 0x41, 0x52, 0x43, 0x48, 0x10,
	0x00, 0x12, 0x12, 0x0a, 0x0e, 0x52, 0x45, 0x43, 0x4f, 0x4d, 0x4d, 0x45, 0x4e, 0x44, 0x41, 0x54,
	0x49, 0x4f, 0x4e, 0x10, 0x01, 0x42, 0x21, 0x0a, 0x09, 0x6d, 0x79, 0x70, 0x61, 0x63, 0x6b, 0x61,
	0x67, 0x65, 0x42, 0x08, 0x4d, 0x79, 0x50, 0x72, 0x6f, 0x74, 0x6f, 0x73, 0x5a, 0x0a, 0x2e, 0x3b,
	0x67, 0x6f, 0x70, 0x72, 0x6f, 0x74, 0x6f, 0x73, 0x62, 0x06, 0x70, 0x72, 0x6f, 0x74, 0x6f, 0x33,
}

var (
	file_proto_mypackage_proto_rawDescOnce sync.Once
	file_proto_mypackage_proto_rawDescData = file_proto_mypackage_proto_rawDesc
)

func file_proto_mypackage_proto_rawDescGZIP() []byte {
	file_proto_mypackage_proto_rawDescOnce.Do(func() {
		file_proto_mypackage_proto_rawDescData = protoimpl.X.CompressGZIP(file_proto_mypackage_proto_rawDescData)
	})
	return file_proto_mypackage_proto_rawDescData
}

var file_proto_mypackage_proto_enumTypes = make([]protoimpl.EnumInfo, 1)
var file_proto_mypackage_proto_msgTypes = make([]protoimpl.MessageInfo, 1)
var file_proto_mypackage_proto_goTypes = []interface{}{
	(ImpressionType)(0), // 0: mypackage.ImpressionType
	(*MyMessage)(nil),   // 1: mypackage.MyMessage
}
var file_proto_mypackage_proto_depIdxs = []int32{
	0, // 0: mypackage.MyMessage.impression_type:type_name -> mypackage.ImpressionType
	1, // [1:1] is the sub-list for method output_type
	1, // [1:1] is the sub-list for method input_type
	1, // [1:1] is the sub-list for extension type_name
	1, // [1:1] is the sub-list for extension extendee
	0, // [0:1] is the sub-list for field type_name
}

func init() { file_proto_mypackage_proto_init() }
func file_proto_mypackage_proto_init() {
	if File_proto_mypackage_proto != nil {
		return
	}
	if !protoimpl.UnsafeEnabled {
		file_proto_mypackage_proto_msgTypes[0].Exporter = func(v interface{}, i int) interface{} {
			switch v := v.(*MyMessage); i {
			case 0:
				return &v.state
			case 1:
				return &v.sizeCache
			case 2:
				return &v.unknownFields
			default:
				return nil
			}
		}
	}
	type x struct{}
	out := protoimpl.TypeBuilder{
		File: protoimpl.DescBuilder{
			GoPackagePath: reflect.TypeOf(x{}).PkgPath(),
			RawDescriptor: file_proto_mypackage_proto_rawDesc,
			NumEnums:      1,
			NumMessages:   1,
			NumExtensions: 0,
			NumServices:   0,
		},
		GoTypes:           file_proto_mypackage_proto_goTypes,
		DependencyIndexes: file_proto_mypackage_proto_depIdxs,
		EnumInfos:         file_proto_mypackage_proto_enumTypes,
		MessageInfos:      file_proto_mypackage_proto_msgTypes,
	}.Build()
	File_proto_mypackage_proto = out.File
	file_proto_mypackage_proto_rawDesc = nil
	file_proto_mypackage_proto_goTypes = nil
	file_proto_mypackage_proto_depIdxs = nil
}

And used a test program to test it out:
package main

import (
	"fmt"

	pb "github.com/mattwelke/protobuf-test/generated/go"
)

func main() {
	myMessage := &pb.MyMessage{
		ImpressionType: pb.ImpressionType_SEARCH,
	}

	// intellisense :)
	fmt.Printf("Data provided (because is non-nullable enum). It is %v.\n", myMessage.ImpressionType)

	// no intellisense :(
	fmt.Printf("Data provided (because is non-nullable enum). It is %v.\n", myMessage.GetImpressionType())
}

What did you expect to see?
Since I'm using Protobuf with other languages like Java too, I expected to see comments when I moused over the getter methods, with the content of the comment being the comment I put in the .proto file. This helps me as a coder understand what the field means (great for using a Protobuf schema made by someone else).
What did you see instead?
Instead, for Go, if I use the getter method, I see no comment:

I do see the comment though if I access the struct data directly:

I'm very new to Protobuf, so I assumed what I saw in Java made sense, that the design goals were for comments from the schema to be made available to the user of code generated from the schema. And I expected that getter methods, since they're there in the generated Go code, should be used. I imagine the only reason the struct fields are exported is so packages like json can use them for deserializing and serialization.
More info
Using VS Code to develop with, which is why I get those pretty comments explaining to me what my message fields are.

I general, for Go, and proto3 it is expected that the fields should be accessed directly, rather than through Getters.
There is no reason to encapsulate and restrict access to them through Getters/Setters, when there is no actual logic in the Getter/Setter more than just returning or setting the field directly.

That makes sense. When I write Go, I just access fields directly unless there's some business logic like validating a mutation. In that case, getters and setters make sense.
Since Protobuf doesn't appear to have any logic in the getters and setters in generated Go code, why do they exist? The getter looks like it checks if the method receiver exists before accessing data from the message struct:
func (x *MyMessage) GetImpressionType() ImpressionType {
	if x != nil {
		return x.ImpressionType
	}
	return ImpressionType_SEARCH
}

But why is this check needed? Wouldn't we be able to assume that the pointer used as the method receiver is always not nil?

I think the getters are in part there for facilitating a transfer from proto2 to proto3. In proto2, if a value was not set, it could actually return a non-zero default value.
The other reason where it’s reasonable are in cases where you’re accessing a field of a message in a message, so you can do something like myMessage1.MyMessage2.GetImpressionType() rather than needing to check the sub-message yourself to prevent a nil-deref.
However, I’m a pretty firm believer that we should be doing those nil-deref guards ourselves, and not hiding them with implicit magic.

The getters are there because m.GetA().GetB().GetC().GetD() != nil is a lot easier to read than the equivalent with manual presence checks.

Hey that's pretty handy:
message MyNestedMessage {
    string some_string = 1;
}

message MyMessage {
    MyNestedMessage some_nested_message = 1;
}

fmt.Printf("Lacks some_nested_message field = %v\n", item.GetSomeNestedMessage() == nil) // Lacks some_nested_message field = true
fmt.Printf("Nested data is %v.\n", item.GetSomeNestedMessage().GetSomeString()) // Nested data is .

No nil pointer dereference and no panic. Thanks for clearing that up for me.


[REQUEST] Batch API calls

I'd be really interested in support for batch API calls. An example of this would be a call to get a couple different anime objects by MyAnimeList ID: https://jikan.me/api/anime/21/22/23/24/.... This would be useful for applications that want to download a bunch of anime data and then persist it locally. This is a more ideal solution than making a bunch of separate API calls. AnimeNewsNetwork implements batching here: https://www.animenewsnetwork.com/encyclopedia/api.php. Would something like this be possible?

That is a useful feature and it's definitely possible but isn't implemented due to performance related issues. One of them being; Jikan a web scraper for MyAnimeList, which doesn't have direct access to their database to be able to do what ANN achieves. The requests are not stored in a database on Jikan's side either (as per MAL's TOS) - it's temporarily cached for 3 days.
Making batch calls would mean making as many requests there's in the batch, which will most likely get Jikan rate-limited temporarily by MyAnimeList - becoming an inconvenience to other users making use of the API.
Applications shouldn't have an issue with the current method as they can asynchronously request the data from Jikan, rather having to fetch one huge request in order to display them all.

Gotcha, I wasn't 100% how Jikan worked. I realize this isn't really possible with MAL's rate-limiting. Thanks for the quick response!


Explain Course Formats

What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/2836
Description (What does it do?)
Adds in a link to the FAQ for self paced and instructor paced courses as well as a badge for instructor paced.
Screenshots (if appropriate):

How can this be tested?
Have courses of the various formats, ensure the link shows as appropriate
Figma: https://www.figma.com/file/Gs4zIhOFv5gVvafawwl6PF/MITx-Online?type=design&node-id=4092-3869&mode=design&t=ONalqUFtLjNoci7G-0

This is ready for review, only the links are incorrect as we're waiting on cs for them. Since the rest is done, it's worth reviewing contingent on those links.


Add prefix parameter in loggers

What does this PR do?

Fixes # (issue)
Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In in short, see following bullet-list:

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?
Make sure you had fun coding 🙃

Hello @rohitgr7! Thanks for opening this PR.

In the file pytorch_lightning/loggers/base.py:

Line 307:1: W293 blank line contains whitespace

In the file pytorch_lightning/loggers/wandb.py:

Line 85:20: E252 missing whitespace around parameter equals
Line 85:21: E252 missing whitespace around parameter equals

Do see the Hitchhiker's guide to code style

not sure why some tests are getting cancelled

@awaelchli do you know why some tests here are getting canceled here?? Something wrong with mock tests here?

@tchaton make sure tests here are good?

@awaelchli can't get the tests working. Not familiar with the error it's raising. Can you check, please?? Thanks.

ok, I try to find what's wrong :)


Google Play Protect detect SpamBlocker as a malicious app since v1.7 release

Bonjour,
I'm opening this issue but it's not really something related to a malfunction or an enhancement request.
I've just installed last published release (v1.7) on F-Droid this morning and I have been warned by Google Play Protect that your app is dangerous to be installed.
It makes the app considered malicious and I see regular notifications on Google Play Store requesting to uninstall your app.
I reverted back to v1.5 and no more alert was raised anymore.
Same with v1.6, no warning alert.
But as soon as I try to install v1.7, warnings and alerts come back.
I have made the same exercise with GitHub releases and conclusions are the same.
It seems something doesn't fit Google Play Protect rules, probably for something in which it overreact, but I think you should take a look about this aspect.
Many SpamBlocker users comes from "Yet Another Call Blocker" app that ended with the same Google Play Protect restrictions but it isn't maintained anymore (no update since more than 3 years) and some users are afraid of using it because of these alerts and warnings.
It will be sad if your app ends with less success than it deserves just because some GAFAM group has decided that your app doesn't follow their SW specification...
I don't think there's any emergency or mandatory request to update the app according to this remark.
Consider this message more as a notification that can explain why there could be less download or user of your app in the next months.
What do you think?
Thank you for your attention.

Thanks for the feedback. I can reproduce this with v1.7.
This is strange, these releases had been tested on my phone, but I didn't see that warning previously. And I just tested with the latest tag which was built yesterday and there is no warning, I haven't removed any feature or permission, only added more features.
Maybe because the v1.7 is now released on F-Droid, and Google verifies apps on F-Droid, only this can explain everything. I think a workaround is to publish this on Play Store as well (is google forcing devs to publish apps on Play Store?...)
I'll keep an eye on the next v1.8, see if it becomes malicious right after F-Droid merges it. For the v1.7, I'll try every commit to find out which one causes the problem, it worn't help if the warning is based on apk signature, but I'll try it anyway.

Don't stress yourself for Google publishing...
F-Droid is an alternative that fits people looking for another way to use their devices in compliance with open source solutions and make the link between us and talented people as you are.
If Google does restrict some external app to be part of their store, why not.
But blaming an app being malicious with no evidence of that, it's another story that I really don't appreciate.
Keep up the good job!

I also install these releases on my phone, I'm the first one who installed them, but I've never seen any popup at the time.
I just tested v1.7, v1.8, and latest version on two phones with different google accounts (different countries)

v1.7 shows popup warning on one phone but not the other
v1.8 and latest version, no popup at all

But my popup shows "it's harmful and blocked", not "the app is unknown from its database and it needs to be scanned".
Maybe it's also based on country or device, I'm a bit confused. But since all issues have been completed, I'm working on publishing to play store.

It's incredibly complex to publish an app on Google Play, it took even longer than developing this app, but finally it's live.
https://play.google.com/store/apps/details?id=spam.blocker

Well, Google exposes the personal information of individual developers. For my privacy, I unpublished this app, let's just ignore that installation warning :)


tooltip not working as body has other elemnts

In body I have left menu bar and lot of other elements in BODY before div#venn
with this line
var tooltip = d3.select("body").append("div")
        .attr("class", "venntooltip");

tooltip hides behind the left menu bar
and if I use following in  i.e use #venn instead of body
var tooltip = d3.select("#venn").append("div")
        .attr("class", "venntooltip");

Than tooltip shows at bottom of graph (my page),
Why tooltip not on of graph?
How to handle such case

There is some CSS that goes along with the tooltip example: http://benfred.github.io/venn.js/examples/intersection_tooltip.html
With the CSS there, the tooltip should be invisible when first added - and only made visible when the mouse moves over the diagram.
It works for me at least - here is an example of a page with lots of other elements:
http://www.benfrederickson.com/distance-metrics/

thanks for reply
what did you use
var tooltip = d3.select("body").append("div")
.attr("class", "venntooltip");
still body or something else?
any any other calculation

thanks for reply,
venntooltip class was not picked,
Working fine now

How did you fix it  ?? What is the css ? Because i am facing the same issue.


Hover Board

Prerequisites

[X] I am a GSSoC-22 Participant
[X] I checked to make sure that this issue has not already been filed

Description
Hover board is a site which changes box color on hovering and it will show you the path or area which you hovered.
Made with help of HTML,CSS,JS.
Tech Stack
Web Development

@rajprem4214 Go for it. Good Luck 👍


What's the state of support for LoDash 4?

Hello :)
Does anyone know the state of support for LoDash 4.x? They made quite a few breaking changes with 4.x - including removing 'thisArg' parameters from most methods.

To try it out, just install from scratch and run the tests.
Lodash version is floating (https://github.com/kmalakoff/knockback/blob/master/package.json#L79) so easy to find out.

lodash 4.x seems to work fine with the automated tests.

@far-blue I've published Knockback 1.2.0 with updates to support the simplifications from LoDash 4. Sorry for the delay...


make necks stack items

Necks need to stack items
also do a verification check before deleting items

This is done in 2.1.0


chore(main): release 0.7.1

:robot: I have created a release beep boop
0.7.1 (2022-11-23)
Bug Fixes

dockerfile: use go 1.19 (923f35f)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/kakao/varlog/releases/tag/v0.7.1 :sunflower:


please provide your dfgan implementation for celebA

I'm sorry that I may have leaked the code, but I'm leaving home to work now, and the desktop computer with training records is at home. If I remember, it will be passed on at the Spring Festival.