Builer with required fields for PreparedGetListOfObjects

@artem-zinnatullin PTAL
As we previously discussed:

at first step client should specify query,
then mapFunc,
he can prepare.

Great!

Refs #218


Is there a CLI demo invocation, or do I just use it as a library?

I'm working through getting a venv set up in the folder, and making the necessary corrections to get the tests to run, but still having a little difficulty trying to suss out how to use/view the examples.
Are they runnable as they are? Is there a general command line invocation with the path/name of an example that will do it?
A little more hand-holding is needed in the docs, please.

They should be runnable as is. I'm using VSCode to view the code, and the evolutionary outputs can be found in the terminal of the running script. If you just run one of the example .py programs in python, it should work. Hope this answers your question.


Upgrade to ghc-8.10.3 in Github Actions

description

[ ] describe solution here ..

checklist

[ ] compiles (cabal v2-build or stack build)
[ ] tests run successfully (cabal v2-test or stack test)
[ ] documentation added
[ ] link to an issue
[ ] add milestone (the current sprint)

superceeded by #630


Wrong imports after repo move

~/.../github.com/jaegertracing/jaeger-client-go [jaeger-client-go:master]$ go build
baggage_setter.go:20:2: use of internal package not allowed
zipkin_thrift_span.go:24:2: use of internal package not allowed
~/.../github.com/jaegertracing/jaeger-client-go [jaeger-client-go:master]$

...because the import is still based on github.com/uber/jaeger-client-go

The correct import path is stated in the readme.


Message poller is stopping for a specific deserialization error when consuming SQS messages

Type: Bug
Component: SQS
Describe the bug
Spring Cloud AWS 3.1.0.
The message poller stops after trying to process some messages from a queue when they result in a "No class found" error during deserialization, causing messages not to be sent to DLQ after "maximum receives".
Scenario: Class that represents the message was moved to a different package and there are still old messages to be processed by new service version.
Related logs:
i.a.c.s.l.s.AbstractPollingMessageSource : Error processing message
java.lang.IllegalArgumentException: No class found with name com.sample.old.TestObject

Sample

Create a record TestObject:

package com.sample.new;

public record TestObject(
    String name
) {
}

Create a simple SQS listener:

  @SqsListener(value = {"test-type-queue"}, acknowledgementMode = SqsListenerAcknowledgementMode.MANUAL)
  public void processMessage(@Valid TestObject message, Acknowledgement acknowledgment) {
    // process message
    acknowledgment.acknowledge();
  }

Post 2 messages to the queue: {"name":"custom name"}, with JavaType header: com.sample.old.TestObject.

Hi @rerodrig.
Not sure what you mean. Are you saying that after these two errors, no new messages are polled from the queue?
Can you share the full stack trace with the error?
Thanks.

Hi @tomazfernandes,
After some errors for both messages, no new messages are polled from the queue.
Here is the stack trace:
2024-02-15T17:09:46.180Z ERROR 19269 --- [test-sqs] [c-response-5-12] i.a.c.s.l.s.AbstractPollingMessageSource : Error processing message

java.lang.IllegalArgumentException: No class found with name com.sample.old.TestObject
	at io.awspring.cloud.sqs.support.converter.AbstractMessagingMessageConverter.defaultHeaderTypeMapping(AbstractMessagingMessageConverter.java:197)
	at io.awspring.cloud.sqs.support.converter.AbstractMessagingMessageConverter.getTargetType(AbstractMessagingMessageConverter.java:179)
	at io.awspring.cloud.sqs.support.converter.AbstractMessagingMessageConverter.convertPayload(AbstractMessagingMessageConverter.java:170)
	at io.awspring.cloud.sqs.support.converter.AbstractMessagingMessageConverter.toMessagingMessage(AbstractMessagingMessageConverter.java:153)
	at io.awspring.cloud.sqs.listener.source.AbstractMessageConvertingMessageSource.convertMessage(AbstractMessageConvertingMessageSource.java:91)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1708)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682)
	at io.awspring.cloud.sqs.listener.source.AbstractMessageConvertingMessageSource.convertMessages(AbstractMessageConvertingMessageSource.java:85)
	at java.base/java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:646)
	at java.base/java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:510)
	at java.base/java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:2179)
	at software.amazon.awssdk.core.internal.http.pipeline.stages.AsyncApiCallMetricCollectionStage.lambda$execute$0(AsyncApiCallMetricCollectionStage.java:58)
	at java.base/java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:863)
	at java.base/java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:841)
	at java.base/java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:510)
	at java.base/java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:2179)
	at software.amazon.awssdk.core.internal.http.pipeline.stages.AsyncApiCallTimeoutTrackingStage.lambda$execute$2(AsyncApiCallTimeoutTrackingStage.java:69)
	at java.base/java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:863)
	at java.base/java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:841)
	at java.base/java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:510)
	at java.base/java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:2179)
	at software.amazon.awssdk.core.internal.http.pipeline.stages.AsyncRetryableStage$RetryingExecutor.lambda$attemptExecute$1(AsyncRetryableStage.java:177)
	at java.base/java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:863)
	at java.base/java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:841)
	at java.base/java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:510)
	at java.base/java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:2179)
	at software.amazon.awssdk.core.internal.http.pipeline.stages.MakeAsyncHttpRequestStage.lambda$execute$0(MakeAsyncHttpRequestStage.java:110)
	at java.base/java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:863)
	at java.base/java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:841)
	at java.base/java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:510)
	at java.base/java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:2179)
	at software.amazon.awssdk.core.internal.http.pipeline.stages.MakeAsyncHttpRequestStage.completeResponseFuture(MakeAsyncHttpRequestStage.java:253)
	at software.amazon.awssdk.core.internal.http.pipeline.stages.MakeAsyncHttpRequestStage.lambda$executeHttpRequest$3(MakeAsyncHttpRequestStage.java:167)
	at java.base/java.util.concurrent.CompletableFuture.uniHandle(CompletableFuture.java:934)
	at java.base/java.util.concurrent.CompletableFuture$UniHandle.tryFire(CompletableFuture.java:911)
	at java.base/java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:482)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)

After 10 attempts to process the messages (5 for each message), they stay in the queue and the following logs are displayed:
2024-02-15T17:09:46.970Z TRACE 19269 --- [test-sqs] [Container#0-0-1] c.s.l.a.BatchingAcknowledgementProcessor : Scheduling next acknowledgement execution in 1000ms
2024-02-15T17:09:47.975Z TRACE 19269 --- [test-sqs] [Container#0-0-1] c.s.l.a.BatchingAcknowledgementProcessor : Scheduling next acknowledgement execution in 1000ms
2024-02-15T17:09:48.976Z TRACE 19269 --- [test-sqs] [Container#0-0-1] c.s.l.a.BatchingAcknowledgementProcessor : Scheduling next acknowledgement execution in 1000ms
2024-02-15T17:09:49.980Z TRACE 19269 --- [test-sqs] [Container#0-0-1] c.s.l.a.BatchingAcknowledgementProcessor : Scheduling next acknowledgement execution in 1000ms
2024-02-15T17:09:50.985Z TRACE 19269 --- [test-sqs] [Container#0-0-1] c.s.l.a.BatchingAcknowledgementProcessor : Scheduling next acknowledgement execution in 1000ms
2024-02-15T17:09:51.985Z TRACE 19269 --- [test-sqs] [Container#0-0-1] c.s.l.a.BatchingAcknowledgementProcessor : Scheduling next acknowledgement execution in 1000ms
2024-02-15T17:09:52.989Z TRACE 19269 --- [test-sqs] [Container#0-0-1] c.s.l.a.BatchingAcknowledgementProcessor : Scheduling next acknowledgement execution in 1000ms
2024-02-15T17:09:53.994Z TRACE 19269 --- [test-sqs] [Container#0-0-1] c.s.l.a.BatchingAcknowledgementProcessor : Scheduling next acknowledgement execution in 1000ms
2024-02-15T17:09:54.995Z TRACE 19269 --- [test-sqs] [Container#0-0-1] c.s.l.a.BatchingAcknowledgementProcessor : Scheduling next acknowledgement execution in 1000ms
2024-02-15T17:09:55.592Z TRACE 19269 --- [test-sqs] [essage_source-2] i.a.c.s.l.SemaphoreBackPressureHandler   : Not able to acquire 10 permits in 10000 milliseconds for io.awspring.cloud.sqs.sqsListenerEndpointContainer#0-0 in TM HIGH. Permits left: 0
2024-02-15T17:09:55.592Z TRACE 19269 --- [test-sqs] [essage_source-2] i.a.c.s.l.s.AbstractPollingMessageSource : No permits acquired for queue test-type-queue
2024-02-15T17:09:55.592Z TRACE 19269 --- [test-sqs] [essage_source-2] i.a.c.s.l.s.AbstractPollingMessageSource : Requesting permits for queue test-type-queue
2024-02-15T17:09:55.592Z TRACE 19269 --- [test-sqs] [essage_source-2] i.a.c.s.l.SemaphoreBackPressureHandler   : Acquiring 10 permits for io.awspring.cloud.sqs.sqsListenerEndpointContainer#0-0 in TM HIGH
2024-02-15T17:09:55.999Z TRACE 19269 --- [test-sqs] [Container#0-0-1] c.s.l.a.BatchingAcknowledgementProcessor : Scheduling next acknowledgement execution in 1000ms
2024-02-15T17:09:56.999Z TRACE 19269 --- [test-sqs] [Container#0-0-1] c.s.l.a.BatchingAcknowledgementProcessor : Scheduling next acknowledgement execution in 1000ms
2024-02-15T17:09:58.000Z TRACE 19269 --- [test-sqs] [Container#0-0-1] c.s.l.a.BatchingAcknowledgementProcessor : Scheduling next acknowledgement execution in 1000ms
2024-02-15T17:09:59.003Z TRACE 19269 --- [test-sqs] [Container#0-0-1] c.s.l.a.BatchingAcknowledgementProcessor : Scheduling next acknowledgement execution in 1000ms
2024-02-15T17:10:00.007Z TRACE 19269 --- [test-sqs] [Container#0-0-1] c.s.l.a.BatchingAcknowledgementProcessor : Scheduling next acknowledgement execution in 1000ms
2024-02-15T17:10:01.009Z TRACE 19269 --- [test-sqs] [Container#0-0-1] c.s.l.a.BatchingAcknowledgementProcessor : Scheduling next acknowledgement execution in 1000ms
2024-02-15T17:10:02.014Z TRACE 19269 --- [test-sqs] [Container#0-0-1] c.s.l.a.BatchingAcknowledgementProcessor : Scheduling next acknowledgement execution in 1000ms
2024-02-15T17:10:03.015Z TRACE 19269 --- [test-sqs] [Container#0-0-1] c.s.l.a.BatchingAcknowledgementProcessor : Scheduling next acknowledgement execution in 1000ms
2024-02-15T17:10:04.019Z TRACE 19269 --- [test-sqs] [Container#0-0-1] c.s.l.a.BatchingAcknowledgementProcessor : Scheduling next acknowledgement execution in 1000ms
2024-02-15T17:10:05.024Z TRACE 19269 --- [test-sqs] [Container#0-0-1] c.s.l.a.BatchingAcknowledgementProcessor : Scheduling next acknowledgement execution in 1000ms
2024-02-15T17:10:05.597Z TRACE 19269 --- [test-sqs] [essage_source-2] i.a.c.s.l.SemaphoreBackPressureHandler   : Not able to acquire 10 permits in 10000 milliseconds for io.awspring.cloud.sqs.sqsListenerEndpointContainer#0-0 in TM HIGH. Permits left: 0
2024-02-15T17:10:05.597Z TRACE 19269 --- [test-sqs] [essage_source-2] i.a.c.s.l.s.AbstractPollingMessageSource : No permits acquired for queue test-type-queue
2024-02-15T17:10:05.597Z TRACE 19269 --- [test-sqs] [essage_source-2] i.a.c.s.l.s.AbstractPollingMessageSource : Requesting permits for queue test-type-queue
2024-02-15T17:10:05.597Z TRACE 19269 --- [test-sqs] [essage_source-2] i.a.c.s.l.SemaphoreBackPressureHandler   : Acquiring 10 permits for io.awspring.cloud.sqs.sqsListenerEndpointContainer#0-0 in TM HIGH

Thanks.

Yup, that's a bug @rerodrig, thanks for reporting and for the detailed logs!
When message conversion throws an error the framework does not release the permits so eventually it runs out.
I have an acknowledgement issue in the pipeline to fix that seems more urgent and should be able to look into this soon enough.
Thanks.

Hey @tomazfernandes, curious if there are any updates on this? I think this bug is something my team has observed as well.

Hi @liwamdaman, no updates,I haven't had the time so work on this yet.
If anyone would like to submit a PR with a fix I'd be happy to review and merge it.


[FIX] Add support for Windows

Description
For some reason in Windows, the docker is not able to resolve internal docker host DB. One way to resolve this is to use DATABASE_HOST as host.docker.internal which will resolve the host from the docker host's IP

@pigfly Do not merge this Yet. Need to verify this in Windows Home docker toolbox first!


Transfer to https://github.com/LivingDocumentation ?

Do you want to participe to https://github.com/LivingDocumentation ?
if you are ok, dot-diagram could be moved to this organisation and publish to maven central

I've just initiated the transfer of dot-diagram to the LivingDocumentation
organization.
On Wed, Nov 16, 2016 at 8:52 PM, Benoît Prioux<EMAIL_ADDRESS>wrote:

Do you want to participe to https://github.com/LivingDocumentation ?
if you are ok, dot-diagram could be moved to this organisation and publish
to maven central
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/cyriux/dot-diagram/issues/5, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABCP5IdgMxBklrE0M1GzJU3isjB10j9Qks5q-17igaJpZM4K0XbC
.

--
Cyrille Martraire
Deliberate Designer
Author of the book: https://leanpub.com/livingdocumentation
Founder of the Software Craftsmanship Paris
http://www.meetup.com/paris-software-craftsmanship community
Co-founder of http://arolla.fr
Follow me: @cyriux http://twitter.com/cyriux
Tel: +33 (0)6 09 33 94 70

Great ! Welcome !

Nice ! Welcome !


[Bug] Major -  podkrepi.bg/"Регистарция" when the user switches bethwen BG and EN version the form data is deleted

Describe the bug
when the user switches bethwen BG and EN version the previously entered form data is deleted
To Reproduce
Steps to reproduce the behavior:

Go to Home page
Click on "Регистрация"
Enter some data in the form
Change the version form BG to EN or vice versa

Expected behavior
The already entered data is preserved, not deleted
Desktop (please complete the following information):

OS: Windows 10
Browser Edge
Version Version 98.0.1108.50 (Official build) (64-bit)

I consider this a normal behavior as user leaves the page on language change the same way as they do when they click home button.

closing as default behavior of Keycloak that we won't be able to change. Also quite unlikely to create any usability problems as language selection is usually done before the start of entering text.


⚠ TROJAN 🇭🇰 Hong Kong HKE 1 has degraded performance

In 11af495, TROJAN 🇭🇰 Hong Kong HKE 1 (https://hkt-1.opensvr.net/) experienced degraded performance:

HTTP code: 200
Response time: 26135 ms

Resolved: TROJAN 🇭🇰 Hong Kong HKE 1 performance has improved in bf3cdb6.


Error on installing rmwc

What RMWC Version are you using?

latest

What build system are you using?

npm

What are the steps to reproduce the bug?
In my packages.json file, there is a reference to rmwc: "latest". When I run "npm install", I get the following error:
npm ERR! code ETARGET
npm ERR! notarget No matching version found for<EMAIL_ADDRESS>npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.
npm ERR! notarget
npm ERR! notarget It was specified as a dependency of '@rmwc/grid'
npm ERR! notarget
I checked MDC's repository, and there is no version 0.40 of layout-grid. Not all packages has been updated to 0.40, and layout-grid is one of those wich isn't.
I also checked rmwc repository and 5 days ago a commit updating several packages to reference version 0.4 of the corresponding mdc's package was made.

You're faster than I am :). Already put the patch out.
Had to do with inconsistent versioning of the MDC dependencies

:-)
Thanks!


StreamlitAPIException. Plesae advise me, Thanks.

StreamlitAPIException: No such component directory: 'D:_streamlit\program\streamlit_webrtc\frontend\build'
Traceback:
File "D:_streamlit\program\app.py", line 17, in
from streamlit_webrtc import (
File "D:_streamlit\program\streamlit_webrtc_init_.py", line 10, in
from .component import (
File "D:_streamlit\program\streamlit_webrtc\component.py", line 74, in
_component_func = components.declare_component("webrtc_streamer", path=build_dir)

Search the past issues.
https://github.com/whitphx/streamlit-webrtc/issues/399#issuecomment-909815583


Fix issue 71

Would be something like this then right @rmunn ?

That's what I was thinking of, though using id.ToString() changes the function signature of withId. Previously it required id to be a string, and now it allows id to be any type. I think the intended signature of withId is to require id to be a string, though @Krzysztof-Cieslak would probably know more about that.

Not having id as a string actually makes more sense. Thanks a lot for fix.


Create GITrepo-sync

Why:
Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

[x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[x] For content changes, I have completed the self-review checklist.

Thank.you
On Sun, Jun 18, 2023, 4:46 a.m. welcome[bot] @.***>
wrote:

Thanks for opening this pull request! A GitHub docs team member should be
by to give feedback soon. In the meantime, please check out the contributing
guidelines https://github.com/github/docs/blob/main/CONTRIBUTING.md.
—
Reply to this email directly, view it on GitHub
https://github.com/github/docs/pull/26079#issuecomment-1596113517, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/BAFCUCCHI3AH5QJLYK67WRDXL3S7TANCNFSM6AAAAAAZK2X5FQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Fixed #4797 : Peer review: Add one more choice to the list, and do not submit if no reason selected

Fixes #4797
Peer review: Add one more choice to the list, and do not submit if no reason selected

Thanks a lot! :-)
For UI pull requests, could you please send screenshots showing the results? Here is what I see:

I updated the copyright option and added reason 4 as No freedom of panorama which is working fine , but the scope option is also adding reason 4 as null , therefore this problem is happening ....  I will solve it soon

@nicolas-raoul  I updated the copyright option and added reason 4 as No freedom of panorama which is working fine , but the (out of scope) option is also adding reason 4 as null , therefore this problem is happening ....
can you please guide me how to solve this , I have tried but couldn't figure out .
for me the best option will be if I also add a Reason 4 for(out of scope), as you wish.

Do you mean that in the current master, each of the step must have the exact same number of possible reasons?
That does not sound ideal, even though I guess that saves some lines of code.
How about designing a system that can take different numbers of reasons at each step?

Could you please rebase on master? A related area has been changed in master. Thanks!

Could you please rebase on master? A related area has been changed in master. Thanks!

yes done ,

@nicolas-raoul  for now i am unable to remove the REASON 4 in out of scope option . I have tried many ways but it is not happenign . what should I do now ?

How about designing a system that can take different numbers of reasons at each step?
Or feel free to unassign this issue and work on a different one if you prefer.


Fix: No error message when entering a invalid email

Details

No error message when entering a invalid email for a new chat
Fixed Issues

$ #16884
PROPOSAL: #16884 (comment)
Tests

Login with any account
Click on the green plus icon and choose New chat
Enter a invalid email (i.e<EMAIL_ADDRESS>Verify "Invalid email" error message is displayed
Switch to Spanish and verify 'Email inválido' is displayed

[x] Verify that no errors appear in the JS console

Offline tests
Same above

QA Steps

Login with any account
Click on the green plus icon and choose New chat
Enter a invalid email (i.e<EMAIL_ADDRESS>Verify "Invalid email" error message is displayed
Switch to Spanish and verify 'Email inválido' is displayed

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
Screencast from 11-04-2023 15:00:12.webm

Mobile Web - Chrome
https://user-images.githubusercontent.com/129500732/231129413-328decc8-be81-4117-978a-3ca02ac0a901.mp4

Mobile Web - Safari

Desktop

iOS

Android
https://user-images.githubusercontent.com/129500732/231130367-8fb844d5-564e-4d59-928a-fb6c33a9a4f3.mp4

@beamanator Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@Beamanator This is my first PR, please help to take a look at it and enable 10 workflows awaiting approval

@neil-marcellini assigning you since it seems you were assigned on the original issue (thanks for pointing that out @fedirjh )

@Beamanator Should we hold this PR until the correct copy is confirmed

@neil-marcellini I saw davidcardoza confirmed that the message of invalid email is "Invalid email". Actually it's set to Invalid email in English and Email inválido in Spanish
https://github.com/Expensify/App/issues/16884#issuecomment-1510423279
And I moved it into messages please check again

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.1-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.1-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.1-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


videodelivery.net - HTTP Error 403: Forbidden

Site used to work, but now doesn't.
Using youtube-dl version 2021.03.03, video plays fine in the browser, no special characters, can't see a similar issue listed.
youtube-dl reports 403 errors:
WARNING: Could not send HEAD request HTTP Error 403: Forbidden
and
ERROR: Unable to download webpage: HTTP Error 403: Forbidden
Full debug output attempting to download:
youtube-dl --verbose -r 1M -f 'bestvideo+bestaudio' -o 'videodelivery.%(ext)s' https://iframe.videodelivery.net/a184bc77dd28a5e27f13ffcccbffb48a
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'--verbose', u'-r', u'1M', u'-f', u'bestvideo+bestaudio', u'-o', u'videodelivery.%(ext)s', u'https://iframe.videodelivery.net/a184bc77dd28a5e27f13ffcccbffb48a']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2021.03.03
[debug] Python version 2.7.17 (CPython) - Linux-4.15.0-129-generic-x86_64-with-Ubuntu-18.04-bionic
[debug] exe versions: ffmpeg 3.4.8, ffprobe 3.4.8
[debug] Proxy map: {}
[generic] a184bc77dd28a5e27f13ffcccbffb48a: Requesting header
WARNING: Could not send HEAD request to https://iframe.videodelivery.net/a184bc77dd28a5e27f13ffcccbffb48a: HTTP Error 403: Forbidden
[generic] a184bc77dd28a5e27f13ffcccbffb48a: Downloading webpage
ERROR: Unable to download webpage: HTTP Error 403: Forbidden (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 632, in _request_webpage
return self._downloader.urlopen(url_or_request)
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 2275, in urlopen
return self._opener.open(req, timeout=self._socket_timeout)
File "/usr/lib/python2.7/urllib2.py", line 435, in open
response = meth(req, response)
File "/usr/lib/python2.7/urllib2.py", line 548, in http_response
'http', request, response, code, msg, hdrs)
File "/usr/lib/python2.7/urllib2.py", line 473, in error
return self._call_chain(*args)
File "/usr/lib/python2.7/urllib2.py", line 407, in _call_chain
result = func(*args)
File "/usr/lib/python2.7/urllib2.py", line 556, in http_error_default
raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)

post the original URL.

Sent original URL and password via email.

Issue resolved by using --add-header 'Referer: https://' no code change needed.
Thank you!


Notification icon appear after app quit via task manager

I have slient mode enabled and the notification icon is hidden nicely when the app is in the background but once I quit the app via task manager, the notification icon appear.

@Bitneko Seems to be fixed already. I cannot reproduce anymore. If not just reopen the issue.


Codeunit 80 - OnBeforePostCustomerEntry

Hi,
Is it possible to add parameter in existing publisher: OnBeforePostCustomerEntry in codeunit 80?
Additional parameter is GenJnlPostLine and it should be pass by var.
LOCAL [IntegrationEvent] OnBeforePostCustomerEntry(VAR GenJnlLine : Record "Gen. Journal Line";VAR SalesHeader : Record "Sales Header";VAR TotalSalesLine : Record "Sales Line";VAR TotalSalesLineLCY : Record "Sales Line";CommitIsSuppressed : Boolean;PreviewMode : Boolean;VAR GenJnlPostLine : Codeunit "Gen. Jnl.-Post Line")

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Update videos.rst

Adding 3 new qhack videos to video page

Website build
Commit: 3424647c218cf60adcb0e3b60589484b8046254d
Circle build number: 603
Website zip: https://603-214003948-gh.circle-artifacts.com/0/tmp/qml_html.zip
Website url: https://603-214003948-gh.circle-artifacts.com/0/_build/html/index.html
Please double check the rendered website build to make sure everything is correct.

@co9olguy, what is the status of this PR? It looks like two of the new videos (Quantum Optimization in NISQ Devices and Beyond by Leonardo and Quantum Circuits as Machine Learning Models by Maria) aren't on YouTube, and your QHACK introduction is also no longer available

We'll need to do a quick triage and temporarily comment out videos that are not online at the moment


Add option for preferred position side

Currently preferred position takes only top or bottom as parameter. It would be ideal to support also right / left

Exactly! I'm implementing the spectrum components in flutter and the popover on the side is quite common on desktop applications: https://spectrum.adobe.com/page/popover/

Exactly! I'm implementing the spectrum components in flutter and the popover on the side is quite common on desktop applications: https://spectrum.adobe.com/page/popover/

OK, I understand. I would implement this feature as soon as possible.

Do we have any update for this.

any updates ?


Reading project settings in a module

Godot version: 3.1
Writing a custom module in C++, everything goes OK except reading project settings. Inside the module I'm trying to read a property as below:
ProjectSettings::get_singleton()->get("display/window/size/height")
but the returned value is a random number.

Are you sure it's not just returning an address?

Base on Godot's source code, the returning type of get is a Variant:
Variant get(const StringName &p_name, bool *r_valid = NULL) const;

I closed this because in my tests, I executed a script file and there was no settings (however it is strange), but having a regular project then there is settings.


Decide on (and convert to) indentation style

Some Python files in the repository are in two-spaces-per-level indentation, while PEP-8 (and Ansible as a whole) uses four-spaces-per-level. Which style should be used for this repository?

I was complaining about this exact same problem literally hours ago.

I personally prefer two-spaces indentation. Didn't really think about Ansible code as a whole which will probably matter if we try to bring it to the core.

Since our ultimate goal is to get this in upstream Ansible, we'll want to follow whatever their style guide is.


Complete documentation of various classes

This PR completes documentation for some random classes that were close to completion according to the 3.2 Docs Sprint stats. However LineEdit and ScrollBars were a trap, because they had documentable theme_items that weren't counted for the sprint :/
There are more classes like this, so I might make few more batch PRs (unless it's better to make one, then consider this WIP).

I pushed one more change for physics_jitter_fix.

Thanks!


V6 Alpha - iOS CI builds cannot resolve Pod dependencies

Bug
I have the V6 alpha installed my project and although it builds locally it is failing on CI.
For some reason, the dependency PromisesObjC is appearing twice in the Podfile.lock, even when I delete this file and the Pods directory before running pod install and pod update. There is no other dependency importing these, if I uninstall react-native-video these dependencies are gone.
  - PromisesObjC (2.2.0)
  - PromisesSwift (2.2.0):
    - PromisesObjC (= 2.2.0)

When I try and build this project on CI I get the following issue:
[!] CocoaPods could not find compatible versions for pod "PromisesObjC":
  In snapshot (Podfile.lock):
    PromisesObjC (= 2.2.0)
  In Podfile:
    PromisesSwift was resolved to 2.2.0, which depends on
      PromisesObjC (= 2.2.0)
None of your spec sources contain a spec satisfying the dependencies: `PromisesObjC (= 2.2.0), PromisesObjC (= 2.2.0)`.

How does this make any sense? Both versions are identical and yet it cannot resolve them.
I've also tried disintegrating the project and reinstalling with no luck.
Platform
iOS
Environment info
React native info output:
System:
    OS: macOS 13.1
    CPU: (6) x[64] Intel(R) Core(TM) i5-8500B CPU @ 3.00GHz
    Memory: 3.92 GB / 16.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 16.19.0 - ~/.nvm/versions/node/v16.19.0/bin/node
    Yarn: Not Found
    npm: 8.19.3 - ~/.nvm/versions/node/v16.19.0/bin/npm
    Watchman: Not Found
  Managers:
    CocoaPods: 1.11.3 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 22.2, iOS 16.2, macOS 13.1, tvOS 16.1, watchOS 9.1
    Android SDK: Not Found
  IDEs:
    Android Studio: Not Found
    Xcode: 14.2/14C18 - /usr/bin/xcodebuild
  Languages:
    Java: Not Found
  npmPackages:
    @react-native-community/cli: Not Found
    react: Not Found
    react-native: Not Found
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Library version: v6.0.0-alpha.4
Steps To Reproduce

npm ci on CI build
Installation fails

Expected behaviour

Pod installation complete!

Reproducible sample code
    - bundle install
    - npm ci

This will help https://www.youtube.com/watch?v=vVI7ZAZq5e0

Can you provide you package.json and a sample project. I suspect collision between dependencies...

Issue was resolved by insuring CI pipeline always ran pod install --repo-update


(Temporarily) build from a custom branch with push support

The package will now include
https://github.com/okta/okta-openvpn/pull/4.

Coverage remained the same at 100.0% when pulling 320bd3c0f39d830b16b3c86bccae3d4e50a37e9d on jdh-use-push-branch into ea928610226d27adba6852f1dd23885d8d18b14a on master.

Coverage remained the same at 100.0% when pulling 25570239d3ae29adeee5a227f6902f395ece54ef on jdh-use-push-branch into ea928610226d27adba6852f1dd23885d8d18b14a on master.

Coverage remained the same at 100.0% when pulling 739841bf40a6e982aec5f9ad7c9b6f6d5dbc3230 on jdh-use-push-branch into ea928610226d27adba6852f1dd23885d8d18b14a on master.


bug

Cannot read properties of undefined (reading 'outlet')

I have the same problem

您好，我已收到您的来信。


Stub the proxy endpoint as glider has been removed from the worker

When we removed the dependency on glider in the proxy tests, we also
removed glider from the worker. However, older versions of the tests
from ESR branches would still call this endpoint and expect a sane
response.
Fortunately, the old proxy tests were invalid and would always pass
even if glider wasn't working. ICMP traffic does not use the proxy.
So, we can just pretend to start a glider instance so the old tests
continue to run, even with an invalid result.
Change-type: patch
Signed-off-by: Kyle Harding<EMAIL_ADDRESS>See: https://github.com/balena-os/leviathan/pull/534

Leaving as draft until I have some time to test an old meta-balena branch against this branch of leviathan.

@balena-ci rebase

@balena-ci rebase

Testing on raspberrypi3 with suites from meta-balena v2.87.4 (pre https://github.com/balena-os/meta-balena/pull/2364) so the old proxy tests should not fail.

@balena-ci rebase

@balena-ci I self-certify!


stm32: Configure DAC using new pinctrl via DT

Add support for DT based pinmux configurations to the DAC driver.
Use the new DT facilities to configure DAC pinmux on all STM32 nucleo boards currently supporting the DAC.

Tested with nucleo_l073rz. However, pins are configured in analog mode by default anyway.

Thanks for this PR.
You could rebase since UART PR was merged, you'll therefore get all of the correct pinctrl DT included.
Here is a script to detect DAC compatible boards:
#!/bin/bash

pinmuxes=`find boards/arm/ -name "pinmux.c"`

#use Perl regex here to match with grep
#match for specific STM32 pinmux header, only used
#with ST based boards
match_stm32_pinmux="pinmux/stm32/pinmux_stm32.h"
match_peripheral_mux="dac\d+"

for pinmux in $pinmuxes; do

	is_stm32_pinmux=`cat $pinmux | grep -cP $match_stm32_pinmux`
	if [ $is_stm32_pinmux -eq 0 ]
	then
		continue
	fi

	periph_mux_count=`cat $pinmux | grep -cP $match_peripheral_mux`
	periph_matches=`cat $pinmux | grep -oP $match_peripheral_mux`
	if [ $periph_mux_count -ne 0 ]
	then
		board=`dirname $pinmux`
		echo $board : $periph_matches
	fi
done

Output for master is:
dev@ubuntu:~/zephyrproject/zephyr$ ./findDac.sh
boards/arm/nucleo_f091rc : dac1
boards/arm/nucleo_g431rb : dac1
boards/arm/nucleo_l073rz : dac1 dac1
boards/arm/nucleo_f207zg : dac1
boards/arm/nucleo_l152re : dac1

Output for your PR:
dev@ubuntu:~/zephyrproject/zephyr$ ./findDac.sh

So you've ported all of the required boards, thanks 👍

@lochej Thanks for the check with the script. Rebased without conflicts.

Final update using ST_STM32_DT_INST_PINCTRL after merged PR #29057 is done. Maybe @erwango wants to have a final look?


Feature request BNO055

Could BNO055 be added https://registry.platformio.org/libraries/adafruit/Adafruit BNO055/installation
https://www.smart-prototyping.com/Zio-9DOF-IMU-BNO055.html

Just spotted https://github.com/linorobot/bno080_micro_ros unclear how to use it though

@samuk I'm using BNO055 .. not pretty code but it works
imu_bno055.zip


Refactor/rollup and more

This PR addressed the following:

[x] Refactors the project to utilize rollup instead of webpack.

[x] Optimizes the build and reduces the bundle size

[x] Adds docs

[x] Fix all pipelines (verify, release, gh-pages)

@kherP I fixed the build, pipelines and all. I also tested the package. All good. Let's release and see.

:tada: This PR is included in version 1.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


date_time_create_from_format_call should be marked risky

Bug report
date_time_create_from_format_call should be marked as risky because it fundamentally changes the result.
We actually had code for checking license expirations, boling down to if( time() - \DateTime::createFromFormat('Y-m-d', '2022-02-11')->getTimestamp() > ONE_WEEK) {…} that depended on the non-! behaviour and this burnt us.
Code snippet that reproduces the problem
The return values do not match
https://3v4l.org/SvBZc
<?php

echo \DateTime::createFromFormat('Y-m-d', '2022-02-11')->format('r');
echo "\n";
echo \DateTime::createFromFormat('!Y-m-d', '2022-02-11')->format('r');

Thanks for reporting, marking the rule as risky sounds good to me :+1:


Nested tensor warning

The transformer logs this on creation:
UserWarning: enable_nested_tensor is True, but self.use_nested_tensor is False because encoder_layer.norm_first was True
There are two things we can do about it:

To silence the error message but nothing else, we can add enable_nested_tensor=False here.
Or we can set norm_first=False here.

I don't know what the consequences of the latter are, really (I have no intuitions about when to norm) so I piloted it and it doesn't seem to affect performance much.

I posted a query about it here but nobody's responded.

@Adamits maybe you can give me your thoughts on #224 vs #225 when you have a cchance. I am not seeing a huge performance difference.

So using norm first comes form this paper: https://arxiv.org/pdf/2002.04745. I had understood this to still be the standard but have not thought much about it in a while. What performance diffs did you see?
Also, if I understand correctly, removing this allows us to enable nested tensors, which gives a better runtime efficiency, is that right?

Nested tensors are a prototype feature in PyTorch; if certain conditions are met, they are used in the transformers implementation. I believe what actually happens is that it uses this nested tensor container the temporary data created during a forward pass.
There is an API advantage in that you can do certain operations across all the tensors grouped into the nested tensor type, but since this all happens within nn.TransformerEncoder and since we don't care much about the internal complexity of that class, this is irrelevant to us.
There is a potential performance advantage in that the tensors grouped into the nested tensor class are all adjacent in VRAM and some operations can be done with memory views instead of memory copies. I am not seeing a difference on my desktop; I do get slightly different results (though not in any meaningful direction) probably because norm_first does something different.
When I run transformers on my home GPU (an RTX 1660, which is by all accounts an old one), I get really bad performance: sanity-checking data loaders takes forever, and when it fires up the second worker to load the validation data, it also freezes the world for a while. This is not true with: rather small data sets, LSTMs, or if I do the computation on CPU. This is why I'm attending to transformer performance. It might be useful for someone with a different GPU to do side-by-side comparison of #224 to HEAD and/or #225.
I also want to silence any warning a user could do something about: this is not something our users can do anything about, so it should be silenced. #224 does it by disabling norm_first, which allows us to take the nested tensor "path" through the transformer encoder. #225 silences the warning by saying that we don't want to use nested tensors anyways. There is a third possibility, though I don't love it: we have a flag --norm_first (and --no_norm_first) such that if true, we take the non-nested path (and silence the warning) if false, we take the nested path (and don't norm first), and if we're not using a transforrmer encoder, neither of the above apply.
I'll read the paper in the meantime.

This is all really really interesting and i'd like to learn more and test this as well, though I do not have time ATM. I will note that I had always assumed our transformer bottleneck was with inference (which would track with the data-loader sanity checking---I believe PTL runs 2 evaluation steps there.). Indeed I had a fork where I added KV-caching for inference and it seemed to 2-3x my runtime for a project where I was doing constant eval, but I found a bug in the KV-caching that I never solved and the fork got extremely stale.

One simple possibility is to merge #225, which just silences the scary warning but doesn't otherwise change current behavior, and then investigate #224 at lower priority as an alternative.


empty bed and .tsv file

Hey,
Trying to run degenotate on a folder contacting a fasta file,
Everything seems to work fine but I get an error at the end and my .bed and .tsv files are empty.
Any help will be appreciated!
Thanks
adding the output:
./degenotate/degenotate.py -s fasta_files/ -o annotated
Welcome to degenotate -- Degeneracy annotation for coding transcripts.
Version 1.2.2 released on June 2023
degenotate was developed by Timothy Sackton, Gregg Thomas
Website:       https://github.com/harvardinformatics/degenotate
The date and time at the start is:  08.26.2023 | 13:16:33
Using Python executable located at: /home/labs/bfreich/shaharr/project/conda_envs/degenotate/bin/python3.10
Using Python version:               3.10.12
The program was called as:          ./degenotate/degenotate.py -s fasta_files/ -o annotated

INPUT/OUTPUT INFO:
Sequence directory:                   /home/labs/bfreich/shaharr/WGS2_NovaSeq_290323/degenotate/fasta_files
Output directory:                     annotated
Per-site degeneracy output:           annotated/degeneracy-all-sites.bed
Transcript count output:              annotated/transcript-counts.tsv
Log file:                             annotated.log
OPTIONS INFO:
Option                                Current setting               Current action
-m                                    3                             Transcripts shorter than this length will be ignored by degnotate.
--quiet                               False                         Time, memory, and status info will be printed to the screen while degenotate is running. ------------------------------------------------------------------------------------------------------------------------------------------------------
Date        Time      Current step                                      Status                                  Elapsed time (s)    Step time (s) ------------------------------------------------------------------------------------------------------------------------------------------------------
08.26.2023  13:16:33  Reading CDS FASTA file(s)                         In progress...
08.26.2023  13:16:33  Reading CDS FASTA file(s)                         Success: 1 CDS read                     0.01327             0.00415
08.26.2023  13:16:33  Caclulating degeneracy per transcript             Processed 0 / 1 transcripts...
Traceback (most recent call last):
File "/home/labs/bfreich/shaharr/WGS2_NovaSeq_290323/degenotate/./degenotate/degenotate.py", line 94, in
globs = degen.processCodons(globs)
File "/home/labs/bfreich/shaharr/WGS2_NovaSeq_290323/degenotate/degenotate/degenotate_lib/degen.py", line 418, in processCodons
OUT.writeBed(transcript_output['bed'], bedfile, globs['annotation'][transcript]['strand']);
KeyError: 's288c'

Hi @rezenman,
I can replicate this error on our test data, so it appears to be a bug in our code for processing a directory of transcript CDS files. Working on a fix now - stay tuned. Thanks for reporting.
Tim

Hi @rezenman,
I've pushed an update to the 'develop' branch that fixes this issue in our test data. Can you please checkout this branch and see if it fixes the issue for you before I close this issue?
If you have installed degenotate via conda, you will need to clone a new version of degenotate for testing. Since your use does not require any dependencies, you can just do this via git clone -b develop https://github.com/harvardinformatics/degenotate and then you can cd to the degenotate directory and run with python degenotate.py.
Let us know if this works, or if you are still having issues.
Tim

Hey,
Thanks for the update. It works perfectly!
Shahar


Mentions from minecraft to discord

I find out, that @a has effect as announce for everyone
while it must tag only minecrafters.
So, Full list:

Minecraft
Discord

@a
@Minecrafters

@all
@Minecrafters

@e
@everyone

@p
@here

@here
@here

@everyone
@everyone

@AnyRoleOrMention
@SameRoleOrMention

Firstly, role Minecrafter isn't defined in bot's config.
You're suggesting to add it and setting to setup it via bot command roles?

@MaxBQb I'd like your answer for my last comment

Em.. Insted of write my comment.. github override yours 👍 )

Anyway,  it is "quality of live" suggestion, I think, with normal priority, rather then low priority (because low often means never)

Eh, I can add it, it not big feature :)

You may also separate tasks like this:
Complexity: Hard | Medium | Easy
Time limits: Needed right now | Can wait | May stay not implemented forever
Amount of profit: Critical | Way more better | Better then nothing | No difference

For this task it is:
Easy, Can wait, Better then nothing
For me
And may be Way more better for those who don't playing minecraft but stay still on discord server.

Well.. they can find workarounds also.. that's why is can wait.. and..
Potentially forever :(


List API changes

This adds a number of improvements to the List API.

List<T> now implements std::Iter::FromIterator() (see #57)
List.append() no longer fails as unimplemented
Improves documentation and tests for List API

23139c8 should fix the build on CI - it was just versioning issues.


⚠ Fortnite has degraded performance

In 0274332, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1509 ms

Resolved: Fortnite performance has improved in 8183637.


Adding to scripts

Hey expressjs admins, I am not sure if you guys will decide to add this very minor change, just adding the debugger to the scripts.

Closing since I never heard back. If you want to make alterations feel free to make them and open a new PR of course!


I see you! (the request of the plug-in station)

Is anyone going to make a BDSx plug-in resource station? I think it's very convenient :)

I need to implement more API before the plug-in station.
I need more time.

The plugin system is published!
You can install it through npm or plugin-manager.bat/sh
Plugins: https://www.npmjs.com/search?q=%40bdsx%2F


vb.net examples

Would you know of any vb.net code that could be a starting point?
Any examples? Google has not identified any...
Would be fantastic!

Well, I tried Getting Started / First step.
Translated the code with http://converter.telerik.com.
It looked coherent, but I got this error back:

Reference required to assembly 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' containing the base class 'System.Object'. Add one to your project.

Any idea why this error comes up?
`Imports SpotifyAPI.Web
Imports SpotifyAPI.Web.Auth
Imports SpotifyAPI.Web.Enums
Imports SpotifyAPI.Web.Models
Class SurroundingClass
Private Shared _spotify As SpotifyWebAPI
Public Shared Sub Main(ByVal args As String())
    '_spotify = New SpotifyWebAPI() With {
    '    .UseAuth = False
    '}
    'Dim track As FullTrack = _spotify.GetTrack("3Hvu1pq89D4R0lyPBoujSv")
    'Console.WriteLine(track.Name)
End Sub

End Class`

So, I got a step further by referencing netstandard, but to no avail...

Namespace or type specified in the Imports 'netstandard' doesn't contain any public member or cannot be found. Make sure the namespace or the type is defined and contains at least one public member. Make sure the imported element name doesn't use any aliases.
Reference to a non-shared member requires an object reference.--

Code as above without comments

OK. After upgrading to new Newtonsoft, etc... I am not getting any error messages.
On the other hand, the string "track.Name" is empty.
No result?

Unauthenticated calls UseAuth = False are deprecated since 2017 by Spotify. (https://developer.spotify.com/community/news/2017/01/27/removing-unauthenticated-calls-to-the-web-api/). Will have to update the docs.
Use one of the provided authentication flows (https://johnnycrazy.github.io/SpotifyAPI-NET/SpotifyWebAPI/auth/) or provide the access token in a custom way

Also, please check track.HasError() and track.Error before fetching any fields...This error would have told you that you're anauthenticated.

Ok. yes pls update the docs.


[Bug] Can't subscribe topic after connect success

What did I do
I have successfully connected mqtt in MQTTX, and I created a new subscribe topic but got an error
What happened
Get an error. Topic: subscribe error, Unexpected QoS, SubACK failed, Please check MQTT broker configuration
Expected
Expect : subscribe topic success.
Environment

OS: macOS Big Sur 11.6
MQTTX version: Version: v1.8.1

More detail
More detail include log information or screenshot

Hi, this should not be a bug, the tips in this have been very clear, is the problem of authentication failure of permissions.

Here we have optimized the error message in https://github.com/emqx/MQTTX/releases/tag/v1.8.2, maybe you should check the ACL configuration of the MQTT broker, if I don't have the problem I will close the issue now.


Add support for a startOffset (FilePlayer)

The player will start playing at the given offset (in seconds).
startOffset prop :

default value is 0
is coerced (minimum 0, maximum player.duration). Any forbidden value will be overwritten by default 0 (internal state), and a warning will be flushed to the console.
is fully reactive: any update to a higher value then current playing cursor value will result in the update of the playing cursor value (player.currentTime).

Following FilePlayer methods now use startOffset to compute their return values

getDuration
getFractionPlayed
getFractionLoaded

You can test this feature in the demo app !

This is a lot of complex code (and wierd use of state) for such a specific use case (and something that you can achieve with logic outside of ReactPlayer) so I am going to close this off. If you feel like startOffset is an important possible feature then feel free to open an issue and we can discuss it over there. I would rather enable the prop for all players and try to avoid using state inside the player classes.
All you would need to do to achieve this outside of ReactPlayer is (assuming your player has a ref of player):

Listen to the onPlay prop and then immediately run this.refs.player.seekTo(fraction)
Amend the amounts returned from onProgress and onDuration before using them to update your UI, according to the fraction of the media you want to play

The reason why internal state shall be used is that you know the duration after meta data has been loaded. This is mandatory if you want to have a bounded, consistent start offset. Plus, startOffset is a prop, which makes it inherently dynamic. You should handle props value updates to expose a consistent behaviour.
I don't find anything complex, except using startOffset when computing duration, fraction played and fraction loaded. The componentWillReceiveProps code handles startOffset prop updates safely (bounded within [0, player.duration]) and drags the cursor (currentTime) to the beginning of the offset to avoid a virtually negative cursor (player.currentTime < startOffset).
startOffset state value is the safe counterpart of the startOffset prop. I could refactor to make all this logic clearer.
However I do understand that you would like all players to implement this feature if it shall be published.
What is the complexity you are describing and do you find it still accurate after this reading?

I think the same thing can be achieved for all players with less intrusive code. The logic relies on the metadataloaded event which we would have to ensure works in all browsers. If we need to wait until we know the duration, we could maybe latch on to the existing onDuration logic. Also, the component's methods currently consistently use a fraction decimal instead of seconds for stuff like seekTo, and the onProgress callback. Agreed that this should probably be seconds but I would rather change the paradigm across the whole component than add a new feature that uses seconds and doesn't follow the pattern of other props/methods.
I'm happy to open an issue requesting this feature and to work out a clean implementation if it gains support from other devs, but I don't want to add lots of code for a single feature that solves a rather edgy use case.


Remove LOG(FATAL)

Replace these with either LOG(BUG), LOG(ERROR) and exit(1) in main.cpp, or throw std::runtime_error.
This is to avoid calling abort for user errors and removes the confusion between LOG(ERROR) and LOG(FATAL).
Issue: https://github.com/bpftrace/bpftrace/issues/3163
Checklist

[ ] Language changes are updated in man/adoc/bpftrace.adoc
[ ] User-visible and non-trivial changes updated in CHANGELOG.md
[ ] The new behaviour is covered by tests

Can LOG(FATAL) throw a custom exception rather than runtime_error? Having a central choke point is nice. Also it's a bit more consistent to read/write.

I think creating a custom exception is useful but I don't like the idea of LOG(FATAL) being responsible for throwing it as it obscures what's going on to someone reading the code. If some part of the code throws then it's immediately clear that the caller needs to handle this or let it bubble up. I also never liked the combination of LOG(FATAL) and LOG(ERROR) as it's confusing which one to use and when.

Additionally, the way log.cpp works now we can't catch errors thrown in the destructor e.g.
[[noreturn]] LogStreamBug::~LogStreamBug()
{
  throw std::runtime_error(buf_.str());
  //sink_.take_input(type_, loc_, out_, internal_location() + buf_.str());
  //abort();
}


Multilingual support

I'm trying to build an app based on open-source models using Embedchain. Is it possible to support multiple languages like Hindi, Hinglish etc.?

Doesn't chatgpt have that capability out of the box?

@Dhravya, as @cachho mentioned, ChatGPT supports multiple languages and it should work just fine. Please feel free to reopen the issue if you need help after trying out chatgpt.


[Enhancement] Slope enhancements and fixes

Currently, slopes are unfinished. Their collisions with Mario, cubes and enemies don't function properly, and they aren't compatible with gels and certain tile properties. (mirrors, for example, would have lots of applications with slopes) There are also some additions i'd like to see.

[ ] Fixed collisions
[ ] Upside-down slopes
[ ] Compatibility with gels
[ ] Compatibility with tile properties

Ideally, I'd like to repurpose "Slope Left" and "Slope Right" to become "flip horizontally" and "flip vertically". That way, we can have all slope directions with 2 tile properties, and we don't have to add any or mix the existing ones around. Only problem is defining when to recognize the "default" slope (unflipped on both axes).


[CodePush] Add limit for request

Issue: deployment list command gets the list of the deployments (which works flawlessly as this is one request) and then for each deployment tries to get metrics info if latest_release field of the deployment is not empty by sending request-per-deployment simultaneously. The server in that case returns 429 error "Too many requests".
Solution: Limit the number of requests per time.

/azp run

/azp run

/azp run

/azp run

Thank you! ❤
I just tested and deployment lists work well now for large amounts.

Thank you! ❤
I just tested and deployment lists work well now for large amounts.


[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test (default-test) on project Testing: There are test failures.

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test (default-test) on project Testing: There are test failures.
[ERROR]
[ERROR] Please refer to /home/user/Bluemeric/qa-testsuite/Gopaddle-RestAssured/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] There was an error in the forked process
[ERROR]
[ERROR] Cannot find class in classpath: Configuration.Configuration
[ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: There was an error in the forked process
[ERROR]
[ERROR] Cannot find class in classpath: Configuration.Configuration
[ERROR] 	at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:657)
[ERROR] 	at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:283)
[ERROR] 	at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:246)
[ERROR] 	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1161)
[ERROR] 	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1002)
[ERROR] 	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:848)
[ERROR] 	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
[ERROR] 	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:210)
[ERROR] 	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:156)
[ERROR] 	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:148)

The problem lies in your test project. Surefire plugin is complaining that it cannot find a class named [ERROR] Cannot find class in classpath: Configuration.Configuration
This class is not part of TestNG. Please fix your project. Nothing can be done from TestNG perspective.
Closing this issue with resolution as Question answered


fix: add react-navigation export to package.json

Yo! Awesome work with this library, was testing it out with onestack.dev and this makes things a bit easier to set up with Vite.

I’m not sure I think that may be for metro or older node - what I’ve typically done is just added a new file like react-native.js at the root that they will use and that file just re-exports things from the right dist folder. I can link to that pattern later when I’m back from dinner.


Support Multi-GPU training based on the paper "On Scaling Up 3D Gaussian Splatting Training"

Paper link: https://daohanlu.github.io/scaling-up-3dgs/
Results:
Default 3DGS:

# GPUs
Batch Size
Training Time
Memory Footprint
# GS
PSNR
SSIM
LPIPS

1
2
350s
8.9 GB
4.4M
26.17
0.830
0.126

2
1 * 2
318s
5.0GB * 2
2.2M * 2
26.17
0.828
0.126

CUDA_VISIBLE_DEVICES=0,2 python simple_trainer.py --batch_size 1 --steps_scaler 0.5
CUDA_VISIBLE_DEVICES=0 python simple_trainer.py --batch_size 2 --steps_scaler 0.5

MCMC 3DGS:

# GPUs
Batch Size
Training Time
Memory Footprint
# GS
PSNR
SSIM
LPIPS

1
2
204
2.5 GB
1M
25.86
0.812
0.159

2
1 * 2
153s
1.3GB * 2
0.5M * 2
25.89
0.811
0.157

CUDA_VISIBLE_DEVICES=0,2 python simple_trainer_mcmc.py --batch_size 1 --steps_scaler 0.5 --cap_max 500000
CUDA_VISIBLE_DEVICES=0 python simple_trainer_mcmc.py --batch_size 2 --steps_scaler 0.5 --cap_max 1000000

Note: this is not to compare between Default and MCMC 3DGS are the converged # GS is not the same.

WIP on cleaning up

It is strange that Gsplat-MCMC perform worse than Gsplat-Default.
I have shown some experiment in discord server. Gsplat-MCMC got better result despite it has lower GSs count. If it got worse, try change another hyperparameter such as --opacity_reg 0.001 instead of the default 0.01.

@TarzanZhao My biggest problem with this PR in its current stage is that it's far from getting 3.5x speedup on 4x GPUs. I'm not sure how much NVlinks play a role in this, which I don't have in my server setup. But would love to know if any thing can be improved on the implementation side, which I think its mostly just the update of the rasterization() function.

I think I can live with like ~3x speedup on 4 GPUs because I'm not implementing the tile-based balancing and GS rebalancing logic. Is that a reasonable expectation?

Using packed mode:
CUDA_VISIBLE_DEVICES=4,5,6,7 python simple_trainer.py --steps_scaler 0.25 --eval_steps -1 --disable_viewer --packed
>>> Step:  7499 {'mem': 2.944546699523926, 'ellipse_time': 1661.8717801570892, 'num_GS': 1356072}
>>> Step:  7499 {'mem': 3.056483268737793, 'ellipse_time': 1661.9940576553345, 'num_GS': 1432245}
>>> Step:  7499 {'mem': 3.076539993286133, 'ellipse_time': 1661.1862392425537, 'num_GS': 1430476}
>>> Step:  7499 {'mem': 3.133754253387451, 'ellipse_time': 1661.065690279007, 'num_GS': 1470615}
>>> PSNR: 27.431, SSIM: 0.8689, LPIPS: 0.075 Time: 0.087s/image Number of GS: 1356072

As a reference. Running the official repo in the same GPU environment (without NVlinks) get:

4 GPUs with total batch size 4:

# 4g_4b.sh
torchrun --standalone --nnodes=1 --nproc-per-node=4 train.py \
        -s ${dataset_folder}/${scene} \
        --images ${image_folder} \
        --llffhold 8 \
        --iterations 30000 \
        --log_interval 250 \
        --model_path ${expe_folder}/4g_4b/${expe_name} \
        --bsz $BSZ \
        $monitor_opts \
        --test_iterations 30000 \
        --save_iterations 30000 \
        --eval

Training Finished after 15m30s
[ITER 29997] Evaluating test: L1 0.028009627014398575 PSNR 27.24338150024414 [19/07 17:24:22]
[ITER 29997] Evaluating train: L1 0.02116350270807743 PSNR 29.852651596069336 [19/07 17:24:23]

@TarzanZhao My biggest problem with this PR in its current stage is that it's far from getting 3.5x speedup on 4x GPUs. I'm not sure how much NVlinks play a role in this, which I don't have in my server setup. But would love to know if any thing can be improved on the implementation side, which I think its mostly just the update in the rasterization() function.

Overall, I think there are two major reasons:

Data loading might be slow.
There are more kernel launches than our implementation, but this is related to the data format required by gsplat. You want the code to be clear and modular, and for some functions to be decoupled, so some additional data format conversion kernels are needed. I think this is normal.

PSNR

The PSNR for the garden scene in this test is lower than in our experiments (below) . Could you please run it again to check if this is due to numerical instability?

PSNR

The PSNR for the garden scene in this test is lower than in our experiments (below) . Could you please run it again to check if this is due to numerical instability?

As a reference.

The PSNR for the garden scene in this test is lower than in our experiments (below) . Could you please run it again to check if this is due to numerical instability?

As a reference.

The PSNR for the garden scene in this test is lower than in our experiments (below) . Could you please run it again to check if this is due to numerical instability?

After some optimization, the training time of 4 GPUs is brought down to 16m25s!
CUDA_VISIBLE_DEVICES=4,5,6,7 python simple_trainer.py --steps_scaler 0.25 --eval_steps -1 --disable_viewer --packed

>>> Step:  7499 {'mem': 2.8663759231567383, 'ellipse_time':<PHONE_NUMBER>670471, 'num_GS': 1352151}
>>> Step:  7499 {'mem': 2.971991539001465, 'ellipse_time':<PHONE_NUMBER>587402, 'num_GS': 1406792}
>>> Step:  7499 {'mem': 3.0060572624206543, 'ellipse_time':<PHONE_NUMBER>523315, 'num_GS': 1454676}
>>> Step:  7499 {'mem': 3.0007195472717285, 'ellipse_time':<PHONE_NUMBER>761017, 'num_GS': 1428084}

MCMC on 4 GPUs
CUDA_VISIBLE_DEVICES=4,5,6,7 python simple_trainer_mcmc.py --steps_scaler 0.25 --eval_steps -1 --packed

>>> Step:  7499 {'mem': 2.4360504150390625, 'ellipse_time':<PHONE_NUMBER>009186, 'num_GS': 1000000}
>>> Step:  7499 {'mem': 2.403714179992676, 'ellipse_time':<PHONE_NUMBER>746918, 'num_GS': 1000000}
>>> Step:  7499 {'mem': 2.42301607131958, 'ellipse_time':<PHONE_NUMBER>961029, 'num_GS': 1000000}
>>> Step:  7499 {'mem': 2.411731243133545, 'ellipse_time':<PHONE_NUMBER>886566, 'num_GS': 1000000}

PSNR: 27.714, SSIM: 0.8744, LPIPS: 0.079 Time: 0.074s/image Number of GS: 1000000

This PR is great! I wonder that can it be used in a way to use 1 GPU to process multiple batch?
So it will allow much larger scene to be trained with just 1 GPU! (larger scene in term number of gaussians, or num of images, ideally both)
I think this 1 GPU use case can help a lot of people to train high quality GS without highend GPU.
@liruilong940607 Do you think it is possible?

@Ben-Mack  For a single GPU, I guess there isn't much you can do other than looping over images?


Variant Recoder fix HGMD url

Add URL to all HGMD variants (release 109).
Sandbox: http://wp-np2-11.ebi.ac.uk:7040/Homo_sapiens/Tools/VR
Variant to test: rs138742754
HGMD in output is BM1115006

http://wp-np2-11..ebi.ac.uk:7040/Homo_sapiens/Tools/VR/Ticket?tl=5ZXGneQ8hzV2rWui
HGMD output is linking to the homepage http://www.hgmd.cf.ac.uk/ac/index.php
without any ID. Should this be linking to the page for BM1115006?

We will let it be as it is for now.


Unwrap executeActionReturning to return multiple

Fixes #2254
Problem
.returning returns a single value instead of a list, failing on both zero and n > 1
Solution
Return a list instead of a scalar from executeActionReturning
Notes
Additional notes.
Checklist

[ ] Unit test all changes
[ ] Update README.md if applicable
[ ] Add [WIP] to the pull request title if it's work in progress
[ ] Squash commits that aren't meaningful changes
[ ] Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

@easel What's the status of your PR?


Version Kubernetes Agent Chart

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or setup this action to publish automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to release/kubernetes-agent/v1, this PR will be updated.
Releases
<EMAIL_ADDRESS>Patch Changes

3a77239: Don't include the Readme.md.gotmpl in the chart

This PR was made due to us needing a versioning commit to force a non-pre-release build


Bump dev version to 0.2

closes #11

Codecov Report

Merging #25 (67d68e4) into main (9e6327e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   89.33%   89.33%
=======================================
  Files           2        2
  Lines          75       75
=======================================
  Hits           67       67
  Misses          8        8

Impacted Files
Coverage Δ

pytest_pyvista/__init__.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Functions should not match {[key: string]: any} type

I'm surprised that this snippet type checks:
function foo(props: {[key: string]: any}) { }
foo(x => x);

$ echo 'function foo(props: {[key: string]: any}) { }; foo(x => x);' | flow check-contents
No errors!
$ flow --version
Flow, a static type checker for JavaScript, version 0.17.0

In what sense is a function type the same as an object type?

From IRC:

[3:05pm] glevi: danvk: So technically a function is an object
[3:05pm] glevi: I think we've always been a little unsure about how to approach that reality
[3:06pm] glevi: For example, we say that Function is a subtype of Object
[3:06pm] glevi: Since all functions are objects
[3:07pm] danvk: {[key: string]: any} feels more specific than Object
[3:07pm] danvk: seems like it’s calling specifically for a string—>value mapping
[3:07pm] danvk: i.e. an object with string keys
[3:07pm] jeffmo: danvk: glevi: Arguably a function fits that description
[3:07pm] glevi: danvk: So technically all object keys are strings
[3:07pm] jeffmo: function foo(){} foo.prop = ‘asdf’;
[3:08pm] jeffmo: function foo(){}  foo.name
[3:08pm] danvk: the prompt for this was that I was calling _.findWhere() instead of _.find()
[3:08pm] danvk: which is an error that Flow can’t catch if it considers function and object the same thing
[3:08pm] jeffmo: Practically speaking, I don’t think anyone expects that a function would pass checking if {[:string]: anye} were specified, though
[3:09pm] danvk: right, 1 * “1” is legal JS but Flow doesn’t allow it
[3:10pm] danvk: seems like this may be another one of those cases
[3:11pm] samg: Uh, so the function is converted into a { "$call": Function } type, and that's a subtype of the indexable sig? Seems like we should exclude $call from that subtyping relationship.
[3:13pm] samg_: feels like a bug to me
[3:14pm] danvk: right… I’d expect {} to match that type
[3:14pm] danvk: but not function(){}
[3:17pm] samg_: { [:string]: any } is the same as Object, as far as I can tell
[3:17pm] samg: but it should exclude the function, if I'm reading this right
[3:18pm] samg_: err, nope. no error with that as well, which is good, because at least flow is consistent
[3:20pm] samg_: In fact, flow is fairly explicit about functions being objects: https://github.com/facebook/flow/blob/4b4e3800e780bfebbadff1357c126763ac02d37c/src/typing/flow_js.ml#L3423

@samwgoldman was this addressed by #984?

@danvk I don't think so. At least, that wasn't my intention.

Is there any way to create a typedef specifying a parameter should be an Object but not a Function? This otherwise makes it impossible to properly make a distinction between _.merge and _.mergeWith, for example.

I found a way to make this work:
type GenericMap<T> = {[key: string}: T} & {$call: void};

https://flowtype.org/try/#0C4TwDgpgBA8gRgKwgY2AFXNAvLRLhQBkUA3gCTICGANtQFxQBuA9gJYAmAvgNwBQokKAHEIAOwgAnVsgCylMAB40APig4SAbQDWEEAwDOwKaIDmAXQZpORUhRr0mbLn17sU1ShOgAzAK6jUVmZRKGBKHX14JFQACmZEBhFxKVl5BVFfAFs4SWUASgYWDhcwiKj8GJJKBgBmTjy+UohIvFiqhgByb2ZmDvqS8Oby2L8A4CDRGLySfqA

This is valid behavior for object types. You could also use an exact object type.

@STRML thanks for the solution. Please fix your code snippet for further googlers.
- type GenericMap<T> = {[key: string}: T} & {$call?: void};
                                    ^
+ type GenericMap<T> = {[key: string]: T} & {$call?: void};

Good catch, thanks.


False negative with Scala 2.12 and ReversedMissingMethodProblem

We have a case where a problem is only shown with Scala 2.11 but not with 2.12 where a method was added to a trait (not a really problem in this case as the trait is not extended by users).
I haven't tried to see if that's actually a bug in mima or if something else is going on.
Failed jenkins build on Scala 2.11: https://jenkins.akka.io:8498/job/pr-validator-akka-http/2201/consoleFull.
Can be reproduced on https://github.com/kag0/akka-http/commit/01571e13b103ac709ebf26a9d17a22b796416c2c by running mimaReportBinaryIssues in subproject akka-http.

Thinking more about it, it's probably expected. I guess the reason is that in 2.12 default method implementations are generated for traits so that it indeed isn't a compatibility issue any more.


Add a migration service project template

Based on https://github.com/dotnet/aspire-samples/tree/main/samples/DatabaseMigrations/DatabaseMigrations.MigrationService with placeholders for provider-specific code

There's also the web-based example we have at https://github.com/dotnet/aspire-samples/tree/main/samples/AspireShop/AspireShop.CatalogDbManager

I think we should consider another sample template that's crud + EF + postgres, showing how to use migrations etc.

Or we could just add it to the existing starter template, potentially as an option.

Strawman with some open questions:
We get a lot of feedback about what patterns work well to configure, initialize, and manage a database using EF Core as part of an Aspire app. We have some samples and documentation on this but we should take this guidance to the next level and include it in our starter template.
Rough idea of what this would include:

A new option on the template to include a database that allows selecting between the supported database integrations: PostgreSQL, MS SQL Server, MySQL, MongoDB, or Oracle

❓ Should we limit this to just PostgreSQL and MS SQL Server? Some other combo?

A simple page in the Blazor app that uses the database and demonstrates basic CRUD, e.g. a Todo's list
A new API in the API project that exposes an HTTP API for the data in the database (this aligns with the webapiaot template so we can lift the relevant implementation from there)

❓ Should this be a new API added in the existing project or should we separate into its own API project?

Relevant code in the AppHost project to add the database server and instance resources and configure the API project to reference it and WaitFor it
Update the tests project to add a test that hits the page that depends on the database

❓ Should we limit this to just PostgreSQL and MS SQL Server? Some other combo?

PostgreSQL, MS SQL Server

A new API in the API project that exposes an HTTP API for the data in the database (this aligns with the webapiaot template so we can lift the relevant implementation from there)

Yes, we should do the DB stuff in existing API not from the front end directly.

First cut of what it would look like is at https://github.com/DamianEdwards/AspireStarterDb
I made the migrations service a web project as we don't support deploying worker apps to ACA today.
Please provide any feedback and I'll work to get this added to the 9.0 starter template.

It should use the new UseAsyncSeeding for seeding. HasData is rarely what the users want, it's for managed data that evolves with the model but is never modified by the application itself.
And apply the other suggestions from https://github.com/dotnet/aspire-samples/issues/401

OK thanks, I was following guidance from the EF Core docs. I'll take another look.

Hitting a snag after updating to EF Core in that I can no longer create migrations in the ApiDbService project using `dotnet ef migrations add:
➜ dotnet ef migrations add Initial
Build started...
Build succeeded.
No DbContext was found in assembly 'AspireStarterDb.ApiDbService'. Ensure that you're using the correct assembly and that the type is neither abstract nor generic.

The location of the DbContext hasn't changed. Is this a change or regression in EF Core 9.0 when modifying the MigrationsAssembly?

Pushing this out of 9.0 as the content is going to require proper review before we include it. Good candidate for 9.1

Im still seeing this issue using Aspire.Npsql.EFC.Postgres - 9.0.0-rc-2.24, could you share the workarounds? thanks

Use the string overload of .MigrationsAssembly("AspireStarterDb.ApiDbService") and specify the context name in the call:
dotnet ef migrations add Initial --context TodosDbContext


feat(sdl): We're now polling events, instead of waiting for inputs.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#15  👈
#14
#13
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rafaelrene and the rest of your teammates on  Graphite

Merge activity

May 8, 9:46 AM EDT: @rafaelrene started a stack merge that includes this pull request via Graphite.


Inference speed is very slow

I'm trying to follow the testing scripts for evaluating an existing model on the COCO dataset using faster_rcnn on Google Colab. However, the inference speed was only about 8.2 tasks/s, which is much slower than the reported speed of 21.4fps
This is my testing scripts:
CONFIG = 'configs/faster_rcnn/faster_rcnn_r50_fpn_1x_coco.py'
CHECKPOINT = 'checkpoints/faster_rcnn_r50_fpn_1x_coco_20200130-047c8118.pth'

!python tools/test.py $CONFIG $CHECKPOINT --out results.pkl

And this if the final time taken to run the testing script:
[>>] 5000/5000, 8.2 task/s, elapsed: 610s, ETA:     0s
Any help would be much appreciated!

21.4fps is the inference speed of the network. The testing time contains data time, network inference and post process for evaluation.


Problem: no way for bash scripts to get relevant IP address where Hax web server is listening

Hax gets IP for binding from consul:
hax/server.py
addr = ConsulUtil().get_hax_ip_address()

Having a use case when curl is used to access HTTP API endpoint, the request have to be sent to proper IP address. This issue is to find and way to do it.
Possible options so far:

Make hax to listen on INADDR_ANY by using <IP_ADDRESS> argument for webserver to bind.
Tested. It works. The cons here is that hax becomes accessible from all interfaces. This may be a problem for security.
Make hax to listen on <IP_ADDRESS>. This is opposite solution when only local processes can access HTTP API endpoint. Cons: it may break communication with other applications if they are communicating with hax via network.
Define a way how bash script can get hax IP from Consul.

Jira ticket here: https://jts.seagate.com/browse/EOS-23768
Above we see this:

Reopening issue to discuss it when time permits. So far, Option 1 was implemented and merged according to @knekrasov advise.

@knekrasov  does this mean that the issue was resolved?

I'm going to ping @knekrasov on Jira to get a status update.

This information can be taken from hctl status. So closing this ticket. cc @mssawant

Vaibhav Prakash Paratwar commented in Jira Server:

Close this ticket [~534380]

Vaibhav Prakash Paratwar commented in Jira Server:

.

Vaibhav Prakash Paratwar commented in Jira Server:

.

Vaibhav Prakash Paratwar commented in Jira Server:

,


Question

In the "Set up multi-factor authentication for guests" section:
I was not able to find Conditional Access Policies in Azure Active Directory.
Is an admin supposed to purchase Microsoft Azure separately for this to work in SharePoint?
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a4945844-0f8f-2691-1092-0025cc19c683
Version Independent ID: adc60afc-fb2a-dd5c-9217-6e074abc8dc0
Content: Create a secure guest sharing environment
Content Source: microsoft-365/solutions/create-secure-guest-sharing-environment.md
Product: microsoft-365-enterprise
GitHub Login: @MikePlumleyMSFT
Microsoft Alias: mikeplum

@hwkwicre Thank you for your feedback. Using this conditional access required Azure AD Premium P1 license. I have added a note in the document about the same via PR# https://github.com/MicrosoftDocs/microsoft-365-docs/pull/2462

@msbemba  Thank you very much for the contribution and updating the documentation with PR. @hwkwicre Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Why TabNavigator render all sub screens at same time?

Four sub screen in the TabNavigator, don't you think it is the extra overhead  about render all of the sub screen at same time?

Does there has a way render single sub screen every time.
2.If 1 is not, and each of my sub screens has  a lot of data, how to handle the  hidden danger，e.g. lag, suspend?

we got lazy options
lazy - whether to lazily render tabs as needed as opposed to rendering them upfront
https://github.com/react-community/react-navigation/blob/master/docs/api/navigators/TabNavigator.md

@buncismamen  how to use Lazy?  what params should inside of lazy? can you provide an example?

const MyApp = TabNavigator({
  Home: {
    screen: MyHomeScreen,
  },
  Notifications: {
    screen: MyNotificationsScreen,
  },
}, {
  lazy: true,
  tabBarPosition: 'top',
  animationEnabled: true,
  tabBarOptions: {
    activeTintColor: '#e91e63',
  },
});

@buncismamen  thanks , it works , I have wrote it in the wrong place before.

@buncismamen if they are lazy loaded, do they unload when the tab is changed? It doesnt seem to unload for me.

@Noitidart I think its not, they are not as smart as flatlist
maybe contributor have better explanation for this one

@Noitidart idk if this component is as smart as flatlist, but I think its not, maybe contributor have better words and explanation for this, maybe you could create another issue or looking through the code.

Thanks very much @buncismamen for such a fast reply!! :)

@Donhv the same :(

+1

+1

+1

+1

+1

+1

Not the best solution, but solved my issue. Only execute when screen is visible.
componentDidMount () {
    this._sub = this.props.navigation.addListener( 'didFocus', () => (
      ...api requests...
    ))
  }

hi folks! please install<EMAIL_ADDRESS>where lazy is now default. I also added other optimizations for better memory usage. let me know if this works well for you. https://github.com/react-navigation/react-navigation/pull/3538


[sitemap] Add html suffix for privacy policy

It's needed (maybe since moving to serve static assets via NGINX?).
I'm not sure there's a lot of advantage in listing the privacy policy in the sitemap at all, but I guess it seems sort of like a good idea. Maybe it enhances credibility and makes search engines rank me higher.

Closing in favor of #4961.


OSError: [Errno 95] Operation not supported: 'epoch_1.pth' -> ...

I find an answer "some environments do not support  os.symlink  so that you can add an argument in the checkpoint_config field in config files, like checkpoint_config=dict(create_symlink=False)" in mmdetection project. However, when i set like that, models (epoch_n.pth) can not be saved, which could result in failing to evaluate and compute metrics.

I find declaration of runner in MMCV, I find that turning off create_symlink button will not stop saving checkpoint, you can debug into save_checkpoint function to find whether the checkpoint is saved correctly.

It works! I ignored the two lines you selected. Thanks for your help again!


Question: Is there a way to secure endpoints with HTTP method type in configuration?

Currently, below is what we have in our application.yml.  We need the ability to support securing paths by HTTP method.  It doesn't appear there is a way to do this without programmatically interacting with the org.springframework.security.config.annotation.web.builders.HttpSecurity object.
sso:
    home:
        secure: false
        path: /index.html, /, /login, /user, /webjars/**

It would be convenient to be able to specify the HTTP method similar to the way you can specify paths.  We are currently developing a REST API where we need the ability to lock down different HTTP methods for the same URL.  Below is a proposed YAML configuration that would handle this and still be backwards compatible.  This would allow multiple paths to be specified along with multiple HTTP methods for that given path.  In the example below, "/api/customers" and "/api/products" would be available using the HTTP GET or POST.  In addition, this pattern could be extended for adding roles to a given URL.
If there's an alternative way of doing this, I would like to hear that too.  I started to create a pull request, but wanted to confirm on the approach and make sure it doesn't already exist in some other way.
sso:
    home:
        secure: false
        path: /index.html, /, /login, /user, /webjars/**
        paths:
            -
                path: /api/customers/**, /api/products/**
                method: GET,POST
                secure: false

IMO this is not a YAML type feature: you end up programming in configuration files. With 1.1 (actually Spring Boot 1.3) you just have to write a normal WebSecurityConfigureAdapter (in 1.0 there was an OAuth2SssoCOnfigurerAdapter).


Display objeccts on replay XHR

When I replay the XHR request using the developer tools, I would like to see the objects logged to the console again.
Are there any plans to implement this?

See: https://github.com/firephp/firephp-for-firefox-devtools/issues/25


modify-mysql-dashboard

This PR contains 2 evolutions of MySQL Dashboard only :

add deployment name list box for select your deployment (only the IP currently)
set the current value of the mysql_global_status_wsrep_cluster_size and not average for the last hour

See #302


update README and doc content

this commit is to update all README and doc content related to os-net-config repo

Correct reference to invalid urls
Added more description for os-net-config feature

Fixes: https://issues.redhat.com/browse/OSPRH-8784
Signed-off-by: vcandapp<EMAIL_ADDRESS>

Please address the check commit issues.
Run ./check-commits "47a3903fbb0740b09fe8fc6ab898c45aeff9c7d0..a25309e26be619598eb6d49d42485c06824cd58b"
error [1/1] 'update README and doc content' title lacks a lowercase topic prefix (e.g. 'ipv6:')
error [1/1] 'update README and doc content' 'Signed-off-by: vcandapp<EMAIL_ADDRESS>trailer is missing
error [1/1] 'update README and doc content' body has less than three words, please describe your changes

recheck

recheck

recheck


Consensus Refactor

This PR encompasses the next phase in the consensus refactoring effort (RIPD-1011/RIPD-1342).  As a reminder, the goal is to create a generic version of the consensus algorithm for use in a testing and simulation framework.  This phase achieves that goal with a modest amount of refactoring and introduces some proof of concept unit tests.  The current design can certainly be improved, but I am deferring on more substantial refactoring until more robust testing is in place.  As such, please focus primarily on the correctness of the changes below.  Suggestions on improving the design are appreciated too, but depending on the scope, I may handle them in a subsequent refactoring.
I've tried to break each changeset into a palatable chunk, either migrating one piece of functionality to the new design or refactoring specific behavior. The unit tests and documentation are added in the final two changesets.
At a high-level,

Generic consensus code is in src/ripple/consensus

Consensus<Derived,Traits> is the generic implementation and uses CRTP to define the interface
for specific
The Traits class defines types representing transactions, transactions sets, ledgers and proposals that are operated on in the generic code.

Ripple consensus implementation is in src/ripple/app/consensus

RCLConsensus : public Consensus<RCLConsensus, RCLCxTraits> implements the CRTP interface to hook into rippled application
RCLCxTx, RCLCxTxSet, RCLCxLedger and LedgerProposal are the types defined in RCLCxTraits and conform to type requirements set by generic Consensus.

The current functionality in LedgerConsensusImp and ConsensusImp is migrated to the new framework, with generic functionality in Consensus and application-specific functionality in RCLConsensus.

Doc preview: http://bachase.github.io/ripd1011/index.html

Current coverage is 66.07% (diff: 67.94%)

Merging #1941 into develop will increase coverage by 0.61%

@@            develop      #1941   diff @@
==========================================
  Files           698        696     -2
  Lines         49745      49720    -25
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits          32563      32852   +289
+ Misses        17182      16868   -314
  Partials          0          0

Powered by Codecov. Last update 7fc780d...628d3b6

Rebase on 0.50.0-b1 and addressed PR comments.  Separate update forthcoming to address the dual use of ConsensusPosition and LedgerProposal

Added 6d635e4a89c4177eb13e8c60422921b25ed15d49 to refactor LedgerProposal and ConsensusPosition as suggested by @nbougalis.  The idea now is that generic Consensus only cares about ConsensusPosition, which is suitable for either our own or our peer's position.  For RCL version of consensus, a new RCLCxPeerPos represents a signed ConsensusPosition.
There is only one aspect of the change I don't like, and that was having to add a conversion operator  back to ConsensusPosition.  This is because Consensus only cares about the ConsensusPosition, but can still request the specific implementation to relay the original peer position.
Updated docs http://bachase.github.io/ripd1011/index.html

Pushed a change to ensure that consensusBuilt gets called. With this change, my server consistently reports that it built a ledger a split second before confirming it fully validated it. This is perfect.

Rebased on 0.50.0-b2

Rebased on 0.50.0-b5

Rebased on 0.50.0-rc1

Rebased on 0.50.0, dropped the Time_t trait from consensus and added the latest incarnation of the testing and simulation framework.

Rebased on 0.50.1

I was looking through the doc preview, and noticed some problematic formatting. For example, on https://bachase.github.io/ripd1011/rippled/ref/ripple__Consensus.html, in the Description section, the lists are coming out as one paragraph. I think you need /li instead of *. I also notice the Template Parameters section didn't render the links correctly. Not sure how to fix that.

@ximinez  I had created https://github.com/vinniefalco/docca/pull/15 to handle the list issue but I totally forgot about it.  I'll take a closer look at the template parameter issue.

Lists have to be specified like this:
/** ...

    @li List item 1
    @li List item 2
*/

My PR for docca was actually just for nested list support.  My issue here was missing whitespace.  I updated the docs and https://bachase.github.io/ripd1011/rippled/ref/ripple__Consensus.html looks much better.
Doxygen actually supports markdown style lists and the existing xsl handles it, so no need for @li unless you prefer it.
@ximinez to handle the poor rendering in the template section, I manually changed https://github.com/vinniefalco/docca/blob/master/include/docca/doxygen.xsl#L754 to instead render just like the mode=markup section above https://github.com/vinniefalco/docca/blob/master/include/docca/doxygen.xsl#L710.  I'm not sure what else that impacts though.

Rebased on 0.50.2

Rebased on 0.60.0-b2

Rebased on 0.60.0-b3

Rebased on 0.60.0-b4

Did a bit more tidying and re-reviewed the entire set of changes.  With the additional unit tests, this now has fairly good coverage over the generic Consensus.h implementation.
Improvements to the simulation framework, documentation and additional refactoring of the consensus implementation will happen in other PRs.

No longer need mutable here: https://github.com/bachase/rippled/blob/consensus_prep/src/ripple/consensus/Consensus.h#L546
This: https://github.com/bachase/rippled/blob/consensus_prep/src/ripple/consensus/Consensus.h#L244 would be more readable with = delete.  That or you could just not mention the move assignment altogether, along with the deleted copy members, as the explicit move constructor implicitly deletes the other three.

 Need newline at end of file here: https://github.com/bachase/rippled/blob/consensus_prep/src/test/csf/Peer.h#L492

Ditto (eof newline):
https://github.com/bachase/rippled/blob/consensus_prep/src/test/csf/Sim.h#L104
https://github.com/bachase/rippled/blob/consensus_prep/src/test/csf/Tx.h#L227

I'll blame VS for my bad newline habits 😜

And one more: src/test/unity/csf_unity.cpp

Rebased  on 0.60.0-b5

Replaced with #2040