display scaling?

it's very difficult to read at 4k resolution on my monitor, and while I can change the monitor resolution to resolve this issue on my end, it would be far more convenient to just have some options for display scaling, if possible

Oh my god, hahahaha.
Okay, yes. I will add a zoom option.

ctrl/cmd+= Zoom In.
ctrl/cmd+- Zoom Out.
ctrl/cmd+0 Zoom Reset.


cudaPackages: add cudaFlags

Description of changes
cudaPackages in Nix provides a central place for the CUDA environment in Nix and there has been a migration of relevant packages into that space.  Unfortunately, Nix continues to apply code generation decisions at a local package level and presently those are applied inconsistently.
This change:

Introduces a single "cudaCapabilities" that applies across a build through cudaPackages.cudaFlags
Makes common conventions (Arch, Names, and Flags) available via cudaPackages to package developers
Provides a simple user override via Nix's config to alter compile flags, translating as needed for the packages
Fixes upstream typos

Examples of flags available following the change:
nix-repl> pkgs.cudaPackages.cudaFlags.cudaCapabilities
[ "3.5" "5.0" "5.2" "6.0" "6.1" "7.0" "7.5" "8.0" "8.6" "8.6+PTX" ]

nix-repl> pkgs.cudaPackages.cudaFlags.cudaCapabilitiesCommaString
"3.5,5.0,5.2,6.0,6.1,7.0,7.5,8.0,8.6,8.6+PTX"

nix-repl> pkgs.cudaPackages.cudaFlags.cudaArchNames
[ "Kepler" "Maxwell" "Pascal" "Volta" "Ampere" ]

Note: In this PR I've tried to choose flags that represent what Nix does presently and are supported by the toolkit versions. I am not partial to any particular choice here (other than it be consistent across packages) and expect experienced users will override them anyway for their own tradeoffs (support of new hardware or reduced final binary size).  Improvements welcome!
@samuela @NixOS/cuda-maintainers
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

$ nix-build pkgs/top-level/release.nix -A tarball.nixpkgs-basic-release-checks --arg supportedSystems '[ "aarch64-darwin" "aarch64-linux" "x86_64-linux" "x86_64-darwin"  ]
/nix/store/jy2q5cb9rwmx87jdd611381wmb0cqbj5-nixpkgs-release-checks
$ nix-build --expr 'with (import ./. {}).pkgs; python3.withPackages(ps: with ps; [ jaxlib pytorch tensorflow torchvision ])'
/nix/store/cifn082kdcd5fwxrh55rcnazybmalcvs-python3-3.10.8-env
$ nix-build --expr 'with (import ./. { config = { allowUnfree = true; cudaSupport = true; }; }).pkgs; magma' $EXTRA
/nix/store/h1jssha9fzkcww1xhqpsbynvam4srx5c-magma-2.6.2
$ nix-build --expr 'with (import ./. { config = { allowUnfree = true; cudaSupport = true; }; }).pkgs; python3.withPackages(ps: with ps; [ jaxlib pytorch tensorflow torchvision ])'
/nix/store/p8lk2z3y60zz34ckzza8ag2v390za8qj-python3-3.10.8-env
# mxnet is presently marked as broken but was updated to be consistent

Result of nixpkgs-review pr 205351 run on x86_64-linux 1

6 packages marked as broken and skipped:

python310Packages.mask-rcnn
python310Packages.optuna
python310Packages.rl-coach
python39Packages.mask-rcnn
python39Packages.optuna
python39Packages.rl-coach

28 packages failed to build:

gpt2tc
python310Packages.distrax
python310Packages.dm-sonnet
python310Packages.elegy
python310Packages.pot
python310Packages.rlax
python310Packages.tensorflow-datasets
python39Packages.baselines
python39Packages.dalle-mini
python39Packages.distrax
python39Packages.dm-sonnet
python39Packages.edward
python39Packages.elegy
python39Packages.flax
python39Packages.gpt-2-simple
python39Packages.pot
python39Packages.pymanopt
python39Packages.rlax
python39Packages.scikit-tda
python39Packages.tensorflow (python39Packages.tensorflow-build ,python39Packages.tensorflowWithoutCuda)
python39Packages.tensorflow-datasets
python39Packages.tensorflow-probability
python39Packages.tensorflowWithCuda
python39Packages.tflearn
python39Packages.treex
python39Packages.trfl
python39Packages.umap-learn
python39Packages.vqgan-jax

22 packages built:

libtensorflow
magma
python310Packages.baselines
python310Packages.dalle-mini
python310Packages.edward
python310Packages.flax
python310Packages.gpt-2-simple
python310Packages.jaxlibWithCuda
python310Packages.pymanopt
python310Packages.scikit-tda
python310Packages.tensorflow (python310Packages.tensorflow-build ,python310Packages.tensorflowWithoutCuda)
python310Packages.tensorflow-probability
python310Packages.tensorflowWithCuda
python310Packages.tflearn
python310Packages.torchWithCuda
python310Packages.treex
python310Packages.trfl
python310Packages.umap-learn
python310Packages.vqgan-jax
python39Packages.jaxlibWithCuda
python39Packages.torchWithCuda
tts

Just checked the logs and the failures do not look related. In particular, the python3.9 builds of TF/JAX were auto-killed, possibly due to OOM issues but they appear to be building fine with python3.10 so I don't think that's an issue.
I'll proceed with merging. Thanks for all your hard work @jmillerpdt -- this is a good step forward!


Expose Digest and Crypto.Hash.Types

It would be nice to create an empty Digest value. Is there any way you could expose this, or make Digest a monoid? Thank you for this project :)

What are you trying to achieve ? Not sure, what an empty Digest is, and I don't think Digest behave like a monoid (e.g. appending 2 Digest SHA1 doesn't yield a Digest SHA1)

That makes a lot of sense actually. My mistake - I'm trying to make a nonce-based session cache in wai-session - found myself using fromMaybe and needed a default value. Sorry about that!

I still would like to convert a Digest into a ByteString - do you have any tips for this? :\

you could use Data.ByteArray.convert from the memory package to do that

Ahh! The typeclasses are fooling me! Thank you!


Move hypermedia responsibility from router to handlers

This changes some of how hypermedia is delivered to the handlers. It's possible to access the handlers that hyperlinks points at and get a description string from them. Routers are no longer responsible for delivering any other kind of hypermedia, so the Hypermedia type has been removed and only hyperlinks are delivered through the Endpoint.
This is a breaking change for anything that uses the hyperlinks or the Hypermedia structure in any way, including custom routers.

I'm considering removing the Hypermedia struct for now, since the Handler trait can take care of that, and just have the hyperlinks in the Context. I can't think of anything else that can only come from the router...

@homu r+

:pushpin: Commit 8e101c2 has been approved by Ogeon

:hourglass: Testing commit 8e101c2 with merge cf9f274...

:sunny: Test successful - status


Graph precentage on smaller screen overlays with map.

I just cloned the project, did "npm install" and afterwards "npm start".
http://shrani.si/f/x/6D/c85M3bs/ng2-admin-bug.png
Google Chrome 58.0.3029.110 (64-bit).
Node v6.11.0,
NPM v3.10.10,
Windows 10.
The demo on your website doesn't have this problem.

I have the same issue. Seems like these rules are not applied for some reason
`@media (max-width: $resM) {
.card.medium-card.traffic-panel {
  height: auto;
}

div.channels-info {
  display: block;
  width: calc(100% - 88px);
  margin-top: -65px;
  margin-bottom: 10px;
}
.traffic-chart {
  position: inherit;
  float: none;
  margin: 0 auto;
}
.chart-bg {
  left: calc(50% - 90px);
}

}`

i just hide it for temp solution..
div.channels-info {
display: none;
}


Ensure that drawable dashboard can work with native fonts.

Once the drawable wrapper is implemented, this should be nearly out of the box, more about testing than anything else.

Works fine with native-drawn Adafruit fonts now, should work with all others too. Will now test with tcUnicode fonts to ensure that still works.

Both TcUnicode and regular fonts now work dashboard, to use native it's as simple as passing the font parameter as a NativeFontDesc(font, mag) exactly as it would be provided in the designer.


ct-series-a  –>  ct-series-1

This isn't an issue, but it seems that people leave their feature requests here so I will do the same.
Would it be possible to change the ct-series-a naming system to a number system, e.g. ct-series-1?
I've run into a scenario where I'm trying to use a @for loop in a Sass file to automatically add colors to my bar charts in a specific order, but the whole lettering convention is ruining it. I could create an array to map numbers to letters, but it's excessive and doesn't work past index 26 because the letter naming system resets itself after it reaches the end of the alphabet. It's something very minor, yet something very limiting.
It seems that this could be changed by removing alphaEnumerate on line 275 of bar.js, line 176 of line.js, and line 168 of pie.js. I would fork it and do it myself, but it's so minor that I'd rather not clutter up this repository for it to only be rejected.
If replacing the lettering system isn't plausible because it would ruin backwards compatibility, could the numerical system at least be added alongside it?
Absolutely loving Chartist, by the way!

Ah, I just noticed that this is a duplicate of  #183. Sorry about that.


Module Patch HealthController Patch Causing Accesstools.property Warning

[Warning:  HarmonyX] AccessTools.Property: Could not find property for type GClass3097 and name Effects
After a raid using treatment will cause the warning above

Originally written by Kaeno

Accesstools will throw warnings if player doesnt have any effects while healing at end of raid.

Originally written by Kaeno


Manifest details should be preserved

Aside from jar signing details (issue #9), the manifest details should be preserved.

Fixed in c1032b3f855b67d2192242ac6ca9a257ce5283c0.


BRS-653: A&R Login Page

Jira Ticket:
BRS-653
Jira Ticket URL:
https://bcparksdigital.atlassian.net/browse/BRS-653
Description:

Added a custom login page for Attendance and Revenue
Changed the existing Not Authorized page to use a single column layout (similar to the new login page)
Infers the selected Identity Provider from the JWT token after successful log in and stores it in sessionStorage so future login requests to Keycloak will use the same IDP, even if the application is reloaded and its state is lost.

Closing since this is the same as BRS-647 and it hasn't been reviewed yet. Will create a new PR with just one commit.


Issue with Training a model on custom monocular video

I am trying to train the humannerf model on a custom video. I have followed all the steps to extract frames, generate masks, get matadata and used it to prepare dataset. The dataset was prepared properly and the demo code runs fine but the training causes the following error...
------------------ GPU Configurations ------------------
Primary GPUs: [0]
Secondary GPUs: [1]
Epoch: 1 [Iter 20, 19/570 (3%), 33.39 sec] Loss: 0.3246 [lpips: 0.3128 mse: 0.0117 ]
Epoch: 1 [Iter 40, 39/570 (7%), 11.57 sec] Loss: 0.3875 [lpips: 0.3733 mse: 0.0142 ]
Epoch: 1 [Iter 60, 59/570 (10%), 11.71 sec] Loss: 0.4727 [lpips: 0.4684 mse: 0.0042 ]
Epoch: 1 [Iter 80, 79/570 (14%), 12.65 sec] Loss: 0.2763 [lpips: 0.2682 mse: 0.0082 ]
Epoch: 1 [Iter 100, 99/570 (17%), 11.74 sec] Loss: 0.3598 [lpips: 0.3508 mse: 0.0090 ]
Evaluate Progress Images ...
0%|                                                                                | 0/16 [00:00<?, ?it/s]
Traceback (most recent call last):
File "train.py", line 32, in
main()
File "train.py", line 26, in main
train_dataloader=train_loader)
File "core/train/trainers/human_nerf/trainer.py", line 174, in train
is_reload_model = self.progress()
File "core/train/trainers/human_nerf/trainer.py", line 209, in progress
for _, batch in enumerate(tqdm(self.prog_dataloader)):
File "D:\ProgramData\Anaconda3\envs\humannerf\lib\site-packages\tqdm\std.py", line 1178, in iter
for obj in iterable:
File "C:\Users\humense\AppData\Roaming\Python\Python37\site-packages\torch\utils\data\dataloader.py", line 359, in iter
return self._get_iterator()
File "C:\Users\humense\AppData\Roaming\Python\Python37\site-packages\torch\utils\data\dataloader.py", line 305, in _get_iterator
return _MultiProcessingDataLoaderIter(self)
File "C:\Users\humense\AppData\Roaming\Python\Python37\site-packages\torch\utils\data\dataloader.py", line 918, in init
w.start()
File "D:\ProgramData\Anaconda3\envs\humannerf\lib\multiprocessing\process.py", line 112, in start
self._popen = self._Popen(self)
File "D:\ProgramData\Anaconda3\envs\humannerf\lib\multiprocessing\context.py", line 223, in _Popen
return _default_context.get_context().Process._Popen(process_obj)
File "D:\ProgramData\Anaconda3\envs\humannerf\lib\multiprocessing\context.py", line 322, in _Popen
return Popen(process_obj)
File "D:\ProgramData\Anaconda3\envs\humannerf\lib\multiprocessing\popen_spawn_win32.py", line 89, in init
reduction.dump(process_obj, to_child)
File "D:\ProgramData\Anaconda3\envs\humannerf\lib\multiprocessing\reduction.py", line 60, in dump
ForkingPickler(file, protocol).dump(obj)
_pickle.PicklingError: Can't pickle <class 'core.data.human_nerf.train.Dataset'>: it's not the same object as core.data.human_nerf.train.Dataset
D:\ProgramData\Anaconda3\envs\humannerf\lib\site-packages\numpy_distributor_init.py:32: UserWarning: loaded more than 1 DLL from .libs:
D:\ProgramData\Anaconda3\envs\humannerf\lib\site-packages\numpy.libs\libopenblas.GK7GX5KEQ4F6UYO3P26ULGBQYHGQO7J4.gfortran-win_amd64.dll
D:\ProgramData\Anaconda3\envs\humannerf\lib\site-packages\numpy.libs\libopenblas.XWYDX2IKJW2NMTWSFYNGFUWKQU3LYTCZ.gfortran-win_amd64.dll
stacklevel=1)
(humannerf) D:\work_data\Humense_Work\humannerf>------------------ GPU Configurations ------------------
Primary GPUs: [0]
Secondary GPUs: [1]
Traceback (most recent call last):
File "", line 1, in
File "D:\ProgramData\Anaconda3\envs\humannerf\lib\multiprocessing\spawn.py", line 105, in spawn_main
exitcode = _main(fd)
File "D:\ProgramData\Anaconda3\envs\humannerf\lib\multiprocessing\spawn.py", line 115, in _main
self = reduction.pickle.load(from_parent)
EOFError: Ran out of input
I am using a single NVIDIA RTX 2080 Ti and running the single-GPU training code. Can anyone guide me why this error is occuring

This might be due to the .pkl file being empty or doesn't exist at the path you are storing. Did you double-check the paths?

I am trying to train the humannerf model on a custom video. I have followed all the steps to extract frames, generate masks, get matadata and used it to prepare dataset. The dataset was prepared properly and the demo code runs fine but the training causes the following error...
------------------ GPU Configurations ------------------
Primary GPUs: [0]
Secondary GPUs: [1]
Epoch: 1 [Iter 20, 19/570 (3%), 33.39 sec] Loss: 0.3246 [lpips: 0.3128 mse: 0.0117 ] Epoch: 1 [Iter 40, 39/570 (7%), 11.57 sec] Loss: 0.3875 [lpips: 0.3733 mse: 0.0142 ] Epoch: 1 [Iter 60, 59/570 (10%), 11.71 sec] Loss: 0.4727 [lpips: 0.4684 mse: 0.0042 ] Epoch: 1 [Iter 80, 79/570 (14%), 12.65 sec] Loss: 0.2763 [lpips: 0.2682 mse: 0.0082 ] Epoch: 1 [Iter 100, 99/570 (17%), 11.74 sec] Loss: 0.3598 [lpips: 0.3508 mse: 0.0090 ] Evaluate Progress Images ... 0%| | 0/16 [00:00<?, ?it/s] Traceback (most recent call last): File "train.py", line 32, in main() File "train.py", line 26, in main train_dataloader=train_loader) File "core/train/trainers/human_nerf/trainer.py", line 174, in train is_reload_model = self.progress() File "core/train/trainers/human_nerf/trainer.py", line 209, in progress for _, batch in enumerate(tqdm(self.prog_dataloader)): File "D:\ProgramData\Anaconda3\envs\humannerf\lib\site-packages\tqdm\std.py", line 1178, in iter for obj in iterable: File "C:\Users\humense\AppData\Roaming\Python\Python37\site-packages\torch\utils\data\dataloader.py", line 359, in iter return self._get_iterator() File "C:\Users\humense\AppData\Roaming\Python\Python37\site-packages\torch\utils\data\dataloader.py", line 305, in _get_iterator return _MultiProcessingDataLoaderIter(self) File "C:\Users\humense\AppData\Roaming\Python\Python37\site-packages\torch\utils\data\dataloader.py", line 918, in init w.start() File "D:\ProgramData\Anaconda3\envs\humannerf\lib\multiprocessing\process.py", line 112, in start self._popen = self._Popen(self) File "D:\ProgramData\Anaconda3\envs\humannerf\lib\multiprocessing\context.py", line 223, in _Popen return _default_context.get_context().Process._Popen(process_obj) File "D:\ProgramData\Anaconda3\envs\humannerf\lib\multiprocessing\context.py", line 322, in _Popen return Popen(process_obj) File "D:\ProgramData\Anaconda3\envs\humannerf\lib\multiprocessing\popen_spawn_win32.py", line 89, in init reduction.dump(process_obj, to_child) File "D:\ProgramData\Anaconda3\envs\humannerf\lib\multiprocessing\reduction.py", line 60, in dump ForkingPickler(file, protocol).dump(obj) _pickle.PicklingError: Can't pickle <class 'core.data.human_nerf.train.Dataset'>: it's not the same object as core.data.human_nerf.train.Dataset D:\ProgramData\Anaconda3\envs\humannerf\lib\site-packages\numpy_distributor_init.py:32: UserWarning: loaded more than 1 DLL from .libs: D:\ProgramData\Anaconda3\envs\humannerf\lib\site-packages\numpy.libs\libopenblas.GK7GX5KEQ4F6UYO3P26ULGBQYHGQO7J4.gfortran-win_amd64.dll D:\ProgramData\Anaconda3\envs\humannerf\lib\site-packages\numpy.libs\libopenblas.XWYDX2IKJW2NMTWSFYNGFUWKQU3LYTCZ.gfortran-win_amd64.dll stacklevel=1)
(humannerf) D:\work_data\Humense_Work\humannerf>------------------ GPU Configurations ------------------
Primary GPUs: [0]
Secondary GPUs: [1]
Traceback (most recent call last): File "", line 1, in File "D:\ProgramData\Anaconda3\envs\humannerf\lib\multiprocessing\spawn.py", line 105, in spawn_main exitcode = _main(fd) File "D:\ProgramData\Anaconda3\envs\humannerf\lib\multiprocessing\spawn.py", line 115, in _main self = reduction.pickle.load(from_parent) EOFError: Ran out of input
I am using a single NVIDIA RTX 2080 Ti and running the single-GPU training code. Can anyone guide me why this error is occuring

hi~which method you choose to generate the mask?thanks~

Did you solve it, how did you solve it?

How do you extract frames, generate masks and get matadata？

It was a Windows issue, certain APIs were not working properly in Windows.
I shifted to Linux and the code started working fine.
On Tue, Jun 20, 2023 at 5:43 PM litchisea @.***> wrote:

Did you solve it, how did you solve it?
—
Reply to this email directly, view it on GitHub
https://github.com/chungyiweng/humannerf/issues/34#issuecomment-1598279769,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A2Y7F5WIHMOZYCHSLKMTC63XMFIBBANCNFSM57274H6A
.
You are receiving this because you authored the thread.Message ID:
@.***>

I used a simple script to extract and save the frames.
I then used the following code to generate masks
https://github.com/xuebinqin/DIS
and I used VIBE to extract metadata. If I recall correctly, I had to
manipulate the data generated by VIBE a fair bit to be able to get the
camera matrices and other documents.
On Fri, Jul 7, 2023 at 12:56 PM<PHONE_NUMBER> @.***> wrote:

How do you extract frames, generate masks and get matadata？
—
Reply to this email directly, view it on GitHub
https://github.com/chungyiweng/humannerf/issues/34#issuecomment-1624578520,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A2Y7F5RZZ5WNMBKCVHFDFCDXO53FXANCNFSM57274H6A
.
You are receiving this because you authored the thread.Message ID:
@.***>

I used a simple script to extract and save the frames. I then used the following code to generate masks https://github.com/xuebinqin/DIS and I used VIBE to extract metadata. If I recall correctly, I had to manipulate the data generated by VIBE a fair bit to be able to get the camera matrices and other documents.
…
On Fri, Jul 7, 2023 at 12:56 PM<PHONE_NUMBER> @.> wrote: How do you extract frames, generate masks and get matadata？ — Reply to this email directly, view it on GitHub <#34 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2Y7F5RZZ5WNMBKCVHFDFCDXO53FXANCNFSM57274H6A . You are receiving this because you authored the thread.Message ID: @.>

You used a simple script to extract and save the frames，can you post the program? My mail address is<EMAIL_ADDRESS>


[opencv] Expose api from opencv

Change-Id: Ie1b62b437184743339a31b7bd00c85b0f0efab15
Description
Brief description of what this PR is about

If this change is a backward incompatible change, why must this change be made?
Interesting edge cases to note here

Codecov Report

Merging #1367 (7e78589) into master (bb5073f) will decrease coverage by 0.48%.
The diff coverage is 61.65%.

@@             Coverage Diff              @@
##             master    #1367      +/-   ##
============================================
- Coverage     72.08%   71.60%   -0.49%
- Complexity     5126     5177      +51
============================================
  Files           473      480       +7
  Lines         21970    22473     +503
  Branches       2351     2413      +62
============================================
+ Hits          15838    16092     +254
- Misses         4925     5155     +230
- Partials       1207     1226      +19

Impacted Files
Coverage Δ

api/src/main/java/ai/djl/modality/cv/Image.java
69.23% <ø> (-4.11%)
:arrow_down:

...i/djl/modality/cv/translator/BigGANTranslator.java
21.42% <ø> (-5.24%)
:arrow_down:

...odality/cv/translator/BigGANTranslatorFactory.java
33.33% <0.00%> (+8.33%)
:arrow_up:

...nslator/InstanceSegmentationTranslatorFactory.java
14.28% <0.00%> (-3.90%)
:arrow_down:

.../modality/cv/translator/YoloTranslatorFactory.java
8.33% <0.00%> (-1.67%)
:arrow_down:

...i/djl/modality/cv/translator/YoloV5Translator.java
5.69% <0.00%> (ø)

...odality/cv/translator/YoloV5TranslatorFactory.java
8.33% <0.00%> (-1.67%)
:arrow_down:

...modality/nlp/embedding/TrainableWordEmbedding.java
45.00% <0.00%> (-3.34%)
:arrow_down:

...pi/src/main/java/ai/djl/ndarray/BytesSupplier.java
54.54% <0.00%> (-12.13%)
:arrow_down:

...i/src/main/java/ai/djl/ndarray/NDArrayAdapter.java
15.23% <0.00%> (-0.83%)
:arrow_down:

... and 123 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2f2d1c...7e78589. Read the comment docs.


Footer should be displayed based on content language, not country code

We talked over global ruleset, and it seems much simpler to display the footer based on the content of the page (i.e. the us/ or mx/ in the URL).

/cc @mikefantini

closed with #5623


Cannot rename config entry (within Devices & Services)

After a fresh install, every time I try and rename the default config entry of "mainsailos" in the Devices & Services menu, it is reset back to "mainsailos" after I navigate away from the menu.
Small issue but I would like to be able to rename it.
Running release v0.2.0 via HACS. No logging or debugging info needed.

@DrFate09 Do you expect that to also rename all the entity under it ?
If not, i'll have a fix soon for the renaming

@cashew22 I do not expect that behavior.

Will get fix in next release

(0.3.0, lauching in few hours)


Add method for creating text/html response

I'm doing some experiments with serving static content and though this could be useful  in addition to jsonString and text methods on Response.

Codecov Report

Merging #543 (304957d) into release/next (22fb2bf) will decrease coverage by 0.18%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           release/next     #543      +/-   ##
================================================
- Coverage         57.45%   57.26%   -0.19%
================================================
  Files                66       66
  Lines              1469     1472       +3
  Branches             53       59       +6
================================================
- Hits                844      843       -1
- Misses              625      629       +4

Impacted Files
Coverage Δ

zio-http/src/main/scala/zhttp/http/Response.scala
40.47% <0.00%> (-3.12%)
:arrow_down:

...ttp/src/main/scala/zhttp/service/HttpRuntime.scala
96.42% <0.00%> (-3.58%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22fb2bf...304957d. Read the comment docs.

Hi @jczuchnowski
A better api design would be using Zstream instead. In it, the method would take in the path of the HTML file and use Zstream to read it.

@girdharshubham your suggestion makes the use case very narrow. This method could be easily used also to serve some arbitrary html assembled in the application.
But maybe it would make sense to have a couple of overloaded methods that can take a String or a Path? And maybe a ZStream version too?

@jczuchnowski  Yes, that would be great!

One small change @jczuchnowski. Looks good other wise :)


ocamlPackages.reason-native.qcheck-rely: remove

ocamlPackages.reason-native.qcheck-rely: remove
Build is broken. Unmaintained.

It isn't unmaintened. Upstream used version 0.9 of qcheck and version 0.9 it still build. check haven't reached 1.0 so maybe we can add another qcheck version ?

It isn't unmaintened.

This package hasn't received an update in 3 years:
https://github.com/reasonml/reason-native/tree/master/src/qcheck-rely
Reason project is dead.

Upstream used version 0.9 of qcheck and version 0.9 it still build. check haven't reached 1.0 so maybe we can add another qcheck version ?

I'm not sure that is a good idea.

It require a 2 lines patch to build https://github.com/reasonml/reason-native/pull/269/commits/280b3ba7513add0f3d7e47def3f7ddefcec09fea I wouldn't say unmaintened. Would you accept PR if I add me as maintainer ?

It require a 2 lines patch to build reasonml/reason-native@280b3ba I wouldn't say unmaintened. Would you accept PR if I add me as maintainer ?

Sure.

@Et7f3 I think we could merge it with adding it back and  your patch as well

@Et7f3 I think we could merge it with adding it back and your patch as well

Use fetchpatch to fetch from commit (not PR) of upstream PR.
Add URL of upstream PR as comment at top of it.


Typo

Just found few typo on README.md
Also noticed there are two Supporters, but I haven't deleted either of them.

Thank you for your commitment!
I had better use Grammarly... (Just found the VSCode addon for it)


Add support for attributes section for OIDC connections

Describe the issue:
Currently, attribute section is not supported for OIDC connections in the console. We need to support the attribute section for OIDC connections for custom claim mappings

The attribute section is available in IS 6.1.0.
https://github.com/wso2/product-is/assets/37938529/634a8088-8537-4b19-935e-0d731a46bdae
Seems there is an extension configuration issue, which causes to hide the Attributes tab in the OIDC connection.

This should be hidden since the default behaviour does not honor the custom claim mappings previously. With the fix https://github.com/wso2/carbon-identity-framework/pull/5481, the default behavior will be changed to honour the custom claim mappings. Hence we can show the attribute section. But we need to hide this section / or add a banner when the authentication.endpoint.enable_custom_claim_mappings config is set to false.

Fix:

https://github.com/wso2/identity-apps/pull/5445

Verified in latest wso2is-7.0.0-beta7-SNAPSHOT

Hi there, do you have an estimate for when this bug fix will be available in a beta release patch? Thanks.


ansiblels completion does not work with default config

Description
ansiblels completion does not work with default configuration:
LspLog show error message for each attempt to get completion suggest:
[ERROR][2022-08-02 16:22:38] ...lsp/handlers.lua:455	"An error occurred in 'onCompletion' handler: [TypeError] Cannot read properties of undefined (reading 'provideRedirectModules')\nTypeError: Cannot read properties of undefined (reading 'provideRedirectModules')\n    at /home/user/.local/share/nvim/mason/packages/ansible-language-server/node_modules/@ansible/ansible-language-server/out/server/src/providers/completionProvider.js:45:112\n    at Generator.next (<anonymous>)\n    at fulfilled (/home/user/.local/share/nvim/mason/packages/ansible-language-server/node_modules/@ansible/ansible-language-server/out/server/src/providers/completionProvider.js:5:58)"
[ERROR][2022-08-02 16:22:38] ...lsp/handlers.lua:455	"An error occurred in 'onCompletion' handler: [TypeError] Cannot read properties of undefined (reading 'provideRedirectModules')\nTypeError: Cannot read properties of undefined (reading 'provideRedirectModules')\n    at /home/user/.local/share/nvim/mason/packages/ansible-language-server/node_modules/@ansible/ansible-language-server/out/server/src/providers/completionProvider.js:45:112\n    at Generator.next (<anonymous>)\n    at fulfilled (/home/user/.local/share/nvim/mason/packages/ansible-language-server/node_modules/@ansible/ansible-language-server/out/server/src/providers/completionProvider.js:5:58)"

Neovim version
NVIM v0.7.2
Build type: Release
LuaJIT 2.1.0-beta3
Nvim-lspconfig version
06744ba3783ce2d502838f988dec95378543f5d7
Operating system and version
Arch Linux
Affected language servers
ansiblels
Steps to reproduce

Install: mason.nvim + mason-lspconfig
Uninstall: nvim-lsp-installer
Install: ansible-language-server
Open ansible-file
Start server with: LspStart ansiblels
Start typing/modifying

Actual behavior
No completion from LSP-source available, only from current buffer
Expected behavior
Should be available completion for ansible modules, for example:
When typing: ansible.builtin.shell - it should display a list of options
Minimal config
Using mason-lspconfig/mason

LSP log
https://gist.github.com/sincomil/51384201beff913dd2a51804db864a1c

error is occurring in completionProvider.js, which is code we don't own. An ansible user needs to debug this and send a PR.

Let me disagree with you, @justinmk
[ansiblels.lua[(https://github.com/neovim/nvim-lspconfig/blob/master/lua/lspconfig/server_configurations/ansiblels.lua) - is a configuration file for ansible-language-server. This config file is provided by neovim-lspconfig. My research has led me to the fact that this config file is missing important configuration options, so correct config file should include that options:
return {
  filetypes = {
       "yaml-ansible",
  },
  settings = {
    ansible = {
      ansible = {
        path = "ansible",
        useFullyQualifiedCollectionNames = true
      },
      ansibleLint = {
        enabled = true,
        path = "ansible-lint"
      },
      executionEnvironment = {
        enabled = false
      },
      python = {
        interpreterPath = "python"
      },
      completion = {
          provideRedirectModules = true,
          provideModuleOptionAliases = true
      }
    },
  },
}

when you use this setting in your config the issue fixed?

Then someone needs to send a PR to update the asiblels.lua config.

Most of what @sincomil suggested is the defaults and should not be needed to send? https://github.com/ansible/ansible-language-server/blob/v1.0.1/docs/settings.md

The configs in this repo are provided as a starting point. We depend on users (like you) to troubleshoot issues with their specific LSP setups and send improvements.
If you have a usage question, try asking it at:

https://github.com/neovim/neovim/discussions
https://vi.stackexchange.com/

If you found a bug in the core Nvim  vim.lsp module (not part of this repo), the best way to get it fixed is to report to Nvim (not nvim-lspconfig) with:

steps to reproduce it without the particular LSP server and other factors particular to your environment
a failing test case added to lsp_spec.lua, which has code to setup a fake LSP server to simulate various scenarios


Feat/uniswap v3 routes

Before submitting this PR, please make sure:

[x] Your code builds clean without any errors or warnings
[x] You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
This PR add routes and endpoint that interacts with uniswap v3 LP contracts.
Tests performed by the developer:
Tested all new endpoints with curl
Tested and ensured new/updated unit tests pass
Tips for QA testing:
Curl test should be done in the following order:

Execute evm/approve with connector: 'uniswap' 2 tokens
Execute evm/approve with connector: 'uniswapLP' 2 tokens
Use both tokens approved for both contracts for the rest of the endpoints
Execute amm/liquidity/price with period: 1, interval: 1 to know the current pool price
Execute amm/liquidity/add
Execute amm/liquidity/position with tokenId set to the Id if the position created from previous add endpoint - id can be found by looking and output of that transaction hash or etherscan or other block explorer
Execute amm/liquidity/collect-fee with created tokenId. Note that this would either fail with error or return a response with hash that fails execution if either unclaimed fees is 0. Unclaimed fees can be seen the previous call.
Execute amm/liquidity/close with created tokenId. This will return a response with an has that closes specified position and burns token.

4-7 can be repeated if same tokens are reused, else repeat from 1 for tokens that have never been approved.
Also, I strongly advise this test shouldnt be done on ethereum L1 mainnet. Any testnet or L2 is fine.

Hi @vic-en, please fix branch conflicts in this PR. thanks!

@JeremyKono, fixed!

Testing in progress, just getting some issues when running the curl command for request/eth_approve.json where getting network error. please cehck your node URL, API key and internet connection.. at the moment. When it was checked yesterday I did not experience this issue on local so I was testing this now on AWS but still getting the same error..

@rapcmia From the screenshot provided it shows there was a disconnection from the node. Kindly check network connections and test again.

@vic-en please check and resolve branch conflicts in this PR. Thanks!

Tried to test again with the latest PR updates, now getting error of Token not supported:... for both DAI and USDC tokens when trying to run curl for requests/eth_approve.json. I tried to play around the token addresses I can found for USDC on kovan testnet and add it to gateway/src/chains/ethereum/erc20_tokens_kovan.json but still no go. Just checking if there is something we missed or possible related to #5342, thank you

PR update:

wallet/add: ok
wallet: ok
evm/approve for uniswap and uniswapLP
amm/liquidity/price set period and interval to 1: ok

However, when running the amm/liquidity/add the tokenID we need for the next curl commands is always at 0

PR update:

wallet/add: ok
wallet: ok
evm/approve for uniswap and uniswapLP
amm/liquidity/price set period and interval to 1: ok

However, when running the amm/liquidity/add the tokenID we need for the next curl commands is always at 0

That token Id will only be a non-zero if a  tokenId param was passed in that call to increase liquidity.
However, you're trying to mint a new Id which can only be available after that transaction is mined. So you'll gave to poll that transaction and retrieve the tokenId from the tx receipt.


Double caching?

When there is no any option (r.Options.String() = 0x0) it leads to double caching (no fragment cached image ({remote_url}) and fragment cached image ({remote_url}#options).
Ofc, I can fix it just by adding extra check `r.Options.String() == "0x0", but I have some questions:

why it works like that?
is there any problem to disable caching for 0x0 version of image?

interesting... I'm not sure why I've never paid attention to that before.  You're definitely right that it's double caching the unmodified image, and we should fix that.  I don't think it will be quite as simple as checking for "0x0", since depending on where you do that check, you miss out on things like checking for whether a 304 response should be returned.  I'll certainly leave this open to fix when I get a chance.  Looking at the TransformingTransport also reveals some wasteful reading of the response when no transformation is going to take place, so some of this code may be do for a larger refactor.

Actually I just added this dirty check to data.go:

Test cases:

access {{host}}/https://image.com - will lead to cache only original and no trasformation check/copy. State in cache: only original.
access {{host}}/10x10/https://image.com - will lead to check cache to have 10x10 version and then fallback to original check without fragment. Then it will transform it to 10x10 and cache it. State in cache: original & 10x10 version.
access {{host}}/11x11/https://image.com - will lead to check cache to have 11x11 version and then fallback to original check without fragment. Then it will transform original to 11x11 and cache it. State in cache: original, 10x10, 11x11

I hope my investigation help you to resolve this :)


Error: Member not found: 'pie_chart_outlined' when adding import shark

I'm doing a little test running something similar to the example provided. But just importing the shark library to the top, this following error occurs
To Reproduce
Steps to reproduce the behavior:

add import 'package:shark/shark.dart' em main.dart
compile any empty widget, a container for example, without shark implementation
3 - Error: Member not found: 'pie_chart_outlined'. 'pie_chart_outlined': Icons.pie_chart_outlined,

Screenshots

Smartphone (please complete the following information):

Device: Flutter emulator(androidx86) and WXGA tablet API 29

Initially I thought I had inserted an incorrect json, but I changed the page to one that counted an empty Container and even then just importing the shark library this problem already occurs, I would know if it is some missing configuration
?

Thank you for reporting the issue, I am looking into it.
What is your Flutter version ?


Parameter.Value.Builder#orDefault does not mark parameter as optional. Also another request

SpongeVanilla version: 1.16.4-8.0.0 (commit 81f8ff9aab292daec57472cad8bb08b194d65997)
Java version: 8
Operating System: Windows 10
Plugins: WIP plugin for api-8

I don't think I need to explain more but when building a parameter with orDefault, it will not be marked as optional even when we force it using optional() method.
I have another request about the orDefault method.
It is said in the javadoc that orDefault fills the parameter when missing AND when parsing failed.
It could be cool to have the opportunity to separate these two cases, for example with orDefaultOnFail(), and orDefaultOnMissing()..  (with better names maybe)
Thanks for reading this issue

orDefault is going away. It will be up to the developer to check to see whether something has parsed.

orDefault is going away. It will be up to the developer to check to see whether something has parsed.


windows_registry: add api which accepts just the target arch

Currently rustc has to pass the actual value of the --target argument to cc::windows_registry::find_tool, making it one of the only places in rustc where the name of the target matters rather than the contents of the target. This also for example means that if you take the target spec of x86_64-pc-windows-msvc and put it in a file called aarch64-foo.json, rustc will incorrectly try to find a linker for aarch64. Or more realistically if you name it foo.json, rustc will not know which target to find a linker for even though the target spec itself contains the architecture to compile for.

Perhaps we could also change it to take either just the arch, or a full target triple? And then deprecate the former?

Maybe we should split that part into a separate crate?
I feel like it is not exactly part of cc, just put it in cc for convenience, and sometimes we might want to change its API.


Move to pimusicbox organisation

This issue tracks the move to a Pi Musicbox GitHub organisation at https://github.com/pimusicbox.
Hopefully the move will allow for greater community involvement but it's important that @woutervanwijk's original vision for Pi Musicbox with a focus on usability and simplicity is preserved as it's this we owe for the projects popularity.

[ ] Commit the released v0.6 files to GitHub (https://github.com/woutervanwijk/Pi-MusicBox/issues/311)
[x] Transfer this repository
[x] Transfer the mopidy-websettings
and Mopidy-MusicBox-Webclient
 repositories
[x] Assign Maintainer Roles on PyPi for mopidy-websettings and Mopidy-MusicBox-Webclient
[x] Host pimusicbox.com on GitHub Pages (https://github.com/pimusicbox/pimusicbox.github.io/pull/1)
[x] Share access to Twitter and Facebook accounts.

@woutervanwijk, I think we need you for all of these.  None of this blocks the v1.0 release but it'd be great to get things moving when you can.

For transferring the repositories: see https://help.github.com/articles/transferring-a-repository/
For changing roles on PyPi: visit the project page and click 'roles' near the top

This seems completed, with the exception of #311 which is tracked as its own issue assigned to @woutervanwijk. Closing :-)


feat: Add semantic tokens

Add semantic tokens (using hotpink as for missing values)

Only a few hotpinks left

Only one to go now. 💪   ...but maybe we should keep that one, just because nothing is the same without hotpink. 😄


Create a clearer division between the API and the Runtime

Right now it is not exactly clear what the API and Runtime parts of Amethyst are actually for. What I mean is that the API contains classes like HookManager and InputManager, while the Runtime appears to be whats responsible for making them work...
I think this is fine, having common data, structures, and functionality in the Amethyst API, as well as initializing hooks and executing input callbacks in the Runtime - but I think it should be a cleaner setup to make it clear what exactly everything is.
Most modding platforms such as forge offer an "Event Bus", and I think amethyst should have something similar. From my understanding, Amethyst is supposed to be like Fabric but for Bedrock edition, so having mods initialize their own hooks is reasonable, but I think having a central "Event Bus" system should also be provided to help mod compatibility.
On top of all of this, Hook Manager, Config, Runtime Input Manager are all members of the AmethystRuntime class - why?
Mod functions are a strange concept as well, this is functionality that can be replaced with the event bus idea (with the exception of mod initialization and shutdown, for example).
The solution to this I believe is to have a central AmethystAPI class that contains a map of a type id hash, and a corresponding instance. This would be for quick access to the various API feature singletons, such as Hook Manager. The API is never responsible for creating hooks, but it, in my opinion, should be responsible for managing them.
On top of this, I think there should be a central system for getting the addresses of various symbols and class member offsets. The runtime would be responsible for actually finding these addresses and offsets with the use of signatures. The API can then be written to use these addresses and offsets provided by the Runtime in a central way, allowing for the API itself to be almost versionless in a way. The Runtime would be the only thing that needs to be 'updated', with the exception if Mojang removes a class member or function.
In conclusion, the Runtime itself would be solely responsible for finding functions and offsets. The API would be responsible for managing the results from the Runtime, as well as providing a central means to manage hooks, events, and provide classes, structs and functions for Mods.

The current thing holding us back from this right now is the launcher: https://github.com/FrederoxDev/Amethyst/issues/32 as in its current state, some hooks are time dependent so it didn't make complete sense to have two separate things. A better launcher that injects earlier is currently being worked on

It's certainly not everything, but this commit moves away from using ModFunctions in favor for creating callbacks https://github.com/FrederoxDev/Amethyst/commit/4b560ebfdacfd0309365bb5c4bfc3e4e309570a2

https://github.com/FrederoxDev/Amethyst/commit/734a64e993910493f5b3bff9021502402623d764


demo.html throws "ReferenceError: cytoscape is not defined"

After a fresh clone, opening demo.html in Firefox 54 throws the following errors:
The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol.  demo.html
ReferenceError: cytoscape is not defined[Learn More]  demo.html:42:21
	<anonymous> file:///tmp/cytoscape.js-view-utilities/demo.html:42:21

I think the problem is that this import does not exist: http://cytoscape.github.io/cytoscape.js/api/cytoscape.js-latest/cytoscape.min.js
I could get it to work by replacing the link with https://cdnjs.cloudflare.com/ajax/libs/cytoscape/3.1.2/cytoscape.min.js.

It should be ok now, please can you verify and close the issue?

Thanks for the lightning fast fix, it works now!


Fix for blank django form fields when VectorField is not required

If you have a non-required VectorField in django (null=True/blank=True), the saving or creation of a model with a django form would error when trying to save it as blank. This was due to the inherited functionality from forms.CharField. If you look at how JSONFields (which also inherit CharField) they do the same thing as this fix for empty_values. You can try my test case before/after the change in forms.py.

Thanks, let me know if this looks better.

Thanks @Cdingram, looks good without the last commit.

Yeah sorry github made me think there was no space. Reverted it.

Looks great, thanks!


Updated CSS and made it more interactive

Like what changes do u want in css only u want right?

Actually it's not looking good

only faculty page?

Yes

I have opened new pull request to improve UI

Then delete the updated faculty file here because the changes persist here, I can't merge it with that

I am closing this pull request.

Deleted the file.

@Anu27n Made another PR for these changes i have reverted it because it deleted the original file from main branch


KARAF-7155 - Deleting a factory configuration doesn't delete the associated json file

JsonConfigInstaller keeps tracks of configurations that are associated
to a json file. When the configuration is deleted it will try to delete
the file.

@jassuncao what about using felix.fileinstall.filename to delete the file ? This way we don't have to store the factory/pid in the map, just read the felix.fileinstall.filename from the properties and remove it.
It's the fix I did.
Thoughts ?

@jbonofre I had the idea configuration properties wouldn't be available after receiving a ConfigurationEvent.CM_DELETED. I'm almost sure I attempted that, but I might have missed something,

@jassuncao thanks, let me try something and I will let you know.

Actually, it works for me.


Store activity type / mission model description into the database

Checked for duplicates
Yes - I've already checked
Alternatives considered
No - I haven't considered
Related problems
No response
Describe the feature request
Right now we're building description into the compiled mission model, we should also store this into the database.

GSFC's MMS effort has recently encountered a use case for this - it would be nice for documentation to show up whenever an activity directive or span is moused over.


why kaspersky endpoint security tell me trojan

Hey this is because we don't "sign" builds yet, which is why you will see warning from Windows or antivirus
However all the code is open source, we have nothing to hide and no reason to do so, you don't need to worry about this.
We will take actions to make sure Windows does not send this kind of warning in the near future


Use IdentifierPreparer.format_table

@graingert

@cpcloud

Awesome! Glad to know there's a better solution.


[SPARK-29642][SS] Change the element type of underlying array to UnsafeRow for ContinuousRecordEndpoint

What changes were proposed in this pull request?
This patch fixes the bug that ContinuousMemoryStream[String] throws error regarding ClassCastException - cast String to UTFString. This is because ContinuousMemoryStream and ContinuousRecordEndpoint uses origin input as it is for underlying data structure of Row, and encoding is missing here.
To force encoding, this patch changes the element type of underlying array to UnsafeRow instead of Any for ContinuousRecordEndpoint - ContinuousMemoryStream and TextSocketContinuousStream are modified to reflect the change.
Why are the changes needed?
Above session describes the bug.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Add new UT to check for availability on couple of types.

Test build #112868 has started for PR 26300 at commit f457f40.

Can one of the admins verify this patch?

cc. @tdas @zsxwing @jose-torres @gaborgsomogyi

Test build #112868 has finished for PR 26300 at commit f457f40.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ContinuousRecordEndpoint(buckets: Seq[Seq[UnsafeRow]], lock: Object)

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112868/
Test FAILed.

Test build #112876 has started for PR 26300 at commit 8cf2eba.

Test build #112876 has finished for PR 26300 at commit 8cf2eba.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112876/
Test PASSed.

Looks good as far as I can tell.

retest this please

Test build #113289 has started for PR 26300 at commit 8cf2eba.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18197/
Test PASSed.

Test build #113289 has finished for PR 26300 at commit 8cf2eba.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113289/
Test PASSed.

Merging to master.

Thanks for reviewing and merging!


Fix/bench results

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Docs
[ ] New Binding issue #___
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes, and the changes were approved in issue #___
[x] No

Checklist

[ ] When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
[ ] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
[ ] I have added a convincing reason for adding this feature, if necessary

Other information
Similar to https://github.com/tauri-apps/tauri/pull/5798
The main reason the benchmarks broke / went weird, were because of ubuntu-latest changing from 20.04 to 22.04.
This PR fixes the interpretation of results. But doesn't address the performance regression in https://github.com/tauri-apps/tauri/issues/5800.

Example run going here https://github.com/Beanow/wry/actions/runs/3660440260/jobs/6187577193

Let me know if this PR needs breaking up into parts or can be reviewed as a whole?


feat: add session helper in request context

RelatedTo: https://github.com/goravel/goravel/issues/357
📑 Description
✅ Checks

[x] My pull request adheres to the code style of this project
[x] My code requires changes to the documentation
[ ] I have updated the documentation as required
[ ] All the tests have passed

CI failed, and where is the session middleware, please?

start_session middleware is not driver specific, that's why i have included it in framework.
https://github.com/goravel/framework/tree/kkumar-gcc/%23357/session/middleware


vineyard_read_orc faild on k8s with GraphScope

Describe your problem
A clear and concise description of what your problem is. It might be a bug,
a feature request, or just a problem that need support from the vineyard team.

If is is a bug report, to help us reproducing this bug, please provide information below:

Your Operation System version (uname -a):
k8s  v1.23.6

The version of vineyard you use (vineyard.__version__):
0.18.1

Versions of crucial packages, such as gcc, numpy, pandas, etc.:

Full stack of the error (if there are a crash):

2023-11-17 06:41:04,779 [DEBUG][script:82]: command is: /home/graphscope/.local/lib/python3.10/site-packages/vineyard/drivers/io/kube_ssh.sh gs-new-orc-jacky:gs-engine-saddem-0 vineyard_read_orc /tmp/vineyard_workspace/vineyard.sock "hdfs:///vertex/graphscope_uid_vertex/dt=2023-10-29/000000_0" eyJob3N0IjogImh3eS1objEtcmlza21ndC1oZHAtbm4tcHJkLTAyLm15aGxsLmNuIiwgInBvcnQiOiA4MDIwLCAiZmlsZXR5cGUiOiAiT1JDIn0= eyJkZWxpbWl0ZXIiOiAiLCIsICJoZWFkZXJfcm93IjogdHJ1ZSwgInNjaGVtYSI6ICJ1X2lkIiwgImNvbHVtbl90eXBlcyI6ICJzdGQ6OnN0cmluZyIsICJpbmNsdWRlX2FsbF9jb2x1bW5zIjogdHJ1ZSwgImFjY3VtdWxhdGUiOiBmYWxzZX0= False 1 0
2023-11-17 06:41:07,193 [DEBUG][launcher:155]: driver: [return] o04952ddf24ad78dc
2023-11-17 06:41:07,193 [DEBUG][stream:184]: [wait] partial ids = [o04952ddf24ad78dc]
Exception ignored in:
<function Launcher.__del__ at 0x7fd0bb505360>
Traceback (most recent call last):
  File "/home/graphscope/.local/lib/python3.10/site-packages/vineyard/launcher/launcher.py", line 63, in __del__
self.join()
  File "/home/graphscope/.local/lib/python3.10/site-packages/vineyard/drivers/io/stream.py", line 156, in join
raise RuntimeError(
RuntimeError
:
Subprocesses failed with the following error:
Failed to launch job [/home/graphscope/.local/lib/python3.10/site-packages/vineyard/drivers/io/kube_ssh.sh gs-new-orc-jacky:gs-engine-saddem-0 vineyard_read_orc /tmp/vineyard_workspace/vineyard.sock "hdfs:///vertex/graphscope_uid_vertex/dt=2023-10-29/000000_0" ...], exited with 134:
2023-11-17 14:41:06,409 WARN util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
terminate called after throwing an instance of 'orc::TimezoneError'
  what():  Can't open /etc/localtime
command terminated with exit code 134

extra diagnostics are as follows:
2023-11-17 06:41:08,228 [DEBUG][op_executor:921]: new_protocol = vineyard, new_source = o04952ddf6e732724

Minimized code to reproduce the error:

# GraphScope Load Vertex and Edge
graph = (
        graph.add_vertices(Loader("hdfs:////vertex/graphscope_uid_vertex/dt=2023-10-29/000000_0",filetype="ORC",host="ip", port=8020)
                           ,label="u_id"
                           ,vid_field='u_id'
                          )
            .add_edges(
                   Loader("hdfs:///edge/graphscope_uid_edge/dt=2023-10-30/000000_0",filetype="ORC",host="ip", port=8020)
                   ,label="login"
                   ,src_label="u_id"
                   ,dst_label="u_id"
                   ,src_field='src_u_id'
                   ,dst_field='dst_u_id'
                 )

          )

CMD ERROR
Failed to launch job
/home/graphscope/.local/lib/python3.10/site-packages/vineyard/drivers/io/kube_ssh.sh \
gs-new-orc-jacky:gs-engine-saddem-0 \
vineyard_read_orc \
/tmp/vineyard_workspace/vineyard.sock \
"hdfs:///vertex/graphscope_uid_vertex/dt=2023-10-29/000000_0" \

LOG
exited with 134:
2023-11-17 14:41:06,409 WARN util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
terminate called after throwing an instance of 'orc::TimezoneError'
  what():  Can't open /etc/localtime
command terminated with exit code 134

when change read csv file, it's running success!

Hi @JackyYangPassion, thanks for reporting the issue.
Based on the log info, it looks like caused by the timezone error. Could you please check whether the time file /etc/localtime exist in the pod? Also, you could try set the following env to workaround it.
env:
- name: TZ
   value: "Asia/Shanghai"

See also: https://issues.apache.org/jira/browse/ARROW-16386

Hi @JackyYangPassion, thanks for reporting the issue.
Based on the log info, it looks like caused by the timezone error. Could you please check whether the time file /etc/localtime exist in the pod? Also, you could try to add the following env to workaround it.
env:
- name: TZ
  value: "Asia/Shanghai"

Not exist in the pod
kubectl exec -it gs-engine-kggmoi-0 bash -n gs-new-orc-jacky2

in the pod the
localtime -> /usr/share/zoneinfo/Asia/Shanghai

do you mean add /etc/localtime file in each pod?
@dashanji

See also: issues.apache.org/jira/browse/ARROW-16386

thanks for your reply!
the pod linux version is
PRETTY_NAME="Ubuntu 22.04.3 LTS"
NAME="Ubuntu"
VERSION_ID="22.04"
VERSION="22.04.3 LTS (Jammy Jellyfish)"
VERSION_CODENAME=jammy
ID=ubuntu
ID_LIKE=debian
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
UBUNTU_CODENAME=jammy

but follow the issue
i don't know which dockerfile modify?
can you help me?

Fixed in https://github.com/alibaba/GraphScope/pull/3363


In windows prompts cannot be chinese refer to pathlib read_text

Description
In windows , prompts cannot be chinese , because  pathlib read_text default to use gbk to read prompts file;
Proposed Changes
pathlib read_text add encoding=utf-8 params
Checklist

[ *] I have tested these changes locally.
[ *] I have reviewed the code changes.
[ *] I have updated the documentation (if necessary).
[ *] I have added appropriate unit tests (if applicable).

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree

Thanks for the contribution @liseri! Should errors be set here as well? And do you think it would be more helpful to have errors=‘strict’ (which would raise an error and exit) or errors=‘ignore’?

Thanks for the contribution @liseri! Should errors be set here as well? And do you think it would be more appropriate/helpful here to have errors=‘strict’ (which would raise an exception and exit) or errors=‘ignore’?

This is a common bug with the Windows system in China, caused by various factors, primarily summarized as follows: GPK, as a universal code, is widely used, but the Win32 interface at the bottom of Windows defaults to using system variables. This variable can be modified to other encodings, but it may cause some programs to crash because some programs do not use this Win32 interface when running. This issue is mostly resolved by upstream frameworks specifying an encoding parameter or by directly using binary reading.
In this case, binary reading should be used instead of file stream reading.

Thanks for the contribution @liseri! Should errors be set here as well? And do you think it would be more appropriate/helpful here to have errors=‘strict’ (which would raise an exception and exit when non-utf8 is encountered) or errors=‘ignore’?

It is sufficient to set the utf-8 parameter  ; because the prompts file is generated by graphrag itself in utf-8, ensuring that read_text reads in utf-8 will guarantee correctness; if the utf-8 parameter is not set for read_text, it may read using the operating system’s default character encoding (such as gbk encoding on Windows systems).

Thanks for the contribution @liseri! Should errors be set here as well? And do you think it would be more appropriate/helpful here to have errors=‘strict’ (which would raise an exception and exit when non-utf8 is encountered) or errors=‘ignore’?

It is sufficient to set the utf-8 parameter  ; because the prompts file is generated by graphrag itself in utf-8, ensuring that read_text reads in utf-8 will guarantee correctness; if the utf-8 parameter is not set for read_text, it may read using the operating system’s default character encoding (such as gbk encoding on Windows systems).

@liseri what are your thoughts on @glide-the 's comment? We could replace this by binary reading

@liseri what are your thoughts on @glide-the 's comment? We could replace this by binary reading

I think that solution is better; I just chose the simplest approach, as I didn’t want to implement something too complicated; as long as the issue can be resolved, I’m open to any solution; I’ll go ahead and close this pull later.

@liseri why close this ticket? it is a bigger issue for windows user...


[Bug]: UnityEngine.Texture::GetDataWidth not resolved

All of the following criteria must be met

[X] All Requirements must be installed.
[X] Full Latest.log file included. If no file exists then leave this unchecked and state so.

All of the following are optional to answer

[X] Tried reinstalling the Game.
[X] Tried reinstalling MelonLoader.
[x] Tried restarting PC.
[ ] Was able to see the Start Screen.

Describe the issue.
Latest.log
I am trying to play MellonLoader with a small game. However, I encountered the following error without any pointers to interpret. After the messages shown in the log, the game starts with a black screen and then quits immediately.
[18:16:33.674] [MelonStartScreen] Exception while init rendering: System.TypeInitializationException: The type initializer for 'MelonUnityEngine.Texture' threw an exception.
 ---> System.Exception: ICall UnityEngine.Texture::GetDataWidth not resolved
   at UnhollowerMini.UnityInternals.ResolveICall(String signature) in D:\a\MelonLoader\MelonLoader\Dependencies\MelonStartScreen\UnhollowerMini\UnityInternals.cs:line 278
   at UnhollowerMini.UnityInternals.ResolveICall[T](String signature) in D:\a\MelonLoader\MelonLoader\Dependencies\MelonStartScreen\UnhollowerMini\UnityInternals.cs:line 287
   at MelonUnityEngine.Texture..cctor() in D:\a\MelonLoader\MelonLoader\Dependencies\MelonStartScreen\UnityEngine\CoreModule\Texture.cs:line 24
   --- End of inner exception stack trace ---
   at MelonUnityEngine.Texture..ctor(IntPtr ptr) in D:\a\MelonLoader\MelonLoader\Dependencies\MelonStartScreen\UnityEngine\CoreModule\Texture.cs:line 35
   at MelonUnityEngine.Texture2D..ctor(Int32 width, Int32 height) in D:\a\MelonLoader\MelonLoader\Dependencies\MelonStartScreen\UnityEngine\CoreModule\Texture2D.cs:line 56
   at MelonLoader.MelonStartScreen.UI.UI_Utils.CreateColorTexture(Color color) in D:\a\MelonLoader\MelonLoader\Dependencies\MelonStartScreen\UI\UI_Utils.cs:line 11
   at MelonLoader.MelonStartScreen.UI.Objects.UI_Background..ctor(cBackground backgroundSettings) in D:\a\MelonLoader\MelonLoader\Dependencies\MelonStartScreen\UI\Objects\UI_Background.cs:line 16
   at MelonLoader.MelonStartScreen.UI.UI_Style.Init() in D:\a\MelonLoader\MelonLoader\Dependencies\MelonStartScreen\UI\UI_Style.cs:line 16
   at MelonLoader.MelonStartScreen.ScreenRenderer.Init() in D:\a\MelonLoader\MelonLoader\Dependencies\MelonStartScreen\ScreenRenderer.cs:line 38

Did you attach your log file?

[X] Yes, I attached my log file to the text box above.
[ ] No, I could not find a log file at {Game_Directory}\MelonLoader\Latest.log

The start screen isn't required, can you launch with --melonloader.disablestartscreen?

The start screen isn't required, can you launch with --melonloader.disablestartscreen?

Hi thank you for your help. May I know how can I launch it with arguments? Currently the way I launch it is simply launching the game via shortcut.

The start screen isn't required, can you launch with --melonloader.disablestartscreen?

Hi thank you for your help. May I know how can I launch it with arguments? Currently the way I launch it is simply launching the game via shortcut.

if your game is on steam right click the game on steam and open "properties" and past "--melonloader.disablestartscreen" into the box with the label "Advanced users may choose to enter modifications to their launch options"
if your game is not on steam find the EXE for the game and create a shortcut. right click that shortcut and open "properties" under the shortcut tab add the launch argument to the end of the exe in the "target" field.

Here is the log I run with --melonloader.disablestartscreen: Latest.log.

same issue as #433 and #437


YouTube API

Search YouTube for video
Get YouTube video to play while user is writing letter
Hide YouTube player

Hahaaa I didn't write an issue for this because I didn't want to draw attention to the fact that this application is held together by PAPERCLIPS AND GUM

But yes the site does play music now


Delete unpaired bridges

:recycle: Current situation
Describe the current situation. Explain current problems, if there are any. Be as descriptive as possible (e.g., including examples or code snippets).
:bulb: Proposed solution
Describe the proposed solution and changes. How does it affect the project? How does it affect the internal structure (e.g., refactorings)?
:gear: Release Notes
Provide a summary of the changes or features from a user's point of view. If there are breaking changes, provide migration guides using code examples of the affected features.
:heavy_plus_sign: Additional Information
If applicable, provide additional context in this section.
Testing
Which tests were added? Which existing tests were adapted/changed? Which situations are covered, and what edge cases are missing?
Reviewer Nudging
Where should the reviewer start? what is a good entry point?

Closing PR as it was created on tatest, not on beta-5.0.0


json outpus are outdated

The datamodel shown in the run section of develop still shows the old datamodel. The GET is just confusing since visually it's a different JSON output. However POST operations will fail if copied.

I already have this done and push to a branch, just cannot PR due to GH errors :)


LE Audio: Advertising (service) data for one or more services/roles

Is your enhancement proposal related to a problem? Please describe.
In LE Audio we have multiple services and roles which require specific advertising data to be sent. Examples here are the CSIS RSI (which often is connectable extended advertising), Broadcast Source ID (non-connectable extended advertising) and the BASE (periodic advertising).
Ideally we would want as few advertising sets as possible (if supporting unicast and broadcast audio, at least 2 sets is necessary), while still ensuring that the advertising data required by the services and roles are advertised.
Currently both the CSIS server and the broadcast source will create their own advertising set to advertise CSIS PRI and the broadcast source ID + BASE respectively.
Describe the solution you'd like
One solution would be to not have the profile implementations create advertising sets, but rather expose an API to return the needed advertising data.
For CSIS this can be done via a simple function to get the RSI, and possibly with a callback as the RSI needs to be updated whenever the RPA is updated.
For broadcast source we can also easily return the broadcast source ID after a broadcast source has been created. Similarly, but perhaps less trivial, we can also return the
Describe alternatives you've considered
One alternative is to still let the profile implementations control the advertising data, and have the application provide either the app-defined advertising data to the API, such that the profile implementations can append that data to the advertising sets they create. This arguably is a simpler solution, but would still require multiple advertising sets.
Additional context
If we allow the application to control the advertising set, then more responsibility is shifted to the application, and they may behave against the profile specifications. E.g. for the BAP broadcaster it is not allowed to stop the extended or periodic advertising once the BIG has been created. Similarly for the CSIS, it is required to update the advertised RSI when the RPA is updated.

Somewhat related to https://github.com/zephyrproject-rtos/zephyr/issues/33777


Split out into a small stub command line and a library

this is pretty much the smallest change to split this out and it
exposes a few things that can be improved later
no change to logging yet

Signed-off-by: Justin Cormack<EMAIL_ADDRESS>

cc @chungers this should be relatively easy to integrate into Infrakit. Will do some more cleanup in subsequent PRs, eg logging and vendoring and cleaning up the API a bit more.


Ignore some images in (image: …) kirbytag

Is there a way to add a class to an image tag or parent container that will prevent imageset from lazy loading it or doing anything to it?

No, this is currently not possible by using a parameter. However, you could can copy a customized version of the image tag into site/tags and add a parameter that allows you to disable ImageSet on certain images or even disabling it by default.
You can find the code for the image tag in https://github.com/fabianmichael/kirby-imageset/blob/master/tags/image.php
When doing this, you should add c::set('imageset.tags.image', false) to your config.php.
But as I think, this would be an excellent addition to the plugin, I woudl be happy to add this feature at some point. I’m just thinking about how these options should be named. Maybe imageset.tags.image.default for config and (image: … imageset: false) for the parameter?

I thought it could be handy to let the developer choose whether imageset should be opt-in or opt-out for Kirbytext, that’s was this option was supposed to be for.

Brilliant. In my mind it would be something like imageset.tags.image.optional, and if it were set to true, then the (image: ... imageset: false) feature would have an effect.

@fabianmichael this may warrant a new issue, but would it be possible to prevent imageset from running on a certain page? I'm not loading the header scripts on a certain page, but that doesn't seem to prevent it from working on the images.

@lukehatfield This won’t work, as ImageSet generates special HTML code for lazy-loading. The plugin has no way of determing whether a certain script is loaded or not. As there are lots of different script-loading methods and build processes, it would not be feasible to attempt that.


[F7v2] Event Calendar + new Tabs

Add the new event list tabs.
Migrate event calendar. (Each tab gets one, vs shared one for all three tabs?)
Docs on calendar for v2: https://framework7.io/docs/calendar.html

Migrated over, issues outlined in #272 but should be fixed with just API changes. If not, can address later.


error when running wsinfer version

i am running a singularity container built from commit 01b6d4304943c58dfdd4e2b80a421bebf00b1e7e (the latest in the wsinfer branch). most things seemed to work but there is an error at the end.
$ cd /data08/shared/jkaczmarzyk/debug-uh3-tcga-brca
$ singularity exec --bind $(pwd)/outputs/datasetA:/data --contain tilalign_dev-01b6d430.sif Rscript --vanilla /code/commandLineAlign.R inceptionv4 /data/results-tils/model-outputs 0.1 /data/results-tumor/model-outputs 0.5 "" output.csv /data/tilalign true

Attaching package: ‘dplyr’

The following objects are masked from ‘package:plyr’:

    arrange, count, desc, failwith, id, mutate, rename, summarise,
    summarize

The following objects are masked from ‘package:stats’:

    filter, lag

The following objects are masked from ‘package:base’:

    intersect, setdiff, setequal, union

Attaching package: ‘raster’

The following object is masked from ‘package:dplyr’:

    select

[1] "TIL Algorithm (Threshold): Frontiers InceptionV4: 0.1"
[1] "=========== Params after R parsing, if any misalignment please check your flags ==========="
$algorithm
[1] "inceptionv4"

$tilDir
[1] "/data/results-tils/model-outputs"

$tilThresh
[1] 0.1

$cancDir
[1] "/data/results-tumor/model-outputs"

$cancThresh
[1] 0.5

$sampFile
[1] ""

$outputFile
[1] "output.csv"

$outputDir
[1] "/data/tilalign"

$writePNG
[1] TRUE

[1] "Sample 1: 1.75252525252525"
[1] "Sample 2: 1.75"
[1] "Sample 3: 1.75"
[1] "Sample 4: 1.75"
null device
          1

here are the outputs of the script.
$ tree outputs/datasetA/tilalign/
outputs/datasetA/tilalign/
├── invasion_histogram.pdf
├── output.csv
└── PNGs
    ├── TCGA-3C-AALI-01Z-00-DX1.F6E9A5DF-D8FB-45CF-B4BD-C6B76294C291.csv.thresh.png
    ├── TCGA-3C-AALJ-01Z-00-DX1.777C0957-255A-42F0-9EEB-A3606BCF0C96.csv.thresh.png
    ├── TCGA-3C-AALK-01Z-00-DX1.4E6EB156-BB19-410F-878F-FC0EA7BD0B53.csv.thresh.png
    └── TCGA-4H-AAAK-01Z-00-DX1.ABF1B042-1970-4E28-8671-43AAD393D2F9.csv.thresh.png

1 directory, 6 files

it looks like the .pdf of the results was not written. could that be the problem?

null device is just what the write to pdf call spits out when you call dev.off(), thats not an error. Although it should be suppressed.
What does invasion_histogram.pdf look like?

ok so the script was successful? here is the histogram

yea the histogram just looks terrible because its default bin width with only 4 samples. I'll put a flag in the histogram generation to choose better bin widths by n samples


Optionally encode physical sector size in image name

With some real world drives (e.g. FUJITU M2624S) the physical sector size can be changed when formatting. Some tools support this and change the sector size with MODE SELECT (provided that MODE SENSE reports it to be changeable) right before formatting a drive. After FORMAT UNIT has completed the drive has a new physical sector size. rascsi currently displays a warning with a note to use the -b startup option in order to set a different sector size (the one required for the respective client platform).
If the sector size were encoded in the filename, rascsi would be able to actually format drives with a different sector size, namely by renaming the image file accordingly.
Suggested approach: The sector size in bytes is encoded right before the extension, preceded by a dot, e.g. image_file.512.hds or image_file.1024.hda. If a file with this filename format is attached and if no explicit sector size is set on the command line, rascsi will automatically set the sector size to the value encoded in the filename. Illegal values will be rejected, just like the -b option does it. rasctl will not be involved, i.e. the filename is evaluated by rascsi only. Instead of using the command line option to override the size it might be better to report an error if there is a mismatch.
When changing the sector size when formatting the drive, rascsi uses the sector size provided with the subsequent MODE SELECT to rename the file, e.g. from image_file.512.hds to image_file.2048.hds.
If a filename does not have an encoded sector size when formatting with a new size, the file shall be renamed, i.e. the new sector size is inserted before the extension. image_file.hds would become image_file.2048.hds, for instance. If the size does not change no renaming takes place.

An optional approach here would be to make the rascsi backend aware of and store this information in the *.properties files that the Web Interface uses for this purpose.
In fact, the proposed scheme to append the block size to the file name would break the current implementation of *.properties for the Web Interface in the corner case where both are applied at the same time. Similarly to the issue described in https://github.com/akuker/RASCSI/issues/786
I'm not married to the current *.properties scheme either, so I'm open to revisiting this for a more sturdy approach that the rascsi backend manages.

@rdmark In https://github.com/akuker/RASCSI/issues/786 I already mentioned issues caused by additional files. And there is one more issue I think I did not mention: Currently a user can copy an image with any available means in order to get a fully working clone. With additional files this is not possible anymore, which is a disadvantage.

Going to close this ticket because it apperas to open Pandora's box, without resolving anything that cannot easily be handled (at least since release 22.10.01) by using the -b option for the respective drive.


MultiChainComparison M parameter

Do we really need the M parameter for MultiChainComparison? Took me a few minutes of debugging to figure out it only worked if I input three predictions and that I need to change M to fix it.
I would suggest moving the code that assembles the signature to the forward pass so it's no longer necessary to set M.
MultiChainComparison code:
https://github.com/stanfordnlp/dspy/blob/main/dspy/predict/multi_chain_comparison.py

Hmm, the number affects the signature which needs to be known ahead of time. Right?
Maybe we should have an assertion or something?

There is an assertion, it just doesn't give you an explanation of what's going on


Clarify Azure OpenAI api_base with an example.

Why are these changes needed?

It clarifies what api_base from Azure OpenAI Api looks like

Related issue number
Nil
Checks

[ x] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[ x] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ x] I've made sure all auto checks have passed.

Thanks! @thinkall @BeibinLi can you check if the added clarification is helpful?

Codecov Report

Merging #396 (f7dddc1) into main (3991f86) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
- Coverage   40.16%   40.13%   -0.04%
==========================================
  Files          18       19       +1
  Lines        2385     2392       +7
  Branches      540      540
==========================================
+ Hits          958      960       +2
  Misses       1350     1350
- Partials       77       82       +5

Flag
Coverage Δ

unittests
40.13% <ø> (-0.04%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 3 files with indirect coverage changes

LGTM

@joshkyh could you please fix the format issue? Thanks.

@joshkyh could you please fix the format issue? Thanks.

Hi @thinkall , Sorry, I was looking through the failing builds to find the "format issue" you were referring to. I didn't change /home/runner/work/autogen/autogen/test/test_retrieve_utils.py or retrieve_utils.py, could I please clarify what do you mean by the format issue?
Thank you.

@joshkyh could you please fix the format issue? Thanks.

Hi @thinkall , Sorry, I was looking through the failing builds to find the "format issue" you were referring to. I didn't change /home/runner/work/autogen/autogen/test/test_retrieve_utils.py or retrieve_utils.py, could I please clarify what do you mean by the format issue?
Thank you.

This one in the tests: https://github.com/microsoft/autogen/actions/runs/6651348348/job/18073203692?pr=396
First run pre-commit install, then pre-commit.
You can ignore other errors, this will be fixed in another PR.

@joshkyh could you resolve the conflict with main? We can merge after that.

@joshkyh could you resolve the conflict with main? We can merge after that.

https://github.com/microsoft/autogen/blob/main/notebook/oai_openai_utils.ipynb is now a much better contribution in clarifying the API base than my contribution, I'll withdraw my contribution. Thanks for reviewing @thinkall  @gagb  @sonichi


FAQs give incorrect example of a top-level settings

The FAQ section "How does Ruff's import sorting compare to isort" contains a pyproject.toml example config to demonstrate the known-first-party setting.
Included in this example config is the top-level src setting (+ comment noting it is a top-level setting), which is not preceded by the correct/required heading, [tool.ruff]. Instead, it sits right below lint-specific settings, which makes the explanatory comment sound confusing and may mislead users with regard to where src can/needs to be set.
Docs/FAQ source

@MichaReiser I just had another look at the FAQ and saw that in the next section, How does Ruff determine which of my imports are first-party, third-party, etc.?, src is actually explained in detail.
Is it possible the example for known-first-party was originally intended for that section? Or was the idea to provide a complete/working if minimal example for how to configure Ruff for isort?
My suggestion would be to move the (corrected) example away from where it's currently at and into the next FAQ section (minus the then redundant explanatory comment). If readers of the isort section should be made aware the next point is sort of a continuation of the wider topic, or that it includes a fuller example, I could briefly mention that.

Ping, @MichaReiser.

Thanks @keikoro -- I think that's the right diagnosis. Updated here to match your suggestion: https://github.com/astral-sh/ruff/pull/11829.


A few improvements for Tabs

A few things I noticed when testing out tabs:

Multiple tabs with the same item keys would produce conflicting ids on the page. Added a base id for the tabs instance so this is avoided.
Ensure the selected tabs receives focus when tabbing into the tablist, rather than only the first item. This was actually an issue in the selection hooks, so would apply across all collections.
Ensure a tab is always selected, even when no defaultSelectedKey is passed. This will select the first tab by default.

Haven't touched css yet. This is mostly just a demo of aria so far.

awesome work!!
is there a reason why there is no docs page for useTabs? I checked also the generated documentation on this PR and there is no Tabs docs inside the react-aria package.
thanks in advance!

@horacioh no docs yet because this will be an alpha and we don't have a feature flag system in our docs yet, so these will get docs when they get their first semver release

@horacioh no docs yet because this will be an alpha and we don't have a feature flag system in our docs yet, so these will get docs when they get their first semver release

awesome!! thanks for the info @snowystinger


Typo in 3.2.5 pg 85

Figure 3.7 uses gauss_imputation_known_params_demo.ipynb where the dimension of the variables D is 8 and the number of samples N is 10.  However, the second paragraph of 3.2.5 states that the dimension is 10.

fixed, thanks


Add posibility to configure upintheair plot in the admin / settings

It would be nice if one could enable/disable the plot.
even better would it be, if one could change parameters like stroke/fill colour opacity stoke thickness.
if one could add multiple plots(different hights, or reciever plot), that would be absolutely great.

Will see what I can do.

This has been added to my next gen portal TODO list. I am going to close this issue due to the fact that In the near future the portal will reside in it's own repository. The new portal is a total rewrite and totally different creature making most all portal issues posted here invalid.


UI Should Scale for higher resolution monitors

The menu was designed primarily using a 1080p monitor and works well for that resolution. At 1440p, elements can start to feel a bit small. At 4k, items are absolutely tiny and need to be scaled up for the user.
Solutions:

Apply the non-standard zoom CSS property available in CEF. (This is a non-standard feature and can be subject to change in the future, would prefer to not use if possible. Unfortunately, this will also probably be the easiest to implement seamlessly with minimum changes.)
Adjust the breakpoint system and to be more suited towards desktop development and not mobile responsiveness. (Adjusting breakpoints like this often leads to small CSS issues that can become aggravating to fix).

Note: Often when developing for regular browsers, users with 4k screen will enable a browser setting to enable auto scaling. Since this is CEF, there aren't many good solutions for enabling these scaling options programmatically

Although zoom and transform property works in general, popover elements are not handled properly. This is fixed in #439 as it utilizes Popper v2. When that is merged, this should be fairly easy to implement well.

We also need to do a max-width on the entire thing since some people have ultrawide screens.


Is it possible to combine clicks with keyboard events?

I'm trying to test a multi-select component, where if you shift-click on options, you can select multiple options. I've tried this:
syn.type(select1.children[0].domNode, "[shift]")
syn.click(select1.children[0].domNode)
syn.type(select1.children[0].domNode, "[shift-up]", function() {
    console.log("donezo")
})

But it doesn't seem to work. The click happens, but the shift doesn't seem to be incorporated. is it currently possible to do what i'm trying to do?

I don't know, but it should be made possible.

You mean you don't know if its already possible? Or you don't know how you'd implement it?

I don't know if it's already possible.  If it's not possible, we should make it work.


Some calculators name under 3D shapes are not visible

Describe the bug
Some calculators name under 3D shapes are not visible
Screenshots

go ahead @abhijeet141 :)
Dead line 30 june


Add keyboard and focus support

Based on recommended shortcuts specified by the DHTML Style Guide Working Group:

Up: Select the previous visible tree item.
Down: Select next visible tree item.
Left: Collapse the currently selected parent node if it is expanded. Move to the previous parent node (if possible) when the current parent node is collapsed.
Right: Expand the currently selected parent node and move to the first child list item.
Enter: Toggle the expanded or collapsed state of the selected parent node.
Home: Select the root parent node of the tree.
End: Select the last visible node of the tree.
Tab: Navigate away from tree.
* (asterisk on the numpad): Expand all group nodes.

#4 is related.


[FORMATS-181] Use qualityScores for base quality scores

Fixes #181

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/bdg-formats-prb/194/
Test PASSed.


Call Flush between test cases in compliance suite.

Once the Flush RPC is implemented, ensure that we call Flush between compliance test cases to remove any entries and start with an empty RIB. This ensures that there are not test failures on real implementations that do not reinitialise their RIB between transactions when running with PRESERVE persistence.

Fixed in #112


Cleanup

Introduced some config for linting, editorconfig, gitignore etc.
Also refactored towards es2015 and modularized a bit.

:+1: Okay, looks good to me. Somebody else might want to check if it works in their browser too. :cat:

@RobinThrift thank you!

That's good enough for me right now. I am merging this in :)

Okay, great! Cool stuffs!