chore: upgrade relay deps and fix typing issues

Description
This PR comes as an effort to bring improvements to the home and my collection tabs. See https://artsyproduct.atlassian.net/browse/CX-3468
Spoiler: I am preparing to introduce defer and evaluate updating the way we query the data
Please note that some of the bugs were already there but we were not picking them up, I ignored them for now but I think we should fix them next time we touch those lines
This was a hard one to get done 😢

PR Checklist

[x] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@MounirDhahri let me know if you wanna pair on avoiding passing the mockenvironment to actual components, happy to help and I've played around with relay testing a bunch


[CRITICAL] [UX Reliability] User is showing as Hidden even when they initiated the conversation with you

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @danielrvidal
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1717688493562419
Action Performed:
Break down in numbered steps

As Alice, sent money to another existing account (Bob) that you have never chatted with before
Bob receives an email after a moment saying Alice paid him
Bob signs into NewDot in the most recent mode
Bob can see Hidden in the LHN
Navigate to that chat
Its the DM with Alice showing as hidden

Expected Result:
Describe what you think should've happened
When you send someone a message/ money, request money, you should be able to see their email.
Actual Result:
Describe what actually happened
The user/chat is showing as hidden until you open the IOU report.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/36083550/71f95e8c-00d6-4cfc-a7f8-707d9d5315a2

View all open jobs on GitHub

@mountiny this one looks free, I think I can work on it.

Based on the initial discussions as well as my own investigations I can confirm this requires backend changes.
Hidden is the very last fallback, meaning we were not able to fallback to anything more meaningful not even get personalDetails for this accountId - there's nothing better we can display as of now on the UI.

Hey @neil-marcellini here's an SO on how to handle this issue: https://stackoverflowteams.com/c/expensify/questions/19512
As a reminder, we are getting laser-focused on app quality as we take New Expensify to market.

I was told that I should focus on report pagination and re-assign this one. Looks like you're the lucky winner @techievivek

Awaiting @techievivek to come back from OOO to move this forward.

I'm not able to repro this one.

Are we sure this is still happening? Can't reproduce either. @mountiny should we add the retest label maybe?

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

This exact issue needs reproduction and also needs the person who reported it to be assigned so we can use the debugging tools we have to triage exactly what is wrong with their account.

If someone runs into the bug where a user initiates a chat with you and appears as Hidden let’s reopen this issue


cy.react after updating the state does not find the updated component

See details in https://github.com/bahmutov/cypress-react-unit-test/issues/381

fixed  in V2.0.1


Missing color for onboarding slides

What went wrong:
Execution failed for task ':app:processObfPlaystoreDebugResources'.

A failure occurred while executing com.android.build.gradle.internal.res.LinkApplicationAndroidResourcesTask$TaskAction
Android resource linking failed
ERROR:/home/runner/work/openfoodfacts-androidapp/openfoodfacts-androidapp/app/src/obf/res/layout/welcome_slide3.xml:22: AAPT: error: resource color/bg_screen3 (aka openfoodfacts.github.scrachx.openbeauty.debug:color/bg_screen3) not found.

That might have been fixed. Closing


Always prefer stricter comparisons and assertions.

Always prefer stricter comparisons and assertions.

Thank's for this PR. Merged. Should be released on next version.


Support specifying interfaces to mock when using source mode

Requested feature A clear description of the desired feature and an example of
how it would be used.
As far as I can tell, there is no way to specify which interfaces to mock out of a file when using source mode
Why the feature is needed A clear description of how this feature is not
served by existing functionality in gomock.
The closest you can get to this functionality is manually passing in every interface other than the one you want to mock in -exclude_interfaces
(Optional) Proposed solution A clear description of a proposed method for
adding this feature to gomock.
Adding an -interfaces flag which auto-computes the -exclude_interfaces flag would be relatively straightforward I think.

@kliukovkin created a PR on the initial repo but nobody reviewed it: https://github.com/golang/mock/pull/659
Potentially it could just be added here @r-hang?

Hey, this makes sense to us. We welcome anybody moving the PR here for our review.

Thanks @KastenMike for raising this! Here is the PR https://github.com/uber-go/mock/pull/200


When I start my computer it does not startup, it does not apply Dark theme though

Have you hit the apply button in the configurator yet? When the apply button is pressed it will create a startup taskschedule.

Hi @ChrisAnd1998! I have the same problem, that

TaskbarX doesn't launch after system boots.
And Configurator never remembers my config.
I mean every time I run TaskbarX manually, the taskbar will not be Transparent until I run Configurator to set it to Transparent and click Apply manually again.

@b4imetu Are you able to type in your startmenu "Taskscheduler" and open it?
Just want to make sure if you even have access to it. If you don't then your pc is probably owned by an organisation like a school or work. And they blocked access to it.

@ChrisAnd1998 Yes I have access to Taskscheduler and I didn't see anything about TaskBar in that.
By the way, I didn't install TaskbarX from Microsoft Store. I just extract TaskbarX_22.05.2020_<IP_ADDRESS>.zip and run TaskbarX.exe, but the program didn't seem installed on my computer. I can't find any shortcuts created on my desktop or startmenu. And Configurator never remembers my config as I mentioned.

@b4imetu Well something must be preventing TaskbarX from creating a Taskschedule. Maybe an antivirus software other than Windows defender... The settings are also stored in the taskschedule so that means both issues lead the same issue.


Bug Report: Ctrl-W for cut not working in Emacs in Ubuntu-Terminal

Environment
Windows build number: Version 10.0.18362.175
Windows Terminal version (if applicable): Version 0.2.1715.0

Any other software?
Ubuntu 18.04.2 LTS in WSL
GNU Emacs 25.2.2

Steps to reproduce

I open a file with Emacs in Ubuntu from Windows Terminal.
I select a block of text by setting a Mark with Ctrl-Space and then pressing Up arrow key.
I press Ctrl-W to cut text.

Expected behavior
The block of text to be cut, as it does in Ubuntu WSL.
Actual behavior

When WSL Ubuntu is the only tab open:

DesktopWindowsXamlSource window shows up in taskbar for a second, and then Terminal crashes and that window closes.

When another tab is also open:

WSL Ubuntu tab just closes. The other tab remains open.

You can try to change this to another hotkey in config file. By default, ctrl+w means to close the tab.


Update MD file on new branch 2017-11-19_07-25-52

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Remove old sample recipes

Now that the sample recipes, and their git history, have been moved over to the new Sample Recipe Template repository, we should remove the legacy recipes from this project to avoid confusion.

Hey @acrosman I came across the sample recipe folder still in this repo, was about to create an issue, but see you already have.  I think we're ready to delete the snowfakery_samples folder from DataGenerationToolkit.  Assuming Github will let me do this, and if you have no objections, I'll do it before the meeting tomorrow.

This was merged on Oct-31, see PR https://github.com/SFDO-Community-Sprints/DataGenerationToolkit/pull/143.


Explanation of Benefits over Coc-Python

For those of us who have used Jedi in combination with LSP but don't have much technical knowledge about the two, could you maybe explain some of the differences from the other COC extension promoted by coc.nvim?

I haven't used coc-python in a long while, so I'm not up to speed on the benefits (if any) that coc-jedi currently has over coc-python. From a technical perspective:

coc-jedi is a wrapper around jedi-language-server while coc-python is a fork of Microsoft's vscode Python extension
jedi-language-server wraps jedi in a language server, while coc-python forks a language server that wraps a bunch of Python utilities (see here: https://github.com/Microsoft/vscode-python#feature-details )

Basically, over the past year or 2, I've had some frustration combating 3rd party dependencies / using the latest version of jedi my language server of choice, so I implemented my own language server. coc-jedi makes that language server easy to use with coc.nvim.
See here for an explanation of jedi-language-server's inspiration.
If you notice any benefits over the latest version of coc-python, I'd love to hear about them / add them to the readme! If not, please close this issue if I've answered your question sufficiently.

Thank you! I recently switched back to Emacs/Evil recently, but I've been comparing the LSP packages/plugins for both editors to find the areas where they can learn from each other. I'll have to spend more time with coc-jedi when I can find the time.


Monitor File Update Time on File/Folders

Could probably re-use existing script, but tweaked to allow user to select which data to monitor (creation, update, access).
Would be wise to extract the script into a probe module.

Rewrote script in powershell. Takes File time attribute as input parameter.
Added probes, datasources, monitory type and a monitor for the folder object. Does not alert on each and every file, but the folder alert will contain a summary.


Standardize post-onboarding settings window titles to navbar

Based on https://github.com/bitcoin-core/gui-qml/pull/290 rebased over main
This moves all settings pages titles post-onboarding into the navbar, standardizing where the title is for all pages. Whereas, currently, we have some within the page content and some in the page navbar. See this issue: https://github.com/BitcoinDesign/Bitcoin-Core-App/issues/55

cc @GBKS @mouxdesign

@GBKS @mouxdesign
The screenshots below show what the PR does comparing master and PR. Note that this pr only affects the page titles post-onboarding. When you are on the node page.
Master

settings
about
developer
display
storage
connection
proxy
peers
network

PR

settings
about
developer
display
storage
connection
proxy
peers
network

What it doesn't do is change where the page title is during onboarding. But, maybe we want to standardize the page titles into the navbar everywhere?
PR during onboarding

about
developer
storage
connection
proxy

Thanks for doing this. For reference, the reason why titles are bigger during onboarding is consistency. During onboarding, everything is bigger and chunkier. It should feel (and be) really simple, compared to later points in the experience when you navigate the settings pages with a more functional mindset. See the images below for the types of screens we have during onboarding.

ACK https://github.com/bitcoin-core/gui-qml/pull/346/commits/8f81f0d44fd80bb1027235f3bb0bde950a0615b8


Possible Algo. List and Difficulty level

We can compile a possible list of Algorithms to be implemented so that a person attempting as a beginner will not have much problem.
Further, I guess it would be nice to assign the work to implement the algorithms according to the difficulty level. Like a person who is familiar with coding will not attempt beginner level programs and maybe leave them for the new one's. Also, a time constraint would also be a good thing to add so that someone else who is ready to do it will get that chance.

See what we can do is that we can assign tags to every issue and can create a tag based assignment to every year students.

@Monal5031 @yashLadha Sounds good.. We can create tags like easy, medium, hard and expert.

This has been implemented, hence closing..


Text file busy (os error 26) with cargo lambda build

I keep encountering the following error when attempting to re-build my lambda project:
Error:   × error moving the binary `"/home/hkaiser/fleet-management-api/target/x86_64-unknown-linux-gnu/release/organization"` into the output location `"/home/hkaiser/
  │ fleet-management-api/target/lambda/organization/bootstrap"`
  ╰─▶ Text file busy (os error 26)

However, it does work when I delete the target directory and build it again. But I'd rather not do this every time I make a change to my code. Is this a known bug or is there something I'm doing wrong?

That usually happens if another process is doing something with either the specific bootstrap file, or with the target directory. This is not a but in cargo lambda. For example, I've seen something similar when Rust Analyzer is running and I try to run cargo build from my terminal.

Closing this ticket since it's not an issue in cargo lambda.


ViewComponentDescriptor.Type should be a TypeInfo instance instead of a Type instance

ViewComponentDescriptor.Type is of type System.Type while ControllerActionDescriptor.ControllerTypeInfo is of type TypeInfo.
We should change ViewComponentDescriptor.Type to ViewComponentDescriptor.TypeInfo and change the type of the property to be TypeInfo.
In general, TypeInfo represents the information of a type, while Type respresents a type at runtime. We should use TypeInfo through the stack and do AsType where we need an instance of Type.
I'm not sure if there is a scenario where AsType might return null and if we should guard against that.

I doubt we need null checks for this. Please time box the work so we don't spend a lot of time on it.

Agreed, we should be using TypeInfo here and other places. Please look at ParameterDescriptor as well and make sure it's consistent.

I'm not sure if there is a scenario where AsType might return null and if we should guard against that.

This seems excessive :laughing:

Oh wait a sec I could have swore yesterday that we agreed that Type was the right thing to use and TypeInfo is just an artifact of history. I guess I don't care much either way but this doesn't sound like what we discussed.


Unsupported language showing as initial language if detected by browser

Expected Behavior
My browser has currently has vietnamese, english then french languages however my application is setup for english and french language. From that, I expect to see my website in English.
Actual Behavior
My website is in english but shows vietnamese as current language.

Steps to Reproduce the Problem

Setup in your browser vietnamese as top language
Set this configuration:

{ defaultLanguage: 'en', otherLanguages: ['fr'], fallbackLng: 'en' }

Specifications

Version<EMAIL_ADDRESS>Platform: Google Chrome Version 71.0.3578.98 (Official Build) (64-bit)
Subsystem: OSX 10.13.6

Sorry - what exactly is the bug here? You don't want to see vi in i18n.language? If anything, you'll probably want to open this issue in react-i18next as it seems like an issue on that side of things.
You'll notice that the languages array contains en too. This means that i18next is trying to serve the client Vietnamese, but is falling back to English because Vietnamese isn't available.

@isaachinman it should not show vi as language but fr or en. Is it still a react-i18next issue?


Recognize metadata for auto-generated SED-ML

Arose from discussion with @bilalshaikh42. Motivated by limited SED-ML files for existing models. One workaround is to auto-generate SED-ML for models without SED-ML and then make it easy for users to filter these out. This would enable us to important a larger number of models into BioSimulations while making it easy for users to find high-quality simulations.

[x] Identify an appropriate predicate to indicate computationally generated files: http://biomodels.net/model-qualifiers/isDerivedFrom
[ ] Add to documentation for metadata conventions
[ ] Expand BioSimulators-utils code to process this
[ ] Expand BioSimulations data model to capture this
[ ] Add filter for this to project browser
[ ] Display this in project file views (files tab?)

:tada: This issue has been resolved in version 8.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Configure space around thematic break using padding instead of margin

The thematic break is the last non-section block whose padding is configured using top and bottom margins instead of padding. This leaves an inconsistency in the theme. The empty space around the thematic break should be controlled using the padding key instead. This means the padding can then be configured on all edges. The value of the block-margin-bottom key should be used to separate it from the next enclosed block.
If the padding is not set (or falsy), the value of the margin-top key should be used as the top and bottom padding values.

While working on this issue, I noticed that the bottom margin is not being applied if the thematic break falls at the top of the page. This should be addressed as part of this issue (mention it in the CHANGELOG).


[WIP] Support stack map

Solves #2553
It's with some hacking, and only for test purpose.

Currently, I am unsure about who should hold the stackIDMap (perhaps the front end which prints the stack? Is it localManager or IgManager?), nor do I know how the stack should be printed. I need further understanding of the project's structure.

The method mentioned in #2553 seems overly complicated; I am unsure why it requires mapping fd:
struct gadget_stack_ref {
    int stack_map; // fd of the stack map
    int stack_id; // value returned by bpf_get_stackid()
}

Furthermore, its purpose differs from that of MntNsFilter. I think we cannot simply copy the code from MntNsFilter because MntNsFilter needs to be accessed by facilities like localManager responsible for filtering container access, whereas stackIdMap is only used by the frontend and does not need to be accessed in various parts of the project.

containers with different versions of libc. So the address of a function on the stack has to be interpreted differently depending on the libc version. This can be resolved by using a different stack map for each uprobe attachment.

I may lack the necessary knowledge, but why can't stacks from different libraries & different gadgets be mixed within the same stack map? As I understand, the stack map simply associates a stackID with a stack (a set of addresses). In the example eBPF program attached to this PR, stackIDs are recorded alongside PIDs, and then the frontend uses the stackID to find the corresponding stack data, interpreting it using symbols associated with the PID. This doesn't seem to cause any confusion.

containers with different versions of libc. So the address of a function on the stack has to be interpreted differently depending on the libc version. This can be resolved by using a different stack map for each uprobe attachment.

I may lack the necessary knowledge, but why can't stacks from different libraries & different gadgets be mixed within the same stack map? As I understand, the stack map simply associates a stackID with a stack (a set of addresses).

Correct.

In the example eBPF program attached to this PR, stackIDs are recorded alongside PIDs, and then the frontend uses the stackID to find the corresponding stack data, interpreting it using symbols associated with the PID. This doesn't seem to cause any confusion.

Do we have to use the PID? I am concerned that if the target process terminates before ig could open /proc/$pid/maps, it can't work. I thought that if we know that the event comes from /bin/bash and /lib64/libc.so.6, we can resolve the addresses to the symbols even when the process terminated. In this case, we need to know if a probe comes from /lib64/libc.so.6 or another version of libc. But I guess I didn't account for memory relocations of dynamic libraries, so maybe my idea does not work.

@flyth I don't know where to add the code after the refactoring. I see field accessors have a method Set() which takes []byte as input, but in the case of a stack passed in a ring buffer, the serialized bytes are not enough because we need to have access to the stack map and do a bpf(BPF_MAP_LOOKUP_ELEM). Could you shed some light on this?

I think I need more info here - but it sounds like you would want to receive the stackID from the ring buffer, do the lookup in userspace and then send whatever you receive through the DataSource (and not (just) the stackID).

@flyth I don't know where to add the code after the refactoring. I see field accessors have a method Set() which takes []byte as input, but in the case of a stack passed in a ring buffer, the serialized bytes are not enough because we need to have access to the stack map and do a bpf(BPF_MAP_LOOKUP_ELEM). Could you shed some light on this?

I think I need more info here - but it sounds like you would want to receive the stackID from the ring buffer, do the lookup in userspace and then send whatever you receive through the DataSource (and not (just) the stackID).

Yes.

In the ring buffer, we get i.e. stack_id = 42.
We lookup stack_id = 42 in the stack map and we get the value []uintptr{0x123, 0x456, 0x789} (if the stack has a depth of 3).
We look at the target process to resolve those 3 addresses. And return the stack []string{"getchar", "readline", "main"} to the user.

@flyth I don't know where to add the code after the refactoring. I see field accessors have a method Set() which takes []byte as input, but in the case of a stack passed in a ring buffer, the serialized bytes are not enough because we need to have access to the stack map and do a bpf(BPF_MAP_LOOKUP_ELEM). Could you shed some light on this?

I think I need more info here - but it sounds like you would want to receive the stackID from the ring buffer, do the lookup in userspace and then send whatever you receive through the DataSource (and not (just) the stackID).

Yes.

In the ring buffer, we get i.e. stack_id = 42.
We lookup stack_id = 42 in the stack map and we get the value []uintptr{0x123, 0x456, 0x789} (if the stack has a depth of 3).
We look at the target process to resolve those 3 addresses. And return the stack []string{"getchar", "readline", "main"} to the user.

What should the UX be for now, then? Just a list of function names returned as string in a "stack" field - in JSON + columns?
Here's how I'd approach it (afaiu the PR):

prep: this needs to be extended to support maps in a generic way (right now we do it for hardcoded names, but we should also populate maps with a given prefix, IMHO); for a quick test, just add another exception a couple of lines below
create a new operator named "StackOperator" or something like it; make sure the operator registers itself on init() of the file like most other operators do and include it where other operators are included (for testing, could manually add in both occurrences in cmd/common/oci.go)
need to implement DataOperator interface and additionally the DataOperatorInstance interface on another type that can hold the stack map and is returned by the InstantiateDataOperator() func
in the InstantiateDataOperator(), check for the stack-map reference (and create/set/cache it) by using GetVar("mapname") & SetVar(); if it's there, also check DataSources in gadgetCtx for stackId (type:gadget_stack_id); if found, add a new field called "stack" to the DataSource and cache the accessor.
in PreStart(), subscribe to DataSources with the stackId; in the callbacks, extract stackId using the accessor, do the map lookup + extract info from the target process and set info using the accessor for the "stack" field (for initial version, I'd suggest just a concatenated, comma-separated string)
in Stop(), destroy the map.

See other operators like OciHandler, pkg/datasource/compat (used by KubeManager + LocalManager) and pkg/operators/formatters for general info on how operators are used.
I just talked to @alban and he said it might be much more complex than what I proposed since there could be multiple stack maps per gadget run (per container + per target lib version...). So if you prefer, feel free to go ahead and do a PoC that just prints the results to stdout and we'll find a way to integrate it properly afterwards.

What should the UX be for now, then? Just a list of function names returned as string in a "stack" field - in JSON + columns?

I think yes. There could be an option for a multiline output, such as bcc's tcpdrop tool:
https://github.com/iovisor/bcc/blob/6a5602cef2ebd97c351554d53a4f95532db6a568/tools/tcpdrop_example.txt#L7-L38

Also added trace_capabilities gadget, see #173 and #1319. But I don't know how to test it.

TODO: use ebpf extension to refactor this

The failure in documentation checks could be ignored, once this got merged, the link will be available.

As extension: https://github.com/i-Pear/inspektor-gadget/tree/stack_map_as_extension

Changed kernel stack map name to ig_kstack.

@i-Pear #2965 is merged. Could you rebase this PR? Thanks!

Also opened #3028 to fix a minor issue in builtin gadget.

Looks strange... The pkg/operators/ebpf: Support kernel stack map commit will modify pkg/gadgets/trace/tcp/tracer/tcptracer_arm64_bpfel.o, but seems they have no relationship.
And the amd64_bpfel.o is not modified, making it more strange...


Add cloud identity sidebar item

Forgot to add this in https://github.com/buildkite/docs/pull/432 😅

@keithpitt is this how the docs sidebar works now? Or do I need to change it in the main app?

@harrietgrace in both places - you need to add it in here and in the main app (and still do the bump thing) - it may be a little annoying for the time period - sorry!

No worries @keithpitt! Can do 👍🏻


Doen't unlock the Keyboard anymore

Just downloaded the new version and my keyboard remains locked after the countdown. (2016 MBP on 10.12.6) :/

Yeah me too
On 19 Sep 2017, 10:36 PM +1000, FlavourDaveMasterDDissle-theDtotheissle<EMAIL_ADDRESS>wrote:

Just downloaded the new version and my keyboard remains locked after the countdown. (2016 MBP on 10.12.6) :/
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

https://github.com/vitorgalvao/alfred-workflows/issues/31#issuecomment-287334987


[RR2] Upgrade net/http to fasthttp

Replace standard net/http module with the fasthttp. With this enhancement, we can reduce memory usage (because of sync.Pool which is used under-the-hood of fasthttp, and etc...) and provide a way more performant solution for the HTTP transport layer (see the benches here: https://github.com/valyala/fasthttp).

To be backward compatible with the existing HTTP plugin, it'll be a separate plugin for the users, who wants a super-fast HTTP layer.
The plugin name would be fasthttp, it'll support only HTTP (there is a lack of HTTPS support in the fasthttp IIRC).


"DateTransform" can not be overridden

ObjectMapper 2.0.0 in Xcode8 and Swift3
public func transformFromJSON(_ value: Any?) -> Date?
public func transformToJSON(_ value: Date?) -> Double?
For access modifier is "public", it can not be overridden.
override func transformFromJSON(_ value: Any?) -> Date? {
    // code
}

->  Overriding non-open instance method outside of its defining module

Duplicated with #580 and fixed in #605.

Thanks.


[BUG] yarn lint is failing

Describe the bug
yarn lint is failing with following error:
$ yarn lint
yarn run v1.22.19
$ yarn tsc --noEmit && yarn lint-es && yarn lint-sass
$ /home/ubuntu/OSD/oui/node_modules/.bin/tsc --noEmit
$ eslint --cache "{src,src-docs}/**/*.{ts,tsx,js}" --max-warnings 0

/home/ubuntu/OSD/oui/src/components/icon/icon.test.tsx
  34:21  error  Unable to resolve path to module 'cheerio'  import/no-unresolved

✖ 1 problem (1 error, 0 warnings)

Because of failed yarn-lint, I'm not able to commit the changes.
To Reproduce
Steps to reproduce the behavior:
Run yarn lint
Expected behavior
yarn lint should be successful.
OpenSearch Version
N/A
Dashboards Version
N/A
Plugins
N/A
Host/Environment (please complete the following information):

OS: [e.g. iOS]
Browser and version [e.g. 22]

Additional context
Add any other context about the problem here.

Check Cheerio:

rc.7 and rc.8 have issues with the folder structure in the release packages.
rc.6 causes a single test to fail by not matching the snapshot where the top values are off by 100px.
rc.5 passes all the tests and tolerates the overridden nested dependencies.


Distributable RMI primary changes in generated code

This pull request adds distributable(using RMI) and proxy pattern feature into the grammar and generated code. The generated code is still incomplete (Does not work for more than 1 component therefore does not distribute the system), but the changes to grammar are final.
1- Grammar changes:
1.1- a new directive is added: “distribute” can be “on”, “off”, or “forced”
Examples:
distribute on; // means the classes may be distributed. this is the default setting.
distribute off; // means the classes may NOT be distributed
distribute forced; // means all of the classes are distributed
1.2- a new keyword for classes and interfaces called “distributableRMI”
Examples:
class A {distributableRMI;}	// This means the class is distributable using RMI technology
interface IA{distributableRMI;} // Means every class implementing this interface will be distributable and the interface for communications in IA
1.3- a new keyword for classes called “proxyPattern” which means we want a default interface and a proxy file be generated.
2- Changes in the model:
2.1- UmpleModel class has three new boolean attributes:
“distributeOn” is true if distribute is “on” or “forced”.
“distributeForced ” is true if distribute is “forced”.
“distributed” is true only if there is at least one distributed class.
2.2- UmpleClassifier class has a boolean and a string attribute:
“isDistributable” which is true only if the keyword “distributableRMI” is used for the class or interface.
“distributeTechnology” which is RMI by default.( other technologies may added later)
2.3- UmpleClass has three new boolean attribute:
“isDistributed” is true only if the class is distributed for code generation purposes.
“hasProxyPattern” is true only if the class has proxy pattern for code generation purposes. this is always true if the class is distributed.
“needsDefaultInterface” is true if class is distributed or has proxy, unless it has a direct distributable parent interface.
3- Changes in the generated code:
for Classes that are distributable or have proxy pattern, the name of the class is changed to NAME+”Impl”. The generated class is parsed and all of the public methods are used to generate a proxy with the same name of the class and an interface with “I”+NAME.
The proxy delegates all of the public methods of the class and also overrides constructor. The proxy has three constructor to accept component number or component name. It uses the object factory to instantiate the actual class.
The proxy has the same name as the class so that we don’t need to change other classes.
UmpleObjectFactory class and IUmpleObjectFactory interface are generated using new templates.
For classes with proxies; changes to class generator templates are done to replace “this” reference to a reference realSelf which is a reference to the proxy of the class in method calls of generated codes for association. because no class other than the proxy should have access to it.
4- implementation/java/DistributedClassTest.java
Tests for changes in model when directives are used.
Tests for changes in model when keywords are used.
Tests for code generation for UmpleObjectFactory, proxies, distributed classes and interfaces.
5- To add;
reading from configuration file to have more than one components.
RMI connections to have more than 1 components.
add tests for the new features.

The PR succeeded. The issue with Appveyor is not with the PR. So I will merge it.


Types Parsing

Hi! At first, thank for your job!
Secondly, gqlmerge falls on the follow schema:
schema {
    query: Query
}

type Query {
    # first place it falls.
    # the message is `unexpected "=", expected "Ident"`
    admin(id: ID!, role: Role = ADMIN): Admin!
    user(id: ID!): User!
    search(text: String!): [SearchResult]!
}

interface Admin {
    id: ID!
    name: String!
    role: Role!
}

scalar Time

type User implements Admin {
    id: ID!
    name: String!
    email: String!
    role: Role!
    phone: String!
    address: [String!]
    # second place it falls.
    # the message is `unexpected "(", expected ":"`
    friends(page: Pagination): [User]
    createdAt: Time!
}

input Pagination {
    first: Int
    last: Int
}

enum Role {
    ADMIN
    USER
}

union SearchResult = User

Can you add some examples to act as tests please. Love the project but need examples to fix bugs I feel

@3timeslazy I've released a PR #4, please try again with it.
Thank you for your feedback.

It works! Thank you!


composite files feature

I think this is what I was calling the ability to have a file across multiple drives..


CUDA driver version is insufficient for CUDA runtime version?

When I tried to train mask-rcnn on coco, an unexpected error occurred. I was able to train other pytorch networks besides mmdection.
My driver version: 390.87
CUDA version: V9.0.176
2018-11-23 11:50:19,170 @train.py:61 - INFO - Distributed training: False
2018-11-23 11:50:20,460 @base.py:55 - INFO - load model from: modelzoo://resnet50
2018-11-23 11:50:20,856 @checkpoint.py:58 - WARNING - unexpected key in source state_dict: fc.weight, fc.bias

missing keys in source state_dict: layer2.3.bn1.num_batches_tracked, layer2.0.bn2.num_batches_tracked, layer1.0.downsample.1.num_batches_tracked, layer2.3.bn2.num_batches_tracked, layer4.2.bn3.num_batches_tracked, layer2.1.bn2.num_batches_tracked, layer3.0.bn2.num_batches_tracked, layer1.0.bn3.num_batches_tracked, layer3.0.bn1.num_batches_tracked, layer3.5.bn1.num_batches_tracked, layer1.2.bn2.num_batches_tracked, layer4.0.downsample.1.num_batches_tracked, layer1.1.bn2.num_batches_tracked, layer3.4.bn1.num_batches_tracked, layer2.1.bn1.num_batches_tracked, layer3.5.bn2.num_batches_tracked, layer3.1.bn3.num_batches_tracked, layer3.0.downsample.1.num_batches_tracked, layer1.1.bn3.num_batches_tracked, layer2.2.bn3.num_batches_tracked, layer4.0.bn2.num_batches_tracked, layer3.0.bn3.num_batches_tracked, layer3.4.bn3.num_batches_tracked, layer2.1.bn3.num_batches_tracked, layer3.5.bn3.num_batches_tracked, bn1.num_batches_tracked, layer3.2.bn2.num_batches_tracked, layer4.0.bn3.num_batches_tracked, layer1.2.bn1.num_batches_tracked, layer4.1.bn1.num_batches_tracked, layer2.2.bn2.num_batches_tracked, layer4.2.bn1.num_batches_tracked, layer2.0.downsample.1.num_batches_tracked, layer3.2.bn3.num_batches_tracked, layer2.0.bn1.num_batches_tracked, layer1.1.bn1.num_batches_tracked, layer3.3.bn1.num_batches_tracked, layer1.2.bn3.num_batches_tracked, layer4.0.bn1.num_batches_tracked, layer4.1.bn2.num_batches_tracked, layer3.4.bn2.num_batches_tracked, layer3.1.bn1.num_batches_tracked, layer1.0.bn1.num_batches_tracked, layer3.3.bn3.num_batches_tracked, layer2.3.bn3.num_batches_tracked, layer4.2.bn2.num_batches_tracked, layer3.3.bn2.num_batches_tracked, layer3.2.bn1.num_batches_tracked, layer2.2.bn1.num_batches_tracked, layer4.1.bn3.num_batches_tracked, layer3.1.bn2.num_batches_tracked, layer2.0.bn3.num_batches_tracked, layer1.0.bn2.num_batches_tracked

loading annotations into memory...
Done (t=452.10s)
creating index...
index created!
2018-11-23 11:58:04,558 @runner.py:327 - INFO - Start running, host: gu@gu-PC, work_dir: /data/wanggu/mmdetection/output/mask_rcnn_r50_fpn_1x
2018-11-23 11:58:04,559 @runner.py:328 - INFO - workflow: [('train', 1)], max: 12 epochs
cudaCheckError() failed : CUDA driver version is insufficient for CUDA runtime version

I guess you are actually using CUDA 9.2 and the requirement for minimum driver version is 396.xx. Sometimes conda will install cuda 9.2 with pytorch.

I checked torch.version.cuda, it is 9.0.176. And my other pytorch programs are working without any problem. It is strange and I wonder where mmdet or mmcv check the cuda driver and cuda version.

That's strange. mmdet and mmcv do not check the driver, only pytorch itself will check it.

I updated the driver version from 390.87 to 410.73 and the problem is solved.

@hellock just as you said, conda may install another version cuda? I  have met import issue when use mmdetection test.py, so I doubt my cuda version is not compatible.
I installed cuda<IP_ADDRESS>(with cudnn9.2_v7.3.1, driver410.66) which I can check by nvcc -V, but I saw CUDA version10 showed in Nvidia-smi interface, which I installed long time ago and I already uninstalled.
my question is: actually I did not find any cuda10 in conda or other place, any way to confirm which version cuda I use?


SILGen: Don't override the SourceLoc for magic identifiers in stored property initializers.

Explanation: Refactoring stored property initializers to reuse the codegen for default argument generators caused them to accidentally inherit the suppression of default magic literal source locations, causing #file etc. to regress to empty values inside initializer expressions.
Scope: Regression from 3.0
Issue: SR-4325, rdar://problem/31483404
Risk: Low
Testing: Swift CI, test case from Jira

@swift-ci Please test

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 38dcbe92eba9802acb3f874fced4ce1ad7242ea9
Test requested by - @jckarter

@swift-ci Please test

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 38dcbe92eba9802acb3f874fced4ce1ad7242ea9
Test requested by - @jckarter

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 38dcbe92eba9802acb3f874fced4ce1ad7242ea9
Test requested by - @jckarter

@swift-ci Please test

LGTM


Command(ooooos) hehe

Command attempted:

What happened:

More info:

$ ssh-keygen -t rsa -b 4096 -C "


Java-Solution All indices of number in an array

Description
Added java-solution for  "All indices of number in an array" using simple recursion method.
Fixes #1691
Replace #1691  with the issue number which is fixed in this PR
Type of change
Please delete options that are not relevant.

[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works

@Amit366 @ravikr126 @Ayush7614
please review my this PR and merge it, I will thankful for you.


Log Factory and Reworking tablet manager setup steps for the same

Summary:

Creating a log factory class which can be passed in server options
The passed in log factory will be used to create the log implementation

Reworking how setup is done in the tablet server so that we can
create the log and consensus before we actually start consensus.

Test Plan: Tested this in shadow setups using MySQL replication
Reviewers: iRitwik
Subscribers:
Tasks:
Tags:

Replied to some of your comments.


Copying the look from hop?

Hi, I've been using hop for a while, but I like a lot of the ideas here in leap so have been trying it out for a bit. The main thing I miss from hop though is how when it is hinting what to type, it removes all of the syntax colors from everything but the hinting letters so they're really easy to spot without needing to highlight the whole background of the letter.
That feels like it's something I could accomplish with some of the autocommands leap provides, but I wanted ask you if that made sense as the way to do it? If not can you please give a few pointers of how else to go about it?
Then also is this something at all that you'd put into the project itself, or is it best left as a do-it-yourself-if-you-want-it sort of feature?

I had never done things myself with vim highlights, and I've now figured out that I can accomplish this with what is already here with the LeapBackdrop group you've already provided.


RENAME login to getCredentials or getAccount ?

Martin,
The method login is confusing, it isn't actually logging in and does not require any information to LOGIN.
Everybody understands the term login to mean gaining secure access to something by supplying account or other secret information.
Login is really fetching the details about the current session, perhaps it would be better if it were renamed to getCredentials (or getAccount) which more correctly identifies what it is actually doing.
Rather than simply rename and break everybody's code perhaps create a new method getCredentials (or getAccount) (a duplicate of login) and just mark login as:
login has been DEPRECATED and will be removed in the near future, please update your code to use getCredentials (or getAccount)
Perhaps with release 2.0.0, version with  LAN access tried and tested ?
--
Steve

I agree with you @ttz642
My plan will be:

create getCredentials and keep login as an alias
add getCredentials to docs site
update login docs, saying is deprecated and you should use getCredentials
update openWebSocket method to call getCredentials if needed

I agree on the plan for 2.0, LAN mode should be released and login method can be deleted.

Has been added to 1.10.0


test: add tests in DriverOptionsTest.java

Add tests for selector(string, string) in DriverOptionsTest.java that increase coverage of method.

Closes #3
Description
Thanks for contributing this Pull Request. Make sure that you submit this Pull Request against the develop branch of this repository, add a brief description, and tag the relevant issue(s) and PR(s) below.

Relevant Issues : These tests are fairly too simple and are only meant to increase the coverage only after discovering that the static method had a zero coverage according to jacoco. Now the coverage lies at 83% with the addition of these tests. The pull request is created from my forked repo of karate
Relevant PRs : -
Type of change :

[ ] New feature
[ ] Bug fix for existing feature
[ ] Code quality improvement
[X] Addition or Improvement of tests
[ ] Addition or Improvement of documentation

sorry, no thanks. also read this next time: https://github.com/karatelabs/karate/blob/master/.github/CONTRIBUTING.md


Separation of concerns

I dig this example for a couple of important reasons, the structure is sensible, extensible and quite great.  The big problem that I have with it is that a few of the core technologies are baked in very deeply, and to really get much use out of it, there is a very steep learning curve, involving reading a lot of 3rd party code.  I would love to see a package evolve out of this stack that hides a lot of the details - it assumes the src/{components,helpers,containers,redux,theme,utils} structure, and does a sensible thing with it.  There are a few core issues that I have been having that are small in scope and probably easy to tweak.  I am pretty new at a lot of the core technologies here, but as a newcomer I feel it's my job to highlight the things that I find "weird" or "surprising".  If they turn out to be good and/or essential then I'm happy to learn and adopt these things, but coming from a ruby/rails background, it kind of surprises me how much "glue" is involved in day-to-day node projects.  Am I missing something?  I find it difficult to justify needing to understand on a deep level all of the libraries that I use.  Can't we simplify and/or standardize the APIs in such a way that I don't need to constantly refer back to source code in order to explain surprising behavior?
I don't mean to be inflammatory or anything, I am honestly trying to get an understanding of the npm ecosystem - I have just found it to be more jarring than I expected.

@dts I totally agree. I'm also a newcomer and it's been a jarring experience wading through all the glue and third party code. I think abstracting some of the details into a package would make this starterkit more palatable to developers foraying into universal redux app.

My 0.02: This is tough to accomplish... Even for a basic react project that implements both SSR and CSR with routing in place there's a number of libraries that you need to depend on to "glue" it all together.
A very basic example (based on this project btw) can be seen at my repo @ https://github.com/dmitrif/react-workshop , but as you can imagine it does not do all the great stuff this project does while relying on a bigger number of libs.
I do agree that some libraries can be cut out from this boilerplate, such as the form-related libs, memoize, etc.

Personally, (also as a relative newcomer) I liked that the project included examples of how one could handle form and css styles, respectively.

I agree that we should add more help for newcomers.   I'm working on a couple guides; c.f. #724 or Exploring the App for an example.
The kit is evolving rapidly and one could reasonably expect the extra file proliferation and large number of modules to slowly trim down.   For example, a year ago there would have been Gulp or Grunt in the mix.   I would be surprised to see any scss files or style loaders next year.

@dts what you're describing sounds like very much the motivation i had for creating https://github.com/bdefore/universal-redux and submitting #626 and #685 ... I'd be curious to hear what you think.

@bdefore that looks quite interesting, I haven't had a chance to try it out, but based on what I can see this is exactly what I'm asking for, so that's great!  The question that occurs to me immediately is how easily it would accommodate tailor-made extensions, which would add functionality.  Removing features until you're left with "the basics", which it looks like you may already have done.  At that point, having extensions that work together with universal-redux to add features like react-hot-loader to the stack without needting to glue everything together.

@dts thanks for having a look. there is already some amount of customization that is supported, primarily focused on Redux and Express middleware. it's documented more here: https://github.com/bdefore/universal-redux#customization. i would love to get more feedback about how people are using it (or this project) as a base in order to glean what additional customization needs there are.
the example you mention, react-hot-loader, is trickier. at this point, react-transform-hmr (successor to react-hot-loader) is built into universal-redux, since it is core to the functionality and should be as much as possible abstracted away from the developer.

this whole thing is evolving too rapidly at the moment.
yesterday you used flummox, today you hear of redux, tomorrow some kind of falcor or relay emerges.
and react-router is already out of date the next week, and redux-router is declared stale, etc.
it's chaos.
when stability time will be half a year at least then there will be frameworks.

(every time you masturbate another javascript framework is declared obsolete)

Anyway, i've thought about this issue too and wrote my very own react-redux library which incorporates a big chunk of the code from this project.
https://github.com/halt-hammerzeit/react-isomorphic-render
You can do something similar.
The only true answer is what should be a part of such a library: incorporate too much and it will suit noone, incorporate too little and it won't solve the issue.
UNIX way ftw + Charles Darwin way.

I hear it, @halt-hammerzeit.  I am giving @bdefore's solution (https://github.com/bdefore/universal-redux) a try, it appears to be a more mature set of things (I couldn't find anything about deployment/production in yours).  We can fight to reduce the fragmentation by working on things that already exist, instead of constantly rolling our own.  Is there a way we can merge universal-redux and react-isomorphic-render?

@dts mine doesn't aim to give the user deployment facilities at all. it's just a react-redux isomorphic rendering facility.

Jokes aside, (although the one about the correlation between masturbation and Javascript framework dismissal made my day), it would be great to take the chance to draft a common gole and work together in either drive an existing framework to a better stage, or create a new one (only if there are no doable alternatives)

Thanks @halt-hammerzeit ... it's great to see someone else taking a stab at it. You are absolutely right that the balance is tricky around how much you incorporate. I'd love to hear your feedback on mine. I'll have a further look at yours later tonight, but at a quick glance I'm keen on your separation into pieces that just focus on the isomorphic rendering. I'd been considering moving in that direction myself, and I could see pulling some of those into my package if they were their own modules.

Also, in a bit of irony given the timing of these comments, React Router 2.0 release candidate just dropped. That's certainly going to have a ripple through redux-router and redux-simple-router. And I'm hoping it fixes an issue I'm having getting prefetching to work: https://github.com/bdefore/universal-redux/issues/16

@bdefore I looked through your project and I think that it could be difficult to integrate my library into your project. They are very similar (clones) and I think there's no need for you to use my library because your code is absolutely the same. That's for you to decide of course.
As for the voting, I'm voting for @bdefore library then. All the issues will be reported in this repo, but all the commits will go to that npm module repo.

@bdefore
Any update on Koa support ?


install: defineNuxtConfig is not defined

Issue
When attempting to install and activate using nuxt config I receive the following error:
Error while requiring module @shuriken-ui/nuxt: ReferenceError: defineNuxtConfig is not defined

at node_modules/.pnpm/@shuriken-ui+nuxt@0.0.2_ac7fus7hmxy46xiwuygouu3dj4/node_modules/@shuriken-ui/nuxt/nuxt.config.ts:8:16

Config
export default defineNuxtConfig({
  modules: ["@shuriken-ui/nuxt"],
  nui: {
    defaultShapes: {
      accordion: "rounded",
      autocompleteItem: "rounded",
      avatar: "full",
      button: "rounded",
      buttonAction: "rounded",
      buttonIcon: "rounded",
      card: "rounded",
      dropdown: "rounded",
      iconBox: "rounded",
      input: "rounded",
      message: "curved",
      pagination: "rounded",
      progess: "full",
      prose: "rounded",
      tabSlider: "rounded",
      tag: "rounded"
    }
  }
})

Environment

Version: ^0.0.2
Ubuntu 22.04
PNPM

@shuriken-ui/nuxt is not a module, but a layer
You should have a nuxt.config.ts with extends key
export default defineNuxtConfig({
  extends: ["@shuriken-ui/nuxt"],
})

By contrast, the nui is for app configuration and should be placed in app.config.ts

Ok great that works now.  🍾
However, there seems to be some sort of bug in the NuxtConfig type resolver as I get the following error, despite the extends: string | string[] property definitely being defined on NuxtConfig within the Nuxt types.  🤔
TS2345: Argument of type '{ extends: string; modules: string[]; strapi: { url: string; prefix: string; version: "v4"; cookie: {}; cookieName: string; }; }' is not assignable to parameter of type 'NuxtConfig'.   Object literal may only specify known properties, and 'extends' does not exist in type 'NuxtConfig'.

(ConfigSchema internal interface)


Add contains_nan

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.78%. Comparing base (ef5b5c2) to head (e9ffe0e).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
+ Coverage   81.44%   83.78%   +2.34%
==========================================
  Files           7        8       +1
  Lines          97      111      +14
  Branches        4        6       +2
==========================================
+ Hits           79       93      +14
  Misses         18       18

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Can't install the module

Hi,
I tried to install the module through "Help" -> "Install Mobile Module" and it gets succesfully installed but it doesn't list in tiapp.xml. I tried with versions 1.6, 1.5 and 1.3. Thus, I can't compile the module.
Can someone help me? Provide me a link with a valid dist zip?
Platform: Android
Titanium SDK: 5.3.0.GA
Appcelerator Studio: <IP_ADDRESS>605201934
Mac OS X El Capitan
Thank's

Hello. Good evening. I have the same situation as @arildojr.

You can either use gittio to install it:
gittio install nl.vanvianen.android.gcm
have a look here on how to install gittio: http://gitt.io/cli (it's worth it :) )
or download to compiled version from here:
https://github.com/morinel/gcmpush/releases
and place it in the root application folder. Next time you compile the app it will unzip it. Then you just add
<module platform="android">nl.vanvianen.android.gcm</module>
to your  section in the tiapp.xml
or follow this guide: http://docs.appcelerator.com/platform/latest/#!/guide/Using_a_Module
Hope that helps!


Fix: BottomSheet closes when recomposing in iOS #330

Issue details:
https://github.com/adrielcafe/voyager/issues/330
Affected Platform: iOS
Compose version: 1.6.0
It seems the culprit is confirmValueChange in rememberModalBottomSheetState, it's using rememberSaveable where confirmValueChange is used as a key. When this method changes in iOS somehow when you open keyboard or any other thing that causes recomposition, it recreates the sheet state, which hides the bottom sheet modal.
Removing confirmValueChange and using LaunchedEffect to observe sheetState.currentValue solves the issue.

Can we also report this on https://github.com/JetBrains/compose-multiplatform?
It should not have different behaviors, the same code in both platforms.

Hi @DevSrSouza
I believe this one is related
https://github.com/JetBrains/compose-multiplatform/issues/4434

Thank you for this PR! I just saw this issue myself. Plz cut a new alpha release?


Allow supplying a scriptHash instead of a publicKey when building transactions

The current params required for building a txn uses an encoded public key instead of a script hash.
(See: https://github.com/CityOfZion/neon-js/blob/master/src/transactions/create.js#L53)
This causes problems when trying to use the library to build dapps where the smart contract to withdraw from / interact with will not have a public key.
Since the only usage of this key seems to be in calculateInputs where it is converted back to a scriptHash anyway, it would be nice to just accept a scriptHash from the start instead.
(See: https://github.com/CityOfZion/neon-js/blob/master/src/transactions/create.js#L126)

I think
https://github.com/CityOfZion/neon-js/pull/67 solves this, feel free to close!

The PR will utilise the address field provided by the balance object to derive the scriptHash. There shouldn't be any problem as scriptHash and address are reversible.


feat: api chat

Codecov Report

Merging #23 (105f217) into main (be5bec9) will decrease coverage by 3.08%.
The diff coverage is 78.07%.

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
- Coverage   82.88%   79.79%   -3.09%
==========================================
  Files          18       20       +2
  Lines         555      688     +133
==========================================
+ Hits          460      549      +89
- Misses         64       95      +31
- Partials       31       44      +13

Impacted Files
Coverage Δ

lark.go
94.73% <ø> (ø)

http.go
49.09% <50.00%> (-0.91%)
:arrow_down:

api_upload.go
55.88% <53.84%> (ø)

message_v2.go
72.54% <72.54%> (ø)

api_chat.go
75.00% <75.00%> (ø)

api_message.go
66.27% <79.31%> (-6.33%)
:arrow_down:

message_v1.go
90.00% <90.00%> (ø)

msg_buf.go
100.00% <100.00%> (ø)

user.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f85b958...105f217. Read the comment docs.


[BUG] I can't uninstall the bloxtrap in control panel

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
I cant uninstall it in control panel, i tried every single way, ive installed .NET 6.0.25 X64 but it still dosent let me uninstall it, here is an image of how it looks like when i try to uninstall it.

Did you uninstall it at some point? You wouldn't have been able to install it without it.
Anyway, follow the instructions for manual installation detailed here.


Query planner optimization (or AST optimization?)

A query like this:
+(
    +(text:"a" text:"b" text:"c" ...)
    -(text:"x" text:"y" text:"z" ...)
)
+field_id:[0 TO 10]

For a large dataset, we don't want the inner tests on the text values to be carried out for any documents that have field_id outside the range given at the outer level of the query. This is a toy example and I understand that in this specific case, I could just remove scope around the text clauses and make everything toplevel, but my question is really about whether and how an outer clause might be applied to nested levels, if at all.
Is there an existing optimization layer that does this?  Currently I've been applying range constraints within the deepest nested levels of my queries to "avoid work", but I don't know whether this is necessary.  I've seen some recent work on AST optimizations in #2449 and #2461, and comments like this but it's difficult to get an overall sense of what is and isn't done w.r.t. my question.
TL,DR, "Should I repeat my toplevel range constraints in nested layers for performance?"

One of the examples mentioned in #2449 is this:

(a AND b) AND (c AND d) can be simplified to (a AND b AND c AND d)

My example above might then look like this:

(a NOT b) AND c  ==> (a AND c NOT b)

if that is useful for answering the question.

I got feedback on the Discord:

We do have seek in DocSet, which is used to skip docids in AND queries
How effective it is depends on the implementation, in the worst case it just calls advance
There's no documentation but you can check the DocSet implementations
Generally there's some room for improvement here.

I take this to mean that it will depend on the specific implementation currently in the DocSet code, and that I should look there. Closing.


readded the Star width and Height setting

I created this pullrequest to fix issue #13. The starHeigth and starWidth settings (contributed by zhangruize) seems to be missing in the latest version, even though they are mentioned in the readme
I readded this functionality back using zhangruize's code.

Hello @desmese ,
Thanks for your PR! I will check the code again carefully.


[Feature Request] Support for template

I would do like to suggest the template feature for pptxGenjs to be able to replace text, images and charts on a existent pptx, do you think that it is a good idea?  i can work on that for you guys, "i really need this feature on most of my projects"

Hi @TalissonJunior
The PptxGenJS library is only used to generate PowerPoint presentations.
Opening, modifying, templating, etc. of other pptx files are features that will not be added.


size attribute to input box isn't responsive

Hey!
If you add a size attribute to an input element, it isn't responsive and I don't exactly know how you could make it responsive. I'm not sure if it'd be possible to add a class that would make it responsive, but yeah.

You should check here for examples

<form>

      Your email
      <input class="u-full-width" type="email"<EMAIL_ADDRESS>id="exampleEmailInput">

      Reason for contacting
      <select class="u-full-width" id="exampleRecipientInput">
        <option value="Option 1">Questions</option>
        <option value="Option 2">Admiration</option>
        <option value="Option 3">Can I get your number?</option>
      </select>

  Message
  <textarea class="u-full-width" placeholder="Hi Dave …" id="exampleMessage"></textarea>

    <input type="checkbox">
    Send a copy to yourself

  <input class="button-primary" type="submit" value="Submit">
</form>


wip: bidi grpc integration tests

What type of PR is this?
/kind feature
Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build
/area engine
/area tests
What this PR does / why we need it:
Since #1241 is almost ready, we need an integration test for the gRPC server.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This PR:

[x] adds some deps to the falcosecurity/falco-tester images (already pushed to the :latest tag)
[x] is currently based on #1241 and needs to be rebased on master once #1241 gets merged (WIP for this reason)
[x] introduces a very small user-facing change (see the release note) needed to allow the test suite to connect to and read events from the gRPC server
[ ] push falcosecurity/falco-tester to docker hub

/cc @fntlnz
/cc @leodido
Does this PR introduce a user-facing change?:
fix(userspace/falco): honor -M also when using a trace file

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign fntlnz
You can assign the PR to them by writing /assign @fntlnz in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/milestone 0.24.0

LGTM label has been added.  Git tree hash: ccbe43083f69ad6bfd6723f220e39d31ceb259a9

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leodido
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leodido]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fntlnz, leodido
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [fntlnz,leodido]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Can't figure out how to get this to work in noconflict() mode

I can't seem to figure out how to get this one line of code to work in JQuery's noconflict() mode.
$.colorbox({html: ... });
(Can't seem to get this code to render correctly in here .. so I've intentionally shortened it)
Please advise on how I would accomplish this.
Thanks,

Yvan

This isn't enough information to address your question with any confidence.  It may be as easy as replacing $.colorbox with jQuery.colorbox, but it depends on what you have going on.

I'm trying to get this working on a Wordpress site .. in my functions.php file.  I already have the jquery and colorbox libraries loaded in my theme.

Yvan

Just to make sure, you know that jQuery.noConflict() does, right?  It assigns the $ alias to whatever it was prior to referencing jQuery.  Unless you've created a local variable for $ to reference jQuery, you have to fall back to using jQuery in your code.

All of this is unrelated to Colorbox by the way, you could replace Colorbox with any other code using jQuery.

Yes, I understand what noConflict() does, and I know how to use it (I've been using it extensively on the site that I'm developing and trying to get this working with. I just can't seem to get it to work with colorbox for some reason (I've already tried "jQuery.colorbox" to no avail).
The colorbox library is part of the Wordpress theme that I'm using (BuddyBoss), and I'm just trying to leverage it to replace the ugly javascript alert() prompts that I've been using temporarily.  I just keep getting these perpetual "ReferenceError: jQuery is not defined" errors when I try to implement it within my child theme's functions.php file .. even though the JQuery library is definitely loaded, and I'm referencing it extensively in that same functions.php file. I'm stumped, frankly, .. which is why I thought it might be worthwhile for me to go right to the source.


misc: add debug message in deployer

Description
To aid debugging in deployer, add a debugging message.
Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[x] Other (please describe)

Checklist

[ ] I have read the contributing guidelines
[ ] Existing issues have been referenced (where applicable)
[ ] I have verified this change is not present in other open pull requests
[ ] Functionality is documented
[ ] All code style checks pass
[ ] New code contribution is covered by automated tests
[ ] All new and existing tests pass

Codecov Report

Merging #428 (07d1ba5) into main (473c912) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main     #428   +/-   ##
=======================================
  Coverage   14.86%   14.86%
=======================================
  Files          48       48
  Lines        2832     2832
=======================================
  Hits          421      421
  Misses       2382     2382
  Partials       29       29


Fix "Prefer format() over string interpolation operator" issue

This pull request automatically fixes all occurrences of the following issue:
Issue type: Prefer format() over string interpolation operator
Issue details: https://www.quantifiedcode.com/app/project/gh:founders4schools:duedilv3?groups=code_patterns/%3A4ACGxFj1
To adjust the commit message or the actual code changes, just rebase or cherry-pick the commits.
For questions or feedback reach out to<EMAIL_ADDRESS>Legal note: We won't claim any copyrights on the code changes.
Cheers,
Cody - Your code quality bot

Coverage remained the same at 83.735% when pulling 876245f6c510bb367353b1338843985e5bb05f62 on autofix/wrapped2_to3_fix into 18e7f3941de0c43a70d8232c276178db83d57490 on master.

Coverage increased (+1.1%) to 84.88% when pulling 2a4988130f0548470dd30f4c8d927719b6be8289 on autofix/wrapped2_to3_fix into 18e7f3941de0c43a70d8232c276178db83d57490 on master.

Coverage remained the same at 84.88% when pulling 93cce71a2f446b6ec46a82cab922154ef8425afe on autofix/wrapped2_to3_fix into 1031646d59bb79733f060c3d12bd5c15c35aa864 on master.


__syncthreads needed in asps_cuda.cu pass 2?

I have been reading the Katz and Kider 2008 paper and believe you are implementing the algorithm that they describe.
They only talk about synchronization for the first pass of their algorithm, but I believe there also needs to be synchronization between threads in the second pass, too. (If you don't think so, could you explain to me why you wouldn't?)
This would mean you need some __syncthread calls beneath lines 60, 66 in apsp_cuda.cu (and in similar positions in the other two implementations). I believe this may explain the inaccurate results you were getting in your report.pdf.

Wow, thanks for your reminder! I don't know the paper All-Pairs-Shortest-Paths for Large Graphs on the GPU when doing this assignment. 😊
I agree with you that it might need some synchronization barriers after modifying the shared memory like the first pass. However, I'm not working on CUDA programming for a long time. If I have time, I'd love to reproduce the issue, and thank you for the insight.


[hi] Added Hindi localisation style guide

Creates initial Hindi localization style guide
please review @anubha-v-ardhan @divya-mohan0209
Fixes #35599

/approve

@divya-mohan0209 please review and approve the changes you requested. Thanks!

Hi @AmanSarraf, let's work together on changing the target branch from dev-1.22-hi.1 to main.
I think I've got the steps covered in these screenshots in the /hi slack channel. However, let's see if they actually work with no problems, and share our solutions with others in this new slack thread.

/remove-lifecycle stale

@divya-mohan0209 Please have a final look on this and let this merged down!

/assign @divya-mohan0209

/remove-lgtm

@bishal7679 Is this PR being in work these days?

/close

Hi @kubernetes/sig-docs-hi-owners :)
I guess the content of this PR would be valuable to the Hindi team.
Would it be possible to get more attention from Hindi reviewers/approvers for this? Is there any remaining review comment that the PR author can address?

@seokho-son I'd love to have someone else take a stab at reviewing the PR after @AmanSarraf confirms he is working on it. As it stands, there has been no response since 5 months from him & a quick glance at the whole document shows that there are major rewrites required for which we will need the contributor to be involved actively.

Hi @divya-mohan0209 , I am looking to start working on this issue this weekend. I am looking for some sample style guide or some standard that could help me out here.

Hi @divya-mohan0209 , I am looking to start working on this issue this weekend. I am looking for some sample style guide or some standard that could help me out here.

Thanks for informing!
/open

/reopen
:)

I have started working on new style guide , so I wish to close this PR and will generate a new one


Why when tileset's size > 1024 , the texPreChild have to be 1

when the image of tileset is bigger then 1024*1024 ,  the texPreChild have to be 1,
otherwise there is a error
[.Offscreen-For-WebGL-0x7fd913871800]GL ERROR :GL_INVALID_VALUE : glTexSubImage2D: bad dimensions.

And the result of rendering will be mistake.

Tilesets more than 1024 are not supported. That code was mode for RMMV in a hurry and there's no middle solution that works both with large and small tilesets, wait for 2.0 that I'm working on now.

I found there some hard-code1024  in source.  they are the reason ?
I try to change them from 1024 to 2048 , but no effect and take more mistakes....

@ivanpopelyshev , where can I  find 2.0 ?

Exactly.

@ivanpopelyshev , where can I find 2.0 ?

You can find WIP plugin for atlas here: https://github.com/gameofbombs/pixi-super-atlas
I'm working on it right now.

If we just remove those renderTextures, RMMV will stop working and that'll be very bad.
The only solution is to make runtime atlas that can combine BaseTextures with limits only on number of texture slots and the size of GL texture.


Button click listener

Hello!
There is no button click listener on showRateDialog like in original Android-Rate library.
It's very useful feature to store click statistics.
It would great if you add it, I see it something like that:
enum RateDialogButton {
  rate,
  no,
  later,
}

rateMyApp.showRateDialog(
  onClick: (RateDialogButton button) {
  },
);

Well in fact, there is a pull request for that. So I think I'm gonna take care of it today or tomorrow :wink:


Demo

Is there an online demo somewhere? Thanks!

There isn't at the moment. But follow the installation and Usage basic within a basic react app.


Show Includes Publication(0) when experiments have no publication in result

Context
Came up while reviewing #96
Problem or idea

When the experiments in the result set do not have any publications associated with them, the filter Includes Publication filter is active and users can choose to add that filter.
For other filters, we remove the items that aren't in the result set.
Solution or next step
In this case, includes publication is its own facet, so we can show Includes Publication (0) and disable it.
I'm also open to removing it as a filter when the count is 0.
Tagging @davidsmejia @nozomione for thoughts

In this case, includes publication is its own facet, so we can show Includes Publication (0) and disable it.

@davidsmejia  Since I am working on these pages, this is a good time to implement @dvenprasad's suggestion 👍🏻 I can take care of this issue today. Please let me know!


Unified Dictionary analyzer

Merge @CollinAlpert's branch into @chucker's for preparation of https://github.com/dotnet/roslyn-analyzers/pull/4836

No idea why I made it .NET Core specific. I changed that.

think I ran into something similar in an earlier commit. If it's the same thing, the problem is that that exact node doesn't exist in the document any more, so the editor can't remove it. Instead, the way I worked around it was to find an equivalent node, and remove that.

Unfortunately, this does not work either. Maybe that's because I am using the DocumentEditor approach. I still get the "Value cannot be null (Parameter 'expression')" exception in CSharpDoNotGuardDictionaryOperationsFixer.cs#103. Maybe @carlossanlop can help?

Yes and no. It's not exactly the same, but you can do something like: Public Function TryGetValue(Of T)(key As String, <Out> ByRef value As T) As Boolean

This is the declaration. I need to pass a variable to it and that's where I'm having problems. See: https://stackoverflow.com/a/4358774.
I still need to create the type and I don't know where to get that information from.


Change Vim's row/col count to match the Sublime tab

For example, if you ctrl+u or ctrl+d you move up or down 10 lines, presumably because Vim thinks it's window is 20 lines high.

fixed in 60d3b94


Unpurge the nusighttest role

I want my debug waves!

You could just move the relevant parts to within NUsight proper, and just hide it behind one of the reaction configs like the other types

You could just move the relevant parts to within NUsight proper, and just hide it behind one of the reaction configs like the other types

I think that would be mixing test/harness code with real code — ideally there would be very a clean separation. I can imagine when working on the other modules (e.g. localisation), I'll want a very specific harness to run a very specific set of data
with a very limited set of modules — and I probably don't want to pollute the global roles list with my internal module harnesses — this feels like something we need to add 1st-class support for.


POST url with query string parameter

I am working on SAP HANA, a upsert function  have to POST url with parameter like
POST https://my356688-api.s4hana.ondemand.com/sap/opu/odata/sap/YY1_HCI_ID_ID_ORIGIN_CDS/YY1_HCI_ID_ID_ORIGINSap_upsert?IDOrigin='EXTERNAL'&ContactID='1'&Field1='Max'&Field2='Mustermann'
Reference link - SAP Blog
So how do I work on this?
Had try many method on Simple.OData.Client and seem it not allow the uri with query string.

QueryOptions together with InsertEntryAsync is supposed to work but does not seem to. QueryOptions together with UpdateEntryAsync appears to work.


Added Angle between two lines Calculator

Fixes Issue🛠
Closes #1123
Closes #
Description👨💻
I have added Angle between two lines Calculator which calculates the angle between two lines. he line equations are given as input and the angle between them is returned as output in degrees.
Type of Change📄

[ ] Bug fix (non-breaking change which fixes a bug)
[x] New feature (non-breaking change which adds functionality)
[ ] Style (non-breaking change which improves website style or formatting)
[ ] Documentation (non-breaking change which updates or adds documentation)
[ ] Responsiveness (non-breaking change which improves UI/UX on different screen sizes)

Checklist✅

[x] I am an Open Source contributor
[x] I have performed a self-review of my code
[x] My code follows the style guidelines of this project
[x] I have commented on my code, particularly in hard-to-understand areas

Screenshots/GIF📷

@AMS003010  Fix the issue in main index.html file.

Why the files of Frames-Timecode-Calculator is showing, fix the conflict in this same PR @AMS003010

Sorry got caught up, I'll fix it by today

@Rakesh9100  Sorry for the delay 😅
I have fixed all changes and fixed all issues. I have reviewed and made sure that there are no issues.

@AMS003010 The page is not responsive. Are you going to do that?

I'll look into it...

@Rakesh9100 I have made it responsive

Why the files of Frames-Timecode-Calculator is showing, fix the conflict in this same PR @AMS003010

This is still not fixed, I tried to delete by making commit but it deleted the files originally @AMS003010

I'll look into it....

@Rakesh9100
I have done the necessary
It should be fine now

https://github.com/Rakesh9100/CalcDiverse/pull/1435/files
Check here, number of files changed are 13 which should not be @AMS003010

Yes it does say 13 files but that is because I had made a lot of commits to this issue (which included both addition and deletion). I have only made made changes in my frames-timecode-calculator folder and I have added that calculator in the main index.html

The file changes of Frames-Timecode-Calculator should not show up in this PR by any chance @AMS003010

Sure I will look  into it....

Any update, fix this ASAP @AMS003010

I'll try to call a new PR only on those changes...
I close this one as I am not able to revert to previous changes


Update README.md

Add browser extensions

@all-contributors please add @indiealexh for content

@all-contributors please add @indiealexh for content

Much appreciated


Envoy circuit breakers hit with HTTP/2

I use a custom client to send requests to Knative services with a Kourier gateway. It has a slow-start algorithm that gradually scales up concurrent requests until a configured limit is reached, or until error rates are too high. Under normal conditions, with HTTP/1.1, this can easily scale to 10k concurrent requests with just a few Kourier pods. Using HTTP/1.1 is more fragile as it could hit socket limits. However, if I switch that same config to HTTP/2, once the concurrency hits approximately 1000 (maybe slightly lower), Kourier / envoy responds with:
HTTP/2.0 503 Service Unavailable
Content-Length: 81
Content-Type: text/plain
Date: Tue, 10 May 2022 01:58:16 GMT
Server: envoy
X-Envoy-Overloaded: true

upstream connect error or disconnect/reset before headers. reset reason: overflow

If I reduce the concurrency, but increase the number of clients sending requests, once the total concurrent requests goes above 1000, the same result happens. This might depend on the number of upstream service pods, I was testing with just 2.
Is there a way to tune this setting in the Kourier config? Ideally, if requests per socket connection need to be limited, it would allow spawning more connections when the limit is reached.
edit: to clarify, the upstream Service is not changing here, just how the client connects. The upstream service port is defined as a named port (h2c).

As a follow-up, this is mainly overflowing the upstream_rq_pending_overflow value.
foo/myapp-00006.upstream_rq_pending_overflow: 17345

There are also some upstream_cx_overflow and upstream_rq_pending_overflow  values > 0 on HTTP/1.1 services, but they are fairly small.
The dynamic clusters are getting default circuit breaker values.
% curl -s localhost:9000/clusters | grep myapp
foo/myapp-00006::observability_name::foo/myapp-00006
foo/myapp-00006::default_priority::max_connections::1024
foo/myapp-00006::default_priority::max_pending_requests::1024
foo/myapp-00006::default_priority::max_requests::1024
foo/myapp-00006::default_priority::max_retries::3
foo/myapp-00006::high_priority::max_connections::1024
foo/myapp-00006::high_priority::max_pending_requests::1024
foo/myapp-00006::high_priority::max_requests::1024
foo/myapp-00006::high_priority::max_retries::3
foo/myapp-00006::added_via_api::true
...

And looking where new clusters appear to be created via the API, there is no circuit breaker config:
https://github.com/knative-sandbox/net-kourier/blob/969ae748c33768049c72b10ae9fb0cd0235fe6ff/pkg/envoy/api/cluster.go#L39-L52
As my testing has shown, the requests from multiple clients still triggers this overflow. Otherwise, I could create some transport pool to spread the load. I do think each individual Kourier instance should be able to handle > 1024 concurrent requests to a service.

/remove-lifecycle stale

/reopen

I'm currently working around this with the following hack, but since it is not configurable it requires a custom build on my part:
		// HTTP/2 expanded max defaults
		cluster.CircuitBreakers = &envoyclusterv3.CircuitBreakers{
			Thresholds: []*envoyclusterv3.CircuitBreakers_Thresholds{
				{
					Priority:           envoycorev3.RoutingPriority_DEFAULT,
					MaxConnections:     &wrappers.UInt32Value{Value: 1024},
					MaxPendingRequests: &wrappers.UInt32Value{Value: 1024*1024},
					MaxRequests:        &wrappers.UInt32Value{Value: 1024*1024},
					MaxRetries:         nil,
					RetryBudget:        nil,
					TrackRemaining:     false,
					MaxConnectionPools: nil,
				},
				{
					Priority:           envoycorev3.RoutingPriority_HIGH,
					MaxConnections:     &wrappers.UInt32Value{Value: 1024},
					MaxPendingRequests: &wrappers.UInt32Value{Value: 1024*1024},
					MaxRequests:        &wrappers.UInt32Value{Value: 1024*1024},
					MaxRetries:         nil,
					RetryBudget:        nil,
					TrackRemaining:     false,
					MaxConnectionPools: nil,
				},
			},
		}

/remove-lifecycle rotten

/remove-lifecycle stale

/remove-lifecycle stale

/reopen

/reopen

/remove-lifecycle stale

/reopen

/remove-lifecycle stale

/reopen

/remove-lifecycle stale

/remove-lifecycle stale


Unintended scrolling in LOL keyboard nav on Chrome

Test Device
Jordan
Operating System
Mojave 10.14
Browser
Chrome 70.0.3538.77
Problem Description
In https://github.com/phetsims/QA/issues/214:
When tab is pressed after scrolling the page, the page jumps up, making it so the bottom half of the sim is not visible and so that the sim is very difficult to use with keyboard nav.
Steps to Reproduce

Go to https://developers.legendsoflearning.com/public-harness/index.html?startPayload={"languageCode"%3A"en"}
Paste https://phet-dev.colorado.edu/html/coulombs-law/1.0.0-rc.4/phet/coulombs-law_en_phet.html?legendsOfLearning into the source URL
press Tab to activate keyboard nav.
tab down until focus is on an item in the sim window.
scroll down so the sim window is in view.
press tab to advance focus to the next item.
screen will jump upwards, hiding the bottom half of the sim.

Visuals
https://photos.app.goo.gl/hCKVWEsDhBJXGD1J8
Relevant Info
From Slack chat:

Michael Barlow [1:52 PM]
I’m thinking there’s some other JS in there that’s messing with it. I get the same behavior on some of our released sims (e.g. RIAW), so it may have to do with some of the scripts that LOL has in their page.

Michael Barlow [2:02 PM]
I’m not sure we have control over it. If LOL has some custom way to handle tab input, then it’s totally out of our hands. To be safe, you can make an issue in scenery since we’re seeing it on other a11y sims, and assign it to JG, MK, and myself. We’ll investigate. One thing I noticed is that on non-a11y sims, the page jumps back to the top after tabbing through the sim screen. This makes me think that somehow, our PDOM within the iframe is being rendered in a strange way such that when tabbing around it jumps to that spot in the page.

I just tested on Windows and was able to reproduce the issue - however, it turns out you have to scroll all the way to the bottom of the page before pressing tab. Didn't realize this while I was testing for mac.

I may have just seen this happen. @rea-laura if you scroll down again can you still see the whole sim? Then it jumps back up again on next tab? I missunderstood the issue initially.

@jessegreenberg yes, that's what is happening. I posted a video on google photos if you would like to see the bug in action: https://photos.app.goo.gl/hCKVWEsDhBJXGD1J8

Very helpful, thanks! Sorry I didn't see it in the original issue.

On my screen I can only get this to happen when I shrink my browser window vertically. But I wonder if this is a native browser behavior, like the document active element is the iframe, and the browser is trying to shift it into view? Or maybe it is like @mbarlow12 is saying in the issue ticket.

OK, new theory is that it is because the PDOM is crammed into the top left corner of the sim. So when focus changes, the browser shifts to put the focused iFrame element near the center of the view. This will be true if this issue is fixed in the pdom-transform branch of scenery.
I can't reproduce the problem in https://phet-dev.colorado.edu/html/coulombs-law/1.1.0-a11yTest.1/phet/coulombs-law_en_phet.html?mobileA11yTest&legendsOfLearning, @rea-laura can you please confirm that this is fixed in this version by testing with the LoL harness?

This will be fixed naturally with the mobile a11y work. But I don't know the severity of this issue. Is it important for this issue to be fixed in coulombs-law, (or other sims that are nearing publication) and previously published sims? The changes would be too large to be applied in maintenance releases, so new RCs from master would be needed for each.
This bug only happens when the sim iframe is larger than the browser window.
@emily-phet can you please comment on this?

@rea-laura nice find!
Just throwing in my two cents -- @jessegreenberg @mbarlow12 @emily-phet given that the LOL website isn't at all keyboard navigable, I don't think this should be a blocking issue for Coulomb's Law (or any other upcoming sim).

Not 100% sure I'm following the root of this issue, but especially if it's an LOL specific problem we shouldn't fix.

Just curious - how was this issue found? I think we should be careful when investigating PhET-io + a11y related issues. We don't expect these two to work well together, so I don't think it's worth significant effort to test these combos or investigate the issues.

Hmm, good question about LoL, should we be testing a11y at all on their platform? LoL is separate from PhET-iO so in the past we have done some things to make sure that keyboard navigation works well in their harness. Here is an example, where we disabled all keyboard nav when the sim is disabled: https://github.com/phetsims/phet-io/issues/995 (Sorry it is tracked in the phet-io repo, but is not specific to phet-io). I think this is the first a11y+LoL bug we have found since then.

I think we have a decision on this issue in particular, so I am going to close this one. Moving the discussion about whether a11y should be tested in the LoL harness to the meeting doc, but @emily-phet please reopen or move somewhere else if there is a better place to discuss.


Drop udeps and sorted deps cargo linters to speed up test suite.

As previously discussed, we can probably drop these linters as they are slow and not as important.
It's quite sufficient to run them just once in a while.

let's add those to the CI instead


[0.5pt] Set up the project with Webpack and Jest- group task

Set up Gitflow
Set up webpack
Set up a JavaScript testing library (Jest)

https://github.com/AndreaM2429/JavaScriptCapstone/pull/22


TransferManager task management

Encapsulate channel processing.
Various cleanup tasks.

API change check
API changes are not detected in this pull request.


[YUNIKORN-1928] Remove the unused skip logic for auto scaling container.

What is this PR for?
In shim side we have skip autoscaling logic both for yunikorn mode and plugin mode.
switch request.State {
case si.UpdateContainerSchedulingStateRequest_SKIPPED:
    // auto-scaler scans pods whose pod condition is PodScheduled=false && reason=Unschedulable
    // if the pod is skipped because the queue quota has been exceed, we do not trigger the auto-scaling
    task.SetTaskSchedulingState(interfaces.TaskSchedSkipped)
    if ctx.updatePodCondition(task,
       &v1.PodCondition{
          Type:    v1.PodScheduled,
          Status:  v1.ConditionFalse,
          Reason:  "SchedulingSkipped",
          Message: request.Reason,
       }) {
       events.GetRecorder().Eventf(task.pod.DeepCopy(), nil,
          v1.EventTypeNormal, "PodUnschedulable", "PodUnschedulable",
          "Task %s is skipped from scheduling because the queue quota has been exceed", task.alias)
    }

We need to remove the unused misleading logic.
What type of PR is it?

[ ] - Bug Fix
[x] - Improvement
[ ] - Feature
[ ] - Documentation
[ ] - Hot Fix
[ ] - Refactoring

Todos

[ ] - Task

What is the Jira issue?

Open an issue on Jira https://issues.apache.org/jira/browse/YUNIKORN-1928
Put link here, and add [YUNIKORN-Jira number] in PR title, eg. [YUNIKORN-2] Gang scheduling interface parameters

How should this be tested?
Screenshots (if appropriate)
Questions:

[ ] - The licenses files need update.
[ ] - There is breaking changes for older versions.
[ ] - It needs documentation.

This logic is 100% needed and should not be removed. It is used to flag pods that have been skipped so that they may be treated differently by the scheduler plugin logic. Unlike the standalone scheduler mode (which does not need this), plugin mode does, because the default scheduler itself is the one responsible for setting the Pod state. Without this, PreEnqueue functionality is broken.


Include 'tomkerkhove' Helm chart repo

Include tomkerkhove Helm chart repo which includes Helm charts for Azure API Management Gateway
Relates to https://github.com/tomkerkhove/azure-api-management-gateway-helm/issues/4.

This PR is messed up, will recreate it


CREATE FUNCTION relation already exists

I am creating two distinct functions but sqlc (both v1.7.0 and v1.8.0) seems to think they are the same function!
CREATE FUNCTION myfunction(text[], text[]) RETURNS real
    LANGUAGE plpgsql
    AS $_$
DECLARE

and
CREATE FUNCTION myfunction(text, text[]) RETURNS real
    LANGUAGE plpgsql
    AS $_$
DECLARE

The error: relation "myfunction" already exists
Playground
https://play.sqlc.dev/p/afc48eca64c2a3d37feae81b57a7ee1a0bb0e6346d02879ac84c383e27b04730

Confirmed that this is still an issue as of 1.21


Add more date/year mappings from MusicBrainz Picard

Thanks, I added back the "Dates" marker comment


Add clock_gettime(CLOCK_MONOTONIC) monotonic time source

For now the time source is disabled by default, enabled using configure.py -DDUK_USE_GET_MONOTONIC_TIME_CLOCK_GETTIME. It'd be nice to enable the monotonic time source but coming up with a safe condition (guaranteeing the source is available) for each Unix platform needs a lot of investigation.
The default Date provider, which performance.now() falls back to in absence of a monotonic time provider, has sub-millisecond resolution for Unix. So performance.now() works reasonably for common use cases, though the time is not necessarily jump free.

What is the difference between clock_gettime(CLOCK_MONOTONIC) and clock()?

As far as I can tell, clock() has poorer accuracy and can wrap around relatively quickly.

Linux man page indicates the resolution (CLOCKS_PER_SEC) is 1000000, i.e. microsecond resolution. On a 32-bit system the result will wrap around every 72 minutes.
Because clock() exists even in C89 it might be a good default provider for monotonic time, if one could ensure:

The clock_t type is 64 bits (unlikely on a 32-bit system, likely on a 64-bit system) so wrapping is not a concern.
CLOCKS_PER_SEC is high enough, e.g. on Unix systems it's apparently always 1000000 (microseconds).

Wrapping would be easy to handle if there was some guarantee Duktape would get execution time at least every 15-30 minutes. But, there's unfortunately no such guarantee.

MSDN indicates CLOCKS_PER_SEC is only 1000 for MSVC.  Additionally, it seems the value doesn't wrap around but instead saturates to -1 and this is the standard behavior per C99:
https://msdn.microsoft.com/en-us/library/4e2ess30.aspx
Which makes sense since clock_t is signed and signed overflow is undefined behavior, so it would be somewhat strange for a signed counter to roll over.

I think clock_t can be unsigned though; the error return value is (clock_t) -1 which also works for an unsigned clock_t. Regarding the Linux behavior, from the man page:

POSIX.1-2001, POSIX.1-2008, C89, C99.  XSI requires that CLOCKS_PER_SEC equals 1000000 independent of the actual resolution.
[...]
Note  that  the  time  can  wrap around.  On a 32-bit system where CLOCKS_PER_SEC equals 1000000 this function will return the same value approximately every 72 minutes.

Btw, while signed overflow is undefined behavior in general, there's no reason why it wouldn't be perfectly well defined for a particular clock() implementation (or more generally a particular architecture/compiler).
In any case, quite different behavior indeed, and unfortunately not always a good basis for monotonic time.


Are there any samples for this theme?

Hi,
Are there any samples for this theme?   I have been - to the best of my knowledge, following along, but have run issues, trying to figure out missing properties and and the like.  For example, the timeline images don't render properly for me, I get clipped, and distorted circles that don't like up with the modal views.
Is there a working sample that could act as a guide?
Thanks!

This? https://github.com/SotiriosVrachas/jekyll-theme-startbootstrap-agency-child
I haven't used the timeliness in any other project.


Issues with image fusion generation.

After merging, the side profile of my image has encountered this issue. There are noticeable problems in the merged section. I'd like to know how to resolve it. Thank you.

If the facial side angle is too large, indeed, there will be many unknown bugs at present


Draft of using reader database instance

How it works:

During server startup, check for presence of a "reader" database config
If there is a "reader" database config, setup a 2nd database pool for that instance
Anytime the server requests a database client, it must specify "reader" or "writer"
If the server requests a "reader" and the "reader" pool is available, then use a "reader" connection
Database transactions always use "writer", including "reader" queries once inside a transaction

Needs more testing:

We should be able to test this easily by creating a 2nd postgres user medplum_readonly or whatever
I want to do some deeper testing on requests that potentially use a mix of "reader" and "writer"

The fear is the following situation:

Create a resource using a "writer" connection
Immediately search for a resource using a "reader" connection
But the "reader" search executes during the brief window where "reader" and "writer" are out of sync
Weird results follow

To resolve that, we may want to add some kind of logic such as: "once you use a writer connection, you have to use writer connections for the rest of the request"

Idea I'm not married too but might make sense:
What if we tied the readonly / read-write behavior to the Repository itself? That way it is explicit if you are in read-only mode or read-write mode

Tests failing because Github Actions doesn't use init_test.sql 🤔
https://github.com/medplum/medplum/actions/runs/9765092525/job/26955125449?pr=4772

There's probably a way to do this using "Initialization Scripts", but need to research how to set that up: https://hub.docker.com/_/postgres

What if we tied the readonly / read-write behavior to the Repository itself? That way it is explicit if you are in read-only mode or read-write mode
Repository defaults to read-only mode but falls back to read-write if any create, update, or delete is detected. Only searches or readResource are allowed in read-only

Yeah, I think that is where this is headed.
The getDatabasePool(mode) method will still need to exist, for the handful of cases that execute SQL queries outside of Repository.
Within Repository, I think you're right that you can request READER or WRITER, but as soon as you use WRITER once, you get a WRITER for the duration of the Repository instance.
We still may need to set a similar flag at the request context level, in particular for the case where we create a temp systemRepo, and it has to play nice with the user's repo.  I don't have a great example off the top of my head, but something like:

systemRepo creates a resource
repo needs to read that resource, and executes a search

With current logic, that search may be in READER mode, which could lead to incoherent results
Arguably the "right" thing to do here is never rely on create-then-search behavior, and just pass around the resources
But if that proves too thorny, then the model would be to inspect request context to see if there have been any writes