Floating point should be made optional

Right now, we have a floating point register, forwarding paths, pipeline stages, etc. despite not supporting hardware float. But, we don't want to outright remove it because we will eventually support hard float (and even when we have it, we want to provide users the option to use either hard or soft float). Therefore, we need a parameter which enables or disables FP things in the core. The trick is to do this without making the BE more fragile or less readable.

Can it go in its own module?
M
On Wed, May 8, 2019 at 10:07 PM Dan Petrisko<EMAIL_ADDRESS>wrote:

Right now, we have a floating point register, forwarding paths, pipeline
stages, etc. despite not supporting hardware float. But, we don't want to
outright remove it because we will eventually support hard float.
Therefore, we need a parameter which enables or disables FP things in the
core. The trick is to do this without making the BE more fragile or less
readable.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/black-parrot/pre-alpha-release/issues/157, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEFG5ACTGOTQX54LDETW42LPUOWR5ANCNFSM4HLXFR5A
.

The changes are pretty dispersed throughout the Calculator. I’ll have to think about it. Possibly if we encapsulate regfiles + bypass in a single unit, that could be a good partitioning for one piece

Live in dev. There are some extra optimizations that could be made to e.g. shorten the pipeline length. But we might extend it for the iterative multiplier anyway, so it seem premature to mess around with it


vscode lock-up for ~30s if database is locked with OSCrypt tried libsecret but couldnt initialize

Type: Bug

use libsecret (~/.vscode/argv.json "password-store": "gnome-libsecret", https://github.com/microsoft/vscode/issues/187842#issuecomment-1634523221)
use keepassxc (or others?)
have a key in the database for vscode
have the SSI database locked and try to start VSCode
observe vscode lockup for ~30 seconds and have message [92965:1211/204454.929093:WARNING:key_storage_linux.cc(183)] OSCrypt tried Libsecret but couldn't initialise.

i believe this is related to the dummy entry Chrome makes and locks-up if it cannot find it in any locked database (even if they had already been opened once in keepassxc and so should be "warm").
note that this was not a problem with vscode 1.79's keytar, there it would in 80% of cases ask me to unlock the database first (weirdly keytar's implementation was timing out sometimes and i am not sure why) *
EDIT: 1.79.2's keytar and keepassxc sometimes asks for unlocking the database but not always (likely a keepassxc bug if dbus-monitor is anything to go by); but at least keytar did not make vscode un-useable for such a long time (but it did prevent / prolong shutdown if keytar couldnt resolve / is still trying to resolve)
VS Code version: Code 1.85.0 (af28b32d7e553898b2a91af498b1fb666fdebe0c, 2023-12-06T22:27:05.695Z)
OS version: Linux x64 6.6.5-1-MANJARO
Modes:

System Info

Item
Value

CPUs
AMD Ryzen 7 5800X 8-Core Processor (16 x 3700)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
3, 2, 2

Memory (System)
15.53GB (9.39GB free)

Process Argv
. --verbose --crash-reporter-id 3159ccf7-dead-4761-b348-a6094ef14c0c

Screen Reader
no

VM
0%

DESKTOP_SESSION
plasmawayland

XDG_CURRENT_DESKTOP
KDE

XDG_SESSION_DESKTOP
KDE

XDG_SESSION_TYPE
wayland

Extensions (21)

Extension
Author (truncated)
Version

path-intellisense
chr
2.8.5

gitignore
cod
0.9.0

vscode-markdownlint
Dav
0.53.0

vscode-eslint
dba
2.4.2

gitlens
eam
14.5.2

EditorConfig
Edi
0.16.4

prettier-vscode
esb
10.1.0

html-slim-scss-css-class-completion
gen
1.7.8

gc-excelviewer
Gra
4.2.58

vhs
gri
0.0.4

todo-tree
Gru
0.0.226

vscode-test-explorer
hbe
2.21.1

graphql-for-vscode
kum
1.15.3

rainbow-csv
mec
3.9.0

git-graph
mhu
1.30.0

test-adapter-converter
ms-
0.1.8

vscode-xml
red
0.26.1

bash-beautify
sha
0.1.1

markdowntable
Tak
0.11.0

even-better-toml
tam
0.19.2

markdown-all-in-one
yzh
3.5.1

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
pythonvs932:30410667
py29gd2263:30899288
vscaac:30438847
vsclangdf:30486550
c4g48928:30535728
dsvsc012:30540252
azure-dev_surveyone:30548225
3biah626:30602489
89544117:30613380
2i9eh265:30646982
showlangstatbar:30737416
0bi6i642:30917235
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
welcomedialog:30910333
pythonnosmt12:30797651
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
dsvsc013:30795093
dsvsc014:30804076
dsvsc015:30845448
pythontestfixt:30902429
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
2e7ec940:30885897
pythontbext0:30879054
accentitlementsc:30887149
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
aa_t_chat:30882232

slight update to the reason why:
from my further testing both keytar's and the new interfaces not prompting to unlock is because of a keepassxc issue https://github.com/keepassxreboot/keepassxc/issues/10096.
but the point about the 30s lock-up still stands, and i also noticed that vscode is completely locked while the prompt is active, which was not the case with keytar

Happening for me on Fedora 38, Gnome desktop.

Due to GNOME organizations brain dead implementation of their latest desktop environment it is now IMPOSSIBLE to run more than one desktop (although you can) but the instance manager gets in a weird state if you do.   Resulting in this side effect.
https://gitlab.gnome.org/GNOME/gnome-remote-desktop/-/issues/84#login-pane


Fix syncing of bigger-than-short fuel times to Vanilla clients

While QSL manages to successfully interpret the properties, a Vanilla client ends not succeeding on that, causing a desync on the fuel progress display. This should be fixed somehow

This can be fixed by scalling down both current and max value in screen, as on vanilla the value only changes stuff visually in a range of few rows of the texture


fix: missing tokenizer choice in AzureOpenAI subclasses

Fixes a bug in AzureOpenAI.
If an object is instanciated from a subclass of AzureOpenAI, then the tokenizer is always derived from the model name via tiktoken, even if a tokenizer is passed.
This will typically fail, because Azure OpenAI deployments have individual model names.
This fixes this case.

Great catch -- thanks for this @imarquart!


pull request for e2e test at 12/16/2016 05:56:26

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


feat(proxy): proxy cache debug

Update of #7829
Summary
Remove proxy cache headers from response if the kong debug is not set.
Adding Miss/Hit, Age and cache key to answer shouldn't be the default behavior.
Full changelog
The following headers:
X-Cache-Status
X-Cache-Key
Age
are now set only if the header kong-debug is set to 1
Refactor test to remove duplicated lines and use get, post and delete helpers instead of send

@hbagdi Please give this your final review.

Is this potentially a breaking change in terms of the behavior of the proxy?

@hbagdi I have described the impact.

Remove proxy cache headers from response if the kong debug is not set.

Nothing has changed on the caching part, just the headers added in the response.
imho such header shouldn't be added by default.
If you think it is a breaking change I can add a configuration param in addition of debug mode to control if headers are added

Remove proxy cache headers from response if the kong debug is not set.

Nothing has changed on the caching part, just the headers added in the response. imho such header shouldn't be added by default.

The reason why we've not just merged this change is that even though your opinion matches ours, we don't know how many customers rely on the incorrect behavior of Kong.  We're still in the decision process.

If you think it is a breaking change I can add a configuration param in addition of debug mode to control if headers are added

Adding a specific configuration parameter to disable incorrect behavior of previous versions of Kong should be the last resort, but we may want to go that route and make the correct change, like you proposed, in the next major release.  Please bear with us for a couple of more days.

@hanshuebner How is this not a breaking change?

@hbagdi All the arguments have been made.  From your question, I take it that you don't agree that we can merge this.  Please let us know how to proceed.

@hbagdi The gist of the problem here is the interpretation of what the headers X-Cache-Status, X-Cache-Key, Age are.

If we interpret that they are "headers that are only useful when debugging a problem" then generating them all the time was a bug. Anyone relying on this for doing this was thus relying on buggy behavior. So with this interpretation, merging this is not a breaking change (because breaking buggy behaviour is not a breaking change).
If we interpret that "the way things were working before is acceptable" - that sending those headers all the time is correct, then this is a change in functionality and a breaking change. The soonest we would be able to merge this would be with a proper deprecation on Kong 4.0. We could start emitting deprecation messages in the logs in the meantime.

Not sure that not being able to not sent the header was acceptable.
If you think this is a breaking change, I can add a flag to add them or not, set to true by default.
And when the flag is set to false, the debug mode will add them at demand.

I was planning to add a flag for each header, to put it on the answer. set to true by default to keep the behavior
And force all on debug mode

Is a single configuration field that is an array of string better? Or worse?

I have added a response_headers field into the configuration with 3 fields:

age
X-Cache-Status
X-Cache-Key

Allowing to set or unset the presence of the header into the response.
As discussed, to keep previous behavior, all fields are present by default.

@bungle Except for the missing removed_fields entry, do we need anything else for this schema change to be accepted?

@bungle Can you have a look at this schema change, please?

This needs a compat change as well i.e. addition to removed_fields.lua.

Closing because of lack of activity. We would like to accept this contribution if anyone wishes to pick this back up.

Not sure what is missing, just rewords the Merge request?
On Mon, Jun 26, 2023, 20:00 Harry @.***> wrote:

Closed #10445 https://github.com/Kong/kong/pull/10445.
—
Reply to this email directly, view it on GitHub
https://github.com/Kong/kong/pull/10445#event-9642114113, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAB345OTE5PTWI3TH64KCCTXNHE2FANCNFSM6AAAAAAVSQJISI
.
You are receiving this because you were mentioned.Message ID:
@.***>

That and https://github.com/Kong/kong/pull/10445#issuecomment-1581504186. Please re-open if you want to take this to the finish line.

I have reword the PR, changelog commit is done on my fork, I don't have permission to reopen the PR.
Not sure what is a compat change, here as asked the previous configuration will still trigger the same behavior.

@hanshuebner is it good now ? If something else is needed can you highlight it ?

Thanks for your support to make it happen

Will double-check when CE2EE merge.


[Parabeac Eggs] Parabeac Egg for Text Fields

Request Type: Parabeac Egg Request.
Egg Description
This egg would allow support for text fields to be generated in the place of general Text widgets. These would be configured to return input when called upon.
Semantic Suggestion:
.*text-field or with <> <text-field>
Relevant Widgets:

Text Field

Additional Notes:

This was addressed by @DepressoExpressoBoi . Closing out.


Multiline functionality v3 vs v4

For the following:
     x     |    x
-----------|-----------
test1      | test2 \
           |  \
           | test3

v3.1.3 produces:

whereas v4.0.3 gives:

Is it a regression bug or a feature? 😊

Yes, that's a bug.
It seems caused by incorrect pipes scanning, as done in 6b2c2ea.
And I may fix this in few days.

What is the current status on this bug? I need some of the functionality in version 4 of multimd-table, but I can't update it before the bug has been fixed, since my code would otherwise break.

@dk-teknologisk-mnm Sorry for the long delay, I was busy with other things and have no time to check until recently. This bug is fixed and published as v4.1.0.

No worries and thank you for fixing the bug. It seems to work as it should. :-)
I did encounter another thing.
    1     |     2
----------|----------
Test 1    |          \
          | Result 1 \
          |
Test 2    | Result 1 \
          |          \
          | Result 2 \
          |

When I write the above I expect it to give:
1                    2

Test 1               Result 1
Test 2               Result 1 Result 2

But instead it does not render 'Result 1' in 'Test' 1 at all:
1                     2

Test 1
Test 2                Result 4 Result 5

Is this a bug or is it expected behaviour?

It's an implementation bug. Because the current parser assumes:
The first line of a multi-line contains exactly the number of cells.
So the 2nd cell of the fourth line got ignored, as the third line contains 1 cell only (slash excluded).
But since the assumption simplifies the code, I'll leave this open until there's a simple solution to this bug.

Okay. If it can be of any use, here is an explanation of the use-case where I get the bug.
I have a table where I have several if-statements. In order to make it readable this spans over several lines in the table.
So it would look like this:
   1   |   2
------ | ------
Test 1 | {{#if something}} \
       | Text 1            \
       | {{else}}          \
       | Text 2            \
       | {{/if}}

... which if statement is true then becomes this in markdown:
   1   |   2
------ | ------
Test 1 |          \
       | Text 1   \
       |          \
       |          \
       |

So this is why I get the bug.


How to mock specific function  in momentjs

Struggling to mock 2 things using moment js
export const timeZoneFullFormat = () => mtz.tz.guess() //America/Chigao
export const getLocalTime = (time) => moment.utc(time).local()
i want to mock momentjs helper function so that the time changes based on the zone[if you are running in central time zone it has to consider the same time zone]
Did not find solution .

Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions. You'll find more on Jest docs help page. Thank you :)


Code improvements - redundant nil check & multiple redundant append()

This commit makes the following improvements -

len() returns 0 if arg is nil, making the nil check redundant
multiple append() calls can be replaced with single append()

Find the other issues found here - https://deepsource.io/gh/chsatyap/terragrunt/issues/?category=all
This PR also adds .deepsource.toml configuration file to run DeepSource analysis on the repo with. Upon enabling DeepSource, the analysis will run on every PR and commit to detect 560+ types of issues in the changes — including bug risks, anti-patterns, security vulnerabilities, etc.
To enable DeepSource analysis after merging this PR, please follow these steps:

Signup on DeepSource with your GitHub account and grant access to this repo.
Activate analysis on this repo here.

You can also look at the docs for more details. Do let me know if I can be of any help!

Thanks for the PR. This is a clever way to do marketing/sales. I don't think we want to sign up for DeepSource right now, so we'll close the PR, but may consider it in the future.


Add advanced semantic highlighting to the ruby-lsp

Improve our existing semantic highlighting to address more complex Ruby syntax.

[x] Method and block arguments
[x] Punctuation (e.g.: the namespace separator :: or the pipes in a block argument are sometimes highlighted incorrectly without semantic support)
[x] self in front of singleton method definitions and the accompanying dot

We can also enhance the highlighting of syntax that is related to a specific tool, such as Sorbet or Rails. For example,

[x] Sorbet signature declarations
[x] Other Sorbet inline type annotations, such as T.let

Additionally, the specification supports some performance related improvements we can explore. There are two existing options (maybe implementing both is a good idea too)

Implementing semantic tokens delta and refresh. This means we have to maintain in memory (inside our Document store) the current semantic tokens for a file and only return the difference between the previous response and the current one (indicating which tokens were deleted and which ones were added)
Implement semantic tokens for a range. This one is considerably easier than delta and refresh, it's just a matter of returning only the tokens for the given visible range of the document to avoid flickering. In short, it's a new request endpoint where we could simply re-use our semantic tokens implementation and filter tokens that are outside of range

Documentation: https://microsoft.github.io/language-server-protocol/specification#textDocument_semanticTokens

Closing this as we already implemented range semantic tokens and many of the proposed features. We can add more granular tasks if needed.


--namespace not available

I'm using v1.0.4 and according to the 1.0 branch there's an option for --namespace, but the CLI says this option is not available.

I hadn't tried using the namespace option myself until you mentioned it.
It seems to work just fine when I test it out.
$ php artisan crud:generate Test --fields="name:string" --namespace="test\namespace"
Controller created successfully.
Model created successfully.
Migration created successfully.
View created successfully.
Crud/Resource route added to /Users/james/Desktop/projects/laravel-boilerplate/app/Http/routes.php

Paste the command line that you are running?

Hi,
You can do that for now using "1.0.x-dev" version.
I will release the next stable release soon.
Cheers

@remailednet I'm using following command:
php artisan crud:generate Task --fields="name:string, complete:boolean, due:datetime" --route=yes --pk=id --view-path="admin" --namespace=Admin

But I'll try the 1.0.x-dev version as @sohelamin said tonight.

Just released the stable version with namespace feature


Forms with descriptive text

Addresses JIRA 412: Add descriptive text to back-end and display in UI.
Added getDescription functions to each of the lookup objects exported from the lib folder. getDescription takes a structuredField and gets the description to go along with that structuredField .

toxicity is crashing resulting in not getting anything but #toxicity in copy button
Uncaught TypeError: Cannot read property 'adverseEvent' of null
at Object.ToxicityForm._this.handleUpdateAdverseEventInput [as onUpdateInput] (ToxicityForm.jsx:149)
at AutoComplete. (AutoComplete.js:225)
at CallbackQueue.notifyAll (CallbackQueue.js:76)
at ReactUpdatesFlushTransaction.close (ReactUpdates.js:59)
at ReactUpdatesFlushTransaction.closeAll (Transaction.js:206)
at ReactUpdatesFlushTransaction.perform (Transaction.js:153)
at ReactUpdatesFlushTransaction.perform (ReactUpdates.js:89)
at Object.flushBatchedUpdates (ReactUpdates.js:172)
at ReactDefaultBatchingStrategyTransaction.closeAll (Transaction.js:206)
at ReactDefaultBatchingStrategyTransaction.perform (Transaction.js:153)

happens on master branch as well actually

I'll log a jira for it

There's no descriptive text for each reason on progression form?

I also see the error that Greg is getting. The copy button for toxicity is not getting updated with the shortcut string
I noticed in the mockups that there are descriptions for the adverse events too.

The code does not currently have that. Right now the adverse event just displays the name of the adverse event without the description.

Disease progression description at top of progression form has a typo in 2nd sentence: "It is the point of care which includes objective measures like tumor growth,"

Add it to the JIRA issue. It is not a problem with this pull request

In the description of toxicity at the top, should we incorporate some basic text indicating that we are using the CTCAE version x and spell out CTCAE?
Common Terminology Criteria for Adverse Events (CTCAE) version 4.03 (June 14, 2010)

a. Didn't notice the descriptions for AE and Grade's in the mockups -- I can work on adding that before merging.
b. Good catch on the toxicity problem.
c. I'm on board with the text regarding the current version!

What about progression status and reasons. each has a description in progression_lookup but they aren't displayed currently? Is that based on the mock-ups not showing anything?

Thanks for adding the ID's. And yeah -- they weren't shown in the mock ups so I didn't prioritize them. Since those will likely be buttons/checkboxes, maybe we can add tooltips if we want? Up to you whether or not we add that to this PR though.

So for GQ1, I looked back at concept and agree that tooltips may make the most sense like Nicole did for staging.

So we've addressed GQ2 and GQ3 with these new commits.
For GQ1, since those changes are intertwined with the progression form redesign, we will add this issue to the existing JIRA item's description and address it then.
Re: Nicole's suggestion for the adverseEvent descriptions, we will be able to successfully include descriptions of adverseEvents when we remove support for multiple toxicities. So we will put that off for now.

The changes look good. Since GQ1 will be done as part of another jira issue (after completing issue 425), I think this is good to merge


Draft: Allow lowering the chunk_size on Resampler

ATTENTION: This is just me playing around with the codebase, i have no idea of the math ^^
This extends the Resampler trait with:

fn set_chunk_size(&mut self, chunk_size: usize) -> ResampleResult<()>;
fn chunk_size(&self) -> usize;
fn max_chunk_size(&self) -> usize;

ToDo:

[ ] Currently this calculated an invalid needed_length after the first processed frame
[ ] Rebase on top of https://github.com/HEnquist/rubato/pull/80
[ ] Remove weird default implementations

given that there are still todos, shouldn't this be a draft?

This functionality is included in the v0.16.0 release.


hound errors out when trying to read samples from this file

When trying to use hound from my application in such a way:
let data: Vec<u8> = wav_file_received_over_the_network;
let reader = match hound::WavReader::new(&data[..])

Hound fails with:
Ill-formed WAVE file: data chunk length is not a multiple of sample size

When dumping that data to file and attempting to use the rms example on it, hound fails in a similar way:
thread 'main' panicked at examples/rms.rs:31:34:
called `Result::unwrap()` on an `Err` value: IoError(Custom { kind: Other, error: "Failed to read enough bytes." })

The file plays back just fine with vlc, you can download it here: <www.mathieudu.com/misc/tmp.wav>

related to https://github.com/ruuda/hound/issues/63 I assume


Add support for "str" alias in PandasDtype.from_str_alias

Is your feature request related to a problem? Please describe.
Relating to #278, the problem is that yaml file schemas don't accept the value str for pandas_dtype argument.
Describe the solution you'd like
Add the "str" string alias to PandasDtype.from_str_alias, which should map onto the Object dtype, since the "string" alias should map onto the pandas-native string type.

fixed by #261


Change version import to relative import

Failed during building docs
Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/lance-docs/envs/lei-docs/lib/python3.10/site-packages/sphinx/ext/autodoc/importer.py", line 58, in import_module
    return importlib.import_module(modname)
  File "/home/docs/.asdf/installs/python/3.10.4/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/home/docs/checkouts/readthedocs.org/user_builds/lance-docs/checkouts/lei-docs/lance/python/lance/__init__.py", line 25, in <module>
    __version__ = lance.version.__version__
AttributeError: partially initialized module 'lance' has no attribute 'version' (most likely due to a circular import)


Restore Carthage

Restore Carthage distribution now that Carthage 0.38.0 supports binary xcframework distributions.
This PR removes the code that was repackaging build xcframeworks as frameworks for Carthage. Now we distribute exactly the same xcframeworks in the zip distribution as Carthage with the exception of the rebuilt FirebaseCoreDiagnostics.
Successful Carthage 8.0.0 generation in https://github.com/firebase/firebase-ios-sdk/actions/runs/845683211 after generating package on GHA after disabling --local-podspec-path from build_zip.sh. More context about this in #8082.

Thanks for getting this update so quickly!


Hover cards for owner/repo#123 don't show if the issue number is large

Extension version: v0.42.0
VSCode Version: 1.67.1
OS: Windows 10

I have noticed hover cards only show for me when the number is below something like 1100ish?
Steps to Reproduce:

Try hover with python/cpython#1000 and the card displays:

Try hover with python/cpython#83413 and the card doesn't display:

@michaeloliverx do you have the python/cpython repo open in the VS Code window that you're doing the hovering in? My guess is that the answer is no, and that you have a different repo open where the largest issue number is <1100ish.
We use the max issue number of the repo you have open to avoid incorrect hovers, but we shouldn't do that when the format of the hover is <owner>/<rep>#<number>, and only when the format is just #<number>

@


Use providePromises for QuiverSocialProvider

Use providePromises for the social2 API calls in QuiverSocialProvider.  I will create another pull request after this one to move the remaining functions (syncConfiguration_, connectLoop_, etc) to return Promises as well - that will help clean up some of the deeply indented code.
Tested in uProxy and verified no errors in the closure compiler.

:+1:


Functions 404 with Netlify Dev and a linked project

- Do you want to request a feature or report a bug?
BUG
- What is the current behavior?
All functions return 404 not found running netlify dev when netlify link is initialized. Meaning the directory .netlify exists in the project root allong with state.json in that directory filled with its proper site id.
# PROJECT_ROOT/.netlify/state.json
{
    "siteId": SOME_SITE STRING
}

- If the current behavior is a bug, please provide the steps to reproduce.

add new project in netlify and also create a new directory locally with a functions directory and at least one function. (do NOT link or init local dir yet)
add netlify.toml configuration to project root with splat proxy redirect to functions (see netlify.toml setup below)
first run netlify dev and test route using curl hitting proxy default: localhost:8888/api/yourFunc this should return a response correctly
now run netlify link to link up the project created in netlify platform
restart netlify dev and re-curl proxy endpoint default: localhost:8888/api/yourFunc. Now you get 404 response

- What is the expected behavior?

netlify dev should use all local configuration regardless of linking the project or not.
Also env injection should be available via a flag not by default. The functions should return as usual without using any network. NOTE: this fails even with the --offline flag appended
When linked the base directory should be implied the current working directory, no? Sensible default

- Local Environment Information
Using defaults aside from a redirect proxy splat rule in netlify.toml
[build]
    command = "#"
    publish = "public/"
    functions = "functions"

[[redirects]]
    from = "/api/*"
    to = "/.netlify/functions/:splat"
    status = 200
    force = true

Running netlify dev without linking
◈ Netlify Dev ◈
◈ No app server detected and no "command" specified
◈ Running static server from "netlify-serverless/public"   <-- CORRECT DEFAULTS

◈ Server listening to 3999

◈ Functions server is listening on 34121

   ┌─────────────────────────────────────────────────┐
   │                                                 │
   │   ◈ Server now ready on http://localhost:8888   │
   │                                                 │
   └─────────────────────────────────────────────────┘

◈ Rewrote URL to /.netlify/functions/someFunc
Request from ::ffff:<IP_ADDRESS>: GET /.netlify/functions/someFunc
Response with status 200 in 10 ms.

Running netlify dev with project linked (ie .netlify/state.json in project root)
◈ Netlify Dev ◈
◈ No app server detected and no "command" specified
◈ Running static server from "netlify-serverless/public/public" <-- NOTICE because 'base' is not set in netlify.toml

◈ Server listening to 3999

◈ Functions server is listening on 40657

   ┌─────────────────────────────────────────────────┐
   │                                                 │
   │   ◈ Server now ready on http://localhost:8888   │
   │                                                 │
   └─────────────────────────────────────────────────┘

◈ Rewrote URL to /.netlify/functions/someFunc
Request from ::ffff:<IP_ADDRESS>: GET /.netlify/functions/someFunc
Response with status 404 in 4 ms.

netlify-cli/2.54.0 linux-x64 node-v12.16.2

Hey @jbool24 & @ddrake, I was trying to debug this but couldn't reproduce the issue. I'm using netlify-cli/11.8.3. Can you update the cli package and let me know if you're still experienced the issue.
I'll close this otherwise.

Closing as stale. Please re-open if needed


Variable View UI Cleanup part 1

For #4356

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[x] Title summarizes what is changing.
[ ] Has a news entry file (remember to thank yourself!).
[x] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).

A bit of context here. This change does two things. When hosted in a view (instead of a document) the variable explorer now no longer has a close button and sizes it self appropriate to the given view area.
Change is a bit funkier then might be expected due to how the variable view works. The grid that we used needed a hard code vertical size. So we had lots of old code (Tim worked on this) to handle resizing vertically with a dragger. It's all a bit non-clean / non reacty. Given that we're probably going to deprecate this view the goal was to fit this into the old context as cleanly as possible with the least disturbance to the existing variable code paths. Basics is that the variable view panel watches for resizes, then sets a viewHeight value in the state that is only used then in view mode, which is when the variable explorer is hosted in a view as opposed to a document.
Old Code (close button, doesn't fill space, has a draggable divider at the bottom):

New Code:

A bit of context here. This change does two things. When hosted in a view (instead of a document) the variable explorer now no longer has a close button and sizes it self appropriate to the given view area.
Change is a bit funkier then might be expected due to how the variable view works. The grid that we used needed a hard code vertical size. So we had lots of old code (Tim worked on this) to handle resizing vertically with a dragger. It's all a bit non-clean / non reacty. Given that we're probably going to deprecate this view the goal was to fit this into the old context as cleanly as possible with the least disturbance to the existing variable code paths. Basics is that the variable view panel watches for resizes, then sets a viewHeight value in the state that is only used then in view mode, which is when the variable explorer is hosted in a view as opposed to a document.
Old Code (close button, doesn't fill space, has a draggable divider at the bottom):

New Code:

Codecov Report

Merging #4449 (907260f) into main (e8af5b3) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##            main   #4449    +/-   ##
======================================
- Coverage     75%     75%    -1%
======================================
  Files        396     398     +2
  Lines      25863   26021   +158
  Branches    3707    3720    +13
======================================
+ Hits       19589   19593     +4
- Misses      4757    4907   +150
- Partials    1517    1521     +4

Impacted Files
Coverage Δ

.../datascience/interactive-common/synchronization.ts
84% <ø> (ø)

...t/common/application/webviewPanels/webviewPanel.ts
10% <0%> (-58%)
:arrow_down:

src/client/common/application/webviews/webview.ts
13% <0%> (-54%)
:arrow_down:

.../application/webviewPanels/webviewPanelProvider.ts
43% <0%> (-50%)
:arrow_down:

...nt/datascience/interactive-common/debugListener.ts
34% <0%> (-40%)
:arrow_down:

...datascience/interactive-common/showPlotListener.ts
33% <0%> (-39%)
:arrow_down:

src/client/datascience/dataScienceSurveyBanner.ts
69% <0%> (-20%)
:arrow_down:

...ent/datascience/interactive-common/linkProvider.ts
16% <0%> (-19%)
:arrow_down:

src/client/datascience/themeFinder.ts
61% <0%> (-17%)
:arrow_down:

...nce/notebook/notebookEditorCompatibilitySupport.ts
59% <0%> (-9%)
:arrow_down:

... and 66 more

Codecov Report

Merging #4449 (907260f) into main (e8af5b3) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##            main   #4449    +/-   ##
======================================
- Coverage     75%     75%    -1%
======================================
  Files        396     398     +2
  Lines      25863   26021   +158
  Branches    3707    3720    +13
======================================
+ Hits       19589   19593     +4
- Misses      4757    4907   +150
- Partials    1517    1521     +4

Impacted Files
Coverage Δ

.../datascience/interactive-common/synchronization.ts
84% <ø> (ø)

...t/common/application/webviewPanels/webviewPanel.ts
10% <0%> (-58%)
:arrow_down:

src/client/common/application/webviews/webview.ts
13% <0%> (-54%)
:arrow_down:

.../application/webviewPanels/webviewPanelProvider.ts
43% <0%> (-50%)
:arrow_down:

...nt/datascience/interactive-common/debugListener.ts
34% <0%> (-40%)
:arrow_down:

...datascience/interactive-common/showPlotListener.ts
33% <0%> (-39%)
:arrow_down:

src/client/datascience/dataScienceSurveyBanner.ts
69% <0%> (-20%)
:arrow_down:

...ent/datascience/interactive-common/linkProvider.ts
16% <0%> (-19%)
:arrow_down:

src/client/datascience/themeFinder.ts
61% <0%> (-17%)
:arrow_down:

...nce/notebook/notebookEditorCompatibilitySupport.ts
59% <0%> (-9%)
:arrow_down:

... and 66 more


Q() Lookup AND Condition Returns No Results

My Question
How do I filter posts by user containing multiple tags using AND conditional logic and Django's Q() complex lookups?
What Am I Trying To Do?
If someone visits a URL like so: http://<IP_ADDRESS>:8000/username/posts/tagged/django+python/, my URL pattern grabs the last part ("django+python"), splits it by the + sign, and I want to filter my posts model by these two tags where they contain both django AND python.
What I Expect To Work?
Currently, I see two posts in my database that have both "django" and "python" tags:
u = User.objects.get(username=myusername)
for post in Post.objects.filter(tags__slug='django', user=u).filter(tags__slug='python'):
...     print(post.tags.all())
...
<QuerySet [<Tag: python>, <Tag: django>, <Tag: templates>, <Tag: html>, <Tag: stylesheet>, <Tag: css>]>
<QuerySet [<Tag: python>, <Tag: django>, <Tag: jquery>]>

When I use Q() complex lookup logic, I get no results, and that's my question --> Why?
Here my multiple attempts.
Attempt 1
>>> from operator import and_
>>> from functools import reduce
>>> from django.db.models import Q
>>> slugs = ['python', 'django']
>>> conditions = [Q(tags__slug=slug) for slug in slugs]
>>> query = reduce(and_, conditions, Q())
>>> u.post_set.filter(query)
<QuerySet []>

Attempt 2
>>> u.post_set.filter(Q(tags__slug='python') & Q(tags__slug='django'))
<QuerySet []>
>>> u.post_set.filter(Q(tags__slug='python'), Q(tags__slug='django'))
<QuerySet []>

Attempt 3
>>> u.post_set.filter(Q(tags__slug__exact='python') & Q(tags__slug__exact='django'))
<QuerySet []>

More Info
models.py
class Post(models.Model):
    user = models.ForeignKey(settings.AUTH_USER_MODEL, on_delete=models.CASCADE)
    ...
    tags = TaggableManager()

urls.py
urlpatterns = [
    path('posts/tagged/<tags>/', TagListView.as_view(), name='posts_tagged'),
]

Why don't I just chain filters and call it a day?
Because I want the user to be able to filter posts by a theoretically unlimited number of tags.
Ex: http://<IP_ADDRESS>:8000/username/posts/tagged/django+python+jquery+css+javascript+some-tag+whatever/,
Point is, there is no discrete number of tag slots available, it should be free-range for flexibility for the user.

Let's look at the following query:
>>> print(Document.objects.filter(Q(tags__name="foo")&Q(tags__name="bar")).query)
SELECT "docs_document"."id", "docs_document"."name"
FROM "docs_document" INNER JOIN "docs_uuidtaggeditem" ON ("docs_document"."id" = "docs_uuidtaggeditem"."content_object_id") INNER JOIN "docs_mycustomtag"
 ON ("docs_uuidtaggeditem"."tag_id" = "docs_mycustomtag"."id") WHERE
 ("docs_mycustomtag"."name" = foo AND "docs_mycustomtag"."name" = bar)

When we do these sorts of ORM lookups through a relation, we create one result per (object, tag) pair, right? But the filters work on each row. So we're looking for an (object, tag) pair where the  name equals one result and another at the same time. Suffice to say, this will basically always be empty, right? Like no tag will have the name django and python at the same time.
I'm not sure it's the best recommendation, but my recommendation would be for you to directly query the through table here.
This is a bit of a tricky problem, though! Imagine doing this by hand. You could look at every object's tags (so one query per post to get tags), and that would be the easiest to code (but not super performant, right). But instead you could filter down to everything that has at least one of these tags, and then filter through that (though you're still going to need to do some math).
# get all the Post <-> tag associations that cover at least one tag
relevant_items = Post.tags.through.objects.filter(
   name__in=['django', 'python'],
   # only give me tags for Posts
   content_object_type=ContentType.objects.for_model(Post)
)
# at this point we can easily get all the posts that have _either_ django or python. But we want to know those that have both!
# If both tags are present, then the post will be present twice in relevant_items
# (here there are two terms so we only filter for 2, if there were 10 items you filter for 10, etc)
items_with_all_tags = relevant_items.annotate(count=Count('content_object_id')).filter(count=2)
posts = Post.objects.filter(id__in=items_with_all_tags.values_list("id", flat=True)

bit of a mouthful but this will work way better for your case.


Add Norwegian

Add Norwegian translation

Thanks for the pull request! Would you also consider adding translations to preferences files similar to https://github.com/p0deje/Maccy/tree/master/Maccy/Preferences/es.lproj?

Sure, I'll get right onto it!

Then I think all translations are done and ready to be reviewed.

I had to change XCode project to pick it up correctly (add use NB localization instead of NO) but it's merged in 0cd459f. Thank you!

My pleasure, and thank you for the correction.


stm32 flash fixes

Backport:stm32_flash changes from upsteam
PX4 contrib from<EMAIL_ADDRESS>

stm32: Fix erase sector number for microcontrolers with
more than 11 sectors
Erase a sector from the second bank cause the bit 4 of SNB being set
but never unsed, so trying to erase a sector from the first bank
was acually eraseing a sector from the second bank.

stm32: Make up_progmem thread safe

Writing to a flash sector while starting the erase of other sector
have a undefined behavior so lets add a [staticaly initalized]
semaphore and syncronize access to Flash registers.

Add workaround for flash data cache corruption on
read-while-write

This is a know hardware issue on some STM32 see the errata
of your model and if you make use of both memory banks you
should enable it.

Greg's cleanup

PX4 clean up

stm32_flash:Need conditional on non F4 targets

Fix UAVCAN bootloader builds broken by os calls from stm32_flash
Recent upsteam NuttX changes needed by PX4 added sem_[wait|post]
in the stm32_flash driver.
UAVCAN Bootloaders do not use the OS's scheduler etal.
This commit nops the sem_[wait|post] with linker magic.
Which precludes the linking the nuttx scheduler in the
bootloader build.

@zehortigoza - I hear you. I need the name to stay as it is. So I can manage the patch. It may have to be broken down later.  Into multiple pieces. We can revisit the naming.
The upstream stm32_flash file need some love. It suffers from ifdef rash.
Some enhancements would be:

SW detecting the bank mode on the CONFIG_STM32_STM32Fxxxx affected by the errata. (feature)

The change the Kconfig option to override the behavior and track the naming conventions a tad better i.e. CONFIG_STM32_FLASH_DISABLEDCACHEFLUSH so it is not so "use case" centric. (nit)

Fix all the ifdef rash. Nuttx stm32 as had a lot of organic growth.  The expedient solutions contributors tend to do creates coupling and add ifdefs. (I am guilty of it) That fixes/solves their F1 bug/issue and can break all F4's. There are some patterns in Nuttx to deal with this:  See how the stm32_clockconfig is done or others like how i2c drivers are chosen. There are coupling vs duplicate code maintenance trade offs. See Well in an idle world.... for a discussion. (difficult but valuable)

The bigger concern is stated here: https://github.com/PX4/NuttX/pull/89#issuecomment-289034697

@davids5

SW detecting the bank mode on the CONFIG_STM32_STM32Fxxxx affected by the errata. (feature)
Even if we detect enable it without use the second bank would only bring drawbacks, that is the case of recent pixhawks that do not use the seconds bank because of the other bug on the USB line.


Expiry per dataset

I think that we shouldn't merge these two PRs into a single one as they're a separate feature. Also reviewing a bigger change usually is more challenging.

I think that we shouldn't merge these two PRs into a single one as they're a separate feature. Also reviewing a bigger change usually is more challenging.

Why are you merging it against safe-block-deletion then?

To limit the amount of changes shown between the master and expiry-per-dataset. Once the safe-block-deleteion get's merged to master I would change the base branch of this PR to the master branch.

Conclusions after the in-person review with @emizzle @AuHau and @benbierens

typeddatastore.nim move it to nim-datastore and use it's own Iter plus add toAsyncIter conversion in codex
genericcoders.nim movet to a separate PR
asynciter.nim move to a sepearate PR
Try to change: autoencode -> encode and autodecode -> decode

One more comment, I think moving the closures to their own named functions does improve readability somewhat, but it is really marginal, so I'm either way on this and consider it more a matter of style that anything more substantive.


fix(module:select): usage public property in accessing other components

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: CI is down due to merge conflict.
What is the new behavior?
Fix the CI.
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

Changes Unknown when pulling 20c47252c0e1eda62655c4f762dba9070e5c11e7 on trotyl:hot-fix into ** on NG-ZORRO:master**.


[1/x] Title of test-pr-6

Summary
This is a PR to show the merge bot
Test Plan

Before
After

#merge


8 Core

A follow up from this https://github.com/pyscript/pyscript/pull/2196

OK, this was successful ... I don't need it though so I'll keep it as valid/performed test that demonstrated 8-cores always work in here too.


Reporters: Broken links fixed

Broken links fixed.
Also, I've shortened long code lines in the code snippets.
/cc @inikulin @VasilyStrelyaev

\r-

lgtm

fpr

lgtm

lgtm


Feature request: Organize storage accounts by resource group.

If a subscription has a large number of storage accounts it can be hard to peruse them. I think if they could be organized by Resource Group (within the tree structure), it would be helpful.

@craxal in 1.35 please add a setting for organizing resources by Resource Group, and then have the storage accounts producer and the app config producer respect that setting (disks already respects it).


Issue 1135: Associated constants

This PR will make will use associated constances instead of functions in 3 places:

diesel::query_builder::QueryId: const HAS_STATIC_QUERY_ID: bool instead of fn has_static_query_id() ->bool
diesel::query_source::Column: const NAME: &'static str instead of fn name() -> &'static str
diesel::types::FromSqlRow: const FIELDS_NEEDED: usize (with default) instead of fn fields_needed() -> usize { ... }

These are the three places specifically mentioned in https://github.com/diesel-rs/diesel/issues/1135.
I have one stylistic question: Currently the const WHATEVER line replaces the first line of fn whatever(). If the line with const WHATEVER followed a line like type SomeType, I took out the blank line above. Otherwise, I left the blank lines as is. Is that how we want the style to be?

It looks like the diesel_tests project failed to build on Windows for Postgres. I'm a bit surprised, since I would expect this change either to succeed or to fail everything everywhere.
I'm also surprised that this build: https://ci.appveyor.com/project/sgrif/diesel/build/1.0.1006 passed while this build: https://ci.appveyor.com/project/sgrif/diesel/build/1.0.1007 failed when the commit between them was this: https://github.com/diesel-rs/diesel/pull/1145/commits/c0bbc9f55263c95d514236c796e9c1965ab5f2f8 which has only a whitespace change.
I'll attempt to repro this myself, but honestly my Windows computer is not set up for development at all, so I could use a little bit of assistance. (Also, it might be worth investigating a pipeline issue, since apparently a whitespace-only commit broke a build.)

It looks like https://github.com/diesel-rs/diesel/pull/1146 is failing CI builds with the same error, but also failing them for Postgres on Linux, not just Windows.


swift error when issuing access token

I was trying to implement a Kakao login in my flutter app. It works fine until I get auth code from the Kakao app but when I tried to get the access token via auth code, the app [ios version] suddenly had a crash. Here is the error message I got when the crash happened:

kakao_flutter_sdk/Utility.swift:36: Fatal error: Unexpectedly found nil while unwrapping an Optional value

kakao_flutter_sdk  version:^0.7.0
my Info.plist file:
CFBundleURLSchemes

${my url scheme}

KAKAO_APP_KEY
my client id
LSApplicationQueriesSchemes

kakao${my client id}
kakaokompassauth
storykompassauth
kakaolink
kakaotalk-5.9.7

kakao login:
Future signInWithKakao() async {
final installed = await isKakaoTalkInstalled();
print(installed);
String credentials ="";
KakaoContext.clientId = ${my client id};
if (installed) {
  try {
    var code = await AuthCodeClient.instance.requestWithTalk();
     print("code $code");

     // the line where the crash happened
     var token = await AuthApi.instance.issueAccessToken(code);
     print("token $token");
     AccessTokenStore.instance.toStore(token);
     credentials = "access_token:${token.accessToken}";
     print("credentials=>>>>$credentials");
     return credentials;
   }

  on KakaoAuthException catch (e) {
    showToast("Unexpected error occured, please try again!");
    print(e);
    credentials = e.toString();
  } on KakaoClientException catch (e) {
    showToast("Unexpected error occured, please try again!");
    print(e);
    credentials = e.toString();
  }
} else {
  showToast("Kakao talk is not installed");
  credentials = "?";
}
return credentials;

}

Hi @ilyosbekibrohimov
What is your application id?
Application Id is the value found in the My Application menu of Kakao Developers.

Hello,
Thank you for your response!
My application ID is  591973
Thank you.
On Tue, Jul 27, 2021 at 4:09 PM 김민범 @.***> wrote:

Hi @ilyosbekibrohimov https://github.com/ilyosbekibrohimov
What is your application id?
Application Id is the value found in the My Application menu of Kakao
Developers https://developers.kakao.com.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kakao/kakao_flutter_sdk/issues/88#issuecomment-887268295,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALCMDPNPCUPA5VD4ZWPKEOTTZZLRNANCNFSM5BBF7FPA
.

I didn't know the exact cause just by the information you gave me.
Can you show me the log when the crash occurs in your app?
And if possible, I would appreciate it if you could let me know the device information that causes the issue, OS version, and whether it does not occur on other devices.
Additionally, UserApi.loginWithKakaoTalk is added from version 0.7, making it easier to implement logins. Please refer to README.


Adds authors support of blog

Closes #444
Adds author support for the blog posts. We were using "minima" default theme, so copied page.html from the theme repo and edited to support the author.

Authors list is defined in _data/authors.yml
If a post has author tag, post HTML will automatically add "Written By - Author Name"
Clicking Author name will redirect to web link which is defined in YML file
Added authors for all current posts

Sample Post:

ooommmgggg that's awesome! Looks great too!


Full Windows support, decreased network bandwitch usage and labels matched by reggex

Now the execution procedure differs between Unix and Win32 Operating Systems and performs each execution with the native shell.
Each slave has its own label installation cache.
Subversioning by hashing of any script changes between last cached and last configured.
Each predefined setup config are checked individually.
If the slave has installed last setup config version it will avoid following executions.
If slave fails in some setup, will not restart all previous executions.
Do not copy files if they were previously copied (using subversioning).
Labels are now matched as a unique label like last versions but now, included regex support.
A lot of code review, comments and JavaDoc updating

@atgiovannini thanks for the contribution, very appreciated, for both the long-awaited new feature and the housekeeping.
I will review and let you know asap - I'll try to make it by the end of this week if this works for you

Nice, I'm glad to hear that. I'll wait for merge.

Anything going on with this merge? I could really use this feature.
Thank you.

Hey, I missed the new commits fixing the CI.
Good to go!


CoalesceBatchesStream poll_next_inner function bug

Describe the bug
SQL: select * from table where col1 = 'datafusion' limit 10;
Some files are still being read after the result is returned。
Because：
https://github.com/apache/arrow-datafusion/blob/master/datafusion/src/physical_plan/coalesce_batches.rs
CoalesceBatchesStream poll_next_inner function has a loop logic, when sync table scan stream don't return Poll::Pending(eg. Parquet), when CoalesceBatchesStream's parent abort him, still can't quit loop, util table scan stream return Poll::Ready(None).
Also, spawn_execution function in common.rs has this problem.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
End stream when has sync table scan in a friendly way.
Additional context
Add any other context about the problem here.

I think this may have been fixed by https://github.com/apache/datafusion/pull/11652 from @ozankabak  and the synnada team to push limit into the CoalesceBatchesStream

I think so too 🚀

Closing this one -- please feel free to reopen it @JasonLi-cn  if you think it is still an issue


add mixin for creating grid wrap gutter width modifiers

A mixin will allow users to easily add modifiers that affect grid column widths without having to remember whether padding or margin should be negative

resolved by #34


UNMET PEER DEPENDENCY<EMAIL_ADDRESS>

Why am I getting this when trying to install react-chartjs on a fresh install of create-react-app?
package.json looks like this:
`{
"name": "charts",
"version": "0.1.0",
"private": true,
"devDependencies": {
"react-scripts": "1.0.14"

},
"dependencies": {
"react": "^16.0.0",

"react-chartjs": "^0.8.0",

"react-dom": "^16.0.0"

},
"scripts": {
"start": "react-scripts start",

"build": "react-scripts build",

"test": "react-scripts test --env=jsdom",

"eject": "react-scripts eject"

}
}
`

I think that this library does not support the new update 16 of React, you can see my thread about it, it might be useful: https://github.com/reactjs/react-chartjs/issues/195


List index out of range with program counter

Traceback (most recent call last):
  File "/usr/local/bin/myth", line 4, in <module>
    __import__('pkg_resources').run_script('mythril==0.8.17', 'myth')
  File "/usr/local/lib/python3.6/site-packages/pkg_resources/__init__.py", line 748, in run_script
    self.require(requires)[0].run_script(script_name, ns)
  File "/usr/local/lib/python3.6/site-packages/pkg_resources/__init__.py", line 1517, in run_script
    exec(code, namespace, namespace)
  File "/usr/local/lib/python3.6/site-packages/mythril-0.8.17-py3.6.egg/EGG-INFO/scripts/myth", line 236, in <module>
    states = StateSpace(contracts, simplified=False)
  File "/usr/local/lib/python3.6/site-packages/mythril-0.8.17-py3.6.egg/mythril/analysis/symbolic.py", line 25, in __init__
    self.svm.sym_exec(contracts[0].address)
  File "/usr/local/lib/python3.6/site-packages/laser/ethereum/svm.py", line 183, in sym_exec
    node = self._sym_exec(context, State())
  File "/usr/local/lib/python3.6/site-packages/laser/ethereum/svm.py", line 196, in _sym_exec
    start_addr = disassembly.instruction_list[state.pc]['address']
IndexError: list index out of range

The program counter is pointing to an inexistent instruction index.
The contract being analyzed was compiled with an old version of the compiler which probably used a jump to an invalid location (inexistent code) to stop execution instead of using an invalid opcode.

This is most likely fixed.


HelperClient keeps request threads around forever

Please forgive me if I'm not understanding the intended control flow properly, but it seems as though there's a bug in the way HelperClient.send_request handles a specified callback: a new thread is started EVERY time this function is called.  So if I make multiple requests with associated callbacks, they will stack up and wait on the Queue.  When the client is closed, they sometimes hang around afterwards because only one 'None' is pushed into the Queue; hence the other threads will block on Queue.get().  Although I haven't tested it, this design also seems to me that it could lead to the wrong callback being fired if we issue multiple requests each with a different callback since they wait in order for responses (i.e. the new thread-callback-request is sent but the old one receives the response).

I have just been grappling with this and can confirm what you've seen.
Additionally, I have also seen in practice wrong callbacks firing, and the wrong response going back to a synchronous caller due to asynchronous OBSERVE responses coming back and being misinterpreted as being for an outstanding request.


Nucleus and ViewPager

Hello!
I was wondering, how and will Nucleus work when used with ViewPager that holds fragments of the same kind. Since there will be several instances of similar Presenters in Presenter Storage, how we ensure that restored fragments get appropriate presenters and states?

Hi, when instantiated each presenter gets an UUID and during view restoration a corresponding presenter will be found using its UUID that was saved inside View's bundle.

Thank you very much! It's clear now (:


degression: breaking output change for cloudwatch log subscription filters

commit 5e84b447d1d1a24b10eafb496eb5d2989ac97f8a introduced a change in output format: lambda will not add timestamp and request id prefix anymore.
this leads to cloudwatch log subscription filters fail, because the pattern for lambda functions does not match anymore. and this leads in my case to empty dashboard because the subscription filter is not triggered anymore.
expected output (as of 2.0.0): TIMESTAMD REQUEST-ID JSON
output 2.0.1: JSON
Filterpattern in cloudwatch subscription: Filter pattern: [timestamp=*Z, request_id="*-*", event]
i downgraded to 2.0.0 for now. But since this is lambda-log i actually care about those fields (by default).. how can i fix it in the future?
i would be happy to have the lambda prefixes by default - but thats just me ;)
thanks

@mariux A quick fix for this is to override the custom Console instance:
const log = require('lambda-log');

// override the console instance with global console
log.console = console;

I'm working on the changes and will hopefully have a new version pushed out in the next day or so.

Fixed in version 2.1.0. This release has been published to NPM. Please let me know if you are still facing issues after upgrading.
Thanks for reporting!

@all-contributors please add @mariux for bug


Number of Selected Feature

Hi there,
Is it possible to specify the number of selected features? Otherwise, the algorithm tests all features, alone?
Thank you.

It is not possible to specify the number of features in this algorithm. To do that, you need to refer to research articles and make modifications to the algorithm structure.


Added a select input for multiple select form component

Overview
Reference here. This PR adds a write-in box for the multi-select option when 'Other' is selected.

What happens in the post request?

Fixed, thanks!

This isnt saving anything in the API therefore updating the state of the user after saving. Please make sure it is saving the data.


Fixed-height container for the branded-navbar at 50px

Purpose
Prevent branded-navbar overflow
Summary of Changes
Add height of 50px to the container div
Side Effects

Feature Flags

QA Notes

Ticket
None
Reviewer Checklist

[ ] meets requirements
[ ] easy to understand
[ ] DRY
[ ] testable and includes test(s)
[ ] changes described in CHANGELOG.md

Pull Request Test Coverage Report for Build 1705

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 62.631%

Totals

Change from base Build 1702:
0.0%

Covered Lines:
3596

Relevant Lines:
5473

💛  - Coveralls


Got an Error when you scroll fast

Error with task : null is not an object (evaluating 'this.rowRefs[e].ref.setVisibility')
Undefined is not an object (evaluating 'this.viewProperties.width')

dupe https://github.com/stoffern/react-native-optimized-flatlist/issues/1


Failing eslint does not always fail the build

In reviewing #478, I ran into a failure in eslint when running the PR locally. The CI build for the PR succeeded, however viewing the build details shows the same lint error but exited 0.
I'm also not sure why the build exited 0 when locally npm test on the same PR exits 1.
@humphd is this intended?

I reran that build, and it failed as expected.  I guess this is an intermittent bug in Travis?  Very odd
https://travis-ci.org/filerjs/filer/builds/432510814

Definitely seems like an intermittent Travis issue. Closing for now since the issue wasn't repeatable on the same branch and is likely an infrastructure problem.


Adapt for the mangling prefix change ($S -> $s)

Please test with following pull request:
https://github.com/apple/swift/pull/19388
@swift-ci smoke test Linux platform

Please test with following pull request:
https://github.com/apple/swift/pull/19388
@swift-ci test Linux platform

Can you test this manually on macOS to make sure we don't break our developers there? The CI doesn't do it.

Last time this mangling changed it really messed us up for a while since everyone had to have ToT tools installed.

@parkera What test should I run?

You can run all the unit tests (I hope) on macOS using the Xcode workspace.

I assume in order for this to work you need to install a toolchain based on your compiler PR?

yeah, this change has to be in sync with the compiler mangling change

OK, I did run the tests locally by setting SWIFT_EXEC and SWIFT_LIBRARY_PATH to my ToT compiler build.
I worked around one compiler error and got 12 failures in TestNSNumberBridging, which seem to be unrelated to the mangling change.
How can we proceed with that?

I know we need to do this, but is there any way we can detect which version of the compiler we're building with to continue to support shipped tools?
Not to overstate it, but it introduces a barrier to contributions which is difficult for some people to get past.

What you can do is to add a pre-build configuration step. For example:
echo '#define __CFConstantStringClassReference' swift-demangle --remangle-new '$S15SwiftFoundation19_NSCFConstantStringCN' > config.h
using the swift-demangle from the toolchain. And then include config.h in CFInternal.h
Or maybe you can just define a build setting outside the Xcode project and then conditionally compile the macro definition in CFInternal.h. A little bit more manual, but simpler.

@parkera I added a workaround which enables to compile with both compiler versions (old and new mangling prefix)

Please test with following pull request:
https://github.com/apple/swift/pull/19388
@swift-ci smoke test Linux platform

Please test with following pull request:
https://github.com/apple/swift/pull/19388
@swift-ci smoke test Linux platform

Please test with following pull request:
https://github.com/apple/swift/pull/19388
@swift-ci smoke test Linux platform

Please test with following pull request:
https://github.com/apple/swift/pull/19388
@swift-ci test Linux platform

Please test with following pull request:
https://github.com/apple/swift/pull/19388
@swift-ci test Linux platform

Please test with following pull request:
https://github.com/apple/swift/pull/19388
@swift-ci test Linux platform

Please test with following pull request:
https://github.com/apple/swift/pull/19388
@swift-ci clean test Linux platform

Please test with following pull request:
https://github.com/apple/swift/pull/19388
@swift-ci clean test Linux platform

Please test with following pull request:
https://github.com/apple/swift/pull/19388
@swift-ci clean test Linux platform

Please test with following pull request:
https://github.com/apple/swift/pull/19388
@swift-ci test Linux platform

Please test with following pull request:
https://github.com/apple/swift/pull/19388
@swift-ci test Linux platform


Unable to use 'lm_head' in target_modules

model = FastLanguageModel.get_peft_model(
model,
r = 16, # Choose any number > 0 ! Suggested 8, 16, 32, 64, 128
target_modules = ["q_proj", "k_proj", "v_proj", "o_proj",
"gate_proj", "up_proj", "down_proj","lm_head",],
lora_alpha = 32,
lora_dropout = 0, # Supports any, but = 0 is optimized
bias = "none",    # Supports any, but = "none" is optimized
use_gradient_checkpointing = True,
random_state = 3407,
use_rslora = False,  # We support rank stabilized LoRA
loftq_config = None, # And LoftQ
)
When I try to add lm_head in target modules, I get an Assertion Error. It points to some backend code where something like accepted_modules is mentioned. I'm not sure if this was the exact word (Sorry I'm locked out of my aws currently, would've posted the entire error otherwise).
Has anyone encountered this error before? I tried using the normal .get_peft_model instead of the FastLanguageModel. However, that triggered some error during fine-tuning regarding some shape mismatch.

Thanks for the report - will look into this!

@Abhinav2k61 Apologies on the delay, I think you're looking for
modules_to_save = ["lm_head", "embed_tokens",`]

which will turn on finetuning of the lm_head and embed_tokens for example


[Bug] Button for notification does not work for both 3CP and Marketplace

Notification not working (as per PRD, notification needs to work)

Notification Service
Admin/3CP - notification has not been picked since the start @karntrehan @aman1esmagico

Notification Service: Will be needing notification service API's to integrate


Loss nan

Thanks for the great reproduction! I got the nan loss about half of the total number of epoch. Have you met this before?

Epoch: [127/300]
2020-08-17 21:48:47,912: logger.py - info(), at Line 49:INFO:
Train - Epoch: [127/300][ 35/464]	Time  0.738 ( 0.738)	Data  0.000 ( 0.014)	Loss 2.1274e+00 (1.5406e+00)
2020-08-17 21:49:24,172: logger.py - info(), at Line 49:INFO:
Train - Epoch: [127/300][ 85/464]	Time  0.730 ( 0.730)	Data  0.000 ( 0.006)	Loss 1.2996e+00 (1.5485e+00)
2020-08-17 21:50:00,407: logger.py - info(), at Line 49:INFO:
Train - Epoch: [127/300][135/464]	Time  0.750 ( 0.728)	Data  0.000 ( 0.004)	Loss 2.1689e+00 (1.5462e+00)
2020-08-17 21:50:36,613: logger.py - info(), at Line 49:INFO:
Train - Epoch: [127/300][185/464]	Time  0.727 ( 0.727)	Data  0.000 ( 0.003)	Loss 1.5142e+00 (1.5394e+00)
2020-08-17 21:51:12,840: logger.py - info(), at Line 49:INFO:
Train - Epoch: [127/300][235/464]	Time  0.732 ( 0.727)	Data  0.000 ( 0.002)	Loss 1.5060e+00 (1.5328e+00)
2020-08-17 21:51:49,090: logger.py - info(), at Line 49:INFO:
Train - Epoch: [127/300][285/464]	Time  0.723 ( 0.726)	Data  0.000 ( 0.002)	Loss 1.4645e+00 (1.5327e+00)
2020-08-17 21:52:25,279: logger.py - info(), at Line 49:INFO:
Train - Epoch: [127/300][335/464]	Time  0.731 ( 0.726)	Data  0.000 ( 0.002)	Loss 1.5955e+00 (1.5390e+00)
2020-08-17 21:53:01,426: logger.py - info(), at Line 49:INFO:
Train - Epoch: [127/300][385/464]	Time  0.732 ( 0.726)	Data  0.000 ( 0.002)	Loss 1.5102e+00 (1.5416e+00)
2020-08-17 21:53:37,567: logger.py - info(), at Line 49:INFO:
Train - Epoch: [127/300][435/464]	Time  0.725 ( 0.725)	Data  0.000 ( 0.001)	Loss 1.6077e+00 (1.5410e+00)
2020-08-17 21:53:57,834: logger.py - info(), at Line 49:INFO:
----------------------------------------
2020-08-17 21:53:57,834: logger.py - info(), at Line 49:INFO:
=================================== 128/300 ===================================
2020-08-17 21:53:57,834: logger.py - info(), at Line 49:INFO:
----------------------------------------
2020-08-17 21:53:57,834: logger.py - info(), at Line 49:INFO:
Epoch: [128/300]
2020-08-17 21:54:14,399: logger.py - info(), at Line 49:INFO:
Train - Epoch: [128/300][ 21/464]	Time  0.730 ( 0.753)	Data  0.000 ( 0.031)	Loss 1.5503e+00 (1.5762e+00)
2020-08-17 21:54:50,617: logger.py - info(), at Line 49:INFO:
Train - Epoch: [128/300][ 71/464]	Time  0.734 ( 0.733)	Data  0.000 ( 0.010)	Loss 1.6927e+00 (1.5937e+00)
2020-08-17 21:55:26,919: logger.py - info(), at Line 49:INFO:
Train - Epoch: [128/300][121/464]	Time  0.737 ( 0.730)	Data  0.000 ( 0.006)	Loss 1.4969e+00 (1.5841e+00)
2020-08-17 21:56:03,156: logger.py - info(), at Line 49:INFO:
Train - Epoch: [128/300][171/464]	Time  0.736 ( 0.729)	Data  0.000 ( 0.004)	Loss 1.6823e+00 (1.5828e+00)
2020-08-17 21:56:39,368: logger.py - info(), at Line 49:INFO:
Train - Epoch: [128/300][221/464]	Time  0.728 ( 0.728)	Data  0.000 ( 0.003)	Loss 1.4616e+00 (1.5912e+00)
2020-08-17 21:57:15,445: logger.py - info(), at Line 49:INFO:
Train - Epoch: [128/300][271/464]	Time  0.725 ( 0.726)	Data  0.000 ( 0.003)	Loss nan (nan)
2020-08-17 21:57:51,119: logger.py - info(), at Line 49:INFO:
Train - Epoch: [128/300][321/464]	Time  0.711 ( 0.724)	Data  0.000 ( 0.002)	Loss nan (nan)
2020-08-17 21:58:26,710: logger.py - info(), at Line 49:INFO:
Train - Epoch: [128/300][371/464]	Time  0.725 ( 0.723)	Data  0.000 ( 0.002)	Loss nan (nan)
2020-08-17 21:59:02,274: logger.py - info(), at Line 49:INFO:
Train - Epoch: [128/300][421/464]	Time  0.711 ( 0.721)	Data  0.000 ( 0.002)	Loss nan (nan)
2020-08-17 21:59:32,180: logger.py - info(), at Line 49:INFO:
----------------------------------------
2020-08-17 21:59:32,180: logger.py - info(), at Line 49:INFO:
=================================== 129/300 ===================================
2020-08-17 21:59:32,180: logger.py - info(), at Line 49:INFO:
----------------------------------------
2020-08-17 21:59:32,180: logger.py - info(), at Line 49:INFO:
Epoch: [129/300]
2020-08-17 21:59:38,533: logger.py - info(), at Line 49:INFO:
Train - Epoch: [129/300][  7/464]	Time  0.731 ( 0.794)	Data  0.000 ( 0.088)	Loss nan (nan)
2020-08-17 22:00:14,077: logger.py - info(), at Line 49:INFO:
Train - Epoch: [129/300][ 57/464]	Time  0.715 ( 0.722)	Data  0.000 ( 0.012)	Loss nan (nan)
2020-08-17 22:00:49,770: logger.py - info(), at Line 49:INFO:
Train - Epoch: [129/300][107/464]	Time  0.706 ( 0.718)	Data  0.000 ( 0.007)	Loss nan (nan)
2020-08-17 22:01:25,436: logger.py - info(), at Line 49:INFO:
Train - Epoch: [129/300][157/464]	Time  0.726 ( 0.717)	Data  0.000 ( 0.005)	Loss nan (nan)
2020-08-17 22:02:01,175: logger.py - info(), at Line 49:INFO:
Train - Epoch: [129/300][207/464]	Time  0.726 ( 0.716)	Data  0.000 ( 0.004)	Loss nan (nan)
2020-08-17 22:02:36,896: logger.py - info(), at Line 49:INFO:
Train - Epoch: [129/300][257/464]	Time  0.716 ( 0.716)	Data  0.000 ( 0.003)	Loss nan (nan)
2020-08-17 22:03:12,634: logger.py - info(), at Line 49:INFO:
Train - Epoch: [129/300][307/464]	Time  0.717 ( 0.716)	Data  0.000 ( 0.003)	Loss nan (nan)
2020-08-17 22:03:48,380: logger.py - info(), at Line 49:INFO:
Train - Epoch: [129/300][357/464]	Time  0.725 ( 0.716)	Data  0.000 ( 0.002)	Loss nan (nan)
2020-08-17 22:04:24,092: logger.py - info(), at Line 49:INFO:
Train - Epoch: [129/300][407/464]	Time  0.719 ( 0.715)	Data  0.000 ( 0.002)	Loss nan (nan)
2020-08-17 22:04:59,779: logger.py - info(), at Line 49:INFO:
Train - Epoch: [129/300][457/464]	Time  0.691 ( 0.715)	Data  0.000 ( 0.002)	Loss nan (nan)
2020-08-17 22:05:04,096: logger.py - info(), at Line 49:INFO:

Hi @lidehuihxjz
Thanks for reporting the bug. I have already fixed it, but I forgot to update the code to here. I'll update it soon.
The bug stems from the sigmoid function. We need to clamp the sigmoid output before computing losses.

Thanks for the reply, but I also got the error of LOSS NAN with the updated code.

Hi @lidehuihxjz

Thanks for the reply, but I also got the error of LOSS NAN with the updated code.

I ran experiments without a loss NaN. You can check the tensorboard to know what's the NaN component in losses. Please make sure that you are running the latest code.


Fix initialization of optimizers in DDP Strategy

What does this PR do?
Redo of #11886
also fixes: #12317

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you list all the breaking changes introduced by this pull request?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

hey @ananthsub!
is this blocked on something or ready to go?

assigned myself. Will complete this soon.

Any updates on this PR?


EnableMasterSSL with graceful-master-takeover-auto errors

On orchestrator 3.2.3, doing a graceful-master-takeover-auto when AllowTLS is set for the instance will throw an error that replication couldn't be started because the replication threads are already running:
$ orchestrator-client -c topology -a $(orchestrator-client -c clusters)
mysql1:3306   [0s,ok,5.7.32-log,rw,ROW,>>,GTID]
+ mysql2:3306 [0s,ok,5.7.32-log,ro,ROW,>>,GTID]
+ mysql3:3306 [0s,ok,5.7.32-log,ro,ROW,>>,GTID]

$ orchestrator-client -c graceful-master-takeover-auto -i mysql1 -d mysql2
EnableMasterSSL: Cannot enable SSL replication on mysql1:3306 because replication threads are not stopped
{ "Id": 1, "UID": "1607638055531065398:a0a3933a4dd565b60e3becf7cd4c1b6b27060e69c59a862a4b06e0ebcec5f744", "AnalysisEntry": { "AnalyzedInstanceKey": { "Hostname": "mysql1", "Port": 3306 }, "AnalyzedInstanceMasterKey": { "Hostname": "", "Port": 0 }, "ClusterDetails": { "ClusterName": "mysql1:3306", "ClusterAlias": "mysql1:3306", "ClusterDomain": "", "CountInstances": 3, "HeuristicLag": 0, "HasAutomatedMasterRecovery": true, "HasAutomatedIntermediateMasterRecovery": true }, "AnalyzedInstanceDataCenter": "", "AnalyzedInstanceRegion": "", "AnalyzedInstancePhysicalEnvironment": "", "AnalyzedInstanceBinlogCoordinates": { "LogFile": "8141a32e30e9-bin.000003", "LogPos": 644, "Type": 0 }, "IsMaster": true, "IsReplicationGroupMember": false, "IsCoMaster": false, "LastCheckValid": true, "LastCheckPartialSuccess": true, "CountReplicas": 1, "CountValidReplicas": 1, "CountValidReplicatingReplicas": 1, "CountReplicasFailingToConnectToMaster": 0, "CountDowntimedReplicas": 0, "ReplicationDepth": 0, "Replicas": [ { "Hostname": "mysql2", "Port": 3306 } ], "SlaveHosts": [ { "Hostname": "mysql2", "Port": 3306 } ], "IsFailingToConnectToMaster": false, "Analysis": "DeadMaster", "Description": "", "StructureAnalysis": null, "IsDowntimed": false, "IsReplicasDowntimed": false, "DowntimeEndTimestamp": "", "DowntimeRemainingSeconds": 0, "IsBinlogServer": false, "PseudoGTIDImmediateTopology": false, "OracleGTIDImmediateTopology": true, "MariaDBGTIDImmediateTopology": false, "BinlogServerImmediateTopology": false, "SemiSyncMasterEnabled": false, "SemiSyncMasterStatus": false, "SemiSyncMasterWaitForReplicaCount": 0, "SemiSyncMasterClients": 0, "CountSemiSyncReplicasEnabled": 0, "CountLoggingReplicas": 1, "CountStatementBasedLoggingReplicas": 0, "CountMixedBasedLoggingReplicas": 0, "CountRowBasedLoggingReplicas": 1, "CountDistinctMajorVersionsLoggingReplicas": 1, "CountDelayedReplicas": 0, "CountLaggingReplicas": 0, "IsActionableRecovery": true, "ProcessingNodeHostname": "6235160f51df", "ProcessingNodeToken": "690e32e28307d9520449c66844e0003960815b84d5eddc64bdb811fcf14e2f06", "CountAdditionalAgreeingNodes": 0, "StartActivePeriod": "", "SkippableDueToDowntime": false, "GTIDMode": "ON", "MinReplicaGTIDMode": "ON", "MaxReplicaGTIDMode": "ON", "MaxReplicaGTIDErrant": "", "CommandHint": "graceful-master-takeover", "IsReadOnly": false }, "SuccessorKey": { "Hostname": "mysql2", "Port": 3306 }, "SuccessorAlias": "", "IsActive": false, "IsSuccessful": true, "LostReplicas": [], "ParticipatingInstanceKeys": [], "AllErrors": [], "RecoveryStartTimestamp": "", "RecoveryEndTimestamp": "", "ProcessingNodeHostname": "", "ProcessingNodeToken": "", "Acknowledged": false, "AcknowledgedAt": "", "AcknowledgedBy": "", "AcknowledgedComment": "", "LastDetectionId": 0, "RelatedRecoveryId": 0, "Type": "MasterRecovery", "RecoveryType": "MasterRecoveryGTID" }

$ orchestrator-client -c topology -a $(orchestrator-client -c clusters)
mysql2:3306   [0s,ok,5.7.32-log,rw,ROW,>>,GTID]
+ mysql1:3306 [0s,ok,5.7.32-log,ro,ROW,>>,GTID]
+ mysql3:3306 [0s,ok,5.7.32-log,ro,ROW,>>,GTID]

Here are the relevant logs:
2020-12-10 22:07:36 DEBUG orchestrator/raft: applying command 62: write-recovery-step
2020-12-10 22:07:36 DEBUG PostponedFunctionsContainer: waiting on 1 postponed functions
2020-12-10 22:07:36 DEBUG PostponedFunctionsContainer: done waiting
2020-12-10 22:07:36 INFO topology_recovery: Executed 1 postponed functions
2020-12-10 22:07:36 DEBUG orchestrator/raft: applying command 63: write-recovery-step
2020-12-10 22:07:36 INFO topology_recovery: Executed postponed functions: regroup-replicas-gtid mysql2:3306
2020-12-10 22:07:36 DEBUG orchestrator/raft: applying command 64: write-recovery-step
2020-12-10 22:07:36 DEBUG ChangeMasterTo: will attempt changing master on mysql1:3306 to mysql2:3306, b83336727d97-bin.000001:3075084
2020-12-10 22:07:36 INFO ChangeMasterTo: Changed master on mysql1:3306 to: mysql2:3306, b83336727d97-bin.000001:3075084. GTID: true
2020-12-10 22:07:36 DEBUG ChangeMasterTo: will attempt changing master credentials on mysql1:3306
2020-12-10 22:07:36 INFO ChangeMasterTo: Changed master credentials on mysql1:3306
2020-12-10 22:07:36 INFO Started replication on mysql1:3306
2020-12-10 22:07:36 INFO topology_recovery: No PostGracefulTakeoverProcesses hooks to run
2020-12-10 22:07:36 DEBUG orchestrator/raft: applying command 65: write-recovery-step
[martini] Completed 500 Internal Server Error in 845.505737ms

It seems Replication is started and then another command is run that errors at 500 (the enableMasterSSL I'm pretty sure). I traced it to these lines.
In my case, replication was successfully started anyway because I did not require SSL, but in environments where replication requires SSL I think it would fail.
Is it intentional that the enableMasterSSL call comes after the 'auto' block?

Thank you for the report and for the PR! This makes perfect sense. I recall the code for enabling SSL was recently contributed and I didn't validate it well enough.


[BACKPORT][v1.5.5][IMPROVEMENT] Improve logging in CSI plugin when mount fails.

backport https://github.com/longhorn/longhorn/issues/7931
Specifically, the improvement to CSI host namespace and CSI logging of environment when mount fails.

Created this backport issue manually, since part of the previous work on the environment script was already backported.

Hi @james-munson ,
I can reproduce the RWX pod mount fail on Ubuntu 5.15.0-94-generic, the RWX pod failed to mount, but the messeage Failed to mount volume %v on node %s with kernel release you added in PR can not be found. Could you take a look on this? thank you.
> uname -r
5.15.0-94-generic
>
> k get volume -A
NAMESPACE         NAME                                       STATE      ROBUSTNESS   SCHEDULED   SIZE         NODE   AGE
longhorn-system   pvc-d5ca45f2-7d92-429b-b7bd-14b084c2d48b   attached   healthy<PHONE_NUMBER>   cha    117s
>
> k -n longhorn-system get volume pvc-d5ca45f2-7d92-429b-b7bd-14b084c2d48b -o yaml | grep accessMode
  accessMode: rwx
>
> k get pods
NAME                                READY   STATUS              RESTARTS   AGE
longhorn-nfs-installation-t7pfk     1/1     Running             0          4m47s
longhorn-iscsi-installation-m7jb4   1/1     Running             0          4m47s
test-deployment-754dd9fc66-68qsp    0/1     ContainerCreating   0          2m20s
>
> k describe pod test-deployment-754dd9fc66-68qsp | grep Event -A 20
Events:
  Type     Reason                  Age                 From                     Message
  ----     ------                  ----                ----                     -------
  Warning  FailedScheduling        2m37s               default-scheduler        0/1 nodes are available: pod has unbound immediate PersistentVolumeClaims. preemption: 0/1 nodes are available: 1 Preemption is not helpful for scheduling.
  Warning  FailedScheduling        2m35s               default-scheduler        0/1 nodes are available: pod has unbound immediate PersistentVolumeClaims. preemption: 0/1 nodes are available: 1 Preemption is not helpful for scheduling.
  Normal   Scheduled               2m33s               default-scheduler        Successfully assigned default/test-deployment-754dd9fc66-68qsp to cha
  Normal   SuccessfulAttachVolume  2m17s               attachdetach-controller  AttachVolume.Attach succeeded for volume "pvc-d5ca45f2-7d92-429b-b7bd-14b084c2d48b"
  Warning  FailedMount             8s (x9 over 2m17s)  kubelet                  MountVolume.MountDevice failed for volume "pvc-d5ca45f2-7d92-429b-b7bd-14b084c2d48b" : rpc error: code = Internal desc = mount failed: exit status 32
Mounting command: /usr/local/sbin/nsmounter
Mounting arguments: mount -t nfs -o vers=4.1,noresvport,timeo=600,retrans=5,softerr <IP_ADDRESS>:/pvc-d5ca45f2-7d92-429b-b7bd-14b084c2d48b /var/lib/kubelet/plugins/kubernetes.io/csi/driver.longhorn.io/6381505fa73cc1887c25ca8b3079326a4843af3ac8af2f500e818253fefc3afb/globalmount
Output: mount.nfs: Protocol not supported

supportbundle_5e584417-1cc9-44ad-8d2f-6c8c3661f36f_2024-04-02T02-19-38Z.zip
In addition. use kernel 5.15.0-101-generic can make RWX pod mount success.

I think I see the problem.

This is strange.  I'm having a hard time inducing the failure.  I installed my test build of longhorn-manager for both daemonsets (longhorn-manager and longhorn-csi-plugin), changed the kernel on one of my Ubuntu 22.04 worker nodes to 5.15.0-94-generic, and made a new RWX deployment.  The pods all mounted successfully, including the one with the problematic kernel.
On that node,
 uname -a
Linux jbm-u22-pool2-ca5a5aa4-5fcq7 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
root@jbm-u22-pool2-ca5a5aa4-5fcq7:~# mount -l | grep nfs
<IP_ADDRESS>:/pvc-8787aa8f-8496-47b6-8bee-d49a27e68356 on /var/lib/kubelet/plugins/kubernetes.io/csi/driver.longhorn.io/8d63416da5e7a35390a0bb4456ec55a10c6dbb3ce0a42b3eab6c9fa221481328/globalmount type nfs4 (rw,relatime,vers=4.1,rsize=1048576,wsize=1048576,namlen=255,softerr,softreval,noresvport,proto=tcp,timeo=600,retrans=5,sec=sys,clientaddr=<IP_ADDRESS>,local_lock=none,addr=<IP_ADDRESS>)
<IP_ADDRESS>:/pvc-8787aa8f-8496-47b6-8bee-d49a27e68356 on /var/lib/kubelet/pods/c0ad2c30-c146-4bce-ba95-f9af4176547f/volumes/kubernetes.io~csi/pvc-8787aa8f-8496-47b6-8bee-d49a27e68356/mount type nfs4 (rw,relatime,vers=4.1,rsize=1048576,wsize=1048576,namlen=255,softerr,softreval,noresvport,proto=tcp,timeo=600,retrans=5,sec=sys,clientaddr=<IP_ADDRESS>,local_lock=none,addr=<IP_ADDRESS>)

The pod events:
k describe pod rwx-test-79dc5564d4-x6gzj | grep Event -A 20
Events:
  Type     Reason                  Age   From                     Message
  ----     ------                  ----  ----                     -------
  Warning  FailedScheduling        22m   default-scheduler        0/4 nodes are available: pod has unbound immediate PersistentVolumeClaims. preemption: 0/4 nodes are available: 4 Preemption is not helpful for scheduling..
  Warning  FailedScheduling        22m   default-scheduler        0/4 nodes are available: pod has unbound immediate PersistentVolumeClaims. preemption: 0/4 nodes are available: 4 Preemption is not helpful for scheduling..
  Normal   Scheduled               22m   default-scheduler        Successfully assigned default/rwx-test-79dc5564d4-x6gzj to jbm-u22-pool2-ca5a5aa4-5fcq7
  Normal   SuccessfulAttachVolume  22m   attachdetach-controller  AttachVolume.Attach succeeded for volume "pvc-8787aa8f-8496-47b6-8bee-d49a27e68356"
  Normal   Pulled                  22m   kubelet                  Container image "ubuntu:xenial" already present on machine
  Normal   Created                 22m   kubelet                  Created container rwx-test
  Normal   Started                 22m   kubelet                  Started container rwx-test
  Normal   Pulled                  22m   kubelet                  Container image "nginx:stable" already present on machine
  Normal   Created                 22m   kubelet                  Created container nginx
  Normal   Started                 22m   kubelet                  Started container nginx

And in the pod, the mount looks perfectly happy.
 uname -a
Linux jbm-u22-pool2-ca5a5aa4-5fcq7 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
root@jbm-u22-pool2-ca5a5aa4-5fcq7:~# mount -l | grep nfs
<IP_ADDRESS>:/pvc-8787aa8f-8496-47b6-8bee-d49a27e68356 on /var/lib/kubelet/plugins/kubernetes.io/csi/driver.longhorn.io/8d63416da5e7a35390a0bb4456ec55a10c6dbb3ce0a42b3eab6c9fa221481328/globalmount type nfs4 (rw,relatime,vers=4.1,rsize=1048576,wsize=1048576,namlen=255,softerr,softreval,noresvport,proto=tcp,timeo=600,retrans=5,sec=sys,clientaddr=<IP_ADDRESS>,local_lock=none,addr=<IP_ADDRESS>)
<IP_ADDRESS>:/pvc-8787aa8f-8496-47b6-8bee-d49a27e68356 on /var/lib/kubelet/pods/c0ad2c30-c146-4bce-ba95-f9af4176547f/volumes/kubernetes.io~csi/pvc-8787aa8f-8496-47b6-8bee-d49a27e68356/mount type nfs4 (rw,relatime,vers=4.1,rsize=1048576,wsize=1048576,namlen=255,softerr,softreval,noresvport,proto=tcp,timeo=600,retrans=5,sec=sys,clientaddr=<IP_ADDRESS>,local_lock=none,addr=<IP_ADDRESS>)

I'm not sure what's going on.

Repeated the test with 5.15.0-97-generic which is also in the broken range of Ubuntu kernels, and got the same result.  Mount did not fail.

@james-munson Is it reproducible if you use Longhorn 1.6.0 instead?

Actually, that was with 1.6.0 for everything but my custom longhorn-manager and csi-plugin.  Perhaps I'll give it a try with a 1.5.x release.  Or compare test procedure with @chriscchien.

So, since I can't repro the kernel-based Protocol not supported error, I tested using a different mount failure, but still exercising the code path that was missed.  The logging from CSI-plugin is as hoped:
[longhorn-csi-plugin-k46f6 longhorn-csi-plugin] E0406 18:18:12.533095    5056 mount_linux.go:230] Mount failed: exit status 32
[longhorn-csi-plugin-k46f6 longhorn-csi-plugin] time="2024-04-06T18:18:12Z" level=warning msg="Failed to mount volume pvc-fdf504c7-1616-4309-a5b1-25365d74d02e on node jbm-u22-pool2-ca5a5aa4-5fcq7 with kernel release 5.15.0-94-generic, os distro ubuntu" func="csi.(*NodeServer).nodeStageSharedVolume" file="node_server.go:295" component=csi-node-server error="mount failed: exit status 32\nMounting command: /usr/local/sbin/nsmounter\nMounting arguments: mount -t nfs -o rw,vers=4.1,bunny,softerr,timeo=600,retrans=5,noresvport <IP_ADDRESS>:/pvc-fdf504c7-1616-4309-a5b1-25365d74d02e /var/lib/kubelet/plugins/kubernetes.io/csi/driver.longhorn.io/e61d4e8525a632f675b44d7b8ba3704bd179e4e6ae7dbbe5ba811af540ebfa86/globalmount\nOutput: mount.nfs: an incorrect mount option was specified\n" function=nodeStageSharedVolume

In particular,

msg="Failed to mount volume pvc-fdf504c7-1616-4309-a5b1-25365d74d02e on node jbm-u22-pool2-ca5a5aa4-5fcq7 with kernel release 5.15.0-94-generic, os distro ubuntu"

With https://github.com/longhorn/longhorn-manager/pull/2724 committed, this should be testable again.

Verified pass on longhorn v1.5.x (longhorn-manager b160f0)
Deploy Longhorn v1.5.x on Ubuntu 5.15.0-94-generic which RWX volume can not mount success(ref), create and attach a RWX volume, in the longhorn-csi-plugin.log we can find related kernel information as below:
2024-04-09T01:32:45.954023014Z time="2024-04-09T01:32:45Z" level=warning msg="Failed to mount volume pvc-60fce72a-acab-4214-9144-8305cf99e932 on node ccc with kernel release 5.15.0-94-generic, os distro ubuntu" func="csi.(*NodeServer).nodeStageSharedVolume" file="node_server.go:284" component=csi-node-server error="mount failed: exit status 32\nMounting command: /usr/local/sbin/nsmounter\nMounting arguments: mount -t nfs -o vers=4.1,noresvport,timeo=600,retrans=5,softerr <IP_ADDRESS>:/pvc-60fce72a-acab-4214-9144-8305cf99e932 /var/lib/kubelet/plugins/kubernetes.io/csi/driver.longhorn.io/67d50915e9bd94523ce9dfb7240f1b491572361b8cad3537c5274f6184eb3cc0/globalmount\nOutput: mount.nfs: Protocol not supported\n"


iotop: New formula

Second submission, this time audit --strict says we're A-OK.
Given this is a python-based lib I might have missed something. I followed the instructions on the wiki, though.

I should also note that iotop requires a kernel above 2.6, and a system that provides a /proc/self/io. Is there any way brew can check these things before trying to install?

Ok, fixed.

Merged. Thanks for your contribution, Tomás. The preferred commit log message is
iotop 0.6 (new formula) for Linuxbrew

Just curious - why is this being merged straight into Linuxbrew?  Is it a Linux-specific command?

I think I'm also curious by your question @iggyvolz. Isn't linuxbrew meant for Linux?

Oh, I just realized what you mean. I'm not sure if iotop actually runs on OSX, but the documentation is pretty clear that it requires a Linux 2.6.x kernel or above. Is there a /proc/self/io path on OSX?

No, there's no /proc/* on Mac OS. It looks like Mac OS ships with an implementation of iotop, which is news to me:
~ ❯❯❯ which iotop
/usr/bin/iotop
~ ❯❯❯ iotop
dtrace: failed to initialize dtrace: DTrace requires additional privileges

@tomas Linuxbrew is a fork of Homebrew, which is designed for Mac.  Usually, new formulae (formulas?) are sent in to Homebrew, and then they're merged in here weekly - with minor changes for Linux compatibility if needed (hence all the "unless io.Mac?")

@iggyvolz Yeah, I do use "regular" Homebrew on an old OSX laptop. I didn't know Homebrew formulae was ported to Linuxbrew on a weekly basis, though.
Where should I submit a formula for something like GIMP or Inkscape?

If it compiles on both Mac and Linux, then to Homebrew/homebrew.

Cool. Can you point to an example formula for a X11/GTK-based app?

Both Inkscape and GIMP are already in the X11 tap, actually!  But Inkscape might soon be moved to the core Homebrew/homebrew repository, since it doesn't depend on X11 anymore.


Allow tasks as being marked "allowed to fail"

This is useful for, for example, setting up CI tasks that build code on EA JDK versions. Building and testing on an EA JDK might fail, but the failure shouldn't fail the entire build.

This should probably be a more general failure policy:
data FailurePolicy
  | Retry Integer
  | Fail
  | IgnoreFailure

Retrying is purely an agent-side mechanism and doesn't, for example, result in the execution timeout being reset on the server.


PVE Post Install on Proxmox 8.3.0 failed, This version of Proxmox Virtual Environment is not supported

Please verify that you have read and understood the guidelines.
yes
A clear and concise description of the issue.
PVE Post Install on Proxmox 8.3.0 failed, This version of Proxmox Virtual Environment is not supported

/ __ \ |  / / /  / __ _  __/ /   /  / / / / / /
/ // / | / / __/    / // / __ / / /   / // __ / / __/ __ `/ / /
/ /| |/ / /   / / // (  ) / / // / / (  ) // // / / /
//     |/_/  //    _//_/  /// ///_/_,//_/
This script will Perform Post Install Routines.
Start the Proxmox VE Post Install Script (y/n)?y
✗ This version of Proxmox Virtual Environment is not supported
Requires Proxmox Virtual Environment Version 8.0 or later.
Exiting...
What settings are you currently utilizing?

[X] Default Settings
[ ] Advanced Settings

Which Linux distribution are you employing?
Debian 12
If relevant, including screenshots or a code block can be helpful in clarifying the issue.
No response
Please provide detailed steps to reproduce the issue.
No response

Wrong Repo.

Wrong Repo.

I get what you're saying, but a canned response that tells people to utilize the current website (https://community-scripts.github.io) would help make the transition from tteck's stuff over here smoother.

It would also help to look through the issues/discussions, the topic has probably already been discussed 5-10 times :smile:


add possibility to only show the native ios rate dialog

issue
currently it's not possible to only show the native ios rate dialog. This capability is needed because I want to have a custom action for android but still want to show the native ios rate dialog.
changes
I added a method to

check whether the native ios rate dialog is available
shwo the native ios rate dialog

Because then there is the possibility that when the native iOS dialog is not available, the dialog of the package is shown, which I don't want. With my solution I can check whether or not it's available and then make my own decision what I want to show.

@Skyost what's your opinion on this pr?

@The-Redhat I'm very busy at the moment, but I will try to review it tomorrow.

I have a few changes to make (in order to support new Android native review dialog) and it will be okay.


Width of data series can not fix

Hi everyone,
Now i'm using apexchart in my project and it's work perfectly and simply to custom. But if i set plotOptions like:
plotOptions: {       bar: {         borderRadius: 5,         columnWidth: '15px'       },     },
My column chart is not fix width of column data series.

Why my issue is closed?


Silverstripe Dev Guide Forms Page

Affected Version
Silverstripe 4
Description
https://docs.silverstripe.org/en/4/developer_guides/forms/
This page shows the text [CHILDREN Exclude="How_Tos,Fields"] which is (presumably) meant to be not be shown.

Resolved.


Readme.md updates

Done

Trying again!

Done :)
Matan Keidar
Technology & Ops - Platform
Thomson Reuters
Phone: +972-37350086
matan.keidar<EMAIL_ADDRESS>On 19 Jul 2017, at 16:24, Dan Bennett <notifications<EMAIL_ADDRESS>wrote:
Trying again!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_thomsonreuters_CM-2DWell_pull_43-23issuecomment-2D316385548&d=DwMCaQ&c=4ZIZThykDLcoWk-GVjSLmy8-1Cr1I4FWIvbLFebwKgY&r=njChTgLdi6IMlt6MFSMTH70HWCuiqZtmuubiFKfFyDc&m=R1rKgoadK59FbC9_RuKwhJgDBb4Mj0I0dACcyu1kEW0&s=-l4gv2a3bQeDXdfKT4nK3sMa0Nf0mTpUyb8WaF1ws0c&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ACnbTW8X4-5FYJzi0-2DfvCsKpRrTlCRaaz7ks5sPgOcgaJpZM4Ob7l5&d=DwMCaQ&c=4ZIZThykDLcoWk-GVjSLmy8-1Cr1I4FWIvbLFebwKgY&r=njChTgLdi6IMlt6MFSMTH70HWCuiqZtmuubiFKfFyDc&m=R1rKgoadK59FbC9_RuKwhJgDBb4Mj0I0dACcyu1kEW0&s=oG84zCQJseDRjuHkF_jJKT6Eiecu_1XrPZPmf4iL1JU&e=.


[WIP] Update hybrid model parallel GPT2 example for up to 175B parameters

Added scripts for ColossalAI, Megatron-Deepspeed and Pytorch FSDP

@kurisusnowdeng is this PR still valid? If not, I will close it.

@kurisusnowdeng is this PR still valid? If not, I will close it.

@FrankLeeeee We're still working on this PR. Basically some evaluations are left, including gemini & 8bit optimizer pretraining performance, as well as unitests.

Ok, I will convert this PR to draft for now as commits will trigger the CI repeatedly.

Ok, I will convert this PR to draft for now as commits will trigger the CI repeatedly. @kurisusnowdeng do make it ready for review once it is ready :)

Thanks a lot


Handling SAML Single Logout Requests from Federated identity Providers section has wrong image

Is your suggestion related to a missing or misleading document? Please describe.
In the doc[1] under the section "Handling SAML Single Logout Requests from Federated identity Providers", "Configuring Identity Provider(Secondary IS) in the Primary IS" point 6 has below lines
Expand the SAML2 Web SSO Configuration section and fill the required details. ![saml-slo-federated-idp-config](../assets/img/tutorials/saml-slo-federated-idp-config.png
Ideally, it should point to the image.
[1] https://is.docs.wso2.com/en/5.11.0/learn/handling-saml-single-logout-requests-from-federated-identity-providers/

Resolved with https://github.com/wso2/docs-is/pull/2224


Please consider updating go-getter to 1.5.3

Hello,
go-getter in version 1.5.3 added support for aws_profile query string for s3
protocol. That is something we really need, so I would like to ask if you would
please consider releasing patch version with just update of go-getter?

PR to bump the dependency versions is welcome!

I'm reading https://terragrunt.gruntwork.io/docs/community/contributing/ and
not finding it, so just want to make sure: It seems like there is no CLA
required for the contribution?
I will ask management for approval of OS contribution, just want to make sure
if I need to ping legal with CLA approval request.

Correct, there is no CLA for this repo.

@graywolf-at-work Any update on that issue? Is there already a PR?

Sorry did not have time to get to this (and sadly will not have the time for
some time yet).

Please give https://github.com/gruntwork-io/terragrunt/releases/tag/v0.31.7 a try!