Proposal: lazy loading approach to speed up configResolved hook

Hi @aleclarson, thanks again for putting this project together.
I was wondering what would be your opinion about a potential refactor (which I'd happily implement myself) to optimise vite-tsconfig-paths's performance on very large projects with many TypeScript projects referencing each other (e.g. thousands of tsconfig.json files).
At the moment, all tsconfig.json files inside the root are parsed in the configResolved hook, which if I understand correctly blocks the Vite dev server from starting up while this is ongoing.
If Vite renders a specific page that only uses a small subset of the codebase, we may only use a relatively small number of TypeScript projects. What would you think of lazily loading the required TypeScript configs (via tsconfck.parse/parseNative) inside resolveId() instead?
I can think of the following issues getting in the way:

according to this comment, project references need to be processed before the parent project. Would you have a concrete example for this? I couldn't find one in the existing test suite.
since resolveId() can be invoked concurrently, we may need to set up a mutex to ensure a config isn't parsed twice.

I'd love to get your feedback on this idea before I go and make a PR for it. Thanks!

Here's a draft I'm working on: https://github.com/aleclarson/vite-tsconfig-paths/compare/master...fwouts:lazy
This seems to be working but is completely missing the project references priority handling mentioned above, since I don't understand how that's supposed to work :) It also assumes one directory = one project but the current implementation seems to support more than one resolver per directory? I'd love some more context here. Thanks!

I'm fully on board with this idea, if you're still interested! Apologies for the radio silence.

No worries. I'm no longer able to follow this up, feel free to take it on or close the issue.


Refactor time unit fields and variables in security modules

Purpose
This PR updates the time unit fields and variables in security modules.
Check List

[x] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b862de8). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #17209   +/-   ##
=========================================
  Coverage          ?   14.18%
=========================================
  Files             ?       51
  Lines             ?     1600
  Branches          ?      260
=========================================
  Hits              ?      227
  Misses            ?     1360
  Partials          ?       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b862de8...7e67c47. Read the comment docs.


Add option for trimming prefix path

Describe the problem you are trying to solve

Currently there's no easy way to trim the path prefix when compiling.
rustc has --remap-path-prefix  but this requires you to know the prefix. This is hard to know when using build systems and you can't expect users to have this set when distributing source.
Describe the solution you'd like

I believe we should copy Go:

The new go build flag -trimpath removes all file system paths from the compiled executable, to improve build reproducibility.

With a trimpath option in cargo.toml. This would pass --remap-path-prefix=$CARGO_MANIFEST_DIR=/ to rustc.
This could also perhaps be enabled by default on release builds.
Notes

I would be interesting in implemented this myself. Some guidance would be appreciated on how to get this accepted, if I need to write an RFC, etc.

I've just found #5505, which is basically the problem i'm trying to solve here.

I will close for now and guide the conversations to continue in #5505 and #9407.


Refactor CI

Update tox.ini
Drop py35 support
Fix OSX issue on travis-ci

Codecov Report

Merging #12 into master will not change coverage.
The diff coverage is 52%.

@@           Coverage Diff           @@
##           master      #12   +/-   ##
=======================================
  Coverage   72.42%   72.42%
=======================================
  Files           2        2
  Lines         214      214
  Branches       12       12
=======================================
  Hits          155      155
  Misses         59       59

Impacted Files
Coverage Δ

src/ezaero/vlm/plotting.py
0% <0%> (ø)
:arrow_up:

src/ezaero/vlm/steady.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3fe340...575c301. Read the comment docs.


Initial Fixes

@tehdiplomat i think i'm going to merge this, and then can re try to make a new release out of it

@Hanmac Do we need to update the snapshot script for new versions and things? Whats the plan?

@tehdiplomat the snapshot script already uses the 4.6.1 Version:
https://github.com/Card-Forge/forge/blob/038374c3c5df334e1dcae40278723302ba5aea22/.github/workflows/snapshots-android.yml#L79-L80
so no changes needed
just the release for this Repo need to be build / updated again (maybe an Action for this repo too?)

Ah I think @kevlahnota had built that locally and I just uploaded it last time? An action to build the repo is probably a good idea. Should we be bumping the version number to 4.6.2? So we don't clubber the functioning release? I guess pom can handle that.

yeah an Action would be cool
i'm not against bumping it

@kevlahnota How are you running this locally? Can we convert that into github actions here?

@kevlahnota How are you running this locally? Can we convert that into github actions here?

I run this
mvn clean install -DskipTests -e
I don't have experience using github actions so I don't know what to do with it.


[FEATURE REQUEST] Add Review Prompt

import SwiftUI
import StoreKit

struct ContentView: View {
  @Environment(\.requestReview) var requestReview

  var body: some View {
    Button("Leave a review") {
      requestReview()
    }
  }
}

release 1.3 in review


Validations needed for liason officer creation

Subject of the issue
Describe your issue here.
Your environment
Chrome/FF
Steps to reproduce

login as admin to volunteers.keralarescue.in
create liason officers
officer name accepts blank

Expected behaviour
Officer name field must have validations

@giju "this is taken care and pushed to prod now"

fixed and verified

cc: @biswaz @naveenpf @syam3526


The performance of default voc8.res50v3+.CPS

thank you for release the code. we run the default config as your public in voc8.res50v3+.CPS, the best performance is 72.76, a little lower than the 73.20 in paper. have any other tricks?  the default epoch is 34, the paper is 60? but your released log, 73.28 is also use 34 epoch.

Hi, we train this model for 34 epochs with no additional tricks. Please try to use the Docker we provide to run these experiments (https://github.com/charlesCXK/TorchSemiSeg/issues/27).

thank you. But I have installed with conda env as the doc. the version is same. have any other random factor?  I have no permission to use nvidia-docker in cluster. the code and config is same between docker and this repo?


[BUG] OpenDistro admin not allowed to restore indices

Please note!   This is a template to file a bug for the OpenSearch security plug-in.  If you discover a potential security issue in this project we ask that you notify AWS/Amazon Security via our vulnerability reporting page or directly via email to<EMAIL_ADDRESS>Please do not create a public GitHub issue.
Describe the bug
Problem
This is an OpenDistro problem. We are this close to upgrading to OpenSearch, so thank you for your patience in responding to this problem.
I have been trying to restore some indices to our warm OpenDistro nodes after our team ran into some memory issues and had to delete indices. However, when I try to issue a restore command (either using python HTTP calls OR as a curl command) as the backend default admin user, I receive the following error:
Command:
curl -u admin:REDACTED --insecure -XPOST "https://redacted:9200/_snapshot/REDACTED-snapshot-prod-feb-2022-1a/curator-2022030REDACTED/_restore?wait_for_completion=false" -H 'Content-Type: application/json' -d' { "indices": "REDACTED_daily_2022.02.10", "ignore_unavailable": true, "include_global_state": false, "index_settings": {"index.routing.allocation.require.box_type": "warm", "index.number_of_replicas": 0}}'
Response:
{"error":{"root_cause":[{"type":"security_exception","reason":"no permissions for [] and User [name=admin, backend_roles=[admin], requestedTenant=null]"}],"type":"security_exception","reason":"no permissions for [] and User [name=admin, backend_roles=[admin], requestedTenant=null]"},"status":403}
Notice how there aren't any specific permissions for which I am denied for.
I also tried creating a local user and gave it cluster_all and indices_all permissions. However, I observed the same 403 response - also lacking a specific permission.
'{"error":{"root_cause":[{"type":"security_exception","reason":"no permissions for [] and User [name=restore_indices_local_user, backend_roles=[restore_indices], requestedTenant=null]"}],"type":"security_exception","reason":"no permissions for [] and User [name=restore_indices_local_user, backend_roles=[restore_indices], requestedTenant=null]"},"status":403}'
I then searched my security-auditlogs for these calls. When searching over admin, here is what I got back:
Command:
GET /security-auditlog-2022.04.01/_search?size=10000 {   "query": {     "bool": {       "must": [       {           "query_string": {             "fields": [               "audit_request_effective_user"             ],             "query": "*admin*"           }         },         {           "range": {             "@timestamp": {               "from": "now-5m",               "to": "now"             }           }         }       ]     }   } }
Response:
See response.txt, specifically Line 40 & Line 44. Even though I am the default admin user (this comes standard in all OpenDistro clusters, or that is what I understand), the security audit log has "audit_request_effective_user_is_admin" is set to false.  The response is either MISSING_PRIVILEGES or OPENDISTRO_SECURITY_INDEX_ATTEMPT.
I have the following fields set in elasticsearch.yml:
opendistro_security.enable_snapshot_restore_privilege:true
opendistro_security.check_snapshot_restore_write_privileges:true
To Reproduce
I honestly don't know how to reproduce this; in the past, we have restored indices as the default admin user without this issue.
Expected behavior
I should be able to restore indices as an admin without receiving a permission denial.
Plugins
opendistro-alerting
opendistro-index-management
opendistro-performance-analyzer
opendistro_security
opendistro-anomaly-detection
opendistro-job-scheduler
opendistro-reports-scheduler
repository-s3
opendistro-asynchronous-search
opendistro-knn
opendistro-sql
Screenshots
If applicable, add screenshots to help explain your problem.
Host/Environment (please complete the following information):

OS: centos
Version 7

Additional context
Add any other context about the problem here.
response.txt

@Anthony7774 Hey! We are using 1.13.X (I think we're using 1.13.0). I will try using the admin certificate. Regarding that - if I was just restoring a single index (that is NOT the .opendistro_security index) like above, would I need an admin certificate? Would the presence of the .opendistro_security index in the snapshot require that I have an admin certificate to restore an index, even if I'm not restoring the .opendistro_security index?

@verbecee Admin certificate should not be required if you are not restoring the security index and I have not been able to reproduce your issue.
Would you be able to confirm the admin user is mapped to all_access role, by running below command and checking the "roles" section:
curl -XGET "https://localhost:9200/_opendistro/_security/authinfo?pretty" -u admin:<password> -k

@verbecee  here is the output:
{   "user" : "User [name=admin, backend_roles=[admin], requestedTenant=null]",   "user_name" : "admin",   "user_requested_tenant" : null,   "remote_address" : "REDACTED:40732",   "backend_roles" : [     "admin"   ],   "custom_attribute_names" : [ ],   "roles" : [     "own_index",     "all_access"   ],   "tenants" : {     "kibana_REDACTED_tenant" : true,     "kibana_REDACTED_tenant" : true,     "kibana_REDACTED_tenant" : true,     "kibana_REDACTED_tenant" : true,     "global_tenant" : true,     "kibana_REDACTED_tenant" : true,     "kibana_REDACTED_tenant" : true,     "kibana_REDACTED_tenant" : true,     "admin" : true,     "kibana_REDACTED_tenant" : true,     "REDACTED_tenant" : true,     "kibana_REDACTED_tenant" : true,     "kibana_REDACTED_tenant" : true,     "REDACTED" : true,     "kibana_REDACTED_tenant" : true,     "admin_tenant" : true,     "kibana_REDACTED_tenant" : true,     "kibana_REDACTED_tenant" : true,     "kibana_REDACTED_tenant" : true   },   "principal" : null,   "peer_certificates" : "0",   "sso_logout_url" : null }

@verbecee This is very strange, I have tested using 1.13.0 and later, used curator to create the snapshots, which I assume was done in your case and restore for the individual indices work as expected.
Can you confirm that below lines are present in every elasticsearch.yml file across all nodes?
opendistro_security.enable_snapshot_restore_privilege: true
opendistro_security.check_snapshot_restore_write_privileges: true

Closing due to inactivity without next repro steps. Please feel free to re-open with more details if this is still an issue. Thanks!


README correction for JDK17

the JVM option --add-opens java.base/sun.nio.ch=ALL-UNNAMED is missing an equals sign after the option, otherwise the argument isn't recognized

You are correct; Readme is fixed. Thank you!


Move Zhiyuan to HOF

Zhiyuan is now Assistant Professor at Appalachian State.  Move her to HOF.

Latest commit


ASU-765 Finalize initial conf for production

There were some of the production configurations already done to this
repository so this finalizing the initial configuration for production
environments.
The code bases to Open City Profile's implementations:
https://github.com/City-of-Helsinki/open-city-profile

Codecov Report

Merging #49 (2bf950c) into develop (94df76d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop      #49      +/-   ##
===========================================
+ Coverage    87.92%   87.93%   +0.01%
===========================================
  Files           31       31
  Lines         1010     1011       +1
  Branches        98       98
===========================================
+ Hits           888      889       +1
  Misses          99       99
  Partials        23       23

Impacted Files
Coverage Δ

apartment_application_service/settings.py
83.33% <100.00%> (+0.18%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94df76d...2bf950c. Read the comment docs.

@jmp Ready for another review.


Analyzing Restaurant Reviews Using NLP #674

I would like to work on this project, can you please assign this to me?


Apple Spanish keyboard layout

Hello Tekezo,
Currently we have a issue with my Apple Keyboard in Spanish.
Before, I solve the issue with Karabiner, using the following rule
<item>
      <name>Swap ordinal-indicator(º) and less-than(<)</name>
      <identifier>remap.spanish_swap_ordinal_indicator_lessthan</identifier>
      <autogen>__KeyToKey__ KeyCode::SPANISH_ORDINAL_INDICATOR, KeyCode::SPANISH_LESS_THAN</autogen>
      <autogen>__KeyToKey__ KeyCode::SPANISH_LESS_THAN, KeyCode::SPANISH_ORDINAL_INDICATOR</autogen>
</item>

Can you help me explain how can I migrate this rule to Karabiner-Elements in JSON.
Thanks for your help

Have you set your virtual Keyboard to ISO instead of ANSI? On my German keyboard this fixed the Circumflex (left of 1) with < switch thing.
Preferences > Virtual Keyboard > Keyboard Type : Set to ISO
Related to #1035 and #390?


Define a cube in the user manual

Mcblend is strict about the objects that can be considered  cube. The rules should be clearly explained in the user manual.
There is some discussion about it in issue #92.

Old issue.


Handle 'with BOM' UTF encodings.

I noticed that some Windows based files have encodings of 'UTF-8 with BOM', 'UTF-16 with BOM', etc. This handles those, otherwise the encoding fails.

Thank you :)

Cheers! Thank you for the Sublime package.


Configuration for terminal output

Thanks for this great plugin.
I'm having difficulties going through the terminal output though.
That would be nice to have some configuration to :

display coloured output
hide rules details

Hi @mfillon!
Thanks for reporting!
I'll implement rule details hiding.
What do you mean by "coloured output"? What colors and where would you like to have?

Hey @remal ,
Thanks for the quick fix.
Regarding colored output, I was thinking something similar as ESLint :

I'll create a separate issue then

Hey @remal ,
I tried setting that new config to hide description but I'm still seeing everything in the console output ("Why is this an issue?", "How to fix" and "Resources" parts).
I'm using latest version of the plugin (3.4.4).
Here's how I configured in my build.gradle file :
sonarLint {
    rules {
        ...
    }
    logging {
        withDescription = false
    }
}

Am I missing something?
Thanks

@mfillon, you're right - there was a bug. Please try v3.4.5

@mfillon, you're right - there was a bug. Please try v3.4.5

Thanks @remal , I just tested it and It works like a charm!


Enable setting Katex options from dendron

Please Select if your Request is Either something new or an Enhancement

[ ] Enhancement of an existing Feature.
[x] Request of a new feature.

Please select the area your request applies to. (Multiple selections are Possible)

[ ] Onboard. Initial vault setup and import/export pods
[x] Create. Note creation, lookup, snippets and templates
[ ] Retrieve. Backlinks, references, graph view
[ ] Structure. Refactoring, multi-vault and schemas
[ ] Publish. Sharing your repo with the world
[ ] Misc (Choose this if your not sure)

Is your feature request related to a problem? Please describe
Among other things I take notes on the math books that I read. I prefer markdown based solutions over latex for various reasons. One thing that latex still does better than all the markdown note taking applications that I used(they all use the Katex engine) is the ability to define new commands with macros. This is useful because when one reads a new book new notation is introduced and used throughout the book and when I'm taking notes it would be great to define new shorter commands for this.
Describe the solution you'd like
It would be great if you could expose the Katex settings via the "dendron.yml" or some other mechanism. I was browsing through the source and found that dendron is using rehype-katex as the API for Katex. This library supports passing options to Katex. The options that Katex accepts are documented here.
My problem would be solved by exposing the "globalGroup" option which I could turn to true and then macros would persist between the math blocks. Note that inside one math block I can already use the "\newcommand" and similar macros(documented here) and in that block I can call it. For example "$$\newcommand\powmacro[2]{#1^#2} \powmacro{1}{2}$$" displays the expected result.
Describe alternatives you've considered
One can add commands to VS Code and let it do the snippet expansion. One issue I see with this is that you can't call a snippet from another snippet which makes it less flexible than latex macros.
Another solution which I currently use is a clipboard which supports fuzzy search on the clipboard history. My current choice is greenclip. This is fine but it has the same issues as the VS code snippet based approach. Also my my history is cluttered with irrelevant things so again not really my preference.
Additional context
N/A

I started working on this. I managed to put together a rudimentary version. Given that Dendron is using KaTeX and KaTeX has some issues like not supporting default arguments for newcommand and similar macros it might makes sense to expose MathJax as a math renderer option given that the same remark-math github project exposes MathJax as well(see here). I care more about robustness than speed. Also I have larger documents in Obsidian which is probably rendering with MathJax given it supports default values for macros and there are basically these 2 options for rendering math in the browser and they are rendering just fine. For backward compatibility the default renderer can stay KaTeX, but I think this option will benefit a lot of people who do math in Dendron.

In addition a place to define global macros or load third party modules would be nice!

+1 for this, macros are incredibly useful for typesetting maths

I found Markdown-Preview-Enhanced already have Katex macros config. I am not sure we need to port the same functionality to Dendron or able to integrate with Markdown-Preview-Enhanced.

@s1913388 As dendron already replaced the MPE extension view I doubt that relying on it again is a good option.

Are there news about this query. I think that using macro for typesetting equation is a must have for all academics working with equation and writing papers in TeX

This issue is featured in this week's round of CROP voting on Dendron's Discord server.

Is there a chance that this feature be added in a future release ?

I just wanna add that VSCode's built-in preview already supports this feature from settings.json.
You just have to set your macros in markdown.extension.katex.macros. The syntax is almost the same as in MD-Preview-enhanced
Dendron does not seem to currently interact with it, though.


Random error during nothing being occuring

While i was programing a random class this error popped up and since then it has constantly appearing! BTW nice plugin, easy to use and quite useful. Anyway, the error is the following:
java.lang.Throwable: cannot share data context between Swing events; initial event count = 102167; current event count = 102353
at com.intellij.openapi.diagnostic.Logger.error(Logger.java:145)
at com.intellij.ide.impl.DataManagerImpl$MyDataContext.getData(DataManagerImpl.java:345)
at com.intellij.openapi.actionSystem.DataContext.getData(DataContext.java:55)
at com.intellij.openapi.actionSystem.AnActionEvent.getData(AnActionEvent.java:184)
at com.intellij.openapi.actionSystem.AnActionEvent.getProject(AnActionEvent.java:141)
at de.lukweb.discordbeam.DiscordMenu.uploadText(DiscordMenu.java:64)
at de.lukweb.share.ShareMenu.actionPerformed(ShareMenu.java:96)
at com.intellij.openapi.actionSystem.ex.ActionUtil$1.run(ActionUtil.java:298)
at com.intellij.openapi.actionSystem.ex.ActionUtil.performActionDumbAware(ActionUtil.java:315)
at com.intellij.openapi.keymap.impl.IdeKeyEventDispatcher$1.performAction(IdeKeyEventDispatcher.java:604)
at com.intellij.openapi.keymap.impl.IdeKeyEventDispatcher.lambda$processAction$3(IdeKeyEventDispatcher.java:657)
at com.intellij.openapi.application.TransactionGuardImpl.performUserActivity(TransactionGuardImpl.java:193)
at com.intellij.openapi.keymap.impl.IdeKeyEventDispatcher.processAction(IdeKeyEventDispatcher.java:656)
at com.intellij.openapi.keymap.impl.IdeKeyEventDispatcher.processActionOrWaitSecondStroke(IdeKeyEventDispatcher.java:517)
at com.intellij.openapi.keymap.impl.IdeKeyEventDispatcher.inInitState(IdeKeyEventDispatcher.java:472)
at com.intellij.openapi.keymap.impl.IdeKeyEventDispatcher.dispatchKeyEvent(IdeKeyEventDispatcher.java:221)
at com.intellij.ide.IdeEventQueue.dispatchKeyEvent(IdeEventQueue.java:830)
at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:775)
at com.intellij.ide.IdeEventQueue.lambda$dispatchEvent$8(IdeEventQueue.java:424)
at com.intellij.openapi.progress.impl.CoreProgressManager.computePrioritized(CoreProgressManager.java:698)
at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:423)
at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)
Hope it can help to fix further bugs.

Thanks for your bug report. I've got two question for you to determine the impact of this issue more exactly.

Do you have DiscordBeam installed?
Which IntelliJ version are you using?

I don't have that plugin installed in my computer;
2.Yes i have.
3.Intellij 2013.3.1

Thanks for your answers.
One thing confuses me, did you mean the IntelliJ version 2019.3.1, because DiscordBeam doesn't support versions below 2018.3.
Anyway I did a bit of research and I guess I fixed the problem. Here's a new build of DiscordBeam (supports all IDEA versions starting from 2019.3): DiscordBeam-1.05.zip
Just drop the zip file into your IDE and the plugin will be automatically updated. If the error still appears please add a comment to this issue 👍

If this error occurs once more, please open a new issue. Thanks for your help.


PS Generator Stress Test file for SVG crashes generator-assets

The test file is in the trello for Crema.
@rioter says:

My first pass at a fix would be to remove the constant copying of the buffer and instead stream the result around. It is a very risky fix this close to a release.

@jhatwich says:

After chatting it sounds like the fix would go in generator-core and/or generator-assets and essentially it is to rewrite the pipeline to be stream-based anywhere its using buffers. I think this might be a big change due to how "convert" works - it is a bolted-on binary... I think we have to give it the whole image... anyway, this is probably solvable, but may take several weeks of engineering time.

Leaving this bug open to make sure it is actually resolved if/when we implement the suggested streaming.  I have opened https://jira.corp.adobe.com/browse/PS-1327 to track that effort.


Add /image generation

Add support for generating images through prompts. As a bonus, each image can be accompanied by an extended description (from the initial prompt) that can be used with other image generation services such as Midjourney or Stable Diffusion.
For more information, refer to the following link: https://platform.openai.com/docs/guides/images.

Added /imagine  command


SeqReverseSequence doesn't work after tensor conversion

I'm using SeqReverseSequence. I train my model on a GPU, and then when saving the model, I convert all OpenCL tensors to regular double tensors.
However, SeqReverseSequence has two fields, self.outputIndices and self.gradIndices, which can't be convertted into a DoubleTensor. These fields work fine as CLTensors, but when working on a CPU, they must be LongTensor, otherwise I get an invalid tensor type on:
    self.output:gather(input, 1, self.outputIndices)

This function expects self.outputIndices to be a LongTensor when its actually just another DoubleTensor because the model has been converted, saved to a file and loaded again.
So far, I've been simply modifying my the SeqReverseSequence code to look like this:
    self.output:gather(input, 1, self.outputIndices:long())

And this magically works. But is there another way?

Good catch :+1:  I think commit https://github.com/Element-Research/rnn/commit/27c7788ce583c1bc0d311529bce4473f49f70f25 should solve it. Let me know otherwise :)

Thanks Nicholas for this prompt fix


axis of flip

Hi,
According to this line,
https://github.com/cchen156/Learning-to-See-in-the-Dark/blob/master/train_Sony.py#L180
the flipping will occur at axis 0,
however for a batch of images, axis 0 is the 'batch' axis if understand your code correctly,
should it be axis=2 (left-right flip) instead?

Revised.


Unable to redirect to HTTP service

https://github.com/clems4ever/authelia/blob/21d55a027db720e432d7d5955914c2f14d40f4cd/server/src/lib/routes/firstfactor/post.ts#L93-L100
Would you be open to having a PR that adds a config option to allow unsafe redirects? I'm playing around with this locally so I can take some notes, and I'd rather not have to setup certificates.

Opted to use Traefik's generated certs.


Documentation for safe dereference operator

Bicep 0.15+ includes a .? (safe dereference) operator to simplify working with missing and nullable types.
Rough first pass:
At a high level, the .? (safe dereference) operator will return null if a missing property (or nested property thereof) is accessed. For example:

myObject.?foo will return null if myObject has no foo property (instead of raising an error).
myArray[?index] will return null (instead of raising an error) if index is greater than or equal to the length of myArray.
myObject.?foo will return null if myObject is null.
myArray[?index] will return null if myArray is null.

Like C#'s null conditional operator, safe navigation is short-circuiting: if the access performed by .? or [?] returns null, then any chained property or array accesses will not be performed. Short-circuiting may be interrupted with parentheses if desired. For example:
var foo = bar[?1].property.nested // .property.nested will only be accessed if bar[?1] returns a non-null value
var baz = (bar[?1].property).nested // .property will only be accessed if bar[?1] returns a non-null value. .nested will always be accessed, even if bar[?1].property returns null

For users who are used to the ?. (null conditional) operator from TypeScript, you will generally want to use .? one step earlier in an access chain.  For example, assume a symbol a whose value is an empty object. In TypeScript, if you wanted to safely navigate to a nested property, you would need to place a ? immediately following the first expression that may evaluate to null or undefined:
a.some?.deeply.nested.property

In Bicep, the same symbol requires that the first (rather than the second) access operation be safe in order to avoid the need to check whether a property exists with contains (e.g., (contains(a, 'some')):
a.?some.deeply.nested.property

This difference is due to how missing property accesses are handled in the ARM runtime vs. how they are handled in JavaScript. In Javascript, if you try to access a missing property or an out-of-bounds array index, the value undefined will be returned. In the ARM runtime, however, an error will be raised.

See https://learn.microsoft.com/en-us/azure/azure-resource-manager/bicep/operator-safe-dereference.


TorchCrepe is slower than TF crepe on CPU

By empirical observation, using PyTorch version of crepe is 5-6 times slower on CPU as compared to TF (benchmarks to be attached).
The main reason I infer is due to TF turns on MLIR optimization during CPU inference, hence utilizing oneDNN library and AVX / AVX2 operations. For PyTorch, this article mentions that it is possible to turn on oneDNN fusion, but I have yet to have success of applying it + observing the speedup on CPU.
Another pain point is seems like oneDNN fusion is only supported on Linux right now - see issue. Yet to think of a workaround to make it work.

I haven't tested CPU speed. How are you calling torchcrepe? Depending on your arguments, the runtime changes significantly.

@maxrmorrison sorry for replying late. For torchcrepe, I am using the default parameters as shown in the code demo.
I ran a simple benchmark on colab (all using "model-full:): https://colab.research.google.com/drive/1rBC4bXSo3nujk6n9JeHJfErBaC8epxze?usp=sharing - and find that the latencies are as below (all predicted results are identical) -
Crepe: 48.22s
TorchcrepeV2: 46.13s
Torchcrepe: 56.15s

On my MacBook Pro 2019, TF Crepe is much faster due to hardware acceleration turned on by default, using AVX2 FMA operation, which makes the convolution op faster.
Crepe: 9.684s
TorchcrepeV2: 41.47s
Torchcrepe: 43.63s

Running a torch.profiler on both our implementations can confirm that the bottleneck is due to convolution ops (aten::mkldnn_convolution, aten::_slow_conv2d_forward)

I think code implementation wise we might not be able to do much, probably some common CPU model optimization techniques could be done. Personally I hope to deploy a fairly fast crepe on CPU, which is why its CPU latency is something I am more concerned about.

I don't appear to have your file, so I cannot run your colab. But I fixed the issues and added comments. You were not performing a fair comparison between the models.

Also, if the issue is just swapping out a conv layer, why not just make a pull request to torchcrepe instead of creating a new repo? If you can speed up torchcrepe, you'll end up on the contributor list and not have to deal with a lot of nuances I take care of in torchcrepe that aren't addressed here (e.g., you do not address when the audio file does not fit in GPU memory). And then you don't even have to deal with deployment.
Regarding the inference CPU optimizations, I haven't looked into those. If you find one that works for all systems reliably, I'd be interested.

@maxrmorrison sorry for the late reply. I am more than happy to contribute to torchcrepe! This repo is main for my personal usage and the code existed before torchcrepe, and most of my projects are using it so I did not do the migration.
I should have found a way to speed up using ONNX, but I need more test to verify on several different environments. Once ready, I shall raise an issue on torchcrepe for review.


Multiple instances

This PR is to support multiple instances of MSAL in the same window stack (i.e. in main window and iframe, two separate iframes, etc.).
Changes:

Cleaning up the Storage class to make room for future improvements
Introducing new functionality to make unique keys in the cache tied to each instance of MSAL
Cleaning up the Constants.ts file to properly organize string constants and cache keys
Introduction of new Storage mechanics to UserAgentApplication
Migration from old cache signatures to new ones
Unit tests

Note: @pkanher617 's PR #980 is moved to this PR with some additional changes

Done. @pkanher617 @jasonnutter Can we please prioritize this tomorrow?

@jasonnutter Added the comment. Can you please approve?


WebApp - Update some message related to earning and swap feature

Describe the task
Update some message related to earning and swap feature

Refer: https://github.com/Koniverse/SubWallet-Extension/issues/3150

[x] Message in case Insufficient balance when withdraw, claim reward and unstake

Actual: Show message "Your available balance is [Available balance], you need to leave [ED] as minimal balance (existential deposit) and pay network fees. Make sure you have at least [x tokens] in your transferable balance to proceed."
Expect: Change to message "You don't have enough [token] (network name) to pay gas fee. Top up your transferable balance and try again"

[x] Message in case Insufficient balance when stake with Liquid staking (re-check lending staking)

Example: stake DOT (Acala) and account have xx ACA (xx > ED) and yy (DOT) then input stake amount: DOT > Total DOT on Acala and Polkadot
Actual: Show message "You don't have enough ACA (Acala) to pay gas fee. Lower your amount and try again"

Incorrect token

Expect: Show message "You can only enter a maximum of xx DOT, which is xx1 DOT (Acala) and xx2 DOT (Polkadot). Lower your amount and try again."

Note for tester: Check message in case Insufficient balance when swap

Version test: https://pr-3188.subwallet-webapp.pages.dev/
Validation passed


Fine-grained Action Annotations

Hi,
First of all, thanks for releasing such a great dataset! It seems that the 10K fine-grained action annotations mentioned in the paper are not included in the repo. Is there a plan to release them as well? Thanks

@594zyc
Thank you for your interest in our work.
Yes, we shall release the 10K annotations as well in a few weeks.


Remove/fix duplicate class method check

Rev 26 of the ES6 spec, removes duplicate class method checks, except for "constructor".
This diff removes the dupe check from parseMethodDefinition and
implements it in parseClassBody for "constructor" only. I chose to still
keep track of static and prototype method names, since the spec
describes such a list. I moved the check to parseClassBody with the
intention to be able to reuse parseMethodDefinition for object literals
in the future.
By removing this logic, we also fix a bug that doesn't allow for two
properties with literal names. E.g.
class A
  42() {}
  "foo"() {}
}

currently throws a "duplicate property" error.
I changed the existing tests which previously expected errors to expect
ASTs now. I also added new tests for duplicate constructor properties.
npm test runs fine and there is no benchmark or coverage regression.
Issues covered by this PR:
https://code.google.com/p/esprima/issues/detail?id=594
https://code.google.com/p/esprima/issues/detail?id=563

@fkling Would you mind rebasing this against the latest harmony branch? Thanks!

Done! Do you think I added too many tests?

Looks good, thank you! More tests are fine; the more, the merrier :-)


Remove apache-rat-plugin dependency

Purpose
This PR removes apache-rat-plugin dependency.
Related PR: https://github.com/ballerina-platform/ballerina-lang/pull/14097

Closing the PR since we have decided to use rat plugin in the release profile.


Session connection with stream=True unusable after response.close()

Please consider the following code:
import requests
session = requests.Session()
resp = session.get('http://www.w3schools.com/html/demo_sse.php', stream=True)
resp.close()
session.get('http://www.w3schools.com')

It results in the following exception:
Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File ".../venv/lib/python3.4/site-packages/requests/sessions.py", line 477, in get
    return self.request('GET', url, **kwargs)
  File ".../venv/lib/python3.4/site-packages/requests/sessions.py", line 465, in request
    resp = self.send(prep, **send_kwargs)
  File ".../venv/lib/python3.4/site-packages/requests/sessions.py", line 573, in send
    r = adapter.send(request, **kwargs)
  File ".../venv/lib/python3.4/site-packages/requests/adapters.py", line 415, in send
    raise ConnectionError(err, request=request)
requests.exceptions.ConnectionError: ('Connection aborted.', ResponseNotReady('Request-sent',))

Unless I am doing something wrong, It appears to me that resp.close() returns the connection to the pool in an inconsistent state. What's interesting is that the exception does not occur when the last line in the example above connects to a different server (eg. session.get('http://www.google.com') instead of http://www.w3schools.com). What's also interesting is that the problem only occurs when working with a requests.Session. That is, the following code does not raise an exception:
import requests
resp = requests.get('http://www.w3schools.com/html/demo_sse.php', stream=True)
resp.close()
requests.get('http://www.w3schools.com')

I am using requests version 2.7.0. The problem occurs on both Windows 7 with Python 2.7.10 and on OS X with Python 3.4.3.

This is a known issue (#2593), and was fixed in #2610. =) The next release of requests should contain the fix.

Awesome, thanks :-) Is there an ETA for the next release?

Nothing beyond "soon" I'm afraid. Hopefully our release process will get a bit more concrete over the next few weeks.

Ok, thanks for letting me know!


refactoring of integration tests with basic example

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Other information

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (a9598a0) 66.96% compared to head (35263f0) 39.33%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #849       +/-   ##
===========================================
- Coverage   66.96%   39.33%   -27.64%
===========================================
  Files         250      198       -52
  Lines       23647    20228     -3419
===========================================
- Hits        15836     7956     -7880
- Misses       6997    11919     +4922
+ Partials      814      353      -461

Flag
Coverage Δ

?

go-1.17.x
39.14% <ø> (-26.39%)
:arrow_down:

go-1.20.x
39.31% <ø> (-27.33%)
:arrow_down:

go-1.21.x
39.28% <ø> (-27.47%)
:arrow_down:

integration
?

macOS
39.32% <ø> (+0.03%)
:arrow_up:

ubuntu
39.30% <ø> (ø)

unit
39.33% <ø> (-0.06%)
:arrow_down:

windows
?

ydb-22.5
?

ydb-23.1
?

ydb-23.2
?

ydb-23.3
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 188 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


More frontends/backends

Rendering targets:

OpenVG: GPU-accelerated vector graphics, see https://github.com/ajstarks/openvg and
https://github.com/JamesDunne/golang-openvg
NanoVG: https://github.com/memononen/nanovg unmaintained but may provide helpful insight in how to handle OpenGL backend, see https://github.com/memononen/nanovg/blob/master/src/nanovg.c#L1278 for Bezier tesselation

Implement backend interface:

GIOUI: see https://gioui.org/ and https://github.com/ajstarks/giocanvas
Draw2D: https://github.com/llgcode/draw2d
gg: https://github.com/fogleman/gg
Fyne: https://github.com/fyne-io/fyne
Gi: https://github.com/goki/gi
Gio
Qt: https://github.com/therecipe/qt using QPainter

Related projects:

Cairo
Skia (Google)
Azure (Mozilla)
Blend2D https://blend2d.com/
Clutter https://developer.gnome.org/clutter/1.26/ClutterPath.html

The https://github.com/llgcode/draw2d project (by @llgcode) seems to share some similarities with this project.

FYI, wrt your far future plan "Generate TeX-like formulas in pure Go, use OpenType math font such as STIX or TeX Gyre", I've started something along these lines, here:

https://github.com/go-latex/latex
https://github.com/go-latex/latex/tree/master/mtex

w/ some math oriented fonts there:

https://github.com/go-fonts/latin-modern
https://github.com/go-fonts/stix

I've lost a bit of momentum on the math tex renderer font b/c of golang/freetype not being able to injest latin-modern fonts (the ones used by TeX) and golang.org/x/image/font not implementing everything that would be needed on the rastering front...

Thanks @sbinet that looks excellent! I'll integrate your work sometime soon and I'll keep you posted. For now I've lost some momentum on this, but there will be time in the future where I can take up some of the ideas, including this one!

@sbinet Please check the develop branch for font/sfnt.go (https://pkg.go.dev/github.com/tdewolff/canvas/font#SFNT), this may help you if you need more control over parsing fonts for go-latex. I guess it would be useful to add the https://docs.microsoft.com/en-us/typography/opentype/spec/math table for that!

thanks.
what's the difference w/ the golang.org/x/image/font/sfnt stuff? (it's just the SFNT tables exported, right?)
I may take a stab at implementing parsing the MATH table.
doesn't seem too complicated (famous last words...)
in other news, I've wrapped a C/C++ TeX engine and provided it as a Go package:

https://sr.ht/~sbinet/star-tex (needs Go>=1.16 because of "embed")

the end game being to replace all the cgo bits with pure-Go equivalents (and still pass the infamous "trip" TeX test).

Yes, there is no difference with golang.org/x/image/font/sfnt except that the tables are exported. I've also added subsetting of fonts.
star-tex looks good! When time permits I'll be looking to incorporate your LaTeX libraries into canvas, thanks!

star-tex looks good! When time permits I'll be looking to incorporate your LaTeX libraries into canvas, thanks!

@tdewolff IMO, the things should go on the opposite direction: star-tex to include canvas in a way to be able to produce different outputs (dvi, pdf, svg, png...).
By the way, one more time personal opinion for what this worth, I think that canvas should concentrate on what it is, a canvas. Do it well and leave "pre-print" complex operations to other libraries or modules. It should be a front end of all output formats. To add capabilities like node in tikz or "rich text" should be optional when we use canvas.
My concern is that if you're trying to put a lot of capabilities on canvas, you won't have time to make everything work properly, have good documentation and complete test coverage. And documentation and testing are absolutely necessary for mass adoption of a library.
Personally I'm fan of unix philisophy "do one thing and do it well". Sorry if my opinion is going against your plans.
One more time, thanks for your fantastic work. 🙏

Hi Kroum, thanks for the feedback! I think you're absolutely right, canvas should concentrate on being a building block to draw things with rather than adding more and more features. In particular, the documentation and examples are severely lacking.
I can't guarantee working on maturing the library, because some features are just too interesting! Besides documentation and example, what do you reckon are important steps that need to be complete? Are there any lacking features (dvi or OpenGL output?) or things that need to be improved?

I can't guarantee working on maturing the library, because some features are just too interesting!

@tdewolff I can't blame you for preferring to do fun things instead of writing documentation and tests. Oh, how well I understand you 😛. But it will be a pity to lose potential users when you are so close to the goal, IMO.

Besides documentation and example, what do you reckon are important steps that need to be complete? Are there any lacking features (dvi or OpenGL output?) or things that need to be improved?

Not particularly for me. If I find some time, I would like to improve the LaTeX driver (add settings: output tikz or pgf, save raster images in separate files or ignore them...). We can also imagine adding drivers for metapost, PSTricks, Asymptote...
On the low level side of canvas (libraries that it use), I find that in the "go-images world" is missing  jpeg2000 and CCITT (for black and white) compressions. But this is out of the scope of canvas, even if it indirectly concerns the pdf  and the tiff drivers.
On the high level side of canvas (libraries that use it), having go port of LaTaX as library will be fantastic, but one more time this, IMO, is out of the scope of canvas.

On the low level side of canvas (libraries that it use), I find that in the "go-images world" is missing jpeg2000 and CCITT (for black and white) compressions. But this is out of the scope of canvas, even if it indirectly concerns the pdf and the tiff drivers.

The rendering (converting a canvas to something else) is already decoupled from this library (#41 & #44), so you can implement the Renderer interface to export a Canvas to jpeg2000 or CCITT in any other package.

I don't know how feasible / easy it would be to also have decoupling regarding the "frontend", but just like the Renderer it probably needs time to know what is really needed (I feel that decoupling of the svg & pdf packages went well, because it had allowed to gather enough experience to get the exports right).
One thing I would enjoy, would be the ability to import a svg image as path. I took a look at it and it seemed way to complex (so I am using a png version of the svg, which is good enough for my usecase :)

@oliverpool it seems that the TIFF export format supports the CCITT group 3 and 4 compression, does that help you?

@tdewolff Yes, TIFF support CCITT, but, as far as I know, there in no CCITT encoding library in go. Decoding in go is ok, if I remember well.


DSpace responds "soft 404"

Describe the bug
When you enter to "/handle/something/something/discover" responds with a 200 status code, but it doesn't find anything. It doesn't matter if the handle exists. We discovered this error because some bots with old DSpace 6 links were trying this URL non-stop since it responds with a 200 status code. I don't know why this error doesn't occur in https://demo.dspace.org/
To Reproduce
Steps to reproduce the behavior:

Go to your local DSpace installation or try in (https://sandbox.dspace.org)
Go to /handle/1234/1234/discover (replace "1234" whit the handle you want)

See the HTTP response

Expected behavior
If DSpace is going to respond that the handle was not found, it should respond 404, not 200

@GarrafaGalactica this sounds very similar to the issue which was solved in #2816. The patch was only merged a few days ago and might fix this. I don't know if that patch is running on demo.dspace.org yet.


Move config to prometheus-operator

towards https://github.com/giantswarm/giantswarm/issues/26221
This PR:

remove the default config as it will be added in prometheus-operator

Checklist

[X] Update changelog in CHANGELOG.md.
[X] Make sure values.yaml and values.schema.json are valid.

I can't test this anymore.


Feature/added nodeselector and tolerations to tests

I need this feature to get the test pods scheduled on clusters that have strict tolerations and node pools.


Unable to strace in container with docker 1.10

Using strace in a container gives me an 'Operation not permitted' error.
strace: test_ptrace_setoptions_followfork: PTRACE_TRACEME doesn't work: Operation not permitted

If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
For more information about reporting issues, see CONTRIBUTING.md.
You don't have to include this information if this is a feature request
(This is an automated, informational response)

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

Not a bug, it's a feature!
https://blog.docker.com/2016/02/docker-engine-1-10-security/

To turn off security features use:
docker run --security-opt seccomp:unconfined ...

docker run -t -i --cap_add=ALL  container_name /bin/bash
or
docker run -t -i --privileged container_name /bin/bash


Add entity parsing

Hello, I opened this PR in the hdlparse project.
This is a follow-up to include entity symbol generation.
I'm no python developer so I'm not sure if the code is great, but it works quite well for me.
Could you take a look to both PRs and tell be if there's anything I can do to make them merge-ready?
Thanks !

See https://github.com/hdl/symbolator as a fork.


Update to Ark UI v4

As Ark UI v4 was just released, it would be great to have the library updated too.

@tyteen4a03
Done :)


Scala steward 1560

Contributor Checklist

[ ] Did you add Scaladoc to every public function/method?
[ ] Did you update the FIRRTL spec to include every new feature/behavior?
[ ] Did you add at least one test demonstrating the PR?
[ ] Did you delete any extraneous printlns/debugging code?
[x] Did you specify the type of improvement?
[x] Did you state the API impact?
[x] Did you specify the code generation impact?
[x] Did you request a desired merge strategy?
[ ] Did you add text to be included in the Release Notes for this change?

Type of Improvement

code cleanup

API Impact
No API impact
Backend Code Generation Impact
No impact on backend code generation
Desired Merge Strategy

Squash: The PR will be squashed and merged (choose this if you have no preference.

Reviewer Checklist (only modified by reviewer)

[x] Did you add the appropriate labels?
[x] Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
[x] Did you review?
[x] Did you check whether all relevant Contributor checkboxes have been checked?
[x] Did you mark as Please Merge?

I tried manually rerunning the fasted job, unfortunately freechipsproject is hammering Travis right now so not sure when it'll get to run

jk it's running right now

It worked 🎉


Use fixed point decimal conversion for the OpenFinex API

In order to have a clean conversion between decimals and block chain / substrate integers, we must use a conversion algorithm that does not involve any floating point numbers (as we do now). We need to parse the decimal directly from string.
According to OpenFinex, they use https://github.com/shopspring/decimal in Go.
Substrate has some support for this, see https://substrate.dev/rustdocs/v3.0.0/node_template_runtime/struct.Permill.html . It is not clear however how much of this can be used. Further investigation is needed.

This might be the better link: https://docs.rs/sp-arithmetic/3.0.0/sp_arithmetic/index.html

The issue with https://docs.rs/sp-arithmetic/3.0.0/sp_arithmetic/index.html is that it's not arbitrary precision (like the OpenFinex Go counterpart), and a lot of useful features are in std.

As described in https://github.com/Polkadex-Substrate/polkadexTEE-worker/pull/125 , I ended up writing my own parser/serializer for fixed point decimals.


Load default time along with selected show

Hey barron, would it be easy to implement a default loading hour when we select the show, has happens with other stored values? Even if that implies adding the hour manually on the database for each show :)
thanks

Hello! The reason it's not a feature at the moment was to avoid confusion for shows which may be on multiple days of the week at different times. Looking back now though, that's probably a minority of shows, so I'll investigate adding this feature.

OK, makes sense. What i want is to minimze the input data from end user.
Shows are always at the same time. But i know that end time is the variable to trigger the uploading mix to mixcloud. It can be upload the next day , regardless the hour the user selects.
So Im guessing a default input value of value="11:59" on end time (so that the last show of  the day, that starts at 22.00, doesn't get the mix published on mixcloud BEFORE it it actually goes on air) and then hiding the div?
I already tested the default input value and it works ok, now only need to hide the div. :)  Any suggestions to best implement that?
Thansk for everything!

If you're looking to hide the time input field completely, I'd probably add the hidden attribute to index.php#L172 -- so
 becomes
.
You'd be correct setting all shows to end at 23:59 on day of broadcast would publish them all at the same time and be a quick way to reduce the user input required until this is implemented properly. I'd caution that you might hit issues with Mixcloud's rate limit if you've got more than one or two shows needing published, and at the moment the system doesn't handle that situation well (#7).

Thanks. Do you know what those limits are give or take? I will only do a cron once a day for this action and I have around 5 to 6 mixes daily upload.

I'm not sure. Mixcloud don't publish them and it's not happened often enough for me that I've been able to measure it.


Question

This is not an issue for your code.  What I want to ask is that: what is the name of this dataset? Do you publish it and what i need to cite when i use this dataset.

Hi! I collected the data myself, you can read about it here: https://medium.com/@sullyfchen/how-a-high-school-junior-made-a-self-driving-car-705fa9b6e860
As for citations, you should follow your publisher's guidelines.


Cli rename

Renames the CLI nuget package to Microsoft.Web.LibraryManager.Cli
Also fixes up NuGet properties for Copyright for all packages and GitCommitId for the CLI package.

Installing the locally built package and testing out the libman command:


added logo component and make logo spin

Fixes Issue
PR fixed issue #84
Changes proposed

[x] Create a component named Logo in the components folder that implements the screenshots below.
[x] It should accept a size as prop for the different sizes on the header and footer.
[x] The logo should rotate similar to how it does in a fresh create react app installation [as shown on this GIF]
(https://opensource.com/sites/default/files/uploads/react.gif).
[x] Obtain the logo from the Figma design. Use THIS VIDEO as a
guide

SCREENSHOTS
Figma Design
Acceptance Criteria

[x] The implementation should match the design.

Screenshots

Note to reviewers
the spining of the logo is perform using the tailwind css animation-spin class

Thanks boss... Hope it's ok now


Added support of using trackingSubmodules in the DSL for git submodules.

I followed the same implementation of recursiveSubmodules.
trackingSubmodules is the option to keep tracked git submodules updated to tip of branch

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

Thanks! I squashed your commits and merged them manually.


SD on-device perf test hangs on Aug 9/10, 2023

Describe the bug
SD on-device perf test hangs on Aug 9/10, 2023
To Reproduce

Run checkpoint: https://github.com/tenstorrent-metal/tt-metal/commit/ce1d38fbbe11f9b6b6c5e9ea51ba541a4d8f496c
See logs in post-commit perf pipeline test run as follows which fail in SD pipelines

@muthutt if this is stale please confirm and close


Lost project settings

ISSUE
Project settings have gone AWOL. Provide documentation for how to upgrade from previous setup
Environment

OS: Windws;
Atom: 1.14.1;

Steps
Installed latest version 1.0.1 and all project settings have been nuked :-1: Nothing in the right hand pane at all

hey, i need to fix it. see #115 please

Please update to 1.0.3 sorry about this...

@pete-hotchkiss, any update?

Sorry - crazy afternoon. The utils > conversion trick worked a treat :+1:


Calyx does not correctly support zero bit values

Zero bit values are useful for cases where memories have a single value, and therefore do not need an address port. Currently memories will need idx_bits to be set to at least 1 to ensure no zero bit values are created. This makes memory generators more complicated and introduces extra unnecessary wires.
Zero bit values can be treated as if they do not exist, and should likely be removed before calling a backend (Verilog specifically does not support zero bit values). Currently, Calyx fails during verilog generation and gives an error about overflow on subtraction.
The most immediate use case for this is to allow the AMC frontend to support memories with a single value.

I don't think that would be too complex, but can registers be external in the same way as memories?

Ah, if that is the only limitation then we should change registers to also accept @external attributes on them. Should be straightforward since we just need to emit readmemh and writememh calls in the simulation backend!
If that would solve the problem @andrewb1999, can you open a new issue about it? We can keep this one open as a separate question.
CC @EclecticGriffin @sampsyo since this affects semantics

@calyxir/semantics (because I just made a team)

Interesting point about the Verilog implementation… I guess the overall question is: do we need to eliminate all 0-bit signals before emitting Verilog? (That is, does Verilog (or do common Verilog implementations) not support the creation of 0-bit wires, even if they are never read or written?) That seems likely and, if so, it seems like there are two parts to coping with this:

Primitives themselves. The salient case, of course, is seq_mem_d1 as mentioned above; we would need to do something (perhaps in a compiler pass) to replace the seq_mem_d1 with something else (such as std_reg). I'd be tempted to say we could handle this internal to the primitive, without an actual compiler pass, but we'd need to eliminate the zero-width address port from the cell's interface too, which doesn't seem possible without a Calyx program transformation.
Elsewhere. The Calyx code that uses such a primitive will contain assignments to zero-width ports. The aforementioned pass would eliminate the relevant ports, so we would need to similarly remove any assignments involving those ports in client code.

Anyway, I guess all I'm saying is that this points in the direction of a compiler pass that eliminates zero-width wires, if we believe we must expunge them before emitting Verilog?

firrtl also has a pass to remove 0 width elements before emitting Verilog: https://github.com/ucb-bar/firrtl2/blob/b7e7fe88f10159d7350623554f85e0b05185876a/src/main/scala/firrtl2/passes/ZeroWidth.scala


Producer connection error crashes app

Hello, I'm trying to implement a simple producer for pushing messages to Kafka from my application. but whenever the producer can't connect it throws an error that crashes my app and I can't seem to catch the on connection error from kafkajs. How to properly handle connection error

Everything will be propagated up to producer.connect and producer.send, so essentially:
const main = async function () {
  const kafka = new Kafka(...)
  const producer = kafka.producer(...)

  try {
    await producer.connect()
    await producer.send(...)
  } catch (error) {
    console.error(`Failed to send message to Kafka: ${error.message}`, { error })
    throw error
  }
}

main()
  then(() => console.log('Application successfully executed'))
  .catch(error => console.error('Application exited with unhandled exception', { error }))

You have a more complete example here: https://github.com/tulios/kafkajs/blob/master/examples/producer.js


How to contribute with docs?

I would like to add an example about how to load some models (gltf/dae). Is there some rules or a template to do a PR to the docs site?
Amazing work for the docs, I really like it :)

@Darkensses We are just starting to build the site, I would imagine for now it would go here:
https://github.com/react-spring/r3f-website/tree/master/src/docs/recipes
There are some other docs here you can copy a template from, This is still all under development. But I do not see a reason why you couldn't open a PR to the above location.

Hey!
As @Fasani  said it would be awesome if you could contribute to the docs and feel free to add some docs :)
I added a section in the readme explaining how as you also need to update the sidebar.yaml
https://github.com/react-spring/r3f-website#how-to-add-docs


Should WaitForTasksAsync throws by default ?

I'm doing some review on the code and came to this method
https://github.com/meilisearch/meilisearch-dotnet/blob/b285f324aa94d725cefc70bd8673f42ecef277e3/src/Meilisearch/TaskEndpoint.cs#L70-L91
Don't you think that this method should return some sort of Result object like this instead of throwing :
public class AwaitedTaskResult
{
     public Exception Exception { get; set; }
     public TaskResource TaskResource { get; set; }
     public bool HasCompleted => TaskResource.Status == TaskInfoStatus.Succeeded;
     public bool HasError => Exception != null;
}

The main idea is, that a task could take more time to finish on the server, but this is not an error from the server, it is just taking more time.
Instead of writing
try
{
   await client.WaitForTaskAsync(taskUid);
}
catch (Exception ex)
{
   // do something with the exception
}

We could write
var res = await client.WaitForTaskAsync(taskUid);
if (res.HasError)
  throw res.Exception;

Doing this avoid using exceptions for the control flow, this avoir using try catch blocks if they just want to silent the error.
The main question here is, should this method throws when timeout is reached instead of always returning an object like AwaitedTaskResult ?

Hi @juchom,
Thank you very much for opening this issue, it is very interesting. Indeed, it is not a server error but there is no specific reason for it to take time and most importantly this method was created exclusively for testing and is not intended to be used outside. However, I think this question could be of interest to the rest of the @meilisearch/integration-team

Agreed @alallema. In most of our SDKs, we have a similar piece of code, but we use it only to test, and we try not to advertise it too much because I think this could be very dangerous if the developer is not cautious.

Actually, developers may want to wait for a task (Meilisearch side) to finish and know the result.
If Meilisearch is on error for some reason, we have to know something wrong happened.
This polling method is interesting for developers, this avoid them to develop their owns.
I agree with you, this one is dangerous and mainly because it throws if something went wrong. Having it always returning an object with some helpers methods to know why the final result is a failure would be a nice option.
We could also had a boolean parameter bool throwOnError = false that can be turned on for testing to avoid extra checks in tests.
 public async Task<AwaitedTaskResult> WaitForTaskAsync(
     int taskUid,
     double timeoutMs = 5000.0,
     int intervalMs = 50,
     bool throwOnError = false,
     CancellationToken cancellationToken = default)

Hi @juchom,
I really like the idea of adding bool throwOnError = false but I'm afraid that it will encourage contributors to use this function. Again, Meilisearch is asynchronous and this function will force it to be synchronous by making sure the operation is completed, which could be dangerous in production. So we don't recommend it at all, except for testing purposes.
But we could totally think of a way to handle and return errors differently, I agree with that.

I understand why you want to encourage a fire and forget strategy for async server side operations.
In this case, should this method stay in the client project ? If no, it can be moved to the unit tests project, if you want to prevent its usage.

Since this question has been forwarded to another repo and discussed, I'll close it.


Give CODEOWNERS file an owner in CODEOWNERS

Specifically give the CODEOWNERS file an owner.

The codeowners linter run finished and passed. It's the only thing testing these changes and I'm going to merge without waiting for the other things running to complete since they don't matter for this particular change.


PTC accounts

With PTC accounts seeming to be instantly banned is it at all possible to use this without logging into an account?

I dont think it would. You kinda need the account to get Niantics API information if i am correct.

Does using bluestacks get you banned too?

it's possible.
if they recognize that your device is a virtual one -> they know that the GPS signal is probably faked -> they maybe ban your account.

I'll try using a fake PTC account on it and check, I'm guessing it will ban though

Jw does using a ptc account generator will be all instant banned?

Very likely, im not even scanning at all and they're showing up as banned

Seems you have to login to the app and play a bit before a new PTC account works. I went to the point where you are asked to visit a pokestop but did not do so. Scanning started working.


[DO NO MERGE] Test theory1

Summary of the changes

Fixes:

Apologies opened this as a full PR, not a draft. Ignore any notifications from it.


Svelte package

This is a recreation of the #606 PR, without the changes to @trigger.dev/core.

The @trigger.dev/svelte package can be tested as we've created a release at version 0.0.0-svelte-test-20231206141434. To test the package, make sure to set all the @trigger.dev/* packages to the same version of 0.0.0-svelte-test-20231206141434:
<EMAIL_ADDRESS>"0.0.0-svelte-test-20231206141434",
<EMAIL_ADDRESS>"0.0.0-svelte-test-20231206141434",
<EMAIL_ADDRESS>"0.0.0-svelte-test-20231206141434",

This didn't receive enough feedback from Svelte users to get merged and now v3 doesn't require framework packages.


Support pipelines as graphs of components

In #229 and related slack discussion today, @jeremyliweishih and @angela97lin were chatting about whether we should require pipelines to have exactly one estimator.
Currently, it appears we expect a pipeline to consist of a single string of components to be evaluated linearly, with exactly one estimator at the end. In PipelineBase::predict, we call transform on every component in the line, then call predict on the estimator. self.estimator is currently used in predict, predict_proba and feature_importances in ways which are consistent with that expectation.
We can imagine pipelines where:

The estimator isn't the final component in the pipeline
There are multiple estimators in the pipeline (Perhaps its easier or more clear to do that instead of defining a custom component to implement that)
There are multiple preprocessing pathways of components (which presumably eventually merge together)
There's no estimator at all; the pipeline in question is just doing some preprocessing or feature extraction (this wouldn't be useful in the automl leaderboard as we currently envision it)

Questions:

Which of those cases should we plan to support?
What invariants should we check on pipeline structure?
How can we change our code to enforce them but allow some of the cases described here?
The answers here may take a while to implement. What if anything do we do in the meantime?

Implementation Plan
Tasks

Implement ComponentGraph class with unit tests — 2 weeks
Update PipelineBase to use ComponentGraph object as well as component_graph list — 4 weeks

Key Dates
Aiming for Nov release.
*Goal
*
Nov 18th (6 weeks).
Stretch Goal
Stretch goal: Nov 4th (4 weeks)

Project design doc: https://alteryx.quip.com/YLX3ABQcGUkM/Pipelines-as-DAGs-Design-Doc

Update: had great discussion with @eccabay and @kmax12 yesterday, learned some more about requirements and compatibility considerations. We spent a while discussing the format for inputting the graph structures. Notes here.
Next steps

Input format: we’ll sleep on it. Decide next week.
Let’s keep ComponentGraph hidden from users. We can still use it.
Write up doc which outlines the options, poll evalml team

This epic is no longer needed.

This epic is no longer needed.


[KOGITO-9029] Rocksdb addon for quarkus

Rockds db addon for quarkus.
See modified example for testing it https://github.com/kiegroup/kogito-examples/pull/1648

(tests) - serverless-workflow-examples job #763 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer
export BUILD_MVN_OPTS_CURRENT=
build-chain build cross_pr -f 'https://raw.githubusercontent.com/kiegroup/kogito-pipelines/main/.ci/pull-request-config.yaml' -o 'bc' -p kiegroup/kogito-examples -u https://github.com/kiegroup/kogito-runtimes/pull/2946 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-runtimes.tests.downstream.serverless-workflow-examples/763/display/redirect
Test results:

PASSED: 77
FAILED: 1

Those are the test failures:

org.kie.kogito.examples.DataIndexRestIT.testDataIndexRest
1 expectation failed.JSON path data.ProcessInstances[0].state doesn't match.Expected: is "COMPLETED"  Actual: ACTIVE

(tests) - serverless-workflow-examples job #765 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer
export BUILD_MVN_OPTS_CURRENT=
build-chain build cross_pr -f 'https://raw.githubusercontent.com/kiegroup/kogito-pipelines/main/.ci/pull-request-config.yaml' -o 'bc' -p kiegroup/kogito-examples -u https://github.com/kiegroup/kogito-runtimes/pull/2946 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-runtimes.tests.downstream.serverless-workflow-examples/765/display/redirect
Test results:

PASSED: 77
FAILED: 1

Those are the test failures:

org.kie.kogito.examples.DataIndexRestIT.testDataIndexRest
1 expectation failed.JSON path data.ProcessInstances[0].state doesn't match.Expected: is "COMPLETED"  Actual: ACTIVE


Fix weakref pickling error in tutorials.

Move clear_cache import inside of worker function. This avoids a weakref pickling error when using Dask.

Codecov Report

Merging #516 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #516   +/-   ##
=======================================
  Coverage   86.46%   86.46%
=======================================
  Files          73       73
  Lines        6300     6300
  Branches     1287     1287
=======================================
  Hits         5447     5447
  Misses        676      676
  Partials      177      177

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dba8f73...35ff91e. Read the comment docs.

uncontroversial, thanks


cargo watch failure with failed to initialize proxy connection: IoFailed

Bug Description
if any application fails inside cargo watch, mirrord fails to re-attach with the next iteration of the app.
e.g., mirrord exec -f .mirrord/mirrord.json -- cargo watch -x 'run --bin billing-api -- --dev' if the billing-api bin fails in runtime, any next watch trigger will result in this error:
[Running 'cargo run --bin billing-api -- --dev']
thread '<unnamed>' panicked at mirrord/layer/src/lib.rs:318:22:
failed to initialize proxy connection: IoFailed(Os { code: 111, kind: ConnectionRefused, message: "Connection refused" })
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
mirrord layer setup panicked

Steps to Reproduce

create a --bin project with cargo
add

use std::time::Duration;
use std::thread;

fn main() {
    thread::sleep(Duration::from_millis(4000));

    Err("intentional error").unwrap();
}

run mirrord exec -- cargo watch -x run
once the run fails, remove the Err(...) line, then save
should get mirrord layer setup panicked error

Backtrace
stack backtrace:
   0: rust_begin_unwind
   1: core::panicking::panic_fmt
   2: core::result::unwrap_failed
   3: core::result::Result<T,E>::expect
   4: mirrord_layer::layer_start
   5: mirrord_layer::layer_pre_initialization
   6: mirrord_layer::mirrord_layer_entry_point::{{closure}}
   7: std::panicking::try::do_call
   8: __rust_try
   9: std::panicking::try
  10: std::panic::catch_unwind
  11: mirrord_layer::mirrord_layer_entry_point
  12: mirrord_layer::mirrord_layer_entry_point___rust_ctor___ctor::mirrord_layer_entry_point___rust_ctor___ctor
  13: <unknown>
  14: <unknown>
  15: <unknown>
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
mirrord layer setup panicked

Relevant Logs
No response
Your operating system and version
ubuntu
Local process
cargo-watch
Local process version
No response
Additional Info
No response

Thanks for reporting this. What mirrord version is being used?

@aviramha mirrord 3.77.0 ... but looks like it's fixed in 3.78.2.. damn... now it's definitely one of my top 3 favorite tools <3
anyway, in-case someone search for mirrord + rust integration/example, this might be helpful, so just dropping it here:
# https://taskfile.dev/usage/
version: "3"

tasks:
  # cargo check for failing fast on build time errors
  cargo:check:
    cmds:
      - touch .trigger # add .trigger in .gitignore
      - cargo watch -x check -s 'touch .trigger'
    internal: true
  cargo:watch:
    cmd: >-
      mirrord exec -f .mirrord/mirrord.json -- cargo watch
      --no-vcs-ignores -w .trigger
      -x 'run'
    internal: true
  cargo:dev:
    deps:
      - cargo:check
      - cargo:watch

Awesome :) Kudos to @Razz4780 for a great fix


Updating and documenting Unit Test and Component norms

Problem statement
Testing components currently is difficult (requires more code to test) due to components fetching data and processing it. If we separate these into distinct responsibilities it will make it easier to test the core programming that is in the processing side.
What you need to know

Acceptance criteria

[ ] Proposal documents created for unit tests and component norms (including when to write unit tests and where they should be documented)
[ ] Project updated to conform to those new norms
[ ] All current tests still pass

Impacted by #10850

Pausing to waiting on conversation about moving away from our SPA framework


bugfix: cdn cannot re-download uncompleted task with header param

Signed-off-by: lowzj<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?

fixes: #1380
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #1381 into master will decrease coverage by 0.01%.
The diff coverage is 26.31%.

@@            Coverage Diff             @@
##           master    #1381      +/-   ##
==========================================
- Coverage   51.26%   51.25%   -0.02%
==========================================
  Files         135      135
  Lines        8908     8915       +7
==========================================
+ Hits         4567     4569       +2
- Misses       3964     3968       +4
- Partials      377      378       +1

Impacted Files
Coverage Δ

supernode/httpclient/origin_http_client.go
48.11% <0.00%> (-1.89%)
:arrow_down:

supernode/daemon/mgr/cdn/downloader.go
81.81% <100.00%> (+2.87%)
:arrow_up:

supernode/daemon/mgr/scheduler/manager.go
21.91% <0.00%> (-0.69%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed1145f...516d62f. Read the comment docs.

I do have a general question. Header is usually typed with map[string][]string.
https://github.com/golang/go/blob/fca286bed3ed0e12336532cc711875ae5b3cb02a/src/net/http/header.go#L21
And it looks like there is a builtin Clone in standard library.

I do have a general question. Header is usually typed with map[string][]string.
And it looks like there is a builtin Clone in standard library.

Yes, the arg headers will be parsed into http.Header in the supernode/httpclient. I think that it's better to change the content after parsing.

And it looks like there is a builtin Clone in standard library.

The Clone method is not public until go version 1.13.

The Clone method is not public until go version 1.13.

Oh, good to know. If we're using go1.13 for compilation, then I think it is nice to align with it. Otherwise, I think we could just copy it over.

LGTM.


Menu(s) working improperly

Main Menu:

Selecting the Level Select Menu changes to improper scene rather than adding it as a child.

Pause Menu:

Does not have a continue button
will not be able to save properly it changes to improper scene rather than adding it as a child.

Level Select Menu:

Changes to improper scene rather than adding it as a child.

Added changes in recent push to structure branch, new bug added.


Please remove the 💅 from the package.json description

The special character, while fancy to have is preventing us from importing the library into offline third party repos like Artifactory.
I don't think this request is much of an inconvenience, but it has been for us when we try to import the latest styled-components offline.

Sure, send a PR


Host restarting automatically after Booting Windows using QEMU

I'm starting a Windows Container on Ubuntu 22.04 and it restarts automatically when the container starts:
`❯ Starting Windows for Docker v2.04...
❯ For support visit https://github.com/dockur/windows
❯ Downloading Windows 11...
[i] Downloading Windows media from official Microsoft servers...
[i] Downloading Windows 11...
[!] Microsoft blocked the automated download request based on your IP address. Please check the FAQ on how to boot from a local file and manually download this ISO in a web browser here: https://www.microsoft.com/en-us/software-download/windows11
[!] 1 attempted download(s) failed! Please re-run Mido with these arguments to try downloading again (any partial downloads will be resumed): win11x64
[+] Finished! Please see the above errors with information
❯ Failed to download Windows 11 using Mido, will try a different method now...
❯ Downloading product information from Microsoft...
❯ Downloading Windows 11...
/storage/tmp/win11x64.esd                                  100%[======================================================================================================================================>]   4.54G  35.5MB/s    in 2m 4s
❯ Extracting Windows 11 bootdisk...
❯ Extracting Windows 11 environment...
❯ Extracting Windows 11 setup...
❯ Extracting Windows 11 image...
❯ Adding XML file for automatic installation...
❯ Building Windows 11 image...
❯ Creating a 64G growable disk image in raw format...
❯ Booting Windows using QEMU emulator version 8.2.1 ...`
and restarts

Thank you for the response. I believe that in this case, it's not entirely isolated due to virtualization in KVM.
But I have a theory based on your response: I'm using XCP-ng Docker VM with nested virtualization, and the problem maybe it's not on docker container.


DOMException thrown on destroy()

Bug description
I seem to be getting the following error when calling destroy() on a multitrack object:
Uncaught (in promise) DOMException: Failed to execute 'decodeAudioData' on 'BaseAudioContext': Unable to decode audio data
From what I can see, destroy loops through the audio array and sets src = '' for each audio. This works for all HTMLAudioElement audios, but for WebPlayerAudios (of which the placeholder is one) setting src = '' results in WebAudioPlayer fetching '' and trying to decode the result which results in the above error.
Loving the library so far btw!
Environment
React App
Minimal code snippet
const multitrack = Multitrack.create(
    [
        {
            id: 0,
            url: "/example.mp3",
            startPosition: 0
        },
        {
            id: 1,
            url: "/example2.mp3",
            startPosition: 0
        }
    ],
    {
        container: document.querySelector("#multitrack"),
        minPxPerSec: 10, // zoom level
        rightButtonDrag: false, // set to true to drag with right mouse button
        cursorWidth: 2,
        cursorColor: '#D72F21',
        trackBackground: '#2D2D2D',
        trackBorderColor: '#7C7C7C',
        dragBounds: true,
        envelopeOptions: {
            lineColor: 'rgba(255, 0, 0, 0.7)',
            // lineWidth: 4,
            dragPointSize: 8,
            dragPointFill: 'rgba(255, 255, 255, 0.8)',
            dragPointStroke: 'rgba(255, 255, 255, 0.3)',
        },
    }
)

multitrack.on("canplay", () => {
    multitrack.destroy()
})

Expected result
Multitrack gracefully destroys it's audios and Wavesurfers
Obtained result
Uncaught (in promise) DOMException: Failed to execute 'decodeAudioData' on 'BaseAudioContext': Unable to decode audio data

Oh, good catch!

@katspaugh have the same, make conversation https://github.com/katspaugh/wavesurfer.js/discussions/3410 and provide code

Hi @katspaugh, pls can you fix this bug, because it provide a lot of problems with updating multitrack data, I mean when I load one data then on the same page load another it cant be updated because of this bug

Hi, @katspaugh. I have the same problem

Hello, @katspaugh, I have this problem too

@katspaugh hey, got same issue, would be great if you look at it) Thanks

Thanks for asking all your collegues to chime in, the more the merrier. This is now fixed in 0.4.8.


Please white-list ae01.alicdn.com

This entry removes images from the aliexpress.com website.

Hi @Toontje, we don't block ae01.alicdn.com...
Closing.


Cannot be able to reproduce model's result on test set

I cannot reproduce my result on the test set. When I load the weight back, my model doesn't work consistently
I've run my code on google colab, based on the paper "Neural Architectures for Named Entity Recognition"
I have added the code to fix some initializers

import numpy as np
import tensorflow  as tf
import random as rn
import os
os.environ['PYTHONHASHSEED'] ='0'
np.random.seed(42)
rn.seed(12345)
session_conf = tf.ConfigProto(intra_op_parallelism_threads=1, inter_op_parallelism_threads=1)
from keras import backend as K
tf.set_random_seed(1234)
sess = tf.Session(graph=tf.get_default_graph(),  config=session_conf)
K.set_session(sess)
My mode is bellow:

def building_ner(num_lstm_layer, num_hidden_node, num_hidden_node_char, dropout, droupout_char, time_step, time_step_char,\
                vector_length, vector_length_char, output_length):
    char_inputs = Input(shape=(time_step, time_step_char, vector_length_char), name='char_input')
    inputs = [char_inputs]
    char_mask = Masking(mask_value = 0.0, input_shape = (time_step_char, vector_length_char))(char_inputs)
    char_embeddings = TimeDistributed(Bidirectional(LSTM(units=num_hidden_node_char,return_sequences = False, dropout = droupout_char,\
                                                            recurrent_dropout = droupout_char),\
                                                            merge_mode='concat'))(char_mask)
    word_inputs = Input(shape = (time_step, vector_length), name = 'word_input')
    inputs.append(word_inputs)
    word_embeddings = keras.layers.concatenate([char_embeddings, word_inputs])
    z = Masking(mask_value = 0.0)(word_embeddings)
    for i in range(num_lstm_layer - 1):
        z = Bidirectional(LSTM(units=num_hidden_node, return_sequences=True, dropout = dropout, recurrent_dropout = dropout))(z)
    z = Bidirectional(LSTM(units=num_hidden_node, return_sequences=True, dropout = dropout, recurrent_dropout = dropout),\
                             merge_mode='concat')(z)
    z = TimeDistributed(Dense(output_length))(z)
    crf = CRF(units = output_length, learn_mode = 'join', test_mode = 'viterbi', sparse_target=False)
    pred = crf(z)
    model = Model(inputs=inputs, outputs=pred)
    model.compile('adam', loss=crf_loss, metrics=[crf_viterbi_accuracy])
    return model
ner_model = building_ner(num_lstm_layer, num_hidden_node, num_hidden_node_char, dropout, droupout_char, max_length, max_length_char, \
                                    vector_length, vector_length_char, output_length)

I use data generator for train,dev and test set
def data_generator(word_list, pos_id_list, chunk_id_list, tag_id_list, steps_per_epoch):
    while True:
        for i in range(steps_per_epoch):
            word_list_batch = word_list[i*batch_size:(i+1)*batch_size]
            pos_id_list_batch = pos_id_list[i*batch_size:(i+1)*batch_size]
            chunk_id_list_batch = chunk_id_list[i*batch_size:(i+1)*batch_size]
            tag_id_list_batch = tag_id_list[i*batch_size:(i+1)*batch_size]
            ## Create embedded matrixes
            word_batch = construct_tensor_word(word_list_batch, unknown_embedd, en_model, embedd_dim,\
                                                                    max_length)
            char_batch = construct_tensor_char(word_list_batch, unknown_embedd_char, char_dict, embedd_dim_char, \
                                                max_length, max_length_char)
            pos_batch = construct_tensor_onehot(pos_id_list_batch, max_length, dim_pos)
            chunk_batch = construct_tensor_onehot(chunk_id_list_batch, max_length, dim_chunk)
            tag_batch = construct_tensor_onehot(tag_id_list_batch, max_length, dim_tag)
            input_batch = np.concatenate((word_batch, pos_batch), axis = 2)
            input_batch = np.concatenate((input_batch, chunk_batch), axis = 2)
            output_batch = tag_batch
            yield([char_batch, input_batch], output_batch)
train_generator = data_generator(word_list_train, pos_id_list_train, chunk_id_list_train, tag_id_list_train, steps_per_epoch_train)
dev_generator = data_generator(word_list_dev, pos_id_list_dev, chunk_id_list_dev, tag_id_list_dev, steps_per_epoch_dev)
test_generator = data_generator(word_list_test, pos_id_list_test, chunk_id_list_test, tag_id_list_test, steps_per_epoch_test)
vector_length = embedd_dim + dim_pos + dim_chunk
vector_length_char = embedd_dim_char
output_length = dim_tag

The code I use to train, test and load the weights back is bellow:
ner_model.load_weights(path + '/model/checkpoint-07-0.9972.h5')
# ner_model = load_model(path + '/model/checkpoint-13-1.00.h5', custom_objects = custom_objects)
# ner_model = load_model(path + '/model/ner_fasttext_model.h5', custom_objects=custom_objects)
print(ner_model.summary())

early_stopping = EarlyStopping(monitor='val_crf_viterbi_accuracy', patience=patience, restore_best_weights=False)
filepath = path + '/model/checkpoint-1-{epoch:02d}-{val_crf_viterbi_accuracy:.4f}.h5'
checkpoint = ModelCheckpoint(filepath, monitor='val_crf_viterbi_accuracy', verbose=1, save_best_only=False, save_weights_only = True)
callbacks_list = checkpoint
# history = ner_model.fit_generator(train_generator, steps_per_epoch = steps_per_epoch_train, epochs=40,\
#             validation_data = dev_generator, validation_steps = steps_per_epoch_dev, callbacks = [early_stopping, callbacks_list])
print('Testing model...')
predicts=[]
# ner_model.save(path + '/model/ner_fasttext_model.h5')
answer_1 = ner_model.predict_generator(test_generator, steps = steps_per_epoch_test)

But the first time I run, the result is 95%. After resetting runtime, and load the model back, the result is not consistent, and only 93% or 92%. Can anyone point out what is wrong

Please fill the issue template here. Could you update them if they are relevant in your case, or leave them as N/A? Along with the template, please provide as many details as possible to find the root cause of the issue. It would be great if you can provide a small code to reproduce the error. Thanks!

I realize that if I use the result of random function from other google colab cell or other imported scripts, the result won't be consistent. In other words, I have to write all the random function in the same google colab cell

there was also error when I use a shuffle function, which shuffle the inputs in one batch, for data generator


How to declare mobx prop types using typescript, react and mobx

I have a functional root component like below
const RootPage: React.FC = () => {
    const classes = useStyles();

    return (
        <React.Fragment>
            <Sidebar/>
            <Grid container className={classes.fullHeight}>
                <Map/>
            </Grid>
        </React.Fragment>
    )
};

and my map component is looking like below
interface IMapProps {
    map:MapStore;
}

const Map : React.FC<IMapProps> = (props)=>{
    return (
        <div>
            {props.map}
        </div>
    )
};

export default (inject('map'))(observer(Map));

I am expecting IMapProps to obviously come from the mobx injection; however, typescript is throwing error saying that I should provide the props in the root component. Error looks like below
react_front_1    | Property 'map' is missing in type '{}' but required in type 'IMapProps'.  TS2741
react_front_1    |
react_front_1    |     22 |             <Sidebar/>
react_front_1    |     23 |             <Grid container className={classes.fullHeight}>
react_front_1    |   > 24 |                 <Map/>
react_front_1    |        |                  ^
react_front_1    |     25 |             </Grid>
react_front_1    |     26 |         </React.Fragment>
react_front_1    |     27 |     )

How do I provide types for props that come from the mobx store?

If you search through issues here, you will find some solutions around typing inject correctly.
However, you might consider abandoning inject if you want to save yourself some soul health :)

See #256: You will have the make map optional, map?: MapStore, and at non-null assertions inside your component if needed; {props.map!}.
useContext is an easier way to get type-safe injection in FC's, so we recommend to use that now.

@serendipity1004 I am sorry if my response sounded a bit harsh, that wasn't the intention. As the link states, there is nothing wrong about inject and you keep using it, but be prepared for some extra battles that can be solved more easily with Context.


Minor wording modifications

Not sure if 'web site' is one word or two, but keeping it consistent with the first reference in the doc.

@AErmie : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Use the selector atom-pane-axis.horizontal instead of the pane-row class.

In index.less: Use the selector atom-pane-axis.horizontal instead of the pane-row class.

See #5