Text gets blurry when resizing the viewport with the canvas_items stretch mode

Tested versions

Reproducible in: v4.2.1.stable.official [b09f793f5]
Also reproducible in: v4.1.3

System information
Godot v4.2.1.stable - Windows 10.0.19045 - GLES3 (Compatibility) - NVIDIA GeForce GTX 950M (NVIDIA; <IP_ADDRESS>18) - Intel(R) Core(TM) i5-6300HQ CPU @ 2.30GHz (4 Threads)
Issue description
One of the main advantages of the canvas_items stretch mode (née 2d) is that it scales the UI automatically while keeping the shapes and fonts crisp at any window size. It's particularly useful when you want to keep the same size ratios in your UI regardless of resolution. This is illustrated by the attached project, which I've created for both Godot 3 and Godot 4.
Here are two screenshots taken on Godot 3 (view them at 100% size to get a better idea):

Godot 3.5.3: project run at its base viewport size (1024x576)
Godot 3.5.3: same project when run fullscreen (1366x768)

The text remains crisp in Godot 3 when the viewport size increases or decreases.

However, in Godot 4, the behavior is different and fonts get slightly blurry at any resolution other than the viewport size defined in the settings.

Godot 4.2.1: project run at its base viewport size (1024x576)
Godot 4.2.1: same project when run fullscreen (1366x768)

The same behavior can be observed when resizing to a smaller viewport size, with blur being particularly noticeable.

Godot 3.5.3:
Godot 4.2.1:

Steps to reproduce

Load the Godot 4 MRP
Run the project, the default viewport size is 1024x576
Resize the window or expand it, or set the project to run fullscreen
Notice that the text is crisp at the base resolution, but blurry at smaller/larger resolutions
You can compare with the Godot 3 project where fonts remain crisp regardless

Minimal reproduction project (MRP)

Godot 4 project: StretchTest_Godot4.zip
Godot 3 project for comparison: StretchTest_Godot3.zip

I'm having the same problem and can confirm it:
v4.2.1.stable.mono.official [b09f793f5]

Here is a Minimal reproduction project (MRP)
Bug.zip

@conde2 This is an unrelated issue: https://github.com/godotengine/godot/issues/54030

@Calinou, maybe its related to both, I just realized that the text in Labels gets blurry too, is it supposed to happen?

Ok after some research I found a topic in godot forum with the same problem I had:
https://forum.godotengine.org/t/blury-text-on-label/42452/2
After changing this settings I was able to get my game running crystal clear, not blurry interface and text
For anyone having the same problem, here is the settings I had to change:
theme/default_font_hinting=2
theme/default_font_multichannel_signed_distance_field=true
theme/lcd_subpixel_layout=0

For anyone having the same problem, here is the settings I had to change:

Note that when you enable MSDF font rendering, font hinting and LCD subpixel layout settings are ignored, so you don't need to change these.

I understand Im using the default fonts from godot 4.2 so It's definitely other problem. Should I open a new issue then?
Because I just want to add to the topic that the blurry was not in the editor it was in the game itself and after changing this settings the GAME become crystal clear.
So maybe this settings are affecting the game and shouldn't? For example in the GUI settings if you change the tooltip delay it also changes the in game tooltip delay.
If this is the way it's supposed to be I believe this option should be enabled by default or stated in the docs more clearly.

I have an issue with only tooltips becoming blurry. All other text and custom tooltips that we have implemented in Thrive (but made to look basically like the inbuilt ones) look fine when scaled and even their borders are non-blurry. So only inbuilt tooltips experience blurriness problems in text and their borders also look pixelated so it is not only the text that is impacted.
Should I open a separate issue about that? I couldn't find any issues specifically about blurry tooltips.

I have an issue with only tooltips becoming blurry.

This is already being tracked in https://github.com/godotengine/godot/issues/54030.

Thanks. I did see that issue before but there was so much discussion that I couldn't see that it would also be relevant for tooltips.

Having the same issue

I'm not sure if i'm missing something, is the following correct? I'm looking at labels with a dynamic font after porting from godot 3 to godot 4, while resizing a window to fullscreen.

in godot 3, the labels would render crisp if the stretch mode "viewport" was chosen. If the stretch mode was "2D", they would render badly with lots of artifacts, giving them a blurry feel.
in godot 4 there is no stretch mode "viewport" any more and dynamic fonts will always look bad when not running at the resolution set up in the project settings.
there is no workaround that has a result of a similar quality than what we had with godot 3 and there will be no change with that because it is not considered a bug?

I feel like there is probably some workaround that i am missing. I understand MSDF can help in some cases and be prohibitve in others.

Having the same issue when changing Window>Stretch>Scale in Project Settings with the disabled stretch mode. (Non-game applications use disabled stretch mode)
I have text with font size of 16px. When changing the stretch scale to 1.25x, the font would be 20px, but it looks blurry even though the font size is being scaled to an integer.


$(...).enhancedLovItem is not a function

When I run example application in our newly upgraded 19.1 instance, I see below error
$(...).enhancedLovItem is not a function

Please advise.

@aragorniiit
The example demo app is valid (tested on apex.oracle.com). If you have upgraded apex I would say you should check ORDS configuration - errors says it can't load file. You can confirm the issue by installing any other valid plugin from apex.world - the error will be same.

I suggest checking your ORDS configuration.


Pauli frames on circuits that measure [0,0,...,0] with 0% likelihood.

Pauli frames always operate with a measurement reference sample, and it seems the current implementation assumes this reference sample is [0,0,...,0].
For our case, mostly working with error correction, a zero syndrome is always a possibility and so this problem hasn't come up yet.
However, when the circuit being simulated on the Pauli frame measures all zeroes with 0% likelihood, the Pauli Frames gives the wrong answer.

I suggest we add an optional argument to the constructor that can designates a non all-zero reference.

I think it makes most sense to consider this a documentation issue. Pauli frames simulations inherently only provide samples with respect to a reference and we should put a few warning blocks in the documentation that this is the case, together with examples of how to make a reference simulation.
To the question of how to make a reference simulation... Let's start by documenting how it can be done right now, by running mctrajectory! separately. Then we can decide whether it is worth it to make it "built in" for the Pauli frame object.


Update the game over message

Update the game over message so people know how to play again!

I like the instruction given to the user on how to refresh the game, good thinking!


Add param

Description
Param works.
Testing
To test, try node index.js --project 'fr.wikipedia'

Ooh shoot. I didn't realize this was based off the timeout patch..

Sorry my bad merging this. I'll post a follow up.


Tab reordering drag and drop approach is confusing

I find it confusing from the point of user experience that tab reordering is visually implemented as regular drag and drop. It makes me feel that in addition to reordering I can:
a) detach a tab into its own window, like I'm used to do with web browser tabs;
b) drag a tab from one terminal window to other and thus move the tab between windows (again, like in web browsers);
c) and some users may even expect that they can drop a tab into some other app (e.g. embed it into a word document).
My opinion on this is unless implementing features mentioned above is on the roadmap, tab reordering should not allow dragging a tab outside of the tab panel. Instead, the tab being moved should slide within the tab row. A good example is how the tabs are visually sliding during reordering in MS Edge (Chromium version).
And even if tab detaching is planned, it can be done exactly the same as in Edge (Chromium), i.e. the tab header is not floating with the mouse, but is detached with tab content after significant mouse movement.

Thanks for the feedback! I definitely agree with the points you're making. Fortunately, tab tear-out is on the roadmap, but likely not until after 1.0. Before that, we should definitely just keep the tab in the row, with the sliding behavior. This is great feedback for the XAML team (and @teap in particular ☺).
I've filed https://github.com/microsoft/microsoft-ui-xaml/issues/1685 upstream to make sure this gets added to WinUI, and so we can ingest it ourselves.

Do you guys realize that tab reordering crashes terminal if it was run as an administrator?

Uh we definitely fixed a bug like that two whole versions ago. Can you confirm the version you’re on?

0.11.1121.0

0.11.1121.0
From: Dustin L. Howett (MSFT<EMAIL_ADDRESS>Sent: Thursday, April 23, 2020 11:59 PM
To: microsoft/terminal<EMAIL_ADDRESS>Cc: tstager<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [microsoft/terminal] Tab reordering drag and drop approach is confusing (#3734)
Uh we definitely fixed a bug like that two whole versions ago. Can you confirm the version you’re on?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fterminal%2Fissues%2F3734%23issuecomment-618801918&data=02|01||9a68c3fcaa644b8549f408d7e80c23a4|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637233011135428296&sdata=o7wchOb8h%2B%2Bau5YZigt77XKiFb1EbrUHk3qfWe%2F0WYM%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACCJ7A6AXIAPSCDVBLOCC5TROEL7RANCNFSM4JSDK2OA&data=02|01||9a68c3fcaa644b8549f408d7e80c23a4|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637233011135428296&sdata=pEb5i0qs729BenQS00VI0LEyni%2F8VissZ04jueKSy1s%3D&reserved=0.

https://github.com/microsoft/terminal/pull/5542
It looks like we regressed this when we were cleaning some stuff up.

Huh so I'm looking through the backlog here, and I honestly think we're gonna get to #1256 before the WinUI team is going to be able to get to  microsoft/microsoft-ui-xaml#1685. They're pretty swamped with Win11 work at the moment, and we've been making a lot of progress towards tear-out (see #5000).
I'm just going to close this for now. It's still a good idea for the WinUI TabView, but one we probably won't end up needing ourselves 😅


assetType not working

The following code from your sample with added assetType property doesn't change at all what's being presented. In both cases I'm given only photos. Am I doing something wrong or is it a bug?
Tested on iPhone 6+ with latest iOS 8
BSImagePickerController *imagePicker = nil;
if([sender tag] == 1) {
    imagePicker = self.imagePicker;
} else {
    imagePicker = self.darkImagePicker;
}
imagePicker.assetType = BSAssetTypeVideo;
[self.window.rootViewController presentImagePickerController:imagePicker
                                                    animated:YES
                                                  completion:nil
                                                      toggle:^(ALAsset *asset, BOOL select) {
                                                          if(select) {
                                                              NSLog(@"Image selected");
                                                          } else {
                                                              NSLog(@"Image deselected");
                                                          }
                                                      }
                                                      cancel:^(NSArray *assets) {
                                                          NSLog(@"User canceled...!");
                                                          [imagePicker dismissViewControllerAnimated:YES completion:nil];
                                                      }
                                                      finish:^(NSArray *assets) {
                                                          NSLog(@"User finished :)!");
                                                          [imagePicker dismissViewControllerAnimated:YES completion:nil];
                                                      }];

An update.
After you manually change the album, and switch back to the original one, videos are present. However this is possible only if you have other albums (by default you get only Photos)

Any  update?


Add boroughs to wof processing

Connects to https://github.com/mapzen/vector-datasource/issues/654
@zerebubuth could you review please?

:+1:


Pino instrumentation fails when using ES modules

What version of OpenTelemetry are you using?

@opentelemetry/api: 1.4.1
@opentelemetry/instrumentation: 0.41.0
@opentelemetry/instrumentation-pino: 0.34.0
@opentelemetry/sdk-node: 0.41.0
@opentelemetry/sdk-trace-base: 1.15.0

What version of Node are you using?
18.16.1
What did you do?
Attempted to instrument pino using either default or named imports.
What did you expect to see?
Trace information in the logs.
What did you see instead?
When using default imports, the application crashes when pino() is called. When using named imports, trace information is not added to the logs.
Additional context
We have minimal reproductions of the issues:

Default import: https://github.com/nlindley/otel-esm-examples/tree/master/pino-default
Named import: https://github.com/nlindley/otel-esm-examples/tree/master/pino-named

I think this is the same as https://github.com/open-telemetry/opentelemetry-js/issues/3976
For now you may be able to just use the previous version until we can provide a fix.

They reverted https://github.com/open-telemetry/opentelemetry-js/pull/4011 maybe you should do the same?

This appears to still be an issue. We may want to look towards a solution such as that proposed by https://github.com/open-telemetry/opentelemetry-js-contrib/pull/1694, as this seems to be a resolution difference within the ECMAScript Module Namespace Object versus that of the CommonJS resolved Namespace. This comment, especially the Aside, provides an excellent analysis relevant to the underlying issue.

are we sure this was fixed? It doesn't look like Pino is being instrumented, even with 0.34.4.
otel config
import {
  CompositePropagator,
  W3CTraceContextPropagator,
} from '@opentelemetry/core';
import {SimpleSpanProcessor} from '@opentelemetry/sdk-trace-base';
import {NodeTracerProvider} from '@opentelemetry/sdk-trace-node';
import {registerInstrumentations} from '@opentelemetry/instrumentation';
import {OTLPTraceExporter} from '@opentelemetry/exporter-trace-otlp-http';
import {HttpInstrumentation} from '@opentelemetry/instrumentation-http';
import {ExpressInstrumentation} from '@opentelemetry/instrumentation-express';
import {TraceExporter} from '@google-cloud/opentelemetry-cloud-trace-exporter';
import {PinoInstrumentation} from '@opentelemetry/instrumentation-pino';
import {FetchInstrumentation} from 'opentelemetry-instrumentation-fetch-node';
import {CloudPropagator} from '@google-cloud/opentelemetry-cloud-trace-propagator';
import {Resource} from '@opentelemetry/resources';
import {SemanticResourceAttributes} from '@opentelemetry/semantic-conventions';

const {
  // @ts-ignore
  default: {diag, DiagConsoleLogger, DiagLogLevel},
} = await import('@opentelemetry/api');
diag.setLogger(new DiagConsoleLogger(), DiagLogLevel.DEBUG);
const provider = new NodeTracerProvider({
  resource: new Resource({
    [SemanticResourceAttributes.SERVICE_NAME]: 'api',
    [SemanticResourceAttributes.SERVICE_VERSION]: '1.0',
  }),
});

provider.register({
  propagator: new CompositePropagator({
    propagators: [new W3CTraceContextPropagator(), new CloudPropagator()],
  }),
});

// const exporter = process.env.K_SERVICE
//   ? new TraceExporter()
//   : new OTLPTraceExporter({});

// const processor = new SimpleSpanProcessor(exporter);
// provider.addSpanProcessor(processor);

registerInstrumentations({
  instrumentations: [
    // not working: https://github.com/open-telemetry/opentelemetry-js-contrib/issues/1587
    new PinoInstrumentation({
      logHook: (span, record, level) => {
        console.log('HERE');
        record['resource.service.name'] =
          provider.resource.attributes['service.name'];
      },
    }),
    // new FsInstrumentation(),
    new FetchInstrumentation({
      onRequest: ({request, span}) => {
        span.updateName(`${request.method}: ${request.path}`);
      },
    }),
    new ExpressInstrumentation(),
    new HttpInstrumentation({
      requestHook: (span, req) => {
        // req can be of different types that don't share a common interface
        let path = 'url' in req ? req.url : '';
        path ?? ('path' in req ? req.path : '');
        span.updateName(`${req.method}: ${path}`);
      },
    }),
  ],
});

logs
@opentelemetry/api: Registered a global for diag v1.7.0.
@opentelemetry/api: Registered a global for trace v1.7.0.
@opentelemetry/api: Registered a global for context v1.7.0.
@opentelemetry/api: Registered a global for propagation v1.7.0.
@opentelemetry/instrumentation-http Applying patch for<EMAIL_ADDRESS>@opentelemetry/instrumentation-http Applying patch for<EMAIL_ADDRESS>

being called as an import on the first line of code

I think it is basically working. Here is a full run of npm run test-all-versions in a git clone running on my machine, FWIW: https://gist.github.com/trentm/853da0a159d0fcb8a09e05ac2282fcc3
@mbrevda Your log output shows @opentelemetry/instrumentation-http Applying patch for http and for https, but does not show it for pino. I'd expect to see that output from this code line if the instrumentation was picked up at all:
https://github.com/open-telemetry/opentelemetry-js-contrib/blob/60328af9009c911f8b6f63ae6add12612a8ccb3a/plugins/node/opentelemetry-instrumentation-pino/src/instrumentation.ts#L45
That suggests to me that this may be about import order, rather than about the recent change to support pino in ESM code. I'm not sure of that though. If import order was an issue, I thought @opentelemetry/instrumentation would diag.warn about pino already having been imported, and your log output doesn't show that either.
I see @ts-ignore in your posted code above. Is this TypeScript code that is being compiled to ESM? Are you able to post a small repro case that shows the compiled JS that is being executed. That might help pinpoint the issue.

I'd expect to see that output from this code line if the instrumentation

Same 😁
I think this repo should explain it. When running with import "./otel.mjs" in index.mjs, I get the warning about pino already being imported (and instrumentation doesn't work). When that's commented out and running node --import ./otel.mjs index.mjs, the warning doesn't even show.
Is my setup incorrect?

I am encountering the same issue. Reduced test case: https://github.com/OliverJAsh/esm-otel.
Presumably this has the same root cause as https://github.com/open-telemetry/opentelemetry-js-contrib/issues/1849.

Confirmed this related to the esm loading issues (especially with bundled code). So technically this does work


License for bsuccinct-rs

hi! nice work on these crates -- I'd like to use csf in my (commercial) project for building perfect hash tables in index files.
would you be open to licensing this repo with an MIT license?

All bsuccinct creates are Mit licensed - see their cargo.toml files.
Where did you find information that they use any other license?

oh whoops, I was looking for a LICENSE file but didn't check the Cargo.toml. thanks!


[Hold for #38025] [$1000] Chat - Email id not shown in full available space & after sending full email iID shown for public accounts

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.36
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Launch app
Tap in a report
Enter @ in compose box
Select an user from suggestions list
Note email id is not displayed occupying full space
Send the message

Expected Result:
After selecting an email ID from the user suggestion list, it should be displayed in full within the available space. Once sent, the full email ID should not be displayed.
Actual Result:
The selected email id from user suggestion list is not shown in full available space and after sending full email id is displayed.The selected email ID from the user suggestion list is not displayed in full within the available space. Additionally, after sending, the full email ID is still displayed
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/b78b686a-1d83-4555-a1eb-daf122688972
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~015976cfa3c5a4e481
Upwork Job ID:<PHONE_NUMBER>729029632
Last Price Increase: 2024-03-07

We think that this bug might be related to #vip-vsb
CC @quinthar

I am having trouble understanding this bug. Can you please rephrase the expected and actual results @kbecciv?

@MitchExpensify
Check the above screenshot taken from the issue description.
Bug 1
In the composer box email is broken into multiple lines due to a long email, but still, some space on the right side is there.
The same email uses the full available space after sending it in the message area

Bug 2

Additionally, after sending, the full email ID is still displayed

I don't get this properly. But I guess
After selecting a user for mentioning from the suggested options, the message should have had the user name in the message instead of the email ID if the user name is available.
Example @Mitch instead<EMAIL_ADDRESS>Can you confirm @kbecciv ?

Yes, correct! @Santhosh-Sellavel

Bump @MitchExpensify

We are still waiting for a confirmation from @MitchExpensify to move forward and proposals as well.
Unassigning as am planning for OOO

Ok got it! Yes lets fix this. I think it could fit in #vip-vsb

Thanks for digging into the issue @Victor-Nyagudi ! Going to add this as LOW to vip vsb while we wait on proposals

Switching to Weekly as this is LOW

@shubham1206agra I notice this is labelled Internal, double checking if you think this can be made External or not

Highlighting for proposals here https://expensify.slack.com/archives/C01GTK53T8Q/p1710107159468519

@shubham1206agra I also could not reproduce the second part of the bug in main. But, I could reproduce the first part of the bug. Looking into this a little more closely.

I think you misunderstood the problem here.

Oh Silly me! What a waste of my energy here 😓 . Hmmm. But this could be a potential improvement. Will post this in Slack and see if people like it.

Proposal
Please re-state the problem that we are trying to solve in this issue.
E-mail id is not shown in full available space as shown in the screenshot below

The second part of the issue (i.e. after sending email id) seems to be resolved in the latest main.
What is the root cause of that problem?
Here we set the styles for Composer using textInputCompose which sets the horizontal padding to 12 here. However, for smaller screens, real estate is very precious and the current value of horizontal padding of 12 waste away precious space which can be otherwise used for display of text. This seems to be the root cause of this problem.
What changes do you think we should make in order to solve the problem?
Since there is already a padding of 10 set for the neighbouring emoji, we can reduce the horizontal padding set for Composer. Also, since the current vertical padding of 5 seems good enough for small screen devices, we can set the horizontal padding also to 5 and save some precious real estate for smaller devices.
For this, we can add a style like this here
    smallTextInputComposeHorizontalPadding: {
        paddingHorizontal: variables.avatarChatSpacing - 7,
    },

And use this style for smaller screens like this for Composer here
                style={[styles.textInputCompose, isSmallScreenWidth && styles.smallTextInputComposeHorizontalPadding, isComposerFullSize ? styles.textInputFullCompose : styles.textInputCollapseCompose]}

Similar style change can also be made to ReportActionItemMessageEdit
Here is a comparison of how it will look before and after:

What alternative solutions did you explore? (Optional)
Alternatively, we can reduce the horizontal padding for all screen sizes if required. Also, if needed, we can further reduce the padding.

@shubham1206agra What do you think of this proposal? And I hope I am not way off here.

I think the issue is related to line breaks happening at @ and .

@shubham1206agra That is not seen in the latest main. So, I am confused.
Do you think there is still a pending issue to be resolved? Or it is all good here.

Sure. Will check on this.

Any update @rojiphil ?

Sorry for the delay in response here.
@shubham1206agra I was able to reproduce the issue. And it looked like a nasty bug and I am nowhere closer to solving this.

Shared with expert agency https://expensify.slack.com/archives/C03UK30EA1Z/p1710810646724379

Hi, Im Piotr from Callstack, I will start investigating this issue

Update: found the source of the issue, now Im working on suitable solution that is not too big of walkoround

What's the latest @Piotrfj ?

@shubham1206agra from what I see it's just native text wrapping behavior. There is no setting of that attribute that would change it exactly to what we want. Been trying to look for alternative solution but no luck for now. Right now I'm working on the second part of the issue and will consult the first one with others to find out if I'm missing something or not. That doesn't seem like to be connected to the live markdown though.

Update: I have tested if the EmailUtils (mentioned here: https://github.com/Expensify/App/issues/35725#issuecomment-1991004933) are running, but they are not and it looks like all the breaking is due to android native behavior.
I have a question about the second part of the issue (mentioned here: https://github.com/Expensify/App/issues/35725#issuecomment-1930735370). I not sure if current behavior is a bug to be honest, I have followed the path of the values and everything seems to work as intended.
Do I understand correctly that we would want to change the behavior of what is filled in the input after choosing something from the mention tooltip to a nickname if such is available?

By "nickname" do you mean "Display Name"? @Piotrfj ?

Do I understand correctly that we would want to change the behavior of what is filled in the input after choosing something from the mention tooltip to a nickname if such is available?

I think we always want to show the display name, is that what you are wondering?

Current status for assignment change:
For the text breaking:
I've checked many settings but none of them worked as desired. I've found a function called prefixMailSeparatorsWithBreakOpportunities in EmailUtils.ts file, but it does not seem to run in this case. My current thought is that the issue is due to some native behavior of android and I could not get to the source of it, so I don't know if it's fixable.
For the display name part:
In file SuggestionMention.tsx at line 96

for both arguments login field is passed, as first argument the text field should be passed.
However after doing so the mention is no longer clickable and I haven't been able to find solution for that.

If our best thesis is that this is caused by native Andoird behavior I am tempted to close this. Its a minor issue that I'm not sure is worth digging deeper on at this point

Thoughts @Piotrfj ?

@MitchExpensify Piotr was reassigned to another project in Callstack. Someone from our team will take this issue over and will see if it's worth fixing

Ok got it!

Hi, I'm Jakub from Callstack - expert contributor group - I would like to take over this issue. Will go through convo here and will do my research and will leave my thoughts 😄

@koko57 any update on a new set of eyes on this one?

@MitchExpensify I'm taking a look at this one as Callstack engineer - please assign it to me. Thank you.

Done! Thanks @burczu

What is the latest here @burczu ? Thanks

@MitchExpensify - @burczu is OOO till 05/05. He's still working on a proper solution for this issue.

@burczu how is the solution coming along for this? Thanks

@MitchExpensify Hey! I'm back from ooo - sorry for not leaving an information about it here, I've completely forgotten to do it. I'm still involved in the Guided Setup Stage 2 project (there is one last PR to merge I'm taking care of) but I'll be also working on this issue this week.
Till now, I've confirmed what @Piotrfj found and described in his comment: https://github.com/Expensify/App/issues/35725#issuecomment-2052402367 - I think line breaking issue will be hard to fix and is minor, so i suggest leaving it as is. In terms of display name issue - I was looking for the solution for making it clickable after changing the format but didn't find the solution yet, so I'll continue an investigation.

Not overdue - still investigating.

Here's my update for the second part of the issue:
Mention highlighting is done in two places: for the chat message list it is done in the MentionUserRenderer component, for composer it must be done inside the react-native-live-markdown library.
For now I've managed to show display name instead of login only in the MentionUserRenderer component, here's the result:
https://github.com/Expensify/App/assets/7771498/73b3e86c-8ab6-4abb-8687-373460ac4dd2
As you can see in the above video, the mention is not highlighted in the composer, and it shows a login as a mention - from what I've found, to fix it we need to change some native code of the react-native-live-markdown. I've tried to find the code responsible for this, but with no luck yet.

@shubham1206agra Thanks for pointing this out. Should we put this issue on hold as the one you've mentioned is also on hold now?

Placed on hold for https://github.com/Expensify/App/issues/38025

On hold for https://github.com/Expensify/App/issues/38025

On hold for https://github.com/Expensify/App/issues/38025

On hold for https://github.com/Expensify/App/issues/38025

On hold for https://github.com/Expensify/App/issues/38025

On hold for https://github.com/Expensify/App/issues/38025

Reassigning while I'm leave 🙇

Still on hold

Hold

Still holding

On hold

On hold

On hold

On hold.

On hold

Still on hold

On hold

Hold

On hold

On hold

Relabelling as Lauren is OOO now.

Still on-hold 👍

Still on hold — https://github.com/Expensify/App/issues/38025

@lschurr is back in office, so unassigning myself. Thanks!

On hold


CPU usage spike when minimizing with playing GIF

The viewer use less than 1% of CPU when playing a GIF. If I then minimize it, it goes to 25% CPU usage and stays there. It doesn't happen if the GIF is paused when minimizing.
I am using Windows 10.

fixed, the GIF now pauses upon minimization.


Fix haerae task groups

After group agg update, haerae tasks got error like below since tasks in group yaml do not match with each subtasks.
  File "/lm-evaluation-harness/lm_eval/tasks/__init__.py", line 232, in _get_tasklist
    return self.task_index[name]["task"]
  File "/lm-evaluation-harness/lm_eval/tasks/__init__.py", line 312, in _load_individual_task_or_group
    subtask_list = self._get_tasklist(name_or_config)
  File "/lm-evaluation-harness/lm_eval/tasks/__init__.py", line 394, in _load_individual_task_or_group
    group_name: dict(collections.ChainMap(*map(fn, reversed(subtask_list))))
  File "/lm-evaluation-harness/lm_eval/tasks/__init__.py", line 410, in load_task_or_group
    collections.ChainMap(*map(self._load_individual_task_or_group, task_list))
  File "/lm-evaluation-harness/lm_eval/tasks/__init__.py", line 616, in get_task_dict
    task_name_from_string_dict = task_manager.load_task_or_group(
  File "/lm-evaluation-harness/lm_eval/evaluator.py", line 227, in simple_evaluate
    task_dict = get_task_dict(tasks, task_manager)
  File "/mnt/naplm/users/jungwhan/lm-evaluation-harness/lm_eval/utils.py", line 397, in _wrapper
    return fn(*args, **kwargs)
  File "/lm-evaluation-harness/lm_eval/__main__.py", line 382, in cli_evaluate
    results = evaluator.simple_evaluate(
  File "/lm-evaluation-harness/lm_eval/__main__.py", line 461, in <module>
    cli_evaluate()
KeyError: 'haerae_sn'

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


build: update Github organization name & use newer NPM dependencies

Signed-off-by: Ringo De Smet<EMAIL_ADDRESS>

ping @davidsneighbour

Closing this one due to too many conflicting files with recent changes. I replaced all remaining dnb-org in 77aec8005009


Release Google.Cloud.Logging.NLog version 5.0.0

Changes in this release:
No API surface changes; just dependency updates and promotion to GA.

Created release for Google.Cloud.Logging.NLog-5.0.0


Fix azure SKU in e2e

What this PR does / why we need it:
Looks like new CCM version defaulting SKU to Standard (from former Basic). This introduces explicit SKU to unblock LoadBalancer creation.
Which issue(s) this PR fixes:

Fixes #
What type of PR is this?
/kind bug
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:

Fix azure SKU in e2e

Documentation:

NONE

/retest


[Bug]: App stuck on splash screen

Description
When I try to open the app after it is cleared on the backstack, it gets stuck on the splash screen and doesn't go past there. I have attached a video below.
Steps to reproduce

Open Stax App.
Perform a simple activity
Leave the app and remove from recent.
Open the app again.

Expected result
The app should open and I should be able to do transactions.
Actual result
The app gets stuck on the splash screen.
Link to screenshots/screen recordings
https://drive.google.com/file/d/1HwpvZFRaTj7n6dFF4ZwCEQGgyMoA_vkn/view?usp=sharing
Device name
Redmi 9A
Android OS
10
Is your phone dual SIM or single SIM?
Dual SIM
Which telco are you using for this test?
Safaricom
Stax device ID or email address
5ea7f09261718216

@kibettheophilus it looks like your device has either biometric/PIN/pattern configured as first level security. At Stax we have integrated use of these features so you can securely login to the app using your already set security. This is what might have happened for you, you send the app in the background, cleared it from your active apps which then ended the session that has logged in with your security details. That way on coming back you either have to enter the PIN/Patter or biometric. Maybe on your case when that detail was asked, you tapped on the back button which then removes the prompt to use any of those security features and the app will remain on the splash screen as long as you have not logged in.
To help with the same, please clear again the app from the recent, open and use the security feature set on your phone to open the app again. Let us know how that goes, thank you.

@kibettheophilus please update me if you managed to sort this out.

@kibettheophilus please update me if you managed to sort this out.

@johnswekenyi It is still persisting, so I still have to clear data every time I want to use the app after it is cleared from the backstack.

@kibettheophilus it looks like your device has either biometric/PIN/pattern configured as first level security. At Stax we have integrated use of these features so you can securely login to the app using your already set security. This is what might have happened for you, you send the app in the background, cleared it from your active apps which then ended the session that has logged in with your security details. That way on coming back you either have to enter the PIN/Patter or biometric. Maybe on your case when that detail was asked, you tapped on the back button which then removes the prompt to use any of those security features and the app will remain on the splash screen as long as you have not logged in.
To help with the same, please clear again the app from the recent, open and use the security feature set on your phone to open the app again. Let us know how that goes, thank you.

My phone doesn't use fingerprint(it doesn't support it), but I think this is unique issue -- since it hasn't been reported by anyone else we can close it.


clean-up : fixing test naming

Description:
Most of the tests in suite_test.go  were named as TestEndpoints, this PR cleans up and fixes the naming of the tests in the various packages appropriately.
Affected area:

New Functionality      [ ]
Documentation          [ ]
Install                [ ]
Control Plane          [ ]
CLI Tool               [ ]
Certificate Management [ ]
Networking             [ ]
Metrics                [ ]
SMI Policy             [ ]
Security               [ ]
Tests                  [X]
CI System              [ ]
Performance            [ ]
Other                  [ ]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution? no

Codecov Report

Merging #1992 into main will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1992   +/-   ##
=======================================
  Coverage   56.85%   56.85%
=======================================
  Files         138      138
  Lines        5570     5570
=======================================
  Hits         3167     3167
  Misses       2400     2400
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fceeb0a...019a883. Read the comment docs.


make directories individually configurable

Summary
All REX-Ray directories are relative to $REXRAY_HOME.
This places hard and unnecessary requirements on users' file system layouts.
For example, DC/OS would like to place the config.yaml file somewhere like /opt/mesosphere/etc/rexray/config.yaml to fit with the rest of our configuration management strategy.
This would enable seamless upgrades from earlier versions of REX-Ray, something which is currently impossible due to changes in the configuration file schema.
The schema changes from v0.3.3 to v0.8.2 require our users to manually rewrite the configuration file on every node, which is obviously blocks us from upgrading.
If we could decide on a strategy here I would be happy to submit a PR.

Hi @gpaul,

This places hard and unnecessary requirements on users' file system layouts.

How so? I'd argue it makes things incredibly portable. This is very much like many software applications with which I've worked over the years. If you would like the configuration file to be there simply set REXRAY_HOME to /opt/mesosphere/.

Hi @gpaul,
Or use REXRAY_HOME in concert with symlinks:
$ export REXRAY_HOME=/opt/rexray/v0.8.2
$ ln -s /opt/rexray/v0.8.2/etc/rexray/config.yaml /opt/mesosphere/etc/rexray/config.yaml
When you want to use a diff version of REX-Ray or diff config file change your symlink.
Also, the scheme is backwards compatible for the most part via a lot of effort on our end to ensure it so. Please let us know which piece you've found is not backwards compatible.

@akutz Thanks for the quick response.

How so? I'd argue it makes things incredibly portable.

Does the following not look odd to you?

/tmp/rexray/etc/rexray
/tmp/rexray/var/log/rexray
/tmp/rexray/var/run/rexray
/tmp/rexray/var/lib/rexray

To me, /tmp/anything/var/log|lib|run looks very strange.
The software I'm used to allows you to specify a config file using, say -f /etc/rexray/custom.rexray.conf which, of course, defaults to /etc/rexray/rexray.conf when not specified.
That config file then includes various other parameters like log_dir:, run_dir: and data_dir:.

Regarding the schema changes: I think we just missed the libstorage bus and are still running RR v0.3.3.
Here are the different configuration files (the first predates my appointment at Mesosphere so I likely lack some context):
current:
rexray:
  loglevel: info
  modules:
    default-admin:
      host: tcp://<IP_ADDRESS>:61003
  storageDrivers:
  - ec2
  volume:
    unmount:
      ignoreusedcount: true

new:
rexray:
  loglevel: info
  service: ebs
libstorage:
  integration:
    volume:
      operations:
        unmount:
          ignoreusedcount: true

TBH I would be happy with just having the config file path configurable by command-line parameter.

Hi @gpaul,
For what it's worth the old, posted config above would still be valid with our back-compat feature. It would get translated into the new format.

Hi @gpaul,

Does the following not look odd to you?

/tmp/rexray/etc/rexray
/tmp/rexray/var/log/rexray
/tmp/rexray/var/run/rexray
/tmp/rexray/var/lib/rexray

I agree it's redundant, but it's still portable. It's like someone was provided a new house for free, requesting the construction of a new wall even though there is a wall in the desired location, only the wall is painted a color that person finds unpleasing. Sure, the color may offend your senses, but the wall is still doing the job of a wall :)
I've considered the follow options however:

Make the existing rexray -c|--config switch use an entirely custom config file instead of merging the one specified via the CLI with the default. The merge action is a side-effect of the order of flags/config processing anyway and wasn't entirely intended. I'm happy to fix this; albeit it will take some time to make sure it doesn't mess anything else up.

A custom environment variable for each directory. For example:

Environment Variable
Description

REXRAY_ETC
The path to the REX-Ray configuration directory.

REXRAY_LIB
The path to the REX-Ray lib directory.

REXRAY_LOG
The path to the REX-Ray log directory.

REXRAY_RUN
The path to the REX-Ray run directory.

When REXRAY_HOME is defined the sub-dirs are collapsed in such a way that /var/DIR/rexray simply becomes /var/DIR.

Thoughts?

Hey @akutz,
Firstly, thanks for taking the time to work with me on this (and the other issues I've created!)

For what it's worth the old, posted config above would still be valid with our back-compat feature. It would get translated into the new format.

I tried to upgrade from v0.3.3 to v0.8.1 and it wasn't working. I should have collected logs but IIRC it complained of a missing libstorage config item. I'll try again and see what more I can dig up. If this is a simple matter of adding some simple backwards-compatibility code that would be pretty good news to me.

I agree it's redundant, but it's still portable. It's like someone was provided a new house for free, requesting the construction of a new wall even though there is a wall in the desired location, only the wall is painted a color that person finds unpleasing. Sure, the color may offend your senses, but the wall is still doing the job of a wall :)

Too true, please don't think I don't appreciate the good work you (and others) have already done here!

Make the existing rexray -c|--config switch use an entirely custom config file instead of merging the one specified via the CLI with the default.

TBH I didn't know this flag existed. Perhaps this config overlay, combined with the existing backwards-compatibility functionality (nice one, btw) let's me solve my config upgrade problem and let's us relegate this entire issue to "future improvements" as far as I'm concerned.
I'll report back once I've reproduced the upgrade issue and determined whether the -c flag can solve it.
Thanks again

Hi @gpaul,
Please see my work here https://github.com/codedellemc/libstorage/pull/509. I will likely introduce something similar to REX-Ray.

Very cool!


MSID: 89270 Version: 3 DOI: 10.1101/2<IP_ADDRESS>1886

MSID: 89270
Version: 3
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>1886
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=89270
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>1886

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/89270v3
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>1886
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/89270/v3/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

Scott T. Weiss has wrong email address, otherwise fine to QC.

Corrected package uploaded to s3://prod-elife-epp-meca/89270-v3-meca.zip. Hopefully this will update in the next ~hour.
Please can I leave with you to check this afternoon and publish if OK @rkcook312?

@rkcook312, please could you try hard-refreshing? I'm seeing the following:

let em know if that's not what you're expecting.

Thanks @fred-atherden Ah sorry yep I see that now!


Access request for

Access level:

[ ] Non-privileged
[ ] jenkins user
[ ] root/Administrative
[ ] other (Please specify):

System for which access is needed:
Please explain why you need this access including whether it is a temporary or permanent request:

Access level:

[ ] Non-privileged
[ ] jenkins user
[ ] root/Administrative
[ ] other (Please specify):

System for which access is needed:
Please explain why you need this access including whether it is a temporary or permanent request:

@tony981 Please stop opening useless issues. Dozens of people are notified of every action. If you want to test something, do it in your repositories. If you don't stop, you will be blocked.


Feature Request - Request POJO code generation

I believe it would be highly beneficial for the library to add POJO creation within its Java section.
Many popular libraries in Java development (e.g. Retrofit, GSON) use POJOs in HTTP requests during serialization, so having httpsnippet generate these objects from a request would therefore be quite useful.
An example of what I'd expect this feature to do can be seen using this example
Request (in cURL format)
curl -X POST -H "Content-Type: application/json" -d '{
  "Email"<EMAIL_ADDRESS>  "Password": "password",
  "Settings": {
    "MySetting": true
  }
}' "http://example.com/login"

Generated
public class LoginRequest {
    private String email;
    private String password;
    private Settings settings;

   public String getEmail(){ return email; }
   public void setEmail(String email){
      this.email = email;
   }
   // ... more getters and setters
}

public class Settings {
    public boolean mySetting;
    public void getMySetting(){ return mySetting; }
    public boolean setMySetting(boolean mySetting){
        this.mySetting = mySetting;
    }
}

Is this considered in scope for the library and if so, could it be added potentially?

I'll have to read up more on POJO in Java to understand the scope before answering ...
however in the surface, the main goal here is to have "runnable" code at the end, so any object such generation would have to done within the full sample code

quick questions that come to mind:

how to figure out types for getters and setters?
how to deal with complex objects (such as multipart requests)?
how to deal with file uploads?

if no clear answer can be attained, it might prove to be more costly to the end user to include these object abstractions than just the plain examples provided here

I've thought about this one a decent amount and I think it's outside of the scope of what HTTPSnippet currently tackles, today.
Ultimately, many of the clients and targets have ways that they could dig deeper into language internals, but the feedback above is evidence to me that it's usually quite complicated to do so.  In other words, the deeper we dive with HTTPSnippet's outputs, the more edge-cases we hit.  Also, we have seen with other clients and targets that incompatibilities arise much faster as you more deeply link the output to the UX/DX of a particular language or library, which is generally bad for users.
If you disagree or what I said doesn't make sense, please feel free to comment with some solutions to the questions posed in the comments above and we can reopen and see what we can do!


import --quiet should write a file that can be user edited and reimported

It would be awesome if we could run
 $ beet import --quiet

which then writes a file similar to a temporary commit message file. It would contain the interactive prompt:
# lines starting with # will be ignored
# (32 items)
# Tagging:
#     Dead Brothers - Dead Music for Dead People
# URL:
#     http://musicbrainz.org/release/c775bc5b-26d9-4da6-8b3b-b464040d3147
# (Similarity: 83.0%) (unmatched tracks) (CD, 2000, CH, Voodoo Rhythm Records)
# Unmatched tracks (16):
#  ! Dead Brothers Stomp (#1) (3:02)
#  ! I've Always Known (#2) (2:04)
#  ! Farmer Boy (#3) (2:42)
#  ! Besame Mucho (#4) (2:14)
#  ! Roger (#5) (0:54)
#  ! She Collects Postcards (#6) (5:03)
#  ! Banjo Villa Against Tarass Boulba (#7) (0:51)
#  ! Crying (#8) (4:38)
#  ! Hora (#9) (2:46)
#  ! Allons Aux Paquis! (#10) (2:11)
#  ! Somewhere Between Dog & Wolf (#11) (2:58)
#  ! Buy It! (#12) (1:11)
#  ! Good Time Religion (#13) (5:04)
#  ! Orally (#14) (1:01)
#  ! Ramblin' Man (#15) (3:57)
#  ! [untitled] (#16) (1:08)
# (A)pply, [S]kip, (U)se as-is, as (T)racks, (G)roup albums, Requery (i)nteractively
# Enter search, enter Id, aBort?
/music/beets_/ Dead Music for Dead People - Voodoo Rhythm Records - c775bc5b
<optional temporary uuid here>

I would then put a character with whatever choice I decide on:
# Enter search, enter Id, aBort?
/music/beets_/ Dead Music for Dead People - Voodoo Rhythm Records - c775bc5b
<optional temporary uuid here>
a

and the next item would follow.
Then i could call
$ beet import --file

and beets would apply my choices.
This would help with the dreadful importing stage. (I am importing my library since... a few days ago, and it's still going on)

Thanks for the suggestion! Can you please add your thoughts to #1375, which describes approximately the same machinery (minus the text-file-editing interface)?


Fix Timex.Duration.diff/3 documentation of available units

Summary of changes
While I was reading the docs for Timex.Duration.diff/3, I noticed that :days as an available unit was missing, and hoped it was a mistake. Upon further checking, it seems it was; so I have added it to the documentation.
Checklist

[x] New functions have typespecs, changed functions were updated
[x] Same for documentation, including moduledocs
[x] Tests were added or updated to cover changes
[x] Commits were squashed into a single coherent commit

Coverage remained the same at 67.938% when pulling cb7516851f0968aeedfc6e0dd6ee730a31720468 on aspett:duration-diff-doc-fix into 85ee14feed16ac7ce7827ac6bbdb10471c107141 on bitwalker:master.

Thanks!


Fix resource not found exception with null checks

Title (required)
Fixes B part of #1545.
Description (required)
Fixes part of #1545
Fix resource not found exception with null checks
Tests performed (required)
Wasn't able to reproduce the bug but null checks should prevent the crashes.

Codecov Report

Merging #1628 into 2.8-release will decrease coverage by <.01%.
The diff coverage is 0%.

@@              Coverage Diff               @@
##           2.8-release   #1628      +/-   ##
==============================================
- Coverage         3.87%   3.87%   -0.01%
==============================================
  Files              150     150
  Lines             7567    7571       +4
  Branches           708     710       +2
==============================================
  Hits               293     293
- Misses            7257    7261       +4
  Partials            17      17

Impacted Files
Coverage Δ

...w/commons/contributions/ContributionsActivity.java
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e9af3c...bf20489. Read the comment docs.

Thanks @maskaravivek !


add makefiles,backend scripts to gitignore

Not sure, some scripts in api/ should be in gitignore?
-cc @sneridagh

@nileshgulia1 These ones are not present any more, take a look at the current api folder:
https://github.com/plone/volto/tree/master/api
they mush have been leftovers from an old branch in your machine.


[FLINK-17488] Now JdbcConnectionOptions supports autoCommit control

Now JdbcConnectionOptions supports autoCommit control
Default behaviour hasn't changed.
Added logging information to be able to track batches

What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
Brief change log
(for example:)

The TaskInfo is stored in the blob store on job creation time as a persistent artifact
Deployments RPC transmits only the blob storage reference
TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (100MB)
Extended integration test for recovery after master (JobManager) failure
Added test that validates that TaskInfo is transferred only once across recoveries
Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Thanks for your PR.
It would be nice if you could mention this new option also in the documentation of the JDBC sink.

We've now moved the code from the JDBC connector to its own dedicated repository; please re-route this PR to https://github.com/apache/flink-connector-jdbc


Codestyling

Hi hi, this change is meant for code quality: to use tools such as JSHint (as included in package.json), EditorConfig and ESLint.
In short, this makes coding in JS a bit "stricter" than usual as it enforces some rules in syntax.
Feel free to try it out on vscode sometime and even modify the tool configuration if you like.
You can close this PR if you don't need these tools yet.
TODO:

[ ] include eslint
[ ] set-up vscode recommendations

This goes where?? Index.js?? Or straight in the repo?


added school name

School name: EEEP Professora Luíza De Teodoro Vieira
School email<EMAIL_ADDRESS>

@natanael-oliveira I am sorry, I cannot find a reliable information about your school. Please provide us with:

the school official website URL
an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course
a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.

I will look for another way to confirm the email. I will contact the school

@natanael-oliveira Thank you! I am looking forward to seeing the confirmation.

Hello @philipto. I received a statement from the school confirming the domain of the email provided  statement

@natanael-oliveira Pull request merged. Thank you!

Eu te agradeço tchau

I thank you, bye


Night Mode

feature request from stack overflow
http://stackoverflow.com/questions/31194033/night-mode-using-osmdroid/31215472#31215472
We can create a toggleable tile color inversion to support a quasi night mode

In my app, I pre-create the "night mode" app tiles by inversing them in MOBAC. How's performance of doing that in real-time on the device? I'm a bit sceptical, because the map already is rather resource intensive without doing image manipulation.

I didn't notice a difference


Text color on widget section on INT

@jdm135 Please have a look at this. With current font the text inside the input box is not visible.

Fixed.


Linux support

I see that Linux support is mentioned in the roadmap, so I thought I'd create an issue for this so I (and anyone else interested) can be notified when this is "fixed".

@logix2 Working on this. But problem at moment I am facing is building for linux via electron-builder. Seems not working / or has some known issues.

I see that Linux support is mentioned in the roadmap, so I thought I'd create an issue for this so I (and anyone else interested) can be notified when this is "fixed".

would be awesome if the reader works on linux!! :+1:
I've been searching for such a tool for a very long time and according to the screenshots published
raven is exactly what i was looking for.
Props @mrgodhani for this awesome project!!

@wetterSpitze Thanks for the kind words. I will try to build for Linux right now it's simply blocked as somehow I am not able to build one

@logix2 @wetterSpitze App for Linux is here https://github.com/mrgodhani/raven-reader/releases/tag/v0.3.7 Download Snap or AppImage file

@logix2 @wetterSpitze App for Linux is here https://github.com/mrgodhani/raven-reader/releases/tag/v0.3.7 Download Snap or AppImage file

Very nice to see the project progressing :+1: . And thanks for this very quick effort to port your app on Linux!!


OrthographicProjection: place origin at integer pixel with WindowSize scaling mode

Objective
One way to avoid texture atlas bleeding is to ensure that every vertex is
placed at an integer pixel coordinate. This is a particularly appealing
solution for regular structures like tile maps.
Doing so is currently harder than necessary when the WindowSize scaling
mode and Center origin are used: For odd window width or height, the
origin of the coordinate system is placed in the middle of a pixel at
some .5 offset.
Solution
Avoid this issue by rounding the half width and height values.

Neat, I like it! Thanks for the solid explanation,

Great work. Could you resolve the comments now @NeoRaider?

bors r+


Syntax

What's this PR do?
Apply syntax colors as described in issue #71
Targets PBASIC full syntax
Closes #85 and #71
Where should the reviewer start?
Load this branch and run ChromeIDE.
How should this be manually tested?
Create a test file and enter in some test code. Try to use each of the token categories listed in issue 71 to ensure they are being properly colored.
Any background context you want to provide?
The highlighter is based on the VB code file. The css theme is modified from neo.
Only piece not working as it should is the etDirective type.
What are the relevant tickets?
Issues #71 and #85
Screenshots (if appropriate)

Questions:

Is there a blog post?
No
Does the knowledge base need an update?
No

updated.

Keep in mind that this is the PBASIC syntax, not Parallax syntax... the Spin and PASM languages for Propeller have very different syntax highlighting rules and each syntax highlighting set will need to be supported at that later time within the same app.

This is a minor change and we will update the name.

I jumped the gun on the my last comment and updated.  Please take a look.


Refactor: Move parts of expr pass to new verify pass.

This PR refactors the compiler to extract some parts of the expr pass to a new pass called the verify pass.  This new pass focuses on checks which are not required for resolving expression types.  Removing these checks from the expr pass makes that pass simpler and easier to understand and reason about.  It also makes the implementations of these moved checks much simpler, since the AST is much more uniform after the expr pass than it is during the expr pass.  In contrast to the expr pass, the new verify pass does not mutate the structure of the AST - it only sets and gets some AST flags in the tree.
This PR also adds compiler tests for a bunch of behaviour that was not previously covered by tests.
There should be no observable behaviour change in the compiler, other than some slightly improved error messages.
There might be more pieces of the expr pass that could be moved into the verify pass at a later time, but this seemed like a good chunk of work to start with.  For example, I'd like to look at moving consume tracking to the verify pass, but that will be a pretty big chunk of effort when I do take it on.

I'd like to advocate that this PR not be squashed when merging.  Each commit is a carefully crafted logical step, and each passes all tests, so it should be safe for bisecting.  Mainly, I think keeping the commits separate should make it easier for someone to understand what refactoring was done and which parts relate to which.  It also might make it easier for Luke Cheeseman to deal with any potential conflicts in his dependent-types fork.

Looks like Travis finally got around to testing this and they passed.


Update dependency Microsoft.Extensions.* to 5.0.0

Fixes #5751
Description
This updates Microsoft.Extensions.*from version 2.1.0 to 5.0.0 for TargetFramework netcoreapp3.1.
For netcoreapp2.1, version 2.1.0 must be kept because later versions are not compatible.
Specific Changes

Testing

Per Monica, dropping 2.1 support must wait for release 5.0.


Draft PR : Fix/add current index property to min max fields

Fixes #20231

Pull Request Template
Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request.

Description

Please include a summary of the changes and which issue has been fixed. Please also include relevant motivation
and context. List any dependencies that are required for this change
Links to Notion, Figma or any other documents that might be relevant to the PR

Add a TL;DR when description is extra long (helps content team)

Fixes # (issue)

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Chore (housekeeping or task changes that don't impact user perception)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.
Delete anything that is not important

Manual
Jest
Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

/ok-to-test sha=8f6e560

/build-deploy-preview env=release

/ok-to-test sha=4772dab

/build-deploy-preview env=release

/ok-to-test sha=3662336

/ok-to-test sha=d2e3518

/build-deploy-preview env=release

/ok-to-test sha=8ae07b0

Tested this PR and LGTM

Tested all js fields
Sanity on Table widget all columns
Tested migration scenarios
Tested with older apps

/ok-to-test sha=8ae07b0

/ok-to-test sha=8ae07b0

/ok-to-test sha=a4f36b1

/ok-to-test sha=596eec7


fix: update fields permission tags

这个 PR 实现什么功能/修复什么问题:
修正：修正model field的标签

是否需要 backport 到之前的 release 分支:

release/3.2

/area region
/cc @zexi

Codecov Report

Merging #6432 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6432      +/-   ##
==========================================
+ Coverage    7.18%    7.19%   +0.01%
==========================================
  Files         646      646
  Lines      108626   108626
==========================================
+ Hits         7808     7819      +11
+ Misses     100219   100207      -12
- Partials      599      600       +1

Flag
Coverage Δ

#aFlag
7.19% <ø> (+0.01%)
:arrow_up:

Impacted Files
Coverage Δ

pkg/compute/models/hostnetworks.go
0.74% <ø> (ø)

pkg/compute/models/hoststorages.go
0.50% <ø> (ø)

pkg/compute/models/hostwires.go
0.78% <ø> (ø)

pkg/compute/models/loadbalancernetworks.go
0.51% <ø> (ø)

pkg/compute/models/managedresource.go
0.00% <ø> (ø)

pkg/compute/models/networkinterfacenetwork.go
0.84% <ø> (ø)

pkg/cloudcommon/cronman/cronman.go
53.95% <0.00%> (+5.11%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbeb6be...d1fd245. Read the comment docs.


Allow searching for untagged bookmarks

Closes #192
Created a Docker image for testing: sissbruecker/linkding:search-untagged-bookmarks

I love this idea! Do you need someone to test this docker image with your fix? I presume we should rebase and get rid of those merge conflicts first.

I was thinking about where to put the option to search for untagged bookmarks. If more specific searches like this get added in the future it might make sense to put them into a menu or something in the vicinity of the search input. But for now the current solution is good enough, and it can still be changed later.


PermutohedralLattice.apply

hi,
here is the second question.
i have an rgb image with height and width h and w.
my initial thought is to compute the affinity matrix W then, perform other necessary matrix product. but, i think the whole point to pl is to effciently compoute the prodcut W * IMAGE_OR_SOFTMAXSCORES.
W is of size (h * w, h * w).
W is the matrix defined here, and eq.4 in here, and as you defined it in your code
https://github.com/SamuelJoutard/Permutohedral_attention_module/blob/c86b8108fbfcf73ce300197e57cccbdfa25386ff/CRF/crf.py#L92
of crf in here in eq.3 first term, and in eq6 in here.
often, we need to compute St * W * (1-S) where S is the softmax scores, * is matrix product, t is matrix transpose.
my question now is how to use your PermutohedralLattice.apply to compute either:

St * W
W * (1-S) or simply W * Z.

i need to be able to perform both, in particular the second operation.
Z has the same shape as S. it is useful to in order to compare to another c++ implementation that evaluates first W * Z where Z is simple S for a technical reason; then perform the product between St an the result of W * Z.
thanks
from your code in here,
https://github.com/SamuelJoutard/Permutohedral_attention_module/blob/c86b8108fbfcf73ce300197e57cccbdfa25386ff/CRF/crf.py#L102
here what i did, and then i got this error reported in the other post. it is your code, but used over dummy inputs and considering rgb image and the softmax scores has only one plan filled with 1. i expect the output i.e. norm_1 to have the same number of elements as ones:
    np.random.seed(0)
    n, c, h, w = 32, 3, 224, 225

    img = np.random.rand(n, c, h, w) * 255
    img = torch.cuda.FloatTensor(img)
    img = torch.clip(img, 0, 255)

    npx = h * w
    spatial_x, spatial_y= torch.meshgrid(
        torch.arange(h).cuda(),
        torch.arange(w).cuda()

    )
    spatial = torch.stack([spatial_x, spatial_y], dim=0)  # 4d tensor
    # Duplicate the coordinates along the batch dimension
    spatial = spatial.unsqueeze(0).repeat(n, 1, 1, 1)  # 5d tensor
    spatial = spatial.type(torch.cuda.FloatTensor).detach()
    spatial = torch.reshape(spatial, (n, spatial.size(1), -1))
    # Create the bilateral kernel features
    # Features for the first term of eq (3) in [1]
    img_fea = torch.reshape(img, (n, img.size(1), -1))
    _alpha = 1
    _beta = 1
    features_1 = torch.cat([spatial / _alpha, img_fea / _beta], dim=1)
    ones = torch.ones((n, 1, npx)).cuda()
    pl = PermutohedralLattice.apply
    norm_1 = pl(features_1, ones)

thanks for your help

Hi Soufiane,
thank you for your interest in our work. I think I can answer more easily this issue than the other one (which seems to have been addressed now thanks to ptrblck. In order to compute your product St W (1 - S), I would compute, using the lattice if you need speed-ups, W (1 - S) first. That means, using the names from my code, that the descriptors (desc) is (1 - S) while the features are what you plan to use to compute W (typically rgb + spatial coordinates). Then, you will obtain something that has the same shape as S and so you can do, as you suggested, the product between S and the output of the previous operation.
I hope this was clear enough, if it is not the case, we can discuss this furthermore through a code exemple.
Samuel

hi Samuel,
thank you very much for the details. it is clear.
so, the aim using your implementation is to replace the c++-multi-threaded-cpu implementation of bilateral filter in here.
the issue with the cpu implementation is that the c++-multi-threading seems to be turned off when using ddp+multigpus. so the gain in multigpus is lost with the loss of multi-threading. (let me know if you have any suggestion about this. thanks)
i did a first comparison between your implementation and theirs where they use a thread at least per sample in minibatch. let's ignore for now the difference in term of value.
i measured the time used to perform W * Z when using ddp with single gpu (the ddp has no impact in this case) using your code and theirs on the same input (rgb image (224 * 224) + segmentation (2 plans) for batch size 32):

multi-threaded-c++-cpu implementation: 65ms
your gpu-implementation: 300ms.

gpu: tesla p100.
note: when using ddp+ 2 gpus, the c++ method slows down to 600ms because its multi-threading is not working. so, the good news is that your gpu implementation is helpful in multi-gpu case. but, it is still very slow.
note: when computing W * Z, i dont need the gradient since i compute it manually later.
q1. did you optimize your code, in term of speed?
q2. if not, do you see any opportunity to speed up any part of it? note that all computations to compute the gradient are not necessary.
i'll time the instructions in your code and try to find any bottlenecks.
i really expect that the gpu version will easily run under <= 65ms.
please let me know if you have any idea how to speed the code given the above information.
thank you very much for your help!
the used code is similar to this:

import sys
from os.path import dirname, abspath

import re
import torch.nn as nn
import torch
import torch.nn.functional as F
import numpy as np

from PAM_cuda.pl import PermutohedralLattice

def set_seed(seed):
    torch.manual_seed(seed)
    np.random.seed(seed)
    torch.cuda.manual_seed(seed)
    torch.cuda.manual_seed_all(seed)

def main():
    seed = 0
    cuda = "0"
    print("cuda:{}".format(cuda))
    DEVICE = torch.device(
        "cuda:{}".format(cuda) if torch.cuda.is_available() else "cpu")

    set_seed(seed=seed)
    torch.backends.cudnn.benchmark = True
    # Deterministic mode can have a performance impact, depending on your
    torch.backends.cudnn.deterministic = True

    n, c, h, w = 32, 3, 224, 224
    nbr_cl = 2

    img = torch.randint(
        low=0, high=256,
        size=(n, 3, h, w), dtype=torch.float, device=DEVICE,
        requires_grad=False)
    segmentations = torch.rand(size=(n, nbr_cl, h, w), dtype=torch.float,
                               device=DEVICE,
                               requires_grad=True)
    segmentations = torch.softmax(segmentations, dim=1)
    segmentations = segmentations.view(n, nbr_cl, -1)

    npx = h * w
    spatial_x, spatial_y = torch.meshgrid(
        torch.arange(h, device=DEVICE),
        torch.arange(w, device=DEVICE)
    )
    spatial = torch.stack([spatial_x, spatial_y], dim=0)  # 4d tensor
    # Duplicate the coordinates along the batch dimension
    spatial = spatial.unsqueeze(0).repeat(n, 1, 1, 1)  # 5d tensor
    spatial = spatial.float().detach()
    spatial = torch.reshape(spatial, (n, spatial.size(1), -1))
    # Create the bilateral kernel features
    # Features for the first term of eq (3) in [1]
    img_fea = torch.reshape(img, (n, img.size(1), -1))
    _alpha = 100.
    _beta = 15.
    features_1 = torch.cat([spatial / _alpha, img_fea / _beta], dim=1)

    pl = PermutohedralLattice.apply
    torch.cuda.synchronize()
    start_event = torch.cuda.Event(enable_timing=True)
    end_event = torch.cuda.Event(enable_timing=True)
    start_event.record()
    with torch.no_grad():
        norm_1 = pl(features_1, segmentations)
    end_event.record()
    torch.cuda.synchronize()

    elapsed_time_ms = start_event.elapsed_time(end_event)
    print('time op: {}'.format(elapsed_time_ms))

if __name__ == '__main__':
    for i in range(10):
        print('run {}'.format(i))
        main()

i tried to see if there are some corners to cut, nothing.
here is the gist of bottlenecks in pl(features_1, segmentations) which takes in total ~82ms:

permutohedral_prepare: 71.ms

torch.argsort ~13ms for each call.
torch.sort: 12ms
loop1: 21ms
loop2: 4ms

permutohedral_compute: 10ms

i tired to replace all numpy ops by torch ops but it didnt bring much benefits as the tensors are small.
i just did a quick pr with minor modification in
https://github.com/SamuelJoutard/Permutohedral_attention_module/blob/c86b8108fbfcf73ce300197e57cccbdfa25386ff/PAM_cuda/pl.py#L105
by:
device = hash_vector.device
table = torch.zeros((table_size, n_ch_1), device=device, dtype=torch.int32) - 2

thank you for your quick reactivity and your help!
closing
best


feature(nestjs-map-errors-interceptor): map objects nested into array validation errors

test(nestjs-map-errors-interceptor): test shape of mapped validation error
feat(nestjs-map-errors-interceptor): map validation error for array with incorrect objects

Replaced by #185


Rendering exception in emulator but not on phone when showing simple dialog

Steps to Reproduce
I start a SimpleDialog with a list in it . When I start the Dialog on the phone all is fine. In the emulator I get an exception which does not provide info to get to the root cause or useable information. (for me ;))
Phone and Emulator:
• Android SDK built for x86 • emulator-5554    • android-x86 • Android 7.1.1 (API 25) (emulator)
• Moto G 5 Plus             • ZY224DHFWG       • android-arm • Android 7.0 (API 24)
After simplifying the code I could  reproduce the behavior with this simple code.
The error shows up  on the emulator only it renders fine on my phone (Moto G5plus and Pixel). Also using shrinkWrap does not make a difference:
I also checked these other defects bt it seems the error message is still not helping to get to the problem and I dont know why I actually need any height setting in the code snippet below.
These are the related defects:
https://github.com/flutter/flutter/pull/8321
https://github.com/flutter/flutter/issues/8296
Does not work in Emulator
 _showDialog(BuildContext context) => showDialog<Null>(
      context: context,
      child: new SimpleDialog(children: <Widget>[
        new ListView(
//            shrinkWrap: true,
//            addRepaintBoundaries: true,
            children: <Widget>[
              const Text('1'),
              const Text('2'),
              const Text('3'),
              const Text('4')
            ])
      ]));

Does not work in emulator:
                onTap: () => showDialog<String>(
                    context: context,
                    child: new SimpleDialog(children: <Widget>[
                      new Container(
                          height: MediaQuery.of(context).size.height * 0.5,
                          width: double.INFINITY,
                          child: new ListView(
                              shrinkWrap: true,
                              children: <Widget>[
                                const Text('1'),
                                const Text('2'),
                                const Text('3'),
                                const Text('4')
                              ]))
                    ])),

Does work in Emulator
            onTap: () => showDialog<String>(
                    context: context,
                    child: new SimpleDialog(children: <Widget>[
                      new Container(
                          height: MediaQuery.of(context).size.height * 0.5,
                          width: MediaQuery.of(context).size.width * 0.5,
                          child: new ListView(
                              shrinkWrap: true,
                              children: <Widget>[
                                const Text('1'),
                                const Text('2'),
                                const Text('3'),
                                const Text('4')
                              ]))
                    ])),

Exception Log
[        ] I/flutter (31525): 158 2018-01-09 23:55:45.322504 FINEST ui.chat_message_widget.dart: _renderImage ->
[        ] I/flutter (31525):  message.mediaUrl : https://firebasestorage.googleapis.com/v0/b/lambdbdev.appspot.com/o/test_showcase%2FZvN0bw7GMMaZ9N3UotByzH8zFb33%2FZvN0bw7GMMaZ9N3UotByzH8zFb33%2Fimage_e4370613-a4be-4237-8087-eab74b5416e2.jpg?alt=media&token=c9452337-361c-4682-a03f-a199f77ec615, https://firebasestorage.googleapis.com/v0/b/lambdbdev.appspot.com/o/test_showcase%2FZvN0bw7GMMaZ9N3UotByzH8zFb33%2FZvN0bw7GMMaZ9N3UotByzH8zFb33%2Fimage_e4370613-a4be-4237-8087-eab74b5416e2_thumb.jpg?alt=media&token=c9452337-361c-4682-a03f-a199f77ec615
[        ] I/flutter (31525): message.mediaIsUploading : false
[        ] I/flutter (31525): message.mediaSize.x : 2268
[        ] I/flutter (31525): message.mediaSize.y : 4032
[        ] I/flutter (31525): message.readByUsers : {}
[        ] I/flutter (31525): message.isMediaUploadFailed : false
[   +2 ms] I/flutter (31525): 159 2018-01-09 23:55:45.324700 FINEST ui.busy_overlay.dart: isLoading: {false}
[        ] I/flutter (31525): supportsIsLoading: {true}
[        ] I/flutter (31525): height: {4032.0}
[        ] I/flutter (31525): width: {2268.0}
[        ] I/flutter (31525): child: {FadeInImage}
[        ] I/flutter (31525): borderRadius: {BorderRadius.circular(25.0)}
[ +127 ms] I/flutter (31525): 160 2018-01-09 23:55:45.453467 SEVERE lookatmybaby_flutter.sentry_error_reporter: Context: during performLayout(), library: rendering library
[   +2 ms] I/flutter (31525):     error: RenderShrinkWrappingViewport does not support returning intrinsic dimensions.
[        ] I/flutter (31525): Calculating the intrinsic dimensions would require instantiating every child of the viewport, which defeats the point of viewports being lazy.
[        ] I/flutter (31525): If you are merely trying to shrink-wrap the viewport in the main axis direction, you should be able to achieve that effect by just giving the viewport loose constraints, without needing to measure its intrinsic dimensions.
[   +7 ms] I/flutter (31525): #0      RenderShrinkWrappingViewport.debugThrowIfNotCheckingIntrinsics.<anonymous closure> (package:flutter/src/rendering/viewport.dart:1211)
[        ] I/flutter (31525): #1      RenderShrinkWrappingViewport.debugThrowIfNotCheckingIntrinsics (package:flutter/src/rendering/viewport.dart:1221)
[        ] I/flutter (31525): #2      RenderViewportBase.computeMaxIntrinsicHeight (package:flutter/src/rendering/viewport.dart:229)
[        ] I/flutter (31525): #3      RenderBox._computeIntrinsicDimension.<anonymous closure> (package:flutter/src/rendering/box.dart:1050)
[        ] I/flutter (31525): #4      _HashVMBase&MapMixin&&_LinkedHashMapMixin.putIfAbsent (dart:collection-patch/dart:collection/compact_hash.dart:275)
[        ] I/flutter (31525): #5      RenderBox._computeIntrinsicDimension (package:flutter/src/rendering/box.dart:1048)
[        ] I/flutter (31525): #6      RenderBox.getMaxIntrinsicHeight (package:flutter/src/rendering/box.dart:1381)
[        ] I/flutter (31525): #7      RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.computeMaxIntrinsicHeight (package:flutter/src/rendering/proxy_box.dart:91)
[        ] I/flutter (31525): #8      RenderBox._computeIntrinsicDimension.<anonymous closure> (package:flutter/src/rendering/box.dar
[        ] I/flutter (31525): 161 2018-01-09 23:55:45.463717 SEVERE lookatmybaby_flutter.sentry_error_reporter: Context: during performLayout(), library: rendering library
[        ] I/flutter (31525):     error: 'package:flutter/src/rendering/box.dart': Failed assertion: line 1433: 'hasSize': is not true.
[   +2 ms] I/flutter (31525): #0      _AssertionError._doThrowNew (dart:core-patch/dart:core/errors_patch.dart:37)
[        ] I/flutter (31525): #1      _AssertionError._throwNew (dart:core-patch/dart:core/errors_patch.dart:33)
[        ] I/flutter (31525): #2      RenderBox.size (package:flutter/src/rendering/box.dart:1433)
[        ] I/flutter (31525): #3      RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:106)
[        ] I/flutter (31525): #4      RenderObject.layout (package:flutter/src/rendering/object.dart:1551)
[        ] I/flutter (31525): #5      RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105)
[        ] I/flutter (31525): #6      _RenderCustomClip.performLayout (package:flutter/src/rendering/proxy_box.dart:1003)
[        ] I/flutter (31525): #7      RenderObject.layout (package:flutter/src/rendering/object.dart:1551)
[        ] I/flutter (31525): #8      RenderConstrainedBox.performLayout (package:flutter/src/rendering/proxy_box.dart:255)
[        ] I/flutter (31525): #9      RenderObject.layout (package:flutter/src/rendering/object.dart:1551)
[        ] I/flutter (31525): #10     RenderPadding.performLayout (package:flutter/src/rendering/shifted_box.dart:199)
[        ] I/flutter (31525): #11     RenderObject
[        ] I/flutter (31525): 162 2018-01-09 23:55:45.468066 SEVERE lookatmybaby_flutter.sentry_error_reporter: Context: during performLayout(), library: rendering library
[        ] I/flutter (31525):     error: 'package:flutter/src/rendering/box.dart': Failed assertion: line 1433: 'hasSize': is not true.
[   +3 ms] I/flutter (31525): #0      _AssertionError._doThrowNew (dart:core-patch/dart:core/errors_patch.dart:37)
[        ] I/flutter (31525): #1      _AssertionError._throwNew (dart:core-patch/dart:core/errors_patch.dart:33)
[        ] I/flutter (31525): #2      RenderBox.size (package:flutter/src/rendering/box.dart:1433)
[        ] I/flutter (31525): #3      RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:106)
[        ] I/flutter (31525): #4      _RenderCustomClip.performLayout (package:flutter/src/rendering/proxy_box.dart:1003)
[        ] I/flutter (31525): #5      RenderObject.layout (package:flutter/src/rendering/object.dart:1551)
[        ] I/flutter (31525): #6      RenderConstrainedBox.performLayout (package:flutter/src/rendering/proxy_box.dart:255)
[        ] I/flutter (31525): #7      RenderObject.layout (package:flutter/src/rendering/object.dart:1551)
[        ] I/flutter (31525): #8      RenderPadding.performLayout (package:flutter/src/rendering/shifted_box.dart:199)
[        ] I/flutter (31525): #9      RenderObject.layout (package:flutter/src/rendering/object.dart:1551)
[        ] I/flutter (31525): #10     RenderPositionedBox.performLayout (package:flutter/src/rendering/shifted_box.dart:381)
[        ] I/flutter (31525): #11     RenderObject.layout (package:flutter/src/render
[        ] I/flutter (31525): 163 2018-01-09 23:55:45.472362 SEVERE lookatmybaby_flutter.sentry_error_reporter: Context: during performLayout(), library: rendering library
[        ] I/flutter (31525):     error: 'package:flutter/src/rendering/box.dart': Failed assertion: line 1433: 'hasSize': is not true.
[   +1 ms] I/flutter (31525): #0      _AssertionError._doThrowNew (dart:core-patch/dart:core/errors_patch.dart:37)
[        ] I/flutter (31525): #1      _AssertionError._throwNew (dart:core-patch/dart:core/errors_patch.dart:33)
[        ] I/flutter (31525): #2      RenderBox.size (package:flutter/src/rendering/box.dart:1433)
[        ] I/flutter (31525): #3      RenderConstrainedBox.performLayout (package:flutter/src/rendering/proxy_box.dart:256)
[        ] I/flutter (31525): #4      RenderObject.layout (package:flutter/src/rendering/object.dart:1551)
[        ] I/flutter (31525): #5      RenderPadding.performLayout (package:flutter/src/rendering/shifted_box.dart:199)
[        ] I/flutter (31525): #6      RenderObject.layout (package:flutter/src/rendering/object.dart:1551)
[        ] I/flutter (31525): #7      RenderPositionedBox.performLayout (package:flutter/src/rendering/shifted_box.dart:381)
[        ] I/flutter (31525): #8      RenderObject.layout (package:flutter/src/rendering/object.dart:1551)
[        ] I/flutter (31525): #9      RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105)
[        ] I/flutter (31525): #10     RenderObject.layout (package:flutter/src/rendering/object.dart:1551)
[        ] I/flutter (31525): #11     RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.perfo
[   +1 ms] I/flutter (31525): 164 2018-01-09 23:55:45.475519 SEVERE lookatmybaby_flutter.sentry_error_reporter: Context: during performLayout(), library: rendering library
[        ] I/flutter (31525):     error: 'package:flutter/src/rendering/box.dart': Failed assertion: line 1433: 'hasSize': is not true.
[   +3 ms] I/flutter (31525): #0      _AssertionError._doThrowNew (dart:core-patch/dart:core/errors_patch.dart:37)
[        ] I/flutter (31525): #1      _AssertionError._throwNew (dart:core-patch/dart:core/errors_patch.dart:33)
[        ] I/flutter (31525): #2      RenderBox.size (package:flutter/src/rendering/box.dart:1433)
[        ] I/flutter (31525): #3      RenderPadding.performLayout (package:flutter/src/rendering/shifted_box.dart:203)
[        ] I/flutter (31525): #4      RenderObject.layout (package:flutter/src/rendering/object.dart:1551)
[        ] I/flutter (31525): #5      RenderPositionedBox.performLayout (package:flutter/src/rendering/shifted_box.dart:381)
[        ] I/flutter (31525): #6      RenderObject.layout (package:flutter/src/rendering/object.dart:1551)
[        ] I/flutter (31525): #7      RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105)
[        ] I/flutter (31525): #8      RenderObject.layout (package:flutter/src/rendering/object.dart:1551)
[        ] I/flutter (31525): #9      RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:105)
[        ] I/flutter (31525): #10     RenderObject.layout (package:flutter/src/rendering/object.dart:1551)
[        ] I/flutter (31525): #11     RenderBox&RenderObjectWith

Flutter Doctor
C:\Projects\lambDev\lookatmybaby_shared>flutter doctor
[√] Flutter (on Microsoft Windows [Version 10.0.16299.192], locale en-US, channel alpha)
    • Flutter at c:\sdks\flutter
    • Framework revision 8f65fec5f5 (4 weeks ago), 2017-12-12 09:50:14 -0800
    • Engine revision edaecdc8b8
    • Tools Dart version 1.25.0-dev.11.0
    • Engine Dart version 2.0.0-edge.d8ae797298c3a6cf8dc9f4558707bd2672224d3e

[√] Android toolchain - develop for Android devices (Android SDK 27.0.2)
    • Android SDK at C:\Users\ride4\AppData\Local\Android\sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-27, build-tools 27.0.2
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-915-b01)

[√] Android Studio (version 3.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-915-b01)

[√] IntelliJ IDEA Community Edition (version 2017.2)
    • Flutter plugin version 19.1
    • Dart plugin version 172.4343.25

[√] Connected devices
    • Android SDK built for x86 • emulator-5554    • android-x86 • Android 7.1.1 (API 25) (emulator)
    • Moto G 5 Plus             • ZY224DHFWG       • android-arm • Android 7.0 (API 24)
    • Nexus 5                   • 03b71506f0b4f6b6 • android-arm • Android 6.0.1 (API 23)

I don't understand why this works on real devices. It shouldn't. The problem is that viewports don't know their intrinsic dimensions, because they don't instantiate all their children, but SimpleDialog tries to size itself to the intrinsic dimensions of the children.
We should document this better.

Looks similar to #18108


nnoremap   does generate smooth scrolling

The following does not generate smooth scrolling:
nnoremap <Space> <C-D>

This is expected, due to the way nnoremap works. You need to use either nmap <Space> <C-D>, or (recommended) nmap <Space> <Plug>(SmoothieDownwards).


WevImages in LazyVStack in ScrollView locks at 100% CPU when setting containing view to .equatable()

When using this pattern:
ScrollView {
  LazyVStack {
    ItemView()
      .equatable()
   }
}

And ItemView contains a WebImage, the application will lock at 100% CPU and memory will keep climbing.
Being able to use equatable is important for performance optimization and preventing views from completely re-rendering when a @State variable changes that doesn't require the view to recalculate everything.

More information —
This doesn't happen in iOS 15 Beta 3, but it does happen in iOS 14.5.

I posted in this issue about it as well, https://github.com/SDWebImage/SDWebImageSwiftUI/issues/186
The TLDR of it is, try running in Release mode and see if you have the same issues. In my case, I only had the bad CPU framerate issues in debug. In release, smooth as butter, low CPU usage.


Fetching metadata from an entity using the custom strategy is throwing an error.

Description
I am trying to fetch metadata from an entity with the Custom Strategy using this library.
This produces an error:
Cannot instantiate custom generator : array (
'class' => 'UuidGenerator',
)
The error is not thrown if i change the strategy to auto.
Steps to reproduce
Put this in a controller and trigger the function.
Get the metadata from an entity.
This: "App\Entity\Menu" can be replaced with a entity you have and is using the custom strategy.
This: "$this->em" is a refrence  to __construct(EntityManagerInterface $em)
$cmf = $this->em->getMetadataFactory();
$class = $cmf->getMetadataFor("App\Entity\Menu");

return new Response("ok");

Expected behavior
Show metadata for the class
Environment details
Php: 8
doctrine: 2.11
Symfony: 6

Changing annotation  from
@ORM\CustomIdGenerator(class=UuidGenerator::class)
To
@ORM\CustomIdGenerator(class="Ramsey\Uuid\Doctrine\UuidGenerator")
Partially works;
I get the metadata printed on screen but then i throws an error anyway.
Cannot instantiate custom generator : array (
'class' => 'UuidGenerator',
)
But is now complaining about this
<?php
use App\Kernel;
require_once dirname(__DIR__).'/vendor/autoload_runtime.php';

The issue is now solved.
The last issue was that the menu entity had a relation to a file with the wrong annotation.
So the conclusion is that you need to update your documentation for symfony annotation.
You need to change this:
@Orm\CustomIdGenerator(class=UuidGenerator::class)
To
@Orm\CustomIdGenerator(class="Ramsey\Uuid\Doctrine\UuidGenerator")


🐛 BUG: wrangler get stuck running proxy command

What version of Wrangler are you using?
2.0.26
What operating system are you using?
Pop!_OS 22.04 LTS
Describe the Bug
run wrangler pages dev -- next dev in next.js project folder.
it will stuck at Running next dev... with high cpu usage (1 of my cpu cores always run at 100% for this process).
no error message.
need to close my terminal to terminate the process, CTRL+C in the terminal doesn't work.
with pnpm wrangler pages dev -- next dev (pnpm in the front), wrangler pages dev -- pnpm dev (change next to pnpm for proxy command), and pnpm wrangler pages dev -- pnpm dev (pnpm in the front and next to pnpm for proxy command), it will not get stuck.
other software version details:
node 16.17.0 with nvm 0.39.1
pnpm 7.9.3

Hey,
This may have been resolved since due to a lot of the work we have done around pages dev. Please let us know if this is still an issue!


explorer is not working for parallel in localnet

Overview
explorer is not working for parallel in localnet
Steps to Reproduce
Steps to reproduce the behavior:

run dive chain polkadot -p parallel --explorer --metrics
Open explorer and give endpoint of parallel

Expected Behavior
Explorer to show block details

verified the issue and closing the bug as fixed


Copying the default template result in a parsing error (export...)

Hi, thanks for you awesome work! This lib seems amazing.
Just trying it out.
I aim to use it for web & native at the same time.
I tried to adjust the template and I am getting
(function (exports, require, module, __filename, __dirname) { export default (opts = {}) => {
                                                              ^^^^^^

SyntaxError: Unexpected token export

Which make sense since node is not able (yet) to understand export/import natively. I guess we should adjust README to point to a transpiled version or to warn about this?

Thank you!
Yes I agree, it is very confusing. I will change it right now.