Move block + MultiBody model can give issues with index reduction

Reported by otter on 21 Jun 2014 13:48 UTC
The attached model (from Leo Gall) fails to translate in Dymola (and most likely in all other Modelica tools).

Migrated-From: https://trac.modelica.org/Modelica/ticket/1523

Comment by otter on 21 Jun 2014 14:11 UTC
Fixed in 27e17cf0c38abd227b405a3fc8fe0f3c32f07196 (trunk) and 9b5c652893da661c70322633e33b18bd3efaf180 (maintenance) by

Improving block Modelica.Mechanics.Rotational.Sources.Move
Improving block Modelica.Mechanics.Translational.Sources.Move
Adding test model ModelicaTest.MultiBody.PlanarLoopWithMove.
The test model is a combination of a multi-body system with a kinematic loop and a Rotational.Sources.Move block, where symbolic transformation fails in MSL 3.2.1 build2:

Standard symbolic transformation works in the following way if functions are present with annotation "InineAfterIndexReduction = true".

These functions are not inlined, the Pantelides algorithm is applied and the equations are aymbolically differentiated.
The functions are inlined and further symbolic transoformation is performed (sorting the equations, dummy derivative method etc..

The test model contains the following functions that have annotation "InineAfterIndexReduction = true":

MultiBody.Frames.resolve1/resolve2(..) functions are used to transform the coordinates of a vector in another coordinate system. When these functions need to be differentiated in the Pantelides algorithm, then Eulers differentiation rule is applied with the angular velocity that is usually a factor of 2-3 more efficient as if direct differentation is applied. The drawback is that the sparsity structure is more "coarse" and this lets the Pantelides algorithm fail in this example (this happens usually only in systems with kinematic loops). This means that the differentiated equation system is structurally singular, after the functions with annotation "InineAfterIndexReduction = true" are inlined.
The Rotational.Sources.Move block is using internally functions to express that an input u[2] is the derivative of of input u[1]. In order that this is possible, the functions have the annotation "InineAfterIndexReduction = true" so that the differentiation takes place with the not inlined functions. After the Pantelides algorithm and the differentation is applied, the functions are inlined to enhance efficiency.
The problem with (1) is that after inlining the functions with annotation "InineAfterIndexReduction = true", the equations are structurally singular, but the source of the singularity is now known. One remedy is to restart symbolic processing and to inline all functions with "InineAfterIndexReduction = true" before the Pantelides algorithm is applied. In the model, this approach is in principal succeessful and the model would be structurally regular. However, the Move block is no longer working correctly if the Pantelides algorithm is appliwed with inlining. For this reason in MSL 3.2.1 build 3, the annotation "InineAfterIndexReduction = true" in the Move block has been replaced by annotation "Inline = false". This results in slightly less efficient code, but is more robust in the situation at hand.

Comment by otter on 15 Jan 2016 10:19 UTC
Re-opened, since this change has the effect that Modelica.Mechanics.Rotational.Examples.GenerationOfFMUs does not longer translate in Dymola.

Comment by otter on 15 Jan 2016 13:27 UTC
Based on an email discussion with Sven Erik Mattsson my current understanding is the following:
The "InlineAfterIndexReduction=true" annotation is or was present in

Modelica.Mechanics.Rotational.Sources.Move in order handle input signals where the variable u, its first, and its second derivative are provided from the "outside" of Modelica and in Modelica the translator needs to be informed that the derivatives of u are also external signals.
Modelica.Mechanics.MultiBody.Frames.resolve1/.resolve2 in order to perform differentiation of kinematic equations, without differentiating the orientation matrix (but using Euler's differentiation rule with the angular velocity instead).

The purpose of  "InlineAfterIndexReduction=true" is to perform Pantelides and BLT with the non-inlined form, then inline and use the inlined form for state selection and for better efficiency. Unfortunately, there are a few multi-body systems (usually with kinematic loops), where the structural analysis with the non-inlined form indicates a singular system, although it is not. Once Dymola recognizes this, it tries to inline all functions with "inlineAfterIndexReduction=true" and then applies Pantelides/BLT again (for multi-body systems this means that the efficiency is usually greatly reduced, because the orientation matrix is then differentiated twice; however having an inefficient solution is better as having no solution).
The Move block is defined in such a way that output signal phi = position(u,time) and u is a vector of three input signals(say u[3] = {q,qd=der(q), qdd=der(der(q)) and when phi needs to be differentiated then the provided derivative function of position is utilized. Therefore, to get this differentiation of functions correct, function position must not be inlined, but the provided function position_der and position_der2 used during Pantelides/BLT. For this reason, originally the annotation "InlineAfterIndexReduction=true" was used here.
Now, the problem is that if "inlineAfterIndexReduction" functions are inlined (because "resolved" functions failed), then also the Move functions are inlined too. The result is that a combination of the corresponding multi-body system together with a Move block will fail (for example: ModelicaTest.MultiBody.PlanarLoopWithMove), because the Move functions will fail to work correctly when they are inlined before Pantelides/BLT is applied. Due to this reason the "InlineAfterIndexReduction=true" annotation of the Move block has been replaced by "Inline=false", that is the block is never inlined.
Unfortunately, at that time it was not detected that the Move block will fail if it is not inlined before the state selection algorithm (for the state selection it is important to have the "correct" functional dependency of phi=f(q) and if the Move functions are not inlined then a very bad dependency will make the state selection fail). Due to "Inline=false", the Move block will not be inlined and therefore it will fail in cases where the Move block is involved in state selection, as in model Modelica.Mechanics.Rotational.Examples.GenerationOfFMUs).
The question is what to do? One possibility would be to introduce an additional annotation, say "strictInlineAfterIndexReduction = true" that defines that the corresponding function is NEVER inlined before Pantelides/BLT. This annotation could be defined in the Move block and then the problems above would be solved. However, this can only be done in a new Modelica release and then MSL must be allowed to use this annotation. So this solution would only be applicable in several years and not for MSL 3.2.2. Another (better) possibility would be to introduce a special language element that explicitly defines the relationships of three input signals (that one is the derivative of the other one). Again, such a solution would only be available in several years.
The Move block has the additional feature that the "noDerivative" annotation is used (because the "u" vector argument shall not be differentiated when function position(u) is differentiated). Sven Erik and Hans propose to utilize this feature: If annotation Inline=false is present, then the tool should avoid to inline according to the specification. However, if state selection fails and the function has the "noDerivative" annotation, then this is an indication that a situation as for the Move block is present. It is then proposed to make another try and inline the function before the state selection. However, this approach will not work for the current Move block, because the block has an additional, second dummy argument, "called dummy"). When the Move block is called, actually "time" is given for this dummy argument ("phi = position(u,time)"). I do no longer understand why this dummy argument is needed. Sven Erik and Hans propose to just remove it. If it is removed, then there remains just one argument with the "noDerivative" annotation and the sketched approach can be used.
To summarize, it is proposed to remove the "dummy" argument from the protected position/position_der/position_der2 functions in the Move block. This is a backwards compatible change (because these functions are defined in the protected section). Tools, like Dymola, would have then to implement the strategy sketched above.
If there is no counter proposal or a reason why this solution will lead to yet other issues, I will fix this as indicated.

Comment by otter on 15 Jan 2016 13:37 UTC
Fixed in 807dfa2ebd10e728f97e712fe28f48b90eb9e970 as suggested by removing the "dummy" argument from the internal functions in the protected sections of blocks:

Modelica.Mechanics.Rotational.Sources.Move
Modelica.Mechanics.Translational.Sources.Move

This ticket is not closed until tool support (especially Dymola) shows that this fix works as expected.

Comment by hansolsson on 19 Jan 2016 08:46 UTC
I realized that the code-generation will also be influenced in a bad way by this (the trivial functions should not be inlined).
One solution would be to use "LateInline=true" (instead of "Inline=false" or previous "InlineAfterIndexReduction=true") - similarly as for property caching.
However, it still needs to fixed to work as expected and I have not investigated if this may cause other problems.

Comment by otter on 21 Jan 2016 07:31 UTC
Fixed in 3432a2218e1a4ff83dc1bd67f799aac6f6644eb4, according to the suggestion from Hans and Sven Erik:
Updated Move blocks of the Translational and Rotational library:

Re-introduced the dummy argument (still not yet known why it is here, but just in case, and it does not hurt)
changed annotation to LateInline=true.
Tested these changes with all test models in Modelica and ModelicaTest where the Move blocks are used (with Dymola 2017 dev4)

Changelog modified by otter on 21 Jan 2016 07:31 UTC
Usage of Move blocks of Rotational or Translational library sometimes failed. This has been fixed

Comment by sjoelund.se on 21 Jan 2016 09:29 UTC
Are there examples in Modelica(Test?) for testing this or do we need to use the attached models?

Comment by otter on 21 Jan 2016 09:36 UTC
Replying to [comment:7 sjoelund.se]:

Are there examples in Modelica(Test?) for testing this or do we need to use the attached models?

The critical examples are:

Modelica.Mechanics.Rotational.Examples.GenerationOfFMUs
ModelicaTest.MultiBody.PlanarLoopWithMove

Other Move examples are here:

ModelicaTest.Rotational.TestMove
ModelicaTest.Rotational.AllComponents
ModelicaTest.Rotational.TestBearingConversion


PaaS GUI - Design

PaaS GUI - Design

Hi @gc4rella please don't merge this yet. I've fix all the conflicts, but still have to test everything on the development testbed today.

I've made the changes requested in google doc. If something regarding front end is missing tell me and I will fix it.

👍 @victorjeman.
@gc4rella this is ready to be merged


sailfish output to limma

Hi,
So I have run bcbio-nextgen pipeline for RNA-seq analysis and now I am interested in differential isoform quantification. Should I use the output file: combined.isoform.sf.tpm directly as input to the limma package?
Thanks in advance!

Hi @zahrahaider,
We recommend using the bootstrap estimates for transcript expression from Sailfish that are in the final/sample/sailfish directories as input to Sleuth. We have a standalone repository to set that up for you here, if you pass along the --sleuth option and a formula you want to fit. This won't actually run Sleuth, but it will set everything up for you.
https://github.com/roryk/bcbio.rnaseq

You can also install it as a conda package:
conda install -c bioconda bcbio-rnaseq

Thanks alot for the response.

Great!


KeyBindings: Inconsistent When Clause editing

Insiders: 3-3-19
Windows10
Issue Type: Bug
Editing the when clauses produces inconsistent results:

Try editing first entry "Add Cursor Above"

Try changing to "editorFocus" - remains original value

Change to "editorTextFocus && !editorReadonly" - should stick

Try editing to original  "editorTextFocus" - entry remains as above

Reset binding - should be able to change again

Also there does not seem to be a way to change an existing entry to blank "--" for a global entry

VS Code version: code-oss-dev 1.33.0 (Commit unknown, Date unknown)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8700K CPU @ 3.70GHz (12 x 3696)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
31.87GB (19.40GB free)

Process Argv
.

Screen Reader
no

VM
0%

Extensions (1)

Extension
Author (truncated)
Version

vscode-pull-request-github
Git
0.4.0

@cleidigh Are you doing your edits in the "UI":

or in keybindings.json?

@alexandrudima
The problem and reproduction steps were done within the UI.
Issue 1: Once you have edited a when clause once, a second edit does not work ( the clause remains the value after the first edit)
If you reset the binding then you can change it again once.
My first example changes editorTextFocus -> editorTextFocus && !editorReadonly (successful)
Now try to change to anything else original, drop the negation or delete everything (no change accepted)
Edits to the JSON file directly appear to behave correctly.
Issue 2:  I have no way within the UI to change a when clause to blank (no clause)


Keep jackson-databind in alignment with OpenSearch

Description
While addressing CVE-2020-36518 the security team updated to the latest
minor version of jackson-databind, whereas the OpenSearch team took the
CVE specific update.  Aligning with OpenSearch's version.
Issues Resolved

Resolves the build break associated with https://github.com/opensearch-project/OpenSearch/issues/2597

Check List

[ ] ~New functionality includes testing~
[ ] ~New functionality has been documented~
[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1817 (f3dcb1e) into 1.3 (ce18577) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                1.3    #1817      +/-   ##
============================================
- Coverage     64.64%   64.58%   -0.06%
+ Complexity     3219     3218       -1
============================================
  Files           247      247
  Lines         17363    17362       -1
  Branches       3086     3077       -9
============================================
- Hits          11224    11214      -10
- Misses         4590     4592       +2
- Partials       1549     1556       +7

Impacted Files
Coverage Δ

...ava/com/amazon/dlic/auth/ldap2/MakeJava9Happy.java
39.13% <0.00%> (-4.35%)
:arrow_down:

.../org/opensearch/security/support/ConfigHelper.java
80.39% <0.00%> (-1.97%)
:arrow_down:

...com/amazon/dlic/auth/ldap2/PrivilegedProvider.java
49.18% <0.00%> (-1.64%)
:arrow_down:

.../org/opensearch/security/auth/BackendRegistry.java
58.85% <0.00%> (-0.53%)
:arrow_down:

...ic/auth/ldap/backend/LDAPAuthorizationBackend.java
57.57% <0.00%> (-0.38%)
:arrow_down:

...zon/dlic/auth/ldap2/LDAPAuthorizationBackend2.java
28.35% <0.00%> (-0.38%)
:arrow_down:

...a/org/opensearch/security/tools/SecurityAdmin.java
47.39% <0.00%> (-0.20%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce18577...f3dcb1e. Read the comment docs.


Where did the alvr-nightly AUR package go?

Description
There used to be an AUR package for ALVR called alvr-nightly. This package seems to have disappeared now, but is still mentioned on the wiki. Is it meant to be gone from the AUR?
General Troubleshooting

[ ] I carefully followed the instructions in the README and successfully completed the setup wizard
[x] I read the ALVR Wikis here and here

Environment
Hardware
Note: for Linux, an upload to the hw-probe database is preferred: hw-probe -all -upload
CPU:
GPU:
Audio:
Installation
ALVR Version:
alvr-nightly
SteamVR Version:
Install Type:

[x] Packaged (exe, deb, rpm, etc)
[ ] Portable (zip)
[ ] Source

OS Name and Version (winver on Windows or grep PRETTY_NAME /etc/os-release on most Linux distributions):
Arch linux

Have you tried alvr-git?

Currently I am not at my computer, but I did try it and the build seemed to fail. If it helps I can try to build it again and send the logs in here

You can run ALVR-x86_64.AppImage instead of building it.

the build should work again as of https://github.com/alvr-org/ALVR/commit/2dab06b1cfb274c694d529bbc48caee40cfa3054

the build should work again as of 2dab06b
The AUR package site is deleted, how would that work?

as i mentioned above, it's alvr-git now.

as i mentioned above, it's alvr-git now.

wouldn't a git package be for the latest commit pushed to the repo?

which is also what the nightly pipeline builds once every 24h.
if you're looking for an aur that grabs the tar.gz binaries and installs them on your system, that most likely won't happen, as there are plans to discontinue the tar.gz binary builds. they are not compatible with some of the major distros and are a big cause of confusion for linux users.
the two main options are to build it yourself or to use the appimage. alvr-git will do the former for you.

I just checked and alvr-git does seem to build again. So with that I'm closing this issue.

The problem is that in the installation guide, it references installing the alvr-nightly aur package, but that package no longer exists, so I suggest updating the guide to replace all mentions of it with alvr-git.


it always says this test is secured

Use this: https://github.com/RichardKanshen/edupagehackextended

didint change anything

Use this: https://github.com/RichardKanshen/edupagehackextended

Did you follow the tutorial?

Is it not the same as this one here?

Listen, just do what the tutorial says, that's all.

yeah i found it still having trouble some files are missing like the empty file and other stuff

If you have trouble then make an issue report on the fork. Hopefully the guy may help with whatever problem you're having.

yeah i found it still having trouble some files are missing like the empty file and other stuff

You are getting an empty file?


Ability to change cursor height.

I know that this issue has been created twice already (#100492 and #27931), but we are still looking for this feature, that sublime text already had for YEARS

Requested since 2017 🙏


ATS should reject connections where the client offered ALPN does not have a match with the ATS list

Internally we've been discussing the cross-application attacks discussed in https://alpaca-attack.com/ALPACA.pdf.  And those discussions got us looking at how ATS handles ALPN.
Currently ATS will try to find a matching protocol if the client offers an ALPN entry.  If there is no match, ATS continues on and assumes HTTP/1.1.  If no ALPN string is offered (presumably an older client), ATS continues on and assumes HTTP/1.1
Looking at a snapshot of one of our production boxes logs, we see 92% of the client connections offer ALPN.  In this sample, no client requests that offered ALPN failed to get a protocol match with our ATS server which was willing to accept h2 and http/1.1.
To support older clients (8% of our requests), it is not feasible to stop accepting requests without ALPN. However, we should stop accepting requests where the ALPN string has no match.  Based on our logging, that seems unlikely to be an innocent mistake, but rather that the attacker is trying to poke at our security stance.

RFC 9001, which is part of QUIC, clearly says a connection must be closed immediately if an application protocol is not negotiated.
https://datatracker.ietf.org/doc/html/rfc9001#section-8.1


Added Unit test coverage for Kustomize V3 Iac-provider

Fix #379

I believe, there is scope for adding test cases for testing various error conditions.
For eg:

In LoadIacDir, a test case can be added to check the error when kustomization.yaml is not present in the user provided directory
Thanks for reminding. Missed that case.

Similarly, a test case for checking the error conditions when more than 1 kustomization.yamls are present.
you can't have more than one file with the same name in a directory (as per OS constraints). So that part is taken care of already.

Another, test case is possible for an empty kustomization.yaml
Yep


migrate github actions to whatever package they are wrapping

if there would be a need for an github action (such as rmarkdown::render_site()) (rather than a full workflow for *.rmd-projects as per #325), perhaps those actions should just live in whatever pkg they're wrapping?
That might make things easier.
They could just be .Rbuildignored, and it's just 2 files at root.
Not sure.

nah, too difficult to sync what needs to be in sync between the actions (i.e. images, lib locations etc.)


add shortest path algorithms in java.

I would love to work on this algorithms for hacktoberfest.
Please assign me this task.

Closing in favor of #80 .
Thank you for showing interest in contributing. 😃
@jinicode please create a PR having the algorithms implemented, I'll merge them.
Also have a look at: https://github.com/amanmehara/programming/blob/master/CONTRIBUTING.md


TypeError: currentPropName.toLowerCase is not a function in sort-prop-types

The rule sort-prop-types (with ignoreCase: true) will produce this error when using PropTypes.shape with a number as a key.
Here's an example to reproduce this issue
import React from 'react';
import PropTypes from 'prop-types';

export default function Component({ numberToNameMap }) {
  return
{numberToNameMap[0]}
;
}

Component.propTypes = {
  numberToNameMap: PropTypes.shape({
    0: PropTypes.string.isRequired,
  }).isRequired,
};

The error occurs at this line https://github.com/yannickcr/eslint-plugin-react/blob/v7.12.4/lib/rules/sort-prop-types.js#L192.
Using a string instead of the number as the key when defining the propTypes avoid this issue
import React from 'react';
import PropTypes from 'prop-types';

export default function Component({ numberToNameMap }) {
  return
{numberToNameMap[0]}
;
}

Component.propTypes = {
  numberToNameMap: PropTypes.shape({
    '0': PropTypes.string.isRequired,
  }).isRequired,
};

I'm not sure if using a number instead of a string as a key is "idiomatic" React; I didn't see an example of this in the React documentation either way.

It’s not idiomatic JS, but it still should work :-)

I agree, that object keys shouldn't be declared as numbers. It's something you should avoid, but this error shouldn't happen. I created PR that should fix this issue. Please checkout https://github.com/yannickcr/eslint-plugin-react/pull/2230


HTML logger use  tag instead of JavaScript in template

Description
Currently in the HTML logger template there is a JavaScript which helps to expand and collapse the test result.
https://github.com/microsoft/vstest/blob/ac4adfabc6df702c8ee0ce028599960ff7b3399f/src/Microsoft.TestPlatform.Extensions.HtmlLogger/Html.xslt#L14-L24
Steps to reproduce
dotnet test --logger html
Expected behavior
Test result page does not use additional JavaScript to enable interactions so that it can be used as a test summary page in GitHub actions.
Actual behavior
The script tag and its contents are rendered as text in the GitHub actions summary.
Diagnostic logs
None
Environment
Build version: current version (code is in main branch)

@nohwnd Are you aware of any scenario that would get broken by such change in the html report? I am not sure if we consider the shape of the html report as some kind of public API that cannot be changed or if that's just a by product we can update as we pleased.

I can't see why someone would want to rely on the format of that html output, and it support of <summary> and <details> tags seems ok. So I think we can go for it:
https://caniuse.com/details


Documentation to put direct on Sonar Online

Hello, I need to put an application in ionic 2 in solar online, but even using its model as a base I can not, is there another version only for sonar online?

I'm not sure what you're asking here I'm afraid, what's Sonar Online?

I'm so sorry about how I formulated the question. I need to test a ionic 2 app with travis and sonar, but I dont have the server like you. I do use the free online server (sonarqube.com) and what I'd like to know is if it exists a way to scan the ionic 2 app with sonarqube without having an own server

Oh I see! Yeah, the plugin isn't installed on the public SonarQube instance, I suspect I need to get it in their Update Centre to get it there, unclear, but will be seeking to do that with the full 1.1 release over the next couple weeks. However - my demo server's hosted on AWS using the first-year-free instance hours, so you can get something spun up for very little cost if you need to (bit of a faff getting everything installed, but doable).


HDDS-1341. TestContainerReplication#testContainerReplication fails intermittently

The test fails intermittently. The link to the test report can be found below.
https://builds.apache.org/job/PreCommit-HDDS-Build/2582/testReport/
{code:java}
java.lang.AssertionError: Container is not replicated to the destination datanode
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertNotNull(Assert.java:621)
at org.apache.hadoop.ozone.container.TestContainerReplication.testContainerReplication(TestContainerReplication.java:139)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)
{code}
See: https://issues.apache.org/jira/browse/HDDS-1341

The 3 seconds to wait for the replication may not be enough. I added a counter to check the replication state instead of the dumb wait.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
30
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
76
Maven dependency ordering for branch

+1
mvninstall
551
trunk passed

+1
compile
299
trunk passed

+1
checkstyle
79
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
920
branch has no errors when building and testing our client artifacts.

+1
javadoc
152
trunk passed

0
spotbugs
326
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
532
trunk passed

_ Patch Compile Tests _

0
mvndep
33
Maven dependency ordering for patch

+1
mvninstall
483
the patch passed

+1
compile
294
the patch passed

+1
javac
294
the patch passed

+1
checkstyle
83
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
707
patch has no errors when building and testing our client artifacts.

+1
javadoc
149
the patch passed

+1
findbugs
522
the patch passed

_ Other Tests _

-1
unit
173
hadoop-hdds in the patch failed.

-1
unit
1162
hadoop-ozone in the patch failed.

-1
asflicense
50
The patch generated 17 ASF License warnings.

6488

Reason
Tests

Failed junit tests
hadoop.ozone.web.client.TestKeys

hadoop.ozone.client.rpc.TestBCSID

hadoop.ozone.container.common.impl.TestContainerPersistence

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-862/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/862

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 1583e51bf3c4 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 4a692bc

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-862/1/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-862/1/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-862/1/testReport/

asflicense
https://builds.apache.org/job/hadoop-multibranch/job/PR-862/1/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
4226 (vs. ulimit of 5500)

modules
C: hadoop-hdds/container-service hadoop-ozone/integration-test U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-862/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

+1 LGTM.
Thank You @elek for the fix.
I will commit this.


link libonedal_dpc.so with libonedal_sycl.a due to mkl depency issue

Description
daal4py compatibility with MKL fpk updates (on linux).
Changes proposed in this pull request:
-Additional library linked to resolve undefined references due to dependencies between MKL libraries
To verify:
-Activate conda environment and install dependencies
-Set MPIROOT=$CONDA_PREFIX, TBBROOT=$CONDA_PREFIX, DPCPPROOT=.../compiler/2022.2.0/{system}
-Source env/vars.sh from oneDAL build with updated MKL fpk
-Source compiler env/vars.sh
-Clone Intel extension for scikit-learn
-Run "python setup.py develop --no-deps && python setup_sklearn.py develop --no-deps
-Run any examples/daal4py/ and /examples/daal4py/sycl scripts

from circleci: g++: error: unrecognized command-line option ‘-fsycl’

There is no "link libonedal_dpc.so with libonedal_sycl.a due to mkl depency issue" related changes here, as PR declares. Only compiler updates. Lets move last changes to #1067 and merge that PR1067 to develop.

/intelci: run

/intelci: run


Create C++ data structures to represent the IR

I don't think this should not be a direct 1-to-1 translation from manifest.proto to C++. The C++ data structures should be at a higher abstraction level.

https://github.com/google-research/raksha/pull/51 from @aferr is related.


ODataJsonLightPropertyAndValueDeserializer_ReadPropertyValue Error On Complex Return Types

I'm not sure If this is an issue with how Simple.OData.Client calls it, or Microsoft.OData.Core itself, but after updating past 4.29.0 I get the following error any time I call an action that returns a ComplexType:

Microsoft.OData.ODataException
HResult=0x80131509
Message=An internal error 'ODataJsonLightPropertyAndValueDeserializer_ReadPropertyValue' occurred.
Source=Microsoft.OData.Core
StackTrace:
at Microsoft.OData.JsonLight.ODataJsonLightPropertyAndValueDeserializer.ReadNonEntityValueImplementation(String payloadTypeName, IEdmTypeReference expectedTypeReference, PropertyAndAnnotationCollector propertyAndAnnotationCollector, CollectionWithoutExpectedTypeValidator collectionValidator, Boolean validateNullValue, Boolean isTopLevelPropertyValue, Boolean insideComplexValue, String propertyName, Nullable`1 isDynamicProperty)

I'm able to call the actions successfully through other methods such as postman, and I can see from adding logging to OnTrace in my ODataClient that the method is returning 200, it just can't parse the resulting object.
It doesn't seem to matter what the properties of the ComplexType are, even an object with no properties returns this error. If I Configure them on the API side to instead to be EntityTypes or downgrade Simple.OData.Client back to 4.29.0 they can be called without error.

Can you send me the result from Postman and your service Metadata document?

Postman:

Metadata:
<edmx:Edmx Version="4.0" xmlns:edmx="http://docs.oasis-open.org/odata/ns/edmx">
    <edmx:DataServices>
        <Schema Namespace="ApiActionExample.Model" xmlns="http://docs.oasis-open.org/odata/ns/edm">
            <ComplexType Name="ExampleComplex">
                <Property Name="SomeProperty" Type="Edm.String" />
                <Property Name="SomeOtherProperty" Type="Edm.Int32" Nullable="false" />
            </ComplexType>
            <EntityType Name="ExampleEntity">
                <Key>
                    <PropertyRef Name="ID" />
                </Key>
                <Property Name="ID" Type="Edm.Int32" Nullable="false" />
                <Property Name="SomeProperty" Type="Edm.String" />
            </EntityType>
        </Schema>
        <Schema Namespace="Default" xmlns="http://docs.oasis-open.org/odata/ns/edm">
            <Action Name="ExampleAction" IsBound="true">
                <Parameter Name="bindingParameter" Type="Collection(ApiActionExample.Model.ExampleEntity)" />
                <ReturnType Type="ApiActionExample.Model.ExampleComplex" />
            </Action>
            <EntityContainer Name="Container">
                <EntitySet Name="ExampleEntity" EntityType="ApiActionExample.Model.ExampleEntity" />
            </EntityContainer>
        </Schema>
    </edmx:DataServices>
</edmx:Edmx>```

Thanks. I suppose you are using .NET FX, not .NET Core. If it's NET Core, then it may be fixed in 5.1.

Yes I'm using .Net FX

@AlexaHLE I managed to reproduce the error. It was caused by changes in Microsoft.OData.Core V7. Fix will be released in 5.2.0.

@object Thank you for fixing this so quickly. Do you have a timeline for when 5.2.0 will be available in NuGet?

It's released now.

Hello! I'm working on the same project and we have run into a secondary issue after this fix was applied (we are now at version 5.2.1), We have found that the ODataClient is returning values in an unexpected way. For example, we have a call made using the client as follows:
IDictionary<string, object> response = await client.For("ExampleEntity").Key(key).Action("ExampleAction").ExecuteAsSingleAsync();
Previously this would return a dictionary with keys for the properties like this:
SomeProperty : test
SomeOtherProperty : 1
However after the update, the dictionary instead contains a key called "__result" and contains all the OData information as the value:
__result<EMAIL_ADDRESS>: "http://localhost/App/$metadata#ApiActionExample.Model.ExampleComplex", "SomeProperty" : "test", "SomeOtherProperty" : "1"}
I've found that if I pull out the value and desrialize it, everything does work like before, but it seems like the __result shouldn't be returned by the client, it should already be unwrapped when it returns from the Execute method.
We have also tried using the For<ExampleComplex> overload that returns the object rather than a dictionary. While this does return the object, none of the properties are set.
All of our javascript calls to the OData methods work correctly, it is only when using the ODataClient object on the server side that we experience any problems.

@andrewcot The best would be if you open another issue so it will be easier to track it. Paste there what you wrote here plus the following:

What version broke the correct behavior? You have this problem in 5.2.1. What was the last version when it worked for you?
Is the metadata document the same that @AlexaHLE  sent earlier?
What was the OData response from the server when this OData action was called?

Opened issue 486 as requested

Thanks!


Pointer swaps for agent xmachine_memory_*_lists

@mondus suggested that under certain conditions it should be possible to avoid using append_<agentname>_Agents kernels to move agents from one state to another during agent functions.

If currentState == nextState, it should be safe to do a simple pointer swap.

If there are no function conditions and reallocate==false
Global conditions should be fine.

If there is a state change (currentState != nextState), and the population of the nextState == 0 then a pointer swap should be possible

If there are no function conditions and reallocate == false.
Possible edge case: multiple agent functions in the same layer have the same nextState

If the

When reallocate == true, it may be possible to still do the pointer swap

It depends on the reallocation process, needs to be looked into.

The case of functions which create agents needs to be considered.

The cost of the append function is relatively small compared to typical agent functions, however, for large agent populations with large numbers of agent parameters the cost will be insignificant.
For the keratinocyte model with only 1024 agents and the append kernel only takes ~4μs per invocation plus any kernel sync overheads, however this is a very small agent population.

 Covers my use case

ed4dd38 addresses an issue where if agents are output by an agent function then the pointer swap cannot be used (as the swap memory is used to store data about the new agents).


Error: Cannot find module 'WorkingDirPath '

Expected Behavior
I should be able to specify both a startup file/script and command-line arguments to that script.
Actual Behavior
The newest Dev Build of NTVS (for VS.2015) gives the error (the subject of this issue). Seems that 'WorkingDirPath<StartupFile> <ScriptArguments>' is getting passed into npm module resolving as "a" single module itself.

NTVS Version: https://github.com/Microsoft/nodejstools/releases/tag/v1.3.Dev-03.06.2017
Visual Studio Version: VS.2015.3
Node.js Version: 6.10.1
TypeScript Version: 2.1.6

Reverting to https://github.com/Microsoft/nodejstools/releases/tag/v1.2.RTW got things back working.
Steps to Reproduce

Have an *.njsproj with both <ScriptArguments> & a <StartupFile> specified.
Hit F5 to start debugging.

This also happens on Visual Studio 2017 after upgrading to 15.1

Found the issue this should be fixed in 15.2 and Node 1.3 RTM

Is it possible to install a pre-release of either 15.2 or Node 1.3? Or maybe or workaround?

We haven't put this change in 15.2 yet, but we do expect this to be in the next pre-release. (The other solution is to build the project yourself.)


refactor: logic structure on if-else-if jwt

Hello @sevilayha,
Thanks again for being swift in getting back to me on errata submissions --appreciate it!
I wanted to highlight a quick refactor that perhaps you have considered but debated on. The flow of logic when it comes to the authentication API route seems to be out-of-place with the addition of an else-block. That is, you consider the validation of a user and the password that is sent via POST.
Using the else-block implies a fall-back on the logic the precedes it --whether that passes or fails. It would be more straightforward to withhold this block as it is already implied that the proceeding statements will execute in case of success.

To play devils advocate, allowing the else-statement embraces explicitly --which is beneficial for a mutually exclusive item. But I would argue, in this example, that this statement is mutually exclusive without the else-block. Plus, it cuts down on indentation.

NVM: I see why you included it, being explicit prevents:
http.js:689
    throw new Error('Can\'t set headers after they are sent.');

Yea I struggled with this one. Tried keeping it nice and clean in the beginning, but couldn't get around the headers problem. Thanks for the input.


cloud: Team roles and responsibilities

Originally written by the Cloud team during the offsite. Original notes found here:
https://miro.com/app/board/uXjVPMmn4i4=/

close https://github.com/sourcegraph/handbook/pull/5365


Quickstart assumes readers know what a Gradle plugin is

As someone who is reading the Smithy 2.0 quick start documentation, coming from smithy-rs, I don't have a working Java/JVM environment.
The docs tell me that the  way to build the model is with a Gradle plugin. I don't know how to install a Gradle plugin. Going to the plugin's documentation doesn't describe how to use it.

Actually, immediately after filing this issue, I noticed the sentence a few paragraphs below

(make sure you have gradle installed)


Removed source from the TaskiqSchedule.

The source field in the TaskiqSchedule class seemed to be redundant for me. It was adding unnecessary complexity for the extensions API. This change is incompatible with the previous version.
Signed-off-by: Pavel Kirilin<EMAIL_ADDRESS>

Codecov Report

Merging #218 (3b85174) into develop (e66f3aa) will increase coverage by 6.02%.
Report is 137 commits behind head on develop.
The diff coverage is 74.01%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@             Coverage Diff             @@
##           develop     #218      +/-   ##
===========================================
+ Coverage    67.62%   73.64%   +6.02%
===========================================
  Files           37       55      +18
  Lines          942     1624     +682
===========================================
+ Hits           637     1196     +559
- Misses         305      428     +123

Files
Coverage Δ

taskiq/__init__.py
100.00% <100.00%> (ø)

taskiq/abc/formatter.py
100.00% <100.00%> (ø)

taskiq/abc/middleware.py
100.00% <ø> (ø)

taskiq/abc/result_backend.py
100.00% <ø> (ø)

taskiq/abc/serializer.py
100.00% <100.00%> (ø)

taskiq/acks.py
100.00% <100.00%> (ø)

taskiq/api/__init__.py
100.00% <100.00%> (ø)

taskiq/cli/common_args.py
100.00% <100.00%> (ø)

taskiq/cli/watcher.py
0.00% <ø> (ø)

taskiq/cli/worker/log_collector.py
100.00% <ø> (ø)

... and 42 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Misstatement in definition of Partial<T>

The definition of Partial<T> states:

Constructs a type with all properties of T set to optional. This utility will return a type that represents all subsets of a given type.

To paraphrase Inigo Montoya: You use the word "subset". I do not think it means what you think it means.
A "type with all properties of T set to optional" does not represent subsets of T.
Examples of "subsets of a given type":

given type: real number, some subsets: rational number, integer
given type: number | string | null, some subsets: number, number | null

I know what the author is trying to say, but can't come up with the right words, though I probably should have spent more time on that than what I've put into this Issue so far 😂.

I know what the author is trying to say,

Now that you've brought it up, I've realized I have no idea what the author is trying to say in the second sentence.  Partial<T> only returns the params of the targeted type with the optional flag on each one, doesn't it?  Does something else happen if the targeted type is something other than an object literal?


pull request for e2e test at 11/08/2016 16:26:09

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

Details

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


NETOBSERV-994 FLP multiarch consistency

These changes brings consistency between netobserv components

added shortcuts
use the same target for multi arch / single arch relying on MULTIARCH_TARGETS array

The default is currently amd64 arm64 ppc64le but I'm fine to set only amd64 if you prefer

renamed variables and targets so every repo can run the same targets such as:

IMAGE_ORG=jpinsonn VERSION=multiarch make images to push all images and manifest
MULTIARCH_TARGETS=amd64 make image-build image-push to push a single amd64 image to quay.io/netobserv/flowlogs-pipeline:latest-adm64

$ make help

Usage:
  make <target>

General
  help                  Display this help.
  vendors               Check go vendors

Develop
  lint                  Lint the code
  build                 Build flowlogs-pipeline executable and update the docs
  docs                  Update flowlogs-pipeline documentation
  clean                 Clean
  tests-unit            Unit tests
  tests-fast            Fast unit tests (no race tests / coverage)
  tests-e2e             End-to-end tests
  tests-all             All tests
  benchmarks            Benchmark
  run                   Run

Images
  image-build           Build MULTIARCH_TARGETS images
  image-push            Push MULTIARCH_TARGETS images
  manifest-build        Build MULTIARCH_TARGETS manifest
  manifest-push         Push MULTIARCH_TARGETS manifest
  build-ci-images       Build CI images
  push-ci-images        Push CI images

kubernetes
  deploy                Deploy the image
  undeploy              Undeploy the image
  deploy-loki           Deploy loki
  undeploy-loki         Undeploy loki
  deploy-prometheus     Deploy prometheus
  undeploy-prometheus   Undeploy prometheus
  deploy-grafana        Deploy grafana
  undeploy-grafana      Undeploy grafana
  deploy-netflow-simulator  Deploy netflow simulator
  undeploy-netflow-simulator  Undeploy netflow simulator

kind
  create-kind-cluster   Create cluster
  delete-kind-cluster   Delete cluster
  kind-load-image       Load image to kind

metrics
  generate-configuration  Generate metrics configuration

End2End
  local-deploy          Deploy locally on kind (with simulated flowlogs)
  local-cleanup         Undeploy from local kind
  local-redeploy        Redeploy locally (on current kind)
  ocp-deploy            Deploy to OCP
  ocp-cleanup           Undeploy from OCP
  dev-local-deploy      Deploy locally with simulated netflows

shortcuts helpers
  build-image           Build MULTIARCH_TARGETS images
  push-image            Push MULTIARCH_TARGETS images
  build-manifest        Build MULTIARCH_TARGETS manifest
  push-manifest         Push MULTIARCH_TARGETS manifest
  images                Build and push MULTIARCH_TARGETS images and related manifest
  ci-images-build       Build CI images
  ci-images-push        Push CI images
  ci-images             Build and push CI images

Related PRs:

https://github.com/netobserv/netobserv-ebpf-agent/pull/100
https://github.com/netobserv/network-observability-console-plugin/pull/298
https://github.com/netobserv/network-observability-operator/pull/285

@jpinsonneau did you see this issue: #423 ? I was wondering if that could also impact what you're doing (I don't think so, but haven't had time to look closely)

@jotak I suggest to address this in a separate PR
We need to create our own docker image, save it to netobserv quay (I can't push as maintainer :crying_cat_face: ) and then update the builder images in all of our components passing --build-arg GO_VERSION=1.19.8 in build_target functions

/approve


redi2-redi compatibility

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 211 (0.47%)  changed or added relevant lines in 4 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 26.023%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

ValveResourceFormat/Resource/ResourceTypes/Material.cs
0
16
0.0%

ValveResourceFormat/Resource/Blocks/ResourceEditInfo2.cs
0
48
0.0%

ValveResourceFormat/Resource/Blocks/RED2Structs/RED2Block.cs
0
146
0.0%

Files with Coverage Reduction
New Missed Lines
%

ValveResourceFormat/Resource/Blocks/ResourceEditInfo2.cs
3
0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
4551

Relevant Lines:
18189

💛  - Coveralls


Fix BaseFilterSet not using multiple choice filters

Closes: #3214
What's Changed

Override BaseFilterSet.filter_for_lookup to add logic that checks if the lookup type is exact and if the field has attribute choices (as only IntegerField/CharField with choices can have this attribute), and returns MulipleChoiceFilter if the conditions are meet.
I also removed this block of code elif existing filter.extra.get("choices") because we now expect the choice field to be MulipleChoiceFilter, which would require all relevant lookup expressions of a MulipleChoiceFilter to be included.

TODO

[ ] Explanation of Change(s)
[ ] Added change log fragment(s) (for more information see the documentation)
[ ] Attached Screenshots, Payload Example
[ ] Unit, Integration Tests
[ ] Documentation Updates (when adding/changing features)
[ ] Example Plugin Updates (when adding/changing features)
[ ] Outline Remaining Work, Constraints from Design

It does not seem to have any impact on UI filtering both on Default and Advance


Upgrade to 2.9.0 causes Android build failure: COMPILETODALVIK PARSE error

Steps to reproduce :scroll:

Upgrade via NuGet to 2.9.0

Rebuild Android project

Expected behavior :thinking:
Successful build
Actual behavior :bug:
This causes a build failure in the Android project with several of these error lines in the output:
2>COMPILETODALVIK : PARSE error :
Note there are no error details displayed.  If I return to the previous version I was using (2.8.5), it builds successfully.
Configuration :wrench:
Version: 2.9.0
Platform:

[ ] :iphone: iOS
[x] :robot: Android
[ ] :checkered_flag: WPF
[ ] :earth_americas: UWP
[ ] :apple: MacOS
[ ] :tv: tvOS
[ ] :monkey: Xamarin.Forms

This is a problem on the Xamarin side. Since Exoplayer 2.9.0 uses Java 8 it can't compile everything correctly. Microsoft will probably fix this in Visual Studio v15.10
A possible workaround could be to add <AndroidEnableDesugar>true</AndroidEnableDesugar> to your csproj file.
This is related to https://github.com/xamarin/java.interop/issues/25
And https://github.com/xamarin/xamarin-android/issues/2040

Thanks for the reply.  Unfortunately, I get a class not defined error with the "desugaring" enabled:
java.lang.NoClassDefFoundError :  com/google/android/exoplayer2/source/BaseMediaSource
I will wait Microsoft to hopefully fix this soon.

I get almost identical behaviour, the only difference is that before <AndroidEnableDesugar>true</AndroidEnableDesugar> I get "Uncaught translation error : com.android.dx.cf.code.SimException: invalid opcode ba (invokedynamic requires --min-sdk-version >= 26)" instead.
I've commented on the related Xamarin issues, I hope they can fix it soon.

I'm assuming that v15.0 is a Windows version reference? The latest VS for Mac Community (v7.6.10b27) is broken as well.

Possible fix is here: https://twitter.com/_JonDouglas/status/1060691432401321984

It seems to work with that fix! I've updated 2.9.1 to support this. Only problem left is that Java 1.8 features are not taken in account in the bindings. So some methods are missing.

I assume 2.9.1 hasn't been released yet?
I just tried upgrading to 2.9.0 again since the latest VS for Mac uses OpenJDK 8. It appears the issue still persists even after the upgrade so I'm not convinced that's the only issue.
If it makes any difference, the minimum SDK version I currently support is API 21, and raising it isn't likely an option just yet. I don't expect it is for most projects either.
COMPILETODALVIK: Error: com.android.dx.cf.code.SimException: invalid opcode ba (invokedynamic requires --min-sdk-version >= 26) (Project.Droid) Uncaught translation

Thanks for the reply. Unfortunately, I get a class not defined error with the "desugaring" enabled:
java.lang.NoClassDefFoundError : com/google/android/exoplayer2/source/BaseMediaSource
I will wait for Microsoft to hopefully fix this soon.

Same issue... so disappointing.
I recommend reverting to version 2.8.8

Ping. Any way we could get an update on NuGet to fix this? I really don't understand why it's normal for packages to remain broken for months on end in the Xamarin world (this project is far from the only offender; Microsoft packages are even worse; I'm still multiple Xamarin.Forms versions behind because subsequent updates have bugs, won't compile, etc.).

2.9.4 is committed and works in VS2019 preview2. We have to wait for that to release a stable new version.

Awesome; thanks. Out of curiosity, is there an equivalent Mac preview release?

Seems to be fixed on my side on Visual Studio 2019 Preview 2 (as i just encountered the bug). I had to add AndroidDesugar true, then everything worked on my side.

How is this closed? Has no label/milestone since 9.4 isn't released

@thomashagstrom because there is no need for a new release to make this work. You just need to use VS2019

Doesn't help mac users I suppose? Rider / VS Mac gives the same error.
Even built your latest develop an hour ago and referenced those DLLs. Same issue

VS2019 for Mac might work but i have no idea, try to ask Microsoft to fix this.

I updated to the just-released VS 2019 and v2.9.0.  It compiles successfully after adding AndroidEnableDesugar but I get the following exception at runtime when setting PlayWhenReady to true:
Java.Lang.AbstractMethodError: abstract method "void com.google.android.exoplayer2.Player$EventListener.onPlayerStateChanged(boolean, int)"
This is discussed in  https://github.com/martijn00/ExoPlayerXamarin/issues/79#issuecomment-476568068
Is there any way around this?

Do you have the same error if your replace true to d8 instead ?

<AndroidDexTool>d8</AndroidDexTool> seems to fix the exception.  Thanks!

No exception, but unfortunately the IPlayerEventListener methods no longer seem to be called.

Are you on VS2019 RC or VS2019 Preview ?

The official release version from today (16.0.0 Community).

Ditto the above. Current dev tools info:
=== Visual Studio Community 2019 for Mac ===

Version 8.0.1 (build 1)
Installation UUID: 588f3763-d580-45de-b809-10d8518368e1
	GTK+ 2.24.23 (Raleigh theme)
	Xamarin.Mac <IP_ADDRESS> (d16-0 / 040682909)

	Package version: 518010003

=== Mono Framework MDK ===

Runtime:
	Mono <IP_ADDRESS> (2018-08/fdb26b0a445) (64-bit)
	Package version: 518010003

=== NuGet ===

Version: <IP_ADDRESS>35

=== .NET Core ===

Runtime: /usr/local/share/dotnet/dotnet
Runtime Versions:
	2.2.0
	2.1.2
	2.1.1
	2.0.5
SDK: /usr/local/share/dotnet/sdk/2.2.101/Sdks
SDK Versions:
	2.2.101
	2.1.302
	2.1.301
	2.1.4
MSBuild SDKs: /Library/Frameworks/Mono.framework/Versions/5.18.1/lib/mono/msbuild/15.0/bin/Sdks

=== Xamarin.Profiler ===

Version: 1.6.4
Location: /Applications/Xamarin Profiler.app/Contents/MacOS/Xamarin Profiler

=== Updater ===

Version: 11

=== Apple Developer Tools ===

Xcode 10.2 (14490.120)
Build 10E125

=== Xamarin.Mac ===

Version: <IP_ADDRESS> (Visual Studio Community)
Hash: 50f75273
Branch: d16-0
Build date: 2019-03-05 11:50:33-0800

=== Xamarin.iOS ===

Version: <IP_ADDRESS> (Visual Studio Community)
Hash: 50f75273
Branch: d16-0
Build date: 2019-03-05 11:50:33-0800

=== Xamarin.Android ===

Version: <IP_ADDRESS> (Visual Studio Community)
Android SDK: /Users/ianthetechie/Library/Android/sdk
	Supported Android versions:
		5.1 (API level 22)
		6.0 (API level 23)
		7.1 (API level 25)
		8.0 (API level 26)
		8.1 (API level 27)

SDK Tools Version: 26.1.1
SDK Platform Tools Version: 28.0.1
SDK Build Tools Version: 28.0.3

Build Information:
Mono: mono/mono/2018-08-rc@5ad371dab1b
Java.Interop: xamarin/java.interop/d16-0@c987483
LibZipSharp: grendello/LibZipSharp/master@44de300
LibZip: nih-at/libzip/rel-1-5-1@b95cf3f
MXE: xamarin/mxe/xamarin@b9cbb535
ProGuard: xamarin/proguard/master@905836d
SQLite: xamarin/sqlite/3.26.0@325e91a
Xamarin.Android Tools: xamarin/xamarin-android-tools/d16-0@0a7edd6

=== Microsoft Mobile OpenJDK ===

Java SDK: /Users/ianthetechie/Library/Developer/Xamarin/jdk/microsoft_dist_openjdk_8.0.25
1.8.0-25
Android Designer EPL code available here:
https://github.com/xamarin/AndroidDesigner.EPL

=== Android Device Manager ===

Version: <IP_ADDRESS>
Hash: 86df26f
Branch: remotes/origin/d16-0
Build date: 2019-03-27 18:41:02 UTC

=== Xamarin Designer ===

Version: <IP_ADDRESS>4
Hash: 55b8d07ef
Branch: remotes/origin/d16-0
Build date: 2019-03-22 21:44:12 UTC

=== Xamarin Inspector ===

Version: 1.4.3
Hash: db27525
Branch: 1.4-release
Build date: Mon, 09 Jul 2018 21:20:18 GMT
Client compatibility: 1

=== Build Information ===

Release ID: 800010001
Git revision: 1a426f4ef97c415b9f3cbff9e548c7db5aee09cb
Build date: 2019-04-03 18:08:51+00
Build branch: master
Xamarin extensions: 6b0f7a364694e71268aead3d501c3c35485865b1

=== Operating System ===

Mac OS X 10.14.4
Darwin 18.5.0 Darwin Kernel Version 18.5.0
    Mon Mar 11 20:40:32 PDT 2019
    root:xnu-4903.251.3~3/RELEASE_X86_64 x86_64


Update to 1.19

The name says it all, unfortunately due to Fabric API requirements for 1.19, I did have to upgrade the loader level requirement to 0.14.5.

The runs failed for some reason, they worked on my branch though...

runs sometime fail due to taking too long i think


Add animated radar chart of flavor axes to sessions template

Being able to visualize the flavor axes as an animated radar graph represents their related nature better than a table. This also reduces cognitive load and transmits data to the user more clearly.
Animating between the start and finish states would look really engaging as well.

Interesting option in Svelte https://joelmturner.com/blog/svelte-animated-water-svg-pictorial-fraction/


Port hf-hub for wasm-usage

Correct me if I'm wrong, but from my understanding hf-hub currently wouldn't work in the browser. We could create a PR to add support, though I'm not sure if that makes a lot of sense. Some thoughts:

hf-hub currently uses ureq (online) and reqwest (tokio), ureq doesn't seem to support wasm, while reqwest does. Though we could also use plain fetch requests
hf-hub is currently thought for console based usage and uses indicatif for the progress bar. I checked and indicatif seems to work in wasm, though that is probably not what you want in this use-case. You'd probably want to show a progress-bar in the browser to the user rather than in the web console, so that would probably require a change in the api.
we'll want to use the Cache Web API

https://rustwasm.github.io/docs/wasm-bindgen/examples/fetch.html
https://github.com/emilk/ehttp

We have a decent start on this


The error I get for the above is:
RuntimeError: Expected to mark a variable ready only once. This error is caused by one of the following reasons: 1) Use of a module parameter outside the `forward` function. Please make sure model parameters are
not shared across multiple concurrent forward-backward passes. or try to use _set_static_graph() as a workaround if this module graph does not change during training loop.2) Reused parameters in multiple reentrant
backward passes. For example, if you use multiple `checkpoint` functions to wrap the same part of your model, it would result in the same set of parameters been used by different reentrant backward passes multiple
times, and hence marking a variable ready multiple times. DDP does not support such use cases in default. You can try to use _set_static_graph() as a workaround if your module graph does not change over iterations.
Parameter at index 255 has been marked as ready twice. This means that multiple autograd engine  hooks have fired for this particular parameter during this iteration. You can set the environment variable
TORCH_DISTRIBUTED_DEBUG to either INFO or DETAIL to print parameter names for further debugging.

What is your hyperparameters for the "/lora-alpaca-output-dir/checkpoint-1800"? Did you output all of these four weight matrices?

They are the same, default lora hyperparams used in the repository.
    --lora_r 8 \
    --lora_alpha 16 \
    --lora_dropout 0.05 \

    config = LoraConfig(
        r=lora_r,
        lora_alpha=lora_alpha,
        target_modules=lora_target_modules,
        lora_dropout=lora_dropout,
        bias="none",
        task_type="CAUSAL_LM",
    )

The default lora hyperparams only output q_proj and v_proj, so you can't use the checkpoint directly. But you can generate the adapter model based on checkpoint-1800, and modify your finetune.py to resume the adapter model as following example.
#model = get_peft_model(model, config)
from peft import PeftModel
model=PeftModel.from_pretrained(model, "/lora-alpaca-output-dir")

@lywinged will try that now and lyk how it goes

@lywinged can confirm the above works, and is the same speed as without resuming from checkpoing. I also needed to add "device_map" to get it to work on multi-GPU.
    if resume_from_checkpoint:
        model = PeftModel.from_pretrained(
            model,
            resume_from_checkpoint,
            torch_dtype=torch.float16,
            device_map=device_map,
        )
        resume_from_checkpoint = False  # Avoid trainer attempting to load state
    else:
        model = get_peft_model(model, config)

Thanks so much!

@lywinged can confirm the above works, and is the same speed as without resuming from checkpoing. I also needed to add "device_map" to get it to work on multi-GPU.
    if resume_from_checkpoint:
        model = PeftModel.from_pretrained(
            model,
            resume_from_checkpoint,
            torch_dtype=torch.float16,
            device_map=device_map,
        )
        resume_from_checkpoint = False  # Avoid trainer attempting to load state
    else:
        model = get_peft_model(model, config)

Thanks so much!

If you trained your 1800 with single GPU, just change the micro_batch_size=4, it doesn't affect your result.


[Feature]: Create Category from the bag "Configue Categories"

Describe the feature
Title is pretty self-explanatory.
It'd be nice to have a quick way of making categories from the "Configure Categories" that is attached to the bag, rather than go into the settings. The rest of the necessary stuff is already there for Categories (like item adding etc)
It's just a slog to create new categories on the fly by having to go into the settings every time.
Describe the implementation
A button in configure categories, add a name, and hit enter. Just make a new custom with no items.
OR
A button that opens a box to drag an item in in to make a new category

This exists. Drop an icon onto the corner bag icon to create a new category.

It'd probably be a good idea to explain that somewhere.... Because it's not explained when hovering the bag in the corner, nor in the "Create Category" in the options!

as a picture is worth more... you should see the message 'drop thing to create category'

Yeah, but it requires you to hold an item apparently! You might want to have a variant of that text for when you do NOT hold an item..... But glad it exists!

perhaps.. there is a section in the readme as well
https://github.com/Cidan/BetterBags/blob/main/README.md#manual-custom-categories

Sure... but you know aswell as i do that 9/10 addon users wouldn't read the readme.... :)


Input Processors

Add predefined input processors, similar to those in Unity, and replace the existing ones
And also allows users to define the processors they wanted
Predefined Processor Types

Clamp
Filter: pass all values, only negative values, only positive values, or reject all values
Sensitivity
Inversion
Dead Zone:

range for single-axis
circle, square, and rounded square for dual-axis

Oh interesting: that's a sensible framing. We should try to split this out into distinct work from #490 though: overly large refactor steps tend to be much harder to work with.

yeah, I've been trying to split them out. #490 has made some progress, but I haven't pushed the changes yet.

Updated the description

Updated the description by combining Filters into Clamps and removing user-defined processors reliant on Box, as they are not serializable (use of serde_traitobjects and serde_closures requires Rust nightly)


Use Python 3.8 on macOS

This change is

Looks like Mac picked up the Python 3.7 library instead of 3.8. I have a feeling it is the annoying reimplementation of  FindPythonLibs that pybind11 is using.

Rather than reinvent, can you somehow futz with the module path to just use our vendored-in fork of pybind11?

Nothing to re-invent. CMake just needs an extra hint before using the regular FindPythonLibs module.


API key by e-mail

Motivation
The complete API key is only displayed once. If you don't save it straight away, there is no way of looking it up afterwards.
Proposed Solution
Would it be possible to send an automated email with the API key to the person who created it? As a possibility to be able to see the API key if you do not save it in Passbolt straight away.

@juliawohlhueter @dkehne is this still relevant?
(Now, that the API keys can be chosen completely freely and are always displayed in plain text alongside their QR code?)

@juliawohlhueter has to decide that. i think it still might be relevant

@timoludwig @dkehne I don't think it's relevant anymore. We can see the API keys and QR codes easily, so no e-mail necessary.

Alright!


Bug: Direct url edit "/checkout" unsupported operand type(s) for /: 'list' and 'int'

start project
navigate to http://localhost:8000/
navigate to http://localhost:8000/checkout/

*Fix checkout page error 'unsupported operand type(s) for /: 'list' and 'int'
*Directly navigating to 'checkout' should redirect to order page

Should be fixed on For-Order-Flow

@theechosensloth can you verify if this is fixed now that for-order-flow is merged in?


Devices in recovery/DFU mode aren't detected on Linux in some cases

pymobiledevice3's cli.restore.Command class expects usbmuxd to always be running, but on Linux systems usbmuxd is typically only running whenever an iOS device is connected in normal mode (via udev). I intend to PR a fix to pymobiledevice3, which should fix this.

pymobiledevce3 3.4.1 has released, fixing this issue. The only thing left is to update deleo's code to utilize this version.


Adding a line in the beginning to help in debugging when gha fails- (15)

Motivation
weekly-dep-report.sh in weekly.yml sometimes posts empty message. The shell script when run successfully should echo something at least. However, failed GHA in the past shows the script is successfully run but with no output. Adding two lines in the beginning to ensure the script is not early dying next time the the action fails to produce any output.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
The change is made to help in debugging next time the corresponding gha fails.

/canary

:sunny: Canary successful

/land


classpath.index shows up during test tasks in build/classes/ of projects where gradle-intellij-plugin is enabled

Describe the bug
That's what I'm getting after running ./gradlew test ☹
$ find . -name classpath.index | xargs sha256sum
b9cb27dd3a72a75925fac834110ca2c61614bfda14e6135e022ee4ce7c77e9cf  ./frontend/base/build/resources/main/classpath.index
cd2a2686b0b01d20db40487437f230d6685d5e1973e7a219e5acb8492085b17d  ./frontend/base/build/classes/java/main/classpath.index
bc359d856f409b614a522c6d6ee5414825737c7292079ccd854a9bff2829633d  ./frontend/base/build/classes/java/test/classpath.index
871b91a4b594b69c5249dcd64d90cbd81567cc07e15d5f7b739171d546c242ab  ./build/resources/main/classpath.index
f99b011154a200f6a287c7aab59f16f2d6d49c0c5548926493ff18d9bb878d3b  ./build/classes/java/test/classpath.index

That wouldn't be such a problem... but it heavily messes up Gradle caching :/

Gradle reports (quite reasonably) that it doesn't know where the classpath.index came from in what's otherwise an output directory of compileJava or processResources task... and hence refrains from using the cached data for this output folders.
Even worse, classpath.index (with its apparently non-deterministic contents?) effectively disables caching for the tasks that use affected build/classes/ as inputs :/

To Reproduce
What frontend:base and root project have in common in the above example... is that:

they've got gradle-intellij-plugin enabled AND
they've got some tests

I'd assume this two conditions are enough to observe classpath.index showing up in build/classes/. This warning indicates that PathClassLoader (which IIUC generates these classpath.index files) is used for tests in (sub)projects with gradle-intellij-plugin enabled:
> Task :test
OpenJDK 64-Bit Server VM warning: Archived non-system classes are disabled because the java.system.class.loader property is specified (value = "com.intellij.util.lang.PathClassLoader"). To use archived non-system classes, this property must be not be set

Expected behavior
Well, classpath.index not showing up, or at least showing up not in an output directory of any Gradle task other than test itself :/
Environment:

OS: Fedora 36, probably irrelevant tho
JDK: openjdk version "11.0.15" 2022-04-19
Gradle IntelliJ Plugin Version: 1.6.0
Gradle Version: 7.4.2

Workaround
After ./gradlew test in CI, run:
find . -name classpath.index -delete || true

This fixes the problem but is hackish at best :/
Attempted workarounds (seem to have no effect)
      instrumentCode.enabled = false
      instrumentTestCode.enabled = false
      instrumentUiTestCode.enabled = false
      setupInstrumentCode.enabled = false

or
  test {
    systemProperty "idea.classpath.index.enabled", "false"
  }

or
./gradlew -Didea.classpath.index.enabled=false test

The new PathClassLoader introduced for 221+ unfortunately ignores the idea.classpath.index.enabled=false flag, so manual removing of the classpath.index files is currently necessary.
I've implemented it with https://github.com/JetBrains/gradle-intellij-plugin/commit/7eec2ba62d6c61bfa9ad8bf1876dfd6dea9a074f
It should be available for testing in the nightly release as soon as this build will finish: https://github.com/JetBrains/gradle-intellij-plugin/actions/runs/2576018618

After Updating to IntelliJ Ultimate 2022.3 my Gradle Build randomly fails with errors like this:
> Task :foo:jar FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':foo:jar'.
> Entry classpath.index is a duplicate but no duplicate handling strategy has been set. Please refer to https://docs.gradle.org/7.6/dsl/org.gradle.api.tasks.Copy.html#org.gradle.api.tasks.Copy:duplicatesStrategy for details.

Seems like this classpath.index file would be packaged into the libraries jar file

This issue seems to be tracked in youtrack aswell: https://youtrack.jetbrains.com/issue/IDEA-305759/Gradle-cannot-handle-classpath.index-duplicates

@larsgrefer Please file a new issue and provide more details and a reproducible example.

@hsz After a bit more digging, I noticed that this might be the wrong issue tracker. I'm sorry.
I'm just building a "regular" java library/application with Gradle and IntelliJ without explicitly using the Gradle IntelliJ Plugin

Thanks for the clarification.

FWIW, I also just started getting this issue today. No-one else on my team is having the issue but me and I am fairly certain I am the only one on the latest version of IntelliJ

Any workaround? I guess I can always downgrade back to the previous version (hopefully this fixes it).

@ericl-billgo Is this actually related to the Gradle IntelliJ Plugin – a tool for creating plugins for IDEs? ;)

@hsz I don't know. All I know is that this is the only place Google sent me when I entered my exact error Entry classpath.index is a duplicate but no duplicate handling strategy has been set. Since I am new to Java (but been doing this for 25 years) I am still trying to figure out where to get help. I think my answer is in the link @larsgrefer posted 5 days ago... I will go investigate more.

@ericl-billgo I'm also facing this issue. Add -Didea.classpath.index.enabled=false too IntelliJ's JVM options, that'll fix it


Icon Request: Please Link Sony Camera to Camera Icon

Please link Sony Xperia Camera to Camera Icon. The file name is: com.sonyericsson.android.camera
Thanks.

Already fixed with


Add support to schedule notebooks and pipelines when submitting to kfp

Verify if, when submitting a pipeline, we can actually schedule it to run multiple times

Duplicate of #471


adding ssl_avs_zip to ccgettoken request

Using the default configuration on an elavon sandbox account I was receiving the following error when attempting to use my generated tokens:
Error: 4009
Message: The field Postal Code (ssl_avs_zip) required but not supplied in the authorization request.
Turns out that ccgettoken includes all of the address fields except the zipcode when tokenizing credit card information. After including the ssl_avs_zip field and generating a new token, the tokenzied payment was accepted.

Coverage remained the same at 100.0% when pulling 751274ddf83b263ce2ceabde85ab54fca979e233 on stevemortimer:master into b3ad658afca7d957fa6d5d252de07076620f6ede on lemonstand:master.

Was gonna send the same pull request, @aperdomo can you merge this?


Live collaboration

It would be awesome if StackEdit incorporated some kind of live collaboration features, for example by using Together.js I would love to be able to collaborate with my friends on a .md file in real time!

possible to adopt https://github.com/ether/etherpad-lite for realtime editing?

+1

@theoryshaw I have doubts it would be easy to isolate just the collaborating aspect of etherpad-lite, which seems to be a more kitchen sink approach. A more realistic solution might be leveraging a lightweight library like ShareJS.

ShareJS is a simple (~4k LOC) coffeescript server & web client library for OT.

I'd assume most people don't need/want all the features of the Google Drive realtime API, which I assume offers accountability (who edited and when), multiple cursors, and the like. ShareJS seems to handle just what it needs to and nothing else.
Any thoughts on an easier to maintain alternative @benweet? IMO live collaboration would be a killer feature, worth paying for.

Yeah I'm working on something. It will probably rely on DynamoDB streams which is not ready for production yet (http://dynamodb-preview.s3-website-us-west-2.amazonaws.com/docs/streams-dg/About.html).
The problem with ShareJS and etherpad-lite is that they don't scale well. As soon as you want to add node workers you have to start doing hacks to route users of the same file to the same node.

@benweet Awesome news, looking forward to it.

+1

Any update on that?
By the way, I paid using MozillaJS, is it for one year or lifetime?