Normalizer Wrapper

Hello,
I made the Normalizer that I described in #7. It is fairly straightforward to use but I think documentation will be welcome once this package is integrated to RL.jl. I'm opening an issue as a reminder to do that in due time. Tell me what you think.
Closes #7

In #7 I mention that this may pose problem for NStepSampler. With this implementation, NStepSampler will not work properly.
I have two propositions to deal with that:

We can make a discounted_sum_of_rewards_normalizer: by simply using a FTSeries wrapper to multiply rewards by (1-gamma^n)/(1-gamma) before fitting. The problem with this solution is that if a Trajectory has multiple samplers (remember we discussed the metasampler), say a NStepBatchSampler and a BatchSampler, it is now the latter that will be wrong. So this is not my favourite option.
What I think we should do is completely change NStepBatchSampler. To me, NStepBatchSampler should sample N consecutive experiences of all traces it is asked for, and that's it.  Doing the discounted sum of rewards should be done by the algorithm, for example in q_targets.

Indeed, NStepBatchSampler should be changed in the next version.

Great!
I think after merging this, we'd better register this package first? So that RLCore and RLZoo could be updated to use this package.
(Kind of busy recently, but should have plenty of time to work on it in the following several weeks)

It's not an essential part of the package anyways. If you want to use Trajectories sooner it's fine. What I'm more concerned about is for the algorithms that need the meta sampler.

So I eventually went with a NormalizedTraces (with a s) wrapper. The reason is that otherwise we cannot use it with preconstructed traces such as CircularSARTTraces. I suspect this would have been problematic with Episodes too.
I removed fetch to settle with a simple overload of sample(::BatchSampler). Note that if we add a multistep batch sampler, we will have to implement a specific method for normalization.
One question that we might want to address: currently, the two names of MultiplexTrace share the same normalizer. Meaning that pushing a next_state will update the state normalizer and sampled next_state's will be normalized (as we want).
We must keep that in mind to avoid estimation errors. Currently in RL.jl, pushing a next_state is not a thing so it should be ok.
The other failure case is when pushing dummy states, this should be avoided when using normalization. Since this is already a problem for non-episodic environments (as discussed in #621).
This may be ready to merge. Though I have not tested if it works well with Episodes.


Remove singular object restriction

Currently, the top level object must not be an array. It should be possible to allow a top level array.

Whoops, this is actually not possible.


Parallelize tests

This doesn't make things (much) faster, but does lay some groundwork for doing so.
It also makes it so that an annoying docs build issue won't make it so that you can't see how the integration tests did.
Remaining snag is "coverage files aren't getting read from the places I expect, so the coverage upload isn't working."

This seems like it'll generate much more informative testing outputs on PRs!

@zaneselvans - it looks like coverage is working now, but I'm having trouble coercing the docs build into creating a coverage report.

@jdangerx It might be because the docs environment within Tox installs only the doc extra, and all the packages required to do coverage are part of the test extra?  Maybe if you added the test extra to the docs environment in tox.ini it would work?

To follow up on my vague comment above: I was confused about how sphinx-build would even generate coverage at all. What I overlooked was "the first page of the GD coverage.py docs" and also "my own mental model for how coverage tools work" - namely, needing to run sphinx-build through coverage run so that coverage could actually instrument our code. I've added that now, hope everything passes :)


Update Mac instructions for installing tensorflow

For tenserflow 1.8 that is in donkeycar 2.5.1 you need this new file.
if not you will get error when trying to train model  ModuleNotFoundError: No module named 'tensorflow.python.keras

Codecov Report

Merging #296 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #296   +/-   ##
======================================
  Coverage    39.1%   39.1%
======================================
  Files          27      27
  Lines        2056    2056
  Branches      226     226
======================================
  Hits          804     804
  Misses       1228    1228
  Partials       24      24

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 344127b...44899bf. Read the comment docs.

I hit the same issue and the above update fixed the issue, I think the guide should be updated.


Add missing '.text' in crypto/bn/asm/ppc.pl

Fixes #8495

I'll hold this until I have an answer to https://github.com/openssl/openssl/issues/8495#issuecomment-473627529
(@lzsiga, you could choose to simply confirm this fix)

Merged.
master:
2864df8f9d3264e19b49a246e272fb513f4c1be3 Add missing '.text' in crypto/bn/asm/ppc.pl
1.1.1:
0584ce737efd26aa82d659087fc9f081ef8e30c4 Add missing '.text' in crypto/bn/asm/ppc.pl

Thank you very much, levitte.


about licence

Hello sire i follow your tutorials on uderny and make router class and i change controller,modals,error,view class with my custom codes can its allow use this router class and make my own framework?
is i need add @auther yourname?
thanks

@daveh Thanks you so much for replying

Hay sire I done this here is framework
http://github.com/Softhub99/Zest

Looks good! Good luck with it! :+1:


Row colors disappear on Linux

Description
After clicking on datagrid all rows become white
DBeaver Version
23.2.3
Operating System
Ubunru 22.04
Database and driver
Any
Steps to reproduce

Open a table
Click on any cell

Expected: Colors don't change
Actual: All rows become white
Additional context
https://github.com/dbeaver/dbeaver/assets/82543000/7a4776c5-2c38-42cb-a16a-81b5e53405d4

Sounds like a duplicate of #21125

Not sure, this happens on a fresh Linux, without any accessibility tools ever installed

I mean that probably it's not an os-specific issue and it's not connected with accessibility tools as you reproduced it too.

I mean that probably it's not an os-specific issue and it's not connected with accessibility tools as you reproduced it too.

Still can be connected with Accessibility tools, some Linux distributions can use the API without any screen readers see https://github.com/dbeaver/dbeaver/issues/19709


Triple click for whole line selection crashes browser tab

Problem:
When performing a triple click on a line in the StackEdit 5 editor to select the line's contents, the browser tab crashes.
It only happens on Firefox (maybe in other browsers, too, I only tried Chrome as cross-reference).
Also, it seems to be necessary to have some kind of markdown formatting above the respective line in the file (I tried different levels of titles and a quote).
Setup:

StackEdit 5
Firefox 58.0.2 (64-bit)
Windows 10 Version 1709

Reproduce:

Create new file.
Paste this markdown text:

# Title
This is a test.

Triple click on "this is a test." to select it.
The editor crashes the browser tab and slows down other tabs.

Fixed in v5.10.5.


Verification keeps failing for HEX and Base32 only ASCII working fine

I've been trying to understand the module for house now, but couldn't get to understand what is going on. I followed the steps in the documentation, and it still isn't verifying. This is my code
function getPublicKey() {

	var secret = speakeasy.generateSecret({length: 25});
	var base32Secret = secret["base32"];
	console.log("Secret: ", base32Secret);

	var token = speakeasy.totp({base32Secret, encoding: 'base32', window: 6});

	console.log("MainToken: ", token);

	var tokenValidates = speakeasy.totp.verify({
	  secret: base32Secret,
	  encoding: 'base32',
	  token: token,
	  window: 6
	});

	console.log("TokenValidate: ", tokenValidates);

	var newTokenValidates = speakeasy.totp.verify({
	  secret: base32Secret,
	  encoding: 'base32',
	  token: '1234356'
	});

	console.log("NewTokenValidate: ", newTokenValidates);
}

And, this is my response:
Secret:  IJQSCWS3KJHE2KLCJA4UOUJYONNHQWTPHIXTSIJM
MainToken:  615020
TokenValidate:  false
NewTokenValidate:  false

And then, I tried for ASCII and it works fine
function getPublicKey() {

	var secret = speakeasy.generateSecret({length: 25});
	var acsiiSecret = secret["ascii"];
	console.log("Secret: ", acsiiSecret);

	var token = speakeasy.totp({secret: acsiiSecret});

	console.log("MainToken: ", token);

	var tokenValidates = speakeasy.totp.verify({
	  secret: acsiiSecret,
	  encoding: 'ascii',
	  token: token
	});

	console.log("TokenValidate: ", tokenValidates);

	var newTokenValidates = speakeasy.totp.verify({
	  secret: acsiiSecret,
	  encoding: 'ascii',
	  token: '1234356'
	});

	console.log("NewTokenValidate: ", newTokenValidates);
}

And the result:
Secret:  fm:Scz4n7TDlZXA/}0OPxR3[<
MainToken:  228114
TokenValidate:  true
NewTokenValidate:  false

There is coding error in line 4 of your sample code.
You forgot to specify property key name 'secret' before base32Secret variable.
var token = speakeasy.totp({secret: base32Secret, encoding: 'base32', window: 6});
After I do it, verify method returns true.

This issue occurs because the required fields are not checked in hotpVerify, totpVerify, totp and hotp functions. I can make a PR to check the required fields and throw error accordingly.

Can I close this issue because it is coding error on the author?

This issue above is valid and still going. I used "base32" the token was not validating. Once I switched to the default, which I believe "ASCII," it worked with no problems. I encourage you to take another look at the issue. Thank you.

can u provide the code u use?

I can't provide you with the exact code, but here is sort of what I did. Here is the mindboggling part! It worked for some time, but it fails a lot of the time.
function generateSecret(){
    return speakeasy.generateSecret({length: 20});
}

function getCodeToken(secret: Key) {
    return speakeasy.totp({
        secret: secret.base32,
        encoding: 'base32'
    });
}

function isCodeValid(secret: string, code: number | string){
    return speakeasy.totp.verify({
        secret: secret,
        encoding: 'base32',
        token: code.toString()
    });
}

let secret = generateSecret();
let token = getCodeToken(secret);
let isVerified = isCodeValid(user.speakeasySecret, req.body.code);

If the code sent by the user is correct, the isVerified is suppose to be true, but that is almost always not the case on my end. Let me know if I am doing something wrong here. Thank you.


[Question] differences between MSE loss and Huber loss

Hi, nagadomi. Thanks for sharing this amazing project.
I have some questions about the implementation of waifu2x.
First, have you benchmarked the performance differences between MSE loss and Huber loss?
In my opinion, Huber loss may work better than MSE loss when the input image has slight noise. But when the input image is clear, I think MSE loss is enough.
Second, what's the difference between up_conv7l and up_conv7? I did't find the model definition of up_conv7l in this repo. I guess that up_conv7l is wider than up_conv7.  Am I right?
Third, I have implemented SRResNet in this paper, including MSE loss and Perceptual loss. I found the performance of MSE loss is pretty good. But in some images, there are overflow problem in my implementation.
Following is my 4x upscale result of w2nn.png. The edge of stairs in this result is very clear. But there are some strange overflow pixel..
Do you have any idea to handle this problem? I implemented SRResNet also in torch.

Thanks!

I think MSE loss is enough.

I think so. The threshold parameter of Huber loss in waifu2x is large. When the target image is clear, L1 loss is used only in the first few epochs, otherwise L2 loss(MSE) is used. But the target image is higher resolution than the input image, typically it's more noisy than the input image. But of course, L1 loss and Huber loss do not maximize PSNR metric directly.

I did't find the model definition of up_conv7l in this repo.

upconv_7l can be found in dev branch. Also I've added srresnet_12l.
git checkout -b dev origin/dev

But in some images, there are overflow problem in my implementation.

Maybe you can prevent this problem by clipping the output layer. See upconv_7, InplaceClip01 (also you can use nn.Clamp).
But I have never met this problem. If your dataset is not too small, there might be some bugs.

Thanks for your replay and suggestion!
Dev branch is awesome! You have done so many experiments to increase the performance of SR.
I trained my model by 50000 training samples from imagenet validation set. Maybe there are some bugs in my implementation.
I think I should read your code carefully. Since there are many implementation details in this repo, it is a best example for people who want to develop better SR techniques.
Thanks for your greate work!
If you need help to do experiments, I can contribute!

Thanks

I'm not sure if this is correct. I think that problem is related to batch normlization, if it's not simple coding bug.

It's really caused by batch normlization. Since the parameters obtained by training set is not suitable for some image. I set model:evaluate() to model:training() and it solved.
Thanks!


Waveform flickers when I call wavesurfer.loadDecodedBuffer(buffer);

Hi,
first of all, wavesurfer.js is awesome, you guys did a great job!
Well, there is a nice (somewhat hidden) feature in wavesurfer that I found out while reading the code. I have a custom microphone service implementation in my Angular project (not using the microphone plugin of wavesurfer.js for reasons).
So I read the code what the microphone plugin code is doing to extend a given wavesufer-internal buffer (for rendering) with new buffer data (this is what obviously needs to happen). Turns out it's calling loadDecodedBuffer(buffer); on a wavesurfer instance. So far so good.
When I do the same:
const buffer: AudioBuffer = this.microphoneService.getBufferOfTrack(audioTrackEvent.index);
this.tracks[audioTrackEvent.index].wavesurfer.loadDecodedBuffer(buffer);

It works, but the rendering flickers because it re-renders the whole waveform every time I add buffer data instead of just drawing only the fft result of the added buffer data next to the already rendered graph.
I use the following instance configuration:
    this.tracks[audioTrackEvent.index].wavesurfer = WaveSurfer.create({
          container: '#track-' + audioTrackEvent.index,
          waveColor: '#cc0000',
          progressColor: '#cc0000',
          partialRender: true,
          fillParent: false,
          normalize: false,
          height: 64,
          mediaControls: false,
          responsive: true
    });

Can somebody please point me out what am I doing wrong?
I was hoping that partialRender might help here to only re-render the added data, but it isn't.


Introduce ut

This provides a framework where essentially everything inside of the implementation namespace should be unit-testable from ut.
That interface is not completely pure right now (there are a couple of places where PyObject*'s occur, but that's a header-only dependency so may be ok).
Plenty more tests to write (as always) - this is just the bare-bones sketch.
I discovered an opportunity to merge all the processing loops into a single piece of source, for both SIMD and individual item walk processing. More tests are needed, but it looks promising so far. That should help keep the instruction cache warm, and avoid relying on the branch predictor during execution.

It seems there have been some changes in master that may need to be pulled down?


RoR group project: set up your Kanban board

Hello 👋
We are two in this group @danielamoreno699  and @fredo509
In this milestone we setup our Kanban Board.
Here is our kanban board

Hi @TEAM,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

Correct GitFlow ✔
Good implementations ✔

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Nats Jetstream External Driver does not install

Hi, when try to install nats plugin it returns this error:
go get gofr.dev/pkg/gofr/datasource/pubsub/nats
go: module gofr.dev@upgrade found (v1.28.1), but does not contain package gofr.dev/pkg/gofr/datasource/pubsub/nats
Gofr version: 1.28.1
Go version: 1.23.2

The link on the website and the tag were missing - have added them now can you please check?

go get gofr.dev/pkg/gofr/datasources/pubsub/nats on this page (https://gofr.dev/docs/advanced-guide/using-publisher-subscriber) should be  go get gofr.dev/pkg/gofr/datasource/pubsub/nats


[HELP]

Hi,
I am using the following code to download CO data from sentinel5p:
evalscript_co = """
//VERSION=3
function setup() {
   return {
    input: ["CO"],
    output: {
      bands: 1,
      sampleType: "FLOAT32"
    },
  };
}

function evaluatePixel(samples) {
   return [samples.CO]
}
"""

def download_co_imgs(start_date, end_date, path_to_save_data):

    current_date = start_date
    while current_date <= end_date:

        request_co_data = SentinelHubRequest(
        evalscript=evalscript_co,
        input_data=[
            SentinelHubRequest.input_data(

                DataCollection.SENTINEL5P.define_from("sentinel-5p-l2", service_url=config.sh_base_url),
            )
        ],
        responses=[SentinelHubRequest.output_response("default", MimeType.TIFF)],
        data_folder=path_to_save_data,
        bbox=betsiboka_bbox,
        size=betsiboka_size,
        config=config,
    )
        current_date += timedelta(days=1)
        request_co_data.get_data(save_data=True)

When I use the function to download data it downloads a folder for each day with the files [response.tiff, request.json]. The problem is that I cannot find the acquisition time for the images, i..e the sentinel5p acquisition time for every image.
The request.json contains this:
{
    "timeRange":
    {
        "from": "2020-11-11T00:00:00Z",
        "to": "2020-11-11T23:59:59Z"
    }
}

and not the specific time of the acquisition.
Any help with that?

Hi @stamatisvas!
Thank you for posting this question. I tried running your example but noticed that you don't use the time interval in your request anywhere. Your SentinelHubRequest.input_data dictionary should contain the time_interval parameter like so:
SentinelHubRequest.input_data(
    data_collection=DataCollection.SENTINEL5P,
    time_interval=(current_date, end_date)
)

I also updated the DataCollection part, since there was no need to update the data collection. Unless you are using some other sh_base_url? I didn't see it defined anywhere.
Now, to get to the issue. The reason that the time range is returned is that the SH in the background creates a mosaic of all observations during the timedelta which you specify (1 day). If you want finer temporal resolution I suggest that you decrease the timedelta to 1 hour, that should give you better precision, but will still not give you the exact timestamp.
If you're interested in the exact timestamps, you have to save the information from the scenes and save it explicitly in the evalscript using the updateOutputMetadata function.
Another option is to query the timestamps via the SH Catalog, like so:
from sentinelhub import SHConfig, SentinelHubCatalog

creodias_config = SHConfig()
creodias_config.sh_base_url = "https://creodias.sentinel-hub.com/"

catalog = SentinelHubCatalog(creodias_config)
search_iterator = catalog.search(collection="sentinel-5p-l2", bbox=betsiboka_bbox, time=("2020-11-01", "2020-11-30"))

timestamps = [ts.isoformat() for ts in search_iterator.get_timestamps()]

The service URL needed to be updated, because the 5P collection lives on creodias
You can then use the specific timestamps to make specific requests by providing the exact timestamp in the request.
Hope that helps!


Phone parsing

Some country code have a 0 for local phone. This lead to an error if not removed by the user
Ie: +33 06 versus +33 6

also:<PHONE_NUMBER> shows as error in the mobile app (because of the parenthesis)

I'll look into this one.
@nicolasburtey Could you elaborate on the first task? I don't understand what you mean here. Is it automatically formatting numbers that start with zero to remove the zero?

I'll look into this one.
@nicolasburtey Could you elaborate on the first task? I don't understand what you mean here. Is it automatically formatting numbers that start with zero to remove the zero?

some numbers, in some countries have different ways to be accessed.
ie in France: +33 6 01 23 45 67 89 and + 33 06 01 23 45 67 89 both leads to the same underlying "phone"
the canonical number should be +33 6 01 23 45 67 89 but if the user enter +33 6 01 23 45 67 89 we should automatically erase the 0
the idea is to explore the api of libphonenumber-js and see if there are ways to address this.

Okay I get what you're saying. I'll take a look into it tomorrow.

@nicolasburtey  The behaviour you're asking for looks like it's already there.
This input:

Results in this value being parsed without the leading 0:

Which is then saved and used without the leading zero afterwards:

The only additional behaviour I could see is if you want the input field to be formatted without the 0, but I wouldn't recommend that. I think that'd be uncomfortable for the user to see their input changed as they type.

@nicolasburtey The behaviour you're asking for looks like it's already there.
This input:
Results in this value being parsed without the leading 0:
Which is then saved and used without the leading zero afterwards:
The only additional behaviour I could see is if you want the input field to be formatted without the 0, but I wouldn't recommend that. I think that'd be uncomfortable for the user to see their input changed as they type.

I think in that case, in the confirmation screen, we should show the canonical number. this is really the number that is saved in the system, so if the person contact the support for instance, the support would know what to look for

@nicolasburtey The behaviour you're asking for looks like it's already there.
This input:
Results in this value being parsed without the leading 0:
Which is then saved and used without the leading zero afterwards:
The only additional behaviour I could see is if you want the input field to be formatted without the 0, but I wouldn't recommend that. I think that'd be uncomfortable for the user to see their input changed as they type.

I think in that case, in the confirmation screen, we should show the canonical number. this is really the number that is saved in the system, so if the person contact the support for instance, the support would know what to look for

I know it looks like it's not in the example we used, but the confirmation screen has the canonical number already. I think you might be being tricked by the number we both used lol<PHONE_NUMBER>. In our example/test the country code is +33 and the phone number is 601234567 (formatted from<PHONE_NUMBER>).


Remove hadoop version from Jupyter

Can you unmerge this?
I think pydoop needs the HADOOP_VERSION env variable. That's why i did this.  Is the problem that we have a broken hadoop version on hops.site? If so, we fix that.

Reverted the commit and added a symlink


Checked item is updated in Navigation view

The checked item in Navigation view in Main Activity was not getting updated when user clicks on any other menu item to open any other fragment other than My Courses and then press the back button to come back on My Courses fragment.
Fixed that by updating the onBackPressed method in MainActivity.java file.
Close #102

Why is this closed?

I closed it by mistake.. Opened a new one #104


MSVC warning prefer enum class for SDL_bool

We should find a way of silencing the MSVC warning:

C:\Tools\vcpkg\installed\x86-windows\include\SDL2\SDL_rect.h(102): warning C26812: The enum type 'SDL_bool' is unscoped. Prefer 'enum class' over 'enum' (Enum.3). [C:\projects\nas2d-core\NAS2D\NAS2D.vcxproj]

This enum exists outside of our code base, so it's not reasonable to mark it as enum class. Instead, we should find a way to make the code checks skip code from external dependencies.

The following may be helpful:
https://developercommunity.visualstudio.com/solutions/978036/view.html

To add a bit of detail, the error is: C26812
The recommendation comes from: C++ Core Guidelines
The specific rule in question is: Enum.3: Prefer class enums over "plain" enums

The warning is given by the Code Analysis framework, which is a set of optional checks done during compilation.
The Code Analysis feature can be run from the Visual Studio IDE (Build -> Run Code Analysis on Solution), or from the command line using the C++ compiler (cl.exe):
cl /analyze Sample.cpp

The /analyze parameter can take a ruleset file: /analyze:ruleset file_path.ruleset
Visual Studio ships with a number of rulesets defined in: %VSINSTALLDIR%\Team Tools\Static Analysis Tools\Rule Sets
Example .ruleset file:
<?xml version="1.0" encoding="utf-8"?>
<RuleSet Name="New Rule Set" Description="New rules to apply." ToolsVersion="15.0">
  <Rules AnalyzerId="Microsoft.Analyzers.NativeCodeAnalysis" RuleNamespace="Microsoft.Rules.Native">
    <Rule Id="C6001" Action="Warning" />
    <Rule Id="C26494" Action="Warning" />
  </Rules>
</RuleSet>

You can of course create your own .ruleset file and check it in as part of your project.

Analysis settings can be configured through the project's Property Pages: Configuration Properties -> Code Analysis -> General
Enabling code analysis on build will set the EnablePREfast property in the project file.
  <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
    <ClCompile>
      ...
      <EnablePREfast>true</EnablePREfast>
      ...
    </ClCompile>
    ...
  </ItemDefinitionGroup>

A possible avenue to explore with the project file is the CAExcludePath property:
Suppress warnings for external headers in VS2017 Code Analysis
It seems this setting already exists in the NAS2D project file:
  <PropertyGroup Condition="'$(Language)'=='C++'">
    <CAExcludePath>$(VcpkgRoot)include;$(CAExcludePath)</CAExcludePath>
  </PropertyGroup>

A possible reason why CAExcludePath doesn't seem to disable the warning, is the warning is issued on uses of enum SDL_bool, rather than the definition of it. The enum SDL_bool is defined in the SDL2 library, which should have warnings disabled, though the warning is not on the definition itself. Instead, uses of enum SDL_bool from within the NAS2D library trigger the warning, and warnings are still enabled for NAS2D library code.

It would be desirable to leave this warning enabled, as we want to see warnings about regular enum definitions within the NAS2D library (or at least warnings caused by uses of such definitions). However, we would like to suppress the warning for enum definitions that come from library dependencies (or rather uses of such definitions within our own code).
Sadly, it might be that we need to disable the warning entirely if we want to prevent false positives. It seems to me the detection of this condition is a bit buggy, and not in line with the C++ Core Guidelines, which says:

Enforcement
(Simple) Warn on any non-class enum definition.

However, in practice, the warning seems to come from uses of such enums, rather than from the definition.

Leaving a link to a related support article:
No option to suppress C++ code analysis warning C26812

Looks like the warning is gone since the upgrade to use Visual Studio 2022 in PR #1025.


UnlockFile : is it meant to be used at all?

With the current code, I have
Status UnlockFile(FileLock* lock)
and
Status LockFile(const std::string& fname, FileLock** lock)
LockFile returns FileLock NULL if the file has already been locked.
If I want to UnlockFile a specific file, how/where from do I obtain the needed FileLock for this specific file, i.e. how is it usage meant to be? Is UnlockFile meant to be used at all?

file lock is used to ensure that we can open only one db instance per leveldb database.


Add odd/even test

Add a vetter that takes a light curve and tce  and determine the difference between the depths of the odd and the even transits. It should return both depths and the errors.  Usually a cut is  made when significant depth differences are seen.
The astropy BLS code actually is one path forward for this test.

Some implementation exists (#27) but needs to polish the API.

Superseded by #29


Sudden "parse error on line X" errors in files

Issue Type: Bug
This error cannot be consistently reproduced, but is appearing fairly consistently on my system.
After the last couple of VS Code version updates, I have encountered the following weird issue.
In any file, but mostly in JS files, after I have edited the contents (either added/removed parts), the file is highlighted red (in explorer sidebar) and "red wave" errors appears in/or around the areas where I edited the contents. (see screenshot below)

Sample Error:
Parse error on line 4:
...gleQuote": true    "arrowParens": "avoi
----------------------^
Expecting '}', ',', ']', got 'STRING'
Parse error on line 4:
...ingleQuote": true  "arrowParens": "avoi
----------------------^
Expecting '}', ',', ']', got 'STRING'

The error remains, even if I edit the area, or move the content up/down away from the error area. (see next image)

Sometimes the error can move with the code text (content), but most of the time the error remains in the original location, even though the file have been closed & re-opened.

Problems panel output sample

As can be seen in the above image, the error is repeated many times, and is stuck on the original error, even though the 'error area' contents have been changed already.
Also note, that there's a second error in another file. Both files are JSON formatted this time, but that's not consistently so.
Also note the extension-output-#3 error shown. Not sure where that one comes from.

Despite these errors, the file normally still works, but the syntax highlighting occasionally can become broken by the error.
I assume, it's some kind of cached code validator/syntax highlighter issue, since the error tends to happen after some kind of text addition/correction.
The issue is NOT consistently within a specific file type or scope.
I have even created a clean system  & app reinstall to resolve the issue, but not resolution.
I would be grateful for any suggestions / advice towards resolving this issue.
Thanks for your time and attention.

VS Code version: Code 1.30.2 (61122f88f0bf01e2ac16bdb9e1bc4571755f5bd8, 2019-01-07T22:48:31.260Z)
OS version: Darwin x64 18.2.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz (4 x 2700)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
3, 3, 4

Memory (System)
16.00GB (0.31GB free)

Process Argv
.

Screen Reader
no

VM
0%

Extensions (44)

Extension
Author (truncated)
Version

ionic4-snippets-vscode
4tr
1.2.0

project-manager
ale
10.3.0

copy-relative-path
ale
0.0.2

jest-snippets
and
1.6.1

vscode-tidyhtml
anw
1.10.0

vscode-browser-preview
auc
0.2.5

htmltagwrap
bra
0.0.7

vscode-toggle-quotes
Bri
0.3.2

vscode-opennewinstance
chr
0.0.4

bracket-pair-colorizer
Coe
1.0.61

vue-peek
dar
1.0.2

vscode-eslint
dba
1.8.0

javascript-ejs-support
Dig
0.3.2

createuniqueid
don
0.0.3

vscode-great-icons
emm
2.1.46

prettier-vscode
esb
1.7.3

auto-rename-tag
for
0.0.15

code-runner
for
0.9.6

todo-tree
Gru
0.0.115

rest-client
hum
0.21.1

autofilename
Jer
0.1.3

graphql-for-vscode
kum
1.13.0

rainbow-csv
mec
0.8.0

vscode-duplicate
mrm
1.2.1

vetur
oct
0.14.5

vscode-jest
Ort
2.9.2

vscode-docker
Pet
0.5.1

vscode-snyk
pmb
0.0.2

quicktype
qui
12.0.46

ruby
reb
0.21.0

sass-indented
rob
1.5.1

vscode-open
san
0.1.0

vue-vscode-snippets
sdr
1.3.0

code-settings-sync
Sha
3.2.4

code-spell-checker
str
1.6.10

language-stylus
sys
1.11.0

toggler
teh
0.5.0

stylus-supremacy
thi
2.12.7

tmlanguage
Tog
0.9.0

vuetify-vscode
vue
0.2.0

vscode-import-cost
wix
2.12.0

change-case
wma
1.0.0

JavaScriptSnippets
xab
1.7.2

markdown-pdf
yza
1.2.0

(1 theme extensions excluded)

@mjbvz Thanks for your reply.
The following is mainly for DuckDuckGo/Google/Bing/etc to find and assist others with the same problem.
I just discovered that the culprit behind this issue is the VSCode TMLanguage extension.
The issue have already been reported in the following Issues on that repo:

Parse error reported when viewing output channels #14
Error 'squiggles' don't clear in JSON files. #19

There even seems to be a fix (pull request) for this issue at: Fix for error reporting in JSON files #20.
After some tests with all extensions disabled/enabled, I can confirm that these errors only occurs while the VSCode TMLanguage extension is enabled.
With extension enabled

With extension DISABLED

Hopefully this note will help and save time for others.
cc @gjsjohnmurray


Add option closeOnClickBackdrop to sidebar

Sometimes you don't want the sidebar to be closed when clicking anywhere outside (the most obvious case is when you click on another menu item in the sidebar), but most users expect clicking on the backdrop to close the sidebar.

Wouldn't just using closeOnClickOutside be sufficient?

No, I explained why in the first comment up above. In my sidebar I have several menu entries: if I use closeOnClickOutside, then clicking on a menu entry would close the sidebar, and that's not desirable in my case because the menu entry control a secondary sidebar. You can see it in action here.

Thanks, I updated the PR like this:
this._sidebars.filter((sidebar: Sidebar) => {
  return sidebar.opened &&
         sidebar.showBackdrop &&
         sidebar.closeOnClickBackdrop;
}).forEach((sidebar: Sidebar) => {
    sidebar.close();
});```

I find that using `.filter` and then `.forEach` is a bit more readable and you already use `this._sidebars.forEach` elsewhere in the file.

Thanks @siovene! I've published v4.2.0 with this.


Task execution should complete as soon as submitted work is complete

When a task submits work items using WorkerExecuter.submit but does not call WorkerExecuter.await(), then the task is not considered complete until all submitted work items have finished. However, the task relinquishes its exclusive project lock while work items are running, allowing Gradle to run other tasks in the same project in parallel.
Once all work items are complete, the task must re-acquire the project lock in order to fire any post-execution actions. In many cases this step is not necessary, leading to delay in executing dependent tasks.
Instead, Gradle should only reacquire the project lock for task completion when post-action work may result in mutating the project state. (e.g. TaskExecutionGraphListener). When no post-action work is registered, Gradle should not wait for the project lock in order to mark a task as "complete".

That's super cool! Can you please also consider to add some additional debug info to track enforced locks and reasons behind it?


Unresolved warning ITMS-90809: Deprecated API Usage for UIWeView on iOS with RN 0.63

Hello,
I know i'm opening a duplicate issue that is because my case is different from other closed issues. I have followed the solutions from old issues but it did not help. I even removed the dependencies that are possible to cause the UIWebView warning from my project including  react-native-fbsdk,  react-native-fbsdk, react-native-webview.
Beside, when I tried to run: "grep -r UIWebView node_modules/"
it show me the result which looks like there is nothing related to UIWebView:
node_modules//jsc-android/dist/include/JSContextPrivate.h:/*! @abstract The delegate the context will use when trying to load a module. Note, this delegate will be ignored for contexts returned by UIWebView. */
node_modules//ua-parser-js/test/browser-test.json:        "ua"      : "Mozilla/5.0 (iPhone; CPU iPhone OS 10_0_2 like Mac OS X) AppleWebKit/602.1.50 (KHTML, like Gecko) Mobile/14A456 QQ/<IP_ADDRESS>0 V1_IPH_SQ_6.5.3_1_APP_A Pixel/1080 Core/UIWebView NetType/WIFI Mem/26",
node_modules//fbjs/lib/UserAgent.js.flow:   * - UIWebView
node_modules//fbjs/lib/UserAgent.js:   * - UIWebView
node_modules//create-react-class/node_modules/fbjs/lib/UserAgent.js.flow:   * - UIWebView
node_modules//create-react-class/node_modules/fbjs/lib/UserAgent.js:   * - UIWebView
Also, by running "grep -r UIWebView ios/Pods/
I got no result for UIWebView in native libraries.
It's really weird in my case. Anyone could please help me!
Environment Information:
System:
OS: macOS 10.15.5
CPU: (4) x64 Intel(R) Core(TM) i7-5557U CPU @ 3.10GHz
Memory: 343.86 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 12.18.0 - /usr/local/bin/node
Yarn: 1.15.2 - /usr/local/bin/yarn
npm: 6.14.4 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
Managers:
CocoaPods: 1.9.3 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: iOS 13.6, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
Android SDK:
API Levels: 23, 25, 26, 27, 28, 29
Build Tools: 23.0.1, 28.0.3, 29.0.2, 29.0.3
System Images: android-22 | Google APIs Intel x86 Atom, android-23 | Google APIs Intel x86 Atom, android-27 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom
Android NDK: Not Found
IDEs:
Android Studio: 4.0 AI-193.69<IP_ADDRESS>14223
Xcode: 11.6/11E708 - /usr/bin/xcodebuild
Languages:
Java: 1.8.0_211 - /usr/bin/javac
Python: 2.7.16 - /usr/bin/python
npmPackages:
@react-native-community/cli: Not Found
react: 16.13.1 => 16.13.1
react-native: 0.63.2 => 0.63.2
npmGlobalPackages:
react-native: Not Found
All my project's dependencies:
"@babel/plugin-proposal-decorators": "^7.10.4",
"@bugfender/rn-bugfender": "^1.1.3",
"@invertase/react-native-apple-authentication": "^1.1.2",
"@react-native-community/art": "^1.2.0",
"@react-native-community/async-storage": "^1.11.0",
"@react-native-community/datetimepicker": "^2.6.0",
"@react-native-community/google-signin": "^4.0.3",
"@react-native-community/masked-view": "^0.1.10",
"@react-native-community/netinfo": "^5.9.5",
"@react-native-community/picker": "^1.7.1",
"@react-native-community/push-notification-ios": "^1.3.0",
"@react-native-community/slider": "^3.0.3",
"@react-native-firebase/analytics": "^7.3.1",
"@react-native-firebase/app": "^8.2.0",
"@react-native-firebase/crashlytics": "^8.1.2",
"@react-native-firebase/messaging": "^7.4.2",
"@react-native-firebase/remote-config": "^7.2.2",
"@react-navigation/bottom-tabs": "^5.7.3",
"@react-navigation/core": "^3.5.2",
"@react-navigation/native": "^5.7.1",
"@react-navigation/stack": "^5.8.0",
"@youngtailors/react-native-spring-scrollview": "^2.1.0-rc.4",
"axios": "^0.19.2",
"base64-js": "^1.3.1",
"crypto-js": "3.3.0",
"d3-array": "^2.4.0",
"d3-interpolate-path": "^2.2.1",
"d3-scale": "^3.2.1",
"d3-shape": "^1.3.7",
"immutable": "^4.0.0-rc.12",
"lodash": "^4.17.19",
"lodash.get": "^4.4.2",
"lodash.isequal": "^4.5.0",
"qs": "^6.9.4",
"react": "16.13.1",
"react-native": "0.63.2",
"react-native-android-location-enabler": "^1.2.1",
"react-native-background-timer": "^2.2.0",
"react-native-ble-plx": "^2.0.1",
"react-native-circular-progress": "^1.3.6",
"react-native-dark-mode": "^0.2.2",
"react-native-device-info": "^5.6.2",
"react-native-device-time-format": "^2.3.0",
"react-native-fbsdk": "^2.0.0",
"react-native-firebase-test-lab": "0.0.2",
"react-native-fs": "^2.16.6",
"react-native-gesture-handler": "^1.6.1",
"react-native-gps-state": "^2.0.3",
"react-native-htmlview": "^0.15.0",
"react-native-iphone-x-helper": "^1.2.1",
"react-native-keep-awake": "^4.0.0",
"react-native-linear-gradient": "^2.5.6",
"react-native-localization": "^2.1.6",
"react-native-md5": "^1.0.0",
"react-native-mixpanel": "^1.2.0",
"react-native-modal": "^11.5.6",
"react-native-modal-datetime-picker": "^8.7.1",
"react-native-orientation": "^3.1.3",
"react-native-progress": "^4.1.2",
"react-native-push-notification": "^4.0.0",
"react-native-reanimated": "^1.10.1",
"react-native-safe-area-context": "^3.1.1",
"react-native-screens": "^2.9.0",
"react-native-snackbar-component": "^1.1.10",
"react-native-svg": "^12.1.0",
"react-native-unity-view-reinvented": "^1.4.2",
"react-native-user-inactivity": "^1.1.0",
"react-native-webview": "^10.3.3",
"react-native-wheel-picker-android": "^2.0.6",
"react-redux": "^7.2.0",
"redux": "^4.0.5",
"redux-logger": "^3.0.6",
"redux-thunk": "^2.3.0",
"xdate": "^0.8.2"
Thanks,
Binh

I'm facing the same problem
using RN 0.62.2


[Bug] Does not find 'minimal_init.vim' by default configuration

During the development of neotest-java, I encountered a problem when attempting to execute its tests with neotest-plenary. The tests failed to run as expected.
I was unable to use neotest-plenary until I explicitly specified the minimal_init file in the neotest-plenary configuration.
According to the documentation, neotest-plenary will glob for */minimal_init*, and I can find it on the source code. However I don't understand why it does not work as expected.
This is the error log when I don't explicitly set the min_init file in the config:
Testing:        /home/username/REPOS/neotest-java/tests/core/dir_filter_spec.lua
...l/share/nvim/plugged/plenary.nvim/lua/plenary/busted.lua:267: ./lua/neotest-java/core/root_finder.lua:1: module 'neotest.lib' not found:
        no field package.preload['neotest.lib']
        no file 'lua/neotest/lib.lua'
        no file 'lua/neotest/lib/init.lua'
        no file './neotest/lib.lua'
        no file '/__w/neovim/neovim/.deps/usr/share/luajit-2.1/neotest/lib.lua'
        no file '/usr/local/share/lua/5.1/neotest/lib.lua'
        no file '/usr/local/share/lua/5.1/neotest/lib/init.lua'
        ...

Did you happen to fix this? I ran into the same issue

For now, I set min_init option in the config as described in the README documentation. I did not look further into it yet.

Checked out the issue, and turns out we've got multiple minimal_init.vim files in some of the project subdirectories. I did expect that behavior, as these files are located within a directory ignored by Git. It also affects detecting tests, it includes all of them that are within git-ignored directories.

I have a path of spec/minimal_init.lua and it doesn't seem to be picked up. I have to manually specify the absolute path to the init file.
Wondering if the glob it is doing is not looking in the root of my project's directory.


Make image verification failures easier to spot

Before there would be no line number for the actual data that caused the verification to fail
We can fix this by turning the function into a macro
Relies on #147

This needs a rebase now that I merged the other PR :)

Rebased, thanks


Where can I find the created file path?

I am trying to create a file using the example program, it shows Successful file write, but I tried to get the file from my mobile using "ES File Explorer" application, but I can not able to find the fileToAppend.txt created file, please can you tell me where that file is stored.
window.resolveLocalFileSystemURL(cordova.file.dataDirectory, function (dirEntry) {
    console.log('file system open: ' + dirEntry.name);
    var isAppend = true;
    createFile(dirEntry, "fileToAppend.txt", isAppend);
}, function(a,b,c){ debugger;  });

function createFile(dirEntry, fileName, isAppend) {
    // Creates a new file or returns the file if it already exists.
    dirEntry.getFile(fileName, {create: true, exclusive: false}, function(fileEntry) {
debugger;
        writeFile(fileEntry, null, isAppend);

    }, function(a,b,c){ debugger;  });

}

function writeFile(fileEntry, dataObj) {
    // Create a FileWriter object for our FileEntry (log.txt).
    fileEntry.createWriter(function (fileWriter) {
debugger;
        fileWriter.onwriteend = function() {
            console.log("Successful file write...");
            //readFile(fileEntry);
        };

        fileWriter.onerror = function (e) {
            console.log("Failed file write: " + e.toString());
        };

        // If data object is not passed in,
        // create a new Blob instead.
        if (!dataObj) {
            dataObj = new Blob(['some file data'], { type: 'text/plain' });
        }

        fileWriter.write(dataObj);
    });
}

window.resolveLocalFileSystemURL(cordova.file.dataDirectory, function (dirEntry) { ...

https://github.com/apache/cordova-plugin-file#where-to-store-files

cordova.file.dataDirectory - Persistent and private data storage within the application's sandbox using internal memory

@janpio Can't I able to find it in my file manager?

I don't know. "private data storage within the application's sandbox using internal memory" doesn't sound like it. Have you tried cordova.file.externalDataDirectory? That sounds like it should be accessible.


Roll engine 88113925e3a0..8584da2c2400 (2 commits)

https://github.com/flutter/engine/compare/88113925e3a0...8584da2c2400
git log 88113925e3a063bd6a249346aaa784e65772a25b..8584da2c24009e37cd142765071152b88019c469 --no-merges --oneline
8584da2c2 Roll src/third_party/skia dc19391eef52..70aab823547a (8 commits) (flutter/engine#8836)
1cdc16322 Roll src/third_party/dart 1577b95c93..dbe80f3397 (43 commits)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/5328073225404416

Commit queue failed; closing this roll.


Promote universal filters/shortcodes to the top

https://deploy-preview-1243--11ty.netlify.app/docs/filters/
https://deploy-preview-1243--11ty.netlify.app/docs/shortcodes/

Personally, I like the way the documentation is currently structured, as having the individual filters first let's me understand what is going on. Then, by the time I see the universal filter, I already know how the universal filter works and what it does.
I feel the importance of this documentation page is to teach new users how 11ty works, rather than promote the best practices which is another topic altogether and deserves its own section.

IMO the language specific filters should be an advanced usecase. They’re really only useful when you’re writing a library that has to deal with people using a variety of template languages, and you need to have different behaviors since each language has a different feature set. New people should use universal filters (or just “filters”) by default, since it makes it easier to switch template languages.

I agree with this! I fixed the conflicts, and am merging it in—thank you!


Remove nux=1

Or at leas explain somewhere why it is included.

Closing this as we are archiving this sample. Please check out the new sample at ms-identity-javascript-angular-spa-aspnetcore-webapi.


Unify parametrized strings?

We're currently using three forms of parametrized strings. Examples:

path definition and URLs in connectors:

path: 'users/:id'

GraphQLQueries: e.g.

read: '{user(id: "%id") ...'

Custom Messages/Translations and itemTitles of tabs:

'addView.add.success': 'Succesfully created {title}.'

The problem is, that there are different limitation imposed on the special characters. For example, a GraphQL query already uses the { and } characters and the character % is a meaningful character in a URL...
Any suggestions?

Solved: Connectors got outsourced and itemTitle logic changed. So now we have only 'users/:id' for paths and 'successfully created {title}'. Which I consider managable


Add CSV and multiple register support to Generator

Depends on https://github.com/openregister/generate-picker-data-file/pull/4.

Thanks for the feedback @johnollier! After further discussion I think there's merit to doing that but it's not guaranteed that the end result would end up much more readable, so I wouldn't refactor at this point.


Add weight utilities to TxIn and TxOut

Add segwit_weight and legacy_weight methods to TxIn
Add weight method to TxOut

Heads up (though CI will flag I'm sure) that this doesn't compile with 1.41.0:
   Compiling bitcoin v0.29.0 (/tmp/tmpiw57dv_s/bitcoin)
error[E0277]: `[(bool, &str); 6]` is not an iterator
    --> bitcoin/src/blockdata/transaction.rs:1555:32
     |
1555 |         for (is_segwit, tx) in txs {
     |                                ^^^ borrow the array with `&` or call `.iter()` on it to iterate over it
     |
     = help: the trait `std::iter::Iterator` is not implemented for `[(bool, &str); 6]`
     = note: arrays are not iterators, but slices like the following are: `&[1, 2, 3]`
     = note: required by `std::iter::IntoIterator::into_iter`

error[E0277]: the size for values of type `str` cannot be known at compilation time
    --> bitcoin/src/blockdata/transaction.rs:1561:61
     |
1561 |             let tx: Transaction = deserialize(Vec::from_hex(&tx).unwrap().as_slice()).unwrap();
     |                                                             ^^^ doesn't have a size known at compile-time
     |
     = help: the trait `std::marker::Sized` is not implemented for `str`
     = note: to learn more, visit <https://doc.rust-lang.org/book/ch19-04-advanced-types.html#dynamically-sized-types-and-the-sized-trait>
     = note: all local variables must have a statically known size
     = help: unsized locals are gated as an unstable feature

otherwise d758074a8f583cd722f8b02deb0958789ea4a97f look good.

Pardon my ignorance, but what is the use of legacy_weight? Is segwit_weight not the only weight we should care about?
Is this about the one byte flag whether the tx contains witnesses or not?

Do we know someone who actually uses it? If not, I'd just drop it for now and add when someone asks.

Heads up (though CI will flag I'm sure) that this doesn't compile with 1.41.0:

Updated, thanks!

Do we know someone who actually uses it? If not, I'd just drop it for now and add when someone asks.

This is needed for https://github.com/rust-bitcoin/rust-miniscript/pull/476 :)

it's the weird reported to pre-segwit nodes ... which, okay, there's an argument that we don't really care about pre-segwit nodes 6 years after Segwit activation, but that's the value.

Yes, and also the correct weight of non-segwit inputs when included in non-segwit transactions, since the segwit_weight always includes (at least) 1WU for the witness length, even when the witness is empty

The new docs look great. Though I really wish there were a way to compute transaction weight without these footguns :/. Maybe we could have a method on Psbt that could more-reliably predict weight.

+1 to adding _min to the names -- sorry, I forgot about this suggestion too.

I guess you missed my question about naming. I think naming it min_legacy_weight, min_segwit_weight and min_weight would make the potential foot gun more visible in the code. Is there some reason why the min_ prefix is undesirable?

Ops, sorry!
I do see your point about warning users, but I'm not sure if that's the best way of accomplishing it. I consider the segwit marker and the txin/txout varint length to be outside the txins/txouts themselves, so I think that the weight we give back is the exact weight of the object, not the minimum one.

I don't think the min_ makes a lot of sense since the varint and the markers are outside of the TxIn .
For the same reasoning, should we use Transaction::min_weight() because if serialized in a block could change the varint of the number of transactions in the block?

Yeah, these are good arguments. min_ does sound like the weight of the actual input could potentially be larger, or that it can't be computed exactly.

Yeah, good points.

Sure, I'm afk now, but I'll fix asap!
-------- Original Message --------
On Dec 15, 2022, 19:15, Martin Habovštiak wrote:

@Kixunil approved this pull request.
ACK 6d51e92
But please consider fixing the doc formatting in a subsequent PR.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


[hw/dv] Feature/questa dv

This feature adds functionality for OpenTitan to simulate using Siemens Questa. See issue 9514 for further details.

Azure had a bit of a meltdown at the end of last week. I'll re-trigger the CI runs now.

It is failing now because it says there is no sign off line. This was missed in commit 05b8590 but on the final commit 91bf6f3 it is there as far as I can see.
It looks like the CI is only running for the older 05b8590. Is it possible for the CI to skip this commit?


[Bug] Could I compile and execute LLM model for VTA?

🐛 Bug

I'm trying to execute a Vicuna v1.5 model in VTA simulator with mlc-llm.
I had produce a compiled Vicuna model without any problem, but I got an error in runtime as follow.
Does MLC-LLM supported executing in VTA?
Traceback (most recent call last):
  File "benchmark.py", line 24, in <module>
    app.run(main)
  File "/venv/apache-tvm-py3.8/lib/python3.8/site-packages/absl/app.py", line 308, in run
    _run_main(main, args)
  File "/venv/apache-tvm-py3.8/lib/python3.8/site-packages/absl/app.py", line 254, in _run_main
    sys.exit(main(argv))
  File "benchmark.py", line 15, in main
    cm.benchmark_generate(
  File "/workspace/mlc-llm/python/mlc_chat/chat_module.py", line 977, in benchmark_generate
    self._prefill(prompt)
  File "/workspace/mlc-llm/python/mlc_chat/chat_module.py", line 1078, in _prefill
    self._prefill_func(
  File "/workspace/tvm-unity/python/tvm/_ffi/_ctypes/packed_func.py", line 239, in __call__
    raise_last_ffi_error()
  File "/workspace/tvm-unity/python/tvm/_ffi/base.py", line 481, in raise_last_ffi_error
    raise py_err
  File "/mlc-llm/cpp/llm_chat.cc", line 1650, in mlc::llm::LLMChatModule::GetFunction(tvm::runtime::String const&, tvm::runtime::ObjectPtr<tvm::runtime::Object> const&)::{lambda(tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*)#5}::operator()(tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*) const
  File "/mlc-llm/cpp/llm_chat.cc", line 952, in mlc::llm::LLMChat::PrefillStep(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, bool, bool, mlc::llm::PlaceInPrompt, tvm::runtime::String)
  File "/mlc-llm/cpp/llm_chat.cc", line 1327, in mlc::llm::LLMChat::ForwardTokens(std::vector<int, std::allocator<int> >, long)
  File "/workspace/tvm-unity/src/runtime/relax_vm/vm.cc", line 935, in operator()
    self->InvokeClosurePacked(clo, args, rv);
  File "/workspace/tvm-unity/src/runtime/relax_vm/vm.cc", line 529, in tvm::runtime::relax_vm::VirtualMachineImpl::InvokeClosurePacked(tvm::runtime::ObjectRef const&, tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*)
    clo->impl.CallPacked(TVMArgs(values.data(), tcodes.data(), args.size() + 1), rv);
  File "/workspace/tvm-unity/src/runtime/relax_vm/vm.cc", line 603, in operator()
    *rv = static_cast<VirtualMachineImpl*>(ctx_ptr)->InvokeBytecode(gf_idx, inputs);
  File "/workspace/tvm-unity/src/runtime/relax_vm/vm.cc", line 660, in tvm::runtime::relax_vm::VirtualMachineImpl::InvokeBytecode(long, std::vector<tvm::runtime::TVMRetValue, std::allocator<tvm::runtime::TVMRetValue> > const&)
    RunLoop();
  File "/workspace/tvm-unity/src/runtime/relax_vm/vm.cc", line 785, in tvm::runtime::relax_vm::VirtualMachineImpl::RunLoop()
    this->RunInstrCall(curr_frame, instr);
  File "/workspace/tvm-unity/src/runtime/relax_vm/vm.cc", line 738, in tvm::runtime::relax_vm::VirtualMachineImpl::RunInstrCall(tvm::runtime::relax_vm::VMFrame*, tvm::runtime::relax_vm::Instruction)
    this->InvokeClosurePacked(func_pool_[instr.func_idx], args, &ret);
  File "/workspace/tvm-unity/src/runtime/relax_vm/vm.cc", line 511, in tvm::runtime::relax_vm::VirtualMachineImpl::InvokeClosurePacked(tvm::runtime::ObjectRef const&, tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*)
    packed->CallPacked(args, rv);
  File "/workspace/tvm-unity/src/runtime/library_module.cc", line 78, in operator()
    LOG(FATAL) << TVMGetLastError();
tvm._ffi.base.TVMError: Traceback (most recent call last):
  10: mlc::llm::LLMChatModule::GetFunction(tvm::runtime::String const&, tvm::runtime::ObjectPtr<tvm::runtime::Object> const&)::{lambda(tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*)#5}::operator()(tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*) const
        at /mlc-llm/cpp/llm_chat.cc:1650
  9: mlc::llm::LLMChat::PrefillStep(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, bool, bool, mlc::llm::PlaceInPrompt, tvm::runtime::String)
        at /mlc-llm/cpp/llm_chat.cc:952
  8: mlc::llm::LLMChat::ForwardTokens(std::vector<int, std::allocator<int> >, long)
        at /mlc-llm/cpp/llm_chat.cc:1327
  7: operator()
        at /workspace/tvm-unity/src/runtime/relax_vm/vm.cc:935
  6: tvm::runtime::relax_vm::VirtualMachineImpl::InvokeClosurePacked(tvm::runtime::ObjectRef const&, tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*)
        at /workspace/tvm-unity/src/runtime/relax_vm/vm.cc:529
  5: operator()
        at /workspace/tvm-unity/src/runtime/relax_vm/vm.cc:603
  4: tvm::runtime::relax_vm::VirtualMachineImpl::InvokeBytecode(long, std::vector<tvm::runtime::TVMRetValue, std::allocator<tvm::runtime::TVMRetValue> > const&)
        at /workspace/tvm-unity/src/runtime/relax_vm/vm.cc:660
  3: tvm::runtime::relax_vm::VirtualMachineImpl::RunLoop()
        at /workspace/tvm-unity/src/runtime/relax_vm/vm.cc:785
  2: tvm::runtime::relax_vm::VirtualMachineImpl::RunInstrCall(tvm::runtime::relax_vm::VMFrame*, tvm::runtime::relax_vm::Instruction)
        at /workspace/tvm-unity/src/runtime/relax_vm/vm.cc:738
  1: tvm::runtime::relax_vm::VirtualMachineImpl::InvokeClosurePacked(tvm::runtime::ObjectRef const&, tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*)
        at /workspace/tvm-unity/src/runtime/relax_vm/vm.cc:511
  0: operator()
        at /workspace/tvm-unity/src/runtime/library_module.cc:78
  File "/workspace/tvm-unity/src/runtime/library_module.cc", line 78
TVMError: Assert fail: T.tvm_struct_get(p_lv807, 0, 10, "int32") == 12, Argument fused_fused_decode1_take1.p_lv807.device_type has an unsatisfied constraint: 12 == T.tvm_struct_get(p_lv807, 0, 10, "int32")

To Reproduce
Steps to reproduce the behavior:

I added below code to compile in parse_target() method of mlc_llm/utils.py(line 695), and built a Vicuna model using modified mlc-llm.

def parse_target(args: argparse.Namespace) -> None:
  ...
  elif args.target == "vta":
      import vta
      assert tvm.runtime.enabled("rpc")
      env = vta.get_env()
      device = "vta"
      target = env.target if device == "vta" else env.target_vta_cpu
      args.target = tvm.target.Target(target, host=env.target_host)
      args.target_kind = "vta"
  ...

TVM_LOG_DEBUG=DEFAULT=2 python mlc_llm/build.py --hf-path /dist/model/vicuna-7b-v1.5 --target vta --quantization q4f16_1

To execute compiled model, I added below code in detect_device() of mlc_chat/support/auto_device.py(line 35)

def detect_device(device_hint: str) -> Optional[Device]:
  ...
  elif device_hint == "vta":
      from vta.testing import simulator
      from tvm import rpc
      assert tvm.runtime.enabled("rpc")
      remote = rpc.LocalSession()
      device = remote.device("ext_dev", 0)
      device.MASK2STR[device.device_type] = 'vta'
      return device
  ...

I executed benchmark like a below code, and I got an above error.

cm = ChatModule(model=model_name, model_lib_path=compiled_model_path, device='vta')
output = cm.benchmark_generate(
      prompt=FLAGS.prompt,
      generate_length=FLAGS.length,
)

Expected behavior

I expected a Vicuna model was executed in mlc-llm with VTA simulator successfully.
Environment

Platform (e.g. WebGPU/Vulkan/IOS/Android/CUDA): VTA
Operating system (e.g. Ubuntu/Windows/MacOS/...): Ubuntu 22.04
Device (e.g. iPhone 12 Pro, PC+RTX 3090, ...):

Additional context

As far as I know, VTA is currently not undergoing maintenance. Meanwhile, Relax does not support VTA backends

Thank you.
Could I ask a further question, is this error caused by VTA, not by RPC? Is mlc-llm considered to be working on RPC?
If possible, I would like to modify mlc-llm and tvm to execute an LLM model on VTA. Is it feasible?


Late insertion of script inside a fragment

Let's consider the case
<x-fragment src="anURL.html">
  <template>
    <script src="anScript.js"></script>
  </template>
  <script>
    document.currentFragment.loaded.then(fragment => {
      fragment.appendChild(document.importNode(
        fragment.querySelector('template').content, true));
    });
  </script>

The inserted script doesn't have its src attribute resolved.

I think, I shouldn't delete the baseURI attribute. It could be useful for late resolution of src addresses.

From now, using <link rel="import">


[Spotify Player] ...

Extension – Spotify API Bug
Author: @mattisssa

Description
Steps To Reproduce

Use any command. In this case, I use Search Playlists.
Search for any playlist name, it shows the playlists properly
make sure you have not played any music on Spotify or used these commands for while, about 45 mins or so.

The current behavior
After hitting play command, extension fails and generates the warning in the attached screenshot.
The expected behavior
It should play the desired song-playlist-artist properly.
(Note: Restarting Raycast or playing something manually on Spotify fixes the issue temporarily. After an hour of inactivity bug reproduces itself. Both Raycast and the extension are up to date)
Raycast version
Version: 1.38.3

Hey! The issue has been fixed recently, could you please check for updates and ensure it still happens for you?

Thanks for the quick response. I did check for updates and everything seems to be updated. I also tried uninstalling and reinstalling the extension, however bug has remained consistent.

Should be fixed in the update, please let me know if it's not 😉

@mattisssa I don't see any update available to the extension.


curious about the statistics of 'level'

In the demo page, I can see a level select element whose values can be none, method and statement. This is cool. But is it only available for java? Can it support other languages?

Thank you for your feedback. Currently Java is the only supported language. The reason for the limited support is that a parser is used to differentiate between comment and code blocks. A second parser is then used to identify method blocks. Support for other languages is definitely possible however this requires an implementation of the both of the parsers described above for the specific language.
I should note that even though the documentation parser was written for java, it will most likely work with C++. This is because the documentation symbols used by both languages are the same. However other languages such as Ruby or Python the parser will not be able to identify the documentation since they use different comment symbols.
The second language specific parser, the method identification, is fairly Java specific. The parser will most likely not properly identify methods for C++ since the method signatures are different from Java.


API staking annual reward calculator

Return:

Min % annual reward
Max % annual reward
% annual reward for staking earch MN

Add swagger docs

Change Block Time to Avg. Staking Reward = (Max + Min)/2

Add Est. Annual Staking reward


Consistent naming for environment variables

I'm submitting a ...  (check one with "x")
[ ] bug report => search github for a similar issue or PR before submitting
[x] enhancement request
[ ] feature request
[ ] support request
[ ] general question

Current behavior (how does the issue manifest):
Env var name STOP_ENGINE_ON_ERROR is not consistent with other vars e.g. FLOGO_LOG_LEVEL
Expected behavior:
Name should be FLOGO_ENGINE_STOP_ON_ERROR
Minimal steps to reproduce the problem (not required if feature enhancement):
NA
What is the motivation / use case for changing the behavior?
Consistency
Please tell us about your environment (Operating system, docker version, browser & verison if webui, etc):
Flogo version (CLI & contrib/lib. If unknown, leave empty or state unknown): 0.X.X
0.5.2
Additional information you deem important (e.g. issue happens only occasionally):

In this particular case, I feel backward compatibility is not needed. @mellistibco ??

I agree with @vijaynalawade. probably don't need it for this one


Update SelveRF stable version to 0.6.3

As mentioned here the stable version can be bumped. I didn't have time to do this earlier.
There were no functional changes in this version and I have been using it since January this year without problems. I didn't see any problems in the forum either.

Thanks for reviewing this issue and providing a PR
I'v provided a PR to update your testmatrix. NOde 14 is no longer supported and will always fail. So testing should / must be performed with node 16 / 18 / 20. Merging this PR will likely make your dependabot PRs pass again.

0.6.3 created 08.01.2023
7 User
OK


Make ansible-lint and best practices copliant

Ansible-lint checks playbooks for practices and behavior that could potentially be improved. We have some bad habits in the code which we can make better:

Use echo to register variables: We should replace this wit set_fact. The problem here is, that we use the .stdout over and over. So i register it as a dict, but that's only for BC compatibility. We should change this to a version without .stdout in a future version.

Use synchronize instead of rsync in a command: I'm not sure if this is working. @mblaschke removed synchronize some time ago and replaced it with the plain rsync call. It would be great if you have a look at this and give some feedback to this issue.

Use the creates argument when using a command.

Some minor tasks like whitespace, missing names and deprecated sudo instead of become.

What do you think about this improvements? Please provide some feedback so we can make Ansistrano even better :-)

It looks like some tests broke, anyway, about all you point out:

We don´t even need set_fact but just concatenate them in defaults/main.yml, we haven´t done it to prevent BC breaking but I guess it is time to consider breaking it. And if we do it, just have the variables defined in defaults so that people can override them or use the variable straight away. If we create a 2.x series, should be fine
Rsync was used in that particular bit as it is much quicker to do it in a raw command than using the synchronise module, this feature from @mblaschke is for advanced users who need extra speed when deploying so I would be relatively 👎 about it
You have added the sudo -> become change in this PR, it should not be here
👍 on using Ansible lint
Unclear about the benefits of adding creates

I have added some cleanup at https://github.com/ansistrano/deploy/pull/201
Can you please reopen this with the Ansible lint changes? Not sure about the other things you proposed

Hi @FlxPeters
Sorry about the late reply but I would be happy if you could reopen this PR with the ansible-lint and the creates arg (read a bit more about it :)). I would leave the rsync stuff contributed by @mblaschke as it is since this way of deployment was added to improve speed
And of course, we would be happy to start the integration with Molecule!

Yes, i add the create statements. I will close this PR and add a new one based on #201.


Trustworthy identification of service caller

Description
I have a service which needs to know the identity of the service calling its API. From reading the documentation I see there is the x-envoy-downstream-service-cluster header which can be attached to HTTP requests to carry this information. However, in the docs it says:

Note that in the current implementation, this should be considered a hint as it is set by the caller and could be easily spoofed by any internal entity

So my question is, is there a trustworthy mechanism to propagate the service identity with a HTTP request?
Relevant Links
https://www.envoyproxy.io/docs/envoy/v1.5.0/configuration/http_conn_man/headers#x-envoy-downstream-service-cluster

You would need to set up mTLS, use JWT, etc. so the service identity can be cryptographically verified.

@mattklein123 Even with mutual TLS enabled, the called service still needs to know the caller identity at the REST API level, and I'm hoping to get this information from Istio in order to create a JWT.


[sync sdk] crypto/internal/bigmod: switch to saturated limbs

crypto/internal/bigmod: switch to saturated limbs
Turns out that unsaturated limbs being more performant for Montgomery
multiplication was true in portable C89, but is now a misconception.
With add-with-carry instructions, it's possible to run the carry chain
across the limbs, instead of needing the limb-by-limb product to fit in
two words.
Switch to saturated limbs, and import the same Montgomery loop as
math/big, along with its assembly for some architectures. Since here we
know the sizes we care about, we can drop most of the assembly
scaffolding. For amd64, ported to avo, too.
We recover all the Go 1.20 performance loss on private key operations on
both Intel Xeon and AMD EPYC, with even a 10% improvement over Go 1.19
(which used variable-time math/big) for some operations.

看起来这个改动有性能损失，它的优化主要针对RSA那种大数位数很多的那种（1024、1536、2048），对用于椭圆曲线的256位，性能反而有所下降。

如果针对256位数字做优化：
goos: windows
goarch: amd64
pkg: github.com/emmansun/gmsm/internal/bigmod
cpu: Intel(R) Core(TM) i5-9500 CPU @ 3.00GHz
BenchmarkModMul256-6   	 1766509	       686.0 ns/op
BenchmarkSign_SM2-6   	   38679	     31679 ns/op	    8156 B/op	      77 allocs/op

似乎还可以接受。


[SDL-0188] Moving scripts to new feature branch

This PR is ready for review.
Summary
Moving existed feature tests to the new branch
ATF version
develop
CLA

[x] I have signed the CLA

All updates according to review comments are in 09ae553


[MM-17198] Send serverVersion to redux store on login and loadMe

Summary
This PR sets the server version as part of the login complete and load me calls. Server version is needed to correctly decide which is the appropiate channel to redirect a user either right after login or when the user is logged in and loads the root of the server, therefore the setServerVersion action is dispatched as part of those two processes.
Ticket Link
https://mattermost.atlassian.net/browse/MM-17198
Checklist

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit tests passed
[x] Ran make flow to ensure type checking passed
[x] Added or updated unit tests (required for all new features)

Related Pull Requests

Has webapp changes

Changes looks good. This will be tested as part of the 5.16 release Guest Accounts feature. Removing the QA Review label.

@enahum my rationale here is that this is used in a method that belongs to mattermost-redux as well, hasNewPermissions inside getRedirectChannelNameForTeam here https://github.com/mattermost/mattermost-redux/blob/master/src/selectors/entities/channels.js#L1236, so chances are that the same problem would happen in any application that used mattermost-redux
I'm 0/5 on this approach, happy to move it to the webapp if that's preferred.

@mgdelacroix I can speak for the mobile app that is using this https://github.com/mattermost/mattermost-redux/blob/ab9f1ff1b5c077a6a898326fcc989d4637d05e96/src/actions/websocket.js#L687 and then listening to that event to trigger the setServerVersion action

@enahum same happens in the webapp, server version is set after the websocket connection. In this case, that was not enough, as the webapp is making decisions based on the server version (like channel redirection) without establishing the websocket connection first. That's why an alternative method (right after the first request, either login or load me) made sense

@mgdelacroix ok understood, thanks for the explanation, if there isn't a better way to handle it I think is ok.

@enahum :+1:
Thanks for taking the time to review the approach!! :smile:


Add carbon elements

Let's add carbon elements to the catalog. Should close https://github.com/PolymerElements/carbon-route/issues/57

This looks good locally. I needed to stamp v0.8.1 of carbon-route to get our updated docs (v0.8.0 had invalid markdown).
The demo looks pretty good but I'd like to wait for https://github.com/PolymerElements/carbon-route/issues/53 to land before we push this out though, so that there's a useful URL bar in the demo. After that lands (and we stamp v0.8.2) I'd say that this is good to go.

great! ^ cc @tjsavage

Sounds good - let's wait for it to land then push.

Ok, it's landed and released as v0.8.2, LGTM!


allow reward blocking in distribution module

Description
Note: This PR isn't nearly as big as it seems! Most of the LOC changed are generated
Stride requires some addresses to be blacklisted, so that they can vote and bond, but cannot accrue staking rewards. These addresses are specified as a parameter. There are two steps to the blacklisting process

Scale down rewards for a validator so that the rewards are proportional to the validator's whitelisted stake
Only distribute tokens to addresses if they are not blocked

Scaling down rewards for a validator so that rewards are proportional to the validator's whitelisted stake
Here, we need to scale down by the proportion of whitelisted stake. Note, at block n, we distribute rewards for block n-1, which was signed by validators finalized in block n-3. See https://github.com/tendermint/tendermint/pull/1815 for more details
To achieve this, we

Store BlacklistedPower and ValidatorBlacklistedPower (which indexes validator power by block)
Index in the BeginBlocker
Add GetTotalBlacklistedPower  which returns the total power and blacklisted power for a validator

We construct a map from validator -> blacklisted power for all validators. Using this, we downscale in allocation.go
Distribute to addresses that are not blocked
Only distribute addresses if they are not blocked

In CalculateDelegationRewards we return 0 coins for
In withdrawDelegationRewards, we set rewards to 0

Question: @riley-stride why do we need both of these?
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[ ] included the correct type prefix in the PR title
[ ] added ! to the type prefix if API or client breaking change
[ ] targeted the correct branch (see PR Targeting)
[ ] provided a link to the relevant issue or specification
[ ] followed the guidelines for building modules
[ ] included the necessary unit and integration tests
[ ] added a changelog entry to CHANGELOG.md
[ ] included comments for documenting Go code
[ ] updated the relevant documentation or specification
[ ] reviewed "Files changed" and left comments if necessary
[ ] confirmed all CI checks have passed

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed ! in the type prefix if API or client breaking change
[ ] confirmed all author checklist items have been addressed
[ ] reviewed state machine logic
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage
[ ] manually tested (if applicable)

Some of these suggestions are to self, happy to take them just lmk @asalzmann


Use path-posix package for browser-friendly build

Closes #8
Verified all tests pass.
Verified that this results in a build that runs in the browser.

Hmm, I'm not sure I want to pull in a very old duplication of a Node API in order to paper over a deficiency in some other duplication. I don't see any reason for whatever is supplying the path package in your browser build to omit the posix export.
If you're using rollup-plugin-node-builtins, there's an issue for this: https://github.com/calvinmetcalf/rollup-plugin-node-builtins/issues/33
Browserify, on the other hand, seems to include a correct posix export. Perhaps you could use a Rollup plugin to alias the path import to path-browserify.
I'm going to close this.


Mac: Fix and enable remaining dehydrate functional tests

Resolves #1216
VFS for Git was already doing the right thing.  The only changes needed to the test code:

Switch from CmdRunner.DeleteDirectoryWithUnlimitedRetries to RepositoryHelpers.DeleteTestDirectory
Updated DirectoryShouldContain to sort the entries before comparing them as the order is different on Mac and Windows

/azp run PR - Windows - Functional Tests


active two-way data binding is broken in  1.2.0 and 1.2.1

Bug description:
The 2-way data binding for the 'active' attribute in the tab component seems to be completely broken with the latest two versions. I'd give a plnkr, but plnkr is giving me a helluva time loading the latest js, in fact, so is jsfiddle. here's a working example: https://jsfiddle.net/willbdaniels/2mq3106a/14/ it just has the js I needed (1.2.0) embedded. you can change the raw js around to see the problem not being present in the version just before that
Version of Angular, UIBS, and Bootstrap
Angular: 1.4.8
Bootstrap: 1.2.1
Edit to add in nice plunker
http://plnkr.co/edit/GkyGI4V92I4DXp3CWYwp

@WillBDaniels, you can use the 'Edit in Plunker' link from our demo page to create a  basic working plunker you can use to reproduce your issue.  Your instructions are a little vague so we're going to need a plunker that shows the issue.  Thanks.

@icfantv alright, I think i got the plunk working, you can see the behaviour here: http://plnkr.co/edit/GkyGI4V92I4DXp3CWYwp
Namely, you'll notice that the $scope.activeTab is being completely unaffected by the 'active' property on the uib-tab. Then, if you change the ui-bootstrap version to '1.1.2' in the index.html instead of 1.2.1, the behaviour goes back to normal, and all $scope variables are respected again.

Thank you.  I was able to confirm this as an issue in our application at work as well.  Marking as a bug.

This is not a bug - the active attribute was changed, as noted in the changelog. The new usage is shown in the example.
Here is a working Plunker

@WillBDaniels, with apologies for the team, this should have been marked as a breaking change so it showed up in the change log.  It wasn't so it didn't.  I will update when I get to work.

It's worth noting, that in the official documentation link to docs the 'select tab' buttons are still broken due to this change.

Aw man.  Yea.  Good catch.

We still need the docs update portion of this even though the CHANGELOG has been fixed.

Hi,
I was waiting this 1.2.x release so much because of template-url attribute for tabs. But I had to disappoint a little because of this active handling.
I needed to use different tab template on one page and default template on another. I was first testing it with global override using $provide in .config() phase, but it changed the new template for all pages. (ofc.)
What I need, is that I can toggle tab open/close.
Here is Jsfiddle where I have uib 1.1.2 in use
as you can see I was able to open/close tabs. (toggle)
Here is Jsfiddle with latest uib 1.2.x and I haven't been able to get that toggle feature to work. How this can be done? (if it even can be done)
I could do this if 'select' would be called on each click. Or could this toggle be done to the main tab ctrl + template?
I'm in the situation where I need to revert to 1.1.x series and make some hax logic in to .config() section where I detect that which page I am and override tab template on the right page.
Or
I need to create my own copy-paste tab solution :|

@RopoMen, please do not hijack issue threads.  Additionally, per our project documentation, the issues forum is not for support requests.  Please use a wider-audience venue like StackOverflow.  Thanks.

Hi,
You have an error in your page. Look at: https://angular-ui.github.io/bootstrap/#/tabs
When we click, for example, "select third tab" nothing happens.
Thanks a lot,
Bruno

@bmvantunes, please be respectful of our time by 1) reading the issue on which you are commenting and 2) performing a search of existing issues before entering anything.  What you've entered has already been noted above.  Additionally, it is a duplicate of #5558 and #5560.

Hi @icfantv, I did not want to disrespect you in any way. I really love your work!


Build for aarch64

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

@conda-forge-admin, please rerender.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@scopatz, this is ready for review :)

This should probably go through the usual arch migration. Please add attr to this file: https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/master/recipe/migrations/arch_rebuild.txt

Thanks. I wasn't aware of that.


How to run multi-person pose estimation?

When I run the python pose api, I find I can only get a single-person pose estimation, How can I get multi-person pose estimation?

Hi @EconML , @Sihan-Song  did you get a chance to look at this https://github.com/google/mediapipe/issues/1442#issuecomment-754821084.

Closing this ticket as there is a lack of activity on it.

anyone have code for multi-pose estimation using mediapipe ??


sysconfig: use get_makefile_filename() from stdlib sysconfig

Instead of guessing the filename just refer to the stdlib.
This also removes the "_makefile_tmpl" hook added in pypa#16, but

It was never implemented by the distro requesting it from what I can see:
https://github.com/NetBSD/pkgsrc/blob/586097714897b1b4d4a9/devel/py-setuptools/Makefile#L28
The stdlib version should return a proper result as it is patched by the distro requesting the change:
https://github.com/NetBSD/pkgsrc/blob/6efa5763ec447864a7d4/lang/python38/patches/patch-Lib_sysconfig.py

Also adds a small test checking that the file exists on Unix platforms

@0-wiz-0 can you confirm this does not break anything for NetBSD?

I do see that pkgsrc already patches sysconfig for similar purposes, so I expect that deferring to sysconfig is the right thing to do.

I do see that pkgsrc already patches sysconfig for similar purposes, so I expect that deferring to sysconfig is the right thing to do.

Ah, thanks. I've updated the commit message accordingly, linking to the upstream patch,

thanks!


Delete the deperecated .swift-version file and add swift_version to AsyncSwift.podspec.

Hello.
Thank you for Async.
In this pull request I added missing swift_version to AsyncSwift.podspec. Also deleted .swift-version, it was deprecated.

Thanks @RomanPodymov!


[🤖 CI] Upload diagnostics on push

The file name was wrong. The diagnostics.zip file is helpful to investigate CI failures

Merging quickly as it's the only way to test


Some compatibility issue with Drag Ruler

Using YTV (v2.5.2) Drag Ruler (v1.7.7) on Foundry 0.8.8, and with the option for walls to cancel animation checked.
As a GM when you drag a token over a wall the animation is cancelled, but the ruler that appears when you drag the token is visible for the duration that the actual move would have taken.
If you right click while the token is moving, the drag ruler disappears and from that moment onwards, for the selected token the drag ruler vanishes as intended (now and then when you pick up the token and move it a bit fast the movement is not registered at all though as a side issue).
If you choose another token at any point or deselect the first token, the same issue appears again and so on.
In the video the aforementioned behaviour is shown and just before I start moving the tokens around rapidly, I have right clicked to make the drag ruler template disappear faster.
https://user-images.githubusercontent.com/7237090/125272335-a1916700-e303-11eb-9c53-b685e277f520.mp4
Not sure if this is a Tokens Visible or Drag Ruler issue. Think that another issue with these two modules I raised on Foundry discord was addressed with a YTV update though, so I post it here first.

I would report this issue to Drag Ruler.
Drag Ruler draws and erases the ruler, not YTV.
Drag Ruler should probably wrap Token.prototype.setPosition if it wants to
guarantee that the duration of the ruler rendering always matches the
duration of the animation rather than assuming a duration.
After setPosition returns then the animation is complete.
On Mon, Jul 12, 2021 at 6:24 AM thatlonelybugbear @.***>
wrote:

Using YTV (v2.5.2) Drag Ruler (v1.7.7) on Foundry 0.8.8, and with the
option for walls to cancel animation checked.
As a GM when you drag a token over a wall the animation is cancelled, but
the ruler that appears when you drag the token is visible for the duration
that the actual move would have taken.
If you right click while the token is moving, the drag ruler disappears
and from that moment onwards, for the selected token the drag ruler
vanishes as intended (now and then when you pick up the token and move it a
bit fast the movement is not registered at all though as a side issue).
If you choose another token at any point or deselect the first token, the
same issue appears again and so on.
In the video the aforementioned behaviour is shown and just before I start
moving the tokens around rapidly, I have right clicked to make the drag
ruler template disappear faster.
https://user-images.githubusercontent.com/7237090/125272335-a1916700-e303-11eb-9c53-b685e277f520.mp4
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/David-Zvekic/TokensVisible/issues/21, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AH3YQQTM2E3SSGPSZLU2JJ3TXK7E3ANCNFSM5AGRNP7Q
.

This bug does also occur in "Your Tokens Visible" when Drag Ruler is disabled when moving the token via Measure+Spacebar, meaning Drag Ruler doesn't have anything to do with this bug occuring.

I'll look at your report of the "bug" without drag ruler, because you are
changing your report and now reporting that there is no dependence on Drag
Ruler.
"As a GM when you drag a token over a wall the animation is cancelled, but
the ruler that appears when you drag the token is visible for the duration
that the actual move would have taken."
That issue is caused by Drag Ruler, making assumptions of the animation
time.   Without Drag Ruler, using core system, as a GM if you attempt to
draw a ruler path that crosses a wall, Foundry cancels the entire movement
and gives you an error that the movement path crosses a wall.  This happens
with or without YTV.   When you do a valid ruler-token-movement without
Drag Ruler, the ruler rendering in the base Foundry system exactly matches
the travel time of the token.
"If you right click while the token is moving, the drag ruler disappears
and from that moment onwards, for the selected token the drag ruler
vanishes as intended (now and then when you pick up the token and move it a
bit fast the movement is not registered at all though as a side issue)."
What you describe is standard behavior, with or without YTV.  attempting to
move the token before its current token-movement is complete, moves the
token from it's current position to the new position immediately - Foundry
does not let the current movement finish.  Right clicking a token movement
along a ruler, causes the rule to vanish immediately (with or without YTV).
On Wed, Jul 14, 2021 at 10:14 AM Manuel Vögele @.***>
wrote:

This bug does also occur in "Your Tokens Visible" when Drag Ruler is
disabled when moving the token via Measure+Spacebar, meaning Drag Ruler
doesn't have anything to do with this bug occuring.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/David-Zvekic/TokensVisible/issues/21#issuecomment-879930081,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AH3YQQQWFMCFYWS3KJ4KWVTTXWLVPANCNFSM5AGRNP7Q
.

Please note that the comment that "changed" the bug report wasn't made by the person who initially reported the issue. I'm the author of Drag Ruler and left that comment because I closed this issue in my repository because I don't consider Drag Ruler to be at fault for this behavior and wanted to let you know about this. My explanation of why I think this is the case was rather brief and I'll elaborate a bit further on why I think that:
Generally, Drag Ruler replicates the behavior of the Measure+Spacebar movement scheme. For one Measure+Spacebar does already do roughly the right thing and additionally doing things this way reduces the likelyhood of module conflicts, because modules that work well with Foundry Cores Measure+Spacebar functionality are very likely to work well with Drag Ruler too. As a result should you decide to fix the compatibility with Measure+Spacebar, the issue presented here with Drag Ruler will very likely go away as well. That's why I consider this not to be a bug in Drag Ruler.
Additionally I'd like to state that Drag Ruler doesn't make any assumptions about the animation time. It simply calls Token.animateMovement and awaits that fucntions completion. After that function returns, the Ruler is being cleared. If the animation is cancelled properly (if it isn't this might be a core foundry as well - this has happened in the past) that would be a possible explanation for the behavior described in this issue.

Indeed, I didn't change my initial report at any point but instead reported the issue to the Drag Ruler git as instructed.
I am taking a look at how another module (Monks Little Details) cancels the movement when you press a specific key. There are no issues when this module cancels the movement with the Drag Ruler being cleared immediately.

I looked at Monks LIttle Details method but that method doesn't work because by the time the YTV code fires, Drag Ruler has already called animateMovement asynronously and is waiting for the promise (which is simply pending because javascript it not really asynchronous).
This however gave me an idea, and 2.5.3 should fix it.
Since setPosition is the last method called, and it awaits animateMovement, and YTV is also wrapping animateLinear (for the ability to change animation speed), this means YTV can decide to set the duration to 0 temporarily for ANY token animation that happens after it calls await.   this 'await' call then allows all the promises to be animated which are then set to 0 duration (because they depend on the YTV wrapped animateLinear.  Subsequently the Drag Ruler vanishes as the User expects.
uploading 2.5.3 now.

Works like a charm! Nice one, thanks


Adjust count url facebook

adjustment to also make it work on httpS sites.

Thank you for the PR!


fix: release-please-config

Description
Fix release with release-please
Issues Resolved
List any existing issues this PR resolves
Check List

[✔] A summary of changes made is included in the CHANGELOG under ## Unreleased
[➖] New functionality includes testing.
[➖] New functionality has been documented in the README if applicable.

Amazing. Let's see if this works 🤞


Using precompiled c++ annoy binaries

r? @yonromai
It looks like the way to do it(as in snappy-java) is to precompile binaries for different architectures rather than ship the source code and compile on target machines. So this PR covers for 2 types: 64bit OSX and our edgenode linux machines. That way we don't need depend on g++, javah, c++ header files etc on deployed machines.

@ijklr Right, but here the problem is that each time we update annoy, we need to manually compile the code on several machines and copy it to the jar, right? The makes the build process really shaky.
Snappy java uses dockcross for compiling cross platform at build time. This seems like a much more maintainable approach.


Parallelize vm resource tests

This is to address #149
Testing

[ ] Verify make testacc is just as consistent as before
[ ] Find the right balance of GOMAXPROCS to make the tests as fast as possible

Use 5 processes reduces the test time from 80 minutes to 30 minutes
FAIL
[DEBUG] Running sweeper
FAIL    github.com/ddelnano/terraform-provider-xenorchestra/xoa 1960.791s
testing: warning: no tests to run
PASS
ok      github.com/ddelnano/terraform-provider-xenorchestra/xoa/internal        0.018s [no tests to run]
FAIL
make: *** [Makefile:36: testacc] Error 1


All but the last t.index reference for a table are ignored

Given this schema.rb containing this fragment:
  create_table "streams", force: :cascade do |t|
    t.datetime "created_at"
    t.datetime "updated_at"
    t.jsonb    "dependencies",       null: false
    t.index name: "index_first", using: :gin, expression: "(dependencies -> 'one'::text)"
    t.index name: "index_second", using: :gin, expression: "(dependencies -> 'two'::text)"
  end

and then running rake db:drop db:create db:schema:load, only the second index is created. This is using the schema_plus on master, using Padrino.

@fj thanks for the bug report -- i reproduced it using rails too.  will take a look

Closed in favor of SchemaPlus/schema_plus_pg_indexes#8

@fj fixed it schema_plus_pg_indexes v0.1.9, which should be pulled in by schema_plus if you bundle update

@fj oops committed the version yesterday bump but forgot to do the release.  now schema_plus_pg_indexes v0.1.9 is released


Dear Rakesh(@SM-ins),

Dear Rakesh(@SM-ins),
Thank you for your feed-back!
cs.Population does not input the CSV files directly downloaded from THE WORLD BANK. We need DataLoader class to use them.
Please run the following codes with the latest version (>2.3.0).
data_loader = cs.DataLoader("../input")
pop_data = data_loader.population()
pop_data.cleaned().tail()

Type of pop_data is equal to cs.Population and "locations_population.csv" will be saved in "../input" directory. This is different from "API_EN.POP.DNST_DS2_en_csv_v2.csv", but well organized.
Best Regards,
Lisphilar
Originally posted by @lisphilar in https://github.com/lisphilar/covid19-sir/issues/42#issuecomment-651144648

This issue is discussed in #42 and I will close this new issue.


Updated JSON specs

Description
This PR addresses https://github.com/openforcefield/fragmenter/issues/16 and updates the JSON specs for qcfractal portal
Changes that were made:

Added connectivity to molecule
Geometry is now in Bohr
Added a workflow JSON here to define options for all fragmenter routines, torsiondriver, and qc options.
Removed initial crank state JSON and instead added an input dictionary with the following structure:

The fragment_ID is the canonical, isomeric, explicit hydrogen, mapped SMILES.
{ fragment_ID: {
    provenance: {
        workflow_id:
        canonicalization:
        creator: fragmenter
        hostname:
        routine: {...}
        ....
    }
    torsiondriver_input: {
        job_0: {
            dihedrals: [[0, 1, 2 3],...]
            grid_spacing : [30, ...]
            molecule: {
                connectivity: [[0, 1, 1], ...]
                geometry: [1.233, 2.156, ...]
                identifiers: { (cmiles output goes here)}
                molecular_charge:
                molecular_multiplicity:
                symbols: [C, C, ...]
                }
            }
        }
    }

Status

[ ] Ready to go

@Lnaden and @dgasmith, The travis builds are failing with the following error:
ERROR: dist-info version incorrect (is lib/python3.6/site-packages/cmiles-0+unknown, should be 0.0.0)
None of the travis or conda files were changed in this PR and I can't reproduce this error locally. All tests pass locally.

Codecov Report

Merging #18 into master will decrease coverage by 1.51%.
The diff coverage is 67.58%.


python312Packages.polyfactory: 2.18.0 -> 2.18.1

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 359283

x86_64-linux

:fast_forward: 2 packages marked as broken and skipped:

chatgpt-retrieval-plugin
chatgpt-retrieval-plugin.dist

:x: 2 packages failed to build:

python311Packages.weaviate-client
python311Packages.weaviate-client.dist

:white_check_mark: 8 packages built:

litestar
litestar.dist
python311Packages.polyfactory
python311Packages.polyfactory.dist
python312Packages.polyfactory
python312Packages.polyfactory.dist
python312Packages.weaviate-client
python312Packages.weaviate-client.dist

@fabaff Even it was broken before, I still update it to the newest and disable it on python311. It reports that setuptools.build_meta not found but I don't know why and how to fix it.