cmd/scollector: WIP for DSC status

This still needs some error handling, but the basics are there. Going to test it on a few systems tomorrow but would love a code review whenever someone gets a chance.

Reviewed 9 of 10 files at r1.
Review status: 9 of 10 files reviewed at latest revision, 11 unresolved discussions, all commit checks successful.

cmd/scollector/collectors/dsc_windows.go, line 10 [r1] (raw file):
No need to name this.

cmd/scollector/collectors/dsc_windows.go, line 86 [r1] (raw file):
need to check for error

cmd/scollector/collectors/dsc_windows.go, line 104 [r1] (raw file):
no need for , _

cmd/scollector/collectors/dsc_windows.go, line 105 [r1] (raw file):
c.Success++ is fine

cmd/scollector/collectors/dsc_windows.go, line 109 [r1] (raw file):
same as above

cmd/scollector/collectors/dsc_windows.go, line 123 [r1] (raw file):
. at EOL

cmd/scollector/collectors/dsc_windows.go, line 130 [r1] (raw file):
"Time in seconds" or just "Seconds" taken...

cmd/scollector/collectors/dsc_windows.go, line 174 [r1] (raw file):
switch mode {
case "PULL":
  return 0
...

cmd/scollector/collectors/dsc_windows.go, line 187 [r1] (raw file):
switch t {
case "Reboot":
  return 0
...

cmd/scollector/collectors/dsc_windows.go, line 204 [r1] (raw file):
nope, gotta return errors all the way up or ignore them. collectors don't ever log errors.

cmd/scollector/collectors/dsc_windows.go, line 207 [r1] (raw file):
I'm not really a fan of using time.Now() for this. Much more inclined to record the actual timestamp and compute things from that instead.

Comments from the review on Reviewable.io

Reviewed 1 of 10 files at r1.
Review status: all files reviewed at latest revision, 11 unresolved discussions, all commit checks successful.

Comments from the review on Reviewable.io

Review status: 9 of 10 files reviewed at latest revision, 11 unresolved discussions, some commit checks pending.

cmd/scollector/collectors/dsc_windows.go, line 10 [r1] (raw file):
Done.

cmd/scollector/collectors/dsc_windows.go, line 86 [r1] (raw file):
Done.

cmd/scollector/collectors/dsc_windows.go, line 104 [r1] (raw file):
Done.

cmd/scollector/collectors/dsc_windows.go, line 105 [r1] (raw file):
Done.

cmd/scollector/collectors/dsc_windows.go, line 109 [r1] (raw file):
Done.

cmd/scollector/collectors/dsc_windows.go, line 123 [r1] (raw file):
Done.

cmd/scollector/collectors/dsc_windows.go, line 130 [r1] (raw file):
Done.

cmd/scollector/collectors/dsc_windows.go, line 174 [r1] (raw file):
Done.

cmd/scollector/collectors/dsc_windows.go, line 204 [r1] (raw file):
Done.

cmd/scollector/collectors/dsc_windows.go, line 207 [r1] (raw file):
Do you mean run_start_time instead of run_age? Had a discussion about that in slack today https://bosun.slack.com/archives/general/p1434645366001374
I feel pretty strong about this being seconds since and not a timestamp. Lets jump on a hangout tomorrow if you want to talk about it.

Comments from the review on Reviewable.io

Review status: 9 of 10 files reviewed at latest revision, 11 unresolved discussions, some commit checks pending.

cmd/scollector/collectors/dsc_windows.go, line 187 [r1] (raw file):
Done.

Comments from the review on Reviewable.io

Review status: 9 of 10 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

cmd/scollector/collectors/dsc_windows.go, line 207 [r1] (raw file):
Talk to Kyle about this.

Comments from the review on Reviewable.io

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

Comments from the review on Reviewable.io

@mjibson or @captncraig This is ready for a final review before merging. I talked with Kyle about the Age vs Timestamp and he was fine with Age.

You can merge this yourself after you fix the imports list.


Enforce 16 BPP support

VNC servers delivering 16 BPP were not handled (black screen)

Closing this PR as its not seen activity from the author in over a year and now has conflicts.

Closing this PR as its not seen activity from the author in over a year and now has conflicts.

Because I don't work on it since nov 2021 and cannot modify/improve it anymore.
Good to know that @pmhahn seems to have taken over this PR and provided a more elaborate and universal solution.
For me, it was a quick hack to make it work. In my case.
Regards.


fix: patch devmenu on bridgeless

Details

Calling getReactNativeHost and getReactInstanceManager on bridgeless mode is forbidden, since the getReactHost is the one to go there. When the former is called, it leads to such scenario:

getReactInstanceManager creates new instance of ReactInstanceManager (which should not happen since it is bridge concept)
ReactInstanceManager creates an instance of BridgeDevSupportManager: (https://github.com/facebook/react-native/blob/63f8c3dcd6dbc4424d4f519101b06fab9cb4ff76/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java#L274 then https://github.com/facebook/react-native/blob/63f8c3dcd6dbc4424d4f519101b06fab9cb4ff76/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DefaultDevSupportManagerFactory.kt#L72)
It adds a listener for handleReloadJS: https://github.com/facebook/react-native/blob/63f8c3dcd6dbc4424d4f519101b06fab9cb4ff76/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/BridgeDevSupportManager.java#L163 which, after reload, triggers creation of new ReactApplicationContext: https://github.com/facebook/react-native/blob/63f8c3dcd6dbc4424d4f519101b06fab9cb4ff76/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java#L1225
It then creates CatalystInstanceImpl: https://github.com/facebook/react-native/blob/63f8c3dcd6dbc4424d4f519101b06fab9cb4ff76/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java#L1460 which, on the cpp side of the object, creates new hermes runtime later: https://github.com/facebook/react-native/blob/9792d5e2d12072629c858ad094375128edc546f4/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/CatalystInstanceImpl.java#L128, then https://github.com/facebook/react-native/blob/9792d5e2d12072629c858ad094375128edc546f4/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/CatalystInstanceImpl.java#L146, then https://github.com/facebook/react-native/blob/9792d5e2d12072629c858ad094375128edc546f4/packages/react-native/ReactAndroid/src/main/jni/react/jni/CatalystInstanceImpl.cpp#L198, then https://github.com/facebook/react-native/blob/9792d5e2d12072629c858ad094375128edc546f4/packages/react-native/ReactCommon/cxxreact/Instance.cpp#L63, then https://github.com/facebook/react-native/blob/9792d5e2d12072629c858ad094375128edc546f4/packages/react-native/ReactCommon/cxxreact/NativeToJsBridge.cpp#L114, then https://github.com/facebook/react-native/blob/9792d5e2d12072629c858ad094375128edc546f4/packages/react-native/ReactCommon/hermes/executor/HermesExecutorFactory.cpp#L201.

This new hermes runtime should never be created, whats more, it does not provide the flags to hermes which are needed, resulting in the crash we see in the App, since queueMicrotask is not available in the default configuration and used in bridgeless mode.
Fixed Issues

$ https://github.com/Expensify/App/issues/48163
PROPOSAL:
Tests

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@allroundexperts hold on with testing

We will most likely just remove the patch https://github.com/Expensify/App/pull/51676


A blob container can be opened by the direct link to one deleted blob container with the same name

Storage Explorer Version: 1.20.0-dev
Build Number: 20210616.2
Branch: main
Platform/OS: Windows 10/ MacOS Big Sur 11.3
Architecture: ia32/x64
How Found: Exploratory testing
Regression From: Not a regression
Bug Descriptions
Copy direct link to one service -> Delete the service -> Open the link from the browser.
The direct link can find and open a service which has the same name as the deleted service in a different storage account.
Steps to Reproduce

Expand one storage account -> Blob Containers.
Right click one blob container -> Click 'Copy Direct Link to Blob Container'.
Then delete the blob container.
Expand another storage account -> Blob Containers.
Create a blob container using the same name of the blob container which is deleted in Step3.
Paste the copied link to browser -> Open the link.
Check there is an info bar indicates that Unable to find resource 'XXX'. It may have been deleted or you may not have access to it.

Expected Experience
There is an info bar.

Actual Experience

There is no info bar.
Able to find and open the blob container under another storage account.

Additional Context
Here is the video:

I checked with 1.19.1 and it does report the error. Maybe this is a regression.

I cannot reproduce this bug on the latest release candidate. Could you save the direct link and share one that can reproduce the bug with us?

@JasonYeMSFT Verified on the latest 1.20.0 branch build. Reproduce.
The direct link comes from the deleted blob container 'donotdelete' under the account 'a0615account'.
When opening the link it will find and open the blob container 'donotdelete' under the account 'alinkyan0617'.
Here is the direct link to repro:
storageexplorer://v=1&accountid=%2Fsubscriptions%2F92be7e56-8a60-427c-a3e3-0ebd54a827a1%2FresourceGroups%2Fcti-kristine%2Fproviders%2FMicrosoft.Storage%2FstorageAccounts%2Fa0615account&subscriptionid=92be7e56-8a60-427c-a3e3-0ebd54a827a1&resourcetype=Azure.BlobContainer&resourcename=donotdelete

I see. The bug will only reproduce if the container is already loaded in the tree.

I did some investigation of the implementation and this seems to be by design. The current implementation has a dedicated code path to search all the service level group nodes available in the tree for the node when the group node in the direct link cannot be found. Let me bring up with the team to see if it still make sense.

Verified on the build main/20211109.2. Fixed.


Harden HAproxy security

Rancher versions: 1.6

The default Rancher LB SSL cipher configuration does not disable
weak 64-bit block ciphers and is thus vulnerable to SWEET32 attack. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2016-2183.

SWEET32 (CVE-2016-2183, CVE-2016-6329)      VULNERABLE, uses 64 bit block ciphers

The default Rancher LB SSL cipher configuration does not prefer AES GCM ciphers over CBC ciphers which should be done in order to mitigate Lucky13 attack. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2013-0169

LUCKY13 (CVE-2013-0169)      VULNERABLE, uses cipher block chaining (CBC) ciphers

The Rancher LB service does not use unique Diffie-Hellman primes for DH key exchanges but instead uses the common primes shipped with the HAProxy binary.

LOGJAM (CVE-2015-4000), experimental      Common prime with 2048 bits detected: haproxy 1.5 builtin, but no DH EXPORT ciphers

Issue 1) and 2) could possibly be addressed by updating Rancher LB SSL config to use one of the ciphersuites maintained by Mozilla: https://wiki.mozilla.org/Security/Server_Side_TLS

I found a handy bit of info here, adding the following to the config removes the SWEET32 vulnerablity on my scans:
global
ssl-default-bind-options no-sslv3 no-tlsv10
ssl-default-bind-ciphers ECDH+AESGCM:DH+AESGCM:ECDH+AES256:DH+AES256:ECDH+AES128:DH+AES:RSA+AESGCM:RSA+AES:!aNULL:!MD5:!DSS
ssl-default-server-options no-sslv3 no-tlsv10
ssl-default-server-ciphers ECDH+AESGCM:DH+AESGCM:ECDH+AES256:DH+AES256:ECDH+AES128:DH+AES:RSA+AESGCM:RSA+AES:!aNULL:!MD5:!DSS
tune.ssl.default-dh-param 2048

-- From https://forums.rancher.com/t/haproxy-ssl-ciphers/6653

Rancher server: v1.6.15-rc6
I was able to test load balancer with HTTPS with:

self signed certificate
real certificate

pr for reference https://github.com/rancher/lb-controller/pull/108


Implementation of SSH KEY generation

Deploy SSH Key setup
Closes https://github.com/portainer/portainer/issues/1752

@rushirajsilvertouch could you rebase the PR on the latest develop branch please? I'm having troubles building this locally for testing.

Closed in favor of #2294


PushNotification.hasPermission() does not work in the browser

Expected Behaviour
PushNotification.hasPermission() should return an object of the form { isEnabled: true } or { isEnabled: false } to make it API-compatible with the other platforms (Android, iOS etc).
Actual Behaviour
PushNotification.hasPermission() returns true unconditionally (not even { isEnabled: true }).
Steps to Reproduce
Run the following code in the browser:
PushNotification.hasPermission(function (result) {
    console.log(result);
})

Platform and Version (eg. Android 5.0 or iOS 9.2.1)
Any desktop browser (tested on Firefox 58 and Chrome 64)
Cordova CLI version and cordova platform version
Cordova 8.0.0
Cordova browser platform 5.0.3
Plugin version
2.1.3
Sample Push Data Payload
Sample Code that illustrates the problem
PushNotification.hasPermission(function (result) {
    console.log(result);
})

Logs taken while reproducing problem
true

Recommendation
I believe that a minimal implementation of the hasPermission() function on the browser platform should at least check whether the notification permission is granted:
hasPermission: function(successCallback, errorCallback) {
        const granted = Notification && Notification.permission === 'granted'
        successCallback({ isEnabled: granted });
},

@ntamas yeah, that is a real good point and you seem to have a handle on how to implement the fix. PR's are always welcome.

Great, I will prepare a PR soon then.

On 2018. Feb 28., at 20:04, Simon MacDonald<EMAIL_ADDRESS>wrote:
@ntamas yeah, that is a real good point and you seem to have a handle on how to implement the fix. PR's are always welcome.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@ntamas this will be out in the next release.

Awesome, thanks a lot!


Karpenter doesn't support new 6th generation instance types with AWS_ENABLE_POD_ENI = true

Version

Karpenter: v0.11.1

Kubernetes: v1.22.9
Expected Behavior
Karpenter should support c6i.*, c6a.*, m6i.*, m6a.* EC2 instance types with AWS_ENABLE_POD_ENI = true.
New 6th gen instances are listed in the supported instances list
Actual Behavior
Karpenter does not support c6i.*, c6a.*, m6i.*, m6a.* EC2 instance types with AWS_ENABLE_POD_ENI=true.
Steps to Reproduce the Problem

Create EKS cluster
Follow Security groups for pods guide
Schedule a pod with security group and any c6i., c6a., m6i., m6a. instance type selector.

Notes
Core of the issue seems to be in the fact that github.com/aws/amazon-vpc-resource-controller-k8s v1.1.0 is used, which doesn't have 6th gen listed with IsTrunkingCompatible: true/BranchInterface > 0, v1.1.3 already has them.
Resource Specs and Logs
Could not schedule pod, incompatible with provisioner "default", no instance type satisfied resources {"cpu":"200m","memory":"256Mi","pods":"1","vpc.amazonaws.com/pod-eni":"1"} and requirements karpenter.sh/capacity-type In [on-demand], karpenter.sh/provisioner-name In [default], node.kubernetes.io/instance-type In [c6i.large], kubernetes.io/arch In [amd64]

Could not schedule pod, incompatible with provisioner "default", no instance type satisfied resources {"cpu":"200m","memory":"256Mi","pods":"1","vpc.amazonaws.com/pod-eni":"1"} and requirements karpenter.sh/provisioner-name In [default], node.kubernetes.io/instance-type In [c6a.large], kubernetes.io/arch In [amd64], karpenter.sh/capacity-type In [on-demand]

Could not schedule pod, incompatible with provisioner "default", no instance type satisfied resources {"cpu":"200m","memory":"256Mi","pods":"1","vpc.amazonaws.com/pod-eni":"1"} and requirements karpenter.sh/capacity-type In [on-demand], node.kubernetes.io/instance-type In [m6a.large], kubernetes.io/arch In [amd64], karpenter.sh/provisioner-name In [default]

The new types are included and we automatically pull the latest version of this file now.


ListOfDeliveryNotes.deliveryNotes.shipmentStatus in version 3.0.0

The same issues also apply to DeliveryNoteById.shipmentStatus
1 All parties might not implement GoodsReceipt. shipmentStatus should be changed to optional as decided at API meeting on 2025-02-28.
2 Current Enumerations

Planned
Departed
Arrived

At API meeting on 2025-02-28 there was a decison to add enumeration Loaded.
In Stora use case the GoodsReceipt will be sent after unloading of the goods, i.e. not when it has arrived.
So enumeration Unloaded should be added.
Should papiNet keep enumeration Arrived or remove it?
If deliveryNoteStatus is Cancelled, what enumeration should then be used for shipmentStatus?
Should papiNet add a new enumeration Cancelled to be used in this case?

We keep the "Arrived" enumeration value.
We add the "Cancelled" enumeration value, which has a different meaning than the "Cancelled" of the deliveryNoteStatus.

Done, see commit 9c746e3.


Adding custom persistence

If I am not mistaken, this project creates a new type of repository (conceptually, even if not extending SRepository, if I am not mistaken), which can be used together with a ProjectRepository (please correct me if I am saying something stupid).
In other words it is a rewriting of a lot of aspects of MPS (for example, I see a module named typesystemIntegration, I suppose this is needed because the modules are not part of the ProjectRepository, right?)
I was thinking that it could be useful to provide the possibilities to store models into a key-value store using custom persistence, because this would permit even to users that are not ready to jump on this new system to start dropping git even when using desktop based MPS, but working with all the sub-systems of MPS that they are familiar with.
I think this could be a path with very limited impedence and helps getting more users looking into this: start using cloud-based model storing as a drop-in addition to file-based storing and then move to web-based model editing.
Does this make any sense to you?

I was thinking that a significant portion of the code could be used to support both the existing CloudRepository and "standard" custom persistence, making possible to benefit from the code in more contexts

I had experimented a bit in the past with custom persistence towards a MongoDB instance. The result (incomplete) meant nothing changed for the user, beside a new option when creating models and the coordinates of the MongoDB server appeared in the .mps/modules.xml file

There is a repository implementation that is completely unrelated to the one in MPS. The integration with MPS is done by synchronizing the model data in both directions. You have to specify a "binding" to tell the synchronizer which models you want to work with in MPS.
The typesystemIntegration module is something unrelated. It is part of MPS and not of modelix.
A custom persistence wouldn't allow realtime collaboration. MPS usually writes to/reads from the persistence when the focused window changes, not when the model changes.

A custom persistence wouldn't allow realtime collaboration. MPS usually writes to/reads from the persistence when the focused window changes, not when the model changes.

Good point! I will close this issue (but I am about to open one about the model server :D)
Thank you for the explanation

One alternative to realtime collaboration is working with locks. Maybe there are some benefits of custom persistence + locks.

Or could someone avoid locks and just get auto-resolved conflicts in the moment the system tries to save?


fix(collapse): fix type definition

Types of changes

[ ] New feature
[ ] Bug fix
[ ] Enhancement
[ ] Component style change
[x] Typescript definition change
[ ] Documentation change
[ ] Coding style change
[ ] Refactoring
[ ] Test cases
[ ] Continuous integration
[ ] Breaking change
[ ] Others

Background and context

Solution

How is the change tested?

Changelog

Component
Changelog(CN)
Changelog(EN)
Related issues

collapse
修复CollapseItem类型声明
fix CollapseItem type definiton
Close #1719

Checklist:

[ ] Test suite passes (npm run test)
[ ] Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
[ ] Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others
should be submitted to main branch)

Other information

@erhsilence 感谢 PR ~

如果是a-collapse-item在循环这种情景下， v-for指定的key 和组件属性key冲突了，组件属性key就获取不到了


Can't get DMR for STR-DN1040

Mine doesn't seem to listen on 52323 at all. NMAP on it got me the following:
80/tcp    open  http
1083/tcp  open  ansoft-lm-1
1900/tcp  open  upnp
10100/tcp open  itap-ddtp
33335/tcp open  unknown
50001/tcp open  unknown
60151/tcp open  unknown

I've tried all of those ports for the DMR, and no luck on any of them. The port 80 Sony information page says the firmware version is "1.08 / fv=s9327.1092.0", if that helps.
Any ideas?

It would be great if you could post your device type

It would be great if you could post your device type

It's the STR-DN1040 AV-Receiver.

So, I finally managed to get it to register. Turns out it's very picky about the device name. "MediaRemote:11-22-33-44-55-66" worked at least. Once that works, I can now at least manually get the remote command list and I'm now doing some very hacky things with IRCC (as the receiver doesn't have any of the input buttons in the SOAP interface, so I'm doing things like "Home", "Confirm", "Right", "Confirm" to change to a particular input).

You might be be interested in issue #45. Although it's not implemented yet it might be worth watching this issue.
As soon as it's closed we should be able o provide a proper source selection for all devices

I am also having this same issue (in concert with alexmohr/media_player.sony) with the STR-DN840 A/V Receiver. The DLNA descriptor for this is also description.xml on port 8080

@RyanMorash  did you try using the device name mentioned above?

@palfrey @RyanMorash  Do you need any further support on this?


SwiftmailerServiceProvider overwrites default $app['swiftmailer.options'] on instantiation

Swiftmailer's register() does not allow it to set the options.  It just overrides the app's options that may have been set previously.  You can see this on line 26 of the SwiftmailerServiceProvider.php file

I don't have any issue with swiftmailer options. Can you paste a code sample ?

I am using @igorw config provider.  I have examples but am headed out of the country shortly.  I can provide an example when back.
But if you extend the slim application and overload the constructor you might be able to replicate (i call the parent right after that).
I overload the constructor to have my class register the providers i need.  First Igor's config, then swiftmailer.
I found that $app['swiftmailer.options'] = array (); was causing the assignment issues.
Sorry for any readability issues here.  I am on the phone.

Sorry.  Apparently an rtfm moment
Sorry to waste time!
https://github.com/silexphp/Silex/blob/1.3/doc/providers.rst

please show code examples

I will by the end of today.  Found out where the inconsistency was.
On Aug 12, 2015 11:26 AM, "Kamil Samigullin"<EMAIL_ADDRESS>wrote:

please show code examples
—
Reply to this email directly or view it on GitHub
https://github.com/silexphp/Silex/issues/1176#issuecomment-130362204.

Hey @kamilsk - I found out this issue a bit later playing around with Igor's config service provider.  If you already have $app['swiftmailer.options'], like you would using the Doctrine service provider, it will ignore them.
With this commit it will be able to allow it.
Test the issue with the following code:
// The issue lies here

$app['swiftmailer.options'] = array('host'=>'your-host-name-here');
$app->register(new Silex\Provider\SwiftmailerServiceProvider());
var_dump($app['swiftmailer.options']); // This will have 'host' as 'localhost' as that is the default

Looking at the Doctrine service provider, you can see that they allow defaults to be set before the provider is instantiated.
Note: I don't think there would be any BC breaks due to the fact that most people would of had to configure the provider after loading it.
If all looks good I will submit the PR.

Your example is not a "true way", IMO. If you use that provider as specified in the documentation, then everything is working fine.
See
https://github.com/silexphp/Silex/blob/1.3/src/Silex/Provider/SwiftmailerServiceProvider.php#L53-L60
https://github.com/silexphp/Silex/blob/1.3/src/Silex/Application.php#L169-L180
http://silex.sensiolabs.org/doc/providers/swiftmailer.html
And example below
$app->register(new Silex\Provider\SwiftmailerServiceProvider(), [
    'swiftmailer.options' => [
        'host' => 'host',
        'port' => '25',
        'username' => 'username',
        'password' => 'password',
        'encryption' => null,
        'auth_mode' => null
    ]
]);

What do you think?

@cgsmith your issue is that you are supposed to customize parameters after registering the provider. Otherwise the parameter defined in the provider will win

Closing this one for the reasons explained by @stof. By the way, all providers work this way.

@fabpot @stof I do not understand a couple of things then.
For example: why does the doctrine provider do the opposite of how the providers are said work? Is this a bug in the doctrine provider?
I am just trying to understand Silex a bit better and contribute in anyway.  Thank you!
Doctrine Provider and SwiftMailer example:
$app['db.options'] = [
    "driver" => "pdo_mysql",
    "host" => "my.local",
    "dbname" => "vse",
    "user" => "some-user",
    "password"=> "12345"
];
$app['swiftmailer.options'] = [
    'host'=>'your-host-name-here'
];
$app->register(new Silex\Provider\DoctrineServiceProvider());
$app->register(new Silex\Provider\SwiftmailerServiceProvider());
var_dump($app['swiftmailer.options']); // properties set to defaults, would expect to be similar to doctrine
var_dump($app['db.options']); // shows properties unmodified, this is how I would expect it to work

@cgsmith, good point

@cgsmith this is because the DoctrineServiceProvider does not define this parameter at all. It defines db.default_options

@stof obvously but that proves that "By the way, all providers work this way." isn't actually true and it is inconsistent right now.

Hi all, please provide feedback regarding the PR.  I feel it is important to provide a consistent experience for the developer and this provider was a "gotcha" for me when I started learning Silex.  Other providers allowed the application's options to be set before hand while SwiftMailer didn't.
It led me down a chase to see that the provider was overriding the values.  The PR is backwards compatible and will provide this unified experience and allow the developer to institute there own paradigm while programming.

+1 on this from me.


[SPARK-41297] [CONNECT] [PYTHON] Support String Expressions in filter.

What changes were proposed in this pull request?
This patch extends the functionality of the DataFrame in Spark Connect by support passing string based SQL expressions to the filter. The expressions are passed as is to the server during evaluation. If the expression is not boolean an Analysis error is thrown.
spark.range(100).filter("id < 10").collect()

Why are the changes needed?
Compatibility
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT

python linter failed

Fixed the linter issue

Can one of the admins verify this patch?


Add-DbaAgReplica + New-DbaAvailabilityGroup - Added parameter EndpointUrl

Type of Change

[x] Bug fix (non-breaking change, fixes #6786, fixes #5859 )
[x] New feature (non-breaking change, adds functionality, fixes # )
[ ] Breaking change (effects multiple commands or functionality, fixes # )
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose
Especially on docker, but also on complex network designs it may be necessary to use custom endpoint URLs for the replicas instead of using the algorithm of Get-DbaEndpoint.
Approach
I added a new parameter on Add-DbaAgReplica and New-DbaAvailabilityGroup.
Commands to test
Follow these instructions: https://dbatools.io/docker/
Only change the line with New-DbaAvailabilityGroup to:
New-DbaAvailabilityGroup @params -EndpointUrl 'TCP://dockersql1:5022', 'TCP://dockersql2:5023' -Verbose

Test the health of replicas and database with:
Get-DbaAgReplica -SqlInstance $instance[0] | Format-Table
Get-DbaAgDatabase -SqlInstance $instance | Format-Table

Output
AUSFÜHRLICH: Ausführen des Vorgangs "Setting up availability group named test-ag and adding primary replica" für das Ziel "localhost".
AUSFÜHRLICH: [12:48:05][Get-DbaEndpoint] Getting endpoint hadr_endpoint on GALLOPER
AUSFÜHRLICH: Ausführen des Vorgangs "Adding replica to availability group named test-ag" für das Ziel "localhost,14333".
AUSFÜHRLICH: [12:48:05][Get-DbaEndpoint] Getting endpoint hadr_endpoint on localhost,14333
AUSFÜHRLICH: Ausführen des Vorgangs "New-DbaAvailabilityGroup" für das Ziel "Joining localhost,14333 to test-ag".
AUSFÜHRLICH: Ausführen des Vorgangs "Seeding mode is automatic. Adding CreateAnyDatabase permissions to availability group." für das Ziel "GALLOPER".
AUSFÜHRLICH: Ausführen des Vorgangs "Seeding mode is automatic. Adding CreateAnyDatabase permissions to availability group." für das Ziel "localhost,14333".
AUSFÜHRLICH: [12:48:07][Backup-DbaDatabase] Setting Default timestampformat
AUSFÜHRLICH: [12:48:07][Backup-DbaDatabase] 1 database to backup
AUSFÜHRLICH: [12:48:07][Backup-DbaDatabase] Backup database [pubs]
AUSFÜHRLICH: [12:48:07][Backup-DbaDatabase] Creating full backup
AUSFÜHRLICH: [12:48:07][Backup-DbaDatabase] Building file name
AUSFÜHRLICH: [12:48:07][Backup-DbaDatabase] Building backup path
AUSFÜHRLICH: [12:48:07][Backup-DbaDatabase] Devices added
AUSFÜHRLICH: [12:48:08][Get-DbaDbBackupHistory] Processing pubs
AUSFÜHRLICH: [12:48:08][Get-DbaDbBackupHistory] Executing sql query on [GALLOPER].
AUSFÜHRLICH: [12:48:08][Get-DbaDbBackupHistory] Processing as grouped output.
AUSFÜHRLICH: [12:48:08][Get-DbaDbBackupHistory] 1 result-groups found.
AUSFÜHRLICH: [12:48:12][Add-DbaAgDatabase] Error joining database to availability group | Cannot join database 'pubs' to availability group 'test-ag'.  The database has already joined the availabili
ty group.  This is an informational message.  No user action is required.

ComputerName               : localhost
InstanceName               : MSSQLSERVER
SqlInstance                : dockersql1
LocalReplicaRole           : Primary
AvailabilityGroup          : test-ag
PrimaryReplica             : dockersql1
ClusterType                : None
DtcSupportEnabled          : False
AutomatedBackupPreference  : Secondary
AvailabilityReplicas       : {dockersql1, dockersql2}
AvailabilityDatabases      : {pubs}
AvailabilityGroupListeners : {}

ComputerName InstanceName SqlInstance AvailabilityGroup Name            Role ConnectionState RollupSynchronizationState  AvailabilityMode BackupPriority EndpointUrl           SessionTimeout Failove
                                                                                rMode
------------ ------------ ----------- ----------------- ----            ---- --------------- --------------------------  ---------------- -------------- -----------           -------------- -------
localhost    MSSQLSERVER  dockersql1  test-ag           dockersql1   Primary       Connected               Synchronized SynchronousCommit             50 TCP://dockersql1:5022             10  Manual
localhost    MSSQLSERVER  dockersql1  test-ag           dockersql2 Secondary       Connected               Synchronized SynchronousCommit             50 TCP://dockersql2:5023             10  Manual

ComputerName InstanceName SqlInstance AvailabilityGroup Replica   Name SynchronizationState IsFailoverReady IsJoined IsSuspended
------------ ------------ ----------- ----------------- -------   ---- -------------------- --------------- -------- -----------
localhost    MSSQLSERVER  dockersql1  test-ag           localhost pubs         Synchronized            True     True       False
localhost    MSSQLSERVER  dockersql2  test-ag           localhost pubs         Synchronized            True     True       False

This will also address this feature request: #5859 (New-DbaAvailabilityGroup - add option to force IPs in endpoint urls)

I looked into this and after seeing EndPointUrl as a modifiable option in SSMS, agree with the addition so long as the EndPointUrl is automatically determiend by default, as we discussed.
This does not solve the docker problem in a beautiful manner, however. After a bit of digging, I found that our change to ComputerName in Connect-DbaInstance for Linux machines is what broke it. Making one change on line 839 to remove the accommodation for Linux fixed it. Problem is, I'd like to keep the pretty hostname for Linux and I can't see where the ComputerName is referenced in a meaningful way in Add-DbaAgReplica.
Going to keep looking into it.

The ability to add multiple instances has been reinstated and now also works with the EndpointUrl parameter.
Additionally, the parameter ReadonlyRoutingList has been added, which is required for a reasonable use of ReadonlyRoutingConnectionUrl.

Thanks so much for the updates! I updated a test and will merge once they pass 👍

Okay this is driving me crazy, sorry for the multiple commits, let me take another stab at this. Once it passes, we'll be set.

Unrelated test failure, we're set! 💯


K9s Include new Amd 64 version

In PR https://github.com/derailed/k9s/pull/1910 the x86_64 in the release was changed to amd64
so that :
k9s_Windows_x86_64.tar.gz
changed into
k9s_Windows_amd64.tar.gz
Description
This will check for both and select the correct version
This will also close https://github.com/chocolatey-community/chocolatey-packages/issues/1999
Motivation and Context
It is really annoying that it is still not up to date to the latest version available
Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Migrated package (a package has been migrated from another repository)

Checklist:

[X] My code follows the code style of this repository.
[ ] My change requires a change to documentation (this usually means the notes in the description of a package).
[ ] I have updated the documentation accordingly (this usually means the notes in the description of a package).
[ ] I have updated the package description and it is less than 4000 characters.
[X] All files are up to date with the latest Contributing Guidelines
[ ] The added/modified package passed install/uninstall in the chocolatey test environment.
[X] The changes only affect a single package (not including meta package).

:x: Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

:white_check_mark: Package verification completed without issues. PR is now pending human review

:white_check_mark: Package verification completed without issues. PR is now pending human review

Let me know if you are missing anything else!

:white_check_mark: Package verification completed without issues. PR is now pending human review


+print-reconnect-cookie option doesn't appear to do anything

Describe the bug
https://www.mankier.com/1/xfreerdp#+print-reconnect-cookie seems to imply that there is a +print-reconnect-cookie option that will print the base64 reconnect cookie after connecting.
However, in my testing, it is not printed.  Furthermore, the rdp_read_server_auto_reconnect_cookie() function is present in /libfreerdp/core/info.c , but I can't see any evidence that it's called from anywhere.
To Reproduce
Steps to reproduce the behavior:

Run xfreerdp with the +print-reconnect-cookie option
Look for the reconnect cookie printed out

Expected behavior
Reconnect cookie printed in base64
** Application details

Version of FreeRDP
FreeRDP version 2.0.0-dev5 (4a6b843f1)

I'm pretty sure xfreerdp doesn't use the reconnect cookie for reconnection, but reconnects using a while loop that calls freerdp_connect x times (the configured max reconnection attempts in settings).

@wdormann Please don´t reference external sites, freerdp.com, this github project and the documentation printed by xfreerdp and others are the one and only relevant and up to date documentation.
As for your question: rdp_recv_logon_info_extended is the place you´re looking for...
Might simply be your server configuration not sending that specific message.
The message is sent in rdp_write_extended_info_packet which is part of rdp_send_client_info that is sent in CONNECTION_STATE_MCS_CHANNEL_JOIN


'_lock' is not defined on exit when using python 3

When using pyspotify 2 (newest develop at current time) and python 3, I get this error when my script exits:
Exception ignored in: <function GcWeakrefs.__init__.<locals>.remove at 0x7f9c06ea4b70>
Traceback (most recent call last):
  File "/home/trygve/dev/pyspotify/venv3/lib/python3.4/site-packages/cffi-0.8.2-py3.4-linux-x86_64.egg/cffi/gc_weakref.py", line 12, in remove
  File "/home/trygve/dev/pyspotify/spotify/__init__.py", line 57, in wrapper
NameError: name '_lock' is not defined

It happens consistently, every time. The only code needed to make it happen is this:
import spotify
session = spotify.Session()

I'm running Python 3.4.0. When running Python 2.7.6, I don't get this error.

I started looking closer at this issue a while back. IIRC, I managed to reduce how often this happened, but not to get rid of it totally.
As a sign of how late in the interpreter shutdown this exception is raised, the following change does not hide the error as you would expect, but cause a NameError: name 'NameError' is not defined exception!
diff --git a/spotify/__init__.py b/spotify/__init__.py
index 857bc84..1327d46 100644
--- a/spotify/__init__.py
+++ b/spotify/__init__.py
@@ -56,8 +56,11 @@ def serialized(f):

     @functools.wraps(f)
     def wrapper(*args, **kwargs):
-        with _lock:
-            return f(*args, **kwargs)
+        try:
+            with _lock:
+                return f(*args, **kwargs)
+        except NameError:
+            pass
     if not hasattr(wrapper, '__wrapped__'):
         # Workaround for Python < 3.2
         wrapper.__wrapped__ = f

This Python bug looks related: http://bugs.python.org/msg195244

This change effectively hides the error, but I really don't want to do this:
diff --git a/spotify/__init__.py b/spotify/__init__.py
index 857bc84..1327d46 100644
--- a/spotify/__init__.py
+++ b/spotify/__init__.py
@@ -56,8 +56,11 @@ def serialized(f):

     @functools.wraps(f)
     def wrapper(*args, **kwargs):
-        with _lock:
-            return f(*args, **kwargs)
+        try:
+            with _lock:
+                return f(*args, **kwargs)
+        except:
+            pass
     if not hasattr(wrapper, '__wrapped__'):
         # Workaround for Python < 3.2
         wrapper.__wrapped__ = f

I can't reproduce this bug with cffi 1.0 development snapshot.
cffi 1.0 final will hopefully be released early next week. pyspotify will require cffi 1.0 as soon as it is available.


GroupBy Not working as expected

I am trying to achive the output like this
Parent 1
----    Child 1
Parent 2
----  Child 1
Parent 3
Parent 4
In the itemlist i am providing
itemList = [
{ "id": 1, "itemName": "Child 1", "category": "Parent 1" },
{ "id": 2, "itemName": "Child 1", "category": "Parent 2" },
{ "id":3, "category": "Parent 3"},
{ "id":4, "category":"Parent 4"},
]
i am getting output like this
Parent 1
child 1
Parent 2
child 1
Parent 3

Parent 4

Can you let me how to achive the output as below
Parent 1
---   Child 1
Parent 2
--- Child 1
Parent 3
Parent 4

@skonetigari It doesn't make sense to have a parent without a child and vice versa. So i think this would not be supported as of now. Hence closing. Thank you.


Update bootstrap environments

We need clang to be installed with most recent ponyc as it uses
clang as the default linker.
Also, update to Ubuntu 20.04 as we no longer support 18.04

@Theodus I can't build the ubuntu image locally at the moment. I get an error that appears to be regional in nature as when the ponyc release docker image was built earlier, it had no problems.
Can you give it a try?
My error:
"E: Release file for http://security.ubuntu.com/ubuntu/dists/focal-security/InRelease is not valid yet (invalid for another 2h 22min 57s). Updates for this repository will not be applied.
E: Release file for http://archive.ubuntu.com/ubuntu/dists/focal-updates/InRelease is not valid yet (invalid for another 2h 23min 0s). Updates for this repository will not be applied."

Also the libz error on Fedora, that is odd. I wonder what that requirement is coming from.
@Theodus do you have time to check the fedora error and see if ponyc requires libz.so to run (i hope not!) or if it is an odd unsatisfied dependency we are missing for building ponyup in fedora environments?

I got the ubuntu image building working. I needed to restart my computer because... of course I did.

The fedora error is because of this with the glibc builds (note this is on ubuntu 18.04)
./ponyc: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by ./ponyc)
linux-vdso.so.1 (0x00007ffe5416c000)
libatomic.so.1 => /usr/lib/x86_64-linux-gnu/libatomic.so.1 (0x00007fe17dca9000)
libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007fe17daa5000)
libz.so.1 => /lib/x86_64-linux-gnu/libz.so.1 (0x00007fe17d888000)
librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007fe17d680000)
libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007fe17d461000)
libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fe17d0c3000)
libz3.so.4 => not found
libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007fe17ceab000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fe17caba000)
/lib64/ld-linux-x86-64.so.2 (0x00007fe17deb1000)

@Theodus are you ok with turning off Fedora bootstrap while we discuss "the glibc issue" at sync this week? If yes, I will update this and get your sign-off so we can move forward with some other PRs.

@SeanTAllen That sounds good

See https://github.com/ponylang/ponyc/issues/3537


put intro before install as @julieraines suggested in #308 and #309

See http://openaps.readthedocs.io/en/dev/docs/openaps-guide/intro.html to see how they flow.

@julieraines can you verify that this accomplishes what you wanted?

There, that should make a lot more sense for beginners who are getting stuck on the Guide section: instead this provides a link over to Phase 0 of the walkthrough (setting up a Raspberry Pi) and then a link back to the Guide when they're more ready.
Please review and 👍  if you think this is ready to merge to master.

This looks good to me!  👍


Jekyll 4.0 support ?

Including this gem in my Gemfile forces the Jekyll dependency to use the older v3.8.6. Any chance it can be updated to work with Jekyll 4? Thanks

@brockfanning Can we get a release since support for this has been merged in?

@SUPERCILEX Just pushed up version 0.0.2. Thanks for everyone's patience and help!

Woohoo, thanks!

if i understand correctly, this should be closed.

Sounds good, closing now.


Looking for the best fork of Goose to use in production

Hey everyone - I've been trying to determine which fork of the original Goose project is the most maintained, preferably one that's already used in production. Would you advise using this fork or will the original become the standard since it looks like it's being maintained again. Thanks!

@katejefferson I'm in the same boat. Why do you say the original is being maintained again? I didn't notice anything to suggest that after 15 minutes of casual browsing on bitbucket.


Updated Creating a Plugin Section Example

Modified Creating a Plugin example for below changes.

Modified compile hook to emit, as compile is a sync hook and it doesn't have tapAsync method.

Thanks!


Logs for unregistering/registering delegated resources are not reflected in this script

I followed that instrcution and it seems that the script always returns: "No new delegation changes." despite I registered/unregistered resources few times.
This would require further investigation but:

the script searches tenant activity logs (here: https://docs.microsoft.com/en-us/rest/api/monitor/tenantactivitylogs/list) whereas the actual logs are kept under regular activity logs (here: https://docs.microsoft.com/en-us/rest/api/monitor/activitylogs/list)
Tenant activity logs as per article "API does not retrieve the logs at the individual subscription of the tenant but only surfaces the logs that were generated at the tenant level." so searching tenant activity logs does not return desired output.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dc8af3c1-6fe8-1746-fb3c-306d03e52cdd
Version Independent ID: 79fb4c4f-78a9-7e95-0548-508ad287c6c4
Content: Monitor delegation changes in your managing tenant - Azure Lighthouse
Content Source: articles/lighthouse/how-to/monitor-delegation-changes.md
Service: lighthouse
GitHub Login: @JnHs
Microsoft Alias: jenhayes

@zagruby The script is meant to pick up activity over the last 1 day (first parameter in the script). Can you confirm that this duration will pick up your activity? If yes, can you also please confirm what actions you performed when you reference " I registered/unregistered resources few times " ? Did you delegate a new subscription / resource group to an existing offer? Or completely deploy a new regDefinition and regAssignment ?  This script is meant to pick up specific operations from the tenant-level activity log - and sounds like you have the right access to read. So don't think there would be concerns there.

@zagruby Thank you for your query, our team will further look into it and get back to you at the earliest.

Hello @zagruby , as we haven't heard back, we will close this issue but please don't hesitate to respond and we will gladly continue the discussion.

@archunz and @femsulu  I have been trying different parameters in the script to be sure we have picked the correct time frame. So I tried -10 as well, this should pick up logs for the past 10 days.
$GetDate = (Get-Date).AddDays((-1))
Usually the logs in portal are visible under 'Activity log' after around 2 minutes, when I was searching for "register" and "unregister".
With reference to:

" I registered/unregistered resources few times "
I delegated a new subscription (and later on resource group as well) to the existing offer as well as I onboarded new "customer" - my msdn subscription. In both cases the script was returning 'No new delegation'

Later on I deleted the delegation, reonboarded the customer,delegated resource groups a few times and deleted the delegation. Each time the same result.
When checking script the variable $showOperations.operationName.value holds the following values:
Microsoft.ManagementPartner/partners/write
Microsoft.Portal/consoles/keepAlive/action
Internal.Telemetry/collect/action
Microsoft.Portal/consoles/write
Microsoft.Authorization/elevateAccess/action
Microsoft.Management/getEntities/action
Microsoft.Portal/consoles/delete
but when I modify the script to look not in the Tenant logs but Activity Logs so  instead:
Uri = "https://management.azure.com/providers/microsoft.insights/eventtypes/management/values?api-version=2015-04-01&$filter=eventTimestamp ge '$($dateFormatForQuery)'"`
I am using:
Uri = "https://management.azure.com/subscriptions/{subscriptionId}/providers/microsoft.insights/eventtypes/management/values?api-version=2015-04-01&$filter=eventTimestamp ge '$($dateFormatForQuery)'"`
I am seeing new delegations, I guess it will not work in case of deleted delegation as the script will not have access to deleted subcription logs.
So I was thinking that the logs thatI am looking for are not kept on tenant level but on subscription level and searching those logs from tenant level does not return anything as the search does not go deeper.

Thanks for your detailed response, @zagruby.
Based on your response, I think you are trying to run the query in the customer or Managed tenant. Is that correct ?
The capability documented here allows the MSP or managing tenant to query their own (i.e. MSP or managing tenant) tenant level activity logs and capture the below action - "Microsoft.Resources/tenants/register/action" . This should cover both the create, update and delete delegation actions.
I see you have reached out to us, the product team, via your CSA as well. Happy to connect and clarify further.

@archunz No, this is not correct, I am running the report in the MSP tenant, so the tenant which is managing other's tenants.
I was running the script thru service principal account with proper role and scope. (I was trying contributor role as well after it failed with Monitoring Reader.)

Thanks @zagruby for confirming that you are running the query from the MSP tenant.
I think you had the right authorizations as you were able to read the tenant level activity log and retrieve other actions per your previous comment.
Let us connect further via the conversation setup by CSA to  debug further.


Vercel_Frontend_Deployment

This is a beginner-friendly guide that outlines the essentials of Vercel Frontend Deployment, covering its introduction, benefits, deployment steps, and advanced features to empower new developers in effectively using Vercel for their web projects.

Looks great! Maybe a comparative analysis with other deployment platforms can help users understand why Vercel might be the best choice for their specific needs. That and I think all all is good.

Looks great! Maybe a comparative analysis with other deployment platforms can help users understand why Vercel might be the best choice for their specific needs. That and I think all all is good.

Thank you! I will add that part.


Cyanea incorrectly puts the background buttons on a dialog in accentColor

They were:
textColor = accent
BackgroundColor = transparent

I have an issue where i get buttons styled like that instead of TextButton styled ones when I have my theme descend from Themes.Cyanea.NoActionBar (dark or light), and when inspecting the layout it seems it is applying android:style/ThemeOverlay.Material.Dialog.Alert() instead of my.bundle.identifier.dev:style/ThemeOverlay.MaterialComponents.Dialog.Alert() (and this latter seems to have been applied twice..?). Any tips regarding this?

Similarly, the text color of DialogButtons are incorrectly colored with colorPrimary, when they are typically colored with colorAccent. The AndroidX library versions for ListPreference, PreferenceDialogFragments, and other misc AlertDialogs have this same behavior

If someone posts simple sample code it would be much appreciated.

In my scenario, I'm using the ThemePickerActivity and your provided JSON themes per the documentation:
 {
    "theme_name": "Reddit",
    "base_theme": "DARK",
    "primary": "#FF000000",
    "primary_dark": "#FF000000",
    "primary_light": "#FF262626",
    "accent": "#FFFF3D00",
    "accent_dark": "#FFD83300",
    "accent_light": "#FFFF5A26",
    "background": "#FF212121",
    "background_dark": "#FF1C1C1C",
    "background_light": "#FF424242"
  }

Colors DialogButtons with the above-defined "primary" or "primary_dark", when it should be colored with "accent". My dialogs use the parent style from Theme.Cyanea.Light. I've tried your "Reddit" Cyanea Theme and my own, and both cases do the same.
Affected components:

AlertDialog.Builder
Dialogs from Preferences (ListPreference, EditTextPreference, etc.)
All dialogs from what I've seen

To Reproduce: (In Java, sorry)
This is an AlertDialog.Builder from 'androidx.appcompat.app.AlertDialog'
      final AlertDialog.Builder sampleDialog = new AlertDialog.Builder(mContext);
      sampleDialog.setMessage("Sample Dialog")
                     .setNegativeButton("Close", (thisDialog, id) -> thisDialog.dismiss());
                    });
      sampleDialog.show();

Or, you can create an EditTextPreference on a PreferenceScreen and the same occurs.
On a related note, CheckBoxPreferences have their checkboxes colored by the some variant of the background color, when they should also be colorAccent.

Any updates on this?

Using this library also having the same issue
https://github.com/wdullaer/MaterialDateTimePicker

Is there a way to fix it?

Has there bene anyway to fix this?


Transaction history filter shows items not in filter sometimes

Not sure what causes this yet, but happens if you change filters in Transaction History. You'll get items that don't apply to your filter. Sometimes it's one and others it's more (i.e. a long list of abandons when filtering on supports).
Thanks to @eggplantbren for spotting this one also.

Should no longer happen with latest changes.


HEdtree method inherited from Node?

NodeHEdtree <- R6Class("NodeHEdtree",
                       inherit = Node,
                       public = list(
                         AddChild = function(x) {
                           super$AddChild(x)
                         },
                         AddChildNode = function(x) {
                           super$AddChildNode(x)
                         }
                       )
)
myt <- NodeHEdtree$new('mytree')
ma <- myt$AddChild('Option A')
mb <- myt$AddChild('Option B')
ma1 <- ma$AddChild('Option A1')

Could be a good idea because could name things closer to the decision tree/health economics field and leave out Node methods that don't make sense in this context?


work around for us-east-2 region and eu-west-1

0 day fix for us-east-2 and other regions outside of us-east-1. Us-east-1 lookup code was causing other regions to not list Azs correctly.

aos-ci-test

Hey, I checked out this branch, but when running ose-on-aws.py with --region=us-east-2 I get the following error:
ERROR! Syntax Error while loading YAML.

The error appears to have been in '/home/centos/openshift-ansible-contrib/reference-architecture/aws-ansible/playbooks/roles/cloudformation-infra/tasks/main.yaml': line 105, column 9, but may
be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:

  when: create_vpc == "yes" and region != "us-east-1"
    tags:
        ^ here

just patched it for you. Sorry about that
On Mon, Mar 6, 2017 at 4:05 PM, Gihad Murad<EMAIL_ADDRESS>wrote:

@gihad commented on this pull request.
In reference-architecture/aws-ansible/playbooks/roles/
cloudformation-infra/tasks/main.yaml
https://github.com/openshift/openshift-ansible-contrib/pull/212#discussion_r104522110
:

@@ -48,9 +101,9 @@
NodeDockerVolType: gp2
S3BucketName: "{{ s3_bucket_name }}"
S3User: "{{ s3_username }}"

when: create_vpc == "yes" and region != "us-east-1"

Should this line be bellow move 2 lines bellow?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/openshift/openshift-ansible-contrib/pull/212#pullrequestreview-25363411,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADoslJj2dsd7A1mCCBXp0ewRYYu586xaks5rjHUYgaJpZM4LqNfh
.

Thanks @cooktheryan.
Hitting another issue that might be related to this:
TASK [cloudformation-infra : Create Greenfield Infrastructure] *****************
fatal: [localhost]: FAILED! => {"changed": false, "failed": true, "msg": "Parameters: [SubnetAvailabilityZones] do not exist in the template"}

I see that SubnetAvailabilityZones was removed from reference-architecture/aws-ansible/playbooks/roles/cloudformation-infra/files/greenfield.json

@gihad gimme a few. Gotta dive back into the code its been a while

@gihad
TASK [cloudformation-infra : Create Greenfield Infrastructure in us-east-1 ignore VPC classic] ***
skipping: [localhost]

TASK [cloudformation-infra : Create Greenfield Infrastructure] *****************
changed: [localhost]

TASK [cloudformation-infra : Create Brownfield Infrastructure] *****************
skipping: [localhost]

TASK [cloudformation-infra : Create Brownfield Infrastructure with existing bastion] ***
skipping: [localhost]

TASK [cloudformation-infra : Add App Node] *************************************
skipping: [localhost]

TASK [cloudformation-infra : Add Infra Node] ***********************************
skipping: [localhost]

PLAY RECAP *********************************************************************

Should be good to go now

@cooktheryan Thanks for all the help so far. CI build is passing now.
I've hit a problem very far down now, and it might not be related to this. It looks like all resources were created in AWS properly but the script failed here:
TASK [setup] *******************************************************************
fatal: [ose-master03.myuken.com]: UNREACHABLE! => {"changed": false, "msg": "Failed to connect to the host via ssh: ssh: connect to host ose-master03.domain.com port 22: Connection timed out\r\n", "unreachable": true}

PLAY RECAP *********************************************************************
localhost                  : ok=9    changed=5    unreachable=0    failed=0
ose-master03.domain.com    : ok=0    changed=0    unreachable=1    failed=0

I can SSH into the bastion server via SSH and from there ose-master03.domain.com is reachable via SSH. From the server I'm where I'm running ansible I can't SSH into ose-master03.domain.com tho.
Does the error above mean that the machine were ansible is running on can't reach ose-master03.domain.com or the bastion server?

Have you setup the .ssh/config file?
On Mar 6, 2017 5:53 PM, "Gihad Murad"<EMAIL_ADDRESS>wrote:

@cooktheryan https://github.com/cooktheryan Thanks for all the help so
far. CI build is passing now.
I've hit a problem very far down now, and it might not be related to this.
It looks like all resources were created in AWS properly but the script
failed here:
TASK [setup] *******************************************************************
fatal: [ose-master03.myuken.com]: UNREACHABLE! => {"changed": false, "msg": "Failed to connect to the host via ssh: ssh: connect to host ose-master03.domain.com port 22: Connection timed out\r\n", "unreachable": true}
PLAY RECAP *********************************************************************
localhost                  : ok=9    changed=5    unreachable=0    failed=0ose-master03.domain.com    : ok=0    changed=0    unreachable=1    failed=0
I can SSH into the bastion server via SSH and from there
ose-master03.domain.com is reachable via SSH. From the server I'm where
I'm running ansible I can't SSH into ose-master03.domain.com tho.
Does the error above mean that the machine were ansible is running on
can't reach ose-master03.domain.com or the bastion server?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openshift/openshift-ansible-contrib/pull/212#issuecomment-284561111,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADoslOHY8ObsY-ID1eTeTI9oSDbWHdAtks5rjI5ZgaJpZM4LqNfh
.

Yes, but I had a typo. Thanks 👍

@cooktheryan I've hit another issue after the cloudformation step.
TASK [prerequisites : Install the required rpms] *******************************
failed: [ose-master01.domain.com] (item=[u'NetworkManager', u'atomic-openshift-excluder', u'atomic-openshift-docker-excluder']) => {"changed": false, "failed": true, "item": ["NetworkManager", "atomic-openshift-excluder", "atomic-openshift-docker-excluder"], "msg": "No package matching 'atomic-openshift-excluder' found available, installed or updated", "rc": 126, "results": ["No package matching 'atomic-openshift-excluder' found available, installed or updated"]}

I'm using AMI ami-6a2d760f which is equivalent to ami-6d1c2007 in us-east-1.
My arguments to ose-on-aws are the following:
./ose-on-aws.py --keypair=mykey --public-hosted-zone=domain.com --deployment-type=origin --ami=ami-6a2d760f --github-client-secret=secret --github-organization=myorg --github-client-id=secret --region=us-east-2 --master-instance-type=m4.2xlarge --node-instance-type=m4.2xlarge --app-instance-type=m4.2xlarge
I will keep debugging further here.

are you using origin or openshift enterprise?
On Tue, Mar 7, 2017 at 11:17 AM, Gihad Murad<EMAIL_ADDRESS>wrote:

@cooktheryan https://github.com/cooktheryan I've hit another issue
after the cloudformation step.
TASK [prerequisites : Install the required rpms] *******************************
failed: [ose-master01.domain.com] (item=[u'NetworkManager', u'atomic-openshift-excluder', u'atomic-openshift-docker-excluder']) => {"changed": false, "failed": true, "item": ["NetworkManager", "atomic-openshift-excluder", "atomic-openshift-docker-excluder"], "msg": "No package matching 'atomic-openshift-excluder' found available, installed or updated", "rc": 126, "results": ["No package matching 'atomic-openshift-excluder' found available, installed or updated"]}
I'm using AMI ami-6a2d760f which is equivalent to ami-6d1c2007 in
us-east-1.
My arguments to ose-on-aws are the following:
./ose-on-aws.py --keypair=mykey --public-hosted-zone=domain.com
--deployment-type=origin --ami=ami-6a2d760f --github-client-secret=secret
--github-organization=myorg --github-client-id=secret --region=us-east-2
--master-instance-type=m4.2xlarge --node-instance-type=m4.2xlarge
--app-instance-type=m4.2xlarge
I will keep debugging further here.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openshift/openshift-ansible-contrib/pull/212#issuecomment-284770046,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADoslEMmUvWSXVmiEGjYRbdbr_JhFjdwks5rjYMlgaJpZM4LqNfh
.

@cooktheryan origin

I'm going to stand up an origin cluster so that I can attempt to work through this better

@gihad should be better now.

@cooktheryan Just following up: Yesterday I was able to bring the reference architecture up on aws region us-east-2 with no issues, some of the relevant parameters to ose-on-aws.py:
--deployment-type=origin --ami=ami-6a2d760f --region=us-east-2
Thanks!

Are there any plans on getting the fixes here that allowed deployment in us-east-2 into master of the main repo? I have no rush on this, just wondering for the future.

Will be resolved in #315


Enums with numbers

Is it possible to use an enum with numbers as the keys? My dates are currently stored as:
{
  month: 01,
  year: 2015
}

and I would like to be able to do:
var Months = t.enums({ 1: 'January', 2: 'February', ... });
var Years = t.enums({ 2015: '2015', 2014: '2014' });
var Date = t.struct({ month: Months, year: Years });

The only solution I could come up with currently is to transform the numbers to string when receiving them from the server and then back to numbers before sending them back. Not idea.
Thanks!

Is it possible to use an enum with numbers as the keys

The current implementation uses a hash to store the enums, since in JavaScript
hash keys are strings (or automatically converted to strings) I'd say no.
If you don't strictly need an enum, you could define Month and Year as subtypes, e.g.
// I'll define `Integer` to show you a "composable approach"
// but feel free to define just 2 predicates for Month and Year...

var Integer = t.subtype(t.Num, function (n) {
  return n % 1 === 0;
});

var Month = t.subtype(Integer, function (n) {
  return n >= 1 && n <= 12;
});

var Year = t.subtype(Integer, function (n) {
  return n >= 2014 && n <= 2015;
});

Thanks @gcanti. I think that is a much cleaner way to setup the model, but is there an easy way to get that to display as a select element containing all possible values?

Oh sorry, this is the tcomb-form lib not tcomb :). Obviously you want to show months and years as a select! In that case I'm afraid there is not clean solution besides what you're already doing.

Could I use a transformer? Also, on an unrelated note, what is the best way to get to JSON from form.getValue()?

Could I use a transformer

Unfortunately transformers are only for textboxes at the moment, otherwise you could do something like this:
var Month = t.subtype(Integer, function (n) {
  return n % 1 === 0 && n >= 1 && n <= 12;
});

var DisplayMonth = t.enums({ 1: 'January', 2: 'February' });
// build options by hand
DisplayMonth.options = Object.keys(DisplayMonth.meta.map).map(function (value) {
  return {value: value, text: DisplayMonth.meta.map[value]};
});

var Person = t.struct({
  month: Month
});

var Form = t.form.create(Person, {
  fields: {
    month: {
      // override factory
      factory: t.form.select,
      // custom options
      options: DisplayMonth.options,
      // number <-> string
      transformer: {
        function format(v) { return String(v); }
        function parse(v) { return parseInt(v, 10); }
      }
    }
  }
});

But it's super verbose. At this point it's better to write a reusable custom template or a custom factory.

what is the best way to get to JSON from form.getValue()

I'm afraid I don't understand: form.getValue() gives you an instance of your model. Now if your model is only composed by JSON compatible types (null, string, number, boolean), you already have a JSON.


Fix typo to scalegen ProposalVrfMessage

A typo in scalegen generation comment causes make generate fail.

bors merge

bors merge


Is it possible to optionally disable Picker button based on a condition?

How can I modify the Native Base Picker code to disable the button based on conditions?

@VanessaChu You can try that yourself
NativeBase Picker is implementation of React Native Picker

This issue should not have been closed since this does not work on iOS.
@VanessaChu According to the RN docs, you can disable the input for their picker by passing an enabled flag, which works just fine on android.
This however does not work on iOS and there is not currently a way to disable it.

@ekimlinger Your statement sounds invalid
As said earlier

NativeBase Picker is implementation of React Native Picker

Since React Native supports this only for Android, we cannot help in adding this to iOS

Released with 2.5.0


Add SetDefault() to IHasDefaultValue

I'm almost thinking these interfaces shouldn't exist anymore. As it is, this'll give the ability to SetDefault() on IBindables...

Went unnessary after I made some changes to the pr this was intended for (#2367)


Swift Tutorial - Adding An Image Crashes Application

When I try add an image on both iPhone/Simulator, the application crashes with the following message:
'NSInternalInconsistencyException', reason: 'Invalid update: invalid number of rows in section 0.  The number of rows contained in an existing section after the update (1) must be equal to the number of rows contained in that section before the update (4), plus or minus the number of rows inserted or deleted from that section (1 inserted, 0 deleted) and plus or minus the number of rows moved into or out of that section (0 moved in, 0 moved out).'

+1

@iulukaya Could you have a look at the ios issues (or re-assign) when you have a chance?

Fixed this one.


Can't select ollama models

Bug Report
Description
Bug Summary:
The dropdown to select models in the application is not functioning as expected.
Steps to Reproduce:

Access the application.
Navigate to the dropdown to select models.
Attempt to select a model.

Expected Behavior:
When selecting a model from the dropdown, it should activate or display relevant information.
Actual Behavior:
Selecting a model from the dropdown does not trigger any action or display relevant information.
Environment

Operating System: Manjaro
Browser (if applicable): Firefox 124.0.1

Reproduction Details
Confirmation:

[x] I have read and followed all the instructions provided in the README.md.
[x] I am on the latest version of both Open WebUI and Ollama.
[ ] I have included the browser console logs.
[x] I have included the Docker container logs.

Logs and Screenshots
Browser Console Logs:
[Include relevant browser console logs, if applicable]
Docker Container Logs:
here is the most relevant logs
open-webui  | Traceback (most recent call last):
open-webui  |   File "/usr/local/lib/python3.11/site-packages/uvicorn/protocols/http/httptools_impl.py", line 411, in run_asgi
open-webui  |     result = await app(  # type: ignore[func-returns-value]
open-webui  |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
open-webui  |   File "/usr/local/lib/python3.11/site-packages/uvicorn/middleware/proxy_headers.py", line 69, in __call__
open-webui  |     return await self.app(scope, receive, send)
open-webui  |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
open-webui  |   File "/usr/local/lib/python3.11/site-packages/fastapi/applications.py", line 1054, in __call__
open-webui  |     await super().__call__(scope, receive, send)
open-webui  |   File "/usr/local/lib/python3.11/site-packages/starlette/applications.py", line 123, in __call__
open-webui  |     await self.middleware_stack(scope, receive, send)
open-webui  |   File "/usr/local/lib/python3.11/site-packages/starlette/middleware/errors.py", line 186, in __call__
open-webui  |     raise exc
open-webui  |   File "/usr/local/lib/python3.11/site-packages/starlette/middleware/errors.py", line 164, in __call__
open-webui  |     await self.app(scope, receive, _send)
open-webui  |   File "/usr/local/lib/python3.11/site-packages/starlette/middleware/base.py", line 189, in __call__
open-webui  |     with collapse_excgroups():
open-webui  |   File "/usr/local/lib/python3.11/contextlib.py", line 158, in __exit__
open-webui  |     self.gen.throw(typ, value, traceback)
open-webui  |   File "/usr/local/lib/python3.11/site-packages/starlette/_utils.py", line 93, in collapse_excgroups
open-webui  |     raise exc
open-webui  |   File "/usr/local/lib/python3.11/site-packages/starlette/responses.py", line 261, in wrap
open-webui  |     await func()
open-webui  |   File "/usr/local/lib/python3.11/site-packages/starlette/middleware/base.py", line 217, in stream_response
open-webui  |     return await super().stream_response(send)
open-webui  |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
open-webui  |   File "/usr/local/lib/python3.11/site-packages/starlette/responses.py", line 250, in stream_response
open-webui  |     async for chunk in self.body_iterator:
open-webui  |   File "/usr/local/lib/python3.11/site-packages/starlette/middleware/base.py", line 181, in body_stream
open-webui  |     raise app_exc
open-webui  |   File "/usr/local/lib/python3.11/site-packages/starlette/middleware/base.py", line 151, in coro
open-webui  |     await self.app(scope, receive_or_disconnect, send_no_error)
open-webui  |   File "/usr/local/lib/python3.11/site-packages/starlette/middleware/cors.py", line 85, in __call__
open-webui  |     await self.app(scope, receive, send)
open-webui  |   File "/usr/local/lib/python3.11/site-packages/starlette/middleware/base.py", line 189, in __call__
open-webui  |     with collapse_excgroups():
open-webui  |   File "/usr/local/lib/python3.11/contextlib.py", line 158, in __exit__
open-webui  |     self.gen.throw(typ, value, traceback)
open-webui  |   File "/usr/local/lib/python3.11/site-packages/starlette/_utils.py", line 93, in collapse_excgroups
open-webui  |     raise exc
open-webui  |   File "/usr/local/lib/python3.11/site-packages/starlette/responses.py", line 261, in wrap
open-webui  |     await func()
open-webui  |   File "/usr/local/lib/python3.11/site-packages/starlette/middleware/base.py", line 217, in stream_response
open-webui  |     return await super().stream_response(send)
open-webui  |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
open-webui  |   File "/usr/local/lib/python3.11/site-packages/starlette/responses.py", line 250, in stream_response
open-webui  |     async for chunk in self.body_iterator:
open-webui  |   File "/usr/local/lib/python3.11/site-packages/starlette/middleware/base.py", line 181, in body_stream
open-webui  |     raise app_exc
open-webui  |   File "/usr/local/lib/python3.11/site-packages/starlette/middleware/base.py", line 151, in coro
open-webui  |     await self.app(scope, receive_or_disconnect, send_no_error)
open-webui  |   File "/usr/local/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 65, in __call__
open-webui  |     await wrap_app_handling_exceptions(self.app, conn)(scope, receive, send)
open-webui  |   File "/usr/local/lib/python3.11/site-packages/starlette/_exception_handler.py", line 64, in wrapped_app
open-webui  |     raise exc
open-webui  |   File "/usr/local/lib/python3.11/site-packages/starlette/_exception_handler.py", line 53, in wrapped_app
open-webui  |     await app(scope, receive, sender)
open-webui  |   File "/usr/local/lib/python3.11/site-packages/starlette/routing.py", line 756, in __call__
open-webui  |     await self.middleware_stack(scope, receive, send)
open-webui  |   File "/usr/local/lib/python3.11/site-packages/starlette/routing.py", line 776, in app
open-webui  |     await route.handle(scope, receive, send)
open-webui  |   File "/usr/local/lib/python3.11/site-packages/starlette/routing.py", line 485, in handle
open-webui  |     await self.app(scope, receive, send)
open-webui  |   File "/usr/local/lib/python3.11/site-packages/fastapi/applications.py", line 1054, in __call__
open-webui  |     await super().__call__(scope, receive, send)
open-webui  |   File "/usr/local/lib/python3.11/site-packages/starlette/applications.py", line 123, in __call__
open-webui  |     await self.middleware_stack(scope, receive, send)
open-webui  |   File "/usr/local/lib/python3.11/site-packages/starlette/middleware/errors.py", line 186, in __call__
open-webui  |     raise exc
open-webui  |   File "/usr/local/lib/python3.11/site-packages/starlette/middleware/errors.py", line 164, in __call__
open-webui  |     await self.app(scope, receive, _send)
open-webui  |   File "/usr/local/lib/python3.11/site-packages/starlette/middleware/base.py", line 189, in __call__
open-webui  |     with collapse_excgroups():
open-webui  |   File "/usr/local/lib/python3.11/contextlib.py", line 158, in __exit__
open-webui  |     self.gen.throw(typ, value, traceback)
open-webui  |   File "/usr/local/lib/python3.11/site-packages/starlette/_utils.py", line 93, in collapse_excgroups
open-webui  |     raise exc
open-webui  |   File "/usr/local/lib/python3.11/site-packages/starlette/middleware/base.py", line 191, in __call__
open-webui  |     response = await self.dispatch_func(request, call_next)
open-webui  |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
open-webui  |   File "/app/backend/apps/ollama/main.py", line 76, in check_url
open-webui  |     await get_all_models()
open-webui  |   File "/app/backend/apps/ollama/main.py", line 158, in get_all_models
open-webui  |     app.state.MODELS = {model["model"]: model for model in models["models"]}
open-webui  |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
open-webui  |   File "/app/backend/apps/ollama/main.py", line 158, in <dictcomp>
open-webui  |     app.state.MODELS = {model["model"]: model for model in models["models"]}
open-webui  |                         ~~~~~^^^^^^^^^
open-webui  | KeyError: 'model'
open-webui  | INFO:apps.openai.main:get_all_models()

Screenshots (if applicable):
[Attach any relevant screenshots to help illustrate the issue]
Installation Method
Installed ollama using package manager then set up ollama as service and to listen on port 11434.
After that I cobbled the following docker compose file
version: '3.8'

services:
  open-webui:
    container_name: open-webui
    image: ghcr.io/open-webui/open-webui:main
    network_mode: 'host'
    ports:
      - "3000:8080"
    extra_hosts:
      - 'host.docker.internal:host-gateway'
    volumes:
      - open-webui:/app/backend/data
    environment:
      - OLLAMA_BASE_URL=http://<IP_ADDRESS>:11434
    restart: always

volumes:
  open-webui:

and ran docker compose up
Additional Information

The application is running on Docker (image: ghcr.io/open-webui/open-webui:main).
Ollama version: 0.1.17 is installed externally on my computer.
It seems to be a development error since the API documentation for /api/tags (https://github.com/ollama/ollama/blob/v0.1.32/docs/api.md#list-local-models) shows that there is no 'model' key.
Even after fixing the current issue (by changing model["model"] to model["name"]), the list of models shows up but cannot be selected (clicking them does not trigger any action).

* Ollama version: 0.1.17 is installed externally on my computer.

That is an ancient version of Ollama is there a good reason you're using it? I'm fairly certain that there are vulnerabilities like this. I'm not sure that we're compatible with it anymore.  See this commit which deprecates name from many types and adds model everywhere: ollama/ollama@1f5b7ff976460ad5305ab31998554944825f1f5f


*: rename repo from pingcap/ticdc to pingcap/tiflow

What problem does this PR solve?
Finish step-6 in https://github.com/pingcap/tiflow/issues/3749 for release-5.3
What is changed and how it works?

Run the following script

sed -i "s/github.com\/pingcap\/ticdc/github.com\/pingcap\/tiflow/g" $(find . -type f|grep -vE "bin/|.git")
sed -i "s/pingcap\/ticdc/pingcap\/tiflow/g" $(find . -type f|grep -vE "bin/|.git")
make fmt

Change project name from ticdc to tiflow in Makefile

Check List
Tests

Unit test
Integration test

Release note
None

/run-all-tests

/run-kafka-integration-test

/lgtm

/merge


StateIsActiveGuard not triggering on delay complete

It seems that I cannot get a parallel state transition to fire using a StateIsActiveGuard when the state it's tracking only uses a delay to trigger the next state.
Here I've set up a test state chart using the parallel node.

Compound Chart A is using delays to transition back and forth between A1 and A2. Compound Chart B is using StateIsActiveGuards to follow Chart A. Example of "To B2" transition below:

However, this does not work!
It seems to only be the delay that does not work, because if i use a script to fire an event to change A1 to A2, "To B2" will trigger the StateIsActiveGuard as expected. I would expect that "To B2" should trigger whenever A2 is active whether that is from a delay or event trigger.
Please help! I am loving this plugin and it's my favourite way to build state machines in any game engine.

A guard does not trigger transitions it is merely a check that is done when a transition would trigger. The guard can then prevent this transition from happening when it evaluates to false (hence the name "guard").  These actions will potentiall trigger transitions:

a state is entered (can trigger automatic transitions of that state)
an event is sent to the state chart (can trigger all transitions of active states in the chart)
an expression property is set (can trigger automatic transitions of active states in the chart)

Could you give me a bit more details about the use case you have? Maybe this can be modeled differently.

Ok thank you for further clarification! I guess I'm still a bit confused as to why when a state's delay is not included in that list since isn't a state moving from one to the other using a delay still count as a state being entered?
This is how I had it set up to give you a bit more context for what I was expecting:

I was hoping that the Move state would always be active when the Controllable and Stunned states were active, and the Hold state would be active when CoyoteTime was active. Basically, CoyoteTime is a grace period given to the player when a collision is detected to let the player make a split second last adjustment to avoid the collision, and was trying to use a delay transition to count down that time for me. If the player doesn't make an input, the delay ends and the Stunned state is triggered. If they do, an event fires and the player is Controllable again.
Hopefully that helps give you some extra context. I could definitely be over complicating things and have since simplified it to just one compound state and calling the movement via a function instead.

Thanks a lot for taking the time to write up a clarification!

I guess I'm still a bit confused as to why a transition delay is not included in that list since isn't a state moving from one to the other using a delay still count as a state being entered?

A delay delays the actual execution of the transition. So while the delay is running the transition is pending.  But you will still be in the old state until the delay has fully elapsed. During that time other transitions will still be evaluated and could potentially supersede the pending transition. For example lets assume this setup:

The state chart starts by entering A  which will evaluate all transitions leaving A.   There is an automatic transition going to B which is delayed by 5 seconds and another one going to C when  some_event is sent. This is similar to your Coyote Time setup. So the automatic transition will be triggered and is marked as pending. But we are still in A until the transition actually runs. If during the delay some_event is sent,  the transition going to C will be triggered and we leave A. This will abort the pending transition to B.  So during this whole operation a StateIsActive guard checking for B being active would return false because we never entered B because the transition was only pending but never executed.
I think in your particular case you could indeed remodel this and do away with the parallel state as it isn't really parallel. Parallel states are intended to model aspects that are mostly independent of each other but in your case the Move and Hold states basically just translate to "if i am in  Stunned then Hold is active, otherwise Move is active".  So one way to model this could be:

Then then you can just use the callbacks of the Moving and Holding states and you don't need any guards or custom code.  This is because if a child state is active, its parent state is also active, so this setup exactly expresses   "if i am in  Stunned then Hold is active, otherwise Move is active". I hope this helps!

A delay delays the actual execution of the transition. So while the delay is running the transition is pending. But you will still be in the old state until the delay has fully elapsed.

Yep, this all makes sense to me, and tracks with my understanding of how the states work.

So during this whole operation a StateIsActive guard checking for B being active would return false because we never entered B because the transition was only pending but never executed.

But this still doesn't really clarify why a StateIsActive guard in a parallel state checking for B being active would continue to not return true if the delay transition to B completes, but does when B is transitioned to with an event transition. I feel like StateIsActive should not care how a parallel state was transitioned to, only if that state is active as the guard is described.
Anyway, I won't push further on this topic unless you'd like further details. I might be misunderstanding how this works or explaining it badly, but I love your suggestion on the new setup and it makes way more sense! I'll implement something like that moving forward. Thanks!

So am I getting this right, you have a situation where B is active and the StateIsActive guard for B still returns false and prevents the transition? That would indeed be a bug. Would you happen to have a small example project that reproduces this?

Well I checked the example and it's pretty much what I described. State changes need to be triggered by something, a guard can only prevent a state change but not trigger it. So if you send an event by pressing 1 or 2, then is event is evaluated against all transitions and hence the B-branch transitions as there is a trigger. But if A1 auto-transitions to A2 (or vice versa) there is nothing that would trigger anything in the B-branch, so any guard in the B branch will not even be evaluated. For that to work, the state chart would need to re-evaluate all automatic transitions whenever a state change somewhere occurs. That is  probably doable but I'm not quite sure if this would have unwanted side effects or prevent certain use cases.

Ah ok! Gotcha. Thank you for clarifying! Since refactoring the state machine as per your amazing suggestion, I probably won't be using it like this for a long time anyway. Thanks for your patience and support! 🙏


Add GrassBag.

I'm very unsure of how to do this, and had trouble running the ModInstaller
at all in development. But I hope this works.

Thank you! I made some bug fixes since I opened this and forgot to update this PR, I'll open up another to point at the most recent one.


connectivity test: Change allow-all-egress policy to allow all egress

Change allow-all-egress policy to allow traffic to all ports on all (supported) protocols to all destinations. This helps unmask bugs that woudl be otherwise masked by the default deny when nothing in the policy map matches.
This policy adds proto-only entries for TCP, UDP, and SCTP, wildcarding both the destination identity and the destination port.
Merging may need to be postponed until the surfaced bugs are fixed.

May need to do the same for always-allow-ingress, haven't looked at it yet.


Clarify that RP2350 gets its unique id from OTP

Fixes #1915

Looks good, but I wonder if this ought to use the \if mechanism that can be seen in e.g. https://github.com/raspberrypi/pico-sdk/pull/1945/files ?

yes, looks like that might be a good idea.

One small quibble but otherwise looks great! :+1: