[Utility] Refactor and rename some existing functions related to handling transactions

Description

Summary generated by Reviewpad on 19 May 23 01:12 UTC
This pull request contains various changes to improve the modularity, readability, and extensibility of the codebase. It includes modifications to different packages, such as rpc/utils.go, utility/unit_of_work, utility/types, and shared/core/types. Among the changes are the addition of new functions, updates to existing functions, and modifications to unit tests. The changes aim to enhance the abstraction of business logic, improve the validation and handling of transactions, and provide better error handling. The details of the changes are described in the individual file summaries.

Issue
NA
Type of change
Please mark the relevant option(s):

[ ] New feature, functionality or library
[ ] Bug fix
[x] Code health or cleanup
[ ] Major breaking change
[ ] Documentation
[ ] Other

List of changes

Avoid using the utilityUnitOfWork in the rpc module because we do not want to have it run utility's business logic
Added GetIndexedTransaction to the UtilityModule interface to be able to retrieve an indexed transaction without running the underlying business logic
Renamed HydrateIdxTx to HandleTransaction in the UtilityUnitOfWorkinterface so its more descriptive of what the function does
Moved over all the business logic related to getting "signer candidates" into its own file for readability purposes
Renamed anteHandleMessage to basicValidateTransaction
Split the logic in basicValidateTransaction into multiple smaller functions for readability and so adding new business logic will be clearer

TODO_IN_THIS_COMMIT:

[ ] Add an E2E test that leverages txProtoBytesToRPCIdxTxs in the RPC module
[ ] Add unit tests for GetIndexedTransaction in the utility module
[ ] Add a few unit tests for basicValidateTransaction

Testing

[x] make develop_test; if any code changes were made
[x] make test_e2e on k8s LocalNet; if any code changes were made
[ ] e2e-devnet-test passes tests on DevNet; if any code was changed
[ ] Docker Compose LocalNet; if any major functionality was changed or introduced
[ ] k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
[ ] I have tested my changes using the available tooling
[x] I have updated the corresponding CHANGELOG

If Applicable Checklist

[ ] I have updated the corresponding README(s); local and/or global
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added, or updated, mermaid.js diagrams in the corresponding README(s)
[ ] I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@h5law @dylanlott @adshmh I marked this as ready for review because all the core business logic changes I intend to have in this PR is complete. This touches some code that all of us are working on, so I want to get this in and avoid more complex merge conflicts in the future.
I left a few TODO_IN_THIS_COMMIT items in the GitHub description regarding tests I need to add and will focus on those tomorrow. Just wanted to start getting 👀 at this in parallel and give all of you a heads-up of the change.

@h5law @dylanlott @adshmh I haven't added an E2E test that leverages txProtoBytesToRPCIdxTxs and will do that tomorrow. Might also leave it for a follow-up PR depending on how long the review on this one takes.
Otherwise, this is ready to go.


feat(plugin): support mjs output for plugin

Summary

add .mjs ouptut for every plugin.
change plugin buildType to bundle

Related Issue

Checklist

[ ] I have added changeset via pnpm run change.
[ ] I have updated the documentation.
[ ] I have added tests to cover my changes.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.fupeng.antik seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


channel_not_found error from users.admin.invite endpoint

I got a channel_not_found error until I used the channel ID, rather than the channel name, in the list of channels a user should be auto-enrolled. I'm not sure if that's because it was a private channel, so am raising an issue rather than submitting a PR. Others might benefiting from being aware that they may need to use the ID, not the channel name.

Thanks for raising the issue. The channel name worked before, so that might actually be a change to the API. Would be great if you could make a pull request to reflect the change.

The correctly specifies that only IDs work.


Sketch out data management UI improvements

From https://github.com/hotosm/tech/issues/98
Look to improve data management functions for forms and submitted data. Need to consider:

sort, filter, export by day and user
update, delete forms
consider some features that other ODK-based tools do

@smit1678 was work on this starting this week? Can we still add the ability to "archive" submissions (based on certain filer criteria)? Or is improving performance when there's a large number of submissions also on the list?

I believe everything is done


Missing FUTURES hook for pp data API change

Relating to changes introduced in #1926.  I think a FUTURES hook should have been in-place due to the API change that resulted.
I think it would be a good idea to do this before tagging a release.

I propose that this issue be added to the v1.10 milestone.  I mentioned it some time ago on #1926 but I don't think it got noticed.

I am wary of introducing another future switch for this behaviour
The #1926 change is adding metadata and removing a bug which could exhibit itself with certain input data sets.
This is not an API change.
I would need more justification for how this is a major behavioural change before I would support a  future option.
This level of change, subtly reinterpreting metadata on load, is a common pattern for changes and enhancements and does not fall into the future switch category, I feel.

Our code was dependent on the fact that there was a time coordinate when there is now not one (month_number instead).  Iris has a public UI not just for function/class/module calls but also of how data is represented (perhaps UI is not the right term, but the principle/risk is the same).
I think this could be high risk with iris end users who rightly assume they still have a time coordinate but are not aware of the subtle change that has taken place here.

To expand on @cpelley's comment, we had workaround code that specifically checked for invalid years on a cube prior to saving, which then "fixed" the year prior to saving.  Year 0 to mean any year is a common convention in ancillary files, so we've hit this problem a lot.  The #1926 change broke our check for whether a file was a year < 1 or not - so was, to us, an unexpected behaviour change that we then had to account for.
It's great that you're trying to handle data with a year of 0 in a better way (and your fix is better than our workaround one), but I'd suggest it's only courteous that when you change behaviour in a way that may impact downstream code, you give people fair warning.

It's great that you're trying to handle data with a year of 0 in a better way (and your fix is better than our workaround one), but I'd suggest it's only courteous that when you change behaviour in a way that may impact downstream code, you give people fair warning.

We have attempted to give fair warning, by providing a what's new entry and (soon) by providing a release candidate.
The addition of a 'future' flag for a particular case is a value judgement based on the size of the change.  In this case, my view is that the change is not large enough to warrant the complication of a future flag.  The removal of the erroneous time coordinate is more in the realms of a bug fix than anything else.

Thanks for that @marqh.  You're right, it is a value judgement of whether or not something justifies the use of a FUTURE flag, and ultimately it's your call, so I'm not going to push this any further.  I've explained our position, and you've listened, so I'm content.
I suspect our view may be different from yours because we deal with ancillaries so have hit this problem so often: to us, year zero is a problem for the vast majority of files we see, while to you, it's a tiny fraction.  Different perspective, leading to different opinions.


Update documentation on README.md

Hello,
It looks like the README.md needs a quick update:
outputFormat
Type: String Default: YYYY-MM-DD
This is the format in which the date is displayed in the input box.
After messing around with it for a bit it appears that the correct argument is simply 'format'
{{date-picker date=dateArg format="MM-DD-YYYY" valueFormat="YYYY-MM-DD"}}

I had trouble getting this addon to work until I read the source and saw that outputFormat is never used.
format however is specified and works fine so I'm confused by your previous comment

Thanks. I had a closer look and you're right. Clearly I was confused somewhere. I've fixed the docs. Thanks all for your help

Awesome, and thanks for the nice add-on. I'm making good use of it :)


docs: explain why NewAuthorizeSession uses gob

https://github.com/ory-am/fosite/pull/1#discussion_r48776389

This issue has been superceeded by a superior architecture


problem with generate CSS style for child component

hello i want set Style to sub child but css not generate correctly
my code
    return Style.it(`.ant-table-tbody tr td {color: red}`,

);

and generated css

the problem is here .s1287016723 color: red}

Hi @samankhademi , thanks for opening this! Technically CSS does not require a semi-colon for the last property-value in a CSS declaration block, looks like the parser does not account for this corner case.
Add a semicolon to the end of your css key-value pair and will work. Like so:
.foo { color: red; }
Hope to have a fix up soon.

d6e2880f63c0b40e3ea7e17eb55d204929de31f0

yes!!!!!!!!!!!!!!! thank you man


compatibility with haros update

Runnning the model analysis with the docker:
docker run -p 4000:80 -ti haros:latest /haros_runner.sh https://github.com/aremazeilles/dummy_package.git dummy_package dummy_node

I get the following error:
[100%] Built target dummy_node
Traceback (most recent call last):
  File "/ros_model_extractor.py", line 207, in <module>
    main()
  File "/ros_model_extractor.py", line 202, in main
    if extractor.launch():
  File "/ros_model_extractor.py", line 78, in launch
    self.extract_primitives(node, parser.global_scope, analysis, rosmodel)
  File "/ros_model_extractor.py", line 91, in extract_primitives
    name = analysis._extract_topic(call)
AttributeError: 'NodeExtractor' object has no attribute '_extract_topic'

I am not sure when was updated the pip package of haros, but in the current version of file extractor.py, the requested method is now in classes RospyExtractor and RoscppExtractor

closed, see https://github.com/ipa320/ros-model/issues/105#issuecomment-636055729 for further details.
Code also moved to ros-model-cloud, new issue -> https://github.com/ipa320/ros-model-cloud/issues/35


Postgres SSL mode doesn't pass credentials correctly

Hi,
My application is running CockroachDB v22.2.
Below files are fine. (I did a small test using psycopg3 raw inside the same project)

ca.crt
client.root.crt
client.root.key

I'm trying to use this connection string:
postgres://root@node1:26257/defaultdb%3Fsslmode%3Dverify-ca%26sslrootcert%3D%2Fusr%2Fsrc%2Fcerts%2Fca.crt%26sslcert%3D%2Fusr%2Fsrc%2Fcerts%2Fclient.root.crt%26sslkey%3D%2Fusr%2Fsrc%2Fcerts%2Fclient.root.key
I can see the SanicMayimExtension opening the following:
Opening <PostgresPool postgres://root:...@node1:26257/defaultdb%3Fsslmode%3Dverify-ca%26sslrootcert%3D%2Fusr%2Fsrc%2Fcerts%2Fca.crt%26sslcert%3D%2Fusr%2Fsrc%2Fcerts%2Fclient.root.crt%26sslkey%3D%2Fusr%2Fsrc%2Fcerts%2Fclient.root.key>
Then during application runtime the SQL server (CockroachDB) is returning this.
error connecting in 'pool-1': connection failed: ERROR:  password authentication failed for user root
I've had to escape the '/' characters as the base/interface implementation assumes the default DSN but doesn't account for connections like above.
Furthermore, there's no mapping between the urlparse query parameters back to the main connection.
So, psycopg3 is compatible with the format above however Sanic + Mayim extension breaks the connection parameters in transit.
Any known workarounds so far? Is there a way to pass the raw connection in for the moment?
If you can give me some pointers I could possibly give it a go myself - not that I have much experience in this space.

Hmm... This is good to know. If you wouldn't mind, I would be happy if you could submit a PR for this.
In the meantime, you could try something like this:
from psycopg_pool import AsyncConnectionPool
from mayim.sql.postgres.interface import PostgresPool
from mayim import Mayim

# Manually create this either with connection params or DSN
# We will override the connection in a minute though...
pool = PostgresPool(...)

# Override the default pool with your own
pool._pool = = AsyncConnectionPool(...)

# Pass to Mayim
Mayim(pool=pool, ...)


Add alan flower

@castrojo can we add the Ok to test label?

@cjyabraham please merge when you have a chance, thanks!


Error occurred during the fetch of repository 'souffle' with BAZEL@HEAD

https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/3332#018acfac-62a0-468d-8583-1eb93585739e
Platform : Ubuntu
Logs:
ERROR: An error occurred during the fetch of repository 'souffle':
   Traceback (most recent call last):
	File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/e3a55cec1570d06656e66c4ad74b3af0/external/bazel_tools/tools/build_defs/repo/http.bzl", line 150, column 10, in _http_archive_impl
		patch(ctx, auth = auth)
	File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/e3a55cec1570d06656e66c4ad74b3af0/external/bazel_tools/tools/build_defs/repo/utils.bzl", line 174, column 22, in patch
		ctx.patch(patchfile, strip)
Error in patch: Error applying patch /var/lib/buildkite-agent/builds/bk-docker-6x83/bazel-downstream-projects/kythe/third_party/souffle_filesystem.patch: in patch applied to /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/e3a55cec1570d06656e66c4ad74b3af0/external/souffle/src/include/souffle/utility/FileUtil.h: could not apply patch due to CONTENT_DOES_NOT_MATCH_TARGET
(04:11:37) ERROR: /var/lib/buildkite-agent/builds/bk-docker-6x83/bazel-downstream-projects/kythe/WORKSPACE:63:19: fetching http_archive rule //external:souffle: Traceback (most recent call last):
	File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/e3a55cec1570d06656e66c4ad74b3af0/external/bazel_tools/tools/build_defs/repo/http.bzl", line 150, column 10, in _http_archive_impl
		patch(ctx, auth = auth)
	File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/e3a55cec1570d06656e66c4ad74b3af0/external/bazel_tools/tools/build_defs/repo/utils.bzl", line 174, column 22, in patch
		ctx.patch(patchfile, strip)
Error in patch: Error applying patch /var/lib/buildkite-agent/builds/bk-docker-6x83/bazel-downstream-projects/kythe/third_party/souffle_filesystem.patch: in patch applied to /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/e3a55cec1570d06656e66c4ad74b3af0/external/souffle/src/include/souffle/utility/FileUtil.h: could not apply patch due to CONTENT_DOES_NOT_MATCH_TARGET

Steps:

git clone -v https://github.com/kythe/kythe.git
git reset 3a8d7b9f660b565152a27b799ecf083148a57c1b --hard
export USE_BAZEL_VERSION=ea4ab7d8e696f48253fd172fcfbd37661e4710d5
sudo apt update && sudo apt -y install bison flex uuid-dev asciidoc graphviz source-highlight
bazel build //kythe/...

CC Greenteam @Wyverald

That seems an awful lot like a bug in that particular Bazel version.  The patches apply cleanly locally, so I have no good way of investigating this.

@zrlk Any Update on the above issue ?

This is not repeatable using patch and seems a lot like a bazel bug.  There's not really anything we can do about it. The patch was generated directly from the source files Bazel is complaining about  so CONTENT_DOES_NOT_MATCH_TARGET is nonsensical.

I'll take a look

It seems to be an issue in the applyFuzz function, I guess we can switch to applyTo without fuzz matching.

Should be fixed by https://github.com/bazelbuild/bazel/commit/555d7e51c980d27c7499dadffcedc3d741a9b269

Please close; this is fixed


Pathfinding Visualizer and Sorting Visualizer

These projects are completely based on the implementation of 2 types of algorithm that is :
Pathfinding Visualizer
This contains all types of algorithm like Dijkshitra,A*,Swarm,BFS,DFS etc the purpose of this project is to create a playful interface to help understand the concepts of DSA better with the help of HTML,CSS,Javascript and React JS.

Sorting Visualizer
This contains all types of algorithm like Merge sort,heap sort,bubble sort etcthe purpose of this project is to create a playful interface to help understand the concepts of DSA better with the help of HTML,CSS,Javascript and React JS.

Please assign this issue to me.
@TusharKesarwani

Create a fresh issue after 1st June


Add stego ctf tools: exiftool, steghide, binwalk, foremost

When i play ctfs i usually require theses tools to solve stego challenges:
exiftool , steghide, binwalk, foremost

Thanks for your PR.


added initial flexclone test case

Updated Doc with changes -> v1.1
A couple of tasks updated: Typos
Added ONTAP-41 test case series for demonstrating flexclones with NFS client
Updated linux revert to remove test case 41s
Result: a run of 41-* creates 2 mount points, one a flexclone of the origin volume
an ls -alR displays a testfile in the origin exists in the clone, and a newop only exists in the flexclone

I have a couple of meetings, today & tomorrow. There may be minor changes. Otherwise, the demo is ready. Happy to review if you wish to discuss or think of changes.


A select function similar to soups.

Is your feature request related to a problem? Please describe.
It's great to be able to run find and then find within the initial result, but it seems more readable to be able to find based on CSS selectors.
Describe the solution you'd like
selector = '.foo img.bar'
soup.select(selector) # this would return any img item with the class "bar" inside of an object with the class "foo"

@kjaymiller thanks for your request! It's a nice idea, and one that I've toyed with... However, I'm hesitant to add CSS selectors at this moment because they're not exactly intuitive/user-friendly for those who don't know front-end (the bulk of gazpacho users right now). And they wouldn't provide all that much more over the existing find method. That said, if CSS selectors keep coming up perhaps we can we revisit this in the future. But for now I'm going to close this.

I came here to request CSS selector support too - every scraper I've written in the past decade has worked using CSS selectors and I honestly can't imagine scraping without them.
I wrote the first library that added selector support to BeautifulSoup (before it was a built-in feature) - the implementation wasn't too complicated, you're welcome to borrow from it if it looks useful: https://github.com/simonw/soupselect

Super slick! A non-negotiable for me is that gazpacho remain 0 dependency. But it's cool to see such a clean pure python way of implementing selectors.

My hesitation in adding selectors is that I think the overlap between people who know them and Python Developers/Data Scientists/Data Engineers is smaller than we realize. I've been scraping for like 4 years now, and I still don't really understand them 🙈
I don't want gazpacho to replace bs4/lxml for everything. I want it to be the hammer that solves 95% of your web scraping problems. If that makes sense?

My offer here isn't for your to depend on soupselect - which is 14 years old and never saw a release on PyPI. It's for you to copy and paste over the code from that, clean it up and incorporate it into Gazpacho. The key implementation is only 100 lines of Python.


[📊 DATA] Are Projects Donating to Other Projects 🟠

Description

see if projects are donating to other approved projects on public goods registry

Objective / Business Insight

see tendency for proejcts to create circular economy for public goods
see correlation between different projects
emphasize this for a feature like lists that groups projects together

Acceptance Criterion

[ ] social graph
[ ] are projects donating to other projects (like approved proejcts)
[ ] are projects verifying as huamn
[ ] how many porjects are donating direclty andt through quadratic funding. Percentage and number of direct donations and quadratic funding.

Data Sources
Similar Queries

whether those projects were following each other #6

Challenges
Resources
How to Present

https://flipsidecrypto.xyz/ellen_roc/q/r-PyTv25kUSy/9-join
check if projects are approved on registry


Adding test coverage for client.py module.

Replacing _abstract() with directly raising NotImplementedError
Testing all abstract code paths
Adding no-cover for a failed import
Completely testing the base Credentials class

This is the beginning of a sprint to get to 100% code coverage (#212). I plan to focus on client.py and send small-ish PRs (to make review easier) and then just use each PR as a diffbase.
If too many diffbases makes reviews hard, I can just make the changes from HEAD and then deal with merge conflicts on my own.
/cc @waprin @nathanielmanistaatgoogle

Looks great; merge if you like?

LGTM as well.

Also curious about this is that it is completely orthogonal to issue 393.


Nest JS basic script error

basic npm install command is npm install
but now, setting is npm run install
so, make some error
04:31:34.718  Step 4/6 : RUN npm run install
04:31:34.737   ---> Running in c9f7fe9bfc34
04:31:35.592  npm`
04:31:35.592   ERR! Missing script: "install"npm ERR!
npm ERR!
04:31:35.593   Did you mean this?
04:31:35.593  npm
04:31:35.593   ERR!     npm uninstall # Remove a packagenpm
04:31:35.593   ERR!
04:31:35.593   npm ERR! To see a list of scripts, run:
npm
04:31:35.593   ERR!   npm run
04:31:35.594
04:31:35.594  npm ERR!`

Thanks! It will be fixed in the next version!


⚠ GitLab Server has degraded performance

In f438d4d, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 6385 ms

Resolved: GitLab Server performance has improved in 4f9188d.


problem fine tuning stand-alone mode worker instances

I am running spark-perf on a scale-up node with v1.6.0 in stand-alone mode, and I'm having trouble fine tuning the runs. The problem I am currently facing is that I'd like to run multiple workers (smaller JVM heaps) on a single node. But, no matter how I am configuring spark-perf I see:

1 master, N worker instances
N coarse-grained executors
1 JVM running the actual test

So, I am able to get multiple worker instances fired up, but I only see one JVM running an actual test (e.g. glm-regression). Am I messing up or missing a configuration option? The other issue I'm curious about is the coarse-grained executors. I have not seen them running before any time that I've used stand-alone mode.
Thanks.

Argh... caught again by terminology. Closing this, as there is really no problem.


Add producer field

Example for AMZN producer:
Label.Me.2019.720p.AMZN.WEBRip.800MB.x264-GalaxyRG
The producer is no longer included with quality, and will have to become its own field. Producer strings are always before the quality though, and match too liberally with title names to be its own standalone regex.
To fix this, will likely look into converting the patterns from a list to a dict, and assign the fields one by one, so producer could be able to use the quality regexes (using extras.py's link_pattern_options). Also helps with #7, as currently many regexes are split off as variables to be able to use them in multiples places.
The order in which the regexes are run probably (might?) does matter, and making this into a dictionary would break this, but this can be fixed. Maybe have a list of the field names in the needed order, and iterate through that whilst calling the appropriate dictionary entries.

Order seemed to matter slightly, not for major reasons though: think some matching isn't being taking out in the raw. Set order with a list that it reads from and accesses the dict with.


Add sv06

@Al3xlol Hello, you would mind forking and opening a pull request that adds the necessary information?


updated the text  and icon color for No data match.

Fixes #612 #607
Updated the icon color and text as commented in No known contacts.

I think this issue is not merged into the latest version 1.0.1, because it seems to be the same green color icon for me in iPhone 5s, version 11.2.6

I think the grey color icon and "No Data Match" is outdated and refers to old UX. @driedgrape can confirm.
I'm going to close this for now, but @ArchanaNair you can consult with UX on slack to work out the latest here.

@tstirrat I dropped a message to @driedgrape on slack, will update here once I get confirmation.

@ArchanaNair, Tim is correct. Based on the most up-to-date specs, it should say "No known contact" with a green indicator.
"home_no_contact_header": "No known contact",
"home_no_contact_subtext": "Based on available data you haven’t been near anyone reported positive for COVID-19.


[SPARK-9978] [PySpark] [SQL] fix Window.orderBy and doc of ntile()

cc @rxin

Merged build triggered.

Merged build started.

LGTM

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40919/
Test FAILed.

Test build #1608 has started for   PR 8213 at commit 56cf18e.

Test build #1608 has finished for   PR 8213 at commit 56cf18e.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class StringIndexerModel (
 implicit class StringToColumn(val sc: StringContext)

I've merged this.

in master/branch-1.5/branch-1.4.


fetch wallet updates separate from useLazyQuery

Fixes #141. I am not sure exactly how useQuery and useLazyQuery work, but it seems if you leave the component before they complete, the data retrieved from them will not update in the cache. By separating the updateWallet query from the component we ensure that the cache is updated when the query completes.

Fixes #141. I am not sure exactly how useQuery and useLazyQuery work, but it seems if you leave the component before they complete, the data retrieved from them will not update in the cache. By separating the updateWallet query from the component we ensure that the cache is updated when the query completes.

useLazyQuery works like a mutation and only execute when you use the function returned. otherwise the query would execute automatically when the screen is being initialized for display


entity-aware self-attention used in mLUKE

According to the mLUKE paper, mLUKE has not used entity-aware self-attention.

The word and entity tokens equally undergo self-attention computation (i.e., no entity-aware self-attention in Yamada et al. (2020)) after embedding layers.

However, the following code gives the warning message:
(The message can be suppressed by giving "use_entity_aware_attention=True".)
>>> model = transformers.AutoModel.from_pretrained("studio-ousia/mluke-base-lite")
Some weights of the model checkpoint at studio-ousia/mluke-base-lite were not used when initializing LukeModel: [
'luke.encoder.layer.0.attention.self.w2e_query.weight', 'luke.encoder.layer.0.attention.self.w2e_query.bias',
'luke.encoder.layer.0.attention.self.e2w_query.weight', 'luke.encoder.layer.0.attention.self.e2w_query.bias',
'luke.encoder.layer.0.attention.self.e2e_query.weight', 'luke.encoder.layer.0.attention.self.e2e_query.bias',
...]

>>> model.config.use_entity_aware_attention
False

In fact, the public model contains weights for entity-aware self-attention.
>>> state_dict = torch.load("pytorch_model.bin")
>>> list(state_dict.keys())
[...,
'luke.encoder.layer.0.attention.self.w2e_query.weight', 'luke.encoder.layer.0.attention.self.w2e_query.bias',
'luke.encoder.layer.0.attention.self.e2w_query.weight', 'luke.encoder.layer.0.attention.self.e2w_query.bias',
'luke.encoder.layer.0.attention.self.e2e_query.weight', 'luke.encoder.layer.0.attention.self.e2e_query.bias',
...]

Could you make it clear whether mLUKE uses entity-aware self-attention?
config.json should specify use_entity_aware_attention: true unless pytorch_model.bin is updated with no weights for entity-aware self-attention.

The values of the EASA weights are identical to the corresponding w2w... weights, which is how these weights are initialized in the LUKE paper.

I appreciate the clarification. Now I understand.
So, use_entity_aware_attention: false is not misconfiguration and this ignores unused weights.

The warning is somewhat disturbing

To fix this confusing behavior, how about equipping a model with EASA weights regardless of the setting of use_entity_aware_attention?
In this case, the model simply skips computation for the EASA weights when use_entity_aware_attention=False.

how about equipping a model with EASA weights regardless of the setting of use_entity_aware_attention?

Thank you for your suggestion.
It can be an option, but I'm concerned that it adds an unnecessary memory footprint with the unused weights.
Other solutions I can come up with are...

Add a custom warning message to LukeModel to clarify what happens when users set use_entity_aware_attention: false.
Add an explanation to the model card on hugging face hub.

As this is not the first time this kind of confusion has occurred, I will definitely do the second one later soon.
Then, probably will send a PR to hugging face for the first option.

I think we can use PreTrainedModel._keys_to_ignore_on_load_unexpected [transformers/modeling_utils.py].

Thank you for the pointer! It is a clean solution.
I will send a PR to the transformers library to add options to the LUKE model.


Weekly Calendar duplicating days

Hello,
I have implemented the weekly view of the MaterialCalendarView, which was working fine until a specific date range I saw, which is February 13 2017 until February 19 2017, that duplicated the days, as can be seen below.
Before clicking on next
http://imgur.com/a/XL9Dw
After clicking on next
http://imgur.com/a/ZBem5
As shown on the images, the days repeat, which is not the expected result. The result should be: the first week is 12 until 18 of February that is Ok, but the second week would be 19 until 25 of February.
My code is like this:
SimpleDateFormat sdf = new SimpleDateFormat("yyyy-MM-dd", Locale.ROOT);
        try {
            Date dateFrom = sdf.parse(timesheet.getTimesheetPeriod().getStartDate());
            Date dateTo = sdf.parse(timesheet.getTimesheetPeriod().getEndDate());

            Calendar calFrom = Calendar.getInstance();
            calFrom.setTime(dateFrom);

            Calendar calTo = Calendar.getInstance();
            calTo.setTime(dateTo);

            calendar.state().edit()
                    .setFirstDayOfWeek(Calendar.SUNDAY)
                    .setCalendarDisplayMode(CalendarMode.WEEKS)
                    .setMinimumDate(CalendarDay.from(calFrom.get(Calendar.YEAR), calFrom.get(Calendar.MONTH), calFrom.get(Calendar.DAY_OF_MONTH)))
                    .setMaximumDate(CalendarDay.from(calTo.get(Calendar.YEAR), calTo.get(Calendar.MONTH), calTo.get(Calendar.DAY_OF_MONTH)))
                    .commit();
        } catch (ParseException e) {
            e.printStackTrace();
        }

The first time I load the calendar, I set the current day like this:
calendar.setSelectedDate(dateFrom);
calendar.setCurrentDate(dateFrom);

Is there something wrong on my code?

I wasn't able to reproduce on the latest version. Please make sure to reopen the issue if it's still happening. Thank you.


chore: release main

:robot: I have created a release beep boop
multidim-interop: 2.0.25
2.0.25 (2024-04-09)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/tcp bumped from ^9.0.18 to ^9.0.19
@libp2p/webrtc bumped from ^4.0.24 to ^4.0.25
@libp2p/webtransport bumped from ^4.0.23 to ^4.0.24
libp2p bumped from ^1.3.2 to ^1.3.3

tcp: 9.0.19
9.0.19 (2024-04-09)
Dependencies

bump stream-to-it from 0.2.4 to 1.0.0 (#2474) (2b2958f)

webrtc: 4.0.25
4.0.25 (2024-04-09)
Dependencies

The following workspace dependencies were updated

devDependencies

libp2p bumped from ^1.3.2 to ^1.3.3

webtransport: 4.0.24
4.0.24 (2024-04-09)
Dependencies

The following workspace dependencies were updated

devDependencies

libp2p bumped from ^1.3.2 to ^1.3.3

libp2p: 1.3.3
1.3.3 (2024-04-09)
Bug Fixes

decrease default dial timeout (#2471) (936dbba)
limit max dial queue size (#2472) (0cfcc4d)

Dependencies

The following workspace dependencies were updated

devDependencies

@libp2p/tcp bumped from ^9.0.18 to ^9.0.19

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/libp2p/js-libp2p/releases/tag/multidim-interop-v2.0.25 :sunflower:

:robot: Release is at https://github.com/libp2p/js-libp2p/releases/tag/libp2p-v1.3.3 :sunflower:

:robot: Release is at https://github.com/libp2p/js-libp2p/releases/tag/tcp-v9.0.19 :sunflower:

:robot: Release is at https://github.com/libp2p/js-libp2p/releases/tag/webrtc-v4.0.25 :sunflower:

:robot: Release is at https://github.com/libp2p/js-libp2p/releases/tag/webtransport-v4.0.24 :sunflower:


Fix VanderPol and Rober benchmark

Comment QNDF() in VanderPol Problem and Rodas5() in Rober Problem benchmarks

Thanks!


[#40] Custom metrics: Histogram support

The support for metric of histogram type

Merged.
Thanks for your contribution !


Implement Process related CybOX objects

See #50

Process objects were completed before this issue was opened

window process is not handled in convert_pattern.py


Rbenv can't build Ruby 2.3.0 on El Capitan

It tries for some reason to put stuff in /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/. Probably because it doesn't inspect the env before building or something.
installing common headers:    /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/Users/camdennarzt/.rbenv/versions/2.3.0/include/ruby-2.3.0
/private/var/folders/0x/gvllnpys5p9cngslb8r5pnq80000gn/T/ruby-build.20151226114651.5865/ruby-2.3.0/lib/fileutils.rb:250:in `mkdir': Permission denied @ dir_s_mkdir - /Applications/Xcode.app/Contents/     Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/Users (Errno::EACCES)

nevermind, looks like it's a ruby bug: https://github.com/ruby/ruby/commit/e98f7ea423b08222b6eceda945613040c7b08a09#diff-7f2d280dffee5d06de608cd80c2df55f

Thanks for letting us know!


Breaks copy-paste in Editey web apps

Steps to reproduce:

Get one of the Editey's web apps, e.g. JavaScript Editey
Create a new Editey file (--> A new tab is opened with the URL "javascript.editey.com/file/...")
Type some text and try to copy-paste it.

Expected: The copied text gets pasted in the web app.
Result: Neither copy nor paste work. Nothing gets pasted. When I copy, instead of the selected text, I get a tofu block when I paste it in a native notepad. I tried to copy paste the selected text from the context menu, didn't work either.
Chrome: 54.0.2840.87 m (64-Bit) on Windows 10
The only workaround to solve this problem is to exclude Editey-related domains from the extension options.

I don't have Editey installed in order to reproduce, but I'm going to assume this is similar to #18.
This extension works by preventing a site's JavaScript from receiving paste events, this is done in order to prevent the site from blocking the browser's default behavior for those events. There are sites that listen for paste events and do useful things with those events. For those sites you do not want this extension active, which is why you can configure this extension to disable itself on certain sites.

Go to chrome://extensions/
Click on the "Options" link for this extension
Add an exclusion pattern for https?://javascript.editey.com/.* (or something similar that).

Thank your for your quick answer. If using the exclusion list is the only workaround, wouldn't it be nice to add such reported websites to  default.js for future releases? So that users don't get surprised, if something doesn't work (and then defining a custom regex is not really user-friendly). Furthermore, if a user has many Chrome extensions, it's not obvious for him that it's this extension that breaks the copy-pasting on certain websites.
The regex I defined for Editey web apps looks like this: https?:\/\/.*\.editey\.com\/.*.

Actually, adding extra patterns to defaults.js wouldn't help, as that's only used when someone first installs the extension. Someone's exclusion list wouldn't be updated when the extension is updated (unless they happen to click on "Use Default Settings" after the update). The values in the defaults are there more for backwards compatibility to older versions of this extension, when there wasn't a settings page.

With the release of version 2, the extension is no longer active on any site by default, which should alleviate this problem.


IncompatibleKeys(missing_keys=[], unexpected_keys=[]) for FCN32

I loaded FCN32s, downloaded the pre-trained weights and tried to load them into the model:
from model = FCN32s()
import FCN32s
model.load_state_dict(torch.load('fcn32s_from_caffe.pth'))
output = model(input)

Keep getting this error. I loaded VGG16 weights - they seem to be working fine.

The pre-trained model is trained with pytorch 0.2.0, so maybe it's incompatible with latest version.


Added Japanese support

Related to #142
I implemented Integer, Long and BigDecimal converter for Japanese.
I checked all tests passed.
Could you review this PR?

Codecov Report

Merging #148 (5d26e6f) into master (2c7d26d) will decrease coverage by 0.14%.
The diff coverage is 96.07%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@             Coverage Diff              @@
##             master     #148      +/-   ##
============================================
- Coverage     98.83%   98.70%   -0.14%
- Complexity      513      535      +22
============================================
  Files            76       81       +5
  Lines          2058     2157      +99
  Branches         79       83       +4
============================================
+ Hits           2034     2129      +95
- Misses           12       14       +2
- Partials         12       14       +2

Files
Coverage Δ

...llegro/finance/tradukisto/LongValueConverters.java
100.00% <100.00%> (ø)

...pl/allegro/finance/tradukisto/MoneyConverters.java
100.00% <100.00%> (ø)

...pl/allegro/finance/tradukisto/ValueConverters.java
100.00% <100.00%> (ø)

...allegro/finance/tradukisto/internal/Container.java
100.00% <100.00%> (ø)

...ternal/languages/japanese/JapanesePluralForms.java
100.00% <100.00%> (ø)

...kisto/internal/support/JapaneseNumberChunking.java
100.00% <100.00%> (ø)

...uages/japanese/JapaneseNumberToWordsConverter.java
90.90% <90.90%> (ø)

...to/internal/languages/japanese/JapaneseValues.java
97.67% <97.67%> (ø)

...ges/japanese/JapaneseThousandToWordsConverter.java
90.47% <90.47%> (ø)

Fixed.
I am amazed that you know Kanji and Hiragana!


Improve time scale tick generation

This includes two fixes:

Fixes ticks on series charts so that they're evenly spaced
Uses only common units for both minor and major ticks

The Intervals.major variable indicated if a given unit was eligible to be a major unit. The reason we skipped quarters and weeks is that they were uncommon units. It's very strange to plot week 26 2017, week 27 2017, week 28 2017, etc. People are much more used to seeing days or months, so we should choose one of those units. Skipping these two strange units isn't specific to just major ticks

I'm not sure to understand the goal of this whole change: it looks like that now 'auto' + 'series' is almost the same as 'data' + 'series', am I right? If so, why not use this combination instead?
I really don't think that auto should behave differently depending on the value of distribution, binding these two options doesn't seem a great approach. Also it's against another feature: 'series' distribution of auto generated ticks that are filtered: for example, remove ticks that fall during the weekend and display ticks in series.
scale: { // scale options
 distribution: 'series',
 ticks: {
   source: 'auto',
   filter: function(tick) {
       // return true if tick is not during the week-end
       return ...
   }
 }
}

Note: ticks.filter is not implemented yet!

I've split this PR into two to make it easier to review and discuss.


Convert to .ts

Checklist:

Closes #43778

Hey 👋🏽!
Welcome to contributing to freeCodeCamp.
Thanks for taking the time to create the PR and working on this. We’ve reviewed your pull request and decided not to merge it; However, We would welcome future pull requests from you.
You are welcome to read these guidelines to learn more about contributing to this project.
We recommend starting with issues that are labeled "help wanted"
Happy contributing.


Allow svg image upload

Fixes issue: https://github.com/the-control-group/voyager/issues/4543

Codecov Report

Merging #5556 (8ae96b9) into 1.5 (a95fd26) will decrease coverage by 1.12%.
The diff coverage is 80.95%.

@@             Coverage Diff              @@
##                1.5    #5556      +/-   ##
============================================
- Coverage     63.50%   62.37%   -1.13%
  Complexity     1401     1401
============================================
  Files           195      195
  Lines          4137     3875     -262
============================================
- Hits           2627     2417     -210
+ Misses         1510     1458      -52

Impacted Files
Coverage Δ

src/Http/Controllers/ContentTypes/Image.php
67.41% <80.95%> (+0.35%)
:arrow_up:

src/Listeners/ClearCachedSettingValue.php
66.66% <0.00%> (-8.34%)
:arrow_down:

src/Traits/AlertsMessages.php
45.00% <0.00%> (-5.00%)
:arrow_down:

src/Http/Controllers/VoyagerBaseController.php
57.72% <0.00%> (-4.92%)
:arrow_down:

src/Database/Types/Type.php
87.87% <0.00%> (-2.68%)
:arrow_down:

src/Http/Controllers/ContentTypes/Relationship.php
83.33% <0.00%> (-2.39%)
:arrow_down:

src/Helpers/helperTranslations.php
68.75% <0.00%> (-1.84%)
:arrow_down:

src/Translator.php
56.66% <0.00%> (-1.57%)
:arrow_down:

src/VoyagerServiceProvider.php
79.68% <0.00%> (-1.34%)
:arrow_down:

src/FormFields/AbstractHandler.php
78.94% <0.00%> (-1.06%)
:arrow_down:

... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a95fd26...8ae96b9. Read the comment docs.


Upgrade to Akka Streams 1.0-RC4

Thanks! Please squash the two commits and name it 'Upgrade to Akka HTTP 1.0-RC4'.

Done.

Thanks again!


Build error with Tungstenite 0.22.0+

Since https://github.com/snapview/tungstenite-rs/commit/c21281abbc65d50fa00a820014dd0bab0ac0b9e3, support for url::Url in the tungstenite library has become an optional feature that is disabled by default. Since message-io currently relies on tungstenite's default trait implementations for url::Url, this change causes a build error with tungstenite >= v0.22.0:
error[E0277]: the trait bound `url::Url: IntoClientRequest` is not satisfied
   --> /home/USER/.cargo/registry/src/index.crates.io-6f17d22bba15001f/message-io-0.18.1/src/adapters/ws.rs:199:38
    |
199 |                     match ws_connect(url, stream) {
    |                           ---------- ^^^ the trait `IntoClientRequest` is not implemented for `url::Url`
    |                           |
    |                           required by a bound introduced by this call
    |
    = help: the following other types implement trait `IntoClientRequest`:
              httparse::Request<'h, 'b>
              ClientRequestBuilder
              tungstenite::http::Request<()>
              Uri
              std::string::String
              &'a str
              &'a std::string::String
              &'a Uri
note: required by a bound in `client`
   --> /home/USER/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tungstenite-0.23.0/src/client.rs:176:10

The problem can be solved either by limiting tungstenite to versions < 0.22.0, or by requiring a version >= 0.22.0 and explicitly enabling the url feature.

Released in v0.18.2


Default only creates a single master

The default pentagon created cluster will only create a single master since it limits the *_kubernetes_master_aws_zone list to the 0th entry with it passes the value to the template.
https://github.com/reactiveops/pentagon/blob/master/pentagon/__init__.py#L177
https://github.com/reactiveops/pentagon/blob/master/pentagon/__init__.py#L188
You could work around by explicitly determining the *_kubernetes_master_aws_zones command option

fixed


Invoke chown more reliably while removing artifacts

Here is my take to fix #14842

LGTM. @vitorgalvao, any comments?

Nope, also looks good to me. Lets merge it.


Dictionary of [String: Object] not encoded correctly?

When encoding a dictionary that contains objects with form style and true explode value, the key for each parameter should be the key for each entry in the dictionary, not the key that is passed in.
This is the behaviour experienced when using https://editor.swagger.io with the following yaml file:
openapi: 3.0.3
info:
  title: Test API
  version: v1
paths:
  /products:
    get:
      summary: Get list of products
      parameters:
        - name: filters
          in: query
          schema:
            $ref: '#/components/schemas/ProductFilterRequestQueryParameter'
      responses:
        '204':
          description: OK
components:
  schemas:
    ProductFilterRequestQueryParameter:
      type: object
      description: |
        A set of constraints placed on filters, keyed by the filter name, and containg an operator and an array of values.
      additionalProperties:
        $ref: '#/components/schemas/ProductFilterRequestConstraint'
      example:
        color:
          operator: eq
          value:
            - blue_code
        material:
          operator: in
          value:
            - gold_code
            - blue_code
    ProductFilterRequestConstraint:
      type: object
      description: |
        A constraint placed on a filter. Constraints can either be "in" (an array) or "equals" (to a value).
      properties:
        operator:
          type: string
        value:
          type: array
          items:
            type: string
      required:
        - operator
        - value

You can see the results of the query produced by "trying out" the request in editor.swagger.io.
However, this package produces a query string that ignores the keys in the dictionary and flattens the values.
A failing test representing the expected output:
    func testEncodeDictionaryWithObject() {

        struct Filter: Codable {
            let `operator`: String
            let value: [String]
        }

        // GIVEN
        let parameter = [
            "color": Filter(operator: "eq", value: ["blue"]),
            "material": Filter(operator: "in", value: ["leather", "metal"])
        ]
        // THEN
        let query = URLQueryEncoder().encode(parameter, forKey: "filters").percentEncodedQuery
        // produces query == "filters=in&filters=leather&filters=metal&filters=eq&filters=blue"
        XCTAssertEqual(query, "color[operator]=eq&color[value]=blue&material[operator]=in&material[value]=leather&material[value]=metal")
    }

I am aware that the output produced by editor.swagger.io seems to be encoding the object as deepObject style while expecting a form style, so perhaps this is not a bug in this package but nonetheless I thought it important to raise an issue to discuss.
As far as I can tell, there is no official OpenAPI Spec support for deeply-nested objects. There is some discussion here with links to other discussions too. Perhaps it would be useful to define what this package will do with deep objects, and officially add support for it?

Thanks for raising this @kerrmarin and sorry for the delay in responding! It's a very interesting issue but I don't really have much experience in this area myself and I don't have any good answers unfortunately.

As far as I can tell, there is no official OpenAPI Spec support for deeply-nested objects. There is some discussion https://github.com/swagger-api/swagger-editor/issues/1954 with links to other discussions too. Perhaps it would be useful to define what this package will do with deep objects, and officially add support for it?

Yeah this is a shame. I'd be cautious about changing any behaviour ourselves, although it's interesting that the swagger editor does use the deepObject style. Documenting the behaviour certainly sounds like a good idea though.
If you have a moment, pushing up a Pull Request to add a note to the README that either links to this ticket or to some of the other discussions that you linked to might be a helpful addition 🙇


expect(...).toBeVisible is not a function

Description
After upgrading to<EMAIL_ADDRESS>and<EMAIL_ADDRESS>all Detox tests began failing with:
TypeError: expect(...).toBeVisible is not a function

Expected behavior
Detox should initialize its global variables correctly, i.e.: Jest's expect should not shadow the Detox's expect.
Actual behavior
CustomDetoxEnvironment sets Detox globals and matchers including this.global.expect, but then, a few moments later the Detox's expect gets overwritten with Jest's one.
Screenshots

See: https://github.com/facebook/jest/pull/10484

Temporary solution
Lock your jest and jest-circus dependencies to 26.4.x, like demonstrated here:

Can we catch this and throw an error?

Catch what and which error do you want to throw, could you elaborate pls? I'll check in the morning

If jest is above the version we support.


Humanize Audit Entry

Hi -
I am working on the Audit Entry where I would like to humanize the modifications based on change in certain property.
E.g. If the amount is increased or decreased I would to add a new column in the Audit Entry Property table "Activity" and insert saying Amount Reduced.
Similarly if the property let's say IsPost changed from 0 to 1 I would like to record that Activity as Posted.
Do you think you can help me on achieving something like this ?

Hello @maharatha ,
There is some place you could place similar code. I believe the best place is probably when the library has created all auditEntries and auditEntryProperties.
Here is an example that add a new AuditEntryProperty when the ColumnInt value is greater than five.
audit.Configuration.AutoSavePreAction = (context, audit2) =>
{
	foreach (var entry in audit.Entries)
	{
		if (entry.Entry != null && entry.Entry.Entity is EntitySimple)
		{
			var entity = (EntitySimple) entry.Entry.Entity;

			if (entity.ColumnInt > 5)
			{
				entry.Properties.Add(new AuditEntryProperty() { PropertyName = "GreaterThan", NewValue = "5"});
			}
		}
	}
	(context as CurrentContext).AuditEntries.AddRange(audit.Entries);
};

This is probably a good example too let you getting started. Let me know if you need more help or this example was enough to find your solution.
Best Regards,
Jonathan

Thank you for responding so quick. But my requirement is to access the old and new value and then decide on what to insert.
The example you gave would suffice half of my requirement but it would accommodate most of it if I have access to the old and new value before inserting.

You can easily access to old value by finding it either in the properties list or using the ObjectStateEntry
var oldValue = entry.Entry.OriginalValues["ColumnInt"];
var newValue1 = entity.ColumnInt;
var newValue2 = entry.Entry.CurrentValues["ColumnInt"];


Re-justify or remove the discussion of FluentIterable in "the ImmutableList.Builder case"

https://jspecify.dev/docs/spec/#substitution explains why our substitution rules have a special case for null-exclusive type variables. That overall point is still true. But we go on to discuss why we use MINUS_NULL instead of NO_CHANGE, and we justify it by appealing to FluentIterable, whose annotations have subsequently changed with the introduction of @NonNull. We should see if the justification still holds up (perhaps with a FluentIterable-like type that is null-unmarked) or not, and we should update the spec accordingly.

Maybe also explain that "the ImmutableList.Builder case" has an effect not just for unspecified-nullness type arguments but for nullable type arguments?
In one way, the latter case sounds less important: It can arise only in the case of code that would already have other nullness errors if it were all being checked for nullness.
In another way, it sounds more important: We're generally more comfortable with the idea of leaving types unspecified and letting tools choose to refine them than we are with the idea of leaving types nullable and letting tools choose to refine them. (OK, we actually expect plenty of refining of nullable types, too. But we expect it in the case of "I know that this nullable expression is non-null in this case," not "I know that this nullable parameter is non-null in this case.")

Hmm. By "nullable type arguments" you mean cases like this?
@NullMarked
interface Foo<T> {
  void foo(T t);
}

@NullMarked
// test:not-nullness-subtype:String?:String!:Foo#T
void test(Foo<@Nullable String> foo) {
  foo(null); // not-nullness-subtype or no?
}

I continue to think that a smart tool should know that any expression using a symbol whose declaration had a type argument that wasn't a nullness subtype of its type parameter's bound is suspect, certainly if the expression involves that type variable, without the spec making any extra effort to point that out.

Right, a case like that.
I suspect we agree that the spec and conformance tests should either say that there's a not-nullness-subtype finding there or say that there's not? But I'm not sure what you have in mind when you refer to "making any extra effort." I think we've talked about removing the special case entirely (and a special case is clearly "extra effort" of a sort). Another possibility is to use NO_CHANGE instead of MINUS_NULL (which wouldn't change the effect on the example you just gave but which might feel simpler), which is more what this issue is about.
Maybe we can add this to the list of things to talk more about in a meeting :)

If this issue is just about changing the non-normative discussion in the spec, then we don't have to debate it here; let's talk about the actual change you want to make (like, in a PR).
If this issue is about changing the normative part of the spec that says that when substituting a type argument for a type parameter, then use NO_CHANGE for all the type variables (before any projections) regardless of the operator of the type argument, then the issue title is wrong. 😁

I'll update my last comment to say that if this issue is about changing only the non-normative parts of the spec, then perhaps it shouldn't block the 1.0 release of the spec.

OK, I have convinced myself that it does still make sense for the rule to use MINUS_NULL (as opposed to NO_CHANGE). So there is no normative spec change to be made, only an improvement to the non-normative part. Thus:

This issue doesn't block spec 1.0, as noted above. I'm removing it from the milestone.
I've mailed https://github.com/jspecify/jspecify/pull/657 to update the example. (But now it looks like I'm going to remove the example instead :))


Secret scanning push protection bypass rules (beta)

Summary
Security teams need more configurability over who can bypass push protection to balance security and developer productivity effectively. By integrating secret scanning's push protection into repository rulesets, Application Security teams can provide fine-grained control over which users can approve requested bypasses. Developers will have the ability to request approval from authorized users to push a blocked secret.

This shipped with GHES 3.14<EMAIL_ADDRESS>


update new patterns before new values to prevent leftover placeholder characters

When providing both a new value and new pattern at the same time leftover placeholder characters remain.
This is caused by updating the value before updating the pattern.
This pull request switches the order and adds a test case.

nice catch. thanks for the added test case, too


add pretty format for debug logs

Goose currently supports json, csv, and raw (debug, ie {:#}), add pretty print debug (ie {:#?})which can be useful for reviewing structured data.

Fixed with https://github.com/tag1consulting/goose/pull/340


feat(typescript): configure inlayHint

since LazyVim have toggle inlayhint keymap, it make sense to configure them for each extra languages provided. In this commit I just add the configuration for typescript, since IDK how to configure the rest of lang extras that was provided.

+1 i also think inlay hints should be configured for supported languages, thanks for the contribution !

I've turned off some inlay hint configs and merged. Thanks!


Pastanaga Editor: Make text float around left/right aligned images in edit mode as well

Right now if you make images float left/right in the edit mode, the text won't float around the image:

This works in the view mode though:

@rakshitv15 thank you for stepping up to work on this and sorry we did not reply sooner! Unfortunately, we kind of already fixed the issue. I'd recommend going through the Volto issues that are marked as "easy" to find other tasks that are suitable for you:
https://github.com/plone/volto/labels/41 lvl%3A easy
Let me know if there is anything I can do to help!

Fixed by @sneridagh. Closing


ios Google Login Internal Error 500

I am implementing react-native-google-signin, and when i try to run on simulator i get Internal error 500. I already approved my account to be used in the simulator.
Steps to Reproduce

run react-native run-ios
Click Sign In and input email and password
accounts.google.com return Internal Error 500

Environment

react-native : 0.56.0
react-native-google-signin : 1.0.0 rc3
react : 16.4.1
cocoapods and GoogleSignIn pod version : both latest version

@jozan, i did not try the example app, but my code work perfectly on android, and on ios, it did show login form but end with internal error 500 in simulator and end with "something went wrong" on physical device

Is the error shown in Webview or somewhere else?
Make sure you're using the correct GoogleServices-info.plist which is created for your project and recheck that your configuration object has correct values.

@jozan, i already double checked and i use the correct iosclientid and correct googleservices-info.plist, bundle id also correct, i can send u the code and plist if u need it

I had same error, too

http://prntscr.com/klvdi0

@luckycharm313 You wrote that you had the same error. Have you resolved it? :)

This is the screenshot of the error i get on simulator, have been trying to create new app, new plist, new bundle id, add pod 'Firebase/Core' and the result is still error 500 for ios.
@luckycharm313, have you managed to solve the problem ?

I had the same problem but now it is working.
I had filled in App ID, App nickname, Bundle ID and App Store ID filled in for my app in Firebase, but I had left the App ID Prefix blank. When I filled in the App ID Prefix it started to work.
You can find the App ID Prefix here: https://developer.apple.com/account/ios/identifier/bundle
Click on any app id to see your prefix.

I had the same problem. I tried @FabianOMB fix but with no success

I tried @FabianOMB fix but no success too, I also try to change GoogleSignIn SDK download to 4.0.0 instead of 4.2.0 and still get the same error.

Try to clear the history of safari :)
I do that sometime and it work.

Have you checked the linked framework and libraries?
I had the same issue, the problem was missing framework.
I did use cocoapods, but somehow the frame and libraries not correctly linked.
https://github.com/react-native-community/react-native-google-signin/blob/master/ios-guide.md

@lilsatya , which version of GoogleSignIn SDK are u using ? 4.0.0 or 4.2.0 ?

Any solution for this? i followed the article correctly ???

I cannot repro the error so it’s not quite easy to find a solution.

This issue seems to be stale. If you still get the same error (500) please create a new issue. Closing this.


Improve error when command isn't defined

ROM.use :auto_registration
ROM.setup :memory

class Users < ROM::Relation[:memory]
  register_as :users
end

# when this is removed:
# class CreateUser < ROM::Commands::Create[:memory]
#   relation :users
#   register_as :create
# end

ROM.finalize

rom = ROM.env

create_user = rom.command(:users).create # ==> ElementNotFoundError

Produces ROM::Registry::ElementNotFoundError: :users doesn't exist in ROM::Registry, but that doesn't describe the precise problem, which is that there is no such command. A better error would be something like:
ROM::Registry::NoSuchCommandError: There is no :create command defined for :users relation.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/27536880-improve-error-when-command-isn-t-defined?utm_campaign=plugin&utm_content=tracker%2F155789&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F155789&utm_medium=issues&utm_source=github).

+1 xD

:+1:


fixed the logic and improved the template

going to work on css and API for the next update

this looks awesome


Add parameters to caret related mixins

Caret related mixins can be useful to designer for purposes others navbars and dropdowns. This PR allows for different size and margin and vertical-alignment with default matching default bs variables

Thanks for this! Slating for v5.3.0 as it's a nice new feature to have.


Map doesn't fir in the borders

Issue description
I have given the following styles:
agm-map {
border: 1px solid black;
border-radius: 20px;
}
But the corners of the map, pop out of the specified border.

Expected/desired behavior
However, I want the corners to be inside the border.

This is a css problem. Please close this issue. Btw if you add overflow: hidden it will fix it.


Implement CloseAsync and Abort needs to use this.webApp in StopWebServer()

private void StopWebServer()
{
    if (this.serverHandle != null)
    {
        try
        {
            this.serverHandle.Dispose();
        }
        catch (ObjectDisposedException)
        {
            // no-op
        }
    }
}

this needs to use this.webApp

Hi @snijhof, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@snijhof : Thanks for your contribution to the Azure documentation! The author, @vturecek, has been notified to review your proposed change.

@snijhof great catch, thank you!

#sign-off


Add "PET_ITEM_FORAGING_SKILL_BOOST_EPIC"

https://discord.com/channels/997079228510117908/1200017326217633863

does PET_ITEM_FARMING_SKILL_BOOST_EPIC even drop by wolves?

No, that one is bought from Duncan in dungeons.


[Enhancement] Upgrade hudi dependency version to 0.12.1

What type of PR is this：

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

upgrade hudi dependency to the latest version and resolve class conflicts

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

run starrocks_admit_test

run starrocks_fe_unittest

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

run starrocks_admit_test

run starrocks_admit_test

@Mergifyio backport branch-2.5


Support for Swift 3.0

Is that in the works?

Just noticed there's an [open PR])(https://github.com/radex/SwiftyUserDefaults/pull/91)

Need it as well

For now, feel free to use the branch from https://github.com/radex/SwiftyUserDefaults/pull/91 :)

On swift3 branch. Thanks for your patience!


[test] Add PrgEnv-pgi to SPEC-ACCEL test

Hello @sebkelle1, Thank you for submitting the Pull Request!

Codecov Report

Merging #999 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #999   +/-   ##
=======================================
  Coverage   91.84%   91.84%
=======================================
  Files          80       80
  Lines       10732    10732
=======================================
  Hits         9857     9857
  Misses        875      875

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b122790...7ba10fa. Read the comment docs.


Add paysera.com

Hello @johnmcdee ,
This repo is not being maintained anymore, but we are trying to keep it alive on a fork here, would you kindly submit your PR there and close this one here? :)

Hi @tupaschoal!
Sure, thanks for pointing me in the right direction!


Automatically create a new release or publish new image when changes are merged

Currently, we need to manually create a release to publish the new image.

Related to #39, #40, #41, #42, #43, #44.

Related to #45, #46, #47, #48, #49, #50, #51, #52, #53, #54, #55, #56, #57, #58, #59, #60, #61.

Completed with release 0.2.0.


Add transfer and module transaction ids

Related to https://github.com/safe-global/safe-transaction-service/pull/1365
This PR adds the new fields (transferId, moduleTransactionId) for Transfers and Module Transactions into the associated entities, validation schemas, and test instance builders.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.116%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3676

Relevant Lines:
4028

💛  - Coveralls


chore(deps): update dependency @typescript-eslint/eslint-plugin to v8

This PR contains the following updates:

Package
Type
Update
Change

@typescript-eslint/eslint-plugin (source)
devDependencies
major
^7.6.0 -> ^8.0.0

Release Notes

typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)
v8.0.0
Compare Source
🚀 Features

stricter parent types for the AST

typescript-estree: split TSMappedType typeParameter into constraint and key

eslint-plugin: remove formatting/layout rules

eslint-plugin: [prefer-nullish-coalescing] change ignoreConditionalTests default to true

eslint-plugin: deprecate no-loss-of-precision extension rule

eslint-plugin: [no-unused-vars] align catch behavior to ESLint 9

typescript-estree: rename automaticSingleRunInference to disallowAutomaticSingleRunInference

utils: allow specifying additional rule meta.docs in RuleCreator

eslint-plugin: split no-empty-object-type out from ban-types and no-empty-interfaces

rule-tester: support multipass fixes

typescript-estree: stabilize EXPERIMENTAL_useProjectService as projectService

eslint-plugin: remove deprecated no-throw-literal rule

eslint-plugin: apply initial config changes for v8

eslint-plugin: remove no-useless-template-literals

eslint-plugin: [no-floating-promises] add 'allowForKnownSafeCalls' option

eslint-plugin: replace ban-types with no-restricted-types, no-unsafe-function-type, no-wrapper-object-types

eslint-plugin: [no-unused-vars] add reportUnusedIgnorePattern option

eslint-plugin: [no-unused-vars] support ignoreClassWithStaticInitBlock

eslint-plugin: [no-unused-vars] handle comma operator for assignments, treat for-of the same as for-in

eslint-plugin: [no-unused-vars] report if var used only in typeof

eslint-plugin: [no-floating-promises] disable checkThenables by default for v8

rule-tester: switched to flat config

eslint-plugin: [no-unnecessary-type-parameters] promote to strict

🩹 Fixes

correct eslint-plugin's peerDependency on parser@8

disable projectService in disabled-type-checked shared config

typescript-estree: add TSEnumBody node for TSEnumDeclaration body

eslint-plugin: include alpha pre-releases in parser peer dependency

eslint-plugin: correct rules.d.ts types to not rely on non-existent imports

eslint-plugin: remove duplicate import RuleModuleWithMetaDocs

type-utils: also check declared modules for package names in TypeOrValueSpecifier

eslint-plugin: [no-unnecessary-template-expression] do not render escaped strings in autofixes

eslint-plugin: [no-unused-vars] incorporate upstream changes around caught errors report messages

eslint-plugin: [no-misused-promises] perf: avoid getting types of variables/functions if the annotated type is obviously not a function

rule-tester: provide Linter a cwd in its constructor

❤  Thank You

Abraham Guo
Alfred Ringstad
auvred
Brad Zacher
Christopher Aubut
Collin Bachman
James Henry
Josh Goldberg
Josh Goldberg ✨
Kirk Waiblinger
StyleShit
Victor Lin
Yukihiro Hasegawa

You can read about our versioning strategy and releases on our website.
7.18.0 (2024-07-29)
🩹 Fixes

eslint-plugin: [no-unnecessary-type-assertion] prevent runtime error when asserting a variable declared in default TS lib

eslint-plugin: [unbound-method] report on destructuring in function parameters

eslint-plugin: [no-duplicate-type-constituents] shouldn't report on error types

eslint-plugin: [strict-boolean-expressions] support branded booleans

❤  Thank You

auvred
Oliver Salzburg
Vinccool96
Yukihiro Hasegawa

You can read about our versioning strategy and releases on our website.
7.17.0 (2024-07-22)
🚀 Features

eslint-plugin: backport no-unsafe-function type, no-wrapper-object-types from v8 to v7

eslint-plugin: [return-await] add option to report in error-handling scenarios only, and deprecate "never"

🩹 Fixes

eslint-plugin: [no-floating-promises] check top-level type assertions (and more)

eslint-plugin: [strict-boolean-expressions] consider assertion function argument a boolean context

eslint-plugin: [no-unnecessary-condition] false positive on optional private field

❤  Thank You

Armano
Josh Goldberg ✨
Kirk Waiblinger
StyleShit

You can read about our versioning strategy and releases on our website.
7.16.1 (2024-07-15)
🩹 Fixes

eslint-plugin: [no-unnecessary-type-parameters] descend into all parts of mapped types in no-unnecessary-type-parameters

❤  Thank You

Dan Vanderkam

You can read about our versioning strategy and releases on our website.
7.16.0 (2024-07-08)
🚀 Features

rule-tester: stricter rule test validations

eslint-plugin: [no-unnecessary-parameter-property-assignment] add new rule

eslint-plugin: add support for nested namespaces to unsafe-member-access

eslint-plugin: [no-floating-promises] add checkThenables option

🩹 Fixes

deps: update dependency @eslint-community/regexpp to v4.11.0

eslint-plugin: [no-floating-promises] add suggestions to tests from #9263 checkThenables

website: react key error on internal pages of website

eslint-plugin: [restrict-template-expressions] don't report tuples if allowArray option is enabled

❤  Thank You

Abraham Guo
auvred
Josh Goldberg ✨
Juan Sanchez
Vinccool96
YeonJuan
Yukihiro Hasegawa

You can read about our versioning strategy and releases on our website.
7.15.0 (2024-07-01)
🚀 Features

eslint-plugin: [array-type] detect Readonly<string[]> case

eslint-plugin: back-port new rules around empty object types from v8

🩹 Fixes

disable EXPERIMENTAL_useProjectService in disabled-type-checked shared config

eslint-plugin: [no-unsafe-return] differentiate a types-error any from a true any

eslint-plugin: [no-unsafe-call] differentiate a types-error any from a true any

❤  Thank You

auvred
Kim Sang Du
rgehbt
Vinccool96

You can read about our versioning strategy and releases on our website.
7.14.1 (2024-06-24)
🩹 Fixes

eslint-plugin: [prefer-nullish-coalescing] treat enums and literals as their underlying primitive types

eslint-plugin: [prefer-nullish-coalescing] ensure ternary fix does not remove parens

❤  Thank You

Jake Bailey

You can read about our versioning strategy and releases on our website.
7.14.0 (2024-06-24)
🚀 Features

support TypeScript 5.5

🩹 Fixes

eslint-plugin: [no-extraneous-class] handle abstract members

eslint-plugin: [prefer-nullish-coalescing] handle intersected primitive types

eslint-plugin: [no-invalid-this] support AccessorProperty

❤  Thank You

Brad Zacher
cm-ayf
Jake Bailey
James Zhan
Joshua Chen
yoshi2no

You can read about our versioning strategy and releases on our website.
7.13.1 (2024-06-17)
🩹 Fixes

eslint-plugin: [prefer-readonly] refine report locations

eslint-plugin: [return-await] support explicit resource management

eslint-plugin: [no-unsafe-member-access] differentiate a types-error any from a true any

❤  Thank You

Kirk Waiblinger
Yukihiro Hasegawa

You can read about our versioning strategy and releases on our website.
7.13.0 (2024-06-10)
🚀 Features

typescript-estree: require import = require() argument to be a string literal

typescript-estree: forbid .body, .async, .generator on declare function

eslint-plugin: [no-dynamic-delete] allow all string literals as index

🩹 Fixes

ast-spec: function-call-like callee should be Expression not LeftHandSideExpression

scope-manager: handle index signature in class

eslint-plugin: [init-declarations] refine report locations

eslint-plugin: [no-base-to-string] make error message more nuanced

eslint-plugin: [no-unsafe-assignment] be more specific about error types

eslint-plugin: [no-magic-numbers] fix implementation of the ignore option

❤  Thank You

Fotis Papadogeorgopoulos
Joshua Chen
Kirk Waiblinger
Tobiloba Adedeji
Vinccool96
YeonJuan

You can read about our versioning strategy and releases on our website.
7.12.0 (2024-06-03)
🚀 Features

eslint-plugin: [no-useless-template-literals] rename to no-useless-template-expression (deprecate no-useless-template-literals)

rule-tester: check for parsing errors in suggestion fixes

rule-tester: port checkDuplicateTestCases from ESLint

eslint-plugin: [no-floating-promises] add option 'allowForKnownSafePromises'

🩹 Fixes

no-useless-template-expression -> no-unnecessary-template-expression

eslint-plugin: [no-unnecessary-type-assertion] combine template literal check with const variable check

eslint-plugin: [dot-notation] fix false positive when accessing private/protected property with optional chaining

eslint-plugin: [explicit-member-accessibility] refine report locations

eslint-plugin: [no-unnecessary-type-assertion] declares are always defined, so always check declares

eslint-plugin: [prefer-literal-enum-member] allow using member it self on allowBitwiseExpressions

eslint-plugin: [return-await] clean up in-try-catch detection and make autofixes safe

eslint-plugin: [member-ordering] also TSMethodSignature can be get/set

❤  Thank You

Abraham Guo
Han Yeong-woo
Joshua Chen
Kim Sang Du
Kirk Waiblinger
YeonJuan

You can read about our versioning strategy and releases on our website.
7.11.0 (2024-05-27)
🚀 Features

eslint-plugin: deprecate prefer-ts-expect-error in favor of ban-ts-comment

🩹 Fixes

eslint-plugin: [consistent-type-assertions] prevent syntax errors on arrow functions

❤  Thank You

Abraham Guo
auvred
Dom Armstrong
Kirk Waiblinger

You can read about our versioning strategy and releases on our website.
7.10.0 (2024-05-20)
🚀 Features

eslint-plugin: [sort-type-constituents] support case sensitive sorting

🩹 Fixes

eslint-plugin: [prefer-regexp-exec] fix heuristic to check whether regex may contain global flag

❤  Thank You

auvred
Emanuel Hoogeveen
jsfm01
Kirk Waiblinger

You can read about our versioning strategy and releases on our website.
7.9.0 (2024-05-13)
🩹 Fixes

eslint-plugin: [explicit-function-return-types] fix false positive on default parameters

❤  Thank You

Kirk Waiblinger
Sheetal Nandi
Vinccool96

You can read about our versioning strategy and releases on our website.
7.8.0 (2024-04-29)
🩹 Fixes

eslint-plugin: [no-unsafe-argument] handle  tagged templates

eslint-plugin: [prefer-optional-chain] suggests optional chaining during strict null equality check

eslint-plugin: [consistent-type-assertions] handle tagged templates

eslint-plugin: [no-unsafe-return] handle union types

eslint-plugin: [no-unused-vars] clear error report range

❤  Thank You

auvred
Josh Goldberg ✨
jsfm01
Kim Sang Du
YeonJuan

You can read about our versioning strategy and releases on our website.
7.7.1 (2024-04-22)
🩹 Fixes

eslint-plugin: [no-unsafe-assignment] handle shorthand property assignment

eslint-plugin: [explicit-function-return-type] fix checking wrong ancestor's return type

eslint-plugin: [prefer-optional-chain] only look at left operand for requireNullish

eslint-plugin: [no-for-in-array] refine report location

eslint-plugin: [no-unnecessary-type-assertion] allow non-null assertion for void type

❤  Thank You

Abraham Guo
Kirk Waiblinger
YeonJuan

You can read about our versioning strategy and releases on our website.
7.7.0 (2024-04-15)
🚀 Features

eslint-plugin: replace no-new-symbol with no-new-native-nonconstructor

❤  Thank You

Dave
Josh Goldberg ✨

You can read about our versioning strategy and releases on our website.
7.6.0 (2024-04-08)
🚀 Features

bump npm dependency ranges

❤  Thank You

Abraham Guo
auvred
Brad Zacher

You can read about our versioning strategy and releases on our website.
7.5.0 (2024-04-01)
🩹 Fixes

eslint-plugin: [no-floating-promises] handle TaggedTemplateExpression

eslint-plugin: [no-unnecessary-type-assertion] handle exactOptionalPropertyTypes compiler option

❤  Thank You

Brad Zacher
Kim Sang Du
Mark de Dios
Naru
YeonJuan

You can read about our versioning strategy and releases on our website.
7.4.0 (2024-03-25)
🚀 Features

eslint-plugin: [consistent-type-imports] ignore files with decorators, experimentalDecorators, and emitDecoratorMetadata

eslint-plugin: [no-unnecessary-type-arguments] handle tagged templates

eslint-plugin: deprecate no-throw-literal and add a renamed only-throw-error

🩹 Fixes

eslint-plugin: [prefer-optional-chain] address multipart nullish checks false positive

eslint-plugin: [prefer-optional-chain] properly disambiguate between boolean and false

eslint-plugin: [no-unnecessary-type-assertion] avoid remove const casting on template literals with expressions inside

❤  Thank You

Abraham Guo
Brad Zacher
Josh Goldberg ✨
Kim Sang Du
Kirk Waiblinger
Marco Pasqualetti
YeonJuan

You can read about our versioning strategy and releases on our website.
7.3.1 (2024-03-18)
🩹 Fixes

eslint-plugin: [no-floating-promises] revert disable of ignoreVoid in strict config

❤  Thank You

Josh Goldberg ✨

You can read about our versioning strategy and releases on our website.
7.3.0 (2024-03-18)
🚀 Features

eslint-plugin: [restrict-template-expressions] add allowArray option

eslint-plugin: add meta.docs.recommended setting for strict config options

eslint-plugin: add rule use-unknown-in-catch-callback-variables

eslint-plugin: [prefer-reduce-type-parameter] supports tuple, union, intersection

🩹 Fixes

correct engines.node constraints in package.json

eslint-plugin: [unbound-method] check method definition in object literal using longhand form

eslint-plugin: [consistent-type-imports] handle imports without specifiers

eslint-plugin: [no-redundant-type-constituents] incorrectly marks & string as redundant

eslint-plugin: [no-unnecessary-qualifier] handle merge namespace with enum

eslint-plugin: [no-unused-expressions] false negatives when using assertions

eslint-plugin: [ban-ts-comment] more accurate handling of multiline comments

eslint-plugin: [explicit-function-return-type, explicit-module-boundary-types] improved checking for allowHigherOrderFunctions option

eslint-plugin: [class-literal-property-style] ignore property assigned in constructor

eslint-plugin: [no-unnecessary-type-assertion] fix false negative for const variable declarations

❤  Thank You

Abraham Guo
Alexu
Arka Pratim Chaudhuri
auvred
Derrick Isaacson
fnx
Josh Goldberg ✨
Kirk Waiblinger
Marta Cardoso
Michaël De Boey
Tristan Rasmussen
YeonJuan

You can read about our versioning strategy and releases on our website.
7.2.0 (2024-03-11)
🚀 Features

support TS 5.4

eslint-plugin: [prefer-string-starts-ends-with] add allowSingleElementEquality option

🩹 Fixes

eslint-plugin: expose *-type-checked-only configs for extension

eslint-plugin: [member-ordering] report alphabetical sorting for all groups instead of just the first failing group

eslint-plugin: [no-var-requires, no-require-imports] support template literal

eslint-plugin: [no-useless-template-literals] detect TemplateLiteral

eslint-plugin: [no-unnecessary-condition] handle union array and tuple type

eslint-plugin: [prefer-find] support ternary branches in prefer-find

❤  Thank You

Arka Pratim Chaudhuri
auvred
Chris Plummer
Fotis Papadogeorgopoulos
Josh Goldberg ✨
Kirk Waiblinger
Wayne Zhang
YeonJuan

You can read about our versioning strategy and releases on our website.
7.1.1 (2024-03-04)
This was a version bump only for eslint-plugin to align it with other projects, there were no code changes.
You can read about our versioning strategy and releases on our website.
7.1.0 (2024-02-26)
🚀 Features

eslint-plugin: add *-type-checked-only configs

eslint-plugin: [naming-convention] support the auto-accessor syntax

eslint-plugin: [consistent-return] add new rule

🩹 Fixes

eslint-plugin: [prefer-optional-chan] allow typeof for avoiding reference error

eslint-plugin: [no-misused-promises] improve check union types

eslint-plugin: [no-use-before-define] fix false positive type reference in as, satisfies

❤  Thank You

Arka Pratim Chaudhuri
Josh Goldberg ✨
YeonJuan

You can read about our versioning strategy and releases on our website.
7.0.2 (2024-02-19)
🩹 Fixes

fix tsconfig-less check errors, fix @types/eslint incompatibilities, add tests

❤  Thank You

Brad Zacher
Gareth Jones

You can read about our versioning strategy and releases on our website.
7.0.1 (2024-02-12)
🩹 Fixes

eslint-plugin: update peer dep for parser

❤  Thank You

Tim Dorr

You can read about our versioning strategy and releases on our website.

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: package-lock.json
npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving<EMAIL_ADDRESS>npm error Found<EMAIL_ADDRESS>npm error node_modules/@typescript-eslint/parser
npm error   dev<EMAIL_ADDRESS>from the root project
npm error
npm error Could not resolve dependency:
npm error peer<EMAIL_ADDRESS>|| ^8.0.0-alpha.0" from<EMAIL_ADDRESS>npm error node_modules/@typescript-eslint/eslint-plugin
npm error   dev<EMAIL_ADDRESS>from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /tmp/renovate/cache/others/npm/_logs/2024-08-01T01_25_22_553Z-eresolve-report.txt
npm error A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2024-08-01T01_25_22_553Z-debug-0.log


Include and Exclude does not work correctly

An example of this is that trying to recreate the files behaviour in package.json by excluding everything and including specific things doesn't work. The package tries to publish zero files.

Example config
{
    "name": "@ghost/kjua-revived",
    "version": "0.2.0",
    "exports": {
        "./package.json": "./package.json",
        ".": "./src/kjua.ts"
    },
    "include": [
        "src/**",
        "README.md",
        "LICENSE",
        "jsr.json"
    ],
    "exclude": [
        "**"
    ]
}

Docs excerpt
https://archive.ph/kof8a#ignoring-files

Related: #22648

Mostly creating this issue for tracking/visibility for others since it looks like that issue in Deno repo is the cause but there is no issue here for it :pray:

Thanks - I'll also add a note to the docs.

I'm kinda stuck here. The file I want to publish is in the .gitignore, which prevents me from publishing. I'd like to know when will this fix be released, and how do I upgrade JSR?

@cloydlau npx jsr@latest should help!

@ghostdevv Thanks, I've upgraded jsr to v0.11.0 using this command, but still the about-to-publish file list is empty when I run npx jsr publish --dry-run.

The docs are still incorrect. There is an open PR here: https://github.com/jsr-io/jsr/pull/238
Change the config to this (unfortunately it needs to be nested under the "publish" config for the time being, but in the future that will be collapsed down):
{
    "name": "@ghost/kjua-revived",
    "version": "0.2.0",
    "exports": {
        "./package.json": "./package.json",
        ".": "./src/kjua.ts"
    },
    "publish": {
      "include": [
          "src/**",
          "README.md",
          "LICENSE",
          "jsr.json"
      ]
    }
}

I tried the nested "publish", the about-to-publish file list is not empty now, but the directories or files listed in the .gitignore are still missing even if they are explicitly declared in publish.include.


Locality load balancing won't work if use header based routing for virtual service

Bug description

Locality load balancing is working fine without virtual service

hello-v1 down, istio can failover to hello-v2

If use header based routing for virtual service, locality load balancing won't work

  spec:
    hosts:
    - hello
    http:
    - match:
      - headers:
          region:
            regex: v1
      route:
      - destination:
          host: hello
          subset: v1
    - route:
      - destination:
          host: hello
          subset: v2

hello-v1 down, istio can't failover to hello-v2

I need header based routing and failover feature, but it doesn't seem to work with locality load balancing, it seems the prioirity of header based routing is higher than locality load balancing?

Affected product area (please put an X in all that apply)
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
Affected features (please put an X in all that apply)
[X] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Expected behavior
Locality load balancing work with header based routing for virtual service
Version (include the output of istioctl version --remote and kubectl version --short and helm version --short if you used Helm)
# istio
client version: 1.8.1
control plane version: 1.8-dev-806fb24bc121bf93ea06f6a38b7ccb3d78d1f326
data plane version: 1.8.1 (18 proxies)

# k8s
Client Version: v1.14.3
Server Version: v1.16.3

# helm
v3.3.4+ga61ce56

This is working as expected. The locality priority is applied to the destination. So since you have already filtered the destination down to one region, there is nothing to failover to.

This is working as expected. The locality priority is applied to the destination. So since you have already filtered the destination down to one region, there is nothing to failover to.

Thanks for replying. Is there a way to use header based routing while using locality load balancing, or other implementation？
For example, curl -H "region:v1" hello should go to region1 first, if region1 down, failover to region2. Thanks

I do not think that is possible, the locality is always based on where the client is located, so the header influence probably will not work

I found a similar issue, but seems not possible also.
Implement Priority in VirtualService.   https://github.com/istio/istio/issues/20717


#15110 - Support double ammo mould in SmeltingPlugin

Fix #15110 by checking if there is a double ammo mould in the inventory

Added in #15446 - your code is wrong because it doesn't account for making cannonballs out of a single bar


support reading data from places which aren't files

Hi.
I would suggest prioritizing a "memory" protocol for synthizer buffers.
My reasoning is, that with a "file" protocol and a "memory" protocol, almost every generic use case would be covered, since you can almost convert every other use case (that I can think of) to either a file, or in-memory data.
thoughts?

I agree. That would wrap up grabbing sound data - from the internet for example - quite nicely. Unless I'm missing something, which is entirely possible.

This is prioritized for after the planned HRTF improvement and basic reverb.  What you'll be getting is the ability to wire in your own stream protocols directly.  In C this'll be callbacks:
int readFromStream(void *stream) {
    // ...
}

bool seekInStream(void* stream, int pos) {
    //...
}

Etc.  And in Python, you'll do it by inheriting from a class.
Then things like reading from the internet, etc, are you just do them and don't round-trip through a temporary buffer that you construct only for the sake of giving it to a Synthizer decode function.
There will probably then be a simplified helper for buffers themselves that doesn't require going through the trouble of registering a custom protocol when you already have a chunk of memory you want to feed in, but the above lets you do lots of stuff and avoids having a big wav file fully loaded into memory twice over and also works with streaming, etc.

Not sure if this also includes the possibility of handing Synthizer an array of u8s and a content type, and having it create a buffer from that? If not then I'll create a separate issue. I'd like to create an asset loader for Bevy, and it expects to hand something an array of bytes and get back an arbitrarily-typed asset.
I suspect this is under the same umbrella, but I don't really need seeking and a callback interface would be overkill. Perhaps that's where the helpers come in, but in the off-chance that I'm wrong, I wanted to make sure this use case was covered.
Thanks.

@ndarilek
The short answer is yes.  The long answer is also yes, pretty much.  Though the helper is specifically for doing what you want to do, being as the underlying streaming thing is more complicated.  No need to make you implement 5 methods for loading a buffer.
Do you need the ability to manually specify the content type?  At the moment Synthizer just autodetects it and I wasn't planning to really make that change.

Cool deal. Content-type autodetection is fine. I just need to hand
Synthizer some bytes and have it hand me back a buffer it can play. Thanks!

You're welcome, also the timeline at the moment is probably ~3 weeks.  This one is after #32 which became super super high priority after Linux support because reasons, and is a pretty big refactor.  But this ticket is maybe the number 1 requested thing, so after performance stops sucking, etc.

It obviously took longer than 3 weeks, but Synthizer 0.9 will have syz_createBufferFromEncodedData, which is implemented now, as well as syz_createBufferFromFloat.  There will also be custom streams, in order to address the use case of using this functionality with StreamingGenerator, as well as enabling all the other use cases.
I'll close this issue out with the 0.9 release.


[Suggestion] TransactionConfig can be made internal in 4.0.0?

Hi,
As version 4.0.0 of the driver now favors usage of TransactionConfigBuilder and there is no public API which accepts or exposes TransactionConfig, it seems like it can be made internal. Although formally it's a breaking change, in fact it should not affect anyone.
Driver version: .NET driver 4.0.0

We've added this PR https://github.com/neo4j/neo4j-dotnet-driver/pull/399 to actually to allow users to access to TransactionConfig after created in case anyone would like to read the config after it is created.


Run pr intgration tests on cloud dev as well

[x] Run PR integration tests against cloud dev as well
[x] Run push integration tests against cloud dev as well
[x] Run examples against cloud dev as well
[x] Run server regession tests against cloud dev as well

@bahlo Which jobs do you think should be required?


[Event Request] Codeunit 5063 ArchiveManagement - OnBeforeArchivePurchDocument

Hi, would it be possible to get an event OnBeforeArchivePurchDocument in codeunit 5063, procedure ArchivePurchDocument, like this :
    procedure ArchivePurchDocument(var PurchHeader: Record "Purchase Header")
    var
        ConfirmManagement: Codeunit "Confirm Management";
        IsHandled : Boolean;
    begin

        IsHandled := false;
        OnBeforeArchivePurchDocument(PurchHeader,IsHandled);
        if not IsHandled then begin
            if ConfirmManagement.GetResponseOrDefault(
                StrSubstNo(Text007, PurchHeader."Document Type", PurchHeader."No."), true)
            then begin
                StorePurchDocument(PurchHeader, false);
                Message(Text001, PurchHeader."No.");
            end;
        end;
    end;

    [IntegrationEvent(false, false)]
    local procedure OnBeforeArchivePurchDocument(var PurchHeader: Record "Purchase Header" ; var IsHandled : Boolean)
    begin
    end;

?
Thanks

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


TestPage.GetField

Has TestPage.GetField been dropped from AL? Is there an alternative?

Just spotted you can reach fields by name to get the value.
TestPage.FieldName.Value()


build: Fix build reproducibility.

Without going the extra length of exporting PYTHONHASHSEED=0 or
similar, the built sdist and wheel for a given version of the project
would have inconsistent random ordering of extras_require entries
between builds.
This was observed attempting to lock a VCS requirement on a fork of this
project here: https://github.com/pantsbuild/pants/discussions/21145
On the bright side, it led to Pex fixing its building and locking code
to be robust to this sort of (unintended) bad behavior:
https://github.com/pex-tool/pex/pull/2554

@MthwRobinson it looks like you may be most appropriate to review. The problematic use of set appears to stem directly from #986.


zstd.ZstdCompressionWriter object has no attribute _FileLikeProxy__inner

Problem description
Opening a zst file in append mode causes a crash
Steps/code to reproduce the problem
$ python -c "from smart_open import open;f=open('/tmp/test.zst', 'ab')"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/misha/.pyenv/versions/smartopen/lib/python3.12/site-packages/smart_open/smart_open_lib.py", line 251, in open
    return so_utils.FileLikeProxy(decoded, binary)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/misha/.pyenv/versions/smartopen/lib/python3.12/site-packages/smart_open/utils.py", line 213, in __init__
    self.__inner = inner
    ^^^^^^^^^^^^
AttributeError: 'zstd.ZstdCompressionWriter' object has no attribute '_FileLikeProxy__inner'

Versions
>>> import platform, sys, smart_open
>>> print(platform.platform())
Linux-5.15.0-117-generic-x86_64-with-glibc2.35
>>> print("Python", sys.version)
Python 3.12.5 (main, Aug 14 2024, 15:59:14) [GCC 11.4.0]
>>> print("smart_open", smart_open.__version__)
smart_open 7.0.4

Checklist
Before you create the issue, please make sure you have:

[x] Described the problem clearly
[x] Provided a minimal reproducible example, including any required data
[x] Provided the version numbers of the relevant software

The problem seems to have been introduced in 7.0.0, as I'm unable to reproduce the crash with 6.4.0.
@ddelange Can you please look into this? I think the bug was introduced here: https://github.com/piskvorky/smart_open/commit/192845bba2d8819118edacc9330dc7807477819b


Question about your latency graph

@IlyasMoutawwakil Just to be clear, this graph is showing that the AWQ method performs the worst in terms of forward latency/inference time, correct? (from https://github.com/huggingface/optimum-benchmark/tree/main/examples/running-mistrals)

I've been coming across conflicting information around the impact of quantization on inference time, so just checking. For example, on https://huggingface.co/docs/transformers/main/en/quantization, it mentions

AWQ quantization can also be combined with FlashAttention-2 to further accelerate inference.

(emphasis on "further") - implying AWQ was supposed to accelerate inference. But your graph seems to suggest otherwise.

These are already "old" benchmarks 😅, the quantization libraries are in constant development, but I believe this issue still exists in AutoAWQ. The problem is that GEMV scales very poorly with batch size. If you want the latest benchmarks, I suggest looking at the llm-perf leaderboard plots.
Quantization schemes that perform compute in fp16 are inherently slower than pure fp16, because of the dequantization overhead. The best way to accelerate an AutoAWQ model is by using its fused modules (use_fuse=True in the quant config), which I think delivers the best performance (will add to the llm-perf later).


First draft of overview

Hi guys.
This PR contains a simple first draft of the "overview" page of the aleph docs that's sorely missing.
I want to iterate on this based on your feedback.
It also includes a fix for a typo I found in a different page's title.

And thank you @guillheu, it was indeed much needed! :+1: