PVC not honoring Retain reclaimPolicy

I have the below volume claim template with reclaimPolicy: Retain:
    volumeClaimTemplates:
      - name: storage-vc-template
        spec:
          storageClassName: ebs-sc-xfs
          reclaimPolicy: Retain
          accessModes:
            - ReadWriteOnce
          resources:
            requests:
              storage: {{ .Values.ebsVolumeSize }}

But operator is applying a Delete policy:
$ kubectl get pvc -o custom-columns="NAME:.metadata.name,\
 POLICY:.metadata.labels.clickhouse\.altinity\.com\/reclaimPolicy,\
 SIZE:.spec.resources.requests.storage,\
 PV:.spec.volumeName"
NAME                                                            POLICY    SIZE    PV
storage-vc-template-chi-clickhouse-0-0-0     Delete    475Gi   pvc-c211beb4-ec6f-414d-887c-bf15e778df49

Operator then decides to delete PVC when CHI is deleted
I0719 14:12:21.902130       1 deleter.go:203] PVC tc/storage-vc-template-chi-clickhouse-0-0-0 would be deleted
I0719 14:12:21.911134       1 deleter.go:212] OK delete PVC tc/storage-vc-template-chi-clickhouse-0-0-0

Any ideas?

This also happened to me. At the initial setup, PVCs were created with correct reclaimPolicy: Retain. But after some times we had to update eks cluster nodes which  effectively replaced all nodes with newer version. What happened was that all existing PVCs went to "Released" state and new PVCs with "reclaimPolicy" set to "Delete" which was the default value of associated storage class was created and bound to existing volumes.
Need to know if this is a bug and how to prevent this in future.

@mbkh68
EKS worker nodes upgrade shall not affect reclaimPolicy
could you share your kind: ClickHouseInstallation manifest?
kubectl get chi -n your-namespace your-chi-name -o yaml

Thank you @Slach
here is my ClickHouseInstallation file:
`apiVersion: "clickhouse.altinity.com/v1"
kind: "ClickHouseInstallation"
metadata:
name: "clickhouse"
namespace: ${namespace}
spec:
defaults:
templates:
serviceTemplate: default-service-template
configuration:
files:
config.d/force_drop_table.xml: |

<max_partition_size_to_drop>0</max_partition_size_to_drop>
<max_table_size_to_drop>0</max_table_size_to_drop>

openssl_client.xml: |

false
/etc/clickhouse-server/secrets.d/ca.crt/clickhouse-tls-cert/ca.crt
true
sslv2,sslv3
true
none

AcceptCertificateHandler

openssl.xml: |

/etc/clickhouse-server/secrets.d/server.crt/clickhouse-tls-cert/server.crt
/etc/clickhouse-server/secrets.d/server.key/clickhouse-tls-cert/server.key
/etc/clickhouse-server/secrets.d/dhparam.pem/clickhouse-tls-cert/dhparam.pem
none
true
true
sslv2,sslv3
true

ca.crt:
valueFrom:
secretKeyRef:
name: clickhouse-tls-cert
key: ca.crt
server.crt:
valueFrom:
secretKeyRef:
name: clickhouse-tls-cert
key: server.crt
server.key:
valueFrom:
secretKeyRef:
name: clickhouse-tls-cert
key: server.key
dhparam.pem:
valueFrom:
secretKeyRef:
name: clickhouse-tls-cert
key: dhparam.pem
kafka.conf: |

<sasl_username>${kafka_username}</sasl_username>
<sasl_password>${kafka_password}</sasl_password>
<security_protocol>${kafka_security_protocol}</security_protocol>
<sasl_mechanisms>${kafka_sasl_mechanisms}</sasl_mechanisms>
<enable_ssl_certificate_verification>false</enable_ssl_certificate_verification>

keeper_map.conf: |

<keeper_map_path_prefix>/keeper_map_tables</keeper_map_path_prefix>

users:
admin/networks/ip: "::/0"
admin/profile: default
admin/password_sha256_hex: ${admin_hashed_password}
  backup/networks/ip: "::/0"
  backup/profile: default
  backup/password_sha256_hex: ${backup_hashed_password}

  service-control/networks/ip: "::/0"
  service-control/profile: readonly
  service-control/password_sha256_hex: ${sc_hashed_password}
zookeeper:
  nodes:
    ${indent(8, zk_nodes)}
settings:
  interserver_http_port: _removed_
  interserver_https_port: 9009
  tcp_port: 9000 # keep for localhost
  tcp_port_secure: 9440
  https_port: 8443
  logger/level: information
clusters:
  - name: ${cluster_name}
    secure: "yes"
    insecure: "no"
    secret:
      auto: "yes"
    layout:
      shards:
      ${indent(10, shards)}
    templates:
      podTemplate: pod-template-with-volumes

templates:
serviceTemplates:
- generateName: clickhouse-{chi}
metadata:
annotations:
external-dns.alpha.kubernetes.io/hostname: ${host_name}.
external-dns.alpha.kubernetes.io/ttl: '60'
service.beta.kubernetes.io/load-balancer-source-ranges: ${allowed_ip_ranges}
name: default-service-template
spec:
ports:
- name: https
port: 8443
- name: secureclient
port: 9440
type: LoadBalancer
volumeClaimTemplates:
- name: data-storage-vc-template
reclaimPolicy: Retain
spec:
storageClassName: ${storage_class_name}
accessModes:
- ReadWriteOnce
resources:
requests:
storage: ${data_storage_size}
- name: log-storage-vc-template
spec:
storageClassName: ${storage_class_name}
accessModes:
- ReadWriteOnce
resources:
requests:
storage: ${log_storage_size}
podTemplates:
- name: pod-template-with-volumes-us-west-2a
zone:
values:
- "us-west-2a"
distribution: "OnePerHost"
spec:
serviceAccountName: ${service_account}
containers:
- name: clickhouse
image: clickhouse/clickhouse-server:${clickhouse_version}
volumeMounts:
- name: data-storage-vc-template
mountPath: /var/lib/clickhouse
- name: log-storage-vc-template
mountPath: /var/log/clickhouse-server
resources: ${resources}
- name: clickhouse-backup
${indent(14, backup_container)}
  - name: pod-template-with-volumes-us-west-2b
    zone:
      values:
        - "us-west-2b"
    distribution: "OnePerHost"
    spec:
      serviceAccountName: ${service_account}
      containers:
        - name: clickhouse
          image: clickhouse/clickhouse-server:${clickhouse_version}
          volumeMounts:
            - name: data-storage-vc-template
              mountPath: /var/lib/clickhouse
            - name: log-storage-vc-template
              mountPath: /var/log/clickhouse-server
          resources: ${resources}
        - name: clickhouse-backup
          ${indent(14, backup_container)}
  - name: pod-template-with-volumes-us-west-2c
    zone:
      values:
        - "us-west-2c"
    distribution: "OnePerHost"
    spec:
      serviceAccountName: ${service_account}
      containers:
        - name: clickhouse
          image: clickhouse/clickhouse-server:${clickhouse_version}
          volumeMounts:
            - name: data-storage-vc-template
              mountPath: /var/lib/clickhouse
            - name: log-storage-vc-template
              mountPath: /var/log/clickhouse-server
          resources: ${resources}
        - name: clickhouse-backup
          ${indent(14, backup_container)}
  - name: pod-template-with-volumes-default
    spec:
      containers:
        - name: clickhouse
          image: clickhouse/clickhouse-server:${clickhouse_version}
          volumeMounts:
            - name: data-storage-vc-template
              mountPath: /var/lib/clickhouse
            - name: log-storage-vc-template
              mountPath: /var/log/clickhouse-server
          resources: ${resources}`

Thank you @Slach
Here is my ClickHouseInstallation file:
Also I use release-0.23.0 version.
apiVersion: "clickhouse.altinity.com/v1"
kind: "ClickHouseInstallation"

metadata:
  name: "clickhouse"
  namespace: ${namespace}

spec:
  defaults:
    templates:
      serviceTemplate: default-service-template
  configuration:
    files:
      config.d/force_drop_table.xml: |
        <yandex>
          <max_partition_size_to_drop>0</max_partition_size_to_drop>
          <max_table_size_to_drop>0</max_table_size_to_drop>
        </yandex>
      openssl_client.xml: |
        <clickhouse>
          <openSSL>
            <client>
              <loadDefaultCAFile>false</loadDefaultCAFile>
              <caConfig>/etc/clickhouse-server/secrets.d/ca.crt/clickhouse-tls-cert/ca.crt</caConfig>
              <cacheSessions>true</cacheSessions>
              <disableProtocols>sslv2,sslv3</disableProtocols>
              <preferServerCiphers>true</preferServerCiphers>
              <verificationMode>none</verificationMode>
              <invalidCertificateHandler>
                <name>AcceptCertificateHandler</name>
              </invalidCertificateHandler>
            </client>
          </openSSL>
        </clickhouse>
      openssl.xml: |
        <clickhouse>
          <openSSL>
            <server>
              <certificateFile>/etc/clickhouse-server/secrets.d/server.crt/clickhouse-tls-cert/server.crt</certificateFile>
              <privateKeyFile>/etc/clickhouse-server/secrets.d/server.key/clickhouse-tls-cert/server.key</privateKeyFile>
              <dhParamsFile>/etc/clickhouse-server/secrets.d/dhparam.pem/clickhouse-tls-cert/dhparam.pem</dhParamsFile>
              <verificationMode>none</verificationMode>
              <loadDefaultCAFile>true</loadDefaultCAFile>
              <cacheSessions>true</cacheSessions>
              <disableProtocols>sslv2,sslv3</disableProtocols>
              <preferServerCiphers>true</preferServerCiphers>
            </server>
          </openSSL>
        </clickhouse>
      ca.crt:
        valueFrom:
          secretKeyRef:
            name: clickhouse-tls-cert
            key: ca.crt
      server.crt:
        valueFrom:
          secretKeyRef:
            name: clickhouse-tls-cert
            key: server.crt
      server.key:
        valueFrom:
          secretKeyRef:
            name: clickhouse-tls-cert
            key: server.key
      dhparam.pem:
        valueFrom:
          secretKeyRef:
            name: clickhouse-tls-cert
            key: dhparam.pem
      kafka.conf: |
        <clickhouse>
          <kafka>
            <sasl_username>${kafka_username}</sasl_username>
            <sasl_password>${kafka_password}</sasl_password>
            <security_protocol>${kafka_security_protocol}</security_protocol>
            <sasl_mechanisms>${kafka_sasl_mechanisms}</sasl_mechanisms>
            <enable_ssl_certificate_verification>false</enable_ssl_certificate_verification>
          </kafka>
        </clickhouse>
      keeper_map.conf: |
        <clickhouse>
          <keeper_map_path_prefix>/keeper_map_tables</keeper_map_path_prefix>
        </clickhouse>
    users:
      admin/networks/ip: "::/0"
      admin/profile: default
      admin/password_sha256_hex: ${admin_hashed_password}

      backup/networks/ip: "::/0"
      backup/profile: default
      backup/password_sha256_hex: ${backup_hashed_password}

      service-control/networks/ip: "::/0"
      service-control/profile: readonly
      service-control/password_sha256_hex: ${sc_hashed_password}
    zookeeper:
      nodes:
        ${indent(8, zk_nodes)}
    settings:
      interserver_http_port: _removed_
      interserver_https_port: 9009
      tcp_port: 9000 # keep for localhost
      tcp_port_secure: 9440
      https_port: 8443
      logger/level: information
    clusters:
      - name: ${cluster_name}
        secure: "yes"
        insecure: "no"
        secret:
          auto: "yes"
        layout:
          shards:
          ${indent(10, shards)}
        templates:
          podTemplate: pod-template-with-volumes

  templates:
    serviceTemplates:
      - generateName: clickhouse-{chi}
        metadata:
          annotations:
            external-dns.alpha.kubernetes.io/hostname: ${host_name}.
            external-dns.alpha.kubernetes.io/ttl: '60'
            service.beta.kubernetes.io/load-balancer-source-ranges: ${allowed_ip_ranges}
        name: default-service-template
        spec:
          ports:
            - name: https
              port: 8443
            - name: secureclient
              port: 9440
          type: LoadBalancer
    volumeClaimTemplates:
      - name: data-storage-vc-template
        reclaimPolicy: Retain
        spec:
          storageClassName: ${storage_class_name}
          accessModes:
            - ReadWriteOnce
          resources:
            requests:
              storage: ${data_storage_size}
      - name: log-storage-vc-template
        spec:
          storageClassName: ${storage_class_name}
          accessModes:
            - ReadWriteOnce
          resources:
            requests:
              storage: ${log_storage_size}
    podTemplates:
      - name: pod-template-with-volumes-us-west-2a
        zone:
          values:
            - "us-west-2a"
        distribution: "OnePerHost"
        spec:
          serviceAccountName: ${service_account}
          containers:
            - name: clickhouse
              image: clickhouse/clickhouse-server:${clickhouse_version}
              volumeMounts:
                - name: data-storage-vc-template
                  mountPath: /var/lib/clickhouse
                - name: log-storage-vc-template
                  mountPath: /var/log/clickhouse-server
              resources: ${resources}
            - name: clickhouse-backup
              ${indent(14, backup_container)}

      - name: pod-template-with-volumes-us-west-2b
        zone:
          values:
            - "us-west-2b"
        distribution: "OnePerHost"
        spec:
          serviceAccountName: ${service_account}
          containers:
            - name: clickhouse
              image: clickhouse/clickhouse-server:${clickhouse_version}
              volumeMounts:
                - name: data-storage-vc-template
                  mountPath: /var/lib/clickhouse
                - name: log-storage-vc-template
                  mountPath: /var/log/clickhouse-server
              resources: ${resources}
            - name: clickhouse-backup
              ${indent(14, backup_container)}
      - name: pod-template-with-volumes-us-west-2c
        zone:
          values:
            - "us-west-2c"
        distribution: "OnePerHost"
        spec:
          serviceAccountName: ${service_account}
          containers:
            - name: clickhouse
              image: clickhouse/clickhouse-server:${clickhouse_version}
              volumeMounts:
                - name: data-storage-vc-template
                  mountPath: /var/lib/clickhouse
                - name: log-storage-vc-template
                  mountPath: /var/log/clickhouse-server
              resources: ${resources}
            - name: clickhouse-backup
              ${indent(14, backup_container)}
      - name: pod-template-with-volumes-default
        spec:
          containers:
            - name: clickhouse
              image: clickhouse/clickhouse-server:${clickhouse_version}
              volumeMounts:
                - name: data-storage-vc-template
                  mountPath: /var/lib/clickhouse
                - name: log-storage-vc-template
                  mountPath: /var/log/clickhouse-server
              resources: ${resources}

could you upgrade operator to 0.23.7 first to continue to figure out?
could you provide full logs from clickhouse-operator container?
kubectl log -n <operator-namespace> -l app=clickhouse-operator --container=clickhouse-operator --since=48h


v3: port grids functionality over from v2.

We currently have grids functionality in our v2 branch, but no such thing exists in v3. It looks like issue #26 was done while we were in-between cutover from v2 to v3.
This should be a straightforward merge of that feature commit into master.

This was successfully merged into the master branch and released internally.


Place search is broken

URL
No response
How to reproduce the issue?
It looks like the same issue Ben describes in https://github.com/facebook/Rapid/issues/1007 applies to iD as well. I get a CORS error when searching for Huston.
Screenshot(s) or anything else?
No response
Which deployed environments do you see the issue in?
Released version at openstreetmap.org/edit
What version numbers does this issue effect?
No response
Which browsers are you seeing this problem on?
No response

Confirming that I also get a 404 for the request to https://nominatim.openstreetmap.org/search/ and that only POIs/data loaded in the current view display in search, in agreement with what Ben noted.

This is caused by osm-search/Nominatim#3134, although I thought openstreetmap/operations#920 would have temporarily fixed the issue...

@k-yle I still get the CORS error. Is this maybe something different from the other "search/" issues?

I see this was fixed by @tyrasd last week via X and Y.
I can confirm it works on https://ideditor.netlify.app/
@tyrasd since the change referenced in https://github.com/openstreetmap/iD/issues/9822#issuecomment-1670462560 does not solve the issue on production, maybe this is something for a hotfix release?
I will close the issue now, since it is handled pending deployment…

@tordans yeah, I thought so as well, but as I had planned to do a full release soon anyway, it is now included in v2.27.0, which should be deployed soon. :relaxed:


Add dubbo-pilot deploy and doc

What this PR does:
Modified Makefile and Added the compiled dubbo-pilot control plane script.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Codecov Report

Merging #504 (f6b0e37) into develop (b71ac6e) will decrease coverage by 0.00%.
The diff coverage is n/a.

:exclamation: Current head f6b0e37 differs from pull request most recent head e7f8336. Consider uploading reports for the commit e7f8336 to get more accurate results

@@             Coverage Diff             @@
##           develop     #504      +/-   ##
===========================================
- Coverage    54.71%   54.71%   -0.01%
===========================================
  Files          664      664
  Lines        77744    77744
===========================================
- Hits         42537    42535       -2
- Misses       31570    31573       +3
+ Partials      3637     3636       -1

Impacted Files
Coverage Δ

pkg/envoy/admin.go
50.00% <0.00%> (-9.68%)
:arrow_down:

pkg/config/mesh/kubemesh/watcher.go
59.01% <0.00%> (-8.20%)
:arrow_down:

pilot/pkg/model/addressmap.go
57.35% <0.00%> (-5.89%)
:arrow_down:

security/pkg/nodeagent/sds/sdsservice.go
84.76% <0.00%> (-2.65%)
:arrow_down:

pilot/pkg/model/service.go
45.70% <0.00%> (-1.81%)
:arrow_down:

pkg/test/framework/resource/version.go
18.42% <0.00%> (-1.76%)
:arrow_down:

pkg/envoy/instance.go
76.27% <0.00%> (-1.70%)
:arrow_down:

security/pkg/nodeagent/cache/secretcache.go
84.94% <0.00%> (-0.77%)
:arrow_down:

pkg/istio-agent/agent.go
56.73% <0.00%> (-0.49%)
:arrow_down:

pilot/pkg/bootstrap/certcontroller.go
42.51% <0.00%> (ø)

... and 8 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


How to pass SSL client certificate in the oauth object?

I'm trying to connect to a service that uses OAuth1 with ssl certificate and key for authentication.
Is it possible to add ssl details to the oauth object?

Hey, I need this same feature as well. I looked into the node-oauth source code and in function _createClient() there is the definition of the options object which gets passed to the https request. If we can specify our own options object or additions to it, that would be great.
I too need to specify a custom key and cert file while doing a OAuth1 cycle.

+1.


Maven Buildpack fails with code 145

When running the Maven Buildpack 6.5.0 on Circleci the task fails with Code 145.
Bellow is the output from the process
Paketo Maven Buildpack 6.5.0
https://github.com/paketo-buildpacks/maven
Build Configuration:
$BP_MAVEN_BUILD_ARGUMENTS  -Dmaven.test.skip=true --no-transfer-progress package  the arguments to pass to Maven
$BP_MAVEN_BUILT_ARTIFACT   target/*.[ejw]ar                                       the built application artifact explicitly.  Supersedes $BP_MAVEN_BUILT_MODULE
$BP_MAVEN_BUILT_MODULE                                                            the module to find application artifact in
$BP_MAVEN_DAEMON_ENABLED   false                                                  use maven daemon
$BP_MAVEN_POM_FILE         pom.xml                                                the location of the main pom.xml file, relative to the application root
Creating cache directory /home/cnb/.m2
Compiled Application: Contributing to layer
Executing mvnw --batch-mode -Dmaven.test.skip=true --no-transfer-progress package
Unable to parse command line options: Unrecognized option: --no-transfer-progress
  usage: mvn [options] [<goal(s)>] [<phase(s)>]

  Options:
   -am,--also-make                        If project list is specified, also
                                          build projects required by the
                                          list
   -amd,--also-make-dependents            If project list is specified, also
                                          build projects that depend on
                                          projects on the list
   -B,--batch-mode                        Run in non-interactive (batch)
                                          mode (disables output color)
   -b,--builder <arg>                     The id of the build strategy to
                                          use
   -C,--strict-checksums                  Fail the build if checksums don't
                                          match
   -c,--lax-checksums                     Warn if checksums don't match
   -cpu,--check-plugin-updates            Ineffective, only kept for
                                          backward compatibility
   -D,--define <arg>                      Define a system property
   -e,--errors                            Produce execution error messages
   -emp,--encrypt-master-password <arg>   Encrypt master security password
   -ep,--encrypt-password <arg>           Encrypt server password
   -f,--file <arg>                        Force the use of an alternate POM
                                          file (or directory with pom.xml)
   -fae,--fail-at-end                     Only fail the build afterwards;
                                          allow all non-impacted builds to
                                          continue
   -ff,--fail-fast                        Stop at first failure in
                                          reactorized builds
   -fn,--fail-never                       NEVER fail the build, regardless
                                          of project result
   -gs,--global-settings <arg>            Alternate path for the global
                                          settings file
   -gt,--global-toolchains <arg>          Alternate path for the global
                                          toolchains file
   -h,--help                              Display help information
   -l,--log-file <arg>                    Log file where all build output
                                          will go (disables output color)
   -llr,--legacy-local-repository         Use Maven 2 Legacy Local
                                          Repository behaviour, ie no use of
                                          _remote.repositories. Can also be
                                          activated by using
                                          -Dmaven.legacyLocalRepo=true
   -N,--non-recursive                     Do not recurse into sub-projects
   -npr,--no-plugin-registry              Ineffective, only kept for
                                          backward compatibility
   -npu,--no-plugin-updates               Ineffective, only kept for
                                          backward compatibility
   -nsu,--no-snapshot-updates             Suppress SNAPSHOT updates
   -o,--offline                           Work offline
   -P,--activate-profiles <arg>           Comma-delimited list of profiles
                                          to activate
   -pl,--projects <arg>                   Comma-delimited list of specified
                                          reactor projects to build instead
                                          of all projects. A project can be
                                          specified by [groupId]:artifactId
                                          or by its relative path
   -q,--quiet                             Quiet output - only show errors
   -rf,--resume-from <arg>                Resume reactor from specified
                                          project
   -s,--settings <arg>                    Alternate path for the user
                                          settings file
   -t,--toolchains <arg>                  Alternate path for the user
                                          toolchains file
   -T,--threads <arg>                     Thread count, for instance 2.0C
                                          where C is core multiplied
   -U,--update-snapshots                  Forces a check for missing
                                          releases and updated snapshots on
                                          remote repositories
   -up,--update-plugins                   Ineffective, only kept for
                                          backward compatibility
   -v,--version                           Display version information
   -V,--show-version                      Display version information
                                          WITHOUT stopping build
   -X,--debug                             Produce execution debug output

unable to invoke layer creator
unable to contribute application layer
error running build
exit status 1
ERROR: failed to build: exit status 1
ERROR: failed to build: executing lifecycle: failed with status code: 145

The suggested solution here would be to use a newer version of Maven. The flag mentioned in the error, --no-transfer-progress is from Maven 3.6.1 (2019). You should use a version of Maven newer than that.
By default, the buildpack will install a version of Maven that is newer than 3.6.1 and compatible with this argument. However, if you are using Maven Wrapper, then the version of Maven is dictated by the Maven wrapper present in your application. You likely need to update your Maven wrapper so it's using a newer version. Then next time you build, the buildpack will use that version of Maven.
If you cannot update Maven for some reason, set the env variable BP_MAVEN_BUILD_ARGUMENTS to -Dmaven.test.skip=true package with pack build -e BP_MAVEN_BUILD_ARGUMENTS='-Dmaven.test.skip=true package'. That will override the default set of Maven arguments and remove the one incompatible with your older version of Maven.

The project is not using any wrapper and will rely on the maven buildpack for taking action on installing the correct maven version. I have verified that this is happening on a java 17 project, but not when java 11 project ??
Here is the output from the java 17 project where maven is contributing ->
Paketo Maven Buildpack 6.5.0
https://github.com/paketo-buildpacks/maven
Build Configuration:
$BP_MAVEN_BUILD_ARGUMENTS  -Dmaven.test.skip=true --no-transfer-progress package  the arguments to pass to Maven
$BP_MAVEN_BUILT_ARTIFACT   target/*.[ejw]ar                                       the built application artifact explicitly.  Supersedes $BP_MAVEN_BUILT_MODULE
$BP_MAVEN_BUILT_MODULE                                                            the module to find application artifact in
$BP_MAVEN_DAEMON_ENABLED   false                                                  use maven daemon
$BP_MAVEN_POM_FILE         pom.xml                                                the location of the main pom.xml file, relative to the application root
Apache Maven 3.8.5: Contributing to layer
Downloading from https://repo1.maven.org/maven2/org/apache/maven/apache-maven/3.8.5/apache-maven-3.8.5-bin.tar.gz
Verifying checksum
Expanding to /layers/paketo-buildpacks_maven/maven
Creating cache directory /home/cnb/.m2
I think this i a bug in the builder,  and that I know that i can temporary fix this by overriding the MAVEN_BUILD_ARGUEMENTS as stated.

Executing mvnw --batch-mode -Dmaven.test.skip=true --no-transfer-progress package

In your original post, it says mvnw  ^^^. Are you certain?
I can take a closer look if you include the full output from building, as well as the full pack buildcommand you're running. It's hard to say what might be happening without the full output.

Closing this now. Thanks for pointing me in the right direction :-)


MSGraphClient still does not work for guest accounts without browser activity

Category

[ ] Question
[ ] Typo
[X ] Bug
[ ] Additional article idea

related to #3722, I have a mobile app that gets an oauth token and then uses it in the graph client
var c = new GraphServiceClient(
new DelegateAuthenticationProvider(
(requestMessage) =>
{
requestMessage.Headers.Authorization = new AuthenticationHeaderValue("bearer", syncInfo.accessToken);
return Task.FromResult(0);
}));
I then try to get some list items from a site the user is a guest account on.
var items = await c.Sites["mysite"].Lists["9ed7b835-610e-405b-ad6b-b71782f55d3d"].Items
.Request().Filter("fields/Title eq '" + userId + @"'").Expand("fields")
.GetAsync();
If the user is logged into the website using the browser, I get the list item result. If not (or its been ~24 hours since the user was logged in to the site using the browser) I fail to get the list items.

What error are you getting? You say it's failing if they are not signed into the site or it's been 24 hours since they were signed in... that sounds like the access token has expired...


Update sample tests

this is a follow up to #88 by @KannarFr. There are too many follow up fixes to do before I make the samples tests pass, so I am intentionally merging this without passing tests


On screen indicator for NMZ power ups

Can an on-screen indicator showing which power ups are currently spawned in nmz be added?
Sometimes the chat just goes by too fast and if i'm not paying 100% attention i'll miss it.
I think right beside the potion icons would be a good spot.

I'd recommend using the Chat Notifier to get notifications when powerups spawn.

Duplicate of #2278


Julia Support

Does not look like Julia is currently supported though it is mentioned at the top of the notebooks.ai page.

I concur with @sebastient. Would love Julia support. Having Julia as a kernel would definitely be a differentiator among the Jupyter Notebook cloud providers. Everyone (Google, Microsoft) has Python support. Others (Microsoft) also have R support. Few outside of JuliaBox support Julia.

Thanks folks! Yes, R & Julia are coming very soon!


update ma732 encoder and test

Hi lee
What is the ma732 update about?
On Sat, May 18, 2024, 01:47 leemagnusson @.***> wrote:

You can view, comment on, or merge this pull request online at:
https://github.com/unhuman-io/obot-controller/pull/251
Commit Summary

5430149
https://github.com/unhuman-io/obot-controller/pull/251/commits/54301495441dc0987ccac003f9843e24e847b77a
update ma732 encoder and test

File Changes
(3 files https://github.com/unhuman-io/obot-controller/pull/251/files)

M motorlib
https://github.com/unhuman-io/obot-controller/pull/251/files#diff-35a791bec0b5fd56149288ac018eb03903ed293fdd3dae1ab79d54017124f98f
(2)
M obot_g474/config/config_obot_g474_motor_enc.cpp
https://github.com/unhuman-io/obot-controller/pull/251/files#diff-43b4595189af2175e7ea68cc1838a3515417be3077cd2234e7d2914e20db9ba6
(10)
M obot_g474/test/system/test_motor_enc.py
https://github.com/unhuman-io/obot-controller/pull/251/files#diff-d69ec0451b67f4cb4a8ca91182db92d4187fb4590801036ca3867bb74e6fe08c
(39)

Patch Links:

https://github.com/unhuman-io/obot-controller/pull/251.patch
https://github.com/unhuman-io/obot-controller/pull/251.diff

—
Reply to this email directly, view it on GitHub
https://github.com/unhuman-io/obot-controller/pull/251, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADKWXEP7BAW3SSX3YIEVCFDZC2JH5AVCNFSM6AAAAABH45WWHCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGMYDGNRZGM4DSNA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Changes here: https://github.com/unhuman-io/motorlib/pull/251. @josebly An important change on the ma782. I was setting the filter incorrectly, this seems to make it very noisy.

Same problem on ma782? A problem with ma782 is the BCT is not read
correctly with motor_util --api
On Mon, May 20, 2024, 19:10 leemagnusson @.***> wrote:

Changes here: unhuman-io/motorlib#251
https://github.com/unhuman-io/motorlib/pull/251. @josebly
https://github.com/josebly An important change on the ma782. I was
setting the filter incorrectly, this seems to make it very noisy.
—
Reply to this email directly, view it on GitHub
https://github.com/unhuman-io/obot-controller/pull/251#issuecomment-2120856464,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADKWXEMG4J2Q4RIRC2EDALDZDIVAPAVCNFSM6AAAAABH45WWHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRQHA2TMNBWGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


request enhancement to image deletion on import for detected duplicates

Currently, the checkbox on the import dialog to delete images after import only applies to images actually imported.  If the import directory contains duplicates of images previously imported, and the user has selected to check for duplicates, then only those images actually imported (i.e., not duplicates) will be deleted from the source directory.
I sometimes do NOT check the delete after import, especially if I absolutely want to confirm the import before deleting.  I know I can manually go the the import directory and delete the files, but I would like to be able to check the delete box, repeat the import, and have f-spot delete the files.  I am NOT requesting that the default behaviour be changed, but that some option be presented such as "Also delete images not imported because they were detected as duplicates."  It might also be less confusing if this checkbox only appears if the main "delete after import" and "detect duplicates" are both checked.

That should be rather simple to implement. But we start to really clutter up the import dialog with a lot of options that most people probably never change. Maybe good defaults and a "link" to another configuration dialog could clean that up...
(I also thought about this when adding the merge-raw-and-jpeg feature...)


Force visit of array instructions and added comments

Cancels and replace #172
Array instructions were not visited because they were handled directly by visitInstruction(...). I've excluded ArrayInstruction from the scope of visitInstruction(...) so that visitArrayInstruction(...) is called through the accept(...) method.

Codecov Report

Merging #173 (e5e765f) into master (f93a0db) will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #173      +/-   ##
============================================
+ Coverage     60.49%   60.68%   +0.19%
- Complexity     3569     3596      +27
============================================
  Files           363      363
  Lines         15638    15638
  Branches       1945     1945
============================================
+ Hits           9460     9490      +30
+ Misses         5301     5268      -33
- Partials        877      880       +3

Impacted Files
Coverage Δ

...rc/main/java/org/apache/bcel/util/BCELFactory.java
94.70% <100.00%> (+2.94%)
:arrow_up:

...va/org/apache/bcel/generic/InstructionFactory.java
47.63% <0.00%> (+6.86%)
:arrow_up:

...java/org/apache/bcel/generic/ArrayInstruction.java
68.75% <0.00%> (+56.25%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

I think I will get to this PR after 6.7.0, for 6.7.1...

I think I will get to this PR after 6.7.0, for 6.7.1...

Hello @nbauma109
Thank you for your PR.
I'm not sure I understand why this is needed. Is it possible to create a unit test that fails without it?

It's not indispensable. It just seems that the original developers wrote the code related to array instructions appearing in the coverage diff report above but forgot to actually use it.
Maybe a reviewer can confirm ?

Closing this as it needs to be replaced by a test-only PR.


Meet No module named 'Cython' while install in AWS EMR with pip

Describe the bug
Meeting Error "No module named 'Cython'"
while installing awswrangler with pip(pip3) in EMR
i think there's something wrong with the newest version
cause previous is ok

To Reproduce
Use pip(pip3) to install awswrangler in AWS EMR
pip install awswrangler

Same thing happening with Glue ETL Jobs using --additional-python-modules, likely from introducing C libraries.
https://docs.aws.amazon.com/glue/latest/dg/aws-glue-programming-python-libraries.html

Hi @dragonH @hwangji , thanks for reporting it.
For platforms without PyArrow 3 support (e.g. EMR):
pip install pyarrow==2 awswrangler
Or specifically for Glue PySpark Job:

Key: --additional-python-modules
Value: pyarrow==2,awswrangler

P.S. Also consider to freeze the Wrangler version for productive environments (e.g. awswrangler==2.3.0)

P.S. Also consider to freeze the Wrangler version for productive environments (e.g. awswrangler==2.3.0)

yes
this is what I did to overcome the issue
thanks @igorborgest 😊

P.S. Also consider to freeze the Wrangler version for production environments (e.g. awswrangler==2.3.0)

This is the solution!!

To anyone coming to this issue in late July 2021... there's an issue with awsrangler==2.10.0... you get a cython version error if you try to use it in an AWS Glue Job.. so use this
Key: --additional-python-modules
Value: pyarrow==2,awswrangler==2.9.0


One or more errors occurred- PBI Actions

Hello, I need help.
It is my first time configuring CICD for PowerBi reports in Azure DevOps. I use the PowerBi Actions extension to upload a pbix file into a new workspace using Service Principle for authentication. After I start deploying I get this error (One or more errors occurred.) I don't get an error code to troubleshoot. Error logs:
2021-12-03T09:43:36.4350017Z ##[section]Starting: Power BI Action: Publish
2021-12-03T09:43:36.4521929Z ==============================================================================
2021-12-03T09:43:36.4522769Z Task         : Power BI Actions
2021-12-03T09:43:36.4523128Z Description  : Release Task Power BI Actions
2021-12-03T09:43:36.4523417Z Version      : 5.4.24
2021-12-03T09:43:36.4523875Z Author       : Maik van der Gaag
2021-12-03T09:43:36.4524739Z Help         :
2021-12-03T09:43:36.4525068Z ==============================================================================
2021-12-03T09:43:37.7385014Z Starting Power BI Actions extension
2021-12-03T09:43:37.7692259Z ### Required Module is needed. Importing now...
2021-12-03T09:43:37.9347902Z ### Trying to import the incorporated module for PowerBI
2021-12-03T09:43:39.3885769Z Done processing Power BI Actions
2021-12-03T09:43:39.6949831Z ##[error]One or more errors occurred.
2021-12-03T09:43:39.7414806Z ##[section]Finishing: Power BI Action: Publish
Thanks,
Dina

@dafzali please add the variable system.debug and set the value to true. And then share the log with me

Hi Maik,
Thanks for your response.
The log is still the same after adding the variable system.debug.
2021-12-03T10:09:48.0675834Z ##[section]Starting: Power BI Action: Publish
2021-12-03T10:09:48.0824816Z ==============================================================================
2021-12-03T10:09:48.0825259Z Task         : Power BI Actions
2021-12-03T10:09:48.0825553Z Description  : Release Task Power BI Actions
2021-12-03T10:09:48.0825828Z Version      : 5.4.24
2021-12-03T10:09:48.0826102Z Author       : Maik van der Gaag
2021-12-03T10:09:48.0827370Z Help         :
2021-12-03T10:09:48.0827699Z ==============================================================================
2021-12-03T10:09:49.2214835Z Starting Power BI Actions extension
2021-12-03T10:09:49.2496301Z ### Required Module is needed. Importing now...
2021-12-03T10:09:49.4485975Z ### Trying to import the incorporated module for PowerBI
2021-12-03T10:09:51.0638420Z Done processing Power BI Actions
2021-12-03T10:09:51.4361438Z ##[error]One or more errors occurred.
2021-12-03T10:09:51.4709880Z ##[section]Finishing: Power BI Action: Publish

Thanks,
Dina

Coud you try adding the capatals System.Debug.
What kind of setup are youi using

The log doesn't change.
I have my Powerbi reports in Azure DevOps Repos and trying to configure CICD for all the PowerBi Reports. But now I have only one task in my release pipeline to get the file from the directory and upload it into my test workspace. When I run the release I get this error.
Thanks.

On what kind of agent are you running it. And could you share screenshots of all your configurations? Pipeline, Variables and Variable Groups

ReleaseLogs_32.zip
Here is the release log, I will share the configuration as well.

The problem was that I had selected the wrong organization type for my connection service ( Service Principle ) when I changed it, the issue was fixed and published successfuly.
Thank you for your support.
Dina

Hi @dafzali
I am also getting the similar error as yours while deploying the cicd pipeline to publish reports into power bi.
Below is the process I followed:
pipeline:

Release:

Could you please help me to resolve this issue?
Thanks in advance

Hi @kc2188 ,
I first added the variable system.debug and set the value to true, then I saw that the problem was with authorization for my service principle account, The problem was that I had selected the wrong organization type for my connection service ( Service Principle ) when I changed it, the issue was fixed and published successfully.


Docker image vulnerability

The latest docker image is vulnerable to CVE-2019-5021:
docker run -it microsoft/azure-cli:latest sh
/ # cat /etc/shadow | grep root
root:::0:::::
To fix, please build from a newer version of alpine:
https://alpinelinux.org/posts/Docker-image-vulnerability-CVE-2019-5021.html

@fengzhou-msft add to next Sprint.

@dwj300 Thanks for submitting this issue. The fix will be released with next azure cli version on 11/26/2019.


Keeps losing position in menu bar

Since at least Sierra, macOS lets us command-drag an item in the menu bar to a non-default position. BitBar menu bar items keep losing the custom position given by command-dragging however. Is there any way to prevent this?

Same here and I do not have Bartender. It happens on wake up (Sierra) and also if you choose the "Refresh all" command from the Preferences menu.

Took an evening to dig a little. The plugin menu items are torn down and set up whenever setupAllPlugins is called, which means the OS loses track of the custom positions when this happens.
This happens in a few different situations; the one I findmost annoying is when the system wakes up from sleep. The above PR fixes this case.

I built a bit on @sohocoke's work and re-added the "Refresh All" to the menu which just calls setupAllPlugins. So now it keeps position and refreshes without losing position. I left "Reset All" in there just in case you actually want to reset the positions...for reasons.
While I was in there I also made it a bit simpler to build.  The built application will be ./App/build/Release/BitBar.app. Enjoy.

What sets the initial order in the bar? I was assuming the scripts would be called in alphanumeric order and added to the bar as they finished... serially. However, I've had them appear in other orders after reboot. Adding in alphanumeric order would be nice... so this would work for setting the order in the bar... once and done...
00-tracker.10m
10-bandwidth-test-min.1h
20-ping-test-min.1m
30-ssh-menu.1h
40-brew-services.10m
No more "get whatever order you get... then cmd-drag them around... rinse... repeat..."

@neuronsong see #468

This is still broken / happening to me

The order of the items in the top bar appears to be unrelated to the file name, but rather determined by inode number (right-most being the lowest inode). Every time I've refreshed the bitbar, scripts are displayed in inode order. Tested on macOS 10.15.7. I have not tested for scripts with different refresh rates.
The inconsistent results users are getting when renaming files can be explained by people using either symlinks or script files directly. When renaming a regular file, the file does not get a new inode number. When renaming a symlink, a new inode is created.
A consistent way to set the order (tested with scripts that all have the same refresh rate) is to make symlinks to the script files in the correct order. Rightmost item symlink should be created first. If you prefer to use script files directly without linking, then use cp to copy each file in the correct order. Use ls -1i | sort -n to check whether the order is correct.

I'm not sure if the issue can be considered closed. The original question was not about the relative positions of Bitbar plugins themselves, but rather the position of the whole BitBar display (I only have one plugin), which seems to be always shoved to the leftmost position on the menu bar (and becomes hidden due to there being a huge number of menubar icons already) after MacOS wakes up from sleep.

Reopening
Still no solution though so 🤷♂

Update: Bartender actually worked in maintaining BirBar's position in the menu bar. Dozer didn't seem to work though.

Dozer works for me.

Dozer doesn't work.
Using Catalina.

Fixed it by the following steps:

Uninstall existing BitBar - delete it from Applications
git clone https://github.com/rashidkpc/bitbar.git && cd bitbar
git submodule init && git submodule update
make
The built app will be found in ./App/build/Release/BitBar.app.
Drag BitBar.app to Applications folder.


Add page numbers to concept list

When the concepts are turned into a proper Concepticon concept list, this should include page numbers to identify relevant scans with the source data.

Ah, @tresoldi, do you remember that we have the Koelle list already mapped? But since it was a bit difficult to deal with, we had it all on google drive, I think. Could you share the link here? Or let me know if you do not find it, I think it was @Kristina-Pianykh, who started to look into this list...

It is this one: https://docs.google.com/spreadsheets/d/10VrKzLbB65kSm7JYT4S7uJLqNR1jJZ6sESGECApMECg/edit#gid=223138965
I remember all the discussions about "nose ring" and all, and eye-balling it seems to be in line with the concepts.tsv I pushed in May. But I will double check and confirm with her and possibly @chrzyki .

page numbers (and thus scan numbers) are available in raw/test-koelle.csv


SW-2223 Keep state of current org in the url

allows us to share urls maintaining org context
centralized handling so devs can create links in code without worrying about populating the org id
some special handling for the welcome page alone as it switched between routing contexts
also updated the plants primary page (used by observations, dashboard) to avoid redundant calls to get/set preferences, noticed this while debugging

QA'd this locally a bunch. If anyone has time to give this a whirl.. will be super helpful.

@karthikbtf I'm trying to go to https://tree-location-web-git-karthik-sw-2223-terraformation.vercel.app/planting-sites/70?organizationId=23  from other org that I have selected (id=7), and the link get the org id changed to the one that I have selected (7). Is that the expected behavior? So I don't see the planting site

@karthikbtf I'm trying to go to https://tree-location-web-git-karthik-sw-2223-terraformation.vercel.app/planting-sites/70?organizationId=23 from other org that I have selected (id=7), and the link get the org id changed to the one that I have selected (7). Is that the expected behavior? So I don't see the planting site

Thanks for taking a look @constanzauanini . No that's the wrong behavior. Let me take a look.

@karthikbtf I'm trying to go to https://tree-location-web-git-karthik-sw-2223-terraformation.vercel.app/planting-sites/70?organizationId=23 from other org that I have selected (id=7), and the link get the org id changed to the one that I have selected (7). Is that the expected behavior? So I don't see the planting site

This should be fixed now, thanks for testing. Btw, the behavior you observed will happen - only if you don't have access to the org in the url (23). If you have access, it should switch to that org. Give it a try after the preview builds.

Code looks correct to me. I did some testing in Vercel and working correctly!

Awesome \o/ thanks! I will wait until next week before merging. In case others can QA.


Missing MIME type for file "."

I must manually add new mime type for "." file like "text/json", because of directory .well-known where available... but file in chalenges directory not !!!
letsencrypt.exe (1.9.0) on Windows 2012 stil write only error, that validation fails because of .well-known directory is not available from web
in your ZIP package is file Web_Config.xml with same MIME type... but I don't know what to do with this file

How are you running the app?
Did you read through the wiki article on the web.config file?

svecpetr, rename Web_Config.xml to web.config and then place it in the .well-known directory. Then, make sure to turn off the option in IIS that forces SSL connections for that directory.


Multiple Metric Health Rules

Waiting to hear if people want this

Yes we want to create health rule with multiple metrics by adding condition


fix: preview mode enable web3 param

WHY
after applying this other PR the usage of the URL param ENABLE_WEB3 for preview mode scenes got broken showing a Could not get a wallet connection Error: Invalid provider Metamask error.
WHAT
fixed old "metamask" authentication with new "injected" auth.
Thanks @pablitar for the awsome help.

@pbosio
Yeah, because when you enable web3, you need to log in exactly like in prod

Is it OK to have a "log in" button in Preview Mode?

If you don't use the ENABLE_WEB3 you are automatically logged in and don't see the buton at all =)


Support custom socket factory

As requested at https://github.com/ClickHouse/clickhouse-java/pull/1171#discussion_r1248335413

:tada: Thanks much @zhicwu  for creating this issue. I will keep an eye to see when this gets closed.

Thanks @zhicwu for working on this feature. Can we release this feature?

@mzitnik, can you or @zhicwu help to release this feature?

@zhicwu @mzitnik checking again here if this feature can be released?

@mayankvadariya Sorry for the delay. We are working on that having some issues in our release process. You can bypass it for now by building a local version. Again sorry for the delay

@mayankvadariya Sorry for the delay. We are working on that having some issues in our release process. You can bypass it for now by building a local version. Again sorry for the delay

Hopefully I can fix the issues in nightly and release two workflows in the weekend.

@zhicwu @mzitnik do you have any update on the release timeline?


Re-support glTF 1.0 premultipliedAlpha

Cesium used to support the glTF 1.0 premultipliedAlpha property. This was removed in 1.50 when we we updated the glTF pipeline:
https://github.com/AnalyticalGraphicsInc/cesium/pull/6805#discussion_r203855494
This would only work when OIT is disabled. See forum thread:
https://groups.google.com/d/msg/cesium-dev/6dCttPKnJWw/vxCNm2jEBAAJ
This breaking change was not mentioned in CHANGES.md, which made this much harder to find. It might be worth adding a note about it there too.

Using Cesium > 1.50 on iOS 12.x appears to always use premultipliedAlpha, no matter what value is specified in the GLTF model. On the other hand, Chrome on Windows 10 never uses premultipliedAlpha. This is a problem as it is impossible to use the same models and shaders on all platforms.

This is still an issue as of June 2019. Any chance of a fix coming soon or perhaps someone could give me a pointer on where to look so I could attempt to fix it myself?

@xtassin there was a recent fix where Chrome on Windows was incorrectly setting premultiplyAlpha to true, this was turned off in this PR: https://github.com/AnalyticalGraphicsInc/cesium/pull/7804
I imagine this is what's causing:

On the other hand, Chrome on Windows 10 never uses premultipliedAlpha.

Based on the discussion here: https://github.com/AnalyticalGraphicsInc/cesium/issues/7795#issuecomment-488043587 it sounds like always set premultiply to false was the intended outcome, so the fact that iOS is using premultiply is the problem here?

@OmarShehata yes, it appears iOS always requires premultiplied alpha. I am testing with an (old) iPad Air 2 with iOS 12.1.1

I would like to give an update: I have received screenshot from users on desktop where this problem is visible (wrong handling of pre-multiplied alpha). This would indicate that the issue may also be GPU/OS dependent. I will try to gather more details.

@OmarShehata, disabling orderIndependentTranslucency forces Cesium to use pre-multiplied alpha correctly on all platform. However, it creates other rendering issues that make it un-usable as a workaround in production.

I'm closing this issue, since as of 1.97 we're only providing limited support for glTF 1.0.


hyperdrive fuse-setup fails on macOS Catalina due to permission error

Running hyperdrive fuse-setup on macOS Catalina fails on the first go. In the terminal window, you see the error message Could not configure the FUSE module: Error 1: … @hyperspace/hyperdrive/bin/commands/fuse-setup.js:66:37….
Separately, a macOS alert tells you that system extensions by Benjamin Fleischer have been blocked.
To reproduce

On macOS Catalina, run hyperdrive fuse-setup

What should happen
FUSE setup should succeed.
What actually happens
FUSE setup fails due to a permission error installing system extensions.
Workaround
Manually go into System Preferences and grant permission for Bejamin Fleischer to install system software on your computer.
Suggestions/discussion

Document this issue under known issues.
Can this extension be signed so the error does not occur?
Looking into OSXFuse, it appears that the open source project is no longer maintained and the license is no longer open source (https://github.com/osxfuse/osxfuse/issues/616)

Relevant issue on OSXFuse: https://github.com/osxfuse/osxfuse/issues/595#issuecomment-504482599


Secret Must Be String

Looking at the fastify-jwt options, I thought this was configured correctly:
    "authorization": {
        "jwt": {
            "secret": {
                "private": {
                    "key": "-----BEGIN ENCRYPTED PRIVATE KEY-----\nMIIJ.........GoI\n-----END ENCRYPTED PRIVATE KEY-----\n",
                    "passphrase": "some-secret-phrase"
                },
                "public": "-----BEGIN PUBLIC KEY-----\nMII...........AAQ==\n-----END PUBLIC KEY-----\n"
            },
            "sign": {
                "algorithm": "RS256"
            }
        }
    }

I assumed this is what is needed in order to use an RSA key pair. Is there an example of how to do this?

Hi, you can use env variables in your config. So you can put your secret in an encrypted vault and specify the environment variable.
    "authorization": {
        "jwt": {
            "secret": {
                "private": {
                    "key": "{PRIVATE_KEY}",
                    "passphrase": "{PRIVATE_KEY_PASSPHRASE}"
                },
                "public": "{PUBLIC_KEY}"
            },
            "sign": {
                "algorithm": "RS256"
            }
        }
    }

I tried the following:
PLT_PUBLIC_KEY="-----BEGIN PUBLIC KEY-----\nMIICI............EAAQ==\n-----END PUBLIC KEY-----\n"
PLT_PRIVATE_KEY="-----BEGIN ENCRYPTED PRIVATE KEY-----\nMIIJ.......moGoI\n-----END ENCRYPTED PRIVATE KEY-----\n"
PLT_PRIVATE_KEY_PASSPHRASE='some-secret-phrase'

    "authorization": {
        "jwt": {
            "secret": {
                "private": {
                    "key": "{PLT_PRIVATE_KEY}",
                    "passphrase": "{PLT_PRIVATE_KEY_PASSPHRASE}"
                },
                "public": "{PLT_PUBLIC_KEY}"
            },
            "sign": {
                "algorithm": "RS256"
            }
        }
    }

getting the following error:
Error: Cannot parse config file. Unexpected token
 in JSON at position 481
    at DBConfigManager.parse (/home/hatem/Dev/work/dkp/api-v1/node_modules/@platformatic/config/index.js:173:13)
    at async loadConfig (/home/hatem/Dev/work/dkp/api-v1/node_modules/@platformatic/service/lib/load-config.js:46:25)
    at async start (file:///home/hatem/Dev/work/dkp/api-v1/node_modules/@platformatic/db/lib/start.mjs:13:29)

Hmm, can you encode them to the base64 and check if it works?

Anyway, IMHO it should work.

I encoded the keys to base64 and get the following:
 (index) │            path             │              message               │
├─────────┼─────────────────────────────┼────────────────────────────────────┤
│    0    │ '/authorization/jwt/secret' │ 'must be string {"type":"string"}'

I don't think it's setup to take the options the same way that fastify-jwt takes them.


Add character:  to font:

Character : b
Font : carlos

@choidf , the small b for carlos is the same as capital one. So would you like to work on something else? There are pending characters with the up-for-grab tag. Just request on the ones with no assignees and I will assign that to you.
If not then I will assign this one to you, no worries 😊


Failure to post the audit report should not be an error when running from Test Kitchen

Description
When developing a cookbook for use with audit mode, you may want to first run it through Test Kitchen. You'll likely get an ERROR message when chef-client attempts to post the audit report to the  server:
[...]
       Synchronizing Cookbooks:
         - audit_web_rhel (0.1.0)
       Installing Cookbook Gems:
       Compiling Cookbooks...
       Starting audit phase

       Finished in 0.00021 seconds (files took 0.46834 seconds to load)
       0 examples, 0 failures
       Auditing complete

       Running handlers:
       Running handlers complete
       Chef Client finished, 0/0 resources updated in 01 seconds
       [2016-03-21T13:32:43+00:00] ERROR: Failed to post audit report to server. Saving report to /tmp/kitchen/cache/failed-audit-data.json
       Finished converging <default-centos-72> (0m22.46s).
-----> Kitchen is finished. (2m15.26s)

I feel that ERROR is not the correct severity for this case because I don't expect there to be a server. The ERROR leads me to believe that something failed in one of my audit controls.
Perhaps WARN or INFO would be more appropriate here, or skip the upload process if if we can detect that we're running through Test Kitchen.
Chef Version
12.8.1
Platform Version
Discovered on CentOS 7.2, but applies to any platform.
Replication Case
Step 1: Create a cookbook.
$ chef generate cookbook TEST

Step 2: Modify .kitchen.yml to enable audit mode.
---
driver:
  name: vagrant

provisioner:
  name: chef_zero
  client_rb:
    audit_mode: :audit_only

platforms:
  - name: centos-7.2

suites:
  - name: default
    run_list:
      - recipe[TEST::default]
    attributes:

Step 3: Run kitchen converge.
$ kitchen converge

Client Output
https://gist.github.com/tpetchel/69cc5f17692ec93e174b
Stacktrace
N/A

This seems more like a test-kitchen enhancement (add enable_reporting = false to the generated config.rb) than a chef-client bug. Please file this request there.

The bug report though explicitly says they enabled reporting in their client_rb:
In my scenario we run chef-zero on our machines (not in tk), with audit reporting enabled and see this ERROR each run.
I think the right solution would be to detect chef-client is running in chef-zero and not ERROR, but INFO that audit data was saved in location xyz.


Basic Alonzo node

In order to have QA begin testing on an Alonzo capable node we have minimally integrated the Alonzo era such that a node can hardfork to the Alonzo era. No other functionality has been implemented i.e nothing cli related and only enough in the api to allow a hardfork.
Prerequisites:

https://github.com/input-output-hk/ouroboros-network/pull/2932 needs to be merged
Node configuration parsing for Alonzo needs to be integrated

After 2932 in ouroboros-network is merged, I can update the node deps in this PR and finalize this PR.

bors merge


latex rendering

using https://github.com/nteract/mathjax-electron.

Worth checking out Katex. MathJax's architecture is pretty insane so that may be a better way forward.

var mathjaxHelper = require('mathjax-electron')

var container = document.createElement('div')
container.innerHTML = '$$\\sum\\limits_{i=0}^{\\infty} \\frac{1}{n^2}$$'

mathjaxHelper.loadAndTypeset(document, container)

seemed pretty easy to me, but I didn't look into it apart from the fact that Hydrogen uses mathjax.

KaTeX is supported in the sp/docpane branches of ink and julia-client now. Was surprisingly easy to implement.


 You want to check the PHP code (feature) or test also JS code with the PHP code (acceptance test)?
For acceptance test you can check https://github.com/pionl/laravel-chunk-upload-example which contains tests in codeceptjs for supported Laravel versions.
For feature test - you should be able to send a request with a file (or mock the request). Should not be hard to do so.

I've not made any tests. But you can update readme if you want 👍


Make the output format more obvious to find

Prerequisites
Put an x into the box that applies:

[ ] This issue describes a bug.
[ ] This issue describes a feature request.
[x] This issue describes a documentation improvement request.

For more information, see the Contributing Guidelines.
Description
It took me a while to find the place in the repo to find the output format.  I've discovered this repo because someone at work was rejoicing that it supports tf-0.12.x now, and so I came to look and see what it is.
Actual Behavior
Confusion, lack of desire, uncertainty
Expected Behavior
Excitement, desire, feeling of "must have".
At least examples from the docs can be linked to from the Readme.md.  It would be nice if the markdown examples were previewable in github so you get a feel for what the rendered output looks like too.
Replication Case
Be someone who doesn't know what this tool is ;-)
Version
master

@iMartyn - I just stumbled on this tool yesterday and had the same frustration so I opened PR #216 which has a fix.
Even after I located the correct docs, I consistently had trouble returning to that page. A more robust job could be done (possibly remove USAGE_GUIDE.md or migrate content from docs/README.md), but I've at least proposed a minimal fix so users would always get to the right place.

Thanks @aaronsteers , we definitely need more documentation (well a lot more!). I was planning to circle back to it towards end of v0.9.0 when other more urgent fixes and implementations were done.


DRAFT - Panellists on the platform

Background
The functionality for managing panellists on the platform is on develop but needs to be iterated a little to include diversity data for panellists and additional contact details. Pending confirmation of the data necessary for the report and the provision of a spreadsheet containing all the panellists' details.
User Story
As Panel Liaison Manager, I would like to have all the panellist data stored confidentially on the platform so that a future Panel Diversity report can be delivered without manual intervention.
As an Admin user, I would like to have all the panellist data stored on the platform so that I can set up panels without having to manually set up the panellists on an exercise be exercise basis.
Feature(s) Description

[ ] Add the following fields in the database for Panellists: TBC
[ ] Amend Email (existing field) to JAC Exercise Email
[ ] Perform bulk upload of Panellist data to Firebase - spreadsheet to be provided
[ ] Pending response to question below

Outstanding questions

[ ] How are manually input user details used in exercises currently, e.g. are phone numbers/email addresses used in sharing documents or are they added to documents?

Acceptance Criteria (optional/delete if not used)
It's done when it is possible to fully manage panellist data on the platform - specified user can edit and update panellists' details and users can select panellists from a dropdown when setting up panels on exercises.
User Testing Steps
TBC
Feature Champion
Nick

Hey team! Please add your planning poker estimate with Zenhub @drieJAC @HalcyonJAC @tomlovesgithub @warrensearle


Parser failed

Hi, I have an issue with following log:
[error] Client(<IP_ADDRESS>:29031): Parser failed for {{badmatch,<<34,58,34,49,46,51,46,49,46,49,54,48,55,48,52,34,44,34,115,121,115,95,118,101,114,34,58,34,49,46,48,46,50,46,49,34,125,130,62,0,2,0,57,118,49,47,56,56,56,48,48,50,49,48,48,48,48,48,48,48,48,48,48,48,48,48,48,55,52,51,47,102,105,114,109,119,97,114,101,47,100,101,102,97,117,108,116,47,97,99,116,105,111,110,47,102,108,97,115,104,0,130,59,0,3,0,54,118,49,47,56,56,56,48>>},[{emqttd_parser,parse_frame,3,[{file,"src/emqttd_parser.erl"},{line,139}]},{emqttd_client,received,2,[{file,"src/emqttd_client.erl"},{line,260}]},{gen_server,try_dispatch,4,[{file,"gen_server.erl"},{line,615}]},{gen_server,handle_msg,5,[{file,"gen_server.erl"},{line,681}]},{proc_lib,wake_up,3,[{file,"proc_lib.erl"},{line,250}]}]}
18:27:57.804 ^[[1;31m[error] Client(<IP_ADDRESS>:29031): Error data: <<130,59,0,3,0,54,118,49,47,56,56,56,48,48,50,49,48,48,48,48,48,48,48,48,48,48,48,48,48,48,55,52,51,47,116,111,107,101,110,47,100,101,102,97,117,108,116,47,97,99,116,105,111,110,47,102,108,97,115,104,0>>
can someone help me about it? thanks a lot.

@congleetea, fixed?

No,  sometime it happened. I almost can not catch the error.

I have a similar issue, my client is connecting to the broker via lua https://github.com/geekscape/mqtt_lua
19:57:27.848 <0.2034.0> [error] Client(<IP_ADDRESS>:1152): Parser failed for {{badmatch,0},[{emqttd_parser,parse_frame,3,[{file,"src/emqttd_parser.erl"},{line,146}]},{emqttd_client,received,2,[{file,"src/emqttd_client.erl"},{line,247}]},{gen_server,try_dispatch,4,[{file,"gen_server.erl"},{line,615}]},{gen_server,handle_msg,5,[{file,"gen_server.erl"},{line,681}]},{proc_lib,wake_up,3,[{file,"proc_lib.erl"},{line,250}]}]}
19:57:27.848 <0.2034.0> [error] Client(<IP_ADDRESS>:1152): Error data: <<128,16,0,1,0,11,47,112,108,97,121,101,114,47,49,51,53,0,48,21,0,18,47,112,108,97,121,101,114,47,49,51,53,47,115,116,97,116,117,115,49,128,182,1,0,2,0,17,47,116,111,117,114,110,97,109,101,110,116,47,52,50,56,49,56,0,0,17,47,116,111,117,114,110,97,109,101,110,116,47,52,50,51,52,54,0,0,17,47,116,111,117,114,110,97,109,101,110,116,47,52,51,51,57,55,0,0,17,47,116,111,117,114,110,97,109,101,110,116,47,52,49,52,56,53,0,0,17,47,116,111,117,114,110,97,109,101,110,116,47,52,50,50,51,55,0,0,17,47,116,111,117,114,110,97,109,101,110,116,47,52,54,51,53,53,0,0,17,47,116,111,117,114,110,97,109,101,110,116,47,52,55,53,49,55,0,0,17,47,116,111,117,114,110,97,109,101,110,116,47,52,54,57,54,48,0,0,17,47,116,111,117,114,110,97,109,101,110,116,47,52,51,55,55,56,0>>

@BADBDY23, https://github.com/emqtt/emqttd/issues/575

<<128,16,0,1,0,11,47,112,108,97,121,101,114,47,49,51,53,0,48,21,0,18,47,112,108,97,121,101,114,47,49,51,53,47,115,116,97,116,117,115,49,128,182,1,0,2,0,17,47,116,111,117,114,110,97,109,101,110,116,47,52,50,56,49,56,0,0,17,47,116,111,117,114,110,97,109,101,110,116,47,52,50,51,52,54,0,0,17,47,116,111,117,114,110,97,109,101,110,116,47,52,51,51,57,55,0,0,17,47,116,111,117,114,110,97,109,101,110,116,47,52,49,52,56,53,0,0,17,47,116,111,117,114,110,97,109,101,110,116,47,52,50,50,51,55,0,0,17,47,116,111,117,114,110,97,109,101,110,116,47,52,54,51,53,53,0,0,17,47,116,111,117,114,110,97,109,101,110,116,47,52,55,53,49,55,0,0,17,47,116,111,117,114,110,97,109,101,110,116,47,52,54,57,54,48,0,0,17,47,116,111,117,114,110,97,109,101,110,116,47,52,51,55,55,56,0>>
parse result
{mqtt_packet,{mqtt_packet_header,8,false,1,false},
{mqtt_packet_subscribe,1,[{<<"/player/135">>,0}]},
undefined}
{mqtt_packet,{mqtt_packet_header,8,false,1,false},
{mqtt_packet_subscribe,1,[{<<"/player/135">>,0}]},
undefined}
{mqtt_packet,{mqtt_packet_header,8,false,1,false},
{mqtt_packet_subscribe,2,
[{<<"/tournament/42818">>,0},
{<<"/tournament/42346">>,0},
{<<"/tournament/43397">>,0},
{<<"/tournament/41485">>,0},
{<<"/tournament/42237">>,0},
{<<"/tournament/46355">>,0},
{<<"/tournament/47517">>,0},
{<<"/tournament/46960">>,0},
{<<"/tournament/43778">>,0}]}, undefined}

<<130,59,0,3,0,54,118,49,47,56,56,56,48,48,50,49,48,48,48,48,48,48,48,48,48,48,48,48,48,48,55,52,51,47,116,111,107,101,110,47,100,101,102,97,117,108,116,47,97,99,116,105,111,110,47,102,108,97,115,104,0>>
parse result
{mqtt_packet,{mqtt_packet_header,8,false,1,false},
{mqtt_packet_subscribe,3,[{<<"v1/888002100000000000000743/token/default/action/flash">>,0}]},
undefined}


Add filter to GetWorkflowExecutionHistory API

Add filter to GetWorkflowExecutionHistory API.
We need to provide functionality to allow customer filter on specific event type and certain event content

the issue is submitted in the wrong repo


[ci] Fix curl-cffi installation

Fix oversight in 02483bea1c4dbe1bace8ca4d19700104fbb8a00f
Template
Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

[x] I am the original author of this code and I am willing to release it under Unlicense

What is the purpose of your pull request?

[x] Core bug fix/improvement

Note: Commit as bug fix for ...


[SD-App] please add robo8080/SD_Updater_TestData

https://github.com/robo8080/SD_Updater_TestData

The app has been scheduled for rebuild

Compilation of this package failed, it has been labeled as invalid until the source of the problem is identified and addressed


Fix parallel buid errors in examples/elf

Summary

This PR fixes build errors in examples/elf in parallel build.
I applied the same logic in examples/posix_spawn/Makefile which adds an explicit context:: target.
Also, I modified tests/Makefile to avoid compiling incomplete symtab.c

Impact

This PR affects examples/elf only.

Testing

I tested this PR for maix-bit:elf configuration with -j1 to -j24 options.

Hi, @xiaoxiang781216,
I hope this PR fixes nightly build errors.

@masayuki2009 it seems that this build break relate to this change.
Configuration/Tool: spresense/elf,CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL

Cleaning...
Configuring...
Copy files
Select CONFIG_HOST_LINUX=y
Refreshing...
Disabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
Enabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
Refreshing...
Building NuttX...

arm-none-eabi-ld: hello++2.o: file not recognized: file truncated
make[4]: *** [hello++2] Error 1
make[4]: Target 'all' not remade because of errors.
make[3]: *** [helloxx_build] Error 2
make[3]: Target 'all' not remade because of errors.
make[2]: *** [tests/symtab.c] Error 2
make[2]: Target 'all' not remade because of errors.
make[1]: *** [/home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/apps/examples/elf_all] Error 2
make[1]: Target 'all' not remade because of errors.
make: *** [../apps/libapps.a] Error 2
make: Target 'all' not remade because of errors.

Hi, @xiaoxiang781216

it seems that this build break relate to this change:

Oh, really? But I thought this PR was merged after the nightly build started.
Actually, I can not see the change in the following log.
https://builds.apache.org/job/NuttX-Nightly-Build/61/consoleFull
Is my understanding correct?

Hi, @xiaoxiang781216

it seems that this build break relate to this change:

Oh, really? But I thought this PR was merged after the nightly build started.
Actually, I can not see the change in the following log.
https://builds.apache.org/job/NuttX-Nightly-Build/61/consoleFull
59 files changed, 689 insertions(+), 999 deletions(-)

'[' -d /home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/testing/../apps ']'
cd /home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/testing/../apps
git pull
Already up to date.

Not sure, we need upate cibuild.sh to print the last commit.

Is my understanding correct?

But the similiar issue, Haitao fix before:
commit 2f23d2a60284737c61539258f07964e2e77db0ef
Author: liuguo09<EMAIL_ADDRESS>Date:   Tue Feb 25 20:26:51 2020 +0800
examples/elf/tests: Correct symtab.c dependency to fix parallel build break

Correct symtab dependency from build to populate instead, or tests
subdirectory programs would be built twice which resulted in errors
as below:
arm-none-eabi-ld: hello++3.o: file not recognized: file truncated

@yamt and @liuguo09 modify examples/elf recently to fix the various parallel build issue. We need review these change again.

According to the PR merge time, the recent nightly build doesn't include it. So let's wait the next build result. I'll update cibuild.sh to git log the last commit anyway.

Hi, @liuguo09

According to the PR merge time, the recent nightly build doesn't include it.
So let's wait the next build result.
I'll update cibuild.sh to git log the last commit anyway.

Thanks for the comments. I understand.

Umm, unfortunately it still fails.
https://builds.apache.org/job/NuttX-Nightly-Build/62/consoleText
====================================================================================
Configuration/Tool: maix-bit/elf,CONFIG_RV32IM_TOOLCHAIN_GNU_RVGL
Cleaning...
Configuring...
Copy files
Select CONFIG_HOST_LINUX=y
Refreshing...
Disabling CONFIG_RV64GC_TOOLCHAIN_GNU_RVGL
Enabling CONFIG_RV32IM_TOOLCHAIN_GNU_RVGL
Refreshing...
Building NuttX...
riscv64-unknown-elf-ld: /home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/nuttx/staging/libapps.a(elf_main.home.jenkins.jenkins-slave.workspace.NuttX-Nightly-Build.apps.examples.elf.o): in function elf_main': /home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/apps/examples/elf/elf_main.c:357: undefined reference to g_elf_nexports'
riscv64-unknown-elf-ld: /home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/apps/examples/elf/elf_main.c:357: undefined reference to `g_elf_exports'
make[1]: *** [nuttx] Error 1
make: *** [pass2] Error 2
make: Target 'all' not remade because of errors.

Hi, @liuguo09

Umm, unfortunately it still fails.
https://builds.apache.org/job/NuttX-Nightly-Build/62/consoleText

Can we get complete build logs when build errors happened?
Because I can not reproduce the same link errors.
Also, can we manually trigger the build system with a specific configuration? (e.g. maix-bit:elf or lc823450-xgevk/posix_spawn)

Hi, @masayuki2009 ,
You could modify the apache nuttx nightly build Configuration 'Build ->Execute shell' to test:
Just as below, update to use your own fork testing repo, and update your cibuild.sh and testlist with only the elf config built. Then save the configuration.  Return back and click on the left 'Build now' button. If do not want email to nuttx devlist in your testing, you should also update the email setting in Configuration.
_if [ -d testing ]; then
rm -rf testing
fi
git clone https://github.com/apache/incubator-nuttx-testing testing
cd testing
./cibuild.sh -i -s ./testlist/full.dat_

The above steps may be hard for you to test : (
If so, I'll see if I could get the full build log firstly.

@liuguo09

The above steps may be hard for you to test : (

Perhaps, I understand how to configure the job but should I change the configuration for the test?
Because the job is used for NuttX-Nightly-Build, so it might be not good for the test.
What do you think?

@liuguo09

If so, I'll see if I could get the full build log firstly.

I found that we need to change nuttx/tools/testbuild.sh so that it can save build logs.

@masayuki2009
nuttx-parallel-build-oneshot in asf setup temporarily by xiang,  tried many times to reproduce, but it hasn't reproduced yet.  You may use it to test.
By the way, my testing cibuild.sh and full testlist commit here:
https://github.com/liuguo09/incubator-nuttx-testing/commit/3a2b79e24f049edb8ea656577c8288647b2cc595

You could update your testing accordingly.

@liuguo09

nuttx-parallel-build-oneshot in asf setup temporarily by xiang,
tried many times to reproduce, but it hasn't reproduced yet. You may use it to test.

Thanks, I'll try it later.

@liuguo09 @xiaoxiang781216

nuttx-parallel-build-oneshot in asf setup temporarily by xiang,
tried many times to reproduce, but it hasn't reproduced yet. You may use it to test.

I tried both without build logs (same as nightly build) and with build logs, I can not reproduce linker errors so far. Perhaps, it depends on the machine load.
However, I noticed that @xiaoxiang781216 was able to reproduced the error at
https://builds.apache.org/job/nuttx-parallel-build-oneshot/10/consoleText

@masayuki2009
In the 10th build log, I think it was because of build without https://github.com/apache/incubator-nuttx-apps/pull/120 PR. while in the following builds, I add the change.
As you said, the machine load may be reasonable. I wonder if there is chance that the 'mv symtab.c_tmp symtab.c' wasn't atomic and wasn't flushed in time?

How about merge https://github.com/apache/incubator-nuttx-apps/pull/120 PR firstly? I think your mv operation is necessary.

@liuguo09

In the 10th build log, I think it was because of build without #120 PR.
while in the following builds, I add the change.

I don't think #120 PR was effective. Because the latest nightly build still failed.
Also, I've not applied #120 PR for my tests but I can not sill reproduce linker errors.
Now, I've just changed a build machine from 'ubuntu' (actually H43 was assigned) to H27 which is used for the recent nightly build but still no errors.

@liuguo09

I don't think #120 PR was effective. Because the latest nightly build still failed.

I mean that the latest nightly build still has link errors in maix-bit:elf although I applied mv operation to symtab.c. However, I still can not reproduce the same errors with nuttx-parallel-build-oneshot.

You are right. It seems the mv operation to symtab.c reduces the probability of build break(from my local build, it is easy to hit the link error without mv operation), but it doesn't root cause the link errors in the latest nightly build.

@liuguo09 @xiaoxiang781216
Thanks for the comments, as I commented to #120, let's merge the PR #120.
However, we will need to find another root cause of link errors in the nightly build.
To find the root cause, I'd like to propose to remove both nuttx and apps repos as well in the nightly build configuration just like testing repo. Because we can not know previous states of the repos.

Hi, @xiaoxiang781216 @liuguo09
I've just reproduced link errors with my parallel build aging script.
https://builds.apache.org/job/nuttx-parallel-build-oneshot/35/consoleText
Can I login to the build machine (H43) ?

@masayuki2019 I guess it would be hard to login the apache build machine : (
I also repoduced locally by manually adding 'sleep 1' into mksymtab.sh in the current code base. From the build log, I think the link error is because of posix_spawn are built twice by pass1 and pass2 context build. In which the symtab.c produced by mksymtab.sh twice,  so it may be rewrited and compiled at the meantime.  And finally result in symtab.o not correct.

Hi, @liuguo09

I guess it would be hard to login the apache build machine : (

Oh, really..

I also repoduced locally by manually adding 'sleep 1' into mksymtab.sh in the current code base. >From the build log, I think the link error is because of posix_spawn are built twice by pass1 and >pass2 context build. In which the symtab.c produced by mksymtab.sh twice,
so it may be rewrited and compiled at the meantime. And finally result in symtab.o not correct.

I was able to reproduce the error by adding sleep 1 to mksymtab.sh
And also confirmed that https://github.com/apache/incubator-nuttx-apps/pull/120 is effective.
However, I was not reproduced the same error for examples/elf by adding sleep 1 .
Perhaps, examples/elf generates many elf files so it's more complicated than posix_spawn.

You should firstly revert your 'mv symtab.c_tmp symtab.c' for example/elf since it would reduce the build break possibility. After revert,  I reproduce it locally.

@liuguo09

You should firstly revert your 'mv symtab.c_tmp symtab.c' for example/elf
since it would reduce the build break possibility. After revert, I reproduce it locally.

Yes, that's why I pushed the commit and finally merged.
As you can see, there still have the same link errors for maix-bit:elf in the nightly build but I can not reproduce it with my parallel build aging test.

@masayuki2009 I use the paralle-oneshot nuttx build for some test. Please know it. Thanks

Hi @liuguo09,

I use the paralle-oneshot nuttx build for some test. Please know it. Thanks

No problem, thanks for letting me know.

@masayuki2009 @xiaoxiang781216 Please help to review https://github.com/apache/incubator-nuttx-apps/pull/127.  I think it is the root cause of elf/posix_spawn/module parallel build breaks. But still need verfiy. l am doing full nightly build in nuttx-oneshot-parallel build now.

@masayuki2009 @xiaoxiang781216 Please help to review #127. I think it is the root cause of elf/posix_spawn/module parallel build breaks. But still need verfiy. l am doing full nightly build in nuttx-oneshot-parallel build now.

Can you reproduce the same error by adding sleep in mksymtab.sh ?


USB DFU fixes

This patchset fixes the DFU firmware upload function and the support for DFU in composite mode. It also fixes the upload code in view of unifying the USB legacy and composite code (issue #10503).

no need for "subsys: " prefix in commits :)

Codecov Report

Merging #11027 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #11027   +/-   ##
=======================================
  Coverage   53.22%   53.22%
=======================================
  Files         217      217
  Lines       26668    26668
  Branches     5914     5914
=======================================
  Hits        14193    14193
  Misses      10059    10059
  Partials     2416     2416

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51c7b5f...2dc8182. Read the comment docs.

no need for "subsys: " prefix in commits :)

Ok, I just pushed a new version without it.

@aurel32 do you have plans to fix this for 1.14?

@aurel32 do you have plans to fix this for 1.14?

I think there is nothing to fix, it just needs a rebase. I have done one locally, but I still need to test it.

@jfischer-phytec-iot I have just rebased the PR.

@aurel32 would you apply @nashif suggestion from #12813?

@aurel32 would you apply @nashif suggestion from #12813?

I am just discovering that issue now. I'll add that patch in the PR.

@aurel32 would you apply @nashif suggestion from #12813?

I am just discovering that issue now. I'll add that patch in the PR.

Done.


Add Two Counter Metric in BigQuery Write Schema Transform

Adding two metrics, an input PCollection element count and one write failure count in BigQuery write schema transform. The metrics will be used for Syndeo monitoring integration.

@pabloem
@manavgarg

this seems reasonable. We may add more metrics to the elm/err counter, but we're good as-is for now, huh?

LGTM. LMK if we should merge

I'll probably change the name of each counter to be more descriptive of the IO type they are instrumented for. But that can wait till I add in Pub/Sub read metrics and I'll make the change. Think this is good for now. Feel free to merge it if you think It's okay!
Thanks @pabloem for all the suggestion!

Run Java_GCP_IO_Direct PreCommit

lgtm thanks @nickuncaged1201 !


Use WIT cache in List instead of fetching same WITs many times

This solution uses https://github.com/golang/groupcache to cache WITs
Here are some metrics of List execution time on my laptop:
100 WIs; 3-5 WITs ~ 12ms the very first time and 4ms every next one when using this cache.
100 WIs; 3-5 WITs ~ 44ms every List execution when not using the cache.
If you think we can use groupcache then I will add some unit tests.
Fixes #242

Can one of the admins verify this patch?

Here are some metrics of List execution time on my laptop:
100 WIs; 3-5 WITs  ~ 12ms the very first time and 4ms every next one when using this cache.
100 WIs; 3-5 WITs  ~ 44ms every List execution when not using the cache.
If you think we can use groupcache then I will add some unit tests.

I fixed the conflict and rebased the PR.

[test]

Using groupcache should be fine with our current code (it's behind an interface, anyway).
I tried to rebase the code and run into the following issue: We have restructured the transaction-related code in such a way that we create new instances of models.WorkItemTypeRepository for every request. So this is going to restrict the caching to a single request, which is bad. Your code uses a cache instance per work item type repo. What is the thinking behind this? Why not a global cache per application instance?

@tsmaeder thanks for reviewing the PR! :) It's a bad news for the current caching approach if we moved to creating a new models.WorkItemTypeRepository for every request.
Groupcache is designed to use a pre-defined get function to get a missing value in cache. It means that we have to provide a function that works with DB when we are creating the cache. Not when the cache is used. And we can't create the cache group using the existing WIT repository and use that cache globally because when the cache is used that WIT might not exist anymore.
When this PR was created there was the only one WIT Repository for the runtime and a few more where used in tests so it worked well. I will try to refactor this code and workaround this problem. Maybe we can pass WorkItemTypeRepository via cache context so the get function will use the passed WIT repo every time instead of pre-defined one. If it works then we can make this cache global.

Another option could be to introduce some global cache for all relevant objects like WIT, WI, etc. Instead of using immutable groupcache for immutable WITs only. I mentioned that in https://github.com/almighty/almighty-core/pull/359#issuecomment-253381709

@alexeykazakov I'm sure there will be more cachable things then just WIT, so I'm all for a global concept.

Rebased and resolved conflicts.

Replaced local WIT Caches (one per models.WorkItemTypeRepository) by a global WIT Cache.
Not sure if it makes sense to keep an instance of the Cache in a gormapplication.GormBase instance instead..
Next step would be to switch models.WorkItemTypeRepository.LoadTypeFromDB() to use the cache. And move real DB loading to an internal method.
@tsmaeder please take a look.

There is a simpler solution with a synchronized map: https://github.com/almighty/almighty-core/pull/497

Replaced by #497


Fix broken links in RULES.md

Describe the problem
Some links in the References section of RULES.md are broken. These links are important to understand what the validation problem is.
The broken links that were flagged so far are the following:

[ ] link to stop_times spec (there is an extra "s" character):

[ ] in stop_without_stop_time
[ ] in stop_has_too_many_matches_for_shape
[ ] in stops_match_shape_out_of_order
[ ] stop_too_far_from_shape_using_user_distance
[ ] stop_without_stop_time

[ ] all links that point to the Best Practice GitHub repo (the structure was changed in this PR)

[ ] I know the reference in missing_timepoint_column is broken, but there might be more

Please comment on this issue if you know of any others!
Suggest a fix or an alternative
No response

Hi!
Do you mind if I take this one? I'm a first timer looking to make any contribution I can!

Hey @dsaldonid,
Sure, go ahead 😊. Let us know if you find everything you need, you might want to check out our contribution guidelines.
Thanks for helping out!


Add a Gitter chat badge to README.md

rode/rode now has a Chat Room on Gitter
@RobertKelly has just created a chat room. You can visit it here: https://gitter.im/rode/rode.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

Decided to utilize github discussions for a bit.


[Bug] Comment Time

Bug: Time in comments is always showing a few seconds ago.

@GuptaTanisha update?

@GuptaTanisha update?

I am not able to sign up. Can't generate the OTP.

@sanjay270899 I tried to fix the bug. As I am not able to sign up. I have not verified whether the bug is fixed or not. Please check and update whether it is fixed or not.


feat: bolt struct point modify #0000

bolt point modify

Hello, what are you trying to achieve here?

Hi thanks for your reply
I mainly want to improve the structure pointer in the code

Thanks for the reply @xiongpan828. What are you looking to improve exactly?
What problem did you initially spot that this PR fixes?

I'm happy to reopen the pull request once we discuss in more details what motivates the changes (either in a discussion or an issue).


[WIP] .NET Beyond

Day 1 is in PT while Day 2 is in GMT. Also the newsletter subscribe button didn't work for me. The button just disappeared. On Safari. Not sure if that is just because it is in staging?

I did check it out on mobile Safari in iOS and the newsletter signup seems to work there at least. Can't check on desktop currently unfortunately.
Only feedback from my side is just echoing what @anthonyvetter said about day 2 being in GMT. Everything else looks great!

Per our conversation, these will be resolved in a follow up PR tomorrow, merging


Sometimes not sent back to Gallery after categories screen

Start Android gallery
Send a pic to Commons
Fill title/description, press OK
Fill categories, press OK
Window disappears, I am shown my home screen

Most of the time at step 5 I am sent back to the gallery, I think.
Log:
07-01 18:27:37.261   483   513 W OpenGLRenderer: Bitmap too large to be uploaded into a texture (4608x3456, max=4096x4096)
07-01 18:27:37.394   915   925 I art     : Background partial concurrent mark sweep GC freed 26605(1368KB) AllocSpace objects, 10(1464KB) LOS objects, 29% free, 37MB/53MB, paused 2.614ms total 195.285ms
07-01 18:27:37.396  1999  2233 I Adreno-EGL: <qeglDrvAPI_eglInitialize:379>: QUALCOMM Build: 10/21/15, 369a2ea, I96aee987eb
07-01 18:27:37.396  1999  2233 I OpenGLRenderer: Initialized EGL, version 1.4
07-01 18:27:37.506  1910 19392 E libprotobuf-native: [libprotobuf ERROR third_party/protobuf/src/google/protobuf/message_lite.cc:121] Can't parse message of type "mozc.commands.Command" because it is missing required fields: output
07-01 18:27:37.508   483   557 D EventLog$LogTask: EventLog hit https://www.wikimedia.org/beacon/event?%7B%22schema%22%3A%22MobileAppCategorizationAttempts%22%2C%22revision%22%3A5359208%2C%22wiki%22%3A%22commonswiki%22%2C%22event%22%3A%7B%22username%22%3A%22Tyuvc%22%2C%22categories-count%22%3A2%2C%22files-count%22%3A1%2C%22source%22%3A%22external%22%2C%22result%22%3A%22queued%22%2C%22device%22%3A%22LGE+Nexus+5%22%2C%22platform%22%3A%22Android%5C%2F6.0.1%22%2C%22appversion%22%3A%22Android%5C%2F2.4.2%22%7D%7D;
07-01 18:27:37.604  1999  2233 V RenderScript: 0xa095a000 Launching thread(s), CPUs 4
07-01 18:27:37.715   483   513 D OpenGLRenderer: endAllStagingAnimators on 0x9df88780 (RippleDrawable) with handle 0x9c97c020
07-01 18:27:38.145  1999  2233 W OpenGLRenderer: Incorrectly called buildLayer on View: ex, destroying layer...
07-01 18:27:38.145  1999  2233 W OpenGLRenderer: Incorrectly called buildLayer on View: ex, destroying layer...

Not really a problem but being back to the gallery is more convenient.

Wow, interesting. I've never had this happen. Could you paste a longer section of the logs if possible?

It actually sends me back to either Contributions or my external app, depending on whether I started the upload via the app or via my external app.


MAIN - B-18641 display backup address in office app

B-18641
INT PR
Upstream of B-18891
Summary
Adds the customer's backup address to the Customer Info card on the Move Details page for office users.
Verification Steps for the Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.

[ ] Has the branch been pulled in and checked out?
[ ] Have the BL acceptance criteria been met for this change?
[ ] Was the CircleCI build successful?
[ ] Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests

How to test

Most customers populated with dev_db_e2e_populate have a backup address so you likely do not need to create any new customers.
Access the office application
Login as a Service Counselor
Access the Move Details page and scroll down to the Customer Info card
Verify the Customer Info card has a line for Backup Address and that line contains the customer's backup address (compare to the address listed on the Move History page)
If the customer does not have a backup address set it should display an em dash.
Repeat for TOO, TIO, and QAE/CSR (they all use the same component, service counselor has their own component)

Frontend

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
[ ] There are no new console errors in the browser devtools.
[ ] There are no new console errors in the test output.
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
[ ] This change meets the standards for Section 508 compliance.

Backend

[ ] Code follows the guidelines for Logging.
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys.
[ ] Have been communicated to #g-database.
[ ] Secure migrations have been tested following the instructions in our docs.

Screenshots

Changes match those in INT


Access to encrypted ODS file fails

I have created an ODS file with LibreOffice Calc which I have protected with a password.
I opened this file as follows:
odfPackage = OdfPackage.loadPackage(document.getFile(), openPassword, null);
odfDocument = OdfDocument.loadDocument(odfPackage);

This still works. After that I try to get the MasterPage as follows:
odfDocument.getOfficeMasterStyles().getMasterPage("Default");

Unfortunately, I get this exception:
java.security.InvalidAlgorithmParameterException: Wrong IV length: must be 8 bytes long
	at java.base/com.sun.crypto.provider.CipherCore.init(CipherCore.java:525)
	at java.base/com.sun.crypto.provider.BlowfishCipher.engineInit(BlowfishCipher.java:222)
	at java.base/javax.crypto.Cipher.implInit(Cipher.java:843)
	at java.base/javax.crypto.Cipher.chooseProvider(Cipher.java:901)
	at java.base/javax.crypto.Cipher.init(Cipher.java:1433)
	at java.base/javax.crypto.Cipher.init(Cipher.java:1364)
	at org.odftoolkit.odfdom.pkg.OdfPackage.decryptData(OdfPackage.java:2052)
	at org.odftoolkit.odfdom.pkg.OdfPackage.getBytes(OdfPackage.java:1870)
	at org.odftoolkit.odfdom.pkg.OdfPackage.getInputStream(OdfPackage.java:2172)
	at org.odftoolkit.odfdom.pkg.OdfFileDom.initialize(OdfFileDom.java:219)
	at org.odftoolkit.odfdom.dom.OdfStylesDom.initialize(OdfStylesDom.java:79)
	at org.odftoolkit.odfdom.pkg.OdfFileDom.<init>(OdfFileDom.java:102)
	at org.odftoolkit.odfdom.dom.OdfStylesDom.<init>(OdfStylesDom.java:64)
	at org.odftoolkit.odfdom.dom.OdfSchemaDocument.getStylesDom(OdfSchemaDocument.java:436)
	at org.odftoolkit.odfdom.dom.OdfSchemaDocument.getOfficeMasterStyles(OdfSchemaDocument.java:536)

I am using the current code from the Master Branch.
During debugging, I became aware of the decryptData method in the OdfPackage.
There, in line 2027, the AlgorithmElement is read from the manifest.xml. It has the following content in my file:
<manifest:algorithm manifest:algorithm-name="http://www.w3.org/2001/04/xmlenc#aes256-cbc" manifest:initialisation-vector="qiWmy8seRpFOREHbrzhbag=="/>

After the Base64 decoding in line 2033, iv is then 16 bytes long.
Is it possible that in line 2048 we should use the algorithm from the manifest instead of the Blowfish? So in my case aes256-cbc?
Thanks,
Lars

yes, currently only the obsolete algorithms that were used > 10 years ago are implemented in ODF Toolkit; you'd need to add SHA256 and AES to read what current LibreOffice produces.

Okay, I'll try to change that.