Add integration test for div_precision_increment support

What problem does this PR solve?
Issue Number: ref #8834
Problem Summary:
What is changed and how it works?
Check List
Tests

[ ] Unit test
[x] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-all-tests

/cc @windtalker @SeaRise

/hold

/unhold

/run-all-tests


Remove unused metric name

The script created by the 01_Training_Script.ipynb notebook defines a variable name that is never used, which could be confusing:
# What to name the metric logged
metric_name = "logloss"

Those lines should be deleted.

Done in V2.1.0


Disable ccache for ubuntu-14.04/clang3.4 docker config

ccache isn't working there. Disabling it allows the build to work properly.
Fixes #1929

LGTM.

None of the failures shown are related to this PR.
Additionally, sanity is failing now because the LLVM APT repository is down, and has been down for more than 2 weeks. This is used in grpc_clang_format Dockerfile and we currently have no workaround.


[Enhancement]: DNN 10 Theme - Update color system to incorporate --dnn-color-variation-opacity and --dnn-color-surface-* and --dnn-color-*-<r, g, b>

Is there an existing issue for this?

[X] I have searched the existing issues

Description of problem
Updates have now been made to the new DNN color system and those changes need to be incorporated into the new DNN 10 theme.  The following CSS variables have now been added:

--dnn-color-variation-opacity (new CSS variable that can be used to handle opacity calculations)
--dnn-color-surface-* (new set of CSS variables to handle surfaces like "cards" or other layers on the z axis)
--dnn-color-*-r
--dnn-color-*-g
--dnn-color-*-b

The RGB numeric values are already there, but they were only there for the base colors.  Now RGB values will be available for all base colors plus their light, dark, contrast variations.
Before
    --dnn-color-primary
    --dnn-color-primary-light
    --dnn-color-primary-dark
    --dnn-color-primary-contrast
    --dnn-color-primary-r
    --dnn-color-primary-g
    --dnn-color-primary-b

After
    --dnn-color-primary
    --dnn-color-primary-r
    --dnn-color-primary-g
    --dnn-color-primary-b
    --dnn-color-primary-light
    --dnn-color-primary-light-r
    --dnn-color-primary-light-g
    --dnn-color-primary-light-b
    --dnn-color-primary-dark
    --dnn-color-primary-dark-r
    --dnn-color-primary-dark-g
    --dnn-color-primary-dark-b
    --dnn-color-primary-contrast
    --dnn-color-primary-contrast-r
    --dnn-color-primary-contrast-g
    --dnn-color-primary-contrast-b

Description of solution
Add new CSS variables listed above.
Description of alternatives considered
Many were discussed, but this was the consensus approach between several DNN community members during a live co-coding session on Sep 27, 2024.
Anything else?
No response
Do you be plan to contribute code for this enhancement?

[X] Yes

Would you be interested in sponsoring this enhancement?

[X] Yes

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Closing per #6202


Reusable StripInaccessible Utility Class

The StripInaccessibleRecipes class is a really great way of understanding how things work.
Along with that, it would be really great to have a reusable StripInaccessble class that contains all DML operations.
Since, the operations will stay the same irrespective of the use case, it would make more sense to have such a class.
That way, the developer has one less thing to worry about.
For example,
StripInaccessible.create(accountList); StripInaccessible.edit(accountList); StripInaccessible.remove(accountList);

@borkarameya thanks for filing this issue. I had the same thought about a month ago, and last week released a dedicated library that covers not only DML, but access checks in general. You can find the code, and installation/usage instructions here: https://github.com/codefriar/CanTheUser Note you'll want to specifically look at the Safely side of things. ie: Safely.insert(...) etc.


podvm: Attempt to fix missing policy

WIP: Can we even write to /run/ during podvm build? Since #1998 the default-policy.rego has been symlinked to point to /run/peerpod/policy.rego, but if you aren't using init data then this file doesn't exist. In this we try and make that file point to our default policy file to cover this case.
Note: I don't understand how this works for packer images at the moment, so I'm clearly missing something.

WIP: Can we even write to /run/ during podvm build?

i don't think so, /run should be tmpfs mount, no?

WIP: Can we even write to /run/ during podvm build?

i don't think so, /run should be tmpfs mount, no?

Yeah, that's what I thought, but it sounds like the other mechanism should do this, so I'll not continue with this path


[WFCORE-7074] Use the ModuleIdentifier.fromString() where a slot may …

…be used in a string module name.
https://issues.redhat.com/browse/WFCORE-7074

Perhaps this should also fix ExternalModuleService.addExternalModule. I believe the usage via GlobalDirectoryDeploymentService could incorporate a user-defined module name with a slot. It would be an edge case but I think the module name is the value part of a PathElement key/value pair, and thus could have a value like "foo:slot" or "foo:main".

Thanks @jamezp. This passed CI so we can deal with ExternalModuleService.addExternalModule separately.


[tsp-client] Sparse-spec issue in linux

$ tsp-client init -c https://github.com/Azure/azure-rest-api-specs/blob/90a65cb3135d42438a381eb8bb5461a2b99b199f/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml

Use output directory '/home/mharder/python-mh'? (y/n)
Using output directory '/home/mharder/python-mh'
tsp-client version: 0.1.0
Found emitter package @azure-tools/typespec-python
SDK initialized in /home/mharder/python-mh/sdk/contosowidgetmanager/azure-contoso-widgetmanager
Additional directories: specification/contosowidgetmanager/Contoso.WidgetManager.Shared/
Processing additional directories: specification/contosowidgetmanager/Contoso.WidgetManager.Shared/

Error: ENOENT: no such file or directory, lstat '/home/mharder/sparse-spec/s'

Closing as not an issue anymore


Can't load vue from webpack alias

I cant get vue 'vue/types/index'  from  like this,
//main.ts

import vue from 'vue'

But I want to use some vue plugin ,so I have to use vue from 'vue/dist/vue.esm.js'
.Not  from 'vue/types/index'。I add webpack alias but it doesn't work.

How cant I use both vue (js and ts) in my project ?

and some error like this

Sorry about the delay here; I bellieve you need to use allowSyntheticDefaultImports for this to work.


Is there gonna be any new release for the Orika core?

Orika has no new releases (fixing vulnerability and issues), recently. Is there gonna be any new releases for the same?

@prathamk I'm also interested when there will be a new release.


Genome List: AMR summary

Check the following genome list overview page. IT has total 100 genomes.
However, the number of resistance and susceptible genomes displayed in the
AMR graph and table are more than 100.
For every antibiotic, we need to count distinct genome ids for resistance/susceptible/intermediate genomes, not the total number of records in the genome_amr core.
-Maulik
https://www.alpha.patricbrc.org/view/Taxonomy/1763?eq(isolation_country,"Mali")#view_tab=overview

changed to unique genome count, but in some cases, we do have data for resistant and susceptible, so ended up going more than the total number of genomes.


Support for FillPercent/bbolt

Hello
I’m trying to find a way to specify the FillPercent value on the bbolt Engine without success.
The default value is 0.5, would like to put a 0.9. Do you know how to proceed through Genji when creating the db/bucket?
Thx

@asdine can you help me please? Thx

There is currently no way to customize the way the Bolt engine is running, besides the bolt options.
db, err := genji.New(boltengine.New("my.db", 0600, &bolt.Options{...}))

FillPercent must be set up manually on the required bucket on every transaction, which is not possible at this moment. Also, it would also mean that it should be table-specific, which is even more complicated.
Perhaps it would be interesting to be able to customize the engine further, with something like this:
db, err := genji.New(boltengine.New("my.db", &boltengine.Options{
  FillPercent: 0.9,
  Mode: 0600,
  Options: &bolt.Options{},
}))

but it means having a FillPercent value that would be the same for all buckets.
Could you describe why you need to have access to the FillPercent feature?

Well first thx for your answer!
It’s the first time I’m using bbolt and I’m adding a basic struct with 10 fields (mix of string/date/int) in a loop adding a total of 12,000 records and I end up with a DB size of 1 gigs. It seems to me that it’s big for the data I’m putting there...
I red on some forums that of the db is reaching a size it’s doubling the size with « blank spaces ». It’s allowing the dB to grow faster (scale better), but for the space it’s not optimal at all... and it seems this theory is good because I see the dB size growing like 32, then 64, 128, 256, 512 and then jumping directly to 1024 mbytes. On these forums people are saying that we can change the FillPercent per bucket, and putting a 0.9 value would solve the issue. That’s why I’m asking.
Hum won’t be proud of it but can I change something directly in the code of the package locally to make it possible? Like a hack I would say?

Oh just red again your second option it’s not an issue to have the same FillPercent for all buckets! So I can create the dB with a Genji.New()? I will give it a try as soon as I can.

Closing this as Bolt is no longer supported


New version: foxglove.studio version 1.4.0

Auto-updated by vedantmgoyal2009/winget-pkgs-automation in workflow run 411
Microsoft Reviewers: Open in CodeFlow

/azp run


Add Elm Games

Thanks for the great site!

Thanks! Thanks for contributing your work too! Your signal code looks great, btw. Did you find the Signal.mergeMany suggestion helpful?

 Yes, made the code that much cleaner and easier to understand for me. Thanks for the tip!


Support stylelint autofix

Stylelint works as a linter in ale, but it also features a --fix option for autofixing like eslint.
It would be nice to have it alongside the existing ale fixers.

It would be worth implementing #612 for this. I'll do it eventually.


Requirement version bump

Per https://github.com/mapbox/pxm-manifest-specification/issues/16

+1 LGTM.


[ffmpeg] update to <6.0>

Library name:ffmpeg
New version number:6.0
Other information that may be useful (release notes, etc...)
https://ffmpeg.org/
February 28th, 2023, FFmpeg 6.0 "Von Neumann"

I'm also very interested by having the port of ffmpeg v6.0, especially for the support of Intel's OneVPL (required to deal with hardware encoder/decoder of Intel CPUs gen 12+).
Some info from Intel about FFMPEG build instructions (https://www.intel.com/content/www/us/en/developer/articles/technical/onevpl-in-ffmpeg-for-great-streaming-on-intel-gpus.html) :
The switch to oneVPL from Media SDK in FFMPEG, is simple. Just substitute ‘--enable-libvpl’ instead of ‘--enable-libmfx’ in the configure stage of FFMPEG compilation.  Both options enable compilation of Intel® Quick Sync Video (*_qsv) codecs, which can be used without change from the FFMPEG command line or in applications.

Is there any progress for ffmpeg 6.0?

Is there any progress for ffmpeg 6.0?
Same question.

Bumping

Looks like 6.0 is pretty good

Looks like 6.0 is pretty good

Every patch need to be added manually by major edtion, no one is willing to do this...

I often feel puzzled about ffmpeg patches...

Fixed by #30135

Fixed by #30135

Works, thank you.

Ticket can be closed

cc @Neumann-A @BillyONeal


web3 jupyter js widget example seems to fail.

web and web2 examples work fine, with web3 I just see what is shown in attached screenshot.

This is definitely a bug.  The jupyter-js-services API may have changed under our feet.  I'll lock to a strict version in package.json, that should fix things.

In #414 I fix the version of jupyter-js-services, hopefully that does the trick....

I've confirmed #414 closes this.

Closed by #414


Skip cythonizing with no changes

To make it developer friendly.

I recommend using the ccache. You can reduce the compile time safety.

Thanks for the comment, but skipping compilation is still much more faster, isn't it?
On OS X Yosemite, ccache setup
brew install ccache
sudo ln -s /usr/local/bin/ccache /usr/local/bin/clang
sudo ln -s /usr/local/bin/ccache /usr/local/bin/clang++

1 without ccache
Using /usr/local/lib/python2.7/site-packages
Finished processing dependencies for chainer==1.6.2
python setup.py develop  33.12s user 2.20s system 97% cpu 36.118 total

2 with ccache
Using /usr/local/lib/python2.7/site-packages
Finished processing dependencies for chainer==1.6.2
python setup.py develop  8.25s user 1.43s system 97% cpu 9.967 total

3 skipping with no change
Using /usr/local/lib/python2.7/site-packages
Finished processing dependencies for chainer==1.6.2
python setup.py develop  0.82s user 0.44s system 95% cpu 1.330 total

Thank you for the presentation of evidence.
It is necessary to check environment variables and header files that in order to determine the skipping compilation.
We need a more safety method.
For example, to control this function by command line flag.

It is necessary to check environment variables and header files that in order to determine the skipping compilation.
We need a more safety method.

I see, that's reasonable. I added a command line option --cupy-only-changed to skip cythonizing if there're no changes.

I think that the calculation of md5 is not necessary for most users.
So, it is better that extra file is not made.

Ok. In that case, maybe there is no way to fix this issue.
And at the current master branch, the speed is fast enough, so this PR can be closed.


ElUpload feature

are there any posibilities to add ElUpload editable row?

Sorry, the upload component is not suitable for cells, you can use a custom template

actually ElUpload is still suitable for cells. :D

add button upload on edit
after upload response successful set the cell value to filename or path.. :)

anyway, thank you for pointing me the custom templates. nice to have that custom component

Could you provide some relevant links for reference? Because I don't know what functions the upload component should implement in the cell,  I can't be sure whether it can be supported or not?
https://jsfiddle.net/51ztmovb/

Thank you for the feedback.. sorry I'm trying to make working jsfiddle on this, but cannot. Here is what I do in my local screen reader
After getting response, probably replace the upload button with response filename from server.
It takes component from https://element.eleme.io/#/en-US/component/upload
Here is my custom template
import VXETable from 'vxe-table'

VXETable.renderer.add('ElUpload', {
  autofocus: '.my-cell',
  renderEdit (h, editRender, { row, column }) {
    return [
      <el-upload class="upload-demo" ref="upload" action="http://localhost:8000/api/upload"><el-button slot="trigger" size="small" type="primary">select file</el-button></el-upload>
    ]
  },
  renderCell (h, editRender, { row, column }) {
    return [
      <span>{ row[column.property] }</span>
    ]
  }
})

Sorry I'm, because the el-upload needs to cooperate with many events, and the requirements of each project may be different, I think it should not be supported, and it is easier to customize with the renderer

@xuliangzhan 类似这种的话，我要引入某个element-ui的组件，加入存在一个click，那事件怎么写呢？@click好像不行。


Read article "Choosing an architecture"

https://memo.bank/en/magazine/choosing-an-architecture

Should you use ES or not?

Explain a good example of a drawback of ES

shouldn't use ES on part of the system that needs strong consistency e.g. AuthN
dealing with eventual consistency
no breaking change, instead create a new version of event with backward compatibility

This article is not about how to choose an architecture pattern in the system. But actually, he mentions how he chose architecture for his core banking system.


Remove Amazon.Corretto.17 <IP_ADDRESS> to Amazon.Corretto.17.JDK <IP_ADDRESS>

Microsoft Reviewers: Open in CodeFlow

URL: https://corretto.aws/downloads/resources/<IP_ADDRESS>.1/amazon-corretto-<IP_ADDRESS>.1-windows-x64.msi
OK
(Automated message - build 910)


Add Past Enrollment Popup

Summary

Now that the enrollment history endpoint is implemented, we can bring back and improve the Past Enrollment popup.
Currently, the popup just displays the past enrollment graph of one quarter.

TODO

[X] Make a request to PeterPortal to get the enrollment history, and parse the response
[X] Create the popup and display an enrollment history graph
[ ] Add the ability to view the enrollment history of all other quarters
[ ] Cache responses
[ ] Add ZotTracker link

Test Plan

Verify this works for classes that had a class in the most recent quarter.
Verify this works for classes that haven't been offered very recently.
Verify this works for classes that have never been offered before.

Issues
Closes #341, #182

That's seriously hot 💯


solve the navbar toggle issue in small and medium screen + update cuu…

now navbar toggle issue of small and medium screen is solved.
https://github.com/user-attachments/assets/46d24f08-1ed3-482a-8fe4-a2b166f1169a
additionally i add the current ui of navar to all pages.
my issue no. is #4189

update cuu… ??

@abhi03ruchi  what i have to do

check deploy preview once .  changes arent visible .
add before and after pics .


Improve documentation of First Steps section

Hey I started to use newsboat today and I like it a lot!
I found it kind of hard to read through the documentation though (especially the "First steps" section).
Steps I took in this PR to (hopefully) improve the documentation:

"First Steps" section is restrucutred into a "First Steps" and a "Configuration" main section.
"First Steps" now has explicit "Add Feeds" and "First UI Interaction" subsection.
"Configuration" is basically paragraphs from the previous "First Steps" section with some headings.
"Key Bindings" in the "Configuration" section now contains the information from the bind-key configuration command documentation (I found it hard to find the values for the dialog argument before)
Some Paragraphs which contain good information but do not directly contribute to the documentation topic are moved into "Info boxes".
Some texts are rewritten to be more concise.

I hope that no information was lost on the way, but I really took care to keep everything.
If you find this useful, please consider merging.

Oops, just realized that the "First Steps" section is also used in the man page.
Should I try to split every new section / subsection into a separate file and integrate it to the man file?
Or keep the old file for the man page? (Probably too much overhead to maintain two versions?)

I like the intent here! Thank you for the work. I ran out of time reviewing though, but I'll continue on Sunday.

Thanks for your review and approval @Minoru and @der-lyse. Glad the changes seem useful! :slightly_smiling_face:

Coverage remained the same at 59.333% when pulling ccac45bdf979507fc8a05aaf7f7e160b5880bd14 on sebashwa:improve-documentation into 30bd64534ca7a17f0d5e1a32f7cedc455430ce38 on newsboat:master.

Thank you very much for all this work, @sebashwa, and congratulations on your first contribution to Newsboat! This will get auto-merged in a few minutes.

Thank you very much for all this work, @sebashwa, and congratulations on your first contribution to Newsboat! This will get auto-merged in a few minutes.

Thanks! And thank you for the useful feedback and for maintaining this tool!

Hey @Minoru just FYI this didn't get merged automatically, I think because of some CI failure. I have no idea why the CI task failed though. Can you have a look or help out how I can fix this? Thanks!

Yeah, sorry, FreeBSD release that we were using in CI was EOLed, which broke the build. Fixed now :)


"Node globals cannot be used in browser"

The call stack traces to this library.
Error occured when running yarn dev and opening up localhost:3000
node version: 18
OS: macOS M1 chip
framework: NextJS (should be obvious but mentioning just in case)

Whoops! Actually, it points to the openai-streams library

omg 🤣 I thought I was in the nextjs-openai repo when I closed this, but I wasn't. Oh well, I made a duplicate issue

lmao no worries, we'll talk on the other thread


App Login isn't working

Login to the app doesn't work, shows there was some error.

assign to me


Properly decode UserData before adding to new slaves

I tested this PR by adding slaves to an existing cluster and confirming that the UserData attribute is not gibberish.
Fixes #303.

@dhorgan - Test this out and let me know if it fixes the problem for you.
I'm curious to know also if you have any issues with UserData when using spot instances.

I've just tested this and I can confirm that it's working now! 👍

I'm curious to know also if you have any issues with UserData when using spot instances.

Sorry, I can't help here - we aren't using spot instances right now.

No worries. Thanks for confirming on your end.
I tested out spot instances just now, and adding a spot slave preserves the UserData attribute correctly.
Merging this in.


Climate Thermostat

Good evening.
I have a TH-20 thermostat, it is forwarded to HA using your integration, but the temperature scale in it is 1-99.
In it I can specify the lower switch-on temperature and the upper switch-off temperature.
Please tell me if it is possible to add changes to the temperature range in the thermostat map so that you can set it yourself.
Or the ability to set a target temperature with automatic setting of the upper and lower hysteresis thresholds for a given thermostat.
Thank you.

So far I have solved the problem in the same way as in the picture below, but as I understand, after the update everything disappears.

I have a similar problem.
I use the Th16 for a refrigerated showcase that should work -5 /+5 degrees. Is there a way to set a negative temperature

У меня аналогичная проблема. Я использую Th16 для холодильной витрины, которая должна работать при -5/+5 градусах. Есть ли способ установить отрицательную температуру?

Try installing - 5, 5


[Bug] Rouge padding on bottom of MessageList / ListView.builder

Describe the bug
There is a rogue padding at the bottom of the ListViewBuilder. It looks to be added from the SilverPadding.
See: https://api.flutter.dev/flutter/widgets/ListView-class.html
"By default, ListView will automatically pad the list's scrollable extremities to avoid partial obstructions indicated by MediaQuery's padding. To avoid this behavior, override with a zero padding property."
This also leads to un wanted jumping when coming in and out of the input as there is no padding added when focused in the input.
To Reproduce
Steps to reproduce the behavior:

Spin the example app up
Go to basic example
Observe extra padding at the bottom of the list

Expected behavior
No extra  padding to be on the bottom of the list.
https://user-images.githubusercontent.com/825344/216580839-d4dc211b-0d2c-4566-acda-1a200cb7c0d9.MP4
Screenshots
Broken:
https://user-images.githubusercontent.com/825344/216580791-f634d1d8-8880-4451-8b58-1f2695358427.MP4
Environment

OS: Mac
Device: iPhone 14 Pro
Flutter Version: 3.7
Software/library Version: latest

Additional context
I opened a PR to fix this: https://github.com/molteo-engineering-team/Dash-Chat-2/pull/38

PR to fix this: https://github.com/molteo-engineering-team/Dash-Chat-2/pull/38


Industrial and Advanced Welders

About the PR

Adds the industrial welder with a capacity of 250u (vs 100 for standard welder and 1000 for experimental welder).
Also adds the advanced industrial welder which is the same capacity as the industrial but with a 1.3x speed bonus so it's faster at welding stuff.
Increases the chance of the regular welder to appear in the welding supplies locker from 0.1 to 0.7 (like the engineer locker).
Adds the industrial welder to the welding supplies locker at a 0.5 probability.
Added the adv welder to the salvage crate as possible loot at 10% chance. In future it can be science related.

Screenshots

Top to bottow: Experimental, Adv industrial, industrial, standard, mini (emergency).

Changelog

:cl:

add: Added the industrial welder and advanced industrial welders to the game. Larger capacity and the advanced is faster at welding.

why would emergency welders even exist? i've never seen anyone use them

why would emergency welders even exist? i've never seen anyone use them

They already exist and they're in the emergency tool box (or have a chance to be) iirc. They're slower than a regular welder but are pocket sized. Big welders are not.


a scroller bug in ScrollableEditText?

For a large text file, it can't scroll smoothly.
I think the reason is missing postInvalidate(), fixed as follows:
    override fun computeScroll() {
        if (!isInEditMode) {
            if (textScroller.computeScrollOffset()) {
                scrollTo(textScroller.currX, textScroller.currY)
                postInvalidate()
            }
        }
    }

OMG I tried to fix this so many times and it was just a one line, thank you so much 🙏


Typos in the code

Misprints in the code in English. Ich habe dein Deutsch nicht überprüft. Ich denke, dein Deutsch perfekt ist.

damn, how many eyes do you have 😁  but that's how software testers are, i know a few

will review this tomorrow 😭

Was glad to help😁, there are still prints in the code with extra spaces and code formatting.
But it does not affect the work of the code.

hope nothing is overlooked 😁
https://github.com/builtbybel/ReadySunValley/releases/tag/0.40.0
unfortunately i only have two eyes


blank screen on build

Something related to https://github.com/SimulatedGREG/electron-vue/issues/457
I'm building my app with electron-builder.
yarn dev works fine, but the build give me the following error.

Here the error is obvious. It searchs for electron/index.html/style.css instead of electron/style.css
Where this bug could come from ?

Node version: v10.4.0
NPM version: YARN 1.7.0
Operating System: macOS sierra 10.12.6

How are you bringing in the CSS file? Are you using SASS?
If you're using sass, you should just import the SCSS code like so in the App.vue file:
<style lang='scss'>
    @import './scss/app';
</style>

Then your CSS should be automatically injected into the head of the DOM.

This isn't really even nearly enough to reproduce the issue, so I'm exactly not sure how anyone would solve this for you.

For those with the same error, it was something else a little tricky.
I had a mistyping in the URL I was loading. I added by mistake a trailing /.
When you yarn dev, your url is localhost:some_port, so adding a '/' does not matter. But when building, you use the index.htlm endpoint, and you should not add any '/' behind, or electron builder think it is a dir, and search from 'index.html' and not from root '/'
So, just mistyping js bug business as usual, just use Typescript :)


Allow public subnets in AWS MachinePool

To be consistent with install config, allow public subnets to be
specified in MachinePool even if the MachineSets created would use only
private subnets.
Account for success in all of the following cases:

No subnets specified
Only private subnets specified
Both public and private subnets specified

Private subnets are required to be exactly one per availability zone if
subnets are specified. If public subnets are also specified, then there
should be exactly 1 public and 1 private subnet for each availability
zone.

/assign @akhil-rane
/cc @abhinavdahiya

This looks good to me. @abhinavdahiya over to you :)

This looks good to me. @abhinavdahiya over to you :)

mostly cosmetic suggestions.
/lgtm

mostly cosmetic suggestions.
/lgtm


Sync pods manually or automatically

Is your feature request related to a problem? Please describe.
List of files and folders are cached during pod open and displayed every time we interact with the pod. If we upload something from fairdrive, we would not see the changes unless we remount.
Describe the solution you'd like
we sync pod automatically after a certain interval, also allow user to manually sync pod.
Describe alternatives you've considered
No response
Additional context
No response

600s  or 60s interval ?
It does take some time when amount of files is big


lock keyword: let arg_{read,write} caller determine locking

Instead of unconditionally opening files with lock=false, this allows the caller of arg_read or arg_write to pass a boolean lock keyword argument to determine whether IOStream objects should do per-operation locking or not. For IOStream objects created by opening a file, this calls open with the lock keyword. For IOStream objects passed into the arg_read or arg_write call, if lock=false the IOStream is locked once for the whole operation and then the _dolock field is set to false and restored upon termination of the block.

@vtjnash, I can't officially request a review from you since you're not a member of JuliaIO (I've invited you, so you can join), but if you could please look at this and let me know if you approve of my use of I/O locking here.

It seems like many of these could be unspecified kwargs, so that they don't need to be explicitly documented?

Bump @StefanKarpinski @vtjnash What is the status of this PR?

Status is incomplete, pending feedback from @vtjnash on how to do this correctly.

I think the main discussion was around making this ;kwargs... and forwarding it everywhere consistently

That doesn't really make much sense as the keywords can only be forwarded to open and all the other keywords that open takes would break the package. Even lock cannot consistently be forwarded.

Bump.
@vtjnash Could you clarify what you mean about forwarding the keyword arguments?
If I understand correctly, @StefanKarpinski is waiting on you to elaborate before he can implement the necessary changes.

We also could remove lock from the proposed future API. The current shape of the design seemed to be optimally confusing, as it sometimes forwards an argument ("lock") that sometimes does something and sometimes changes the behavior of other functions.

@StefanKarpinski Does that answer your questions, or do you need further clarification?

No, it doesn't.

We can just not do this API change. As far as I'm concerned, the status quo is fine: someone might pass an IO object into one of these functions and then try to also use it from another thread, but a) I suspect that's unlikely and b) if that turns out to be a real problem, we can revert https://github.com/JuliaIO/ArgTools.jl/commit/641aa3f8dccbd910684849e6b2c5ec33c7570409 and it will fix the crash at the cost of making byte-oriented I/O slow again. Or maybe by then the compiler will be smart enough for it not to be so slow.


NIAD-2046 - Quick fix of null handling

-> Secured an optional field from passing null

Moved to one-commit-pr -> #78


examples: fix mingw build error

M_PI was not declared error solved

M_PIis used in deg2rad(). There is already such function in tvgMath.h. Maybe it would be better to include tvgath.h to factorize code

@vtorri tvgMath.h is used internally and cannot be used in examples. We could potentially introduce tvg::M_PI, and remove all  #define _USE_MATH_DEFINES but that's a separate problem to deal with.


Cartoonify Added

Pull Request Template

Please Fill all the details. It will help us to track issues and Pull Request.

I have added the Cartoonify script.
Issue no.(62t) -
Self Check(Tick After Making pull Request)

[x] This issue was assigned to me
[x] One Change in one Pull Request
[x] My file is in proper folder
[x] I am following clean code and Documentation.
[x] I have added README.md with my script

Add your Script|Author_Name|ShortItroduction in Main README.

Done.


Validate crates package ownership

What is it?
If a user enters a crate into oss-directory, we should validate ownership first in our GitHub app.
We can either use the Crates API here
https://doc.rust-lang.org/cargo/reference/registry-web-api.html#owners
Or if we need to, we can use a database dump in our BQ https://github.com/opensource-observer/oso/issues/2380

FYI, the API is rate limited to 1 request per second
https://crates.io/data-access
They aggressively block if you abuse


misleading job status ?

What happened?:
@jdelfino is across a leak problem with storage container that gets progressive worse on subsequent runs with provence when the outsize size is large (order of GBs). This is something that might be fixed with 1.8 may be.
But on the back of it, I am seeing a strange thing, this particular job never finishes in spite of iterating through all datums mostly successfully).
$ pachctl  list-job | grep  PX | grep  runn
5db569d7fae349c7bda9f18653a7d455 PX/5b9b487e19174e43b0b0414ea441e29f           26 hours ago 25 hours      0       0 + 56068 / 56068    0B       0B       running
1269a2021f4d4afba345fda920e45269 PX/82a9cf4eee8d41b7aeef97fdf8e9508c           2 days ago   2 days        1       0 + 56068 / 56068    0B       0B       running
da5af8a2f31b4323ab7ef3b3dd038736 PX/4ac130f8afa34621adf2260dfecd38dd           3 days ago   3 days        1       0 + 56068 / 56068    0B       0B       running
485b1b81fd974151a1dca053276bb33e PX/af4382e9548348cab18c594a229be6d4           3 days ago   2 days        1       0 + 54237 / 54237    0B       0B       running
06f5572aeec94c32b02f75ce3fca9ead PX/c60db28d0d7d437b8b7653e6237f094f           4 days ago   4 days        1       0 + 54237 / 54237    0B       0B       running
0cbd898d295f4f5c9c424f65069fd38c PX/e00fdfbb03b34186a7d60092ed80904b           4 days ago   4 days        1       0 + 54237 / 54237    0B       0B       running
2011207305874e13a85254c4695a4290 PX/9169c2056f8747db962d6cbb1be0b3c2           5 days ago   4 days        1       0 + 54237 / 54237    0B       0B       running
817c350c526147e6b1ac727beda7e013 PX/6885dfdafd0647398bed1679a563282e           5 days ago   4 days        1       0 + 54237 / 54237    0B       0B       running
3a0bea054af74d128b9b64756c638443 PX/3086c6b4cbd649a69366f10d8c4c6835           5 days ago   4 days        1       0 + 54237 / 54237    0B       0B       running
c7ec7d34115b4c7fa75cedaeea814064 PX/a008aaba91e748b2966f0eabfb49a3bf           5 days ago   4 days        0       215 + 53712 / 53927  780.5MiB 960MiB   running
a8b6f877c0b94ac7bd752791cb6c8b55 PX/ed6a9c5f5f2746769f696a67e8f8790f           5 days ago   5 days        0       133 + 53535 / 53668  482.8MiB 593.4MiB running

and when I stop job, It tell me its already finished.
$ pachctl stop-job 485b1b81fd974151a1dca053276bb33e
error from StopJob: commit PX/af4382e9548348cab18c594a229be6d4 has already been finished

How can I check if the job is actually running or superficially running?
What you expected to happen?:
Not sure what correct job status is
How to reproduce it (as minimally and precisely as possible)?:
Create a pipeline that churns through massive dataset, first job passes successfully but subsequent jobs causes leak in storage container, leading to OOM kills of pods by K8s.
Some jobs completes others never does .. leaving a trail of OOM killed pods.
Not sure about details, but when this happens, may be job status is often misleading ?
Anything else we need to know?:
Environment?:

Kubernetes version (use kubectl version): 1.11.2
Pachyderm CLI version (use pachctl version): 1.7.5
Cloud provider (e.g. aws, azure, gke) or local deployment (e.g. minikube vs dockerized k8s):
OS (e.g. from /etc/os-release):
Others:

@suneeta-mall I think what's going wrong here is that the code that marks jobs as finished isn't as fault tolerant as it could be. The oom-kills prevent the job from getting marked as completed despite the fact that  the output is getting materialized. We'll look at fixing this, in the short term you can tell if jobs are completed if their output commits have been finished and you should be able to read the data out of those commits.

@jdoliner ah that makes sense. Thanks
Is there a trick to getting subsequent pipeline triggered as well (whilst this pipeline is in sort of hung state)?  I suppose not (other than manually branching off) but keen to hear your thoughts


cast decimal to double option

Just found out that Arrow JS has a open issue where negative decimal types do not work properly (link)
Maybe its good idea to add a fourth cast option similarly to PR #476 called castDecimalToDouble? I can do another PR for it?

Sure, sounds good! We can just add a deprecation warning later when they are resolved. 👍🏻

Weird negative number will be solved in apache-arrow 13
https://github.com/apache/arrow/pull/35067


some network connection states have weird capitalization

in the "state" list, parts of the possible values have been converted to lowercase:
> The possible states are as follows: CLOSE_WAIT CLOSED ESTABLISHED FIN_WAIT_1 FIN_WAIT_2 LAST_ACK listEN SYN_RECEIVED SYN_SEND timeD_WAIT for more information about the states of a TCP connection, see Rfc 793.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 32e22509-0790-98ec-29f0-f4a45af86079
Version Independent ID: a8481c2f-a27e-ecff-6c79-0e4f63ce18a4
Content: netstat
Content Source: WindowsServerDocs/administration/windows-commands/netstat.md
Product: windows-server
Technology: manage-windows-commands
GitHub Login: @coreyp-at-msft
Microsoft Alias: coreyp

Thanks for the feedback. I notice this has been corrected in this commit: https://github.com/MicrosoftDocs/windowsserverdocs/commit/05d5af3f69ee8c235be86a28365859a8658a866c
#please-close


Error on CompressionLevel=None

If I try setting CompressionLevel to "None", I get an error:
CbzMage error:: InvalidOperationException: Failed to convert configuration value at 'CompressionLevel' to type 'System.IO.Compression.CompressionLevel'.

Thank you for my very first bug report :)
That's a typo in the appsetting.json documentation. The correct parameter is "NoCompression". I'll update the release.


pull request for e2e test at 12/14/2016 20:56:09

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[graphiql] Don't render newlines in documentation strings

Long documentation strings that contain a newline are rendered as is in GraphiQL. This makes reading them a bit confusing and disjointed.
Doc pane

Tooltip

In the original schema this looks like this:
    """
    Bearing, in degrees, clockwise from North, i.e., 0 is North and 90 is East. This can be the
    compass bearing, or the direction towards the next stop or intermediate location.
    """
    heading: Float

I would love it if these doc strings, which in our case can be multiple paragraphs, be treated like markdown. This would mean that a single newline is ignored and a double newline treated as a new paragraph.
Thank you for making this wonderful piece of software.

thanks @leonardehrenfried ! this is a great suggestion. packages/graphiql-react/src/markdown.ts is where we keep the configuration for markdown-it, and iirc, this is just a simple config tweak or plugin away from happening!

will be fixed in graphiql v4


Handle Notification of unknown alarm

Currently the admin GUI just logs and ignores notifications about Alarms with names that do not match any alarm name in the Alarms (registration) cache:
https://github.com/JeffersonLab/jaws-admin-gui/blob/39eecd8f56b4ce4877f386fecd6937ca0f2a8c0f/src/main/java/org/jlab/jaws/business/session/KafkaNotificationFacade.java#L64
We should probably make these notifications available to users on the interface somehow.  Perhaps:

Insert a new Alarm registration dynamically.   This is problematic because currently there are many required fields we won't have values for.  We could create "UNKNOWN" placeholders in the ACTION, COMPONENT, and TEAM columns, but that sorta defeats the whole purpose of defining constraints.  Perhaps make the fields nullabe?
Dump the records into a separate "dead letter queue".  This has some management cost.  Maybe a circular queue?    Users would need to know to look in the queue periodically.

Fixed in v4.6.9


Get everyone as a collaborator.

please comment below with your irl name.

[x] Ryan Ang
[ ] Stephanie Bui
[x] Daniel D'Souza
[ ] Cameron Dudley
[ ] Rie Hinze
[ ] James Hutchins
[ ] Haisheng Lin
[ ] Jaime Romero
[ ] Vincent Rose

rang1 is Ryan Ang

Jaime Romero

Vincent Rose

Haisheng Lin
On Thu, Sep 17, 2015 at 8:40 PM, vinnybod<EMAIL_ADDRESS>wrote:

Vincent Rose
—
Reply to this email directly or view it on GitHub
https://github.com/daniel-dsouza/CSE360/issues/1#issuecomment-141335101.

James Hutchins

Stephanie Bui

Rie Hinze

i want to close this, I'll assume Cameron knows what to do.


tidy consumables resouce files

This PR tidies up some old files to do with Consumables.
I also investigated some issues as I was doing this and have the following observation and suggest Action points.

As noted by @EvaJanouskova and @joehcollins , whereas the item_code = 280 is defined as  "Diazepam 5mg_1000_CMST" (per resources/healthsystem/consumables/ResourceFile_Consumables_Items_and_Packages.csv), there is an entry in the file resources/healthsystem/consumables/ResourceFile_consumables_matched.csv that associates this item_code with "Endoscope" (line: 464). This seems not to cause any problem except confusion (the same file says there is no match for Endoscope). The question is: why does that file seem to say that 'Endoscope' has that item_code? I don't think there is any action to take here.

The script scripts/data_file_processing/healthsystem/consumables/consumable_resource_analyses_with_lmis/consumables_availability_estimation.py  (which generates ResourceFile_Consumables_availability_and_usage.csv and ResourceFile_Consumables_availability_small.csv) does not run all the way through: for me, it hangs on line 281. (This is a step where some items are being renamed).

[x] Action: Make consumables_availability_estimation.py run all the way through

I wanted to use the file to re-generate our definitions of item_code and 'pkg_codeusingscripts/data_file_processing/healthsystem/consumables/processing_data_from_one_health/generate_consumables_item_codes_and_packages.py. This _almost_ works but the following are the differences between the file that exists currently in master` and the file that is generated by running this script. (Comparison workbook here).
Comparison workbook here

There is one more 'Package' defined: Contraception initiation (Pkg_Code 164):  (This contains 1 Pregnancy Slide Test Kit (item 2019)). (Line 1782 gives:

{
    Intervention_Cat: Maternal/Newborn and Reproductive Health
    Intervention_Pkg: Contraception initiation
    Intervention_Pkg_Code: 164
    Items: Pregnancy Slide Test Kit (Human - Chorionic Gonadotrophin (Hcg))_100_MM192300_CMST, strip
    Item_Code: 2019
    Item_Code_Avail: 2019
    Expected_Units_Per_Case: 1
    Unit_Cost: 32.164
    Source_Cost_Item: Malawi EHP 2021
    Source_ExpectedUnits: Malawi EHP 2021
}

[ ] Action:  This definition should be added manually, as other post hoc additions are in generate_consumables_item_codes_and_packages.py.

The name of some items have been modified in (seemingly) minor ways:

I'm not sure if these changes are necessary or consequential or why they changed. It seems like #807 and #861 brought these changes.

[ ] Action:  Understand if these changes are to be kept (and so made reproducible in by inserting into the scripts) or not.

There is an additional column:

Item_Code_Avail which is mostly blank: I am not sure what this does
Source_Cost_Item
Source_ExpectedUnits

[ ] Action:  Understand if these changes are to be kept (and so made reproducible in by inserting into the scripts) or not.

HI @tbhallett. Thank you so much for the detailed comments. Line 281 lmis_df_wide_flat = rename_items_to_address_inconsistentencies(lmis_df_wide_flat, inconsistent_item_names_mapping) runs for me but it took over an hour to complete. It's because of the way in which I've tried to collapse the data  - I think I can make this quicker. But I now get an error on line 379 (a reshape command) which is strange. I'll look at this and the rest of your comments more closely tomorrow.

HI @tbhallett. Thank you so much for the detailed comments. Line 281 lmis_df_wide_flat = rename_items_to_address_inconsistentencies(lmis_df_wide_flat, inconsistent_item_names_mapping) runs for me but it took over an hour to complete. It's because of the way in which I've tried to collapse the data - I think I can make this quicker. But I now get an error on line 379 (a reshape command) which is strange. I'll look at this and the rest of your comments more closely tomorrow.

Thanks for looking into this @sakshimohan

It's good that it runs on  your machine. For me, it does crash. I think this is likely to be a pandas 2.0 upgrade thing. As long, as it's reproducible under a version of pandas it's OK. (And you don't need to spent time trying to speed it up!)
On the other points - it's up for debate really; Let's see what @EvaJanouskova  and @joehcollins think.

That would be ok with me.
If we all agree that we're happy with the current state and the write up above, then we can just merge these changes... And log as an issue.

Ok great- on reflection this was not a very helpful comment from me (above). I meant to say that i'm happy to spend more time on this to check everything if you'd find helpful as off the top of my head i'm not fully versed in how the spreadsheets are generated.
The only other thing was that i think we discussed having endoscope as a consumable and use the availablity in the availability spreadsheet - does that still need doing?

The name of some items have been modified in (seemingly) minor ways:
image
I'm not sure if these changes are necessary or consequential or why they changed. It seems like https://github.com/UCL/TLOmodel/pull/807 and https://github.com/UCL/TLOmodel/pull/861 brought these changes.
Action: Understand if these changes are to be kept (and so made reproducible in by inserting into the scripts) or not.

These are other changes I made manually in the ResourceFile_Consumables_Items_and_Packages.csv, I've changed some names according what we wanted to use with the contraception module and also 2 new items were added to be used with contraception module. I'm happy to discuss what to do about them.

There is an additional column:
Item_Code_Avail which is mostly blank: I am not sure what this does
Source_Cost_Item
Source_ExpectedUnits
Action: Understand if these changes are to be kept (and so made reproducible in by inserting into the scripts) or not.

These changes came from the #876, where the columns are described:
"The Item_Code for every item used with contraceptive methods is matched with the item code of an item with the most similar name (Item in  RF_Consumables ). However for the simulation purposes of default availability, a new column Item_Code_Avail is added. If the item code is in the availability data (ResourceFile_Consumables_availability_small.csv), Item_Code_Avail is the same as Item_Code, if it's not in the availability data the closest match (if any) of items included in availability data is written as Item_Code_Avail to be used to approximate the availability for the simulations with default availability.
I also added Source_Cost_Item (for all contraceptive items and their cost it is Malawi EHP 2021) & Source_ExpectedUnits (for items included in OHT 2016, those were used, the rest is based on Malawi EHP 2021) columns so it is easy to figure out which year the data are from in future and so it's clear which data were updated, hence does not come from the same source as the rest in the file."
If I remember correctly, @sakshimohan introduced automatic availability approximation, is that correct? If so (can I see where this is happening?), then the Item_Code_Avail column should not be needed anymore. However, both Source_ columns would be good to preserve as when I got to the RF it took a long time to figure out where the data came from. It would be nice if whoever works with it in the future doesn't have to go through this again.

@sakshimohan, and/or @tbhallett  Just out of curiosity, what is current use of ResourceFile_Consumables_availability_and_usage.csv?

Hi @tbhallett. I have now been able to get the consumables_availability_estimation.py file run through to generate the two availability resource files. It seems like not having three ''' around one of the drug names which was being changes to deal with consumable names change in September in OpenLMIS was causing part of the issue.
The dataframe collapse functions (rename_items_to_address_inconsistentencies and collapse_stockout_data) are taking really long to run now, perhaps because of the new version of pandas but they do complete on my computer after approx. 30-40 minutes. I have made a slight update to get the first one to run faster by only running on the part of the dataset which consists of inconsistent drug names over the course of 2018, rather than running it on the entire dataset as done previously.
The resource files have not changed except some very negligible changes (very close to 0%) as shown in the screenshot below -

@sakshimohan, and/or @tbhallett Just out of curiosity, what is the current use of ResourceFile_Consumables_availability_and_usage.csv?

Hi @EvaJanouskova. We're not using this file currently but we had generated it previously to have a more detailed record of the amount of consumables received, stocked, dispensed each month (a more detailed version of ResourceFile_Consumables_availability_small.csv). We had previously considered doing the econometric analysis on factors associated with consumable availability on this LMIS dataset but decided to go with HHFA in the end for a few reasons.
The file is 117MB so I'm not opposed to deleting it since we're not currently using it. @tbhallett if you agree, I can remove the line in consumables_availability_estimation.py which saves this resourcefile and delete the file.

Hi @tbhallett. I have now been able to get the consumables_availability_estimation.py file run through to generate the two availability resource files. It seems like not having three ''' around one of the drug names which was being changes to deal with consumable names change in September in OpenLMIS was causing part of the issue.
The dataframe collapse functions (rename_items_to_address_inconsistentencies and collapse_stockout_data) are taking really long to run now, perhaps because of the new version of pandas but they do complete on my computer after approx. 30-40 minutes. I have made a slight update to get the first one to run faster by only running on the part of the dataset which consists of inconsistent drug names over the course of 2018, rather than running it on the entire dataset as done previously.
The resource files have not changed except some very negligible changes (very close to 0%) as shown in the screenshot below -

Thanks very much for all this, @sakshimohan
It's really great that you've got that script working, and very nice to know that we can reproduce that ResourceFile exactly.
One thing I spotted in your screenshot (and happens on my machine too) is that line 245488 has a Facility_ID value of ">107". i.e. not an integer.  I don't know how this happened --- but it could some markup from a git compare compare that crept in, as this is also a line with one of those small departures. I think this is the cause of the failing tests, so I'm putting in a manual correction to remove it.

@sakshimohan, and/or @tbhallett Just out of curiosity, what is the current use of ResourceFile_Consumables_availability_and_usage.csv?

Hi @EvaJanouskova. We're not using this file currently but we had generated it previously to have a more detailed record of the amount of consumables received, stocked, dispensed each month (a more detailed version of ResourceFile_Consumables_availability_small.csv). We had previously considered doing the econometric analysis on factors associated with consumable availability on this LMIS dataset but decided to go with HHFA in the end for a few reasons.
One reason I envision, we might end up using this data is some way is that the way in which we have characterised consumable availability is a fixed probability. This doesn't really allow us to explore what happens at the facility level if the central vendor simply purchases more consumables. This data might give us some insight into this because it records how probability of availability is associated with quantity received per month.
The file is 117MB so I'm not opposed to deleting it since we're not currently using it. @tbhallett if you agree, I can remove the line in consumables_availability_estimation.py which saves this resourcefile and delete the file.

Good points. I think it'd be nice to use such a file to examine actual usage of consumables (implied in this file) with what the model says. But, it's true that we don't use it now..... so, in the interests of being clear about our intentions, I would vote for:

Deleting the file from the repo
Commenting-out the line in the script that generates it
Adding a comment at that point about this discussion!

@EvaJanouskova  -- to your comments
Sorry for my poor communication on this point. Indeed, we had not said anywhere properly that we wanted to be able to regenerate that file using the script  and, of course, we approved your PRs, so it shows I forgot too!
I think it's very debatable whether we want to preserve that generate_consumables_item_codes_and_packages.py generates ResourceFile_Consumables_Items_and_Packages.csv, .....
but, on balance, maybe we should do it whilst we're here and I agree with you, Eva, that we don't want to loose the work you did on the renaming/matching and also don't want someone to have re-do it because we can't see what was done / how it was done.
So, can I leave it with you, Eva, to raise an issue that says: Guarantee that ResourceFile_Consumables_Items_and_Packages.csv is perfectly regenerated by running generate_consumables_item_codes_and_packages.py.... and make the changes to the script accordingly?
It doesn't have to be your priority and this PR can go ahead in its current state.

@sakshimohan, and/or @tbhallett Just out of curiosity, what is the current use of ResourceFile_Consumables_availability_and_usage.csv?

Hi @EvaJanouskova.
....
The file is 117MB so I'm not opposed to deleting it since we're not currently using it. @tbhallett if you agree, I can remove the line in consumables_availability_estimation.py which saves this resourcefile and delete the file.

If the data in the file are not outdated, I would keep this file as there are some consumables we might want to add to the ResourceFile_Consumables_Items_and_Packages.csv in future, and it would be good to know that we have some availability data for them. I @joehcollins found there some he would like to be used.

@EvaJanouskova  -- to your comments
....
So, can I leave it with you, Eva, to raise an issue that says: Guarantee that ResourceFile_Consumables_Items_and_Packages.csv is perfectly regenerated by running generate_consumables_item_codes_and_packages.py.... and make the changes to the script accordingly?
It doesn't have to be your priority and this PR can go ahead in its current state.

Issue opened: #1274

@sakshimohan can I just check then which resource file actually shows the availability values used within the model? I had previously thought this was ResourceFile_Consumables_availability_and_usage.csv?

@sakshimohan can I just check then which resource file actually shows the availability values used within the model? I had previously thought this was ResourceFile_Consumables_availability_and_usage.csv?

Hi @joehcollins. The model uses ResourceFile_Consumables_availability_small.csv. See line 804-808 of the health system.py. This is the file with cleaned district names and ensured that any missing data is interpolated. If there are consumables that you're using which aren't in  ResourceFile_Consumables_availability_small.csv but are in  ResourceFile_Consumables_availability_and_usage.csv, I can look into this an make a correction.


Rename package

Thanks for the useful package! One thing though:
> pip install cors

I think is somewhat misleading and probably confusing for package maintainers who include this package, because I’m not including CORS but a CORS scanner. So, could you please rename the package
https://github.com/chenjj/CORScanner/blob/332ca147a1b311504758946f35bb314d2411fbd8/setup.py#L6
from cors to corscanner such that:
> pip install corscanner

Thanks, you can use pip install corscanner now.

Thanks, you can use pip install corscanner now.


DB Error while migrating a Database

"Doctrine\DBAL\Driver\PDOException::("SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'json null, created_at timestamp null, updated_at timestamp null) default cha' at line 1")"
The above is error while migrating the DB,due to this only 5 tables are created

@anuragyadav8949 Please upgrade your database version which supports json columns.

duplicate of #552, #421


Azure Migrate documentation missing VMWare switch for Physical to Azure migrations commands

The information IS correctly listed in the Azure Site Recovery documentation:
https://docs.microsoft.com/en-us/azure/site-recovery/vmware-physical-mobility-service-overview#linux-machine
Step 2 on https://docs.microsoft.com/en-us/azure/migrate/tutorial-migrate-physical-virtual-machines#install-on-windows
should include the /Platform "VmWare" switch
UnifiedAgent.exe /Role "MS" /Platform "VmWare" /Silent
Step 2 on https://docs.microsoft.com/en-us/azure/migrate/tutorial-migrate-physical-virtual-machines#install-on-linux
should also include VmWare in the command
sudo ./install -r MS -v VMware -q
As noted, those are both correctly listed in the Azure Site Recovery docs, but missing in the Migrate docs.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7f3d7cc0-ecf8-a48f-3c6e-8e18c7787c41
Version Independent ID: 31b358bd-1ee6-a058-8590-802941350e90
Content: Migrate machines as physical server to Azure with Azure Migrate. - Azure Migrate
Content Source: articles/migrate/tutorial-migrate-physical-virtual-machines.md
Service: azure-migrate
GitHub Login: @rayne-wiselman
Microsoft Alias: raynew

@stantoni-msft Thanks for the feedback. This issue is being assigned to the content owner for further review.
@rayne-wiselman FYI!

@stantoni-msft. Added this to the article. It should show updated later today. Thx
#please-close


Windows reserved file names

Expected Behavior

We correctly handle, and in a normalized manner, this windows reserved file and directories names

Actual Behavior

Different classes handle this issue in their own manner, see PsychSignalDataConverter, BenzingaDataConverter and many directly don't handle it.

see https://github.com/QuantConnect/Lean/pull/3779/files/886e0232ec3113172d514182c27bc1b96d203c7f#r345286756
Potential Solution

Create a new class that handles this case for windows., files and directories.

Reproducing the Problem

N/A
System Information

Windows
Checklist

[x] I have completely filled out this template
[x] I have confirmed that this issue exists on the current master branch
[x] I have confirmed that this is not a duplicate issue by searching issues

[x] I have provided detailed steps to reproduce the issue

File Normalizer
Add in Extensions class, on the OS File class?
ToValidPath (for writing to disk safely)
FromValidPath (for getting the ticker from its normalized format)


Add support for parsing old and new (colored) input formats

sorry for my slow responding。
There are two question：

It seems you put vendor under the root directory, you may need to remove it.
Is there any problem can test your case? I haven't meet any.


tinyxml2.cpp(159): warning C6011: Dereferencing NULL pointer 'other'.

I am getting a code analysis warning for this method:
`void StrPair::TransferTo( StrPair* other )
{
if ( this == other ) {
return;
}
// This in effect implements the assignment operator by "moving"
// ownership (as in auto_ptr).
TIXMLASSERT( other != 0 );
TIXMLASSERT( other->_flags == 0 );
TIXMLASSERT( other->_start == 0 );
TIXMLASSERT( other->_end == 0 );

other->Reset();

other->_flags = _flags;
other->_start = _start;
other->_end = _end;

_flags = 0;
_start = 0;
_end = 0;

}`
There warning is raised on this line:
`other->_flags = _flags;`

The warning I am getting is:

tinyxml2.cpp(159): warning C6011: Dereferencing NULL pointer 'other'.

I know we have the ASSERT above testing the pointer but this will not apply for release build will it? Can we please put a if(other != 0){ ..... } .... or something to suppress the warning?
Thank you.

What problem would it solve? Suppress a false positive?

most static analyzers have a method of suppressing false positives.
Wouldn't it be better to just suppress your warning instead of adding
to the execution time?
On 12/20/16, Dmitry-Me<EMAIL_ADDRESS>wrote:

What problem would it solve? Suppress a false positive?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/leethomason/tinyxml2/issues/506#issuecomment-268236278

--
Farzad Sadeghi

Yes, but then you may suppress a potential valid warning. I simply pointed this out because if you are in release mode, and the "other" pointer IS NULL it is going to crash is it not?
Anyways, I am not here to argue about it. :) I reported the warning that is raised - and it is the ONLY warning that gets raised. So it would have been a clean sweep.
If you guys are happy with that, then I am.

@ajtruckle It's not going to crash because there're no cases when this pointer is actually null. The assertion is there to indicate this fact.

@Dmitry-Me OK. I obviously got it wrong. I thought ASSERT was a DEBUG only test and was skipped for RELEASE builds.

@ajtruckle It doesn't matter if it's skipped. It's there to indicate intentions.

@ajtruckle Nice to have the static checking, but I agree this one should be suppressed since it's an internal function that is checked in debug.


docs: Document collectWindowErrors option

Resolves https://github.com/getsentry/raven-js/issues/1049

@mitsuhiko re-read my comments, I think this has to be re-thought

There's similar issue in raven-node now – https://github.com/getsentry/raven-node/issues/307
We have 3 separate calls during installation process:
process.on('uncaughtException', ...) // global error handler
process.on('unhandledRejection', ...) // global promises handler
instrumentor.instrument(..., ...) // global breadcrumbs handler

Only unhandledRejection is configurable by using captureUnhandledRejections.
However, for raven-js, we call:
TraceKit.report.subscribe // global error handler
self._instrumentTryCatch()  // global try/catch handler
self._instrumentBreadcrumbs() // global breadcrumbs handler

And only latter 2 are configurable through autoBreadcrumbs and instrument options.
So we have:

global error handlers on both SDKs
global breadrcumbs on both SDKs
global try/catch on JS (@benvinegar why don't we instrument setTimeout/setInterval on node? Is there no need to do that there?)
global promises handler on Node (unhandledrejection is not supported on IE/Edge/Firefox https://caniuse.com/#feat=unhandledrejection and if we'd want to use polyfill like https://github.com/rtsao/browser-unhandled-rejection we'd not be able to support IE11 anyway, as it doesn't support native Promises)

I'd love to unify both of those setups, eg.:
captureUncaughtExceptions/captureUncaughtErrors
captureUnhandledRejections
captureBreadcrumbs/autoBreadcrumbs
instrument + instrument as a dict (as it's done now for raven-js)
Thoughts? @getsentry/javascript

More ref: https://github.com/getsentry/raven-js/issues/782

Looks like collectWindowErrors doesn't work any more.
You need to edit defaultIntegrations now.
This is how i have disabled the global handlers:
import * as Sentry from '@sentry/browser';
import { serialize } from '@sentry/utils/object';
import { API, Integrations as CoreIntegrations } from '@sentry/core';

Sentry.init({
  defaultIntegrations: [
    new CoreIntegrations.Dedupe(),
    new CoreIntegrations.InboundFilters(),
    new CoreIntegrations.FunctionToString(),
    new Sentry.Integrations.TryCatch(),
    new Sentry.Integrations.Breadcrumbs(),
    new Sentry.Integrations.LinkedErrors(),
    new Sentry.Integrations.UserAgent(),
  ],
});

Maybe there is a way how to just remove one default integration but I havent found it.

@danielhusar it's right there in the docs https://docs.sentry.io/platforms/javascript/#removing-an-integration :)


Pretty clear bug in trickle-ice branch

I'm not sure of the severity as I don't use this codepath, but in erizoAgent.js, this is pretty clearly wrong:
exports.addNewErizoController = function (msg, callback) {
    "use strict";

    if (msg.cloudProvider === '') {
        addNewPrivateErizoController(msg.ip, msg.hostname, msg.port, msg.ssl, callback);
    } else if (msg.cloudProvider === 'amazon') {
        addNewAmazonErizoController(msg.ip, msg.hostname, msg.port, msg.ssl, callback);
    }

};

var addNewAmazonErizoController = function(privateIP, callback) {

The parameters passed into addNewAmazonErizoController do not match the function declaration.  I don't use the amazon cloud provider so I do not have a fix for this.

I see this still hasn't been merged and I've made a pull request that fixes this and also adds a WebRTC stack for iOS cordova hybrid apps here #394


WIP clear inherited dependencies before rebuild

Related: https://github.com/flutter/flutter/issues/21967

Consider a widget that conditionally depends on an InheritedModel aspect:
if (foo) {
  return Text("Foo", MyModel.of(context, aspect: MyAspect));
}

It seems that if foo requirement is met once. Then even if that condition fails in the future; the widget will stay dependent on the MyModel.
This leads to unnecessary builds. I'd expect the list of dependencies to be cleared before build call

This seems to fix the problem (at least for my use-case).
But I'm likely to be missing something.
I don't know how to evaluate the performance impact.
Although considering how minor the modification is (Only InheritedWidgets are impacted), I doupt it changes much.
I'll add tests when it has been confirmed that this is a correct solution

This is a good idea in principle however we didn't include it in InheritedModel because implementing it correctly would be complicated and expensive.
Here is probably more than you wanted to know about why that's true.
The change in this PR will clear an InheritedWidget's dependencies when the InheritedWidget is rebuilt. What you're after is for a dependent widget's dependency entries to be cleared when the dependent widget is rebuilt. Element.deactivate() does part of this, it removes a dependent Element from its InheritedElement's set of dependencies. Element.activate() clears the table of the element's dependencies on InheritedElement ancestors. You could do these things in Element.rebuild() but for the _inheritedWidgets table.
Elements maintain a <Type, InheritedElement> table called _inheritedWidgets, for the sake of inheritFromWidgetOfExactType(). It makes the cost of the Foo.of(context) static methods that depend on finding an InheritedElement ancestor of a particular type, constant. Not to put to fine a point on it, but that constant lookup time cost is critical to Flutter's performance. For similar performance reasons, regular Elements don't copy this table, they share it (InheritedElements introduce copies because they redefine the set of inherited elements visible from a descendant). To enable clearing an entry in the _inheritedWidgets table, we'd have to keep track of all of the widgets that depend on each entry. Which would be expensive and complicated.

Interesting, thanks for the insights.
There's still one point I don't understand:

The change in this PR will clear an InheritedWidget's dependencies when the InheritedWidget is rebuilt. What you're after is for a dependent widget's dependency entries to be cleared when the dependent widget is rebuilt.

Why is removing oneself on rebuild from the InheritedElement.dependents similarily to deactivate not a valid solution  ?
if (_dependencies != null && _dependencies.isNotEmpty) {
  for (InheritedElement dependency in _dependencies)
    dependency._dependents.remove(this);
  _dependencies.clear();
}

Why would we have to alter _inheritedWidgets? From my understanding it seems unrelated to the listening and clearing _dependents seemed to be enough.

Sorry about that, you're right: the _inheritedWidgets table doesn't need to change when an Element's dependencies are recomputed.

Why is removing oneself on rebuild from the InheritedElement.dependents similarily to deactivate not a valid solution ?

Having Element.rebuild() clear its dependencies is what I'd try.  For this approach to be successful, none of the existing tests should fail and performance shouldn't be affected. As you know some of this work is currently done by deactivate() and the rest by activate(). Doing everything at build time changes the framework's semantics subtly. I'm not sure if that would be a completely safe change.

Ok tests got fixed.
They revealed a different issue: Widgets can subscribe to an InheritedElement outside of build method (typically didChangeDependencies).
I separated _dependencies from build specific dependencies, and unsubscribed only to the latter.
The implementation can be improved, but I'd like to check performances first (to see if it's even acceptable to begin with).
What can I do to evaluate performances impact?

@HansMuller Any updates on this?
Especially about the:

What can I do to evaluate performances impact?


Update set_spec to correct OAI form setSpec

An issue in Krikri had us converting OAI setSpec headers to set_spec
by mistake. This is now patched, and for all future harvests we want to
map from setSpec.
The relevant
diff
is the switch to Ruby OAI's #_source method.

Wanted to get this in while it was present at hand, since it's apparently something we've dropped until now.


Enhancements/ Changes suggested related to client server integration with API

These are some of the suggestion that was raised during #72  that needs to be checked for refactoring:

[ ] - Have to check uploadSize increment flow.
[x] - Need to remove setTimeOut in sending requests.
[x] - Also the data type of sendPostRequest needs to be modified.
[ ] - on clicking Cancel the pending requests has to aborted.

setTimeout and sendPostRequest return type has been changed already in https://github.com/Nasser-Eddin-Nasser/Digitact/pull/89


[AMENDMENT] Jmp.chat

Title
Jmp.chat (source: Communication ➜ Virtual Phone Numbers ➜ Jmp.chat)
Amendments
Fix current price and note the service is no longer is beta
Amendment Data
name: Jmp.chat
url: https://jmp.chat/
icon: https://jmp.chat/static/jmp.svg
androidApp: com.cheogram.android.playstore
description: >
  Phone number for incoming + outgoing calls and messages, provided by Soprani.

  Works with Jabber, Matrix, Snikket, XMPP or any SIP client. Pricing starts at

  $4.99 / month. Only available in the US and Canada (as of 2024).

  See alternate instances at [soprani.ca](https://soprani.ca/)

Affiliation Disclosure
Yes, I am affiliated with this project
Would you like to submit a PR?
Maybe?
Please tick the boxes

[X] You have filled out this form accurately, and to the best of your knowledge
[X] You have indicated whether or not you are associated with the project the amendment refers to
[X] A similar submission has not already been opened for this software / service
[X] You agree to our Code of Conduct
[X] You have read and followed the Contributing Guide

Done in https://github.com/Lissy93/awesome-privacy/pull/275. Thanks for the issue @singpolyma!


Table: add test

Please makes sure these boxes are checked before submitting your PR, thank you!

[x] Make sure you follow Element's Contributing Guide.
[x] Rebase before creating a PR to keep commit history clear.
[x] Add some descriptions and refer relative issues for you PR.

CI 里面看上去只跑了 Table 的测试？

不是 我们本地为了快一点改成了只跑 table，刚才把配置也推上去了，已经修回来了

@QingWei-Li 测试挂了 5 个。

DONE


Sending push to Android device succeed but did not receive the notification

I've followed the guide at https://github.com/Ph3nol/NotificationPusher/blob/master/doc/gcm-fcm-adapter.md, and got success response:
array(5) {
  ["message_id"]=>
  string(35) "0:1526899807216245%882441d2f9fd7ecd"
  ["multicast_id"]=>
  int(7747457543145750552)
  ["success"]=>
  int(1)
  ["failure"]=>
  int(0)
  ["canonical_ids"]=>
  int(0)
}

But my device didn't receive any notification.
Any suggestion? Thanks!

@dongmai sometimes it happens with some devices. Try to play with parameters
$params['message']['content-available'] = '1';
$params['device']['content_available'] = 'true';

The same for iOS if problems
$params['message']['custom'] = $params['message'];
$params['message']['content-available'] = 1;
$params['message']['sound']             = 'default';

@Syrok  I've tried but no luck.

@dongmai try to use the latest version also.

@seyfer Still no luck on the latest version, what I could do now?  :)

I can push to iOS devices successfully.

@dongmai Try to debug and read docs, maybe you will find something. Maybe some of your parameter missing.
https://firebase.google.com/docs/cloud-messaging/concept-options
Maybe your device works only with older GCM?
https://developers.google.com/cloud-messaging/android/client

@seyfer Thanks for your help.
I think I should test on other device than HUAWEI phone, as other found problem with it https://github.com/Ph3nol/NotificationPusher/issues/107

hi @seyfer , I've tested on Asus android 7 but still no luck.
Bellow is my code:
function test_push_notification($device_token, $device_type) {
    $pushManager = new PushManager(PushManager::ENVIRONMENT_PROD);

    // Then declare an adapter.
    $gcmAdapter = new GcmAdapter(array(
        'apiKey' => '_the_api_key_',
    ));

    // Set the device(s) to push the notification to.
    $devices = new DeviceCollection(array(
        new Device('_the_device_token_')
    ));

    $params = [];
    $params['message']['content-available'] = '1';
    $params['device']['content_available'] = 'true';

    // Then, create the push skel.
    $message = new Message('This is an example.', $params);

    // Finally, create and add the push to the manager, and push it!
    $push = new Push($gcmAdapter, $devices, $message);
    $pushManager->add($push);
    $pushManager->push(); // Returns a collection of notified devices

    // each response will contain also
    // the data of the overall delivery
    foreach($push->getResponses() as $token => $response) {
        var_dump($token);
        var_dump($response);
    }
}

any idea?

Maybe something wrong with your app? If you are doing it with some JS frameworks like PhoneGap or Cordova, etc. - they could have problems. Google, research.

@dongmai how did u resolve ?? i am having issue with ios but android is working fine can u help me


Interactions

Hi!
First of all, congrats on this reference, it's really nice to use!
I was wondering if it would be useful to have access to a node interactions list.
Does this sound like a good idea for this library?
Thank you!

Wouidn't mind it, don't know when I'll get around to it but feel free to open up a PR if you're up for it!


Create a Docker image for Artichoke build

We spend a lot of time installing dependencies in the Artichoke build:
https://github.com/artichoke/artichoke/blob/2c6614ca57364b9a574c44be18f3323d08931f25/.circleci/config.yml#L38-L67
The Rust toolchain does not change frequently, neither does the C toolchain, nor the Ruby toolchain.
Build a Docker image with the following dependencies:

snapshot clang
bison
gperf
binutils
Rust version that matches the rust-toolchain

rustfmt, clippy
wasm32-unknown-emscripten and wasm32-unknown-unknown targets

Ruby 2.6.3
latest Bundler 2.x
node LTS
yarn
shellcheck
shfmt

This change would enable:

Implementing the shellcheck file discovery with shfmt, which enables naming shell scripts without the .sh suffix.
Building mruby-sys with the clang native wasm target.
Unifying the build into one mega job (not sure if this is desirable).

WIP https://github.com/artichoke/artichoke-ci
Pending getting off the waitlist for GitHub package registry.

Is this something you still need help with?
I’d like to take a look as I think this is a great project, but my main expertise is Ops/DevOps so I doubt I’ll be able to help much with the Rust side of things :)

Hi @Temikus. I'm interested in pursuing this, but not for CI (GitHub Actions is filling that need).
Would you be interested in exploring packaging the artichoke and airb binaries in a Dockerfile for distribution similar to https://hub.docker.com//ruby or https://hub.docker.com//jruby?
I think the resulting code is the same, but the intent is different.
The build docs will be your best bet to get started: https://github.com/artichoke/artichoke/blob/master/BUILD.md.
Does this sound interesting to you?

@lopopolo Sure, lemme take a look :)
How do you want to go about it? Should I create a new issue in this project or use this one for comms?

Using this one works for me

@lopopolo I have some additional questions, if you don't mind:

What do we want in the container besides 'airb' and 'artichoke'?

Do I include ruby/rubygems?
Any packages/gems installed by default?

Which base images do we support? Do we want it to be Ubuntu only (what the CI currently runs on)? Or add a more slim/secure image like alpine or debian-slim?

If we want alpine - is it ok if we have some things dynamically linked? (due to proc-macro, see https://github.com/rust-lang/cargo/issues/7563#issuecomment-553526254)

Do you want nightlies (every change) or only official releases built?

Presumably we would want this in some kind of CI, correct? If so - what do I target - GitHub actions?

Where should this work live? This repo or a separate one?

Just to check whether we're on the same page you can take a look at something I've hacked together and working on at the moment (keep in mind that this is just a very early POC): https://gist.github.com/Temikus/0b5121285d2dbdba1995c8702a7a1d12

@Temikus I think you're right that building proper support for nightly builds is a separate project from the implementation of Artichoke itself. I've set up a bare bones repo at https://github.com/artichoke/docker-artichoke-nightly where we should put the code and tickets for exploring the design. I'll be moving this issue over to the new repo.

What do we want in the container besides 'airb' and 'artichoke'?
Do I include ruby/rubygems?
Any packages/gems installed by default?

For now just airb and artichoke. Artichoke can't interact with the local filesystem, so including MRI rubygems is not likely to be useful.

Which base images do we support? Do we want it to be Ubuntu only (what the CI currently runs on)? Or add a more slim/secure image like alpine or debian-slim?

Alpine and debian-slim seem good to start (these seem to be fairly standard from many of the CI containers I have experience with).

If we want alpine - is it ok if we have some things dynamically linked? (due to proc-macro, see rust-lang/cargo#7563 (comment))

From this ticket, it looks like this issue is only applicable when using alpine as a build host. Rust has fairly good cross compilation support: we should be able to use debian-slim (or ubuntu) as the stage 0 build host in a multi-stage dockerfile that cross compiles to the x86_64-unknown-linux-musl target (see https://doc.rust-lang.org/edition-guide/rust-2018/platform-and-target-support/musl-support-for-fully-static-binaries.html).

Do you want nightlies (every change) or only official releases built?

Building once a day seems fine for now (I imagine this is easier to drive from a GitHub Action).

Presumably we would want this in some kind of CI, correct? If so - what do I target - GitHub actions?

Yes, all Artichoke repos use GitHub Actions.

Where should this work live? This repo or a separate one?

https://github.com/artichoke/docker-artichoke-nightly

https://gist.github.com/Temikus/0b5121285d2dbdba1995c8702a7a1d12

This is AWESOME! I never would have thought to leverage the cargo install step. That makes things so much simpler than cloning the repo and mounting it into the builder.
The alpine container stage 0 would essentially be the same thing, but you would modify the rustup install invocation to set the musl target as the default toolchain.
Artichoke declares a rust-toolchain file which pegs a particular Rust version, but building the nightlies with the latest stable is 💯.
@Temikus would you like me to give you push access to https://github.com/artichoke/docker-artichoke-nightly?


[Serving] Memory leak when new checkpoint restore in TFServing.

Describe the current behavior
Every time new checkpoint restore trigger memory leak in TFServing (use EmbeddingVariable in model).
Describe the expected behavior
No memory consumption increase when restore new checkpoint.

It's not a memory leak, EmbeddingVariable's allocation comes from EVAllocator which would cache lots of memory each model restore.
We provide Environment Variable to disable EVAllocator which could be used in this case. PR: https://github.com/alibaba/DeepRec/pull/254


fix Friendica Webfinger interop

Friendica is sending us webfinger requests like these, and we're 400ing. Is it because they're URL-encoded? We should fix.
/.well-known/webfinger?resource=acct%3A%40arush.io
/.well-known/webfinger?resource=https%3A%2F%2Farush.io

False alarm, these are 400ing because arush.io doesn't have a representative h-card. Never mind.


Enhance auto completion

Summary
Auto-completion of show command is not very clear and helpful at the moment if one uses a large password store or even multiple stores with hundreds of entries. At the moment completion just lists all secrets at once.
Steps To Reproduce
Just type gopass show and hit TAB key.

Expected behavior
For me it would be much more helpful if it would work like bash auto completion for filesystem (e.g. using ls). Auto-completion should just take the next path hierarchy into account for auto completion.
If auto completion would take arbitrary parts of the next path hierarchy into account, like zsh auto completion for filesystem that would be even better:

This works for me as you have described.
I think the difference in your issue between what you do in Steps to Reproduce and Expected behavior is that you don't put some prefix after gopass show but you start with ls pkg.
The behavior for gopass and ls autocompletion for me is exactly the same. If I don't put anything behind ls or gopass show it will basically print everything. Once I add a prefix for a path, only secrets with that prefix path are shown.

But ls won't show all subfolders recursively. gopass' showcommand does exactly that.

Ah, ok. That's what you're going for.
I guess we can improve this then. Do you want to create a PR for this @nilskuhn?

Yes, I would like to.
Could you give me a hint which packages/files should be affected? Or is there some documentation of package structure?

The CLI helper start for list (ls) in here:
https://github.com/gopasspw/gopass/blob/master/commands.go#L731
https://github.com/gopasspw/gopass/blob/master/pkg/action/list.go#L25:18
I think you need to look into list, because that is what the autocompletion is using in the background (even for other commands like show).

@metalmatze That's correct, but we shouldn't need to change list for this change.
I think it should be possible to implement this change in ´action.Complete´.
You can inspect c.Args() and filter the list output there.


JBD BMS: Balancing indicator not showing on correct cells

Balancing indicators on Cell Voltages page are not showing on correct cells. The red indicators jump between cells showing 1-3 cells balancing and after a while it shows all cells balancing:

Checked with dbus-spy and it shows the same:

Switched to bluetooth adapter and xiaoxiang app is showing only two cells balancing as it should:

I have a JBD-SP04S034 4S 200A BMS with three temperature sensors, so there might be an issue with unusual message length. I need to check if disabling one temperature sensor in xiaoxiang app makes any difference.
Edit: Disabled one temp sensor and still the same issue.

Have others with a JBD BMS the same issue?

@iLeeeZi can you organize the protocol documentation so we can fix this? Please ask your seller or the manufacturer.

Did some testing and looks like that it is not a protocol issue.
I added logging after L123 in lltjbd.py
https://github.com/Louisvdw/dbus-serialbattery/blob/jkbms_ble/etc/dbus-serialbattery/bms/lltjbd.py#L123
logger.info(str(tmp))

And the data seems correct, but with data showing only two of the cells balancing, the UI indicated after a few seconds that three of the cells are constantly balancing
2023-05-04 15:55:04.967329500 INFO:SerialBattery:0001
2023-05-04 15:55:05.974664500 INFO:SerialBattery:0001
2023-05-04 15:55:06.965833500 INFO:SerialBattery:0001
2023-05-04 15:55:07.972370500 INFO:SerialBattery:0101
2023-05-04 15:55:08.978049500 INFO:SerialBattery:0001
2023-05-04 15:55:09.969268500 INFO:SerialBattery:0001
2023-05-04 15:55:10.976891500 INFO:SerialBattery:0101
2023-05-04 15:55:11.982067500 INFO:SerialBattery:0000
2023-05-04 15:55:12.973059500 INFO:SerialBattery:0001
2023-05-04 15:55:13.979577500 INFO:SerialBattery:0101
2023-05-04 15:55:14.986797500 INFO:SerialBattery:0001
2023-05-04 15:55:16.028883500 INFO:SerialBattery:0001
2023-05-04 15:55:17.018241500 INFO:SerialBattery:0101
2023-05-04 15:55:18.024716500 INFO:SerialBattery:0001
2023-05-04 15:55:19.015430500 INFO:SerialBattery:0001
2023-05-04 15:55:20.021196500 INFO:SerialBattery:0001
2023-05-04 15:55:21.012090500 INFO:SerialBattery:0001
2023-05-04 15:55:22.017786500 INFO:SerialBattery:0001
2023-05-04 15:55:23.025228500 INFO:SerialBattery:0101

So the log data is correct, but the displayed data not?

Yes. The bms seems to send correct data, and the driver reads it correctly but dbus and gui is incorrect.

Could you write me on Discord?

Could you try to replace
https://github.com/Louisvdw/dbus-serialbattery/blob/88e5eea93331ae99dc28fcf8b5a40cb866e432e2/etc/dbus-serialbattery/bms/lltjbd.py#L118-L130
with
    def to_cell_bits(self, byte_data, byte_data_high):
        try:
            # get up to the first 16 cells
            tmp = bin(byte_data)[2:].rjust(min(self.cell_count, 16), utils.zero_char)
            logger.info("tmp: type: " + type(tmp) + " - value: " + tmp)
            # tmp = 0101
            tmp_reversed = reversed(tmp)
            # tmp_reversed = 1010
            logger.info("tmp_reversed: type: " + type(tmp_reversed) + " - value: " + tmp_reversed)

            test = tmp_reversed + reversed(tmp)
            logger.info("test: type: " + type(test) + " - value: " + test)

            if self.cell_count > 16:
                tmp2 = bin(byte_data_high)[2:].rjust(self.cell_count - 16, utils.zero_char)
                logger.info("tmp2: type: " + type(tmp2) + " - value: " + tmp2)
                tmp_reversed = tmp_reversed + reversed(tmp2)
                logger.info("tmp_reversed: type: " + type(tmp_reversed) + " - value: " + tmp_reversed)
            # tmp = 1010
            for c in range(self.cell_count):
                if is_bit_set(tmp_reversed[c]):
                    logger.info("balancing cell " + c)
                    self.cells[c].balance = True
                else:
                    self.cells[c].balance = False

        except Exception as err:
            logger.error(f"Unexpected {err=}, {type(err)=}")

?
It could be that nothing works, since I'm not sure about the var types and I have no JBD BMS to test. But the driver shouldn't crash.

I got errors on reversed() so changed it to [::-1]:
    def to_cell_bits(self, byte_data, byte_data_high):
        try:
            # get up to the first 16 cells
            tmp = bin(byte_data)[2:].rjust(min(self.cell_count, 16), utils.zero_char)
            logger.info("tmp: type: " + str(type(tmp)) + " - value: " + tmp)
            tmp_reversed = tmp[::-1]
            logger.info("tmp_reversed: type: " + str(type(tmp_reversed)) + " - value: " + tmp_reversed)

            test = tmp_reversed + tmp[::-1]
            logger.info("test: type: " + str(type(test)) + " - value: " + str(test))

            if self.cell_count > 16:
                tmp2 = bin(byte_data_high)[2:].rjust(self.cell_count - 16, utils.zero_char)
                logger.info("tmp2: type: " + str(type(tmp2)) + " - value: " + tmp2)
                tmp_reversed = tmp_reversed + tmp2[::-1]
                logger.info("tmp_reversed: type: " + str(type(tmp_reversed)) + " - value: " + tmp_reversed)

            for c in range(self.cell_count):
                if is_bit_set(tmp_reversed[c]):
                    logger.info("balancing cell " + str(c+1))
                    #self.cells.append(Cell(True))
                    self.cells[c].balance = True
                else:
                    #self.cells.append(Cell(False))
                    self.cells[c].balance = False

        except Exception as err:
            logger.error(f"Unexpected {err=}, {type(err)=}")

But without self.cells.append(Cell()) I get
2023-05-10 15:53:14.552053500 ERROR:SerialBattery:Unexpected err=IndexError('list index out of range'), type(err)=<class 'IndexError'>

In some other function

Can you post the error logs or give me access to the system? Second would save me a lot of time writing back and forth. Please contact me on Discord for this. You find the link in my profile.

Thank you @mr-manuel for fixing this. I have a JBD-AP20S003S BMS with 18 cells. I suspected that the red balancing indicators in SerialBattery were wrong ever since cell voltages became available but never had a chance to compare them to the xiaoxiang app. Saw this note in the changelog, upgraded to v1.0.20230531 and now they look much more normal! Thank you.


How to change the pdk ?

Can anyone tell help to change the pdk from sky130 to gf180mcu??

@proppy

@radhe-2022
Follow below steps:
export PDK_ROOT=<absolute path to GF180 PDK >`
export PDK=gf180mcuC
make mount

Alternatively:
export PDK_FAMILY=gf180mcu # set environment variable for volare
export PDK=gf180mcuC # set environment variable for the rest of the toolchain
make
make test

should allow volare to resolve and download the new GF180MCU PDK.
See also https://caravel-user-project.readthedocs.io/en/latest/ for instructions on how to set up the caravel_user_project environment to submit a project to the recently announced GF-MPW0 Open MPW shuttle:
https://opensource.googleblog.com/2022/10/announcing-globalfoundries-open-mpw-shuttle-program.html

What should be the directory of executing all this instructions??

@radhe-2022 fresh checkout of OpenLane, see https://github.com/The-OpenROAD-Project/OpenLane#installation-the-short-version

I'm a beginner
I followed..
launched terminal in home directory

git clone https://github.com/The-OpenROAD-Project/OpenLane.git
cd OpenLane
EXPORT PDK_FAMILY=gf180mcu
EXPORT PDK=gf180mcuC
sudo make
sudo make test

I exported the gf180 pdk but still after make command docker fetches sky130A pdk image
Please help if Im doing any blunder ..
Thankyou @proppy @vijayank88

@radhe-2022
Where GF180 pdk installed in your machine?

launched terminal in home directory

Can you paste the full command outout?

EXPORT PDK_FAMILY=gf180mcu
EXPORT PDK=gf180mcuC

export should be in lowercase.

sudo make
sudo make test

sudo shouldn't be strictly required.

Done..! Thankyou so much sir @proppy @vijayank88
Heading towards my first design to get tapeout


SameDiff calculates unnecessary gradients

Issue Description
I want to calculate gradients for only specific variables in my samediff graph.
In the following code, z.gradient().getArr() should be null, since I specified to only backpropagate the gradient for x.
https://gist.github.com/orausch/361c3582fa899697d7e407b8bc913a31
Actual Output:
w.gradient(): 8.0000
x.gradient(): 8.0000
z.gradient(): 4.0000

Expected Output:
w.gradient(): 8.0000
x.gradient(): 8.0000
z.gradient(): null

Version Information
1.0.0-beta5
If this is not the right way to do what I want to do, please let me know how to do it.

This is expected behaviour.
SDVariable loss = sd.loss().meanSquaredError("loss", sd.constant(Nd4j.zeros(1)), w.mul(z));

Note you have w.mul(z) - clearly, w gradient is required, so this multiplication operation is required to be differentiated. Let O=w.mul(z), then the mul_bp operation has inputs (w, z, dL/dO), and outputs (dL/dw and dL/dz).
In general SameDiff automatically determines the minimal subgraph necessary to calculate the required gradients; however this minimal subgraph is at the operation level, not the variable level. Consequently we get gradients for all (floating point) operations that need to be differentiated.


'split' column is missing

Hello. I found your research very interesting. And,, I have one question about ECInstruct.
Three days ago, when I download your data from huggingface, ECInstruct had the "split" column.
Thus, I can divide data to train,val,test.
However, after you modified data (2 days ago), I cannot access the "split" column on ECInstruct and I cannot divide data.
Could you add "split" column on your ECInstruct data?

Thanks for the reminder. We have updated the ECInstruct data now.


Add possibility to send to channels, not only users

With this patch you can target IRC channels instead of only users.

Nevermind...


Memory leak: Unmanaged thread pool started

Caused by https://github.com/fge/json-schema-validator/issues/135

Disabled multithreading. This workaround seems to work here. Waiting to see what the author says about the original issue


chore: bdd-spring-1575571183 to 0.0.1

chore: Promote bdd-spring-1575571183 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


shortcuts commands ideas

I'm thinking about the "Current Shortcuts" by Alt+S
Currently I can read them and then use on my keyboard that shown Keystroke.
I also could select a line. e.g. "Table View Ctrl +T".
The shortest way  to select now "Table View Ctrl +T" could be double click and open it from there.
When we could show there also all Buttons, Menu, Input entries, also those without a key code and add a search field this will give a kind of overview and a different navigation option.
For using pyautogui this also means we can enter a search string to that helper and it finds the button, without the need to have an image  to locate it on screen. Currently we need different images dependent on users screen depth and fonts used.
We could also think about having a Ctrl+F on any view which then searches this helper data and highlights the element we are looking for.
This behaviour is than quite similiar to browsers.
For pyautogui that would mean we highlight something and search for e.g. a yellow box
set the mouse pointer there and click.

So you are suggesting

Being able to execute shortcuts via double click in the Shortcut dialog
Include within the Shortcut dialog all interactive QObjects (sounds like it would be very confusing for a normal user)
Include a filter/search for the Shortcut dialog
Include a Ctrl+F shortcut on every window to highlight QObjects by their name (for ease of use for pyautogui)

Yes?