Adds New Functions

I've added some new functions over the last months.

@synax These are all great additions. Thanks! Can you add tests for each function?

Hey,  sure, totally forgot them. Will add them this week. cheers

Sorry for the delay. I've added tests for the new functions.

@synax 3 tests fail for me. The should exist functionality was rolled back a while ago because it broke things.
    Context SoftwareProduct
      [+] Should return the correct test Name 78ms
      [-] Should return the correct test Expression 90ms
        Expected strings to be the same, but they were different.
        Expected length: 270
        Actual length:   59
        Strings differ at index 0.
        Expected: '@('HKLM:\SOFTWARE\WOW6432Node\Microsoft\Windows\CurrentVersion\Uninstall\*','HKLM:\\Software\Microsoft\Wind
ows\CurrentVersion\Uninstall\*') | Where-Object { Test-Path  } | Get-ItemProperty | Where-Object DisplayName -Match 'Microsoft
 .NET Framework 4.6.1' | Should Exist'
        But was:  'TestSoftware Microsoft .NET Framework 4.6.1  | Should Exist'
        -----------^
        428:                 $results.Expression | Should Be "@('HKLM:\SOFTWARE\WOW6432Node\Microsoft\Windows\CurrentVersion\U
ninstall\*','HKLM:\\Software\Microsoft\Windows\CurrentVersion\Uninstall\*') | Where-Object { Test-Path $_ } | Get-ItemProperty
 | Where-Object DisplayName -Match 'Microsoft .NET Framework 4.6.1' | Should Exist"
        at Invoke-LegacyAssertion, C:\Program Files\WindowsPowerShell\Modules\pester\4.3.1\Functions\Assertions\Should.ps1: li
ne 188
        at <ScriptBlock>, C:\source\GitHub\poshspec\Tests\poshspec.Tests.ps1: line 428

    Context SoftwareProduct w/Property
      [+] Should return the correct test Name 223ms
      [-] Should return the correct test Expression 19ms
        Expected strings to be the same, but they were different.
        Expected length: 326
        Actual length:   129
        Strings differ at index 0.
        Expected: '@('HKLM:\SOFTWARE\WOW6432Node\Microsoft\Windows\CurrentVersion\Uninstall\*','HKLM:\\Software\Microsoft\Wind
ows\CurrentVersion\Uninstall\*') | Where-Object { Test-Path  } | Get-ItemProperty | Where-Object DisplayName -Match 'Microsoft
 .NET Framework 4.6.1' | Select-Object -ExpandProperty 'DisplayVersion' | Should Be 4.6.01055'
        But was:  'TestSoftware Microsoft .NET Framework 4.6.1 DisplayVersion | Select-Object -ExpandProperty 'DisplayVersion'
 | Should Be 4.6.01055'
        -----------^
        441:                 $results.Expression | Should Be "@('HKLM:\SOFTWARE\WOW6432Node\Microsoft\Windows\CurrentVersion\U
ninstall\*','HKLM:\\Software\Microsoft\Windows\CurrentVersion\Uninstall\*') | Where-Object { Test-Path $_ } | Get-ItemProperty
 | Where-Object DisplayName -Match 'Microsoft .NET Framework 4.6.1' | Select-Object -ExpandProperty 'DisplayVersion' | Should
Be 4.6.01055"
        at Invoke-LegacyAssertion, C:\Program Files\WindowsPowerShell\Modules\pester\4.3.1\Functions\Assertions\Should.ps1: li
ne 188
        at <ScriptBlock>, C:\source\GitHub\poshspec\Tests\poshspec.Tests.ps1: line 441
    Context PSModule
      [+] Should return the correct test Name 67ms
      [-] Should return the correct test Expression 53ms
        Expected strings to be the same, but they were different.
        Expected length: 172
        Actual length:   160
        Strings differ at index 155.
        Expected: 'Get-Module -Name WorkplaceValidation -ListAvailable -ErrorAction SilentlyContinue | Select-Object -First 1
| Select-Object -ExpandProperty 'Path' | should not benullorempty'
        But was:  'Get-Module -Name WorkplaceValidation -ListAvailable -ErrorAction SilentlyContinue | Select-Object -First 1
| Select-Object -ExpandProperty 'Path' | Should Exist'
        ----------------------------------------------------------------------------------------------------------------------
------------------------------------------------^
        581:                 $results.Expression | Should Be "Get-Module -Name WorkplaceValidation -ListAvailable -ErrorAction
 SilentlyContinue | Select-Object -First 1 | Select-Object -ExpandProperty 'Path' | should not benullorempty"
        at Invoke-LegacyAssertion, C:\Program Files\WindowsPowerShell\Modules\pester\4.3.1\Functions\Assertions\Should.ps1: li
ne 188
        at <ScriptBlock>, C:\source\GitHub\poshspec\Tests\poshspec.Tests.ps1: line 581


Decisions taken

Decisions taken:

The application will be based on the solid-chess application https://github.com/pheyvaer/solid-chess/

This issue has been closed and from now on Wiki will host decisions taken. https://github.com/Arquisoft/dechat_es5b/wiki


Only release release.

Reverts this for now as source doesn't load in Android Studio in apps
https://github.com/vanniktech/gradle-maven-publish-plugin/blob/master/CHANGELOG.md#version-0190-2022-02-26

Behavior Change: When using version 7.1.0 or newer of the Android Gradle Plugin we will now publish all variants of a library unless androidVariantToPublish was set in the DSL. This means that for example both debug and release or all flavors.

Compare
https://repo1.maven.org/maven2/com/google/android/horologist/horologist-audio/0.0.2/
and
https://repo1.maven.org/maven2/com/google/android/horologist/horologist-audio/0.0.3/

Tested this with a build to 0.0.5 and it works, fixes the source display, so will land.


Repository not found

Hi. When start project: python -m magicanimate.pipelines.animation --config configs/prompts/animation.yaml
have some error :
A matching Triton is not available, some optimizations will not be enabled.
Error caught was: No module named 'triton'
E:\JupyterNoteBook\lidaming\magic-animate\magicanimate\pipelines\pipeline_animation.py:43: FutureWarning: Importing `DiffusionPipeline` or `ImagePipelineOutput` from diffusers.pipeline_utils is depreca
ted. Please import from diffusers.pipelines.pipeline_utils instead.
  from diffusers.pipeline_utils import DiffusionPipeline
Traceback (most recent call last):
  File "C:\ProgramData\anaconda3\lib\site-packages\huggingface_hub\utils\_errors.py", line 270, in hf_raise_for_status
    response.raise_for_status()
  File "C:\ProgramData\anaconda3\lib\site-packages\requests\models.py", line 1021, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://huggingface.co/pretrained_models/stable-diffusion-v1-5/resolve/main/tokenizer/tokenizer_config.json

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "C:\ProgramData\anaconda3\lib\site-packages\transformers\utils\hub.py", line 389, in cached_file
    resolved_file = hf_hub_download(
  File "C:\ProgramData\anaconda3\lib\site-packages\huggingface_hub\utils\_validators.py", line 118, in _inner_fn
    return fn(*args, **kwargs)
  File "C:\ProgramData\anaconda3\lib\site-packages\huggingface_hub\file_download.py", line 1374, in hf_hub_download
    raise head_call_error
  File "C:\ProgramData\anaconda3\lib\site-packages\huggingface_hub\file_download.py", line 1247, in hf_hub_download
    metadata = get_hf_file_metadata(
  File "C:\ProgramData\anaconda3\lib\site-packages\huggingface_hub\utils\_validators.py", line 118, in _inner_fn
    return fn(*args, **kwargs)
  File "C:\ProgramData\anaconda3\lib\site-packages\huggingface_hub\file_download.py", line 1624, in get_hf_file_metadata
    r = _request_wrapper(
  File "C:\ProgramData\anaconda3\lib\site-packages\huggingface_hub\file_download.py", line 402, in _request_wrapper
    response = _request_wrapper(
  File "C:\ProgramData\anaconda3\lib\site-packages\huggingface_hub\file_download.py", line 426, in _request_wrapper
    hf_raise_for_status(response)
  File "C:\ProgramData\anaconda3\lib\site-packages\huggingface_hub\utils\_errors.py", line 320, in hf_raise_for_status
    raise RepositoryNotFoundError(message, response) from e
huggingface_hub.utils._errors.RepositoryNotFoundError: 404 Client Error. (Request ID: Root=1-65825bb9-3d5247bb676aecf77ad7cda5;fe795558-d4a6-43f1-a8c9-6243d2815fcd)

Repository Not Found for url: https://huggingface.co/pretrained_models/stable-diffusion-v1-5/resolve/main/tokenizer/tokenizer_config.json.
Please make sure you specified the correct `repo_id` and `repo_type`.
If you are trying to access a private or gated repo, make sure you are authenticated.

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "C:\ProgramData\anaconda3\lib\runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\ProgramData\anaconda3\lib\runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "E:\JupyterNoteBook\lidaming\magic-animate\magicanimate\pipelines\animation.py", line 282, in <module>
    run(args)
  File "E:\JupyterNoteBook\lidaming\magic-animate\magicanimate\pipelines\animation.py", line 271, in run
    main(args)
  File "E:\JupyterNoteBook\lidaming\magic-animate\magicanimate\pipelines\animation.py", line 75, in main
    tokenizer = CLIPTokenizer.from_pretrained(config.pretrained_model_path, subfolder="tokenizer")
  File "C:\ProgramData\anaconda3\lib\site-packages\transformers\tokenization_utils_base.py", line 1951, in from_pretrained
    resolved_config_file = cached_file(
  File "C:\ProgramData\anaconda3\lib\site-packages\transformers\utils\hub.py", line 410, in cached_file
    raise EnvironmentError(
OSError: pretrained_models/stable-diffusion-v1-5 is not a local folder and is not a valid model identifier listed on 'https://huggingface.co/models'
If this is a private repository, make sure to pass a token having permission to this repo either by logging in with `huggingface-cli login` or by passing `token=<your_token>`

https://github.com/magic-research/magic-animate/issues/13


Explicitly document ordering behavior of union-function in bicep/ARM

The documentation of the union-function in bicep/ARM currently states that

Duplicate values or keys are only included once.

The example seems to imply that for a key that is contained in multiple parameters the last provided value is kept in the result.
Is that the defined behavior? Could that be documented?
This would apply to https://docs.microsoft.com/en-us/azure/azure-resource-manager/templates/template-functions-object#union as well.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3bff25f6-d85f-290b-d075-da200756070e
Version Independent ID: 5eab2d57-3a94-d1c2-94f2-535e1dc84a8a
Content: Bicep functions - objects - Azure Resource Manager
Content Source: articles/azure-resource-manager/bicep/bicep-functions-object.md
Service: azure-resource-manager
Sub-service: bicep
GitHub Login: @mumian
Microsoft Alias: jgao

@sopelt - Thanks for bringing this to our attention. We will investigate it further and update you shortly.

@sopelt - thanks for this feedback. I have added some text to clarify how the order of the parameters affect the result. The update should get published later today.
#please-close


How to use .Value

var queryInput = form.Elements["q"] as IHtmlInputElement;
if (queryInput != null)
{
queryInput.Value = "anglesharp";
}
Cannot use .Value, it complains that it's not part of IHtmlInputElement extension
After I do this, can I retrieve the value to make sure it's set properly.
The submitsync doesn't seem to pick up those value and the authentication fails.

Can you bring up a bit more code (e.g., the HTML used to generate the DOM) for context?

Thanks for giving me a pointer

																<input name="j_class" id="j_pin" type="hidden">
																<input name="j_pw" id="j_pw" type="hidden">
				                        <button name="login" id="login" type="button">Click Here to Log On</button>
				                    </form>

It looks like it has couple of hidden field and those must be filled as well. After that, it complains that browser does not support javascript.
So I did
        var config = Configuration.Default
      .WithDefaultLoader()
      .WithJavaScript()
      //.WithDefaultCookies();
      .WithCookies();

but then it errors out with
System.TypeLoadException
HResult=0x80131522
Message=Could not load type 'AngleSharp.Services.IScriptingProvider' from assembly 'AngleSharp, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=e83494dcdc6d31ea'.
Source=AngleSharp.Scripting.JavaScript
StackTrace:
at AngleSharp.JsConfigurationExtensions.WithJavaScript(IConfiguration configuration)
at AssetBot1.Program.d__0.MoveNext() in C:\Source\AssetBot1\AssetBot1\Program.cs:line 22
So I'm getting closer.

If you are using a new version of AngleSharp then you must use AngleSharp.Js. AngleSharp.Scripting.JavaScript is not supported and only works with versions pre 0.10.

Thanks. That helps.
Now I'm using
var config = Configuration.Default
.WithDefaultLoader()
.WithJs()
//.WithDefaultCookies();
.WithCookies();
and I'm getting this error
Since your browser does not support JavaScript,\n                you must press the Continue button once to proceed
Any suggestions?

Probably the JS is too complex and crashes. AngleSharp.Js is still experimental and does not work on state of the art web apps. You should see some output in the debug console.


add cli opt for passing prom port

You can now pass a specific prometheus port via --prom-port flag
fixes https://github.com/solo-io/bumblebee/issues/100

Thanks a lot for allowing this config, much appreciated!

of course!


Updated img syntax

Using the syntax shown in Grav documentation:
https://learn.getgrav.org/content/media#cropresize-width-height

Oh I just noticed that the featured images still behave unexpectedly on the post.
For me at least they're not actually cropped, but just resized to the 4 by 3 format so they turn up skewed.
Is that the expected behaviour?

Great work @floede ! Merged, thanks!


File collision with matplotlib conda package

When using constructor to build a maxiconda distribution containing (amongst others) also matplotlib and basemap, I see the following error message:
Checking for duplicate files ...
Error: File 'lib/python2.7/site-packages/mpl_toolkits/__init__.py' found in multiple packages: basemap-1.1.0-py27_3.tar.bz2, matplotlib-2.0.2-np113py27_0.tar.bz2

Looks like this file should be removed during basemap packaging.
CC @barsch

Here's a minimal recipe to show the problem:
name: JustATest
version: 1.0.0_0

channels:
  - http://repo.continuum.io/pkgs/free/
  - https://conda.anaconda.org/conda-forge

install_in_dependency_order: true

specs:
  - python 2.7.14*
  - conda
  - ipython
  - jupyter
  - basemap
  - basemap-data-hires

$ constructor --platform=linux-64 JustATest
platform: linux-64

Checking for duplicate files ...
Error: File 'lib/python2.7/site-packages/mpl_toolkits/__init__.py' found in multiple packages: basemap-1.1.0-py27_3.tar.bz2, matplotlib-2.0.2-np113py27_0.tar.bz2

Has anybody come to know for a resolution of this problem?
I'm hitting the same problem.

IMO that is a bug in how python installations allow for files to be overridden without any warning. (Not sure if that situation has changed with modern pip.)
Unfortunately, b/c python allow that, many projects do this without even noticing. In essence those files are the same see https://github.com/matplotlib/matplotlib/blob/dde274943cd59600ae6e7ddd0c30dd55bb2a1e1f/lib/mpl_toolkits/init.py and https://github.com/matplotlib/basemap/blob/master/lib/mpl_toolkits/init.py, so IMO only matplotlib should package and install the mpl_toolkits __init__.py.
The patch forward would be:

open an issue on the constructor repo to allow for this overwrite, maybe issuing only a warning rather than an error;
open an issue with basemap and matplotlib requesting them to fix it.

I would be open to a patch that fixes this here, in the feedstock, anyone interested in sending a PR?
PS: closing this b/c it is not really an abbatiale issue for the @conda-forge/basemap team.

so IMO only matplotlib should package and install the mpl_toolkits init.py.

Yep, that's exactly my opinion, like stated before:

Looks like this file should be removed during basemap packaging.

It's matplotlib's responsibility to have that __init__.py for the mpl_toolkits subpackage and basemap as it depends on matplotlib should not have that file packaged.

open an issue with basemap and matplotlib requesting them to fix it.

Can we not just do this during basemap conda packaging (that's why I opened the issue here)? I think that would be easiest.. and I don't see how this issue should be closed, to be honest.

Can we not just do this during basemap conda packaging (that's why I opened the issue here)? I think that would be easiest..

Like I said, I'd merge a PR doing that. So you fancy sending it?

and I don't see how this issue should be closed, to be honest.

B/c it is not our responsibility to fix that so constructor can work and I don't want to burden the maintainers here.

Actually, looking at the current matplotlib packages, I don't see that offending mpl_toolkits/__init__.py in them.. which is strange.. so I don't know what the problem really is right now.
@waterazu since you are running into this problem right now.. can you post the list of packages that the constructor is trying to bundle?


Potential OOM bug/exploit in graphite NBT

In crates/graphite_binary/src/nbt/decode.rs the read_list function uses Vec::with_capacity(length as _). However, length has no upper bound. I believe malicious input could potentially allocate i32::MAX * sizeof(usize) bytes.
The other read functions are correctly bounded.

In the specific context of Minecraft, packets have a 2mb limit, so clients cannot simply allocate 2 terabytes.
If you were to impose a limit, what number would it be and what exploits would it prevent?

Should be fixed by aca938b, will leave issue open until confirmation from a second person


Migrate to MkDocs

This PR does the following:

Moves to MkDocs
New syntax highlighting
New Flutter Example
Remove Zap

TODO:

[x] Old Links Should Work
[x] Docs added since this PR was started need to be added back in
[x] Update Favicon
[x] Confirm that code blocks are correct
[x] Web compatibility check
[x] Code Blocks in Tabs
[x] Edit edit_uri
[x] The Change cookie settings link from the footer should be removed since we're not setting any cookies.

Commits are broken up pretty neatly

Nice, thanks!
This looks good, but since most of the content is under "Reference" at the moment, I'd rename the tabs a bit. I think "Documentation & Guides" should be called "Home" (or something like that ?) and "Reference" should probably just be "Documentation".

Only Dark Mode

Is there a reason we support only dark mode? If possible, I'd prefer both, ideally using the  prefers-color-scheme CSS query to determine whether to use dark/light mode.

The syntax highlighting injects the colors using inline css.
Refactoring to use a single style sheet would be very time consuming.
Take a look at the code, most of it was copied from Google/ServerPod

@simolus3
Got some free time. Checkout the new deployment. Uses dark/light mode based on device and has corrected section names

@simolus3 Are you OK with just the not hitting a 404:
/docs/something -> /docs/something-else          (No 404)
/docs/something#header -> /docs/something-else   (Won't go to header)

Or do you need the header (permalinks) to be the same?
/docs/something#header-name -> /docs/something-else#other-header-name   (Won't go to header)

The are tons and tons of permalinks and mapping all of them would be hours of brain numbing work.

@simolus3 I will be using this to create the redirects:
https://docs.netlify.com/routing/redirects/

@simolus3
It's all good to go!
Let me know If there is something I've missed

@simolus3
Flutter broke webdev with the latest release of devtools_shared: https://github.com/dart-lang/webdev/issues/2492

Aaaand now I'm done.
Just a couple more fixes.

Thank you very much, this looks great! I'll take a deeper look at this soon, just some quick thoughts:

Do we depend on Flutter for building the docs now? If so, I think we can remove the stubs packages and just use the proper dependencies?
We're still using a custom highlighter, right? Is it possible to inject something into the CSS generated by Material for MkDocs (e.g. is there some hooks sass file that we can override)? That way we might be able to use predefined classes instead of inline styles. Don't worry about it though, I'm just wondering if it's possible and I can do it myself since I've already caused so much back-and-forth steps with the syntax highlighting.

We have flutter installed so we can build examples/app. I rather not mix the example app project with the docs project.
We are not using inline css for the syntax highlighting. The css for it can be found in docs/docs/css/syntax_highlight.css. You can add more css in that file. You can also create a new css file, just make sure to add an entry for it in extra_css: in mkdocs.yml. We can do SaSS too by compiling it to css before we build the site.

Ah one thing I've forgotten - the deployment previews we generate for branches and PRs must have a noindex, nofollow meta tag for search engines so that they can't show up in favor of the main website. The older docs were able to do that with different builder configurations. Is there a way to do the same with MkDocs (or do we have the option to build a dev variant of the site that has those tags)

Is there anything I missed which is holding this PR up?
I've started working on the rewrite and would love to get this done sooner than later.

Apologies on the delays reviewing this. I've taken another look, and only two remaining things stood out to me. Once the first one is addressed we can merge this:

When I run ./docs.sh serve, generated build assets like compatibility.dart.js are not served. Is this intentional? Even --with-build-runner does not include any output argument, so the compiled files are not visible. I get that we can't rebuild the Flutter example on every edit, but is it possible to bring build and serve closer together and very clearly document the remaining differences?
(we can do this one after the merge) If possible, can we avoid spaces in the URI and use custom paths (e.g. /Generation options -> /generation_options) instead? Browsers should copy them with %20, but these still look a bit ugly and might be harder to share because some messengers don't recognize the entire URL.

Will do.
This is because the docs folders have spaces in their names. I'll fix this during the rewrite.

I've renamed the folders so that there are no spaces & added clearer docs.sh serve docs to the ReadMe.md
The web build and the Flutter example project don't change often, so we don't think the serve command needs to include them. The serve command is a simple utility for writing documentation with hot reload, and that's all it needs to focus on.

Building once is sufficient, thanks! I just noticed this because the interactive feature detection on /web was broken since I've used serve without ever running build.

@simolus3 How does the production site get released?

It's released when I push to the latest-release branch, which I do after a drift release so that newer APIs mentioned in the docs don't confuse users.

Finally released :rocket:

Look'n good!


Find a consultant modal  - Search results  - User has to click on the image now to select consultant

Expected behavior
On the find a consultant search results, we should be able to click anywhere in the box to select the consultant.

Actual behavior
User has to click on the photo image to select the consultant.
Steps to reproduce behavior
Click find a consultant
Search
View results and attempt to select the consultant by clicking anywhere in the box.

Created a ticket for this issue: https://razoyo.atlassian.net/browse/TST-159

8-12 SH  - Fixed.


Add x-axis description to the export diagram

Scott,
you've mentioned something about rendering svg instead of png files. Since the image rendering code is a mess, I would be happy to rewrite it. Would you recommend any library for svg rendering?

personal favorite is d3, snapsvg might be worth a look too. d3 will run on the server, which is nice for this use case.

here's a start https://github.com/ScottWeinstein/wardleymapstool/compare/svg-client-11?expand=1

this is now done.


Implement logic for ScheduleSpec.startingDeadline

The ScheduleSpec defines a property startingDeadline which defaults to 15 minutes. This property is currently never evaluated. The doc says
"startingDeadlineSeconds" : 60, // Deadline in seconds for starting the job if it misses scheduled time for any reason. Missed jobs executions will be counted as failed ones.

If we want to support the above (Missed jobs executions will be counted as failed ones) then we need to store a failed JobRun if we missed the timeframe to start it.

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-1599. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.


Fix clippy warnings with newer Rust

Similar to:

https://github.com/heroku/buildpacks-python/blob/bb0264c8bb0c8b429951c97bf9fdfb894bb78878/Cargo.toml#L15-L16
https://github.com/heroku/buildpacks-ruby/pull/314/commits/87c5302be420e394d3d8a2cbb6dc95df82ab6b79

$ cargo clippy --all-targets --all-features -- --deny warnings
    Checking num-rational v0.4.2
   Compiling libcnb-proc-macros v0.22.0 (/Users/rschneeman/Documents/projects/work/libcnb.rs/libcnb-proc-macros)
    Checking libcnb-common v0.22.0 (/Users/rschneeman/Documents/projects/work/libcnb.rs/libcnb-common)
    Checking time v0.3.30
    Checking ahash v0.8.11
    Checking opentelemetry_sdk v0.21.2
error: lint group `pedantic` has the same priority (0) as a lint
  --> Cargo.toml:33:1
   |
33 | pedantic = "warn"
   | ^^^^^^^^   ------ has an implicit priority of 0
34 | unwrap_used = "warn"
   | ----------- has the same priority as this lint
   |
   = note: the order of the lints in the table is ignored by Cargo
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
   = note: `#[deny(clippy::lint_groups_priority)]` on by default
help: to have lints override the group set `pedantic` to a lower priority
   |
33 | pedantic = { level = "warn", priority = -1 }
   |            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Thank you!


Flexible Pricing: Add additional relationship columns to FlexiblePrice

We need to be able to associate a learner's request for flexible pricing to a specific program or (at a later date) course. Since these are two different tables, we need to use Django's contenttypes framework to accomplish this. We also need to be able to associate aFlexiblePrice record with the FlexiblePriceTier that they are assigned.

Add a GenericForeignKey to FlexiblePrice that can point at either a Program or a Course.
Add a nullable, null by default, ForeignKey column to FlexiblePrice that points to FlexiblePriceTier.

There is a confusion over this point.

Add a GenericForeignKey to FlexiblePrice that can point at either a Program or a Course.

FlexiblePrice model do not have any courseware_object_id field but we introduced a GenericForeignKey courseware_object = GenericForeignKey('courseware_content_type', 'courseware_object_id') in FlexiblePriceTier.
Can you tell me do we need GenericForeignKey to FlexiblePrice model ?

@asadiqbal08 please take  a look on my PR https://github.com/mitodl/mitxonline/pull/580

https://github.com/mitodl/mitxonline/pull/580


task: Longhorn v1.1.0 release chart

Need to update Rancher charts for Longhorn v1.1.0 release.

The test Chart for Cluster Manager: https://github.com/shuo-wu/charts/ branch master
The test Chart for Cluster Explorer: https://github.com/shuo-wu/charts/ branch dev-v2.5

Validated Using the Provided charts: LGTM


ktlint incorrectly reports redundant toString

The super.toString() call is incorrectly reported even though there is no other way to get the super class's string:
override fun toString(): String = "${super.toString()}, selectedValueKey=$selectedValueKey"

Thank you for the ticket. Fixed in 0.9.1 (it should become available through Maven Central within the next ~25 minutes).

@shyiko Damn that was fast! 😄 Thanks!


If you plan to share anime episodes after upscaling using this, please read.

I uploaded Death Note EP 01 as a test at 960p on nyaa.
And they deleted it a few min later.
Here is the chat:
http://s7.postimg.org/9shb2sjbf/Nyaa_Mod.jpg
And here is the Episode in case you want to watch it:
[deleted by admin]

can not download...
May you upload some snapshots of video?
like?
snapshot(original) VS snapshots(waifu2x)

use this: http://yukinoshita.eu/ddl/[Unk] Death Note 01 [Dual Audio][960p].mkv

Please don't share illegal videos in my repository.

@BrokenSilence
Maybe different drawing type of animation will be better.
Thanks for sharing! We may use GIF to communicate nexttime.

Eh i mean. It should not be listed as a normal video then. If the title says something like: 720p UPSCALED TO 1080p. Then it's alright in my opinion.


RuntimeException: "Could not create parent directory for lock file" when running with systemd-run

Expected Behavior
It builds just fine, without errors, just like outside of the sandbox.
Current Behavior
Exception in thread "main" java.lang.RuntimeException: Could not create parent directory for lock file /.gradle/wrapper/dists/gradle-6.3-bin/8tpu6egwsccjzp10c1jckl0rx/gradle-6.3-bin.zip.lck
	at org.gradle.wrapper.ExclusiveFileAccessManager.access(ExclusiveFileAccessManager.java:43)
	at org.gradle.wrapper.Install.createDist(Install.java:48)
	at org.gradle.wrapper.WrapperExecutor.execute(WrapperExecutor.java:107)
	at org.gradle.wrapper.GradleWrapperMain.main(GradleWrapperMain.java:63)
Finished with result: exit-code

Context
I packaged my application built with Gradle for Arch Linux. However building it fails when some sandboxing options are enabled (running the build with DynamicUsers using systemd-run).
Steps to Reproduce
Method A

git clone https://github.com/Minecraft-Technik-Wiki/BlockMap
cd BlockMap
sudo systemd-run --service-type=oneshot --pipe --wait --pty -p DynamicUser=yes -E HOME=/tmp -p WorkingDirectory=$PWD bash -c "GRADLE_USER_HOME=$PWD/gradle;$PWD/gradlew --no-daemon"

This may be reproducible with other Gradle repositories, but I know that the application "JabRef" (which is packaged in a similar way) does not have this issue, so there's no guarantee.
Method B
See https://github.com/actionless/pikaur/issues/498
Your Environment
------------------------------------------------------------
Gradle 6.3
------------------------------------------------------------

Build time:   2020-03-24 19:52:07 UTC
Revision:     bacd40b727b0130eeac8855ae3f9fd9a0b207c60

Kotlin:       1.3.70
Groovy:       2.5.10
Ant:          Apache Ant(TM) version 1.10.7 compiled on September 1 2019
JVM:          14.0.1-internal (Oracle Corporation 14.0.1-internal+0-adhoc..jdk14u-jdk-14.0.1-ga)
OS:           Linux 5.7.4-arch1-1 amd64

Still occurring on gradle 7.0.2

Can you try passing -g $PWD/gradle instead of the inline env var? Which I believe is ignored because of the ; between it and the invocation of Gradle.


Remove counterpart and add react-intl to handle i18n

Screenshot taken with the generated app with react-intl (see Logout which is translated):


Portfolio chart

Add a chart displaying historical portfolio value for the connected wallet.
Description

Add selectors to calculate portfolio value
Adjust hooks to query all portfolio data on the dashboard

Related issue

#761
Fixes #2024

Screenshots (if appropriate):

Dashboard/History page results in application error on this deployment

@platschi This crash is fixed

@platschi marking this ready for review now. We do not currently have a CTA for this, so if there is not enough data I just left the chart blank. In this case, the CTA just below will be displayed showing a link to perps on the position table.

ahhh man so stoked for this!!!!!!!

could you add a standard 8px border radius?

@platschi marking this ready for review now. We do not currently have a CTA for this, so if there is not enough data I just left the chart blank. In this case, the CTA just below will be displayed showing a link to perps on the position table.

will make a CTA for a blank chart now

could you simplify the date format?

maybe just "month/date" for longer ranges:

"weekday, time" for medium ranges:

am/pm for short ranges:

@asherism @platschi I've fixed the comments from Yashar, ready for another review.

@asherism My mistake, I addressed all of your comments but one 😂

@asherism My mistake, I addressed all of your comments but one 😂

all good, i was actually able to bypass by switching wallets again but it does after a short while break again

On mobile, after connecting via rainbow wallet to a wallet that has an open position, the default CTA does not switch to the portfolio chart. switching pages/page refresh does not help.


pod specification to install ObjectMapper for Swift 3

Hello,
Sorry I know this is not an issue but I can't find a way to install the ObjectMapper version that run with swift 3.
Could anybody help me please?
Thanks

You should use the 2.0.0 version.
pod 'ObjectMapper', '~> 2.0.0'

Thanks @cristiansimioni I appreciate your help, I installed but I got the following error when I compile the project:
/Users/jperera/Documents/GitRepository/MySecurityAccount/MySecurityAccount/Contact.swift:10:8: Module file was created by an older version of the compiler; rebuild 'ObjectMapper' and try again: /Users/jperera/Library/Developer/Xcode/DerivedData/MySecurityAccount-cgpdohozsvhpevhjubironbdencq/Build/Products/Debug-iphonesimulator/ObjectMapper.framework/Modules/ObjectMapper.swiftmodule/x86_64.swiftmodule
Any idea of this?

I was facing something similar this week. I solved it following the steps below:

On Xcode, navigate to Product and hit Clean
Close Xcode
Open a console and delete DerivedData folder
cd ~/Library/Developer/Xcode/
rm -rf DerivedData/
Open Xcode and try again.

Same issue trying clean build .....but no luck


fix: Chat blinks when txt attachment is uploaded

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/48697
PROPOSAL: https://github.com/Expensify/App/issues/48697#issuecomment-2342661795
Tests

Log in with a Gmail account
Open any 1:1 chat
Send a txt attachment
Verify that: Chat doesn't blink when txt attachment is uploaded.

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Log in with a Gmail account
Open any 1:1 chat
Send a txt attachment
Verify that: Chat doesn't blink when txt attachment is uploaded.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/bfc26fca-f10e-4c15-9b49-f4f3b3cb2a36

Android: mWeb Chrome

https://github.com/user-attachments/assets/a2fe29ce-3cf9-48f9-8b10-4975ab46bbea

iOS: Native

https://github.com/user-attachments/assets/772430fd-8efe-4834-ac81-531ac303bce0

iOS: mWeb Safari

https://github.com/user-attachments/assets/d8776883-7a03-45a9-b067-e78ea44f7b91

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/b89b213f-7375-4635-a7b9-73906f71cd09

MacOS: Desktop

https://github.com/user-attachments/assets/9744df32-9bcd-4c47-851e-677099e248a5

I am a little stuck on the Android Native builds, will add the screenshot later

@getusha friendly bump

@getusha bump again

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


Attachments branch

Changed the way the ship communicates with weapons to be directly through the hardpoints, giving the hardpoints the ability to communicate to it's attachment. I created two enums (Size and Types) that can be used to determine how things can fit if needed, and the hardpoints can use the attachment through the inherited Use method (this is a rename of the FireWeapon method to allow for easier abstraction).

Closing to fix up my code to better fit the guidelines.


[Dynamic Spec Decoding] Auto-disable by the running queue size

The first PR for #4565.
This PR adds an auto-disable mechanism to speculative decoding. Specifically, we allow users to set a threshold, in terms of the number of requests in the current running queue, to disable speculative decoding for new incoming requests.
Example usage: --speculative-disable-queue-size 4. This means to disable speculative decoding for the current batch of requests if running queue has more than 4 requests.
cc @cadedaniel @LiuXiaoxuanPKU @leiwen83
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

QQ: can you also update the benchmark result?

The current speculative decoding performance isn't good enough due to the lack of bonus token, so the benchmark result may be less meaningful. We should perform another round of benchmarking later once all missing pieces are in place.

It's discussed in #4212 and should be the latter case you mentioned. On the other hand, it does affect the performance a lot in certain cases. First, without a bonus token, there's no guarantee that each step will generate at least one token. Second, inter-token-latency (ITL) can be calculated by decoding-step-latency / accepted-tokens-in-this-step, so assuming the number of speculative tokens is 5 and the acceptance rate without the bonus token is 60%, then we accept 3 tokens in a step, meaning that ITL=L/3. However, with a bonus token, it will be ITL=L/4, which is 33% speedup.

Updated on reject sampler (cc @cadedaniel for reviewing these API changes of reject sampler):

Enable bonus token for PLD.
Disable strict_mode using environment variable VLLM_DISABLE_REJECT_SAMPLING_STRICT_MODE.

With these updates, the performance should be acceptable, so I'll try to benchmark on A100 when I got a chance, but this should not be a blocker of this PR.

Disable strict_mode using environment variable VLLM_DISABLE_REJECT_SAMPLING_STRICT_MODE.

This is not necessary; we can simply set strict_mode to False (we only had it in for development correctness, now we can disable it outside of unit tests).

tests failing unfortunately

tests failing unfortunately

The failed test seems flaky. I found the same 2 spec decode tests failed in the main branch as well. Should retry all failed tests.

seems since https://github.com/vllm-project/vllm/pull/4551 was merged it caused that test to fail on the main branch. investigating..

There's an inefficient allocation during spec decode which can cause OOM when paired with a large batch size. I lowered the batch size in that test, it passes locally for me.

Thanks for fixing that! Could you help retry the failed tests again?

Retried

retry again?

@richardliaw seems it’s waiting for compute. I found this out by opening the buildkite link.

retry again?

It is retrying automatically but waiting for the resource...

As you pointed out, my previous description about generating at least one token is incorrect. The one that guarantees at least one token to be generated in each step is called "recover" token, which is different from the bonus token. Bonus token is only accepted when all speculative tokens are accepted.

So in the second scenario L=5 (0-4 th tokens are fed into the target model); in the first, L=6 (0-5th tokens are fed into the target model) regardless of whether the request has been all accepted to the end or not.

Yes, we always feed L tokens proposed by the draft model to the target model whatever the proposed tokens are accepted or not. Let me try to summarize the steps in my words:

[Propose] Run draft model for L steps to generate L speculative tokens.
[Verify] Run target model with the L speculative tokens at once to generate kv-cache and logprobs. Because of that, the (L+1)th token is automatically generated by the target model.
[Sample] Decide how many speculative tokens should be accepted.
If all tokens are accepted, we feed the bonus token generated by the target model to the draft model to update its kv-cache.

Thus, the cost of bonus token is step 4, which updates the kv-cache of the draft model. And this is the feature vLLM currently missing (but we will add it soon). Fortunately, some speculative decoding methods such as prompt lookup decoding (i.e., n-gram) don't need a draft model, so bonus token is completely free.


nTimeout in OS_WaitForSemaphore, OS_WaitEvent not implemented

1. SDK version（SDK 版本）
{
Commit Hash 112593b8784794315b0e0aaa3fdf03438599c684
}

2. In what kind of operation problems appear, and how to reproduce the problem ?（什么样的操作步骤问题会出现，是否是稳定复现，如何复现问题？）
{
As written in the Documentation, the parameter nTimeout in OS_WaitForSemaphore and OS_WaitEvent is not implemented right now and needs to the set to OS_TIME_OUT_WAIT_FOREVER. Having a proper timeout in milliseconds working would help alot to be able to avoid polling and use event-driven programming instead.
The only workaround I've found is using OS_StartCallbackTimer to unlock the semaphore in case the timeout runs out, similar to https://github.com/Ai-Thinker-Open/GPRS_C_SDK/blob/605262ba65d92086715e03369f670ff353a9c3b2/libs/gps/src/gps.c#L414
}

any updates here?

any updates here?


Cannot reproduce the results of the paper

I trained the model based on Airfrans data using the script provided in the github repository, and the model uses transolver, but the convergence is as shown in the figure below, and the loss decreases very slowly, which doesn't seem to be in line with the results mentioned in the paper.

Are there any parameters I should adjust?

Hi, thanks for your experiment.
We do not report the training log in AirfRANS. As we stated in README.md, you can need to execute bash scripts/Evaluation.sh to test the model. The final performance will be saved in scores/score.json.
You do not need to change any parameter in our provided scripts. The final spearman coefficient of lift coefficient will be 0.9978234455861399 in our experiments.


Forbid editing functions on head

No CRDT on head, since it should be set from an apply
Stop creating two change-sets (saving on the edit and then on unmount)
Create new change-set with the updated func, leaving head untouched

bors merge


Not clear how to set up the first passkey

After running, it just shows an empty list "No identities in vault". it's not clear what to do. There's also no quickstart/tutorial.
Adding a link to a tutorial on this screen, especially on the first run would help..

Even with playing around, I cannot figure out how to use the tool. ;-)
Chrome is able to talk to bulwark

but when I approve, and select "USB security key" in Chrome, nothing happens

What I noticed: bulwark already asks me to authorize the process ("user presence"?) before I even select what device I want to use. Is it possible that you ask the user for confirmation already when the browser is only enumerating devices (checking with FIDO tokens are available) and not yet initiating the registration process? Thus, when the actual registration process starts, bulwark is not acting anymore.


Follow-up on SSL support for non-Go (and non-Java)

This PR changes how we find libssl.so. I used the CGO instead, so we don't depend on ldconfig anymore. This PR also adds a hook on SSL_shutdown to clean up the LRU map.

This unfortunately doesn't work well with Docker. I'm going to close this for now.


WIP DST 466

The show condition was pointing at the incorrect dictionary key for the forms data. Updating the key has corrected the issue.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.96%. Comparing base (f27a774) to head (705f2a2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage   80.96%   80.96%
=======================================
  Files          64       64
  Lines        2159     2159
=======================================
  Hits         1748     1748
  Misses        411      411

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


exitOnError prints %!(EXTRA string="the error...")

$ ./bin/subctl deploy-broker
The provided kubeconfig is invalid%!(EXTRA string=stat clusterB/auth/kubeconfig: no such file or directory)
We should convert error to string with err.string() before printing it out.

%!(EXTRA string= is because of incorrect format of fmt (https://golang.org/pkg/fmt/). Adding %s removes it.
exitOnError("Unable to determine the Kubernetes connection configuration: %s", err)
But the word 'stat' is present which I am guessing is part of err.
output:
Unable to determine the Kubernetes connection configuration: stat /path/to/kubeconfig: no such file or directory
This applies to all exitOnError functions.
I used exitOnError in  PR #127 with %s and am getting proper error message.
./bin/subctl join --kubeconfig ~/path/to/kubeconfig
Argument missing: broker-info.subm file generated by 'subctl deploy-broker' not passed


RFC 0028 - Enhance request message

Problem
The request message of the Introduce protocol assumes both introducees already know each other - they just haven't formed a "DIDComm" connection between them.
The above assumption leaves out a large swathe of real-life introductions where the two introducees have no previous knowledge of each other.
Furthermore, requests for introductions in these types of scenarios typically include prerequisites:

My kitchen sink is clogged and leaking, can you recommend a good plumber?
We're thinking of buying a house - can you introduce me to your tax consultant?

Proposal
To address the first issue (no prior knowledge), let's explicitly make name  an optional attribute of please_introduce_to.
I'm open to ideas to address the second issue (prerequisites). The key thing is that the requestor needs to convey the requisites to the Introducer, narrowing down for the latter the space of potential introducees to provide.
To me it seems like a good aproach would include the request-presentations~attach object from the Present Proof Protocol in a semantically meaningful way for the Introducer to understand that the request for proof is not for them to fulfill - it is for them to relay that request to the potential candidate introducees on behalf of the original requestor.

One potential consequence of this approach is that due to the fact that several prerequisites might be specified, a series of introductions might ensue if the Introducer does not know of a single party that satisfies all criteria, but knows several that, overall, satisfy them all.

@llorllale The docs on the protocol give the wrong impression if they suggest that the two parties know each other. The assumption I was going for was that the two parties know some shared context. It might be that Fred verbally told each of them that he had a nice friend he wanted to introduce, but it was never intended to be stronger than that. So we should definitely revise the RFC to make that clearer, as you suggest. I will come up with a revision and run it by you. Let's collaborate.
On the topic of prerequisites, I agree that this is a useful feature. I am pondering the best way to do it. I'll leave comments here as soon as I have some thoughts--or you can, if you beat me to it.

@dhh1128 can we agree on this general outline of events?

Introducee requests the Introducer to introduce them to parties that collectively satisfy a set of criteria
Introducer does best effort to satisfy that request. It may find one party that matches all criteria or it may find N parties that each individually match a subset of the criteria
2.1. If Introducee cannot satisfy any of the criteria, it should inform the Introducee to make a decision.
2.2. If Introducee gives a positive response, the protocol's state can proceed to the next step
Introducee instantiates N rounds of the introduce protocol

@llorllale Generally, I like that. However, I think sometimes the introducer, not the introducee, begins the process. ("Alice, would you mind if I introduced you to my friend George?") It's not always the case that the introducee is the first mover, and has crisp criteria in mind. So we need a way to allow both variants.

@dhh1128 yes - I am focusing on the flow initiated by the introducee as I feel the one started by the introducer is fairly complete

@dhh1128 how can we move this forward. I have a sketch of the sequence of messages - I'm not sure if I should dump all those here (it's a bit long). And this issue is assigned to you, so I'm not sure if I can push a PR for this.

I am interested in this topic, but buried by other priorities. I like your thinking and would be excited if you moved the ball forward by raising a PR. I don't mind raising a PR myself, but if I'm the one that does it, it will probably be slow to happen. Up to you.
One other way, besides a PR, that we could move this forward would be to convene a conversation about it. Since we're the only two talking, it could just be between us. But we could also take it broader, if you feel the need for more input. If you keep it pairwise, I'll send you a DM on chat about how to book me.


Adding Spock

https://github.com/fidelity/spock

@ncilfone
Hey,
Thanks for the contribution.
Unfortunately, it seems the code has some issues:

It conflicts with main (probably because of another merged PR)
There's currently no Configuration category and I assume it's too narrow to fit the project. You can add it in a different category though.
I can't see Spock in the preview (see the Netlify comment), which means there's something wrong with the YAML (maybe it's the category?).

Awaiting your fixes :)
Thanks!

@SnirShechter

Rebased to main. Should be good now.
Changed the category
Looks like it's showing up in the preview now.

Thanks!


Not discoverable

Is there a reason this documentation is not discoverable through the navigation (for example How-to > Secure app)?
This is a very frequent subject for customer inquiries so it would be helpful to have up-to-date and easily accessible official information.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d90bbf62-44f9-30a6-d6ea-bbf776f6efc5
Version Independent ID: b3961eac-6c70-b345-f48c-e4c0ec67059c
Content: Azure App Service IP Restrictions
Content Source: articles/app-service/app-service-ip-restrictions.md
Service: app-service-web
GitHub Login: @btardif
Microsoft Alias: byvinyal

FYI, I arrived at this page from the link under "Security and compliance" here:
https://docs.microsoft.com/en-us/azure/app-service/app-service-web-overview#why-use-web-apps

Adding @cephalin

Is there any documentation on configuring these rules using powershell?

-Disregard the above, got it figured out...
$ExistingConfig = Get-AzureRmResource -ResourceGroupName $ResourceGroup -ResourceType Microsoft.Web/sites/config -ResourceName $WebAppName -ApiVersion 2016-08-01
$ExistingConfig.Properties.ipSecurityRestrictions = 'values'
$ExistingConfig | Set-AzureRmResource -ApiVersion 2016-08-01 -Force

fixed. #please-close

@dcbrown16
We will now close this issue. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Typos and incorrect font type in some descriptions

Hi all,
I have read the latest commits (3369da4 7a76c5d) and found some typos and incorrect font type in some descriptions in the latest commits:

Some "SID" words haven't be renamed to RRID.
Details are from IOPMP TG mailing list: https://lists.riscv.org/g/tech-iopmp/message/277

In Section 2.7 Error Reactions

    Return                                                                          .
    VVVVVV                                                                          V
 2. Retrun bus error (or a decode error) or not with an implementation-defined value;

ERR_REQINFO.v should be *ERR_REQINFO.v* at https://github.com/riscv-non-isa/iopmp-spec/blob/main/chapter2.adoc?plain=1#L80 (Section 2.7 Error Reactions)

MDCFG(m).t and MDCFG(m+1).t should be *MDCFG(_m_).t* and *MDCFG(_m_+1).t* at https://github.com/riscv-non-isa/iopmp-spec/blob/main/chapter3.adoc?plain=1#L19 (Section 3.1 Full Model)

MDCFG(0), MDCFG(j) and j should be *MDCFG(0)*, *MDCFG(_j_)* and _j_ at https://github.com/riscv-non-isa/iopmp-spec/blob/main/chapter3.adoc?plain=1#L63 (Section 3.3.2 Rapid-K model)

ENTRYLCK.f should be *ENTRYLCK.f* at https://github.com/riscv-non-isa/iopmp-spec/blob/main/chapter3.adoc?plain=1#L85 (Section 3.3.7 Prelocked Configurations)

Thanks for you feedback, updated, will be available on next push.


How do you open bottomsheet from a view model

Hi
thank you for this control
I have many scenarios where instead of displaying an alert /dialog from a viewmodel I would like to display a bottomsheet?
What is your approach?
thanks

I want to open the TapGestureRecognizer object in a collectionview object when clicked. How can we do it?


exports-loader

I'm trying to get a computer-vision library to work with my create-react-app. Specifically either tracking.js or js-objectdetect. The problem with both these awesome libraries is that they are written as IIFE with no export statements e.g.
(function(){...})()
They are supposed to be imported as <script src = 'etc'> so I can't seem to just import them as normal and follow the API without getting
TypeError: foo.bah is not a constructor
I tried adding my own export statements but a can of worms exploded out of it!
Apparently I could use the webpack exports-loader but adding that in a create-react-app opens another can of worms. What is the right way to deal with this scenario?

If the scripts are not modules then there is no need to use the module syntax for them. Just use scripts tags as suggested in their documentation.
For example, with tracking.js you can add this to public/index.html:
    <script src="%PUBLIC_URL%/tracking.min.js">

Then in the code you can:
const tracking = window.tracking;

const colors = new tracking.ColorTracker(['magenta', 'cyan', 'yellow']);
// ...

This assumes that you put tracking-min.js in your public folder.
Finally I would suggest raising an issue to tell the maintainers that their library’s npm distribution does not work with CommonJS environments (such as Webpack) and propose that they export a UMD version.
I hope this helps!

Looking at the code it seems like you could also do
import 'tracking';

as first statement in src/index.js and then use window.tracking everywhere.
Again, the fact that normal import syntax doesn’t work is unfortunate, but it’s easy to fix for the maintainers if they adopt UMD wrapper instead of always putting the export on a global.

@howardkitto You can also try react-app-rewired to modify your webpack config without ejecting from create-react-app.

IMO there's no need to do anything Webpack-specific here. The problem has nothing to do with Webpack per se.

Thank you so much for your help. Here is a working version...
https://github.com/howardkitto/react-tracking


Added -x/--line-regexp (match whole line) option

ag already has the -w option, and this seems a fairly obvious complement to it, so i'm worried that this was requested and rejected at some point in the past. However, i can't find anything in the list of issues to confirm that so... here we go.
Just in case it's not super clear, -x is an option described in the POSIX specification for grep which causes the pattern to match on whole lines only. In other words, grep -x 'foo' has the same effect as grep '^foo$'.
This is an option that i miss a lot when using ag, so i thought i'd try to add it. Sorry if it's shit, this is only like the second time i've really done anything in C. I also added some cram tests for both this option and the existing -w.
Added -x/--line-regexp (match whole line) option
- Added -x functionality (like `grep`) for literal and non-literal matching
- Options -w and -x are mutually exclusive
- Added cram tests for -w and -x options

https://github.com/ggreer/the_silver_searcher/issues/626


Kernel backdoor is not istalled run a kernel exploit and try again

Not open FBI please help me please

Exactly as it says, run a kernel exploit before FBI.

How do you do

On 11.3, you don't (can't). Earlier versions, run fasthax first. Please ask these things on a forum next time as github is not a forum.


Select white text in dark mode

Seems only happened on Windows. Can you try if this works for you https://codepen.io/AndyJepkes/pen/gpbwVG ? Thanks

Seems only happened on Windows. Can you try if this works for you https://codepen.io/AndyJepkes/pen/gpbwVG ? Thanks

The codepen works on Linux 👍🏼

The codepen works on Linux 👍🏼

@smhmd Just updated, can you help to check out if that works for you?

@smhmd Just updated, can you help to check out if that works for you?

Works!

Works!


Improved sign up experience for events

Who is your user?
Collectives that host events and do ticketing through Open Collective. (Posting this on behalf of a user that sent an email to support)
What are they trying to achieve?

We have been using the events feature on the Open Collective platform as a means to check in people to our in-person events as a way to keep track of attendance in the same place where people and organizations can donate to us."
A frequent complaint that we have is that the Captcha feature is annoying and too complicated. For instance, in the last event, someone failed the Captcha 3 times and ended up not checking in. I understand that this is for security reasons, but would there be a way to make the experience simpler and smoother?
An idea would be to add types of events when an admin is creating a new event. In our case, we make use of events for attendance purposes only, so it would make sense to allow only attendees to get tickets during the duration of the event. This could potentially eliminate the need for a Captcha. On a related note, we did a test and we were able to get a ticket to a past event.
Another suggestion to work around this issue would be to allow the possibility to confirm check-in by email, where the person would enter their email and then confirm attendance by clicking on the link sent to their email.
Lastly, I have noticed that if someone is not logged in to the Open Collective platform, they are not able to see how many people attended each event. This is not ideal for us, because we are trying to collect data in this platform so that potential financial sponsors can see the work we have been doing and the dimension of our community when they come to this page. Would it be possible to have the total number of attendees as part of the event summary? Currently, it says "Attended by" followed by the initials of the first 4 people who signed up. Then, even if you are signed up, you need to click the event to see the count of people who attended. An more helpful alternative would be to show "Attended by" followed by "{initials of the first person who checked in} and {number of remaining check-ins}".

How are they currently doing this?

They are using the events feature normally, but are suggesting some updates that would work better for their use case.
How well understood is this problem?

[x] Surfacing: if you feel this is a seed of an idea that needs to be researched.
[ ] Understanding: if you've done some research and feel it is already well understood and ready for shaping.
[ ] Shaping:  if you feel a solution is clearly defined and can be made into a pitch (read more about shaping)
[ ] Pitching: if you feel that it is ready to be presented for prioritisation (read more about pitching)

Trying to summarize this feedback:

Simplify Captcha for Event Check-In (https://github.com/opencollective/opencollective/issues/7302 could help with that)
The "Sponsors and Participants" section is only displayed for logged-in users. I'm not sure about the rationale for this, but I tend to agree with this person that we should show it.

we did a test and we were able to get a ticket to a past event.

This is either because:

They're admins (admins can contribute to an event even after it's over)
Or the event ended less than 24hours ago (there's a grace period)

Moved to https://github.com/opencollective/opencollective/issues/5355


Scroll position is lost when dealing with collection-repeat + modal opening

Let's suppose a tab presenting the view MyList: a list of item using a collection-repeat.
Click on an item, its detail is shown.
Now, go back and...cool the scroll has kept the position ! Everything Ok, since MyList is a cached view .
Now this scenario:
Click on an item, and in its detail page, open a modal (assuming there's button/link opening a modal).
Now, close the modal and go back to the list (through the back button too).
Wow! The scroll has lost the previous position, it's at the top ! => issue
It doesn't happen when using classic ng-repeat.
Is it possible to fix it? It's very annoying regarding UX ;)
Thanks a lot

Greetings, @mica16!
We are now requiring all issues to be submitted through our custom issue form so that we have all of the information necessary to fix them as quickly as possible.
Your progress on this issue has been saved at the following url:
link to Ionic issue form
This issue will be closed if not resubmitted through the form. Please fill out the rest of the form so that we may assist you.
Thank you for allowing me to assist you.

Closed


Make Footer responsiveness in Mobile View   ISSUE #150

I make the change to make it responsive in mobile devices in case of footer.

Conflicting files
login.css
Resolve it & create PR again


Remove restrictions on transformers

Remove the limitation since it is verified that we can work with transformers 4.42.3


docs: Add design document

This adds the project's primary design document.
Signed-off-by: Orel Misan<EMAIL_ADDRESS>

Change: Added table which compares existing similar projects.

Change: Similar projects comparison table - changed a link to a file in test-network-function to belong to a specific tag.

Change: Fixed code review comments.

Change: Fixed review comments.

Change: Fixed review comments by @ormergi.

Change: Fixed review comments suggested by @dankenigsberg.

Change: Rebase
Changed block diagram format to svg.

Change: Rebase
Update block diagram.

Change: Answered a comment.

Change: Rebase
Fixed heading links.
Added namespace administrator persona.
Added namespace administrator use case to third implementation phase.

Change: Fixed notes rendering.

@ormergi

Updating the image tags to the ones available at quay.io/kiagnose will be nice.

Done.

Please consider change the wording "user-supplied ConfigMap" to "checkup ConfigMap".
I dont think user-supplied is the right wording is doesn't sound right to me.

It is supplied by the user, and serves as our main user-interface.
The term user-supplied ConfigMap appears in all of our documentation, feel free to suggest a change in a follow-up PR.

Also using "installation" doesn't sound right (to me), I think we should use "deployment / deploying" instead.

The term installation appears in all of our documentation, feel free to suggest a change in a follow-up PR.

The notes sections are not rendered properly, please make sure each line starts with > or > **_Note_**: (no caps, punctuation at the end), it should fix it.

Thanks, done.

Change: Fixed comments made by @EdDev in an offline discussion.

It is supplied by the user, and serves as our main user-interface. The term user-supplied ConfigMap appears in all of our documentation, feel free to suggest a change in a follow-up PR.

Using supply is wrong, you should use "supply" to describe some kind of resource that one party provide for another.
As far as I understand a checkup configuration is not a resource.

The term installation appears in all of our documentation, feel free to suggest a change in a follow-up PR.

Its a shame that I didn't catch these earlier,I could at least try to prevent other docs to use this wording (taking about both)
If you do agree you can do those changes to this doc (and also at #12), then the follow up PR will be just for
changing the docs that already exists.


Get around the order of adding links

Is there  a way to get around the order of adding links?
I am trying to create a graph that should look like:
a -> b
a -> c
c -> d
When I do:
Node
a = node("a"),
b = node("b"),
c = node("c"),
d = node("d");
a = a.link(b);
a = a.link(c);
c.link(d);

Graph g1 = graph("example1").directed().with(a);

Graphviz.fromGraph(g1).width(200).render(Format.SVG).toFile(new File("src/main/d3/graph1.svg"));

There is no link created from c -> d
I can't link them in the correct order because I don't know from my input.
What is the way to fix this?

I found my problem. Closing this. Thanks!


fix(create-extend-error): handle undefined error#stack

Context
Most of the non-V8 powered browsers haven't implemented Error#captureStackTrace API due to which stack trace generation fails in browsers like Safari (Mac, iOS). This results in error#stack being undefined in such browsers.
Whoops uses clean-stack v3.0.0 to format the stack trace, wherein clean-stack fails to handle undefined stack parameter which leads to a TypeError being thrown. To be precise, we have seen the following error on iOS Safari - undefined is not an object (evaluating 'stack.replace') which originates from https://github.com/sindresorhus/clean-stack/blob/v3.0.0/index.js#L12
Clean-stack didn't support and handle an undefined value for the stack parameter until v4.1.0 wherein it has started returning undefined if stack is empty.
Changes
Handled the above mentioned case by ensuring cleanstack isn't called unless stack is of type string.
Note: We could've simply upgraded the version of clean-stack but it has started shipping the dist code as ESM which might not be compatible with the build system used by the users of whoops.

Thanks a lot!


improvement: change pva.py to use own SSL connection to new server instead of calling openssl

improvement: change pva.py to use own SSL connection to new server instead of calling openssl
if someone is up for the task pls do so. Don't forget to change the README when openssl is removed

tested and not reliable working in commit:
https://github.com/Cyborgscode/Personal-Voice-Assistent/commit/177c202059711585a2e76ff49912c02a98a066d5


Bf entity context menu style

Hey, I just made a Pull Request!
This fixes #11767.
The code has been adapted to make the icon color configurable in the theme. It is now possible to change the default white color, with the following snippet:
export function createThemeOverrides(theme: BackstageTheme): Overrides {
  return {
    PluginCatalogEntityContextMenu: {
      button: {
        color: 'blue',
      },
    },
...

:heavy_check_mark: Checklist

[X] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[X] Screenshots attached (for UI changes)
[X] All your commits have a Signed-off-by line in the message. (more info)

Hi @benjdlambert, I have adjusted the code so that the behavior of the "3 dots icon" is the same as the header title and header subtitle:

by default, they will have a color set to theme.palette.bursts.fontColor
since the theme designer is already able to individually override the title and subtitle colors
he now can also change the '3 dots icon' color

This was actually something I needed for my custom theme (the title and subtitle do not have the same color and were overridden - ignoring the bursts color).
Hope that helps :-)

Hi @wasadigi and @benjdlambert, sorry to randomly inject myself but wanted to mention there was some effort going on to deprecate the bursts object/property entirely. I just haven't been able to get it done: https://github.com/backstage/backstage/pull/10145#issuecomment-1067736470

Hey, I haven't really looked at everything that needs to happen (across the codebase) to remove bursts. Once this is done, it would be easy to adapt the context menu. But the basic question remains: do we want to give the flexibility to override all elements of the header (title, subtitle, context menu icon), OR do we want to enforce that there is a single "text colour" property, applied to all 3 elements.
Since the initial question came up after I created a custom theme, and took advantage of the existing ability to set the color of the title and subtitle, I guess that other theme authors might have done the same.

Hey, sorry I seemed to miss the notifications for this and haven't seen the replies. Apologies @wasadigi.
Ok, so I think to be honest it's fine to use the bursts thing for now whilst it's not deprecated, and maybe when you get round to the deprecation we can move it over to something sane then rather than worrying about that in this PR?
This PR still needs DCO signing also, and theres some additional file in here that looks like it's autogenerated from an IDE or something? :pray:

No worries @benjdlambert. I will fix the issue with the extra file, it's a mistake. Thanks for the feedback!

There's also some help for the DCO failure here: https://github.com/backstage/backstage/pull/11769/checks?check_run_id=6743102252

Thank you for your help and your patience :-).
By the way, when I had to regenerate the api-report.md, it took me some time to find the command that I had to run. I found it in the package.json file, but I remember to have seen it somewhere in the documentation or in the repo... but I cannot find the info anymore.
Do you know where it is?

@wasadigi At the moment it's only highlighted in CI logs when encountering the error, with the command that needs to be run


problems on iOS

There is a problem with sending / receiving messages on iOS.
For example this piece of code:
on client:
this.socket.emit("string", "SOME STRING");

on server:
socket.on('string', (value: string) => {
    console.log("Received string from client: " + value);
}

writes to console this: Received string from client:  undefined
The same problem is observed on sending / receiving JSON objects and on both direction: from client to server and vise versa
Full example of this problem is available at https://github.com/AlexanderRay/socketIoWithIosIssue

@budilovskiy
so did you solve this problem?
I have got same problem.

@budilovskiy
@triniwiz
so did you solve this problem?
I have got same problem.

@okdevwww
@juanitozambada
No, unfortunately, I did not solve the problem


add exists static method to models

I would find it useful to have a static method for models like in Active Record. It would use a primary key value as input and return True or False if the entry is there or not.
For a  User model it would be called like this:
User.exists("some-user-id")
True

@stevearc Thank you for adding this!


Hoglins are not scared of portals

This is accomplished in vanilla by having minecraft:nether_portal be added to #minecraft:hoglin_repellents, so the equivalent block added by Immersive Portals should probably do the same.

This issue still exists in the 1.17 version of IP.


ci(action): 配置ci触发规则

:tada: This PR is included in version 1.1.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


az keyvault network-rule add --subnet {subnet id here} ..{additional params}... not working

Describe the bug
When I try to pass the subnet ID in for the --subnet param it is throwing indicating that it doesn't see it as valid input.  Perhaps there is a max length I am exceeding?
subnetId=$(az network vnet subnet show --resource-group $vnetResoureGroup --vnet-name $vnet --name $subnet --query "id" -o tsv);
az keyvault network-rule add --name $keyvault --resource-group $kvResourceGroup --subnet $subnetId
Output: incorrect usage: [--subnet ID | --subnet NAME --vnet-name NAME]
Note: I have tried various output forms and even just manually executed the same command withe the subnet ID surrounded by quotes and without, with the initial '/' and without.
The same approach works fine in powershell:
$vnet = Get-AzVirtualNetwork -Name $VnetName -ResourceGroupName $VnetResourceGroup
$subnet = Get-AzVirtualNetworkSubnetConfig -Name $subnetName -VirtualNetwork $vnet
Add-AzKeyVaultNetworkRule -SubscriptionId $Subscription -ResourceGroupName $KvResourceGroup -VaultName $KeyVault -VirtualNetworkResourceId $subnet.Id -PassThru
Related command
subnetId=$(az network vnet subnet show --resource-group $vnetResoureGroup --vnet-name $vnet --name $subnet --query "id" -o tsv);
az keyvault network-rule add --name $keyvault --resource-group $kvResourceGroup --subnet $subnetId
Errors
incorrect usage: [--subnet ID | --subnet NAME --vnet-name NAME]
Issue script & Debug output
az_command_data_logger: command args: keyvault network-rule add --debug --name {} --resource-group {} --subnet {}
cli.knack.cli: Event: CommandInvoker.OnPreArgumentLoad [<function register_global_subscription_argument..add_subscription_parameter at 0x000002127250F600>]
cli.knack.cli: Event: CommandInvoker.OnPostArgumentLoad []
cli.knack.cli: Event: CommandInvoker.OnPostCommandTableCreate [<function register_ids_argument..add_ids_arguments at 0x000002127254D4E0>, <function register_cache_arguments..add_cache_arguments at 0x000002127254D620>]
cli.knack.cli: Event: CommandInvoker.OnCommandTableLoaded []
cli.knack.cli: Event: CommandInvoker.OnPreParseArgs []
cli.knack.cli: Event: CommandInvoker.OnPostParseArgs [<function OutputProducer.handle_output_argument at 0x0000021270AB6200>, <function CLIQuery.handle_query_parameter at 0x0000021270AE3D80>, <function register_ids_argument..parse_ids_arguments at 0x000002127254D580>]
cli.azure.cli.core.azclierror: Traceback (most recent call last):
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\knack/cli.py", line 233, in invoke
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 652, in execute
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\knack/invocation.py", line 113, in _validation
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 894, in _validate_arg_level
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/keyvault/_validators.py", line 543, in validate_subnet
knack.util.CLIError: incorrect usage: [--subnet ID | --subnet NAME --vnet-name NAME]
cli.azure.cli.core.azclierror: incorrect usage: [--subnet ID | --subnet NAME --vnet-name NAME]
az_command_data_logger: incorrect usage: [--subnet ID | --subnet NAME --vnet-name NAME]
cli.knack.cli: Event: Cli.PostExecute [<function AzCliLogging.deinit_cmd_metadata_logging at 0x0000021272503240>]
Expected behavior
Expected --subnet to recognize the subnet ID as a subnet ID and function as expected
Environment Summary
$ az --version
azure-cli                         2.59.0 *
core                              2.59.0 *
telemetry                          1.1.0
Dependencies:
msal                              1.27.0
azure-mgmt-resource             23.1.0b2
Python location 'C:\Program Files\Microsoft SDKs\Azure\CLI2\python.exe'
Extensions directory 'C:\Users\a525949.azure\cliextensions'
Python (Windows) 3.11.8 (tags/v3.11.8:db85d51, Feb  6 2024, 22:03:32) [MSC v.1937 64 bit (AMD64)]
Legal docs and information: aka.ms/AzureCliLegal
Additional context
No response

Thank you for opening this issue, we will look into it.

Hi @jklaus,
2.59.0 is not the latest Azure CLI(2.61.0).
If you haven't already attempted to do so, please upgrade to the latest Azure CLI version by following https://learn.microsoft.com/en-us/cli/azure/update-azure-cli.

I was seeing the same on our build agents which have the latest.  I also just upgraded my local and I am still seeing the same outcome.

I modified the query for the subnet ID, using jq to handle the parsing now, and it seems to be working fine.  Looking at the output the subnet IDs look the same and I'm still running the same az version.  I am a bit perplexed as to why this is working, perhaps something changed on the backend?


Add code coverage reporting

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@a7df739). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head 8edaa78 differs from pull request most recent head 273b651. Consider uploading reports for the commit 273b651 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main     #130   +/-   ##
=======================================
  Coverage        ?   82.60%
=======================================
  Files           ?        4
  Lines           ?      460
  Branches        ?       33
=======================================
  Hits            ?      380
  Misses          ?       71
  Partials        ?        9

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more