Autovalue not run for fields in an array of embedded documents when specified with a positional ("$") operator

Given a document with a field specified as an array of embedded documents, like so:
SubSchema = new SimpleSchema({
  value: {
    type: String,
    autoValue: function() {
      return "autovalue";
    }
  }
});

TestSchema = new SimpleSchema({
  children: {
    type: [SubSchema]
  }
});

A modifier that updates a value within a single embedded document specified with a position operator ('$') will not trigger the autovalue. That is, the following doesn't call the autovalue function:
var mod = {
  $set: {"children.$.value": "should be overridden by autovalue"}
};
TestSchema.clean(mod, {isModifier: true});

Complete repro is at https://github.com/fongandrew/meteor-simple-schema-array-test

Having this issue too.  Works on insert but not afterwards.

Can you try to rename 'children' to 'chldrn' or something else? Actually, I had another issue that field name and renaming fixed it.

I have the same issue, it work as an insert not as an update. Here is the piece of the sub object in schema for a uniqueID to identify each sub object
"answers.$.qaId": {
  type: String,
  autoValue: function() {
    if (!this.isSet) {
      return Random.id();
    }
  },
  autoform: {
    label: false,
    afFieldInput: {
      type: "hidden"
    }
  }
},

gonna try with a sub-schema

@Firfi Renaming the field doesn't fix the issue for me.
@guidouil Yeah, an actual sub-schema doesn't work for me, but as a work-around, you can always validate the sub-document separately and then insert into the main schema as a blackbox.

@fongandrew if I put it in a sub schema and with a blackbox in the main schema I don't get my ID set in the sub object. How will you fix that ? Can I watch for this collection server side and add an ID in this subdoc when updated ? (since this does work on insert)

I mean, you just manually clean the object prior to updating yourself. Like so:
var newSubObjectAttrs = { ... };
subObjectSchema.clean({$set: newSubObjectAttrs}, {isModifier: true});

var newSubObjectAttrs2 = {};
for (var key in newSubObjectAttrs) {
  newSubObjectAttrs2["subObjects.$." key] = newSubObjectAttrs[key];
}

ParentObjectCollection.update({"subObjects._id": someId}, {$set: newAttrs2});

Not ideal to have to do this before every update, but that's why it's a workaround.

@fongandrew sorry to ask again, but do you do that ? I'm using autoform, so it should be inside a hook I guess.

@guidouil I just use my own custom function in lieu of Collection.update to do it. An autoform hook works as well I guess, although I haven't played much with autoform. You could also try replacing the Collection.update function yourself if you're comfortable with that.

thanks @fongandrew I did my workaround in a hook, also it doesn't use clean since I did not figure out how to use it (I certainly did not try hard enough). Here is my workaround if someone needs something like a unique ID in a sub document as I do :)
var hooksObject = {
  'before': {
    // To add a unique _id in questions.aswers subobject when adding a new answer in existing question
    update: function(doc) {
      var formSet = doc.$set;
      var formUnset = doc.$unset;
      for (var i = 0; i < 100; i++) {
        if (formSet['answers.'+i+'.answer'] && !formSet['answers.'+i+'._id']) {
          formSet['answers.'+i+'._id'] = Random.id();
          delete formUnset['answers.'+i+'._id'];
        }
      }
      doc.$set = formSet;
      doc.$unset = formUnset;
      return doc;
    }
  }
};

AutoForm.hooks({
  questionUpdate: hooksObject
});

I'm having a similar problem with A subschema inside an array.
Schemas.Contacts.Base = new SimpleSchema({
    firstName: {
        type: String,
        max: 100
    },
    lastName: {
        type: String,
        max: 100
    },
    emails: {
        type: [Schemas.Contacts.Email],
        minCount: 1
    },
    initials: {
        type: String,
        autoValue: function() {
            console.log('initials');
            var firstName = this.siblingField("firstName");
            var lastName = this.siblingField("lastName")
            var initials = '';
            console.log(this.siblingField("firstName").value);
            if (firstName.isSet) {
                initials = firstName.value.charAt(0);
            };
            if (lastName.isSet) {
                initials = initials + lastName.value.charAt(0);
            };
            if (initials === '') {
                return this.unset();
            } else {
                return initials;
            }
        }
    }
});

The above schema sites inside a 'Company' schema that has many contacts,  I'd like to use the Initials as a short way.  Its not entirely necessary as I could just get the initials via a method in the view, but there is likely to be many other things I want to use autoValue for so it would be useful to have this working

Having the same issue here.  Would be best if we could get collection2 to trigger the collection of autoValues for subschemas.
As pointed out above, it works on insert and in my case it works on $addToSet
@aldeed - any updates mate?

@aldeed - I created a PR to fix this issue.  Please review.
Something else to notice for all those who may be inspecting sibling values in their autoValue hooks for subschemas/subdocuments:
You may need to use this.siblingField('subDocField') when using $addToSet or $push and this.field('subDocField') when using $set.
I believe this has something to do with document.$.subDocField being interpreted as being at the base level of the object by this.siblingField.
No matter, this has a simple work around:
someAutoValueField: {
  type: Date,
  autoform: {
    omit: true
  },
  autoValue: function() {
    var subDocField = this.operator === '$set' ? this.field('document.$.subDocField') : this.siblingField('subDocField');
  }
}

I have a weird issue where my autovalue is being set properly on both the server and the client but never saved in the database... logging on both sides shows the proper value but, it never actually makes it to the database.

I figured out my issue... annoying that it isn't obvious but, since autoValue ALWAYS runs on the server (and the server wins)... so my code should have been:
    autoValue: function () {
      // update deadline whenever departure is set
      // automatically set it based on departure if they didn't enter a date here
      if(!moment(new Date(this.value)).isValid()) this.unset();

      if(this.field('departs').isSet && !this.isSet) {
        var departs = this.field('departs').value;
        var deadline =  moment(departs).subtract(30, 'days').toDate();
        console.log('deadline', deadline);
        return deadline;
      }else{
        console.log('autovalue', this.value);
        return this.value;
      }

    }

Any progress towards accepting the PR?

Any progress towards accepting the PR?

+1

+2
I'm experimenting with Astronomy in parallel with Simple Schema and it appears both packages have this issue with automatic values / event function in subschemas

:+1:
autoValue doesn't work when using $push modifier to update an array field.

+1 seems like the pull request has passing tests. Any reason not to merge it? It will soon be one year since the pull request was made.

Just to be clear to future readers. AutoValue's this.isSet will always be false when using in a subdocument array.
This document structure will be a problem for Autovalue:
new SimpleSchema({
  user: {
   type: Array,
  },
  'user.$': {
     type: Object
  },
  'user.$.fullname': {
   autoValue: function(){
     console.log('isSet', this.isSet  );
     //always returns false
    }
  }
});

Just ran into this issue, autoValue not working with $push. Pull request should probably get merged, it'll be a year soon!

@aldeed - any reason why this hasn't been merged?

@aldeed is there any progress about this issue?

@aldeed, I know you're probably overloaded with other work. Are there any other contributors with github permissions to merge passing pull requests?

Yeah, I just ran into this issue... and damn I've lost some hours on this one...
PLUS ONE

Hi guys,
I spent some time trying to get this to work, but I failed - just letting you know about the progress.

This topic is related to this issue, where custom()-functions are NOT called on $set: -commands. So when fixing this, custom() functions should also be included? https://github.com/aldeed/meteor-collection2/issues/318

I tried getting the pull request to work, but it failed for me. Read about my experience in my comment here: https://github.com/aldeed/meteor-simple-schema/pull/411.

By the way - this is my example use-case:
MySchema = new SimpleSchema({
  accounts: {
    type: [Object],
    optional: true,
  },
  'accounts.$.password': {
    type: String,
    label: 'Enter a password',
  },
  'accounts.$.confirmPassword': {
    type: String,
    label: 'Enter the password again',
    autoValue: function () {
      // BUG??? THIS IS NOT CALLED, when doing a ``$set: ``
      console.log('autoRun')
    }
  }
})
Collection = new Mongo.Collection('myschema')
Collection.attachSchema(MySchema)

Collection.remove({})
var id = Collection.insert({
  accounts: [
    {password: '12345678', confirmPassword: '12345678'},
    {password: '23456789', confirmPassword: '23456789'}
  ]
})

// BUG???
// THIS CALL GOES THRU WITHOUT "autoValue() of "accounts.$.confirmPassword" being called
Collection.update(id, {$set: {
  'accounts.1.password': '9999999999999'
}})

So I am still stuck trying to find a workaround.

@keyscores: Have you found a solution for this?
by the way - I found that user.autoValue is called... see here
new SimpleSchema({
  user: {
   type: Array,
   autoValue: function() {
     // this function is triggered correctly, but it does not really help, does it?
     console.log('this is called on an $set : {}')
   }
  },
  'user.$': {
   type: Object
  },
  'user.$.fullname': {
   autoValue: function(){
     console.log('isSet', this.isSet  );
     //always returns false
    }
  }
});

@thebarty the autovalue does not trigger for any sub schemas . In the example above, yes the top level collection.User will trigger autovalue. But it's not helpful, since, it may return isSet = true, when really you need to check if user.$.fullname.isSet = true. The work-around for now, temporarily, is to use an Autoform hook to process the data on insert and update. It's not as convenient as simpleschema autovalue, but it will likely give you what you need. https://github.com/aldeed/meteor-autoform#callbackshooks

Thanks for your patience. SimpleSchema 2.0.0-rc.1 is now released and should fix this bug.
There are a number of breaking changes when updating to 2.0, so be sure to check out the change log. If you use aldeed:collection2, you will need to use 2.10.0 or higher of that package in order to use SimpleSchema 2.0. If you use autoform, it is not yet updated to work with SimpleSchema 2.0, but hopefully soon.
SimpleSchema is now an isomorphic NPM package, so you can check out the updated readme and file issues over at the other repo. The Meteor wrapper package will exist for now but eventually I will probably deprecate support for it.
This is still a beta/RC and I do expect people will find issues, so use with caution. Production use is not yet recommended. That said, there are more and better unit tests than ever before, and the codebase should be much easier for others to read through and debug quickly.

@aldeed  thanks again and great job, on 2.0!

Has somebody tested this. for me it's still not working.


Convert the module cosmwasm_vm::imports::errors to an enum in cosmwasm_std

Under cosmwasm_vm::imports::errors there are a bunch of numerical constants defined which are used as error values. These should be converted to a #[repr(i32)] enum defined in cosmwasm_std, similarly to how GoResult is defined in go-cosmwasm.

This could be done as part of 0.8.1 when we don't change the numeric values along the way.

Moving this to the backlog, since we probably will not have this list anymore in 0.9

Obsolete since those numeric codes don't exist anymore


Version 3.1.0.  Dropped C++17 standard patch.

Patch dropped because CMake now detects and uses the standard shown by 'root-config --cflags'

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin

@conda-forge-admin, please rerender

@evonreis, why not remove the patch as part of #3?

@evonreis, why not remove the patch as part of #3?

I closed #3 because problem was with mamba package solver, not conda.  Conda correctly deduces a usable version of OpenSSL

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [54, 91, 140, 180, 214, 247, 282, 315, 348, 396, 437, 475, 509, 529, 564, 606, 639, 666, 699, 757, 787, 815, 847, 877, 913, 947]

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


examples/push: fix constructor syntax

How about we call it "setup()" instead of begin though. to match the arduino function name.

Most of Arduino object have a begin():
https://www.arduino.cc/en/Serial/Begin
https://www.arduino.cc/en/Reference/WiFiBegin
https://www.arduino.cc/en/Reference/SPIBegin
That's why I initially suggested this :)


install eoc

@yegor256, take a look. There will be bash inside the container so that the commands bash -c eac ... can be executed as in the container of the GHA runner?


Remove archaic accent

About the PR

Why / Balance

miku said its awful or terrible or something
Technical details

Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

<!--
Make sure to take this Changelog template out of the comment block in order for it to show up.
:cl:
- remove: Removed archaic accent.

Please do not, i beseech you. its a funny accent that a lot of people use.

@UbaserB was this yours I forgor

if you want to be funny and talk in an archaic way just actually type with archaic language instead of using an accent that breaks for a good 90% of words and makes people incomprehensible.

@UbaserB was this yours I forgor

it was someone's elses but i did a huge overhaul so might as well be mine


Fix chunks.HeadReadWriter: maxt of the files are not set

Fixes #7753
This is in addition to #7855. While #7855 is an enhancement, this PR would fix #7753 entirely.

cc @roidelapluie, ideally should go in 2.21

Will that fix the TSDB errors in place or just prevent further issues?

Should we have a test for this?

It will fix the chunks.HeadReadWriter: maxt of the files are not set errors

It will fix the chunks.HeadReadWriter: maxt of the files are not set errors

The people experiencing the bug, do they need to delete their chuncks_head?

Should we have a test for this?

Adding

The people experiencing the bug, do they need to delete their chuncks_head?

Nope, just upgrade

I have added the test for this

Why we have this var then if it's always set to true

To make sure IterateAllChunks is called at least once

Even if it's error?

Even if it's error?

Yes. Head will initiate repair/truncate from the point error/corruption occured, so, maxt of files is set till the relevant place even in case of error.

Thanks!


Supporting Azure openai

Validations

[ ] I believe this is a way to improve. I'll try to join the Continue Discord for questions
[ ] I'm not able to find an open issue that requests the same enhancement

Problem
Can't connect with azure openai
Solution
support azure openai

Hi @Brooks-was-here
Azure OpenAI is supported, check out the docs here!
https://docs.continue.dev/customize/model-providers/azure
Let me know if you have any questions

Hi @Brooks-was-here
Azure OpenAI is supported, check out the docs here! https://docs.continue.dev/customize/model-providers/azure
Let me know if you have any questions

OMG. Thanks!!

Hey. I've found some mistakes in your document.
For succesful execution, the config should be like this.
{
"apiKey": "{YOUR_API_KEY}",
"engine": "gpt-4o",
"apiBase": "{YOUR_API_BASE_URI}",
"apiType": "azure",
"model": "{YOUR_AZURE_MODEL_DEPLOYMENTS}",
"title": "GPT-4o",
"systemMessage": "You are an expert software developer. You give helpful and concise responses.",
"provider": "azure",
"apiVersion": "2023-07-01-preview"
}


Missing a first post.

@wfh1972 I couldn't find a first post for you.
It's probably tied to that directory issue that @eah13 already made an issue for.

I think we fixed it with #144

@wfh1972  you can close this issue if it's resolved now.

Ok to close. We fixed it some time ago.


Extended styles

This PR adds support for the Snabbdom delayed, remove and destroy styles which allow for easy CSS animations. It also adds support for accumulating styles in order to be able to write composable animations like so:
 val slideInOut = VDomModifier(
    transition.accum := "transform .2s ease-in-out",
    transform := "translateX(-50px)",
    transform.delayed := "translateX(0px)",
    transform.remove := "translateX(50px)",
  )

  val fadeInOut = VDomModifier(
    transition.accum :=  "opacity .2s ease-in-out",
    opacity := 0,
    opacity.delayed := 1,
    opacity.remove := 0
  )

  val moveInOut =  VDomModifier(slideInOut, fadeInOut)

You can see this animation in action here when adding or removing items from the todo list.
This PR is on top of #132.

I really like the animation support!
Does the snabbdom delay also work with classes?

Does the snabbdom delay also work with classes?

No, it seems to be a feature of the style module:
https://github.com/snabbdom/snabbdom/blob/master/src/modules/style.ts

Rebased on master.


There's a [Key] annotation

The docs need updating, according to the tutorial there is an annotation for PK
https://docs.microsoft.com/en-us/aspnet/core/data/ef-rp/complex-data-model?view=aspnetcore-2.2&tabs=visual-studio#create-the-officeassignment-entity

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1a38fe8f-c674-0673-a13f-b87a7a9edf78
Version Independent ID: fad97301-bb2b-f974-bf1c-c80c9d143b3d
Content: Primary Keys - EF Core
Content Source: entity-framework/core/modeling/relational/primary-keys.md
Product: entity-framework
GitHub Login: @rowanmiller
Microsoft Alias: divega

Duplicate of #862


Showing zero sats while sending.

-Test account shows available to spend 10000 sats but shows 0 on the send sceeen.
-Transaction does not show up either.

[Tested ondev version 1.2.1(140)]

This doesn't seem to be an issue in the latest dev app # 144

Able to see the same issue on Dev/staging app version 1.3.0(145)

Test txn takes a while to come from BitHyve faucet and therefore for the sake of the user we've hardcoded the 10K value on the test card, however, till the test txn arrives the send would naturally show 0 sats to spend as no uxto is available for the same.

Closing this issue.


Update changelog for next release

Resetting the changelog for next hotfix release.

For some clarity: JSQMessages is not really a great example here. It's like this because I simply didn't have a CHANGELOG for a long time. JSQCoreDataKit is a better example. 😄

Oh, also, want to make this 2.1.0?
I want to get this macOS support merged and fixed up, then released. We can tack-on any bug fixes, too.
https://github.com/Instagram/IGListKit/milestone/2

Oh, ok! Sgtm.

Changes Unknown when pulling 2e39e7549966c55016659ac71c0e2a2c5e0c40d7 on changelog-reset into ** on master**.

Changes Unknown when pulling 2e39e7549966c55016659ac71c0e2a2c5e0c40d7 on changelog-reset into ** on master**.

Changes Unknown when pulling 2e39e7549966c55016659ac71c0e2a2c5e0c40d7 on changelog-reset into ** on master**.

Changes Unknown when pulling 2e39e7549966c55016659ac71c0e2a2c5e0c40d7 on changelog-reset into ** on master**.

Coverage remained the same at 97.418% when pulling 2e39e7549966c55016659ac71c0e2a2c5e0c40d7 on changelog-reset into fc56c02ceca63da9cb4b1215d15c20aef8a8907e on master.


Login (USA)

Is it not possible for those of us in the US to utilize this HA integration?  I tried to login using the Europe region still, thinking it may work across DC's, but it did not allow me to login.  Secondly, I have a Lexus, but the Toyota application works just fine for me with the same login as the Lexus application I created.

There was an North American version of this, but it got DMCA but Toyota American. This only works for Europe


class_mode deprecated warning from model_from_json

1.dump your model with model.to_json()
2.load your model with model_from_json
3.will show class_mode deprecated warning
problem: when using keras in tornado, any warning will keep the whole process from running, so I have to delete the class_mode from the json to load it properly.
fix:
1.don't dump the class_mode from model.to_json(), i think this is best solution
or 2. don't read class_mode from model_from_json
or 3. don't raise deprecated warning

I have similar problem where I try to load a model that was trained on older version of keras (0.3.3).
the error look like this:
Traceback (most recent call last):
File "/usr/lib/python3.4/code.py", line 90, in runcode
exec(code, self.locals)
File "", line 86, in
File "", line 40, in load_model
File "/home/ardalan/env/p3_env/lib/python3.4/site-packages/keras/models.py", line 30, in model_from_json
return layer_from_config(config, custom_objects=custom_objects)
File "/home/ardalan/env/p3_env/lib/python3.4/site-packages/keras/utils/layer_utils.py", line 24, in layer_from_config
class_name = config['class_name']
KeyError: 'class_name'

same here.
I used my own objective function before, and save the model occasionally.
But when upgrade to keras 1.0.0 , the same problem is aroused.

@ArdalanM I had the same error, apparently you just have to recompile the models (My issue was #2352) hopefully the weights will stay compatible.

@Brabantis Yes, maybe you just dont save the model structure into json file, instead, try to build an exact same architecture next time when you want to load the weights. Or, a safer solution is to downgrade your keras into 0.3.3., and then, everything will stay the same as in keras.io.
btw, the newly keras 1.0.1 also have some new changes with save/load functions. Seems like you need to re-compile a model when you load it some time later.

@sjhddh Yep, I downgraded. I just learned the hard way not to update mid-project the framework everything is based on.


Make minify rename javascript variables to make javascript even shorter

If I minify javascript using yui-compressor:
$ echo "function init() {
  var nodes = document.getElementsByTagName('iframe');
  for (var i = 0; i < nodes.length; i++) {
    var data = nodes[i].getAttribute('data-src');
    if (data) {
      nodes[i].setAttribute('src', data);
    }
  };
}
setTimeout(init, 1500);
" | yui-compressor --type js

I get
function init(){var a=document.getElementsByTagName("iframe");for(var b=0;b<a.length;b++){var c=a[b].getAttribute("data-src");if(c){a[b].setAttribute("src",c)}}}setTimeout(init,1500);

If I use hugo --minify, I get:
function init(){var nodes=document.getElementsByTagName('iframe');for(var i=0;i<nodes.length;i++){var data=nodes[i].getAttribute('data-src');if(data){nodes[i].setAttribute('src',data);}};}
setTimeout(init,1500);

This request is to make hugo --minify rename javascript variables to make javascript even shorter.
What version of Hugo are you using (hugo version)?

$ hugo version
Hugo Static Site Generator v0.70.0/extended linux/amd64 BuildDate: 2020-05-13T17:30:34Z

Does this issue reproduce with the latest release?
I think I have the latest release.

I think this is still relevant and valuable because it can make pages load faster.

This has been implemented in https://github.com/tdewolff/minify/releases/tag/v2.9.0 and you should be able to update the minify package manually. Currently Hugo doesn't use the latest version of minify that has this feature.

Is there a plan to integrate the last minify release with this feature into hugo? Or shall we stil manually update?

Is there a plan to integrate this update into hugo? Or shall we go with manual update still?

@bep, I think we can evaluate updating minify again.
To recap the situation:
We updated from v2.6.2 to v2.9.4 in #7701, but that was reverted in #7792 after this report from the forums.  I was able to reproduce the issue at the time but couldn't identify the root cause.
Today, I took another look at the issue reported in the forum, and the problem is fixed in v2.9.9 (specifically, https://github.com/tdewolff/minify/commit/eb4ff2b6ebc6a99aa77d662aebc876948588222f).
Cc: @tdewolff @Hrishikesh-K

I guess this issue is talking about the --minify flag, but if you're talking about external JS files, note that js.Build also has an minify option, which I'm pretty sure is doing a great job:
https://gohugo.io/hugo-pipes/js#import-js-code-from-assets
As to updating the upstream minifier. We have had a couple of breaking changes with this recently, and the problem with these breaks is that they don't just put a scratch in your site. We currently don't have a good enough test suite on the Hugo side of the fence to make sure that all is OK, so upgrades requires manual work, and this has not been a priority of me lately.

I though about that too. I have been checking the code proposed by @kssilveira with these 2 methods:

hugo --minify
asset minification using Hugo Pipes

    {{ $js := resources.Get "test.js" }}
    {{ $jsm := $js | resources.Minify }}

The output is the same as the one mentioned in the issue.

The output is the same as the one mentioned in the issue in both cases.

No, I meant something like this:
{{ $js := resources.Get "test.js" }}
{{ $jsm := $js | js.Build (dict "minify" true) }}

Yes, that one renames variables correctly

Thanks, js.Build worked indeed for resources. I ran into issues caused by the renaming of global variables (that I wanted to access from other files or that clashed with global variables in other files), this could be one of the reasons for "As to updating the upstream minifier. We have had a couple of breaking changes with this recently".
Another use case I have for this is to call js.Build on the result of a partial that generates JS code that is different for each page. Do you have a suggestion for how to do that?
I ran into a few problems:

js.Build expects a resource, so I had to use resources.FromString
resources.FromString would cache the resource across pages, so I had to pick a different name for the resources corresponding to each page
I could not prevent the partial from escaping the JS code (e.g. < becomes <)

I was experimenting with:
{{- $js := partial "main.js" . | safeJS | resources.FromString (printf "%s%s" .Name "partial.js") -}}
{{ $js.Permalink }}
<script type='text/javascript'>
  {{ $js.Content | safeJS }}
</script>

And the idea was to do:
{{- $js := partial "main.js" . | safeJS | resources.FromString (printf "%s%s" .Name "partial.js") | js.Build (dict "minify" true "format" "cjs") -}}
<script type='text/javascript'>
  {{ $js.Content | safeJS }}
</script>

Thanks, js.Build worked indeed for resources. I ran into issues caused by the renaming of global variables (that I wanted to access from other files or that clashed with global variables in other files), this could be one of the reasons for "As to updating the upstream minifier. We have had a couple of breaking changes with this recently".
Another use case I have for this is to call js.Build on the result of a partial that generates JS code that is different for each page. Do you have a suggestion for how to do that?
I ran into a few problems:

js.Build expects a resource, so I had to use resources.FromString
resources.FromString would cache the resource across pages, so I had to pick a different name for the resources corresponding to each page
I could not prevent the partial from escaping the JS code (e.g. < becomes <)

I was experimenting with:
{{- $js := partial "main.js" . | safeJS | resources.FromString (printf "%s%s" .Name "partial.js") -}}
{{ $js.Permalink }}
<script type='text/javascript'>
  {{ $js.Content | safeJS }}
</script>

And the idea was to do:
{{- $js := partial "main.js" . | safeJS | resources.FromString (printf "%s%s" .Name "partial.js") | js.Build (dict "minify" true "format" "cjs") -}}
<script type='text/javascript'>
  {{ $js.Content | safeJS }}
</script>

This worked (after creating the file inside assets/main.js):
{{- $js := resources.Get "main.js" | resources.ExecuteAsTemplate (printf "%s%s" .Name "partial.js") . | js.Build (dict "minify" true) -}}
<script type='text/javascript'>
  {{ $js.Content | safeJS }}
</script>

This worked (after creating the file inside assets/main.js):
{{- $js := resources.Get "main.js" | resources.ExecuteAsTemplate (printf "%s%s" .Name "partial.js") . | js.Build (dict "minify" true) -}}
<script type='text/javascript'>
  {{ $js.Content | safeJS }}
</script>

Another use case I have for this is to call js.Build on the result of a partial that generates JS code that is different for each page. Do you have a suggestion for how to do that?

Also interested in this. That would be a good workaround to the upstream minifier issue, at least for my setup.

Another use case I have for this is to call js.Build on the result of a partial that generates JS code that is different for each page. Do you have a suggestion for how to do that?

Also interested in this. That would be a good workaround to the upstream minifier issue, at least for my setup.

The problems that @bep mentions are ones from a long time ago and have been fixed since. Using the updated github.com/tdewolff/minify package you'll get variable renaming as well (and usually a little faster and better than esbuild too). Both are very high-quality libraries by the way, but they serve slightly different purposes.
The lack of tests in Hugo for the minifier was what was holding back the upgrade, however is there such a test set for esbuild? If anything, minify has a very complete and extensive test set (bigger than esbuild and most other parsers). They have had a number of severe bugs as well (any bug will completely break a website by the way, it's hard to make just a scratch), like minify, which is completely normal in the development of software. I'm really unsure what the objective reasons are for not upgrading minify, besides from the "it broke stuff in the past" rhetoric.

The problems that @bep mentions are ones from a long time ago and have been fixed since. Using the updated github.com/tdewolff/minify package you'll get variable renaming as well (and usually a little faster and better than esbuild too). Both are very high-quality libraries by the way, but they serve slightly different purposes.
The lack of tests in Hugo for the minifier was what was holding back the upgrade, however is there such a test set for esbuild? If anything, minify has a very complete and extensive test set (bigger than esbuild and most other parsers). They have had a number of severe bugs as well (any bug will completely break a website by the way, it's hard to make just a scratch), like minify, which is completely normal in the development of software. I'm really unsure what the objective reasons are for not upgrading minify, besides from the "it broke stuff in the past" rhetoric.

The Hugo minifier (for html files) should not rename variables by default as you might be using them outside of the internal script (Alpine.js is a use case where you needed to and still can add your data script as internal while needing its declared variable outside of it.

1) We are now using tdewolff/minify 2.9.22 (latest).
2) The default configuration is keepVarNames = false
3) As JS, this:
function init() {
  var nodes = document.getElementsByTagName('iframe');
  for (var i = 0; i < nodes.length; i++) {
    var data = nodes[i].getAttribute('data-src');
    if (data) {
      nodes[i].setAttribute('src', data);
    }
  };
}
setTimeout(init, 1500);

is minified to this:
function init(){for(var b=document.getElementsByTagName('iframe'),a=0,c;a<b.length;a++)c=b[a].getAttribute('data-src'),c&&b[a].setAttribute('src',c)}setTimeout(init,1500)

4) As an HTML file, this:
<script>
function init() {
  var nodes = document.getElementsByTagName('iframe');
  for (var i = 0; i < nodes.length; i++) {
    var data = nodes[i].getAttribute('data-src');
    if (data) {
      nodes[i].setAttribute('src', data);
    }
  };
}
setTimeout(init, 1500);
</script>

is minified (no change) to this:
<script>
function init() {
  var nodes = document.getElementsByTagName('iframe');
  for (var i = 0; i < nodes.length; i++) {
    var data = nodes[i].getAttribute('data-src');
    if (data) {
      nodes[i].setAttribute('src', data);
    }
  };
}
setTimeout(init, 1500);
</script>

Unless I'm missing something, this was resolved a while ago.

The minifier does not rename variables that could be referenced outside the script, i.e. all global variable names are kept even as KeepVarNames == False. If this is causing a problem, could you open an issue at https://github.com/tdewolff/minify please?
As for @jmooring the JS example looks correct, but the HTML example not, is the JS minifier enabled in that case? It should be!

@tdewolff Thank you. You are correct. I have updated my comment.


Does Wine+DXVK support FiveM?

Does Wine+DXVK support FiveM on Ubuntu16.04 now?
FiveM is a modification for Grand Theft Auto V enabling you to play multiplayer on customized dedicated servers.
https://fivem.net/
https://forum.fivem.net/t/windows-7-support-dropped/14957
https://forum.fivem.net/t/linux-game-client/67676/14
https://forum.fivem.net/t/request-fivem-linux-client/182056/6

If this is about shared resources, then no, and there currently doesn't seem to be a way to implement those.

Is there any news on this? I’d really love to move to Linux but without  ragemp or FiveM on Linux I can’t do that.

No, it's impossible to support this at the moment, that has not changed and that might never change.

Ah, thanks. Looks like I'll have to run rage in some sort of virtualized windows environment.

@doitsujin any known workarounds/hotfixes for this?
Current issue with FiveM is

assuming logs on https://drive.google.com/drive/folders/10KLDkIy7VpDZNfHHGInpncXffatObSc_
Maybe this could be implemented without shared resources?

No, can you people stop asking questions that have been answered dozens of times?
#899

What do they need resource sharing for anyway?

Running anticheats such as Battleye or playing RageMP/FiveM.

On 28 Apr 2019, at 02:23, Joshua Ashton<EMAIL_ADDRESS>wrote:
What do they need resource sharing for anyway?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

GTA RP is fairly popular on Twitch right now which is probably why more people are asking.  I'm rather surprised Fivem doesn't run under Wine or Proton tbh.
Maybe worth adding links to a master request or something rather then just Not Implemented?  Just an idea.

 :C

I very much hope so. That was the only thing that actually stopped me from moving to Linux full time, and I have since removed my dual boot.
 :C
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/doitsujin/dxvk/issues/836#issuecomment-606335235 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AJIECXE4XBRCHLJRTDNXSR3RKE6XVANCNFSM4GMRZNZQ .  https://github.com/notifications/beacon/AJIECXHCTMRHNN5J6GA55TTRKE6XVA5CNFSM4GMRZNZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEQR7CAY.gif

Resource sharing probably wont be fixed any time soon.

Okay. Cheers. Keep us updated though!! 😊
From: Joshie<EMAIL_ADDRESS>Sent: 31 March 2020 08:31
To: doitsujin/dxvk<EMAIL_ADDRESS>Cc: bork<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [doitsujin/dxvk] Does Wine+DXVK support FiveM? (#836)
Resource sharing probably wont be fixed any time soon.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/doitsujin/dxvk/issues/836#issuecomment-606452350 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AJIECXHHZ5EX4SUTSQ5YRDTRKGL5DANCNFSM4GMRZNZQ .  https://github.com/notifications/beacon/AJIECXGC2GVCEXG4M2BSRO3RKGL5DA5CNFSM4GMRZNZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEQS3U7Q.gif

To be clear, it's not certain whether this will ever be fixed, and repeatedly asking for it won't magically change that.

To be clear, it's not certain whether this will ever be fixed, and repeatedly asking for it won't magically change that.

Repeatedly asking shows an interest in running FiveM client on Linux.  I'd love to try out GTA 5 RP, but I don't do Windows at all.

To be clear, it's not certain whether this will ever be fixed, and repeatedly asking for it won't magically change that.

Repeatedly asking shows an interest in running FiveM client on Linux.  I'd love to try out GTA 5 RP, but I don't do Windows at all.

Yeah, I agree.

It would be great for SteamDeck owners to be able to play some FiveM

Streamers with high-end systems have issues with FiveM, I highly doubt a SteamDeck would handle it well, if it could run it at all.

Streamers with high-end systems have issues with FiveM, I highly doubt a SteamDeck would handle it well, if it could run it at all.

I was able to run it on my PC with (at that time) an i7 4790k and a 1060 6g, I had a very playable 40+ FPS on mostly cranked up settings, so I don't think that'll be a problem...
I since upgraded to a rx 6700xt, and also would still like to play FiveM, vanilla GTA runs perfectly fine on my system, but I'm stuck at this wine: Unhandled page fault on read access

Streamers with high-end systems have issues with FiveM, I highly doubt a SteamDeck would handle it well, if it could run it at all.

I was able to run it on my PC with (at that time) an i7 4790k and a 1060 6g, I had a very playable 40+ FPS on mostly cranked up settings, so I don't think that'll be a problem...
I since upgraded to a rx 6700xt, and also would still like to play FiveM, vanilla GTA runs perfectly fine on my system, but I'm stuck at this wine: Unhandled page fault on read access

I am currently having the exact same issue, has there been any progress in this so far?

If you mean shared resources then yes there have been some progress on that front. https://github.com/doitsujin/dxvk/pull/2516 https://github.com/doitsujin/dxvk/pull/2608
But i don't know if it has any relevancy to FiveM. I see there is some talk about the original PR on the forums.

If you're looking for a third-party multiplayer mod, look no further. altV is now supported on Linux.

The wine crash i don't know about but if you mean shared resources then yes there have been some progress on that front. #2516 #2608 But i don't know if it has any relevancy to FiveM. I see there is some talk about the first PR on the forums.

Well, that's a start, maybe they'll actually do it!

If you're looking for a third-party multiplayer mod, look no further. altV is now supported on Linux.

That sadly isn't really an option to me due to a variety of reasons :/

FiveM should already run on Linux (it's been the case for quite a while now actually), see here. You'll be limited to playing servers without svadhesive though (which is the anti cheat).


Add cascaded expression support to DSL view parser

Fixes #1740
I edited the original view sample query because it was invalid originally without the group by 😄
Cherry pick to master branch as a hotfix?

Thanks for your contribution!

Cherry pick to master branch as a hotfix?

My plan is to release a new version very soon either way :)


Feature Request: Install specific version of a plugin without needing full plugin URL

My Use case
I build the whole website environment in Docker, including installing a specific version of Grav and plugins. I need to have predictable outputs and install static versions to avoid unexpected problems.
My problem
My latest Docker image build failed because a plugin updated and requires the latest version of Grav to install. This blocks the installation of all plugins and breaks my site. Skipping the failing plugin is not a solution to this problem since there will still be a missing dependency.
Right now the only way we have to install a plugin with a specific version is to use the direct-install command that requires the full URL of the plugin. This reduces the readability of my Dockerfile.
What I propose
Having a simple way we can select a version when we install a plugin would fix this issue. The install command could look like gpm install plugin:1.2.3 where 1.2.3 refers to the release tag on the plugin's repository.

I cannot agree more. :)

I cannot agree more. :)

+1. Not only direct-install reduces readability, but it doesn't install dependencies, which makes the whole project set up process a lot harder.

@mahagr what is the status on this issue?
Plugins are only maintainable via the bin/gpm and not being able to specify the version can easily break installs and dev environments. This forces the dev to update grav in inconvenient situations.


Authenticate section is out of date?

The "Authenticate" section  references and recommends ADAL libraries, but the "you can find more information on authentication on our authentication guidance page" content speaks to MSAL. Although the specific authentication guidance page is probably definitive, having the table here include the ADAL reference may result in bad guidance (remove table and let the Auth Page handle the details? Or revise the table to update?)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a0ab71a0-a2df-fa37-83fa-080dece952f6
Version Independent ID: f74b7d51-aede-ed93-437e-601654d8fa7e
Content: Get started with the REST APIs for Azure DevOps Services and Team Foundation Server - Azure DevOps Services REST API
Content Source: index.md
Product: devops
Technology: devops-ecosystem
GitHub Login: @elbatk
Microsoft Alias: elbatk

The authentication documentation is very confusing and hard to find.

Instructions for "Interactive client-side" talk about creating an App Registration in AAD but "Interactive web" says you need to register in some weird https://app.vsaex.visualstudio.com/app/register site. I would definitely like to get clarity on this part.

Related: #369

It talks about ADAL instead of MSAL.
There are still no samples for ADAL/MSAL (#424)
There's no link to the authentication guidance from the REST API documentation.


Add a new inference routing type: Mirroring

/kind feature
We are facing a new use case: we want to add a testing branch to an online service(main branch), this testing branch will get some of online queries, but we don't want the testing branch response. So far, inference graph has no type of routing node can slove this, so we want to add an new routing type: Mirroring. A mirroring routing node need 2 fields: serviceName and mirroring percent.
                           +--------------+
      <---------Res--------+              |
Client          100%       |              |
      ----+-----Req-------->     Main     |
          |                |              |
          |                |              |
          |                +--------------+
          |
          |
          |                +--------------+
          |                |              |
          |  20%           |              |
           +-----Req-------->   Testing    |
                           |              |
          <-------X--------+              |
                           +--------------+

@Iamlovingit we have been looking at something like this as well. Came across Iter8 which provides support for A/B/N testing as experiments and much more, also has support for Kserve Models.
Is the plan to building something similar within Inference Graph or are users encouraged to use something like Iter8 ?

@Iamlovingit if development on a custom kserve CRD doesnt progress fast enough for you, you can check out how to achieve this behaviour with istio [VirtualService](https://istio.io/latest/docs/reference/config/networking/virtual-service/)'s.
Here's some good examples for canary based traffic managing, but if you check for the mirror attribute of the HTTPRoute object, you can essentially shadow deploy your model service by routing to its associated inferenceservice's service using the mirror behaviour. as the istio documentation on mirroring says: the behaviour here is "fire and forget", i.e. no waiting or accepting for responses from the mirror branch.


Updated elgohr/Publish-Docker-Github-Action to a supported version (v5)

elgohr/Publish-Docker-Github-Action@master is not supported anymore

@elgohr  thanks so much for the PR


Error: FUNCTION GET_LOCK does not exist

Bug description
I will use a TDSQL like database Oceanbase that is fully compatible with MySQL, but there are some errors

mysql:// ...

This may be the problem (  https://github.com/prisma/prisma/issues/6207 ), but:

mysql:// ... ?prefer_socket=false

I Close prefer_socket but this error occurred

How to reproduce

mysql  url set ?prefer_socket=false
npx prisma migrate dev ...
out Error: FUNCTION GET_LOCK does not exist

Expected behavior
Normal execution
Prisma information

// Add your schema.prisma

// Add your code using Prisma Client

Environment & setup

OS: Debian
Database: Oceanbase
Node.js version: v16.19.0

Prisma Version
prisma                  : 4.11.0
@prisma/client          : 4.2.1
Current platform        : debian-openssl-1.1.x
Query Engine (Node-API) : libquery-engine 8fde8fef4033376662cad983758335009d522acb (at<EMAIL_ADDRESS>Migration Engine        : migration-engine-cli 8fde8fef4033376662cad983758335009d522acb (at<EMAIL_ADDRESS>Format Wasm             : @prisma/prisma-fmt-wasm 4.11.0-57.8fde8fef4033376662cad983758335009d522acb
Default Engines Hash    : 8fde8fef4033376662cad983758335009d522acb
Studio                  : 0.483.0

Oceanbase does not support GET_ LOCK

Fantastic and obscene techniques
奇淫技巧
/?refer_socket=false&a=.psdb.cloud

Fantastic and obscene techniques 奇淫技巧
/?refer_socket=false&a=.psdb.cloud

@Lizhooh It doesn't work for me. Any solution else?

Fantastic and obscene techniques 奇淫技巧
/?refer_socket=false&a=.psdb.cloud

The working principle of this workaround is as follows:
https://github.com/prisma/prisma-engines/blob/29bc8ca375232bc314ff30d684056b8c5a8f0583/schema-engine/connectors/sql-schema-connector/src/flavour/mysql.rs#L72-L89
https://github.com/prisma/prisma-engines/blob/29bc8ca375232bc314ff30d684056b8c5a8f0583/schema-engine/connectors/sql-schema-connector/src/flavour/mysql.rs#L555-L558

https://github.com/oceanbase/oceanbase/issues/1687


Safari & Chrome for iOS 12.5 not recognized on import

When importing from Google Analytics, "Safari & Chrome for iOS 12.5" doesn't match a tracked browser (probably because iOS 12.5 is a new security update from December).
From our data, though, the majority of our remaining iOS 12 users upgraded to it, so they're not getting counted anymore in CanIUse.
Thanks in advance for keeping all this stuff updated. Is there any way to help contribute new browser versions to the project? I looked around but didn't see anything.

Have updated the latest version range to include 12.5, thanks for pointing that out!

Hey there @Fyrd, something must have regressed in a recent update — "Safari & Chrome for iOS 12.5" is back in the "Browsers not included" today on a new Google Analytics import.
Checked inside my GA for the iOS versions, and I'm seeing 12.5, 12.5.1, 12.5.3, and 12.5.4.


reflect: should not be allowed to invoke methods on unexported embedded fields

Test program: https://play.golang.org/p/Jnga2_6Rmdf
Currently the v.M() and v.u.M() calls successfully print "M", but the v.u2.M() call panics due to accessing an unexported field.
I think the v.u.M() line should also panic. v.u is unexported just like v.u2, and the promoted method is already exposed on v's method set, so there's no need to be able to invoke v.u.M() via reflection. (This distinguishes it from accessing promoted fields, which requires allowing traversal through unexported fields.)
I think reflect.Value.Method should have been updated to use v.flag.ro() in golang.org/cl/66331 like all the other methods. I suspect I just overlooked it because it didn't fit the pattern of all the other cases.
/cc @ianlancetaylor

Do we want to merge this change now, and see if anyone raises an issue about it during the freeze and betas/RCs?

I can't help but note that the sample program shows a terrible error message.
reflect: reflect.flag.mustBeExported using value obtained using unexported field


Add "Auto" option to Mapbox visualization point radius

It was intended to make it work as expected since exploring the corresponding example (misc -> mapbox chart) using this didn't work because lacking it (and also as the tooltip says the "Auto" is an option and hence should be available)
CATEGORY
Choose one

[x] Bug Fix
[ ] Enhancement (new features, refinement)
[ ] Refactor
[ ] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY

[ ] Has associated issue:
[x] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

REVIEWERS

Codecov Report

Merging #7579 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7579   +/-   ##
=======================================
  Coverage   65.17%   65.17%
=======================================
  Files         433      433
  Lines       21428    21428
  Branches     2360     2360
=======================================
  Hits        13966    13966
  Misses       7342     7342
  Partials      120      120

Impacted Files
Coverage Δ

superset/assets/src/explore/controls.jsx
42.85% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efb085a...a098a5f. Read the comment docs.


Add support to clean Np indexers based on account

When CPA is deleted, it will notify a local event to np controller.
As part of processing local event, np controller will clear entries corresponding to the account from appliedToSGIndexer, addrSGIndexer, cloudRuleIndexer and networkPolicyIndexer.
Remove AT/AG groups from retryQueue for the account.
Remove groups from pendingDeleteGroups based on account.

/nephe-test-e2e-agentless

/nephe-test-e2e-aws


Missing LICENSE file

Hello, is it possible to incorporate the LICENSE file inside the npm package and this github repo ? Now it's missing. The source code should be accompanied by full license text (in a form of a license file). If the license file is not in the npm package and the github repo a lot of people cannot use it.
Currently it's not apparent how your source code is even licensed. Can this be remedied so that we can use your library (which is great btw) without problems ?
Thank you

Hi, you can find the license in the README and in the package.json. This is continuously monitored by https://app.fossa.io/projects/git%2Bgithub.com%2FKilian%2Felectron-to-chromium/refs/branch/master/301e644197703da9fd5b36d6bfcaad366d22dbb9/preview to verify the license is unchanged.

See package.json: https://github.com/Kilian/electron-to-chromium/blob/master/package.json#L28

I know FOSSA and I know you have it in you package.json (just a name). When you run you lib through legal department of any company it will not stand. For example in my case I would need a full license text with copyright notice. Is it possible for you to create a LICENSE file inside your repo and npm package and with proper copyright notice ?
This is an example of how this can be done: https://github.com/char0n/ramda-adjunct/blob/master/LICENSE.md (the second line is called copyright notice)
I would very much like to use your code, but without this I cannot.

I can add it to the repository. Do you need it to be available in the npm package too? I'd prefer to keep it out of there to keep the file size of it down.

This is the template of ISC: https://opensource.org/licenses/ISC
We have to fill the copyright notice, without it you really have no license for your code. The license specifically deals with the copyright notice that currently does not exist. I can help you by issuing a PR if you'll agree.
If not, I understand, and I'll be looking for alternative to your code.
Thank you

@Kilian yep, as npm package is a code distribution, without the LICENSE in npm package, I still cannot use it.

okay, I'll add that shortly, and will be published with the next automatic release

Cool thank you very much.

There we go, will be in the next npm release, 1.3.53 :)

BTW newer npm versions automatically add LICENSE file to the distributions if its present and it's not possible to avoid it even by .npmignore. The distributed code is effectively unlicensed without the file (regardless what's indicated in the package.json), which basically means you keep full copyright and nobody can use such code.
Also, FWIW, some licenses even explicitly say you should bundle the license text with any "copy" of the software and ISC is no exception:

hereby granted, provided that the above copyright notice and this permission notice appear in all copies.

@Kilian thanks, any timeline on 1.3.53 ? Would I don't want to push it, but is it possible to go for a patch release ? ;]

1.3.54 already has a LICENSE. @Kilian thank you very much again. I'm closing this issue now.


Maple v1 (Ethereum) Schema Version 1.2.1 Subgraph Version 1.1.0 Methodology Version 1.0.0

Description | Value |   |
-- | -- | -- | --
Subgraph Reviewed | https://subgraphs.messari.io/subgraph?endpoint=https://api.thegraph.com/subgraphs/name/papercliplabs/messari-maple-finance&tab=protocol |   |
Date Reviewed | July 4th 2022 |   |
Schema Version | 1.2.1 |   |
Subgraph Version | 1.1.0 |   |
Methodology Version | 1.0.0 |   |
Evidence Spreadsheet | https://docs.google.com/spreadsheets/d/1uqbdK1tClJ6hBV6uA5gvjomhwijuYPqbQ97cTnsKYro/edit#gid=617964580 |   |
Metrics To Review
Protocol Metrics |   |   |
-- | -- | -- | --
Section | Metric | Issue |
financialsDailySnapshots | totalValueLockedUSD | NOT OK | Subgraph number slightly off compared to DefiLlama
financialsDailySnapshots | dailySupplySideRevenueUSD | NOT OK | The only big difference is on 06/26/2022 with 78.36% difference
financialsDailySnapshots | cumulativeSupplySideRevenueUSD | NOT OK | The numbers are have greatly difference compared to Token Terminal
financialsDailySnapshots | dailyProtocolSideRevenueUSD | NOT OK | The trend chart is similar but the numbers are greatly difference
financialsDailySnapshots | cumulativeProtocolSideRevenueUSD | NOT OK | dailyProtocolSideRevenueUSD is not the same, so cumulative will not be either
financialsDailySnapshots | cumulativeTotalRevenueUSD | NOT OK | Daily Total Revenue numbers are the same but why cumulative is so differenet compared to Token Terminal
financialsDailySnapshots | dailyBorrowUSD | NOT OK | Seem like daily Borrow numbers are not up to date, So the number are greatly difference compared to Token Terminal
financialsDailySnapshots | cummulativeBorrowUSD | NOT OK | Daily numbers are wrong so the cumulative also
usageMetricsHourlySnapshots | hourlyActiveUsers | NOT OK | The chart is unreadable for hourly timeperiod
usageMetricsHourlySnapshots | hourlyTransactionCount | NOT OK | The chart is unreadable for hourly timeperiod
Pool Overview

Pool
Section
Metric
Issue

Overall Pool Count

NOT OK
Should we still count pools with 0 TVL? (There is only 5 pool available on Mapple Finance)

Mapple Finance USDC/wETH

Mapple Finance USDC/wETH
TVL (USD)
NOT OK
Too much different each pool compared to Maple App

Mapple Finance USDC/wETH
Reward Tokens
NOT OK
Slighlty different each pool compared to Maple App

Pool Metrics

Pool
Section
Metric
Issue

Orthogonal Trading USDC01

liquidityPoolDailySnapshots
totalValueLockedUSD
NOT OK
- Not Good, constantly difference compared to Dune (3.09% to 4.43%)

liquidityPoolDailySnapshots
totalDepositBalanceUSD
OK
- Slightly off compared to Dune

liquidityPoolDailySnapshots
dailyVolumeByTokenAmount - USDC
OK
- Slightly off compared to Dune

liquidityPoolDailySnapshots
inputTokenBalances - USDC
OK
- Slightly off compared to Dune

liquidityPoolHourlySnapshots
totalValueLockedUSD
OK
- The value numbers are the Same as daily time series (Good)

Anything that was labeled "NOT OK" because of numbers being "slightly off" has had its status changed to OK


Initial setup for template repository

I've added the library as a git submodule (these now work with git template repositories - which makes our lives a lot easier!), as well as a README file, a conda environment file, and the setup configuration file for building the datasets used for this tutorial.

To make the repository into a template repository, click the tick button at the top of the Setttings page (just underneath the repository name box).