#2584 async context propagation

Reduce Span dependency on SpanEvent
Remove unused class

Codecov Report

Merging #2848 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2848      +/-   ##
==========================================
- Coverage   40.92%   40.92%   -0.01%
==========================================
  Files        1803     1802       -1
  Lines       61625    61562      -63
  Branches     8655     8651       -4
==========================================
- Hits        25223    25193      -30
+ Misses      36402    36369      -33

Impacted Files
Coverage Δ

...nt/profiler/context/active/ActiveTraceFactory.java
64.15% <ø> (+5.53%)
:arrow_up:

...navercorp/pinpoint/test/mock/MockTraceContext.java
11.11% <ø> (ø)
:arrow_up:

...ler/context/recorder/WrappedSpanEventRecorder.java
25% <100%> (-3.95%)
:arrow_down:

...pinpoint/profiler/context/DefaultTraceContext.java
49.38% <100%> (ø)
:arrow_up:

...navercorp/pinpoint/profiler/context/SpanEvent.java
72.34% <100%> (+3.29%)
:arrow_up:

.../java/com/navercorp/pinpoint/rpc/cluster/Role.java
0% <0%> (-71.43%)
:arrow_down:

.../com/navercorp/pinpoint/rpc/packet/PongPacket.java
50% <0%> (-21.43%)
:arrow_down:

...npoint/rpc/server/SimpleServerMessageListener.java
80% <0%> (-20%)
:arrow_down:

...rp/pinpoint/rpc/control/ControlMessageDecoder.java
66.07% <0%> (-14.29%)
:arrow_down:

...om/navercorp/pinpoint/rpc/codec/PacketDecoder.java
71.08% <0%> (-7.23%)
:arrow_down:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f14bf1...521c817. Read the comment docs.


Don't print GitHub annotations in JSON mode

The output does not mix well. This does mean the PDK can't use these annotations, but at least it doesn't break it either.

fwiw, because of the way the PDK runs tools in background shells and parses all the output as JSON, it wasn't ever going to be able to use this directly anyway. The PDK will have to learn annotations all on its own.


Fix: dataplaneId null for older TransferProcesses

WHAT
Add a fix related with the null dataplaneId value in a TransferProcess.
WHY
To avoid terminated null dp_id's errors. Similar to https://github.com/eclipse-edc/Connector/pull/4420
FURTHER NOTES
Please check https://github.com/eclipse-edc/Connector/issues/4418 for more context
Closes https://github.com/eclipse-tractusx/tractusx-edc/issues/1535

@paullatzelsperger @wolf4ood can you please review? 🙇

@wolf4ood reviewed, so I'm taking my own review off

The porting looks good, but i think the DataPlaneSignalingFlowControllerTest is missing

you're, right, thank you, added in https://github.com/eclipse-tractusx/tractusx-edc/pull/1534/commits/c86698ae5769b5fe4c00a908df3a248cb0375ab8

Can you please re-run the tests here? everything is passing locally

@bmg13 i think we also have to port the test when the data plane is null when terminating
https://github.com/eclipse-edc/Connector/pull/4420/files#diff-18c8693725dbf0962879c1552c8e5e24c31af6190dd0a0e1d3d9200b9e250409R314

@bmg13 i think we also have to port the test when the data plane is null when terminating/suspending
https://github.com/eclipse-edc/Connector/pull/4420/files#diff-18c8693725dbf0962879c1552c8e5e24c31af6190dd0a0e1d3d9200b9e250409R314
https://github.com/eclipse-edc/Connector/pull/4420/files#diff-18c8693725dbf0962879c1552c8e5e24c31af6190dd0a0e1d3d9200b9e250409R262

The termination one was added in a later commit: https://github.com/eclipse-tractusx/tractusx-edc/pull/1534/commits/60ebfe166284d4f05ef939b09c2f1f4ff3861c40
the suspend I did not add since these changes added were only to termination and not to suspension


[Tabular] Avoid copying identical dataframes

Issue #, if available:
Description of changes:
Avoid copying DataFrame when they are identical. This brings about 10% speedup of single-batch prediction on tabular models.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Just verified that test_scores are exactly the same across multiple datasets and tasks

, and we are saving 11.7% of the prediction time on average.


Missing Dependencies

Debian does not ship with ripgrep installed. it must be installed manually for the script to function.

So what do you say do I make it optional in the script it self or abort the script after suggesting to install it.

Best I can tell the requirements are ripgrep, curl, and libnotify-bin.


file Examples/ecdsa-examples/ecdsa-sig-01.json

This file says:
     "key":{
        "kty":"EC",
        "kid":"11",

but, page 38 of draft-ietf-cose-msg-24.txt says:
o  The 'kty' field MUST be present and it MUST be 'EC2'.

while the kty field is not part of the signature this did raise some concern that I'm verifying with the wrong group!  Please confirm that this file using the NIST 'nistp256' curve? (not secp256XX?)
I'm feeding the following digest into the signature validation:
(byebug) sha256.unpack("H*")
["45e243bb7071e72a288416ccb9cfbd2932fe1926916fe85b344141ecce91e4bb"]
(byebug) sig01_pub_key
#<ECDSA::Point: nistp256, 0xbac5b11cad8f99f9c72b05cf4b9e26d244dc189f745228255a219a86d6a09eff, 0x20138b0b706db558af8254ab7804a3a64b6d72ccf5adbedbb4a2eff045f8>
(byebug) signature
#<ECDSA::Signature:0x00000001f1df00 @s=51765963774164195565914350724151000343397507914291589008366842864028004758943, @r=106251839252054433277813174560343063247957774643926440805394321619487281072353>
I wonder if I've gotten something trivial screwed up? Order or r/s maybe.

The curve to be used is controlled not by the kty field, but by the crv field.  And yes this is the nistp256 curve.  I can see changing the string to match the document, but JOSE uses the string 'EC' so that is what I kept for this purpose.  (I have similar tests that run over JOSE as well.)
I have a different SHA256 value than what you are displaying.  The string to be hashed is part of file - in "Intermediates"."ToBeSigned_Hex" - check for seeing what is different there

Thanks Jim. I confirmed that I am producing the same input to the SHA256 (yes, the ToBeSigned_Hex).
I realize that crv controls the curve, but that's identical. I was worried that maybe "EC" vs "EC2" might refer to some other set of families.
What is your SHA256 output?

Just to be sure my Ruby library wasn't doing something weird.... And I'm pretty sure this matches your ToBeSigned input.
obiwan-[~/Desktop/Downloads](2.2.1) mcr 10016 %hexdump -C ~/net/dooku/corp/projects/pandora/chariwt/n1.bin
00000000  84 6a 53 69 67 6e 61 74  75 72 65 31 45 a2 01 26  |.jSignature1E..&|
00000010  03 00 f6 54 54 68 69 73  20 69 73 20 74 68 65 20  |...TThis is the |
00000020  63 6f 6e 74 65 6e 74 2e                           |content.|
00000028
obiwan-[~/Desktop/Downloads](2.2.1) mcr 10017 %sha256sum ~/net/dooku/corp/projects/pandora/chariwt/n1.bin
45e243bb7071e72a288416ccb9cfbd2932fe1926916fe85b344141ecce91e4bb  /home/mcr/net/dooku/corp/projects/pandora/chariwt/n1.bin

I thought I'd go on to making my own signatures, and I'd use your private keys. So just for initial fun, I used the d value presented to derive the public key points again. That should be easy. The result was a surprise.  The X values match, but the Y values did not!
(byebug) public_key.x
84479481090508879236361810314595438639920637850206250382769291656310074416895
(byebug) sig01_pub_key.x
84479481090508879236361810314595438639920637850206250382769291656310074416895
(byebug) public_key.y
14508547282523033594077281899984253063221771617900828323772342424228169781630
(byebug) sig01_pub_key.y
221382765198319077083920120796396551052321440967416757858684904626210296
~~~~~~~~

Here is the ecdsa-sig-02 example:

~~~~~~~~
     Failure/Error: expect(public_key.y).to eq(sig02_pub_key.y)

       expected:<PHONE_NUMBER>0031460649754685707864258145190135110235385393681494258596710557893535765907562207370466357656300190667
            got:<PHONE_NUMBER>1848053926337199541213250085168674588220258660782462530200758625213253354049701321900095587770936212451116
~~~~~~~~

so something is systematically wrong with this ecdsa library perhaps.   Here is the public key format that I generated, in case it helps. I am taking this point to the ecdsa github issue hub.

~~~~~~~~
(byebug) public_key_string
"\x02\xBA\xC5\xB1\x1C\xAD\x8F\x99\xF9\xC7+\x05\xCFK\x9E&\xD2D\xDC\x18\x9FtR(%Z!\x9A\x86\xD6\xA0\x9E\xFF"
(byebug) public_key_string.unpack("H*")
["02bac5b11cad8f99f9c72b05cf4b9e26d244dc189f745228255a219a86d6a09eff"]
~~~~~~~~

https://gist.github.com/mcr/b1c9dd9cfcab249e73200d0d056ac0da .
let me add the results. I wonder if there is something that has munged the y-coordinates?

byte 12 in your input is different.
You decode to
84                                      # array(4)
6a                                   # text(10)
5369676e617475726531              # "Signature1"
45                                   # bytes(5)
a201260300                        # "\xA2\x01&\x03\x00"
f6                                   # primitive(22)
54                                   # bytes(20)
546869732069732074686520636f6e74656e742e # "This is the content."
I decode to
84                                      # array(4)
6a                                   # text(10)
5369676e617475726531              # "Signature1"
45                                   # bytes(5)
a201260300                        # "\xA2\x01&\x03\x00"
40                                   # bytes(0)
# ""
54                                   # bytes(20)
546869732069732074686520636f6e74656e742e # "This is the content."

Thanks for checking that. My eyes couldn't see it.


How to use a direct gist file

Hey.
I want on my github and in the gist section to place a file with a black-list
And that the program itself will load it.
How to do it ?
Since you can not use the RAW mode, constantly hash changes in the URL address bar after the changes are made there

@rdbox why you can`t use the raw mode?


[READY TO TEST] improve rapsearch chunk retry logic

Enforce chunk timeout 30 min.
Retry crashed or corrupt output chunks (but not timed out chunks).   Ensure (mostly) that all chunks get their first try before any retries proceed.
Make sure that a crashed chunk is not retried on the same server where it first crashed.   If no other servers available, give up.   If the chunk produced corrupt output (without crashing) it may be retried on the same server.
If 3 or more tries (across all chunks) have failed on a given server, avoid that server.   If more than 2/3 of servers have to be avoided, give up.
If some failure have occurred on a server (but fewer than 3), minimize the probability of choosing that server again -- but choose it if all other servers are fully loaded.
If after 12 tries (across all chunks) the success rate is too low or the failure cost is too high, give up.

Pending some testing and review and a tiny bit more instrumentation.   I feel the run_remotely change is pretty solid, and focusing my work on server.py  -- the goal there is twofold:
(1)  minmize the cost of retries when facing systematic problems that are likely not solvable with retries;  but also at the same time
(2) improve the odds of succcess when facing transient environmental problems like a couple machines with corrupt indexes or other problems
One approach that was already implemented for (2) was adding randomness in the server selection process -  rather than basing it purely on load.  Often a misconfigured server would crash jobs quickly and have low load, so if we picked the least loaded server every time, we would pick the bad server each time, and our retries would be ineffective.  Some sort of metric needs to be in place to deal with this as well, and this PR is also doing something rudimentary there.
As I've said before doing retries well is tricky, there is a reason we are only doing them this late in the game :)

Btw the current system where chunk threads compete for servers is a little nuts, so I should mention I came up with it.   If I was doing it again with the same ssh design I would have one resource manager thread that pulls a chunk from the priority queue of waiting chunks, blocks until a server is available, then launches the chunk on the server as an async job (or in a thread, whatever -- the point is the rate limiting, waiting, prioritizing logic, would be all in one main loop, not with distributed handshakes between hundreds of threads).   I am honestly not quite sure why I did it so complicated the first time.

These additional stats seem helpful.   I'll show more for the various test scenarios.
STATUS REPORT FOR rapsearch: {
    "TOTAL_CHUNKS": 5,
    "CHUNKS_ATTEMPTED": 5,
    "CHUNKS_SUCCEEDED_ON_FIRST_TRY": 5,
    "CHUNKS_SUCCEEDED_ON_RETRY": 0,
    "CHUNKS_FAILED": 0,
    "CHUNKS_ELAPSED_AVG_SUCCESS":<PHONE_NUMBER>937775,
    "CHUNKS_ELAPSED_AVG_FAILURE": 0.0,
    "TOTAL_SERVERS": 2,
    "SERVERS_WITH_FAILURES": 0,
    "SERVER_STATS": {
        "<IP_ADDRESS>": {
            "SUCCESSES": 3,
            "FAILURES": 0
        },
        "<IP_ADDRESS>": {
            "SUCCESSES": 2,
            "FAILURES": 0
        }
    }
}

This shows the expected outcome when timeout is set so that one of the chunks exceeds it deliberately (because of the data in that chunk).
STATUS REPORT FOR rapsearch: {
    "TOTAL_CHUNKS": 5,
    "CHUNKS_ATTEMPTED": 5,
    "CHUNKS_SUCCEEDED_ON_FIRST_TRY": 4,
    "CHUNKS_SUCCEEDED_ON_RETRY": 0,
    "CHUNKS_FAILED": 1,
    "CHUNKS_ELAPSED_AVG_SUCCESS":<PHONE_NUMBER>436996,
    "CHUNKS_ELAPSED_AVG_FAILURE": 1350.0696051120758,
    "TOTAL_SERVERS": 2,
    "SERVERS_WITH_FAILURES": 2,
    "SERVER_STATS": {
        "<IP_ADDRESS>": {
            "SUCCESSES": 2,
            "FAILURES": 1
        },
        "<IP_ADDRESS>": {
            "SUCCESSES": 2,
            "FAILURES": 1
        }
    }
}

{
    "time": "2019-06-19T00:08:26.432",
    "data": {
        "event": "STATUS REPORT FOR rapsearch",
        "values": {
            "TOTAL_CHUNKS": 83,
            "CHUNKS_ATTEMPTED": 54,
            "CHUNKS_SUCCEEDED_ON_FIRST_TRY": 36,
            "CHUNKS_SUCCEEDED_ON_RETRY": 17,
            "CHUNKS_FAILED": 1,
            "CHUNKS_ELAPSED_AVG_SUCCESS":<PHONE_NUMBER>5992946,
            "CHUNKS_ELAPSED_AVG_FAILURE": 1050.0554659366608,
            "TOTAL_SERVERS": 8,
            "SERVERS_WITH_FAILURES": 7,
            "SERVER_STATS": {
                "<IP_ADDRESS>": {
                    "SUCCESSES": 6,
                    "FAILURES": 0
                },
                "<IP_ADDRESS>": {
                    "SUCCESSES": 11,
                    "FAILURES": 1
                },
                "<IP_ADDRESS>": {
                    "SUCCESSES": 4,
                    "FAILURES": 2
                },
                "<IP_ADDRESS>": {
                    "SUCCESSES": 6,
                    "FAILURES": 6
                },
                "<IP_ADDRESS>": {
                    "SUCCESSES": 4,
                    "FAILURES": 1
                },
                "<IP_ADDRESS>": {
                    "SUCCESSES": 4,
                    "FAILURES": 2
                },
                "<IP_ADDRESS>": {
                    "SUCCESSES": 9,
                    "FAILURES": 3
                },
                "<IP_ADDRESS>": {
                    "SUCCESSES": 9,
                    "FAILURES": 3
                }
            }
        }
    },
    "thread": "Thread-29",
    "pid": 594,
    "level": "INFO"
}

Here is a status report that shows a rigged run where we forced every third chunk to fail, then allowed it to succeed on retry, except one chunk (chunk_id=1) we just forced to timeout.   The timeout is not retried, so chunk 1 fails.   A chunk that fails (all retries) causes early exit for the job (since the job can't succeed without that chunk).  In this case about 1/3 of the cost is saved by this early exit.   The distribution of successes and failures across servers is pretty even because in this case we rigged it to deterministically fail every third chunk.   Need to also test a rig where it deterministically fails certain servers.  Coming soon.
The above report shows a bug in calculating ELAPSED_AVG_FAILURE -- wrong denominator, should be number of failed tries, as opposed to the number of chunk_ids that did not succeed.

In this case we rigged every server whose ip address ends in an even number to fail all its chunks.   As luck had it, all our servers had even ip numbers, so all chunks that were attempted, failed.   No chunk was retried, because, a retry waits behind the first tries, and after 12 failing first tries we decide the service is unreliable and give up on the entire job.
{
    "time": "2019-06-19T01:08:55.773",
    "data": {
        "event": "STATUS REPORT FOR rapsearch",
        "values": {
            "TOTAL_CHUNKS": 83,
            "CHUNKS_ATTEMPTED": 16,
            "CHUNKS_SUCCEEDED_ON_FIRST_TRY": 0,
            "CHUNKS_SUCCEEDED_ON_RETRY": 0,
            "CHUNKS_FAILED": 16,
            "CHUNKS_ELAPSED_AVG_SUCCESS": 0,
            "CHUNKS_ELAPSED_AVG_FAILURE": 60.00378108024597,
            "TOTAL_SERVERS": 4,
            "SERVERS_WITH_FAILURES": 4,
            "SERVER_STATS": {
                "<IP_ADDRESS>": {
                    "SUCCESSES": 0,
                    "FAILURES": 4
                },
                "<IP_ADDRESS>": {
                    "SUCCESSES": 0,
                    "FAILURES": 4
                },
                "<IP_ADDRESS>": {
                    "SUCCESSES": 0,
                    "FAILURES": 4
                },
                "<IP_ADDRESS>": {
                    "SUCCESSES": 0,
                    "FAILURES": 4
                }
            }
        }
    },
    "thread": "Thread-26",
    "pid": 595,
    "level": "INFO"
}

{
    "time": "2019-06-19T02:01:02.891",
    "data": {
        "event": "STATUS REPORT FOR rapsearch",
        "values": {
            "TOTAL_CHUNKS": 83,
            "CHUNKS_ATTEMPTED": 83,
            "CHUNKS_SUCCEEDED_ON_FIRST_TRY": 75,
            "CHUNKS_SUCCEEDED_ON_RETRY": 8,
            "CHUNKS_FAILED": 0,
            "CHUNKS_ELAPSED_AVG_SUCCESS":<PHONE_NUMBER>602891,
            "CHUNKS_ELAPSED_AVG_FAILURE": 60.00269511342049,
            "TOTAL_SERVERS": 8,
            "SERVERS_WITH_FAILURES": 2,
            "SERVER_STATS": {
                "<IP_ADDRESS>": {
                    "SUCCESSES": 14,
                    "FAILURES": 0
                },
                "<IP_ADDRESS>": {
                    "SUCCESSES": 0,
                    "FAILURES": 4
                },
                "<IP_ADDRESS>": {
                    "SUCCESSES": 12,
                    "FAILURES": 0
                },
                "<IP_ADDRESS>": {
                    "SUCCESSES": 14,
                    "FAILURES": 0
                },
                "<IP_ADDRESS>": {
                    "SUCCESSES": 14,
                    "FAILURES": 0
                },
                "<IP_ADDRESS>": {
                    "SUCCESSES": 15,
                    "FAILURES": 0
                },
                "<IP_ADDRESS>": {
                    "SUCCESSES": 14,
                    "FAILURES": 0
                },
                "<IP_ADDRESS>": {
                    "SUCCESSES": 0,
                    "FAILURES": 4
                }
            }
        }
    },
    "thread": "Thread-26",
    "pid": 582,
    "level": "INFO"
}

In this case 2 of the 8 servers were rigged to crash their chunks after 60 seconds.   Those servers were only given 4 chunks to try.   After that the system learned to avoid the 2 rigged servers.   All failures were retried on different servers and succeded, as did the entire job.


Can not sign transactions for account

I've enabled write mode in the ./config/mainnet.yaml and am trying to send transactions using the relayer but I am getting the following error:
"Internal Error - Error: Can not sign transactions for account relayer1497898df7b5f14a.near on network mainnet, no matching key pair found in InMemorySigner(MergeKeyStore(InMemoryMultiKeyStore, InMemoryKeyStore, UnencryptedFileSystemKeyStore(/home/node/.near-credentials))).. "
I have read the various Near/Aurora docs but I'm stuck - I assume I need to use another account that Ive setup to do this ? can someone provide some clear instructions on what I need to do to allow my aurora RPC node to send txes?

I figured out my issue and how to generate my own credentials so have closed this ticket.

I figured out my issue and how to generate my own credentials so have closed this ticket.

@damiensgit Cloud you provide steps to figure out this issue?

@damiensgit bro could you provide some guide to figure out this issue please?

Please see the updated readme.

Please see the updated readme.

thanks a lot, it's really help!


Forking sometimes fails without any explanation

This seems to mostly happen on readonly drives

Yeah, I've just tried to copy your personal hyperdrive. It doesn't appear in "My Drives". It seems it conflicts with "host this drive" feature. When I've started hosting your drive, I'm no more able to fork/copy your drive. If I stop hosting your drive then the fork/copy feature will just enable the hosting back.
There's some conflicts between "host this drive" and "fork/copy".


afew silently dying in cronjobs?

This might be a problem specific to my setup (fresh debian testing, python 2.7.8), but I thought I'd give it a go here..
I have a script that pulls mails, and calls notmuch and afew, roughtly as below.
#!/bin/bash

# look up pid of running gnome-keyring-daemon to unlock passwds

die() {
    # notify me about error via desktop notifications
    exit 1
}

index() {
    echo ------------------------ NOTMUCH ------------------------
    /usr/local/bin/notmuch new || die "NOTMUCH new failed"

    echo ------------------------  AFEW   ------------------------
    /home/pazz/.local/bin/afew -v -t -n -C /home/pazz/.notmuch-config
    echo ---------------------------------------------------------
}

set -e
nm-online -x   # stop if not online

/usr/bin/mbsync $@ uow || die "UOW failed"
/usr/bin/mbsync $@ gmail || die "GMAIL failed"

index
date

Works fine when triggered manually. In particular, I get afew's verbose log
messages.
Now when I call this script from cron, it seems that afew is not called at all:
On standart out I get:
...
------------------------ NOTMUCH ------------------------
Processed 42 total files in almost no time.
No new mail.
------------------------ AFEW ------------------------
----------------------------------------------------------
Sat 14 Feb 14:52:09 GMT 2015

First question: why does afew -v print to stderr, and not to stdout?
Secondly, even the standart err contains nothing of afew:
i get some notmuch error messages complaining about nonmail (mbsync status) files,
but no output from afew.
Also, afew seems not to have run: new messages carry the new tag and are not tagged otherwise.
It seems afew died silently on me.
Any suggestions?
[edit] and by "silently", i mean not doing anything while still exiting with return code 0.

to answer my first question: afew uses the logging module and that prints to stderr per default.
I added some "print()"'s to afew for the heck of it. And it seems afew does in fact run and also exit properly when called by cron. It seems that it just can't find any filters and thus doesn't do anything..

some more debugging:
It seems that this line: https://github.com/teythoon/afew/blob/master/afew/Settings.py#L36
does not what it's supposed to:
The value of user_config_dir before is:
 /home/pazz/.config/afew/config

afterwards, settings.sections() returns
['global', 'SpamFilter', 'KillThreadsFilter',  ...]

according to my config, when I call afew from the terminal.
From cron, settings.sections() returns
['global']

I thought it was an issue with file permissions for this file, but a crontab entry
* * * * * cat /home/pazz/.config/afew/config >/home/pazz/.afew.slog

has the effect that the config file is copied as expected.
Now I'm really at my wits' end :/

ARGS!
The value of user_config_dir was in fact
$HOME/.config/afew

The patch below fixes the issue for me. Do you have any reservations agains
os.path.expandvars at this point?
+++ b/afew/Settings.py
@@ -27,6 +27,7 @@ from afew.FilterRegistry import all_filters
 user_config_dir = os.path.join(os.environ.get('XDG_CONFIG_HOME',
                                               os.path.expanduser('~/.config')),
                                'afew')
+user_config_dir=os.path.expandvars(user_config_dir)

 settings = SafeConfigParser()
 # preserve the capitalization of the keys.

Hi Pazz :)
Quoting Patrick Totzke (2015-02-20 01:21:24)

$HOME/.config/afew
The patch below fixes the issue for me. Do you have any reservations agains
os.path.expandvars at this point?

:/ good catch.  I don't have reservations against your patch.  I'm
somewhat curious though where the `$HOME/.config/afew' came from.
Justus

Sidenote: when I fumbled around with this i saw that afew has a -C option to set notmuchs config
but no option to set its own. This would have allowed to fix the issue without sending patches..


calculate snap dir size by scan

Signed-off-by: qupeng<EMAIL_ADDRESS>What problem does this PR solve?
Issue Number: close #9896 .
What is changed and how it works?
Before the patch the snap directory size is tracked in memory. However it's hard to handle mv *.sst.tmp *.sst if the target path exists. Besides this maybe there are still other unknown bugs.
This PR calculates the snap directory size by scan. This operation is moved to the PD worker thread from raftstore threads. A benchmark in #9896 shows that the scan won't hurt performance too much.
Related changes

PR to update pingcap/docs/pingcap/docs-cn:
PR to update pingcap/tidb-ansible:
Need to cherry-pick to the release branch

Check List
Tests

Unit test
Manual test
With the patch store-used-size is very close to engine-size:

Without the patch store-used-size becomes far from engine-size after about 6 hours:

Release note

No release note.

/release

/release

/run-all-tests

/merge

/run-all-tests

/merge

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

Does release 3.0 exist this problem?

Does it mean there is leak resource?


conflicting types for ‘base_yylex’

i'm having problems compiling
bison (GNU Bison) 3.0.4
flex 2.6.4
gcc (GCC) 7.1.1 20170630
gram.c:64:25: error: conflicting types for ‘base_yylex’
 #define yylex           base_yylex
                         ^
scan.c:9205:12: note: in expansion of macro ‘yylex’

            ^
In file included from gram.y:61:0:
../../../src/include/parser/gramparse.h:68:12: note: previous declaration of ‘base_yylex’ was here
 extern int base_yylex(YYSTYPE *lvalp, YYLTYPE *llocp,
            ^~~~~~~~~~
gram.c:64:25: error: conflicting types for ‘base_yylex’
 #define yylex           base_yylex
                         ^
scan.c:9208:21: note: in expansion of macro ‘yylex’

                     ^
scan.c:9229:1: note: in expansion of macro ‘YY_DECL’
  */
 ^~~
In file included from gram.y:61:0:
../../../src/include/parser/gramparse.h:68:12: note: previous declaration of ‘base_yylex’ was here
 extern int base_yylex(YYSTYPE *lvalp, YYLTYPE *llocp,
            ^~~~~~~~~~

@yannick if I remember correctly you're building on ArchLinux, can you share/confirm the specifics of the platform though?
Once we have that we'll look at running through the entire build process on it to determine if we need to make any compatibility changes/improvements on our end, and if not we can share the process we used with you.

yes, archlinux.
by default it now has
gcc (GCC) 7.1.1 20170630
flex 2.6.4 bison (GNU Bison) 3.0.4
there must be something going wrong during the configure step.

@yannick can you share all of the steps you've used, starting from scratch on ArchLinux in order to get here?

@derekjn sure. but its basically just what the readme says.
here is a Docker file to reproduce the issue:
https://github.com/yannick/build-pipelinedb-on-archlinux
if that works some more work is needed, namely remove the dependency from /usr/lib/zmq.a in the makefile and make that one auto detect or user submittable. plus openssl configs such as:
PKG_CONFIG_PATH=/usr/lib/openssl-1.0/pkgconfig CFLAGS+=" -I/usr/include/openssl-1.0" LDFLAGS+=" -L/usr/lib/openssl-1.0 -lssl" ./configure --mandir=/usr/share/man --datadir=/usr/share/postgresql --sysconfdir=/etc --with-gssapi --with-libxml --with-openssl --with-perl --with-python PYTHON=/usr/bin/python2 --with-tcl --with-pam --with-system-tzdata=/usr/share/zoneinfo --with-uuid=e2fs --enable-nls --enable-thread-safety --with-openssl

but getting the parser error out of the way would make it possible for me to fix these things

+1

Same issue here with GCC 6.4.0 and same versions of flex and bison, using Gentoo.

@yannick so we took some time using your Docker image (thanks!) to take a closer look at what's going on here. The same error is produced when building vanilla PG 9.5.3, which is the version of PG that PipelineDB is currently based on. Note that the latest PG 10 builds just fine on Arch Linux, and thus so will PipelineDB 1.0.0.
The only apparently relevant difference we were able to see between our build environment and the Arch Linux build environment provided is the flex version. Looking through the headers, any flex version greater than 2.6.0 can cause quite a lot of differences between #defines, resulting in a fairly different parser build.
I don't have much experience with AL but it didn't seem very straightforward to install a specific version of flex. I think that a good first step towards finally resolving this would be to run flex version 2.6.0. If you can update the Dockerfile to do this we'd be happy to keep looking into it.


Update app.js

Hi @minan05, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;


pretrained weight download

Could you please share an implementation using stable diffusion within the diffusers library?
Downloading the repository you mentioned would require over 40GB, which is too difficult for my hard drive and internet speed.

Hello，Have you make it?

It appears that alternative third-party download options are available if you're experiencing slow download speeds from Hugging Face. E.g.,

https://blog.csdn.net/BetrayFree/article/details/134151873


It takes two taps on mobile...

First interaction with star rating takes two taps on mobile (safari, iOS) to get the onclick event to fire. It happens in your own demo:
https://www.vevix.net/ember-star-rating/
Removing the mouseMove event from the component "fixes" it - but then you don't get the desired mouseover effect on desktop.
Only affects the FIRST mobile tap.
 Mouse events will never be fired b/c of preventDefault() (see above link with event ordering). Should be self-explanatory what I've done.
Then, change _getTarget() to this:
_getTarget(x) {
  const numStars = get(this, 'numStars');
  let numStarsFilled = (numStars * (x - this.$().offset().left) / this.$().width() + 0.5);

  if (numStarsFilled > numStars) {
    numStarsFilled = numStars;
  }

  if (get(this, 'useHalfStars')) {
    return numStarsFilled;
  }
  return Math.ceil(numStarsFilled - 0.5);
},

I have added a sanity check for numStarsFilled, so that dragging beyond the number of stars, during a touch event, will prevent the value exceeding the number of stars. In other words, without this, the touchEnd event could be fired (thumb lifted up) when the thumb is outside the component, and a five star rating component could return a rating of 8 (or other value higher than 5).
No time for a PR right now.

PR created.
https://github.com/trmcnvn/ember-star-rating/pull/18

Thanks 👍


[Bug]: Receive button on Spending page always performs CJIT onboarding

Describe the bug
If the wallet already has a lightning channel and user is on the 'Spending' page, if the Receive button is pressed then the CJIT flow is triggered. It should only do this when the wallet has no LN channel.
Reproduce

Go to '...'
Click on '....'
Scroll down to '....'
See error

Screenshots / Recording
No response
Operating system
Android 13 TKQ1.221114.001
Bitkit version
v130
Log output
No response

Tested on v1.0.4 6404b079a1dd23f079515b3d7a14865baf959914
@pwltr is it intentional that when there are historical spending activities it goes straight to CJIT flow? I ask because the "send Bitcoin to your SPENDING BALANCE" message and arrow are not displayed anymore.
https://github.com/user-attachments/assets/d5bccaf9-c2f9-4474-8261-4efc450e921b

No you're right this probably should only go to CJIT when there is no receiving capacity. Right now it checks whether spending balance is 0.


Revert "fix: update output variable validation (#264)" and "docs: upd…

…ate API ref for the setOutput API (#265)"
This reverts commits 4bc87f71ff940ef9f80f3dec981273dd1403f6ae and 31dc4fd001c0d0f6752ceaa90e0f777a6b4f2a8c.
Description
This change reverts commits relating to changes in output variable validation.
Testing
./build.sh
yarn run test-all
Checklist
I have:

[ ] Added new automated tests for any new functionality
[x] Run npm run build

Licensing statement (do not modify)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

reverting is fine. but we have a customer impacting ticket that they need to have us increase the length of the name.

reverting is fine. but we have a customer impacting ticket that they need to have us increase the length of the name.

this is pushed back to the next commit


Regular Expression don't work ?

Hi,
I tried to edit rules.cfg for match dev.example.com or dev.test.org :
[     {         "Pattern": "^dev\.([\da-z\.-]+)\.([a-z\.]{2,6})$",         "Address": "<IP_ADDRESS>"     } ]
But does'nt works.
I've test my regex on this website : https://www.regexpal.com/, it's work.
Could u help me please ?

You have to escape \ character because it's in a JSON string.
 { "Pattern": "^dev\\.([\\da-z\\.-]+)\\.([a-z\\.]{2,6})$", "Address": "<IP_ADDRESS>" } ]

Thanks stackia, works fine !


LDAP/AD details

Some things are not clear to me with LDAP.

If a user is to be authenticated by LDAP - does she need pre-creation of sqlpad user by admin? This should be documented in authentication.md

Is it possible to enable LDAP authentication while disabling local username registration? (It should be possible in an enterprise environment. Looking at the code I'm not sure this is possible). This should be documented in authentication.md

Add a URL example LDAP_URL to configuration.md - I took the example from http://www.passportjs.org/packages/passport-ldapauth/ . Is that correct? are both LDAP and LDAPS supported? #707

@dengc367

@eladeyal-intel
I think admin should pre-create the ldap email(eg<EMAIL_ADDRESS>in sqlpad, so the admin can control the process to authentication and authority of the user, because configuration roles is in the sqlpad metadata database, and we should mapping the user and role.
Of course, if no pre-creation of ldap user by admin, we can still give the default authority to the user.

I did not understand @dengc367  response to #1 and #2. I think things like that should be documented. (And then maybe changed if needed). I will not be using LDAP myself.

@eladeyal-intel Sorry, I misunderstood your meaning before. OK, I will update it in authentication.md and #707  wait for a monent.

@eladeyal-intel  PR #738 submitted, please check. thanks.


attach to game window by SetParent

Check for fullscreen mod and the plugin load process not shown.
Some hacky code added and please carefully reviewed before merge.


Resource not found: The following package was not found in : mavlink_sitl_gazebo

After following all the instructions when i run roslaunch px4_fast_planner px4_fast_planner.launch. i get the errors:
Resource not found: The following package was not found in : mavlink_sitl_gazebo
ROS path [0]=/opt/ros/melodic/share/ros
ROS path [1]=/home/muzaib/catkin_ws/src
ROS path [2]=/opt/ros/melodic/share
ROS path [3]=/home/muzaib/Firmware
The traceback for the exception was written to the log file

@Muzaib95Anjum looks like you did not includ PX4 SITL packages on the path. Did you do the setup using the setup.sh script in the install folder? It already does that for you and the necessary lines in your .bashrc file

@mzahana yes i did setup using setup.sh script in the install folder! But the error remains....

@Muzaib95Anjum Are the paths updated in you .bashrc Also make sure that you source your .bashrc before you launch the setup?
cd
source .bashrc

@mzahana let me check again then tell you the situation.

@Muzaib95Anjum I just noticed that there are few steps missing in the setup.sh file. I will update it.

@mzahana okay when you update the the file kindly do notify.

@Muzaib95Anjum setup.sh file is updated. Kindly re-run it and check.

@mzahana okay checking it.

Also make sure that the end of your .bashrc looks like the following
source /opt/ros/melodic/setup.bash
source /home/arrow/catkin_ws/devel/setup.bash
source ~/Firmware/Tools/setup_gazebo.bash ~/Firmware ~/Firmware/build/px4_sitl_default
export ROS_PACKAGE_PATH=$ROS_PACKAGE_PATH:~/Firmware
export ROS_PACKAGE_PATH=$ROS_PACKAGE_PATH:~/Firmware/Tools/sitl_gazebo
export GAZEBO_PLUGIN_PATH=$GAZEBO_PLUGIN_PATH:/usr/lib/x86_64-linux-gnu/gazebo-9/plugins
export GAZEBO_MODEL_PATH=$GAZEBO_MODEL_PATH:/home/arrow/catkin_ws/src/px4_fast_planner/models

Note that your home folder name can be different.
Also make sure that
source $HOME/catkin_ws/devel/setup.bash

is before all the export lines.

@mzahana okay thanks i am re running it.

If your issue is solved please close it.

@mzahana i have re runned the file and after this command roslaunch px4_fast_planner px4_fast_planner.launch these errors are listed:
ERROR: cannot launch node of type [px4/px4]: Cannot locate node of type [px4] in package [px4]. Make sure file exists in package path and permission is set to executable (chmod +x)
[rvizvisualisation-16] process has died [pid 5438, exit code -6, cmd /opt/ros/melodic/lib/rviz/rviz -d /home/muzaib/catkin_ws/src/px4_fast_planner/rviz/rviz.rviz __name:=rvizvisualisation __log:=/home/muzaib/.ros/log/8ac84420-bfb5-11ea-91fb-54ab3ae22b7e/rvizvisualisation-16.log].
log file: /home/muzaib/.ros/log/8ac84420-bfb5-11ea-91fb-54ab3ae22b7e/rvizvisualisation-16*.log
[gazebo-5] process has died [pid 5398, exit code 134, cmd /opt/ros/melodic/lib/gazebo_ros/gzserver -e ode /home/muzaib/catkin_ws/src/px4_fast_planner/worlds/outdoor_village.world __name:=gazebo __log:=/home/muzaib/.ros/log/8ac84420-bfb5-11ea-91fb-54ab3ae22b7e/gazebo-5.log].
log file: /home/muzaib/.ros/log/8ac84420-bfb5-11ea-91fb-54ab3ae22b7e/gazebo-5*.log
RVIZ opened and closed immediately and Gazebo has no models!!

How does your .bashrc look like?
Did you source it before you launch?
Also expect Gazebo to take some time the first time you run the setup as it downloads worrd models

My .bashrc
source /opt/ros/melodic/setup.bash
source /home/muzaib/catkin_ws/devel/setup.bash
source ~/Firmware/Tools/setup_gazebo.bash ~/Firmware ~/Firmware/build/px4_sitl_default
export ROS_PACKAGE_PATH=$ROS_PACKAGE_PATH:~/Firmware
export ROS_PACKAGE_PATH=$ROS_PACKAGE_PATH:~/Firmware/Tools/sitl_gazebo
export GAZEBO_PLUGIN_PATH=$GAZEBO_PLUGIN_PATH:/usr/lib/x86_64-linux-gnu/gazebo-9/plugins
export GAZEBO_MODEL_PATH=$GAZEBO_MODEL_PATH:/home/muzaib/catkin_ws/src/px4_fast_planner/models
Yes i sourced it when opened new terminal source .bashrc

you need to also have
export ROS_PACKAGE_PATH=$ROS_PACKAGE_PATH:~/Firmware
export ROS_PACKAGE_PATH=$ROS_PACKAGE_PATH:~/Firmware/Tools/sitl_gazebo

This is my .bashrc
source /opt/ros/melodic/setup.bash
source /home/muzaib/catkin_ws/devel/setup.bash
source ~/Firmware/Tools/setup_gazebo.bash ~/Firmware ~/Firmware/build/px4_sitl_default
export ROS_PACKAGE_PATH=$ROS_PACKAGE_PATH:~/Firmware
export ROS_PACKAGE_PATH=$ROS_PACKAGE_PATH:~/Firmware/Tools/sitl_gazebo
export GAZEBO_PLUGIN_PATH=$GAZEBO_PLUGIN_PATH:/usr/lib/x86_64-linux-gnu/gazebo-9/plugins
export GAZEBO_MODEL_PATH=$GAZEBO_MODEL_PATH:/home/muzaib/catkin_ws/src/px4_fast_planner/models

I am not sure why are you crossing
source ~/Firmware/Tools/setup_gazebo.bash /Firmware /Firmware/build/px4_sitl_default
export ROS_PACKAGE_PATH=$ROS_PACKAGE_PATH:/Firmware
export ROS_PACKAGE_PATH=$ROS_PACKAGE_PATH:/Firmware/Tools/sitl_gazebo
are they not included in your bashrc?

@mzahana i am not crossing them when i paste them from terminal it gets crossed. Yes they are included in my .bashrc. And Gazebo is opened with the world but i cant see the drone in it. And rviz is not opened also kindly guide.

I am not sure what your issue is here. The setup seems correct. Are you able to launch PX$ SITL alone?

@ i have run the command roslaunch px4_fast_planner px4_fast_planner.launch it opened the following

rqt_configure
gazebo

But i cant see the drone in the Simulation and Rviz opened and immediately closed.. This is i am assking..

Can you run ?
cd ~/Firmware
make px4_sitl_default gazebo

@mzahana Yes i ran and gazebo opened with empty world and a Drone

That means PX4 SITL is compiled and successfully. Then, I see no reason why the setup should not work.

I just notice that your .bashrc is not correct. The Firmware folder should be in home i.e. ~/Firmware, and the correct .bashrc should point to ~/Firmware not /Firmware

@mzahana the project is started to work Fine now Thank you for your cooperation.

Hello! I am new to ROS and Linux. Right now I am doing research that requires the use of them.
When trying to run the ORB_SLAM2_CUDA project on a jetson nano, but I have an error specified as follows:
Resource not found: the following package was not found in : ORB_SLAM2_CUDA
ROS path [0] = / opt / ros / melodic / share / ros
ROS path [1] = / opt / ros / melodic / share /
The traceback for the exception was written to the log file
I don't know what to do to fix this error. I would appreciate your cooperation.

Hello! I am new to ROS and Linux. Right now I am doing research that requires the use of them.
When trying to run the ORB_SLAM2_CUDA project on a jetson nano, but I have an error specified as follows:
Resource not found: the following package was not found in : ORB_SLAM2_CUDA
ROS path [0] = / opt / ros / melodic / share / ros
ROS path [1] = / opt / ros / melodic / share /
The traceback for the exception was written to the log file
I don't know what to do to fix this error. I would appreciate your cooperation.

@DavidLlantenC Hi!
Unfortunately, this is not the right place for your question. It's better to ask on the corresponding repository issue tracker.

Hello !!..i'm trying to the simulation but it's show the same like @Muzaib95Anjum and my .bashrc looks like
.
.
source /opt/ros/melodic/setup.bash
source /home/tanmay/catkin_ws/devel/setup.bash
export PATH=/usr/lib/ccache:$PATH
export GAZEBO_MODEL_PATH=~/ardupilot_gazebo/model
source ~/Firmware/Tools/setup_gazebo.bash ~/Firmware ~/Firmware/build/px4_sitl_default
export ROS_PACKAGE_PATH=$ROS_PACKAGE_PATH:~/Firmware
export ROS_PACKAGE_PATH=$ROS_PACKAGE_PATH:~/Firmware/Tools/sitl_gazebo
export GAZEBO_PLUGIN_PATH=$GAZEBO_PLUGIN_PATH:/usr/lib/x86_64-linux-gnu/gazebo-9/plugins
export GAZEBO_MODEL_PATH=$GAZEBO_MODEL_PATH:/home/tanmay/catkin_ws/src/px4_fast_planner/models
.
.
.
And the error shown in the terminal is
Resource not found: The following package was not found in : mavlink_sitl_gazebo
ROS path [0]=/opt/ros/melodic/share/ros
ROS path [1]=/home/tanmay/catkin_ws/src
ROS path [2]=/opt/ros/melodic/share
The traceback for the exception was written to the log file

And after adding /opt/ros/melodic/share to .bashrc, I'm getting this error
.
.
WARN: unrecognized 'param' tag in  tag
WARN: unrecognized 'param' tag in  tag
WARN: unrecognized 'param' tag in  tag
WARN: unrecognized 'param' tag in  tag
WARN: unrecognized 'param' tag in  tag
WARN: unrecognized 'param' tag in  tag
started roslaunch server http://tanmay-Nitro-AN515-54:39111/
SUMMARY
CLEAR PARAMETERS

/mavros/

PARAMETERS

/camera_pose_publisher/child_frame: camera_link
/camera_pose_publisher/parent_frame: world
/camera_pose_publisher/pose_topic: camera/pose
/fast_planner_node/bspline/limit_acc: 2.5
/fast_planner_node/bspline/limit_ratio: 1.1
/fast_planner_node/bspline/limit_vel: 1.0
/fast_planner_node/fsm/act_map: False
/fast_planner_node/fsm/flight_type: 1
/fast_planner_node/fsm/thresh_no_replan: 2.0
/fast_planner_node/fsm/thresh_replan: 0.5
/fast_planner_node/fsm/waypoint0_x: 19.0
/fast_planner_node/fsm/waypoint0_y: 0.0
/fast_planner_node/fsm/waypoint0_z: 1.0
/fast_planner_node/fsm/waypoint1_x: 0.0
/fast_planner_node/fsm/waypoint1_y: 10.0
/fast_planner_node/fsm/waypoint1_z: 1.0
/fast_planner_node/fsm/waypoint2_x: -19.0
/fast_planner_node/fsm/waypoint2_y: 0.0
/fast_planner_node/fsm/waypoint2_z: 1.0
/fast_planner_node/fsm/waypoint_num: 2
/fast_planner_node/heading_planner/half_vert_num: 3
/fast_planner_node/heading_planner/lambda1: 2.0
/fast_planner_node/heading_planner/lambda2: 1.0
/fast_planner_node/heading_planner/max_yaw_rate: 1.04719753333
/fast_planner_node/heading_planner/w: 10.0
/fast_planner_node/heading_planner/yaw_diff: 0.0872664611111
/fast_planner_node/manager/clearance_threshold: 0.2
/fast_planner_node/manager/control_points_distance: 0.3
/fast_planner_node/manager/dynamic_environment: 0
/fast_planner_node/manager/local_segment_length: 7.0
/fast_planner_node/manager/max_acc: 2.5
/fast_planner_node/manager/max_jerk: 4.0
/fast_planner_node/manager/max_vel: 1.0
/fast_planner_node/manager/use_geometric_path: False
/fast_planner_node/manager/use_kinodynamic_path: False
/fast_planner_node/manager/use_optimization: True
/fast_planner_node/manager/use_topo_path: True
/fast_planner_node/optimization/algorithm1: 15
/fast_planner_node/optimization/algorithm2: 11
/fast_planner_node/optimization/dist0: 0.4
/fast_planner_node/optimization/dist1: 0.0
/fast_planner_node/optimization/lambda1: 10.0
/fast_planner_node/optimization/lambda2: 5.0
/fast_planner_node/optimization/lambda3: 0.0
/fast_planner_node/optimization/lambda4: 0.001
/fast_planner_node/optimization/lambda5: 1.5
/fast_planner_node/optimization/lambda6: 10.0
/fast_planner_node/optimization/lambda7: 20.0
/fast_planner_node/optimization/max_acc: 2.5
/fast_planner_node/optimization/max_iteration_num1: 2
/fast_planner_node/optimization/max_iteration_num2: 300
/fast_planner_node/optimization/max_iteration_time1: 0.0001
/fast_planner_node/optimization/max_iteration_time2: 0.005
/fast_planner_node/optimization/max_vel: 1.0
/fast_planner_node/optimization/order: 3
/fast_planner_node/planner_node/planner: 2
/fast_planner_node/sdf_map/cx: 320.5
/fast_planner_node/sdf_map/cy: 240.5
/fast_planner_node/sdf_map/depth_filter_margin: 2
/fast_planner_node/sdf_map/depth_filter_maxdist: 7
/fast_planner_node/sdf_map/depth_filter_mindist: 0.2
/fast_planner_node/sdf_map/depth_filter_tolerance: 0.15
/fast_planner_node/sdf_map/esdf_slice_height: 0.3
/fast_planner_node/sdf_map/frame_id: world
/fast_planner_node/sdf_map/fx:<PHONE_NUMBER>36
/fast_planner_node/sdf_map/fy:<PHONE_NUMBER>36
/fast_planner_node/sdf_map/ground_height: -1.0
/fast_planner_node/sdf_map/k_depth_scaling_factor: 1000.0
/fast_planner_node/sdf_map/local_bound_inflate: 0.5
/fast_planner_node/sdf_map/local_map_margin: 50
/fast_planner_node/sdf_map/local_update_range_x: 5.5
/fast_planner_node/sdf_map/local_update_range_y: 5.5
/fast_planner_node/sdf_map/local_update_range_z: 4.5
/fast_planner_node/sdf_map/map_size_x: 40.0
/fast_planner_node/sdf_map/map_size_y: 40.0
/fast_planner_node/sdf_map/map_size_z: 5.0
/fast_planner_node/sdf_map/max_ray_length: 4.5
/fast_planner_node/sdf_map/min_ray_length: 0.5
/fast_planner_node/sdf_map/obstacles_inflation: 0.099
/fast_planner_node/sdf_map/p_hit: 0.65
/fast_planner_node/sdf_map/p_max: 0.9
/fast_planner_node/sdf_map/p_min: 0.12
/fast_planner_node/sdf_map/p_miss: 0.35
/fast_planner_node/sdf_map/p_occ: 0.8
/fast_planner_node/sdf_map/pose_type: 1
/fast_planner_node/sdf_map/resolution: 0.1
/fast_planner_node/sdf_map/show_esdf_time: False
/fast_planner_node/sdf_map/show_occ_time: False
/fast_planner_node/sdf_map/skip_pixel: 2
/fast_planner_node/sdf_map/use_depth_filter: True
/fast_planner_node/sdf_map/virtual_ceil_height: 3.0
/fast_planner_node/sdf_map/visualization_truncate_height: 2.5
/fast_planner_node/topo_prm/clearance: 0.3
/fast_planner_node/topo_prm/max_raw_path2: 25
/fast_planner_node/topo_prm/max_raw_path: 300
/fast_planner_node/topo_prm/max_sample_num: 2000
/fast_planner_node/topo_prm/max_sample_time: 0.005
/fast_planner_node/topo_prm/parallel_shortcut: True
/fast_planner_node/topo_prm/ratio_to_short: 5.5
/fast_planner_node/topo_prm/reserve_num: 6
/fast_planner_node/topo_prm/sample_inflate_x: 1.0
/fast_planner_node/topo_prm/sample_inflate_y: 5.5
/fast_planner_node/topo_prm/sample_inflate_z: 1.0
/fast_planner_node/topo_prm/short_cut_num: 1
/gazebo/enable_ros_network: True
/geometric_controller/Kp_x: 6.0
/geometric_controller/Kp_y: 6.0
/geometric_controller/Kp_z: 10.0
/geometric_controller/Kv_x: 1.5
/geometric_controller/Kv_y: 1.5
/geometric_controller/Kv_z: 3.5
/geometric_controller/ctrl_mode: 2
/geometric_controller/enable_gazebo_state: True
/geometric_controller/enable_sim: True
/geometric_controller/init_pos_x: 0.0
/geometric_controller/init_pos_y: 0.0
/geometric_controller/init_pos_z: 1.0
/geometric_controller/mav_name: iris
/geometric_controller/max_acc: 2.5
/geometric_controller/velocity_yaw: False
/mavros/cmd/use_comp_id_system_control: False
/mavros/conn/heartbeat_rate: 1.0
/mavros/conn/system_time_rate: 1.0
/mavros/conn/timeout: 10.0
/mavros/conn/timesync_rate: 10.0
/mavros/distance_sensor/hrlv_ez4_pub/field_of_view: 0.0
/mavros/distance_sensor/hrlv_ez4_pub/frame_id: hrlv_ez4_sonar
/mavros/distance_sensor/hrlv_ez4_pub/id: 0
/mavros/distance_sensor/hrlv_ez4_pub/orientation: PITCH_270
/mavros/distance_sensor/hrlv_ez4_pub/send_tf: True
/mavros/distance_sensor/hrlv_ez4_pub/sensor_position/x: 0.0
/mavros/distance_sensor/hrlv_ez4_pub/sensor_position/y: 0.0
/mavros/distance_sensor/hrlv_ez4_pub/sensor_position/z: -0.1
/mavros/distance_sensor/laser_1_sub/id: 3
/mavros/distance_sensor/laser_1_sub/orientation: PITCH_270
/mavros/distance_sensor/laser_1_sub/subscriber: True
/mavros/distance_sensor/lidarlite_pub/field_of_view: 0.0
/mavros/distance_sensor/lidarlite_pub/frame_id: lidarlite_laser
/mavros/distance_sensor/lidarlite_pub/id: 1
/mavros/distance_sensor/lidarlite_pub/orientation: PITCH_270
/mavros/distance_sensor/lidarlite_pub/send_tf: True
/mavros/distance_sensor/lidarlite_pub/sensor_position/x: 0.0
/mavros/distance_sensor/lidarlite_pub/sensor_position/y: 0.0
/mavros/distance_sensor/lidarlite_pub/sensor_position/z: -0.1
/mavros/distance_sensor/sonar_1_sub/id: 2
/mavros/distance_sensor/sonar_1_sub/orientation: PITCH_270
/mavros/distance_sensor/sonar_1_sub/subscriber: True
/mavros/fake_gps/eph: 2.0
/mavros/fake_gps/epv: 2.0
/mavros/fake_gps/fix_type: 3
/mavros/fake_gps/geo_origin/alt: 408.0
/mavros/fake_gps/geo_origin/lat: 47.3667
/mavros/fake_gps/geo_origin/lon: 8.55
/mavros/fake_gps/gps_rate: 5.0
/mavros/fake_gps/mocap_transform: True
/mavros/fake_gps/satellites_visible: 5
/mavros/fake_gps/tf/child_frame_id: fix
/mavros/fake_gps/tf/frame_id: map
/mavros/fake_gps/tf/listen: False
/mavros/fake_gps/tf/rate_limit: 10.0
/mavros/fake_gps/tf/send: False
/mavros/fake_gps/use_mocap: True
/mavros/fake_gps/use_vision: False
/mavros/fcu_protocol: v2.0
/mavros/fcu_url<EMAIL_ADDRESS>/mavros/gcs_url:
/mavros/global_position/child_frame_id: base_link
/mavros/global_position/frame_id: map
/mavros/global_position/gps_uere: 1.0
/mavros/global_position/rot_covariance: 99999.0
/mavros/global_position/tf/child_frame_id: base_link
/mavros/global_position/tf/frame_id: map
/mavros/global_position/tf/global_frame_id: earth
/mavros/global_position/tf/send: False
/mavros/global_position/use_relative_alt: True
/mavros/image/frame_id: px4flow
/mavros/imu/angular_velocity_stdev: 0.0003490659 // 0...
/mavros/imu/frame_id: base_link
/mavros/imu/linear_acceleration_stdev: 0.0003
/mavros/imu/magnetic_stdev: 0.0
/mavros/imu/orientation_stdev: 1.0
/mavros/landing_target/camera/fov_x: 2.0071286398
/mavros/landing_target/camera/fov_y: 2.0071286398
/mavros/landing_target/image/height: 480
/mavros/landing_target/image/width: 640
/mavros/landing_target/land_target_type: VISION_FIDUCIAL
/mavros/landing_target/listen_lt: False
/mavros/landing_target/mav_frame: LOCAL_NED
/mavros/landing_target/target_size/x: 0.3
/mavros/landing_target/target_size/y: 0.3
/mavros/landing_target/tf/child_frame_id: camera_center
/mavros/landing_target/tf/frame_id: landing_target
/mavros/landing_target/tf/listen: False
/mavros/landing_target/tf/rate_limit: 10.0
/mavros/landing_target/tf/send: True
/mavros/local_position/frame_id: map
/mavros/local_position/tf/child_frame_id: base_link
/mavros/local_position/tf/frame_id: map
/mavros/local_position/tf/send: True
/mavros/local_position/tf/send_fcu: False
/mavros/mission/pull_after_gcs: True
/mavros/mission/use_mission_item_int: True
/mavros/mocap/use_pose: True
/mavros/mocap/use_tf: False
/mavros/odometry/fcu/odom_child_id_des: base_link
/mavros/odometry/fcu/odom_parent_id_des: map
/mavros/plugin_blacklist: ['safety_area', '...
/mavros/plugin_whitelist: []
/mavros/px4flow/frame_id: px4flow
/mavros/px4flow/ranger_fov: 0.118682
/mavros/px4flow/ranger_max_range: 5.0
/mavros/px4flow/ranger_min_range: 0.3
/mavros/safety_area/p1/x: 1.0
/mavros/safety_area/p1/y: 1.0
/mavros/safety_area/p1/z: 1.0
/mavros/safety_area/p2/x: -1.0
/mavros/safety_area/p2/y: -1.0
/mavros/safety_area/p2/z: -1.0
/mavros/setpoint_accel/send_force: False
/mavros/setpoint_attitude/reverse_thrust: False
/mavros/setpoint_attitude/tf/child_frame_id: target_attitude
/mavros/setpoint_attitude/tf/frame_id: map
/mavros/setpoint_attitude/tf/listen: False
/mavros/setpoint_attitude/tf/rate_limit: 50.0
/mavros/setpoint_attitude/use_quaternion: False
/mavros/setpoint_position/mav_frame: LOCAL_NED
/mavros/setpoint_position/tf/child_frame_id: target_position
/mavros/setpoint_position/tf/frame_id: map
/mavros/setpoint_position/tf/listen: False
/mavros/setpoint_position/tf/rate_limit: 50.0
/mavros/setpoint_raw/thrust_scaling: 1.0
/mavros/setpoint_velocity/mav_frame: LOCAL_NED
/mavros/startup_px4_usb_quirk: True
/mavros/sys/disable_diag: False
/mavros/sys/min_voltage: 10.0
/mavros/target_component_id: 1
/mavros/target_system_id: 1
/mavros/tdr_radio/low_rssi: 40
/mavros/time/time_ref_source: fcu
/mavros/time/timesync_avg_alpha: 0.6
/mavros/time/timesync_mode: MAVLINK
/mavros/vibration/frame_id: base_link
/mavros/vision_pose/tf/child_frame_id: vision_estimate
/mavros/vision_pose/tf/frame_id: odom
/mavros/vision_pose/tf/listen: False
/mavros/vision_pose/tf/rate_limit: 10.0
/mavros/vision_speed/listen_twist: True
/mavros/vision_speed/twist_cov: True
/mavros/wheel_odometry/child_frame_id: base_link
/mavros/wheel_odometry/count: 2
/mavros/wheel_odometry/frame_id: odom
/mavros/wheel_odometry/send_raw: True
/mavros/wheel_odometry/send_twist: False
/mavros/wheel_odometry/tf/child_frame_id: base_link
/mavros/wheel_odometry/tf/frame_id: odom
/mavros/wheel_odometry/tf/send: False
/mavros/wheel_odometry/use_rpm: False
/mavros/wheel_odometry/vel_error: 0.1
/mavros/wheel_odometry/wheel0/radius: 0.05
/mavros/wheel_odometry/wheel0/x: 0.0
/mavros/wheel_odometry/wheel0/y: -0.15
/mavros/wheel_odometry/wheel1/radius: 0.05
/mavros/wheel_odometry/wheel1/x: 0.0
/mavros/wheel_odometry/wheel1/y: 0.15
/rosdistro: melodic
/rosversion: 1.14.12
/traj_msg_converter/fast_planner_traj_topic: planning/ref_traj
/traj_msg_converter/traj_pub_topic: command/trajectory
/traj_server/traj_server/time_forward: 1.5
/use_sim_time: True
/waypoint_generator/waypoint_type: manual-lonely-way...

NODES
/
camera_pose_publisher (px4_fast_planner/camera_pose_publisher.py)
fast_planner_node (plan_manage/fast_planner_node)
gazebo (gazebo_ros/gzserver)
gazebo_gui (gazebo_ros/gzclient)
geometric_controller (geometric_controller/geometric_controller_node)
mavros (mavros/mavros_node)
rqt_reconfigure (rqt_reconfigure/rqt_reconfigure)
rvizvisualisation (rviz/rviz)
sitl (px4/px4)
tf_camera (tf/static_transform_publisher)
traj_msg_converter (px4_fast_planner/trajectory_msg_converter.py)
traj_server (plan_manage/traj_server)
vehicle_spawn_tanmay_Nitro_AN515_54_7906_5010508217689179395 (gazebo_ros/spawn_model)
waypoint_generator (waypoint_generator/waypoint_generator)
world_map_linker (tf/static_transform_publisher)
auto-starting new master
process[master]: started with pid [7917]
ROS_MASTER_URI=http://localhost:11311
setting /run_id to 29cae2ea-30a7-11ec-946a-b89a2a729232
process[rosout-1]: started with pid [7928]
started core service [/rosout]
process[world_map_linker-2]: started with pid [7932]
process[tf_camera-3]: started with pid [7933]
ERROR: cannot launch node of type [px4/px4]: Cannot locate node of type [px4] in package [px4]. Make sure file exists in package path and permission is set to executable (chmod +x)
process[gazebo-5]: started with pid [7934]
process[gazebo_gui-6]: started with pid [7939]
process[vehicle_spawn_tanmay_Nitro_AN515_54_7906_5010508217689179395-7]: started with pid [7944]
process[mavros-8]: started with pid [7945]
ERROR: cannot launch node of type [plan_manage/fast_planner_node]: Cannot locate node of type [fast_planner_node] in package [plan_manage]. Make sure file exists in package path and permission is set to executable (chmod +x)
ERROR: cannot launch node of type [plan_manage/traj_server]: Cannot locate node of type [traj_server] in package [plan_manage]. Make sure file exists in package path and permission is set to executable (chmod +x)
ERROR: cannot launch node of type [waypoint_generator/waypoint_generator]: Cannot locate node of type [waypoint_generator] in package [waypoint_generator]. Make sure file exists in package path and permission is set to executable (chmod +x)
ERROR: cannot launch node of type [geometric_controller/geometric_controller_node]: Cannot locate node of type [geometric_controller_node] in package [geometric_controller]. Make sure file exists in package path and permission is set to executable (chmod +x)
process[rqt_reconfigure-13]: started with pid [7950]
process[camera_pose_publisher-14]: started with pid [7952]
process[traj_msg_converter-15]: started with pid [7953]
process[rvizvisualisation-16]: started with pid [7957]
Traceback (most recent call last):
File "/home/tanmay/catkin_ws/src/px4_fast_planner/scripts/trajectory_msg_converter.py", line 11, in
from quadrotor_msgs.msg import PositionCommand # for Fast-Planner
ImportError: No module named quadrotor_msgs.msg
[traj_msg_converter-15] process has died [pid 7953, exit code 1, cmd /home/tanmay/catkin_ws/src/px4_fast_planner/scripts/trajectory_msg_converter.py __name:=traj_msg_converter __log:=/home/tanmay/.ros/log/29cae2ea-30a7-11ec-946a-b89a2a729232/traj_msg_converter-15.log].
log file: /home/tanmay/.ros/log/29cae2ea-30a7-11ec-946a-b89a2a729232/traj_msg_converter-15*.log
[FATAL] [1634625508.472151975]: UAS: GeographicLib exception: File not readable /usr/share/GeographicLib/geoids/egm96-5.pgm | Run install_geographiclib_dataset.sh script in order to install Geoid Model dataset!
================================================================================REQUIRED process [mavros-8] has died!
process has finished cleanly
log file: /home/tanmay/.ros/log/29cae2ea-30a7-11ec-946a-b89a2a729232/mavros-8*.log
Initiating shutdown!
[rvizvisualisation-16] killing on exit
[rqt_reconfigure-13] killing on exit
[camera_pose_publisher-14] killing on exit
[mavros-8] killing on exit
[vehicle_spawn_tanmay_Nitro_AN515_54_7906_5010508217689179395-7] killing on exit
[gazebo_gui-6] killing on exit
[gazebo-5] killing on exit
[tf_camera-3] killing on exit
[world_map_linker-2] killing on exit
Traceback (most recent call last):
Traceback (most recent call last):
File "/opt/ros/melodic/lib/gazebo_ros/spawn_model", line 34, in
File "/home/tanmay/catkin_ws/src/px4_fast_planner/scripts/camera_pose_publisher.py", line 7, in
from tf.transformations import quaternion_from_euler
import tf
File "/opt/ros/melodic/lib/python2.7/dist-packages/tf/init.py", line 30, in
File "/opt/ros/melodic/lib/python2.7/dist-packages/tf/init.py", line 30, in
from tf2_ros import TransformException as Exception, ConnectivityException, LookupException, ExtrapolationException
from tf2_ros import TransformException as Exception, ConnectivityException, LookupException, ExtrapolationException
File "/opt/ros/melodic/lib/python2.7/dist-packages/tf2_ros/init.py", line 41, in
File "/opt/ros/melodic/lib/python2.7/dist-packages/tf2_ros/init.py", line 41, in
from .buffer_client import *
from .buffer_client import *
File "/opt/ros/melodic/lib/python2.7/dist-packages/tf2_ros/buffer_client.py", line 40, in
File "/opt/ros/melodic/lib/python2.7/dist-packages/tf2_ros/buffer_client.py", line 40, in
import actionlib
import actionlib
File "/opt/ros/melodic/lib/python2.7/dist-packages/actionlib/init.py", line 28, in
File "/opt/ros/melodic/lib/python2.7/dist-packages/actionlib/init.py", line 28, in
from actionlib.action_client import *
File "/opt/ros/melodic/lib/python2.7/dist-packages/actionlib/action_client.py", line 51, in
from actionlib.action_client import *
File "/opt/ros/melodic/lib/python2.7/dist-packages/actionlib/action_client.py", line 51, in
'''
KeyboardInterrupt
'''
KeyboardInterrupt
Traceback (most recent call last):
File "/opt/ros/melodic/lib/rqt_reconfigure/rqt_reconfigure", line 5, in
from rqt_reconfigure.main import main
File "/opt/ros/melodic/lib/python2.7/dist-packages/rqt_reconfigure/main.py", line 36, in
from rqt_reconfigure.param_plugin import ParamPlugin
File "/opt/ros/melodic/lib/python2.7/dist-packages/rqt_reconfigure/param_plugin.py", line 35, in
from rqt_gui_py.plugin import Plugin
File "/opt/ros/melodic/lib/python2.7/dist-packages/rqt_gui_py/plugin.py", line 33, in
from qt_gui.plugin import Plugin as Base
File "/opt/ros/melodic/lib/python2.7/dist-packages/qt_gui/plugin.py", line 31, in
from python_qt_binding.QtCore import QObject
File "/opt/ros/melodic/lib/python2.7/dist-packages/python_qt_binding/init.py", line 55, in
from .binding_helper import loadUi, QT_BINDING, QT_BINDING_MODULES, QT_BINDING_VERSION  # @UnusedImport
File "/opt/ros/melodic/lib/python2.7/dist-packages/python_qt_binding/binding_helper.py", line 276, in
getattr(sys, 'SELECT_QT_BINDING_ORDER', None),
File "/opt/ros/melodic/lib/python2.7/dist-packages/python_qt_binding/binding_helper.py", line 108, in _select_qt_binding
QT_BINDING_VERSION = binding_loader(required_modules, optional_modules)
File "/opt/ros/melodic/lib/python2.7/dist-packages/python_qt_binding/binding_helper.py", line 155, in _load_pyqt
_named_optional_import('PyQt5.%s' % module_name)
File "/opt/ros/melodic/lib/python2.7/dist-packages/python_qt_binding/binding_helper.py", line 142, in _named_optional_import
_named_import(name)
File "/opt/ros/melodic/lib/python2.7/dist-packages/python_qt_binding/binding_helper.py", line 133, in _named_import
module = builtins.import(name)
KeyboardInterrupt
[rosout-1] killing on exit
[master] killing on exit
shutting down processing monitor...
... shutting down processing monitor complete
done
@mzahana

Well in my case I just rebooted the computer with sudo reboot now after installing px4 dependencies and everything works finally


Polish Xcode support for source dependencies

Context
Fixes https://github.com/gradle/gradle-native/issues/192
Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation
[x] Recognize contributor in release notes

You're still trying to change how the workspace is generated. You should instead change how the project file is generated. Otherwise the result is wrong and is working by coincidence only.
Specifically:

Filter the cpp compile configuration to remove the project components that will be included as xcode project, attach this as an input to the project generation task, to generate the header path in the xcode project file.
Filter the swift compile configuration in the same way, attach this as input to the project generation task, to generate the module search path in the xcode project file.

I think I understood what you wanted Adam. Basically, we want to ensure that Swift module and headers are present for source dependencies as they should build be able to compile without issue as opposed to the Swift module and headers from the current build where they could have failures in it which would be annoying when generating the Xcode project.
I had to add some additional modification to make the filtering work such as exposing the include path configuration for C++ and exposing the Swift module of the application so it can be consumed by XCTest as well as filtered out when adding the task dependencies.
CI is running and you can have another look at the code.


5.0.0-GA cannot collect under centos7

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ ] Question or discussion
[ √] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?

Bug

Which version of SkyWalking, OS and JRE?
SkyWalking 5.0.0-GA
CnetOS 7（vmware machine）
JRE 1.8

Which company or project?
my demo project.

What happen?
If possible, provide a way for reproducing the error. e.g. demo application, component version.
collector running, no error,but it cannot collect agent message right.

Requirement or improvement

Please describe about your requirements or improvement suggestions.

What do you mean can't collect data? What does agent log say?

I doubt there is related to os.

不会英文，有点变扭。
问题是这样：
5.0.0-GA部署在虚拟机中的CentOS7下，启动收集器、UI都没有问题；
结果无法收集到探针发来的数据；
其他因素：
同一个sky包在window7（本机）下部署是可以收集的；

collector的启动日志
skywalking-collector-server.log

If you didn't reply this in English, I have to close this issue, Apache required. We need to make sure everyone in the world understand what is happening here. You could move to QQ Group, Chinese is welcome to here. But official issue and pull request are English only. Sorry.


[Bug] Duplicate error msgs on notebooks

When I have multiple code cells in Jupyter notebooks, all the code cells, apart from the one being edited, will show the same error msg. Expect to show only in the one where the error really happens.

In this example, the error msg in the upper cell should be removed.

Should be fixed in 3.11.1.


Improve README

The README could be improved, I think:

There are links to two issues, #71 (feedback to the weather forecasting - issue is closed) and #74 (Debug Builds - the last debug build was for version 0.9 or something around this, if you don't want to package more debug builds, I would remove it from README and close the issue).
There is a feature request issue and a discussion - which one is the preferred? If it's the discussion, the link should be changed.

Thanks, I'll update it later today. As for the debug builds, I stopped generating them because I wasn't receiving any feedback (I assumed nobody was using them) - I'll change the wording to say if someone wants a debug build to test, to post there and I can create a new one.
Either is preferred, I get notified of both - though people are more familiar with GitHub issues, therefore I left that as the link in the README


Configuring a Custom SSL Policy

Please try to apply the example on this documentation.
It used to work just fine, as long as you included one of the 6 suites listed in the Important Note section.
However, ever since this feature is added to UI, you no longer can remove this suite from your list.
TLS_RSA_WITH_AES_256_CBC_SHA256
and if you try to do it with powershell.
Set-AzureRmApplicationGateway : An error occurred.
This seems to be a bug. Either this bug must be fixed or this documentation must be updated.
I have two working WAFs in two different regions. One of them I was using with a Custom SSL policy setting, including
TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256
to enable WAF communicate with the backend. Since this is the only strong cipher.
The other one was on default, since it wasn't on production yet.
However, I cannot set the same custom policy for this reason. It enforces me to include TLS_RSA_WITH_AES_256_CBC_SHA256
Otherwise I cannot change the existing SSL policy.
This caused us to lose SSL test score. We are no longer A+. Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ae11bd8c-20f5-dccc-45c6-694542e6e36b
Version Independent ID: e39f8e43-304b-b345-add9-5a7388cad580
Content: Configure SSL policy on Azure Application Gateway - PowerShell
Content Source: articles/application-gateway/application-gateway-configure-ssl-policy-powershell.md
Service: application-gateway
GitHub Login: @vhorne
Microsoft Alias: victorh

@MetehanBolat could you please share what service you are using to rate your SSL score test? If you are using SSL Labs, you can find a working configuration in #8412.

@MetehanBolat We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Fixed compilation issue

The module is referring to a non-existing file preventing the
project from building.

Not really sure what the right fix is (renaming the file to what the modulemap expects or doing what this PR does). Anyway, adding Leanplum-iOS-Location 2.0.1 via CocoaPods does not work currently (for me at least).

I just tested it, it works for me:
target 'test' do
  pod 'Leanplum-iOS-SDK', '~> 2.0.1'
  pod 'Leanplum-iOS-Location', '~> 2.0.1'
end

Can you please post your podfile?
Changing the module map to source will point to the actual source code.... So I am not sure if that's the right fix...
Are you using Obj-C or Swift? Are you using static or dynamic?

We are running Swift, dynamic frameworks. Here is our Podfile:
platform :ios, '8.0'
use_frameworks!

target 'Project' do
  pod 'Fabric'
  pod 'Crashlytics'
  pod 'AFNetworking'
  pod 'Bolts'
  pod 'FBSDKCoreKit'
  pod 'FBSDKLoginKit'
  pod 'FBSDKShareKit'
  pod 'AccountKit'
  pod 'SDWebImage'
  pod 'UIImage-Resize'
  pod 'GPUImage'
  pod 'MBProgressHUD'
  pod 'JTSImageViewController'
  pod 'TOCropViewController'
  pod 'HMSegmentedControl'
  pod 'FXPageControl'
  pod 'SlackTextViewController'
  pod 'TGPControls', :git => 'https://github.com/tradono/TGPControls.git'
  pod 'Stripe'
  pod 'Leanplum-iOS-SDK'
  pod 'Leanplum-iOS-Location'
  pod 'Firebase/Core'
  pod 'Firebase/AdMob'
  pod 'GoogleMobileAdsMediationFacebook'
  pod 'Shimmer'

  target 'ProjectTests' do
      inherit! :search_paths
  end

end

Just tried creating a new project with the same Podfile and it works so seems like it is something else in our project which is off.

(we manage versions in our Podfile.lock by the way)

What's the error you are seeing?

The error we are seeing is
Pods/Leanplum-iOS-Location/LeanplumLocation.framework/Modules/module.modulemap:2:19: Umbrella header 'Leanplum-iOS-Location-umbrella.h' not found

I have a suspicion the error is in our project somewhere. It is not a priority for us currently to upgrade Leanplum so you can just close this PR if you wish as I am not spending a lot of time trying to get to the bottom of this. Thanks for your time.

I also tested with brand new swift project, dynamic fw and cocoa pods. it works for me. please reopen if you run into this issue again...


bpf2c: emit maps in order they appear in ELF file

Description
This PR does the following:

Save the original map index while parsing the maps section.
Print the maps in the same order when emitting the C code.

Testing
Added new test in api_test.
Documentation
NA
Fixes #875

Codecov Report

Merging #883 (983e052) into main (ee0d4e3) will decrease coverage by 45.49%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main     #883       +/-   ##
===========================================
- Coverage   75.32%   29.83%   -45.50%
===========================================
  Files          83        3       -80
  Lines       14606      781    -13825
  Branches      482      488        +6
===========================================
- Hits        11002      233    -10769
+ Misses       3313      257     -3056
  Partials      291      291

Impacted Files
Coverage Δ

tools/bpf2c/bpf_code_generator.cpp
36.43% <0.00%> (-0.55%)
:arrow_down:

tests/libs/util/netsh_helper.cpp

libs/execution_context/ebpf_native.c

tests/libs/util/service_helper.h

libs/api/libbpf_object.cpp

tests/libs/util/service_helper.cpp

tests/client/main.cpp

libs/platform/ebpf_error.c

libs/platform/ebpf_pinning_table.c

libs/api_common/api_common.cpp

... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee0d4e3...983e052. Read the comment docs.

Can we modify tests\bpf2c_test_wrapper to have it generate code that uses map-in-map? Currently, we don't have coverage for the map-in-map code generation case.

Can we modify tests\bpf2c_test_wrapper to have it generate code that uses map-in-map? Currently, we don't have coverage for the map-in-map code generation case.

I can do that. I already have added map-in-map test cases in api_test.c though (bindmonitor_tailcall_native_test). Also, once the changes for #852 are in, we should be able to run all the existing unit tests for native mode also.

Can we modify tests\bpf2c_test_wrapper to have it generate code that uses map-in-map? Currently, we don't have coverage for the map-in-map code generation case.

I can do that. I already have added map-in-map test cases in api_test.c though (bindmonitor_tailcall_native_test). Also, once the changes for #852 are in, we should be able to run all the existing unit tests for native mode also.

OK, as long as it gets covered, I am not picky about how we do it.


Remove files which generated by npm run build-all

Hi, this is the first part of PR which splited from PR #152.
This PR contains:

Remove files which generated by npm run build-all (but keep folder exists)
Update gitignore
Add hint in contributing.md (build after clone)

I found those pages which generated by npm run build-all are tracked by git, those files should not be tracked, so I add it into gitignore file.
(Also, because I used PHPStorm to develop, I add .idea into .gitignore)
Vongola

Thanks so much for this! This looks good 👍 to merge to me once the inline comment is resolved.
Sorry this has taken forever, I've been taking a code break 😸

Actually, I'll just remove it and save you the small bit of trouble, you've put in a lot of work already!


Fix Models Inside of Group Not Rendering Correctly In Editor

Summary
The fix was to make sure we are initializing the entities contained in a group in an editor context.
Fixes #146

Not sure what's happening, but when generating a dungeon level, all wooden beams and doorways are missing entirely. So I think the issue is still here?
Otherwise, the behavior in #136 is fixed with this PR. But not the offset of the models.


Add Adaptive Dialog: DoWhile

See also: https://github.com/EricDahlvang/AdaptiveDoWhile

Pull Request Test Coverage Report for Build 376863583

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 55.428%

Totals

Change from base Build 376862069:
0.01%

Covered Lines:
9589

Relevant Lines:
15919

💛  - Coveralls

@EricDahlvang This is an awesome example PR to refer to!
In R12, most of the changes can be codeless by editing uischema in sdk repo. One thing remaining is

The layouter in Composer is still hardcoded. I will try to bring a solution

Thanks @yeze322
This is exciting.  :)


Some improvements

I tried to make some improvements into the code, here's the list:

Somes project informations (author, version, license...), but the version is "place the new version here", so change it.
Docstrings for each function (a documentation to the function), but i think that some is not correctly, so you can correct.
Variables names is more explicity.
Better code style.
get_square() just call get_rectangle()
The constant DEFAULT_CHARACTER that is used in each ch=DEFAULT_CHARACTER.
1 grammatical correction in README.md.
And some small changes.

The logic behind the module is same, you are free to change or remove everything.
I recommend that you test everything before.

 Thank for the pull request!


Opcode 0x44 is not correct in post-merge version

This issue is related to #219
The file context/ethereumContext.tsx implement a check to see if the app should display opcode 0x44 as DIFFICULTY or PREVRANDAO based on the selected fork.
// TODO: need to implement proper selection of doc according to selected fork (maybe similar to dynamic gas fee)
// Hack for "difficulty" -> "prevrandao" replacement for "merge" HF
if (selectedFork?.name === mergeHardforkName && toHex(op.code) == '44') {
  return {
    ...meta[prevrandaoDocName],
    ...{
      opcodeOrAddress: toHex(op.code),
      staticFee: op.fee,
      minimumFee: 0,
      name: 'PREVRANDAO',
    },
  }
}

However this only check for the merge fork, the current live fork is now shangai, so the app will wrongly use DIFFICULTY instead of PREVRANDAO.

Anyway thanks a lot for your work!
evm.codes is really awesome and I use it all the time ❤

@pldespaigne - thanks for alerting! #264 should fix this issue :)


Add a secondary content to "patch/content/secondary"

Add a secondary content (e.g. languages, skills, character, etc.).


Add schemaID type

@ponyjackal This new type looks good. Let's use this new type in the EAS protocol contextualizers now.


Bin Wrenching.

Would it be possible to add a quick deposit function for the bins like JABBA barrels?
Where when you shift + rclick with empty hand it deposits every matching item into the bin.
Also.. are the bin's supposed to be not wrenchable?

Right click twice in a row :)
I'll add a check for wrenching.

Oh right lol.

Wrenches should now function and not be inserted into bins.

To remove it right? 'Cause the configurator in wrench mode merely rotated it, even when shift wrenching.

Right.


release version 1.3.1?

It seems that version 1.3.1 was not released (and that fixes method ambiguities that are causing Aqua tests to fail in other packages, apparently).

Whoops, thanks for noticing this.  I tried registering in https://github.com/JuliaStrings/LaTeXStrings.jl/commit/6a93912e4ea27469b1d29932fb455fa14f32f160#commitcomment-131386831 but https://github.com/JuliaRegistries/General/pull/94515 needs to be merged first.

Will be closed by https://github.com/JuliaRegistries/General/pull/94573


'az aks get-credentials' failure

Hello,
running azure cli 2.0.20 on windows 10.0.16299 x64.
Issuing an az aks get-credentials -g [rgName] -n [aksName] fails with:
[Errno 13] Permission denied: 'C:\Users\EPinci\AppData\Local\Temp\tmprfizlnun'
Traceback (most recent call last):
File "C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\lib\site-packages\azure\cli\main.py", line 36, in main
cmd_result = APPLICATION.execute(args)
File "C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\lib\site-packages\azure\cli\core\application.py", line 212, in execute
result = expanded_arg.func(params)
File "C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\lib\site-packages\azure\cli\core\commands_init_.py", line 377, in call
return self.handler(*args, **kwargs)
File "C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\lib\site-packages\azure\cli\core\commands_init_.py", line 620, in execute_command
reraise(*sys.exc_info())
File "C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\lib\site-packages\six.py", line 693, in reraise
raise value
File "C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\lib\site-packages\azure\cli\core\commands_init.py", line 602, in _execute_command
result = op(client, **kwargs) if client else op(**kwargs)
File "C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\lib\site-packages\azure\cli\command_modules\acs\custom.py", line 1288, in aks_get_credentials
merge_kubernetes_configurations(path, additional_file.name)
File "C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\lib\site-packages\azure\cli\command_modules\acs\custom.py", line 829, in merge_kubernetes_configurations
with open(addition_file) as stream:
PermissionError: [Errno 13] Permission denied: 'C:\Users\EPinci\AppData\Local\Temp\tmprfizlnun'
Also tried with an elevated command prompt. I have local admin right on the workstation.
Thank you.

Thanks for reporting this. We have #4746 opened to track this issue.


Upgrade to latest django-talkback

We have a new released version and we should totally start using it!

lol


[Swift 4] Update Linked List

Checklist

[x] I've looked at the contribution guidelines.
[x] This pull request is complete and ready for review.

Description
Update Linked List to Swift 4
#507

@remlostime can you also check and put the swift 4 print checks in the test projects? I

@vincentngo Done.


Restrict workspace settings to admins

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/22013
PROPOSAL: https://github.com/Expensify/App/issues/22013#issuecomment-1615874424
Tests

From account A, create a new workspace.
Invite account B.
From account B, go the #announce room of the workspace you are invited to.
Modify the URL (as shown in the video) to /r/[reportID]/settings/who-can-post.
Verify that Not Found page is shown.
Modify the URL (as shown in the video) to /r/[reportID]/welcomeMessage
Verify that Not Found page is shown.

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

From account A, create a new workspace.
Invite account B.
From account B, go the #announce room of the workspace you are invited to.
Modify the URL (as shown in the video) to /r/[reportID]/settings/who-can-post.
Verify that Not Found page is shown.
Modify the URL (as shown in the video) to /r/[reportID]/welcomeMessage
Verify that Not Found page is shown.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/77237602/960e7d75-a6f1-4ba5-a8b5-7073cc0d8cd6

Mobile Web - Chrome
https://github.com/Expensify/App/assets/77237602/08258ad5-a4ec-4451-86e2-282acaca3eac

Mobile Web - Safari

https://github.com/Expensify/App/assets/77237602/20e2aa5f-c3f5-4129-aa79-cb6e2935c1b8

Desktop

iOS

Android

@mollfpr Here are answers to potential concerns you might have:

Why didn't we use withPolicy HOC
Because withPolicy gets the policyID from route and we need it from report.policyID.

Why did we remove _.isEmpty(props.report) from ReportWelcomeMessagePage.js
Because it is already wrapped with the HOC withReportOrNotFound which performs the same.

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@mollfpr Applied all the suggested changes... Hope it looks good now 😇

Okay @mollfpr,  Adding the videos now..

We have 2 cases for the welcome message page and 3 for the who can post page.
✅ The page will open
❌ The not found page will be open
Welcome message page:

Open the page as an admin ✅
Open the page as not an admin ❌

Who can post a page

Open the page from the #admin room ❌
Open the page from the #announce room as an admin ✅
Open the page from the #announce room as not an admin ❌

We should add all the cases to the test step.
Here's an example of what I prepare for testing on native.

@mollfpr I have edited the test steps. Please confirm they are as expected and I'll attach all the videos tomorrow morning as soon as possible. (Got a lot of testing to do 6 devices x 5 tests 😅).

@esh-g No worries!
I think we can change how to test this; instead of modifying the URL, we can just prepare a chat that has all the links for each test case. But let's take that for tomorrow.

@mollfpr I have updated the tests and the test videos. I hope they are up to the mark but please feel free to point out any suggestions you have! 😇

bump @grgia

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.42-0 🚀

platform
result

🤖 android 🤖
cancelled 🔪

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
cancelled 🔪

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.42-26 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Expose the Spinnaker UI via LoadBalancer

Is there a way to get the spinnaker chart to expose the UI (deck) via a LoadBalancer instead of ClusterIP?

Yes but currently no auth is implemented so you would be opening up your cluster to the world. Once auth (fiat) is baked in sensibly I think making that configurable makes sense.

Oh, I wasn't aware that auth hadn't been integrated yet. I don't see another ticket for that, so I just added one.
What's the timeframe for implementing these changes? We'd love to be able to use the Spinnaker chart for out Spinnaker install, but in its current state - forcing users to setup port forwarding and use the local proxy every time they want to use Spinnaker is a nonstarter.

More info on implementing auth is available here:
http://www.spinnaker.io/docs/securing-spinnaker
Once it is out of alpha we can implement the changes in the chart.

Closing per Vic's comments.


[BUG] Link checker didn't detect the broken link for files in github repository

I found some broken links in UPGRADING.md, they pointed to files in another github repository, whose locations have changed.

https://github.com/opensearch-project/documentation-website/blob/main/docs/alerting/settings.md
https://github.com/opensearch-project/documentation-website/blob/main/docs/ad/api.md

Seeing from the results of link checker runs, there is no error to show the broken links:
https://github.com/opensearch-project/opensearch-plugins/actions/workflows/links.yml
I could create PR to change the above broken links to github permalink.

I fixed the links in #100 but am wondering why the link-checker missed those bad links. I will try and figure it out.

I fixed the links in #100 but am wondering why the link-checker missed those bad links. I will try and figure it out.

Hi Miki, thank you for fixing the links. I noticed the broken links for files in Github repo return the status 200, but not 4xx, but I didn't investigate further.

I'll close this. Since the host returns 200s link checker doesn't think they are broken.