Add user to Ortto when they make a profile

When a user fills out their profile for the first time (with an email at least) we should save them in Ortto - using the same API call in #1290 - https://help.ortto.com/a-224-creating-and-updating-people - but with different information. We'll only need:

Email
userId (str:cm:user-id)
First Name
Last Name

Similarly - when a user updates their profile we should run the same process to catch any new changes and update their profile.

When I update my account a new record will be added, is this expected result ?

On staging it's expected because it will find user on Ortto based on email address and if it fails to find one, it will create a new user.
@maryjaf On staging we merge users from impact-graph to Ortto based on email address and on production based on user-id

Thanks @RamRamez by considering this, the test has been passed


Remove IngestProperties in favour of InstanceProperties + TableProperties

With the changes in #336, we wont need the IngestProperties class anymore. We can consider refactoring and removing the class as the IngestCoordinatorFactory creates an IngestCoordinator using InstanceProperties and TableProperties.

This is intended to move us towards issue https://github.com/gchq/sleeper/issues/370 (simplify flow of control for ingest).


[Bug] Complicated type hint involving type parameter mistakenly cached

In the following code:
from beartype import beartype

class A:
    pass
class B(A):
    pass
class C:
    pass
class D(C):
    pass

@beartype
def f[T: A, U: A](x: tuple[T, U]) -> tuple[T, U]:
    return x

@beartype
def g[T: C, U: C](x: tuple[T, U]) -> tuple[T, U]:
    return x

b = B()
d = D()
print(f((b, b)))
print(g((d, d)))

The final line gives a BeartypeCallHintParamViolation:
File <@beartype(__main__.g) at 0x24837e78f40>:40, in g(__beartype_object_2509142458400, __beartype_get_violation, __beartype_conf, __beartype_check_meta, __beartype_func, *args, **kwargs)

BeartypeCallHintParamViolation: Function __main__.g() parameter x=(<__main__.D object at 0x0000024837D8C2C0>, <__main__.D object at 0x0000024837D8C2C0>) violates type hint tuple[T, U], as tuple index 0 item <class "__main__.D"> <__main__.D object at 0x0000024837D8C2C0> not instance of <class "__main__.A">.

Beartype seems to think that T and U are still bound to A, as in the definition of f.
Internally, this is because beartype._check.convert.convcoerce.coerce_hint_any wants to use a cached version of the type hint tuple[T, U], which is indexed by its repr "tuple[T, U]" (as a string), and mistakenly accessed the one cached in the previous function f.

Wow. That's... brutal. You're right about everything, beautiful unicorn @EtaoinWu. I'm loathe to implement the obvious fix, because the obvious fix requires @beartype to stop deduplicating type hints. Deduplication non-negligibly reduces space and time consumption across the lifetime of the average app. Deduplication is good. Stopping deduplication is bad. But crunchy bugs like this are even worse than bad!
Sadly, I don't see any other fix. The underlying issue here is that type variables have ambiguous representations. Clearly, the type variable T: A is not the type variable T: C. Yet both share the ambiguous repr(T: A) == repr(T: C) == 'T'. Pretty sucky, honestly. I sigh. Oh, well. Let's stop deduplicating type hints, I guess. :face_exhaling:
QA: the eternal tragedy.

Update: figured it out. I get it. We only need to stop deduplicating type hints for the proper subset of type hints parametrized by one or more type variables and thus satisfying the constraint:
bool(get_hint_pep_typevars(hint))

Phew. Fear not, everybody. @beartype 0.19.1 will still be deduplicating your life for you. :sweat_smile:

Resolved by 74f9da8f0e1187e. Thanks so much for the incredibly concise minimal working example (MWE). Thanks to that, we solved this in a jiffy. @beartype @leycec Productions™ super-appreciates how awesome you are, @EtaoinWu. :heart_eyes_cat:


Make BigQueryCreateEmptyTableOperator idempotent

@TobKed are you working on retrofitting BQ operators?

Closed via https://github.com/apache/airflow/pull/6470


[web]: device chrome is not available in channel stable (v.1.17.0)

When switching to Channel stable, v1.17.0, there is no chrome device.
A terminal log says more than 1000 words ;)

flutter channel beta
Switching to flutter channel 'beta'...
git: From https://github.com/flutter/flutter
git:    8fbfe1cfb..a849daf28  dev                  -> origin/dev
git:  * [new branch]          flutter-1.19-candidate.0 -> origin/flutter-1.19-candidate.0
git:    7bce4d9fd..f5d2c8c77  master               -> origin/master
git:  * [new branch]          timsneath-api-readme -> origin/timsneath-api-readme
git:  * [new tag]             1.19.0-0.0.pre       -> 1.19.0-0.0.pre
git: Switched to branch 'beta'
git: Your branch is behind 'origin/beta' by 3 commits, and can be fast-forwarded.
git:   (use "git pull" to update your local branch)
Successfully switched to flutter channel 'beta'.
To ensure that you're on the latest build from this channel, run 'flutter upgrade'
flutter devices
4 connected devices:

Android SDK built for x86 • emulator-5554                        • android-x86    • Android 10 (API 29) (emulator)
iPhone 11 Pro             • 2EC07DCE-7642-4225-98D9-79F561F8C512 • ios            •
com.apple.CoreSimulator.SimRuntime.iOS-13-4 (simulator)
Chrome                    • chrome                               • web-javascript • Google Chrome 81.0.4044.138
Web Server                • web-server                           • web-javascript • Flutter Tools

flutter channel stable
Switching to flutter channel 'stable'...
git: Switched to branch 'stable'
git: Your branch is up to date with 'origin/stable'.
Successfully switched to flutter channel 'stable'.
To ensure that you're on the latest build from this channel, run 'flutter upgrade'
flutter devices
Downloading Dart SDK from Flutter engine 540786dd51f112885a89792d678296b95e6622e5...
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100  213M  100  213M    0     0  15.3M      0  0:00:13  0:00:13 --:--:-- 15.1M
Building flutter tool...
Downloading package sky_engine...                                   0.4s
Downloading flutter_patched_sdk tools...                            0.9s
Downloading flutter_patched_sdk_product tools...                    0.9s
Downloading darwin-x64 tools...                                     2.3s
Downloading darwin-x64/font-subset tools...                         0.4s
2 connected devices:

Android SDK built for x86 • emulator-5554                        • android-x86 • Android 10 (API 29) (emulator)
iPhone 11 Pro             • 2EC07DCE-7642-4225-98D9-79F561F8C512 • ios         •
com.apple.CoreSimulator.SimRuntime.iOS-13-4 (simulator)

flutter config --enable-web
Setting "enable-web" value to "true".

You may need to restart any open editors for them to read new settings.

flutter devices
2 connected devices:

Android SDK built for x86 • emulator-5554                        • android-x86 • Android 10 (API 29) (emulator)
iPhone 11 Pro             • 2EC07DCE-7642-4225-98D9-79F561F8C512 • ios         •
com.apple.CoreSimulator.SimRuntime.iOS-13-4 (simulator)

flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, v1.17.0, on Mac OS X 10.15.4 19E287, locale en-CH)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 11.4.1)
[✓] Android Studio (version 3.6)
[✓] IntelliJ IDEA Community Edition (version 2018.3)
[✓] VS Code (version 1.45.0)
[✓] Connected device (2 available)
• No issues found!

It's beta. Just use this commands:
$flutter channel beta
$flutter upgrade
$flutter create .
$flutter run -d chrome

Please read https://flutter.dev/web , web is not available on the stable release channel


Inconsistent Samplesheet Column Names

Describe the bug
The samplesheet for the Freyja entrypoint of Aquascope has a subset of the columns in the original samplesheet but the column names have been changed.
SNAME = sample
BAMFILE = bam_file
Impact
This is making it difficult to automate samplesheet generation.
Expected behavior
Columns containing the same information should have the same names across samplesheet with a consistent case, and consistent use of underscore etc.

completed with 2a511d6b013aa67262363669169d33e3c5abd5d1


Add WithNoOverrideEmptyStructValues

Add option to not overwrite empty fields in destination structs if the
structs are not empty.

I'm not positive that this needs a new option.  If it does, perhaps it should be generalized to more than structs or to depths other than zero.
Please take a look at the tests.  Thoughts?

@cwarden Sorry it took so long. The tests look fine, but I'm not sure if this PR can introduce unknown side effects. It looks you have been using your fork for a year. Did you find anything wrong during this time?

Hi @imdario.  This change has been working well for me in https://github.com/ForceCLI/force-md.


#2769 Initial experience when i have local R's is bad

Where there is no last used connection, try automatically pick local R if available

👍


Update changelog for 1.36.1 hotfix

Update changelog for 1.36.1 hotfix release.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 42.198%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
27753

Relevant Lines:
61529

💛  - Coveralls


[Feature] Add BSD Binary

Feature: Add Binaries for BSDs like OpenBSD, LibertyBSD, and FreeBSD / TrueOS.

Do these OSes support flatpaks? On our readme, we have a community controlled section which links to the flatpak: https://flathub.org/apps/details/io.lbry.lbry-app
I don't see us taking this on anytime soon as the Linux userbase is one of our smallest, and BSD oses make up even a tinier portion than that.

Do these OSes support flatpaks? On our readme, we have a community controlled section which links to the flatpak: https://flathub.org/apps/details/io.lbry.lbry-app
I don't see us taking this on anytime soon as the Linux userbase is one of our smallest, and BSD oses make up even a tinier portion than that.

https://github.com/flatpak/flatpak/issues/1985

It's native binary, but it's something.
You can run LBRY-Desktop on

Linuxulator (https://forums.freebsd.org/threads/missing-shared-library-libffmpeg-so-while-running-electron-app-lbry-desktop-on-linuxulator.81987/#post-531578)
Wine-Proton (https://forums.freebsd.org/threads/missing-shared-library-libffmpeg-so-while-running-electron-app-lbry-desktop-on-linuxulator.81987/#post-531472)

From
https://forums.freebsd.org/threads/missing-shared-library-libffmpeg-so-while-running-electron-app-lbry-desktop-on-linuxulator.81987/#post-531578


url target

fix #399

What about the help card?

What about the help card?

Oh... that's painful. Are we keeping these names (target and resource)?

I like the names. I can update the help card. Let me grab this branch and throw a commit on it

HelpCard https://github.com/vinniefalco/url/commit/1d2406cdbd594cb56e37dc9eb9b8d24a9decf342

squash it and merge it when you think its ready


Add optional currency for create recurring payment

Resolves #41

Is the test in Go 1.11 flaky ? @stanleynguyen

Is the test in Go 1.11 flaky ? @stanleynguyen

Yes. I will fix it some time next week


update libraries2

Rebuilt #100 on the latest master branch.

:tada: This PR is included in version 5.0.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Usage with react

I'm trying to follow your /Getting-Started.
When attempting to extend CircularNodeView, the render method has return type VNode. I can see you are using snabbdom-jsx here. However, this module uses global typings which conflict with @types/react -- which I am using for other parts of the app.
How am I to proceed?
Many thanks for any help.

It looks like these brand new TS features could help:
https://blogs.msdn.microsoft.com/typescript/2018/03/27/announcing-typescript-2-8/#jsx-pragma-comments
https://blogs.msdn.microsoft.com/typescript/2018/03/27/announcing-typescript-2-8/#jsx-namespace-resolution
PRs are welcome.

Fixed with https://github.com/theia-ide/sprotty/commit/b64aaf041823b3da55c97b1f47dc8e5ba199dd04
As Theia now uses React as well, I had to take action.

I migrated the sprotty code to use local JSX factories instead.
With regard to the global types, the strategy is separate React JSX and snabbdom-jsx usages in distinct packages. The solution is implemented in yangster

In the snabbdom dependent package I avoid importing the global React typings by adding an empty types property in the tsconfig.json. See https://github.com/Microsoft/TypeScript/issues/17042 for some more information.
For the React dependent package, no action was needed as it is an upstream dependency.

Two more things:

Instead of "types": [] you could also specify "skipLibCheck": true in tsconfig.json. The downside of not checking this is that tsc will no longer check the manually defined *.d.ts files in the package.
You can actually use React and sprotty in the same package, but it has to be separate modules.


5x sample CO2

ericklein/air_quality#73

#define variable created to control sample count. This code is in /dev awaiting testing and integration.


Cleanup some of the testing issues.

Some test related improvements and cleanup.

Yeah, not sure what might happen longer term, but a follow up PR uses it for now. It's a simple Java app to do easy pass / fail checks against a Solr cluster for the cluster.sh script since it's a pain to do well/easily via scripting.


Parameter parsing/passing: The CLI's -File parameter doesn't support negative numbers as positional arguments

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
Note: This is related to various other, similar bugs: https://github.com/PowerShell/PowerShell/issues?q=is%3Aissue+is%3Aopen+"parameter+parsing%2Fpassing"
When using pwsh -File trying to pass a positional argument that is a negative number fails, because the - is apparently invariably interpreted as starting a parameter name:
# Create sample script t.ps1
@'
[CmdletBinding()] param([int] $p) "-p value: $p"
'@ > t.ps1

pwsh -NoProfile -File t.ps1 -1     # !! BREAKS: *positional* argument
pwsh -NoProfile -File t.ps1 -p -1  # OK, as *named* argument.
./t.ps1 -1                         # OK, positional argument with *direct invocation*.

Note that quoting -1 does not help.
Expected behavior
-p value: -1
-p value: -1
-p value: -1

Actual behavior
t.ps1: A parameter cannot be found that matches parameter name '1'.
-p value: -1
-p value: -1

Error details
No response
Environment data
PowerShell Core v7.3.0-preview.4

Visuals
No response

Windows 11 + PS7.2.4 - no errors
does this work as a workaround?
pwsh -NoProfile -File t.ps1 (-1)

That's surprising, because the error is related to PowerShell's parameter parsing, which isn't OS-specific. I don't have Windows 11, but I see the error in  WinPS, 7.2.4, and  v7.3.0-preview.4, both on Windows 10 and macOS 12.4.
Your attempted workaround is syntactically only an option from inside PowerShell, where there's rarely a need to call the CLI (if you needed to, you would use pwsh -NoProfile { ./t.ps1 -1 }, which avoids the problem); even there, however, it isn't effective, because the (1) gets translated to a string with value 1, given that a call to an external program is being made.

Tested it on another Windows 11 box - no errors.
tested on Windows Server 2016 - no errors.

@scriptingstudio, just to narrow things down and rule out that you're not accidentally testing something different from the repro in the OP:
In a shell started with  powershell.exe -NoProfile, i.e., Windows PowerShell, I see the error too - do you not?
(The specific WinPS version is v5.1.19041.1682, though the specific version is unlikely to matter, given that Windows PowerShell is unlikely to have received a fix.)
I see the error on Windows 10, macOS 12.4, and Ubuntu 18.04 - again suggesting that the OS is incidental.

Hello , i   am Pablo and working was good for regular and fix. I want the bot again!, Hope we do It again. Good Luck ALL the best

@mklement0  I got it, could repro. I think it is pwsh/powershell parameter binder problem (or something like that). It considers an argument with - as a parameter

Unfortunately, it appears to be by design based on this code https://github.com/PowerShell/PowerShell/blob/master/src/Microsoft.PowerShell.ConsoleHost/host/msh/CommandLineParameterParser.cs#L1352-L1383.  It's doing a simple parameter binding which is a subset of the actual PS parameter binder.
I'd be worried what scenarios would break if we try to change this.

@SteveL-MSFT, calling an implementation shortcut that is inconsistent with how parameter names are normally parsed by design  strikes me as overly generous (unavoidable differences between -File-based and in-session / -Command notwithstanding).
As for what could break if something like -1 were no longer considered a parameter name but a positional argument (which is how it's interpreted in-session):

Note that in-session / with -Command, a script's parameter that looks like a negative number, such as -1 ($1) cannot be bound by a named argument.

That is, such a parameter can only be bound positionally, except via splatting - an inconsistency in its own right; see #17767

# !! BREAKS: "-1" is interpreted as a positional argument:
# !!   -> A positional parameter cannot be found that accepts argument 'foo'
 & { [CmdletBinding()] param([string]$1) "[$1]" } -1 foo

However, because of the bug at hand, this does work - but arguably shouldn't - when called via the CLI's -File parameter.

'[CmdletBinding()] param([string]$1) "[$1]"' > t.ps1

# -> 'really?'
pwsh -nop -file t.ps1 -1 really?

In other words: the following code could break:

calls to scripts declared with ill-advised parameter names such as -1 (parameter variable $1)
if they are called with a named argument binding such a parameter but only ever via the CLI's -File parameter, given that this otherwise doesn't work.

Perhaps needless to say, the existence of such scripts / calls seems very unlikely.
Conversely, not being able to pass a negative number via -File is an unnecessary restriction, especially given that the functionality that implicitly prevents it shouldn't exist to begin with: if -1 foo doesn't work in a PowerShell session, neither should it via -File


enable use of transform_graph tool with contrib/rnn

This is a simple fix for using contrib/rnn with the transform_graph (and possibly other tools).
In particular, it fixes the following error:
2017-08-24 16:07:41.015752: E tensorflow/tools/graph_transforms/transform_graph.cc:210] Op type not registered 'BlockLSTM' in binary running on ip-172-31-30-181. Make sure the Op and Kernel are registered in the binary running in this process.

It's also possibly a remedy for issue #11847.

Can one of the admins verify this patch?

Please address the CLA before we look at the change. Thanks!

@pks, unfortunately, it doesn't solve a ValueError: No op named BlockLSTM in defined operations. problem mentioned in the issue. But from tensorflow.contrib.rnn import * does. Thank you!

@dkurt the proposed fix here fixes the transform_graph tool, not freeze_graph.py -- but glad that the import works :-)

I signed it!

That works as well. Thanks!

Jenkins, test this please.
@petewarden any opinion on this PR?

@petewarden ping?

MacOS failure is unrelated.


Configured Coveralls

:thumbsup: whenever travis responds

Changes Unknown when pulling e5672dd49fe60ea739129038e065c8eb4e59ff63 on coveralls-setup into ** on master**.

Changes Unknown when pulling 06d2b9cb8cc31d714786c9d4f93545c76eb79fde on coveralls-setup into ** on master**.


Scatter images cover others with the same data point

Is your feature request related to a problem? Please describe.
I have a multiple series chart. The series are line and scatter charts. When the two points of my scatter charts have the same value (either from the same series or from two different ones) one will cover the other. I can't see that there are multiple data points and I can't click on them for further information in the tooltip. When the data points aren't exactly the same but almost, they are too close to eachother so that I again can't click on every data point for more information in the tooltip.
Describe the solution you'd like
I would like that the scatter chart won't draw the markers of the data points at the exact same place as another marker already is. And I would also like that I can click on every scatter data point even if they are pretty close to each other.
Describe alternatives you've considered
At the moment I am writing the description of my data point in the tooltip. When there are two scatter images at the same place, I am writing both descriptions in the same tooltip. But I would like to change that because I would like to have another scatter image for the different kinds of data points.

The overlap is inevitable as moving the data-points to avoid overlaps would represent the wrong data.
You should set the opacity of the markers so that when two markers of different series overlap, it becomes more prominent due to the difference.
Are you not able to click on the markers when they are close to each other? Are you using a shared tooltip?

Ok, thank you. I will try it with the opacity.
I have three line charts and three scatter charts in one diagram and they all have different values on the x-axis. I figured, I couldn't use shared tooltip.
The following image shows a small part from my diagram. I can't find out how I can click on the scatter data point with the red image. Wherever I click, it opens the tooltip for the yellow blizzard or the green line chart.

I just found something that doesn't work either. If I have 4 scatters on the same date. 2 of them also have the same y-axis value and are overlapping each other. Then I can only see the tooltip of one of those data points. I have a picture attached. If I click on any of those data points I can only happen to see the tooltip of one of the scatter images in the middle. I can't see the tooltip for the one on top, neither for the one on the bottom and neither for the other one that's also in the middle.

Any chance you got to look at my issue?
In my multiple series chart I can't open the tooltip of a lot of data points from all the series...

did you find any solution or trick for this? We also have hidden markers in the chart. Is there any way we could show a different marker so the user knows there are more and she can zoom?


[fix](schema change) fix bug of query failure after rename column

Proposed changes
Fix the following issue
CREATE TABLE IF NOT EXISTS t1 (
                k1 INT NOT NULL,
                value1 varchar(16) NOT NULL,
                value2 int NOT NULL
)
DUPLICATE KEY (k1)
DISTRIBUTED BY HASH(k1) BUCKETS 1 properties("replication_num" = "1");

select * from t1

ALTER TABLE t1 RENAME COLUMN value2 new_col

select * from t1 where new_col = xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall

lgtm


Register Data Sources

Description
Right now, only global scope dataframes are saved by marimo for reference. However, I'd love to be able to have them saved to marimo without explicitly defining it as a variable
For example, when I run a Langchain agent, it fetches data and streams dataframes and text to the cell output:

I'd like to register these data frames to the global scope so that:

Data an agent has fetched already is summarized in the Explore data sources panel
Fetched data can be referenced in future AI cells

In my case, I'd like to be able to programmatically generate the variable symbol name.
Suggested solution
def run_agent(input):
   for event in agent.run(input):
      # if is tabular
      df = pd.DataFrame(event.content)
      mo.editor. register_datasource(df, event.name + event.tool_args + "_df") # <--- saves df to var "nearest_gene_tool_chr15_88569444_df"
      mo.output.append(df)
      ...
    ...

Alternative
No response
Additional context
No response

Thinking out loud - I wonder if this should be explicit like mo.editor.register_datasource, or just "happen" when outputing an unnamed (no variable) dataframe.
Right now we auto-discover dataframes/datasources:

Variables declared
In SQL for CREATE TABLE
In SQL for ATTACH db

I think just happening could be cool also for sure, but for the purpose of referencing in later data frames, especially if a user has multiple data tables with the same schema (the result of fetching data from the same api multiple times with diff params), then that could get confusing, so I'd still like the option to be able to assign a meaningful name ideally!

Hi! created a draft PR for what the mo.editor.register_datasource method could look like.
I'm not sure if it's adding the variable in the proper way though.
I initially considered using an AST method like visit_Call is already used for the SQL tables, but this prevents dynamic variable name registration, such as mo.editor.register_datasource(df, construct_varname(api_call, api_call_params))
A specific example I tested with was:
my_module.py:
  import marimo as mo
  import pandas as pd

def register_dfs_in_background():
    df = pd.DataFrame({'a': [1], 'b': [2]})
    x = 'myvarname'
    mo.editor.register_datasource(df, x)

marimo_notebook.py:
import marimo

__generated_with = "0.9.14"
app = marimo.App()

@app.cell
def __():
    import my_module
    return (my_module,)

@app.cell
def __(my_module):
    my_module.register_dfs_in_background()
    return

if __name__ == "__main__":
    app.run()

I did not attempt to register "outputted" dataframes yet, because I'd like to understand how you would want variable naming to look for that first

Hi @riyavsinha - I'll take a look at the PR. I dont think we want to support dynamic variable registration - this can lead to bugs and confusing behavior. And i dont know if register_df should hook into the reactivity at all.
I did think of a better solution you mentioned SQL. (Sorry on a phone) you can potentially create the df as a local variable and do mo.sql("""create or replace table_name from df_name"""). This will store the df in memory via duckdb which will give you the data sources features you are looking for.

Yeah that makes sense. I can make do with the workaround


Meson dependencies check won't pick list items

https://github.com/openbmc/openbmc-build-scripts/blob/d2176ef9704d968858f031e89ace9d1b876d3bf5/scripts/unit-test.py#L758
The patten fails to match dependencies declared in a list, for example,
some_deps = [
  dependency('lib1'),
  dependency('lib2'),
]

r"dependency\('([^']*)'.*?\),?\n"  should fix the problem.

Please refer to this commit.


Flickering after view animates - e.g. from dashboard to games list (and back)

Can be seen especially on iOS simulator and device.

Still not clear, why this is happening.

Is this still happening with BoardZ 2?

This seems to be "gone".


add DoubleDispatchObject

This is awesome! Thanks for submitting it, and I'll be very interested in seeing the results. I'll review it this weekend. Thanks again!

Sure, thank you Will.
Cyril
On Fri, Apr 19, 2019, 7:11 AM Will Fuqua<EMAIL_ADDRESS>wrote:

This is awesome! Thanks for submitting it, and I'll be very interested in
seeing the results. I'll review it this weekend. Thanks again!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/waf/MultipleDispatchBenchmarks/pull/1#issuecomment-484854984,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIBUUTSREITTBI7ZMQKMR3PRGSE7ANCNFSM4HHA7VIQ
.

@waf I'm curious too, to see the figures you get on whatever box you happen to run; here, on my snail cheap laptop, it looks like I consistently get runtime perf in the same ballpark as with the dynamic keyword, for shape sample set sizes of 1000, 10000, 100000, and up...
I wasn't expecting it to be faster than your boilerplate dictionary dispatch pattern anyway (since my impl itself uses dicos internally plus extra overhead).
Keep me posted and thank you for this neat little benchmark repo again.
CJ

Thanks for your work on this! It's a very cool approach. I've run the benchmarks on a desktop machine, and included the results below. It's a little bit slower than the Dynamic Dispatch, but not much (less than 2x).

I was interested in investigating in the smallest boilerplate code as
possible to support it, and the least intrusive also (inheritance is
optional, simple composition pattern thanks to the EnsureThreadSafe helper
being the preferred).
Here are the few limitations by design &/or implementation I can think of
and that I haven't documented yet:
no support for static methods (not that it would make much sense anyway)
currently works on closed types signatures only (one can't leave generic
parameters open at class or method level and rely on double dispatch on
those) - doesn't mean one cannot use generic classes or methods, but those
must be closed somehow, eg, MyMethod(string input) if we want the
double dispatch to be honored
haven't tested the contra / covariance compatibility rules on parameters
that are delegate types (that may or may not work, dunno yet)
My only remaining foreseeable item is to generalize it up to 2 or 3
parameters after "this", if that doesn't degrade the perf too much.
Multiple dispatch use cases beyond "this" + 3 parameters are rare,
reportedly.
Thanks again,
Cyril
On Wed, Apr 24, 2019, 1:26 AM Will Fuqua<EMAIL_ADDRESS>wrote:

Thanks for your work on this! It's a very cool approach. I've run the
benchmarks on a desktop machine, and included the results below. It's a
little bit slower than the Dynamic Dispatch, but not much (less than 2x).

Reply to this email directly, view it on GitHub
https://github.com/waf/MultipleDispatchBenchmarks/pull/1#issuecomment-486073080,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIBUUW7GCAID4NRCZ3G5WDPR7VP7ANCNFSM4HHA7VIQ
.

@waf On this:

"Haven't tested the contra / covariance compatibility rules on parameters that are delegate types (that may or may not work, dunno yet)"

eventually did last night (and good news, it works) but couldn't get the time to prepare a worthy commit..
Will do soon, with added corresponding unit tests.
I'm also considering at least one possibly meaningful use case to support static methods in combination with surrogates, or if only those bound to functions :
eg, sth along the lines of,
var absoluteValue = default(object).CreateSurrogate(name of(Math.Abs), default(object), default(object));
var a1 = (int)absoluteValue(-123); // valid cast, as it returns 123 (System.Int32)
var a2 = (decimal)absoluteValue(-499.99m); // valid cast, as it returns 499.99m (System.Decimal)
overloaded static functions of that sort are quite frequent in some APIs / frameworks / libraries.


Module 'Firebase' has no member named 'Analytics' in 10.3.0

Description
Module 'Firebase' has no member named 'Analytics'
implementation
Firebase.Analytics.setAnalyticsCollectionEnabled(true)
Reproducing the issue
No response
Firebase SDK Version
10.3.0
Xcode Version
14.2
Installation Method
CocoaPods
Firebase Product(s)
AB Testing, Analytics, Authentication, Crashlytics, DynamicLinks, In-App Messaging
Targeted Platforms
iOS
Relevant Log Output
No response
If using Swift Package Manager, the project's Package.resolved

Expand Package.resolved snippet

Replace this line with the contents of your Package.resolved.

If using CocoaPods, the project's Podfile.lock

Expand Podfile.lock snippet

Replace this line with the contents of your Podfile.lock!

Got resolved by removing Firebase in front of Firebase.Analytics.setAnalyticsCollectionEnabled(true)
But where is the related doc ?

Hi @varindersingh-dewsolutions-MarTech, good to hear that the issue has been resolved. Per checking, Analytics.setAnalyticsCollectionEnabled(true) is indicated on our docs. I'll now be closing this ticket, but feel free to comment if you have any other questions.


Generate FieldValidationInstrumentation

graphql-java has recently implemented field level validation that is tested after the query is parsed, but before it is executed. https://github.com/graphql-java/graphql-java/issues/162
It would be really handy if this could be automatically generated using javax.validation annotations!
I'm only just starting my own implementation so I haven't thought it through fully, but I can see it working as follows:

In the method that generates a GraphQLSchema, also generate a FieldValidationInstrumentation
This generate would, for each GraphQL query or mutation, check the arguments
For each argument and fields of each argument get any javax.validation annotations
Create a rule for each annotation. Add each rule to a SimpleFieldValidation
The programmer could then add the FieldValidationInstrumentation to the GraphQL builder GraphQL.newGraphQL(...).instrumentation(instrumentation).build()

It would also be nice to have a custom org.springframework.validation.Validator bean that could check business logic (e.g. the email already exists in the database) but I haven't thought about how that could be implemented yet.
There's an example of the graphql-java validation in the method fieldValidation(), Line 161, shows an example.
https://github.com/graphql-java/graphql-java/blob/2f8f3de1d722ec0128b960c5e565405057fa76ff/src/test/groovy/readme/InstrumentationExamples.java#L161

+1 for this enhancement :)

+1 for this enhancement :)

@EdgarArguelles While this is something I'm still planning to look into, I think it's much less needed now than at the time this issue was opened. The reason is that these days it should be rather easy to use ResolverInterceptor to achieve the same result. Of course, it has always been possible to utilize the capabilities of the underlying framework (e.g. Spring, Guice etc) as most of them provide Bean Validation integration.

Hey there!
I am using spqr in a spring-boot environment. For authentication I need to read a JWT token from every incoming request. I found out how to do for a single method it with the @GraphQLRootContext  annotation, but I want to do it on a global level. To my understanding this can be done with a ResolverInterceptor, but I don't know how to register it with spring.
Can anyone help me?

@Matthias-Walter-Innio I'd whole-heartedly suggest you use existing Spring features for handling security, as it already has everything you need to process JWT. Since SPQR will invoke Spring-managed beans, all Spring features will work normally.
If that's for some reason not an option, yes, ResolverInterceptor is the way to go, as it can intercept any resolver invocation and inspect the root context.
To register any extension in Spring, simply register a bean such as:
//E is any extension type, such as TypeMapper ResolverInterceptorFactory, or anything else
public ExtensionProvider<GeneratorConfiguration, E> customExtensions() {
    return (config, extensions) -> extensions.append/drop/insert(...); //modify the current list as you please
}

For your case, you want a ResolverInterceptor that is applicable globally (to all resolvers), so you can use GlobalResolverInterceptorFactory:
public ExtensionProvider<GeneratorConfiguration, ResolverInterceptorFactory> customInterceptors() {
    return (config, current) -> current.append(new GlobalResolverInterceptorFactory(customGlobalInterceptors);
}

If you want to react to e.g. an annotation (so that only annotated methods are intercepted), you can provide a custom ResolverInterceptorFactory.

Thanks a lot, I will try out!

@Matthias-Walter-Innio Answered your SO question as well.

Sorry if this is an old thread...I'm using JavaX validation constraints in my Spring app, how should I get SPQR to pick these up? Currently I have the below Object and am trying to validate this in my Graph query:
public class Example {
    @NotBlank
    @Pattern(regexp = ".{3,}")
    private String query;
}

  @GraphQLQuery(name = "exampleSearch")
  public List<String> searchList(@GraphQLArgument(name = "query") @RequestBody @Valid Example query) {
    return searchService.exampleSearch(query);
  }


Add at the speed of paul [doom] by dimrain47

Song Name
at the speed of paul [doom]
Artist Name
dimrain47
Source
Youtube
Youtube Link
Y4tPnqWND1I
Direct File Link
No response
Song ID
467339
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 38601659

reject
what is this


fees get paid even opening tx for swap fails

I just created a swap with strike and got an error message from their side:
2024/10/28 20:25:21 [INFO] [Swap:8b981107d39e60899a93ee06b99ad32a327a38e557949a892bc15860c8d95bae] Start new swap-out: peer: 03c8e5f583585cac1de2b7503a6ccd3c12ba477cfd139cd4905be504c2f48e86bd chanId: 836614:>
2024/10/28 20:25:24 [INFO] [Swap:8b981107d39e60899a93ee06b99ad32a327a38e557949a892bc15860c8d95bae] Paid Feeinvoice of 300 sats
2024/10/28 20:25:24 [INFO] [Swap:8b981107d39e60899a93ee06b99ad32a327a38e557949a892bc15860c8d95bae] Swap canceled. Reason: -13:Error: Please enter the wallet passphrase with walletpassphrase first.
2024/10/28 20:25:24 [INFO] [Swap:8b981107d39e60899a93ee06b99ad32a327a38e557949a892bc15860c8d95bae] Warning: Paid swap-out prepayment, but swap canceled before receiving opening transaction

this already happend in the past but I didnt realize it that time, now I see theres defintiv a bug, or a missbevavior as ps shouldnt pay fees if the swap might fail.
PS probably needs a pre-check to validate that the swap would work.
maybe @Impa10r and @zapomatic can explain it better, because they also experience this bug already.

confirmed, same error from Zap-O-Matic initiating a LN -> LBTC swap with Strike. It looks like their LBTC wallet is locked, but we only know about it after sending the 300 sats. Would expect either the pre-payment is conducted after an initial check with the node to ensure their wallet is ready, or that the fee is bounced back after the failure.

Thank you for reporting the issue.
Based on your suggestion, I think it is appropriate to check in advance when receiving a swap out request.
A GetOnchainBalance check is performed in the State_SwapOutReceiver_CreateSwap state.
You can find the relevant section here:
https://github.com/ElementsProject/peerswap/blob/b7070cac0bec85a308df8da46b0aead57c7d95d4/swap/actions.go#L382
However, since this check alone may not be sufficient in some cases, I am considering updating the process as follows:

Opening tx Construction and Signing
When a swap-out request is received, receiver should first construct and sign an on-chain transaction.
If the wallet is locked during this step, signing will fail, allowing us to detect issues at that point. This will help prevent problems caused by wallet lock states like those you reported.
Reference link: signmessage RPC

testmempoolaccept
Additionally, to verify whether the transaction can be broadcasted successfully, we will use testmempoolaccept. If any issues arise during this step, an error will be returned at that point, preventing inaccurate swap processing.

I thik these improvements will reduce the risk.
Points to Note
However, even with this approach, it does not completely prevent cases where only prepayment is received and then a swap cancellation occurs afterward. For such abuse cases, there is already a mechanism within the system that records and manages suspicious peers as "suspicious peer."


multiple files select on single select with remove icon in Jquery MultiFile

I using this jquery multifile plugin, according to that we can select only one file at a time,
this is file input attribute of that
<input type="file" name="files" class="multi" onchange="return Plugins.handleFileSelect(this);"/>
Since I'm trying to select multiple files that can list each file with remove(X) icon at a time so I changed above input attribute like this
<input type="file" name="files" class="multi" onchange="return Plugins.handleFileSelect(this);" multiple="multiple"/>
Now I can select multiple files, but its not listing files with Remove("X") Icon
if I attached 2 files this is the view with inspect elements
https://i.stack.imgur.com/uzpsx.png
but its not listing two remove icons for each file in multiple file select

Although this issue was created earlier, it's a duplicate of #70 (that issue has more traction).

Anyone found any solution for the issue?

Files selected together must stay together and can't be removed 1 by 1, that's why there's only 1 link to remove the selection. This is because the selection is a FileList. If you want to manipulate the list  (ie.: remove individual files selected) you must iterate over the FileLIst, use FileReader to load the files contents, then you have a plain simple array you can manage yourself and you can do anything. But that's beyond the scope of this project which isn't maintained any more.


Adds support for public repositories

https://developer.github.com/v3/repos/#list-all-public-repositories

That's a pretty big miss. Thanks for adding it!


Code Refactored

PR includes :

changes in status code and response
Readme and Setup  file updated
Code Refactored

Can one of the admins verify this patch?

ok to test

@gopal-mahajan Need to update the collection name in the Jenkinsfile here as well.

retest this please


setting WDS_SOCKET_PATH does not fix what path the dev server responds on

If you run a simple npx create-react-app my-app and then try to start it with WDS_SOCKET_PATH=/somethingelse npm start the fast refresh won't actually work. In fact, the WS never responds. The solution that worked to fix this was:

First eject the app: npm run eject
Then edit the file /config/webpackDevServer.config.js and add webSocketServer: { options: { path: sockPath } }, to the configuration.

Ran into this too — thanks for the workaround!

Also hit this bug when going through a proxy.
We haven't ejected but instead are using react-app-rewired to modify CRA's config.
We have WDS_SOCKET_PATH set in the environment, then in config-overrides.js, devServer section:
config.webSocketServer = config.webSocketServer || {}
config.webSocketServer.options = {
    ...config.webSocketServer.options,
    path: process.env.WDS_SOCKET_PATH,
}

I'm having the same issue. @iamfrisbee's solution worked for me

+1


Communication: Allow user to forward messages

Checklist
General

[X] I tested all changes and their related features with all corresponding user types on a test server.
[X] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[X] I chose a title conforming to the naming conventions for pull requests.

Server

[X] Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
[X] I strictly followed the principle of data economy for all database calls.
[X] I strictly followed the server coding and design guidelines.
[X] I added multiple integration tests (Spring) related to the features (with a high test coverage).
[X] I added pre-authorization annotations according to the guidelines and checked the course groups for all new REST Calls (security).

Client

[X] Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
[X] I strictly followed the principle of data economy for all client-server REST calls.
[X] I strictly followed the client coding and design guidelines.
[X] Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
[X] I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
[X] I added multiple screenshots/screencasts of my UI changes.
[X] I translated all newly inserted strings into English and German.

Motivation and Context

Currently user cannot forward messages to other channels/direct-group chats.
(Closes #9066)
Description

The forward message feature has been added. Users can now navigate to the forward message dialog by clicking on the forward message option. They can select a random number of destinations and add content to the forwarded message (similar to Slack).
forwarded_message table has been added to the database with the following fields:

id: id of forwarded message
source_id: the id of the original message
source_type: the type of the original message (post or answer)
destination_post_id: the id of the destination post (the id of newly created post with the forwarded message)
destination_answer_id: the id of the destination answer post (the id of newly created answer post with the forwarded message)

post and answer_post table have been updated with a new column named has_forwarded_messages.
Known Issue for a followup PR:
The server-side changes for forwarding multiple messages within a single message and forwarding a message as a reply to another message (inside an AnswerPost) are already in place, but the client-side implementation is not ready yet. To achieve this, a unique message link needs to be generated for each post/answer post, similar to the "Copy Link" feature in Slack. This will be completed in a follow-up PR.
Steps for Testing

Prerequisites:

1 Instructor/Student
1 Course with Communication enabled

Log in to Artemis.
Navigate to the Communication section of a course.
Select a random message to forward or create a new one. Click on the forward message option (available on its hover bar or in the dropdown menu when opened via right-click).
Add some content to the forwarded message and select random destinations to forward the message.
Go to the destination channels/user chats and observe the forwarded messages.

Testserver States

[!NOTE]
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress

Performance Review

[X] I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance even for very large courses with more than 2000 students.
[X] I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance even for very large courses with more than 2000 students.

Introduced methods to retrieve messages by their IDs and manage forwarded messages.
Enhanced the Post and AnswerPost classes to track forwarded messages.
Added a new component for displaying forwarded messages.
Implemented a new method for batch retrieval of answer messages by their IDs.
Added a new endpoint for retrieving answer posts by their IDs.
Introduced a new DTO for grouping forwarded messages.
Added a new button for forwarding messages in various components.
Enhanced the ConversationMessagesComponent to handle forwarded messages and navigation.

Bug Fixes

Improved error handling in message retrieval and forwarding functionalities.

Documentation

Updated UI elements and added tooltips for new features.

Style

Introduced new styles for the forward message dialog and related components.

Tests

Added tests for new functionalities related to message forwarding.
Enhanced test coverage for components managing forwarded messages.

Chores

Updated internationalization files to include translations for the forward message feature.

thank you for your reviews :) after your reviews I updated the code to address the following issues:

Users can no longer forward a message to an announcement channel.
Fixed the rendering issue in the forward message dialog by using the PostingContentComponent.
Resolved failing server tests by making some minor changes in ForwardedMessage.java.
Added additional client tests.

I appreciate your re-reviews :)

Tested on TS6, I noticed a problem with the search bar: It's only possible to enter lowercase letters. So If I try to forward something to a direct chat with "Daniel" I can only find him by typing "aniel" (because "daniel" does not match "Daniel")

I used the existing logic for user selection. I face this issue while creating a direct conversation as well. So this issue is not related with this PR, but should be solved in another PR.

[Tested on TS2] Functionalities work mostly as expected, except for two quirks while I was playing around.

After forwarding messages, I logged in to another user and the forwarded content was not rendered at first. After refreshing, they got rendered like normal. This also happened after my 2. point.
directly after logging in

after refreshing

When forwarding from a private channel to a public channel, the link for "view conversation" appears even if the user is not in the private channel, and clicking on it causes them to access a site they are not supposed to, and reloads them to the all public messages. Is this desired behaviour?

PS: after this happens, the forwarded content are again not rendered until you refresh.
This is more of a sanity check, is it intended that messages from direct chats are allowed to be forwarded to public chats? I was thinking if this is suitable for the privacy of the users.

I tested it again and didn't encounter this issue. However, some content may load slowly when tested immediately after deployment; I've experienced this in other PRs as well.
Since it doesn't crash or show any errors, I think displaying a warning that says "You are not a member of this conversation" is fine for now. In the future, there could be a preview of the channel for users who aren't members, along with a "Join" option at the bottom, similar to Slack.
Yes, this is allowed in Slack as well. Artemis already has a confidentiality warning that says, "Keep your personal information safe by keeping it to yourself and not sharing it online" so I think it should be fine.


Data Persistence issue

Job Boards of the previous user is being displayed during my session.

The state is persistent because the data of the old user is not being flushed when the new user logs in.
Fixed the bug will close this issue after committing the code to the main branch.


Change bar on table/fig should also appear in booklist

Signed-off-by: Robert D Anderson<EMAIL_ADDRESS>This matches a change in 3.2 that added change bar support for revised topics in the TOC. #3100
This update does the same thing for tables and figures:

When a revision is specified on a table (or figure), AND
When that revision uses a change bar in the DITAVAL, AND
When that table (or figure)appears in a generated table list (or figure list),
The table (or figure) should be marked with that change bar in the table list (or figure list)

Sample bookmap for testing, with table/figure list, revised / not revised tables and figures, and ditaval:
pr3235.zip


Feature request: French and Japanese Translations

Is your feature request related to a problem? Please describe.
It would be awesome if it were possible to change language on the fly.
Describe the solution you'd like
Add a button to switch language.
Describe alternatives you've considered
None
Additional context
I am French but I play the game in Japanese. When talking with friends, I often have to switch from one language to another (French, English and Japanese) and I don't always remember the names in each language. Most sites don't have multiple languages.

Hey @julroy67, thanks to @FlorianReinprecht we have support for multiple languages (just German and English atm). If you would be willing to do a translation, all of the infrastructure is set up!

@SawyerHood Nice, let me add the FR and JP translation! 😄

Hey @julroy67 ,
a friend of mine started with a french tanslation. She may not be a native like you, but maybe you can use it as a starting point. 😄
fr.txt

@FlorianReinprecht Thanks, I'll check that and merge into my version!


loveterm:line() no longer tries to draw to a nil screen

Previously, the example loveterm:line() tried to call bresenham with nil as iits first arg, causing an error. By changing nil to self this error is fixed.

Thanks for this, it's much appreciated


[Accessibility] Users are confused about the difference between Owners and Organizations

Consider modifying the language around the Owner field to make it clear that an organization can be considered an owner. This could be accomplished with a tooltip, or extra text added to various sections of the site that deal with Owners and/or Organizations.

@anangaur , please provide more details and we can start the work.


Not accounting for all repos

I noticed that the spreadsheet currently produced does not contain all of the repos in this UCSB-CS56-Projects organization.
I also noticed that there are repos missing from https://api.github.com/orgs/UCSB-CS56-Projects/repos
This is probably not an issue with the code, but an issue that should be addressed nonetheless.
Maybe we have the wrong link? Or possibly the organization needs to be updated somewhere...?

This issue was due to pagination. Must specify a larger pagination number to get all the repos


Add gateway api for controlling scenes

This will make the gateway becoming stateful essentially, because there is no way to reconcile the state with the device.
It sucks, but for the simplicity, we will start with this and also use in-process memory store for now.

The upstream service can reconcile when needed. We will move on with the in memory temp store and "stateless" solution.


Ice detecting dolphin emu but not Metroid prime iso

Roms are in default rom folder.

fyi in consoles.txt that line next too "wii" is just the line that appears where your about to type.lol

Fixed my self. apologies.


our team section and new footer is added

Related Issue

Info about the related issue
our team section and new footer is added

Closes: #192
Describe the changes you've made
Previously

now

Type of change
What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Mention any unusual behaviour of your code (Write NA if not)
Any unusual behaviour of your code
Additional Info (optional)
Any additional information you want to give
Checklist:

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly whereever it was hard to understand.
[x] My changes generate no new warnings.
[ ] Any dependent changes have been merged and published in downstream modules.

https://user-images.githubusercontent.com/55352601/118385538-47d72e00-b62d-11eb-9e10-366f7031c018.mp4

@adarshvulli @ankitapuri kindly review this PR

I know there are some adjustments required like the meet our team heading is very large for phone view and cards should be in center in Phone view.
And i will do them no problem .
As soon my PR for logout is merged i will rebase my branch and commit the changes 🙂


chore: update web.py

Description
seperate -> separate
Motivation and Context

How Has This Been Tested?

[ ] Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
[ ] If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

Pipeline test:
Your own tests:

Types of changes

[ ] Fix bugs
[ ] Add new feature
[x] Update documentation

📚 Documentation preview 📚: https://RDAgent--395.org.readthedocs.build/en/395/

Thank you eltociear!


: Adding support for the angle representation for a CGPoint.

Checklist

[x ] New Extension
[x ] New Test
[n ] Changed more than one extension, but all changes are related
[n ] Trivial change (doesn't require changelog)

          2 Messages

  :book:
  Executed 124 tests, with 0 failures (0 unexpected) in 1.378 (1.647) seconds

  :book:
  Executed 116 tests, with 0 failures (0 unexpected) in 1.574 (1.843) seconds

  Generated by :no_entry_sign: danger

Current coverage is 33.36% (diff: 100%)

Merging #287 into master will increase coverage by 0.06%

@@             master       #287   diff @@
==========================================
  Files            46         46
  Lines          2036       2038     +2
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            678        680     +2
  Misses         1358       1358
  Partials          0          0

Powered by Codecov. Last update 275a9ba...0e03f3d


Please disable mangling by default

As you note in your README property mangling will probably break your code if you don't know how to use it, which is why your upstream UglifyJS disables it by default.
I don't understand what makes you, unlike your upstream, enable it by default, however. This cost me quite a bit of debugging time to figure out why our production build was arbitrarily breaking with a very niche thing in one of our dependencies.

I'm actually confused by the docs here. When we introduced webpack we've disabled mangling based on them, but they seem to be a bit misleading. Only property mangling is dangerous. It's not clear for me if it's on by default or not.

By looking at the code looked like it's not. I enabled it manually and it made smaller bundles and actually broke the build, so this confirms it's not on by default.
Another issue is that docs link to uglify master, which is currently v3, but this plugin uses v2 (#32).

@Sheeo so if you got the error with default settings (you have not set mangle.props to true or config object) the report with some example code should go upstream to https://github.com/mishoo/UglifyJS2.

I think upstream's docs are a bit misleading, too -- toplevel variable name mangling can break code as well as property mangling, this was indeed happening in a dependency of mine. Upstream does disable all mangling by default, you have to explicitly enable it.
Thanks for the doc clarification on your end!

Fixed by #42, reopen if still regressions :)


Remove unnecesssary values Vec from DynamicUniformBuffer and DynamicStorageBuffer

Objective
Fixes #8284. values is being pushed to separately from the actual scratch buffer in DynamicUniformBuffer::push and DynamicStorageBuffer::push. In both types, values is really only used to track the number of elements being added to the buffer, yet is causing extra allocations, size increments and excess copies.
Solution
Remove it and its remaining uses. Replace it with accesses to scratch instead.
I removed the len accessor, as it may be non-trivial to compute just from scratch. If this is still desirable to have, we can keep a len member field to track it instead of relying on scratch.

This seems to show a rough ~12% improvement over main when testing against many_cubes -- sphere (867.26us -> 763.99us).


Disable namespace creation

OS cluster is currently namespaced although it creates a separate namespace to deploy cluster
I think for more convenience it should either be namespaced and deploy cluster in the same namespace where crd has been created, or should be a cluster resource and deploy cluster in a namespace specified in spec
In my opinion namespace management via operator makes sense when crd requires multiple namespaces, otherwise we will have some pain managing full lifecycle in terms of PVC management
There is a number of operators for orchestrating databases that I used to work with and all of them create clusters in the same namespace where crd is created (cassandra, vicroriametrics, etcd etc)

I think we should switch to creation of cluster in the same namespace where CRD has been created, unless there is a chance we will need to create multiple namespaces for multiple components (like single controlplane namespace and separate namespaces for different components)

Hi Michael, thanks for the issue.
your idea is part of our progress plan, thats an update that we will add in the next versions.

@idanl21 any update here? is it done?


peerpod-ctrl: dynamically fetch cloud provider config

at runtime, when Provider is not passed
Fixes: #881

made some changes and removed WIP


Implements single Client as the default GCP SecretManager approach

Fixes #818
Fixes #837
Some comments around this fix:
The issues are around the fact that apparently GCP SM does not expects multiple clients running at the same time.
Also, the main memory leak comes from the fact that SecretStore reconciles were not calling the Close method.
The main idea of the fix is to make sure we only have one instance of GCPSM and GCPWI clients, and never close them. Closing doesn't have to do with memory per se, but with some random error messages that appear if a given ES or SS gets reconciled in parallel.
Signed-off-by: Gustavo Carvalho<EMAIL_ADDRESS>

@moolen Alternatively to this fix (which is provider - related), what I already tested and confirmed to work is implement a mutex approach. This would obviously impact the concurrency option, but it seems for some providers this can actually make sense. So the other way around this is to add a new SupportsConcurrency method for the Providers and a check on the reconciler loop before Locking a given Mutex.
I followed with this one as the fix as this way concurrency is still allowed.
PS - I believe I still can do some cleanup to methods that are not used anymore, but I want to see what e2e tests will say about this.

Also, a picture about the improvement:
fix running with concurrency=10, store-requeue-interval="1s"
main running with concurrency=1, store-requeue-interval="10s"
(hided graphs are for other combinations of these two parameters)

Awesome! Also curious to see the mutex implementation, if it is already there. We can decide which direction to go looking at them side by side

I did fix-by-mutex on top of 0.4.4 only, but it can be checked in here: https://github.com/external-secrets/external-secrets/tree/fix-by-mutex

Update: I just figured out that even if we do this approach, GCP provider itself currently wouldn't support multiple concurrent calls. This is the issue of #818 actually. Basically what's happening there is that one thread is configuring to use one credentials, while the other is trying to fetch secrets. At this time, the actual call the client does is using the newly configured credentials by thread 1, and not the expected in thread2. This, when granular permissions are used, turns out to be a Permission Denied error.
TL;DR - It's safer even from a security point of view to implement Mutexes, and just not allow GCP Provider to be concurrent. I'll close this PR and add a new one with this config.
The new PR will also be from a fork, as requested by @knelasevero =)


Support custom dictionaries?

Could custom dictionaries be supported?
https://cspell.org/docs/dictionaries-custom/
My cspell config is like this:
cspell.config.cjs
module.exports = {
  version: '0.2',
  language: 'en',
  dictionaries: [
    'user-apps',
    'user-brands',
    'user-custom',
    'user-files',
    'user-npm',
  ],
  dictionaryDefinitions: [
    {
      name: 'user-apps',
      path: './dictionaries/apps.dic',
      addWords: true,
    },
    {
      name: 'user-brands',
      path: './dictionaries/brands.dic',
      addWords: true,
    },
    {
      name: 'user-custom',
      path: './dictionaries/custom.dic',
      addWords: true,
    },
    {
      name: 'user-files',
      path: './dictionaries/files.dic',
      addWords: true,
    },
    {
      name: 'user-npm',
      path: './dictionaries/npm.dic',
      addWords: true,
    },
  ],
};

npm.dic
commitlint
corepack
cssnano
depcheck
htmlhint
immer
markdownlint
sonarjs
stylelint
svgr

This is feasible in terms of technical implementation, but due to my recent busy schedule, I may not be able to support it immediately (the time frame that I can guarantee is within one month). It would be great if you could submit a PR for this!

@donniean great suggestion!


Fix bugs in PredictiveTrainingModule when using PredictiveTrainingModuleConfigs for config

This fixes #91

There were some conflicts that prevented merging, I kept the version in v0.1.


Added column_oriented check to the named_results function

Summary
Fixed StreamClosedError when trying to execute QueryResult.named_results() after QueryResult.row_count
result = client.query('SELECT * FROM system.tables')
print(result.row_count)
print(list(result.named_results()))  # StreamClosedError

Checklist
Delete items not relevant to your PR:

[x] Unit and integration tests covering the common scenarios were added

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


'earthmass' not populated for the BodyScannedEvent

I am making a voice responder that outputs the approximate value of a scanned body (and star) but discovered that the 'earthmass' property is not set in response to the Body Scanned event.
I made some local code changes to get it to work but I noticed you've made significant changes since the last public release - so I'm not sure my changes would be of much help to you as a pull request since they're pretty trivial.
I am using the scan values from this wikia page, which depends on 'earthmass' for identifying tiny/medium/huge bodies.

This property isn't listed in the Frontier journal reference.  Do you have a journal entry for a planet that shows this value?

It's called "MassEM" in the journal entry and they provide an example in the Frontier journal reference under section 6.1. EDDI defines the property "earthmass" in DataDefinitions/Body.cs which is exposed to the templating language, but that field is never populated.
I can send you an example and a pull request with my local changes when I'm back at my home PC this evening.

Attached a patch of my changes and a journal log with a few sample scan events.
Cheers!
earthmass-patch.zip
Journal.170325133214.01.log.zip

Thank you for the logs.  I've added earthmass (and radius) to BodyScanned; they will be available in the next release.

Perfect, thanks!

These new properties haven't been included in the last two releases. Can you please include these changes into the next release?

Sorry should have said next major release.  The patch releases in the 2.2 series are just fixes rather than new features.

These properties are present in EDDI 2.3 (currently in beta).


Downloads HTML instead of MP4

When I try to download a video such as https://www.br.de/mediathek/video/abenteuer-wildnis-natur-doku-urwald-von-morgen-nationalpark-eifel-av:61f16675cc0d4d0009a6446e I only get the HTML page downloaded, not the referenced MP4 file:

It appears as if the plugin has no effect at all. I am using v0.7.0 on a DS218j with DSM 6.2.4-25556 Update 5:

Hi rstub,
sorry for the late answer. As the video is not available anymore, I can't debug why the download failed for you.
If you have another link from BR Mediathek, which doesn't work, please provide it, so I can look into it.
I tried downloading this Episode and it worked just fine.

Thanks for looking into this. Sorry for not being clear. So far no download link has worked for me, including the one you provided:

So I assume there is something fundamentally wrong with my installation. How could this be debugged?

Take a look at #46, probably your download station broke the provider.

My DS seems to be different, maybe because I am using DSM 6.2.4-25556 Update 5. There is no @appconf in /volume1.  I'm a bit confused that the owner name is just a number, not the user's name. But that may have to do with DSM 6.
Did you also try to remove mediathek using the rm command and then install it again? And can it be enabled or disabled in the Download Station settings?

I think the numbers are to be expected. On my system there is no user with UID 501 (or group with GID 20), but this should have no effect. To be sure I also transferred the directory via chown DownloadStation: -R mediathek/ with now effect.
Removing mediathek with rm and reinstalling things did not change anything either. I am also able to add and remove the tick mark for mediathek in the Download Station settings.
BTW, I have not tried any of the other "File Hosting" options. Maybe that is not working at all for me for some reason? Do you know of any possibility to test those? Does one have to enable PHP processing for Download Station somewhere? I cannot find such a setting, though. Which PHP version is required? I have PHP 7.2 and PHP 7.3 installed.
Maybe I am doing something fundamentally wrong. Here are the steps I have taken:

Install Download Station on my NAS
Install mediathek.host as an additional "File Hosting" provider
In Download Station use "Create Download via URL" and provide a URL such as https://www.br.de/mediathek/video/abenteuer-wildnis-tier-doku-polarwoelfe-ueberleben-in-kanadas-arktis-av:61bc72ea119391000941a19b

This results in a 100kB HTML file being downloaded. Any obvious errors in that procedure?

Hmm I'm not sure if DSM 6's Download Station is that much different. Haven't changed anything to make the Hostfile compatible with DSM 7.
I could create a debug version, so we can see if the host is even executed. Maybe I find some spare time today.

I have the same problem with Download Station and latest mediathek.host. Only a HTML-file of a size between 80 and 100 KB was downloaded. I have the same DSM version as rstub and I reinstalled Download Station and mediathek.host 0.7.0 without success.
It covers nearly all downloads from a mediathek of ARD and ZDF.
I have this problem since version 0.6.X (don't know the exact version).

I have "the same problem" since may 2022... I can't download any video from https://www.arte.tv/fr/, I just get html files.
DS1019+
DSM 7.1-42661 Update 1
Download Station 3.9.3-4609
mediathek 0.7.0
look at files received for https://www.arte.tv/fr/videos/046579-001-A/real-humans-saison-1-1-10 => real-humans-saison-1-1-10.zip

I updated my device to DSM 7.1.1-42962 Update 5 and uninstalled package PHP 7.0 (it's not supported in DMS 7.x) and now I will get the MP4 files again.
Maybe it is an issue about installed PHP package(s).
Right now I have only installed package PHP 7.4.

I am   not sure if my DS218j has enough memory for DSM 7.x. Concerning PHP, I have only version 7.3 and 7.4 installed.

My device is a DS115j and I could install DSM 7.1.1 without problems.
Go to https://www.synology.com/de-de/support/download and select your NAS-model.
Synology show you the possible DSM versions to install (I need to download the installer(s) and upgrade manually).
On the page you can also select your current DSM version and the DMS version you want to upgrade to. Synology gives you advise on how to do it the best way (I had to install version 7.0 first and then I could update to latest 7.1.1).

Thanks @MHartmann-427 for the encouragement. I have now also updated to DSM 7.1.1 and can report that downloading works as expected now. Interestingly, for @steeve-kaut1 using a recent DSM is not sufficient.
@iNaD: I leave it to you how to proceed with this issue.

Thanks for your research and updates on this topic. I will keep this open for now and add a Troubleshooting section to the Readme with the suggestions from this issue.


Add Consumer.Storeoffsets

Opening this PR for exposing Storeoffsets feature in .net api. Requested in #31.
As suggested I followed the implementation of this feature from Go language https://github.com/confluentinc/confluent-kafka-go/commit/e093d2be7dd0f3fc41f3a53c5127a139a9e4919d
Regarding what to retrun from Consumer.cs StoreOffsets method, I was debating if I should use existing class called CommitedOffsets.cs to capture results, but the name of the class appears to be misleading. So I have created a new class called OffsetResults.cs, a more general name to capture such results. Please let me know your thoughts and suggestions. If this new name appears appropriate, then it can be used instead of CommitedOffsets.cs as well. I didn't go that far because it would be a breaking change.

It looks like @vinodres hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.
Once you've signed reply with [clabot:check] to prove it.
Appreciation of efforts,
clabot

[clabot:check]

@confluentinc It looks like @vinodres just signed our Contributor License Agreement. :+1:
Always at your service,
clabot

thanks! this looks good at first glance and is pretty small - should be able to get this in soon.

thanks @vinodres - finally got to reviewing this! let's try and get this in the Nov 20 release we're going to do.

@mhowlett / @edenhill, for this PR is there anything else you are waiting from me?

@edenhill - I don't think we need a unit test for this.
This is now LGTM and I'll merge it if there are no other comments.
One more thing I think would be good is an example demonstrating the difference between storing and committing, but that can come later.

librdkafka master is now fixed, please verify.


STREAMLINE-778: Roles API updates

Changed the role hierarchy api to accept role name instead of id.
i.e. POST /roles/{parentRoleName}/children/{childRoleName}
Added a new role hierarch api to accept a set of child role names
i.e. POST /roles/{parentRoleName}/children/
["childRoleName", "childRoleName2",..]
Added description to Role

@arunmahadevan
If the user wants to rename the role or add/remove more child roles, are we suppose to make same POST call or need to add another PUT API?

@shahsank3t

For renaming the role you can use "PUT /roles/:ID". The parent-child relations are maintained internally on ids so it will not be affected.
Right now there is no PUT api for updating children. POST will only add the roles you pass in the input array. (if you pass an already existing child role in POST it will throw an exception). You need to call "DELETE /roles/:PARENT_ID/children/:CHILD_ID" to remove parent-child association. If you really want, I can add a PUT api.
There is no key for the roles array. Its just a set of string, so you can POST a json array.

@arunmahadevan
Yes, please add a PUT api for updating children. Mapping & then making POST/Delete API calls to update children will be complicated on UI.

@shahsank3t, added PUT api.

@arunmahadevan
Thanks for PUT API.
One more change we need is a way to identify predefined ones (eg: ROLE_CLUSTER_ADMIN, ROLE_TOPOLOGYY_ADMIN, etc) from the ones user defined.
I was wondering if you could add children array into the GET API for "roles" which UI can use as a differencing field between predefined & user defined roles. This will also help us reduce 'N' number of GET children API request, where N is the number of users defined roles having children.

@shahsank3t, when the user clicks on the role details, you can query the child roles and display. Not sure if you necessarily have to differentiate between predefined roles and user defined roles.

@arunmahadevan, on the UI we are showing predefined roles into one section and custom roles into another. So to clearly differentiate between them, it would be better to get children in the same API else UI needs to make GET children for all roles and then separate them.

@shahsank3t, if you want a way to differentiate system roles from user defined ones, we can add a flag (say isSystemRole). Getting children by default would be expensive in case of multilevel hierarchy and not really required for differentiating.

@arunmahadevan I am fine with adding a flag as well.

@arunmahadevan, On deleting the custom role, we are getting an error saying:
"An exception with message [Role has child roles: [Role{id=5, name='UDF_ADMIN', timestamp=1493024164911} com.hortonworks.streamline.streams.security.catalog.Role@ef4d6887, Role{id=4, name='FILE_ADMIN', timestamp=1493024157325} com.hortonworks.streamline.streams.security.catalog.Role@d2504eac]] was thrown while processing request."
Can you please make appropriate changes on the backend which delete's the associated child roles for that custom role rather than UI making all those delete API calls? (similar to add API)

@shahsank3t, added a "system" flag in the roles. Also modified the delete API to remove the child association automatically.

+1, Thanks @arunmahadevan


Add announcement bar about Open Sourcing

Blocked on #29

Refactor MarketingBar into InformationBar and DiscordBar
The InformationBar should take the discord prompt as children in the DiscordBar.
The discord bar should be used in / and /play
Add another instance of the MarketingBar on the / page, below the page title "Typing competitions for programmers"
The bar should include a Github svg and the text "speedtyper.dev is now open source! 🎉"
When you press the text or the logo you should open this repository in a new tab
Post an image of the design in the PR

@codicocodes will post an example design

Not sure if we want this. Closing for now.


Fix use case sentence for bash util doc

Thanks for all your hard work!
I noticed a small typo in the bash util doc so here's a quick update. Additionally, my formatter caught some spacing in the .md as well. Happy to revert that if it's an issue.
The main change is just
- A common use case this is for letting it interact with your local file system.

+ A common use case for this is letting the LLM interact with your local file system.

Testing
make docs_build succeeds locally and the changes show as expected ✌

I suppose the workflows need to be manually triggered by a maintainer?

@hwchase17 curious if there is anyone else I should tag for the 1st time automation trigger?


Optimizations

The amount of code used in this plugin could be reduced significantly. You should utilize loops.

Yeah, thanks!

Do you mind doing that? This is an old project, and has been inactive for a bit now, lol.

@applqpak No need, I've made one here already awhile back: https://github.com/NebulaLabs/PocketMine-Plugins/blob/master/Scripts/HelpTailor.php

Okay, thanks. :)


Can I use image labeling instead of object detection and tracking to view similar products as the capture one ?

Hello, I'm building a flutter app that the user can capture a product (clothes, shoes, watches, etc...) and my app should view the similar products, I see that the object detection is still not yet implemented for iOS, so can I use image labeling for that issue, and if yes can anyone give me a hint what should I do, I'm learning now TensorFlow in Order to make my own custom model...
This is example for what I need : https://developers.google.com/ml-kit/case-studies/adidas
Hope can anyone help me with that,

@hassanyassiin : we released 0.8.0 yesterday and all the APIs are supported for both iOS and Android, except for selfie segmentation.
Also, be aware that google_ml_kit is an umbrella plugin that will include all the functionality for all the ML Kit APIs, and therefore will include more functionality that you intend to use. If your intentions is to only use object detection try google_mlkit_object_detection. Go to our readme for more details: https://github.com/bharat-biradar/Google-Ml-Kit-plugin/tree/master/packages/google_ml_kit


ssh key passphrase

when your ssh key has a passphrase and you try push/pull with this plugin, we don't have an interactive shell that can request the passphrase. a known workaround is to use a keychain to autofill the passphrase. this bug is likely low priority cause of the common use of keychains.

Sir I am willing to solve it but I don't know where to start can someone please guide.

No success to pull or push on Windows.
Error: "Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists."
Followed the guide and nothing :/
My key has a passphrase, over cmd i can connect with no problem.


Build Code for ESP32 U4WD for One Core (IDFGH-6311)

Hello All.
I use Windows 10
vscode with arduino extension for programmer the esp32
I work with D2WD and all wotk OK
but now I need to build code for ESP32 U4WD. but its print this error
ets Jul 29 2019 12:21:46

rst:0xc (SW_CPU_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 188777542, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:1
load:0x3fff0018,len:4
load:0x3fff001c,len:1044
load:0x40078000,len:10124
load:0x40080400,len:5856
entry 0x400806a8
E (269) cpu_start: Running on single core chip, but application is built with dual core support.
E (269) cpu_start: Please enable CONFIG_FREERTOS_UNICORE option in menuconfig.
abort() was called at PC 0x40084805 on core 0

ELF file SHA256:<PHONE_NUMBER>000000

Backtrace: 0x40088784:0x3ffe3be0 0x40088a01:0x3ffe3c00 0x40084805:0x3ffe3c20 0x40079247:0x3ffe3c40 0x400792ad:0x3ffe3c70 0x400792b8:0x3ffe3ca0 0x40079465:0x3ffe3cc0 0x400806da:0x3ffe3df0 0x40007c15:0x3ffe3eb0 0x4000073d:0x3ffe3f20

Rebooting...

I dont know how to force compiler to Build code for only one core. and I cant select Board ESP32 U4WD because the sdk only know the modules and not the chips
thank you a lo

Hi @hdpklm, at the moment the Arduino core for ESP32 (https://github.com/espressif/arduino-esp32) doesn't have support for ESP32-U4WD. There is a feature request for adding this support: https://github.com/espressif/arduino-esp32/issues/5183. Please follow that link and click "subscribe" button to get notified about progress on that issue.
You can still compile programs for ESP32-U4WD using ESP-IDF, see https://docs.espressif.com/projects/esp-idf/en/release-v4.4/esp32/get-started/index.html for the getting started instructions. When using ESP-IDF, you need to use idf.py menuconfig or the GUI configuration editor in VS Code to enable single core mode (i.e. CONFIG_FREERTOS_UNICORE option). Then your program will run on ESP32-U4WD. If you wish to use Arduino libraries as part of your ESP-IDF application, check out these instructions for using arduino-esp32 as an ESP-IDF component: https://docs.espressif.com/projects/arduino-esp32/en/latest/esp-idf_component.html#installation.

Hello @igrr
ok, thank you very much


Upgrade to JupyterLab 3.0

Fixes https://github.com/utoronto-2i2c/jupyterhub-deploy/issues/81
TODOs

[ ] Figure out what to do about qgrid
[ ] Build image
[ ] Deploy and test on staging

Unfortunately I don't think qgrid is compatible with JupyterLab3, but there's an open PR for this: https://github.com/quantopian/qgrid/pull/356
@yuvipanda, do you know if it's actively used by users? I found two references about it:

https://github.com/utoronto-2i2c/jupyterhub-deploy/issues/42
https://github.com/utoronto-2i2c/jupyterhub-deploy/issues/41

@GeorgianaElena if qgrid will still work on classic notebook, let's just document that and go ahead.

AFAIK, Quantopian does not exist anymore and I am not sure if qgrid is being maintained recently by others... so I agree with @yuvipanda.

Thanks @yuvipanda and @damianavila! It all seems to be working (qgrid only with classical notebook).
I will deploy this to prod tomorrow so that users don't get interrupted and presented with a new interface on a Friday :D
Also, hopefully, we will get some feedback over the weekend if I missed anything and there's something not working ok so that everything it's working by Monday.

I will deploy this to prod tomorrow so that users don't get interrupted and presented with a new interface on a Friday :D
Also, hopefully, we will get some feedback over the weekend if I missed anything and there's something not working ok so that everything it's working by Monday.

Maybe, in the future, we should think about ANN these sort of big changes? IIRC, there was something written in the ecosystem to make wide ANN in a Jupyterhub sort of setup... let me find it... ok, here it is: https://github.com/rcthomas/jupyterhub-announcement
Again, just something to think about for the future (not asking to use it now :wink: ).

Maybe, in the future, we should think about ANN these sort of big changes? IIRC, there was something written in the ecosystem to make wide ANN in a Jupyterhub sort of setup... let me find it... ok, here it is: https://github.com/rcthomas/jupyterhub-announcement

Thanks for sharing @damianavila! This seems like a pretty cool service to have.
Unfortunately, I failed to deploy this over the weekend :( However, @damianavila's message got me thinking if we should instead coordinate with the UToronto folks before and schedule this deployment, similar to what happened when the hub version was bumped. @yuvipanda, what do you think?


Snake example doesn't work

http://labs.phaser.io/view.html?src=src\games\snake\part8.js
As soon the snake hits the egg, this error shows:
Uncaught TypeError: Cannot read property 'FX' of undefined
    at Food.eat (part8.js:71)
    at Snake.collideWithFood (part8.js:219)
    at Scene.update (part8.js:295)
    at Systems.step (Systems.js:280)
    at SceneManager.update (SceneManager.js:363)
    at Game.step (Game.js:363)
    at TimeStep.step (TimeStep.js:519)
    at step (RequestAnimationFrame.js:102)

Have removed part8 from the index as dynamic fx isn't in v3 any more.


Handle post import errors

As found in https://github.com/camunda/camunda-modeler/issues/3687 post import errors in the BPMN editors were not appropriately handled.
Reviewing the existing code it was clear that it
(1) swallowed existing exceptions
(2) did not catch exceptions in all cases, i.e. https://github.com/camunda/camunda-modeler/issues/3687.
This PR should clean up the matter.

I could add a unit test, mock handleLinting and see what is happening.
Was hoping though that I could get around with existing functionality still working, and code being much cleaner than before :see_no_evil:.