Assembly strong name information is misleading

Bug
NuGet Package Explorer - Zip - X64 - (5.9.48+f28f3b874b)
Windows 10 - 1903
Installed from: Zip on GitHub
Using sn tool I get below information:
sn -vf Common.1.1.1.dll

Microsoft (R) .NET Framework Strong Name Utility  Version 4.0.30319.0
Copyright (c) Microsoft Corporation.  All rights reserved.

Assembly 'Common.1.1.1.dll is a delay-signed or test-signed assembly

and
C:\git\temp\sn>sn -vf Common.1.1.4.dll

Microsoft (R) .NET Framework Strong Name Utility  Version 4.0.30319.0
Copyright (c) Microsoft Corporation.  All rights reserved.

Assembly 'Common.1.1.4.dll' is valid

Using package explorer in both cases I get :
Strong Name: Yes, version <IP_ADDRESS>

What is the expected result?
in first case: Strong Name: Nope, but delay-signed or test-signed assembly, version <IP_ADDRESS>
in second case Strong Name: Yes, version <IP_ADDRESS>

NPE checks to see if there is a strong name but does not validate it. Strong names are not validated by .NET Core, .NET 5, Mono. In .NET Framework, they're only validated when using app domains or the GAC.

@clairernovotny I failed to find any articles about strong naming being left behind. Could you point me to one?


ref(k8s): update k8s api to 1.2.4

Summary of Changes
change the k8s api version to 1.2.4 and fix the wait for pod as k8s now logs throttling requests.
Issue(s) that this PR Closes
Please list the issue(s) that this PR closes, similar to the below:
Closes #343
Closes #344
Associated End To End Test PR(s)
Associated Documentation PR(s)
Associated Design Document(s)
Testing Instructions
Please provide a detailed list for how to test the changes in this PR.

Create a Deis Cluster
deploy an app with different storage backends
app should be deployed without any error

Pull Request Hygiene TODOs
Please make sure the below checklist is complete.

[x] Your pull request is concise and to the point (make another PR for refactoring nearby code)
[x] Your commits follow the commit style guidelines

cool PR hope this will solve all inconsistencies and  race conditions in launching pods and getting logs


Feature: Can we have capitalized version for %p in clock?

Hi, 👋.
Feature: Can we have a capitalized version for %p in clock?
So instead of "08:10 am", I would like to have "08:10 AM".
I tried to capitalize in the CSS part, but Waybar doesn't support it.
Thank you so much for Waybar! 🍦

What does your clock format config look like? Waybar should format date and time using the date format strings (see man 1 date).
Though I notice something weird:
    "clock": {
        "format": "{:%H:%M:%S %p %P}",
    },

I see it rendered as if it doesn't interpret %P :thinking:

From the shell it works as expected:
$ date +'%H:%M %p %P'
16:00 PM pm

(scratch my previous comment)
The wiki explains which formatters are available. See this page fmt.dev/latest/syntax.html#chrono-specs

I have visited that wiki multiple times and the Chono spec, but had no luck. Can you pin point which one fixes my issue?

@azzamsa the linked documentation points has the formatter %p which you seem to already use and does what you're looking for (capitalized 12/24 hours, here an example).
Unsure why you see it not capitalized. Does it also reproduce without using a stylesheet and a minimal configuration like:
    "clock": {
        "format": "{:%R %p}",
    }

Which window manager are you using?

the linked documentation has the formatter %p which you seem to already use and does what you're looking for (capitalized 12/24 hours, here an example).

Oh, I see.

Unsure why you see it not capitalized. Does it also reproduce without using a stylesheet and a minimal configuration like:

I am using Hyperland.
However, I don't use it anymore. I will come back here if the issue persists when I happen to use Hyperland again.


Base Boosting Example: Scoring is invalid

Hello,
I tried to run the example in the base boosting docs again after changing the instantiation of the regressor, but now, the nested cross-validation procedure is not running to completion because of the scoring method. Please let me know what I could do to resolve this issue. I look forward to using this package!

Hi,
You'll need to update to version 0.1.7 which is available via PyPI. This was mentioned in the earlier issue.
Notedly, the scoring issue stems from the following update to sklearn, where _check_multimetric_scoring no longer accepts an str object as an argument.

I do have the latest version, but the scoring issue still persists. Could you confirm that the Base Boosting example runs without errors? Thanks.

I've run several tests without issue.
Can you please try from physlearn import __version__, then print(__version__), as well as from sklearn import __version__, then print(__version__), and let me know the outcomes. Also, could you show the error message, so I can see at which line the error is occurring. The scoring is a str, so it should never reach _check_multimetric_scoring to generate a ValueError.


ios: leaking streams

It turns out that WebRTC creates a new instance of the RTCMediaStream wrapper before calling callbacks on the peerconnection which means that instance equality can no longer be used for finding the streams.

Nice find! How did you catch this?
Come to think of it, wouldn't it make more sense to stop storing stream object altogether then? https://github.com/jitsi/react-native-webrtc/blob/master/ios/RCTWebRTC/WebRTCModule%2BRTCPeerConnection.h#L16 We could use an object of our own with some metadata matching the stream ID. WDYT?

So it works and is implemented as intended on the Android side, so I'm not sure if it would make sense to make a custom structure only on the iOS side as we have used to try and keep both sides as similar as possible. Honestly that seems like extra work and to be honest is more a bug of WebRTC.

I think it has been this way since the beginning. I have a vague memory of this being the same when I worked on the Cordova plugin. In addition there was a comment somewhere about this, but I can no longer find this.
At any rate, aligning the native sides is not really that useful IMHO, since they have different APIs already (look at the video capture code for instance).
I’ll revisit this when updating to M74 since there is some work in the area that needs to happen anyway.


[WIP]Consolidate test suites

Merge integration and policy-collection into one single suites. Use spec
label to label the test cases.
Signed-off-by: Yu Cao<EMAIL_ADDRESS>

@ycao56 the diff is quite large so it's hard to review. Could you please separate this out into two commits? The first commit would be moving the files from policy-collection to integration and the second commit would be the changes made to the test files to make them work.

@ycao56 the diff is quite large so it's hard to review. Could you please separate this out into two commits? The first commit would be moving the files from policy-collection to integration and the second commit would be the changes made to the test files to make them work.

Sure. I will update.

@mprahl this is ready for review.


gmrender-resurrect: 0.0.8 -> 0.0.9

Updating the latest version of gmrender-resurrect lets
us skip adding the cherrypick patch, as this is already
included in 0.0.9.
(Note, I am not maintainer of this nix package, but
maintainer of gmrender-resurrect)
Signed-off-by: Henner Zeller<EMAIL_ADDRESS>Motivation for this change
Version Upgrade; reduce complexity by not having to cherrypick a patch.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 119588 at b381d5e8 run on x86_64-linux 1

1 package built successfully:

gmrender-resurrect

2 suggestions:

warning: unused-argument
Unused argument: fetchpatch.
Near pkgs/tools/networking/gmrender-resurrect/default.nix:1:33:
  |
1 | { lib, stdenv, fetchFromGitHub, fetchpatch, autoreconfHook, pkg-config, makeWrapper, gstreamer
  |                                 ^

warning: unclear-gpl
gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/tools/networking/gmrender-resurrect/default.nix:34:7:
   |
34 |       license = licenses.gpl2;
   |       ^

hey, thanks for this! unfortunately i'm no longer using it on my machine, so i can't really test it locally. since you're the maintainer of the software itself, would you be willing to adopt this package?

Sure, would you like me to remove you and add me to the maintainers list ?

yes, please

Done.


Simple interface for turrets

All turrets should have a common way to be told to shoot. By implementing an interface, calling the shooting function in animation controllers should be more consistent across different turrets.

Changed the base from develop to lightningTurret, so that this PR doesn't include the same commits as #27 does 😛


docs: fix & enhance "Use your own globs" example

Fix: micromatch treats path strings differently, so *.js matches only those js files which are in drive's root, given the config function gets array of absolute paths as parameter. This PR fixes that.
Enhance: This PR also adds more clarification to the example by showing how multiple commands can be executed on different types of staged files.

@SachinShekhar are you sure about this? We specifically use the matchBase option like so:
https://github.com/okonet/lint-staged/blob/d404d7d5a2ccfba51d2d59e1fbb6e2e82539646c/lib/generateTasks.js#L46-L49
This is also documented in the README:
https://github.com/okonet/lint-staged#filtering-files

@iiroj You answered yourself. Currently, the example doesn't use matchBase option either. So, a pattern without slash matches nothing.

Now I understood, you mean the micromatch commands in the example, not lint-staged itself! Looks good.


Fix Examples/qo_twophoton

A potential fix for the Examples/qo_twophoton.jl. I think passing times into this function is causing errors, as there is no argument for times in the ξfun.
Please double-check. Thanks!

It's actually because twophoton, inputs times to the ξfun automatically. This is a leftover from previous code, thanks for noticing!


Better documentation regarding the use of a custom tab bar component

Related to: https://github.com/react-navigation/react-navigation-tabs/issues/116
There is little to no documentation about using a custom component as the tab bar with createBottomTabNavigator.
Some documentation about the required props + an explanation of what they mean could be very helpful.

I mainly had problems with the extra ones I had to provide, getAccessibilityRole, getAccessibilityStates and getButtonComponent. Figured it out eventually by having a look at the source code. Also, it's a bit hidden in the themes maybe? I didn't find it, but that might have been just me.

i wouldn't say it's hidden, it's exactly where it needs to be for themes, but i agree we need to have some information on this perhaps in the api reference section


The 'mip' keyword in recipe yaml is confusing

The 'mip' field in the datasets dictionaries refer to CMIP-tables, not to MIP's themselves. There is certainly not a one-to-one correspondence between the two concepts, so I suggest to rename the key to e.g. 'table'

@ESMValGroup/esmvaltool-developmentteam Is there anyone with an opinion on this proposal?

The official CMIP(5) Data Reference Syntax (DRS) speaks of 'MIP table', but I agree that 'mip' is probably confusing if you do not know this field actually refers to 'mip table'. I would prefer to call it e.g. 'mip_table' instead of 'table' to be more precise this time.

I'm with @axel-lauer on this one! table can be easily confused with CMOR tables

I'm with @axel-lauer on this one! table can be easily confused with CMOR tables

@valeriupredoi I'm confused now. Can you explain the difference between 'MIP table' and 'CMOR table'? I was looking at the explanation here, which seems to suggest they're the same thing:

The CMIP6 MIP tables can be downloaded here: https://github.com/PCMDI/cmip6-cmor-tables/tree/master/Tables

i.e. they talk about CMIP6 MIP tables, but refer to a repo which is named CMIP6 CMOR tables...

they are the same by name - CMOR tables are constructed based on the specifications laid down by the CMIP Data Request in mip tables; the thing is I am saying, just as Axel, that we should be more specific with your variable naming convention and don't use the general table because this is for the DRS and has nothing to do with CMOR validation (checks), we also have a dedicated CMOR validation bit, and those tables are indeed called cmor/tables. BTW here is the DRS document for our reference, their naming is MIP_table :beer:

@zklaus @jvegasbsc are Dreq/MIP/CMOR experts so I'd be interested what they think :+1:

Ah okay thanks for the clarification Vi! BTW I totally agree that it's better to be specific

I agree with @valeriupredoi  that it would be good to follow the existing conventions, though maybe not with the capitalization. @valeriupredoi Is there a similar document for CMIP6?

yep, found it! authored by our own @bnlawrence here

From the document mentioned above, it looks like it is table_id in CMIP6. It does not look very nice to me to put _id and _label behind every facet in the recipe, as is done in the CMIP6 DRS. If we leave out the _id part again, plain table seems to be most in line with the CMIP6 DRS.

In the same way, the dataset is also confusing as it seems to refer to a model (and is also called model elsewhere, e.g. the dkrz search).

it seems to refer to a model

This is only the case for model data. Note that we also support observational datasets.

This is only the case for model data. Note that we also support observational datasets.

Fair enough, thanks for pointing out my lack of knowledge 😅 Doesn't make it less confusing!

This is only the case for model data. Note that we also support observational datasets.

The exact reason we replaced the model tag with dataset


Neo4j 4.0.x. support

Hello,
is there any plan to support newer versions of neo4j ?
Neo4jError: The old parameter syntax {param} is no longer supported. Please use $param instead
Thanks

+1


Added instruction to set the env path for dtrace

Added instruction to set the env path for dtrace. It was missing earlier and causing confusion that dtrace commands are not working.

@bhupeshpant19jan - Sure the command prompt path command will work fine. Also longer term persistent setting using the environment values in settings. And I have not really looked at the new app execution alias in packaged apps, but that might work as well.
https://learn.microsoft.com/en-us/windows/apps/desktop/modernize/desktop-to-uwp-extensions


F3D hangs when opening certain glTF file

F3D hangs when opening certains glTF files
Caused by a regression in VTK: https://gitlab.kitware.com/vtk/vtk/-/issues/19085
Mirror of the VTK for easier discovery

@Alairion


Testing: add integration test coverage for multiple MongoDB versions

Description
Add test coverage for MongoDB 3.6. Keep the existing test for version 5.0. That needs to keep the name mongodb
(as opposed to mongodb5.0) because of the automation we have around generating documentation from the metadata.yaml files.
The new mongodb3.6 directory is very similar to the mongodb directory. Here is the output of diff --recursive on the two directories in case it's helpful. In particular, I will point out that metadata.yaml is almost identical, but I had to mark the id field as optional and add an optional field called ms.
diff '--color=auto' --recursive third_party_apps_data/applications/mongodb/centos_rhel/install third_party_apps_data/applications/mongodb3.6/centos_rhel/install
3,4c3,4
< cat << EOF > mongodb-org-5.0.repo
< [mongodb-org-5.0]
---
> cat << EOF > mongodb-org-3.6.repo
> [mongodb-org-3.6]
6c6
< baseurl=https://repo.mongodb.org/yum/redhat/\$releasever/mongodb-org/5.0/x86_64/
---
> baseurl=https://repo.mongodb.org/yum/redhat/\$releasever/mongodb-org/3.6/x86_64/
9c9
< gpgkey=https://www.mongodb.org/static/pgp/server-5.0.asc
---
> gpgkey=https://www.mongodb.org/static/pgp/server-3.6.asc
12,14c12,14
< sudo mv mongodb-org-5.0.repo /etc/yum.repos.d/mongodb-org-5.0.repo
< sudo chown root:root /etc/yum.repos.d/mongodb-org-5.0.repo
< sudo chmod 0644 /etc/yum.repos.d/mongodb-org-5.0.repo
---
> sudo mv mongodb-org-3.6.repo /etc/yum.repos.d/mongodb-org-3.6.repo
> sudo chown root:root /etc/yum.repos.d/mongodb-org-3.6.repo
> sudo chmod 0644 /etc/yum.repos.d/mongodb-org-3.6.repo
17,22c17,21
<     mongodb-org-5.0.14 \
<     mongodb-org-database-5.0.14 \
<     mongodb-org-server-5.0.14 \
<     mongodb-org-shell-5.0.14 \
<     mongodb-org-mongos-5.0.14 \
<     mongodb-org-tools-5.0.14
---
>     mongodb-org-3.6.23 \
>     mongodb-org-server-3.6.23 \
>     mongodb-org-shell-3.6.23 \
>     mongodb-org-mongos-3.6.23 \
>     mongodb-org-tools-3.6.23
24,25c23,24
< sudo systemctl enable mongod
< sudo systemctl restart mongod
---
> sudo systemctl enable mongod
> sudo systemctl restart mongod
diff '--color=auto' --recursive third_party_apps_data/applications/mongodb/debian_ubuntu/install third_party_apps_data/applications/mongodb3.6/debian_ubuntu/install
5c5
< wget --no-verbose --output-document=- https://www.mongodb.org/static/pgp/server-5.0.asc | sudo apt-key add -
---
> wget --no-verbose --output-document=- https://www.mongodb.org/static/pgp/server-3.6.asc | sudo apt-key add -
10c10
< case $osname in
---
> case $osname in
12c12,14
<     echo "deb [ arch=amd64,arm64 ] https://repo.mongodb.org/apt/ubuntu $oscode/mongodb-org/5.0 multiverse" | sudo tee /etc/apt/sources.list.d/mongodb-org-5.0.list
---
>     # The MongoDB repos only have 3.6 for bionic, nothing more recent like focal.
>     oscode="bionic"
>     echo "deb [ arch=amd64,arm64 ] https://repo.mongodb.org/apt/ubuntu $oscode/mongodb-org/3.6 multiverse" | sudo tee /etc/apt/sources.list.d/mongodb-org-3.6.list
15,19c17,19
<     # Debian 11 is not officially supported, so use 'buster'.
<     if [ "$oscode" = "bullseye" ]; then
<       oscode="buster"
<     fi
<     echo "deb http://repo.mongodb.org/apt/debian $oscode/mongodb-org/5.0 main" | sudo tee /etc/apt/sources.list.d/mongodb-org-5.0.list
---
>     # The mongoDB repos only have 3.6 for stretch, not buster/bullseye.
>     oscode="stretch"
>     echo "deb http://repo.mongodb.org/apt/debian $oscode/mongodb-org/3.6 main" | sudo tee /etc/apt/sources.list.d/mongodb-org-3.6.list
29,34c29,33
<     mongodb-org=5.0.14 \
<     mongodb-org-database=5.0.14 \
<     mongodb-org-server=5.0.14 \
<     mongodb-org-shell=5.0.14 \
<     mongodb-org-mongos=5.0.14 \
<     mongodb-org-tools=5.0.14
---
>     mongodb-org=3.6.23 \
>     mongodb-org-server=3.6.23 \
>     mongodb-org-shell=3.6.23 \
>     mongodb-org-mongos=3.6.23 \
>     mongodb-org-tools=3.6.23
diff '--color=auto' --recursive third_party_apps_data/applications/mongodb/metadata.yaml third_party_apps_data/applications/mongodb3.6/metadata.yaml
158a159
>         optional: true  # This is not optional in more recent versions of MongoDB.
173a175,178
>         optional: true
>       - name: jsonPayload.ms
>         type: string
>         description: ''
diff '--color=auto' --recursive third_party_apps_data/applications/mongodb/sles/install third_party_apps_data/applications/mongodb3.6/sles/install
3c3
< sudo rpm --import https://www.mongodb.org/static/pgp/server-5.0.asc
---
> sudo rpm --import https://www.mongodb.org/static/pgp/server-3.6.asc
5,18c5,7
< source /etc/os-release
< SUSE_VERSION="${VERSION_ID%%.*}"
< case $SUSE_VERSION in
<   15)
<     sudo zypper addrepo --gpgcheck "https://repo.mongodb.org/zypper/suse/15/mongodb-org/5.0/x86_64/" mongodb
<     ;;
<   12)
<     sudo zypper addrepo --gpgcheck "https://repo.mongodb.org/zypper/suse/12/mongodb-org/5.0/x86_64/" mongodb
<     ;;
<   *)
<     echo -n "unknown version"
<     exit 1
<     ;;
< esac
---
> # Use the SUSE 12 repo even on SUSE 15, since there is no official repo
> # for MongoDB 3.6 for SUSE 15.
> sudo zypper addrepo --gpgcheck "https://repo.mongodb.org/zypper/suse/12/mongodb-org/3.6/x86_64/" mongodb
21,26c10,14
<     mongodb-org-5.0.14 \
<     mongodb-org-database-5.0.14 \
<     mongodb-org-server-5.0.14 \
<     mongodb-org-shell-5.0.14 \
<     mongodb-org-mongos-5.0.14 \
<     mongodb-org-tools-5.0.14
---
>     mongodb-org-3.6.23 \
>     mongodb-org-server-3.6.23 \
>     mongodb-org-shell-3.6.23 \
>     mongodb-org-mongos-3.6.23 \
>     mongodb-org-tools-3.6.23

Related issue
b/265034366
How has this been tested?
Integration tests ran and passed.
Checklist:

Unit tests

[X] Unit tests do not apply.
[ ] Unit tests have been added/modified and passed for this PR.

Integration tests

[ ] Integration tests do not apply.
[X] Integration tests have been added/modified and passed for this PR.

Documentation

[X] This PR introduces no user visible changes.
[ ] This PR introduces user visible changes and the corresponding documentation change has been made.

Minor version bump

[X] This PR introduces no new features.
[ ] This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
[ ] This PR bumps the version.

Adding release label to make TestMinimumSupportedAgentVersionIsModified happy, as per a discussion with Avi.

The last run was clean enough (no 3p test failures, some ops_agent_test flakes though). And people are waiting on this PR. Merging once unit tests pass.


Fix on click edit mode states (#18321)

fix click code cell

modified editmode when updating active cell

This PR fixes #18299

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 48.234%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
14797

Relevant Lines:
29109

💛  - Coveralls


sessionStorage is not reliable on iOS

Safari on iOS will wipe out sessionStorage just by not being on the tab and loading other resource intensive websites. So this means tabbing away from a generated playlist is highly risky.

We could use localStorage + # in URL with an ID pointing to the localStorage entry


How is the time taken per frame of the function stack recorded？

Hi @denghuihua,
ETTrace saves the stack every 4.5-5ms (here).
Each time we save the stack, we also save the time it was saved using CACurrentMediaTime (here).
Then when creating the flamegraph (here), we use that time to infer the duration of each call.

I understand all of the above answers, but after calculating the stack duration, how to determine the time for each layer of the stack to call the function, I see in the flame diagram that each function in the stack has a time display, how to calculate this

The same logic applies, ETTrace uses multiple recorded stacks to infer the duration of each function call.
Lets say we have these stacks:

Stack s1
Stack s2
Stack s3
Stack s4

main()
main()
main()
main()

func1()
func1()
func1()

func2()

If each stack was recorded every 5ms we can infer that:

main() was executed for 20ms.
func1() was executed for 15ms.
func2() was executed for 5ms.

In the image you shared, the stacks would have this format:

Stack s1
...
Stack n-1
Stack n
Stack n+1

main()
...
main()
main()
main()

UIApplicationMain()
...

UIApplicationMain()
UIApplicationMain()

...

@objc ExploreCardViewController.collectionView(_: didSelectItemAt:)
@objc ExploreCardViewController.collectionView(_: didSelectItemAt:)

...

ExploreCardViewController.collectionView(_: didSelectItemAt:)
ExploreCardViewController.collectionView(_: didSelectItemAt:)

...

protocol witness for ExploreCardViewControllerDelegate.exploreCa....:
protocol witness for ExploreCardViewControllerDelegate.exploreCa....:

...

ExploreViewController.exploreCardViewController(_:didSelectItemAtIndex:)
ExploreViewController.exploreCardViewController(_:didSelectItemAtIndex:)

Thank you very much for your answer, very detailed,I have got it


Slow liquidity test

Description

Type of change

[ ] Docs change / dependency upgrade
[ ] Configuration / tooling changes
[ ] Refactoring
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Requires changes in customer code

High-level change(s) description - from the user's perspective

Related Issue(s)
Fixes
Related pull request(s)

it will be done when doing e2e fixes


[FEATURE] Rotate video in fullscreen mode despite RN settings

In react-native-video player can go to landscape mode if rotation locked to portrait in Xcode settings

I'm also interested in this feature being built in to this project.
I believe you could use https://github.com/yamill/react-native-orientation in tandem with this project. The problem with this approach is that you would have to disable the locked to portrait in xcode because this setting from my R&D experience is that this setting is NOT overwritable with the current libraries and orientation support in React Native.  In your case, the view where react-native-video is being rendered. This is less then ideal but I think would work.

@larryranches Do you know how react-native-video do that without additional setup?

@max-mykhailenko You'll have to use the same approach. The problem is not really the video component. It's the handling of the orientation.

@larryranches I enable only portrait orientation in Xcode Info.plist, but react-native-video rotate according to orientation and never mind to the setting. I'll look sources of react-native-video and maybe find something helpful.

@max-mykhailenko I'm very interested by this feature as well, let me know if you have any leads, I'm willing to contribute. If not, I will try to implement the solution proposed by @larryranches (locking the orientation at the RN level and unlock it while in full screen).

@max-mykhailenko I ended up implementing the solution from @larryranches and it works great!

@wcandillon Are you locking every view in your project then unlocking only the views that you'd like to install landscape?

@larryranches correct.
On my main class I have:
componentDidMount() {
        Orientation.lockToPortrait();
}

@wcandillon Also wondering what Larry asked: are you locking every view in your project then unlocking only the views that you'd like to install landscape?

@GeoffreyPlitt you can lock only root view and all children will be locked. After fixing callbacks for RN 0.40 all works with https://github.com/yamill/react-native-orientation library. Thanks, guys!

I was looking for a feature like this and then I noticed that after updating iOS to 11 I can rotate the video in fullscreen mode without the need of react-native-orientation or any other custom setup. Which is nice.


⚠ ClamAV has degraded performance

In ae09445, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 89 ms

Resolved: ClamAV performance has improved in f6bb44e after 5 minutes.


DateTime Overhaul

Prerequisites

[x] I have written a descriptive issue title
[x] I have verified that I am running the latest version of Nancy
[x] I have verified if the problem exist in both DEBUG and RELEASE mode
[x] I have searched open and closed issues to ensure it has not already been reported

Description
The way Nancy binds and parses bodies and querystring values differs with DateTime objects  This issue is the parent to child issues and PRs whose aim is to investigate and possibly overhaul the DateTime parsing within Nancy.
Issues that need investigating are:

[ ] #2417
[ ] #2426

One thing I think would be useful is a configuration option in Nancy that tells it how to handle DateTime, DateTimeOffset is different and more forgiving.  When a date comes into a request via a querystring or body payload the binder or querystring parsing should read the config option and convert the DateTime to DateTimeKind.Local, Utc, Unspecified, whichever is selected in the config option. This might be another item in the SDHP, ie/they dont have to convert dates in their modules for example to the format that they want to use in their application. Thoughts?

Thoughts on #2417
We have introduced a breaking change between 1.x and 2.x when it comes to the deserialization of JSON. When we replaced the JSON serializer with SimpleJson, we also made a change which means that all DateTime and DateTimeOffset instances will be deserializes with DateTimeStyles.AssumeUniversal | DateTimeStyles.AdjustToUniversal (you can see the SimpleJson code here) and that results in DateTime instances being DateTimeKind.Utc.
Say you now return a model with a DateTime that has a +2 offset, for example 10am in Sweden, which will have something like 1000+2 (because Sweden is currently GMT+2 because of daylight savings time) in the serialized representation. When we deserialize this it will think it needs to adjust that to UTC so it will end up as 0800. In 1.x this would not happen because the deserialization assumed local.
The reason for the change is that we want to follow the ethos

DateTimeOffset in, DateTimeOffset out

The problem is that it will break existing 1.x clients and they would have to have all consumers update their date/time handling. The proposal is that we had a configuration option that let's you specify which DateTimeStyles that should be used, have them default to DateTimeStyles.AssumeUniversal | DateTimeStyles.AdjustToUniversal but would still let older applications change the configuration to use DateTimeStyles.AdjustToLocal. The conundrum is how we get that information into the JavaScriptSerializer, which is what is used by both DefaultJsonSerializer and JsonBodyDeserializer (it's actually only the second one that is important since this is a deserialization concern.
Proposed solution 1 - Add it to BindingConfig
I.e the config that can be passed in to Bind<T> in a module. This would let us control is on a per-bind basis. However, since will only flow to the JavaScriptSerializer via the  JsonBodyDeserializer, since binding does not use DefaultJsonSerializer. This means we would need to hard code values in the DefaultJsonSerializer that is passes to the JavaScriptSerializer when it uses it, even though the values aren't going to have any impact.
The default value would be DateTimeStyles.AssumeUniversal | DateTimeStyles.AdjustToUniversal
Proposed solution 2 - Add a ModelBindingConfiguration environment config
This would let us do
env.Binding(
   dateTimeStyles: DateTimeStyles.AdjustToLocal);

The default value would be DateTimeStyles.AssumeUniversal | DateTimeStyles.AdjustToUniversal
Both DefaultJsonSerializer and JsonBodyDeserializer already have access to the INancyEnvironment and already use it to pass configs into the JavaScriptSerializer.
However I don't feel this sits quite right because it's not really only related to model binding, but more to JSON (de)serialization in general, which leads me to proposal 3
Proposed solution 2 - Add option to the JsonConfiguration environment config
We already have a JsonConfiguration environment config and since  DefaultJsonSerializer and JsonBodyDeserializer already have access to the INancyEnvironment and already use it to pass configs into the JavaScriptSerializer, this sounds like a clear winner. It would not let us do per-bind decisions on this, but it would not prevent anyone from doing that conversion themselves if/when they need it.

Thoughts on #2426
tl;dr The DynamicDictionaryValue does DateTime parsing in two places(#1 and #2) and neither assumes UTC. This means that we know have different behavior between DateTime parsing in DynamicDictionaryValue and how JSON deserialization treats them.
The problem is that we have no, obvious, way of injecting any config values into DynamicDictionaryValue to let the user define the expected behavior.
Thoughts on solutions?!
ping @NancyFx/most-valued-minions

#2417 proposed solution 2 makes sense to put it in the JsonConfiguration
#2426 only thing I can thing is to make Default and TryParse take the JsonConfiguration as a second method argument so users can choose.  If it's not provided we use JsonConfiguration.Default in DynamicDictionaryValue

Addressed by https://github.com/NancyFx/Nancy/pull/2438/ & https://github.com/NancyFx/Nancy/pull/2454


ADD querystring flags to force h264 and dtx

@ggarber I'm no sure if I'm not testing things correctly but I can't get H264 to work. I'm just testing locally going to localhost:5000/room?h264=true and when I use Chrome to Chrome and look in webrtc-internals I just see normal VP8.

When I do Firefox to Chrome though I get VP9??

Am I missing something? Did I break something in my refactor?

@ggarber ok, I added a simple test that just makes sure that you can successfully connect and subscribe when you turn on h264.

@aullman

It is what I tried to (badly) explain in slack.  You need to load part of the hack before opentok.js and the other part after opentok.js.  That's the reason why I had 2 scripts in webpack configuration.   I'll try to fix it.

H264 should work with fake devices.  Devices and codecs should be independent.    I wouldn't waste lot of time with this though.  It is very hacky no matter what and not business critical.

Firefox to Chrome VP9 is very surprising.  I will review that.

@aullman

It was not working because I test it with Chrome Canary and you probably used Chrome and apparently the payload types have changed.  I fixed it to support both version now.

VP9 in Firefox was happening because your firefox version doesn't support H264 (it happens to me too if use Stable instead of Nightly).  I fixed to make the rule more strict, now it will never use VP9.

I think tests should work fine with fake devices.   I'm not sure how much effort we should put in this though if it is very hacky no matter what.  Maybe it is better to work first on exposing in opentok.js the APIs needed to configure the codec list and/or manipulate the SDPs properly.  But I let you decide :)

Thanks @ggarber looking good. I also added the video codec to the stats drop down using the QOS event from the subscriber. I also added a quick test that verifies that the stats show the H264 codec if you pick H264. It only works in Chrome because Firefox still doesn't have the codec name in the stats.


Disable auto turn and re-enable enemy

To leverage the auto turning towards the enemy, the enemy is constantly set to zero. This causes limitations for other uses. Instead disable auto-turning somewhere else. (0x737CD0 void __thiscall oCNpc::TurnToEnemy(void))

See branch autoTurn


docs/control-service: update contributor documentation

Why?
Contributor doc for control-service is inaccurate and hard to use
What?
Restructure document so how-to-run sections are at the beginning Update running locally section with correct instructions
How has this been tested?
Ran the service locally using updated instructions
What type of change are you making?
Documentation change, non-breaking

If there's a ticket issue, please link it.


Modal transition glitches if one modal is hidden and other shown at the same time (iOS only)

Environment
  Expo CLI 3.27.14 environment info:
    System:
      OS: macOS 10.15.5
      Shell: 5.7.1 - /bin/zsh
    Binaries:
      Node: 10.20.1 - /var/folders/kc/w3zg_rmd6vnd_5w22fw154yh0000gn/T/yarn--1602600352442-0.37023497130992244/node
      Yarn: 1.22.5 - /var/folders/kc/w3zg_rmd6vnd_5w22fw154yh0000gn/T/yarn--1602600352442-0.37023497130992244/yarn
      npm: 6.14.4 - ~/.asdf/installs/nodejs/10.20.1/bin/npm
    SDKs:
      iOS SDK:
        Platforms: iOS 14.0, DriverKit 19.0, macOS 10.15, tvOS 14.0, watchOS 7.0
    IDEs:
      Xcode: 12.0.1/12A7300 - /usr/bin/xcodebuild
    npmPackages:
      expo: ~39.0.2 => 39.0.3
      react: 16.13.1 => 16.13.1
      react-dom: 16.13.1 => 16.13.1
      react-native: https://github.com/expo/react-native/archive/sdk-39.0.3.tar.gz => 0.63.2
      react-native-web: ~0.13.12 => 0.13.18
    Expo Workflow: managed

Platforms
iOS only
Versions

iOS: simulator, 14.0.1
react-native-modal: 11.5.6
react-native: 0.63.2
react: 16.13.1

Description
When switching between two modals using the same piece of state, on iOS the animation glitches and the 2nd modal never shows up. It's there and it's covering the content, breaking any pressable buttons underneath but it's not visible (can be made visible by manually switching the isVisible prop off and on in React Native Debugger).
This does not happen on Android (there's a bit of visual glitching but otherwise it's fine) but does so on both iPhone and the simulator.
Reproducible Demo
https://snack.expo.io/gRtAP3xNO

Open demo on iPhone or download it and open locally on the iOS simulator
Press Trigger first modal
Press Trigger second modal

Expected outcome:
First modal fades away and second modal takes its place
Actual result
First modal disappears but second modal never shows up.
Note
This might be a duplicate of #481 or they may have a similar root cause
Workaround until this issue is fixed

Don't use one piece of state to switch between two modals
When switching between modals, close the first one and wrap the code flipping the visibility of the second one in InteractionManager.runAfterInteractions to allow the first fade out animation to finish

+1

We encountered the same issue with two modals shown in different scenes:
Scene one has a modal. Clicking in the modal navigates to Scene two while hiding it.
Scene two starts with a different modal being shown.
The modal in scene two was not visible and was blocking all interaction with the scene.
We managed to make it work with the workaround that @d4rky-pl suggested.

We ran into a similar issue when showing a second modal after a button is pressed on a first modal.
I added a timeout while setting the second modal's visible to true and it worked.
I start to doubt that issue is not with react-native-modal and due to react-native's re-rendering.
For anyone looking for a solution, try adding a timeout for the first state to resolve. Not the most elegant solution, but it works.

No need for any timeouts here. It's a well-known issue: you can't just simultaneously switch between modals. It's also bad for UX. Instead, you should wait for one modal to finish its closing animation (by using onModalHide), and only after that show another modal.

Well, that should be documented somewhere (or if it is documented, somewhere more obvious)

Thanks @pistonsky :)
@hbiede it's documented in the FAQs https://github.com/react-native-modal/react-native-modal#i-cant-show-multiple-modals-one-after-another
Feel free to submit a PR to improve the docs 👍

Even when using onModalHide I'm running into issues when I want to display for example a Alert.alert from onModalHide...
It will show up for a split second and dissapear.
If I use setTimeout(func, 10), it will work. Has anyone else encountered this?

Even when using onModalHide I'm running into issues when I want to display for example an Alert.alert from onModalHide...
It will show up for a split second and disappear.
If I use setTimeout(func, 10), it will work. Has anyone else encountered this?

This should’ve been solved in #491. You should be able to use () => InteractionManager.runAfterInteractions(func) in onModalClose


Way to disable icons?

I was wondering if you could add a config to remove item icons, because I’m using the Runtime Icons mod and I’d like the scrap from this mod to look like other icons from the mod, and same with the equipment

Wouldn't it make more sense to ask them for a config to override all item icons? Adding a config to remove my icons would be a lot of work for a very specific issue, if even possible. My icons are set in unity and not in code so I'd have to figure out how to reference each individual item's icons and etc..

I was referring to asking the author of runtime icons to make an override all icons config. Anyways, sorry.


[Question]: Are events are 'replayed' after the managed controllers are scaled up?

Very cool stuff ! Thanks for open sourcing it.
My initial question though is (without having even tried the controller-zero-scaler), how can the API CR event, which triggers the upscale of a sleeping controller/operator be replayed so that it can be consumed by the controller after it started up again ? Is there a mechanism to re-feed events or is it the task of the controller/operator that starts up to evaluate the current state (which he needs to do anyway during startup I guess) ?

when the controller starts it receives all events it watches for, at least when the implementation is backed by the go k8s client.


fix(challenges): Tests are not shown on visiting challenges for the first time

Closes #16948

Pre-Submission Checklist

[x] Your pull request targets the staging branch of freeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[x] Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #16948
Description

When you visit a challenge, the test sometimes are not showing. This pr solves that issue.
To reproduce the issue:
Open a block(here a request is being made to the server for the block's data) then quickly select a challenge inside that block before the response from the server for that block request arrives.
how to store looks that is related for reference:
 store: {   entities: {     challenge: {       challengename: {         challengeinformation       }     }   },   challenge: {     tests: {       here are the tests     }   } }
The cause:
The lesson pane is where the tests and other information of the challenge is shown. This pane has selectors for the information of the challenge. Every selector points for the information of the challenge in the store to "entities: challenge: challengename: challengeinformation" except the tests selector. The tests are stored in "challenges: tests". When the block data arrives from the server it updates the "entities" where the information of the challenge is being stored, but the "challenges" where the tests are being selected from is not getting updated. Because of this when you reproduce the issue successfully, you are going to see the skeleton loading of the challenge in the lesson pane, but tests are going to be already displayed incorrectly(meaning they have been selected already but since there were no data yet the tests array is going to be empty), and when the block data arrives, the skeleton loading is being replaced, but the tests are not.
ds
This solution:
The "app.fetchNewBlock.complete" action is now going to have the challenge information that is currently selected if there is a challenge currently selected. This action is going to also arrive now in the challenges reducer with the currently selected challenge. In this reducer if there is a challenge in the payload, its going to update the "challenge" part of the store which contains the tests that are being selected in the lesson pane.
Related files:
Lesson pane to check the selectors.
fetchNewBlockCompleted this updates the "entities" but not the "challenge" where the tests are.
Reducer of challenge this is where the tests are being updated.
There may be better solutions but atleast you can indentify the problem from this. Hopefully my explanation is not gibberish.

@absolitudo Thank you for your work on this, sorry for the delay in getting round to it.
Are the tests available under store.entities the way the rest of the challenge data is? If so, can you update the testsSelector to access them there.
The fetchChallenge reducer deals only with the fetching of the current challenge after a direct navigation, i.e. navigation the the challenge URL rather  than clicking on the map or completing a challenge.

Are the tests available under store.entities the way the rest of the challenge data is? If so, can you update the testsSelector to access them there.

Yes they are available there, but there are a couple of problems that need to be considered. One is that the tests are not in the format that the component is able to display them. The tests go through a function called "createTests". This function is here: https://github.com/freeCodeCamp/freeCodeCamp/blob/30b26e1476eb2e40695256c5e060c2d804138789/common/app/routes/Challenges/utils/index.js
The selector could use this function to format the tests.
The other problem is related to executing the challenge. I don't completely understand what is happening when you execute the challenge but at least in the challenge reducer the tests are being used from store.challenge.tests so in order for that to still work the tests would need to be present there. The current bug is produced because in store.challenge.tests no tests are present.
The reducer: https://github.com/freeCodeCamp/freeCodeCamp/blob/167b60985353ccce69181cbe7d365d3cafb69c49/common/app/routes/Challenges/redux/index.js
ctrl + f: types.executeChallenge

Hi @absolitudo once again!
I have replied on https://github.com/freeCodeCamp/freeCodeCamp/pull/16986
Once again thanks a lot for taking the time to make this pull-request.
Happy contributing!


Reduce docker image size for runtime usages

Checklist

[X] I've read the contribution guidelines.
[X] I've searched other issues and no duplicate issues were found.
[X] I've agreed with the maintainers that I can plan this task.

Description
Originated from discussion  posted by @kasperornmeck in https://github.com/autowarefoundation/autoware/discussions/2780_
Purpose
Reduce docker images size for runtime environment where unnecessary software could be removed from development environment and reduce the disk space used.
Current status
Details of the container used in the analysis:

REPOSITORY: ghcr.io/autowarefoundation/autoware-universe
TAG: galactic-20220728-prebuilt-cuda-arm64
IMAGE ID: 8b7fbc56f6bf
CREATED: 8 days ago
SIZE: 19.3GB

Definition of done

[ ] runtime dependencies analysis
[ ] reduce sized docker image for runtime

With docker image built from nvidia/cuda:11.4.0-runtime-ubuntu20.04, and runtime dependencies installed for autoware, the disk usage of /usr/local/cuda-11.4 folder could be reduced by 2.2GB.
Original:   4.0G    /usr/local/cuda-11.4
New:        1.8G    /usr/local/cuda-11.4

Currently I'm thinking of two approaches of this work:

Reduce size of prebuilt image
Considering the prebuilt images is for users to try out Autoware quickly, dev environment could be remove from it.

Keep current prebuilt image and build another runtime image
This allows users to rebuild partial of Autoware, not the whole project using prebuilt image, then runtime image may be provided just for execution.

The main concept of size reducing:

Only use runtime libraries for CUDA/TensorRT (This could save ~2.2GB)
Only copy the install folder or maybe also keep src folder (This could save up to ~3.3GB)

@kenji-miyake, what's your opinion about it ?

@Sharrrrk Thank you for investigating this issue!
I totally agree with you, and either option seems okay. The first option would be better as a first step because it's simpler.

@Sharrrrk thanks for taking this on!
For inspiration, you could take a look at the images layers which ROS and NVIDIA have used to create their Docker images. See

https://github.com/osrf/docker_images/blob/3f4fbca923d80f834f3a89b5960bad5582652519/ros/galactic/ubuntu/focal/ros-core/Dockerfile
https://hub.docker.com/layers/nvidia/cuda/11.4.2-runtime-ubuntu18.04/images/sha256-9fd4770341bd8f2cd754b70d552dfd0cc5e6e3ed1406449f00b1c5bb944133b0?context=explore

I'd recommend building up a new container and not removing from an existing one.

Hi @kasperornmeck, I looked into the docker file of Nvidia and ROS, Nvidia used a script from outside to install all the packages, and for ROS, it's just like what have been implented in current ansible script. So I would say that use nvidia runtime docker image as base would be a good and neat approach. I will modify the ansible srcipts (add a variant that only installs runtime dependencies) and the Docker file (use mutlti stage build) of course, so that the prebuilt image could reduce it's size in later build.

Hi @Sharrrrk
I was installing the NVIDIA driver using the runfile (local) method. You might already be aware of this but you can install only the driver, or any of the other software by selecting/deselecting, e.g., all the runtime dependencies.
lqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqk
x CUDA Installer                                                               x
x - [X] Driver                                                                 x
x      [X] 515.65.01                                                           x
x - [ ] CUDA Toolkit 11.7                                                      x
x    - [ ] CUDA Libraries 11.7                                                 x
x       + [ ] CUDA Development 11.7                                            x
x       - [ ] CUDA Runtime 11.7                                                x
x            [ ] cuda-cudart                                                   x
x            [ ] cuda-nvrtc                                                    x
x            [ ] libcublas11                                                   x
x            [ ] libcufft                                                      x
x            [ ] libcurand                                                     x
x            [ ] libcusolver                                                   x
x            [ ] libcusparse                                                   x
x            [ ] libnpp                                                        x
x            [ ] libnvjpeg                                                     x
x    - [ ] CUDA Tools 11.7                                                     x
x       + [ ] CUDA Command Line Tools 11.7                                     x
x       + [ ] CUDA Visual Tools 11.7                                           x
x    - [ ] CUDA Compiler 11.7                                                  x
x         [ ] cuda-cuobjdump                                                   x
x                                                                              x
x Up/Down: Move | Left/Right: Expand | 'Enter': Select | 'A': Advanced options x

Hi @kasperornmeck  thanks for the information, I will compare the docker size between manually install and cuda-runtime.

Currently I have started to change Dockerfile and ansible scripts, the main ideas:

Use cuda runtime images as base

Only runtime packages of TensorRT are installed

Only minimal set of ROS packages are installed

Multistage image build, copy install folder

@Sharrrrk have you created a PR for these changes? If so, please link it to the Issue.

I've created this discussion on re-layering of the dockerfile/image:
https://github.com/orgs/autowarefoundation/discussions/3469

Merge this issue with https://github.com/autowarefoundation/autoware.universe/issues/4111.

Closing this issue since it will be addressed by:

https://github.com/autowarefoundation/autoware/issues/3999


Implement user suspension

There are cases you would want a use to not have access but not have their account deleted. Example: late payments

@SonarBeserk I'm going to add this in soon. Would you mind if the actual servers get suspended, rather than the user itself? (References #498)

#498 is desired to allow things like archiving servers where they exist but may not be booted. Where as this is for the purpose of locking all servers of a user until they pay up.


Update camp to v0.2.0

@davidbeckingsale is this is mislabeled? You updated to camp v0.2.2, correct?


Adding Favicon to the website

Hey @akshitagupta15june I want to add favicon to this website as well as it looks a bit odd without the favicon.

Please assign this issue to me @akshitagupta15june

@akshitagupta15june I can work on this, issue this to me

Hey @akshitagupta15june I think I can contribute to the project by adding it. Please assign it to me.

Hey @akshitagupta15june I think I can contribute to the project by adding it. Please assign it to me.

@akshitagupta15june This issue is solved in #332 , Do review it thank you


Constructor + Deconstructor CTD

Issue description:
A combination of constructor and destructor with a fortune III upgrade results in a crash to desktop.
What happens:
It crashes to desktop.  When loading back into game everything works fine and constructor/destructor performs as expected.
What you expected to happen:
It to not crash to desktop.
Steps to reproduce:

Seed constructor with an ore - tested with both Biomes O' Plenty amber ore and Draconic Evolution draconic ore - likely to occur with any ore.
Flip destructor to ignore redstone mode.
Flip constructor to ignore redstone mode.
...
Profit?

Version (make sure you are on the latest version before reporting):

Minecraft: 1.12.2
Forge: <IP_ADDRESS>19
Refined Storage: 1.12.2-<IP_ADDRESS>

Does this issue occur on a server? [yes/no] no
If a (crash)log is relevant for this issue, link it here:
[pastebin/gist/etc link here] https://pastebin.com/3Hvh5QSh

Feed the beast utils error

Oh, should this bug report be routed to FTBUtils?

Yes


”Căpleni” is listed in the drop-down menu

Description:
"Căpleni" is listed in the drop-down menu alongside its corresponding county and commune, according to the law.
Precondition:
The website is up an running.

Step 1
Type "Căpleni" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Căpleni, SATU MARE (Căpleni)".


Add user-agent creation to e2e tests (name+step)

Go beyond our go-client library and try to find test name and step.

Turns out setting user-agent is pretty hard if you want any detail, and it's complicated by our use of ConformanceIt() wrapper for It().
When I initially looked at using BeforeEach(), I saw that it was the same line every time, so I spent some time exploring solutions deeper into gingko and client-go.
However when we use the ConformanceIt() wrapper, the source is always 'k8s.io/kubernetes/test/e2e/framework/framework.go:757' :
k8s.io/kubernetes/test/e2e/framework/framework.go:757 -- [sig-apps] StatefulSet [k8s.io] Basic StatefulSet functionality [StatefulSetBasic] should perform rolling updates and roll backs of template modifications [Conformance]
k8s.io/kubernetes/test/e2e/framework/framework.go:757 -- [sig-auth] ServiceAccounts should allow opting out of API token automount  [Conformance]
k8s.io/kubernetes/test/e2e/framework/framework.go:757 -- [sig-auth] ServiceAccounts should mount an API token into pods  [Conformance]
k8s.io/kubernetes/test/e2e/framework/framework.go:757 -- [sig-cli] Kubectl client [k8s.io] Guestbook application should create and stop a working application  [Conformance]

However for all other tests (which I wasn't running initially) it supported giving proper line numbers.
k8s.io/kubernetes/test/e2e/kubectl/portforward.go:496 -- [sig-cli] Kubectl Port forwarding [k8s.io] With a server listening on localhost [k8s.io] that expects NO client request should support a client that connects, sends DATA, and disconnects
k8s.io/kubernetes/test/e2e/network/dns.go:158 -- [sig-network] DNS should provide DNS for ExternalName services
k8s.io/kubernetes/test/e2e/framework/framework.go:710 -- [sig-cli] Kubectl client [k8s.io] Kubectl cluster-info should check if Kubernetes master services is included in cluster-info  [Conformance]
k8s.io/kubernetes/test/e2e/storage/persistent_volumes-local.go:562 -- [sig-storage] PersistentVolumes-local  StatefulSet with pod affinity should use volumes on one node when pod has affinity

The simple approach of just including the test description test was however merged.
Merged: https://github.com/kubernetes/kubernetes/pull/67550


Add global box-sizing: border-box rule

This pull request adds a global box-sizing: border-box; rule to all elements, ensuring more predictable element sizing by including padding and borders within the total width and height of elements.
Before

After

@fahdi


[WIP][MINOR][INFRA] Increase GitHub Action Maven connectionTimeout

What changes were proposed in this pull request?
This PR increases Maven's connectionTimeout  from 1 minute (default) to 3 minutes.

https://maven.apache.org/guides/mini/guide-http-settings.html#Connection_Timeouts

<settings>
  <servers>
    <server>
      <id>central</id>
      <configuration>
        <httpConfiguration>
          <all>
            <connectionTimeout>180000</connectionTimeout>
          </all>
        </httpConfiguration>
      </configuration>
    </server>
  </servers>
</settings>

Why are the changes needed?
Although we added Maven cache inside GitHub Action, the timeouts happen too frequently.
[ERROR] Failed to execute goal on project spark-mllib_2.12:
...
Connection timed out (Read failed) -> [Help 1]

Does this PR introduce any user-facing change?
No.
How was this patch tested?
This PR is irrelevant to Jenkins result. This should succeed in GitHub Action.

Test build #114973 has started for PR 26790 at commit 1620cd4.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19794/
Test PASSed.

Hi, @HyukjinKwon, @srowen , @wangyum .
Could you review this PR? Currently, mvn build timeout occurs at GitHub Action job.
This happens when the caches are invalidated. I hope this will recover this flakiness.

Oops. It seems that we also need to increase Connection timedout.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19795/
Test PASSed.

Hi, @maropu . Could you review this PR, please?

Test build #114974 has started for PR 26790 at commit 9654426.

Test build #114975 has started for PR 26790 at commit 3592088.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19796/
Test PASSed.

Oh! closed?

Oops. Sorry, I didn't notice you came to my PR. Here, I tried three approaches but there was no luck. I moved to my personal repository to test this. I'll came back with a verified solution.

https://github.com/dongjoon-hyun/spark/pull/11

Thank you, @maropu !

The last run here (with 3 min limit) is still running. But, I guess I need to repeat multiple times to verify this.

https://github.com/apache/spark/commit/35920881a2c44a1fba6b0a6d3c28116fcedd6ac5/checks?check_suite_id=346818032

And, master branch came back with green with your last commit. So, it seems that the rush-hour time congestion goes away. :)

https://github.com/apache/spark/commit/e88d74052bf40eabab9e3388fa09e52097ffa3aa

hahaha, I see. Nice.

Test build #114973 has finished for PR 26790 at commit 1620cd4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114973/
Test PASSed.

Test build #114974 has finished for PR 26790 at commit 9654426.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #114975 has finished for PR 26790 at commit 3592088.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114975/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114974/
Test FAILed.

Hi, All.
I made a PR for this.

https://github.com/apache/spark/pull/26793


cannot use 'g' key when writing posts

Not sure if this was broken by #26 or something earlier, but if I try replying to a post now, the g key does nothing although all other keys work fine.  If I disable the extension the g key works perfectly again.

Shoot, I'm sure that's what did it. I'll get it fixed today. Thanks for point it out!

This should be fixed by #29
Thanks for sending this in, I appreciate it. New build should be live in Firefox now, imagine Chrome will follow later today.
Time for me to write some tests 😅

Seems fixed now, thanks so much!!


Question: Process name for all processes in active space

Is it possible to have the process names for all processes in the active space? Instead of having only the process name of the active window and symbols for all other processes.
Example (active window in bold):
Now:  symbol | symbol | terminal | symbol
Would like to have: firefox | terminal | terminal | vscode
Thanks for your help!

I added a new setting (defaults to false): "Expand all processes". It forces open all processes. The current one is highlighted as before.

Let met know if this is what you had in mind.


Debug console not shown on "export project" with "export with debug"

Godot version
Godot 4 Alpha 2
System information
Windows 10 Intel 4690k GTX 1060
Issue description
Exporting a game via "export project" with "export with debug" does not show the console
Related : #56884
However, that one is focused on the export all, not "export project", but similar field.
Steps to reproduce

Open Godot 4 ALpha 2
Install export templates
Export game as project with "export with debug" enabled
Game will not have a console

Minimal reproduction project
Uploading Bugged Export.zip…

Does reverting https://github.com/godotengine/godot/pull/56012 and compiling a debug export template fix the issue for you?

Otherwise you can ship your debug build with a .bat file that runs the project in a console explicitly, like we do for Godot itself.

Creating this .bat file automatically for projects exported in debug mode sounds interesting.

Creating this .bat file automatically for projects exported in debug mode sounds interesting.

Should be easy to add, I'll take a look tomorrow.

Should probably be opt-in, and implemented for macOS and Linux debug exports too?

Should probably be opt-in, and implemented for macOS and Linux debug exports too?

I'm not sure if it needs to be opt-in, unless we want to expose this for projects exported in release mode as well. If you really don't need it for a project exported in debug mode, you can remove the .bat file after exporting the project.

I know that this has been fixed now, but is there an example of the .bat file for exported console? I kinda wanna try something before Alpha 5.


Test migration of a 5.0 database

Take a 5.0 database and point a 6.0 stroom at it and check that the migrated data is still valid.

Migration successful for pre-prod 1, 2, and 3.


[BUG]: POI sensor listed first in build menu, lacks subcategory

Description of the bug/crash
The POI sensor building from Rocketry Expanded mod is listed as very first in the "Automation" build menu.
The call to AddBuildingToPlanScreen() for it needs "sensors" as the 3rd parameter.
Steps To Reproduce

Click 'Automation' build icon at the bottom, see where the sensor building is.

Player.log
N/A

thx for the report, fixed in next update


client.BeginTx does not set transaction context

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

When using the generated ent.Client to start a database transaction with the BeginTx method, the Tx struct's go-context field (ctx) does not get populated. This leads to hard-to-debug errors, as transaction commit hooks use this exact context in the ent.CommitFunc. The result is a nil-pointer-panic because of the missing context.
Expected Behavior 🤔

I would expect that BeginTx(...) should populate the ctx field, ergo the same behavior as Tx(...). This is not the case.
Steps to Reproduce 🕹

var client *ent.Client
// connect to your database...

ctx := context.Background()
tx, err := client.BeginTx(ctx, &sql.TxOptions{Isolation: sql.LevelSerializable})
if err != nil {
    panic("out of scope of this bug report...")
}

tx.OnCommit(func(next ent.Committer) ent.Committer {
    return ent.CommitFunc(func(ctx context.Context, tx *ent.Tx) (err error) {

        if ctx == nil {
            panic("this will panic.")
        }

        return next.Commit(ctx, tx)
    })
})

_ = tx.Commit()

Your Environment 🌎

Tech
Version

Go
1.17.5

Ent
0.9.1

Database
Postgres

Driver
github.com/lib/pq

Thanks for reporting this issue @lukasbraach 🙏
It looks like Client.BeginTx is not aligned with Client.Tx. Do you want to send a patch to fix this? 😃

@a8m can I take this one on?

@a8m Can I take this one on?

Sure, go ahead.

@a8m I don't think I have permission to push up a new branch. Can you add permission to me or do I need to be assigned to the issue to be given permission?

Hey @ItsATrap48, you need to fork this project to your account. Then create a new branch on it. Later, you open a PR for the request to merge.

Hello, I'd like to contribute on this one could you see my PR please? 😃
(my first public commit, my apologies if anything wrong)


Unable to proceed with extension authoring/development

Issue Type: Bug
Steps to Reproduce:

Install Azure Data Studio 1.31.0 (Aur for Manjaro, Windows by Microsoft Site)
Using yo azuredatastudio (if needed see https://github.com/llali/generator-azuredatastudio) create a new extension called ads-test-ext (using typescript
Open ads-test-ext folder with Visual Studio Code (v 1.58.2)
Install in Visual Studio Code the extension with id: ms-mssql.sqlops-debug
Run the project with F5
Now Azure Data Studio will open with DevTool Window and there are no way to proceed with extension development (see https://imgur.com/a/chxx9RM)
All this step are working with Azure Data Studio 1.30.0

Azure Data Studio version: azuredatastudio 1.31.0 (a430fd2592763ef4c4a406821967e4b7b2b3d876, 2021-07-20T19:40:24.296Z)
OS version: Linux x64 5.12.16-1-MANJARO

System Info

Item
Value

CPUs
AMD FX(tm)-8320 Eight-Core Processor (8 x 4018)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onrasterization: disabled_softwareskia_renderer: enabled_onvideo_decode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
1, 1, 1

Memory (System)
15.61GB (1.61GB free)

Process Argv
--no-sandbox --unity-launch --no-sandbox

Screen Reader
no

VM
0%

DESKTOP_SESSION
plasma

XDG_CURRENT_DESKTOP
KDE

XDG_SESSION_DESKTOP
KDE

XDG_SESSION_TYPE
x11

Extensions: none

@faraoman, can you open an issue in that repository?

Closing since the issue has been moved to different repro.  Thanks for your interest in extension development!


Cookie session

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @akelyasir, I understand what you mean. You put JWT token in the cookies header instead of authorization header. A pull request couldn't modify existing features. I will implement this feature in next release.


Cloudspanner reuse instance and database

Separate cloud spanner instnace lifecycle from perfkit resource lifecycle.

I signed it!

I signed it!

I signed it!

@googlebot I signed it!

@googlebot I signed it!


Move content from cwiki to website (FAQ movement)

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.

What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

FAQs _ Apache Hudi!.pdf
@vinothchandar please have a look.
Once you approve this, we can actually delete the content from cwiki and leave a comment to redirect users to this page on website. :)

@pratyakshsharma thanks for doing this. the page itself looks good. however, there may be some broken links here. esp links to configs. Could we also fix that in this PR.
+1 on deleting the previous page.

@vinothchandar There are no broken links here. I have fixed them already. You can try building this on local to reconfirm. :)

@vinothchandar Please take a look. Fixed all the broken links now.

Thanks for this @pratyakshsharma !


fix(scf): publishing status check

:tada: This PR is included in version 1.12.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Auto Assign Does Not Recognize Pages

Auto Assign Files function does not recognize pages as a level within the archival hierarchy.

Isn't really a bug. Carpenters only recognizes these container types:
b: 'Box',
c: 'Cabinet',
d: 'Drawer',
f: 'Folder',
i: 'Item',
t: 'Tube'
If a new type page is needed then this will be a added feature.

@seanlw The app won't let me assign any more files after those error messages. That seems like a bug.

@metaweidner that's the correct behavior since it can't find the correct location because of the unknown type. Carpenters won't guess at where to put it.

Page seems to be a new container

@seanlw I loaded the images and attempted to auto-assign. It gave me those messages. Now I can't drag any of the files from the built in assignment window or the windows file viewer. The app is completely frozen. Had to end the task from the task manager.

That sounds like a different issue than the auto assignment error. It just got triggered during that event.

This issue is no longer relevant since we removed the load files interface.


Unabbreviate TOC

TOC is not a common abbreviation for Table of Contents :)

Glad to have a college grad on board <3


Apply various small improvements to keymap

Coverage increased (+0.2%) to 56.702% when pulling 21e1b8bf4a247fe416c9f493cdb5189a03d7ac9f on dennisschagt:feature/improve-keymap into 5c948956774403f39e812649348fedad34089ce6 on newsboat:master.

Thanks for the review!


Make graphsage node attribute inference reproducible

What's the status of this? There's several PRs that would benefit from building some sort of abstraction around per-epoch random state generation (e.g. #848, #879).

There's still some failing tests I need to fix. Are you talking about ConcurrentGraphWalk? I can prioritise this if it's blocking

Yeah, ConcurrentGraphWalk. It'd be convenient if there was some sort of abstraction to manage the randomness sources. Potentially that could be landed as a separate PR that just adds that abstraction without changes to GraphSAGENodeGenerator.

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@7060903). Click here to learn what that means.
The diff coverage is 97.6%.

@@            Coverage Diff            @@
##             develop    #844   +/-   ##
=========================================
  Coverage           ?   82.3%
=========================================
  Files              ?      45
  Lines              ?    4913
  Branches           ?       0
=========================================
  Hits               ?    4044
  Misses             ?     869
  Partials           ?       0

Impacted Files
Coverage Δ

stellargraph/utils/saliency_maps/__init__.py
100% <ø> (ø)

stellargraph/core/convert.py
100% <100%> (ø)

stellargraph/mapper/sampled_node_generators.py
93.6% <100%> (ø)

...rgraph/utils/saliency_maps/integrated_gradients.py
95.7% <94.5%> (ø)

stellargraph/core/graph.py
98.5% <96.3%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7060903...33ac06c. Read the comment docs.


JSON from resp.media is not recognized

It seems this only works as expected if JSON is rendered via resp.text; however, the most idiomatic and succinct way of writing a JSON API is by leveraging req.get_media() and resp.media.
Test case used:
import falcon
from falcon_api_browse import HTMLResponseMiddleware

class Hello:
    def on_get(self, req, resp):
        resp.media = {'message': 'Hello, World!', 'cool': True}

app = falcon.App(middleware=[HTMLResponseMiddleware()])
app.add_route('/hello', Hello())

@vytas7 I started off with resp.text initially as Mailman used that API, but I've migrated to using resp.media now. I can make the change here, but I was wondering what would be the right way to capture the response content regardless of the way it was set?
Would response.render_body() be the best API? It seems to take into account whether resp.text or resp.media is set and uses the appropriate media handler for serialization as well.

Affirmative, resp.render_body() is probably the best option. At least I've gone that route in the ASGI tutorial; see Caching Responses.
There is one caveat, however, that this approach currently doesn't support resp.stream. But maybe it's an acceptable tradeoff given that few would stream JSON?

Note that render_body() is a new API in 3.0; so if you want to support Falcon 2.0, you'll need to shim this by reading back the resp.data property. However, given that you're referencing resp.text which is new in 3.0 anyway, maybe you can drop Falcon 2.0 support from pyproject.toml?

@vytas7 Thanks, I think that makes sense to drop support for 2.x since upgrade to 3.x hasn't been difficult, atleast in Mailman.

There is one caveat, however, that this approach currently doesn't support resp.stream. But maybe it's an acceptable tradeoff given that few would stream JSON?

Yeah, I think we should be fine without resp.stream, we can come back to this later. YAGNI.


New SIGNL4 alerting article

Purpose of this pull request
This pull request (PR) adds a new SIGNL4 alerting article originally submitted by @rons4 in PR #3142. It adds this article:
https://help.sumologic.com/docs/alerts/webhook-connections/signl4
Issue number: #3111

Select the type of change:

[ ] Minor Changes - Typos, formatting, slight revisions
[ ] Update Content - Revisions and updating sections
[x] New Content - New features, sections, pages, tutorials
[ ] Site and Tools - Updates, maintenance, and new packages for the site, Gatsby, React, etc

Thanks for the review, @kimsauce. I committed your suggestions.


BTC Explorer not loading after update 1.5.3 to 1.6.0

I noticed that when BTC Explorer runs on the old version of Raspiblitz, it does not work after upgrading to 1.6.0. I did see in the logs that it was installed and enabled, but the webinterface is not accessible.
I removed BTC Explorer using the menu, and re-installed it using the menu and then it works.

As candle reported there was an outage at NPM .. future versions will make better "error detection" on the installs to notify the user on it: #1419

Just tested the install of the Explorer again and it all looks good. Closing issue.


Specify PHP versions explicitly

That way we know which version is actually installed, instead of the versions depending on when the layers were built.
That will also help with the general flow: contributors can send PRs to increase PHP versions when they come out. Instead of randomly having to rebuild layers in the hopes that it will bundle a new PHP version.

ARM doesn't build on GitHub Actions for some reason atm.


The example code given on the github default page does not work

The example code given on the github default page does not work:
The line:
matcher = DependencyTreeMatcher(doc.vocab)
Gives the error:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
NameError: name 'DependencyTreeMatcher' is not defined

If I replace this with:
matcher = DependencyMatcher(doc.vocab)
It then errors futher down on:
matcher.add('pattern', None, pattern)
matches = matcher(doc)
for match_id, token_idxs in matches:
     tokens = [doc[i] for i in token_idxs]
     tokens = sorted(tokens, key=lambda w: w.i)  # Make sure tokens are in their original order
     print(tokens)  # [We, introduce, methods]

with the error:
Traceback (most recent call last):
  File "<stdin>", line 2, in <module>
  File "<stdin>", line 2, in <listcomp>
  File "doc.pyx", line 296, in spacy.tokens.doc.Doc.__getitem__
TypeError: '<' not supported between instances of 'list' and 'int'

I'm on Windows 10 with WinPython (Python 3.7.1 (v3.7.1:260ec2c36a, Oct 20 2018, 14:57:15) [MSC v.1915 64 bit (AMD64)] on win32). Thanks otherwise, I have been looking for pattern matching for ages without luck!

@Code4SAFrankie  The error is due to a bug in this line.
https://github.com/cyclecycle/spacy-pattern-builder/blob/51a1eb9a2cbd56163103e0e903af585442f8f912/spacy_pattern_builder/util.py#L83
Annotation of depth is done only when attribute doesn't exist, but it should also be done when it is none. I am giving a pull request soon to address this bug.

@Code4SAFrankie  Did you manage to solve this? I am looking into using this for pattern matching and I also still get the same error

@laurencgreen  @Code4SAFrankie I solved it, check my branch in the pull request.

Greetings,  I still get the same error, I've already check pull request yet I did not really get how to solve the problem.  Can you please guide me?
Thanks.

Hi all, I have the same error. After checking what is inside matches (it's really a list of list of int, i.e. [[1, 0, 3]], but not a list of int), so iterating over token_idxs[0] instead of token_idxs solves the problem.

Hi all, I have the same error. After checking what is inside matches (it's really a list of list of int, i.e. [[1, 0, 3]], but not a list of int), so iterating over token_idxs[0] instead of token_idxs solves the problem.

Thanks for the reply, Yet now I got (name 'token_idxs' is not defined) error.


map.own

name map.own
catchphrase
map own properties
synopsis
any -> A; any -> B

map.own(mapper A=>B)(Object<A>) -> Object<B>

description
map.own behaves as map on objects, the only difference being map iterates over all properties of an object whereas map.own iterates only on an object's direct properties not inherited from its prototype.
const Person = function (name) {
  this.name = name
}

Person.prototype.greet = function () {
  console.log(`Hello, my name is ${this.name}`)
}

const david = new Person('david')

david.greet() // Hello, my name is david

david.a = 1
david.b = 2
david.c = 3

const square = number => number ** 2

map.own(square)(david) // { name: NaN, a: 1, b: 4, c: 9 }

execution concurrent
note
const nativeHasOwnProperty = Object.prototype.hasOwnProperty

const objectHasOwnProperty = (object, property) => nativeHasOwnProperty.call(object, property)

Hey, mind if I grab this?

@LMulvey welcome!


Create codeql-analysis.yml

Description

References

Testing

[ ] This change adds test coverage for new/changed/fixed functionality

Checklist

[x] I have read and agreed to the terms within the Auth0 Code of Conduct.
[x] I have read the Auth0 General Contribution Guidelines.
[ ] I have reviewed my own code beforehand.
[ ] I have added documentation for new/changed functionality in this PR.
[ ] All active GitHub checks for tests, formatting, and security are passing.
[ ] The correct base branch is being used, if not master.

Codecov Report

Merging #4 (7cb5a15) into master (bc30408) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #4   +/-   ##
=======================================
  Coverage   95.00%   95.00%
=======================================
  Files           3        3
  Lines          80       80
=======================================
  Hits           76       76
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc30408...7cb5a15. Read the comment docs.


AdminLTE app.js seems conflict with highcharts bar chart

Hi All
I have used AdminLTE with highcharts js, it works so fine with all kind of highcharts chart type except the bar chart type. When I remove the adminlte app.js, and highcharts bar chart type can work
The highcharts bar chart demo I used is this  http://www.highcharts.com/demo/bar-stacked
Does anyone know what's the problem here?
P.S
My chrome log is show that "Uncaught TypeError: Cannot read property 'defaultView' of undefined " when adminlte app.js work with highchart bar chart type

I only copied the parts from app.js to the particular file where highcharts was conflicting with so that not all pages are affected due to the change on app.js.

Same problem here. Solved commenting the jQuery resize event - v1.1 - 3/14/2010 related code on AdminLTE/app.js, as @StefanoF suggested above.

Could you please specific portion of  app.js code issue?

This is the portion of code I commented out to avoid the Uncaught TypeError: Cannot read property 'defaultView' of undefined error.
/*
 * jQuery resize event - v1.1 - 3/14/2010
 * http://benalman.com/projects/jquery-resize-plugin/
 *
 * Copyright (c) 2010 "Cowboy" Ben Alman
 * Dual licensed under the MIT and GPL licenses.
 * http://benalman.com/about/license/
 */
(function($, h, c) {
    var a = $([]), e = $.resize = $.extend($.resize, {}), i, k = "setTimeout", j = "resize", d = j + "-special-event", b = "delay", f = "throttleWindow";
    e[b] = 250;
    e[f] = true;
    $.event.special[j] = {setup: function() {
            if (!e[f] && this[k]) {
                return false;
            }
            var l = $(this);
            a = a.add(l);
            $.data(this, d, {w: l.width(), h: l.height()});
            if (a.length === 1) {
                g();
            }
        }, teardown: function() {
            if (!e[f] && this[k]) {
                return false
            }
            var l = $(this);
            a = a.not(l);
            l.removeData(d);
            if (!a.length) {
                clearTimeout(i);
            }
        }, add: function(l) {
            if (!e[f] && this[k]) {
                return false
            }
            var n;
            function m(s, o, p) {
                var q = $(this), r = $.data(this, d);
                r.w = o !== c ? o : q.width();
                r.h = p !== c ? p : q.height();
                n.apply(this, arguments)
            }
            if ($.isFunction(l)) {
                n = l;
                return m
            } else {
                n = l.handler;
                l.handler = m
            }
        }};
    function g() {
        i = h[k](function() {
            a.each(function() {
                var n = $(this), m = n.width(), l = n.height(), o = $.data(this, d);
                if (m !== o.w || l !== o.h) {
                    n.trigger(j, [o.w = m, o.h = l])
                }
            });
            g()
        }, e[b])
    }}
)(jQuery, this);

The version of AdminLTE I'm using is Date: 4 Jan 2014.

my step solv this problem
I use inspection element of firefox to debug problem

make sure check highcharts.js load in view page
at the console inspection i found app.js (or app.min.js) error at line number 186 about tooltip function, comment out and try reload view page again. if chart can display so tooltip may be conflict with highcharts widget.
in my project not found bootstrap-tooltip.js so I copy file from another project (or download from internet also) and paste into my project  after that register tooltip in AppAsset
revert comment out from choice 2 and try to reload view page again, if everything was to be you suspect chart can display with again


TListK Map

I need to be able to do something like this (aka, apply a natural transformation to a product):
  def map[A[_], B[_], AS <: TListK, BS <: TListK](
    as: Prod[AS]
  )(f: A ~> B)(
    implicit ev: TListK.Compute.Aux[TListK.Op.Map[B, BS], AS]
  ): Prod[BS] = {
    Prod.unsafeApply(as.values.asInstanceOf[Seq[A[scala.Any]]].map(f))
  }

but there doesn't seem to be any way to do it.
This (or a workaround) is sadly blocking my ability to complete scalaz-deriving's support for covariant typeclass derivation: https://gitlab.com/fommil/scalaz-deriving/merge_requests/86

@andyscott have you had any time to look at this?


[PKG-4248] Update to 1.23.0

opentelemetry-api 1.23.0 :snowflake:
Destination channel: Snowflake
Links

PKG-4248
Upstream repository
Upstream changelog / diff

Explanation of changes:

...

Linter check found the following problems:
ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_840vk7gvj4/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:44: documentation_specifies_language: Use the generic link, not a language specific one
===== Final Report: =====
0 Errors and 1 Warning were found


Sprites are still colorized when SCRIBBLE_COLORIZE_SPRITES set to false.

How are you applying the colour?

How are you applying the colour?

scribble(text).blend(c_black,1).draw(x,y);

The .blend() method will colourize everything; this is by design. If you want to colourize specific parts of an input string use inline formatting.


Trusted pervasive (vstd) types should be : Structural

Hi verus team, I was trying to check the equality of two structs that contain Option like this:
#[allow(unused_imports)]
use builtin_macros::*;
#[allow(unused_imports)]
use builtin::{ensures};

mod pervasive;
#[allow(unused_imports)]
use pervasive::{*, option::Option, map::*};

impl std::cmp::PartialEq for Option<u32> {
    #[verifier(external)]
    fn eq(&self, other: &Self) -> bool {
        match (self, other) {
            (Option::Some(a), Option::Some(b)) => a == b,
            (Option::None, Option::None) => true,
            _ => false,
        }
    }
}

impl std::cmp::Eq for Option<u32> {}

#[derive(Structural, PartialEq, Eq)]
pub struct MyStructA {
    pub content: Option<u32>,
}

fn MyFun() {
    let s1 = MyStructA{content:Option::Some(1)};
    let s2 = MyStructA{content:Option::Some(1)};
    assert(s1 == s2);
}

fn main() { }

However, verus reports the error:
error[E0277]: the trait bound `pervasive::option::Option<u32>: builtin::Structural` is not satisfied
   --> rust_verify/example/myexample.rs:23:10
    |
23  | #[derive(Structural, PartialEq, Eq)]
    |          ^^^^^^^^^^ the trait `builtin::Structural` is not implemented for `pervasive::option::Option<u32>`
    |
note: required by a bound in `builtin::AssertParamIsStructural`
   --> /Users/xudongs/verus/source/builtin/src/lib.rs:328:39
    |
328 | pub struct AssertParamIsStructural<T: Structural + ?Sized> {
    |                                       ^^^^^^^^^^ required by this bound in `builtin::AssertParamIsStructural`
    = note: this error originates in the derive macro `Structural` (in Nightly builds, run with -Z macro-backtrace for more info)

error: aborting due to previous error

For more information about this error, try `rustc --explain E0277`.
verification results:: verified: 0 errors: 0

My understanding about the equality check is:

#[derive(Structural)] is necessary for the struct we want to check equality for
if the struct has #[derive(Structural)], every field in this struct has to have #[derive(Structural)] as well

If both 1 and 2 are true, what would be the best way to check the equality of a struct that contains Option fields?

I changed assert(s1 == s2); to assert(equal(s1, s2)); and it works.
Just curious, what is the difference between == and equal in the context of proof code?

equal is guaranteed to always be "equality at the level of the SMT encoding"
== is just the usual Rust == operator, which may or may not have the above property. If it does have that property (called Structural), then == is allowed in proof/spec code, where it thereby means the same thing as equal.
I'm not sure why Option isn't already marked Structural - I think it probably could be without any issues. @utaal is that right?

[Triaged at the Verus all-hands.]
This should not matter for spec code anymore, as it already becomes SpecEq.
Consider other names: SmtEq, LogicalEq, SolverEq.
It should be implemented as a #[verifier(external)] impl for Option, Result, etc.


doesReadmeHashExist doesn't take param --readmeDir

Describe the bug
Hello,
On my project I have 2 sub dir
- Matrix
| README.md
| - matrix-back
|        | - README.md
| - matrix-front
|        | - README.md

Each projects has a README.md.
I have a husky pre-hook in matrix-back who insert coverage into root folder.
If I don't have a statement into my matrix-back/README.md, the message Readme does not contain the needed hashes is displayed.
The issue is in the method validate.ts doesReadmeFileExist. The param doesn't take --readmeDir argument.
Additional context
> istanbul-badges-readme --readmeDir="./.."

Info: 0. Istanbul Badges Readme process started
Info: 1. Config check process started
- Readme file exists... ✔.
- Coverage file exists... ✔.
- Coverage hashes exist... ✔.
readmePath= ./README.md
Error: Readme does not contain the needed hashes
Error: Please refer to the documentation

Thanks

Hello, @Tlahey, thank you very much for your report. We'll look into it as fast as we can ;)

Hey @Tlahey thanks for your report, indeed this readmeDir is a new feature and I forgot to consider that in validate.
Just created a PR right now to fix it #20

@all-contributors please add @Tlahey for bug

Hey @Tlahey version 1.3.1 is up, could you please install and see if it solved the problem?

@Tlahey we have had some problems lately with us having to increase its version so please try this fix with version 1.3.4.
Sorry for the inconvenience.


Added Generics to the tasks.

This way, the tasks' onError and onSuccess will deliver the right type and no casting will be needed. The add?????Task of the AssetsManager will also deliver the right type, which can be very helpful :smile:
let task = assetsManager.addTextureTask("download texture", "/textures/");
task.onError = (task, message, exception) => { console.log(task.texture);}; // was not valid until now

Continuing this -https://github.com/BabylonJS/Babylon.js/pull/3111 .

This PR introduces a compile error again if the strictFunctionTypes option is enabled:
babylon.d.ts(15717,20): error TS2420: Class 'AbstractAssetTask' incorrectly implements interface 'IAssetTask'.
Types of property 'onSuccess' are incompatible.
Type '(task: this) => void' is not assignable to type '(task: AbstractAssetTask) => void'.
Types of parameters 'task' and 'task' are incompatible.
Type 'AbstractAssetTask' is not assignable to type 'this'.
15717     abstract class AbstractAssetTask implements IAssetTask {
~~~~~~~~~~~~~~~~~

Not sure how you try to compile this, but this was, of course, fully tested (otherwise we wouldn't have been able to update the dist js files).
Care to share a bit mroe information? Are you trying to use this in code? are you using the Abstract class as a type?
I have updated the documentation, maybe this will help - http://doc.babylonjs.com/how_to/how_to_use_assetsmanager

I'm not using any AssetTasks. My project is referencing the babylon.d.ts
I compile my project with typescript 2.6.1 and all strict options enabled.
(BabylonJs itself still uses typescript 2.5.3 which does not support strictFunctionTypes)

Gotcha.
Our gulp script is still using 2.5.3 . We actually dont have strictFunctionTypes enabled. Let me see if I can fix this. and the rest of the (ca. 100) errors :)

Just an update - strictFunctions check was enabled and is available as version 3.1.0-beta6 on NPM