TypeError: Cannot read property 'send' of null

After a frew requests for chromecast text to speech triggers over the sayit plugin, there is an error with the chromecast instance. When I restart the instance, the problem is gone. But it's very annoying that the error is always, when I have more than a few requests in a short time and the chromecast did not play any playlists anymore...

chromecast.0
2018-06-16 21:11:20.428
error
Badezimmer - Could not play announcement: TypeError: Cannot read property 'send' of null

chromecast.0
2018-06-16 21:11:20.428
error
at process._tickCallback (internal/process/next_tick.js:109:7)

chromecast.0
2018-06-16 21:11:20.428
error
at /opt/iobroker/node_modules/iobroker.chromecast/node_modules/castv2-player/lib/playlist.js:75:23

chromecast.0
2018-06-16 21:11:20.428
error
at PersistentPlayer.queueLoadPromise (/opt/iobroker/node_modules/iobroker.chromecast/node_modules/castv2-player/lib/persistentPlayer.js:477:14)

chromecast.0
2018-06-16 21:11:20.428
error
at /opt/iobroker/node_modules/iobroker.chromecast/node_modules/castv2-player/lib/persistentPlayer.js:486:24

chromecast.0
2018-06-16 21:11:20.428
error
at DefaultMediaReceiver.queueLoad (/opt/iobroker/node_modules/iobroker.chromecast/node_modules/castv2-client/lib/senders/default-media-receiver.js:50:24)

chromecast.0
2018-06-16 21:11:20.428
error
at MediaController.queueLoad (/opt/iobroker/node_modules/iobroker.chromecast/node_modules/castv2-client/lib/controllers/media.js:146:8)

chromecast.0
2018-06-16 21:11:20.428
error
at MediaController.RequestResponseController.request (/opt/iobroker/node_modules/iobroker.chromecast/node_modules/castv2-client/lib/controllers/request-response.js:34:8)

chromecast.0
2018-06-16 21:11:20.428
error
at MediaController.Controller.send (/opt/iobroker/node_modules/iobroker.chromecast/node_modules/castv2-client/lib/controllers/controller.js:28:16)

chromecast.0
2018-06-16 21:11:20.428
error
at Channel.send (/opt/iobroker/node_modules/iobroker.chromecast/node_modules/castv2/lib/channel.js:34:12)

chromecast.0
2018-06-16 21:11:20.428
error
at Client.send (/opt/iobroker/node_modules/iobroker.chromecast/node_modules/castv2/lib/client.js:128:10)

chromecast.0
2018-06-16 21:11:20.428
error
Badezimmer - Error playing playlist - TypeError: Cannot read property 'send' of null

@linchen4000 Is the log from you trying to play something after hitting the problem? If so what is the status of the adapter (content of chromecast.0..status ?
The adapter should restart automatically after hitting an exception - if this is not the case I would need to fix that.

Yes the log was after I tried to play something and it didn't work. I reinstalled the hole adapter after having this problem more often. But after that so far the error has not yet occured again.
When it occur again, I will read out the status.

Okay, now it occurred again:

chromecast.0
2018-06-21 18:27:30.412
error
Badezimmer - Could not play announcement: TypeError: Cannot read property 'launch' of null

And the adapter is still alive and did not restart.

system.adapter.chromecast.0.outputCount
ioBroker outputs level
ioBroker outputs level
8
true
chromecast.0
2018-06-21 18:30:32.317
2018-06-21 16:28:46.719

system.adapter.chromecast.0.inputCount
ioBroker - inputs level
ioBroker - inputs level
0
true
chromecast.0
2018-06-21 18:30:32.317
2018-06-21 18:27:47.304

system.adapter.chromecast.0.uptime
chromecast.0
chromecast.0.uptime
373311
true
chromecast.0
2018-06-21 18:30:32.317
2018-06-21 18:30:32.317

system.adapter.chromecast.0.memRss
chromecast.0
chromecast.0.memRss
38.38
true
chromecast.0
2018-06-21 18:30:32.315
2018-06-21 18:30:17.319

system.adapter.chromecast.0.memHeapTotal
chromecast.0
chromecast.0.memHeapTotal
23.03
true
chromecast.0
2018-06-21 18:30:32.316
2018-06-21 14:52:01.136

system.adapter.chromecast.0.memHeapUsed
chromecast.0
chromecast.0.memHeapUsed
19.15
true
chromecast.0
2018-06-21 18:30:32.316
2018-06-21 18:30:32.316

system.adapter.chromecast.0.connected
chromecast.0
chromecast.0.connected
true
true
chromecast.0
2018-06-21 18:30:32.312
2018-06-17 10:48:42.085

system.adapter.chromecast.0.alive
chromecast.0
chromecast.0.alive
true
true
chromecast.0
2018-06-21 18:30:32.308
2018-06-17 10:48:42.082

I'm experiencing something very similar

I think I resolved it by restarting the adapter daily in the night with a CRON job.

Sadly the issue appears multiple times per day sometimes even per hour. So I don't think I can work around it using a cron job.
I can't correlate it to connection issues either. I tried using the ping adapter to check if the issue appears whenever there is a connection error but there is no correlation.
I would love to see some improvements in the adapter regarding reconnecting

What version of the adapter are you on? In version 2.1.5 I added reconnects based on mDNS updates.
In order to debug the issue I would need the full log for the device with issues so I can see what sequence of events&triggers it gets.
The status I would need is the one from the chromecast device since it shows if the adapter is currently connected:

I am using this adapter to output speech from sayit and also the 'bongs' from our doorbell (just a nice MP3 file) and have been trying to debug this issue with...
DEBUG=* node --inspect node_modules/iobroker.chromecast/main.js --force --logs
Looks like castv2 connection closed is the magic phrase to watch out for ;)
One can start the adapter and request playback of any number of items so long as they are withing a short period of each other. However, after some time with no playback the above castv2 connection closed message is output and after this no further playback is possible.
I notice it's just over 1 minute between the last playback and the connection closed message.
Something else odd when looking at the debug logs is that the heartbeat messages all look fine (ie. one 'PING' followed by a 'PONG' for each device detected) until at some point they start being duplicated (ie. two sets of 'PING' followed by a 'PONG' for each device detected!).
This duplication always seems to happen some time between the last successful playback and the failure which appears rather suspicious.
BTW, my stack trace looks like this just to confirm it's the same one we're talking about:
Kitchen - Error playing playlist - TypeError: Cannot read property 'send' of null
    at Client.send (/opt/iobroker/node_modules/castv2/lib/client.js:128:11)
    at Channel.send (/opt/iobroker/node_modules/castv2/lib/channel.js:34:12)
    at fn.Controller.send (/opt/iobroker/node_modules/castv2-client/lib/controllers/controller.js:28:16)
    at fn.RequestResponseController.request (/opt/iobroker/node_modules/castv2-client/lib/controllers/request-response.js:34:8)
    at fn.MediaController.queueLoad (/opt/iobroker/node_modules/castv2-client/lib/controllers/media.js:146:8)
    at DefaultMediaReceiver.queueLoad (/opt/iobroker/node_modules/castv2-client/lib/senders/default-media-receiver.js:50:24)
    at /opt/iobroker/node_modules/castv2-player/lib/persistentPlayer.js:504:26
    at new Promise (<anonymous>)
    at /opt/iobroker/node_modules/castv2-player/lib/persistentPlayer.js:495:16
    at process._tickCallback (internal/process/next_tick.js:68:7)

So the problem is that the closed connection from the underlying castv2 module is not passed up as expected to the castv2-client and therefore is not triggering a reconnect here:
https://github.com/angelnu/castv2-player/blob/523fd5a8317656a5038b7a7b3ca9d1de4e89f1a7/lib/persistentClient.js#L252
A fix is discussed here: https://github.com/thibauts/node-castv2-client/issues/58#issuecomment-404825417, and indeed changing the line in persistentClient.js from...
            //If connection closes afterwards then re-open it again
            that._client.once("close", function(){
              that._close();
              that._connectClient();
            });

...to...
            //If connection closes afterwards then re-open it again
            that._client.client.once("close", function(){
              that._close();
              that._connectClient();
            });

... works perfectly. Or at least for me. I will create an issue in that module and reference everything there.


Add my changes to lr4d's branch

The error message of the ValueError is huge. Can you look into making the traceback shorter? If that's not possible, we should disable the execution of that code block


fix: Fix robots.txt for OCW production

The live production OCW site needs a different robots.txt file than the other
environments. This adds separate files for each environment and adds logic for when to
use which.
Description

Separate robots.txt files for live prod and non-live
Add logic for picking which file to use

Motivation and Context

Google is blocked from crawling the site when the robots.txt is wrong
How Has This Been Tested?

Ran the Pulumi preview to ensure the right files are used for each site
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Enhancement (improves on existing behavior)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project. (Did you install and run the pre-commit hooks?)
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

LGTM


Verify ActiveJob job signature matches arguments

Hello,
I'd like to suggest an improvement to the have_enqueued_job and have_been_enqueued matchers – ensuring the arguments passed by the subject/caller actually match the job's method signature.
Motivation
At the moment it's possible to write an implementation and spec which calls & expects the wrong number of arguments, or mix up the positional/keyword arguments. This results in a passing test, but the implementation will fail at runtime.
This improvement would guard against these false-positives. This approach was inspired by RSpec's awesome verifying doubles.
Example
class KeywordArgsJob < ActiveJob::Base
  def perform(a:, b:) # expecting keyword arguments
  end
end

RSpec.describe "ensuring job arguments match the job signature" do
  it "throws an exception on mismatch" do
    expect { KeywordArgsJob.perform_later(1, 2) } # incorrectly passing positional args
      .to have_enqueued_job(KeywordArgsJob).with(1, 2) # incorrectly expecting positional args
  end
end

Current outcome: Spec passes
Desired outcome: ArgumentError: Missing required keyword arguments: a, b

Notes / questions
I wasn't sure if this behaviour should initially be opt-in, then become the default in the next major version. For the initial PR I've not made the verifying arguments behaviour configurable because it seems like any resulting failures will always be underlying bugs which should be fixed.

Hmm... I think the CI failures are unrelated flakes:
expected that command "bin/rspec spec/system/widget_system_spec.rb" has exit status of "0", but has "9". (RSpec::Expectations::ExpectationNotMetError)
features/system_specs/system_specs.feature:109:in `the exit status should be 0'

Matrix is passing on my fork:
https://github.com/odlp/rspec-rails/actions/runs/8342458003

Thanks, I have one last thing I'd like to change which is I'm not sure that it should raise an ArgumentError, this is a matcher and I think it should fail the matcher instead

@JonRowe switched to the matcher failing in 232ea6b. Turns out this is much neater when it fails:
Failures:

  1) ActiveJob matchers throws an exception on mismatch
     Failure/Error:
       expect { KeywordArgsJob.perform_later(1, 2) } # incorrectly passing positional args
         .to have_enqueued_job(KeywordArgsJob).with(1, 2) # incorrectly expecting positional args

       Incorrect arguments passed to KeywordArgsJob: Missing required keyword arguments: a, b
     # ./spec/rspec/rails/matchers/active_job_spec.rb:51:in `block (2 levels) in <top (required)>'
     # ./spec/rspec/rails/matchers/active_job_spec.rb:46:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:74:in `block (3 levels) in <top (required)>'
     # ./spec/spec_helper.rb:68:in `block (2 levels) in <top (required)>'

Thanks for the suggestion

Thanks so much for this

It was a pleasure - glad to make a small contribution back to a tool I use almost every day. Thanks for you reviews & guidance @JonRowe.

Released in 7.0.0


Lodash 3 compatibility

Hi. Just a quick question. Is lodash-deep compatible with the latest lodash (3+)?

Yes, it is :).


Add an ability to bind same interface to several implementations

It can be similar to the Ninject Named binding:
serviceCollection.AddScoped<IRepository, DefaultRepository>("Default");
serviceCollection.AddScoped<IRepository, AnotherRepository>("Another");
...
var repository = provider.GetService<IRepository>("Default");

+1

+1

+1

Note this would also give us named options back for free :)

Nothing's free -- just prepaid. :)

The DI system in DNX is designed around supporting the most common set of features so that other DI systems can be adapted to it. If you have a need for named bindings we recommend using a DI system that supports it and integrating it with DNX.


Add HTTP status codes from RFC 5842

https://issues.apache.org/jira/browse/HTTPCORE-553

Test fails with OpenJDK 7 due to a timeout. Is this a problem we've caused?


@mzikherman : remove popular artists component from collect page

This removes the popular artist component from the /collect page. While I think the data quality is pretty good, it's not a particularly effective component in terms of inquiry conversions and it's an expensive aggregation which runs on every query commercial filtering query by default. @briansw & I decided we could retire it recently while discussing keyword search. I'm still hoping to test decayed merchandisability as a sort on /collect instead at some point.
I'm planning on leaving the aggregation on the Gravity side in case we want to use it in any other context.
On a related note, the new keyword search feature on /collect will support artist name as a filter on the grid view.

So long friend! You never even lived outside of a lab :(


chore(dev): remove console logs

Checklist

[x] npm test passes
[x] tests and/or benchmarks are included
[x] commit message follows commit guidelines

Description of change

移除 console log，改动较小我直接合并了 @dxq613


JS/TS Moving files breaks import relocation

Type: Bug
Moving a directory containing multiple JS/TS files to import sometimes breaks.
It always seems to work fine the first time I move a file, but it breaks any following times.
There seems to be a race condition because VSCode is trying to apply the modifications in the old location.
VS Code version: Code 1.89.0 (b58957e67ee1e712cebf466b995adf4c5307b2bd, 2024-05-01T02:09:22.859Z)
OS version: Windows_NT x64 10.0.19045
Modes:
Remote OS version: Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2
Remote OS version: Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2
Remote OS version: Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

System Info

Item
Value

CPUs
AMD Ryzen 7 5800X 8-Core Processor              (16 x 3793)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
31.91GB (9.67GB free)

Process Argv
--crash-reporter-id ca91d43f-598e-42ee-8662-02961c5b5089

Screen Reader
no

VM
0%

Item
Value

Remote
WSL: Debian

OS
Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

CPUs
AMD Ryzen 7 5800X 8-Core Processor (16 x 3792)

Memory (System)
15.57GB (12.12GB free)

VM
0%

Item
Value

Remote
WSL: Debian

OS
Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

CPUs
AMD Ryzen 7 5800X 8-Core Processor (16 x 3792)

Memory (System)
15.57GB (12.12GB free)

VM
0%

Item
Value

Remote
WSL: Debian

OS
Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

CPUs
AMD Ryzen 7 5800X 8-Core Processor (16 x 3792)

Memory (System)
15.57GB (12.12GB free)

VM
0%

Extensions (17)

Extension
Author (truncated)
Version

language-x86-64-assembly
13x
3.1.4

better-comments
aar
3.0.2

vscode-firefox-debug
fir
2.9.10

dotenv
mik
1.0.1

remote-containers
ms-
0.362.0

remote-wsl
ms-
0.88.2

vim
vsc
1.27.2

vscode-eslint
dba
2.4.4

gitlens
eam
14.9.1

prettier-vscode
esb
10.4.0

vsc-nvm
hen
0.0.3

vscode-kafka
jep
0.15.0

vscode-docker
ms-
1.29.1

makefile-tools
ms-
0.9.10

vscode-jest
Ort
6.2.5

prisma
Pri
5.13.1

vscode-postcss
vun
2.0.2

A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
vscorecescf:30445987
vscod805cf:30301675
binariesv615:30325510
vsaa593:30376534
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
962ge761:30959799
pythongtdpath:30769146
welcomedialogc:30910334
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30936856
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
2e7ec940:31000449
pythontbext0:30879054
accentitlementst:30995554
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
jg8ic977:31013176
fchga941:31038042
pythonprc:31039816
dwnewjupyter:31039675

Please provide specific steps to reproduce the issue

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

Open a project containing submodules, e.g.
 +-index.ts
 + Foo
  +-Bar
       + Bar.ts
       + index.ts

Relocate some files (e.g., move the Bar directory up a level).

Move something else.

What should happen: imports in Bar.ts and other files referencing Bar should be updated to the new paths.
What is happening: sometimes, it works; other times, I get an error about Foo/Bar/Bar.ts does not exist.
It seems the TS relocate action is attempting to modify the file in its old location, instead of the new one.

Some update seems to have fixed this.


Is the "Properties" section in Witchcraft.Foldable documentation a note for maintainers?

I wasn't able to make sense of the "Properties" section in Witchcraft.Foldable, but then I don't even know what free theorems are (found this and this on the topic) or what properties Foldable has. Based on the wording, it also seemed as if this is a general note for maintainers. Am I on the right track?

Properties
People are working on Foldable properties. This is one of the exceptions to there needing to conform to properties. In the meantime, we are testing that naturality is preserved, which is be a free theorm.
If that fails, something is very wrong with the instance.

it also seemed as if this is a general note for maintainers

Yes and no. Foldable goes against the philosophy of principled type classes, as we would expect it to have testable properties. The props that it does have are trivial, so testing them should not fail under any circumstances. if it does, then the instance is severely broken.


Fixed package build error

Pull Request Checklist

[X] Make sure to read the contributor guide here.
[X] Make sure you are making a pull request against the staging branch.
[X] Make sure your pull request title matches the requested format.
[X] Make sure to lint, type-check, and run unit and API tests.

Description
Fixed package build error

:tada: This PR is included in version 2.0.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Bluetooth: HCI: k_sem_take failed with err -11

Zephyr build version:  zephyr-v2.4.0-1367-g7d16ab50d738
Step to build and configuration:

west build -b native_posix zephyr/samples/bluetooth/central

west build -t menuconfig

Goto --> Sub Systems and OS Services --> Blueooth-->Bluetooth HCI driver debug
Goto --> Sub Systems and OS Services --> Blueooth-->Bluetooth debug type (Normal printf-style to console)
Goto --> Sub Systems and OS Services --> Blueooth-->Bluetooth debug type (Normal printf-style to console)
Goto --> Sub Systems and OS Services --> Blueooth-->Bluetooth HCI core debug

Use Cambridge Silicon Radio CSR rck PTS Dongle as Controller

sudo btmon

sudo hciconfig hci1 down

Finally run command: sudo ./build/zephyr/zephyr.exe --bt-dev=hci1
In a short time, an exception will be triggered, see below:
ASSERTION FAIL [err == 0] @ /home/lingao/zephyrproject/zephyr/subsys/bluetooth/host/hci_core.c:374
	k_sem_take failed with err -11
@ /home/lingao/zephyrproject/zephyr/subsys/bluetooth/host/hci_core.c:374
[00:00:10.910,000] <err> os: >>> ZEPHYR FATAL ERROR 3: Kernel oops on CPU 0
[00:00:10.910,000] <err> os: Current thread: 0x56614fa0 (unknown)
[00:00:10.910,000] <err> os: Halting system

@JoeSpeedboat CC


Album song count

Hey,
thanks for this! :)
could you tell me what'd be the best way to get the album song count of a recognized track?
I can see the album in the metadata list under sections. But is there a way to look up the album and get the amount of songs on that album?
Thanks!

@Janphr, https://www.shazam.com/services/amapi/v1/catalog/ru/artists/503131736/albums

I plan to add this functionality over the weekend.

And: https://www.shazam.com/services/amapi/v1/catalog/ru/albums/1650765462
@Janphr

That works for me, thanks!

I've been sorting through my other open projects, I'll add methods for current requests soon.

added in 0.5.0.


Update to Balena 17.12

 Front conversations

Postponed as what we currently have is a work in progress branch for this version. There hasn't been an official 17.12 release yet as there is a pending name change that needs to happen.

Fixed by https://github.com/resin-os/meta-resin/pull/1127


TypeError: Cannot use 'in' operator to search for 'data' in null

Getting a bizarre error I've not seen before. The only change I made was the way Git handles line endings, but I doubt that would cause it. Using Express-handlebars v2.0.0 when I try to "res.render" I get the following:
TypeError: Cannot use 'in' operator to search for 'data' in null
    at Object.compile (.\node_modules\express-handlebars\node_modules\handlebars\dist\cjs\handlebars\compiler\compiler.js:467:19)
    at HandlebarsEnvironment.hb.compile (.\node_modules\express-handlebars\node_modules\handlebars\dist\cjs\handlebars.js:34:41)
    at ExpressHandlebars._compileTemplate (.\node_modules\express-handlebars\lib\express-handlebars.js:239:28)
    at ExpressHandlebars.<anonymous> (.\node_modules\express-handlebars\lib\express-handlebars.js:124:25)

The issue seems to be because line 124 is:
return this._compileTemplate(file, this.compilerOptions);
But compilerOptions is set to null here on line 31:
compilerOptions: null,
Any help would be greatly appreciated.

I was also facing this issue. Downgrading to 1.2.2 solved the problem for me.
My findings were that express-handlebars has dependency to handlebars like "handlebars": "^3.0.0", so it tries to install the latest handlebars. Current handlebars version is 3.0.2 somehow breaks express-handlebars

That solved it for me too! Thanks.

I will look into the Handlebars' changelog to see what changed between 3.0.0 and 3.0.2. From what you're saying, it looks like semver was broken, which is unfortunate. Another way around this issue would be you add "handlebars": "3.0.0" to your package.json and pass that copy of Handlebars to Express Handlebars via the config options.

handlebars.js Issue 1003 was opened on that project and has a suggested workaround while this gets worked out.

Sweet mother of Jesus, I have spent hours troubleshooting this issue... I thought I was going mad. Indeed, adding the workaround mentioned in handlebars.js Issue 1003 worked for me as well. What a pain!

It looks like it is happening because of handlebars 3.0.2 which was being installed bundled with your package. I killed my node-modules and force loaded handlebars 3.0.1 ( npm install --save<EMAIL_ADDRESS>) then did a npm install and this seems to have resolved my problem. I spent a lot of time troubleshooting because it was only happening on my production box. What a pain. For some reason this page hasn't been indexed by google so it never showed up in a search. It would have saved me some headache. Bah! Just thought I would share a quick and easy fix that doesn't require mods to sources.

Release a guard against this in 2.0.1


Resolve August integration makes too many requests and hits rate limits

Significantly reduce the number of api calls
that the august integration makes
Lock and door status now use the get_lock_status call with
door_status=True to avoid multiple calls to the same endpoint
Lock and door status are now updated ever 10 seconds instead
of every 5 seconds
Lock detail (battery level, etc) are now only updated every
1800s since its unlikely to change even of that period
A bug that caused the activities endpoint to be queried with
the exact same request once per lock or doorbell instead of
once per house has been resolved (self._house_ids had
duplicate ids)

Breaking change

Proposed change

Type of change

[ ] Dependency upgrade
[x] Bugfix (non-breaking change which fixes an issue)
[ ] New integration (thank you!)
[ ] New feature (which adds functionality to an existing integration)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

[x] The code change is tested and works locally.
[x] Local tests pass. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist
[x] The code has been formatted using Black (black --fast homeassistant tests)
[ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
[x] New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
[ ] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

[ ] No score or internal
[ ] 🥈 Silver
[ ] 🥇 Gold
[ ] 🏆 Platinum

Hi @bdraco,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Thanks for this ! Would it make sense to rework August to use the Data Update Coordinator helper that we have? (docs)

The likely makes more sense here, however its a quite an increase in scope so I'm not sure if I can find the time to do it in the next few days. @balloob Do you have an integration in mind that is a good example of how to do this well?

Philips hue. Which also inspired the docs.
I'll review this tomorrow, get this merged first.

Assuming py-august doesn’t take the pr I mentioned in the original issue, it’s likely best to merge this with an update interval of 60s instead of 10s

Might be able to use the activity endpoint to significantly reduce the number of lock queries since the unlock/lock events are in there as well

I'm going to assume the the py-august author isn't available at the moment and rework this to handle the 429 in the component for now

@balloob should be ready for a first pass review.

py-august upstream has been updated. I'm reworking this now

Looks like there are some lint issues that still need to be worked out

Hi @lamandrice,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

hmm
ci failed with
An unexpected error has occurred: CalledProcessError: command: ('/usr/bin/git', 'fetch', 'origin', '--tags')
return code: 128
expected return code: 0
stdout: (none)
stderr:
    error: RPC failed; curl 56 GnuTLS recv error (-54): Error in the pull function.
    fatal: The remote end hung up unexpectedly
    fatal: early EOF
    fatal: index-pack failed

hmm
ci failed with
An unexpected error has occurred: CalledProcessError: command: ('/usr/bin/git', 'fetch', 'origin', '--tags')
return code: 128
expected return code: 0
stdout: (none)
stderr:
    error: RPC failed; curl 56 GnuTLS recv error (-54): Error in the pull function.
    fatal: The remote end hung up unexpectedly
    fatal: early EOF
    fatal: index-pack failed

Failure was transient .. bumping the sha and repushing solved it.


Update readme with correct min version

Update documentation to indicate python 3.9 as minimal required version for package.

close #38


Fix loader for Qemu Raspi3 target

Qemu supports the raspi3 target (I'm running qemu-system-aarch64 -display none -smp 4 -m 1G -serial stdio -kernel target/aarch64-unknown-hermit-loader/debug/rusty-loader  -machine raspi3)
These commits add some support for raspi3, so that I could at least successfully boot into the kernel. A lot of fields in BOOT_INFO are not initialized correctly though.
Some things like the value  phys in link.ld should also be set through some board-specific files.
Some commits also only aim to simply improve readability or convert the llvm_asm! to the asm! macro.
I'm leaving this here for discussion for now.

Ok, sounds like a great starting point.


Laravel mix does not compile import or require statements

Laravel Mix Version: 1.4.2
Node Version: 6.11.2
NPM Version: 3.10.10
OS: Windows 10

Issue
Laravel Mix does not compile import or require. Instead, it simply copies them.
It does not perform minification in production mode either, but that's a side-issue.
Steps to reproduce

Create a new npm project.
Install laravel-mix through npm and copy the scripts to your package.json.
npm install some package.
Create app.js:

import package from 'package'; // Or package = require('package');

Add mix.babel('inputpath/app.js', 'outputpath/app.js'); to your webpack.mix.js.
Run npm run dev or any other compilation script.

The output file will just be the same as the input file. Meanwhile, other ES6 features are compiled correctly (tested with classes and arrow syntax for example).
Am I missing something, or is this a bug?

Same thing happens to me. I found a workaround here. Don't know if it affects performance though.
mix.js('resources/assets/js/app.js', 'public/js');

mix.webpackConfig({
  module: {
    rules: [{
      test: /\.js?$/,
      use: [{
        loader: 'babel-loader',
        options: mix.config.babel()
      }]
    }]
  }
});

@fiskhandlarn Thanks! That works for now. However, it seems like using mix.babel should just work.
For me, using mix.js without the config you mentioned works in development mode, but crashes in production mode (during minification). With the config, it also works in production.

@WouterFlorijn I agree, that would have been the best/easiest. :)

If the package you're requiring was written in es6, it won't be compiled down. You'd need to require the compiled version of that package.

@JeffreyWay The package I'm trying to require is my own written ES6 code for the app/site. It would be nice to be able to compile that with mix.babel. :)


Add getOne, updateOne methods to db.collection

(This is strictly the initial proof-of-concept, it still needs tests (and testing) and formatting and possibly more)


Search Feature not found -- Feature Request

Add the search feature, include search text in current page as well as whole book

This is duplication of #43. Closing for now.


Add uBiome sequencing summary spreadsheets

Created by @eliesbik on 2017-12-13. Commit created by @dhimmel with Elies authorship information.
Spreadsheets were emailed to Daniel by Elies and unmodified besides for their file names.
@eliesbik I created a README to add some documentation for the two spreadsheets. Would you be able to briefly summarize each sheet, and I'll add these descriptions to the bullet points.

Description of spreadsheet “results.xlsx”:

Tab “Mapping” contains the metadata associated with all the samples. It links each sample (e.g., FJ5 - gut) with sample type (concentrated or not), SeqID (unique sequencing dataset number), tube ID etc. “count” lists the number of reads assigned to Bacteria, and ‘count_norm” also lists the reads assigned to Bacteria, but normalized for a total of 1 million reads.
Tab “AllTaxa” lists each SeqID, and the “count” and “count_norm” assigned to each taxon, on all taxonomic levels. This is listed in the long format (useful in R).
Tab “GenusOnly” is a subset of “AllTaxa”, just listing the genus level data.
Tab “SpeciesOnly” is a subset of “AllTaxa”, just listing the species level data.

Description of spreadsheet “species.xlsx”:

Tab “SpeciesCountsTable” lists the same data as in tab “SpeciesOnly” from spreadsheet “results.xlsx”, but now in the wide format, comparable to an OTU table. The microbial species are listed in rows, and the samples are shown in columns. The absolute counts are shown.
Tab “SpeciesNormTable” lists the same data as in tab “SpeciesOnly” from spreadsheet “results.xlsx”, but now in the wide format, comparable to an OTU table. The microbial species are listed in rows, and the samples are shown in columns. The normalized counts are shown (normalized to 1 million reads assigned to Bacteria).
Tab “Top 20” shows the 20 most abundant species, as based on the normalized counts, averaged over all the samples, and also includes a bar graph.

Merged in https://github.com/dhimmel/fratjuice/commit/8af860a459b03a8bdc81f95aa653edcacf66f565. Thanks @eliesbik for the contribution!


Where to run the benchmarks for the published results?

Users will be able to run benchmarks locally. However, how do we choose on what kind of machine to run the benchmarks for the published results? Should it just be a reasonably recent server, and then we also document the machine specs alongside the benchmarks like https://julialang.org/benchmarks/ did?
For multi-compiler benchmarks this may be tricky. With several compilers we can build for x86, but some will be specific to the vendor hardware (IBM, Cray, ARM). Should we consider these as well?
Considering the support from the community so far and potential impacts of fortran-lang, down the road it shouldn't be difficult to get a dedicated cloud instance donated.
In the meantime, perhaps it will be good enough to just run on a recent workstation that one of us owns.

I think we have to run on all hardware that people are interested in. From typical HPC cpus, to typical workstations and laptops, to servers. X86 and ARM. And GPU!
But to get started, just a single machine is enough.
On Thu, Jul 9, 2020, at 10:49 AM, Milan Curcic wrote:

Users will be able to run benchmarks locally. However, how to we choose
on what kind of machine to run the benchmarks for the published
results? Should it just be a reasonably recent server, and then we also
document the machine specs alongside the benchmarks like
https://julialang.org/benchmarks/ did?
For multi-compiler benchmarks this may be tricky. With several
compilers we can build for x86, but some will be specific to the vendor
hardware (IBM, Cray, ARM). Should we consider these as well?
Considering the support from community so far and potential impacts,
down the road it shouldn't be difficult to get a dedicated cloud
instance donated.
In the meantime, perhaps it will be good enough to just run on a recent
workstation that one of us owns.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/fortran-lang/benchmarks/issues/4, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAFAWEJAJAWCGLFFALWFXLR2XYLJANCNFSM4OVZF2TQ.

Should it just be a reasonably recent server, and then we also document the machine specs alongside the benchmarks like https://julialang.org/benchmarks/ did?
...
In the meantime, perhaps it will be good enough to just run on a recent workstation that one of us owns.

Yes this seems like the best approach for now.
The only criteria for the machine I can think of is that it supports recent x86 vector instructions so we can take advantage of them - so this only excludes very old machines.
Ideally the machine would be dedicated without any other loads (see also reproducible benchmarking in linux environments).

Yes, I would start with x86-64 and AVX2 instructions.


Default export should match both IPv4 and IPv6

A combined regex would be very useful, similar to how ip-regex also exports a combined one on the default export.

Something like this:
new RegExp(`(?:${require(".").cidrv4.source})|(?:${require(".").cidrv6.source})`, 'g')


Run Wrong

I am a beginner, I don't know how to evaluate the performance with matlab, what can I do?

Question is solved, I'm very thank you for owner's helper.

抱歉放假回家了，所以现在才回复，评估实验结果只需要将person-re-ranking里的feature load换成对应的特征矩阵（注意转置）即可。

抱歉放假回家了，所以现在才回复，评估实验结果只需要将person-re-ranking里的feature load换成对应的特征矩阵（注意转置）即可。

抱歉放假回家了，所以现在才回复，评估实验结果只需要将person-re-ranking里的feature load换成对应的特征矩阵（注意转置）即可。

你好！评估实验结果时我跑出来bounding_box_test_features.mat，bounding_box_test_labels.mat，gt_bbox_features.mat，gt_bbox_labels.mat，query_features.mat和query_labels.mat等6个文件，但是用matlab修改feature load时，不知道对应关系，请问可以帮忙回答一下么？谢谢

galFea = importdata('/home/xieyangyang/Downloads/person-re-ranking-master/evaluation/feat/Market-1501/bounding_box_test_features.mat');
galFea = single(galFea);
galFea = galFea';
probFea = importdata('/home/xieyangyang/Downloads/person-re-ranking-master/evaluation/feat/Market-1501/query_features.mat');
probFea = single(probFea);
probFea = probFea';
label_gallery = importdata('/home/xieyangyang/Downloads/person-re-ranking-master/evaluation/data/Market-1501/testID.mat');
label_query = importdata('/home/xieyangyang/Downloads/person-re-ranking-master/evaluation/data/Market-1501/queryID.mat');
cam_gallery =   importdata('/home/xieyangyang/Downloads/person-re-ranking-master/evaluation/data/Market-1501/testCam.mat');
cam_query =  importdata('/home/xieyangyang/Downloads/person-re-ranking-master/evaluation/data/Market-1501/queryCam.mat');

Thank you very much！

Hello! I used the features extracted from the model , but I got the poor results.(Rank1=5.23% MAP=1.96%)
Have you ever met such questions?
Thankyou very much!

Hello SaintLogos1234:
I have done what you say , I changed what you said ,and  I command:
(matlab -nojvm -nodesktop -nodisplay -r "run /home/paulchou/DML/person-re-ranking/evaluation/Market_1501_evaluation.m;exit")

But I got this error??
could you help me??

galFea and probFea need transposing:
galFea = single(galFea);
galFea = galFea';
probFea = single(probFea);
probFea = probFea';

Thanks you for your applying, here is the result, but the matlab got stock.
Market_1501_evaluation.txt
In line 29 to 30 , i close this two lines.Bit line 96 have a issue??

Never mind the mistake, we're just going to test it with this code, we're not going to do anything else

Dear Autuor, I have got the bounding_box_test_features. mat、query_features. mat the two files. I would like to ask testID. mat, queryID. mat, testCam. mat, queryCam. mat. The mat is how to get?


Added Monona Grove Highschool

Added Monona Grove Highschool
School Website
Course Handbook (Go to page 13, or search for Computer Science)

@NBT22 Thank you for your patience while waiting for a review and processing your request. Pull request merged. Thank you!


Refactor phantomJS code?

Sentinl and Kibana version

Latest version 6.x

Issue description

PhantomJS binaries are packaged inside the build, this makes the zip file size = 100Mo! Hard to release.
Also, the project https://github.com/johntitus/node-horseman is no longer supported.
I am wondering if this part of Sentinl will be refactored?

Hi @ebuildy thanks for the feedback. Where would you need to release other than our provided builds
This is/was pretty much the same way the "other" watcher package is distributed to support multiple platforms with no user installation and help the lower-end. You can most definitely build a "naked" SENTINL and as long as PhantomJS is on the system it should work fine.
The plan is to switch from PhantomJS to Puppeteer but its a tedious task low in priority which might still be months away unless some brave soul steps in the help. Any PR is welcome! ;)


can't find html.next() method

I can't find html.next() method. Have you been removed it ?

This was already solved, you can install from the repository or wait for the new release. As mentioned above you can use ._next() meanwhile a new release is set.
#148

v0.10.0 was released yestearday fixing this bug.


Move Caddyfile into config maps

Admin and public.

This ended up being impractical.  Our Caddyfiles are 30+ lines, so they're easier to manage as standalone files consumed during image builds.  Admin and Public both have this pattern.


Fix systemjs-angular-loader.js for <=IE10

"let" is ES2015 and therefore not supported by<=IE10

Welp, made the mistake to merge it too son. Can you please sign the CLA? Or I shall revert the commit :(

I signed the CLA immediately after the post but didn't reply because you already committed it.


Add logo and improve right-to-left support

This adds the Lotus logo, improves RTL support across the site, and adds units to 0 values in accordance with original CSS style.

This now incorporates a merge from @evra6965 along with a new commit from me. There is a lot of added #rtl nesting in the CSS. See why here.

Also, https://github.com/OriginProtocol/company-website/pull/95/commits/ffe3452bcb30065f711e471920326bfc8bcdd538 includes a fix for the email signup form causing horizontal overflow on screens less than 384px wide.


Docs page on using custom components and data (and more broadly MDX)

Don't merge
Closes #20

Changes:

docs page (/docs/mdx) about MDX, containing:

introduction with basic info about MDX
info about syntax elements supported by MDX (Markdown, JSX, ESM import and export statements, JS expressions)
info on how to create components
info on how to import components
info on how to import data
info on how to define components locally
info on how to define data (variables) locally

test page (/test/mdx-components) for components written in MDX (=not JSX components)

Notes
I wasn't sure if we want to write documentation for MDX components as well so I've only tested if they work for now.

@rufuspollock thank you for great suggestions! I've applied them and just need to double check the issue re having components in /content folder


Async client takes a while to close the connection

For example if I run the following script with the websockets package within a context manager managing the session, it closes quickly.
https://gist.github.com/yyolk/42b67ec5f1b1a17e273b5497e9eaad88#file-01__websockets__xrpl_stat_table-py
If I run the same code, with xrpl-py which is set up to handle the websocket identically, the websocket does close but it takes a while.
https://gist.github.com/yyolk/42b67ec5f1b1a17e273b5497e9eaad88#file-02__xrpl-py__xrpl_stat_table-py
My first instinct was to see where there was a difference in how websockets handled it and how xrpl-py does. For the most part it's identical, following the dunder method for __aexit__ to close() when called from the AsyncWebsocketClient.__aexit__ https://github.com/XRPLF/xrpl-py/blob/e5bbdf458ad83e6670a4ebf3df63e17fed8b099f/xrpl/asyncio/clients/async_websocket_client.py#L58-L65
It led me to notice a few assert statements in the code that seemed pretty reasonable for conditional checks
https://github.com/XRPLF/xrpl-py/blob/e5bbdf458ad83e6670a4ebf3df63e17fed8b099f/xrpl/asyncio/clients/websocket_base.py#L84-L90
However if I run with python -O or in optimized mode, which will drop all assert statements, I do see the socket program close as swiftly as the one with websockets which I've seen very little difference in it's implementation. The only thing that stuck out to me at first glance was using the convenience of asyncio.shield(...) over spinning up a background thread and these assert statements.
I did a quick search and saw we only had asserts in a few places and tried dropping it here: https://github.com/yyolk/xrpl-py/tree/patch-20210705
-O command line arg: https://docs.python.org/3/using/cmdline.html#cmdoption-o

Would you please quantify the time penalty we have? I'd expect even without the assert statements that we're slower than the base library because we are essentially grafting a synchronous response into websockets so that you can use the any client with our helper functions. That's a penalty I believe we should take.

@yyolk Closing as we don't have enough detail


jenkins operator in opernshift operator hub getting - ImagePullBackOff

Seems like the version in operator hub is pointing to a non-existent tag.
Failed to pull image "quay.io/redhat-developer/openshift-jenkins-operator:0.4.1-ed5de33": rpc error: code = Unknown desc = Error reading manifest 0.4.1-ed5de33 in quay.io/redhat-developer/openshift-jenkins-operator: unknown: Tag 0.4.1-ed5de33 was deleted or has expired. To pull, revive via time machine.

Hi @osirisstar-hub ,
the image tag has been errounesly changed. It is now restored.
can you confirm that it is working for you now?

Yes it just completed the install.  Thanks!


Windows 10 support for WSL windows store version

Hi,
would be nice to have the latest wsl /systemd support in windows 10 also (some company don't have windows 11 installed yet)
Thanks,
Nick

Apparently, the 1.0 version was published to the Windows Store, and it even allowed me to download it on Windows 10. Yet, it does not work:

Maybe it shouldn't be offered to Windows 10 users at all?

It works provided that you are running Windows 10 22H2 with the optional KB5020030 update installed.

Windows 10 22H2 + KB5020030 does not work for me. When I attempt to open WSL directly from the Microsoft Store, I get the following error instead:

I thought the Windows Subsystem for Linux component was no longer required with the 1.0 release? That's why I uninstalled it in the first place.
I tried re-installing this component anyway just in case, but then my OS is using the in-Windows WSL instead of the Store version when I do, as running wsl --version still fails.
Help would be appreciated.

I had the same issue as @SmashManiac , and re-installing the Windows Subsystem for Linux component under "Windows Features" yielded nothing, I would still get the pre-Microsoft store version of WSL2.
After that I went scorched earth on WSL, uninstalled everything related to it (the Windows feature, Ubuntu images and any updates related to WSL listed in the control panel), rebooted and tried again from scratch.
Couldn't get rid of the "this application requires the Windows Subsystem for Linux" error message no matter what I did, so I went ahead and re-installed it anyway and rebooted.
This time, the output of the "wsl --version" command worked and returned the expected version (<IP_ADDRESS>)

From there, running "wsl --install ubuntu" got everything setup and working (with systemd enabled as well).
The old WSL2 must leave some remnant in the OS that confuses the WSL2 store app. It's also strange that the WSL team states that the WSL Windows Feature doesn't need to be enabled, but it clearly does in order to get things working on Windows 10.

The old WSL2 must leave some remnant in the OS that confuses the WSL2 store app.

"The old WSL2" is called "inbox WSL" or "system WSL". It exits even if WSL2 store app is installed. wsl.exe just prefers WSL2 store app if installed.

The old WSL2 must leave some remnant in the OS that confuses the WSL2 store app.

"The old WSL2" is called "inbox WSL" or "system WSL". It exits even if WSL2 store app is installed. wsl.exe just prefers WSL2 store app if installed.

That comment is incorrect according to the official 1.0 release announcement though; it clearly states that the "in-Windows" version of WSL is the one from the "Windows Subsystem for Linux" optional component, and that it only needs to be installed for WSL1:
https://devblogs.microsoft.com/commandline/the-windows-subsystem-for-linux-in-the-microsoft-store-is-now-generally-available-on-windows-10-and-11/
Besides, I do get the proper wsl --version behavior on my Windows 11 machine after uninstalling "Windows Subsystem for Linux" from it, so it does appear to be an exclusive Windows 10 bug.


Issue with VbScript code

VSCode Version: Code - Insiders 1.5.0-insider (e9c80f036645caae7759b3954fc72dbe6c644edf, 2016-08-12T06:07:39.195Z)
OS Version: Windows_NT ia32 6.1.7601

Steps to Reproduce:

Open a VBScript with a class defined in it
The "End Property" and "End Class" Statements are not being recognized as reserved words and turning blue as expexted.

@aeschli this PR was accepted, will you pick up a new bundle?


Add option to error on unconsumed input

introducing a new method to be backwards compatible, please let me know what you think about this approach @MiSawa

Looks good, thank you for the contribution!!

Oops sorry, forgot to execute non-dry-run of the release. New version will be available soon.


perf: hardcode a mirroring seeder to test its performance

This PR adds helps to join a certain peer (a seeder that doesn't announce all cores on the DHT), to compare it with the current seeder, it shouldn't disrupt anything else and is simple to revert, hopefully, we can test it in internal staging soon.

@Nazeh rather move to .env


Crash when Rotate Phone [Vivo XShot] with AnyOrientationCaptureActivity

Reopen New Issue from : https://github.com/journeyapps/zxing-android-embedded/issues/82
ERROR LOG Below:

Phone :
Vivo XShot
Android 4.4.2

Should be fixed by #133.

Fix released in v3.2.0.
Please re-open if you still have this issue.


[For test only] Support control plane SDS

Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[x] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@JimmyCYJ: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio-unit-tests-master
c3e7cb5943ade2d614d9426e6171db62b5915411
link
/test istio-unit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio-unit-tests-master
c3e7cb5943ade2d614d9426e6171db62b5915411
link
/test istio-unit-tests-master

istio-racetest-master
c3e7cb5943ade2d614d9426e6171db62b5915411
link
/test istio-racetest-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio-unit-tests-master
c3e7cb5943ade2d614d9426e6171db62b5915411
link
/test istio-unit-tests-master

istio-racetest-master
c3e7cb5943ade2d614d9426e6171db62b5915411
link
/test istio-racetest-master

istio-codecov-master
c3e7cb5943ade2d614d9426e6171db62b5915411
link
/test istio-codecov-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio-racetest-master
c3e7cb5943ade2d614d9426e6171db62b5915411
link
/test istio-racetest-master

istio-codecov-master
c3e7cb5943ade2d614d9426e6171db62b5915411
link
/test istio-codecov-master

istio-unit-tests-master
df491949080d015e3d37fb2a191b8b6a9e20a958
link
/test istio-unit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio-codecov-master
c3e7cb5943ade2d614d9426e6171db62b5915411
link
/test istio-codecov-master

istio-unit-tests-master
df491949080d015e3d37fb2a191b8b6a9e20a958
link
/test istio-unit-tests-master

istio-racetest-master
df491949080d015e3d37fb2a191b8b6a9e20a958
link
/test istio-racetest-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio-unit-tests-master
df491949080d015e3d37fb2a191b8b6a9e20a958
link
/test istio-unit-tests-master

istio-racetest-master
df491949080d015e3d37fb2a191b8b6a9e20a958
link
/test istio-racetest-master

istio-codecov-master
df491949080d015e3d37fb2a191b8b6a9e20a958
link
/test istio-codecov-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-presubmit-tests-master
7512beff8bbeb4654d5d49b8269aae9de394e006
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This PR combines
https://github.com/istio/istio/pull/16460
https://github.com/istio/istio/pull/16466
and adds integration test for SDS control plane.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-presubmit-tests-master
7512beff8bbeb4654d5d49b8269aae9de394e006
link
/test integ-security-k8s-presubmit-tests-master

istio-racetest-master
e4f020eb1d312a576dff1c4283e99b59d852df44
link
/test istio-racetest-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@JimmyCYJ: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-presubmit-tests-master
d1a643dd73c12428edd1a067aeb22dcfc2864c56
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


iOS 10 Photo Library, Camera permission issue

After ios10, the policy have changed to ask the allow popup for photo & camera

if i say ok, it fines.
But i say dont' allow, the spinner keeps loading, and the app crashes after few second.

Dupliate of #330, let's handle it there


[doc] Revise web test suite developer guide

@jennycao @Honry @Shao-Feng PTAL
You can check the visual at
https://github.com/zqzhang/crosswalk-test-suite/blob/dev-guide/doc/Web_Test_Suite_Developer_Guide.md

Thank you all for the review; I will address them in this week when handle other urgent things.

@jennycao I don't know where your last 2 comments target for.

@Honry @jennycao your comments shall have been addressed; could you please check https://github.com/zqzhang/crosswalk-test-suite/commit/30fc17e7f90600fa08aa4924f98c416374d4f177? Thanks.


Lint name strings for…

We ought to check for style and consistency in name strings.
Some things we ought to check for:

[ ] Leading or trailing spaces
[ ] Markdown syntax (e.g., `code` or *emphasis*)
[ ] Balanced braces, brackets, and parentheses
[ ] Use of ellipses (…) and spaces
[ ] Uniqueness
[ ] Double (or more) spaces (e.g., Don't let this→  ←happen)

Prompted by https://github.com/web-platform-dx/web-features/pull/2017. Related to https://github.com/web-platform-dx/web-features/issues/1935.

Good ideas. I added them to the checklist, plus a couple more for ellipses and double (or triple) white space characters.


Test installing OVS on CentOS 6

CentOS 7 and CentOS 6 are quite different, so it may be worthwhile to extend the CentOS recipe to include both versions. In order to do that, I'll need to test installing OVS on CentOS 6.

EPEL does not offer OVS packages, and none of the OpenStack-related packages that do have OVS are supported on CentOS 6.

Closing this issue (not pursuing any additional work on this project)


Refactor tkey-verification: new ways of accessing compiled-in assets

Refactoring to:

Include the device binaries in the repo directly. Remove the build scripts for verisigner. Use the ordinary tkey-device-signer for new stuff. If a user wants to build verisigner, they have to use old tags and the instructions there.

Use ordinary tkeyclient package instead of internal version.

Use the ordinary tkeysign package to communicate with both signer, these days updated to be able to get a firmware hash, and the old verisigner.

Use new way of accessing internal assets like: vendor public keys, known firmwares, and the app binaries. We're now more idiomatic in the access and use something like foos := NewFoo() with methods on foo to do something with them.

Support multiple vendor keys at the same time for verification.

Make the external command show-pubkey into just another command in tkey-verification.

Closes #18

Updated the description of what this PR does.
Rebased on main.
Squashed and rewored many commits.

Please have a look @dehanj. Do you think we should squash the entire thing into something like the new PR description or do we leave the individual commits? Some of them are mostly small fixes.
Not sure what to do about the first commit... It's from the tkey-libs branch which has been abondened. Do we even try to remove it?

When using tkey-verification verify -d /path/to/dir` with a local copy of the verification data, if I change the name of the apptag (to for example "verisigner-v0.0.4"), nothing happens. From what I can see it never uses the apptag for anything. Should it?
Is apptag used for anything today, or is it simply a human readable tag?

When using tkey-verification verify -d /path/to/dir with a local copy of the verification data, if I change the name of the apptag (to for example "verisigner-v0.0.4"), nothing happens. From what I can see it never uses the apptag for anything. Should it?
Is apptag used for anything today, or is it simply a human readable tag?

It's only a human readable tag now. Should be documented as such, so good point.

Fixed most of my comments. Maybe some more squashing can be done, but waiting with that until the speed is included.
Otherwise I start to think that it looks good. The functionality has been verified.


IODMA not generated

Hello,
I'm having some trouble to use FINN with my own network. I already followed the tutorial scripts which worked fine.
My network is not composed of fancy layers, only conv, batchnorm, Relu dans fully connected layers.
I'm using FINN v0.5b and get the following error on the synthesize step:
Running step: step_synthesize_bitfile [14/15]
Traceback (most recent call last):
File "/workspace/finn/src/finn/builder/build_dataflow.py", line 128, in build_dataflow_cfg
model = transform_step(model, cfg)
File "/workspace/finn/src/finn/builder/build_dataflow_steps.py", line 486, in step_synthesize_bitfile
ZynqBuild(cfg.board, cfg.synth_clk_period_ns, cfg.enable_hw_debug)
File "/workspace/finn-base/src/finn/core/modelwrapper.py", line 140, in transform
transformed_model
File "/workspace/finn/src/finn/transformation/fpgadataflow/make_zynq_proj.py", line 326, in apply
MakeZYNQProject(self.platform, enable_debug=self.enable_debug)
File "/workspace/finn-base/src/finn/core/modelwrapper.py", line 140, in transform
transformed_model
File "/workspace/finn/src/finn/transformation/fpgadataflow/make_zynq_proj.py", line 168, in apply
), "Must have 1 AXI lite interface on IODMA nodes"
AssertionError: Must have 1 AXI lite interface on IODMA nodes
/workspace/finn/src/finn/transformation/fpgadataflow/make_zynq_proj.py(168)apply()
-> ), "Must have 1 AXI lite interface on IODMA nodes"
It seems that there should be an IO AXI lite for DMA, but it's not generated.. I don't know why?
Can someone help me with this?
I have put my a simplified model to reproduce the error and the script I used here :  https://github.com/Logitek27/FINN_IODMA_ISSUE . I just used the "build_custom" command with the FINN docker.
Thanks for your help

Hi,
your model is not directly compatible with the series of transformations applied by the default build_dataflow_cfg flow.
For example, your model contains depthwise-conv layers, which require the InferVVAU() transformation to map the respective MatMul nodes to "Vector_Vector_Activate_Batch" HLS cores. This transformation is not present in the default build steps (see https://github.com/Xilinx/finn/blob/dev/src/finn/builder/build_dataflow_steps.py), so the MatMul nodes remain in the graph after step 3 (convert_to_hls). This breaks the rest of the build flow because the next step cannot connect all nodes within one dataflow partition, which is required for IODMA insertion. As you can see in the intermediate .onnx model of step 4, it breaks the graph into separate dataflow partitions where it encounters non-HLS nodes.
To fix this, you can experiment with a custom series of build steps. I suggest a look at our MobileNetV1 example, which also uses a few custom steps to deal with the dw conv layers:
https://github.com/Xilinx/finn-examples/blob/main/build/mobilenet-v1/build.py
https://github.com/Xilinx/finn-examples/blob/main/build/mobilenet-v1/custom_steps.py
I tried these exact steps on your model, but it doesn't seem to do the trick without some modification.
Simply adding the InferVVAU() to the default step 3 handles the dw MatMul nodes, but the graph still breaks in 3 places:

MaxPoolNHWC followed by FMPadding_Batch
MaxPoolNHWC followed by FMPadding_Batch
Series of Transpose->MaxPool->Mul->Flatten

Hi,
Thank you for your response it's very clear. I've tried to add this transformation and other modifications to solve my problem without success yet. But it's better with "InferVVAU()" transformation.  I let you know if I succeed to solve the problem!

I am closing this issue due to inactivity. Please feel free to reopen or create a new issue if the problem persists!


xUnit warnings do not show up in problem matcher

VSCode Version: 1.20.1
OS Version: Ubuntu 17.10

Steps to Reproduce:

C# project with xUnit package
Use $msCompile problem matcher in build task
Have a warning in one of the tests
Problem matcher does not grab the warning

Example class that would cause a warning:
namespace Tests
{
  public class MyTests
  {
    [Fact]
    public void Good()
    {
    }

    public void Warning() // <-- Warning xUnit1013: Public method 'Warning' on test class 'MyTests' should be marked as a fact.
    {
    }
  }
}

Possible fix:
Update mscompile regex from
/^(?:\s+\d+\>)?([^\s].*)\((\d+|\d+,\d+|\d+,\d+,\d+,\d+)\)\s*:\s+(error|warning|info)\s+(\w{1,2}\d+)\s*:\s*(.*)$/

to
/^(?:\s+\d+\>)?([^\s].*)\((\d+|\d+,\d+|\d+,\d+,\d+,\d+)\)\s*:\s+(error|warning|info)\s+(\w{1,5}\d+)\s*:\s*(.*)$/

The major difference between the output is the code. xUnit uses 5 characters instead of 2

I would rather argue that there should be a special problem matcher for xUnit because there might be other differences. Such a problem matcher could be contributed by an extension.


Where do local recordings get saved to?

I can't find the saved files generated from the streams that I'm publishing with .localRecord. Where are they saved to?
Is there an API to tell a stream where to save its local recording?

macOS

.moviesDirectory

iOS

.documentDirectory then move to PhotoLibrary


Unnecessary ownership makes it harder to use RecordBatch::schema and Schema::try_merge than it needs to be

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
 I would like to create one new Schema instance, which I will have ownership of, of course, but it seems like the schema merge should only need to borrow the record batches' schemas.
Describe the solution you'd like
I wish I could write:
use arrow::{datatypes::Schema, error::ArrowError, record_batch::RecordBatch};
fn schema_merge(batches: &[RecordBatch]) -> Result<Schema, ArrowError> {
    Schema::try_merge(batches.iter().map(|b| b.schema()))
}

but that doesn't compile because batch.schema() returns an owned Arc<Schema> and try_merge expects impl IntoIterator<Item = Schema>:
425 |         Schema::try_merge(batches.iter().map(|b| b.schema()))
    |         ----------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `Schema`, found `Arc<Schema>`
    |         |
    |         required by a bound introduced by this call
    |
    = note: expected struct `arrow::datatypes::Schema`
               found struct `std::sync::Arc<arrow::datatypes::Schema>`

It seems like Schema::try_merge could be changed to only need references to the schemas (or a new function if you didn't want to break backwards compatibility):
-    pub fn try_merge(schemas: impl IntoIterator<Item = Self>) -> Result<Self, ArrowError> {
+    pub fn try_merge<'a>(
+        schemas: impl IntoIterator<Item = &'a Schema>,
+    ) -> Result<Schema, ArrowError> {
...
            // merge metadata
            for (key, value) in metadata.into_iter() {
-                if let Some(old_val) = out_meta.get(&key) {
-                    if old_val != &value {
+                if let Some(old_val) = out_meta.get(key) {
+                    if old_val != value {
...
-                out_meta.insert(key, value);
+                out_meta.insert(key.clone(), value.clone());
            }
}

buuuuuut then you'd have this problem if you try to use as_ref to get &Schema from the Arc<Schema>s:
error[E0515]: cannot return value referencing temporary value
   --> bulk_ingester/src/fsm/create_intermediate_files.rs:425:40
    |
425 |    my_try_merge(batches.iter().map(|b| b.schema().as_ref()))
    |                                        ----------^^^^^^^^^
    |                                        |
    |                                        returns a value referencing data owned by the current function
    |                                        temporary value created here

so it seems like if there's a Schema::try_merge_from_borrowed_schemas, then it'd also be nice to have RecordBatch::borrow_schema that returns &Schema (not to be confused with SchemaRef, of course ;))
What do you think?

No objections to adding a schema_ref method to RecordBatch or even changing schema to return a reference.
W.r.t to merging, perhaps we could just add an appropriate method to SchemaBuilder?

I recently started working on changing RecordBatch::Schema so that it returns an &Schema instead of a SchemaRef. This is a breaking change, and in order to get this code to compile, I had to make changes to files where RecordBatch::Schema is called. These changes were pretty straightforward, and in many cases I just had to remove .as_ref() from places where the SchemaRef was being treated as a &Schema. In other cases, I wrapped the new &Schema return values in Arcs.
I will put up a PR for this soon. If these changes are too significant, I would be happy to make another PR that creates a schema_ref method and doesn't alter the functionality of Schema.

I think it should probably return a &SchemaRef as this will allow users to cheaply clone it if they want an owned SchemaRef

That makes sense. I will work on a PR for that tonight.

If the goal is to allow @carols10cents to write this (which I agree would be much more ergonomic):
fn schema_merge(batches: &[RecordBatch]) -> Result<Schema, ArrowError> {
    Schema::try_merge(batches.iter().map(|b| b.schema()))
}

Perhaps we can change try_merge from
pub fn try_merge(
    schemas: impl IntoIterator<Item = Schema>
) -> Result<Schema, ArrowError>

To take SchemaRef:
pub fn try_merge(
    schemas: impl IntoIterator<Item = SchemaRef>
) -> Result<Schema, ArrowError>

Or alternately make a new function Schema::try_merge_refs or something
I realize this would incur extra runtime overhead of additional Arc clones, but I think in the grand scheme of things it is pretty minimal compared to logic that Schema::try_merge is doing

If the goal is to allow @carols10cents to write this (which I agree would be much more ergonomic):

I think the broader pattern is to enable borrow propagation to work correctly, the try_merge is just an example of where this causes problems. FWIW we've made similar changes in the past, e.g. https://github.com/apache/arrow-rs/issues/2035 and https://github.com/apache/arrow-rs/issues/313

I think the broader goal is to enable borrow propagation to work correctly, try_merge is just an example of where this causes problems.

If that is the broader goal, I think we should track it under a different ticket given its potential for large breaking (albiet mechanical) API changes for users of arrow-rs.
The idea is good (avoid clone'ing Arcs) but I have't seen this ever show up in benchmarks

FWIW I would suggest we just add a schema_ref method and everyone can then be happy 😄

This sounds good to me

I filed https://github.com/apache/arrow-rs/issues/5463 to track the larger discussion

Closed by #5474, SchemaBuilder::try_merge already accepts a &FieldRef

label_issue.py automatically added labels {'parquet'} from #5448

label_issue.py automatically added labels {'arrow'} from #5448

label_issue.py automatically added labels {'arrow-flight'} from #5448


Build Failure: Unresolved Dependencies for com.android.tools.build:gradle:8.9.0 After Updating Java, Gradle, and Flutter

Steps to reproduce

Update Java, Gradle, and Flutter to the latest versions.
Try building the Flutter project.
Try to build the project.

Actual results
After updating Java, Gradle, and Flutter to their latest versions, my Flutter project fails to build with unresolved dependency errors. Below are the details of the error and my project setup.
The build fails with unresolved dependency errors for com.android.tools.build:gradle:8.9.0 and org.codehaus.groovy:groovy-all:latest_version.
Logs
Error:
FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring root project 'android'.
> Could not resolve all artifacts for configuration ':classpath'.
   > Could not find com.android.tools.build:gradle:8.9.0.
     Searched in the following locations:
       - https://dl.google.com/dl/android/maven2/com/android/tools/build/gradle/8.9.0/gradle-8.9.0.pom
       - https://repo.maven.apache.org/maven2/com/android/tools/build/gradle/8.9.0/gradle-8.9.0.pom
     Required by:
         project :
   > Could not find org.codehaus.groovy:groovy-all:latest_version.
     Searched in the following locations:
       - https://dl.google.com/dl/android/maven2/org/codehaus/groovy/groovy-all/latest_version/groovy-all-latest_version.pom
       - https://repo.maven.apache.org/maven2/org/codehaus/groovy/groovy-all/latest_version/groovy-all-latest_version.pom
     Required by:
         project :

Project Setup:
android/build.gradle
buildscript {
    ext.kotlin_version = '1.8.22'
    repositories {
        google()
        mavenCentral()
    }
    dependencies {
        classpath 'com.android.tools.build:gradle:8.9.0'
        classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
        classpath 'com.google.gms:google-services:4.3.15'
    }
}

allprojects {
    repositories {
        google()
        mavenCentral()
    }
}

rootProject.buildDir = "../build"
subprojects {
    project.buildDir = "${rootProject.buildDir}/${project.name}"
}
subprojects {
    project.evaluationDependsOn(":app")
}

tasks.register("clean", Delete) {
    delete rootProject.buildDir
}

android/app/build.gradle
plugins {
    id "com.android.application"
    id 'com.google.gms.google-services'
    id "kotlin-android"
    id "dev.flutter.flutter-gradle-plugin"
}

android {
    namespace 'com.example.chat'
    compileSdk = flutter.compileSdkVersion
    ndkVersion = flutter.ndkVersion
    compileOptions {
        sourceCompatibility = JavaVersion.VERSION_1_8
        targetCompatibility = JavaVersion.VERSION_1_8
    }
    defaultConfig {
        applicationId = "com.example.chat"
        minSdkVersion 23
        targetSdkVersion 33
        versionCode = flutterVersionCode.toInteger()
        versionName = flutterVersionName
    }
    buildTypes {
        release {
            signingConfig = signingConfigs.debug
        }
    }
    configurations.all {
        resolutionStrategy {
            force 'org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.22'
        }
    }
}

wrapper/gradle-wrapper.properties
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.9-bin.zip
networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists

Environment Details:

Java version: 22.0.2 (build 22.0.2+9-70)
Gradle version: 8.9
Flutter version: Latest

Flutter Doctor output

Doctor output

[√] Flutter (Channel stable, 3.24.0, on Microsoft Windows [Version 10.0.22635.4010], locale en-US)
    • Flutter version 3.24.0 on channel stable at E:\ali\flutter system\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 80c2e84975 (13 days ago), 2024-07-30 23:06:49 +0700
    • Engine revision b8800d88be
    • Dart version 3.5.0
    • DevTools version 2.37.2

[√] Windows Version (Installed version of Windows is version 10 or higher)

[!] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
    • Android SDK at C:\Users\Ammar\AppData\Local\Android\sdk
    • Platform android-34, build-tools 33.0.1
    • Java binary at: C:\Program Files\Common Files\Oracle\Java\javapath\java.exe
    • Java version Java(TM) SE Runtime Environment (build 22.0.2+9-70)
    X Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/to/windows-android-setup for more details.

[X] Chrome - develop for the web (Cannot find Chrome executable at .\Google\Chrome\Application\chrome.exe)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.

[!] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.7.1)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.7.34009.444
    X Visual Studio is missing necessary components. Please re-run the Visual Studio installer for the "Desktop development with C++" workload, and include these
      components:
        MSVC v142 - VS 2019 C++ x64/x86 build tools
         - If there are multiple build tool versions available, install the latest
        C++ CMake tools for Windows
        Windows 10 SDK

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/to/windows-android-setup for detailed instructions).

[√] VS Code (version 1.92.1)
    • VS Code at C:\Users\Ammar\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.94.0

[√] Connected device (2 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.22635.4010]
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 128.0.2739.9

[√] Network resources
    • All expected network resources are available.

! Doctor found issues in 4 categories.

Looks like you are mixing Gradle version with Android Gradle Plugin (AGP) version - they are not the same. There is no 8.9.0 AGP version, see here for all available versions: https://maven.google.com/web/index.html?q=com.android.tools.build#com.android.tools.build:gradle

Given that the agp version provided does not yet exist, I'll be closing this issue.
Thank you


Fixes Issue#74

This issue fixes issue #74.

OS: Ubuntu
OS Version: 17.10
Python Version: 2.7

Hello,
Thanks for your contribution, I fixed the conflict, Please if I did it wrong let me know. PR merged.
Best Regards.


All JS modulepreload tags are within ROOT DIV element

Thanks for creating this wonderful library to enable Selective Hydration.
After this change, I find all the "modulepreload" link tags placed within our new <div id="root"> element. I am not sure why though Remix's Meta and Links are within the createHead method only.
export const Head = createHead(() => {
    const data = useRouteLoaderData<typeof loader>("root");
    return (
        <>
            <meta charSet="utf-8" />
            <meta name="viewport" content="width=device-width, initial-scale=1.0, minimum-scale=0.5, maximum-scale=3.0, interactive-widget=resizes-content" />
            <meta name="robots" content="index, follow" />
            <Meta />
            <Links />
        </>
    );
});

I am also using Layout Export feature of Remix and my Layout is as follows
export function Layout({ children }: { children: React.ReactNode }) {
    return (
        <>
            <Head />
            {children}
            <ScrollRestoration />
            <Scripts />
        </>
    );
}

Is there anything I am doing wrong here? This is just placing the various modulepreload tags later when it should ideally have been in the head

Is it because we are doing renderToString on HEAD and Meta and Links do not have any context on the current route and therefore not reading the vite manifest properly to inject the relevant modulepreload links. Later, <Scripts /> is bringing it and somehow moving it to the top of the ROOT element.


adding date_created csv

@Gustry @markherringer
this fix #849
importer can receive date_created to custom date (like for osm)
new template
__template.zip

LGTM to me, it seems to work !


Suggest adjust bookkeekper.conf default FlushEntryLogBytes to 256MB to improve bookie io throughput

Motivation
When AddEntry to bookie, entries will be written to memtable first and then written to the journal log. If it blocked in memtable write, the total AddEntry operation will be blocked, and the 99th AddEntry latency will increase.
When memtable full or checkpoint scheduled by timer, memtable will be swapped with backup one. However, if the backup memtable has not been flushed to disk complete yet, the memtable swap will be blocked, and the AddEntry operation will be blocked. So in which situation the backup memtable will be blocked?
When pulsar doing catch-up read, large amount of data will be read from ledger disk, and ledger disk io util will increase. At the same time, backup memtable will flush data from PageCache to disk triggered by OS (default is 30s) or rolling file no matter for HDD or SSD. It is hard to control the flush frequency and batch size in each flush cycle. In most cases, the flush batch size of each flush cycle is from 500MB to 1GB, which will lead to the ledger disk io util to 100% from 1s to 10s+, especially when large amount of read from the ledger disk in the same time.
Changes
In order to decrease ledger disk high io util duration, we can control the backup memtable flush batch size from pageCache to disk. In my practice, the flush batch set to 256MB may perform better for HDD disk.
So I suggest adjust the default configuration FlushEntryLogBytes to 256MB in bookkeeper.conf to increase bookie io throughput.

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks


External transition type level validation

There are some long term upgrades I want to make to this mechanism, however, in the interest of time, I am going to call this good enough to merge into master. I plan to improve the interface with some more type aliases (and hopefully better names), and have a tighter interface that exposes less information. I made a couple of issues to track the remaining work.
https://github.com/CodaProtocol/coda/issues/2479
https://github.com/CodaProtocol/coda/issues/2480

Looks good minus nits. I really like the way the validation code looks with this change.


Add version checks to API/Config server

Istio Config server (manager/mixer) should have version check for backwards incompatibility with older versions of pre-alpha/alpha istioctl. Longer term (beta/post-beta) the API and config server should maintain backwards compatibility and/or fail gracefully.

From https://github.com/istio/manager/issues/722

hackathon feedback:
gcloud (and other command line tools) check if a newer version is available. This would be very useful from a user experience standpoint.

More importantly, istioctl should negotiate a version with the remote in-cluster apiserver.

Issue moved to istio/galley #9 via ZenHub


Cc2024

update of the BioNT logo and typos in the news for CC2024

@hexylena or @shiltemann: I would like to have a 'small' heading in the middle of this post. However, only the first level heading does not give an error/warning. If you have any suggestions, on how to fix this it would be great. But you can also leave it as it is.
@shiltemann thanks for spotting the typos.

Hi @teresa-m, thanks!
We can just ignore the error about the heading level, that is more important for tutorials than here, so don't worry about it too much

Thanks, good to know! Thanks a lot!


Does unpatchify average between overlapping patches?

How do the unpatchify works for overlapping patches?
Does it average the values in overlapped area or it takes the value of the next patch as it is?
Thanks.

Hi @ritulahoti it won't do average. If the patches are overlapped, patchify will de-overlapping and recover the original image if this condition holds The required condition to successfully recover the image using unpatchify is to have (width - patch_width) mod step_size = 0 when calling patchify. (as mentioned in readme)

Hi, thanks for a quick response.
I'm trying to patchify an image and unpatchify the segmentation maps of the generated patches. So, for given two overlapping patches with varying probability values within, what values does the overlapping section get? (Conditions are being met)

No, the overlapped patches will be de-overlapped. E.g. for the 1d case, the original image is [a,b,c], patchily with step size 1 produces two patches. patch 1 is [a,b] and patch 2 is [b, c], then the patch 2 will be trimmed to [c] only when doing unpatchify. Then it will be concatenated with [a,b] to recover the original [a,b,c] image.
Weiyuan Wu   | Ph.D. Student @SFU-DB
a: 8888 University Dr., Burnaby, BC, CA
@.***  w: wooya.me
On Jun 5, 2021, 10:30 PM -0700, Ritu Lahoti @.***>, wrote:

Hi, thanks for a quick response.
I'm trying to patchify an image and unpatchify the segmentation maps of the generated patches. So, for given two overlapping patches with varying probability values within, what values does the overlapping section get? (Conditions are being met)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

Alright, I got it.
However, in my segmentation experiment, after applying unpatchify, the output shows a shifted results. Although its de-overlapping, the segmentation results should not shift, right?
Also, any help on how can I average the overlapping regions value?

Alright, I got it.
However, in my segmentation experiment, after applying unpatchify, the output shows a shifted results. Although its de-overlapping, the segmentation results should not shift, right?
Also, any help on how can I average the overlapping regions value?

This must be a bug if the result is shifted. Would you mind providing your image size and the step size/patch size you used?
For averaging the overlapping values, unfortunately, I think you need to change the code in thedef unpatchify since I didn't design this functionality into the library.

Sure.
Image size: (160,160,144), patch size: (64,64,64), step=32
Thanks.


Charts are broken and not rendered with LWS turned on

Who is the bug affecting?
Consumers of LightningWebChartJS repo individually with custom deploy of components.
What is affected by this bug?
Some of the Charts are broken and not rendered
When does this occur?
After enabling LWS(Lightning Web security) on the org.
Where on the platform does it happen?
Where c-chart LWC components are used.
How do we replicate the issue?
Enable setting Use Lightning Web Security for Lightning web components from Setup -> Session settings
Expected behavior (i.e. solution)
All Charts should work with LWS turned on.
Other Comments
Problem: sanitize method in utils lwc

Hi @Manish-Padakanti , thanks for your feedback and for using the solution !
I am running some tests in an org with LWS enabled and the charts (Chart Builder and custom chart) are working for me. I've also run some ESLint tests for LWS and getting nothing...
Can you please share the code of the chart you're trying to use? That will help us investigate the problem.
Thanks !

Hi @Manish-Padakanti ,
I've successfully reproduced the error from my side, but unfortunately we cannot do anything as the error with LWS comes from the Chart.js library we're referencing.
You mentioned in the description that the problem comes from the sanitze function. I've tested in the LWS Console and the function works fine with LWS enabled.
We've also incuded new ESLint validations for LWS (#107) and our components are compliant. However, the error returned "Invalid mutation: Cannot define property _chartjs on..." comes from the library (Chart.js 2.8.0) included as a static resource.
I am going to update the FAQ in the documentation to mention this case, but for now there's nothing we can do.
We're planning to upgrade the library to make it work with the latest version of Chart.js (3.x). We cannot guarantee that the new version will fix the LWS issue, and we don't have neither an ETA for this upgrade (it requires a lot of rework of the solution).
Sorry for the inconveniences and thanks for using the solution !

Chart JS version 4.3 confirmed working with LWS enabled. This project appears abandoned, is there anyone actively working on it anymore?

Hi @user851, thanks for the feedback on LWS, that's actually good news !
For information, we're still maintaining the project (you can have a look at the latest issues) with the Chart JS version it was implemented initially.
We've thought about migrating to a new Chart JS version, but honestly there's a lot of work to do. It wouldn't be only to replace the library but we would also need to :

Review the configuration objects (a lot of things have changed in ChartJS side)
Deprecate and include new attributes
Make sure that we can have a retro-compatibility with the current users

We'll re-think about it anyway. Thanks again!


cranelift: Rename i{min,max} to s{min,max}

👋 Hey,
This brings these instructions in line with our general naming convention of signed instructions being prefixed with an s. The matching u{min,max} instructions already follow this convention.
The only other instructions that I could find that break this naming convention are iadd_{carry,cout}/isub_{borrow,bin}, which are discussed in: #5165

We've fixed the Rust 1.65 build failure on main; could you rebase?


New operator to check wether a number is divisible by another

Well, my Idea was to add a new operator. It's binary and returns a boolean:
%%
It would check, wether a certain number is divisible by another. For example, 12 %% 4 would return true, 12 %% 5 false. It's basicly just
a % b == 0
but shorter. Might not be as understandable but I don't think that's a big issue.

$ coffee
coffee> divides = (a, b) -> b % a is 0
[Function]
coffee> divides 4, 8
true
coffee> divides 4, 9
false
coffee>

It's been a while since one of these kinds of proposals has come up. Unfortunately for you, it's coffeescript policy not to adopt a syntax for something that could be done just as easily with a simple helper function. Also, I don't think it's commonly needed. -1.

Could I add it myself, only for myself? If so, where?

Sure, fork the project. It'd be a little more involved than just pointing you to a specific line. You would have to add it to the grammar and then describe how its AST node compiles. If you've never worked on a compiler, you should probably read a book or something first.

As a side note, this is something where Haskell-style backticks would come in handy.
coffee> divides = (a, b) -> b % a is 0
coffee> divides 4, 8
true
coffee> 4 `divides` 8
true

@alpha123: see #1429

Was there every any consensus on that?

You tell me. You can see the same discussion I see, and the issue is still open. Go ahead and add your opinion.


fix: upgrade sp1-sdk to resolve compile issue

When I was building raiko using docker according to https://github.com/taikoxyz/raiko/blob/main/docs/README_Docker_and_RA.md, I encountered an issue where the blake3-zkvm dependency could not be found. Upon investigation, I found that the upstream repository https://github.com/sp1-patches/BLAKE3 has been deleted, and the latest version of sp1 no longer depends on it.
Furthermore, the documentation specifies using the taiko/alpha-7 branch for the build. Perhaps an alpha-8 branch should be created to implement this fix?
    Updating git repository `https://github.com/sp1-patches/BLAKE3.git`
ERROR: Repository not found.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
error: failed to get `blake3-zkvm` as a dependency of package `sp1-core v0.1.0 (https://github.com/succinctlabs/sp1.git?branch=main#2f57e1e7)`
    ... which satisfies git dependency `sp1-core` (locked to 0.1.0) of package `sp1-sdk v0.1.0 (https://github.com/succinctlabs/sp1.git?branch=main#2f57e1e7)`
    ... which satisfies git dependency `sp1-sdk` (locked to 0.1.0) of package `sp1-driver v0.1.0 (/Users/rustist/Developer/raiko/provers/sp1/driver)`
    ... which satisfies path dependency `sp1-driver` (locked to 0.1.0) of package `raiko-host v0.1.0 (/Users/rustist/Developer/raiko/host)`

Caused by:
  failed to load source for dependency `blake3-zkvm`

Caused by:
  Unable to update https://github.com/sp1-patches/BLAKE3.git?branch=patch-blake3_zkvm/v.1.0.0#bac2d59f

Caused by:
  failed to clone into: /Users/rustist/.cargo/git/db/blake3-551cb6a9ae540f14

Caused by:
  process didn't exit successfully: `git fetch --tags --force --update-head-ok 'https://github.com/sp1-patches/BLAKE3.git' '+refs/heads/*:refs/remotes/origin/*' '+HEAD:refs/remotes/origin/HEAD'` (exit status: 128)

This issue can be resolved by running cargo update sp1-sdk.

Thanks! this problem is fixed by commit https://github.com/taikoxyz/raiko/pull/282/commits/3b2108827b297c4b9a534d691362ad8706360957 which had been merged to main :)


Work on solution to rise recovery of Nomad hack victimes

Package
contracts-bridge, contracts-core, contracts-router, deploy, indexer, local-environment, multi-provider, sdk-bridge, sdk-govern, sdk, not applicable (please describe)
Describe the feature you would like
The real road to recovery of victims :
https://medium.com/@jamestrulard/explore-solutions-to-rise-recovery-of-nomad-bridge-exploit-victims-b3d8058d9ddb
Additional context
No response

Many solutions exist among others:
Use the treasury of Nomad Company (Nomad raised 22,4M$ in April 2022).
Negociate with some Mad assets holders to write-off their debt for Nomad Equity & future $Nomad governance token. For exemple for ETHmad holders who would have a recovery 0–5%, better to give them equity with a option from Nomad to buy it back 85% if ETH are returned in the future. It will allow to rise recovery of retailers who are not able to take equity part of Nomad. here some details : https://medium.com/@jamestrulard/onchain-analysis-of-eth-nomad-assets-on-moonbeam-91423668ea17
Founders’ personal contribution (They are into crypto for a while and worked in several high market cap crypto project like CELO, Storj). here some details : https://medium.com/@jamestrulard/pranay-mohan-invested-into-5m-sround-lifi-protocol-700d05c8c678
Fundraising in equity, tokens and Debt
Search acquirors to sell the company
Dedicate the about +10 devs of Nomad on projects to generate fees to rise victims recovery.
We are looking for Nomad founders and shareholders to demonstrate significant efforts. If the full 100% recovery of users would not be possible, victims are looking for any solution to rise the recovery ratio step by step instead of waiting a whole recovery one or a better macro crypto condition as bull market can not come back before many years if never.

Make AMA sessions with community and victims

Demonstrate the efforts on financing solutions

Let opened any discussion in forum and Discord without censorship.

Nomad team said they were exploring all options available to recover funds beyond law enforcement and tracking hackers to return stollen funds. In their Medium, they highlighted to put user first and we want it really to apply, as it seems for now a Founders and shareholders first before users.
We would like to create a community opened discussion to find solution. About 190M$ have been exploited 1 August 2022. About 30M$ have been recovered, making about 160M$ missing the refinance.
The main exploiter (wallet 1–3) holds about 100M$ of funds. Then one hacker (if not 2) holds about 62,5% of all funds missing.
Best regards,
A individidual acting for the victims community.


Make Bert.RateLimiters .netstandard2.0-compliant

Hello,
This is not an issue with any fuctionality per se, but with the project setup. I've put together a PR (see https://github.com/robertmircea/RateLimiters/pull/10) to move to the new SDK project style and to target .netstandard2.0. Currently, using RateLimiters results in warnings about the wrong framework being targetted and it would be nice to get rid of those. This PR achives this. Can I ask you to merge it in if you're happy with it, and to republish the nuget package, please?
Thanks,
MT

Thanks for the PR. I've merged it and published a new version on nuget.org. I've also introduced Nuke Build as a build system for the library for easier versioning and publishing of new releases.

Thank you very much, have confirmed it all works and builds .netstandard2.0/netcore apps without grumbling!


add data type property and filter

part of #205
The data types I have curated for now:

genomic
proteomic
metabolomic
demographic
clinical
imaging
ehr
other

We could use enum, but I am afraid there will be more datatypes in the future. So I just use similar schema as "topics".

Our Submission Type is similar to Tool Type. However if we accept non-tool submissions (e.g. research paper), Submission Type is a suitable name.

Our Submission Type is similar to Tool Type. However if we accept non-tool submissions (e.g. research paper), Submission Type is a suitable name.

submission type makes more sense to me. Tool Type sounds more like what tools used in the challenges and this could be overlapped with programming languages/skills to me.

Do you think that the user would appreciate this granularity in the challenge registry?

I cannot speak for everyone, but personally for Output data,  Input format and Output format, I feel they are good to have, but not necessary for the use case on the challenges data.

@tschaffter in terms of the filter name,  my preference: "Input Data" > "Data Type" > "Training Data"


more airbnb tests

From the documentation : https://github.com/airbnb/javascript/blob/master/README.md

@christophehurpeau Thanks for contributing!


[release-v1.66] Pin previous release for upgrade tests to a commit

How to categorize this PR?

/area testing
/kind bug
What this PR does / why we need it:
This PR pins the previous release for upgrade test to commit https://github.com/gardener/gardener/commit/6bf444481e6bebf13f6b7ab7c72cd18e44c3c7b5.
It contains changes required to run on cgroupv2 nodes and there is not patch version which include those changes yet.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

NONE

/hold

/hold cancel

/override pull-gardener-e2e-kind-migration-release-v1-66
This PR pins the previous gardener version for upgrade tests only. Migration tests currently fails for a different reason which is going to be fixed soon