No audio, just video

I'm trying to have Vapoursynth pipe video with audio to ffmpeg, so far had no luck with libbestaudiosource (seems to open but FFMPEG doesn't see any stream beyond #0 video from ffms2, even trying to pass audio stream alone), neither with libbestsource. FFmpeg only gets Stream #0:0 with video, no audio.
I've tried different videos. With older stuff with 8-bit PCM it throws this error:
vapoursynth.Error: AudioSource: Unsupported audio format from decoder (probably 8-bit)
MediaInfo of the file:
Format                                   : AVI
Format/Info                              : Audio Video Interleave
File size                                : 7.81 MiB
Duration                                 : 7 s 0 ms
Overall bit rate                         : 9 362 kb/s

Video
ID                                       : 0
Format                                   : JPEG
Codec ID                                 : MJPG
Duration                                 : 7 s 0 ms
Bit rate                                 : 9 212 kb/s
Width                                    : 640 pixels
Height                                   : 480 pixels
Display aspect ratio                     : 4:3
Frame rate                               : 30.000 FPS
Color space                              : YUV
Chroma subsampling                       : 4:2:2
Bit depth                                : 8 bits
Scan type                                : Progressive
Compression mode                         : Lossy
Bits/(Pixel*Frame)                       : 1.000
Stream size                              : 7.69 MiB (98%)
Title                                    : FUJIFILM AVI STREAM 0100

Audio
ID                                       : 1
Format                                   : PCM
Format settings                          : Unsigned
Codec ID                                 : 1
Duration                                 : 7 s 0 ms
Bit rate mode                            : Constant
Bit rate                                 : 128 kb/s
Channel(s)                               : 1 channel
Sampling rate                            : 16.0 kHz
Bit depth                                : 8 bits
Stream size                              : 109 KiB (1%)
Alignment                                : Aligned on interleaves
Interleave, duration                     : 1000  ms (30.00 video frames)
Interleave, preload duration             : 1000  ms

Vapoursynth was compiled from the master (r67) and also tried the r66 release.
The script is minimal :
import vapoursynth as vs
core= vs.core #core = vs.get_core()

source='/examplepath/to/file.mp4'
clip = core.bs.VideoSource(source=source)
audio = core.bs.AudioSource(source=source, track=1)
clip.set_output(index=0)
audio.set_output(index=1)

Running it on a recent video from smartphone and output:
LD_LIBRARY_PATH=/usr/local/lib PYTHONPATH=/usr/local/lib/python3.8/site-packages vspipe -c y4m script.py - | ffmpeg -i -   /dev/shm/test.mp4
ffmpeg version 6.1.1 Copyright (c) 2000-2023 the FFmpeg developers
  built with gcc 13 (Ubuntu 13.1.0-8ubuntu1~20.04.2)
  configuration: --prefix=/home/user/ffmpeg_build --extra-cflags='-I/home/user/ffmpeg_build/include -fPIC' --extra-ldflags='-L/home/user/ffmpeg_build/lib -fPIC' --bindir=/home/user/bin --extra-libs=-ldl --enable-gpl --enable-libass --enable-libmp3lame --enable-nonfree --enable-libfdk-aac --enable-shared
  libavutil      58. 29.100 / 58. 29.100
  libavcodec     60. 31.102 / 60. 31.102
  libavformat    60. 16.100 / 60. 16.100
  libavdevice    60.  3.100 / 60.  3.100
  libavfilter     9. 12.100 /  9. 12.100
  libswscale      7.  5.100 /  7.  5.100
  libswresample   4. 12.100 /  4. 12.100
  libpostproc    57.  3.100 / 57.  3.100
Input #0, yuv4mpegpipe, from 'fd:':
  Duration: N/A, start: 0.000000, bitrate: N/A
  Stream #0:0: Video: rawvideo (I420 / 0x30323449), yuv420p(progressive), 1920x1080, 30 fps, 30 tbr, 30 tbn
Stream mapping:
  Stream #0:0 -> #0:0 (rawvideo (native) -> mpeg4 (native))
Output #0, mp4, to '/dev/shm/test.mp4':
  Metadata:
    encoder         : Lavf60.16.100
  Stream #0:0: Video: mpeg4 (mp4v / 0x7634706D), yuv420p(progressive), 1920x1080, q=2-31, 200 kb/s, 30 fps, 15360 tbn
    Metadata:
      encoder         : Lavc60.31.102 mpeg4
    Side data:
      cpb: bitrate max/min/avg: 0/0/200000 buffer size: 0 vbv_delay: N/A
frame=  139 fps=0.0 q=31.0 size=    2560kB time=00:00:04.60 bitrate=4559.1kbits/s speed=9.16xframe=  291 fps=289 q=31.0 size=    4864kB time=00:00:09.66 bitrate=4122.0kbits/s speed=9.61xOutput 323 frames in 1.10 seconds (292.93 fps)
[out#0/mp4 @ 0x55f54be1a280] video:5252kB audio:0kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: 0.043830%
frame=  323 fps=280 q=31.0 Lsize=    5254kB time=00:00:10.73 bitrate=4009.9kbits/s speed=9.31x

Video details:
Format                                   : MPEG-4
Format profile                           : Base Media / Version 2
Codec ID                                 : mp42 (isom/mp42)
File size                                : 27.4 MiB
Duration                                 : 10 s 880 ms
Overall bit rate                         : 21.2 Mb/s
Encoded date                             : UTC 2024-01-22 09:35:47
Tagged date                              : UTC 2024-01-22 09:35:47
com.android.version                      : 12
mcvr                                     : redacted special characters

Video
ID                                       : 1
Format                                   : AVC
Format/Info                              : Advanced Video Codec
Format profile                           : High@L1
Format settings                          : CABAC / 1 Ref Frames
Format settings, CABAC                   : Yes
Format settings, Reference frames        : 1 frame
Format settings, GOP                     : M=1, N=30
Codec ID                                 : avc1
Codec ID/Info                            : Advanced Video Coding
Duration                                 : 10 s 860 ms
Source duration                          : 10 s 765 ms
Bit rate                                 : 20.0 Mb/s
Width                                    : 1 920 pixels
Height                                   : 1 080 pixels
Display aspect ratio                     : 16:9
Frame rate mode                          : Variable
Frame rate                               : 30.000 FPS
Minimum frame rate                       : 29.910 FPS
Maximum frame rate                       : 30.090 FPS
Color space                              : YUV
Chroma subsampling                       : 4:2:0
Bit depth                                : 8 bits
Scan type                                : Progressive
Bits/(Pixel*Frame)                       : 0.321
Stream size                              : 25.7 MiB (94%)
Source stream size                       : 25.7 MiB (94%)
Title                                    : VideoHandle
Language                                 : English
Encoded date                             : UTC 2024-01-22 09:35:47
Tagged date                              : UTC 2024-01-22 09:35:47
Color range                              : Limited
Color primaries                          : BT.709
Transfer characteristics                 : BT.709
Matrix coefficients                      : BT.709
mdhd_Duration                            : 10860
Codec configuration box                  : avcC

Audio
ID                                       : 2
Format                                   : AAC LC
Format/Info                              : Advanced Audio Codec Low Complexity
Codec ID                                 : mp4a-40-2
Duration                                 : 10 s 880 ms
Bit rate mode                            : Constant
Bit rate                                 : 192 kb/s
Channel(s)                               : 2 channels
Channel layout                           : L R
Sampling rate                            : 48.0 kHz
Frame rate                               : 46.875 FPS (1024 SPF)
Compression mode                         : Lossy
Stream size                              : 255 KiB (1%)
Title                                    : SoundHandle
Language                                 : English
Encoded date                             : UTC 2024-01-22 09:35:47
Tagged date                              : UTC 2024-01-22 09:35:47

FFMPEG 6.1.1 compiled from tarball release https://ffmpeg.org/releases/
ffmpeg
ffmpeg version 6.1.1 Copyright (c) 2000-2023 the FFmpeg developers
built with gcc 13 (Ubuntu 13.1.0-8ubuntu1~20.04.2)
configuration: --prefix=/home/user/ffmpeg_build --extra-cflags='-I/home/user/ffmpeg_build/include -fPIC' --extra-ldflags='-L/home/user/ffmpeg_build/lib -fPIC' --bindir=/home/user/bin --extra-libs=-ldl --enable-gpl --enable-libass --enable-libmp3lame --enable-nonfree --enable-libfdk-aac --enable-shared
When compiling bestsource-R1 I exported the Pkg config dir of FFmpeg 6.1.1:
export PKG_CONFIG_PATH=/home/user/ffmpeg_build/lib/pkgconfig
But I always end up linking the ffmpeg .so files into /usr/local/lib/
zimg and xxHash-0.8.2 also compiled from latest release

from vapoursynth import core
print(str(core))
VapourSynth Video Processing Library
Copyright (c) 2012-2023 Fredrik Mellbin
Core R66
API R4.1
API R3.6
Options: -
Number of Threads: 16
Max Cache Size: 4096

gcc --version
gcc (Ubuntu 13.1.0-8ubuntu1~20.04.2) 13.1.0
lsb_release -a
Distributor ID:	Ubuntu
Description:	Ubuntu 20.04.6 LTS
Release:	20.04
Codename:	focal
uname -a
Linux R7x 5.19.17-051917-generic #202210240939 SMP PREEMPT_DYNAMIC Mon Oct 24 09:43:01 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Thanks for vapoursynth and the plugins and of course I would appreciate your help to get audio working

The answer is simple: VS doesn't support 8 bit audio and I didn't implement any conversion to 16 bits inside bestsource. I'll put it on the todo list since someone (you) actually asked for it now.

Thanks for the quick reply. The problem with 8-bit is only in older files, the more recent ones are as specified in the video details above (AAC LC), so it seems something is definitely going in but not coming out the other side. I've tried outputting to mplayer and there's no audio there either.


CC72496:  Adding technical references

Hello, @sffamily,
This proposed file change comes from https://github.com/MicrosoftDocs/azure-docs.it-it/pull/93 .
Could you review this contribution and help to merge if agreed?
Many thanks in advance.

@v-makoud : Thanks for your contribution! The author, @sffamily, has been notified to review your proposed change.

#sign-off


CI: Support release on workflow triggering

Maintainer can trigger release process by going to actions -> Open release pr -> Run workflow

I've already configured the cargo registry token with permission limited to publishing new version of async-compression.

Oops, I forgot that I can merge things without approval.

Well if there is any objection, I can revert this PR.


Make course search faster

MongoDB full-text search is quite slow (visible latency), could we leverage something else to make it faster? Some options:

Redis full-text search module, in-memory so everything is super quick to access => see mcgill.wtf for an example
Client-side search? Does fuse.js blow up if we try to search through all of our course records => 10,000? Or could we use https://github.com/lucaong/minisearch?
Atlas search, this is a MongoDB cloud feature - supports fuzzy search and stuff, could be something
https://github.com/quickwit-oss/tantivy

[ ] (discovery) FlexSearch


Scaffolded Controllers should end with a newline

The typical convention is for files to end with a newline (}\r\n instead of }).  However, Controllers generated by Scaffolding just end with a bare }.

@mkArtakMSFT - This is another content issue.


Interpolated multiline strings syntax coloring gets messed despite compiling fine

Issue Type: Bug
This has been an issue for a while and has been a minor annoyance and I guess I was too lazy to report it, sorry about that.
Basically in a C# code file if you create a multiline interpolated string, and use {} for substitution at the very beginning of a line the coloring gets screwy, but it still compiles fine.
Specifically:
public void Main(){
    int foo = 0;
    string test = $@"
 {foo} (there is a space at the beginning of this line!)
    ";
}

Works fine! Compiles correctly and is colored correctly:

However if you remove the space before {foo} it gets screwy:

On it's own it's not a big deal, but if you start doing function calls within the substitution area the context get's all sorts of messed.
Please let me know if there are any other details you need.

Duplicate of https://github.com/dotnet/csharp-tmLanguage/issues/131

Ugh. Apologies apparently I posted the original issue as well. Guess I forgot about it.


[3.x] Kotlin 1.3 compatibility

The current generated code assumes Kotlin 1.4 and breaks on stuff like trailing comas, we should make sure the generated code works with Kotlin 1.3

Is Kotlin Native binary compatible with <1.4? Let's say that Apollo graphql generator generates KT 1.3 compatible code, but Apollo runtime library has dependency on Coroutines library which is compiled with KN 1.4. Will it work?

Generally speaking every new Kotlin release requires every native lib and app to be rebuilt.
I didn't look into all the details but binary compatibility is wayyyyy different on native than it is on the JVM. If you're using a native version of apollo build with Kotlin 1.4, you'll most likely have to compile everything with 1.4 including the generated models.

It looks like the 1.3 compiler can actually not read metadata from 1.5 so 1.3 compatibility doesn't seem possible at that point. Users will have to update. Also good thing we have this in the README.md already.


Testing Update

I'd like to be able to write tests for the update function of my Ratatouille app, but I'm having some trouble.
Based off the counter example:
  describe "update" do
    test "when + is pressed, the model is incremented by 1" do
      assert Counter.App.update(0, {:event, %{ch: ?+}}) == 1
    end
  end

Fails with (UndefinedFunctionError) function Counter.App.update/2 is undefined or private

I had just misnamed my test module, sorry about that.


Non-ASCII characters in storage directory path

cppan doesn't seem to handle non-ascii characters in storage_dir path correctly. Running it with:
storage_dir: D:\Libraries\cppan-storage

in cppan.yml doesn't cause any issues, but changing it to:
storage_dir: D:\Libraries\cppąń-storage

produces the following error:
C:\>cppan
Can't open database file: D:/Libraries\cpp╣˝-storage\etc\database\service.db error: unable to open database file

I'm running 64-bit Windows 10 Education N Version 1607
Edit: Also having non-ascii characters in TEMP path causes build process to fail

Hi,
Yes, this is a known issue, please use only latin letters for the moment.

Chinese characters also have this kind of problem

I've implemented unicode dir and file names handling, so update you cppan client via cppan --self-upgrade or from website and try it.
ps.
It does not work for me completely because ninja cannot handle unicode paths and also when trying to build with cmake --build ., for example, with visual studio. But on cppan side everything should work.

Marking this as fixed, please, comment if you still have unicode path issues.


xvega builds up to 0.0.4 build 0 were not properly pinning nlohmann_json's version used at build time

This is fixed in #4, however, earlier builds should be marked as broken.

Should this be closed now?


adding USIL to the repository

Adding Universidad San Ignacio de Loyola, Lima, Peru.

please confirm pull request to add Universidad San Ignacio de Loyola to repository.

the university domain is http://www.usil.edu.pe/ - please somehow conifrm that the committed domain also belongs to the university and is used for emails

As you can verify on this link:
http://www.usil.edu.pe/0/modulos/jer/jer_interna.aspx?are=0&pfl=0&jer=853

The official link for students redirect to Office 360 with usil.pe as realm.
By some reason the university gave us "usil.pe" domain, "usil.edu.pe" is for administrative personnel only. If you need another way to verify the ownership please tell me what do you need to ask them.
Thanks.

thanks a lot for your timely help, i'm adding the domain!


[8] Add yaml to setup, update reqs

Checklist:

[ ] I have refactored my code out from notebooks/
[ ] I have checked the code runs
[ ] I have tested the code
[ ] I have run pre-commit and addressed any issues not automatically fixed
[ ] I have merged any new changes from dev
[ ] I have documented the code

[ ] Major functions have docstrings
[ ] Appropriate information has been added to READMEs

[ ] I have explained the feature in this PR or (better) in output/reports/
[ ] I have requested a code review

ah shoot this was still in draft whilst I was prototyping a test

I'll open a new PR


Copy DecomposeAggregatedOps pass from tpp-mlir

Copied from tpp-mlir project
The current MLIR repo does not offer an easy-to-use pass for decomposing linalg.softmax, and tpp-mlir provide a solution
track: https://github.com/intel/graph-compiler/issues/214

We're waiting the upstream solution from: https://github.com/llvm/llvm-project/pull/97582. @kurapov-peter would you please provide some insights?

We're waiting the upstream solution from: llvm/llvm-project#97582. @kurapov-peter would you please provide some insights?

Oh, I did not notice this PR on llvm

Unfortunately it won't land in the nearest future. The decision is to create a generic decomposition mechanism (that I'm working on now). I could put a similar implementation into GC if we need it. Do we?

Please rebase.


can i build this jar with jdk 1.7

I changed the source and target in pom.xml from 1.8 to 1.7. the jar was created successfully. Will i face any issues using it ? @ianopolous

If it compiles to 1.7 then it should be fine. Let me know if it isn't.

Using the jar gives me error. java.util.Optional is a feature of jdk 1.8

Ah yes, Optionals only arrived in 1.8. Are you unable to upgrade?


How to solve the loss of precision in the process of voxel transformation of mesh？

I'm sorry I haven't had time to use the library yet. But I have a question to ask. When I export the stl segmentation file to nrrd or nii format use
ing 3d slicer, I will face a great loss of precision. Does the library solve this problem, and if so, is it related to the resolution of ReferenceImage? Thank you very much!!

It would be nice if we could set the resolution.

Hi. Apologies for the delayed response, I've been very busy. I'm sorry, but as the code is right now, the resolution of the ReferenceImage is the resolution that the resulting .nii file will have. If you have any suggestions on how to change that, I'd love to hear them. Honestly, I'm not an expert in stl meshes whatsoever.

Hi. Apologies for the delayed response, I've been very busy. I'm sorry, but as the code is right now, the resolution of the ReferenceImage is the resolution that the resulting .nii file will have. If you have any suggestions on how to change that, I'd love to hear them. Honestly, I'm not an expert in stl meshes whatsoever.

Thank you for taking the time to respond. I am trying to solve this problem through Slicer Python API!

Hi @Dobmod ,
Please let me know if you find out the solution!
Thanks!
Vicent

Hi @vcasellesb , I first attempted resampling to enlarge the ReferenceImage, and then used it to export the STL. This way, I achieved less loss!

Dear @Dobmod,
I'm glad you figured it out! Of course, the resulting nifti segmentation converted from the stl is going to match the dimensions and spacing from the reference image, so changing those is a good way to achieve it. However, I think it's very specific to your use case.


[FSDE-18643] Prepare Chi 5.13.0 release

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-376/1/. :white_check_mark:

You can check this PRs instance in https://494fcc5c5e523810e1636ef49ad3cc8710c8ffbb-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-376-ux-chi.kubeodc-test.corp.intranet/ (internal)

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-376/2/. :white_check_mark:

You can check this PRs instance in https://8b6dcb95a4a44c05b61fb72bde8a73fef0dec4a8-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-376-ux-chi.kubeodc-test.corp.intranet/ (internal)

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-376/3/. :white_check_mark:

You can check this PRs instance in https://1cfcc32c09c91a8ae142b6d7e55caf2fa83fa045-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-376-ux-chi.kubeodc-test.corp.intranet/ (internal)


When using the Axum authentication example, the devserver proxy does not work

Problem
The server with the authentication layer is listening on port 3000, and works when using dx serve. However, the hot reloader server on port 8080 does not proxy to the other server and throws the error "Backend connection failed. The backend is likely still starting up. Please try again in a few seconds."
I think the issue is here which becomes the address to forward to here
Steps To Reproduce
Steps to reproduce the behavior:
Running the fullstack-auth example has the same issue
Expected behavior
The dev sever should use the correct port to forward requests to.
Environment:

Dioxus version:   master
Rust version:   1.81.0
OS info:         Windows 10
App platform:    fullstack

Questionnaire
I would like to fix and I have a solution
Add an argument to the serve command to set the inner server address

I'm wondering how this is supposed to work? Was it tested to function at all with custom (axum) backends?


fix: favicon in flask format , PR#34

this is a PR of UI: added a favicon to the site #31, PR #34
PR: #34 .
@kvcops issue resolved.

Still the issue persists...the favicon is not displaying ,please recheck for the problem

@kvcops you need to authorise deployment to check it.

let me deploy and check it out...

yep...its working...thanks for contributing for this project :)


AAC audio to MP3 file converter

Conversion testing was successful. But, I will have the script run separate from KIM since the installation and configuration of ffmpeg adds undo complexity to KIM.  Current thinking is to convert notes and then run a post converter if needed to change all notes with AAC audio links to the MP3 extension and convert each AAC file to MP3.
Steps - download ffmpeg, extract zip into a folder, add folder to the path, pip install ffmpeg, pip install pydub, pip install ffprobe - run converter.

Doesn't seem overly important. Will put on hold for now.

Going to close this. Too much effort for users to setup.


VSCode-designer-issue with ForEach and the variable below that

Describe the Bug with repro steps
Create foreach and create a variable below that

What type of Logic App Is this happening in?
Standard (VSCode)
Are you using Preview Designer or GA Designer
Generally Available
Workflow JSON
No response
Screenshots or Videos

Browser
VSCode
Additional context
No response

Hi @mhireholi thank you so much for raising this issue. Can you please elaborate a little bit more on what is the issue and what is the expected scenario/look?

@ccastrotrejo I'm able to repro this, this happens when there's an uneven parallel branch in a scope card, for example, because the condition node is a lot larger than the normal node, when adding it as a parallel node to a scope node, the scope card becomes off center.

Thanks @Eric, I will take a look at that


Improve BasePropertyComponent, and child components.

The problem
Right now we use BasePropertyComponent to render every component in the system. It was build in the beggingin and has pure documentation and types. Also, it exports child components like Array.Edit which are neither documented nor well typed.
Acceptance criteria

general refactor everything to Ract.FC
write proper types for all the child components
handle infinite loop case, when user wants to use BasePropetyComponent of the same property in custom component.
where possible add useMemo, useCallback not to render all the time.
add docs for child components

Any solution?

This should be resolved in AdminJS v7.


Add back the DISM ohai plugin installation in the default recipe

I removed this by accident when I removed all the gem installs. We need this still
Signed-off-by: Tim Smith<EMAIL_ADDRESS>

Even better


Specify max log levels in the config

To dial down the log noise a bit in production, we could add a log level to the config json. Example:
"log_level": "err"
Will only log errors and higher severity and discard the rest.

Implemented in 57572a93666500b3df4c81b8c744ae4723bf9fd5, e26c9c7696d8de6616d34f0e3a2d3e6d1ae9e990


disable revision view in frontend

For now we want to show those routes (/entity/repository/compare/ e.g. https://de.serlo-staging.dev/entity/repository/compare/1555/150196) in the old frontend.
For production and staging.

revisions are ready now


Objects in Nav tree are not Alpha ordered

Currently the nav tree is not sorted when loaded. The model has a list, but no sort is applied.  The tree can sort, but it is not applied.

Setting as enhancement, because GOTO as a right click option will go to the focused control which should be near where you want to be

Fixed in 2021.3.12


Allow expires_in equals 0

Some services (http://vk.com, no expiration) return "expires_in" equals 0 and no "expires".
In this case:
!empty($options['expires_in']) == FALSE
!empty($options['expires']) == FALSE
and expires property remain NULL

Coverage remained the same at 100.0% when pulling a17b6fcfe6ef8b837da5f0e61bd31e3ad8af2013 on artad:master into 4aec352f0a0e7be528384944e629d410a5dedc76 on thephpleague:master.

Coverage remained the same at 100.0% when pulling a17b6fcfe6ef8b837da5f0e61bd31e3ad8af2013 on artad:master into 4aec352f0a0e7be528384944e629d410a5dedc76 on thephpleague:master.

Coverage remained the same at 100.0% when pulling a17b6fcfe6ef8b837da5f0e61bd31e3ad8af2013 on artad:master into 4aec352f0a0e7be528384944e629d410a5dedc76 on thephpleague:master.

Thanks, @artad.
This seems to comply with the definition of "expires_in" in appendix A.14. of RFC 6749:
expires-in = 1*DIGIT

It can be 1 or more DIGIT, where RFC 5234 defines DIGIT as
     DIGIT          =  %x30-39
                            ; 0-9

Any concerns, @shadowhand?

LGTM.

Thanks!

Thanks for your attention

This breaks the code tho, hasExpireduses the PHP empty() function to determine if expires_in is set or not. 0 is considered empty using that function.
As is, it yields the following error
RuntimeException: "expires" is not set on the token in vendor/league/oauth2-client/src/Token/AccessToken.php on line 174


site service-level does not use explicit action

Unlike all but two other commands, site service-level does the following things:
Site flag only: Lists current service level on site
Site and set flags: Sets site to service level in set flag
Which is not as intuitive as other commands. Can we make this more explicit by adding subcommands?

site-info should show service level, set-service-level should be new action


Unset GOOS for running generate_cert/main.go during docker builds so …

…non-linux hosts can build. Fixes https://github.com/istio/istio/issues/2341

Hi @christian-posta. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

+1 yah i can add GOARCH to the PR too.


[FEATURE] Rename Work Experience label

Is your feature request related to a problem? Please describe.
Ambiguous field name when fill out Work Experience modal
Describe the solution you'd like
Rename Name field to Employer Name
Describe alternatives you've considered
Rename Name field to Company Name
N/A
Additional context
Education modal uses Institution to indicates a place where the user study. Meanwhile labeling Name to indicates a workplace might misleading at first read

@cbot59
I added an experience section to the leftSidebar of en/builder.json.
      "experience": {
        "form": {
          "name": {
            "label": "Company Name"
          }
        }
      }

After that on the WorkModal.tsx file, I changed the label  path
label={t<string>('builder.leftSidebar.sections.experience.form.name.label')}
Now it's showing the label as Company Name instead of Name.

But this project supports several languages. Should I need to add the experience section to all builder.json files?
I have no idea about other languages instead of Bengali and English. I already added the experience section to these languages.

@jobayer12 Good job sir. I think we need to the experience: {} to whole builder.json otherwise the code might error on other translation. Unless we had a way to provide a fallback value (name should be okay) in case experience: {} is missing.

@cbot59 I added the experience: {} on all builder.json files. Review my PR and if there is anything else I need to change please let me know.


Voiding mode

Is it possible to enable overflow voiding mod in ME Chest/Tank?

Currently no.
Maybe in the next release, you might leave this issue open untill it's implemented.

done https://github.com/reobf/Programmable-Hatches-Mod/releases/tag/v0.0.19p7-beta

Tnx <3
This one too? https://github.com/reobf/Programmable-Hatches-Mod/releases/tag/v0.0.19p7-GTNH270-beta

Yes they are basically the same thing, but with some different naming.
Because GTNH dev changed a lot of naming in 2.7.0.


Automated cherry pick of #5631: elb bugfix

Cherry pick of #5631 on release/2.13.
#5631: elb bugfix

Codecov Report

Merging #5636 into release/2.13 will decrease coverage by 0.05%.
The diff coverage is 1.59%.

@@               Coverage Diff               @@
##           release/2.13   #5636      +/-   ##
===============================================
- Coverage          6.86%   6.81%   -0.06%
===============================================
  Files               519     534      +15
  Lines             88131   90292    +2161
===============================================
+ Hits               6052    6150      +98
- Misses            81580   83634    +2054
- Partials            499     508       +9

Flag
Coverage Δ

#aFlag
6.81% <1.59%> (-0.06%)
:arrow_down:

Impacted Files
Coverage Δ

pkg/baremetal/manager.go
0.51% <0.00%> (ø)

pkg/cloudcommon/db/db_dispatcher.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/metadata.go
8.74% <0.00%> (-2.16%)
:arrow_down:

pkg/cloudcommon/db/modelbase.go
1.42% <0.00%> (-0.05%)
:arrow_down:

pkg/cloudcommon/db/namevalidator.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/opslog.go
1.94% <0.00%> (ø)

pkg/cloudcommon/db/paging.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/quotas/context.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/quotas/handler.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/quotas/quotas.go
0.00% <0.00%> (ø)

... and 140 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b73f544...a8cad04. Read the comment docs.


[Bug] EntryPointNotFoundException: GetModuleFileName

[REQUIRED] Please fill in the following fields:

Unity editor version: 2019.4.24f1
Firebase Unity SDK version: 8.0.0
Source you installed the SDK: .unitypackage (.unitypackage or Unity Package Manager)
Problematic Firebase Component: Editor (Auth, Database, etc.)
Other Firebase Components in use: Analytics (Auth, Database, etc.)
Additional SDKs you are using: Many. GPG, Facebook, Mopub, Helpshift, Pushwoosh. (Facebook, AdMob, etc.)
Platform you are using the Unity editor on: Mac (Mac, Windows, or Linux)
Platform you are targeting: iOS, Android, Amazon (iOS, Android, and/or desktop)
Scripting Runtime: IL2CPP (Mono, and/or IL2CPP)

[REQUIRED] Please describe the issue here:
Whenever an asset is refreshed the Firebase SDK tries to call GenerateXmlFromGoogleServicesJson which eventually results an EntryPointNotFoundException: GetModuleFileName.
Steps to reproduce:
Have you been able to reproduce this issue with just the Firebase Unity quickstarts (this GitHub project)? No.
What's the issue repro rate? (eg 100%, 1/5 etc) In my project I get multiple errors whenever I build the project.
What happened? How can we make the problem occur?
This will occur just building my project. I have attached the exception stack to the ticket.
The project is a commercial project and i'm unable to reproduce with the samples. If you could give me some indicators as what it might be then I could try and get it to happen in the samples. Right now, I just don't understand the error.
EntryPointNotFoundException.txt

Hi @JimmyDeemo,
This is a rather unusual issue. Could you try if updating the SDK and Unity editor resolves the issue? If it doesn't please provide a minimal, reproducible example of your project so that we can identify what's causing this.

I can try but the thing is that this is a commercial project and I can't just hand it over. I will try and strip back everything to get a copy of the project that does it. Alternatively, expediting this issue will help me; https://github.com/googlesamples/unity-jar-resolver/issues/472.
I am on vacation next week so I would appreciate it if the bot didn't close this ticket until at least two weeks.

I am still working on providing a repro project for this issue. Please can you keep the ticket open a little while longer.

@paulinon I have a small repro project that has been stripped of company references and code, please may I have an e-mail address to send it to you?

Hi @JimmyDeemo, you may share this with<EMAIL_ADDRESS>

@paulinon Thank you. You should have a Send Safely link in that inbox. Please confirm.
Repro steps are to load the project in either 2019 or 2020 LTS versions. You should see the error somwhere in the console. Likewise if you go to any script, right click re-import, it will generate another error.

I have found that if I remove the SQLite folder from the project that the error message stops occuring.


[Bug] /job/:jobId/logs and /job/:jobId/result-folder-content Return 200 Status Code without Auth

The two routes /job/:jobId/logs and /job/:jobId/result-folder-content return 200 status codes despite throwing errors in the response. Example status/code response:
200
{
    "error": "invalid input",
    "messages": [
        "requires property \"jupyterhubApiToken\""
    ]
}

Expected Behavior
I would expect them to return a 402 code like the other routes (/job/:jobId/events for example) if there is no auth token.
To Reproduce
These lines of Python code should be able to reproduce the error:
import json, requests

x = requests.get("https://cgjobsup-test.cigi.illinois.edu/v2/job/xxxxxxxxxxxxxxxxxx/result-folder-content")
print(x.status_code)
print(json.dumps(json.loads(x.content), indent=4))

x = requests.get("https://cgjobsup-test.cigi.illinois.edu/v2/job/xxxxxxxxxxxxxx/logs")
print(x.status_code)
print(json.dumps(json.loads(x.content), indent=4))

Seems this was solved by https://github.com/cybergis/cybergis-compute-core/pull/86


Add tests for built package

Proposed change

Add tests for built package, for freshly built package functionality check (#1479).
Type of change

[ ] New country/market holidays support (thank you!)
[ ] Supported country/market holidays update (calendar discrepancy fix, localization)
[x] Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency update (version deprecation/upgrade)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[ ] New feature (new python-holidays functionality in general)

Checklist

[x] I've followed the contributing guidelines
[x] I've run make pre-commit, it didn't generate any changes
[x] I've run make test, all tests passed locally

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
10631

Relevant Lines:
10631

💛  - Coveralls


Upgrade version of moment.js used by agent to 2.21.0

This PR upgrades version of moment.js that agent uses: from 2.15.0 to 2.21.0 because of CVE-2017-18214. moment.js used by UI already upgraded on https://github.com/treasure-data/digdag/pull/742.

Thank you for reviewing. Will include the change log in next release note.

Merged.


show the count of matched result

Thank you for such great works!
I wonder if we can show the total number of matched item and which one we are on.
By the way, the regex search is awesome!

@npejo is working in some improvements to the search, I think this is something I can take a look and try to bundle together


Fix setting ulimit under systemd

There was an inconsistency with creating a file
/etc/systemd/system/redis-server.service.d/limit.conf
but then referring to file
/etc/systemd/system/redis-server.service.d/limits.conf
in the augeas resource.
Whereas limits.conf seems to be a better name the file
limit.conf is now likely to exist on many systems, and
I don't want to risk having both a limit.conf and a
limits.conf. So limit.conf it is.

The context was set to to the filepath, but should have been
prefixed with "/files". Seeing as this is default I removed the context.
This closes  arioch/puppet-redis#268

Hepp!
The checks that fail in Travis is not something I believe is caused by this pull request. This fails, even on eg. ruby 2.3.3
ERROR:  Error installing bolt:
winrm-fs requires Ruby version >= 2.2.0.
This seems to be an error with the setup or the winrm-fs plugin.
I will ignore these checks, until I am told otherwise.
Kind regards,

bahner

has this been here for 3 months because of broken ruby dependencies in the travis config?

I would appreciate if this fix can make it to the next release.
Currently the module is essentially broken on servers with sytemd because the limit.conf file is empty due to the typo which causes the systemd unit to be masked and therefore puppet can't enable the service.

Merged.
Thx for your patience, there's a vacancy for a new maintainer as Peter stepped down. 😉


removed unneccisary subtraction, combined high and low parameters

Closes #965.
Removed simulated double precision subtraction from latitudeToWebMercatorFraction.glsl and combined high and low parameters into one southMercatorY. Changed occurrence of the function call to match the new parameters.

Made the changes.

removed the declaration

It looks like there is a differnce when you remove the code. Top is my branch, bottom is master.

@ggetz can you provide a url to Cesium viewer with the camera position?
@kring can you take a look?  We are OK with just leaving the code as you originally had it.

Viewer (my branch)

@pjcozzi I rebuilt my branch and and refreshed the page, and now I am seeing the same thing as master

Looks good on my machine too!


Coveralls doesn't work

After repo name changed (riot-router --> riot-route), coveralls seems not working. I've already changed the source and synced it. There's something buggy. Some issues like this is reported on coveralls' repo.
https://github.com/lemurheavy/coveralls-public/issues/603

Solved.


Minimap horizontal movement with mouse

When the main window contains long lines then it would be useful to be able to move the minimap horizontally with the mouse as well as vertically.

Currently it is possible to use shift+mouse wheel to scroll horizontally. I am not quite sure how the minimap could be dragged horizontally.

... the minimap can be dragged horizontally with the mouse in SublimeText


Respect scan_date at import time for all findings imported

I noticed that the scan_date field in the importer is not respected if the parser does not have a date to set, or just does not set it at all. This PR sets the date of all findings imported to the date set at import time, but only if the parser fails to do so. Default behavior of setting the finding date to "today" is maintained.

@StefanFl unit tests will fail here (the one I made), but think the logic is sound now and ready for some more test coverage

The import scan_date should overwrite the date the parser recorded. It is the user taking it into their hands to change it, so the findings should record as such.
I am not sure I agree. The field is mandatory in the UI and mandatory (defaulted to today) in API. So if it's always used to overwrite any date set by the parser, the user will have no way to actually use the date set by the parser. When importing a scan the user (or the cicd script) doesn't always know when the scan was performed, so it can't always set the scan_date correctly. So it would be better to have the parser set it.
Either way, the PR description differs from the PR implementation at the moment.

I will update the PR description to better describe the implementation

So if it's always used to overwrite any date set by the parser, the user will have no way to actually use the date set by the parser.

This is not true. Please see the unit tests that outline all possible use cases of where a findings date can come from.

When importing a scan the user (or the cicd script) doesn't always know when the scan was performed, so it can't always set the scan_date correctly. So it would be better to have the parser set it.

Since the scan_date field is not mandatory when using the API, a CI/CD script can simply not set the scan_date (and it will default to the time of import), and the finding date will either come from the scan report, or the default value.

For example reports from AWS or other cloud security scans usually contain findings with different "first found" dates. This PR now overwrites all of them with the date chosen by the user or the api script (or today if no date is provided in the API).

Half of this correct. The dates will be overwritten by the user if they specify the scan_date. Since it is not mandatory, users can not use it. The default generated date will not overwrite a date that was taken from the scan report (see the two unit tests on this)

I don't think that is what we want, or am I misreading the code?

You are misreading the code. Please deploy this and test by hand. I found that the Acunetix scans used in the unit tests have a date from the report, and the ZAP scans used in the unit tests do not specify a date in the report.

Ok, I don't have the time to analyze all the possible code paths here so have to assume it does what it does. I am wondering though what happens when an import starts at 5minutes before midnight and runs 10 or 15 minutes? And what happens when a DD instance is not in UTC? Couple of years ago I had to change most instance to .localtime() and .localdate() to avoid "off by one" date errors.

Thanks for the comments @damiencarol @valentijnscholten
I'll add the uses cases to documentation.
The defaults are set in forms.py and API serializers and neither one accommodates timezones. It would be good to change those (and all instances of time related activities) to support timezones. But for now, I will change just these two.
I'm not sure how I would check for timezone accommodation in the unit tests though.

Testing for timezones in unit tests would be a big job, as we're not doing that anywhere yet. I have an idea on how to implement the requirements without relying on comparisons to "today" in these places. But don't have the time to do it or show it, so I'll just leave it up to the rest.

Looking at the code if the import is started at 23:55 and runs for 10 or 15 minutes you will get some findings that have their date overwritten, and some keep their date.

Hmm that is a tough one. Struggling to think of way to overcome that. Wouldn't that happen without this code change as well though?

Testing for timezones in unit tests would be a big job, as we're not doing that anywhere yet. I have an idea on how to implement the requirements without relying on comparisons to "today" in these places. But don't have the time to do it or show it, so I'll just leave it up to the rest to review/approve.

Agreed, the timezone test would be very time consuming. I think simulating various timezones via hardcode and checking count the count of findings at various dates and validating dates would do it.
I have updated the default date in UI/API and in tests to accommodate timezones. Also added documentation

Looking at the code if the import is started at 23:55 and runs for 10 or 15 minutes you will get some findings that have their date overwritten, and some keep their date.

Hmm that is a tough one. Struggling to think of way to overcome that. Wouldn't that happen without this code change as well though?

Before this PR I think the date field of findings is never overwritten by scan_date? You could fix it by getting now() in the importer and pass it on to process parsed findings so it uses the same "now" for all findings. Not sure if that makes the code better/nicer. Also not saying it should prevent merging as maybe most would consider it a corner case, but from a product owner point of view I personally would like to have that scenario working 100% correctly at some point :-)

Oh that is actually what is already happening (see now=now)
https://github.com/DefectDojo/django-DefectDojo/blob/1a1cf79d303046e6c21bbc2cb591058b1b875001/dojo/importers/importer/importer.py#L352-L356
I did not notice this until now, but I think it solves that corner case

Oh that is actually what is already happening (see now=now)
https://github.com/DefectDojo/django-DefectDojo/blob/1a1cf79d303046e6c21bbc2cb591058b1b875001/dojo/importers/importer/importer.py#L352-L356
I did not notice this until now, but I think it solves that corner case

Ah crap, I didn't realize it was already there as it's not shown in the diff. But SOMEBODY (*me) already added it earlier it seems. The prophecy fulfilled or how do they say that in English.

For reference: https://github.com/DefectDojo/django-DefectDojo/blob/dev/dojo/forms.py#L376
I think the UI should be consistent with the API. I agree with the change, but I think the field should not be required in the UI, and should not be pre-populated.


Power measurements in emissions.csv

CodeCarbon version: 2.3.1
Python version: 3.9.2
Operating System: Debian GNU/Linux 11

Description
I have a question regarding the cpu_power, gpu_power, and ram_power values in the emissions.csv file generated by CodeCarbon. I noticed that these values represent the latest instantaneous power measurements for each component. Is this the normal operating behavior, or is it an error? If not, it would be helpful to clarify this in the documentation, as it can be misleading. Users might mistakenly assume that these values reflect the mean power consumption of each component over the measurement period.
Alternatively, would it be more useful to compute these power values as the mean power? This would involve dividing the energy consumption of each component by the duration of the measurement period. However, I realize that this approach may not be as informative, given that this information is already available in the emissions.csv file.

Hello, we have multiple ways of representing power, energy & emissions data.
I would answer that the behavior you mention is the expected one, but maybe you are expecting something else.
The mean power by itself is not quite useful, at least from my understanding, but its instant value gives an idea of what happened at a specific time.
Would you have a specific usecase, where a mean power value would be useful ? (it could be aggregated in a reporting app, for instance).


Refactor codegen: split FunC AST generation and pretty-printing

Some remarks on the design of the new codegen architecture:

Code generation should be a two-step transformation: (1) produce FunC ASTs, (2) pretty-print FunC ASTs which we then use to feed into the FunC compiler as we do new;
Special care should be taken to avoid clashes between identifiers and FunC keywords;
The FunC pretty-printer should produce human readable code that should look like the currently produced FunC code;
The FunC pretty-printer should have configuration options to support fully-parenthesized expressions and more human-readable version (we should focus on the easier fully-parenthesized version first);
The TypeScript representation of FunC AST and the pretty-printer should be available as a separate NPM package so it can be re-used by TON community.

Related issue in the ongoing series of refactorings: #458.

@byakuren-hijiri Btw, the pretty-printer and the FunC AST data structure should be adaptable to #420

If we were to parse FunC via Ohm, FuncParser.bnf and FuncLexer.flex from ton-blockchain/intellij-ton can be helpful guidances as there's no formal description of FunC. Also, it's parser is almost exclusively located in one file: parse-func.cpp

Retracting the requirement

The pretty-printer and the FunC AST data types itself should be adaptable to #420;

as not planned


Update Visual Studio Code

They recently changed it, so it would be nice to have the latest. Thanks!

Didn't they change the icon to blue? Isn't blue now the latest color? Requesting new blue color. Thanks.

To add to this, Blue is stable and Green is insider builds.
https://code.visualstudio.com/blogs/2017/10/24/theicon


Update http4s-circe, http4s-dsl, ... to 0.23.24

About this PR
📦 Updates

org.http4s:http4s-circe
org.http4s:http4s-dsl
org.http4s:http4s-server

from 0.23.14 to 0.23.24
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.http4s" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.http4s" }
}]

labels: library-update, early-semver-minor, semver-spec-patch, version-scheme:early-semver, commit-count:1

Superseded by #212.


Suggesstion: decouple teammates of each character

Thanks for your great work. There's a small problem I found inconvenient while using GO.
In the current version, all teammates are tied together, i.e., if you choose a teammate B for character A, A will become the teammate automatically in B's page. However, most characters are not limited to a certain team. For example, Raiden and Xiangling both need Bennett's buff. Buf if I add Bennett to Xiangling's team buff, he will be automatically removed from Raiden's build. This is quite inconvenient when finding build for multiple characters. So could you please make team buff of each character independent, or add a switch to it? Thanks.

For example, I hope to see the following builds side by side, which is impossible in the current version, since they share the same character Bennett.

Also, I have change Kazuha's Swirl reaction every time I make a new build, since different teams use different elements. Decoupling the teammates also solves this problem.
Since it is very common for different main DPSs to share the same support, I think this could be the default option for making new team builds. (Of course the existing builds shoud not be changed when upgrade.) If one wants to make both characters teammate of each other, it should not take too long to set it saperately.


Convert units

This popped up in #131
We don't seem to have a way to convert from unit to another. Which is why currently in system.ex there is still this manual conversion going on: memory_in_bytes = memory_in_kilobytes * 1024
To get rid off it (in the most general way/sense) we need to be able to convert from one unit to another. Which means something like: convert({value, current_unit}, desired_unit) # => {value, unit} scaled to desired unit
Not sure about the function name, but convert sounds fitting to me. Also, not too stern about the interface - if you got a better idea go for it!
so in general:

add convert function to scale behaviour
implement function for existing units (best by calling out to Scale itself, as we don't want duplication)
use newly implemented function to get rid off manual * 1024 in system.ex
$$$ profit (as in consistency and more functionality and the Unit/conversion sub system mightily improved)

Hey there, Im starting to learn elixir and think this would be a great issue to start with. Working on this now.

Go for it! :tada:
Let me know if you need guidance or something. Early PRs are also good to refine what's there :)

That would be great, opening a PR now to get some initial feedback on the approach. Also let me know if anything could be expressed in more idiomatic elixir - Im still wrapping my head around it.

This is implemented and now an integral part of the behaviour :tada:


Add README to explain how to reproduce examples

I tried to reproduce examples, especially Lea Rumiz's resume. It is not intuitive how to redo, eventually I ended up in:
$> asciidoctor-web-pdf resume.adoc \
  -a stylesheet="style.css"\
  --template-require ./template.js

Perhaps a simple README.md per example would help to clarify how to go ahead.

Perhaps a simple README.md per example would help to clarify how to go ahead.

Yes that's a good idea 👍🏻

fixed in  36b4d59


Desk Service Interuption

Services Affected: Authentication, Desk

We are seeing service interruption for Desk and our Authentication services. Automated recovery has kicked in and we are currently monitoring the situation.

Resolved: Desk is back up in e11b5bc.

Recovery is stable, but we are still monitoring the situation.

We've seen full recovery and will continue to actively monitor the situation.


[UX] Edit Expenses

The ability to edit existing expenses or anything input on the site.
At the moment to edit an expense or anything else I need to delete it and then re-do every step, this is a bit painful if I accidently mess up an expense by a day and have to redo it.

Noticed this was already existing as an issue.


feat(cli): JSON reporter

Summary
This PR exposes (again) the --json option, and it adds a new --json-pretty.
The --json option will print everything in JSON format (diagnostics and summary).
The --json-pretty, together with --json, will print said JSON formatted.
I also added a warning because the fields' names are weird, and I think they should be reviewed.

Test Plan
I added new tests

This reporter is intended for machines not human? Thus, I am not sure if we need --json-pretty. We could first introduce only --json and see users reaction.

I forgot to add this comment:
Could not use an option --reporter=<reporter> instead of specific flags?
We could have --reporter=json and --reporter=json-pretty.
This could avoid the addition of more flags once we integrate more reporters.

Sure, no problem

Sure, no problem

Do you plan to make the change?


When sending attachments, sometimes it doesn't send and the attachment preview pane will expand/de-expand a few times

This is a bug that we've been getting on the Samsung s22+.

Attach multiple photos to a message (happens more often when sending more than one)
Click send
Sometimes the photos won't send, but the attachment preview widget will expand up and down, a few times.

I have no idea what would cause this

gonna say this wont happen anymore


nodejs-bigquery - convert samples test ava to mocha

Fixes #Convert all sample tests to mocha (it's a good idea to open an issue first for discussion)

[ ] Tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

👋 gentle ping

@JustinBeckwith  strange! locally all tests passing form me, but not here

So this will sound crazy.  Try pinning @types/sinon to version 5.0.5 with no range specifier, and see if it works.

Heh apologies - I meant in the root package.json, not samples/package.json


Implement api for delegate route transitions

Description
Draft implementation for design doc: https://docs.google.com/document/d/10C5VbqhU7FkkDSVlcVZmrl8UyL7nw4CeL4QdPKMjsEk/edit#
Related Issues
https://github.com/flutter/flutter/pull/67515
Tests
This is my next step before setting the PR ready to be reviewed
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[X] I signed the CLA.
[X] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[X] I read the Tree Hygiene wiki page, which explains my responsibilities.
[X] I updated/added relevant documentation (doc comments with ///).
[ ] All existing and new tests are passing.
[X] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[ ] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[ ] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

@jamesblasco are you waiting for more feedback on this PR or are you working on it?

I am a bit blocked with this and I have also been very busy with university and work, so I focused on that.
My main concern currently is something I wrote inside the design-doc open questions and @goderbaue also commented in the PR and the design doc:
PROBLEM CASE: the top-route is replaced or a new route is pushed before the previous active route finishes a pop transition.
With the current solution, this would create an awkward jump in the animation. (The top-route changes and so will do the secondaryAnimation transition from the bottom-route)
I could try to implement a transition train-hopping similar to: https://github.com/flutter/flutter/blob/ac5a9a390597f44c86222a022a8926263633a511/packages/flutter/lib/src/widgets/routes.dart#L268
So when there are multiple top-route transitions happening at the same time, the bottom-route would combine all  secondaryAnimation transition and would animate them their respective positions (with the current code the bottom-route only uses the secondaryAnimation transition from the active one)
This looks a bit complex and would like to know if it can be a good approach before investing my time in it

Hello @xster, I will have more time this next few months and I would like to go back on this and https://github.com/flutter/flutter/pull/67515.
I made some changes to take into account the case when the next route is replaced, and now both animated translation would mix one entering and another one would exit.  I will work on some improved tests in the upcoming week.
Let me know if this is still considered.

Maybe this could be implemented for PageRoutes so it does not affect all routes.
abstract class PageRoute<T> extends ModalRoute<T> with DelegatedTransitionsRoute<T> {
 ///...
}

@xster @goderbauer As this is blocking #67515 and iOS 15 is coming out soon, could someone please find time to review the recent changes?
I'm still utilizing https://github.com/jamesblasco/modal_bottom_sheet in the interim, as Flutter's current modals look very out of place in iOS 14.
Unfortunately, it feels like the Cupertino widgets keep falling further and further behind with each new iOS release.

Based on @jamesblasco's comments on PR #67515, it sounds like this PR should be closed. People interested in this feature should probably check out the modal_bottom_sheet package on pub.
@jamesblasco let me know if this is still something we should review (or just open a new PR and ping me on our Discord).

@Hixie  honestly I would still get for trying to merge this. This feature is not possible to implement in a package and nowadays the package uses some painful workaround that makes you replace all the default MaterialPageRoute with a MaterialExtendedPageRoute to make the CupertinoModalBottomSheetRoute animate correctly. This is something difficult to understand for lots of people and has huge implications on their codebase.
Even if we don't merge modal_bottom_sheet, this would be the must first step needed and will already help the devs using the package, which does look like a lot considering it has 1.5k likes and 99% popularity.

The original design here expected that any route that wanted to act in a particular way for a particular next route would implement that locally, on the principle e.g. that it's not the bottom sheet that knows that the route below it should be pushed backwards into the screen, it's an inherent feature of that page route that it can push itself back when something appears on top of it.
Can you talk more about why this is not a good idea? (I'm not saying it's a good idea, just want to make sure we've properly considered the alternatives before adding more API surface.)

So I think the idea is that a current route would transition out differently for each type of route that comes in.
A page should be able navigate to a new page like material page route and also to a bottom sheet route, and animate different for each case.
This already happens with MaterialPageRoute, it animates out if the next page is MaterialPageRoute/CupertinoPageRoute, but it does not if that MaterialPageRoute page is set to be fullscreenDialog.
We could support that only MaterialPageRoute and CupertinoPageRoute pushes back when a new modal bottom sheet appears on the screen, we could simply set it up like:

This comes with the same complications as the implementation of this PR, how do we get the nextRoute, what happens if it changes to a new route type, how we cross-animate the transition jumps:

Implementing this only for the MaterialPageRoute and CupertinoPageRoute with Sheet Route has the same difficult implications and still makes it impossible to design new transitions outside the framework that can be supported by the MaterialPageRoute (I bet 90% of the flutter uses this route), so what we can only do it is workarounds like cloning the MaterialPageRoute functionality into a new class.
See:
https://github.com/flutter/flutter/pull/67515#discussion_r512271702
https://github.com/flutter/flutter/pull/67515#issuecomment-717467837

I see. So to put it another way, the problem is that the CupertinoPageRoute is expected to animate in a particular way specifically when this new kind of sheet, which ideally would not be known to the rest of the framework, is pushed on top, so really only the new sheet can know what the animation should be...
This reminds me a little of the way Shapes can define a lerp either from themselves to another shape, or from another shape to themselves...

Right now, we have this model, if I recall correctly:
  Navigator
    │
    ├─ B's transition when B was appearing, created by B
    │   │
    │   └─ Route B
    │
    └─ A's transition when A was appearing, created by A
        │
        └─ A's transition when B was appearing, created by A
            │
            └─ Route A

But we could make it look like this:
  Navigator
    │
    ├─ B's transition when B was appearing, created by B
    │   │
    │   └─ Route B
    │
    └─ A's transition when A was appearing, created by A
        │
        └─ A's transition when B was appearing, created by A
            │
            └─ A's transition when B was appearing, created by B (*)
                │
                └─ Route A

I think this would even work if the new transition (marked with an asterisk *) uses the same Animation as the one created by A (the one just above it in the tree).
To do this I think you would need to call something like widget.nextRoute.buildTransitionsForPreviousRoute in _ModalScopeState, which means ModalRoute would need to find some way to get a hold of the next route and maintain it, maybe by overriding _updateSecondaryAnimation to keep a reference to nextRoute locally?
I think this would be simpler than the mixin approach in this PR. The question is, would it address all the use cases we care about?

@jamesblasco ping

@jamesblasco Do you mind if we close this PR in the meantime, just to get it off our review queue? (I'm not sure if you got enough feedback to continue work?)

Yeah let's do that! For any future work related to bottom sheets I will be doing in it in this package
https://github.com/jamesblasco/modal_bottom_sheet/tree/main/sheet


are waterline have cli / terminal test like django orm?

hi.. some time i missing test / query on to cli like django.. are waterline have cli version to test query like django orm..
Thanks..

Waterline doesn't have this feature.  If I need an interactive CLI to test my models, I add one to my application.  Sails has this out of the box, and hapi has a useful plugin called https://github.com/hapijs/reptile .


support rn 0.51

1.support react-native 0.51

This repo is no longer maintained. Use this active fork that is published on npm:
https://github.com/peacechen/react-native-modal-selector


[FLINK-11181][tests] Fix SimpleRecoveryFailureRateStrategyITBase test error

What is the purpose of the change
This pull request fix SimpleRecoveryFailureRateStrategyITBase test error.
The configuration has not been passed to the MiniClusterWithClientResource.
Brief change log

Pass configuration to MiniClusterWithClientResource.

Verifying this change
This change is already covered by existing tests, such as (please describe tests).
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)

@sunjincheng121 Thanks a lot for your review and suggestions. I have updated the code.
Best, Hequn

Thanks for the quick update！ @hequn8128
Will be merged.
Thanks, Jincheng


Escaping Quotes in Question via Splunk

For those trying to run commands like the one below, you must escape the quotes by using the escape character found in the w3 reference below.
Example: | taniumnlp --timeout "60" --question "Get Run Keys from all machines with Computer Name containing """
Reference:
https://www.w3.org/TR/xml11/#syntax
The documentation online currently is only for the splunkbase app not the one you can download from the Github repository.
Also, in the documentation it says to run the commands in the following format:
|script python tanium_nlp ....
If you install the app from Github and not Splunkbase, you can run the app by simply using the aliases script name as above.
| taniumnlp ..........

Removing all inline searching


Assert-error in HA LOG regularly

Home Assistant Adaptive Lighting Issue Template
Bug Reports
If you need help with using or configuring Adaptive Lighting, please open a Q&A discussion thread here instead.
Before submitting a bug report, please follow these troubleshooting steps:
Please confirm that you have completed the following steps:

[x] I have updated to the latest Adaptive Lighting version available in HACS.
[x] I have reviewed the Troubleshooting Section in the README.
[ ] (If using Zigbee2MQTT) I have read the Zigbee2MQTT troubleshooting guide in the README.
[x] I have checked the V2 Roadmap and open issues to ensure my issue isn't a duplicate.

Required information for bug reports:
Please include the following information in your issue.
Issues missing this information may not be addressed.

Debug logs captured while the issue occurred. See here for instructions on enabling debug logging:

Your Adaptive Lighting configuration:

(If using Zigbee2MQTT), provide your configuration files (remove all personal information before posting):

devices.yaml
groups.yaml
configuration.yaml ⚠; Warning REMOVE ALL of the PERSONAL INFORMATION BELOW before posting ⚠;

mqtt: server:
mqtt: user:
mqtt: password:
advanced: pan_id:
advanced: network_key:
anything in log_syslog if you use this

Brand and model number of problematic light(s)

Describe the bug and how to reproduce it:

Steps to reproduce the behavior:

You've left half of the issue template blank, please fill in the missing details so we can properly help you.

Yeah I know, to much information to add :)
Anyway, I fixed the error myself in the local code, it was just a mistake in what to assert.
Switch.py line 1419 should read: assert isinstance(adapt_color, bool | None) in line with the init of  in line 1243: adapt_color: bool | None = None
Also, line 1418 should be corrected as adapt_brightness is also inited as bool | None.

After capturing some logging, it turns out the error is caused by a light that is no longer present in HA.


Merge in rbenv history

Per the discussion from #13, this is another take on the merging of rbenv history.
Rather than using git-replace to graft in the history of rbenv into the appropriate points in nodenv's history (and thus rewriting all of nodenv's commit shas); this approach is just merging in rbenv/master using the ours merge strategy. From the git documentation for the ours merge strategy:

This resolves any number of heads, but the resulting tree of the merge is always that of the current branch head, effectively ignoring all changes from all other branches. It is meant to be used to supersede old development history of side branches. Note that this is different from the -Xours option to the recursive merge strategy.

As described above, with this merge strategy, the content of the merged commits are ignored. So the contents of nodenv haven't changed at all (which can be verified by diffing this PR with master). But now that rbenv's history has been merged, we ge the correct merge-base so future merges from rbenv will be much easier. (A simple matter of adding rbenv as a remote, fetching, and git merge rbenv/master)
Details:
I merged in two commits from rbenv: ea3203dbab78da7fd29b5490889e60a7dcc8766c and f71e22768c8bc02a10fc917f05072fdc68d71be4. The former being the HEAD of rbenv/master at the time nodenv was forked/created. The latter being the HEAD of rbenv/master at the time @OiNutter did a manual merge from rbenv (956a73b0ce15d8673fa8298eaab82c80ef0d85b6).
If everyone is cool with this PR, we can fast-forward master rather than doing a github merge. This way we don't get a merge-bubble that contains merge bubbles.

LGTM :+1:


Question - Reacting to font change so I can load fonts on the fly

I want to give the users a big list of fonts (in my case google fonts) however I don't want to have to load them all on the page beforehand - especially when someone is just viewing the content of the editor (e.g. not actually editing it).
What is the recommended way to react to the font change?

I will add events of plugins in version 3.0.0.
You will be able to add it dynamically when you change the font.

That's great, your work on this is absolutely fantastic.
As version 3 will be a little way off, is there any recommendations for what i can do for now?

You can redefine plugin's method.
editorInstance.onload = (core) => {
  core.plugins.font.pickup = ()=>{..}
}

https://github.com/JiHong88/SunEditor/blob/master/src/plugins/submenu/font.js#L113

const value = e.target.getAttribute('data-value');
"value" is font-family value.
Please refer this code.
https://github.com/JiHong88/SunEditor/blob/master/src/plugins/submenu/font.js#L113


[IT-3356] Setup guardduty initiated malware protection

Guardduty has detected suspicious activity in our EC2 instances in the past.  This change is to improve our security posture
Enable GuardDuty-initiated malware scan[1] to initiate an agentless scan of the Amazon EBS volumes attached to the Amazon EC2 instances and container workloads, automatically whenever GuardDuty generates any of the Findings that invoke GuardDuty-initiated malware scan[2]
[1] https://docs.aws.amazon.com/guardduty/latest/ug/gdu-initiated-malware-scan.html?icmpid=docs_gd_help_panel
[2] https://docs.aws.amazon.com/guardduty/latest/ug/gd-findings-initiate-malware-protection-scan?icmpid=docs_console_unmapped

i tested but unfortunately this didn't work.  i couldn't even enable it manually from the AWS console. i sent a tix to AWS for help.  now waiting for a reply.

this doesn't work.  need to setup with guardudty at the organizations level.


Error in soda-sql:tests doc

Hi team,
There seems to be an error in the soda-sql:tests doc: https://docs.soda.io/soda-sql/documentation/tests.html. More specifically, the sample snippet in the column test seems to be wrong.
In the scan.yml the tests and validity_format don't need a "-":

Expected working snippet:

table_name: yourtable
metrics:
- row_count
- missing_percentage
- invalid_percentage
columns:
start_date:
validity_format: date_eu
tests:
- invalid_percentage < 2.0

Thanks :)

fixed


make fails with “Makefile:52: *** target pattern contains no '%'.  Stop.”

PR #207 adds rules like
${GOPATH}/bin/notary-server: NOTARY_VERSION $(shell find . -type f -name '*.go')
which break when GOPATH contains multiple :-separated entries with
Makefile:52: *** target pattern contains no '%'.  Stop.
(regardless of which target is used.)
I’m not entirely sure what a proper fix is at the moment, this is a tangle of several issues.

https://golang.org/pkg/go/build/ suggests that $gopath_entry/bin should be only used for commands built from the corresponding $gopath_entry/src, which is not generally the case for a checkout of notary.
This can be worked around by something like (unset GOPATH; make binaries), only using the Godeps-managed dependencies
OTOH (make build) is still available, requires running setting GOPATH manually to point at Godeps, and the standard way to do that, GOPATH=`godep path`:$GOPATH, causes a multi-entry GOPATH to be set.
(make build) could arguably be dropped or reworked as (make binaries) has been, but this also breaks (go test), for the same reason.

AFAICT either all or none of the make rules should call godep; and using ${GOPATH} is wrong in any case.
(Filing at least a bug without a PR for now to hopefully save others the time figuring out the cause of the breakage.)

Sorry about that. I'll revert it for now until we have a better solution https://github.com/docker/notary/pull/214

Looks like this issue was resolved; closing.  Should we re-open #202? (putting the compiled binaries into $GOPATH/bin)


Pretty tests

[x] Used dataProvider to provide each test file as a separate test
[x] Autoloading and namespaces for tests
[x] Make test store declared classes once before build (::setUpBeforeClass instead of ::setUp)
[x] Move some constants to phpunit config
[x] Minor refactoring of test classes

@morria Do the RasmusTests and PhanTest differ only in source and expected folder name?

@morria I thinks this one is ready for review

Awesome! Sorry for the delay. Taking a look now.

Great patch. Thanks @scaytrase! This should make hacking on Phan much more enjoyable.
I made a small change to make the instance of CodeBase reusable between tests (https://github.com/etsy/phan/commit/d5dac835fefabf0ce1aa62fa9240c6e984a9f343) to speed things up (down to 6s from 2m for me). Its a bit risky for letting state leak between tests if CodeBase::__clone isn't kept up to date, but worth it for the speedup.


How to check when SaveModelTransaction finished

How to check when a SaveModelTransaction is finished and call some function?
I'm storing a few models using SaveModelTransactions like this:
TransactionManager.getInstance().addTransaction(new SaveModelTransaction<>(ProcessModelInfo.withModels(companyList)));
TransactionManager.getInstance().addTransaction(new SaveModelTransaction<>(ProcessModelInfo.withModels(eventList)));

I'd just need to call a function after these transactions are finished to do some post-processing.
I guess there must be a simple solution for it, but although I checked the docs all over a few times already, unfortunately I can't figure out how to do it.
Any help on this would be much appreciated.
Using 3.0.0-beta5
EDIT
Ok, after reading this issue about onModelStateChanged: https://github.com/Raizlabs/DBFlow/issues/319
Using a FlowContentObserver seems to do the trick:
FlowContentObserver mFlowObserver = new FlowContentObserver();
mFlowObserver.registerForContentChanges(mContext, Event.class);
mFlowObserver.addModelChangeListener(new FlowContentObserver.OnModelStateChangedListener() {
  @Override
  public void onModelStateChanged(@Nullable Class<? extends Model> table, BaseModel.Action action, @NonNull SQLCondition[] primaryKeyValues) {

      mUpdateFinishedHandler.sendEmptyMessage(0);

    }
 });

TransactionManager.getInstance().addTransaction(new SaveModelTransaction<>(ProcessModelInfo.withModels(companyList)));
TransactionManager.getInstance().addTransaction(new SaveModelTransaction<>(ProcessModelInfo.withModels(eventList),mFlowObserver));

But, is this the correct way of checking when a Transaction is finished at all?
And can I be sure that the second SaveModeTransaction with the FlowObserver will indeed be executed after the first one?

That probably would be avoided for more complex scenarios if you end up listening for other operations.
in 3.0.0-beta6, the Transactions system (and documentation) has gotten a huge overhaul. (released some point this week). If you like a sneak-preview
. It'll provide a very easy way :
transaction
    .success(new Transaction.Success() {
       @Override
       public void onSuccess(Transaction transaction) {
          // called post-execution on the UI thread.
       }
   })

In the meantime you can use the ProcessModelInfo's result() method by specifying a TransactionListenerAdapter could give you what you need.

Yes that looks promising. Your hint using ProcessModelInfo's result() method seems to work well, and much faster than my FlowContentObserver workaround. Thanks a lot!
So this is how I do it for the time being then:
TransactionManager.getInstance().addTransaction(new SaveModelTransaction<>(ProcessModelInfo.withModels(companyList)));
TransactionManager.getInstance().addTransaction(new SaveModelTransaction<>(ProcessModelInfo.withModels(eventList).result(
              new TransactionListenerAdapter<List<EventType>>(){
                @Override
                public void onResultReceived(List<EventType> list) {
                  mUpdateFinishedHandler.sendEmptyMessage(0);
                }
              }
            )));