Allow missing sections

Fix #6
Unfortunately, I wasn't able to come up with a simple way to match zero or one instances of a pattern. Because of this, it's possible to write a few pathological errors that will cause infinite recursion rather than a more helpful description.
Example:

#[test]
fn smoke_test_9() {
    error_chain! {
        types {
            Error, ErrorKind, ChainErr, Result;
        }
        types {
            Error, ErrorKind, ChainErr, Result;
        }

        foreign_links { }

        errors {
            HttpStatus(e: u32) {
                description("http request returned an unsuccessful status code")
                display("http request returned an unsuccessful status code: {}", e)
            }
        }
    }
}

Because there are multiple types declarations, they are both combined into a single types declaration which looks like types { Error, ErrorKind, ChainErr, Result; Error, ErrorKind, ChainErr, Result; }, which doesn't match any of the existing rules except the one that produced it.
It is necessary for there to be a rule like this that matches zero or one type blocks with zero or one entry sections, so I don't see how to avoid matching on more than one type block or more than one entry section.
Perhaps an RFC for a macro_rules ? is in order? Do you know why this was excluded to begin with? It seems like a natural extension of * and +.

Thanks @cramertj ! It's the end of the day here and I'm beat, but I'll look at this tomorrow (really).

@brson Sounds good! No rush.

Ping @brson

Thanks! I'll get a build out shortly.


app.sample docstring examples

Added docstring examples for cogent3.app.sample apps:

take_named_seqs
omit_bad_seqs
take_n_seqs
fixed_length

#1636

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

7 of 8 (87.5%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.73%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/cogent3/app/sample.py
7
8
87.5%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
29683

Relevant Lines:
32359

💛  - Coveralls


Not being able to install android version

Godot version
4.0 dev
System information
Android 10
Issue description
When I tried to download the APK it worked, but when tried to install it, it said app not installed.

(Translation: app not installed; done)
Steps to reproduce
Download app and try to install it
Minimal reproduction project
No response

@L4z4r1 What device model do you have? The current Android editor releases only include 64-bit ARM libraries, so 32-bit ARM and x86 devices are not supported.

@L4z4r1 do you have previous build of Editor installed?
if so try uninstalling if first
fresh install fixed it for me 😅

This should work fine now. Please let us know if it still doesn't.

I have the exact same problem. Fixed it by including 32bit and 64bit binaries in the export settings. I guess the device I was testing as 32bit... something I completely forgot about.


Align with EJBCA & SignServer template repo

Updated and added standard documentation according to EJBCA and SignServer tool template repository.
After merge, please check that pull request templates and issue templates are working.

Template repo: https://github.com/Keyfactor/ejbca-signserver-tools-github-template


fix(react,vue): useWriteContract value

Description
useWriteContract().writeContract value not inferred correctly when config set up with chain that has formatters/serializers (e.g base) and abi has at least one 'payable' and 'nonpayable' function.
This TS Playground illustrates the issue well. Fixes https://github.com/wevm/wagmi/issues/3981.

More changes needed in Viem, will re-open this later.


Use Refget and thoas for instant download

Type

[ ] Bug fix
[ ] New feature
[x] Improvement to existing feature

Related JIRA Issue(s)
ENSWBSITES-929
Description
Instant download needs to use Thoas and Refget rather than REST API to download the sequences in FASTA format. This PR makes that change. However, the sequence checksums are not available for genomic sequences yet. Therefore, the REST API is used for it.
Deployment URL
http://feature-instant-download-thoas.review.ensembl.org/
Views affected
Entity viewer -> transcripts -> transcript list item -> download
Entity viewer -> gene function -> protein list item -> download
Possible complications
The sequence checksums via Thoas are available only through http://thoas-checksum.review.ensembl.org/thoas at the moment. So this code will not work unless the sequence checksums become available in the staging Thoas server.

One problem and one question.
The problem is genome browser. From what I am seeing in the PR, this code should break instant download in the genome browser. That's bad.
The question is whether it's better to query for checksums from components, like you are doing now; or to query for them from the fetcher functions (fetchForTranscript and fetchForProtein), in which case every fetch function will become a sequence of two fetches: one for the checksum and the other for the sequence itself. The latter approach looks more flexible (you are currently repeating the code that's fetching the checksums in InstantDownloadTranscript and InstantDownloadProtein components), but will likely require sending plain graphql query strings via POST requests to thoas using the browser's fetch function rather than using apollo's useQuery React hook.

One problem and one question.
The problem is genome browser. From what I am seeing in the PR, this code should break instant download in the genome browser. That's bad.
The question is whether it's better to query for checksums from components, like you are doing now; or to query for them from the fetcher functions (fetchForTranscript and fetchForProtein), in which case every fetch function will become a sequence of two fetches: one for the checksum and the other for the sequence itself. The latter approach looks more flexible (you are currently repeating the code that's fetching the checksums in InstantDownloadTranscript and InstantDownloadProtein components), but will likely require sending plain graphql query strings via POST requests to thoas using the browser's fetch function rather than using apollo's useQuery React hook.

Update regarding the Apollo client.

Apollo client that we initialise here can be exported, imported in a fetchers file, and used directly as client.query(...)
Which suggests that we probably want to move the code for initialisation of ApolloClient in its own file, much like we initialise redux store in its own file. The client can then be imported both in the React component that uses ApolloProvider to pass it down the component tree, and independently by the functions that need it. I hope it will work.

See SO discussion for reference.

Update regarding the Apollo client.

Apollo client that we initialise here can be exported, imported in a fetchers file, and used directly as client.query(...)
Which suggests that we probably want to move the code for initialisation of ApolloClient in its own file, much like we initialise redux store in its own file. The client can then be imported both in the React component that uses ApolloProvider to pass it down the component tree, and independently by the functions that need it. I hope it will work.

See SO discussion for reference.

@azangru I've made the changes accordingly

@azangru I've made the changes accordingly

@azangru The tests are now fixed. I managed to fix it by mocking the instant download components in Zmenu.test.tsx and TranscriptsListItemInfo.test.tsx, so think it should be better than what we anticipated (mocking apollo client objects).

@azangru The tests are now fixed. I managed to fix it by mocking the instant download components in Zmenu.test.tsx and TranscriptsListItemInfo.test.tsx, so think it should be better than what we anticipated (mocking apollo client objects).

Looks good. Don't know if you want to move the gql-client.ts file some place more convenient.

I can't figure out where it will fit. I'll leave it as it is for now, and move it in a later PR when there is a better place to put it.


FinSetoids is Cartesian

This is a WIP because:

[x] I want to implement Cocartesian also
[ ] I want to look into doing something with ObjectRestriction to make this work a little more general

I wonder if there might be an opportunity for proving a theorem of the sort "if category X has property P, then sub-category Y of X (as witnesses by relation R) also has property P if P and R are related in way Z".  As sort of "R preserves P".
Is this what you meant by part 2 of the TODO?

I wonder if there might be an opportunity for proving a theorem of the sort "if category X has property P, then sub-category Y of X (as witnesses by relation R) also has property P if P and R are related in way Z".  As sort of "R preserves P".
Is this what you meant by part 2 of the TODO?

I wonder if there might be an opportunity for proving a theorem of the sort "if category X has property P, then sub-category Y of X (as witnesses by relation R) also has property P if P and R are related in way Z". As sort of "R preserves P".
Is this what you meant by part 2 of the TODO?

Yeah, that's exactly what I meant by part 2.

The main thing stopping me from working on this PR is that I don't know where to put the tools for constructing terminal objects and binary products and things like that for object restrictions of categories. Any suggestions? I was thinking something like Categories.Category.Construction.ObjectRestriction.Properties.Terminal etc but I'm not satisfied by that

Why not put them directly in Categories.Category.Construction.ObjectRestriction.Properties ? Only if that grows very large would it need to be split (probably as you propose).
It might well be that some of the actual constructions should go elsewhere, and then just 'assembled' in the above?

@Taneb It would be really nice to get this finished and merged in. What can I do to help?

@JacquesCarette thanks for reminding me that this PR exists! I need to take another look at it to refamiliarise myself, it's been a while

Another ping on this one - it would be nice to finish. I have some cycles to help.


Implement client-side mTLS support settings

See #696
This is far from done. I tested it and quickly ran into issues with cert-manager:
{"level":"error","time":"2023-07-19T13:12:34Z","msg":"looking up info for HTTP challenge","service":"autocert","host":"test.example.com","error":"no information found to solve challenge for identifier: test.example.com"}
{"level":"error","error":"a valid client certificate is required to access this page","status":495,"status-text":"a valid client certificate is required to access this page","request-id":"c28412c5-e6c5-429e-a062-47ab3ad0585d","time":"2023-07-19T13:12:34Z","message":"httputil: error"}
{"level":"info","service":"authorize","request-id":"c28412c5-e6c5-429e-a062-47ab3ad0585d","check-request-id":"c28412c5-e6c5-429e-a062-47ab3ad0585d","method":"GET","path":"/.well-known/acme-challenge/i2K0F783PCrFnPkXh2jk2njfSn4GASGPhBOPnX0wvhk","host":"test.example.com","query":"","ip":"<IP_ADDRESS>","allow":true,"allow-why-true":["accept"],"deny":true,"deny-why-true":["invalid-client-certificate"],"user":"","email":"","time":"2023-07-19T13:12:34Z","message":"authorize check"}
{"level":"info","service":"envoy","upstream-cluster":"","method":"GET","authority":"test.example.com","path":"/.well-known/acme-challenge/i2K0F783PCrFnPkXh2jk2njfSn4GASGPhBOPnX0wvhk","user-agent":"cert-manager-challenges/v1.9.1 (linux/amd64) cert-manager/4486c01f726f17d2790a8a563ae6bc6e98465505","referer":"http://test.example.com/.well-known/acme-challenge/i2K0F783PCrFnPkXh2jk2njfSn4GASGPhBOPnX0wvhk","forwarded-for":"<IP_ADDRESS>","request-id":"c28412c5-e6c5-429e-a062-47ab3ad0585d","duration":4.265011,"size":1560,"response-code":495,"response-code-details":"ext_authz_denied","time":"2023-07-19T13:12:34Z","message":"http-request"}

The autocert thing is a bit concering, I thought that was disabled in Kubernetes?
I also tried setting ingress.pomerium.io/allow_any_authenticated_user: 'true' on the acme solver ingress, but that gave the same errors. It would seem that the client cert requirement kicks in before the authentication check is performed?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hello,
The overall direction of your PR is correct.
The issue with cert-manager is:

when you enable client CA, naturally, all inbound requests would require to present a client TLS cert during TLS handshake process.
That would interfere with HTTP01 challenge solver; when LetsEncrypt would try to access the challenge URL, a client cert would be requested that matches your CA, and LetsEncrypt would be unable to present one.

unfortunately there's no way to disable client cert request just for the HTTP01 challenges as this is configured per port (443) and as such, HTTP01 challenges are fundamentally incompatible with mTLS. You have to use a different cert-manager Issuer challenge type, such as DNS.
Please disregard autocert message, it's coming from OCSP code that's historically running inside autocert module. There's no autocert running in Kubernetes.

Thank you for the super quick answer!

unfortunately there's no way to disable client cert request just for the HTTP01 challenges as this is configured per port (443) and as such, HTTP01 challenges are fundamentally incompatible with mTLS. You have to use a different cert-manager Issuer challenge type, such as DNS.

Wouldn't it be possible to disable the https redirect on port 80 for the ACME challenge routes? That way we circumvent the problem entirely.

currently everything is configured on port 443, port 80 is only doing redirects.
I tracked that request in a separate ticket https://github.com/pomerium/ingress-controller/issues/698
For the time being I recommend to switch to DNS challenges.

You know, having thought a bit about this I think the entire approach might be wrong. mTLS is such a different beast from how Pomerium otherwise does things, that fully supporting it might end up ruining everything else. I'm thinking of just hosting node-oidc-provider and then connecting it to Pomerium.
That way you can extract all kinds of nifty things from the certificate subject and embed it in the OIDC response in order to do policy on top of that using Pomerium. You know, using the right tools for what they're good at :-)
Is there a way of doing that? I don't see any support for a generic OIDC in the docs...

Hi @andsens, I believe you can set provider to oidc to use a generic OIDC provider, see https://www.pomerium.com/docs/deploy/k8s/reference#identityprovider.
I should also mention that we're currently in the middle of rethinking Pomerium's mTLS support, so if you have any specific suggestions or feature requests please feel free to share them. I can't make any promises, but if you have any thoughts I'd be interested to hear them.

if you have any specific suggestions or feature requests please feel free to share them.

I haven't been able to find a discussion or issue related to this, so I guess I'll just post my comments here :-)
The advantage of implementing mTLS directly in Pomerium is that API integration for anything Pomnerium is proxying is super easy. Just setup e.g. an openssl config, reference it with curl, and you're done. This gets quite a bit more advanced if there is a separate mTLS endpoint that needs to be authenticated against first.
The disadvantage is that mixing mTLS into all of this can become super complicated. The requirements for it and configuration of it is just completely different from all the other authentication flows, which might mean having to account for it in every single feature that you implement (or worse, you forget to account for it).
I see a solution that could circumvent both issues, but it's a little more complicated: A built-in, but separate, mTLS server that acts as an OIDC provider and can authenticate browser clients, and an authentication flow that supports JWK/the x5c field in JWT tokens (rfc).
This way programmatic access doesn't require multiple requests or special openssl configuration and can be implemented using the dozens of libraries already available. At the same time you can still support seamless user access through browsers with installed client certs.
The advantage of using a single OIDC endpoint for browser mTLS is that you can avoid presenting the user with PIN prompts for every pomerium protected site they visit.

Hi @andsens, delegating mTLS to a separate identity provider is definitely an interesting idea. I think one could even prototype this today without further changes to Pomerium itself: if this OIDC provider returned a custom claim in its ID token, you could write a Pomerium policy with a claim/ criterion against it. (This claim could be as simple as "validated: true" if all you care about is certificate validity, or something more complicated like "certificate_email: <email address>" if you wanted to, say, extract a SAN email address from the certificate.)


[Minor] Fix indentation in generators

Some generators produce incorrect indentations E.g.
Actual
class Users::RegistrationsController < Devise::RegistrationsController
# before_action :configure_sign_up_params, only: [:create]
# before_action :configure_account_update_params, only: [:update]

  # GET /resource/sign_up
...

Expected
class Users::RegistrationsController < Devise::RegistrationsController
  # before_action :configure_sign_up_params, only: [:create]
  # before_action :configure_account_update_params, only: [:update]

  # GET /resource/sign_up
...

This would result in configured linters screaming about improper code. Thought i'd fix it for everyone.

Thanks!


Table widget on dashboard - $columnSpan = 'full' does't take affect

Package
filament/widgets
Package Version
v3.2
Laravel Version
v11.9
Livewire Version
3.4
PHP Version
8.2
Problem description
I had a single table widget showing on my default dashboard. I changed the column width with protected int|string|array $columnSpan = 'full'; successful to the full width.
Then, I implemented a custom blade-Template because I wanted to have Tabs in my widget.
Now, the widget only appears in a one column width. Not in full width anymore.

I still have the columnspan = "full" in my code: https://github.com/Feuerwehr-Bamberg-Loschgruppe-1/Strichliste/blob/b2d8132dd83d2546ae642574fe448a61288f9d24/app/Filament/Widgets/MonthlyDrinksWidget.php#L17
Expected behavior
I expected that the widget would be rendered in the fulll width.
Steps to reproduce
Create a table widget and set it to full width.
The widget appears in full width.
Now add the public function render() and set the view to a custom blade-template
Now, the widget appears as a one column widget and not in full width anymore.
Reproduction repository (issue will be closed if this is not valid)
https://github.com/Feuerwehr-Bamberg-Loschgruppe-1/Strichliste
Relevant log output
No response

Donate 💰 to fund this issue

You can donate funding to this issue. We receive the money once the issue is completed & confirmed by you.
100% of the funding will be distributed between the Filament core team to run all aspects of the project.
Thank you in advance for helping us make maintenance sustainable!

Without public function render()

I found the solution. A user give me the hint that I had to change the div to
<x-filament-widgets::widget> /// </x-filament-widgets::widget>
But I didn't found this in the table widget part neither in the widget blade template.


Bot application service url IP address

Hi Team,
We need your support in enabling our firewall proxy settings for  testing our hosted bot application. Through our logs in the application we are seeing the following error
Bot application error
System.Net.Http.HttpRequestException: An error occurred while sending the request. ---> System.Net.WebException: Unable to connect to the remote server ---> System.Net.Sockets.SocketException: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond <IP_ADDRESS>:443
Upon  performing the trouble shooting with the network firewall it has been observed that firewall is blocking the requests from botframework service and for every request  it comes from different IP address from microsoft service. Could you provide us the range of IP addresses from which the requests are coming. So that we will enable those range of IP in our firewall

Hi @nagenndrababu, there is unfortunately no single list of IP addresses. Many of the Bot Framework servers are hosted on Azure, although many are not, and some of them may move without notice.

We have same issue from customer which would like to protect their service by defining range of ipadresses in firewall.
I think it is reasonable requirement.

Hi @vovanb, we don't have a single list. Traffic could originate from any Azure datacenter or any Microsoft non-Azure datacenter. You can find a list of all Azure IPs but I don't think there is a published list of other Microsoft servers.

You can find the Azure IP ranges here: https://www.microsoft.com/en-us/download/details.aspx?id=41653
These IPs will work for some channels for now, but may break without notice (and without the possibility of reversing the change) in the future.

Closing as we have answered the question. Please open a new issue if you'd like to discuss further.


How to change the number format of Bar chart label when tap on a bar?

Is there any parameter to change the number format in the image?. Thanks

Hi.
There are a lot of samples here. Please check them, we customized tooltip in some of them like this one:
Line Sample 1 (Source Code)


Animating movement between options in the spawn menu

This change does the following:

Modifies the SpawnPointList to introduce a new coroutine for moving the content position to the location of a specific menu option.
Modifies SpawnPointSelectorManager to use this new coroutine.

Testing:

Verified that loading/exiting/reloading the spawn menu still works.
Verified that moving between menu options is animated.
Verified that holding down up/down scrolls menu options more quickly, and that the animation is still smooth.

one nitpick, otherwise lgtm


Custom procedure editing: renaming, adding, and deleting inputs and labels

Resolves
Related to #607, https://github.com/LLK/scratch-blocks/issues/1195, https://github.com/LLK/scratch-blocks/issues/1185
Proposed Changes
Each argument on a custom procedure now has an id and a displayName instead of an id and a name.
argument.id now corresponds to the name field on the Blockly.Input that stores and renders that argument.
argument.displayName is what is seen and edited by the user.
The paramMap is now gone, since the mapping is done by argument.id.
procedures_mutator_root is now called procedures_declaration_root.
Reason for Changes
Continuing to implement custom procedures.
Test Coverage
Tested in the custom procedure playground.  There are two useful buttons for testing: "add random input" and "remove random input".

@paulkaplan @picklesrus ready for review again.  I'm going to look into testing.

Tests still seem to be failing, and had one tiny question about constant definitions.
Wanted to just make a checklist here of things that have to change in the VM (opcode mapping) to support this:

[ ] procedures_defnoreturn => procedures_definition
[ ] procedures_callnoreturn => procedures_call
[ ] procedures_callnoreturn_internal => procedures_prototype
[ ] procedures_param => argument_reporter_string_number or argument_reporter_boolean

Is that last one right?

Horizontal tests are failing, yeah.  I think it's a problem with mocks not being set up properly, but I'll take a look.
Opcode mapping: yes, those all look right.  Procedures_param is now two separate things.


Input type of choice is not parsing as a valid option despite GitHub documentation.

On 11/10/2021 it was announced that choice was a supported option for workflow_dispatch inputs, GitHub Actions: Input types for manual workflows.
However when I attempt to add a choice input and this extension it says it is invalid, screenshot included

Is this just a schema mismatch between the current github action schema and what the extension is leveraging? Regardless can we get an update to support all the different manual input types.

This should work now.


homepage - format news/blog section

Right now, blog items are listed vertically. We could pull out a featured image and give that section a strong pull.
Is one featured article good, or more? Should it default to the most recent?

I believe we initially intend for one blog post(The most receont one) to be featured on the front page then linking out to the rest of the blog post. Thoughts on going forward with that?
I think for sure the featured should default to the most recent since it'll show that we are active.
If we want to put more post on the front page I think we can pull out three and have them inline.

Cool. I like the idea of three in a row. But let's go with one featured for now. In the future maybe we have the option to switch between the two with a quick config change.


Update to 2.2.1

The importer needs to keep up with ElasticSearch 2.2.1. Otherwise, you get errors like this:
Caused by: java.lang.IllegalArgumentException: An SPI class of type org.apache.lucene.codecs.PostingsFormat with name 'Lucene50' does not exist.  You need to
 add the corresponding JAR file supporting this SPI to your classpath.  The current classpath supports the following names: [es090, completion090, XBloomFilt
er]

I had to downgrade ES to 2.2.0 in order to use the recommended importer from the matrix table.

I can connect JDBC importer <IP_ADDRESS> to Elastiscearch 2.2.1 without errors, so everything ok here.
Maybe you build an uberjar and messed up META-INF/services for Lucene. See issue at https://github.com/elastic/elasticsearch/issues/15071


added emoji intruder

PR Description 📜
given a grid of emojis , find the odd one out emoji from the grid in a given time limit.
Fixes #2949

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @Nikita06211 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@kunjgit sir kindly review and merge this PR

Thank you  @Nikita06211 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


BioCompute Organization

Page needs to be created/updated
Original content at https://github.com/biocompute-objects/bco-public-website/blob/main/content/organization.md

Card/page has been hidden for the 4.0.0 release. Should be addressed in a later release.

deadline: 3.5.22


Setup migration patten to allow updating schema without breaking existing projects

With this pattern in place, whenever a newer version of AutoArena points towards an older project database, the database will be migrated to the latest state. This allows the project database schema to change over time without breaking the experience for users, provided they are using the latest version of AutoArena.
No attempt is made at this time to allow backwards migrations, or runtime compatibility of older versions of AutoArena with newer project files.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (trunk@327d2a1). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff            @@
##             trunk      #44   +/-   ##
========================================
  Coverage         ?   94.83%
========================================
  Files            ?       28
  Lines            ?     1220
  Branches         ?        0
========================================
  Hits             ?     1157
  Misses           ?       63
  Partials         ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thanks for the comments @consoull @yifanwu-kolena — I'm going to merge this one and punt any backwards migration and checkpointing functionality indefinitely until it's proven necessary.


operator [N] [CI] pubsubplus-eventbroker-operator (1.0.0)

Thanks submitting your Operator. Please check below list before you create your Pull Request.
New Submissions

[ ] Have you packaged and deployed your Operator for Operator Framework?

[ ] Have you tested your Operator in all supported installation modes?
[ ] Have you considered whether you want use semantic versioning order?
[ ] Are you familiar with our contribution guidelines?
[ ] Is your submission signed?
[ ] Is operator icon set?

Updates to existing Operators

[ ] Did you create a ci.yaml file according to the update instructions?
[ ] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[ ] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[ ] Have you tested an update to your Operator when deployed via OLM?
[ ] Is your submission signed?

Your submission should not

[ ] Modify more than one operator
[ ] Modify an Operator you don't own
[ ] Rename an operator - please remove and add with a different name instead
[ ] Modify any files outside the above mentioned folders
[ ] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[ ] Description about the managed Application and where to find more information
[ ] Features and capabilities of your Operator and how to use it
[ ] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[ ] Human readable name and 1-liner description about your Operator
[ ] Valid category name1
[ ] One of the pre-defined capability levels2
[ ] Links to the maintainer, source code and documentation
[ ] Example templates for all Custom Resource Definitions intended to be used
[ ] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

/merge possible


Turn on MFA for AWS environment

I attached the Force_MFA policy from https://docs.aws.amazon.com/IAM/latest/UserGuide/tutorial_users-self-manage-mfa-and-creds.html, so you should be required to enable MFA the next time you log in now. MFA is enabled on the root account.


SignalR client address resolution

Hello,
I am working on a project integrating SignalR with .NET Aspire and have encountered a specific challenge related to automatic address resolution for connections.
We are using SignalR Client for real-time communication, and currently, the configuration of the SignalR hub connection address is done manually in the appsettings.json.
Specific Challenge:
While in HttpClient, using a generic address like http://apiservice automatically resolves the correct address, this approach does not work with the SignalR client. When attempting to use http://apiservice or ws://apiservice with the SignalR client, the connection fails to establish, indicating an issue with automatic address resolution.
Is there a way to configure the SignalR client in .NET Aspire to automatically resolve the connection address, similar to what happens with HttpClient?
If so, what are the steps to implement this functionality, or where can I find relevant documentation?
I would greatly appreciate any guidance, suggestions, or code examples that could help resolve this issue. Thank you very much for your assistance!

maybe yarp can solve this?

I tried using YARP, but I couldn't succeed. I managed to find a workaround using var resolve = _configuration.GetValue("services:apiservice:1");".

I also came into the same issue - and was interested to try and use service discovery for SignalR clients. I ended up pinching the same code from UseServiceDiscovery .
This is in a Razor page, I had to inject IConfiguration, so that service resolving can presumably look up the service env vars:
@inject IConfiguration Configuration;

var hubBuilder = new HubConnectionBuilder()
    .WithUrl("http://apiservice/eventhub");

hubBuilder.Services.AddSingleton(Configuration);
hubBuilder.Services.AddServiceDiscovery();
hubBuilder.Services.AddSingleton<IConfigureOptions<HttpConnectionOptions>, ServiceDiscoveryHttpOptionsConfigurer>(provider =>
{
    var timeProvider = provider.GetService<TimeProvider>() ?? TimeProvider.System;
    var selectorProvider = provider.GetRequiredService<IServiceEndPointSelectorProvider>();
    var resolverProvider = provider.GetRequiredService<ServiceEndPointResolverFactory>();
    var registry = new HttpServiceEndPointResolver(resolverProvider, selectorProvider, timeProvider);

    return new ServiceDiscoveryHttpOptionsConfigurer(registry);
});

_hubConnection = hubBuilder.Build();

public class ServiceDiscoveryHttpOptionsConfigurer : IConfigureOptions<HttpConnectionOptions>
{
    private readonly HttpServiceEndPointResolver _registry;

    public ServiceDiscoveryHttpOptionsConfigurer(HttpServiceEndPointResolver registry)
    {
        _registry = registry;
    }

    public void Configure(HttpConnectionOptions options)
    {
        options.HttpMessageHandlerFactory = handler => new ResolvingHttpDelegatingHandler(_registry, handler);
    }
}

cc @BrennanConroy

The easier way to wire this up assuming you have access to the client factory would be something like this:
public static class HubConnectionExtensions
{
    public static IHubConnectionBuilder WithUrl(this IHubConnectionBuilder builder, string url, IHttpMessageHandlerFactory clientFactory)
    {
        return builder.WithUrl(url, options =>
        {
            options.HttpMessageHandlerFactory = _ => clientFactory.CreateHandler();
        });
    }
}

You need to inject the IHttpMessageHandlerFactory into your code and pass it into the WithUrl call above.

@ReubenBond we have to clean up the service discovery API and make it easy to get to wire it up.
@IEvangelist I think we should document using the Http client factory interfaces to get either an HttpClient or an HttpMessageHandler as the first-class way to do integration with libraries that have not been SD enlightened.

I see similar behavior for the WebSockets (blazor, interactiveserver connecting to apiserver for update notification). I get a name on the wss protocol resolution error (and a delay of 2s). I tried to replace the web socket factory but I am not understanding how to change the name resolver there. When I change the transport to LongPolling and use @davidfowl hack of above, it works smooth as expected.

The easier way to wire this up assuming you have access to the client factory would be something like this:

Thanks, took me a bit to figure out, but it worked.

I'm having the same problem between react (send/receive), .net 8(signalr here) and aspire, where the api is using signalr stand alone

I'm currently struggling with service discovery for ClientWebSocket (non-SignalR websocket communication). It would be great to get an API for resolving service discovery on demand. There are probably many cases service discovery needs to be used without HttpClient, HttpMessageHandler, etc.
something like .GetRequiredService<ServiceDiscoverySomething>().ResolveUrl(url)

I'm currently struggling with service discovery for ClientWebSocket (non-SignalR websocket communication). It would be great to get an API for resolving service discovery on demand. There are probably many cases service discovery needs to be used without HttpClient, HttpMessageHandler, etc.
something like .GetRequiredService<ServiceDiscoverySomething>().ResolveUrl(url)

I can suggest one such use case; constructing a hyperlink to an endpoint on one of those services. I have a service that sends emails to users, and those emails need to include links to various parts of our platform. Some of those links are to services that are configured via service discovery, but there does not seem to be an easy way of getting that URL except by trying to send something to it.


Login as buildkite user

Context
Recently we found /usr/local/bin was not in buildkite-agent user's path. I tried adding it to the bash_profile for the user, but that didn't work because we're calling sudo and it defaults to the secure_path, which by default is very restrictive
Change
Emulate user login when launching buildkite-agent so we get all the env variables sourced from .bash_profile

Might it be clearer to just do that in the environment hook? I'd prefer to keep the env/defaults inherited from the system environment as minimal as possible.

Yeah that sounds like a logical place to put it. My only problem is I'm trying to keep drift from this stack to a minimum, so how do I add something (i.e. add /usr/local/bin to $PATH) without modifying the existing scripts? Should we source another file (i.e. ~/user-env) where users can place their own environment paths?

Yeah, fair point. Perhaps we should just explicitly set a path that includes /usr/local/bin in the stack environment hook?
I'm reluctant to add to much stuff to customize the host system environment as I really want to move to a "agents run in docker" approach as soon as possible.

Yeah given the headache this has caused I'm inclined to just stop supporting anything not running in docker


Property to control Zoom In/Out the Network View.

Hi,
First of all. Big thanks for this great library.
I have scenario here where we need provide an option to zoom in/out the Network View using button instead of mouse. Is there any property available to control it?
Thanks

@Wouterdek : Thanks for adding this request as enhancement.
Is there any suggestion or workaround to achieve this functionality with current version?
Thanks

Zoom is controlled by the DragCanvas in NetworkView, which currently doesn't support setting zoom levels programmatically.
I'll be working on the library at the end of this month or the beginning of september, I'll look into it then.

@Wouterdek : Great. Many thanks for your prompt reply.

Next version will have a ZoomFactor property on the NetworkViewModel.

@Wouterdek : Thank you.


remove outline from the input

since you're using a rounded input, some browsers will still show a rectangle outline when the input is focused. chrome on osx, for instance, does this.

@SteveByerly It breaks accessibility. It is not critical, but it's important. What do you think?

You are totally right - i completely failed to address accessibility. I've updated the PR to account for highlighting the focused input.

👍


WIP v0.0.3

Tasks:

[x] Fix crash when RG3 trying process incomplete definition
[x] Add precache for platform paths detector (in AnalyzerContext)
[x] Export AnalyzerContext into init.py
[x] Fix tag parser (support dots in tag name)
[x] Support explicit type registration via annotations & templates

Need add annotation "RG3_RegisterLocation[path]" to override source header file for specific type. This path will be interpreted as "angled" path like #include <my_path>.
Expected behaviour: RG3_RegisterLocation affect path, declares Location as 'angled', set line and column to 0, set path to [new_path]

Support of template specialization registration via annotations moved to v0.0.4

Apple, wtf...

macOS fixed

Template type recogintion finished but 1 test failed on ubuntu machine.
Test: Tests_AnonymousRegistration.TrivialAndSTLTypesRegistration
Need investigate what's happened and why 1 type not found.

So, our types processing method has a few issues and test cases when it's failed. I'm working on fix of that cases and trying to rewrite that places.

Finalized scheme and fixed most issues. If last commit compiles fine I'll initiate release of v0.0.3

Looks nice, let's release this.


Initializing bug in 6.3.2?

Hi,
After upgrading to 6.3.2 today, my published react project started acting wonky. What appears to be happening is that if I open my app in a browser, it will be re-directed to the last opened page. For example, let's say browser tab A is opened to:
http://mysite.com/path/to/something
...and then I open browser tab B and navigate to:
http://mysite.com/totally/different/path
...browser tab B will be redirected to
http://mysite.com/path/to/something
...immediately. I wasn't able to run any extensive testing I'm afraid, as I had to downgrade right away to get to some pressing work. I'm running React 16.8.4, react-router 4.3.1, and connected-react-router 6.3.2 (before the downgrade).
My config is as follows.
I have a custom history setup like this:
import createBrowserHistory from 'history/createBrowserHistory';

const history = createBrowserHistory({ basename: '/my/basepath/' });

export const navigate = (url) => {
  history.push(url);
};

export default history;

...and then my (somewhat stripped down) store config looks like this:
import { persistCombineReducers, persistStore } from 'redux-persist';
import sessionStorage from 'redux-persist/es/storage/session';

const allReducers = {
	...myAppReducers,
	router: connectRouter(customHistory)
}
const reducers = persistCombineReducers(persistConfig, allReducers);

export default function configureStore() {

	const store = createStore (
	 connectRouter(customHistory)(rootReducer),
	 {},
	 composeEnhancers (
	   responsiveStoreEnhancer,
	   applyMiddleware (
			 sagaMiddleware,
			 routerMiddleware(customHistory)
	   )
	 )
	)

	const persistor = persistStore (store)
	sagaMiddleware.run(rootSaga)
	return { persistor, store }
}

Hmm...could this be a bad interaction between redux-persist, I wonder? As I said at the top, this doesn't happen under 6.3.1, so it seems like the problem is localized to connected-react-router, but I could imagine some bad interaction between the different libraries.
Hope this is useful!

Same issue here, routing broken with react 16.8.4 using SSR, connected-react-router 6.3.2 and using createBrowserHistory. Version 6.3.1 works fine. I suspect the isFirstRendering fix that was included in 6.3.2 (#259).
App is available under a base path. When sending data to the browser after rendering on the server, the router location state is set to /mybasepath/, then just after the @@INIT event there is a @@router/LOCATION_CHANGE event that requires the path / (first route without the base path). Still investigating.

I had a somewhat related issue (#267) caused by the fix present on v6.3.2 that makes isFirstRendering work properly (in earlier versions like v6.3.1, it was always false).
Since you say you're opening a new tab (therefore causing a "first rendering" of the page), I suspect it's the same cause.
I guess the problem comes from this statement in the reducer code: https://github.com/supasate/connected-react-router/blob/v6.3.2/src/reducer.js#L24
        return isFirstRendering
          ? state
          : merge(state, { location: fromJS(location), action })
}

when isFirstRendering is true, the reducer just returns the current state, when it's false, it uses the location from the payload
I don't know how redux-persist works, but I see it stores into Session Storage, which is shared across tabs for the same origin (domain + port). I suspect something like: you open the tab B, requesting a path, the router kicks in, see it's the first rendering, so it returns the state as-is, but the state comes from Session Storage and contains the latest state of tab A, causing a redirect to tab A location.

@mdupont That sounds like a plausible explanation. I don't see how this isn't bad behavior, though. In the world of a single page app, there are still times where you legitimately want to open a second window of the app, and you certainly don't want that new window navigating somewhere you didn't tell it to. In my case, I open that second window to a specific route (e.g. /my/second/route), and connected-react-router navigates away from that route upon load.
One potential solution here is that redux-persist shouldn't persist the data connected-react-router stores. So, when redux-persist rehydrates the app from its data store (which can be whatever you want it to be, but in my case is indeed Session Storage, as you note), it just skips the stuff connected-react-router stores. That seems like it might work when opening a new window, but it seems like you wouldn't want that behavior if you simple reload the existing window, and therefore are just reloading the main instance of your React app.
So it still seems to me like the behavior in 6.3.2 is broken, but I'd be happy to be wrong here, so long as there's a solution that gets me where I need to be.
FWIW, I use connected-react-router primarily so I can trigger route changes from outside router calls (e.g. I sometimes do route changes from inside redux-saga saga functions.)

Okay, so it looks like adding blacklist: ['router'] to the redux-persist config options does the trick. I'll close this for now, and re-open if that turns out not to fix the issue.

@bmueller-sykes - dropping in to say that the blacklist fix worked for me as well.  If you're running a production app, you may also want to add a migration to remove router from your existing users' persisted states:
Mine looks like this, and seems to do the trick:
state => {
  const { router, ...restOfState } = state;
  return restOfState;
},


Find widget: when press button find next, one item is skipped

From<EMAIL_ADDRESS>on 2012-05-16T05:38:39Z
Commit 0b0254d159fd (Simplified previous change ( revision 9caff1b29c14 )) results on my end in the following behaviour:

pressing enter brings up the next item
pressing next button/F3 brings up the 2nd next item instead of next (1 item is skipped)

The original commit enabling "go next on enter" ( revision 9caff1b29c14 ) worked correctly from my perspective.
offending lines?
----------------
It seems that, on lines 51-53 of spyderlib/widgets/findreplace.py
self.connect(self.search_text, SIGNAL('valid(bool)'),
lambda state:
self.find(changed=False, forward=True, rehighlight=False))
is always triggered, both on ENTER and on F3/next button events. That explains why it skips 1 next item. Unfortunately, lack of knowledge prevents me suggesting a fix.
System info:
------------
Arch Linux 3.3.6, Python 2.7.3, Qt 4.8.0, PyQt4 (API v2) 4.9.1, Spyder latest and greatest from the default repo (2.2.0dev)
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=1029

From<EMAIL_ADDRESS>on 2012-05-16T03:47:23Z
Note that search previous (button or SHFIT+F3) works as intended.

From<EMAIL_ADDRESS>on 2012-05-16T07:40:15Z
Ahh.. this is why I'm having a trouble with a function/function definition where the function is only called once.  Please fix ASAP!

From<EMAIL_ADDRESS>on 2012-05-16T07:15:22Z
I have experienced this myself, but I didn't pay much attention because I thought it was user error. I'd be in favor of reverting the change back to r9caff1b29c14 .

From<EMAIL_ADDRESS>on 2012-05-18T07:48:06Z
issue #1033 has been merged into this issue.

From<EMAIL_ADDRESS>on 2012-05-18T08:57:18Z
See code review comments attached to r0b0254d159fd for more details on the source of the problem.

From pierre.raybaut on 2012-05-22T03:02:22Z
This issue was updated by revision 7de0897e0549 .
Status: Fixed

From<EMAIL_ADDRESS>on 2012-05-22T04:45:57Z
Tested.
Status: Verified


feat: rendering-metadata-in-paymentsummary

rendering metadata in payment Summary

https://user-images.githubusercontent.com/55848322/177002589-a6901746-8ad0-4370-87e3-5036eb8b1aab.mp4

@pavanjoshi914 can you solve this conflict?


Allow authorizing non-HTTPS apps with a dev build of Pallad

Problem:

Pallad's extension currently restricts content scripts to HTTPS sites, preventing testing on local non-HTTPS environments. This limitation hinders developers from easily testing and authorizing the extension in non-HTTPS apps during development.

closes: #195
Issue ticket number and link:

Ticket Number: [ 195 ]
Link: [ https://github.com/palladians/pallad/issues/195 ]

Acceptance Criteria

[x]  Feature Flag: Add VITE_APP_DEV_MODE to .env.example.
[x] Manifest Update: If VITE_APP_DEV_MODE === 'true', include http://*/* in the content script matches array in manifest.ts.
[x] Build Behavior: When built with VITE_APP_DEV_MODE=true, allow content scripts in non-HTTPS apps.

@mrcnk Please review this PR.


ENH: Handle other periodic boundary conditions

eOn depends on the assumption that all the external potentials (and some of the output writers) use the same  definition of PBCs for wrapping. However, this is not always true.
After discussions with Hannes, the cleanest way for now is to just maintain all the varying implementations (there aren't that many [1,2,3]), and allow the Potentials to pass the type as a parameter.
Refs:
[1] Deiters, U. K. Minimum Image Convention Coding of Microcomputers. Molecular Simulation 1989, 3 (5–6), 343–344. https://doi.org/10.1080/08927028908031386.
[2] Hloucha, M.; Deiters, U. K. Fast Coding of the Minimum Image Convention. Molecular Simulation 1998, 20 (4), 239–244. https://doi.org/10.1080/08927029808024180.
[3] Deiters, U. K. Efficient Coding of the Minimum Image Convention. Zeitschrift für Physikalische Chemie 2013, 227 (2–3), 345–352. https://doi.org/10.1524/zpch.2013.0311.

Worth keeping https://github.com/MDAnalysis/mdanalysis/issues/1475 in mind as well.
In general the current approach in eOn is to use fractional coordinates, rescale and then back-transform, which is very solid for orthogonal boxes (if a little expensive), not so sure about triclinic.


Open only default snippets on double-click from the sessions widget

When double clicking in the sessions widget, a snippet using the default session should be opened only when the double click happens on the default session


mscompile branch successfully compiles and needs testing

I am requesting aid in testing STELLOPT compilation on windows machines. The compilation currently works.
Purpose of this project:
Goal: Support compilation of a shared libstell.dll that is usable with python on windows machines.

Numpy currently supports shared libraries under ctypes, but not static libraries
Most users at IPP-Greifswald have windows VMware machines without administrative privileges.
Instead of maintaining many separate unsupported toolchains (wout parsers, etc.), we should encourage use of the tools provided by the core developers within LIBSTELL.

Status: with GCC9.3 under msys64+mingw64 on windows 10

serial / parallel static libraries successfully compile (libstell.lib)
serial shared LIBSTELL library successfully compiles (libstell.dll)
testing on Windows 10, mac-osx Catalina

Requests:

Testing compilation on Windows machines outside of my computational environment
Testing required modifications to makefiles under traditional build-systems (HPC, mac osx, etc.)
Eventual merging with development branch
Testing and development of PYSTELL

Still cleaning it up.


Removes code to filter to subsets.

Should only go in after https://github.com/Oufattole/meds-torch/pull/57. Closes https://github.com/Oufattole/meds-torch/issues/62

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (55_dataset_cleanup@360f02f). Learn more about missing BASE report.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@                  Coverage Diff                  @@
##             55_dataset_cleanup      #66   +/-   ##
=====================================================
  Coverage                      ?   64.17%
=====================================================
  Files                         ?       10
  Lines                         ?      723
  Branches                      ?        0
=====================================================
  Hits                          ?      464
  Misses                        ?      259
  Partials                      ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add CII Best Practices badge

Proposed changes
This PR adds CII Best Practices badge.
Types of changes
What types of changes does your code introduce to the project: Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[X] Update only documentation, not any source code.

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

[X] I have read the CONTRIBUTING doc
[ ] I have signed the CLA
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Further comments
N/A

Coverage remained the same at 100.0% when pulling 98f3da6cf8f0f732f4cd57a070a13e12cff72fe0 on fisuda:add/cii_badge into 6c1000b64b6a2f1847689a30a77015e988ce1c74 on lets-fiware:main.


Behaviour of --force-regen for image_regression

I made some small changes to plots I test using image_regression and noticed that --force-regen only regenerated the images that changed enough to fail the test.
Is this intended behaviour?
From the docstring for data_regression it sounds like --force-regen is supposed to regenerate all test data.

Hi @erihe251,

only regenerated the images that changed enough to fail the test.

Yeah that's right, that's the intended behavior currently.

Hi @nicoddemus, and thanks.
So the documentation

To regenerate the data, either set force_regen attribute to True or pass the --force-regen flag to pytest which will regenerate the data files for all tests.

would be more accurate as

To regenerate the data, either set force_regen attribute to True or pass the --force-regen flag to pytest which will regenerate the data files for all failed tests.

?
I can see that this behaviour is more efficient, but the "force" keyword made me assume unconditional regeneration.

Yeah the docs are incorrect, we should fix that. Would you like to contribute? That can be done directly through GitHub's UI. 😁

I'll fix it!


Error when opening spyder

Description
What steps will reproduce the problem?

Graphics backend Gtk3
Open Spyder

What is the expected output? What do you see instead?
Expect no error message
Please provide any additional information below
After the error I have to reopen spyder a few times and then it works fine. It could not connect to the python kernel (In console: connection to kernel...)
File "/usr/lib/python3.6/site-packages/spyder/plugins/init.py", line 511, in
toggled=lambda checked: self.toggle_view(checked),
File "/usr/lib/python3.6/site-packages/spyder/plugins/ipythonconsole.py", line 695, in toggle_view
self.create_new_client(give_focus=False)
File "/usr/lib/python3.6/site-packages/spyder/plugins/ipythonconsole.py", line 974, in create_new_client
self.connect_client_to_kernel(client)
File "/usr/lib/python3.6/site-packages/spyder/plugins/ipythonconsole.py", line 995, in connect_client_to_kernel
stderr_file)
File "/usr/lib/python3.6/site-packages/spyder/plugins/ipythonconsole.py", line 1383, in create_kernel_manager_and_kernel_client
stderr = codecs.open(stderr_file, 'w', encoding='utf-8')
File "/usr/lib/python3.6/codecs.py", line 895, in open
file = builtins.open(filename, mode, buffering)
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/spyder-martin/kernel-4d681953b37a.stderr'
Version and main components

Spyder Version: 3.2.0
Python Version: 3.6.2
Qt Versions: 5.9.1, PyQt5 5.9 on Linux

Dependencies
pyflakes >=0.6.0 :  1.6.0 (OK)
pycodestyle >=2.3:  2.3.1 (OK)
pygments >=2.0   :  2.2.0 (OK)
pandas >=0.13.1  :  None (NOK)
numpy >=1.7      :  1.13.3 (OK)
sphinx >=0.6.6   :  1.6.4 (OK)
rope >=0.9.4     :  0.10.7 (OK)
jedi >=0.9.0     :  0.11.0 (OK)
psutil >=0.3     :  5.3.1 (OK)
nbconvert >=4.0  :  5.1.1 (OK)
sympy >=0.7.3    :  None (NOK)
cython >=0.21    :  None (NOK)
qtconsole >=4.2.0:  4.3.0 (OK)
IPython >=4.0    :  5.3.0 (OK)
pylint >=0.25    :  1.7.4 (OK)

I see you don't use the latest Spyder version. It is possible to upgrade to 3.2.3. By upgrading you distribution or pip install --upgrade spyder

@Jeroendevr is right. I think this problem was fixed in 3.2.3, or it'll be fixed in 3.2.4 (to be released in a couple of days).


request-autotile editor- ability to mark squares as filled shapes/ autofill squares with a single click

Right now setting collusion,occlusion and navigation is extremely cumbersome, because you have to manually draw the shapes. It would save ALOT of time and effort if there is a quick command that simply fills the selected square with a square shape - instead of asking to manually create each single shape
99% of the time that is what we want anyway
See how rpg maker has it:

It takes one single click to mark a square as passable or non passable. We can also click and drag to set multiple squares as non passable and right click and drag- to set multiple squares as non passable.
Can we get a tool that emulates that somehow? Autoshape fill tool?

If you talking about top down game, that was totally fine. But how about sidescroller game? Some of my tiles I created is not full square, sometimes I need polygon shapes (non square). Well, the collision using concave which is currently not usable for KinematicBody2D.
Maybe fixing the snap function (I try the snap and doesn't work) will be more suitable

@damarindra  for more specific shapes, you can use the current shape tool and draw each square painstakingly manual as you  wish.
My proposal does not nullify the current tools. It merely compliments them.
Here I made a mockup:

That was more suitable in this situation.
Is your snap tool working?

@damarindra not sure about the autosnap- is it supposed to snap to pixels? If so- I dont think it works

@damarindra  do collisions made in the autotile editor work for you? They dont seem to work at all for me- not even showing in debug>visible collision shapes.

Found another bug here:
https://github.com/godotengine/godot/issues/13287

Snapping keep points inside of the tile, and also snaps to bitmask grid (the 2x2 and 3x3 invisible lines)

so a complete fill is 4 (easy) clicks instead of a single click, not sure if this is really necessary, difficult to implement, unless the right click deletes all the shapes on the tile (because there's no way to know which one of the shapes in the tile is the original one created with a fill, sure you can check points and see if they fit, but still not probably the best solution).
BTW @blurymind in the right side of the auto tiles tools there are Zoom In/Out/Reset buttons, it's much easier to edit shapes and record gifts using them. I originally wanted to add buttons to create shapes based on the bitmask (match mask and match non-mask), this tool was suposed to delete all shapes and create new ones. Not sure if will do it, for now it's easy enought to draw shapes.

@MarianoGnu thank you for the tip. I knew about the snap. It still takes too long as compared to a possible bucket tool.
Right now we can't even copy a shape from one tile and paste it into another. Would a copy and paste feature be easier to implement?
I mean if we can do it for bitmasks, why not also be able to do it for tile collision shapes?

copy-paste ALL the shapes together was also on the plans, and not so difficult to do

copy-paste ALL would help a lot !

Adding 6 buttons (copy, copy all, paste, paste as duplicate, paste all, paste all as duplicate) makes stuff confusing, there are a LOT of things that can be done, making the work as simple and with the best experience is important.

how about 3 buttons- copy all,paste all and a bucket fill tool-for filling
tiles quickly with a simple square
On Wed, Dec 6, 2017 at 6:09 PM, Mariano Javier Suligoy <
<EMAIL_ADDRESS>wrote:

Adding 6 buttons (copy, copy all, paste, paste as duplicate, paste all,
paste all as duplicate) makes stuff confusing, there are a LOT of things
that can be done, making the work as simple and with the best experience is
important.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/13283#issuecomment-349725939,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGMbVbGXzOJ7cfcUJPTlvhvSuRw1bvxPks5s9thAgaJpZM4QqgZ5
.

I'd like to throw in my support for a bucket-fill tool, I think that would help a lot. I think just copy+paste would be hugely helpful as well, even if you leave off all other operations.
I also have to manually click the save icon to get the colliders to update, but not the icon or bitmask. That is very confusing, to the point where I thought the colliders were simply broken. I can maybe look into fixing that this weekend sometime if I have the time.

This has been addressed in 3.1 when creating a square collision, it fills the whole tile. Should we close it?

It's still trash to use. See
https://youtu.be/RPgTlxb7Bno?t=469
Can we reopen this bug and make it like my gif mockup:
https://github.com/godotengine/godot/issues/13283#issuecomment-346958074

One click is required to fill a cell - not 3 steps

@blurymind Please open a proposal on the Godot Proposals repository.

Here is alink to the proposal
https://github.com/godotengine/godot-proposals/issues/648


vagrant up: Broken XML is generated

Error:
$ vagrant up
Bringing machine 'test_vm' up with 'libvirt' provider...
==> test_vm: Uploading base box image as volume into libvirt storage...

/root/.vagrant.d/gems/gems/fog-libvirt-0.0.2/lib/fog/libvirt/requests/compute/create_volume.rb:7:in `create_volume_xml': Call to virNetworkCreateXML failed: invalid argument: unknown suffix '.0G' (Libvirt::Error)
        from /root/.vagrant.d/gems/gems/fog-libvirt-0.0.2/lib/fog/libvirt/requests/compute/create_volume.rb:7:in `create_volume'
        from /root/.vagrant.d/gems/gems/fog-libvirt-0.0.2/lib/fog/libvirt/models/compute/volume.rb:40:in `save'
        from /root/.vagrant.d/gems/gems/fog-core-1.32.1/lib/fog/core/collection.rb:51:in `create'
        from /root/.vagrant.d/gems/gems/vagrant-libvirt-0.0.30/lib/vagrant-libvirt/action/handle_box_image.rb:56:in `block in call'
        from /root/.vagrant.d/gems/gems/vagrant-libvirt-0.0.30/lib/vagrant-libvirt/action/handle_box_image.rb:40:in `synchronize'
        from /root/.vagrant.d/gems/gems/vagrant-libvirt-0.0.30/lib/vagrant-libvirt/action/handle_box_image.rb:40:in `call'
        from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in `call'
        from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/builtin/handle_box.rb:56:in `call'
        from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in `call'
        from /root/.vagrant.d/gems/gems/vagrant-libvirt-0.0.30/lib/vagrant-libvirt/action/handle_storage_pool.rb:24:in `block in call'
        from /root/.vagrant.d/gems/gems/vagrant-libvirt-0.0.30/lib/vagrant-libvirt/action/handle_storage_pool.rb:17:in `synchronize'
        from /root/.vagrant.d/gems/gems/vagrant-libvirt-0.0.30/lib/vagrant-libvirt/action/handle_storage_pool.rb:17:in `call'
        from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in `call'
        from /root/.vagrant.d/gems/gems/vagrant-libvirt-0.0.30/lib/vagrant-libvirt/action/set_name_of_domain.rb:34:in `call'
        from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in `call'
        from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:95:in `block in finalize_action'
        from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in `call'
        from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in `call'
        from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/builder.rb:116:in `call'
        from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/runner.rb:66:in `block in run'
        from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/util/busy.rb:19:in `busy'
        from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/runner.rb:66:in `run'
        from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/builtin/call.rb:53:in `call'
        from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in `call'
        from /root/.vagrant.d/gems/gems/vagrant-libvirt-0.0.30/lib/vagrant-libvirt/action/connect_libvirt.rb:18:in `call'
        from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in `call'
        from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/builtin/config_validate.rb:25:in `call'
        from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/warden.rb:34:in `call'
        from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/builder.rb:116:in `call'
        from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/runner.rb:66:in `block in run'
        from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/util/busy.rb:19:in `busy'
        from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/action/runner.rb:66:in `run'
        from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/machine.rb:214:in `action_raw'
        from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/machine.rb:191:in `block in action'
        from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/environment.rb:516:in `lock'
        from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/machine.rb:178:in `call'
        from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/machine.rb:178:in `action'
        from /opt/vagrant/embedded/gems/gems/vagrant-1.7.4/lib/vagrant/batch_action.rb:82:in `block (2 levels) in run'

When outputting the xml in
/root/.vagrant.d/gems/gems/fog-libvirt-0.0.2/lib/fog/libvirt/requests/compute/create_volume.rb there is:
<volume>
        <name>jessie-template_vagrant_box_image_0.img</name>
        <allocation unit="M">8193</allocation>
        <capacity unit=".0G">8</capacity>
        <target>
          <format type="qcow2"/>
          <permissions>
            <owner>0</owner>
            <group>0</group>
            <mode>0744</mode>
            <label>virt_image_t</label>
          </permissions>
        </target>
        </volume>

This is broken, since .0G is not a valid unit.
System is Debian 8 - Ruby is ruby 2.1.5p273 (2014-11-13) [x86_64-linux-gnu]

By default this is specified in bytes, but an optional attribute unit can be specified to adjust the passed value. Values can be: 'B' or 'bytes' for bytes, 'KB' (kilobytes, 103 or 1000 bytes), 'K' or 'KiB' (kibibytes, 210 or 1024 bytes), 'MB' (megabytes, 106 or 1,000,000 bytes), 'M' or 'MiB' (mebibytes, 220 or 1,048,576 bytes), 'GB' (gigabytes, 109 or 1,000,000,000 bytes), 'G' or 'GiB' (gibibytes, 230 or 1,073,741,824 bytes), 'TB' (terabytes, 1012 or 1,000,000,000,000 bytes), 'T' or 'TiB' (tebibytes, 240 or 1,099,511,627,776 bytes), 'PB' (petabytes, 1015 or 1,000,000,000,000,000 bytes), 'P' or 'PiB' (pebibytes, 250 or 1,125,899,906,842,624 bytes), 'EB' (exabytes, 1018 or 1,000,000,000,000,000,000 bytes), or 'E' or 'EiB' (exbibytes, 260 or 1,152,921,504,606,846,976 bytes)
https://libvirt.org/formatstorage.html

thanks for your feedback - but why do you close this issue? From my understanding vagrant-libvirt is generating invalid XML... why do you think, that this is not an issue?

Debugging futher:
The box is generate by tools/create_box.sh - metadata is:
{
    "provider": "libvirt",
    "format": "qcow2",
    "virtual_size": 8.0
}

Looking at 8.0, .0 is evaluated as the unit. This happens, because 8.0 (as a floating-point number) is passed to fog-libvirt (fog-libvirt-0.0.2/lib/fog/libvirt/models/compute/volume.rb  - Look at line 112 we have
        def split_size_unit(text)
          if text.kind_of? Integer
            # if text is an integer, match will fail
            size    = text
            unit    = 'G'
          else
            matcher = text.match(/(\d+)(.+)/)
            size    = matcher[1]
            unit    = matcher[2]
          end
          [size, unit]
        end

As a consequence, floating point numbers should not be passed to fog-libvirt-0.0.2.
Thus, we can either patch fog-libvirt-0.0.2 to handle floating point numbers or we can patch vagrant-libvirt to not pass floating point numbers.
Anyway, I don't think that closing this issue helps :-/

Was there ever a solution for this? @yanosz @pronix


[HBASE-22874] Mark Canary as LA(Tools)

@busbey please review.

PR for branch-1 https://github.com/apache/hbase/pull/516
PR for branch-2 https://github.com/apache/hbase/pull/515

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
227
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
374
master passed

+1
compile
56
master passed

+1
checkstyle
77
master passed

+1
shadedjars
264
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
38
master passed

0
spotbugs
242
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
240
master passed

_ Patch Compile Tests _

+1
mvninstall
308
the patch passed

+1
compile
60
the patch passed

+1
javac
60
the patch passed

+1
checkstyle
73
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
307
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1069
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
33
the patch passed

+1
findbugs
247
the patch passed

_ Other Tests _

-1
unit
16455
hbase-server in the patch failed.

+1
asflicense
32
The patch does not generate ASF License warnings.

20249

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestFromClientSide3

hadoop.hbase.client.TestFromClientSideWithCoprocessor

hadoop.hbase.util.TestFromClientSide3WoUnsafe

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/514

JIRA Issue
HBASE-22874

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 3fba09302616 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-514/out/precommit/personality/provided.sh

git revision
master / ab28f9d8c7

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/1/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/1/testReport/

Max. process+thread count
5169 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
90
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
356
master passed

+1
compile
62
master passed

+1
checkstyle
98
master passed

+1
shadedjars
323
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
42
master passed

0
spotbugs
280
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
278
master passed

_ Patch Compile Tests _

+1
mvninstall
341
the patch passed

+1
compile
60
the patch passed

+1
javac
60
the patch passed

+1
checkstyle
87
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
304
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1039
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
41
the patch passed

+1
findbugs
311
the patch passed

_ Other Tests _

-1
unit
17356
hbase-server in the patch failed.

+1
asflicense
29
The patch does not generate ASF License warnings.

21246

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestFromClientSideWithCoprocessor

hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/514

JIRA Issue
HBASE-22874

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 46e273dc0d77 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-514/out/precommit/personality/provided.sh

git revision
master / 66ad42c742

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/2/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/2/testReport/

Max. process+thread count
4887 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/2/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
78
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
356
master passed

+1
compile
56
master passed

+1
checkstyle
81
master passed

+1
shadedjars
315
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
38
master passed

0
spotbugs
277
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
274
master passed

_ Patch Compile Tests _

+1
mvninstall
360
the patch passed

+1
compile
59
the patch passed

+1
javac
59
the patch passed

+1
checkstyle
77
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
269
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1058
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
34
the patch passed

+1
findbugs
265
the patch passed

_ Other Tests _

-1
unit
20361
hbase-server in the patch failed.

+1
asflicense
66
The patch does not generate ASF License warnings.

24195

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestSnapshotTemporaryDirectory

hadoop.hbase.replication.TestReplicationSmallTestsSync

hadoop.hbase.client.TestFromClientSideWithCoprocessor

hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory

hadoop.hbase.tool.TestBulkLoadHFiles

hadoop.hbase.replication.TestReplicationSmallTests

hadoop.hbase.util.TestFromClientSide3WoUnsafe

hadoop.hbase.tool.TestSecureBulkLoadHFiles

hadoop.hbase.client.TestRestoreSnapshotFromClientClone

hadoop.hbase.client.TestCloneSnapshotFromClientNormal

hadoop.hbase.master.procedure.TestSCPWithReplicas

hadoop.hbase.namespace.TestNamespaceAuditor

hadoop.hbase.client.TestFromClientSide3

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/514

JIRA Issue
HBASE-22874

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux ecf7235fe920 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-514/out/precommit/personality/provided.sh

git revision
master / 7af5b30eca

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/3/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/3/testReport/

Max. process+thread count
4885 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/3/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
42
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
389
master passed

+1
compile
77
master passed

+1
checkstyle
111
master passed

+1
shadedjars
359
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
42
master passed

0
spotbugs
308
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
305
master passed

_ Patch Compile Tests _

+1
mvninstall
363
the patch passed

+1
compile
64
the patch passed

+1
javac
64
the patch passed

+1
checkstyle
111
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
346
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1110
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
41
the patch passed

+1
findbugs
312
the patch passed

_ Other Tests _

-1
unit
16550
hbase-server in the patch failed.

+1
asflicense
29
The patch does not generate ASF License warnings.

20717

Reason
Tests

Failed junit tests
hadoop.hbase.master.procedure.TestCreateTableProcedure

hadoop.hbase.client.TestAdmin2

hadoop.hbase.namespace.TestNamespaceAuditor

hadoop.hbase.master.procedure.TestDeleteTableProcedure

hadoop.hbase.master.procedure.TestCloneSnapshotProcedure

hadoop.hbase.master.assignment.TestOpenRegionProcedureHang

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/514

JIRA Issue
HBASE-22874

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux bbb935d9190e 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-514/out/precommit/personality/provided.sh

git revision
master / 1b50404f34

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/4/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/4/testReport/

Max. process+thread count
4938 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/4/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
67
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
354
master passed

+1
compile
109
master passed

+1
checkstyle
140
master passed

+1
shadedjars
449
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
101
master passed

0
spotbugs
504
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
500
master passed

_ Patch Compile Tests _

+1
mvninstall
487
the patch passed

+1
compile
137
the patch passed

+1
javac
137
the patch passed

+1
checkstyle
153
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
437
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
987
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
35
the patch passed

+1
findbugs
264
the patch passed

_ Other Tests _

-1
unit
19160
hbase-server in the patch failed.

+1
asflicense
30
The patch does not generate ASF License warnings.

23828

Reason
Tests

Failed junit tests
hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController

hadoop.hbase.master.procedure.TestSCPWithReplicas

hadoop.hbase.master.procedure.TestRestoreSnapshotProcedure

hadoop.hbase.replication.TestReplicationKillSlaveRSWithSeparateOldWALs

hadoop.hbase.client.TestAsyncTableAdminApi

hadoop.hbase.replication.TestReplicationSmallTestsSync

hadoop.hbase.tool.TestBulkLoadHFiles

hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated

hadoop.hbase.tool.TestSecureBulkLoadHFiles

hadoop.hbase.master.procedure.TestProcedurePriority

hadoop.hbase.client.TestAdmin

hadoop.hbase.client.TestSnapshotTemporaryDirectory

hadoop.hbase.util.TestFromClientSide3WoUnsafe

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/514

JIRA Issue
HBASE-22874

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 182c8059cd1f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-514/out/precommit/personality/provided.sh

git revision
master / b8857ec010

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/5/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/5/testReport/

Max. process+thread count
5054 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/5/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
83
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
371
master passed

+1
compile
61
master passed

+1
checkstyle
92
master passed

+1
shadedjars
313
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
43
master passed

0
spotbugs
280
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
278
master passed

_ Patch Compile Tests _

+1
mvninstall
342
the patch passed

+1
compile
59
the patch passed

+1
javac
59
the patch passed

+1
checkstyle
90
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
372
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1455
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
46
the patch passed

+1
findbugs
331
the patch passed

_ Other Tests _

-1
unit
17374
hbase-server in the patch failed.

+1
asflicense
31
The patch does not generate ASF License warnings.

21860

Reason
Tests

Failed junit tests
hadoop.hbase.master.procedure.TestTruncateTableProcedure

hadoop.hbase.util.TestFromClientSide3WoUnsafe

hadoop.hbase.master.TestMasterShutdown

Subsystem
Report/Notes

Docker
Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/514

JIRA Issue
HBASE-22874

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 20c8eb0853e4 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-514/out/precommit/personality/provided.sh

git revision
master / b8857ec010

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/6/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/6/testReport/

Max. process+thread count
4856 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/6/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
98
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
363
master passed

+1
compile
61
master passed

+1
checkstyle
93
master passed

+1
shadedjars
307
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
40
master passed

0
spotbugs
320
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
317
master passed

_ Patch Compile Tests _

+1
mvninstall
340
the patch passed

+1
compile
62
the patch passed

+1
javac
62
the patch passed

+1
checkstyle
89
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
308
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1053
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
37
the patch passed

+1
findbugs
315
the patch passed

_ Other Tests _

-1
unit
16475
hbase-server in the patch failed.

+1
asflicense
27
The patch does not generate ASF License warnings.

20401

Reason
Tests

Failed junit tests
hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint

hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated

hadoop.hbase.client.TestFromClientSideWithCoprocessor

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/514

JIRA Issue
HBASE-22874

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 0f9270ec2189 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-514/out/precommit/personality/provided.sh

git revision
master / 84ee378df1

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/7/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/7/testReport/

Max. process+thread count
4512 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/7/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
114
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
421
master passed

+1
compile
67
master passed

+1
checkstyle
93
master passed

+1
shadedjars
317
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
43
master passed

0
spotbugs
278
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
276
master passed

_ Patch Compile Tests _

+1
mvninstall
356
the patch passed

+1
compile
61
the patch passed

+1
javac
61
the patch passed

+1
checkstyle
89
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
302
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1051
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
36
the patch passed

+1
findbugs
279
the patch passed

_ Other Tests _

-1
unit
15605
hbase-server in the patch failed.

+1
asflicense
36
The patch does not generate ASF License warnings.

19554

Reason
Tests

Failed junit tests
hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster

hadoop.hbase.client.TestAsyncRegionAdminApi

hadoop.hbase.client.TestAsyncSnapshotAdminApi

hadoop.hbase.master.TestMasterShutdown

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/514

JIRA Issue
HBASE-22874

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 456f1567e49b 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-514/out/precommit/personality/provided.sh

git revision
master / b329bf0a57

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/8/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/8/testReport/

Max. process+thread count
4884 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/8/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

I'm going to close this first approach since it lacks what we need per the continued discussion on HBASE-22874 . I'm only doing this to avoid having the QA bot continue rebuilding the PR every time a commit lands on the target branch. Please continue discussion about needs on HBASE-22874 and let's start with a PR just for master to start dealing with implementation details and look at backports once we get that merged.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
150
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
480
master passed

+1
compile
75
master passed

+1
checkstyle
105
master passed

+1
shadedjars
396
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
53
master passed

0
spotbugs
334
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
332
master passed

_ Patch Compile Tests _

+1
mvninstall
474
the patch passed

+1
compile
79
the patch passed

+1
javac
79
the patch passed

+1
checkstyle
97
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
371
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1298
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
40
the patch passed

+1
findbugs
285
the patch passed

_ Other Tests _

-1
unit
15442
hbase-server in the patch failed.

+1
asflicense
29
The patch does not generate ASF License warnings.

20135

Reason
Tests

Failed junit tests
hadoop.hbase.quotas.TestQuotaAdmin

hadoop.hbase.master.procedure.TestSCPWithReplicas

hadoop.hbase.client.TestFromClientSide3

hadoop.hbase.master.TestMasterShutdown

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/514

JIRA Issue
HBASE-22874

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux e97660124e99 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-514/out/precommit/personality/provided.sh

git revision
master / 4268774de1

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/9/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/9/testReport/

Max. process+thread count
4789 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-514/9/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.


static handler needs to take abs path

ran into this trying to do a demo running the daemon out of a directory other than the src dir

There were the following issues with your Pull Request

Commit: 76e850e7054f27468405ee5393cd3083dfe64cf2
Commits must be in the following format: %{scope}: %{description}

This message was auto-generated by https://gitcop.com


Allow searching quotes

Add a --search flags that will filter quotes by search term before printing one random quote.

Already supported.