Branch: Quicklogic : Multiplier primitive instance should be qlal4s3_mult_cell_macro

Multiplier primitive instance should be qlal4s3_mult_cell_macro, so the black box instance should be the following in cells_sim.v file:
(* blackbox *)
module qlal4s3_mult_cell_macro (
input [31:0] Amult,
input [31:0] Bmult,
input [1:0] Valid_mult,
input sel_mul_32x32,
output [63:0] Cmult );
endmodule
User should be configuring the multiplier into x32 or x16 and should be connecting the signals appropriately.
Attached the primitive files ( cells_sim.v  & cells_map.v) , design example (rtl) and EDIF file for reference.
Multipliers.zip

The multiplier is added to Yosys and will soon be released on Github

The multiplier is released

@rakeshm75 all the mults macros are also supported in arch-defs

@kgugala, I have pulled the latest code. When I run the design with multiplier, I get the following error:
25.2.2. Analyzing design hierarchy..
ERROR: Module \qlal4s3_mult_cell_macro' referenced in module \AL4S3B_FPGA_IP' in cell `\u_qlal4s3_mult_cell_macro' is not part of the design.
make[3]: *** [quicklogic/tests/quicklogic_testsuite/design3/design3-ql-chandalar/ql-s3-ql-eos-s3-virt-ql-eos-s3-wlcsp/top_synth.json] Error 1
make[2]: *** [quicklogic/tests/quicklogic_testsuite/design3/CMakeFiles/file_quicklogic_tests_quicklogic_testsuite_design3_design3-ql-chandalar_ql-s3-ql-eos-s3-virt-ql-eos-s3-wlcsp_top.eblif.dir/all] Error 2
make[1]: *** [quicklogic/tests/quicklogic_testsuite/design3/CMakeFiles/design3-ql-chandalar_jlink.dir/rule] Error 2
make: *** [quicklogic/tests/quicklogic_testsuite/design3/CMakeFiles/design3-ql-chandalar_jlink.dir/rule] Error 2
design3.zip

hi @rakeshm75 I added your test to arch-defs repository https://github.com/antmicro/symbiflow-arch-defs/commit/7670933dfefc9237b050ad1fe231f5b38810f1ac
I ran it and it passes to the bitstream. It looks like you don't have the latest Yosys code. Support for the qlal4s3_mult_cell_macro cell has been added in this commit https://github.com/antmicro/yosys/commit/8d691b63910b2e81506c2201d496aaa41ea47577
There is one more issue with the design you attached - it get almost entirely optimized out during synthesis.

Hi Karol,
Its the same design which I had filed issue with Yosys that it optimizes the design completely.
The issue number #63 (https://github.com/SymbiFlow/yosys/issues/63). It was fixed and I could run the design on Yosys, create edif and run through SpDE tool. I have attached the EDF file created by Yosys and Precision for your reference.
We should have only qlal4s3_mult_cell_macro multiplier primitive not qlal4s3_mult_32x32_cell nor qlal4s3_mult_16x16_cell. 32x32 or 16x16 multiplier should be built from the base qlal4s3_mult_cell_macro.
(* blackbox *)
module qlal4s3_mult_cell_macro (
input [31:0] Amult,
input [31:0] Bmult,
input [1:0] Valid_mult,
input sel_mul_32x32,
output [63:0] Cmult );
endmodule
design3_EDF.zip


allow customizable caching permissions

This PR allows deployments to restrict access to the cache with their custom logic by extending the new SupersetSecurityManager
@mistercrunch @john-bodley
cc @fabianmenges I remember George Siros also expressing interest in this functionality.

Codecov Report

Merging #4704 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4704      +/-   ##
==========================================
+ Coverage   71.56%   71.57%   +<.01%
==========================================
  Files         191      191
  Lines       14958    14961       +3
  Branches     1100     1100
==========================================
+ Hits        10705    10708       +3
  Misses       4250     4250
  Partials        3        3

Impacted Files
Coverage Δ

superset/security.py
74.47% <100%> (+0.26%)
:arrow_up:

superset/viz.py
79.63% <100%> (+0.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e1b6b7...4f2269d. Read the comment docs.

I think this results in double-checking the permission at the moment, which is an extra database round trip. I'm not sure how efficient it is either for non-all-datasource-access roles, meaning we'd pay a relatively expensive cost twice.
Currently the view is in charge of doing data access checks. Since the auth scheme here is a FAB (web framework) construct, it could be good to keep those check shallow in the stack, meaning in the view layer.
Curious to understand your use case and how the check on cache would differ from the datasource check.

@fabianmenges option 2 is what we're thinking. I made a note which describes how we could bypass double-checking the datasource permissions by default.

Why late-checking deep in the code as opposed to in the view layer?

I thought about this some more. you're right. With the new approach we are taking now, anyone who can access the datasource can access the cache. I'll go ahead to close this PR.


Middleware not working with route binding

Please excuse me if this is a misunderstanding on my part - I've tried applying the middleware in a few different ways, but am having some issues getting it to work successfully with route binding with models.
For example (imagine item ID 123 is a draft):
Route::withDrafts(function (): void {
    Route::get('/item/{item}', function() {
        dd(Item::find(123));
    });
});

This works fine. However, something along the lines of:
Route::withDrafts(function (): void {
    Route::get('/item/{item}', ItemController::class, 'edit');
});

...

class ItemController {
    public function edit(Item $item)
    {
         dd($item);
    }
}

results in a 404. Setting the is_published field to 1 on the item in question allows the page to load, so the route works, it just isn't obeying the middleware and including drafts when binding the item model.

Looks to have been a middleware priority issue. Fixed in latest version.


Home Screen

After successful login the user should land on their home screen.  This should be a browseable screen of the content they have available to them in their library.
Some content could be:

Available CategoriesC* Available Movies
Available TV Shows
Latest Movies
Latest TV Shows
Continue Watching
Genres
Next Up - If a TV Show has more than one episode, suggest the next episode
You might like - a suggested list of shows or movies from their library.

There should be a way to access Search functionality.
Switch current User (this will take back to user selection).
If more than one Server, away to switch servers (will take back to server selection screen).
Clicking on the Movies will take the user to the Movie Browser screen.
Clicking on TV Shows will take the user to the TV Shows Browser screen
All content needs to be able to be easily browser with a Directional Pad (remote control, game pad).   It should be fairly easy to get to content with a minimum set of clicks.
Clicking on a Latest Movie or TV show will take the user to the detail info about that Movie or TV Show.
Clicking on a movie or episode in continue watching, starts playback of that show from

https://www.egeniq.com/blog/developing-android-tv-keeping-focused
Tab bar has moved to the top of the screen, so the above link has some useful suggestions around RowsFragment usage.

All the major features for this screen are now implemented.


Getting current block height in a Cadence script on the archive node panics the  FVM

Running the following Cadence script panics the FVM
getCurrentBlock().height

Thanks for the report @cybercent, we will look into this. In the meantime, do you happen to still have the full stack trace of the error you experienced when running the script? Thanks.


How to handle AR migrations?

Say I have a User model:
class User < ActiveRecord::Base
  include Tenacity
  t_has_many :posts
end

And a post model:
class Post
  include Mongoid::Document
  include Tenacity

  field :title

  t_belongs_to :user
end

If I try to migrate the User model Tenacity will raise an error cause the User table doesn't yet exist.
How would you tackle this?

Hi,
Sorry, but I'm unable to reproduce this error.  I created User and Post models with the code you listed.  I also created a migration:
class CreateUsers < ActiveRecord::Migration
  def change
    create_table :users do |t|
      t.integer :post_id

      t.timestamps
    end
  end
end

I was able to run the migration, and the users table was created successfully.  I tested this using sqlite and mysql.
Here are the versions of the libraries I'm using:
rails 3.1
mongoid 2.2.3
tenacity 0.5.2
What versions of these libraries are you using?

Also, what is the exact error that Tenacity is raising?  It may help be track down what is going on.
On a side note, in one day I'll be leaving on vacation.  So, if you don't hear back from me, please don't think I'm ignoring you.  I'll replay when I return.

Hi.
Thanks for replying.
Seems to be this relation that is raising the problem, since it's trying to show fields from a non existing table:
t_belongs_to :user

That's causing the problem. When I try to migrate with:
rake db:migrate

Mysql2::Error: Table 'xxx.users' doesn't exist: SHOW FIELDS FROM `users`

If I uncomment t_belongs_to it works without errors.
mongoid 2.2.3 with rails 3.1

Can you please run rake db:migrate --trace and send me the output?

Mysql2::Error: Table 'xxxxx.users' doesn't exist: SHOW FIELDS FROM `users`
/Users/yeggeps/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/activerecord-3.1.1/lib/active_record/connection_adapters/mysql2_adapter.rb:283:in `query'
/Users/yeggeps/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/activerecord-3.1.1/lib/active_record/connection_adapters/mysql2_adapter.rb:283:in `block in execute'
/Users/yeggeps/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/activerecord-3.1.1/lib/active_record/connection_adapters/abstract_adapter.rb:244:in `block in log'
/Users/yeggeps/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/activesupport-3.1.1/lib/active_support/notifications/instrumenter.rb:21:in `instrument'
/Users/yeggeps/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/activerecord-3.1.1/lib/active_record/connection_adapters/abstract_adapter.rb:239:in `log'
/Users/yeggeps/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/activerecord-3.1.1/lib/active_record/connection_adapters/mysql2_adapter.rb:283:in `execute'
/Users/yeggeps/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/activerecord-3.1.1/lib/active_record/connection_adapters/mysql2_adapter.rb:473:in `columns'
/Users/yeggeps/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/activerecord-3.1.1/lib/active_record/connection_adapters/abstract/connection_pool.rb:95:in `block (2 levels) in initialize'
/Users/yeggeps/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/activerecord-3.1.1/lib/active_record/connection_adapters/abstract/connection_pool.rb:185:in `with_connection'
/Users/yeggeps/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/activerecord-3.1.1/lib/active_record/connection_adapters/abstract/connection_pool.rb:92:in `block in initialize'
/Users/yeggeps/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/activerecord-3.1.1/lib/active_record/base.rb:712:in `yield'
/Users/yeggeps/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/activerecord-3.1.1/lib/active_record/base.rb:712:in `default'
/Users/yeggeps/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/activerecord-3.1.1/lib/active_record/base.rb:712:in `columns'
/Users/yeggeps/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/tenacity-0.5.2/lib/tenacity/orm_ext/activerecord.rb:52:in `_t_id_type'
/Users/yeggeps/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/tenacity-0.5.2/lib/tenacity/orm_ext/helpers.rb:9:in `id_class_for'
/Users/yeggeps/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/tenacity-0.5.2/lib/tenacity/orm_ext/mongoid.rb:94:in `_t_initialize_belongs_to_association'
/Users/yeggeps/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/tenacity-0.5.2/lib/tenacity/associations/belongs_to.rb:32:in `initialize_belongs_to_association'
/Users/yeggeps/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/tenacity-0.5.2/lib/tenacity/class_methods.rb:274:in `t_belongs_to'

Ah, cool, thanks man!
Have a great vacation!

Having also just come across this issue, for the moment I'm just running with a monkey patch until you get a chance to update:
RAILS_ROOT/config/initializers/patch_tenacity_table_missing.rb:
#https://github.com/jwood/tenacity/issues/31
Tenacity::OrmExt::ActiveRecord::ClassMethods.class_eval do
  def t_id_type
    @_t_id_type_clazz ||= begin
      Kernel.const_get(columns.find { |x| x.primary }.type.to_s.capitalize)
    rescue
      Integer
    end
  end
end

This is fixed in version 0.5.3


💔crash : totaltypescript

the total typescript site

this is a page that has code editor playground, and it broke if steal the word is running 😥
this is the error message:
DOMException: Failed to execute 'insertBefore' on 'Node': The node before which the new node is to be inserted is not a child of this node.

maybe i'll build a list of site urls that Steal the Word make devastating bug on it. i don't know if this is better.


Indefinitely long duration

Is there a way to make pysine play this wave for an infinitely long duration until a trigger. Since I do not know the end time.
Any help is appreciated.

Does this example help?
import pysine

def trigger():
    """ Example trigger function

        returns true if the number of seconds since 1970 divides by 3 """
    import time
    # round current time to seconds and check if it is divisible by three
    if round(time.time()) % 3 == 0:
        return True
    else:
        return False

while not trigger():
    pysine.sine(frequency=400, duration = 0.01)

otherwise, what kind of trigger do you have to stop the sound?


Remove unused dependencies from release

I remember doing a review on this at one point-- I think its done.


stats_sysstat daemonset pods only coming up in namespace kube-system

Ideally, I'd like all pods created by this tool to come up in one namespace, created during a run, so that cleanup is easier and there is less chance of affecting another project.
Currently pods created by the role stats_sysstat are only coming up when namespace specified is kube-system. Testing so far has been limited to openshift 4.2.

This issue gets solved with the right role and role binding. Fix in progress.

fixed with commit c2820e3fb16f9c8e9cacf0b2162b3a073817b753


Fork from Conda Forge

Upstream
Changelog
Actions

Fork from Conda Forge
Reset build number
Linter fixes

Notes

I accidentally pushed my changes to main at first. I think I've done what I need to revert it, but I'm still unable to see the differences between my branch and main.

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_d84jsodykb/clone/recipe/meta.yaml:20: missing_hash: The recipe is missing a sha256 checksum for a source file
ERROR: /tmp/abs_d84jsodykb/clone/recipe/meta.yaml:20: missing_source: The recipe is missing a URL for the source
ERROR: /tmp/abs_d84jsodykb/clone/recipe/meta.yaml:30: patch_must_be_in_build: patch must be in build when source/patches is set.
Errors were found

@SC426 we can't view the changes because the last commit on your branch is the revert commit.


Cancel CI that is not the latest commit on a branch

Ported from https://github.com/canonical/mysql-operator/pull/134

Like with the bundle, there's another cham on edge for postgresql VM.

Legacy relations are borked, but that's not a fault with the PR. I propose to merge and fix the issues separately.


readCharacteristic() doesn't return fail callback

When I call readCharacteristic()  on a peripheral implementing PASSKEY security, Android often doesn't ask for passkey.
So readCharacterstic failed but neither success nor error callback are called.
However, using logcat, I can see that the API returns GATT_INSUFFICIENT_AUTHENTICATION (status = 5)
D/BluetoothGatt(23821): onCharacteristicRead() - Device=FD:8B:BA:4B:1D:27 UUID=f3851521-5942-b2cb-ae40-271cd0dd17e5 Status=0

I think this a bug in Android; my handler calls the error callback when it gets any status except SUCCESS.

On second thought, we might add a timeout of our own. Wouldn't report the proper error code, but at least it would report some error.

There is now support for explicit paring/bonding in the BLE plugin, that should help with this issue.
There are however reports of that this works a bit unstable, not sure if this is the plugin or the Android implementation. See this issue: https://github.com/evothings/cordova-ble/issues/129
Closing this issue, let me know if to reopen.


Added an option to control processing jobs with no queue name set

What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds an internal flag to control whether or not the job-controller reconciles jobs with no queue name set; by default those jobs are not processed.
This is important so users are not surprised that their existing running jobs get suspended when they first try Kueue.
This flag will be exposed to be configurable via ComponentConfig once we add it.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:

Wait, I see the option, but I don't see the command line flag for it.

No command-line flag, this is an option in the controller that we will expose via Component Config. I don't want to add a flag just so we deprecate it right away. I will send a PR after this one for CC, it is not that complicated.

/hold cancel


Excluded subnets for Deny Subnets without NSG

Describe the bug
As per Issue 38 in the Terraform module, the "Deny Subnets without NSG" policy currently doesn't allow for networks needing subnets for internal services which do not support NSGs, such as GatewaySubnet, AzureFirewallSubnet, and AzureFirewallManagementSubnet.
Steps to reproduce

Create a virtual network
Assign the policy
Try to create one of the subnets which do not support NSGs

@jtracey93 - would you mind taking a look at this one as well since it is very similar to the UDR one?


upgrades rspec to 2.99

fixes ActiveRecord code loading issues (tested on rails 4.2)
upgrades gemspec dependency to rails 4.2

:+1:


Which files/folders to backup in order to be able to migrate docker deployment to another server?

Topic
Docker setup, Backup, Maintenance
Question
I am new to Richie. I started using the docker deployment to experiment with hosting a couple of online courses and I would like to keep a backup of whatever data I create in Richie. My goal is to be able to restore it to another server if it's ever needed.
I am not a docker-compose expert but as far as I can tell, the only volumes being mounted are from /data. Does that include everything that is persisted to disk by the postgres, mysql, elasticsearch containers? Is it sufficient to backup everything under the /data directory?

Yes! And inside the /data directory, only the /media directory is related to what you created. Files in the static directory are collected from the source code.
You also need to backup your database, either postgresql or mysql depending on which one you chose. It's either one, not both.
Everything indexed in Elasticsearch comes from postgresql (resp. Mysql) and can be recreated at anytime by running the bootstrap_elasticsearch command.


Publishing a form does not show the success screen

Description
Deleting a form should show the success/error screen but on publishing shows the edit screen.
Steps to reproduce

Go to a form ready to publish
Click on publish
The form is put back into edit mode

Expected behaviour
The success screen is displayed
Screenshots or videos
https://github.com/cds-snc/platform-forms-client/assets/107579368/f1453fdf-e05e-4f70-811f-aba05844be1d

Ref: https://github.com/cds-snc/platform-forms-client/pull/3218


Rewrite Swift For TensorFlow random number generation.

We break the PRNG library into engines for generating random bytes and distributions for using engines to produce numbers that fit some statistical distribution.
We modify Tensor to use this new version and remove the RandomState class from Utility.

@swift-ci please test tensorflow

@swift-ci Please test tensorflow

I'm not too involved in the tensorflow project, but is there a reason why you didn't just build on top of SE-0202? See: Random.swift. That way you can achieve things like let randomFloat = Tensor<Float>(.random(in: 0 ..< 1, using: &arc4)) no? (Or whatever syntax you would like to introduce).

@Azoy Thanks for bringing up SE-202!
An important requirement for RNGs in machine learning is seedability, which is why we initially pursued our own seedable RNG implementation. (This is sort of at-odds with arc4random() on macOS, which is focused on security and isn't really seedable AFAIK.)
I think conforming the various RNGs in this PR to RandomNumberGenerator is pretty sensible.
The Tensor random initializers can take an optional RandomNumberGenerator:
init(randomUniform shape: TensorShape, generator: RandomNumberGenerator? = nil) {
  let generator = generator ?? ARC4RandomGenerator.global
  // ...
}

@rxwei: what do you think about this design?

Thanks for the comment, @Azoy
As @dan-zheng describes, the design here is intended to make sure that random streams are reproducible, which is a useful property for experimentation. I agree with his proposal to reuse the RandomNumberGenerator protocol and it will simplify this PR, so thanks for the tip.

I understand about reproducibility, I was thinking along the lines of:
public protocol SeeadableRNG: RandomNumberGenerator {
  init(seed: [UInt8])
  init<T: BinaryInteger>(seed: T)
}

so that any custom generator tensorflow may need can take advantage of the stdlib provided facilities such as random ints/floats/bools, random element from collection, shuffling, etc.

Exactly — the uniform and normal distributions would be useful for all users of Swift, as would as a sendable ARC4Random implementation, so it would be great if they could participate in the RandomNumberGenerator design. Thanks!

The SeedableRNG protocol proposal makes a lot of sense. I'll modify this PR to do that.
I would be interested in adding to the RandomNumberGenerator design, if that makes sense, though I would prefer to get the changes into the TF branch sooner, as they are required for some other work.

Have addressed everyone's comments.
Only large-ish change is adding the restriction: where T.RawSignificand : FixedWidthInteger which means we can use T.random(in: using:) to do some of the generation as recommended by @natecook1000

@swift-ci please test tensorflow

@swift-ci please clean test tensorflow

@swift-ci please clean test tensorflow

@swift-ci please clean test tensorflow

@swift-ci please clean test tensorflow

@jtkeeling James, you can drop all _TFHoistable for now to unblock this patch and further progress. We'll develop a fix for _TFHoistable.

@jtkeeling James, do you still plan to merge this patch?

@rxwei Yes - will try to do today. Ran into some issues due to the _TFHoistable issues, but should be sorted now.

@rxwei I've synced this and tested it as follows:

Running the tests
Running the MNIST example with [randomNormal, randomUniform] x [optimization on, optimization off]

So I'm confident the issues with _TFHoistable are now fixed.
Could you do the merge for me? Thanks!

@swift-ci please test tensorflow

@swift-ci please test tensorflow

Thanks, James. Looks great!


Auto Video compression Method not working getting "Native module not found" error

Auto Video compression Method not working getting "Native module not found"  error
Video compression working with this version:
"react": "17.0.1",
"react-native": "0.64.2",
"react-native-compressor": "^0.5.3",
Video compression not working with this version:
"react": "17.0.2",
"react-native": "0.66.1",
"react-native-compressor": "^1.1.1"
This is the code which we are using:
await Video.compress(filePath,
                { compressionMethod: 'auto' },
                (progress) => { isCompress = true }
            ).then((path) => {
                console.log(path, 'compressed path');

            }).catch((err) => { alert("err: "+err); })

Attached the error screenshot also:

@workhexaloop you can install react-native-get-random-values manually and check
yarn add yarn add react-native-get-random-values

Thanks @nomi9995 its working now.


GL queries statistic fixes

Description
A few errors that I noticed while running this on Mesa/Linux.

All the issues you pointed should be addressed.

Thanks, looks good. The mac build failure seems like unfortunately something on travis failed since last time it compiled the main branch. I'm going to see if I can sort that out, but if everything else goes green I'll merge this in.


pid to pwm

Hi
I caught my attention while browsing through scripts. You input rpm type value in pid and send the output value directly to the motor as pwm. how did covert this? I didn't understand.

It’s because the PID’s output will keep changing the value (motor PWM input) based on the error in the encoder until it reaches the target RPM. You can convert it to PWM value by using the CALCULATED_RPM / MAX_RPM * 255 but the behaviour will be the same.

thank you for answer.


k8s: Make node-name obtention more robust

~Align with kubernetes on how the system uuid is obtained~
Base node-name obtention on the hostname instead of the system uuid (which can be hard to find and may not be unique per machine).
Fall back to report all pods (printing a warning) if the node name cannot be obtained

Fixes #2049

@errordeveloper Mind testing if the fix works in katacoda?
@paulbellamy Mind reviewing?

We know from weaveworks/weave#2427 that the product_uuid, which is the first thing GetSystemUUID() returns if present, is the same across many machines on some popular hosting providers. How do k8s and scope cope with that?

We know from weaveworks/weave#2427 that the product_uuid, which is the first thing GetSystemUUID() returns if present, is the same across many machines on some popular hosting providers.

Great point

How do k8s and scope cope with that?

TLDR: In the case of Scope, badly
We use the uuid to obtain the current node name and, in turn, to filter out pods not scheduled in the current machine.
If the uuids are not unique then the machine name obtention will likely be wrong and/or duplicated which may cause us to miss pods.
e.g:
probe1 runs in a machine with uuid "foo" and node-name "A"
probe2 runs in a machine with uuid "foo" node-name "B"
When obtaining the node-name both probe1 and probe2 obtain node-name "A" (because of the searching order)
Result: both probe1 and probe2 report the pods scheduled in node "A" and the pods from node "B" are never reported.
I need to think about how to solve this. In the worse case scenario we can report all pods from all probes (which is what we do on ECS) if the performance impact is not too high.

It seems the nodes have a kubernetes.io/hostname label, which I can match against the hostname and obtain the node name from there.
http://stackoverflow.com/a/35022237/1914440
It seems it was called hostname in the past, so I will have to query that too.

Done. @paulbellamy PTAL

I don't have any concrete concerns, hostname just seems less unique than a uuid, but apparently some hosting services scupper that anyway. vagrant, web1, web2, db1, being examples of fairly non-unique hostnames.
As a side note, I thought checkpoint wrote some random data into a file on first launch to uniquely identify a host. but maybe that was a previous version
But, checkpoint has to uniquely id a host in the whole planet, scope just needs to be unique within scope's view, so I don't think this is an issue.

After @paulbellamy's comment I am considering to revert de224e5
@rade thoughts?

I don't understand what problem this is actually trying to solve. Obtaining a unique id for every node in a cluster? That is precisely the problem we had to tackle in Weave Net.

It seems there is more to than just unique IDs though. You write

We use the uuid to obtain the current node name and, in turn, to filter out pods not scheduled in the current machine.

which suggests that the ID information is somehow correlated with info provided by k8s.

Obtaining a unique id for every node in a cluster?

No, we are trying to identify the pods scheduled in the current node (to avoid reporting all pods from all nodes). For that we are using the pods' nodename.
The problem is obtaining the nodename. For that, we are obtaining the metadata from all the k8s nodes and narrow it down by checking against known metadata unique to the current node. So far we have tried the system uuid and the hostname but they don't seem to really be unique.

The question we are trying to answer here is "what pods are running on this node?" Correct? So the challenge here then is to construct some form of id from the information we can obtain from the host itself, that in turn can be matched to an id obtained from the meta data associated with a pod. Yes?

Yes, see above.

How does k8s come up with the nodename? Surely we should just do the same?

Surely we should just do the same?

Let me try to figure this out.

OK, it doesn't seem easy. Apparently it depends on the cloud provider, and in order to obtain it you may need cloud-provider credentials :S
See https://github.com/kubernetes/kubernetes/blob/2df5d4d980e8a6692b00f9ced2a23b8dd5f26bdf/pkg/kubelet/kubelet.go#L298-L313 and https://github.com/kubernetes/kubernetes/blob/ee49906c45171b1da354910bce4f4ed2095dd0d4/cmd/kubelet/app/server.go#L183-L206

Could we ask the kubelet on the node?

Here's an idea. Instead of assuming the uuids are unique, we verify it in the node list. If they are, we use the uuid. If not, we report all the pods.

Could we ask the kubelet on the node?

Unfortunately it doesn't provide the NodeName, see https://github.com/weaveworks/scope/issues/2049#issuecomment-271882200

So what we are trying to do here cannot be done?

But ... kubelet seems to expose http://localhost:10255/pods/, so we can obtain the pods from there.

Overridden by #2132


Where to ask architecture based questions?

I am sorry for possibly posting this at the wrong place. I would like to extend vscode, however I have a few questions related to its architecture. Do you guys have a slack or similar soft Q-A account? Stackoverflow is very strict on asking soft questions without well defined answers which is why I have come here.
I specifically want to know the way intellisense provides suggestions, and which files I should be interested in.

@Alanz2223 please ask here.
I assume that you have seen the section CompletionItemProvider in https://code.visualstudio.com/docs/extensionAPI/vscode-api

I have reviewed it but did not find anything relating to parameter hints. Do you know how comments have to be formatted so that they will appear when a suggestion is highlighted?
https://code.visualstudio.com/docs/editor/editingevolved#_parameter-hints

@Alanz2223 as an extension writer you can register a SignatureHelpProvider. They are responsible for showing the parameter hints.
That best way to deeply explore our API is to look at vscode.d.ts either in github or in the workspace you use to develop your extension. If you generated your extension with yeoman, you can find the file in node_modules/vscode.


Increment Version

@JuliaRegistrator register() UtilityModels v0.2.0

Registration pull request created: JuliaRegistries/General/29866
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.0 -m "<description of version>" 276af51ea7a29cd9ba59fe8a707b8526fbed3b6b
git push origin v0.2.0


[aes:dv] added functionality to aes DV

These commits contain a fairly large update to DV with manual mode added,
also the interleaving of data/iv/key is added.
also added a mode where reads and writes to DUT is split into parallel processes such that the arbitration is done by the sequencer and timing is less predictable (write/read/write/read ) sequential mode is still an option.
the aes_stress test is failing for some seeds which is being debugged.
but I want to get this in as more changes to AES is coming.

Closing this PR as @rswarbrick points out there are obvious issues here.
Sorry for not being more diligent


SolrJ extension for SolrTextTagger

Hi all,
Not really an issue, but I wanted to let you know that I implemented SolrParams, SolrRequest and SolrResponse specific for the SolrTextTagger.
The module is available at https://github.com/redlink-gmbh/solrj-text-tagger/
I plan to make it available at Maven Central in the coming days.
Feedback welcome!
best
Westei

Very cool!  After we switch to Java 8 (which I see this code requires as it uses .stream()), what do you think of providing this code with the text tagger?  It would probably result in another module but I think that's better than separate projects altogether.

I should definitely be an own module (as it only depends on SolrJ and does not have a direct dependency to the SolrTextTagger module. I have no problem of managing it at the above location, but maybe SolrTextTagger user will more likely find it when it is made available under the same groupId as the solr-text-tagger.
Regarding Java 8: I was in the impression that Solr 6 requires Java 8. In SolrJ they renamed some of the main classes with Solr 6. So to support older Java versions one would need to provide two separate releases (one for SolrJ 6 and SolrJ 5)

I just released 2.3 and bumped the tagger to Solr 6 and Java 8.
Yes, Solr 6 requires Java 8.
Feel free to send a pull request for this contribution.  Perhaps the SolrJ module can be a child of the existing one, without having to move the current code to a new subdirectory -- that'd be nice.

Now that Solr 7.4.0 includes the tagger, perhaps you might want to propose your addition directly to Apache Solr / SolrJ.


Integration update

If you're adding a new rule, please follow these steps.

Codecov Report

Merging #294 (e312b31) into main (bb04468) will decrease coverage by 0.03%.
The diff coverage is 99.75%.

@@            Coverage Diff             @@
##             main     #294      +/-   ##
==========================================
- Coverage   99.93%   99.89%   -0.04%
==========================================
  Files         146      155       +9
  Lines        4640     4840     +200
==========================================
+ Hits         4637     4835     +198
- Misses          3        5       +2

Impacted Files
Coverage Δ

rules/expiring-todo-comments.js
100.00% <ø> (ø)

rules/fix/index.js
100.00% <ø> (ø)

rules/no-unused-properties.js
100.00% <ø> (ø)

rules/prefer-string-slice.js
100.00% <ø> (ø)

rules/selectors/index.js
100.00% <ø> (ø)

rules/utils/parentheses.js
100.00% <ø> (ø)

rules/utils/needs-semicolon.js
94.44% <85.71%> (-5.56%)
:arrow_down:

index.js
100.00% <100.00%> (ø)

rules/better-regex.js
100.00% <100.00%> (ø)

rules/catch-error-name.js
100.00% <100.00%> (ø)

... and 114 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb04468...e312b31. Read the comment docs.


Record Level Permissions (Graylog Support?)

Is your feature request related to a problem? Please describe.
We are using Graylog in its open source version with an open search backend. For easy scalability on affordable storage Quickwit would be a good alternative. Replacing Graylog entirely with Quickwit is missing permissions at the moment (Have a user only see records with certain field values that is).
Describe the solution you'd like
Either

find some way of limited access to records by user or
support Graylog as a frontend so it handles user permissions. Since Graylog does alerting as well and is configured already this approach is preferred.

Describe alternatives you've considered

Grafana as far as I can see would not support record level permissions but only limiting access to data sources entirely. But this only applies for enterprise versions of Grafana.
starting up Graylog targeting it to Quickwit as a storage returns version errors.
similar to the previous one OpenSearch Dashboard does not even start up. If it would it likely does not provide the permission feature on its own.

Additional context
I have seen some mentions of tenants in the documentation but no way of utilizing it as a permission tool inside Quickwit directly. Our Idea is having a single scalable system used by many users / teams to send there application logs to. This entails potentially sensitive data and therefore has to be protected against leakage.

Thanks, @scMarkus, for reporting this. Supporting GrayLog would be awesome, would love to have a quick chat with you to see how we can do this, you can join our discord server and ping me (@fmassot)


ehcache 3 kit structure and content work.

Ehcache kit needs a README.txt file that is relevant to it - including pointing out where to find docs and samples.
Also it needs to include enough info in the 'legal' folder to help users sort out what is licensed which way.

The idea is that these contents would get "merged over" the contents of the terracotta-kit  contents.

All this content should go under clustered/clustered-dist and indeed src/assemble might be a good location.

I haven't yet added any maven-related work - hoping akomakom can help with that.

well ... no maven here 😉


Example Dockerfile

For anybody in need to run this in Docker, this example Dockerfile could be helpful:
FROM ubuntu:16.04
# Using Ubuntu here because of better latex support

WORKDIR /app

# Install needed stuff
RUN apt-get update && \
    apt-get -y install golang-go git && \
    apt-get -y install texlive-latex-base texlive-fonts-recommended texlive-fonts-extra texlive-latex-extra && \
    rm -r /var/lib/apt/lists/*

# Prepare go
ENV GOPATH=/app/gopath
RUN mkdir gopath

# Testing needed binaries
#RUN pdflatex --version
#RUN go --version

# Install from github
RUN go get github.com/izakmarais/reporter/... && \
    GOBIN=/usr/local/bin/ go install -v github.com/izakmarais/reporter/cmd/grafana-reporter

# Testing compiled binary
#RUN grafana-reporter --help

EXPOSE 8686

CMD [ "grafana-reporter", "-ip", "host-where-grafana-is-accessable:3000" ]

Thanks for this.
I plan on merging https://github.com/IzakMarais/reporter/pull/26, which does also provide a docker option.


SCRUM-1825

Thanks for explaining and updating things, @ianlongden .
"Yes, we probably need an update for the props. Also a delete."
Ah, okay, I was thinking it'd be better to keep standard with a full CRUD, so we could directly create a topic_entity_tag_prop through its own create endpoint instead of having to patch it through the related topic_entity_tag object it connects to.  I can see that it would work both ways, and it's redundant to add the Create _prop router, but it makes the logic more standard, because when creating other objects that connect to reference, we create them through their create/POST endpoint, instead of thinking about its parent and patching that.

topic still doesn't show on reference GET https://dev4003-literature-rest.alliancegenome.org/reference/AGR:AGR-Reference-0000000001  Also doesn't show in swagger schema for POST / PATCH
topic_entity_tag POST works with and without props, but patch to add qualifiers doesn't with 500 error (works to patch without props)
{
"note": "a note",
"props": [ { "qualifier": "ATP:qualifier1" } ]
}
/topic_entity_tag_prop/{topic_entity_tag_prop_id}  PATCH  schema example has
{
"qualifier": "string",
"topic_entity_tag_prop_id": 0
}
with topic_entity_tag_prop_id instead of topic_entity_tag_id
Trying to patch it with topic_entity_tag_prop_id 1 in the endpoint and passing
{
"qualifier": "patch prop through PATCH",
"topic_entity_tag_id": 2
}
gives a 202 success, but does not update the value


database insertion errors are not thrown

When running ingestion pipeline, if there are any database insertion errors w/ PgVector, the error is not propgated up the stack.
const vectorStore = yield* Effect.sync(() =>
    new PGVectorStore({
      dimensions: 512,
      connectionString: DATABASE_URL,
    })
  )
 const pipeline = yield* Effect.sync(() =>
  new IngestionPipeline({
    transformations: [
      new OpenAIEmbedding({ dimensions: 512, model: 'text-embedding-3-small' }),
    ],
    vectorStore,
  })
)
yield* Effect.tryPromise(() => pipeline.run({ documents }))

Its just logged to the console
https://github.com/run-llama/LlamaIndexTS/blob/11b385633495456cba4c63c926018a37d200b18c/packages/llamaindex/src/storage/vectorStore/PGVectorStore.ts#L226

It should also upsert something like this...
  async add(embeddingResults: BaseNode<Metadata>[]): Promise<string[]> {
    if (embeddingResults.length == 0) {
      console.debug('Empty list sent to PGVectorStore::add')
      return []
    }

    const sql: string = `
      INSERT INTO ${this.schemaName}.${this.tableName}
        (id, external_id, collection, document, metadata, embeddings)
      VALUES ($1, $2, $3, $4, $5, $6)
      ON CONFLICT (id) DO UPDATE SET
        external_id = EXCLUDED.external_id,
        collection = EXCLUDED.collection,
        document = EXCLUDED.document,
        metadata = EXCLUDED.metadata,
        embeddings = EXCLUDED.embeddings
      RETURNING id
    `

    const db = await this.getDb()
    const data = this.getDataToInsert(embeddingResults)

    const ret: string[] = []
    for (const params of data) {
      const result = await db.query(sql, params)
      if (result.rows.length) {
        const id = result.rows[0].id as string
        ret.push(id)
      }
    }

    return ret
  }

How about one add call is seen as a transaction? If that fails, it throws an error and rollbacks to everything before the add call?
If you like the idea, it would be great if you can help with a PR

How about one add call is seen as a transaction? If that fails, it throws an error and rollbacks to everything before the add call? If you like the idea, it would be great if you can help with a PR

https://github.com/run-llama/LlamaIndexTS/issues/1153

I add the transaction but i dont think its strictly necessary since the INSERT call is one statement and if it fails they all fail


[Flash Enc] esp32s3 "invalid header: 0x8511cbdd" after enabling flash encryption (IDFGH-12327)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
I'm not sure how I broke my code. Looking for advice.
I have code that burns my device
espefuse.py --port /dev/cu.usbmodem2101 burn_key BLOCK5 /temp/flash-enc-key.bin.aa XTS_AES_256_KEY_1 --do-not-confirm

espefuse.py --port /dev/cu.usbmodem2101 burn_key BLOCK6 /temp/flash-enc-key.bin.ab XTS_AES_256_KEY_2 --do-not-confirm

espefuse.py --port /dev/cu.usbmodem2101 burn_efuse SPI_BOOT_CRYPT_CNT 7 --do-not-confirm

and code to encrypt the binary:
espsecure.py encrypt_flash_data --aes_xts --keyfile /temp/flash-enc-key.bin --address 0x300000 --output jJfwmApp.bin.enc jJfwmApp.bin

and code to flash the firmware
esptool.py --port /dev/cu.usbmodem2101 --baud 921600 --before default_reset --after no_reset --chip esp32s3 write_flash --flash_mode dio --flash_freq 80m --flash_size 8MB --force
0x0 /build/bootloader/bootloader.bin
0xf000 /build/partition_table/partition-table.bin
0x10000 /build/ota_data_initial.bin
0x300000 /build/jJfwmApp.bin.enc
0xe0000 /build/jJfuApp.bin.enc
0x25000 /build/jOtaAesKey.bin.enc

But after booting I get these logs:
ESP-ROM:esp32s3-20210327
Build:Mar 27 2021
rst:0x15 (USB_UART_CHIP_RESET),boot:0x8 (SPI_FAST_FLASH_BOOT)
Saved PC:0x40043daa
0x40043daa: ets_vprintf in ROM

invalid header: 0x8511cbdd
invalid header: 0x8511cbdd

I think I figured it out.
These also need to be encrypted

/bootloader/bootloader.bin
/partition_table/partition-table.bin

yes that was the problem. I had broken my code.


Machine translation not working?

Expected Behavior
Documentation talks about a translation configuration. Followed instructions but nothing is translated.
Actual Behavior
No translation

@guidedways Hi, I'm sorry the feature doesn't work for you. Can you please provide more info about the structure of your files (especially the Strings files) and the exact command you're executing + the output you're getting? Are there any warnings? Please use the -v option to get a more verbose output, maybe it will provide some more detail.


Mesh.get_faces() method crashes on android with GLES2.0

I'm not seeing something similar, will look around for related issues, as it may be others have experienced the same issue but not nailed down to the exact problem.
Godot version:
Official 3.1.1
OS/device including version:
Huawei MYA-L11
Should have:
CPU: ARM Cortex-A53, 1400 MHz
GPU: : ARM Mali-T720 MP2, 600 MHz
Issue description:
I have experienced crashes on my Android GLES2.0 3D project. It works fine in Windows 10.
the issue occours when you want to get vertices of the ArrayMesh in order to generate programmatically a collision shape.
Steps to reproduce:
You can create a simple project with a MeshInstance and arraymesh as it's mesh, doesn't matter if it's empty.
Then use the following code.
func _ready():
	var fcs = self.mesh.get_faces() #this one crashes on android
	print(fcs)

It will crash on an android export.
Minimal reproduction project:
Get_Faces gles2.0.zip
I have added an apk, just in case.. but you may want to configure your own in order to place a breakpoint right before the get_faces() method.

Please don't bully me because I have a Huawei...

Have you tried this with GLES3 as well?

Have you tried this with GLES3 as well?

Nope, at least not on mobile, for performance reasons, too slow on my 2 mobile devices.
Neither on OSX as I do not have a macOS to compile for it.
My guess is that it works, may try later for the sake of solving the issue.

It would help narrow down the problem as I dont have an android build system set up right now.

It would help narrow down the problem as I dont have an android build system set up right now.

That's definitely a problem.
Anyhow, I tried and on my device it crashes right after splash screen:
platform/windows/os_windows.cpp:2532 - Condition ' !process_map->has(p_pid) ' is true. returned: FAILED
But it seems to be my device not working with gles3.0 (even if it states it's compatible), I re created an empty project, added a meshinstance node and a camera, and it crashes, no scripts at all.
I am trying right now with just a node2d this time.

Weird,
I tried with node2d as root, without any other node, it worked, then I changed the root node again to spatial, ad worked.
I added again a mesh and a camera, and it worked again.

Now that I had the GLES3.0 version working I added again the script, and it crashed again.
So I guess I should change the title.


Blog posts broke

See e.g. https://leafletjs.com/2022/04/18/leaflet-1.8.0.html.
I think we didn't consider https://github.com/Leaflet/Leaflet/commit/dfbe5a884a5f61b74efd928199ea1a843cc6b69d in https://github.com/Leaflet/Leaflet/pull/8177. I'm not able to address this until maybe tomorrow.
/cc @Falke-Design, @mourner

Sorry my fault ... but i can't fix it in the next 9 hours.
No the /SlavaUkraini folder cannot be removed because it contains the dialog logic and content of the dialog


stream_create: Use user pills instead of rendering all users list.

Fixes #16805.
This fixes the issue that in realms with 1000+
users, opening stream creation form takes a lot of time and
selecting users for subscribing is basically unusable.
We use the approach used by already present streams which use
pills to allow adding of users instead of displaying
complete list of users.
Opening this since #16979 closed magically on its own.

@amanagr thanks for working on this, and sorry for the slow review!  This is a really important thing to fix.
I think this is great, but creates some problems we need to address in the generic framework, and I think the right solution involves not deleting some of the code deleted here, so I don't want to just merge and then fix forward.
Basically, the problem is that if you're creating a private stream, a really really useful thing to be able to do is start from the membership of an existing stream and then adjust it (adding/subtracting people).  And the key problem is it's hard to tell who is already there and you can't subtract with this design.  So here's my proposal:

The UI for creating streams is as-is in this PR if all of your pills are just individual users.
If you add a stream (or user group: https://github.com/zulip/zulip/pull/17994; @m-e-l-u-h-a-n FYI), we display the old-style checkboxes UI, but just with the set of users you've selected via the pills.  All the boxes would start checked -- but this would serve the purpose of both letting you confirm you you're about to add to your new private stream (not being able to do so when creating your new secret private stream feels really scary) and also letting you conveniently subtract users.
We limit the number rendered to the DOM using ListWidget so it doesn't make things slow if you're trying to add a new default stream in chat.zulip.org.  A mergeable intermediate state would be to just only show the checkboxes when <500 users are involved.

I think the alternative way I could imagine doing this is expanding the "stream" pills to have an "expand" button on them that replaces the stream pills with pills for all its individual users, and then you click X on them freely as you go.  That would probably feel more consistent design-wise.  (Google Calendar apparently uses basically this design pattern for creating calendar events starting from Google Group, which is a very similar use case, so there's some precedent).  And then I guess we'd just not offer that button if your stream has more than 250 members or something (or make it present but disabled with hover behavior).
The main downside of that design is that it's a lot easier to visually scan your list of users if they're displayed one-per-line than if they're in a giant jumble in your pills.
@alya what are your thoughts?  I think we could probably get either of these working in time for the 4.0 release; I think my preference is probably the "Expand stream pills" option just because it's simpler in terms of both design consistency and implementation, and then maybe in some future plan we have a design change or button or something to make it more of a 1-item-per-line visuals if we feel we want that.

I'm fine with the plan of doing the expandable pill boxes for now, and designing a one-per-line expanded view later. I do think the latter will be a better way to go in the long run.
Thank you both!

So for now, do we want to have this expanding pills approach along with current checkbox list of users(but that will have no improvement over slowness of stream creation form.).
(I couldn't find CZO thread regarding this, so I asked it here.)

@m-e-l-u-h-a-n I'm not sure I understand your question.

But in any case, #17994 just merged, so we probably don't need to do much further coordination between these features
(beyond making user group widgets support whatever we do here).

@m-e-l-u-h-a-n I'm not sure I understand your question.

I was asking that this pr removes list of users that allowed selecting individual users through checkboxes, so by adding feature of allowing stream/user_group pills to expand do we want to keep that list of users(for now) or simply add expanding pills feature of stream/user_groups.

Closing this in favour of  #18249.


Please publish typescript types

Thanks for the library. Would it be possible for you to publish typescript types for it?

With 96f67a167c9ec6b7e937f40967dae8d3537768ee the entire project has moved to Svelte 4 and with that the default way of creating packages for Svelte. This also means types are now generated automatically. I don't use Typescript myself, so please let me know if it all works as expected.


Allow noting how many instruments are required

Maybe via a little dropdown over the egg?

This could be expanded to goal tracking in general. You could apply the same implementation to seashell hunt.

The settings now expose all instrument count options (plus the bingo and seashell options that were there), which I'm going to call good enough for now.


MySQL: SQL type VARCHAR is not compatible with SQL type YEAR

The release_year column of the table film is to blame.
I think it's more a problem in SeaORM though.
I monkey patched sakila-data.sql to make it work for now.

Yeah, its located here
https://github.com/SeaQL/sea-schema/blob/master/src/mysql/writer/column.rs#L158

With #114 this issue is no longer present


Not an editor command: UpdateRemotePlugins

Describe the bug
UpdateRemotePlugins is absent.
Version information

OS: macOS 12.1
Neovim:

NVIM v0.6.0
Build type: Release
LuaJIT 2.1.0-beta3
Compiled by brew@BigSur

Features: +acl +iconv +tui
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/local/Cellar/neovim/0.6.0/share/nvim"

Gkeep:

  gkeep: health#gkeep#check
  ========================================================================
  ## gkeep
  │ - OK: gkeepapi 0.13.7 installed
  │ - OK: keyring installed
  │ - ERROR: Remote plugin not found
  │   - ADVICE:
  │   │ - Try running :UpdateRemotePlugins and restart

Well that's interesting since UpdateRemotePlugins is a built-in command (see :help UpdateRemotePlugins). A quick google around suggested that possibly the internal script hasn't been loaded yet for you. I'm not sure how this could happen, but try
:runtime! plugin/rplugin.vim
:UpdateRemotePlugins

You may also need to set let g:loaded_remote_plugins = 0 before. For further diagnosis, the command should be defined in rplugin.vim. If you run :scriptnames, you should see that file in there somewhere (for me it shows up as  60: /tmp/.mount_nvimk4sNN2/usr/share/nvim/runtime/plugin/rplugin.vim)

Thanks a lot, my bad, deep down in my lua configs there was a line: vim.g.loaded_remote_plugins = 1. Commenting it out helped.


add developer documentation to osm repo

to help onboard new developers to the project. how do you set up the project locally, debug, develop, etc.

This is done!


[Feature Request] Telemetry/update check opt out

I cannot find any setting or documentation on how to opt out of Telemetry/update checking.
Please could you add this feature.

Seems to be a duplicate or something that could be added onto #256


[ISSUE #3601] Fix dledger put batch msg stats bug

Make sure set the target branch to develop
What is the purpose of the change
In Dledger Commitlog, put batch msg stats is incorrect.
Brief changelog
fix the stats bug.

Codecov Report

Merging #3600 (5908995) into develop (a779d69) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #3600      +/-   ##
=============================================
- Coverage      48.83%   48.76%   -0.07%
+ Complexity      4650     4644       -6
=============================================
  Files            555      555
  Lines          36738    36739       +1
  Branches        4840     4840
=============================================
- Hits           17942    17917      -25
- Misses         16550    16571      +21
- Partials        2246     2251       +5

Impacted Files
Coverage Δ

...pache/rocketmq/store/dledger/DLedgerCommitLog.java
75.97% <100.00%> (ø)

...ain/java/org/apache/rocketmq/test/util/MQWait.java
43.24% <0.00%> (-10.82%)
:arrow_down:

...org/apache/rocketmq/common/stats/StatsItemSet.java
43.28% <0.00%> (-7.47%)
:arrow_down:

...org/apache/rocketmq/store/ha/WaitNotifyObject.java
66.07% <0.00%> (-5.36%)
:arrow_down:

...ketmq/common/protocol/body/ConsumerConnection.java
95.83% <0.00%> (-4.17%)
:arrow_down:

...mq/client/impl/consumer/RebalanceLitePullImpl.java
48.52% <0.00%> (-1.48%)
:arrow_down:

.../rocketmq/broker/filter/ConsumerFilterManager.java
72.19% <0.00%> (-0.90%)
:arrow_down:

...e/rocketmq/client/impl/consumer/RebalanceImpl.java
39.45% <0.00%> (-0.79%)
:arrow_down:

...n/java/org/apache/rocketmq/store/ha/HAService.java
71.28% <0.00%> (-0.67%)
:arrow_down:

...ent/impl/consumer/DefaultLitePullConsumerImpl.java
67.99% <0.00%> (-0.52%)
:arrow_down:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a779d69...5908995. Read the comment docs.


poly_storage not compatible with empty type optimization

Following my comments in a different poly_storage question, I've isolated a working/compiling example of poly storage and dropped it back into my working codebase. But because I have a couple of empty components, empty type optimization suppresses the underlying pool storage (I think?) and the get or raw functions fail to compile when used within poly_storage.
This can easily be reproduced in the poly_storage test file by adding an empty component and then emplacing it onto an entity in one of the test cases.
#defining ENTT_NO_ETO fixes the compilation error, but I'm wondering if it'd be possible to exclude empty types for consideration in polymorphic storage altogether (as it arguably would make no sense anyway?), or other compile time fixes.

Currently, you can  if constexpr on the storage type directly within the poly object.
Probably, we can make it more flexible by adding the type to the poly_storage trait, so that this becomes possible:
template<typename Entity, typename Type>
struct poly_storage_traits<Entity, Type, std::enable_if_t<!std::is_empty_v<Type>>> {
    using storage_type = poly<Storage<Entity>>;
};

I don't feel the need honestly, but it's viable and it takes something like 5 minutes to do, so... 🙂

the get or raw functions

By the way, raw is about to disappear.

Good to know that if constexpr can easily bypass problematic template instantiations altogether, I was worried it'd require heavy-handed SFINAE hoops. I'll do that for now, thank you! :)

Probably, we can make it more flexible by adding the type to the poly_storage trait

Of course, I was wrong. 😄 This isn't possible since the poly storage cannot depend on the component type. It's... I mean, more or less the reason for which it exists. 🤷♂
However, you can bounce your poly interface to a class that has a specialization for empty types. Or use if constexpr directly.


[HELM] Configuring HTTPS

Hi! thank you in advance for developing this awesome tool :)
I've been reading the documentation and READMEs searching for a simple but secure way to configure https.
I'm testing the k8s/helm deployment, not docker-compose.
I've seen this and its fine for configuring HTTPS in the nginx with docker.
But in the Kubernetes README I've seen that is not yet implemented the option to add my own certificate:

If you want to encrypt the traffic to the nginx server you can use the option --set nginx.tls.enabled=true and --set nginx.tls.generateCertificate=true to generate a self signed certificate and use the https config. The option to add you own pregenerated certificate is generelly possible but not implemented in the helm chart yet.

I've thought that it could be possible to generate kubernetes secrets with cert/key and add them via extraSecrets in values. Also mount that secrets as extraVolumes in /etc/nginx/ssl/
Is this the way it is intended to do this?
More than including a new feature, Im thinking if there is a way to expand documentation related with this.
Also if I can configure HTTPS this way I can share the solution in this ticket
Kind regards!

Is there any reason not to use TLS on top of the ingress, instead of the nginx itself?


Add bw(if(expr)) and brw(if(expr)) to skip writing conditionally

It would be great if it would be possible to skip writing of individual fields conditionally, similar to what br(if(...)) does for reading.
API could look like this:
#[binrw]
#[brw(little)]
struct Data {
    version: u16,
    some_field: u16,
    #[br(if(version >= 5, 0))]
    #[bw(if(version >= 5))]
    another_field: u32,
}

And for brevity:
#[binrw]
#[brw(little)]
struct Data {
    version: u16,
    some_field: u16,
    #[brw(if(version >= 5, 0))]
    another_field: u32,
}

@Holzhaus the currently recommended pattern for this is using the behavior of optionals in binrw (which is that on None nothing is written).
so one potential option is using:
#[bw(map = |field| (version >= 5).then(|| field))]]

or if that's a bit too verbose/polluting, you can get even more fancy and have the following helper function:
fn write_if<T>(condition: impl FnOnce() -> bool) -> impl FnOnce(T) -> Option<T> {
    move |field| condition().then(move || field)
}

Which can then be used like so:
#[bw(map = write_if(|| version >= 5))]

I do think your idea make sense, however, as that makes sense for bidirectionality of the attribute. I had originally gotten it in my head that it didn't make sense as "not involving Default for writing doesn't make sense", however having given it more thought it sorta does? The only concern being that populating the field with a non-default value then being confused it isn't written seems possible.
(Also I should note that presently if you use Option<T> as your field type, the bidirectionality already works, with the caveat that you likely need validation to ensure you don't have Some(T) for versions where that's invalid)

I had been hoping to use if for conditionally writing a constant. Something like #[bw(calc = 0, if(version > 1))].  I eventually used an Option<u32> in the struct. Nevertheless, conditional constants might be another reason to support bw(if…).


vscode: fix #76427 fallout

Motivation for this change
PR https://github.com/NixOS/nixpkgs/pull/76427
Original change https://github.com/NixOS/nixpkgs/commit/bb24fafbfad04cd23431de14176cdc581a906f66
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

https://github.com/NixOS/nixpkgs/pull/76427 seems have completely undone the changes from https://github.com/NixOS/nixpkgs/commit/bb24fafbfad04cd23431de14176cdc581a906f66 (was it based on an old branch?).
Your commit hardcodes the path as https://github.com/NixOS/nixpkgs/blob/0717848d7bb5adb01c7a9f293ed07676099de6f2/pkgs/applications/editors/vscode/with-extensions.nix#L73
but "vscode" isn't guaranteed in the current version
https://github.com/NixOS/nixpkgs/blob/319418f226ea214c3852c172e600fb8cd2aa79d9/pkgs/misc/vscode-extensions/vscode-utils.nix#L28
As far as I can tell reverting the changes from https://github.com/NixOS/nixpkgs/commit/bb24fafbfad04cd23431de14176cdc581a906f66 wasn't deliberate. Reapplying https://github.com/NixOS/nixpkgs/commit/bb24fafbfad04cd23431de14176cdc581a906f66 seems like a better course of action

I'll keep the share/vscode/extensions since it seems like it's used after the PR. https://github.com/NixOS/nixpkgs/blob/319418f226ea214c3852c172e600fb8cd2aa79d9/pkgs/misc/vscode-extensions/vscodeWithConfiguration.nix#L21
Was originally suggested here https://github.com/NixOS/nixpkgs/pull/71251#discussion_r377972428.
Though I'll probably eventually(?) take a deeper look to fixup what was added.


add missing .js to utils import path.

github serves 404 for the imports that end with utils instead of utils.js,
this breaks
https://tetris-rbizvjgqbj.now.sh/
issue:
https://github.com/lukejacksonn/tetris/issues/4

Also please rebase with HAv2.

i am pretty busy, will try to get to that beginning of next week.
i do not care about the credit in the commits too much though,
if you want just do the changes and close this :)
thanks for your work btw, i regularly come back to your hyperapp contributions for examples :)

@jaeh thanks
I applied the fix myself: c49c7d52296cc8d94e23109694e97926fb354a39


tab doesn't work in multi-line insertion mode

In block selection (Ctrl-v), when going to multi-line insertion mode (Ctrl-I or Ctrl-A), the tab key has no effect.

Still the case with prompt-toolkit 2.0.


More detailed error logging on segment activities

+1

Java 8 + zk atomicity seems keeps breaking, trying for a better travis CI run


Azure.Core should wrap all transport layer exceptions

If your network connection drops during the middle of a request, we should throw a RequestFailedException rather than an HttpRequestException that HttpClient throws.
Ideally customers won't have to know or care about which transport layer they're using.

Include clientRequestId in messages.


The Update messed up the colour in formatting

We have written the needed data into your clipboard because it was too large to send. Please paste.How is it that an update that was supposed to supposed to quicken the formatting does not format the document at all.
I copied some code from one file, created another pasted it and the blighter would not use colours to format the document it.

@aniket-chowdhury Can you please include some clear steps and follow the issue template?

I don't know it just glitches some times and some times it works fine. I will close this issue. It seems internal.


Replaced docker container uses amost 1gb memory.

first of all, Thx for creating devspace which really speeds up dev loop.
I am using dev image typescript:18-alpine
but i found the docker container use amost 1gb memory which increases the costs in cloud: aks
I used 512Mi and 500m resoiuces. but it failed at pnpm i due to the oom.
so is there a way to use less memory and cpu resources when doing devspace dev ?

@jaketakula Thanks for reporting this issue. Were you able to find a solution to this? pnpm seems like it might be using a lot of memory, and I don't see where it's installed in the image:
❯ docker run -i -t --rm ghcr.io/loft-sh/devspace-containers/typescript:18-alpine sh -c pnpm
sh: pnpm: not found

IIRC, there's a way to limit the amount of memory that NodeJS can use, which may allow pnpm to run within the memory limits you've given. This is specific to NodeJS, and not something devspace can configure. Here's a SO answer that might be helpful.


Make spoiler for wiki threads

Something like that, spoiler, as simple as it is, so we can put some stuff inside of it

This would be complicated to implement at the plugin level because of themes compatibility and lack of TinyMCE spoiler support 😕


Actualizo el readme

Codecov Report

Merging #7 (c302ea1) into master (cb28732) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##              master        #7   +/-   ##
===========================================
  Coverage     100.00%   100.00%
  Complexity        45        45
===========================================
  Files              6         6
  Lines             86        86
===========================================
  Hits              86        86

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb28732...c302ea1. Read the comment docs.


[WIP] ARROW-2015: [Java] Replace Joda time with Java 8 time

This removes the use of the Joda time library in Arrow Java and replaces it with Java 8 java.time, as recommended by JSR-310. Arrow APIs that previously return a Joda time object will now return a java.time object. This includes the getObject method of date, time, timestamp and interval vectors. Most classes have an equivalent counterpart in java.time and usually required only a small change to use the new API. Some of the notable changes:

IntervalDayVectorpreviously usedPeriodas a friendly-type, now uses java.time.Duration to give intervals in days and time.InvervalYearVectorstill usesPeriod` for intervals in year, month, day.

LocalDateTime is similar but the constructor LocalDateTime.of accepts fraction of a second as nanoseconds, where with Joda time it could be in milliseconds.

DateUtility removed methods for Period conversions because they are done better in java.time.Period now. Also added methods to convert internal time vals to LocalDateTime in UTC that is used in vector and holder reader classes.

@siddharthteotia @jacques-n please take a look and see how this might impact Dremio.  I think most of the changes in API just required slight modifications - like instead of new LocalDateTime use LocalDateTime.of. One issue was that the previous constructor of LocalDateTime could accept milliseconds, while in java.time.LocalDateTime and others, nanoseconds are used. That was the only real gotcha I noticed.  cc @icexelloss

Codecov Report

Merging #2966 into master will increase coverage by 0.94%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #2966      +/-   ##
=========================================
+ Coverage   86.45%   87.4%   +0.94%
=========================================
  Files         490     422      -68
  Lines       68911   63738    -5173
=========================================
- Hits        59579   55708    -3871
+ Misses       9246    8030    -1216
+ Partials       86       0      -86

Impacted Files
Coverage Δ

rust/src/record_batch.rs

go/arrow/array/table.go

rust/src/array.rs

go/arrow/math/uint64_amd64.go

go/arrow/internal/testing/tools/bool.go

go/arrow/array/bufferbuilder.go

go/arrow/internal/bitutil/bitutil.go

go/arrow/memory/memory_avx2_amd64.go

go/arrow/array/null.go

go/arrow/datatype_nested.go

... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df54da2...bd3c4c6. Read the comment docs.

@siddharthteotia @jacques-n please take a look and see how this might impact Dremio. I think most of the changes in API just required slight modifications - like instead of new LocalDateTime use LocalDateTime.of. One issue was that the previous constructor of LocalDateTime could accept milliseconds, while in java.time.LocalDateTime and others, nanoseconds are used. That was the only real gotcha I noticed. cc @icexelloss

@BryanCutler - Dremio is using Joda extensively. This change set would require dremio also to move away from joda. Can you please let me know if this checkin can be held back for a week more so that it gives us time to do the above. All thoughts appreciated. Thanks

Can you please let me know if this checkin can be held back for a week more so that it gives us time to do the above

Hi @shyambits2004 .  Sure there is no need to rush this in. Maybe we could tentatively target this for the 0.13.0 release? We can push it out more if it ends up being too much work for then too.

Yeah, I was thinking this would be a bit much to push into 0.12, and 0.13 timeline would be ~February

Hi @shyambits2004 have you had a chance to make the necessary changes on Dremio side, can this change be updated and submitted?

@tvamsikalyan I think there is no easy way to support backward compatibility here. Consumers of arrow java will need to switch to java8, if they have to upgrade to a release that contains this change.

Yes, this is an API breaking change. I have updated the description and will add something to release notes.

Yes, this is an API breaking change. I have updated the description to reference the vector getObject method and will add something to release notes.

OK. Please see reader class changes also. In one case, getPeriod was changed to getDuration.

@tvamsikalyan I think there is no easy way to support backward compatibility here. Consumers of arrow java will need to switch to java8, if they have to upgrade to a release that contains this change.

OK.

Necessary changes on Dremio side were done. This change can be updated and submitted.
Thank you so much.

Great, thanks @tvamsikalyan !  I will rebase and update this PR soon.

I have rebase and will merge later after tests pass. Ping @pravindra and @tvamsikalyan if you would like to take a final look.

huzzah

all tests passed except an unrelated Ruby failure

Merged to master, thanks all for reviewing!


fix(nvd): add support of versionStartExcluding and versionEndExcluding

Description

Add support of versionStartExcluding and versionEndExcluding fields.
Add (including) and (excluding) suffixes for versions.
Add update (if used) for versions from CPE

Before:

After:

@knqyf263 @simar7 Take a look this PR, when you have time, please.

There is still a mismatch for the 0.9.0-beta versions in the nist.gov source and the screenshot in the PR, see the last screenshot from this comment: https://github.com/aquasecurity/vuln-list-update/issues/282#issue-2216503420

Hello @pjonsson
Thanks a lot! I missed update part for versions from CPE.
I updated this in https://github.com/aquasecurity/avd-generator/pull/82/commits/35c548c090c9a349996b356dd7ee859d7e3bc2e5

I don't know anything about the code, but the current screenshot in this PR looks like it captures everything from the CVE at nist.gov.


Manual configuration of Github web-hook build trigger gives 403  CSRF verification failed.

The full Gitbug service integration asks for a lot of privileges - including the email lists of my employer organisation, even if the repo I want to serve is under my personal Gibhub account.
Instead, I have tried to configure the webhook update manually from Github.
Using the cli, works great, and the docs are correctly rebuilt,
curl -v -v  -X POST https://readthedocs.org/build/mcp-profile-docs

Configuring Github to hit the same url fails with a 302 redirect to https://readthedocs.org/projects/mcp-profile-docs/builds/
Configuring Github with the redirected url https://readthedocs.org/projects/mcp-profile-docs/builds/ gives a 403

Forbidden (403)

CSRF verification failed. Request aborted.

You are seeing this message because this HTTPS site requires a 'Referer header' to be sent by your Web browser, but none was sent. This header is required for security reasons, to ensure that your browser is not being hijacked by third parties.

If you have configured your browser to disable 'Referer' headers, please re-enable them, at least for this site, or for HTTPS connections, or for 'same-origin' requests.

You can use the GitHub endpoint at https://readthedocs.org/github -- this should be in our docs, feel free to contribute the change if not.

Manual Github webhooks are documented here:
http://docs.readthedocs.io/en/latest/webhooks.html#github

We also have a more recent management page for this, found under "Integrations" on the project dashboard. I'd suggest looking at that and the docs on webhooks if you're still hitting issues here.


[building] consider rollup

I'd like to look into a rollup based default config. I think we need to have measurable benefits from using rollup VS webpack, and give different recommendations for different scenarios.
I'd like to open a discussion in this issue about this.
Some areas I am interested in:
Module output
This is one of the obvious benefits, but how practical is it? Not all browsers which support modules, support dynamic imports. How do you make sure you distribute the right code?
Code optimization
Focusing on es-modules has the potential for better tree shaking, dead code elimination and minification (inlining variables etc) because it's easier for the bundler to take certain assumptions. I'd like to see if this can be measured objectively.
Code splitting
One thing that webpack does very well is code splitting. It is more complicated than it seems, as shared dependencies between lazy loaded chunks creates quite some coordination demands on the bundler. I'm interested in seeing how rollup stacks up against webpack in this area.
Build tasks
For larger apps building is more than just compiling the JS. Static assets need to be moved around, environment variables need to be set etc. How well does rollup handle these things?
Caching
Webpack handles caching, both short and long-term. For .js but also other assets like css and pngs. How does rollup handle this?
Does anyone have any insights in this area?

Module Output
Rollup can output es, IIFE, cjs, amd, system, umd. you're covered

Code Splitting
Landed stable in Rollup 1.0. I use it in my apps, and developed rollup-plugin-modulepreload to help devs automatically preload chunks based on a predefined or  custom predicate

Build Tasks
There are lots of plugins for this like rollup-plugin-cpy. npm scripts are also good for this

I like rollup's plugin-based architecture.
I like rollup's focus on browser standards rather than kitchen-sinking.
I like the quality of rollup's generated code.


cannot install with pgsql as database

I got the source; ran
php artisan microweber:install<EMAIL_ADDRESS>admin pass db.domain microweber laravel password pgsql

As I only had postgres PDO compiled with PHP.  It came back and said,
Installing Microweber...

  [Illuminate\Database\QueryException]
  SQLSTATE[42P01]: Undefined table: 7 ERROR:  relation "attributes" does not
  exist (SQL: alter table "attributes" add column "attribute_value" text null
  , add column "rel_type" varchar(255) null, add column "rel_id" varchar(255)
   null, add column "attribute_type" varchar(255) null, add column "session_i
  d" varchar(255) null, add column "updated_at" timestamp(0) without time zon
  e null, add column "created_at" timestamp(0) without time zone null, add co
  lumn "created_by" integer null, add column "edited_by" integer null)

  [PDOException]
  SQLSTATE[42P01]: Undefined table: 7 ERROR:  relation "attributes" does not
  exist

when I tried to open the web site, I was shown another error:

Server check
There are some errors on your server that will prevent Microweber from working properly

    The PDO MYSQL PHP extension must be loaded

How could I make it work with Postgres only?

Hi, you must install the PDO PHP extension
http://stackoverflow.com/a/13375165/731166

Doing artisan microweber:install with the prefix option got me another error:
hau@fig ~/lab/my_site $ php artisan microweber:install<EMAIL_ADDRESS>admin pass db.domain microweber laravel password pgsql -p my_site_
Installing Microweber...
Error: SQLSTATE[08006] [7] timeout expired

Hello @hau , i have made fixes for pgsql, can you try now by downloading the zip from here https://github.com/microweber/dist/raw/master/microweber-latest.zip

Bug was fixed in the given zip version.  Thank you!


Bug fix: Similar filename causes premature blow_up

Log similar filenames, but don't blow_up until all files have been searched

I'm failing two tests, but the baseline is also failing the same two tests.

We are soon to release the next major version of Ceedling. There are release candidates available on the release tab on github. I believe it already fixes this issue.

We are soon to release the next major version of Ceedling. There are release candidates available on the release tab on github. I believe it already fixes this issue.

Great, thanks!


Transaction Links aren't shown

"Transactions can also be linked together. You may think of the link as a special kind of tag that can be used to group together a set of financially related transactions over time. "
2014-02-05 * "Invoice for January" ^invoice-pepe-studios-jan14
  Income:Clients:PepeStudios           -8450.00 USD
  Assets:AccountsReceivable

2014-02-20 * "Check deposit - payment from Pepe" ^invoice-pepe-studios-jan14
  Assets:BofA:Checking                  8450.00 USD
  Assets:AccountsReceivable

They should probably work the same way as tags currently do

Duplicate of #110

Ah, sorry, missed that one :-)


⚠ Processors has degraded performance

In c659261, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 62 ms

Resolved: Processors performance has improved in 175d750.


Add fpm config-files flag

This addresses #88 where package updates overwrite the /etc/defaults/gortr file, loosing any configured runtime arguments. By adding the --config-files flag, fpm instructs the system package manager to prompt before overwriting.

Ah, I typoed that commit message, twice! I've force pushed to my branch to fix that, my bad.

Ah, I typoed that commit message, twice! I've force pushed to my branch to fix that, my bad.


Fix linter checks

The CI linter checks are broken. The CI job fails with:
golangci-lint run ./...
Error: server/plugin.go:39:28: unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
func (p *Plugin) ServeHTTP(c *plugin.Context, w http.ResponseWriter, r *http.Request) {
                           ^
Error: server/plugin.go:90:82: unused-parameter: parameter 'mmUserID' seems to be unused, consider removing or renaming it as _ (revive)
func (p *Plugin) httpMeetingSaveSettings(w http.ResponseWriter, r *http.Request, mmUserID string) {
                                                                                ^
Error: server/plugin.go:115:81: unused-parameter: parameter 'mmUserID' seems to be unused, consider removing or renaming it as _ (revive)
func (p *Plugin) httpMeetingGetSettings(w http.ResponseWriter, r *http.Request, mmUserID string) {
                                                                                ^
Error: server/command.go:44:33: unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
func (p *Plugin) ExecuteCommand(c *plugin.Context, args *model.CommandArgs) (*model.CommandResponse, *model.AppError) {
                                ^
Error: server/command.go:219:37: unused-parameter: parameter 'args' seems to be unused, consider removing or renaming it as _ (revive)
func (p *Plugin) executeCommandHelp(args *model.CommandArgs) *model.CommandResponse {
                                    ^
make: *** [Makefile:46: check-style] Error 1
Error: Process completed with exit code 2.

See https://github.com/mattermost/mattermost-plugin-agenda/actions/runs/8660923579/job/23749777528?pr=112

I'll pick this one up.
Only question is what you want to do with the unused function.
the unused params are easily ignored with _
But the getConfiguration function is currently not used. Removing it doesn't break anything but maybe its better to set a lintignore there to keep the functionality?


[Bug] [kompile] - Broken #Or translation to kore in function equation

K Version
$ kompile --version
RV-K version 1.0-SNAPSHOT
Git revision: c305b58
Git branch: master
Build date: Sat Jan 30 02:51:41 EET 2021

Description
Rule whose right-hand-side consist of an #Or expression replaces the entire RHS with a variable during translation.
Input Files
tmp.k
module TMP
  imports INT

  syntax Int ::= split(Int)  [function, functional]

  rule  split(V:Int)
        =>
          (
            (
              {true #Equals (V >=Int 0)}
              #And V
            )
            #Or
            (
              {false #Equals (V >=Int 0)}
              #And (V +Int 1)
            )
          )
    [label(xyzzy)]

endmodule

Reproduction Steps
$ kompile --backend haskell tmp.k

The xyzzy rule above is translated to the following, which replaces the entire right-hand side with a variable.
  axiom{R} \implies{R} (
    \and{R}(
      \top{R}(),
      \and{R} (
          \in{SortInt{}, R} (
            X0:SortInt{},
            VarV:SortInt{}
          ),
          \top{R} ()
        )),
    \and{R} (
      \equals{SortInt{},R} (
        Lblsplit'LParUndsRParUnds'TMP'Unds'Int'Unds'Int{}(X0:SortInt{}),
        Var'Unds'0:SortInt{}),
      \top{R}()))

Expected Behavior
The RHS should be translated to Kore instead of being replaced with a variable.

It looks like this "GuardOrs" pass (https://github.com/kframework/k/blob/master/kernel/src/main/java/org/kframework/compile/GuardOrPatterns.java#L82) is affecting #Or patterns which appear only on the RHS of a rewrite, when it should not be touching these #Or patterns.
Need to make sure we do not traverse inside the RHS of a rewrite when doing this transformation.


[Bug]: Repeated Connectivity result - ConnectivityResult.mobile

Platform
iOS 16
Plugin
Connectivity Plus
Version
3.0.2
Flutter SDK
3.7.12
Steps to reproduce
Whenever connectivity result change we are logging it
Connectivity _connectivity = Connectivity();
 _connectivity.onConnectivityChanged
        .listen((ConnectivityResult result) {
     log('Connectivity subscription result: $result');
});

For many users we are getting repeated ConnectivityResult.mobile. Wanted to know what could cause this? Ideally it should be ConnectivityResult.mobile -> ConnectivityResult.none -> ConnectivityResult.mobile.

### Logs

```shell
// not required

Flutter Doctor
[✓] Flutter (Channel stable, 3.7.12, on macOS 13.0.1 22A400 darwin-x64, locale en-IN)
    • Flutter version 3.7.12 on channel stable at /Volumes/Work/flutter_sdk/flutter_3.7.12
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 4d9e56e694 (5 months ago), 2023-04-17 21:47:46 -0400
    • Engine revision 1a65d409c7
    • Dart version 2.19.6
    • DevTools version 2.20.1

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc4)
    • Android SDK at /Users/sumeet/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0-rc4
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] VS Code (version 1.80.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.68.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 13.0.1 22A400 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 116.0.5845.179
    ! Error: Failed to prepare the device for development. Please unlock and reconnect the device. (code 806)

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Checklist before submitting a bug

[X] I Google'd a solution and I couldn't find it
[X] I searched on StackOverflow for a solution and I couldn't find it
[X] I read the README.md file of the plugin
[X] I'm using the latest version of the plugin
[X] All dependencies are up to date with flutter pub upgrade
[X] I did a flutter clean
[X] I tried running the example project

Me too.
On IOS -
when disable/enable WiFi, why do I get several messages (3 times when disable, 7 times when enable):
flutter: ConnectivityManager: Connectivity subscription result: ConnectivityResult.none
flutter: ConnectivityManager: Connectivity subscription result: ConnectivityResult.none
flutter: ConnectivityManager: Connectivity subscription result: ConnectivityResult.none
flutter: ConnectivityManager: Connectivity subscription result: ConnectivityResult.wifi
flutter: ConnectivityManager: Connectivity subscription result: ConnectivityResult.wifi
flutter: ConnectivityManager: Connectivity subscription result: ConnectivityResult.wifi
flutter: ConnectivityManager: Connectivity subscription result: ConnectivityResult.wifi
flutter: ConnectivityManager: Connectivity subscription result: ConnectivityResult.wifi
flutter: ConnectivityManager: Connectivity subscription result: ConnectivityResult.wifi
flutter: ConnectivityManager: Connectivity subscription result: ConnectivityResult.wifi

Same for me. This started to occur with version 5.0.0

Anything on this ?

The callback is called whenever the OS NotificationCenter emits a value, and the package doesn't check if the value is distinct to the previous one, that would be something you would have to do on your side.
There is also a PR on the works that is changing the way the connectivity values are returned, it would be good if you could test it for your usecase: https://github.com/fluttercommunity/plus_plugins/pull/2599

It is mentioned in the README already that currently plugin doesn't filter values returned by the underlying platform. Check the last sentence here: https://github.com/fluttercommunity/plus_plugins/tree/main/packages/connectivity_plus/connectivity_plus#ios--macos
Closing as currently this is how the plugin works. We plan to update the behavior to distinct values, but it will happen a bit later.


ucob encounter issues

Hello ! I'm having a problem with cactbot, sometimes ucob alerts/timeline didn't work at all. and someday, it work for like 1 time (generally when I restart the duty) and it didnt work after a wipe. It seems tied totally to RNG, I don't understand because I don't have any problem with every 5.0+ fights.
I'm unsure about others old encounters but i'm pretty sure it happens to me too sometimes on others content.
my high performance parsing filter is not disabled and I already checked if my in game log was hiding something but it seems everything is fine also cactbot don't send any error in the log.
EDIT: Sorry to add this: it seems it happens only when I am resetting the parse manually before the pull but it didnt happens on new encounter even if i am resetting the parse manually between pulls.

I also get this pretty frequently. Also have issues with de-syncing when pushes happen early in P1, effectively making the timeline unusable the rest of the phase.

same things for UwU

Are there errors in the overlayplugin log when this is happening? In the cactbot options, if you click developer options, and the the debug option for raidboss, this will add a "timeline time" (among some other debug output in the console) by the timeline.  One thing to check is if it is still running after a wipe, and that's why this is happening.
Re: timelines.  ucob phase 1 is tricky to sync.  I could probably do a better job, but there's a large amount of time between when twin drops the neurolink and when the next ability comes to sync to, and so timelines are always going to be a bit messy.  If you can attach some network logs, I can try to make something that works.
Sorry, but  "same things for UwU" is a bit vague.  Do you mean the timeline? Do you mean that it's not working sometimes?

EDIT: Sorry to add this: it seems it happens only when I am resetting the parse manually before the pull but it didnt happens on new encounter even if i am resetting the parse manually between pulls.

What do you mean by resetting the parse manually? And you're saying when you do that, that's when the problem occurs?

I'll see if I can get some network logs uploaded for you later. Thanks!
On Sat, May 9, 2020, 1:07 PM Adrienne Walker<EMAIL_ADDRESS>wrote:

Are there errors in the overlayplugin log when this is happening? In the
cactbot options, if you click developer options, and the the debug option
for raidboss, this will add a "timeline time" (among some other debug
output in the console) by the timeline. One thing to check is if it is
still running after a wipe, and that's why this is happening.
Re: timelines. ucob phase 1 is tricky to sync. I could probably do a
better job, but there's a large amount of time between when twin drops the
neurolink and when the next ability comes to sync to, and so timelines are
always going to be a bit messy. If you can attach some network logs
https://github.com/quisquous/cactbot/blob/master/docs/FAQ-Troubleshooting.md#how-to-find-a-network-log,
I can try to make something that works.
Sorry, but "same things for UwU" is a bit vague. Do you mean the timeline?
Do you mean that it's not working sometimes?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/quisquous/cactbot/issues/1394#issuecomment-626214564,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AI3I7W2QC4T6J74WT2LABA3RQWLXRANCNFSM4MT7AC3Q
.

Timeline didnt work at all, I only have basic triggers (provoke sound, hallowed ground sound, etc)
but nothing work in the fight.
By resetting the parse manually, i mean pressing "Clear Encounter" on ACT. I do that each wipe, that's why the timeline work only the first try and then i didnt work again.
Same things for uwu means it's exactly the same thing as ucob, it work only the first try.
I'm gonna see if I can use logs

Hi, just checking back here again.  I heard from @panicstevenson that uwu seems to be working.
If any of you are still having uwu or ucob issues, the best thing to do is to attach a zipped up Network log to this issue.  Even a video would help at this point.  This would help a lot with whatever's going on in p1 ucob especially.
A second thing to try is to go into the cactbot config, turn on developer mode, and then turn on raidboss debug mode.  This will add a small timer to the side of raidboss timelines (and add a bunch of debug output).  If the timer is still running when you're starting a fight, then that's an issue.
A third thing is wondering if this is #1453?

Hi, wanted to add I'm also having issues with the UCOB timeline, and fire in/out continuing to fire (ha) incorrectly even after a wipe. The fire in/out spam after wipe has so far happened every time we've made it to Nael. I also experienced issues with the timeline all-together disappearing, but I'm not sure if it's related to this existing issue. I found this thread after we were done raiding, so I plan to record with developer mode and debug mode on next time. I'm attaching an affected network log.
Network_20510_20200623.zip

@soveriegn3 The delayed triggers I filed as #1513.  It's not ucob specific, but it's worse in ucob because all the fire triggers all get launched with delays at the start of the phase.  My recommendation is to not wipe in Nael phase.  :wink:
The timeline disappearing is weirder.  I have seen that happen when there's a crash, which you would find in your OverlayPlugin log afterwards.  If you see it again, check there and let me know any additional info.
This all sounds different than the previous issues of "phase 1 desyncing" and "sometimes the timeline doesn't start" too.  I'm still hoping my timeline changes fixed the desyncing, and I don't know what's going on with the timeline not starting.

Finally got back into UCOB today, and couldn't replicate the issues of the timelines being out of sync or not loading at all. I did get a few samples of fire in/out firing after a wipe but it looks like you covered that in  #1513. thought I'd update.

Sounds like this is maybe fixed.  Let me know if this is still happening.


Code comments not interpreted correctly

Again, this is a Gogs issue that remains a Gitea issue. This applies to wiki and issues entries as well.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/40585754-code-comments-not-interpreted-correctly?utm_campaign=plugin&utm_content=tracker%2F47456670&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F47456670&utm_medium=issues&utm_source=github).

I can't see the plaintext content so it's very hard to debug (as I mentioned in that issue)

@lunny, indeed. Or, as I replied on the original issue, just try it.

resolved by #1660


.html() doesn't execute scripts unlike .append()

Just found such kind of inconsistency.
// script is not executed
$('body').html('<script>alert(1)</script>');

// script is excuted
$('body').html('').append('<script>alert(1)</script>');

I thought I will able to fix it by replacing the following code:
https://github.com/fabiospampinato/cash/blob/master/src/manipulation/html.ts#L19-L25
  return this.each ( ( i, ele ) => {

    if ( !isElement ( ele ) ) return;

    ele.innerHTML = html;

  });

with:
return this.empty().append(cash.parseHTML(html));

But it fails in .html(0) test.

I can prepare PR with the following changes to html.ts if I did that correctly and if you believe this should be fixed:
 // @require core/cash.ts
 // @require core/type_checking.ts
-// @require collection/each.ts
+// @require core/variables.ts
+// @require collection/filter.ts
+// @require ./append.ts
+// @require ./empty.ts
+// @require ./text.ts

 interface Cash {
   html (): string;

   if ( isUndefined ( html ) ) return this;

-  return this.each ( ( i, ele ) => {
-
-    if ( !isElement ( ele ) ) return;
-
-    ele.innerHTML = html;
-
-  });
+  if ( htmlRe.test ( html ) ) {
+
+    this.filter ( ( i: number, ele: EleLoose ) => isElement ( ele ) ).empty ().append ( html );
+
+  } else {
+
+    this.text ( html );
+
+  }

+  return this;
 }

 fn.html = html;

First of all how does jQuery behave under the same scenario? Cash is general strives to align with that as much as possible.

jQuery executes scripts passed to .html method. Just tried at jquery.com in the browser console:
jQuery('body').html('<script>alert(1)</script>');

Here is a link to jquery's implementation: https://github.com/jquery/jquery/blob/main/src/manipulation.js#L373-L402

Same for append?

Append is working fine in Cash :). Scripts are executed.

But is that what jQuery does too? Correctness is alignment with jQuery basically.

Yes, all jQuery's methods that accepts html will execute scripts.
https://api.jquery.com/html/:

By design, any jQuery constructor or method that accepts an HTML string — jQuery(), .append(), .after(), etc. — can potentially execute code. This can occur by injection of script tags or use of HTML attributes that execute code (for example, ). Do not use these methods to insert strings obtained from untrusted sources such as URL query parameters, cookies, or form inputs. Doing so can introduce cross-site-scripting (XSS) vulnerabilities. Remove or escape any user input before adding content to the document.