Add the link to the discussion in the ML

CC @ndeloof @batmat @KostyaSha

:+1:

I think it's safe enough though the state does not seem to be correct in general


KAFKA-16260: Deprecate window.size.ms in StreamsConfig.java and index.html

This is the first step towards KIP-1020
Pieces of config to deprecate:

window.size.ms
windowed.inner.class.serde

In the code, WINDOWED_INNER_CLASS_SERDE was directly below DEFAULT_WINDOWED_VALUE_SERDE_INNER_CLASS with no decorators or javadocs. I added a @Deprecated decorator.
I added a @Deprecated decorator to WINDOW_SIZE_MS_CONFIG and a short note regarding deprecation to the javadoc. Normally I'd note the release it was dep'd in as well as alternate config but those are not established yet.
In the documentation, I added a short note on deprecation to window.size.ms but again, had no further info to add.
Something titled windowed.inner.class.serde was not present in config-streams.html

Closing this for now. We can reopen anytime.


New build system

Pre:
I think Xcode builtin spm support is very sad.

If you delete DerivedData you have to close Xcode and redownload all deps (with xcframeworks they are really heavy)
Can't actually link to XCFramework (you have to use abs path to derived data)
Really poor and only one way to edit deps via UI
Updates not reliable (sometimes you have to delete DerivedData)

I propose to use Package.swift directly and reference deps XCFrameworks from .build/artifacts
I put Package swift in xcfs (read as xcframeworks) folder. And change reps in targets to xcfs/.build/artifacts/xcfs/.... so we have relative paths to XCFrameworks now.
Another improvements:

I use archives for building frameworks, so we have dsyms and call safe layer for compatibility
xcframeworks now have dsyms
I added GitHub Actions, so we can publish sha for libs on release

Other thoughts and plans:

This is work in progress, I just want to show you direction and get feedback early
Pland to upgrade to openssl 1.1.1i. (I have lib compiled, but I need to update ssh_cmd)
We need to drop i386 and include arm64 from simulators

That sounds interesting. I agree with all the issues you listed for binary swift packages. The only way I have to force update for a specific package is to delete it and then add it again. It's really not convenient.
It would be good to invite comments by other users of these packages.

That sounds interesting. I agree with all the issues you listed for binary swift packages. The only way I have to force update for a specific package is to delete it and then add it again. It's really not convenient.
It would be good to invite comments by other users of these packages.

I forget to add, that to build all xcframeworks you can run swift run --package-path xcfs build from the root of the project.

I forget to add, that to build all xcframeworks you can run swift run --package-path xcfs build from the root of the project.

👋
I upgraded ssh-keygen to openssl 1.1.1i (ref #110).
Enabled arm64 simulator for all frameworks and also fix curl_ios_static.

👋
I upgraded ssh-keygen to openssl 1.1.1i (ref #110).
Enabled arm64 simulator for all frameworks and also fix curl_ios_static.

Thank you very much. That PR will be extremely useful and valuable. I'll review it tonight.

Thank you very much. That PR will be extremely useful and valuable. I'll review it tonight.

Cool! Can you create tag v2.7.0 for test? GitHub Actions will build all frameworks

Cool! Can you create tag v2.7.0 for test? GitHub Actions will build all frameworks

I'm trying. "git tag v2.7.0" created the tag, but did not propagate it to the server. I'm looking at the documentation.

I'm trying. "git tag v2.7.0" created the tag, but did not propagate it to the server. I'm looking at the documentation.


Deploy sample api

As per #74:
Deploy a sample api as described, say, from in https://www.deadbear.io/simple-serverless-fastapi-with-aws-lambda/ and be able to call it from CLI
AC:
-sample app is deployed via Terraform
-sample app is callable  from CLI
Work Plan:

[x] Get a FastAPI example app (from the url above) and put it into /server/lambda (replacing what is there)
[x] Figure out how to run the example app locally in python
[x] Add a build step to pull_request.yml
[ ] Add a build step to push.yml
[ ] Figure out how to run tests (?) >>breakout to separate ticket
[x] Add a terraform file to /server that deploys the build as a lambda function
[x] Use the AWS admin console to execute the lambda function to verify that it works.

Deploy lambda via Terraform requires Admin access

@ArogeG and @gormless87 I still don't have the admin access in AWS. I am getting "aws_iam_role.fam_api_v1_lambda_exec will be created" but was not created.

@explorertolu  I have sent another reminder and added Julian to the chat. Are you able to work on something else while we await your access elevation request?

@ArogeG Sure, thanks!

Thanks @ArogeG, my admin access is now working.
@gormless87

@gormless87 I have completed the work except for the testing that we need to breakout in a separate ticket.


Add support for AWS_SESSION_TOKEN

This PR adds support for AWS_SESSION_TOKEN so that users can use an AWS account that supports this when using CloudFiles. Previously, requests would all return Forbidden because the session token was not actually being used during boto3 client creation. The PR adds support for AWS_SESSION_TOKEN to be used in an environment variable as well as through aws-secret.json. Fixes #101 .

Tests are failing due to import error, not due to this PR.


Plans for places actions?

What are the current plans for implementing places actions such as adding a place and deleting a place. I see they are on the agenda but where on the list are they and how soon is it expected to be added?
I'm not so familiar with creating node packages or I would attempt to jump in myself and help add it.

I'm happy to accept a PR, but I won't be working on it in the coming weeks.

I am working on messing with it now actually, one thing though you might be able to point me in the right direction for.
When creating a server api key in the google developers area what IP address(s) should I be adding so that requests from my node app work on my local machine?

 So if you use a router whatever IP address your router receives from the Modem.


Revert "Merge pull request #9151 from DFE-Digital/1609-apply-for-tt-m…

…igrate-code-to-terraform-modules-apps"
This reverts commit a0c0bd19b495ebc43471829543db03ea64602b25, reversing changes made to a9b7bea28e2b79d907c16483d506eb69b0b938b9.
Context

Changes proposed in this pull request

Guidance to review

Link to Trello card

Things to check

[ ] If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
[ ] This code does not rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
[ ] API release notes have been updated if necessary
[ ] If it adds a significant user-facing change, is it documented in the CHANGELOG?
[ ] Required environment variables have been updated added to the Azure KeyVault

Not required


Ricebox

This PR adds go-rice for stable file resolution in production and development environments.
It also modifies the builds and deployments accordingly for Kubernetes.
fixes #38

Damn.  I had that originally.  I took it out because I was fighting with referencing the HTMLLayout from within the ricebox.  I'll try again in a new PR

tracking with :
https://github.com/gopheracademy/gcon/issues/46


Broken links

Package version (if known): 29
Describe the bug
Navigating links goes to error page
Steps to Reproduce

Click on any of the 10 links (in Loans HIstory) under Document or Physical copies in the screenshot
Goes to error page

Expected behavior
Screenshots (if applicable)
Additional context

Thank you for reporting that. It will be fixed by this PR.


Add MP_ERROR_TEXT for MicroPython post-1.12 (esp32-only)

This PR has fixes needed post MicroPython v1.12 due to the required MP_ERROR_TEXT macro.
This PR only fixes the esp32 port, same changes need to happen for other ports as well..
I realize you don't want to just merge this given that you're most likely still working with v1.12, I'm just providing it for the future.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you.
In the meanwhile I'll add a define for MP_ERROR_TEXT in lv_conf.h
That way I'll be able to merge your change now, and in the future just remove that define.

This is causing build breakage on the JavaScript port (after 1.12). lv_conf.h is included before the internal MicroPython headers, so it defines MP_ERROR_TEXT. When the MP header gets included, it tries to redefine the macro and causes errors.
At the moment I'm working around this by commenting out the definition in lv_conf.h.

Ignore my previous message; it turns out that I forgot to update submodules.


navigate to screen from BottomSheet

How can we navigate to a screen from a bottom sheet?
if i navigate to Screen from BottomSheet, screen will be another bottom sheet. How can i do the opposite?

LocalNavigator.currentOrThrow.parent.push(NewScreen())?

didn't work

One idea might be to do this:
    bottomSheetNavigator.saveableState("isVisible") {
        Napier.d(
            tag = "push",
            message = "Bottom Sheet ${bottomSheetNavigator.isVisible} ${bottomSheetNavigator.items} ${bottomSheetNavigator.lastEvent}"
        )
        if ((bottomSheetNavigator.isVisible).and(bottomSheetNavigator.lastEvent == StackEvent.Idle)) {
// navigate to new screen
        }
    }

The idea is to wait until the bottomsheet is hidden and then to push the new screen. However, it's still not working in my case for some strange reason.


Update pom.xml

Pull request for CircleCI to build and test :(

Problem appears to be getting craftbukkit, not vault.

Indeed, back at home now so was going to take a proper look.

@dumptruckman Ok, looks like it struggles to get CraftBukkit because of your Logging library.
https://github.com/dumptruckman/Logging/blob/master/pom.xml
I'm able to add the Essentials repo to grab the version required for building. Any reason why that relies on CraftBukkit and not Bukkit? Only saw a reference to the Plugin class.

Huh. I forgot that was a separate lib. Anyway, I updated it to use Bukkit instead. Build successful on our ci.

Nice, unable to get the tests to pass on my PC. Not sure why, been too long!

Fixed in #1586 ?


Blog Post for Separate Image Filesystem for Kubelet

Kubernetes has had support for many releases for a separate image filesystem. There are common configuration issues that users can do to get into a separate filesystem case.  This post walks through configurations and the eviction manager.

/cc @rphillips @haircommander for the technical review

content looks good, I'd recommend some sort of conclusion though, the blog feels like it ends abruptly to me

content looks good, I'd recommend some sort of conclusion though, the blog feels like it ends abruptly to me

Thanks for that suggestion. I'll put on future work and suggest ways to get involved.

content looks good, I'd recommend some sort of conclusion though, the blog feels like it ends abruptly to me

Updated with some future work and a getting involved.

/sig node

/hold
pending assignment of publication date

/hold
pending assignment of publication date

great! I’m on PTO so I’ll address these comments in December so no rush on publication date.

Thanks for proposing the article. Please revise this in light of the pending feedback, including https://github.com/kubernetes/website/pull/43971/files#r1400907393
/hold
we must not publish this until we've assigned a release date, bearing in mind that the v1.29 release is imminent.

As this is unfinished, I'll mark it as a work in progress. Please change the PR title once it's ready for review.
/retitle [WIP] Add blog post for Separate Image Filesystem for Kubelet

/hold cancel
@sftim this is ready for review again.

/hold
pending assignment of publication date
(Please don't unhold until a publication date is assigned).

/retest

/hold cancel
@sftim this is ready for a review again. Updated the date so I think its good to go.

Not sure why the deploy failed though.

@sftim Looks like we have today and tomorrow to merge if we want to keep the due date. Any outstanding issues?

This PR isn't previewing, which is a shame.
If you push an almost identical commit in place of what's there, that might help (https://github.com/kubernetes/website/issues/43736 tracks a proper fix)

Thanks
/lgtm
/approve

Hi, Tide.


Issues connecting to Snoonet

Hello!
When attempting to connect to the bot to our Snoonet server, I'm getting a disconnect during a PONG event:
Attempting socket connection to IRC server
Socket connection successful
Sending irc NICK/USER
SEND: CAP REQ sasl
SEND: NICK botname
SEND: USER botname 8 * botname
GOT NOTICE from the server: "*** If you are having problems connecting due to ping timeouts, please type /quote PONG <password> or /raw PONG <password> now."
info: Connected to Discord
SEND: PONG <password>
Unhandled message: { command: 'ERROR',
  rawCommand: 'ERROR',
  commandType: 'normal',
  args: [ 'Closing link<EMAIL_ADDRESS>[Registration timeout]' ] }
Connection got "end" event
Connection got "close" event

It looks like it's trying to send the PONG, then it disconnects after about 20 seconds... any ideas?

update: removed "sasl": "true" and things are connecting ok.


Add fake simulation support for talonSRXCollection

CTRE has yet to add HALSIM support for their devices. This PR will fake support for the TalonSRXCollection object, so we can simulate TalonSRX devices

Im just going to wait on CI, then merge this


question about the roadmap of xla send/recv ops supporting.

Please make sure that this is a feature request. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:feature_template
System information

TensorFlow version (you are using): TensorFlow master branch with commit id: 3ef6fbfd02716f774024afae711383fdb0d8a30c
Are you willing to contribute it (Yes/No): Yes

Describe the feature and the current behavior/state.
I'm starting my project on top of tensorflow with cross-machine communication support. Currently, we want to use the send/recv ops for multicast/p2p communication in HLO graph. However, we find that the latest tensorflow has not fully supported such ops in xla. I would like to query the roadmap for the support.
The send/recv hlo file for test is as follows:
HloModule TwoSendRecvBothWayRecvFist_module
ENTRY %TwoSendRecvBothWayRecvFist.v3 () -> (f32[], token[]) {
%token0 = token[] after-all()
%recv = (f32[], u32[], token[]) recv(token[] %token0), channel_id=15, sharding={maximal device=1}
ROOT %recv-done = (f32[], token[]) recv-done((f32[], u32[], token[]) %recv), channel_id=15, sharding={maximal device=1}
%constant = f32[] constant(2.1), sharding={maximal device=0}
%send = (f32[], u32[], token[]) send(f32[] %constant, token[] %token0), channel_id=16, sharding={maximal device=0}, control-predecessors={%recv}
%send-done = token[] send-done((f32[], u32[], token[]) %send), channel_id=16, sharding={maximal device=0}
}
The current tensorflow  would end up with an error when compiling the hlo graph as follows:
Attempting to fetch value instead of handling error Internal: LHLO opcode recv is not supported.
We notice that the "xla all_to_all" communication primitive was added last month (https://github.com/tensorflow/tensorflow/blob/636833c8ff5f716dfa2eddd60a9eae905d8f715a/tensorflow/compiler/xla/service/gpu/nccl_all_to_all_thunk.cc#L65). So are the support of xla send/recv ops in scheduling?
Thanks a lot.
Will this change the current api? How?
Not sure.
Who will benefit with this feature?
This feature would enable us to develop more flexible parallelisms for large model training. such as pipeline parallelism support in xla level.
Any Other info.
None

@NEWPLAN ,
Can you please fill the issue template.Also can you please elaborate about your Feature and please specify the Use Cases for this feature. Thanks!

@NEWPLAN ,
Can you please fill the issue template.Also can you please elaborate about your Feature and please specify the Use Cases for this feature. Thanks!

Hi,
Thanks for your help. We have updated the issue with given template as above.

Hi,
Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.


Finished dungeon search with no seeds.

Somewhy the seed cracker doesn't work. I have tried with every single category but nothing works.
The dungeons are intact

Your screenshot doesn't embed.
First, did you enable the dungeons finder? If so, then what kind of configuration does the map you're playing on have? Is it all 100% vanilla? Does one seed control all of the generation of the overworld, or are there multiple seeds for structures, biomes, etc.?


Add Go sample application

Add sample application in Go language  using REST api
Add syntax highlighting for sample scripts for PowerShell, C#, Python and Go

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: saleem-mirza sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@saleem-mirza : Thanks for your contribution to the Azure documentation! The author, @bwren, has been notified to review your proposed change.

Hello team I’m wondering why bot marked this pull request as do-not-merge. Am I missing anything?

@saleem-mirza - After the article author approves the changes and adds a hash sign-off comment, the system will remove the do-no-merge label and add the ready-to-merge label.

Thanks @GitHubber17. This clarifies a lot.
One suggestion though. Is it possible to create a page with documentation about tags being used and what they means. It will give community better insight.

@bwren Hi Brian, can you respond to @saleem-mirza and/or approve this PR? Thanks.

@bwren please review and either sign off or make necessary changes.

@bwren Hi Brian, any word of wisdom is appreciated.

@saleem-mirza Sorry, I remember this one and thought that we had addressed it.  I spoke to the PM about this, and he was concerned about putting it out in our documentation since we're not in a position to support it.  Suggest that you put this out on a blog to get it to the community.

#please-close


Redirect to next parameter in RevisionsUnscheduleView

Fixes #9671.
I've moved get_valid_next_url_from_request from wagtail.admin.views.pages.utils to wagtail.admin.utils, as it's not something that's specific to pages, and we use it in other places too (e.g. wagtail.documents). I added an import in wagtail.admin.views.pages.utils for backwards compatibility in case people depend on it, but I'm happy to remove it entirely.
Please check the following:

[x] Do the tests still pass?[^1]
[x] Does the code comply with the style guide?

[x] Run make lint from the Wagtail root.

[x] For Python changes: Have you added tests to cover the new/fixed behaviour?

Please describe additional details for testing this change.
[^1]: Development Testing
[^2]: Browser and device support
[^3]: Accessibility Target

Merged in 0c62704836a29f193cd2ff4dee2a89d5a003a42f (main) and 015a00caba8de71e15dde0eccab645ded8bc01cd (stable/4.1.x).


[zlib] Build error "File does not have the expected hash"

Hi, I have a download error while installing zlib package for openvdb. I use manifest file installation:
{
  "name": "project",
  "version-string": "0.0.1",
  "dependencies": [
    "openvdb"
  ]
}

The install script I use:
VCPKGDIR=./vcpkg
VCPKG=$VCPKGDIR/vcpkg
if [ ! -d $VCPKGDIR ]; then
    git clone https://github.com/Microsoft/vcpkg.git $VCPKGDIR
fi
pushd $VCPKGDIR > /dev/null || exit
  git pull
  ./bootstrap-vcpkg.sh
popd > /dev/null || exit

$VCPKG integrate install
$VCPKG install

Host Environment

OS: Ubuntu 20.04
Compiler: revision

Failure logs
Building package zlib[core]:x64-linux...
-- Downloading https://www.zlib.net/zlib-1.2.12.tar.gz -> zlib1212.tar.gz...
[DEBUG] Feature flag 'binarycaching' unset
[DEBUG] Feature flag 'manifests' = off
[DEBUG] Feature flag 'compilertracking' unset
[DEBUG] Feature flag 'registries' unset
[DEBUG] Feature flag 'versions' unset
[DEBUG] 29949: popen(curl --fail -L https://www.zlib.net/zlib-1.2.12.tar.gz --create-dirs --output /home/kobaka/CLionProjects/astro_openvdb/vcpkg/downloads/zlib1212.tar.gz.29949.part 2>&1)
[DEBUG] 29949: cmd_execute_and_stream_data() returned 0 after   697355 us
Error: Failed to download from mirror set:
File does not have the expected hash:
             url : [ https://www.zlib.net/zlib-1.2.12.tar.gz ]
       File path : [ /home/kobaka/CLionProjects/astro_openvdb/vcpkg/downloads/zlib1212.tar.gz.29949.part ]
   Expected hash : [ cc2366fa45d5dfee1f983c8c51515e0cff959b61471e2e8d24350dea22d3f6fcc50723615a911b046ffc95f51ba337d39ae402131a55e6d1541d3b095d6c0a14 ]
     Actual hash : [ e5d60326bb0727726d4e80700ff70850329d117eb758b632bba2be8ada7a35de2ba815ba8df22d99aadc8a98987c2fd2a6cf4c0d9c29f9cb146abbb4b0fe4155 ]

[DEBUG] /mnt/vss/_work/1/s/src/vcpkg/base/downloads.cpp(741):
[DEBUG] Time in subprocesses: 697860 us
[DEBUG] Time in parsing JSON: 2 us
[DEBUG] Time in JSON reader: 0 us
[DEBUG] Time in filesystem: 45 us
[DEBUG] Time in loading ports: 0 us
[DEBUG] Exiting after 698.2 ms (697633 us)

And then goes lengthy proxy server failure guideline, which I don't have on my system. Should I manually edit portfile for zlib or wait for fix? Thanks!
Update: seems like the script tries to compare hash of .part file to the expected hash:
File does not have the expected hash:
             url : [ https://www.zlib.net/zlib-1.2.12.tar.gz ]
       File path : [ /home/kobaka/CLionProjects/astro_openvdb/vcpkg/downloads/zlib1212.tar.gz.34261.part ]
   Expected hash : [ cc2366fa45d5dfee1f983c8c51515e0cff959b61471e2e8d24350dea22d3f6fcc50723615a911b046ffc95f51ba337d39ae402131a55e6d1541d3b095d6c0a14 ]
     Actual hash : [ a8207f40b1c65ee7673a1671d85290f00d9b67a0d3c39ee1f5f472d62cd7665d2ac9f8ca3b6548866ed610d2e4a392dfe97129d44b26eac64568d5e8cb90a8c9 ]

~/Downloads$ sha512sum zlib-1.2.12.tar.gz
cc2366fa45d5dfee1f983c8c51515e0cff959b61471e2e8d24350dea22d3f6fcc50723615a911b046ffc95f51ba337d39ae402131a55e6d1541d3b095d6c0a14  zlib-1.2.12.tar.gz

~/CLionProjects/astro_openvdb/vcpkg/downloads$ sha512sum zlib1212.tar.gz.34261.part
a8207f40b1c65ee7673a1671d85290f00d9b67a0d3c39ee1f5f472d62cd7665d2ac9f8ca3b6548866ed610d2e4a392dfe97129d44b26eac64568d5e8cb90a8c9  zlib1212.tar.gz.34261.part

Thanks for posting this issue. If you don't use manifest mode, can you install zlib succeed with vcpkg?

Thanks for posting this issue. If you don't use manifest mode, can you install zlib succeed with vcpkg?

Yes, I can now.
I also found that the command to download the zlib archive using curl was downloading web page instead of the archive. So that's why the hash was not correct...
Today I checked it again, and eems like the issue was solved.

Thanks for posting this issue. This issue has been solved, I am closing this issue for now.


Monorepo for all Dart packages

Let's say I have a problem with realtime there are currently 3 repositories where an issue could be tracked: supabase-flutter, supabase-dart, realtime-dart. This is really annoying. (By the way, why is supabase-flutter still at supabase and the others at supabase-community?).
I think by combining them into one repo, but still separated packages, you get a better overview. You could use Melos by Invertase to manage them. Versioning should be easier too.

@Vinzent03

I see that supabase-flutter is moved, but issues are still split between all repos. I would move all issues to supabse-flutter/ supabase-dart and disable issues on the rest.

Thanks for reminding me of this! I have disabled issues on all sub repositories. I created some basic issue templates on the Supabase-flutter repository as well. Something that I should have done long time ago...

@Vinzent03
After all these time, I have finally implemented your idea to the sub repos 🎉

Great implementation via linking to the repo!

@Vinzent03 @bdlukaa @DanMossa
Just a heads up, but I plan to consolidate all the sub repos including yes_another_jaon_isolate into a mono repo using Melos adding all of them into the supabase_flutter repo in the coming days if there is no big obstacles. We have a few open PRs, but once they are clear, I think we are good to do. Let me know if there are any concerns with it 💪
All the repos of the sub libraries will be archived with a link in their readme to the new location within supabase-flutter.

That are great news! I'm just curious. Has anything in particular changed? Is there a similar plan for the other languages libraries? I guess the main reason is easier releasing?

@Vinzent03

Has anything in particular changed? Is there a similar plan for the other languages libraries?

At the moment, no plans for other languages, but I'm really hoping the Flutter library can lead the way, because I really think it makes sense for all the languages to have a mono repo in general.

I guess the main reason is easier releasing?

Yup, this and quality assurance. I felt a strong need after seeing this issue. https://github.com/supabase/supabase-flutter/issues/430

Closing as complete here https://github.com/supabase/supabase-flutter/pull/461


Problem when children of configurable products are not visible individually

Hi, I just installed your module and I'm trying to figure out how to use it. The first thing I noticed is that it lists all simple products even if they are children of configurable products. This then includes a url for this products that is not valid as they are not visible individually.
How can I solve this issue?
Also the generated files are .xml not .csv and are located in pub/media/run_as_root/feed
I suggest the readme to get updated

readme updated ✓

Thanks for the quick answer! Any ideas about my other question? By the way, thanks for your module!

Thanks for the quick answer! Any ideas about my other question? By the way, thanks for your module!

looking into it these days. We'll come back with more info later. Thanks for your patience!

Thanks in advance! It's positive that you aknowledge the issue. I suggest to check the existing option of the system and if the children of configurable products are set to not be visible individually to not be included...

Note: https://github.com/run-as-root/Magento-2-Google-Shopping-Feed/blob/21c78e619cb72c69b8c3609a37638c868b1ebaa5/Service/GenerateFeedForStore.php#L119 here we should add a check for product's visibility and skip all 'not visible individually' products as well.

Hm... I'm rethinking this. Maybe we should show all the individual variants with their stock, availability and separate SKU but put the link only of their corresponding parent configurable product.

Usually the process is as follows:
configurable product is visible in catalog only, child products are visible in search only. product feed websites only link to specific variants (child products) as customers usually search/find the actual variant and want to be taken to that variation in the store. If they're taken to the configurable they have to configure it again -> might drain conversion rate.
anyway: linking 'not visible individually' products is a bug and must be fixed.

In my opinion as this is how it is with magento configurable products I suggest we lead the feed to the configurable product. I don't think we have another option. But the image shown in the feed could be the one of the variant... It's not clear to me what is the best option here. For example what title should then the feed have? Nobody changes the variant title. It is the config product title with a variant word attached with dash to the original title. Not very nice to show it in the feed. Why don't we show only the configurable product and it's image in the feed and ignore the variants completely? It's because we will not have the availability and the price given to the variant or because we may lose conversion rate because we don't show all the versions?


HOP-173 API consitency

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


DJV 2.0.5 - MARK IN/OUT and GOTO IN/OUT have identical icons

DO:

open any clip

HAPPEN:

MARK IN/OUT and GOTO IN/OUT have identical icons

SHOULD:

different icons since different functions

NOTES:

on the bottom of the image I added a suggestion

I've modified the icons and they will be included with the next release.


Instead of login using sign in and sign up.

Just want to propose a simple add-on. Whenever someone visits the site they see the login button, wouldn't it be great if we can have two buttons sign in and sign up to avoid confusion? Please do let me know your thoughts.
Thanks
@rtgdk @goneall

@lkbhitesh07 Since we don't collect or store any information information on the user that would typically be in a sign-up form, I don't think we need the sign-up option typically found in other sites.
@rtgdk Any thoughts on this one?

@goneall Totally agree with you. We use sign in with github just for submitting the license. For other tools, we don't require login - so having a sign up add-on is not useful.

@lkbhitesh07 Based on the above comments, I'm suggesting we close this issue.  I do appreciate you reviewing the app and looking for improvements, however.

@lkbhitesh07 Closing this issue. Feel free to reopen if needed.


fix: parse filename from response header

fix: parse filename from resp header

The quotes need to be removed. See also the following syntax:

More details from https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Disposition

ok, i have fixed it

See the lint errors:
Error: pkg/net/http.go:334:1: exported function ParseSuggestedFilename should have comment or be unexported


Fix Windows firewall message check

Describe your changes
The no rules matched message is operating system language specific, and can cause errors
Now we check if firewall is reachable by the app and then if the rule is returned or not in two different calls:
isWindowsFirewallReachable
isFirewallRuleActive
Issue ticket number and link
Fixes # 1249
Checklist

[x] Is it a bug fix
[ ] Is a typo/documentation fix
[ ] Is a feature enhancement
[ ] It is a refactor
[ ] Created tests that fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

did a fast test on windows 10 pro italian and now the rule in windows firewall works

awesome, thanks @Fantu


nixos/icingaweb2: Fix environment.etc assignment

Motivation for this change
Backport of  #60087
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Thanks for the backport @dasJ


A suggested fix for errors when running examples and it says cannot find shared object file

So I know this has been reported before and the issue was closed (https://github.com/SFML/SFML/issues/752), where the response was to use ldconfig. I have had this issue with other software and have used a different solution to solve the problem when you are installing SFML so people don't have to go searching for the error and then use ldconfig. This CMake page discusses the issue (http://www.cmake.org/Wiki/CMake_RPATH_handling) and I've found that if you follow their recommendation (section Always full RPATH) then it resolves the issue. I added the code (shown below) between lines 9-11 of your SFML-2.3.2/CMakeLists.txt file then you don't have this problem. I'm using OpenSUSE 13.1, and after adding this code it seems to have been resolved and I can now run the examples/window executable without having to touch ldconfig. I mentioned this in the other thread but no one responded and I wasn't sure if it was because it was closed so the other people don't see any further responses. Anyways, I thought I would mention it again in case you're interested in including it in the future.
CMake Code:
SET(CMAKE_SKIP_BUILD_RPATH FALSE)
SET(CMAKE_BUILD_WITH_INSTALL_RPATH FALSE)
SET(CMAKE_INSTALL_RPATH "${CMAKE_INSTALL_PREFIX}/lib")
SET(CMAKE_INSTALL_RPATH_USE_LINK_PATH TRUE)
LIST(FIND CMAKE_PLATFORM_IMPLICIT_LINK_DIRECTORIES "${CMAKE_INSTALL_PREFIX}/lib" isSystemDir)
IF("${isSystemDir}" STREQUAL "-1")
SET(CMAKE_INSTALL_RPATH "${CMAKE_INSTALL_PREFIX}/lib")
ENDIF("${isSystemDir}" STREQUAL "-1")

Please refer to the Contribution Guidelines for further reports. We try to keep this tracker to confirmed bugs and features only.
I'm not exactly sure how this works, what I do know is that RPATH has been re-enabled and that we have an open issue for OS X.

You should be able to run the examples if you run them from the intermediate build directory, because RPATH is still available then. After installing, you have to run ldconfig.
Personally I don't think it's a good idea to add absolute and fixed RPATH values to either the executable or libraries. Copying .so files to /usr/lib (or any other related directory) and running ldconfig is just how it works. Though, normally your package manager of choice takes care of updating ld's cache after installing libraries.

I don't see how this is an issue with SFML. In my case I'd prefer to disable RPATH all together via cmake -DCMAKE_SKIP_RPATH=TRUE or when using cmake-gui you can add CMAKE_SKIP_RPATH to the list of values (it won't appear in the list) and set it to true. I don't think SFML should fiddle with RPATHs itself. This is a learning thing on the part of a Linux developer - once you learn how RPATHs work you should realize its your responsibility to configure it. CMAKE does all the heavy lifting and SFML should stay out of the way.

Is this still an issue? Are there any further comments? @cbalen, @TankOs, @StevenChristy
Otherwise I'll close this.

No I don't think so, I just wanted to point out a method to change the CMake so you don't need to use ldconfig in case other people were interested.

This is a packaging issue more than a CMake/SFML one. Closing this.


Ignore folders to reduce docker image size.

Currently, the huaweinoah/smarts:v0.4.4 docker image in Dockerhub expands to an on disk size of 9.45GB.
Hence, added a .dockerignore file to ignore folders while building the docker image, in order to reduce its size.

Great! Thanks for adding this Adai
My sense is the .dockerignore can basically be our .gitignore... we could symlink for simplicity :) there's lots more beyond the ignored directories you have here we should ignore.


Running DeepAR in loops gives different results from running the non-first experiment directly on GPU

Hello, I am required to run DeepAR with nested cross-validation and hyperparameter tuning, and I tried running the example code in a simple loop to check reproducibility, and found that the second experiment (i.e. the one with 2 layers of LSTM) has different results when it is run in a loop compared to it is run directly (i.e. running the following code with for l in [2]:). I notice this only happens on GPU (I use Tesla V100 GPU and cuda 10.2 ). I was wondering if anyone knows how to fix the cuda random seed in mxnet? Many thanks!

from gluonts.model.deepar import DeepAREstimator
from gluonts.trainer import Trainer
import random
from gluonts.core.component import get_mxnet_context
import pandas as pd
import matplotlib.pyplot as plt
from gluonts.dataset.common import ListDataset
from itertools import islice
from gluonts.evaluation.backtest import make_evaluation_predictions
from gluonts.evaluation import Evaluator
import mxnet as mx
import numpy as np
mx.random.seed(0)
np.random.seed(0)
url = "https://raw.githubusercontent.com/numenta/NAB/master/data/realTweets/Twitter_volume_AMZN.csv"
df = pd.read_csv(url, header=0, index_col=0)
training_data = ListDataset(
    [{"start": df.index[0], "target": df.value[:"2015-04-05 00:00:00"]}],
    freq = "5min")
test_data = ListDataset(
    [
        {"start": df.index[0], "target": df.value[:"2015-04-10 03:00:00"]},
        {"start": df.index[0], "target": df.value[:"2015-04-15 18:00:00"]},
        {"start": df.index[0], "target": df.value[:"2015-04-20 12:00:00"]}
    ],
    freq = "5min"
)
for l in [1,2]:
    mx.random.seed(0)
    np.random.seed(0)
    random.seed(0)
    print(get_mxnet_context())#gpu(0)
                #mx.random.seed(0, ctx=mx.gpu(0))#same as remove this line
                #mx.random.seed(0, ctx=ctx)
    mx.random.seed(0,get_mxnet_context())
    estimator = DeepAREstimator(freq="5min",
                            prediction_length=36,
                            trainer=Trainer(epochs=10),
                            num_layers=l
                           )
    predictor = estimator.train(training_data=training_data)
    forecast_it, ts_it = make_evaluation_predictions(test_data, predictor=predictor, num_samples=100)
    forecasts = list(forecast_it)
    tss = list(ts_it)
    evaluator = Evaluator(quantiles=[0.5], seasonality=2016)

    agg_metrics, item_metrics = evaluator(iter(tss), iter(forecasts), num_series=len(test_data))
    print('layers: '+str(l))
    print(agg_metrics)
    print('\n')

Excuse me, I'm faced with the exact same question. Have you find the solution yet?

It doesn't seem to be a problem with the seed, because for me the second experiment is always X when ran in loop l in [1,2] and always Y when ran in loop l in [2], where X!=Y is the problem and unexpected behavior. I tried
del estimator, predictor
gc.collect()

but that doesn't fix it either. Btw I'm using TemporalFusionTransformerEstimator.
Any ideas?


You do not use Rustup. Rustup is a preffered way to install Rust and its components

Version of VSCode: 1.11.2
Version of the extension: 0.3.14
OS: Windows 10
Description: Rust 1.17 is installed in my machine from rustup. I can call rustup from the command line, including in visual studio code terminal. But, the plugin says rustup is not in use with the message: You do not use Rustup. Rustup is a preffered way to install Rust and its components
Output of the "Rust logging" channel:
DEBUG: handleMissingRls: Rust is either not installed or installed not via Rustup
DEBUG: Configuration: updatePathToRacer: findRacerPathSpecifiedByUser: path=undefined
DEBUG: Configuration: updatePathToRacer: findDefaultRacerPath: foundPath=D:\Users\ggomez\.cargo\bin\racer.EXE
DEBUG: Legacy Mode Manager: MissingToolsInstallator: getMissingTools(): pathDirectories=["D:\\app\\client\\ggomez\\product\\12.1.0\\client_2","D:\\app\\client\\ggomez\\product\\12.1.0\\client_2\\bin","C:\\Program Files\\Docker\\Docker\\Resources\\bin","C:\\Program Files\\Microsoft MPI\\Bin\\","C:\\ProgramData\\Oracle\\Java\\javapath","D:\\app\\client\\ggomez\\product\\12.1.0\\client_1","D:\\app\\client\\ggomez\\product\\12.1.0\\client_1\\bin","C:\\Windows\\system32","C:\\Windows","C:\\Windows\\System32\\Wbem","C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\","C:\\Program Files\\Microsoft SQL Server\\130\\Tools\\Binn\\","C:\\Program Files (x86)\\Microsoft SQL Server\\Client SDK\\ODBC\\130\\Tools\\Binn\\","C:\\Program Files (x86)\\Microsoft SQL Server\\130\\Tools\\Binn\\","C:\\Program Files (x86)\\Microsoft SQL Server\\130\\DTS\\Binn\\","C:\\Program Files (x86)\\Microsoft SQL Server\\130\\Tools\\Binn\\ManagementStudio\\","C:\\Program Files\\PostgreSQL\\pg96\\bin","C:\\Program Files\\Rust stable MSVC 1.13\\bin","C:\\Program Files (x86)\\Windows Kits\\8.1\\Windows Performance Toolkit\\","C:\\Program Files (x86)\\Microsoft SQL Server\\110\\DTS\\Binn\\","C:\\Program Files (x86)\\Microsoft SQL Server\\120\\DTS\\Binn\\","C:\\Program Files (x86)\\GtkSharp\\2.12\\bin","C:\\Program Files\\Perforce","C:\\Program Files\\Perforce\\DVCS\\","C:\\Program Files\\Microsoft\\Web Platform Installer\\","C:\\Program Files\\TortoiseGit\\bin","C:\\Program Files\\dotnet\\","C:\\Program Files\\nodejs\\","C:\\Program Files\\Git\\cmd","D:\\Users\\ggomez\\.cargo\\bin","D:\\Users\\ggomez\\AppData\\Local\\Continuum\\Anaconda3","D:\\Users\\ggomez\\AppData\\Local\\Continuum\\Anaconda3\\Scripts","D:\\Users\\ggomez\\AppData\\Local\\Continuum\\Anaconda3\\Library\\bin","D:\\Users\\ggomez\\AppData\\Local\\Microsoft\\WindowsApps","C:\\Program Files (x86)\\Microsoft VS Code\\bin","C:\\Program Files (x86)\\Microsoft SDKs\\F#\\4.0\\Framework\\v4.0","D:\\Users\\ggomez\\AppData\\Roaming\\npm"]
DEBUG: Legacy Mode Manager: MissingToolsInstallator: getMissingTools(): tools={"racer":"D:\\Users\\ggomez\\.cargo\\bin\\racer.EXE","rustfmt":"rustfmt","rustsym":"rustsym"}
DEBUG: Legacy Mode Manager: MissingToolsInstallator: getMissingTools(): racer's path=D:\Users\ggomez\.cargo\bin\racer.EXE
DEBUG: Legacy Mode Manager: MissingToolsInstallator: getMissingTools(): this.missingTools = []

Execute rustc --print=sysroot and write here results.

Result of command rustc --print=sysroot:
C:\Program Files\Rust stable MSVC 1.13

where rustup, where rustc.

where rustup:

D:\Users\ggomez.cargo\bin\rustup.exe

where rustc:

C:\Program Files\Rust stable MSVC 1.13\bin\rustc.exe
D:\Users\ggomez.cargo\bin\rustc.exe

Okay.
You should either uninstall C:\Program Files\Rust stable MSVC 1.13\bin\rustc.exe or make the second one go first.

maybe is it a bug in the rust intaller or rustup?

Ah y and thanks you very much for the help.

@gabomgp,
No, you a long time ago installed Rust 1.13 using installer from rust-lang.org
That's it.

Close the issue if the problem is fixed.


Repeating / duplicate

Sometime I get duplicate apps, usually if ive made and error in my lables in docker compose. Even if i correct the errors the repeates are still there, Restarting flame doesnt remove them.
Only way to fix this is to delete them from the GUI and then refresh.

That's beacuse of the current implementation of docker integration. It can only add to the database not delete.


Tracking Issue: Deployment Policy

This probably wouldn't live here in this repo, but it's the best spot to open the issue for now.
We should integrate with and document how to use sigstore/cosign signatures to enforce policy at deployment time. I'd really rather avoid making our own admission controller if we can avoid it, but if we do have to for POC or demo purposes I vote we call it "cosigned" :)
Some existing ones we could try to integrate with:
https://siegert-maximilian.medium.com/ensure-content-trust-on-kubernetes-using-notary-and-open-policy-agent-485ab3a9423c
https://github.com/sse-secure-systems/connaisseur
https://github.com/IBM/portieris
https://kubernetes.io/blog/2019/08/06/opa-gatekeeper-policy-and-governance-for-kubernetes/
https://github.com/grafeas/kritis
I'm sure there are more! Add them to the issue and I'll merge into this list :)
Thanks to https://twitter.com/developerguyba for all the pointers :)

FYI: https://github.com/sighupio/opa-notary-connector takes a midway approach between https://siegert-maximilian.medium.com/ensure-content-trust-on-kubernetes-using-notary-and-open-policy-agent-485ab3a9423c (pure opa) and https://github.com/sse-secure-systems/connaisseur (pure Go).
We started similarly to connaisseur by having the whole logic in Go, but in the end, we decided to move the "resource parsing" and "mutatingWebhook" part in open-policy-agent allowed us to easily add CRDs by just adding a few lines of rego shifting left the feedback as much as possible. W.r.t. the pure opa approach instead, we still tried to have some kind of user friendly specific configuration handled by a dedicated sidecar container called on localhost from rego rules.

Portieris was what we would have needed, but we didn't manage to spin it up outside of IBM cloud.

Cool! I haven't really figured out OPA/rego yet but we did manage to build some built-in functions here: https://github.com/sigstore/cosign/tree/main/copasetic
I'd love for anyone with more OPA experience to help figure out how to get these into something that can enforce policy :)

Nice!
The point is that as long as you don't get your custom function into mainstream rego, deploying it will require embedding or recompiling OPA and if the function is only needed by a niche of users it's unlikely it will be merged. We ended up with the sidecar approach exactly for that reason.
Probably a plugin approach similar to what hashicorp vault does (but less secure maybe) would be better, but I'm not aware of plans to introduce them in the near future.

Haha yup, that's exactly what i realized after i wrote these. The embedding model doesn't really allow for composite.
Is there a good place we could plug stuff into an existing sidecar? Or would it make more sense to write our own?

Cool! I haven't really figured out OPA/rego yet but we did manage to build some built-in functions here: https://github.com/sigstore/cosign/tree/main/copasetic
I'd love for anyone with more OPA experience to help figure out how to get these into something that can enforce policy :)

cc: @anderseknert

You can see here what we did for opa-notary-connector, we have rego rules structured to parse resources and find all images and then check via a simple call on localhost to a sidecar container and build patches with the returned answer.
It should be really easy to write a new sidecar container for cosign and plug it in there!

@dlorenc looks like you are already in company of some great OPA/Rego devs! But if there's anything I can help out with, let's chat 😃

Thanks for the help! I think I understand that rego, but to double check:, the sidecar API is right here: https://github.com/sighupio/opa-notary-connector/blob/master/deployments/helm/opa-notary-connector/opa-config/config.rego#L79
request := {
        "url": "http://localhost:8080/checkImage",
        "method": "POST",
        "headers": {
            "X-Request-ID": uuid.rfc4122("")
        },
        "body": {
            "image": s,
        }
    }

So we would need to listen on 8080 and read POSTS to /checkImage, with the image as string in the body?
Where does the configuration for this live? How does the sidecar know keys to check against?

The configuration is passed in the values.yaml and then used to generate a secret, you can find
here an example.
repositories: []
# - name: "localhost.*"
#   priority: 10
#   trust:
#     enabled: true
#     trustServer: "https://notary-server.notary.svc.cluster.local:4443"
#     signers:
#     - role: "targets/jenkins"
#       publicKey: "H" # base64 encoded public key

So yes, the concept is, that's just the opa chart deployed as mutating webhook with a sidecar container injected and a configuration specific for the target signature store. So, in the end, the sidecar has just a simple endpoint (here) and given an image returns the sha or not if that's signed according to the given configuration (here)

Ref github.com/dlorenc/cosigned :)

One idea to enable TUF:
fulcio is the root CA
fulcio issues signing certificates (delegations via TUF) to repository owners, for those repositories
Those owners sign images with the keys corresponding to the certs, which chain to the fulcio root
Also include signed timestamps and snapshots
clients trust fulcio
Can enable trust for a specific repository, by adding that key to their trust ring
That key is signed by fulcio, so it can be trusted.
Deployment time policy to allow trusting repositories

Providing config to OPA could be done either when starting the server (for static configuration) or it could be fetched periodically from a bundle endpoint for more dynamic configuration. I had a look at the cosigned admission controller and it does look doable in OPA/Rego, but I'm not sure how to verify that without having an example admission review request and config at hand. Would that be available somewhere? I couldn't find any tests.

Let's use this to document the existing working policy engines.
We have:

https://github.com/sse-secure-systems/connaisseur
Kyverno
OPA: https://github.com/developer-guy/container-image-sign-and-verify-with-cosign-and-opa
cosigned

@dlorenc I'm curious if you're thinking about having an "official" admission controller for cosign in the sigstore org (e.g. move cosigned there, or make it part of this repo), or if admission is something that you'd rather delegate to the broader community?

I think I'd be supportive of "an official one" as long as we can convey that sigstore is also intended to work well with all the other ones. I don't want anyone to get the impression that sigstore can only be used with the official* one.
Does that make sense?

Totally, thanks!

Ref #1192


TypeError: undefined is not a function (near '...}).then(function (data, tab...')

I am getting this error when trying to use the promises way to fetch data:
Tabletop.init({
key: "PRIVATE_KEY",
simpleSheet: true
}).then(function(data, tabletop) {
console.log(data);
})}

I was using an older version of Tabletop.js. Sorry.


Defaults tail path to stdout

Changes proposed in this PR

allowing the user to not specify a path, in which case stdout is used

Why are we making these changes?
It's nice when running, for example, cs tail -f <uuid>, to not have to specify the path.

@pschorf Any thoughts on this?


Proper completion

Currently we have no compleion after namespaces ('::'), only followwed by '.' and '->', and there bad filter (probably rtags problem).

You are right, I'm working on that. For more information please take a look here:
https://github.com/Andersbakken/rtags/issues/584

It's done, there's still room for improvement, but key smart completion works fine.
Can you @lyuts please close this issue?

Thank you.


readme doc's "showPreivew" is wrong.

readme doc's "showPreivew" is wrong.

Thanks. I have updated

http://hayageek.com/docs/jquery-upload-file.php IE is not working,[IE6,IE7,IE8,IE9,IE10]


how to make portals spawn only on certain blocks

According to your testing, does the issue occur with ONLY Portal Gun mod and Immersive Portals mod and Farbic API?
Yes
Describe the issue
how to make portals spawn only on certain blocks can you tell me all the controls please
Post the log here
No response

Do you mean nether portal? You can build an obsidian frame on the other side to control the position.
If there is no matching obsidian frame on the other side, it will generate a new frame. Currently does not support limiting the type of blocks that new frame can generate on.

Said in the wiki https://qouteall.fun/immptl/wiki/Portal-Gun.html#how-to-use


when dependency modules use React.lazy, vite convert more 'default' wrapped the component

Describe the bug
When I use this code:

throw this error:

I guess vite may convert more 'default' wrapped the component, which cause the error.
Reproduction
https://github.com/SheldonWatson/vite-commonjs-isure
System Info
System:
    OS: macOS 11.2.3
    CPU: (8) arm64 Apple M1
    Memory: 139.81 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.1.0 - ~/n/bin/node
    Yarn: 1.22.10 - /opt/homebrew/bin/yarn
    npm: 7.17.0 - ~/n/bin/npm
  Browsers:
    Chrome: 92.0.4515.131
    Safari: 14.0.3
  npmPackages:
    vite: ^2.4.4 => 2.4.4

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Because @material-ui/icons/Search is a comonJS module, vite will convert it to esm during dependency pre-bundling, so .default is required for dynamic import, for example:
React.lazy(async () => (await import('@material-ui/icons/Search')).default)

Because @material-ui/icons/Search is a comonJS module, vite will convert it to esm during dependency pre-bundling, so .default is required for dynamic import, for example:
React.lazy(async () => (await import('@material-ui/icons/Search')).default)

I'm still confused, when I use import Search from '@material-ui/icons/Search', it's right,
why dynamic import will cause error?

In other words，when I use a third part dependency, what's the applicable way to use React.lazy, ?
does your way is still word for esm dependency?
React.lazy(async () => (await import('@material-ui/icons/Search')).default)

In other words，when I use a third part dependency, what's the applicable way to use React.lazy, ?
does your way is still work for esm dependency?
React.lazy(async () => (await import('@material-ui/icons/Search')).default)

Both ways are possible, only the time to load the module is different.
The import Search from '@material-ui/icons/Search method attaches default to Search，document link.
And the dynamic import import('@material-ui/icons/Search') is returning a promise, so it is asynchronous, document link.
(await import('@material-ui/icons/Search')) returns the entire module object, so .default is needed to use the default members of the module.

In other words，when I use a third part dependency, what's the applicable way to use React.lazy, ?
does your way is still work for esm dependency?
React.lazy(async () => (await import('@material-ui/icons/Search')).default)

Both ways are possible, only the time to load the module is different.
The import Search from '@material-ui/icons/Search method attaches default members to Search，document link.
And the dynamic import import('@material-ui/icons/Search') is returning a promise, so it is asynchronous, document link.
(await import('@material-ui/icons/Search')) returns the entire module object, so .default is needed to use the default members of the module.

Thx for your detailed document link，but I still want to know if (await import('@material-ui/icons/Search')) returns the entire module object，why when I use const Search =  React.lazy(() => import('@material-ui/icons/Search')) in webpack bundled project, it works well？It is webpack do the things that attaches default members to Search?

Because it is a commonJS module, vite will convert it to esm during dependency pre-bundling.
here is the converted code：

Because it is a commonJS module, vite will convert it to esm during dependency pre-bundling.
here is the converted code：

Because it is a commonJS module, vite will convert it to esm during dependency pre-bundling.
here is the converted code：

How ever, if I dynamic import local files：
const Child =  React.lazy(() => import('./child'))

it can work well,
here is my demo: https://github.com/SheldonWatson/vite-commonjs-isure

After import('@material-ui/icons/Search') conversion there is a defalut under the default,
here's my printout of the differences between them, which should help you understand：

Thx for your so detailed explain！
However,  in case of some unexpected error in production environment，I till use webpack to bundle project,
I just use vite in development environment，so your code React.lazy(async () => (await import('@material-ui/icons/Search')).default) works well in Dev environment, but throw this error in Prod environment：

I'm really confused about vite's pre-bundling that convert cjs to esm, why cause another default? Or it is webpack compatible
it?

After import('@material-ui/icons/Search') conversion there is a defalut under the default,
here's my printout of the differences between them, which should help you understand：

I'm afriad it is babel

@ygj6 It looks like an edge case for lazyImport, which is handled properly in static import. I'm working on it.

Good, I mistakenly thought the problem was caused by esbuild conversion code and I stopped analyzing the problem, fortunately you found the correct cause.

So,when will fix the bug？In next version？
---Original---
From: @.>
Date: Sat, Aug 14, 2021 16:46 PM
To: @.>;
Cc: @.>;"State @.>;
Subject: Re: [vitejs/vite] when dependency modules use React.lazy, vite convert more 'default' wrapped the component (#4553)
Good, I mistakenly thought the problem was caused by esbuild conversion code and I stopped analyzing the problem, fortunately you found the correct cause.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

@SheldonWatson  It should be the nearest version after #4596 merged. After reading commit history, I think it should be v2.5.0.

Thx，By the way，did you notice in  cjs package，requie static resource such as image will throw error,but require js is ok！
---Original---
From: "Yunfei @.>
Date: Sat, Aug 14, 2021 18:11 PM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [vitejs/vite] when dependency modules use React.lazy, vite convert more 'default' wrapped the component (#4553)
@SheldonWatson  It should be the nearest version after #4596 merged. After reading commit history, I think it should be v2.5.0.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

@SheldonWatson I haven't met such cases. It will be good to open another issue to track the problem and provide a reproduction example.

@SheldonWatson I haven't met such cases. It will be good to open another issue to track the problem and provide a reproduction example.
@ygj6 He know the problem, and I solved it by the plugin @originjs/vite-plugin-commonjs that is produced by him!

v2.5.0.

Have you fixed it? I update vite to 2.5.0，but it still doesn't work!

@SheldonWatson It's still pending and not merged https://github.com/vitejs/vite/pull/4596.


Feature/inclusion fields

Are you a current Fivetran customer?

Fivetran created PR
What change(s) does this PR introduce?

This PR introduces the ability for a user to declare fields_to_include as an argument within the salesforce_formula_utils.sfdc_formula_view() macro. If a user defines this argument then the macro will only include the specified fields in the output of the model.
Does this PR introduce a breaking change?

[X] Yes (please provide breaking change details below.)
[ ] No  (please provide explanation how the change is non breaking below.)

This PR applied breaking changes in the form of renaming some key arguments. For example:
join_to_table_first -> source_table

Is this PR in response to a previously created Issue

[X] Yes, Issue #16
[ ] No

How did you test the PR changes?

[X] CircleCi
[ ] Other (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

[X] BigQuery
[X] Redshift
[X] Snowflake
[X] Postgres
[ ] Databricks
[ ] Other (provide details below)

Provide an emoji that best describes your current mood

📨
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

@fivetran-jamie I was able to address your review notes. I would especially like your feedback on the README phrasing of the two mutually exclusive options of using the macro.
Thanks!


Fix #1659, Add custom epoch support to TIME UT

Describe the contribution
Fixes #1659

CFE_TIME_Print is only function that uses the epoch defines. Avoid use of CFE_TIME_Print to test other Time functions and specifically check for the expected seconds and subseconds.
Print that Manual Inspection Required (MIR) is required when testing CFE_TIME_Print with a custom epoch.

Testing performed

Manually ran unit tests for TIME: $ make -C build/native/default_cpu1/time test
Verified coverage on files with $ gcov cfe_time_api.c.gcno and $ gcov cfe_time_api.c.gcno
Verified correct output when using default epoch time:
[ PASS] 06.001 time_UT.c:847 - String: '1980-001-00:00:00.00000' == '1980-001-00:00:00.00000'
Verified correct output when using custom epoch time:
[  MIR] 06.001 time_UT.c:851 - (MIR) Confirm adding seconds = 0, subseconds = 0 to configured EPOCH results in time 1980-001-00:00:09.00000

Expected behavior changes
Time unit tests will now pass, even when project is using a custom epoch time.
System(s) tested on

Ubuntu 18.04 VM

Contributor Info - All information REQUIRED for consideration of pull request
Jose F. Martinez Pedraza / NASA GSFC

Does time_current_test.c also need to be updated?

Does time_current_test.c also need to be updated?

No need to update time_current_test.c. That file uses CFE_TIME_Print, but it only uses it to print out the time to log. It doesn't Assert the return value.

@excaliburtb This is the time test fix for your custom EPOCH.

CCB:2021-07-28 APPROVED with Changes

Open new issue to use configurable leap seconds

CCB:2021-07-28 APPROVED with Changes

Open new issue to use configurable leap seconds
Open issue to add macro for manual inspection (MIR)

Test overrides configured leap seconds, so no change needed.
Added #1725 and nasa/osal#1118 for MIR macro


support for Collection Type

Feature Request
Describe the feature you'd like to propose:
https://docs.oracle.com/en/database/oracle/oracle-database/12.2/lnpls/plsql-collections-and-records.html#GUID-7E9034D5-0D33-43A1-9012-918350FE148C

+1


slaves behind proxy

Hello,
I can't seem to figure out how to configure jenkins/openshift so the created slaves use my proxy settings. Do I need to customize the slaves images ?
My pipelines run but can't download anything from the internet.
Thank you for your help

I figured it out. set env variables http_proxy, https_proxy and no_proxy


Fix starting on python 3.12

Workaround for support Python 3.12 and bug https://github.com/reagento/adaptix/issues/329


Returned 'removed_indexes' in transition function in class TabularGrowthRateTransition may be missing rows that are in 'data', but not in returned 'updated'.

Please see this issue on our repo that describes the problem:
https://github.com/psrc/urbansim2/issues/123

Just to follow up on the issue Stefan found. The problem happens when some rows of the data (say households) have characteristics that are not captured by the control totals table. These can be some outlier agents from the base year that we don't want to control for and should be removed. However, the link tables (say persons) do not remove rows belonging to these outlier agents.

Thanks for reporting this.   Good to know that it was a control total issue.    Agreed that a warning about some agents not being subject to the transition model would be a nice addition.


Fixes #198

@mattgreene @richbrowne
What issues does this address?
Fixes #198
...
What's this change do?
Attempts to clarify how the agent interacts with BIG-IP and that the use of auto-sync should be avoided.
Where should the reviewer start?
review changes inline below or at http://lbaasv2-test.readthedocs.io/en/bugfix_issue198.ha-clustering/
Any background context?

@mattgreene -- let me know if you're uncomfortable with the bit about using auto-sync after creating a load balancer, I'm happy to take it out.


<EMAIL_ADDRESS>and lerna

I don't know if this is the right place for this, neither if this is a bug.
Additional context
I am using tsdx in a lerna monorepo. If I start all process at once via lerna run --parallel start, my create-react-app start process fails with Module not found: Can't resolve <path/to/module>.
My guess is the cleanup of the dist folder on watch mode collides with the parallel startup.
If this doesn't belong here, feel free to close it.
Your environment

Software
Version(s)

TSDX
0.10.0

TypeScript
3.6.3

Browser
Chrome Version 77.0.3865.120 (Offizieller Build) (64-Bit)

npm/Yarn
npm 5.8.0

Operating System
Ubuntu 19.04 VM

are we totally removing the dist folder or just wiping its contents?

@grimnomad --parallel will not cause the processes to care about their dependencies. Try running with the --stream flag instead. Lerna will then respect local dependencies and wait until the build is done.
Note that this will not work with watch tasks since they never finish.

@jaredpalmer It looks like the dist folder gets removed.
The function removing the dist folder:
https://github.com/jaredpalmer/tsdx/blob/76d7eb33e946c6dd3ebb656eabc874e392ecf012/src/index.ts#L475-L479
and the line where it is called in watch task:
https://github.com/jaredpalmer/tsdx/blob/76d7eb33e946c6dd3ebb656eabc874e392ecf012/src/index.ts#L364
@sebald Thank you for the clarification.

Would a solution be to clear the contents of the directory and not delete the folder?

Honestly i don't know. I my opinion it doesn't matter. create-react-app will not find a file and will crash.

I was using rimraf so was removing the entire folder, made a pr to instead wipe the contents inside of dist instead of removing it entirely https://github.com/jaredpalmer/tsdx/pull/272 not sure if this fixes the issue though

I have tested the watch task with the --noClean flaq as introduced in #282. Now it runs without falling.


Invalid Hypercore key error on install

Following the Getting Started guide, I tried to install Pear on my 2023 M3 MacBook Pro using npm. Below is the result:
zsh prompt% npm i -g pear
added 101 packages in 7s
zsh prompt% pear
Installing Pear Runtime (Please stand by, this might take a bit...)

Pear Runtime installed!

Finish the installation by opening the runtime app

pear run pear://runtime

Or by adding the following to your path

export PATH="/my/super/secret/path/pear/bin:$PATH"
zsh prompt% pear run pear:://runtime
Warning! To complete the Pear-Runtime installation, add the following to the beginning of your $PATH:
/my/super/secret/path/pear/bin
Until then, this request will be forwarded to the internal PEAR binary for you.
✖ Error: Invalid Hypercore key
    at decode (file:///my/super/secret/path/pear/by-dkey/7216eeac5c879a2ca1dcff14bb8c1ad47d188a8c17b13e66f36d354ea8bd3b28/1/boot.bundle/node_modules/hypercore-id-encoding/index.js:30:9)
    at parse (file:///my/super/secret/path/pear/by-dkey/7216eeac5c879a2ca1dcff14bb8c1ad47d188a8c17b13e66f36d354ea8bd3b28/1/boot.bundle/node_modules/pear-link/index.js:45:39)
    at run (file:///my/super/secret/path/pear/by-dkey/7216eeac5c879a2ca1dcff14bb8c1ad47d188a8c17b13e66f36d354ea8bd3b28/1/boot.bundle/run.js:24:31)
    at Command.run [as _runner] (file:///my/super/secret/path/pear/by-dkey/7216eeac5c879a2ca1dcff14bb8c1ad47d188a8c17b13e66f36d354ea8bd3b28/1/boot.bundle/cmd/run.js:23:47)
    at runAsync (file:///my/super/secret/path/pear/by-dkey/7216eeac5c879a2ca1dcff14bb8c1ad47d188a8c17b13e66f36d354ea8bd3b28/1/boot.bundle/node_modules/paparam/index.js:727:13)
    at Command.parse (file:///my/super/secret/path/pear/by-dkey/7216eeac5c879a2ca1dcff14bb8c1ad47d188a8c17b13e66f36d354ea8bd3b28/1/boot.bundle/node_modules/paparam/index.js:228:26)
    at module.exports (file:///my/super/secret/path/pear/by-dkey/7216eeac5c879a2ca1dcff14bb8c1ad47d188a8c17b13e66f36d354ea8bd3b28/1/boot.bundle/cmd/index.js:244:23)
    at async cli (file:///my/super/secret/path/pear/by-dkey/7216eeac5c879a2ca1dcff14bb8c1ad47d188a8c17b13e66f36d354ea8bd3b28/1/boot.bundle/cli.js:18:3)
✖ Error: Unknown [ code: (none) ] Error: Invalid Hypercore key
    at decode (file:///my/super/secret/path/pear/by-dkey/7216eeac5c879a2ca1dcff14bb8c1ad47d188a8c17b13e66f36d354ea8bd3b28/1/boot.bundle/node_modules/hypercore-id-encoding/index.js:30:9)
    at parse (file:///my/super/secret/path/pear/by-dkey/7216eeac5c879a2ca1dcff14bb8c1ad47d188a8c17b13e66f36d354ea8bd3b28/1/boot.bundle/node_modules/pear-link/index.js:45:39)
    at run (file:///my/super/secret/path/pear/by-dkey/7216eeac5c879a2ca1dcff14bb8c1ad47d188a8c17b13e66f36d354ea8bd3b28/1/boot.bundle/run.js:24:31)
    at Command.run [as _runner] (file:///my/super/secret/path/pear/by-dkey/7216eeac5c879a2ca1dcff14bb8c1ad47d188a8c17b13e66f36d354ea8bd3b28/1/boot.bundle/cmd/run.js:23:47)
    at runAsync (file:///my/super/secret/path/pear/by-dkey/7216eeac5c879a2ca1dcff14bb8c1ad47d188a8c17b13e66f36d354ea8bd3b28/1/boot.bundle/node_modules/paparam/index.js:727:13)
    at Command.parse (file:///my/super/secret/path/pear/by-dkey/7216eeac5c879a2ca1dcff14bb8c1ad47d188a8c17b13e66f36d354ea8bd3b28/1/boot.bundle/node_modules/paparam/index.js:228:26)
    at module.exports (file:///my/super/secret/path/pear/by-dkey/7216eeac5c879a2ca1dcff14bb8c1ad47d188a8c17b13e66f36d354ea8bd3b28/1/boot.bundle/cmd/index.js:244:23)
    at async cli (file:///my/super/secret/path/pear/by-dkey/7216eeac5c879a2ca1dcff14bb8c1ad47d188a8c17b13e66f36d354ea8bd3b28/1/boot.bundle/cli.js:18:3)

you added two colons in pear, ie it should be pear://runtime

Absolutely right. Thanks!


Installed. And Now?

I installed VisualRust via the latest msi installer from AppVeyor. It has been installed successfully, but if I open Visual Studio, I can't see any Templates for Rust if I open the project wizard.

I can open the file itself, I can open any file with Visual Studio... However, if I force to open the folder (where the Cargo.toml resides), it opens up, but it doesn't offer any Rust-ish tools/features, such as debugging, syntax highlighting and autocompletion.

I'm currently trying to use the Rust plugin with VS 2017 and still had a rsproj lying around (I think I tested the Rust plugin with VS 2015, which I do not have installed anymore ... I honestly don't know how I created that file 😆). It looks like this (perhaps you need to generate a unique guid, when you are trying to use it different projects):
<?xml version="1.0" encoding="utf-8"?>
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
  <PropertyGroup Label="Globals">
    <ProjectGuid>6449e950-4899-48a1-8681-cb5a310833fd</ProjectGuid>
    <ManifestPath>Cargo.toml</ManifestPath>
  </PropertyGroup>
  <Import Project="$(MSBuildExtensionsPath)\VisualRust\VisualRust.Rust.targets" />
  <Import Project="$(MSBuildThisFileName).InMemory.Targets" Condition="Exists('$(MSBuildThisFileName).InMemory.Targets')" />
</Project>

With this I could load the project, but the build hangs. Auto-completion worked only for local variables. I'll try to look further into it, when I have the time.

seems to work

@denis-golubev How can I open the rsproj file? It isn't recognized by VS

new text document-> enter it select standord opening program vs

it opens up, but it doesn't offer any Rust-ish tools/features, such as debugging, syntax highlighting and autocompletion. i can confirm (partly). debugging with rust doesnt work, autocompletion,too. furthermore, git doesnt really work.

After following the steps described by @CountOmega the solution opens. It looks like VS understands it's a Rust project. I had to enable "Show All Files" to see the project files... Also as described by @CountOmega all other features don't work.

Cargo.toml can be opened and edited, though. But working with it is really tricky.

Biuld configurations cant be edited, too.

It seems that line numbers arent really visible whilst using rust. I had to switch to on manually.

vs always wants to save a sln in addition to rsproj but you have to delete it otherwise your not able to open it

only a few key words are highlighted e.g. mut let pub. String and comments, too. but other rustish word like use blalba arent highlighted.

so you are forced to debug with rustup using the vs developer command prompt
@echo off cd C:\Users\Count Omega\Documents\Visual Studio 2017\Projects\Inventar C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\vcvars64.bat cls
batch script for debugging if it helps

When attempting to build master ( f005c247f0f30aa0d84fab655d192743de53bba8 ) myself, I've noticed that src/VisualRust/VisualRust.projitems appears to incorrectly reference the templates, which may be related.  This is my fix:
   <ItemGroup Condition="'$(Configuration)' == 'Debug'">
-    <Content Include="$(MSBuildThisFileDirectory)..\VisualRust.Templates\bin\$(Configuration)\ProjectTemplates\Rust\127\ApplicationProject.zip">
+    <Content Include="$(MSBuildThisFileDirectory)..\..\bin\VisualRust.Templates\$(Configuration)\ProjectTemplates\Rust\127\ApplicationProject.zip">
       <Link>ProjectTemplates\ApplicationProject.zip</Link>
       <IncludeInVSIX>true</IncludeInVSIX>
     </Content>
-    <Content Include="$(MSBuildThisFileDirectory)..\VisualRust.Templates\bin\$(Configuration)\ProjectTemplates\Rust\127\LibraryProject.zip">
+    <Content Include="$(MSBuildThisFileDirectory)..\..\bin\VisualRust.Templates\$(Configuration)\ProjectTemplates\Rust\127\LibraryProject.zip">
       <Link>ProjectTemplates\LibraryProject.zip</Link>
       <IncludeInVSIX>true</IncludeInVSIX>
     </Content>
-    <Content Include="$(MSBuildThisFileDirectory)..\VisualRust.Templates\bin\$(Configuration)\ItemTemplates\Rust\127\Module.zip">
+    <Content Include="$(MSBuildThisFileDirectory)..\..\bin\VisualRust.Templates\$(Configuration)\ItemTemplates\Rust\127\Module.zip">
       <Link>ItemTemplates\Module.zip</Link>
       <IncludeInVSIX>true</IncludeInVSIX>
     </Content>

I can't spot the corresponding errors in AppVeyor, no idea what the build difference is, but this might be related to the templates being missing.

Ahh - from that snippet you can also see the project and item templates were previously only included in Debug builds, whereas AppVeyor is only doing Release builds.  I've created a fix for this in https://github.com/PistonDevelopers/VisualRust/pull/286 .

Same here. Installed latest build from AppVeyor on 2017, but no project template appeared. Then I created rsproj manually and pasted  @denis-golubev 's xml and it worked. It compiles and runs, but under debugger it just fails:
1>Target "BeforeBuild" in file "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\VisualRust\VisualRust.Core.targets":
1>Done building target "BeforeBuild" in project "hello_world.rsproj".
1>Target "BeforeCompile" in file "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\VisualRust\VisualRust.Core.targets":
1>Done building target "BeforeCompile" in project "hello_world.rsproj".
1>Target "CoreCompile" in file "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\VisualRust\VisualRust.Rust.targets":
1>  Using "CargoBuild" task from assembly "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\VisualRust\\VisualRust.Build.dll".
1>  Task "CargoBuild"
1>    Task Parameter:ManifestPath=Cargo.toml
1>    Task Parameter:Release=False
1>    Running cargo in directory D:\Rust\hello_world
1>    C:\Users\Alex\.cargo\bin\cargo.exe build --message-format json
1>    MSBUILD : error MSB4166: Child node "2" exited prematurely. Shutting down. Diagnostic information may be found in files in the temporary files directory named MSBuild_*.failure.txt.
========== Build: 0 succeeded or up-to-date, 1 failed, 0 skipped ==========

And autocomplete is not working (perhaps I didn't install something? But I ran rustup component add rust-src).

Using this fix Autocompletion feature works, but building still crashes.


Master

Recursive Heuristic Algorithm and corrections for Rankings.jl v0.3.2

Recursive Heuristic Algorithm and corrections for Rankings.jl v0.3.2


TaxonomyPicker: Available when loading from localhost?

Category
[ ] Enhancement
[ ] Bug
[x] Question
Version
Please specify what version of the library you are using: [    1.16.0     ]
Expected / Desired Behavior / Question
Is the Term Store supposed to be available when loading the web part from localhost, or is this only available when packaged for production?
Observed Behavior
I build, bundle and package the web part without --ship or --production, and then deploy the sppkg file to the app catalog on my SharePoint Online dev tenant. I then check for trusting localhost:4321.
When I then add the web part to a page, and try to type in terms or open the term set browser, nothing gets loaded. gulp serve --nobrowser is running.
The sample terms seems to work as expected when I run locally (using gulp serve).

Hi @frankok!
Yes, it should be available. Please, check properties of the Taxonomy Picker in your web part.
Maybe termSetId is set to the value from other tenant or something.

The sample terms seems to work as expected when I run locally (using gulp serve).

In local workbench it just shows mock data, in SharePoint-hosted workbench it tries to load data from your actual Term Store.

Hi @frankok,
Is your question still relevant? Did you manage to make the control working in local build?

Hi, I honestly can't remember, since this issue is so old :-P
I will just close the case.


Enhance YouTube transcript retrieval logic

fixes #245
/claim #245
Summary
This PR improves the logic for handling YouTube transcript retrieval within the application. Key changes include:

Updated the tool invocation handler to check if the YouTube transcript is successfully retrieved based on the selected videos.
Improved the message filtering logic to exclude assistant messages that indicate a transcript retrieval issue if the transcript was successfully retrieved.
Added state management for transcript retrieval status to enhance user experience and feedback.
Ensured that the component correctly displays success or error messages based on the state of transcript retrieval.

Testing
https://github.com/user-attachments/assets/311c1447-031d-4232-815f-5285d8dc2e29
In the video demonstration, third video example does not have transcripts provided by Youtube. Hence throws error as expected.

@akhilender-bongirwar
Critique of the Pull Request (PR)
The PR aims to address an issue in the File Organizer 2000 Obsidian plugin where the AI assistant incorrectly states that it couldn't retrieve a YouTube transcript, even when the transcript was successfully fetched. The current approach attempts to filter out such erroneous messages on the frontend.

Analysis
Strengths:

Identifies the Problem: The PR correctly identifies that unwanted error messages are displayed to the user even when the transcript retrieval was successful.
Attempts a Fix: By filtering messages and excluding certain assistant messages based on conditions, it tries to prevent the incorrect error message from appearing.

Weaknesses:

Frontend Filtering is Fragile:

Race Conditions: The state transcriptRetrieved may not update synchronously with the arrival of messages, leading to inconsistent filtering.
Incomplete Filtering: The assistant's message may contain valuable information alongside the error message, which could be improperly filtered out.

Complexity in Message Handling:

Filtering messages based on content strings and roles adds unnecessary complexity to the component.
The approach relies on hardcoded error messages, which is not scalable or maintainable.

Root Cause Not Addressed:

The assistant should not generate incorrect error messages in the first place. The PR addresses the symptom (the message) rather than the root cause (the assistant's logic).

Recommendations for Improvement

Handle Errors at the Source

Modify the Tool Invocation Logic:

Ensure that the assistant only mentions the inability to retrieve the transcript when the retrieval actually fails.
a. Update handleToolCall Function

if (toolCall.toolName === "getYouTubeTranscript") {
const args = toolCall.args as { videoId: string };
const { videoId } = args;
try {
const transcript = await getYouTubeTranscript(videoId);
const title = await getYouTubeVideoTitle(videoId);
setSelectedYouTubeVideos(prev => [
...prev,
{ videoId, title, transcript },
]);
addToolResult({
toolCallId: toolCall.toolCallId,
result: { transcript, title, videoId },
});
// Indicate success explicitly
return { success: true };
} catch (error) {
console.error("Error fetching YouTube transcript:", error);
// Return error details to the assistant
return { success: false, error: error.message };
}
}
```
 - **b. Adjust Assistant's Response Logic**
   ```tsx

// Pseudo-code representation of assistant logic
if (toolResult.success) {
// Proceed with using the transcript
assistantMessage = I've successfully retrieved the transcript for the video titled "${title}". How can I assist you further with it?;
} else {
// Inform the user of the failure
assistantMessage = I couldn't retrieve the transcript for the YouTube video with the ID "${videoId}". ${toolResult.error};
}
```

Remove Frontend Message Filtering

Since the assistant will now only generate appropriate messages, you can eliminate the frontend filtering logic. This reduces complexity and the potential for bugs related to state management and message synchronization.
Remove the Following Code:

const errorMessages = [
"don't have access to the transcript for the YouTube video",
"couldn't retrieve the transcript for the YouTube video",
];
// ...
const filteredMessages = messages.filter(message => {
const isAssistantMessage =
message.role === "assistant" && message.content.includes("transcript");
const isErrorMessage = errorMessages.some(errorMessage =>
message.content.includes(errorMessage)
);
return !(isAssistantMessage && isErrorMessage && transcriptRetrieved);
});
```

Update the message rendering to use messages directly:

{messages.map(message => (
// ... render messages without filtering
))}
```

Improve Assistant's Prompt or Backend Logic

If using a backend AI service or language model, adjust the prompt engineering or the backend logic to handle the success and error cases more effectively.
Example Prompt Adjustment:

Before:
Whenever you attempt to retrieve a YouTube transcript, inform the user if you cannot access it.

After:
When you attempt to retrieve a YouTube transcript, only inform the user if the retrieval fails. If successful, proceed without mentioning any errors.

Provide Clear User Feedback

If the transcript is successfully retrieved, consider informing the user explicitly. This enhances the user experience by confirming that their request was fulfilled.
Example Assistant Message Upon Success:I've successfully retrieved the transcript for the video titled "Your Video Title". How can I assist you further with it?

Is There a Better Approach?
Yes, handling the error at the source (during the tool invocation) and ensuring the assistant constructs messages based on the actual outcome is a better approach. This avoids the need for frontend message filtering, reduces complexity, and provides a cleaner, more maintainable codebase.

Conclusion

Current PR Limitations: While the PR attempts to fix the issue, it doesn't address the root cause and introduces complexity through frontend filtering.
Recommended Solution: Handle success and failure cases within the tool invocation logic and adjust the assistant's response accordingly. Remove unnecessary frontend filtering.

Benefits

Reliability: Ensures that messages accurately reflect the outcome of transcript retrieval.
Maintainability: Reduces code complexity and potential bugs.
User Experience: Provides clear and accurate feedback to the user.

Improved Code Snippets

In chat.tsx:

// Remove error messages array and filtering logic
// const errorMessages = [...];
// Remove filteredMessages and use messages directly in rendering
// const filteredMessages = ...
// In handleToolCall function
const handleToolCall = async ({ toolCall }) => {
if (toolCall.toolName === "getYouTubeTranscript") {
const args = toolCall.args as { videoId: string };
const { videoId } = args;
try {
const transcript = await getYouTubeTranscript(videoId);
const title = await getYouTubeVideoTitle(videoId);
setSelectedYouTubeVideos(prev => [
...prev,
{ videoId, title, transcript },
]);
addToolResult({
toolCallId: toolCall.toolCallId,
result: { transcript, title, videoId },
});
// Return success flag
return { success: true, transcriptRetrieved: true, title };
} catch (error) {
console.error("Error fetching YouTube transcript:", error);
return { success: false, transcriptRetrieved: false, error: error.message };
}
}
// ... handle other tools
};

- **In Assistant Logic or Prompt:**
```tsx
// Ensure that the assistant constructs its response based on the success flag.

Summary
By handling success and failure cases explicitly during the tool invocation and adjusting the assistant's response logic, we can ensure accurate communication with the user without relying on fragile frontend filtering. This results in a more robust and maintainable solution.

@akhilender-bongirwar thanks for the PR. This approach does however not work consistently. Here are some suggestions on how to implement a better solution:

@aexshafii,  Thank you for your detailed feedback and suggestions. I understand your concerns regarding frontend filtering, and I agree that addressing issues at the source is typically a better approach. However, in this particular case, I chose to implement the filtering logic on the frontend for a specific reason:
Whenever I provide a YouTube video link and request a transcript, the response from the OpenAI API results from the assistant: one initiating the tool call and the other an error message indicating that the transcript could not be retrieved (shown in image below). This happens consistently, even when the transcript is successfully fetched. The error message is part of the assistant's response, which makes it difficult to prevent from being displayed on the frontend.
Since I can't control the response generation from the OpenAI API (using useChat from the ai-sdk), I realized that filtering these messages based on the context where the transcript is stored was the most reliable approach. The logic ensures that if the transcript is successfully retrieved and stored in the context, I can confidently filter out the erroneous error message. This approach guarantees that only valid messages are displayed, without impacting any further interactions regarding the video.
I acknowledge that frontend filtering adds a layer of complexity, and it's not an ideal long-term solution. However, given the constraints where I cannot modify the underlying API behavior, this solution effectively prevents the erroneous error message from being shown while maintaining the integrity of the information stored in the context. Even if I were to implement success flags as you suggested, they would still be dependent on the AI's response, which includes the error message by default. As a result, I would still need to filter the messages based on the content.

@akhilender-bongirwar thanks for your help with this issue but for now I estimated the other solution was satisfactory and introduced minimal changes. I will make sure to reward you with the bounty if we do implement this solution later on 🙏

@akhilender-bongirwar thanks for your help with this issue but for now I estimated the other solution was satisfactory and introduced minimal changes. I will make sure to reward you with the bounty if we do implement this solution later on 🙏

@aexshafii, Thank you for your consideration, but these changes correctly ensure the successful retrieval of YouTube transcripts.

@aexshafii, I just wanted to follow up, as it's been a week since I made the changes. I was wondering if you’ve had a chance to test them and whether you've encountered any issues. I made sure everything aligns with what’s shown on fileorganizer2000.com for retrieving YouTube transcripts and interacting with the content.

Thanks so much for your time, and I appreciate your feedback.


Define labels for size and priority categories

Size labels specify the estimated amount of time an issue is going to take to complete. Proposed color is #FF7F50 (Coral)
Labels:

x-small:  You only need one cup of coffee to finish it
small:  < ☕☕☕  (3)
medium: < ☕☕☕☕☕  (5)
large: < ☕☕☕☕☕☕☕☕☕☕  (10)
x-large: Split it into a project with more manageable chunks

Priority labels can be assigned by product managers as long as they don't abuse them ;) Proposed color is #FF1493 (Deep Pink)
Labels:

P1: Critical, drop whatever you are working on and work on this.
P2: Must. Must be finished this milestone.
P3: Should. Should be finished this milestone.

Sounds good.
But we are not splitting large issues anymore? Only x-large?  –  I kind of agree with that, sometimes is just large and we don't need to split it, but I'm not developing so I don't know :P

re: Labels
I like the idea of P1 and P2 (I think P3 would be the default priority in this case)
re: Sizes
Waffle offers the Fibonacci sequence as many others do as well (1, 2, 3, 5, 8, 13 points), some use a geometric sequence like (1, 2, 4, 8, 16, 32 points).
We're currently using 1, 2, 5, 8, 13 points on waffle (so we skipped the 3).
The main point in all of these (and also in @menor 's suggestion) is to have exponential growth (because we're getting less accurate in judging complexity the bigger the tasks get). Also it's important not to link them with actual hours but keep them as an abstract measurement (which makes it easier to think about the complexity of the problem itself, rather than the time spent).
I'm fine with any of the point distributions, I'd just suggest to think about bringing back X-Large as well and adjusting our voting behaviour (but having an additional 'Split / req's needed' card would make sense in that case)

I forgot about the large splitting @fabiennepimenta although I think that medium is too small to be the biggest issue, let's see what other developers think. About bringing back the x-large @JannKleen I like your idea of having a 'split' card for them, what if we call it 'Project' to keep things more consistent? everything larger than 'large' is would not be a task anymore but a 'project'
About the P3 you are right, since it's the default for the milestone I think we don't need it, the less labels the better

I agree with all these points! I would like to see the range xs-xl come back to our voting scheme as well (honestly, we have been working on l/xl issues even though they have not been voted that way). Are these 'points' just something for us down the road? I'm not sure I understand this scoring. As another point, maybe we could figure out a better way to share these issue sizes among ourselves. like if you do one xl last sprint, this sprint you take some smaller ones or something (not sure if this needs to be a "rule", but more of a suggestion?)

I'm OK with having a little chat with you at the beginning of the sprint and decide how to split the issues based on areas of knowledge/energy @heinburger I don't know if that will work, or you were thinking of something more elaborated?
To do this though, we need to make more clear when the sprint begins and end, and have all the issues for a sprint at the beginning of it (if not before)

That sounds all very good, love the idea of a 'Project'-card @menor !I'd keep the Fibonacci point distribution.

So that makes:
x-small: 1 coffee
small: 2
medium: 3
large: 5
x-large: 8
And then projects, right?

I already asked myself if it would make sense to split the estimation meeting off of the normal sprint meeting flow. Something along the lines of
Thursday: Estimation meeting
Friday: Sprint is compiled
Monday: Old Sprint ends / New Sprint starts
Thursday (1,5 weeks later): Estimation meeting
...
Also, we could maybe have ad-hoc estimations if there are important issues that we want to get into the next Sprint. I guess they should have more than one issue to estimate, so the estimates stay comparable...

@menor Sorry, I misworded. I meant staying with the current point-distribution (Fibonacci with skipped 3)

@jose - I'm not sure, but just a little more conversation (like you say) about which issues we are taking form the sprint might be cool
yeah - I think this point scheme is perfect - Yeah - @nash I like that very much

I love the idea of having fixed sprint times @JanNash, I think it will help a lot. In the sprint meeting we could also first go through all the open PR, decide what's missing to close them and assign people to finish them with a priority tag to avoid 'rotten code'. Also if we decide a task it's a project, a person should be assigned right at that moment to split the project into tasks.
Also if we do it like that @heinburger we can have an unofficial chat on every two fridays at lunch time and decide there what to do.

Copy the new point distribution from the PR discussion here:
x-small: 1 coffee
small: 3
medium: 5
large: 8
x-large: 13

I wouldn't bring back x-large but I will go with consensus.

@JannKleen @mmarder what should we do with x-large?

I would keep x-large but we should put the rule on us that those issues have to be split up.

Ok, then will keep it, my concern is that we'll need to put two tags x-large and split into tasks every time we have an extra large. I was thinking we could vote something as split into tasks in the sprint meeting and in that same moment include the issue in the sprint and assign some person to split it up.

What about a meeting for a 'review' sprint on the last friday of the sprint?
And on Monday it starts the new one.
This way we are ending the week and a sprint / we demo / show what we did in this sprint instead of doing this in the new sprint planing.
What do you think?

For me the less meetings the better, I would do it in the sprint planning. But if most of the people prefer to do it this way I am also OK

I understand that, but it would be also useful as 'retrospective' about the past sprint. Instead of making everything in the same meeting – that is exhausting.


Offer to close open files from folder being removed from workspace

When removing a folder from the workspace, if any files are still open from that workspace it may be helpful to offer to close them

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Change incorrect "lightNing" to "lighTING" in WorldEnvironment.xml

Note: for the godot-docs repo we don't care much about the git history, but for the engine repo please make sure to use explicit commit logs, and not the default "Update $filename" proposed by the GitHub online editor.
I'll merge this one as is though, I only mention it for future PRs.

[...] for the engine repo please make sure to use explicit commit logs, and not the default "Update $filename" proposed by the GitHub online editor.

@akien-mga : I don't think I've quite understood the point you were making. Would you please be so kind as to clarify whether you were advising me to

leave out the name of the file to which I'm making the changes
and
write an explicit commit message instead of a vague "Change abc.xyz".

Much obliged. :smile:

I mean that your commit log should be "Change incorrect "lightNing" to "lighTING" in WorldEnvironment.xml", not just the PR's title. (Or "Docs: Fix typo in WorldEnvironment.xml".)

See https://github.com/godotengine/godot/blob/master/CONTRIBUTING.md#be-nice-to-the-git-history and the following section.


Replace libappindicator with ksni

Using ksni and the xdg standard for tray icons on Linux unlocks missing functionality and new features (https://github.com/tauri-apps/tray-icon/issues/104 and more), as well as unblocks a GTK4 migration (https://github.com/tauri-apps/webkit2gtk-rs/issues/94).

Predefined menu items are not handled, except separator and about.
Shortcuts are ignored.

Companion PR for muda:
Export more internals so muda can be used in combination with ksni: https://github.com/tauri-apps/muda/pull/239
Tauri issue:
[feat] Use ksni crate for tray icons on Linux: https://github.com/tauri-apps/tauri/issues/11293

@amrbashir @FabianLars How do we proceed from here? The tests fail because the PR depends on https://github.com/tauri-apps/muda/pull/239.

you can make tray-icon depend on the git version of muda for now

Sorry for the delay, been a bit busy IRL, and also not sure if we want to have this in tauri v2, keep old implementation and add it in tauri v2 behind a feature flag or wait for v3

if we make v3 only about switching from gtk3 to gtk4 (which imo we should) this change could wait for v3. If v3 takes ages i think it would be better to add it in v2 if that's not too much of a headache. I wouldn't put it behind a feature flag either way unless there's something missing compared to the libappindicator implementation that i don't see rn.

Alright. Then please keep me updated.
And I updated the muda dependency.

I am actually leaning towards keeping the old implementation for now and adding this behind experimental feature flag (ksni) for both, tray-icon crate and tauri crate


Add perf tests for upload and download to file.

Add perf tests for upload and download to file.

API change check
API changes are not detected in this pull request.


avoid repeating assignment in 'SetWithTimeout' function by using 'S…

…et' method if timeout is invalid

Thanks!