Ability to Independently Change Color of Mesh and Face (of a cut)

Just looking at this video. It is a striking visual contrast to have the faces of a cut be presented in a different color than the brain mesh. This would be great to have! See: https://www.youtube.com/watch?v=ShvEzf8eXUk

closing. This feature is implemented, see the shade volume not background option of the clip plane demo.


ft: add notfound middleware to remove trailing slash

Esto funcionaria con la endpoint  "/"?

This solution looks better than using regex at the end of the URLs... I Like!!


Add AWS CLI commands for manual upload to datalake raw buckets

Related PR: https://github.com/guardian/support-service-lambdas/pull/662

 Update Zuora full export documentation


Fix broken circle CI config

@rgardler,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Refer to a spatial bounding box of video (by area)

Description
Refer to a spatial bounding box of video (by area)
Proposed Solutions
xywh media fragments (same as for images)
Related IIIF: Canvas # Fragments
Additional Background
Source: BL workshop notes
Interest: 100%

If the use case is to refer to an area for an annotation, then we would annotate the Canvas directly, not the media asset.  For example, to annotate a part of the "video" to identify an object that's depicted.
So it's not request a region from within a video, it's just refer to it. If we follow the current pattern (and I think we should), then we get this for free from the Presentation API when it supports A/V on canvases.

Summary of discussion on 2016-08-23 A/V WG Call:

Issue is about reference to spatial bounding box of a video by area (not download (#4,#47), or playback (~ #25))
Terminology: use "region" (cf. region in Image API) which is specified in terms of xywh as we use for both canvases and images
Question of whether aspect ratio comes into play? Whether we are talking about effective dimensions or actual dimensions? If we consider this use case to be about reference as opposed to request, then that means we would be referring to a region of a Canvas so this is mainly a presentation API issue.
Example uses:

Would like to be able to say "the person that you’re seeing in the background of this video in this region has this name..." as an annotation

Part of the issue when talking about regions on videos is areas/regions of interest changing over time (with still images, referring to a region/area of interest will not change over time)
Perhaps not a very common feature... maybe concentrate on more common features such as jumping to certain point in time, or certain duration of video/audio
Avalon does no not yet deal with annotation of a region of video, but it is a use case that comes up
Note that corresponding temporal reference use case is #11, being able to refer to both region and time point or range seems more common than region alone.


Check support for GridLayoutManager

Update the sample application by adding a new tab to test a GridLayoutManager

Hello @shahsurajk . As I may be interested, what exactly is it that you want to test the GridLayoutManager?

Hello @shahsurajk . As I may be interested, what exactly is it that you want to test the GridLayoutManager?

Hey @cmilousi thank you showing interest! Essentially what needs to be checked is how the lib behaves when placed with a GridLayoutManager. If it works, maybe add an example fragment to the view pager with the GridLayoutManager thing. 🤔

Hey @cmilousi thank you showing interest! Essentially what needs to be checked is how the lib behaves when placed with a GridLayoutManager. If it works, maybe add an example fragment to the view pager with the GridLayoutManager thing. 🤔


Refactor command line arguments.

Hi, @lriggs! Thanks for opening this PR!

In the file tdvt/tdvt/config_gen/datasource_list.py:

Line 385:121: E501 line too long (122 > 120 characters)
Line 44:9: F841 local variable 'e' is assigned to but never used

In the file tdvt/tdvt/tdvt.py:

Line 696:1: W293 blank line contains whitespace
Line 604:43: W291 trailing whitespace
Line 600:1: E302 expected 2 blank lines, found 1
Line 494:1: E302 expected 2 blank lines, found 1
Line 465:121: E501 line too long (329 > 120 characters)
Line 464:121: E501 line too long (212 > 120 characters)
Line 462:121: E501 line too long (356 > 120 characters)
Line 461:121: E501 line too long (289 > 120 characters)
Line 460:1: W293 blank line contains whitespace
Line 458:121: E501 line too long (164 > 120 characters)
Line 457:5: E265 block comment should start with '# '
Line 455:1: W293 blank line contains whitespace
Line 454:121: E501 line too long (232 > 120 characters)
Line 453:121: E501 line too long (224 > 120 characters)
Line 451:121: E501 line too long (121 > 120 characters)
Line 450:121: E501 line too long (124 > 120 characters)
Line 449:5: E265 block comment should start with '# '
Line 447:121: E501 line too long (240 > 120 characters)
Line 445:121: E501 line too long (133 > 120 characters)
Line 443:5: E265 block comment should start with '# '
Line 441:121: E501 line too long (167 > 120 characters)
Line 440:121: E501 line too long (134 > 120 characters)
Line 437:5: E265 block comment should start with '# '
Line 433:121: E501 line too long (154 > 120 characters)
Line 432:121: E501 line too long (134 > 120 characters)
Line 431:121: E501 line too long (145 > 120 characters)
Line 430:121: E501 line too long (131 > 120 characters)
Line 429:121: E501 line too long (143 > 120 characters)
Line 428:121: E501 line too long (150 > 120 characters)
Line 425:5: E265 block comment should start with '# '
Line 414:121: E501 line too long (122 > 120 characters)
Line 386:121: E501 line too long (137 > 120 characters)
Line 369:1: W293 blank line contains whitespace
Line 358:1: E305 expected 2 blank lines after class or function definition, found 1

In the file tdvt/test/tdvt_test.py:

Line 277:1: W293 blank line contains whitespace
Line 258:9: E265 block comment should start with '# '
Line 240:1: E302 expected 2 blank lines, found 1
Line 18:1: F401 'argparse' imported but unused

For reference: Error Code Reference, PEP8, Python code style


Missing type narrowing based on control flow analysis of logical expressions

Bug Report
🔎 Search Terms
Control-flow analysis logical
🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ

⏯ Playground Link
Playground link with relevant code
💻 Code

declare function fail(): never;

declare const a: string | null;
declare const b: string | null;

if (!a) fail();
a.charAt(0); // a is correctly narrowed to `string`

b || fail();
b.charAt(0); // Object is possibly 'null'. ts(2531)

🙁 Actual behavior
It seems that the branches of logical expressions do not impact control flow analysis, and thus the logical expression form is not equivalent to the conditional form, resulting in the type of b not being narrowed.
🙂 Expected behavior
b narrowed to the string type.

Based on #32695 I'm pretty sure that this is a design limitation and is working as expected, specifically, this rule:

the call occurs as a top-level expression statement

The fail() expression is not a top-level expression statement, so is not included in CFA.

This is unfortunate. In our case we have tons of checks of the form assert(condition, errorMessageExpression) that we realized have a significant performance cost because more often than not, errorMessageExpression is complex. We're looking at alternative styles and would really prefer using logical operators for their terseness, but would lose type narrowing.

You could consider an approach using optional chaining syntax, where the receiver object is nullified in production contexts:
debug?.assert(...);

TypeScript is doing something similar for trace logging.

You could consider an approach using optional chaining syntax, where the receiver object is nullified in production contexts

I fail to see how this is relevant. Our checks are meant to be for production, not for local debugging. The part of the check on the left-hand side of the || operator is the condition being checked/asserted, which can be arbitrary. The fail call needs to be performed conditionally solely based on the result of the check, not some environment configuration.

To clarify this was closed as "completed" but the limitation has not changed in newer versions.
It would be great to reevaluate the possibility to do this given the recent improvements in type narrowing.


Don't terminate RGBDS strings with a NUL

The man page mentions that a NUL truncates a string; this is because RGBDS maps transparently to C strings. People may want to use other terminators (hello Pokémon and its $50, though there 0 is a mostly useless char anyways), or just use 0 in the middle of their strings.
Thus, and especially as fixed-size buffers are mostly being used anyways, RGBDS should use Pascal strings instead.

Okay, I wasn't intending exactly on using a byte, but the more general idea of storing the length separately. Wasn't aware of Rust's behavior, which is basically what I'm shooting for.

If you're using C99, you can just use a flexible array member to store the data, which makes the Pascal-like approach a lot simpler:
struct string {
  unsigned length;
  char data[];
};


Better exclusion patterns documentation & support

From the following code, it seems like the exclusion patterns should be separated by :, but I couldn't find that documented anywhere.
https://github.com/Tarsnap/tarsnap-gui/commit/3489c5d11d26b2bf97c4f298d578e9eda024e7b1#diff-83ff65c94c9bc8a6390318b50bfc8b419cc96f625d744d45d053353ccfe0c28cR86-R90
I also wish I could select paths to exclude in a GUI, similarly to selecting directories to back up.

Thanks @ilyagr, your analysis looks correct.  I'm planning to re-work the file&directory selection, and I've made a note to look at excluding paths as well.


Remove aux heat from climate entity

Climate entity auxiliary heater is deprecated
https://developers.home-assistant.io/blog/2024/03/10/climate-aux-heater-deprecated
Re-implement as a switch entity under device config.

This is a distinct hvac_mode on Tekmar thermostats, but the HA climate entity doesn't have a matching HVACMode for emergency heat. Instead, the climate entity will show 'heat' mode (return HVACMode.HEAT)when the thermostat is in emergency mode since HA can't show the true mode of the thermostat.
This switch will show if the thermostat is in emergency mode (and set it). During normal operation the thermostat will not show if the emergency stage is active or not, only if it's in that mode to force operation.


Hydra jobs continue "building" if npm errors out via napalm

I've experienced this with both npm install and npm run test (by providing npmCommands to buildPackage)
Hydra logs end with the npm ERR! ... error output that typically appears before npm exits with a non-zero exit code, e.g. when a dependency can't be found or a test fails.

It might be that nix is waiting for the registry to shutdown. I’ll take a look on Monday.

Fixed in https://github.com/nmattia/napalm/commit/78cb7d391f14a33a8f7b5cfaa5ff26d97470549c

Thanks @nmattia!


[Staging and Production] Zotero does not give error message when credentials are revoked

This has the exact same behavior as issue #3748
Steps

Go to a project on which you have admin access
Go to project settings and enable and configure Zotero
Confirm that Zotero is configured and files are linked
Log on to your Zotero account.
Go to settings (in the upper right) > feeds/API
Click to edit, then revoke, the key for your most recently configured Zotero add-on.
Go to the project settings and refresh the page/ click to change the folder for Zotero.

Expected
A message would appear stating that the OSF "Could not retrieve Zotero settings at this time. The credentials associated with this Zotero account may no longer be valid. Try disconnecting and reconnecting the Zotero account on your account settings page."
Actual
There is no message to let me know that something is wrong and when I click to change the folder, the folder browser gets stuck loading.

This happens because of an underlying problem with the oauth system for citations (and Dataverse), specifically with the way we're verifying auth. We're checking only to see that one or more external accounts are associated with the osf user's account, not if that association is still valid on both the osf side and the addon side. This is also an issue for Dataverse (name -> account info -> edit account -> api token -> regenerate to test for this), and almost certainly would be for Mendeley if I could figure out how to revoke that key.
It's probably possible to make a trivial api call in the method I link above to check for HTTP4XX errors, if so that would be a solution. @lyndsysimon might know of a better way, though.


Add support for importKey('jwk').

Close #133

Codecov Report

Merging #183 (7509656) into main (a50325b) will decrease coverage by 0.16%.
The diff coverage is 89.93%.

@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
- Coverage   95.86%   95.71%   -0.16%
==========================================
  Files          20       20
  Lines        2321     2448     +127
  Branches      198      227      +29
==========================================
+ Hits         2225     2343     +118
- Misses         96      105       +9

Flag
Coverage Δ

unittests
95.71% <89.93%> (-0.16%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/kems/dhkemPrimitives/ec.ts
86.85% <82.35%> (+0.31%)
:arrow_up:

src/kems/dhkemPrimitives/x25519.ts
95.83% <91.66%> (-1.23%)
:arrow_down:

src/kems/dhkemPrimitives/x448.ts
95.83% <91.66%> (-1.23%)
:arrow_down:

src/utils/misc.ts
89.36% <91.66%> (+1.40%)
:arrow_up:

src/cipherSuite.ts
98.05% <100.00%> (ø)

src/kems/dhkem.ts
100.00% <100.00%> (ø)

src/xCryptoKey.ts
100.00% <100.00%> (ø)


Add user authentication

Setup -

User model
User route
Authentication controller

closing and re-opening pull to trigger build check action


Error in SignStream sign bank - to be avoided when we generate the new one very soon

Items with a + should not be listed separately from their counterparts without the +.
And the images are missing here.
Thanks!

Also:  attempting to copy Sign Bank info from within SignStream for the sign TOUCH causes SignStream to crash.  Not sure if the problem is with something in the Sign Bank file.  Might be worth checking this, to make sure that any such errors don't occur in the new Sign Bank...


Fix icon

Icon of adapter frontier_silicon: https://raw.githubusercontent.com/iobroker-community-adapters/ioBroker.frontier_silicon/master/admin/radio.png not gettable

should be fixed at repo


Gate: Allow build directories with space characters

Fixes the FetchContent cases when the build directory contains
spaces e.g. cmake -S . -B "build dir" -GNinja

ping?


Transfer

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Relates to #469
Special notes for your reviewer:
Release Notes:

Hi @fabianburth , changes from the past days pulled down an rebased to main.


[FLINK-35353][docs-zh]Translate "Profiler" page into Chinese

What is the purpose of the change
"Profiler "page was released in English and it should be translated into Chineses
Brief change log
translate 'docs/content/docs/ops/debugging/profiler.md'
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
The serializers: (no )
The runtime per-record code paths (performance sensitive): ( no )
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no )
The S3 file system connector: ( no )

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (no)

Hi @wuchong , I have finished the translation of the page.Could you please verify my pull request?

HI,@reswqa , I have finished the translation of the page.Could you please verify my pull request?

Hi @JingGe , thank you for the review, I have already made adjustment based on your opinion, please check my commit again.

Hi @Myasuka ,thank you for the comments, I have made changes to solve the problems, please check again.


How can I obtain current epoch in the detector forwarding?

I am going to conduct some epoch-related operations when conducting detector forwarding.

Maybe you can learn about HOOK：https://mmengine.readthedocs.io/en/latest/tutorials/hook.html


Support Python 3.12

Open Issues:

[x] Fix wheel building error
[ ] Investigate editable install failure (see coverage testing) with setuptools>=64
[ ] Ensure laz-rs-python has released wheels

Codecov Report

Merging #283 (59ecbae) into main (1df12cd) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 59ecbae differs from pull request most recent head 3536f66. Consider uploading reports for the commit 3536f66 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

@@           Coverage Diff           @@
##             main     #283   +/-   ##
=======================================
  Coverage   74.74%   74.74%
=======================================
  Files          26       26
  Lines        3231     3231
=======================================
  Hits         2415     2415
  Misses        816      816

Flag
Coverage Δ

cxx
87.21% <ø> (ø)

python
70.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1df12cd...3536f66. Read the comment docs.


Some applications doesn't work

@Timidger  Hello I tried start some various applications via dmenu but some apps doesn't work.. (gnome-terminal, krusader, gedit..)
Why?
Also I tried start way-cooler in my computer with ubuntu and xserver. There way-cooler start in window and works fine.
But when I start it in another tty where I log in and run: way-cooler in console -> so way-cooler doesn't show background, arrow is black (not white) and starting applications is very very slow.. (thunar)
Is it OK??

Assuming you have xwayland installed (which it sounds like you do, since thunar works)  please double check that your xdg-shell version matches what Way Cooler uses (v6) by doing ls -l /usr/share/wayland-protocols/unstable/xdg-shell/. You should have a xdg-shell-unstable-v6.xml file in there. If you don't, please install it (I'm not sure if it's in the main repos for Ubuntu, but you might be able to find a PPA of it somewhere. You can also try to install it manually).
Way Cooler not showing the background is interesting, are you sure you have way-cooler-bg installed (e.g does which way-cooler-bg work?). The arrow will be black, because that's the default that Wayland uses (and that currently I can't change, for various reasons).
I would check other applications if thunar's start time is slow, I found that not all apps work equally well when using xwayland. If you notice that the compositor itself is sluggish (e.g mouse moving or otherwise) that's a different problem (if you compiled from source, did you make sure to pass the --release flag to cargo to ensure it's not running in debug mode?)


UnhanlededPrimiseRejectionWarning

Hey,
I have the same problem as some others here, that the backend won't work with "npm start"
(node:4476) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'port' of undefined     at LeagueDataProviderService.getCurrentData (C:\Users\Pasca\Desktop\Stream\lol-pick-ban-ui-master\lol-pick-ban-ui-master\backend-build\data\league\LeagueDataProviderService.js:58:97)     at TickManager.runLoop (C:\Users\Pasca\Desktop\Stream\lol-pick-ban-ui-master\lol-pick-ban-ui-master\backend-build\TickManager.js:18:61)     at Timeout.timeout.setInterval [as _onTimeout] (C:\Users\Pasca\Desktop\Stream\lol-pick-ban-ui-master\lol-pick-ban-ui-master\backend-build\TickManager.js:15:47)     at ontimeout (timers.js:436:11)     at tryOnTimeout (timers.js:300:5)     at listOnTimeout (timers.js:263:5)     at Timer.processTimers (timers.js:223:10)
I tried to start powershell as admin, but wouldn't help.
Adding the league path won't help either

Please make sure your LoL-Client is actually running when starting the overlay services.
This issue normally appears when the client is offline while the LCU broker attempts to read the local connection information to it.

Found out, that this was actually a problem with the windows installation.
After a fresh reinstall the pick ban server just worked fine

Found out, that this was actually a problem with the windows installation.
After a fresh reinstall the pick ban server just worked fine


vendor: ruby-macho 2.0

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew tests with your changes locally?

This is a major version change, but nothing in it should break the calls that Homebrew is currently using.
Important changes:

FatFile.new_from_machos (which Tools.merge_machos uses) now works correctly (earlier versions didn't align Mach-O slices onto page boundaries correctly).
The entire library now has to_h support, which should make inspection/debugging a little easier.

cc @sashkab

Thanks again @woodruffw!


fix: update supported node versions

Update supported Node.js versions to LTS

:tada: This PR is included in version 2.2.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


⚠ Bofrost.lu has degraded performance

In a5997ca, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1451 ms

Resolved: Bofrost.lu performance has improved in d3f9880 after 9 minutes.


Improvement to support DB using environment variable

While using in different environments it useful to be able to select the database using environment variable instead of a hardcoded one in seed.json
This PR allows to overwrite the connection string using DB_URI env var.

Currently the seed.json file that gets generated by default contains this:
{
  "undefined": "localhost/LOCAL_DB_NAME",
  "dev": "localhost/DEV_DB_NAME",
  "prod": "localhost/PROD_DB_NAME"
}

and the keys dev and prod are used if NODE_ENV equals dev or prod.
Are you just wanting to use a different environment variable than NODE_ENV or are you just wanting to specify your db on the command line rather than in a file?

The idea was to specify the db using the command line instead of that file.

This could also be useful in specifying username/password from environment variables instead of using that file. I'm unsure how to do so right now.

You can specify it on the mongo db uri, you can specify it like this: http://mongodb.github.io/casbah/3.1/reference/connecting/#uri-style-connections-1

Version 3.0.1 now uses seed.js instead of seed.json so you can specify environment variables in that file.


Eliminate pointers passed between functions via channels, etc.

We have lots of code passing values around by passing around a pointer. For small values there is very little advantage to this, as it just puts more stress on the Garbage collector since it must check these pointers.
We should refactor this into just passing values where it makes sense.

I sometimes use it to have a unique identifier for something that will be passed to the channel and back.


Enhance set availability button

Before:

After:

:heart:

It should be only one button for confirming 👀 I think we should remove "Confirmar Inscrição"

Fixed, @MarioRodrigues10!


Teacher ratings

I made a website with a database of Lowell announcers and teacher reviews, do you guys want to integrate ratings or links to review pages into the UI? Thanks for work on arenarolodex!

Hi! Though it does seem like a good idea in theory, arenarolodex is somewhat associated with the counseling department and sponsoring a list of teacher ratings would anger many teachers and counselors and we'd definitely get into trouble. Thank you for the suggestion, though.


Add missing cell in table

Found the label1 text in the designer file

@rpetrusha, The value is indeed the literal string "Key not set".

Sorry, @Youssef1313. I'd completely overlooked line 132. I'll approve and merge your PR now. Thanks for making this correction.


Add test case for descriptor with meta + payload functions

Follow up to https://github.com/agraboso/redux-api-middleware/issues/199#issuecomment-404960106 and #200
@ztanner I added a test case here to make sure non-async and async functions were being handled in awaitWith. What do you think?
Seems ok here, but I'm thinking that it may be worth running the bundled code in lib through some tests too

Coverage remained the same at 100.0% when pulling 004a7f3507fed3eebb4237b0c3666d3ab51a7871 on nason:awaitWithAsyncFnTest into 85aa8fb91df2162e4ee3663c519c602d31c0a233 on agraboso:next.

Yeah I think the underlying problem is that the bundler is expecting the awaited function to be async, since the transpiled code tries to then it. In reality, not everyone has an async payload/meta function, so this would throw.
I think it'd be a good idea to run the tests through the bundled code, because then I think we'd see some of these use-cases fail.


Replace original in the custom inline template

Seems like removing this from the custom template I made broke editing objects in the change menu, so I put it back. Wondering if there's a way to make tests for this kind of thing now.

https://www.selenium.dev/selenium-ide/
I think we'll need something like Selenium to properly test this.

This might need further investigation. I will make an issue. I wanna get this PR out the door because it at least fixes the issue.


Network 2022-05-01 Azure Virtual Network Manager Contributions

ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[X] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
9/12
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
9/13, as estimated by NRP team (network-2022-05-01 branch owner)
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[X] I commit to follow the Breaking Change Policy of "no breaking changes"
[X] I have reviewed the documentation for the workflow.
[X] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[X] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[X] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

Changes look fine from ARM side and am signing off. You still need approval from the breaking change board for the changes though. Signing off from ARM side

@raosuhas I've removed the breaking changes in commit 2018d8f, we will take them at a different time. Do you know how to trigger reevaluation of this tag?


add header text

Added a SHEros text to a webpage and made it blue.

I have made the required changes. I changed the pull requests title and description. how do I generate a new link to submit for a second code review? @devalibello

@yusufhawwah Just resubmit the PR link

I have found the link @devalibello but I don't understand the last part of the corrections where you were talking about OPTIONAL prefix in comments. Thank you for your support.

Your project doesn't have any OPTIONAL changes. So just ignore


Implement the Request endpoint

https://devblog.uber.com/take-your-users-for-a-spin/
https://developer.uber.com//v1/endpoints/#request

:+1:  WIP?

Can do if nobody else is :yum:

@ahmetabdi  fork it?

@ahmetabdi have you started on this?
I'm looking through the code, it's a little unfortunate that the constant Uber::Request already exists. I think it should be renamed so that the Request resource can use that name.  How about Uber::ApiRequest?
It would be nice to add some tests to this gem. @sishen  do you have a preference for testing libraries/strategies? I personally would use rspec and vcr for this project.

@dylanjha @ahmetabdi Thank you, sorry that I don't have time to work on it. Feel free to change Uber::Request to Uber::ApiRequest. And both rspec and vcr are good to me.

Anyone making any headway on this? If not then in about a week I will have time to do.

I have not started on this.  Go for it @joshuaNathaniel

Will do.

Done here: https://github.com/sishen/uber-ruby/pull/5


CPU thread support?

Are we going to support the new CPU multithreading?
cc: @lcw

Eventually :)

@vchuravy you mentioned some issues to me about this during the hackathon. I recall that they were implementing shmem and scratch space. Can you elaborate a bit on how these, and any others you can think about, for the benefit of the brave soul who chooses to take this one on?

One place to look is libocca, https://libocca.org, which uses a
similar kernel abstraction and has an OpenMP backend.

Yes shared memory and scratch memory are both abstractions that currently rely on the GPU hardware to do the right thing. Shared memory is shared across a block and scratch memory is thread local.
I think I have also seen codes in Clima that will require more care so that will take a review.


Fixing build errors on ARM NEON.

I was trying to build this for an ARM platform, but ran into some problems.  Not sure if my changes are the best way to resolve them, but the code does compile now.

Thanks! I'm setting up an ARM device to test out the changes (and maybe have some sort of automated regression testing), but in principle they look good to me…

hi guys, I've independently some across several of the same issues trying to build arm.
commit
although instead of vreinterpretq_u8_u32 i went with vcgeq_u8.
is vreinterpretq_u8_u32 android specific?
[ARM Compiler toolchain Compiler Reference] (http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0491f/BABGDDDH.html)

I guess we can close this.

@james-huang I've commented on #65. Looking for vreinterpretq_u8_u32, I seem to find it in various toolchains for the NEON set in the arm-eabi, so I'm not sure it's Android specific.


enable travis CI

Oops, did I use the wrong constraint for FutureOr?

Oops, did I use the wrong constraint for FutureOr?

Yup. Thank you, Travis. 😄


[WIP]implemeted or enhanced communicatorfactory

Fixes convict-git/KoraKaagaz#62

Outdated pull requested.... please raise a new PR


About VILLAIN attack

I have reproduced your code on VILLAIN backdoor attacks using the MNIST dataset, but the attack's performance is poor. Could you share your experimental results about VILLAIN? The results of VILLAIN on MNIST is listed as bellow:
============== Backdoor ==============
Average LIA Attack Accuracy of Passive 0 (each epoch): 70.01%
Average LIA Attack Accuracy of Passive 1 (each epoch): 67.57%
Attacker 0's Manipulated Backdoor Attack Accuracy: 2/1398 (0.14%)
Attacker 0's Real Backdoor Attack Accuracy: 0/1126 (0.00%)

We got similar experimental results to yours and presented them in our paper with explanations. We are glad to share it with you, but as you know, our paper is under review and our ongoing work is based on it. So you can wait for the publication or just follow the code.


fix(FA) - Mark Ansible tests as flaky

What does this PR do?
Mark all ansible tests as flaky for fleet

Motivation
Bad impact on main pipeline :

https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/625241877
https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/624814930

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Candles not always syncronized with their health etc.

Client shoots host's candle the the host doesn't pick it up.
Players never die and seem to have an infinite amount of lives

I've started making the host the only one with the authority to set how much health a candle has

fixed in #470


Add support for Marlin-quantized models

What does this PR do?

This change adds support for Marlin-quantized models. Marlin is an FP16xINT4 matmul kernel, which provides good speedups decoding batches of 16-32 tokens. It supports quantized models with symmetric quantization, groupsize -1 or 128, and 4-bit.
Tested with:

Llama 2
Llama 3
Phi 3

Draft checking whether all tests still pass.

Fixes # (issue)
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you read the contributor guideline,
Pull Request section?
[ ] Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
[ ] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
[ ] Did you write any new necessary tests?

Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Un-drafted. I was checking if the build worked, but it seems that there is currently only an unrelated error in the Intel build.


Docs and Base class test disabled

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


UIKit has hilarious include issues

Apparently UIKit is relying on Starboard.h including UIKit.h which is a crazy weird layering inversion. Removing that causes the UIKit build to break all over the place in hilarious ways.

Fixed via #1643.


HADOOP-16685: FileSystem#listStatusIterator does not check if given path exists

HADOOP-16685: FileSystem#listStatusIterator does not check if given path exists
Changed DirListingIterator so that the constructor makes the first call to listStatusBatch. This is similar to what FileSystem#listFiles does. Added a contract test in AbstractContractGetFileStatusTest.java to validate that listStatusIterator throws a FNF exception if the given Path does not exist.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
74
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1258
trunk passed

+1
compile
1065
trunk passed

+1
checkstyle
47
trunk passed

+1
mvnsite
81
trunk passed

+1
shadedclient
955
branch has no errors when building and testing our client artifacts.

+1
javadoc
87
trunk passed

0
spotbugs
128
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
126
trunk passed

_ Patch Compile Tests _

+1
mvninstall
50
the patch passed

+1
compile
1026
the patch passed

+1
javac
1026
the patch passed

-0
checkstyle
45
hadoop-common-project/hadoop-common: The patch generated 1 new + 75 unchanged - 0 fixed = 76 total (was 75)

+1
mvnsite
80
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
816
patch has no errors when building and testing our client artifacts.

+1
javadoc
85
the patch passed

+1
findbugs
135
the patch passed

_ Other Tests _

-1
unit
555
hadoop-common in the patch failed.

+1
asflicense
45
The patch does not generate ASF License warnings.

6606

Reason
Tests

Failed junit tests
hadoop.conf.TestCommonConfigurationFields

Subsystem
Report/Notes

Docker
Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1695/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1695

JIRA Issue
HADOOP-16685

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 63c4967f93b8 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / bfb8f28

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1695/1/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1695/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1695/1/testReport/

Max. process+thread count
1346 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1695/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Fixed the checkstyle issue. TestCommonConfigurationFields failure seems unrelated and looks like it is failing for other patches as well.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
103
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1385
trunk passed

+1
compile
1156
trunk passed

+1
checkstyle
55
trunk passed

+1
mvnsite
100
trunk passed

+1
shadedclient
994
branch has no errors when building and testing our client artifacts.

+1
javadoc
84
trunk passed

0
spotbugs
128
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
126
trunk passed

_ Patch Compile Tests _

+1
mvninstall
50
the patch passed

+1
compile
1074
the patch passed

+1
javac
1074
the patch passed

+1
checkstyle
65
the patch passed

+1
mvnsite
106
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
925
patch has no errors when building and testing our client artifacts.

+1
javadoc
105
the patch passed

+1
findbugs
163
the patch passed

_ Other Tests _

-1
unit
613
hadoop-common in the patch failed.

+1
asflicense
59
The patch does not generate ASF License warnings.

7230

Reason
Tests

Failed junit tests
hadoop.conf.TestCommonConfigurationFields

Subsystem
Report/Notes

Docker
Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1695/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1695

JIRA Issue
HADOOP-16685

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 6aea78f05e35 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / ed302f1

Default Java
1.8.0_222

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1695/2/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1695/2/testReport/

Max. process+thread count
1344 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1695/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@jojochuang yeah, it doesn't look like ABFS or S3A actually overrides any of the listStatusIterator behavior, so I guess there isn't a huge benefit currently to use listStatusIterator vs. a regular listStatus(Path) call for these filesystems. I think S3A does page list results in other places, like listFiles.
For this patch, the single batch will be fetched in the constructor rather than the first call to hasNext().

didn't know it got used much. I've only just discovered how much listLocatedStatus was used.
we could adopt it as it could be better for those massive directory listings -though S3Guard complicates life there.

I think listFiles(recursive=true) was probably the more impactful change, especially for S3. It's not clear to me how much of an issue performance is with listStatusIterator.

let's just fix semantics then

Sounds good. So does this patch look okay? Any other comments before it can be merged?

The patch itself is good to me. The above discussion aren't related to the patch.
Not sure about cloud connectors, but every time I see a potential area in HDFS that worths optimizing and I don't, it always comes back biting me :)

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
74
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1319
trunk passed

+1
compile
1191
trunk passed

+1
checkstyle
48
trunk passed

+1
mvnsite
82
trunk passed

+1
shadedclient
990
branch has no errors when building and testing our client artifacts.

+1
javadoc
86
trunk passed

0
spotbugs
149
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
144
trunk passed

_ Patch Compile Tests _

+1
mvninstall
55
the patch passed

+1
compile
1176
the patch passed

+1
javac
1176
the patch passed

+1
checkstyle
49
the patch passed

+1
mvnsite
83
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
858
patch has no errors when building and testing our client artifacts.

+1
javadoc
83
the patch passed

+1
findbugs
139
the patch passed

_ Other Tests _

+1
unit
596
hadoop-common in the patch passed.

+1
asflicense
46
The patch does not generate ASF License warnings.

7095

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1695/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1695

JIRA Issue
HADOOP-16685

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux fc09c2961707 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 96c4520

Default Java
1.8.0_222

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1695/3/testReport/

Max. process+thread count
1363 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1695/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Anything else before this can be merged?

LGTM


Report accessibility plugin results

Hi all,
This is a crosspost from https://stackoverflow.com/questions/29913799/report-accessibility-plugin-results
I have the following protractor.conf
// An example configuration file.
// https://raw.github.com/angular/protractor/master/example/conf.js

exports.config = {
    // The address of a running selenium server.
 //   seleniumServerJar: './node_modules/protractor/selenium/selenium-server-standalone-2.41.0.jar', // Make use you check the version in the folder
    //seleniumAddress: 'http://localhost:4444/wd/hub',
    // Capabilities to be passed to the webdriver instance.
    capabilities: {
        'browserName': 'chrome'
    },
    framework: "jasmine2",
    onPrepare: function() {
        var jasmineReporters = require('jasmine-reporters');
        jasmine.getEnv().addReporter(new jasmineReporters.JUnitXmlReporter({
            consolidateAll: true,
            filePrefix: 'xmloutput',
            savePath: 'testresults'
        }));
    },
    // Options to be passed to Jasmine-node.
    jasmineNodeOpts: {
        showColors: true,
        defaultTimeoutInterval: 30000
    },
    plugins: [{
        chromeA11YDevTools: true,
        path: 'node_modules/protractor/plugins/accessibility'
    }]
};

Is it possible to configure protractor so that the jasmine-reporter will report also the results from the accessibility plugin?
If not, could this be a valid feature request?
Thanks,
David

This is not possible with the plugin framework. The problem is that plugins are agnostic to the test framework being used, so they do not emit test results in a way specific to jasmine-reporters.
You can get all test and plugin results in JSON format using resultJsonOutputFile in the config. I'd suggest doing that, and then processing it in any way you need.


add new school International School, Vietnam National University, Hanoi - vnuis

add new school International School, Vietnam National University, Hanoi

University site: http://www.is.vnu.edu.vn/en/

@philipto please review & approve my PR

@tuantranhuu1294 Thank you for your patience while waiting for a review and processing your request. Pull request merged.


First .pyd commit

Changed .gitignore to allow .pyd files, created folder architecture, put in JaggedArray.pyd with offsets2parents(), and also included the .cpp origin in the src folder

Great start! In many respects, this is what we're looking for, and it's looking good. There were just two points I had to make at the start:

Indent with four spaces, not tabs (you can configure your editor or IDE to emit spaces when you type the tab key).
Don't version control the .pyd files. I didn't know what they were at first—they're Windows shared libraries, not called .dll for some reason—and we should never version-control shared libraries. In your proposal, you say that the product of the project would be .pyd files for all awkward class types, but actually, it's the .cpp files we really want. (Good to know that you've successfully compiled it, though!)
* No need for the testing code and show*() functions in the C++. We can and should do that with the normal unit tests. But that doesn't have to be right now.

I committed fixes for bullets 1 and 2 above. We'll talk more later.

@davidlange6 Just adding David to this PR thread.

Okay, now the build procedure is working. Let me know when you have nothing else to add and we'll merge with master and create an awkward-cpp package in PyPI. Then we can begin the main work of implementing JaggedArrayCpp.


[TOPI] add injective scheduler for HLS backends

This PR adds initial support for schedulers of HLS backends (e.g. SDAccel, AOCL).  Optimization for performance and resource usage is a future work.
To pass tests, this PR also adds support for max, min, and some math operations to the SDAccel backend.

@tmoreau89 @comaniac @nishi-t Can you please review this PR?

Not very familiar with the TOPI, but the code generation part looks good to me.

Due to recent history change to master, we will need everyone to rebase against the current master, see https://github.com/dmlc/tvm/issues/1394 we are sorry for the inconvenience

@kazum Looks good to me. thanks

Catching up on this PR. This seems sound to me, unifying code gen between HLS languages is the right approach.

I approved the PR. @kazum could you rebase against master so we can merge it back? Thanks!

@tmoreau89 Rebased, thanks. :)


Update Library Description

Does this minor update work for you @julienrf ? Thanks!

Yes, that's perfect


Handle dropped internet connection gracefully

A dropped internet connection currently results in one of the worker threads to crash. Instead, catch the relevant errors, pause the sync and resume on reconnect.

fixed in f5da7794fce9a5e1dd1b2f02c03c77a9018397e2


Add UI to set a custom LUInet model for a Web Almond user

For testing.

We will need this feature to let people switch to different levels of model stability (nightly, alpha/beta, stable).


Updates to RawTransactions: sendRawTransaction and decodeScript

This PR fixes Issue #67, by returning a string TXID when sendRawTransaction() is called with a single transaction hex. Previously it returned an Array with a single element containing a TXID string. This is a breaking change.
This PR also uses the new rest POST bulk endpoint when calling decodeScript() with an array.
This PR includes updates to unit and integration tests. It also includes new end-to-end tests for the sendRawTransactions() endpoint variations.

:tada: This PR is included in version 2.2.10 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


After I add a new talk, I get a weired error

I add a new post using
hugo new talk/abc.md
when i start the local server I get a weired error
ERROR 2017/10/14 14:10:48 Error while rendering "page": template: theme/talk/single.html:49:31: executing "theme/talk/single.html" at <markdownify>: wrong number of args for markdownify: want 1 got 0

I cannot reproduce this on the latest Academic version.
Check that your abc.md file has a parameter called event set like event = "" (occurring after the first +++ and before the [header] section). You may also wish to update to the latest version if you are not already using it.

Closer examination revealed that any new file created does not have a preamble.


More than one hyphen in keyword causes failure

If a keyword has more than one hyphen, it will sometimes throw "Expecting property name enclosed in double quotes: line 1 column 2 (char 1)". It doesn't seem to do it with every example of this, but the ones that throw errors throw them every time. Log output attached.
error2.txt

@stellpdc Thanks for pointing this out. So this a bug that does not throw the correct error. The actual issue is that no images were found for this search query.
To test this, you can type dorman 924-5226-8 on the google images page and you would see no images are returned in the search.
I will fix the code to send correct feedback in the console (for e.g. "No Images Found").

Interesting.
Additionally, it seems that this error also occurs when the number of images returned by the search is less than the program is expecting. Since the program defaults to downloading 100, if the search only returns 26 images, then the program throws this error.

@stellpdc in cases where the images are less than the limit set in the query, you should see the following error:
Unfortunately all 100 could not be downloaded because some images were not downloadable. 26 is all we got for this search filter!
Can you give me an example query so I can reproduce this error on my end?

I've attached the keywords file and the command I'm using.
I did a little more research. I've tried the following scenarios and gotten the following results for the keyword "Dorman 071-002":

Using the command and keyword file attached to this message, the program works at first, but then errors on the above keyword with the message "Expecting property name enclosed in double quotes: line 1 column 2 (char 1)". If I delete the offending keyword from the keyword file and run the program again, it will run successfully until it gets to another keyword that returns too few images and then crash.

Running googleimagesdownload -p -e -l 25 -k "Dorman 071-002" -s large -o C:\Users\Stell\Desktop\dorman causes no error and outputs the normal "Unfortunately, all 25 could not be downloaded..." message.

Running the command in the attachment with a keyword file containing only (3) keywords with "Dorman 071-002" being the middle one causes no error, outputs "Unfortunately, all 25 could not be downloaded...", and continues the program.

As best I can tell, having too few image results only crashes the program when you have a keyword file with a huge number of keywords.
command.txt
keywords.txt

Thanks @stellpdc for the detailed description on the issue. Unfortunately I was not able to reproduce the issue that you are seeing. I have used your keyword file and the exact same query. At the time of writing I have reached keyword 202 and I do not see any errors yet.
The only thing I have changed was replace line 510 with this one:
start_line = s.find('rg_meta notranslate')
can you try that and see if that resolves the intermittent issue?

@stellpdc can you confirm if the latest update resolved your issue?


Add raiutils to PR template

Description
Add raiutils to PR template
Areas changed

npm packages changed:

[ ] responsibleai/causality
[ ] responsibleai/core-ui
[ ] responsibleai/counterfactuals
[ ] responsibleai/dataset-explorer
[ ] responsibleai/fairness
[ ] responsibleai/interpret
[ ] responsibleai/localization
[ ] responsibleai/mlchartlib
[ ] responsibleai/model-assessment

Python packages changed:

[ ] raiwidgets
[ ] responsibleai
[ ] erroranalysis
[ ] rai_core_flask

Tests

[ ] No new tests required.
[ ] New tests for the added feature are part of this PR.
[ ] I validated the changes manually.

Screenshots (if appropriate):
Documentation:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Codecov Report

Merging #1290 (034045d) into main (70895df) will increase coverage by 14.38%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1290       +/-   ##
===========================================
+ Coverage   66.05%   80.43%   +14.38%
===========================================
  Files          99       18       -81
  Lines        4569      322     -4247
===========================================
- Hits         3018      259     -2759
+ Misses       1551       63     -1488

Flag
Coverage Δ

unittests
80.43% <ø> (+14.38%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

responsibleai/responsibleai/_input_processing.py

...s/erroranalysis/_internal/error_report/__init__.py

responsibleai/responsibleai/_interfaces.py

raiwidgets/raiwidgets/explanation_dashboard.py

...bleai/responsibleai/_managers/explainer_manager.py

raiwidgets/raiwidgets/explanation_constants.py

raiwidgets/raiwidgets/error_analysis_dashboard.py

...bleai/responsibleai/_tools/causal/causal_config.py

erroranalysis/erroranalysis/_internal/utils.py

...ponsibleai/responsibleai/_managers/base_manager.py

... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70895df...034045d. Read the comment docs.


docs: copyedit readme

@subratsf and @PrabhavSF, these changes aren't live in the VSCode Marketplace.
https://marketplace.visualstudio.com/items?itemName=salesforce.salesforce-docs-markdown-preview
https://marketplace.visualstudio.com/items?itemName=salesforce.sfdocs-markdown-assistant
The docs that are currently live have typos, spelling errors, etc.


3D button

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

11 of 11 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.682%

Totals

Change from base Build<PHONE_NUMBER>9:
0.0%

Covered Lines:
13385

Relevant Lines:
13386

💛  - Coveralls


Finalize IIIF Image API version 3

Following the announcement that version 3.0 of the IIIF Image API is now in beta status and ready for implementation, this pull requests contains finishing work on the IIIF Image API version 3.0 functionality. In Detail:

reflects changes to the Image API compliance levels
fixes a minor error
adds support for version 3.0 image information response property preferredFormat
extends test coverage for IIIF Image API version 3.0 tile source and information response parsing

Thanks for the continued work on this @lutzhelm.


How to install into a private server

server folder is VRisingDedicatedServer

it's like installing mod for the client side of the game, but instead of putting it inside the client folder, you put it in the server folder instead.
I recommend you join the Discord Server for the modding community, which would be https://discord.gg/XY5bNtNm4w
there you can learn more about modding.

Is it possible to have this added in the readme or info?
If it's client side using a mod manager is easy. But theres obviously some slight guesswork if you are doing it to a private server


Separate wallet descriptors and signers

When initialising a seed wallet, seed bytes are used and saved as secret_protocol_randomness. Converting an old config with into_v1 now also creates a secret_protocol_randomness file based on the seed.
Need to test various signer configs.

Pushed d7665dd2e5ea421fbc0389032ec892e7cae503c6
Adding our own xkey signer: avoids the bug with matching fingerprints and paths.


[nzherald] Add NZHeraldIE

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[X] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[X] Searched the bugtracker for similar pull requests
[X] Checked the code with flake8

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[X] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[ ] Improvement
[X] New extractor
[ ] New feature

Description of your pull request and other information
This adds supports for videos on nzherald.co.nz (NZ news site)
Upstream request: resolves https://github.com/ytdl-org/youtube-dl/issues/28267
They use Brightcove so this extractor redirects to that once we extract the relevant player url.
From my testing there are at least two page formats for videos:

video embedded in article
dedicated video page

I notice a few other similar extractors hard code the Brightcove player and account ids. Might be a bit overkill but I've added them as a fallback here and opted to try extract them first.
Known issues:

raises unexpected extractor error for articles without a video

I notice a few other similar extractors hard code the Brightcove player and account ids. Might be a bit overkill but I've added them as a fallback here and opted to try extract them first.

I havent looked at the code yet. If the extraction of these IDs require an additional network request, it is better imo to just hardcode them since the brightcove IDs dont change

I notice a few other similar extractors hard code the Brightcove player and account ids. Might be a bit overkill but I've added them as a fallback here and opted to try extract them first.

I havent looked at the code yet. If the extraction of these IDs require an additional network request, it is better imo to just hardcode them since the brightcove IDs dont change

Ah ok. I can simplify this a lot then.


Related Stories shortcode

Sample Shortcode:
{{<featured/related-stories
  title="More Stories from the 2024 Election"
  link="/election"
  cta="Visit the Election Center →"
  limit="12"
>}}

Idea for the backlog: We could make a widget at /embed/ to build related article shortcodes.


Add HttpClientBuilder and add factory methods to HttpClient

When a user creates an HttpClient, the code looks like the following:
// Using Clients:
HttpClient client = Clients.newClient("none+http://.../", HttpClient.class);
// Using ClientBuilder:
client = new ClientBuilder("none+http://.../")
    .decorator(HttpRequest.class, HttpResponse.class, ...)
    .build(HttpClient.class);

This could be simplified if we had a dedicated builder and factory methods:
// Using factory methods in HttpClient:
HttpClient client = HttpClient.of("http://.../");
// Using HttpClientBuilder:
client = new HttpClientBuilder("http://.../") // No need to specify serialization format
    .decorator(...) // No need to specify message types
    .build(); // No need to specify client type

Closed by #680


Not triggering routines

Hi,
I created a routine, and the functionality itself is working fine, as the routine plays when it is triggered manually.
However, as soon as I try to trigger it using the virtual contact sensor it does not work.
I can see the state changing (using setstate command) from closed to open (also vice versa) in the app, but the routine does not seem to be triggered.
This is the routine:

When I use a virtual button (so not a contact switch) from some third party (which I want to get rid of), the routine is also triggered.
So it seems like the issue lies within Alexa/Amazon?
Is it possible to emulate a button instead as it seems more reliable for routine triggering?
If so what do I have to change in the code?
Thanks a lot

setstate?  Hmm, I believe updates are only processed by alexa when the state changes; so if you keep using "setstate 1" then Alexa might ignore them ("it was already open so I won't do anything").
For this reason I normally use "pushcontact" or "pushcontactbyname"; this makes it look more like a real button by sending two events (DETECTED, NOT_DETECTED).
eg from a log entry last week, we can see the incoming web api call, then the refreshing of the access token (if this fails then the skill can't send notifications), then two status update pushes.  Each update was accepted ("202 Accepted") and a routine that triggers on "Drier Button opens" successfully ran.
2024/10/18 15:47:29 Decoded body:
{
    "command": "pushcontactbyname",
    "param1": "Drier Button",
    "param2": "0"
}

2024/10/18 15:47:29 Pushing a notification to Alexa
2024/10/18 15:47:29 Refreshing auth token
2024/10/18 15:47:29 Attempting to get tokens for code: Atzr|xxxxx
2024/10/18 15:47:29 200
2024/10/18 15:47:29 Body response:
{
    "access_token": "Atza|xxx",
    "refresh_token": "Atzr|xxx",
    "token_type": "bearer",
    "expires_in": 3600
}

2024/10/18 15:47:29
{
    "event": {
        "header": {
            "namespace": "Alexa",
            "name": "ChangeReport",
            "messageId": "xxx",
            "payloadVersion": "3"
        },
        "endpoint": {
            "scope": {
                "type": "BearerToken",
                "token": "Atza|xxx"
            },
            "endpointId": "switch-000012"
        },
        "payload": {
            "change": {
                "cause": {
                    "type": "PHYSICAL_INTERACTION"
                },
                "properties": [
                    {
                        "namespace": "Alexa.ContactSensor",
                        "name": "detectionState",
                        "value": "DETECTED",
                        "timeOfSample": "2024-10-18T15:47:29.630158594Z",
                        "uncertaintyInMilliseconds": 0
                    }
                ]
            }
        }
    },
    "context": {
        "properties": [
            {
                "namespace": "Alexa.EndpointHealth",
                "name": "connectivity",
                "value": {
                    "value": "OK"
                },
                "timeOfSample": "2024-10-18T15:47:29.630158594Z",
                "uncertaintyInMilliseconds": 0
            }
        ]
    }
}

2024/10/18 15:47:29 Running in region: us-east-1
2024/10/18 15:47:29 Using API endpoint: https://api.amazonalexa.com/v3/events
2024/10/18 15:47:29 Status response: 202 Accepted
2024/10/18 15:47:29 Body response:
2024/10/18 15:47:29 Pushing a notification to Alexa
2024/10/18 15:47:29 No refresh needed
2024/10/18 15:47:29
{
    "event": {
        "header": {
            "namespace": "Alexa",
            "name": "ChangeReport",
            "messageId": "xxxxx",
            "payloadVersion": "3"
        },
        "endpoint": {
            "scope": {
                "type": "BearerToken",
                "token": "Atza|xxxx"
            },
            "endpointId": "switch-000012"
        },
        "payload": {
            "change": {
                "cause": {
                    "type": "PHYSICAL_INTERACTION"
                },
                "properties": [
                    {
                        "namespace": "Alexa.ContactSensor",
                        "name": "detectionState",
                        "value": "NOT_DETECTED",
                        "timeOfSample": "2024-10-18T15:47:29.72568606Z",
                        "uncertaintyInMilliseconds": 0
                    }
                ]
            }
        }
    },
    "context": {
        "properties": [
            {
                "namespace": "Alexa.EndpointHealth",
                "name": "connectivity",
                "value": {
                    "value": "OK"
                },
                "timeOfSample": "2024-10-18T15:47:29.72568606Z",
                "uncertaintyInMilliseconds": 0
            }
        ]
    }
}

2024/10/18 15:47:29 Running in region: us-east-1
2024/10/18 15:47:29 Using API endpoint: https://api.amazonalexa.com/v3/events
2024/10/18 15:47:29 Status response: 202 Accepted
2024/10/18 15:47:29 Body response:
2024/10/18 15:47:29 Handler ended:
{
    "Answer:": "Update Success"
}

You should check your logs to ensure the update messages are being accepted by Alexa and also test with pushcontact (you may want to do this twice to ensure you're starting from an "off" state).

Hi, thanks for the help again. I have noticed that it used the false API events endpoint. When I manually changed it to the correct one it worked.

Ah good, that might have been something left over from when you testing things to fix the regional problem you had.
I'm glad I made this thing write lots of log messages :-)


when will you release digits for windows,

there's one caffe-windows  at http://pan.baidu.com/s/1eQ6bWK6

Windows is not officially supported even in Caffe. I've done my best to keep the code in DIGITS platform-independent though (with a few exceptions, like in digits.config), so it shouldn't be too much work to get it running. At present, however, there is no plan to begin supporting Windows. If you do try to implement it yourself, I would love to hear how it goes and would be happy to provide any advice that I can.

@lukeyeager : Caffe is supported on windows by Microsoft now. check the official branch here : https://github.com/Microsoft/caffe
now I guess porting Digits to windows is rather easy compared to the time, caffe was'nt on windows!

@Coderx7 That's right. I've already tried to use Digits on Windows with that Windows Caffe version and I could do it (check the last comment here: https://github.com/willyd/caffe-builder/issues/6)

@lunzueta : Great job ;)
now I'm impatiently waiting for your guide on how to get DIGITS to work on windows ;)

@Coderx7 Probably not the best way, but here is a very brief guide of what I did:

Install Python. In my case, I installed Anaconda (https://www.continuum.io/downloads). Optionally, you can also install PyCharm (https://www.jetbrains.com/pycharm/) to configure and run the Python projects in a more visual way.
Install Graphviz for Windows (http://www.graphviz.org/Download_windows.php) and include its bin directory in the 'path' environment variable.
Checkout the 'windows' branch of Caffe (https://github.com/BVLC/caffe/tree/windows) and compile it (quite straightforward to do this, just follow the instructions explained there).
Include the 'caffe' folder generated when compiling 'pycaffe' (the one inside the 'CAFFE_PATH\Build\x64\Release\pycaffe' folder), in the folder 'C:\Anaconda2\Lib\site-packages', so that Caffe can then be imported as an external library in your Python project.
Checkout Digits from its Github repo.
Open a Windows Command Prompt, go to the folder where Digits is installed and run this: python -m pip install -r requirements.txt
Then, run this: python digits-devserver and you'll be able to see Digits on http://localhost:5000 and use it normally. I wasn't able to run the 'digits-server' bash file yet, but I guess this can also be "windows"-ized with some more dedication.

Hope this helps.

Great job indeed ;)
Thanks a gazillion ;-)

@lunzueta : I'm getting an error when I try to run digits-devserver,
T:\DIGITS-master>python digits-devserver
Default value for caffe_root "<PATHS>" invalid:
        caffe binary not found in PATH
==================================== Caffe =====================================
Where is caffe installed?

        Suggested values:
        (P*) [PATH/PYTHONPATH] <PATHS>

I Imported caffe successfully,and also added the caffe bin directory (Build\X64\Release\pycaffe\caffe) as well, yet this error is happening.
I would really appreciate a guidance here.
Thanks in advance

@Coderx7 Hi. Now I'm testing all this in another PC to be sure that I didn't miss anything in the explanation above, but I'm still on it. Maybe this is happening because you should also add this directory to the 'path' environment variable: 'CAFFE_PATH\Build\x64\Release'. Let me know.

@lunzueta :Hi, Actually I have set the Path environment variable as well, this actually looks like this:
%CAFFE_ROOT%\pycaffe\caffe;%CAFFE_ROOT%
in which CAFFE_ROOT is a user variable with the value of : T:\Caffe\Build\x64\Release.
I also tried logging off and even restarting my PC, still no luck.
should I add caffe to the python path as well? I'm not a python coder you know!

@Coderx7 , I modified the ./digits/config/caffe_option.py, line 87 to let DIGITS know where the caffe.exe is. Then modify line 197 from parse_version(0,11,0) to parse_version(0,12,0) to let DIGITS know that the caffe.exe is built by Visual Studio 2013. Hope these hints would help you.

@happynear : Thanks alot , the server is now running. but I dont know if this is related to this or not.
I tried running the main.py in order to download the mnist dataset and give it a try, but I get the few parameters error .
I am doing it like this :
T:\DIGITS-master>tools\download_data\main.py mnist /mnist usage: main.py [-h] [-c] dataset output_dir main.py: error: too few arguments
and this :
T:\DIGITS-master>tools\download_data\main.py mnist  T:\DIGITS-master\mnist usage: main.py [-h] [-c] dataset output_dir main.py: error: too few arguments
which as you can see doesnt work!.
by the way the mnist folder is there , so I dont know whats causing this!

@Coderx7 I've just installed everything in another PC, following the "brief guide" I explained above, and also including 'CAFFE_PATH\Build\x64\Release' in the 'path' environment variable, and I could also run it correctly. @happynear why are those modifications you mention needed?

@lunzueta : I dont know, I just followed what you said and that didnt work for me, I added the caffes release  folder and its executable path plus the address of the caffe folder inside pycaffe folder and nothing worked! until I did as @happynear suggested.
By the way I'm facing some weird issues at the moment.
the server is running just fine.
I can easily create the mnist dataset
but when I try to create a model and train the mnist dataset it fails!
Train Caffe Model Error

    Initialized at 10:40:46 PM (1 second)
    Running at 10:40:48 PM (0 seconds)
    Error at 10:40:48 PM
    (Total - 1 second)

ERROR: [Error 2] The system cannot find the file specified

Traceback (most recent call last):
  File "T:\DIGITS-master\digits\scheduler.py", line 484, in run_task
    task.run(resources)
  File "T:\DIGITS-master\digits\task.py", line 202, in run
    env=env,
  File "L:\Anaconda2\lib\subprocess.py", line 710, in __init__
    errread, errwrite)
  File "L:\Anaconda2\lib\subprocess.py", line 958, in _execute_child
    startupinfo)
WindowsError: [Error 2] The system cannot find the file specified

Dont know whats going on here :-/ !

Ok, I deleted everything and started from scratch.
I installed Anaconda2 ( the latest version ) .
Followed @lunzueta 's guide and then applied the @happynear 's modification actually in two places inside caffe_options.py (line 114 and 210 like following):
line 114: executable = 'T:/Caffe/Build/x64/Release/caffe.exe'#os.path.join(path, program)
line 210: executable = 'T:/Caffe/Build/x64/Release/caffe.exe'#os.path.join(value, 'build', 'tools', 'caffe')
and I didnt change anything else (didnt need to change line 196 (return parse_version(0,11,0) )
and to my astonishment, everything is working just fantastic!
Thanks again guys .
(by the way I noticed when I tried to use Show visualizations and statistics, python.exe crashed. if I uncheck it and classify everything is fine. but with that option checked the python crashed. Any Idea on this?

@Coderx7 Good to know it worked in your side too. Meanwhile, I did some more tests in my side comparing what I could get in Linux and also in Windows. Mnist + LeNet worked in the same way in both, except when I marked the option "Show visualizations and statistics" for testing. In Windows it crashed. So, I guess that we still can't say the compatibility issue is completely solved. I'm not sure if this is because of Digits code or because of the Caffe version we are using, which isn't Nvidia's Caffe fork.

@Coderx7 Good to know that it also worked in your side. Yes, I also got that error you mention when Show visualizations and statistics is activated when testing. So, I guess we still can't say that the compatibility issue is completely solved. I don't know if this happened because of Digit's code or because we aren't using Nvidia's Caffe fork.

@lunzueta yes, you are right. I couldn't either use debugging to know for sure whats going on.
I listened to your suggestion and installed Pycharm the community edition, but when ever I tried to run debug! everything froze! tried it for couple of times, yet nothing changed. the same thing made me use print and log for debugging ! and you saw how that turned out!
dont know what the problem is though. If debugging worked, I'm 100% sure we could figure out the cause much sooner.

There might be a temporary solution.  If I loaded h5py before caffe, the problem seemed to disappear.  The hdf5 DLL loaded by h5py and Caffe were different.  h5py is using a newer version, while the one in nuget (for Caffe) is old.

Hello! This is my first post in github, so please forgive me if I did sth wrong.
Hmm... Strange, I followed @lunzueta  guide and everything is working for me! (Including the Show visualizations and staticstics).
Here is what I have done:

I compiled caffe from @happynear's branch (follow his exact instruction, especially the python wrapper stuff):
https://github.com/happynear/caffe-windows
I downloaded Anaconda2 as my python. Installed it, got an error that need to be ignored at the end of the installation, but somehow it still works for me.
Pycaffe from happynear branch has some requirement. I have to remove level-db and protobuf from the requirement.txt under caffe-windows-master/python, do a pip install just like @lunzueta said (for pycaffe, NOT for DIGITS, that's a later step). Then I followed @happynear to recompile level-db and install protobuf manually (the instruction is in @happynear 's caffe branch in the link above).
I made sure to correctly modified the python include and python library path in happynear's caffe Visual studio project to point them to Anaconda2 include and libs directories. Then I compile pycaffe.
I then copied the caffe folder under caffe-windows-master/python to Anaconda2/Lib/site-packages.
Then I download DIGITs repository:
https://github.com/NVIDIA/DIGITS
Again, I check the requirements.txt under DIGITS-master/ and make sure to remove level-db or protobuf. Then pip install the requirements.
** NOTE ** For pip install to work smoothly, I have to install Visual C++ for Python:
https://www.microsoft.com/en-us/download/details.aspx?id=44266
And also create a bat file with all the required paths to binaries and dlls, then run the bat file as ADMINISTRATOR. The content of the bat file for DIGITS-master python requirements.txt is:

REM If this bat file is run as administrator,
REM the program will start from %SystemRoot%\System32
REM Thus, first go to the folder where the bat file is run
cd /D %~dp0
PATH=.;^
..\Anaconda2;^
%SystemRoot%\System32;^
%SystemRoot%
python.exe -m pip install -r requirements.txt
pause
Forgot to mention: you need a similar bat file for pycaffe's requirements.txt.
8. The key difference is that** I don't modify caffe_options.py**. Instead, I created a bat file that contain the paths to all required binaries and dlls. One thing I noticed is that somehow the PATH environment for digits-devserver MUST BE ABSOLUTE PATH, meaning you can't use "..". The content of digit server running bat file is:
REM If this bat file is run as administrator,
REM the program will start from %SystemRoot%\System32
REM Thus, first go to the folder where the bat file is run
cd /D %~dp0
PATH=.;^
D:\University of Oklahoma\Projects\Caffe\Anaconda2;^
D:\University of Oklahoma\Projects\Caffe\caffe-windows-master\3rdparty\bin;^
D:\University of Oklahoma\Projects\Caffe\caffe-windows-master\bin;^
D:\University of Oklahoma\Projects\Caffe\Graphviz2.38\bin;^
C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v7.5\bin;
%SystemRoot%\System32;^
%SystemRoot%
python.exe digits-devserver
pause
Here I put DIGITS-master, Anaconda2, caffe-windows-master, and Graphviz2.38 into one single place called D:\University of Oklahoma\Projects\Caffe. The bat file is named run_digit.bat and is put in D:\University of Oklahoma\Projects\Caffe\DIGITS-master.
After that, everything is working (except Torch, which I can't find any source to compile on Windows using Visual Studio, but it's not required anyways).
FYI, I'm compiling caffe with compute capability of 30 (I have GTX 660 card). I tested it on both Windows 7 and Windows 10 Enterprise 64 bit. I guess "Show Visualization and statistics" option doesn't work for you guys because you modified the caffe-options.py?

Thanks for the information.  I built my caffe from https://github.com/microsoft/caffe, and installed Python 2.7.11 64-bit from official Python site.  The h5py package was from UCI's unofficial python package site.

Hi,
first, thank you all for the hard work to port DIGITS to win.
I followed the guides mentioned in this thread, repeated the installation process several times, but everytime I get following error while running training (I had no trouble creating lmdb sets):
Traceback (most recent call last):
File "d:\Toolkits\DIGITS\digits\scheduler.py", line 484, in run_task
task.run(resources)
File "d:\Toolkits\DIGITS\digits\task.py", line 250, in run
self.after_runtime_error()
File "d:\Toolkits\DIGITS\digits\model\tasks\caffe_train.py", line 937, in after_runtime_error
output = subprocess.check_output(['tail', '-n40', self.path(self.CAFFE_LOG)])
File "C:\Anaconda2\lib\subprocess.py", line 566, in check_output
process = Popen(stdout=PIPE, *popenargs, **kwargs)
File "C:\Anaconda2\lib\subprocess.py", line 710, in init
errread, errwrite)
File "C:\Anaconda2\lib\subprocess.py", line 958, in _execute_child
startupinfo)
WindowsError: [Error 2] The system cannot find the file specified
Unfortunatelly I'm no pythonist so I have no clue how to resolve this. I'm using the Microsoft caffe branch successfully for some time now and it alone is working fine. It'd be nice to have some gui though :)
BTW. I know that caffe.exe is accessible from the caffe_output.log. So the problem is probably somewhere else.
Does anybody have the same issue ?

The system cannot find the file specified error indicates it can not find your caffe, at least this was in my case.
try using the full path for caffes executable, or use the one I myself used! here
hope this helps

@Coderx7 Thank you. Actually I set the path to caffe.exe explicitly (edited the lines 114 & 210 as you suggested in your comments ). And by checking the caffe_output.log file I can see that the network is configuring ( ie caffe.exe is running ) and than stops suddenly before the training starts :
...
I0507 21:05:03.662497 10716 net.cpp:217] pool2 needs backward computation.
I0507 21:05:03.662497 10716 net.cpp:217] norm2 needs backward computation.
I0507 21:05:03.662497 10716 net.cpp:217] relu2 needs backward computation.
I0507 21:05:03.662497 10716 net.cpp:217] conv2 needs backward computation.
I0507 21:05:03.662497 10716 net.cpp:217] pool1 needs backwar*** Check failure stack trace: ***
thanks for the link. I'll give it a try...

@Coderx7 So I checked out your repo, followed your instructions (changed the paths to executable in digits config, made sure all path variables are set correctly, I even have caffe.exe folder in path for sure ), but the problem persists. I will probably start once again from scratch, but I'm skeptical. BTW, when including pycaffe to Anaconda2 site-packages, do you just copy the whole caffe folder (located in /caffe/build/x64/Release/pycaffe/) to site-packages folder? Also do you use 32bit or 64bit installation of Anaconda?
Thanks for your help.

@monkeyonagazeboo : yes the contents of pycaffe need to be copied to site-packages folder.
I'm using Anaconda 64bit (2.7 I guess)

I don't know. Once more I uninstalled/deleted everything (caffe, digits, anaconda), re-installed and re-build using the @lunzueta guide, but the problem stays the same. Next time I will try another machine, after I get some. Thanks for your time.

I hope you figure it out soon.
Good luck ;-)

@Coderx7 So I have found out what the problem was. The machine I was testing digits on has graphics card with less graphic RAM and the caffe training was failing with cuda out of memory error. This can be easily seen by running the same solver from command line. By using the smaller batch size the error disappeared. I don't understand why is the digits failing with 'File not found' instead of CUDA out of memory message, but everything seems to work fine now, including the visualization and statistics feature. Thank again for your support.

@monkeyonagazeboo I'm glad to hear you made it as well ;-)

any news about this? someone successfully ran DIGITS on windows?

@andrewssobral: we all did! read the posts and you will know the process.

Hello,
Although I followed some of the instructions in this thread, I’m still struggling with getting DIGITS to work using Windows.
I use following caffe-version : [https://github.com/BVLC/caffe/tree/windows]
And I try to use DIGITS 3.
Building caffe was successful, and caffe is running using a command prompt or powershell.
But when I launch python digits-devserver in a command prompt, it fails with following message :
'Your Caffe does not have version info.  Please upgrade it.'
And it also produces : ‘Where is caffe installed’ ?
So, since I told the location of the executable (‘C:\Programs\caffe-windows\Build\x64\Release\caffe.exe’), I suppose that the main problem is that he cannot get a version while executing info_dict = cls.get_info(executable) (line 154 in caffe_option.py)
Does anyone know what I could try more to fix this problem?
Thanks in advance.

@JVR32 : Hello! I'm not sure you read my post yet, but it seems like DIGITS changes working directory while running, so you probably want to make a .bat file like I said in my previous post and include the absolute path to your caffe.exe.
The error "not have version info" is probably because you have not copied the compiled caffe python library into your python site packages location (in my downloaded caffe visual studio solution, there is a caffe-python project, which you need to make sure you can compile).
Again, please spend some time reading my post. I know it's long, but I'm sure it works.
Hope that helps!

Was able to start it be making another change to caffe_option.py
Replaced version_string = line[line.find(pattern) + len(pattern)+1:].rstrip() by version_string = '0.12.0' in get_executable_version_string()
Already had replaced 0.11.0 by 0.12.0 in that file before asking my previous question, but apparently on the wrong location. Now that problem seems to be solved.
However, [http://localhost:5000] provides the interface, but now I got stuck on another -rather annoying- obstacle : when I want to configure my experiment, I want to provide the folder where the training images are stored -> New Image Classification Dataset -> Training Images (= " Indicate a folder which holds subfolders full of images"). I should expect that I must add e.g. 'c:/temp/images', but that's not possible. He always adds another '/' in front (-> /c:/temp/images) and always says 'training images - folder does not exist' when pressing 'create'-button on that page. And a browse-button to select a folder is not provided  :-(   So I have to find a way to select the folder that contains my training images.

He always adds another '/' in front

Whoops, that's probably a consequence of https://github.com/NVIDIA/DIGITS/pull/773 and this line. You might want to remove it while we fix it.

@gheinrich : removing that line solved the problem. Thank you!

And I try to use DIGITS 3.

You're going to want to use v4.0.0-rc.1 to include @IsaacYangSLA's Windows fixes:
https://github.com/NVIDIA/DIGITS/pull/769, https://github.com/NVIDIA/DIGITS/pull/781, etc.

is there an updated guide for doing this or is it still broken?

@chris-hawley https://github.com/NVIDIA/DIGITS/blob/master/docs/BuildDigitsWindows.md

Updated guide for Miniconda Python
https://github.com/conner99/DIGITS/blob/master/docs/BuildDigitsWindows.md

Thank you for the helpful installation guide!
I found just one thing at the part of
’’’
python -m pip install -r requirements.txt
’’’
This command made all file names into lower case with the latest pip script (8.1.2 on windows 10), which led small messes.
E.g. PIL/Image.py into pil/image.py
I had to reinstall pillow ( and edit some lines in later requirement.txt too )


release: v3.0.5

coverage: 83.976% (+0.04%) from 83.933%
when pulling 2780c02e3874fb5c9deaf1559a188c80405da445 on release_3.0.5_gcroci2
into 04615569d251f37918e16cb459b0581ef1d2c8fa on main.


Test: Electron 28 update

Refs: https://github.com/microsoft/vscode/issues/201935

[x] macOS @rebornix
[ ] linux @rzhao271
[ ] windows @alexdima

Complexity: 3
Create Issue

We plan to promote Electron 28 in the March 2024 milestone to insiders. The following tests cover some of the common UI bits that don't have smoke tests. You can download the nightly explorations builds from here for testing.
Testing:

macOS:

Enable Native Tabs (via settings: window.nativeTabs: true)

Ensure native tabs are enabled in the system preferences (System Preferences > General > Prefer tabs: "always":)
Launch application
Try opening new window from either command line (code-exploration ) or from the menu entry (Cmd + Shift + N)
Verify new window is launched as a new tab in the active instance of the application window is focused when starting from command line
open the code exploration application from finder or dock
open external terminal
run code-exploration
make sure the new window is put to foreground

windows:

verify maximize and restore operations work as expected when OS task bar is auto-hidden for custom titlebar
Verify titlebar is not clipped off when exiting fullscreen

Maximize VS Code window
Press F11 or Ctrl+K Z twice to enter/exit full screen.
Verify titlebar is not cropped

Verify there is no rendering lag with custom titlebar

All OS:

Check out the electron-28.x.y branch locally and verify you can run out of sources, set a breakpoint and debug using the VS Code launch configurations and VS Code debugger

My Ubuntu 22.04 VM keeps freezing while running yarn watch. I'll have to see whether Insiders has the same issue for me on the VM.


settings: restore previous menu's scroll position

To improve settings usability

[x] Confirm no memory leaks
[x] Confirm all menus still work
[x] Find max memory usage (for banglejs 1)
[x] Document {push,pop,restore}Menu

Tried it - works good on my watch!
I'll leave the merging to @gfwilliams.

This is a pretty big change - how sure are you it's not going to break something, and that there aren't memory leaks with the push/pop menus?

I've been through most menus, particularly the ones that don't fit the typical pattern, but I'll do an exhaustive check for memory leaks and thus confirm there's no hidden bugs

And do you know if it noticeably increases memory usage? It looks like maybe it wouldn't by anything noticeable but it'd be really bad if it stopped working on Bangle.js 1.

Will add my findings from the above check

It might be nice to have some kind of docs on when push/pop/restoreMenu should be used so that if someone works on this in the future we don't end up with it getting broken?

Sounds good, yes I'll add that

Exhaustively checked all the menu items, memory usage stabilises on returning out of the menus and I've noted down the usage in the readme. Give me a shout if there's anything I've missed

That's awesome - thanks! Let's merge then!

Thanks!


[Bug]: Rspack performing rebuild when started without watch

System Info
System:
OS: macOS 14.4.1
CPU: (10) arm64 Apple M1 Max
Memory: 6.16 GB / 64.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 20.12.2 - ~/.nvm/versions/node/v20.12.2/bin/node
npm: 10.5.0 - ~/.nvm/versions/node/v20.12.2/bin/npm
pnpm: 9.1.1 - ~/.nvm/versions/node/v20.12.2/bin/pnpm
Browsers:
Chrome: 125.0.6422.142
Safari: 17.4.1
npmPackages:
@rspack/cli: ^0.7.1 => 0.7.1
@rspack/core: ^0.7.1 => 0.7.1
Details
Starting rspack from the command line with rspack --config ./rspack.config.js is unintentionally also starting a watch.
The build appears to exit as expected.
zchapple@macos-N2GW31716V mctop % npm run build-prd
><EMAIL_ADDRESS>build-prd
> rspack --config ./rspack.config.js

Rspack compiled successfully in 328 ms
zchapple@macos-N2GW31716V mctop %

However modifying a file after the build exited, triggers a watch compile.
zchapple@macos-N2GW31716V mctop % npm run build-prd
><EMAIL_ADDRESS>build-prd
> rspack --config ./rspack.config.js

Rspack compiled successfully in 328 ms
zchapple@macos-N2GW31716V mctop % Rspack compiled successfully in 16 ms

Reproduce link
No response
Reproduce Steps

Update to 0.7.1
Run a build
Update a JS file
See Incremental build output

This was actually an issue due to having a phantom Rspack instance running in the background. After moving back to rspack 0.6.5 and testings and having it still happen I checked my activity monitor and found a node instance that was not terminated. This was most likely do to me doing some ctrl+c kills on builds that were in progress.  In essence the build did not clean up the running Rspack and it would still output to the terminal.


Image displayers on bottom scope stop working after changing data shape

Camera is tested, it changes the shape and resumes outputting data the expected way.
data hub and displayer need to be tested

terminating zmq context did not solve the problem. Instead, a new method is added to zmq.array to set the shape without the need to close the socket.


smoothState.js version is our of sync.

The different configuration claim different smoothState versions:
https://github.com/weblinc/jquery.smoothState.js/blob/master/bower.json
https://github.com/weblinc/jquery.smoothState.js/blob/master/smoothState.jquery.json

possibly related: the Getting Started page links to @miguel-perez's repo, which seems to lag behind this (apparently official) one


refactor(linter): move away from tuples for test cases

closes #1956

Current dependencies on/for this PR:

main

PR #2011   👈

This stack of pull requests is managed by Graphite.

Merge activity

Jan 13, 3:23 AM: @Boshen merged this pull request with Graphite.


How to override state parameter in the oidc-client library

How to explicitly specify the "state" parameter while sending the oauth request to the IDP I can see that the oidc-client library is adding one  automatically, but can we override it?
When pass the state in the extraQueryParams .It is appending the variable rather than overriding it
extraQueryParams: {
state:'12345'}
Do we have a way to override and pass a custom state value like  idp_url?client_id=xxx&state=123456& redirect_uri=xxx"

state is a reserved protocol param. The UserManager controls it. If you simply want to send custom params to the STS, use the extraQueryParams.

state is a reserved protocol param. The UserManager controls it. If you simply want to send custom params to the STS, use the extraQueryParams.

@brockallen
Is there a way to override state programatically as we need to send a custom value in the state parameter for our External Idp?

@brockallen
Is there a way to override state programatically as we need to send a custom value in the state parameter for our External Idp?

I don't understand why the state param. Why not the official acr_values or some other custom param? The state param is for the client to round trip state to itself. It's not meant to be used by the STS.

I don't understand why the state param. Why not the official acr_values or some other custom param? The state param is for the client to round trip state to itself. It's not meant to be used by the STS.