Correct way to handle subscriptions

What is the correct way to get callback about navigate back to a controller in the presenter.
If we have an attached presenter, we didn't set setRetainViewMode(RetainViewMode.RELEASE_DETACH), we don't get attachView() and detachView() in the presenter fur sure, because presenter stay in alive.
But for example I am subscribed to database change with an observer (Room) and it's very performance hungry. I would like to unsubscribe from changes during the controller isn't the current active controller, and resubscribe when we go back, but I don't want to rebuild the full UI.
I solved it with setRetainViewMode(RetainViewMode.RELEASE_DETACH) but in this case we start with a clean Controller, so we must to build the full UI again.
Do you have any idea or I just make in too complicated and this problem is easier :)

Hm, so attach / detachView() should be called in that case regardless of RetainViewMode and you would subscribe / unsubscribe in Presenter.attachView() and Presenter.detachView(), right?

I think it should use different callbacks to avoid misunderstandings.
But it could be a great feature, if the developer could subscribe/unsubscribe depends on Controller state. Currently on detach the subscriptions stay alive and it just doesn't forward to the render, but I believe there are cases when this causes too much unnecessary computation.

I think that attaching and detaching view in presenter should follow the actual lifecycle of a view in the Conductor library. For example in my mvp-based app I rely on this fact and set RETAIN_DETACH in a few places to have exactly this effect - so that the view wouldn't be recreated and reattached.
But on the second thought when using MVI this shouldn't be a problem - view state will get restored. But for MVP it could be something which is not obvious. At least I think this must be carefully thought out before changing...

You are right, I don't agree with attach / detachView() should be called in that case regardless of RetainViewMode.
I just say it would be great a different callback, which is regardless of RetainViewMode to manage subscriptions which are heavy.


TypeScript support breaks npm start

I just check this:
https://open-wc.org/building/building-rollup.html#support-typescript
But changing my-app.js to my-app.ts, makes npm start (es-dev-server) stop working.

You will need to add typescript support to es-dev-server as well: https://open-wc.org/developing/es-dev-server.html#typescript-support

Thanks @LarsDenBakker! I will check it!

Also I have tried to just run tsc --watch before running the server. It seems a setup a little simpler.
  "scripts": {
    "compile:typescript": "tsc",
    "compile:typescript-watch": "tsc --watch",
    "serve": "es-dev-server --app-index index.html --node-resolve --watch --open",
    "start": "npm-run-all --parallel compile:typescript-watch serve",
    "build": "npm-run-all compile:typescript build:rollup",
    "build:rollup": "rimraf dist && rollup --config"
  },

But when I run the npm run build, I have this error:
> rimraf dist && rollup --config

./index.html → dist/legacy...
(!) `this` has been rewritten to `undefined`
https://rollupjs.org/guide/en/#error-this-is-undefined
src/app-shell.js
23:  * file in the root directory of this source tree.
24:  */
25: var __decorate = this && this.__decorate || function (decorators, target, key, desc) {
                     ^
26:   var c = arguments.length,
27:       r = c < 3 ? target : desc === null ? desc = Object.getOwnPropertyDescriptor(target, key) : desc,
...and 1 other occurrence
created dist/legacy in 2.6s

./index.html → dist...
(!) `this` has been rewritten to `undefined`
https://rollupjs.org/guide/en/#error-this-is-undefined
src/app-shell.js
5:  * file in the root directory of this source tree.
6:  */
7: var __decorate = this && this.__decorate || function (decorators, target, key, desc) {
                    ^
8:   var c = arguments.length,
9:       r = c < 3 ? target : desc === null ? desc = Object.getOwnPropertyDescriptor(target, key) : desc,
...and 1 other occurrence
created dist in 1.5s

Looks tsc is outputting something which rollup doesn't like.

Yes! It seems the __decorate function. 😕
Typescript output:
var __decorate = (this && this.__decorate) || function (decorators, target, key, desc) {
    var c = arguments.length, r = c < 3 ? target : desc === null ? desc = Object.getOwnPropertyDescriptor(target, key) : desc, d;
    if (typeof Reflect === "object" && typeof Reflect.decorate === "function") r = Reflect.decorate(decorators, target, key, desc);
    else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
    return c > 3 && r && Object.defineProperty(target, key, r), r;
};
import { LitElement, html, customElement } from 'lit-element';
let AppShell = class AppShell extends LitElement {
    render() {
        return html `

app-shell

    `;
    }
};
AppShell = __decorate([
    customElement('app-shell')
], AppShell);
export { AppShell };
//# sourceMappingURL=app-shell.js.map

For now I use https://github.com/open-wc/open-wc/issues/640#issuecomment-515078760


NOJIRA: updated README

Added a note that about using the gh-pages plugin to push changes to the production site.

Merged at a91dd729c46ff353d7a20d8eda25aaa4b00ccca9


Utils tweaks

Show correct singular/plural for "X retweets" (also made it lowercase)
Add a default <title> for wordcloud.py
Remove unused imports/variables

This was merged in. I'm not quite sure why the PR didn't close.

Oh, and thanks!


Select start image

As an author I want to be able to select an image to starting from.
https://h5p.org/node/530775

DONE.


build: do not rename elf file, copy it

We break dependency if we rename the zephyr.elf file, we should keep it
as it is an essential dependency in the build system. Instead, copy the
file.
Fixes #10639
Signed-off-by: Anas Nashif<EMAIL_ADDRESS>

We still need a dependency from the "run" target to the ".exe" file ...

@nashif : To continue to have logical_target_for_zephyr_elf mean "the final executable", we can change the suffix of the elf file instead of copying/renaming it.
This approach can be seen here: https://github.com/SebastianBoe/zephyr/commit/0c72c82fdad67bef68cc6ecaa0d9c9a170ffcae0

We still need a dependency from the "run" target to the ".exe" file.

This is wrong. It is safe to depend on a target, when you actually depend on a targets post_build output.


27 zipped adb bugreports

Support zipped adb bugreports
WIP
fixes #27

@ivanja85 Sorry - took some time to get back to this. I just noticed that the patches above remove the support for the "old" bugreport which is used prior Android 7. Think we can get both :-)

Closing due to inactivity


No POM file is published so sources cannot be downloaded

You can see the lack of a POM file here: https://jcenter.bintray.com/com/tmsdurham/actions/actions-on-google/2.0.2-alpha/

The 2.0.2 stable release now has the POM
https://jcenter.bintray.com/com/tmsdurham/actions/actions-on-google/2.0.2/


CoreLibs fails detect HTML

Here's an example:
https://ameshkov.github.io/web/test_html_page.html
We should do two things:

Improve the current protocol detection code.
Additionally, we need to start using Accept header for detection. In Chromium/FF it gives us 100% insurance that it is trying to load an HTML page.

core/pull-requests/470


Consider adding GetDefaultServices() and AddLogging() to Logging

Currently Logging defines and provides default implementation of services, e.g. ILoggerFactory but unlike most other framework components it does not define either a GetDefaultServices([IConfiguration]) method or an AddLogging(this IServiceCollection, [IConfiguration]) sugar extension method. Perhaps the reasoning was been that Logging only needs to be added by Hosting, but making this change would improve consistency and abstraction. It would also be useful for testing and for non-Web application scenarios that don't have Hosting but want to take advantage of these basic services without much friction.

Added it and we're calling it from hosting.

@lodejard If you think we need to do something about that, reopen the bug. For now the extension method was moved to the Logging repository.


Fix issue of missing FreeRTOS+TCP cmake file in FreeRTOS console

Problem
The freertos_plus/standard/CMakeLists.txt is missing in generated metadata due to the logic in metadata of only including
enabled modules by matching the parent directory with the module name.
Fix
Rename the file to freertos_plus_tcp.cmake to match module name, and add a metadata function to allow adding <module-name>.cmake files to metadata, where the eligibility of adding the cmake file to metadata would be for the file name to match an enabled module name
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/bot run checks


[ci skip] [cf admin skip] NO_CI adding bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I've added bot automerge as instructed in #3.
Merge this PR to enable bot automerging.
Fixes #3

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.


Cannot add Collaborator to HockeyApp Organization

What App Center service does this affect?
User Management - Organization Collaborators
Describe the bug
Using an organization imported from HockeyApp, it is not possible to add new members to the organization.
To Reproduce
Following the documentation "Adding users to an organization":

Select an app within an organization
On the left side navigation, select the Settings page
Select People
Type the user's email address to add the user

Problem: there is no input field to type the user's email address.
Expected behavior
I expect to be able to add members to an organization, or if you prefer "collaborators without Admin role".
Screenshots

Desktop (please complete the following information):

OS: macOS 10.14.3
Browser: Tested on Safari and Firefox.
Version: Safari 12.0.3, Firefox 66.0.2 (64-bit).

Smartphone (please complete the following information):
n/a
Additional context
With an organization created on AppCenter.ms I can add new members and manage their role. It all works fine.
I have tried for few hours to add or manage team members on the AppCenter or on HockeyApp.
I have now found a dirty workaround to add collaborators:

Add new organization owners on HockeyApp (without any options).
Make them invite the invitation and login onto AppCenter.
Demote them from the organization on HockeyApp.
On AppCenter, manage the users even though they do not appear on the Collaborator list.

This is obviously pretty bad as:

We can't see who has been invited or not.
We cannot properly manage the roles.
The invited users have admin access for a short period of time.
We cannot revoke access to the organization.

@kevindelord thanks for bringing this up. The data between HockeyApp and App Center is only synced into one direction which is why it's not possible to add users to a HockeyApp organization on App Center.
We're currently working on Stage 2 of the transition plan which is about moving apps from HockeyApp to App Center. Once that's done we will address what you're asking for, to move entire organizations with all their apps (Stage 3). Until then, it won't be possible to add users to HockeyApp originated organizations on App Center, only on HockeyApp.
Related:

The work is tracked on our roadmap
Issue for "Move apps from HockeyApp to App Center" https://github.com/Microsoft/appcenter/issues/230

@derpixeldan thanks for the quick reply. I understand what's going on then.
The fact that we now have invisible users in the (HockeyApp) Organization does not feel... right.
This is related to the issue: #196.
I guess we just gonna wait and see :)

@kevindelord Hi, we have just released the support for adding/removing collaborators to HockeyApp organizations in App Center. Can you give it a try and see if that fixes your issue?

@nevalenny Hello there, yes it does work perfectly. I can invite new users, edit the existing ones, remove access, add them to teams, etc.


S3 Pipeline Documentation

We have announced S3 support externally a few times now, but without docs our users would not be able to leverage it. I would consider this the official release of S3 pipelines to our OSS community. Great work team!

Looks good to me. I didnt see any typos and data looks accurate


VIZIO SmartCast TV is being incorrectly categorized as a Chromecast, breaking DRM playback

Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
4.3.x
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from main?
Yes
Are you using the demo app or your own custom app?
Both
If custom app, can you reproduce the issue using our demo app?
Yes
What browser and OS are you using?
VIZIO TV
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
Mozilla/5.0 (X11; Linux armv7l) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3626.121 Safari/537.36 CrKey/1.0.999999 VIZIO SmartCast(Conjure/SX7A-4.6.419.12 FW/<IP_ADDRESS>-1 Model/M65-D0)
What are the manifest and license server URIs?

Available upon request
What configuration are you using?  What is the output of player.getConfiguration()?

Default
What did you do?

Configure a player to play DRM protected content on a VIZIO SmartCast TV.
What did you expect to happen?
Video should play.
What actually happened?

Player throws an 8000 error.

@joeyparrish I'm not sure which approach is best to take for this fix:

Refine the shaka.util.Platform.isChromecast() utility to ignore the VIZIO use case

I'm not sure if this would break scenarios where the TV was acting specifically as a cast device.

Soften the logic in shaka.polyfill.MediaCapabilities.canCastDisplayType_ to treat the !(window.cast) case as a warning instead of an error and fallback to shaka.media.Capabilities.isTypeSupported

Both?  At least 2.


OPEN: ONNX Parsing

The PR handles pretrained .onnx models which are traversed to generate a computational graph, each layer converted to the associated TrainLib kernel. The weights are saved by the Golden Model generator.
The PR adds argument parsing in order to indicate the path to the pretrained model, additionally replacing hardcoded directory namings.

@dnadalini Have a look particularly at how start_at and update_layer_list are treated. These two flags should be merged in the "Sparse Update" PR.


Remove RoR2 features from Example Mod

Currently we got a bunch of RoR2 specific stuff in the example mod. We should par it down to be Unity generic. Right now the example uses the RoR2 ASC module to find the game's main canvas. We can just create our own canvas for the example UI. We'll just remove the hooks used. Remember to remove the assemblies from the project and the asmdef references.

This was completed.


Masking: Add DateMask

Adds a date mask algorithm that works exactly like Cleave.js's date mask.
How Has This Been Tested?
unit
Types of changes

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[x] I've added relevant tests.

This should close #3892


[labs/virtualizer] Fix a null pointer exception happening in corner cases when virtualizer is destroyed and recreated quikcly.

This solves an error we've been facing internally.

@alanbuzek can you describe the error you were getting?
Ideally, we'd have an issue open first, and a test in the PR. I know that virtualizer is a bit hard to test, but I'd at least like to have an understanding of why this element can be undefined, and what the consequences of that are. Is this something that fixes itself after the next update?
We at least need a changeset in the PR.
cc @graynorton

Hi @justinfagnani, thanks for your reply. I added more detailed explanation on the error it's solving, please let me know if it makes sense. Also reached out via email with more (internal) context and added a context. Please let me know what you think, thanks!

@alanbuzek Thank you for the PR!
In reviewing your change, it appears to me that the error you're seeing is happening when a Virtualizer's mutation observer fires after the Virtualizer has been disconnected, resulting in a call to _finishDOMUpdate() after _childrenRO has been reset to null.
Your change will prevent the specific exception you're seeing, but I think we'd actually prefer to have _finishDOMUpdate() do nothing at all when the Virtualizer is not connected.
Since we have another spot in the code (in _updateLayout()) where we are guarding based on an indirect check of connection state, it seems better for clarity to track connection state explicitly and use that state to guard both _finishDOMUpdate() and _updateLayout().
I've pushed a commit to your branch that does this, and have confirmed that all of our existing Virtualizer tests are passing with this change. Can you take a look and verify that this change also eliminates the errors you're seeing in your app?
If so, then I'll go ahead and approve the PR and we can get it merged.
cc @rictic

@graynorton Thanks so much for looking into this in detail and coming up with a better solution. We tested your proposed change and it indeed solves the issues we've been facing. You can approve the PR and merge, as suggested. Thanks!


DI framework for iOS targets

Kind (Required)

Proposal

Overview (Required)
Why not use a DI framework for iOS targets?
Koin and Kodein are compatible with KMM.
As it is now, I think Hilt is fine for Android target.
Because this app has to learn to experience Hilt as well.
Links

https://insert-koin.io
https://github.com/Kodein-Framework/Kodein-DI

I'll work on it as per my proposal!

Thanks! Assigned 👍


Various metadata updates

See individual commits for details.

Updated so it matches what jeweler produces. Also noticed it picked up the LICENSE as an extra rdoc file now which proves my point that various tools didn't pick it up.

@ekohl do you want or need a new release with these changes?

Not strictly. I updated the RPM for 1.3.6 and noticed this when inspecting the changes. Having this upstream means I don't have to make local changes in our gem2rpm template in future updates.

okay. Then I won't do a release right now.
Thanks for the cleanup :-)


Examples

Examples pls.

i have no idea how to set this up, might check back again in the future™


some ktx examples + new cubemapDebug

related to https://github.com/BabylonJS/Babylon.js/pull/6045

you rock!


release: 0.7.32

Codecov Report

Merging #53 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master     #53      +/-   ##
=========================================
- Coverage    0.67%   0.67%   -0.01%
=========================================
  Files         136     136
  Lines        6052    6071      +19
  Branches      614     616       +2
=========================================
  Hits           41      41
- Misses       6010    6029      +19
  Partials        1       1

Impacted Files
Coverage Δ

.../java/net/mm2d/dmsexplorer/view/MusicActivity.java
0% <ø> (ø)
:arrow_up:

...va/net/mm2d/android/upnp/cds/CdsObjectFactory.java
0% <ø> (ø)
:arrow_up:

...src/main/java/net/mm2d/dmsexplorer/Repository.java
0% <ø> (ø)
:arrow_up:

...java/net/mm2d/android/upnp/cds/MsControlPoint.java
0% <ø> (ø)
:arrow_up:

...t/mm2d/dmsexplorer/view/ContentDetailFragment.java
0% <ø> (ø)
:arrow_up:

.../java/net/mm2d/dmsexplorer/view/MovieActivity.java
0% <ø> (ø)
:arrow_up:

...va/net/mm2d/dmsexplorer/view/SettingsActivity.java
0% <ø> (ø)
:arrow_up:

...et/mm2d/dmsexplorer/view/ServerDetailActivity.java
0% <ø> (ø)
:arrow_up:

...et/mm2d/dmsexplorer/view/ServerDetailFragment.java
0% <ø> (ø)
:arrow_up:

...mm2d/dmsexplorer/view/adapter/PropertyAdapter.java
0% <ø> (ø)
:arrow_up:

... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ff827d...532a0d2. Read the comment docs.


Landing Page buttons

Change the log in landing page so that it looks like this:
https://www.figma.com/proto/fxOgL3EIhMvGMiUNDRvYxa/AI-System-Assessment-Report-for-Dev?node-id=308%3A1405

It is close now - but still has the Login at the top rather than with the Sign Up. It's non-trivial to change the "Login" block at the top.

\


add default values of env vars to manifests. otherwise it is confusing to deduce which variable to add to which manifest.

Done.


Rename variants in the core language

Currently I use terminology from natural deduction to inform the names of the variants in the core language. This has turned out to be a bit intimidating and a source of confusion. The consistency between the names seems to also get in the way of understanding.
In the interest of making it a bit easier to understand and work on Fathom, this PR switches to more familiar names. We can tweak this further down the line, but I hope it helps!
Let me know your thoughts on this.

I think this terminology probably is clearer to someone not well versed in the space. 👍

Probably somebody versed in the space would actually call them Pi, Lam, App, and Sig, Struct, Proj, heh. But personally I still kind of like drawing a connection between things related to the different connectives in our type theory (ie. Fun, Record, Array, Const, Format), and prefer to avoid the Greek letters if possible.


Consider adding a timeout for password prompt in CLI

If using the CLI as part of an automated process or in the case where you have no access to interact with the shell/terminal is would be nice if the CLI would timeout or fail if no password is provided instead of prompting and waiting forever.

added with #256


Revert "Split VPA count in dashboard by API version"

Reverts gardener/gardener#5695
/area monitoring
/area auto-scaling
/king bug
Originally we wanted to find out, if all VPAs have been switched to v1 or if we still have users of v1beta2. Turns out, the api version split isn't very useful, because the metrics hardcode the version: see https://github.com/kubernetes/autoscaler/blob/master/vertical-pod-autoscaler/pkg/utils/metrics/recommender/recommender.go#L143-L147 and https://github.com/kubernetes/autoscaler/blob/1fa0716db97a0ce2b9785a954ffce5611c7a2d67/vertical-pod-autoscaler/pkg/recommender/model/vpa.go#L126

/assign @wyb1


The "mat-" prefix cannot be used in ng-material v1 compatibility mode

I already updated @angular/material and @angular/cdk to v beta.12 but I got this error
 ERROR Error: The "mat-" prefix cannot be used in ng-material v1 compatibility mode. It was used on an "mat-list" element.
What's wrong ??

If you are on beta.12 and have already made the conversion to mat-, then you should be able to remove {provide: MATERIAL_COMPATIBILITY_MODE, useValue: true},

I don't use MATERIAL_COMPATIBILITY_MODE in my code

if you are using "covalent" or "md2" see also
https://github.com/Teradata/covalent/issues/923
https://github.com/Promact/md2/issues/290

Please refer all troubleshooting questions to StackOverflow, Gitter, or Google Groups.

I'm currently using md2, that's the source of the problem,
thanks


Update Українська.json

It will be visible on any language, so you should translate it to other languages or it will appear anyway, just without any translation.
Also , is missing.


[CI]add incremental packages

What type of PR is this?
/kind feature

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

/lgtm

/lgtm

/wolf

/wolf


fix(card): fix expanded card rendering

Summary

Modified expanded card to render at 100% width/height with 50px padding

:tada: This PR is included in version 1.87.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0-beta.9 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.87.1 :tada:
The release is available on npm package (@release-1.x dist-tag)
Your semantic-release bot :package::rocket:


Desktop, styling

Client wish:

size of the quote should be back to the small size of the paragraph text (medium) (for mobile and dektop)
the small text size should be a bit bigger (font-size: 7rem i tested)
more spacing after accordeon
looking on running text: reduce spacing between paragraph spacing a bit more (if that is possible)
main page: wp-blocker below the categroy title smaller (I can also change it, no?)
margin-bottom_1.5rem

[ ] size of the quote should be back to the small size of the paragraph text (medium) (for mobile and dektop)
[ ]  the small text size should be a bit bigger (font-size: 7rem i tested)
[ ] more spacing after accordeon
[ ] ooking on running text: reduce spacing between paragraph spacing a bit more (if that is possible)
[ } 9 main page: wp-blocker below the categroy title smaller (I can also change it, no?)
margin-bottom_1.5rem

main page: wp-blocker below the categroy title smaller (I can also change it, no?)
margin-bottom_1.5rem

i dont understand. can you give a print?

main page: wp-blocker below the categroy title smaller (I can also change it, no?)
margin-bottom_1.5rem

i dont understand. can you give a print?

I think I can change that manually in the backend, no?


Revert lots of changes to our test-infra fork

This reduces our test-infra changeset to:
 OWNERS                                                  |  16 ++--
 gubernator/Makefile                                     |   2 +-
 gubernator/config.yaml                                  |  68 ++++++++---------
 images/alpine/Dockerfile                                |  20 +++++
 images/alpine/Makefile                                  |  27 +++++++
 images/bootstrap/Dockerfile                             |  18 ++---
 images/bootstrap/Makefile                               |   2 +-
 images/bootstrap/create_bazel_cache_rcs.sh              |  17 ++---
 images/bootstrap/runner.sh                              |  26 ++++---
 images/cert-manager-test/Dockerfile-0.3                 |  60 +++++++++++++++
 images/cert-manager-test/Makefile                       |  52 +++++++++++++
 images/cert-manager-test/README.md                      |   9 +++
 images/gcloud/Dockerfile                                |  34 +++++----
 images/gcloud/Makefile                                  |   8 +-
 images/gcloud/runner                                    |   2 +-
 mungegithub/cherrypick/deployment/tarmak/Makefile       |   1 +
 mungegithub/cherrypick/deployment/tarmak/configmap.yaml |  15 ++++
 mungegithub/cherrypick/ingress.yaml                     |  19 +++++
 prow/JETSTACK.md                                        |  55 ++++++++++++++
 prow/Makefile                                           |   8 +-

Plus also the DCO changes I merged into this repo already.
Future PRs will reduce the changeset further.

/hold


net/haproxy: feature & bugfix release

New features

Overhaul model to support configuration injection (used by our Let's Encrypt plugin)
Allow to use proper time format for more fields (downinter, inter)

Bugfixes

Fix search fields
Relax mask for description fields
Enhance isEnabled() to be more accurate
Improve some validation messages
Various fixes for the template

Merged, thanks. Very good work!


how to get the log level?

Hello, may I know how to get the log level of a received log message ?
Thank You!

Hi Xsmael, as there are different syslog message formats this lib currently does not provide any default parser, so you should parse the message yourself to get the log level.
A fast search listed some libraries that claims to parse syslog messages compliant to different versions of the RFC.
Check out the following libs and see if one of them suit your needs:

glossy
syslog-parse
syslog
syslogd

Please note I did not try any of the libs above and that none of are them related to this project.
Hope this help you towards the right direction!


Z-wave ids: Different nodes are assigned the same ids under new naming scheme.

Home Assistant release (hass --version): 0.49.0
Python release (python3 --version): 3.4.2
Component/platform: Z-wave
Description of problem: If you have more than one device of the same kind in the Z-wave network, some of these are given the same identifier. See below for a real world example.
NODE 29 - sensor.FIBARO System FGWPE/F Wall Plug Power:
friendly_name: FIBARO System FGWPE/F Wall Plug Power
new_entity_id: sensor.fibaro_system_fgwpef_wall_plug_power
node_id: 29
old_entity_id: sensor.fibaro_system_fgwpef_wall_plug_power_29_4
unit_of_measurement: W
value_index: 4
value_instance: 1

NODE 32 - sensor.FIBARO System FGWPE/F Wall Plug Power
friendly_name: FIBARO System FGWPE/F Wall Plug Power
new_entity_id: sensor.fibaro_system_fgwpef_wall_plug_power
node_id: 32
old_entity_id: sensor.fibaro_system_fgwpef_wall_plug_power_32_8
unit_of_measurement: W
value_index: 8
value_instance: 1

Expected:
Unique entity ids without collisions.

I believe this is expected and the idea is that you should go in and rename any conflicting zwave IDs.

Aha. I see. That wasn't apparent. I had another issue with changes not being stored to zwcfg_*.xml file, but that got sorted with a reboot after I changed back to the legacy naming scheme. Will take another shot at updating in a couple of weeks time.
Thanks, closing.


Floating search view assumes that view is always called from activity

Hey Airmorty,
Your lib looks great!  I want to use it in my upcoming project work.
However I am not able to use your lib as of now as It crashes on me when I try to inflate the view. When I looked into your source code its accessing activity. I feel custom view should be activity / fragment agnostic!
In my opinion if the custom view is doing more than a view should do then that responsibility should be given back to caller of this custom view.
Let me know your thoughts!
Caused by: java.lang.ClassCastException: android.view.ContextThemeWrapper cannot be cast to android.app.Activity at
com.arlib.floatingsearchview.FloatingSearchView.setupQueryBar(FloatingSearchView.java:454)

Thanks!
Manju

Hi Manju,
You are absolutely correct, and that is exactly the kind of issues I would like to address before adding any new functionalities, so thanks for that.
The issue was fixed in d303a2cb94a51c9c4db38acef731fa0743eeac42. I will close this issue once I confirm that the Maven repository is up to date.

Hey @arimorty ,
Thanks for consideration.I think it would be still better to give callback to the caller after voice button clicked and expect the result back to view from setter methods.
We have also implemented some of our custom views like this and later  we ran into multiple problems decided that custom views should not do anything extra which related to calling fragments or expecting any other result. So we keep all our custom view dumb / agnostic of external factors like calling voice recognition etc.
Let me know your thoughts!
Thanks!
Manju

@manjunathc23 Ok, since I have other things I want to improve first, I'll have a look at your suggestions about letting clients handle voice rec it in the future, probably release 1.0.3. For now, I have added  a silent exception to avoid crashing the client.
I can confirm that release 1.0.2 now is live. It contains fixes you suggested (mainly the casting problem) as well as a very important fix relating to dynamic suggestion item height measuring (if you don't know already, suggestion items can have different heights, try it out with long texts).
I hope it will inflate without any problems. Thanks for suggestions and, if possible, I would love to see your project when ready (if you end up using this lib)

Perfect! Thank for considering.
Thanks a lot. I'll add credits to your work too.
I would also love contribute your repo.
Thanks!
Manju

Search view works good with the fragments too!
Thanks for taking look at this issue. Looking forward to integrate your lib for our app.

Thanks for the pic. If you are going to use Hindi in the search, you should know that RTL support is not complete yet, but I hope it will be for next release (1.0.3).

Hey Ari,
We are gonna use localization as of now. Our app will be english language.
Anyways Hindi is not RTL its same use LTR as English. Thanks a lot.
I'll let you know when we go live with search bar.

Hey @arimorty ,
Take a look at the PR https://github.com/mikepenz/AboutLibraries/pull/175
I have created a PR to get your lib included in the About Libraries, let me know if you want to add more details about your lib.
Thanks!
Manju

That's great, Thanks.

Please support RTL in next release . thanks


Fix spelling: seperate -> separate

@lgirvin : Thanks for your contribution! The author, @mashamsft, has been notified to review your proposed change.

Hi @lgirvin, thanks for your contribution! You are right, thanks for catching this misspelling :) #sign-off


Godot Engine crashes on font change from the editor (using tool)

Operating system or device - Godot version:
Windows 10 Home 64bit
Godot Engine 2.1.3 (Steam, stable)
Issue description:
If you try to change the font size from within the editor, Godot Engine crashes.
set_font_size(value) (on line 29) in menu_item.gd causes the crash.
It also crashes if you try to use set("font_size", value) instead of set_font_value.
Steps to reproduce:
Open menu_item.tscn or main_menu_scene.tscn and change the menu item font size from within the editor (using export).
Link to minimal example project:
Bugged When Changing Font Size From Editor.zip

func set_font_size(value):
	# Update value
	font_size = value

	# Set button text
	set_font_size(value)

It causes infinite loop. It's just a bug in your script, not the bug inside the engine. Calling set("font_size", value) does the same thing, because it also triggers set_font_size(value).
I have no clue what is the point of calling set_font_size(value) at the end of set_font_size(value).

Maybe is missing a dot .set_font_size(value) for a parent class function call.

set("font_size", value)  still crashes it though.
Do the setter from the same script code trigger the setget? To my knowledge, the setget should not trigger if you change the values from within the same script.

@ivanskodje wrong assumption ;) It should trigger. Show me your updated script.

@Listwon According to the documentation:

Whenever the value of variable is modified by an external source (i.e. not from local usage in the class), the setter function (setterfunc above) will be called. (From here)

Which is why I dont think changing them from within code should not trigger setget methods inside the same source.

Local usage as font_size = value, not set("font_size", value), which calls setter explicitly.

What it means is, from outside:
font_object.font_size = something #calls setter

From script of font_object (local)
font_size = something #does not call the setter
self.font_size = something #calls setter too
.set_font_size(something)  #calls parent setter if exists


[HUDI-8511] Fix the bug where the Flink table config hoodie.populate.meta.fields is not effective and optimize write performance

Change Logs
1. Fix the bug

Resolve missing hoodie.populate.meta.fields in Table Config (hoodie.properties)
Enhance validity checks

2. Optimize write performance

Reduce unnecessary decoding overhead when disabling meta fields

Impact
Improve write performance. After optimization, the write speed with hoodie.populate.meta.fields=false is 42.9% faster than with hoodie.populate.meta.fields=true.
Testing method
Consume from the earliest position in Kafka until all messages are consumed (Kafka Lag = 0), and compare the time taken for both.
1）populate meta fields
time taken: 21hours and 25mins

2）no meta fields
time taken: 12hours and 14mins

Risk level (write none, low medium or high below)
medium
Documentation Update
none
Contributor's checklist

[x] Read through contributor's guide
[x] Change Logs and Impact were stated clearly
[x] Adequate tests were added if applicable
[x] CI passed

Infor Summary
1. In #11028, we already fixed the unnecessary rewrite when the schemas are exactly the same, is your benchmark based on the fix then?
Yes
2. Why are allowOperationMetadataField allowed only when populateMetaFields is enabled?

Disabling populateMetaFields can reduce the performance overhead of decoding HoodieRecords. However, if allowOperationMetadataField is enabled, decoding performance is still affected even if populateMetaFields is disabled. Therefore, the impact of these two settings on performance is interconnected.
Both are metadata fields. populateMetaFields is the main switch, while allowOperationMetadataField just controls the activation of specific metadata fields. When the main switch is off, the sub-switches should have no effect.

3. When enable populateMetaFields, why the number of record key fields must be equal to one？
The Log Scanner needs to regenerate the Record Key. Currently, it only supports a simple key generator, which means there can only be one primary key column.

@hudi-bot run azure

@hudi-bot run azure

@usberkeley Apologies for cancelling the CI run for this PR. CI queue is blocked and I have a couple of release blockers for which I am prioritizing CI. I will re-trigger the test after some time, or if you have more commit to push then the test will retrigger automatically after the commit.

@usberkeley Apologies for cancelling the CI run for this PR. CI queue is blocked and I have a couple of release blockers for which I am prioritizing CI. I will re-trigger the test after some time, or if you have more commit to push then the test will retrigger automatically after the commit.

hello codepe, got it, no problem～


RFE: BTreeMap allow counter be implemented by j.u.c.AtomicLong

There is optimization for sizeLong by using Atomic.Long to skip iteration. For temporary tables there can be counter implemented by j.u.c.AtomicLong to minimize overhead. Every CAS on counter writes record to disk. For temporary tables that will be deleted after close. It be only in memory.

I suggest deffer this issue to next version. There is simple workaround with self implementing Bind.size on AtomicLong.

Not going to fix this.


Update README.md

@jeffdav this was just to test the PR workflow 😅

I like a good newline though.  Very bold.


Bug: Can't load images from other drives

When I try to open an image file for the tileset image, if an image is not in the same drive as where LEd installed, then I get an error saying "ERROR: Couldn't read image data". If I copy the image to the same drive, then it can load it.
The drive it's installed to is C and the drive the images are in is the D drive.
If you need anymore info, please let me know.

Hmm I see the issue here: it's definitely related to my dn.FilePath class which doesn't properly support different drive paths.
I will fix that.


Add python API

This PR is the same as https://github.com/linkedin/feathr/pull/53, but created directly within the main repository instead of a folk where CI is not yet supported.


Export to Github should ask the user which folders to include

We should have a .gitignore strategy.

Verification:
Open a non-git folder, go to the SCM viewlet, click Publish to GitHub, pick a repo name and you'll end up in a quick open UI to include/exclude top level files/folders from the git repo. Whatever is excluded should end up in the .gitignore file, so it doesn't get pushed.


Switch from system to %x for running rake in ext/faster_path/extconf.rb

Not sure if this fixes it for mac users, but I was having issues with getting this gem to install extensions inside a docker container running Debian Jessie. Switch to %x fixed it. Maybe something todo with waiting for output?
https://stackoverflow.com/questions/6338908/ruby-difference-between-exec-system-and-x-or-backticks

Thanks!  Merging to master.


Settings Editor filter string java. includes JavaScript settings as well

Issue Type: Bug
See https://github.com/microsoft/vscode-java-pack/issues/794
VS Code version: Code 1.61.2 (6cba118ac49a1b88332f312a8f67186f7f3c1643, 2021-10-19T14:57:20.575Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: No

Hello folks, if we could bump the priority of this one, it'd be great. Right now when you search ".java" in the settings, all JavaScript settings shows up and it's rather counter-intuitive for our users. cc @brunoborges

Code pointer so that I don't lose track: https://github.com/microsoft/vscode/blob/main/src/vs/workbench/services/preferences/common/preferencesModels.ts#L80
My idea is to implement a better ordering that takes into consideration the name of the setting.


fix: remove comment that shows up in clap help text

fixes #85

Thanks @epage !

Thanks, and also thanks for the release! 🚀


Add shorthand to permission registry

Currently, permission.py files are slightly more verbose than they otherwise could be, especially when permissions refer to other permissions. For example, currently, you might have:
perms['shrubberies.change_shrubbery'] = has_role('shrubber') | Relation('store', perms['shrubberies.change_store'])

The registry class should have a shorthand that cuts down on the perms boilerplate, allowing code like this:
shrubberies = perms.shorthand('shrubberies')
shrubberies.change_shrubbery = has_role('shrubber') | Relation('store', shrubberies.change_store)

This could be further shortened (at the expense of readability) by doing something like s = perms.shorthand('shrubberies') and then referring to and assigning to s.update_shrubbery.
perms.shorthand('shrubberies') would return a special namespace object whose __getattr__ and __setattr__ perform item lookups/assignments on the registry itself, with the string 'shrubberies.' prefixed.
It's tempting to make __setattr__ etc on the registry object itself behave like this, but because the registry is a subclass of dict, there are already lots of attributes and methods on it that we could potentially clash with.
We could just break backwards compatibility and make the registry itself a namespace object like what we're describing, one which creates a new child namespace upon attempting to access an unset attribute (so e.g. you can assign to perms.shrubberies.change_shrubbery without first having to assign perms.shrubberies to something). The downside of this is that it creates one extra thing that we'd need to explain to new users in our tutorial without huge benefit, whereas everyone who's going to be using this library already understands how a dict works.
Doing it this way means that it's opt-in, and using an explicit call to something (.shorthand() here) gives developers that are new to codebases that have opted-in something to go and look up in the documentation.

A note regarding this bit:

We could just break backwards compatibility...

In general I'm too worried about compatibility in general until we hit 1.x, but compatibility breaks still mean I have to refactor the internal projects that use this library. In this case though, there's not a need to; the registry-as-namespace-object model described here could still provide a __setitem__. I'm not going to do what this paragraph describes anyway though, for the other reasons I've described above.


python312Packages.tencentcloud-sdk-python: 3.0.1240 -> 3.0.1241

Diff: https://github.com/TencentCloud/tencentcloud-sdk-python/compare/refs/tags/3.0.1240...3.0.1241
Changelog: https://github.com/TencentCloud/tencentcloud-sdk-python/blob/3.0.1241/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 345036 run on x86_64-linux 1

4 packages built:

python311Packages.tencentcloud-sdk-python
python311Packages.tencentcloud-sdk-python.dist
python312Packages.tencentcloud-sdk-python
python312Packages.tencentcloud-sdk-python.dist


Fix deploy workflow

For some reason, the deploy workflow doesn't actually push the changes, even though it displays no errors and works just fine from my local command line...

Not sure how to resolve this, so I've removed deploy part of the workflow in ed704482c3859da9e3bf8e561afd88d2e3ace0a6.


Overlapping or Stacked donut/pie charts

Hello - thank you very much for this amazing work and library. Its easy to use and I have it working. However, do you have any examples of how I could accomplish overlapping or stacked donut or pie charts? An example of what I am looking for would be like the chart at this link (this link actually shows sort of drill down data but essentially all I am looking for is two concentric donut charts) - http://www.highcharts.com/demo/pie-donut
I tried creating two overlapping donut charts on the same canvas but i only get to see one of them at a time as my mouse moves in and out of the canvas area. Any advice is appreciated.

Tagging: NEW CHART TYPES

@chicagosky Huzzah! The first alpha of Chart.js 2.0 has landed and should fix this issue. Check out the release and try it out! We've got a lot of momentum right now, so please help us test so we can launch 2.0 Gold by the end of the month.
https://github.com/nnnick/Chart.js/releases/tag/v2.0-alpha
I'm closing this issue for now, but if you have implementation questions or find bugs, please create a jsfiddle and post the link here and we'll reopen this issue and get it fixed.

@derekperkins Hi. I wanted to create a drilldown similar to link posted by chicagosky. The pie chart in chart.js 2.0 seem to be doing the trick, except for proper labelling. I have commodities as labels (outer circle) and each commodity belongs in one of four sectors (inner circle). Is there a way to be able to change the labels in the inner circle, currently it has similar labels as the commodities circle? And also change the legend to sectors? Thanks!


Kippo Docker Container Compatibility Issues

Issue
The Kippo docker container that the main README.md¹ links to download only a container for the linux/arm image of Kippo². While I don't believe that it's a problem with the ARM version being available, I believe that the bigger userbase of x86 computers is something that should be added as an option for testing reasons so that developers and users with an x86 CPU can do quick setup and testing with Kippo like all the other honeypot docker containers.
Sources

README
Kippo Container

We would be happy if you provided a docker image for x86.


data-featherlight-filter on data-featherlight-gallery breaks link functionality

I've got a div with the data-featherlight-gallery and data-featherlight-filter set to a certain class. In that div, I have some links which hold that class and others which don't.
The links with the class work as expected (the lightbox shows up) but all the other links (those without the class) stop working - nothing happens when they are clicked.
Fiddle showing the issue: https://jsfiddle.net/wuu5Lcop/1/

I had this issue too and I could never figure out why it was happening. However, you can highjack it this way:
$.featherlight.prototype.beforeOpen = function(event) {
    if(!$(event.target).hasClass('your-fl-filter-class')) {
            window.location = $(event.target).attr('href');
            return false;
    }
}

Oh, looks like a bug with the auto-bind functionality. If you don't use data-featherlight and with javascript it'll be ok.
I'll try to fix that asap.

Yes, I also noticed this same bug.
It can be seen in cbaur's example: https://jsfiddle.net/wuu5Lcop/1/
I took a look at the js code but I couldn't find the problem.
I did find a hack to exclude some images from a gallery, using HTML.
But I don't know a way to exlude links to external websites. They are broken.
It could be a useful feature to add e.g. featherlight-data="ignore" would force the link to behave in a normal way.
In this example, images 1 and 2 will be part of the gallery.
But image 3 will open in a single lightbox, despite being contained within the
 block.

image 1
image 2
image 3
yahoo

However, unfortunately the link to the external website is broken and doesn't work.

Oh, sorry, forgot about this bug.
Now fixed in 1.7.13.
Thanks for the great bug report.


Fix/262 info

In this PR, I have added info for actors in admin page and added the event info when the volunteer clicks on the event.
To test it:

Log in as admin and see Voluntarios, Voluntarios > Solicitudes, Socios, Educadores, Familia and Familia > Solicitudes
Log in as volunteer and click on an event in the calendar

Everything looks good and now the blue cards do not look so empty but I have a doubt: when I tried to download some file it does not work and I was wondering if this was because they are from the populate and the file does not exit

yes, forgot to mention. The buttons for downloading won't work with the people from the populate of the backend. If you want to test it, you'll need to create an actor of that role and then you can download the file


Noticed a huge improvement when using ExternRef's when changing allocator to Mimalloc

Not really sure what to write, but in benchmarking and randomly trying mimalloc as a global allocator, I noticed a rather huge performance boost in bench cases using  externrefs.
You can simulate the same using my test project at https://github.com/cylewitruk/wasm-test and running cargo bench --bench wasmtime to get results from the normal allocator.
In src/lib.rs you can uncomment the MiMallocstuff and run the benches again, and you'll (hopefully?) see a pretty impressive performance increase.
I tried the same with Wasmer (which was slower to begin with) and Wasmer remained consistent with non-mimalloc timings.
But the fact that Wasmer remains the same while Wasmtime gains impressively in timings makes me think that there might be some relatively simple yet substantial performance improvements that could be made within Wasmtime itself?
Linux cylwit-XPS-9320 6.2.0-31-generic #31~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Wed Aug 16 13:45:26 UTC 2 x86_64 x86_64 x86_64 GNU/Linux

Thanks for the report! I tested this out locally and got:
fold-add-square         time:   [3.2824 ms 3.2828 ms 3.2832 ms]
                        change: [-28.987% -28.919% -28.852%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
  3 (3.00%) high mild

Add/add_externref       time:   [275.53 ns 275.58 ns 275.63 ns]
                        change: [-36.699% -36.682% -36.665%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high severe
Add/add_native          time:   [129.08 ns 129.09 ns 129.10 ns]
                        change: [-4.0775% -4.0595% -4.0412%] (p = 0.00 < 0.05)
                        Performance has improved.
Add/add_memory          time:   [229.41 ns 229.51 ns 229.60 ns]
                        change: [-1.7513% -1.6910% -1.6373%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
  2 (2.00%) low mild
  4 (4.00%) high mild

after switching to mimalloc. I'm on aarch64, however, instead of x86_64, so the performance results may differ. By huge improvement are you seeing the same 40% decrease in time? Or are you seeing more?
One way to help confirm what's going on is to use perf. When I perf record beforehand the top functions for the add_externref benchmark are:
  15.89%  before   before             [.] __aarch64_ldadd8_rel
  13.01%  before   libc-2.31.so       [.] __aarch64_swp4_rel
   9.40%  before   before             [.] __aarch64_ldadd8_relax
   7.79%  before   libc-2.31.so       [.] __aarch64_cas4_acq
   6.96%  before   libc-2.31.so       [.] _int_malloc
   6.76%  before   before             [.] wasmtime::func::Func::call_impl
   6.64%  before   libc-2.31.so       [.] _int_free
   3.96%  before   libc-2.31.so       [.] malloc

whereas afterwards they are:
  23.95%  wasmtime-af70e2  wasmtime-af70e2000a2cd35b  [.] __aarch64_ldadd8_rel
  13.53%  wasmtime-af70e2  wasmtime-af70e2000a2cd35b  [.] __aarch64_ldadd8_relax
   8.82%  wasmtime-af70e2  wasmtime-af70e2000a2cd35b  [.] wasmtime::func::Func::call_impl
   5.18%  wasmtime-af70e2  wasmtime-af70e2000a2cd35b  [.] mi_heap_malloc_zero_aligned_at_fallback
   5.14%  wasmtime-af70e2  wasmtime-af70e2000a2cd35b  [.] wasmtime_runtime::externref::gc
   4.19%  wasmtime-af70e2  wasmtime-af70e2000a2cd35b  [.] wasmtime_runtime::externref::VMExternRef::new_with
   4.01%  wasmtime-af70e2  wasmtime-af70e2000a2cd35b  [.] wasmtime::func::Func::ty_ref

where this sort of makes sense to me. _int_{malloc,free} are the default system allocator and they're pretty high in the profile beforehand and basically gone in the latter. AFAIK glibc's default allocator is not known for its speed, so it's expected that swapping to mimalloc (or others) would improve allocation time.
For aarch64 specifically there's atomic stuff high up in the profile but that's less relevant for x86_64.
I'd recommend giving perf a try locally as it may show similar results as well, but otherwise this looks all expected to me so far.

You got better timing improvements than me anyway :)
fold-add-square         time:   [1.7552 ms 1.7588 ms 1.7635 ms]
                        change: [-20.970% -20.669% -20.361%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 13 outliers among 100 measurements (13.00%)
  1 (1.00%) low severe
  4 (4.00%) low mild
  6 (6.00%) high mild
  2 (2.00%) high severe

Add/add_externref       time:   [147.88 ns 148.13 ns 148.40 ns]
                        change: [-30.137% -29.752% -29.397%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
  3 (3.00%) high mild
Add/add_native          time:   [63.155 ns 63.253 ns 63.359 ns]
                        change: [-4.4835% -3.8322% -3.2604%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
  3 (3.00%) high mild
  1 (1.00%) high severe
Add/add_memory          time:   [98.934 ns 99.111 ns 99.297 ns]
                        change: [+1.7055% +2.7377% +3.6384%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 6 outliers among 100 measurements (6.00%)
  2 (2.00%) high mild
  4 (4.00%) high severe

But like you mention you're on a different arch and different computer so results will vary. If everything looks normal/expected to you then I don't see a reason to dig further - I mostly thought it was quite interesting that particularly ExternRefs saw the performance increase whereas the add_memory bench regresses (which is the case I would have thought would have benefit the most since there I'm serializing everything to Wasm memory and reading/writing).
Here's my perf record before & after:
  11,38%  wasmtime-f0d59a  wasmtime-f0d59a15b0ad0b71                         [.] wasmtime::func::Func::call_impl
   6,51%  wasmtime-f0d59a  libm.so.6                                         [.] __ieee754_exp_fma
   5,27%  wasmtime-f0d59a  wasmtime-f0d59a15b0ad0b71                         [.] rayon::iter::plumbing::bridge_producer_consumer::helper
   3,63%  wasmtime-f0d59a  libm.so.6                                         [.] exp@@GLIBC_2.29
   2,26%  wasmtime-f0d59a  wasmtime-f0d59a15b0ad0b71                         [.] wasmtime_runtime::externref::gc
-------------------------------
 15,08%  wasmtime-f0d59a  wasmtime-f0d59a15b0ad0b71                         [.] wasmtime::func::Func::call_impl
   6,85%  wasmtime-f0d59a  libm.so.6                                         [.] __ieee754_exp_fma
   5,66%  wasmtime-f0d59a  wasmtime-f0d59a15b0ad0b71                         [.] rayon::iter::plumbing::bridge_producer_consumer::helper
   3,76%  wasmtime-f0d59a  libm.so.6                                         [.] exp@@GLIBC_2.29
   3,48%  wasmtime-f0d59a  wasmtime-f0d59a15b0ad0b71                         [.] wasmtime_runtime::externref::gc

There might be something in the ExternRef code that could be optimized? Do you see anything in my examples where I'm using Wasmtime incorrectly/in a less-than-optimal way?

As you've discovered, ExternRefs are allocated with malloc. There isn't much we can do to improve performance within this design, other than suggest alternative allocators for ExternRef-allocation heavy use cases.
Looking forward to our plans for the GC proposal, as part of that work we will implement bump allocation for all objects, including ExternRef.

Well cool! I'll go over there and have a read :)  I'll close this ticket now since there's nothing to do, but good info if anyone else stumbles along


Fixed import for EmbeddingBase class for ollama and huggingface embedders

Description
Fixed import for EmbeddingBase class for ollama and huggingface embedders.
Fixes #1544
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

Maintainer Checklist

[ ] closes #xxxx (Replace xxxx with the GitHub issue number)
[ ] Made sure Checks passed

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This looks good, thanks @kmitul.


add mouse scroll

Adds a scroll option in the mouse input. This can be used to scroll not only pages, but elements inside pages such as iframes.
Resolves #83

This time the tests worked here even in the older versions of php. I'll try to take a look and fix it.

This time the tests worked here even in the older versions of php. I'll try to take a look and fix it.

This seems inherently flakey, so not useful even for someone using this library. Is there a way to block, waiting for chrome to finish the render?

This seems inherently flakey, so not useful even for someone using this library. Is there a way to block, waiting for chrome to finish the render?

@GrahamCampbell I didn't find a better solution to this, but it worked every time in all my machines even without the usleep. I implemented this feature because I needed it for a project. I also didn't find any way to block the execution until the scroll finishes, do you have any suggestion?

@GrahamCampbell I didn't find a better solution to this, but it worked every time in all my machines even without the usleep. I implemented this feature because I needed it for a project. I also didn't find any way to block the execution until the scroll finishes, do you have any suggestion?

Maybe you need to wait before scrolling?

Maybe you need to wait before scrolling?

@GrahamCampbell How do you feel about just printing a warning instead of an error if this test fail? It will prevent breaking the tests on github and will still warn developers about what happened.

@GrahamCampbell How do you feel about just printing a warning instead of an error if this test fail? It will prevent breaking the tests on github and will still warn developers about what happened.

Waiting before scrolling seems to work, I should have thought about that before. 😁

Waiting before scrolling seems to work, I should have thought about that before. 😁

Great, thanks.

Great, thanks.


Add me the Firebase Github Org

Add me to the orgnisation

@DevXcode1
You will need to reach out to Firebase support or members who have privilege to add people in the org.
Closing from here as this isn't an issue.


Update envoy and co. to match latest data-plane-api commmit

envoyproxy/data-plane-api: 9edfeb841b0f8e54816f0b81949f79104072072c
google/googleapis: 82944da21578a53b74e547774cf62ed31a05b841
envoyproxy/protoc-gen-validate: 872b28c457822ed9c2a5405da3c33f386ac0e86f
cncf/udpa: cc1b757b3eddccaaaf0743cbb107742bb7e3ee4f

For xDS reviewers, UDPA moved their core protos from udpa/core/v1 to xds/core/v3. See original pr: https://github.com/cncf/udpa/pull/40.

Known failures: https://github.com/grpc/grpc/issues/25368 https://github.com/grpc/grpc/issues/22411 https://github.com/grpc/grpc/issues/25369


Ignore fields user guide

Recently we got an issue where the kubectl provider along with the fluxcd provider end up always performing an update-in-place. The fix is rather easy so I thought a user guide may be useful for people running into this issue.
Signed-off-by: Luis Gabriel<EMAIL_ADDRESS>

Flux sets labels on each object after bootstrap, why do we tell people to ignore metadata.annotations instead of metadata.labels?

@stefanprodan did a yaml diff and for my specific case, I saw no new labels being added, just annotations and after testing this, it seems no new labels where being dtected. But glad to edit the example to add labels if you deem it useful.

Hi, I've been wondering about this and trying to reproduce this scenario. In my terraform plans, I do see in-place updates for yaml_incluster. Looking at the corresponding object in the cluster, for example source-controller deployment, I see annotation like:
  annotations:
    deployment.kubernetes.io/revision: "21"

which sure aren't in the terraform configuration.
For such things, I guess using ignore_fields to ignore the annotations is okay, unless the flux manifest starts adding annotations in the future. I believe overwriting these annotations with terraform is harmless as we ensure our attributes are present and any other attributes added by K8s itself are automatically added if removed by terraform. I'm not sure if we need to officially document ways to ignore such drifts or rather document what they mean with proper reasoning behind them.
But I don't think we should be ignoring spec. Differences in spec are important to be tracked and need to be reconciled whenever there's a drift detected.

Hi @darkowlzz What k8s provider are you using? Most likely a cloud provider will have mutating webhooks. I had this problem on EKS.

What k8s provider are you using? Most likely a cloud provider will have mutating webhooks. I had this problem on EKS.

I'm using a self-hosted k0s cluster.
If the whole spec is ignored using the ignore_fields kubectl argument, will this provider actually work at all? When there's a new flux version, wouldn't the spec be ignored and everything will become no-op?
As per https://registry.terraform.io/providers/gavinbunney/kubectl/latest/docs/resources/kubectl_manifest#ignore-manifest-fields, individual fields can be ignored. Can we do with ignoring only the specific fields in spec and annotation that are mutated by the mutating webhook?

@darkowlzz I do not think the provider will work if the whole spec is ignored, which was why i was hesitant in the first place. I would be more interested in knowing what mutation is causing issues for the provider.
As far as I know EKS does not mutate anything applied to the cluster by default? Must be something else.

I has the same inquiry at first. That's why I have already made those tests. The provider does work if you change the manifests like bumping the version or other actions. It will detect changes to the parsed_yaml and yaml_body properties so plan will work normal.

We no longer depend on the kubectl provider, the flux_bootstrap_git uses Flux server-side apply.


when predict ,the param predicted_out_filename  in predict_sft  don't work again ,  and run one more predict work,the pred file has been covered ?

@wangzaistone  to fix


dogstatsd: allow empty message for events (resolves #6054)

What does this PR do?
To be consistent with the Datadog API, allow empty message for events.
Motivation
When the agent starts the event HOST's Datadog Agent has started is emitted and when I tried to emit something similar with dogstatsd I got the error event: empty title or text.

Thanks a lot for the PR @verdie-g ! It will be available in the next release of the agent 7.25.0/6.25.0


Avj high severity vulnerability from outdated Angular versions

Is this a regression?
No
Description
Akita uses an out dated version of Angular that is dependent on a vulnerable version of avj.
There is already a PR opened to upgrade the versions of Angular which should fix the outdated dependency.
https://nvd.nist.gov/vuln/detail/CVE-2020-15366
https://github.com/datorama/akita/pull/671

The repo is updated now. I'll release new versions soon.


'synth_set' used twice

Hi, I was looking through the code for the DCASE'24 Task 4 baseline system and noticed the following lines in the file train_pretrained.py:
strong_full_set = torch.utils.data.ConcatDataset([strong_set, synth_set])
tot_train_data = [maestro_real_train, synth_set, strong_full_set, weak_set, unlabeled_set]
train_dataset = torch.utils.data.ConcatDataset(tot_train_data)

According to this, 'synth_set' is used twice. Is there a specific reason for this?

Hi,
Thanks for the question,
I think it has been done only to "upsample" the amount of synthetic training data during each epoch.
It is very similar to having 12 for synthetic training data as in the past recipe but it has been split into 6 and 6+strong.
In general the recipe is very sensitive to the batch size and the proportions of each dataset.
This is for sure not optimal but worked well in our experiments.
@JanekEbb do you know more maybe ?

Thanks for the explanation!

Actually, I'd say that leads to strong_set (strong Audioset portion) being underrepresented in the training. Currently strong_set makes only 6/64*3470/(10000+3470)≈2.6% of the training data if I am not wrong. We may wanna fix that.
Thanks for pointing that out Florian!

After many tries it seems to me that the best configuration is this one with the strong and synth concatenated.
The strong labels do not seem to help in my case.


Update Composer dependencies (2023-02-24-00-08)

Visual regression test passed!
View the visual regression test report


[linux] glib minimal version is raised?

Describe the bug
In 11.2.0 on Ubuntu 22.04 (and early) with glib 2.64 stopped working OpenFilePickerAsync.
It's broken by Avalonia/src/Avalonia.X11/Interop/Glib.cs in the RunOnGlibThread function call.
Now used g_timeout_add_once (available in glib since 2.74) instead of old call g_timeout_add_full (base api)
Is the minimal required version Avalonia is raised from Ubuntu 16.04 to 24.04,
or is it possible to return to the previous api glib?
To Reproduce
use OpenFilePickerAsync
Expected behavior
no crash
Avalonia version
11.2.0
OS
Linux
Additional context
Unable to find an entry point named 'g_timeout_add_once' in shared library 'libglib-2.0.so.0'

Fixed in https://github.com/AvaloniaUI/Avalonia/pull/17392
Planned to be shipped with 11.2.1

@maxkatz6 Is there any way around this issue?

@JerryJian use nightly builds or wait for 11.2.1 which is expected next week.


update TweetManager.py

Hi there, I have this package (got3) working on my machine this evening, the only edit I needed to make locally was here in TweetManager.py. Package urllib2 has been distributed into urllib.request and one other urllib class in Python 3, and changing instances of urllib2 to urllib.request does make the opener build successful. I'm suggesting this change so the package can be functional for other Python 3 users, though I understand this isn't your officially supported package. Also if you have the script written as is for a particular reason I'm not aware of, totally understand. Just wanted to share the fix I found.

Was about to file a pull-request for the same fix/issue. Why didn't i get the updated version while cloning? Seems to be in the same branch


Example suggestion: tuples in roc

Tuples are not mentioned in the tutorial so it would be nice to have a basic example demonstrating how they are commonly used.

We do have an issue to add Tuple to the tutorial #5141, I think @kunalznk is working on that, but I haven't checked in on that for a while.

Even if it's mentioned in the tutorial, I think it would be useful to have an example that demonstrates how they work, their type signature, pattern matching with tuples...


1.0.4

fixed serialization of objects that may have attributes of type datetime.date: #3
documentation

use steenzout.sphinx to generate documentation

renamed version module to metadata

Coverage remained the same at 100.0% when pulling 2c51aaba54606b68cd89038d0e430b3881de608b on develop into 8c13afefdd380bf4d6d1caa7ef252f3b2789f688 on master.

Coverage remained the same at 100.0% when pulling 1f7ae1569a55657153fb10360819f2a882b524ff on develop into 8c13afefdd380bf4d6d1caa7ef252f3b2789f688 on master.


DAO interface document.

Please answer these questions before submitting pull request

Why submit this pull request?

[X] Document

Related issues
#1064

New feature or improvement

Describe the details and related test reports.
Someone wanted to extend the collector storage module, he/her reference to ElasticSearch DAO implementation only. But not everyone knows ElasticSearch query API.

Closing this PR for now. I have already replied @peng-yongsheng


typings intellisense

Maybe I'm not really understanding how vscode works. In my project (angular2) I've installed tsd. The project folder structure is this one:
+-- build
|  +-- *.js
+-- node_modules
|  +-- *.ts
|  +-- *.d.ts
+-- src
|  +-- *.ts
+-- typings
|  +-- google.analytics
|  |  +-- ga.d.ts
|  +-- tsd.d.ts
+-- tsconfig.json

My tsconfig.json looks like this:
{
    "compilerOptions": {
        "target": "es5",
        "module": "system",
        "moduleResolution": "node",
        "sourceMap": false,
        "emitDecoratorMetadata": true,
        "experimentalDecorators": true,
        "removeComments": false,
        "noImplicitAny": true,
        "outDir": "build"
    },
    "exclude": [
        "build", "node_modules", "typings", "temp"
    ]
}

I've got this src/components/app/app.ts file:
import { Component } from 'angular2/core';
// import { ga } from 'google.analytics/ga'; // <--- Cannot find module 'google.analytics/ga'

@Component({
    selector: 'ang-app'
})
export class AppComponent {
    constructor() {
        _gaq.push(); // <--- Cannot find name _gaq any
    }
}

Also tried to add /// <reference path="typings/tsd.d.ts" /> with same result. (Also I've read that typescript doen't need /// references any more). And even deleting "exclude" from tsconfig.json.
So VSCode is understanding 'angular2/core' but not 'google.analytics/ga' neither _gaq. How should I do to use ga.d.ts or even better, tsd.d.ts?

Magically it started to work after several restarts and trials...


linux desktop app does't allow to enter in text-field after "@" and throw this error

Linux desktop app got stock while entering input after entering "@"  in text-field
A KeyUpEvent is dispatched, but the state shows that the physical key is pressed on a different logical key. If this occurs in real application, please report this bug to Flutter. If this occurs in unit tests, please ensure that simulated events follow Flutter's event model as documented in HardwareKeyboard. This was the event: KeyUpEvent#714f2(physicalKey: PhysicalKeyboardKey#7001f(usbHidUsage: "0x0007001f", debugName: "Digit 2"), logicalKey: LogicalKeyboardKey#00032(keyId: "0x00000032", keyLabel: "2", debugName: "Digit 2"), character: null, timeStamp: 8:00:35.270000) and the recorded logical key LogicalKeyboardKey#00040(keyId: "0x00000040", keyLabel: "@", debugName: "At")
'package:flutter/src/services/hardware_keyboard.dart':
package:flutter/…/services/hardware_keyboard.dart:1
Failed assertion: line 444 pos 16: '_pressedKeys[event.physicalKey] == event.logicalKey'
════════════════════════════════════════════════════════════════════════════════
** (shop:995669): WARNING **: 19:01:42.046: Unable to retrieve framework response: Message is not valid JSON
════════ Exception caught by services library ══════════════════════════════════
A KeyUpEvent is dispatched, but the state shows that the physical key is pressed on a different logical key. If this occurs in real application, please report this bug to Flutter. If this occurs in unit tests, please ensure that simulated events follow Flutter's event model as documented in HardwareKeyboard. This was the event: KeyUpEvent#714f2(physicalKey: PhysicalKeyboardKey#7001f(usbHidUsage: "0x0007001f", debugName: "Digit 2"), logicalKey: LogicalKeyboardKey#00032(keyId: "0x00000032", keyLabel: "2", debugName: "Digit 2"), character: null, timeStamp: 8:00:35.270000) and the recorded logical key LogicalKeyboardKey#00040(keyId: "0x00000040", keyLabel: "@", debugName: "At")
'package:flutter/src/services/hardware_keyboard.dart':
package:flutter/…/services/hardware_keyboard.dart:1
Failed assertion: line 444 pos 16: '_pressedKeys[event.physicalKey] == event.logicalKey'
════════════════════════════════════════════════════════════════════════════════
flutter doctor -v
[✓] Flutter (Channel stable, 2.5.3, on Ubuntu 20.04.3 LTS 5.11.0-40-generic,
locale en_US.UTF-8)
• Flutter version 2.5.3 at /home/subash/snap/flutter/common/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 18116933e7 (5 weeks ago), 2021-10-15 10:46:35 -0700
• Engine revision d3ea636dc5
• Dart version 2.14.4
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
• Android SDK at /home/subash/Android/Sdk
• Platform android-30, build-tools 30.0.3
• Java binary at: /snap/android-studio/current/android-studio/jre/bin/java
• Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
• All Android licenses accepted.
[✓] Chrome - develop for the web
• Chrome at google-chrome
[✓] Linux toolchain - develop for Linux desktop
• clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final)
• cmake version 3.10.2
• ninja version 1.8.2
• pkg-config version 0.29.1
[✓] Android Studio (version 2020.3)
• Android Studio at /snap/android-studio/115/android-studio
• Flutter plugin version 61.2.2
• Dart plugin version 203.8430
• Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
[✓] Android Studio
• Android Studio at /snap/android-studio/current/android-studio
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• android-studio-dir = /snap/android-studio/current/android-studio
• Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
[✓] VS Code
• VS Code at /snap/code/current
• Flutter extension version 3.28.0
[✓] Connected device (2 available)
• Linux (desktop) • linux  • linux-x64      • Ubuntu 20.04.3 LTS
5.11.0-40-generic
• Chrome (web)    • chrome • web-javascript • Google Chrome 96.0.4664.45
• No issues found!

Possible duplicate of #89982.

Hi @subash9860, Thanks for filing the issue. There have been several reports for this issue https://github.com/flutter/flutter/issues/89982 and this has been fixed on the latest master channel. I did verify on master, 2.6.0-12.0.pre.790 and couldn't reproduce it. You may switch to the master channel until the fix lands on stable.
You may switch to master by running
flutter channel master
flutter upgrade

flutter doctor -v
[✓] Flutter (Channel master, 2.6.0-12.0.pre.790, on Ubuntu 20.04.3 LTS 5.11.0-40-generic, locale en_GB.UTF-8)
    • Flutter version 2.6.0-12.0.pre.790 at /home/mahesh/Development/master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 3a18e6ee42 (24 hours ago), 2021-11-22 13:01:00 +0300
    • Engine revision ad00d12833
    • Dart version 2.16.0 (build 2.16.0-35.0.dev)
    • DevTools version 2.8.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /home/mahesh/Android/Sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /home/mahesh/Downloads/android-studio-2<IP_ADDRESS>-linux/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Linux toolchain - develop for Linux desktop
    • clang version 10.0.0-4ubuntu1
    • cmake version 3.16.3
    • ninja version 1.10.0
    • pkg-config version 0.29.1

[✓] Android Studio (version 2020.3)
    • Android Studio at /home/mahesh/Downloads/android-studio-2<IP_ADDRESS>-linux/android-studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[✓] VS Code (version 1.62.2)
    • VS Code at /usr/share/code
    • Flutter extension version 3.28.0

[✓] Connected device (3 available)
    • sdk gphone x86 (mobile) • emulator-5554 • android-x86    • Android 11 (API 30) (emulator)
    • Linux (desktop)         • linux         • linux-x64      • Ubuntu 20.04.3 LTS 5.11.0-40-generic
    • Chrome (web)            • chrome        • web-javascript • Google Chrome 96.0.4664.45

• No issues found!

Closing as fixed on master, if you still encounter the issue, please feel free to file a new issue or comment on this issue and I will reopen it.
Thank you.


validate_token works on local web server, but not remote?

Hey all,
I've got this gem enabled on a project and it's working fine locally. BUT when I'm deployed, while I can register/login and my calls (using a custom authentication helper) work just fine, the actual validate_token doesn't do anything. It looks like maybe on the server the tokens aren't being set correctly, as when I look at my actual User data, I can find the client, but not the token itself. Is there an easy, obvious gotcha for this? I imagine it's something very simple.

Hi there @hoggworks    ,
In an effort to cleanup this project and prioritize a bit, we're marking issues that haven't had any activity in a while with a "close-in-7-days" label. If we don't hear from you in about a week, we'll be closing this issue. Obviously feel free to re-open it at any time if it's the right time or this was done in error!
If you are still having the issue (especially if it's a bug report) please refer to our new Issue Template to provide some more details to help us solve it.
Hope all is well.


Android web views and Chrome bad rendering

Chrome for Android does not implement completely background-position. Therefore, color picker is rendered bad as can be seen in the attached image. Maybe the problem is not background-position, but I have deduced it because debugging Android web view in Chrome for desktop the color picker is shown correctly in the desktop and bad in the mobile.
I only have tried JavaScript implementation, but I suppose that the issue also happens in jQuery implementation.
Thanks.

Hi @Martin1887 ,
thanks for this finding.
I will look into this as soon as possible. In the meantime,... have you tried tinyColorPicker? It is way smaller and faster and therefore better suited for mobile (in case you use jQuery anyhow). It also supports mobile touch.
Other than that I think this problem might be caused by rounding problems. I'll check as soon as possible.
Cheers


Refactor: Forgot-Password Form Component

The Forgot-Password form component, used for creating and updating forms, should be refactored to use PrimeNG's form components so that the styling is consistent with the remainder of the application.
Relative path: frontend/src/app/forgot-password

On it ^^

Looks good! Thank you for your contribution!


Linker Error on Android after Update of Xamarin.Android.Google.BillingClient

I had a working implementation for a InApp-Purchase in my app (already released)...  Which also updated Xamarin.Android.Google.BillingClient to Version 4.0.0 (I have no idea wich version it was before updating).
Now I get the following Compiler-Exception (in Release Mode with link all assemblys):
/Library/Frameworks/Mono.framework/External/xbuild/Xamarin/Android/Xamarin.Android.Legacy.targets(5,5): Error XALNK7000: Mono.Linker.MarkException: Error processing method: 'Plugin.InAppBilling.InAppBillingPurchase Plugin.InAppBilling.Converters::ToIABPurchase(Android.BillingClient.Api.Purchase)' in assembly: 'Plugin.InAppBilling.dll' ---> Mono.Cecil.ResolutionException: Failed to resolve System.String Android.BillingClient.Api.Purchase::get_Sku()
at Mono.Linker.Steps.MarkStep.HandleUnresolvedMethod (Mono.Cecil.MethodReference reference) [0x00013] in [...]
I have a Linker-Config-File wich looks like that:
<linker>     <assembly fullname="Plugin.InAppBilling"> 		<namespace fullname="Plugin.InAppBilling" /> 	</assembly>     <assembly fullname="Xamarin.Android.Google.BillingClient"> 		<namespace fullname="Android.BillingClient" /> 	</assembly> </linker>
I also tried to put the libraries in the linker-options of the project... same result.
Bug Information
Version Number of Plugin: 4.0.2 and 4.2.0-beta testet
Device Tested On: -
Simulator Tested On: -
Version of VS: 8.10.5 (build 16) for Mac
Version of Xamarin: <IP_ADDRESS> (Xamarin.Android)
Versions of other things you are using:
Xamarin.Android.Google.BillingClient: 4.0.0
Android Target Version: Android 10
C#-Language Version: Version 8
Steps to reproduce the Behavior
Expected Behavior
Compilation with linking
Actual Behavior
Linker-Error
Code snippet
Screenshotst

I have a dependency on 3.0.0 of https://www.nuget.org/packages/Xamarin.Android.Google.BillingClient/ so don't update to 4.0 as it will have breaking changes.

If desired you can use the 5.0.0-beta to use billing client 4.0


Text is rendered white on a white background

Description
Sometimes the text will be rendered white on a white background,
after changing the theme the rendering is okay.

To Reproduce
Sometimes the text will be rendered white on a white background,
after changing the theme the rendering is okay.
This is on single file mode, i have no idea how it behaves elsewhere.
Expected behavior
Highlighting or black text
Version information
Commit 9a7364ae59f4234602755cc11e2e5cfa84d3c791
Additional context
This is a bug which got reported to me by someone else, therefore i made this issue to track it.

Thanks for submitting a issue!
to assign this issue to yourself please comment @aurora-care-bear please assign me

Fixed in https://github.com/AuroraEditor/AuroraEditor/pull/745


Deploy on already existed cloudfront distribution

actually I already comment on #10, But for visibility I will create another one.
So I want to deploy the solution on already existed Cloudfront distribution. I have a static website host in bucket X, but the web get assets (images, etc) from bucket Y.
To deploy it, what command should I use?
cdk deploy -c S3_IMAGE_BUCKET_NAME='bucket-X' or cdk deploy -c S3_IMAGE_BUCKET_NAME='bucket-Y'?
Thank you,

The current solution does not reuse an existing CloudFront distribution. In order to do that, you have to change the CDK code to import an existing CloudFront Distirbution using the following method fromDistributionAttributes
When you do that, bucket Y should be used, as it's the source of your images.

@achrafsouk ,
Currently I'm not really familiar with AWS CDK, is there manual way to change or deploy this solution?

Well of course you can do it in the console.

You have to create a new cache behavior in your existing CloudFront distribution dediated for serving images (e.g. /images/* or *.jpg, *.png, etc..)
Then mimic the configuration of this cache behavior using the deployed CloudFront distribution in the solution: Associate the CloudFront Function on the viewer event, configure the origin failover with appropriate origins, etc...

Thanks for the reply @achrafsouk ,
btw I have question regarding my 1st question,
let's say I decide with this approach instead for the deployment cdk deploy -c S3_IMAGE_BUCKET_NAME='bucket-Y'
Is there any way the deployment harm the object in Bucket Y?
Apparently, I used same S3 bucket to serve Dev and Prod assets.

I have a similar question, is it recommended to delete my old distribution and associate custom domains to new distributuion?


Improve string compare

We do have lots of string compare/switch code without considering case sensitivity such as provider in providerFactory, catalogType in materialize, etc. This can be improved  to avoid blocking customers to use upper cases in spec yaml files.

User input: provider.type, catalogType: case sensitive
Internally, we need to avoid string compare and better use enum.


Adds support for SPFx v1.20.0. Closes #6391

Adds support for SPFx v1.20.0. Closes #6391

On it 🤙👍

Ready to Merge 🚀

Merged manually.
Thank you for your awesome contribution 👏


Angular View and Controller for Blog duplicated at app

Hello there,
As per my understanding the module (Blog) would be a completely decoupled from the application (MyAbpZeroProject).
But I can see a blog.cshtml and blog.js files under main app Project.
Is this by design ?
I mean, Should the view and controller lie on module or app(host) solution ?
Bruno

Hi,
cshtml and js files are under module project actually: https://github.com/aspnetboilerplate/sample-blog-module/tree/master/src/Abp.Samples.Blog.Web/App/Main/views/blog
But when you install Abp.Samples.Blog.Web nuget package, these files are copied into the application. When we upgrade nuget package, they will be ugraded (so, we shouldn't make changes on these files in the application).
We may think to embed these files into dll, so user can not change them at all. But this causes additional compexity (we should write some special Http handler to get these files from dll, also write a view engine.. etc). I wanted to keep it simple.

Thanks I understand the approach.
Would you mind to share the nuget config file for generating the packages ? We would like to apply the same approach
Best Regards
Bruno

By the way, would you recommend posting questions to aspnetzero or abp fórum instead of GitHub for questions like this ?
Bruno

Hi,
This is nuhet packaging batch: https://github.com/aspnetboilerplate/sample-blog-module/blob/master/nupkg/pack_blog_modules.bat
Every project has it's own nuspec. Example: https://github.com/aspnetboilerplate/sample-blog-module/blob/master/src/Abp.Samples.Blog.Web/Abp.Samples.Blog.Web.nuspec

Yes, please post questions to the forum and bugs/feature-requests here.
Thanks

Okay I will use this behavior for now on.
Just to finish this question, regarding the copy of cshtml and js files to web projects, I couldnt find any specific configuration on nuspec file or the bat file.
Can you please point me out how can we achieve this ?
I have both files on my module web Project and would like to copy to same structure when the nuget package is installed into the "app" web Project.
Cheers
Bruno

No configuration is needed. Nuget automatically does it when it's Build Action is 'Content'.


raft: refactor inflight

Closing https://github.com/coreos/etcd/pull/4931
We shouldn't drop size field in inflights because we now optimize buffering depending on the size field (https://github.com/coreos/etcd/pull/6353).
/cc @xiang90

LGTM


Misleading restore documentation with potentially major impact

My today case was:

Restore production Postgres Server. -> A new server has been provisioned
Reconfigure separate instance of an app to point to this server -> Modified "Server" part of connection string to use new address
Run the app and test results of data migration on the restored instance.
After my tests, to my surprise I've noticed, that all the data changes I've made, happened on production database!

After some trial and error, I've drilled down to the fact, that it's not enough to change Server name in connection string. Also the database user has to be changed to the one listed on restored server resource page. This is because user has a format of username@servername, which I was not aware of having significance. One would intuitively expect user for one server not being authorized to another server.
Since documentation did not warn about this, I've noticed this subtlety after the fact and could potentially do damage to production database. Fortunately nothing major happened.
I would advise to both:

put clear warning about this in docs
consider limiting authorization, so that user of one server, is not authorized when connecting through another server

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c1e66809-0841-77bd-f898-4ab139a4f3fa
Version Independent ID: 5cce5d90-de2d-192f-e05f-a475703b0196
Content: Backup and restore - Azure portal - Azure Database for PostgreSQL - Single Server
Content Source: articles/postgresql/howto-restore-server-portal.md
Service: postgresql
GitHub Login: @sr-msft
Microsoft Alias: srranga

@artizzan we'll review your feedback and get back to you shortly. Thanks.

The thing that particularly mislead me was this phrase:
"The new server created by point-in-time restore has the same server admin login name and password that was valid for the existing server at the point-in-time chose."
That way when editing connection string, I was only paying attention at server part.
Thank you for handling this! 🍻 👍

Hi @artizzan,
sorry to hear about you experience.
We had documented about changing username under "Post restore tasks" https://docs.microsoft.com/en-us/azure/postgresql/concepts-backup#perform-post-restore-tasks. But we will clarify further in the doc page and make it clear.   We will also look into your second point on authorization.

@artizzan We will proceed to close this issue now.
If there are further questions regarding this issue, please comment and we will gladly continue the discussion.


Helm Chart, more permissions and user group service account selector

Added an initial Helm chart.
Some more choices for the permissions
Ability to select user, group or service account when giving permission.

Hey! Thanks for this pr, I will try and look at it ASAP :)

Hey! Thanks for this pr, I will try and look at it ASAP :)

👍
I've now added a Healthcheck url for Kubernetes to use, as root was giving a 400 error due to being behind Google Oauth.
I added a bit more instruction on the Oauth credential setup too.
I'm still working on a few things but this is probably the last commit on this PR.

Also the tests no  longer work nicely on your branch for me. Do they work for you? Im getting weird error messages about it so it might be me.


Fix issue with changing environment variables and compiler daemon reuse

Fixes #25029
Supersedes #25035
This addresses the issue of changing environment variables by removing some of the vendor-specific handling that was in place and creating a set of known changing environment variables that will be ignored when checking JVM compatibility in any JDK or operating system.
The previous distinction between IBM vs Apple vs Other JVMs has started to lose meaning since the old IBM JVMs have evolved and can execute on Apple hardware now and have some of the same environment variables that need to be ignored.
These environment variables are unlikely to be meaningful in any context, so now we just filter them out when checking JVM compatibility on any platform.  We do still need to understand if a JVM is IBM or not since there are differences in initial heap size and garbage collection mbean names, etc.
This PR also adds tests to validate the functionality of the switch in the Scala plugin that enables persistent compiler daemons.

@bot-gradle test this

@bot-gradle test this

I've triggered the following builds for you:

PullRequestFeedback build

I've triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test and merge

I've triggered a build for you.

Thanks a lot for the quick fix!


Optimizing ML Models with Optuna

Topic Suggestion
Optimizing ML Models with Optuna
Proposed article introduction
Optuna is the SOTA algorithm used to make changes to ML and deep learning models. It all depends on the Bayesian fine-tuning method. It stops trying combinations that don't improve our score any more and only tries combinations that do.
People who work on ML models have a hard time. In order to make it easier for us to fine-tune our model, there are a lot of tools out there. You need to make sure that our data is important and that our ML model fits on it perfectly. Here, we'll learn how to make an Xgboost regressor work even better.
When you use machine learning, a hyperparameter is a parameter that can be changed to change how the learning process works.  The values of hyperparameters can't be guessed from the data. It's important to set these parameters so that the model can learn from our data. You can change the learning parameters so that the model fits our data and learns from it to make smart predictions.
Key takeaways

Visualization of Tuning
Comparing the Tuned Model and Base Model
Creating Hyper-Parameters Space

Article quality
In this article, we'll learn how to improve ML models and how to find the best parameters for the models we make. The code will be easy to read and understand.
References
N/A
Templates to use as guides

How To Guide Template
Software Review Template
Tutorial Template

Sounds like a helpful topic - let's please be sure it adds value beyond what is in any official docs and/or what is covered in other blog sites. (the articles should go beyond a basic explanation - and it is always best to reference any EngEd article and build upon it). @NdoloBonface
Please be attentive to grammar/readability and make sure that you put your article through a thorough editing review prior to submitting it for final approval. (There are some great free tools that we reference in EngEd resources.)
ANY ARTICLE SUBMITTED WITH GLARING ERRORS WILL BE IMMEDIATELY CLOSED.
Please be sure to double-check that it does not overlap with any existing EngEd articles, articles on other blog sites, or any incoming EngEd topic suggestions (if you haven't already) to avoid any potential article closure, please reference any relevant EngEd articles in yours. - Approved

Just wanted to follow up on this topic, as we will be clearing up the queue where possible.
Just and FYI I will be closing this topic form just to help clear up the queue where possible - can be REOPENED at anytime when ready. 👍

Just wanted to follow up on this topic, as we will be clearing up the queue where possible.
Just and FYI I will be closing this topic form just to help clear up the queue where possible - can be REOPENED at anytime when ready. +1

Hello @hectorkambow this is the topic I'm currently writing on . I mentioned it earlier via slack when  I was asking about being a peer reviewer.


convert tests from mocha to fuse-box-test-runner

mocha tests use outdated createEnv and should be ported to ts, and use fuse-box-test-runner

Jest works really well with TypeScript (and then you can also use vscode-jest ) - would recommend that, if you can

as does https://github.com/avajs/ava


Missing documentation in math::utils

I'll do it. Now I'm trying to rewrite JPEG decoder (or using libjpeg-turbo/mozjpeg)

@hauleth You can assign issues to yourself to let people know you are working on it.

I have forgotten about that.

Done by 52fe43246575732cc42ba8aa66e2ab1faaab179a


Fedora: Do not duplicate system libraries e.g. zlib

I think it is best if we keep the dlopen/dlsym approach to comply with Fedoras Packaging rules. We should add proper dependencies into our spec files and ensure that the load path to the zlib.so is properly defined when building the packages, such that we avoid recursive loading and problems associated with this.

https://github.com/ibm-genwqe/genwqe-user/commit/e574f78795b43b82571a45df11fa0e84b024725b should address the issue. We should check our spec file examples to get the thing completely correct.
We need to ensure that dlopen really finds the systems zlib. Depending on the lib-search path is not optimal and might lead to recursive loading: our zlib tries to dlopen itself - bad.

Should work now. Closing the issue.