Memory Leak

I am trying to use jrsonnet as lib in an HTTP wrapper to improve performance in a high TPS system.
However we have just deployed the service and its experiencing a memory leak.

This is the util module I created, and a test which demonstrates how I use the API.
extern crate log;

use log::info;

use jrsonnet_evaluator::apply_tla;
use jrsonnet_evaluator::trace::PathResolver;
use jrsonnet_evaluator::{function::TlaArg, gc::GcHashMap, FileImportResolver, IStr, State, Val};
use jrsonnet_parser::{ParserSettings, Source};
use jrsonnet_stdlib::ContextInitializer;

type Context = (State, Val);

pub fn init() -> Context {
    let state: State = State::default();

    state.set_import_resolver(FileImportResolver::default());

    let ctx = ContextInitializer::new(state.clone(), PathResolver::new_cwd_fallback());

    state.set_context_initializer(ctx);

    let decoder = std::path::Path::new("src/decode.jsonnet");

    let Ok(import) = state.import(decoder) else {
        panic!("failed to import decoder");
    };

    (state, import)
}

fn build_tla(version: String, variant: String, message: String) -> GcHashMap<IStr, TlaArg> {
    let message: IStr = message.clone().into();
    let source: IStr = "".into();
    let message = jrsonnet_parser::parse(
        &message,
        &ParserSettings {
            source: Source::new_virtual("<top-level-arg:message>".to_string().into(), source),
        },
    )
    .unwrap();

    let mut tla_args: GcHashMap<IStr, TlaArg> = GcHashMap::new();
    tla_args.insert("version".into(), TlaArg::String(version.into()));
    tla_args.insert("variant".into(), TlaArg::String(variant.into()));
    tla_args.insert("message".into(), TlaArg::Code(message));

    tla_args
}

pub fn decode(
    context: Context,
    version: String,
    variant: String,
    message: String,
) -> Result<serde_json::Value, String> {
    let start = std::time::Instant::now();
    let (state, decode) = context;
    let tla_args = build_tla(version, variant, message);

    let Ok(result) = apply_tla(state, &tla_args, decode) else {
        panic!("failed to apply tla");
    };

    let Val::Obj(_) = result else {
        panic!("expected object, invalid decoder");
    };

    info!("decoded in {:?}", start.elapsed());

    match serde_json::to_value(&result) {
        Ok(result) => Ok(result),
        Err(e) => Err(e.to_string()),
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_decode() {
        let version = "0.0.1".to_string();
        let variant = "iso_var_visa_base1".to_string();

        let message = serde_json::json!({
            "version": "v1",
            "request_message": {
                "mti": "100",
                "elements": {}
            }
        });

        let context = init();

        let result = decode(context, version, variant, message.to_string()).unwrap();

        let cmo = serde_json::json!({
            "message":{
                "mti":"0100",
                "raw":{"elements":{},"mti":"100"},
                "variant":"iso_var_visa_base1",
                "version":"0.0.1"
        });

        assert_eq!(result.to_string(), cmo.to_string());
    }
}

This gets called in the following tokio API handler:
    let post_decode = warp::path!("decode" / String)
        .and(warp::post())
        .and(warp::body::json())
        .map(|variant: String, raw: serde_json::Value| {
            let cmo_version: String = version().to_string();

            // TODO: Cache the context for faster decoding?
            let context = jsonnet::init();

            match jsonnet::decode(context, cmo_version, variant, raw.to_string()) {
                Ok(result) => warp::reply::json(&result),
                Err(e) => {
                    error!("ERROR: {}", e);
                    warp::reply::json(&serde_json::json!({
                        "error": e,
                    }))
                }
            }
        });

This is my first crack at writing a system in Rust. Perhaps I am doing something wrong. Either, there a memory leak in the code above, or in jrsonnet itself.
If I could clone context and supply it to the decode function I could perhaps circumvent the memory leak. However I am getting the follow error when trying to do so:
error[E0277]: `NonNull<jrsonnet_gcmodule::cc::RawCcBox<EvaluationStateInternals, jrsonnet_gcmodule::collect::ObjectSpace>>` cannot be shared between threads safely
   --> src/main.rs:83:33
    |
83  |     let commands = warp::post().and(post_decode);
    |                                 ^^^ `NonNull<jrsonnet_gcmodule::cc::RawCcBox<EvaluationStateInternals, jrsonnet_gcmodule::collect::ObjectSpace>>` cannot be shared between threads safely
    |
    = help: within `(jrsonnet_evaluator::State, jrsonnet_evaluator::Val)`, the trait `Sync` is not implemented for `NonNull<jrsonnet_gcmodule::cc::RawCcBox<EvaluationStateInternals, jrsonnet_gcmodule::collect::ObjectSpace>>`
    = help: the trait `warp::filter::FilterBase` is implemented for `warp::filter::map::Map<T, F>`
note: required because it appears within the type `RawCc<EvaluationStateInternals, ObjectSpace>`
   --> /Users/anthony/.cache/cargo/registry/src/index.crates.io-6f17d22bba15001f/jrsonnet-gcmodule-0.3.6/src/cc.rs:80:12
    |
80  | pub struct RawCc<T: ?Sized, O: AbstractObjectSpace>(NonNull<RawCcBox<T, O>>);
    |            ^^^^^
note: required because it appears within the type `State`
   --> /Users/anthony/.cache/cargo/registry/src/index.crates.io-6f17d22bba15001f/jrsonnet-evaluator-0.5.0-pre95/src/lib.rs:262:12
    |
262 | pub struct State(Cc<EvaluationStateInternals>);
    |            ^^^^^
    = note: required because it appears within the type `(State, Val)`
    = note: required for `&(jrsonnet_evaluator::State, jrsonnet_evaluator::Val)` to implement `Send`

Is there any obvious issue with my code?
Or is there anyway I can clone the context?

Alternatively, if you could create a test release with https://github.com/CertainLach/jrsonnet/pull/122 I could continue with my other method of calling jrsonnet as a binary

We have identified the leak comes from ContextInitializer::new

the actual line that leaks in the above code is this:
  let ctx = ContextInitializer::new(state.clone(), PathResolver::new_cwd_fallback());

I think there must be some sort of circular reference or something like that in this ContextInitializer code.

I think there must be some sort of circular reference or something like that in this ContextInitializer code.

Yes, there is, jrsonnet uses garbage collection for such links.
You can force garbage collection of current thread reference cycles using jrsonnet_gcmodule::collect_thread_cycles() call.
Regarding State is not Sync - jrsonnet internal structures aren't thread-safe (This isn't unique to jrsonnet, all jrsonnet implementations aren't thread-safe, even go-jsonnet: https://github.com/google/go-jsonnet/issues/733), you can use I.e thread_local for this, but I would recommend you to start jrsonnet in separate process, especially if you plan to limit code in RAM/CPU usage.

Thanks! The process is run in a Thread by tokio, so I just needed to run jrsonnet_gcmodule::collect_thread_cycles(); and now we are not getting any memory leaks.
We really appreciate your rapid response! We pushing to production any day now, and this was a issue. 😅


Dramatically inefficent ObjectFactory disposing

Still same problem, error not fixed.
https://jira.spring.io/browse/SPRNET-1318

Fixed in https://github.com/spring-projects/spring-net/pull/115


[New Project]: Make GitHub Issues endless on web

Does this project already exist in the app?

[X] I have searched the existing projects

No, this project doesn't exist in the app.
Tell us about the project
Rather than scrolling pages, make Github endless, on the web.
Is the Project a DPG (Digital Public Good)

[ ] Yes
[X] No

Does the project list which Sustainable Development Goals it addresses in its labels?

[ ] Yes
[ ] No

Code of Conduct

[X] I've read the Code of Conduct and understand my responsibilities as a member of the GitHub community

Anything else?
No response

This GitHub repository is for the the website: forgoodfirstissue.github.com so your issue does not make sense.

Okay


TIGL Viwer - Rotate view by specified degree and axis with console command

Hi,
my goal is to create a gif of a rotating aircraft. In order to do this with an affordabel amount of work I would like to use a script for the TIGL Viewer console. I could find the command for viewBack() viewTop() but no command for a specific amount of degree around a specified axis.
Is there such a command or is their a different way to do this?
Thanks for your help!
Fabian

Hi @FNPeter . There is currently no such function in the tigl viewer, but it could be implemented easily.

Lots of thanks for the TIGL developers for such a quick and helpful response!


chore(package): update dependencies (#1)

update by https://greenkeeper.io/

Current coverage is 3.14% (diff: 100%)

Merging #192 into master will decrease coverage by 5.65%

@@            master      #192   diff @@
========================================
  Files            5         5
  Lines          125       127     +2
  Methods          0         0
  Messages         0         0
  Branches         0         0
========================================
- Hits            11         4     -7
- Misses         114       123     +9
  Partials         0         0

Powered by Codecov. Last update 5192b31...4c2e2f7

Thanks!


Webhooks for PR Builds

Our Jenkinsfile needs to be kicked off and get information from the GitHub PR Webhook: https://developer.github.com/v3/activity/events/types/#pullrequestevent
Currently that is not supported in OCP for multibranch or github specific webhooks. It appears that using a generic webhook is possible, but would require something to translate it: https://github.com/openshift/origin/issues/13970#issuecomment-298276316
their reasoning here: https://github.com/openshift/origin/issues/15455#issuecomment-318159076
The other option is to go directly to Jenkins and use something like this: https://github.com/jenkinsci/generic-webhook-trigger-plugin/

they way we handled it with hf was to with an app that took accepted the webhook and update / invoked the PR / MR pipeline config.
There is also this card in trello that is getting a bit stale https://trello.com/c/ucGKOKnt/1158-5-support-folders-organization-folders-and-multibranch-pipelines-pipelineintegration-evg

@mcanoy cool, sounds the "translate it" solution. Hmm yeah that was moved to devtools candidates in July it looks like.
Have you tried the generic-webhook-trigger-plugin with GH webhooks? i haven't tried that yet, but it looked promising.

I haven't tried it. Looks interesting but seems like there still has to be something in the middle to get the ref or commit value set, right? I am assuming if that was changed to the value we wanted - the pr - then it will build that instead of the ref that is in the pipeline bc.
git:
  uri: "<url to git repository>"
  ref: "<optional git reference>"
  commit: "<commit hash identifying a specific git commit>"
  author:
    name: "<author name>"
    email: "<author e-mail>"
  committer:
    name: "<committer name>"
    email: "<committer e-mail>"
  message: "<commit message>"
env:
   - name: "<variable name>"
     value: "<variable value>"


Next.js - Few Links do not work in production & all links work in development

I have built a Next.js & Express.js  application that works fine in development but in production there are few links in navigation bar and at some other places that do not work. And also after built I get some 404 like these. Here are few
https://example.com/_next/static/uskRfKy1t9bdwHxqyX7Ct/pages/question.js net::ERR_ABORTED 404 (Not Found)
GET https://example.com/_next/static/uskRfKy1t9bdwHxqyX7Ct/pages/profile.js net::ERR_ABORTED 404 (Not Found)
I have 3 links in navigation bar Home, Questions, Notifications. Home & Questions link do not work when I am on certain page, but Notification link do work from each page. I do not understand why this is happening.
<Button className={classes.button}><Link href='/index' as="/">Home</Link></Button> <Button className={classes.button}><Link href='/questions' as="/questions">Questions</Link></Button> <Button className={classes.button}><Link href='/notifications'>Notifications</Link></Button>
I have tried different things to make it work but I could not succeed.
Everything works in development

Next.js - 9.1.4

Sorry, this is an issue for a command-line tool called "hub" written in Go and has nothing to do with Next.js or Express.


devpi-client: 7.0.0 -> 7.0.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for devpi-client is: Client for devpi, a pypi index server and packaging meta tool
meta.homepage for devpi-client is: http://doc.devpi.net
meta.changelog for devpi-client is: https://github.com/devpi/devpi/blob/client-7.0.2/client/CHANGELOG
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 7.0.2 with grep in /nix/store/83msyp1fbnagi8jk8bxjg27my30zjmvc-devpi-client-7.0.2
found 7.0.2 in filename of file in /nix/store/83msyp1fbnagi8jk8bxjg27my30zjmvc-devpi-client-7.0.2

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
devpi-client

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/83msyp1fbnagi8jk8bxjg27my30zjmvc-devpi-client-7.0.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A devpi-client https://github.com/r-ryantm/nixpkgs/archive/555aac16535f7ea1e23e90e55e9813da813c2305.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/555aac16535f7ea1e23e90e55e9813da813c2305#devpi-client

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/83msyp1fbnagi8jk8bxjg27my30zjmvc-devpi-client-7.0.2
ls -la /nix/store/83msyp1fbnagi8jk8bxjg27my30zjmvc-devpi-client-7.0.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

devpi-client

Maintainer pings
cc @nlewo @makefu for testing.

@ofborg eval


Review of changes in kubernetes.conf

In commit 06b0a08c0261477d8eee2ccf2cdd0d4f7b864afe the following lines have been added to the docker-image/v1.7/debian-XXX/conf/kubernetes.conf files.
kubernetes_url` "#{ENV['FLUENT_FILTER_KUBERNETES_URL'] || https://#{ENV.fetch('KUBERNETES_SERVICE_HOST')}:#{ENV.fetch('KUBERNETES_SERVICE_PORT')}/api}"
verify_ssl "#{ENV['KUBERNETES_VERIFY_SSL'] || true}"
ca_file "#{ENV['KUBERNETES_CA_FILE']}"

After that, my Pods stopped working. They start but display no output and do not start log collections.
I replaced
kubernetes_url "#{ENV['FLUENT_FILTER_KUBERNETES_URL'] || https://#{ENV.fetch('KUBERNETES_SERVICE_HOST')}:#{ENV.fetch('KUBERNETES_SERVICE_PORT')}/api}"
by
kubernetes_url "#{ENV['FLUENT_FILTER_KUBERNETES_URL'] || 'https://' + ENV['KUBERNETES_SERVICE_HOST'] + ':' + ENV['KUBERNETES_SERVICE_PORT'] + '/api' }"
It didn't look pretty, but it worked.
Could you review this commit?
Thank you

We are experiencing the same symptoms described above by @emrocha  - fluentd pods do not produce any logs to stdout and ruby utilizes 100% of the CPU on the kubernetes node.
We were able to mitigate by pinning the daemonset image to v1.7.4-debian-elasticsearch7-1.0 (instead of the latest image)

@emrocha Good catch. Your change is good. Need to quote string with " for ruby string.

Had exactly the same issue, changing this file also worked for me. Thanks mate, that saved me a lot of time.

We have published 2.2 images with this fix.
Check it.

@repeatedly I am running from tag v1.7.4-debian-graylog-2.2 and the problem is still here ehhhhhhhhh

@repeatedly I think you meant to modify the line, not add another one in the patch

@repeatedly yeah, when I fix the duplicated line it starts working. please fix your patch

@ninja Please send the patch.

Okay. Just removed the line and now building new images: https://github.com/fluent/fluentd-kubernetes-daemonset/commit/08fcd8fc92cdc7313f29aafe6f1bf01ccafca035

thanks


Regression on skinned animation export

Hi,
I have done several tests exporting a simple scene with a skinned mesh and is failing even for the most simple cases with this exporter, for both Blender 2.79 and Blender 2.8. The same examples worked with the old exporter (glTF-Blender-Exporter).
The test samples I have done are
1 mesh and 1 skeleton
3 meshes and 1 skeleton
3 meshes and 3 skeletons. This one fails also with the old exporter.
SeveralSkeletons.tar.gz

fixed with #398


PeopleCode

Language
PeopleCode is proprietary scripting language for PeopleSoft ERP.
Additional resources
PeopleCode Syntax Highlighting for Notepad++
https://github.com/cache117/peoplecode-npp/blob/master/PeopleCodeUDL.xml

To the one implementing this: Here's a little guide to PeopleCode.


feat: convert push notification ios to typescript

Summary

Solving #29 by rewriting package to typescript.
Test Plan

What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility

OS
Implemented

iOS
✅❌

Android
✅❌

Checklist

[ ] I have tested this on a device and a simulator
[ ] I added the documentation in README.md
[ ] I mentioned this change in CHANGELOG.md
[x] I updated the typed files (TS and Flow)
[ ] I added a sample use of the API in the example project (example/App.js)

any updates on this?

I'll revisit this once TurboModule is available for OpenSource.
For now, I'd like to be up to date with the current implementation of the push notification ios in the core repository.


Support saving PNG while preserving colors under transparent pixels

Godot 3.0.2
I am writing a tool to help optimize shaders by packing various channels in R, G, B and A. The problem is, if a value in the alpha channel is zero, the PNG saver might destroys others colour channels. This is really bad in the context of shaders because you may still need them.
This option is supported by the PNG format so I think it would be nice to support it.

I don't think Godot does anything in particular to those pixels, but I
would check resource_saver_png.cpp
On Sun, Mar 18, 2018, 09:21 Marc<EMAIL_ADDRESS>wrote:

Godot 3.0.2
I am writing a tool to help optimize shaders by packing various channels
in R, G, B and A. The problem is, if a value in the alpha channel is zero,
the PNG saver destroys others colour channels. This is really bad in the
context of shaders because you may still need them.
This option is supported by the PNG format so I think it would be nice to
support it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/17611, or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z20ojSoTBXWSZ88NwnCJMeoQCZmu9ks5tfomQgaJpZM4SvQ4c
.

To my good surprise, it looks like saving a PNG with zero alpha in Godot preserves color channels... nevermind this issue then :)
However this led me to find another corner case issue, I'll post it for the record...


Can't run demo app with either node versions 8 or 10 after a rebase

Bug Report
Summary
After rebasing my fork with the current master and doing a complete reinstall of the packages i.e. rm yarn.lock && rm -rf node_modules/ && yarn install && npm run build:node, I get  the error
  ../../bin/embark run --nodashboard --nobrowser
pid 88291 listening on /Users/mulish/Desktop/gitcoin/embark/templates/demo/.embark/embark.ipc
========================
Welcome to Embark 4.0.0-alpha.1
========================
Error: Cannot find module '/Users/mulish/Desktop/gitcoin/embark/modules/debugger'

when trying to run the demo app i.e. cd into the templates/demo folder and run ../../bin/embark run --nodashboard --nobrowser
Current behavior
As explained above :)
How to reproduce

Rebase your code with the current master or clone the repo afresh
Install the needed dependencies via rm yarn.lock && rm -rf node_modules/ && yarn install && npm run build:node
cd into the demo app folder i.e. cd templates/demo/ and install the node packages yarn install
Finally try to run the demo app using the command ../../bin/embark run

Expected behavior
The demo app should run from the templates folder as needed
If you encounter an error, please create a logfile using the following command and post the output here
pid 94718 listening on /Users/mulish/Desktop/embark/templates/demo/.embark/embark.ipc
Error: Cannot find module '/Users/mulish/Desktop/embark/modules/debugger'
    at Function.Module._resolveFilename (module.js:548:15)
    at Function.Module._load (module.js:475:25)
    at Module.require (module.js:597:17)
    at require (internal/module.js:11:18)
    at Plugins.require [as loadInternalPlugin] (/Users/mulish/Desktop/embark/src/lib/core/plugins.js:66:14)
    at Engine.loadInternalPlugin [as registerModule] (/Users/mulish/Desktop/embark/src/lib/core/engine.js:55:18)
    at Engine.registerModule [as deploymentService] (/Users/mulish/Desktop/embark/src/lib/core/engine.js:232:10)
    at Engine.apply [as startService] (/Users/mulish/Desktop/embark/src/lib/core/engine.js:94:20)
    at startService (/Users/mulish/Desktop/embark/src/cmd/cmd_controller.js:142:16)
    at nextTask (/Users/mulish/Desktop/embark/node_modules/async/dist/async.js:5324:14)
    at next (/Users/mulish/Desktop/embark/node_modules/async/dist/async.js:5331:9)
    at /Users/mulish/Desktop/embark/node_modules/async/dist/async.js:969:16
    at callback (/Users/mulish/Desktop/embark/src/cmd/cmd_controller.js:124:11)
    at Dashboard.done [as start] (/Users/mulish/Desktop/embark/src/cmd/dashboard/dashboard.js:69:5)
    at start (/Users/mulish/Desktop/embark/src/cmd/cmd_controller.js:122:19)
    at nextTask (/Users/mulish/Desktop/embark/node_modules/async/dist/async.js:5324:14)
    at next (/Users/mulish/Desktop/embark/node_modules/async/dist/async.js:5331:9)
    at /Users/mulish/Desktop/embark/node_modules/async/dist/async.js:969:16
    at callback (/Users/mulish/Desktop/embark/src/cmd/cmd_controller.js:107:11)
    at Engine.callback [as init] (/Users/mulish/Desktop/embark/src/lib/core/engine.js:49:14)
    at init (/Users/mulish/Desktop/embark/src/cmd/cmd_controller.js:101:16)
    at nextTask (/Users/mulish/Desktop/embark/node_modules/async/dist/async.js:5324:14)

Please provide additional information about your system
OS: Mac OSX Mojave 10.14.1
Embark Version: 4.0.0-alpha.1
Node Version: 8.12.0 and also 10.13.0
NPM Version: 6.4.1
Sometimes issues are related to Embark's installation. Can you provide information on how Embark was installed?
I forked the repo and branched out. But on rebasing with the current master 4.0.0-alpha.1 and trying to run the demo app, I got stuck with the above error.

@mul1sh thanks for reporting this. We've had all hands on deck figuring out what went wrong there.
There were several issues, but it kind of boils down to the fix applied here: https://github.com/embark-framework/embark/commit/f9384733f83309b78877d43094f99abf48bcd95c
Can you please try again with latest master and confirm this?

@PascalPrecht thanks for the update 👍 , rebasing again then

@mul1sh hey there! Could you verify/confirm the fix?

@PascalPrecht the fix works, thanks for the swift action 🙂 I've also updated #1061 with my latest changes so it should now work with the wallet as intended.
So i think i'll close this issue then.


New version: Mozilla.Firefox.ESR.trs version 128.4.0

Created by 🥟 Dumplings.
Microsoft Reviewers: Open in CodeFlow

@wingetbot run


Does this library make sense for assessing named entity annotations?

Hello
I am interested in this library for assessing named entity annotations on text for NLP applications.
I saw the example provided in the docs where you have an audio sample that has segments annotated by several annotators. Each segment consists of a span of time (start -> end) and a label.
My use case is similar. Each segment has a start and an end, as well as a label. However, the segments are spans of tokens and not time, so they are discrete and not continuous.
Would I still be able to use your lib as in this example with CombinedCategoricalDissimilarity
Are there any issues I should be aware of?
Does the lib have other methods to deal with such use cases?

Yes, this is definitely a use case.
Besides this is showcased in the introduction paper of the gamma agreement by Mathet et al.
You can use integers to refer to the positions between your tokens with the boundaries of your Entities.
Example:
The queen Elizabeth will be received in France at the Élysée Palace ->
0 The  1 queen 2 Elizabeth 3 will 4 be 5 received 6 in 7 France 8 at 9 the 10 Élysée 11 Palace 12

Cool, I will check that paper out. Thanks for the response!


Optimize RPC device dict merge

I noticed the dict merge makes two copies of the destination dict, one inside mergedicts and one outside.  It doesn't look like we need to make a make a copy in the first place since we never compare the old and new data anywhere.
This is a ~92% speed up

Thanks


cargo-insta: 0.16.0 -> 1.7.1

Motivation for this change

Update to latest release
ZHF: #122042 (for Darwin build)

cc @NixOS/nixos-release-managers
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 122321 at b872b54a run on x86_64-linux 1

2 packages built successfully:

cargo-geiger
cargo-insta


Call cleanups from last registered to first

It seems more reasonable that cleanups are called from the last registered one to the first one,
when destruct.

I signed it!

@googlebot rescan

Thanks for the PR @codeeply. I think that this might have been a better way to implementation this from the start. However, reversing the order of callback execution could negatively impact existing leveldb users, so it's safer to keep with the existing solution. If you need a reverse cleanup mechanism for Iterator then you can implement your own in application code.
Sorry for the long delay in considering your PR. Please reopen if you want to continue this discussion.


[CARBONDATA-3662]: Changes to show metacache command

Why is this PR needed?

There is no command to show the cache occupied by each of the executors(only applicable for index server).
This command will not show per table, only per node
Example:
Driver - X bytes
Executor1 - Y bytes
Executor2 - Z bytes

Show metacache command does not show the complete cache used used by IndexServer side and Driver side. It just shows the total of both of them.

What changes were proposed in this PR?

To change show metacache command to show executor metacache, where the "executor" keyword is optional.
Added TOTAL cache value separately for Index Server and Driver.

Does this PR introduce any user interface change?

No
Yes. (please explain the change and update document)

Is any new testcase added?

No
Yes

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1524/

retest this please

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1567/

@kunal642 , @akashrn5 , please review

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1583/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1584/

retest this please

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1587/

retest this please

retest this please

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1590/

retest this please

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1615/


Handle None and String types

Codecov Report

Merging #114 (49ab6ee) into dev (97c4f25) will increase coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev     #114      +/-   ##
==========================================
+ Coverage   42.73%   42.80%   +0.06%
==========================================
  Files          34       34
  Lines        4448     4448
==========================================
+ Hits         1901     1904       +3
+ Misses       2547     2544       -3

Impacted Files
Coverage Δ

...mblyline_core/scaler/controllers/kubernetes_ctl.py
14.23% <0.00%> (ø)

assemblyline_core/dispatching/dispatcher.py
79.75% <0.00%> (+0.45%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97c4f25...49ab6ee. Read the comment docs.


Installed, but no news showing up

Hi All,
I installed the solution as specified in the instructions, but the news feed is not showing up on the form.  I checked the Bing Search on Azure and it shows as running successfully.  Any tips on how to troubleshoot?

Ditto. Does not appear to work. No news is displayed.
The Business Rules are updating the newsurl and newsapikey fields.


WIP Switch permission check from KC to Auth service

[ ] Tests

Codecov Report

Merging #2129 into master will decrease coverage by 0.02%.
The diff coverage is 18.18%.

@@            Coverage Diff             @@
##           master    #2129      +/-   ##
==========================================
- Coverage   69.04%   69.02%   -0.03%
==========================================
  Files         162      163       +1
  Lines       15146    15155       +9
==========================================
+ Hits        10457    10460       +3
- Misses       3738     3746       +8
+ Partials      951      949       -2

Impacted Files
Coverage Δ

space/authz/authz.go
22.22% <13.79%> (-6.35%)
:arrow_down:

rest/http.go
50% <50%> (ø)

controller/workitem.go
79.26% <0%> (+0.61%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93967dc...fced1a6. Read the comment docs.


Add flip vertical and horizontal in crop avatar page

like rotate buttons on crop avatar page, i need to add flip buttons in model popup on crop avatar page. And need to save the flipped image to directory

Just add them by yourself.


Automatically discover IP addtresses

The request is to add functionality to automatically add IP addresses by either scanning subnets with nmap in ipv4 or by snmp querying router for arp/neighbor tables for ipv4/ipv6. DNS requests could be made to fill the description field.

Please see https://github.com/digitalocean/netbox/wiki/Why-NetBox-Doesn't-Scan-IPs


Bug: Voyage Calculator Ignoring Daring Tilly

After using the Voyage Calculator to determine the optimal crew for a voyage, the indicator for the crew's number in that slot's list always ignores Daring Tilly. This happens regularly, so not a one-time thing.

The slot for Deputy Science Officer says Lt. Commander Spock and the indicator shows he should be the first option.

However, in the game, the list shows Daring Tilly first.
In addition, since immortalizing her, she's never been a suggested option. Of course, it could just be that her number hasn't been called up, but it does leave the doubt that the calculator is ignoring her for some reason.

This has been previously reported and is being investigated.
Daring Tilly and Lt Cmdr Spock have the same voyage CMD score, which has led to some potential sorting inconsistencies between the game and DataCore. It's likely why DataCore thinks Spock should be shown higher on your crew selection screen than Tilly, but it's not yet clear whether it's affecting the voyage calculation algorithm. (I don't think it is, but I'll look into this further in the next week or so.)

Oh, sorry. I had looked for it, but didn't see it in the open issues (disclaimer: I didn't go through each, just the ones that looked relevant).
Please let me know if I can be of any help narrowing down the cause of the issue.

No worries, I only meant to confirm that this is indeed an issue. It was first reported on our Discord, which of course not everyone checks.
I'll update this thread when the issue is resolved, or if we need more help. Thanks!

In case it's helpful, here's another pair with a tie that sort in the wrong order (Rain Robinson 5/5 and Chef Pike 4/5).

With attached player data.
player-data-issue-428.txt

Thanks for the added info! The differences between Pike and Rain here helped narrow down the potential tiebreakers. I'm guessing it might be as simple as crew name, so I'm going to try that.
Feel free to see if the numbers are more accurate on this test site (which also includes some other planned changes to the voyage calculator):
https://voyagecalc-qol23.website-i3mu.pages.dev/playertools?tool=voyage

I've had the chance to try it a few times thus far and it seems to be sorting properly now.
Loving the options for layout, by the way. Super helpful when multitasking on a phone to set up a voyage.

Thanks for the confirmation! I feel pretty good about the latest update, though there's still a chance the sorting may not be 100% correct. If you run into any inconsistencies, please let me know.
Once I get a few more confirmations, I'll move this fix and the layouts to the live site, hopefully by next week. Thanks again for your help!

I queued up a voyage yesterday, though I'm not exactly sure at what time.  The bug was still there.  I will continue to monitor, however.

I queued up a voyage yesterday, though I'm not exactly sure at what time. The bug was still there. I will continue to monitor, however.

Just to clarify, were you using the live site or the test site that @ussjohnjay had provided earlier? I have yet to encounter the sorting issue on the test site yet.

I just tested again with the test site and it sorted properly.
Sorry for the long intervals between testing. I only do it when I'm at a computer and my voyages are longer these days -- mostly thanks to your hard work!

Just to clarify, were you using the live site or the test site that @ussjohnjay had provided earlier? I have yet to encounter the sorting issue on the test site yet.

I didn't realize that there was a test site, so I was reporting on production.  I didn't realize it hadn't gone live, so ignore my report.

While I only get about one voyager per day now (thanks to your hard work!), I've made it a point to use the test site for each over the past week. Haven't run into the sorting bug yet. So, unless someone else sees something, I guess this issue can be closed once the changes go live.

The fix to this has now been merged onto the live site along with the latest voyage calculator update. Thanks for everyone's help here!


Qt api: pass payloads as pointer

What is the benefit besides skipping a copy?

The pointer argument becomes a huge foot-gun. If you let the original payloads vector go out of scope while the RequestRepeater is still around you will get unexpected behavior.
I don't see the payloads arguments used anywhere. Should we just remove it?


Slight change to wording.

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks

@kwekuako Please merge this PR. Thanks


Please update the Lingui 4.0 example code

Currently, there are only sample projects for vite-project-react-babel in js-lingui, can you update the examples using swc-plugin? Because I want to know how .swcrc is included in vite.config.ts instead of adding .swcrc. Thanks.

Hi @usercao,
please check these examples - https://github.com/lingui/js-lingui/tree/next/examples

Hi @andrii-bodnar ,
May I ask if the writing in next.config.js and vite.config.js is consistent with the example code nextjs-swc?
swcPlugins: [
  ['@lingui/swc-plugin', {}],
]

plugins: ['@lingui/swc-plugin'],

Because as far as I know, their construction methods are not the same. Is adding a vite-project-react-swc more user-friendly?


Update README.md

This is Indonesia?

Just had a quick look and I believe that repo author is not Indonesian or any relation to Indonesia. Until somebody thinks otherwise, this PR can be closed.


URGENT!

Hi Emran.
We have some issues in our repo due to the changes you made yesterday.

Issue with the uppercase in biography folder causing CI check failed. This one solved last night (midnite!) after spending a lot of time.
You changed the folder name; it causing bugs to md files with images. Those images didn't sync with md files because the links are not match. See the picture:

Things to be URGENTLY done:

[ ] Update images link
[ ] Check the preview of md files
[ ] Make sure all the md files of group member with images are updated, also the README file.
[ ] Make sure all the CI check passed
[ ] Make an issue for this bug PR
[ ] Make PR
[ ] Assign colleagues for review
[ ] After merged, on deliverable update the development column with your recent link with no lint issue

@emran-ai @GabriellaLohy  what URGENT suppose to mean ???

It was because the deadline for group project was on friday but friday morning there’s still bugs in our repo.
That’s why I created the urgent column.


Polymorphic Math methods, backwards compatibility, and polyfills

Suppose code was written with the knowledge that the Math methods will throw exceptions if given BigInt values.
// example
function myNumberOnlyApiMethod(numArray) {
  // This method should throw an exception if any of the values are BigInts
  const maxNum = numArray.reduce((prev, cur) => Math.max(prev, cur))
  // do further Number-only logic here
}

If the implementation of some methods change to allow BigInt values instead, that code will not behave as designed.
If it were necessary to call a new method to get the new behavior, then the potential for this bug would be eliminated.
It would be good to explicitly consider whether it is better to incur this risk than to add a new method.

An additional concern with changing the existing methods is that it puts transpilers/polyfillers in the awkward position of needing to defensively clobber all these builtin functions with bigint-aware versions.  These polyfills need to be included even if nothing directly references bigint in the code, since an external API could produce bigints (e.g. Math.abs(externalFunction()) needs to be able to handle bigints in case externalFunction returns one).
This is made worse because any usages of Math.pow will now need to be polyfilled for bigint, and the polyfill can't be reasonably used in ES 2015 (or earlier) contexts, since it really wants to use ** syntax.

Thanks for the comments! 😄

Suppose code was written with the knowledge that the Math methods will throw exceptions if given BigInt values.
If the implementation of some methods change to allow `BigInt` values instead, that code will not behave as designed. If it were necessary to call a new method to get the new behavior, then the potential for this bug would be eliminated.
It would be good to explicitly consider whether it is better to incur this risk than to add a new method.

This situation requires two things to be simultaneously true:

That a codebase is already supplying both Numbers and BigInts to the same function.
That the function’s returning a BigInt (instead of throwing a TypeError) would materially change the codebase’s behavior.

I would be quite surprised if the first condition were true in any codebase, and I would be even more surprised if both the first and second conditions were simultaneously true in any codebase (actually breaking something). Having said that, I do accept that someone might have done something weird in an actually used codebase—
But this is the same as extending web APIs. Many web APIs’ functions have been extended to accept broader inputs without web-compatibility problems. Examples include XMLHttpRequest’s send addEventListener, addEventListener’s third argument, and CanvasDrawPath’s path overloads (thanks @annevk). Such function-input changes have been generally considered “forward compatible”. I don’t think there is soemthing unique about extending Math functions that is different than extending web-API functions.
So I would explicitly consider this risk to be small, that the ergonomics (avoiding yet more globals for BigMath and DecMath) to be worth this small risk, and that this is in keeping with precedents set by many previous changes to web-platform APIs’ functions. I will add this to the explainer when I have time.
However, if any browser team remains concerned about web compatibility, then use-counter data would be welcome, of course.

An additional concern with changing the existing methods is that it puts transpilers/polyfillers in the awkward position of needing to defensively clobber all these builtin functions with bigint-aware versions. These polyfills need to be included even if nothing directly references bigint in the code, since an external API could produce bigints (e.g. Math.abs(externalFunction()) needs to be able to handle bigints in case externalFunction returns one).

I would imagine that any polyfilling would continue to be opt-in. Libraries generally advertise any dependencies on language features they have, e.g., “This library requires promises.” I’m not sure how extending Math would be different—if a codebase has a dependency on a library that requires Promise, then it needs to include a Promise polyfill; if it has no such dependency, then it does not need to include a polyfill. The same would go for BigInt Math: “This library requires BigInt Math.” A codebase that has no dependency on a library requiring BigInt Math would not need a BigInt Math polyfill.

This is made worse because any usages of Math.pow will now need to be polyfilled for bigint, and the polyfill can't be reasonably used in ES 2015 (or earlier) contexts, since it really wants to use ** syntax.

BigInts were added to the language after **. All engines that support BigInts also support **. (Although BigInt pow would be reimplementable without ** anyway.)
Thanks again for the comments! 😄

It is always the case that language builtins may stop throwing exceptions; code that relies on those exceptions is brittle. If you want to throw on BigInts reliably, you must explicitly check that; that’s always been the case for any types.

@shicks every single language change likely requires that; as one of the prominent polyfill authors, that’s not a burden, that’s just the way it works.

Slow rollout of engines with BigInt support (still only ~90%! Who wants to leave 10% of their potential users out in the cold? That's millions of people!), combined with lack of polyfillability of overloaded operators, are a reason why many developers still use libraries (e.g. these) instead of native BigInts. Overloading Math.* functions is going to make that approach a whole lot messier. Adding new functions as e.g. BigInt.max() would be:

easier to implement for libraries (no need to monkey-patch Math)
faster to execute (no need to have a userland type check on every Math.* function call, which aside from its direct overhead would be almost guaranteed to disable compiler optimizations)
easier to transition off of when the time comes (when native support has reached >99% or whatever a given app picks as their threshold; note that reaching x% native BigInt support will likely happen years before reaching the same x% native support for whatever this proposal will end up being, so there'll likely have to be a staged migration away from polyfills/libraries).

I don’t see why it would make anything messier. It’s very easy to feature-detect whether a function works with BigInt or not, and the less-than-five authors that write these polyfills will handle that for everyone else.

It’s certainly true that support for BigInts and BigInt Math will not reach >99% prevalence for many years, and that BigInt polyfills will be needed for a long time. But I agree with @ljharb—I’m not sure why monkey-patching Math is different than monkey-patching the many web APIs that have already been gradually extended.
In addition, any codebase that uses BigInts (but wants to accommodate the 10% of browsers that do not support them) cannot use a transparent polyfill anyway, because the native BigInt API depends on syntax (like + and instanceof). The codebase must instead use a non-polyfill library like Google’s JSBI, with the intent to later transpile their code into native Babel code when they decide that browsers are ready, years later. The codebase would look like:
JSBI.multiply(JSBI.BigInt(-1), JSBI.add(JSBI.BigInt(x), JSBI.BigInt(1)))

…with the intent to later be converted, years later, into:
-1n * (BigInt(x) + 1)

This would be little different if we extended abs, pow, and such. The library would get a few more functions:
JSBI.multiply(JSBI.BigInt(-1), JSBI.abs(JSBI.add(JSBI.BigInt(x), JSBI.BigInt(1)))

…calls to which would, years later, be transpilable to Math calls:
-1n * Math.abs(BigInt(x) + 1)

So to summarize what you just said: people won't be able to actually write Math.abs(some_bigint) for many years. You don't think that's a reason to prefer a different design, where the new stuff could actually be used soon?
I'm quite familiar with JSBI: I wrote it. And it's exactly what informs my opinion. Do you think that the whole situation around needing to use JSBI is desirable and should be repeated for more features? I think the contortions that people have to go through to use BigInts today, which are so much more cumbersome than most new JS features that can be polyfilled reasonably, are a lesson learned: don't spec future features in similar non-polyfillable ways.
(Related side note: it turns out that even the "transpile-JSBI-away" idea is, unfortunately, much easier said than done in a scenario where multiple libraries/components of a large system use BigInts and pass them between each other. Figuring out how to accomplish an atomic mass code migration, or whether an incremental transition could possibly be feasible, is a thing that developer teams actually worry about today.)
Monkey-patching comes into play once native BigInt support is sufficiently widely available that JSBI is no longer needed for emulating BigInts themselves (which brings a performance benefit).
Monkey-patching builtins is widely considered bad practice for a variety of reasons (not the least of which: compatibility issues which then impede TC39's ability to standardize future features, as happened before), but there's nuance:
Adding a nonexisting function (i.e. the pattern window.foo = window.foo || function FooPolyfill() { ... }) may be deemed acceptable due to lack of good alternative, and at least won't affect code that doesn't use window.foo.
Overwriting an existing function, however, does affect existing code that uses the function in question: it makes it slower, both by adding type checks to it, and by disabling compiler optimizations that replace the original function with a specialized instruction sequence (in a quick test with Math.pow, I'm seeing up to 30x slowdown!). If you assume that code calling Math functions is typically performance sensitive, incurring such a slowdown on existing code just so that some new code can rely on a polyfilled feature is likely unacceptable. (Another drawback of the monkey-patch-builtins becomes visible there: if you import two libraries, where one does the monkey-patching and the other relies on high performance, you have a problem.)
So yeah, you can demand existence of JSBI.abs (or MyShinyBigMathPolyfill.abs for that matter), and force developers to rewrite/transpile eventually. But at that point, why not simply spec it as BigInt.abs? Where's the drawback of that?

@js-choi About opt-in polyfilling, we have found this to be unscalable.  The library is the thing that knows what it depends on, so relying on the application (maybe transitively) depending on it to aggregate all these "extra dependencies" via some sort of documentation side-channel doesn't really work, for the same reason that NPM doesn't leave installing all the transitive dependency libraries up to the end user.  We've had great success with Closure Compiler as a central point of detection for which polyfills (both of language syntax and of standard runtime library) are required, allowing library authors to add polyfill dependencies as seamlessly as they can add ordinary library dependencies, without any work required by application authors (which would be a significant blocker in a "one version" monorepo).
While it may seem that ** is not a problem due to the order in which it came into the language, looking deeper reveals this as  false security.  As Jakob suggested, the problem of "how do you get a large codebase off of JSBI" is actually a lot more difficult than you might assume.  JSBI is not interoperable with native BigInt, and data flow across application and library boundaries is often two-way, effectively requiring an infeasible atomic migration.  The alternative is to add a compatibility shim that feature-detects and routes calls to either JSBI or native operators/methods depending on browser availability.  (This shim can be compiled out of builds targeting modern browsers, but must remain in the fallback build, which may still see native BigInts in practice).  When the fallback build targets ES 2015 or lower, ** becomes a syntax error, so it needs to be transpiled, even though (as we just established) it may end up running into native bigints.  These sorts of transpilation/polyfill issues continue even past ES 2015 due to the performance impact of monkey-patching the builtins.
Our hope has been that, once native BigInt adoption reaches 99.x% and the final "highest-requirement" service finally stops demanding support for pre-BigInt browsers, then (and only then) we'll be able to actually get rid of JSBI and start using native BigInts everywhere.  But if that would introduce these polyfill requirements on Math, then that basically moves the goalpost and pushes the GA date for BigInt back another 3-4 years.

The abs is so simple that any library can have integrated polyfill
While the spec is needed to allow to use Math.abs or BigInt.abs in the code.

don't spec future features in similar non-polyfillable ways

The committee has repeatedly rejected polyfillability as a constraint on language design - much of the language post-ES6 would have been designed differently if maintaining polyfillability was a constraint, before and after BigInt.

@ljharb It is surprising to me that as a Polyfill library maintainer that you aren't concerned by the performance implications of doing the BigInt polyfills for Math.
There is no reason to overload the methods for BigInt, it doesn't help anyone.  It just placates someones desire to not to have decide on a new namespace (or to limit the number of namespaces).
Yes, the committee can not be constrained by polyfills, otherwise you can't add features like WeakMap, WeakRef or other new capabilities, but that doesn't mean the committee should not consider what the implication of those polyfills are to the ecosystem.

@concavelenz i don’t agree those implications are particularly problematic, personally. Either way, it’s a better design for methods under “Math” to accept all mathematical data types. It very much helps me as a language user that Math methods work with all numeric primitives, and would hurt me to needlessly increase the separation between BigInt and Number (and potentially Decimal in the future)

@ljharb The problem is that there already is a separation between BigInt and Number.  The fact that Math and Number are two different namespaces is perhaps unfortunate, but as it currently stands, Math and Number operate only on numbers.  That's a pretty clean invariant to maintain.  Extending this to have BigInt methods operate only on bigints (and eventually Decimal methods operate only on decimals) is, I would argue, more consistent than a situation where the Math namespace is a grab bag of some functions that work on bigints and others than don't, and some can mix types but others can't.

I think that consistency is a subjective and variable thing, and it’s highly inconsistent that something named Math only works with one of the numeric primitives.
The separation between BigInt and Number isn’t complete; there are a number of operators that work on both.

First, I’d like to express gratitude towards everyone bringing their experience and insight about backwards compatibility, especially from Google Closure Compiler and from JSBI. Your concerns are important issues: thank you for raising them, and thank for your patience in explaining them.
This topic was originally about backwards compatibility and polyfillability. So I think that discussing what benefit polymorphic Math methods would have over separate methods probably belongs in another issue (i.e., #14). My mental model as a developer had always been that Math methods are conceptually a “extension” of the math operators, I expect many other developers to share this mental model (@ljharb and @sarahghp also seem to too), and polymorphic Math methods would match that mental model. Of course, as @ljharb says, consistency is subjective, but I think the benefits would be real. But, again, this part probably belongs more on #14.
Back on topic: There are concerns about the transition period for a codebase after it switches to native BigInt primitives but still before it can use native polymorphic Math methods.
A polyfill that monkey-patches the Number-only native Math methods would bring performance problems for all Number-only uses of the Math methods. And it would be difficult to keep the polyfill opt-in only; keeping track of the documentation of transitive dependencies is unscalable. These are all certainly true.
These problems already have a solution from the web-API space, ponyfilling. During this transition period, ponyfills would provide their own BigInt-supporting math methods separately from monkey-patching the Math methods. We would discourage any monkey-patching of Math. Eventually, many years from now, when native polymorphic Math functions are ready, the codebase would switch its ponyfill calls to use native Math functions.
Hopefully, encouraging ponyfilling rather than polyfilling should address concerns about performance during the transition period.

Let's please avoid usage of that particular term, though :-) The es-shims ecosystem calls a spec-compliant implementation a "polyfill" and installing that in the environment "shimming". We don't have to use the es-shims terms, of course, but I'd prefer we only popularize professional terms.

it’s highly inconsistent that something named Math only works with one of the numeric primitives
I think this is a wrong use of the word "inconsistent", but I mostly with the comment. I think another term would be "unintuitive", but there's the contradiction that having some methods work with BigInts may also be unintuitive. So a better term is "misleading", because how on Earth can't Math be more mathematical? Mathematics does symbolic computation, Math doesn't, it works on positional notation in base/radix 2 (AKA binary numerals), that's "mathematic enough", but intentionally preventing Math from being more generalized/extended is not mathematical at all. However, the purpose of Math wasn't to be truly mathematic, but "good enough" for most arithmetic operations with minimal-to-none algebra (Math does implicit algebra, because logarithms try to solve exponential equations doing numeric computation instead of symbolic).

But we haven't talked about bike-shedding, if Decimal ever gets added, ALL Math methods could be extended to operate with it, even transcendental ones like sin can be optimized doing modular normalization/reduction.
Another point, the cognitive load of remembering which methods work with BigInt could be equivalent to the cognitive load of dealing with multiple "copies" of the same function, from 2, 3, or even 4 different namespaces. I have no proof for this statement, but some polls may help to check it.


Update Unity.gitignore

vscode and jetbrains folders added

@Cadons I haven't heard anything on this PR in a while. Could you review the comments I've made?

@Cadons I haven't heard anything on this PR in a while. Could you review the comments I've made?

I have read your comment, what do you expect that I do? undo the edits?

@Cadons I haven't heard anything on this PR in a while. Could you review the comments I've made?

I have read your comment, what do you expect that I do? undo the edits?

You could create an entry similar to this one if you like. Otherwise I believe we should close this PR.


pull request for e2e test at 12/03/2016 07:15:02

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


using postcssModules make sass file cannot extract into a single css file

https://github.com/glromeo/esbuild-sass-plugin/blob/bc4452940e800ed18fa0761644e4f4ef3e4fddf6/src/utils.ts#L158
from the source code, when using this plugin with option postcssModulesPlugin make sass cannot extract into a single css file. is there anyway to solve this problem?i wannt to use css module and extract both

I'm facing the same issue, I wonder if this is a limitation with esbuild at the moment. Is this something that you know @glromeo ? Nice plugin by the way :-)

Sorry guys what you ask is against esbuild design. In order for the css modules to be imported they have to be specified as 'js' for the loader and then esbuild leaves their handling to the plugin with no way for that css to be part of the compact bundle you want. I left this issue open while I was getting my head around the possibility of writing myself a bundling of all the styles module into a single one but the effort of such task (considering the issue with sourcemaps) puts it out of scope

@ronkorland esbuild provides a callback for that https://esbuild.github.io/plugins/#on-end

I would also be interested in extracting the css to a separate file. @ronkorland would you mind sharing your approach?

@franckchen @yourivdlans @tiagovtristao @ronkorland
v2.7.0 brings, at long last, a solution to this CSS vs Js problem
while playing nicely with esbuild pipeline...have a try!


tiiuae/falcon-7b-instruct error - AttributeError: 'RWConfig' object has no attribute 'n_head_kv'

System Info
root@ccee50263a51:/usr/src# text-generation-launcher --env
2023-05-31T15:54:42.586976Z  INFO text_generation_launcher: Runtime environment:
Target: x86_64-unknown-linux-gnu
Cargo version: 1.69.0
Commit sha: db2ebe3947c4cb018e1504ae417f3efb9a517d89
Docker label: sha-db2ebe3

  File "/opt/conda/lib/python3.9/site-packages/text_generation_server/server.py", line 124, in serve_inner
    model = get_model(model_id, revision, sharded, quantize, trust_remote_code)
  File "/opt/conda/lib/python3.9/site-packages/text_generation_server/models/__init__.py", line 206, in get_model
    and config.n_head_kv != config.n_head
  File "/usr/src/transformers/src/transformers/configuration_utils.py", line 261, in __getattribute__
    return super().__getattribute__(key)
AttributeError: 'RWConfig' object has no attribute 'n_head_kv'

Information

[ ] Docker
[ ] The CLI directly

Tasks

[ ] An officially supported command
[ ] My own modifications

Reproduction
docker run --gpus 2 --shm-size 1g -p 8081:80 -v $PWD/data:/data ghcr.io/huggingface/text-generation-inference:latest --model-id tiiuae/falcon-7b-instruct --trust-remote-code

Expected behavior
not error

I cannot reproduce your issue. Can you clear $PWD/data/models--tiiuae--falcon-7b-instruct and see if the problem persists?

Yes, that worked!

Yes, that worked!

How to set num-shard?


HTTPS sensitive URIs

change of all http:// URIs in js/id folder to //.
(closes #2960)

see also discussion on #2681
For outbound links and api endpoints, we need to make sure the resource is available over both http and https.  I commented in the diff the places where that's not true.
Given that iD can sometimes be loaded locally, and file:// urls can break in surprising ways, maybe we should instead add the location.protocol === 'http' ? 'http' : 'https' check to iD.detect()?
Thoughts @jfirebaugh ?

This // will load the hyperlink depending on the iD's current connection status
if plain then // will go to http://
if encypted then // will go to https://

Please don't use protocol relative URLs -- as @bhousel said they fail for file://, and https is preferred even when loading the referring page on http. Therefore:

If the site supports https, use https unconditionally.
If not, look for an alternative URL.
Failing that, bug the site owner for https support.
Failing that, stick to http.

@bhousel I have updated the patch.
Please have a look.

Thanks this looks good!


Terminal.dispose should not show the panel if it is hidden

#11133

This was done via #11839 and subsequent fixes.


Fix: Use timely sorting instead of start_at

Fixes: https://artsyproduct.atlassian.net/browse/GRO-296🔒
We were sorting by started_at and that seemed to be pretty unintuitive. I'd asked on #dev-help🔒 about timely_at which I found in gravity🔒.
I just updated everything to reference that. This looks like what the old page was doing.

ty! 👍


Add Sendable conformance to PresentationState

Is PresentationState not Sendable if State is?

Closing in favor of #2086.


Tdd

Features:
New Test file solver_spec.rb
New file solver.rb
In this project, we made three exercises with the TDD method: Factorial, Reverse, and FizzBuzz.

@Munsa1 Thank you for reviewing our project.


ci: push javadoc to proper repo

Push javadocs to the docs repo.

Codecov Report

Merging #1988 (5b05135) into main (c99ff04) will decrease coverage by 18.03%.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@              Coverage Diff              @@
##               main    #1988       +/-   ##
=============================================
- Coverage     81.15%   63.13%   -18.03%
  Complexity      109      109
=============================================
  Files            88       29       -59
  Lines          3699      415     -3284
  Branches         29       29
=============================================
- Hits           3002      262     -2740
+ Misses          661      117      -544
  Partials         36       36

see 59 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


0.16.0 docs build is failing

docs.rs failed to build 0.16.0: https://docs.rs/crate/stm32f0xx-hal/0.16.0
logs
[INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap.
[INFO] [stdout] add606e904d8d00e9e83ceb3d5cf36d06acbc0cfc0cd35183e9f98ced61ac806
[INFO] running `"docker" "start" "-a" "add606e904d8d00e9e83ceb3d5cf36d06acbc0cfc0cd35183e9f98ced61ac806"`
[INFO] [stderr]    Compiling semver-parser v0.7.0
[INFO] [stderr]    Compiling typenum v1.11.2
[INFO] [stderr]    Compiling proc-macro2 v1.0.8
[INFO] [stderr]    Compiling unicode-xid v0.2.0
[INFO] [stderr]    Compiling cortex-m v0.6.2
[INFO] [stderr]     Checking stable_deref_trait v1.1.1
[INFO] [stderr] error[E0463]: can't find crate for `core`
[INFO] [stderr]   |
[INFO] [stderr]   = note: the `thumbv6m-none-eabi` target may not be installed
[INFO] [stderr]
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr]
[INFO] [stderr] For more information about this error, try `rustc --explain E0463`.
[INFO] [stderr] error: could not compile `stable_deref_trait`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: build failed
[INFO] running `"docker" "inspect" "add606e904d8d00e9e83ceb3d5cf36d06acbc0cfc0cd35183e9f98ced61ac806"`
[INFO] running `"docker" "rm" "-f" "add606e904d8d00e9e83ceb3d5cf36d06acbc0cfc0cd35183e9f98ced61ac806"`
[INFO] [stdout] add606e904d8d00e9e83ceb3d5cf36d06acbc0cfc0cd35183e9f98ced61ac806

Probably a weird docs.rs problem?

Figured it out!  Targets for docs need to be specified in Cargo.toml now.  Soucre
docs.rs setup
Local reproduction of current issue:
docker-compose run web build crate stm32f0xx-hal 0.16.0
Testing local fix:
docker-compose run -v /home/alex/git/stm32f0xx-hal/:/build web build crate --local /build
Pull request open here.


Common expression elimination should also re-find the correct expression, during re-write.

Describe the bug
The common-expression-elimination optimizer errors when there are two aggr_fn(<short_circuit>) projections. Specifically, we have a reproducer with a failure when running:
statement ok
CREATE TABLE t1(
    time TIMESTAMP,
    load1 DOUBLE,
    load2 DOUBLE,
    host VARCHAR
) AS VALUES
  (to_timestamp_nanos(1527018806000000000), 1.1, 101, 'host1'),
  (to_timestamp_nanos(1527018806000000000), 2.2, 202, 'host2'),
  (to_timestamp_nanos(1527018806000000000), 3.3, 303, 'host3'),
  (to_timestamp_nanos(1527018806000000000), 1.1, 101, NULL)
;

# cannot have 2 projections with aggr(short_circuited), with the same short-circuited expr (e.g. CASE WHEN)
statement error DataFusion error: Optimizer rule 'common_sub_expression_eliminate' failed
select t2."struct(t1.time,t1.load1,t1.load2,t1.host)"['c3'] as host, sum((case when t2."struct(t1.time,t1.load1,t1.load2,t1.host)"['c3'] is not null then t2."struct(t1.time,t1.load1,t1.load2,t1.host)" end)['c1']), sum((case when t2."struct(t1.time,t1.load1,t1.load2,t1.host)"['c3'] is not null then t2."struct(t1.time,t1.load1,t1.load2,t1.host)" end)['c2']) from (select struct(time,load1,load2,host) from t1) t2 where t2."struct(t1.time,t1.load1,t1.load2,t1.host)"['c3'] IS NOT NULL group by t2."struct(t1.time,t1.load1,t1.load2,t1.host)"['c3'] order by host;

We isolated this error to how the IdArray is generated and used. The IdArray is generated by insertion-at-index during traversal of a first visitor. This IdArray is then read during the second visitor, also by an index, but this index is incremented differently as this second visitor traverses.
As such, the second visitor finds the wrong expr, and then inserts the wrong expression. We could make small changes to fix our bug, but then broke other statements. We feel that the index-based lookup may be inherently fragile to slight changes in traversal patterns across the two visitors; as such, we have a proposed alternative which will be up in PR shortly.
To Reproduce
Full reproducer:
statement ok
CREATE TABLE t1(
    time TIMESTAMP,
    load1 DOUBLE,
    load2 DOUBLE,
    host VARCHAR
) AS VALUES
  (to_timestamp_nanos(1527018806000000000), 1.1, 101, 'host1'),
  (to_timestamp_nanos(1527018806000000000), 2.2, 202, 'host2'),
  (to_timestamp_nanos(1527018806000000000), 3.3, 303, 'host3'),
  (to_timestamp_nanos(1527018806000000000), 1.1, 101, NULL)
;

# struct scalar function with columns
query ?
select struct(time,load1,load2,host) from t1;
----
{c0: 2018-05-22T19:53:26, c1: 1.1, c2: 101.0, c3: host1}
{c0: 2018-05-22T19:53:26, c1: 2.2, c2: 202.0, c3: host2}
{c0: 2018-05-22T19:53:26, c1: 3.3, c2: 303.0, c3: host3}
{c0: 2018-05-22T19:53:26, c1: 1.1, c2: 101.0, c3: }

# can have an aggregate function with an inner coalesce
query TR
select t2."struct(t1.time,t1.load1,t1.load2,t1.host)"['c3'] as host, sum(coalesce(t2."struct(t1.time,t1.load1,t1.load2,t1.host)")['c1']) from (select struct(time,load1,load2,host) from t1) t2 where t2."struct(t1.time,t1.load1,t1.load2,t1.host)"['c3'] IS NOT NULL group by t2."struct(t1.time,t1.load1,t1.load2,t1.host)"['c3'] order by host;
----
host1 1.1
host2 2.2
host3 3.3

# can have an aggregate function with an inner CASE WHEN
query TR
select t2."struct(t1.time,t1.load1,t1.load2,t1.host)"['c3'] as host, sum((case when t2."struct(t1.time,t1.load1,t1.load2,t1.host)"['c3'] is not null then t2."struct(t1.time,t1.load1,t1.load2,t1.host)" end)['c2']) from (select struct(time,load1,load2,host) from t1) t2 where t2."struct(t1.time,t1.load1,t1.load2,t1.host)"['c3'] IS NOT NULL group by t2."struct(t1.time,t1.load1,t1.load2,t1.host)"['c3'] order by host;
----
host1 101
host2 202
host3 303

# can have 2 projections with aggr(short_circuited), with different short-circuited expr
query TRR
select t2."struct(t1.time,t1.load1,t1.load2,t1.host)"['c3'] as host, sum(coalesce(t2."struct(t1.time,t1.load1,t1.load2,t1.host)")['c1']), sum((case when t2."struct(t1.time,t1.load1,t1.load2,t1.host)"['c3'] is not null then t2."struct(t1.time,t1.load1,t1.load2,t1.host)" end)['c2']) from (select struct(time,load1,load2,host) from t1) t2 where t2."struct(t1.time,t1.load1,t1.load2,t1.host)"['c3'] IS NOT NULL group by t2."struct(t1.time,t1.load1,t1.load2,t1.host)"['c3'] order by host;
----
host1 1.1 101
host2 2.2 202
host3 3.3 303

# can have 2 projections with aggr(short_circuited), with the same short-circuited expr (e.g. CASE WHEN)
statement error DataFusion error: Optimizer rule 'common_sub_expression_eliminate' failed
select t2."struct(t1.time,t1.load1,t1.load2,t1.host)"['c3'] as host, sum((case when t2."struct(t1.time,t1.load1,t1.load2,t1.host)"['c3'] is not null then t2."struct(t1.time,t1.load1,t1.load2,t1.host)" end)['c1']), sum((case when t2."struct(t1.time,t1.load1,t1.load2,t1.host)"['c3'] is not null then t2."struct(t1.time,t1.load1,t1.load2,t1.host)" end)['c2']) from (select struct(time,load1,load2,host) from t1) t2 where t2."struct(t1.time,t1.load1,t1.load2,t1.host)"['c3'] IS NOT NULL group by t2."struct(t1.time,t1.load1,t1.load2,t1.host)"['c3'] order by host;

# can have 2 projections with aggr(short_circuited), with the same short-circuited expr (e.g. coalesce)
statement error DataFusion error: Optimizer rule 'common_sub_expression_eliminate' failed
select t2."struct(t1.time,t1.load1,t1.load2,t1.host)"['c3'] as host, sum(coalesce(t2."struct(t1.time,t1.load1,t1.load2,t1.host)")['c1']), sum(coalesce(t2."struct(t1.time,t1.load1,t1.load2,t1.host)")['c2']) from (select struct(time,load1,load2,host) from t1) t2 where t2."struct(t1.time,t1.load1,t1.load2,t1.host)"['c3'] IS NOT NULL group by t2."struct(t1.time,t1.load1,t1.load2,t1.host)"['c3'] order by host;

Expected behavior
Should succeed on all of the provided test cases. Should not lookup with wrong expr, and insert the wrong expression, during the common-expression-elimination re-writer.
Additional context
No response

I ran this reproducer on a  36.0.0 build and it works, so thus I think this is a regression:
(venv) andrewlamb@Andrews-MacBook-Pro:~/Software/arrow-datafusion$ ~/Software/DataFusionArchive/datafusion-cli-36.0.0
DataFusion CLI v36.0.0
❯ CREATE TABLE t1(
    time TIMESTAMP,
    load1 DOUBLE,
    load2 DOUBLE,
    host VARCHAR
) AS VALUES
  (to_timestamp_nanos(1527018806000000000), 1.1, 101, 'host1'),
  (to_timestamp_nanos(1527018806000000000), 2.2, 202, 'host2'),
  (to_timestamp_nanos(1527018806000000000), 3.3, 303, 'host3'),
  (to_timestamp_nanos(1527018806000000000), 1.1, 101, NULL)
;
0 rows in set. Query took 0.028 seconds.

❯ select t2."struct(t1.time,t1.load1,t1.load2,t1.host)"['c3'] as host, sum((case when t2."struct(t1.time,t1.load1,t1.load2,t1.host)"['c3'] is not null then t2."struct(t1.time,t1.load1,t1.load2,t1.host)" end)['c1']), sum((case when t2."struct(t1.time,t1.load1,t1.load2,t1.host)"['c3'] is not null then t2."struct(t1.time,t1.load1,t1.load2,t1.host)" end)['c2']) from (select struct(time,load1,load2,host) from t1) t2 where t2."struct(t1.time,t1.load1,t1.load2,t1.host)"['c3'] IS NOT NULL group by t2."struct(t1.time,t1.load1,t1.load2,t1.host)"['c3'] order by host;
+-------+-----------------------------------------------------------------------------------------------------------------------------------------+-----------------------------------------------------------------------------------------------------------------------------------------+
| host  | SUM(CASE WHEN (t2.struct(t1.time,t1.load1,t1.load2,t1.host))[c3] IS NOT NULL THEN t2.struct(t1.time,t1.load1,t1.load2,t1.host) END[c1]) | SUM(CASE WHEN (t2.struct(t1.time,t1.load1,t1.load2,t1.host))[c3] IS NOT NULL THEN t2.struct(t1.time,t1.load1,t1.load2,t1.host) END[c2]) |
+-------+-----------------------------------------------------------------------------------------------------------------------------------------+-----------------------------------------------------------------------------------------------------------------------------------------+
| host1 | 1.1                                                                                | 101.0                                                                                |
| host2 | 2.2                                                                                | 202.0                                                                                |
| host3 | 3.3                                                                                | 303.0                                                                                |
+-------+-----------------------------------------------------------------------------------------------------------------------------------------+-----------------------------------------------------------------------------------------------------------------------------------------+
3 rows in set. Query took 0.031 seconds.

I believe this was also introduced as part of the TreeNode refactor in https://github.com/apache/arrow-datafusion/pull/8891, similarly to  https://github.com/apache/arrow-datafusion/issues/9678


PyAV does not build with ffmpeg 5.x

Overview
av/stream.c uses __pyx_v_c_stream->codec->codec_type, but it is deprecated ~4 years ago and will be removed in next ffmpeg version (libavformat>58).
In https://trac.ffmpeg.org/wiki/Bump59

...
libavformat
- AVFormatContext.open_cb replaced by io_open/io_close
- AVStream.codec removed; stream information is now exported through AVStream.codecpar; for decoding/encoding the users should allocate a separate codec context
- HTTP and RTSP protocol's 'user-agent' option renamed to 'user_agent'
- ...

Expected behavior
pip install av --no-binary av works with the latest FFmpeg version
Actual behavior
Build failed due to the above compile error
Build report:
...
    src/av/stream.c: In function ‘__pyx_f_2av_6stream_wrap_stream’:
    src/av/stream.c:2257:27: error: ‘struct AVStream’ has no member named ‘codec’
     2257 |   switch (__pyx_v_c_stream->codec->codec_type) {
          |                           ^~
    src/av/stream.c: In function ‘__pyx_f_2av_6stream_6Stream__init’:
    src/av/stream.c:2875:29: error: ‘struct AVStream’ has no member named ‘codec’
     2875 |   __pyx_t_1 = __pyx_v_stream->codec;
          |                             ^~
    src/av/stream.c:2995:15: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     2995 |     __pyx_t_6 = __pyx_v_self->_codec_context->codec;
          |               ^
    src/av/stream.c: In function ‘__pyx_f_2av_6stream_6Stream__finalize_for_output’:
    src/av/stream.c:3688:130: error: ‘struct AVStream’ has no member named ‘codec’
     3688 |   __pyx_t_7 = __pyx_f_2av_5error_err_check(avcodec_parameters_from_context(__pyx_v_self->_stream->codecpar, __pyx_v_self->_stream->codec), 0, NULL); if (unlikely(__pyx_t_7 == ((int)-1))) __PYX_ERR(0, 144, __pyx_L1_error)
          |                                                                                ^~
    error: command '<here is my_gcc_path>' failed with exit code 1
 ...

Reproduction
build pyAV with latest ffmpeg library
Versions

OS: Linux

FFmpeg:

ffmpeg version N-102619-gebedd26eef Copyright (c) 2000-2021 the FFmpeg developers
built with gcc 10.2.0 (GCC)
configuration: --prefix=<my path> --extra-cflags='-fPIC -m64' --enable-shared --disable-static --enable-gpl --enable-nonfree --enable-libvpx --enable-libmp3lame --enable-libopus --enable-libwebp --enable-libass --enable-cuda-nvcc --enable-libnpp --enable-cuvid --enable-nvenc --nvccflags='-gencode arch=compute_60,code=sm_60 -O2' --enable-libx264 --enable-libx265 --enable-libfdk-aac --enable-libwebp --enable-openssl --enable-libsvtav1 --enable-libvorbis --enable-fontconfig --enable-pic
libavutil      57.  0.100 / 57.  0.100
libavcodec     59.  1.100 / 59.  1.100
libavformat    59.  2.101 / 59.  2.101
libavdevice    59.  0.100 / 59.  0.100
libavfilter     8.  0.101 /  8.  0.101
libswscale      6.  0.100 /  6.  0.100
libswresample   4.  0.100 /  4.  0.100
libpostproc    56.  0.100 / 56.  0.100

Research
I have done the following:

[x] Checked the PyAV documentation
[x] Searched on Google
[x] Searched on Stack Overflow
[x] Looked through old GitHub issues
[ ] Asked on PyAV Gitter
[ ] ... and waited 72 hours for a response.

@zzjjbb  I just build both ffmpeg and pyAV from source, and it works.
ffmpeg using branch origin/release/4.4
pyAV using tag v8.0.3
you can build PyAV from source using the Makefile in the repo

PR is welcome.

@zzjjbb I just build both ffmpeg and pyAV from source, and it works. ffmpeg using branch origin/release/4.4 pyAV using tag v8.0.3
you can build PyAV from source using the Makefile in the repo

Hello @dianyo ,
I have built according to the version you provided, but still encounter the same problem above. Could you please elaborate on your build process? thanks in advance.

What version was this tested against, FFmpeg 5.x?

I'm experiencing similar.

OS: macOS on arm64
FFmpeg: version 5.0

pip install av fails with our without --no-binary av

For those looking to use ffmpeg 4.x under macOS, you can still install it via brew, but you need to tell pkg_config where to locate the libraries:
brew install ffmpeg@4
export PKG_CONFIG_PATH="/opt/homebrew/opt/ffmpeg@4/lib/pkgconfig"
pip3 install av

I'm experiencing similar.
* OS: macOS on arm64

* FFmpeg: version 5.0

pip install av fails with our without --no-binary av

That's a slightly different issue. If we had binary wheels for arm64 you would not need to build PyAV yourself.

FWIW I am getting the same error on x86_64 GNU/Linux with ffmpeg 5.0, sadly blocking a rebuild of mine.
ffmpeg -version:
ffmpeg version n5.0 Copyright (c) 2000-2022 the FFmpeg developers
built with gcc 11.1.0 (GCC)
configuration: --prefix=/usr --disable-debug --disable-static --disable-stripping --enable-amf --enable-avisynth --enable-cuda-llvm --enable-lto --enable-fontconfig --enable-gmp --enable-gnutls --enable-gpl --enable-ladspa --enable-libaom --enable-libass --enable-libbluray --enable-libdav1d --enable-libdrm --enable-libfreetype --enable-libfribidi --enable-libgsm --enable-libiec61883 --enable-libjack --enable-libmfx --enable-libmodplug --enable-libmp3lame --enable-libopencore_amrnb
--enable-libopencore_amrwb --enable-libopenjpeg --enable-libopus --enable-libpulse --enable-librav1e --enable-librsvg --enable-libsoxr --enable-libspeex --enable-libsrt --enable-libssh --enable-libsvtav1 --enable-libtheora --enable-libv4l2 --enable-libvidstab --enable-libvmaf --enable-libvorbis --enable-libvpx --enable-libwebp --enable-libx264 --enable-libx265 --enable-libxcb --enable-libxml2 --enable-libxvid --enable-libzimg --enable-nvdec --enable-nvenc --enable-shared --enable-version3
libavutil      57. 17.100 / 57. 17.100
libavcodec     59. 18.100 / 59. 18.100
libavformat    59. 16.100 / 59. 16.100
libavdevice    59.  4.100 / 59.  4.100
libavfilter     8. 24.100 /  8. 24.100
libswscale      6.  4.100 /  6.  4.100
libswresample   4.  3.100 /  4.  3.100
libpostproc    56.  3.100 / 56.  3.100

@zupatisc not productive, we know PyAV doesn't build with FFmpeg 5. I'm still waiting for someone to step up and provide a pull request.

OK, I've had a look and the main breaking change in FFmpeg seems to be that AVStream.codec, a pointer to an AVCodecContext is gone. This member has been deprecated since at least FFmpeg 4, so no surprise there.
AFAICT this means that in our Stream class, we are going to need to have our own pointer to an AVCodecContext, which we allocate and free. There is a AVStream.codecpar structure which holds information about the codec in the context of the stream.  To the best of my understand the logic is as follows:

For input: we use AVStream.codecpar configure our AVCodecContext using avcodec_parameters_to_context
For output: we need to copy parameters from AVCodecContext to AVStream.codecpar using avcodec_parameters_from_context (which we already do)

I have a very rough patch in #910, but there seem to be some unexpected consequences so it might be a while.

For those looking to use ffmpeg 4.x under macOS, you can still install it via brew, but you need to tell pkg_config where to locate the libraries:
brew install ffmpeg@4
export PKG_CONFIG_PATH="/opt/homebrew/opt/ffmpeg@4/lib/pkgconfig"
pip3 install av

Haven't tested yet, but could this be added to the Documentation?!?  For example, in a trouble shooting section?

Not stale, see #910.
(Sorry for the noise, making stalebot go away.)

Wait, this was already merged, so I guess this issue can be closed? @jlaine

Not yet in a release (I've cherry-picked it for Debian for now)

Has this been updated as yet?

I was able to install it using this for now, although it'd be nice if it was released.
pip3 install git+https://github.com/PyAV-Org/PyAV

@uvjustin how do you feel about pushing out a PyAV release as-is? I had been hoping to bundle the API changes we mentioned in #1005 but I'm just too short on spare time. I feel the community would be best served by immediately having an FFmpeg5-compatible PyAV now.

I think we should at least make the changes mentioned in https://github.com/PyAV-Org/PyAV/pull/1007#issuecomment-1187706065 before the next release. I'll put together a quick PR.

I've tagged the release, so the wheels will be hitting PyPI as soon as CI completes (probably in ~4 hours)!


Sass Error invalid CSS - expect expression on "color.adjust()"

Describe the bug
I'm getting following error:
Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
ModuleBuildError: Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
SassError: Invalid CSS after "...1px solid color": expected expression (e.g. 1px, bold), was ".adjust($choices-pr"
        on line 149 of node_modules/choices.js/src/styles/choices.scss
>>     border-left: 1px solid color.adjust($choices-primary-color, $lightness:

When compiling CSS with following dependencies:
"choices.js": "^9.0.1"
"node-sass": "^7.0.0"
"sass-loader": "^12.0.0
"@symfony/webpack-encore": "^1.7.0" // webpack 5

To Reproduce
Steps to reproduce the behavior:

Import import 'choices.js/src/styles/choices.scss'; in CSS or JS
run yarn encore dev
See error

Can you try with the latest version of Choices (v9.1.0)? You will likely need to switch from node-sass to the sass module too (node-sass has been deprecated).

Thanks, switching to sass fixed this issue.


"Add item to cart" link broken: POST

CHECK ROUTE

Checking if a cart existed caused a redirect to /cart on adding new product


Rm airbyte engine healthcheck

cancelled the build-docs job cause it was doing the same thing taking forever again


Common Nav bar

Currently, there is no common nav bar in this website. So, if the user goes to see the profile of another person, there is no way to go back to main page without clicking back button. Making a common nav bar will also reduce repetitive code.

Please assign this task to me as part of hacktoberfest.

Okk

yeah. Thanks for pointing it out. I will be keeping this issue open if you want to contribute to the above issue you can make a pull request with the necessary changes. Happy Hacktoberfest !

Good 👍

I'll be closing the issue as it's resolved. Repo merging in 5 minutes. Thanks for Hacktoberfest contributions! Feel free to create more issues. Good luck in your future contributions!


Minor reorganization of RiskyContrib

This PR moves a function definition of RiskyContrib from the main workspace to inside the solver (which is the only place where it is used). It makes the code more readable and results in less parameters being passed around unnecessarily.
@sbenthall does such a small change merit a changelog entry?
Please ensure your pull request adheres to the following guidelines:

[x] Tests for new functionality/models or Tests to reproduce the bug-fix in code.
[x] Updated documentation of features that add new functionality.
[ ] Update CHANGELOG.md with major/minor changes.

Codecov Report

Merging #1057 (859a415) into master (1b75501) will decrease coverage by 0.00%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #1057      +/-   ##
==========================================
- Coverage   71.70%   71.70%   -0.01%
==========================================
  Files          66       66
  Lines        9984     9983       -1
==========================================
- Hits         7159     7158       -1
  Misses       2825     2825

Impacted Files
Coverage Δ

HARK/ConsumptionSaving/ConsRiskyContribModel.py
77.77% <83.33%> (-0.05%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b75501...859a415. Read the comment docs.

@Mv77 the change looks good.
It's technically a change to the API, so a changelog entry does not hurt!

Sure, I've added a changelog entry and this is now ready to merge.


Complex bindings doesn't work with js_interpreter

Invite sent https://studio.ensembleui.com/app/fyDWXl9ykQv8Rhk20Izy/screen/MjunCLT9Og1UgimKtexC
The call to List<String> bindings =  Bindings().resolve(JSInterpreter.parseCode(variable)) should return a list of applicable bindables so we can listen for changes to these bindables and re-evaluate the expression, but it doesn't work for some use cases:
Works (this return bindings = [name])
Text:
   text: ${name}

Doesn't work (this returns bindings = [] ):
Text:
  text: ${ensemble.storage.merchants[name]}

See the project for the actual output

@vusters do you expect just ['name'] to be returned here or ['ensemble.storage.merchants','name']

both please

fixed


[Launcher] Remove ASP .NET dependencies

Replaced NLog.Web.AspNetCore with NLog.Extensions.Logging

PR Checklist

[x] Applies to #2542
[x] CLA signed. If not, go over here and sign the CLA

Validation Steps Performed

PowerLauncher builds and runs.
Log files are still written in \AppData\Local\Microsoft\PowerToys\Run\Logs\1.0.0\
ASP .NET dependency is gone.

Good catch on the msi updates.

@traies Have you verified this with an msi now?  If so feel free to merge it.

@traies Have you verified this with an msi now? If so feel free to merge it.

I have, it has the issue where the PowerToys.runtimeconfig.json isn't updated correctly unless the solution is completely clean, but other than that its working.


Input layout fix

fixes #252
This pull request fixes the wrong layout displayed in the docs as stated in the issue above.

Thank you!

Thank you!

:D


Update disaster-recovery.md

Edited VSAN to vSAN to match all documentation.

@sbkuehn : Thanks for your contribution! The author(s) have been notified to review your proposed change. @dikamath

@divka78 - can you review ... also please update the 'author' section of the docfx.json global metadata to your GitHub alias divka78 (not your MS alias). Thanks.

Is this going to be merged?

@sbkuehn This PR is awaiting author review/approval, but I've verified the fix and will merge. Thanks.
-PR review team


Check price from other sources

uniswap
0x

could look at paraswap agregator https://paraswap.io/#/?network=polygon

That's right. paraswap as well


Extend repository's readme

A description of the application and its submodules should be written

The readme of the repository has been updated with:

A brief description of the system and its submodules
A bit of extra information about the technologies used by the submodules
The names, uos and the link to the github profile of each team member

I'm going to include a diagram of the whole project, explaining the interactions between the different parts (technologies) and users.
Working on it.

I think we can close this issue, in principle the README seems to be acceptable and the criteria that had been defined to be complete are met.


Databricks AutoML Failure | Notebook generation failed with TER: {"error_code":"MAX_NOTEBOOK_SIZE_EXCEEDED","message":"File size imported is (61906255 bytes), exceeded max size (50000000 bytes)"}

We are using Databricks AutoML for a regression problem. The job runs for around 5 minutes and then fails with the error :
ERROR databricks.automl.base_learner: AutoML run with experiment id:<PHONE_NUMBER>939848 failed with non-AutoML error Exception('Unable to generate notebook at /mlworkspace/mlflow_experiments/23-01-24-07:55-16. Model_Train_Automl-8af8fe13/23-01-24-07:55-DataExploration-6daa65a552c058ab075213cdd68e2ece using format JUPYTER: {"error_code":"MAX_NOTEBOOK_SIZE_EXCEEDED","message":"File size imported is (61906255 bytes), exceeded max size (50000000 bytes)"}\n')
The dimension of the dataset : (1160, 22)
Screenshot from the run -

Hi, I had the same issue and one of the contributors answered me in Twitter. I have tested it and it works fine now in RT 11.3ML.

However, I notice that when I had the same error a couple of weeks ago, the error showed that the "max size" was about 10Mb and yours is 50Mb.. I wonder if only the size limit was increased but not the underlining issue regarding automl creating a big notebook for a small dataset.


Missing label pop ups for Mapillary feature points

Description
iD has this and itis very useful when starting with these that there is a pop-op label that tells what the Mapillary feature point icon is about.
Version
2.0.0
What browser are you seeing the problem on? What version are you running?
Edge v111.0
The OS you're using
win 11
Steps to reproduce
No response
The browser URL at the time you encountered the bug
https://rapideditor.org/edit#background=Maxar-Premium&datasets=fbRoads,msBuildings&disable_features=boundaries&id=w-5&map=20.72/12.10411/-68.90102&photo=mapillary/903792870497481&photo_overlay=mapillary-map-features
The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36 Edg/111.0.1661.62

Can you send a screenshot of what you mean?  I'm not sure whether this is about the styling of the points on the map or the styling of the features in the Mapillary viewer.  (I agree we could do a much better job connecting all this information for users)

Sorry for not having expressed myself more clearly.
In Mapillary select the Map Points to be shown. In iD switch Map Features on. Then hover over such icons to activate, which will show a pop-up of what the icon represents. As there is quite a number of different Map Features, I think it is useful to have these explanatory pop-ups.
iD and Rapid have an on/off switch only for these Map Features. I think a filter as Mapillary has is better as it avoids clutter, as different editors have different causes to edit.
I cannot have the pop-up show in a screenshot, as it disappears on the keystroke to get the screenshot.


feat: add tracing capabilities to Serinus

Serinus should be able to expose a simple and intuitive API (much like the Hooks) that allows the developers to trace the timings and metrics of the application using external tools like OpenTelemetry or by appending the value to the Server-Timing header.
The system should trace various events:

All the Hooks events;
The handle of the request;
The handle of the response;

It should be moved to the next version, right now the same things can be achieved using middlewares.


add docs for blazor inside rush monorepo

Added docs on how to add a blazor pilet to a rush monorepo.
This documentation depends on this pr:
https://github.com/smapiot/Piral.Blazor/pull/69
So please only approve this after the other pr is approved.
Since i tested every step of the monorepo docs i have a test project on my pc. would you loke to host this in a repo inside smapiot?
If yes. how should i send it to you?

thanks for merging @FlorianRappl . This documentation will only work if this pull request is also merged:
https://github.com/smapiot/Piral.Blazor/pull/69


Why log 1000 info statements in a single request?

Even in the most verbose production environments -- the honeycomb event model -- the recommendation is to capture all the relevant information in a request and write that out as a broad "high cardinality" log statement at the completion of the request -- that would be one info statement per request.
Even in a debugging circumstance, I'd consider 1000 statements in a request to be very high.  What's the reasoning behind this?

Yes indeed, this a constructed example, however I've seen real-world apps that logged a lot per single business use case, which indeed was the inspiration to write up these blog posts after a specific recent project.
The reasoning was to show the performance impact writing text-based logging statements has on our application. For that, and to compare different approaches, I wanted a high pressure on the logging impl hence that many statements.


pubsub permission question regarding getTopic and getSubscription

We would like to have a service account with access only to subscribe to a topic and not t to publish or create anything else than create its subscription on one topic if the subscription doesn't exists.
Given the code below what is needed to get it to work without granting access to the actual project?
  private static void ensureTopicAndSubscriptionExist(
      PubSub pubsub, String topic, String subscription) {

    if (pubsub.getTopic(topic) == null) {
      throw new IllegalStateException("Topic does not exist: " + topic);
    }

    if (pubsub.getSubscription(subscription) == null) {
      LOG.info("creating PubSub subscription={} for topic={}", subscription, topic);
      pubsub.create(SubscriptionInfo.of(topic, subscription));
      LOG.info("created PubSub subscription={} for topic={}", subscription, topic);
    }
  }

We only get this to work if the service account user has edit rights on the project

Hi @fonzy2013!
Did you have a look at the Access Control page in Pub/Sub docs? From your code it seems that you need to be able to get topics, get subscriptions, subscribe to topics and pull messages.
From the docs it seems that you need to grant to the user the following roles:

Pub/Sub Viewer: allows to get/list topics and subscriptions
Pub/Sub Subscriber: allows to create subscriptions and pull messages
Have you tried this?

If you already know the topic/subscription you want to grant access to you should be able to grant the above permissions only on the topic/subscription you are interested in.

Thanks, it doesn't work so I guess I will file a support ticket elsewhere as here is only for the high level java api...

Sounds like a plan, I am closing this but please feel free back what the solution to the problem was!

OK


[Improvement][Audit] Change time to create_time

close #15845

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.48%.  Consider uploading reports for the commit ada8d4a to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #15846   +/-   ##
=========================================
  Coverage     39.47%   39.48%
- Complexity     4993     4995    +2
=========================================
  Files          1347     1347
  Lines         45641    45606   -35
  Branches       4892     4869   -23
=========================================
- Hits          18018    18007   -11
+ Misses        25699    25675   -24
  Partials       1924     1924

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.