Error: Invalid flow specified on adding a car

Describe the bug
I had two accounts - one for skoda and one for powerpass. To allow powerpass automatically authenticate on my car, I logged in to the car using the powerpass account. Same for skoda app. Afterwards, the car stop reporting the charging data etc. under the old skoda account.
I therefore removed the skoda account from the integration and tried to add the new powerpass account.
Provided login name and password, got a screen "Loading next steps for skoda connect" and received error "Invalid flow specified".
Logging back in with the old account also did not work.
Reinstalled the integration, tried again (found this on different bug here on github). Did not work.
Removed the HACS integration, restarted HA, re-installed integration.
Tried again to login using the powerpass, same error.
Tried again to login using skoda account works, but does not provide the data again.
Is this working in MySkoda app?*
Yes, logged out and in on 2 different phones, all works.
Latest working release
Working with skoda account using release 1.2.12, same release does not work with powerpass.
Debug logs
Found 2 interesting things in logs:
2024-07-04 14:33:33.798 ERROR (MainThread) [skodaconnect.connection] Received unhandled error indicating client-side problem.
Restart or try again later.
2024-07-04 14:33:33.798 ERROR (MainThread) [custom_components.skodaconnect.config_flow] Fetch vehicles failed with error: No vehicles were found for given account!

and another one:
2024-07-04 14:37:00.355 WARNING (MainThread) [homeassistant.helpers.frame] Detected that custom integration 'skodaconnect' calls async_forward_entry_setup for integration, skodaconnect with title: xxxxxxxxxx and entry_id: xxxxxxxxxxxxxxx, which is deprecated and will stop working in Home Assistant 2025.6, await async_forward_entry_setups instead at custom_components/skodaconnect/__init__.py, line 256: hass.async_create_task(, please create a bug report at https://github.com/skodaconnect/homeassistant-skodaconnect/issues
2024-07-04 14:37:00.395 WARNING (MainThread) [homeassistant.helpers.frame] Detected code that calls async_forward_entry_setup for integration skodaconnect with title: xxxxxxxxxxxx and entry_id: xxxxxxxxxxxxxxx, during setup without awaiting async_forward_entry_setup, which can cause the setup lock to be released before the setup is done. This will stop working in Home Assistant 2025.1. Please report this issue.
Stack (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/usr/src/homeassistant/homeassistant/__main__.py", line 223, in <module>
    sys.exit(main())

Installation:

Home Assistant variant: Hass OS core 2024.7.0, OS 12.4, frontend 20240703.0
Python version N/A
Python library versions N/A

Additional context
N/A

First thought is that moving to the Powerpass account gets you into the same situation as users with new accounts/cars (e.g. https://github.com/skodaconnect/skodaconnect/issues/126) where the car data is no longer found by the old API (used by HA and MySkoda Essentials App) and only the new API (used by the newer MySkoda App) works.

Would you be able to guide me to "capture" somehow the API communication, perhaps? I would be glad to contribute, but my python-mojo is microscopic :)
My other idea would be to use OBD2 and android phone to report the data to HA using MQTT - that's about as far as my scripting skills go :)

Thanks but for Enyaq we already have more than enough data. Feel free to join our Discord for further discussion and updates. https://discord.gg/826X9jEtCh


Add IRegExpResult

Interface that matches the return value of String.prototype.match and RegExp.prototype.exec
Currently we need to use a cast to access the "index" and "input" properties.

Restarted the Travis build, since I suspect it was a flaky timeout.

Actually this seems to have already been done.
https://github.com/google/closure-compiler/blob/master/externs/es3.js#L2098


Enable landing pages via CTP categories

Accepting either a particular root category for nav menu or fallback to all root categories.

Duplicated https://github.com/commercetools/commercetools-sunrise-java/issues/378


Updated unix-dgram

Installation is failing for node 12.
unix-dgram fixed it in 2.0.3.

@phuesler is this repo abandoned or will this be looked into sometime soon?

@OmgImAlexis As much as I want to say no, the fact that it took me over a month to reply tells me that, yes, this repo is abandoned until I find new maintainers. I'm sorry.


wrong result

I have executed your program and the parameter is "im0.png im1.png 60 1 3 3 5 9”, then I get the disparity as follow.

Hello,
I'm not able to reproduce your output.
Is the provided demo script Dispev.bat producing the expected output?
In case it does, please remember that my implementation of the matching algorithm for stereoscopic disparity evaluation is asymmetric: if you swap the inputs, the output will be incorrect since the algorithm will search for correspondence in one direction only.
This might be the cause of your unexpected result.


Allow NIOSocketConnector to use a proxy transport if configured

It's possible there is a forwards proxy configured in the JVM (see java.net.Proxy and java.net.ProxySelector).  Allow a proxy transport to be injected into the NioSocketConnector to possibly handle these cases.

closed by pull request https://github.com/kaazing/enterprise.gateway/pull/39


Add a report issues feature

Add report issues feature leading users to github issues page (or use api).

Enable attaching log file (See #28)

Only way to post an issue on github is to be authenticated. Will people actually do that?
Would be better to do this via email.


Revert Shared directory breaking changes from main

Revert: https://github.com/microsoft/FluidFramework/pull/9087
Revert: https://github.com/microsoft/FluidFramework/pull/9451

🎂 LGTM, and also see my comments about BREAKING.md. Not sure how to handle this case there, maybe it's fine to just revert it, or maybe we should leave a note that in 0.58.2000 there was an accidental breaking change made (maybe don't even need to document it in depth). @heliocliu what do you think?

i think it's fine to leave it out of the breaking.md for now.  deprecating the broken version on npmjs probably makes more sense for that


fiona.errors.SchemaError: cannot convert to GBK

The following error happens whatever encoding set I use, GBK,UTF8,GB2312 etc . Is it an error due to GDAL ?
Traceback (most recent call last):
File "F:/WorkSpace/PyScriptTest/src/test.py", line 66, in
gdf.to_file('gdfrSS',driver='ESRI Shapefile')
File "D:\ProgramData\Anaconda3\envs\gdal2\lib\site-packages\geopandas\geodataframe.py", line 504, in to_file
to_file(self, filename, driver, schema, **kwargs)
File "D:\ProgramData\Anaconda3\envs\gdal2\lib\site-packages\geopandas\io\file.py", line 128, in to_file
filename, "w", driver=driver, crs=df.crs, schema=schema, **kwargs
File "D:\ProgramData\Anaconda3\envs\gdal2\lib\site-packages\fiona\env.py", line 396, in wrapper
return f(*args, **kwargs)
File "D:\ProgramData\Anaconda3\envs\gdal2\lib\site-packages\fiona_init_.py", line 263, in open
**kwargs)
File "D:\ProgramData\Anaconda3\envs\gdal2\lib\site-packages\fiona\collection.py", line 162, in init
self.session.start(self, **kwargs)
File "fiona/ogrext.pyx", line 1123, in fiona.ogrext.WritingSession.start
fiona.errors.SchemaError: Failed to create field name 'A_1': cannot convert to GBK
Process finished with exit code 1

@CUG499251662 that error arises from https://github.com/OSGeo/gdal/blob/3d7e5546f40bcefb6e0c56e1227aad2a4b4285ee/gdal/ogr/ogrsf_frmts/shape/ogrshapelayer.cpp#L1765-L1770 and tells me that your GDAL/OGR library build does not include the libiconv support that we expect. The problem is downstream from the Fiona and GeoPandas project and I am going to close this issue. If you installed geopandas and fiona using the conda-forge channel, you should report the problem at https://github.com/conda-forge/gdal-feedstock. If you installed geopandas and fiona using the default anaconda channel, you will have to report the issue to the anaconda project.


Clone-based and interactive recommendation for modifying pasted code

http://dl.acm.org/ft_gateway.cfm?id=2786871&ftid=1615595&dwn=1&CFID=725641379&CFTOKEN=87982003

This paper implements a a proof-of-concept tool named CCDemon, which is an Eclipse plugin.


[terra-avatar] Fix image flicker (when possible)

Summary
Fixes the image briefly flickering when updating Avatar props by storing the image in the state so a new image doesn't have to be generated upon rerendering if image, alt, and variant props haven't been updated.
I looked into hooking shouldComponentUpdate in terra-image but it had no effect on the issue.
There is a test page added but the effect will have to manually be observed because I could not get an automated test to see the flicker.
Additional Details
Closes #1334
Thanks for contributing to Terra.
@cerner/terra

Functional review complete.  Some image resizing was noted on Edge and IE10/11 (and later Chrome on further investigation by @Blackop778 ) when changing between the initials v. image versions of the Avatar.  This variance was noted to exist in Master and is unrelated to the work completed in this PR.  A new issue will be logged to address the sizing issue.  In terms of the PR in question, no new issues identified were identified.


Refactor/variables

Update legacy variables value with same value in design tokens.
Move variables into individual files, to prepare for Web Components with integrated style.

TLDR; Just variables reorganization

In fact, it's just splitting packages/base/core/src/less/_variables.less monolith into multiple files that could be easily imported when we will migrate to WebComponent with Shadow DOM.
It will change absolutely nothing for the /dist files for now.

Hum doesn't that mean that some variables are duplicated then ? @AxelPeter

No duplicates, only a big file splitted in multiple files :)


Observation Fetching

We need the ability to query all of or a subset of observations for a datastream

[x] The frontend needs to loop through the nextLinks and append the full dataset into the observations store
[x] Bug: SensorThings always returns a nextLink, even when there isn't another page of data
[ ] Bug: The nextLinks don't include all of the query parameters of the original request. For example $resultFormat=dataArray is missing

Updated the frontend to loop through the nextLinks add add the data to the observations store. This works with the first page and should work for the rest once Ken has updated the nextLinks to include all the original query parameters


Use automatic broadcasting instead of F.repeat

Jenkins CI test (for commit 1d33cdaf10bdf11e084222aca4aa87f274274658, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

Jenkins, test this please.

Jenkins CI test (for commit 1d33cdaf10bdf11e084222aca4aa87f274274658, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

@YoshikawaMasashi This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?


feat(store,world): add popFromField

Just changing Store/World API, not tablegen, to avoid conflicts there. Can be another PR a bit later, or wait and update this one.
After the tablegen part this should unblock https://github.com/latticexyz/mud/pull/583 (unless @yonadaaa also needs a partial getItem method)

lgtm! How does the world contract size look with this addition?

20.444 -> 21.535 similar increase to updateInField at ~1kB


Update tutorial README links

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "patch-1" git@github.com:missingcharacter/infrakit.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.


Update the README for Docker Desktop (Windows) users

Cool, that is really useful. The saving is a bit strange, though, I think most people won't use that.

I agree the saving is weird. Maybe we should remove it altogether?

Yeah, the saving is pretty universal for any Docker container. Though it helped me here to understand how globally Docker images works by giving me an example 🤣


Xiaomi WXKG11LM - triple action

Good morning.
I noticed a problem with the Xiaomi WXKG11LM button. More specifically with the action "triple".
After pressing the button three times in the domoticz logs the following will appear: (Zigbee) Unable to find selector switch level for value "triple"
All other functions (single, double, quadruple, hold) work fine.
Where to look for the cause?

Additional information
Zigbee2MQTT version: 1.16.2
Python version: 3.7.3
Domoticz version: 2020.2
Plugin version: last

Hi all,
i have the same problem with
WXKG01LM | MiJia wireless switch
Single, double, quadruple, hold and release works fine,
but tripple is not :-(

Hi all,
i have the same problem with
WXKG01LM | MiJia wireless switch
Single, double, quadruple, hold and release works fine,
but tripple is not :-(

I couldn't get the triple click to work either. But I noticed that in the documentation here the action is spelled as tripple (with 2 p's). I didn't see triple nor tripple in my mqtt logs. single and double where fine and I could see them in the logs.
Maybe somewhere in the code the tripple and triple spelling gets mixed up and the action gets lost?

I couldn't get the triple click to work either. But I noticed that in the documentation here the action is spelled as tripple (with 2 p's). I didn't see triple nor tripple in my mqtt logs. single and double where fine and I could see them in the logs.
Maybe somewhere in the code the tripple and triple spelling gets mixed up and the action gets lost?

Can someone please test if the issue is still valid?

My part of the issue still is. Same as it was January 23th.

Closing the ticket as it is zigbee2mqtt issue itself not the plugin one, hopefully will be fixed once


Rename RootWidget::get_element to RootWidget::child_mut

Huh. It's weird the test fails. I did a rust-analyzer rename, it should have covered all uses.

Oh, it missed doc tests.

Good that CI is catching this already :)

Oh, it missed doc tests.

Btw. relevant for this: https://github.com/rust-lang/rust-analyzer/issues/9573


Surprising derivation path

Was given mnemonic by app:
caught excite leaf elevator silent giggle butter what damage broccoli degree general by the app.
I would expect first address to be:
m/44'/2'/0'/0/0 | LQ3nQyttveLNmhaZsf7JCwtR5WiRZEy2bM

Instead, I got the address:
Lbvw57i9UoJoGTftzdjMLqcybv9Jgm7wPm

Which is:
m/0'/0/0 | Lbvw57i9UoJoGTftzdjMLqcybv9Jgm7wPm

m/0'/0 is like a "Multibit" path which is no longer supported.
Shouldn't the app use a standard BIP0044 scheme, so that it's compatible with other wallets?

Closing due to inactivity. I imagine derivation for P2PKH addresses with breadwallet-core to always be done with m/0'/0. Perhaps they will use standard conforming derivation paths when P2WPKH is implemented?


gen: do not set */* as Content-Type, wrap request/response to add way to set Content-Type instead

Currently, we don't set any pattern as  Content-Type  response header and let net/http to guess. See #372.
For request media type patterns we return ErrNotImplemented.


Todo List Drag Drop Within a Column

Allow drag and drop within a column to switch tasks around to help with prioritization. Currently allows drag and drop between columns, but it automatically moves task to the bottom of the list. Need to allow user to switch order of tasks within a column.

Closing, we reassessed and decided that drag and drop between columns is the final functionality we need. This could be an enhancement to pursue later on.


[BUG] Event Hubs samples are not showing up in docs.microsoft.com/samples/browse

We expect all the samples that live in this repo to show up in https://docs.microsoft.com/samples/browse
We do this by adding the right metadata in the readme file that lives in the folder that has the samples.
If you see this search query for Event Hubs samples in Java, you see the one for checkpoint store that mirrors the samples in this repo, but you don't see one for Event Hubs SDK itself.
Compare this with the search query for Event Hubs samples in JS and you will see samples for both Event Hubs SDK and the checkpoint store

/cc @JonathanGiles

The search query for Service Bus samples in Java does show the right results. So, perhaps we can use the metadata in the readme file for Service Bus samples as a reference

Fixed with PR #20474

yay! Thanks!


Crops: Add Emerald Pumpkin

Add emerald pumpkin as a valid crop type. Create sprite and growth specifications.

Graphics added.

Implemented.


Login auditing on Linux

Cannot configure successful login auditing on Linux
There is no Security tab for a Linux SQL Server, this page needs updating.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7a5731fb-8c19-a127-e994-b4bb23835222
Version Independent ID: f72b70a9-daa8-eac3-2399-8e52b6398786
Content: Configure Login Auditing (SQL Server Management Studio) - SQL Server Management Studio (SSMS)
Content Source: docs/ssms/configure-login-auditing-sql-server-management-studio.md
Product: sql
Technology: ssms
GitHub Login: @markingmyname
Microsoft Alias: maghan

@CraigSQL -- Craig, thank you for your feedback.
@markingmyname -- Mark, please look into this issue.

#reassign @erinstellato-ms

@erinstellato-ms Following up. Is there any further action required, or can we close this issue?

@rwestMSFT I think I still need to update the docs here.


Some issues with enums management in API

Problem description
I'm seeing several issues with the current way enums are managed in the api, making them unpractical to work with:

frequent confusion in how to refer to enum: as their yaml key, or upper camel case? both are used depending on the context
lack of type enforcement: enums are defined as string.
multiplicity of definitions: enum values are set in different places (enum struct + api.go const), developers need to make sure these defs are always sync'ed; plus, they are sometimes referred to as CamelCase strings equivalent.
some boilerplate to add when a new enum field is created: a conversion function + a declaration in enum.go

Example of usage that I find confusing:
What doc says:
         balancer: (enum) one of the following:
             roundRobin: RoundRobin balancer
             leastBytes: LeastBytes balancer
             hash: Hash balancer
             crc32: Crc32 balancer
             murmur2: Murmur2 balancer

How enum is defined:
type KafkaEncodeBalancerEnum struct {
	RoundRobin string `yaml:"roundRobin" json:"roundRobin" doc:"RoundRobin balancer"`
	LeastBytes string `yaml:"leastBytes" json:"leastBytes" doc:"LeastBytes balancer"`
	Hash       string `yaml:"hash" json:"hash" doc:"Hash balancer"`
	Crc32      string `yaml:"crc32" json:"crc32" doc:"Crc32 balancer"`
	Murmur2    string `yaml:"murmur2" json:"murmur2" doc:"Murmur2 balancer"`
}

This structure is sort of a hack to allow documentation and also to perform conversions via reflection. It isn't used to carry data.
Usage in yaml:
      kafka:
        address: <IP_ADDRESS>:9092
        topic: topic1
          balancer: roundRobin

Usage in go code:
	var balancer kafkago.Balancer
	switch config.Balancer {
	case api.KafkaEncodeBalancerName("RoundRobin"):
		balancer = &kafkago.RoundRobin{}
	case api.KafkaEncodeBalancerName("LeastBytes"):
		balancer = &kafkago.LeastBytes{}
	case api.KafkaEncodeBalancerName("Hash"):
		balancer = &kafkago.Hash{}
	case api.KafkaEncodeBalancerName("Crc32"):
		balancer = &kafkago.CRC32Balancer{}
	case api.KafkaEncodeBalancerName("Murmur2"):
		balancer = &kafkago.Murmur2Balancer{}
	default:
		balancer = nil
	}

It's the usage in go code that I find very confusing: it doesn't use the documented format in strings, but uses upper camel-case instead. Moreover, it lacks of type enforcement, as it accepts any string in the switch statement, making it more bug-prone if a wrong value is provided, or in case of typo, etc.
Proposal
Instead of all of this, I wish we had just one reference point to declare enums, and make it as a type alias for better type enforcement:
type MetricFilterEnum string

const (
	MetricFilterEqual MetricFilterEnum = "equal"
	MetricFilterNotEqual MetricFilterEnum = "not_equal"
	MetricFilterPresence MetricFilterEnum = "presence"
	MetricFilterAbsence MetricFilterEnum = "absence"
	MetricFilterRegex MetricFilterEnum = "match_regex"
	MetricFilterNotRegex MetricFilterEnum = "not_match_regex"
)

type MetricsFilter struct {
         # ...
	Type  MetricFilterEnum `yaml:"type" json:"type" doc:"the type of filter match (enum)"`
}

We would remove:

enum values as constant definitions in api.go
enum reference in enum.go
the enum struct that is only there to carry doc & perform conversions by reflection
the conversion function

The downside is that we'd loose the enum values documentation. We cannot have doc markers on constants.
An option could be to use go documentation, and add some logic to the docgen scripts to use go doc to extract this documentation and inject it in the api doc file:
The go constants would be documented as such:
const (
	// match exactly the provided filter value
	MetricFilterEqual MetricFilterEnum = "equal"
	// the value must be different from the provided filter
	MetricFilterNotEqual MetricFilterEnum = "not_equal"
	// filter key must be present (filter value is ignored)
	MetricFilterPresence MetricFilterEnum = "presence"
	// filter key must be absent (filter value is ignored)
	MetricFilterAbsence MetricFilterEnum = "absence"
	// match filter value as a regular expression
	MetricFilterRegex MetricFilterEnum = "match_regex"
	// the filter value must not match the provided regular expression
	MetricFilterNotRegex MetricFilterEnum = "not_match_regex"
)

Then with go doc -all -short -C pkg/api MetricFilterEnum and some sed magic, this could be reinjected into docs/api.md.
This is not as pretty as the current implementation in terms of doc generation, but IMO we should favor code quality over this.

Hey @KalmanMeth @OlivierCazade @jpinsonneau , any thoughts to share on this? Personally I'd like to go forward for the gains it would provide (better type safety / less duplication etc.) and do the changes but I recognize there's a drawback especially wrt. the doc tag on enum that needs to be done differently

@eranra Your input would also be appreciated.

I'm fine going that direction as soon as the doc is kept :+1:
Let's just ensure to refactor all at once to avoid keeping both approach

I agree that some of the enums are not really used in the coding and it is confusing and error-prone for the programmer. At the same time we need to clearly define the legal values used for the various parameters. I think we should strive to make the use of the enums uniform across the various stages, and at the same time include (one way or another) the possible values in the documentation. If we have a decent solution on how to document the parameter values directly from the code, then I am OK with the proposed changes.

thanks @KalmanMeth @jpinsonneau
I updated the current PR to refactor all at once as Julien suggested. @KalmanMeth , the current documentation is fully preserved - it's just that the doc gen script is less straightforward to understand, but in the end it's still just about running make doc and the output still lists all enum values


fix(ec2.js): ignore cases of irrelevant response

:tada: This PR is included in version 1.107.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


broken hyperlink at https://github.com/microsoft/presidio/blob/master/docs/install.md#L5

Describe the bug
In https://github.com/microsoft/presidio/blob/master/docs/tutorial_analyzer.md#using-the-analyzer-service  "Install Presidio" link goes to 404
To Reproduce
Steps to reproduce the behavior:

Go to https://github.com/microsoft/presidio/blob/master/docs/tutorial_analyzer.md#using-the-analyzer-service
Click on "Install Presidio"
3. Scroll down to '....'
See error 404

Expected behavior
Presidio install instructions .md
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

Hi @AlexanderTyan , we've renamed "install.md" to "deploy.md" and probably missed this reference. A contribution would be great if you're interested.
Should reference to https://github.com/microsoft/presidio/blob/master/docs/deploy.md

cool just did a PR


[AWIBOF-7170] ARION supports POS dump and ASAN options

Signed-off-by: isaac.baek<EMAIL_ADDRESS>

수고하셨습니다!!!


[Event Hubs] add enqueueTime to Process span links

This PR is for issue #9599, which has a dependency on #10765.

/azp run python - eventhub - ci

/azp run python - eventhub - ci

/azp run python - eventhubs - tests


Temporal indexing in Wicker

Summary

Enable temporal indexing in wicker

Review guide

@isaak-willett @aalavian - Please review them, I need atleast one of your +1 as an approval to merge

@varshaparthay this all looks awesome! Left a couple comments but also one question. Is the cpp code a direct copy from l5ml datastore? If it is I won't review it in depth unless you want me to.

Running one final test before merge


Point out where to change the number of compilation workers

https://github.com/pivotal-cf/onboarding-week/blob/9f0a832bc848bc696eddea6946d33bd579e403be/deploy_oss.prolific#L260
This should be more clear. In the .yml, you should edit the workers line under the compilation section.

@kdolor-pivotal thanks for the suggestion. I've addressed it in 31d9be4


feat: add list_and_lock_head, delete_request_lock, prolong_request_lock methods

Python code after a long time, rather check it carefully. 😄

I just realized, you should also bump the version and update the CHANGELOG.md

how about we automate this going forward?

how about we automate this going forward?

I kind of like the versioning flexibility this gives us, plus we weren't making that many changes to these libraries for it to be worth investing the time into. But maybe there is some easy solution for this.


[MINOR] fix some places are not elegant, as a newcomer

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contributing.html before opening a pull request.

What is the purpose of the pull request

fix toString of InsertBucket
fix inelegant code of pattern like "if not null" in RollbackHelper

(For example: This pull request adds quick-start document.)
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
yes
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[x] Has a corresponding JIRA in PR title & commit

[x] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

LGTM, thanks @baobaoyeye

Please merge @lamber-ken, and how about changing the title to [MINOR] use Option and fix description in toString method ?

Please merge @lamber-ken, and how about changing the title to [MINOR] use Option and fix description in toString method ?

Got, thanks


Kotlin examples are written in Java

The client libraries page for Kotlin is the same as for Java. Also all examples are written in Java and not in Kotlin. Hence, I would suggest to either remove it or convert the examples into Kotlin
URL for relevant page?
http//<IP_ADDRESS>/client_libraries/libraries/kotlin/

@fezu54: Please be aware the the link you posted does not point to the official InfluxDB documentation. We don't maintain the content there, and can't vouch for its authenticity or security.

Moving this issue to our https://github.com/influxdata/influxdb-client-java repository.
Please review Kotlin examples https://github.com/influxdata/influxdb-client-java/tree/master/client-kotlin here and update as needed for accuracy to reflect distinctions between Java and Kotlin as needed.


Fix external postgresql error on dev vm vagrant up

Fix external postgresql error on dev vm vagrant up.
==> database: Running provisioner: chef_zero...
The chef binary (either `chef-solo` or `chef-client`) was not found on
the VM and is required for chef provisioning. Please verify that chef
is installed and that the binary is available on the PATH.

This gets us past the first error (above) and onto a second one.
Signed-off-by: Lincoln Baker<EMAIL_ADDRESS>
[ ] New functionality includes tests
[ ] All buildkite tests pass
[ ] Full omnibus build and tests in buildkite pass
[ ] All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/main/CONTRIBUTING.md#developer-certification-of-origin-dco
[ ] PR title is a worthy inclusion in the CHANGELOG

https://buildkite.com/chef/chef-chef-server-main-omnibus-adhoc/builds/3558#67cf7618-28cb-4eb3-869c-9d362dd5da51
https://buildkite.com/chef/chef-umbrella-main-chef-server/builds/945


build: include more directories

What's in this pull request?

Resolved bug number: (SR-)

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    OS X platform               | @swift-ci Please test OS X platform
    Linux platform              | @swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

llvm/Support/Compiler.h recently grew a dependency on llvm-config.h.  This
pointed out that we were not including the path to the generated header
directory in the build output.  Ensure that we have the corresponding -I.

@swift-ci please test

@swift-ci please test

The errors are unrelated to this change.

Re-testing...
@swift-ci please test

Tests pass, and the change seems reasonable to me!


Replace usage of FromStr::from_str with str::parse across the project

It's best to use the inherent str::parse<T: FromStr> method across the project instead of FromStr::from_str since it doesn't require bringing FromStr into the scope.

Implemented From<&str>, replace parse to &str

@Stukalov-A-M str::parse<T> is more convenient that Into<T>::into in cases where type inference fails, thanks to the turbofish syntax. It is also more idiomatic in this case: FromStr carries the intent of extracting meaning from a string, while (Try)From is more suited for type conversions, where the string probably stays the same but the context around it is changed.

@Stukalov-A-M str::parse<T> is more convenient than Into<T>::into in cases where type inference fails, thanks to the turbofish syntax. It is also more idiomatic in this case: FromStr carries the intent of extracting meaning from a string, while (Try)From is more suited for type conversions, where the string probably stays the same but the context around it is changed.

Could u pls. send the ref where it's said about idiomaticity ?
I found only info that parse::() we're using were cast may bring to an error and Into:: where we sure that str will be casted into the the  without errors

Here are some discussions on it:

https://users.rust-lang.org/t/is-there-actually-a-semantic-difference-between-fromstr-and-tryfrom-str/92765/2
https://internals.rust-lang.org/t/pre-rfc-deprecate-fromstr-in-favor-of-tryfrom-str/12331/5

If the parsing is infallible, it's possible to specify the bottom Infallible type as the Err associated type in FromStr.

Here are some discussions on it:

https://users.rust-lang.org/t/is-there-actually-a-semantic-difference-between-fromstr-and-tryfrom-str/92765/2
https://internals.rust-lang.org/t/pre-rfc-deprecate-fromstr-in-favor-of-tryfrom-str/12331/5

If the parsing is infallible, it's possible to specify the empty Infallible type as the Err associated type in FromStr.

Thanks a lot! I'll research discussions.

implemented


Aug 6 update appears "tainted"

The most recent update shows up as tainted. I read this post on the Pi forums, so it seems to be unimportant - but wanted to mention it.
Aug  6 2014 17:55:53
Copyright (c) 2012 Broadcom
version 3da89bd3cdef7980b684f48fe60944aff4502f50 (tainted) (release)

This tainted flag appears again with the latest update:
~> /opt/vc/bin/vcgencmd version
Jun 13 2017 14:49:57
Copyright (c) 2012 Broadcom
version 22340f772ce101854acbc46045358dae832dd513 (tainted) (release)


feat(fastlane-setup): Add lane to add ad hoc iOS devices in one command.

Hi, thanks for submitting a Pull Request! :balloon:
Before submitting, please be sure to check a few things:
Commit names formatting
This repository is automatically published to npm with
semantic-release.


LedgerResult Deserialization: Large TransferRate in AccountSet

Some historical AccountSet transactions set TransferRate to something larger than 2,000,000,000. This is disallowed by rippled, but only after the fix1201 amendment was enabled. Therefore, the AccountSet transactions with a large TransferFee that occurred before that amendment are valid. We have a @Value.Check on AccountSet that ensures the TransferFee field is either 0 or between 1B and 2B. We should probably get rid of this check.
Ledgers where this is a problem:

2764BFE48C6D143F56A3194A794CAE4D16A9308AF8E28CAAD6ECDE8AF127A7E4
6A95998349E6F99CAD3550140D8C193A8FAAD817C607C6ED80B5D3CEF9C89AF9

Instead of getting rid of the @Value.Check, since that would hurt developer ergonomics when constructing an AccountSet, we could instead do the following:
Add a JsonNode to JsonRpcClientErrorException that is present when we are unable to deserialize a rippled result. When a developer encounters a JsonRpcClientErrorException, they can manually handle the JSON via JsonNode. Since a problem like this only occurs in historical data and can consistently be reproduced, developers should be able to trivially handle this case with the JsonNode, if they ever come across it at all.


Add a pull from upstream button

In order to pull from upstream at the moment i have to use the terminal, this is not a major problem but is there a way to add this feature to the package?

There was some discussion ( see #44 ) about github exclusive features. I am unsure about pulling from upstream but am willing to discuss it if someone wants to work on a PR for it.

In the menu-veiw.coffee file you have used the code:
{ id: 'pull', menu: 'Pull', icon: 'pull', type: 'upstream'}
to put the pull button into the menu. Why is the 'type' set as upstream? dhould it not be origin as that is the git remote it uses.

Also if I wanted to look at where the id is (see the code in my last comment), would I be right in going to the git.coffeefile and looking at the code from line 99 onwards?
Thanks :smiling_imp:


Feature/remove service stats

Remove service stats method.
delete_job = {
  applications: %w[1 2 3],
  metrics:%w[10 20 30] ,
  users: %w[100 200 300],
  from:Time.new(2002, 10, 31).to_i ,
  to: Time.new(2003, 10, 31).to_i
}
Service.delete_stats(service_id, delete_job)

All fields from delete_job are mandatory. Empty arrays are valid.

Tests failing because endpoint needs to be available in apisonator. We need to merge first feature in apisonator.

bors r+


Can I rewrite tests to use xUnit?

As I am aware the repo is not really active, so I thought I would rewrite the code to use xUnit tests.

Imo it's not worth the trouble, somebody would have to review it and that's a lotta code specially in an inactive repo
Also it seems there are plenty of tests already. It's not about the testing tool, it's about the quality of the tests


Fix welcome message

Fix text when the user wants to create an account. These notes refer to the page that shows after selecting "try now"

the welcome message says welcome to XYZ. Change it to Welcome to TogetherCrew
The text for the 2nd step sounds clunky. Remove be so that the text says Select time period and channels you want to analyse.

@katerinabc Please reach out to our UI/UX first.

point 1 & 2 has been resolved with the latest update. I'm closing the issue.


merchants: delist Binance [Discussion]

Merge.
relisting plan:
Binance can contact our ceo again to a request an official response to be relisted (when they stop trying to give "us" (who?? Lolz) ultimatums.)
seriously: if they want to be listed, they can open a git issue like everyone else, and they can atop threatening us. L o l

Merge it!!
Binance is blacklisted as an exchange that infringes on the privacy, sovereignty and freedom of users.

While we are at it, could we list samourais atomic swaps implementation? It's way more userfriendly than unstoppableswap which is listed.

While we are at it, could we list samourais atomic swaps implementation? It's way more userfriendly than unstoppableswap which is listed.

Samourai's impl has had 5 releases in under a week. IMO too early to list it.
maybe need subcategories
exchanges:

cex (kucoin etc)
p2p (localmonero, hodl hodl)
dex (bisq, haveno)
atomic DEX (basicswap)

swap services:

Swap Aggregators (trocador, intercambio)
Custodial Swaps (fixedfloat, changenow)
Atomic Swaps (unstoppableswaps, samourai)


Fuzzy authorship matching

Normalize authorship of names for rather aggressive fuzzy matching:

remove ex authors
remove initials
remove punctuation
ascii fold accents
use basionym authorship only if existing, ignoring the comb authors if also present (botany)
ignore year
expand author abbreviations with lookup dictionaries

https://github.com/Sp2000/colplus-backend/commit/769c0af5fd23ad97a01596e667df4cb6e4761047


Added Vanilla server.js file

Added server.js boiler plate to server.js file

oh looking good

Great!


Do not allow the user to change the name of the selected event

It is not needed anymore
See https://github.com/B3rn475/IFMLEdit.org/pull/19


Optimized scrollbar code to by combining 'width' and ''height'

Variables 'bg-color-1' and 'fg-color-1' have been used to store the values of the commonly used colors.
Code has been minified to remove whitespace and comments

Honestly just trying to help in any way to be more effective at code optimization. Thanks!

Can i have someone reveiw my code and approve or deny it please? Appreciate it!


Surya/core 5692/list invitations

a decent amount of code but mostly just bookkeeping
there's a few issues I'm running into but I believe they are due to DIARKs.

Looks good at first glance, but could you add some tests?  There are some existing tests in teams/member_test.go like MemberAddSocial, MemberAddNoPUK, MemberAddNoKeys, MemberAddEmail that generate invite links.  You could test what you've added here as well.

@patrickxb I reworked this to print implicit admins more in like with ccsandbox, and tested invitations in member_test.go.

The commits 6b24ba19756b...2c17ff8545d4 introduce visual changes on linux. :mag_right: 1 changed

Changed: Markdown-emoji (before) (after)


mariadb-connector-c: 3.1.2 -> 3.1.4

Motivation for this change
Update connector-c to v3.1.4
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @

@GrahamcOfBorg build mariadb-connector-c

@GrahamcOfBorg build mariadb-connector-c


Nothing happens on cPanel v80+

I followed the website instructions, and no cert was generated or installed.
No error messages. Just ok messages, but nothing happenned.
Have you tried the script on cPanel 80?

Have you tried the script on cPanel 80?

Yes, I installed a blank DNSONLY v80 right now and it issues and installs a certificate as expected.
See the troubleshooting command under "Usage" on the website.

Closing as invalid for now, please post the output of the debugging command if you wish to revisit this.


ionic getting-started   out of date  and Ionic CLI

After I installed ionic,I started a project by
ionic start myApp2 sidemenu

The app was inited by https://github.com/driftyco/ionic-app-base/archive/master.zip
I can't find the sidemenu project.
And When I cd myApp2, I found
ionic-app-base-master ionic.project

I ran into this same issue, running Yosemite 10.10.2.   I had been messing around with the yeoman ionic generator, and when I tried the regular ionic start myapp, it built an app to ionic-base-app-master inside my named folder.
Ran a global npm update, and it began to work as documented. Weird bug, glad someone else had seen it.


[Doc][5.1.0] Missing step to when setting up samples

The document [1] needs an additional step to move back to the is-samples folder before running the checkout(Step 3) command.
[1] https://docs.wso2.com/display/IS510/Downloading+a+Sample

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Certificate Compression (RFC8879)

Replacement of #9155 (github doesn't allow change of source repositories)
Add support for brotli compression
Add support for Zstandardi compression
Add support for RFC8879
Add support for callback API, which allows the user to handle either compression expansion or pre-compressed server certificates.

Checklist

[X] documentation is added or updated
[X] tests are added or updated

This PR is in a state where it requires action by @openssl/otc but the last update was 30 days ago

Not sure why address_ub_santitizer is failing. I tried running it locally (same options, etc), and it succeeds. The error seems to be in a file this PR does not touch?

Thank you @mattcaswell! I will be updating this shortly.

Ping @mattcaswell ?

Ping @mattcaswell ?

Sorry - been away on vacation for the last 2 weeks. Will try and pick this up when I am caught up.

I removed BUF_MEM from the APIs.

Should we run some tests with this code and asan?

Done.

ping @mattcaswell ?

I added most of the fixes as fixups/additional commits; hopefully to make review easier.

OTC want to discuss the design of this feature so there maybe some more comments that come out of that. I'd like to discuss it at next week's meeting if possible (although we weren't quorate this week due to vacations). I can ask OTC if you can attend too if you would like to do that...although the meeting time is likely to be dreadful for your timezone (OTC meet every Tuesday 0800UTC - 1000UTC).

Yes, that would be 4am to 6am my time. I could possibly attend, given enough warning.
While I like the flexibility in this implementation (simple compress API, get/set compress API, compress callback, auto-compression), I can certainly understand the desire to simplify it, but I would hate for it to be dumbed down.
In terms of use cases, I see the following (these are the extreme cases):

Simple website: Set the certificate in the SSL_CTX, call SSL_CTX_compress_certificate() API with the preferred algorithm, done.
Less simple website: multiple SSL_CTX's are set up as above or via SSL_get_cert_to_compress() and SSL_set_comp_cert(), and assigned during the early/servername callback.
Complex: CDN fronting many domains: Set the certificate via SSL_use_certificate() in the SSL during the early/servername callback from external database. Use the compression callback to determine if compression is desired, and look up a compressed certificate based on algorithm. Set compressed cert if available, or compress and cache in external database. If it expands, note in external database and return no compression from callback.

I suppose the callback might not be necessary in the CDN case where the certificate and any compressed forms are set in the same callback (early or SNI). This might require compressing the certificate multiple times (outside OpenSSL) and that a compressed version ends up unused, but it's a one-time compression, assuming that the result is cached externally.
I had suggested an OSSL_COMP_CERT object that could be referenced (rather than copied), this might make ownership clearer, but I didn't want to go down that path, yet.
The elephant in the room with respect to compression is the client cert; it cannot be pre-compressed due to the context data received from the server, so it has to be done at run-time, dynamically. And if the client has to do it that way, why can't the server?

OTC:
Receiving of compressed certificates should be "on" by default
Transmission of compressed certificates should be "off" by default, unless you have already cached some certificates using SSL_CTX_compress_cert() or you have set the callback.
We should only negotiate compression algorithms for transmission for which we have a cached certificate (unless you are using the callback).

OTC: Receiving of compressed certificates should be "on" by default Transmission of compressed certificates should be "off" by default, unless you have already cached some certificates using SSL_CTX_compress_cert() or you have set the callback. We should only negotiate compression algorithms for transmission for which we have a cached certificate (unless you are using the callback).

I was actually thinking of getting rid of the callback; it's not strictly necessary, and complicates the API. I think (server-side) pre-compression can do everything necessary. Unless the @openssl/otc really wants the callback, the following is how I propose to update this PR (basically in agreement, except the callback, but with additional details).
Client Side
Pre-compression is not an option. User assigns certificates, and specifies compression algorithm preferences/options (via SSL_{CTX_}set1_cert_comp_preferences() if desired). Compression is done dynamically per the configuration, due to the context received from the server.
Server Side
There are three basic use cases:

Easy-to-use compression done during initialization
External store of compressed certs set in SSL (e.g. CDNs/virtual hosting)
External store of compressed certs set in SSL_CTX (e.g. load-balanced servers)

Easy-to-use option
For (1), the APIs are simple, and apply to both SSL_CTX and SSL, although they are less useful for SSL:

Assign certificates, chains, etc, as normal
Set compression algorithm preferences (optional) via SSL_{CTX_}set1_cert_comp_preferences()
Compress certificates via SSL_{CTX_}compress_certs(), this API takes an algorithm to specify the compression algorithm to use to compress, with algorithm = 0 meaning to use all algorithms configured in step 2. Trying to compress with an algorithm not specified in step 2, or not enabled in the library, will generate an error.

No (server-side) state-machine compression will be performed; if a certificate hasn't already been compressed, then it won't be. Certificate expansion will be handled properly, meaning the expanded certificate won't be used. The SSL_{CTX_}compress_certs() API would compress all certificates assigned to an SSL or SSL_CTX (note the plural). While the APIs for (2) and (3) apply only to the most recently added certificate.
Provide compressed data to SSL
For (2), the APIs are a bit more complex, and both apply to SSL_CTX and SSL, although they are less useful for SSL_CTX:

Set compression algorithm preferences (optional) via SSL_set1_cert_comp_preferences()
Assign certificates, chains, etc, as normal
Assign one-or-more compressed certificate to the "current certificate" (i.e. the last one set) via SSL_set1_compressed_cert(). This certificate data is retrieved from an external store, not unlike the certificate itself.
Go back to (2) to assign a different type of certificate (e.g. ECDSA vs RSA)

This is most useful during the early or servername callbacks; based on the servername indication, a certificate can be loaded into an SSL via SSL_set1_compressed_cert().
This will require, for instance, setting the ECDSA cert/key/comp-cert(s). Then setting the RSA cert/key/comp-cert(s). It's not one-step because there may be multiple compressed versions of the installed certificate
Provide compressed data to SSL_CTX
For (3), it's similar to (2), but is done at initialization time of an SSL_CTX like (1). In this case, the certificate and compressed form are distributed to each server as they are set up. Compression is done in one place (e.g. a certificate server) rather than locally. This would be done via SSL_CTX_set1_compressed_cert().
Helper routines
While users could certainly read the RFC to figure out how to format the data to be compressed, the SSL_{CTX_}get_cert_to_compress() helper API can be used to get the properly formatted data. It may be more useful to simply provide the compressed data instead, and avoid having the user try to compress it themselves (e.g. SSL_{CTX_}get_compressed_cert()).
Enabling
The certificate compression feature defaults to "on".
A client merely needs to have the compression algorithm in its library to either transmit a compressed certificate or receive one.
In addition to having the compression algorithm in its library, a server needs to explicitly pre-compress (via the APIs above) a certificate in order to transmit it. A server will accept compressed certificates.
The feature can explicitly be disabled via the SSL_OP_NO_TX_CERTIFICATE_COMPRESSION (which disables transmitting compressed certificates) and the SSL_OP_NO_RX_CERTIFICATE_COMPRESSION (which disables transmitting the extension, and thus indicating no support for receiving compressed certificates) options.

Unless the @openssl/otc really wants the callback

The impression I got from other OTC members was that a simpler API is better. It's always possible to add additional API functions later - but taking them away is hard. My guess is that removing the callback altogether would be acceptable.

In addition to having the compression algorithm in its library, a server needs to explicitly pre-compress (via the APIs above) a certificate in order to transmit it. A server will accept compressed certificates.

If I understand correctly the feature is "on" but won't be used by a server if there are no pre-compressed certificates available to send. Just a normal (uncompressed) certificate will be sent back to the client.
For client certs you can't precompress anyway, so this is always on if the library has support for the compression algorithms and SSL_OP_NO_TX_CERTIFICATE_COMPRESSION is not being used.
If my understanding above is correct then I think the way you have described things is more-or-less in line with the sentiment in the OTC meeting, so I think this would be acceptable.

If my understanding above is correct then I think the way you have described things is more-or-less in line with the sentiment in the OTC meeting, so I think this would be acceptable.

Exactly!

So long as this simpler solution can work with the server using our existing callback options to select a certificate dynamically, with the server not necessarily knowing the set of certificates or SNI names it might receive in advance, I think that solution is fine.

So long as this simpler solution can work with the server using our existing callback options to select a certificate dynamically, with the server not necessarily knowing the set of certificates or SNI names it might receive in advance, I think that solution is fine.

Yes, that should continue to work (and one of my goals).

Looks like a rebase is required.

Looks like a rebase is required.

(Un)fortunately, I've become a rebase master...

@mattcaswell this should have all updates now for the "simplified" API.

Regarding crypto/objects/objects.pl which gitbub won't let me comment on directly.

Not sure if this is really necessary.

One of the problems with the FIPS module is that it includes many definition files that aren't used just by FIPS. For example, NIDs which are used for things other than encryption (e.g. Compression). So although this does not contain any code in the FIPS module, it would be considered a FIPS change. That seems counter-intuitive.
This avoids that, but it's not really scaleable. If there were some way to isolate the non-FIPS definitions, etc., from FIPS, it would go a long way to avoiding the dreaded (fips changed) label.
I can certainly remove it, but it will suddenly get that label.

All comments should be addressed, now

Needs another rebase too.

I suspect the failures are due to obsolete or old installs of zstd/brotli on Windows. I think review can continue while that gets resolved.

I suspect the failures are due to obsolete or old installs of zstd/brotli on Windows. I think review can continue while that gets resolved.

Looks to have been due to an update to vcpkg configuration on windows-latest.

Is this ready for re-review or is there still outstanding work to be done following from my previous round of comments?

Is this ready for re-review or is there still outstanding work to be done following from my previous round of comments?

@mattcaswell, Yes.

This comment is still outstanding. Docs need updating to say they return an "empty" method on failure - or something like that

I replied to this comment directly in the diff, it's not showing up in the comment thread‽‽

ping @mattcaswell

I know you're never going to believe me after 16 days of inactivity - but I was actually partway through reviewing this when your ping came through!! Honest!

Ping @openssl/committers for second review

ping @mattcaswell

I know you're never going to believe me after 16 days of inactivity - but I was actually partway through reviewing this when your ping came through!! Honest!

I didn't want to ping you just before the releases... and then there's the unrelease... sigh.

Note: Updates take a while because I run a series of tests locally similar to the CI, to save myself (and the reviewers) the headache of continuous fixup commits.

Updated with @hlandau comments. I'd like to put any GREASE tests into a separate PR, though.

Nice! Congratulations @tmshort - thanks for all your hard work on this!

The Configure conflict looks trivial (it's just the $usage line) and the libcrypto.num conflict is trivial as well.  Assuming no more conflicts over the next 24 hours, I won't rebase this unless absolutely necessary.

@tmshort Likewise, thanks for getting this through the gauntlet!
(I note @tmshort added a reaction to my approval in under 30 seconds... 😮)

I could also say you approved it 30 seconds after I added a reaction to @mattcaswell's re-approval. :)

Nice! Congratulations @tmshort - thanks for all your hard work on this!

Thank you all.
Now on to Raw Public Keys!

👍 I'm happy to resolve the conflicts when merging.

I just did it locally, but I'm also a committer.

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Just comments... starting merge.

Coverity has picked up a few things/..
New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)
** CID 1516095:    (DEADCODE)
/test/cert_comp_test.c: 163 in test_ssl_cert_comp()
/test/cert_comp_test.c: 206 in test_ssl_cert_comp()

*** CID 1516095:    (DEADCODE)
/test/cert_comp_test.c: 163 in test_ssl_cert_comp()
157         if (!TEST_true(create_ssl_ctx_pair(NULL, TLS_server_method(),
158                                            TLS_client_method(),
159                                            TLS1_3_VERSION, 0,
160                                            &sctx, &cctx, cert, privkey)))
161             goto end;
162         if (test == 3) {

CID 1516095:    (DEADCODE)
Execution cannot reach this statement: "server_pref[0] = expected_s...".

163             server_pref[0] = expected_server;
164             server_pref[1] = expected_client;
165             if (!TEST_true(SSL_CTX_set1_cert_comp_preference(sctx, server_pref, 2)))
166                 goto end;
167             client_pref[0] = expected_client;
168             if (!TEST_true(SSL_CTX_set1_cert_comp_preference(cctx, client_pref, 1)))
/test/cert_comp_test.c: 206 in test_ssl_cert_comp()
200                 goto end;
201         }
202
203         if (!TEST_true(create_ssl_connection(serverssl, clientssl, SSL_ERROR_NONE)))
204             goto end;
205         if (test == 3) {

CID 1516095:    (DEADCODE)
Execution cannot reach the expression "sc" inside this statement: "sc = ((serverssl == NULL) ?...".

206             SSL_CONNECTION sc = SSL_CONNECTION_FROM_SSL(serverssl);
207
208             / expect that the pre-compressed cert won't be used */
209             if (!TEST_int_eq(sc->cert->key->cert_comp_used, 0))
210                 goto end;
211
** CID 1516094:  Memory - illegal accesses  (UNINIT)

*** CID 1516094:  Memory - illegal accesses  (UNINIT)
/ssl/statem/statem_clnt.c: 3735 in tls_construct_client_compressed_certificate()
3729         ret = 1;
3730         goto out;
3731
3732      err:
3733         SSLfatal(sc, SSL_AD_INTERNAL_ERROR, ERR_R_INTERNAL_ERROR);
3734      out:

CID 1516094:  Memory - illegal accesses  (UNINIT)
Using uninitialized value "tmppkt.subs" when calling "WPACKET_cleanup".

3735         WPACKET_cleanup(&tmppkt);
3736         BUF_MEM_free(buf);
3737         COMP_CTX_free(comp);
3738         return ret;
3739     }
3740     #endif
** CID 1516093:    (TAINTED_SCALAR)
/ssl/t1_trce.c: 1337 in ssl_print_compressed_certificates()
/ssl/t1_trce.c: 1345 in ssl_print_compressed_certificates()

*** CID 1516093:    (TAINTED_SCALAR)
/ssl/t1_trce.c: 1337 in ssl_print_compressed_certificates()
1331         msg += 8;
1332         BIO_indent(bio, indent, 80);
1333         BIO_printf(bio, "Compression type=%s (0x%04x)\n", ssl_trace_str(alg, ssl_comp_cert_tbl), alg);
1334         BIO_indent(bio, indent, 80);
1335         BIO_printf(bio, "Uncompressed length=%d\n", (int)uclen);
1336         BIO_indent(bio, indent, 80);

CID 1516093:    (TAINTED_SCALAR)
Using tainted expression "clen" as the divisor in "(float)uclen / (float)clen".

1337         BIO_printf(bio, "Compressed length=%d, Ratio=%f:1\n", (int)clen, (float)uclen / (float)clen);
1338
1339         BIO_dump_indent(bio, (const char *)msg, clen, indent);
1340
1341     #ifndef OPENSSL_NO_COMP_ALG
1342         if (!ossl_comp_has_alg(alg))
/ssl/t1_trce.c: 1345 in ssl_print_compressed_certificates()
1339         BIO_dump_indent(bio, (const char *)msg, clen, indent);
1340
1341     #ifndef OPENSSL_NO_COMP_ALG
1342         if (!ossl_comp_has_alg(alg))
1343             return 0;
1344

CID 1516093:    (TAINTED_SCALAR)
Passing tainted expression "uclen" to "CRYPTO_malloc", which uses it as an allocation size. [Note: The source code implementation of the function has been overridden by a builtin model.]

1345         if ((ucdata = OPENSSL_malloc(uclen)) == NULL)
1346             return 0;
1347
1348         switch (alg) {
1349         case TLSEXT_comp_cert_zlib:
1350             method = COMP_zlib();

Thanks @slontis, I'll take a look at these.

** CID 1516095: (DEADCODE)
/test/cert_comp_test.c: 163 in test_ssl_cert_comp()
/test/cert_comp_test.c: 206 in test_ssl_cert_comp()

These will look like dead code if less than two compression algorithms are configured. If there are two compression algorithms configured, then this won't be dead code. This is due to a check on line 152 which skips the tests when trying this configuration, the expected values are initialized and set based on the configuration compression algorithms.

See #19440


There is no sample dashboard json file available in this repo.

Hi folks,
I'm using suricata_exporter version 7.0.0 and also getting metrics but I don't know which important metric needs to be configured on the Grafana dashboard, Does anyone have a sample grafana dashboard for Suricata metrics?  Would anyone put the sample Grafana dashboard JSON file in this repo?

I also encountered this problem, is there any solution?

it would be nice to have a simple/explanatory dashboard

Hello,
I would also like a Grafana Dashboard for this exporter. That would be awesome.


Add files via upload

增加中科院半导体研究所
Adding Institute of Semiconductors, Chinese Academy of Sciences

@jonlimx I am sorry, this domain does not belong to a university, nor to a college. I have to close the request without merging. This organization is more like research organization.
Please ensure that you are familiar with this repository rules located at the bottom of this page before submitting a new request.
Please notice that free educational subscription for JetBrains tools is for students and teachers only, and is valid for using the tools for educational purpose only. If employees of this Institute need  licenses for JetBrains tools, they may be eligible for an academic discount for the tools. Please send the request by email to<EMAIL_ADDRESS>


ValueError: Expecting property name: line 60 column 7 (char 1324)

Expected Behavior
Should start Pokemon BOT
Actual Behavior
Traceback (most recent call last):
File "pokecli.py", line 452, in
main()
File "pokecli.py", line 53, in main
config = init_config()
File "pokecli.py", line 124, in init_config
load.update(json.load(data))
File "/usr/lib/python2.7/json/init.py", line 291, in load
**kw)
File "/usr/lib/python2.7/json/init.py", line 339, in loads
return _default_decoder.decode(s)
File "/usr/lib/python2.7/json/decoder.py", line 364, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/usr/lib/python2.7/json/decoder.py", line 380, in raw_decode
obj, end = self.scan_once(s, idx)
ValueError: Expecting property name: line 60 column 7 (char 1324)
Steps to Reproduce
Just pull the latest DEV branch, used the new config file example and changed my login info. When I run it, it fails.
pok1@pokebot1:~/PokemonGo-Bot$ git pull
remote: Counting objects: 81, done.
remote: Compressing objects: 100% (34/34), done.
remote: Total 81 (delta 48), reused 35 (delta 35), pack-reused 12
Unpacking objects: 100% (81/81), done.
From https://github.com/PokemonGoF/PokemonGo-Bot
a9fd95b..eee7ba4  dev        -> origin/dev
5df9610..b3c53ce  feature/event-log -> origin/feature/event-log
Updating a9fd95b..eee7ba4
Fast-forward
CONTRIBUTORS.md                             |  2 ++
configs/config.json.example                 |  5 ++++-
pokecli.py                                  |  1 -
pokemongo_bot/init.py                   | 41 +++++++++++++++++++++--------------------
pokemongo_bot/cell_workers/incubate_eggs.py |  2 +-
pokemongo_bot/cell_workers/move_to_fort.py  | 63 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
web                                         |  2 +-
7 files changed, 91 insertions(+), 25 deletions(-)

Replace MoveToFort section with this:
{
"type": "MoveToFort",
"config": {
"lure_attraction": true,
"lure_max_distance": 2000
}
},

it crashed after that pull.
According to the pull, there was some changes to configs/config.json.example | 5 ++++-
So I created a new config.json  from it and put my login info and changed back to my settings:
"max_steps": 10,
"walk": 4,
"location_cache": false,
"release": {
"any": {"release_below_cp":20000, "release_below_iv": 0, "logic": "or"},

ok let me try this

@justinbeatz
It works. They missed a bracket

@justinbeatz Give this man a raise! thx

Created a PR to fix the issue with #2282


Google map is not loading

[x] I have read the Get Started - Installation section
[x] I have read and done the Get Started - Setup Android section
[x] I have read and done the Get Started - Setup iOS section
[x] I have already searched for the same problem

Environment

Technology
Version

Flutter version
2.10.3

Plugin version
^5.3.2

Android version
12

iOS version
15.2

Xcode version
13.2.1

Stacktrace/Logcat
Web app is created with vue.js and I am getting a console message while map component loading in flutter app.

{message: InvalidValueError: setCenter: not a LatLng or LatLngLiteral with finite coordinates: in property lat: not a number, messageLevel: 3}

Android Manifest permission:
     <uses-permission android:name="android.permission.INTERNET"/>
<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION"/>
 <uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION"/>
<uses-permission android:name="android.hardware.location.gps"/>

also added                    androidOnGeolocationPermissionsShowPrompt:                       (InAppWebViewController controller, String origin) async {                     return GeolocationPermissionShowPromptResponse(                         origin: origin,                         allow: true,                         retain: true                     );                   }, into inAppWebView Widget.

Same problem here

Same problem here, Actually For me, Google map is loading but it cannot detect location

Do you also load the map on iOS? My app is crashing(

Same problem here, Actually For me, Google map is loading but it cannot detect location

Using OpenStreetView and I can't get my location...

I was getting behavior on Android only, The reason is that on Android to get location of user you need to do one more step after getting the permission from the user, And that is to ask the user to start the location service.
To use this functionality, I request to enable this service before user using the webview.
Note: Call this service If you have the location permission.
  Future<bool> checkLocationService() async {
    lc.Location location = lc.Location();

    bool _serviceEnabled;

    _serviceEnabled = await location.serviceEnabled();
    if (!_serviceEnabled) {
      _serviceEnabled = await location.requestService();
    }
    return _serviceEnabled;
  }

Actually I was expecting the webview to notify when ever there is such requests but looks like even the website is not aware of that, So I was unable to detect such request.


Cancel debug configuration choose dialog ends with an error pop up

VSCode Version: 1.16.1
OS Version: Win10 64Bit

Steps to Reproduce:

Open an empty folder, create a simple file abc.txt with content test.
Open abc.txt and F5
Debug configuration dialog will pop up
Press ESC to cancel

Reproduces without extensions: Yes

This is fixed in the latest vscode insiders.
Let me know if you can reproduce with latest insiders and I will reopen
https://code.visualstudio.com/insiders


Missing LICENSE

Hey, I've got a patch ready to add support for Bitwig 2.3, but without a license my company won't allow me to send it.
Can you quickly add one? It doesn't really matter what it is, so long as it's a real license (not WTFPL or something similar).

Hi @rhofour
Thank's for reaching out. I've been added the license.


Add m.me referral capabilities

Passing Parameters via M.me Links
In addition to giving bot developers a way to link to their bot, Messenger Platform now also supports the passing an arbitrary parameter via these links.
This can be used for many purposes. It could be used to track different links placed in different channels to see which is most effective. It could also be used to tie a Messenger user to a session or account in an external app. It could even be used to direct the user to specific content or features available within the bot.
e.g.
http://m.me/repostbot?ref=youtube
Provides a report in Facebook Analytics and Dashbot.io on all the users aquired via Youtube
Doco
https://developers.facebook.com/docs/messenger-platform/referral-params

@cama pls check branch issue-9


Number of locked TFTs doesn't appear if it's 0

Description
Number of locked tfts doesn't appear if it's 0.

Expected result
It should display 0 TFT.

Verified, Devnet c765569.


ZEPPELIN-598 ] Dynamic loading for Interpreter and API

What is this PR for?
Use of external libraries that are included in the Roadmap,
The interpreter needs related to dynamic loading capabilities.
What type of PR is it?
Feature
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-598
How should this be tested?

Run to mvn clean package -DskipTests
Run to mvn clean package -DskipTests -pl zeppelin-server --am
run zeppelin.
move to interpreter menu on web ui.

check empty interpreter

call restapi

POST http://localhost:8080/api/interpreter/load/md/md
{"artifact":"org.apache.zeppelin:zeppelin-markdown:0.6.2", "className":"org.apache.zeppelin.markdown.Markdown"}

check interpreter menu to create interpreter md on web ui.
add interpreter setting md
run paragraph md

%md
Hello markdown

call unload restapi

DELETE http://localhost:8080/api/interpreter/unload/md2/md2/org.apache.zeppelin.markdown.Markdown

check delete md on web ui
restart to paragraph for md
if result is error status then well working.

Screenshots (if appropriate)
Click to link for screenshot
Questions:

Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? we have had already.

LOG FILE Limit 4MB Over

@cloverhearts StaticInitialization from Interpreter.register is deprecated thus you cannot init new interpreter by Class.forName. You have to use new way to install new interpreter.


Explore Dark Theme

An epic to collect issues related to a PF dark theme.

Light theme dropdowns have a grey border on the top and sides. Dark theme dropdowns only have a bottom border. When two dark theme dropdowns are touching, there's no separation between them.


add index to table

Just added an index to the scheduled_notifications table, so the query is more optimized when you have lots of notications created.

Codecov Report

Merging #29 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #29   +/-   ##
=========================================
  Coverage     98.16%   98.16%
  Complexity       76       76
=========================================
  Files             9        9
  Lines           218      218
=========================================
  Hits            214      214
  Misses            4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1072ce...55db84b. Read the comment docs.

Good idea!
I'd prefer to add it to the existing migration however, could you update that?
Thanks

I'd prefer to add it to the existing migration however, could you update that?

Are you sure? I think the current migrations should not be touched, moreso in a package. Because you then break the migrations for all the people with the package already installed.
For example, I have installed it, and already did the current migration. If you modify it instead of creating a new one, I cannot  have this index created by the package.

Are you sure? I think the current migrations should not be touched, moreso in a package. Because you then break the migrations for all the people with the package already installed.
For example, I have installed it, and already did the current migration. If you modify it instead of creating a new one, I cannot have this index created by the package.

Fair point. I just don't like having lots of package migrations clogging up the folder, but since we don't actually publish the migrations it's probably ok.
My thinking was that this isn't actually required for the package.
thoughts @thomasjohnkane ?

Unless i'm missing something, I don't think this would actually speed up the queries. Since we never query only the send_at column, we need to do a table scan anyway?

I was digging issues looking for this. Had to create a manual migration to add the index to send_at. @atymic can you explain your reasoning? The snooze:send command will query the send_at and, for big databases, this index will matter.


Create a GitHub action

Any other descriptions?
The action should do what? Since there's already 3 actions that cover CI, CD, and code valitation, there's no way to identify the action needed.

Pining @brokad - but I believe the point of this GH action is initially to deploy a shuttle project to shuttle. So basically install cargo-shuttle and run cargo shuttle deploy.

I created a simple action for deploying a site on shuttle
https://github.com/kaleidawave/axum-shuttle-demo/blob/main/.github/workflows/publish.yml
If you remove the Check source step it is pretty much ready to go. I also added | awk '!/Database URI.*?$/' to the end of the deploy command to remove the database uri because it contains the database password and I think GH actions logs are public.
https://docs.github.com/en/actions/creating-actions/creating-a-composite-action is a good guide about how to package one up and https://github.com/marketplace/actions/deploy-to-cloudflare-workers-with-wrangler is a good example for a "cloud deployment GH action"

Repo is ready -> https://github.com/shuttle-hq/shuttle-deploy-action


DownloadBuildArtifactsV0

Task name: DownloadBuildArtifactsV0
Description:

Upgraded @types/node and azure-pipelines-task-lib
Added node16 execution handler

Documentation changes required: N
Added unit tests: N
Checklist:

[x] Task version was bumped - please check instruction how to do it
[x] Checked that applied changes work as expected

@narula0781, could you please check this PR?

/azp run

/azp run

Appears 0.216.0 was released within the last day, and jobs are now failing to actually download artifacts. Same jobs worked fine using 0.212.0 yesterday... Example of failing job: https://dev.azure.com/plus3it/watchmaker/_build/results?buildId=5482&view=logs&j=d4aecca3-a437-5e55-8920-532a8eb17862


Fix #67 matching schedules by removing debug output

I left some debugging in place that was messaging objects.  This doesn't
blow up in the console, but does once you get to real adapters like
slack.

:+1:

Released with v2.1.10


QG4 checks (Release 3.2)

QG checks
Please keep this issue open until QG 4 is concluded and will be managed by the Issue Creator!
We will inform you about finding and proposals in separated issues, this issue here is for the Overview of the Checks!
Please keep this issue open until QG 4 is concluded!
Product Name: Managed Service Orchestrator
Product Owner: Mehran Roshandel
Helm Chart Version: 1.4.2
App Version: 1.4.2
Check of Tractus-X Release Guidelines
This QG x Check is depending on the mandatory information from our current Release Guidelines.
TRG 1 Documentation

[x] TRG 1.01 appropriate README.md
[x] TRG 1.02 appropriate INSTALL.md
[x] TRG 1.03 appropriate CHANGELOG.md

TRG 2 Git

[x] TRG 2.01 default branch is named main

[x] TRG 2.03 repository structure

Checks within TRG 2.03

[x] TRG 2.03 /docs directory contains detailed product related documentation for the Tractus-X product
[x] TRG 2.03 /charts directory contains the Helm chart for the Tractus-X product IF available
[x] TRG 2.03 AUTHORS.md file (optional) (TRG 2.03)
[x] TRG 2.03 CODE_OF_CONDUCT.md file (TRG 2.03)
[x] TRG 2.03 CONTRIBUTING.md file (TRG 2.03)
[x] TRG 2.03 DEPENDENCIES file(s) with up to date content (Dash tool generated) (TRG 2.03)
[x] TRG 2.03 LICENSE file (TRG 2.03)
[x] TRG 2.03 NOTICE.md file (TRG 2.03)
[x] TRG 2.03 SECURITY.md file (TRG 2.03)

[x] TRG 2.04 Leading product repository

Checks within TRG 2.04

[x] TRG 2.04 repository name must be productname without prefix or suffix
[x] TRG 2.04 should contain the release
[x] TRG 2.04 references/urls to the product's other repositories
[x] TRG 2.04 might contain product helm chart(s)
[x] TRG 2.04 README.md: contains the urls for the underlying applications

[x] TRG 2.05 .tractusx metafile in a proper format

TRG 3 Kubernetes

[x] TRG 3.02 PersistentVolume and PersistentVolumeClaim is used when needed

TRG 4 Container

[x] TRG 4.01 semantic versioning and tagging

[x] TRG 4.02 top level README.md file, that contains information about the used base image

[ ] TRG 4.03 Image has USER command and Non Root Container

Checks within TRG 4.03

[ ] TRG 4.03 deployment.yaml has runAsUser and allowPrivilegeEscalation: false properly set

[ ] TRG 4.05 released image must be place DockerHub as mandatory container registry; remove GHCR references

[ ] TRG 4.06 Notice File for DockerHub has all necessary information

Checks within TRG 4.06

[ ] TRG 4.06 Link to the source of your base image (Container registry and GitHub if available)
[ ] TRG 4.06 Link to your product image on DockerHub
[ ] TRG 4.06 Link to your repository on GitHub
[ ] TRG 4.06 Direct link to the Dockerfile used to build your image
[ ] TRG 4.06 Link to LICENCE file in your repo as Project License (make clear, that this is the PROJECT licence, not an image license

TRG 5 Helm

[ ] TRG 5.01 Helm chart must be released

Checks within TRG 5.01

[ ] TRG 5.01 appropriate semantic versioning for version and appVersion has to be used in Chart.yaml
[ ] TRG 5.01 must not contain any environment specific values-xyz.yaml
[ ] TRG 5.01 values.yaml file must contain proper default values/placeholders
[ ] TRG 5.01 No hostname provided for ingress
[ ] TRG 5.01 Ingress is disabled
[ ] TRG 5.01 No references to any secret engine service (e.g.: Hashicorp Vault)
[ ] TRG 5.01 Dependencies should be prefixed with the nameOverride and/or fullnameOverride properties
[ ] TRG 5.01 Image tag is set to the Chart.yaml appVersion property
[ ] TRG 5.01 must be deployable to any environment without overwriting default values with a simple helm install command
[ ] TRG 5.01 dependencies have to be declared in Chart.yaml NOT requirements.yml

[ ] TRG 5.02 Helm chart location in /charts directory and correct structure

Checks within TRG 5.02

[ ] TRG 5.02 each file must contain the Apache 2.0 Licence
[ ] TRG 5.02 latest tag is not used in helm chart be default

charts/
    chartNameA/
      Chart.yaml
      ...
    chartNameB/
      Chart.yaml
      ...
AUTHORS.md
DEPENDENCIES.md
LICENCE
README.md

[ ] TRG 5.04 CPU and memory limits and requests are properly set

[ ] TRG 5.06 application must be configurable through the Helm chart

[ ] TRG 5.07 dependencies are present in the Chart.yaml they are properly configured

[ ] TRG 5.08 a product has a single deployable helm chart that contains all components

Checks within TRG 5.08

[ ] TRG 5.08 name of the Chart should be just the product-name without prefix or suffix
[ ] TRG 5.08 values file should contain all available variables (even from subcharts) with default values and comments about what they do
[ ] TRG 5.08 helm install command should successfully install the chart to any supported Kubernetes version cluster (without overwriting default values)
[ ] TRG 5.08 helm test runs without errors

[ ] TRG 5.09 Helm Test running properly

Checks within TRG 5.09

[ ] TRG 5.09 A GitHub action exist which builds or uses the helm chart which gets released
[ ] TRG 5.09 The GitHub action can be triggered manually through Github WebUI manually running a workflow
[ ] TRG 5.09 Helm test verifies that the application is up and running

[ ] TRG 5.10 Products need to support 3 versions at a time

Checks within TRG 5.10

[ ] TRG 5.10 latest (K8s version 1.25)
[ ] TRG 5.10 latest - 1 (K8s version 1.24)
[ ] TRG 5.10 latest - 2  (K8s version 1.23)

[ ] TRG 5.11 Upgradeability PRERELEASE

Checks within TRG 5.11

[ ] TRG 5.11 Based on the Helm test workflow, you must provide a GitHub action which takes the latest released helm chart, does an installation of it and then execute the upgrade to the current / new version.

TRG 6 Released Helm Chart

[ ] TRG 6.01 Released Helm Chart

TRG 7 Open Source Governance

[x] TRG 7.01 Legal Documentation

[x] TRG 7.02 License and copyright header

[x] TRG 7.03 IP checks for project content

[x] TRG 7.04 IP checks for 3rd party content

Checks within TRG 7.04

[x] TRG 7.04 DEPENDENCIES file is up-to-date and reflects the current use of the 3rd party content
[x] TRG 7.04 all libraries listed there should have the status "approved"
[x] TRG 7.04 no libraries with status "rejected"
[x] TRG 7.04 for libraries with status "restricted", the according IP issues must be present (issue number in the source column)

[ ] TRG 7.05 Legal information for distributions

[ ] TRG 7.06 Legal information for end user content

[ ] TRG 7.07 Legal notice for documentation

Hints
Information Sharing

Hi @adkumar1,
I guess managed-service-orchestrator does not have any UI right? Just asking, because I am not sure, if TRG 7.06 would be relevant for this app

@SebastianBezold - I have created the PR #74 for it. Please check and merge

Hi @adkumar1,
I guess managed-service-orchestrator does not have any UI right? Just asking, because I am not sure, if TRG 7.06 would be relevant for this app

@adkumar1, @MehranRoshandel  can you please give a short answer, so we can close this issue?

Yes, There is no UI for managed-service-orchestrator

Closing, since we are already working on release 23.12


fetch-http-handler: abortSignal, requestTimeout issues

If an abort signal is passed, it is first included in the request options:
https://github.com/awslabs/smithy-typescript/blob/2f70f105a1093c0c5d1caaa84ce292e5917f31ec/packages/fetch-http-handler/src/fetch-http-handler.ts#L99-L101
Then later, the abort signal will be added to the race promises:
https://github.com/awslabs/smithy-typescript/blob/2f70f105a1093c0c5d1caaa84ce292e5917f31ec/packages/fetch-http-handler/src/fetch-http-handler.ts#L144-L154
It seems like the latter block of code can be removed. Relying solely on fetch's internal abort signal signally mechanism seems preferable.

can track release in https://github.com/aws/aws-sdk-js-v3/issues/4872


Booleanslotfix

Proposed changes:

Added an extra feature for un-set booleans

Status (please check what you already did):

[x] made PR ready for code review
[x] added some tests for the functionality
[x] updated the documentation
[x] updated the changelog

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Tom Metcalfe seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

please sign the CLA :D - @akelad will review it

And you need to fix the tests (travis failes): https://travis-ci.com/RasaHQ/rasa_core/jobs/146136783#L1564


Not working here either

Basically installs then just sits with logo, changing any of the parameters does nothing, any ideas??
Also get this issue clicking on Lookup symbols at Yahoo Finance

Having the same problem after uninstall/reinstall

Fixed in v1.1.14
Thank you for your patience


Adding kafka layer

I tested this out with my zookeeper charm, and got an error.
Here is what I did:

Checked out and built zookeeper from my PR: https://github.com/juju-solutions/bigtop/pull/8

Added my quorum patch to the zookeeper charm's resources dir: https://github.com/juju-solutions/layer-apache-bigtop-base/pull/18/files

Did the same thing with kafka (pulled the branch, built it, applied the patch).

Deployed openjdk and both charms to my local LXD controller, and added a relation between kafka and zookeeper.

I got the following error in the kafka charm:
2016-06-07 14:32:48 INFO zookeeper-relation-changed Traceback (most recent call last):
2016-06-07 14:32:48 INFO zookeeper-relation-changed   File "/var/lib/juju/agents/unit-kafka-0/charm/hooks/zookeeper-relation-changed", line 19, in
2016-06-07 14:32:48 INFO zookeeper-relation-changed     main()
2016-06-07 14:32:48 INFO zookeeper-relation-changed   File "/usr/local/lib/python3.4/dist-packages/charms/reactive/init.py", line 73, in main
2016-06-07 14:32:48 INFO zookeeper-relation-changed     bus.dispatch()
2016-06-07 14:32:48 INFO zookeeper-relation-changed   File "/usr/local/lib/python3.4/dist-packages/charms/reactive/bus.py", line 421, in dispatch
2016-06-07 14:32:48 INFO zookeeper-relation-changed     _invoke(other_handlers)
2016-06-07 14:32:48 INFO zookeeper-relation-changed   File "/usr/local/lib/python3.4/dist-packages/charms/reactive/bus.py", line 404, in _invoke
2016-06-07 14:32:48 INFO zookeeper-relation-changed     handler.invoke()
2016-06-07 14:32:48 INFO zookeeper-relation-changed   File "/usr/local/lib/python3.4/dist-packages/charms/reactive/bus.py", line 280, in invoke
2016-06-07 14:32:48 INFO zookeeper-relation-changed     self._action(args)
2016-06-07 14:32:48 INFO zookeeper-relation-changed   File "/var/lib/juju/agents/unit-kafka-0/charm/reactive/kafka.py", line 26, in configure_kafka
2016-06-07 14:32:48 INFO zookeeper-relation-changed     kafka.configure_kafka(zks)
2016-06-07 14:32:48 INFO zookeeper-relation-changed   File "lib/charms/layer/bigtop_kafka.py", line 37, in configure_kafka
2016-06-07 14:32:48 INFO zookeeper-relation-changed     bigtop.trigger_puppet()
2016-06-07 14:32:48 INFO zookeeper-relation-changed   File "lib/charms/layer/apache_bigtop_base.py", line 235, in trigger_puppet
2016-06-07 14:32:48 INFO zookeeper-relation-changed     r'(# )?export JAVA_HOME.': 'export JAVA_HOME={}'.format(java_home),
2016-06-07 14:32:48 INFO zookeeper-relation-changed   File "/usr/local/lib/python3.4/dist-packages/jujubigdata/utils.py", line 195, in re_edit_in_place
2016-06-07 14:32:48 INFO zookeeper-relation-changed     with Path(filename).in_place(encoding=encoding) as (reader, writer):
2016-06-07 14:32:48 INFO zookeeper-relation-changed   File "/usr/lib/python3.4/contextlib.py", line 59, in enter
2016-06-07 14:32:48 INFO zookeeper-relation-changed     return next(self.gen)
2016-06-07 14:32:48 INFO zookeeper-relation-changed   File "/usr/local/lib/python3.4/dist-packages/path.py", line 1450, in in_place
2016-06-07 14:32:48 INFO zookeeper-relation-changed     os.rename(self, backup_fn)
2016-06-07 14:32:48 INFO zookeeper-relation-changed FileNotFoundError: [Errno 2] No such file or directory: Path('/etc/default/bigtop-utils') -> Path('/etc/defaul
t/bigtop-utils.bak')

I got the same error running bundletester on the charm, built, with patch, as per the above.

Thank you for the review Pete. Managed to reproduce the problem you are reporting. Fixed it with a rebase of this branch. Please, re-review.

I have a failing test when running a fresh build of the Kafka charm against a fresh model in my lxd environment on Ubuntu Xenial. Here's the text of the message:
ERROR: kafka::01-deploy.py
[/tmp/bundletester-vwtqIt/kafka/tests/01-deploy.py exit 1]
2016-06-10 09:14:14 Starting deployment of local.lxd-test:bilbo
2016-06-10 09:14:15 Deploying services...
2016-06-10 09:14:15  Deploying service jdk using cs:trusty/openjdk-4
2016-06-10 09:14:17  Deploying service kafka using /tmp/charmlh2ia0xl/trusty/kafka
2016-06-10 09:14:20  Deploying service zk using cs:trusty/apache-zookeeper-3
2016-06-10 09:15:28 Config specifies num units for subordinate: jdk
2016-06-10 09:19:06 Adding relations...
2016-06-10 09:19:06  Adding relation kafka:zookeeper <-> zk:zkclient
2016-06-10 09:19:06  Adding relation kafka:java <-> jdk:java
2016-06-10 09:20:16 Deployment complete in 362.47 seconds
/home/petevg/.local/lib/python3.5/site-packages/path.py:1717: DeprecationWarning: path is deprecated. Use Path instead.
warnings.warn(msg, DeprecationWarning)
F
FAIL: test_deploy (main.TestDeploy)
Traceback (most recent call last):
File "/tmp/bundletester-vwtqIt/kafka/tests/01-deploy.py", line 30, in test_deploy
assert 'Kafka' in output, "Kafka daemon is not started"
AssertionError: Kafka daemon is not started

Ran 1 test in 449.967s
FAILED (failures=1)
PASS: 2 ERROR: 1 Total: 3 (456.214629 sec)

Tests aside, I was able to do "juju add-relation kafka zookeeper" without errors. :-)

This bug in juju core blocks this charm. Kafka service will not start because its fqdn is not resolvable.
https://github.com/juju-solutions/bigtop/pull/5#issuecomment-224301125

Closing the PR and submitting upstream.


Having Issues Connecting to Redis UI headless service using Anthos Istio gateway

We have deployed Anthos GKE on-prem and trying to connect to Redis UI service and it is failing, we haven't injected envoy side car as when we do that Redis deployment itself fails due to Redis Operator not able to communicate with POD's, we realized that Redis is not integrated with Istio Service Mesh yet ( may be creating the problem) , so we tried only with Ingress gateway config and getting the error captured in the thread, Can someone guide us how to make this work with Istio Ingress Gateway
We have the config like exernal URL--> Ingress gateway TLS(Certificate applied through Secrets)--> Gateway yaml---> Virtualservice yaml--> service entry yaml
apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
  name: redis-enterprise
  namespace: redis
spec:
  selector:
    istio: ingressgateway
  servers:
  - hosts:
    - redis-gke-poc-ui.test.com
    port:
      name: https-redis
      number: 443
      protocol: HTTPS
    tls:
      credentialName: redis-certificate
      mode: SIMPLE

------------------

apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: redis-enterprise-ui
  namespace: redis
spec:
  gateways:
  - redis-enterprise-gateway
  hosts:
  - redis-gke-poc-ui.test.com
  http:
  - match:
    - uri:
        prefix: /
    route:
    - destination:
        host: redis-enterprise-0.redis-enterprise.redis.svc.cluster.local
        port:
          number: 9443
-----------------------------------------

apiVersion: networking.istio.io/v1alpha3
kind: ServiceEntry
metadata:
  name: redis-enterprise-ui
  namespace: redis
spec:
  hosts:
  - redis-enterprise-0.redis-enterprise.redis.svc.cluster.local
  location: MESH_INTERNAL
  ports:
  - name: https
    number: 9443
    protocol: TCP
  resolution: DNS (edited)

This is the Error we are getting when we try to access the UI through LB external IP
< HTTP/1.1 503 Service Unavailable
< content-length: 91
< content-type: text/plain
< date: Wed, 15 Jul 2020 04:56:48 GMT
< server: istio-envoy
<
upstream connect error or disconnect/reset before headers. reset reason: connection failure* Connection #0 to host redis-gke-poc-ui.test.com left intact

Can you look at the config dump and /clusters output and paste here? See https://github.com/istio/istio/wiki/Troubleshooting-Istio for more info.

Any more info?

I will close this as we do not have enough information. Please reopen with the config dump if you still see this issue, but I suspect #27096 fixes it


feat: Angular 13 support

This pull request updates the Angular dependencies to version 13.

please merge. also add support for angular 14.

please add support for angular 14

please add support for angular 14


png icons are low quality for high resolution screens

Affected tools:
search
coordinate conversion
northarrow
timeslider

Fixed in https://github.com/Esri/arcgis-runtime-toolkit-qt/pull/529


Update distlib vendor library

Description
Update distlib library from 0.2.4.dev0 to 0.2.9.post0. This
is necessary in order to be able to enforce Wheel distribution
based installations.
Relates # (PRs)
rez #602 , #628
Type of change

[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Remarks

This should be merged once #602 is fully merged. Both #602 and #628 require a newer version of distlib libary in order to work. This distlib version provides a different API as such merging this first before Wheel distribution installation is enforced will cause errors. For example the allow_fail in

for installed_file in distribution.list_installed_files(allow_fail=True)

is no longer avaiable.

@lambdaclan could you update the vendor README please? Apart from that, I don't have much to say. :+1:


EXAMPLES_NOTEPRINTF and SYSTEM_NOTE don't build

i guess they need some updates.

@XuNeo please take a look.


MSFT: 6967505 setInterval(alert(), 10000/237) throws Invalid calling object exception after domtimeline script is injected

In debugger when we used to put all globaobject properties in the ActivationObject and use that
as "this" pointer for global object. We should separate out the ActivationObject from GlobalObject and
use the GlobalObject as "this"

@agarwal-sandeep can you take a look?

Beside name change it looks good to me


Struct Union Fails to Compile

@dsyme there's still a simple case where struct unions fail to compile
    type [<Struct>] Failure = A | B

This is the repro repo that's setup to use the compiler tools to build
struct-union-failure.zip
Built using FSharp.Compiler.Tools (4.1.17)
Please provide a succinct description of the issue.
Repro steps

open repro sln
build sln

@cloudRoutine It took a while but see https://github.com/Microsoft/visualfsharp/issues/3274 for the fix


Request for multiplatform

Is it possible to package this for multiplatform?
for my own project i just copied your code into my commonMain
i use this with kotlin/js and react, but having it in common code leaves the option open to render stuff serverside too
seems like Chat.isUpperCase() does not exist on js so i solved it expect/actual, iirc this is the only problem i ran into
//common
expect val Char.isUpperCase: Boolean

// js
actual val Char.isUpperCase: Boolean
    get() = (this == this.toUpperCase() && this != this.toLowerCase())

// jvm
actual val Char.isUpperCase: Boolean
    get() = isUpperCase()

I've thought this would be a good thing to do.  I've not done any multi
platform yet. Will look at it.
On Sun, Jan 12, 2020 at 4:01 AM NikkyAI<EMAIL_ADDRESS>wrote:

Is it possible to package this for multiplatform?
for my own project i just copied your code into my commonMain
i use this with kotlin/js and react, but having it in common code leaves
the option open to render stuff serverside too
seems like Chat.isUpperCase() does not exist on js so i solved it
expect/actual, iirc this is the only problem i ran into
//common
expect val Char.isUpperCase: Boolean
// js
actual val Char.isUpperCase: Boolean
get() = (this == this.toUpperCase() && this != this.toLowerCase())
// jvm
actual val Char.isUpperCase: Boolean
get() = isUpperCase()
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nwillc/ksvg/issues/3?email_source=notifications&email_token=AA3VMXM7WEPCA6Q52JNPIHLQ5LL5VA5CNFSM4KFWQ7Q2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IFSCURA,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA3VMXJNNMPTSXVNUF3EYMLQ5LL5VANCNFSM4KFWQ7QQ
.

I assume the logging support will need fixing too.

i would suggest kotlin-logging, not that there is much to replace..
have a look at my port: https://github.com/NikkyAI/pentagame/tree/a0311c68ade0dc768a539c6e8da6a8901682aa92/shared/src/commonMain/kotlin/com/github/nwillc/ksvg
and the Character.isUpperCase code here https://github.com/NikkyAI/pentagame/blob/ca4215cdade3e9f8b3be5519365620952dd4c9bd/shared/src/jsMain/kotlin/isUpperCase.kt

I've undertaken making the project multi-platform.  Won't happen instantly,
and happy for any help, but I am working on it in my free time.
On Mon, Jan 13, 2020 at 1:30 AM NikkyAI<EMAIL_ADDRESS>wrote:

i would suggest kotlin-logging, not that there is much to replace..
have a look at my port:
https://github.com/NikkyAI/pentagame/tree/a0311c68ade0dc768a539c6e8da6a8901682aa92/shared/src/commonMain/kotlin/com/github/nwillc/ksvg
and the Character.isUpperCase code here
https://github.com/NikkyAI/pentagame/blob/ca4215cdade3e9f8b3be5519365620952dd4c9bd/shared/src/jsMain/kotlin/isUpperCase.kt
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/nwillc/ksvg/issues/3?email_source=notifications&email_token=AA3VMXID7NS5DGFOQEE5GDDQ5QDAPA5CNFSM4KFWQ7Q2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIXU67Y#issuecomment-573525887,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA3VMXKHANONDBAOMLRG72DQ5QDAPANCNFSM4KFWQ7QQ
.

I've accepted your PR.  It's not the logging I'm worried about. I don't have a JS test harness to try things with and am struggling getting JS unit testing going.

i can look into that
also have similar problems of not knowing how to run tests in the browser

seems like this is breaking things.. https://stackoverflow.com/questions/51475050/spaces-in-test-method-names-when-targeting-multiplatform
TL;DR: cannot have spaces in testnames in commonTest because it cannot compile to js

after fixing all the testnames with @JsName
these errors are left over
here jvm and js seem to sort x1, x2, y1, y2 differently
https://github.com/nwillc/ksvg/blob/72402ec00c1f4c33ec4f2d5f01335ef12000d207/src/commonTest/kotlin/com/github/nwillc/ksvg/elements/LINETest.kt#L48
IllegalArgumentException: Value (10) is not a valid length or percentage
https://github.com/nwillc/ksvg/blob/72402ec00c1f4c33ec4f2d5f01335ef12000d207/src/commonTest/kotlin/com/github/nwillc/ksvg/elements/RECTTest.kt#L43
IllegalArgumentException: Value (M 10,30 A 20,20 0,0,1 50,30 Z) is not a valid path
https://github.com/nwillc/ksvg/blob/72402ec00c1f4c33ec4f2d5f01335ef12000d207/src/commonTest/kotlin/com/github/nwillc/ksvg/elements/PATHTest.kt#L31
for the last few errors it seems like the regex might be acting up, i will open a PR again for the current progress

The issues in the tests I believe are resolved.  The sort order is now enforced and the other bits and pieces seem resolved.  The JVM build artifacts now work with existing clients so I've merged the branch to master.  I think the javascript is working but I still don't understand the packaging and how it would be used in an example. More to do there.

Please see #10 for instructions on how to use this in a multiplatform project