HDFS-17278. Fix order dependent flakiness in TestViewfsWithNfs3.java under hadoop-hdfs-nfs module

Description of PR
The order dependent flakiness was detected if the test class TestDFSClientCache.java runs before TestRpcProgramNfs3.java.
The error message looks like below:
[ERROR] Failures:
[ERROR]   TestRpcProgramNfs3.testAccess:279 Incorrect return code expected:<0> but was:<13>
[ERROR]   TestRpcProgramNfs3.testCommit:764 Incorrect return code: expected:<13> but was:<5>
[ERROR]   TestRpcProgramNfs3.testCreate:493 Incorrect return code: expected:<13> but was:<5>
[ERROR]   TestRpcProgramNfs3.testEncryptedReadWrite:359->createFileUsingNfs:393 Incorrect response:  expected:<null> but was:<org.apache.hadoop.nfs.nfs3.response.WRITE3Response@42752a9b>
[ERROR]   TestRpcProgramNfs3.testFsinfo:714 Incorrect return code: expected:<13> but was:<5>
[ERROR]   TestRpcProgramNfs3.testFsstat:696 Incorrect return code: expected:<0> but was:<13>
[ERROR]   TestRpcProgramNfs3.testGetattr:205 Incorrect return code expected:<0> but was:<13>
[ERROR]   TestRpcProgramNfs3.testLookup:249 Incorrect return code expected:<13> but was:<5>
[ERROR]   TestRpcProgramNfs3.testMkdir:517 Incorrect return code: expected:<13> but was:<5>
[ERROR]   TestRpcProgramNfs3.testPathconf:738 Incorrect return code: expected:<13> but was:<5>
[ERROR]   TestRpcProgramNfs3.testRead:341 Incorrect return code: expected:<0> but was:<13>
[ERROR]   TestRpcProgramNfs3.testReaddir:642 Incorrect return code: expected:<13> but was:<5>
[ERROR]   TestRpcProgramNfs3.testReaddirplus:666 Incorrect return code: expected:<13> but was:<5>
[ERROR]   TestRpcProgramNfs3.testReadlink:297 Incorrect return code: expected:<0> but was:<5>
[ERROR]   TestRpcProgramNfs3.testRemove:570 Incorrect return code: expected:<13> but was:<5>
[ERROR]   TestRpcProgramNfs3.testRename:618 Incorrect return code: expected:<13> but was:<5>
[ERROR]   TestRpcProgramNfs3.testRmdir:594 Incorrect return code: expected:<13> but was:<5>
[ERROR]   TestRpcProgramNfs3.testSetattr:225 Incorrect return code expected:<13> but was:<5>
[ERROR]   TestRpcProgramNfs3.testSymlink:546 Incorrect return code: expected:<13> but was:<5>
[ERROR]   TestRpcProgramNfs3.testWrite:468 Incorrect return code: expected:<13> but was:<5>
[INFO]
[ERROR] Tests run: 25, Failures: 20, Errors: 0, Skipped: 0
[INFO]
[ERROR] There are test failures.

The polluter that led to this flakiness was the test method
testGetUserGroupInformationSecure() in TestDFSClientCache.java. There was a line UserGroupInformation.setLoginUser(currentUserUgi);
which modifies some shared state and resource, something like pre-setup the config. To fix this issue, I added the cleanup methods in TestDFSClientCache.java to reset the UserGroupInformation to ensure the isolation among each test class.
@AfterClass
public static void cleanup() {
    UserGroupInformation.reset();
}

Including setting
authenticationMethod = null;
conf = null; // set configuration to null
setLoginUser(null); // reset login user to default null

..., and so on. The reset() methods can be referred to hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java.
After the fix, the error was no longer exist and the succeed message was:
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hdfs.nfs.nfs3.CustomTest
[INFO] Tests run: 25, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 18.457 s - in org.apache.hadoop.hdfs.nfs.nfs3.CustomTest
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 25, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------

Here is the CustomTest.java file that I used to run these two tests in order, the error can be reproduce by running this CustomTest.java.
package org.apache.hadoop.hdfs.nfs.nfs3;
import org.junit.runner.RunWith;import org.junit.runners.Suite;

@RunWith(Suite.class)
@Suite.SuiteClasses({
    TestDFSClientCache.class,
    TestRpcProgramNfs3.class
})
public class CustomTest {}

How was this patch tested?
It was run under the openjdk version "17.0.9"/Apache Maven 3.9.5 environment.
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[x] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 20s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
31m 45s

trunk passed

+1 :green_heart:
compile
0m 17s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 16s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 17s

trunk passed

+1 :green_heart:
mvnsite
0m 19s

trunk passed

+1 :green_heart:
javadoc
0m 20s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 19s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 33s

trunk passed

+1 :green_heart:
shadedclient
19m  1s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 11s

the patch passed

+1 :green_heart:
compile
0m 11s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 11s

the patch passed

+1 :green_heart:
compile
0m 12s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
0m 12s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
checkstyle
0m  8s

the patch passed

+1 :green_heart:
mvnsite
0m 12s

the patch passed

+1 :green_heart:
javadoc
0m 13s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 13s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 32s

the patch passed

+1 :green_heart:
shadedclient
19m  6s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 11s

hadoop-hdfs-nfs in the patch passed.

+1 :green_heart:
asflicense
0m 21s

The patch does not generate ASF License warnings.

79m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6329/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6329

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux a3f434c3f0b0 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6fd7ea59d2942de7fa519a128b5303a4babd905f

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6329/1/testReport/

Max. process+thread count
682 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-nfs U: hadoop-hdfs-project/hadoop-hdfs-nfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6329/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 21s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 27s

trunk passed

+1 :green_heart:
compile
0m 16s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 16s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 18s

trunk passed

+1 :green_heart:
mvnsite
0m 20s

trunk passed

+1 :green_heart:
javadoc
0m 22s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 19s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 34s

trunk passed

+1 :green_heart:
shadedclient
19m 24s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 11s

the patch passed

+1 :green_heart:
compile
0m 12s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 12s

the patch passed

+1 :green_heart:
compile
0m 10s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
0m 10s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m  9s

the patch passed

+1 :green_heart:
mvnsite
0m 12s

the patch passed

+1 :green_heart:
javadoc
0m 12s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 13s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 34s

the patch passed

+1 :green_heart:
shadedclient
19m  6s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m  9s

hadoop-hdfs-nfs in the patch passed.

+1 :green_heart:
asflicense
0m 23s

The patch does not generate ASF License warnings.

80m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6329/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6329

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 7570b4fcffe0 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / fe8553ef2922a26cb218b13c148ec282b510fb1a

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6329/2/testReport/

Max. process+thread count
634 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-nfs U: hadoop-hdfs-project/hadoop-hdfs-nfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6329/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Thanks for fixing this bug!

Thanks for the quick response too!

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 21s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 23s

trunk passed

+1 :green_heart:
compile
0m 15s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 13s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 17s

trunk passed

+1 :green_heart:
mvnsite
0m 21s

trunk passed

+1 :green_heart:
javadoc
0m 20s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 19s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 34s

trunk passed

+1 :green_heart:
shadedclient
19m 16s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 12s
/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-nfs.txt
hadoop-hdfs-nfs in the patch failed.

-1 :x:
compile
0m 12s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-nfs-jdkUbuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04.txt
hadoop-hdfs-nfs in the patch failed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04.

-1 :x:
javac
0m 12s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-nfs-jdkUbuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04.txt
hadoop-hdfs-nfs in the patch failed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04.

-1 :x:
compile
0m 10s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-nfs-jdkPrivateBuild-1.8.0_392-8u392-ga-1~20.04-b08.txt
hadoop-hdfs-nfs in the patch failed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08.

-1 :x:
javac
0m 10s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-nfs-jdkPrivateBuild-1.8.0_392-8u392-ga-1~20.04-b08.txt
hadoop-hdfs-nfs in the patch failed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 10s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-nfs.txt
hadoop-hdfs-project/hadoop-hdfs-nfs: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)

-1 :x:
mvnsite
0m 12s
/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-nfs.txt
hadoop-hdfs-nfs in the patch failed.

+1 :green_heart:
javadoc
0m 13s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 12s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

-1 :x:
spotbugs
0m 12s
/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-nfs.txt
hadoop-hdfs-nfs in the patch failed.

+1 :green_heart:
shadedclient
20m 25s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
0m 15s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-nfs.txt
hadoop-hdfs-nfs in the patch failed.

+1 :green_heart:
asflicense
0m 23s

The patch does not generate ASF License warnings.

78m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6329/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6329

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 392bcd742c04 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6bee636d07e8603d961bebd784c829293224d350

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6329/3/testReport/

Max. process+thread count
561 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-nfs U: hadoop-hdfs-project/hadoop-hdfs-nfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6329/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 34s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m 20s

trunk passed

+1 :green_heart:
compile
0m 24s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 23s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 23s

trunk passed

+1 :green_heart:
mvnsite
0m 29s

trunk passed

+1 :green_heart:
javadoc
0m 27s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 24s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 46s

trunk passed

+1 :green_heart:
shadedclient
32m 53s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 18s

the patch passed

+1 :green_heart:
compile
0m 18s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 18s

the patch passed

+1 :green_heart:
compile
0m 17s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
0m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 14s

the patch passed

+1 :green_heart:
mvnsite
0m 20s

the patch passed

+1 :green_heart:
javadoc
0m 18s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 18s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 46s

the patch passed

+1 :green_heart:
shadedclient
33m 39s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 42s

hadoop-hdfs-nfs in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

124m 59s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6329/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6329

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 03f5793bf142 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a45e3f0b88e0c8423ee3d2e7281e8410d5016ae5

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6329/5/testReport/

Max. process+thread count
555 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-nfs U: hadoop-hdfs-project/hadoop-hdfs-nfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6329/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 20s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
30m 56s

trunk passed

+1 :green_heart:
compile
0m 17s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 17s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 19s

trunk passed

+1 :green_heart:
mvnsite
0m 20s

trunk passed

+1 :green_heart:
javadoc
0m 21s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 18s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 33s

trunk passed

+1 :green_heart:
shadedclient
19m  9s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 12s

the patch passed

+1 :green_heart:
compile
0m 11s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 11s

the patch passed

+1 :green_heart:
compile
0m 12s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
0m 12s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m  9s

the patch passed

+1 :green_heart:
mvnsite
0m 13s

the patch passed

+1 :green_heart:
javadoc
0m 13s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 12s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 32s

the patch passed

+1 :green_heart:
shadedclient
19m  7s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 13s

hadoop-hdfs-nfs in the patch passed.

+1 :green_heart:
asflicense
0m 24s

The patch does not generate ASF License warnings.

79m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6329/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6329

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux<PHONE_NUMBER>be 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 9c6e4e2a8ae56c0cc8652356f4bf6189a3730e7d

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6329/6/testReport/

Max. process+thread count
554 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-nfs U: hadoop-hdfs-project/hadoop-hdfs-nfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6329/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Add AboutUs page

Add an AboutUs page so that anyone as a beginner can come and write his/her name on that page as a contributor and create his/her pull request and learn about it.

Can I make this?

Can I make this? As part of cwoc?

Yes. Why not.

Can I make this? As part of cwoc?

Bro, I am assigning you this task. You have 4 days to complete it.

can you give me a little bit of context on how it should look? Or I will do  it on my own way and will show it to you?

can you give me a little bit of context on how it should look? Or I will do it on my own way and will show it to you?

You can do it of your own, make it fancy filled with color, or just a simple about us page it is totally up to you.
You are given 4 days to do this work, is it ok for you?

@Sloth-Panda Bro, today is your last day to complete this work.


Workaround Atomic* crashes on Samsungs with Android 5.0.x

@see https://github.com/ReactiveX/RxJava/pull/3979/files
of course, this fix is inappropriate. Gonna pessimize perf only on those problematic devices.

Nope. This could be done in Application by hooking ClassLoader and providing own implementations for Atomic*FUs. Library has nothing to do with this.


Update device-quirks for GPD win 3

fixed GPD win 3  orientation issue

fixed GPD win 3 orientation issue

fixed GPD win 3 orientation issue

Please help review GPD win 3 issue

It was set to normal to prevent crashing because it would crash when rotated 90 or 270 degrees. Is this no longer an issue anymore?

Acutally, I have test on my GPD win 3 (i7-1195G7) . If I set normal mode , It shows vertical screen.
The  orientation  should be set 'right'  to fixed screen rotation issue.

Independent report of this working from a user on our discord as well

rebased and merged in #84


Design fixes for RU language pack

Type of Change

Tool Source: Styling

What issue does this relate to?
N/A
What should this PR do?
Fixes some minor issues that were observed once the new Russian translations were added.
What are the acceptance criteria?
With the Russian language pack selected:

Consistent font-weight across Cyrillic and ASCII chars in the tool header
Consistent font-weight across Cyrillic and ASCII chars in the labels of checkbox options
Contribution callout (visible on scroll) button text wraps, and does not overflow

With the English language pack selected:

Ensure these changes haven't obviously caused any issues

I can commit more slim translations after successful review to make RU UI looks better :)
In Russian a lot of letters hah
For example Присоединяйтесь к проекту на GitHub to Перейти на GitHub = Get involved on GitHub to ~Come to GitHub ¯_(ツ)_/¯

@powerdot Go for it -- I don't think changes to the strings will have any conflicts with anything being changed here, so you're welcome to open a PR whenever and I'll take a look :)


[Feature request] Merge fillable columns with parent

I was missing this feature and stumbled upon this issue: #77
After reading the issue and the comments I decided to create this feature request and introduce a potential way of implementing this.
This would be nice feature to have.
I've created a trait in my project based off of @litvinjuan's answer in the issue:
<?php

namespace App\Concerns;

trait ExtendParentFillables
{
    public function getFillable()
    {
        $parentFillable = (new \ReflectionClass($this))->getParentClass()->newInstance()->getFillable();

        return array_merge($this->fillable, $parentFillable);
    }
}

This could be included in the package and to prevent breaking changes this could be added in the form of a trait as well. Which would make it opt-in and opens the potential for a "guarded" form as well.
The trait is not only useful in parental's context as it can be used to extend any models' fillables.

This may explain an issue I'm running into (noted at https://github.com/laravel/framework/pull/48160#issuecomment-1716277763) in Laravel 10.21+.

Resolved by #120


Insert deleted key into hashmap will cause size() be increased

What steps will reproduce the problem?
1. Initiate a HashMap  (such as google::sparse_hash_map<int, int> hashmap;)
2. Set the deleted key  (hashmap.set_deleted_key(-1);)
3. Insert a delete key into it (hashmap.insert(std::make_pair(-1, -1 * 100));)
4. Check its size by call size() method, the size() is increased; but it is
unable to be get via iterator.

What is the expected output? What do you see instead?
If insert a deleted key, the size() should not be increased.

What version of the product are you using? On what operating system?
1.11 on Centos

Please provide any additional information below.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 7 May 2013 at 9:24

This is still the case.

This is only achievable by compiling with NDEBUG, otherwise an assertion error is given.
calling "erase.(map.deleted_key())" seems to do the trick. Maybe it should be somewhere in the code to do it on insert / operator[]


Figure out what ongoing UISP import looks like

How are we going to handle ongoing synchronization between UISP and meshDB?
What happens when a device name is changed in UISP to one value and another in meshDB?

The more I reflect on this, the more I think we should not be in the business of storing the following fields:

Device Model
Device Type
SSID
IP Address
Lat/lon

Any more than we are in the business of storing frequency, uptime, or other dynamic metrics. These fields can all change, and if we store them, we need to keep them up to date (and keep UISP up to date with our changes). Clients wishing to learn this info should just query UISP using the join key we provide.
Devices not included in UISP that need this information recorded should be added there, rather than created in our DB.
I think there is an argument for storing, and I am in favor of keeping:

Notes
Install Date
Abandon Date
Status

Since there is not as much of a need to keep them in sync with UISP and they have a more "low frequency" nature. For example if we haven't been able to ping an LBE in a few days in UISP, is it abandoned? Probably not in most cases, but yes in some. MeshDB would track that distinction as determined manually by a volunteer (or maybe by some kind of scheduled cleanup system), while UISP would be responsible for reporting the precise "up to the second" information.
I could be talked out of even these fields however...
We obviously need the following minimum fields for sure:

Node Number
UISP ID

The one sticking point, as called out above, is the device name. This can be changed in UISP and may fall out of sync
We also definitely need to store the sector supplemental info for map display where appropriate:

Radius
Azimuth
Width

Misclick ooops

Notes from my call with @WillNilges today:
Generally aligned on the above. For device name we're going to can-kick a bit. Let's implement all the other changes and leave device name duplicated for now

Perhaps we can leverage the new admin notification system we developed in #450 to report device name conflicts? Seems overkill but maybe if the notifications are infrequent it will be fine?

Remaining work: add a celery worker to sync with UISP (hourly?) using UISP IDs to join and de-duplicate


Update or remove package-info.md files

The package-info.md files are pretty outdated and not used in every package. Either update and add missing files or remove all of them.

This is currently worked on in #53


chore(types): add function types to element and locators

add 'gulp types' to output index.d.ts
some clean up for functions to use fat arrow
clang clean up

Main concern is the fat-arrowing of the module that shouldn't be ES6ey. Other stuff looks reasonable.

Looks good after Travis finishes (I re-ran it after a sauce connect flake) and one more comment on the gulpfile.


Uninstall deleted active swift version, not the specified.

Hi, I was running 0.2.0, but just today updated to 0.3.0 by running the install script without deleting the previous version of swiftly because 0.2.0 didn't have update working yet.
I went to delete a toolchain I wasn't going to use anymore, and instead it deleted the active toolchain and switched to the one I was deleting.
It was fine, I recovered easily in this case, but should nuke swiftly and all it's folders from orbit to make the move from 0.2.0 -> 0.3.0 or a problem with the actual uninstall command?
In window one:
user:~$ swiftly list
Installed release toolchains
----------------------------
Swift 5.10.0
Swift 5.9.2

Installed snapshot toolchains
-----------------------------
main-snapshot-2024-07-15 (in use)
5.10-snapshot-2024-02-14
main-snapshot-2024-02-14

In window 2, just for full disclosure
user:~$ swiftly install latest
...
Swift 5.10.1 installed successfully!

Back in window 1
user:~$ swiftly uninstall 5.10.0
The following toolchains will be uninstalled:
  Swift 5.10.0
Proceed? (Y/n): Y

Error: Found symlink that points to non-swiftly managed executable: /home/eloise/.local/share/swiftly/toolchains/main-snapshot-2024-07-15/usr/bin/repl_swift
user:~$ swiftly list
Installed release toolchains
----------------------------
Swift 5.10.1
Swift 5.10.0 (in use)
Swift 5.9.2

Installed snapshot toolchains
-----------------------------
5.10-snapshot-2024-02-14
main-snapshot-2024-02-14

I think the mistake (if its in the code and not the lack of fresh install) has to be in: https://github.com/swiftlang/swiftly/blob/bcfd8439a078893c11d3331c193e2b6a7b431887/Sources/Swiftly/Uninstall.swift
Because I don't see how this could have gone wrong? (I'm on Linux)
https://github.com/swiftlang/swiftly/blob/bcfd8439a078893c11d3331c193e2b6a7b431887/Sources/LinuxPlatform/Linux.swift#L108

rm'd the appropriate directories (found by find ~ -iname *swiftly* or you know the directions ) and reinstalled.
Issue disapears.

@carlynorama When you say you ran swiftly in 2 windows did you do that at the same time?
Because if that is the order you ran the different commands it doesn't seem to make sense.
ie the main snapshot was the in use version of swift but when you ran update it updated the 5.10 install

Yes, at the same time.  Let's see if i can clear it up bit.
Before the submitted logs

I ran curl -L https://swiftlang.github.io/swiftly/swiftly-install.sh | bash, then option 1 to "update" my 0.2.0 install to 0.3.0, did nothing to deinstall swiftly or the toolchain before hand.  I did the full "it's Friday night. YOLO. Let's just see."
Afterwards I ran swiftly install main-snapshot and switched to it using use, no problems.

The story begins

Window 1: I did a list, it does not list 5.10.1 (latest) because I hadn't installed that yet, but it does list main-snapshot-2024-07-15 (in use) and all the previous toolchains I had with v0.2.0.
Window 2: I started the swiftly install latest
Window 1: While that Window 2 install was running (I know, I know) I did the swiftly uninstall 5.10.0 because I wasn't going to need it.
After confirming yes (Y) I wanted 5.10.0 deleted in Window 1, I went away from that machine entirely for... a few minutes?
When I came back:

Window 2: indicated successful install of 5.10.1
Window 1: noticed error about folder permissions, ran list again to check that 5.10.0 had been deinstalled. Instead I saw:

confirmation the 5.10.1 had indeed been successful installed as expected from the Window 2 data
main-snapshot-2024-07-15 had been removed and the current swift toolchain had been swapped to the one I had been trying to remove (5.10.0)

reinstalled main-snapshot-2024-07-15, everything seemed fine, but didn't switch to it.

Super weird.  I submitted the issue and stopped for the night.
This Morning
This morning I noticed there was still some swiftly-not-allowed-to-access messages when trying to switch toolchains with use. I figured that this really must be my sloppy install hygine, and decided to clear everything swiftly out and start fresh. I did not do an ls -al on these directories to check their permissions. That would have been good data to have in hindsight.
It seems to all be working now. I installed latest, main-snapshot (which I needed to do twice? I'm not really sure what that was about, I was relying on list, I did not check the folder, which also would have been useful to have done in retrospect) a 5.9, then deleted the 5.9, which behaved as expected.
This is a wee little Ubuntu machine I can wipe with very low stress. Would it be helpful for me to delete swiftly again, uninstalling the toolchains correctly this time, reinstall 0.2.0, and try to recreate? I'm comfortable calling this user error, but if there's data wanted, I can try to collect it.

Note, using use stopped working, nor could I fully uninstall all. Was getting a "The file doesn't exist." for both failures.
Did
rm -r ~/.local/bin/swiftly
rm -r ~/.local/share/swiftly/

AND
find ~/.local/bin/ -maxdepth 1 -type l
find ~/.local/bin/ -maxdepth 1 -type l -delete

THEN reinstalled 0.3.0
NOW everything really works as expected.

I think the fact you were running swiftly in two windows at the same time is probably the issue. We haven't tested for this at all.

I agree with that assessment.  I wouldn't honestly actually really expect it from a 0.3.0, as I said I was dinking around too fast on a Friday on an inconsequential dev box.  Did want to note manual deleting the symlinks for the next time I get myself into a jam.
Thanks for even taking a look!


Firmware Extraction Attack

I recently came across this article that explains how it is possible to extract the seed phrase encrypted in Jade if the attacker manages to steal the device.
Is there already a way to deal with this problem? I looked through the commits here, but I didn't see any solution so far
They also provided a more technical explanation here

This doesn't extract the seed, just the allows the decryption of the credentials used with the blind pinserver. (So someone could do something that would wipe your pin there and need you to reinitialize the device from your recovery seed)

@3rdIteration isn't the encrypted Private Key also stored locally in the hardware wallet?
If one can decrypt the PIN, it makes sense that he would be able to decrypt the private key saved on the same device, doesn't it?

No, not with Jade. It needs a decryption key from the blind PINServer. (Which needs the PIN)
This is why it never mentioned that it could extract seeds or private keys.


rust-sgx-sdk community

Is there any community around baidu/rust-sgx-sdk? I think this project is fairly popular and I'd like to get in touch with other developers. Would you consider for example running gitter.im?

Good idea! I just created one and add the badge to Readme!

That's great, thanks!


Missing pip install of casim package in Installation directions?

I followed the steps to install casim using a conda env, but upon running the tests I got the following error:
Traceback (most recent call last):
File "casim_test.py", line 4, in
from casim import casim
ModuleNotFoundError: No module named 'casim'
I think the Installation instructions may be missing an explicit step. I tried running pip install . from the cancer_sim directory and casim installed in my environment and then the tests ran OK.

You might also want to create a console script entrypoint in setup.py and then uploade to pip and/or create a conda package. Installation instructions and access to the high level function would simplify drastically.

This issue is part of the JOSS review at https://github.com/openjournals/joss-reviews/issues/2436

fixed by PR #13.
On 7/15/20 12:34 AM, Blake A. Wilson wrote:

I followed the steps to install using casim using a conda env, but upon
running the tests if got the following error:
Traceback (most recent call last):
File "casim_test.py", line 4, in
from casim import casim
ModuleNotFoundError: No module named 'casim'
I think the Installation instructions may be missing an explicit step. I
tried running |pip install .| from the cancer_sim directory and casim
installed in my environment and then the tests ran OK.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mpievolbio-scicomp/cancer_sim/issues/5, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ADWCQR5JHTOMRVBR4KRNLT3R3TMPJANCNFSM4OZ6SNPQ.

Thanks!


Clean JsonCallParameter class

Signed-off-by: Karim TAAM<EMAIL_ADDRESS>

PR description
Remove and clean this part of code in the JsonCallParameter class
from != null ? Address.fromHexString(from) : null,
to != null ? Address.fromHexString(to) : null,
gasLimit != null ? Long.decode(gasLimit) : -1,
gasPrice != null ? Wei.fromHexString(gasPrice) : null,
gasPremium != null ? Wei.fromHexString(gasPremium) : null,
feeCap != null ? Wei.fromHexString(feeCap) : null,
value != null ? Wei.fromHexString(value) : null,
payload != null ? Bytes.fromHexString(payload) : null);

Test performed

Test with eth_call and eth_estimateGas
Update unit tests

Changelog

[x] I thought about the changelog and included a changelog update if required.

Still thinking it might be better to merge them but push back if you still think they'd be better separate!

I just tried to merges them. I think we can do as you said. If there is a need to add specific fields for the RPC we will change


Install problem

Installation problem. I do

git clone https://github.com/frictionlessdata/tableschema-js.git - ok
cd tableschema-js/ - ok
npm install jsontableschema - result bellow

npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
....
+<EMAIL_ADDRESS>added 6 packages from 7 contributors and audited 12445 packages in 11.258s

12 packages are looking for funding
  run `npm fund` for details

found 5 vulnerabilities (2 low, 3 high)
  run `npm audit fix` to fix them, or `npm audit` for details

lsb_release -a, Ubuntu 18.04.3 LTS (bionic)
npm -v , 6.13.1
node --version,  v13.2.0

Please preserve this line to notify @roll (lead of this repository)

@ppKrauss
It's npm install tableschema
Please re-open if needed


QLoRA Inference

Can I load QLoRA fine-tuning weights into a Hugging Face model as shown below?
model_id = "meta-llama/Meta-Llama-3-8B-Instruct"
quantization_config = BitsAndBytesConfig(
load_in_4bit=True,
bnb_4bit_compute_dtype=torch.bfloat16,
bnb_4bit_use_double_quant=True,
bnb_4bit_quant_type='nf4'
)

tokenizer = AutoTokenizer.from_pretrained(model_id)
model = AutoModelForCausalLM.from_pretrained(
    pretrained_model_name_or_path=model_id,
    #config=config,
    low_cpu_mem_usage=True,
    torch_dtype=torch.float16,
    device_map='auto'
)

model = PeftModel.from_pretrained(model, "qlora_finetune_folder/")

I have changed the Checkpointer to FullModelHFCheckpointer.
Essentially, it is loadable & runnable, but I am curious if it reflects the same structure as qlora_llama3_8b. Thanks.

Hi @jeff52415 thanks for opening this issue, this is a really good question. One possible source of discrepancy is the different implementations of NF4 quantization used by torchtune and Hugging Face. To be more explicit, torchtune relies on the NF4Tensor class from torchao in QLoRA instead of the bitsandbytes version from Hugging Face. I need to verify that quantizing a torchtune checkpoint with bitsandbytes yields the same result as quantizing with ao. Let me look into it and get back to you. Also cc @rohan-varma who may have some insights here


Building with Node.js 20

I wanted to get this working on Node.js 20.11.0. I think I'm most of the way there with 23f80d4490cc0bdb59b4d9e19540406cb614100a.
Not directly because of Node.js 20, but because osm-testdata no longer has a 1.0.0 release I've had to add a specific commit reference to it in package.json:
  "osm-testdata": "github:osmcode/osm-testdata#ecfdeb0d5ffcfcb60939651d517d5d7d1bb041a3",

That doesn't work so well with the npm install section of the Makefile, so I've had to amend it from:
./node_modules: ./node_modules/node-pre-gyp
	npm install `node -e "console.log(Object.keys(require('./package.json').dependencies).join(' '))"` \
	`node -e "console.log(Object.keys(require('./package.json').devDependencies).join(' '))"` --clang=1

to this:
./node_modules: ./node_modules/@mapbox/node-pre-gyp
	npm install

I'm a bit confused by what the --clang=1 part does. I can't find any npm install documentation referring to it. If I put it back in it tries to build everything and his dog in terms of node modules (zmq, mdns2, etc.). It seems to build fine without it, although I've not yet tested it.

This code is not maintained any more. I'll mark the repo as archieved.


x/sys/windows: API break in SecurityAttributes struct

What version of Go are you using (go version)?

$ go version
go version go1.11.13 darwin/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
N/A

What did you do?
In this revision of x/sys, there was a breaking API change:
https://github.com/golang/sys/commit/5c00192e8ce6429d705e1e4d83b4b22e79482964#diff-c4ffa695b270239c949ef5b31be6c4f5
This means that Docker doesn't compile any more:
https://github.com/moby/moby/blob/master/pkg/system/filesys_windows.go#L112
What did you expect to see?
Successful compilation.
What did you see instead?
cannot use uintptr(unsafe.Pointer(&sd[0])) (type uintptr) as type *"golang.org/x/sys/windows".SECURITY_DESCRIPTOR in assignment

cc @alexbrainman @zx2c4

Change is intentional. Going from an unsafe member put there as a stop-gap to a properly typed one now that we have support is sensible. x/sys/windows is unversioned in order to allow for these gradual improvements over time.
Fixed here for moby: https://github.com/moby/moby/pull/40017

The change is intentional but we don't want to break programs like Docker.  Can we keep the old struct and define a new one with a different name?

CC @tklauser @bradfitz

@ianlancetaylor Then we'd have to change every place that actually uses that struct. The cascading effects aren't pretty.
Meanwhile I've already opened a CL to fix this for Docker and things seem to be moving along nicely there.

I agree with @zx2c4

The change is intentional but we don't want to break programs like Docker.

I though we built modules just for such purpose. Lets see if modules work. I don't use modules myself, so I would not know. But maybe we need to bump module version or something, because it is breaking change. Maybe others will help.

Can we keep the old struct and define a new one with a different name?

We changed SecurityAttributes, and it is used as a parameter in 11 exported functions. Do we duplicate all these API?
We changed from
type SecurityAttributes struct {
	Length             uint32
	SecurityDescriptor uintptr
	InheritHandle      uint32
}

to
type SecurityAttributes struct {
	Length             uint32
	SecurityDescriptor *SECURITY_DESCRIPTOR
	InheritHandle      uint32
}

When we created original version many years ago, we didn't care about use of SecurityDescriptor field. But now people want to use it.
If we cannot change SecurityAttributes, then people like Jason would have to store code in his private repo, and then others cannot benefit from his efforts.
Alex

In principle, I'd also prefer a new type being introduced. But since the change was already submitted and we have modules to select a particular revision of the module, I'd also be fine to keep it as is. Also, x/sys/windowsis vendored in the case of moby/docker, so the breakage would only occur after vendoring a new version. This is being done along with the necessary API changes in moby/moby#40021.
People who want the old type could also still use syscall.SecurityAttributes.

Modules only help if we tag the sources appropriately, which we aren't doing.  And a breaking change requires changing the import path to golang.org/x/sys/windows/v2, which seems undesirable for a minor change like this.
I guess if this is underway we can continue.  But let's please pay more attention to breaking changes.

Modules only help if we tag the sources appropriately

That's not entirely true. If they have a go.mod file, they'll keep getting the same version until they update their deps or update. So the breakage won't appear out of nowhere at least.

 Then we had to search the history to find a version Docker still compiled against.

It wasn't the end of the world, but pretty inconvenient.

FWIW, I agree we shouldn't be changing the API within a major version. I was just pointing out that it's not as bad as it used to be where different users could get different results depending on when they cloned various stuff.

Is there an official position on the compatibility guarantees for x/sys/windows? This is the second breaking change I've been made aware of in the last week.

Is there an official position on the compatibility guarantees for x/sys/windows? This is the second breaking change I've been made aware of in the last week.

The official position remains the same for all the Go repos: we shouldn't break compatibility. But we only have automated checks for that in the main "go" repo, so sometimes things slip by.
@jba was working on tooling to detect compatibility breakage for all repos, though. (What's the status of that?)
In the meantime we need to step up our human vigilance until we have automation. And/or roll things back when they happen, like I did the other day with the other issue.
I almost think we should roll this one back too on principle and add an accessor method(s) on the type to get at the pointer if we need it.

I almost think we should roll this one back too on principle and add an accessor method(s) on the type to get at the pointer if we need it.

Please don't. This change is already in effect, accessor methods are ugly, and a setter method would make clean & readable declarations of the code difficult.
If x/sys/windows can never be broken, I'm not sure that's a worthwhile project for me to continue to contribute to, and I'll probably wind up building something private instead. x/sys/windows is a good start, but there are a lot of weird warts and incomplete things, like this uintptr member, which over time need to be gradually fixed. Windows APIs are complicated and strange enough that it's unlikely we'll get everything perfect on the first try, and evolution is just simply necessary.

If x/sys/windows can never be broken, I'm not sure that's a worthwhile project for me to continue to contribute to, and I'll probably wind up building something private instead.

That's fine if you want to do that. It's more fun and locally optimal to hack away by yourself.
But we're building something for many people, and that means not breaking compatibility.
Maybe there's a middle road, though: you could work on a new major version (golang.org/x/sys/windows/v2) and clean up a bunch of stuff all at once.

I almost think we should roll this one back too on principle and add an accessor method(s) on the type to get at the pointer if we need it.

I have no problem with that.
But we also have to consider @zx2c4 sentiment.
Can we create new Git branch in that repo where we can develop. And copy branch changes onto master every once in a while (including incrementing module version number)?
Alex

But we're building something for many people, and that means not breaking compatibility.

I thought this is what modules were meant for, and x/sys is still unversioned. Ian wrote in https://github.com/golang/go/issues/34309#issuecomment-531630445 :

"We can break compatibility in x/sys/windows, but I don't think we can break it to that extent."

It seems like this is exactly the kind of "tiny breakage" that ought to be acceptable to keep the project at least minimally healthy. An ironclad commitment to never breaking it, when things are in such flux, will result in something monstrous overtime.

Seems like this issue has stalled, and the Docker folks are waiting on a decision here: https://github.com/moby/moby/pull/40021#issuecomment-537066824

It's been almost two weeks since that commit landed, and various projects have been updated. Seems disruptive to revert and cause more breakage.

It's been more than a month that https://github.com/golang/sys/commit/5c00192e8ce6429d705e1e4d83b4b22e79482964#diff-c4ffa695b270239c949ef5b31be6c4f5 landed and this discussion seems stale, can an owner confirm that the change will not get reverted and close this PR? This will hopefully allow https://github.com/moby/moby/pull/40021 to move forward.

Okay, decision: we won't revert. It's not a great situation, but rolling back would just cause different people pain (for the second time), so let's just keep it as it made the API better, even if it did so in an unfortunate way. We'll try to be more careful and maybe start using the new go release / gorelease (#26420) to catch these things like we do for std.
Plus people using modules don't feel the pain until they update deps, so it used to be worse.
Sorry.


Engine crashes after changing the opponent in the chart editor after pressing enter.

Describe your bug here. Mind you, if you are modding, please try testing your bug in a clean version of the engine instead, this ensures the bug is actually caused by the engine itself.
read title
Command Prompt/Terminal logs (if existing)
https://cdn.discordapp.com/attachments/979114840037683200/1198373489422381206/2024-01-20_22-06-44.png?ex=65beab48&is=65ac3648&hm=87f3af80b1bb7f2a76c2a253f17cd89777e039033c92b4898ce2945751286916&

copy and paste it on the url

Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
idk if it's considered as an editing but i only added a song on the bulid. it has nothing to do with the song but with the character
If you use 1.12.0 or earlier, did you have Optimized Chart Loading turned on?
None

can you provide logs please?

can you provide logs please?

it's on the link

update to the latest version


coreutils: Skip inotify dir-recreate test

Motivation for this change
Some target platforms, especially when building inside a container
have issues with the inotify test. I also saw issues related to that
test under macOS so I would suggest in skipping that for now.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[X] macOS
[X] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Assured whether relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Relates to #59934

Perhaps add a motivation in the code just above the line you've added?

Perhaps add a motivation in the code just above the line you've added?

Sure, I added the comment as suggested.


bug(stream): group_top_n/main.slt wrong results in end-to-end test (parallel)

Describe the bug
It fails here:
https://buildkite.com/risingwavelabs/pull-request/builds/35535#018bd6cd-c3f6-4d75-886b-217f111ba6cf
But passes after retry:
https://buildkite.com/risingwavelabs/pull-request/builds/35535#018bd6e1-43f6-4e4e-aa59-e9728bc92801
Error message/log
e2e_test/streaming/group_top_n/main.slt                      .. [FAILED]
failed to run `e2e_test/streaming/group_top_n/main.slt`
Caused by:
    query result mismatch:
    [SQL] select * from mv_with_expr_in_window;
    [Diff] (-expected|+actual)
    -   1  3
    -   1  4
    -   1  5
    -   2  4
    -   2  5
    -   3  5
    +   1 3
    +   1 4
    +   1 5
    +   2 5
    +   3 4
    +   3 5
    at e2e_test/streaming/group_top_n/main.slt:71

To Reproduce
No response
Expected behavior
No response
How did you deploy RisingWave?
No response
The version of RisingWave
No response
Additional context
Not sure on which commit it started.

expected after #12240 make the row id of the inserted records more random.
The record (2,4) and (3,4) have the same rank, so if it can be in the result depends on its stream key(row id)
dev=> select x, y, x/2, 6-y, RANK() OVER (PARTITION BY x/2 ORDER BY 6-y) as rank from t;
 x | y | ?column? | ?column? | rank
---+---+----------+----------+------
 1 | 5 |        0 |        1 |    1
 1 | 4 |        0 |        2 |    2
 1 | 3 |        0 |        3 |    3
 1 | 3 |        0 |        3 |    3
 1 | 2 |        0 |        4 |    5
 1 | 1 |        0 |        5 |    6
 2 | 5 |        1 |        1 |    1
 3 | 5 |        1 |        1 |    1
 2 | 4 |        1 |        2 |    3
 3 | 4 |        1 |        2 |    3
 2 | 3 |        1 |        3 |    5
 3 | 3 |        1 |        3 |    5
 2 | 3 |        1 |        3 |    5
 3 | 3 |        1 |        3 |    5
 2 | 2 |        1 |        4 |    9
 3 | 2 |        1 |        4 |    9
 2 | 1 |        1 |        5 |   11
 3 | 1 |        1 |        5 |   11
(18 rows)


v0.5 Model, Trainer refactor

There are three core changes in this PR:

A refactor of the Trainer object, now called a Training task. The idea is to provide users with a single entry point to the software being to implement the missing methods of the Training abstract interface. Users are welcome to use the fields, samplers, etc.. that flambe provides, but this interface ultimately provides more room for customization by having everything in one object.

build_model: constructs the model
build_optimizers: dictionary pointing from string to optimizer
build_schedulers: dictionary pointing from string to scheduler
sample_batches: yields batches of data
train_step: takes a batch and returns the loss
val_step: takes all validation batches and returns a set of evaluation metrics
val_metric: selects a single metric for validation

One of the thing I'm unhappy about in this design is the build_x methods. They are the way they are because I was trying to hide some boilerplate code from the users (namely fp16 and DataParallel) which modify the model but cannot be executed in place. This results in potentially a lot of private attributes used to construct the model, and is generally kind of ugly. Would appreciate suggestions. One alternate design would be to use a callback object of some sort, which Training would leverage.

The Encoder interface. Simply expands on the Module object to provide input_dim and output_dim methods. I'm considering whether we should make these optional methods on flambe.nn.Module instead of adding a new class. These methods provide a consistent way of accessing the size of the dimension that other objects may care about.

Optimizers and Scheduler can be instantiated without parameters. This makes the config cleaner, and is generally something I disliked in the original PyTorch interface. Again welcoming suggestions here, as it required writing down every Optimizer in PyTorch..

@iitzco-asapp

Not everything inherits from Encoder
I was having issues with mypy, may be resolved, I'll have to check
I ultimately felt like inheritance provided a better user experience here.
Testing will be done the same way as it is done now.

Closing as this as being reviewed.


WIP Account level metrics

Need to add some more tests for account level metrics. holding off till i get comments on the previous card

Need to add some more tests for account level metrics. holding off till i get comments on the previous card

Refactored and already merged into master


fix: Prevent global config of API Endpoint

Issues

Related to pull request #96

Description of changes:
There is a bug where the AWS SDK session is configured to use a specific endpoint.
This commit moves the endpoint configuration from the SDK Session to specific SDK Clients (SSM).
The SSM endpoint is passed in to the session-manager-plugin from the AWS CLI, and I believe the intention is to ensure any Region overrides from the AWS CLI are respected by the session-manager-plugin.
A problem occurs when the AWS credentials are sourced from AWS SSO / Identity Center.
When the SDK Session is configured with an endpoint, this overrides all Service Endpoints, including SDK internal SSO credential providers. When the current SSO credentials need to be refreshed, the refresh request is sent to https://ssm.[aws-region].amazonaws.com/token. The SSM API does not know about the /token endpoint, or CreateToken operation, and returns an UnknownOperation error.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Hi @Yangtao-Hua are you able to review this PR?
Thank you.


add: remove_sonos_playlist

There are currently a couple of ways to create a sonos playlist but no way to delete them.  I am getting ready to do a PR to add this functionality.  I do have a couple questions and figured it best to get them sorted here before I create the PR.

parameter name - the underlying contentDirectory.DestroyObject call requires an 'object_id' to be set. I have the function signature looking like this: remove_sonos_playlist(self, object_id)  The content of object_id should be the be the item_id (i.e. SQ:10) of the playlist to delete.  object_id and item_id are used in the code and I am not sure if the signature should be object_id or item_id.  I guessed object_id since that is what the underlying call is using.

Proper position in the SoCo class doc string for the new function.  Methods and Properties are split out but within those subgroups it is not strictly alpha order.  It appears to be sub-grouped by functionality and then alpha within that.  I have it listed after add_item_to_sonos_playlist in the docstring and within the code.  Ok? OR Should it come after the two create_... methods?

Testing - against the mock soco object only or against the mock and an actual device (--ip)? I am unsure if the project is trying to go completely mock or if the mock usage is just to augment testing when you don't have a reachable device.

doc strings and docs - I see a variety of doc string/documenting methods in play.  Which is the preferred version?  The method I used for to_dict @KennethNielsen behaved rather badly when my parameter doc string needed to wrap and I had to butcher it to make it fit on one line within the length limit of pyflake/pep8. I am pretty sure it was my formatting or some such, but I was unsure of where to read up on the requirements to make the output work as intended.

Best,
Jeff

Hi Jeff,

parameter name - the underlying contentDirectory.DestroyObject call requires an 'object_id' to be set. I have the function signature looking like this: remove_sonos_playlist(self, object_id) The content of object_id should be the be the item_id (i.e. SQ:10) of the playlist to delete. object_id and item_id are used in the code and I am not sure if the signature should be object_id or item_id. I guessed object_id since that is what the underlying call is using.

item_id seems to be what Sonos uses to refer to the id of a metadata or music item (e.g. a track or album). It uses object_id for UPnP calls.  So I guess object_id is correct here.

Proper position in the SoCo class doc string for the new function. Methods and Properties are split out but within those subgroups it is not strictly alpha order. It appears to be sub-grouped by functionality and then alpha within that. I have it listed after add_item_to_sonos_playlist in the docstring and within the code. Ok? OR Should it come after the two create_... methods?

I am not sure that people have paid that much attention to it, and the whole docstring probably needs rewriting anyway. I have tried to keep related functions together (e.g. all transport functions, all queue functions etc). Put it where you have suggested.  At some point, we may split core.py into several smaller files.

Testing - against the mock soco object only or against the mock and an actual device (--ip)? I am unsure if the project is trying to go completely mock or if the mock usage is just to augment testing when you don't have a reachable device.

Originally, all testing was done 'live'. But we then introduced unittests and mocks, and wrote the --ip flag. I tend to test against mocks only most of the time, and occasionally against a live device. It would be nice to have both for the functionality you are suggesting.

doc strings and docs - I see a variety of doc string/documenting methods in play. Which is the preferred version? The method I used for to_dict @KennethNielsen behaved rather badly when my parameter doc string needed to wrap and I had to butcher it to make it fit on one line within the length limit of pyflake/pep8. I am pretty sure it was my formatting or some such, but I was unsure of where to read up on the requirements to make the output work as intended.

Not sure what problems you have, but we are now trying to use Google style docstrings (though we are not very good at it!)  See here: http://sphinxcontrib-napoleon.readthedocs.org/en/latest/example_google.html  Some of the older code is not updated yet.
Lawrence

attempting test membership of a DIdlPlayListContainer to the items in .get_sonos_playlists() always fails.
new_playlist = soco.create_new_playlist(title='foo')
assert new_playlist in soco.get_sonos_playlists()     # fails
assert new_playlist.item_id in [x.item_id for x in soco.get_sonos_playlists()]   # passes

Is this because the items from the .get_sonos_playlists are not considered playable?  see soco/data_structures.py::DidlObject._eq_
Currently, I am comparing using .item_id to test for membership. However, I was confused and a bit disappointed that I couldn't use the first assert.

Hi @dundeemt

Is this because the items from the .get_sonos_playlists are not considered playable?

Well, they are playable and therefore certainly also should be considered as such.
Can you check what actually differs? __eq__ checks for equality of the to_dict values, so it would be nice to what actually fails.

The following code:
created_pl = soco.create_sonos_playlist(title=self.pl_name)
print created_pl.to_dict()
for pl in soco.get_sonos_playlists():
    print pl.to_dict()
assert created_pl.to_dict() in [x.to_dict() for x in soco.get_sonos_playlists()]

emits the following:
{u'title': u'zSocoTestPlayList42', u'restricted': True, u'parent_id': u'SQ:', u'item_id': 'SQ:118', u'resources': [<DidlResource 'file:///jffs/settings/savedqueues.rsq#118' at 0x7f9e4890cb50>], u'desc': u'RINCON_AssociatedZPUDN'}
... snipped ...
{u'title': u'zSocoTestPlayList42', u'restricted': True, u'parent_id': u'SQ:', u'item_id': u'SQ:118', u'resources': [<DidlResource 'file:///jffs/settings/savedqueues.rsq#118' at 0x7f9e4890c810>], u'desc': None}

The DidlPlaylistContainer emitted by create_sonos_playlist has differences starting at item_id, the returned value is a 'SQ:118' vs. u'SQ:118' .
The resources element has not been converted to a dictionary and it should be if it inherits from DidlObject -- correct? Or it is overridden somewhere. So  comparing the _repr_ of the objects fails because of location differences.
And finally, the desc element has a value, and none of the results from .get_sonos_playlists do.

closed by PR #345


Add Geist Lending

Not harvestOnDeposit as it can be quite expensive due to receiving and swapping up to 7 different reward tokens and then leveraging twice.
FTM
Vault: 0xbf1340159c1b69Ae98Ff08BE5fC77cdc084dDc73
Strategy: 0xFd41FDec0d4a245B13d15786fdcd9427B660Ec21
Want: 0x21be370D5312f44cB42ce377BC9b8a0cEF1A4C83
WBTC
Vault: 0x7489bFD512BEDd6b16318fa7c33F1Bc7075C372d
Strategy: 0x82EE77037DE0F540eF5cb72355C689f33361423C
Want: 0x321162Cd933E2Be498Cd2267a90534A804051b11
ETH
Vault: 0x7bdD39339bE40adC54199aB4b5Fb6B2A89D40d4c
Strategy: 0x22d53d93c476Db639079943efA80B9426500Afee
Want: 0x74b23882a30290451A17c44f4F05243b6b58C76d
fUSDT
Vault: 0xe9B01CB6c9379a491108119713b7D62C38DB9C97
Strategy: 0x3Faf7CBfC85F78D7085915846537950e4D2e0C8a
Want: 0x049d68029688eAbF473097a2fC38ef61633A3C7A
USDC
Vault: 0x4Fa9263B35DC20bfa2eDEE24ee26113b40C4D3bB
Strategy: 0x223b87a14D08A5d2fF7B7B911F1480F9aDc47dE7
Want: 0x04068DA6C83AFCFA0e13ba15A6696662335D5B75
DAI
Vault: 0x315d6030e908835b1dfE3393213Cab70bfB30Ace
Strategy: 0x5F12a657032D3A43f2bBe368caD5e8074BD65eAE
Want: 0x8D11eC38a3EB5E956B052f67Da8Bdc9bef8Abf3E

please open PR to contracts with this strategy, would be nice to have few additional eyes on it before releasing (chargeFees).
i see StrategyAaveAvalanche in code, and its also not in contracts.
basically every deployed strat should be in contracts repo ready to be deployed (beethoven strat cant compile as i remember)


bug: http post

Type: bug
Ionic Version: 2.x
Platform: android 6.0 webview
when make a post call, for example:
    var creds = "username=" + user.username + "&password=" + user.password;
    var headers = new Headers();
    headers.append('Content-Type', 'application/x-www-form-urlencoded');
    headers.append('Cache-Control', 'no-cache');
    headers.append('Cache-Control', 'no-store');
    headers.append('Expires', '0');
    headers.append('Pragma', 'no-cache');

    return new Promise(resolve => {

        console.log('credenziali: ', creds);

        this.http.post('SERVER-URL', creds, {headers: headers})
        .map(res => res.json())

        .subscribe(data => {

            console.log('risultato chiamata: ', data);

            //if(data.json().success){
              if(data.status == 200 && data.statusText == "OK"){

                this.storeUserCredentials(data['_body']);
                resolve(true);
            }
            else
                resolve(data.statusText);
        },

        error => {
               console.log("error", error)
              resolve(error.statusText);
          },

        () => {
                console.log('onComplete')
      });

These is the bug:
correct user data -> login process ok
wrong user data -> login process ko -> correct user data -> login process ko
wrong user data -> delete app data from Android Settings -> open app -> correct user data -> login process ok
It seems that (angular or ionic) caches somehow http call or something like that.
Thank you.

Hello! Thank you for opening an issue with us! Would you be able to provide a sample application via GitHub that demonstrates the issue you are having?
A few questions that might help solve this:
Is this only on Android? What happens if you run on iOS? locally via web browser?
Have you run remote debug on it and looked at the network traffic? What does the communication back and forth look like?
Thanks for using Ionic!

i followed this tutorial:
https://www.djamware.com/post/58c1703e80aca7585c808ec1/step-by-step-tutorial-building-ionic-2-rest-api-authentication
when i don't make mistakes using the correct username and password the process login is all ok but when i try to put wrong data it gives me an error 401 unauthorized error even when in the third and later attempt i put the correct data.
I tried only on Android and via browser ( via browser i have cors issues )

Thank you for the reply.

when i try to put wrong data it gives me an error 401 unauthorized error even when in the third and later attempt

Have you verified that the correct data is being sent in the request on the third and later attempts?

Yes and this is the reason i think thai there is some cache process because when i delete app data of the app from settings and i retry the login process if i put directly the correct auth data it gives me no error.
Thank you very much
Inviato da iPhone
Il giorno 06 set 2017, alle ore 20:35, Ken Sodemann <notifications<EMAIL_ADDRESS>ha scritto:
Thank you for the reply.
when i try to put wrong data it gives me an error 401 unauthorized error even when in the third and later attempt
Have you verified that the correct data is being sent in the request on the third and later attempts?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/ionic-team/ionic/issues/12830#issuecomment-327574834, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ad1Vg3jJwzAz8UO2Badj8Htm4UPsi3hAks5sfuYCgaJpZM4POswI.

Just to clarify, when you try this with the wrong credentials, you see something like this in Chrome's network tab:

And then when you subsequently send the correct login information you see something very similar only with the correct data? But then still get a 401?
Also, have you tried asking this question on our forum or on our slack channel.
At this point, I will have to close this as more of a support question but if you can provide a GitHub repo that demonstrates a bug in the Ionic Framework regarding this I will be happy to reopen the issue.


Circuit connections inside group within a blueprint fail to create blueprint string

After adding circuit connections to entities within a group and adding that Group to a Blueprint, when I try to convert the blueprint to a string, I get a ValueError that the connected entity is not in the list.  More specifically, I load up a blueprint and add a few circuit connections (at this point, the blueprint is still good and can export to string with no issue).  I then create a Group from the entities of the blueprint.  I add the Group to a new Blueprint and try to create the string from it, but it breaks.  If I do not make the circuit connections, there's no problem and can import it to Factorio no problem.  I've attached my code and the error code:
Exception has occurred: ValueError <LogisticRequestContainer '5'>{'name': 'logistic-chest-requester', 'position': {'x': 43.5, 'y': -0.5}, 'connections': {'1': {'green': [{'entity_id': <Association to Inserter with id '0'>}], 'red': [{'entity_id': <Association to Inserter with id '4'>}]}}} is not in list
# Labs bp
bp_str = "0eJy1ldtugzAMht/F10kFAUrhcq8xTRMHq4sGgZFQDVW8+5K2q+ja0ZCtVxzsfL/j2PEe8qrHtuNCQboHXjRCQvq8B8m3IqvMPzW0CClwhTUQEFltvnLMtCuMBLgo8RNSfyR3F1VZPlnBxhcCKBRXHI+aEzcCbSO1RWtomvam/ioiMOhlq8gwNFgaU9s1ZV8ovuNqoLV+r5AGBn5iD6+ir3PsThFehn+tEpxUoksV2SKW83hmg/ec8YEFnjnTwwldqqx4p1xI7JS2/b4J7yDzgxQtIM2C1hNQ1Wy5VLygxRtKRTv86PVzNjh6Exo7QeeZG5fcmXLWqJJ3WBzt4RU4cUilDdf3plm41WzfvWbawbHZrLrtHPV6ccX6Nv3G/sC3aTjKLitjkUBoewruN160JEcOW1jf2wL9h0qKl9zbLie9eejV6iePLVTmmTl6GLTpZJgT2GEnDwps44dxwuKQJUmQ+MQcFeopDU9n73H8AlTBmZE="
bp = Blueprint(bp_str)
bp2 = Blueprint(bp_str)

new_id = 0
inserters = bp.find_entities_filtered(type='inserter')
for ins in inserters:
    ins.id = str(new_id)
    new_id += 1
    base_pos = ins.position
    pos1 = (base_pos['x'], base_pos['y']+1)
    nb = bp.find_entities_filtered(position=pos1)
    if(nb[0].type == 'logistic-container'):
        nb[0].id = str(new_id)
        new_id += 1
        bp.add_circuit_connection('red', ins.id, nb[0].id)
    pos1 = (base_pos['x'], base_pos['y']-1)
    nb = bp.find_entities_filtered(position=pos1)
    if(nb[0].type == 'logistic-container'):
        nb[0].id = str(new_id)
        new_id += 1
        bp.add_circuit_connection('green', ins.id, nb[0].id)

g1 = Group('g1', entities=bp2.entities)
g2 = Group('g2', entities=bp.entities)

for entity in g2.entities:
    entity.position['x'] += 9
bp3 = Blueprint()
# bp3.entities.append(g1)
bp3.entities.append(g2)

print(bp3.to_string())

A quick addition to this, but this error is not limited to circuit connections, but power connections as well.  That's probably a given, but better to be thorough.

Having a constructor for Group that accepts a string would be nice since it'll save computation time converting from a blueprint to a group.  That will be good considering my comment in #20.

Alright, I'll put it in now. What attributes would you like to acquire from a blueprint string? Should it just be the entities, or is there extra information that you would like to extract?

I think entities is all I should need.  If not, I can just override the __init__ function and grab more data.  I feel like the only other thing I might need is some location data, like local/absolute position.  I haven't gotten to that point yet.


New front end

Problem Description
New Product: “The current state of the Eloverblik has focused primarily on getting to market and not on UX. Reasonably created UX-report shows multiple issues with the UX. Thus, customers are misguided when trying to use the product. Existing products/services fail to address the UX. Our product/service will address this gap by creating a new front end.
Benefit Hypothesis
We believe that by rewriting the front end, a better UX can be gained and UX issues can be mitigated or removed. The wish about a mobilefirst platform can be realized.
Acceptance criteria and must have scope

Logical front end layout
Mobilefirst
Test for the front end must be automized

Objectives and key results
Increased usability, better front end, mobile friendly and a better UX in general
Leading Indicators
UX wireframes and user tests
Non Functional Requirements
/
Stakeholders
-BSJ, UX’er (MightyDucks), End user testers
Timeline
Ressources: UX’ers (MightyDucks)

På PI planning har vi aftalt, at der er overlap mellem funktionalitet for Energioprindelse og Eloverblik. Derfor er scope for denne feature følgende:

Login på én portal for private kunder
Tilknytning af målepunkter via CPR
Visualisering af private kunders forbrug og produktion på time-, dag-, uge-, måneds- og årsniveau
Hente private kunders forbrugs- og produktionsdata


No LICENSE file

Can you specify what license this is distributed under please? Without that its not possible for this to be used in most corporate environments.

Thank you I have added unlicensed license declaration http://unlicense.org/


Unable to install using npm, or serverless install, on EC2

Hi,
First, thank you for your work, and for making it public!
I'm having a hard time installing serverless-chrome on my AWS EC2 instance. Following the instructions (transcript below) gives me an error about eslint-plugin-import and eslint-config-airbnb-base:
$ git clone https://github.com/adieuadieu/serverless-chrome
$ cd serverless-chrome
$ npm install
npm WARN peerDependencies The peer dependency webpack@2 || 3 included from babel-loader will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm WARN peerDependencies The peer dependency<EMAIL_ADDRESS>included from eslint-config-airbnb-base will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm WARN optional dep failed, continuing<EMAIL_ADDRESS>npm WARN optional dep failed, continuing<EMAIL_ADDRESS>npm WARN engine<EMAIL_ADDRESS>wanted: {"node":">=6.10.0"} (current: {"node":"4.8.4","npm":"2.15.11"})
npm WARN engine<EMAIL_ADDRESS>wanted: {"node":">=6"} (current: {"node":"4.8.4","npm":"2.15.11"})
\
><EMAIL_ADDRESS>postinstall /home/ec2-user/serverless-chrome/node_modules/serverless/node_modules/tabtab/node_modules/inquirer/node_modules/external-editor/node_modules/spawn-sync
> node postinstall
\
><EMAIL_ADDRESS>postinstall /home/ec2-user/serverless-chrome/node_modules/serverless
> node ./scripts/postinstall.js

><EMAIL_ADDRESS>postinstall /home/ec2-user/serverless-chrome
> if [ ! -f ./config.js ]; then UUID=$(openssl rand -base64 32 | tr -d "/=+"); echo "export default {uuid: \"$UUID\"}" > ./config.js; fi

npm ERR! Linux 4.9.20-11.31.amzn1.x86_64
npm ERR! argv "/usr/bin/node" "/usr/bin/npm" "install"
npm ERR! node v4.8.4
npm ERR! npm  v2.15.11
npm ERR! code EPEERINVALID

npm ERR! peerinvalid The package<EMAIL_ADDRESS>does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>
npm ERR! Please include the following file with any support request:
npm ERR!     /home/ec2-user/serverless-chrome/npm-debug.log

npm-debug.log.txt
I tried installing with serverless install -u https://github.com/adieuadieu/serverless-chrome, got this cryptic error:
$ serverless install -u https://github.com/adieuadieu/serverless-chrome
Serverless: Downloading and installing "serverless-chrome"...

  Range Error --------------------------------------------

  Invalid array buffer length

     For debugging logs, run again after setting the "SLS_DEBUG=*" environment variable.

  Get Support --------------------------------------------
     Docs:          docs.serverless.com
     Bugs:          github.com/serverless/serverless/issues
     Forums:        forum.serverless.com
     Chat:          gitter.im/serverless/serverless

  Your Environment Information -----------------------------
     OS:                     linux
     Node Version:           4.8.4
     Serverless Version:     1.20.2

Any and all help would be appreciated.

Hi @kirilledelman — Serverless-chrome requires at least Node 6.10 but it looks like you've got Node 4.8.4 installed.
You might also try using either the standalone @serverless-chrome/lambda NPM package, or the Serverless-framework plugin serverless-plugin-chrome NPM package. However, they also require at least Node 6.10.

@adieuadieu Thank you! It worked.


OC-429 ~ Removes activate and deactivate device requests

All is well.

All is well.

All is well.


Importing drawflow theme css breaks my appearance

Sorry I wasn't sure where to post this question, I know it's not directly related to Drawflow...
This is what I designed:

When I press export and copy the CSS, and reference it in App.vue like this
<style>
    @import './assets/styles/newStyle.css';
</style>

It breaks my setup. Here is what my browser looks like

Do I need to do anything special for importing a theme?

You also have to import the minimal theme drawflow.min.css.
The theme does not replace the min file, it overwrites it.
If you don't have it added, try putting the style in head.

Oh I see. Thank you so much! I didn't realize that I needed to import the theme alongside drawflow.min.css


Float incorretly casted to PDO::PARAM_INT in MySQL, should be: PDO::PARAM_STRING

Laravel Version: 5.5.40
PHP Version: 7.1
Database Driver & Version: MariaDB 10.0.24 (MySQL 5.6)

Description:
When issuing the following command:
User::where('rating', '>', 2.5)->get()
The query that actually goes to the database is:
WHERE rating > 2
What should go to the database in order for correct behavior:
WHERE rating > '2.5'
This is caused by the MysqlConnection using PDO::PARAM_INT
According to this wiki article by PHP it should use PDO::PARAM_STRING
https://wiki.php.net/rfc/pdo_float_type
The PDO extension does not have a type to represent floating point values.

The current recommended practice is to use PDO::PARAM_STR

The line that causes the issue is:
https://github.com/laravel/framework/blob/59a045343e0994b45b66fd6afa9199c2d566e0ba/src/Illuminate/Database/MySqlConnection.php#L80
It should be edited to:
is_int($value) ? PDO::PARAM_INT : PDO::PARAM_STR

@themsaid this is something you have touched before.
If this is intentional, could you maybe explain why floating point values are not converted to strings, as per the wiki article.

See also #23850.

@staudenmeir Thanks for referencing that. I have a read a couple of more issue topics but am still uncertain about why it is not cast to string.
The one that really matters is: #16063 , which highlights the issues with JSON comparison
However, I think it is safe to say that we should not solve one issue by introducing another.
This should at least be mentioned on the Database/Eloquent page that when using a float in the where query, it should first be casted to string. This should already  prevent a lot of people having headaches!

Thanks - I'll close this.
@stemis - feel free to submit a PR to the docs with your idea above.

@stemis do you have PDO::ATTR_EMULATE_PREPARES = true ?
I noticed that this option causes this behaviour. Please check #23850


Yuzu updates for 2024-02-03

Description of changes
Switching to vendored ffmpeg because early access uses internal APIs now :(
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

There's some weird performance regression, drafting for now

The latest builds address the frame pacing regressions.


feat(not added deadline item): add functionality to tell user to add a deadline item

:tada: This PR is included in version 2.5.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add object display test

Prior to this commit there was no test to provide assurances that changes
to the codebase would not effect the expected output implemented as the
Display trait. This commit adds a test to help provide that assurance.

Coverage increased (+13.8%) to 83.111% when pulling 2a9b42dd8c06e8043e008d20c8eb3ea01be72fd4 on add-display-validation-test into bd3a9318452169b7c44fc247f0694958dc86373d on master.


No dock widget icon to drag in customize

Describe the bug
When I go to the customize screen, there is no way to drag the Dock widget to the touchbar. The text shows up, but the area to drag is blank. I'm guessing this is a Big Sur issue (pre-widget version of Pock was fine on Big Sur).
Expected behavior
A way to drag the Dock to the touchbar
Screenshots

Versions:

macOS version: 11.2.1
Pock version:  0.8.1-5

Additional context
I have tried reinstalling both Pock and the Widgets from scratch. Security settings should be ok as the previous version of Pock was fine.

Same problem in 10.15.7

Same problem. This is a fresh install on a new laptop, but all security settings have been set according the instructions

Same problem in 11.2

Same problem

Same here on brand new M1 @ 11.2.

Same problem @ 11.1 (fresh install, all permissions should be enabled).

Hi! Try following the instructions in this reddit's thread: https://www.reddit.com/r/MacOS/comments/lggk6o/comment/gms2gg2

Thanks, @pigigaldi, the version downgrade helped 👍

For me too @pigigaldi ! THANKS

This also worked for me.

Sadly this didn't work for me. Tried downgrading then upgrading (1.1-8), as well as uninstalling and downloading the latest widget — still not seeing anything that I can drag.

The steps that worked for me were.

Uninstall widget.
Install widget via the link from the reddit post.
Add to the touchbar
Upgrade the widget.

Step 3 is the one that has to be done at that exact point in the procedure. Once you upgrade the widget, you can no longer see it in the customization window. So you've got to add it before upgrading.

Yep, that workaround worked for me. A bit of a mess though.

Ahhh, two key points (I was doing incorrectly):

Install widget via the link from the reddit post.

i) When installing the old widget, do not download the zip file, extract and install via "Drag Widget Here" — Mac OS warned it couldn't "check it for malicious software", and disabled it. From Open Widgets Manager, I was immediately prompted to update the widget (don't), which is important because...

Add to the touchbar
...
Step 3 is the one that has to be done at that exact point in the procedure. Once you upgrade the widget, you can no longer see it in the customization window. So you've got to add it before upgrading.

ii) As @jonathanabennett pointed out, you have to customize and drag the old widget onto the touchbar prior to upgrading it.
Thanks, works now!


Fixes version in README file

This PR fixes the version after the release.
Please @juanpedromoreno could you review? Thanks

LGTM


Wrong location

In this step:

Run the following command to install IIS on the virtual machine:

Set-AzVMExtension   -ResourceGroupName myResourceGroupAG
-ExtensionName IIS   -VMName contosoVM
-Publisher Microsoft.Compute   -ExtensionType CustomScriptExtension
-TypeHandlerVersion 1.4   -SettingString '{"commandToExecute":"powershell Add-WindowsFeature Web-Server; powershell Add-Content -Path \"C:\\inetpub\\wwwroot\\Default.htm\" -Value $($env:computername)"}'
-Location EastUS
There is a typo in the  "-Location EastUS"
All the resources are created in WestUS2 as per the previous instructions in the guide.
Then, the cmdlet fails due to the wrong location.
It should say  "-Location WestUs2"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 841418eb-7a51-60fe-a651-bf77a7c790de
Version Independent ID: 2a5ede90-8d15-e4d4-faa6-99efed460a54
Content: Tutorial: Hosts multiple web sites using the Azure portal - Azure Application Gateway
Content Source: articles/application-gateway/create-multiple-sites-portal.md
Service: application-gateway
GitHub Login: @vhorne
Microsoft Alias: victorh

@MauricioZa , Thanks for reaching out. We will investigate and update this thread.


[UI][Related Link] Some commonly used icons should be added to our project

Github icon, Twitter icon

And a common icon for all other sites

And a common icon for all other sites


New User: Diigo

Please fill the following out:

Name: Diigo
Homepage url: https://www.diigo.com/index
Logo:https://www.diigo.com/images/v6/logo.png

Nice, wanna open a PR for it? Here's some examples


Removing overridden JSON.stringify method (toJSON) for clarity when s…

…tringifying a model.

Thanks, Austin! I'll update the major version number since this is a breaking (but good) change and then publish to NPM.

Published<EMAIL_ADDRESS>


[Bug]: Play button not showing

Give a brief about the bug discovered✍
Hey @panwar8279 The buttons to play the game are not visible on the website. I have attached a screenshot to have a better look. Please have a look at it and assign me this issue. Thank you!

What is the expected behavior?
The buttons should be visible to the users for a better user experience.
Give a brief description to get the expect behaviour.

Increase the height of the cards.
Align the button in the center.

Are you contributing for a program?
GSSoC2023
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hi @sumitkr2000 , i am assigning this issue to you. Kindly complete within 2 days. Good luck sumit!


improves cmdset elements.xml explanation

Category

[x] Content fix
[ ] New article

What's in this Pull Request?
Adds clarification to elements.xml section regarding RegistrationIds. The elements.xml currently provided is the default from the yeoman generator and will only work with lists when deployed, not document libraries. Based on the behavior when running localhost, it is easy to make the assumption that the custom action will be applied to both lists and document libraries, but that is not the case once deployed.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/spfx/extensions/get-started/building-simple-cmdset-with-dialog-api.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

thx @gunna025, appreciated.


Drop ecto_paging

[x] update public specs
[ ] change implementation
[ ] change FE implementations

Updated spec for new APIs (reimbursement, reports): created new data structure


Add Linutil Logo via state.rs.

Type of Change

[x] New feature
[ ] Bug fix
[ ] Documentation Update
[ ] Refactoring
[ ] Hotfix
[ ] Security patch
[x] UI/UX improvement

Description
This PR includes the following changes:
Add Linutil Logo: Adds a new ASCII logo for Linutil by editing state.rs and using ANSI color codes in the ratatui library to render a colorful (blue) logo.
The changes are primarily aesthetic and focused on improving the user experience through clear messaging and branding.
Testing

Tested the rendering of the ASCII logo to ensure it displays properly and the colors are applied correctly.

Impact

No new dependencies introduced.
The changes are visual and should not impact performance or core functionality.

Issue related to PR

Resolves no specific issue but addresses minor UI/UX improvements.

Additional Information

The logo is designed in blue using ANSI colors, adding a unique branding element to Linutil.

Checklist

[x] My code adheres to the coding and style guidelines of the project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no errors/warnings/merge conflicts.

@fam007e Duplicate of #379

Please drop changes in hint.rs.

Can you add a preview of how this looks?


feat: support the flag "-var"

#59

Codecov Report

Merging #61 into master will increase coverage by 0.30%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   31.14%   31.45%   +0.30%
==========================================
  Files           2        2
  Lines         122      124       +2
==========================================
+ Hits           38       39       +1
- Misses         76       77       +1
  Partials        8        8

Impacted Files
Coverage Δ

pkg/api/exec.go
10.14% <0.00%> (-0.15%)
:arrow_down:

pkg/api/post.go
58.18% <100.00%> (+0.77%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ae20a3...a4ecde6. Read the comment docs.


pkg-config targets are not created

I've read Brief overview section and do understand basic concepts. Yes
I've read F.A.Q. section and there is no solution to my problem there. Yes
I've read Code of Conduct, I promise to be polite and will do my best at being constructive. Yes
I've read Reporting bugs section carefully. Yes
I've checked that all the hunter_add_package/find_package API used by me in the example is the same as in documentation. Not applicable
I'm using latest Hunter URL/SHA1. Yes

I'm trying to write a package for libconfig, but it doesn't seem to generate pkg-config targets. I get the error message Target "boo_cpp" links to target "PkgConfig::libconfig++" but the target was not found..
Here is the commit: https://github.com/tastytea/hunter/commit/8413187511fbd297144e782d266a7b66a5e37304
There are 2 pkg-config files installed, libconfig++ and libconfig. This is the resulting libconfig++Config.cmake (libconfigConfig.cmake is the same, but whithout ++):
# […]/Cellar/[…]/raw/lib/cmake/libconfig++/libconfig++Config.cmake
set(LIBCONFIG++_FOUND 1)
set(LIBCONFIG++_VERSION "1.7")
set(LIBCONFIG++_LIBRARIES "config++")
set(LIBCONFIG++_LIBRARY_DIRS "${exec_prefix}/lib")
set(LIBCONFIG++_LDFLAGS "")
set(LIBCONFIG++_INCLUDE_DIRS "${prefix}/include")
set(LIBCONFIG++_CFLAGS "")
)

This is the corresponding libconfig++.pc:
# […]/Cellar/[…]/raw/lib/pkgconfig/libconfig++.pc
prefix=__HUNTER_PACKAGE_INSTALL_PREFIX__
exec_prefix=${prefix}
libdir=${exec_prefix}/lib
includedir=${prefix}/include
Name: libconfig++
Description: C++ Configuration File Library
Version: 1.7.2
URL: http://www.hyperrealm.com/main.php?s=libconfig
Requires:
Conflicts:
Libs: -L${libdir} -lconfig++
Libs.private:
Cflags: -I${includedir}

Travis build reproducing issue:

https://travis-ci.com/tastytea/hunter/builds/121464586

Here is the log until first error reported by Hunter, option HUNTER_STATUS_DEBUG is ON:

log.txt

I've checked that the first error in logs IS NOT external.build.failed. Yes

I'm building on Linux.
I'm using system CMake
CMake version: 3.14.3

I'm using unmodified toolchain gcc from Polly

Edit: Added `libconfig++.pc`

There are 2 pkg-config files installed, libconfig++ and libconfig. This is the resulting libconfig++Config.cmake (libconfigConfig.cmake is the same, but whithout ++)

The file libconfigConfig.cmake created by the package itself, not by Hunter:
config.status: creating lib/libconfigConfig.cmake
config.status: creating lib/libconfig++Config.cmake
...
/usr/bin/install -c -m 644 libconfigConfig.cmake '/home/travis/build/tastytea/hunter/_testing/Hunter/_Base/c770725/239e635/c4d7b01/Build/libconfig/Install/lib/cmake/libconfig'
/bin/mkdir -p '/home/travis/build/tastytea/hunter/_testing/Hunter/_Base/c770725/239e635/c4d7b01/Build/libconfig/Install/lib/cmake/libconfig++'
/usr/bin/install -c -m 644 libconfig++Config.cmake '/home/travis/build/tastytea/hunter/_testing/Hunter/_Base/c770725/239e635/c4d7b01/Build/libconfig/Install/lib/cmake/libconfig++'

And as you can see, file libconfigConfig.cmake doesn't providing imported target as it should. A workaround is to patch the package. A solution is to send such patch upstream.

A good motivator for finally learning a bit more CMake I guess. 🙂
Is there a way to disregard the supplied *Config.cmake and generate them from pkg-config in the meantime?

generate them from pkg-config in the meantime?

That's what Hunter do:

https://github.com/ruslo/hunter/blob/v0.23.206/cmake/schemes/url_sha1_autotools.cmake.in#L74-L83

But the package overwrites this file on installation step.

https://github.com/ruslo/hunter/blob/v0.23.214/README.rst