Multicluster bootstrap in antctl

Describe what you are trying to solve

The antrea multi-cluster cluster set can be deployed following the instruction
Describe the solution you have in mind

Add a sub-command deploy so users can run antctl deploy to deploy a new antrea multi-cluster cluster set rather to apply YAML files themselves.
In the early stages, we will add command such as antctl deploy or antctl init to initialize the cluster set.  Then we will add command suck as antctl add-cluster or antctl join-cluster to join member clusters, antctl delete cluster to delete member clusters. And update command may not necessary.
Describe how your solution impacts user flows

It makes it easier to deploy multi-cluster set.
Describe the main design/architecture of your solution

antctl deploy should support below features.

initialize a leader cluster. eg. antctl deploy/init leader-cluster.
off-boarding a member cluster. eg. antctl delete member-cluster.
initialize a member cluster. eg. antctl deploy/init member-cluster.
join a member cluster. eg. antctl join member-cluster
clear cluster set. eg. antctl clear/reset clusterset

Examples:

Deploy leader cluster:
antctl deploy leader-cluster --name <CLUSTER_NAME> --kubeconfig <PATH_OF_KUBECONFIG>
Deploy member cluster:
antctl deploy member-cluster --name <CLUSTER_NAME> --kubeconfig <PATH_OF_KUBECONFIG> --leader <SERVER_ADDRESS_OF_LEADER>
Delete member cluster:
antctl delete member-cluster --name <CLUSTER_NAME> --kubeconfig <PATH_OF_KUBECONFIG>

Alternative solutions that you considered

Test plan

Additional context

The command antctl deploy/delete/clear looks like a global command, this may cause misunderstandings that users may think it is used for deploy antrea controllers. I wonder if there is a better commands. antctl mc deploy or antctl multi-cluster deploy maybe okay, but mc is not a verb.

@luolanzone Could you help to review it ? Thanks .

this is a part of #3107

I suppose antctl deploy leader-cluster will just deploy leader controller and antctl init leader-cluster will do some tasks like adding ClusterSet and ClusterClaim for the leader?

I feel in K8s such orchestration should be done by an operator, but not CLI. @salv-orlando @tnqn @antoninbas might have opinions too.

I tend to agree with @jianjuns about the operator, but I don't have a very strong opinion. Having this support in antctl can be a stop-gap solution too if needed. I think we discussed in the past that a few things could benefit from being both antctl commands and operator functions (we discussed having a shared "library" between the 2 IIRC).

@hjiajing  I think we need an option like --version here to allow user to deploy different version of Multicluster controller.

I agree. It's weird if running cmd on a cluster member to delete/deploy another member cluster via antctl.

@hjiajing I think we need an option like --version here to allow user to deploy different versions of Multicluster controller.

okay，I'll do it

I feel in K8s such orchestration should be done by an operator, but not CLI. @salv-orlando @tnqn @antoninbas might have opinions too.

AFAIK, istio and cilium have started to use CLI for installing their components. For example, https://istio.io/latest/docs/setup/install/istioctl/#install-istio-using-the-default-profile

Good to know this. Thought over. Probably I need to understand better how the antctl way works. For example, for joining a member, do we run the command in member or in leader, and does the command needs to interact with a remote cluster too?

Commands
In the first stage, we plan to implement those commands below which can help users to set up and initialize and delete a cluster set quickly.

antctl mc deploy leader/member cluster: used for initializing a leader or member cluster.
antctl mc delete member-cluster: used for deleting a member cluster.
antctl mc delete cluster-set: used for deleting a cluster set.

Deploy
The deploy sub-command is used to deploy specific multi-cluster controller and create the CRDs of multi-cluster in the cluster. There are two arguments, one is leader-cluster, another is member-cluster.
antctl mc deploy leader-cluster is used to set up leader cluster of the cluster set.
antctl mc deploy leader-cluster

Options:
-n, --namespace: namespace to deploy multi-cluster controller
--cluster-id: the leader cluster id.
--version: version of multi-cluster controller

For example, we could deploy test-leader-cluster in the antrea-test namespace by following command:
antctl mc deploy leader-cluster --cluster-id test-leader-cluster --kubeconfig $HOME/.kube/config -n antrea-test

antctl mc deploy member-cluster is used to set up member cluster of the cluster set.
antctl mc deploy member-cluster

Options:
-n, --namesapce: namespace to deploy multi-cluster controller
--cluster-id: the member cluster id
--version: version of multi-cluster controller
--leader-cluster-kubeconfig: path of the leader cluster kubeconfig file
--token: access token of the leader cluster
--sa, service-account: service-account of the leader cluster

For example, we can deploy a member cluster by following commands:
antctl mc deploy leader-cluster --cluster-id test-member-cluster --leader-cluster-kubeconfig $HOME/.kube/leader-cluster-config

Delete
The delete sub-command is used to delete the multi-cluster and the CRDs in a cluster, in the meanwhile, the cluster claim will also be deleted.
antctl mc delete member-cluster <CLUSTER_ID>

Options:
-n, namespace: namespace of the cluster
--leader-cluster-kubeconfig: path of the leader cluster kubeconfig file

For example, we can delete a member cluster by following commands:
antctl mc delete member-cluster test-member-cluster -n antrea-test

We can also use antctl mc delete to delete a ClusterSet. This command will delete all resources in the Cluster Set.
antctl mc delete clusterset <CLUSTER_SET_ID>

Options:
-n, --namesapce: namespace to deploy multi-cluster controller
--leader-cluster-config: path of the leader cluster kubeconfig file
--path-of-configs: path of member-cluster config file

Additional context
Maybe it is reasonable to run cmd on a cluster member to delete/deploy another member cluster via antctl. We can also delete a work node by kubectl delete node on other work nodes.

@hjiajing : thanks for the good writeup of the proposal. But I think it could me understand if you add each command is running in which cluster (leader and member), or say it talks to which cluster's apiserver.

According to @jianjuns Jianjun's comments, maybe it's not reasonable to connect two APIServers in one command. I have re-designed the command to deploy the member clusters. The deployment of member clusters could be divided into two steps. In the first step, the users can use the command antctl mc create to create an access-token or service account in the leader cluster,  which will be used by the next step.  Then the users can use antctl mc deploy member-cluster to deploy a member cluster in the cluster set. And the access-token or service account could be specified in the flag arguments. For example, a user may use the following command to deploy the member cluster.
$ antctl mc create access-token leader-token -n antctl-test
leader-token created.
$ antctl mc deploy member-cluster -n antctl-test --access-token leader-token --cluster-id test-member
Processing...
member-cluster test-member deployed.

Deploying a member-cluster in this way, the antctl will connect to one APIServer in one command. So the operations are more atomic. Once the operation is failed, it's easier to roll back.
In addition, I think the command antctl mc create could be extended, we may use the command to create more resources in the cluster set such as service export and others.

The new proposal sounds good to me. Let us implement cluster bootstrapping first, and then we can consider if need to support other functionalities.

The PR about this issue is #3474


Inputfield in Command Shell not active by default

The inputfield in Command Shell Module is not selected on Page load or submit. This way you always have to actively select the input field using tab or mouse.

Great point! Will add it by the next release!

It will be added in version 13.10 very soon. Thanks


paper1111: Watch 01-709-834-9700

paper1111 requests the watch of the watch_keyword 01-709-834-9700. See the Metasmoke search here and the Stack Exchange search here.

!!/approve


Addon not working with Vivaldi explorer

System Information:

Version: 2.6
Language: es
Timezone Offset: -05:00
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.94 Safari/537.36 Vivaldi/1.1.453.52

What steps will reproduce the problem?

Install addon at Vivaldi Browser latest version
Im already logged in at google account
It asks for login anyway and page stays blank. The same happens if I log out from google account and try to reinstall Calendar addon. I asks, of course, for login and again, page remains blank. What a waste of time dude!

What is the expected result?
To actually login and get the bloddy addon to work
What happens instead?
Page remains blank after asking for google credentials
Screenshot URL:
Logs:

What a waste of time dude!

True that — why would you even try installing a Chrome extension into a browser that only implements part of the Chrome Extensions API?
Turn on logging and see for yourself that Opera (and presumably Vivaldi) don’t support the Authentication API. And please go contact them if you want to see this working.
This extension is for Chrome and works well in Chrome. If you have issues in Chrome, report them here, otherwise it is indeed a waste of time for both of us.

Well, what a rude comment from your side.  Of course I will ask them to make something about it so we dont have to talk to rock star developers who mistreat regular users like me.

Umm, I cannot imagine that the person who wrote above:

What a waste of time dude!

and

To actually login and get the bloddy addon to work

is suggesting that I am the one being rude.

Your bug report did not contain any logs, as requested. If you did take the time to turn on logging, you’d see that Opera/Vivaldi already include a line stating that the Authentication API is not supported.
There are other closed issues that mention that this extension does not work in Opera, but you did not take the time to look over them before opening an existing one.

So it is indeed a waste of time for both of us. This discussion is not productive, so I’m going to close it down now.


supports meshopt and basisu decoders

This PR adds meshopt and basisu decoders support.
Meshopt is fully bundled from the THREE.js examples
Basisu is provided by the KTX2Loaderwith an additional assembly file, added to the asset folder.
Also added a shortcut to set draco and basisu decoders paths when setting a system asset path. I couldn't find a good CDN for the basisu assembly file so the support is a bit different from draco's default.
It adds some glue code to provide access to the renderer from ModelReader, but this is required to use WebGLRenderer.initTexture and WebGLRenderer.compileAsync, both of which are very important to reduce "blocking time" when loading models.
This is part of a larger effort to provide real time dynamic LOD management that might take a few months to make and for which a POC is available here (very much work-in-progress): https://github.com/Holusion/dpo-voyager/tree/seamless_load_proto

This is great, thanks! Excited to see the LOD support come together. That will be a nice feature. We've been planning KTX support for awhile (https://github.com/Smithsonian/dpo-voyager/tree/dev-ktx) but hasn't been prioritized due to not being a part of our content pipeline yet.

From my tests, it is a pain to encode (I use gltf-transform), the lack of support in blender (not even in progress) makes editing models a lot harder (especially since those are lossy encodings so we can't easily go back and forth).
However on the Voyager Side, support has been flawless and we have seen consistent loading time improvements with both methods and greatly improved memory usage and with GPU upload times with ktx2/basisu textures.
Any reason why this didn't get deployed?

model-viewer is using this gstatic endpoint for the basisu files: https://www.gstatic.com/basis-universal/versioned/2021-04-15-ba1c3e4

I'd rather not depend on google at all for keeping anything not search-related working long-term. Using the repo's local assets dir is fine for me but if you do really need to have a cloud-based fallback, I couldn't find anything that would be more reliable so I this one will have to do.

Looked at this a little more and I think we should have more consistency between the handling of the draco and basis libs.
How do you feel about: https://github.com/Smithsonian/dpo-voyager/tree/dev-meshopt-ktx
This doesn't use gstatic endpoints for draco or basis, but points to the CDN we are already using to deliver assets. I don't particularly like the conflation of bundled assets and libs, but it seems cleaner.
I understand your hesitancy to default to a CDN, but one of our goals is for end users to be able to include the component in their code without a dependency on hosting it themselves which has been a limitation in the past.
It can also easily be configured for local use (which we discuss in the docs: https://smithsonian.github.io/dpo-voyager/explorer/offline/) by just setting the resourcesRoot to './'. We could potentially even add some code to check the CDN and default to the local root if unavailable...

To be clear I'm not opposed to default to a CDN, I'm just wary of Google breaking things carelessly. They have a track record. Especially since the route is versioned, it might (or might not) return a 404 if they decide to upgrade the libraries for their model-viewer. We probably wouldn't get warning before this happens.
In the end I don't plan on using the default often, we pretty much always use the resourceRoot so I don't want to weigh in too much on this.
With that said, I like your proposition on https://github.com/Smithsonian/dpo-voyager/tree/dev-meshopt-ktx : it's more consistent than the original patch, easy to update and to replace if needed.

Understood. This has been merged via dev-meshopt-ktx and v0.43.0 release.


Document suggestion for cache invalidation

Since the PHP stack is out of reach, I don't see how cache invalidation works.
For example, to renew the generated start page of a content driven site every 10 minutes.
Please provide a suggestion how to handle that.
Thanks in advance.

I don't see that either, but you could schedule the artisan command for the specific slug.
One could also use this to create an observer that clears the specific cache entry when saving a model. I have not used his package for now, but the availability of this command suggests that there also is a call that can be made without using the scheduling functionality. It would be nice if that would be documented, though.

I added the something like this sto an observer:
$cache = app()->make(Cache::class);
$cache->clear($slug);
$cache->forget($slug);

I was thinking about how to do this as well. However, in my case we have more than 1 web server in a serverless context, so cache invalidation needs to be propagated across all of them.


Connecting database to react

In this commit I have created separate files for the two queries that are happening so far, deleted the original queries.js file.
Then changed around to have the category tabs to be populated via data base. Prettier was run in all files that were edited.

There are a lot of errors in the console on the Home page loading


Update geo-point.md

Feedback received 12/22/23
Description
Feedback: PUT testindex1/_doc/1be inside ""
{
"point": {
"lat": 40.71,
"lon": 74.00
}
}
The values need to be inside " "
Issues Resolved
n/a
Checklist

[x] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

These don't need to be in quotation marks.

Thank you! I'll close the PR.


Bump app build number to 465

Summary

Weekly beta release (build: 465)
Release Note

/release-note-none

/release-note-none

/cherry-pick release-2.3

Cherry pick is scheduled.


feat: Visualize SqlLab.Query model data in Explore 📈

SUMMARY

Explore view now can accept datasource_type = 'query, which represents sql_lab.Query model. Now users will be able to easily chart data from queries being executed in SQL Lab
https://user-images.githubusercontent.com/27827808/173101938-4c31864d-0c0b-4fb1-aa5a-6bfdb25123bc.mov
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Go to Sqllab and run a query
Click Create Chart
Verify that Chart Source is Query with the SQL icon

***OR

Go to Sqllab and run a query
Then run a select id from query
Take one valid id from results returned
Enter the following string into the browser {ephemeral-url}/superset/explore/query/{id}

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

/testenv up

/testenv up

/testenv up

/testenv up

/testenv up

/testenv up

/testenv up

/testenv up

/testenv up

@hughhhh @hughhhh have we really done testing? The explore page of master branch seems doesn't work at all.
https://user-images.githubusercontent.com/2016594/179336747-ce3fa9e7-6e43-489c-a74d-0d1868ce228c.mov

@zhaoyongjie I have fixes out for these 2 bugs
https://github.com/apache/superset/pull/20747
https://github.com/apache/superset/pull/20751


Sharing knowledge or experience

I apologize that I'm writing an off-topic message here. But I don't know how else I could get in touch with other developers who are experimenting with Brochard.
Although I'm not an expert on Orchard, but I'm familiar with it and have built an order management module and some other small modules with it for a customer of mine.
I would love to get in touch with others how are interested in Brochard too and want to share knowledge and give the core developers (Nick at this moment) feedback. Hopefully we would be able to give hem a helping hand in the future.
If you want to get in touch with other developers, please do not hesitate to write a message here or make your contact info public or leave your e-mail address to make it possible for the rest of us to contact you without polluting the 'issues' section of github.
If anyone has a better idea, please do not hesitate to share it here. It would be nice to find a better way to communicate with each other.
Dave

I love feedback :+1:

Hi Dave,
I just made my e-mail address public. So feel free to contact me anytime you want.

What about a gitter for the brochard repo? why not? I'm not helpful atm but I like reading all the conversations and sometimes catch important information.

You asked for it: https://gitter.im/OrchardCMS/Brochard

Gitter has been created and is active.


K8s operator POC

Depends on the following PRs:

https://github.com/SwissDataScienceCenter/renku-gateway/pull/429
https://github.com/SwissDataScienceCenter/renku/pull/2142

if it's approved it's no longer a PoC 😆

You can access the deployment of this PR at https://renku-ci-nb-668.dev.renku.ch


[FEATURE REQ] Data Lake: Please stop Flush from being executed twice when writing a stream

Library or service name.
Azure.Storage.Files.DataLake v12.5.0
Is your feature request related to a problem? Please describe.
If you execute a write operation using a common stream like the following sample code, the same two flushes to the Storage API will be executed.
Since I am writing large amounts of data to multiple storage accounts, the overhead and error rate of this redundant flush is becoming too much to ignore.
class Program
{
    static async Task Main(string[] args)
    {
        var connectionString = "DefaultEndpointsProtocol=https;AccountName=***;AccountKey=***;EndpointSuffix=core.windows.net";

        var dataLakeServiceClient = new DataLakeServiceClient(connectionString);

        var fileSystemClient = dataLakeServiceClient.GetFileSystemClient("sampledata");

        await fileSystemClient.CreateIfNotExistsAsync();

        var fileClient = fileSystemClient.GetFileClient("sample.txt");

        // Write blob using stream
        using (var stream = await fileClient.OpenWriteAsync(false))
        using (var writer = new StreamWriter(stream))
        {
            await writer.WriteLineAsync(DateTime.Now.ToString());
        }
    }
}

Workaround
It seems that Flush is called every time Dispose is executed, so you can minimize the number of times Flush is executed by writing tricky code like the following, but I feel this is not the right way to write it.
// Remove using
var stream = await fileClient.OpenWriteAsync(false);

// Adding `leaveOpen` flag
using (var writer = new StreamWriter(stream, leaveOpen: true))
{
    await writer.WriteLineAsync(DateTime.Now.ToString());
}

Thank you for your feedback.  Tagging and routing to the team best able to assist.

Thank you for your feedback.  Tagging and routing to the team best able to assist.

Since the flush process is also subject to write transaction billing, there is a concern that unnecessary billing may have been unintentionally incurred when using the Write stream.

Since the flush process is also subject to write transaction billing, there is a concern that unnecessary billing may have been unintentionally incurred when using the Write stream.

I agree the workaround does not seem to be the best option, but I wonder if doing that would dispose the stream anyways when the stream you get from OpenWrite disposes.
This might be the way how creating CsvWriter streams and StreamWriter work where it disposes after being used, because you're essentially having the same stream just different Writers pointing to it.
@seanmcc-msft Do you have a recommendation to prevent multiple Flush calls (Dispose being called on the stream multiple times).

Although there may be some consistency issues, ideally, if the position has not changed since the last flush, the next flush should be skipped. In buffered writers, if there is nothing to flush, flushing will not be done.
I can still compromise if flush does not incur any charges, but it is difficult because it is actually charged.

Unfortunately, with the current ADLS Gen 2 SDK, this issue doubles the cost of Flush API calls in a typical scenario, which has caused some of my customers to consider moving away from Azure.

Hi @shibayan, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.


Testing on Windows

I've found some problems when trying to npm test on Windows.
First, npm run lint tries to lint package.json files, which obviously throws. The solution would be changing the script to: "lint": "eslint <%= srcDir %>/**/*.js" on https://github.com/diegohaz/generator-rest/blob/master/generators/app/templates/_package.json#L14
Another problem is the test script itself. It has a condition written in shell script and Windows doesn't recognize it. I'm looking for a cross-platform conditional statement solution, but found nothing yet.

I think https://github.com/diegohaz/generator-rest/commit/d69c0571b7eb37a1b0266c30d846b90eb67d0cee has fixed this, but I'm having trouble to set up Windows environment to make sure it works.

Managed to finally install bcrypt without errors and am running npm test.
Seems like as the tests run concurrently powershell isn't showing any helpful output. I will report back once the test fails or completes.

@diegohaz The test finished with an error.. :sob: Apparantly it was creating so many copies of the folder to test that it used a few GBs of space.

It happens because it copies the node_modules folder on each test suite. I will change it to create symlinks instead. It will also run faster.


Register buffer

Hello maybe i do something wrong or it is a bug.
I try to save a Tensor in a Model. The  this.register_buffer("Y0", Y0); in the constructor. I change the Tensor later.
It somehow does not store the Tensor in may Model.
Thanks in advance.
Michael

@Sprinzl -- how, specifically, do you change the tensor? If you construct a new Tensor, that new Tensor wouldn't be registered, so that's expected.
If you use an in-place operation, such as copy_() to overwrite the contents of the existing Tensor, and observe this behavior, then that's a bug.

@Sprinzl
Thank you for having an interest in learning Torchsharp. Welcome from Germany! I assume from your Github profile.
To help us understand how best to support you, attaching a simple example e.g. torchsharpTest.zip will help us understand your questions faster.

Repro cases are often useful, but in this case, it should not be necessary to attach a ZIP file.

Ok _copy does the trick.  I am   woundering how to handle a different shape...
                    var iy = 1.0 / ix;
                    pot = (pot * iy) + (Pot * (1.0 - iy));
                    this.Pot = Pot.copy_(pot); //Registered Buffer
                    this.PotCumulative = PotCumulative.copy_( pot.cumsum(1)); //Registered Buffer
                    this.Save();

Thank you Niklas.


Request-scoped transactions with async SQLAlchemy

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the FastAPI documentation, with the integrated search.
[X] I already searched in Google "How to X in FastAPI" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to FastAPI but to Pydantic.
[X] I already checked if it is not related to FastAPI but to Swagger UI.
[X] I already checked if it is not related to FastAPI but to ReDoc.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
#
# From the tutorial for synchronous db use
#

# Dependency
def get_db():
    db = SessionLocal()
    try:
        yield db
    finally:
        db.close()

@app.post("/users/", response_model=schemas.User)
def create_user(user: schemas.UserCreate, db: Session = Depends(get_db)):
    db_user = crud.get_user_by_email(db, email=user.email)
    if db_user:
        raise HTTPException(status_code=400, detail="Email already registered")
    return crud.create_user(db=db, user=user)

#
# From the tutorial for async use ... transactions?
#

@app.post("/notes/", response_model=Note)
async def create_note(note: NoteIn):
    query = notes.insert().values(text=note.text, completed=note.completed)
    last_record_id = await database.execute(query)
    return {**note.dict(), "id": last_record_id}

Description
This is really a question about the FastAPI documentation. I realise it's not the place to ask questions about SQLAlchemy. It boils down to whether there's a reason for the apparent difference w.rt. transactions in the sync and async database tutorials included in the documentation. I've also asked this question on stackoverflow, reproduced below:
I'm confused about transactions with FastAPI and async SQLAlchemy (i.e. version 1.4+). The FastAPI tutorial for SQL databases uses request-scoped transactions created via a FastAPI dependency. This is what I'd expect.
But then the documentation has another tutorial for async SQL databases in which I can't see any sign of transactions. It does use a PyPi dependency called databases which provides "simple asyncio support for a range of databases". I don't know if it does transactions internally but I don't see how they could be request-scoped without help from the calling application.
And then again I see a blog article about FastAPI and async SQLAlchemy which appears to do things the original way with request-scoped transactions and FastAPI dependencies. Which is the "correct" approach? Does it matter if one is using Core or ORM mode or is that no longer a thing in SQLAlchemy 1.4?
Operating System
Linux
Operating System Details
No response
FastAPI Version
Latest
Python Version
3.10
Additional Context
No response

I experimented with this and came up with the following. It's extremely simple in the final analysis. If you look at the blog example I linked, you find the following FastAPI dependency:
# Dependency
async def get_session() -> AsyncSession:
    async with async_session() as session:
        yield session

The example then manages transactions explicitly in FastAPI path operations:
@app.post("/cities/")
async def add_city(city: CitySchema, session: AsyncSession = Depends(get_session)):
    city = service.add_city(session, city.name, city.population)
    try:
        await session.commit()
        return city
    except IntegrityError as ex:
        await session.rollback()
        raise DuplicatedEntryError("The city is already stored")

This is a little dangerous. If service.add_city does anything that could throw an exception, the try block will never be entered. As it happens, if any work has been done on the AsyncSession object, the context manager invoked in the dependency operation (async with async_session() ...) has your back. It will rollback the transaction.
All of this is actually unnecessary. If you want automatic handling of request-scoped transactions, just add a single line to the end of the dependency function:
# Dependency
async def get_session() -> AsyncSession:
    async with async_session() as session:
        yield session
        await session.commit()

This single addition means you don't have to (and shouldn't) handle transactions anywhere else in your own code. After yielding the session, a transaction will be implicitly started whenever needed. If a path operation which uses the dependency completes successfully, the commit() executes which flushes any session work to the database and commits it. If an exception occurs, the context manager looks after rolling back any open transaction.
One point of information: if you enable echoing of your SQL statements (echo=True parameter to create_async_engine), you can see transaction commits and rollbacks. You may not always see a rollback occurring on exceptions.  For instance, if you've done a session.add but this has not been flushed, no rollback is needed. The session is simply discarded.

Ok to close to question.

Here is another neat trick, thanks to FastAPIs dependency injection, which manages to inject dependencies for callables, even when you override __new__.
Instead of:
# Dependency
async def get_session() -> AsyncSession:
    async with async_session() as session:
        yield session
        await session.commit()

@app.post("/cities/")
async def add_city(city: CitySchema, session: AsyncSession = Depends(get_session)):
    city = service.add_city(session, city.name, city.population)

How about making our own session subclass:
# Dependency
async def get_session() -> AsyncSession:
    async with async_session() as session:
        yield session
        await session.commit()

class DB(AsyncSession):
    def __new__(cls,db:AsyncSession = Depends(get_session)):
        return db

@app.post("/cities/")
async def add_city(city: CitySchema, db: DB = Depends()):
    city = service.add_city(db, city.name, city.population)

Just mention your session subclass as a dependency when you need it and FastAPI looks after the rest without even needing parameters.


Config is not loaded by default

As part of #4848, I was expecting the default config to be loaded all the time. But it seems this is not the case. The apps call OPENSSL_init_ssl() with OPENSSL_INIT_LOAD_CONFIG (which isn't documented), it's documented for OPENSSL_init_crypto(). There it's documented that it's not the default. Why is this not the default? Just for backwards compatibility?

It is documented for OPENSSL_init_ssl():
The B<opts> parameter specifies which aspects of libssl and libcrypto should be
initialised. Valid options for libcrypto are described on the
L<OPENSSL_init_crypto(3)> page. In addition to any libcrypto
specific option the following libssl options can also be used:

So all OPENSSL_init_crypto() options also apply to OPENSSL_init_ssl().
I believe it isn't the default for backwards compatibility. Co-incidentally I made it the default for libssl as part of #5818 (although I hadn't thought about the backwards compatibility concern). But #4848 does imply that we should be doing it by default anyway.

Note, unless I am mistaken, the environment variable OPENSSL_CONF can be used to change the
system configuration to pretty much anything, including code-execution in every application that does
not opt-out.

Note, unless I am mistaken, the environment variable OPENSSL_CONF can be used to change the
system configuration to pretty much anything, including code-execution in every application that does
not opt-out.

Only if an application actually loads config.

Only if an application actually loads config.

Yes, but that is what will happen automatically in future.
I wonder if that environment lookup should be configurable.

Yes, but that is what will happen automatically in future.
I wonder if that environment lookup should be configurable.

It doesn't automatically happen at the moment. If #5818 gets merged then it will.

(at least it will for libssl applications).

This should be fixed now.


Excluding Trace Methods

Is your feature request related to a problem? Please describe.
When instrumenting code with the trace_methods property there is no way of excluding a class/method, even though it may just be a single class that you're trying to exclude from a directory that has a large amount of other classes.
Describe the solution you'd like
I am suggesting an option to exclude specific classes from being instrumented even if the class exists in a location where trace_methods is being implemented. The syntax could be: trace_methods=com.example.*, -com.example.foo.*.
Describe alternatives you've considered
An alternate solution for this would be to list each class individually that you want instrumented in the trace_method property, which isn't feasible for larger projects, it's better to list what you don't want instrumented instead of listing what you do want.

In our company we would also be interested in this feature. I would also submit a PR but would like to get some feedback on the following implementation ideas:

Specify classes to include and exclude in the trace_methods parameter, using "+" prefix or no prefix for includes and "-" for excludes (original proposal).
Use two separate parameter for includes and excludes, similar to profiling_inferred_spans_included_classes and profiling_inferred_spans_excluded_classes.

In order to keep consistency I would have preference for option 2 but open for any ideas, proposals. Please let me know if you would be interested in a contribution for this issue.

Out of curiosity: what’s your use case for trace_methods now that there are profiler inferred spans?
Both approaches sound fine to me, I don’t have a strong preference.

According to the documentation profiler inferred spans are experimental and they have a trade off between accuracy and performance. So I was wondering if the feature is mature enough for a large scale production usage and hence was looking into extending the existing feature. Do you have any insides if and when profiler inferred span become stable and if they would replace the existing stable feature?

Great question.
Inferred spans are not experimental because we think they may cause stability issues with the application. It's built on the widely used profiler async-profiler which does the heavy lifting of efficiently collecting stack traces.
The main reasons for it being experimental are:

We want to be able to change configuration options and their defaults (for example, we did a major change in 1.15.0).
There are some issues with parent/child relationships which we want to fix before declaring it a generally available feature: https://github.com/elastic/apm/issues/247
The impact is basically that some spans are displayed out-of-order in the UI.
We're working on better documentation for the feature.

If you are fine which those caveats, please give it a try and we'd be happy to get your feedback.
But we also don't plan to remove trace_methods.

Thanks for sharing the insides. We will give it a try and will let you know about our experiences.

Hi @ethranes and @christiangalsterer , this issue has been open for a while and I was wondering if you managed to use inferred spans for your use-cases and had any feedback about it. Right now this issue isn't really actionable as-is, thus we are quite likely to close it without further updates.
Also, async-profiler that is used by the agent has been updated in latest (1.19.0) version of the agent, thus in case you had any stability issues with it, it might be better now.

This issue hasn't been updated in a while, thus we'll close it for now.
The way to find slow/relevant methods is now properly documented here.
Also, ff you have time to provide feedback, can you describe your use-case for using trace_methods in the first place here ?

instrument a library/framework that is not currently natively supported through auto-instrumentation
instrument a part of your application that needs to be monitored with dedicated spans/transactions: for example, custom batch execution, or internal delegation to a sub-component of the application.
something else


Update ERC-5564: update schemeID

Update the scheme ID for the SECP256k1 implementation from 0 to 1.
Add content to the implementation section

hey @Pandapip1!
What's wrong here, why isn't the PR merged automatically?
Is the reviewing bot down?


update tests to extend UnitTest

I've got no problem with updating each of these to extend UnitTest, but I thought (think?) we've only seen impact to other tests if the "non-UnitTest" test classes invoke code that leverages ConfigUtil.  Is that not the case?

I've got no problem with updating each of these to extend UnitTest, but I thought (think?) we've only seen impact to other tests if the "non-UnitTest" test classes invoke code that leverages ConfigUtil. Is that not the case?

Yep, that is true. I felt that I was in here anyways and should just have the tests extend UnitTest, hopefully, to future-proof it.


Implement Docker image CI

Partially addressed and available here: https://quay.io/repository/clastix/capsule-proxy
Definitely, we have to rename this issue and provide e2e testing, also to check if the source code is compiling properly.

Partially addressed and available here: https://quay.io/repository/clastix/capsule-proxy
Definitely, we have to rename this issue and provide e2e testing, also to check if the source code is compiling properly.

Workflows implemented:

[x] e2e
[x] helm life-cycle
[ ] linters

Said so, #63 is a prerequisite to consider this as closed.


Curl mode

I'm wondering if there's a way to do a straight CURL request in Httpie. This would be very useful with long curl requests that I would like to see the pretty output from.
Even just a way to pipe curl -> httpie would be cool
Any ideas?

httpie is not (just) a formatter; it is (also) an HTTP client. If you want the pretty output (sans colorization) you can use python -m json.tool or jq.

Thanks I'll look into those!

Closing since the following works fine for my use case:
curl CURL_FROM_FIREFOX | python -m json.tool


'Issue' folder

Hi,
Is there a possibility to add the 'Issue' folder ?
Thanks

Hello @apmascalabs
Could you explain your feature. As it seems now it would not fit the GitList philosophy of being just a git viewer. Perhaps there is something I missed that needs some clarification.

Hi @DannyvdSluijs,
Do not misunderstand me, I do not want to change the philosophy of the project, but it seemed to me to be a good way to create a 'communication channel' among the users of the same repo.
The 'issues' could be created as the 'commits', remaining only visible on the repo.
Do you think it's a wrong way to see the project?
thank you

Hi @apmascalabs,
I guess this feature would oppose the philosophy of the project when thought of it as being a part of GitList's core but there's a discussion going on in #739 about how to make Gitlist extensible. As far as I've understood @klaussilveira, he's in favor of keeping the core rather basic and put any additional features into plugins. However, there is no plugin architecture in place at this point other than the architecture provided by the underlying framework Silex and Composer, which is fine in my opinion. There's also a pretty active GitList fork by @p3x-robot. You could ask the author about his views on this feature request. Lastly, @alehaa maintains a fork, too, which has been outlined to be a group effort to ensure the future development of GitList but right now seems to be maintained only by himself.
I hope this info may help you!
Cheers
P.S. other forks exist

Ok, thanks for your answer, reading the #739 discussion I have understand the 'issues'. I will check some forks.
Thanks @netbrothers-tr

@netbrothers-tr our fork is dead, as contribution will take place in this repo again. See gitlist-php/gitlist#42.

Thanks @alehaa for the info! Pleased to hear!


[BUG]

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
Everytime i open bloxstrap in full screen and then close it, it freezes.(Apps can still run in the background, and the win(Windows) button doesn't work) This is not a bug i find in the roblox you install on the website. Does anyone have a solution?

What's your rendering mode set as?

when i put my commend like:"the old backround avatar creator" it doesnt woork when  i press changes bc when i start "play roblox"noothing changes

Issue has been awaiting clarification for over a month, closing as stale. If you have anything further to add, just respond and I'll reopen.


Cleanup url_*_get/set functions

An alternative to #8170. Instead of removing unused free functions, this converts the free functions to methods of URLImpl class and call those from URL class.
This also changes names of type_get/set to type_code_get/set, because there are "type" and "type code" in URLImpl and type_get/set were used for "type code". And I redefined type_get/set for "type".
I could add a constructor and make other functions to methods as well, and member variables of URLImpl should be private, but I didn't make those changes for now because this is enough to save the unused functions.

@shinrich can you please take a look at this.


merge branch kistler-v1

Codecov Report

Merging #312 (99d2597) into main (d063dc0) will increase coverage by 0.16%.
The diff coverage is 44.44%.

:exclamation: Current head 99d2597 differs from pull request most recent head 25552e4. Consider uploading reports for the commit 25552e4 to get more accurate results

@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
+ Coverage   66.92%   67.08%   +0.16%
==========================================
  Files          68       68
  Lines        4018     4023       +5
==========================================
+ Hits         2689     2699      +10
+ Misses        951      948       -3
+ Partials      378      376       -2

Impacted Files
Coverage Δ

client/core/ownDevice.go
65.12% <0.00%> (ø)

client/core/getDevice.go
64.28% <33.33%> (+3.79%)
:arrow_up:

client/core/device.go
80.10% <75.00%> (-1.91%)
:arrow_down:

pkg/net/coap/client.go
72.59% <0.00%> (+0.74%)
:arrow_up:

client/core/getResource.go
40.90% <0.00%> (+9.09%)
:arrow_up:

client/core/maintenance.go
70.37% <0.00%> (+11.11%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


PLEASE HELP ME GET TIBIALYZER WORKING

I dont know if tibialyzer is working or not.... been trying 4 hours...... i launch it and everything looks good the hud works but nothing else does summary doesnt work at all is it frozen or something i tried all the releases none work this is so anoying i just wanto use tibialyzer... i doesnt detect my character i think itt doesnt show exp gained it doesnt show the runes i use or gold or items the creature is looting what the hell im getting tired of getting it to work

ohh ok nevermind i see now it cuase of battleye well good luck getting the program working again sucks i didnt have a chance to try it :) i will atleast make use of the HUD making it easier to spot my hp and mana xD


Evaluate lua-resty-openidc as APIMan replacement

Similar to #3, let's also evaluate lua-resty-openidc, which is an Nginx-based library for OpenID Connect integration.  It does not have the same adoption (it's newer) as mod_auth_openidc, but is being developed by some of the same folks.  Also, since we're already using Nginx, this may be a cleaner solution.

We've decided to go the mod_auth_openidc route as it seems like a more mature project at this point.


Sample of config file

Do you have a sample of your config file ?
All scripts have "freq" option hard coded ?
I have an error with "freq": "1h" but no idea oh problem trying to debug df
lightgbm.basic.LightGBMError: Check failed: (num_data) > (0) at /Users/runner/work/1/s/python-package/compile/src/io/dataset.cpp, line 33
Can we have a bit more documentation ?
Thx

> All scripts have "freq" option hard coded ?
> I have an error with "freq": "1h" but no idea oh problem trying to debug df
Yes, most of the scripts assume 1m frequency. I have never tried other (lower) frequencies (although it might be useful for more general scenarios).
> Can we have a bit more documentation ?
Which script or step does not work for you and where it fails? Then I could add more details on the implicit assumptions and usage.
Here is the config.json I am using for all steps (except for trading):
{
  "api_key": "my_key",
  "api_secret": "my_secret",

  "telegram_bot_token": "source_id",
  "telegram_chat_id": "destination_id",

  "symbol": "BTCUSDT",
  "base_asset": "BTC",
  "quote_asset": "USDT",

  "data_folder": "C:/DATA2/BITCOIN/GENERATED/BTCUSDT",
  "model_folder": "C:/DATA2/BITCOIN/MODELS/BTCUSDT"
}

Thank you for this add in documentation and your reply ;)
I used in configuration variable the keys collector.depth.freq for playing with frequency in scripts replacing the line
freq = App.config["collector"]["depth"]["freq"]

to
freq = App.config["collector"]["depth"]["freq"]

Also added package "tqdm" in requirements.txt - library required in download, merge and depth scripts
For LightGBMError it was my fault i don't installed this package and i have switched between linux & mac.
Try to discover more ;)
Thx


How to delete messages on Gmail (SMS label) and mirroring the clean on the phone ?

Hello,
I have a little question:
If I delete messages SMS on my phone and then I restore all messages with SMS Backup+: all is restored, including the deleted message: ok (https://github.com/jberkel/sms-backup-plus/issues/4)
But today I tried to delete messages on my Gmail backup, and then I did a restore: I hoped I would have the "cleaned" version of my messages but the deleted messages are always here on the phone after restoration completed.
I think it is because the SMS phone database hasn't been deleted before the restoration? Am I right?
If yes, should I delete it manually (if possible), before the restoration, or do you have any other recommendations?
What I would like is to clean my message by deleting which I don't want anymore. I found doing the cleaning on Gmail (or Thunderbird), easier, but is it possible?
Thanks :)
Expected behaviour
Delete messages on Gmail (SMS label) and mirroring the clean on the phone
Actual behaviour
Delete messages on Gmail (SMS label) are always present on the phone after a SMS Backup+ restoration.
Steps to reproduce the behaviour
Delete message on Gmail on the SMS label.
Start a restoration on SMS Backup+.
Please specify the following:

Android version 10
Phone model / brand Moto G7 Plus Motorola
SMS Backup+ version installed 1.6.0-BETA2
Messaging app Android Messages

Have you taken into account that when you delete a message in Gmail it isn't actually deleted immediately? Instead, Gmail adds a Bin label to the message which has the effect of hiding it from your inbox. Messages retain any other labels, including the SMS label. Messages labelled Bin are permanently deleted at some later date, determined by your account settings I think. I doubt SMS Backup excludes messages that have the Bin label when performing a restore.

Hi,
Thanks for your reply, it's a good tip, but it seems that as I thought, by deleting the SMS database on my phone (done with SMS Backup & Restore: tools), I do not have my deleted SMS displayed anymore :).
Bye


[KOGITO-3296] - Upgrading Infinispan CRD and fixing custom credential…

…s bug
See: https://issues.redhat.com/browse/KOGITO-3296
In this PR we upgrade the Infinispan CRDs, so now users can use the 2.x channel from the OLM installation. Also, the generated secret from Infinispan is now attached to our secret, which will be injected into the KogitoService.
I made a clean up in the KogitoInfra controller package, which will help KOGITO-3039 as well.
@r00ta please review your reproducer, the identities.yaml file had the wrong name. To add a custom credential to a KogitoService, you only have to create a custom Infinispan credential secret, add it to the Infinispan CR and make your KogitoService to use the infra provided by us. If you would create your own Infinispan CR, just add the custom credentials there the same way you did, create a new secret for the KogitoService with the same credentials but with different format and add everything manually to the KogitoService. Is not the ideal, but KOGITO-3039 will fix that. You would create your own Infinispan and tell the Kogito Operator that you would like to use that reference, every thing will be done for you.
cc @vaibhavjainwiz
@sutaakar I didn't make great changes in this PR, I think would be a nice addition to 0.15 so people won't have problems with the Infinispan CRD any more.
Signed-off-by: Ricardo Zanini<EMAIL_ADDRESS>Many thanks for submiting your Pull Request :heart:!
Please make sure that your PR meets the following requirements:

[x] You have read the contributors' guide
[x] Pull Request title is properly formatted: [KOGITO-XYZ] Subject
[x] Pull Request contains link to the JIRA issue
[x] Pull Request contains description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket
[x] Your feature/bug fix has a unit test that verifies it
[x] You've tested the new feature/bug fix in an actual OpenShift cluster

/jenkins test

@sutaakar do you mind verifying this manually as well? :(

sure, will try

@ricardozanini Checked using external credentials and generated credentials for both Infinispan operator 1.1.x and 2.0.x - both works ok (for Infinispan 2.0.x the Data index crash as it is not yet compatible, which is expected). Credentials are passed from Infinispan secret to Kogito one.

MANY THANKS for this super verification, @sutaakar . I'm pushing @vaibhavjainwiz suggestions, and as soon as we merge #558 I think we can run this CI again.

/jenkins test

Keycloak only failure, merging.


AttributeError in gIV Notebook help wanted

The notebook can't run this line：
Load the raw dataset
h5_path = px.io_utils.uiGetFile('*.h5', 'G-mode IV dataset')
AttributeError: 'module' object has no attribute 'uiGetFile'
Is it possible to use usid instead of px? But Conda install pyUSID seems not working, the message is
PackagesNotFoundError: The following packages are not available from current channels
So how to solve it?

When you pip install pycroscopy it should also automatically install pyUSID. The gIV notebook has not been updated since the latest changes were made to px. Anyhow, if you try
import pyUSID as usid
h5_path = usid.io_utils.file_dialog(file_filter='Translated file (*.h5)')) this should work.
See the BE processing notebook https://github.com/pycroscopy/pycroscopy/blob/master/jupyter_notebooks/BE_Processing.ipynb for more details.

@cuu123 I updated the notebook. Please check out the notebook again.

Also please consider joining the pycroscopy slack group to interact with the user community. https://pycroscopy.slack.com


[UI] : Show Profile Picture

Is your feature request related to a problem? Please describe.
A profile picture should be shown in the account icon in the bottom navigation bar if the current user's profile photo is not null. ( FirebaseAuth.instance.currentUser?.photoURL )
(Ex : When user signs in with google)

Please assign this issue to me under jwoc

Any update ?

@Abhigyan103 pls assign this issue to me under jwoc

update ?


Update info..

Hey.
Is there going to be any updates on this soon?
I'm realy waiting for the FILE BROWSER

Hi @ExtremeCopycat
Which task are you referring?
and it would be better to keep questions on gitter 😬

I dident know about gitter, sorry for that.
And i have all the files on the same server as the streama server. So i was wondering when the file browser would get out. If i use the system as it is now i would end up with double of all tne files

This issue can be related to this one
I think that your problem can be solved by using Local Video Files field in admin settings

If you already have a directory with your videos, put it here and you will be able to choose them when creating movies or TV shows.

i added the directory to my local files to "Second Directory".
I dident understand exactly how to make this work. is there any way to get some help with this?
Do i need to do something special with the folder i have my movies in. Rigt now i have the top folder called "MOVIES" and under it i have a folder for each movie. In that folder i have the movie file and subtitles and some text files.
Any help is appreciated

And should i run v0.3.2 or v1.0.6?

Use the new one - v1.0.6.
I will close this issue as file browser for two directories are is already implemented


chore(main): release 0.2.0

:robot: I have created a release beep boop
0.2.0 (2024-09-20)
Features

providers: add support for multi-providers (#8) (b563a1c)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v0.2.0
:sunflower:


Why health check an http endpoint rather than backend service's own TCP endpoint?

At Marco's suggestion, I'm looking at switchboard for a different service backend than cf-mysql-release
I see the health check system is hard coded to test for an http endpoint - which I assume is different from the service TCP endpoint - but why?
What is wrong with the idea of health checking the backend service's active TCP connection?
Or how do you recommend that arbitrary backend services co-publish additional HTTP endpoints just for health checking? Is there an agent process that you are using that we can borrow?
I don't really want backend services to have to run an additional agent - it makes process monitoring hard inside docker containers for example - so I'm a little torn about this requirement for an additonal HTTP endpoint for health checking.

Hi @drnic,
At the time we designed switchboard, I think the idea of a sidecar 12 seemed like a good way to go.
TCP connection checking can be prone to false-positives, in that once an application has called bind(2) and listen(2), the OS is going to accept and queue connections even if the application itself isn't accept(2)'ing connections. Up to a point.
Ideally you'd want to write something more advanced, that actually knew to talk to the application to determine if the service is really alert and responsive. There are two places to implement that: as a plug-in to the load-balancer (switchboard) or, in the form of a sidecar.
Docker containers are a whole different ball of wax. For containers, Diego is much more flexible, allowing TCP checks, HTTP checks, and even embedded health command calls lattice docs. That's definitely a different ball of wax than the context switchboard was written in - collocating a sidecar in a BOSH deployment isn't a big deal.
We could certainly entertain the idea of adding TCP checks to switchboard, again, presuming compelling use cases. :)
--
Marco Nicosia
Product Manager
Pivotal Software, Inc.

The main reason we check for a separate HTTP endpoint rather than the TCP port of the service itself is to allow for cases where health (and hence routability) is more complicated than whether a process listens on a port.
Giving this proxy was to be used in front of a mysql cluster, this lead us to one of two options: either hard-code mysql-specific knowledge in this application, or require an external process to provide application-aware health status. We opted for the latter, as it offers more extensibility and flexibility.
It shouldn't be too hard to add a flag and some extra logic to force the healthcheck to look at the TCP port instead of an HTTP endpoint.

Hey @drnic,
I'm going to go ahead and close this issue. As always, feel free to re-open any time.
--
Marco Nicosia
Product Manager
Pivotal Software, Inc.


AssignmentPollVoteDetailCtrl + View + Template

Take care about it.. I currently do not know what it's for.

TODO: Implement the "Einzelstimmennachweis" for assignments. I just copy and pasted the template and controller from openslides-votecollector. This needs a rework. You can orientate yourself at the motion poll detail view.

Done with #75 #82 #87


many files are created at wrong place when creating a project using ng new with -sd

Versions
Angular CLI: 1.5.3
Node: 8.9.1
OS: linux x64

Repro steps

ng new --prefix core --routing -sc -sd src/core --style scss -v prj-web
ng build

Observed behavior
The project will be created apparently ok.
The .angular-cli.json file will contain an app which "root" will point to "src/core" folder. But the created files (tsconfig.app.json, main.ts, etc) on this app declaration won't be found since they were created at /src folder.
Error: ENOENT: no such file or directory, stat '/home/black/Development/prj-web/src/core/tsconfig.app.json'
    at Object.fs.statSync (fs.js:948:11)

Desired behavior
Seems that app files should be in the same source directory pointed by -sr parameter in order to build ok.

Thanks for reporting this issue. However, this issue is appears to be a duplicate of an existing issue #8461. Please subscribe to that issue for future updates.


[Improvement] Introduce code formatting for *.g4 Antlr4 grammar files

Why are the changes needed?

introduce code formatting for Antlr4 files (eg. for KyuubiSql grammar) using antlr4Formatter from spotless-maven-plugin (doc: https://github.com/diffplug/spotless/tree/main/plugin-maven#antlr4)

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

Codecov Report

Merging #4188 (d730c2a) into master (246be77) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4188      +/-   ##
============================================
- Coverage     53.01%   52.95%   -0.06%
  Complexity       13       13
============================================
  Files           548      548
  Lines         29946    29946
  Branches       4025     4025
============================================
- Hits          15876    15859      -17
- Misses        12594    12607      +13
- Partials       1476     1480       +4

Impacted Files
Coverage Δ

...e/kyuubi/jdbc/hive/ClosedOrCancelledException.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../kyuubi/server/mysql/constant/MySQLErrorCode.scala
13.84% <0.00%> (-6.16%)
:arrow_down:

...ache/kyuubi/server/mysql/MySQLCommandHandler.scala
77.77% <0.00%> (-4.05%)
:arrow_down:

...apache/kyuubi/engine/JpsApplicationOperation.scala
77.41% <0.00%> (-3.23%)
:arrow_down:

...g/apache/kyuubi/operation/BatchJobSubmission.scala
74.28% <0.00%> (-2.29%)
:arrow_down:

...ache/kyuubi/server/mysql/MySQLGenericPackets.scala
76.59% <0.00%> (-2.13%)
:arrow_down:

...rg/apache/kyuubi/ctl/cmd/log/LogBatchCommand.scala
59.09% <0.00%> (-1.52%)
:arrow_down:

...ain/scala/org/apache/kyuubi/engine/EngineRef.scala
74.60% <0.00%> (-0.80%)
:arrow_down:

...in/scala/org/apache/kyuubi/config/KyuubiConf.scala
97.35% <0.00%> (-0.07%)
:arrow_down:

...org/apache/kyuubi/operation/ExecuteStatement.scala
77.92% <0.00%> (ø)

... and 1 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

To be honest, I do not like this new style. Here are my thoughts:

the new style just use more blank line which make it un-readable
the end on line #xxx is not aligned
the current style follows Spark

To be honest, I do not like this new style. Here are my thoughts:

the new style just use more blank line which make it un-readable
the end on line #xxx is not aligned
the current style follows Spark

Thanks for reviewing, and I agree with the points you listed.
The rough idea of this PR is to bring auto-formatting to Antlr files, but currently no more options supported to align with the style we expected.
Shall we just close this PR ?

yeah, I think so. We can re-open it when we find a better way.

OK, closing this PR. Thx.
Btw, we are not expecting a better solution for Antlr styling from the future version of spotless-maven-plugin, since from 2.31.0 it requires Java 11+ we are now pinning it to 2.30.0.


Bug Fix & Enhancement

[Bug] Bean name of @Service annotated class does not resolve placeholder #1755
[Enhancement] Resolve the placeholders for sub-properties #2297

Codecov Report

Merging #2687 into 2.6.x will decrease coverage by 0.09%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##              2.6.x    #2687     +/-   ##
===========================================
- Coverage     47.41%   47.31%   -0.1%
+ Complexity     4299     4279     -20
===========================================
  Files           557      554      -3
  Lines         24384    24340     -44
  Branches       4313     4301     -12
===========================================
- Hits          11561    11517     -44
- Misses        11039    11040      +1
+ Partials       1784     1783      -1

Impacted Files
Coverage Δ
Complexity Δ

...nnotation/AbstractAnnotationConfigBeanBuilder.java
93.33% <ø> (ø)
9 <0> (ø)
:arrow_down:

...beans/factory/annotation/ReferenceBeanBuilder.java
71.11% <ø> (ø)
12 <0> (ø)
:arrow_down:

...bo/config/spring/schema/DubboNamespaceHandler.java
100% <ø> (ø)
3 <0> (ø)
:arrow_down:

...ans/factory/annotation/ServiceBeanNameBuilder.java
100% <ø> (ø)
12 <0> (ø)
:arrow_down:

...spring/context/event/ServiceBeanExportedEvent.java
100% <ø> (ø)
2 <0> (ø)
:arrow_down:

.../config/spring/status/DataSourceStatusChecker.java
76.47% <ø> (ø)
6 <0> (ø)
:arrow_down:

...nnotation/DubboConfigBindingBeanPostProcessor.java
67.5% <ø> (ø)
7 <0> (ø)
:arrow_down:

...annotation/ServiceAnnotationBeanPostProcessor.java
83.08% <ø> (ø)
31 <0> (ø)
:arrow_down:

...ubbo/config/spring/status/SpringStatusChecker.java
81.25% <ø> (ø)
11 <0> (ø)
:arrow_down:

...baba/dubbo/config/spring/util/AnnotationUtils.java
42.1% <ø> (-19.01%)
4 <0> (-5)

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f58997f...e33d3df. Read the comment docs.


Add setuptools to the installation requirements

setuptools is a dependency of this package, as it is used in
version.py. When building applications with this package as
dependency, the applications need to have setuptools as an additional
dependency, eventough it is this package's dependency.
By adding setuptools to the list of installation requirements, this
package becomes self-contained.
Resolves #2

Pull Request Test Coverage Report for Build 41

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 70.362%

Totals

Change from base Build 39:
0.0%

Covered Lines:
249

Relevant Lines:
341

💛  - Coveralls


Is flutter 1.17.0 or dart 2.8 supported?

I tested with master branch and failed, while v1.12.13 still works.
Error:
Target kernel_snapshot failed: Exception: Transformer terminated unexpectedly.

Done


Rename HISTORY to CHANGELOG

CHANGELOG is more consistent with contemporary projects.

[ ] Rename HISTORY.md to CHANGELOG.md
[ ] Modify Rakefile rake task accordingly

On Hold: until 0.12.0 is ready for release


not found: value $ivy on Windows 10

Hi,
I've just downloaded jupyter-scala_2.11.6-0.2.0-SNAPSHOT.zip and installed jupyter-scala by running jupyter-scala.bat.
But then when I try to run the code from README to import Spark, I get a bunch of exceptions, see below.
Any idea how to fix it?
thanks a lot,
E.

@ZmeiGorynych I don't know if this is still relevant, but you could try putting the
import org.apache.spark._
...

lines into a new cell.

There have been a lot of improvements in recent versions of jupyter-scala (now almond).

The installation instructions now include steps for a windows installation.
Spark integration is also documented.

If it's still relevant, could you check if you still run into issues using the current version?

@sbrunk Thanks a lot for the update! I'm not currently looking at this, but will keep it in mind once I come back to it.

Ok closing then. Feel free to reopen in case you come back to it and still run into this issue.


Data Science with Python:Introduction to unsupervised learning

Description 📜
I have worked on the issue "Introduction to Unsupervised learning" in which I have explained the detailed information about the unsupervised learning. Fixes issue #428

Type of change 📝

[ ] Audio (Should be in mp3 format Includes speech clarity, Concise ,Low distortion)
[ ] Video (Animations, screen-recordings, presentations and regular explanatory films are all possibilties etc)
[x] Documentation (Content Creation in the form of codes or tutorials)
[ ] Other (If you choose other, Please mention changes below)

Domain of Contribution 📊

[ ] Android Dev (Flutter, Java, Kotlin)
[ ] Backend Dev (Java, .NET, Python)
[ ] C/CPP
[ ] Competitive Programming
[ ] Cyber Security
[ ] DSA
[ ] Database
[x] Datascience with Python
[ ] Datascience with R
[ ] Frontend Dev HTML/CSS/JS
[ ] Frontend Dev React/Angular/Vue
[ ] Golang
[ ] Interview Prep
[ ] Java_Domain
[ ] JavaScript
[ ] MERN
[ ] Machine Learning
[ ] Open Source
[ ] Python_Domain
[ ] Rust
[ ] Statistics
[ ] UI/UX

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸

Just removing the unnecessary tags. From next time just keep the domain name you are contributing to in the PR description. Its mentioned in the comments.
You can ask the mentors of your domain to review this PR now!

/assign
I would like to work on this issue.
Name: Basudev Tyagi
Batch: Data Science with Python Batch-13
Type: Documentation

/assign

@prathimacode-hub please review my issue.

Kindly follow the project structure provided. @Robinrai2612


Decoding JSON is slower in AOT than JIT code

Decoding JSON seems to be ~40% slower in AOT than in JIT code.
Here are two runs with a little benchmark:
Compiling AOT executable
Info: Compiling with sound null safety
Generated: /Users/gabriel/Desktop/temp/dart_json_benchmark/bin/dart_json_benchmark.exe

Running JIT code
Small document(RunTime): 27.268317290649797 us.
Large document(RunTime): 7540.672932330827 us.

Running AOT code
Small document(RunTime): 37.69622662846803 us.
Large document(RunTime): 12054.126506024097 us.

Compiling AOT executable
Info: Compiling with sound null safety
Generated: /Users/gabriel/Desktop/temp/dart_json_benchmark/bin/dart_json_benchmark.exe

Running JIT code
Small document(RunTime): 25.612168322917732 us.
Large document(RunTime): 7157.946428571428 us.

Running AOT code
Small document(RunTime): 35.71108452665786 us.
Large document(RunTime): 11241.657303370786 us.

Decoding is still plenty fast. I just noticed the difference and thought it might be of interest to the Dart team.
Feel free to close this issue if this is not a concern.

I'm not surprised here. JIT gets smarter over time...ever a short amount of time.
CC @mraleph @lrhn

I agree that it's not that surprising.
A simple benchmark, doing nothing but repeatedly decoding the same inputs, is very likely to be monomorphic and therefore JIT compiles very well. Real-life applications probably won't show as big a difference (and tend towards the slower speed).

Thanks for the explanation.
I'm closing this since it's expected behavior.


Party Management and Recruitment

Description
Let's add the ability to recruit party members through events in Guild houses or in the wild.
Acceptance Criteria
Tasks
Use this section to keep track of work

QA Notes
Environments
Steps

This is not one issue, definitely a milestone or parent ticket.


How to add custom driver subdirectory to application project?

I want to add custom sensor driver to my project. How to organize Kconfig and Cmake files for that?

Seems duplication of #5554


Remove crams + indexes and somaliers from bucket directory

This script will delete CRAMs + indexes for provided samples at the specified bucket path.
For example, if a genome sequence has ingested as type: exome and the sequence goes through alignment, a bogus CRAM is created in the main/exome/cram/ path in the bucket.
Context: https://github.com/populationgenomics/seqr-private/issues/73
I have to say, it seems like a data loss risk to just let this script loose in the main branch...
Are there any additional steps or checks that should be included to mitigate risk before merging this? Or perhaps a different repo where it would be safer?

@lgruen: Thoughts on this?

I share @illusional's reservations here. Manual removal of crams should a) be an infrequent occurrence - it should basically only happen if data is withdrawn from a study or we have put it in the wrong project in error. and b) it is a unique opportunity for data loss as for most projects the cram will be our only copy of read-level data.
To me, the safest option would seem to be a "run once" data management script with hardcoded file paths for deletion that is committed to the seqr-private repo. A version of the script in this PR could be used to prepare the files for deletion list as described by @illusional.


referential integrity checking of napa squads mongodb via sparql in fuseki

@Michal-Babins you may be interested in this too. We should all meet and discuss at some point
I will try to attach the referential integrity report, within the scope of the data that was retrieved (see the local/some_napa_collections.yamltarget in theproject.Makefile`)

objects-that-are-never-subjects.tsv.txt

I think a lot of the data object issues are b/c we didn't load the data_object_set when we were testing, I've fixed the OmicsProcessing part_of issue.


Placeholders in the paths

Hello,
Latest version (1.5.5) stores build artifacts in the directories with placeholders in names. Then electron runtime can't find them and nothing works.

I am on node 6.7, running electron-rebuild from a script with the following params:

@artemave I'll look into this when I get a chance, it looks like some weird prebuilt issue 😕

@artemave PR is up to handle this 👍

Merge?

Hit this same issue myself today, also when trying to run electron-rebuild on sqlite3. Spent an hour or so digging in enough to understand the cause and was just about to file my own bug report when I discovered this issue.  As far as I can tell node-sqlite3 can not be built for electron using electron-rebuild until this issue is resolved.
As an interim workaround: I can confirm that reverting electron-rebuild to 1.4.0 will work with the latest electron (1.4.14). (I've only tested with electron-1.4.7. and 1.4.14, but I'd expect everything in between to work too).

I have the same problem.
I have rename {node_abi}-{platform}-{arch} to electron-v1.4-darwin-x64 ,it work


Integrate Profile Page with backend API

Checkout the backend repo and specifically this PR. You will be required to make the necessary changes in the profile page too (add fields for master resume, resume 1 ,etc.)
Connect it using preferably fetch API or react-axios.

I want to work on this issue.


Removed axes() because not defined

I got the following error when I tried to run this notebook through binder. Not very experienced with Julia so sure what the problem is...
'''
UndefVarError: axes not defined
Stacktrace:
[1] include_string(::String, ::String) at ./loading.jl:522
[2] execute_request(::ZMQ.Socket, ::IJulia.Msg) at /srv/julia/pkg/v0.6/IJulia/src/execute_request.jl:193
[3] (::Compat.#inner#6{Array{Any,1},IJulia.#execute_request,Tuple{ZMQ.Socket,IJulia.Msg}})() at /srv/julia/pkg/v0.6/Compat/src/Compat.jl:125
[4] eventloop(::ZMQ.Socket) at /srv/julia/pkg/v0.6/IJulia/src/eventloop.jl:8
[5] (::IJulia.##13#16)() at ./task.jl:335
'''
I removed ax = axes() and it runs fine since ax variable is never called anyways.

Merged. I also don't remember why it is here. Let's see if someone comes to explain to us why it is needed :)
Thanks for taking the time to fix things up!

Maybe @NHDaly knows?

Huh, yeah, looking through the commit history on PyPlot.jl, it looks like they stopped exporting the axes() function into the user's namespace in the last release that still supported Julia 0.6:
https://github.com/JuliaPy/PyPlot.jl/commit/c7afdfd64539ff411df565d8b74ed63fcf6aee86
You can still access it through PyPlot.axes(), if you need to, but I think removing it as you've done here seems fine as well. :) Thanks for the PR! :)
More generally, though, @betatim, we should definitely update this file to be a Julia 1.0 notebook, as Julia 0.6 is not a supported release.

I've opened https://github.com/binder-examples/multi-language-demo/pull/6 to update it. :)

(To clarify, one of the main reasons it's worth updating is that in Julia 1.0 we start supporting the Manifest.toml, so after PR #6, we will have a hard-coded version of PyPlot, so that the code will never break in the (foreseeable) future because it will always install the same version of julia and its package dependencies.)


Memory access violation when calling cpdef'ed method of extension type

During testing of scikit-image master with Cython 0.29.4 on Windows, I get a reproducible segfault in the scikit-image's _mcp Cython extension module as mentioned at https://github.com/scikit-image/scikit-image/pull/3696#issuecomment-459652232.
The segfault happens when calling the cpdef goal_reached method of the cdef class MCP (Cython extension type) at https://github.com/scikit-image/scikit-image/blob/master/skimage/graph/_mcp.pyx#L541.
The segfault disappears when overriding the cpdef method from Python or when adding a __dict__ to the cdef class.
The segfault is in the generated code
obj_dict_version = likely(Py_TYPE(((PyObject *)__pyx_v_self))->tp_dictoffset) ? __PYX_GET_DICT_VERSION(_PyObject_GetDictPtr(((PyObject *)__pyx_v_self))) : 0;
where __pyx_v_self is a valid python object, tp_dictoffset seems reasonable (1936), but _PyObject_GetDictPtr(((PyObject *)__pyx_v_self)) points to an out of bounds address such that __PYX_GET_DICT_VERSION either segfaults or returns an invalid or random value.
It seems to me that either the cdef class should have a zero tp_dictoffset, or allocate memory for a __dict__.
Here's the top of the call stack:
>	_mcp.cp37-win_amd64.pyd!__pyx_f_7skimage_5graph_4_mcp_3MCP_goal_reached(__pyx_obj_7skimage_5graph_4_mcp_MCP * __pyx_v_self=0x000001a23db99858, __int64 __pyx_v_index=9, double __pyx_v_cumcost=1.0000000000000000, int __pyx_skip_dispatch=0) Line 7580	C
 	_mcp.cp37-win_amd64.pyd!__pyx_pf_7skimage_5graph_4_mcp_3MCP_6find_costs(__pyx_obj_7skimage_5graph_4_mcp_MCP * __pyx_v_self=0x000001a23db99858, _object * __pyx_v_starts=0x000001a203e47d08, _object * __pyx_v_ends=0x00007ff9b3067ce0, _object * __pyx_v_find_all_ends=0x00007ff9b305c950, _object * __pyx_v_max_coverage=0x000001a2420fb870, _object * __pyx_v_max_cumulative_cost=0x00007ff9b3067ce0, _object * __pyx_v_max_cost=0x00007ff9b3067ce0) Line 8683	C
 	_mcp.cp37-win_amd64.pyd!__pyx_pw_7skimage_5graph_4_mcp_3MCP_7find_costs(_object * __pyx_v_self=0x000001a23db99858, _object * __pyx_args=0x000001a203e9c160, _object * __pyx_kwds=0x0000000000000000) Line 7869	C
 	python37.dll!_PyMethodDef_RawFastCallKeywords(PyMethodDef * method, _object * self=0x000001a23db99858, _object * const * args=0x000001a23db97fc0, __int64 nargs=1, _object * kwnames=0x0000000000000000) Line 690	C
 	[Inline Frame] python37.dll!_PyMethodDescr_FastCallKeywords(_object *) Line 288	C

Yeah, this looks like a bug. tp_dictoffset should be 0 iff we have a dict. Can you come up with a minimal reproducible example?

Can you come up with a minimal reproducible example?

Not yet, but I experimented with this:
# module.pyx

from __future__ import print_function

from cpython.object cimport Py_TYPE, PyObject

cdef extern from 'object.h':
    PyObject** _PyObject_GetDictPtr(object)

cdef print_info(self):
    cdef Py_ssize_t dictoffset
    cdef PyObject** objptr

    print('* id(self)', id(self))

    dictoffset = Py_TYPE(self).tp_dictoffset
    print('* dictoffset', dictoffset)

    objptr = _PyObject_GetDictPtr(self)
    print('* _PyObject_GetDictPtr(self)', <Py_ssize_t>objptr)
    if objptr != NULL:
        print('* _PyObject_GetDictPtr(self)[0]', <Py_ssize_t>(objptr[0]))

    if hasattr(self, '__dict__'):
        print('* id(self.__dict__)', id(self.__dict__))
        print(self.__dict__)

cdef class CdefClass:

    def __init__(self):
        self.obj = 1

    cpdef cpdef_func(self):
        pass

    def def_func(self):
        print_info(self)
        self.cpdef_func()

class PyClassDerived(CdefClass):
    pass

class PyClass:

    def __init__(self):
        self.obj = 1

    def def_func(self):
        print_info(self)

print('CdefClass')
c = CdefClass()
c.def_func()

print('PyClassDerived')
c = PyClassDerived()
c.def_func()

print('PyClass')
c = PyClass()
c.def_func()

When using the CdefClass definition with __dict__, the output looks as expected (to me):
# module.pyd

cdef class CdefClass:
    cdef dict __dict__
    cdef object obj
    cpdef cpdef_func(self)

CdefClass
* id(self)<PHONE_NUMBER>072
* dictoffset 24
* _PyObject_GetDictPtr(self)<PHONE_NUMBER>096
* _PyObject_GetDictPtr(self)[0]<PHONE_NUMBER>464
* id(self.__dict__)<PHONE_NUMBER>464
{}

PyClassDerived
* id(self)<PHONE_NUMBER>040
* dictoffset 24
* _PyObject_GetDictPtr(self)<PHONE_NUMBER>064
* _PyObject_GetDictPtr(self)[0]<PHONE_NUMBER>968
* id(self.__dict__)<PHONE_NUMBER>968
{}

PyClass
* id(self)<PHONE_NUMBER>512
* dictoffset 16
* _PyObject_GetDictPtr(self)<PHONE_NUMBER>528
* _PyObject_GetDictPtr(self)[0]<PHONE_NUMBER>464
* id(self.__dict__)<PHONE_NUMBER>464
{'obj': 1}

Note that _PyObject_GetDictPtr(self)[0] == id(self.__dict__) in all cases.
When using the CdefClass definition without __dict__, the output for the PyClassDerived case looks suspicious (_PyObject_GetDictPtr(self)[0] == 0 != id(self.__dict__) ):
# module.pyd

cdef class CdefClass:
    # cdef dict __dict__
    cdef object obj
    cpdef cpdef_func(self)

CdefClass
* id(self)<PHONE_NUMBER>080
* dictoffset 0
* _PyObject_GetDictPtr(self) 0

PyClassDerived
* id(self)<PHONE_NUMBER>608
* dictoffset 32
* _PyObject_GetDictPtr(self)<PHONE_NUMBER>640
* _PyObject_GetDictPtr(self)[0] 0
* id(self.__dict__)<PHONE_NUMBER>960
{}

I think it simply means that the dict is supported by the object but has not been initialised yet (because nothing was assigned to it). Looks like we must handle that case.

Thank you! https://github.com/cython/cython/commit/253c25a902aef2c54de31baa22af73d0dbad2a06 fixes the crash in scikit-image.

Fix released in 0.29.5.


envoy spams debug log

Found envoy-log sitting around with 16G, all entry look the same:
[2018-03-04 22:59:51.822][388][warning][router] accesslog.cc:171] Cilium access log send failed: Resource temporarily unavailable

Is there any time interval between the entries? I.e., would rate-limiting the logging help here?

I saw several messages per second, it looked like an error retry that then spams the log.


[Bug]: CLI gives incorrect error when logged in account does not have access to store.

Please confirm that you have:

[X] Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
[X] Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?
Theme
Expected behavior
The CLI should have displayed a message saying that the currently logged in account does not have access of any kind to the store on the passed --store flag. Then it should prompt to log in with a different account or log them out or something. shopify auth logout is not included in the migration instructions, but is probably not necessary if this is done right.
Actual behavior
The following error was printed after running shopify theme dev --store=myotherstorenamehere.myshopify.com
┏━━ Viewing theme… ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ (1.02s) ━━
┏━━ Error ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
┃ You can't use Shopify CLI with development stores if you only have Partner staff member access. If you want to use Shopify CLI to work on a development store, then you should be the store owner or create a staff account on the store.
┃
┃ If you're the store owner, then you need to log in to the store directly using the store URL at least once (for example, using myotherstorenamehere.myshopify.com/admin) before you log in using Shopify CLI. Logging in to the Shopify admin directly connects the development store with your Shopify login.
┃
┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
error Command failed with exit code 1.

This is an incorrect error because the store I was attempting to log into is not and never was a development store and the logged in account does not have Partner staff member access or access of any kind to this store.
Stack trace
No response
Reproduction steps

Log into a store with an Shopify account (a partner account to get this exact error i'm guessing, have not tried with an account that is not partner) that has access for example by running shopify theme dev --store=mystorehere.myshopify.com then close dev server.
Switch to a different theme on a different store, etc in a different folder. This theme is one that the account from step 1 does NOT have access to of any kind. A different login is needed to sign into this different store.
Try running shopify theme dev --store=myotherstorehere.myshopify.com
Witness error.

Operating System
Mac OS 13 Ventura
Shopify CLI version (check your project's package.json if you're not sure)
3.20.1
Shell
zsh
Node version (run node -v if you're not sure)
v16.15.0
What language and version are you using in your application?
Liquid
https://github.com/Shopify/cli/issues/686#tasklist-block-7c89a3cd-7b45-4b50-a5a8-e44c4ad3d0eb

I can't log in my theme in version 3.21.0


SSL support

This fork introduce a basic SSL support.
The certificates are required and need to be on the host machine (I use the same 2 auto-signed certificates for all my development virtual machines). Yo can specify the local path and certificates' names in group_vars/all

@enricodeleo thanks so much for getting this started again. I wanted to this to handle this myself though since there's a lot more Nginx configuration needed.
See https://github.com/roots/bedrock-ansible/pull/172

@swalkinshaw thanks to your attention and your great work! I'll try to contribute further in the near future since as I said before I am an heavy user of Bedrock :)


improve layout of home screen

improve the layout of home screen currently if there are only two videos there's a lot of distance between them

I want to work on this issue please assign it to me

I want to work on this under JWOC


Nearly entire page not working.

Almost nothing works for me anymore. I used to go in and create stuff on my computer but I cant anymore. Where I should be able to type on either left or right side it is just blue. Almost none of the clickable buttons work. I tried going onto my laptop to see if maybe it was an issue with my dekstop but it works on neither. I have no idea how to possible fix the issue and I would really prefer not having to go back to google docs which sucks in comparison. The organization of the homebrewery- natural crit is extremely helpful.

You'll have to provide more details and screenshots of your issue.

@calculuschild, I think this issue can be closed as "cannot reproduce"

Closing since there hasn't been a reply from the user for a while and it is assumed the problem was solved.
If you are still experiencing this issue, feel free to reopen and provide information, @werjak


Typo in the README

Under the Object365 pretrained models, The ViT-B and ViT-L on the left column should be switched to match the URLs.

Thanks and it is fixed.


Feature request: organize data in folders

implement folder "car-state"; "battery-state"; "thermal-state" instead of having all in a single folder

implemented in 0.3.0

0.3.0 released to NPM

temperatures and seat / steering heating values are missing
inside temp
outside temp
hvac on/off
seat heating
stearing wheel heating
driver temp setting


⚠ SceneTime has degraded performance

In 17d6e71, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 15082 ms

Resolved: SceneTime performance has improved in 5ce1e3b after 8 minutes.


I18_n Removing html tags from posts

Laravel Version: 5.5.19
Voyager Version: 1.0.13
PHP Version: 7.1.1
Database Driver & Version: MySQL

when i18_n is enabled, in edit mode of posts, html tags from posts removing. in pages and other custom tables all is ok, truble in only posts.

The HTML tags are a part of the Rich Text Editor.

Closing due to inactivity.
Also it looks like this is expected behaviour.


automate upload

added modrinth support with 57303ab302a41f631a18795bc322754865d93168

added support for my own maven with 014d3e3d22b313d86426907a7059d38f92da3ad6

ADDED CURSEFORGE support!!! (with 3b9becfd42dcae9554dca1b81202910d10169329 ) 🥳🥳

Not added rn: Changelogs. They'll come next.

Fixed with 52bb35ca258e5c9445b67dcd110689e9f2ac037b


Go 1.15 compatiblity

Describe the bug
Even after a couple of fixes (#2401, #2429), there are more issues related to compatibility with Go 1.15
To Reproduce
Steps to reproduce the behavior:

brew install<EMAIL_ADDRESS>make test

Expected behavior
All tests pass
Screenshots
These tests fail, possibly more:
=== RUN   TestProxyClientTLS/should_pass_with_TLS_client_to_trusted_TLS_server_with_correct_hostname
    builder_test.go:342:
        	Error Trace:	builder_test.go:342
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unavailable desc = connection error: desc = "transport: authentication handshake failed: x509: certificate relies on legacy Common Name field, use SANs or temporarily enable Common Name matching with GODEBUG=x509ignoreCN=0"
        	Test:       	TestProxyClientTLS/should_pass_with_TLS_client_to_trusted_TLS_server_with_correct_hostname
=== RUN   TestProxyClientTLS/should_fail_with_TLS_client_without_cert_to_trusted_TLS_server_requiring_cert
=== RUN   TestProxyClientTLS/should_fail_with_TLS_client_without_cert_to_trusted_TLS_server_requiring_cert_from_a_different_CA
=== RUN   TestProxyClientTLS/should_pass_with_TLS_client_with_cert_to_trusted_TLS_server_requiring_cert
    builder_test.go:342:
        	Error Trace:	builder_test.go:342
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unavailable desc = connection error: desc = "transport: authentication handshake failed: x509: certificate relies on legacy Common Name field, use SANs or temporarily enable Common Name matching with GODEBUG=x509ignoreCN=0"
        	Test:       	TestProxyClientTLS/should_pass_with_TLS_client_with_cert_to_trusted_TLS_server_requiring_cert
--- FAIL: TestProxyClientTLS (0.15s)
    --- PASS: TestProxyClientTLS/should_pass_with_insecure_grpc_connection (0.01s)
    --- PASS: TestProxyClientTLS/should_fail_with_TLS_client_to_non-TLS_server (0.12s)
    --- PASS: TestProxyClientTLS/should_fail_with_TLS_client_to_untrusted_TLS_server (0.00s)
    --- PASS: TestProxyClientTLS/should_fail_with_TLS_client_to_trusted_TLS_server_with_incorrect_hostname (0.00s)
    --- FAIL: TestProxyClientTLS/should_pass_with_TLS_client_to_trusted_TLS_server_with_correct_hostname (0.00s)
    --- PASS: TestProxyClientTLS/should_fail_with_TLS_client_without_cert_to_trusted_TLS_server_requiring_cert (0.00s)
    --- PASS: TestProxyClientTLS/should_fail_with_TLS_client_without_cert_to_trusted_TLS_server_requiring_cert_from_a_different_CA (0.00s)
    --- FAIL: TestProxyClientTLS/should_pass_with_TLS_client_with_cert_to_trusted_TLS_server_requiring_cert (0.00s)
=== RUN   TestMultipleCollectors
--- PASS: TestMultipleCollectors (0.00s)
=== RUN   TestBindFlags
--- PASS: TestBindFlags (0.00s)
=== RUN   TestReporter_EmitZipkinBatch
--- PASS: TestReporter_EmitZipkinBatch (0.00s)
=== RUN   TestReporter_EmitBatch
--- PASS: TestReporter_EmitBatch (0.00s)
=== RUN   TestReporter_SendFailure
--- PASS: TestReporter_SendFailure (0.00s)
=== RUN   TestReporter_AddProcessTags_EmptyTags
--- PASS: TestReporter_AddProcessTags_EmptyTags (0.00s)
=== RUN   TestReporter_AddProcessTags_ZipkinBatch
--- PASS: TestReporter_AddProcessTags_ZipkinBatch (0.00s)
=== RUN   TestReporter_AddProcessTags_JaegerBatch
--- PASS: TestReporter_AddProcessTags_JaegerBatch (0.00s)
=== RUN   TestReporter_MakeModelKeyValue
--- PASS: TestReporter_MakeModelKeyValue (0.00s)
FAIL
FAIL	github.com/jaegertracing/jaeger/cmd/agent/app/reporter/grpc	0.383s

cc @albertteoh

Just some additional info:

This is caused by Go 1.15 dropping support for verifying hostname/IP address in the Common Name field of a certificate.
GODEBUG=x509ignoreCN=0 make test should get the tests passing locally in the meantime.
More details found here: https://github.com/golang/go/issues/39568#issuecomment-671424481

I don't think GODEBUG is the appropriate path here (it will become unsupported in Go 1.16 again). This https://github.com/golang/go/issues/39568#issuecomment-671424481 has a number of other suggestions on how to fix this. I think we need to regenerate the test certificates as described in step 2 there.


Null Pointer Exception

1970-01-01 08:01:46,916 [LittleProxy-ClientToProxyWorker-7] io.netty.channel.DefaultChannelPipeline WARN An exception was thrown by a user handler's exceptionCaught() method while handling the following exception:
java.lang.NullPointerException
at org.littleshoot.proxy.impl.ClientToProxyConnection.timedOut(ClientToProxyConnection.java:455)
at org.littleshoot.proxy.impl.ProxyConnection.userEventTriggered(ProxyConnection.java:657)
at io.netty.channel.AbstractChannelHandlerContext.invokeUserEventTriggered(AbstractChannelHandlerContext.java:308)
at io.netty.channel.AbstractChannelHandlerContext.fireUserEventTriggered(AbstractChannelHandlerContext.java:294)
at io.netty.handler.timeout.IdleStateHandler.channelIdle(IdleStateHandler.java:322)
at io.netty.handler.timeout.IdleStateHandler$AllIdleTimeoutTask.run(IdleStateHandler.java:435)
at io.netty.util.concurrent.PromiseTask$RunnableAdapter.call(PromiseTask.java:38)
at io.netty.util.concurrent.ScheduledFutureTask.run(ScheduledFutureTask.java:120)
at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:357)
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:357)
at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:111)
at java.lang.Thread.run(Thread.java:745)
I am getting this exception every now and then. Do you guys know the cause of this? Is it because of the timeout settings I have:
proxy = new BrowserMobProxyServer();
proxy.setConnectTimeout(30, TimeUnit.SECONDS);
proxy.setRequestTimeout(30, TimeUnit.SECONDS);
proxy.start(0);
driver = new PhantomJSDriver(capabilities);
driver.manage().timeouts().setScriptTimeout(30, TimeUnit.SECONDS);
driver.manage().timeouts().pageLoadTimeout(60, TimeUnit.SECONDS);
proxy.newHar(target);
driver.get(target);
Har har = proxy.getHar();
driver.quit();
Note, I don't stop the proxy everytime I quit the driver. So the proxy keeps running...

It looks like this is caused by a defect in LittleProxy when the client request times out. I'll open a defect in LP. It should be fairly straightforward to fix.
Thanks for noticing this and pasting the info!

@chemicwepn - this should now be fixed, after an update to LittleProxy. Can you let me know if you still have issues with it?

how do I update to use the new version? I a using this setting in pom:

net.lightbody.bmp

browsermob-core-littleproxy
2.1.0-beta-2

You'll need to build from master, until there's another beta release that includes the fix. There's a section in the README file explaining how to do so.

Yo, I ran the new build. Looks like Null pointers are gone. Fix looks good. Thanks for the quick fix.

Great! I'll close this issue, then.


Release consensus <IP_ADDRESS>

Description
Release version <IP_ADDRESS> of the ouroboros-consensus bundle. See the changelog.

bors r+

bors r+


Use flake8-black for linter

Install flake8-black in CI to check for black errors.

Resolved in PR #53


Can't run the porcupine_demo_file demo

Hi,
I am trying out Porcupine.  I had created an account with Picovoice and have the access key.  However, every time I try to run the demo on WINDOWS via Cygwin shell, I keep getting the INVALID ARGUMENT error. I had copied all the files that I supplied to the command line options in the build directory for ease of run.
I know have a legit access key that I created months ago, and I make sure I do an export ACCESS_KEY=<the access key I got when I signed up for a Picovice account in Nov. 2021.>
Please direct me where I can help on this!  Thank you very much!
./porcupine_demo_file.exe -l ./libpv_porcupine.dll -m ./porcupine_params.pv -k ./my_trained_model.ppn -t 0.5 -w ./sample-16bits.wav -a ${ACCESS_KEY}
'pv_porcupine_init' failed with 'INVALID_ARGUMENT'

I have the status echoed out.
'pv_porcupine_init' failed with 'INVALID_ARGUMENT' status=3

I think all you need to do is to literally replace ${ACCESS_KEY} with yours. This is not an environment variable.

I think all you need to do is to literally replace ${ACCESS_KEY} with yours. This is not an environment variable.

Hi,
Please note that I also set the environment var $ACCESS_KEY.  Also, I did try the literal form that, that is, "-a ", but it still does not work.
The error status returned is 3.  If you could look up the code of pv_porcupine_init(...) and share what exactly the error code is, I would greatly appreciate it.
Thanks.

Btw, I decide to try on the Linux platform, using the same trained model that I created 6 months ago, and I get the below.
I can understand that Picovoice wants to encode the platform information into the model for restricted/licensing purposes, but would you want to do that when people, like me, are trying to evaluate Porcupine for possible usage of a product, as in paying for usage?
One of key points in my evaluation is also looking at Picovoice's support of its Porcupine product and other products.
[ERROR] keyword file has incorrect format or belongs to a different platform [ERROR] loading keyword file at './hey_davinci_trained_model.ppn' failed with 'INVALID_ARGUMENT'
On WINDOWS platform, I get the mysterious "INVALID_ARGEMENT" with status = 3 with the below run.
`./porcupine_demo_file.exe -l ./libpv_porcupine.dll -m ./porcupine_params.pv -k ./my_trained_model.ppn -t 0.5 -w ./sample-16bits.wav -a
'pv_porcupine_init' failed with 'INVALID_ARGUMENT'`

Ok, it could be my .ppn model, which was created via picovoice.ai web site 6 months ago, is too old.  I substitute my .ppn file with the alexa_windows.ppn that comes from this github site, and I get the below error.
'pv_porcupine_init:' failed with 'RUNTIME_ERROR'
RUNTIME_ERROR is status=7

The problem is now resolved!  The .ppn model that I created 6 months ago is NOT compatible with the latest Porcupine V2.1!!!!
I just made a new model for the Linux platform and it works!
Your library is not very user friendly!!!!!  It needs to report the problem specifically if something is wrong!
Picovoice/Porcupine could go far with this software and making $$$$ if you can make your software user friendly AND better support!

you should have gotten an error log saying that your model is incompatible with the version of the library.

@kenarsa I don't see any log.
Btw, when I first tried Porcupine in Nov 2021,it works really well.  Now, V2.1 detects only 4 out of 6 wake words in the 16Khz sample .wav that I've been using.  I've noticed also V2.1 now requires 16-bit PCM; whereas, the Porcupine version in Nov. 2021 works with 32-bit audio samples.