Lazyload and image crawling issues

There seems to be some image indexing issues as we noticed a great downfall in our website's images clicks/impressions. The screenshot is from google's search console and it displays our website's image performance in google's search results:
.
The weird thing is that we have been using the lazyload plugin since April 2019, but as you can see in the above screenshot the downfall began occuring at about mid December and quite suddenly.
At this point now, if i google search our website and search for images there is not even one single photo appearing in results.
I have the vanilla-lazyload script (12.4.0) placed before </body>.
Just before this i have the I/O polyfill script.
I use the data-scrset attribute as well as data-sizes and have the src attribute blank (i don't use any low quality placeholder images).
I ran tests with puppeteer script (from puppeteer examples page: lazyimages_without_scroll_events.js), testing some of our website urls as well as some examples from the verlok/lazyload demos. This script checks if page is using scroll events to lazy load images. This plugin DOES NOT use scroll events, however all test were "Failed".
I also temporarily added a chrome extension (Website SEO checker) and tested some of my urls with plenty of lazy loaded images and result was: "No images found".
I am not quite sure if the lazy loading technique is actually good for seo and proper crawling, however we have also created image sitemaps to help bots with indexing.
Of course i am not pointing this as a bug of this plugin, but i am just wondering if there is any workaround for websites that rely quite much on their good quality images. I was thinking to add all images inside  but not sure if it such a good idea as this could lead to heavy html files.
Any ideas?

I'm not a SEO expert so I'm not sure I can help.
First question I ask you is: how can you be sure that the drop in your google search console is due to the implementation of vanilla-lazyload? I mean, it could be for any other reason, can't it? Or the drop in the graphic matches the date on which you deployed a new version of your website using lazyload?

I think it might be interesting for you to read the final part of the discussion following issue #277. In the end of it, my understanding is that LazyLoad is 100% SEO friendly.

A couple of advices:

Try upgrading to 12.5.1 - Just to make sure you have the latest version
Try removing the IntersectionObserver polyfill - It's not necessary! If you don't use it, all images will be loaded immediately on browsers that don't support it, meaning Internet Explorer 11 (almost unused in 2020), and you will save time and computing on all other browsers

Leave it like that for a couple of days and see how it goes on Google Search console.

If the above steps don't solve your issue, I would suggest you to use a hybrid approach to lazy loading, with hybrid meaning half native (which is supported only in chromium-based browsers), half js-driven (for Safari, Firefox and others).
I wrote an article about it on Smashing Magazine --> Hybrid Lazy Loading: A Progressive Migration To Native Lazy Loading
.
The only downside of native lazy loading is that you wouldn't have any control on the loading / loaded events, no loading-related classes and callbacks.
Don't forget to let me (and the hundred people following this repo) know how it goes in the end!

I added the polyfill just a week ago in order to cover case that bot doesn't support I/O.

Ok thanks. That wouldn't be necessary since if LazyLoad detects that I/O is not supported, it loads all the images immediately. As you can see at this line in the source, it's the first check it does.

I will remove the polyfill and upgrade to latest version and check again and of course I will update this thread with new results.

If you added the polyfill just a week ago, it's OK to remove it but we already know it's not the cause of the problem.
But try and update to the latest version because Babel was adding code that wasn't compatible with all browsers.
It that doesn't solve, try migrating to native lazy loading. All at once, by removing the LazyLoad script, or progressively with the use_native option, as I explained in the above-mentioned article on Smashing Mag.

Hey @DimLeon ,
how is this going? Do you have any news?

Hey @DimLeon ,
please send an update  on what is going on, otherwise I’ll close this assuming that you solved.

Closing this.
Feel free to reopen and send updates anytime.

It seems that all our images are now being crawled properly.  And the vanilla-lazyload had no direct relation to this.
Throughout all pages of the website there was a complicated menu with menu items and submenus containing extended html code, many images as well as some ajax calls to fetch content. For some reason, as soon as we removed all these ajax calls as well as some hundreds lines of html content, we noticed vast increase of image impressions in google search console.
No actual explanation on this.
We had no errors, images were loading properly in the front, website speed was quite descent.
However, the 95% of the website images were not crawled.
And everything fixed when we removed some extended html code and 3 ajax functions.
So, nothing to do with LazyLoad script. Thanks you for support.

Thank you very much @DimLeon for the information you've reported.


🐛 SkSurfaceGanesh.h

What were you trying to do?
build
Reproduceable Code
No response
What happened instead?
`[RUN_FASTLANE]
❌  (node_modules/react-native-vision-camera/ios/Skia Render Layer/SkiaRenderer.mm:22:9)
20 | #import <include/gpu/mtl/GrMtlTypes.h>
21 | #import <include/gpu/GrBackendSurface.h>

22 | #import <include/gpu/ganesh/SkSurfaceGanesh.h>
|         ^ 'include/gpu/ganesh/SkSurfaceGanesh.h' file not found
23 | #import <include/gpu/ganesh/mtl/SkSurfaceMetal.h>
24 |
25 | #import "SkImageHelpers.h"

`
Relevant log output
No response
Device
iPhone 11
VisionCamera Version
rc6
Additional information

[X] I am using Expo
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar issues in this repository and found none.

I got same error when using rc.9, do you have any clue for the solution?


Auto-Increment To Next Step When Entering Notes Via MIDI

To aid fast note-entry, when using an attached MIDI keyboard to enter notes, automatically increment the active step after entering a note.
I'd envisage starting entering notes in this way by holding a step button, and hitting a key on the keyboard (as it operates currently). After that, though, active step would automatically increment so the next key-press would set the note for the next step, etc.
One of the step buttons could be held in the normal way, to edit the note at that step, and auto-incrementing would continue from that step.
Auto-incrementing would continue until the either the last step pf the pattern had been reached (either the Last Step set on the Sequence page, or step 64), or could wrap around to the beginning of the pattern.

I do like the current ability to select a few notes and "transpose" them while the sequencer is running. I actually discovered that workflow during a live set :) and it was fun! I also like the fact that entering notes with the keyboard this way is very similar to how editing steps works on the sequencer as well. It's just more consistent. Entering steps as you describe could be a separate action.

Point taken. How about:
Pressing a step button drops into auto-increment mode.
Pressing currently active step button drops out of auto-step-select mode, returning the keyboard to transpose duties?

Also, auto-increment only works on Note Layer?

I think many people would find it quicker to enter notes this way, as you can do it without needing two hands.

One option may be to add another RecordMode. Currently there is Overwrite and Overdub which both do live recording. There could be another Step Record mode which would allow for entering a notes using a MIDI keyboard. So the workflow would be something along the lines of setting the Step Record mode. Then enter recording mode using SHIFT + PLAY. This would put the cursor on the first step of the sequence. Entering notes would write them to the sequence, wrapping around at the last step to the first step. Recording could be stopped by leaving record mode or restarted by leaving and entering record mode.

Did a quick proof of concept of the above idea and it works quite well. I think I might add it to the next release.

Cool, that should work :)
Good work!

Couple of enhancements that spring to mind:

Wiggle pitch-bend to turn on Slide for that step (idea stolen from MI Yarns sequencer)
Mod-wheel sets step length up to tied with full mod value


nixUnstable: pre20201205_a5d85d0 -> pre20210219_548437c

Motivation for this change
update nixUnstable
had to pin gcc to gcc9 as additional work was merged since the last update which is not compatible. Pragmatically, we can bump to gcc10 when upstream has CI around gcc10
Using the version of nixUnstable which hydra is using. and just picked the patches that I really want to use.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Last time I checked the current hydra-unstable in here didn't build with latest Nix master. Can you please check if bumping Hydra would resolve the issue?
Also, this should be backported IMHO.

Last time I checked the current hydra-unstable in here didn't build with latest Nix master. Can you please check if bumping Hydra would resolve the issue?
Also, this should be backported IMHO.

updating hydra to latest, then picking what the flake.lock is locked to

updating hydra to latest, then picking what the flake.lock is locked to

https://github.com/NixOS/nixpkgs/pull/109309

1 package marked as broken and skipped:
nix-exec

1 package failed to build:
hercules-ci-agent

53 packages built:
bundix cabal2nix cachix common-updater-scripts crate2nix crystal2nix dep2nix disnix disnixos dydisnix fusionInventory go2nix hydra-unstable libnixxml lispPackages.quicklisp-to-nix lispPackages.quicklisp-to-nix-system-info nix nix-binary-cache nix-bundle nix-direnv nix-doc nix-du nix-index nix-pin nix-plugins nix-prefetch nix-prefetch-bzr nix-prefetch-cvs nix-prefetch-docker nix-prefetch-git nix-prefetch-hg nix-prefetch-scripts nix-prefetch-svn nix-review nix-serve nix-update nix-update-source nixFlakes nixos-generators nixos-shell nixui python37Packages.nix-kernel python37Packages.nixpkgs python37Packages.pythonix python38Packages.nix-kernel python38Packages.nixpkgs python38Packages.pythonix python39Packages.nix-kernel python39Packages.nixpkgs python39Packages.pythonix update-nix-fetchgit vgo2nix vulnix

https://github.com/NixOS/nixpkgs/pull/109309

1 package marked as broken and skipped:
nix-exec

1 package failed to build:
hercules-ci-agent

53 packages built:
bundix cabal2nix cachix common-updater-scripts crate2nix crystal2nix dep2nix disnix disnixos dydisnix fusionInventory go2nix hydra-unstable libnixxml lispPackages.quicklisp-to-nix lispPackages.quicklisp-to-nix-system-info nix nix-binary-cache nix-bundle nix-direnv nix-doc nix-du nix-index nix-pin nix-plugins nix-prefetch nix-prefetch-bzr nix-prefetch-cvs nix-prefetch-docker nix-prefetch-git nix-prefetch-hg nix-prefetch-scripts nix-prefetch-svn nix-review nix-serve nix-update nix-update-source nixFlakes nixos-generators nixos-shell nixui python37Packages.nix-kernel python37Packages.nixpkgs python37Packages.pythonix python38Packages.nix-kernel python38Packages.nixpkgs python38Packages.pythonix python39Packages.nix-kernel python39Packages.nixpkgs python39Packages.pythonix update-nix-fetchgit vgo2nix vulnix

@GrahamcOfBorg build hydra-unstable

@GrahamcOfBorg build hydra-unstable

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109309 run on x86_64-darwin 1

3 packages marked as broken and skipped:

fusionInventory
nix-exec
nixui

51 packages failed to build and are new build failures:

bundix: log was empty
cabal2nix: log was empty
cachix: log was empty
crate2nix: log was empty
crystal2nix: log was empty
dep2nix: log was empty
disnix: log was empty
dydisnix: log was empty
go2nix: log was empty
haskellPackages.cachix: log was empty
haskellPackages.hercules-ci-agent: log was empty
haskellPackages.nix-paths: log was empty
haskellPackages.update-nix-fetchgit: log was empty
hercules-ci-agent: log was empty
libnixxml: log was empty
nix: log https://termbin.com/wn4l
(nixStable): log was empty
nix-bundle: log was empty
nix-direnv: log was empty
nix-doc: log was empty
nix-du: log was empty
nix-index: log was empty
nix-pin: log was empty
nix-plugins: log was empty
nix-prefetch-bzr: log was empty
nix-prefetch-cvs: log was empty
nix-prefetch-docker: log was empty
nix-prefetch-git: log was empty
nix-prefetch-hg: log was empty
nix-prefetch-scripts: log was empty
nix-prefetch-svn: log was empty
nix-serve: log was empty
nix-update: log was empty
nix-update-source: log was empty
nixFlakes: log https://termbin.com/h2iy
(nixUnstable): log was empty
nixos-generators: log was empty
nixos-shell: log was empty
nixpkgs-review: log was empty
python37Packages.nix-kernel: log was empty
python37Packages.nixpkgs: log was empty
python37Packages.pythonix: log was empty
python38Packages.nix-kernel: log was empty
python38Packages.nixpkgs: log was empty
python38Packages.pythonix: log was empty
python39Packages.nix-kernel: log was empty
python39Packages.nixpkgs: log was empty
python39Packages.pythonix: log was empty
update-nix-fetchgit: log was empty
vgo2nix: log was empty
vulnix: log was empty

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109309 run on x86_64-darwin 1

3 packages marked as broken and skipped:

fusionInventory
nix-exec
nixui

51 packages failed to build and are new build failures:

bundix: log was empty
cabal2nix: log was empty
cachix: log was empty
crate2nix: log was empty
crystal2nix: log was empty
dep2nix: log was empty
disnix: log was empty
dydisnix: log was empty
go2nix: log was empty
haskellPackages.cachix: log was empty
haskellPackages.hercules-ci-agent: log was empty
haskellPackages.nix-paths: log was empty
haskellPackages.update-nix-fetchgit: log was empty
hercules-ci-agent: log was empty
libnixxml: log was empty
nix: log https://termbin.com/wn4l
(nixStable): log was empty
nix-bundle: log was empty
nix-direnv: log was empty
nix-doc: log was empty
nix-du: log was empty
nix-index: log was empty
nix-pin: log was empty
nix-plugins: log was empty
nix-prefetch-bzr: log was empty
nix-prefetch-cvs: log was empty
nix-prefetch-docker: log was empty
nix-prefetch-git: log was empty
nix-prefetch-hg: log was empty
nix-prefetch-scripts: log was empty
nix-prefetch-svn: log was empty
nix-serve: log was empty
nix-update: log was empty
nix-update-source: log was empty
nixFlakes: log https://termbin.com/h2iy
(nixUnstable): log was empty
nixos-generators: log was empty
nixos-shell: log was empty
nixpkgs-review: log was empty
python37Packages.nix-kernel: log was empty
python37Packages.nixpkgs: log was empty
python37Packages.pythonix: log was empty
python38Packages.nix-kernel: log was empty
python38Packages.nixpkgs: log was empty
python38Packages.pythonix: log was empty
python39Packages.nix-kernel: log was empty
python39Packages.nixpkgs: log was empty
python39Packages.pythonix: log was empty
update-nix-fetchgit: log was empty
vgo2nix: log was empty
vulnix: log was empty

gah, darwin :(

gah, darwin :(

gah, darwin :(

It is already broken now and I think some tests are failing. We should fix it eventually.

gah, darwin :(

It is already broken now and I think some tests are failing. We should fix it eventually.

Yea, but the current darwin build is passing https://hydra.nixos.org/build/135058690 so I don't want to break darwin users. Especially since this should be backported.
Wish darwin wasn't so expensive to get CI for. (Free for linux)

Yea, but the current darwin build is passing https://hydra.nixos.org/build/135058690 so I don't want to break darwin users. Especially since this should be backported.
Wish darwin wasn't so expensive to get CI for. (Free for linux)

looks like https://github.com/NixOS/nix/commit/86a2ceeb986609488be1c6794a8e416df3b90c7b was merged which would allow me to revert gcc version pinning

looks like https://github.com/NixOS/nix/commit/86a2ceeb986609488be1c6794a8e416df3b90c7b was merged which would allow me to revert gcc version pinning

if we can't merge this because of darwin yet, we should at least apply the patch from https://github.com/NixOS/nix/pull/4470.

if we can't merge this because of darwin yet, we should at least apply the patch from https://github.com/NixOS/nix/pull/4470.

reverted the gcc9 change, because it's no longer relevant, may also fix the darwin build
added the related flake inputs changes which I cared about and attempted to open this PR in the first place
@SuperSandro2000 do you mind doing a darwin review?

https://github.com/NixOS/nixpkgs/pull/109309

1 package marked as broken and skipped:
nix-exec

1 package failed to build:
hercules-ci-agent

51 packages built:
bundix cabal2nix cachix common-updater-scripts crate2nix crystal2nix dep2nix fusionInventory go2nix hydra-unstable libnixxml lispPackages.quicklisp-to-nix lispPackages.quicklisp-to-nix-system-info nix nix-binary-cache nix-bundle nix-direnv nix-doc nix-du nix-index nix-pin nix-plugins nix-prefetch nix-prefetch-bzr nix-prefetch-cvs nix-prefetch-docker nix-prefetch-git nix-prefetch-hg nix-prefetch-scripts nix-prefetch-svn nix-review nix-serve nix-update nix-update-source nixFlakes nixos-generators nixos-rebuild nixos-shell nixui python37Packages.nix-kernel python37Packages.nixpkgs python37Packages.pythonix python38Packages.nix-kernel python38Packages.nixpkgs python38Packages.pythonix python39Packages.nix-kernel python39Packages.nixpkgs python39Packages.pythonix update-nix-fetchgit vgo2nix vulnix

hercules-ci-agent is already broken on master

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109309 run on x86_64-darwin 1

4 packages failed to build and are new build failures:

nix-update: log was empty
nixFlakes: log https://termbin.com/ha8z
(nixUnstable): log was empty
nixpkgs-review: log was empty

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109309 run on x86_64-linux 1

1 package marked as broken and skipped:

nix-exec

2 packages blacklisted:

tests.nixos-functions.nixos-test
tests.nixos-functions.nixosTest-test

2 packages failed to build and are new build failures:

haskellPackages.hercules-ci-agent: log https://termbin.com/tugp
hercules-ci-agent: log https://termbin.com/4jqp

53 packages built:

bundix
cabal2nix
cachix
common-updater-scripts
crate2nix
crystal2nix
dep2nix
fusionInventory
go2nix
haskellPackages.cachix
haskellPackages.nix-paths
haskellPackages.update-nix-fetchgit
hydra-unstable
libnixxml
lispPackages.quicklisp-to-nix
lispPackages.quicklisp-to-nix-system-info
nix (nixStable)
nix-bundle
nix-direnv
nix-doc
nix-du
nix-index
nix-pin
nix-plugins
nix-prefetch
nix-prefetch-bzr
nix-prefetch-cvs
nix-prefetch-docker
nix-prefetch-git
nix-prefetch-hg
nix-prefetch-scripts
nix-prefetch-svn
nix-serve
nix-update
nix-update-source
nixFlakes (nixUnstable)
nixos-generators
nixos-rebuild
nixos-shell
nixpkgs-review
nixui
python37Packages.nix-kernel
python37Packages.nixpkgs
python37Packages.pythonix
python38Packages.nix-kernel
python38Packages.nixpkgs
python38Packages.pythonix
python39Packages.nix-kernel
python39Packages.nixpkgs
python39Packages.pythonix
update-nix-fetchgit
vgo2nix
vulnix

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109309 run on x86_64-linux 1

1 package marked as broken and skipped:

nix-exec

2 packages blacklisted:

tests.nixos-functions.nixos-test
tests.nixos-functions.nixosTest-test

2 packages failed to build and are new build failures:

haskellPackages.hercules-ci-agent: log https://termbin.com/veld
hercules-ci-agent: log https://termbin.com/j26h

53 packages built:

bundix
cabal2nix
cachix
common-updater-scripts
crate2nix
crystal2nix
dep2nix
fusionInventory
go2nix
haskellPackages.cachix
haskellPackages.nix-paths
haskellPackages.update-nix-fetchgit
hydra-unstable
libnixxml
lispPackages.quicklisp-to-nix
lispPackages.quicklisp-to-nix-system-info
nix (nixStable)
nix-bundle
nix-direnv
nix-doc
nix-du
nix-index
nix-pin
nix-plugins
nix-prefetch
nix-prefetch-bzr
nix-prefetch-cvs
nix-prefetch-docker
nix-prefetch-git
nix-prefetch-hg
nix-prefetch-scripts
nix-prefetch-svn
nix-serve
nix-update
nix-update-source
nixFlakes (nixUnstable)
nixos-generators
nixos-rebuild
nixos-shell
nixpkgs-review
nixui
python37Packages.nix-kernel
python37Packages.nixpkgs
python37Packages.pythonix
python38Packages.nix-kernel
python38Packages.nixpkgs
python38Packages.pythonix
python39Packages.nix-kernel
python39Packages.nixpkgs
python39Packages.pythonix
update-nix-fetchgit
vgo2nix
vulnix

I think that failure has been a long time flakey issue
can you try to build it again?

Can confirm. I regularly compile Nix on my own since I have a few patches on top and this is one of the tests that fail from time to time.

can you try to build it again?

I have build it at least two times with that issue.

can you try to build it again?

I have build it at least two times with that issue.

I had another coworker be able to build it fine. I might just merge and babysit, restarting it.

cc @edolstra @Ma27 do you mind if I pin the nix version for hydra, and the nixUnstable package can more closely follow the development branch?

Don't have the capacity to test (tonight at least in my tz), but LGTM :+1:

@ofborg eval

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109309 run on x86_64-linux 1

1 package marked as broken and skipped:

nix-exec

2 packages blacklisted:

tests.nixos-functions.nixos-test
tests.nixos-functions.nixosTest-test

3 packages failed to build and already failed to build on hydra master:

haskellPackages.hercules-ci-agent: log was empty
hercules-ci-agent: log was empty
libnixxml: log was empty

50 packages built:

bundix
cabal2nix
cachix
common-updater-scripts
crate2nix
crystal2nix
dep2nix
fusionInventory
go2nix
haskellPackages.cachix
haskellPackages.hercules-ci-cnix-store
haskellPackages.nix-paths
haskellPackages.update-nix-fetchgit
hydra-unstable
lispPackages.quicklisp-to-nix
lispPackages.quicklisp-to-nix-system-info
nix (nixStable)
nix-bundle
nix-direnv
nix-doc
nix-du
nix-index
nix-pin
nix-plugins
nix-prefetch
nix-prefetch-bzr
nix-prefetch-cvs
nix-prefetch-docker
nix-prefetch-git
nix-prefetch-hg
nix-prefetch-scripts
nix-prefetch-svn
nix-serve
nix-update
nix-update-source
nixFlakes (nixUnstable)
nixos-generators
nixos-rebuild
nixos-shell
nixpkgs-review
nixui
python38Packages.nix-kernel
python38Packages.nixpkgs
python38Packages.pythonix
python39Packages.nix-kernel
python39Packages.nixpkgs
python39Packages.pythonix
update-nix-fetchgit
vgo2nix
vulnix

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109309 run on x86_64-darwin 1

5 packages failed to build and already failed to build on hydra master:

nix-direnv: log was empty
(nixpkgs-review): log was empty
nix-update: log was empty
nixFlakes: plain log  |  pretty log
(nixUnstable): log was empty

1 package failed to build and are new build failure:

nix-review: log was empty

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

nix-direnv:

warning: unused-argument
Unused argument: nix.
Near pkgs/tools/misc/nix-direnv/default.nix:1:42:
  |
1 | { lib, stdenv, fetchFromGitHub, gnugrep, nix, nixFlakes }:
  |                                          ^

nixFlakes:

warning: EvalError
Cannot evaluate attribute ‘nixFlakes’ in ‘/nix/store/2pii6w5m7138dxg0vwjaxwnv8d8jrx1p-nixpkgs’.

nixUnstable is now past this.

closing due to other PR


Don't re-append the inputel in line input mode

This fixes to a large extent the rapid race condition flashing of the keyboard reported in https://github.com/erkyrath/quixe/issues/32

Let me go through the logic and make sure I know the plan:
Your change is meant to only call frameel.append() when the input element is first created, and otherwise to leave it in the same place in the DOM.

If line input was just accepted and is now being restarted, then win.inputel will be null, and this has no effect.
If line input is continuing through some other event (like resize or timer), then the window DOM has not changed and it's correct to leave the input element in the same place.
If character input is continuing, text might have been printed, in which case we'd want to move the input element, really. But City of Secrets doesn't do this.

Is all that correct?

Won't the case of character input continuing after newly printed text be handled by accept_one_content?

Issue erkyrath/quixe#32 causes Android Accessibility Suite's TalkBack feature to abort reading new transcript output even though the element has the attribute aria-live="polite". In the case of one buffer window and line input, this patch allows selecting the output to be read manually (unfortunately, Firefox for Android 68.1.1 then crashes when navigating with TalkBack).
I have set up a copy of windowtest.ulx and Quixe 2.1.6 with this patch at https://innodonni.github.io/play-full.html to facilitate further testing. Typing "open bottom fixed buffer 5" followed by "getline" seems to function nicely on Android, although the new input is not focused automatically.
Is anyone able to test this on iPhone with Siri?

Finally got this one in! (I still have to run it through some more tests.)
Thank you for your patience.


NO-ISSUE: Synchronize From Upstream Repositories

The downstream repository has been updated through the following upstream commit:

Date
Commit
Author
Message

2024-09-27 19:28:08
operator-framework/operator-controller@f169414
Joe Lanford
follow-ups for containers/image from catalogd and previous PR (#1270)

upstream commit list

The vendor/ directory has been updated and the following commits were carried:

Date
Commit
Author
Message

2024-09-27 00:05:36
openshift/operator-framework-operator-controller@0f8b8c3
dtfranz
UPSTREAM: : Add OpenShift specific files

2024-09-27 00:05:37
openshift/operator-framework-operator-controller@bb14af7
Alexander Greene
UPSTREAM: : Drop commitchecker

2024-09-27 00:05:38
openshift/operator-framework-operator-controller@736de31
AOS Automation Release Team
UPSTREAM: : Updating ose-olm-operator-controller-container image to be consistent with ART Reconciling with https://github.com/openshift/ocp-build-data/tree/4022cd290f00a44d667dda03f2d78d84a488c7ed/images/ose-olm-operator-controller.yml

2024-09-27 00:05:38
openshift/operator-framework-operator-controller@3b35f7f
Mikalai Radchuk
UPSTREAM: : update owners

2024-09-27 00:05:39
openshift/operator-framework-operator-controller@92d35d4
Brett Tofel
UPSTREAM: : Add pointer to tooling README

2024-09-27 00:05:40
openshift/operator-framework-operator-controller@ada1b79
Mikalai Radchuk
UPSTREAM: : Disable Validating Admission Policy APIs downstream

2024-09-27 00:05:41
openshift/operator-framework-operator-controller@eebd175
AOS Automation Release Team
UPSTREAM: : Updating ose-olm-operator-controller-container image to be consistent with ART for 4.16 Reconciling with https://github.com/openshift/ocp-build-data/tree/6250d54c4686a708ca5985afb73080e8ca9a1f7f/images/ose-olm-operator-controller.yml

2024-09-27 00:05:41
openshift/operator-framework-operator-controller@9c4360d
Mikalai Radchuk
UPSTREAM: : Enable Validating Admission Policy APIs downstream

2024-09-27 00:05:42
openshift/operator-framework-operator-controller@c4c56d9
Ilias Rinis
UPSTREAM: : manifests: set required-scc for openshift workloads

2024-09-27 00:05:43
openshift/operator-framework-operator-controller@9f2f9bd
AOS Automation Release Team
UPSTREAM: : Updating ose-olm-operator-controller-container image to be consistent with ART for 4.17 Reconciling with https://github.com/openshift/ocp-build-data/tree/4c1326094222f9209876f06833179a1b9178faf7/images/ose-olm-operator-controller.yml

2024-09-27 00:05:44
openshift/operator-framework-operator-controller@63d7f5b
everettraven
UPSTREAM: : add everettraven to approvers+reviewers

2024-09-27 00:05:45
openshift/operator-framework-operator-controller@0431b73
everettraven
UPSTREAM: : add openshift kustomize overlay

2024-09-27 00:05:45
openshift/operator-framework-operator-controller@258b025
Todd Short
UPSTREAM: : Add tmshort to approvers

2024-09-27 00:05:46
openshift/operator-framework-operator-controller@76641b1
AOS Automation Release Team
UPSTREAM: : Updating ose-olm-operator-controller-container image to be consistent with ART for 4.18 Reconciling with https://github.com/openshift/ocp-build-data/tree/dd68246f3237db5db458127566fc7b05b55e1660/images/ose-olm-operator-controller.yml

2024-09-27 00:05:47
openshift/operator-framework-operator-controller@9457e2f
Todd Short
UPSTREAM: : Properly copy and call kustomize

2024-09-27 00:05:47
openshift/operator-framework-operator-controller@f32359a
Joe Lanford
UPSTREAM: : manifests: add hostPath mount for /etc/containers

2024-09-27 00:05:48
openshift/operator-framework-operator-controller@12f2384
dtfranz
UPSTREAM: : Add test-e2e target for downstream Makefile to be run by openshift/release.

This pull request is expected to merge without any human intervention. If tests are failing here, changes must land upstream to fix any issues so that future downstreaming efforts succeed.
/cc @openshift/openshift-team-operator-framework

/label tide/merge-method-merge

/lgtm


Controller does not pass host name to the protocol

The default implementation of connection.factory() does not pass the hostname argument to SMTP(). Because of this, SMTP.__init__() looks up the FQDN of the socket which, at least on my system, takes several seconds during which the event loop is blocked. Such a blocking operation should never be executed in the event loop thread.

Thanks for the report @agronholm!
Looks like the failure is on this line here:
https://github.com/aio-libs/aiosmtpd/blob/ec804d9038989b20d2068ab3dc69ff0888a48257/aiosmtpd/controller.py#L32

This is the real problem though: https://github.com/aio-libs/aiosmtpd/blob/master/aiosmtpd/smtp.py#L94
I stumbled onto this because in my test runs, it always took suspiciously long for the SMTP server to respond. I traced the problem to the line above. I would recommend using socket.gethostname() instead if it has to happen in SMTP.__init__(). At least on my system, it gives the same result but returns instantly, unlike socket.getfqdn().

That's probably because you don't have a resolvable FQDN - https://stackoverflow.com/a/13932042/344286
I'm pretty sure that simply passing the hostname through should do the correct thing here.

I had the same performance issues as Alex and fixed it by inheriting from the controller and overriding factory():
def factory(self):
    return Server(self.handler, hostname=self.hostname, enable_SMTPUTF8=self.enable_SMTPUTF8)

Pretty much the same is present in https://github.com/cole/aiosmtplib, in which the SMTPConnection class queries the FQDN when issuing a helo command. This can be fixed by querying the FQDN once beforehand and passing it as source_address upon construction SMTPConnection or a subclass thereof (e.g. aiosmtplib.smtp.SMTP).

IMHO the solution suggested by @v7a is correct. If we already pass an explicit hostname to Controller, we should pass that as well to SMTP in factory.
I'm tempted to put this into PR #192 , but that PR is already so unwieldy so I'll defer until the PR is merged, then start a new PR to fix this.

I accidentally implemented a way of passing through parameters to the SMTP class in 7289e6d because a need arose...
It's part of that honkin' huge PR #192 , though 😅

@v7a w.r.t. this:

SMTP requires us to use the FQDN for helo/ehlo (given I interpreted https://www.ietf.org/rfc/rfc2821.txt correctly), so passing hostname=self.hostname in factory() is wrong in my eyes.

I've just read RFC2821, and in Section 3.6 it says:

Only resolvable, fully-qualified, domain names (FQDNs) are permitted when domain names are used in SMTP.  In other words, names that can be resolved to MX RRs or A RRs (as discussed in section 5) are permitted, as are CNAME RRs whose targets can be resolved, in turn, to MX or A RRs.

Which I take to mean that "we can use anything as long as it's FQDN and resolvable to A or MX".
So there is no requirement that the domain being returned must be "the actual FQDN of the SMTP Server's interface"; just that whatever it is returning must be resolvable.
There are 2 possible options going forward:

We can validate hostname as given by user, and reject if it's not resolvable to A or MX; or
We will just assume user is a consenting adult who knows how to read the manuals, and raise a warn if user provides a hostname (instead of leaving it None)

I am heavily for option No. 2 there.

With the merging of #202 into 1.3.0, Controller now has a special parameter server_hostname that gets passed to SMTP(hostname=...)
There is a second, submarine issue being discussed here, and that is the behavior of SMTP when not given the hostname parameter.
Because that's actually a separate issue from "Controller not passing hostname to SMTP", I recommend to start a new issue to discuss that.
In the meanwhilst, I'll close this issue because the main problem -- the title of this Issue -- already has a workaround in 1.3.0. Feel free to reopen this issue if you think it's not yet solved.


Records should be destroyed 10 seconds after being accessed for the first time.

I'm on it

:clap:

I think this is fundamentally wrong. The records should not be deleted after 10 seconds, because they should never be inserted to the DB in first place.. they should only live in memory for 10 seconds and be removed afterwards.

I think you are on to something. We should probably wrap every request in a transaction (I heard you love those @arthurnn) and roll it back after the response has been flushed.

@chancancode good idea.

:ok_hand:


Update jenkins pipeline to get new k8s plugin

Addresses: https://github.com/rancher/rancher/issues/22459 & https://github.com/rancher/rancher/issues/21777

A duplicate to #969

Whoops, closing https://github.com/rancher/types/pull/969


Add row shifting AES step

Changes:

Add the row shifting function, required by the block cipher.

I've addressed all your comments @ilitteri, feel free to tell me if you catch anything more worth changing.


Process Undefined Error*

When you npm install, npm run watch and then run our extension (F5), then there is a process.env is undefined error within the WebView developer tools on the newly opened WebView window.  Thank you so much for looking into this, this is an important issue~!  :)

Just asking if we have some workarounds for now.


config reload

Is there a way to let the docker_auth reread the config file? Currently you need to restart the container if you changed the config file. I see the following options:

reload on file changed
reload every minute
reload on every request
reload on the call of special api route

It would be nice to have one of this options (toggleable via config) if your config is changed from an external program like a CLI or a webinterface.

there isn't a way right now, but adding one sounds reasonable.
as always, no ETA but eventually there will be a way. :)


Update Docker version on which we test Helios

Codecov Report

Merging #1192 into master will increase coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1192      +/-   ##
============================================
+ Coverage     52.51%   52.57%   +0.06%
- Complexity     1609     1611       +2
============================================
  Files           268      268
  Lines         13005    13005
  Branches       1501     1501
============================================
+ Hits           6829     6837       +8
+ Misses         5655     5651       -4
+ Partials        521      517       -4


Startup on login option for all users

Is there a startup on login feature for all users?

This is not currently possible. You could set it up manually, but currently Text Grab does not have an option to install and launch for all users by default.

I do this:

Edit "Text-Grab.dll.config" so that FirstRun:False / RunInTheBackground:True / StartupOnLogin:True
Put a shortcut of "Text-Grab.exe" in %programdata%\Microsoft\Windows\Start Menu\Programs\StartUp

The problem is whit multiple users. If one user dont log out of windows and other logs in, then the program dont start correctly.
Is there a better way to set it up manually? Thanks


IE11 is broken

Safari 10 and below uses min/max width/height declarations for actually rendering the size of flex items, but it ignores those values when calculating how many items should be on a single line of a multi-line flex container. Instead, it simply uses the item's flex-basis value, or its width if the flex basis is set to auto. see bug. Fixed in all versions > 10.

**IE 11 requires a unit to be added to the third argument, the flex-basis property see MSFT documentation**

**In IE10 and IE11, containers with display: flex and flex-direction: column will not properly calculate their flexed childrens' sizes if the container has min-height but no explicit height property. See bug.**

**IE 11 does not vertically align items correctly when min-height is used see bug**

Firefox 51 and below does not support Flexbox in button elements. Fixed in version 52.

In Safari 10.1 and below, the height of (non flex) children are not recognized in percentages. However other browsers recognize and scale the children based on percentage heights. Fixed in all versions > 10.1 (See bug) The bug also appeared in Chrome but was fixed in Chrome 51

Flexbugs: community-curated list of flexbox issues and cross-browser workarounds for them

**In IE10 the default value for flex is 0 0 auto rather than 0 1 auto as defined in the latest spec.**

The space-evenly value of the justify-content property, as described in the CSS Box Alignment Module Level 3 is only supported by some browsers.

From https://caniuse.com/#feat=flexbox


Async handling; Controller protocol; Path/handler conveniences

Hi there 👋
This PR is mostly to gauge interest in a few changes I've made to a forked copy of this package. I can very easily split this up into many PRs if there is interest in any/all of this, but first wanted to see how it was received. Thanks for having a look!
Included Changes

Support Async/Await
a. Allows use of async/await to make async extremely simple
Fix file dir handling
a. Noticed files within directories were broken
Exclude DemoServer from package
a. Slim out the package
Add controller protocol and convenience subscript
a. Allows GET["your/route"] = MyController.myRouteHandler
i. The above would be possible for the following: struct MyController: Controller { func myRouteHandler(_ request: HttpRequest) async -> HttpResponse {
Enable registering multiple paths for a given handler
a. Allows GET["my/first/route", "my_other_route"] = { request in }
Trim : from request parameters
a. Allows request["parameterName"] vs request[":parameterName"] as a more convenient/intuitive accessor.
i. Addresses #489

(Worth noting there are some CI issues and OS version items that will need to be sorted out if these changes are desirable for others besides myself)


SLB logo update.

ENVIRONMENT: production
URL: https://scrapers.peviitor.ro/
Browser: Mozilla firefox
Device: Laptop
OS: Windows 10
STEPS TO REPRODUCE:
Open the URL in the browser
Run scraper for "SLB" Company
Check the logo
EXPECTED RESULTS:
The company logo is the same on scrapers.peviitor.ro as on the company website
ACTUAL RESULTS:
The company logo is not the same on scrapers.peviitor.ro as on the company website

Fixed!

The company logo has been updated.


[Parsers] xsodata - Refactor xsk core services - leftovers

Leftovers from: xsodata - Refactor xsk core services https://github.com/SAP/xsk/issues/145

:heavy_check_mark: Demo recorded

:heavy_check_mark: update xsodata and odata examples

https://github.com/SAP/xsk/tree/main/samples/hdb-odata
https://github.com/SAP/xsk/tree/main/samples/hdb-xsodata

:heavy_check_mark: fix issue eclipse/dirigible#877

:heavy_check_mark: fix issue ->olingo do not support '1..*' from xsodata --> solution is to convert it to *

:heavy_check_mark: add JUnit tests + ITest

:heavy_check_mark: Refactor Xtransformer

:heavy_check_mark: dirigible support for SAP Annotations for OData Version 2.0

https://wiki.scn.sap.com/wiki/display/EmTech/SAP+Annotations+for+OData+Version+2.0
https://github.com/eclipse/dirigible/issues/889  -> Dirigible Supportability for annotation

Element
Dirigible Supportability

Element edm:Schema
:x:

Element edm:EntityContainer
:x:

Element edm:EntitySet
:heavy_check_mark:

Element edm:EntityType
:heavy_check_mark:

Element edm:Property
:heavy_check_mark:

Element edm:NavigationProperty
:heavy_check_mark:

Element edm:FunctionImport
:x:

Element sap:value-constraint
:x:

Element edm:Parameter
:x:

Element edm:AssociationSet
:heavy_check_mark:

For all the list of annotations check the official documentation SAP OData Annotations v2.X
XSK supports only the below cases:

edm:EntitySet
Parameter Value
Requirement

sap:creatable
“false”
The "create forbidden" setting is defined for the entity set in the OData service definition (.xsodata) file

sap:updatable
“false”
The "update forbidden" setting is defined for the entity set in the OData service definition (.xsodata) file

sap:deletable
“false”
The "delete forbidden" setting is defined for the entity set in the OData service definition (.xsodata) file

sap:semantics
“aggregate”
Where aggregation is defined for the entity set of the entity type using "aggregates" expression in .xsodata file

:heavy_multiplication_x: [OPEN] OData Service-Definition Features

FEATURES
SUPPORTED IN XSK
REMARKS

Aggregation
:x:

Association
:heavy_check_mark:
DONE

Key Specification
:heavy_check_mark:
DONE

Parameter Entity Sets
:x:

Projection
:heavy_check_mark:
DONE

HANA TableType
Dirigible supported type for odata

CALC VIEW
:heavy_check_mark:

GLOBAL TEMPORARARY
:x:

SHARED TEMPORARARY
:x:

NO LOGGING TEMPORARY
:x:

SYNONYM
:x:

SYSTEM TABLE
:x:

TABLE
:heavy_check_mark:

USER DEFINED
:x:

COLUMN VIEW
:x:

VIEW
:heavy_check_mark:

JOIN VIEW
:x:

OLAP VIEW
:x:

HIERARCHY VIEW
:x:

:heavy_multiplication_x: [IN PROGRESS] XSODATA PARSER Conditions

Conditions
Implemented
Remarks

1
:heavy_check_mark:

2
:heavy_check_mark:

3
:heavy_check_mark:

4
:heavy_check_mark:

5
:heavy_check_mark:

6
:x:
can not be imlemented

7
:heavy_check_mark:

8
:heavy_check_mark:

9
:x:
calculation views and analytic views processing

10
:heavy_check_mark:

11
:heavy_check_mark:
calculation views and analytic views processing

12
:heavy_check_mark:
calculation views and analytic views processing

:heavy_multiplication_x: [OPEN] Xsodata do not handle Calculation Views

HANA TableType
Implemented Transformers

TABLE
:heavy_check_mark:

VIEW
:heavy_check_mark:

CALC VIEW
:heavy_check_mark:

:x:[PAUSED] Etag not covered ->#178

Close this one and let open particular issues on requests


General fixes for mobile app

Description
This PR includes genera fixes for the mobile app.
About #1244 #1233 #1214 #1247
How Has This Been Tested?
Tested on Simulators and web

there are multiple places where text-alignment was removed all together, are you saying it also didn't have any effect on web?
doesnt include images of all the effected screens, where they verified?

Yeah, it's odd it doesn't affect but checked and it doesn't. I'll fix conflicts and upload all the screenshots

there are multiple places where text-alignment was removed all together, are you saying it also didn't have any effect on web?
doesnt include images of all the effected screens, where they verified?

Uploaded more screenshots


Setting domain when sharing

Hello,
When I try to share with type domain I get:
Failed to share file: googleapi: Error 400: The domain field is required for permissions of type 'domain'., required
I do not see how to set domain. Sorry if I missed this in documentation.
Thanks,
Sep

I tried using domain in argument in terminal but it is not working.
I'm using released version
Please help

Hi! Any solution for this ? I find the same problem.

Hi,
Please build from the master


Table Align: Convert left/right to start/end

part of bootstrap 5 migration
https://getbootstrap.com/docs/5.0/migration/
this is causing a tremendous amount of lint errors in property app, which after this PR is merged we can address:

The failure above is due to the format of your commit message: Commit messages must follow Conventional Commits: https://www.conventionalcommits.org/en/v1.0.0/


webostv: Cannot change source

Home Assistant release (hass --version):
0.38.4
Python release (python3 --version):
Python 3.5.3
Component/platform:
media_player.webostv
Description of problem:
Cannot change current source.
Expected:
Set the current source.
Problem-relevant configuration.yaml entries and steps to reproduce:
media_player:
  - platform: webostv
    host: mytv.lan

Traceback (if applicable):
Traceback (most recent call last):
  File "uvloop/future.pyx", line 374, in uvloop.loop.BaseTask._fast_step (uvloop/loop.c:112704)
  File "/usr/src/app/homeassistant/core.py", line 1018, in _event_to_service_call
    yield from service_handler.func(service_call)
  File "/usr/src/app/homeassistant/components/media_player/__init__.py", line 364, in async_service_handler
    yield from getattr(player, method['method'])(**params)
  File "uvloop/future.pyx", line 230, in __iter__ (uvloop/loop.c:110600)
  File "uvloop/future.pyx", line 432, in uvloop.loop.BaseTask._fast_wakeup (uvloop/loop.c:113980)
  File "uvloop/future.pyx", line 101, in uvloop.loop.BaseFuture._result_impl (uvloop/loop.c:108900)
  File "/usr/local/lib/python3.5/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/app/homeassistant/components/media_player/webostv.py", line 294, in select_source
    self._current_source_id = self._source_list[source]['id']
KeyError: ''

Additional info:
For some reason the source name is not correctly passed to select_source (it is set to '').

My bad this was a media_player.universal config issue. I was using a config similar to what's in the docs.
The culprit was this part:
  select_source:
    service: media_player.select_source
    data_template:
      entity_id: media_player.living_room_tv
      source: ''

After changing it to the following this issue can be solved:
  select_source:
    service: media_player.select_source
    data_template:
      entity_id: media_player.living_room_tv
      source: {{ source }}

I'll issue a PR later for the documentation.


Implement ORIS Code in DE API

Definition of Ready

[ ] Does this meet the INVEST criteria?
[ ] Does this have a clearly defined user?
[ ] Does this have an estimate?
[ ] Does this have acceptance criteria?
[ ] Does this have sufficient context (wireframes, business rules, etc.)?
[ ] Is this traceable to a feature, epic, or PI?

User Story
As a user I want to enter filter criteria for ORIS code so that I can see results for my desired facilities
NO validation
Acceptance Criteria
Given that a user has entered one or multiple ORIS codes
When the API endpoint is executed
Then the system displays the records that match the criteria (containing data elements below)
Data Elements
Results:
When the system identifies at least one record that matches the criteria, then for each record the system will display:
STATE
FACILITY_NAME
ORISPL_CODE
UNITID
ASSOC_STACKS
OP_DATE
SUM_OP_TIME
COUNT_OP_TIME
GLOAD
SLOAD
SO2_MASS
SO2_RATE
NOX_MASS
NOX_RATE
CO2_MASS
CO2_RATE
HEAT_INPUT
PRIMARY_FUEL_INFO
SECONDARY_FUEL_INFO
UNIT_TYPE_INFO
SO2_CONTROL_INFO
PART_CONTROL_INFO
NOX_CONTROL_INFO
HG_CONTROL_INFO
PRG_CODE_INFO
Context
(User journeys, design mockups, architectural diagrams, business rules, data element definitions)
Testing
Test Case:
Tester:
Definition of Done

[ ] Have all Acceptance Criteria been agreed to and validated by the scrum team?
[ ] Has the code been unit tested and peer reviewed?
[ ] Have the functional tests been executed?
[ ] Have all defects been reviewed and dispositioned, resolved, or deferred?
[ ] Has the user story been accepted by the Product Owner?
[ ] Is the user story ready to be deployed to the test/staging environments?

During sprint planning on 3/17, the team decided to complete the DE API by creating tickets #967, #968, #969, #970


Can not login when delopy Osmedeus on vps

As you can see,  the request url is http://<IP_ADDRESS>:5000/api/auth. I think it should request http://vps-ip/api/auth. How can i fix the issue?

By default, you can only run Osmedeus on localhost which means you need to ssh on VPS and do a tmux or screen to run it.
If you really wanna do remote access check out protips this wiki page for more detail.

Hi @j3ssie,
I use  ssh forwarding using this command.
ssh -L 5000:localhost:5000 root@vps-ip

Now I can access http://localhost:5000, but still cann't login. The url request is still http://<IP_ADDRESS>:5000/api/auth and <IP_ADDRESS> can't be accessed. I have no idea how to solve it.

Thanks,
Richard

sorry for my typo on ssh command on the wiki. Your command is right
ssh -L 5000:localhost:5000 root@vps-ip

But you need to make sure enable GatewayPorts yes in your /etc/ssh/sshd_config.
I just test it on my machine and it works perfectly.
Can you using netstat or something to check port 5000 is open on your local machine?

I request http://localhost:5000/api/auth, it works . But i request http://127.0.01:5000/api/auth, and it fails.

When i click login button, it will request http://127.0.01:5000/api/auth, rather than  http://localhost:5000/api/auth. So it can not login successfully..

It’s really weird. Could you try ssh command but with <IP_ADDRESS> instead of localhost.

i try  this ssh command.
ssh -L 5000:<IP_ADDRESS>:5000<EMAIL_ADDRESS>

It still doesn't work. Is there any way to change the request url ( http://127.0.01:5000/api/auth) to http://localhost:5000/api/auth?

Hi @j3ssie ,
I solve it when I change to other local machine(Ubuntu). I don't know what's wrong with my previous machine(Mac OS).
Thanks,
Richard Cao

i try this ssh command.
ssh -L 5000:<IP_ADDRESS>:5000<EMAIL_ADDRESS>

It still doesn't work. Is there any way to change the request url ( http://127.0.01:5000/api/auth) to http://localhost:5000/api/auth?

It’s hardcode on the react UI. I’ll add an option to change it on the next release.

@1hack0 Just commit an option to change API destination could you give it a try.
See more details.

Thank you


Separate Authorization From Route

example, instead of:
router.get(/:id${idRegex}, auth('READ'), (req, res, next) => {});
use:
router.get(/:id${idRegex}, auth('READ'))
router.get(/:id${idRegex}, (req, res, next) => {})
and add the option to not expose a route but still use the authorization middleware of exseq

moved to internal bug tracker


Files unexpectedly closes when I do any action inside

Description
I basically open the files and after opening normally, when I try to enter anything from any path it says something went wrong and just closes
Steps To Reproduce

Open Files and try to enter or browse anyway by clicking on anything
It will close unexpectedly informing you that something went wrong

Expected behavior
I expected it would go into normal any of the files or folders that I clicked once or twice to look and see the files
Files Version
V<IP_ADDRESS>
Windows Version
Windows 11 22489.1000 Pro Insider Preview
Relevant Assets
debug.log
debug_fulltrust.log

Thanks for the report. Could you try replacing %localappdata%\Packages\49306atecsolution.FilesUWP_et10x9a9vyk8t\LocalState\settings\filetags.json with the following content?
{
  "FileTagList": [
    {
      "TagName": "Blue",
      "Uid": "3aab30c1-a9f6-4dbd-a3a8-c343b645b177",
      "ColorString": "#0072BD"
    },
    {
      "TagName": "Orange",
      "Uid": "2e1a1dda-688c-4966-a0eb-b28f2315a09f",
      "ColorString": "#D95319"
    },
    {
      "TagName": "Yellow",
      "Uid": "ebba15f5-12f4-4417-bab1-877ae182c171",
      "ColorString": "#EDB120"
    },
    {
      "TagName": "Green",
      "Uid": "5304fa1b-8153-4039-9595-c9dc66e924a1",
      "ColorString": "#77AC30"
    },
    {
      "TagName": "Azure",
      "Uid": "f3714fb0-cfe7-4f01-85c0-fbdda7abde99",
      "ColorString": "#4DBEEE"
    }
  ]
}

I it doesn't work please try to turn off "Enable file tags" option in Files settings Exterimental. (#6605)

Replace the entire file with what you sent me and stopped happening, now it's working normally!

Just an additional comment: when I replace the part you say and put the one you sent and saved, and open it again, it takes, but if I put the tag colors, close it and try to access it again, it does the same error, anywhere that is clickable, I went to look at the file, and when I replace and save with yours and then put the tags, close and open again, it puts it the same way it was before the replacement

Thanks for confirming, merging with #6605. For now you can turn off the file tags feature.

Edit: could you clarify what do you mean by "if I put the tag colors"?

It's just that, when I assign a tag, such as in green, to any file or folder and I don't close the files, it acts with the normal behavior, but if I close it, with the tag assigned to some file or folder and try to open it again, it crashes and closes unexpectedly like in the first situation


Add protocol method for Windows.

Don't know why this method didn't appear on Windows before:)

Thanks @Berrysoft

By the way, when would be the next release? @Thomasdezeeuw

By the way, when would be the next release? @Thomasdezeeuw

Socket2 doesn't have a release schedule. If someone asks I just prepare a release. I can do that this week(end).

Thank you! I would like to see a new release.


Subresource Integrity TagHelper [Discuss]

Something for ScriptTagHelper and maybe a StyleSheetTagHelper?

The website author includes an integrity attribute on JavaScript and CSS tags, specifying the cryptographic digest of the resource being loaded from the third party. When the browser fetches the resource, it computes the file's digest and compares it with the value from the integrity attribute. If the values match, the resource is loaded. Otherwise, the browser refuses to load the resource.

W3C Working Draft http://www.w3.org/TR/SRI/
GitHub blog on it: http://githubengineering.com/subresource-integrity/
Could have a compute hash with local file type approach

Sounds pretty cool. This isn't in the plan for this release, but certainly worth looking at in the future.

Unclear what we could do that was correct and worked at runtime.

I'd like to vote to bring this back...

Unclear what we could do that was correct and worked at runtime.

Given:
<script src="~/dist/vendor.js" asp-append-version="true"></script>

You're already generating a SHA256 hash on the file contents.
This value, base64 encoded, could be exposed as the integrity attribute along with adding the appropriate cross-origin attribute.

Re-opening for discussion. The bug triage team will review again.

@Eilon  - FYI this issue is still closed.
Buuuut I was thinking about this. If we're generating the SRI based on the hash of the file, and our system is compromised, it doesn't actually provide a huge a mount of benefit - we'll just generate a new hash which matches the compromised file and the browser will happily carry on.
It might help in the case where someone meddles with the resource on the wire, but given HTTPS is taking over I'm not sure how much of a concern this is.

Oops, I must have pressed the wrong button! Actually re-opened now.

Moved this out to 2.2.0 as we won't be doing this earlier than that.

@DamianEdwards, any suggestions regarding this?

This is not a priority for the 2.2 release, hence closing again. Let's re visit after 2.2


mintestWithMods: add -- Minetest bundled with mods

Description of changes
The PR adds a simple function pkgs.minetestWithPackages to bundle minetest with mods and add them to the MINETEST_MOD_PATH. The function takes the lead from functions like ghcWithPackages, so minetestWithPackages (mods: [mods.whitelist]) makes the whitelist mod available in the mod path.
The mods that can be installed are bundled in the newly introduced package minetest-mods, which as yet contains only a small selection of mods that I actually use atm but would ideally be generated automatically from contentDB.
The entries in minetest-mods are generated using pkgs/games/minetest/mods/build-minetest-mod.nix, imported there as buildMod, which expects a set with the attributes pname containing the name of the mod and src for the source. This function is derived from the similar function for vim plugins.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@hllizi I finished that contentdb updater I mentioned. Do you mind if I open a pr based on this, integrating the updater and addressing my comments?

@hllizi I finished that contentdb updater I mentioned. Do you mind if I open a pr based on this, integrating the updater and addressing my comments?

Not at all!

@hllizi I finished that contentdb updater I mentioned. Do you mind if I open a pr based on this, integrating the updater and addressing my comments?

I'll lay low until your PR is ready in order to provoke no conflicts.


Add class and extension methods to make obtaining nanosecond time easier

Goal
OTel deals in nanoseconds, but Embrace deals in milliseconds, so lets make it as easy as possible to convert the latter to the former

Current dependencies on/for this PR:

master

PR #340   👈

This stack of pull requests is managed by Graphite.

OTel deals in nanoseconds,

ah yes, another sign of OTel's backend roots....


[WIP] EATT MTU exchange handling

Sample message

@sjanc @rymanluk FYI

Proper solution for this problem is yet to be discussed.


Module name conventions

@abunashir We should follow the asciidoctor extension module naming conventions. Thanks!
e.g.
https://github.com/riboseinc/asciidoctor-bibtex/blob/master/lib/asciidoctor-bibtex/asciidoctor.rb

I'm not currently using any extensions/macros that aren't built in, but I may not be understanding this. @paolobrasolin , if you understand this better, could you take this ticket over as part of your cleanup?

If this was part of the asciidoctor core it would live in Asciidoctor::Converter::RFC2Converter (et. anal. for v3).
The naming convention for extensions would be to name it asciidoctor-rfc and use the base namespace Asciidoctor::RFC. (asciidoctor-bibtex and asciidoctor-bibliography itself are non kosher, actually). Of course there is some variability, but that's what popular extensions seem to be doing.
On side note, I saw two version.rb, one for each api. I'm not particuarly convinced by that, (I'd go with one gem, one version). I'll open an issue about that when I'm actively refactoring.
@opoudjis Sure!

The two version.rb files are indeed wrong, and I was hoping you wouldn't notice. :-) There is no compelling reason to version v3 and v2 separately. Happy for you to get rid of this, or for me to.


Explicit setting of integrations prevents sending of user_hash.

We a have a code that dynamically turns on or off Intercom integration depending on the user.
We hit a condition when it should send it to Intercom but it doesn't. It does try to send it but it's missing the user_hash.
        analytics.identify('id', { ... }, {
          Intercom: { user_hash: 'x' },
          integrations: {
            All: true,
            ...,
            Intercom: true
          }
        });

Removing the explicit setting fixed it.
        analytics.identify('id', { ... }, {
          Intercom: { user_hash: 'x' },
          integrations: {
            All: true,
            ...
          }
        });

However that just a work around and it makes the backend code a bit more complicated now that it has to decide to include the Intercom key rather than just setting the value to either true or false.
It's also setting a trap for developers expecting it to just work.

Hey @more-ron thanks so much for bringing this up. This is definitely a known issue and is a problem that is rooted at our analytics.js library. Basically, the library does not let you use selective integrations AND integration specific options such as the user_hash.
We've added a note internally to address this issue at the platform level.

This is a big deal for me.
I'm using Intercom's secure mode so I have to send the user_hash.
I can explicitly disable Intercom with integrations: { Intercom:false }
But sending integrations: { All: true } doesn't turn it back on.
Is there a workaround aside from forcing a browser refresh?

Hi @more-ron, as part of the monorepo migration, this issue has been moved to new issue. Our engineers have been notified and will prioritize and work on it ASAP. Thank you!
For more information, see README.md.


-o3 for ARM64 platform performance increase

Hi, I noticed that doing -o3 on x86_64 has no noticeable performance changes but compiling with -o3 on ARM64 shows about a 2-3% increase in speed. Would this cause any foreseeable issues?
Here were my results showing the change(I did the test multiple times with different sizes, showing around the same speed increase)

-o2
-o3

real    3m56.909s
real    3m50.971s

You could add additional time for:

-D NDEBUG
-D NDEBUG -flto -fuse-linker-plugin -flto-partition=max -flto-compression-level=0 -ffat-lto-objects,

a) -D NDEBUG -flto -fuse-linker-plugin -flto-partition=max -flto-compression-level=0 -ffat-lto-objects -fprofile-generate,
b) run 5000 iterations on some sample
c) recompile: -D NDEBUG -flto -fuse-linker-plugin -flto-partition=max -flto-compression-level=0 -ffat-lto-objects -fprofile-use
LTO gave most significant gain in my test.

I'm pretty sure floop-nest-optimize would be beneficial in our case. An idea to entertain is also cflags based on arch.

An idea to entertain is also cflags based on arch.

-march=native -mtune=native
Ideally we'd just let the user override the CFLAGs which would mean people could choose what's appropriate for their usecase, but sadly the PR to do this has been stuck in limbo, along with all the other PRs to fix the broken build system.


Fixes for 5.5

As above

Thank you! We went with PR https://github.com/DoubleDeez/MDMetaDataEditor/pull/14 as it maintained 5.0 compatibility.


How to use as a library?

Hi,
I've downloaded the toGeoJson file into my computer (windows 7 64 bit if it matters).
I've added it to my dependency manager (using requireJS).
I can see the file loading, but the toGeoJson is not available in my scope.
Any idea why? Is there another file I need to download?

My bad - I thought the code returns the toGeoJson, but it seems it creates a global and thus my code returned "undefined" in this way:
define(['./module', 'toGeoJson'], function (directives, toGeoJson)
Removing "toGeoJson" from the var list fixed the issue.


Allow Remapping of Disabled windows chortcuts (Win +L)

I am currently unable to remap WIN + L
I thought of fixing it manually  by disabling WIN + L in the regedit.
This did not allow me to remap the shortcut.
As an avid user of vimbindings i would certainly like to be able to bind WIN + L to
Win + RIGHT

Please read the documentation
https://docs.microsoft.com/en-us/windows/powertoys/keyboard-manager#keys-that-cannot-be-remapped

Ive tried the same thing by disabling win L , win L not working now, which is good. coz i totally dont use that.
but  when you remap, it OMG. shit still wont work is there  a way i can patch powertoys repository and remove that validation?
So i can save Windows L to swap with windows arrow-right instead.
thanks for the reply if someone will reply in advance :)

How can i Compile powertoys?
I wanna remove this line , what are requirements so i can compile it on my machine?
https://github.com/microsoft/PowerToys/blob/master/src/modules/keyboardmanager/ui/BufferValidationHelpers.cpp#L224

@goldcoders I know it's been a long while, but I managed to "remap" the  Win + L shortcut, or more specifically, its behavior.
If you run the command Rundll32.exe user32.dll,LockWorkStation, your screen will be locked. So what you can do in PowerToys when remapping a shortcut, is select "run program" (instead of "Send key/shortcut"), use C:\Windows\System32\rundll32.exe for the app path, and user32.dll,LockWorkStation for the arguments. Then whatever shortcut you assigned will lock the screen of your PC.


Repetative waypoints

Challenge http://freecodecamp.com/challenges/waypoint-use-hex-code-for-specific-shades-of-gray has an issue. Please describe how to reproduce it, and include links to screenshots if possible.
I'm not sure if this is intended or not but there are several new way points posted that ask the user to almost exactly the same thing.  Their names are as follows:
waypoint: Use Hex Code to Color Elements White
waypoint: Use Hex Code to Color Elements Red
waypoint: Use Hex Code to Color Elements Green
waypoint: Use Hex Code to Color Elements Blue
waypoint: Use Hex Code to Mix Colors
waypoint: Use Hex Code to Color Elements Gray
waypoint: Use Hex Code for Specific Shades of Gray
All of them are completed by simply changing the Hex value. This may be intentional, I don't know, but I thought I would point it out.

Hey @jstoebel, thanks for posting this!
This does seem intentional, so as to drill this skill into campers.
I am going to close this issue, but feel free to reopen if you feel it is an issue (or annoying for campers)

Hi, the site remains in the challenge: Use Hex Code to Mix Colors, and i have resolved it.


can't start new thread

运行panoptic_fpn时，提示上述错误
OpenBLAS blas_thread_init: pthread_create failed for thread 27 of 64: Resource temporarily unavailable
OpenBLAS blas_thread_init: RLIMIT_NPROC 2063176 current, 2063176 max

You are currently running too many processes.
During the evaluation, panopticapi will create many processes to parallel evaluate the results. You can clean up the useless processes of the system.

You are currently running too many processes. During the evaluation, panopticapi will create many processes to parallel evaluate the results. You can clean up the useless processes of the system.

您好，抱歉再次打扰您，本人太小白，请问无效的进程在哪里查看并清楚呢？谢谢

您好，抱歉再次打扰您，本人太小白，请问无效的进程在哪里查看并清楚呢？谢谢

This problem can be solved with a search engine.

Thanks for your answer！


[Global Styles] Disables buttons' colors are not accessible

This is related to #7378, #7377, #7376, #7104, and #7103.
Accessibility Question:
Does it matter that an element is accessible if it cannot be interacted with?
(Perhaps @Owlbertz might weigh in.)

I think there are two things to consider: people that are (partly) not able to see colors and screen readers (for people that cannot see at all).
For the first case, the disabled style is not accessible for sure because of the pretty low (its 3.01 to 1, needs to be at least 4.5 to 1). I am not sure if there are any hard requirements for the style of disabled states, maybe the cursor could change to the disabled state when hovering?
Regarding screen readers everything should be fine as long as there is the disabled attribute. This is currently not set, but I think this - rather than the class - should indicate the disabled state.

Based on this conversation i'm inclined to say we could use a disabled cursor on them but that its ok they didn't have a correct contrast ratio.
http://ux.stackexchange.com/questions/80881/do-disabled-buttons-still-need-to-be-contrast-compliant-for-accessibility

I agree.
Since W3C says…

1.4.3 Contrast (Minimum): The visual presentation of text and images of text has a contrast ratio of at least 4.5:1, except for the following:

(Level AA) Large Text: Large-scale text and images of large-scale text have a contrast ratio of at least 3:1;

Incidental: Text or images of text that are part of an inactive user interface component, that are pure decoration, that are not visible to anyone, or that are part of a picture that contains significant other visual content, have no contrast requirement.
Logotypes: Text that is part of a logo or brand name has no minimum contrast requirement.

I'm closing this.

Of course, I might make a PR with
.button[aria-disabled="true"] {
  cursor: not-allowed;
}

Is this what you're suggesting, @Owlbertz?

@andycochran There's also .button.disabled and button[disabled].
Although, I'm inclined to say we should recommend just one way to indicate a disabled button, and then only have CSS for that.
@Owlbertz @andycochran What's the difference between using disabled and aria-disabled?

I'm collecting all of the contrast issues into one: #7387


Grid layout not available In our halstack-react

We don't have any component for supporting grid system, so we had to use another third party library to implement grid system and responsive part of the layout.
Please provide required components in our halstack-react library.

Hi @Ragavreddy!
I'm happy to report that the first version of the Grid is already available here. Please, check it out and feel free to share your comments and thoughts about it 🚀 (https://github.com/dxc-technology/halstack-react/discussions/new/choose).
I'm closing this issue, thanks for your patience.


chore: add v1-alpha registration for backwards compatibility

Signed-off-by: Abhinandan Purkait<EMAIL_ADDRESS>

bors try

bors merge


[manager] Update store raft config values for election/heartbeat tick if they don't match the node config.

The store raft config election/heartbeat tick values are mainly used by the UI to show the current config to the user. See https://github.com/docker/swarmkit/issues/2634

Hmm... rebuilt several times and got an error:  command cd "$WORKDIR" && TMPDIR=/tmpfs make ci took more than 10 minutes since last output...


Remove mat-form-field static position

https://github.com/ngx-formly/ngx-formly/blob/77997893b145506bdc15df5db36f17c467c53b89/src/ui/material/form-field/src/form-field.wrapper.scss#L5-L8
The style would cause some other small issues. This solution is useful for some cases and not for some other cases. So I think it would be better to be set for user themselves.

we use position static to solve the following issue https://github.com/angular/components/issues/4580, could you please point me to the other cases that may not be suitable?

https://ng-matero.github.io/ng-matero/forms/dynamic
Please check this page. I have fix the issue by overriding the position: static. You can open the Chrome DevTools and turn off the style to checkout the changing of form field and city select panel.

This issue has been fixed and released as part of v5.10.27 release.
Please let us know, in case you are still encountering a similar issue/problem.
Thank you!


local object detection model running in cpu mode error

I have a problem running an object detection model in cpu mode:
     var mlContext = new MLContext();
     mlContext.GpuDeviceId = null;
     mlContext.FallbackToCpu = true;
     ITransformer mlModel = mlContext.Model.Load(MLNetModelPath, out var _);

The last line produces that error:
System.Reflection.TargetInvocationException
HResult=0x80131604
Nachricht = Exception has been thrown by the target of an invocation.
Quelle = System.Private.CoreLib
Innere Ausnahme 1:
TargetInvocationException: Exception has been thrown by the target of an invocation.
Innere Ausnahme 2:
MissingFieldException: Field not found: 'TorchSharp.torch.CUDA'.
These are the referenced packages:

I hope someone can help me.
Visual Studio 2022
Model Builder 17.17.0.
.net 8.0

The answer was using TorchSharp-cpu 99.5


Minor CSS updates

since I'm a stickler for decent web design

Apparently I forgor💀 to disable mobile view when changing the css via inspect element


Pass http proxy settings into AMQPClient

We noticed that the AMQPClient spawned by a BlobCheckpointStore.from_connection_string and EventHubConsumerClient.from_connection_string were ignoring proxy settings.  This appears to fix things by passing down the http_proxy dict down into the AMQPClient created.

Can one of the admins verify this patch?

Thanks so much for catching this @splbio!
I believe the fix will also need to be applied here to the async client:
https://github.com/Azure/azure-sdk-for-python/blob/master/sdk/eventhub/azure-eventhub/azure/eventhub/aio/_client_base_async.py#L162
@yunhaoling - could you please validate this patch?

I am going to add to the async client as well, re-running tox now to test.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: splbio sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Updated to include async client.  Thank you @annatisch and @adxsdk6 .

/azp run python - eventhub - tests

Getting perms from folks here to sign the CLA, should be done shortly.

Hello @splbio , thanks for the PR.
For eventhub, the proxy setting are being passed in to uamp.authentication object:
https://github.com/Azure/azure-sdk-for-python/blob/d320a5a82c3d48a172ebf844a34afdd15ca12214/sdk/eventhub/azure-eventhub/azure/eventhub/_client_base.py#L168-L188
You can see in the uamqp.AMQPClient, if authentication is being passed, then http_proxy won't be used.
https://github.com/Azure/azure-uamqp-python/blob/master/uamqp/client.py#L91-L109
I have seen an issue talking about IPv6 support, is your PR for that?

Hi @splbio , I'm here reaching out again making sure you're aware of the current situation.
In EH, we always pass mgmt_auth and extract proxy from it, hence this PR would not change the behavior as someone could expect.
IPv4 http proxy is supported while IPv6 not due to limitation of the underlying C library. Issue could be found here: https://github.com/Azure/azure-c-shared-utility/issues/439.
With the above being said, I'm closing this PR Appreciate your collaboration on this very much and will update you once IPv6 gets supported. Feel free to reach out to us if there's other stuff we could help.


DCL Desktop does not warn Unity Dependency

What happened?
Downloaded DCL Desktop and tried starting as guest several times. I downloaded Unity on an unrelated note and made the connection it may be a dependency, now it loads correctly.
DCL Desktop took me all the way up to 99% loading the world before just terminating with a generic error.
Steps to reproduce
Download DCL Desktop, start a session without having Unity installed.
Operating System
Windows 10  (10.0.19043) 64bit
Wallet
None, played as guest
CPU
Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz
GPU
Intel(R) UHD Graphics 620 8135MB
RAM
16270MB
Kernel Version
1.0.0-1990570041.commit-c77c4c3
Unity Version
desktop-main.commit-cedda56
Realm
unicorn
NameTag
dude#a178

The desktop client doesn't have any dependency. You probably were suffering from this issue we had a couple of days ago, now it's fixed: https://github.com/decentraland/explorer-desktop/issues/170


Update input width in _chips.scss sass component

This is a minor but suitable change which updates the width of input field (for adding new chips) from fixed 120px to fit-content, with same !important weight. Also, the min-width and max-width properties are set to limit its size between 100px and 200px. With this change, the input placeholder (if limited to under 200px) will not get cropped, and it will also have a better fit into the input field, thereby offering it more flexibility to adapt the content.
Proposed changes

Basically, this change fixes the issue that I had encountered recently with the placeholder or text of the input before pressing enter to convert it to a chip. Please have a look at how this small change affects the chips input (Screenshot from Google Chrome):
Screenshots (if appropriate) or codepen:

Types of changes

[ x ] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

[ x ] I have read the CONTRIBUTING document.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Yes @DanielRuf sir! Thank you for mentioning! It did actually slip out of my mind when I had made this pull request. I think even the default 'auto' value for width property might not work in the desired way for IE.
Also, can you please tell if the !important weight is really necessary to be used here, as I don't think it is required for the width changes to take effect?
Now, I guess it's time to update this PR.

Regarding the new or old width setting? !important is bad in general.

Regarding the new or old width setting? !important is bad in general.

Actually, it was about the old width setting, as there was !important used with width:120px CSS. Completely agreed, it isn't a good practice to use !important weight in general.
Still, as it was used in the previous code, I didn't remove it for now. Please let me know if in case it has to be discarded.


Port to 1.21

This PR ports PolyForgery to 1.21(.1).
Also:

All textures have been optimized with oxipng, making them a bit smaller
Polydex support is still present
Tier Override information is now visible in the Polydex recipes (i.e. higher tier Alloy Forges sometimes have a higher yield; this is now presented in the Polydex recipe)
Various things have been cleaned up

Thanks for the PR!
I am merging this manually ASAP rebasing on your tree, pushing everything after building and testing.
I am also planning to ship this mod to Modrinth (after ages, I know), I'll make sure to add you as a contributor (as well as any major contributors from the past)

Ah, one thing I forgot to fix is that sgui needs to be jar-in-jar'd (include(...)), since it's not present in any of the dependencies of PolyForgery.

Fixed it, thanks for the heads up
The only issue I noticed is a client failure when building the multiblock, it disconnects with "No value with id 44" so I think that PolyMc is not blocking everything correctly.
This will probably be gone when PolyMc releases since 1.21 is still WIP, so I'll ignore it for now

Manually merged your patches and force-pushed the new up-to-date tree to the 1.21.1 branch, thanks again!

Release out on GitHub: v2.1.0+1.21.1 - Update to 1.21.1, Compressed Textures and Polydex is back!
Waiting for TheEpicBlock/PolyMc v5.7.0 for the Modrinth release


layout: 'position is undefined' on remove()

I have an <a-entity layout> (el) containing <a-plane> children to which i have given no position. if I do el.components.layout.remove() it comes back saying position is undefined in setPositions(), initialPositions[] seems to be empty at the time. No luck when I gave them position attributes either. No luck if I add the children first then add the layout component after say 1sec. Some luck if I wait much longer (5 sec) though newly/subsequently added children do not seem to be picked up. Layout type is 'box'.
expected: it doesn't try to restore position of children if it hasn't picked up their positions correctly
actual: breaks

ps i cannot find where this.childAttachedCallback comes from in this.el.removeEventListener('child-attached', this.childAttachedCallback); in remove() ? is this some aframe magic?


Use SPDX identifier in license field of META6.json

Use the standardized identifier for the license field.
For more details see https://design.perl6.org/S22.html#license

Thanks a lot!


Enhance TiFlash DDL Tests

Enhancement
The DDL module is lack some integrated tests, including

the case when multi DDL actions happen closely, and there are some corresponding insert actions between these DDL actions.
the case that the schema change parts of a lossy DDL action arrive at tiflash node among different epoches of the periodic schema sync.

Thus, we need to enhance tests to improve the correctness guarantee of our DDL module.

\assign hongyunyan

/assign hongyunyan


New version: FranklinTemplates v0.9.0

Registering package: FranklinTemplates
Repository: https://github.com/tlienart/FranklinTemplates.jl
Created by: @tlienart
Version: v0.9.0
Commit: 981e1143e6872f04a197c8c4fdb11a042a7b1589
Reviewed by: @tlienart
Reference: https://github.com/tlienart/FranklinTemplates.jl/commit/981e1143e6872f04a197c8c4fdb11a042a7b1589#commitcomment-84247081
Description: Simple website templates for Franklin.jl

blocked for now following suggestion in https://github.com/JuliaRegistries/General/pull/66219

can this be unblocked now that LiveServer 1.0 is out?

[noblock]

@greimel I'm not 100% sure whether that will solve it but could you edit your comment above and put [noblock] in it? Otherwise I'll have to bother a maintainer which I unfortunately do too often


Provide option to override 'out.json' file name in writeIstanbulFormat

The file is being overwritten every time a new test suite runs (more precisely, every time "write" is being called), making it impossible to merge the code coverage for multiple test suites.
If separate files are generated for each test suite, then a merged report can be created with "nyc report".
For example, at the end of a test suite I can put something like this:
afterAll(async () => {
    const [jsCoverage, cssCoverage] = await Promise.all([
        page.coverage.stopJSCoverage(),
        page.coverage.stopCSSCoverage(),
    ]);
    await pti.write([...jsCoverage, ...cssCoverage], {outputName: 'my-test-output'});
    }
});

and then use that option in https://github.com/istanbuljs/puppeteer-to-istanbul/blob/master/lib/puppeteer-to-istanbul.js
line 27:
   const outFilePath =${this.storagePath}/${this.options.outputName || 'out'}.json
This way the test suites will generate separate files, that can be at the end merged with "nyc report".

This issue is still open. Any ETA on fixing this overwriting logs behavior? Or any work around?

Upvoting on this. I have to run one test, rename it before I can run the next one. Should be an easy fix as babao suggested.


Add unit tests for Bundler::Source

Updated the PR.

👍

@homu r+

:pushpin: Commit 1ab9524 has been approved by segiddins

:zap: Test exempted - status


Exception when creating credential offer: Error: Wallet item not found

Hello everyone, I have an issue. I created and stored the schemas and credential definition into the ledger. I would like to issue the credential to holder so, I received the proposal from the holder then, I want to send back the proposal of holder by using issue-credential-2.0/records/{cred_ex_id}/send-offer but I received the error
aries_cloudagent.indy.issuer.IndyIssuerError: Exception when creating credential offer: Error: Wallet item not found
Caused by: Item not found
Caused by: Query returned no rows

Thank you very much for your help.

Did you use the same storage database (aka wallet) for creating the objects as when you are trying to issue?  From the look of the issue, it appears you are using a different database for the agent.  For example, if you created the ledger entries in one docker session, removed and created a new docker container, the private objects related to the ledger entries would be lost. You can't recreate them and you can't issue credentials without them.

@swcurran I think I did not change to another database because after running the docker, I worked on testing only the API of ACA-Py. here is my script to run the docker

But I remembered I created and stored the schema and credential definition to ledger then, I shut down PC. Next day, I run the above script again for creating the agent and finally, I met the problem as I mentioned when I want to issue the credential. (I do not know what I did is affected to my testing or not.)

@swcurran I used schemas/{schema_id} & credential-definitions/{cred_def_id} by inputting the schema_id and cred_def_id respectively, I can get the list of the schema and credential definition.

{Update} @swcurran I run from starting without shutting the PC, finally, I can issue the credential. I think after shutting down, the ledger state was resetting and when I want to issue the credential, it cannot find the entries in the previous ledger state. Thank you very much for your comments.


Amazon Bedrock Workshop - [Bug] 02_qa_w_rag_claude_opensearch.ipynb hardcoded to use us-east-1

Describe the bug
The following code in 02_qa_w_rag_claude_opensearch.ipynb will throw an error if the AWS_DEFAULT_REGION is not set. Update to retrieve the region dynamically, e.g. boto3.session.Session.region_name. Do not hard code the region.
from opensearchpy import OpenSearch, RequestsHttpConnection, AWSV4SignerAuth
from langchain.vectorstores import OpenSearchVectorSearch

service = 'aoss'
credentials = boto3.Session().get_credentials()
auth = AWSV4SignerAuth(credentials, os.environ.get("AWS_DEFAULT_REGION", 'us-east-1'), service)

The following line in 02_qa_w_rag_claude_opensearch.ipynb will also throw an error if the REGION is not set:
host = collection['createCollectionDetail']['id'] + '.' + os.environ.get("AWS_DEFAULT_REGION", None) + '.aoss.amazonaws.com:443'

None is not an appropriate value if the variable is not set.

I agree, can you do a quick PR @jicowan ? Thank you for catching this and improving our examples


LIMIT and OFFSET should support expressions

Even though it is technically possible to pass expressions to LIMIT and OFFSET, the docs.Take and docs.Skip operators expect integers, which doesn't make them very flexible.
The docs.Take and docs.Skip operators should take an expression instead of an integer, evaluate the expression and cast it to integer.

Fixed by https://github.com/genjidb/genji/commit/6178d1acfb341950f83631a48132fde3b78382bf


[SIS-021] Bottom navbar styling

Description
Styled the nav bar. The underline has not been implemented though. New dependency: react-native-svg-transformer

Ticket #21
Type of change
Please delete options that are not relevant.

[ ] New feature (non-breaking change which adds functionality)

Checklist:

[x] My PR title is formatted as [SIS-<issue number>] <issue name> (eg. [SIS-010] Create UI button)
[x] I have linked my issue/ticket on the project board to this PR
[x] I have sent my PR to #team-sistema-prs on Slack and requested two people to review
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation (if required)
[x] My changes generate no new warnings
[x] I have tested that my feature works as expected on Android and iOS. If you are a Windows dev, please request a Mac dev to run your branch. If it's a front-end change, I have attached screenshots of what the result looks like on both platforms.

Added underline and made tabIcon into component with this commit

Can you comment on the changes ppl suggested above? And resolve the merge conflicts, thanks! Then, request either Ramy or me to merge.

Fixed android padding and updated screenshot


dashboard/app: allow main UI to show bisect results

Modify uiBug type. Rename BisectCause to BisectCauseDone. Introduce BisectFixDone.
Modify createUIBug() and MergeUIBug() to set the above fields appropriately.
Modify bug_list to display the bisection status; remove yesSort() as it is not used anymore. Adjust ".list_table .stat" to appropriate width.
Add TestBugBisectionStatus() to check bisection status on main page.
Add file from running "make generate": pkg/html/generated.go

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@835dffe). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #1308   +/-   ##
=========================================
  Coverage          ?   57.67%
=========================================
  Files             ?      131
  Lines             ?    24661
  Branches          ?        0
=========================================
  Hits              ?    14222
  Misses            ?     9765
  Partials          ?      674

Impacted Files
Coverage Δ

dashboard/app/main.go
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 835dffe...fc8e83b. Read the comment docs.


Cannot install due to wrapt errors

Here is the partial stacktrace for your reference:
Installing collected packages: astor, keras-preprocessing, keras-applications, absl-py, setuptools, tensorboard, tensorflow-estimator, termcolor, gast, google-pasta, wrapt, tensorflow, toposort, gpt-2-simple, gpt2-client
  Found existing installation: setuptools 40.8.0
    Uninstalling setuptools-40.8.0:
      Successfully uninstalled setuptools-40.8.0
  Found existing installation: wrapt 1.10.11
Cannot uninstall 'wrapt'. It is a distutils installed project and thus we cannot accurately determine which files belong to it which would lead to only a partial uninstall.

I have reproduced this issue with Py3.7 Anaconda on both Mac and Linux (Debian 9.9)

Thanks for the heads-up. I'll see what I can do about it. This bug never came up during unit testing

@NirantK see this tensorflow issue.  It has several suggestions for fixing the issue.

That worked. Thanks.