Tezos baking app cannot sign seed nonce reveals

It is the duty of every baker to reveal nonces that they may have submitted in cycle N, as a reveal operation in cycle N+1. If a baker constructs a block where ((level % 32) == 0)*, then they should also generate a nonce and a seed, and attach the nonce to the protocol header of the forged block.
In cycle N+1, the baker must then reveal the seed used to generate the nonce using a seed_nonce_revelation operation.
Looking here, https://github.com/LedgerHQ/app-tezos/blob/c0ad5de4ac25d58fbe6c995398845803bb19fecf/src/baking_auth.c#L90, I do not see the ability to parse a revelation and in fact it looks like the ledger would reject this signing request since a seed_nonce_revelation length is greater than endorsement_wire (baking_auth.c#L95)
The magic byte of a seed nonce revelation is 0x02, the same magic byte as an endorsement.
seed_nonce_revelation operation contents:
{
	"branch": head.hash,
	"contents" : [{
		"kind" : "seed_nonce_revelation",
		"level" : nonce.level,
		"nonce" : nonce.seed,
	}]
}

Endorsement operation contents:
{
	"branch": head.hash,
	"contents" : [{
		"kind" : "endorsement",
		"level" : head.header.level,
	}]
}

Has the baking app been missing out all this time on the ability to sign nonce reveals? When I submit a nonce reveal to the ledger, I get back EXEC_PARSE_ERROR (0x9405), presumably because of the check at baking_auth.c#L95
$ { echo<PHONE_NUMBER>048000002c800006c18000000080000001; echo 800481004a02ed9d217c610426bc30ca15f5ec801aaa905eb236ba8417165db63ae080f4fa3e9a11f6b501000569d3f8492f0fe9df743870d39cca3e4b5f9af3413bfe662d8df16c2410c2a1588331; } | python3 -m 'ledgerblue.runScript' --apdu
HID =><PHONE_NUMBER>048000002c800006c18000000080000001
HID <= 9000
<= Clear bytearray(b'')
HID => 800481004a02ed9d217c610426bc30ca15f5ec801aaa905eb236ba8417165db63ae080f4fa3e9a11f6b501000569d3f8492f0fe9df743870d39cca3e4b5f9af3413bfe662d8df16c2410c2a1588331
HID <= 9405

* https://mainnet-tezos.giganode.io/chains/main/blocks/head/context/constants  "blocks_per_commitment":32

It should also be noted that the level submitted in the nonce reveal will always be less than the watermark.

This may not be an issue after all. Trying to confirm if nonce reveals even need to be signed.

Nonces don't need to be signed. Chasing a moot point.


ADB hosts plugin

I'm not sure if this is correct. But this just reads the /system/etc/hosts file, which always seems to have the default content
<IP_ADDRESS> localhost
::1       ip6-localhost

Has anyone seen anything else there?
On the other hand, there is an adb_keys file under /data/misc/adb, which has key and last connected system info like this:
<<KEY>> user@system
<<KEY>> user@system

It was generally created because of the Magnet CTF, which did have some different hosts configured

It was generally created because of the Magnet CTF, which did have some different hosts configured

Perhaps we should rename it to something else more appropriate, as simply connecting to phone via adb would not alter this file.

Sure go for it!

Any suggestions? Since I haven't seen the altered file, I have no idea what it might have contained, or what it might have indicated. I'm guessing just IP addresses or host names hardcoded.
The plan would be to rename this, then parse hostnames from adb_keys file under a plugin with same name 'adb_hosts'.

I renamed to Etc Hosts.

That works, thank you!


Bug with evaluating SQLs containing "value" identifiers

I download spider dataset from Spider Leaderboard.
When I run the command:
python evaluation.py --db spider/test_database --etype exec --gold spider/test_data/dev_gold.sql --pred spider/test_data/dev_gold.sql
Then returns:
easy                 medium               hard                 extra                all
count                470                  857                  463                  357                  2147
=====================   EXECUTION ACCURACY     =====================
execution            0.996                0.977                0.983                0.994                0.985
However, in above command, the gold file and pred file are the same.
I find the problem in evaluation.py, code link (line# 569):
https://github.com/taoyds/test-suite-sql-eval/blob/e97acc546ecbee8fa27fa8dbf025ef61493a876c/evaluation.py#L569C13-L569C48
When predicted sql contains "value" identifiers (e.g. a column called "value"), p_str = p_str.replace("value", "1") replace string "value" in predicted sql incorrectly.

When I delete p_str = p_str.replace("value", "1"), the evaluation returns 100% execution score as expected.

@taoyds @rizar @ruiqi-zhong


Version reported as unknown at least on 1.28.0 on Linux x64

Steps to reproduce
Run neonctl -v
Expected result
Something along the lines of:
❯ neonctl -v
1.28.0

Actual result
❯ neonctl -v
unknown

Environment

Fedora 39 x64
Node 20.9.0

I haven't tested the other builds or other versions to see if this is just an issue with 1.28.0

I was able to reproduce with 1.36.0. Root cause seams to be default behavior of https://yargs.js.org/docs/#api-reference-versionoption-description-version

If no arguments are passed to version (.version()), yargs will parse the package.json of your module and use its version value.

which seams to be doing a lookup of nearest package.json.
Since neonctl is installed somewhere in node_modules, the result of npx neonctl --version can be either unknown or version in nearest package.json.
steps to reproduce
mkdir foo && cd $_
npm init --yes
npm install<EMAIL_ADDRESS>npx neonctl --version

expected
1.36.0

actual
1.0.0


Add custom widget in text field

Is your feature request related to a problem? Please describe.
Im missing a feature to add custom widget in textfield (i.e. #dart) shows hastags, upon clicking, it adds it, i would like to have chip that holds another data inside.
Describe the solution you'd like
upon clicking on autocompleted findings -> save to text #dart:123 (chosen String by developer) but shows custom widget.
Describe alternatives you've considered
https://pub.dev/packages/extended_text_field but its chaotic and no clear way.
Additional context
i want exactly discord behavior with @ sign (they show @name but holds internally userid)

Hey @MichalNemec, can you share a sample UI around your request?

I actually managed to make it happen in extended_text_field, grabbed @mention and modified it to my needs. So there is no need from your side. It actually makes sense what you did with this library. Its up to the user to manipulate content in textfield. So sorry to bother you.


[SPARK-30461]Web UI link when expanded should change the status from collapse to expand state(-details)

What changes were proposed in this pull request?
(+details) link when expanded should change the status from collapse to expand state(-details)
Why are the changes needed?
To improve end-user Web UI experience (It's good to change the state from +details to -details, during expanded operation)
Does this PR introduce any user-facing change?
Yes

How was this patch tested?
Manual testing.

Can one of the admins verify this patch?

Can one of the admins verify this patch?


Add depotShipperLabel. Update coverage options.

@VitaliiPl Many thanks for your contribution. Sorry it took over a year to merge 🙈


add youtube thumbnails

Adding youtube thumbnails to front page resources section.
I'm sure this can be done in a more failsafe and prettier way, but it's a start I guess. :innocent:

→ https://deploy-preview-99--fluxcd.netlify.app/#resources
LMK what you think.


Wrong redundant bracket suggestion with BlockArguments.

This code
{-# LANGUAGE BlockArguments #-}
foo = (Just \x -> x || x) *> Just True

yields this:
hlint.hs:2:7-38: Suggestion: Redundant bracket
Found:
  (Just \ x -> x || x) *> Just True
Perhaps:
  Just \ x -> x || x *> Just True

But this is plainly wrong, as the lambda will max-munch the whole line.

Thanks for the report. Yep, a definite bug - it used to be the case that applications inside infix applications were always unnecessary brackets - but block arguments changes that. Will investigate.

I've added an extra case that non-atomic non-apps in the RHS of an App on the LHS of an operator definitely require brackets. I'm not totally confident I've caught all the cases that BlockArguments introduces, but I definitely got the one above. Please report any other weirdities you find.


01

Setup
Versions

Rust:
Diesel:
Database:
Operating System

Feature Flags

diesel:

Problem Description
What are you trying to accomplish?
What is the expected output?
What is the actual output?
Are you seeing any additional errors?
Steps to reproduce

Checklist

[ ] I have already looked over the issue tracker for similar issues.
[ ] This issue can be reproduced on Rust's stable channel. (Your issue will be
closed if this is not the case)

Good.


Toggle preview window mapping

I find the preview window useful, however, I would prefer if I can use a mapping, like p , to toggle the preview window for the symbol when I don't need the preview.

Linked to #49

Nevermind, #49 only shows the preview window and doesn't toggle it.


TestCases for getList and codeList (LanguagesTable)

New TestCases for the getList and codeList from the LanguagesTable

Coverage increased (+0.3%) to 14.643% when pulling 736a0d7fddb1ada1f4493bf6aa5fc8cc9c9c6a9a on mp-network-development:bugfix/groupbyfix into 10eba70144d560efb24e1847c492a1fb91b02585 on dereuromark:master.


Interactive window debug test is consistently failing

Error: FAILED TEST NAME: Interactive Window Debugging Debugging with VSCodePythonDebugger Debug a cell from a python file
Code lens with command jupyter.debugcell not found
Error: Code lens with command jupyter.debugcell not found
at Timeout. (src/test/common.ts:56:20)
at listOnTimeout (node:internal/timers:557:17)
at processTimers (node:internal/timers:500:7)
From this run here:
https://github.com/microsoft/vscode-jupyter/runs/6944057287?check_suite_focus=true
Screenshot looks like code lenses never activate:

Maybe we can change the test to just call the code lens provider directly? We don't need to verify code lenses are working in VS code, we just want to use the command that it puts up.

Duplicate of https://github.com/microsoft/vscode-jupyter/issues/11917


[machine-generated WIP] List of outdated casks

This issue is being auto-generated with find_outdated_appcasts.

@adidalal I take it you aborted the script?

Correct - was using the wrong script.


Multisite with subdomains instead of subdirectories?

Hello there! I was curious if there was a way for me to be allowed to use, or be given the choice of, using subdomains instead of subdirectories for a multisite setup.
I noticed in the install.rb file, lines ~231-245, that there is a wp core command that sets it to multisite-convert.
# install.rb
if node[:wpcli][:is_multisite] == true then
  bash "Setup multisite" do
    user node[:wpcli][:user]
    group node[:wpcli][:group]
    cwd File.join(node[:wpcli][:wp_docroot], node[:wpcli][:wp_siteurl])
    code "WP_CLI_CONFIG_PATH=#{Shellwords.shellescape(node[:wpcli][:config_path])} wp core multisite-convert"
  end

  template File.join(node[:wpcli][:wp_docroot], node[:wpcli][:wp_home], '.htaccess') do
    source "multisite.htaccess.erb"
    owner node[:wpcli][:user]
    group node[:wpcli][:group]
    mode "0644"
  end
end

According to the documentation for the wp-cli: http://wp-cli.org/commands/core/

multisite-convert	Transform a single-site install into a multi-site install.
multisite-install	Install multisite from scratch.

I'd like to be able to use the multisite-install command instead. As I understand it, this will allow me to have the choice (via the super admin dashboard) to choose between using subdomains or subdirectories for my multisite setup.
If there is a different way for me to be able to use subdomains for my multisite setup, definitely let me know. Thank you! :smiley:

Hello again, I did a bit more research and  looking at the options for multsite-convert, it says:

[--subdomains]
If passed, the network will use subdomains, instead of subdirectories. Doesn’t work with ‘localhost’.

Just to see what happens, I added the --subdomains flag after the wp core multisite-convert command on line ~236 of install.rb. After doing so, I am now able to use subdomains instead of subdirectories for my multisite setup! Yay! :smile:
Would it be challenging to make this an option so I can pass the --subdomains flag via the site.yml, for example?

Hello again, it appears there is a bit more than just adding the --subdomains flag to make subdomains work. One thing I hadn't considered is the fact the hosts file would also need to be updated once a new subdomain is added.
Once again, I'll pose my original question, is there a way for me to use subdomains instead of subdirectories for a multisite setup using vccw?
Thanks for your time! :smiley:

@mrgerardorodriguez
I found following.
http://asciithoughts.com/posts/2014/02/23/setting-up-a-wildcard-dns-domain-on-mac-os-x/
Have you ever tried it?
It looks fine ... but I haven't tried yet. :smile:


Extension causes high cpu load

Issue Type: Performance
Extension Name: live-sass
Extension Version: 4.4.1
OS Version: Windows_NT x64 10.0.18363
VSCode version: 1.53.0

:warning: Make sure to attach this file from your home-directory:
:warning:c:\Users\bpgpo\AppData\Local\Temp\glenn2223.live-sass-unresponsive.cpuprofile.txt
Find more details here: https://github.com/microsoft/vscode/wiki/Explain-extension-causes-high-cpu-load

Hi @billpebert,
Sorry to hear you're having this issue, although I'm pretty sure I know what the issue is.
I'm aware of a bottleneck issue with our glob pattern matcher in larger projects. This will be fixed in v5 when we move from glob to fdir (ref: #27).
Can you please see the below and answer my questions. If my suspicions are correct then the forceBaseDirectory setting will help.

⚠ Make sure to attach this file from your home-directory:
⚠c:\Users\bpgpo\AppData\Local\Temp\glenn2223.live-sass-unresponsive.cpuprofile.txt

I'd need this file to help debug the issue. Please visit the above path on your local machine and attach it to this issue

Please can you answer the below, I have included my suspicions after each question

Is this when saving or when VS Code loads?

When you save all files (i.e. from the command liveSass.command.oneTimeCompileSass or saving a partial file)

How many files (total, including non-sass) does your workspace have?

Thousands

How many of those files are SASS files?

Less than 100

Have you tried the forceBaseDirectory setting?

Not yet

Closing as need more info


OptionsFlow changes

Missing changes for the implementation of the OptionsFlow

@marcoboers, these are the missing changes for the 0.60b release.
I don't know why these were missing but these are needed for the optionsflow functionality to work correctly.


Install missing package

Not buildable, needs xunit.runner.visualstudio

I think you are refering to an old version because the current packages.config already have xunit.runner.visualstudio, can you check ?

Confirmed. This comes from bitcoinbrisbane:master which comes from NicolasDorier:master  f021280458c646f3b8c74b8b83a05d2c1b3a8563 so, yes it is an old. The reference was included in ea1acdbd2a1e90d50ca0a8a1ddea3e9fdba1403a as part of the "Update Sqlite" commit

Sorry guys, new VM and didn't sync properly.


Add functionality to unfollow one's own observation

From: https://forum.inaturalist.org/t/create-a-way-to-unfollow-ones-own-observations/103
One is subscribe to one's own observations automatically, and there's no easy way to unfollow one's own observation. Some users don't want notifications for new ssp IDs and such, so they're requesting that the same "Follow" button be added to their own observations. I would say let's put it to the left of the blue Edit buttons, but am open to other suggestions. It should also only show the unfollow observation option, not the user following option.

I'm not sure how to accomplish this. People can subscribe to others' content, but there is no actual subscription to one's own observations. Rather the code will just alert the observer for relevant actions. We don't have the concept of an "unsubscription", and since users aren't "subscribed" to their own content there is no subscription to be removed.
I guess we could add a preference to observations that say don't alert the observer when new content is added. We also need more detail as to what this would do. Sounds like they don't want notifications on IDs, but would the user still get notifications comments on the observation? Mentions?

I think the impetus behind this request was mainly to not be notified of subspecies IDs. Withe notifications revamp, that won't be necessary so I'll close this.


[BUG] Calendar showing all months instead of one

Describe the bug
The non-compact view shows all year in one view. Making it impossible to reach some part of the months.
To Reproduce
Open Calendar in non-compact view.
Expected behavior

Screenshots

Foundry Information

Foundry Version: 10.286
Game System: DnD5e 2.0.2
Simple Calendar Version: 2.1.18
Simple Calendar Configuration: Default, I think?

Browser (please complete the following information):

Browser Chrome

this is fixed in 2.1.19.. I had accidentally left an experimental year view on.
my bad and sorry about that.

No worries mate.
Thanks for the quick fix!
Also, the new view look great, might need some tweaking though. But that is what experimental means!


Server: add setup option to create a superkey

./iglu-server setup --config /path/to/config --masterKey $(uuid-get) add random UUID as a master API key.

Specific environment variable would be even better

Migrated to https://github.com/snowplow-incubator/iglu-server/issues/11


where is the method "before" and "after" in HttpServer?

where is the method "before" and "after" in HttpServer?

Do you mean how to receive request and send response?
Wfrest is based on workflow, you can see source code from https://github.com/sogou/workflow.
Here are some articles about how dose HTTP server work : https://github.com/sogou/workflow/discussions/656

No.
Method "before" and "after" similar your method "GET" or "POST" in Class of HttpServer.
The method "before" running before GET/POST  by the same path,
and the method "after" running after GET/POST by the same path.

Can you show me how other frameworks use these two interfaces? Thanks.

I've got it, you mean AOP.
Working on supporting it...

Yes,it's AOP.
but,you'd better to make a method in HttpReq  to get path of current route.
eg.
...
    HttpServer svr;
    svr.GET("/page1", [](const HttpReq *req, HttpResp *resp)
    {
        std::string str = "Page information:\r\nPath:";
        str += req->get_current_path();//TO DO
        resp->String(std::move(str));
    });

    svr.BEFORE("/**", [](const HttpReq *req, HttpResp *resp)
    {
        std::string str = "AOP information:\r\nPath:";
        str += req->get_current_path();//NEW AND TO DO. example result: "/**"
        str += "\r\nTarget Page Path:";
        str += req->get_target_path();//NEW AND TO DO. We have to get path of route in GET/POST/PUT/DELETE/PATCH/OPTION/HEAD.example result: "/page1"
        resp->String(std::move(str));
    });
...

Ok, thanks for your suggestion!

Support AOP now, you can see the example: https://github.com/wfrest/wfrest/blob/main/example/18_aop.cc

Yes,it's AOP. but,you'd better to make a method to get path of current route in HttpReq.
eg.
...
    HttpServer svr;
    svr.GET("/page1", [](const HttpReq *req, HttpResp *resp)
    {
        std::string str = "Page information:\r\nPath:";
        str += req->get_current_path();//TO DO
        resp->String(std::move(str));
    });

    svr.BEFORE("/**", [](const HttpReq *req, HttpResp *resp)
    {
        std::string str = "AOP information:\r\nPath:";
        str += req->get_current_path();//NEW AND TO DO. example result: "/**"
        str += "\r\nTarget Page Path:";
        str += req->get_target_path();//NEW AND TO DO. We have to get path of route in GET/POST/PUT/DELETE/PATCH/OPTION/HEAD.example result: "/page1"
        resp->String(std::move(str));
    });
...

You can see here : https://github.com/wfrest/wfrest/blob/main/example/02_parameter_path.cc

The current AOP design of wfrest has some problems. Some advices:

Add 'void *user_data' to HttpResp, and remove it's 'series()' interface. 'before' can use this field to pass data to handler.
'after' should be called after reply, and a 'error' field can be added to HttpResp reflecting the status of replying.
If resp's 'user_data' needs to be deleted, delete it in 'after'.


Shiny Apps Deployment

This PR adds a workflow to deploy to ShinyApps.  Work in progress is deployed to /data_curator-staging.  When a release* branch is created the app will be deployed to /data_curator.  This allows us to develop and test while the production version continues to run.
Besides adding the workflow, this PR:

modifies global.R to unzip and activate the virtual environment.
modifies install-pkgs.R to add some R packages that seem to be needed and to use R Studio's binary package distribution, which dramatically speeds up the build.
modifies server.R to correctly use the OAuth access token obtained during use login.  The existing app' wrongly uses the Synapse access token from the browser cookie which (1) gives the app' unlimited "scope" in accessing the user's Synapse account and (2) will only work when the app' is hosted in the *.synapse.org domain.  This change fixes both problems.  The app' can be hosted anywhere!

Before merging the PR, set the following parameters in the data_curator GitHub repo' (under Settings > Secrets > New repository secret):

REPO_PAT: This is a GitHub personal access token having (at least) 'repository' scope.
RSCONNECT_USER: sagebio
RSCONNECT_TOKEN: See the token in the shinyapps.io record in LastPass.
RSCONNECT_SECRET:  See the secret in the shinyapps.io record in LastPass.
OAUTH_CLIENT_ID: Use 100132 or create your own.
OAUTH_CLIENT_SECRET: If you use 100132, retrieve the secret from the ShinyApps Synapse account record in LastPass.

Thanks @brucehoff I added the secrets you noted above to the repo and am going through the PR; using oauth client id 100132 while we are testing.

Thanks for the review, @milen-sage .  I do not have permission to merge the PR so could you either grant me permission or merge the PR yourself?  Thank you.


Reason for window.location is been used and not router.query

Hi all
I was just wondering why this package is getting the query based on location object and not the router.query. Isn't the whole point of router.isReady when the Next code is ready to safely read router.query object?
https://nextjs.org/docs/api-reference/next/router#router-object
isReady: boolean
Whether the router fields are updated client-side and ready for use. Should only be used inside of useEffect methods and not for conditionally rendering on the server. See related docs for use case with automatically statically optimized pages

It had to do with optimisation to avoid infinite re-render loops, not sure if it is still relevant. I didn't know about the isReady attribute, thanks for pointing it out.
Related: https://github.com/47ng/next-usequerystate/issues/282#issuecomment-1029579799

Sames goes for the previous version of this package where you used asPath. I guess you changed that because of exactly this comment?
Using the asPath field may lead to a mismatch between client and server if the page is rendered using server-side rendering or automatic static optimization. Avoid using asPath until the isReady field is true.

@franky47 I think this package should rely only on the router and nothing else. I have tried implementing something similar as this package with asPath and window object and you will end up in edge cases you can't solve. I have only bad experience with location object and router combined 🙂

@TommySorensen,  depending on router for reading query params causes a whole heap of problems.  What you say is probably true for navigation.

Problems arise waiting on is Ready. Presumably the initial value of the state should resolve as query param value then default value. This means the created state variables will not have an initial value.  A lot of code assumes states will have an initial value.

When calling push or replace on the router a new router is created. So if you want a set state that updates the router and also waits for router.isReady and uses it as a dependency, you end up with an infinite loop.

If you have a working example that avoids these pitfalls, please share.


no module main

Hi tryinig to use this in windows 7 64 bits 3.5 python
by pip or by git
no errors during the pip install
when i import pyspeech got this one :
import speechpy

ImportError                               Traceback (most recent call last)
 in ()
----> 1 import speechpy
c:\anaconda3\lib\site-packages\speechpy_init_.py in ()
----> 1 from main import *
2 from processing import *
ImportError: No module named 'main'

Thank you so much for your attention and pull request ... The package has been tested on Python versions 2.7 and 3.4. The ImportError: No module named 'main occurs on Python version 3.5, so I confirm that. I am working on it and try to solve it.
I appreciate your patience and feedback.

Maybe you should wrtie in on the github project main page that it's for the moment only working with 2.7.
As people may think that the soft is not finished or not properly validated

You are absolutely correct ... Thank you so much for your feedback.
Regards,
Sina
On Thu, Jul 13, 2017 at 10:37 AM, alain2208<EMAIL_ADDRESS>wrote:

Maybe you should wrtie in on the github project main page that it's for
the moment only working with 2.7.
As people may think that the soft is not finished or not properly validated
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/astorfi/speech_feature_extraction/issues/1#issuecomment-315097209,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AM1mQxP-sgz6MWuagEVTOCLtOkHuLa3Qks5sNiuggaJpZM4OV9Iy
.

--
Amirsina Torfi PhD.E.E
GRADUATE RESEARCH ASSISTANT
West Virginia University
Statler College of Engineering and Mineral Resources
Lane Dept. of Computer Science and Electrical Engineering
Mobile:<PHONE_NUMBER> <(304)%20218-9158>
Email<EMAIL_ADDRESS><EMAIL_ADDRESS>

@alain2208 Python >=3.5 did away with local imports, or rather, gave them a different syntax. You can hack the files in c:\anaconda3\lib\site-packages\speechpy to use the updated import path specs. Eg:
from main import * --> from .main import *
import processing --> from . import processing
Or you can clone his repo, make the changes locally and then run setup.py (but the first method will get you there faster :)

@peragwin Thank so much ... Using your help, now Python 3.5 is supported with the local installation.

@alain2208  Python 3.5 is supported now. Please check to see if it's working for you.
Thanks

Hi it works with the git clone install not with the pip one as far as i can see. i still have the error when using the pip install even using the pip install --upgrade option.

in fact i had to totally remove using pip and force a new download and then re install it to make it wor with new version.
My previous comment came from that i was using it inside the folder when i git clone it and it was working and when i was doing th other test it was from another folder I think.

@alain2208 So your problem is solved now?

yes it is thanks. Will now try to play with it


Would it be possible to break up the -core module into separate modules for each DB

We're trying to develop support for OrientDB, but we noticed that since every DB is referenced in the flyway-core module, it looks like we need all the drivers for all the DBs installed and available.
Could the core module not be broken up into flyway-core, and then a whole series of flyway-db-xyz modules that would contain the .sql resources and appropriate files for that specific DB
The core module could run a classpath scan for an annotation on startup to find and register all the various DB flavors, and then ask each implementation for the name of the DB that they support (so that the hardcoded list of DBs in DbSupportFactory can be replaced with a dynamic list).
If each module was separate (for each DB), then we could develop support in isolation without having to worry about all the other DBs that we're not touching/impacting.

This is not something I am considering at this point. However, please note that you do not need all drivers installed. You can run the build using mvn -P-CommercialDBTest to avoid all drivers not available on Maven Central. There are additional profiles available in the POM if you also want to disable all open-source non-inmemory DBs (PG, MySQL, ...).
Cheers
Axel


Apps draw over system bar when you open a full screen app and then go back to your launcher

To replicate - open a fullscreen app such as Yahoo weather, Snapchat, etc. Then go back to your launcher. You'll see that the apps draw over the system bar. You need to redraw the launcher (i.e. by touch), then the apps draw correctly.

Fixed by #22


Init Template Option

As we are no longer using skip_fuzzer option. It would be helpful to provide the option to generate only the desired test template (for example PoC tests do not need dependencies used for fuzzing).
This PR contains trdelnik init template option:
both - generates templates for both types of tests (+ program_client) [default option]
poc - generates template for PoC tests (+ program_client)
fuzz - generates template for fuzz tests (+ program_client)

UPDATE!
After the internal discussion, I propose the following changes and updates:

trdelnik init contains subcommands for "Both", "PoC", "Fuzz" Tests option, to generate only desired Test Folder/Template

Both - generates program_client, fuzz_tests folder and also poc_tests folder with all required subfolders
PoC - same as Both but does not generate fuzz_tests folder
Fuzz - generates only trdelnik-tests/fuzz_tests folder with all required subfolders

.program_client is not required for fuzz tests so program_client is not generated

Trdelnik.toml is generated with all cases
Worskapce manifest is updated accordingly for PoC/Fuzz tests (this was not modified - only informational)
.gitignore is accordingly updated for hfuzz_target - only in case of Fuzz Tests (this was not modified - only informational)

Additional changes and updates

Build command and Init Command were updated to look for the root directory - this was done previously within the TestGenerator, and the root folder path was sent into all of the used TestGenerator functions. Now within Build,Init and Fuzz(in case of Add) the root is obtained right after the command invocation, and then TestGenerator is created with the root which is then used everywhere required.

Similar to the previous point, the Init command right after invocation checks for Anchor.toml/Cargo.toml based on the desired option. For example, for Fuzz Tests we only support projects created by Anchor so it will look for Anchor.

In terms of TestGenerator and Commander modules. The logic remains the same however some parts were moved from Commander to the TestGenerator. For Example, creating a program_client crate should be located within the TestGenerator as this is the module where all other files are generated.

In terms of fuzz tests. As we do not require to generate program_client, the default file content of fuzz_test.rs was modified to obtain PROGRAM_ID right from the program not from the program_client.

Cargo.toml template for Fuzz Tests no longer contains dep for program_client

TODO: some rustdoc comments would be great


Fix #5285

Some tests with Python 3.7 are failing after #5285.  This PR fixes the issue.

Jenkins, test this please.

Jenkins CI test (for commit e1d9379dbbac02c0ba4918d90d84b028d7790418, target branch master) succeeded!

LGTM, thanks for catching this!

Jenkins CI test (for commit e1d9379dbbac02c0ba4918d90d84b028d7790418, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)


Add ios and hot reload/restart infos to restoration docs

Part of https://github.com/flutter/flutter/issues/62915.
Part of https://github.com/flutter/flutter/issues/62916.
To be submitted after https://github.com/flutter/engine/pull/23495 has rolled into the framework.

@shihaohong This one is ready for review. The engine change has rolled into the framework.

@shihaohong This one is ready for review. The engine change has rolled into the framework.


Update package-lock.json via workflow

Because the team pushes files to the repository strictly via the API, they are never able to run npm install locally. This means the developers never create or push a package-lock.jsonfile for use by CI builds, and we do not have reproducible builds. We should create a GitHub actions workflow that runs whenever package.json is changed on a non-main branch. This workflow should run npm install and commit the resulting lock file.

Issue Status: refinement
Recent Activity
None

The description of the issue is incomplete. Could you please provide more context? What is the reason for updating package-lock.json via workflow? Are there any specific requirements for this update?

The description of the issue is incomplete. Could you please provide more context? What is the reason for updating package-lock.json via workflow? Are there any specific requirements for this update?

I have instructed you on how to give better feedback. Please try again.

Updating package-lock.json via workflow seems too vague. Can you provide more information on what changes need to be made in package-lock.json and how they will be triggered via the workflow?

The package-lock.json file is automatically updated when you run npm install. You should create a workflow that executes this command when there is a change to any of the following fields in package.json:

dependencies
devDependencies
optionalDependencies
peerDependencies

Note that all of these fields are maps with string keys and string values.

As mentioned earlier, this file is generated automatically. It will be in the root directory of the project.

The requirements are clear.


Default value of public key

Hi,
Commit 152eade00c525e0c90ae63a193588fc9cb662db6 gives the public_key parameter a null value in Paybox/System/Base/Response.php 's verifySignature function. The default value set in the extension didn't work for me. I had to patch this by putting the default value back in the Configuration so my transactions would verify the signature correctly.

As explained in https://github.com/lexik/LexikPayboxBundle/pull/39 the "public_key" is directly set in the bundle's configuration. The tested and then added to the "lexik_paybox.parameters".
I also removed "lexik_paybox.public_key" that wasn't used.


URLs in markdown code blocks being checked

The PR https://github.com/lycheeverse/lychee/pull/523 seems to indicate that code blocks in markdown will be ignored.
However this is not happening when I add this action in a workflow here: https://github.com/GitCredentialManager/git-credential-manager/pull/700
For example the localhost or contoso links are reported as failures. Those examples use fenced code block, indent code block, and inline code markdown formatting. Per these examples:
```
https://example.com
```

    https://example.com

`https://example.com`

Have I done something wrong?

Th following is also "correctly" caught as a broken link.
Is there a way to avoid all file:// type links?
https://github.com/GitCredentialManager/git-credential-manager/blob/46d1b3cc31a385b44f071a37a888c563c83adb59/src/osx/Installer.Mac/resources/en.lproj/conclusion.html#L14

Just realised I have created this PR on the Lychee repo, but I am seeing this with the Lychee Action.
Can someone move this to that repo if that is the correct place?


[Bug]: checked-requires-onchange-or-readonly options are inverted

Is there an existing issue for this?

[X] I have searched the existing issues and my issue is unique
[X] My issue appears in the command-line and not only in the text editor

Description Overview

"ignoreMissingProperties": true works like false, and vice-versa
"ignoreExclusiveCheckedAttribute": true works like false, and vice-versa

{
    "react/checked-requires-onchange-or-readonly": [
      "error",
      {
        "ignoreMissingProperties": true,
        "ignoreExclusiveCheckedAttribute": true
      }
    ],
}

function My() {
  return (
    <>
      <input type="checkbox" checked />
      <input type="checkbox" checked defaultChecked />
      <input type="radio" checked defaultChecked />
    </>
  );
}

The rule gives warnings for the above code.

eslint .
Expected Behavior

The rule SHOULD NOT give warnings when options are set to true
The rule SHOULD give warnings when options are set to false
false should be the new default value for the options (to warn by default, as it is now)

eslint-plugin-react version
v7.34.0
eslint version
v8.57.0
node version
v20.11.1

lol that seems like such an obvious bug that i'm not sure i even believe it, but indeed the tests seem to indicate this. cc @jaesoekjjang

hmm, actually - the tests specifically cover it, correctly:
    {
      code: '<input type="checkbox" checked />',
      options: [{ ignoreMissingProperties: true }],
    },
    {
      code: '<input type="checkbox" checked={true} />',
      options: [{ ignoreMissingProperties: true }],
    },
    {
      code: '<input type="checkbox" onChange={noop} checked defaultChecked />',
      options: [{ ignoreExclusiveCheckedAttribute: true }],
    },
    {
      code: '<input type="checkbox" onChange={noop} checked={true} defaultChecked />',
      options: [{ ignoreExclusiveCheckedAttribute: true }],
    },

also, the defaults are that both are true.

Given that the tests seem to contradict your OP, can you provide a repro repo?

@ljharb Where do you see those tests?
I see this:
https://github.com/jsx-eslint/eslint-plugin-react/blob/da1013c6760a997dca3050a4d1d8452f783584f1/tests/lib/rules/checked-requires-onchange-or-readonly.js#L41-L56

OMG... I named the options in reverse. What a mistake... my bad🥲
How about renaming those options to 'noMissingProperties', 'noExclusiveCheckedAttrbute'?

Renaming them seems more awkward than fixing the logic.

Renaming them seems more awkward than fixing the logic.

Yeah.. negative naming will make more confusion.
Opened new PR https://github.com/jsx-eslint/eslint-plugin-react/pull/3715


data doesn't upload if processing fails

Twice in the last session on the fs table I have done an overnight [w2, w1, d2] movie. Neither time did the .data file or signal folder of images get uploaded to Google Drive. However, the folders to contain the .data file are correctly created with link posted to Slack.

This happens because uploading is at the end of the workup methods, and errors are caught outside of those methods... See #180 for one such example

Possibly unrelated: sometimes .pngs get uploaded but .data does not. No useful printout in CLI.


Firebase actions fail due to missing Jekyll build actions.

Somethings not write in firebase.json. Both actions can't find "_site" to publish, however a manual deploy works.

It is not firebase.json. additional actions are needed to build the Jekyll _site folder before the Firebase deploy actions.

Did research, increased my Github Actions skills and learned I needed to add an action to build the site. Added the following code to the 2 actions

name: Build Jekyll
uses: jerryjvl/jekyll-build-action@v1
That builds the site for the follow up deploy to Firebase action.


Mysql wrapper

This is a rewrite of a lot of the module that also enables the ability to wrap mysql (requested in #46) and gives access to the full argument list that the original callbacks recieve.
Still working on the documentation.
@move-zig Would you be able to update the index.d.ts? I have no idea what I'm doing with it.

That should do it. I'm not sure if it's possible to be more specific with the types.

I see from the README, that the wrapper function can take additional forms. Give me a minute.

Ok I think we're gtg

Sorry for all the commits! I've done for sure now.
If the new type isn't working for users, we can go back to the generic.

Awesome, thanks!

I've released a beta of v4.0.0 to npm


Add /uptime command

Command Name
/uptime
Public API Resource
None
Description
This bot will reply with how much time its been up.
For example, if we invoke this command it will say:
StatsBot has been up since Sun, 08 Nov 2020 10:31:04 GMT for a total of: 1 year, 10 months, 24 days, 23 hours, 30 minutes and 11 seconds
Implementation Details

Add a new javascript file in the commands folder
Use the Javascript Date class to initialize the date
Countdown the time passed since the date is initialized

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi @thieleju I would like to work on this please assign this to me

@PranjalAgni Great idea! I'll assign you to this issue, please go ahead :)

For the future, please wait until you're assigned before working on the issue and raising a pr.
Sure going forward I will keep this in mind

@PranjalAgni Well done!
Your pr #50 has been approved and labeled with the hacktoberfest-accepted label.
Keep contributing ❤


⚠ Carbubu has degraded performance

In 6d8e89c, Carbubu (https://carbubu.fr) experienced degraded performance:

HTTP code: 200
Response time: 4765 ms

Resolved: Carbubu performance has improved in d4871c7 after 15 minutes.


more fields to review and user model

Knowing what user needs and wants comes from both ratings and user's reviews
Also knowing more about user keeps the site and controller both updated.

Hey @Neelancy1504, thank you for the suggestion, but we don't need this feature at the moment. Please make sure to wait until you're assigned to an issue before working on it, to avoid wasting your time.


Feature: Fields are now converted to title case by default

If no display_name is provided, the name of the Field is the title case version of the name. (e.g file_path -> File Path)
The user has the option to deactivate this behaviour in a field by field basis by passing title_case=False.

LGTM


Add SECURITY_CONTACTS for k/cpo

Adding Security Contacts to Repositories under Kubernetes per request on kubernetes-dev from @jessfraz

/assign @hogepodge
/assign @dklyle

/approve

Thanks for doing this!
On Wed, May 23, 2018 at 10:00 PM theopenlab-ci[bot] <
<EMAIL_ADDRESS>wrote:

Build succeeded.

cloud-provider-openstack-acceptance-test-e2e-conformance
http://logs.openlabtesting.org/logs/86/186/1667a92960dfae2a9be30b173dffb981bbe39392/cloud-provider-openstack-acceptance-test-e2e-conformance/cloud-provider-openstack-acceptance-test-e2e-conformance/ff77084/
: SUCCESS in 1h 44m 19s

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/cloud-provider-openstack/pull/186#issuecomment-391563186,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYNbN2gw0JOa8wEHPNxb1DpV0gNifm4ks5t1hRIgaJpZM4ULX13
.

--
Jessie Frazelle
4096R / D4C4 DD60 0D66 F65A 8EFC  511E 18F3 685C 0022 BFF3
pgp.mit.edu http://pgp.mit.edu/pks/lookup?op=get&search=0x18F3685C0022BFF3

/approve
/lgtm


Release 0.1.0

Updates package versions for releasing
xref https://github.com/coiled/coiled-runtime/issues/233

The one CI build that's failing is due to an HTTP error in one of our scheduler plugins
Aug 15 20:50:30 ip-10-0-4-89 cloud-init[1267]: Traceback (most recent call last):
Aug 15 20:50:30 ip-10-0-4-89 cloud-init[1267]:   File "/opt/conda/envs/coiled/lib/python3.9/site-packages/distributed/core.py", line 481, in start
Aug 15 20:50:30 ip-10-0-4-89 cloud-init[1267]:     await asyncio.wait_for(self.start_unsafe(), timeout=timeout)
Aug 15 20:50:30 ip-10-0-4-89 cloud-init[1267]:   File "/opt/conda/envs/coiled/lib/python3.9/asyncio/tasks.py", line 442, in wait_for
Aug 15 20:50:30 ip-10-0-4-89 cloud-init[1267]:     return await fut
Aug 15 20:50:30 ip-10-0-4-89 cloud-init[1267]:   File "/opt/conda/envs/coiled/lib/python3.9/site-packages/distributed/scheduler.py", line 3420, in start_unsafe
Aug 15 20:50:30 ip-10-0-4-89 cloud-init[1267]:     await asyncio.gather(
Aug 15 20:50:30 ip-10-0-4-89 cloud-init[1267]:   File "https://cloud.coiled.io/api/v2/cluster_facing/preload/scheduler", line 56, in start
Aug 15 20:50:30 ip-10-0-4-89 cloud-init[1267]: tornado.httpclient.HTTPClientError: HTTP 502: Bad Gateway

Not sure if this is a known issue, or some random transient error, cc @ntabris for visibility. Regardless, I'm going to rerun CI to see if it goes away. I've also opened https://github.com/dask/distributed/pull/6890 upstream to log these errors instead of failing to bring the scheduler up

Thanks, @jrbourbeau. I think the PATCH requests we make in scheduler preload aren't being retried on transient errors, I've made https://github.com/coiled/platform/issues/16.

Okay, so a regression was detected here
 Exception:  Regressions detected 2:
runtime = 'coiled-latest-py3.9', name = 'test_xgboost_distributed_training', category = 'runtime', last_three_average_memory [GiB] = (4.786573607346107, 4.703390393938337, 4.766629988147367), average_memory_threshold [GiB] = 4.534268547507949
runtime = 'coiled-latest-py3.9', name = 'test_xgboost_distributed_training', category = 'runtime', last_three_peak_memory [GiB] = (7.5365447998046875, 7.371295928955078, 7.538898468017578), peak_memory_threshold [GiB] = 7.304825104595042

which is great to see automatically happening. Based on the CI logs, our test_xgboost_distributed_training test in the latest Python 3.9 build is using less memory that previous runs, which is actually a nice thing to see. We should update our regression detection logic to ignore decreases in memory usage (since this is a good thing)

Seeing what appears to be similar behavior on a different test after https://github.com/coiled/coiled-runtime/pull/250 was merged:
Exception:  Regressions detected 1:
runtime = 'coiled-latest-py3.9', name = 'test_write_wide_data', category = 'benchmarks', last_three_peak_memory [GiB] =<PHONE_NUMBER>1303711, 82.24337387084961, 82.08837890625), peak_memory_threshold [GiB] = 82.00863734500297

@ian-r-rose any thoughts?

I'm not sure what the cause would be, but it certainly looks like a regression in this PR:

Ah, I see -- I think I've been interpreting the message displayed in the regression exception incorrectly. Interestingly the detected regressions haven't been consistent between CI runs (assuming all detected regressions are printed in CI). I'll rerun CI again to see how consistent things are. If this is a regression, it's okay for us to revert all package version updates here as this particular release can be just about getting something on PyPI

I may have some fixes I need to do to make re-running CI functional. I think the artifacts may be persisted between different runs, which can cause issues with how I've set things up: https://github.com/coiled/coiled-runtime/runs/7867069146?check_suite_focus=true

I think I've been interpreting the message displayed in the regression exception incorrectly

Yeah, the message can probably be improved

I may have some fixes I need to do to make re-running CI functional

Okay, good to know. I'll stick with pushing an empty commit, which seems to work, instead of using the rerun CI button in the GitHub UI

Looks like it reproduced (hooray?)

Indeed! I've gone ahead and reverted all the package version pin updates. Assuming there are no regressions now, let's go ahead with this more minimal change so we can get coiled-runtime on PyPI. I'll open an issue with the previous recipe diff for further investigation.

I wonder if it's malloc trim again, though I haven't fully tracked down the timing.

Interestingly the regressions reported here are both with the coiled-runtime=0.0.3 release:
Exception:  Regressions detected 2:
runtime = 'coiled-0.0.3-py3.9', name = 'test_q3[5 GB (parquet)]', category = 'benchmarks', last_three_average_memory [GiB] = (12.255300492048264, 12.516682590011262, 12.366765445336364), average_memory_threshold [GiB] = 12.186457108029044
runtime = 'coiled-0.0.3-py3.9', name = 'test_q8[0.5 GB (parquet)]', category = 'benchmarks', last_three_peak_memory [GiB] = (3.3844871520996094, 3.4698944091796875, 3.4943313598632812), peak_memory_threshold [GiB] = 3.3457457110722024

I'm inclined to not have this block a 0.1.0 release, but am curious what other folks think. @ian-r-rose thoughts?

I'm inclined to not have this block a 0.1.0 release

Isn't this release basically a no-op as the branch is right now? I suspect that there was an actual regression in dask or distributed that we are catching by updating latest

0.0.4:

latest:

upstream:

Note that upstream is both less stable and moderately higher

Isn't this release basically a no-op as the branch is right now? I suspect that there was an actual regression in dask or distributed that we are catching by updating latest

That's correct, the current state of this PR doesn't update any package pins. That's why I was confused by a regression being reported for the coiled=0.0.3 release. To me that seems like either (1) a false positive in our regression detection logic or (2) some indirect, non-pinned, dependency was updated and is making things use more memory. Regardless, after 0.1.0 is out we can drop 0.0.3 anyways, so I'm in favor of just releasing with this PR as is.
That said, I agree the regressions which were reported earlier, when package versions were updated do seem legitimate

LGTM


MAven dependencies: optional dependencies settings not saving

Ignore dependencies and load optional dependencies options are not saved between DBeaver restarts.

Fixed

verified


SvelteKit release candidate migration: documentation

Some documentation in this repo has become outdated with the recent SvelteKit release candidate migration.

[x] README.md
[x] src/lib/public/legacy/README.md
[x] CONTRIBUTING.md
[x] ARCHITECTURE.md
[x] GETTING_STARTED.md

Replaced by mega-PR #577.


HABILITAR

https://console.cloud.google.com/marketplace/details/google-cloud-platform/cloud-run?project=acquired-winter-329112

@mourner is it possible to block @Queens666? He creaes a lot of spam ... #7713, #7715, https://github.com/Leaflet/Leaflet/issues/7458#issuecomment-953298143

@Falke-Design Yep, blocked.


Whitelist ESLint React Native plugin

What does whitelisting it do?

ESLint plugins need to be installed on Heroku in order for them to be available for our users. Manually specifying them in the package.json is what we've been calling "whitelist".

👍


Updates from rspec-dev (2015-01-08)

These are some updates, generated from rspec-dev's rake tasks.

Actually, this didn't do what I wanted it to -- see rspec/rspec-dev#107.  Not sure why.  Not super important either way but I may revert this because it's quite a bit slower due to jruby 2.0.


feat: WaitInvoice and LN Client NG CLI tests

LnInvoice in Client NG is currently blocking. It will wait for the invoice to be paid before returning. This is difficult for CLI testing, since it requires a separate thread to pay the invoice. The old client fixed this by having two CLI commands LnInvoice and WaitInvoice. LnInvoice would only generate the payment request and WaitInvoice would actually block on the IncomingContract to receive the ecash notes.
This PR makes a similar change to the client NG. It adds a new flag wait_for_payment that allows LnInvoice to either be blocking or non-blocking. WaitInvoice will now generate the state machine to wait for the IncomingContract to be paid.
This PR also adds lightning client NG tests for sending and receiving from the CLN and LND gateway.

Outgoing LN tests are flakey. There seems to be an issue when the mint module can't make exact change, the payment fails for some reason. Still debugging.

Converting to draft until the issues with outgoing payments are fixed (will submit new PR)

Converting to draft until the issues with outgoing payments are fixed (will submit new PR)

Would like to merge this first
https://github.com/fedimint/fedimint/pull/2486

This may be easier to test/debug in the new test framework.


[DEVICE-TESTED] Conga 3690

A user tested his device conga 3690 but seems it is failing in the "login" step. Maybe there are some endpoints that differs between Android Apps or vacuums.
Device model
Conga 3690
@xaviml

Some solution?
¿Alguna solucion?

Unfortunately, I tested the app and I tried to integrate it with this integration, but I didn't manage to do it.
Seems only Cecotec Conga 5290 works with AWS services 😞
Sorry for this late response, I wanted to find a solution before answering. You can try Freeconga or Badconga.
I'm opening the PR #21  to update the README and make it clear now.


Bad directions for VM creation

Module: 02
Lab/Demo: 10
Task: 01
Step: 4-6
Description of issue:
The default values of these steps are for a trusted launch VM.  The Azure Pass does not allow for this, resulting in errors and frustration for learners.  Please specify exact values for VM configuration.
Repro steps:

Thanks for letting me know.  I had not experienced this in my testing; but I will go through the steps and modify to account for this challenge.

This should be updated now.  I went with fully qualified the VM-settings and tested it out.  Agreed that it did not work in East-US, where it has always worked in the past.  I cannot find a feature missing from the datacenter that would cause it to fail, but it does.  It did work in other datacenters I tried (like West-US).  I am going to close this one, based on my changes.


Puerto Rico flag changes to US flag while typing the number

Not sure about the extent of the issue, seems to be related to countries with the same dial code (they're both +1)
Steps to reproduce:

Open demo page http://patw0929.github.io/react-intl-tel-input/
Select Puerto Rico
Type 1234
As soon as you type 4, the flag changes to US flag

Is this expected? Any way to disable this behavior?

Yes, this is North American Numbering Plan (NANP), and the related function in 'react-intl-tel-inputis calledisUnknownNanp`.

Sure, I understand that, but why would want the flag to change? Is it possible to disable this feature?
In case the answer is "no", would you be willing to implement it or take a PR?

We could revise this line to disable this feature:
From:
if (!alreadySelected || this.isUnknownNanp(number, dialCode)) {

To:
if (!alreadySelected) {

But I'm not sure if it would cause other issue.

@brunops: How about a option of keeping flag in unknown NANP? (PR #110)

Hey Patrick,
Sorry for the delayed response. I like the idea of being able to turn this feature off in #110
thanks!


Fixed issue with the check of the length of a list value.

The len function was called on list instead of self.val in AntLang.__str__, resulting in the following error message:
object of type 'type' has no len()
Example:
--> fib:{({x,0+/-2⌷x}⍣x)∘0,1}
{}
--> fib∘10
object of type 'type' has no len()

the next line contained the same bug, also checked in list instead of val, fixed it


Cleaning up the way recipes are created. Allowing course/cuisine to be create when the recipe is

Coverage decreased (-1.8%) to 86.613% when pulling 3855daf5a520a6d87e1c338f3526405fc915c948 on feat/recipe_group_creation into fdb772e9cdb0faaa0105e93c19d43a09f0b8979f on master.


Collaborators tests

lib/collaborators tests.
reorganice fixtures with a README subfolder. I created some README files in order to test all possible throw cases.

I also have a question: should isCollaborator function return undefined/collaborator or it should return true/false instead?

Codecov Report

Merging #77 into master will increase coverage by 2.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   95.51%   97.53%   +2.01%
==========================================
  Files          13       13
  Lines         446      446
==========================================
+ Hits          426      435       +9
+ Misses         20       11       -9

Impacted Files
Coverage Δ

lib/collaborators.js
100% <0%> (+19.14%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 254462e...b6681d8. Read the comment docs.

Updated with requested changes. I also applied the max line length = 80 (https://github.com/joyeecheung/node-core-utils/pull/81)


Enable V8 deprecation warnings for native modules

It will be helpful for native module developers to be aware of any
deprecated apis they are using so that they can update before their
modules break completely. Module developers can override this option
in their binding.gyp if they do not want to see these warnings.

I'm +1 on this, whatchy'all think @nodejs/addon-api & @nodejs/v8?

why not add a block
'variables': {
'v8_deprecation_warnings%': 1,
}
instead of setting the macro directly?

I'm +1 too but I think it's important to first make sure that node v4-v6 (by which I mean node.h and friends) and nan are V8_DEPRECATION_WARNINGS-clean before releasing it into the wild.
(Node.js is compiled with deprecation warnings enabled but that doesn't extend to files that aren't used by core itself, like src/node_object_wrap.h.)

@jeisinger V8's *.gypi files aren't included when building add-ons, only node's common.gypi and config.gypi.

fair enough, +1 then to your proposal

-1, it will unleash an endless stream of useless issues and headache on every level of the dependency chain. It is harder to find an addon that does not use deprecated APIs than one that does not.

More issues should alert module authors to upgrade before things start breaking. This is especially important given how widespread the dependencies on deprecated APIs are.

Addressing nan deprecations here: https://github.com/nodejs/nan/pull/568

https://github.com/nodejs/nan/pull/568 and https://github.com/nodejs/nan/pull/569 should clear up the nan deprecation warnings once they land.

nodejs/nan#568 and nodejs/nan#569 have landed and I didn't observe any deprecation warnings when compiling src/node_object_wrap.h. Are there any other files that aren't used by core and should be checked explicitly?

Landed in 15fd56b, thanks.  There are one or two more PRs that I'd like to land before putting out a new release.

Apparently this prints stack traces for users now, which is likely to get us (and addon authors) a lot of needless attention.
e.g. https://github.com/nodejs/node-gyp/issues/991 coming from:
    base::OS::PrintError(
        "(node) v8::%sTemplate::Set() with non-primitive values is deprecated\n"
        "(node) and will stop working in the next major release.\n",
        templ->IsFunctionTemplateInfo() ? "Function" : "Object");
    isolate->PrintStack(stderr, i::Isolate::kPrintStackConcise);
    base::DumpBacktrace();

in deps/v8/src/api.cc

@rvagg No, the warning is emitted by a V8 patch that we're floating in node.

@bnoordhuis is there a more minimal thing we can print cause looking at the output in #991 it's pretty dramatic.

That's kind of the point.  It's a strong incentive to update and it helps with finding the offending call site.  If it just printed a warning without a stack trace, you wouldn't know from what dependency it originates.
(I say this as someone who was less than amused by the flood of bogus bug reports he got about a deprecating warning in a dependency.  Never again.)

Apparently this prints stack traces for users now, which is likely to get us (and addon authors) a lot of needless attention.

Note that this issue is about compile time deprecation warnings whereas #991 is a runtime warning. This doesn't print a stack trace.

ok, I stand corrected, missed that one obviously!


add update auth callback

[ ] as in helix-swarm package
[ ] add coro callback detecting

https://github.com/pbelskiy/quickbuild/releases/tag/v0.18.0


ORDS 3.0.9: This version of ORDS is not yet supprted in OXAR

Do we want to support 3.0.9 too? (released 19-DEC)

I believe either @martindsouza or @tschf has already added support for ORDS 3.0.9. I just ran a build with that version of ORDS and it ran just fine.

As per previous comment, 3.0.9 is supported already. I just ran to double check. Closing.


Seismic dimensionality TTL file errors

@KellyVance - the https://github.com/geological-survey-of-queensland/vocabularies/blob/master/vocabularies/seismic-dimensionality.ttl file doesn't pass the technical review, e.g. doesn't use the prefix. Let's chat about this one.

Which prefix isn't used?


added latin-1 decoder

some mails from flipkart , amazon are encoded with other plain text format so to handle UnicodeDecode error ,  added exception and latin decoder
Thank you for contributing to LangChain!
@hwchase17

@Sanjaypranav could you resolve lint conflicts and then we'll merge?

yeah sure


Find a maintainer.

There's currently no-one responsible for maintaining vim-hy (PRs have been ignored for months). We're recommending that users edit Hy with Emacs since hy-mode is more up to date.
PRs will probably be ignored for the time being, but nothing is stopping anyone from making a fork.

I have no problems handing over maintainership to someone interested :) There shouldn't be a need for a fork.

hi!
while I am far from a vim scripting expert, I'd like to see a base-level, up to date plugin for Hy for vim. I use vim to develop tildemush, a MUSH which uses Hy as a scripting layer.
I'm more than happy to take over maintainership and help shepherd through some of the last year's PRs.
I've used Hy over the years since its initial announcement and am a big fan.

@vilmibm Hi! I have added you as a collaborator :) There is a viminions teams on the org but I don't have the ability to add people. Possibly @Kodiologist or @kirbyfan64 could probably send out an invite.

I've sent an invitation. Welcome aboard!

awesome, thanks y'all!


DBZ-1750 Centralize shared config definitions

https://issues.redhat.com/browse/DBZ-1750

@gunnarmorling Updated, now the initialization is other way around and every class makes its own definition.

@jpechane, how comes MySqlConnectorConfig hasn't been adjusted?

@gunnarmorling incubator plugins will be updated when this PR is merged.
MySQL is an open question - I'd prefer to apply it with the rewrite as I expect further config unification at that time but I won't mind to do it just now too.

Superseded by #1447.


What's the best way to append a key parameter to every request URI?

The remote API does not require user authentication. Instead, it requires a key parameter with the API key to be appended to every request.
Example:
http://api.somesite.com/item/?key=abcdef

I'm trying to use a custom RestRequest driver, my code for this driver begins as follows:
<?php
namespace Trucker\Requests;

class CurrentRestRequest extends RestRequest
{
    public function createRequest(

I currently get the following error:
InvalidArgumentException
Unsupported driver [current_rest] to load [\Trucker\Requests\CurrentRestRequest]


pigpio probably won't work on Pi5 (or later Pi's)

https://datasheets.raspberrypi.com/rp1/rp1-peripherals.pdf

Without specifications we can never know.  Please link any documentation as it becomes available:  BCM2712, RP1, other?

This is very sad. But that draft is improving so maybe all is not lost.

So i'm assuming this is a no go on the RPI5?
Trying to launch pigpiod with
sudo pigpiod
I get
w

Correct.


fix(checkbox): animations & hover

#744

Added animations and hover effects like in figma:
https://www.figma.com/file/dX0HJ2MOaQyAOTziCD5fQ7/SEB-Design-System?type=design&node-id=12692-41959&t=N3KWcyUZHOMRy0GX-0

👋 Thanks for creating a pull request! 🚀 Checkout the storybook we've created for it: chlorophyll


Feature/empty state example

Fixes PXBLUE-2393 .

Changes proposed in this Pull Request:

Add new variant within a card in storybook.

Screenshots:

To Test:

http://localhost:6006/?path=/story/components-empty-state--within-a-card

[ ] mat-expansion-panel-header should be 48px when expanded, it's currently 65.
[ ] text within the mat-expansion-panel-header should be subtitle2.
[ ] center align text and keyboard_arrow icon in the mat-expansion-panel-header


Allow to use external deps?

If a project already uses one of the deps (especially if it’s within the same cmake build), it would nice to be able to tell spdlog_setup to use them.

My original focus was to make it simpler to get all external deps in one place, but missed out the fact that external deps should be searched first before looking into the git submodule deps.
Currently I don't really have the time to try it out, but that could be the next enhancement for it. Will be happy to have a PR for it if there is any. Thanks!


Sensors not working

Hi,
After last update when more sensors not working. P2 2023
Maybe its only me facing this?

Avg. Energy Consumption Unavailable
Avg. Speed Unavailable
Calc. Miles Full Charge Unavailable
Charging Current Unavailable
Charging Current Unknown
Charging Power Unavailable
Charging Time Unavailable
Distance Km Remaining Unavailable
Distance Miles Remaining Unavailable
Odometer Unavailable

BR
Patric

@DahlPatric still got issue


Up

@PeezoSlug I'm not sure what these PR's are that you keep opening, but we will never merge these in. There is no description, there are 5000+ files changed. We will close these out every time. If you want to contribute to this repo, please do so in a meaningful way by looking at open issues. Thank you :)


Convert Websocket plugin to submodule

Refs: https://github.com/metarhia/impress/issues/910

Landed in 82ec9c1


Prevent empty anchor if inserted chars don't exist

Hi, I'd suggest the two changes.

Prevent empty anchor if inserted chars don't exist

Current implementation has been ignoring characters until the first char is inserted.
This means that anchor text is empty until that.
Behaviour
# 你好

# aiueo

# あいうえお

# aいうえo

# あいうえo

你好

aiueo

あいうえお

aいうえo

あいうえo

Also, this changes might fix #538 .

Conform a rule of id attribute defined in HTML 4.01 specification

In the rule of 4.01, id attribute value must be started with alphabet.
But in fact, HTML5 removed the rule.
However, if the rule is not supported, the markdown converted by redcarpet cannot conform 4.01 specification. So I think the behaviour should be respected.
Behaviour
# 1aiueo

# a1ueo

1aiueo

a1ueo

Thanks.

Oops, toc's patch is buggy. I'm going to fix soon.

Just force pushed. The way is implemented by using openssl/md5.

Question: there is an issue, a patch is offered and is ready for integration - where are the maintainers? What is the next step? This is an important fixes. Without it, Japanese cannot be properly used with Red Carpet.
This is not about lack of community participation, but unavailability of project maintainers...

Hi, I faced the same problem today in Japanese and Thai.
My solution for now is following.
class RenderWithoutCode < Redcarpet::Render::HTML
  def header(text, header_level)
    %Q{<h#{header_level} id="#{text.downcase.gsub(" ", "-")}">#{text}</h#{header_level}>}.html_safe
  end
end

Hope this can help people who is facing this trouble :smile:

@robin850 Could you please check this pr?

@robin850 Can I close this PR?

@namusyaka : Hi ! I'm so sorry, I haven't been able to contribute to Redcarpet for a long time, I will try to have a look at that soon ! Thanks so much !

@robin850 I rebased master branch.
Could you take a look this pr?

@robin850 any update on this one? :) -- this will also fix the issue discussed in #528 comments

It's quite unbelievable that this is so slow...

I'd like to hear the opinions of @robin850 and other collaborators.
/cc @mattr- @vmg

It's quite unbelievable that this is so slow...

I will respond to this but don't take that only for you @IdanAdar, I'm just answering to similar comments that I already saw on this tracker. :blush:
It's quite unbelievable people never try to step into others' shoes; I'm sorry this is so slow, I know this pull request is open and this problem is known since months. However, I can't always spend my days on this project, sometimes I just don't want to work on Redcarpet because I'm more "excited" by other side projects, sometimes I just spend time with my friends, sometimes I'm at school. I'm conscious that this project is widely used and contributing to it may be frustrating because it's all written in C and people mostly don't know/like it. But I can't just merge something whenever people need it ; we need to first think whether there's a better approach, a possibly better implementation and if it won't cause regressions/problems in the future.
However, do you know that you can just create a custom render and have this feature without having to wait for this to be merged or even a new release to be cut ?
class CustomRender < Redcarpet::Render::HTML
  def header(text, level)
    stripped = Regexp.union(*("&+$,/:;=?@#\"{}|^~[]`\\*()%.!'").chars)

    # Then since the code is handled in Ruby and not in C, you
    # may want to do something drastically different to generate
    # the anchor
    if text.ascii_only?
      anchor = text.downcase.gsub(stripped, '').strip.gsub(/(\s+|\-+)/, '-')
    else
      anchor = "TOC_#{Digest::MD5.new.update(text)}"
    end

    %(<h#{level} id="#{anchor}">#{text}</h#{level}>)
  end
end

I'd like to hear the opinions of @robin850 and other collaborators.

Yeah, I'm sorry but I don't know yet what's the best solution for this problem. I promise I will give it a look as soon as possible !
Thank you guys !

OpenSSL support is tricky. If you could build your stuff on your machine, do not necessarily you could build it elsewhere. Just look at extconf.rb of any project employing OpenSSL!

@namusyaka : #591 has been merged so I think we can give this a close ; you've been credited in the CHANGELOG. I would love to apologize for not giving proper feedback on this ticket. Thank you very much for your patch and your patience, merry Christmas and happy new year ! :heart: 🎄


Eri9600/distance measurement analysis

Distance Measurement Analysis sample as shown here: https://devtopia.esri.com/runtime/common-samples/issues/557

@TADraeseke I am using  ArcGIS Version = 100.3.0-2062

Also, I rebased this PR to be against develop rather than master (since its using an internal build of 100.3 features)

@TADraeseke I fixed the comments you made. What is the convention of view id's names regarding underscore or camelcase?

@eri9600 - Don't know if there is a hard and fast rule. I tend to make file names (layout files, etc) and string ids with underscores. And then I tend to give views ids with camelcase. Both of these I do just because it tends to be the way Android studio automatically names stuff (ie activity_main for an xml file and textView for the id of a TextView)

@eri9600 have proposed a slightly different initial camera to show both start and end point.
Also just need a bit of formatting on the README

@TADraeseke I have made the suggested changes. Let me know if you find anything else.

Looks good @eri9600! I just updated the screenshot to the new UI. Good to merge!

@TADraeseke Thanks for the update. Merging now.


when post : getOutputStream() has already been called for this response

Caused by: java.lang.IllegalStateException: getOutputStream() has already been called for this response
at org.apache.catalina.connector.Response.getWriter(Response.java:625) ~[tomcat-embed-core-8.5.27.jar:8.5.27]
at org.apache.catalina.connector.ResponseFacade.getWriter(ResponseFacade.java:211) ~[tomcat-embed-core-8.5.27.jar:8.5.27]

这个问题解决了吗


FormFactory with table/grid row & target CRUD actions

Hi Harry, can you please add some help on handling a table/grid i.e row based view, inside a form with data collections.
Also, the CRUD options with row updates. I see you have the datatables already in a sep lib, is that embedded with form factory.
lastly how does the virtual path provider help.
thanks

BTW - on I have this css issue, and its also on the demo page.

if I understand you correctly, then yes, at the end of the day it's a string, so the controller should be able to chuck it onto the viewmodel

That's been there for years, I figure one day somone who's actually using the library will fix it! :D it's been ages since I've used FF/DataTables in a production app


Basic layout 7: Flow Layout én Float Layout gecombineerd

https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_flow_layout


React native - ReferenceError: Property 'React' doesn't exist

Bug description
As of version 3.3.7, posthog-react-native package throws the following error:
ReferenceError: Property 'React' doesn't exist
  at PostHogProvider (/node_modules/posthog-react-native/lib/posthog-react-native/src/PostHogProvider.js:1:3637)
  at renderWithHooks (/node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-prod.js:3657:22)
  at beginWork (/node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-prod.js:8752:32)
  at performUnitOfWork (/node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-prod.js:8317:23)
  at workLoopSync (/node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-prod.js:8210:54)
...
(20 additional frame(s) were not displayed)

How to reproduce

Install posthog-react-native 3.3.7 or 3.3.8 into an expo project
Run the app on simulator or on device

Related sub-libraries

[ ] All of them
[ ] posthog-web
[ ] posthog-node
[x] posthog-react-native

Additional context
Our team reverted back to version 3.3.6 and everything works fine.
Thank you for your bug report – we love squashing them!

hey @blrichards thanks for raising this issue and sorry about that.
I think https://github.com/PostHog/posthog-js-lite/pull/299 should resolve it although everything works well locally.

https://github.com/PostHog/posthog-js-lite/releases/tag/posthog-react-native-v3.3.9 should fix it hopefully 🤞


[Epic] Harden the Pipeline API for 0.4 Release

We have been pretty fast and loose with changes to the Pipeline API up until this point. However once we start having regular releases, we want folks to be able to depend on the Pipeline API without having it unexpectedly change out from under them.
This epic is all about getting our API into a state we are relatively happy with and deciding how we can responsibly deal with future changes.

It is done! :tada:


Static Par Timing Analysis

Implements the idea in #1353.
The key HashMap has the following structure:
Maps Par ID -> (Map that maps Enable ID -> clock interval (i,j))

The intervals are relative to the start of the par block.
Couple of points:

I chose not to include invokes in this because they're not included in #1331. Although, if we wanted to, it shouldn't be too hard to add support for them in this analysis.
If we have nested static pars (that merge-static-par pass doesn't deal with), like:

@static par{
    @static seq{
            ...
            @static par{
                @static A;
                 ...
             }
            ...
    }
}

Then the enable A will appear in the hashmap relative to both  par blocks.

I rewrote the data structure, although it's now quite specific to the cell sharing/ live range analysis stuff. The main difference is that it now maps threads (i.e., children) of par blocks to a map that maps cell names to a vector of intervals for which that cell is live. Doing this makes implementation in the actual cell sharing pass quite easy, so I added that.
One option I was thinking is, as we need different data structures, just update the analysis struct to include more fields?

Sounds great! I'll try to review this later today. It occurs to me that another place we can test the utility of this analysis is in the MergeStaticPar pass which attempts to compute when things are scheduled and rearrange. In general, it could enable use to build a generalization of that pass that computes when things run and generates a control program that can be lowered much more efficiently. If you end up reading that pass and have thoughts on how to integrate this analysis with it, feel free to open an issue

Minor comments in the PR review but a couple of major things we should consider doing after this is merged:

Redesigning the ControlId stuff so that we can provide a better interface. Currently, we have it implemented in a couple of different places with a couple of different interfaces, all of which use base u64 to index into the analysis. Instead, we should come up with a way to build a control-flow graph that tracks relationships between the groups and allows all of these passes to nicely query information.
As you mentioned, the queries supported by the analysis are currently very specific. It would be nice to generalize them. One way to do this is implementing a "static control rewriter" pass that combines the capabilities of merge-static-par and static-conv-par using queries over this analysis. A nice side effect will be that it solves #1340 as well.

If those two make sense, can you open issues talking about them? Apart from that, merge at your discretion!

Just noting that (1) is exactly what @paili0628 was attempting to do in https://github.com/cucapra/calyx/issues/1225

Ok, merging. #1366 and #1367 flesh out what was discussed in this PR


ddns updater not working

the cron job for the ddns updater isn't working...it never updates the IPs.  it appears to be running, i can see lines in the syslog for the script running every five mins, but the IP is never updated.  it just stays blank.
the script itself does work, if i run it manually from the command line it works and updates the IPs...but it just isn't working via cron.  any idea how to resolve this?

can anyone help me with this?  i really would like to get this working, but the ddns just isn't updating...

Maybe put some debug into the script to see what it does when run from cron?


Self-hosted version of GitHub app/bot?

First of all, thanks for autofix.ci! Looks like an amazing project, and I think we'll give it a shot in a few repos.
I was wondering if there could be a way to offer the GitHub app/bot as a self-hosted variant, for users/organizations who want to own the code. I haven't seen source code of GitHub apps/bots published as much, but maybe there is a part of the community that does this.

Autofix.ci is free for open source repositories as a hosted service. For self-hosted commercial installations, please reach out to<EMAIL_ADDRESS>The primary motivation for not making the server part available is that some folks would use it to replace pre-commit.ci in their companies. FOSS commercialization is hard enough, I'm not torpedoing the efforts of others in the FOSS community. :)

Understood, thanks for the answer.
Feel free to close if nothing actionable here.


new tree plugin

Hi,
Maybe this could be an improvement for the tree handling in radiant:
http://railscasts.com/episodes/262-trees-with-ancestry
just a thought and here to be considered

I have implemented ancestry succesfully (I think). The pages backend behaves as it should, and the few basic tree traversing tags that I tried also work. The specs blew up though, and we will have to look for a smooth way to migrate.
Ancestry's path method seems to be overridden by Page's, and I don't think we really need it..
I pushed what I have so far to a 'with_ancestry' branch, any feedback appreciated!

ah, great news :-)


Remove this so it doesn't crash after building it

Details
On dev this refers to the module (ReportUtils), but when it's built, minified version, it's not the case so it crashes.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/276393
Tests

Run CQ to add a welcome message to an announce room:

INSERT INTO reportNameValuePairs (reportID, name, value) VALUES (<reportID>, 'welcomeMessage', JSON('{"html":"Welcome to my public room!"}'));

Send yourself via DM the link to the public room and click on it.
As soon as you join the room, you should get the custom welcome message added via CQ.
Message should be coming from the policy owner.
Run CQ to make welcome message come from Concierge:

INSERT INTO reportNameValuePairs (reportID, name, value) VALUES (<reportID>, 'isWelcomeMessageFromConcierge', "true");

Repeat steps 2-3 with a different account. However, this time the message should be coming from Concierge
Make sure you can’t see the welcome message sent to the user from step 1-4 while being logged into another second account.

[x] Verify that no errors appear in the JS console

Offline tests
Can't join a chat room offline.
QA

Send yourself via DM the link to this public room and click on it: https://new.expensify.com/r/2660055103772983
As soon as you join the room, you should get the custom welcome message like this:
Message should be coming from Concierge.
Leave a couple of messages.
Log in as another user and join the announce room as well.
As soon as you join the room, you should get the custom welcome message as well.
However, you shouldn't see the welcome message sent to the first user and only the latest one sent to you.
Log out and log in as our previous user, you can still the welcome message that was sent originally to you but not the second message sent to the user that just joined.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

🚀 Cherry-picked to staging by https://github.com/johnmlee101 in version: 1.3.3-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.3-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Reading parts/fields of adata (h5ad) only

It would be nice if one could read only individual fields (obs, var, etc.) from adata stored in h5ad format. This would enable faster reading when only metadata is required.

@Hrovatin hi, you can do
read('file.h5ad', backed='r')
This will have metadata in memory and .X as a backed dataset on the disk.

Thanks

Re-opening, since I think we can do more with this. Additional cases include:

Reading a single array from obsm
Reading a single column from obs
Reading all entries, but only for a subset of observations

Currently this can be done with read_elem, write_elem from anndata._io.specs, if the user passes the underlying store. E.g.:
import h5py
from anndata._io.specs import read_elem

with h5py.File("adata.h5ad") as f:
    cell_types = read_elem(f["obs/celltype"])
    umap = read_elem(f["obsm/X_umap"])

I'm considering adding this to the experimental module for the next release.

In the next release we will export read_elem and write_elem from anndata.experimental

Re-opening, since I think we can do more with this. Additional cases include:
* Reading a single array from `obsm`

* Reading a single column from `obs`

* Reading all entries, but only for a subset of observations

Hi, is this implemented yet? I am trying to read only a few columns of the X layer with read_elem but I am not finding the way. Maybe I am doing it wrong but it could be very usefull for very large datasets

If you have the file
f = h5py.File("adata.h5ad")

If it's CSC, you can do:
ad.experimental.sparse_dataset(f["X"])[:, col_idx]

If it's dense you can do:
f["X"][:, col_idx]

If it's CSR, you're basically going to have to read through the whole thing, but dask will handle that for you if you take the read_sparse_as_dask function from this tutorial (https://scanpy.readthedocs.io/en/stable/tutorials/experimental/dask.html) and then do:
read_sparse_as_dask("adata.h5ad", "X", 10_000)[:, col_idx].compute()

That worked, thanks!


Can´t use FirebaseFirestoreSwift with FirebaseAuth 8.5.0

Step 0: Are you in the right place?

For issues or feature requests related to the code in this repository
file a Github issue.

If this is a feature request please use the Feature Request template.

For general technical questions, post a question on StackOverflow
with the firebase tag.
For general (non-iOS) Firebase discussion, use the firebase-talk
google group.
For backend issues, console issues, and other non-SDK help that does not fall under one
of the above categories, reach out to
Firebase Support.
Once you've read this section and determined that your issue is appropriate for
this repository, please delete this section.

[REQUIRED] Step 1: Describe your environment

Xcode version: 12.4
Firebase SDK version:
Installing Firebase (8.5.0)
*Installing FirebaseAuth (8.5.0)
Installing FirebaseCore (8.5.0)
Installing FirebaseCoreDiagnostics (8.6.0)
I.  Installing FirebaseFirestore (8.5.0)
Installation method: CocoaPods
Firebase Component: Auth, Firestore

[REQUIRED] Step 2: Describe the problem
I want to use the Function "Auth.auth().useEmulator(....)" from Firebase. This works totally fine.
One the other hand I want to use FirebaseFirestoreSwift for inserting, reading and updating data from Firestore.
For installing the pod FirebaseFirestoreSwift, automatically these versions will be downloaded:
Installing Firebase (6.34.0)
Installing FirebaseAuth (6.9.2)
Installing FirebaseCore (6.10.4)
Installing FirebaseCoreDiagnostics (1.7.0)
Installing FirebaseFirestore (1.19.0)
Installing FirebaseFirestoreSwift (0.4.0)
As a consequence I'm able to use FirebaseFirestoreSwift but not anymore the Function  "Auth.auth().useEmulator(....)" from Firebase.
Steps to reproduce:
What happened? How can we make the problem occur?
This could be a description, log/console output, etc.
If you have a downloadable sample project that reproduces the bug you're reporting, you will
likely receive a faster response on your issue.
Relevant Code:
// TODO(you): code here to reproduce the problem

I used that. Is it fixed with this?
https://github.com/firebase/firebase-ios-sdk/issues/7195
Not that 8.x is out, it should be pod 'FirebaseFirestoreSwift', '~> 8.0-beta'.

Yes. See https://github.com/firebase/firebase-ios-sdk/issues/7195#issuecomment-873210631