I can't get rid of the userwarning of WER and CER: Torchmetrics v0.9 introduced a new argument class property called full_state_update that has not been set for this class...

I can't get rid of this userwarning while using WordErrorRate and CharErrorRate:
/home/hxt/ASR_adversarial_examples/venv/lib/python3.7/site-packages/torchmetrics/utilities/prints.py:36: UserWarning: Torchmetrics v0.9 introduced a new argument class property called `full_state_update` that has
                not been set for this class (WordErrorRate). The property determines if `update` by
                default needs access to the full metric state. If this is not the case, significant speedups can be
                achieved and we recommend setting this to `False`.
                We provide an checking function
                `from torchmetrics.utilities import check_forward_full_state_property`
                that can be used to check if the `full_state_update=True` (old and potential slower behaviour,
                default for now) or if `full_state_update=False` can be used safely.

According to the description above, a relevant property called full_state_update should be set for WER but not.
Actually, my torchmetrics version is:
torchmetrics                    0.9.3

and the full_state_update property has been set already according to source code:
class WordErrorRate(Metric):
    is_differentiable: bool = False
    higher_is_better: bool = False
    full_state_update: bool = False

    # ...

Then I searched the source code for where this userwarning was thrown, and I found this in the base class torchmetrics/Metrics:
class Metric(Module, ABC):

    # ...

    is_differentiable: Optional[bool] = None
    higher_is_better: Optional[bool] = None
    full_state_update: Optional[bool] = None

    def __init__(
        self,
        **kwargs: Any,
    ) -> None:
        super().__init__()

        # ...

        if self.full_state_update is None and not is_overridden("forward", self, Metric):
            rank_zero_warn(
                f"""Torchmetrics v0.9 introduced a new argument class property called `full_state_update` that has
                not been set for this class ({self.__class__.__name__}). The property determines if `update` by
                default needs access to the full metric state. If this is not the case, significant speedups can be
                achieved and we recommend setting this to `False`.
                We provide an checking function
                `from torchmetrics.utilities import check_forward_full_state_property`
                that can be used to check if the `full_state_update=True` (old and potential slower behaviour,
                default for now) or if `full_state_update=False` can be used safely.
                """,
                UserWarning,
            )

So is this a problem about class member full_state_update overriding?

And how to get rid of this? Thank you.

Hi @Xiaotian0726, thanks for reporting this issue.
I am a bit confused that you still get the warning even when you overwrite the property in your metric class. Here you can see that we do exactly that for our own metrics:
https://github.com/Lightning-AI/metrics/blob/ed2249d1e250dbfc4f2e654b455f43f3d29abfb1/src/torchmetrics/regression/mse.py#L42-L44
Also I cannot reproduce the error on v0.9.3 with this small example:
from torchmetrics import Metric

class WordErrorRate(Metric):
    full_state_update: bool = False

    def update(self):
        pass

    def compute(self):
        return 1

if __name__ == "__main__":
    metric = WordErrorRate()

you have not setup your warnings filtering in some weird way?
Regardless of all this the warning has been removed from the next release in this PR https://github.com/Lightning-AI/metrics/pull/1349. You can update directly from master now if you want the change:
pip install git+https://github.com/Lightning-AI/metrics.git

or wait for the next release (it will probably be within a week or so).

Yes, the warning is first removed it what will be v0.11.0, which will officially be released within the next week.
Closing issue.


Move bootstrap to peerDependencies

I think bootstrap should be in peerDependencies, so that bootstrap-vue-3 doesn't install it's own conflicting one in node_modules/bootstrap-vue-3/node_modules/bootstrap.
The instructions already say yarn add bootstrap bootstrap-vue-3

I am not sure if I understand this topic correctly, but: I am trying to develop our own custom library with just few special components, based on Vue 3 + Bootstrap 5. As this library should be used in Vue 3 + Bootstrap 5 applications, any of its component does not import Bootstrap nor Bootstrap-Icons (I use Storybook for development, so Bootstrap is imported in stories, not in component itself, mimicking the real application inside which my component will be used. So the build size of my library is relatively small (~ tens of kBs).
Now I tried to incorporate bootstrap-vue-3 library to use its BTable component. Even if I import only BTable component with import { BTable } from "bootstrap-vue-3"; build size of my library increased to 1+ MB as BTable "injected" whole Bootstrap and especially Bootstrap Icons into the build.
It would be great if Bootstrap could be really externalized from bootstrap-vue-3.

Build size is fixed now.
There is no node_modules/bootstrap-vue-3/node_modules/bootstrap
Since this lib can't be used without bootstrap, it makes sense for this lib to pull it too. Instructions are wrong, I'll update that to install only bootstrap-vue-3

@mariusa I was following this issue since I agreed(although for different reasons, which I'll get to) with this proposal.
While it makes sense that the library should pull it, it doesn't make sense for the library to include bootstrap in the built files; for people already including bootstrap in their build process, it adds unnecessary size and conflicts to the library.
I of course can't speak for everyone, and only my current pipeline, but for instance: A site I'm working on supports extensions to the core; the site in question already includes bootstrap's css and js.  If I include bootstrap-vue-3 in my extension, the two versions of bootstrap's js(one in the site, and the one in bootstrap-vue-3) conflict, preventing a collapse from working.
Take this fiddle for example; the code to reproduce it is simple and will be included in  this post, but clicking the collapse opens it as normal.  Clicking the button again to close it fails to work, however.
I did test this before writing this post and bootstraps' js is still in the built files.

Code to reproduce; make sure bootstrap.js is loaded into the document.

  Toggle Collapse

Collapse contents Here

      Toggle Inner Collapse

        Hello!

window.addEventListener('DOMContentLoaded', () => {
  const app = Vue.createApp({});
  app.use(window['bootstrap-vue-3'].BootstrapVue3);
  app.mount(document.querySelector("#app"));
});

If bootstrap is already in the page, conflicts will happen; if it is removed for the build process, this issue is fixed.  As it stands, I've had to clone the library and build it myself so I could use it in my projects because of these conflicts, but that of course is a sub-optimal solution.

The simple change I made to the process to avoid conflicts in vite.config.ts
//...
external: ['vue', 'bootstrap'],
//...
output: {
//...
  globals: {
    vue: 'Vue',
    bootstrap: 'bootstrap',
  },
},
//...

TL;DR: If bootstrap is already included in the page, the library breaks.  Please move it to peerDependencies and exclude it from the build process.

Got it

Guys, we're getting a build error which seems to be due to peerDependencies:
https://github.com/cdmoro/bootstrap-vue-3/pull/277#issuecomment-1038463985
Any suggestions on how to fix that? I can't figure it out. Thanks!

We can surely require bootstrap 5.1.x . Question is, what's the best solution while keeping bootstrap in peerDependencies?


Adding more calcualtors

Add  calcualtors like Sugar Intake and Body Fat Calculators
assign me this under jwoc24

Mentees needs to create an issue after the coding period starts. Closing this issue for now.

Can you please open all closed issues as coding phase of jwoc starts from 15

@NaveenChandraAdhikari mentees need to create new issues. No issues made before the coding period would be considered under JWOC.


Pip3 not found

I'm using helper script to install and no matter what I do I end up with (/usr/data/mobileraker_companion/scripts/install.sh: line 197: pip3: not found) how do I get past this?

You'll need to make sure that pip3 is installed.
Since your running on a creality machine there is a high possibly that this is not possible due to the locked OS they provide.
I suggest you ask at the creality groups for help as I currently don't have access to any creality machine to test it myself.


when led issue is fixed in ESP32 core, update uses of led to only happen once

https://github.com/espressif/arduino-esp32/issues/5306


Netlogon Elevation of Privilege Vulnerability "Zerologon" (CVE-2020-1472) Event Codes

Given the recent advisories re: Netlogon Elevation of Privilege Vulnerability "Zerologon" (CVE-2020-1472) would be it prudent to add the codes from;
https://support.microsoft.com/en-us/help/4557222/how-to-manage-the-changes-in-netlogon-secure-channel-connections-assoc
Events logged when a connection is denied because vulnerable Netlogon secure channel connection was attempted:

5827 (machine accounts) Error
5828 (trust accounts) Error

Events logged when a connection is allowed because the account was added to the "Domain controller: Allow vulnerable Netlogon secure channel connections" group policy:

5830 (machine accounts) Warning
5831 (trust accounts) Warning

Events logged when a connection is allowed in the initial release which will be denied in the DC enforcement mode:

5829 (machine accounts) Warning

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4342cf3c-f5e5-89f2-f67d-d895632af639
Version Independent ID: b28376fa-a373-ba10-6e5c-97c15fcc7981
Content: Appendix L - Events to Monitor
Content Source: WindowsServerDocs/identity/ad-ds/plan/Appendix-L--Events-to-Monitor.md
Product: windows-server
Technology: ad-ds
GitHub Login: @iainfoulds
Microsoft Alias: iainfou

Is there any chance this will be picked up soon?

#assign:pataltimore

Hi @simonsigre,
Thanks for submitting this feedback. Sorry it took a while to get back to you. Since the enforcement phase has started, I added 5827 and 5828 to the list. The change publishes tomorrow.
I'm going to request this issue be closed. #please-close
Thanks,
Pat


btc-rpc-explorer: update to v2.0.2

Just a patch release with minor fixes. Have tested on my node, works as expected.

Current version is v2.2.0 - @JosephGoulden could you also test an adapt the PR?

Updated 2.2.0 and tested, looks good.

Hi @JosephGoulden can you rebase the PR on the dev branch?

This looks good now :) merging for v1.7RC1 much thanks


small fix for case when buffer size is larger then the actual  availa…

…ble times
I hit a small bug when the configured buffer size was larger then length of the actual available times array. Some times when preloading the steps, the plugin keeps on firing the "waiting" event. Setting a Math.min on the buffer size , comparing with the _getMaxIndex() should fix it.

Thanks @gwaihir8!! I understand the problem, and it will fix some scenarios.
But if we want to be precise, the buffer should be the minimum among the desired buffer size and the number of available indexes ahead of the player (that its more complex to compute, as it depends on steps, loop and upper and lower limit options).
I think that another option could be to change the method getNumberNextTimesReady. It's neither precise, as I'm checking right now. In some cases, it does not return the number of next times ready (as its name says). Instead, it returns the howmany parameter, as it finds that it has arrived to the end of the loop (to the upperLimit or to the lowerLimit). But if loop option is true, it does not check if it has done a full loop (the method prepareNextTimes has this check).
Could you try if adding the check of arriving to the same initial index at  getNumberNextTimesReady solves the problem?
I'm not comfortable that it returns an unprecise value, and it could be converted return a boolean to get if all the desired next times are ready... but we need the number to show the percentage of loading when waiting.


chore: user authentication page testing

What
Golden test for Sign in and Sign Up page
Comments

[ ] tooltip message localization
[ ] Wiget Test waiting for Patrol Windows fix

Part of
#1176

Codecov Report

Merging #3233 (df3db52) into develop (a3608be) will increase coverage by 1.98%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##           develop   #3233      +/-   ##
==========================================
+ Coverage     7.69%   9.67%   +1.98%
==========================================
  Files          249     249
  Lines        12248   12250       +2
==========================================
+ Hits           942    1185     +243
+ Misses       11306   11065     -241

Impacted Files
Coverage Δ

...ib/generic_lib/widgets/smooth_text_form_field.dart
86.48% <ø> (+86.48%)
:arrow_up:

...ib/pages/preferences/user_preferences_account.dart
20.97% <ø> (ø)

...th_app/lib/pages/user_management/sign_up_page.dart
53.18% <90.00%> (+52.72%)
:arrow_up:

...ckages/smooth_app/lib/widgets/smooth_scaffold.dart
67.79% <0.00%> (+23.72%)
:arrow_up:

...ooth_app/lib/pages/user_management/login_page.dart
67.21% <0.00%> (+66.39%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@monsieurtanuki
I had to add a label to pass labeledTapTargetGuideline or I was getting Expected: Tappable widgets should have a semantic label on golden tests.
I had two options either ignore that guideline or add a label to every onTap widget.
If you got any other idea, I would implement that.

I had to add a label to pass labeledTapTargetGuideline or I was getting Expected: Tappable widgets should have a semantic label on golden tests.
I had two options either ignore that guideline or add a label to every onTap widget.
If you got any other idea, I would implement that.

What about Semantics(label: 'xxx', child: InkWell(...))? Or better, putting directly a semanticLabel, e.g. to Icon or TextSpan?

Well just some more suggestions besides what was already suggested
Also, the pages are not entirely rendered like the bottom screen is cropped, perhaps you can also fix that. I remember there were some scroll features in the testing library as well

How to generate golden files for that?
I used flutter test --update-goldens


Alerts Not Getting Processed

Hi @nathanielc ,
i have configured Morgoth for anomaly detection as per the Morgoth documentation, but unfortunately alerts are not getting processed.
[ec2-user@ip-172-31-14-178 ~]$ kapacitor show cpu_alert
ID: cpu_alert
Error:
Template:
Type: stream
Status: enabled
Executing: true
Created: 16 May 17 00:48 UTC
Modified: 16 May 17 01:05 UTC
LastEnabled: 16 May 17 01:05 UTC
Databases Retention Policies: ["telegraf"."autogen"]
TICKscript:
// The measurement to analyze
var measurement = 'cpu'

// Optional group by dimensions
var groups = [*]

// Optional where filter
var whereFilter = lambda: TRUE

// The amount of data to window at once
var window = 1m

// The field to process
var field = 'usage_idle'

// The name for the anomaly score field
var scoreField = 'anomalyScore'

// The minimum support
var minSupport = 0.05

// The error tolerance
var errorTolerance = 0.01

// The consensus
var consensus = 0.5

// Number of sigmas allowed for normal window deviation
var sigmas = 3.0

stream
    // Select the data we want
    |from()
        .measurement(measurement)
        .groupBy(groups)
        .where(whereFilter)
    // Window the data for a certain amount of time
    |window()
        .period(window)
        .every(window)
        .align()
    // Send each window to Morgoth
    @morgoth()
        .field(field)
        .scoreField(scoreField)
        .minSupport(minSupport)
        .errorTolerance(errorTolerance)
        .consensus(consensus)
        // Configure a single Sigma fingerprinter
        .sigma(sigmas)
    // Morgoth returns any anomalous windows
    |alert()
        .details('')
        .crit(lambda: TRUE)
        .log('/tmp/cpu_alert.log')

DOT:
digraph cpu_alert {
graph [throughput="0.00 points/s"];

stream0 [avg_exec_time_ns="0s" ];
stream0 -> from1 [processed="46"];

from1 [avg_exec_time_ns="5.916µs" ];
from1 -> window2 [processed="46"];

window2 [avg_exec_time_ns="3.191µs" ];
window2 -> morgoth3 [processed="8"];

morgoth3 [avg_exec_time_ns="0s" ];
morgoth3 -> alert4 [processed="0"];

alert4 [alerts_triggered="0" avg_exec_time_ns="0s" crits_triggered="0" infos_triggered="0" oks_triggered="0" warns_triggered="0" ];`

The morgoth binary is in

/usr/local/bin

with permissions kapacitor:kapacitor. Please find the Kapacitor.conf file below:
[udf]
# Configuration for UDFs (User Defined Functions)
[udf.functions]
    [udf.functions.morgoth]
       prog = "/usr/local/bin/morgoth"
       timeout = "10s"

Please advise

This is working now


Visualizing an AudioClip with a bit depth lower than 32 doesn't work with some clips

Sometimes, the visualize method gives an error if the bit depth of the AudioClip is lower than 32. If a sample is set using set_sample() under certain conditions I can't quite figure out, visualizing the audio clip will cause an overflow error "signed short integer is greater than maximum". From what I can gather, this might be caused by python numbers being 32 bit, so assigning them into the clip when the bit depth is lower than 32 causes issues. In my testing, I found that trying to create a sine wave (starting at 0) failed on the first set_sample, which should have been a value of 0, but that just setting a sample to a value of 0 didn't cause it to fail in a vacuum. It's possible that this is just user error, but it's also possible that it's a bug in the python client, and I'm not sure which.
This makes it impossible, or at least difficult, to create an audio clip with a bit depth lower than 32. I've added a test case for this in bridges-client-testing\python\web_tutorial_mastercopy\audio_clip.py, although it's in main() and commented out (because it requires creating a separate audio clip with a different bit depth).

Alec/Matthew, could one of you take a look at this? We need to figure this out soon..

I probably know what this is. The java and c++ clients were written
assuming the bit_depth was always 32. Some of the normalizatin were
hardcoded with that assumptin. I guess the python client has the same
bug. Haven't looked into it yet.

mmm, there are lots of strange things in the python implementation of audioclip. It is entirely written assuming 32 bits. I'll have to make more changes than I thought.

alright. I went through the AudioClip class in python. I think it is now correct. It follows the same conventions as the java and C++ version. I noticed that the wave parser is much slower in python than c++, but not slow enough to be a problem in my opinion. so that's probably fine.
I updated the documentation of audioclip. And upgraded the python client on the cloud9 server to have the correct version.
@KyleReto check that everything is fine. But I ran the tests (after fixing them to the new convention) and they passed and generated the expected output, so I think they are fine. If there are still issues, reopen this issues.


ENH: New geoaccessor Series.h3 to handle h3's geohash

[x] closes #739
[ ] whatsnew entry

Need to find some ways to remove these auto-generated methods

Use index.h3 as the basic, then adapt that to Series and DataFrame?


[Enhancement] Support (more) readline hotkeys when composing emails

In my terminal, I am able to do stuff like like Alt-f (skip forward a word), Alt-b (skip back a word), which are the readline "emacs style" defaults.
I notice that some of these readline hot keys do work with nmail, such as Ctrl-K (delete whole line).
I also have Alt-left, Alt-right set to skip whole words in my ~/.inputrc (in addition to the default hot keys, some of which I listed above)
However: When I use Alt, Ctrl or Shift with cursor/arrow keys, or even Alt-f and Alt-b, then nmail prints stuff like this:
ȫȈȜȫȱȜȫȜȱȫȜȫȈȜȩȆȚȩȯȚȩȯȚȆȚȩȯȚȩhiuigyftyyƉƉƉƒƒƒƉƉőőőŐŐ

It would be nice if nmail respected the readline settings, or at least provided some of its own, similar hot keys.
Specifically, it would be nice to skip whole words (back & forward) and delete whole words (back and forward, with Alt-delete and Alt-backspace).

Hi @sc0ttj - thanks for reporting this.
Yeah, the built-in compose editor in nmail is all but fantastic. Early on I added a functionality to compose in external $EDITOR by pressing CTRL-e for this reason.
I can agree it makes sense to support some more basic key shortcuts. Let me take a look at this and see what can be supported with reasonable effort.

Thanks :+1:
A quick win might be to add just
Alt-left,
Alt-right,
Alt-backspace,
Alt-delete
...as I doubt any users of any language are expecting to see stuff like  ȫȈȜȫȱȜȫȜȱȫȜȫȈȜȩȆȚȩȯȚȩȯȚ when using those combinations..  Then you could ignore readline entirely..  Just a thought, obvs..

I've implemented support for the keyboard shortcuts suggested in the last comment. I've only tested in Ubuntu gnome-terminal and macOS Terminal.app, where the default keyboard config should work correctly. Other environments may need manual configuration in ui.conf. See the README.md for details.
Please let me know if you encounter any issues. Thanks!


ORPOTrainer.init() got an unexpected keyword argument 'tokenizer'

I used orpo colab example for mistral model and I am getting this error. I am using below configs
from trl import ORPOConfig, ORPOTrainer
from unsloth import is_bfloat16_supported
orpo_trainer = ORPOTrainer(
model = model,
train_dataset = dataset,
tokenizer = tokenizer,
args = ORPOConfig(
max_length = max_seq_length,
max_prompt_length = max_seq_length//2,
max_completion_length = max_seq_length//2,
per_device_train_batch_size = 2,
gradient_accumulation_steps = 4,
beta = 0.1,
logging_steps = 1,
optim = "adamw_8bit",
lr_scheduler_type = "linear",
max_steps = 1500, # Change to num_train_epochs = 1 for full training runs
fp16 = not is_bfloat16_supported(),
bf16 = is_bfloat16_supported(),
output_dir = "outputs",
report_to = "none", # Use this for WandB etc
),
)

trl library just updated and they remove the tokenizer and changed it to processing_class
print(trl.__version__)
0.12.0

from trl import ORPOConfig, ORPOTrainer
from unsloth import is_bfloat16_supported

orpo_trainer = ORPOTrainer(
    model = model,
    train_dataset = dataset,
    processing_class = tokenizer,
    args = ORPOConfig(
        max_length = max_seq_length,
        max_prompt_length = max_seq_length//2,
        max_completion_length = max_seq_length//2,
        per_device_train_batch_size = 2,
        gradient_accumulation_steps = 4,
        beta = 0.1,
        logging_steps = 1,
        optim = "adamw_8bit",
        lr_scheduler_type = "linear",
        max_steps = 30, # Change to num_train_epochs = 1 for full training runs
        fp16 = not is_bfloat16_supported(),
        bf16 = is_bfloat16_supported(),
        output_dir = "outputs",
        report_to = "none", # Use this for WandB etc
    ),
)

@danielhanchen  Would it be ok if i open a pr to help with this issue?

So unsloth uses the newest version of trl always and just recently trl just updated and remove the tokenizer parameter to processing_class  mentioned here 2348
for now you can just try installing the older version at the top of the colab notebook
!pip install trl==0.10.1

check if it works
0.11.0  version will show a very weird warning

Unsloth will make backward compability I think

Just fixed @avemio-digital @dame-cell ! Please update Unsloth on local machines via pip install --upgrade --no-cache-dir --no-deps unsloth. For Colab, Kaggle, just refresh!

This has been fixed in trl v0.12.1, make sure to run
pip install --upgrade trl

please also note that tokenizer is deprecated, so you should prefer processing_class, as mentioned by @dame-cell in https://github.com/unslothai/unsloth/issues/1285#issuecomment-2473628461


source-bundle: generated script fails when a build element has no source

See original issue on GitLab
In GitLab by [Gitlab user @hashpling] on Aug 24, 2017, 14:31
If a build element doesn't have any sources, then the tarball won't contain a source directory for that element but the generate build- script will attempt to copy the contents of the directory to /buildstream/build and will error out due to set -e.
The simplest fix would seem to be to check for the existence of the source directory before attempting the copy in the build-module.sh.in template, but the exact shape of that change depends on the choice of fix to issue #67.
(Perhaps I should be using kind script instead of kind manual for an element without sources, but I think that these elements are omitted from source-bundle generated tarballs?)

In GitLab by [Gitlab user @tlater] on Sep 25, 2017, 14:01
created branch 75-source-bundle-generated-script-fails-when-a-build-element-has-no-source

In GitLab by [Gitlab user @tlater] on Sep 25, 2017, 15:25
mentioned in merge request !97

In GitLab by [Gitlab user @tristanvb] on Sep 27, 2017, 14:46
closed via merge request !97


Cannot use PathIconSource for TabViewItem.IconSource

When I use SymbolIconSource or FontIconSource for TabViewItem.IconSource, the application is happy.. but when I use PathIconSource for example:
<MUXC:TabViewItem Header="Bookmarks"                           IsClosable="False">             <MUXC:TabViewItem.IconSource>                 <MUXC:PathIconSource Data="M17 3H7c-1.1 0-1.99.9-1.99 2L5 21l7-3 7 3V5c0-1.1-.9-2-2-2z"/>             </MUXC:TabViewItem.IconSource>         </MUXC:TabViewItem>
then I got an exception: "The parameter is incorrect.\r\n\r\nThe parameter is incorrect.\r\n"	System.Exception {System.ArgumentException}
Version Info

NuGet package version:
[Microsoft.UI.Xaml 2.4.2]

Windows 10 version
Saw the problem?

Insider Build (xxxxx)

November 2019 Update (18363)

May 2019 Update (18362)
Yes

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Device form factor
Saw the problem?

Desktop
Yes

Mobile

Xbox

Surface Hub

IoT

To be sure, does this same PathIconSource work outside of a Tabview, like in a grid?

yes it does work outside of a Tabview.. in my case it works fine in NavigationViewItem..

I would like to look into this.

I think I found the issue, the PathIcon(Source).Data property is causing us problems here as it can't be shared, see #827. A possible solution would be to set the icon sources data to null while the TabViewItem consumes it. This of course is not ideal though. Another option would be to copy the data, however I am not quite sure how we would do this.

While not ideal, I think the "clearing" approach might be the best here given that it can not be shared anyway. If we are not choosing that approach, I would open a PR to at least catch PathIcons and skip them to not cause crashes.
@stmoy What are your thoughts on this?

Just ran into this. Is there a workaround I can use to get it working?


No such module 'Jukebox'

I have done exactly as mentioned in Readme.md. I am getting this error and couldn't figure out why. I checked on Stack Overflow. There are many answers on this topic, tried many of them but still the same.
Any help would be appreciated.

Just try to rebuild the app.


adding association's profil

Pull requests
Before submitting a pull request, please make sure the following is done:

Fork the repository and create your branch from master.
Make sure format your code.
If you've fixed a bug or added code that should be tested, add tests!

Done


fix(text-field): allow for input isValid override

fixes https://github.com/material-components/material-components-web-react/issues/356

Codecov Report

Merging #374 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
+ Coverage   96.97%   96.97%   +<.01%
==========================================
  Files          51       51
  Lines        1816     1819       +3
  Branches      209      210       +1
==========================================
+ Hits         1761     1764       +3
  Misses         55       55

Impacted Files
Coverage Δ

packages/text-field/Input.js
97.5% <100%> (+0.09%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4ad675...d531849. Read the comment docs.

Created https://github.com/material-components/material-components-web/issues/4054 which will include another follow up PR once completed.


Add REVOKED segment status to signal a segment that was shared is revoked

Adding REVOKED segment status to explicitly revoke a segment from the sharee so that Ansible/Segment Builder can act differently for such segments.
Please link to the issue
Issue Tracked => #1147

Thanks, this will unblock the 2nd-party audience sharing workflows, where the owner of the segment comes from a separate IMS Org.  It will also be used when promoting/revoking access to segment definitions between sandboxes.  @cmathis let me know if you have additional questions.

@shieldz Is there a difference between INACTIVE and REVOKED? Is there a reason we should add another status and not reuse what is there?

Yes, and it has to do with user roles.  If a segment comes from a different org or sandbox, an admin user from the receiving org/sandbox shouldn't be able to "reactivate" a REVOKED segment, but they could reactivate an INACTIVE one


API allows the deletion of "Unknown" group

@rentzso
API should reject this request. The "unknown" group is integral and assumed to exist within the api, and needs protection. @gsfr recommended leaving the choice of the HTTP response code up to you.
This is required for bali milestone.
From chrome inspector:
Request URL:https://localhost:8443/api/groups/unknown?root=true
Request Method:DELETE
Status Code:200 OK
Remote Address:<IP_ADDRESS>:8443

Good catch.


Update landing page

https://miro.com/app/board/o9J_lOltyEw=/?moveToWidget=3074457359247619452&cot=14

Bounty Level: Important
Complexity: Simple
Design Bounty: 20 Ada
Bounty: 40 Ada
Bounty Bonus: 15 Ada
Increase increment: 1 week

We should close this issue since it has been completed?


Improved deployment output

The PR ensures the following things:

Copy the most important alias to the clipboard, instead of the last one
All automatic aliases now have the https:// prefix
We're now printing a warning message if --target production, but no (or empty) alias was set

Codecov Report

Merging #1968 into canary will increase coverage by 0.26%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           canary   #1968      +/-   ##
=========================================
+ Coverage    6.28%   6.55%   +0.26%
=========================================
  Files          90      90
  Lines        4103    4106       +3
=========================================
+ Hits          258     269      +11
+ Misses       3845    3837       -8

Impacted Files
Coverage Δ

src/commands/deploy/latest.js
0% <0%> (ø)
:arrow_up:

src/commands/scale.js
0% <0%> (ø)
:arrow_up:

src/util/read-metadata.js
100% <0%> (ø)
:arrow_up:

src/util/get-project-name.js
100% <0%> (ø)
:arrow_up:

src/util/hash.js
100% <0%> (ø)
:arrow_up:

src/util/error.js
100% <0%> (ø)
:arrow_up:

src/util/get-files.js
100% <0%> (+3.1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 803b1ae...7a02548. Read the comment docs.


core: clean up a couple unneeded imports

Signed-off-by: Mike Schore<EMAIL_ADDRESS>

thanks mike!


docs: update README to add Ed's blog

Please answer the following questions and leave the below in as part of your PR.

[ ] This PR corresponds to an issue with a clear problem statement.

[ ] I have updated the CHANGELOG.md file with a description of the addressed issue.

Thanks!


feat: new aspectfit contain mode

this creates a new contain mode which is kind of a mix of outside and inside.
You can zoom out to see the full view while blocking the panning while zoomed in to the bounds of the view

Thanks for contributing! Please open an issue first explaining the feature and its main use cases. Then, any future PR will need to add tests.

inside can only satisfy when the content is smaller than the area.
outside can only satisfy when the content is larger than the area.
When the content starts smaller than the area and becomes larger after zooming, inside and outside cannot fulfill the requirement;
there will also be a problem of content exceeding the area and unable to zoom in or out.
aspectfit precisely solves this problem.
Apart from aspectfit, are there any other methods to achieve this?
Thank you.


package.json this is JSON

File package.json does not belong to the npm. This is a typical json file.
Maybe it's better this way:
{ icon: "npm", extensions: ["npmignore"] },

Or custom code that checks for existance of node_modules, .npmignore. Possibly even reading the file to see if it looks like the package.json schema, but I think that probably overkill/prone to hiccups.

@mrmlnc I just used the npm icon because I mostly use package.json on npm context. What other contexts does this file has? I've look into atom's icons and they just mark it as json. In fact, I just added this change today so... I can change it again if we have quorum ;D

For example, themes for VS Code:
https://github.com/marvinhagemeister/vscode-theme-afterglow-remastered/blob/master/package.json
Or, languages for VS Code:
https://github.com/mrmlnc/vscode-apache/blob/master/package.json
Or, GitBook use package.json to configure the plugins.
In truth, this is not so important :)

Ok! You've made your point. I'll change it to json icon! :+1:


feat: add metrics around stream lifecycle

Checklist

[X] I have read the coding guide.

Description
We suspect that the batchstores are out of sync and this generates a large amount of stream resets.
This branch will print the batchstore fingerprint to allow for detection of inconsistencies.
Closes: #3439

This change is

replaced by https://github.com/ethersphere/bee/pull/3474


Add method to override language of X-API-LANG header.

The existing localization behaviour gives priority to the X-API-LANG request header to extract the locale (see extractLocale in i18nHelper). But we need a way to override this behaviour in specific cases (for example when generating a report with a given customer language).
The proposal solution adds a method to just override the request language without breaking existing behaviour, so we can use it like this:
Request::setLanguageHeader($language);  PDFService::changeLocale($customer->getCode(), $language);
Maybe this is not the cleanest solution, but changing I18nHelper is challenging without breaking existing behaviour and affecting entire platform.

Hi @gabmarfer, thanks for your feedback and using PSFS. I've check your proposal and I want to suggest a different approach to solve it.
Essentially the locale extracted from headers is stored in memory during the script execution to know the language for the request and the Dispatcher extract it from the headers X-API-LANG and HTTP-ACCEPTED-LANGUAGES. In case of running PSFS in command line for tasks, it gather the default locale from the config.
There is a helper class named I18Helper that has this mission in the framework and it allows to pass a default locale in case you are running a task command and the running process doesn't have any http header.
To force an specific language when you are in a HTTP request, I suggest to modify the setLocale static method from the
I18nHelper to ignore the base behavior and set directly the passed default language:

Modify the static method parameters in the I18nHelper class to allow a way to force the default locale
 public static function setLocale($default = null, $force = false)

In the first line, just evaluate if $force parameter is set to true avoiding the default behavior where checks the HTTP headers
locale = $force ? $default : self::extractLocale($default);

It will be a best and easy solution, I've just pushed this solution to the latests version with unit testing to ensure that it works. Please, try it and tell me if you still need your patch.
Thanks

Thanks for your reply. I thought about your approach before proposing this Pull Request.
You have to take into account that extractLocale function is called within translationsCheckLoad from CustomTranslateExtension class. You could add force=true in that call, but this would introduce a hidden behaviour that can break the current one. So, you will need to add the argument to the public static function _($message, $customKey = null, $forceReload = false) and pass the force=true for every single translation or think in another feasible solution.
Thanks again!


Support for creating sub-accounts?

Issue Summary
I would like the ability to create sub-accounts under my master account, allocate them API keys + MessagingService and pass that and the SIDs back into my TF state.

is that not loosely equivalent to suspend / close subaccount endpoints?

Yes, it's loosely equivalent, but it would need to be added as an exceptional case because there's no explicit DELETE operation as there are with other resources.

Really would love for this to be added, only thing holding us back from using this in production. 'Close' seems to be the best option since closed subaccounts will be automatically deleted after 30 days anyways.
This other Twilio provider seems to be working just fine with subaccounts https://registry.terraform.io/providers/RJPearson94/twilio/latest/docs/resources/account_sub_account

+1 for this.  I'm trying to ensure subaccounts are created consistently across our environments, as code.
I've been fighting terraform every step of the way with this goal (initially i wanted to create accounts in the organisation consistently too but there isn't even an API for that), and was really surprised when i saw we can manage sub accounts either.


Use fallback user avatar in cases where the user is unknown to us

Details

this is PR is a followup after this: https://github.com/Expensify/App/pull/39229 was reverted, it also fixes issues that were found after the original PR merge
the logic that decides which avatar to show is now consolidated into the <Avatar> component, almost all calls to getAvatar and getDefaultAvatar were removed as they were mostly concerned with showing a correct SVG avatar version - now <Avatar> does all this
right now the source of truth is almost always avatar prop from personalDetails. It is returned from backend, and any user "known" to us will have it set
we will now display FallbackAvatar when:

there is no details/accountID
when accountID was optimistically set in TS code
as a final fallback in Avatar component (that behaviour is unchanged)

special note for icons: whenever we create icons array/object we have to explicitly set FallbackAvatar as source. Otherwise nothing would be shown because of patterns like this one: https://github.com/Expensify/App/blob/main/src/components/OptionRow.tsx#L209

Extra notes for reviewer:

please note that a PR affecting workspace avatars logic was merged some time ago, but after the revert: https://github.com/Expensify/App/pull/39637/files - it introduced usage of accountID for both user account and policy id.
Because of this we were already passing accountID to Avatar component in some places
☝ introduced a bug related to Workspace avatar colors styling, if you notice something wrong with WS avatar please verify that its not already on main - this line seems problematic: https://github.com/Expensify/App/blob/main/src/components/Avatar.tsx#L97

CC @s77rt
Fixed Issues

$ https://github.com/Expensify/App/issues/38743
$ https://github.com/Expensify/App/issues/40989
$ https://github.com/Expensify/App/issues/40996
PROPOSAL:
Tests

go to every place in the app where we can display an unknown user and verify that the avatar next to them is the fallback one (and not the colorful one)
places to verify:

search option from Chats list
searching users from "Start chat"
searching users from "Split expense"
searching users from "Pay someone"
searching users from "Assign Task"
searching users from Workspace list > Workspace > Members > Invite member

test https://github.com/Expensify/App/issues/41014:
verify that small avatars in mentions from chat are correct including Concierge avatar
test https://github.com/Expensify/App/issues/40989:

go to Workspace list > Workspace > Members
turn on offline mode (disable network in devtools) and try adding a non-existing user to members
verify that profile page opens

test https://github.com/Expensify/App/issues/40996:

check if the avatar in quick action from Popover menu is the same as newly added user

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/3929868/aebd1b4d-df48-40ef-933f-e2829bf1875f

Android: mWeb Chrome

iOS: Native
https://github.com/Expensify/App/assets/3929868/419d996d-c16f-4b86-ac34-4cef462c5327

iOS: mWeb Safari

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/3929868/a42534b6-d59e-4af8-bd18-54da22085660
https://github.com/Expensify/App/assets/3929868/241d09d8-23d4-4ee6-9447-3793917779f6
https://github.com/Expensify/App/assets/3929868/39a43fe9-e9f0-4f26-9efb-ad4bbcd37608

MacOS: Desktop

@s77rt thanks for all the comments, some notes from me:

please take a look at: https://github.com/Expensify/App/pull/41485/files as it introduces some changes related to workspace and it will most likely get merged before our PR
I decided that always passing explicitly accountID={undefined} looks out of place as its almost never done in this project, so I kept accountID? as optional
also: <MenuItem> renders <Avatar>, and MenuItem is rendered 100+ times in the App - I don't want to add accountID into all this places
about Icon read my comment, I would really like to return to source being not optional there I think it will be better for the codebase in the long run

Bug: In the task assignee the assign to me row has the fallback avatar

All changes pushes @s77rt
I like the types suggestion but in the end I don't want to add any more changes because this PR is constantly growing, maybe in future we can add the union.
For the bug that you found there is something wrong in the whole chain of calls : TaskAssigneeSelectorModalProps -> useOptionsList -> OptionsListUtils.createOptionList -> createOption which returns a list of options that include empty Icon only for current user - so Im simply recreating the proper icon. Investigating this chain of calls was extremely difficult and in the end I don't know where to fix it.

Can you please test if that bug is still reproducible? (without the workaround) I'm getting a different icon now which is also wrong but same as staging

So without workaround it reproduces for me every time on web. I have a feeling that whether you get this bug is related to state of personalDetails key in onyx, because the logic that generates these options combines together a lot of data. If I explicitly search for myself then sometimes the avatar updates, but after a full page refresh I'm always back to the bug.
However I tried running it on ios and there I had the correct avatar :/
I think its better to keep the workaround if there are some cases where this bug appears

In main / staging can you reproduce the bug? If not then it's a regression and we should fix it without workarounds

Can you please resolve the conflicts and remove the workaround? I cannot reproduce this constantly but feels like we should handle it separately

1 minute I pushed a bug

Ok all done, workaround removed.

omg I can't believe there was a test for this - I'm fixing the test now

Reviewer Checklist

[X] I have verified the author checklist is complete (all boxes are checked off).
[X] I verified the correct issue is linked in the ### Fixed Issues section above
[X] I verified testing steps are clear and they cover the changes made in this PR

[X] I verified the steps for local testing are in the Tests section
[X] I verified the steps for Staging and/or Production testing are in the QA steps section
[X] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[X] I checked that screenshots or videos are included for tests on all platforms
[X] I included screenshots or videos for tests on all platforms
[X] I verified tests pass on all platforms & I tested again on:

[X] Android: Native
[X] Android: mWeb Chrome
[X] iOS: Native
[X] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[X] MacOS: Desktop

[X] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[X] I verified proper code patterns were followed (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I verified that this PR follows the guidelines as stated in the Review Guidelines
[X] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[X] I verified that all the inputs inside a form are aligned with each other.
[X] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Networking issue

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

https://github.com/Expensify/App/assets/16493223/a833aabd-002c-4983-9bd2-22e25f308a13

Also @grgia may be interested in taking a look at this since she has some context about avatars I believe.
Also I think we should wait until this gets merged: https://github.com/Expensify/App/pull/41485 as the two will have a slight conflict and the other one is hotfixing a bug. Besides mine is bigger so it will take more time to merge the other way around.
So even if everything is good here please refrain from merging until 41485 lands on main

Merged main and updated my code to work after this workspace avatars fix: https://github.com/Expensify/App/pull/41485/files

@Kicu Can you please merge main again to fix the ts errors

@shawnborton or @dubielzyk-expensify I have one more avatar related PR- I just spun up a test build if you'd like to take a look. This one handles the changes to fallback avatars after the first take was reverted

Found a missing spot when viewing the workspace avatar from the workspace overview page:
https://github.com/Expensify/App/assets/2319350/4c7bb51e-c9b0-4fa6-a3a1-4952384aa0c9

@shawnborton great find.
I checked that the same bug is currently appearing on web so its not introduced by my code, but rather another bug after this: https://github.com/Expensify/App/pull/39637
However if thats okey with you guys I could try to fix this within this PR as hopefully that will be faster.

Amazing, thanks!

@mountiny Done and done

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.77-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


adding explicit version of rules_python to workspace

it seems protobuf (or another package) is loading and outdated rules_python as a dependency. hence, we have to load an up-to-date rules_python version first. this is required for oss-fuzz.


update

@baskaryan, I am not an expert in this repo, in fact, this is my second code review.
The changes make sense. However, having a description of the PR may be useful, if there is an issue relevant to this PR, you might wanna link it, etc. Also, a more explanatory title may help.


[IMPROVEMENT] Useless [ExecuteAlways] and Update() calls in CanvasSliderVisuals, editor slider value not sync in playmode

Describe the problem
The script CanvasSliderVisuals uses an Update() function to do things in the editor.
https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity/blob/e30b350c131501084a4f9003cba1361248717f66/org.mixedrealitytoolkit.uxcore/Slider/Visuals/CanvasSliderVisuals.cs#L166
I fell it is not necessary in this case, a OnValidate() function should do the job. The [ExecuteAlways] could then be removed, improving in editor performances.
Moreother, the handle position is not updated when modifying the slider value from the inspector in playmode. This is different from the classic Unity UI. I d'like the behaviour in editor to be the same as the Unity UI slider.
Describe the solution you'd like

Replace the [ExecuteAlways] and Update() with an OnValidate() function or other Unity editor tools.
Make the editor slider value sync in playmode (and send value changed events like Unity UI)

Low priory issue, worth investigating.

Hi @anonymous2585 ,
Thank you for reporting this issue. We appreciate your feedback and interest in MRTK3.
We have reviewed your issue. We have added it to our backlog and will prioritize it accordingly.
However, if you would like to speed up the process and contribute to the MRTK3 project, you are welcome to submit a Pull Request with your proposed fix or implementation. We would be happy to review your code and merge it into the main branch if it meets our quality standards.
Please let us know if you have any questions or need any assistance. Thank you for your support and collaboration.
Best regards,
The MRTK3 team


Sinking Arthrobotrya into Teratophyllum (Dryopteridaceae)

Author(s) of proposal
Zheng-Yu Zuo
Name of taxon
Arthrobotrya
Rank of taxon
Genus
Approximate number of species affected
2
Description of change
Arthrobotrya was a small genus in PPG I that used to be treated as a synonym of Teratophyllum. Recent study showed that both the molecular phylogeny and morphological characteristics evidences support treating Arthrobotrya as a synonym for Teratophyllum.
Reason for change
Arthrobotrya was recognized by PPG I but has recently been shown to be nested in Teratophyllum. The key morphological characteristics distinguishing Arthrobotrya from Teratophyllum are also not clear.  Furthermore, Teratophyllum and Arthrobotrya share similar habits and overlapping distribution areas.
Reference(s) for publication of the name
Z.-Y. Zuo, G. Rouhan, S.-Y. Dong et al., A revised classification of Dryopteridaceae based onplastome phylogenomics and morphological evidence, with the description of a new genus, Pseudarachniodes, Plant Diversity, https://doi.org/10.1016/j.pld.2024.07.010
List the numbers of any related issues
No response
Code of Conduct

[X] I agree to follow the PPG Code of Conduct

Arachniodes macrostegia and A. ochropteroides which are closely related to Olfersia in Lu et al. (2019) is absent in this article. So now the genus Arachniodes s.s. is not still defined.

If there are some conflicts of interests, I have a concern there are no comments about Arachniodes macrostegia and A. ochropteroides in Zuo et al . (2024). According to the phylogeny of Lu et al. (2019), It needs to define two different genus for these two species to define the genus Arachniodes s.s.
A plastid phylogeny of the fern genus Arachniodes (Dryopteridaceae)
Ngan Thi Lu, Atsushi Ebihara, Hai He, Liang Zhang, Xin-Mao Zhou, Ralf Knapp,Peris Kamau, David Lorence, Xin-Fen Gao, Li-Bing Zhang,
https://doi.org/10.1016/j.ympev.2018.12.013


Improve supported platforms description

Fix #696

My suggestion on the call was:
We maintain compatibility and explicitly support these platform versions, including performing CI testing on all library revisions.
We do not explicitly maintain compatibility with older platform versions; we no longer perform CI testing on iOS8 as of version 1.0.11. Any known incompatibilities with older versions can be found at https://github.com/ably/ably-ios/issues?q=is%3Aissue+is%3Aopen+label%3A"compatibility".
Please raise an issue or contact Ably customer support for advice if you find a problem with, or wish to have support for, unsupported platform versions.

@paddybyers @mattheworiordan WDYT about latest version I pushed?

We recommend our customers drop support for iOS8 given that less than 0.5% of users are still using it as of Feb 2017.

Really I don't think it's our place to tell customers what versions they should support in their app.
My suggestion was:

Please raise an issue or contact Ably customer support for advice if you find a problem with, or wish to have support for, unsupported platform versions.

I think that says what we want to say.

@paddybyers better now?

better now?

LGTM

@mattheworiordan one last check before merging?


HI i have problem with this challenge,i have changed my browser zoom (100%) but it still doesn"t work

Challenge Size your Images has an issue.
User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
 But your code is incorrect.
GitHub Issues are for reporting bugs on the website only.
Please use the Help chat room for getting challenge related help.
Happy Coding.


PR: Don't limit subject in message view to 3 lines

Fix for #1861
Question:
In this xml file several deprecated functions are used (like android:singleLine or android:toLeftOf).
Can I just change them in this PR or should such things happen in a different PR?

Question regarding this: what will that do if the title is very long? Does the header scroll work independently of message scroll or not? Not very common and probably not a to be supported use case, but I have at least one threads of emails where someone put a whole book in the title (which turned to be a good crash test case for email clients).

The header is included in the message scrolling, so that shouldn't be a problem.

OK, so just long scrolling. Seems fine given the limited use case, but still I’m a bit concerned that this could mean less space for message body in some emails. Could we have a better UI here ? Like reducing the title to one line or two (minimum size in height), but being able to tap it to open a pop-up window (like the “About” one) with the full title? Or maybe make it a foldable field, I think that’s part of the Material Redesign or should be. ;)

Why would you not want to be able to see the full subject without expanding it? Even if people put lots of text there, presumably it's important text you want to read.

@GoneUp: Thanks for the fix!

Well a whole book in the title is a troll, nothing important to read. But I agree that’s not common.
However, even if the title is important, maybe I don’t need to read it each time I go to such an email if what I’m interested in is something in the body. So having the title folded as the default looks like a more sensible default to me, but maybe that’s only my opinion. Anyway, if that ever become an issue, I’ll feel free to open a ticket for that. ;)


Export specific collection

I know there's been discussion on how to handle limiting the meshes being exported.
I would love to see an option to select a single collection to export.  Since objects can belong in many collections, this would allow for users to select specific objects for export.  For example, I would create collections called 'LowPolyExport' and 'HighPolyExport'.
I know the current way to do this might be 'Export selected meshes' or even 'Export visible' but the problems with these are that they aren't persisted when the .blend is saved.  I want to have a collection so that I can repeat a glTF export from a .blend file without having to remember exactly what was selected last time.
I'm not up to speed on Blender's Python but I am diving into the source code at the moment to try and isolate issues. I have a very complex Blender scene which I'm trying to export to GLB and then across to Babylon JS - at the moment the exporter hangs constantly but I'm not able to share the scene publicly. So I am working to isolate the issues and create files that replicate them.  You'll see me here quite a bit for the next month :)

I implemented this feature on a fork.  Forgive me - I never submitted a pull request, I don't really know Python, I have no idea how to automate any testing or anything like that so I'll just link to my code here.
I found that the FBX exporter is quite nicely set up and already included this feature.  I don't think the way I am doing it efficient at all - for every node I am parsing over the list of all objects in the active collection, converting it to a list and filtering based on that.  A much neater way, and the way that the FBX exporter does it, would be to simply select the active collection, get all its objects, and then pass them onto __filter_node() to be filtered.
Anyway my effort at this is here.
https://github.com/AlexMuir/glTF-Blender-IO/commit/bff2173bd21440e3e7bcf67135a37441dcbc08a8

Fixed by 69746b2b31eeee080d5dfd3c74f1e02742795ed2


Use github's docker registry

Describe the solution you'd like
Instead of using docker hub, we can simply use github's own docker registry. Update .github workflow to reflect this

veidemann-scopeservice has an example of existing solution for this


x/tools/gopls: improve highlighting

Document highlight doesn't provide highlighting for fields or multiple uses of the same function. Should it? This issue will track missing behaviors for the textDocument/highlight command.

@ridersofrohan will be working on this

Commit 0a3398
Improved tests for highlights by allowing you to specify what should be highlighted for each mark. Also fixed issue #2785.

Commit 66c5a5
Adds control flow highlighting within for loops.

I think that this can be closed after https://go-review.googlesource.com/c/tools/+/208267. Thanks @ridersofrohan!


Checking if address is within a function's catch block

I'm looking to get the function which contains an address. However, I noticed that if the address is contained within a try block, getFunctionContaining will return null even though it is contained in a function. Is there a way I can check if the address is in a catch block and then retrieve the function containing said catch block?

So the FunctionManager's getFunctionContaining should be giving me the function. I'm either doing something that is causing it to disassociate with the function, or running my analysis before the gcc exception handler analyzer. Need to figure out which. Regardless this no longer needs to be open.


Nested project in $expand segment

Hi , i focus the project for long time , i thank the v4 sould be support nested navigation expand query:
see odata-v4.0-errata03-os-part1-protocol-complete <IP_ADDRESS>

http://host/service.svc/Customers?$expand=Orders
http://host/service.svc/Customers?$expand=Orders($filter=Amount gt 100)
http://host/service.svc/Orders?$expand=Items($expand=Product),Customer
http://host/service.svc/Customers?$expand=SampleModel.VipCustomer/InHouseStaff
http://host/service/Employees?$expand=Model.Manager/DirectReports($levels=4)

thank you !
xiaoxin

The following were implemented in Net.Http.OData 5.0.0 (released 25/03/2020)

http://host/service.svc/Customers?$expand=Orders
http://host/service.svc/Customers?$expand=SampleModel.VipCustomer/InHouseStaff

Support for the other parts of the spec will be implemented in a future release


Validates short options. Closes #5657

Validates short options. Closes #5657

Merged manually, thank you! 🥳


Reset mod settings on every load or start game

@StrongMods Thanks for your contribution! Your change seems solid. I won't have access to a Windows machine this week, so I cannot validate it at the moment, but I'll review it next week.
I've updated the to-do list. Here are the critical issues I see for this repo's implementation:

[DESIGN] Simplify the mod's usage. Think about integration with UCP for a smoother installation process.
[CHORE] Expand support to accommodate multiple players. As of now, the mod supports only the red player in multiplayer.
[CHORE] Blend autoselling with an in-game function, like adding an item to the stockpile. This would aid in UCP compatibility.

While UCP 3.0 might simplify things significantly, it's still not ready/public. We might want to consider working with the existing UCP 2.15b in the meantime.


Dev coder sudo

Thank You

Hi @Dev-coder-sudo, please carefully read the README file before contributing to any file. Maybe by mistake you have created a markdown outside the contributors folder please delete that and again push your changes.
I'll happy to merge you changes 😊
Happy learning!

OK I will make the necessary change
Thank You
On Wed, Oct 4, 2023 at 10:10 PM Suraj Kumar @.***>
wrote:

Hi @Dev-coder-sudo https://github.com/Dev-coder-sudo, please carefully
read the README file before contributing to any file. Maybe by mistake you
have created a markdown outside the contributors folder please delete that
and again push your changes.
I'll happy to merge you changes 😊
Happy learning!
—
Reply to this email directly, view it on GitHub
https://github.com/Suraj-kumar00/Getting-started-with-Git-Github/pull/5#issuecomment-1747271679,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASJN3CYD6KQ2KVF4EKT2WN3X5WGQVAVCNFSM6AAAAAA5S4VOQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBXGI3TCNRXHE
.
You are receiving this because you were mentioned.Message ID:
@.***
com>

I made the change. Can you please review it.


Missing ZefyrScaffold and ZefyView

Please take a look into original discussion. The ZefyrScaffold and ZefyrView widgets were replaced with ZefyrEditor widget.


Lower-case classname prop for tags with hyphens

Really specific:
const Element = styled('linear-gradient')``;

Will render:
<linear-gradient classname="sc-gZMcBi giNnHm"></linear-gradient>

Notice the classname instead of class.
This only fails when calling styled() to render an element with a hyphen in the tag. Also fails when using the as prop. I tried it with all the hyphenated tags in domElements.js + details-menu, it fails for all of them. Putting the camelCase version of the tag (linearGradient) renders the wrong tag (lineargradient all attached) with the right prop. Calling the helper (styled.linearGradient) works great though.
Here is a sandbox with the issue: https://codesandbox.io/s/1z1k0jlny7
Am I missing something?
Edit: I'm using styled-components 4.2.0

I had the same issue when I was working with AMP custom tags like <amp-image className='test' />.
I think it should be treated as Web Components in react and styled-component should pass class instead of className

If you use React with Web Components (which is uncommon), use the class attribute instead.

Does React itself handle hyphenated tag names differently? We generally follow whatever React does.

Am I missing something?

Oh, you have no idea, past me, you have no idea.
Sorry, finally had some time to come back to this, basically:

The real tag is <linearGradient /> (with a capital G for some reason), but <lineargradient /> is perfectly fine too, the lib gets it right. There is no <linear-gradient />, my bad. Don't do CSS kids.
<details-menu /> is a custom element, styled-components doesn't know that and react just doesn't recognize it as a standard html5 tag, like @d7my11 said. Not the lib's fault as far I can tell.

<linear-gradient /> is treated as a custom element, react doesn't like them, and everything is fine. Could be possible to fix custom elements in the lib, but that looks way beyond what I had in mind here.
In short: I messed up, sorry... Close?


Adding tslint, take 2

This PR adds tslint rules from tslint-wix-react: https://github.com/wix/tslint-wix-react/blob/master/tslint.js as team agreed.
And also delivers all source and demo, and tests files linted.
During the linting I added some specific rules to test/ folder and turned off some rules in main preset repo.

Squash to master after travis passes.


GSD CI/CD pipeline rules/checks

GSD CI/CD pipeline rules/checks
At a minimum:

Flag any file deletions, we shouldn't be deleting files
Flag any malformed directories/filenames
Ensure JSON is actually JSON, and format it as per our standards (e.g. https://github.com/cloudsecurityalliance/gsd-tools/blob/main/local-scripts/print-json.py)
LONG TERM: take any URLs and mirror them
LONG TERM: JSON schemas

@oswalpalash added a check for valid JSON in https://github.com/cloudsecurityalliance/gsd-database/pull/2291

See https://github.com/cloudsecurityalliance/gsd-database/pull/2295 for point 1.

Copy-pasting my comment from the other PR :  I think we should formalize all of these scripts in the gsd-tools repo and use it from there. I think we're going to end up having complex github actions and it'd be nice to use all scripts from there. While we're not using it at scale now, but starting right early will save us time and help us iterate on things without having to clone this massive dataset everytime.

Yes this seems to be the right course of action.
I think 1. and 2. can be done by small shell and python scripts.
But  "3. Ensure JSON is actually JSON, and format it as per our standards " requires a syntax parser  and a format parser and to my knowledge there is no tool to check the format of JSON file. The only tools I have found rewrite the entire file with every execution time and a comparison of the file with the output is a waste of CPUtime.
From my experience with this database this will take ages for large commits.
Also is it very inconvenient to wait for test on a PR.
So I would suggest to build a tool which reads in each JSON files ones, parses it for the format and then as JSON.
Later the same tool could check for schema validation.
For the format parser you can just tokenize the files into {, }, [, ] and the space indention ( ^'  '*4)  and then check if the number of unmatched braces is equal to the indention tokens. (Similar to the way python does it.)
Do you have any preferences regarding programming languages?
I have some done some work with rust https://github.com/raphaelahrens/json_analytics and the GSD databse and are now able to parse and analyze the whole dataset in a few minutes.
Also a custom parser is quickly written with nom.

I created a branch with a work in progress JSON validator.
It reads in a list of files via stdin.
Parses them with serde_json to make sure it is JSON.
Then it checks the indention of the lines.
The format parser is new code and still needs testing.
https://github.com/raphaelahrens/gsd-tools
To test it you can run
cd json_validator
fd '.*' --extension=json  ~/git/gsd-database | cargo run --release

Or run it with find
find  ~/git/gsd-database  -iname "*.json"| cargo run --release

@kurtseifried  and @joshbressers I noticed that the GSDs which are created via the webform have a different indention because of this line of code.
		gsd_json = JSON.stringify(gsd_data, null, 2);

https://github.com/cloudsecurityalliance/gsd-tools/blob/40930fd06cea629f1047179b5eada349cc758c5f/webform/routes/gsdform.js#L64
But the script which @kurtseifried mentioned as a reference for the format uses 4 space indention.
What is your opinion, do you want a fixed indention or is it ok to have a %2 and a %4 indention?
Also tab vs spaces? :laughing:
The validator is currently complaining about the format of 3803 files.

The actions have now been moved to gsd-tools and there is a PR to use them in this repo. https://github.com/cloudsecurityalliance/gsd-database/pull/2318

I'm closing this for now. We can open new issues for the long term goals when we're ready.
thanks for this @raphaelahrens !


Roll Flutter Engine from fdc667ebb34e to 01e247a9ab39 (4 revisions)

https://github.com/flutter/engine/compare/fdc667ebb34e...01e247a9ab39
2024-10-14<EMAIL_ADDRESS>Use GWeakRef API (flutter/engine#55795)
2024-10-14<EMAIL_ADDRESS>Remove unnecessary use of std::vector (flutter/engine#55796)
2024-10-14<EMAIL_ADDRESS>Remove fl_keyboard_view_delegate_subscribe_to_layout_change and just access the object directly via a method (flutter/engine#55817)
2024-10-13<EMAIL_ADDRESS>Split out FlKeyboardLayout into its own class (flutter/engine#55816)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Add simple PMTU calculation with heartbeats

Calculate the maximum MTU size that can travel the entire path machine1<->machine2.
The easiest way is probably to craft heartbeat messages starting at the maximum value until they are successfully returned.  Potentially listen to ICMP PacketTooBig

@enobufs is this still an issue/something that needs to be done?

SCTP RFC actually mentions RFC4821 which recommends using the heartbeat. It is an interesting approach.  The current implementation does not fully support heartbeat. In WebRTC context, we have heartbeat at ICE layer, and I am not sure how critical it is not having heartbeat at SCTP layer..
I think we need to investigate how other WebRTC libraries deal with path MTU discovery.

I think we need to investigate how other WebRTC libraries deal with path MTU discovery.

AFAIK libwebrtc actually has the PMTU hard coded to a safe low value (I would have to lookup the exact value).
And yes the two options are either on the SCTP or the ICE level.
The ICE PMTU would have the advantage that the same information could get passed to the RTP stack as well.
But the problem is that for ICE there was only a draft for figuring out the PMTU, never an RFC. And AFAIK there is no other implementation which supports the ICE way.
The SCTP approach is way more interoperable.


Refactor

Created new path (active if report_version==5), which gives the same reports as version 4 but using new refactored functions.
Main changes:

reduced server side code to essentially calling two functions (get_report_settings and produce_report)
get_report_settings creates a list of lists containing all the required information to produce report except questionnaire inputs
produce_report is a universal function that can produce any of the reports in any of the two formats (html, rtf)
added several unit tests and a report test (a test that generates some reports and checks if they are unchanged)

Less important UI-related changes

added modal message when HTML report is under construction
restricted conditions to refresh HTML report to prevent the report from rendering again after clicking "prev" on the report tab
getting sidebar_toc feature to a more mature state

I am a bit confused with tests. If I run devtools::test() the result is OK, but when I run devtools::check() it is failed. I will try to investigate, but do not feel expert with this. If you have any help suggestions I am open

Finally clean check. Turned out that wrong capitalisation of the image name does not impact local execution but does impact github. Strange

Overall looks good, what' sthe plan with functions to add and functions to delete, will there be a future PR to clean up?

functions_to_delete are required for report_version <= 4. If we agree to remove those version then I remove functions_to_delete (and merge function_to_add with functions)


CommentThread class missing from release

Expected behavior

CommentThread class included in Timber release on WP.org
Actual behavior

There is no CommentThread class. Also files Comment.php and Post.php differ between git branch 1.2.0 and actual 1.2.0 release.
Steps to reproduce behavior

Download zip from https://downloads.wordpress.org/plugin/timber-library.1.2.0.zip and unpack it
Look for CommentThread.php file in the lib folder
File is missing

Thank you so much @jakub300 — I'm not sure what happened there. It's now fixed and I'll push out a <IP_ADDRESS> so that existing users of 1.2 get the patch


PHP configuration directory along versions leads to problems

The PHP_INI_SCAN_DIR env is very useful but the current path leads to problems.
The conf directory is placed along with the version directories inside scoop/apps/php
Scoop picks conf as the latest version and also updates from conf to $latest even if $latest is already installed.
$ scoop list
Installed apps:

  php (conf)

$ scoop update php
updating php (conf -> 7.1.0)
uninstalling php (conf)
installing php (7.1.0)
creating shim for php
creating shim for php-cgi
running post-install script...
php was updated from conf to 7.1.0

I would suggest creating a separate directory conf along apps, cache, shims for such version independent configurations. For the php example it would be scoop/conf/php/ and the env_set would be set to following (or we define a $config_dir variable)
"env_set": {
    "PHP_INI_SCAN_DIR": "$dir\\..\\..\\..\\conf\\php"
},

This will break current php installations!
A dirty workaround could be filtering conf as version inside the versions function from lib/versions.ps1

Yes, I agree ~/scoop/conf/php would be a better location.
And it would also be good to allow $conf_dir in the env_set. I prefer $conf_dir to $config_dir for consistency, and to avoid confusion with scoop config.
Maybe we could add a post_install script to php.json to look for ~/scoop/apps/php/conf, and move it to ~/scoop/conf/php if it exists?
Are you happy to submit a PR for all these?

Yes, I will look into that


doc: add AUR instructions

I packaged sxtetris in the AUR: https://aur.archlinux.org/packages/sxtetris 🥳

Thank you!


Slide thr screenshots instead of clicking on the pages

Hello, Pham Sy Minh!
I've got a question.
I really liked that you could slide throught screenshots in version 1.4.3, 1.6.0 - its easy to check hundreds, thousands of screenshots
Clicking to slide the screenshots really sucks.
Is it possible to make a variable like --slide and make screenshots slide instead of clicking?
Q.2 what variable controlls the amount of screenshots in the line with /pages/simillarity? ( currently its 2 similar screenshots per line which is really low and time consuming)? is it possible to make it bigger? like 5 or 6 screens per line
Thanks for the advice and help!

I don't really understand your first question, about your second question, the original one allows like 4 screenshots per line, but I changed it to 2 because decreasing the number of screenshots per line will increase the screenshot size, which I think makes it 's easier to realize small interesting things in the screenshots, at least in my point of view. Tho if you want to change it, I'm ok with that


Support integer values for interpolation in the prototype transforms

Following #7241, this adds support for integer values for interpolation to the prototype transforms.
cc @vfdev-5 @bjuncek

Test failures are just test suite problems: https://github.com/pytorch/vision/actions/runs/4178150405/jobs/7236602113#step:10:2123 (Still need to fix them though)


code window is asked to be reloaded when vls runs for a long time

If VLS is running for long then sometimes it makes the editor to hang and then asks for user to reload the window.

can u state here what editor and os are u using? as well as instructions that we can use to reproduce that issue 🙂

can u state here what editor and os are u using? as well as instructions that we can use to reproduce that issue 🙂

I am using the V compiler and my OS was Windows 10. I had to write bad code for VLS to detect then fix it afterwards then when doing make on the issues trigger sometimes.

I am using the V compiler and my OS was Windows 10. I had to write bad code for VLS to detect then fix it afterwards then when doing make on the issues trigger sometimes.


Instantiate chaincode......

error: [client-utils.js]: sendPeersProposal - Promise is rejected: Error: 2 UNKNOWN: chaincode error (status: 500, message:  is not a valid endorsement system chaincode)     at new createStatusError (/opt/gopath/src/github.com/hyperledger/caliper/node_modules/grpc/src/client.js:64:15)     at /opt/gopath/src/github.com/hyperledger/caliper/node_modules/grpc/src/client.js:583:15 error: [client-utils.js]: sendPeersProposal - Promise is rejected: Error: 2 UNKNOWN: chaincode error (status: 500, message:  is not a valid endorsement system chaincode)     at new createStatusError (/opt/gopath/src/github.com/hyperledger/caliper/node_modules/grpc/src/client.js:64:15)     at /opt/gopath/src/github.com/hyperledger/caliper/node_modules/grpc/src/client.js:583:15 error: [client-utils.js]: sendPeersProposal - Promise is rejected: Error: 2 UNKNOWN: chaincode error (status: 500, message:  is not a valid endorsement system chaincode)     at new createStatusError (/opt/gopath/src/github.com/hyperledger/caliper/node_modules/grpc/src/client.js:64:15)     at /opt/gopath/src/github.com/hyperledger/caliper/node_modules/grpc/src/client.js:583:15 error: [client-utils.js]: sendPeersProposal - Promise is rejected: Error: 2 UNKNOWN: chaincode error (status: 500, message:  is not a valid endorsement system chaincode)     at new createStatusError (/opt/gopath/src/github.com/hyperledger/caliper/node_modules/grpc/src/client.js:64:15)     at /opt/gopath/src/github.com/hyperledger/caliper/node_modules/grpc/src/client.js:583:15
`
not ok 4 Failed to instantiate chaincodes, Error: Failed to send instantiate due to error: Error: Failed to send instantiate Proposal or receive valid response. Response null or status is not 200. exiting... at Client.newDefaultKeyValueStore.then.then.then.then (/opt/gopath/src/github.com/hyperledger/caliper/src/fabric/e2eUtils.js:385:19) at  at Client.newDefaultKeyValueStore.then.then.then.then.then (/opt/gopath/src/github.com/hyperledger/caliper/src/fabric/e2eUtils.js:398:15) at
operator: fail
at: chaincodes.reduce.then.catch (/opt/gopath/src/github.com/hyperledger/caliper/src/fabric/instantiate-chaincode.js:69:19)
stack: |-
  Error: Failed to instantiate chaincodes, Error: Failed to send instantiate due to error: Error: Failed to send instantiate Proposal or receive valid response. Response null or status is not 200. exiting...
      at Client.newDefaultKeyValueStore.then.then.then.then (/opt/gopath/src/github.com/hyperledger/caliper/src/fabric/e2eUtils.js:385:19)
      at <anonymous>
      at Client.newDefaultKeyValueStore.then.then.then.then.then (/opt/gopath/src/github.com/hyperledger/caliper/src/fabric/e2eUtils.js:398:15)
      at <anonymous>
      at Test.assert [as _assert] (/opt/gopath/src/github.com/hyperledger/caliper/node_modules/tape/lib/test.js:224:54)
      at Test.bound [as _assert] (/opt/gopath/src/github.com/hyperledger/caliper/node_modules/tape/lib/test.js:76:32)
      at Test.fail (/opt/gopath/src/github.com/hyperledger/caliper/node_modules/tape/lib/test.js:317:10)
      at Test.bound [as fail] (/opt/gopath/src/github.com/hyperledger/caliper/node_modules/tape/lib/test.js:76:32)
      at chaincodes.reduce.then.catch (/opt/gopath/src/github.com/hyperledger/caliper/src/fabric/instantiate-chaincode.js:69:19)
      at <anonymous>

...
fabric.installSmartContract() failed, Error: Fabric: instantiate chaincodes failed
at chaincodes.reduce.then.catch (/opt/gopath/src/github.com/hyperledger/caliper/src/fabric/instantiate-chaincode.js:70:31)
at
not ok 5 TypeError: Cannot read property 'getUpdates' of undefined
operator: error
expected: |-
  undefined
actual: |-
  [TypeError: Cannot read property 'getUpdates' of undefined]
at: process.onetime (/opt/gopath/src/github.com/hyperledger/caliper/node_modules/tape-promise/node_modules/onetime/index.js:22:12)
stack: |-
  TypeError: Cannot read property 'getUpdates' of undefined
      at update (/opt/gopath/src/github.com/hyperledger/caliper/src/gui/src/demo.js:145:26)
      at Object.demoStopWatch [as stopWatch] (/opt/gopath/src/github.com/hyperledger/caliper/src/gui/src/demo.js:185:5)
      at startPromise.then.then.then.then.then.then.catch (/opt/gopath/src/github.com/hyperledger/caliper/src/comm/bench-flow.js:347:18)
      at <anonymous>

...
1..5
tests 5
pass  3
fail  2
`

Are you trying to run one of the samples or your own benchmark? Which Fabric SDK version are you using? Run npm ls fabric-client in the Caliper directory, what is the output?


Fix HttpSessionListener.sessionDestroyed is not being called #2031

Solves: #2031
Also, in order to make it possible to detect degradation caused by Jetty's version upgrade, I added several tests.

Coverage increased (+0.002%) to 84.502% when pulling d8a198fcbf42424edf3cb0e0785e0e70114c8e3b on t-tsutsumi:pr/implement-HandlerContainer into 10dad0fae7a9a1aa8c1369146b8d1f4ccf9998ad on dropwizard:master.

Coverage increased (+0.002%) to 84.502% when pulling d8a198fcbf42424edf3cb0e0785e0e70114c8e3b on t-tsutsumi:pr/implement-HandlerContainer into 10dad0fae7a9a1aa8c1369146b8d1f4ccf9998ad on dropwizard:master.

is it possible to merge this to 1.1.x? as its actually a 1.1.x regression due to jetty upgrade.
We would like to be able to use this feature again without the need to wait for 1.2

I cherry-picked these commits in https://github.com/dropwizard/dropwizard/commit/bfc370b5fb16a8d7b93ea9cd2520c2921a13d95e and https://github.com/dropwizard/dropwizard/commit/5f85ffab2f09e6ff43f88f8763ecbef147e2754e into the release/1.1.x branch


Is it possible to include one agent to multiple pools?

For example I want to have three pools like that: dev01, dev02, dev03 with next machines in them {d1-app, d-sql}, {d2-app, d-sql},{d3-app, d-sql}. So d-sql would be in three pools. Is it possible?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4409a9cb-8448-edd6-da0a-243e5601aa3e
Version Independent ID: ec15f71a-a76d-c3f9-1d31-832f92183ef4
Content: Agents pools - Azure Pipelines
Content Source: docs/pipelines/agents/pools-queues.md
Product: devops
Technology: devops-cicd
GitHub Login: @steved0x
Microsoft Alias: sdanie

@VerdonTrigance -- thank you for your question.  You may find answers here:

Azure DevOps Support Bot
Azure DevOps on Stack Overflow

@steved0x -- please look into this potential documentation issue.

@VerdonTrigance An agent can only be registered with one pool at a time. I will update the docs to make this clear. Thank you.

@VerdonTrigance But you could have 3 agents using the d-sql image and register each one to a different pool though.


New tuto for DNS config on Digital ocean

We need a Tuto for DNS config in digitalocean. Thank you.

Evilginx handles DNS config. You need to point nameservers in your domain provider to Evilginx server.
There is nothing to touch on DigitalOcean. Please read the blog post again to understand how Evilginx acts as a DNS by itself.

Thank you for your response, it's just the "You need to point nameservers in your domain provider to Evilginx server." that I don't understand ...