[Potential Bug]: sanity check mulState handling of modulos

Triton python code
No response
Triton IR
No response
Crash log
No response
Additional information
In the PtrState::mulState function, we directly assign the only modulos present in the two operands to the result. I am trying to understand if that is the correct behavior.
E.g,. consider the following examples:
%0 = tl.arange(0, 4)
%1 = arith.remsi %0, %cst3
%2 = arith.muli %1, %cst4

Each of these values should contain:
%0: [0, 1, 2, 3]
%1: [0, 1, 2, 0]
%2: [0, 4, 8, 0]

Should we also multiply the modulo OFRs accordingly?

Thanks for noticing this. I agree this doesn't look right. I haven't put much thought into understanding what multiplying a modulo expression would mean (it might not make sense). What do you think about just asserting that we are not dealing with modulo in a mul?

Thank you for confirming! I believe we can just multiply the modulos field with the corresponding scalar in mulState to address this pattern.
FWIW, I am working on a version of the PtrAnalysis with the goal to separate the Pointer and mask analysis from Memref and Linalg lowering, hence these questions. Will post more details soon. cc @manbearian


Adding Tetrahedron under Graphs and Shapes

I would like to add tetrahedron in the calculator of shapes part.
It will be including :

volume calculation,
height calculation,
circumradius calculation and
height calculations

@sairish2001 I would like to work on the above mentioned issue.
Please assign it to me.

Go ahead!
Deadline 30 March,2021 (11:59 PM IST)


Great!

Great page! Short and to the point.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a1261884-8284-53f9-a325-15061bf897f8
Version Independent ID: 4520c20f-86f6-5066-298b-d3d428901f87
Content: Use the Task List - Visual Studio
Content Source: docs/ide/using-the-task-list.md
Product: visual-studio-dev15
GitHub Login: @gewarren
Microsoft Alias: gewarren

Thank you for the positive feedback. It's nice to hear!


Remove references to English

Not all sites will use English exclusively. Since we do not know that this information is English, we should not make that claim.
It does not seem this impacts validation, as the Jekyllrb.com sitemap includes no such information.

It does not seem this impacts validation

Looks like that's true. Is there any value in having it at all?
Also @pathawks are you able to resolve the merge conflict?

Also @pathawks are you able to resolve the merge conflict?

Resolved :smile:

Is there any value in having it at all?

Oh sure, if we actually knew what language the content was. Some programs will offer to translate content that is not in the users default language.

Also @pathawks are you able to resolve the merge conflict?

Resolved. :smile:

Is there any value in having it at all?

Oh sure, if we have a way of actually knowing the language of the content.
Some programs may offer to automatically translate content that is not in the users preferred language.

:+1:

How about adding an option for this? While not everything is in English, specifying the language code should offer maximum flexibility.

I can see maybe a site.language and/or a post.language setting, but for now I think it's probably best to keep simple things simple on the road to first stable version.

I hear you, but I'd like to have an issue to track this since I'd like to be as close to the specs as possible.
I'll make a new issue for this.

I'll make a new issue for this.

:+1:


consensus-logic: Use ClientUpdateNotif instead of FCMessage::NewState

Description
This PR removes the cycle between FCM worker and CSM worker by having CSM send NewState message to FCM via ClientUpdateNotif instead of ForkChoiceMessage::NewState.
Type of Change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[x] Refactor
[ ] New or updated tests

Checklist

[ ] I have performed a self-review of my code.
[ ] I have commented my code where necessary.
[ ] I have updated the documentation if needed.
[ ] My changes do not introduce new warnings.
[ ] I have added tests that prove my changes are effective or that my feature works.
[ ] New and existing tests pass with my changes.

Related Issues

closing this in favor of the next PR: https://github.com/alpenlabs/strata/pull/434 which is branched off of release branch.


Example does not work

I have done everything right, and still getting this error
I have modified manifest to allow implicitFlow.
I have also added graph  to application in Azure AD config, and set ALL of the delegated file permissions available for files, I can authenticate, and am getting the token, but no files back. I checked my onedrive and there are files in it, but none being returned by http get call.
Have you guys tried running this example yourselves?
If I go to graph api explorer and use the http get call from this example I do get files, heaps of them which I have in my onedrive
https://graph.microsoft.io/en-us/graph-explorer#/
Cant understand what is happening then with this example. All I get back is from res in the console is
{"_body":"{"@odata.context":"https://graph.microsoft.com/v1.0/$metadata#users('7b3f1e33-35b5-4918-ba9e-d3c15a89ab3e')/drive/root/children\",\"value\":[]}","status":200,"statusText":"Ok","headers":"[\n  [\n    "application/json;odata.metadata=minimal;odata.streaming=true;IEEE754Compatible=false;charset=utf-8"\n  ],\n  [\n    "private"\n  ],\n  [\n    "ef27af17-5a93-41af-875b-e5f5c9af5246"\n  ],\n  [\n    "ef27af17-5a93-41af-875b-e5f5c9af5246"\n  ]\n]","type":2,"url":"https://graph.microsoft.com/v1.0/me/drive/root/children"}
So nothing...., not sure why>?

Hi @nigel-dewar . Thanks for reporting this issue. I get a list of files returned with the Files.Read permission only.

My user consents to the Files.Read (and User.Read from AAD) permissions during log in, and I see "scp": "Files.Read User.Read" when I decode the token in jwt.io. Is this also the case for you?

Yes it is definitely selected

Thanks @nigel-dewar . Sorry, but I meant "Can you please paste your access token into a decoder (like http://jwt.io/)?". Then you can inspect the token--it MAY CONTAIN PRIVATE DATA so don't paste it here. There should be a "scp" section that shows all the permissions that are included in the token. That "scp" should include "Files.Read User.Read".

Hi @nigel-dewar . If this still reproduces for you, please reopen this issue.


Asset loading failing in SSL for big files

I have this failing app, which demonstrates what appears to be a sprockets bug.
Without SSL, it works properly.
With SSL, it keep loading for several seconds and then the request stops with a failure.
It would seem the provided Content-Length isn't appropriate. The provided integer is too big, making the browser wait for more data until it timeouts.
Is there the possibility to render big files with streaming ? I guess it'd fix the problem.

I fixed a content length issue recently, 6fd49f93008fb0210902fdcc23c46126af78759a which is probably what you seeing.
Since your still using sprockets 2.0.3, you should upgrade.

Hum no, I'm sorry but it doesn't work either with sprockets (and rails) edge.
I have updated the Gemfile to use edge on both projects in my failing application.

@josh this issue shouldn't be closed. The bug occurs even in edge.

If you properly have ssl installed on your machine, it works like the following :

script/rails requires require File.expand_path('../../lib/core_ext/rails/server', __FILE__).
lib/core_ext/rails/server.rb configures Rack::Server to use SSL.
config/application.rb adds Rack::SSL.

You can try it without SSL by removing the config.use_ssl and removing the require in scripts/rails.


Disable --create on push by default

Push by default sets the flag --create to automatically create the repository if it doesn't exist. This behaviour, however, requires elevated permissions not usually present in CI. In most cases this won't be needed as the modules will already be created. Therefore to cover the common case we now change the default input for push_create to false. To maintain the current behaviour explicitly set push_create: true.

Not going to merge this. We should allow writers permission to create repos.


View's footer prop is inconsistent with body and does not allow for transparent or gradient background

Footer syntax should be consistent with body syntax, and allow me to set a transparent or gradient background:
View:
  body:
    Column:
  footer:
    Column:
      styles:
        backgroundColor: 0x00FFFFFF
      children:

@vinothvino42 can you work on this please

@vusters It is added to this PR #569


probe-run depends on wasmparser

It seems that we don't turn off enough features of the object crate, so it's pulling in a WASM parser. Since we'll never use that, we should remove the dependency.

The problem is, that probe-rs actually pulls in this dependency with all default features (see).
I've opened https://github.com/probe-rs/probe-rs/issues/559 and asked them to hide the more specific features behind a feature flag.

Fixed by #235


Cache redis or memcached

Hello first, I would like to thank everyone for the great work they are doing. Congratulations
I have a query when using cache memcached or redis does not work
it does not make any cache and that is configured correctly
I would like help

@samirios182805 Is there an error on the screen or in the log file? If so, share the error message as it helps us better understand the scenario.
Also inform the version of CI, PHP and the Operating System used.

use windows 10, laragon redis php 7.2 Codeigniter 4.0.2
does not show any errors only does not cache in redis only in file
App/Config/Cache.php
public $handler = 'file'; working
public $handler = 'redis'; not working no create cache

@samirios182805 Can you do a test using predis' when using redis` and give feedback?

sorry it works for me apparently it had redis installed but the windows extension does not check files for files and it did not show me any errors, maybe you can put a warning if your version of php does not have the redis extension

The whole idea behind the backup handlers is to avoid showing errors directly.
You can always check your logs. Any error will be mentioned there.


[API] Load issue attributes when editing an issue

Fixes #6721
Previously assignees on the issue were nil since they weren't loaded, which messed up any ranging that happened when comparing.

Nice catch... We really need more tests for the api handlers

@jolheiser thanks for PR :) I'll be merging this once build is complete, could you create a backport PR once I merge this one?

@techknowlogick Sure thing! 😄

Codecov Report

Merging #6723 into master will increase coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #6723      +/-   ##
==========================================
+ Coverage   40.72%   40.73%   +0.01%
==========================================
  Files         421      421
  Lines       57867    57872       +5
==========================================
+ Hits        23567    23575       +8
+ Misses      31171    31167       -4
- Partials     3129     3130       +1

Impacted Files
Coverage Δ

routers/api/v1/repo/issue.go
23.22% <0%> (-0.25%)
:arrow_down:

routers/repo/view.go
42.6% <0%> (+1%)
:arrow_up:

models/repo_list.go
67.89% <0%> (+1.05%)
:arrow_up:

models/unit.go
51.42% <0%> (+5.71%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbf8538...c0485d4. Read the comment docs.

Please create backport to 1.8 branch


Upgrade strategy does not work if ruby-build is already installed

The nof_if clause on execute "Install ruby-build" most likely is not needed.

Guess it did work.


Refactor/landing page

Description
Styled header on the landing page
Fixes # (issue)
When the header component was added to the landing page the style didn't match the figma design
Type of change
Styling
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Change Status

[ ] Complete, tested, ready to review and merge
[ ] Complete, but not tested (may need new tests)
[ ] Incomplete/work-in-progress, PR is for discussion/feedback

How Has This Been Tested?

[ ] Test A
[ ] Test B

Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] There are no merge conflicts

Looks great.


Improve GRADLE build Performance

Compiler daemon. The Gradle Java plugin allows you to run the compiler as a separate process by setting options.fork = true. This feature can lead to much less garbage collection and make Gradle’s infrastructure faster. This project has more than 1000 source files. We can consider enabling this feature.
=====================
If there are any inappropriate modifications in this PR, please give me a reply and I will change them.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you very much for the patch. This option is already set for the build and we do not need to duplicate it.


Configure Protractor to use Chrome in headless mode

This gets the npm run e2e to work on the remote setup we are using.

I'm dropping this PR because these changes were included in #5.


Investigate performance of 'compare' command for O(100K) utterances

~100K utterances seems to be taking ~30 seconds for dotnet nlu compare -e tests100k.json -a tests100k.json -m. We should analyze the perf and see if there are any obvious ways to speedup the comparison.

The main bottleneck for compare tests is the exceptions that are thrown for Assert.Pass and Assert.Fail. As far as I can tell, these methods are the only way to specify a pass/fail reason for an NUnit test. A low-hanging way to improve performance is to make the tests run in parallel, which will come in a PR shortly. We can eventually also look into setting our "reason" as an additional metadata attribute on the test results (e.g., a category or something) and use something like expected results to pass/fail the NLU tests.


Change submit task for real xvsa

Change submit task for real xvsa.
Add task_id to task config so that it shows up first.
Add mock .scan_log and scan_result to processTask for later use.

OK


PiN/PiS WIP  - to discuss

I have recalculated PiN/PiS for haplotypes containing 995F, 995S and wt.
These values look very different from those in the phase 1 manuscript but I can't find any code for this analysis @alimanfoo, do you remember if you calculated these? Here F haplotypes have PiN/PiS 20 times that of wt, whereas S is half of wt.
I have calculated these Pi values over all haplotypes in each group at a time, therefore I don't have CIs. If we think these are necessary, I can calculate each sample separately to build the distribution.

Use mpd = mean_pairwise_difference(ac, fill=0) for non-syn and syn var to give a ratio for each "type". These can be compared to each other without calculating the PiN or PiS denominator as this would cancel out in each case.

@alimanfoo - I've swapped out calculating Pi for mean_pairwise_distance, as suggested, then use mean_mpd to build each fraction.
The values haven't really changed drastically so I was hoping you could have a look before I alter the ms text.


Remaining formatting issues in tables

2 other issues I have noticed that make my inner OCD unhappy:

inconsistency in the format of the table headers in the spec: most of the time it is in bold but not always
numeric examples in the tables concerning the content of json files are not "highlighted" and might not be as obvious to the reader.

For example
Number of EEG channels included in the recording (for example, 128).

Should probably be:
Number of EEG channels included in the recording (for example, `128`).

inconsistencies in the rendering of string and numeric values for tables (mostly for stings)

Sometimes examples are written:
like this

and other times
`like that`

Column name
Requirement level
Description

name
REQUIRED
Channel name (for example, FC1, Cz)

units
REQUIRED
Physical unit of the value represented in this channel, for example, V for Volt, or fT/cm for femto Tesla per centimeter (see Units).

Originally posted by @Remi-Gau in https://github.com/bids-standard/bids-specification/issues/739#issuecomment-782854311

just noticed a similar "formatting" related PR: https://github.com/bids-standard/bids-specification/pull/786
I think if we don't put CIs into place to catch these soft, style related things, it'll be hard to maintain.

just noticed a similar "formatting" related PR: #786
I think if we don't put CIs into place to catch these soft, style related things, it'll be hard to maintain.

Agreed. Though regarding the CI part we have to keep in mind that possibly a lot of this will be "encoded" in the metadata part of the awesome schema that @tsalo is working on.
So the style check will probably have to be done on some intermediate files after the macros are applied, no? I think you did some similar magic recently, am I right?

Agreed. Though regarding the CI part we have to keep in mind that possibly a lot of this will be "encoded" in the metadata part of the awesome schema that @tsalo is working on.

Indeed, and I think between Taylor and me we managed to purge a few more styling "bugs".

So the style check will probably have to be done on some intermediate files after the macros are applied, no?

Yes, since #774 these kinds of styling "bugs" would have to be fixed in the schema files ... OR on the spec after the schema is applied. --> But I think running a CI on the YAML file "descriptions" would be nicer:
https://github.com/bids-standard/bids-specification/blob/87ca2c1ee40eede9f41d92c30847cf2ef758b3b3/src/schema/metadata/Acknowledgements.yaml#L3-L5
We just need someone to spend a couple of "minutes to hours"™ to write a script and a GitHub Action to run it :sunglasses:


'az monitor app-insights component' is only using deprecated IKey.

Preconditions

[X] No need to upgrade Python SDK or the Python SDK is ready.

Related command

az monitor app-insights component connect-webapp
az monitor app-insights component connect-function

Resource Provider
microsoft.insights/components
Description of Feature or Work Requested
The current ‘az monitor app-insights component’ is only using IKey. However, since this will be deprecated soon, it is necessary to change to use a connection string.
For example, the following changes are necessary.
https://github.com/Azure/azure-cli-extensions/compare/main...tomo-msft:azure-cli-extensions:main
Minimum API Version Required
N/A
Swagger PR link / SDK link
N/A
Request Example
N/A
Target Date
2025-03-31
PM Contact
<EMAIL_ADDRESS>Engineer Contact
N/A
Additional context
No response

Thank you for opening this issue, we will look into it.


Add on-prem S3 to the use case as the default for s3 storage for any edge demo

Instead of requiring paid S3 access for anyone who wants to run this demo, we should integrate an on-prem S3 service, like minio, to provide a self-contained demo environment that does not rely on external services.  This would also help reduce any potential credential leaks when mutiple people attempt to deploy this use case in their environment.
As a parallel task, any AWS s3 buckets that are required for prepping an environment for the use should only be read-only access  and treated a source repository for seeding the initial artifacts for a demo

This might make #57 unnecessary.

This might make #57 unnecessary.

I think we can host read-only, anonymous buckets for artifacts to be consumed as the initial seed for any use case. I think this would consist of binary objects that are not easily versioned by git.  This issue is an attempt to ensure that a running use case does not require external S3 for these small use cases

Is this for the model storage, or for the ACM Observability?


Further improvements to types and Rust usage in capture & decoder modules

This PR builds on the work in #33. The common theme is to make better use of the Rust type system in order to streamline the code in the capture & decoder modules and, more generally, to write better Rust.
The main changes include:

Add further types to the usb module to encapsulate more conversion and formatting details. These include EndpointAddr, EndpointType, StringId, BCDVersion, UTF16Bytes and UTF16ByteVec.

Add a VecMap<K, V> type to use in place of Vec. This has two key properties:

Indices can be of a specific newtype, converted to usize internally. This removes a lot of x as usize conversions in the code.
Items can be inserted at a specific index, with the underlying Vec<Option<V>> being enlarged as necessary. This removes several places where we were doing this by hand.

Prevent the decoder from peeking ahead at what the ID of a stream item will be. Instead, return an ID only when an item is pushed out to the stream. This enforces the property that no item can be referred to by ID from another stream, before it has been output itself. Several parts of the decoder were not keeping to this rule and have been refactored accordingly.

Rename methods in line with Rust API guidelines, in particular eliminating a lot of get_ prefixes.

Add preludes to the usb and capture modules to avoid lengthy import lists.

Rebased to fix conflicts.


client 'ingoing_rate_limit' support

This would be very helpful for user-facing installations!

@Hades32, The 'ingoing_rate_limit' config should be global or per clientId based? I don't know if a global config is enough?

Typically (or at least for us) there are some kind of special clients (e.g. An app server or some downstream service) which should not be limited. So a global setting would not be helpful.
So limiting should either be per client (configurable per user, e.g. only for anonymous clients) or alternatively on a per listener base. We have different listeners for users and services.
Actually thinking about it, I think configuring it per listener would be the best.

move to 0.11.0

esockd  3.0 supports Rate Limiting based on Token Bucket algorithm.
etc/emqttd.config:
    %% Listeners
    {listeners, [
        {mqtt, 1883, [
            %% Size of acceptor pool
            {acceptors, 16},

            %% Maximum number of concurrent clients
            {max_clients, 512},

            %% Socket Access Control
            {access, [{allow, all}]},

            %% Connection Options
            {connopts, [
                %% Rate Limit. Format is 'burst, rate', Unit is KB/Sec
                %% {rate_limit, "100,10"} %% 100K burst, 10K rate
            ]},

            %% Socket Options
            {sockopts, [
                %Set buffer if hight thoughtput
                %{recbuf, 4096},
                %{sndbuf, 4096},
                %{buffer, 4096},
                %{nodelay, true},
                {backlog, 512}
            ]}
        ]},


OrderActionsBy doesn't work correctly

Cannot get OrderActionsBy working correctly. I need to order actions based on HTTP methods used so that GET methods come first (then POST, PUT, DELETE etc.). I have a few API controllers with some actions (using different HTTP methods). So I tried something very simple as shown below.
This is not working (order doesn't change at all):
config.OrderActionsBy(apiDesc =>
{
    return apiDesc.HttpMethod == "GET" ? "1" : "2";
});

This is working (but obviously it doesn't order actions as I want):
config.OrderActionsBy(apiDesc =>
{
    return apiDesc.HttpMethod;
});

Am I doing something wrong or misunderstood something or is this a bug in Swashbuckle?

Swagger, the community-driven spec that powers Swashbuckle, does not list operations in a flat list. It dictates that operations MUST be grouped by path. So, the ordering is only applied within those groups.
Perhaps, TagActionsBy is what you need as the UI supports arbitrary grouping of operations based on a tag. The default is controller name but you could change to HTTP method.

I understand your point, but what I want is to order actions within a group based on HTTP methods (GETs first and so on). I don't want to group actions by HTTP methods. Now actions seem to be ordered by paths? Actually, I also tried TagActionsBy and it worked as you mentioned, but that's not what I want.
So, is it possible to order actions within a group based on HTTP methods?
Anyway, I really like Swashbuckle and have used it earlier with WebAPI 2 and now trying to adopt this Core version.

Hmmm - so in that case OrderActionsBy really should be working as you expect. There's tests around that so I'm reluctant to concede it's a big. Let me try reproduce and I'll get back to you

Any update on this?
I've used the following code:
c.OrderActionsBy(description => description.HttpMethod);

Expected:
DELETE /competitors/{id}
GET /competitors/{id}
GET /competitors
GET /competitors/search/{keyword}
POST /competitors
PUT /competitors

Actual:
DELETE /competitors/{id}
GET /competitors/{id}
GET /competitors
POST /competitors
PUT /competitors
GET /competitors/search/{keyword}`

@aboo - as per my comments above, the Swagger document structure dictates that operations are always grouped by path and therefore sorting can only be applied within the scope of each path. Therefore, the actual behavior you've described is correct. That is, operations for the "/competitors/{id}" path are displayed first, and sorted by HTTP method and are then followed by operations for the "/competitors" path, also sorted by HTTP method.

I do not think its working
Trying to set in the following order within the same Controller
GET - POST - PUT - DELETE
            // Define order of the Actions on the page
            Func<ApiDescription, string> sortKeySelector = (x =>
            {
                return
                    x.HttpMethod.Equals("GET", StringComparison.InvariantCultureIgnoreCase)
                    ? "0"
                        : x.HttpMethod.Equals("POST", StringComparison.InvariantCultureIgnoreCase)
                        ? "1"
                            : x.HttpMethod.Equals("PUT", StringComparison.InvariantCultureIgnoreCase)
                            ? "2"
                                : x.HttpMethod.Equals("DELETE", StringComparison.InvariantCultureIgnoreCase)
                                ? "3"
                                : "4";
            });
            options.OrderActionsBy(sortKeySelector);

If there is some requirement that paths be sorted within a group and the OrderActionsBy sorting override can't change that, I wish that fact was more discoverable in the intellisense for the method in Visual Studio. It would have saved me many hours trying to figure out why sorting was broken.
Frankly, a sorting override like this should truly override the sorting. Setting a sort override only to have it changed by internal sorting is confusing and unexpected.

Unfortunately, the sorting override doesn't work within the grouping items, which is really confusing and unexpected.
The way it works is withing the logical grouping (GroupName), it orders items by sub-groups (1st controller items order, then 2nd then 3rd, etc.)
The code below proves that.
`
var actionsSortingOrder = new Dictionary<string, int>
{
{ "GET", 0 },
{ "POST", 1 },
{ "PUT", 2 },
{ "DELETE", 3 },
};
var actionsDefaultOrder = _actionsSortingOrder.Max(m => m.Value) + 1;
var actionOrderCollector = new Dictionary<string, int>();
 options.OrderActionsBy((oa =>
            {
                var method = oa.HttpMethod.ToUpperInvariant();
                string res;

                if (actionsSortingOrder.ContainsKey(method))
                {
                    if (!actionOrderCollector.ContainsKey(method))
                    {
                        actionOrderCollector[method] = 0;
                    }

                    res = $"{actionsSortingOrder[method]}.{actionOrderCollector[method]++}";
                }
                else
                {
                    res = actionsDefaultOrder.ToString();
                }

                return res;
            }));

`

Yeah... I've just spent half a day on this myself! Seeing if I could override sorting via OrderActionsBy...
Would be really nice in a future release to enable a true sorting override using this method!
No ifs... No buts!
Surely this wouldn't constitute a major code change!?

Well... If you want something done...?
I knocked up this Vanilla JavaScript hack which sorts Swagger end-points by HTTP method (GET, POST, PUT etc) and then by alphabetical order.
This works via the InjectJavascript extension for Swashbuckle.AspNetCore.SwaggerUI version 6.2.3 and I've tested it using a Core WebAPI project running under .NET6 (although it should also work for .NET5):
swagger-custom.js:
`
"use strict";
(function () {
const SwaggerEndPointClass = ".opblock";
const SwaggerEndPointsToggleClass = ".opblock-tag-section";
const SwaggerEndPoints = "operation-tag-content";
const SwaggerEndPointsClass = `.${SwaggerEndPoints}`;
const SwaggerEndPointsContainer = `${SwaggerEndPointsClass} > span`;

const SwaggerHttpMethods = Object.freeze([
    "head",
    "options",
    "get",
    "post",
    "put",
    "patch",
    "delete"
]);

let swaggerEndPointsSorted = false;
let swaggerEndPointsToggleClickHandlersAssigned = false;

function GetSwaggerEndPointIDHttpMethodIndex(swaggerEndPointID) {
    for (let i = 0; i < SwaggerHttpMethods.length; i++)
        if (swaggerEndPointID.includes(`-${SwaggerHttpMethods[i]}_`))
            return i;
}

function SortSwaggerEndPointIDs(swaggerEndPointIDX, swaggerEndPointIDY) {

    let swaggerEndPointIDHttpMethodIndeX = GetSwaggerEndPointIDHttpMethodIndex(swaggerEndPointIDX);
    let swaggerEndPointIDHttpMethodIndeY = GetSwaggerEndPointIDHttpMethodIndex(swaggerEndPointIDY);

    if (swaggerEndPointIDHttpMethodIndeX < swaggerEndPointIDHttpMethodIndeY)
        return -1;

    if (swaggerEndPointIDHttpMethodIndeX > swaggerEndPointIDHttpMethodIndeY)
        return 1;

    return 0;
}

function GetSwaggerEndPointIDsByHttpMethods(swaggerEndPointsContainers) {
    let swaggerEndPointIDs = [];

    swaggerEndPointsContainers.forEach(x => swaggerEndPointIDs.push(x.querySelector(SwaggerEndPointClass).id));
    swaggerEndPointIDs.sort();
    swaggerEndPointIDs.sort(SortSwaggerEndPointIDs);

    return swaggerEndPointIDs;
}

function SwaggerEndPointsSort() {
    let swaggerEndPointsContainers = document.querySelectorAll(SwaggerEndPointsContainer);

    if (swaggerEndPointsContainers.length < 1)
        return;

    let swaggerEndPointsContainerNew = document.createElement("div");
    let swaggerEndPointsContainerOld = document.querySelector(SwaggerEndPointsClass);
    let swaggerEndPointIDsByHttpMethods = GetSwaggerEndPointIDsByHttpMethods(swaggerEndPointsContainers);

    swaggerEndPointIDsByHttpMethods.forEach(x => swaggerEndPointsContainerNew.appendChild(document.getElementById(x)));

    swaggerEndPointsContainerNew
        .classList
        .add(SwaggerEndPoints);

    swaggerEndPointsContainerOld
        .parentNode
        .replaceChild(swaggerEndPointsContainerNew, swaggerEndPointsContainerOld);

    swaggerEndPointsSorted = true;
}

window.addEventListener("DOMNodeInserted", () => {
    if (!swaggerEndPointsSorted)
        SwaggerEndPointsSort();

    let swaggerEndPointsToggles = document.querySelectorAll(SwaggerEndPointsToggleClass);

    if (!swaggerEndPointsToggleClickHandlersAssigned)
        if (swaggerEndPointsToggles.length > 0) {
            swaggerEndPointsToggles.forEach(x => x.addEventListener("click", _ => swaggerEndPointsSorted = false));
            swaggerEndPointsToggleClickHandlersAssigned = true;
        }
});

})();
`
As I said it's a hack but should hopefully sort your needs until they decide to make the OrderActionsBy TRULY override the end-point order... Irrespective of arbitrary grouping!
Hope this helps!


Format of the key file for visualize

Hello.
Thanks for this awesome work.
I am trying to embed a bunch of protein families using ESM2 and visualize using UMAP to see if the the families are in distinct clusters.
I found in the documentation
--key
Input a CSV, with your group mappings for your embeddings where the first column is the label and the second column is the group to be colored.

Can you please give a small example of the format of the file?
For example, let say I just have one sequence of a polymerase and one sequence of a kinase, and I want to show the two as different colors, what would the csv file look like?
I would be really grateful for your help.
Best,
Amin.

Sorry for the delay! Below is an example of a key file. Note that while Class can be any arbitrary string, the Label column must match the header in the input fasta file.

Label,Class
P63086,Cell membrane
O75439,Mitochondrion
Q2TBK2,Mitochondrion
O35094,Membrane
Q4QQW3,Mitochondrion
Q32PI5,Cytoplasm
Q60415,Membrane

Also, you can use the utils command to help create your key for you! Below is an example of passing an absolute path to a directory where your fasta files are, separated into classes. For instance, if you had 4 fasta files in the directory, it would output a key where there are 4 classes.
trill key_example 0 utils prepare_class_key --dir /path/to/fasta/files/sep/by/class
You can also pass a text file with --fasta_paths_txt where each line has an absolute path to a fasta file. Each fasta file (and all of the associated sequences) will be considered its own class.
trill key_example 0 utils prepare_class_key --fasta_paths_txt /path/to/file/paths.txt
Here is an example of how the paths.txt could look if you only had two classes-

/path/to/file/seqs1.fasta
/path/to/other/file/seqs2.fasta

Thanks @martinez-zacharya
This is exactly what I was looking for.
Best,
Amin.


Feature idea: permalinks

Some playgrounds with code snippets support this, e.g.
https://www.typescriptlang.org/play?#code/C4TwDgpgBAqgzhATlAvFA3gKCjqA7AQwFsIAuKOYRASzwHNtcC6z8BXIgIyUZ2oBNylGvUwBfTEA
I'm not sure what encoding it is, but the original was
type User = {
    name: string
    age: number
    id: string
}
```.

We could start by base64-encoding the input, or find a more optimal encoding for code such as the one used by typescript playground.

The "identifier" of the snippet would automatically update the URI in the browser for easy copy-pasting.

ok, I got it - lzstring.compressToEncodedURIComponent from https://pieroxy.net/blog/pages/lz-string/index.html . There are typings so we could use ScalablyTyped for the bindings, but given it's just ~2 methods we could write the JS stubs manually too.

That's a must have, I thought about it a while back but forgot to record an issue for it, thanks for that

I'll give it a go.


Use new version collector

The version.NewCollector function was moved from common to client_golang.

Bump client_golang.
Use new version.NewCollector function.

I didn't see #13717

Looks like we had similar ideas hahahaha https://github.com/prometheus/prometheus/pull/13717


Single node replica set KeyFile error

I'm trying to setup a single node replicaset for development using docker compose, see docs .
  mongo:
    image: mongo
    volumes:
      - ./data/mongo:/data/db
    environment:
      MONGO_INITDB_ROOT_USERNAME: ${MONGO_USERNAME}
      MONGO_INITDB_ROOT_PASSWORD: ${MONGO_PASSWORD}
      MONGO_REPLICA_SET_NAME: rs0
    restart: unless-stopped
    entrypoint: >
      /bin/sh -c '
      echo "rs.initiate()" > /docker-entrypoint-initdb.d/init-replicaset.js;
      /usr/local/bin/docker-entrypoint.sh mongod --replSet rs0 --bind_ip localhost
      '

When running I get the following:
mongo_1          | BadValue: security.keyFile is required when authorization is enabled with replica sets
mongo_1          | try 'mongod --help' for more information

But really I don't need a keyfile for a single node setup. Is there some way to disable this?

The solution with --noauth actually helps, but you also need to remove MONGO_INITDB_ROOT_USERNAME and MONGO_INITDB_ROOT_PASSWORD from your config as well as update all clients to not send username/password. This option actually disables password authentication for the whole DB. Interestingly at least in my case I still needed db.auth() in the js init file.


Move velox_aggregation_fuzzer_test and spark_aggregation_fuzzer_test to the fuzzer directory

Summary:
This diff moves velox_aggregation_fuzzer_test to velox/functions/prestosql/fuzzer and moves spark_aggregation_fuzzer_test to velox/functions/sparksql/fuzzer.
This is part of https://github.com/facebookincubator/velox/issues/7754.
Differential Revision: D52106081

Hi @kgpai, I'm moving the target of velox_aggregation_fuzzer_test and spark_aggregation_fuzzer_test in this PR. I updated dist_compile.yml and scheduled.yml to use the new paths. But the CI job failed with the following error (https://github.com/facebookincubator/velox/actions/runs/7202009747/job/19620662750?pr=8007)
Run actions/download-artifact@v3
Starting download for aggregation
Error: Unable to find an artifact with the name: aggregation

Do you know what I'm missing here?

Scheduled aggregation fuzzer jobs failed because they incorrectly check out the main branch instead of my branch. Join fuzzer and linux-build failed due to irrelevant errors.


Added a dynamic search bar

Description
I have added a dynamic search bar to search for any databases in the web app of Datasets repo.
Checklist:

[X] I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
[X] I have cross-checked that the dataset I'm uploading is not present in the project
[X] I have cross-checked that the dataset is present in the correct folder

Screenshots 👇

Hey @durgeshm01722, there are some merge conflicts, please resolve them first.

Okay

@nikhil25803 , I have resolved the merge conflicts. Sorry for that. I didn't realised.

No prob @durgeshm01722 , Great work  :)

Thanks 🙌

Hey @durgeshm01722 , fix this one please.

I guess it has been fixed @durgeshm01722 :)
Leave it for now

It's okay on my side 😯

Looks good this side too :)


[SPARK-14426][SQL] Merge PerserUtils and ParseUtils

What changes were proposed in this pull request?
We have ParserUtils and ParseUtils which are both utility collections for use during the parsing process.
Those names and what they are used for is very similar so I think we can merge them.
Also, the original unescapeSQLString method may have a fault. When "\u0061" style character literals are passed to the method, it's not unescaped successfully.
This patch fix the bug.
How was this patch tested?
Added a new test case.

Test build #55090 has started for PR 12199 at commit e54bcc6.

Test build #55090 has finished for PR 12199 at commit e54bcc6.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55090/
Test FAILed.

LGTM

Test build #55095 has started for PR 12199 at commit 0619067.

Yay! LGTM.

Test build #55095 has finished for PR 12199 at commit 0619067.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55095/
Test FAILed.

Test build #2758 has started for PR 12199 at commit 0619067.

Test build #55106 has started for PR 12199 at commit e28ddd2.

Test build #2758 has finished for PR 12199 at commit 0619067.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #55106 has finished for PR 12199 at commit e28ddd2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55106/
Test PASSed.

Merging into master thanks.


Your requirements could not be resolved to an installable set of packages.

i had this issue while installing canvas in laravel 8 with laravel ui
Problem 1
- cnvs/canvas[v5.2.0, ..., v5.2.5] require illuminate/support ^5.6|^5.7|^5.8|^6.0 -> found illuminate/support[v5.6.0, ..., 5.8.x-dev, v6.0.0, ..., 6
.x-dev] but these were not loaded, likely because it conflicts with another require.
- cnvs/canvas[v5.3.0, ..., v5.4.0] require php ^7.2 -> your php version (8.0.0) does not satisfy that requirement.
- Root composer.json requires cnvs/canvas ^5.2 -> satisfiable by cnvs/canvas[v5.2.0, ..., v5.4.0].

What version of Canvas are you installing?

please ,i just ran composer require austintoddj/canvas from the documentation

The latest version of Canvas is 6.x
Can you try updating the version you're installing and let me know if you still have issues with it?

okay, sir, maybe I didn't  explain the problem well, I haven't used this package before, my PHP version is  php8, laravel8, and laravel valet when i ran  composer require austintoddj/canvas i had that error, i tried to do update my compooser.js PHP version to suit the package requirements as such   "require": {         "php": "^7.3|^8.0",         "ext-json": "*",         "ext-mbstring": "*",         "ext-openssl": "*",         "doctrine/inflector": "^1.4|^2.0",         "dragonmantank/cron-expression": "^3.0.2",         "egulias/email-validator": "^2.1.10",         "league/commonmark": "^1.3",............................

Aha, got it.
The package doesn't yet support PHP8, but it will in the next release.
Hoping to have it out in just a couple days or less.

@fozoholiver1 Fixed in v6.0.14
Let me know if you run into any issues!


Parentage GO:0052593 tryptamine:oxygen oxidoreductase (deaminating) activity

Hi,
why do you consider tryptamine has an aliphatic amine and not an aromatic amine. One should maybe change to GO:0008131 | primary amine oxidase activity.
Best. Lionel

The confusion may have come from RHEA:
https://www.rhea-db.org/rhea/59419
which has

More general form(s) of this reaction
RHEA:16156
an aliphatic amine + H2O + O2 <=> an aldehyde + H2O2 + NH4+

A question for @kaxelsen ?

In GO we have  xx reactions with the same EC:
'aliphatic amine oxidase activity' http://purl.obolibrary.org/obo/GO_0052595
'aminoacetone:oxygen oxidoreductase(deaminating) activity' http://purl.obolibrary.org/obo/GO_0052594
'phenethylamine:oxygen oxidoreductase (deaminating) activity' http://purl.obolibrary.org/obo/GO_0052596
'primary amine oxidase activity' http://purl.obolibrary.org/obo/GO_0008131
'tryptamine:oxygen oxidoreductase (deaminating) activity' http://purl.obolibrary.org/obo/GO_0052593

The confusion may have come from RHEA: https://www.rhea-db.org/rhea/59419 which has

More general form(s) of this reaction
RHEA:16156
an aliphatic amine + H2O + O2 <=> an aldehyde + H2O2 + NH4+

A question for @kaxelsen ?

RHEA:16153 used the wrong amine compound. The reaction has just been updated to use "a primary methyl amine" CHEBI:228804, which is equivalent to "a primary amine" and more general than "an aliphatic amine". The updated reaction will become public in 2024_03 scheduled for May 10.


chore(atomic): fix snyk vulnerabilities

https://coveord.atlassian.net/browse/KIT-1209
A few things:

adding the .snyk file to ignore vulnerabilities is not supported for Coveo projects, @olamothe you'll have to ignore it since you have access to bypass rules. Here's the issue's link
I updated tailwind and some packages (by running npm audit fix) to fix the other snyk issue we have
added the licenses folder to our package.json's files so it's included along with the current LICENSE
Since SF's license indicates that we have to give credit. I added a license property in the component that uses them. This will show up when the component's is required (like through the CDN). I think that should be enough to show our appreciation 😄

Thanks to @louis-bompart for pointing these issues out!

@olamothe you'll have to ignore it since you have access to bypass rules.

That's done !


how to use ?

I have problems executing

You have to give the argument --service like it sais below.

You have to give the argument --service like it sais below.

How to use this now? before I used this to authenticate: node funi --auth. But now its not work, I'm opening the command in the "lib" folder is it correct?

Using this command " node funi --auth" show this message: Missing required argument: service
How do i work?

Do node index.js —service 'funi' —auth

Do node index.js —service 'funi' —auth

Thanks, its work


Update README.md

Motivation/Description of the PR

Improvements on how to inject I object.

Type of change

[ ] :fire: Breaking changes
[ ] :rocket: New functionality
[ ] :bug: Bug fix
[ ] :clipboard: Documentation changes/updates
[ ] :hotsprings: Hot fix
[x] :hammer: Markdown files fix - not related to source code
[ ] :nail_care: Polish code

Checklist:

[ ] Tests have been added
[ ] Documentation has been added (Run npm run docs)
[ ] Lint checking (Run npm run lint)
[ ] Local tests are passed (Run npm test)

In our tests we still use injection via arguments.

Sorry, I don't think this is necessary.
Even I can be injected per file I still prefer to inject it per test for better visibilty


added pretrained embedding (+ minor aesthetic refactor)

fix for #80

I wonder if the token_embeddings should also get pretrained embeddings


Remove android-minSdkVersion entry

CordovaLib requires minSdkVersion 16 so the template won't build, better remove it as in the future it will require another version

Will need to propagate this to the other templates...

@devgeeks yeah, I sent a few, but wasn't sure which ones you are still maintaining
BTW, this one is not merged https://github.com/phonegap/phonegap-template-hello-world/pull/27


Make a /docs a Git subtree

While the splitting of docs => hugoDocs was a good idea, and we should continue with that, the submodule approach has some major flaws:

It's not possible to create an "atomic PR" with both code and documentation changes.
Old PRs that does the above is no longer easily mergeable.
This change made the release process more complex than needed.

Maybe Git subtrees?
https://developer.atlassian.com/blog/2015/05/the-power-of-git-subtree/
Help/suggestions welcome. I think we got to fix this sooner than later.
/cc @digitalcraftsman @spf13 @moorereason @anthonyfok

This article describes it pretty well:
https://medium.com/@v/git-subtrees-a-tutorial-6ff568381844
A sub-tree should be less painful. I will do that.

Notes:
git remote add docs git@github.com:gohugoio/hugoDocs.git
git subtree add --prefix=docs/ docs master --squash

Pulling changes should be:
git subtree pull --prefix=docs/ docs master --squash

@digitalcraftsman we should mostly do changes in hugoDocs, but I guess we can synch both ways if needed (use case: PRs with docs changes). We should live with this for a while to test it out and update contrib. guide.

@bep re the use of the master branch: please have a look at https://github.com/gohugoio/hugoDocs/pull/19#issuecomment-311145110.


fix-ci: use pg 9.4

Codecov Report

Merging #2 into master will increase coverage by 8.81%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
+ Coverage   82.78%   91.59%   +8.81%
==========================================
  Files          13       13
  Lines         488      488
  Branches       70       70
==========================================
+ Hits          404      447      +43
+ Misses         75       32      -43
  Partials        9        9

Impacted Files
Coverage Δ

django_north/management/migrations.py
100% <0%> (+4.2%)
:arrow_up:

django_north/management/commands/migrate.py
96.66% <0%> (+6.66%)
:arrow_up:

django_north/management/commands/flush.py
88.6% <0%> (+43.03%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14a9296...97fa9e2. Read the comment docs.


namespace no longer reserved?

Reserved keywords not used by Razor: namespace

From what I read here: https://docs.microsoft.com/en-us/aspnet/core/mvc/razor-pages/?view=aspnetcore-2.1&tabs=visual-studio#using-layouts-partials-templates-and-tag-helpers-with-razor-pages i see that @namespace is being used.
Moreover VS 15.6.7 with ASP.NET core stuff when creating .NET Core project "ASP.NET Core Web Application" the file _ViewImports.cshtml also uses @namespace directive.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b87067b2-347c-072d-26c8-5a8c7c9c860b
Version Independent ID: a0b3b70a-3b39-1b5f-a4ce-c41bd2d6b044
Content: Razor syntax reference for ASP.NET Core
Content Source: aspnetcore/mvc/views/razor.md
Service: asp.net-core
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

@janis-veinbergs  Your observations are correct. Thanks for the feedback!

@NTaylorMullen  see Reserved keywords not used by Razor
Reserved keywords not used by Razor

namespace
class

Should namespace be moved to Razor keywords

Should namespace be moved to Razor keywords

Yes


Added hibernation and resume support to rosa cli

@vkareh PTAL

/hold
@pvasant @vkareh holding not because of technical reasons but because SREP aren't ready for this feature.

/hold
@pvasant @vkareh holding not because of technical reasons but because SREP aren't ready for this feature.

Just as a reminder we are gating this feature based on the feature flag set for org

/hold cancel

@vkareh  PTAL

/lgtm


Add tuple of all colors to ColorSensor

This adds a tuple mapping the color ints to human readable strings.
Could be used like this:
from ev3dev.ev3 import ColorSensor

c = ColorSensor('1')
print(c.COLORS[c.color])

This makes sense, but unfortunately the change is in the autogenerated region of the code (its between the autogen tags, also see https://github.com/ev3dev/ev3dev-lang/tree/develop/autogen), so it will be overwritten on next regeneration.
I guess one way to deal with this would be to monkey-patch the ColorSensor class outside of any auto-generated region (ColorSensor.COLORS=['nocolor',...]), although that may be considered unintuitive by readers of the code.
We could also try to use the information available in the spec.json and generate the color dictionary automatically.

Superceded by #320


hunspell: tolerate REP rule count mismatches

Similar to support for tolerating PFX/SFX count mismatches, add the ability to tolerate REP count mismatches.
The issue arises in recent updates to LibreOffice mongolian dictionary and is currently failing all PRs that change the analyzers:
https://bugs.documentfoundation.org/show_bug.cgi?id=164366

I added a CHANGES. Also the underlying issue is now fixed in the LibreOffice. I will try to chase it down in the bataak repo after brushing up on some mongolian :)


Update README.MD to fix invalid characters issue

A few invalid symbols in 'agnoster.zsh-theme' :
https://github.com/robbyrussell/oh-my-zsh/issues/1906#issuecomment-275799694
this issue got introduced in 2013 and people are still confused and don't know right way to fix it.
It would be awesome if we can put this in README.md
Thanks & Regards,
Pradeep

Nice one. 😀
I've only been using ITerm2 for a few hours but I thought the change fonts button was located at: iTerm2 -> Preferences -> Profiles -> Text -> Change Font -> Family[12pt Meslo LG S DZ Regular for Powerline] as opposed ro iTerm2 -> Preferences -> Change Font -> 12pt Meslo LG S DZ Regular for Powerline

@djsd123 Thanks updated correct path

I am STILL having an issue after following these steps, where the carrot is misaligned with the rest of the block containing the path, and they are slightly different colors (OSX)

Have you run into this?

This is better suited in the wiki (FAQ section maybe).


starlark: API additions for improved debugging

This change adds a number of small features to improve debugging.
The actual debugger API will come in a later change.

Thread.Name : an optional string field that describes the purpose of
the thread, for use in debugging.
(*Program).Filename: a method that reports the file of the program.
Also, a String method that returns the same thing.
Also, a test that it reports the correct location even for
an empty file (a special case of the previous implementation).
(*Frame).Local(i int): a method to return the value of a local
variable of an active frame, such as one might use in debugger's
stack trace.
ExprFunc: creates a starlark.Function from a given expression,
such as one might use in a debugger REPL.

@cococlyde55

@cococlyde


Possible memory leak

Hey,
Even after your latest commit, I see the GPU memory going up as training progresses, and getting slower:
On a 4090 GPU (24gb VRAM), for example:
Iter 5000: 15% GPU memory usage, ETA: 36:28
Iter 14000: 65% GPU memory usage, ETA: 1:20:10
Is this normal? Maybe another detach() missing somewhere?
Thanks!

Hi, this is actually quite normal.
The memory overhead of VRAM mainly consists of several parts:

the input image (which is loaded onto the GPU by default unless --load2gpu_on_the_fly is used),
the query MLP,
the rasterization of the Gaussian,
the model parameters of the 3D Gaussian (such as XYZ, rotation, scaling, opacity, etc.).

In my experiments, the VRAM overhead of the query MLP is not significant. The increase in VRAM usage is because before 15k, the 3D Gaussian in the canonical space is continuously densifying.


Change INDEX_SEARCHER threadpool to resizable to support task resource tracking

Description
Change the INDEX_SEARCHER threadpool type to QueueResizableOpenSearchThreadPoolExecutor to support task resource tracking for concurrent segment search.
Added new ConcurrentSearchTasksIT test to validate that multiple threads are reporting resource stats for the same task with concurrent search enabled. Note that this is separate from #7440.
Related Issues
#7425
Check List

[x] New functionality includes testing.

[x] All tests pass

[ ] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #7502 (1480aba) into main (6ac3317) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@             Coverage Diff              @@
##               main    #7502      +/-   ##
============================================
- Coverage     70.55%   70.49%   -0.07%
+ Complexity    59666    59650      -16
============================================
  Files          4887     4887
  Lines        286559   286559
  Branches      41307    41307
============================================
- Hits         202193   202012     -181
- Misses        67727    67917     +190
+ Partials      16639    16630       -9

Impacted Files
Coverage Δ

...ain/java/org/opensearch/threadpool/ThreadPool.java
82.60% <0.00%> (+1.44%)
:arrow_up:

... and 476 files with indirect coverage changes

Tagging @reta @andrross @sohami @kotwanikunal @ketanv3 for review and some feedback on #7425

Taking a look at testStartingTrackingHandlesMultipleThreadsPerTask test flakiness

Ah I see. If numThreads is large then the same thread may pick up multiple Runnables for the same task id. The other problem is task.getResourceStats() has a max size of the number of threads in the threadpool.

Have we figure out (and fixed) the flakiness part? thank you

@reta Yep the flakiness and your last round of comments are both addressed now.


Difference in standardization between CT scans

Despite normalization to [0, 1], not all CT scans are normalized along the same distribution. This leads to inconsistent pixel intensity distributions on DCNN and DCGAN predictions. Examples are shown below:

Possible fix by thresholding lighter images at -1000

Fixed by np.clip being invoked with lower bound -1000 and upper bound 3000.


Remove unnecessary html_theme_path option

Summary
The qiskit_sphinx_theme package is deprecating qiskit_sphinx_theme.get_html_theme_path() in https://github.com/Qiskit/qiskit_sphinx_theme/pull/211 as prework for soon having "variants" that allow setting the theme to either Core (Terra) or Ecosystem.
Turns out, setting html_theme_path isn't necessary in the first place. The Qiskit Finance docs render the same before and after this change.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 75.793%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
645

Relevant Lines:
851

💛  - Coveralls

I think the changes I see (from #243 output)

to now (from output here) are then because this current run was done on the new rc1 qiskit-sphinx-theme whereas the above was the last stable version

This theme path has been there a long while forever - it was in Aqua - before the app repos were done. Its now in all the app repos the same.

+1 on the rc explaining that.
When I ran tox -e docs locally, I couldn't find any difference between the two. The only possible risk would be if html_theme_path = ['.'] had an impact on things, as html_theme_path = ['qiskit_sphinx_theme.get_html_theme_path()] is redudant.
But we don't declare a theme in ., only some templates and static assets. Which Sphinx has dedicated options for. html_theme_path is irrelevant.

Just an FYI for docs changes in the apps. If this relates to stable too, such as simple spelling/text fixes etc and changes like this to configuration or CI that apply equally to stable we normally backport these to stable. I guess with theme changes going on when we choose to publish can make a visual difference - at present there is no need to publish finance, but it would look slightly different because of the theme if we did, but I don't personally think its a problem. More just noting things since the apps publish docs more frequently, that just at releases, as is done with qiskit terra. Ie doc bug fixes and code bug fix releases are independent in that regard.


Stories with same name overwrite each others screenshot

Bug description
Using the same name for 2 or more stories leads to having the same filename.
This function needs to be refactored:
https://github.com/lost-pixel/lost-pixel/blob/main/src/crawler/storybook.ts#L244-L245
How to reproduce
Run Lost Pixel in storybook mode with at least 2 stories with the same name.
Expected behavior
No response
Lost Pixel information

lost-pixel logs from CI
No response

Hello, curious what is the use case here? I am looking into the codebase and found this issue but not sure what would be a way to trigger this..

Run Lost Pixel in storybook mode with at least 2 stories with the same name.

If the file name is different the filename generated by lost pixel will also be different right?


Background video playback

Hello again,
I noticed the following behaviour: if I used this media stream source to play video file in background on a phone and then lock the screen, wait 10-20 seconds then unlock the screen, video playback stops.
The media stream source continue to request samples but the MediaPlayerElement doesn't render them.
Does anyone have any idea about this?
Technically, starting with AU, Background video playback should be possible but I noticed no other app on windows mobile does so.

Hi, I had issues too with background video playback on my first experiments with MediaStreamSource api years ago on desktop. I can't remember if I already talked about it here but was not able to find a fix.
Initially found on 8.1, I remember I was able to reproduce the issue on Windows 10 when minimizing the playing app, maybe only in tablet mode. I would love to see it fixed too !


replaced FocusTrap to TapRegion

I replaced FocusTrap to TapRegion because FocusTrap is not supporten now in Flutter 3.7.0 (https://github.com/flutter/flutter/pull/107262)

..

Hey @AurelVU, I'm sorry for closing your PR without merging it but I was already working on it.
The update is live on pub
Version 2.2.22


python310Packages.djangorestframework-camel-case: 1.3.0 -> 1.4.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.djangorestframework-camel-case is: Camel case JSON support for Django REST framework
meta.homepage for python310Packages.djangorestframework-camel-case is: https://github.com/vbabiy/djangorestframework-camel-case
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.4.0 with grep in /nix/store/gl70wckagw9lc7g6cj9glnnqbxz86aq9-python3.10-djangorestframework-camel-case-1.4.0
found 1.4.0 in filename of file in /nix/store/gl70wckagw9lc7g6cj9glnnqbxz86aq9-python3.10-djangorestframework-camel-case-1.4.0

Rebuild report (if merged into master) (click to expand)

6 total rebuild path(s)

6 package rebuild(s)

First fifty rebuilds by attrpath
baserow
peering-manager
python310Packages.djangorestframework-camel-case
python310Packages.drf-spectacular
python311Packages.djangorestframework-camel-case
python311Packages.drf-spectacular

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/gl70wckagw9lc7g6cj9glnnqbxz86aq9-python3.10-djangorestframework-camel-case-1.4.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.djangorestframework-camel-case https://github.com/r-ryantm/nixpkgs/archive/5e96d9c02fe8d5f7c361eeb8baafe29e609f04ac.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/gl70wckagw9lc7g6cj9glnnqbxz86aq9-python3.10-djangorestframework-camel-case-1.4.0
ls -la /nix/store/gl70wckagw9lc7g6cj9glnnqbxz86aq9-python3.10-djangorestframework-camel-case-1.4.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:

python311Packages.drf-spectacular

5 packages built:

baserow
peering-manager
python310Packages.djangorestframework-camel-case
python310Packages.drf-spectacular
python311Packages.djangorestframework-camel-case

Maintainer pings
cc @SuperSandro2000 for testing.

Result of nixpkgs-review pr 215793 run on aarch64-darwin 1

1 package failed to build:

python311Packages.drf-spectacular

5 packages built:

baserow
peering-manager
python310Packages.djangorestframework-camel-case
python310Packages.drf-spectacular
python311Packages.djangorestframework-camel-case


Bengali translation

See #173 for details

It is not actual no longer, the translations will be needed for v2.0.0.


More Ubuntu Support

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area cmd

/area pkg

/area docs

/area tests

What this PR does / why we need it:
Trying to simplify and expand Driverkit's Ubuntu support:

Rather than having ubuntu-generic and ubuntu-aws, simplify to just ubuntu
Expand support to more than just generic and aws, as described in: #144

Which issue(s) this PR fixes:

Fixes #144
Special notes for your reviewer:
This work is also built in part on top of the work @amalone-scwx did in some internal testing - wanted to make sure I give credit where credit is due :)
Does this PR introduce a user-facing change?:
Yes, simplifying Ubuntu target types to just --target ubuntu, though backwards compatibility with ubuntu-aws and ubuntu-generic should still work (but I would argue need to be deprecated in the future).
The one "gotcha" to look out for with this change is that now the Ubuntu "Flavor" (ex: aws, generic, kvm, oracle, etc) is now dynamically parsed from the kernelrelease field. If the kernelrelease passed in is formatted incorrectly or omits that flavor, then generic is the assumed flavor.
For example, if a config looks like:
kernelversion: 199
kernelrelease: 4.15.0-188
target: ubuntu

The updated code will assume that generic is the "flavor" here since the target is no longer a reliable way to get that information.

Simplifying and expanding Ubuntu support into just `--target ubuntu` and adding support for all flavors! `ubuntu-generic` and `ubuntu-aws` target types are still supported for backwards compatibility, but should be deprecated.
Massive overhaul to the go-side of the Ubuntu builder which now parses the Ubuntu "Flavor" from the kernelrelease and uses it to build URL paths to search for kernel headers, meaning all Ubuntu flavors should now be supported rather than just AWS and generic.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: EXONER4TED
To complete the pull request process, please assign leodido after the PR has been reviewed.
You can assign the PR to them by writing /assign @leodido in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

0251047 combining aws and generic into just ubuntu, getting it to work

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Hi! This is great!
My only concern is dropping backward compatibility for existing configs with ubuntu-aws.
I think we should actually support ubuntu-aws from cmdline/config and internally store it as 'ubuntu`.
Aside from that, i think this needs a lot of testing before being merged :)
But it's a great step forward IMHO; thank you very much!

That makes sense to me! I can make sure to add in that backwards compatibility. I'm unable to continue work on this PR for a few days, but I'll get that going as soon as I get back to it.

Ah i see, sorry we use the "wip" in the PR title to notify that the PR is a wip :)
So, forgive me if i didn't notice the draft ahah

All good :) I was using the built-in draft mode of Github, which prevents the PR from being merged:

But let me edit the title to make it more clear!

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: EXONER4TED
To complete the pull request process, please assign fntlnz after the PR has been reviewed.
You can assign the PR to them by writing /assign @fntlnz in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

288af2f put back go:embed

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I actually think I'm very nearly done - I was able to build ubuntu-oracle, ubuntu-aws, and ubuntu-kvm, for example, on my machine just fine. However, I can't for the life in me figure out why it won't pass the integration tests haha...
On my M1 Mac, I'm able to compile the ubuntu-aws ARM test just fine:
╰─❯ _output/bin/driverkit docker --output-module _output/test.ko --target ubuntu --kernelrelease 4.15.0-1129-aws --kernelversion 138 --kernelurls "https://download.falco.org/fixtures/driverkit/aarch64_devel/linux-headers-4.15.0-1129-aws_4.15.0-1129.138_arm64.deb" --kernelurls "https://download.falco.org/fixtures/driverkit/aarch64_devel/linux-aws-headers-4.15.0-1129_4.15.0-1129.138_all.deb" --architecture arm64
INFO driver building, it will take a few seconds   processor=docker
INFO kernel module available                       path=_output/test.ko

I was hoping to have this wrapped up today, but until I can figure out the CI errors... might take a few more days.
Current CI errors:
DEBU   CC [M]  /tmp/driver/main.o
DEBU �In file included from <command-line>:
DEBU ././include/linux/kconfig.h:5:10: fatal error: generated/autoconf.h: No such file or directory
DEBU  #include <generated/autoconf.h>
DEBU           ^~~~~~~~~~~~~~~~~~~~~~
DEBU compilation terminated.
DEBU Fmake[2]: *** [scripts/Makefile.build:335: /tmp/driver/main.o] Error 1
DEBU :make[1]: *** [Makefile:1590: _module_/tmp/driver] Error 2
DEBU Xmake[1]: Leaving directory '/tmp/kernel-download/usr/src/linux-aws-headers-4.15.0-1129'
DEBU $make: *** [Makefile:7: all] Error 2
DEBU log pipe close                                error=EOF
DEBU context canceled
FATA exiting                                       error="Error: No such container:path: 4b5da0bf0adc7dd422a48425a407cf6e5ba0aec8193d30a00cf785c9193daa17:/tmp/driver/module.ko"
make: *** [Makefile:91: test/aarch64/configs/ubuntu_aws.yaml] Error 1

Here's initial output from my branch building on local. I used kernel-crawler as my input and looped over anything under Ubuntu. It has several new flavors!
However, in the Driverkit output, there were 2270 ubuntu targets to build, and I was only able to build ~1100 of them. Most of them seemed to fail for the same reason the CI fails. So I am still investigating that issue, but I think it's the only one left...
builds.txt

I think I figured it out - I had changed:
		KernelHeadersPattern: "linux-headers*",

To be linux*headers* at an earlier point in my debugging when I was troubleshooting something. It seems that is now shooting me in the foot because the template script is grabbing the wrong directory for the include/generated/autoconf.h with the wildcard.
I put it back, seeing if that fixes my issue.

Also, i know it is getting annoying (sorry!) , but can you have a look at https://github.com/falcosecurity/test-infra/pull/766 ?

Also, @EXONER4TED , i forgot to ask: did you try multiple kernel-crawler crawled ubuntu configs? (fixing of course the target).
I fear we might break something :/

I can use more crawler configs if we'd like! I just did a:
python3 __init__.py crawl --distro Ubuntu --out_fmt driverkit

^ and that's been my input test on my local machine. I can fire the test off locally again on one of those lists you posted though.

I just did a:
python3 __init__.py crawl --distro Ubuntu --out_fmt driverkit

This is exactly what i needed :)
But you did have to change various ubuntu-$flavour with just ubuntu right?

Yea! I think it's a small/simple change to kernel-crawler 😄

I will give it another look in ~1hr, but i think this LGTM now!

Sounds good to me! The more 👀 the better. It's been very cool to get lots of feedback!
I can also open a PR for deprecating ubuntu-aws and ubuntu-generic which can just sit and be merged at leisure when ready.

My approval is weak :/ @dwindsor

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: EXONER4TED, FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 4172e41f7cd057586e49cb1683b78e740ee192c3

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dwindsor, EXONER4TED, FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,dwindsor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Fixes for s390x

In the first commit, we need to use Swift calling convention when dealing with BoxPair on s390x.  BoxPair is expected to be returned in 2 registers but there is no native C type that is returned in two registers by the default ABI on s390x.
The second commit fixes the way enum payloads are packed for big endian order.
Both of these commits resolve test cases failures on s390x therefore no new test cases are added.

Thanks @vivkong!
@rjmccall @aschwaighofer As a followup, does SWIFT_CC(swift) let us get rid of the BoxPair::Return hack altogether on all our supported platforms?

@aschwaighofer I have to question for a fix I need in clang for s390x.  I saw the original commit was done by you.  In lib/CodeGen/TargetInfo.cpp, isSwiftErrorInRegister() in SystemZABIInfo needs to return false.  Should I open a bug?

@vivkong According to llvm's calling convention description swiferror is passed in R9:
https://github.com/apple/swift-llvm/blob/stable/lib/Target/SystemZ/SystemZCallingConv.td#L37
https://github.com/apple/swift-llvm/blob/stable/lib/Target/SystemZ/SystemZCallingConv.td#L75
Are there bugs in the SystemZ backend that precludes this from working?  If yes, it makes sense to disable usage of swifterror on SystemZ by returning false from isSwiftErrorInRegister until the backend is fixed.

@aschwaighofer, It's not working correctly at the moment.  How should I request this change in Clang?  Or would it be better to temporary set IsSwiftErrorInRegister to false in https://github.com/apple/swift/blob/master/lib/IRGen/IRGenModule.cpp?utf8=✓#L408 ?

@vivkong I pushed a fix to llvm.org and it is on stable and swift-4.1-branch.

@vivkong Can you file a bug at https://bugs.llvm.org that swifterror support is broken on SystemZ if there is not one already?

@aschwaighofer Thanks!  And will do.


Hotfix #33 - DefaultO*mFactory fix (ZF2 compatibility)

DefaultOdmFactory and DefaultOrmFactory could be used with context of AbstractPluginManager

with ZF2 and zf-apigility-doctrine these factories are used with
ZF\Apigility\Doctrine\Server\Query\Provider\Service\QueryProviderManager

@TomHAnderson would you be able to confirm that this PR resolves your issue? Thanks!

Coverage increased (+0.09%) to 86.287% when pulling f023e1dba3b0014e8b5011a610416960cabfef48 on webimpress:hotfix/33 into a90f05480527c4f519489c5823e47167a5e22017 on zfcampus:master.

Thanks for the quick turn-around.  I'll put this into use today and report back.

This patch works as advertised.  Thanks!


Feat: Add a button in the file manager to create a new file

When using the file manager, it is often useful to have the option to add a new empty file into the directory.
The daemon's router needs to be changed to accept "../file/touch"
The touch function takes its inspiration from the Unix-like "touch" command which allows you to create an empty file within a directory

Thanks for your contribution.
I noticed that you added some APIs, which need to be updated to the Daemon and Web project, and we will do a code review when your other PRs are ready.

Perfect, now I update both the daemon and the web with the new API.


Update azure-synapse-link-synapse.md

We don't need MSI credential and access to customer's storage account to create Dataverse snapshot/partitioned tables.

#sign-off

@ilijazagorac  - Thanks for your contribution. The removal of the content has already occurred in another PR in our internal repo. Closing without merging.


Remove unused features in syn

A lot of features in syn are enabled by default even though we don't use them. We should check which features we actually use and opt out all the others.

https://docs.rs/syn/1.0.36/syn/#optional-features


[Dubbo-1962] Resolving inconsistent parameter validation rules

What is the purpose of the change
Resolving inconsistent parameter validation rules. #1962
Brief changelog
ReferenceConfig.java#setProtocol(String protocol)
RegistryConfig.java#setGroup(String group)
RegistryConfig.java#setVersion(String version)
Verifying this change
Unit test passed.
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #1970 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1970      +/-   ##
============================================
- Coverage     50.04%   50.03%   -0.01%
  Complexity     4706     4706
============================================
  Files           562      562
  Lines         25213    25216       +3
  Branches       4449     4449
============================================
  Hits          12618    12618
  Misses        10690    10690
- Partials       1905     1908       +3

Impacted Files
Coverage Δ
Complexity Δ

...n/java/org/apache/dubbo/config/RegistryConfig.java
86.2% <100%> (+0.32%)
43 <2> (ø)
:arrow_down:

.../java/org/apache/dubbo/config/ReferenceConfig.java
48.58% <100%> (+0.89%)
39 <1> (+1)
:arrow_up:

...e/dubbo/remoting/transport/netty/NettyChannel.java
57.5% <0%> (-8.75%)
19% <0%> (-2%)

...onfig/spring/extension/SpringExtensionFactory.java
76.92% <0%> (-7.7%)
8% <0%> (ø)

...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java
83.33% <0%> (-5.56%)
6% <0%> (ø)

...he/dubbo/remoting/transport/netty/NettyServer.java
67.85% <0%> (-3.58%)
8% <0%> (-1%)

.../dubbo/remoting/transport/netty4/NettyChannel.java
60% <0%> (-1.25%)
21% <0%> (ø)

...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java
55.69% <0%> (+3.79%)
13% <0%> (+2%)
:arrow_up:

...apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java
48.38% <0%> (+19.35%)
3% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d21d994...b32a44e. Read the comment docs.

Seems reasonable, no need to modify, close this PR


Bug in example

Hi,
I just found a bug in one example:
https://github.com/facebook/draft-js/blob/master/examples/media/media.html
If you click the button "add image" and don't type anything, this.state.editorState will be set to null because the lines:
_addMedia(type) {
const src = window.prompt('Enter a URL');
if (!src) {
return;
}
      const entityKey = Entity.create(type, 'IMMUTABLE', {src});

      return AtomicBlockUtils.insertAtomicBlock(
        this.state.editorState,
        entityKey,
        ' '
      );
    }

will return null if src is not set (specifically if(!src) line). Then afterwards you can't upload any images since the whole thing is broken, because this.state.editorState is set to null already.
I 'd change
to:
if (!src) {
return this.state.editorState;
}
I can submit a PR if this is not my illusion

We shouldn't be using window.prompt in that example, since it causes problems with selection state.
It should be an input instead, like in the link example. Or just buttons.


Version 0.2.0

Maybe releasing a 0.2.0 as https://github.com/mattpat/node-schedule/pull/82 expanded the Job interface?
Thanks!

we're now at 0.2.1 on NPM and github

Thanks!


generate diff coverage statistics for diff changes

please do add more test cases for that, say the "rename", "deletion" operations for the files.


#1824: try-runtime ci checks: Migrations

Goal
The goal of this PR is to enable try-runtime migraiton checks (pre-and-post) in CI
Details

[x] Added a make target try-runtime-check-migrations-paseo-testnet to run checks locally against paseo
[x] Added a github action that runs the checks.
[x] Set trigger with label for the job, Adding the label change/storage-migration will trigger future CI runs for that PR to run a new job that will run the migration against testnet if: ${{ github.event.label.name == 'change/storage-migration' }}

Closes #1824
Discussion

Checklist

[ ] Chain spec updated
[ ] Custom RPC OR Runtime API added/changed? Updated js/api-augment.
[ ] Design doc(s) updated
[ ] Tests added
[ ] Benchmarks added
[ ] Weights updated

here is a successful run for migration checks
https://github.com/frequency-chain/frequency/actions/runs/9506037171/job/26202319163


Allow service and node filter to be name in tasks subcommands

Allow service and node filter to be name on docker node tasks and docker service tasks commands 🐅.
This changes is mainly server-side (between engine api and swarmkit). There is just a check in api/client/service/tasks.go to handle the special self meaning.
This is an attempt to partly fix #24163 and #24165 (it just misses partial names, but this would require changes in swarmkit I think 🐳).
This is an alternative to a client-side only change (see https://github.com/docker/docker/compare/master...vdemeester:tasks-filter-service-node-by-name).
/cc @aaronlehmann @cpuguy83 @stevvooe
🐸
Signed-off-by: Vincent Demeester<EMAIL_ADDRESS>

LGTM

LGTM

don't merge yet! we're having issues with CI not being triggered, so it didn't run on this PR

I think whole CI was run.


Use Hive.init without path

Question
Would it be possible to have a default directory for hive files?
It would make sense for me, because I need Hive initialized in a synchronous manner inside a constructor.

Sorry I don't quite understand what you want to do. The directory you provide with Hive.init() is the default directory.

What I mean is to have an init method that you can use as Hive.init(), with no arguments.
If I remember correctly, you need to use init as Hive.init('my/directory').

That's what I am suggesting. Have a directory (wherever you decide) that plays the "default directory" role. It can be appPath/hive.

But each operating system has different directories. There is no way for me to know where you have write permission.

Well, you have write permission inside your app directory, don't you?

You are right. I need to await Hive.openBox().
I was trying to initialize Hive inside a constructor for a service, but it seems it is not possible.
I'll close this, as it seems there is nothing you can do.


The Cancer Targetome

As part of another project, I became aware of this resource. I am uncertain if this is useful to us, but I thought I'd mention it to the KG2 team in case it seems interesting/useful:
https://github.com/ablucher/The-Cancer-Targetome
Fine to close this issue if not.

Thanks, @edeutsch


feat: convert link command

feat: convert link command
This PR:

renames internal command dendron.convertLink to dendron.convertCandidateLink, that was used in the backlinks panel to convert candidate links to wikilinks
hides dendron.convertCandidateLink from userland as this is not functional outside of the backlinks panel context.
implements Dendron: Convert Link, which can

convert broken links to plaintext. user is prompted to choose what part of the link text to use.

choices

alias: use link's alias if exists (otherwise option isn't suggested)
note name: use link destination's note name (basename excluding all parent hierarchies)
hierarchy: use link destination's entire hierarchy
prompt: user is prompted to manually input text to use
change destination: user is prompted a lookup to choose a different existing note to link.

convert valid links.

when cursor is above a usertag, user is asked if they want to convert it to a regular wikilink
when cursor is above a regular wikilink with user.* hierarchy, user is asked if they want to convert it to a usertag
when cursor is above a hashtag, user is asked if they want to convert it to a regular wikilink
when cursor is above a regular wikilink with tags.* hierarchy, user is asked if they want to convert it to a hashtag
all other references (frontmatter tags, non user/hashtag wikilinks, note references) will display a toast message that there is no available convert operation

when cursor is not above any recognized reference, the command will display a toast message that there is no link to convert.

Pull Request Checklist
You can go to dendron pull requests to see full details for items in this checklist.
General
Quality Assurance

[x] Add a test for the new feature
[x] Make sure all the existing tests pass
[x] Do a spot check by running your feature with our test workspace
[~] If your tests involve running [[manual Testing|dendron://dendron.dendron-site/dendron.dev.qa.test#manual-testing]], make sure to update [[Test Workspace|dendron://dendron.dendron-site/dendron.dev.ref.test-workspace]] with any necessary notes/additions to perform manual test ^9jtWc6ov340p
[ ] After you submit your pull request, check the output of our integration test and make sure all tests pass

NOTE: If you running MacOS or Linux, pay special attention to the Windows output and vice versa if you are developing on Windows

Special Cases

[~] If your tests changes an existing snapshot, make sure that snapshots are updated
[~] If you are adding a new language feature (graphically visible in VS Code/preview/publishing), make sure that it is included in test-workspace. We use this to manually inspect new changes and for auto regression testing

Docs

[x] Make sure that the PR title follows our commit style
[x] Please summarize the feature or impact in 1-2 lines in the PR description
[ ] If your change reflects documentation changes, also submit a PR to dendron-site and mention the doc PR link in your current PR

Special Cases
Git

[x] Make sure your branch names adhere to our commit style [[#^6zdCscSXs1MM]]

All PRs should start with [feat|fix|enhance|]/[{description-of-pr-in-kebab-case}]

eg. feat/add-thisthing

Analytics

[~] If you are adding analytics related changes, make sure the Telemetry docs are updated

Github Issue

[ ] If this pull request is addressing an existing issue, make sure to link this PR to the issue that it is resolving.
[ ] If the resolution comes with a document update, link the docs PR to the issue as well.

@Harshita-mindfire I've added you to the reviewer as an FYI because this might be a good feature to add to the code action provider

will add docs very soon

docs: https://github.com/dendronhq/dendron-site/pull/324

related: #1885 #963


Update color literals

Carrying on from the changes proposed in #539 I've gone back and had a quick review of the rule.
Added two extra options

allow-variable-identifiers (default true)
allow-map-identifiers (default true)

The first option allows you to disallow the use of color-literals as variable identifiers/names but is disabled by default due to the feedback we received around this rule.
The second option allows you to disallow the use of color literals as map identifiers which to me seemed the logical extension of the option above but suited different use cases to the above.
Added extra tests and necessary documentation
closes #538
closes #539
DCO 1.1 Signed-off-by: Dan Purdy<EMAIL_ADDRESS>

Coverage increased (+0.02%) to 97.017% when pulling 8631d95574c15465d78d305be69f76e3ac58d263 on DanPurdy:feature/fix-color-literals into 6b041473605beb5fffa8bf641f96a22ae481a0e2 on sasstools:develop.

Coverage increased (+0.02%) to 97.017% when pulling a0fac8b60e8b6210a3d9a7ebeec7fa767ad57af0 on DanPurdy:feature/fix-color-literals into 6b041473605beb5fffa8bf641f96a22ae481a0e2 on sasstools:develop.

Due to the extra features contained in this we should probably hold it for 1.7.0
There's a few fixes we could roll out already as 1.6.3

Coverage increased (+0.02%) to 97.017% when pulling b498d801ba9b8855fbfd0da141880e09046deaac on DanPurdy:feature/fix-color-literals into f745ab52ce2bf532b7cbcde4db481e8ee9482de0 on sasstools:develop.

Coverage increased (+0.02%) to 97.017% when pulling 403556879c05537e27e62e3f931cff4c6946a7e1 on DanPurdy:feature/fix-color-literals into bbef921bdb9756fd79a84dbc3f26ef3e8f89645a on sasstools:develop.

Coverage increased (+0.02%) to 97.017% when pulling a5e713faec2d8afe25731ddba5c5e661196f823c on DanPurdy:feature/fix-color-literals into 557b9775ca6aba623aef8bded9ecb865d32a216e on sasstools:develop.

Coverage increased (+0.02%) to 97.017% when pulling 57fa7469e58a29df7e9cfb450036ffa8420c3601 on DanPurdy:feature/fix-color-literals into 90bf83bdf007562ee1e0d8e0debdf0fe724cf071 on sasstools:develop.

Coverage increased (+0.02%) to 97.017% when pulling 6a2f3748b040c27e6e7b47308fb195f1dc1ea2c4 on DanPurdy:feature/fix-color-literals into 0fb7d3da8253c2e8df0e4d7b7db9448d65de356d on sasstools:develop.

Coverage increased (+0.02%) to 97.017% when pulling fe71aac148cac942686784616d5ad2673f6da15f on DanPurdy:feature/fix-color-literals into 0fb7d3da8253c2e8df0e4d7b7db9448d65de356d on sasstools:develop.


Adding a section for OpenSearch SQL CLI on Downloads/Getting Started page to fix #654

Signed-off-by: Vimal K<EMAIL_ADDRESS>Description
Add a section for OpenSearch SQL CLI on Downloads/Getting Started page
The new section looks as follows:

The brief descriptive words for this cli tool was taken from https://pypi.org/project/opensearchsql/ . I did not had that information so I took the liberty to add what I feel fits well for the section. The platform and package information is also added, open to change those if required. This is my very first contribution to OpenSearch project , so please let me know if anything has to be changed . Thank you
Issues Resolved
Closes #654
Check List

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

@opensearch-project/project-website Can we have maintainers to take a look and PR, and trigger the CI?

@wbeckler Thank you for the review. Will patch those changes soon. :)

PR patched!

@wbeckler could you take another look, thx

Upvoting this.
Looking forward to have this published!

@vimalMK - I apologize for letting this sit for so long. No reason we shouldn't have a download artifact for it. I have a few questions.
Will these artifacts need to be updated and recommitted every time theres a new CLI version? I think this might be something we'd want to tie in with your release process so that we can make sure the artifacts are updated.
How often do these get updated?

@vimalMK - I apologize for letting this sit for so long. No reason we shouldn't have a download artifact for it. I have a few questions.
Will these artifacts need to be updated and recommitted every time theres a new CLI version? I think this might be something we'd want to tie in with your release process so that we can make sure the artifacts are updated.
How often do these get updated?

@nateynateynate SQL-CLI release has its own versioning, doesn't have to go with every OpenSearch release, and we don't expect it to be released very often. So far it has only been released once. https://pypi.org/project/opensearchsql/#history

@nateynateynate What would you like to do with this?

When #3112 publishes I'll close this one out. Thanks everyone.

Looks like you're live! #3117


No onBuffer function

There is onBuffer() in react-native-video. But in this package, I can't find it. It's very necessary to show the loader when the HLS video is buffering. However, it's buffering and playing the HLS video.

[x] react-native-af-video-player version: ^0.2.1

[x] React Native version: 0.64.0

[x] OS: Android

[x] Has this issue already been raised? No

[x] Have you clearly read and understood the Readme? Yes

I used this package in a one yo app and its really hard to maintain with this package installed
We should customize players according to our requirements using basic react-native-video.