fix issue resolving pow correctly, updated docs

AMDG

It might be better to check std::numeric_limits::is_integer
instead of std::is_integral, as this allows user-defined types.
I believe this is more consistent with the existing code (see
rational_detail::is_compatible_integer).
I'm not sure what test/expected_fail_12.cpp is
supposed to be testing.
in rational_pow_test, using boost::pow is
unnecessary as it will always be found by ADL.
no_std_pow_collision is useless because
std::pow(float, float) is an exact match.
Please verify that the new tests fail for
the old code.  If they already pass for the
old code, then they're not very useful.

In Christ,
Steven Watanabe

If you look at https://github.com/qtumproject/cpp-eth-qtum/issues/31#issuecomment-404867094 it shows the original template was properly omitted, so the issue is something else and this change may not even be necessary.  I suspect at this point that it is a failure to include  in the proper location (perhaps inside boost::spirit where it is being used?) or the C++ language level changed and caused that invocation of pow to no longer match, since C++11 removed some pow() signatures (in favor of what I would guess is a template that requires the same type for the base and the exponent).

AMDG
Also, I wouldn't classify pow as a utility function.
In Christ,
Steven Watanabe

AMDG
On 07/13/2018 09:52 AM, James E. King III wrote:

If you look at https://github.com/qtumproject/cpp-eth-qtum/issues/31#issuecomment-404867094 it shows the original template was properly omitted, so the issue is something else and this change may not even be necessary.

Does commenting out the definition of pow for rational
fix the problem?

I suspect at this point that it is a failure to include  in the proper location (perhaps inside boost::spirit where it is being used?)

cmath is #included right at the top of the spirit header.

or the C++ language level changed and caused that invocation of pow to no longer match, since C++11 removed some pow() signatures (in favor of what I would guess is a template that requires the same type for the base and the exponent).

pow(double, double) is definitely defined in all versions
of the standard.
In Christ,
Steven Watanabe

AMDG
On 07/13/2018 09:52 AM, James E. King III wrote:

If you look at https://github.com/qtumproject/cpp-eth-qtum/issues/31#issuecomment-404867094 it shows the original template was properly omitted, so the issue is something else and this change may not even be necessary.  I suspect at this point that it is a failure to include  in the proper location (perhaps inside boost::spirit where it is being used?) or the C++ language level changed and caused that invocation of pow to no longer match, since C++11 removed some pow() signatures (in favor of what I would guess is a template that requires the same type for the base and the exponent).

Ugh.  boost::pow is hiding std::pow.  Here's why:

"name lookup ends as soon as a declaration is found for the
name." [basic.lookup.unqual]
For using directives: "During unqualified name lookup (3.4.1),
the names appear as if they were declared in the nearest
enclosing namespace which contains both the using-directive
and the nominated namespace." [namespace.udir] (i.e. using
std::pow effectively puts pow in the global namespace)

Note that this happens before overload resolution and
is not affected by the fact that boost::pow does not
match.
In Christ,
Steven Watanabe

Perhaps we should move pow into rational (and make it a static?), so that one needs to use boost::rational::pow(...) to use it?

Or it could change to be operator ^ and we could also add operator ^=  to the class.

AMDG
On 07/13/2018 12:25 PM, James E. King III wrote:

I'm starting to think it would be better to just remove the change from 1.68 and possibly deal with it later.

+1

This implementation is incomplete - it won't work on rational exponents, for example,

rational exponents should not be supported as the result is
not rational.

and the way it was originally implemented in the PR from 2015 is flawed due to the name collision already experienced by one consumer.  Granted in Boost.Spirit, instead of "using" simply putting in "std::pow" would be more explicit

We still need ADL, so using std::pow is the right way, I think.

however I'm concerned about any other implementations that might end up running into the same problem.

I'm certain that there are.

In this case I believe the issue is limited to implementations within the boost namespace, based on what Steven diagnosed.  boost::pow just seems like a bad idea at the moment given we're going to release 1.68.0 soon and we're in beta.  Thoughts?

Right.  We'd need to check all of boost and there's no
way something at that scale will fly, this late in the
release process.
In Christ,
Steven Watanabe


Re-adding accessory after plugin changes

I believe it is expected to have to re-add the accessory via the Home app after doing some tweaks/changes in the config of the plugin.
I scratched my head for 5 minutes looking at a "not responding" tile before thinking about adding a new accessory, and there it was.
Suggestion is to make it a bit more obvious that that step is needed. Unless of course it is a bug, and it's possible to modify the same accessory without having to add it again.
Thanks for a great plugin!

@Jafalex Thank you for reporting this. Currently, it generates a "unique accessory" based on name, IP, Zone and type. It has to be unique. What I can do is use just the name, so you can change the IP without having to re-add the device. What do you think of that?

Interesting as all it took to generate a new accessory was adding the "volumeAsFan": true parameter. Name, IP and Zone were unchanged. Note that I  am not using Type.
Only relying on name change to recreate the unique accessory sounds like a good idea to me. Cheers

Hum, this also happened to me when updating to latest. My IP address is reserved so I don’t think any of those values changed.

Ah, looks like the hash was recently updated to include zone, which probably did it.

I made some changes in 2.9.5 Can you verify if anything has changed since this update?

Sorry for missing your question here. This issue definitely seems to be fixed. I wonder if it introduced another issue where the volume level always resets to zero, even after changing the volume, when I release my finger from the level goes straight back to zero (but the actual volume remains to where I set it). It’s like the plug-in couldn’t read the volume level and set the fan level accordingly.
Cheers


feat(docs): added OpenSSF Scorecard Batch to increase clo-monitor score

Purpose of PR?:
This PR increases the clo-monitor score of kubeArmor.
Fixes #1353
Does this PR introduce a breaking change?
No
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:

[ ] Bug fix. Fixes #
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[x] PR Title follows the convention of  <type>(<scope>): <subject>
[ ] Commit has unit tests
[ ] Commit has integration tests

I have submitted pull requests to the repositories of KubeArmor, policy-templates, and Kastore. In this regard, I humbly request your esteemed review of these contributions.

@Ankurk99 Should I close this pull request? Another pull request relating to the same issue has already been merged.

Should I close this pull request? Another pull request relating to the same issue has already been merged.

@vishalrajofficial Yes, it has been addressed in the other PR. Thank you.


[Spec Deviation] -0.0 and +0.0 are considered as identical

Description:
As per the spec, -0.0 and +0.0 are equal but not identical. But, below code outputs true.
io:println(-0.0 === +0.0); // true

Duplicates #17977


Removed leftover deallocationCallback

I forgot to remove this field in the last PR
@davidfowl, @pakrym

@dotnet-bot test Innerloop Windows_NT Debug Build and Test


Circular dependencies when using @robotty/umzug-postgres-storage and pg

Versions

sequelize: 6.16.1
umzug: 3.0.0
@robotty/umzug-postgres-storage: 3.0.4
pg: 8.7.1

Environment:

I'm using TypeScript for code and migration files.
DB is PostgreSQL

Code:
import path from "path";
import { Pool } from "pg";
import { Sequelize } from "sequelize";
import { Umzug } from "umzug";

const { PGStorage } = require("@robotty/umzug-postgres-storage");

const connectionString =
  "postgres://postgres:postgres@localhost:5432/xyz";
const sequelize = new Sequelize(connectionString);
const sequelizeConfig = sequelize.config;
const pool = new Pool({
  user: sequelizeConfig.username,
  host: sequelizeConfig.host,
  database: sequelizeConfig.database,
  password: sequelizeConfig.password!,
  port: Number(sequelizeConfig.port),
});

(async () => {
  const poolConnection = await pool.connect();
  const storage = new PGStorage(poolConnection);
  const umzug = new Umzug({
    migrations: {
      glob: path.resolve(__dirname, "..", "migrations") + "/*.ts",
    },
    storage,
    context: sequelize.getQueryInterface(),
    logger: undefined,
  });

  await umzug.down({ to: 0 });
  await umzug.up();
})();

Running this via node_modules/.bin/ts-node bin/test.ts results in:
TypeError: Converting circular structure to JSON
    --> starting at object with constructor 'Sequelize'
    |     property 'dialect' -> object with constructor 'PostgresDialect'
    --- property 'sequelize' closes the circle
    at JSON.stringify (<anonymous>)
    at prepareObject (/node_modules/pg/lib/utils.js:81:15)

Logging the thing in pg/lib/utils.js results in:
{
  name: '01-user.ts',
  path: '.../migrations/01-user.ts',
  context: <ref *1> PostgresQueryInterface {
    sequelize: Sequelize {
      options: [Object],
      config: [Object],
      dialect: [PostgresDialect],
      queryInterface: [Circular *1],
      models: {},
      modelManager: [ModelManager],
      connectionManager: [ConnectionManager]
    },
    queryGenerator: PostgresQueryGenerator {
      sequelize: [Sequelize],
      options: [Object],
      dialect: 'postgres',
      _dialect: [PostgresDialect],
      _quoteIdentifier: [Function: quoteIdentifier],
      quoteIdentifier: [Function (anonymous)],
      typeValidation: undefined
    }
  }
}

The error doesn't happen with<EMAIL_ADDRESS>

Thanks @sdepold - could you share what the migration itself looks like? Or does it happen even with no migrations?

The migration file's content is actually completely irrelevant since the error happens when Umzug tries to store the executed migration in the db:
import { MigrationProps } from "../src/@types/migrations";

export async function up({ context: queryInterface }: MigrationProps) {}
export async function down({ context: queryInterface }: MigrationProps) {}

Looks like this is an issue because Sequelize itself has circular dependencies.
// Our sequelize
const sequelize = new Sequelize( {
  'dialect' : "sqlite",
	'storage' : "database.sqlite"
} );

console.log( "Sequelize=", sequelize );

Will produce a log and show you a bunch of circular stuff.
Since umzug calls
    async runCommand(command, cb) {
        const context = await this.getContext();
        await this.emit('beforeCommand', { command, context });
        try {
            return await cb({ context });
        }
        finally {
            await this.emit('afterCommand', { command, context });
        }
    }

Where context contains sequelize which is a circular object. This calls the emittery function which eventually calls
				eventData = JSON.stringify(eventData);

Which tries to convert the object that has sequelize in it that's a circular object. Hence the error is thrown.

@sdepold finally got a chance to look into this. It's happening because @robotty/umzug-postgres-storage is implementing the v2 storage interface. I would recommend not using it with v3 - especially since it doesn't explicitly specify a peer dependency, and because the GitHub repo is read only. The breaking change was documented in the beta release but not explicitly in the stable release notes, so apologies for that. I've now amended the notes. Having said that, I'd also recommend being a bit careful with libraries that don't specify peer dependencies.
An update to the readme would be very welcome, since this is a bit of a gotcha. But unfortunately beyond that I don't think umzug can control external packages failing to declare supported version ranges for peer dependencies.

@mikealeonetti to reply to the issue you're seeing, could you give a little more detail? The umzug repo itself doesn't call JSON.stringify(eventData) anywhere, as far as I'm aware. Is that in your code? If so - does changing that line solve the problem?

@mikealeonetti to reply to the issue you're seeing, could you give a little more detail? The umzug repo itself doesn't call JSON.stringify(eventData) anywhere, as far as I'm aware. Is that in your code? If so - does changing that line solve the problem?

Indeed! I should have put the stack trace. This is called by the emittery package. I'm not sure what umzug uses emittery for, for emittery is JSON serializing the data.

Interesting, I hadn't come across this before. It looks like it only stringifies when debug is enabled, which would be the case if process.env.DEBUG was equal to * or emittery.  So I think this is an emittery issue, I'll create an issue there and if it doesn't get traction will try to think of a workaround for umzug.


Add istioctl installation steps.

Fixed https://github.com/kubernetes/charts/issues/1494

/cc @lachie83


upgrade bullet-core to 0.5.2

Coverage increased (+0.004%) to 99.518% when pulling 954f04e930f00f1b0d1f75c716ffb79a9363a852 on 0aix:master into 86f5a17ca9a5b1541d04b643c36baab6b352f311 on bullet-db:master.


[AutoDiff] NFC: Rename SILReverseAutoDiff* to SILAutoDiff*.

As title. No need to differentiate (no pun intended) between forward and reverse.

@swift-ci please test tensorflow

@swift-ci please test tensorflow linux

@swift-ci please test tensorflow

@swift-ci please test tensorflow

@swift-ci please test tensorflow

@swift-ci please test tensorflow

@swift-ci please test tensorflow

@shahmishal Mishal, I think something's wrong with update-checkout in CI. Could you take a look?

Maybe a clean test will fix it? I'll try triggering a clean test.

@swift-ci please clean test tensorflow

@swift-ci please test tensorflow


Add Enterprise Management service to project

PR summary
This PR adds the Enterprise Management service to the project, including the generated
service and unit test code, plus a skeleton integration test.
Fixes:
PR Checklist
Please make sure that your PR fulfills the following requirements:

[x] The commit message follows the Angular Commit Message Guidelines.
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] New tests
[ ] Build/CI related changes
[ ] Documentation content changes
[ ] Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@mahakAg I've updated the add-em branch with latest from master, etc.  There are test failures in the integration test for EM.  Could you please take a look and see if you can fix those, then push changes to the add-em branch (to be included in this PR)?

:tada: This PR is included in version 0.6.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Issues with connecting to other project site

I can't connect sui to a project site, like when it ask to connect a wallet it won't connect with sui, it works well for other app like ethos, suiet, martian

Hi,
Thanks for testing out the Sui wallet. Currently, the Sui wallet is still under development. This means that sometimes, some bugs can slip in. However, the bugs are often solved a couple of days later.
Note that the wallet currently communicates to devnet or testnet, which are restarted every couple of weeks. The result is that all assets (which do not hold any value) are wiped.
After a network reset, the following steps could help:

Update the wallet
Change the language of your Chrome browser to English (and delete other languages)
Clear the site data of the website you are having issues with in chrome. (Paste "chrome://settings/content/all?searchSubpage" in your search bar)
Delete and reinstall the wallet

Is your issue still not solved? I'd recommend the Sui Discord. The community is often more responsive on wallet issues there.
Have a wonderful day.


Use of the challenge dataset

Hi, do you use all the training dataset of the challenge for training, and extract part of it for testing? What is the ratio of the training set to the test set, and do you use the validation dataset of the challenge?

嗨，您是否将挑战的所有训练数据集用于训练，并提取其中的一部分进行测试？训练集与测试集的比率是多少，是否使用挑战的验证数据集？

Yes, we only used the entire training dataset from the challenge, with a split ratio of 8:2, and we didn't use the validation dataset. You can download and check out the data we processed for more details.


fix: use only-allow to enforce installation with pnpm

See title; allows for cleaner, less "janky" script.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

The usage of the -y flag seems to be an issue with npm@6. I'm removing it in order to let the tests pass. With npm@7, it will prompt for confirmation before installing, but that shouldn't be an issue because people running npm@7 will be doing so in interactive mode.

Thanks for the contribution! Makes the code much nice.

It looks nice but now it's one more potential security issue though 😅

@Jolg42 Looks like only-allow is authored by pnpm so if we trust pnpm, we can trust that as well.

I know but temporary attacks are also a thing and executing some code without specifying the version means it's open bar 🤷
npx<EMAIL_ADDRESS>pnpm fixes that.

I pinned it ✅


tests/stax: snapshot each test into its own directory

Broken out from #119, since it doesn't touch any app code.

There are a lot of changes to screens as a result of #119 - this change allows us to actually track a bit easier which flows change as a result.
I'm definitely not against de-duplicating things like home in future - but having full separation clears things up initially.
(would probably happen as part of adapting the stax testing framework to reuse the new nano one)

LGTM


Etag middleware generating the same weak etag for different body content.

What version of Hono are you using?
4.6.5
What runtime/platform is your app running on?
Cloudflare workers
What steps can reproduce the bug?
Generate a large response (20kb) with the etag middleware using weak etags, change a character in the response again.
What is the expected behavior?
When changing the response body the etag should be different
What do you see instead?
Different response bodies generate the same etag
Additional information
When output'ing the respons body used for generating the hash it looks like this:
body ReadableStream {
  locked: false
}

This is the section in the middleware that we had a look at:
  const hash = await sha1(res.clone().body || '')
      etag = weak ? `W/"${hash}"` : `"${hash}"`

I'm guessing that hono starts to stream the body at some size of response body which breaks the etag functionality. I'm not sure what the best fix is in this case. Is it possible to disable the streaming or to read the entire stream into a string at this point?

Hi @markusahlstrand
Thank you for your report. This is a known issue and is currently stuck, but there is a pull request.
https://github.com/honojs/hono/pull/2911
https://github.com/honojs/hono/pull/2918
I would like to fix it with one of these, so please wait a little.


Make dev tools using easier, add ida_namer NEW IDA support

Make dev tools copy easier and add .bat for scripts, add new version ida support

@praydog merge

Not merging. This font is hurting my eyes. Scale back the scope of this PR or make the fonts selectable.


BSE has no metadata

Updating to current master and trying to import BSE throws an error
$ python add_et.py
Traceback (most recent call last):
  File "/usr/lib64/python3.12/importlib/metadata/__init__.py", line 397, in from_name
    return next(cls.discover(name=name))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
StopIteration

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/work/basis_set_exchange-historical/positronic/add_et.py", line 3, in <module>
    from basis_set_exchange import lut, manip, curate
  File "/home/work/basis_set_exchange/basis_set_exchange/__init__.py", line 58, in <module>
    __version__ = version("basis_set_exchange")
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.12/importlib/metadata/__init__.py", line 889, in version
    return distribution(distribution_name).version
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.12/importlib/metadata/__init__.py", line 862, in distribution
    return Distribution.from_name(distribution_name)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.12/importlib/metadata/__init__.py", line 399, in from_name
    raise PackageNotFoundError(name)
importlib.metadata.PackageNotFoundError: No package metadata was found for basis_set_exchange

I think you are trying to run that script from within the package directory without first installing the package into the python environment. After doing that, it works for me.
pip install -e ./  (or wherever the pyproject.toml is)

Yes, BSE used to work straight as a git repository.


CDS-57634 - AWS SAM and Containerized Step Group topics

https://harness.atlassian.net/browse/CDS-57634
Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.
What Type of PR is This?

[ x] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

https://harness.atlassian.net/browse/CDS-57634

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app


Can't install the latest robonomics_comm from airapkgs

It would be convenient to be able to install the HEAD rev of robonomics_comm from aira channel. Let's say robonomics_comm-unstable.
In case I want to use the last patch I have to download robonomics_comm' source code and build it by myself

airapkgs is snapshot of software development, it should be fixed to revision, if you need frontier development commit please use just git.
I’ll keep in mind to provide more frequently updates.


Minification strips whitespace for wrapped lines

Context
Prettier 1.5.0 introduces support for formatting styled-components output. One of the changes it makes is wrapping long lines to the next line.
The minification setting in babel-plugin-styled-components strips out this whitespace entirely.
Test Case
Input test.js:
import styled from 'styled-components';

const output = styled.li`
  animation: really-really-really-really-really-really-long-name 2s linear infinite;
`;

console.log(output.componentStyle.rules);

$ jest test.js
[ 'animation: really-really-really-really-really-really-long-name 2s linear infinite;' ]

Output from prettier test.js, note how there isn't a space between linear and infinite:
import styled from 'styled-components';

const output = styled.li`
  animation: really-really-really-really-really-really-long-name 2s linear
    infinite;
`;

console.log(output.componentStyle.rules);

$ jest test.js
[ 'animation: really-really-really-really-really-really-long-name 2s linearinfinite;' ]

With minification turned off, the whitespace is preserved:
$ jest test.js
[ '\n  animation: really-really-really-really-really-really-long-name 2s linear\n    infinite;\n' ]

Oh, jeeeeez. Thanks for spotting this edge case :smile: I'll see what I can do

thanks @philpl! Let me know if there's anything else I can help with!

@chrisvoll This PR should fix it. Wanna take a look whether it works for you? https://github.com/styled-components/babel-plugin-styled-components/pull/70

Published in 1.1.6


p doesn't work

I updated to the latest nerdtree version and p no longer works to visit the parent node.

+1

hey guys, its working here. What nerdtree options are you using?

Hi, I use vundle (if that matter) and in my .vimrc following options:
    Bundle 'git://github.com/scrooloose/nerdtree.git'

    let NERDTreeShowBookmarks=1
    let NERDTreeChDirMode=2
    let NERDTreeQuitOnOpen=1
    let NERDTreeShowHidden=1
    let NERDTreeKeepTreeInNewTab=0
    let NERDTreeMinimalUI=1 " Disables display of the 'Bookmarks' label and 'Press ? for help' text.
    let NERDTreeDirArrows=1 " Tells the NERD tree to use arrows instead of + ~ chars when displaying directories.

Its working here with those options set.
What version of vim are you guys using?

Macvim, and vim 7.3

I'm not sure if this is related, but it seems to me that p only breaks when i want to go up from a directory that's parent line is combined of multiple dirs. This is a new feature from this commit.
So if i have it like this
  ~ views/some_folder/
    + boxs/ <--- this is where my cursor is

Then p wont work, while if there's no such combined directory in the path then it works as before.

I am not sure why this was closed. @complex857 clearly described the problem, and I was able to replicate the issue precisely. It should be a simple fix that I will get to eventually. Re-opening now...


[CI ONLY] py312 branch changes for the buildfarm

This PR will be rebased and force pushed.

@sklam can we close this one? It's abandoned.


typo: environemnt -> environment

@nschonni : Thanks for your contribution! The author, @mattbriggs, has been notified to review your proposed change.


Finish functional API ops draft

Signed-off-by: Kaiyuan Hu<EMAIL_ADDRESS>

Codecov Report

Merging #835 (3381527) into main (5090e08) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #835      +/-   ##
==========================================
- Coverage   70.94%   70.91%   -0.04%
==========================================
  Files         185      185
  Lines        8182     8196      +14
  Branches     1339     1340       +1
==========================================
+ Hits         5805     5812       +7
- Misses       1979     1986       +7
  Partials      398      398

Impacted Files
Coverage Δ

towhee/pipelines/alias_resolvers.py
64.70% <ø> (ø)

towhee/__init__.py
80.00% <50.00%> (-3.07%)
:arrow_down:

towhee/functional/entity.py
73.07% <50.00%> (-1.93%)
:arrow_down:

towhee/hub/repo_manager.py
80.18% <0.00%> (-0.91%)
:arrow_down:

towhee/models/utils/video_transforms.py
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5090e08...3381527. Read the comment docs.

/lgtm
/approve

/approve
/lgtm


pointertap happens even if mouse down happens outside a displayobject

try mouse button down (touch down) outside a some displayobject
move pointer over this displayobject
then release mouse (or touch)

as a result: pointertap happens

This is with something near the latest version (4.5.6), right?

yes, I use latest version

Any news on this?
Still firing in the latest stable (v4.7.0)

A fix was added for 4.8.0 :)


Twitter section

We must implement UI for twitter's section, ofc it must be responsive:

We can close this #23


/etc/shadow should belong to the shadow group

Describe the bug
Currently, /etc/shadow belongs to the root group. For many use cases, this poses no problems, but when some program needs to use PAM to authenticate on the behalf of multiple users, the program needs to be executed as root (which seems generally unacceptable security-wise). One example is PAM authentication in Nginx, where the NixOS wiki currently recommends running Nginx as root (see discussion here on this).
Expected behavior
I think it's reasonable for /etc/shadow to belong to a group called "shadow" so users can make the decision on letting some programs/users read /etc/shadow. Debian seems to do this as well.
If maintainers agree this is a reasonable thing to do, and if someone can confirm if this change is as simple as adding a group called shadow and adding a line in update-users-group.pl chown-ing /etc/shadow to root:shadow, then I'll create a PR.
Notify maintainers

@edolstra @adisbladis

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/nginx-pam-access-to-etc-shadow/6218/5

I've tackled this in https://github.com/NixOS/nixpkgs/pull/98676. PTAL.

@jonringer As soon as the above PR is merged (https://github.com/NixOS/nixpkgs/pull/98676), it can be backported to 20.09, and this issue won't be blocking 20.09 anymore.


clair: 4.1.2 -> 4.2.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/quay/clair/releases.
meta.description for clair is: "Vulnerability Static Analysis for Containers"
meta.homepage for clair is: "https://github.com/quay/clair"
meta.changelog for clair is: "https://github.com/quay/clair/blob/v4.2.0/CHANGELOG.md"
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

/nix/store/1ig21sg3dkd0fbpiwxhfmxmpan74qk8b-clair-4.2.0/bin/clairctl passed the binary check.

/nix/store/1ig21sg3dkd0fbpiwxhfmxmpan74qk8b-clair-4.2.0/bin/clair passed the binary check.

/nix/store/1ig21sg3dkd0fbpiwxhfmxmpan74qk8b-clair-4.2.0/bin/.clair-wrapped passed the binary check.

3 of 3 passed binary check by having a zero exit code.

2 of 3 passed binary check by having the new version present in output.

found 4.2.0 with grep in /nix/store/1ig21sg3dkd0fbpiwxhfmxmpan74qk8b-clair-4.2.0

found 4.2.0 in filename of file in /nix/store/1ig21sg3dkd0fbpiwxhfmxmpan74qk8b-clair-4.2.0

directory tree listing: https://gist.github.com/881d125f9c5c1413ee1f86b49521c607

du listing: https://gist.github.com/821e9103ab98f590d6b56c5fea56c69d

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
clair

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/1ig21sg3dkd0fbpiwxhfmxmpan74qk8b-clair-4.2.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A clair https://github.com/r-ryantm/nixpkgs/archive/c93b682775a946cea63c48e2634870997cd4564c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/1ig21sg3dkd0fbpiwxhfmxmpan74qk8b-clair-4.2.0
ls -la /nix/store/1ig21sg3dkd0fbpiwxhfmxmpan74qk8b-clair-4.2.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

clair

Maintainer pings
cc @marsam @kalbasit for testing.

Result of nixpkgs-review pr 133465 run on x86_64-linux 1

1 package built:

clair


Robin_map:find() causing segmentation faults

robin_hash::dist_from_ideal_bucket() is causing segmentation faults when accessed via robin_map::find()

Thanks for the report.
Could you try to set a TSL_DEBUG global define (-DTSL_DEBUG) and enable assert (avoiding using NDEBUG) and see if any assert is triggered?
Do you have any code example to reproduce the problem?

How would I set that?  I'm extremely amateur and just running into this while working on a personal project.  I'm looking through to make sure that everything is actually initialized.

You'll pass the -DTSL_DEBUG flag to the compiler command line or add_definitions to CMake.
If you eventually have a small example to reproduce the problem, I could look into it.

I believe this is also related with issues in this ticket: https://github.com/Tessil/robin-map/issues/52

@gabrieltanase42 The above issue should not cause a segmentation fault in the find but an infinite loop.
Looking at the find implementation, a segfault during the dist_from_ideal_bucket() call could be because we access a non-existing bucket. As the ibucket is bounded between [0, bucket_count()) by next_bucket the problem could come from calling find through an invalid or null tsl::robin_map/set pointer or an invalid reference, a custom GrowthPolicy with a wrong bucket_for_hash implementation, a m_buckets which is not of size bucket_count or some corner case bug in the hash map itself with an empty map.
@maxerature As you mention "make sure that everything is actually initialized", how do you use the robin_map/set? Through a pointer or reference? Are you sure the pointer is not null? As a nullptr would exhibit this kind of error.

I'll close the issue for now. @maxerature make sure you're not using the map trough a null-pointer or invalid reference and if you still encounter the error, don't hesitate to reply and I'll re-open the issue.

I got this issue as well.
It is hard to reproduce. My local small scale test works.
It only happens when I run it in real-world data with a pretty large scale.

It turns out that my segmentation fault issue is not from robin_map, but my usage of std::queue.


Extended to set custom Server ID

Script and yaml files edited, I hope it's fine.

The concerns regarding the wait command could be circumvented by (mis)using a healthcheck-script like I did here

My apologies, apparently this is new to me.

Hi @robinmanuelthiel and @madnuttah
I have been looking at this repo too and I want to introduce a similar change to supply a hostname (with -o argument) to the speedtest command optionally, and I plan to open a PR soon from my fork.

Concerning this PR, I tested your changes locally @madnuttah and I observed a problem where the docker container fails if I do not specify the server ID.  I think it would be good to make this ability to add a server ID optional, and if it is missing the the regular speedtest CLI command should be invoked without the -s argument.
Container logs:
Running a Speed Test...
2024-05-30T07:41:46.102927881Z Thu May 30 07:41:46 2024
2024-05-30T07:41:46.107768923Z speedtest: Missing argument for option: -s
2024-05-30T07:41:46.149092423Z Unable to retrieve JSON results from speedtest
2024-05-30T07:41:46.149114881Z Running next test in 1800s...
2024-05-30T07:41:46.149116256Z

p.s. the similar change I made can be found at

https://github.com/bazzani/speedtest/commit/2033353a1b671a3be0b7de876376f49c2cbe9568

Yeah, if we introduce Server ID and URL, I would like to see them as optional parameters as well. This implementation here requires them.

Hi @robinmanuelthiel and @madnuttah
I have been looking at this repo too and I want to introduce a similar change to supply a hostname (with -o argument) to the speedtest command optionally, and I plan to open a PR soon from my fork.
Concerning this PR, I tested your changes locally @madnuttah and I observed a problem where the docker container fails if I do not specify the server ID. I think it would be good to make this ability to add a server ID optional, and if it is missing the the regular speedtest CLI command should be invoked without the -s argument.
Container logs:
Running a Speed Test...
2024-05-30T07:41:46.102927881Z Thu May 30 07:41:46 2024
2024-05-30T07:41:46.107768923Z speedtest: Missing argument for option: -s
2024-05-30T07:41:46.149114881Z Running next test in 1800s...
2024-05-30T07:41:46.149116256Z

p.s. the similar change I made can be found at

bazzani@2033353

This looks promising. Can you create a PR from your repo back into this one?

p.s. the similar change I made can be found at

bazzani@2033353

This looks promising. Can you create a PR from your repo back into this one?

Hi @robinmanuelthiel, may I ask you to please clarify that you are referring to my suggested change?

https://github.com/bazzani/speedtest/commit/2033353a1b671a3be0b7de876376f49c2cbe9568

If so, I can work on this, and also add support for the -s flag at the same time
although providing them must be mutually exclusive or this causes an error when running the speedtest cli with both -o and -s provided 👇

speedtest --accept-license --accept-gdpr -f json -s 28910 -o lg-tok.fdcservers.net
[2024-06-09 21:50:15.193] [error] Only one server selection can be specified

Yes, exactly. To me it's important, that I also works without specifying any server name or IP.

Yes, exactly. To me it's important, that I also works without specifying any server name or IP.

100%, I will open the PR soon enough, after giving it a thorough test locally.

Hey there and sorry for my late reply. I must confess this was quite rushed. It was working so I submitted the PR without any further tests, as I wrote it did what I wanted. I'm sorry if it didn't meet the quality you've expected. As I'm doing much better again, I'm getting a take on this again.

@bazzani Not sure, if I like the build part in the Docker Compose file, as I wanted to give an example, how to use the container easily in Docker Compose file. Building it yourself, would make it harder. But we could maybe add another examle file for self-building or just use both, image and build https://docs.docker.com/compose/compose-file/build/#using-build-and-image

Hey there and sorry for my late reply. I must confess this was quite rushed. It was working so I submitted the PR without any further tests, as I wrote it did what I wanted. I'm sorry if it didn't meet the quality you've expected. As I'm doing much better again, I'm getting a take on this again.

Hey no worries - thanks for the contribution. We are working on this together! 💪

@bazzani Not sure, if I like the build part in the Docker Compose file, as I wanted to give an example, how to use the container easily in Docker Compose file. Building it yourself, would make it harder. But we could maybe add another examle file for self-building or just use both, image and build https://docs.docker.com/compose/compose-file/build/#using-build-and-image

I see what you mean @robinmanuelthiel, thanks for the input and helping me consider the other optionsyou proposed.
I think I was perhaps a tad too deep in the developer mindset, and not enough in a consumer (of the service) mindset.
I will review that link you sent and play about a bit with the image and build approach.

Hey there and sorry for my late reply. I must confess this was quite rushed. It was working so I submitted the PR without any further tests, as I wrote it did what I wanted. I'm sorry if it didn't meet the quality you've expected. As I'm doing much better again, I'm getting a take on this again.

Thank you for the PR @madnuttah, I do appreciate your changes as it helped me to understand the project more, and made me more curious as to how we can extend it by working together. OSS is the best!

@bazzani it seems like you invested way more time into this and the script looks better already than what I have here right now. I'll close this, also because of a lack of time. Sorry, I shouldn't have done this that time.

Sorry, I shouldn't have done this that time.

I disagree!  Can't wait to see this feature here soon. Thanks for your work @madnuttah! Keep it coming. (both feedback, issues and code contributions)

@bazzani, are you still planning to create a PR for the Server ID?

@bazzani, are you still planning to create a PR for the Server ID?

Hi @robinmanuelthiel i am indeed. I started working on it last week and got stuck on a few shell scripting logic challenges (due to the two mutually exclusive optional flags). I then got sick on Friday so I have not had a chance to complete it yet.
I will look at it tomorrow and get something in a PR for your review.

FYI @robinmanuelthiel @madnuttah #19


pipelines: add source image builds to all pipelines

We are legally required to distribute the source for our OSS projects. Adding this task ensures compliance in the RHTAP build pipeline.

/lgtm


Searching in the group selector, where options are loaded via the API, does not work for androids

Describe the bug
Searching in the group selector, where options are loaded via the API, does not work on many androids, especially cheap ones
Steps to reproduce

group selector

allGroups is answer from api with groups list
Link to minimal reproduction
https://uust-time.ru/
System Info
Android Poco

Used Package Manager
npm
Validations

[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion.
[X] The provided reproduction is a minimal reproducible example of the bug.

This is a PC library, not too much compatibility processing for mobile


how to embed a youtube video?

is the a way to embed html iframe
thanks

@cobraprojects have you embedded youtube video ?


Feature Request: Folders

I photoshopped an image as a preview for this. There are different roles in raids and instead of having 8 tob layouts, 2 for each role for regular tob and hard mode tob, you could have one icon to click on the left for theatre of blood, and then on the top you can click the infinity logo to go back to your bank, or any of the top tabs for your bank tag layout options. You could make a tab and call it (tob) tob mdps and it would go to the (tob) folder and the bank tag would be called tob mdps. (cox) surge telegrab would go in the (cox) folder, and the bank tag would be called surge telegrab. You could set icons for the folder, and for each bank tag like regular. Some sort of implementation of this would be amazing. I'll venmo you lol
Use cases for folders:
Clues: Beginner through master is 6, plus mimic makes 7 tabs reduced to 1.
Raids 1: Regular cox solo, trio, CM's Solo, CM's casual, CM's max eff surge telegrab, CM's max eff surge entangle, CM's max eff venge/humid. 7 tabs reduced to 1.
Raids 2: Tob solo, Tob mage, Tob nfrz, Tob rdps, Tob mdps, HMT mage, HMT nfrz, HMT rdps, HMT mdps. 9 tabs to 1.
Raids 3: Toa solo, Toa 150, Toa 300, Toa 450, Toa 500. 5 to 1.
Nightmare: Regular NM solo, Regular NM team, PNM. 3 to 1.
Desert Treasure 2 bosses: 4 bosses reduced to 1.
Farming: Hespori, tree run, herb run, idk I don't do farming anymore so like 5 to 1.
Idk you can see it gets congested and adds up fast. This would be great to have and I love the idea of having the folders on the left and the banktags up top. Just regraphic the infinity logo to a back button and it's clear how to get back. Idk if anybody else uses bank tag layouts like I do but I have so many and I hate scrolling. I would really love an option to organize like this. I think it's clean ui and efficient use of space. Limit folders to 9 entries and you're golden. Thanks! I love the plugin and all the plugins you've made on the hub.

As someone with 50+ tag tabs, I'd be super psyched about this feature, and this implementation looks great. You could also condense GWD bosses, wilderness bosses, slayer bosses, and skilling tabs into their own folders as well.
Functionally, I question how you would go about dragging items from your actual bank into a tag tab in a folder, considering it's two layers deep. I'm not sure what limitations there might be, but perhaps the tag tab or bank tab icons could dynamically change to represent the tag tabs in folders when the folder is hovered over with an item?

I'd ask anyone commenting here to consider whether the tag tab tab would suit your needs (right-click the + button in the top left and choose "view tag tabs").
I don't plan to add folders anytime soon if at all and idk of anyone else who's willing to do that work either.

I already make use of the tag tab tab and have it as the default left click.
In my view, folders are more of a wishlist QoL feature than a necessity
(whereas the bank tags and layouts base plugins ARE necessities in my
enjoyment of the game at this point). They'd make for a cleaner, more
organized and satisfying experience that would certainly be utilized by
many if the hours were put in to implement, but with no real loss as far as
the plugin's functionality is concerned if they never happened.
Hopefully one day this plugin and it's features are added to the core game
and perhaps expanded on with features like this, but I know that's
controversial.
On Wed, Feb 28, 2024, 2:50 PM geheur @.***> wrote:

I'd ask anyone commenting here to consider whether the tag tab tab would
suit your needs (right-click the + button in the top left and choose "view
tag tabs").
I don't plan to add folders anytime soon if at all and idk of anyone else
who's willing to do that work either.
—
Reply to this email directly, view it on GitHub
https://github.com/geheur/bank-tag-custom-layouts/issues/92#issuecomment-1969895075,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHWXKMJLMUQDMVODU3CSTQDYV6KARAVCNFSM6AAAAABD43Y34GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRZHA4TKMBXGU
.
You are receiving this because you commented.Message ID:
@.***>


I created and uploaded a PyPI package of bilm.

Hi,
I just wanted to let you know that I created and uploaded a PyPI package of bilm. See here: https://pypi.org/project/bilm/
I did set myself as maintainer and offer to maintain it if you want me to.
I also plan to create a conda package for conda-forge: https://conda-forge.org/
Otherwise if you want I can transfer the package in PyPI (and the maintainer attribute) to you.
Thanks
Philip

Thank you!
In the long run it's probably best if we maintain the packages -- will follow up via email.

I added mattpeters as additional owner on PyPI:
https://pypi.org/manage/project/bilm/collaboration/

Thanks Philip!


Overwrite Option

Hey @maxogden,
I created this as potential fix to #20. By default overwrite is true but we can toggle it off. I created a function to remove the symlink if it already exists. I added some tests but I did run into a weird issue with the last test:
test('callback called once', function (t) {
  rimraf.sync(targetC)
  t.plan(2)
  console.log('extracting to', targetC)
  extract(sourceC, {dir: targetC}, function (err) {
    if (err) throw err

    // this triggers an error due to symlink creation
    // NOTE the new overwrite: false option
    extract(sourceC, {dir: targetC, overwrite: false}, function (err) {
      if (err) t.ok(true, 'error passed')
      t.ok(true, 'callback called')
    })
  })
})

It craps out with:
events.js:141
      throw er; // Unhandled 'error' event
      ^
Error: EBADF: bad file descriptor, read
    at Error (native)

Any ideas?
Looks like this unresolved node bug: https://github.com/nodejs/node/pull/2955 && https://github.com/nodejs/node/issues/2950

Crazy, haven't run into this case before. cc'ing @mafintosh here too

@maxogden any intent to merge the PR?


Corporate Console - Updated project name is not displayed in Manage Approved List window

Background

Launch Project Console
Login as Project Manager
Click on Foundation
Update the project name of a project that has Pending Whitelists for a company
Launch Corporate Console
Login as CLA Manager
Click on Company
Observed the updated project name is displayed

Click on MANAGE APPROVED LIST
Observed that the updated project name is not displayed and still previous project name is displayed

@nirupamav please confirm this works.  Demo'd to team earlier this week.

Testing blocked due to bug #1626

Verified that the issue is fixed. Also tested in others pages of Corporate Console, Project Console and Contributor console and issue is fixed


[SDP-297] Cucumber tests turned back on without Poltergeist

Make sure you have checked off the following before you issue your Pull Request:

[X] Passed overcommit hooks, including running all code through Rubocop

NB: lots of the cucumber tests fail, but fail for good reasons, not due to driver issues.

Closing PR as it was overtaken by using selenium and chrome instead on webkit


support multiple different ron file types

Hello, this is simple PR, that allow to use custom file format and multiple different asset files types.
Now plugin can be used in two different ways:
// there are the same
app.add_plugins(RonAssetPlugin::<Wizard>::default());
app.add_plugins(RonAssetPlugin::<Wizard>::create("ron"));

// but we can register multiple different types
app.add_plugins(RonAssetPlugin::<Wizard>::create("wizzard.ron"));
app.add_plugins(RonAssetPlugin::<Spell>::create("spell.ron"));

Hello,
Thanks for the contribution. Makes sense, very useful. I will directly publish the new version!


lazily/manually register the QEMU interpreters

this would save us a docker call
the downside is that this requires sudo / root privilege

If by save a docker call, you mean use qemu outside the container... I'm not sure this is a great idea for a few reasons:

Issues with any shared libraries (C or C++ runtimes) required to run the image present only in the image.
Cannot run custom operating systems without having a linux image installed.
Would require installing qemu on the host, which would require substantial setup.

This probably isn't worth it anymore, since Rust 1.19 is effectively no longer used, so I think we can safely assume this isn't relevant for nearly all dev environments anymore.


Tags

Some documents qualify for several folders, when folders are used as "tags", in a way. For example, when I write for Diffbot, I put them in the Diffbot folder. When I write for SitePoint, I put them in the SitePoint folder. But then there are stages - Under Review, In Progress, etc. I could have separate folders for SitePoint - Under Review, SitePoint - In Progress, but that brings with it a whole lot of tab noise when you have many projects. Besides, sometimes something I write for Diffbot will get published on SitePoint, and then it would match both folders - which one do I put it in?
As a fix, I would recommend adding tags into the mix, so we can label documents with categories or milestones. I currently do this with prefixes.

Either that, or adding subfolders into main folders - so we can have an "Under Review" subfolder in SitePoint. That still wouldn't allow me to add a post under both SitePoint and Diffbot, but would help.

Have you considered using different classeurs (using the switch on the top of the screen)? You could have a classeur for SitePoint, another for Diffbot, and then have folders named "Under Review", "In Progress" in each of them.

I had no idea this feature existed, thanks, that solves it with subfolders!

BTW, one folder can be shared by multiple classeurs, using + > import folder.

That's even cooler. Thanks!


ci: update linked dependencies when versions bump

Remove --no-private option in bump-version script to update dependencies in the private packages
Ref: https://github.com/ckb-js/kuai/issues/388

Codecov Report

Merging #397 (cd4d0c6) into develop (6c3fcc1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #397   +/-   ##
========================================
  Coverage    62.39%   62.39%
========================================
  Files           94       94
  Lines         3101     3101
  Branches       688      688
========================================
  Hits          1935     1935
  Misses        1057     1057
  Partials       109      109

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c3fcc1...cd4d0c6. Read the comment docs.


Add pre-commit hooks and set resource_class

Adds pre-commit hooks and sets default resource_class to small, since large is a bit overkill?

Ah this duplicates https://github.com/CircleCI-Public/orb-tools-orb/pull/152, closing


fix potential io streams leak

Io streams/memory leak can happen in case of any exceptions during further initialization.

thanks!


Stopped working in IE 11

Version 0.1.0 worked fined. With recent version 1.0.3 I get the following:

TypeError: Invalid attempt to spread non-iterable instance

This stops the application from running completely. This only happens in IE11, it works fine in Chrome.
Code causing this is in beforeModel of application route:
config.i18n.allowedLocales = ['de', 'en', 'fr'];
const bestLanguage = get(this, 'bestLanguage').bestLanguageOrFirst(config.i18n.allowedLocales);
const languageToSet = get(bestLanguage, 'baseLanguage');

What do you have in your config/targets.js?

'use strict';

const browsers = [
  '> 1%',
  'last 2 versions',
  'Android >= 5',
  'IE >= 11',
  'iOS >= 9'
];

module.exports = {
  browsers
};

This was fixed by #18 🎉


F13 as a keyboard shortcut

VSCode Version: 1.32.3
OS Version: Windows 10.0.17763 Build 17763

Steps to Reproduce:

remap Capslock to F13 through autohotkey or registry

Windows Registry Editor Version 5.00

[HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Keyboard Layout]
"Scancode Map"=hex:00,00,00,00,00,00,00,00,02,00,00,00,64,00,3a,00,00,00,00,00

try to use it to as a keyboard shortcut and it won't work.

I am a bit weary of doing the registry change, but I have a keyboard which has a physical F13 key. Pressing F13 on this keyboard is recognized correctly by VS Code.

the register way still not working. the ahk wasn't working because it relied on the register change I made. closing because ahk on its own works.


Document where to use versioned struct and where not

Hi,
I'm using client-go's NewSharedInformer to access ingresses but I'm not sure which expectedType to use.
I've started out using (k8s.io/client-go/pkg/apis/)extensions.Ingress which worked on my 1.7 clusters but another user reported their got the error expected type *extensions.Ingress, but watch event object had type *v1beta1.Ingress" component. If I use (k8s.io/client-go/pkg/apis/extensions/)v1beta1.Ingress it seems to work on all cluster but I couldn't find any authoritative information about The Right Way.
Please document which structs to use with NewSharedInformer, preferably in a way that still works when Ingress get moved out of beta.

FYI, I got the error also on 1.7 k8s cluster (1.7.2)

/remove-lifecycle stale
/lifecycle freeze

/lifecycle frozen


assert_iamframe_equals() passes if all-nan-cols are present

Please confirm that this PR has done the following:

[x] Tests Added
[x] Documentation Added
~Name of contributors Added to AUTHORS.rst~
[x] Description in RELEASE_NOTES.md Added

Description of PR
Currently, assert_iamframe_equal() fails if one of the IamDataFrames has a meta-column of all-nan's (and the column doesn't exist in the other IamDataFrame). Arguably, all-nan should be treated as identical to "column doesn't exist".
The PR also adds a page for the testing module to the docs.
Closes #515

Perfect, good to merge from my side.


[EventEngine] Make the thread pool quiesce 10x faster, and add a small stress test

Good news! After adding multiple closures to the test in https://github.com/grpc/grpc/pull/33223/commits/3aef630dffc46ee1d80213769d6f3a5b529a98c8 (this PR), I confirmed that the quiesce stress test fails with a non-empty pool error before PR https://github.com/grpc/grpc/pull/33219 landed, and that PR fixes it.


Improve IDE experience for snippets #221

Oh wow! Didn't know you could get click-through-to-file in asciidoc on IntelliJ. Very nice. :)


Go To File includes files that are in search.exclude

VSCode Version: Code - Insiders 1.11.0-insider (c995ecf2e94a00aa7eda81ed842e787b999e83ae, 2017-03-27T06:05:14.051Z)
OS Version: Darwin x64 15.6.0
Extensions:

Extension
Author
Version

EditorConfig
EditorConfig
0.6.2

JSDocTagComplete
HookyQR
0.0.2

code-settings-sync
Shan
2.6.1

sort-lines
Tyriar
1.2.0

vscode-svgviewer
cssho
1.4.0

jshint
dbaeumer
0.10.15

vscode-eslint
dbaeumer
1.2.8

githistory
donjayamanne
0.2.0

tslint
eg2
0.8.1

vsc-ember-cli
felixrieseberg
0.3.3

phpcs
ikappas
0.7.0

prettify-json
mohsen1
0.0.3

Theme-MarkdownKit
ms-vscode
0.1.1

jscs
ms-vscode
0.1.9

typescript-javascript-grammar
ms-vscode
0.0.18

autolinting-for-javascript
t-sauer
1.3.0

vscode-babel-repl
t-sauer
0.1.2

vscode-apielements
vncz
0.6.4

gitblame
waderyan
1.3.0

Steps to Reproduce:

Open a workspace which has additional directories in search.exclude
Open "Go To File" (Cmd + P)
Type in something that matches something in an excluded directory
Excluded files show up (for example files in node_modules)

Until I updated VSCode today, all files from the excluded directories were also excluded from "Go To File".

https://github.com/Microsoft/vscode/issues/23270


Add react-hooks.org to showcase

Motivation
I built react-hooks.org entirely with docusaurus and I would like to add it to it's showcase.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Just changed the a JSON file. I don't know if it requires any tests.

thanks :)


Client change step function

I've left specific comments throughout, however, the general point is that the polling of DescribeExecution needs more love.
Don't mix callbacks and Promises, it's confusing and error-prone, particularly if recursion is involved.
Here is some example code which uses only Promises:
https://gist.github.com/woolinsilver-kainos/c0dc922eaaf6be70f5ad6d2116f76c65
The magic is on line 63.
The file can be run as-is to see what's happening, e.g. node task-poller.js.


Add dal.hpp

Add global header that includes all library functionality
Add test that verifies all algorithms are include in dal.hpp. There is no such checks for tables and IO, expect they are not updated so frequently
Move .clang-format one level up, update paths in CI scripts

/intelci: run

/intelci: run

/intelci: run


Make  android error

when I use ndk16 to make mxnet ,it need <x86intrin.h>.but ndk sysroot don't have this. How can I do?THS

@sandeep-krishnamurthy  could you help to add label installation/build? Thanks!

Does using USE_F16C=0 help?

I have the same problem! How to solve it?

In case you are using make based build you should try as suggested by @rahul003:
USE_F16C=0 make -j$(nproc)

or
cp make/config.mk ./config.mk
# change "USE_F16C =" line to "USE_F16C = 0"
make -j$(nproc)

Just to be clear, I use following configurations:
NDK version => 15.2.4
TARGET => arm64/ARMV8
export CC=aarch64-linux-android-gcc
export CXX=aarch64-linux-android-g++

Then I move to the incubator-mxnet/amalgamation and type:
make ANDROID=1
When I try commands suggested by @lebeg:
USE_F16C=0 make -j$(nproc)
I have the same error which is:
mxnet_predict-all.cc:83:23: fatal error: x86intrin.h: No such file or directory
 #include <x86intrin.h>
                       ^
compilation terminated.
make: *** [mxnet_predict-all.o] Error 1

a solution is comment the line "#include <x86intrin.h>" after make for the first time,
then make ANDROID=1 would work.


Sorting in bibliography: lowercase appears after uppercase (“author” after “Zuthor”)

This affects both lowercase family names and non-dropping-particles.
Example:
pandoc -s -F pandoc-citeproc -t markdown-citations-markdown_in_html_blocks << EOT
---
references:
- author:
  - family: author
    given: Al
  id: a
  issued:
    date-parts:
    - - 1985
  title: Title
  type: book

- author:
  - family: Author
    given: Al
  id: A
  issued:
    date-parts:
    - - 1985
  title: Title
  type: book

- author:
  - family: zuthor
    given: Zoe
  id: z
  issued:
    date-parts:
    - - 1985
  title: Title
  type: book

- author:
  - family: Zuthor
    given: Zoe
  id: Z
  issued:
    date-parts:
    - - 1985
  title: Title
  type: book

- author:
  - family: Doe
    given: Dan
    non-dropping-particle: de
  id: d
  issued:
    date-parts:
    - - 1985
  title: Title
  type: book
...

# Text

Foo [@A; @a; @d; @Z; @z].

# References

EOT

Expected:
Text
====

Foo (Author 1985; author 1985; de Doe 1985; Zuthor 1985; zuthor 1985).

References {#references .unnumbered}
==========

Author, Al. 1985. *Title*.

author, Al. 1985. *Title*.

de Doe, Dan. 1985. *Title*.

Zuthor, Zoe. 1985. *Title*.

zuthor, Zoe. 1985. *Title*.

Actual:
Text
====

Foo (Author 1985; author 1985; de Doe 1985; Zuthor 1985; zuthor 1985).

References {#references .unnumbered}
==========

Author, Al. 1985. *Title*.

Zuthor, Zoe. 1985. *Title*.

author, Al. 1985. *Title*.

de Doe, Dan. 1985. *Title*.

zuthor, Zoe. 1985. *Title*.

@nickbart1980 - I get the correct output for this test case (so I can't reproduce your "actual" output):
Text
====

Foo (Author 1985; author 1985; de Doe 1985; Zuthor 1985; zuthor 1985).

References {#references .unnumbered}
==========

Author, Al. 1985. *Title*.

author, Al. 1985. *Title*.

de Doe, Dan. 1985. *Title*.

Zuthor, Zoe. 1985. *Title*.

zuthor, Zoe. 1985. *Title*.

Are you perhaps using an older version inadvertently?

No, latest dev version, but I'm usually compiling with cabal install -ftest_citeproc -funicode_collation. Without -funicode_collation, i.e., just cabal install -ftest_citeproc, I get the same result as you do.

I just installed with -funicode_collation.  Still couldn't reproduce what you're seeing...
With unicode_collation:
Text
====

Foo (Author [1985](#ref-A); author [1985](#ref-a); de Doe
[1985](#ref-d); Zuthor [1985](#ref-Z); zuthor [1985](#ref-z)).

References {#references .unnumbered}
==========

author, Al. 1985. *Title*.

Author, Al. 1985. *Title*.

de Doe, Dan. 1985. *Title*.

zuthor, Zoe. 1985. *Title*.

Zuthor, Zoe. 1985. *Title*.

That's odd. I’m on MacOS 10.10, and have now upgraded to icu4c 55.1 (homebrew: https://homebrew.bintray.com/bottles/icu4c-55.1.yosemite.bottle.tar.gz), and reinstalled pandoc-citeproc (which in turn reinstalls text-icu-<IP_ADDRESS>) with the following:
pandoc-citeproc $ cabal install -ftest_citeproc -funicode_collation --extra-lib-dirs=/usr/local/opt/icu4c/lib --extra-include-dirs=/usr/local/opt/icu4c/include
Resolving dependencies...
In order, the following will be installed:
text-icu-<IP_ADDRESS> (reinstall) changes: text-<IP_ADDRESS> -> <IP_ADDRESS>
pandoc-citeproc-0.7 +unicode_collation +test_citeproc (reinstall) changes:
aeson-pretty-0.7.2 added, attoparsec-<IP_ADDRESS> added, process-<IP_ADDRESS> added,
temporary-<IP_ADDRESS> added, text-icu-<IP_ADDRESS> added
Warning: Note that reinstalls are always dangerous. Continuing anyway...
Configuring text-icu-<IP_ADDRESS>...
Building text-icu-<IP_ADDRESS>...
Installed text-icu-<IP_ADDRESS>
Configuring pandoc-citeproc-0.7...
Building pandoc-citeproc-0.7...
Installed pandoc-citeproc-0.7
Updating documentation index
/Users/nick/Library/Haskell/share/doc/x86_64-osx-ghc-7.8.3/index.html

Output, as before:
Text
====

Foo (Author [1985](#ref-A); author [1985](#ref-a); de Doe
[1985](#ref-d); Zuthor [1985](#ref-Z); zuthor [1985](#ref-z)).

References {#references .unnumbered}
==========

Author, Al. 1985. *Title*.

Zuthor, Zoe. 1985. *Title*.

author, Al. 1985. *Title*.

de Doe, Dan. 1985. *Title*.

zuthor, Zoe. 1985. *Title*.

Anything else I could try?

I'm at a loss.  I've tried this with -funicode_collation on both Ubuntu linux and OSX (with icu4c installed via homebrew) , and in both cases I get correct sorting.  (I don't know if icu's collation is locale-dependent.  What is your locale?)

Excellent guess. – $locale told me:
LANG=
LC_COLLATE="C"
LC_CTYPE="UTF-8"
LC_MESSAGES="C"
LC_MONETARY="C"
LC_NUMERIC="C"
LC_TIME="C"
LC_ALL=

Running
export LC_ALL=en_US.UTF-8
export LANG=en_US.UTF-8

resolves the sorting issue, also for accented and other modified characters for which icu4c was originally brought in (see https://code.google.com/p/citeproc-hs/issues/detail?id=64).
Also, export LC_ALL=da_DK.UTF-8; export LANG=da_DK.UTF-8 leads to the correct Danish sorting of “Ø” after “Z”, so this all looks ok.
My follow-up question is, could pandoc be patched to make icu4c use the locale matching the content of the lang variable, or, if this is empty, use en-US as a default?

+++ nickbart1980 [May 05 15 01:45 ]:

Excellent guess. – $locale told me:
LANG=
LC_COLLATE="C"
LC_CTYPE="UTF-8"
LC_MESSAGES="C"
LC_MONETARY="C"
LC_NUMERIC="C"
LC_TIME="C"
LC_ALL=

Running
export LC_ALL=en_US.UTF-8
export LANG=en_US.UTF-8

resolves the sorting issue, also for accented and other modified characters for which icu4c was originally brought in (see https://code.google.com/p/citeproc-hs/issues/detail?id=64).
Also, export LC_ALL=da_DK.UTF-8; export LANG=da_DK.UTF-8 leads to the correct Danish sorting of “Ø” after “Z”, so this all looks ok.
My follow-up question is, could pandoc be patched to make icu4c use the locale matching the content of the lang variable, or, if this is empty, use en-US as a default?

That should be possible.  Currently we have
src/Text/CSL/Style.hs line 438:
      comp a b = T.collate (T.collator T.Current) (T.pack a) (T.pack b)

The Current means:  use the current locale.  Instead of Current, we
could use Locale "en-US" or whatever.

OK, on closer look, it's not easy to make the collation depend on the locale specified in the style.
The problem is that the compare' function, and the Ord instance it is used to define, doesn't have a parameter for style or locale.
I might try leaving it as Current and setting the LANG environment variable from within pandoc-citeproc, depending on the style.

That seems to work well.  The locale will be set by the locale metadata field, if present, and otherwise the style's own default-locale, or en-US if that isn't present either.

Well, mostly. Locale-specific collation is not set from the locale metadata field yet.
I get the Danish collation, “Ø” after “Z”, only after running export LC_ALL=da_DK.UTF-8 (interestingly enough, not with export LC_COLLATE="da_DK.UTF-8" alone).

Really?  It works for me:
---
locale: da_DK
references:
- issued:
  date-parts:
  - - 2005
  author:
  - given: John
    family: Øoe
  id: item1
  title: First book
  type: book
  publisher: Cambridge University Press
  publisher-place: Cambridge
- container-title: Journal of Generic Studies
  issued:
    date-parts:
    - - 2006
  author:
  - given: John
    family: Zoe
  id: item2
  title: Article
  type: article-journal
  volume: '6'
  page: '33-34'
...

@item1
@item2

With this I get Z before  Ø.
When I comment out the locale line in the metadata, I get Ø before Z.

Hmm, what's your output when you run the locale command? And shouldn't it be da-DK (with a hyphen) in your example?

My locale is
LANG=en_US.UTF-8
LANGUAGE=
LC_CTYPE="en_US.UTF-8"
LC_NUMERIC="en_US.UTF-8"
LC_TIME="en_US.UTF-8"
LC_COLLATE="en_US.UTF-8"
LC_MONETARY="en_US.UTF-8"
LC_MESSAGES="en_US.UTF-8"
LC_PAPER="en_US.UTF-8"
LC_NAME="en_US.UTF-8"
LC_ADDRESS="en_US.UTF-8"
LC_TELEPHONE="en_US.UTF-8"
LC_MEASUREMENT="en_US.UTF-8"
LC_IDENTIFICATION="en_US.UTF-8"
LC_ALL=

It works either with da-DK or da_DK (pandoc-citeproc treats these the same).
+++ nickbart1980 [May 07 15 10:12 ]:

Hmm, what's your output when you run the locale command? And shouldn't
it be da-DK (with a hyphen) in your example?
—
Reply to this email directly or [1]view it on GitHub.
References

https://github.com/jgm/pandoc-citeproc/issues/122#issuecomment-99941418

OK, this seems to be hinging on whether LC_ALL is set or not. If it is, LANG does not seem to override it. If I leave LC_ALL unset, your example works as expected.

Aha.  Currently I just set LANG (in the subprocess) according to the
value of the locale metadata, if set.  Should I just set LC_ALL
instead?  That should be safe, I think.
+++ nickbart1980 [May 08 15 03:58 ]:

OK, this seems to be hinging on whether LC_ALL is set or not. If it is, LANG does not seem to override it. If I leave LC_ALL unset, your example works as expected.

Reply to this email directly or view it on GitHub:
https://github.com/jgm/pandoc-citeproc/issues/122#issuecomment-100195181

Yes, that seems better. In general, the most common approach seems to be to let users set LANG but not LC_ALL, and use the latter in scripts to override the former, if necessary. See, e.g., https://www.gnu.org/software/gettext/manual/html_node/Locale-Environment-Variables.html.

I've done this.


Revert removal of integrity checks in yarn.lock

@jstastny-cz Thanks for the PR. It would be great for us to understand what caused that. Since yarn.lock is a big file and we have good-enough checks on our CI, we many times skip looking at it more carefully on reviews. It's clear to me that there's no reason for us to remove those integrity checks, so understanding the commands ran during development that made the integrity checks be removed will be valuable to us.

@tiagobento it is usage of locktt --registry=<URL> without --skipIntegrity

@domhanak Right. Thanks for reply!
@Ginxo Hi! So, I'm not that familiar with the everyday use of locktt, I only know it's used inside our Jenkins/Prod environments, but given what happened here, maybe we could make --skipIntegrity be turned on by default? Or is it that the standard usage of locktt always aims at removing the integrity checks from yarn.lock/package-lock.json files?

@domhanak What do you mean "some dependencies resolved to newer version"? yarn.lock is basically a recipe for reproducible builds, so everything that's written there is what's used to download the dependencies. Also, yarn.lock has to be aligned with what's declared on our package.json files. If it's not, then after a yarn run init, we'll see changes on yarn.lock. That's why we have the Check yarn.lock steps on our CI builds. If everything is green, we shouldn't have to update anything. Am I missing something?

@tiagobento you are correct, all I mean that since we use ^ yarn resolved newer version than we have declared(expected).

+1 to this PR. locktt it's basically used by locktt in production build in order to replace registry (prod build system only access to our internal npm registry and it fails due to .lock files).
It seems to be solved by yarn 2+ so we will remove locktt from this project once we test it and we migrate prod system to this new version.

@Ginxo Thx for chiming in! Upgrading to Yarn 2 sounds like a good idea :) Thanks!


KeyError: 'GT_CLOUD_BASE_URL' when running skatepark emulator example

Running the skatepark emulator example, it seems the example client expects the GT_CLOUD_BASE_URL environment variable to be defined, but it's not mentioned in the repo readme.
 ❯ poetry run python client.py
Traceback (most recent call last):
  File "/Users/dylan/Documents/managed-structure-example/example-client/client.py", line 26, in <module>
    HOST = os.environ["GT_CLOUD_BASE_URL"]
           ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^
  File "<frozen os>", line 685, in __getitem__
KeyError: 'GT_CLOUD_BASE_URL'

I see the example .env.client.example contains all the right values, I think it just needs to be mentioned in the readme.

check out latest in https://github.com/griptape-ai/griptape-cli/pull/29


Add must_use to read and write...

as the number of bytes actually read/written may be fewer than buf.len()

This doesn't seem to be doing the thing we want. The must_use seems to apply to the Result, not to the u32.
This compiles with no warnings even though you don't use the u32:
pub fn do_read(mut t: impl Read) {
    t.read().unwrap();
}

This does warn, but it already warned before this change because Result is already must_use.
pub fn do_read(mut t: impl Read) {
    t.read();
}

going to close this for now, since there's apparently no way to apply #[must_use] to the Ok(_) variant and not to the Result itself in Rust today... :(


The following components and platforms could not be set up:

HA 0.98.3 on a Raspberry 64 bit hassio image running on a Pi4 4GB.
Using Cyberpower PR1500ELCD here that is pretty identical to APC SMT1500i
When I start HA I have this message:
The following components and platforms could not be set up:
apcupsd
apcupsd.binary_sensor
apcupsd.sensor
Please check your config.
this is my config in the config.yaml
apcupsd:
  host: a722577e-apcupsd

# Sensors
binary_sensor:
  - platform: apcupsd

sensor:
  - platform: apcupsd
    resources:
      - bcharge
      - version
      - upsmode
      - model
      - status
      - linev
      - loadpct
      - bcharge
      - timeleft
      - mbattchg
      - mintimel
      - maxtime
      - maxlinev
      - minlinev
      - outputv

System logs shows this error:
19-09-05 19:39:29 INFO (MainThread) [hassio.core] Hass.io is up and running
19-09-05 19:39:44 WARNING (MainThread) [hassio.api.addons] Protected flag changing for a722577e_apcupsd!
19-09-05 19:39:47 INFO (SyncWorker_16) [hassio.docker.interface] Clean addon_a722577e_apcupsd application
19-09-05 19:39:48 ERROR (SyncWorker_16) [hassio.docker] Can't start addon_a722577e_apcupsd: 500 Server Error: Internal Server Error ("linux runtime spec devices: error gathering device information while adding custom device "/dev/usb/": no such file or directory")

this commands shows the UPS:
core-ssh:~# cat /sys/bus/usb/devices/*/product
PR1500ELCD
USB2.0 Hub
xHCI Host Controller
xHCI Host Controller
DWC OTG Controller

core-ssh:/dev# ls /dev
fd       full     init     mqueue   null     ptmx     pts      random   shm      stderr   stdin    stdout   tty      ttyAMA0  urandom  zero

Addons does not even start and there is no log in the logs section of the addon

apcupsd only supports APC UPSes. Perhaps this add-on will work with your UPS.

It's strange, I have seen lot of users using this add-on on Cyberpower UPSs

Can you point me anywhere about this? I looked for a little while before closing this, and I didn't see any evidence of someone using apcupsd with Cyberpower UPSes.


Tesseract 4.1 - Setting region of interest doesn't work

The following unit tests are failing in Tesseract 4.1 build (branch features\321-Tesseract-4):

EngineTests.CanProcessDifferentRegionsInSameImage
EngineTests.CanProcessSpecifiedRegionInImage

seems to be related to https://github.com/tesseract-ocr/tesseract/issues/845
More specifically setting setting the region of interest (SetRectangle in tesseract) to anything other than the dimensions of the pix causes erroneous results (random sting output).

I just stumbled about this bug as well. Is there a chance it will be fixed soon?

Still broken in Tesseract 5.0 (#579) :(


Enhancement: Push notifications instead of polling

Problem
Right now (v1.0.3) notifications are being pulled from the back end with polling interval of 15 seconds. This is poor man's approach, but to make this cool feature work in time for yesterday's beerinar demo, I had to hack something quickly.
Needless to say, this can't stay that way.
Possible approaches
I looked at some frameworks, but haven't really figured out anything useful just yet.
If you have an idea about which push notifications framework I should use, do let me know.
These are requirements:

It must be absolutely free to use (or if it costs $, then it must be part of Azure stack and count towards Azure consumption)
It must work on nodejs client-side.

Any ideas?

I would give Azure Event Grid a try. Pricing seems low-cost for this purpose.
Disclaimer: I did not use it before, but this is what I'd use for myself. :-)

The problem is not pushing events from my Azure Functions back end - that's the easy part. The problem is consuming events from nodejs. There is nothing that Azure Event Grid can push events to that can be consumed with a ready-made nodejs client library, at least from what I could find so far.
But thanks for the hint, when I focus on this feature, I'll investigate deeper.

Perhaps Service Bus could work, that has a connection string that you can connect to from clients. Although, based on the examples, it's still like an endless loop to get updates, not specifically event-based. A tiny step away from a timer :D
https://docs.microsoft.com/en-us/azure/service-bus-messaging/service-bus-nodejs-how-to-use-queues

From the example it seems that this is actual tunnel/socket thing, not a polling thing. The example at that page gives 2s delay to stop processing just because it's a demo, but if I'd connect to the bus from a Disposable and then disconnect from its dispose it could easily work.
The only problem is that queue is first-come-first served. If I have fifteen clients to notify, only the first to fetch the message from the queue would actually get notified...
So... back to square one, really. I'll investigate deeper about Event Grid, there must be something I can use from there.

I am closing this. There won't be anything but polling for the foreseeable future. All other options are going to cost more as far as I can tell from checking the pricing options available. Also, third-party options are going to cost a lot more. Unfortunately, for a free service, I have to keep costs down. So that's it.
At some future point I may do a peer-to-peer notification system, that would make sense, even though it would require some local configuration.
So, for now, that's it. Case closed.


I tried to convert tf frozen model to ir, but it failed.

Platform (like ubuntu 16.04/win10):
docker image mmdnn/mmdnn:cpu.small
Python version:
python 3.5
Source framework with version (like Tensorflow 1.4.1 with GPU):
tf 1.7 with GPU optimized by tensorRT, not very sure the version of tf
Destination framework with version (like CNTK 2.3 with GPU):
I want to convert the frozen pb to ir first, then convert it to saved model for tensorflow serving
Pre-trained model path (webpath or webdisk path):
https://developer.download.nvidia.com/devblogs/tftrt_sample.tar.xz
Running scripts:
mmtoir -f tensorflow --frozen_pb resnetV150_TRTFP32.pb --inNodeName input --inputShape 224 224 3 --dstNodeName dstNode -o resnet150-ir

Traceback (most recent call last):
File "/usr/local/bin/mmtoir", line 11, in
sys.exit(_main())
File "/usr/local/lib/python3.5/dist-packages/mmdnn/conversion/_script/convertToIR.py", line 184, in _main
ret = _convert(args)
File "/usr/local/lib/python3.5/dist-packages/mmdnn/conversion/_script/convertToIR.py", line 48, in _convert
parser = TensorflowParser2(args.frozen_pb, args.inputShape, args.inNodeName, args.dstNodeName)
File "/usr/local/lib/python3.5/dist-packages/mmdnn/conversion/tensorflow/tensorflow_frozenparser.py", line 108, in init
placeholder_type_enum = dtypes.float32.as_datatype_enum)
File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/tools/strip_unused_lib.py", line 86, in strip_unused
output_node_names)
File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/graph_util_impl.py", line 174, in extract_sub_graph
_assert_nodes_are_present(name_to_node, dest_nodes)
File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/graph_util_impl.py", line 133, in _assert_nodes_are_present
assert d in name_to_node, "%s is not in graph" % d
AssertionError: dstNode is not in graph

Any ideas? Or does mmdnn support converting tensorRT optimized tf frozen model?
Thanks.

Hi @elvys-zhang ,as you can see from the traceback, "dstNode is not in graph" .Please check your dstNodename.

@namizzz Thanks for your reply.
I am a starter of tf. I tried the tools 'mmvismeta' to check dstNodeName, but another error occured

Traceback (most recent call last):
File "/usr/local/bin/mmvismeta", line 11, in
sys.exit(_main())
File "/usr/local/lib/python3.5/dist-packages/mmdnn/conversion/examples/tensorflow/vis_meta.py", line 36, in _main
visualize(sys.argv[1], sys.argv[2])
File "/usr/local/lib/python3.5/dist-packages/mmdnn/conversion/examples/tensorflow/vis_meta.py", line 9, in visualize
tf.train.import_meta_graph(model_filename)
File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/training/saver.py", line 1947, in import_meta_graph
meta_graph_def = meta_graph.read_meta_graph_file(meta_graph_or_file)
File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/meta_graph.py", line 643, in read_meta_graph_file
text_format.Merge(file_content.decode("utf-8"), meta_graph_def)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xff in position 191: invalid start byte

Could you please suggest some ways for me to check what the dstNodeName is? Thanks.

I have figured it out. But there was another error
Traceback (most recent call last):
  File "/usr/local/bin/mmtoir", line 11, in <module>
    sys.exit(_main())
  File "/usr/local/lib/python3.5/dist-packages/mmdnn/conversion/_script/convertToIR.py", line 184, in _main
    ret = _convert(args)
  File "/usr/local/lib/python3.5/dist-packages/mmdnn/conversion/_script/convertToIR.py", line 48, in _convert
    parser = TensorflowParser2(args.frozen_pb, args.inputShape, args.inNodeName, args.dstNodeName)
  File "/usr/local/lib/python3.5/dist-packages/mmdnn/conversion/tensorflow/tensorflow_frozenparser.py", line 122, in __init__
    tensorflow.import_graph_def(model, name='')
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/util/deprecation.py", line 432, in new_func
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/importer.py", line 489, in import_graph_def
    graph._c_graph, serialized, options)  # pylint: disable=protected-access
tensorflow.python.framework.errors_impl.NotFoundError: Op type not registered 'TRTEngineOp' in binary running on f9ccb16d346e. Make sure the Op and Kernel are registered in the binary running in this process.

Hi @elvys-zhang ,MMdnn don't support the tensorRT optimized model file now, thanks!

Hi @elvys-zhang ,I find this. Maybe you can add this line to load your model successfully. I tried in my machine. It works !
import tensorflow.contrib.tensorrt as trt

But in the tensorRT optimized model file(.pb). There is a TRTEngineOp including almost the whole graph, MMdnn can not handle it now. Thanks!
Name and type of all nodes

@namizzz Thanks for your reply.
It did work. So is there any plan to support converting TRT optimized model? Looking forward to it. Thank you.

@namizzz Thanks.
It seems that the newest tensorflow source has already supported converting saved model to TRT optimized saved model. I will try it.


Acceptance test for resource nsone_user

This is currently blocked since ns1 archives the users and doesn't release the login name once its deleted. Below is my ticket and response from nsone
Hi,

  While working on https://github.com/sarguru/terraform-provider-nsone , I noticed that once the user is  deleted via API the login name doesn't get released and I get an error 400 Bad Request: {"message":"request failed:Login Name is already in use."} . Is it intentional? It makes it really difficult to write Integration Tests.

   This is no where near an impacting issue but would definitely be a nice to have.  Thanks in advance.

The response was
Hello Sarguru,

We currently do not allow the reuse of usernames, as we archive them across several systems.  I will bring this up to our engineering team as a future suggested change to the platform.

Thank you,

cc-ing @beevek

Thanks @sarguru -- not a small change for us at this time due to some fundamentals of our backend, but we will track this and update when possible.  cc @weyrick

Thanks for quick response @beevek . Thats cool :)

Tracking this internally, will update this issue when we have progress.


Docker compatibility with OpenShift

This PR rebases the image to use the official OpenShift / CentOS Docker image. This enhances the compatibility with OpenShift and makes the service useable on OpenShift.
It leaves out the dynamic building with Travis. If this is still needed, we can add this again.

@marcbachmann are you ok with replacing our alpine images with centos? I don't like the idea very much to be honest. should we roll with separate images for our dev and appuio prod?

nobody here really has centos know how
the alpine image is 172 MB, the centos is 377.8 MB - might slow down our tests a bit

the reasoning behind it is...

also ich muss leider sagen: euer postgres container wird nicht auf openshift laufen. da passieren dinge im startup welche einfach nicht funktionieren: https://github.com/docker-library/postgres/blob/master/9.4/docker-entrypoint.sh#L30

chmod und gosu passen nicht in ein openshift environment. der einfachere weg wäre wirklich das offizielle image zu nehmen. sonst verbrate ich sicher 1-2 tage damit

A rebase to master will fix travis

If possible, I'd like to keep a separate centos image until we figure out what our strategy is

Deprecated


Cannot use periods in the title section(Left side)

For some reason, I cannot use a period in the left side, the logs states: "The variable play has to contain % at the beginning and one % on the end", but my text has no percent characters, only periods.  It is a tad annoying because I cannot put my server's IP into the scoreboard.  Any help or fix with this would be greatly appreciated.

The left side only contains text and the right side only numbers. So you can only specify the ip on the left side and then you have to put a constant number to the right side.


Reestablish dropped server connection

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
[x] I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferably).
[ ] I've written tests to cover the new code and functionality included in this PR.
[x] I've read, agree to, and signed the Contributor License Agreement (CLA).

PR Summary
It appears that after a number of hours of being connected, the server connection fails (self.server.websocket_safe_read()) with a ConnectionResetError: [Errno 104] Connection reset by peer.
This simple change catches this exception and triggers a self.server.rtm_connect(reconnect=True) to re-establish the connection and improve the client (bot) uptime.
Related Issues
Fixes #101 and #107
Test strategy
I have two slack bots that would lose connection every 3-6 hours and have to be restarted. After making this change (and a corresponding change in my bots to handle the reconnection properly) I have had 18 hour uptime on both of them.
Unfortunately I'm uncertain as to how to cover this change with unit tests.

Current coverage is 60.85% (diff: 7.69%)

Merging #145 into master will decrease coverage by 0.71%

@@             master       #145   diff @@
==========================================
  Files             8          8
  Lines           255        258     +3
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            157        157
- Misses           98        101     +3
  Partials          0          0

Powered by Codecov. Last update d753df3...e43c732

@daveanderson this looks really promising, thats for the contribution! i'll think a little bit about our testing strategy here and get back to you on that topic after the weekend ☀

As an update, I've been running this code solidly for the past week and have 100% uptime on two bots. Though this patch may not improve code coverage, I believe the improvement in reliability and uptime is very worthwhile.

I'd prefer just using https://pypi.python.org/pypi/tenacity and picking which exceptions you want to handle, the generic 'except:' picks up way more things than usually wanted, including KeyboardInterrupt  and SystemExit which shouldn't be caught like this...

Probably should read over https://docs.python.org/2/howto/doanddont.html#except also

I think the main issue here is that the library doesn't surface exceptions properly, preventing your application from properly handling the errors.
I'd like to keep the reconnect logic outside of the library itself, since there are different actions a developer might want to take depending on why the websocket has been disconnected. We're working on properly surfacing the exceptions and I'll be adding some error handling to the examples to show reconnect logic.

I agree with @Roach though I'm not quite sure if doing that is possible, this library has already established some of those guarantees 😞


Add support for BOSS I2S DAC V 1.2

Hey guys,
I really enjoy using balena-sound. I've got a DAC (BOSS I2S DAC V 1.2) which is not officially supported in your /docs/04-dacs.md. I have tried adding the custom configuration variable BALENA_HOST_CONFIG_dtoverlay with the value of allo-boss-dac-pcm512x-audio. No success so far. I have also modified the DT parameters as explained in your guide.
The snapcast-client throws tons of errors and i tried spotify connect, airplay and bluetooth playback. Non worked for me.
I previously used the DAC in combination with the OS Volumio which always worked fine with this DAC.

Hey @fa0lan, as per this guide, you are using the correct dtoverlay. My guess is that the DAC is working but those snapcast-client errors don't sound good. If you can share them we can figure out what is going on.

Closing due to inactivity. Please reopen if still having problems.


After setting "python.languageServer": "JediLSP", I get prompted to use Pylance

I switched from "Pylance" to "JediLSP" and got a prompt to switch back to Pylance. The prompt is shown by the Pylance extension:

cc @jakebailey

The Pylance extension always asks to be default because the user install flow we target is "people install Pylance directly"; this will go away in the future.


Rework Message Rendering

Message rendering works with html, it doesn't have to.
Use better rendering like here https://github.com/gempir/raftchat/blob/master/src/layout/Message.tsx

Done with frontend rewrite


[SPARK-36286][SQL] Block some invalid datetime string

What changes were proposed in this pull request?
In PR #32959, we found some weird datetime strings that can be parsed. (details)
This PR blocks the invalid datetime string.
Why are the changes needed?
bug fix
Does this PR introduce any user-facing change?
Yes, below strings will have different results when cast to datetime.
select cast('12::' as timestamp); -- Before: 2021-07-07 12:00:00, After: NULL
select cast('T' as timestamp); -- Before: 2021-07-07 00:00:00, After: NULL

How was this patch tested?
some new test cases

Test build #141540 has started for PR 33490 at commit 4a18456.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46058/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46058/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46058/

Test build #141540 has finished for PR 33490 at commit 4a18456.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141540/

Test build #141616 has started for PR 33490 at commit 389a610.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46133/

Test build #141630 has started for PR 33490 at commit 48e7357.

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46146/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46146/

Test build #141616 has finished for PR 33490 at commit 389a610.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141616/

cc @cloud-fan

Test build #141630 has finished for PR 33490 at commit 48e7357.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141630/

This is clearly a bug fix. These invalid strings are not documented as supported and it doesn't make sense to support them.
Thanks, merging to master/3.2!


[Event Request] Table Contact, Procedure CreateSalesQuoteFromContact

Hi,
we would like to request a event change or alternatively an additional event in the procedure CreateSalesQuoteFromContact.
The current code looks like this (17.1)

We want to use the existing event OnBeforeCreateSalesQuoteFromContact to transfer some additional information from the Contact to the Sales Header, so this event seems to be perfect.
A few lines later the line SalesHeader.Init(); clear all values that my the event subscriber had preset (except the primary key fields). In my Scenario, it is important to define the values before the SalesHeader is inserted. Therefore i can provide three solutions:

Suggestion
Delete the line "SalesHeader.Init(), because this line is not neccessary (SalesHeader is local)
Suggestion
Move the "SalesHeader.Init()" line before calling the existing event "OnBeforeCreateSalesQuoteFromContact(Rec, SalesHeader);"
Suggestion
New Event OnBeforeInsertSalesQuote(Rec, SalesHeader) - please define both paramter as  Var

I prefer the first suggestion.
Many thanks!

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


🐛 Remove double rendering of importer/exporters

Summary
Acceptance Criteria

Sidebar Importer & Exporter links show only once

Screenshots or Video
Testing Instructions

[ ] View dashboard
[ ] Verify that sidebar Importer & Exporter links show only once

Notes

QA Results: Pass ✅
Tested on: DEMO
There's no longer double rendering of importers/exporter links in the sidebar


New Ping Service

@iloire created a new ping service to allow for synthetic website monitoring.
https://www.npmjs.com/package/watchmen-ping-nightmare
It will allow to interact with a browser to login or get more data from a site

Thanks! I have updated the README https://github.com/iloire/watchmen/blob/master/README.md#ping-services


Handle possible IOError

See https://github.com/guard/guard/issues/833 for the actual bug

@e2 thanks for this.