Image_Picker doesn't function properly in One Plus 3 & 3T

Steps to Reproduce

It is related to the issue #85392. Since it is closed I am creating new ticket.
Even though we configured all the required permission properly, we get this error. Currently  we found this error in OnePlus 3 & 3T, It works perfectly in OnePlus 5T and emulators.
final _picker = ImagePicker();
XFile? pickedFile = await _picker.pickImage(
                  source: ImageSource.camera,
                  maxWidth: 400,
                );

XFile? pickedFile = await _picker.pickImage(
                  source: ImageSource.gallery,
                  maxWidth: 400,
                );

Expected results: It should Launch Camera or Gallery to pick Image (It doesn't work all the time)
Actual results:
[ERROR:flutter/lib/ui/ui_dart_state.cc(199)] Unhandled Exception: PlatformException(already_active, Image picker is already active, null, null)

Logs
W/Binder ( 4938): Caught a RuntimeException from the binder stub implementation.
W/Binder ( 4938): java.lang.SecurityException: Permission Denial: writing com.android.providers.media.MediaProvider uri content://media/external/file from pid=4938, uid=10075 requires android.permission.WRITE_EXTERNAL_STORAGE, or grantUriPermission()
W/Binder ( 4938): at android.os.Parcel.readException(Parcel.java:1943)
W/Binder ( 4938): at android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:183)
W/Binder ( 4938): at android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:135)
W/Binder ( 4938): at android.content.ContentProviderProxy.delete(ContentProviderNative.java:561)
W/Binder ( 4938): at android.content.ContentResolver.delete(ContentResolver.java:1749)
W/Binder ( 4938): at android.media.MediaScannerConnection$1.scanCompleted(MediaScannerConnection.java:68)
W/Binder ( 4938): at android.media.IMediaScannerListener$Stub.onTransact(IMediaScannerListener.java:60)
W/Binder ( 4938): at android.os.Binder.execTransact(Binder.java:692)

Hi @rmControls, could you please share the output of flutter doctor -v with the exact steps to reproduce the issue and also what version of the image_picker plugin are you using?

flutter doctor -v
[√] Flutter (Channel stable, 2.2.3, on Microsoft Windows [Version 10.0.19042.1110], locale en-US)
    • Flutter version 2.2.3 at G:\FlutterLab\flutter_sdk\flutter
    • Framework revision f4abaa0735 (5 weeks ago), 2021-07-01 12:46:11 -0700
    • Engine revision 241c87ad80
    • Dart version 2.13.4

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at D:\android\Sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_SDK_ROOT = D:\android\Sdk
    • Java binary at: D:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 4.1.0)
    • Android Studio at D:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[√] VS Code (version 1.57.1)
    • VS Code at C:\Users\abcde\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.23.0

[√] Connected device (2 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 92.0.4515.107
    • Edge (web)   • edge   • web-javascript • Microsoft Edge 92.0.902.62

Image Picker Version:
image_picker: ^0.8.2
Reproduce-able Code
As said this error occurs only in OnePlus 3 & 3t.
final _picker = ImagePicker();

XFile? pickedFile = await _picker.pickImage(
                  source: ImageSource.camera,
                  maxWidth: 400,
                );

XFile? pickedFile = await _picker.pickImage(
                  source: ImageSource.gallery,
                  maxWidth: 400,
                );

The issue is not reproducible on Android xiaomi k20 pro on the latest stable channel.
Could you please try switching to the master channel by running
flutter channel master
flutter upgrade
flutter clean

and see if it is reproducible there.
you can switch back to stable channel again by running flutter channel stable

code sample
import 'dart:io';
import 'package:flutter/material.dart';
import 'package:image_picker/image_picker.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
        color: Colors.white,
        title: 'Flutter Demo',
        theme: ThemeData(primarySwatch: Colors.blue),
        home: ImagePickerSample()
        );
  }
}
class ImagePickerSample extends StatefulWidget {
  ImagePickerSample({Key? key, this.title = 'Image Picker Sample'})
      : super(key: key);

  final String title;

  @override
  _ImagePickerSampleState createState() => _ImagePickerSampleState();
}

class _ImagePickerSampleState extends State<ImagePickerSample> {
  Widget imageBuilder(File file, int index) {
    if (file != null && file.path.isNotEmpty) {
      return Image.file(
        File(
          file.path,
        ),
        fit: BoxFit.cover,
      );
    } else {
      return imagePlaceHolder(index);
    }
  }

  Future<XFile?> pickImage(ImageSource source) async {
    try {
      final image = await _picker.pickImage(
        source: source,
      );
      return image;
    } catch (e, stackTrace) {
      return XFile('');
    }
  }

  Widget imagePlaceHolder(int index) {
    return Container(
      // padding: EdgeInsets.only(right),
      alignment: Alignment.center,
      decoration: BoxDecoration(
        border: Border(
            right: index % 2 == 0 ? BorderSide() : BorderSide.none,
            bottom: BorderSide()),
      ),
      child: Icon(Icons.add_a_photo),
    );
  }

  final _picker = ImagePicker();

  List<File> images = [];

  @override
  void initState() {
    // TODO: implement initState
    super.initState();
    List.generate(4, (x) => images.add(File('')));
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            Expanded(
              child: GridView.builder(
                itemCount: 4,
                gridDelegate: const SliverGridDelegateWithFixedCrossAxisCount(
                    crossAxisCount: 2),
                itemBuilder: (context, index) => GestureDetector(
                    onTap: () async {
                      final image = await pickImage(ImageSource.gallery);
                      setState(() {
                        images[index] = File(image!.path);
                      });
                    },
                    child: imageBuilder(images[index], index)),
              ),
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: () {},
        tooltip: 'Increment',
        child: Icon(Icons.add),
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 2.2.3, on macOS 11.4 20F71 darwin-arm, locale en-GB)
    • Flutter version 2.2.3 at /Users/mahesh/Documents/flutter
    • Framework revision f4abaa0735 (4 weeks ago), 2021-07-01 12:46:11 -0700
    • Engine revision 241c87ad80
    • Dart version 2.13.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] IntelliJ IDEA Community Edition (version 2021.1.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 57.0.5
    • Dart plugin version 211.7233

[✓] VS Code (version 1.58.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.24.0

[✓] Connected device (4 available)
    • Redmi K20 Pro (mobile)     • <IP_ADDRESS>:5555                     • android-arm64  • Android 11 (API 30)
    • iPhone 12 Pro Max (mobile) • 6A434744-B348-4FB3-AB10-131292174456 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-4 (simulator)
    • macOS (desktop)            • macos                                • darwin-arm64   • macOS 11.4 20F71 darwin-arm
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 92.0.4515.107

• No issues found!

Thanks


PBR: Fix refraction texture in right handed system

See https://forum.babylonjs.com/t/pbr-refractions-are-incorrect-when-userighthandedsystem-true/40496/2

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/13818/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13818/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13818/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/13818/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13818/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13818/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13818/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/13818/merge#BCU1XR#0

Doesn't seem to fix the NodeMaterial test Playground: https://playground.babylonjs.com/?snapshot=refs/pull/13818/merge#9AG9KN

And PBRMaterial still fails too if environment is rotated: https://playground.babylonjs.com/?snapshot=refs/pull/13818/merge#R7DGCN#1

And PBRMaterial still fails too if environment is rotated

The problem should now be solved, thanks for reporting it!

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13818/merge/testResults/webgl1/index.html
If tests were successful afterwards, this report might not be available anymore.

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13818/merge/testResults/webgl2/index.html
If tests were successful afterwards, this report might not be available anymore.


Inconsistent fonts

Hi!
The GoogleSignInButton specifies a Roboto font but the Facebook one defaults to application font style. I have a stylized font for my overall app but I'd like to have the auth buttons consistently Roboto.
I tried to overwrite the font family in the FacebookSignInButton by doing:
DefaultTextStyle(
  style: TextStyle(fontFamily: 'Roboto'),
  child: FacebookSignInButton(
    onPressed: () => handlePress(auth, auth.facebookSignIn),
  ),
);

But I still end up getting

The Facebook button defines a text style, which means your DefaultTextStyle is ignored.
I think the right approach here is another optional parameter, for all buttons, to allow callers to set a preferred text style.


[SPARK-31402][SQL][FOLLOWUP] Refine code comments in RebaseDateTime

What changes were proposed in this pull request?

Refine the code comments of days rebasing, to be consistent with the micros rebasing. i.e. one method is the actual implementation and the other variant is the optimized version.
Why are the changes needed?

improve code comments
Does this PR introduce any user-facing change?

No
How was this patch tested?

N/A

Test build #121183 has started for PR 28199 at commit bd34313.

cc @MaxGekk

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25870/
Test PASSed.

Merged build finished. Test PASSed.

Test build #121183 has finished for PR 28199 at commit bd34313.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121183/
Test FAILed.

retest this please

Test build #121208 has started for PR 28199 at commit bd34313.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25896/
Test PASSed.

Test build #121208 has finished for PR 28199 at commit bd34313.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121208/
Test FAILed.

retest this please

Test build #121254 has started for PR 28199 at commit bd34313.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25941/
Test PASSed.

@cloud-fan This is just changes in comments. It can be merged if the build succeed? I just want to avoid rebasing of my other PRs that might conflicts with this PR.

Test build #121254 has finished for PR 28199 at commit bd34313.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121254/
Test FAILed.

yea it's comment only, we don't need to wait for tests. merging to master/3.0!


Fix options on non existant tables, closes #442

LGTM :smiley:

Sorry I just merged hasql-19 and it makes this branch not merge cleanly. Can you rebase please?

I rebased this and merged manually. Thank you for the fix!

Sorry for not rebasing. I haven't had a lot of time to develop recently 😐

No problem at all, it went smoothly.


[HOLD for payment 2024-08-14] [HOLD for payment 2024-08-09] [CRITICAL] [Advanced Approval Workflows] Implement <WorkspaceWorkflowsApprovalsExpensesFromPage /> for Member Selection

Coming from: #wave-control: advanced approval + workflows polish
Issue OwnerCurrent Issue Owner: @blazejkustra

Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue!

@strepanier03 Could you please assist with paying @suneox for a C+ review of the PR?

@suneox, can you please link me to your Upwork profile? For some reason, I can't find you among our hires to send the contract.

Scratch that, you come up under a different last initial but I found you now, all good.

Offer sent, I'll check again in a couple hours to see if I can pay it.


Allow linking

@huisaddison This is the PR I mentioned. There are 10 changed files, but most are autogenerated by the build. I'll describe them below.

src/matrix_construction.cpp and src/matrix_multiplication.cpp. These are the actual changes I made. All functions in both of these files can now be called from another package via Linking To (details below).
.Rbuildignore, .gitignore, dspline.Rproj. I added the project file and the others were created when building. I don't think there's "anything to see here", unless you don't want these for some reason.
R/RcppExports.R, inst/* src/RcppExports.cpp. These are autogenerated by Rcpp::compileAttributes(). The new inst/* folder is what is needed to link to the C++  from another package (it gets copied into the package directory on install).

Using this branch, if I install dspline via say remotes::install_github("ryantibs/dspline"), then in my package, if I want access to the functions in 1 above, I would do the following:

In my package, add dspline in the DESCRIPTION under LinkingTo. Or usethis::use_package("dspline", "LinkingTo").
In whatever .cpp code I want, add// [[Rcpp::depends(dspline)]]
#include <dspline.h>

Now I can call, for example, dspline::rcpp_b_mat() directly.

If you'd rather avoid merging this (to skip the other annoying changes), you can just make the changes in 1 to any .cpp files that you want and rebuild as you usually would.

@dajmcdon @huisaddison Should I merge this one?

Unfortunately since #9 changes the return types for most of these functions, this PR will soon be out of date.  I can issue a new PR with the new types and new n_eval functions (unless @dajmcdon would prefer to do it)

I think it's better for @huisaddison to work it in to his #9. I'll close this.


Publish new article - "Document set for fast process legacy automation".

Please use this template to ensure easier processing of your pull request
Category

[ ] Content fix
[x] New article
[] Example checked item (delete this line)

For the above list, an empty checkbox is [ ] as in [SPACE]. A checked checkbox is [x] with no space between the brackets. Use the PREVIEW tab at the top right to preview the rendering before submitting your issue.
(DELETE THIS PARAGRAPH AFTER READING)

Related issues

fixes #issuenumber
partially #issuenumber
mentioned in #issuenumber

If this fixes (should close) or references an issue, please add the issue number here. When you type the hashtag symbol (#), a list of potential issues will pop up from which you can choose. This helps those maintaining the issue list as it will (1) link the PR to the issue & (2) automatically close the issue when this PR is merged in.
(DELETE THIS PARAGRAPH AFTER READING)

Contents of the Pull Request

Please describe the changes in this PR. Try to give enough details so the person reviewing it to merge it can make a good decision about your content.
(DELETE THIS PARAGRAPH AFTER READING)

Guidance

Please update this PR information accordingly. We'll use this as part of our release notes in monthly communications.
Please target your PR to master branch. Released documents are in live branch.
(DELETE THIS PARAGRAPH AFTER READING)

Docs Build status updates of commit a8c700e:
:warning: Validation status: warnings

File
Status
Preview URL
Details

Community/TOC.md
:warning:Warning
View
Details

Community/document-sets-are-magic.md
:white_check_mark:Succeeded
View

Community/index.yml
:white_check_mark:Succeeded
View

Community/microsoft365-maturity-model--intro.md
:white_check_mark:Succeeded
View

Community/microsoft365-maturity-model--management-of-content.md
:white_check_mark:Succeeded
View

Community/TOC.md

Line 39, Column 5: [Warning-file-not-found] Invalid file link: 'docuument-sets-are-magic.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


What's the correct type mapping for use with EFCore?

I'm able to get it working correctly with Dapper but so far, no luck with EFCore.
In OnModelCreating, I have the following conversion registered:
modelBuilder
    .Entity<CategoryEmbedding>()
    .Property(e => e.Embedding) // This property is a Vector
    .HasConversion(
        v => v.ToArray(),
        v => new(v));

// Elsewhere
[Column(TypeName = "vector(1536)")]
public Vector? Embedding { get; set; } = new(Array.Empty<float>());

In my migration:
migrationBuilder.Sql("CREATE EXTENSION vector");

migrationBuilder.AddColumn<float[]>(
    name: "embedding",
    table: "category_embeddings",
    type: "vector(1536)",
    nullable: true);

The default type it assigns is byte[] and I've manually changed it to float[].  Neither work correctly.
The error as reported by Postgres when using float[]:
ERROR:  column "embedding" is of type vector but expression is of type bytea at character 167
HINT:  You will need to rewrite or cast the expression.
STATEMENT:  INSERT INTO category_embeddings (id, active, category, created_by, created_utc, embedding, name, update_context, updated_by, updated_utc)
 	VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10)

The error as reported by Postgres when using string:
ERROR:  column "embedding" is of type vector but expression is of type character varying at character 167
HINT:  You will need to rewrite or cast the expression.
STATEMENT:  INSERT INTO category_embeddings (id, active, category, created_by, created_utc, embedding, name, update_context, updated_by, updated_utc)
 	VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10)

Any tips on getting the correct mapping with EFCore?

Current planned workaround is to use float[] and then add a trigger that converts it to vector in the DB.  Then on writes, use float[] via EF Core.  On reads, use Dapper and query on the vector column.

Hi @CharlieDigital, I spent some time on this, but think it might need its own plugin. I'd recommend using ExecuteSql for inserts for now.
var embedding = new Vector(new float[] { 1, 2, 3 });
ctx.Database.ExecuteSql($"INSERT INTO category_embeddings (embedding) VALUES ({embedding.ToString()}::vector)");

@ankane Thanks for going the extra mile; appreciate it.

No problem. Just added a Pgvector.EntityFrameworkCore package. It only supports the Vector type right now, but planning to add distance functions and index options at some point (#2).

I am using Pgvector.EntityFrameworkCore, but I am getting an error message: System.InvalidCastException: Can't cast database type .<unknown> to Vector.
I must configure the vector mapper at program startup using NpgsqlConnection.GlobalTypeMapper.UseVector().
I am aware that NpgsqlDbContextOptionsBuilder.UseVector() can also be used for configuration, but it does not seem to be working.
https://github.com/npgsql/efcore.pg/issues/2562#issuecomment-1339795868


Refactor(eos_designs): Write a generic method in shared_utils for duplicate detection

          So following discussion over chat here is the agreement to move forward:

The PR is merged as is and then two extra PRs should be opened:

to add negative tests for duplicate detection
to refactor all occurences of duplicate detection into a generic function in shared_utils and replace it

Originally posted by @gmuloc in https://github.com/aristanetworks/ansible-avd/issues/2627#issuecomment-1517459908
This requires #2748 to be merged first

@gmuloc can this be pushed to 4.1?

I think it can until we decide exactly the behavior we want - the tests (other issue) should be implemented though


Devs SBAT access historical gold/dollar exchange rate data

Expected Behavior
Developers can access cUSD/cGold exchange rate data from past dates, for example to create a gold screen in the wallet to show exchange rate trends.
Current Behavior
Developers can only access the current cUSD/cGold exchange rate by querying the exchange contract

Implementing the design doc from this investigate issue https://github.com/celo-org/celo-monorepo/issues/677


Insertion Sort using JAVA

Closing due to inactivity, feel free to reopen.
Add the file to a folder, and read our contributing guide.


Missing certificate secret link on ingress detail page

Setup

Rancher version: 2.6.5
Browser type & version: Chromium

Describe the bug
The ingress detail page is missing a link to the TLS certificate secret.
To Reproduce
Create an ingress with a tls configuration that points to an existing TLS secret for a certificate.
Then go to the ingress detail page.
Result
The certificate secret name is shown but not linked.
Expected Result
There is a link which points to the secret.
Screenshots

It looks like this missed QA due to no MS. Even though it merged in 2.6.7, have tagged with 2.7q3 to get some validation


Build in Keras3 Model will not build sub-layers

In Keras 2,  the keras.Model has implemented build methods that try to run the call() to build sub-layers https://github.com/keras-team/keras/blob/601488fd4c1468ae7872e132e0f1c9843df54182/keras/engine/training.py#L541-L552
However, such implementation is missing in keras 3

that is intended in keras 3, src.

that is intended in keras 3, src.

Can the same usage (e.g., manually build sublayers instead of calling super.build) be applied to Keras 2?

Yes, but not as much strict as of now.


DNN library is not found.

Detected at node 'sequential_4/sequential_1/model1/Conv1/Conv2D' defined at (most recent call last):
File "main.py", line 75, in
y_pred, score = prediction_func(img_crop)
File "main.py", line 30, in prediction_func
pred = predictor.predict(img)
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/utils/traceback_utils.py", line 65, in error_handler
return fn(*args, **kwargs)
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/engine/training.py", line 2382, in predict
tmp_batch_outputs = self.predict_function(iterator)
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/engine/training.py", line 2169, in predict_function
return step_function(self, iterator)
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/engine/training.py", line 2155, in step_function
outputs = model.distribute_strategy.run(run_step, args=(data,))
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/engine/training.py", line 2143, in run_step
outputs = model.predict_step(data)
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/engine/training.py", line 2111, in predict_step
return self(x, training=False)
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/utils/traceback_utils.py", line 65, in error_handler
return fn(*args, **kwargs)
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/engine/training.py", line 558, in call
return super().call(*args, **kwargs)
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/utils/traceback_utils.py", line 65, in error_handler
return fn(*args, **kwargs)
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/engine/base_layer.py", line 1145, in call
outputs = call_fn(inputs, *args, **kwargs)
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/utils/traceback_utils.py", line 96, in error_handler
return fn(*args, **kwargs)
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/engine/sequential.py", line 412, in call
return super().call(inputs, training=training, mask=mask)
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/engine/functional.py", line 512, in call
return self._run_internal_graph(inputs, training=training, mask=mask)
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/engine/functional.py", line 669, in _run_internal_graph
outputs = node.layer(*args, **kwargs)
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/utils/traceback_utils.py", line 65, in error_handler
return fn(*args, **kwargs)
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/engine/training.py", line 558, in call
return super().call(*args, **kwargs)
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/utils/traceback_utils.py", line 65, in error_handler
return fn(*args, **kwargs)
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/engine/base_layer.py", line 1145, in call
outputs = call_fn(inputs, *args, **kwargs)
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/utils/traceback_utils.py", line 96, in error_handler
return fn(*args, **kwargs)
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/engine/sequential.py", line 412, in call
return super().call(inputs, training=training, mask=mask)
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/engine/functional.py", line 512, in call
return self._run_internal_graph(inputs, training=training, mask=mask)
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/engine/functional.py", line 669, in _run_internal_graph
outputs = node.layer(*args, **kwargs)
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/utils/traceback_utils.py", line 65, in error_handler
return fn(*args, **kwargs)
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/engine/training.py", line 558, in call
return super().call(*args, **kwargs)
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/utils/traceback_utils.py", line 65, in error_handler
return fn(*args, **kwargs)
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/engine/base_layer.py", line 1145, in call
outputs = call_fn(inputs, *args, **kwargs)
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/utils/traceback_utils.py", line 96, in error_handler
return fn(*args, **kwargs)
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/engine/functional.py", line 512, in call
return self._run_internal_graph(inputs, training=training, mask=mask)
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/engine/functional.py", line 669, in _run_internal_graph
outputs = node.layer(*args, **kwargs)
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/utils/traceback_utils.py", line 65, in error_handler
return fn(*args, **kwargs)
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/engine/base_layer.py", line 1145, in call
outputs = call_fn(inputs, *args, **kwargs)
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/utils/traceback_utils.py", line 96, in error_handler
return fn(*args, **kwargs)
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/layers/convolutional/base_conv.py", line 290, in call
outputs = self.convolution_op(inputs, self.kernel)
File "/home/creapple/anaconda3/envs/seatbelt_detection_py/lib/python3.8/site-packages/keras/layers/convolutional/base_conv.py", line 262, in convolution_op
return tf.nn.convolution(
Node: 'sequential_4/sequential_1/model1/Conv1/Conv2D'
DNN library is not found.
[[{{node sequential_4/sequential_1/model1/Conv1/Conv2D}}]] [Op:__inference_predict_function_6381]

Hello @Abhijeet241093, please check the README file for detailed instructions on how to setup and run this script.


Makefile.frag as a Makefile filename

This pull request adds Makefile.frag as a Makefile filename, as discussed in #2968.
There are around 3,800 Makefile.frag files on GitHub.

per https://github.com/github/linguist/pull/2973 it looks like this should already be  deployed to production...?
stats at https://github.com/krakjoe/bundle still point out that 36% is javascript.

@staabm - looks like there was a stale cache somewhere for the page. Things are looking better now:

@arfon confirmed, thx for the fast response!


CSO optional inputs

Allow users to mark inputs for custom objects as optional. See totally valid reason here.

Agreed! So... we'd go for the AppendMenuItems solution? That one should be pretty straightforward to implement.


Sandbox/jail build scripts

Build scripts has too much capabilities than it would actually need. As a security measure, it may be good to perform some kind of sandboxing for them.
Things we could be restricting:

Act as the nobody user, disallowing read of private files, or deletion of important files.
Disable networking (with some way to opt out).

Strategy we could take:

Just use some existing mechanism (changing user) to downgrade privileges. Is this possible?
LD_PRELOAD and hook libc, which is what Gentoo use. Possible to bypass. Availability on Windows: possible, but probably harder than Linux.
Full sandboxing with gVisor. Safe, but doesn't work for Windows indeed.

Unfortunately, dropping privileges tends to require starting as root.
However, things like seccomp might help, though they're Linux-only.

We could take the setuid-helper approach here, where we ship a small binary that sandboxes the main cargo binary. I believe this is what Google does to sandbox Chrome and Electron on Linux.

See also rust-lang/compiler-team#475
My ideal:

Allow opt-in full sandboxing of proc macros via wasm
Extend the system with capabilities requested via Cargo.toml for access to different system resources
Extend the system to build.rs

I see proc macros as the MVP for this because most can be "pure" (no external state or side effects) while build.rs inherently interacts with external state and has side effects.

One possible way to control the scope of scripts is to require that their system access go through compiler provided precompiled libraries. These libraries may then respect configuration files and so forth to allow, deny, and log their effects. Additionally, these libraries can provide a great API into the build process itself while also making scripts both more powerful and quick to compile.

My discussion for #13113 was redirected here. I just read https://github.com/rust-lang/compiler-team/issues/475. It sounds like the WASI team is going for a file/directory-based directories interface...

Extend the system with capabilities requested via Cargo.toml for access to different system resources

...so it sounds like adding a [resources] section similar to [dependencies] for non-.rs source file resources would be useful for providing this "allowed" list.

Just noticed rust-lang/rfcs#2794 which might be relevant

Also looking to compile prior art for permissions / capabilities

Deno CLI for the script being run

The more I think about this, I worry whether sandboxing will be the right approach.  It is the most complete but that will also add its own burdens, including build time as users won't be able to reuse builds between the host (build scripts) and target (runtime).
I find cackle's approach of ACLs interesting.  If we had a linter that could trace your theoretical call stacks, then you could get a report of all unsafe and FFI calls.  You can then build up abstractions for these a priori or ad-hoc (fs read, fs write, env read, spawning), -sys link name, crate name, etc) and approve them either in your own code or in your dependencies.
This would allow you to more easily audit any non-pure operation in your dependency tree that you would actually call.
Compared to sandboxing, the main downside is we can't enforce how APIs are called, like what paths are read or written.

including build time as users won't be able to reuse builds between the host (build scripts) and target (runtime).

This is exactly what I noticed during the experiment https://github.com/rust-lang/rust-project-goals/issues/108#issuecomment-2364752145! I found it pretty frustrating 😞.

Compared to sandboxing, the main downside is we can't enforce how APIs are called, like what paths are read or written.

It is indeed promising. And agree that guarding API calls at the per-crate level, which somehow hurts the usability of build scripts because it doesn't consider the purpose of an API call. Here are some tricky situations: controlling calls into a seemingly safe executable but with malicious arguments, or calling $CARGO metadata, where we may need to handle changes in the registry cache and rustup toolchain overrides.
Just a wild idea. We could probably provide an interactive approval session, allowing the user to run the build script first and pre-approve all API/syscall calls. Then, we could export the pre-approval list to a file for Cargo to read.
Anyhow, it comes down to what level of configurability we'd like to provide.

Just a wild idea. We could probably provide an interactive approval session, allowing the user to run the build script first and pre-approve all API/syscall calls. Then, we could export the pre-approval list to a file for Cargo to read.

While this would be approval-after-the-fact, this isn't far from cargo fix support for this being a lint.


parsing with de locale gives wrong isValid result

Hi,
i found that parsing of none english values is not correct.
Parsing "Dec 02" will result in "December 02" in english, whats correkt. With "de" locale parsing "Dez 02" will result in "Februar 02" (maybe because it is currently february). Parsing the full month name results in booth languages in the correct result. "Dezember 02" will work in german and "December 02" will work in english.
Version: 2.24.0
Test 1
const value = moment.utc('Dez 02', 'MMMM DD', 'de');
const isValid = value.isValid();

value is now Februar 02
isValid is true
EXPECTED
value is Dezember 02
isValid is true
Test 2
const value = moment.utc('D 02', 'MMMM DD', 'de');
const isValid = value.isValid();

value is now Februar 02
isValid is true
EXPECTED
value is Invalid date
isValid is false

Last momentjs version which works as expected: 2.11.2 (since 2.13.0 got the error above, with 2.12.0 another error)

To the first test:
the locale mentioned uses Dez. with a period (.) at the end.
To the second test, try strict mode, and I get invalid date:
 moment.utc('D 02', 'MMMM DD', 'de', true);

Best of luck.


Any trained model for ID card shape detector?

Hi @davisking,
Thank you for the wonderful work.
I would like to know if any trained model for ID card shape detector available? Basically Model should identify Bank Card or National ID card etc or any Card shape. Please let me know if I want to train a new model how to do.
My apologies if it is a basic question.
Thanks in advance.

Not that I know of.

Noted. Thank you for quick reply @davisking.


Fix for xhtml parsing error where InjectionInputStream.read() method …

…reports one less byte than the actual payload size.

Makes sense.
int nbytes = super.read(b, off + n, len - n);
// Here we're only returning -1 on EOF (-1) if num characters already written to the buffer is 0
if (n == 0 && nbytes == -1) {
    return -1;
}
// But before this PR this if statement was missing, and so we were subtracting -1 incorrectly
if (nbytes > 0) {
    n += nbytes;
}


bevy_pbr2: Fix clustering for orthographic projections

Objective
PBR lighting was broken in the new renderer when using orthographic projections due to the way the depth slicing works for the clusters. Fix it.
Solution

The default orthographic projection near plane is 0.0. The perspective projection depth slicing does a division by the near plane which gives a floating point NaN and the clustering all breaks down.
Orthographic projections have a linear depth mapping, so it made intuitive sense to me to do depth slicing with a linear mapping too. The alternative I saw was to try to handle the near plane being at 0.0 and using the exponential depth slicing, but that felt like a hack that didn't make sense.
As such, I have added code that detects whether the projection is orthographic based on projection[3][3] == 1.0 and then implemented the orthographic mapping case throughout (when computing cluster AABBs, and when mapping a view space position (or light) to a cluster id in both the rust and shader code).

Screenshots
Before:

After:

Old renderer (slightly lighter due to slight difference in configured intensity):

Works in Sponza and looks appropriately funky 🙂 :
https://user-images.githubusercontent.com/302146/145849528-b14b86fb-217a-4cae-b7a4-1bac22a059a9.mp4

I forgot to pick in the debug visualisation improvements and comment fixes from one of my branches with bloom on top of clustered forward before making the PR for it. I used the third visualisation (cluster coherency) to check the clustering, and the z-slicing one as well to find and fix a bug. So I added those in here too.

Looks good to me. Thanks for the quick fix!

bors r+


Coming from oauth2 plugin now integrated in yt-dlp, but stopped to work

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm asking a question and not reporting a bug or requesting a feature
[X] I've looked through the README
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've searched known issues and the bugtracker for similar questions including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Please make sure the question is worded well enough to be understood
just updated to the new release, I was using before the yt-dlp-oauth2 plugin and everything worked well.
so according to the author I removed the python plugin as now it's integrated into yt-dlp and changed the login "oauth2" by "oauth" and followed the usual procedure google device etc...
but now all videos I wanty to download  are marked unavailable. did I miss anything? I don't think it's a bug, but surely something I missed to do or clean or else, reason why I open an issue "ask a question" first.
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[debug] Command-line config: ['-vU', 'https://youtu.be/WKOBs9eKJqc?si=p5OvRcOQabv8RIL4']
[debug] System config "/etc/yt-dlp.conf": ['--source-address', '2001:bc8:1203:362:6051:1b6c:606f:35ef', '-vU', '--geo-verification-proxy', 'rumble.com', '--proxy', 'node221.e-blokos.com:3128', '--no-cookies', '--cache-dir', '/home/PEERTUBE/.cache', '--username', 'PRIVATE', '--password', 'PRIVATE', '--force-ipv4']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp [67adeb7ba] (zip)
[debug] Python 3.12.7 (CPython x86_64 64bit) - Linux-6.11.6-x86_64-with-glibc2.39 (OpenSSL 3.2.2 4 Jun 2024, glibc 2.39)
[debug] exe versions: ffmpeg 6.1.2 (fdk,setts), ffprobe 6.1.2
[debug] Optional libraries: Cryptodome-3.21.0, brotli-1.1.0, certifi-2023.05.07, pyxattr-0.7.2, requests-2.32.3, sqlite3-3.45.1, urllib3-1.26.20, websockets-13.0
[debug] Proxy map: {'all': 'node221.e-blokos.com:3128'}
[debug] Request Handlers: urllib, requests, websockets
[debug] Plugin directories: ['/usr/local/lib64/python3.12/site-packages/yt_dlp_plugins', '/usr/local/lib/python3.12/site-packages/yt_dlp_plugins']
[debug] Loaded 1839 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
ERROR: Unable to obtain version info (HTTP Error 403: rate limit exceeded); Please try again later or visit  https://github.com/yt-dlp/yt-dlp/releases/latest
[debug] Loading youtube.oauth_refresh_token_default from cache
[youtube] oauth: Refreshing access token
[debug] [youtube] oauth: Logged in using profile "default"
[youtube] Extracting URL: https://youtu.be/WKOBs9eKJqc?si=p5OvRcOQabv8RIL4
[youtube] WKOBs9eKJqc: Downloading webpage
[youtube] WKOBs9eKJqc: Downloading ios player API JSON
[youtube] WKOBs9eKJqc: Downloading mweb player API JSON
ERROR: [youtube] WKOBs9eKJqc: Video unavailable. This content isn’t available.
  File "/usr/local/bin/yt-dlp/yt_dlp/extractor/common.py", line 741, in extract
    ie_result = self._real_extract(url)
                ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/bin/yt-dlp/yt_dlp/extractor/youtube.py", line 4671, in _real_extract
    self.raise_no_formats(reason, expected=True)
  File "/usr/local/bin/yt-dlp/yt_dlp/extractor/common.py", line 1275, in raise_no_formats
    raise ExtractorError(msg, expected=expected, video_id=video_id)

Your account has been blocked. Closing as duplicate of #10085

ok thanks.. :-\

To clarify, your Youtube account is restricted. I didn't mean your GH account is blocked from the repo or anything. The restriction can last anywhere from 2 days to 2 months. You will only be able to watch videos with the account using certain official clients. Usually the android app will always work. Sometimes the webpage won't

ok it's more clear indeed. I just wonder on which criteria YT reich decides to restrict since the method used by oauth is the same as any TV or device... meaning that if a school with one account share videos on the same account can be at anytime be restricted... hilarious.... the end of YT is near...

It's not necessarily because oauth. It's because you probably extracted/downloaded too many videos and YouTube flagged that as automated activity, leading to an account ban. It appears to happen with cookies too at the same rate

@DTrombett I wonder how the differentiate download and play a movie if it's only by checking the browser consistency....

There are many ways to detect yt-dlp usage, but it's likely the inhuman rate of video consumption coupled with the lack of Botguard and Droidguard attestation that gets accounts flagged. You can read up about passing a PO token to yt-dlp when using your account with it; doing so may reduce the chances of your account being restricted like this. (AFAIK there's nothing that can be done while it's currently restricted)

the lack of Botguard/Droidguard
yeah it's mort this, as for now my activities are no more than 100 downloads / day.... po token seems more a trick than a solution like oauth, and I won't be surprised YT will fix it soon....

OAuth is not really a solution. though. Passing OAuth is not effectively different than passing cookies. They are just different ways of authenticating. What I'm saying is using a PO token with authentication might prevent your account from being restricted like this in the future.

ok I will see if it's restricting too long.. .thanks for help


Android WebView net::ERR_NAME_NOT_RESOLVED

Is this a bug report?
yes
Have you read the Contributing Guidelines?
yes
Environment
Environment:
OS: macOS High Sierra 10.13.2
Node: 8.7.0
Yarn: 1.3.2
npm: 5.2.0
Watchman: 4.9.0
Xcode: Xcode 9.1 Build version 9B55
Android Studio: 2.3 AI-162.4069837
Packages: (wanted => installed)
react: 16.2.0 => 16.2.0
react-native: 0.51.0 => 0.51.0
Target Platform: Android
Steps to Reproduce

Create a clean project with react-native init myProject
add a webview

<WebView
  source={{ uri: 'https://m.facebook.com' }} // or any other url
/>

Run on Android

Expected Behavior

Should render the website.
Actual Behavior
Shows blank screen and showing "Encountered an error loading page " in debug console.
The onNavigationStateChange method returns:
{
  canGoBack: false
  canGoForward: false
  code: -2
  description: "net::ERR_NAME_NOT_RESOLVED"
  loading: false
  target: 489
  title: ""
  url: "https://m.facebook.com/"
}

Tested on the emulator and on a real device.
(works fine on iOS)

Same here.

Any news on this? Am also seeing this problem and need a fix ASAP

I built my project in another computer and it works just fine. I still have this issue in my computer. It was working fine and one day ti started throwing this error. My android setup must be corrupted or something.

Faced this issue when my laptop was connected to wifi and was using Emulator. Check whether emulator can assess DNS server ( use chrome and open google.com, if it works then emulator has assess to DNS server).
Else check this


more crashes on a server

crash-reports_crash-2022-04-21_10.49.15-server.txt
crash-2022-04-21_10.45.14-server.txt

@netcore10 thanks for reporting again.
Are you able to test a pre-release build for me plase? I'm fairly certain I have both of the issues fixed, but I might have messed up jam names. Could you check that jam gets a name when it's created (i.e. something like Beef and Mutton Preserve)?
As mentioned before I don't have any infrastructure to test this on, unfortunately - my computer can't run a MC server and a client at the same time.
If you are able to test, this is the link to the download via GitHub actions
P.S, accidentally closed the issue because I wrote half fix #18 in my commit message 😆

sure i can give it a test

no crash, but no name - I am running a custom modpack though

hmm yeah I half expected that. let me figure something out and get back to you

Hey, i'm just happy people don't crash atleast. I appreciate you doing all this.

Issues are fine to fix when they're on mods that I enjoy working on, luckily jamtastic is one of them 😆

ahahaha i bet

The more complicated the mod, the harder it is to work on.

Hello again :)
This one uses a library to pull translations from the client
🤞

oop i may've been a dum and forgot to add it to my client xD

nope still crash
crash-2022-04-21_15.15.26-server.txt

Ok this one tries a completely different approach uses some custom networking packets

that one caused a crash loop on the server without triggering an error.

logs_latest.log

latest.log

Oh god I did it again

If this doesn't work I probably have to find a way to test locally on my computer :upside_down:

WE GOT THERE \o/

Ahahahahaha finally! Thank you so much for helping me test this out!

You're welcome, i'll let you know if i find any server side problems but i think we can call this successful.

V1.3.4 has the fix in it, it may take a while to show up on CurseForge since their weekend is Friday/Saturday


Ignoring .history direction for syntax check etc.

Plugin is working great, just curious if there is some way to "hide" the .history directory from linting tools (ESLint and PHP CS Fixer) All the files listed in screenshot below are files from .history directory (with the exception of one)

I don't know if these tools consider settings search.exclude
	"search.exclude": {
		"**/node_modules": true,
		"**/bower_components": true,
                 "**/.history": true
	},

or maybe files.exclude
  "files.exclude": {
    "**/.git": true,
    "**/.svn": true,
    "**/.hg": true,
    "**/CVS": true,
    "**/.DS_Store": true,
    "**/.history": true
  },

@zabel-xyz Ahhh, I see what you are saying.  There is really no way for you to control their extensions :-)  But I do appreciate the feedback, I will track this down!


Unable to unzip a file from an archive within any iPad Air simulator

Zip archive is created (with password) with different archivers and with different content for test reasons, the result is the same and is always reproducible.
Everything is fine on all the simulators but iPad Air (no difference which iOS is setup). Device seems to work well too.
In method 'readDataWithBuffer:'  a line 'int err= unzReadCurrentFile(_unzFile...' always gets as a return value '-3', which is 'Z_DATA_ERROR' and 'msg' contains a string "invalid distance too far back".
Version: objective-zip 1.0.2 (installed as a Pod)
Xcode Version 7.0.1.

I have same issue on mac os project
on Mac OS 10.11

I also have this issue.  Xcode 7.2.1 fails with iPhone 5s simulator but works with iPhone 4s simulator.  Is there something different between each simulator?  I also installed 1.0.2 as a Pod.  I'm open to any suggestions for debugging this.

It seems to be a 32bit vs 64bit issue.  I have a zip file with just one file and a password.  It works on the simulators that I think are 32bit.  If I provide a zip file without a password, then it seems to work.

@gianlucabertani So is there at least any workaround? This thing really blocks app testing for any 64bit simulator

I'm afraid I don't have the time to investigate a problem with lower level libraries. What I can suggest is:

Some forks use the system's zlib as a static library dependency, instead of compiling the sources. Usually it is some versions behind (this is why I prefer the sources), but it may contain custom fixes. So, try forking and using the system's zlib, or look for a fork that already does.
If it still doesn't work, the ideal solution would be to contact the developer of MiniZip library (@nmoinvaz). He can surely be of more help than me.

It's been awhile since I looked at this.  I'm pretty sure that the problem is fixed in MiniZip.  You should be able to just pull the most recent version of MiniZip and the problem goes away.  It would be fairly easy to test.  I might have some time at the end of this week to look at it.

Don't know man, replacing its files with those from github.com/nmoinvaz/minizip spawns a total of 23 issues, including uninitialized variables, unsafe conversion and a possible null dereference. It looks like a big step back to me.

Ok, guys, thanks a lot. I'll take a look at this from MiniZip point of view.

The issue existed in the official builds of minizip for a long time. I had users contact me a while back and fixed it in my repository. Here is the direct issue:
https://github.com/nmoinvaz/minizip/issues/45
https://github.com/nmoinvaz/minizip/commit/58921f6b960975f0f5a19e990615c8cc6204e47a
If anybody is willing to submit the 23 issues as a pull request I will incorporate.
Thanks.

I played a bit with the latest 'minizip' version and managed to make my project work well on any simulator with it. All the issues I experienced were 'implicit type cast' warnings. I personally wouldn't consider them as the serious ones, because in most cases they just claim about 'long to integer' (and vice versa) casting loss for the cases, where integer is enough (e.g. hard drive order index). This could be fixed with a refactoring throughout the entire minizip project and a proper quality testing (to avoid type casts entirely); OR it could be done with just a bunch of explicit casts instead of implicit ones to silence the compiler. If the latter one is the case then I can prepare a proper PR. @nmoinvaz @gianlucabertani what do you think?

Ok, I'll do as soon as I can dedicate some time to the project.

MiniZip updated.

I've added a new section on README on adding files with encryption. If you're still having doubts, please have a look.

Great, no I can confirm it's working with any architecture (though at first I had some troubles with the case described in #61, thinking it was still it).


Get Some CI

...after we write some tests.

I mean, yes, in an ideal world.
But I'm probably not going to do either of those things.


version 0.4 + post/pre scripts

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


feat(zod): expose zod schemas for auth, clock, enums, and quote types

Breaking it up into multiple PR's since its a lot to review and I wanted to get feedback on general organization.
Documentation will follow in the final pr, but all schemas are exported as variables named <type_with_first_char_lowercase>Schema

Ah, I forgot about automatic publish. I think probably best to include all of them. I'll put in the rest


Crash:

What were you doing when the crash occured? How can we replicate it?
I opened a map in the paradise dimension, and upon selecting the map in the hotbar, the game crashed. When rejoining the server, it just keeps crashing
Did it crash the client or server?
Client
Mod Version
Beta 2.0.2
Fabric API Version
0.69.0
Crash Report
java.lang.NullPointerException: Cannot read field "field_16021" because "material" is null
	at net.id.paradiselost.util.ParadiseLostMapColorUtil.getColor(ParadiseLostMapColorUtil.java:9)
	at net.minecraft.class_330$class_331.handler$dek000$updateTexture(class_330.java:1549)
	at net.minecraft.class_330$class_331.method_1776(class_330.java)
	at net.minecraft.class_330$class_331.method_1777(class_330.java:103)
	at net.minecraft.class_330.method_1773(class_330.java:40)
	at net.minecraft.class_759.method_3223(class_759.java:272)
	at net.minecraft.class_759.method_3231(class_759.java:247)
	at net.minecraft.class_759.method_3228(class_759.java:452)
	at net.minecraft.class_759.method_22976(class_759.java:364)
	at net.minecraft.class_757.method_3172(class_757.java:752)
	at net.minecraft.class_757.method_3188(class_757.java:1065)
	at net.minecraft.class_757.method_3192(class_757.java:816)
	at net.minecraft.class_310.method_1523(class_310.java:1177)
	at net.minecraft.class_310.method_1514(class_310.java:768)
	at net.minecraft.client.main.Main.method_44604(Main.java:244)
	at net.minecraft.client.main.Main.main(Main.java:51)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:461)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

Other mods
No response
Additional Information
No response

Can you attempt this is Beta 2.1.0 and see if it still occurs? I'm unable to reproduce a crash.


No module named 'azure.identity'

Hello, I have encountered some problems as follows:
2023-09-03 16:54:59,323.323 49470:inference.py:140 test_git_inference_single_image(): loa
ding ckpt from output/GIT_BASE_COCO/snapshot/model.pt
2023-09-03 16:54:59,602.602 49470:common.py:233 limited_retry_agent(): fails with
No module named 'azure.identity': tried 1/10-th time
Traceback (most recent call last):
File "/shared/miniconda3/envs/wxp39/lib/python3.9/site-packages/azfuse/common.py", line
231, in limited_retry_agent
return func(*args, **kwargs)
File "/shared/miniconda3/envs/wxp39/lib/python3.9/site-packages/azfuse/cloud_storage.py
", line 1081, in is_folder_once
for x in self.list_blob_names(remote_path + '/'):
File "/shared/miniconda3/envs/wxp39/lib/python3.9/site-packages/azfuse/cloud_storage.py
", line 784, in list_blob_names
for info in self.iter_blob_info(prefix, creation_time_larger_than):
File "/shared/miniconda3/envs/wxp39/lib/python3.9/site-packages/azfuse/cloud_storage.py
", line 842, in iter_blob_info
for b in self.container_client.list_blobs(
File "/shared/miniconda3/envs/wxp39/lib/python3.9/site-packages/azfuse/cloud_storage.py
", line 781, in container_client
return self.block_blob_service.get_container_client(self.container_name)
File "/shared/miniconda3/envs/wxp39/lib/python3.9/site-packages/azfuse/cloud_storage.py
", line 765, in block_blob_service
from azure.identity import DefaultAzureCredential
ModuleNotFoundError: No module named 'azure.identity'
2023-09-03 16:55:01,519.519 49470:common.py:233 limited_retry_agent(): fails with
No module named 'azure.identity': tried 2/10-th time
...
Has anyone else experienced the same problem? Thanks!

pip install azure-identity

it was a change in azfuse. fixed the issue there. please re-install azfuse. thanks


feature: gpu add export keys

这个 PR 实现什么功能/修复什么问题:

gpu add export keys
cancel expire time on cancel pending delete

是否需要 backport 到之前的 release 分支:
release/2.12
/cc @swordqiu @ioito
/area region

Codecov Report

Merging #3666 into master will increase coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #3666      +/-   ##
=========================================
+ Coverage    6.94%   6.95%   +0.01%
=========================================
  Files         500     499       -1
  Lines       83931   83752     -179
=========================================
- Hits         5827    5825       -2
+ Misses      77609   77431     -178
- Partials      495     496       +1

Flag
Coverage Δ

#aFlag
6.95% <0%> (+0.01%)
:arrow_up:

Impacted Files
Coverage Δ

pkg/compute/models/guest_actions.go
0% <0%> (ø)
:arrow_up:

pkg/compute/models/isolated_devices.go
2.35% <0%> (-0.16%)
:arrow_down:

pkg/appsrv/response.go
66.15% <0%> (-3.08%)
:arrow_down:

pkg/compute/models/loadbalancerbackends.go
2.8% <0%> (ø)
:arrow_up:

pkg/util/influxdb/influxdb.go
0% <0%> (ø)
:arrow_up:

pkg/baremetal/tasks/bm_register.go
0% <0%> (ø)
:arrow_up:

pkg/compute/models/capabilities.go
0% <0%> (ø)
:arrow_up:

pkg/compute/models/loadbalancer_backendstatus.go

pkg/keystone/models/users.go
1.75% <0%> (ø)
:arrow_up:

pkg/baremetal/manager.go
0.52% <0%> (ø)
:arrow_up:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f29a1c...2eb4492. Read the comment docs.

/lgtm

/lgtm

/approve


Support Timeout only mode

The current system runs when failed or command is timed out.
I need to run only when timeout is occurred not on error.
Can this action have option like timeout_only?

There's PR about this. #15

Merged #17 which extends #15


[MM-36056] Add modes info

Summary

Based on https://github.com/mattermost/mattermost-plugin-apps/pull/191
Ticket Link
https://mattermost.atlassian.net/browse/MM-36056

Codecov Report

Merging #198 (5e517b0) into lev-onprem-aws (71a61bf) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           lev-onprem-aws     #198   +/-   ##
===============================================
  Coverage           24.15%   24.15%
===============================================
  Files                  33       33
  Lines                1569     1569
===============================================
  Hits                  379      379
  Misses               1157     1157
  Partials               33       33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71a61bf...5e517b0. Read the comment docs.


TURNS (TURN with TLS/DTLS) socket buffer operation error

TURNS doesn't work.
With
turn_uris: [ "turns:domain.tld:5349?transport=udp", "turns:domain.tld:5349?transport=tcp" ]
or
turn_uris: [ "turns:domain.tld:3478?transport=udp", "turns:domain.tld:3478?transport=tcp" ]
turnserver reports an error:  session closed ... reason: TLS/TCP socket buffer operation error (callback)
riot-web works fine, testssl.sh domain.tld:5349 and testssl.sh domain.tld:3478 also shows no errors.

I had the same problem,  “ turns ”

No problem here. But I am using my own TURN server.

You'd like to say you're using ssl'ed turn without any issues?

@root562 yeah, I am also using my own TURN server . When I use non-ssl mode ( turn:domain ), it can be used, but ssl mode( turns:yourdomain ) will report an error

No SSL on my TURN. My Turn server is only accessible by VPN.

No SSL on my TURN. My Turn server is only accessible by VPN.

So, what the reason to reply have no problem if you even don't use TURNS?

I am using TURN, but not SSL.

I'm also seeing this with coturn <IP_ADDRESS>-1ubuntu2.18.04. This is with riot 0.9.8 on Android 9.
I had no-tlsv1 and no-tlsv1_1 set in turnserver.conf but even after disabling those (thinking maybe the Android client only supports TLS 1.1) the issue remained. I'm using a very compatible cipher-list.
Can confirm it works flawlessly without TLS.

Exact same issue here: (D)TLS does not work, only unencrypted communication works.
I am running coturn <IP_ADDRESS> from Debian and riot-android 0.9.9 on Android 9
Any workaround ? Any news from the developpers ?

On riot-web I've got the same error but still, the voice is working ...

I can confirm the same issue on riot android when using coturn with SSL. Unencrypted works fine. Do we know if this is in anyone's radar to fix?

I had the same problem on a debian buster system … My advice: double check the certificates on the coturn server (are they really valid?) an the paths to the certificates specified in turnserver.conf, make them accessible by the user running coturn.

same problem here.
The android Riot app does not seem to be trusting the LetsEncrypt certificate.
It works fine through the Linux (riot-web) client.
Can any developer shed some light on which certificates store is used on the Android app to trigger the turns connection?

I've SSL cert from CA authority other than LetsEncrypt's and SSL and TURN server doesn't works properly with iOS and WEB Client. For workaround to work this i'm temporally disabled SSL with parameters at turnserver.conf:
no-sslv3
no-tlsv1
no-tlsv1_1
no-tlsv1_2
And works perfectly with audio and audio/video one-one via Riot client.

@djrzulf do you also get an Unknown CA TLS Alert in the packets dump? If so, which CA is your cert signed by?

Some problem here, using coturn with jitsi. Does it have something to do with the CA-file option?

same problem heare
origin <>, local <IP_ADDRESS>:4445, remote <IP_ADDRESS>:38116, reason: TLS/TCP socket buffer operation error (callback)
lifetime=0, cipher=TLS_AES_256_GCM_SHA384, method=UNKNOWN

Actually, a still open issue. Have the same problems with coturn & BBB on Debian Buster, TLS ON = error, OFF = working.
However, SSL/TLS ON => audio is working!?

I also have the problem, but it also doesn't work for me if I deactivate ssl/tls in my config. The it seems as the webclient connects succesfull, but the android app still fails.

Able to reproduce. works perfectly with turn:, not working with turns:.
Problem only visible in android and ios. works perfectly from mobile browsers(tested with firefox)

Very similar to https://github.com/jitsi/jitsi-meet/issues/6383#issuecomment-632659991


Hot Corners

Description of the new feature / enhancement
Customizable hot corners feature for Windows: you can enable and select an action every time you touch with your mouse any of the 4 screen corners. For example:

Top Left Corner: Action - Task View
Top Right Corner: Disabled
Bottom Left: Action - Show Start Menu
Bottom Right: Action - Show Desktop

Scenario when this would be used?
Easily switch actions just with the mouse, without pressing any key, for example, Win + Tab for Task View (Top Left corner), Win for Start Menu (Bottom Left Corner), and so on.
Supporting information
This feature is already supported by other OS such as MacOS and Linux Gnome. There are some third-party apps for Windows to allow this, but I don't trust them, would prefer an official Microsoft solution, and PowerToys is the perfect place for this.

/dup #1305


test(Subject): update test object assertion

Description:
This PR adds small update to test cases to be compatible with browsers.
Related issue (if exists):

Coverage remained the same at 96.347% when pulling 91ed0ba494c830464ec96e3bcee605c710420035 on kwonoj:test-sauce into f5f018054164e5c8944c7293f5fb4c651299dacc on ReactiveX:master.

Coverage remained the same at 96.347% when pulling 92ad8296e0281d67f364f1e1738185cf05bf5092 on kwonoj:test-sauce into f5f018054164e5c8944c7293f5fb4c651299dacc on ReactiveX:master.


File renaming is not handled

Lapce Version
lapce-0.2.5-1
System information
Manjaro Linux 22.0.0
Describe the bug
Filename in "Open Editors" and tabs does not changes when file was renamed
Additional information

Duplicate of #1559


IOU

hello, Where are the IOU indicators displayed for each category. thank

I only return the mIoU in the released code. To obtain per-class IoU, you should pass average=none to the helpers.metrics.IoU class, see https://lightning.ai/docs/torchmetrics/stable/classification/jaccard_index.html#torchmetrics.classification.MulticlassJaccardIndex
You will then have to slightly adapt how you log the metrics in
https://github.com/brdav/cma/blob/41838718481ec8db9c3c11acfe53f62a00630d24/models/model.py#L186
since the metrics will return an array of length n_classes instead of a single number.


Update how-to-authenticate-an-imap-pop-smtp-application-by-using-oaut…

The article is updated as per TASK 7969132, thank you!

Hi @lindalu-MSFT, could you please publish this? Thank you.

@Benny-54 Merged to production, just now. Should be live shortly! Thanks

@Benny-54 Merged to production, just now. Should be live shortly! Thanks

Thank you!


Bring Risk Calculation Documentation in line with current practice

There are a number of inconsistencies in https://github.com/corona-warn-app/cwa-documentation/blob/master/cwa-risk-assessment.md
I have made a couple of corrections, additions and edits that should be considered.
To make it easier to compare proposed change line by line I have created a PR #367 with the details.

Has been superseded by extensive update. Most issues seem to have been addressed in committ 0efba5e


"No module named mwclient"

Hey! Awesome plugin, but I can't seem to get it to work. No matter what I do, I get the error in the title.
Installed mwclient via pip, Vim is compiled with python,  installed vim-mediawiki-editor via vundle, got the error.
Thought it was maybe because mwclient was installed via sudo, uninstalled mwclient, uninstalled vim-mediawiki-editor; reinstalled mwclient for my user, reinstalled vim-mediawiki-editor, still getting the issue.
Any tips?

So it seems to be a Python 2.7 - 3.4 issue.  I copied the installed mwclient files (as well as 'six' and 'requests', two other dependencies) from /usr/lib/python3.4 to /usr/lib/python2.7.  That solved the "no module found" issue.... but now I'm getting an invalid JSON response when I try to connect to my personal wiki.  I think this is an issue with my wiki's config and how mwclient talks to it (all is gravy with en.wikipedia.org). I will check over at mwclient for proper config of my wiki.  Again, awesome plugin, thanks for everything :D

From https://github.com/mwclient/mwclient/issues/94 it seems like the problem was a wrong mediawiki path. In order to configure the path, I guess vim-mediawiki-editor needs a g:mediawiki_editor_path option.
(About the Python 3 issue: Python 3.x support has been added to the development version of mwclient and a stable release will hopefully be released soon)

The invalid JSON response issue is fixed by #3, I believe.


Delete comment button should not be next to edit

In the spirit of #410, we should move the delete comment button next to inline review comments away from the edit comment button. It's even worse with these small buttons which show up only on hover.

I don't see the issue, delete requires a confirmation

@bfred-it As does the cancel button we've moved before.

As does the cancel button we've moved before.

The confirmation on cancel is also added by Refined GitHub though.

I think this should be an exception as it would look ugly to move the x button and it has a confirmation anyway.


HTML code example for mapbox-gl

Hello,
could you kindly write a HTML example same as you did for bonn data for mapbox-gl?

@emakarov absolutely! In the mean time, you can see the mapbox-gl code we use for demo.tegola.io here

@ARolek thanks. looking forward to have a look at example

@emakarov Not sure if you're still looking for an example, but here you go.
`

@ojlamb thanks!
will definitely give it a try

@ojlamb I think it's not right,even add source "zones",it use mapbox official tile

@zhl11b I was able to get it to load as per the example once I added my Mapbox token, no problem here.


Layout modifiers application order

Many layout modifiers work as expected with each other only when applicated in certain order. Searching for that order can be difficult for many users, especially when they use many layout modifiers. I think there should be some documentation(or maybe other way) to prevent users from wrong application order.

https://github.com/xmonad/xmonad-extras/tree/master/XMonad/Config/Alt does that, but somebody would have to write functions like those in XMonad/Config/Alt/Desktop.hs to apply modifiers at the right precedence number.


8 10 1

@uzzelk changes requested. Drop me a message if doesn't make sense.

@MichaelGNairn I have made the minimum changes for now, but will look to make use of NOMIS APIs to improve this automation in the future (if the situation allows). Changes I have made are:
README

Removed duplicate line in banks by region download instructions.
Added instructions to download region to Las lookup file.
Point 2 – specified to open sdg_data_updates from Jemalex and not from local drive.

compile_tables.R

Added “lubridate” to line 7 under the list of packages to be installed.
Added library('lubridate') to list beneath.

update_8-10-1.R

I did not do anything to the ordering of the csv as “blank” (United Kingdom) is already first.
Added csv_output$Region[csv_output$Region == "East of England”] <- "East" to bottom of script.
I also did not change the region ordering. I also couldn't think of a simple way to do it... you put in your review that it is not a big issue so have left it for now. Could be something I look to do when improving the code in future.

8-10-1_checks.Rmd

Changed table to clickable table (thanks for the code for this - I actually tried it when initially doing the checks file but it wasn't working, as I didn't seem to have the DT package installed 🤭). I have added DT to list of packages in compile_tables.R and also added library(DT) to top of checks file script.

Looks great, well done Katie!
Only issue is I am still getting England first in the csv, instead of "blank" for United Kingdom.


Priority queue

Description 📜
In the folder "Data Structure" I can resolve an issue about Priority Queue by including some pictures.On the basis:-

Main queues  Operations
Priority Queue Representation
Fixes #1612

Type of change 📝

[x] Documentation (Content Creation in the form of codes or tutorials)

Domain of Contribution 📊

[x] C/CPP

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented on my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm a GWOC'21 contributor

Screenshots / Gif (Optional) 📸

/assign


[Microsoft.App] Add jijohn14 as owner

Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.

@MUHAMMAD IHSAN ALI.


Support variables pane for R (was: Code highlight for R kernel)

So I am currently using the latest version of Jupyter (v2021.2.0) on my laptop. I find it very cool that I can also use R kernels, even with IntelliSense! yet I might be missing something because I would like to see the variables that I have created and if possible code highlight. Here is a screenshot.

Thanks for the suggestion.
We'd likely need help from the R community to get code highlighting and the variable explorer to work.
The variable explorer uses a setting to determine how to query the R kernel for the value of a variable. Specifically this one:
 [
                            {
                                "language": "python",
                                "query": "_rwho_ls = %who_ls\\nprint(_rwho_ls)",
                                "parseExpr": "'(\\w+)'"
                            },
                            {
                                "language": "julia",
                                "query": "whos",
                                "parseExpr": "'(\\w+)'"
                            }
                        ]

If you added a setting for R, you might be able to figure out how get the kernel to return variable information. On top of that the R kernel has to support the jupyter 'introspection' message.
Syntax highlighting is more about VS code supporting R as a default language. In the VS code insiders build, I believe R highlighting should already work.

Thanks for your feedback. The code colorization issue will be addressed once VS Code adds native support for editing notebooks. Please see https://github.com/microsoft/vscode/issues/91987. You can experiment by using VS Code insiders, which defaults to the new notebook experience.
We're keeping this open to track the ability for R to display variables.

R kernel supports the jupyter 'introspection' message. #710
But what I set could use the variableQueries.
    {
      "language": "R",
      "query": "as.list(.GlobalEnv)",
      "parseExpr": "'(\\w+)'"
    }

    {
      "language": "R",
      "query": "_rwho_ls = %who_ls\\nprint(_rwho_ls)",
      "parseExpr": "'(\\w+)'"
    }

all of these can't work

Iteration-candidate because it was on Discussions.

Its been a while and there haven't been enough upvotes on this issue,
Hence closing this, if still required please feel free to ping here and we'll re-open this issue


Integration with the seaclouds-dc plus some syntactic fixes.

This PR carries the integration with the seaclouds-dc, that is monitoring rules for the metrics provided by the seaclouds-dc and the required node templates to be added to the DAM when the seaclouds-dc is required, are now automatically generated. Moreover some fixes, found during the last deployment tests, are applied. @PaoloCifariello can you have a look at this?

Current coverage is 37.33%

Merging #249 into master will increase coverage by +0.60% as of ab87f3b

@@            master    #249   diff @@
======================================
  Files          329     331     +2
  Stmts        12064   12156    +92
  Branches      1548    1553     +5
  Methods          0       0
======================================
+ Hit           4432    4538   +106
- Partial        449     451     +2
+ Missed        7183    7167    -16

Review entire Coverage Diff as of ab87f3b

Powered by Codecov. Updated on successful CI builds.

@PaoloCifariello I rebased and pushed the fixes. Thanks.

Thanks @MicheleGuerriero! It is ok to me, +1.


Define Development Workflow

What process should we use in how contributions are made?

My thought is:

Create an issue.
Tag an issue
Set the milestone


Fix normalization

OMG, very nice.
I wondered how I've gotten away with this. Turns out that I'm actually not calling this routine in the rest of the project. Nevertheless, still good to have for didactic purposes. Thanks for adding the test as well.


stable diffusion + gpt3 = schizo meme generator?

(poke @ChampPG)

might want to wait for #33 lmao

they kinda both have the same issue (no gpu)

Wait really stable uses gpu for me?

I mean as in "i have no gpu"


[beta] Panel should be updated when a view with lint errors has been closed

Title, basically. When a view with lint errors is closed, the panel should be updated and have the closed view removed.

@pykong sublime_linter.py line 156: on_pre_close_async should be on_pre_close, the contents of that method should be fixed and a panel update should be added.

Fixed by 157b36fa4747a088c270df2bf6b45eaca3a51779


Adds support for Mac OS

I saw this comment on tuntap.c, so does this crate support MacOS?

I don't have any MacOS myself, so I can't make any promises. But AFAIK it should. Feel free to try yourself.


[Request] Init command to prepare jar and dir structure

In some cases, it is great to have some sort of init command, which downloads, patches and installs the jar, prepares the directory structure and configuration files, but does not start the actual Minecraft server. That way it can be pre-configured, plugins installed first etc, e.g. for scripting the whole install and setup process, which is the aim our end.
Looks like here an additional option could be checked for, before running the patched jar: https://github.com/PaperMC/Paperclip/blob/master/java8/src/main/java/io/papermc/paperclip/Paperclip.java#L53
Best would be if even the Minecraft server's and plugins' own default configuration files could be pre-created, but I guess that would be much more complicated, including additional patches to the vanilla jar if those do not have such an option already.

Paperclip is a bootstrap tool, such a configuration option would need to start the server in order to run the relevant code to actually create the configuration files, any option for this would really need to be in the server itself, which, I can't see there being a huge demand for at all, too nuanced for such a marginal use-case

Paperclip is a bootstrap tool, such a configuration option would need to start the server in order to run the relevant code to actually create the configuration files, any option for this would really need to be in the server itself, which, I can't see there being a huge demand for at all, too nuanced for such a marginal use-case

Ah okay, I see now that I mixed up paperclip.properties with server.properties indeed, so I'll reopen on the server repo.

Ah okay, I see now that I mixed up paperclip.properties with server.properties indeed, so I'll reopen on the server repo.

for what you're wanting, especially if you want plugins configs to be created, you'd actually need to start all the plugins and everything, sounds like the best option would be to just have a shim plugin which stops the server after startup

for what you're wanting, especially if you want plugins configs to be created, you'd actually need to start all the plugins and everything, sounds like the best option would be to just have a shim plugin which stops the server after startup

I'm not sure how the main server init is structured, but there will be some init step where the plugins have been loaded, before the server binds to a port, the world and spawn areas are created etc, like between those two steps:
Jan 06 18:02:17 VM-Buster papermc[5382]: [18:02:17 INFO]: Generating keypair
Jan 06 18:02:18 VM-Buster papermc[5382]: [18:02:18 INFO]: Starting Minecraft server on *:25565

Not sure how to archive this best, making it part of the patches or as a plugin. But I'm currently opening a request at the Paper repo, where it indeed fits better.

I'm not sure how the main server init is structured, but there will be some init step where the plugins have been loaded, before the server binds to a port, the world and spawn areas are created etc, like between those two steps:
Jan 06 18:02:17 VM-Buster papermc[5382]: [18:02:17 INFO]: Generating keypair
Jan 06 18:02:18 VM-Buster papermc[5382]: [18:02:18 INFO]: Starting Minecraft server on *:25565

Not sure how to archive this best, making it part of the patches or as a plugin. But I'm currently opening a request at the Paper repo, where it indeed fits better.

loaded != enabled, plugins need to be enabled to create their configs, which requires going past the point of having loaded the worlds

loaded != enabled, plugins need to be enabled to create their configs, which requires going past the point of having loaded the worlds

Ah okay, I guess different aims of this could then conflict, e.g. if someone wants or needs to have the server binding to a different port initially, it needs to stop before this step, but then plugin configs do not exist yet. Okay I see that it is not that trivial, let's see if there is even any interest for such by others and their use case.

Ah okay, I guess different aims of this could then conflict, e.g. if someone wants or needs to have the server binding to a different port initially, it needs to stop before this step, but then plugin configs do not exist yet. Okay I see that it is not that trivial, let's see if there is even any interest for such by others and their use case.


Update click to 8

Warning: I don't know what I'm doing; I don't usually use Python and this is my first time with Watson's code, so this pull request should be treated with caution. But hopefully it can at least act as the start of a fix for use of click v8.
The cause of #430 seems to be this (click v8 changes):

TypeError is raised when parameter with multiple=True or nargs > 1 has non-iterable default. #1749

'Multiple options' at click documentation.
I remove multiple=True from several click options, which I don't believe are intended to be specified at the command line more than once as they seem to be flags rather than options which take (multiple) values.
I believe I've successfully run Watson's tests, which all seem to be passing.
By the way, will a new release of Watson be prepared soon, either with the temporary fix of specifying v7 of click or this fix? I ask as I'm currently working on my system config. :)

Wow this is huge. Thanks :pray: We'll look into this soon.

I'm not pro Python user and don't much about test suits, but my test with this pr on my local computer works find plus I did a simple pytest and there was 250 passed, 14 warning, 91 errors, you can see the result here.

@mizhozan, I also had those fixture-related failures. The solution seemed to be install the dev requirements from requirements-dev.txt. (See the varying mock versions depending on the version of setuptools you have.)

Thanks a lot, now the test runs perfectly with 341 passes and 14 warnings accordingly in my case.at
Is there anything hinder merging this PR to the main release? I like to have watson back (currently I've switched to timew, temporarily) and don't want to mess with the OS python site packages.

@mizhozan, I also had those fixture-related failures. The solution seemed to be install the dev requirements from requirements-dev.txt. (See the varying mock versions depending on the version of setuptools you have.)

@mizhozan Thanks. I think I managed to confuse myself regarding the versions of packages I had installed. I've just (re-?)re-installed click (8.0.1), and now I also have the deprection warnings.
@jmaupetit Can you hold off on merging, please? I'll see if I can get rid of the deprecation warnings.

The deprecations warnings are now gone (see last commit), but I'm out of my depth here and can't know whether or not more needs to be done to properly update to click 8.
From the changelog:

Redesign the shell completion system. #1484, #1622
Support Bash >= 4.4, Zsh, and Fish, with the ability for extensions to add support for other shells.

Allow commands, groups, parameters, and types to override their completions suggestions.

Groups complete the names commands were registered with, which can differ from the name they
were created with.

The autocompletion parameter for options and arguments is renamed to shell_complete. The
function must take ctx, param, incomplete, must do matching rather than return all values, and must
return a list of strings or a list of CompletionItem. The old name and behavior is deprecated and will be
removed in 8.1.

The env var values used to start completion have changed order. The shell now comes first, such
as {shell}_source rather than source_{shell}, and is always required.

I've searched for source_ in Watson's code and found source_zsh in create-completion-script.sh. I think this is where I bow out and leave things for others with more knowledge and understanding of Watson and Python. Thanks!

Ran into this issue today. Would love to see this merged in.

It's been almost a year, what's the status on this?

Rebased and merged in #471


MB-7950 add shipments to sc move details page

Description
Add shipments section to move details page. Within the section, added HHG shipment cards with the counselor remarks.
I also updated the tests for this page to use react-testing-library since we're moving to that I think.
Reviewer Notes
Styling is always an issue for me...Though I hope it's at least close.
Setup

Run server and client

make server_run

make office_client_run

Log in as a service counselor.
Open a move that hasn't been submitted to see its details.
You should see the shipments section with the cards. Each card should have an "Edit shipment" button. Submit the move.
You shouldn't be able to see the "Edit shipment" buttons anymore.

Code Review Verification Steps

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Screenshots
Editable

Not Editable

Messages

:book:
:link: MB-7950

  Generated by :no_entry_sign: dangerJS against b9101e6cc0ccfe9230b3221e50b77620e8ef144c

Looking really good! Just one nit-picky thought.
Noticed the margin below the shipment details card looks a bit large. Looking at the designs, I think we're going for a consistent 32px/4 units of spacing between the content and the bottom edge of those containers. This is not a deal breaker, but want to see if it's an easy fix.