Git LFS installs don't work on Ubuntu

An ubuntu user reported to me that installs from package cloud don't work on Ubuntu when installing through packagecloud:
curl -s https://packagecloud.io/install/repositories/github/git-lfs/script.deb.sh | sudo bash

It doesn't output any obvious errors, but doesn't actually install anything. Luckily, you can workaround it by downloading a specific deb and installing it with dpkg -i path/to/git-lfs.deb.
How can we get this to work for Ubuntu users?

Update our packagecloud distro map to upload the debs for ubuntu versions?
Provide the deb/rpm downloads on the latest release page so users with alternative OSs can get them?

/cc @andyneff

FWIW that curl command doesn't install git lfs itself, it installs sources so the package manager knows where to get it. You still have to apt-get install git-lfs, in this case. The packagecloud installation page isn't very clear about this.
IMO we should do both 1 and 2.

So is it possible that it works just fine on Ubuntu if they just run apt-get right after? If so, I think we could just skip step 1.

No, it doesn't work on ubuntu. We still need ubuntu packages on packagecloud for it to work. The script essentially just installs some packagecloud deps and writes a sources file, it doesn't check that any packages for that distro exist in the repo. The failure comes when you try to install them with the package manager.

@ssgelm just suggested adding packages for the supported ubuntu versions: precise, trusty, vivid, and wily.  I'll add those when I ship Git LFS v1.1.

We support all currently available distributions of Ubuntu in packagecloud.rb, so I believe that this issue can be safely closed.


add support for two modes local testnet

This PR adds logic for reading launcher modes from config

just finsihed up my changes, going to merge them into my fork and then work on merging your pr


Implement couch_log_devnull for suppressing logging during testing

COUCHDB-2899

Indeed, that's the easiest way to handle this, but I think it's not right one. In CouchDB 1.x we had special log level none which disables all the logging. And this one is correct: you shouldn't jungle backends to toggle logging activity - it's all the matter of logging level, where there is the highest one that suppress everything.
However, this will require more work to do and allow to configure couch_log via config. That's not bad, since that's need to do in anyway. Would you like to handle this?

I can certainly look into configuring couch_log via config, but right now my priority is re-enabling the test suite for downstream CI builds. This is just a quick-and-dirty hack that would make my life a little easier for the time being, but I can understand not wanting it in couchdb.

@jaydoane ok, so I just submitted https://github.com/apache/couchdb-couch-log/pull/10
To solve your problem there is nothing need to do since eunit.ini already contains magic option that turns off any logging so these calls will not reach the backend whatever it used.

@kxepal, excellent. Thank you! Looks like you'll need to add .travis.yml in your commit, though.

@jaydoane yea, I should add travis.yml everywhere. Thanks for reminder (:


Recommendations

Hi,
I was looking to do something similar to this project and this repository sent me in the right direction for some investigation on how to properly integrate bevy and wry. I've found a few caveats I believe you should be aware for if you ever feel like pursuing this project.:
1. winit transparency issue on Windows
Current releases of winit do not support WS_CLIPCHILDREN and therefore let wry transparency go through whatever is being rendered behind in the WebView. Control on this will be part of a future release of winit and will have to be supported by bevy_winit in order for bevy_wry to properly to work on Windows.
2. Use wry's IPC instead of WebSocket
wry offers a secure request/response based IPC channel (which is the communication method used by tauri) between the WebView's Javascript process and the Rust process. I believe this communication method should be leveraged instead of a custom websocket connection.
Cheers.

Hi!
Thank you for a great input. I was not aware of this IPC channel. l refactored this plugin so it uses IPC channel for incoming events and WebView::evaluate_script for outgoing events.
As for 1 - I will have to play with this plugin on Windows more.


Add  element

added, ready for review

And it's done! Now people can search for <div> and be impressed that we've covered it :D


Unable to condfigure CXF producer endpoints in Spring XML contexts

Consider a simple Camel XML route with a CXF producer endpoint.
<camelContext id="cxf-context">
    <route>
        <from uri="direct:start"/>
        <to uri="cxf://http://localhost:8080/example-camel-cxf-soap/greeting?serviceClass=org.wildfly.camel.examples.cxf.GreetingService" />
    </route>
</camelContext>

The result is missing dependencies related to Spring. These can be easily added to the CXF module dependency list. I also think the CXF module needs to export META-INF and META-INF/cxf so that we can support the various CXF namespaces.

Blocks the security aspect of #248 since the security namespaces are required for HTTP conduit config.


[DOC] document how this is different to sphinxcontrib-proof

@najuzilu beyond the obvious styling improvements would you be able to put a list together of the differences between this project and sphinxcontrib-prettyproof. It would be helpful in the docs when people are trying to decide which to use etc.
From memory you had lots of issues with sphinxcontrib-proof

Let me explain very briefly some of the reasoning behind the implementation and syntax.
During the first two iterations of this extension, I followed the instructions under Developing a “recipe” extension to create the different directives. The main reason I chose to use a domain is because I wanted the numbering of the directives to depend on the previous directive regardless of its name. If I had placed the directives under their respective domains, then the numbering would depend only on the previous directive of the same name (example: theorem 1, theorem 2, corollary 1, conjecture 1, conjecture 2, ...).
Unlike sphinxcontrib-proof, I wasn't using enumerable_node but was instead generating the number myself. I realized, after I had finished the first iteration that the numbering wasn't working as I had hoped. The order in which the documents are processed cannot be controlled/reordered according to the toctree because the reading phase is designed to run independently of other documents (in case it's invoked in parallel). So, I had to find a way through Sphinx to number each node which is where enumerable_node came in handy.
The syntax is similar to sphinxcontrib-proof primarily because both implementations use domains, but also because I wasn't sure what to call the domain so I ended up using the same name (hoping we'd change it to something more inclusive).
However, unlike sphinxcontrib-proof, this extension supports the following options for most directives:

label - allows users to reference the directive
sphinxcontrib-proof supports this through targets:.. _righttriangle:

.. proof:definition:: Right triangle

A *right triangle* is a triangle in which one angle is a right angle.

The equivalent in this extension would be:```{proof:definition} Right triangle
:label: righttriangle

A *right triangle* is a triangle in which one angle is a right angle.
```

I included these options keeping in mind that other directives such as math and figure use a similar approach; I was going for consistency.
proof:proof is the only directive which does not support a label option. I made this decision after realizing that proofs aren't generally referenced as much.
class - to allow users to customize directives
nonumber - to allow users to remove the number

The biggest headache I had with sphinxcontrib-proof was the actual referencing throughout the text. In order to reference a directive, you have to remember its target name and type (theorem, definition, corollary, etc.). Here's an example:
You can label and reference definition and theorems (e.g. :numref:`theorem {number} <pythagorean>`).
You can also reference proofs (see the :ref:`proof of the Pythagorean theorem <proof>`).

I found this to be too cumbersome (or maybe I'm just that lazy haha). I didn't want to have to remember the type in addition to the target. So, I decided that the labels will by default incorporate the type when referenced. This is what the equivalent of the references above would look like in this extension:
You can label and reference definition and theorems (e.g. :proof:ref:`pythagorean`).
You can also reference proofs (see the :proof:ref:`proof of the Pythagorean theorem <proof>`).

Thanks @najuzilu we should copy this to the docs :-).

Do we use any code from sphinxcontrib-proof?

Thanks @najuzilu we should copy this to the docs :-).

Working on it... :-)

Do we use any code from sphinxcontrib-proof?

We don't use any code from sphinxcontrib-proof.

Can I ask for one extra piece of information here? I think we should also document why this package is a different package from sphinxcontrib-proof, and not a set of improvements that we upstreamed to that package. In general we should try to upstream improvements to other tools as much as possible, and only build our own tools if there's an incompatible difference between what we're doing and what is out there. Did we make this assessment before creating prettyproof?


fix(region): azure win os defualt user

这个 PR 实现什么功能/修复什么问题:

[x] 功能、bugfix描述
[x] 冒烟测试
[ ] 单元测试编写

是否需要 backport 到之前的 release 分支:
None
/area region
/cc @zexi

Codecov Report

Merging #9134 (794e749) into master (5a5d5cc) will decrease coverage by 1.63%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #9134       +/-   ##
==========================================
- Coverage    5.84%   4.21%    -1.64%
==========================================
  Files         836     169      -667
  Lines      130002   25043   -104959
==========================================
- Hits         7602    1056     -6546
+ Misses     121719   23891    -97828
+ Partials      681      96      -585

Flag
Coverage Δ

aFlag
4.21% <ø> (-1.64%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/compute/models/elasticcache_secgroups.go

pkg/compute/models/cachedimages.go

pkg/multicloud/aws/loadbalancer.go

pkg/appsrv/stages.go

pkg/compute/models/routetables.go

pkg/monitor/models/commonalert.go

pkg/hostman/system_service/host_deployer.go

pkg/multicloud/ucloud/client.go

pkg/compute/models/loadbalancerbackends.go

...g/compute/models/loadbalanceropenstackcachedlbb.go

... and 656 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a5d5cc...794e749. Read the comment docs.

这个 fix 不 cherry pick 回去？


Linkifier doesn't work

We have an organization linkifier on https://coq.zulipchat.com/ with pattern Merge PR #(?P<id>[0-9]+): which stopped working around Nov 16 (same day as the zulip 7.5 release).
The other organization linkifiers such as with pattern coq#(?P<id>[0-9]+) continue to function AFAICT.

Zulip Server and web app version:

[x] Zulip Cloud (*.zulipchat.com)

Linkifier documentation, in case it's helpful: https://zulip.com/help/add-a-custom-linkifier
@PIG208 Do you know why that pattern would no longer work?

It appears that this issue generalizes to patterns that contain spaces.
For example, on Zulip we have the pattern Zulip code block that links to the documentation, but it doesn't correctly match messages that contain the pattern.

It's interesting that it flashes blue for a moment as though it's working before going back to normal text. We get the same effect.

Yes. I think that's because local echoing correctly links the text, while the backend renderer doesn't. It would be more obvious if the message is sent without internet connection.

I suspect a regression in 70b20e9d2bfe1bea3e083e00eae9d4eb8ab22d36; @alexmv FYI.


【bug】do_sample= False still get random output

Please provide more details about your case. Do you modify anything or directly run the inference.py?

Please provide more details about your case. Do you modify anything or directly run the inference.py?

yes,I just changed the loading of the visual model locally, my changes should not affect the randomness.

Can you provide thecode after modification?

#clip_model, processor = create_model_from_pretrained(self.vision_tower_name)
local_bin = self.vision_tower_name + "/open_clip_pytorch_model.bin"
clip_model, processor = create_model_from_pretrained("convnext_xxlarge",pretrained=local_bin)
just like this

I think the problem probably comes from this local loading. But without your exact code and weight, I can't not reproduce your problem.

I think the problem probably comes from this local loading. But without your exact code and weight, I can't not reproduce your problem.

how can i try webdemo of cam34b?

We will release the public demo very soon.

We will release the public demo very soon.

after some logging,i found same picture after CLIP-ConvNext get different embeding,this is why output get diff.Other vison model is ok ，What's so special about CLIP-ConvNext？

@penghao-wu Or about when will the demo be available online? I wanted to verify that the offline deployment was correct

open_clip model need clip_model.eval() after  create_model_from_pretrained()


Add ErrorContextBuilder

This class is a builder for ErrorContext instances.
This issue depends on completion of:

#36
#37

Can the entry point be something like ErrorContext.builder() which would be a a default method in the interface and would return an instance of ErrorContextBuilder?

e.g. in ErrorContext:
default ErrorContextBuilder builder() {
    return new ErrorContextBuilder();
}

Alternatively, we could create a method in ErrorContextBuilder that is not named builder (to avoid the rather awkward ErrorContextBuilder.builder()).
e.g. ErrorContextBuilder.newInstance()

Because there is builder in the name, use the newInstance() version


Add commit message release trigger

Description

This adds a trigger to the action to only run the action when a PR is merged to main AND the head commit message contains the text 'Update to version'.
It's janky, but it requires minimal intervention.
Related Issues

Checklist

[x] Is this code covered by new or existing unit tests or integration tests?
[x] Did you run make test successfully?
[x] Do new classes, functions, methods and parameters all have docstrings?
[x] Were existing docstrings updated, if necessary?
[x] Was external documentation updated, if necessary?

Additional Notes or Comments

Codecov Report
Patch coverage has no change and project coverage change: -0.01% :warning:

Comparison is base (e59ad44) 78.58% compared to head (7d4a16d) 78.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #884      +/-   ##
==========================================
- Coverage   78.58%   78.58%   -0.01%
==========================================
  Files          89       89
  Lines        5782     5775       -7
==========================================
- Hits         4544     4538       -6
+ Misses       1238     1237       -1

see 7 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Image block with lightbox

Hello Team,
I was looking if we can have a lightbox feature on the image block. Is there any plan of implementing that feature in upcoming versions of the core concrete5
Thank You! :)

It might be nice to also add the ability to specify a particular thumbnail type for the image as well... that way you could link to the full size image in the lightbox while embedding a particular thumbnail version of the image in the page.

I've written this up with some other additions on #9248  - let's track on its progress there.


Badges for License, PHP version and packages are wrong

Describe the bug
Badges for License, PHP version and packages are wrong. All of them link to the the badge image instead of something logical or no link at all.
To Reproduce

Click on the mentioned badges on https://github.com/JsonMapper/JsonMapper and see the badge image being opened in a new tab.

Expected behavior
The packages badge should open https://packagist.org/packages/json-mapper/json-mapper. The license badge should open https://choosealicense.com/licenses/mit/ and the PHP badge can be without a link.
Environment (please complete the following information):
N/A
Additional context
N/A

@DannyvdSluijs  Can you assign it to me?

@DannyvdSluijs , I have generated a PR for the above issue, can you check and let me know if its good?

I’m planning to give it a review this week.  I’ll make sure you are okay for Hacktoberfest.

Resolved with #51


Help

Hello Sir,
Thank you for making this nice control. But can you please tell me how can I get get delegates to be called inside my view control instead of View.swift?
Thanks

@Prarik
I'm not sure what you mean with View.swift, but to use the delegates you'll have to assign the closure to the delegates property of the textView:
class MyViewController: UIViewController {

    var textView: NextGrowingTextView?

    override func viewDidLoad() {

        super.viewDidLoad()

        //  self.textView = // ... create self.textView instance

        self.textView?.delegates.textViewDidEndEditing = { (textView) -> Void in
            // Do something
        }
    }

Ok got it. Thanks @JohnEstropia


Clarification in the docs on key codes

It would be nice to know exactly how glutin key codes map to native key codes. For example, are they mapping to physical keys, or are they dependent on the user's keyboard layout? Also, exposing a way to get the actual native key code would be handy for applications that must then pass on the native key code to another API (e.g. CEF). Otherwise the encoding implemented by glutin must be reversed by the application.

I did some experimentation using the keyboard configuration options that Windows 10 provides. When using the Japanese IME in non-romaji modes (e.g. hiragana), the Pressed events all have no VirtualKeyCode associated with them, but the Released events have the ones you'd expect. Windows also provides a Dvorak keyboard layout, and the VirtualKeyCode field of the events changes accordingly - so my guess is that the VirtualKeyCode field is dependent on the keyboard layout.
However, the second field of the KeyboardInput event is a scan code, which is always the same for each key, regardless of layout: when I press the D key, the VirtualKeyCode reported is D in the regular layout and E in the Dvorak layout, but the scan code is 32 in both cases. This might be the native key code you're looking for.
You may know all this already, because this is an old issue, but I figured I'd break down what I found for future readers.

Closing for https://github.com/tomaka/winit/issues/35


Reduce javascript components

Description
Refactors some custom elements from the extended partner pages from their implementation as Custom HTML Elements with Shadow DOM into Jekyll Liquid templates with global SCSS using BEM class name notation. Business logic that had been performed by JavaScript in the custom elements has been refactored into Liquid logic, or driven by changes to the structure of the Front Matter for the partner's to eliminate the need for any business logic in favor of minimizing any domain model logic in the view.
Check List

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

Hey @astephanus how are you testing for the social icons? I was trying to find a partner with them but couldn't find one.

@dtaivpp Yes. There are very few partners whom have provided social links. The list is as follows:

CERN
Searchuim AI
Sematext
Tracetest
Thankfully in double checking I did happen to notice that some styling that had been in the previous custom element shadow DOM implementation did not get coverted correctly for those icons. However, that did not affect whether or not they were displayed.

Ah thank you! Idk how I missed them. Will review and get back to you shortly!

@dtaivpp An easy way to check to see which partners have social links is to run this in the terminal from the project directory: grep social_links ./_partners/*.md. That will give you a list.

Okay looking this over and I am a little wary about the spacing of the icons. Despite them being evenly spaced and square they don't look it. Maybe is there a square set of icons we could use instead?


Trouble Loading Keychain Data Xcode 10.2 Swift 4

Hi Team,
I am having a trouble loading the keychain data. App crash when loadDataForUserAccount is called. Mac OS 10.14.4 and Xcode 10.2 Swift 4
I updated my Mac os to 10.14.4 and updated my Xcode to 10.2 & project swift version 4 to convert 5. After that when first time Xcode Run project login successfully after second time Xcode project Run app crash I tried to error "expression produced error: error: /var/folders/s1/: error: no type named 'ReadRequest' in module
Swift._DebuggerSupport.stringForPrintObject(Swift.UnsafePointer<project.ReadRequest>(bitPattern: 0x13e1e2890)!.pointee)".
Let me know if I'm doing anything wrong from my side. Is there any particular reason for that?
Error Function :-
public static func loadDataForUserAccount(userAccount: String, inService service: String = LocksmithDefaultService) -> [String: Any]? {
struct ReadRequest: GenericPasswordSecureStorable, ReadableSecureStorable {
let service: String
let account: String
}
    let request = ReadRequest(service: service, account: userAccount)
    **return request.readFromSecureStore()?.data**
}

Error Message :-
expression produced error: error: /var/folders/s1/: error: no type named 'ReadRequest' in module ''
Swift._DebuggerSupport.stringForPrintObject(Swift.UnsafePointer<projectName.ReadRequest>(bitPattern: 0x13e1e2890)!.pointee)
@matthewpalmer @victor @jonallured  @hermanolsson @jakemarsh @diejmon @marcelofabri @edwellbrook @larslockefeer

Hi all, I have the same issue, Xcode 10.2 and iOS simulator 12.2
Tried to erase all content and settings, haven;t helped

Getting same error as well. Definitely a problem when using this Pod on Xcode 10.2.

Still an issue

I had the same issue before and did the following steps:

Updated CocoaPods to 1.7.0 RC1
Followed again the setup steps for Keychain Sharing:

Choose your target project
Select Capabilities
Enable Keychain Sharing

It solved my case


I don't know what is it, but it can be important

Analyzer Feedback from IntelliJ
Version information

IDEA IU-192.6603.28
2.5.0
IU-192.6603.28, JRE 11.0.3+12-b304.56x64 JetBrains s.r.o, OS Windows 10(amd64) v10.0 , screens 1536x864

Exception
Dart analysis server, SDK version 2.5.0, server version 1.27.2, error: Captured exception
NoSuchMethodError: The getter 'iterator' was called on null.
Receiver: null
Tried calling: iterator
#0      Object.noSuchMethod (dart:core-patch/object_patch.dart:51:5)
#1      _protocolAvailableSuggestionSet (package:analysis_server/src/domains/completion/available_suggestions.dart:233:35)
#2      createCompletionAvailableSuggestionsNotification.<anonymous closure> (package:analysis_server/src/domains/completion/available_suggestions.dart:78:14)
#3      MappedListIterable.elementAt (dart:_internal/iterable.dart:415:29)
#4      ListIterable.toList (dart:_internal/iterable.dart:219:19)
#5      createCompletionAvailableSuggestionsNotification (package:analysis_server/src/domains/completion/available_suggestions.dart:79:8)
#6      CompletionDomainHandler.setSubscriptions.<anonymous closure> (package:analysis_server/src/domain_completion.dart:497:11)
#7      new DeclarationsTrackerData.<anonymous closure> (package:analysis_server/src/domains/completion/available_suggestions.dart:306:9)
#8      _rootRunUnary (dart:async/zone.dart:1132:38)
#9      _CustomZone.runUnary (dart:async/zone.dart:1029:19)
#10     _CustomZone.runUnaryGuarded (dart:async/zone.dart:931:7)
#11     _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:336:11)
#12     _DelayedData.perform (dart:async/stream_impl.dart:591:14)
#13     _StreamImplEvents.handleNext (dart:async/stream_impl.dart:707:11)
#14     _PendingEvents.schedule.<anonymous closure> (dart:async/stream_impl.dart:667:7)
#15     _rootRun (dart:async/zone.dart:1120:38)
#16     _CustomZone.run (dart:async/zone.dart:1021:19)
#17     _CustomZone.runGuarded (dart:async/zone.dart:923:7)
#18     _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:963:23)
#19     _rootRun (dart:async/zone.dart:1124:13)
#20     _CustomZone.run (dart:async/zone.dart:1021:19)
#21     _CustomZone.runGuarded (dart:async/zone.dart:923:7)
#22     _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:963:23)
#23     _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
#24     _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
#25     _Timer._runTimers (dart:isolate-patch/timer_impl.dart:391:30)
#26     _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:416:5)
#27     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:172:12)

For additional log information, please append the contents of
file://C:\Users\m1910307\AppData\Local\Temp\report.txt.

Thanks for reporting this issue! It looks like this was previously reported at https://github.com/dart-lang/sdk/issues/38014; please follow along there.

Duplicate of https://github.com/dart-lang/sdk/issues/38014


Use Model.findById() rather than get()

Calling this.get() from within remove() will not populate params.user object, and if you have a before get hook validating the presence of a user object (i.e. feathers-authentication.hooks.requireAuth) it will throw an error.
This is a bit of a weird situation because of some inconsistencies in the API. update() takes an id and Model.findById() is used so I guess the assumption is the author will validate access, permissions etc in a before update hook. patch() takes an id or params but ultimately does a find and passes the id in to the params.where object, if present.
This PR follows the update() method of retrieving a single instance for remove().

Thank you. You are right, that behaviour is indeed inconsistent. I also noticed that passing on to find will cause issues when pagination is enabled so I'll do another review before getting this change out in a patch release.

Thanks again. I made a 1.0.8 patch release with your fix and created a follow-up issue to review the consistency of that part of the API.


org.embulk.spi.Column#visit(): disuse "instanceof"

I feel that having public getTypeEnum method prevents us from adding complex types (such as array and map). I don't find benefits in contrast to its potential disadvantage.

I think  enum-switch is faster than if-instanceof in ColumnVisitor.

Sorry that this pull request has been left. Let us close this pull request.


Fix: Convert Menu class to a namespaced area

This PR cleans up the API to call the "Main Menu" for 2048.cpp.
One only just needs to add menu.hpp and to call Menu::startMenu().
For example:
#include "menu.hpp"
int main() {
  Menu::startMenu();
}

Functions needed for the 2048.cpp's Main Menu are contained within (menu.cpp's) own anonymous namespace.

The PR will be closed via "Squash and Merge". :card_file_box:
(Will be automatically merged in <24hrs from this message if no objections)

As there are no objections, will do squash and merge.

Hi @cawvyoct! Apologies for not replying earlier: was busy this whole week :sweat_smile:.
I looked over the code, and everything looks fine to me :+1:. Just one question: why is using an anonymous namespace a better choice here than a class?
Also, this might be pedantic, but I guess the correct word is "erroneous" as opposed to "errornous" here. :grimacing:

Also, this might be pedantic, but I guess the correct word is "erroneous" as opposed to "errornous" here. :grimacing:

Yes, you are right.
Thinking about it, "invalid" would be a better word (in my opinion) so it should be,  FlagInputInvalidChoice.

Just one question: why is using an anonymous namespace a better choice here than a class?

This is a great question! :+1: :smile_cat:
It is a little bit hard to answer in a condensed form so I apologise for the upcoming answer...
(Will this edit answer to add more clarity / edit mistakes if needed). :pen:

However, in a basic summary form,

A class is normally associated as some sort of "named datastructure".
This class did not hold any "datatypes" it wanted to encapusulate, so it would be better suited as a struct.
Even as a struct, there was no "datatypes" it wanted to combine / rename into a special "named datastructure".
The "functions" inside of this datastructure would be better suited outside of the struct as the named datastructure was acting more like an API to invoke "something".
Namespaces are better suited for this role.
Items in a header file (menu.hpp in this case) are normally intended to be imported (and possibly invoked) by other parts of a project's source code.
All the functions in the header file except one, startMenu(), are not invoked anywhere else outside of menu.cpp (its local translation unit)
The original intent of all functions except startMenu() was to be hidden in the private part of its class definition so privacy of the API was important.
"Private functions" like these should be defined in an unnamed (anonymous) namespace in its translation unit and not in the header file. This prevents "anyone" from allowing usage of the functions outside of its local translation unit.


Document wxCore library coverage (not test coverage, but binding coverage)

Subsequent action of #119

Will link to each class doc in docs.rs after first
publish


[New Port Request] minizip, maintained fork

Library name: minizip fork (?)
Library description: This is a fork of the minizip library that adds a slew of other features and is reasonably maintained, both in contrast to the original minizip that seems to be stable enough to just hang there.
Source repository URL: https://github.com/nmoinvaz/minizip.git
Project homepage (if different from the source repository): https://github.com/nmoinvaz/minizip/
Anything else that is useful to know when adding (such as optional features the library may have that should be included): The library has quite a few optional features, serving as frontend to various other compression algorithms (bzip2, zstd, libz) and cryptography libraries (ssl etc.); it seems reasonable that you would not always want to have all features, which may make this port a bit tricky.

Hi @ulfllorenz
Thanks for posting this request. We have a port named minzip in vcpkg now.
Could you please help confirm if this can meet your demands?
https://github.com/microsoft/vcpkg/tree/master/ports/minizip
Thanks.

Well, not quite. The minizip port in vcpkg is the original one from the zlib developers, which lacks quite a few features; as far as I can discern, it only allows interfacing with bzip2.

I have made a simple port for nmoinvaz/minizip privately because some package depends on the old minizip and some other depends on the fork. I named the port creatively to minizipfork because it doesn't really matter to us as the port is currently a private one :-)
I can share the private port if anyone wants to work with this, there's nothing secret in that. Probably the hardest part is to decide what to do with the name. Especially if one needs to have both installed at the same time.

I think if we can get the private port that would be at least a useful starting point that saves the odd hour of work.

Can be found from here https://github.com/oswjk/vcpkg-minizip-fork

It will probably take some time (days, single weeks) until we do this specific item, but thanks in any case.

@oswjk Thank you so much. I hope it get's pushed to vcpkg soon

@NancyLi1013 I am interested in creating a PR for this. Do you have any guidance on what the name of that port should be?

Put my vote in for "nmoinvaz-minizip"

@Chronial
I think you can make a PR for this now. For the port name, please use "nmoinvaz-minizip" proposed by @BillyONeal . Thanks for your contribution.

While looking at some more inspiration for the port implementation, I noticed that the name minizip2 seems to have established itself in other repositories (MinGW, MacPorts, Homebrew). This also seems to be supported by the maintainer, who added support for suffixes for distribution.
So unless you are committed to nmoinvaz-minizip, I would go with minizip2 for the sake of consistency.

@Chronial, thanks for the information!
I think it's fine to name it minizip2, even it may confuse with user, since we already have minizip port with different repo,
However, we may want it to be in consistency with other repositories (MinGW, MacPorts, Homebrew).
@BillyONeal, what do you think?


expm grad can fail on TF2 when eager execution is disabled

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): macOS 10.15.2
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): v2.1.0-rc2-17-ge5bf8de410 2.1.0
Python version: 3.7.3

Describe the current behavior
Evaluating the gradient of a tf.linalg.expm operation can fail with the following exception when eager execution is disabled:
Node 'gradients_1/matrix_exponential_1/while_grad/matrix_exponential_1/while_grad': Connecting to invalid output 6 of source node matrix_exponential_1/while which has 6 outputs.

Calling tf.compat.v1.experimental.output_all_intermediates(True) at the start of the session fixes the issue.
The issue only seems to happen if the gradient op gets added after the Session has already evaluated something.
Describe the expected behavior
No exception should be thrown.
Code to reproduce the issue
import tensorflow as tf
tf.compat.v1.disable_eager_execution()
session = tf.compat.v1.Session()
x = tf.constant([[1., 0.], [0., -1.]], dtype=tf.float32)
y = tf.linalg.expm(x)
session.run(y)
session.run(tf.gradients(y, x))

Also see gist here: https://colab.research.google.com/drive/1N5KeUBXJAmpict_lofiREHyE1QUcSDUl

Was able to reproduce the issue. Please find the Gist here. Thanks!

@charmasaur As mentioned in the error, if you make necessary changes this should work.
import tensorflow as tf
tf.compat.v1.disable_eager_execution()
tf.compat.v1.experimental.output_all_intermediates(True)
session = tf.compat.v1.Session()
x = tf.constant([[1., 0.], [0., -1.]], dtype=tf.float32)
y = tf.linalg.expm(x)
session.run(y)
session.run(tf.gradients(y, x))

Yup, that fixes the issue for me too.

Great. I am gonna close this issue then. To understand the cause of this error please read the following doc. Thanks.
If you have any more questions please post them on stack overflow. Thanks!

OK, but presumably the fact that tf.compat.v1.experimental.output_all_intermediates(True) is necessary means that there's still something to be fixed here. Surely using that function isn't the intended long-term solution for people who want to calculate gradients of expm?
https://www.tensorflow.org/api_docs/python/tf/compat/v1/experimental/output_all_intermediates also says that if we see this effect we should file an issue, which again suggests to me that there's some underlying issue to fix here.


Minor refactorings

Q
A

Bug Fix?
yes

New Feature?
no

BC Breaks?
yes

Deprecations?
no

Fixed Tickets

phpunit/phpunit 5.5.4 requires php ^5.6 || ^7.0 -> your PHP version (5.5.21) does not satisfy that requirement. FML 🙂 I will undo that commit and apply it after the v0.9 release.


Make usage of the new stop semantics to properly shutdown the plugin

Implements stop to return from run according to https://github.com/elastic/logstash/issues/3210
Depends on https://github.com/elastic/logstash-devutils/pull/32 and https://github.com/elastic/logstash/pull/3812
Fixes #10

The changes make sense but the tests don't pass for me:
~/p/logstash-input-drupal_dblog (purbon-feature/use_new_stop) $ bundle exec rspec spec
uri:classloader:/jruby/kernel/kernel.rb:28: warning: unsupported exec option: close_others
Using Accessor#strict_set for specs
Run options: exclude {:redis=>true, :socket=>true, :performance=>true, :couchdb=>true, :elasticsearch=>true, :elasticsearch_secure=>true, :export_cypher=>true, :integration=>true, :windows=>true}
F

Failures:

  1) LogStash::Inputs::DrupalDblog behaves like an interruptible input plugin #stop returns from run
     Failure/Error: expect(plugin_thread).to be_alive
       expected `#<Thread:0x48f5bde6 dead>.alive?` to return true, got false
     Shared Example Group: "an interruptible input plugin" called from ./spec/inputs/drupal_dblog_spec.rb:5
     # /Users/andrewvc/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-expectations-3.1.2/lib/rspec/expectations/fail_with.rb:30:in `fail_with'
     # /Users/andrewvc/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-expectations-3.1.2/lib/rspec/expectations/handler.rb:37:in `handle_failure'
     # /Users/andrewvc/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-expectations-3.1.2/lib/rspec/expectations/handler.rb:48:in `handle_matcher'
     # /Users/andrewvc/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-expectations-3.1.2/lib/rspec/expectations/expectation_target.rb:54:in `to'
     # /Users/andrewvc/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/logstash-devutils-0.0.16-java/lib/logstash/devutils/rspec/shared_examples.rb:14:in `block in (root)'
     # org/jruby/RubyBasicObject.java:1673:in `instance_exec'
     # /Users/andrewvc/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-core-3.1.7/lib/rspec/core/example.rb:152:in `block in run'
     # org/jruby/RubyProc.java:308:in `call'
     # /Users/andrewvc/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-core-3.1.7/lib/rspec/core/example.rb:222:in `call'
     # /Users/andrewvc/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-wait-0.0.7/lib/rspec/wait.rb:46:in `block in (root)'
     # org/jruby/RubyBasicObject.java:1673:in `instance_exec'
     # /Users/andrewvc/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-core-3.1.7/lib/rspec/core/example.rb:322:in `instance_exec'
     # /Users/andrewvc/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-core-3.1.7/lib/rspec/core/hooks.rb:380:in `execute_with'
     # /Users/andrewvc/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-core-3.1.7/lib/rspec/core/hooks.rb:446:in `block in run'
     # org/jruby/RubyProc.java:308:in `call'
     # /Users/andrewvc/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-core-3.1.7/lib/rspec/core/example.rb:222:in `call'
     # /Users/andrewvc/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-core-3.1.7/lib/rspec/core/hooks.rb:445:in `run'
     # /Users/andrewvc/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-core-3.1.7/lib/rspec/core/hooks.rb:500:in `run'
     # /Users/andrewvc/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-core-3.1.7/lib/rspec/core/example.rb:331:in `with_around_example_hooks'
     # /Users/andrewvc/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-core-3.1.7/lib/rspec/core/example.rb:149:in `run'
     # /Users/andrewvc/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-core-3.1.7/lib/rspec/core/example_group.rb:490:in `block in run_examples'
     # org/jruby/RubyArray.java:2300:in `map'
     # /Users/andrewvc/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-core-3.1.7/lib/rspec/core/example_group.rb:486:in `run_examples'
     # /Users/andrewvc/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-core-3.1.7/lib/rspec/core/example_group.rb:453:in `run'
     # /Users/andrewvc/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-core-3.1.7/lib/rspec/core/example_group.rb:454:in `block in run'
     # org/jruby/RubyArray.java:2300:in `map'
     # /Users/andrewvc/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-core-3.1.7/lib/rspec/core/example_group.rb:454:in `run'
     # /Users/andrewvc/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-core-3.1.7/lib/rspec/core/example_group.rb:454:in `block in run'
     # org/jruby/RubyArray.java:2300:in `map'
     # /Users/andrewvc/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-core-3.1.7/lib/rspec/core/example_group.rb:454:in `run'
     # /Users/andrewvc/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-core-3.1.7/lib/rspec/core/runner.rb:111:in `block in run_specs'
     # org/jruby/RubyArray.java:2300:in `map'
     # /Users/andrewvc/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-core-3.1.7/lib/rspec/core/runner.rb:111:in `block in run_specs'
     # /Users/andrewvc/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-core-3.1.7/lib/rspec/core/reporter.rb:53:in `report'
     # /Users/andrewvc/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-core-3.1.7/lib/rspec/core/runner.rb:107:in `run_specs'
     # /Users/andrewvc/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-core-3.1.7/lib/rspec/core/runner.rb:85:in `run'
     # /Users/andrewvc/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-core-3.1.7/lib/rspec/core/runner.rb:69:in `run'
     # /Users/andrewvc/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-core-3.1.7/lib/rspec/core/runner.rb:37:in `invoke'
     # /Users/andrewvc/.rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-core-3.1.7/exe/rspec:4:in `<top>'
     # org/jruby/RubyKernel.java:958:in `load'
     # /Users/andrewvc/.rbenv/versions/jruby-<IP_ADDRESS>/bin/rspec:23:in `<top>'
     #
     #   Showing full backtrace because every line was filtered out.
     #   See docs for RSpec::Configuration#backtrace_exclusion_patterns and
     #   RSpec::Configuration#backtrace_inclusion_patterns for more information.

@andrewvc I run the test again, but for me all is green. could you provide me with the seed used? probably this might help reproducing.
purbon-elastic% bundle exec rspec
Using Accessor#strict_set for specs
Run options: exclude {:redis=>true, :socket=>true, :performance=>true, :couchdb=>true, :elasticsearch=>true, :elasticsearch_secure=>true, :export_cypher=>true, :integration=>true, :windows=>true}
.

Finished in 1.13 seconds (files took 2.01 seconds to load)
1 example, 0 failures

Randomized with seed 26257

purbon-elastic% bundle exec rspec spec
Using Accessor#strict_set for specs
Run options: exclude {:redis=>true, :socket=>true, :performance=>true, :couchdb=>true, :elasticsearch=>true, :elasticsearch_secure=>true, :export_cypher=>true, :integration=>true, :windows=>true}
.

Finished in 1.09 seconds (files took 1.6 seconds to load)
1 example, 0 failures

Randomized with seed 47667

have you tried running them again ? do they fail always?

@andrewvc why do you run then in jruby-<IP_ADDRESS> ? I run this test with the actual jruby used in core, .22, can you try with it?

@andrewvc are you sure you update your Gemfile to point to your logstash and ``devutils```? your error is most likely because of this.

LGTM! Just make sure you rebase to pull in @ph 's gemspec changes :)


Add e_os2.h before ssl.h in quic_tserver_test.c to fix c99 compiles.

This change ensures that struct timeval is present before ssl.h is included to ensure definition consistency.
Fixes: #22309

I maintained in #22178, I still think that a better fix is to include struct timeval (wherever it is) directly in ssl.h, but this fix does not do that. Such a fix would replace this and #22178.

Requiring an internal header file to be able to include ssl.h is a problem that needs to be fixed differently as this is not a solution that is available to the application users of ssl.h as internal header files are non-public. The solution has to be handled differently.
If you look at apps/include/apps.h there is a comment on requiring this for DTLS as well so it isn't QUIC specific as a problem.

Requiring an internal header file to be able to include ssl.h is a problem that needs to be fixed differently as this is not a solution that is available to the application users of ssl.h as internal header files are non-public. The solution has to be handled differently.
If you look at apps/include/apps.h there is a comment on requiring this for DTLS as well so it isn't QUIC specific as a problem.

I agree that a more general solution is required - possibly adding #include <sys/time.h> to ssl.h as a general solution, but that was rejected on a prior PR. If other committers could chime in, I would be happy to reroll this accordingly.

It is a bit of a mess - in that on Win32 platforms we are using winsock.h or winsock2.h to get the definition and we aren't consistent in the source tree. There should be no usage of winsock.h anywhere - they should have all been converted over to winsock2.h.
The dance in crypto/bio/bio_sock.c can be reformed into the following (dropping the ancient TANDEM stuff and changing winsock.h to winsock2.h):
#if defined _WIN32
# include <winsock2.h>
#else
# include <unistd.h>
# if defined __VMS
#  include <sys/socket.h>
# elif defined _HPUX_SOURCE
#  include <sys/time.h>
# else
#  include <sys/select.h>
# endif
#endif

As we already depend on this pattern of includes to pull in struct timeval in the code that should be hopefully acceptable to others to include it where ever we have a dependency on having struct timeval defined (like in ssl.h)
It is close to what we do in include/e_os.h (it unconditionally pull in winsock2.h on windows platforms and sys/time.h on on-windows platforms, whereas the bio_sock.c has a NO_SOCK wrapper around it - which we need to omit in this context).

timeval is a BSD thing...  maybe that wasn't the smartest thing to use in public functions 😕

This pull request is ready to merge


📎 Add command biome migrate eslint

Description
We want to create a new command, biome migrate eslint, which will attempt to determine the rules configured in eslint and update the biome.json with rules that have a source in Biome.
Plus, it will attempt to read .eslintignore file and map the glob patterns in biome.json#linter.ignore
Limitations and expectations
Computing the rules that applied by eslint by reading the configuration file isn't an easy task, mainly because the majority of the projects out there use JavaScript to write their configuration file.

Computing the rules that applied by eslint by reading the configuration file isn't an easy task, mainly because the majority of the projects out there use JavaScript to write their configuration file.

We could invoke eslint with the --print-config CLI flag to obtain the final config.

I am starting the work to support the migration from the legacy eslint config.

Supporting flat configs (eslint.config.js) would also be much appreciated.

I think a feature like this will help a lot with getting more projects migrated to Biome.
Plus, I'd highly appreciate showing a list of rules which are not (yet) supported so you always know what you are missing. Moving to Formatter is one thing, but moving to another Linter which may not check important stuff for you is bad when you know about it the hard way.

@Conaclos how is this going? Is there a draft PR open where we can follow the progress? 😅❤

The implementation is now in a good shape. Any comments/reviews are welcome. #2103

We have released a Nightly that includes biome migrate eslint. Please let us know if you find any issue. We look forward to hearing about your experiences with this new feature!

This works great, although a simple eslint config generated a lot of biome rules with recommended set to false. I wonder whether there's an overlap between the generated and the recommended rules set and also whether the recommended rules could be better than the original eslint rules? Unfortunately, I couldn't find a recommended (default) rules file to compare this against, only the docs.

@umstek Yeah most of the rules are in the recommended set. It was simpler to disable recommended and migrate individually every rule. You can find the list of recommended rule here: https://biomejs.dev/linter/rules/#recommended-rules. There is an open discussion to provide a way of removing redundant configs: https://github.com/biomejs/biome/issues/2465

@Conaclos Thanks. So I did this, with that list of recommended rules extracted as recommended.txt.
import biome from './biome.json';

const recommended = (await Bun.file('./recommended.txt').text())
  .split('\n')
  .map((x: string) => x.trim())
  .filter(Boolean);

biome.linter.rules.recommended = true;

const groups = Object.keys(biome.linter.rules).filter(
  (x) => typeof biome.linter.rules[x] === 'object',
);

for (const rule of recommended) {
  for (const group of groups) {
    if (biome.linter.rules[group][rule]) {
      delete biome.linter.rules[group][rule];
    }
  }
}

Bun.write('biome.deduped.json', JSON.stringify(biome, null, 2));

Looks good enough.

@Conaclos Thanks. I wrote a script to do what I wanted.


fix(Card): fix image shorthand

Fixes #3542.
Updates generated markup by shorthand.
Before

After

Codecov Report

Merging #3551 into master will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3551      +/-   ##
==========================================
+ Coverage   99.74%   99.81%   +0.07%
==========================================
  Files         174      174
  Lines        2725     2725
==========================================
+ Hits         2718     2720       +2
+ Misses          7        5       -2

Impacted Files
Coverage Δ

src/views/Card/Card.js
100% <ø> (ø)
:arrow_up:

src/modules/Search/Search.js
99.46% <0%> (+1.06%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cee78a5...bb42533. Read the comment docs.


FeatureDataAdapter not persisting preferred index selection

We do have a preferred index selection...but it is only used for index writing.  Since there is a misalignment of the assumptions of the query strategies  (all indices in the same name space contain the adapter data) and the preferred index selection, this seems like a good time to consider making an adjustment here as well.  Allow the preferred index selection to filter the set of indices inspected during the strategies analysis.
In performing the analysis, it was noticed that the preferred index selection is not sufficiently persisted in the data store.

Further analysis reveals that all feature related adapters benefit from this approach.

Needs to applied to 0.9.1


capi/examples: make it build 'upload' too by default

'commit-message-check/gitcop' still claims the "topic" is longer than 72 characters but my count says 44...

No worries, I can adjust the commit message while squashing. The gitcop tool is a bit weak, I'm considering removing it :(


Dark Mode Switching Does Not Work On The Website

Bug
Dark/Light mode switching works fine on the desktop app but is not working on https://lbry.tv nor on the dev server.
To Reproduce
Steps to reproduce the behavior:

Go to https://lbry/tv
Click on Settings Icon > Dark/Light

Expected behavior
Dark mode switching should work.
Screenshots
Below is a GIF of the bug (On the local dev server)

Below is a GIF of the mode switching working on the dev server electron app, same version.

This error is shown in the console (on the dev server)

System Configuration

LBRY Daemon version: Is this applicable?
LBRY App version: I could only find the daemon version in the help page -> 0.68.0; package.json -> 0.45.0-rc.5
LBRY Installation ID: 692EAWhtoqDuAfQ6KHMXxFxt8tkhmt7sfprEMHWKjy5hf6PwZcHDV542VHqRnFnTCD
Operating system: Ubuntu 18.04
Browser: Firefox 75.0 (Felt this would be useful)

I am extremely sorry! It was totally my mistake. I had a dark mode extension working in the browser which made light mode look like dark mode. I am truly sorry.


Solder API-Endpoint refers to a wrong URL

Hello,
today I set up the TechnicSolder and linked it with TechnicPack.net. But the TechnicLauncher can't access to the Solder-API.

[B#353] net.technicpack.rest.RestfulAPIException: Error accessing URL [https://mirror.edgelessgaming.com/public/api/modpack/]
[B#353] 	at net.technicpack.rest.RestObject.getRestObject(RestObject.java:157)
[B#353] 	at net.technicpack.solder.http.HttpSolderApi.getMirrorUrl(HttpSolderApi.java:59)
[B#353] 	at net.technicpack.solder.cache.CachedSolderApi.getMirrorUrl(CachedSolderApi.java:134)
[B#353] 	at net.technicpack.platform.PlatformPackInfoRepository.getInfoFromPlatformInfo(PlatformPackInfoRepository.java:72)
[B#353] 	at net.technicpack.platform.PlatformPackInfoRepository.getPlatformPackInfo(PlatformPackInfoRepository.java:60)
[B#353] 	at net.technicpack.platform.PlatformPackInfoRepository.getCompletePackInfo(PlatformPackInfoRepository.java:51)
[B#353] 	at net.technicpack.launchercore.modpacks.PackLoadJob$6.run(PackLoadJob.java:190)
[B#353] 	at java.lang.Thread.run(Thread.java:745)

If I load the API-page in my brower, it refers to another URL ("mirror.edgelessgaming.com/api/modpack/" instead of "mirror.edgelessgaming.com/public/api/modpack/"). If I remove the last slash in the URL (mirror.edgelessgaming.com/public/api/modpack) it works fine.
Is this problem known and how to fix it?

My fault. Solder was not installed in the root directory of the Apache-Web-Server.


Competing consumer (server-persisted) subscription

Since the catchup subscription is not currently supported, I assume that competing consumer subscriptions are also not supported?

Feel free to submit a pull request that implements this functionality.


Use Envoy to route traffic to tinkerbell services

@abhinavmpandey08 Could you add some detail on the problem and why Envoy is preferable?


javascripting does not properly install due to a dependency on an unpublished package (leichtgewicht/msee)

npm install -g javascripting
...
npm ERR! 404 Not Found
npm ERR! 404
npm ERR! 404 'leichtgewicht/msee' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it
npm ERR! 404 It was specified as a dependency of 'workshopper-adventure'
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, or http url, or git url.

npm ERR! System Windows_NT 10.0.10565
npm ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\ProgramData\\chocolatey\\lib\\npm\\tools\\node_modules\\npm\\bin\\npm-cli.js" "install" "-g" "learnyounode"
npm ERR! cwd C:\Dev\Personal
npm ERR! node -v v4.2.2
npm ERR! npm -v 1.4.9
npm ERR! code E404
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     C:\Dev\Personal\npm-debug.log
npm ERR! not ok code 0

Sorry about that! This happened because @leichtgewicht/msee is a scoped package, and that functionality got added to npm at version 2.7.0.
You'll need to update npm to at least 2.7.0.
You can do that with this command:
npm install -g npm

Try that out and let me know how it goes.

That resolved it! Thanks :+1:


save-state command deprecated

When I run this action, I get the following warning:
The save-state command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Maybe #571 fixes this issue :)

Superseded by #618

@cristiangreco Maybe these changes should also be made:
https://github.com/actions/cache/pull/950/files


WIP: Dell XPS 15 9550

Here is a dump of everything I know about getting my laptop running. It's highly unstructured however---and I was the one who emailed the list warning against precisely this lack of structure. So in the interest of not being a hypocrite :), let me know the best we to organize this.
I imagine that the 13" variant Dell xps-13-9350 would most/share all of these settings, there is also a question of how that should be handled.

I don't think we should be too picky on structure for now, so long as we are making forward progress.
I would prefer that the kernel version not be pegged, we need some sort of versionAtLeast function.

Ok, I created a new module at lib/kernel-version.nix, it works like this:
{
  imports = [ ../lib/kernel-version.nix ];
  kernelAtleast =
    [ { version = "4.4"; msg = "Kernel does not support graphics hardware"; }
      { version = "4.5"; msg = "Kernel does not support audio hardware"; }
    ];
}

When the version at boot.kernelPackages is too low, a warning is printed during evaluation.
Could you use this for the trailing section of the module, or I am I missing something?

@ehmry That looks absolutely wonderful! I will gladly switch to using it.

@ehmry Ok this should be g2g! Used kernelAtLeast and moved comment to wiki file.


Adapt tests: image channel order enums don't depend on Kernel

Adapts to https://github.com/KhronosGroup/SPIRV-Headers/pull/413
Fixes: #5572

cc: @dj2

I think this is a dup of #5562. That PR also updated the channel data type tests which this PR did not.


How are static files used here?

I suggest you describe in the readme, how static files are used here so that users leveraging this repo are able to implement features with more ease. For example, creating an Open Graph Protocol Object.

Hello @alexeigud I hope you're doing well!
I wanted to keep this version of Simplefolio the more simple I can. If you want to add additional features that may add more static file types, I suggest you to fork my project and tweak it with your own version or sending me a Pull Request so I can review it.


dFdx and dFdy behave in reverse

Godot version
Godot 4.0 3d8c971ff8936a7c57bdae536d050207077a9427
System information
Windows 10 64 bits GLES3 GeForce GTX 1060 6GB/PCIe/SSE2
Issue description
I've been using the following piece of shader code to make smooth meshes non-smooth:
NORMAL = normalize(cross(dFdx(VERTEX), dFdy(VERTEX)));

However it appears Godot 4 behaves in reverse:

Steps to reproduce
Create a MeshInstance with a SphereMesh, add a DirectionalLight3D, then add a shader to the mesh with the following code:
shader_type spatial;

void fragment() {
	NORMAL = normalize(cross(dFdx(VERTEX), dFdy(VERTEX)));
}

Observe the shading of the sphere gets inverted.
Workaround: swap the code to cross(dFdy(VERTEX), dFdx(VERTEX)).
Minimal reproduction project
No response

This is pure conjecture on my part, I haven't properly researched this.
However dFdx and dFdy are fragment shader functions that work on the internal data as the GPU interpolates between the 3 vertices of a face. A good writeup of how this works internally can be found here: www.aclockworkberry.com/shader-derivative-functions/
Godot was originally an OpenGL engine and even in Godot 4 we've stuck to the coordinate system we've always used, a left handed Z- coordinate system.
Vulkan however assumes a right handed coordinate system. Once the projection matrix is applied we're basically in right handed coordinate system territory.
It is possible that the dFdx and dFdy return values based on this assumption and as a result the vector returned by dFdx specifically, will point in the opposite direction.
I do not know if there is a way to tell GSLang to compensate for this or if there is some other way to make sure the fragment shader knows we're using a left handed system. It would be a pretty breaking change if we need to switch over to a right handed system.

That's odd cuz when looking online I find examples of this still using the previous order https://github.com/KhronosGroup/glTF-Sample-Viewer/blob/33971b2f0a869bc93f6673feac388167e4fd520a/source/Renderer/shaders/material_info.glsl#L106
It's a breaking change that feels arbitrary, but it would be nice to know what is the right thing to do here, and should be documented if left as is. If what you say is true that also means projects using GLES3 and Vulkan as different export targets would have to duplicate their shaders just to flip this.

With https://github.com/godotengine/godot/pull/71919, you could use the shader preprocessor to generate different code depending on the current rendering method in use.

I would really prefer that these functions stay like how they are defined in GLSL. Do not artificially flip dFdy(), because then the user would find that dFdy(FRAGCOORD.y) == -1, which is preposterous.
https://registry.khronos.org/OpenGL-Refpages/gl4/html/dFdx.xhtml

these functions return the partial derivative of expression p with respect to the window x coordinate (for dFdx*) and y coordinate (for dFdy*)

We just need to document the coordinate system of each renderer. The reason dFdy() appears flipped is because fragment coordinates increase downward in Godot 4.0


Fail CI if any benches fail

To ensure that we know when it breaks

I tested this by manually adding exit 1 in the script. It failed as expected.
https://github.com/qdrant/vector-db-benchmark/actions/runs/10281339561/job/28450682228


Fix personalizations dynamic bug

Fixed two issues:

Bug with incorrect dropping of dynamicTemplateData from personalization data
Correct type for dynamicTemplateData

Hello @burantino,Thanks again for the PR! We want to show our appreciation by sending                                              you some swag. Could you please fill out                                              this form so we can send it to you? Thanks!                                             Team SendGrid DX


mypy compliance

Pull Request Checklist:

[x] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes #1719

[ ] Tests for the changes have been added (for bug fixes / features)

[ ] (If applicable) Documentation has been added / updated (for bug fixes / features)

[ ] CHANGES.rst has been updated (with summary of main changes)

[ ] Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

Addresses several issues (around 175/1250 errors) associated with (re-)casting of variables and output typing.

Does this PR introduce a breaking change?
Not really, but there may be breaking changes coming.
Other information:
@aulemahal
We currently use the Quantified type alias in almost all the threshold-based indicators to specify that this variable should conform to something resembling a string with units (str | pint.Quantity), but this alias also includes xarray.DataArray. Does this mean that we can pass (or would like to enable passing) DataArrays of grids denoting thresholds? If not, we may need to create a new, more constrained custom variable (str2pint often takes variables of this type but does not support pint.Quantity or xarray.DataArray). Solving this issue alone will address +250 errors.

There seems to be a handful of trip-falls that we keep running into:

Many of the decorators that we employ do not constrain the types of variables passed in/out of them; This makes it so that regardless of the typing identified by a decorated function, the end results will always return Any. This can be fixed by using -> TypeVar[...] signatures.
Mentioned above, Quantified is used too often in places where it doesn't actually work (some functions demand str-like variables, but claim to support Quantified, which includes DataArray). This could become a breaking change but would address many errors.

Changes as of this commit have us hovering at around 1050 errors total.

Additional comment:
Due to the way that numpy is typed, any time that we pass xarray.DataArray to a numpy.ufunc-like operation (e.g. np.logical_and(da1, da2)) we need to specify the that the output is still a xarray.DataArray (expected output is an ndarray otherwise).

This is just missing the updates to the changelog about breaking changes, but I think we're better off now. Lots of small improvements.


Ability to use task filter.

We need to add the ability to filter tasks according to different parameters for those cases when we really have many tasks and the search for a specific task becomes too complex.

Filtr by project and task type


Fish - Animation Sprite

When moving in the water area the fish looks like a fish swimming

when on a platform in the air area the fish looks like a fish flopping on the ground with small hops

when moving in the air area the fish looks like a fish flopping around


Replace IXML with SXML (for Cloud)

Big PR related to #632.

Classic abap2xlsx classes

Refer to ZCL/ZIF_EXCEL_XML... instead of CL/IF_IXML...
Use of data references with CREATE_OSTREAM_(X|C)STREAM methods

XML

ZCL/ZIF_EXCEL_XML(...) - Same (...) object type names as IXML classes and interface parts used by abap2xlsx (same method and parameter names, except it's a short list of what was used by abap2xlsx till now) - Parameter types refer to ZCL/ZIF_EXCEL_XML... instead of CL/IF_IXML... but run SXML. - implementations don't contain any reference to CL/IF_IXML...

contains many test classes to make sure that SXML and IXML results into identical XML

The tests run IXML only if ZCL_EXCEL_IXML exists (part of NOT_CLOUD package)

ZCL_EXCEL_XML_DOCUMENT

Same as CL_XML_DOCUMENT parts used by abap2xlsx

NOT_CLOUD

ZCL_EXCEL_IXML - contains references to CL/IF_IXML... (it's why it's in NOT_CLOUD)

used by ZCL_EXCEL_XML test classes to run abap2xlsx with IXML (if IXML is installed)

Potential issues:

Performance. Nothing optimized.
SXML is more strict than IXML and less permissive on positioning attributes, namespace declarations, etc.
OO design: Abuse of private instantiation/all friends.
Probably many I didn't see...

On 731:

Sorry, as Lars said, in the end IXML doesn't need to be replaced with SXML, it's only few classes CL_IXML to be replaced with CL_IXML_CORE, etc., all IF_IXML_* remain unchanged, so I remove my PR. It has to be recoded differently. Thanks for looking at it anyway! 👍

Sorry, as Lars said, in the end IXML doesn't need to be replaced with SXML, it's only few classes CL_IXML to be replaced with CL_IXML_CORE, etc., all IF_IXML_* remain unchanged, so I remove my PR. It has to be recoded differently. Thanks for looking at it anyway! 👍


ActionView::Template::Error: undefined method `generate_key'

For some reason I get this error when rendering a partial from the Rails console:
ActionView::Template::Error: undefined method `generate_key' for nil:NilClass
from ~/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/actionpack-4.2.5/lib/action_dispatch/middleware/cookies.rb:453:in `initialize'

Looks like it was a problem on my side. Works perfectly, thanks.

@assimovt What did you end up doing to fix this? I ran into the same issue.

@bjreath Oh, it was so long ago that I don't remember. We are on Rails 5 and no issues there.


How to train model with human3.6m datasets

Good job!
I want to train this model with human3.6m datasets, Could you please let me know how to go with it ?
Thanks!!

In our training, we use pseudo ground truth SMPL pose and shape parameters (generated by MoSh) to train on Human3.6M. Unfortunately, due to license agreement of the dataset, we are not allowed to distribute this data.


Quest Break oak_log and spruce_log not counting (or soup is counting only one)

*Detailed description of the issue:
Break oak_log and spruce_log not counting
in picture from player (is the 2 first objectives)
it same for Soup if player craft 10 for exemple is count only 1

#####################################
PASTE RELEVANT CONFIG SECTION HERE
#####################################
'14':
Name: Bûcheron - Impossible
Objectives:
- Break;oak_log;428
- Break;spruce_log;428
- Break;birch_log;428
- Break;acacia_log;256
- Break;dark_oak_log;256
RewardCommands:
- eco give [playerName] 1000
- msg [playerName] Quête terminée!

Jobs version:
Jobs<IP_ADDRESS>
Server Type (Spigot/Paper/etc):
Paper
Server Version (using /ver):
1.20.2-R-0.1

Craft is based mostly on what you have payments set too, if you are only paying for single craft event and not for crafted amount (PayForEachCraft option) then it would could as single craft for daily quest. For quest not filling up when you perform actions, this might require server/plugin full restart for it to properly update criteria for that quest.
Will add few small changes to more properly record quest changes in some instances.
ede3e4ede7a4b75f832aaf6f46c007cf730e551e


Can the front-end code be open source

Question
Can the front-end code be open source? we want to deploy the front be separate of the backend.
--I look forward to your reply

repeat commit

https://github.com/apache/shenyu-dashboard


Ballerina module compilation will run forever when same module is imported within the module

Description:
Ballerina module compilation will run forever without returning an error when the same module is imported within the module.

Apache Maven version - 3.5.3

Steps to reproduce:
Import own module in any .bal file of the same module. Build the module with $ mvn clean install. This will endup with compiling source forever.
Eg:

Import http module in any .bal of http module. import ballerina/http
Build http module with $ mvn clean install.
The compilation run forever after following output.

Compiling source
    ballerina/http

Affected Versions:
Ballerina 0.983.1-SNAPSHOT
OS, DB, other environment details and versions:
Ubuntu 16.04 LTS

This is a known issue: https://github.com/ballerina-platform/ballerina-lang/issues/4878, and don't think its a blocker.
Closing this one, increased the priority of the original one.


Website [Content models] Review of all tables

This ticket is to cover the work for a final review of all of the content model tables.

see Content guidance table updates.mdx #1415

New content model master spreadsheet...components are in alphabetical order on a single tab and have been aligned to match published content.
https://ibm.box.com/s/29jn0eq124wg5chjgjvsq6ktmsx9jt25


NSD stats contain the terms "master" and "slave"

Hi. I've just noticed that the stats output of nsd-control stats prints zone.master and zone.slave. Ideally, these should also be renamed to primary and secondary, but I can imagine that it would break scripts that parse the output.
Perhaps the stats could print zone.primary and zone.secondary in addition to the old names, so that scripts expecting the old names can continue to work.
I suggest the complete discontinuation of the master/slave terminology in a major update of NSD, such as version 5.

Thanks for the heads up. The fix committed changes that. It prints zone.primary and zone.secondary in addition to the old names. And documents that in the nsd-control man page. Also some other log outputs are updated and sample config and the contrib nsd munin script that uses the primary and secondary zone counts for display.


what does default data columns mean ?

hi, dude,
very thanks your wonderful tool, but i have some confusion about download data.
like this
2018-07-27 00:00:00.254000,1.16438,1.16436,1500000,2620000
2018-07-27 00:00:00.548000,1.16438,1.16434,7610000,1500000
2018-07-27 00:00:00.914000,1.16435,1.16432,1250000,3070000
what does each columns mean? is there no any document to describe this.
can you describe more information? columns mean and units mean
thanks

i found out very strange thing
url_info = {
'currency': symbol,
'year': day.year,
'month': day.month - 1,
'day': day.day
}
why real download file need minus -1 ,?

It means Open, Close, High, Low

I know this is closed but the answer in incorrect. Correct labels for the data frame are Ask_Price, Bid_Price, Ask_Volume, Buy_Volume


OpenVINO

Current state:

previous_state and loglikelihood_scaling parameters aren't supported for RIM OpenVINO model
FFT and IFFT OpenVINO layers aren't support normalized parameter

Performance
Torch time: 18.17 ms
OV time: 35.23 ms

Measured on Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz

Please make performance measurements to compare PyTorch versus OpenVINO. Do not forget to specify CPU.

Please try operator_export_type=torch.onnx.OperatorExportTypes.ONNX_FALLTHROUGH. It helped me locally to resolve ONNX export.


[7.x] Added appends($attributes) method to Eloquent collections

Much like the makeVisible($attributes) and makeHidden($attributes) methods, appends($attributes) allows the developer to utilize Laravel's accessors to append specific attributes across an entire eloquent collection.
$collection->append($attribute);

If you wan't to achieve something similar right now, you would have to do something like this:
$collection->each(function($model) {
    $model->append($attribute)
});

Otherwise your only option is to specify the attributes to be appended directly within the model, where it will be appended every time.
The downside here is that you'd have to remove/unset/hide the attribute whenever you don't need that specific one.
As an end user, this method allows me to more quickly choose when certain attributes should be appended.
The method has simply been added to the Collections.php class and should not cause any breaking changes.

@GrahamCampbell it should be fixed now, if not can you point me in the direction where I'm going wrong? :)

Won't that cause confusion with expected behavior (apppend being synonymous with push) ? Maybe eachAppend instead, like there is eachSpread ?


Fixes #251

add test

As this wasn't really related to #250 after all I looked at this as well while I was at it. As far as I can see, this is now the intended behaviour.
I added a test for oneof, assuming the other *of rules should work the same.  Otherwise I can add the others too.... it might be alot of duplicated code that might just result in harder to maintain tests (As a side note I saw #213 and pytest parametrized tests are great cutting down on that sort of stuff).

Merged after rebase: https://github.com/nicolaiarocci/cerberus/commit/78704de458d50db0f38fb614aef1eeb09c34f3de
Thanks!


AuthServiceProvider Policy Registration Include Array?

I was toying around with policies earlier today and I noticed, by default, policy registration is done on a model => policy basis.
I'm curious if it would be beneficial to allow for a model => [policy, ...] registration instead.
Example...
<?php

namespace App\Providers;

use App\Policies\RoundPolicy;
use App\Round;
use Gate;
use Illuminate\Foundation\Support\Providers\AuthServiceProvider as ServiceProvider;

class AuthServiceProvider extends ServiceProvider {

    /**
     * The policy mappings for the application
     *
     * @var array
     */
    protected $policies = [
        Round::class => [
            RoundPolicy::class,
            ...
            SuperSecretPolicy::class,
            HeroicPolicy::class,
        ],
    ];

    /**
     * Register any authentication / authorization services
     *
     * @return void
     */
    public function boot() {
        $this->registerPolicies();
    }

    /**
     * Register the application's policies.
     *
     * @return void
     */
    public function registerPolicies() {
        foreach ($this->policies as $key => $value) {
            if (is_array($value)) {
                foreach ($value as $item) {
                    Gate::policy($key, $item);
                }
            }
            else {
                Gate::policy($key, $value);
            }
        }
    }
}

Take note of the registerPolicies function which allows for the policy registration to be a single value or an array, functioning similar to the EventServiceProvider event/listener registration.
Let me know what you think!

Please use https://github.com/laravel/ideas/issues for proposals.

Heya, thanks for submitting this. This seems like a feature request or an improvement. It's best to post these at the laravel/ideas repository to get support for your idea. After that you may send a PR to the framework. Please only use this issue tracker to report bugs and issues with the framework.

@staudenmeir I don't have admin access myself to the repos so I can't use that atm.

@driesvints I see, I assumed this feature was also available to members.

Oh, I apologize. I should've read the instructions more closely. I'll make a feature request over there.


Copy

As with mv but just copy the file (class) and replace the class name and namespace with the new filename (classname)

Implemented as :class:copy


move frontend app into frontend folder

The diff is to re-org the folder. Product traffic is not affected. I tested the login and erc20 token sending, everything works fine.

looks like the ci is broken, will consult @zihaoccc  on this

let's just keep current folder structure


feat: paste format options

change paste format for selected history using ArrowLeft/ArrowRight keys
Closes: closes #5

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


https://developer.mozilla.org/en-US/docs/Learn/JavaScript/Objects/Basics

Request type

[x] Please close this issue, I accidentally submitted it without adding any details
[ ] New documentation
[ ] Correction or update

Details

See below. The  result become undefined since it return no value unless we type the below  on the console
var person = {}; person();
instead of the below.
var person = {};
Regards,
Alan Mehio

Please revisit all simmilar issue. The user does not see the result which is stated as below
[object Object]
but rather "undefined"
This has been tested on Chrome dev console.

Hi @alanmehio !
I'm not really sure I understand the problem here. Sre you talking about the instructions at the start of the https://developer.mozilla.org/en-US/docs/Learn/JavaScript/Objects/Basics#Object_basics section?
These seem correct to me.
In any JS console, if you type in
var person = {}
Followed by
person
you'll get a result along the lines of [object Object], Object { } or { }. I updated the section that tells you what the result should be, because since I wrote this, Chrome and Firefox both return different things to specify an object.
If you type in person() you'll get an error, because there is no top-level function called person defined on the page.

True
But I can’t see after defining this
var person = {};
person;
I see
var person = {};
Only
On Wed, 6 Mar 2019 at 17:59, Chris Mills<EMAIL_ADDRESS>wrote:

Closed #1142 https://github.com/mdn/sprints/issues/1142.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mdn/sprints/issues/1142#event-2184771725, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABb09TV-2DHvaaF7qIFu9UjOF2xC0lK_ks5vT_QEgaJpZM4bb8FC
.

Chris,
You are right but in the document is states the below
person = {};
If you enter person into your JS console and press the enter button, you
should get a result similar to one of the below lines:
I am saying   just add this   instead
person = {}; person;
I have not tested with FireFox  but on IE (internet explorer) 11.96  it
works  but it does not work on Chrome.  Again it may work on FireFox but I
have not tested it .
On Chrome,  when you define an object like person and press enter, it
display "undefined" while on IE it works as stated in the documentation.
Good to hear there is somebody who takes feedback. This encourage me and
others.
Regards,
Alan Mehio

Thanks @alanmehio , I think you've now helped me to understand what the confusion is here.
The instructions do state to enter both person = {} and person; it's just that you are supposed to enter the first one in the example code file, and the second on in the JavaScript console.
I have rewritten the instructions to make it clearer what you are being asked to do.
Is it better now?

Chris,
It is better now.  The problem is the issues between browser. I want you to
try it on Chrome and see if you get the same result as on the FireFox and
Internet Explorer.
The document is fine now.
I will try it on FireFox tonight and Chrome tonight and send you two images
to see the differences. I would like to recommend the MDN mention the
FireFox as the browser to test with.
In general the documentation has become much better on MDN.
Regards,
Alan
On Thu, 7 Mar 2019 at 10:18, Chris Mills<EMAIL_ADDRESS>wrote:

Thanks @alanmehio https://github.com/alanmehio , I think you've now
helped me to understand what the confusion is here.
The instructions do state to enter both person = {} and person; it's just
that you are supposed to enter the first one in the example code file, and
the second on in the JavaScript console.
I have rewritten the instructions to make it clearer what you are being
asked to do.
Is it better now?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mdn/sprints/issues/1142#issuecomment-470447669, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABb09YF_pXybB9PnLcrIY1uXF70D-GYoks5vUNltgaJpZM4bb8FC
.

Chris,
I am attaching the images as promised
Google Chrome is up to date
Version 72.0.3626.121 (Official Build) (64-bit)
FireFox QUANTUM
65.0.1 (64-bit)
IE 11.590
Testing on Window 10 64 bit
Strange the behavior of IE at work and at home is different
See the "undefined" once you  type "var person = {};" and press "enter"
// Alan
On Mon, 4 Mar 2019 at 14:20, Chris Mills<EMAIL_ADDRESS>wrote:

Hi @alanmehio https://github.com/alanmehio !
I'm not really sure I understand the problem here. Sre you talking about
the instructions at the start of the
https://developer.mozilla.org/en-US/docs/Learn/JavaScript/Objects/Basics#Object_basics
section?
These seem correct to me.
In any JS console, if you type in
var person = {}
Followed by
person
you'll get a result along the lines of [object Object], Object { } or { }.
I updated the section that tells you what the result should be, because
since I wrote this, Chrome and Firefox both return different things to
specify an object.
If you type in person() you'll get an error, because there is no
top-level function called person defined on the page.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mdn/sprints/issues/1142#issuecomment-469250545, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABb09cKiF5v8gCRELA-0acBufXO5I1Ahks5vTR22gaJpZM4bb8FC
.

Right. So this is standard behavior for DevTools, on Chrome/Firefox (I don't have IE handy to test on.) It doesn't mean that the value is not set, just that it is not returning anything. It just sits there and does nothing until you decide to do something with it.
It shouldn't happen if you follow the instructions in this article correctly, because you are entering the object definition in the sample file, loading that in the browser, then opening the devtools and typing person.
I am happy to update them again if you feel like I need to.
I wonder if I should also add a line to the "What are browser developer tools?" article to make it clear what undefined means in that context?

Chris,
Your are right
I think you should leave it like that  in order to avoid  more confusion
// Alan
On Fri, 8 Mar 2019 at 08:12, Chris Mills<EMAIL_ADDRESS>wrote:

Right. So this is standard behavior for DevTools, on Chrome/Firefox (I
don't have IE handy to test on.) It doesn't mean that the value is not set,
just that it is not returning anything. It just sits there and does nothing
until you decide to do something with it.
It shouldn't happen if you follow the instructions in this article
correctly, because you are entering the object definition in the sample
file, loading that in the browser, then opening the devtools and typing
person.
I am happy to update them again if you feel like I need to.
I wonder if I should also add a line to the "What are browser developer
tools?" article to make it clear what undefined means in that context?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mdn/sprints/issues/1142#issuecomment-470829808, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABb09eBY9-5yxvnNMXR_lRBTbXkxy_bHks5vUg1pgaJpZM4bb8FC
.

Thanks again Alan. closing this for now.


[Enhancement] Do some code optimization.[AsyncHTTPPushRequest]

Search before asking

[X] I had searched in the issues and found no similar issues.

Enhancement Request

located at:
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/push/AsyncHTTPPushRequest.java line 331,343
analysis and explanation:
a. Method invocation 'get' may produce 'NullPointerException'
b. Catch Exception instead of Throwable.
Describe the solution you'd like
a. use Objects.requireNonNull() to avoid NPE.
b. use Exception instead of Throwable.
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

@Alonexc Can i work on this issue

@himansh295 You are very welcome to pr.


Update Content on API Programmer's Guide Card on Resources Page

Problem statement
As a user, I would like the content on the website to best describe what it contains. Since the API Programmer's Guide has been updated, the text on the API Programmer's Guide card on the Resources page is outdated and needs to be updated.
What you need to know

Resources page
Existing card:

The text currently reads:

API Programmer's Guide
Set up an ELR connection to automatically report all disease data to public health departments.

The text should now read:

ReportStream API
Learn about our API and how to set up your connection for reporting data to public health departments.

Acceptance criteria

[ ] Text on API Programmer's Guide card now matches the new text written above.

To do

[ ] ...

@chris-kuryak new content added - note that I updated the card title as well, so it matches the page it goes to

Awesome @audreykwr ! Will slot it into an upcoming sprint.


discovery metadata notification message needs a more random "data-id"

Global Caches will cache metadata. They are designed to remove duplicates for data they've seen already.
Here we see two notification messages for the same metadata discovery record; the second one published after the discovery metadata was updated.
First one:
{"id": "6cb43be6-08f2-48f5-97e0-5412a60d75e4", "type": "Feature", "version": "v04", "geometry": null, "properties": {"data_id": "origin/a/wis2/eu-eumetnet-femdi/metadata/dk-dmi-opendata-harmonie_nea_sf.json", "pubtime": "2024-02-24T03:32:47Z", "integrity": {"method": "sha512", "value": "8T8RlJxK4i8IYL4uAJhtZdld3yyPWf+p8dO1HLlHWQNDGRYZLolbwfdcsUEWJdoh3G/AwK0nA90VhiermDrRTQ=="}, "datetime": null}, "links": [{"rel": "canonical", "type": "application/json", "href": "https://6a6d74.github.io/wis2node-metadata-mgmt/dk-dmi-opendata-harmonie_nea_sf.json", "length": 4168}]}

Updated one:
{"id": "dbfa7a4c-a795-4e7e-9260-3e628690d3d9", "type": "Feature", "version": "v04", "geometry": null, "properties": {"data_id": "origin/a/wis2/eu-eumetnet-femdi/metadata/dk-dmi-opendata-harmonie_nea_sf.json", "pubtime": "2024-02-24T13:49:30Z", "integrity": {"method": "sha512", "value": "8T8RlJxK4i8IYL4uAJhtZdld3yyPWf+p8dO1HLlHWQNDGRYZLolbwfdcsUEWJdoh3G/AwK0nA90VhiermDrRTQ=="}, "datetime": null}, "links": [{"rel": "canonical", "type": "application/json", "href": "https://6a6d74.github.io/wis2node-metadata-mgmt/dk-dmi-opendata-harmonie_nea_sf.json", "length": 4168}]}

You can see the message id changes. As does pubtime. But data-id is the same for both:
"data_id": "origin/a/wis2/eu-eumetnet-femdi/metadata/dk-dmi-opendata-harmonie_nea_sf.json"

Obviously the links.href can stay the same, but data-id needs some randomness. Would suggest appending a unix-epoch timestamp (or similar) to make:
"data_id": "origin/a/wis2/eu-eumetnet-femdi/metadata/dk-dmi-opendata-harmonie_nea_sf-1708776966.json"

That would ensure uniqueness.

Should the update logic be added to the canonical link instead (per https://wmo-im.github.io/wis2-notification-message/standard/wis2-notification-message-DRAFT.html#_links)?


Welcome page: weird flow of installing keybindings

Refs: #21034
OS X, insiders

Welcome page, click on sublime in keybindings
I get a notification about how a window will clickly reload
I click ok and no reload is happening, instead the keybinding is being installed and only after the installation a reload happens
This is much different than the usual extension install experience and I am not sure why are we differentiating here

I would expect that upon click on sublime we simply install the extension and open the extension viewlet. The extension will then have a reload button so a user can easily reload if he chooses. And not showing any message dialog at the top

Linux, insiders.
Agree with @isidorn, probably the best way would be to simply navigate the user to extensions viewlet with the extension selected/focused. Then he would decide himself whether he wants to install it or not by clicking on the 'Install' button.
This would be consistent with usual extension installation experience.

The idea here is to shortcut the many clicks and the viewlet with its list of extensions that must seem complex to new users. Instead the message box briefly explains what users would otherwise have to figure out step-by-step by themselves.

Improvements:

Install keymap in background while waiting for confirmation. (Keymap will be disabled if not confirmed.)
Dismiss confirmation after OK / Cancel.
If not installed 300ms after confirmation, show a message: "Installing the Vim keyboard shortcuts...".

I still dislike this flow but adding verified label since it behaves as you expaplined in your last comment


Feature Request: Web Search

Ive noticed that when building applications with claude-dev, often that not, outdated library versions are used due to the knowledge cut-off with the llm. A web search will be a great way to use updated information important to its process.

For coding purposes, it might be best to give access to git repos specifically using the existing tools.

Need browsing capabilities for updated libraries/dependencies etc

Possibly on the roadmap, closing as duplicate of https://github.com/saoudrizwan/claude-dev/issues/57


Email alerts are getting sent with schedule ID instead of name

Hello,

Your schedule cih8oaiyna from project dataform-data on dataform completed successfully.
See more details on the run page on dataform.co.

Moved from dataform-co/dataform-co#697
/cc @lewish

Now you will get email like below:
Hello,

Your schedule test-fai : t1fakfd6bh from project dataform-staging-test-project on dataform completed successfully.
See more details on the run page on dataform.co.

Will get rid of the random number when we move to the schedules.json


Make sure all configmap changes rollout

When a change happens to a configmap, kubernetes does not automatically restart any pods that make use of it. This is confusing to users because they think they have made a change, only for the workload to ignore it until the user manually deletes the pods. This change follows the standard helm workaround of annotating the pods with a checksum of the configmaps so that a configmap change becomes visible as a pod change to kubernetes causing it to redeploy the affected workloads properly and automatically during a helm upgrade.
Fixes: https://github.com/spiffe/helm-charts/issues/69

Hi @kfox1111 Can you add some more context? What problem is this fixing?

Hi @kfox1111 Can you add some more context? What problem is this fixing?

I just updated the pr description with more context.


Support Tracing

Fixes #115

Proposed Changes

Support Tracing

Release Note

:gift: Add new feature
Data plane pods produce distributed tracing spans.

/kind enhancement

This is using the Vertx SNAPSHOT dependencies since there was a bug in the tracing management.
/hold

Since this pr is already quite big, can you move the copyright fixes in another pr?

Flaky
/retest

The 1 milion dollars question: does it works with the tracing tests in eventing? Or do we wanna enable them in a followup?

I haven't tried because it doesn't make sense, I saw channel-related stuff there: https://github.com/knative/eventing/blob/9c78e32b4e0600b1a3742e2ca6d4b9e4dd571d63/test/conformance/helpers/broker_tracing_test_helper.go#L191

Ok we can figure out those details later, with the new test framework that test may be rewritten to be more extensible

For me it's an lgtm, unhold when it's ready to get in for you
/lgtm
/unhold

hmm, did you say unhold? :smile:


[apptools] Remove tests of "update" command for apptools

Remove 19 tests for "update" command
https://crosswalk-project.org/jira/browse/XWALK-5596

Please re-run the tests since the failure issue had been resolved.

LGTM

Please remove related node unit tests in other PR.


(lightworks) updated the author of the software

@AdmiringWorm  @gep13 @majkinetor
Description

This updated the author for this software as requested by issue #1544
Motivation and Context

How Has this Been Tested?

Screenshot (if appropriate, usually isn't needed):
Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Migrated package (a package has been migrated from another repository)

Checklist:

[X] My code follows the code style of this repository.
[ ] My change requires a change to documentation (this usually means the notes in the description of a package).
[ ] I have updated the documentation accordingly (this usually means the notes in the description of a package).
[ ] All files are up to date with the latest Contributing Guidelines
[ ] The added/modified package passed install/uninstall in the chocolatey test environment.
[ ] The changes only affect a single package (not including meta package).

Original Location

Original Repository
Open Issues Add the different issues underneath, and tick those that are fixed in this PR

[X] Issue 1 #1544
[ ] Issue 2 Link

[ ] Include the link to the opened PR that removes the package from the original location
[ ] The migration guidelines have been followed

:white_check_mark: Package verification completed without issues. PR is now pending human review

@RedBaron2 thanks for doing this!


Fixing #4948. Made box transparent when checked

[x] PR has tests / docs demo, and is linted.
[ ] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

The checkedIcon was being displayed with the boxIcon causing them to overlap
Closes #4948.

Notice that the transition effect is no longer the same.

Yeah, it's in the code.
What's your solution?

The animation still looks different.

On the left, new code. On the right, master implementation. Looks pretty close

@atoko Thanks for leading a way toward fixing the issue.