2.6.11

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

Failed to even lint the recipe, probably because of a conda-smithy bug :cry:. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

That's odd.

@conda-forge-admin, please rerender.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender.

@isuruf, the problem on Windows is still there:
Traceback (most recent call last):
  File "C:\Miniconda\lib\shutil.py", line 544, in move
    os.rename(src, real_dst)
FileNotFoundError: [WinError 2] The system cannot find the file specified: 'D:\\bld\\tmpza3p83nr\\nauty26r11\\This_is_nauty26r11.' -> 'C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmppjju7fyw\\This_is_nauty26r11.'

@isuruf: I'll notify upstream. Can we just repackage nauty and upload it here as a release blob on the repo? I like that better than all this bld.bat magic that you built :)

nauty26r11.tar.gz
Here's the tarball after a tar --delete for that funny file.

(We should probably put that file somewhere else but let's see first what happens.)

@conda-forge-admin, please rerender.

Thanks


Change Homepage to something more fitting

Probably some statistics, links to the different areas of the Calculator, depends on the other issue where we have to think about the structure

depending on #4


[backport] ci: hardcode docker container build image into release/v1.4

Reason for Change:

Backporting required ci changes.
Issue Fixed:

Requirements:

[x] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[x] relevant PR labels added

Notes:

/azp run Azure Container Networking PR


Package release

quadra needs to be installed using tags defined inside the repository. For example:
pip install<EMAIL_ADDRESS>
The main reason for this problem is that PyPI does not allow having direct links defined under the install_required (setup.py) or dependencies (pyproject.toml) list outside of PyPI. Because the Quadra relies on anomalib fork maintained under orobix/anomalib, this activity is on hold until resolved.
Possible solutions:

Release also anomalib package from the fork and add the correct dependency.
Remove the anomalib dependency from the list and installation tutorials mentioning that anomalib has to be installed before quadra.

Closed by #126

Closed by https://github.com/orobix/quadra/pull/126


BR: add some forwarding restrictions

At the protocol level, it is valid to have paths which destination AS is the local AS or paths that are received and forward to the same AS.

A few examples based on the topology above are:

From ff00:0:121 to ff00:0:121, with Up-seg [HF121, HF120] and a Down-seg: [HF120, HF121]
From ff00:0:121 to ff00:0:122, with Up-seg [HF121, HF120] and a Down-seg: [HF120, HF121, HF122]
From ff00:0:212 to ff00:0:222, with Up-seg [HF212, HF211, HF210] and a Down-seg: [HF210, HF211, HF222]

By adding the following forwarding restrictions, we can avoid the above paths as soon as we detect them:

Drop packets that arrive on an external interface and their source AS is the local AS.
Drop packets that arrive on the internal interface and their destination AS is the local AS.
Drop packets which ingress interface remote AS matches the egress interface remote AS (See #1928).

These restriction are still not enough to detect paths like the following:

From ff00:0:111 to ff00:0:112, with Up-seg [HF111, HF120], Core-seg [HF120, HF130] and a Down-seg: [HF130, HF111, HF112]

This is from the legacy router, does not apply anymore.


PullBuffer should not send demand itself

Instead it should return demand size, and demand should be sent from element. This can improve PullBuffer to be written in more functional way, as it should be.

According to the planning meeting on 25.06.2018 this changes internal API so it is not a priority.


ddev auth ssh fails under certain circumstances (inside Travis?)

Describe the bug
travis@bar-program-web:/var/www/html/.pantheon$ git pull origin master
Failed to add the host to the list of known hosts (/home/.ssh-agent/known_hosts).
<EMAIL_ADDRESS>password:

travis@bar-program-web:/var/www/html/.pantheon$ ls -l -h /home/.ssh-agent/known_hosts
ls: cannot access '/home/.ssh-agent/known_hosts': No such file or directory

Before that, the ddev auth ssh completes successfully:
travis@travis-job-moo-dd2e-4b88-b445-14a9bb20a2bc:~/build/Gizra/bar-program/drupal$ ddev auth ssh
Identity added: /home/travis/.ssh/id_rsa (aaron@bar-program-web)
Identity added: /home/travis/.ssh/tmate (/home/travis/.ssh/tmate)
travis@travis-job-36598630-dd2e-4b88-b445-14a9bb20a2bc:~/build/Gizra/bar-program/drupal$

Moreover, ssh-add cannot list the key inside DDEV, but can outside:
travis@travis-job-36598630-dd2e-4b88-b445-14a9bb20a2bc:~/build/Gizra/bar-program/drupal$ ssh-add -L
ssh-rsa fdfdsfds/cfGb3c7B63sBDbh8Tiu1ChZBzIhfyQ== /home/travis/.ssh/id_rsa
travis@travis-job-36598630-dd2e-4b88-b445-14a9bb20a2bc:~/build/Gizra/bar-program/drupal$ ssh-add -l
4096 SHA256:+wrLdBvRJX0Ak /home/travis/.ssh/id_rsa (RSA)
travis@travis-job-36598630-dd2e-4b88-b445-14a9bb20a2bc:~/build/Gizra/bar-program/drupal$ pwd
/home/travis/build/Gizra/bar-program/drupal
travis@travis-job-36598630-dd2e-4b88-b445-14a9bb20a2bc:~/build/Gizra/bar-program/drupal$ ddev ssh
travis@bar-program-web:/var/www/html/web$ ssh-add -l
Error connecting to agent: No such file or directory

To Reproduce
Steps to reproduce the behavior:
Not well defined steps yet, at localhost, it works with the same DDEV projects. Also for other projects, ddev auth ssh works perfectly inside Travis.
Expected behavior

Host computer OS and Version: Ubuntu 18.04.4 LTS inside Travis
ddev version information (use ddev version)

DDEV-Local version      v1.15.3
commit                  v1.15.3
db                      drud/ddev-dbserver-mariadb-10.2:v1.15.1
dba                     phpmyadmin/phpmyadmin:5
ddev-ssh-agent          drud/ddev-ssh-agent:v1.15.1
docker                  19.03.13
docker-compose          1.25.0-rc4
os                      linux
router                  drud/ddev-router:v1.15.1
web                     drud/ddev-webserver:v1.15.3

config.yaml contents for the misbehaving project

name: bar-program
type: drupal8
docroot: web
php_version: "7.4"
webserver_type: nginx-fpm
router_http_port: "8081"
router_https_port: "8043"
xdebug_enabled: false
additional_hostnames: []
additional_fqdns: []
mariadb_version: "10.4"
provider: pantheon
hooks:
  post-import-db:
  - exec: drush config-set system.site name Bar
  - exec: drush cr
  - exec: drush uli
use_dns_when_possible: true

I don't see the command ddev auth ssh failing in your example. If I understand what you're saying a git pull is failing due to failed ssh authentication?
Is it possible that you have overridden the ~/.ssh/config using homeadditions? The ~/.ssh/config provided by default has
rfay@junk-web:~/.ssh$ cat config
# Share known_hosts across all users of the ssh-agent
UserKnownHostsFile=/home/.ssh-agent/known_hosts
# In the container host key checking can be a problem with non-interactive composer, etc.
# Turn it off. When we upgrade to openssh 7.6 we can use the "accept-new" option instead of "no"
StrictHostKeyChecking=no

I guess what you need to do is add something to your travis scripts to debug this.

Verify that in the web container ~/.ssh/config is as above
ls -l /home/.ssh-agent/ to verify permissions. You should see files that are owned by the "travis" user in your case. In my case I see

$ ls -l /home/.ssh-agent/
total 4
-rw-r--r-- 1 rfay rfay 1326 Oct 21 14:02 known_hosts
srw-rw-rw- 1 rfay rfay    0 Oct 21 03:34 proxy-socket
srw------- 1 rfay rfay    0 Oct 21 03:34 socket

You should also see /home/.ssh-agent mounted:
$ df -T /home/.ssh-agent
Filesystem     Type 1K-blocks     Used Available Use% Mounted on
/dev/vda1      ext4 140105160 49901820  83056696  38% /home/.ssh-agent

Do make sure you're not running out of disk space; that df will show that problem though.

ls: cannot access '/home/.ssh-agent/': No such file or directory
df: /home/.ssh-agent: No such file or directory
That's the issue then, checking why the mount does not happen.

    - ddev-router:moo-program.ddev.site
    extra_hosts:
      host.docker.internal: <IP_ADDRESS>
    healthcheck:
      interval: 1s
      retries: 20
      start_period: 20s
      timeout: 2m
    hostname: moo-program-web
    image: drud/ddev-webserver:v1.15.3-moo-program-built
    labels:
      com.ddev.app-type: drupal8
      com.ddev.approot: /home/travis/build/Gizra/moo-program/drupal
      com.ddev.platform: ddev
      com.ddev.site-name: moo-program
    links:
    - db
    - solr:moo-program.ddev.site
    ports:
    - <IP_ADDRESS>::80/tcp
    - <IP_ADDRESS>::443/tcp
    restart: "no"
    user: 2000:2000
    volumes:
    - /home/travis/build/Gizra/moo-program/drupal/.ddev/apache:/etc/apache2/sites-enabled:ro
    - /home/travis/build/Gizra/moo-program/drupal/.ddev/nginx_full:/etc/nginx/sites-enabled:ro
    - ddev-global-cache:/mnt/ddev-global-cache:rw
    - /home/travis/build/Gizra/moo-program/drupal/.ddev:/mnt/ddev_config:ro
    - consistency: cached
      source: /home/travis/build/Gizra/moo-program/drupal
      target: /var/www/html
      type: bind
version: '3.6'
volumes:
  ddev-global-cache:
    name: ddev-global-cache
  mariadb-database:
    name: moo-program-mariadb
  solrdata: {}

A snippet from .ddev/.ddev-docker-compose-full.yaml, not surprisingly the volume is not listed here.

travis@travis-job-cb14d063-2109-4d9d-ad1b-4362d1f2b6d2:~/build/Gizra/moo-program/drupal$ docker volume ls
DRIVER              VOLUME NAME
local               ddev-global-cache
local               ddev-moo-program_solrdata
local               ddev-ssh-agent_dot_ssh
local               ddev-ssh-agent_socket_dir
local               moo-program-mariadb
travis@travis-job-cb14d063-2109-4d9d-ad1b-4362d1f2b6d2:~/build/Gizra/moo-program/drupal$

The external volume does exist with the proper name.

Actually I found the root cause, I could fix it with:
commit a5aa85e357d9921004abc174c086e07d9ced2365 (HEAD -> 1238-dev-env-refresh, origin/1238-dev-env-refresh)
Author: Aron Novak<EMAIL_ADDRESS>Date:   Thu Oct 22 13:42:47 2020 +0200

    do not omit ssh agent

diff --git a/ci-scripts/global_config.yaml b/ci-scripts/global_config.yaml
index 93559ed0..739b228c 100644
--- a/ci-scripts/global_config.yaml
+++ b/ci-scripts/global_config.yaml
@@ -1,11 +1,3 @@
-APIVersion: v1.13.0
-omit_containers: ["dba", "ddev-ssh-agent"]
+omit_containers: ["dba"]
 instrumentation_opt_in: false
-last_used_version: v1.13.0

-# You can turn off usage of the dba (phpmyadmin) container and/or
-# ddev-ssh-agent containers with
-# omit_containers["dba", "ddev-ssh-agent"]
-
-# and you can opt in or out of sending instrumentation the ddev developers with
-# instrumentation_opt_in: true # or false

I suspect that it's indeed some kind of bug, I guess the global volume must not exist when we globally opted out the SSH agent.

Are you saying that you globally opted out of the ssh-agent and then expected ddev auth-ssh to work?
I guess ddev auth-ssh should complain in that case, shouldn't it.

Are you saying that you globally opted out of the ssh-agent and then expected ddev auth-ssh to work?

Exactly. It was opted out in ~/.ddev/global_config.yaml. But ddev auth ssh seemed to work.

ddev auth ssh only sets up so that the ssh-agent can do its work, so it doesn't notice that ssh-agent is missing. Super interesting.

And also, I typically opt-out components to save time during the Travis execution, so ideally even the image should not be pulled, that would be really nice.

The image isn't pulled any more in ddev v1.16.0-alpha* edge channel if opted out.

But, of course... it sounds like you need the ssh-agent. You're trying to use it?

In this case, now I do need it, that's right, in some cases, I do not.

@rfay Thanks!


Quick Actions: Add Replace Media Functionality

Context
People want to replace media, but for real
Summary
Adds Replace Media functionality for foreground and background images.
Relevant Technical Choices
The MediaUpload component requires a render prop.
However, the useQuickActions hook does not render the quick action button. It's easier to pass in a click event handler that is later passed to the context menu button.
To do this, the useMediaPicker hook was exposed to the app. That way we don't need to use the render prop.
To-do

[x] Add replace functionality to background media
[x] Add karma tests

User-facing changes

Replace foreground media
Replace background media

Testing Instructions

[ ] This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:
**Make sure you do these for foreground media + background media (images, gifs, and videos)

Add a piece of media
Add styles to the media in the design panel
Click the Replace action in the quick action menu
Add a media and click insert media
New media should replace existing media but the styles should remain the same

Users without the hasMediaUpload capability should not be able to see this quick action (contributors)
Reviews
Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

[x] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[x] I have tested this code to the best of my abilities
[x] I have verified accessibility to the best of my abilities (docs)
[x] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[x] This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
[x] I have added documentation where necessary
[x] I have added a matching Type: XYZ label to the PR

Fixes #9196

If you insert an image block into a post / page in WordPress, then press replace, the WP Picker opens with the current image selected.

We should do the same here.
I would also change the title of the WP Picker, something like "Replace media"

If you insert an image block into a post / page in WordPress, then press replace, the WP Picker opens with the current image selected.
We should do the same here.

@spacedmonkey that would be great! I'd say that is out of scope of this ticket, so I think we should add a ticket to do this in the future.

Not super fond of how we have to solve this, so I'd really like feedback from @choumx and @sayedtaqui here

Sorry for the delay, will take a look at this tomorrow.

Perhaps we need to refactor our existing code to make it more flexible to accept MediaUpload as it is, instead of dragging the open callback to the point where it is needed. I have not tried but maybe we can directly pass the MediaUpload via Icon here and render the picture swap icon inside its render.
https://github.com/google/web-stories-wp/blob/80f1ccfcb53876aa2706143cd24a2fd2bffac906/packages/story-editor/src/app/highlights/quickActions/useQuickActions.js#L375-L380
and then reactor MenuItem to handle the case when onClick is not provided.

Perhaps we need to refactor our existing code to make it more flexible to accept MediaUpload as it is, instead of dragging the open callback to the point where it is needed. ...

🤔  This is an interesting thought, but to me it feels a bit dodgy to mold the design system (which is supposed to be agnostic) to this API?

🤔 This is an interesting thought, but to me it feels a bit dodgy to mold the design system (which is supposed to be agnostic) to this API?

Not sure if I understood the dodgy part for making a small changes for onClick, but this is what I was suggesting.
If we do not want to make any changes to  MenuItem at all, we may just pass noop for onClick
https://github.com/google/web-stories-wp/compare/try/quickaction-media-upload?expand=1

If we do not want to make any changes to MenuItem at all, we may just pass noop for onClick
https://github.com/google/web-stories-wp/compare/try/quickaction-media-upload?expand=1

Ah just saw this but I made a similar suggestion here: https://github.com/google/web-stories-wp/pull/9534#discussion_r743227045

🤔 This is an interesting thought, but to me it feels a bit dodgy to mold the design system (which is supposed to be agnostic) to this API?

Not sure if I understood the dodgy part for making a small changes for onClick, but this is what I was suggesting. If we do not want to make any changes to MenuItem at all, we may just pass noop for onClick
try?expand=1 (compare)

That would be waay simpler than what's currently in this PR for sure 👍

This works for me.

+1

I don't think there's a clean one with the way the MediaUpload is set up

We could also consider extending MediaUpload with other ways to pass the open callback to children.
I couldn't find a simpler way of doing that vs. using a render prop. The alternative suggested by this SO answer with cloneElement seems like a bit much, but it does allow passing children components normally.

I appreciate everyone taking the time to really think through our options here in an effort to properly support media upload moving forward.

Found an issue when replacing a gif/video with an image. Need to figure that out still, but with those refactors I think this is more in line with what y'all were thinking.

should be fixed now


ValueError: Unable to construct build path with source

Running fmriprep-docker on a ubuntu 19.10 platform with 24 cpus and 64GB RAM.
With the following commands:
fmriprep-docker proc_data proc_data/derivatives participant --participant-label TEST99 --fs-license-file $FREESURFER_HOME/license.txt
After the processing going on for a while and having created most of the anatomical and functional outputs in the derivatives/fmriprep folder, came the error messages attached below. The crash log in the log folder is also attached. Any hint to resolve it would be appreciated.

[Node] Finished "fmriprep_wf.single_subject_TEST99_wf.func_preproc_exe_img_rest_run_01_wf.bold_std_trans_wf.bold_reference_wf.enhance_and_skullstrip_bold_wf.apply_mask".

Traceback (most recent call last):
File "/usr/local/miniconda/bin/fmriprep", line 10, in    sys.exit(main())
File "/usr/local/miniconda/lib/python3.7/site-packages/fmriprep/cli/run.py", line 465, in main
packagename='fmriprep')
File "/usr/local/miniconda/lib/python3.7/site-packages/niworkflows/reports/core.py", line 478, in generate_reports
for subject_label in subject_list
File "/usr/local/miniconda/lib/python3.7/site-packages/niworkflows/reports/core.py", line 478, in
for subject_label in subject_list
File "/usr/local/miniconda/lib/python3.7/site-packages/niworkflows/reports/core.py", line 465, in run_reports
subject_id=subject_label, packagename=packagename)
File "/usr/local/miniconda/lib/python3.7/site-packages/niworkflows/reports/core.py", line 267, in init
self._load_config(Path(config))
File "/usr/local/miniconda/lib/python3.7/site-packages/niworkflows/reports/core.py", line 286, in _load_config
self.index(settings['sections'])
File "/usr/local/miniconda/lib/python3.7/site-packages/niworkflows/reports/core.py", line 325, in index
rlet = Reportlet(self.layout, self.out_dir, config=cfg)
File "/usr/local/miniconda/lib/python3.7/site-packages/niworkflows/reports/core.py", line 164, in init
linked_svg = layout.build_path(entities, validate=False)
File "/usr/local/miniconda/lib/python3.7/site-packages/bids/layout/layout.py", line 1351, in build_path
raise ValueError("Unable to construct build path with source {}".format(source))
ValueError: Unable to construct build path with source {'datatype': 'figures', 'desc': 'bbregister', 'run': 1, 'subject': 'TEST99', 'suffix': 'bold', 'extension': 'svg'}
Sentry is attempting to send 0 pending error messages
Waiting up to 2 seconds
Press Ctrl-C to quit
fMRIPrep: Please report errors to https://github.com/poldracklab/fmriprep/issues

crash-20200226-202341-root-summary-28e8a5a0-92d9-4b21-8fe1-2b2a5b3ce076.txt

What version of fMRIPrep are you using?

my fMRIPrep version is v1.5.9.

Thanks for the report. Seeing this in another project as well, so hopefully it won't be too hard to track down exactly why it's failing.

@audachang, are your inputs BIDS-compliant? (spoiler: they are not).
I've checked on your attached crashfile and noticed that the first error happened on a different (earlier) step of fMRIPrep. Looking at the inputs of that step I find:
bold = ['/data/sub-TEST99/func/sub-TEST99_exe-img-rest_run-01_bold.nii.gz', '/data/sub-TEST99/func/sub-TEST99_exe-img-rest_run-02_bold.nii.gz']

your files have some spurious exe-img- string - if you replace s/exe-img/task/g your dataset will be then valid.
Closing and removing the bug label.


New version: GorillaDevs.Ferium version 4.7.1

Pull request has been created with WinGet Releaser v2 :rocket:
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-09-17 02:37:53.144 [FAIL] Installer failed security check. Url: https://github.com/gorilla-devs/ferium/releases/download/v4.7.1/ferium-windows-msvc.zip Result: 0x80004005
MSI (s) (94:C4) [02:37:47:416]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'.
MSI (s) (94:C4) [02:37:47:416]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'.
MSI (s) (94:C4) [02:37:47:416]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'.
MSI (s) (94:C4) [02:37:47:416]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'.
MSI (s) (94:C4) [02:37:47:416]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'.
Property(S): OutOfDiskSpace = 0
Property(S): OutOfNoRbDiskSpace = 0
Property(S): PrimaryVolumeSpaceAvailable = 0
Property(S): PrimaryVolumeSpaceRequired = 0
Property(S): PrimaryVolumeSpaceRemaining = 0
MSI (s) (94:28) [02:37:48:260]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'.
MSI (s) (94:28) [02:37:48:260]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'.
MSI (s) (94:28) [02:37:48:260]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'.
MSI (s) (94:28) [02:37:48:260]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'.
MSI (s) (94:28) [02:37:48:260]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'.

Automated error analysis suggests -1978335187 may mean Installer failed security check. Another script should retry this every 18 hours.
Automated error analysis suggests 80004005 may mean Resource missing
(Automated response - build 895.)

@wingetbot run

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-09-18 07:24:06.274 [FAIL] Installer failed security check. Url: https://github.com/gorilla-devs/ferium/releases/download/v4.7.1/ferium-windows-msvc.zip Result: 0x80004005
MSI (s) (D8:48) [07:24:01:282]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'.
MSI (s) (D8:48) [07:24:01:282]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'.
MSI (s) (D8:48) [07:24:01:282]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'.
MSI (s) (D8:48) [07:24:01:282]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'.
MSI (s) (D8:48) [07:24:01:282]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'.
Property(S): OutOfDiskSpace = 0
Property(S): OutOfNoRbDiskSpace = 0
Property(S): PrimaryVolumeSpaceAvailable = 0
Property(S): PrimaryVolumeSpaceRequired = 0
Property(S): PrimaryVolumeSpaceRemaining = 0
MSI (s) (D8:68) [07:24:02:063]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'.
MSI (s) (D8:68) [07:24:02:063]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'.
MSI (s) (D8:68) [07:24:02:063]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'.
MSI (s) (D8:68) [07:24:02:063]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'.
MSI (s) (D8:68) [07:24:02:063]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'.

Automated error analysis suggests -1978335187 may mean Installer failed security check. Another script should retry this every 18 hours.
Automated error analysis suggests 80004005 may mean Resource missing
(Automated response - build 895.)

@wingetbot run

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-09-19 08:55:30.890 [FAIL] Installer failed security check. Url: https://github.com/gorilla-devs/ferium/releases/download/v4.7.1/ferium-windows-msvc.zip Result: 0x80004005
MSI (s) (94:04) [08:55:20:571]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'.
MSI (s) (94:04) [08:55:20:571]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'.
MSI (s) (94:04) [08:55:20:571]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'.
MSI (s) (94:04) [08:55:20:571]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'.
MSI (s) (94:04) [08:55:20:571]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'.
Property(S): OutOfDiskSpace = 0
Property(S): OutOfNoRbDiskSpace = 0
Property(S): PrimaryVolumeSpaceAvailable = 0
Property(S): PrimaryVolumeSpaceRequired = 0
Property(S): PrimaryVolumeSpaceRemaining = 0
MSI (s) (94:14) [08:55:21:305]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'.
MSI (s) (94:14) [08:55:21:305]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'.
MSI (s) (94:14) [08:55:21:305]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'.
MSI (s) (94:14) [08:55:21:305]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'.
MSI (s) (94:14) [08:55:21:305]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'.

Automated error analysis suggests -1978335187 may mean Installer failed security check. Another script should retry this every 18 hours.
Automated error analysis suggests 80004005 may mean Resource missing
(Automated response - build 896.)

@wingetbot run

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-09-19 18:29:58.629 [FAIL] Installer failed security check. Url: https://github.com/gorilla-devs/ferium/releases/download/v4.7.1/ferium-windows-msvc.zip Result: 0x80004005
MSI (s) (44:2C) [18:29:52:703]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'.
MSI (s) (44:2C) [18:29:52:703]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'.
MSI (s) (44:2C) [18:29:52:703]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'.
MSI (s) (44:2C) [18:29:52:703]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'.
MSI (s) (44:2C) [18:29:52:703]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'.
Property(S): OutOfDiskSpace = 0
Property(S): OutOfNoRbDiskSpace = 0
Property(S): PrimaryVolumeSpaceAvailable = 0
Property(S): PrimaryVolumeSpaceRequired = 0
Property(S): PrimaryVolumeSpaceRemaining = 0
MSI (s) (44:80) [18:29:53:515]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'.
MSI (s) (44:80) [18:29:53:515]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'.
MSI (s) (44:80) [18:29:53:515]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'.
MSI (s) (44:80) [18:29:53:515]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'.
MSI (s) (44:80) [18:29:53:515]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'.

Automated error analysis suggests -1978335187 may mean Installer failed security check. Another script should retry this every 18 hours.
Automated error analysis suggests 80004005 may mean Resource missing
(Automated response - build 896.)

Umm I'm not sure what I'm supposed to do here, I believe I just have to wait for MS Defender to whitelist this file?

@wingetbot run

I'm not sure it its ferium itself, that is causing the issues.
I can download and run ferium 4.7.1 without any issues, it is only an issue, if I try to install it through winget.

I tried pinging the Windows Defender a few times, I hope that it helps.

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-09-23 08:43:14.552 [FAIL] Installer failed security check. Url: https://github.com/gorilla-devs/ferium/releases/download/v4.7.1/ferium-windows-msvc.zip Result: 0x80004005
MSI (s) (10:E0) [08:43:08:717]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'.
MSI (s) (10:E0) [08:43:08:717]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'.
MSI (s) (10:E0) [08:43:08:717]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'.
MSI (s) (10:E0) [08:43:08:717]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'.
MSI (s) (10:E0) [08:43:08:717]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'.
Property(S): OutOfDiskSpace = 0
Property(S): OutOfNoRbDiskSpace = 0
Property(S): PrimaryVolumeSpaceAvailable = 0
Property(S): PrimaryVolumeSpaceRequired = 0
Property(S): PrimaryVolumeSpaceRemaining = 0
MSI (s) (10:08) [08:43:09:545]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'.
MSI (s) (10:08) [08:43:09:545]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'.
MSI (s) (10:08) [08:43:09:545]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'.
MSI (s) (10:08) [08:43:09:545]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'.
MSI (s) (10:08) [08:43:09:545]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'.

Automated error analysis suggests -1978335187 may mean Installer failed security check. Another script should retry this every 18 hours.
Automated error analysis suggests 80004005 may mean Resource missing
(Automated response - build 896.)

@wingetbot run


Clarify and expand descriptions of NonFiles

This is a minor documentation revision, to make clearer what a NonFile/"non-file" is, as discussed in https://github.com/GitoxideLabs/gitoxide/pull/1730#discussion_r1894381449. At least for now, they are named the same, but the term is more specifically defined.
A couple of possible other names that it could be changed to:

Other as suggested in #1730 (comment). As noted, this is natural. But it is not specific. If Git uses this as a technical term, as suggested, then it should probably be used. I was unable to find it in a cursory search of git/git on GitHub, though. I didn't find anything for "NonFile" and everything I found for "non-file" was in phrases like "non-file mailmap," "non-file remote," "non-file backend," and "non-file argument."
NonTrackable, or variations such as Untrackable and NotTrackable - This idea is from a commit message in a test that refers to the condition of not being a NonFile as that of being a "trackable file." I think this is also intuitive when considered abstractly, and accurate. But I'm not sure if it would be intuitive in practice.

Instead of changing it to one of those here, I've just clarified and expanded the documentation. This is with the idea that, with the documentation adjusted this way, it should be possible to figure out if any other name still confers a significant improvement in clarity.
There is another conceptually related change that I made to nearby documentation that is not really covered by this. I'll post a review comment on it so that if it is considered out of scope or unwanted then it can be undone.,

A great catch, thanks! I was a bit sloppy quick here 😅.

I just realized the commit message in 154b21f somewhat overinflates its importance: it's not changing documentation comments, but instead a regular comment and debug and assertion messages. (Fortunately, since it's not really changing documentation, it's not a conventional commit with doc:, somewhat limiting the breadth of the confusion.)


Workflow unclear to make ros2 topic echo work for custom-generated types

In Anzu PR 9310, unable to use it for custom generated type; not immediately clear to me how to make this work.
FYI @sloretz @cottsay
\cc @IanTheEngineer @calderpg-tri

It seems like the right workflow is to ensure the Python messages are on PYTHONPATH when running the ros2 CLI:
3ffdb67
That at least makes ros2 topic echo work.
However, ros2 interfaces list does not work: 71c9e27
How do we update this to ensure that our messages etc. are discoverable?

How do we update this to ensure that our messages etc. are discoverable?

The messages are made discoverable via the ament index. This is normally created via this bit of CMake code. There doesn't seem to be an equivalent in bazel_ros2_rules, but maybe it could exist here so that depending on :custom_messages_defs gave a target the ability to discover those messages. If so the key pieces are to generate ament_index files for custom messages, and to make the shim update the AMENT_PREFIX_PATH environment variables to point to those files when :custom_messages_defs is depended upon.

Fixed by #124


floorp: build with private components, adjust license

see https://github.com/Floorp-Projects/Floorp-private-components/blob/main/LICENSE
Description of changes

From versions v11.10.5 -> v11.11.0, Floorp moved some of its bespoke components (most notably its Workspaces feature) to a separate repo, distributed under the "Floorp Shared Source License", which is essentially an unfree redistributable license for the purposes of nixpkgs.

License: https://github.com/Floorp-Projects/Floorp-private-components/blob/main/LICENSE
Relevant changes in the main repo: https://github.com/Floorp-Projects/Floorp/compare/5d22e392cfae6bf3f5432528e8019f1a2aa3121f...bd057dfa3d08ee537dcd6a20cd03c416e0452e43
Relevant changes in the Floorp-core repo: https://github.com/Floorp-Projects/Floorp-core/compare/2903aec35fbfe936c8415c92e9c073441d53743c...2b5b78a1886daf531e06f7eb278f0b27e7983e07

This PR enables building with these components, and adjusts Floorp's license to include the new unfree redistributable license accordingly.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@christoph-heiss Draft for now because I wanted to get your opinion on this: Instead of updating the floorp package to include the new unfree redistributable license, an alternative approach would be to add a new floorp-unfree package that includes these components.
My initial thoughts were that including them in the core floorp package probably makes more sense, since I'd wager Workspaces are one of the main reason why someone might choose Floorp over vanilla Firefox. Thoughts?

Instead of updating the floorp package to include the new unfree redistributable license, an alternative approach would be to add a new floorp-unfree package that includes these components.

Well, the thing is - from a maintainability standpoint, I'd definitely only keep one package. Also having another build for a Firefox fork in the tree significantly burdens Hydra even more, since these are one of the most expensive packages to build, as you can imagine.
I do not consider myself in really the position to decide that - I think the best would be to drop by in the Nix Mozilla Matrix channel (https://matrix.to/#/#mozilla:nixos.org), link this PR and discuss it there maybe a bit.
In any case, I am not willing to maintain any proprietary code/packages, and never will.
This means someone else has to do that, and that's - especially given this is a browser, so a very security-critical application - sometimes not an easy task. (e.g. timely updates are a must)
Would you be willing to take this over?

Would you be willing to take maintainership, regardless of which way we go here?

Hmm, actually, probably not. My work schedule can be unpredictable at times, and I'm afraid of the scenario where upstream makes some big change that breaks the build script and I don't have the time to fix it. Not that unlikely of a scenario, seeing as they're planning on moving from extended support release to rapid releases soon.
I wouldn't mind being added as a maintainer, but I definitely wouldn't want to be the only one for that reason.
Think I'll probably close this PR then for now, but if someone else wants to have the torch, feel free to use this as a base for your own.

In the meantime, if someone stumbles across this wanting workspaces in their Floorp, and also doesn't mind to compile the entire thing from scratch for every update, you can add this in your nix config instead of pkgs.floorp:
(pkgs.wrapFirefox
  (pkgs.floorp-unwrapped.overrideAttrs (old: {
    extraConfigureFlags = (old.extraConfigureFlags or [ ]) ++ [
      "--enable-private-components"
    ];
  }))
  { })

Note that this will pull in unfree code to your installation!


[stable/magento] bump dependency mariadb 1.0.2

See https://github.com/kubernetes/charts/issues/1944#issuecomment-327856581


reimport of glb file does not reimport the textures of the file

Godot version
4.1.2
System information
Windows 11
Issue description
when I export a glb file from blender and I've edited a texture on one of the materials, I then go to Godot to reimport the glb the textures are not replaced with the new one. Clicking reimport on the texture itself doesn't work either.
To get around this I have to first delete the image in godot, ignore the warning and click reimport on the glb file. The problem with this work around is that the import settings of the image are then reset every time and also it's annoying.
Steps to reproduce

export glb with a material and texture from blender.
import in Godot
edit texture and re-export glb
re-import in Godot

(using minimal reproduction project)

open "gltf 1/test.glb" and "gltf 2/test.glb" in a program that can preview it and observe that the two files have different textures on the suzanne mesh.
copy "gltf 1/test.glb" to the projcet folder and observe that suzanne has "1" written on the head.
copy and owerwrite "gltf 2/test.glb" to the project folder and observe that suzanne still has "1" written on the head (it should be "2" now).

Minimal reproduction project
https://github.com/atornity/godot_import_gltf_issue

This sounds the same as:

https://github.com/godotengine/godot/issues/83154

Please confirm

This sounds the same as:
* [glTF import won't update extracted texture #83154](https://github.com/godotengine/godot/issues/83154)

Please confirm

No idea how I didn't see that.
Yes, it seems to be the same issue although It's not at all "unpredictable" for me.

Good, then a duplicate, please search for open issues in the future :) This one was easily found with "glb texture reimport".


check.py: Avoid shell=True in subprocess calls

This simply breaks up the args into a list of args so we can avoid using shell=True

Added note to the changelog


Prepare release <IP_ADDRESS>

I'd like to wait with the release for another week in order to possibly include https://github.com/haskell-unordered-containers/unordered-containers/pull/246 and https://github.com/haskell-unordered-containers/unordered-containers/pull/259.

Ready to release! :)
@treeowl, can you take it from here?

Ping @treeowl! :)
If you give me upload permissions, I could do the release too BTW!

Sorry, let me do one more pass today and then I'll release.

Oh, crud. I got mixed up and thought this was an issue rather than a PR, and started doing some of this, and I think also some other changelog updates, in a different commit. Can you please rebase carefully to make sure we don't double up?

Never mind. It didn't push....

@sjakobi please review the package candidate https://hackage.haskell.org/package/unordered-containers-<IP_ADDRESS>/candidate

I've made a few more tweaks to the changelog in #269. I'll cut the release once that is merged.


update 1.1.0 some network don't work

Describe the bug
when i update it to 1.1.0.
i use google chrome,but network don't work.

when i stop orbstack.
it is work.

To Reproduce
No response
Expected behavior
No response
Diagnostic report (REQUIRED)
No response
Screenshots and additional context (optional)
No response

when i restart my mac, it is all right


refactor: content demo

write a demo about with content, includes scss、config and js

1、contentView  is not a crx's component ,so should not create a folder for it
2、make vite chunk build config simple
3、add a demo to show how combining other scss in content


Support for 'ref' type fields

Description
Currently ref type fields return null:
else if (value instanceof admin.firestore.DocumentReference) {     return null; }
See here
Expected Behavior
ref is a firebase object that has a property path that returns a string, for me personally that's all I need to be indexed to Typesense so I think working with that would be the easiest solution for now.
Metadata
Typsense Version:
"typesense": "^1.2.2",
"typesense-instantsearch-adapter": "^2.4.0"

OS:
macOS

I've published this in v0.4.0 of the extension.


Saver.read with multiple matches

Seem to be getting error when 'read' is called and there are multiple matching paths. Expand testing to cover cases with different kwargs when there are multiple matching paths.

Also add more test cases for if there are no matches.


fix: Xcode 15 build issue

Dismissed my review due to @nickle-rs's comments in Slack, pointing out that this library isn't used in the Shopper app.

@briannadoubt, we're all in the same boat, now: working on both apps. 😅 This is needed for the Creator app.


Add 'Reason' to SelectionChangeEvent

In the process of working on a Vim plugin for VSCode I've run into a number of areas where I need a little bit of API help. Apologies if any of my suggestions already exist!
One thing that I would really like is an onClick event. I know that we have a way to see if selections are changed, but the difficulty is that the Vim plugin changes the selections a lot, which makes it difficult to know who changed the selections - me or you. onClick would solve this problem.

Not sure about onClick but we could enrich the TextEditorSelectionChangeEvent with some sort of hint

Yeah, that would be great.

fyi @jrieken  - there is a ICursorSelectionChangedEvent.source - 'mouse' will be set there if the mouse handler or touch handler caused it. https://github.com/Microsoft/vscode/blob/master/src/vs/editor/browser/view/viewController.ts#L71

@alexandrudima I also see ICursorSelectionChangedEvent.reason. How are both reason and source related? Will source be set when reason is Paste?

I need some naming inspiration for this one... I wonder if source is a good name because thats commonly used for the emitter/sender of event objects (which would be the editor itself following the model). Maybe something like modifiedBy and an enum TextEditorSelectionModifier. Idea:
	export enum TextEditorSelectionModifier {
       Keyboard = 1,
       Mouse = 2
    }

	export interface TextEditorSelectionChangeEvent {

        modifiedBy?: TextEditorSelectionModifier;

		textEditor: TextEditor;
		selections: Selection[];
	}

Then looking at the editor the source is a string which can be arbitrary, like emmet, so I wonder what modifiers we should enumerate for the API. @johnfn Do you only require mouse/onClick or also things keyboard, api etc?

@jrieken what if multiple extensions want to tweak the selection in response to a keyboard or mouse selection change? The extensions could check for modifiedBy == api (or source != 'editor'?) to prevent infinite looping, but the end result would be nondeterministic.

I don't understand that how that relates to modifiedBy? Already today listeners can trigger events while being active. Since event delivery happens in the order of subscriptions I don't see the nondeterminism. Having said that, it's usually a bad idea to trigger events while processing them..

@jrieken I'm talking about the current situation, not the proposed change. Sorry it was tangential, but modifiedBy made me think of preventing instability in handling selection-changed events when the event is retriggered during processing, which made me think about what happens when extensions concurrently attempt to change the selection.
Unless you wait for one handler to complete before calling another, I'm pretty sure the outcome is nondeterministic.
But maybe the right answer is as you suggeted: "don't retrigger an event while processing it." In which case I need to make a feature-request for modifying selections before they are applied...

In which case I need to make a feature-request for modifying selections before they are applied.

Yeah, that's a different thing because the extension host is only being informed about selection changes and isn't part of the select-operation.

@jrieken I have complete confidence I can leave this issue entirely to you

@johnfn Do you only require 'mouse/onClick' or also things 'keyboard', 'api' etc?

@johnfn Can you please answer?

@jrieken ah, super sorry! I have difficulty sorting through all my Github notifications. 😞
mouse and/or onClick are by far the highest priority. The others are welcome if possible.

Thanks. I understand mouse as in 'user selected something' explicitly (not because of undo/redo, setting new content etc). Will make the changes early August such that we have enough time to fine tune

Exactly. Any click or release event, and explicitly not anything else.

@johnfn I have just pushed the change to master. It would be great if you can give it try with tomorrows insider build and give feedback

@jrieken ooh, this is a big one. I have been waiting on this for a while. Thanks!

Thanks and happy coding

@jrieken I've played with this new API change and most cases work perfectly. The only problem I've run into right now is sometimes TextEditorSelectionChangeKind is undefined, for example, when you insert a code snippet and all placeholders are selected, we receive a selection change with TextEditorSelectionChangeKind set as undefined. Any ideas?

That's the defined behaviour - there is no guarantee that the source is always known


Support DatabaseSnapshot

From @TamalSaha on March 13, 2017 8:28
Goal:
Port our grpc api to TPR based version: https://github.com/appscode/api/blob/ad5ff4c7690a95b53b682da388f164504f34fd14/db/v1beta1/snapshot.proto
Design:

Create a new TPR called DatabseSnapshot. This will work on any type of k8sdb. The object will have all the info necessary for taking snapshot.

DB reference
Bucket location, secrets for connection, etc.

Operator for each db will watch for DatabseSnapshot create events with matching label (eg, k8sdb.com/type: postgres).

User can manually create the DatabseSnapshot object to take one-of snapshots.
Scheduled Snapshots
Each DB TPR will have fields for snapshot schedule and necessary info (bucket name, etc). If that field is set, operator for that Db type will create a Kubernetes CronJob using a k8sdb-snapshotter docker image. The snapshotter process lives in this repo. It creates a DatabaseSnapshot object everytime the cron job is scheduled. The actual process of snapshotting is done by the individual operators.
Copied from original issue: k8sdb/apimachinery#1

@aerokite I think we should avoid using Kube's CronJob for now. It is still in alpha. And we are not going to use any alpha feature, given our past experience. So, we have do the cron part ourselves using robfig cron.
Kube's plan for CronJOb: https://github.com/kubernetes/kubernetes/issues/41039

This issue was moved to kubedb/project#60


Different samples for different purposes

Is your feature request related to a problem? Please describe.
Having the same settings for samples and profiling as for number of rows (or percentage) we cannot provide the whole profiling without demonstrating the full table/schema as samples. We don't need to see a table with 1 mln rows (100 rows would be enough) but profiling should be done for the whole table. Or sometimes we don't need profiling at all but samples are important
Describe the solution you'd like
We'd like to have different sample %/rows' number for sample demonstrated and profiling
Here is the slack link: ttps://openmetadata.slack.com/archives/C02DZK3QH8Q/p1678205790829219

@ayeremeeva sampling is for profile only. For sample data we consider all of the profile sample % but only capture 100 rows. Just because you mentioned 100% and there are 1M rows we won't ingest all of that data into OpenMetadata as sample.


Tasks

Tasks

[x] Expose relevant method on the tree builder parser trait.
[x] Document the new API in api.d.ts CstParser class.
[ ] Should there be special handling if this API is called from an EmbeddedActionsParser?
- e.g throw an error?
[ ] Tests and 100% Coverage.
[ ] Create small example in examples/parser for this scenario.
[ ] Update CST Guide Docs on the website (also link above example).

Originally posted by @bd82 in https://github.com/SAP/chevrotain/issues/1032#issuecomment-527990322

maybe copy paste these sub tasks in the original issue so you can edit them?

I am closing this issue, please track this in the original issue.


Android Build?

(sorry, hard to search if this is already asked, but..)
I would like to view my Android TV on my Android Tablet. Can we build this program for Android (an APK?) or where can I find that?

#100


With Deal colorings, color should account for overhead

It's late so I might have the math wrong here, but the general point should be right.  Buying at just below the resting price and selling at just above doesn't get any profits, because the overhead eats it all.  If we let o be overhead (so without brokers, overhead is 20% and o = 0.2), then if the stock percentage value is between 1/sqrt(1 + o) and sqrt(1 + o), it should be colored gray in deal mode; then you can always buy purple-colored stocks and sell green-colored ones without losing anything to overhead.

Thanks!  This will make things easier, especially early in a run.

Sure! Let me know if I messed up anything or something doesn't work as intended.

I'm still seeing some issue but I'm not sure exactly where it's coming from.  My overhead is 1.54%, so with the symmetric calculation I suggested nothing should happen between about 99.24% and 100.77%.  However, in this screenshot:

it says I should sell at something rounded up to 100%.  That is, the ratio is within the no-action range, and even with no overhead it's below 100% so should not be a sell color.
Unfortunately, since I took the screenshot the market's changed and I can't test with the other gradient scheme or try to debug the code in the js console, or I'd provide more information.

Hmm... I've been looking into it a bit but can't replicate it so far, if i change the values to percentage = 100% and overhead = 1.54% it does indeed stay greyed out.
There might be some problem with it not updating when the market updates, I'll keep an eye on it.


Added opportunity to set fixed amount of promo codes

Now you can do :
Promocodes::create($amount, $reward, $data, $expiresIn, false, $amount);
$amount is an integer.
You need to make migration if you have already installed laravel-promocodes
php artisan vendor:publish
php artisan migrate

Fix indents

Great feature. I will write tests for this and then I will definitely merge ;)

i think this commit is to have a functionality of having the coupon valid for the first N uses ... correct me if im wrong .. hope this makes it to the repo ... rather than having a separae field it would be good to use the additional data to have [ maximum_uses => N , maximum_uses_per_user => X ] and work round that, i think this is one of the common uses cases

in addition to the above post it would be super easy if we can add another attribute which would cap the max promo credit by default where in if the percentage bonus is greater than Y and caps it to Y that pretty much wraps all use cases
[ maximum_uses => N , maximum_uses_per_user => X, maximum_bonus => Y ]

also we can add eligibility check to for the coupon for cases where coupon is valid only for a purchase of Z
[ maximum_uses => N , maximum_uses_per_user => X, maximum_bonus => Y, eligibility => [conditions] ]

Any news?


Doc reorg: Configuring CumulusCI

Rendered Docs: https://cumulusci.readthedocs.io/en/feature-doc-reorg__config/config.html
My goal is for this section to be the one-stop-shop for anything that can be configured via the cumulusci.yml file. I think that there is a good majority of content here, but I will need some supplemental input (e.g. the "Plan Configuration" section). Feel free to add other examples to cookbook.rst. My intent is to do a simple first example in confg.rst and then practical examples of common configurations can be listed in cookbook.rst.
Open Questions
(1) I wanted to include a section on Org Configurations even though there is a complete vScratch Org Environments section. Let me know if I'm including too much and need to link out to the other section sooner.

@davidmreed @davisagli - I'm working on the "Using when Clauses" section and thinking if should probably go under the "advanced configuration" section because of the knowledge needed for specifying the clause (e.g. creating a pythonic statement that evaluates to a boolean, what variables are available to reference).
Wondering what both your thoughts are?

@justinvholt - I noticed that all of the lines that start with Example: were indented. I'm guessing this was to make the "preview" on github display a certain way. For the final version we won't want these indents as they cause the rendered version to look a little wonky.

@justinvholt - I noticed that all of the lines that start with Example: were indented. I'm guessing this was to make the "preview" on github display a certain way. For the final version we won't want these indents as they cause the rendered version to look a little wonky.


Bugfix/improve logging replication message

Adds a small amount of debug-logs to replication messages during timeouts.
Presently it's difficult for an on-call to know which requests are taking too long and fetching too much data.

Pull Request Test Coverage Report for Build 018280bd-174c-4c68-9d03-3bd1646b6414

0 of 7 (0.0%)  changed or added relevant lines in 2 files are covered.
71 unchanged lines in 10 files lost coverage.
Overall coverage increased (+0.06%) to 57.728%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

common/log/tag/tags.go
0
3
0.0%

client/history/client.go
0
4
0.0%

Files with Coverage Reduction
New Missed Lines
%

service/history/queue/timer_queue_processor_base.go
1
77.26%

common/backoff/retry.go
2
92.11%

common/membership/hashring.go
2
83.54%

common/task/fifoTaskScheduler.go
2
85.57%

service/history/shard/context.go
2
65.02%

common/persistence/nosql/nosqlplugin/cassandra/workflow.go
3
57.89%

service/history/task/fetcher.go
3
91.79%

service/matching/taskListManager.go
4
76.88%

common/persistence/nosql/nosqlplugin/cassandra/workflowParsingUtils.go
19
86.32%

common/persistence/nosql/nosqlplugin/cassandra/workflowUtils.go
33
74.22%

Totals

Change from base Build 01828014-b220-4ae5-8811-94eda2de108b:
0.06%

Covered Lines:
84040

Relevant Lines:
145580

💛  - Coveralls


Cannot convert from continuous to centroid with vendor peakpicking

When dealing with QCP and QCI files, we have a setup that returns continuous data.
I would like to use msconvert to get centroid so it would be the same as all the rest of the data we have.
I'm currently using :
    arguments = ""
    arguments += f"wine msconvert {docker_file} "
    arguments += "--outdir /out_data --mzML "

    if "_QCP_" in docker_file.upper() or "_QCI_" in docker_file.upper():
        arguments += """--filter "peakPicking true 1-" """

    # # Tried with all the arguments bellow but removed them to pinpoint the issue.
    # arguments += f"""--filter "lockmassRefiner mz={lock_mass} tol=0.5" """
    # arguments += """--filter "msLevel 1" """
    # arguments += """--filter "zeroSamples removeExtra" """
    # arguments += "--zlib "
    # arguments += "--numpressAll "
    # arguments += "--32 "
    # arguments += "--inten32 "
    # arguments += "--mz32 "

However I got a
2023-06-20T20:04:57.135427847Z format: mzML
2023-06-20T20:04:57.135481769Z     m/z: Compression-None, 64-bit
2023-06-20T20:04:57.135485667Z     intensity: Compression-None, 32-bit
2023-06-20T20:04:57.135488582Z     rt: Compression-None, 64-bit
2023-06-20T20:04:57.135491097Z ByteOrder_LittleEndian
2023-06-20T20:04:57.135493662Z  indexed="true"
2023-06-20T20:04:57.135496327Z outputPath: /out_data
2023-06-20T20:04:57.135498781Z extension: .mzML
2023-06-20T20:04:57.135501206Z contactFilename:
2023-06-20T20:04:57.135503591Z runIndexSet:
2023-06-20T20:04:57.135508370Z spectrum list filters:
2023-06-20T20:04:57.135510794Z   peakPicking true 1-
2023-06-20T20:04:57.135513149Z   msLevel 1
2023-06-20T20:04:57.135518318Z chromatogram list filters
2023-06-20T20:04:57.135523148Z filenames:  MySuperFile.raw
2023-06-20T20:04:57.135636652Z processing file: MySuperFile.raw
2023-06-20T20:04:58.637570736Z calculating source file checksums
2023-06-20T20:05:50.877500090Z writing output file: MyOutFile.mzML
2023-06-20T20:10:39.740727767Z Error writing run 1:
2023-06-20T20:10:39.740760378Z File Open Error
2023-06-20T20:10:39.741977092Z Conversion failed for 1 runs in  MySuperFile.raw
2023-06-20T20:10:39.744486502Z Error processing file  MySuperFile.raw

I tried all the combinations of parameters, on many different files from different days/batches ,without success....
Thanks in advance,
Have a great day.

Peak picking on Waters .raw can be pretty finicky. Also the Waters peak picker caches the centroid data inside the .raw directory, so it needs write access. Was that the issue?

Hello @chambm,
I don't really know to be honest, after hours of switching the filters it seemed to black-magically work
Maybe was the ``--filter "peakPicking true 1-"that I changed for explicit--filter "peakPicking true msLevel=1"`
So I will keep it like that (thus closed the issue)
Thanks a lot for the fast reply !
Have a great day.


adds custom delegate methods to inform the delegate upon overlay rela…

The changes add two optional delegate methods to inform the delegate upon overlay related events.
The reason for the changes is, I want to hide a subview after the cell is swiped open. But since the cell is displaying an overlay copy of itself, setHidden no longer works. I have to hide the subview right before the overlay is created.

Hello, thanks for the PR. I have merged it manually because I like swipeTableCellWillBeginSwiping & swipeTableCellWillEndSwiping names better


Upgrade to react-native 0.60

@pavjacko What is the plan here? There are many interesting new features and bugfixes in 0.60, and 0.61 is already on it's way.

@maximilize almost there! https://github.com/pavjacko/renative/pull/269 should be ready end of this week. Alpha preview should be even sooner. this will support 0.61.1 already

@pavjacko That's great news. I'll have a look into this later when we start our migration to web and tizen.

@maximilize  0.28.0-alpha.2 is out with support for RN 0.62.2 with all major platforms.
PR https://github.com/pavjacko/renative/pull/269 will be open for QA/Fixes until we have stable release and can migrate fully to 0.28.0


Update friture to master branch, add necessary python packages

Motivation for this change
Package upgrade. I didn't upgrade to v0.41 because there were two issues with it that broke the package.
I didn't run tests for the python packages added with these commits, but friture seems to be able to use them.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Ahoy, I added the licenses and changed the date format. Also, I removed the fetchpatch derivation argument from friture (because it was just a development relict).

This should do the trick!


Implement filtering jobs list by queue

@guidow, I'd consider the above more of a nit so feel free to merge if you'd prefer to keep it as is.


Add asdf as a node version manager

Summary
Adding asdf as a node version manager.
https://github.com/asdf-vm/asdf
asdf is a great version manager, and it was missing from here, so my projects couldn't find the node binary. Now they can!

Changelog

[Internal] [Added] - Find node binary when using asdf as the node version manager
Test Plan

lol @akshetpandey, what's up with the thumbs down?

Closing this, since https://github.com/facebook/react-native/pull/30111 got merged.


Cap dispenser remodel (+Reliability)

Lifting caps from below with detachable refill
Hollow structure instead of the aluminum breadboard

Working with Ishaan to deploy this soon


Reply to confirm_reqs with a vote by hash

Do we have a test to check efficency of sending vote for hash (fork) & then fork block? Wouldn't vote be just ignored?

Nope, votes are stored by their hash, and later the hash->block table is used when votes are tallied.


bug: i_ctrl-o mappings not executed, chars are inserted instead

Did you check docs and existing issues?

[X] I have read all the which-key.nvim docs
[X] I have updated the plugin to the latest version before submitting this issue
[X] I have searched the existing issues of which-key.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
v0.10.0
Operating system/version
Debian GNU/Linux trixie/sid
Describe the bug
This issue is a remake of issue 141. The mapping chars are inserted in the buffer instead of being processed in normal mode.
I managed to fix the problem by applying the following patch.
diff --git a/lua/which-key/state.lua b/lua/which-key/state.lua
index 83ffd71..d6f8edf 100644
--- a/lua/which-key/state.lua
+++ b/lua/which-key/state.lua
@@ -234,6 +234,12 @@ function M.execute(state, key, node)
     if vim.v.register ~= Util.reg() and state.mode.mode ~= "i" and state.mode.mode ~= "c" then
       keystr = '"' .. vim.v.register .. keystr
     end
+
+    local curr_mode = vim.api.nvim_get_mode().mode
+
+    if curr_mode:find("ni[IRV]") ~= nil then
+      keystr = "<C-O>" .. keystr
+    end
   end
   Util.debug("feedkeys", tostring(state.mode), keystr)
   local feed = vim.api.nvim_replace_termcodes(keystr, true, true, true)

Steps To Reproduce

Open a buffer and enter insert mode (i).
Press <c-o> followed by zz.
zz is written in the buffer.

Expected Behavior

zz is executed as a mapping in normal mode.

Health
which-key: require("which-key.health").check()

- OK Most of these checks are for informational purposes only.
  WARNINGS should be treated as a warning, and don't necessarily indicate a problem with your config.
  Please |DON't| report these warnings as an issue.

Checking your config ~
- WARNING |mini.icons| is not installed
- WARNING |nvim-web-devicons| is not installed
- WARNING Keymap icon support will be limited.

Checking for issues with your mappings ~
- OK No issues reported

checking for overlapping keymaps ~
- WARNING In mode `n`, <gc> overlaps with <gcc>:
  - <gc>: Toggle comment
  - <gcc>: Toggle comment line
- OK Overlapping keymaps are only reported for informational purposes.
  This doesn't necessarily mean there is a problem with your config.

Checking for duplicate mappings ~
- OK No duplicate mappings found

Log
Debug Started for v3.13.2
{
  branch = "main",
  commit = "6c1584eb76b55629702716995cca4ae2798a9cca"
}
new Mode(n:1)
Trigger(add) Mode(n:1) ' ` " z= g' g` ] [ <C-W> z g
on_key: i
ModeChanged(n:i)
  new Mode(i:1)
  Safe(true)
Trigger(add) Mode(i:1) <C-R>
on_key: <C-O>
ModeChanged(i:niI)
  Safe(true)
on_key: z
State(start): Mode(n:0) Node(z) { keys = "z" }
  update Mode(n:1)
  continue: z Mode(n:1)
  getchar
  on_key: z
  got: z
  suspend: Mode(n:1)
  Trigger(del) Mode(n:1) z= g' g` ] [ <C-W> z ' ` " g
  feedkeys: Mode(n:1) zz
ModeChanged(niI:i)
  Unsafe(pending "z")
  suspend: Mode(i:1)
  Trigger(del) Mode(i:1) <C-R>
on_key: z
on_key: z
Trigger(add) Mode(n:1) ' ` " z= g' g` ] [ <C-W> z g
Trigger(add) Mode(i:1) <C-R>
on_key: <Esc>
ModeChanged(i:n)
  Safe(true)
on_key: :
ModeChanged(n:c)
  new Mode(c:1)
  Safe(true)
Trigger(add) Mode(c:1) <C-R>
on_key: q
on_key: !
on_key: <CR>
ModeChanged(c:n)
  Unsafe(command-mode)
  suspend: Mode(n:1)
  Trigger(del) Mode(n:1) z= g' g` ] [ <C-W> z ' ` " g
Trigger(add) Mode(n:1) ' ` " z= g' g` ] [ <C-W> z g

Repro
vim.env.LAZY_STDPATH = ".repro"
load(vim.fn.system("curl -s https://raw.githubusercontent.com/folke/lazy.nvim/main/bootstrap.lua"))()

require("lazy.minit").repro({
  spec = {
    { "folke/which-key.nvim", opts = {} },
    -- add any other plugins here
  },
})

Ran into the same issue.
You can implement a work around with the following mapping.
vim.keymap.set("i", "<YOUR_BINDING_HERE>", function()
    vim.cmd("startinsert!")
    vim.api.nvim_feedkeys(vim.api.nvim_replace_termcodes("<Esc>", true, true, true), 'n', false)
end, { expr = true })

I ran into the same issue, the issue patch fixed the problem for me.

This issue shouldn't be closed. It is valid and has a simple fix.


added back python 3.5 support

Related to issue #356
https://github.com/Grokzen/redis-py-cluster/issues/356

@n89nanda After considering it, i will follow what i said before that i will follow the support matrix of the upstream redis-py as much as possible even if it would go outside my normal and usual way of dealing with supported python versions. Thank you for this contribution.


Cadence 1.0 changes

Description
quick bandage for cadence 1.0 enforcing scripts to begin with
access(all) fun main
instead of
pub fun main
which breaks cadut parser, which in turn is used by flow-js-testing
ideally should release a version with a fix for this ASAP, so that flow-js-testing can be fixed without patching
Also updated the templates for contract deploy/update.

For contributor use:

[x] Targeted PR against master branch
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work
[ ] Code follows the standards mentioned here
[ ] Updated relevant documentation
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Added appropriate labels

I've changed the workflow to use Cadence 1.0 CLI
This will need to be reverted later on

Worth noting, the update template handles both update and deploy, but the param deciding which one to use is broken - if you set update to true it will use the deploy-only version. Not touching that to not break compat.
  const template = update ? addContractTemplate : updateContractTemplate

@jribbink
The failing tests are related to a plugin library (but they ran locally now so probably related)
Fixed parsing of authorized arguments


changelog for release 2.0

I usually write a brief changelog for each new releases inside the git annotated tag message. This time the changes since 1.8.0 are many, because we merged the classtree branch and refactored most of the modules. And I was only indirectly involved in this, so it's a bit difficult for me to summarize the changes.
Could @moyogo or @belluzj help me write down the most notable changes? I'm not talking about implementation details, but only changes that users of the library would be interested in, like API changes, or bugfixes, etc.
You could write in here the proposed release notes, and then when we're happy I'll use them to cut a new release.

The lib now supports .glyphs -> Python objects -> .glyphs round-trip for Glyphs files that were produced with Glyphs >= 2.5b 1076. If some Glyphs data doesn't round-trip, it's a bug. Also, if you edit the Python objects (= instances of GS* classes) before writing to .glyphs, the diff between the original Glyphs file and the modified one should be minimal and reflect only the changes that were made to the Python objects
The glyphsLib.classes module provides an API that should match the internal API of Glyphs.app. If it doesn't then it's a bug.

That’s a nice to summarize it :-)

are we ready to release 2.0?


Magic number

Most cli calls require the magic number.
It would be good to have a section explaining what this is and why it is required.

the difference between --testnet-magic and --network-magic

Noted.  Mentioned in Exercise 2, but should be in the tutorials

There already was a brief explanation in the transaction tutorial, but I added another sentence.


fixes and untraslated phrases

fixes and untraslated phrases

@qubabos Can you have a look at the conflicts and resolve them?


Implement FlipFlop in Python

Tried to simplify the convoluted game logic (lots of goto's) a bit.
Probably some cleanup still possible.

Excellent, removing GOTOs is what it's all about :) Thank you!! 👏


add Spanish localization support

Add support for localization in Spanish. I move the json language files to the assets folder because I think it makes more sense since from the pubspec.yaml file you have to add them to "assets".

Awesome. Yeah, assets makes more sense. I didn't see you add this until after I added Russian and organized the local_setup a little. If you don't mind pulling the newest changes and resolving the conflicts, that would be awesome.


[Bug] Tested the latest build after cmd4 upgrade, however I am seeing "My_Thermostat Cannot convert value:  to Float for TargetTemperature"

Describe The Bug:
After upgrading the cmd4 to the latest version, I find no issue in firing commands from Home app.
However from the log, I am always seeing "My_Thermostat Cannot convert value:  to Float for TargetTemperature"
My settings is with One Constant zone and with no temp sensor.
To Reproduce:
N/A
Expected Behaviour:
There shouldn't be any temperature feedback.
Probably some field is missing as there is no variable "cannot convert value: ?? to Float for TargetTemperature"? I also found that it's coming in at an interval of 60, so it might be related to the last block of code
Link to Logs:

Cmd4 Config:

Environment:
Node.js Version v14.15.5
Npm Version  v6.14.11
Homebridge Version v1.1.7
Operating System: Raspbian

a piece of sample getSystemData with no temp sensor for your reference. Thanks heaps

I will have a look at this one for you tomorrow, I have seen it once or twice myself but never at the interval and constantly. My best guess is that the ‘Get’ command has returned ‘Null’ value instead of a reading; which the controller sometimes returns (had to put a ‘wild card’ return case for the modes because of this). Strange as the ‘reading’ should just be the value set for temperature in the main area of the app.
Two things to try before I get back to you:

Restart the tablet that has the main controlling app.
If you haven’t already, set "restartRecover": false to clear the cache of the old cmd4 accessories you had, so that it creates the new cmd4 accessories (don’t think this is your problem but worth checking you did it)

oh i thought you are in the east coast and didn't expect a reply from late night!
Just tried to reboot the tablet / restarted homebridge / and actually I had a corrupted Pi so I did a fresh install.
[2/11/2021, 1:00:42 AM] [Cmd4] My_Thermostat Cannot convert value:  to Float for CurrentTemperature
[2/11/2021, 1:00:42 AM] [Cmd4] My_Thermostat Cannot convert value:  to Float for TargetTemperature

Still showing the same error messages but I'll keep monitoring and try to tweak the .sh scripts tonight

btw i tried to copy the previous sample_config.json from your second last build (which I used previously), and still similar result is showing too. Another potential cmd4 issue?

 Sorry to hear about the corrupted SD card on your Pi; that is always a pain!
I can see a little mistake in the shell script but it is not anything that would cause the issue you are seeing; also found an opportunity to reduce one less command being sent to the control unit for the 'no temperature sensors' shell script.
I have also just swapped over to the single zone no temperature sensor shell script and I am not seeing the warning come up; especially not in the interval you are seeing.

Are you seeing anything funny on the GUI in HomeKit for the Thermostat? Typically if it is having an issue it will 25.0deg as the temperature. In your case the temp reading is what ever you set the temp, so if it is not showing the value on the front of the main app and is showing 25.0deg in HomeKit then there is an issue.

Ok so further confirmation from the developer of homebridge-cmd4 is that this error is being generated due to how cmd4 receives everything as a string and then converts that to the appropriate data type; zero is also represented by null and this is where he thinks the issue is.
This also means that for some reason you are getting a reading of null quite frequently; which is not good and not something I am experiencing myself. Are you using my config and shell script exactly as they are found? If not can you please paste them here for me to inspect? The polling in the screenshot looks correct.

sorry for late reply, fixing the corrupted pi almost messed up my circadian clock and i am losing track of time.
So I am now using the new CMD4, with the new json updated.
There's one thing I've noticed is that the Home app is not UNable to get the status of the current e-zone,
say for instance, if the fan is ON (triggered on the wall mount tablet), the fan icon in Home would remain OFF.
However, firing commands via Home app is still working.

https://drive.google.com/drive/folders/1Yd08ogzSf6PDyYblXOiR1ERvu4a9LdKu?usp=sharing
Here's the ezone/zone.sh I am using, I've also attached the config for your ref. Thanks mate!

It sounds like you are experiencing what I was experiencing when I first went to cmd4 v3.0.x; where the status for the fan and switches were inverted, but that was fixed in cmd4 now so it cannot be the same issue. I have just followed the same sequence of events you described and mine is working correctly.
Your config.json is correct. What I wanted to be 100% sure is that you had "restartRecover": false to clear the cache and create new accessories in v3.0.x; this can now be set to true from now on. You also have "outputConstants": false which is needed and when set to true was causing issues with the On characteristic.
Your shell scripts are exactly the ones from the repo with the mistake I mentioned earlier fixed (good spotting on that one!). I honestly cannot see anything wrong with your setup and would expect yours to act the same as mine (even though I have temp sensors I should see the same results as you using the same shell script).
The next thing we could get you to do is run Homebridge in Debug mode and see if there is anything we can catch in those logs.

Also out of curiosity; is your Pi connected over Wi-Fi or Ethernet and what HomeHub are you using? Is that connected over Wi-Fi or Ethernet?

I've now turned restartRecover to true and see if that would help. My pi is with ethernet, albeit its connected to a mesh satellite with lan cable. I am using my appletv as the homehub, and my ipad as the backup one.
btw I think i've foudn the culprit, I've missed the step to install jq.... please accept my apologies as I've overlooked the steps when recovering the pi. sorryyyyy about about the mess.
The message "My_Thermostat Cannot convert value: null to Float for CurrentTemperature" is still showing when I first restart the homebridge service. However, It's not coming in at the 60 sec interval. I'll monitor it for today and get back to you! really appreciate that Mitch, and we'll be good to have our mask takne down by tomorrow!

Oh boy... Yep that would be your problem! Lol I did find it so strange that you weren’t seeing null in your error message of [Cmd4] My_Thermostat Cannot convert value:  to Float for CurrentTemperature as mine when I occasionally see it would see null in the the blank space.
I will say you will still see this error occasionally (I will come up with a method to get rid of this) as it’s an issue with first the data it receives when it first polls the control unit (I assume we don’t get what we are after in the time frame we want it and then we get the value after). I  confident you will no longer have it at the polling interval now!
Man I can’t wait to have the mask off! On my days off I just avoid going out too often but at work it’s 12.5hr days with it on and it kills my ears haha

CMD4 got another update to 3.1.0, things are working fine at the moment, except with the more frequent error message though.
Now I am seeing the "null" value now, instead of a blank spacing. But I believe that's more of a CMD4 thing to be resolved!

I only just tried out the new update now; it is to add the feature request I put in for accessory status logs in homebridge logs (set Thermostat to cool, etc).
I am still so confused as to why you get the message so frequently and I do not... I think it is partially a cmd4 thing, but there is something I can do about it on my end when I get the chance :)

Tried to push all the update buttons on the tablet but that doesn't seem to do any update. Does the tablet actually get an OS update? or I can do Apps update only?
Currently I have reverted back to v3.0.15 and it's looking stable and healthy!

It should be just an Android tablet right? Hopefully you can press the little home button and it will take you to the Home Screen. Hopefully on this screen you will see the google play store (should look like a colourful triangle), if not swipe to the other screens to look for it. In the google play store you can update you system as it does gets updated once or more a year. Here you can update any other apps on the tablet too :)

So the recent update of cmd4 to v3.1.2 runs a number of checks for how to handle 'null'; this means that it is most definitely being produced by my shell script or being received from the aircon controller itself. You will have to leave this with me for the time being as I figure out what I need to do take into account a 'null' value received. I am not sure how much time I will have over the next two weeks to work on this, but I will keep you updated if you can hold tight.

I'll try to do the update and see if that'd resolve the mysterious error message then! Really appreciate your hard work !
(just a side track, I cannot connect to the raspberry pi from time to time. I used Pi Hole for my adblock and i found that the pi is unreachable once or twice a day, but then it got back to work after minutes or so. Have you heard of it before, or what keywords should I look for on the web? thanks !)

Let me know how you go :)
I wonder if this other problem is also related to your ‘null’ value problem. That being said I am getting the ‘null’ on occasion. I would maybe try raise the issue with connection on the homebridge repo or if Pi Hole has a repo maybe raise it there? Hopefully someone can help you with that issue!

Just updated to the latest
Homebridge v1.3.0 with CMD4 v3.1.3
The response is now so speedy and as soon as you pushed the button on Home, there is an instant update in the console for switch on true/false. However the log in red looks scary though but i guess it is just cosmetic!

Nice, I still can’t upgrade to homebridge v1.3.0 as one of the plug-ins I use breaks it at this stage. Looking forward to using it and the child bridge functionality.
Those logs started on cmd4 v3.1.3 and I have brought it up to the developer, they should not be popping up at all in my opinion. He is pretty busy at the moment, so hopefully they don’t stick around for long.

The new log i think they are actually providing a better explanation on the issue. It looks like there has to be something to do with the Name? however, in my config file, I believe the names are all set for the switches.
As for the CurrentTemperature TargetTemperature, this is exactly what you've mentioned earlier as they are returning the Null value from the script.

I think the name thing is a little misleading and not an issue. The reason why all of your switches are appearing with the same name "My_Switch" is due to the warning pointing at the property displayName instead of name. For displayName they are all set to "My_Switch" and the name is most likely set to the actual name of your room (e.g. "Living Room").
The whole upgrade of cmd4 to v3.x.x has been quite the wild ride for me and has caused quite a few issues, or perhaps has exposed underlying issues in my work. I am still on the fence that a bunch of these are still issues with cmd4 itself or not... I do hate how it looks like my work is causing a heap of warnings/errors and am struggling to fix them with my skill level. Thankfully the developer of cmd4 has been super awesome, but I think there is still a fair bit of work at hand for myself...

Just updated to the latest
Homebridge v1.3.0 with CMD4 v3.1.3
The response is now so speedy and as soon as you pushed the button on Home, there is an instant update in the console for switch on true/false. However the log in red looks scary though but i guess it is just cosmetic!

@cyrusauyeungc to fix these specific error tables popping up, you will need to add -s to each of the curl commands in  the shell scripts for the set areas (not the get, they should have it). This will need to done in both shell scripts and for all set curl commands.

I don't know how or at what stage I introduced this error. Still working on the "null" problem as I can, but this should reduce some of the issues you are seeing. I will fix it in the next version when I get a chance.

The new log i think they are actually providing a better explanation on the issue. It looks like there has to be something to do with the Name? however, in my config file, I believe the names are all set for the switches.
As for the CurrentTemperature TargetTemperature, this is exactly what you've mentioned earlier as they are returning the Null value from the script.

My comment response to this one was also incorrect about the empty string for name; I now realise what you mean and am looking into it.

I think I am introducing too many problems at a time...

so for now there is 2 issues i am seeing
with the first one coming as a Table, which tells the Time / Speed / Dload / Upload etc.
==> Can i say -s is a fix for this issue?

the second issue would be the " " as an empty string.
==> which would need you to work on and i do appreciate that!

However there is another CMD4 update, i'd see how that goes again! keep testing latest update haha

I think I am introducing too many problems at a time...

It’s all good :)

with the first one coming as a Table, which tells the Time / Speed / Dload / Upload etc.
==> Can i say -s is a fix for this issue?

Yep, just add that like in my screen shot before the -g in each ‘set’ command in both scripts.

the second issue would be the " " as an empty string.
==> which would need you to work on and i do appreciate that!

Yep! I have been super busy but have been trying a few tests here and there when I can.

@cyrusauyeungc just letting you know I have not forgotten about this. I have been extensively working with the developer of cmd4 to try and figure this one out and have been doing a lot of testing. I will let you know when we have a win but it has been a long work in progress so far!

Appreciate that! After updating to the latest CMD4 i was hoping for less error message, but then I am now seeing new message prompts now haha. I am also trying to figuring out where that "Name" property was and see if I could mitigate it.

There are new changes in my script and config that will take advantage of new staggered polling in cmd4 that negates the ‘name’ warnings. Still getting the empty string warnings and working on that. Just to avoid you having to change scripts and config as much as I have been this last month or so; I will wait until we have a more finished product before I flick it through to you :)

@cyrusauyeungc testing has been very promising. The most recent test removed almost all issues with empty string or null readings. The only ones received were when setting a value (which prompts an immediate 'get'); I will be testing a new potential fix that last bit tonight after work. We are getting very close here and am very much looking forward to closing this one out!

Appreciate that and I do hope that this could be closed! unfortunately I'll have to move out of the house very soon, hopefully i'll still have another 40 days due to the crazy rental market in Perth. Looking forward to applying your up-to-date fix and closing it before I move :1st_place_medal: !

Oh damn! I am sorry to hear you are moving on. Hopefully I’ll have some good news in the next day or few :)

@cyrusauyeungc I was hoping to have news for you a lot sooner, this has been crazy to work on to be honest. John and I have been back and forth with all sorts of testing of new scripts for this and new methods of cmd4 to better handle the limitations of this device; we have both learnt a lot about it and the benefits of the improvements in cmd4 will help a lot of other people.
I hope you are still in the house you were renting; but do not feel bad if you have had to move on. I am sorry it has taken this long to put together and wish I could have had something for you sooner. If you still have access to the air con, jump on over to my 'beta' and update your config and script with the ones there. As prior, change your IP address in the script and any other modifications you may have made before. You can find the beta branch by going here:

Glad you're still looking at the issue! However my apologies that the owner has decided to sell the house so I can no longer do testing :( but I really do appreciate that and I might be looking at installing a MyAir in my new place :) !

Bugger I knew I may have been too late, but hopefully you might get your hands on another in the future :) I have someone else who might be able to test this beta for me (outside of myself), then I will push it into the main branch!


[Suggestion] Iguana's Tinker Tweaks - XP

I believe this one falls under Modtweaker...
Anyway, nearly every other aspect of tools can be modified in the scripts, but it looks like tool XP, which is something I assume is being added by Iguana, is not able to be changed via script.
Any chances we could get that one added in?

Correct me if I'm wrong, but can't you just tweak each material's stats using ITT to begin with, including their XP stat?  Why do you need ModTweaker to do this?

I have a modtweaker script that goes in and dynamically updates every (currently editable) value for TiC tools, using a set of equations and variables based on arrays/custom defined difficulty/attack/durability/speed/handle/damage ratings.
While I could edit the values directly in ITT, it's just more valuable to me to be able to add it in my script

Ah, fair enough.  I was under the impression you were just trying to change a stat here and there; carry on.

To make it a bit more understandable:
In my current modpack, I have approximately 98 different valid materials for which I can modify the values of. In ITT, each material is printed out on its own line, and each attribute on its own line. (10 lines per material + 1 buffer space) This ends up being close to about 1100+ lines of things to edit or view. Quite tedious :-1:
My script, however, is a mere 86 lines of code, meaning I have more actual materials being modified, than I have lines of code =P

:o I would very much like to see an example of your changes if you don't mind, do you have them posted anywhere?

The changes themselves are... rather specific for an "RPG" esque genre where monsters get stronger and stronger as you move out from spawn area, or go into other dimensions. (Done via MobProperties)
So the damage values on some of the "Higher End" metals might be quite high is you are just using it as is.

// File Explanation:
/*
	This file is used to auto-calculate all Tinker Tool values on the fly.
	The ratings are based on an "Intended Purpose" basis. Purposes are as followed:
		0 - Multi-purpose Tool
		1 - Weapon focused
		2 - Tool focused (mining/durability)
		3 - Handle focused
		4 - XP Modifier focused (currently not implemented in ModTweaker/MineTweaker)
		5 - Nerf nerf

	When taking these materials into consideration for "intended purpose" copy the values into a spreadsheet from the following arrays:
		materials
		purposeIDs
		difficultyRatings
		dimensionIDs (optional, use if you have a multi-dimension world where certain metals materials be obtained from, or if you want to support materials from The End/Nether/Overworld/Etc)

	Putting these values into a spreadsheet will make your life much easier when trying to line up the values.

	Each material is given a designated "Difficulty of being obtained" where most of the values are calculated based on.
	The rest of the ratings allow for intended purposes to create variation, and extremities for sacrifices in other areas.

	All Credit to: MagisterXero/FiromisCaine

*/

var damageRatings = [3, 7, 1, 1, 1, 1] as int[];
var durabilityRatings = [3, 2, 5, 4, 1, 1] as int[];
var handleRatings = [0.5, 0.2, 0.8, 1.65, 0.3, 0.01] as float[];
var xpRatings = [0.86, 1.0, 0.77, 0.6, 0.35, 0.01] as float[];
var speedRatings = [3, 1, 9, 2, 2, 0] as int[];
var dimensionRatings = [1, 2, 3, 4, 5, 5, 6, 6, 6.5, 7, 7.3, 7.6, 8, 8.5, 9, 9.3, 9.6, 10, 10.3, 10.7, 11, 11.2, 11.5, 11.8, 12, 13, 14, 14, 14] as float[];

var materials = ["Wood", "Cactus", "Cardboard", "Flint", "Paper", "Stone", "Bone", "Certus Quartz", "Iron", "Plastic", "Silver", "Angmallen", "Brass", "Copper", "Lead", "Nickel", "Bronze", "Electrum", "Glue", "Hepatizon", "Manasteel", "Peridot", "Platinum", "Ruby", "Sapphire", "Thaumium", "Yellorium", "Invar", "Slime", "Cyanite", "Damascus Steel", "Ludicrite", "Obsidian", "Alumite", "Amethyst", "BlueSlime", "Blutonium", "Enderium", "Jade", "Limonite", "Rosite", "Signalum", "Steel", "Lumium", "Pink Slime", "Elementium", "Bedrockium", "Terrasteel", "Void Metal", "Nether Quartz", "Netherrack", "Midasium", "PigIron", "Bloodwood", "Darkwood", "Ghostwood", "Fusewood", "Ardite", "Cobalt", "Manyullyn", "Emberstone", "Bloodstone", "Crystalitestone", "Skeletal", "Prometheum", "Fiery", "Ironwood", "Knightmetal", "Steeleaf", "Astral Silver", "Carmot", "Deep Iron", "Black Steel", "Oureclase", "Mithril", "Quicksilver", "Haderoth", "Ceruclase", "Inolashite", "Shadow Iron", "Shadow Steel", "Ignatius", "Vyroxeres", "Orichalcum", "Celenegil", "Vulcanite", "Kalendrite", "Amordrine", "Sanguinite", "Eximite", "Desichalkos", "Atlarus", "Adamantine", "Tartarite", "Ender Amethyst", "Fairy", "Pokefennium", "Red Aurum"] as string[];
var purposeIDs = [0,	1,	4,	1,	4,	1,	0,	0,	0,	0,	4,	4,	2,	2,	2,	0,	0,	4,	4,	0,	1,	1,	2,	1,	1,	1,	0,	1,	3,	0,	1,	3,	2,	1,	1,	3,	0,	2,	2,	0,	3,	2,	1,	2,	3,	0,	3,	4,	1,	1,	0,	4,	0,	1,	2,	0,	1,	0,	2,	1,	0,	1,	1,	0,	0,	1,	2,	1,	4,	4,	3,	1,	1,	2,	0,	4,	1,	0,	1,	0,	1,	0,	0,	2,	1,	0,	0,	1,	1,	0,	1,	4,	0,	1,	3,	4,	0,	1] as int[];
var dimensionIDs = [0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	0,	1,	1,	1,	1,	1,	1,	1,	1,	1,	1,	1,	1,	2,	3,	4,	6,	8,	8,	8,	8,	9,	11,	12,	12,	13,	14,	14,	14,	15,	15,	16,	16,	18,	19,	20,	20,	21,	22,	22,	23,	24,	24,	25,	25,	25,	26,	27,	27,	27] as int[];
var difficultyRatings = [1,	2,	2,	2,	2,	2,	3,	3,	3,	3,	3,	4,	4,	4,	4,	4,	5,	5,	5,	5,	5,	5,	5,	5,	5,	5,	5,	6,	6,	7,	7,	7,	7,	8,	8,	8,	8,	8,	8,	8,	8,	8,	8,	9,	11,	14,	15,	15,	16,	4,	4,	5,	5,	6,	6,	6,	7,	8,	9,	10,	9,	11,	12,	13,	24,	17,	14,	16,	15,	27,	29,	30,	32,	33,	36,	37,	39,	40,	42,	41,	44,	45,	46,	48,	53,	49,	50,	60,	55,	56,	68,	60,	62,	76,	42,	72,	85,	100,] as int[];

for x, material in materials {

	var purposeID = (purposeIDs[x]);
		var damageRating = damageRatings[purposeID];
		var durabilityRating = durabilityRatings[purposeID];
		var handleRating = handleRatings[purposeID];
		var xpRating = xpRatings[purposeID];
		var speedRating = speedRatings[purposeID];
	var difficultyRating = (difficultyRatings[x]);
	var dimensionID = (dimensionIDs[x]);
		var dimensionRating = dimensionRatings[dimensionID];
	print(material + "-- Damage Rating:" + damageRating + " Durability Rating:" + durabilityRating + "-- Handle Rating:" + handleRating + "-- XP Rating:" + xpRating + "-- Purpose ID:" + purposeID + "-- Difficultiy Rating:" + difficultyRating + "-- Dimension ID:" + dimensionID + "-- Dimension Rating:" + dimensionRating);

	var damage = (difficultyRating + (((damageRating + 4) * dimensionRating) + (difficultyRating / 2.5) - 10) / 5);
	var baseDurability = 175 + (((difficultyRating * dimensionRating) * durabilityRating * 2 ) / 3.5);
	var handleModifier = (((handleRating * 8) * dimensionRating + (difficultyRating / 7)) / 11.53);
	var miningSpeed =  (225 * dimensionRating) / 2 + (difficultyRating * ((speedRating * 3) / 2));
	if (miningSpeed == 0) {
		miningSpeed = 40;
	}
	var bowDrawSpeed = 26 + ((90 + baseDurability) / miningSpeed) * 53;
	if (bowDrawSpeed == 0) {
		bowDrawSpeed = 10;
	}
	//var xpModifier = ((5 + (xpRating * dimensionRating)) / (1 + difficultyRating / dimensionRating ) * xpRating);
	//if (xpModifier == 0) {
	//	xpModifier = 0.1;
	//}
	var arrowFlightSpeed = 2 + bowDrawSpeed / 21;
	var weight = (((baseDurability * (damage / 13))) / arrowFlightSpeed / (29 + miningSpeed / (damage + difficultyRating))) + 1;
	var breakChance = ((baseDurability / 100) / weight);

	print(material + "-- Damage:" + damage + " Durability:" + baseDurability + "-- Handle:" + handleModifier + "-- Speed:" + miningSpeed + "-- DrawSpeed:" + bowDrawSpeed + "-- FlightSpeed:" + arrowFlightSpeed + "-- Weight:" + weight + "-- BreakChance:" + breakChance);

	mods.tconstruct.ToolStats.setBowDrawspeed(material, bowDrawSpeed);
	mods.tconstruct.ToolStats.setBowFlightSpeed(material, arrowFlightSpeed);
	mods.tconstruct.ToolStats.setArrowMass(material, weight);
	mods.tconstruct.ToolStats.setArrowBreakChance(material, breakChance);
	mods.tconstruct.ToolStats.setDamage(material, damage);
	mods.tconstruct.ToolStats.setHandleModifier(material, handleModifier);
	mods.tconstruct.ToolStats.setDurability(material, baseDurability);
	mods.tconstruct.ToolStats.setSpeed(material, miningSpeed);
}

Oh wow, yeah that's way more in-depth than I've ever ventured to try in any of the packs I've worked on.  While I won't take it, I'll definitely use it as an example on how to mess with TiC Tool Stats.  Thanks!

That is amazing. And I have no qualms about asking if you care if I use this as a basis for my pack?

Go for it, just remember to leave the comments in, please :)

Wow :amazed:

So yeah Yulife, think you can hook this one up in the next build maybe? xD

Uhm....thats a script though :) I can post it somewhere in the documentation though!

No no, I mean.
Is setting tool XP already implemented via script?

(Yulife is not a coder, ok well he is, but not this stuff... And he isn't a
person with enough power to force me to addsupport for a mod)
It will come, rventually, maybe, will have to look at the api.
On Wednesday, September 9, 2015, MagisterXero<EMAIL_ADDRESS>wrote:

No no, I mean.
Is setting tool XP already implemented via script?
—
Reply to this email directly or view it on GitHub
https://github.com/jaredlll08/ModTweaker2/issues/241#issuecomment-138912844
.

Ahh, okay
Thanks for the update though Jared
I was hoping this one would be a rather simple one

Honestly, it could be easy, I am just fairly busy currently
On Wednesday, September 9, 2015, MagisterXero<EMAIL_ADDRESS>wrote:

Ahh, okay
Thanks for the update though Jared
I was hoping this one would be a rather simple one
—
Reply to this email directly or view it on GitHub
https://github.com/jaredlll08/ModTweaker2/issues/241#issuecomment-138914859
.

No big rush on this one, because of the script I made for setting all the other values, this one is more of a "First world problem". I used a lot of variable equations to calculate the values and force them to be balanced across the board using a designated scaling system, so writing this script assisted in my not needing to muck with stuff manually.

If this can be modified in ITT config why should we bother to support it Modtweaker?
Because this require extra work compared to other TinkersFeatures (this feature sould only available if ITT is present)


Missing v3.0.8 tag

Version 3.0.8 was released a few months ago and  available on NuGet but there is no v3.0.8 tag in the repository

Sorry, I misused the bug template and now I can't remove the bug label 😬

Hi, I created a new release here. The problem is that I don't want to install .net core SDKs for 2.1 or 2.2 in order to build the binaries. I will skip this for the current release and continue with these for 3.0.9.