power-assert feedback

Opening this just to gather some feedback about the new power-assert feature.

test(t => {
	const foo = 'foo';
	t.ok(foo.indexOf('bar') !== -1);
	t.end();
});

t.ok(foo.indexOf('bar') !== -1)
           |
           -1

@twada Any way we could show the value of foo here too? I think that could be useful. @vdemedes What do you think?

This is badass. This might actually make me switch to Ava. :dancer:

@twada
Currently this:
test(t => {
	const b = 'bar';
	const c = 'baz';
	t.is(b, c);
	t.end();
});

Outputs:
t.is(b, c)
       |  |
       |  "baz"
       "bar"

Is there any way to have it output the old simple output when using direct inputs? Meaning no expressions.
Old simple output:
'bar' === 'baz'

That output is faster to look at.

@twada @uiureo I've documented the enhanced asserts. Would appriciate your review.

First, as an author of power-assert, I'm so glad to see this happen! :smile:
Thank you @sindresorhus !

@twada @uiureo I've documented the enhanced asserts. Would appriciate your review. Happy to change anything. 89219ce?short_path=0730bb7#diff-0730bb7c2e8f9ea2438b52e419dd86c9 :)

I think it's well written.

@sindresorhus
t.ok(foo.indexOf('bar') !== -1)
         |
         -1

@twada Any way we could show the value of foo here too? I think that could be useful.

AVA's power-assert output is configured at ava/enhance-assert.js (see renderers section)
If you change powerAssertRenderers.SuccinctRenderer to powerAssertRenderers.DiagramRenderer like below,
	empower(assert,
		powerAssertFormatter({
			renderers: [
				powerAssertRenderers.AssertionRenderer,
				powerAssertRenderers.DiagramRenderer
			]
		}),
		{
			destructive: true,
			modifyMessageOnRethrow: true,
			saveContextOnRethrow: false,
			patterns: module.exports.PATTERNS
		}
	);

You'll get verbose output like
t.ok(foo.indexOf('bar') !== -1)
     |   |              |
     |   |              |
     |   -1             false
     ["toto", "tata", "titi"]

It seems nice to have verbosity configuration options in AVA, and change power-assert renderers according to the option value.

I know I'm asking a lot, but I would like the following not to use power-assert, since it's just direct input.
test(t => {
    const b = 'bar';
    const c = 'baz';
    t.is(b, c);
    t.end();
});

But this should use power-assert since it's an expression and could benefit from the power-assert output.
test(t => {
    const b = 'bar';
    const c = 'baz';
    const d = 'faz';
    t.is(b + d, c);
    t.end();
});

@sindresorhus

Is there any way to have it output the old simple output when using direct inputs? Meaning no expressions.

Currently, t.is is configured to be enhanced by power-assert and power-assert cannot toggle output on and off by captured value for now.
What you mean here is that if two arguments are both in form of Identifier or Literal, and its values are simple primitives, AVA's power-assert feature should be turned off automatically. It is not possible now but worth challenging.

@sindresorhus
Oh I missed your next question!

But this should use power-assert since it's an expression and could benefit from the power-assert output.

test(t => {
    const b = 'bar';
    const c = 'baz';
    const d = 'faz';
    t.is(b + d, c);
    t.end();
});

Thank you for your clear example!
My answer is the same as former one --- It's not possible now, but I'll try to make it happen.

It wouldn't nessecarily have to be turned off, could maybe just change the renderer to not show diagrams when Identifier or Literal is passed. This is just a nitpick/nicetohave, though.

@sindresorhus Thanks, it's getting a bit easier.

@twada is babel-plugin-espower compatible with babel 6?

@vdemedes Not yet. I'm wrestling with Babel6 now.
Almost done but still doesn't work with presets.

Not sure if I should create a new issue for this, but when using promises (await statements), power-assert does not show the correct value.
t.same(await fn(fixture1), {})
             |
             Object{}

The result of the promise is not empty, that's for sure :).

@SamVerschueren Thank you for reporting!
Currently, power-assert only supports ES6/ES2015 expressions. So AwaitExpression is not supported yet and to be supported in next version. BTW, I'll take a look about this behavior.

Thanks for the feedback!

@SamVerschueren Looks like https://github.com/sindresorhus/ava/issues/113.

Sorry, should have looked in the issue list first.

@SamVerschueren No problem!

@SamVerschueren - async/await fix is in master.

Awesome! :+1:

@sindresorhus is there any more feedback you're looking to collect in this issue, or shall we close it?

Yup, can be closed in favor of https://github.com/twada/power-assert-renderers/issues/3.


Gallery of imageMso (Offer)

In my Excel add-in I have a Gallery of the imageMso images that I can click and a macro that puts the control.id in the clipboard so that I can paste it into the XML
Makes it easier than trying to look up the built in image, but if it were built into the editor, it'd be even easier

imageMso.txt
Just a thought

Hi phossler,
Yes, I have seen those type of galleries before (and use the Microsoft one from time to time). I agree it would be handy to have something like that in the tool itself. Perhaps being able to search by text too (sometimes it takes me forever to find an icon I know it should exist).
There are a few obstacles though:

The icons you see depend on the version of office you have. I would prefer if you could switch between versions as well
Even having a single version of those icons would mean lots of embedded resources in the tool. Not sure if there is a straight source somewhere where I can pick them easily, or if it is would end up being a fairly manual process (in which case I probably won't do it :sweat_smile:)

I'll see what I can do, but you might need to keep using the external spreadsheets / websites like this one for a while (a link to that is in the help menu of the tool).
Regards,
Fernando

No problem

seconding!


Project Structure: Link general README in exercise README

[x] I have thoroughly read and understand The Odin Project Contributing Guide
[x] The title of this issue follows the location for request: brief description of request format, e.g. Exercises: Add exercise on XYZ

The following checkbox is OPTIONAL:

[ ] I would like to be assigned this issue to work on it

1. Description of the Feature Request:
The exercise README does not mention the general README that has setup instructions, most importantly rspec ones.
While the Assignment in the lesson does explicitly say to read the general README first, people have been somewhat often mixing them up and having issues related to rspec and more.

2. Acceptance Criteria:

[ ] Having to read the general README first is put at the start of the instructions in the exercise README

3. Additional Information:
nil

Agree we could make this clearer. Easy change if anyone wants to take this on


Bugfix/2369 type qualifier data function args

Submission Checklist

[x] Run unit tests: ./runTests.py src/test/unit
[x] Run cpplint: make cpplint
[x] Declare copyright holder and open-source license: see below

Summary
Allow the use of data as a prefixed type qualifier for function arguments in order to restrict it to be called with only data arguments.
Intended Effect
Allow compile-time detection of errors arising from embedding a call to Stan's ODE functions inside a function call where ODE data-only arguments are derived from arguments passed into the embedding function and the expression used for function invocation includes a parameter, transformed parameters, or model-block variable.
How to Verify
Unit tests.
Side Effects
Function declarations/definition checked for qualifier consistancy.
The function signature argument type object is now a composite of the argument expression type and a boolean which is true if the argument is a data-only argument.  If more qualifiers are added, the boolean can be changed to an enumeration type corresponding to the set of qualifiers (and unqualified).
Documentation
Added section in programming manual, chapter on User Defined Functions.
Reviewer Suggestions
Bob Carpenter, Daniel Lee, Sean Talts.
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: Mitzi Morris

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

@seantalts usual problem - unit tests work on my machine, fail on travis.  is there some workspace cleanup needed?

Fails on both Travis and Jenkins with the same test failure (test/unit/lang/reject/reject_transformed_parameters failed). For future info, Travis starts a new VM from scratch (actually several) for every build, so there's no workspace issues on it ever. Jenkins is also mostly set up to clean the workspace (it is for this particular job) but I'm less confident across the board. But if they're both failing on the same thing I'd say it's pretty likely that thing is busted. Did you maybe forget to check a file or push or something?

I'm looking into the reject test utility, which actually runs the compiled model.

@mitzimorris, don't know if you noticed, but there are now conflicts in src/test/unit/lang/parser/user_defined_functions_test.cpp.

thanks for the heads up.  resolved the merge conflict.

Did this fixed #2369 and #2213? (they are marked as open)

@randommm Yes, when this gets merged, those two should both be fixed (and thus closed).


Add command to configure number of shards.

Changed aws deployment script to automatically set the number of shards.
Created tests.

@vrde can you take a look at this pr.

[Current coverage][cc-pull] is 86.99%

Merging [#258][cc-pull] into [master][cc-base-branch] will decrease coverage by -<.01%

File ...db/commands/utils.py (not in diff) was modified. more

Misses -1
Partials 0
Hits +1

@@             master       #258   diff @@
==========================================
  Files            19         19
  Lines          1092       1099     +7
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            950        956     +6
- Misses          142        143     +1
  Partials          0          0

Powered by Codecov. Last updated by [5c26bb4...9f959fc][cc-compare]
[cc-base-branch]: https://codecov.io/gh/bigchaindb/bigchaindb/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/bigchaindb/bigchaindb/compare/5c26bb439a49ddddfe168442710eea222f65db77...9f959fc6ed50cc2e6398dfd2ac8b066638ba3e56
[cc-pull]: https://codecov.io/gh/bigchaindb/bigchaindb/pull/258?src=pr

Looks good to me.


[SPARK-14021][SQL] custom context support for SparkSQLEnv

What changes were proposed in this pull request?
This is to create a custom context for command bin/spark-sql and sbin/start-thriftserver. Any context that is derived from HiveContext is acceptable. User need to configure the class name of custom context in a config of spark.sql.context.class, and make sure the class in classpath. This is to provide a more elegant way for custom configurations and changes for infrastructure team.
How was this patch tested?
Added a unit test in CliSuite to track this.
cc @chenghao-intel

Test build #53613 has started for PR 11843 at commit 654397e.

Test build #53613 has finished for PR 11843 at commit 654397e.

This patch fails Scala style tests.
This patch does not merge cleanly.
This patch adds the following public classes (experimental):
     log.warn(s\"Configured context class $className is not a subclass ofHiveContext,\" +

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53613/
Test FAILed.

Test build #53614 has started for PR 11843 at commit 864e1b6.

Test build #53614 has finished for PR 11843 at commit 864e1b6.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
     log.warn(s\"Configured context class $className is not a subclass ofHiveContext,\" +

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53614/
Test PASSed.

Test build #54020 has started for PR 11843 at commit 35c7a8f.

Test build #54020 has finished for PR 11843 at commit 35c7a8f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54020/
Test PASSed.

cc @rxin @liancheng

cc @yhuai , this is critical for our own customized HiveContext, can you please merge this?

HiveContext is going to be deprecated in Spark 2.0. Please see https://issues.apache.org/jira/browse/SPARK-13485
I don't think it makes sense to merge this at this point. If you need this, you should do something once SparkSession is introduced.

Let's close this PR since HiveContext is now removed. If there is interest feel free to re-open it and make the changes based on SessionState instead.


Please provide more context for what a "message" is

Please provide more context as to what a "message" is, I think I understand the concept of what a message is (message being a distinct cloud concept of discrete packages?), but the way it's worded seems like it's exclusively to do with a messaging service like say iMessage.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 30921c17-f076-3747-00e4-0615e376a241
Version Independent ID: d637355d-cb58-500f-f05c-d0b48fca4d7a
Content: Introduction to Azure Queue Storage - Azure Storage
Content Source: articles/storage/queues/storage-queues-introduction.md
Service: azure-queue-storage
GitHub Login: @normesta
Microsoft Alias: normesta

@AlexGadd
Thanks for your feedback! We will investigate and update as appropriate.

@AlexGadd
Thanks for your contribution. Please add your feedback in below link, so our production team can review it and update the same.
feedback · Community (azure.com)


Automate release, workaround macOS CI errors

Includes

Add automatic release workflow as per #178
Symlink gfortran dylibs to /usr/local/lib on macOS CI so PRMS binaries included in this repo can find them. The current installation in CI via awvwgk/setup-fortran puts libs in /usr/local/opt/gcc/lib/gcc/{version} by default
fix pydot usage in pywatershed/analysis/model_graph.py causing CI errors

The workflow currently assumes the repo adopts the same branching scheme as FloPy, where development happens on develop and code is merged to main at release time, while currently the repo merges PRs directly to main
If we adopt the distinction between trunk and development branch this should be good to go and the workflow will be triggered when a branch matching semver format with leading "v" (e.g. v0.1.3) is pushed. If we want to stick to the existing scheme and not introduce a development branch, I can update the workflow to trigger on a different condition, e.g. when commits on main are tagged as release candidates with semver number.
Before merging I can tack on some release docs

Codecov Report

Merging #179 (056e6cc) into main (426171b) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

:exclamation: Current head 056e6cc differs from pull request most recent head 8e75235. Consider uploading reports for the commit 8e75235 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
- Coverage   77.24%   77.23%   -0.02%
==========================================
  Files          50       50
  Lines        6347     6347
==========================================
- Hits         4903     4902       -1
- Misses       1444     1445       +1

Impacted Files
Coverage Δ

pywatershed/analysis/model_graph.py
10.43% <0.00%> (ø)

... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thank you, Wes!
I prefer to only have a main branch which we will snapshot to version branches.

The last step assumes most releases are minor (back-compatible features) and drafts a PR setting minor number +=1 patch 0 but it doesn't merge, for hotfixes or major releases the PR could be closed. But maybe it is better to just remove this and keep placeholder values in version files in main like you say and only set them for releases?

Hey guys, I know I'm late to the party here, but it if there is any way to set this all up to follow the approach that we have for MODFLOW and FloPy, I think that would be best.  We have a versioning approach and release strategy with main, develop, and tags.  We do not typically go back and make hot fixes to previous releases; instead we are always moving forward.  If we want to rethink that for EC in general, then we should, but otherwise we should try and stick with our current recipe.  My 2 cents.

Thank you, Wes! I prefer to only have a main branch which we will snapshot to version branches.

I don't think there should be version branches. The commit with the version will be tagged and the release will point to a specific commit. So it will always be possible to get the source for a specific release.
Version branches are also inconsistent with all of our other repositories.

Version branches are required for the workflow. They can then be deleted.
Me, Wes, and Chris just decided to make everything consistent with flopy with one minor exception of the version in version.txt being x.y.z+ on the develop instead of the same or ahead of x.y.z on main.

@jdhughes-usgs i assume you're good with the above. LMK if otherwise

@jdhughes-usgs i assume you're good with the above. LMK if otherwise

I am ok with it being like flopy, mf6, etc.
The version branches would be deleted since they are not needed after a release is made.

Version branches are required for the workflow. They can then be deleted.
Me, Wes, and Chris just decided to make everything consistent with flopy with one minor exception of the version in version.txt being x.y.z+ on the develop instead of the same or ahead of x.y.z on main.

x.y.z+ on develop is ok. To be most useful would be great if it could be x.y.z+commit_hash on develop. @w-bonelli is there is a way this could be done as part of CI? If we could get this to work we could propagate this to the other repos.

Version branches are required for the workflow. They can then be deleted.
Me, Wes, and Chris just decided to make everything consistent with flopy with one minor exception of the version in version.txt being x.y.z+ on the develop instead of the same or ahead of x.y.z on main.

x.y.z+ on develop is ok. To be most useful would be great if it could be x.y.z+commit_hash on develop. @w-bonelli is there is a way this could be done as part of CI? If we could get this to work we could propagate this to the other repos.

@w-bonelli But we don't have to hold up this PR to implement this, if possible. Maybe this becomes an issue here or in flopy if you think it is possible.

Version branches are required for the workflow. They can then be deleted.
Me, Wes, and Chris just decided to make everything consistent with flopy with one minor exception of the version in version.txt being x.y.z+ on the develop instead of the same or ahead of x.y.z on main.

x.y.z+ on develop is ok. To be most useful would be great if it could be x.y.z+commit_hash on develop. @w-bonelli is there is a way this could be done as part of CI? If we could get this to work we could propagate this to the other repos.

what is the commit hash, that of the current revision? it's hard/impossible to know the commit hash in advance of committing.

Version branches are required for the workflow. They can then be deleted.
Me, Wes, and Chris just decided to make everything consistent with flopy with one minor exception of the version in version.txt being x.y.z+ on the develop instead of the same or ahead of x.y.z on main.

x.y.z+ on develop is ok. To be most useful would be great if it could be x.y.z+commit_hash on develop. @w-bonelli is there is a way this could be done as part of CI? If we could get this to work we could propagate this to the other repos.

what is the commit hash, that of the current revision? it's hard/impossible to know the commit hash in advance of committing.

May not be possible but a google search found this https://github.com/marketplace/actions/commit-hash

We have a flopy issue on this topic. Two potential solutions are

versioneer
setuptools_scm

I think https://github.com/marketplace/actions/commit-hash can extract version+hash for consumption by other tools (e.g. Docker) but cannot automatically embed a fine-grained version string in the module, which seems like what we want.

I think this is ready. The procedure is described in .github/RELEASE.md. Here is a test run on my fork:

Initial run triggered on v0.1.3 branch push
Release PR opened from release branch into main. The changelog only shows 1 commit because currently git-cliff is configured to filter out non-conventional commit messages, and omit CI-related commits — see flopy releases for an example of what this will look like in practice.
Run triggered by publishing the release drafted by the initial run. The publish step failed because my fork is not configured for trusted publishing, it should succeed on this repo
Reset PR opened into develop

The publish step assumes a pypi deployment environment exists and this repo is configured on PyPI for trusted publishing (I did both). There is no need to store PyPI credentials as repo secrets.

In the test run above, the workflow mistakenly leaves a "+" in version.txt in the released version, and increments the patch version number on the final reset PR, both of which were unwanted leftovers from the flopy approach. I just fixed the former and removed the latter step, so the workflow now follows the procedure as described in .github/RELEASE.md (no more incrementing the patch). Also bumped pywatershed/version.py back down to 0.1.2 since that is the most recent released version.

@w-bonelli are you satisfied with the PR now? If so I will merge unless @jmccreight objects.

This PR almost closes #165.

Wes, this is awesome. Thanks for all your work on this.
I did your "what's new" notes for you, in case you were curious to see that.
I'll merge this after all the tests pass again.
closes #178

@jmccreight sure thing. Thanks, sorry, forgot to do the what's new!


Help files should be UTF-8 encoded

Can we test help files in the modules, both XML and TXT, to assure that the encoding is UTF-8? There should be an error if it has any other encoding.

Good idea! I'd like to see this check ps1, psm1, psd1, and ps1xml file encodings as well, warning on any files that are not UTF-8 encoded.

Thanks @juneb and @KirkMunro for the suggestions! We will consider adding the rule to verify the encoding.

Does it have to be UTF-8 with BOM? There are still lots of tools out that that don't handle BOM well.

@KirkMunro You do realize that the PSD1 file generated by New-ModuleManifest is Unicode and not UTF-8.  So I don't think it would be such a good idea to require UTF-8 for these files.  In general, PowerShell creates Unicode files and not UTF-8 files.
WRT to text files, ASCII files are valid UTF-8  files sans BOM as long as they stick to the range 0x00 - 0x7F.

@rkeithhill: That's odd, and no, I hadn't realized that. ISE saves using UTF-8 by default, as did PowerGUI, and PowerSE.  Why would New-ModuleManifest create a UTF-16 file then?  I know there were some issues with which encoding was being used in the past, wrt to the editor that was used -- IIRC ISE couldn't open files with certain encodings.
At any rate, you're right, for most cmdlets, the default value for -Encoding is Unicode (UTF-16).  There isn't enough consensus here to form a rule for PowerShell files though.  Maybe for XML files, since XML's encoding should match the encoding identified inside at the top of the xml file.

My recommendation applied only to help files, which are expected to be UTF-8, not to other file types.

The new rule is implemented with https://github.com/PowerShell/PSScriptAnalyzer/pull/288


Question: PROTOCOL_VERSION vs INIT_PROTO_VERSION?

I've posted this twice on reddit (r/dogecoindev, r/coindev) but haven't gotten any responses :cry: :
So, version.h defines two constants, PROTOCOL_VERSION and INIT_PROTO_VERSION. PROTOCOL_VERSION seems self-explanatory, but for INIT_PROTO_VERSION there's a comment: "initial proto version, to be increased after version/verack negotiation". Does anybody know why that happens? What's the point of initially giving a bogus version then immediately changing it?

If you haven't gotten an answer, then probably nobody knows ;) Regardless, this is a change that predates even Dogecoin's creation, see the upstream PR here: bitcoin/bitcoin#3155.
Maybe try the bitcoin stackexchange. Closing since this is an issue tracker, not a knowledge base.


Watch Variables can't be resolved after a Debugging Restart and Debugger does not start

Hallo,
I have noticed that when I add a Variable to the Watch Window the Debugger is not able to resolve this Variable when I restart the Debugger and the Debugging will not be started.
My concrete use case:
1.) Start Debugger
2.) Add Variable to Watch Window -> no problem, variable value will be resolved
3.) continue debugging (some steps)
4.) restart the debugger -> debugger can't resolve variable and does not start debugging
In the Watch window appears the following error message:
TypeError: Cannot read property 'stdin' of undefined
    at BashDebugSession.evaluateRequest (/home/brosche/.vscode/extensions/rogalmic.bash-debug-0.0.5/out/bashDebug.js:319:29)
    at BashDebugSession.DebugSession.dispatchRequest (/home/brosche/.vscode/extensions/rogalmic.bash-debug-0.0.5/node_modules/vscode-debugadapter/lib/debugSession.js:424:22)
    at BashDebugSession.ProtocolServer._handleData (/home/brosche/.vscode/extensions/rogalmic.bash-debug-0.0.5/node_modules/vscode-debugadapter/lib/protocol.js:104:38)
    at Socket.<anonymous> (/home/brosche/.vscode/extensions/rogalmic.bash-debug-0.0.5/node_modules/vscode-debugadapter/lib/protocol.js:24:60)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
    at readableAddChunk (_stream_readable.js:176:18)
    at Socket.Readable.push (_stream_readable.js:134:10)
    at Pipe.onread (net.js:543:20)

I was able to reproduce this.
Please try following package to check the fix:
bash-debug-0.0.5.vsix.zip
code --install-extension bash-debug-0.0.5.vsix

Hello,
the Bug is bassically gone.
I can now restart the Debugging without any issues.
During my checks I have noticed another problem.
I have added a Variable to the Watch Window which is called DebPath.
The Watch Windows shows the following value:
DebPath = 'declare -- DebPath="/sdcard/linux-image-4.1.0-rt-lenze-i900-rescue_4.1.15-20160316_armhf.deb"'
Probably there is a issue in the parsing of the value. For my understanding it should look like:
/sdcard/linux-image-4.1.0-rt-lenze-i900-rescue_4.1.15-20160316_armhf.deb
When the value is not defined resp. assigned it looks like:
DebPath = 'DebPath'
It think it would be event better and more consistent when the value is not defined / assigned to show just:
not available
This corresponds to the same value when the Debugging has been stopped.
Best regards, Daniel...

I am connecting watch and peek features of debug adapter to "examine" command of bashdb. It will return those "declare .." words if watch is "DebPath", not "$DebPath". However, I noticed that the expression name  "DebPath" is redundant in response, so I will remove it so that only value is shown in single quotes.
I will need to properly document how watch works, since i do not want to make any workarounds related to the problem at this point...

Is this fix already public available in Form of a Release?

v0.0.7 should contain all the fixes I could do for now.


Local gateway rarely transacts join-req/uplinks

Describe the bug
Since Aug 3rd update, having specific issue with Stable Vinyl Chicken rarely responding to confirmed uplinks and join-requests from multiple (10+) local devices.  A rotating handful of adjacent gateways randomly end up "obtaining" the uplink and sending response, however many of these gateways are at the edge of reception (~ -120RSSI / -12.5SNR) so the device often misses the acknowledge and falls back into a join-state.  Stable Vinyl Chicken is on-site and has ~-60RSSI and is transacting other packets on Helium but no longer reliably obtains packets from the nearby devices.
To Reproduce
Device Info (please complete the following information):

Production VIP Console
Console Device ID: 7dc322ed-b74a-4f9b-ae31-a609dee2deff
Device dev eui / app eui:  B460775090000591 / B460775000000090
How often is device sending data:  Every 3 hours, plus whenever sensor triggered.
Region:  US915SB2
Hotspots (names) used to transfer data:  Stable Vinyl Chicken

Additional context
Gateway is Bobcat-300.  It has been rebooted several times, and factory-reset once.  No change in behavior.  Ota Firmware version <IP_ADDRESS>.    Could it be that backhaul latency is high and this gateway no longer secures the packet??  However the timing of these symptoms seems correlated to the recent update.  Tried increasing the RX delay in the device profile to 2 seconds / 5 seconds with no change in end-behavior.
Screenshots

Multiple hotspots may pick up the same packet, and only the first one that delivers the packet to the LNS will be shown on the console. Sometimes a hotspot may have really good rf stats, but it may simply be too slow when trying to deliver the packet to LNS. You could enable multi-packet config so that there is more leeway in the packet delivery process, and you can follow the tutorial here :)


Adjust heading for clarity

@QuinnRadich - Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Native AOT warnings

NLog 5.2 just got released, which removes trim warnings.
Therefore, all issues related to that got closed, namely https://github.com/NLog/NLog/issues/5198 and https://github.com/NLog/NLog/issues/3777.
However, compiling for Native AOT still gives AOT warnings. Is this a separate topic, or was that intended to be fixed in 5.2 as well?
Here's a screenshot of a very simple reproduction. I can put the repro on github if needed.

NLog version: 5.2.0
Platform: .NET 7

NLog uses compiled expression trees to optimize speed for doing object-reflection of custom logging-objects. Ex:
var v = new { Amount = 108, Message = "Hello" };
_logger.Info("{@Hello}", v);  // Uses reflection

I'm guessing that is also why your build also warns about System.Linq.Expressions is part of the build, because it is referenced by NLog.
When reading about PublishAOT then it says:

Requires trimming
No dynamic loading (for example, Assembly.LoadFile).
No run-time code generation (for example, System.Reflection.Emit).
System.Linq.Expressions always use their interpreted form

When using PublishAOT then there is no JIT-compiler available for optimizing Expression-Trees, and I'm guessing that is why that warnings are generated.
I'm not sure there is anyway to work-around this, besides waiting for NLog v6 that hopefully will extract the use of Expression-Trees into a separate nuget-package. Or maybe Microsoft will optimize their support for Expression-Trees in NET8 / NET9 so it no longer gives build-warnings. Until that happens, then you have to live with using PublishReadyToRun
If you find places where NLog can be optimized in regard to trimming / ready-to-run / AOT, then pull-requests are most wellcome.

Getting the following warnings from NLog TestTrimPublish-example-project when using <PublishAot>true</PublishAot>´ with net7.0`:
3>"C:\Users\snakefoot\.nuget\packages\runtime.win-x64.microsoft.dotnet.ilcompiler\7.0.5\tools\\ilc" @"obj\Release\net7.0\win-x64\native\TestTrimPublish.ilc.rsp"
3>NLog.Layouts.LayoutParser.ParseLayoutRendererPropertyValue(ConfigurationItemFactory,SimpleStringReader,Nullable`1<Boolean>,String,PropertyInfo): Using member 'System.Type.MakeGenericType(Type[])' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. The native code for this instantiation might not be available at runtime.
3>NLog.Layouts.ValueTypeLayoutInfo.CreateTypedLayout(Type,Object): Using member 'System.Type.MakeGenericType(Type[])' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. The native code for this instantiation might not be available at runtime.
3>NLog.Internal.ObjectReflectionCache.TryLookupExpandoObject(Object,ObjectPropertyList&): Using member 'System.Type.MakeGenericType(Type[])' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. The native code for this instantiation might not be available at runtime.
3>NLog.Internal.PropertyHelper.TryNLogSpecificConversion(Type,String,ConfigurationItemFactory,Object&): Using member 'System.Type.MakeGenericType(Type[])' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. The native code for this instantiation might not be available at runtime.
3>NLog.Internal.PropertyHelper.CreateCollectionHashSetInstance(Type,Object,MethodInfo&): Using member 'System.Type.MakeGenericType(Type[])' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. The native code for this instantiation might not be available at runtime.
3>NLog.Internal.PropertyHelper.CreateCollectionHashSetInstance(Type,Object,MethodInfo&): Using member 'System.Type.MakeGenericType(Type[])' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. The native code for this instantiation might not be available at runtime.
3>NLog.Internal.PropertyHelper.CreateCollectionListInstance(Type,MethodInfo&): Using member 'System.Type.MakeGenericType(Type[])' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. The native code for this instantiation might not be available at runtime.
3>NLog.Internal.PropertyHelper.CreateCollectionListInstance(Type,MethodInfo&): Using member 'System.Type.MakeGenericType(Type[])' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. The native code for this instantiation might not be available at runtime.
3>NLog.Internal.PropertyHelper.ExtractHashSetComparer(Object,PropertyInfo): Using member 'System.Type.MakeGenericType(Type[])' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. The native code for this instantiation might not be available at runtime.
3>Assembly 'System.Linq.Expressions' produced AOT analysis warnings.
3>Assembly 'System.Private.Xml' produced AOT analysis warnings.

Closing as duplicate of #3366

Current work-around is adding NLog to rd.xml:
<Project>
  <ItemGroup>
      <RdXmlFile Include="rd.xml" />
  </ItemGroup>

</Project>

rd.xml:
<Directives xmlns="http://schemas.microsoft.com/netfx/2013/01/metadata">
  <Application>
        <!-- .NET Native fix -->
        <Assembly Dynamic="Required All" Name="NLog"/>
  </Application>
</Directives>


raise AssetNotSaved with proper message

This fixes the annoying AssetCloud::AssetNotSaved:         AssetCloud::AssetNotSaved: AssetCloud::AssetNotSaved that gets thrown when you do store! on an asset that's invalid. This is especially irksome when trying to go red-green TDD coz the error gives no idea why the saving failed.
@Thibaut @karlhungus

:+1:


[broker] Optimize blocking backlogQuotaCheck to non-blocking in ServerCnx#handleProducer

Motivation
Currently, when broker receive "Producer" command,  it will check the topic if "isBacklogQuotaExceeded".
While in PersistentTopic#isBacklogQuotaExceeded, isTimeBacklogExceeded is used, in which will turns to a blocking operation if "isPreciseTimeBasedBacklogQuotaCheck" is set as true.
The blocking operations in pulsar io threads may impact broker performance, this PR optimized this blocking procedure to async mode.
Modifications
Add "CompletableFuture checkTimeBacklogExceeded()" in PersistentTopic for the async check procedure.
Update corresponding method calls to async mode in ServerCnx#handleProducer.
Verifying this change

[x] Make sure that the change passes the CI checks.

This change is already covered by existing tests, such as org.apache.pulsar.broker.admin.TopicPoliciesTest and org.apache.pulsar.broker.service.BacklogQuotaManagerTest
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?

[x] no-need-doc

Only code optimize.

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

@codelipenghui @hangc0276 @congbobo184  Please help take a look.

@Jason918 Do you want the resolve the conflicts?

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

@eolivelli PTAL

@eolivelli Please help review this PR again

/pulsarbot run-failure-checks

@eolivelli Please help review this PR again


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_67mtlhu9gu/clone/recipe/meta.yaml:17: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_67mtlhu9gu/clone/recipe/meta.yaml:22: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_67mtlhu9gu/clone/recipe/meta.yaml:29: missing_pip_check: For pypi packages, pip check should be present in the test commands
Errors were found


Running Tesla Commands from Home Assistant does not work

Version of the custom_component
latest
Describe the bug
I'm trying to start and stop charge from home assistant but it does not work, logs below

Debug log
Warning! Logs in italian language!

Registratore: homeassistant.components.websocket_api.http.connection
Fonte: components/websocket_api/commands.py:239
integration: Home Assistant WebSocket API (documentazione, problemi)
Prima occorrenza: 13 marzo 2024 alle ore 23:45:03 (5 occorrenze)
Ultima registrazione: 00:17:17

[139675757021120]
[139675626396736]
[139675593994944]
[139675593440704]
[139675637387584]
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 239, in handle_call_service
    response = await hass.services.async_call(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/core.py", line 2319, in async_call
    response_data = await coro
                    ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/core.py", line 2356, in _execute_service
    return await target(service_call)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 905, in entity_service_call
    single_response = await _handle_entity_call(
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 975, in _handle_entity_call
    result = await task
             ^^^^^^^^^^
  File "/config/custom_components/tesla_custom/switch.py", line 114, in async_turn_on
    await self._car.start_charge()
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/car.py", line 1113, in start_charge
    data = await self._send_command("START_CHARGE")
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/car.py", line 775, in _send_command
    raise ex
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/car.py", line 760, in _send_command
    data = await self._controller.api(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/controller.py", line 1317, in api
    response = await self.__post_with_retries(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/tenacity/_asyncio.py", line 88, in async_wrapped
    return await fn(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/tenacity/_asyncio.py", line 47, in __call__
    do = self.iter(retry_state=retry_state)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/tenacity/__init__.py", line 325, in iter
    raise retry_exc.reraise()
          ^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/tenacity/__init__.py", line 158, in reraise
    raise self.last_attempt.result()
          ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/concurrent/futures/_base.py", line 449, in result
    return self.__get_result()
           ^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/concurrent/futures/_base.py", line 401, in __get_result
    raise self._exception
  File "/usr/local/lib/python3.12/site-packages/tenacity/_asyncio.py", line 50, in __call__
    result = await fn(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/controller.py", line 1340, in __post_with_retries
    return await self.__connection.post(command, method=method, data=data, url=url)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/connection.py", line 165, in post
    return await self.__open(url, method=method, headers=self.head, data=data)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/connection.py", line 217, in __open
    raise TeslaException(resp.status_code)
teslajsonpy.exceptions.TeslaException

Hi can you please add in the version of the integration you have installed in home assistant, latest isn't descriptive and given there have been a few releases in the last few days you could be on a few different potential versions.

I have the same problem. I jsut installed this custom component and was hopign to change the Charging amps based on solar production but no commands works (honk,, etc.). I am running the latest version which is v3.20.3 (I just updated) but that problem was also on v3.20.2.
Below are the logs:
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 239, in handle_call_service
    response = await hass.services.async_call(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/core.py", line 2319, in async_call
    response_data = await coro
                    ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/core.py", line 2356, in _execute_service
    return await target(service_call)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 905, in entity_service_call
    single_response = await _handle_entity_call(
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 975, in _handle_entity_call
    result = await task
             ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/button/__init__.py", line 139, in _async_press_action
    await self.async_press()
  File "/config/custom_components/tesla_custom/button.py", line 45, in async_press
    await self._car.honk_horn()
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/car.py", line 850, in honk_horn
    await self._send_command("HONK_HORN", on=True)
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/car.py", line 775, in _send_command
    raise ex
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/car.py", line 760, in _send_command
    data = await self._controller.api(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/controller.py", line 1367, in api
    response = await self.__post_with_retries(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/tenacity/_asyncio.py", line 88, in async_wrapped
    return await fn(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/tenacity/_asyncio.py", line 47, in __call__
    do = self.iter(retry_state=retry_state)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/tenacity/__init__.py", line 325, in iter
    raise retry_exc.reraise()
          ^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/tenacity/__init__.py", line 158, in reraise
    raise self.last_attempt.result()
          ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/concurrent/futures/_base.py", line 449, in result
    return self.__get_result()
           ^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/concurrent/futures/_base.py", line 401, in __get_result
    raise self._exception
  File "/usr/local/lib/python3.12/site-packages/tenacity/_asyncio.py", line 50, in __call__
    result = await fn(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/controller.py", line 1390, in __post_with_retries
    return await self.__connection.post(command, method=method, data=data, url=url)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/connection.py", line 166, in post
    return await self.__open(url, method=method, headers=self.head, data=data)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/connection.py", line 218, in __open
    raise TeslaException(resp.status_code)
teslajsonpy.exceptions.TeslaException

I have the same problem. I jsut installed this custom component and was hopign to change the Charging amps based on solar production but no commands works (honk,, etc.). I am running the latest version which is v3.20.3 (I just updated) but that problem was also on v3.20.2.
Below are the logs:
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 239, in handle_call_service
    response = await hass.services.async_call(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/core.py", line 2319, in async_call
    response_data = await coro
                    ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/core.py", line 2356, in _execute_service
    return await target(service_call)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 905, in entity_service_call
    single_response = await _handle_entity_call(
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 975, in _handle_entity_call
    result = await task
             ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/button/__init__.py", line 139, in _async_press_action
    await self.async_press()
  File "/config/custom_components/tesla_custom/button.py", line 45, in async_press
    await self._car.honk_horn()
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/car.py", line 850, in honk_horn
    await self._send_command("HONK_HORN", on=True)
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/car.py", line 775, in _send_command
    raise ex
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/car.py", line 760, in _send_command
    data = await self._controller.api(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/controller.py", line 1367, in api
    response = await self.__post_with_retries(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/tenacity/_asyncio.py", line 88, in async_wrapped
    return await fn(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/tenacity/_asyncio.py", line 47, in __call__
    do = self.iter(retry_state=retry_state)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/tenacity/__init__.py", line 325, in iter
    raise retry_exc.reraise()
          ^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/tenacity/__init__.py", line 158, in reraise
    raise self.last_attempt.result()
          ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/concurrent/futures/_base.py", line 449, in result
    return self.__get_result()
           ^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/concurrent/futures/_base.py", line 401, in __get_result
    raise self._exception
  File "/usr/local/lib/python3.12/site-packages/tenacity/_asyncio.py", line 50, in __call__
    result = await fn(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/controller.py", line 1390, in __post_with_retries
    return await self.__connection.post(command, method=method, data=data, url=url)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/connection.py", line 166, in post
    return await self.__open(url, method=method, headers=self.head, data=data)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/connection.py", line 218, in __open
    raise TeslaException(resp.status_code)
teslajsonpy.exceptions.TeslaException

I'm in the exact same case with solar optimization. Downgrading to 3.19.11 fixed the issue. I also noticed, twice, that if after a reboot I send a command while the car is awake then it runs fine, even if the cars goes to sleep after a while.

I'm in the exact same case with solar optimization. Downgrading to 3.19.11 fixed the issue. I also noticed, twice, that if after a reboot I send a command while the car is awake then it runs fine, even if the cars goes to sleep after a while.

I have tried that but still the car does not respond to commands. The asleep sensor is off so the car should be awake! It is a newer car (1 week old) in Europe but I don't see the error about requiring the new API.

I have tried that but still the car does not respond to commands. The asleep sensor is off so the car should be awake! It is a newer car (1 week old) in Europe but I don't see the error about requiring the new API.

@flogitgeek can you send any command to your car and get a response? e.g. Unlock doors? If your car is that new there is a strong chance you can't use the unofficial API to send commands

I did some digging into this.
In my case, the error arises when a command is sent to the car when it sleeps. In my case, the command start_charge has been sent by the integration that optimizes my solar production, at 08:54:19. The car was asleep at this time. Sending the command appears to have wake the vehicle, which was reported online one minute later :

However, the command did not wait for the vehicle to be awake and failed instead :
Enregistreur: homeassistant.core
Source: core.py:2335
S'est produit pour la première fois: 08:54:19 (2 occurrences)
Dernier enregistrement: 08:54:21

Error executing service: <ServiceCall switch.turn_on (c:01HS0HMXS63F9ZDBZE6C5AWK1Y): entity_id=['switch.titine_charger']>
Error executing service: <ServiceCall number.set_value (c:01HS0HMXS7745NAKFT51EF1VNE): value=7.0, entity_id=['number.titine_charging_amps']>
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/core.py", line 2335, in _run_service_call_catch_exceptions
    await coro_or_task
  File "/usr/src/homeassistant/homeassistant/core.py", line 2356, in _execute_service
    return await target(service_call)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 905, in entity_service_call
    single_response = await _handle_entity_call(
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 975, in _handle_entity_call
    result = await task
             ^^^^^^^^^^
  File "/config/custom_components/tesla_custom/switch.py", line 114, in async_turn_on
    await self._car.start_charge()
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/car.py", line 1113, in start_charge
    data = await self._send_command("START_CHARGE")
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/car.py", line 775, in _send_command
    raise ex
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/car.py", line 760, in _send_command
    data = await self._controller.api(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/controller.py", line 1348, in api
    await self.wake_up(car_id=car_id)
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/controller.py", line 486, in wake_up
    response = await self.get_vehicle_summary(vin=car_vin)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/controller.py", line 343, in get_vehicle_summary
    await self.api(
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/controller.py", line 1375, in api
    return await self.__post_with_retries_except_unavailable(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/tenacity/_asyncio.py", line 88, in async_wrapped
    return await fn(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/tenacity/_asyncio.py", line 47, in __call__
    do = self.iter(retry_state=retry_state)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/tenacity/__init__.py", line 314, in iter
    return fut.result()
           ^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/concurrent/futures/_base.py", line 449, in result
    return self.__get_result()
           ^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/concurrent/futures/_base.py", line 401, in __get_result
    raise self._exception
  File "/usr/local/lib/python3.12/site-packages/tenacity/_asyncio.py", line 50, in __call__
    result = await fn(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/controller.py", line 1407, in __post_with_retries_except_unavailable
    return await self.__connection.post(command, method=method, data=data, url=url)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/connection.py", line 166, in post
    return await self.__open(url, method=method, headers=self.head, data=data)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/connection.py", line 218, in __open
    raise TeslaException(resp.status_code)
teslajsonpy.exceptions.TeslaException

Similar issue here.
Some commands (flash lights) work, but not the key ones regarding charging.
Tesla software 2024.2.7 (model 3)
Tesla integration software: 3.20.3
HA Core docker 2024.3.1
Enregistreur: homeassistant.components.websocket_api.http.connection
Source: components/websocket_api/commands.py:239
intégration: Home Assistant WebSocket API (documentation, problèmes)
S'est produit pour la première fois: 09:46:35 (1 occurrences)
Dernier enregistrement: 09:46:35

[140334190349248]
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 239, in handle_call_service
    response = await hass.services.async_call(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/core.py", line 2319, in async_call
    response_data = await coro
                    ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/core.py", line 2356, in _execute_service
    return await target(service_call)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 905, in entity_service_call
    single_response = await _handle_entity_call(
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 975, in _handle_entity_call
    result = await task
             ^^^^^^^^^^
  File "/config/custom_components/tesla_custom/switch.py", line 114, in async_turn_on
    await self._car.start_charge()
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/car.py", line 1113, in start_charge
    data = await self._send_command("START_CHARGE")
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/car.py", line 775, in _send_command
    raise ex
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/car.py", line 760, in _send_command
    data = await self._controller.api(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/controller.py", line 1367, in api
    response = await self.__post_with_retries(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/tenacity/_asyncio.py", line 88, in async_wrapped
    return await fn(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/tenacity/_asyncio.py", line 47, in __call__
    do = self.iter(retry_state=retry_state)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/tenacity/__init__.py", line 325, in iter
    raise retry_exc.reraise()
          ^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/tenacity/__init__.py", line 158, in reraise
    raise self.last_attempt.result()
          ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/concurrent/futures/_base.py", line 449, in result
    return self.__get_result()
           ^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/concurrent/futures/_base.py", line 401, in __get_result
    raise self._exception
  File "/usr/local/lib/python3.12/site-packages/tenacity/_asyncio.py", line 50, in __call__
    result = await fn(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/controller.py", line 1390, in __post_with_retries
    return await self.__connection.post(command, method=method, data=data, url=url)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/connection.py", line 166, in post
    return await self.__open(url, method=method, headers=self.head, data=data)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/connection.py", line 218, in __open
    raise TeslaException(resp.status_code)
teslajsonpy.exceptions.TeslaException

Have any of you guys read the information about the latest releases and using the new fleet API for newer Tesla vehicles? The old APi can no longer control cars that Tesla migrated to the Fleet API. The new api requies the latest version and more extensive configuration. Please read the documentation.

Have any of you guys read the information about the latest releases and using the new fleet API for newer Tesla vehicles? The old APi can no longer control cars that Tesla migrated to the Fleet API. The new api requies the latest version and more extensive configuration. Please read the documentation.

I was not getting the error listed in the documentation and wasn't sure if it impacted every regions as people could still use their integration from what I was reading on the home assistant forum.
Maybe be best to update the documentation to clarify better?

Have any of you guys read the information about the latest releases and using the new fleet API for newer Tesla vehicles? The old APi can no longer control cars that Tesla migrated to the Fleet API. The new api requies the latest version and more extensive configuration. Please read the documentation.

I thought about it, but the error seemed different, so I added my input.
If I read the doc right, the new setup requires an add-on that won't be easy to install on a core HA, that will be the challenge of the day

Have any of you guys read the information about the latest releases and using the new fleet API for newer Tesla vehicles? The old APi can no longer control cars that Tesla migrated to the Fleet API. The new api requies the latest version and more extensive configuration. Please read the documentation.

I thought about it, but the error seemed different, so I added my input. If I read the doc right, the new setup requires an add-on that won't be easy to install on a core HA, that will be the challenge of the day

Actually, I was able to set the new solution up on my HA pi which is just a standard SD image setup. The challenge was more about getting all the domains into the right add on and performing steps in the right order despite the nested addons.

Have any of you guys read the information about the latest releases and using the new fleet API for newer Tesla vehicles? The old APi can no longer control cars that Tesla migrated to the Fleet API. The new api requies the latest version and more extensive configuration. Please read the documentation.

I thought about it, but the error seemed different, so I added my input. If I read the doc right, the new setup requires an add-on that won't be easy to install on a core HA, that will be the challenge of the day

Actually, I was able to set the new solution up on my HA pi which is just a standard SD image setup. The challenge was more about getting all the domains into the right add on and performing steps in the right order despite the nested addons.

My setup is HA in a docker behind a nginx proxy manager on another machine.
I am convinced there must be a way to set a Tesla api proxy up, but just haven't found how yet.

Have any of you guys read the information about the latest releases and using the new fleet API for newer Tesla vehicles? The old APi can no longer control cars that Tesla migrated to the Fleet API. The new api requies the latest version and more extensive configuration. Please read the documentation.

I thought about it, but the error seemed different, so I added my input. If I read the doc right, the new setup requires an add-on that won't be easy to install on a core HA, that will be the challenge of the day

Yes, Fleet Api requires a complex setup, i don't know if the effort will be worth the result...

I have to add that i run no business so i cannot register to developer portal at all

+1 on this issue. A few weeks back my car stopped responding to commands. All sensor data seems to work just fine. But pressing any button, toggle, dropdown, etc... nothing. Just get a similar error. Makes me sad, this is my favorite integration.
Source: components/websocket_api/commands.py:239
integration: Home Assistant WebSocket API (documentation, issues)
First occurred: 12:50:24 PM (1 occurrences)
Last logged: 12:50:24 PM

[546532505024]
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 239, in handle_call_service
    response = await hass.services.async_call(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/core.py", line 2319, in async_call
    response_data = await coro
                    ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/core.py", line 2356, in _execute_service
    return await target(service_call)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 905, in entity_service_call
    single_response = await _handle_entity_call(
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 975, in _handle_entity_call
    result = await task
             ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/button/__init__.py", line 139, in _async_press_action
    await self.async_press()
  File "/config/custom_components/tesla_custom/button.py", line 56, in async_press
    await self._car.flash_lights()
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/car.py", line 846, in flash_lights
    await self._send_command("FLASH_LIGHTS", on=True)
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/car.py", line 775, in _send_command
    raise ex
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/car.py", line 760, in _send_command
    data = await self._controller.api(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/controller.py", line 1367, in api
    response = await self.__post_with_retries(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/tenacity/_asyncio.py", line 88, in async_wrapped
    return await fn(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/tenacity/_asyncio.py", line 47, in __call__
    do = self.iter(retry_state=retry_state)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/tenacity/__init__.py", line 325, in iter
    raise retry_exc.reraise()
          ^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/tenacity/__init__.py", line 158, in reraise
    raise self.last_attempt.result()
          ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/concurrent/futures/_base.py", line 449, in result
    return self.__get_result()
           ^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/concurrent/futures/_base.py", line 401, in __get_result
    raise self._exception
  File "/usr/local/lib/python3.12/site-packages/tenacity/_asyncio.py", line 50, in __call__
    result = await fn(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/controller.py", line 1390, in __post_with_retries
    return await self.__connection.post(command, method=method, data=data, url=url)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/connection.py", line 166, in post
    return await self.__open(url, method=method, headers=self.head, data=data)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/teslajsonpy/connection.py", line 218, in __open
    raise TeslaException(resp.status_code)
teslajsonpy.exceptions.TeslaException

Have you read the README? It explains how to make this work with Tesla’s recent API change. Warning: it’s a complicated setup, not for the faint of heart.

Have you read the README? It explains how to make this work with Tesla’s recent API change. Warning: it’s a complicated setup, not for the faint of heart.

yes I have, an it requires the installation of two add-ons, which is not possible on my docker-based HA core setup

yes I have, an it requires the installation of two add-ons, which is not possible on my docker-based HA core setup

Why it isn't? It seems I just did it on my stockpile of docker-composed containers. Just need one container and proxy if you don't have it already.

I have to add that i run no business so i cannot register to developer portal at all

Just type your name.

I ticked the 'Fleet API' checkbox in the configuration.  Is there any way to get back to that screen to uncheck that box?

yes I have, an it requires the installation of two add-ons, which is not possible on my docker-based HA core setup

Why it isn't? It seems I just did it on my stockpile of docker-composed containers. Just need one container and proxy if you don't have it already.

Fully agree, it's my lack of capacity going beyond the basic readme.
My docker core is behind a NPM on another server and I don't see how to get it set up in my case

Same problem here. Also a brand new vehicle, one of the Highland edition Model3's, if that's a factor.
All of my sensor data is working fine, just not commands. I am NOT running the Fleet proxy, but I had (wrongly?) assumed that since I a) wasn't getting the errors described in the docs and b) the sensor data was returning correctly, that I didn't need it. Bad assumption?

Same problem here. Also a brand new vehicle, one of the Highland edition Model3's, if that's a factor. All of my sensor data is working fine, just not commands. I am NOT running the Fleet proxy, but I had (wrongly?) assumed that since I a) wasn't getting the errors described in the docs and b) the sensor data was returning correctly, that I didn't need it. Bad assumption?

This has been mentioned many times, including in this thread. New cars and in theory all cars at some point (bar some older ones) will need to use the Fleet API going forward.

I've just updated the Tesla HTTP Proxy add-on to version 2.1.1 which removes the OAuth flow piece entirely.  I hope this simplifies the setup for some people.  Now the only "hard" part is figuring out how to host your public key.  I recommend using Auth App For Tesla to generate the API token.

I've just updated the Tesla HTTP Proxy add-on to version 2.1.1 which removes the OAuth flow piece entirely.

That was actually best part of it, otherwise it would be enough to run original Tesla stuff.

I've just updated the Tesla HTTP Proxy add-on to version 2.1.1 which removes the OAuth flow piece entirely. I hope this simplifies the setup for some people. Now the only "hard" part is figuring out how to host your public key. I recommend using Auth App For Tesla to generate the API token.

Thank you! Updated docs are also great - I understand where the complexity is now too (hosting the key).
Trying to think through alternatives, is there any opportunity to use my Nabu Casa URL (which has a cert) to host the public key? Looks like I would just need to put my key somewhere in my HAOS install that would expose it as:  https://my.nabucasa.URL/.well-known/appspecific/com.tesla.3p.public-key.pem
Is there anything obvious I'm missing here? (Before I spend a bunch of time trying to figure out how to make this work :) ). Does the Redirect URI need to be on the same domain?

I'm going to take my question over to here, and stop spamming this issue: https://github.com/llamafilm/tesla-http-proxy-addon/discussions/3

For anyone getting a generic TeslaException, please enable debug logging by clicking on Settings > Devices > Tesla Custom Integration > Enable Debug Logging.  Next time the issue happens, you should see the real error message at debug level.  I'm looking for ideas on how to improve the error logging: https://github.com/alandtse/tesla/discussions/935

2024-06-05 08:46:16.994 DEBUG (MainThread) [teslajsonpy.connection] post: https://owner-api.teslamotors.com/api/1/vehicles/1493134057821178/command/honk_horn {'on': True}
2024-06-05 08:46:17.196 DEBUG (MainThread) [teslajsonpy.connection] 403: {"response":null,"error":"Tesla Vehicle Command Protocol required, please refer to the documentation here: https://developer.tesla.com/docs/fleet-api#2023-10-09-rest-api-vehicle-commands-endpoint-deprecation-warning","error_description":""}

@BenoitDuffez you need to be using the fleet API like the error detail mentions

@skipishere Maybe I am mistaken but I am just a user of the HA Tesla integration and I have no control over what API is used. I can't honk from HA because it seems the integration does not use the appropriate API. I'm not myself choosing either API and I have no control over this, but I could be wrong

Please see https://github.com/alandtse/tesla#tesla-fleet-api-proxy for information about why and how to setup  with regards to the API

Indeed, thank you. Sorry about the noise, I thought I was helping :)


Create a release containing Package.swift

Currently Package.swift is in master, but no release/tag is available, so it can't be pulled with swiftpm (AFAI tried).
(Edit: Just noticed you're importing Foundation, so I'm assuming we're waiting for Swift Foundation to make this available on all Swift platforms?)

Yes, this heavily uses regex and therefore wouldn't work on Linux until Foundation has regular expressions (if it doesn't already).
I also have a branch no-regex which removes the uses of regex for variable expansion, but it still needs regex for variable extraction.

I just looked it up and it might technically already work: https://github.com/apple/swift-corelibs-foundation/blob/master/Foundation/NSRegularExpression.swift

But, there's no Package.swift, so I'm not sure what the easiest way to pull it in is anyway.

 This Foundation is going to be distributed with Swift binaries.

1.3.1 has been tagged.


Add link to sbt-jcheckstyle plugin

Please add a link to new my sbt plugin that checks code style of Java projects in a handy way: https://github.com/xerial/sbt-jcheckstyle

Hi @xerial,
Thank you for your contribution! We really value the time you've taken to put this together.
Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement:
http://www.typesafe.com/contribute/cla

Thanks!


Allow searching team by username to match partial usernames

Eg if your search query is "j", then a team with the user "j-mao" on it should appear.
Strangely, this already happens with team name, just not username.

Hello,
I will take a look at this, will update today.


Poor audio performance on Mac

Audio performance for simple youtube playback is poor. With local LAN, we see jerky audio playback; video works much better so something is off.
We used standard WITH_MACAUDIO #define enabled with no other tuning. Is this a known issue?

Any feedback on this? Thanks!

Who owns the Mac client?

hi, Is your MAC client make freerdp get the source code? or get a MAC framework? Then use the iOS client Xcode source?

@cloudecker how's your question related to the issue?

@puneet101 "owns" is hard to define. I'd say the FreeRDP project. The license is Apache License v2.0 and different people do have the copyright on it (see the source headers).
Regarding your issue the Mac client is basically working but at the moment it isn't very well maintained and no further (as i new features) is done.

@bmiklautz   I compiled freerdp MAC client, I got a framework, not a MAC client source code. My question, whether the MAC client also uses the iOS client source code?

@akallabeth  thank you!!!

@cloudecker please stop adding your quiestions/issues into unrelated issues.

Fast forward one year and the question remains. Any news on the Mac audio redirection implementation?

@lemonmojo The state @bmiklautz mentioned did not change, pull requests are welcome but nobody stepped up to fix that issue so far.

I am hoping to get sound redirection from a windows 10 enterprise remote machine to my Mac running Royal TSX ( freeRDP ). It appears that sound will work for a brief moment every time I start a RDP connection, and then it will no longer play. - It seems that when the first audio source stops, then audio no longer works on the RDP session until restarting it.
I currently am using a workaround by keeping a silent audio stream going upon start, and that is the "fix"
Is there any troubleshooting or other solutions that I am overlooking?

@cyp3d this is something you should address to Royal TSX

@hardening I put in a ticket with Royal TSX and they stated
"The best you can do at the moment is to push the following issue in the FreeRDP Github account: https://github.com/FreeRDP/FreeRDP/issues/2950  "
Just trying to get some visibility since they don't want to take ownership.
It does appear that the issue is the same regarding this github issue.

I'm also trying to get audio to work from windows to a mac, but having issues with it stopping after just a few seconds.  Would love to see future development on this feature to get the issues resolved.  Thanks!

@rfoust Unfortunately, I've had to trade off. Depending on my audio playback device Microsoft's RDC for mac works sometimes.
Similarly, Jump Desktop actually has great remote audio, but is lacking other nice features of Royal TSX.
It seems that there is no perfect solution here- unless you can remote control audio to play at the parent machine from RoyalTSX which has the best functionality outside of audio.

#4453 fixes a lot of sound related issues. Don't know if you can bundle that on mac like it is, but every pull fixing that is welcome.

Sound redirection has been basically rewritten, closing this.
Reopen or create a new one if still not solved.


msi: use 7z to extract tar.gz archive

Recently, fresh build fails because of missing tar command.
7z.exe is installed as a toolchain, it is changed to use it.
It fixes the following error:
  Use 'docker scan' to run Snyk tests against images to find vulnerabilities and learn how to fix them
  docker run --rm --tty --volume C:/work/td-agent-builder/td-agent-builder.msi:c:/td-agent-builder:rw td-agent-windows-x64 c:\td-agent-builder\td-agent\msi\build.bat

  C:\>SET SRC_DIR=c:\td-agent-builder\td-agent\msi\

  C:\>CALL "c:\td-agent-builder\td-agent\msi\env.bat"

  C:\>SET PACKAGE=td-agent

  C:\>SET VERSION=4.1.1

  C:\>SET ARCH=x64

  C:\>tar xvf "c:\td-agent-builder\td-agent\msi\..\td-agent-4.1.1.tar.gz"
  rake aborted!
  Command failed with status (): [docker run --rm --tty --volume C:/work/td-...]
  C:/work/td-agent-builder/td-agent-builder.msi/td-agent/Rakefile:1566:in `run_docker'
  C:/work/td-agent-builder/td-agent-builder.msi/td-agent/Rakefile:1484:in `block (2 levels) in define'
  C:/work/td-agent-builder/td-agent-builder.msi/td-agent/Rakefile:1474:in `block (2 levels) in define'
  Tasks: TOP => msi:dockerbuild
  (See full trace by running task with --trace)
  I, [2021-06-29T11:28:07.190678 #2624]  INFO -- : Generate debian/copyright
  rake aborted!
  Command failed with status (1): [C:/Ruby27-x64/bin/ruby.exe -S rake msi:bui...]
  C:/work/td-agent-builder/td-agent-builder.msi/Rakefile:36:in `block (3 levels) in define_bulked_task'
  C:/work/td-agent-builder/td-agent-builder.msi/Rakefile:35:in `block (2 levels) in define_bulked_task'
  C:/work/td-agent-builder/td-agent-builder.msi/Rakefile:34:in `each'
  C:/work/td-agent-builder/td-agent-builder.msi/Rakefile:34:in `block in define_bulked_task'
  Tasks: TOP => msi:build
  (See full trace by running task with --trace)

Even though this PR is merged, another ridk exec patch will fail. it should be fixed in another PR.

Recently, fresh build fails because of missing tar command.
7z.exe is installed as a toolchain, it is changed to use it.

I've rerun CI for Windows on master branch but succeeded: https://github.com/fluent-plugins-nursery/td-agent-builder/runs/2947917109
What's happen on you environment?

Hmm, something wrong with my environment.


Doobie integration

These changes add doobie integration with Hikari connection pool. Supported databases are H2 and PostgreSQL. Currently Slick integration is not removed and may be used as well as early.
Default master configuration is H2 over new Doobie with Hikari coonection pool.

Great! Thanks for your contribution. Now, we almost ready to publish a new release.
Everything is fine except tests and Travis setup.
Unfortunately, last commits about Travis don't fit for our case. It's hard to explain why, but we use two CI servers: Travis and Jenkins.  Moving this spec to integrations tests is the best way to keep these tests. There we can run PostgreSQL as a docker container and this approach allows us not to care about an environment and run these test anywhere where docker is installed.
Actually, it would be enough just to remove last 5 commits to merge this PR. If you don't have enough time, I can complete this testing stuff after merge by myself.

I think only last four commits are extra. This one https://github.com/Hydrospheredata/mist/pull/541/commits/8dfd16372d16cfceb9f7156aa038e3ebb10acc89 is mandatory for the project build. I'd appreciate you help if you will convert these tests to the integration test by yourself.

Yes, you right - 4 would be enough.
Could you please edit history and remove these commits?

I've just removed last three commits. The fourth mark Pg test as abtract and is mandatory to run tests without any fail.


Augmented Reality on ROS

implement simple Augmented reality applications using [OpenGL] and [OpenCV].

The above issue has been completed and uploaded. Please refer to the below file for detailed information.
Augmented Reality on ROS.md


enhancement0

Fixed typos:
processing_activites -> processing_activities
noticably -> noticeably
Found with: https://github.com/ss18/grep-typos

Cool automated system 👍


SteeringTest fails when LetsEncryptDnsChallengeWatcher hangs

I'm submitting a ...

bug report

Traffic Control components affected ...

Traffic Router

Current behavior:

When running the Traffic Router tests in ExternalTestSuite, SteeringTest fails with
Expected: a value greater than <986>
     but: <986> was equal to <986>
	at com.comcast.cdn.traffic_control.traffic_router.core.external.SteeringTest.z_itemsMigrateFromSmallerToLargerBucket(SteeringTest.java:356)

Expected behavior:

The tests in SteeringTest should pass
Minimal reproduction of the problem with instructions:

Run the external tests. For convenience, I have made a branch that runs SteeringTest only in CDN-in-a-Box
https://github.com/zrhoffman/trafficcontrol/commits/steering-test
You can use it to run the Traffic Router tests, including external tests, as follows:
docker-compose up -d
docker-compose -f docker-compose.readiness.yml up readiness # Waits for Traffic Monitor to be usable by Traffic Routers
docker-compose -f docker-compose.traffic-router-test.yml up tr-integration-test

Anything else:

SteeringTest has failed since 18fe13ac63/#3534 (and snuck into 4.1.0). The only 2 assertions that fail are these:
		assertThat(rehashedPaths.get(smallerTarget).size(), greaterThan(hashedPaths.get(smallerTarget).size()));
		assertThat(rehashedPaths.get(largerTarget).size(), lessThan(hashedPaths.get(largerTarget).size()));

I think this is because SteeringWatcher doesn't get to update after the POST request to the mock TO server to change the steering attributes.
The reason I don't think SteeringWatcher updates after that point is that LetsEncryptDnsChallengeWatcher's ScheduledExecutorService hangs when trying to update LetsEncryptDnsChallengeWatcher's database from https://${toHostname}/api/2.0/letsencrypt/dnsrecords/.
For whatever reason, Fetcher's request for LetsEncryptDnsChallengeWatcher never makes it to HttpDataServer (the mock TO server) even though the host and port seem to line up. But, if you make Fetcher return for LetsEncryptDnsChallengeWatcher requests right before it sends the request:
			if (url.contains("letsencrypt")) {
				return http;
			}

then SteeringTest succeeds. If you don't, the request doesn't seem to ever complete.
--
Other notes:

Changing DEFAULT_LE_DNS_CHALLENGE_URL to "https://${toHostname}/api/2.0/letsencrypt/dnsrecords" so it doesn't end in a slash, then adding a mock response for it does not keep LetsEncryptDnsChallengeWatcher's Fetcher request from hanging.
One AbstractResourceWatcher hanging should not make another AbstractResourceWatcher hang. If Traffic Router does this outside of tests, it's a serious bug that we should fix.

Since I haven't PRed it yet: The zrhoffman/tr-int-test branch can be used to run the Traffic Router External Tests.

Start CDN-in-a-Box
Wait for Traffic Monitor to start, since it is used by some Integration Tests (like AbstractResourceWatcherTest)
Run the Traffic Router External Tests and Integration Tests:docker-compose -f docker-compose.traffic-router-test.yml up --build tr-integration-test

You can also debug the tr-integration-test service by setting the TR_TEST_DEBUG_ENABLE to true in variables.env.
Debugging settings to use in Intellij Idea:

Listen to remote JVM instead of Attach to remote JVM
Enable Auto restart, since otherwise the debugger would stop listening after each test
Port 8000
Make sure the IDE is listening for debug connections before starting the tests or they will all fail.

Reopening per @zrhoffman's comment on #5342.

#5069 no longer occurs for me.


Blazor wasm example addition

By making a PR you are agreeing to that contributing a hello world project allows the repo/project owner to use the hello world app in examples for their own use.

[X] only the most simple basic hello world app
[X] remove all tests and commands for tests and dependencies for tests
[X] must say "Hello World" on the main component
[X] only include the minimal components (1 ideally)
[X] no routing, not extras whatsoever
[X] no styling
[X] nothing else !
[X] must work by running npm install and npm start (or equivalent)
[X] must be in the folder named <tech-name>
[X] add build steps and which folder to serve in the README.md
[X] verify that the app once built can be served from whatever folder the built assets are placed in
[X] verify that running npx http-server <your-folder-to-serve> works dotnet run in this case
[X] verify that a Pull Request doesn't already exist. If it does, feel free to contribue to it.

Closes #118

@spboyer please add the steps to the main readme in the root of the repo.

Thanks a lot @spboyer
I understand the dotnet SDK is required to build the app. Do you think we can have it installed from npm? I found this package published by Microsoft, will it work: https://www.npmjs.com/package/dotnet-3.1?

@manekinekko - this package is not an official Microsoft npm package and breakage would be likely.  I would not suggest installing it from npm no more that I'd recommend installing a node app from .NET

@spboyer gotcha!
@johnpapa would this be a blocker when deploying this Hello World app on SWA?

@manekinekko Blazor support in SWA is not fully implemented. We are heads down getting that support completed.

@johnpapa @manekinekko - Ok to merge here.

Thank you @spboyer. Merged.


API reference links corrections

Fixes #46
Introduces the relative input for relevant workflows as well as the --relative option for the docs-api-reference pre-commit hook.
The point of this input/option is to toggle whether or not to install the local Python package(s) as an editable installation (using the -e option for pip install) and creating the API reference markdown links into the Python API relative to the repository root or the importable Python package name.

Codecov Report

Merging #47 (5293830) into main (0927de8) will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   50.19%   50.39%   +0.19%
==========================================
  Files           3        3
  Lines         255      256       +1
==========================================
+ Hits          128      129       +1
  Misses        127      127

Impacted Files
Coverage Δ

ci_cd/tasks.py
50.40% <100.00%> (+0.19%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Align to data

In this PR we want to introduce necessary changes in the soepy package such that estimations can be performed using data from GSOEP.
In addition, tacke issues #85 and #88

Unfortunately, I did not achieve progress on #85. Might be better to review now and postpone issue for the next PR.


Doesn't support multibyte characters

I'm working with https://github.com/dhall-lang/dhall-lang/blob/master/standard/dhall.abnf, which supports various non-ASCII Unicode characters, e.g. combine       = %x2227 / "/\".
Currently, this raises an error, due to the use of bytearray in converting %x2227 to a string. I believe the fix may be as simple as something like
def _decode_bytes(self, data, base):
        """Decodes num-val byte data. Intended to be private."""
       - return bytearray([int(data, base=base)]).decode(self.encoding)
       + return chr(int(data, base=base))

With this change,
>>> Rule.create('combine = %x2227 / "/\"')
<abnf.parser.Rule object at 0x10f4c1518>
>>> Rule('combine').parse("/\\")
(<abnf.parser.Node object at 0x10f48be48>, 1)
>>> x = Rule('combine').parse("∧")
>>> x[0].value
'∧'

I have pushed a fix.  You might try it for yourself before I upload a new package to pypi.


i40e: Failed to delete MAC filter, error I40E_ERR_PARAM

What happened?
When deleting a SR-IOV Pod that has customized MAC address configured. i40e driver reports error message below:
[ 1931.834872] i40e 0000:88:00.1: MAC addr ca:fe:c0:ff:ee:ee has been set by PF, cannot delete it for VF 1, reset VF to change MAC addr
[ 1931.834999] i40e 0000:88:00.1: VF 1 failed opcode 11, retval: -5
[ 1931.835109] i40evf 0000:88:0a.1: Failed to delete MAC filter, error I40E_ERR_PARAM
[ 1931.865124] i40e 0000:88:00.1: Removing MAC on VF 1
[ 1931.865249] i40evf 0000:88:0a.1: Reset warning received from the PF
[ 1931.865257] i40evf 0000:88:0a.1: Scheduling reset task
[ 1931.953132] i40e 0000:88:00.1: Reload the VF driver to make this change effective.
[ 1932.045835] i40e 0000:88:00.1: VF 1 is now untrusted
[ 1932.051530] IPv6: ADDRCONF(NETDEV_UP): enp136s10f1: link is not ready
[ 1932.053490] IPv6: ADDRCONF(NETDEV_UP): enp136s10f1: link is not ready
[ 1932.160215] i40evf 0000:88:0a.1 enp136s10f1: NIC Link is Up 25 Gbps Full Duplex
[ 1932.160231] IPv6: ADDRCONF(NETDEV_CHANGE): enp136s10f1: link becomes ready

What did you expect to happen?
no error message reported from i40e drivers, for example:
[ 2057.031200] i40evf 0000:88:0a.0: Reset warning received from the PF
[ 2057.031209] i40evf 0000:88:0a.0: Scheduling reset task
[ 2057.124303] i40e 0000:88:00.1: VF 0 is now trusted
[ 2057.216816] IPv6: ADDRCONF(NETDEV_UP): net1: link is not ready
[ 2057.258262] i40evf 0000:88:0a.0 net1: NIC Link is Up 25 Gbps Full Duplex
[ 2057.260185] IPv6: ADDRCONF(NETDEV_CHANGE): net1: link becomes ready
[ 2113.069530] i40evf 0000:88:0a.0: Reset warning received from the PF
[ 2113.069539] i40evf 0000:88:0a.0: Scheduling reset task
[ 2113.161275] i40e 0000:88:00.1: VF 0 is now untrusted
[ 2113.167315] IPv6: ADDRCONF(NETDEV_UP): enp136s10: link is not ready
[ 2113.168271] IPv6: ADDRCONF(NETDEV_UP): enp136s10: link is not ready
[ 2113.281669] i40evf 0000:88:0a.0 enp136s10: NIC Link is Up 25 Gbps Full Duplex
[ 2113.281690] IPv6: ADDRCONF(NETDEV_CHANGE): enp136s10: link becomes ready

What are the minimal steps needed to reproduce the bug?
Create a SR-IOV Pod with below spec, then delete the pod, check the system log with dmesg
apiVersion: v1
kind: Pod
metadata:
  name: testpod2
  annotations:
    k8s.v1.cni.cncf.io/networks: '[
        {
                "name": "sriov-net1",
                "mac": "CA:FE:C0:FF:EE:EE"
        }
]'
spec:
  containers:
  - name: appcntr2
    image: centos/tools
    imagePullPolicy: IfNotPresent
    command: [ "/bin/bash", "-c", "--" ]
    args: [ "while true; do sleep 300000; done;" ]
    resources:
      requests:
        intel.com/intel_sriov_netdevice: '1'
      limits:
        intel.com/intel_sriov_netdevice: '1'

Anything else we need to know?
Component Versions
Please fill in the below table with the version numbers of applicable components used.

Component
Version

SR-IOV CNI Plugin
master

Multus
master

SR-IOV Network Device Plugin
master

Kubernetes
1.16.1

OS
CentOS 7.6

Config Files
Config file locations may be config dependent.
CNI config (Try '/etc/cni/net.d/')
using default:
{
        "name": "multus-cni-network",
        "cniVersion": "0.3.1",
        "type": "multus",
        "logLevel": "debug",
        "logFile": "/tmp/multus.log",
        "delegates": [{
                "type": "flannel",
                "name": "flannel.1",
                "delegate": {
                        "isDefaultGateway": true
                }
        }],
        "kubeconfig": "/etc/kubernetes/admin.conf"
}

Device pool config file location (Try '/etc/pcidp/config.json')
using  default:
{
    "resourceList": [{
            "resourceName": "intel_sriov_netdevice",
            "selectors": {
                "vendors": ["8086"],
                "devices": ["154c", "10ed"],
                "drivers": ["i40evf", "ixgbevf"]
            }
        },
        {
            "resourceName": "intel_sriov_dpdk",
            "selectors": {
                "vendors": ["8086"],
                "devices": ["154c", "10ed"],
                "drivers": ["vfio-pci"],
                "pfNames": ["enp0s0f0","enp2s2f1"]
            }
        },
        {
            "resourceName": "mlnx_sriov_rdma",
            "isRdma": true,
            "selectors": {
                "vendors": ["15b3"],
                "devices": ["1018"],
                "drivers": ["mlx5_ib"]
            }
        }
    ]
}

Kubernetes deployment type ( Bare Metal, Kubeadm etc.)
Bare Metal, Kubeadm
SR-IOV Network Custom Resource Definition
apiVersion: "k8s.cni.cncf.io/v1"
kind: NetworkAttachmentDefinition
metadata:
  name: sriov-net1
  annotations:
    k8s.v1.cni.cncf.io/resourceName: intel.com/intel_sriov_netdevice
spec:
  config: '{
  "type": "sriov",
  "cniVersion": "0.3.1",
  "name": "sriov-network",
  "trust": "on",
  "ipam": {
    "type": "host-local",
    "subnet": "<IP_ADDRESS>/24",
    "routes": [{
      "dst": "<IP_ADDRESS>/0"
    }],
    "gateway": "<IP_ADDRESS>"
  }
}'

Hi @zshi-redhat, The mac address behavior not consistent and it mostly depends on PF and VF drivers combination.
With latest drivers, I can confirm it works as expected. Saying that, I've also experienced similar but not exactly the same as yours. (Latest VF driver link here)
I see you're using i40evf driver. Can you please update your VF driver to iavf and see if this issue still exist?
I've noticed, with new drivers(PF: i40e v2.9.21 VF:  iavf v3.7.53), I can set VF mac address administratively with ip link set dev <PF> vf <num> mac CA:FE:C0:FF:EE:EE and it reflects in VF interface as well without having to set it for VF interface. I have also tested this with this plugin and it works.
If this works for you then we might need to revisit how the setting of mac address is implemented in this plugin to make this simpler.

Closing due to inactivity. Please reopen if the issue is not resolved.


where is the exe file

hi where is the exe file for webos dev manager ?

For Windows, install the appropriate MSI file from https://github.com/webosbrew/dev-manager-desktop/releases.


O&O Shutup 10 error on tweaks page

Describe the bug
A clear and concise description of what the bug is.
When running tweaks and having run OO Shutup it errors out with attached screenshot
To Reproduce
Steps to reproduce the behavior:

Go to 'your tool'
Click on 'tweaks'
Scroll down to 'OO shutup'
Send it, and see error

Expected behavior
A clear and concise description of what you expected to happen.
Clearly, its supposed to work. lol
Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Shoutout to all the youtube people!

Was able to reproduce, but running the tweak again seems to work.

When I got the error message it happened repeatedly even running the tweaks again. Maybe the location of the config file has some availability issues, or something has changed upstream and isn't reflected in the script.


Update always-on-top.md

This PR aims to:

clarifying some of the wording for the Always On Top utility in PowerToys
add some Always On Top settings that are missing from the docs
align the Always On Top documentation closer to the Microsoft style guide

@NathanD-GDS please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

These changes look good. Thanks for the updates to this page. Is there anything in here that needs to wait for a future release, or can it be merged today?

This can be merged today. Thanks for the quick approval!


Rename 'Applied to stakeholder' to ....

We once decided to rename 'Applied to stakeholder' to something a little more convenient. But to be honest I forgot what it was. @ChaelKruip do you remember? Or could maybe explain what that select box says about a market model measure?
Including: @jorisberkhout

Now that @ChaelKruip explained me what is meant by 'Applied to stakeholder' (i.e. it allows you to select at which stakeholder the measure is actually measured), I think that 'Measured at stakeholder' would be better way to describe this. What do you think, @ChaelKruip and @grdw ?

Assigned to @grdw