Non-deterministic results for pulumi up

What happened?
Multiple runs of pulumi up result in different outputs for the preview.  Some runs result in no error, while other runs produce errors (with different resources each time).
The resources were recently imported with no issues, and I can find no major differences between my create code and the code generated by pulumi import
Example

Output of pulumi about

Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Hi @chrrlesWork. I'm sorry you're hitting this error. Can you please provide a repro for us: a set of steps (including your code) that we can follow so we see the error on our own computer?
It's very hard for us to fix bugs if we are not able to reproduce the bug on our side.

Hi @chrrlesWork. I'm sorry you're hitting this error. Can you please provide a repro for us: a set of steps (including your code) that we can follow so we see the error on our own computer?
It's very hard for us to fix bugs if we are not able to reproduce the bug on our side.

Hello @iwahbe,
I was able to find the cause and move past this error.  This behavior occurs when specifying the pulumi.Parent() option on resources imported without a declared parent.
For example in record, err := route53.NewRecord(ctx, recordName, recordArgs, pulumi.Protect(true), pulumi.Parent(zone)) here:
func createRecord(ctx *pulumi.Context, r conf.ResourceRecordSet, zone *route53.Zone) (*route53.Record, error) {
  recordName := r.Name + "_" + r.Type
  recordArgs := &route53.RecordArgs{
    ZoneId: zone.ZoneId,
    Name:   pulumi.String(r.Name),
    Type:   pulumi.String(r.Type),
  }
  // Alias types with a target have an additional Alias field and no custom TTLs
  if r.Type == "A" || r.Type == "AAAA" {
    if r.AliasTarget != nil {
      recordAliasArgs := route53.RecordAliasArray{
        &route53.RecordAliasArgs{
          Name:                 pulumi.String(r.AliasTarget.DNSName),
          EvaluateTargetHealth: pulumi.Bool(r.AliasTarget.EvaluateTargetHealth),
          ZoneId:               pulumi.String(r.AliasTarget.HostedZoneId),
        },
      }
      recordArgs.Aliases = recordAliasArgs
    } else {
      recordArgs.Ttl = pulumi.Int(r.TTL)
    }
    if r.Failover != "" {
      recordName = recordName + "_" + r.SetIdentifier
      recordArgs.FailoverRoutingPolicies = route53.RecordFailoverRoutingPolicyArray{
        &route53.RecordFailoverRoutingPolicyArgs{
          Type: pulumi.String(r.Failover),
        },
      }
    }
  } else {
    recordArgs.Ttl = pulumi.Int(r.TTL)
  }
  if r.HealthCheckId != "" {
    recordArgs.HealthCheckId = pulumi.String(r.HealthCheckId)
  }
  if r.SetIdentifier != "" {
    recordArgs.SetIdentifier = pulumi.String(r.SetIdentifier)
  }
  // Populate resource records, if any
  if r.ResourceRecords != nil {
    resourceRecords := pulumi.StringArray{}
    for _, rr := range r.ResourceRecords {
      resourceRecords = append(resourceRecords, pulumi.String(rr.Value))
    }
    recordArgs.Records = resourceRecords
  }
  record, err := route53.NewRecord(ctx, recordName, recordArgs, pulumi.Protect(true), pulumi.Parent(zone))
  if err != nil {
    return nil, err
  }
  return record, nil
}
...
  // Create the domain records
  records := []*route53.Record{}
  for _, r := range cfg.HostedZone.ResourceRecordSets {
    record, err := createRecord(ctx, r, zone)
    if err != nil {
      return nil, err
    }
    records = append(records, record)
  }

My initial import script did not specify a parent:
    for record in hostedZone["ResourceRecordSets"]:
        tag = "%s_%s" % (record["Name"], record["Type"])
        subprocess.run(["pulumi", "import", "aws:route53/record:Record", tag, zoneId+"_"+tag, "-o", "generated/%s.go" % tag, "--skip-preview", "-y"])

This problem has gone away with this change:
    # Import Records
    for record in hostedZone["ResourceRecordSets"]:
        recordName = "%s_%s" % (record["Name"], record["Type"])
        subprocess.run(
            [
                "pulumi",
                "import",
                "aws:route53/record:Record",
                recordName,
                zoneId + "_" + recordName,
                "--generate-code=false",
                "--skip-preview",
                "-y",
                "--parent",
                urn,
            ]
        )

Please note that code generation in this version is disabled because of this issue: https://github.com/pulumi/pulumi/issues/15410

Hi @chrrlesWork. I'm sorry you're hitting this error. Can you please provide a repro for us: a set of steps (including your code) that we can follow so we see the error on our own computer?
It's very hard for us to fix bugs if we are not able to reproduce the bug on our side.

Hello @iwahbe,
I was able to find the cause and move past this error. This behavior occurs when specifying the pulumi.Parent() option on resources imported without a declared parent.
For example in record, err := route53.NewRecord(ctx, recordName, recordArgs, pulumi.Protect(true), pulumi.Parent(zone)) here:
...
Please note that code generation in this version is disabled because of this issue: pulumi/pulumi#15410

Are you saying that the delete behavior or the non-determinism occurs when pulumi.Parent() is omitted? I would expect to see deletes if the code you have includes different parent's then what was imported, since resources are named based on their parents.

Going to close this as no/repro. It looks like there still might be some underlying issue but it's too difficult for us to make progress without a smaller self-contained repro, apologies. Please file a new issue with a repro if this still is a problem for you. Appreciated.


[BUG] - When clicking on Activate button in development mode

Oqtane Info
Version - 5.1.1
Render Mode - Static
Interactivity - Server
Database - SQL Server
Describe the bug
I have released a commercial module called Amazing Subscriber
While testing the module in the local development environment using the licensing=testmode parameter
There is no option to enter the license manual
Expected Behavior
There should be an ability to manually enter a license key and click Validate as the documentation says.
Steps To Reproduce
Include the licensing module in your project and try it
Anything else?
I have setup the product to test in the Sandbox

Please provide the exact Url you are using in your environment

It is in development environment https://localhost:44357/?licensing=testmode
The licensed module Amazing.Module.Subscriber is on homepage

and when you look in the /bin folder you are sure that a license has not already been generated for the module (ie. no Amazing.Module.Subscriber.lic file exists)?

actually it appears there is an issue which was caused when adding support for static rendering which affects the testmode parameter

@sbwalker are you planning to fix this ?

@sbwalker no rush ... I have generated the keys manually and created the lic files and uploaded them to my production sites bin folder and they are now working

@vnetonline the problem you reported should only exist in your development site (ie. localhost). In a production site, the ability to enter a license key should work fine. Please let me know if this is not the case.

@sbwalker this is not the case in my production environment when I click Activate nothing happens the
Purchase button works and it directs me to the order page.

Ok, I will explore further

@vnetonline I am unable to reproduce the problem you are describing. I am assuming you are using the latest version of the Oqtane.Licensing component - version 5.1.0 (https://www.nuget.org/packages/Oqtane.Licensing/5.1.0).
If the integration with your module is specifying the PackageName parameter correctly, and you are running in a local environment, and you have specified the "licensing=testmode" querystring parameter, then the licensing component should display a message which says "Amazing Subscriber Is Not Licensed" and below it display an Activate and Purchase button. Are you able to to post a screen shot this UI in your local installation?
When you click the Activate button, the UI should change and display a form with a Fetch button, a license key text box, and a Validate button. The text box is where a license key can be manually entered and clicking Validate will validate the license key. Can you also post a screen shot of the UI where the license key textbox is displayed in your local installation.

@sbwalker I updated the Oqtane.Licensing 5.1.0 and everything works as expected,
The documentation was not correct, so I have submitted a pull request with images as to what developers should expect when they pass in the ?licenising=testmode parameter on the page on which the module in their local environment to test the license flow.

closing as this is not an issue


class for panel collapsed state

Can we have a class or data attribute in the panel that toggles when the panel is collapsed? Currently we can only use onCollapse and onExpand, but that is kind of overkill for just styling.

If your'e looking for something that can be used for styling, or for e2e tests, then attributes like data-panel-collapsible and data-panel-size already exist (e.g. data-panel-size="0" is collapsed)

data-panel-size will have the collapsedSize and not 0, so it is not logically to use that.

If the collapsed size is not zero, then it will have whatever the collapsed size is. You know that size, Because you pass it in as a prop, so you can write your selector accordingly.

It's feels more idiomatic to have a dedicated data attribute for that. Otherwise I need to change a css/tailwind value somewhere else in the code if I change the collapsedSize value which is weird. Also css could be applied to many panels which all could have different collapsedSizes.
Whether a panel is collapsed or not is idiomatic a different information than the current size of it, so it should also have separate representations.


Add permissions API

@clarkbw can you release this? The last version is a year old https://www.npmjs.com/package/jest-webextension-mock


THRIFT-3037 Go Codegen - Support Struct TypeDefs

Please create a jira ticket to describe what problem you are trying to resolve, what's the before and after generated go code from what thrift code.

Please create a jira ticket to describe what problem you are trying to resolve, what's the before and after generated go code from what thrift code.

Hello @fishy ! :)
The ticket THRIFT-3037 best describes this issue so I figured it best not to create a duplicate. Here is an example of how the generated code changes. I've listed them as bullet points for the major changes.
Change description
This PR makes it possible for typedefs that don't refer to a primative type to compile. This is accomplished by using a struct instead of declaring a type pointer (fixes the issue with READ methods etc. not existing).
Code changes
Here is the example schema which we will be using to describe the issue. Without the change, the code does not compile.
struct ExampleRequest {
    1: required string example_field
}

struct ExampleResponse {
    1: required string example_field
}

typedef ExampleRequest TypedefExampleRequest
typedef ExampleResponse TypedefExampleResponse

service EnvironmentService {
    ExampleResponse exampleMethod(1: ExampleRequest request)
    TypedefExampleResponse typedefExampleMethod(1: TypedefExampleRequest request)
}

Each change will have a title and will be formatted in three sections. Code Change (this PR), previous generated code and new generated code.
Use Structs instead of aliases
This was needed as you can't refer to methods on aliased types. You instead need to implement the existing struct to inherit it's methods.
Code change
https://github.com/apache/thrift/blob/cc2d009a0f036209bc8f39d206e9d2b7cf19f4a1/compiler/cpp/src/thrift/generate/t_go_generator.cc#L769-L773
Old Code
type TypedefExampleRequest *ExampleRequest

func TypedefExampleRequestPtr(v TypedefExampleRequest) *TypedefExampleRequest { return &v }

type TypedefExampleResponse *ExampleResponse

func TypedefExampleResponsePtr(v TypedefExampleResponse) *TypedefExampleResponse { return &v }

New Code
type TypedefExampleRequest struct { *ExampleRequest }

func TypedefExampleRequestPtr(v TypedefExampleRequest) *TypedefExampleRequest { return &v }

type TypedefExampleResponse struct { *ExampleResponse }

func TypedefExampleResponsePtr(v TypedefExampleResponse) *TypedefExampleResponse { return &v }

For Forward TypeDefs use the original typedef name
This was needed as it wouldn't use the correct type. For example it would use ExampleRequestwhere instead the TypeDefExampleRequest should have been used.
Code change
https://github.com/apache/thrift/blob/cc2d009a0f036209bc8f39d206e9d2b7cf19f4a1/compiler/cpp/src/thrift/generate/t_go_generator.cc#L2093-L2094
Old Code
func (p *EnvironmentServiceTypedefExampleMethodArgs)  ReadField1(ctx context.Context, iprot thrift.TProtocol) error {
  p.Request = &ExampleRequest{}
  if err := p.Request.Read(ctx, iprot); err != nil {
    return thrift.PrependError(fmt.Sprintf("%T error reading struct: ", p.Request), err)
  }
  return nil
}

New Code
func (p *EnvironmentServiceTypedefExampleMethodArgs)  ReadField1(ctx context.Context, iprot thrift.TProtocol) error {
  p.Request = &TypedefExampleRequest{}
  if err := p.Request.Read(ctx, iprot); err != nil {
    return thrift.PrependError(fmt.Sprintf("%T error reading struct: ", p.Request), err)
  }
  return nil
}

Pleasse let me know if there's anything else I can clarify :)

Thanks. Please

Add a test to verify the fix
Claim the jira ticket (cc @dcelasun you claimed the ticket previously)
instead of type TypedefExampleRequest struct { *ExampleRequest }, why not just type TypedefExampleRequest = ExampleRequest? that will make things much simpler isn't it?

Thanks for the PR!
I've unassigned myself from the ticket and I agree with @fishy that an alias would be better.

@dcelasun and @fishy thank you for the quick response :)
I have a Jira account Ethan-Gallant but seem to lack the permissions to self-assign the issue. I left a comment on it if someone is able to assign it to me when able.
As for the struct implementation, I've added it to simplify the code ex: type MyTypedefOfString = string it also supports more complicated types like type MyTypeDefOfStruct = MyRequest.
For testing I added a service to the Go test which will cause a compile failure. I'm struggling to get the suite working locally. Do you have any other guidance aside from the existing Readme file I can reference?

also, thrift files under test/ are for all languages and are not necessarily run by all language tests (currently there's no go test specifically run against test/TypedefTest.thrift, it's just the compiler change you made complete broke the go code so it failed the test). for go specific tests I'd suggest you to put it under lib/go/test instead. Note that currently tests under lib/go/test is not run by CI, see https://github.com/apache/thrift/pull/2886 (after that is merged the CI will run those tests)

@fishy I've added a test in the lib/go/test directory with some more extensive use-cases.
Currently it will test:

Optional typedef properties
Typedefs for primitive types
Typedefs for struct types
Services using the above types (where the compile issues originated from)

also, now https://github.com/apache/thrift/pull/2886 is merged, please rebase your change on top of latest master so the CI will actually run your tests.

@ethan-gallant Is there any update on this? I am also facing the similar issue.


Handle problem errors from the API

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#81  👈
#80
#79
#78
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @eberle1080 and the rest of your teammates on  Graphite


V2 UI: Handle overflowing tabs on vulnerability details better

Issue: #381
Since spicy-sections doesn't have a feature of expanding all collapsed sections by default, I decided to programmatically click on those package headers when the page is loaded. But this method is bit of awkward, so let me know if you have a better idea.
Mobile view:

An alternative way of implementing similar feature is using exclusive-collapse mode for spicy-section, but in that mode only the first section is expanded by default, and users are only able to expand one section (which is kind of similar with the tab-bar mode). Here is a demo of different modes of Spicy Section, and you just need to click on the "exclusive-collapse" button to check exclusive-collapse mode:
https://spicy-sections.glitch.me/programatic.html

/gcbrun

/gcbrun

@ZhangChen199102 can you please merge the latest master into your branch?

Hmm, there's some strange behaviour with this.
If I load https://test.osv.dev/vulnerability/ALSA-2024:1818 directly, then all the sections are expanded.
If I instead navigate to the vulnerability via https://test.osv.dev/list?ecosystem=AlmaLinux&q=ALSA-2024%3A1818, they do not expand. I wonder if this is some side effect caused by turbo?

@ZhangChen199102 can you please take a look?


Metadata model output differs between python and tfjs

Running the example flask app for TFJS, with the following settings:
lat: 51.9, lon: -0.4, week: 12, threshold 0.01

Gives 185 species
Whereas the console of the BirdNET Analyzer GUI, using the same inputs, states the list has 148 species.
Apart from the lat, lon and week, I have only changed the loop in main.js to run 200 times, in order to establish how many species have a probability > 0.01:
   // Load metadata model
    setStatus('
Loading metadata model...', false);
    const metadata_model = await tf.loadGraphModel('static/model/mdata/model.json');
    setStatus('Done!')

    // Dummy location and week
    const lat = 51.9;
    const lon = -0.4;
    const week = 12;
    let mdata_input = tf.tensor([lat, lon, week]).expandDims(0);

    // Run the prediction
    setStatus('Running mdata prediction...', false);
    const mdata_prediction = metadata_model.predict(mdata_input);
    setStatus('Done!')

    // Print top 10 probabilities and labels (labels are the same as for the audio model)
    setStatus('Most common species @ (' + lat + '/' + lon + ') in week ' + week + ':');
    const mdata_probs = await mdata_prediction.data();
    const mdata_probs_sorted = mdata_probs.slice().sort().reverse();
    for (let i = 0; i < 200; i++) {
        const index = mdata_probs.indexOf(mdata_probs_sorted[i]);
        setStatus(labels[index] + ': ' + mdata_probs_sorted[i]);
    }

}

I think I may have found the reason for the discrepancy. It looks like you have different models in the two versions. Perhaps the TFJS version is using the  V1 MDATA model?

OK, so it may be the Gui that is the outlier?
I have compared the lists from the analyze.py script (run in VS Code) and the TFJS example, and they are similar enough:
Species comparisons TFJS-Python.xlsx
However, this is the gui output using these settings:

This has been fixed by https://github.com/kahst/BirdNET-Analyzer/issues/261#issuecomment-1956535750


Refactored to use more di, container features, and an alias

@aloha updated PR

@aloha I merged in master, to have the ssl_verify as well.


Error writing log file

I'm using Regridder wihtin a docker container and running into an issue with ESMF being unable to open the log file.  The output to the console (I believe from Fortran) when I run regridder = xe.Regridder(da, target_grid, 'bilinear') says:
Create weight file: bilinear_144x192_180x360.nc
 ESMF_LogOpenFile(): error opening file: PET0.ESMF_LogFile, iostat =          13
 ESMF_LogOpenFile(): error opening file: PET0.ESMF_LogFile, iostat =          13
 ESMF_LogOpenFile(): error opening file: PET0.ESMF_LogFile, iostat =          13
 ESMF_LogOpenFile(): error opening file: PET0.ESMF_LogFile, iostat =          13

And then python says:
ValueError: ESMC_FieldRegridStoreFile() failed with rc = 22.    Please check the log files (named "*ESMF_LogFile").

I'm wondering if this is a simple issue of file system permissions within the docker container, but I cant figure out where ESMF is trying to write the log file to, or how to specify where it could write to (where it has permissions).

This is no longer a problem for me, although I am still curious where ESMF tries to write its logs to


perf: fuzz/invariant benchmarks

Component
Forge
Describe the feature you would like
There are currently no benchmarks for the fuzz and invariant test features, so it's hard to know how good forge actually is compared to other tools like echidna and harvey.
Echidna has a lot of test cases in its repo, maybe those can be used? https://github.com/crytic/echidna/tree/master/tests/solidity
Additional context
No response

Hi guys, I'm taking this up.

since this was opened, this was created: https://github.com/Consensys/daedaluzz
results: https://consensys.io/diligence/blog/2023/04/benchmarking-smart-contract-fuzzers/

and this: https://twitter.com/agfviggiano/status/1682631396702003200
results:

personally, I would close this and point to these benches

Sorry, the issue description is unclear here—the intent was to develop benchmarks and include them in CI or maintain the benchmark results somewhere. Equally important to comparing against echidna/etc is having a concrete way of measuring how changes to the forge fuzzer impact it's performance
I agree we don't need to develop our own benchmarks now and can use these, just need to actually integrate them into CI / persist results somehow for comparison when we make future fuzzer changes

These benchmarks should not be taken seriously other than a superficial comparision.

These are really great guidelines for designing a benchmark https://github.com/fuzz-evaluator/guidelines


multiline input label

Hey guys!
There is a problem if you have a label that is longer than 1 line. The label will overflow the input.
regards

That is unfortunate.
However such a use of floating labels is not covered by the material design spec, and it sounds like poor UX. Labels spanning two lined are specifically listed as things you should not do from the spec in various other components (bottomnavigation for example, see here https://material.google.com/components/bottom-navigation.html#bottom-navigation-style ).

Yeah I would rather avoid it also. Unfortunately on devices with less vertical real estate it is unavoidable for some use cases I have.
Are you against supporting this, if not I can look into it.

Not against it at all. I am sure a PR is welcome (it's Javi's call). If it requires a lot of css changes I would suggest you base it from the css-next branch.

Agree! Sorry for the delayed response!


Don't copy things in Dictionary::Set

I'm not sure why this isn't done this way in gin upstream, so perhaps I'm missing something. Without this, though, electron tries to call the copy constructor of net::CertPrincipal, which doesn't have a copy constructor—it isn't marked DISALLOW_COPY_AND_ASSIGN in Chromium, but it should be.

Since we are going to move to gin in future, I think it is probably better to fix the problem now instead of working around it.
The compiler should be able to automatically move the value, which change caused the compilation to fail?

I've upstreamed this change to gin, too: https://chromium-review.googlesource.com/c/chromium/src/+/1029204

The change that caused the failure was enabling the chromium-style checker, which warns when copy-constructors are automatically created for complex classes. In electron/atom/common/native_mate_converters/net_converter.cc, we call Dictionary::Set with a net::CertPrincipal, which is a complex class without a defined copy-constructor. The chromium-style checker throws an error there, with a message saying that net::CertPrincipal is a complex class which needs an out-of-line copy-constructor. That error doesn't trigger in Chrome's build because that class is never copied. net::CertPrincipal ought to have the DISALLOW_COPY_AND_ASSIGN macro—if it did, then electron's usage of the copy constructor in net_converter.cc would have thrown an error.

Upstreaming the change is great 👍 .


CLI tools for Zarr V2->V3 conversion

I've developed a few CLI tools in zarrs_tools (crates.io / GitHub) that may be useful to some for this challenge.
These tools have not been extensively tested with real-world Zarr V2 data, since we don't use Zarr V2 in my lab.
zarrs_reencode
Convert a V3 compatible subset of Zarr V2 arrays to Zarr V3. Many parameters are available for the output array encoding.
zarrs_reencode \
--chunk-shape 32,32,32 \
--shard-shape 256,256,256 \
--bytes-to-bytes-codecs '[ { "name": "blosc", "configuration": { "cname": "blosclz", "clevel": 9, "shuffle": "bitshuffle", "typesize": 2, "blocksize": 0 } } ]' \
--separator / \
--attributes-append '{ "looking forward to": "OME-Zarr v0.5" }' \
array_v2.zarr array_v3.zarr

zarrs_info
Output the V3 equivalent metadata of a V2 array if it is compatible with only a metadata change. It works for groups too.
zarrs_info group_v2.zarr/array metadata-v3
zarrs_info group_v2.zarr metadata-v3

It takes care of things like the typesize in blosc codec metadata.
zarrs_ome
Generate multiscale arrays for visualisation.
zarrs_ome array.zarr array.ome.zarr

Since last year, my lab has used zarrs_ome to create sharded Zarr V3 multiscale images ($\gtrapprox3000^3$) for visualisation in neuroglancer.

Really cool!

Agreed! I'll compare the outputs (and hopefully the speeds) against a couple of other implementations, hopefully starting later this week.

Reencode 4496763-v2.zarr/0 to 4496763-v3-reencode
	read:  ~152.78ms @ 3.60GB/s
	write: ~648.93ms @ 0.77GB/s
	total: 801.71ms
	size:  550.78MB to 502.71MB (838.86MB uncompressed)

:+1: (Trying to get an apples-to-apple comparison with, say, tensorstore now)

Closing this. For anyone interested in trying this out, see the --output-script option.


TIGRESS timestamp errors in TDataParser

Recently TIGRESS data has been throwing a ton of error messages during data parsing. Looking back at previous versions, it seems to have happened when a fix was applied (adding a closing "}") in the SetTIGTimeStamp function, changing from:
time[2] = *(data +x);
if((time[2] & 0xf0000000) != 0xa0000000)
   // this is ok, it always happens for tig64s.

currentfrag->TimeStampLow = time[0] & 0x00ffffff;
currentfrag->TimeStampHigh = time[1] & 0x00ffffff;
//currentfrag->SetTimeStamp();
return true;

x+=1;
time[3] = *(data +x);
if((time[3] & 0xf0000000) != 0xa0000000) {
   printf("here 2?\n");
   return false;
}
x+=1;
time[4] = *(data +x);
if((time[4] & 0xf0000000) != 0xa0000000) {
   printf("here 3?\n");
   return false;
}

   return true;

... to:
time[2] = *(data +x);
if((time[2] & 0xf0000000) != 0xa0000000) {
	// this is ok, it always happens for tig64s.
	currentFrag->TimeStampLow = time[0] & 0x00ffffff;
	currentFrag->TimeStampHigh = time[1] & 0x00ffffff;
	//currentFrag->SetTimeStamp();
	return true;
}

x+=1;
time[3] = *(data +x);
if((time[3] & 0xf0000000) != 0xa0000000) {
	printf("here 2?\tx = %i\t0x%08x\n",x,time[3]);
	return false;
}
x+=1;
time[4] = *(data +x);
if((time[4] & 0xf0000000) != 0xa0000000) {
	printf("here 3?\tx = %i\t0x%08x\n",x,time[4]);
	return false;
}

return true;

Now it's possible to get past the first if statement we're now receiving a ton of errors from the two following statements.
Firstly, I'm not entirely certain what the purpose of the second two if statements is and they're resulting in us losing a large amount of data. If this is genuine it would indicate that we've got some rouge TIG10s spewing out nonsense timing information, which would obviously be handy to know and pin down.
Secondly, it seems that it is possible to return a true value here while not actually setting the timestamps, is this intentional?

Which commit or PR did this happen in? You can reference it using # and the number. Just helps pin down who did it and why. I'm assuming this is something @pcbend will have to comment on.

The change was passed to the master when the multiset branch was merged  (#608). Which probably isn't a whole lot of use. The commit number is: b8ebbe8... etc.

Looking at the changes I've made there, this was an error on my part. During that commit I went through a lot of the code and changed the formatting of the comments. I took that as an opportunity to remove code that wasn't used (commented out or after a return statement). Looking at the original function, I'm guessing that I thought at that point that the brackets got lost somehow. Since that is apparently not the case, we should just change the curly-brackets after the first if-statement and remove everything after the return:
time[2] = *(data +x);
if((time[2] & 0xf0000000) != 0xa0000000) {
   // this is ok, it always happens for tig64s.
   currentfrag->TimeStampLow = time[0] & 0x00ffffff;
}
currentfrag->TimeStampHigh = time[1] & 0x00ffffff;
//currentfrag->SetTimeStamp();
return true;

I'm not sure if that is the correct way to read Tigress data, but that is essentially how it was done in the initial commit. What format do you expect the timestamp to be in for the different Tigress modules?

The way I thought this was working was:

read two words (time[0] and time[1]) and check that the highest nibble of time[1] is 0xa
read another word (time[2]) and check whether it's highest nibble is 0xa, if it's not use time[0] and time[1] to create a timestamp, and if it is, try and read two more words (time[3] and time[4]) both of which must have a highest nibble of 0xa

So the format should be either two timestamp words, with the second having the 0xa nibble, or five words with the last four having the 0xa nibble. What does the data look like that it's failing on right now? Could you run without the --suppress-errors and paste some of the "corrupt" events here?

OK. Looking at the data, it seems we really do just have a single TIG-10 spewing out errors. For whatever reason, it is duplicating the timestamp low (or high), so it passes the first condition (because there are three or more 0xa nibbles) but then fails the rest.
E.g.:
0x80017d84 0xb1f83053 0xc1100700 0xa0c92bee 0xa1001312 0xa1001312 0x6c92ae52 0x50000673 0x4c92ad27 0xe0017d84
...or:
0x80017db2 0xb1f8306c 0xc1100706 0xa038d062 0xa038d062 0xa1001315 0x638cf465 0x50001c46 0x438cf2af 0xe0017db2
Incidentally, the TIGRESS does not output the events without --suppress-errors. This is because even when it fails in TDataParser it returns NumFragsFound (which is always > 0). Any objections to me changing this to be more like GRIFFIN (i.e. return -x if there's an error)?
Cheers.


Error calling enhanced Prisma methods when using Prisma Accelerate

Description and expected behavior
I was setting up Prisma Accelerate to reduce latency and mitigate cold start times of my Vercel functions.
My prisma is enhanced through zenstack. When using enhancedPrisma for queries, I get errors in the screenshot below.
I've also tried doing npx zenstack generate --no-engine and it doesn't work
Screenshots

Environment (please complete the following information):

ZenStack version: 1.7.0 (and "@zenstackhq/runtime": "1.7.0")
Prisma version: 5.7.1
Database type: Postgresql

Additional context
@ymc9 mentioned on Discord the following:
It seems to be caused by the default large transaction timeout used internally by ZenStack. Looks like a new limit set by Prisma Accelerate.

In V2 we're adding an option to configure it. Maybe we should integrate that change to the next V1 release to unblock.

@ymc9 Tested it and it works great! Huge huge thanks to ya for pushing the updates 🙌


Provide more widget const constructors.

Still many more to go.
@a14n a lint which would be useful (not for leaving on all the time, but for development) would be one that finds constructors of subclasses of @immutable classes that are not const and whose bodies contain nothing but asserts. :-)

This is slightly scary in the sense that we're committing to keeping these const.

I would like this to help drive a greater and greater ability to do things const (see the various Dart bugs I filed when doing this that are mentioned in the patch). Other than limitations of Dart today, I didn't run into anything to prevent us from making every Widget I looked at const. (The limitations being things like: calling const constructors from const constructors based on the constructor's parameters; creating derived Lists using "map" and constant expressions; asserting things about List parameters; calling methods that themselves only contain constant expressions...)


Refactor GDT Backgrounding

Edited to better summarize the change:
This PR does a few things. Primarily, it refactors the backgrounding for GDT and GDTCCTSupport in an attempt to prevent unnecessary background tasks being generated, and hopefully not crash in the background any more. It also cancels active tasks once they have run out of background time.
This also refactors some tests - split the tests into a specific multithreaded test and a recursive run without crashing. It also adds a notification for the upload to post how many events were
uploaded. This should be a bit more reliable and helps the overall
validation during the "run without crashing" test.

Relevant to #3893 but not necessarily a fix for it.

Made this a larger change, adjusting how we handle background tasks as a whole. I think this should help but would love some extra eyes on it.
I believe the original assumption of requesting a background task when going into the background then cancelling when the completion handler gets called means every single time the app is backgrounded it'll execute for the full amount of time. This isn't what we want, especially if no work was being done. A lot of those lifecycle methods are empty now so there's some potential for refactor as well.

I've refactored the GDTFLLIntegrationTest.m file quite a bit - I'll do the same to CCTIntegrationTest but wanted to get this reviewed first to see if it's reasonable or not.

Might as well update the CHANGELOGs, too

@mikehaney24 @paulb777 I believe this is in a proper form to merge once reviewed. Added CHANGELOG entries, bumped the podspec versions, etc.
PTAL when you get a chance!


TabPanel childs are not correctly destroyed and throw errors

when the window (reactified) is closed all Tabs inside TabPanel (exept first one) will throw an error
because this.el is null

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of extjs-reactor.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

is it posible to merge the code in master and publish new version?
at least until we migrate to ext-react, this bug blocks entire UI, and UI froze forever because of this error:
(Uncaught (in promise) TypeError: Cannot set property '_extIndexInParent' of null)

Thanks.

one reason is that not rendered components are not destroyed in the same way. so for tabpanel I've used: deferredRender={false}
<TabPanel deferredRender={false} ...> to make sure all childs tabs are rendered and get the flow to work.


Is nginx 1.24 incompatible with 3.0.10?

2023/09/15 14:53:26 [notice] 115450#0: ModSecurity-nginx v1.0.3 (rules loaded inline/local/remote: 0/8/0)
2023/09/15 14:53:26 [notice] 115450#0: signal process started
2023/09/15 14:53:26 [emerg] 35919#0: module "/usr/local/nginx/modules/ngx_http_modsecurity_module.so" version 1022001 instead of 1024000 in /usr/local/nginx/conf/nginx.conf:12
nginx version: nginx/1.24.1
modsecurity-v3.0.10.tar.gz

[root@localhost nginx]# ./sbin/nginx -v
Tengine version: Tengine/3.0.0
nginx version: nginx/1.24.0
2023/09/15 14:53:26 [notice] 115450#0: ModSecurity-nginx v1.0.3 (rules loaded inline/local/remote: 0/8/0)
2023/09/15 14:53:26 [notice] 115450#0: signal process started
2023/09/15 14:53:26 [emerg] 35919#0: module "/usr/local/nginx/modules/ngx_http_modsecurity_module.so" version 1022001 instead of 1024000 in /usr/local/nginx/conf/nginx.conf:12
What is the reason for this problem? Is nginx 1.24 incompatible with 3.0.10?

> 2023/09/15 14:53:26 [notice] 115450#0: ModSecurity-nginx v1.0.3 (rules loaded inline/local/remote: 0/8/0) 2023/09/15 14:53:26 [notice] 115450#0: signal process started 2023/09/15 14:53:26 [emerg] 35919#0: module "/usr/local/nginx/modules/ngx_http_modsecurity_module.so" version 1022001 instead of 1024000 in /usr/local/nginx/conf/nginx.conf:12
>

What is the reason for this problem? Is nginx 1.24 incompatible with 3.0.10?

seems like you've built your module (the connector) with Nginx 1.22.1, but now you want to use that with Nginx 1.24.0.


Unable to add Helm Chart

Error: looks like "https://googlecloudplatform.github.io/spark-on-k8s-operator" is not a valid chart repository or cannot be reached: failed to fetch https://googlecloudplatform.github.io/spark-on-k8s-operator/index.yaml : 404 Not Found

Same problem here. I´m using version 1.1.27 of spark-on-k8s-operator. It´s Failing to fetch https://googlecloudplatform.github.io/spark-on-k8s-operator/index.yaml. It seems that the repo has been closed or removed.

Error: looks like "https://googlecloudplatform.github.io/spark-on-k8s-operator" is not a valid chart repository or cannot be reached: failed to fetch https://googlecloudplatform.github.io/spark-on-k8s-operator/index.yaml : 404 Not Found

The helm repo has moved from https://googlecloudplatform.github.io/spark-on-k8s-operator to https://kubeflow.github.io/spark-operator, you can do as following:
# Remove old helm repo
helm repo remove spark-operator

# Add new helm repo
helm repo add spark-operator https://kubeflow.github.io/spark-operator

# Update helm repo
helm repo update

# Install the chart
helm install spark-operator spark-operator/spark-operator


Dump SPIRV kernel in benchmark_driver.py

Closes #2536
Mostly copying from https://github.com/intel/intel-xpu-backend-for-triton/pull/2258 with minor code style adjustments.

This PR is LGTM.
BTW: Can we unify the XPU launcher of microbench to the one in Triton XPU? It reduce our effort to sync the changes on the launcher.
There is already some environments to control the legacy profiling stubs in the launcher.

This PR is LGTM. BTW: Can we unify the XPU launcher of microbench to the one in Triton XPU? It reduce our effort to sync the changes on the launcher. There is already some environments to control the legacy profiling stubs in the launcher.

I will take a look: https://github.com/intel/intel-xpu-backend-for-triton/issues/2540


Dependabot updates

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.24%. Comparing base (3210c6c) to head (df46371).
Report is 2 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #12   +/-   ##
=======================================
  Coverage   97.24%   97.24%
=======================================
  Files           8        8
  Lines         218      218
  Branches       40       40
=======================================
  Hits          212      212
  Misses          1        1
  Partials        5        5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Workspace-level environment variable definitions

Often I find myself wanting to associate a workspace with an environment variable (e.g. server domain name, development/production tag) but do not want to create a global system environment variable or pollute ~/.bash_profile with such a variable. I would like such an environment variable to be associated only with the workspace "namespace" and be used for tasks, launch configs and integrated terminals started in that workspace.
I would like to suggest adding an env section to the .code-workspace file format similar to that shown below. It is crucial that a .env file argument be supported to allow environment variables to be excluded from source control (e.g. non-source controlled variables could be placed in  .env file which is specified in .gitignore).
Then different "flavours" of the same workspace (each using different clones of the same repos) could be used on the same computer - great for side-by-side comparison debugging or temporarily experimenting with a different setup etc.
{
	"folders": [
		{
			"name": "Api",
			"path": ".."
		},
		{
			"name": "Processing",
			"path": "../../client/Processing"
		}
	],
	"env": {
		"NODE_ENV": "development",
		"DOMAIN": "backend.example.com"
	},
	"launch": {
		"configurations": [],
		"compounds": [
			{
				"name": "Api + Ws",
				"configurations": [
					"Api",
					"Ws",
				]
			}
		]
	}
}

An extra note. As VS Code project/folder files like launch.json are often put into source control, would be really nice if env could be supported at both top and folder levels within .code-workspace file. This would allow .code-workspace to inject environment at both workspace and folder level independent of source-controlled files. Many possibilities would then be opened up including multiple clones of the same repo that run with different environment etc.

Another workaround:
"terminal.integrated.env.linux": {
    "CARGO_HOME": "${env:HOME}/dev/sdk/cargo",
    "RUSTUP_HOME": "${env:HOME}/dev/sdk/rustup",
    "PATH": "${env:HOME}/dev/sdk/cargo/bin:${env:PATH}"
}

This config works good in integrated terminal, but cannot be used by rls-vscode: rust-lang/rls-vscode#721

An extra note. It would be really nice if env could be supported at both workspace and folder levels. This would allow to configure environment at both workspace and folder levels directly or through .gitignore-able env files. This would open up possibilities including multiple clones of the same repo in the same workspace that run with different environment etc. Would be great for comparing and debugging!
Many thanks for considering this feature which I think would greatly enhance VS Code. 😀
NB: note workspace- and folder-level environment is hopefully not just for launch configs but also tasks and terminals.... removing the need for global environment settings....

FYI I have edited the above comment to remove suggestion of putting folder-level environment in .code-workspace as, now having many repos in my workspace, I am really hoping VS Code will embrace repo auto-detection (https://github.com/microsoft/vscode/issues/87888) to reduce the high maintenance associated with a .code-workspace when constantly adding and removing workspace repos.
I will open a new feature request for folder-level environment which could be provided e.g. in .vs-code/env.json. This feature request still stands though as global environment per workspace would be such a useful feature.

I found this while I was looking to answer a similar request;
I am assuming that these "workspace environment variables" would be visible to the extensions (which is what I was after):
I have a few applications, which are configured through environment variables. I don't want to introduce those environment variables in my shell where I invoke code.
They should be part of a code workspace, which makes for a self-contained debug environment.
Right now, I need to update environment variables for each extension that I'm using (e.g. Perl and Perl Critic/lint), and then there are extensions that don't let me set those environment variables (e.g. Perl Critic/syntax check).
Setting the variables ONCE, in the workspace settings, and export them to all the extensions would be absolutely wonderful...

@beltaurus Thanks for your comment. My proposal is these variables be not global but "associated only with the workspace namespace and be used for tasks, launch configs and integrated terminals started in that workspace." They might for instance point to a server or give an API version etc. i agree with making them visible to extensions also.
I am basically hoping for namespaced environment variables that are available in the same places as global environment variables when within a workspace "namespace".

I'm also looking for this feature. Ideally, I'd like to be able to declare environment variables within my workspace folder, but also permit those that are declared there to be overwritten by a .env file present on my file system. This .env file would not be saved with my project/workspace, but optionally declared by each developer using the project.
My specific use-case is for C/C++ tooling, where I need to declare an SDK_ROOT env and a GNU_INSTALL_ROOT env. There is no default location for these variables as each developer will locate them on their file system as they wish. Having the workspace declare them with, say, null values could then lead to VS Code hinting that a .env file is required with their assignment on loading the workspace/project.

I'm a maintainer of corker.vscode-micromamba extension. This extension aims to allow VSCode IDE users to configure dev environments automatically by utilizing micromamba - an alternative for conda built with C++. E.g., when a developer wants to start a nodejs project. The extension could automatically install nodejs in a virtual environment from conda-forge using micromamba. Virtual environments, in fact, are just a set of environment variables, including modified PATH. It's possible to configure terminal environment variables when a virtual environment is created. This is what python extension is doing when activating a virtual environment. But in the case of vscode-micromamba other extensions, like jest, or go-extension need to know about these modified environment variables, which is not possible. Some extensions could handle DotEnv files, and this way, they could be configured to work, but many are not. Adding a possibility to tell a workspace to use a DotEnv file via settings would be a great possibility for me to make vscode-micromamba integrate nicely with any extension out of the box.

This is very needed feature with multi-workspace project as well. Defining variables would make easier adapting the project configuration for cross-platform usage and conditional compilation with C++;

Here's another use case in case that helps: I have one project here that needs a different version of Java than everything else on the machine. So to develop on that one I need to make a shell script that sets JAVA_HOME to the right value, then launches vscode with that environment. And remember not to run multiple windows in that state.

I've got the same situation as @dseynhae - multiple perl workspaces, each with its own vendored libs dir and PERL5LIB should point to correct dir in each project.


[MongoDB CDC] Fix “pollAwaitTimeMillis” does not take effect #1994

The use case of CI failure has nothing to do with this PR.
Merged into mater.


Zip Download

sequenceDiagram
    Client->>+API: Generate a signed URL for zip download
    API-->>-Client: Signed Zip Server URL
    Client->>+Zip Server: Request Zip with signed URL
    Zip Server->>+API: Ask for Zip File Descriptor
    API-->>-Zip Server: Zip file descriptor
    par
        Zip Server->>+S3: Get image files
    and
        Zip Server->>+API: Get metadata and attribution files
    end

    Zip Server-->>-Client: Send zip file


chainsaw: 2.8.0 -> 2.8.1

Diff: https://github.com/WithSecureLabs/chainsaw/compare/refs/tags/v2.8.0...v2.8.1
Changelog: https://github.com/WithSecureLabs/chainsaw/releases/tag/v2.8.1
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 269132 run on x86_64-linux 1

1 package built:

chainsaw


Adding "A Primer on Design Patterns"

What does this PR do?
Add "A Primer on Design Patterns" by Rahul Batra
For resources
Free programming books
Why is this valuable (or not)?
Requested by #5515
How do we know it's really free?
https://leanpub.com/aprimerondesignpatterns/ shows that it's a pay-what-you-want price with suggested price of $5 and a minimum of $0. Book is accessible directly at https://leanpub.com/aprimerondesignpatterns/read
For book lists, is it a book? For course lists, is it a course? etc.
Book
Checklist:

[x] Read our contributing guidelines
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction)

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

need to fix this branch too one sec


Fix examples

The s2i example that is linked on the official site does no longer work, the image beeing used seems to be missing. https://blog.openshift.com/create-s2i-builder-image/
The link to the example in the README of this repo results in a 404.
 ✘  ~/Downloads/s2i-lighttpd  s2i build test/test-app/ lighttpd-centos7 sample-app --loglevel=3
I0308 12:27:06.889018    3533 main.go:69] Running S2I version "1.1.4"
I0308 12:27:06.890705    3533 docker.go:491] Image "lighttpd-centos7:latest" not available locally, pulling ...
I0308 12:27:08.050227    3533 main.go:148]
Error describing image:     unable to get lighttpd-centos7:latest
Source:             test/test-app/
Output Image Tag:       sample-app
Environment:
Labels:
Incremental Build:      disabled
Remove Old Build:       disabled
Builder Pull Policy:        if-not-present
Previous Image Pull Policy: if-not-present
Quiet:              disabled
Layered Build:          disabled
Docker Endpoint:        unix:///var/run/docker.sock
Docker Pull Config:     /home/cars10/.docker/config.json
Docker Pull User:

I0308 12:27:08.052440    3533 docker.go:491] Image "lighttpd-centos7:latest" not available locally, pulling ...
E0308 12:27:09.196164    3533 errors.go:266] An error occurred: unable to get lighttpd-centos7:latest
E0308 12:27:09.196196    3533 errors.go:267] Suggested solution: check image name, or if using local image add --pull-policy=never flag
I0308 12:27:09.196216    3533 errors.go:269] Details: Error response from daemon: {"message":"repository lighttpd-centos7 not found: does not exist or no pull access"}
E0308 12:27:09.196233    3533 errors.go:273] If the problem persists consult the docs at https://github.com/openshift/source-to-image/tree/master/docs. Eventually reach us on freenode #openshift or file an issue at https://github.com/openshift/source-to-image/issues providing us with a log from your build using --loglevel=3

@cars10
That post is from July 21, 2015, almost two years ago.  Unfortunately old blog posts are rarely updated as products change.  You should instead try using the example that is included in the source-to-image repo here: https://github.com/openshift/source-to-image/tree/master/examples/nginx-centos7

The 404 is still present in the readme :(


chore: github actions workflow for tests / visual regressions

@jennifer-richards now that we've got unit tests I've added a workflow to run those, TS, and linting on CI.
Because the Nuxt build and TS require the generated API client we'll need to have the client on CI. It would be best to generate that on CI so that we have current types, but I've temporarily commited the API client (which is a single file) to test this workflow.


README tweaks

Just sending you some fixes for the README in case you want to use (some of) them.
Thanks for this Github Action Dani!

Oh! Thank you Carlos!! :)


Query Lazy Loading missing md-icon

possible bug? Query.
Just trying this framework out with Lazy loaded modules and getting the following error on lazy routes. normal routes load OK.
Error
if 'md-icon' is an Angular component, then verify that it is part of this module.
All Material 2 objects, I would expect to be loaded in the root NgModule using .forRoot()?
Thanks
Chris

Do you have a repo and branch we can check the code or something? Would like to dive into this a little bit and replicate it.

Hi,
I've created this https://github.com/chrizy/covalent-quickstart
In the left hand menu select Lazy and it will load LazyModule, which contains a test component with a md-card
thanks

seems to work if I add this to the lazy module
import { MaterialModule } from '@angular/material';
@NgModule({
imports: [
MaterialModule
is that right, as you don't need to import this as the app.module level?

Awesome, will check it out, and get back to you if i find anything.

Ok, so i understand the problem now. (got confused with the lazy loading thing)
Yes, you do need to re-import all the modules needed in a sub-module since every module is an encapsulated environment of components.
So in lazy.module.ts you need to add CovalentCoreModule.forRoot() as import (which has MaterialModule inside)
For example in covalent:
https://github.com/Teradata/covalent/blob/develop/src/app/components/components/components.module.ts#L60-L72
We have 4 submodules (this is the components.module.ts) and we have to re-import everything..
This is because imports, declarations, providers and stuff like that are not shared between modules to allow Applications to scale easier. (modularity)
I think we need to add sub-module examples in covalent-quickstart to make it easier for people to do so.

@emoralesb05 I'm not sure this isn't a typo, but you don't want to import CovalentCoreModule.forRoot() in every feature module, you should import just CovalentCoreModule.

agreed, from reading the docs a bit more, .forRoot() should not be used in a feature module,
Thanks for the help.
Now working..

Awesome.
So yeah, i didnt know providers were shared haha, so there is no need for the forRoot() in a sub module
Closing this issue since it wasnt covalent related.


Reload on localhost/php not changing the content

I have a php file in localhost/php named index.php with this code:
echo "Hello world!";
echo "Hello world 2!";
My actual server address: http://localhost/php/
My live server address: http://<IP_ADDRESS>:5500/
but  when I change my index.php code and save, the new code does not refresh in the browser of http://localhost/php/ like on the ritwickdey YouTube video.  I used firefox and chrome web extensions.  What am I missing?

Hi, I have just updated the documentation. Can you check if you have missed Step 5 that I added now.
You have to put your app on the http://localhost/php/ location.
Let me know if you've tried it. If it doesn't work, I want to help you figure it out so I can update the documentation further to clarify the misunderstandings.

I put index.php in the php folder on http://localhost/php.  Still no change.

I got it to work for Firefox and Chrome!  All I did was reinstall the extension for both and it works with the steps listed.  Thanks.

It's good to hear and thank you for the feedback! I hope you get a good experience of this add-on.

Hello, i set-up every thing as described in the steps given but still not work,
Actually, it worked with the test file and when I umped to production files... nothing
I reviewd all the steps many time
any chages in the meanwhile?
(mac os catalina 10.15.6 / Mamp Pro 5.7 / VS Code 1.47.2 / Live-server 1.3.0)


inversion prop

Hi, it would be useful to have a prop that allow to choose of invert moon when there is light theme and sun when there is dark theme instead now by default it's the opposite, to do it now we have to modify animationProperties but this is uncomfortable.

Hi,
you can do it like that too:
<DarkModeSwitch checked={!darkMode} onChange={toggleDarkMode} moonColor='black' sunColor="white" />

Set checked={!darkMode} and change the sun and moon color.


HTML Auditing

HTML Code Review and Fix
There are many mistakes that needs to be fixed, mainly html semantics and good practices on coding html, such as

Using TR TD outside from tables
Insert a heading into span
Using html attributes for widths heights
etc.

This issue was moved to Code4SocialGood/c4sg-web#39


Creating Amplify Console App

I was trying to deploy one of your fullstack samples in the Amplify Console and kept running into this error. Any tips on how to fix this issue?

@Dcalligy thanks for reporting this. It seems there's an issue with the Authentication starter that we'll need to investigate - can you try a different one for the time being?

@Dcalligy can you give it another try?

@kahdojay it worked! Appreciate your help!


Automated Benchmarking for Provider Creation Time

What is the expected feature or enhancement?
Write an automated benchmarking test to measure provider creation time. Creation time is currently at 7-8 seconds (for qiskit-ibm-provider) which is below the optimal 2-3 second creation time defined by @blakejohnson in Qiskit/qiskit-ibm-provider/issues/555, so we want to introduce automation to ensure we notice regressions.
Acceptance criteria

Tool accurately measures provider creation time
Fail test if creation time falls below a certain threshold
Integrate with current cloud staging tests that are run prior to release

@blakejohnson per your suggestion. Please let me know if you have any edits.

Fail test if creation time falls below a certain threshold

Thanks for opening this. If you are defining pass/fail criteria, then you would fail if you exceed a threshold.
However, what I really want is something that records the outcome of the benchmark so we can track this metric over time. You might consider using ASV to produce a dashboard like what we have for Qiskit. Then it isn't so much about rejecting changes the fail the test once, but to observe that we are actively driving this time lower.

@blakejohnson Thanks for the feedback. I updated the second acceptance criteria to reflect the goal of tracking over time.


Better in-code documentation

From now on, we need to make sure to properly use Javadoc tags in the classes we maintain or create. The state of the documentation is terrible, and we need to be able to go back to code in the future and know exactly how it works.

I could probably take a look at this when I have some time.

You're right. @fadils and I can also look at adding a wiki page for contributing with some guidelines.


Modular Rocket Systems, "Lite" and normal versions should not be installed together.

The full version of MRS, and it's "Lite" counterpart should be treated as mutually exclusive, as one is a subset of the other, and they will interfere if both are installed concurrently. Is it possible to disallow installation of both, or at least throw a warning to the user if they try?

Mutual conflicts relationships added to each mod in the above PRs.


Fetch new token when while not having a refresh token

Umbraco version: 12.3.1
Umbraco.AuthorizedServices version: 0.3.1
Issue
I have added a new service, using OAuth2ClientCredentials.
My defined service looks like this:
"DanfossTerms": {
  "DisplayName": "Danfoss Terms API",
  "AuthenticationMethod": "OAuth2ClientCredentials",
  "ClientCredentialsProvision": "AuthHeader",
  "ApiHost": "https://e2e.api.danfoss.com/terms",
  "TokenHost": "https://e2e.api.danfoss.com",
  "AuthorizationUrlRequiresRedirectUrl": false,
  "RequestTokenPath": "/oauth2/token",
  "RequestTokenMethod": "POST",
  "RequestTokenFormat": "FormUrlEncoded",
  "ClientId": "<Set in Azure>",
  "ClientSecret": "<Set in Azure>",
  "AccessTokenResponseKey": "access_token",
  "ExpiresInResponseKey": "expires_in",
  "SampleRequest": "/privacypolicies?culture=en&include_content=true",
  "RefreshAccessTokenWhenExpiresWithin": "00.00:00:40"
}

When requesting a token from the endpoint, I get the following response:
{
    "access_token": "LgHqimayLHHpRVicBQLa2Ag2JayE",
    "token_type": "Bearer",
    "expires_in": "3599"
}

Everything works fine up until my returned token expires.
I would expect Umbraco.AuthorizedServices to just fetch a new token, but I am getting the following response in Umbraco, when I click Verify Sample Request:
Authorized Services: The sample request did not complete: Cannot request service 'DanfossTerms' as the access token has or will expire and no refresh token is available to use. The expired token has been deleted.`

Looking at EnsureAccessToken(), it seems that my token always will get cleared when I don't have a refresh token present.
How would I go about fetching a fresh token before my token expires or when it has expired?

I think at that point it's necessary to go back into the backoffice and manually request another token.  As without a refresh token, we would require the user to log into their account and accept the permissions before another access token would be issued.
Maybe there's some UI improvements we could consider here to make it a little more obvious when a token is expiring.  But I'm not sure it's possible to handle in an automated way without user involvement.  Open to suggestions though if you had an idea how this could work.

As I understand, Client Credentials is meant for applications to obtain an access token outside of the context of a user.
It seems a bit counterintuitive that a user must actively request a new token when using Client Credentials as authentication method.

Sounds great! Thank you for looking into it.

You should find this resolved as part of the 0.4.0 release, which I've just pushed out to NuGet.

This is great! Thanks Andy!


Pasting single line long string

In Mac OS X when you paste a minified file like jquery.min.js or bootstrap.min.css Atom crashes or stays unresponsive for a minute or two.

Thanks for the report! This looks like a duplicate of https://github.com/atom/atom/issues/979 – please subscribe there for updates.


[#95612064] Allow listen addresses and port to be configured

Expose them as variables so that we can put Hipache on a different address
and port. Such as localhost:8080, to be frontend by Nginx.

:+1:


Support element-ios as a trafficlight adapter

Create an adapter; make it work locally in combination with the element-web adapter.
Once complete we can work out how to integrate it into a kubernetes-based deployment to run these tests nightly.
Before then; just getting it working locally is fine.

trafficlight-adapter-appium is fufilling this role atm.


[BUG] Yoopta is messing up global styles

Has this bug been raised before?

[X] I have checked "open" AND "closed" issues and this is not a duplicate

Description
We are using shadcn and consequentially tailwind to build our webapp. As soon as we use any yoopta tool, plugin, mark or editor it messes up global style especially borders
Steps to Reproduce

init a next.js project
setup a theme switcher using next/themes
setup shadcn/ui
copy any block
add a yoopta editor anywhere

Environment

OS: MacOS Sonoma 14.5 (23F79)
Browser: Arc Version 1.54.0 (52220) [Chromium Engine Version 127.0.6533.89]

Screenshots
before yoopta

after yoopta

Do you want to work on this issue?
No
If "yes" to above, please explain how you would technically implement this
No response

Related to https://github.com/Darginec05/Yoopta-Editor/issues/186

Yes, that's annoying behaviour.
It will be fixed in the next version

@debkanchan :D

Hey comrades @g-wozniak @debkanchan!
I just published -rc 4.6.10-rc.0 version with this fix
Could you check it please?
If everything is good I'll publish stable version today

Da comrade! It works

Works great to me as well. Thanks!

@debkanchan roger that, I'll prepare stable version
@g-wozniak thanks for sponsoring ❤

Fixed in v4.7.0 🎉


Construct and convert builtin floats

This pull request deals with construction and conversion to/from built-in floating-point types such as float, double and long``double.

In the first commit above, co0nstruction from double (and other built-in floats) is runing a simple compile sanity chekc in CI.

This PR is working out the details of #47


griffinlim for Harmonix

Can you share the script for Harmonix reconstruction? or the argument for the function below ?
https://librosa.org/doc/main/generated/librosa.griffinlim.html

I have uploaded your requested script to "./processing_codes/harmonix_mel2wav.py". Please note that the reconstruction is NOT lossless (in fact very lossful, but still acceptable for the beat tracking task).

em... it seems lossful.. but the original youtube urls/alignment scripts are not enough to reconstrution.


Use any existing TIME hints in graph to do further ordering.

This patch is written for the benefit of this scenario sketch.  The additional linkage manages to reduce the lateral "sprawl" of the illustration.
Before (develop at 351afb9):

After (this branch):

An assumption of an alignment of PROV-O with W3C TIME is assumed, and cited in an inlined comment.

I'm postponing this for after case-prov 0.7.0.  That typo hid that the implementation wasn't really complete.
Some example two-node graphs should be written to show how each of the Allen algebra properties render with the graph flow direction already used by the PROV-O properties.

The PR now contains an implementation of OWL-Time ordering.  The README and recent patch notes document rationales and demonstrate new illustrations.
The SIEM scenario sketch from this PR's initial comment now looks like this:

The Urgent Evidence Activities graph is, to me, the most interestingly effected of the examples in this repository.  Investigative Actions were loosely piled topologically due to most not having information about how they influenced one another.  With timestamps now influencing vertical sort order, the provenantial links remain the same but the display is now ordered in a decent semblance of a timeline.  Here is the visual diff.


Design a logo for Hope, OLS's fifth cohort

Each OLS Cohort (group of mentored trainees) of OLS has a name. The cohorts are:

Open Seeds
Masked Cohort
Perseverance (like the mars rover)
Kenaz (a rune for openness)
Hope

➡ ➡ ➡  This issue is to suggest a logo for Hope only.
Image requirements:

Square
Vector format (ideally SVG, but any other vector format is fine too).
Not too complex - needs to make sense even when it's a small icon.

To participate - start by making sketches of your idea. Post a if it's on paper, or a screenshot if your earlier ideas are digital. Post your ideas in-thread - there is no need to make a pull request for this task.
Help each other and provide feedback on each others' designs.

Hello @yochannah would make sketches here and send

go for it!

hello @yochannah can I also make an attempt on this task too?

this is beautiful

This looks really good

Hello everyone, I decided to attempt this task, and here is the concept I came up with.
It's a tree inside a sun. I chose this because trees are known for their tenacity and because they can grow to heights of hundreds of feet almost anywhere, making them a universal symbol of hope. Here is a picture of the initial sketch and digital version

Nice concept you guys, but let's not forget one of requirements for the logo

 Hello, @yochannah I just uploaded a small logo in PNG that I think reflects Hope and the OLS Logo in one logo. Please check and let me know what you think. Thank you

I like this logo, depicts Life and Hope but you missed out on the requirement of it being a square logo so maybe you could just redesign it

Hey @yochannah so I was able to come up with roughly 6 ideas for the HOPE logo design. Please feedback from everyone would be highly appreciated

Hey @yochannah so I was able to come up with roughly 6 ideas for the HOPE logo design. Please feedback from everyone would be highly appreciated

It's really lovely, everything is great but u prefer the fourth one more

Hello everyone, I decided to attempt this task, and here is the concept I came up with.
It's a tree inside a sun. I chose this because trees are known for their tenacity and because they can grow to heights of hundreds of feet almost anywhere, making them a universal symbol of hope. Here is a picture of the initial sketch and digital version

I actually like this approach to the Hope cohort Icon design.

Hey @yochannah so I was able to come up with roughly 6 ideas for the HOPE logo design. Please feedback from everyone would be highly appreciated

This is really good, welldone😊

 Hello, @yochannah I just uploaded a small logo in PNG that I think reflects Hope and the OLS Logo in one logo. Please check and let me know what you think. Thank you

I like this logo, depicts Life and Hope but you missed out on the requirement of it being a square logo so maybe you could just redesign it

Oh, in this way, I suggest the owner can put it in a square frame. That way it keeps the circle and in references to size, it'll still work

Hey @yochannah so I was able to come up with roughly 6 ideas for the HOPE logo design. Please feedback from everyone would be highly appreciated

This is really good, welldone😊

The fourth one is good, straightforward and so nice, If I could draw lol. But It might work as an icon when the size is reduces. That first thoughhh, girrlll!!!. Well done

Hey @yochannah so I was able to come up with roughly 6 ideas for the HOPE logo design. Please feedback from everyone would be highly appreciated

This is really good, welldone😊

The second logo totally works for perseverance by the way ☺

Hey @yochannah so I was able to come up with roughly 6 ideas for the HOPE logo design. Please feedback from everyone would be highly appreciated

This is really good, welldone😊

Thankyouuu

Hey @yochannah so I was able to come up with roughly 6 ideas for the HOPE logo design. Please feedback from everyone would be highly appreciated

This is really good, welldone😊

The second logo totally works for perseverance by the way ☺

hmm yes you're right though, I might just submit that idea for that as well. Thankyou by the wayy

Hope loggo

i snip sketched due to poor camera.

This is the first suggestion. It's a logomark that has the letter "h" with the curves signifying streams of water. Water gives life, hope.
![1665576983178215918205288154747](https://user-images.githubusercontent.com/38887940/195340335-81f2fe95-937c-4aa5-998b-cba0922fa8d3.jpg

This logo symbol is a combination of a rising sun (to signify hope, breaking of new knowledge) and a box (signifying a controlled environment, depicting conditions scientists work in)

This logo is a word logo with a symbol of love. Love and hope has a huge correlation

this a sketch i made for hope @yochannah help check it out please

Hello @yochannah don't know if I'm a little late to this but can I work on this as well? Also, do the logo sketches have to be posted here or on the slack channel? Lastly, please what resources can we access to get a better understanding of what each cohort represents, so that we can get a better understanding of how to properly represent that in the logo?

Hi @mkpouto-inyang please go ahead and post your sketches here and you can check the OLS website to get understanding on the program. Goodluck!

Hello @yochannah this is my submitting for the Hope cohort logo.my thought process is that I used hands here to depict the word hope and the hope of achieving greatness in a community when it's members come together to help learn and grow together in the bid to achieve an end goal.the leaves in the center stands  for life and science which is what OLS is about.

This logo symbol is a combination of a rising sun (to signify hope, breaking of new knowledge) and a box (signifying a controlled environment, depicting conditions scientists work in)

I like how you made the sun merge together with the square box to give one continuous logo.has a deferent feel to it

Hey @yochannah so I was able to come up with roughly 6 ideas for the HOPE logo design. Please feedback from everyone would be highly appreciated

Really lovely sketches. Nice work. I resonate more with the First sketch. It gives me this helping hand feeling and the hope OLS gives with love.

@yochannah

@yochannah

@yochannah

Good afternoon everyone and @yochannah, took me a while to find this but i made few images that i think symbolizes hope. Kindly let me know what you all think

This logo symbol is a combination of a rising sun (to signify hope, breaking of new knowledge) and a box (signifying a controlled environment, depicting conditions scientists work in)

I like how you made the sun merge together with the square box to give one continuous logo.has a deferent feel to it

Love it

Hello. Here's my attempt to sketching a logo for Hope. Understanding the meaning of hope; Hope is a feeling of expectation and desire for a particular thing to happen. This informed the ideas I had while sketching. There were a few things that symbolizes hope, one is a dove, hence the first two designs(from your left) the V-like shape symbolizes a hand, in summary this symbolizes holding unto hope.
The second logo implies that the first point of hope is in the heart. You feel and expect and this blossoms everything around (the leaves). Hope in your heart, makes everything blossom
The last sketch was me imagining a hopeful person, one who's expectant. The story behind the logo was an open space with an expectant, yet an exciting person, excited about the star(symbol for something great).

Hi, This is my attempt at a suggestion for the hope cohort logo @yochannah
So I was looking at symbols and illustrations that represented hope and notices a lot of them were heart shapes or two hands holding each other or an object. But then I stumbled upon this really unique icon (unique as i haven't seen it anywhere else) and I modified it a little to how I think it would fit into OLS.

@msempath amazing design you have here 🥰I’ll go with the first, it’s giving a simple look

Hello everyone and @yochannah @Ismael-KG.
This is my own input on the development of a logo for the Hope cohort:
These are a few sketches I penned down, and the finished products afterward.

In this one, I decided to make it look like that, following the guidelines, where it requests that the logo be square.
However, rather than actually use a square box, I decided to make the square implied instead, using the formation of the letters. It is also made such that, in the event where the entire logo "HOPE", cannot be used, especially if it is to be a small icon, the icon representing the "O" can be used on its own and the same message would be communicated.
The logo is green. This green color was chosen because it is consistent with OLS' original colors. In the Logo, we also see two hands. These are the symbols of hope; even beyond hope by ourselves. The two hands signify hope in unity.
The rest of these are similar, but slightly different ideas I had, in different variations as well.

I am still yet to flesh out the last icon of the two hands and the half sun.
Please let me know what you think so far.

Hope Cohort,
hope thru giving each other courage and a hand is what is called Real hope. when we stand together we hoe for the great when we hope alone we hope in vain Help and hope move together.
and the logo is below.

@mkpouto-inyang - wow, those logos are very pretty. I especially like the fact that the colours are simple. If you had to simplify it so that it would fit on the top-left corner of a page (like logos often go), what steps would you take?

@msempath that's a gorgeous concept! I wonder if it would be visible when the logo was really small, though - is it possible to make the lines a bit stronger?

@Idowufaith-data wow, the dove and the heart hands are lovely concepts. If you made it a vector, what might it look like?

@Preciousutos some really nice concept sketeches! What might they look like as vectors?

@Caxri7 I love the way you've combined letters and hope-related concepts. What would be your next step if you vectorised it?

@salmasabo @iremide1022 your concepts are really lovely sketches - what might they look like if you make them into vectors?

I may have missed some people here - there are a lot of posts 😁  if I haven't fed back on yours, please do take sketches to the vector stage!

@niyolynate I like the concept, but it's perhaps a bit too colourful - what might it look like with only 1-3 colours?

Hope Cohort Logo.
The message in a logo says allot, Hope is a key to finishing any thing in life. if you lose hope you can get it from a friend. meaning in this work too we need hope. but our hope alone can diminish just like would burning, if one is removed it will stop burning. that's why giving a hand is very important as a cornerstone of hope. so i chose hands because giving a hand is giving Hope. just like our theme, "Together we stand."@outreachy.
here is the less colours and on the left corner of a page.
#Hope cohort Logo

Here is my Logo submission for the OLS Fifth Cohort.
Below are the analysis for a better interpretation and understanding;
Starting from the "HANDS" they stand as the symbol of "HOPE" for life and people in general
Secondly, the "TREE" is literally referred to as the "Tree of Life" which represent Life itself
Lastly, the "PEOPLE" inside of the Tree represent a "COMMUNITY OF PEOPLE" with Love.
in GENERAL, the hands gives hope to Life and the people as a whole.
To link the OLS Fifth Cohort Logo as a subordinate of the main OLS I came up with the ideology to also represent the main OLS.
The Open Hands stands for;
O = Which means "Open" in the OLS
The Tree of Life stands for;
L = which means "Life" in the OLS
While the People stands for;
S = which in my own innovation can also mean society
@yochannah I would love to see your feedback on this ma'am and from every of my peers here, your feedbacks will go a long way.

@yochannah
Here are the vector samples of my sketches. I also reduced the sizes so you can view the logos in smaller sizes.

Hello @yochannah this is my submitting for the Hope cohort logo.my thought process is that I used hands here to depict the word hope and the hope of achieving greatness in a community when it's members come together to help learn and grow together in the bid to achieve an end goal.the leaves at the center stands  for life and science which is what OLS is about.

@yochannah I made the vector to the sketch as you instructed.

I need help anyone with communication link please for this project.

@niyolynate communication link??
I don’t think I got that but try sketching your design and put it here for comments and all.

@niyolynate reach out to the community via Slack =)

@yochannah These are my sketches for the hope cohort logo

@yochannah please help check out the vector sketch

@yochannah I would love to participate on this task please

@yochannah I would love to participate on this task please

Let’s understand the concept, Hope.
Hope is a feeling of expectation and desire for a particular thing to happen.
In other for us to create a logo to depict the image of hope, we need to consider three major things related to hope,

Colour
Font-style
Image (if any) that signifies strength

A little explanation on How I went about the process…
I made a little research on colour theory, to understand what each colour represent and which colours would be suitable here in this logo. I made use of Yellow and Green, which of course depict hope, because they signify  sunshine, happiness, new beginning and Generousity.
In terms of font, I had to make use of a bold and bright font for strength
Also, the images there are dove and sunlight, dove which represent love, peace of mind, and the other (sunlight) represent brightness and happiness.
Below images contain the processes on how I went in creating the logo for hope

Final logo design (In SVG Format)

Beautiful people - this issue will be closed because of our rebranding exercise.
Thank you for bringing so much positive energy and creativity to the contribution phase! ❤
We hope for the privilege to collaborate more in the future. Best wishes! 🌟


Debug trait better, but still not working correctly

Sorry, didn't see a way to re-open Issue #31.
The issue is about LStr being ?Sized which is an incompatible Trait bound for the current fmt() / fmt_handle() implementation.
Generally I would expect the Debug derivation to "just" work for crate internal types.
For
#[derive(Debug)]
pub struct A {
var1: OwnedUHandle<i32>,
var2: OwnedUHandle<LStr>, // LStrOwned
...
}

I have a lint / cargo check on var2... the lint says (var1 - Sized seems to be ok):
the size for values of type `[u8]` cannot be known at compilation time
within `LStr`, the trait `Sized` is not implemented for `[u8]`, which is required by `OwnedUHandle<LStr>: std::fmt::Debug`
the trait `std::fmt::Debug` is implemented for `OwnedUHandle<T>`
required for `OwnedUHandle<LStr>` to implement `std::fmt::Debug`
required for the cast from `&OwnedUHandle<LStr>` to `&dyn std::fmt::Debug`rustcClick for full compiler diagnostic
lib.rs(93, 10): Error originated from macro call here
string.rs(49, 16): required because it appears within the type `LStr`

Removing derive and implementing
impl std::fmt::Debug for A {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        write!(f, "ok")
    }
}

works as a workaround for my case.

This should be fixed now.


Uncontrolled requests bug

Description
Currently somethings off with our website,that's why it's down.... too many requests are being made automatically causing the daily limit to exceed in matter of minutes. I saw around 50k requests in some minutes till the limit exceeded.
Earlier build shouldn't have caused this error as our app was working fine till morning today, perhaps.
More info: due to an error in pr #635 (that was only visible in production build) , the application was unable to build and hence we didn't have any new production deployments for 20 hours.  I pushed the fix in latest commit, but this shouldn't be the reason.
Problem could be from a merge commit from commits earlier than pr 635, or one of the testers of our applications got this error.
if it's the former, it should be fairly easy to solve as we have to look at previous commits only. If it's latter, it'd be really difficult.
Another clue. I was testing the pr #657 and there I noticed , favourites page seems to be misbehaving, it was repeatedly showing post not found snackbar. So I believed it  could be related to promises in there. I tried different fixes on that method, but the requests were not stopping, I even commented that useeffect but in vain :/ . I tested in test db with credentials only 1 contributor knew so chances are extremely low that his commit would've caused this.
I'll be trying another approach, basically to monitor the network tabs and try to find a solution.
Anyone can also try fixing the errors
Steps to reproduce
you can generate your own credentials and test as well yourself
Screenshots
No response
Desktop (please complete the following information)
No response
Smartphone (please complete the following information)
No response
Additional information
No response

@narayan954 I would like to help.

@narayan954 I would like to help.

Thank you! I'm going to walk through the commits earlier than 635, I hope this works out

@narayan954 I would like to help.

Thank you! I'm going to walk through the commits earlier than 635, I hope this works out

ok


python 2 support

Is Python 2 still supported or was it dropped at some point?
In python 2 there is an import error:
  File "__init__.py", line 1, in <module>
    from vanilla.vanillaBase import VanillaBaseObject, VanillaBaseControl, VanillaError
  File "vanillaBase.py", line 4, in <module>
    from AppKit import NSFont, NSRegularControlSize, NSSmallControlSize, NSMiniControlSize, \
ImportError: cannot import name NSLayoutAttributeLastBaseline

It may rather be an accidental dependency on a newer PyObjC.
That said, although we haven't talked about vanilla and Python 2 explicitly, I don't expect Python 2 support for much longer.

I’ll try to fix this then.
And can you make a ‘python2’ branch just before you decide to drop support for it?

@schriftgestalt Of course, we've been tagging things and can make branches. #101 is there to discuss dropping support for Py2 in vanilla, that has not been done, as @justvanrossum said above.

I just saw that other issue. Thanks. Just send a pull request.

@schriftgestalt I just realized that the Install Modules button in Glyphs 2 installs the Py3 only version of vanilla (which has landed to master), and now it seems broken. Maybe you want to pin the version to the commit 092b748. Just in case.

I have fixed that for the cutting edge version already.


Fixed import build issue

Hi @uzysjung thanks for merging. I think it's best that you create a new release so people can use your pod directly without having to resolve to using the git url.

HI @timominous I created new release (0.9.8) on cocoapod thanks.


Syntax highlighting incorrect for C code within Markdown file

Issue Type: Bug
There seems to be an issue with correctly highlighting a C code block in Markdown files.
For example, if you have a markdown file like shown below, only the first #define is rendered correctly. The second #define is just rendered as if it were text and not code.

Example Markdown
This is an example code block that fails to render correctly.
#define TRUE    (1U)
#define FALSE   (0U)

VS Code version: Code 1.43.1 (fe22a9645b44368865c0ba92e2fb881ff1afce94, 2020-03-18T07:01:20.184Z)

Duplicate of #34525


bug: ion-segment on android

Bug Report
Ionic version:
[x] 5.x
Current behavior:
only 1st ion-segment-button within ion-segment is clickable on android.. on ios it is working fine
Expected behavior:
all  should be clickable on android
Steps to reproduce:
install ionic 5 and run on android
  <ion-toolbar>
    <ion-segment value="general" (ionChange)="segmentChanged($event)">
      <ion-segment-button value="general">
        <ion-label>General</ion-label>
      </ion-segment-button>
      <ion-segment-button value="notifications">
        <ion-label>Notification</ion-label>
      </ion-segment-button>
    </ion-segment>
  </ion-toolbar>

Related code:

insert short code snippets here

Other information:

Ionic info:
Ionic:

   Ionic CLI                     : 5.4.16
   Ionic Framework               : @ionic/angular 5.0.0
   @angular-devkit/build-angular : 0.803.23
   @angular-devkit/schematics    : 8.1.3
   @angular/cli                  : 8.1.3
   @ionic/angular-toolkit        : 2.1.2

Cordova:

   Cordova CLI       : 9.0.0<EMAIL_ADDRESS>   Cordova Platforms : android 8.1.0, browser 6.0.0, ios 5.1.1
   Cordova Plugins   : cordova-plugin-ionic-keyboard 2.2.0, cordova-plugin-ionic-webview 4.1.3, (and 15 other plugins)

Utility:

   cordova-res (update available: 0.9.0) : 0.6.0
   native-run (update available: 0.3.0)  : 0.2.4

System:

   Android SDK Tools : 26.1.1 (/Users/haraldwiesinger/Library/Android/sdk)
   ios-deploy        : 1.10.0
   ios-sim           : 8.0.2
   NodeJS            : v10.15.3 (/usr/local/bin/node)
   npm               : 6.13.4
   OS                : macOS Catalina
   Xcode             : Xcode 11.3.1 Build version 11C504

Thanks for the issue. What devices are you testing this on?

i noticed it on the simulator.. i think its a nexus 5

Can you try this on a physical Android device if possible? Some of the older emulators ship with very outdated versions of the Android webview that cannot be upgraded. As a result, we recommend using physical devices when testing apps on older versions of Android (most physical devices have webviews that auto update).

yes of course.. i will try this a little bit later in the evening 👍

+1 , testado em vários dispositivos, dois de exemplos (moto G 7 play e Pixel 2)

thx for screenshot @gminhaneli.. thats same the same like on my simulator 👍

Aguardando um posicionamento, esse componente sem o clique é dificil pro usuário utilizar

Same error on Android 5.1 or 6 with Ionic 5, ion-segment do not working due a queryselector error in console on change segment-button

I try now on physical device (Android 5.1.1, Nexus 4) and  ion-segment not working too

Can someone provide repo with the code required to reproduce this issue? I am unable to reproduce this behavior, and a repo will help us address this issue faster.

Check this issue
https://github.com/ionic-team/ionic/issues/20487

@SSuarezBrooktec Are these the same issue?

On my issue in Android 5 do not work any function. I think there are 2 different issues.

For the issue you linked to, does the repo there reproduce the issue in this thread?

Its similar then you can check it anyway

Estou acompanhando aqui para ajudar também

have result?

Yes, I was able to reproduce this issue. We are investigating a fix.

@liamdebeasi quando subirá essa atualização?

Can you try the following dev build and let me know if it resolves the issue?
Angular
npm i<EMAIL_ADDRESS>React
npm i<EMAIL_ADDRESS>

ok will check now

@liamdebeasi o ERRO ainda persiste.

Not working on Android 5.1

Can everyone provide a full code reproduction of the issue happening? I checked the reproduction in https://github.com/ionic-team/ionic/issues/20487 and the fix works fine.

I tried with my repo and compile for Android 5.1 but is not working

@liamdebeasi  consegui replicar o problema, é o uso do bloqueio do touch no ngOnInit ou ionViewDidEnter
document.addEventListener("touchstart", () => { this.slides.lockSwipes(true); }, false);
document.addEventListener("touchend", () => { this.slides.lockSwipes(true); }, false);
document.addEventListener("touchcancel", () => { this.slides.lockSwipes(true); }, false);
document.addEventListener("touchleave", () => { this.slides.lockSwipes(true); }, false);
document.addEventListener("touchmove", () => { this.slides.lockSwipes(true); }, false);

@SSuarezBrooktec Can you test this on a physical device? We do not recommend testing on emulators are they ship with very outdated, non upgradable versions of the webview.
I am testing your app with my dev build on Android 5.1, and I am seeing your app work properly now.

@liamdebeasi I've encountered this issue as well and it only happened on one page for us where the structure is
<ion-header />
<ion-segment />
<ion-content /> <!-- this is switched out based on the value of the segment -->

In other pages where the segment was inside the ion-content it was working. I was able to reproduce it with an ionic-pwa stencil starter a couple days ago. I'll try to give you a reproduction. It was happening when switching to the device simulator in Chrome devtools, but only in md mode. In ios mode the segments were working as expected.

@liamdebeasi here you go: https://codepen.io/simonhaenisch/full/poJEEgv
Open this in Chrome dev tools, toggle the device toolbar, then switch to an Android simulator, e. g. Galaxy S5. Clicking the second tab will trigger the ripple effect on the first one but it won't switch to the second tab.
If you open it normally (without a device simulator), you will see that the ripple effect is applied to the wrong segment-button (always the one that was active prior to the click).

Hi Liam
as promised, I've update my repo to represent this bug
git clone https://github.com/yarivgdidi/ion-segments-20381
npm i
tab 1 has the issue with android, tabs 2 and 3 don't
the difference are:
tab 1, ion-segment is not surrounded by ion-toolbar  (not working in android)
tab 2, ion-segment surrounded  by ion-toolbar (working)
tab 3, ion-segment not not surrounded by ion-toolbar  and ion-header is not present (working)
Thanks
Yariv

@liamdebeasi Here's a link to a repo you can use to reproduce the problem
https://github.com/aspoonemore/ionic-v5-android-segment
Thanks,
Dale Spoonemore

@aspoonemore, @liamdebeasi, @s3ppo
Just verified on Dales repo, surrounding ion-segments with ion-toolbar solve this
<ion-toolbar>   <ion-segment (ionChange)="segmentChanged($event)" value="test1">     <ion-segment-button value="test1">       <ion-label>Test1</ion-label>     </ion-segment-button>     <ion-segment-button value="test2">       <ion-label>Test2</ion-label>     </ion-segment-button>   </ion-segment> </ion-toolbar>
Yariv

Errors on console in my project

Thanks for all the follow ups. I have made a few changes and created a new dev build. I have verified in all of the reproductions that this dev build fixes the issue.
Here is the dev build if people would like to test in their other apps:
Angular
npm i<EMAIL_ADDRESS>React
npm i<EMAIL_ADDRESS>

@liamdebeasi i tested it with the devbuild.. works like charm :)
thank you very much

is it already included in yesterdays release of 5.0.1 or do we have to wait for 5.1.0?

It is not in the 5.0.1 release, but will be in an upcoming patch release.

Works for me too. Great job, Ionic team!
Dale

For me in physichal mobile: Huawei P3 Lite Android 5.0.1 is not working. Because webview is v39 (if install the last webview version, didn't work). If you want you can check my repo here
https://github.com/SSuarezBrooktec/Ionic5_ion_segment_error
Error is this:

Segment & tabs not working (both)

I tried out the dev build and I still experience the same issue as detailed in https://github.com/ionic-team/ionic/issues/20466#issuecomment-588478532.
I attempted one fix which seems to work at least for this case, on this line... https://github.com/ionic-team/ionic/blob/master/core/src/components/segment/segment.tsx#L305
What happens is when it tries to find nextEl on the next line it gets the ion-header element instead. Instead of using the top point of the previously selected button we use the vertical center of the element like this:
const previousY = rect.y + (rect.height / 2);

I confirm the fix work, great job @liamdebeasi and team
@bodinaren is your segment surrounded with <ion-toolbar>, e.g.
<ion-toolbar>     <ion-segment (ionChange)="segmentChanged($event)" >         <ion-segment-button >           <ion-label>             one           </ion-label>         </ion-segment-button>         <ion-segment-button >           <ion-label>             two           </ion-label>         </ion-segment-button>     </ion-segment> </ion-toolbar>
for me it solved the issue even before the fix
I've noticed it because some of my segments worked while other didn't

@yarivgdidi No, they weren't, it does fix it though so thanks for that.

I don't think it's supposed to be a requirement, is it?

I tried out the dev build and I still experience the same issue as detailed in #20466 (comment).
I attempted one fix which seems to work at least for this case, on this line... https://github.com/ionic-team/ionic/blob/master/core/src/components/segment/segment.tsx#L305
What happens is when it tries to find nextEl on the next line it gets the ion-header element instead. Instead of using the top point of the previously selected button we use the vertical center of the element like this:
const previousY = rect.y + (rect.height / 2);

@bodinaren The code you suggested is what we already do in the dev build (https://github.com/ionic-team/ionic/pull/20554/files#diff-eb82c3be26eed17c0d922817c1dcb05dR308). Are you trying the latest dev build 5.1.0-dev.202002201606.ac98652?

I don't think it's supposed to be a requirement, is it?

Using ion-segment inside of ion-toolbar is not a requirement.

Thanks for the issue! As per https://github.com/ionic-team/ionic/issues/20466#issuecomment-589173907 it sounds like this issue has been fixed by the dev build. As a result I have merged my changes in and will be closing out this issue. If you are still experiencing issues, please ensure that you are running dev build 5.1.0-dev.202002201606.ac98652. For any additional bugs, please open a new issue. Thanks!

I must have indeed done something wrong when I tested it because with dev build 5.1.0-dev.202002201606.ac98652 it does indeed work. Thanks!


Remove unused variable

Remove unused variable creating confusion: GeometryDrawing myGeometryDrawing = new GeometryDrawing();
Title
Remove unused variable in code sample
Summary
Remove unused variable in code sample creating confusion.
Fixes #Issue_Number

Note: The "Fixes #nnn" syntax in the PR description causes
GitHub to automatically close the issue when this PR is merged.
Remove that line if you don't have issues associated with this
PR. Click on the Guidelines for Contributing link above for details.

Details
GeometryDrawing myGeometryDrawing = new GeometryDrawing(); Variable never used.
Suggested Reviewers
If you know who should review this, use '@' to request a review.

Hi Ron,
Pull Request 4446 done to adapt the VB snippet.

Thanks, @VHellin, for also modifying the Visual Basic example. We'll merge your PR now. Your changes should appear live on docs.microsoft.com in the next day or two.