Split and Send Conveniences.

From what I understand vaguely by looking at the code, you're expecting the user to handle constructing their split messages when they receive them. It'd be convenient if Chomp did that already: buffered incoming messages and only did the user callback when they have a complete packet.
One thing to also watch out with this is message ordering (forgive me if I missed something in the code, but I see no accommodation for it).
For example,
BNSendGameData( account, "1" )
BNSendGameData( account, "2" )

could easily appear on another's client with the "2" first, corrupting your data if you don't account for that quirk.
One way to handle it is to insert in the message prefix a serial number, a split index, and the total number of messages, so you know where to put things when buffering. It gets messy quick, and I have no idea why Blizzard can't guarantee message ordering already; it's like dealing with data without the TCP protocol.

I have no idea why Blizzard can't guarantee message ordering already
I haven't actually seen out-of-order messages received, but I'll admit I have not been testing BattleNet messages intensely since around when they were introduced. Have you actually seen this occurring lately, or was this a theoretical concern?

I know the in-game messages are a guaranteed order (...or at least they have been so far, I haven't extensively tested it in BfA...), but if the BattleNet ones aren't... Whoof, I'll definitely get on that issue.

It'd be convenient if Chomp did that already: buffered incoming messages and only did the user callback when they have a complete packet.
I'll add a per-prefix toggle for reassembly vs on-the-fly delivery in the near future.

The design as it is currently was largely based around the needs of RP profile addons, which can sometimes have an incredibly loooooong incoming queue, and getting to load bits of that data before the final message is received can be incredibly valuable. But I see the use of having Chomp assemble messages, too, in cases where the message is only valuable if the entire thing is present.

The way I see it, the RP profile addons still buffer everything first, but (at least with TRP) they split it into different parts that are sent, so you receive some parts before the others. Having that in the Chomp layer would be really convenient, just like when you're using AceComm.
As for the out of order issue, it's definitely a problem in-game with both BNet whispers and BNet data. You can see it easily by doing two calls to BNSendGameData and then listening for the events. Another addon that has this problem is RP Connect, which sends your raid posts through a relay using BNet whispers, and often the messages for multipara emotes are out of order.

Here's a test case for the out of order issue:
local received_index = nil

local frame = CreateFrame( "Frame" )
frame:RegisterEvent( "BN_CHAT_MSG_ADDON" )
frame:SetScript( "OnEvent", function( self, event, prefix, message, _, senderGameID )
	if prefix == "ORDERTEST" then
		message = tonumber(message)
		print( "got " .. message .. "!" )
		if message == 1 then
			received_index = message
		elseif received_index and message == received_index + 1 then
			received_index = message
		else
			print( "out of order error!" )
			received_index = math.max( received_index, message )
		end
	end
end)

function SlashCmdList.ORDERTEST(msg)
	local bnetGameID = select( 16, BNGetGameAccountInfoByGUID( UnitGUID("player") ))

	print( "Sending messages . . ." )
	for i = 1, 100 do
		BNSendGameData( bnetGameID, "ORDERTEST", tostring(i) )
	end
end
SLASH_ORDERTEST1 = "/ordertest"

Honestly I think this should really be fixed by the devs, but :man_shrugging:.

Damn, that's awful. I'm pretty convinced it did not used to be that way, but maybe I was just obscenely lucky.
I'll look at adding a sequence marker of some sort for BattleNet messages in Chomp. I'm probably going to use a message marker, a 24-bit integer (session sequence), and two 12-bit integers (message sequence/message total), base64-encoded. That gives 16 million session sequences (which will wrap if it hits maximum, starting from a randomly-generated value -- this is to have some safety in case of unexpected UI reloads or relogs), and a maximum message sequence length of 4096 messages. I think those values give enough uniqueness and overhead.
So a message would look something like CHMPABCXAAABAAAC[...] with that scheme, prior to being processed by Chomp. Addons would see none of that, they'd just find their maximum message sizes reduced to 4066 bytes from 4078. Any concerns with this technique?

My input on those points:
Don't really need a random startup value. Reloads/relogs should take enough time for the queue to empty, or at least whatever messages on the line to be received before you send more.
Avoid base64 - that's just an extra library when you can just encode it in plain text for Lua to have an easy time with it (example: "23/1/3" for sequence/page/#pages).
As for addon prefixes, I saw that Chomp supports different prefixes for different parts of the message, I'd recommend not encouraging that practice, so it's easy to see what messages are from what addon or system.

Good points. I'll use hex digits, but I'm sticking to a guaranteed-size prefix. It'll be 12 hex digits, indicating the session sequence, message number, and total messages. I'm keeping the random startup value and modulo handling for now (it's easy to change later), but I'll think more about whether the consequences of not doing so are actually valid.
Use of multiple prefixes is definitely not encouraged. It's only supported because I have to deal with a legacy protocol from the TBC-era that did so and is implemented across multiple addons. I'll make that clearer in the documentation, and maybe un-document how to actually use multiple prefixes.

I see.
And I'm fine with however you want to implement it in the end - just my opinions and it's not like it's going to affect the user-side.

I'm mainly worried about an off-by-one issue on for the total message number, if the preamble isn't a fixed size. I could probably account for that in some other way, but I think I feel most comfortable this way.
 In the current implementation I'm testing, that would not be order-guaranteed by Chomp's parsing. Or is that just the test case for the issue, and your actual messages will only be multi-part if they exceed the maximum message length?

It's a tricky question. I want to say that it's fine so long as whole packets are coming in safely - not much you can do when it comes to the protocol above not accounting for the ordering quirk. But, I can imagine that in practical use cases, ordering of smaller individual messages is important too. I can also imagine this gets hairy quickly - you'd have to keep track of a lot more serials—per client, and per message channel (each channel would guarantee ordering of its different messages). Lots of dangers and gotchas there, but it's a headache that the lib user would totally like to avoid.
For one of my use case ideas, I was thinking of building a cross-faction/realm layer for TRP3, where I'd reroute invalid addon messages (targeting opposite faction) over bnet if it can (which Chomp's "smart" function does), and then feed the data to TRP3's event handlers manually on the other side. I believe this might be part of TRP3's core soon though.

I was talking to Ellypse about all this over the past few days, and my understanding is that, yes, TRP3 will probably end up adopting Chomp and getting BattleNet as a part of the package for doing so.
I modified your test script to add a delay between messages, and it looks like a delay of ~0.125 seconds between each message is necessary to avoid the out-of-order issue (though minor latency spikes can throw that off -- I saw the very rare out of order error at 125ms, and couldn't trigger any at 130ms after several runs).
If I had to guess, that makes it seem like Blizzard's Battle.net messaging servers are processing messages 8 times per second, and have multiple processes plucking any pending messages from the queues when that happens. The modified script is below (modify the DELAY and TOTAL_MSG variables for testing).
local DELAY = 0.130
local MSG_TOTAL = 100

local received_index = nil

local frame = CreateFrame( "Frame" )
frame:RegisterEvent( "BN_CHAT_MSG_ADDON" )
frame:SetScript( "OnEvent", function( self, event, prefix, message, _, senderGameID )
	if prefix == "ORDERTEST" then
		message = tonumber(message)
		print( "got " .. message .. "!" )
		if message == 1 then
			received_index = message
		elseif received_index and message == received_index + 1 then
			received_index = message
		else
			print( "out of order error!" )
			received_index = math.max( received_index, message )
		end
	end
end)

local i = 1
local SendTest
local bnetGameID
function SendTest()
	BNSendGameData( bnetGameID, "ORDERTEST", tostring(i) )
	if i < MSG_TOTAL then
		i = i + 1
		C_Timer.After(DELAY, SendTest)
	end
end
function SlashCmdList.ORDERTEST(msg)
	bnetGameID = select( 16, BNGetGameAccountInfoByGUID( UnitGUID("player") ))

	received_index = 0
	print( "Sending messages . . ." )
	i = 1
	C_Timer.After(DELAY, SendTest)
end
SLASH_ORDERTEST1 = "/ordertest"

There isn't much I can think of to do with this knowledge at the moment, but it might be useful in the future somehow. Chomp's pool tick rate is already at 200ms, so if you're sending full-size BattleNet messages, even without the ordering compensation, it should deliver in-order almost always. The first two messages in the sequence would still be a problem, though, regardless.

"almost always" :frowning_face:
Why or how it's plucking messages out of the queue randomly on Blizzard's end is boggling; now we have to suffer.

Yeah, it will always be possible to receive out-of-order messages, regardless of how much work you do with delays and other tactics, unless you actually buffer them on your end. Speaking of, that latest commit referenced adds the fullMsgOnly mode to the Smart handling, have a look and see if it fits your needs.
The needBuffer-only mode is mostly complete, but I need to add a status return of some sort to non-fullMsgOnly needBuffer handlers to inform them of the current queue state (first message, middle message, last message).
You may note some additional complexity. Due to the necessity of logged messages being split in unique ways that may alter their byte total (not splicing quoted-printable characters, nor UTF-8 byte sequences), the msgTotal count is now sometimes updated. The msgTotal count on messages n and n-1 should always be accurate, so it shouldn't ever erroneously finish processing at message n-1. I did test this, but it's always possible with something like this that some specific set of conditions could throw it off.

I likely wouldn't be looking at internals anyway when the message magic is going on. I don't have a project to use this quite yet, but I'll let you know if I run into any troubles.

Alright. I'm going to mark this issue as closed for now, but feel free to file another issue if you run into any problems ever, of course. The remaining bits I noted I need to work on from here are now specifically covered by #6


Minor testing related fixes

Addresses #1397.

Remove warnings from doctest.
Cuda tests run in a single process. Many of our tests construct fairly big tensors which results in OOM errors otherwise, besides not being any faster.
Disable progress bar in HMC when pytest-xdist is used.
Remove deprecated pandas.DataFrame.as_matrix method.
Do not throw error if the cached path in einsum was dumped using a higher protocol.

This should be good to merge.


WFCORE-568 jboss-deployment-structure.xml parsing fails if a schema loca...

...tion is specified

Windows Build 954 is now running using a merge of 53a4e67a8d6f311ced82e2050d64832a22677b35

Core - Full Integration Build 532 is now running using a merge of 53a4e67a8d6f311ced82e2050d64832a22677b35

Linux Build 1270 is now running using a merge of 53a4e67a8d6f311ced82e2050d64832a22677b35

Windows Build 954 outcome was SUCCESS using a merge of 53a4e67a8d6f311ced82e2050d64832a22677b35
Summary: Tests passed: 3046, ignored: 68 Build time: 0:18:48

Linux Build 1270 outcome was SUCCESS using a merge of 53a4e67a8d6f311ced82e2050d64832a22677b35
Summary: Tests passed: 3046, ignored: 68 Build time: 0:19:00

Core - Full Integration Build 532 outcome was SUCCESS using a merge of 53a4e67a8d6f311ced82e2050d64832a22677b35
Summary: Tests passed: 2827, ignored: 414 Build time: 0:47:51


shift+drag map zoom not working on safari

[x] I've looked at the documentation to make sure the behavior is documented and expected
[x] I'm sure this is a Leaflet code issue, not an issue with my own code nor with the framework I'm using (Cordova, Ionic, Angular, React…)
[ ] I've searched through the issues to make sure it's not yet reported

Steps to reproduce
Steps to reproduce the behavior:

hold shift and drag over map

Expected behavior

zoom window
Current behavior

nothing happens
Environment

Leaflet version: I believe it is 1.7 (e.g. on OSM.org and on leafletjs.com frontpage map)
Browser (with version): Safari Version 13.1.2 (156<IP_ADDRESS>.3)
OS/Platform (with version): macOS 10.15.6

Additional context

Minimal example reproducing the issue
See https://leafletjs.com/
or https://osm.org/

[x] this example is as simple as possible
[ ] this example does not rely on any third party code

Possible duplicate of #7255. Please try reproducing with a fresh build from the master branch, as explained in https://github.com/Leaflet/Leaflet/issues/7255#issuecomment-689562115

It works here on Safari as expected: https://plnkr.co/edit/v4GzrCYSxpIO1aOo?preview

actually, I just noticed it behaves a bit odd, because it does not zoom to the rectangle but adds some padding to it (on all sides). Bug or Feature?

actually, I just noticed it behaves a bit odd, because it does not zoom to the rectangle but adds some padding to it (on all sides). Bug or Feature?

Feature. Changing the map's zoomSnap option to 0 should give you the desired behaviour.

With the master branch It works on Safari as expected: https://plnkr.co/edit/v4GzrCYSxpIO1aOo?preview

Closing as duplicate of #7255


v1p3beta1: new feature enum manual methods

These are manually written methods.
Fixes #126
Checks features enum (loaded from protos) to see if the desired feature exists. If it does, augment the library with the feature method.

@JustinBeckwith this one is pretty urgent. Could you TAL first thing tomorrow?


Base controller crashes when teleop started in same launch file

Some sort of race condition - not yet debugged

Wrong robot - this happens on the firebot


Update AddConstraintName Rubocop linter to account for additional Sequel methods

The linter now checks additional Sequel methods that can add indices
or constraints to make sure that we are explicitly setting a name
Added exclusion for preexisting migrations since we do not want to
edit any indices in them after they have already been ran in user
environments

[#148173629]

+1

Looks good to me @tcdowney!

@tcdowney would this PR handle cases where the unique flag is given as part of the column definition?
create_table(:some_table) do
  column :a1, :string, unique: true
end
# or
alter_table(:some_table) do
  add_column :a1, :string, unique: true
end

Yeah @ljfranklin, you're correct that this change won't handle indices that are added during the add_column call -- only ones that are added in the explicit methods.  I've moved the chore back to the Icebox in our backlog since this would be good future work on this.


Columns escape except one in the array

Hello,
I see in the changelog that you escape all columns by default after the version 7.0.0
I suggest to add something like an escapeColumnsExcept() method to escape all columns except the one in the array.
For example :
return Datatables::of(User::select())
          ->escapeColumnsExcept(['link'])
          ->editColumn('created_at', function ($user) {
            return ucwords($user->created_at->formatLocalized('%A %d %B %Y'));
        })->editColumn('roles', function ($user) {
            return $user->getRolesList();
        })->editColumn('link', function ($user) {
            return 'Edit'
        })->make(true);

In this example, all columns are escaped except the link column.
I can do a PR, but I'm not sure about the name of the method, is that clear enough ?

isn't this a duplicate of all the rawColumns issues

@redalpha01 yep that's it ! #909

Insted it can be useful to add rawColumns to the documentation : https://yajrabox.com/docs/laravel-datatables/master/xss


Update Gateway API to v0.7.0

This PR updates our Gateway API to v0.7.0. This includes the new vendor changes as well as all fixes we needed to pass the additional conformance tests in individual commits.
Fixes: https://github.com/cilium/cilium/issues/25474
Support Gateway API v0.7.0

/test

/test

Add a preview-only label as we might need to wait for https://github.com/cilium/cilium/pull/25602 to land in first.

/test

/test-1.26-net-next

/test

Rebased with master to get the fix for ci-l4lb

/test

/test-1.16-4.19


Does this project have a discord?

Title :)

Thank you for your interest! Not at the moment, but we plan to set one up once the project is close to the beta testing stage. :)

Thank you for your interest! Not at the moment, but we plan to set one up once the project is close to the beta testing stage. :)

Wait :)))
Good Luck!


Correct spelling typo in CSVAnormalOver30Min alert desc

This PR just corrects a very minor typo in the description of the CSVAbnormalOver30Min alert, which shows up noticably in the console when firing.

/ok-to-test

@mrbarge could you please resolve the DCO issue? you need to sign the commit. You can probably get away with git commit --sign --amend then git push -f


template-coq plugin interacts badly with asynchronous proofs

Trying to use asynchronous proofs in coqide or coqc -schedule-vio2vo when Template.Loader has been loaded cause an anomaly:
$ cat bug.v
From Template Require Import Loader.

Lemma test: 0 = 0.
Proof.
  trivial.
Qed.
$ coqc -quick bug.v
$ coqc -schedule-vio2vo 1 bug
Warning: File ./bug.v: proof of test: chars 66-74
Anomaly "cannot find String in module Coq.Strings.String."
Please report at http://coq.inria.fr/bugs/.

On the other hand, if we include everything but the template-coq ML module, things work:
$ cat bug.v
From Template Require Import Ast TemplateMonad.

Lemma test: 0 = 0.
Proof.
  trivial.
Qed.
$ coqc -quick bug.v
$ coqc -schedule-vio2vo 1 bug

I am not sure if this should be reported here or on the Coq issue tracker; I reported here because it's specific to the template-coq plugin.
Versions:

coq 8.9.0 (from OPAM, OCaml 4.06.0)
metacoq - branch coq-8.9, commit 6f306ae09e28ad70df806e7c15d433693ea7fae1.

Interesting, we're probably missing to import the necessary modules for the ML side of the plugin inside Loader.v


Line relating placed and filled orders on trading simulation layer

The line joining triangles signalling the relationship between placed and filled orders may prevent users from seeing the upper tail of the candle (candle.max).

Maybe a dotted line instead of a solid line would be better.

Done, you will see it at the next release


Add gracefull shutdown feature do deployers

Enables us to test gracefull shutdown scenarios in functional tests.
Send Q to IIS Express and Ctrl+C to other servers.
Possibly throw if the server doesn't stop after a timeout.
Required for https://github.com/aspnet/IISIntegration/issues/672

@muratg consider for MQ work


support for couponcode / promotion codes?

I'm digging through but it doesn't appear sharpy pulls back the subscription[couponCode], or POST it either.  Is this due to api issues or something that was simply left out?

I think coupon codes are newer than the last update on sharpy.
+1 on this issue though. I'm having the same issue.


Write Unit Tests for add_or_update_normal_file method

Description: Write unit tests for the add_or_update_normal_file function. Test cases should include:

Adding a new file to an empty normalStore.
Updating an existing file's metadata when a duplicate file (same hash) is found.
Ensuring the file is correctly inserted in the metadata list without duplication.

Resources: Follow the pytest getting started guide for writing tests.
Path: twinTrim/dataStructures/fileMetadata.py
Note: Ensure to maintain the file structure as per the existing files and tests, and add these tests.

hii @Kota-Karthik , please can you assign me this.

@Varun-malviya5 Yes,
make sure to create a separate branch before making the necessary changes and retain the folder structure.

Hey you mind if I work on this? Can get it done by tomorrow.

hey @Kota-Karthik, can you please assign it to me??

@STSonyThomas @kushwxha
We follow a FCFS policy here
you can check out our other open issues or you can create new issues and get them assigned
@Varun-malviya5 is currently working on this

@Varun-malviya5 are you working on this?

@Varun-malviya5 I am unassigning you and assigning this issue to @STSonyThomas
@STSonyThomas
make sure to create a separate branch before making the necessary changes and retain the folder structure.


Did some changes in bom

Ready to submit your project? Nice job! Hopefully you've read the submission guidelines. If not, make sure to read them first.
If you're unsure about the format, make sure to check out the Orpheuspad example and follow the format there.
If this PR isn't a submission, that's okay too! If there's anything about this PR template that seems confusing, let me know in #hackpad on the slack!

my initial pr is #85
@M0HID


fix: possible bug due to using unspecified behavior of std::move

Issue being fixed or feature implemented
All standard library objects that have been moved from are placed in a "valid but unspecified state", meaning the object's class invariants hold (so functions without preconditions, such as the assignment operator, can be safely used on the object after it was moved from). See example:
std::vector<int> v = {2, 3, 3};
std::vector<int> u = std::move(v); // the value of v is unspecified
v.clear(); // we are good now

Instead, let's have swap better!
WITH_LOCK(cs_pendingSigns, v.swap(pendingSigns));

What was done?
Fixed CSigSharesManager::SignPendingSigShares, CSigningManager::ProcessPendingReconstructedRecoveredSigs and refactored CMasternodeMetaMan::GetAndClearDirtyGovernanceObjectHashes for unification.
How Has This Been Tested?
Run unit and functional tests.
Breaking Changes
N/A
Checklist:

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation
[x] I have assigned this pull request to a milestone

@knst knst removed the backport-candidate-22.0.x label Nov 27, 2024

it may conflict with 22.0.x, but not really critical fix. removed label


Custom Search Tab Returning KML Not Expanding in Search Results

Custom search tabs created to return KML results is not working in GEE 5.2.x
Steps to Recreate:

Create custom search tab that points to a web endpoint returning KML
Add custom search tab to Globe and publish.
Perform a basic search to return the KML results
Try to expand results. Results should show a KML tree structure sorting results by type.

Issue was specific to user generated KML:

The important difference between the KML and the Rome search KML standard with GEE is a "1" parameter.  If added to each of the "" sections in the KML

The "+"/"-" icons to expand and collapse the hierarchical layout don't work with either KML, nor in either version of GEEC (7.1.8 & 7.3.0).


Commands not running in MacOS

Hello.
I am trying to deploy the solution to test it in the my laptop, a MACbookPro, but looks like after following all the steps I can not start the containers due in the deploy scrip there are commands which don't run on mac.
"failed to solve: executor failed running [/bin/sh -c pip install --upgrade pip   && pip install --upgrade pipenv   && apt-get update   && apt install -y build-essential   && apt install -y libmariadb3 libmariadb-dev   && pip install --upgrade -r /app/requirements.txt]: exit code: 1"
I guess I am close, most of the containers are completed:
docker images | grep pyrrha
pyrrha-rulesdecision          latest    76e4f428edee   About an hour ago   333MB
pyrrha-dashboard              latest    21d85a10f0a3   2 hours ago         1.24GB
pyrrha-mqttclient             latest    152c2fbc940f   2 hours ago         128MB
pyrrha-api-auth               latest    1789bd869f1b   2 hours ago         781MB
pyrrha-simulator              latest    1451b01156f2   2 hours ago         121MB
pyrrha-wss                    latest    0d0e3f5ca50a   2 hours ago         108MB
pyrrha-mariadb                latest    8057693aceba   4 hours ago         389MB

I guess the solution should be around modifying this commands, like apt-get for brew, removing the -y, etc.
In fact I have tried to run it manually removing all these "non mac" commands, and with success. But when I run again the scrip for deploy fails.
Any options about updating these lines?
Thank you for the support.

Can you provide some details about which instructions you're using?
When running containers, those commands run inside the container, not on the host macOS system. The container base images are based on Debian or Ubuntu, so apt-get is the correct way to do this.
Also, can you provide the kind of Macbook Pro (whether it's Intel or Apple Silicon) and what version of macOS.

Hello @hawk4031 .
Thank you for the quick answer. You are totally right. I guess I was tired and after reading the output "failed to solve: executor failed running [/bin/sh -c pip install --upgrade pip   && pip install --upgrade pipenv   && apt-get update   && apt install -y build-essential   && apt install -y libmariadb3 libmariadb-dev   && pip install --upgrade -r /app/requirements.txt]: exit code: 1" I was trying to fix it manually. But these commands are running inside the container so...
I was just following the instructions to deploy Pyrrha on my local machina from here:
https://github.com/Pyrrha-Platform/Pyrrha-Deployment-Configurations/blob/main/DOCKER_COMPOSE.md#pyrrha-mqttclient
I have done all the steps one by one and the outcome I have shared comes from running the command "docker-compose build".
The error appears here:
=> [pyrrha-api-main 1/5] FROM docker.io/library/python:3.7.7-slim@sha256:5b25848c082804c500e8cadce6d1b344791aa39d82cb9d56285c65e3e937f0c2                                     0.0s
=> CACHED [pyrrha-api-main 2/5] WORKDIR /app                                                                                0.0s
=> CACHED [pyrrha-api-main 3/5] COPY requirements.txt /app                                                                                0.0s
=> ERROR [pyrrha-api-main 4/5] RUN pip install --upgrade pip   && pip install --upgrade pipenv   && apt-get update   && apt install -y build-essential   && apt install -y  173.6s
=> [pyrrha-mariadb internal] load build context                                                                                0.0s
=> => transferring context: 72B
I am trying to deploy it in my Macbook Pro with an i7 Intel Processor and the Big Sur 11.6.8 version running.

Hello @hawk4031 .
Thank you for the quick answer. You are totally right. I guess I was tired and after reading the output "failed to solve: executor failed running [/bin/sh -c pip install --upgrade pip   && pip install --upgrade pipenv   && apt-get update   && apt install -y build-essential   && apt install -y libmariadb3 libmariadb-dev   && pip install --upgrade -r /app/requirements.txt]: exit code: 1" I was trying to fix it manually. But these commands are running inside the container so...
I was just following the instructions to deploy Pyrrha on my local machina from here:
https://github.com/Pyrrha-Platform/Pyrrha-Deployment-Configurations/blob/main/DOCKER_COMPOSE.md#pyrrha-mqttclient
I have done all the steps one by one and the outcome I have shared comes from running the command "docker-compose build".
The error appears here:
=> [pyrrha-api-main 1/5] FROM docker.io/library/python:3.7.7-slim@sha256:5b25848c082804c500e8cadce6d1b344791aa39d82cb9d56285c65e3e937f0c2                                     0.0s
=> CACHED [pyrrha-api-main 2/5] WORKDIR /app                                                                                0.0s
=> CACHED [pyrrha-api-main 3/5] COPY requirements.txt /app                                                                                0.0s
=> ERROR [pyrrha-api-main 4/5] RUN pip install --upgrade pip   && pip install --upgrade pipenv   && apt-get update   && apt install -y build-essential   && apt install -y  173.6s
=> [pyrrha-mariadb internal] load build context                                                                                0.0s
=> => transferring context: 72B
I am trying to deploy it in my Macbook Pro with an i7 Intel Processor and the Big Sur 11.6.8 version running.

Hello @hawk4031.
Any ideas around this? I have reviewed all the steps and nothing changes.
Thank you

I'll have a look and get back to you @Filosss

The problem appears to be with the MariaDB package that pip is installing in that container (api-main specifically). Since it's not locked to a version in requirements.txt, it's trying to install the latest version, which is 1.1.4. This requires a certain version of MariaDB Connector/C, which the base container image (based on Debian Buster) doesn't have (it has an older version). The same is true for a newer version of this base container image, which is based on Debian Bullseye. The MariaDB Connector/C version that is installed with mariadb==1.1.4 is 3.2.4, but Buster and Bullseye only have 3.1.x.
One thing you can do for now is to set a specific version of the mariadb package in requirements.txt to a compatible version. The newest version of that package that I could get installed in the container is mariadb==1.0.11.
This also means we should make that change and put in a PR to lock it in.


[FlatButton] Add fullWidth property

[x] PR has tests / docs demo, and is linted.
[x] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@oliviertassinari Can you please help me with getting these checks passed to get my first pull request merged?

@Shahrukh-Zindani Thanks. First PR 👏

@oliviertassinari Thanks. I was just wondering why don't I see my name in the list of contributors after you merged the branch?

They are sorted by number of contributions DESC. We have 500 contributors. You gonna need to contribute more to see your name 😛

Okay. Got it. I was just making sure as I don't even see my name at the bottom. So was wondering if I am following the process correctly.


[BUG] - Lookup lists that are not valid Python variable names break the labeling function calculation

Describe the bug
Lookup lists that are not valid variable names break the labeling function calculation even when they are not used. When I removed the list called "123" (see screenshot), the calculation worked again.
To Reproduce
Steps to reproduce the behavior:

Create a lookup list called "123"
Import some list (dsnt have to be the 123 one) from knowledge in a LF
Run it
See error

Expected behavior
Either I shouldnt be able to create such list names or the execution environment should preface the list name with something viable like "list_"
Screenshots

Desktop (please complete the following information):

OS: win10
Browser chrome
Version 1.7.1

Additional context

possible solution could be to enhance the toPythonFunctionName function and match the logic to the backend version. Also important to note is that there is a second function currently in use which works slightly different and should be replaced asPythonVariable

So no special characters (replace with '' - already included)
_ case (whitespace changed to _ -> already included)
lowercase (should be included but isn't part of the function atm)
no starting numbers (prefixed with e.g. _ or list_)


Update cla.yml

use bot token for cla action

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[X] N
[ ] Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[X] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.
None

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 46.461%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2422

Relevant Lines:
5213

💛  - Coveralls


Interface 'Block bogon networks' Blocking Legitimate ipv6 ICMP Traffic

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[X] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[X] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
I recently enabled ipv6 support and noticed some weird firewall traffic logs. A lot of traffic from my ISPs default gateway link local address was being blocked by the WAN block bogons rule. I reviewed the logs and realized the traffic is being blocked because it appears to be using the ICMPv4 protocol number even though the network is IPv6 (it shows as 'icmp' instead of 'ipv6-icmp').
At first I assumed it was an ISP configuration issue (sending the wrong protocol number). However, when I turn off bogon blocking the traffic disappears. My assumption was after passing the initial bogus packets the ISP router started using the correct protocol. However, there are no entries showing that traffic was ever passed (or even dropped after disabling Bogon blocking) for the bad protocol number, the traffic simply disappears.
Image bottom is with bogon blocking on and top is after disabling it. Since the traffic disappears as opposed to getting passed and then the gateway behaving differently, this makes me wonder if it might be an opnsense bug.
https://ibb.co/txqS6cw
Additionally, disabling block bogons on the WAN interface and then manually recreating the block bogon rules at the top of my fireawall rule list using the built in bogon aliases (both a v4 and v6 rule) also makes all of the "icmp" (wrong protocol number) traffic disappear too and all of the traffic in the logs shows as ipv6-icmp and is passed.
I did not use ipv6 on opnsense in a prior version.
To Reproduce
Enable WAN block bogons and watch the firewall logs. Unsurue if this might be ISP/gateway hardware specific though.
Expected behavior
ICMPv6 traffic should show up with the correct protocol name and be passed.
Describe alternatives you considered
Manually creating block bogons rules in the Firewall makes the issue go away.
Screenshots
Image bottom is with bogon blocking on and top is after disabling it. Since the traffic disappears as opposed to getting passed and then the gateway behaving differently, this makes me wonder if it might be an opnsense bug.
https://ibb.co/txqS6cw

Relevant log files
Additional context
Environment
Running virtualized on xcp-ng.
Versions	OPNsense 23.7.11-amd64
FreeBSD 13.2-RELEASE-p7
OpenSSL 1.1.1w
CPU type	Intel(R) Xeon(R) CPU E3-1231 v3 @ 3.40GHz (6 cores, 6 threads)

What sort of IPv6-based traffic is passed over the old ICMP protocol with IPv6 addressing? That the bogons catch this traffic is not unusual because they catch all traffic not required (which also depends on your IPv6 connectivity type).
Cheers,
Franco

Without capturing the traffic we don't really know what's going on. pflog artefacts have made the rounds before, but not for traffic suddenly disappearing and capturing that traffic pattern (ipv6 with icmp proto) should be relatively quick with the packet capture GUI. The bigger question, however, is whether the icmp traffic being processed by some automated rule actually reaches the host or of it drops it as invalid anyway.
Cheers,
Franco

Not a single ICMP (wrong version) packet is appearing in the packet capture with the block bogon rule on or off.

Ok next step is using tcpdump on the pflog0 interface (from the command line). This is what filterlog/live log does.

Isn’t fe80::/10 just part of the bogon list?

No ICMP traffic seen when using tcpdump -i pflog0 icmp -v
@AdSchellevis - It is not in https://pkg.opnsense.org/bogons/fullbogons-ipv6.txt  Even if it was, the autogenerated "IPv6 RFC4890 requirements (ICMP)" rules appear before the autogenerated block bogons rule.

Well, I would double check (you can use the alias diagnostics for that as well, to find which alias matches an address). It’s highly unlikely the block is not on the list and matching…
The RFC4890 rule is very strict and could easily be unmatched with your test case.
https://github.com/opnsense/core/blob/5b5cf45846c679b6c90d4447b4493bf63c5d68cf/src/etc/inc/filter.lib.inc#L227-L233

Ah yes, it would be included in the last network, 8000::/1.
The behavior/mislabeling is still bizarre and unexplainable though.


When constructing a TransformedTargetModel, allow the user to override the target_scitype, predict_scitype, and prediction_type traits

For example, this will allow the user to take a Deterministic regression model and transform it into a Probabilistic binary classification model.
TODO before merging:

[ ] Remove the evotrees.jl tests.
[ ] Add some simpler tests.

@ablaom @OkonSamuel This is now ready to review.
Instead of specifying the abstract type, the user instead specifies some traits, and we infer the appropriate abstract type based on those traits. Specifically, the user can provide the following three traits:

target_scitype
predict_scitype
prediction_type

Right now, I'm testing this PR by using an example drawn from EvoTrees.jl, which was the original motivation for this PR. I'm fine with keeping that test, but I realize that EvoTrees.jl is a heavy dependency, so I would also be fine with removing the EvoTrees-based tests and instead putting in some more lightweight tests.
Also, right now, I have MLJ.jl as a test dependency; obviously we want to get rid of that.

https://github.com/JuliaAI/MLJBase.jl/pull/748

Closing in favor of https://github.com/JuliaAI/MLJBase.jl/pull/748 and https://github.com/JuliaAI/MLJBase.jl/issues/760


Changed the Pan gesture recognizer to a LongPress gesture recognizer.…

… This will now allow tracking if the user is just pressing down on the screen without moving their finger. The tracking will still work if they pan. You could also adjust the minimumPressduration as needed.
Thank you so much for library! I am currently using it to develop my first app. This was just a slight modification I had to make for my app but I think others will find it useful. Also this is my first pull request!

Clever, thanks!
Another approach would be like in the single tracker example, where it will track when you start the touch on the line and pan otherwise.
Multitracker example needs also to be adjusted to work well with zooming, but that's another issue.


Add Death Note Dubstep X I Love Bread by ShadowBeatzInc

Song Name
Death Note Dubstep X I Love Bread
Artist Name
ShadowBeatzInc
Source
Youtube
Youtube Link
https://www.youtube.com/watch?v=RKtpF9TxEz0
Direct File Link
https://drive.google.com/file/d/1gKSddioP8vE9ZlHTXEKP21OqR9HTMBoG/view
Song ID
513539
Extra
Created from Auto Nong.
Created for level: 49896559

accept


Update README with link to Formtastic example

The Formtastic example project is very old and unsupported. In lieu of updating the example project, I would suggest removing the link on the README for cocoon.

The Formtastic demo has been upgraded to Rails 5.


Add simple link to CONTRIBUTING.md

Contributing rules should be in the README so that people who visit this repository can know where they should submit their changes.
Signed-off-by: Eli Uriegas<EMAIL_ADDRESS>

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "patch-1" git@github.com:seemethere/docker-ce.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353671112
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.


Determine warehouse size guide

Adding new guide to help users determine the appropriate warehouse size for their query.

thank you for the PR!


try some win ci

Codecov Report

Merging #56 into master will decrease coverage by 1.31%.
The diff coverage is 44.44%.

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   90.58%   89.27%   -1.32%
==========================================
  Files           2        2
  Lines         223      233      +10
==========================================
+ Hits          202      208       +6
- Misses         21       25       +4

Impacted Files
Coverage Δ

src/PackageCompilerX.jl
88.78% <44.44%> (-1.68%)
:arrow_down:

src/juliaconfig.jl
92.85% <0%> (+1.19%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20f0cef...8d3d3fd. Read the comment docs.


Compilation failing due to a warning

The liquid-c gem is bundled in Jekyll and when I updated my bundle earlier on it updated liquid-c from 0.0.2 to 0.0.3. It failed during the compilation. I tried again installing only the gem, it also failed with the following log:
$ gem install liquid-c -v '0.0.3'

Building native extensions.  This could take a while...
ERROR:  Error installing liquid-c:
	ERROR: Failed to build gem native extension.

    /Users/kara/.rvm/rubies/ruby-2.0.0-p353/bin/ruby extconf.rb
creating Makefile

make "DESTDIR=" clean

make "DESTDIR="
compiling block.c
compiling lexer.c
compiling liquid.c
compiling parser.c
cc1: warnings being treated as errors
parser.c: In function ‘rb_parse_expression’:
parser.c:165: warning: unused parameter ‘self’
make: *** [parser.o] Error 1

make failed, exit code 2

Gem files will remain installed in /Users/kara/.rvm/gems/ruby-2.0.0-p353/gems/liquid-c-0.0.3 for inspection.
Results logged to /Users/kara/.rvm/gems/ruby-2.0.0-p353/extensions/x86_64-darwin-10/2.0.0/liquid-c-0.0.3/gem_make.out

I also tried to install v0.0.2 with no problems.
I don't know if it has anything to do with my setup but I managed to get past this by installing liquid-c by itself with the -w cflag in order to ignore warnings during compilation:
$ gem install liquid-c -v '0.0.3' -- --with-cflags=-w

It can probably be corrected with a modification to ext/liquid_c/extconf.rb

Thanks for the report. Looks like your compiler is doing -Wextra or similar by default. #21 should disable that warning.

Fix released in 3.0.0


Reduce to FINER

@bratseth is this approximately the right level to use?

I think we just use FINE ...


user private message comments

comments for the user_private_message model.

Can you double check the return types. I think there's at least one in there that should be a UserInfo object but you have an "array" in there.

yeah, I fixed it here: https://github.com/concrete5/concrete5/pull/329


How to configure egress gateway to connect to remote https server requiring ssl client certificate.

Describe the feature request
Describe alternatives you've considered
[x] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Additional context
istio 1.9.5
I am currently getting this error from the egress gateway:
[istio-egressgateway-bbc67cff6-xdj6p] {"response_code":0,"user_agent":null,"route_name":null,"bytes_received":0,"request_id":null,"response_code_details":"filter_chain_not_found","duration":0,"authority":null,"start_time":"2021-07-09T17:08:52.966Z","downstream_remote_address":"<IP_ADDRESS>:51860","x_forwarded_for":null,"requested_server_name":null,"bytes_sent":0,"path":null,"upstream_host":null,"connection_termination_details":null,"upstream_local_address":null,"upstream_cluster":null,"response_flags":"NR","upstream_service_time":null,"protocol":null,"downstream_local_address":"<IP_ADDRESS>:8443","method":null,"upstream_transport_failure_reason":null}
I have a gateway and a destination rule set in the istio-system namespace with the following:
apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
name: istio-egressgateway-imfmobileplatformdashboard-ng-bluemix-net
namespace: istio-system
spec:
selector:
istio: egressgateway
servers:

port:
number: 443
name: tls
protocol: TLS
hosts:

redacted_hostname
tls:
mode: MUTUAL
credentialName: redacted_hostname # this must match the secret created earlier to hold client certs

apiVersion: networking.istio.io/v1beta1
kind: DestinationRule
metadata:
name: originate-mtls-for-imfmobileplatformdashboard
namespace: istio-system
spec:
host: redacted_hostname
trafficPolicy:
portLevelSettings:
- port:
number: 443
tls:
mode: MUTUAL
credentialName: redacted_hostname # this must match the secret created earlier to hold client certs
sni: redacted_hostname
apiVersion: v1
kind: Secret
metadata:
name: redacted_hostname
namespace: istio-system
type: kubernetes.io/tls
data:
tls.crt: |
base64 encoded data
tls.key: |
base64 encoded data=
ca.crt: |
base64 encoded data

Do you have the corresponding ServiceEntry defined with redacted_hostname as hostname. When you define a destination rule for a hostname Istio should "know" about the service. When the service is external, you do that with ServiceEntry.
The error says "NR" meaning - No Route. It does not know about redacted_hostname. Take a look here - https://istio.io/latest/docs/reference/config/networking/service-entry/ . Define a MESH_EXTERNAL service with resolution DNS for the redacted_hostname. Also set port to 443/HTTPS.


Mark brainreg-segment package as deprecated in prep for renaming.

Marks brainreg-segment as deprecated, as per https://github.com/brainglobe/BrainGlobe/issues/36.
Once merged:

Tag a new version, <1.0. Publish release notes for this accordingly.
Merge in #139
RENAME this repository to brainglobe-segmentation.
Tag version 1.0.0. Publish release notes accordingly.
Publish to PyPI by pushing v1.0.0 tag.
Update dependencies with the name change:

brainreg
cellfinder

Completion of these steps will then resolve the meta-issue https://github.com/brainglobe/BrainGlobe/issues/36

Have I missed something with this PR? Once the package is renamed, it will tell users that it's deprecated, and then link to itself?


Update ASPIRE002 warning message

Update the PackageReference name in the ASPIRE002 warning from Aspire.Hosting to Aspire.Hosting.AppHost.
I just updated from preview 4 to preview 5 without updating my AppHost project to use Aspire.Hosting.AppHost instead of Aspire.Hosting and got confused when the build failed with this warning saying I was missing a reference to something that was there:
Warning: /usr/share/dotnet/packs/Aspire.Hosting.Sdk/8.0.0-preview.5.24201.12/Sdk/Sdk.targets(39,5): warning ASPIRE002: MyProject.AppHost is an Aspire AppHost project but necessary dependencies aren't present. Are you missing an Aspire.Hosting PackageReference? [/runner/_work/myproject/myproject/src/MyProject.AppHost/MyProject.AppHost.csproj]

<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <IsAspireHost>true</IsAspireHost>
    <OutputType>Exe</OutputType>
    <TargetFramework>$(DefaultTargetFramework)</TargetFramework>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Aspire.Hosting" />
  </ItemGroup>
  <ItemGroup>
    <ProjectReference Include="..\MyProject\MyProject.csproj" />
  </ItemGroup>
</Project>

Once I found the updated docs, I realised my mistake and updated my reference, which fixed the build.
Microsoft Reviewers: Open in CodeFlow

/backport to release/8.0


add the lorawan hal file and porting file

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


require('react') may resolve to react-slick's local bower_components/react

in my webpack.config.js I have:
  resolve: {
    extensions: ['', '.js', '.jsx'],
    modulesDirectories: ['bower_components', 'node_modules'],
  },
  plugins: [
    new webpack.ResolverPlugin(
      new webpack.ResolverPlugin.DirectoryDescriptionFilePlugin('bower.json', ['main'])
    ),

Which means the require('react'); within react-slick.js resolves react to the react.js in its bower_components directory, and fails within React's findComponentRoot on (compiled) line 11563: firstChildren[0] = deepestAncestor.firstChild;.
The issue is that when -slick intitialises, React looks for the root node, which is generated by a different React, therefore ReactMount.findComponentRoot can't find reactRoot.
Deleting the bower_components directory inside node_modules/react-slick fixed my issue for now, but it will come back when a fresh environment does a npm install (including elastic beanstalk or heroku builds). I haven't got a permanent solution yet.

tl;dr: The existence of bower_components in the node_modules/react-slick/ directory may affect webpack's module resolution and use the bundled React, which is different from the one which rendered the page, causing a fatal error.

I'm having a similar issue. package.json has a postistall script, which is trying to call "bower install," except bower isn't listed as a dependency.
I'm wondering why you need bower at all here? Can't you just include all of the bower packages in package.json?

removed the dependency on bower and added slick-carousel as a npm dependency.
Released 0.3.7 on npm with change.
Check if your issues got resolved.

@akiran this worked great. Thanks for the fix and thanks for the app.

:+1: works for me!


before_action in BreadcrumbsForWorks doesn't belong

Seems this belongs in a more appropriate place:
        before_action :save_permissions, only: :update

I believe it was here before the breadcrumb extraction in Hyrax: https://github.com/projecthydra-labs/hyrax/blob/master/app/controllers/concerns/hyrax/works_controller_behavior.rb


ionic2 bug (picker) sometimes throw an exception "Error in in ./PickerColumnCmp class PickerColumnCmp - inline template:0:215"

ionic2 version : beta 9
IOS version : 9
this exception is not get every time,only get it if quick call picker.
if angular enable prd mode, this exception gone, but this ok button stop work.
who know what's the reason?
Exception detail:
ViewWrappedException = $1
_context: DebugContext {_view: DebugAppView, _nodeIndex: 0, _tplRow: 0, _tplCol: 215, …}
_originalException: ExpressionChangedAfterItHasBeenCheckedException {message: "Expression has changed after it was checked. Previ…ue: 'undefined'. Current value: '[object Object]'", stack: "BaseException@file:///var/mobile/Containers/Data/A…ww//build/js/app.bundle.js:59356:44↵[native code]", toString: function}
_originalStack: "BaseException@file:///var/mobile/Containers/Data/Application/A946B6EB-095E-4A48-8A4F-035437E88927/Library/Application%20Support/com.maxv.fir…"
_wrapperMessage: "Error in ./PickerColumnCmp class PickerColumnCmp - inline template:0:215"
_wrapperStack: "WrappedException@file:///var/mobile/Containers/Data/Application/A946B6EB-095E-4A48-8A4F-035437E88927/Library/Application%20Support/com.maxv.…"

Hello, thanks for opening an issue with us! Would you be able to provide a plunker that demonstrates this issue? Thanks for using Ionic!

Hello all! As it seems it has been a while since there was any activity on this issue i will be closing it for now. Feel free to comment if you are still running into this issue. Thanks for using Ionic!


Kinetic scroll animation

Type of PR: enhancement
PR checklist:

[x] Addresses an existing issue: fixes #832
[x] Includes tests
[x] Documentation update

Overview of change:

Dose trading view use any library for chart animation like (mobile horizontal scroll smoothly ) and another events on chart or all of this is hard coded ?

@mhtzghoul as you can see everything is implemented internally and we don't rely on any external implementation for animations.

@timocov  i have question
this function ( getPosition(time: number) ) return the Last position of animation One time , Or by accumulation and repetition the position ?

@timocov  i have question
this function ( getPosition(time: number) ) return the Last position of animation One time , Or by accumulation and repetition the position ?

@kirchet ^^ please

Not sure that I understood the question.
getPosition(time: number) returns animation position accordingly to provided time. Internally it stores start animation time and duration. If time - startTime >= duration then it returns final position


Improve Lighthouse score

Description
Lighthouse Report
Icon changes incorporated in flutter/packages#259
Tests - N/A
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change.

cc @Hixie

Icon changes incorporated in flutter/packages#259

That change didn't update the version, so can't be published; there's no way to refer to those images currently because they don't exist in a published version of the package.

@stuartmorgan so is there a need to wait for a version update

Generally version updates are made as part of the change. Since it wasn't, you can either wait for an unrelated change to that package to land and be published (there's one that was just opened, which is how I noticed this, but I don't know when it will land exactly), or you can do a PR just to update the version and CHANGELOG so your change can be published.

Thanks @stuartmorgan
I don't think I'll be able to work on this right now so I'll wait for the PR to land. If it doesn't land in a week or so, I'll update the CHANGELOG
Is it alright?
Thanks for the support 🙂

This PR isn't adding the .img.tmpl files, so won't actually change the template.
Between that and https://github.com/flutter/packages/pull/363 it seems like you've never actually verified that this PR works. Please get it working end-to-end locally before requesting review on the PRs.

@stuartmorgan I've added that change in #83128 which focuses solely on maskable icons
Sorry for the inconvenience

I'll keep this PR open to work on the other changes, if it's ok


MySqlConnector use database statement

Laravel Version: 5.2.45
PHP Version:5.6.29
Database Driver & Version:MySQL 5.7.16

Description:
in my old project, i use the laravel  5.2.22
and  the Illuminate\Database\Connectors\MySqlConnector connect function
...
    public function connect(array $config)
    {
        $dsn = $this->getDsn($config);
...
        if (isset($config['unix_socket'])) {
            $connection->exec("use `{$config['database']}`;");
        }
...
    }
...

in my new project, i use the laravel 5.2.45
and  the Illuminate\Database\Connectors\MySqlConnector connect function
...
    public function connect(array $config)
    {
        $dsn = $this->getDsn($config);
...
        if (! empty($config['database'])) {
            $connection->exec("use `{$config['database']}`;");
        }
...
    }
...

And i use the same (default) database configuration in both project
            'driver' => 'mysql',
            'host' => env('DB_HOST', 'localhost'),
            'port' => env('DB_PORT', '3306'),
            'database' => env('DB_DATABASE', 'forge'),
            'username' => env('DB_USERNAME', 'forge'),
            'password' => env('DB_PASSWORD', ''),
            'charset' => 'utf8',
            'collation' => 'utf8_general_ci',
            'prefix' => 'v3_',
            'strict' => false,
            'engine' => null,

the issue is  in laravel 5.2.45 it exec use my_database, i doubt if it's necessay.Because in my condition, i connect a proxy rather than connect mysql server directly,and it don't allow me to do such use database statements.

Sorry. but our time machine is broken so we can't go back to 5.2 and fix issues. 5.2 is end of life. Do try this in 5.4 or 5.5-dev versions and let us know what happens

Yes please upgrade since 5.2 is not supported anymore.


Security Vulnerability

Hello Team, we are getting a  Hardcoded cryptographic keys security exception and Microsoft.Security also encourages considering re-designing the application to fix this Weakness.
Propagation: Pods/MSAL/MSAL/IdentityCore/IdentityCore/src/util/NSData+AES.m
CCCryptorStatus cryptStatus = CCCrypt(kCCDecrypt, kCCAlgorithmAES128, kCCOptionPKCS7Padding, key, keySize, NULL /* initialization vector (optional) */, [self bytes], dataLength, /* input */ buffer, bufferSize, /* output */ &numBytesDecrypted);
Source: Pods/MSAL/MSAL/IdentityCore/IdentityCore/src/requests/broker/MSIDBrokerCryptoProvider.m at line 109
(NSData *) msidAES128DecryptedDataWithKey:(const void *) keySize:(size_t) CCCryptorStatus cryptStatus = CCCrypt(kCCDecrypt, kCCAlgorithmAES128, kCCOptionPKCS7Padding, key, keySize, NULL /* initialization vector (optional) */, [self bytes], dataLength, /* input */ buffer, bufferSize, /* output */ &numBytesDecrypted);
Questions:

Is this really a matter of concern to use MSAL library with this weakness?
What could be the fix for this weakness?
How soon we can expect a fix?

Wrong thread


Fix no-redeclare in code and switch to error mode

Every file change is pretty straightforward, except for lib/HotModuleReplacement.runtime.js which just takes a little extra time to stare at.

Thanks


Extra path option to configDir. Useful to work with yarn workspaces

When I was working in a monorepo, It was looking for dotenv files in the root of the repository. So, this helps to append an extraPath to find dotenv files. @hdwilber

@hdwilber what if we just set a default path and add configDir as a parameter?


i should use ServerSession on client or server?

i should use ServerSession on client or server?

you can use it on the client, with a "setCondition" check on the server.

Thanks.
i do need use server session like php, but i don't understand on Meteor.user collection.

If you have a look at all the tutorials it shouldn't be too much of a problem. Much success!

thanks again.


[FEATURE] Using fecha in place of moment

While moment is an amazing and robust library, it seems like an overkill. I propose using fecha it is much smaller than moment and can be extended to add missing functionality. If you think it is beneficial I can submit a PR for review.

hmm, I'm a little wary of changing this. What are the advantages of using fecha over moment?
If we are to use this, we first need to move the time scale to be based on the linear scale. ie, we use a parser to transform the dates into unix millisecond timestamps then simply pick good size steps and then convert back to date strings.

@salzhrani I should add that I did try playing around with changing the time scale to be based on the linear scale. Code is in https://github.com/chartjs/Chart.js/tree/time-scale-improvements
CC @chartjs/maintainers to get your thoughts

This library does seem to be a lot smaller than moment and could resolve some issues that people are having using moment with Chart.js. If we could implement it, it could save some size but that seems to be the only main advantage.

It is mainly for size, some projects have js payload budget and this could help with that.

@zachpanz88 it could solve issues for people already using moment, but then issues will be for people already using fetcha. So if we switch to another library, we should consider #2906 but also ensure backward compatibility (I don't know if we expose moment specific options / formatting). Ideally, we should provide a way for users to choose whatever time lib they want.

@salzhrani, it's kind of hacked together, but I'm using time scales with fecha.  I've got a fork of fecha at https://gitlab.com/avlcodemonkey/fecha that adds in the date manipulation features needed to make it work.  And I've got a branch at https://github.com/avlcodemonkey/Chart.js that implements it.

I think the time scale might need a rethink. Instead of using the date manipulation features, we should base it on a linear scale and set the division size appropriately. We'd use fecha/moment to parse the dates into millisecond timesteps then the scale would internally use those timesteps before formatting the output back into nice strings

Since this issue was opened we've changed the time scale internals to depend less on moment. Right now moment is primarily used for the date parsing and formatting. This may make this issue much easier to implement safely

It's also been proposed that we use date-fns in https://github.com/chartjs/Chart.js/issues/4303. date-fns looks to be much more popular. Is there any reason we should consider fecha instead of date-fns?

To me, it's about library size.  Fecha is a very small library that can replace a very large one for chartjs purposes.  If it's possible to use a small subset of date-fns via ES6, I'm open to that approach.  date-fns is clearly more popular.  I would prefer to avoid including the entirety of date-fns though.

Fecha does not seem like a realistic option. It has no date manipulation APIs. There's a lot of functionality that we currently have that could not reasonably be written with Fecha. E.g. it has no ability to calculate the timestamp for the beginning of an hour, day, year, etc.

When I opened the issue about a year ago, date-fns didn't exist. The motivation was to reduce the lib size and not necessarily advocate fecha.

Ok. I'm going to close this issue in favor of tracking it with the date-fns issue. date-fns support tree shaking, so it's much easier to use just the relevant subset of it that we need


move to production

[x] https://github.com/airqo-platform/AirQo-api/pull/2959

Hi @Psalmz777 / @BenjaminSsempala ....

I have just updated the NGINX configurations.
I anticipate some instability within the next 4 hours or so.
In case of any unusual instability, please just restart all the production cluster nodes (1,2 and 3).


[SPARK-20946][SQL] simplify the config setting logic in SparkSession.getOrCreate

What changes were proposed in this pull request?
The current conf setting logic is a little complex and has duplication, this PR simplifies it.
How was this patch tested?
existing tests.

Test build #77628 has started for PR 18172 at commit 077795d.

Test build #77628 has finished for PR 18172 at commit 077795d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77628/
Test FAILed.

Test build #77643 has started for PR 18172 at commit 3edec68.

Test build #77643 has finished for PR 18172 at commit 3edec68.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77643/
Test FAILed.

Test build #77648 has started for PR 18172 at commit b2a75fe.

Test build #77648 has finished for PR 18172 at commit b2a75fe.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77648/
Test FAILed.

Test build #77652 has started for PR 18172 at commit ace2fbc.

Test build #77652 has finished for PR 18172 at commit ace2fbc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77652/
Test PASSed.

Merged build finished. Test PASSed.

CC @liancheng

LGTM except for one comment regarding the behavior change.

Test build #77665 has started for PR 18172 at commit a8fe8b0.

Test build #77665 has finished for PR 18172 at commit a8fe8b0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77665/
Test PASSed.

Merged build finished. Test PASSed.

thanks for the review, merging to master/2.2!

Reverting this because it breaks repl tests.


[Select]: onChange not called on Select.HiddenSelect.

Describe the bug
onChange not called on Select.HiddenSelect
Expected behavior
Should call onChange on Select.HiddenSelect when provided.

fixed in v0.8.0.


Property IndentationControl

The Property IndentationControl seems to have no effect anymore.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4757480a-c03f-22fb-a7cb-158e73e49282
Version Independent ID: 787b31f8-39a7-a85c-9130-38fae7c6eb9a
Content: IndentationControls Property - Business Central
Content Source: dev-itpro/developer/properties/devenv-indentationcontrols-property.md
Service: dynamics365-business-central
GitHub Login: @jswymer
Microsoft Alias: solsen

Hello, Thanks for the feedback.
This issue seems to be a duplicate of issue 1336. So, I will close this issue, and use 1336 for tracking.

@jswymer: I wanted to make sure that all articles get updated.


[Feature Request] Add clampToGround to polygon options

Now we have both zIndex and clampToGround options available for polyline, but for polygon, we only have the zIndex option.
Additionally, we cannot use the zIndex option on a polygon that is not a ground entity.
This behavior is confusing and unintuitive. It is necessary to reach a consensus and make the behavior consistent

It's really confusing


Questions on

Hi
We are also using PGVector to do to embedding search.
We are using Django-filter for faceted search on model fields.
We are using a MrThearMan/graphene-django-query-optimizer to provide .only, prefetch_related and select_related optimizations to ensure our generated SQL runs fast.
We've used EXPLAIN_ANALYZE and noticed that PGVector appears to be running on all rows on the table, and then filtering occurs, which is suboptimal.
We want to ensure that our PGVector embedding calculations run only on pre filtered results.
Does anyone have any real advice on how to

properly formulate Django ORM queries to do this while allowing the flexibility of Django-Filter ?
where the best place to insert overrides on filter sets ordering to ensure performance is respected?

Thanks!

Hi @vade, the Postgres planner should select the most efficient plan in most cases (if not, try running ANALYZE or using extended statistics).


The scale factor and orientation of pointcloud exported

Thanks for your awesome project. I'm a bit confuse about the result of pointcloud exported by ns-export.
step 1.   I obtained the  transforms.json colmap model folder (contains cameras, points3D, images in sparse/0)  after running  ns-process-data.
step 2.  train nerfacto with  nerfstudio-data
ns-train nerfacto --pipeline.model.predict-normals True  --data  ${DATASETS} nerfstudio-data  --downscale-factor 1
step 3. ns-export to get pointcloud file
but pointclud didn't set the same orientation and scale factor  with COLMAP-Base method's result (eg. mvsnet) which reconstructed from  colmap model folder(got in step 1.), they shoud have the same camera intrinsics and poses .
The left result is NERF, right is MVS

My doubts as below

I noticed that Nerf use the OpenGL/Blendercoordinate (as show in data-conventions), so transforming the pointcloud to convert to the COLMAP coordinate after I export the pointcloud is required,  am I right?
On the other hand, I confuse with this beacuse I thought the scale factor and orientation of the pointcloud should be fixed when the camera intrinsics and poses are same.

And then I found the  issue#761, and use the command line
ns-train  ...  nerfstudio-data  - --orientation-method none --center-method none --auto-scale-poses False
to "don't want  dataparser to change the poses at all".
I thought I got the weird result(the left), which is  worse than before. as can see, it seems generated 'duplicated object'
and  don't obtain the actual scale factor I need.

The transformation info is located in the dataparser_transforms.json file in the outputs folder. It's on our list of TODOs, to have the option to export in the original coordinate frame.

yeah, I found that . Thanks
Zhiwei Jiang

在 2023年8月29日，03:06，Matthew Tancik @.***> 写道：

The transformation info is located in the dataparser_transforms.json file in the outputs folder. It's on our list of TODOs, to have the option to export in the original coordinate frame.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.

I have solved this,  and will close the issue
just transformed the exported pointcloud by the inversed  transform  and scale in dataparser_transforms.json.
Here is my python  script, maybe it will be helpful for someone who encounters the same trouble.
import open3d as o3d
import numpy as np
from open3d import io as o3d_io
import json
import copy
import os
def transofrm_cloud(cloud_in_path:str, transforam_scale_json_path:str):
    pcd = o3d_io.read_point_cloud(cloud_in_path)
    with open(transforam_scale_json_path, "r") as fr:
        transforam_scale_json = json.load(fr)
    # transformation = torch.as_tensor(transforam_scale_json["transform"])[None]
    cloud_out_path = os.path.join(os.path.dirname(cloud_in_path), "transformed_point_cloud.ply")

    transformation = np.asarray(transforam_scale_json["transform"])
    # transformation[:, :3] = np.linalg.inv(transformation[:, :3])
    transformation = np.concatenate([transformation, np.array([[0, 0, 0, 1/transforam_scale_json["scale"]]])], 0)
    transformation = np.linalg.inv(transformation)
    # use numpy to scale
    # points = np.asarray(pcd.pcd_transformed)
    # centroid
    # centroid = points.mean(axis=0)
    # # scale
    # scaled_points = (points - centroid) * scale_factor + centroid
    # update point
    # pcd_transformed.points = o3d.utility.Vector3dVector(scaled_points)
    pcd_transformed = copy.deepcopy(pcd)
    # use open3d to scale and transform
    pcd_transformed.transform(transformation)
    # pcd_transformed.scale(scale_factor, center=pcd_transformed.get_center())
    o3d_io.write_point_cloud(cloud_out_path, pcd_transformed)

if __name__ == '__main__':
    transofrm_cloud("export/com_mypose/point_cloud.ply", "outputs/com_mypose/nerfacto/2023-08-28_160924/dataparser_transforms.json")

The original scale and position is fine. (bright is transformed)


Increase default connect timeout to 0.1

Set the default webpack dev server connect timeout to 0.1s for calling the #running? method
Raised an issue and a PR was requested in #73
Reproducing this issue is a little tricky as it means having a dev server that takes longer than 0.01s to accept a TCP connection. Perhaps it could be reproduced with a very busy workstation.
I have observed this happening repeatedly while troubleshooting with coworkers, but it doesn't typically happen for me, although I have also seen it. I am recommending this change because firstly, it has proved to be a more reliable value in my observations.
But also, the change from 1s to 0.01s seems to have been made without much discussion and without any stated reason:
rails/webpacker/pull/753
It is thankfully configurable now and we have done that for ourselves, but I'm interested in helping others avoid this debugging headache by choosing a more generous timeout. If I understand correctly, this will

have no effect for most people who are not running the dev server as running? will return false immediately when the connection is refused
It will solve an issue when a dev server takes between 0.01s and 0.1s to accept a connection and
It will cause a 0.09s added delay for someone who's system drops TCP packets to the specified devserver host/port (not sure how common that is)

@stevecrozz very nice job!
Could you please add an entry to the CHANGELOG.md and I'll merge and release!

No prob! Added an entry to CHANGELOG.md

Thanks, @stevecrozz!

Thanks also to @harrisonb for initially tracking down this issue.


Unable to retrieve any data, aswell as an telescope error

Describe the bug
I've installed the plugin and run setup and update,  I've confirmed that telescope works normally in other situations.
When I type notion menu I get nothing up,  and if i type anything and press enter I get the following error
E5108: Error executing lua: ...cal/share/nvim/lazy/notion.nvim/lua/notion/telescope.lua:90: attempt to index local 'selection' (a nil value)                                   stack traceback:                                                                                ...cal/share/nvim/lazy/notion.nvim/lua/notion/telescope.lua:90: in function 'run_replace_or_original'                                                                          ...re/nvim/lazy/telescope.nvim/lua/telescope/actions/mt.lua:65: in function 'key_func'                                                                                ...hare/nvim/lazy/telescope.nvim/lua/telescope/mappings.lua:293: in function <...hare/nvim/lazy/telescope.nvim/lua/telescope/mappings.lua:292>
I'm using default configuration,  I've confirmed that the api key has access
I'm on arch and my system, nvim and all plugins are up to date.
Any ideas? :)

Solved with this solution https://github.com/Al0den/notion.nvim/issues/22#issuecomment-2322894795


Update UI elements: select option & slider

Currently, these two elements are not yet correctly styled:

Slider

[ ] Update thumb color to holon-blue-500
[ ] Add thumb border
[ ] Add dropshadow

Select option

[ ] Add select icon (cross or check mark)

Please add the disabled version, see issue #34, while working on the styles


CI: ConformanceDatapath: Incorrect status if jobs are skipped

The ConformanceDatapath workflow doesn't properly set its status on GitHub if the test is skipped. In such cases, the workflow remains indefinitely in Pending state.
Example: https://github.com/cilium/cilium/actions/runs/4699458917

Interesting. This likely also applies to other workflows (ci-verifier, ci-clustermesh) that use the same pattern as well. I guess we need to fix Set commit status to set the test as succeeded instead of as pending.


Are there any benchmarks to prove the advantages of making each of these changes?

Is there any want to demonstrate the performance or memory usage improvements that would result from making each of the recommended changes?

In general they're a good idea simply because of the memory use. Quite often it's hard to estimate the maximum size of a collection so a list comprehension instead of a generator is an unknown extra amount of memory.
A few improvements have been made to the Django ORM from these, but others have been rejected: https://github.com/django/django/pulls?q=is%3Apr+flake8-comprehensions+is%3Aclosed . It's not always cut and dry but I think a good default is to err on the side of flake8-comprehensions.
If you want to do some simple benchmarks and add to the readme that would be great.


DOCS: fixed broken bullet list in configuration.markdown

One little line, causing the doc to render wrong.

:+1:


[semver:patch] #12 Base is chosen implicitely

This fix uses the hidden --release flag of the github cli tool to
create a release on the repository on which the pipeline is running
and not the one that it was forked from. The github cli tool asks
in interactive mode where to create the release but defaults to
the upstream which can lead to an unwanted official release during
testing as it happened to me.
With this fix this tool will default to origin which I assume is the only
sensible approach in a pipeline because origin presumably is the
one that the pipeline is running on.

https://github.com/cli/cli/issues/4688
Closes #12

Thank you @TimoKramer ! Merging this in as a patch now.

Not sure why some of the checks appear incomplete, they are in fact complete. Making a note of it here in case it comes up again, manually overriding for now.


Kodi 18 (Leia): MSLError: This title is not available to watch instantly - RasPi

Bug report
This is to separate the issue from a similar issue experienced on CHROMEBOOK, Kodi 19 (https://github.com/CastagnaIT/plugin.video.netflix/issues/1286)
Your Environment

Netflix add-on version: 1.12.8
Operating system version/name: LibreElec 9.2.8, Kodi 18
Device model: RasPi, but according to comments in bug report https://github.com/CastagnaIT/plugin.video.netflix/issues/1286 , this is not device specific,

Used Operating system: neither it is operating system specific

[ ] Android
[ ] iOS
[x] Linux
[ ] OSX
[x] Raspberry-Pi
[ ] Windows

Describe the bug
Since 2nd February 2022 I have been experiencing the next issue: when I try to play a video, I have the "MSLError: This title is not available to watch instantly. Please try another title."
Before that date everything had been working fine. Did not change anything in configuration....
Expected behavior
Should play the title...
Actual behavior
"MSLError: This title is not available to watch instantly. Please try another title."
Steps to reproduce the behavior
1. Open the add-on
2. Browse Netflix
3. Launch a video

Possible fix

Debug log

The debug log can be found here:
kodi20220202.log

Open addon Expert settings and Change "MSL manifest version" setting to original value.

watch here : https://github.com/CastagnaIT/plugin.video.netflix/issues/1300

working workaround:
https://github.com/CastagnaIT/plugin.video.netflix/issues/1300#issuecomment-1029561650

Thanks go to krom54 and bpilsl for reacting! The proposed solution is https://github.com/CastagnaIT/plugin.video.netflix/issues/1300 did work!
Closing the issue....


Update to use LabIcon

The jupyterlab-2.0 branch currently leverages the new LabIcon for all the supported cases available prior to the merging of https://github.com/jupyterlab/jupyterlab/pull/7864  We should move the remainder of our icon usage over to LabIcon. This is non-blocking since currently our "mixed" usage is fully functional.

This has been merged into jupyterlab-2.0


Redundant views shown for LTTng UST traces

With the support of data-tree and scatter charts views like Latency Statistics or Latency vs Time views are now available in the list of Available Views. The Trace Compass server of today provides call stack analysis from the Trace Compass mainline and the Trace Compass Incubator which leads to duplicate and redundant views:
From Trace Compass:

Flame Chart
Function Duration Statistics
LTTng-UST CallStack - Latency Statistics
LTTng-UST CallStack - Latency vs Time

From Trace Compass Incubator:

Flame Chart LTTng-UST CallStack (Incubator)
LTTng-UST CallStack (Incubator) - Latency Statistics
LTTng-UST CallStack (Incubator) - Latency vs Time

The statistics views show pretty much same data, with some small differences. In some cases the symbol resolution is not working all the time for  LTTng-UST CallStack (Incubator) - Latency Statistics.
The Flame Chart LTTng-UST CallStack (Incubator) also shows the Kernel Status if the the kernel trace is part of the trace set. This is not available in the mainline Flame Chart.
Here is picture of the available views for a LTTng UST trace:

To avoid confusion for end-users (and new users), the list of available view needs to be cleaned-up to remove duplicates and redundant data. This is a Trace Compass server implementation issue an needs to be handled there and not in the front-end because the front-end is server-agnostic.

Relates to #296


Add IMDB to filename

Hello all,
I was looking for and haven't been able to find this feature.
If the file does NOT have a IMDB  id in the filename is it possible to have it added after the conversion?
Thanks loving this script.

I usually do this with Couchpotato very easily with the renamer but i have yet to find a way to do it in sickbeard.

This script doesn't do renaming in any way. Renaming is handled by the media managers. I believe CP does do this though as simon2k13 mentioned.


Added Pull Request template

Resolves issue #338
Addition of pull request template file in .md format.
Please review it. @Shreyaar12

Hello @Shreyaar12, please assign me the appropriate level label.

Hello @panwar8279 , Please assign valid labels (gssoc23 and labelX).


FIX: Fix CI script on develop and main branches

What's happened
We used the wrong --base argument when running tests on develop and main branches, this PR set the correct base for them:

In develop branch: diff with main branch.
In main branch: run all tests.

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@7404eac). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop      #34   +/-   ##
==========================================
  Coverage           ?   91.31%
==========================================
  Files              ?      188
  Lines              ?     2419
  Branches           ?      274
==========================================
  Hits               ?     2209
  Misses             ?      165
  Partials           ?       45

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Allow module wildcards

In large projects you often want to enforce explicit silos of modules. These layers reduce the chance of circular dependencies and keep things a bit more sane. The module restriction feature could work perfectly for this if it had wildcards.
- modules:
  - {name: [Foo.Bar.*], within: [Foo.Bar.*, Foo]}
  - {name: [Foo.Qux.*], within: [Foo.Qux.*, Foo]}

This is likely a weaker form of the intention behind https://github.com/ndmitchell/lasagna

I like the idea. Only question is what is the semantics of module wildcards? Does it match 0, 1 or many? Should the valid wildcards the * (0 or more), + (1 or more), ? (exactly 1) to match regex? Or should it be * and ** ?

Good question. My original intention was that * acts like a glob with 0 to many.
Foo.Bar.* matches multiple segments
Foo.Bar.Baz
Foo.Bar.Baz.Qux
...

Foo.Bar* matches:
Foo.Bar
Foo.BarBaz
Foo.Bar.Baz
Foo.Bar.Baz.Qux
...

However, a more complicating matching grammer might be better or just falling back to regex proper.

Are there any existing semantics in some well used module matching tool we can fall back on?

Hmm not that I'm aware of, but it is worth the research.

My proposal would be to mimic shell path expansion. It's probably well-defined and shell nerds like myself would find it perfectly intuitive.
For example,
Foo.* matches
Foo.Bar, and
Foo.Baz, but not
Foo.Bar.Baz

Foo.**.* matches all of the above

Foo.**.*Spec mathes Spec modules at any depth.

That seems pretty reasonable since modules are essentially just paths.

@ndmitchell Any thoughts on this path? I can start on a PR if we have a path.

My thoughts are probably the right way to go is take the FilePattern library that is in Shake, extract it out to a standalone library, and then use it for both this and for #334. Of course, that makes it a fairly reasonably sized chunk of work which involves pulling apart a lot of Shake...

That sounds like a sane approach. I'll open an issue over at shake in case I lose steam, so this path is at least documented.

Sorry to revive an old issue, but I am also interested in this feature. Is there anything that I can do to move things along? @eborden extracted the file pattern library mentioned above and opened a PR to use it in Shake (https://github.com/ndmitchell/shake/pull/551). Even if that PR doesn't land, it seems like we could use the file pattern library to get this done. Is that right?

I was just thinking of this the other day. We could atleast get filepattern up on hackage.

Opened an issue here: https://github.com/eborden/filepattern/issues/3

I don't disagree. This is my main open source project at the moment - I was hacking on it last night. I think I've got down to one open design question, and am looking towards a release soon.

Now filepattern is on Hackage at https://hackage.haskell.org/package/filepattern.
It should be possible to just use ?== and replace "." "/" to get it working.

I am curious about the current state of affairs of this PR. Is anyone actively working on this feature? (My guess is that the answer is "no" given the rather extensive time-line.)

I'm unaware of any progress. The prerequisite of getting filepattern on Hackage has been complete, but nothing since.

I made a PR for this: https://github.com/ndmitchell/hlint/pull/1149.

Note the comment on https://github.com/ndmitchell/hlint/pull/1149#issuecomment-704471359 alludes to some bits that aren't yet complete.

I've got a PR for the rest of this: #1221.


Typescript makes properties readOnly

Hello,
Is there any way to make the properties readOnly when converting to typescript?
Thanks

welp jsonShemas support flag read-only.
But it seem not supported in quicktype !
{
  "id": "http://json-schema.org/geo",
  "$schema": "http://json-schema.org/draft-06/schema#",
  "description": "A geographical coordinate",
  "type": "object",
  "properties": {
    "latitude": {
      "type": "number",
      "readOnly": true
    },
    "longitude": {
      "type": "number"
    }
  }
}

I hope a good guy will can add those feature !
https://json-schema.org/draft/2019-09/json-schema-validation.html
Json shemas is the nextgen json for most sofware and game !


Retry Logic

Hi,
Nice project, I just came here from the hackernews discussion and noticed this comment you made.
"I've also thought about reserving a topic + consumer group specifically for failed jobs and bake the retry logic into KQ itself. But that's an area I must explore more."
At my work, we have made a less sophisticated version of kq -- and this retry logic has been baked in by us, so I thought I would describe it, as it works out quite well for us.

Message is consumed.

If exception happens send it to a retry topic named like this {original-topic-name}.{consumer-group}.retry we have the consumer group in the retry topic name because there are usually multiple consumers consuming off the same topic. Also add a retry_count into the message.

At an interval defined by the operator, read all the messages back off the retry topic, if they succeed, that's great, if they fail send it back to the retry topic but increment the retry_count by one (I should note, all of our messages are JSON encoded)

Keep reading messages, but if a message has over N retry_counts, instead of sending it back to the retry topic, we send it to a dead letter topic {original-topic-name}.{consumer-group}.dlt which usually gets picked up by an operator.

This was super simple to implement, and has worked out great for us so far (we originally came up with a much more complicated solution, but it sucked)
Thanks,
Ben

Hi Ben,
Thanks a lot for the suggestion.
I will take note when I implement the retry logic in the next release.
Sincerely,
Joohwan

So has retry logic been added now?


Pancurses backend doesn't handle backspace properly

Test by putting down a TextEdit with some default text and press Backspace on your keyboard.

I get a correct Key(Backspace) when pressing the backspace key.
Maybe it depends on the OS/terminal used? Can you try the key_codes example?
cargo run --example edit --no-default-features --features pancurses

I tried the edit example, and it seems to work fine. Maybe the issue is with default text in the EditView?... What's the exact code you tried?

OS: Win10x86_64
Terminal: cmd
edit example doesn't work. key_codes example yields , so I'm guessing handling that would fix it?
Exact code.

Indeed, it seems ASCII 8 is backspace, but since linux uses an escape code instead I never noticed it.

PR fix submitted, confirmed works.

Actually, can you try the Del key? Does it send Key(Del), or Key(Backspace)?

Del works


Delete all fonts before installing required fonts in Docker images

Describe the issue
Delete all OS fonts before installing the required fonts in the Docker images to avoid fonts leaking in PDF files.
Code of Conduct

[X] I agree to follow the IETF's Code of Conduct

This is a reasonable fix in the short term but since a lot of us run xml2rfc on our regular PCs, I hope we can figure out how fonts are leaking into Weasyprint and fix it.

@jrlevine I agree the proper fix is to avoid this scenario. I'm closing this issue in favour of #905 & #906.
There can be other instances of font leakages, I guess we have to analyze the fonts in PDF files before publication to find those issues.


  A reduced version of the output is below, running on a Macbook with i386.
Ld build/emulator/PhoneGap.app/PhoneGap normal i386
Undefined symbols for architecture i386:
"_sqlite3_bind_blob", referenced from:
___59-[GMRSqliteStore upsertStatementForRecord:inTableWithName:]_block_invoke350 in libGGLCore.a(GMRSqliteStore.o)
-[GCMRmq2PersistentStore saveMessageWithRmqId:tag:data:error:] in libGcmLib.a(GCMRmq2PersistentStore.o)
ld: symbol(s) not found for architecture i386
clang: error: linker command failed with exit code 1 (use -v to see invocation)
** BUILD FAILED **

@tylercasey couple of things to verify:

Make sure you are using Xcode 7 to build
Make sure you are using cordova-ios 4.1.x
If the above two don't work try disabling bit code in xcode.

Xcode needed upgrade, build completes.  Thanks!


[in_app_purchase] - macOS Support

Use case
There's no macOS implementation for in_app_purchase.
I added that and you can view the PR here: https://github.com/flutter/plugins/pull/4313
Proposal
Because the Plugin Developers added a platform_interface to in_app_purchase, it is easily possible now to add a new platform as clean as possible, so I tried to do that here. If you have any concerns or questions, please leave a comment in the PR or here.
Thanks :)

Duplicate of https://github.com/flutter/flutter/issues/84391


Rewrite Minify_Lines (debug mode) using JSMin algorithm

For this tool to be reliable, it needs to be based on a real Javascript
tokenizer, like JSMin.

I welcome code to improve Minify_Lines as long as it comes with an appropriate
unit test, otherwise I can't offer help on this.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 26 Aug 2013 at 2:16

Issue 279 has been merged into this issue.

Original comment by<EMAIL_ADDRESS>on 26 Aug 2013 at 2:17


Fix inconsistent date-times

This attempts to align the inconsistent dates listed in this ticket. https://issues.redhat.com/browse/YARA-217

Codecov Report

Merging #25 (8d62ae9) into master (c7dc375) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #25   +/-   ##
======================================
  Coverage    0.00%   0.00%
======================================
  Files          32      32
  Lines         470     470
  Branches      151     151
======================================
  Misses        424     424
  Partials       46      46

Impacted Files
Coverage Δ

src/Components/SigDetailsTable/SigDetailsTable.js
0.00% <ø> (ø)

src/Components/SysDetailsTable/SysDetailsTable.js
0.00% <ø> (ø)

src/Routes/Systems/Details.js
0.00% <ø> (ø)

src/operations/queries.js
0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7dc375...8d62ae9. Read the comment docs.


How to write own cost function in c++?

Thank you for the great project.
My questions is, how to write own cost function with c++? I have visual and inertial data.

We have some visual cost functions in COLMAP: https://github.com/colmap/colmap/blob/main/src/colmap/estimators/cost_functions.h There is also a pending PR for inertial optimization: https://github.com/colmap/colmap/pull/2561


Create Magic command azure.quotas in IQSharp

This change introduces a new magic command: %azure.quotas to IQSharp. This pull request is dependent on the following PR, since it exposes the required classes and interface methods:
https://github.com/microsoft/qsharp-runtime/pull/480

/azp run

/azp run

/azp run

/azp run

/azp run

/azp run

This pull request is being force merged since it is interdependent with qsharp-runtime:480.

This pull request is being force merged since it is interdependent with qsharp-runtime:480.


apns does not surport chinese

i change the line 200  to
return json.dumps(self.dict(), separators=(',',':')).encode('utf-8')

it just works for me

Can you please give an example of sending emoji if I use Unicode('😀😀','utf8') just gives a string of gibberish text in push not the emoji

@markmark1, you're close! you almost had it!:
string = unicode('😀 ', 'utf-8')

:cry:


3.1 build failure on FreeBSD

Godot version:
3.1 from git branch, commit dbf2f0c31e1742d361d9d591def2ce6e955800b0
OS/device including version:
FreeBSD 11.2-RELEASE-p4
Issue description:
I can't get godot 3.1 to successfully build on FreeBSD.
I was able to avoid an issue with enet by using module_enet_enabled=no
and another issue with vpx (build output complained about some function,
whose name ended with _avx2, not having avx2 support by using builtin_libvpx=no.
But now I'm stumped on an issue with zstd that seems to hit me, no matter what I set builtin_zstd to: no member named 'minMatch' in 'ZSTD_compressionParameters'
Traceback with builtin_zstd=yes: https://paste.xinu.at/wCNK7w/
Traceback with builtin_zstd=no: https://paste.xinu.at/0M5L4/
Steps to reproduce:
scons platform=x11 module_enet_enabled=no builtin_libvpx=no -j4

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236731
The FreeBSD port maintainer promptly made everything work in the port.
Patched port builds, installs and seems to work fine thus far.
I think for fixing this in godot itself the new files added in the submitted
patch are probably interesting, see https://bugs.freebsd.org/bugzilla/attachment.cgi?id=203065&action=diff

Godot version: f20c9c25ebddcef07daaa8788d8ff33679aa2aef
OS: FreeBSD 11.2-RELEASE-p4 amd64
I suppose this is related to the zstd part:
$ scons -j4 platform=x11 use_llvm=yes target=debug

Errors:
In file included from thirdparty/zstd/compress/zstd_compress.c:23:
thirdparty/zstd/compress/zstd_compress_internal.h:118:5: error: unknown type
      name 'ZSTD_literalCompressionMode_e'
    ZSTD_literalCompressionMode_e literalCompressionMode;
    ^
thirdparty/zstd/compress/zstd_compress_internal.h:200:5: error: unknown type
      name 'ZSTD_literalCompressionMode_e'
    ZSTD_literalCompressionMode_e literalCompressionMode;
[...]

Solution, as pointed in the post before, is changing the append by a prepend. I'll send a PR.


Right bracket missing in code provided by tensorflow tutorial

This template is for miscellaneous issues not covered by the other issue categories.
For questions on how to work with TensorFlow, or support for problems that are not verified bugs in TensorFlow, please go to StackOverflow.
If you are reporting a vulnerability, please use the dedicated reporting process.
For high-level discussions about TensorFlow, please post to<EMAIL_ADDRESS>for questions about the development or internal workings of TensorFlow, or if you would like to know how to contribute to TensorFlow, please post to<EMAIL_ADDRESS>I believe that a right bracket is missing at the end of following code segment
plt.xlabel("{} {:2.0f}% ({})".format(class_names[predicted_label],
                                100*np.max(predictions_array),
                                class_names[true_label]),
                                color=color)

in part Prediction.
And the turtorial link is https://www.tensorflow.org/tutorials/keras/basic_classification
Not a big deal.

I copied the tutorial code in an IDE and I think the code segment has balanced braces.