fix(LabelEditor): show admin-only checkbox to project admins

Checklist

[x] Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
[x] Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
[x] The description lists all applicable issues this PR seeks to resolve
[x] The description lists any configuration setting(s) that differ from the default settings
[x] All tests and CI builds passing

Description
Closes #705. Permissions for the admin-only checkbox were being determined incorrectly. Fixed by having it match the method used to show the edit/delete buttons, which is also the method used by the server.

Thanks all for reviewing! Assigning back to @landonreed to merge.


Allow more granular inclusion of extensions files

For example a user could need to include only the rails_helper with its own
spec_helper. This allows doing that with:
require 'spec_helper'
require 'solidus_support/extension/rails_helper.rb'

It can be more verbose if this is not needed since to fully load the feature_helper it will need:
require 'solidus_support/extension/spec_helper.rb'
require 'solidus_support/extension/rails_helper.rb'
require 'solidus_support/extension/feature_helper.rb'

Also, this will help if we add more helpers, like requests_helpers of others. WDYT?

I like that.
We could add a new file that includes all of these files at once:
require 'solidus_support/testing/setup'

Oh, and can we rename that folder? extension doesn't sound like something related to tests.
require 'solidus_support/testing/spec_helper'
require 'solidus_support/testing/rails_helper'
require 'solidus_support/testing/feature_helper'

@tvdeyen done! Moved all support files into testing and I've called the file that includes all of them testing/all, does it work?

The docs are great, but I believe it's a standard pattern for rails_helper to require spec_helper. It doesn't make sense to require one without the other.

yes but I could want to include a custom spec_helper and not the one provided by this extension, right?

Making a small recap:
These support files are loaded into extensions to have a standard set of RSpec configuration.
We load those files into the extension's spec/spec_helper.rb file.
If the extension has features spec it is convenient to make:
require 'solidus_support/extension/feature_helper'

which currently also loads extension/rails_helper which loads extension/spec_helper.
If the extension does not have features specs we can just make:
require 'solidus_support/extension/rails_helper'

And it will load test config without features ones.
My concern was more if for example an extension needs the features_helper but with something different from what is provided here inside the rails_helper. For example it doesn't need to load preferences or factories.
Anyway, if this is not a real usage scenario, I'll be happy to change the PR in order to just add documentation.

I think what we have right now works good enough. @kennyadsl do you still insist in the change or can we close this for good?

Yes, we can close this one if we are ok with current version. I'll try to port documentation for current implementation if needed. Thanks both for your feedback.


Avoid Wall Clipping

There should be an Effect that raycasts from its local origin in a given vector and positions itself at the hit position (or the given vector if nothing was hit).
This would allow for cameras that maintain a specific distance from a target position without clipping through a wall.

There's built in SpringArm node which does exactly that. However, combining it with Orbiter effect is difficult.
I think node which would take 2 nodepaths as exports (from, to) would make for most flexible solution.


Cursor goes away after typing

Hi, am i missing something here? My cursor goes away after entering a prompt, forcing a click back into the message field to type again. Is this intended?
macos
before typing

after hitting enter, text cursor disappears.

Yes, even me facing the issue.

I am also having this issue.

Duplicate of #67


Clarify DSL use in README

The conversation in #123 raised a good point: not all view controllers, particularly those that are child view controllers, have a title. Clarify this in the README and suggest and alternative approach.

:+1:


Local pull request success status testing

Docs Build status updates of commit 8c1a486:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

E2E_DocsBranch_Dynamic/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


README Enhancement - Cats vs Dogs Audio Classification using DL

Deep Learning Simplified Repository (Proposing new issue)
:red_circle: Project Title : README Enhancement - Cats vs Dogs Audio Classification using DL
:red_circle: Aim : The aim is to enhance the README file and make it eye pleasing, well documented using the given README template.
:red_circle: README to be enhanced : https://github.com/abhisheks008/DL-Simplified/blob/main/Cats vs Dogs Audio Classification using DL/README.md
:red_circle: README Template : https://github.com/abhisheks008/DL-Simplified/blob/main/.github/readme_template.md

:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Follow Contributing Guidelines & Code of Conduct before start Contributing.

:white_check_mark: To be Mentioned while taking the issue :

Full name :
GitHub Profile Link :
Email ID :
Participant ID (if applicable):
Approach for this Project :
What is your participant role? (Mention the Open Source program)

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

Hi @abhisheks008 ,
I'd like to work on this issue.
Full name : JEBA RACHEL NESICA
GitHub Profile Link : https://github.com/Jeba-Rachel-Nesica
Email ID<EMAIL_ADDRESS>Participant ID (if applicable):
Approach for this Project : Conduct a thorough review of the current documentation and code comments to rectify any typographical errors. Enhance the clarity and inclusivity of the documentation to ensure it is both user-friendly and informative. Elevate the README.md file within the Model/ folder by integrating comprehensive visualizations. Document all alterations meticulously and update.
What is your participant role? (Mention the Open Source program): GSSoC'24 Contributor

Hi @Jeba-Rachel-Nesica issue assigned to you.


Adding the quickstart sample links in the code snippets

A suggestion: In addition to download SDK links in the code snippets, that would be also great to offer a quick sample app to test how does this API and the SDK work. Quickstart samples are great when it comes to testing the SDKs. As a start, it would help to link the quick start url, so devs can go ahead, select their prefered language and download a quickstart sample: https://developer.microsoft.com/en-us/graph/quick-start
As a second step it would be much nicer to be able to download the related SDK quickstart sample directly from the code snippets.

Hi @aycabas , Thank you for the suggestion. This is definitely on our radar. We want to leverage the work that Jason and yourself are doing. As a first step, we need to have an effective design to ensure that the user is guided towards those tutorials.


Check whether nitro virtual code needs OS-independent newlines

Describe the feature
We use os-dependent newlines (\n) in two places in our module.ts:
https://github.com/sidebase/nuxt-auth/blob/912006f387b12183ad13f775bb3b5d84596bee81/src/module.ts#L78
https://github.com/sidebase/nuxt-auth/blob/912006f387b12183ad13f775bb3b5d84596bee81/src/module.ts#L130
We should figure out whether that's ok (e.g., whether nitro compiles it correctly) or whether we need to do a checking step to determine whether we need to use \n (*nix based) or \n\r (windows).
Additional information
No response

closing this for now, nobody has reported an issue with this yet + the original virtual imports do not exist any longer.


TBomb Request

Hello
I know you are a developer like me @darkestentropy ....
i hope that you analyzed the code and i am sure you can say that there is no malware hidden as @scpketer said
And you currently know the security concerns if it will be used without any limits
So i request you to kindly take it down
I know its an easy obfuscation as maintaining TBomb by adding new APIs became harder for me
So i did not much really care to obfuscate it more
Hope That You will understand
Any issues feel free to ping...

I'm not taking any active effort for distributing neither TBomb nor this sort of open-source variant of it.
Take it as an inspired work, because:

I do not include TBomb contents in this repo - check Makefile (lines 9-10).
I do not modify TBomb - script does not affect original files.

Issue will remain - I do my best not to take all the fame but credit you.

Thread is locked.
All further issues not related to implementation of this project will be deleted.

Takedown request rejected, project is no longer using new sources unless modified by end user.


Make PYTHON_BIN_PATH error go away

This also makes the logging a little less aggressive.
Fixes #9436
CC: @nlopezgi

So if I understand correctly, this defaults to /usr/bin/python when we can't find it from explicit configuration. But we don't check whether this actually points to a good python. So this seems more like a bandaid fix rather than getting at the root issue. Am I correct in that analysis? If so, should we at least put a comment in the code saying that this is a hack? I notice in the linked issue you said the root cause may be an upstream issue in bazel.

Yes this is a bandaid fix, because Bazel is currently broken.
@nlopezgi wrote this Python configuration tool, so I hope he will take ownership of creating a more optimal solution.

Can we open an issue against bazel and have a link in our code saying essentially "this is a hack, remove when bazelbuild/issues/4242 is resolved"?

Done.

Looking into a permanent fix for the issue. Apologies for the late reply.

Tried to repo this error by using standard Dockerfile.devel in https://github.com/tensorflow/tensorflow/blob/master/tensorflow/tools/docker/Dockerfile.devel (comment on https://github.com/tensorflow/tensorflow/issues/9436 indicates they could repro the issue with this setup, iiuc?). Was able to run the build successfully even after removing the default value set in https://github.com/tensorflow/tensorflow/blob/master/third_party/py/python_configure.bzl#L246. Ran build successfuly with both bazel 0.4.5 and 0.5.1. Do you have any pointers as to how to reliably repro this error so I can diagnose better. Thanks.


hooks with multiple results stop execution after first result

Hi, I noticed that if a hook contains multiple commands which are returning results, dbt stops execution once it gets the first result. It sometimes happens also when SQL returns some intermediate messages (like rowcount).
To reproduce it I created a useless script just to show that the execution stops right after EXEC sp_who2 and the following steps are not executed. It stops few milliseconds after first EXEC, that's why I added the WAITFOR DELAY.
{{
  config(
    pre_hook = "
       EXEC('DROP VIEW IF EXISTS test_bug_view')

       EXEC sp_who2 -- this returns a result and execution of the hook stops

       WAITFOR DELAY '00:00:04';
       EXEC('CREATE VIEW test_bug_view AS SELECT 1 as col')
       "
  )
}}
SELECT * FROM test_bug_view --this fails, because it wasn't created in the pre-hook

As a workaround, now I make sure that there are no intermediate results and it works. For example in EXEC using NO_OUTPUT
I'd be grateful if somebody can fix it :)

If you executes multiple statements, can you use multiple hooks? One for each statement.

If you executes multiple statements, can you use multiple hooks? One for each statement.

to @mikaelene 's point, pre_hook let's you pass a list of SQL statements. when I tried this, it works without issue!
{{
  config(
    pre_hook = [
        "EXEC('DROP VIEW IF EXISTS test_bug_view')",
        "EXEC sp_who2 -- this returns a result and execution of the hook stops",
        "WAITFOR DELAY '00:00:04';",
        "EXEC('CREATE VIEW test_bug_view AS SELECT 1 as col')"
       ]
  )
}}
SELECT * FROM test_bug_view --this fails, because it wasn't created in the pre-hook

to @mikaelene 's point, pre_hook let's you pass a list of SQL statements. when I tried this, it works without issue!
{{
  config(
    pre_hook = [
        "EXEC('DROP VIEW IF EXISTS test_bug_view')",
        "EXEC sp_who2 -- this returns a result and execution of the hook stops",
        "WAITFOR DELAY '00:00:04';",
        "EXEC('CREATE VIEW test_bug_view AS SELECT 1 as col')"
       ]
  )
}}
SELECT * FROM test_bug_view --this fails, because it wasn't created in the pre-hook

I think this is the intended behaviour. @dubravcik are you satisfied with this? Can I close this?

I think this is the intended behaviour. @dubravcik are you satisfied with this? Can I close this?

Yes I will use the list of SQL statements. Thanks @swanderz  @mikaelene !
I must say that it is unexpected behavior that it silently stops for somebody who doesn't know that it is intended. But it is like that in core dbt right?

Yes I will use the list of SQL statements. Thanks @swanderz  @mikaelene !
I must say that it is unexpected behavior that it silently stops for somebody who doesn't know that it is intended. But it is like that in core dbt right?

Yes I will use the list of SQL statements. Thanks @swanderz @mikaelene !
I must say that it is unexpected behavior that it silently stops for somebody who doesn't know that it is intended. But it is like that in core dbt right?

I don't know actually. I meant that if you want to use multiple statements you define them as multiple hooks. Intended usage  is maybe what I meant. The hooks is sent to the database with pyodbc. There is not much we can do about how it is executed. I guess that when dbt gets a result back it sees that statement as complete. dbt only sees that the sql is executed without error. If an error occur, it reports back.

Yes I will use the list of SQL statements. Thanks @swanderz @mikaelene !
I must say that it is unexpected behavior that it silently stops for somebody who doesn't know that it is intended. But it is like that in core dbt right?

I don't know actually. I meant that if you want to use multiple statements you define them as multiple hooks. Intended usage  is maybe what I meant. The hooks is sent to the database with pyodbc. There is not much we can do about how it is executed. I guess that when dbt gets a result back it sees that statement as complete. dbt only sees that the sql is executed without error. If an error occur, it reports back.


User defined type guard function and type any

Hi all!
interface A {
    prop: string
}

function isA(arg: any): arg is A {
    return "prop" in arg;
}

function handle(arg: any) {
    if (isA(arg)) {
        let b = arg.nonExistsProp; // no compile error here
    }
}

Why there is no compile error while acessing nonExistsProp? Is it by design and guard function only works with union types? Can't find some sort of specs, please, help me.

Type guards do not narrow any. The reasoning for this is that we want type guards to allow you to do more, not less. any can already do everything, so it doesn't "help" you to reduce its domain.
More specifically, we actually did try it the other way. The initial version of type guards did narrow on any; what we found is that a lot people had code like this:
// By contract, this function accepts only a Dog or a House
function fn(x: any) {
  // For whatever reason, user is checking against a base class rather
  // than the most-specific class. Happens a lot with e.g. HTMLElement
  if (x instanceof Animal) {
    x.woof(); // Disallowed if x: Animal
  } else {
    // handle House case
  }
}

At the expense of being pedantic, this isn't entirely true. instanceof and user-defined type guards do not perform narrowing. typeof type guards do because we know exactly what type a value has.
let x: any;

if (typeof x === "number") {
    // 'x' has type 'number' here.
    let y = x * x;
}

@RyanCavanaugh what bothers me that the design team up for encouraging bad habits, this is wrong, please stop, you cannot follow the flow even if everyone is flows with it, you should make what's right, not what's everyone is doing

+1 on changing the behavior to narrowing the type.
With respect to prior user behavior, I don't think it's something to be encouraged, but if it is widespread, it's because instanceof existed prior to typeguards being introduced. For user-defined typeguards however, that's not the case. If I define a function with the signature (arg: any) => arg is A, there's zero ambiguity that the user intends for any type to be narrowed to A.
Alternatively, maybe there could be some sort of syntax where the user can explicitly indicate intent to narrow? E.g. isA(arg: any) => arg isOnly A?

I'm serious about the number of breakages we found in real-world code. It was very large, and feedback from people trying early builds said they didn't want this.
It's so far been basically impossible to get a type error on a value of type any and there would need to be a stronger justification other than "You should be stricter on people" when the entire point of the any type is to be as unstrict as possible.
On the one hand, listen to users, and on the other hand, listen to users...

Don't see a contradiction. Let any be the most unrestricted thing in the world. No problem. But when someone does if (anything is Potato) { eatSteak(anything); } they expect a compiler error, any won't give it to them, so they don't want any, they want a shaped value. So the strictness is welcome here, it's a good thing, why would anyone be pissed by it.

What you've written there is runtime-invalid code. The point is that there's lots of runtime-valid code that also issues a type error if we narrow any

Let's not use word strictness or narrowing for a second. Type guard is a predicate that asserts at run time that a given value is of certain type. Ultimately one can put anything in it and it would say yes or no. Once it said yes you get a guarantee (up to the implementation of the type guard) that a value is of that type. Am I right so far? If so, then your example with the woof method must break. We asserted that a value is of type Animal. Animals don't woof, dogs do. It's not a runtime valid code, because if I put a cat in that function and it will crash regradless of what the author thought the contract is. There is no such thing as a contract in JavaScript, there are only our best assumptions and hopefully a test that verifies them. So I am not sure why we are into giving the developers an illusion that they know what they are doing. I see your point that there are a lot of naive people who already written tons of crappy code, well this is TypeScript for goodness sake, time to grow up.

I am not trying to convince you. Just ranting. I get it that the design goal is to make a mainstream language that fits the least competent developer. It is indeed very frustrating that correctness isn't the goal. I get that too. There is already quite a number of features that I wish didn't exist at all, we one more one less doesn't make a difference. Hopefully the niche for a correct/sound counterpart of TypeScript will be filled soon.


Changes to Chrome have stopped the Chrome extension from working

This change has recently rolled out. Extension icons are now all shown together, no longer in the address bar.
Sadly this seems to have broken the phpconsole extension - I no longer receive notifications on debug, error etc.

Disregard please - external factors regarding another affected extension causing the notifications not to show


DDLS skip generated SADL classes

In https://github.com/jasper07/Teched17 2 clases are automatically generated by SADL, the generated classes should be skipped by abapGit
Example: ZCL_ZC_TE_FLIGHT

I couldn't find anything on the VSEOCLASS view (class metadata) that indicates that a class was generated. One option is to check if the class inherits from CL_SADL_GTK_EXPOSURE_MPC and skip it.
Any other options?

my guess is that there some where deep down in the SADL code is a table containing the names of the generated classes, ie. when changing the CDS I guess it has to regenerate the class

Yes. You are probably right :)
In method CL_SADL_GTK_MPC_GEN=>_generate_class if you go to cl_sadl_transport_adapter=>get_instance( )->set_gen_flag, it marks a gen_flag in the TADIR

Something like this, skip if

Exists DDLS with name ZCL_{ ddls_name }
Class has TADIR-GENFLAG = abap_true
and inherits from CL_SADL_GTK_EXPOSURE_MPC
will it work?


Pipelines as code issue with webhook_secret and GitLab

I have Pipelines as code configured and working without webhook_secret.
When I add a webhook_secret in the repository configuration, it stops working.
repository
spec:
  git_provider:
    secret:
      key: provider.token
      name: gitops-webhook-config
    webhook_secret:
      key: webhook.secret
      name: gitops-webhook-config

secret
kind: Secret
apiVersion: v1
metadata:
  name: gitops-webhook-config
  namespace: ci-runner
data:
  provider.token: aaaaa=
  webhook.secret: bbbbbb==

I have tried both webhook.secret being base64 encoded and not being encoded. No success either way.
In GitLab I have populated the field "Secret token". I have also checked by making the call to an httpecho server that the X-Gitlab-Token header is properly populated. I also tried both base64 encoded and not. With not base64 encoded I tested against both webhook.secret encoded and not.
I tested with the latest stable version: ghcr.io/openshift-pipelines/pipelines-as-code:stable
Error (same in all cases):
{"severity":"INFO","timestamp":"2022-05-10T11:45:12.094076159Z","logger":"pipelinesascode","caller":"pipelineascode/secret.go:80","message":"Using git provider : apiurl=https://gitlab.com user= token-secret=gitops-webhook-config token-key=provider.token webhook-secret=gitops-webhook-config webhook-key=webhook.secret","provider":"gitlab","event":""}
{"severity":"ERROR","timestamp":"2022-05-10T11:45:12.094149463Z","logger":"pipelinesascode","caller":"pipelineascode/pipelineascode.go:53","message":"Cannot create status: could not validate payload, check your webhook secret?: gitlab failed validaton: event's secret doesn't match with webhook secret no gitlab client has been initiliazed, exiting... (hint: did you forget setting a secret on your repo?)","provider":"gitlab","event":"","stacktrace":"github.com/openshift-pipelines/pipelines-as-code/pkg/pipelineascode.(*PacRun).Run\n\t/src/pkg/pipelineascode/pipelineascode.go:53\ngithub.com/openshift-pipelines/pipelines-as-code/pkg/adapter.(*sinker).processEvent\n\t/src/pkg/adapter/sinker.go:37\ngithub.com/openshift-pipelines/pipelines-as-code/pkg/adapter.listener.handleEvent.func1.1\n\t/src/pkg/adapter/adapter.go:129"}

Thanks for the detailed bug report, this is weird since we do have our e2e tests testing for it and gitlab is the most simple one   since it's a simple string comparison (actually we just have a fix for it #659 to not be that "simple").
If I give you a "debug" image is there any chance you can use it inside the controller so to see what are the secret pac sees?

great thanks: 🙏🏻
if you can edit the controller with :
% kubectl edit deployments.apps -n pipelines-as-code pipelines-as-code-controller

and switch the image with :
quay.io/chmouel/pipelines-as-code-controller:latest
which has this debug patch:
--- a/pkg/provider/gitlab/gitlab.go
+++ b/pkg/provider/gitlab/gitlab.go
@@ -55,6 +55,10 @@ func (v *Provider) Validate(_ context.Context, _ *params.Run, event *info.Event)
                return fmt.Errorf("gitlab failed validaton: failed to find webhook secret")
        }

+       v.Logger.Infof("Token Received from gitlab: %+v", token)
+       v.Logger.Infof("Token Set by user: %+v", event.Provider.WebhookSecret)
+       v.Logger.Infof("More fun debug: %+v", event.Provider)
+
        if subtle.ConstantTimeCompare([]byte(event.Provider.WebhookSecret), []byte(token)) == 0 {
                return fmt.Errorf("gitlab failed validaton: event's secret doesn't match with webhook secret")
        }

Ah sorry about that, I made it public now

On 10 May 2022, at 17:19, Frederic Giloux @.***> wrote:
@chmouel https://github.com/chmouel it seems that quay.io/chmouel/pipelines-as-code-controller:latest is not public
—
Reply to this email directly, view it on GitHub https://github.com/openshift-pipelines/pipelines-as-code/issues/658#issuecomment-1122535298, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAYFJDJD3QPCC76FUVKRSDVJJ5BXANCNFSM5VRLRDCA.
You are receiving this because you were mentioned.

There is a new line character added to the value from the secret:
aaaaaaaaaaaaaaa
vs
aaaaaaaaaaaaaaa\n

This is weird, we def don’t do anything with the secret, and the secret you showed in yaml doesn’t seem to have newlines
What about using stringData in the secret instead of base64 encoded?
Make sure to encode with "echo -n secret|base64 —encode “  (on gnu, it’s just base64  on osx)

On 10 May 2022, at 20:10, Frederic Giloux @.***> wrote:
There is a new line character added to the value from the secret:
aaaaaaaaaaaaaaa
vs
aaaaaaaaaaaaaaa\n
—
Reply to this email directly, view it on GitHub https://github.com/openshift-pipelines/pipelines-as-code/issues/658#issuecomment-1122713396, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAYFJDQAXOSYYXDNO2GSPDVJKRCTANCNFSM5VRLRDCA.
You are receiving this because you were mentioned.

on another note, nightly tkn-pac should now be able to help the user creating this webhook and set the secret using the "tkn pac repo create" command, cf: https://nightly.pipelines-as-code.pages.dev/docs/install/gitlab/#repository-creation

"echo -n" did the trick. I thought I had removed the new line through the web console but clearly not. Thanks for your help and sorry for the inconvenience.


[graphiql] Grafana Embedded GraphiQL Editor CodeMirror info tooltips links navigate away from page

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
When embedding a GraphiQLInterface inside of a Grafana query editor, any link to a part of the documentation will instead take the user to http://localhost:3000/javascript:void%200, rather than actually executing whatever JavaScript is supposed to execute.
Screenshot to show what I mean by "info tooltip" - the div at the bottom of the inspect window pops up and I don't really have a way to debug it because when I stop hovering, it disappears.

Expected Behavior
The links in the tooltip should open up the documentation, rather than navigate away from the current page.
Steps To Reproduce
I don't exactly know how to ask others to reproduce this since I have such a unique setup. I mostly would just like pointers on how to debug this myself. If anyone is willing to debug this:

Clone https://github.com/wildmountainfarms/wild-graphql-datasource/tree/6f2557995f59e4cb64d65427247522d753528b3b
npm run dev
mage -v build:linux && npm run server
Open http://localhost:3000
Navigate to the Star Wars Film Info dashboard
Edit one of the panels
In the GraphiQL editor, hover over one of the fields in the query to make a tooltip pop up
Click either the name of the field or the type of the field
You are then navigated to http://localhost:3000/javascript:void 0

Environment

GraphiQL Version: 3.1.0
OS: Pop!_OS 22.04
Browser: Firefox 123.0.1
Bundler: webpack 5.86.0
react Version: 18.2.0
graphql Version: 16.8.1

Anything else?
This issue is a weird one to reproduce, but I would appreciate any guidance in to why this might be happening. Embedding GraphiQL into Grafana is likely something that hasn't been done before, and Grafana itself uses a fair bit of React code, so my guess is that something is conflicting with GraphiQL in a way no one expected.
I would appreciate any guidance to get this fixed, as if you navigate away, you lose whatever progress you have made while editing the dashboard.

yeah that looks like something very Grafana specific! it looks like the browser native behavior where it shows the full url when hovering a link, but I'm guessing grafana adds that?
it could also be that grafana has added something like DOMPurify to filter all URLs for all plugins, thus the unexpected serialization?

After some more debugging, I found the piece of code responsible for this and confirmed that this behavior happens for other "go nowhere a tags" in Grafana.
First the piece of code responsible for this bug: https://github.com/graphql/graphiql/blob/9ef55ab745fd51cd654f2406eff117dae298f416/packages/codemirror-graphql/src/info.ts#L300
I created a bug report as linked above and it turns out, if you were to put an element such as lol anywhere on a Grafana page, it would navigate you away from the page.
Now, this is obviously a bug in Grafana, but it's worth mentioning that making href equal to javascript:void 0 is probably not the best solution. There's some discussion here: https://stackoverflow.com/a/1830934/5434860
This issue is probably able to be closed, but I would like to see if anyone had any thoughts on if using javascript: void 0 as an href is something GraphiQL should even be doing in the first place.

I tracked down this addition to https://github.com/graphql/graphiql/commit/02a8ec91deba75fbed6d52196697ff91dc8fc49a#diff-ed168189151bacb4f4f21b037ea4aeb8980fbc53a03aa6ba921f1e9f23fcdef0R167 or this: https://github.com/graphql/graphiql/blob/02a8ec91deba75fbed6d52196697ff91dc8fc49a/src/info.js#L167
This was authored by @leebyron, so I was wondering if you had any insight on this?

I got #3567 created to fix this issue. It was a pretty simple fix that shouldn't cause any problems. I tested to confirm it works in Grafana, but other than that the testing I did was pretty limited.


[FEATURE][001] Inject CSV data into Feature files on the same folder

 [FEATURE][001] Inject CSV data into Feature files on the same folder


Wrong Text: "Screenshot to" should be removed

Under Heading: "List work items added after the start of the sprint"
No 1: Screenshot to Open the velocity chart
"Screenshot to" should be removed

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: bcb22f37-3dc2-e54c-13c5-a2753901fad4
Version Independent ID: a39daaa2-8d90-8bab-833e-6106b3939b4b
Content: Implement Scrum work practices in Azure Boards - Azure Boards
Content Source: docs/boards/sprints/scrum-overview.md
Service: azure-devops-boards
GitHub Login: @chcomley
Microsoft Alias: chcomley

@horazius77 -- Daniel, thank you for catching this.  I am updating the article.

@horazius77 -- Daniel, thank you for your feedback.  I have updated the documentation and it should be live by tomorrow.


tenant creatin valildation with ID

tenant created by the unit tests had a different id than the expected one.
This was due to the validator of the create tenant endpoint.

@Ninjeneer : I did some tests ... regular tenant creation still works properly when done by a super admin.
Do you see any reason why the "tenant creation endpoint" should not accept the ID as input?
Thanks,
Claude

uttest tenants have now the expected ID.

@Ninjeneer : I did some tests ... regular tenant creation still works properly when done by a super admin.
Do you see any reason why the "tenant creation endpoint" should not accept the ID as input?

You should have an error message returned : either in the body of the response, either in your super-tenant logs. You can also check by adding a breakpoint on the throw instruction in SchemaValidator.ts and inspect the 'errors' variable
First of all, is the id passed in the test formatted as a 24 characters long hexadecimal number ?


Make up and down fields public to appease rust-analyzer

Not strictly necessary, but fixes the weird RA message in #30

Thanks!


Builder with EVMJIT enabled should run JIT tests

test-cpp step is a command testeth. To test JIT it should be testeth --jit. It can be added as another step (better) or test-cpp step can be modified.

Something went wrong with that: the command is now ./testeth -t 'devcrypto,jsonrpc,Solidity*,whisper,jit', should be ./testeth -t 'devcrypto,jsonrpc,Solidity*,whisper' --jit.

Fixed in 39fb6a0, thanks!


do not warn about out-of-date Flutter installation too often

Fixes #9243

@johnmccutchan may wish to review also


Job fails bsdtar command

Hi,
in my repository and branch: https://github.com/mlajtos/mosaic/pull/5/files
The Windows and Mac builds are ok, but Linux fails this way:
  ⨯ cannot execute  cause=exit status 1
                    out={:timestamp=>"2020-08-12T09:13:45.777839+0000", :message=>"Process failed: /bin/sh failed (exit code 127). Full command was:[\"/bin/sh\", \"-c\", \"LANG=C bsdtar -czf .MTREE --format=mtree --options='!all,use-set,type,uid,gid,mode,time,size,md5,sha256,link' opt usr .PKGINFO .INSTALL\"]", :level=>:error}

                    command=/home/runner/.cache/electron-builder/fpm/fpm-1.9.3-2.3.1-linux-x86_64/fpm -s dir --force -t pacman -d c-ares -d ffmpeg -d gtk3 -d http-parser -d libevent -d libvpx -d libxslt -d libxss -d minizip -d nss -d re2 -d snappy -d libnotify -d libappindicator-gtk3 --pacman-compression xz --architecture amd64 --name mosaic-browser --after-install /tmp/t-GfXFMS/4-after-install --after-remove /tmp/t-GfXFMS/5-after-remove --description 'Web browser that can display multiple web pages at the same time in one shared window.
     Web browser that can display multiple web pages at the same time in one shared window.' --version 0.0.1 --package /home/runner/work/mosaic/mosaic/dist/mosaic-browser-0.0.1.pacman --maintainer 'Milan Lajtoš<EMAIL_ADDRESS>--url https://github.com/michalklempa/mosaic --vendor 'Milan Lajtoš<EMAIL_ADDRESS>--license MIT /home/runner/work/mosaic/mosaic/dist/linux-unpacked/=/opt/Mosaic /home/runner/work/mosaic/mosaic/build/icon.png=/usr/share/icons/hicolor/0x0/apps/mosaic.png /tmp/t-GfXFMS/9-Mosaic.desktop=/usr/share/applications/mosaic.desktop
                    workingDir=
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
/home/runner/work/_actions/samuelmeuli/action-electron-builder/v1/index.js:144
				throw err;
				^

Error: Command failed: yarn run electron-builder --linux
    at checkExecSyncError (child_process.js:621:11)
    at execSync (child_process.js:657:15)
    at run (/home/runner/work/_actions/samuelmeuli/action-electron-builder/v1/index.js:21:27)
    at runAction (/home/runner/work/_actions/samuelmeuli/action-electron-builder/v1/index.js:132:4)
    at Object.<anonymous> (/home/runner/work/_actions/samuelmeuli/action-electron-builder/v1/index.js:150:1)
    at Module._compile (internal/modules/cjs/loader.js:959:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:995:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Function.Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module.runMain (internal/modules/cjs/loader.js:1047:10) {
  status: 1,
  signal: null,
  output: [ null, null, null ],
  pid: 2427,
  stdout: null,
  stderr: null
}

Any idea what might happen? I do not see stdout/err from the sh and bsdtar commands to investigate.

I was getting a similar error, but after checking a little closer, I was trying to build pacman packages but with the current runner, it seems that GitHub changed the default runner to Ubuntu 20.04 a few months ago https://github.blog/changelog/2020-10-29-github-actions-ubuntu-latest-workflows-will-use-ubuntu-20-04/
This is causing some errors related with the missing binary bsdtar used by the pacman builder. I found this workaround https://github.com/electron-userland/electron-builder/issues/4181 . Just install libarchive-tools for the runner.
I made this using an additional step at the beginning:
      - name: Install libarchive-tools for pacman build # Related https://github.com/electron-userland/electron-builder/issues/4181
        if: startsWith(matrix.os, 'ubuntu')
        run: sudo apt-get install libarchive-tools

You can check my full workflow here: https://github.com/julian-alarcon/prospect-mail/blob/develop/.github/workflows/release.yml#L31
It seems that we are not the only one with similar issues:
https://github.com/hashicorp/vagrant/issues/12038
https://github.com/intel/lkp-tests/issues/50


Add tab completion user guide

Windows version will support tab completion on PowerShell, add user guide.
PR: https://github.com/Azure/azure-cli/pull/24752

@bebound, can this draft be closed?  This looks like a working draft that was replaced by PR 3648


wallet error with 2fa without seed

wallet error with 2fa without seed
I have wallet 2.9.3 with 2fa
at the time of creating it
for some reason
I do not generate the seed
created on November 10
buy 0.31 BCC
now I can not spend them
the cash is withheld
and I can not reset because I do not have seed
please help me
I need to pay something

You can try to post the question on #41 which is where we look at all 2fa related issues.  If you don't have the seed it may be a problem.  You should always always have your seed


Create color-to-hex-argb-string-converter.md

Documentacion de ColorToHexRgbaStringConverter

@microsoft-github-policy-service agree

I've just marked this as Draft so it doesn't get accidentally merged until we release the new converter


sys/linux: add NDISC packet formats to vnet.txt

Add the basic NDISC (RFC 4861) packet formats to sys/linux/vnet.txt.

Hi Dan,
While I am looking at the actual descriptions, you also need to generate *.const files, please see:
https://github.com/google/syzkaller/blob/master/docs/syscall_descriptions.md
In short:
make install_prerequisites
make extract SOURCEDIR=~/linux-next/checkout
make generate

and then add all changed files to this PR.

@dvyukov thanks! Formatting etc now

There is a problem with go fmt -- it changed format in between 1.10 and 1.11 (https://github.com/golang/go/issues/25161) which creates problems.
We currently use format as produced by Go 1.9 and 1.10. You seems to use 1.11. I will reformat it now, but please use version 1.10 next time, for details see:
https://github.com/google/syzkaller/blob/master/docs/contributing.md#how-to-create-a-pull-request

:+1: yeah Gentoo uses 1.11.5.


Missing a small step

Hi team,
I moved this from here: https://github.com/MicrosoftDocs/sql-docs.zh-tw/issues/113
The user is making a suggestion to add a step to the documentation
The comment below was machine translation
@lovepm860524 commented 19 days ago — with docs.microsoft.com
"Judge the Database Engine to execute the name of the individual" block,
4. ...right-click [Local Server Group], point to [Work], and then click [Register Local Server]. All Database Engine executions installed on your computer are displayed. ...
The middle of the line should be added to the "Expanding the local server group".

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3c35290b-b676-c52d-4204-ada11a3bb2af
Version Independent ID: 87264101-997a-d17a-c96a-7a2cf15689e1
Content: Lesson 1: Connecting to the Database Engine - SQL Server
Content Source: docs/relational-databases/lesson-1-connecting-to-the-database-engine.md
Product: sql
GitHub Login: @MashaMSFT
Microsoft Alias: mathoma

Hi @lovepm860524, thank you so much for your feedback! I modified the text a bit to highlight expanding the security group as suggested. Thank  you so much for making our docs better! This change will be live later today.
Is there anything else we can assist you with? If not, we will proceed with closing out this Git Issue in a few business days.
Thanks!
Masha from the SQL Docs team


Fix 'Deprovision' in base images' pipelines

Currently the 'Deprovision' step fails to execute in both twas-nd and ihs base image pipelines.
@git4rk Can you please assign this issue to me?

PR: https://github.com/WASdev/azure.websphere-traditional.image/pull/41

Close the issue since the PR is merged


build fail with bosio.cdt

built and installed latest bosio.cdt
clone bos/contracts, do cmake and make.
some error happened, it's literally the same with https://github.com/EOSIO/eosio.contracts/issues/180, and its solution works.
please fix it if possible. thanks.

you can use master branch to build,maybe   solve

try run follow commands first, then compile as normal
$ git submodule deinit --all -f
$ git submodule update --init --recursive
then ensure the out of $ git state is clean

try run follow commands first, then compile as normal
$ git submodule deinit --all -f
$ git submodule update --init --recursive
then ensure the out of $ git state is clean
is your os  ubuntu or centos?maybe use blow option

git checkout v2.0.1
git submodule update --init --recursive
./build.sh

maybe you can use docker image ,https://github.com/boscore/bos.cdt/blob/v2.0.2/docker/README.md

try run follow commands first, then compile as normal
$ git submodule deinit --all -f
$ git submodule update --init --recursive
then ensure the out of $ git state is clean

Thanks @vonhenry ,this works!


bug: build failed while following the step of Getting Started

Bug Report
Madara version:
the last commit id 271287e6e4d429fbbc40a61d45ad9d334699776f
Current behavior:
build failed
Expected behavior:
build successfully without any errors.
Steps to reproduce:
clone the repository and then do as the following step of Getting Started
Related code:
Microsoft Windows [版本 10.0.19045.4412]
(c) Microsoft Corporation。保留所有权利。
C:\Windows\system32>cd d:\code\madara
C:\Windows\system32>cargo run --release -- setup --chain=dev --from-remote
error: could not find Cargo.toml in C:\Windows\system32 or any parent directory
C:\Windows\system32>cd /d d:\code\madara
d:\code\madara>cargo run --release -- setup --chain=dev --from-remote
Compiling zstd v0.11.2+zstd.1.5.2
Compiling sct v0.7.1
Compiling multihash v0.17.0
Compiling zstd v0.12.4
Compiling wasmtime-cache v8.0.1
Compiling sp-maybe-compressed-blob v4.1.0-dev (https://github.com/massalabs/polkadot-sdk?branch=release-polkadot-v1.3.0-std#a41673f8)
Compiling soketto v0.7.1
Compiling webpki v0.22.4
Compiling multiaddr v0.17.1
Compiling snow v0.9.4
Compiling wasmtime v8.0.1
Compiling starknet-core v0.10.0 (https://github.com/xJonathanLEI/starknet-rs.git?rev=2d59636911628260fa460179010bbd00e89de06e#2d596369)
Compiling rustls v0.20.9
Compiling webpki-roots v0.22.6
Compiling rustls-webpki v0.101.7
Compiling libp2p-identity v0.1.3
Compiling libp2p-core v0.39.2
Compiling rustls v0.21.9
Compiling jsonrpsee-core v0.16.3
Compiling libp2p-swarm v0.42.2
Compiling libp2p-wasm-ext v0.39.0
Compiling libp2p-noise v0.42.2
Compiling futures-rustls v0.22.2
Compiling libp2p-yamux v0.43.1
Compiling sp-wasm-interface v14.0.0 (https://github.com/massalabs/polkadot-sdk?branch=release-polkadot-v1.3.0-std#a41673f8)
Compiling libp2p-websocket v0.41.0
Compiling libp2p-tcp v0.39.0
Compiling libp2p-kad v0.43.3
Compiling libp2p-request-response v0.24.1
Compiling libp2p-connection-limits v0.1.0
Compiling libp2p-ping v0.42.0
Compiling libp2p-allow-block-list v0.1.1
Compiling libp2p-identify v0.42.2
Compiling libp2p-mdns v0.43.1
Compiling libp2p-dns v0.39.0
Compiling libp2p v0.51.4
Compiling tokio-rustls v0.24.1
Compiling hyper-rustls v0.24.2
Compiling sc-telemetry v4.0.0-dev (https://github.com/massalabs/polkadot-sdk?branch=release-polkadot-v1.3.0-std#a41673f8)
Compiling reqwest v0.11.22
Compiling jsonrpsee-server v0.16.3
Compiling sp-runtime-interface v17.0.0 (https://github.com/massalabs/polkadot-sdk?branch=release-polkadot-v1.3.0-std#a41673f8)
Compiling jsonrpsee v0.16.3
Compiling librocksdb-sys v0.11.0+8.1.1
Compiling const-hex v1.10.0
error: failed to run custom build command for librocksdb-sys v0.11.0+8.1.1
Caused by:
process didn't exit successfully: d:\code\madara\target\release\build\librocksdb-sys-a25416330447ace7\build-script-build (exit code: 101)
--- stderr
thread 'main' panicked at C:\Users\Win10.cargo\registry\src\index.crates.io-6f17d22bba15001f\bindgen-0.65.1\lib.rs:603:31:
Unable to find libclang: "couldn't find any valid shared libraries matching: ['clang.dll', 'libclang.dll'], set the LIBCLANG_PATH environment variable to a path where one of these files can be found (invalid: [])"
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
d:\code\madara>
cargo run --release -- setup --chain=dev --from-remote

Other information:
Compiling pest_generator v2.7.5                                                                                error: failed to run custom build command for sc-network-sync v0.10.0-dev (https://github.com/massalabs/polkadot-sdk?branch=release-polkadot-v1.3.0-std#a41673f8)                                                                                Caused by:                                                                                process didn't exit successfully: d:\code\madara\target\release\build\sc-network-sync-2f2093dee951a4f5\build-script-build (exit code: 101)                                                                                --- stderr                                                                                thread 'main' panicked at C:\Users\Win10.cargo\git\checkouts\polkadot-sdk-3672e12173abcafd\a41673f\substrate\client\network\sync\build.rs:22:58:                                                                                called Result::unwrap() on an Err value: Custom { kind: Other, error: "protoc failed: Missing value for flag: --include_source_info\r\n" }                                                                                note: run with RUST_BACKTRACE=1 environment variable to display a backtrace                                                                                warning: build failed, waiting for other jobs to finish...                                                                                error: failed to run custom build command for sc-network-light v0.10.0-dev (https://github.com/massalabs/polkadot-sdk?branch=release-polkadot-v1.3.0-std#a41673f8)                                                                                Caused by:                                                                                process didn't exit successfully: d:\code\madara\target\release\build\sc-network-light-793a6d4f22904886\build-script-build (exit code: 101)                                                                                --- stderr                                                                                thread 'main' panicked at C:\Users\Win10.cargo\git\checkouts\polkadot-sdk-3672e12173abcafd\a41673f\substrate\client\network\light\build.rs:22:58:                                                                                called Result::unwrap() on an Err value: Custom { kind: Other, error: "protoc failed: Missing value for flag: --include_source_info\r\n" }                                                                                note: run with RUST_BACKTRACE=1 environment variable to display a backtrace                                                                                error: failed to run custom build command for sc-network-bitswap v0.10.0-dev (https://github.com/massalabs/polkadot-sdk?branch=release-polkadot-v1.3.0-std#a41673f8)                                                                                Caused by:                                                                                process didn't exit successfully: d:\code\madara\target\release\build\sc-network-bitswap-f6dcdbe8202b9dfc\build-script-build (exit code: 101)                                                                                --- stderr                                                                                thread 'main' panicked at C:\Users\Win10.cargo\git\checkouts\polkadot-sdk-3672e12173abcafd\a41673f\substrate\client\network\bitswap\build.rs:22:58:                                                                                called Result::unwrap() on an Err value: Custom { kind: Other, error: "protoc failed: Missing value for flag: --include_source_info\r\n" }                                                                                note: run with RUST_BACKTRACE=1 environment variable to display a backtrace                                                                                ^C  Building [===================>   ] 1243/1372: ethers-contract
another error

Have you tried running this within windows linux subsystem?

Have you tried running this within windows linux subsystem?
No, is that should running under windows linux subsystem?

I executed the cmd in windows' cmdline,. With following the error message, I installed the libclang.dll. then builded it. There's another error said "cann't find the protoc", I setted PROTOC env. finallly the build was successful. is the error occurred during the process is expected?

repository archived in favor of https://github.com/madara-alliance/madara


Modify system time, causing CPU to rise

VSCode Version: 1.25.1
OS Version: win10 Pro

Steps to Reproduce:

open Vscode

Modify system time

Wait for a few seconds

The CPU occupancy began to rise

Does this issue occur when all extensions are disabled?: Yes

Not repeating

What process is consuming the CPU? You can open the Process Explorer through the Command Palette to see which one it is.

/needsMoreInfo

@BlackHole1 thanks for the screenshot. Can you please also add one using the VS Code Process Explorer. F1 > Developer: Open Process Explorer.

@SpectralKH Is it normal after restart?

@BlackHole1 I didn't restart, I just updated to VSC 1.16.1

I already use webstorm, thank you very much for your reply, I will close this question


Yarn install fails

Description
Yarn install fails to install. No node_modules directory is created so the postinstall fails. Not sure where the actual bug is.
Expected Result
Expect the install to work
Actual Result
Install doesn't work
Reproduction
Not sure what to do here.
Additional context
➤ YN0032: │ utf-8-validate@npm:5.0.5: Implicit dependencies on node-gyp are discouraged
➤ YN0002: │ @chakra-ui/accordion@npm:1.3.2 [0bf55] doesn't provide framer-motion (p76a49), requested by @chakra-ui/transition
➤ YN0002: │ @chakra-ui/skeleton@npm:1.1.14 [0bf55] doesn't provide @chakra-ui/theme (pabac2), requested by @chakra-ui/media-query
➤ YN0002: │ @chakra-ui/skeleton@npm:1.1.14 [0bf55] doesn't provide @emotion/react (pab30a), requested by @chakra-ui/system
➤ YN0002: │ @chakra-ui/skeleton@npm:1.1.14 [0bf55] doesn't provide @emotion/styled (pa938d), requested by @chakra-ui/system
➤ YN0002: │ @chakra-ui/switch@npm:1.2.5 [0bf55] doesn't provide framer-motion (p23e33), requested by @chakra-ui/checkbox
➤ YN0002: │ @endemolshinegroup/cosmiconfig-typescript-loader@npm:3.0.2 [d8344] doesn't provide typescript (p6a0d6), requested by ts-node
➤ YN0002: │ styled-jsx@npm:4.0.0 [806ea] doesn't provide @babel/core (pbde35), requested by @babel/plugin-syntax-jsx
➤ YN0002: │ xstate-viz-app@workspace:. doesn't provide @babel/core (p81569), requested by babel-jest
➤ YN0002: │ xstate-viz-app@workspace:. doesn't provide @chakra-ui/system (pe6242), requested by @chakra-ui/icons
➤ YN0060: │ xstate-viz-app@workspace:. provides cypress (p51176) with version 8.0.0, which doesn't satisfy what cypress-real-events requests
➤ YN0002: │ xstate-viz-app@workspace:. doesn't provide ws (p928f6), requested by @xstate/inspect
➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements  for details, where  is the six-letter p-prefixed code
➤ YN0000: └ Completed in 11s 697ms
➤ YN0000: ┌ Fetch step
➤ YN0013: │ yargs@npm:17.0.1 can't be found in the cache and will be fetched from the remote registry
➤ YN0013: │ yauzl@npm:2.10.0 can't be found in the cache and will be fetched from the remote registry
➤ YN0013: │ yn@npm:3.1.1 can't be found in the cache and will be fetched from the remote registry
➤ YN0013: │ yocto-queue@npm:0.1.0 can't be found in the cache and will be fetched from the remote registry
➤ YN0013: │ typescript@npm:4.3.5 can't be found in the cache and will be fetched from the remote registry
➤ YN0000: └ Completed in 1m 3s
➤ YN0000: ┌ Link step
➤ YN0007: │ bufferutil@npm:4.0.3 must be built because it never did before or the last one failed
➤ YN0007: │ utf-8-validate@npm:5.0.5 must be built because it never did before or the last one failed
➤ YN0007: │ cypress@npm:8.0.0 must be built because it never did before or the last one failed
➤ YN0007: │ core-js-pure@npm:3.9.0 must be built because it never did before or the last one failed
➤ YN0007: │ xstate-viz-app@workspace:. must be built because it never did before or the last one failed
➤ YN0009: │ xstate-viz-app@workspace:. couldn't be built successfully (exit code 1, logs can be found here: /private/tmp/xfs-1b11a7d7/build.log)
➤ YN0009: │ xstate-viz-app@workspace:. couldn't be built successfully (exit code 1, logs can be found here: /private/tmp/xfs-1b11a7d7/build.log)
Node 14.18.3
Yarn 2.4.3
MacOS Catalina 10.15

If I do an npm install it appears to work but then when running npm run start I get the following broken look site:

What I'm actually trying to do is to get a local version of the inspector: https://statecharts.io/inspect

As to Yarn - it looks like you are using Yarn 2/3 there but we are using Yarn Classic (v1) here.

Would be good to add that to the README.

You can close this ticket, I'll start a new ticket with the other issue.


Move extension methods experiment to shipped list

Review in https://dart-review.googlesource.com/c/sdk/+/149686


chore: update CODEOWNERS

:tada: This PR is included in version 6.0.1 :tada:
The release is available on:

v6.0.1
GitHub release

Your semantic-release bot :package::rocket:


dotnet publish command fails on container builder for react-redux spa template

I created a new project with dotnet new reactredux. I then added a Dockerfile that that runs the dotnet publish command.  I can build and run the docker image locally on my windows machine with no problem but when I push to container builder I get this error:
/usr/share/dotnet/sdk/2.0.0/Sdks/Microsoft.NET.Sdk/build/Microsoft.NET.Sdk.DefaultItems.targets(286,5): error : Duplicate 'Content' items were included. The .NET SDK includes 'Content' items from your project directory by default. You can either remove these items from your project file, or set the 'EnableDefaultContentItems' property to 'false' if you want to explicitly include them in your project file. For more information, see https://aka.ms/sdkimplicititems. The duplicate items were: 'Views/Home/Index.cshtml'; 'Views/Shared/Error.cshtml'; 'Views/Shared/_Layout.cshtml' [/source/webapp.csproj]
The command '/bin/sh -c dotnet publish --output /app/ --configuration Release' returned a non-zero code: 1

My googling suggests the issue is with the .csproj file and that the latest sdk includes everything in the project directory by default, but I can't pinpoint what exactly is causing the issue.
My .csproj file looks like this:
<Project Sdk="Microsoft.NET.Sdk.Web">

  <PropertyGroup>
    <TargetFramework>netcoreapp2.0</TargetFramework>
    <TypeScriptCompileBlocked>true</TypeScriptCompileBlocked>
    <TypeScriptToolsVersion>Latest</TypeScriptToolsVersion>
    <IsPackable>false</IsPackable>
    <GenerateAssemblyInfo>false</GenerateAssemblyInfo>
  </PropertyGroup>

  <ItemGroup>
    <None Include="app.yaml" CopyToOutputDirectory="Always" />
    <None Include="Dockerfile" CopyToOutputDirectory="Always" />
  </ItemGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.AspNetCore.All" Version="2.0.0" />
  </ItemGroup>

  <ItemGroup>
    <DotNetCliToolReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Tools" Version="2.0.0" />
  </ItemGroup>

  <ItemGroup>
    <!-- Files not to publish (note that the 'dist' subfolders are re-added below) -->
    <Content Remove="ClientApp\**" />
  </ItemGroup>

  <Target Name="DebugRunWebpack" BeforeTargets="Build" Condition=" '$(Configuration)' == 'Debug' And !Exists('wwwroot\dist') ">
    <!-- Ensure Node.js is installed -->
    <Exec Command="node --version" ContinueOnError="true">
      <Output TaskParameter="ExitCode" PropertyName="ErrorCode" />
    </Exec>
    <Error Condition="'$(ErrorCode)' != '0'" Text="Node.js is required to build and run this project. To continue, please install Node.js from https://nodejs.org/, and then restart your command prompt or IDE." />

    <!-- In development, the dist files won't exist on the first run or when cloning to
         a different machine, so rebuild them if not already present. -->
    <Message Importance="high" Text="Performing first-run Webpack build..." />
    <Exec Command="node node_modules/webpack/bin/webpack.js --config webpack.config.vendor.js" />
    <Exec Command="node node_modules/webpack/bin/webpack.js" />
  </Target>

  <Target Name="PublishRunWebpack" AfterTargets="ComputeFilesToPublish">
    <!-- As part of publishing, ensure the JS resources are freshly built in production mode -->
    <Exec Command="npm install" />
    <Exec Command="node node_modules/webpack/bin/webpack.js --config webpack.config.vendor.js --env.prod" />
    <Exec Command="node node_modules/webpack/bin/webpack.js --env.prod" />

    <!-- Include the newly-built files in the publish output -->
    <ItemGroup>
      <DistFiles Include="wwwroot\dist\**; ClientApp\dist\**" />
      <ResolvedFileToPublish Include="@(DistFiles->'%(FullPath)')" Exclude="@(ResolvedFileToPublish)">
        <RelativePath>%(DistFiles.Identity)</RelativePath>
        <CopyToPublishDirectory>PreserveNewest</CopyToPublishDirectory>
      </ResolvedFileToPublish>
    </ItemGroup>
  </Target>

</Project>

I'm not entirely sure if this is a problem with the react-redux spa template or with Google's container builder.  I don't have the same issue using the empty web template from dotnet new web.

I'm not familiar with Google's container builder or what different requirements or conventions it involves. Sorry I can't offer advice on that. If you track this down and believe there's a bug in the code in this repo, or some way it could be made more compatible generally, please let us know the details!


Can you provide a full exemple without Kotlin?

Title says it all.
Thanks

Hello @PedroBarbosaPT, I'm sorry for the late reply. First of all thank you for the interest in my library.
At the moment there are two dedicated java files (link) that show how to invoke Paperboy from Java.
Would this be sufficient for you?
All you have to do is, taking the Fragment that is created by PaperboyChainBuilder and PaperboyBuilderKt.buildPaperboy and put it in some container via the FragmentManager as you would do with every other Fragment.
Something like this (in case you would use the Java classes of the sample app):
public class SampleActivity extends AppCompatActivity {
    @Override
    protected void onCreate(@Nullable Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);

        if (savedInstanceState == null)
            getFragmentManager().beginTransaction()
                    .replace(R.id.content, JavaSample2.buildCustom())
                    .commit();
    }
}

Thanks for the help, but I still have 1 error.
buildCustom (Context) in SampleActivity cannot be applied to ()
So I did this:
    Context context = this.getApplicationContext();
    if (savedInstanceState == null)
        getFragmentManager().beginTransaction()
                .replace(R.id.content, changeLog.buildCustom(context))
                .commit();
}

And now:

Wrong 2nd argument type. Found: 'com.github.porokoro.paperboy.PaperboyFragment', required: 'android.app.Fragment'

Thanks for all the help so far

My bad, it should be getSupportFragmentManager() instead of getFragmentManager().

Thanks, its now working like a charm 👍 ;)
One more thing please
Can you provide me this layout? https://raw.githubusercontent.com/porokoro/paperboy/develop/art/screenshot-2.png

For this layout all you have to do is setting the view type to LABEL.
new PaperboyChainBuilder(context)
                .viewType(ViewTypes.LABEL)
                .buildFragment();

Then you can throw the returned fragment into the SupportFragmentManager as usual.

Thanks
Great job / Great Design 👍


Question : Possible to send messages as a bold italic or smileys in telegram?

Not issue , just question

I'm not really a user of telegram, so I'm not 100% sure what the character encoding of formatted text or emoji's looks like. It should be possible, but I don't know how.

you should add to the sent string to bot "parse_mode = HTML" (alongside chat_id and text)  and then you can use  for bold </> for italic

So it looks like to support bold or italics the parse_mode would have to be html or markdown. I think I would prefer markdown, just to make it consistent with slack and discord. I will add that as a feature.
To send emojis you have to set the escaped unicode string of the emoji... I don't think there's anyway I can make that easier for telegram.

Implemented in https://github.com/CryptoSignal/crypto-signal/pull/272. The default parse mode ended up being HTML as some markdown characters are being used in the default message format which can cause issues when there is no matching end pair. That said you can choose to use whatever you like!

Merged


Use object notation for data_stream fields

Currently, we're setting the data_stream.* fields in dotted notation:
https://github.com/elastic/apm-data/blob/6ef8c812968705603f67f04f6cb605c7a46a94a0/model/internal/modeljson/document.go#L73-L75
This causes issues when using the reroute processor:

https://github.com/elastic/elasticsearch/pull/96243

While I think that the reroute processors, and all processor for that matter, should support both dotted and nested field notations, we should use nested fields to work around that issue for now.
It seems unlikely that users have relied on the dotted field notation in their ingest pipeline as the set processor doesn't even work with dotted field names. The only processor for which it's possible to access dotted field names is the script processor.
The primary way to set the data_stream.* fields in an ingest pipeline is the reroute processor, but it can't be use for APM due to the dotted field notation.

The reroute processor supports dotted field names now, so changing to object notation in APM Server isn’t required anymore.


Small bug in setup-unit shell script on line 12 causing failure

Located under: https://unit.nginx.org/installation/#repo-install
This script: https://unit.nginx.org/_downloads/setup-unit
Script has small bug on line 12 causing the script to throw a syntax error:
./setup-unit: line 731: syntax error near unexpected token '}'
./setup-unit: line 731: '}'
Line 12 is: >&2 echo 'Your version of bash(1) isn't supported by this script.';
An extra open single quote is causing the bulk of the script to become a string
Line 12 should be: >&2 echo "Your version of bash(1) isn't supported by this script.";
Swapping out single quotes for double and the script executes perfectly on Debian 11.5

Thanks! We already aware of it and we will push a new version the next days. Christmas as coming in the way 🎄
Thanks for reporting this. I will let you know once we have pushed the fix so you can test it again.
Thanks for sharing

@figuerom16 could you please try again?

The new script target at https://raw.githubusercontent.com/nginx/unit/master/tools/setup-unit works perfectly now on Debian 11.5.
Thank you!


About the evaluation set of ACE

Hello, thank you for your excellent work.
As mentioned in your paper, We used two settings for selecting known types: 10 most frequent events types and 8 event types, one from each parent type of the event ontology and The evaluation is done on the complete set of event types.
Could you please tell me what is the ACE evaluation set used in the results of rows 10 most frequent and 1 per general type in Table 8 ?
Does the evaluation set of these experimental settings contain seen event types?

Hi zhengdong, the dev set and evaluation set are kept are the same with the full ACE dataset. We only reduced the number of training examples by type.


npm latest dist-tag is pointing to 1.2.32, not 1.5.8

Note: for support questions, please use one of these channels: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#question. This repository's issues are reserved for feature requests and bug reports.
Do you want to request a feature or report a bug?
bug
What is the current behavior?
npm install angular installs angular version 1.2.32
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://plnkr.co or similar (template: http://plnkr.co/edit/tpl:yBpEi4).
 npm install --save angular
~/
└──<EMAIL_ADDRESS>
What is the expected behavior?
version 1.5.8 should be installed
What is the motivation / use case for changing the behavior?
N/A
Which versions of Angular, and which browser / OS are affected by this issue? Did this work in previous versions of Angular? Please also test with the latest stable and snapshot (https://code.angularjs.org/snapshot/) versions.
N/A
Other information (e.g. stacktraces, related issues, suggestions how to fix)
An authorized owner of the angular npm package should run this command:
 npm dist-tag add<EMAIL_ADDRESS>latest

Thx for reporting! It should have been fixed a few minutes ago.
(It is kind of a "known (temporary) issue".)


Remove whitespace between sections when separators are disabled

Hi,
I have removed airline_left and right_separators but still can't get right of a blank character here:

Any suggestions?
Here is what I have now in my .vimrc:
let g:airline_powerline_fonts = 0
let g:tmuxline_powerline_separators = 0
let g:airline_left_sep=''
let g:airline_right_sep=''

Similarly, how do I hide an empty section like this?

@firedev the space is put there on purpose so that your buffers don't shuffle back and forth when you're switching between buffers.
@atav32 that's a known limitation of the current implementation, please see #157.


⚠ Bofrost.lu has degraded performance

In 9e598c2, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1998 ms

Resolved: Bofrost.lu performance has improved in 211df15 after 8 minutes.


Fix ShiftRows destroys merged cell issue

sync ShiftRows logic from POI 5.2
fix merged region overlap issue

I wanted to give it a try but solution doesn't compile
with an error
npoi/main/SS/Formula/PTG/FormulaShifter.cs could not be found

@serii833 I forgot changing the non-Core csproj files. Can you try again?

@tonyqus looks good on my samples


chore: bdd-sbhg-1587113723 to 0.0.1

chore: Promote bdd-sbhg-1587113723 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Move the . back into button on icon download page.

Guessing docutune did this.  Move the period back into the button.

#sign-off

@ckittel - Thanks for the fix!
(FYI, this PR was opened in the public repo. In the future, you can use the private repo and tag the author for review if needed. Thanks!)

@Court72 - OMG -- can't believe I didn't notice that.  Thanks :)


Implement AnnotationReindex transform

Summary

Ticket no. 109026
Add a new transform to reindex annotation ids.

How to test
Tests are added to verify this change.
Checklist

[x] I have added unit tests to cover my changes.
[ ] I have added integration tests to cover my changes.
[x] I have added the description of my changes into CHANGELOG.
[ ] I have updated the documentation accordingly

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[x] I have updated the license header for each file (see an example below).

# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Codecov Report
Patch coverage: 77.77% and project coverage change: -0.01 :warning:

Comparison is base (e1d4314) 78.57% compared to head (af24ed3) 78.57%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1008      +/-   ##
===========================================
- Coverage    78.57%   78.57%   -0.01%
===========================================
  Files          237      237
  Lines        27046    27063      +17
  Branches      5396     5397       +1
===========================================
+ Hits         21251    21264      +13
- Misses        4528     4532       +4
  Partials      1267     1267

Flag
Coverage Δ

ubuntu-20.04_Python-3.8
78.57% <77.77%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

datumaro/plugins/transforms.py
75.31% <77.77%> (+0.02%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


chore: concurrent Server Side Apply for catalog sync

Applies Catalog Data concurrently to allow for faster synchronisation of ModuleTemplates

/test all


Build binaries take too much space

This is preventing us from creating build artifacts efficiently which enables multi-stage CI pipelines. Enabling multi-stage CI pipelines is critical to accelerating CI runs #2128
(python_env) billteng@e03cs01:~/ttm2/build/lib$ ls -l
total 1469128
-rw-rw-r-- 1 billteng billteng  22417748 Sep 26 01:54 libbuild_kernels_for_riscv.a
-rw-rw-r-- 1 billteng billteng  10787880 Sep 26 01:53 libcommon.a
-rwxrwxr-x 1 billteng billteng   3278184 Sep 26 01:53 libdevice.so
-rw-rw-r-- 1 billteng billteng  37724542 Sep 26 01:54 libdtx.a
-rw-rw-r-- 1 billteng billteng  43536404 Sep 26 01:54 libllrt.a
-rw-rw-r-- 1 billteng billteng  56667894 Sep 26 01:54 libtensor.a
-rwxrwxr-x 1 billteng billteng     27984 Sep 26 01:53 libtracy.a
-rw-rw-r-- 1 billteng billteng 817002186 Sep 26 01:54 libtt_dnn.a
-rw-rw-r-- 1 billteng billteng  17988820 Sep 26 01:54 libtt_gdb.a
-rwxrwxr-x 1 billteng billteng 308021640 Sep 26 01:54 libtt_lib_csrc.so
-rw-rw-r-- 1 billteng billteng  10397064 Sep 26 01:54 libtt_metal_detail.a
-rw-rw-r-- 1 billteng billteng 103962010 Sep 26 01:54 libtt_metal_impl.a
-rwxrwxr-x 1 billteng billteng  72528088 Sep 26 01:54 libtt_metal.so
drwxrwxr-x 2 billteng billteng      4096 Sep 26 01:53 tools
(python_env) billteng@e03cs01:~/ttm2/build/lib$ du . -h --max-depth=1
9.7M    ./tools
1.5G    .

Perhaps the best way out is to redo build with #2662 and/or #2874

Assuming you guys are running with CONFIG=ci, this is a non-issue:
With default build (i.e. CONFIG=assert):

with CONFIG=ci:

With assert it's getting compiled with -g and size bloat is from the debug symbols

does build=ci work in post-commit? If so, that would be an easy way to enable artifacts

does build=ci work in post-commit? If so, that would be an easy way to enable artifacts

@tt-rkim

@TT-billteng @cfjchu @ttmchiou
got a PR up to integrate CONFIG=ci into all our flows and add it as part of build binaries step: https://github.com/tenstorrent-metal/tt-metal/pull/5655
Build itself looks good and I've tested eager package pipeline + profilier pipeline and they work. Both libs and tests build wonderfully. Note for those unfamiliar with build binaries pipeline, we upload everything in build/lib and build/test. I believe we could (and possibly should) add build/hw and build/programming_examples
https://github.com/tenstorrent-metal/tt-metal/actions/runs/8054614149
https://github.com/tenstorrent-metal/tt-metal/actions/runs/8055845818
https://github.com/tenstorrent-metal/tt-metal/actions/runs/8055846477
is all post commit.
Once this passes, we'll merge this immediately and we can start using ci config on all tests. We could consider a slow rollout such as incorporating these artifacts into the profiler regression.

We have switched over all pipelines to use ci config and added CONFIG=ci to the build C++ binaries pipeline.
There's some work to be done to verify that we can just download and use these binaries that we built on Github-hosted runners.

This is hw toolchain, lib, test, and programming_examples on a per config basis (specification for build folder in workflow: https://github.com/tenstorrent-metal/tt-metal/actions/runs/8067848579/workflow) :

We're going to close this now as we now have a much more reasonable output of <100MB.


Umamusume soul causes crash

equip umamusume soul
equip umamusume apparel
take off umamusume soul
crash

Here is the crash report:
crash-2022-12-26_09.19.19-client.txt

Fixed in 0.0.3, Check github release.


Did you mean "same"?

thx


Add snippet bot

TL;DR
There is no snippet bot to check to ensure that region tags are healthy.
Currently there is no check to ensure safe deletion or addition of region tags in code samples.  This can potentially lead to issues when users click Github Link shown in Cloud Docs pages.
Example: Check snippet-bot.yml in https://github.com/GoogleCloudPlatform/python-docs-samples/tree/main/.github
Terraform Resources
NA

Detailed design
Adding snippet bot

Additional information
No response

During the recent PR I have observed that snippet bot did not trigger, so re-opening the issue.


Make keys not bound to anything in normal mode be usable

If I haven't bound a key to anything, it should be available for use as if you are in insert mode.
For example arrow keys in YouTube should work as I haven't bound arrow keys to anything in my bindings:
"bindings": {
      "hintToggle": "f",
      "newTabHintToggle": "shift+f",
      "scrollUp": "k",
      "scrollDown": "j",
      "scrollLeft": "h",
      "scrollRight": "l",
      "goToPageTop": "g g",
      "goToPageBottom": "shift+g",
      "goToFirstInput": ":",
      "goBack": "shift+j",
      "goForward": "shift+k",
      "reload": "r",
      "tabBack": "a",
      "tabForward": "w",
      "closeTab": "e",
  }

Same for all other keys. Like v or o and so on. This was allowed by sVim too and is super useful.

Yeah, I've noticed this too and I think it's a pretty big workflow regression. We should fix this or revert the normal mode patch before submitting to the App Store.

I've implemented this behaviour in branch 188-normal-mode-non-bound-keys. As we can only isolate keys on a per-key-basis I had to isolate all keys that are bound according to the settings. This means that even though by default g doesn't do anything in Vimari it is isolated because it is part of both g+i,shift+g, and g+g. See included code below for reference.
In my opinion we should add this as a preference (something like transparentBindings) that defaults to true as it is a workflow regression as said before.
// Returns all keys bound in the settings.
function boundKeys() {
    var bindings = Object.values(settings.bindings)
        // Split multi-key bindings.
        .flatMap(s => s.split("+"))
    bindings.push(settings.modifier)
    // Use a set to remove duplicates.
    return new Set(bindings)
}

Random note for future readers: if you made your userSettings.json before #194, missing json keys don't seem to inherit from the default settings. You have to specifically add it to your userSettings.json it seems.


Hide footer when keyboard is opened

https://user-images.githubusercontent.com/39493102/154974794-7e158dee-6ec9-42c5-9b5b-eca576834f7d.mp4

is this working fine on iOS? let us verify in iOS device before merging

is this working fine on iOS? let us verify in iOS device before merging

Yes Ravi has tested this

We went ahead with the scroll input into view solution


Issue with opening Carla

getting this issue when trying to use carla. Any help would be great.

Hi @andrster.
Can you provide more information?
How many versions of Unreal do you have installed? Which version are you using? Are you rebuilding CARLA?

I believe 4.18 and yes I was rebuilding carla.

If you press "Yes" does it give any error? I've seen this happening sometimes, usually pressing yes it recompiles and launches the editor just fine.

Yes it won't recompile and to try manually, which also won't work.  Also my symbol for the project looks off and make rebuild in carla gives that error

and this happens on Rebuild.sh

issue resolved


Switch to fixed-point algorithm

Currently with larger keyframe intervals (even at just 60 frames) accumulating errors are very noticeable and result in a "pulsing" behavior.
Will likely need to switch to a fixed-point integer algorithm instead, so that any error is 100% predictable can be precisely accounted for in the encoder.

Implemented as of b1d2679
I figure this also warrants a minor codec version bump since accumulated errors would likely be exacerbated by trying to run new fixed-point output through a floating-point decoder.


Refresh config using file-system notifications

Rather than periodically polling the config file.
This is based off of #855

Closing because this will be made obsolete by the move to futures/tokio.


[Feature] - Please add support for Enchanted Shulkers

Description:
I been trying to tell which of the two shulker mods i like more, yours or "Upgraded Shulkers"
Yours easily won, in funcationality with another mod already and texture wise.
But a mod called Item Swapper adds a functionality to drag items from shulkers.
Sadly the mod doesnt work with this mod, but it would be great if it could! :)
What is wished to happen:
A clear and concise description of what you want to happen.
For compatibility with the Item Swapper mod.
Additional context
Add any other context or screenshots about the feature request here.
Item Swapper mod link: https://www.curseforge.com/minecraft/mc-mods/itemswapper

I have found there was also the same issue in the Item Swapper mod repository. https://github.com/tr7zw/ItemSwapper/issues/117
Let me think about it.

Forgot to mention that i been using the 1.19.2 version, if that would be an issue, ik most mods have been pushing for 1.19.3 for some reason.

I'm pretty sure there were some breaking changes between 1.19.2 and 1.19.3, but I don't think that matters. The Item Swapper mod doesn't seem to have an interface for integrating with other mods. So, I'll have to figure out how to proceed.

should we also ask on their github for if they can help open for interfacing?
Btw ty for the time for looking into it :D

Yeah. Specifically, having the entrypoint of the Item Swapper mod would make the integration easier.

I found a compatibility datapack that does something similar to what we need:
https://modrinth.com/mod/charm-drag-and-drop-shulker-fix
_This is a very simple mod to improve the behavior of Charm's drag and drop shulker module.
The module's normal behavior with any shulker, be it modded or not, is to use the vanilla shulker box's container size, even if a modded shulker, in this case a shulker from Reinforced Shulkers, has a larger size than a vanilla shulker box.
This mod patches that to make it so that, at least a Reinforced Shulker, can be used to it's full capacity with the module._
This or something like this might improve the compatibility between your mod and Enchanced Shulkers.  The dev seems friendly too.


feat(docs): support inlining code snippets from files

Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Codecov Report
Patch coverage has no change and project coverage change: -10.72 :warning:

Comparison is base (54a3727) 75.01% compared to head (37dbbaf) 64.30%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7712       +/-   ##
===========================================
- Coverage   75.01%   64.30%   -10.72%
===========================================
  Files         353      353
  Lines       35425    35425
===========================================
- Hits        26574    22779     -3795
- Misses       8851    12646     +3795

Flag
Coverage Δ

pytest-testIntegration
?

pytest-testIntegrationBatch1
?

pytest-testQuick
63.61% <ø> (ø)

pytest-testSlowIntegration
33.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 90 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


ResolveCommand results in FATAL error

Hey,
I tried this now for almost two hours and I am sorry, but I can't find any solution for this.
I have a lot of hosts under one domain and i'd like to not type the full hostname everytime i would like to connect.
I tried to solve this by using the ResolveCommand.
My config:
hosts:

  "*.fresh":
    ResolveCommand: /bin/sh -c "echo $(echo %h | sed s/.fresh//).freshest.me"
    Inherits:
    - private-template

templates:
  # Templates are similar to Hosts, you can inherits from them
  # but you cannot ssh to a template
  work-template:
    User: worker
  private-template:
    User: andre

defaults:
  # Defaults are applied to each hosts
  ControlMaster: auto
  ControlPath: ~/tmp/.ssh/cm/%h-%p-%r.sock
  ControlPersist: yes
  Port: 22
  User: andre
  TCPKeepAlive: yes
  ServerAliveInterval: 10
  ForwardAgent: yes
  IdentityFile: ~/.ssh/id_rsa

includes:
- ~/.ssh/hosts/*.yml

The following error:
> $ ssh www.fresh
DEBU[0000] assh args: [www.fresh]
DEBU[0000] Loading config file '/Users/andre/.ssh/assh.yml'
DEBU[0000] Loaded config file '/Users/andre/.ssh/assh.yml' (0 + 2 => 2 hosts)
DEBU[0000] Loading config file '/Users/andre/.ssh/hosts/backend-a.yml'
DEBU[0000] Loaded config file '/Users/andre/.ssh/hosts/backend-a.yml' (2 + 7 => 5 hosts)
DEBU[0000] Loading config file '/Users/andre/.ssh/hosts/dev.yml'
DEBU[0000] Loaded config file '/Users/andre/.ssh/hosts/dev.yml' (7 + 10 => 3 hosts)
DEBU[0000] Loading config file '/Users/andre/.ssh/hosts/private.yml'
DEBU[0000] Loaded config file '/Users/andre/.ssh/hosts/private.yml' (10 + 14 => 4 hosts)
DEBU[0000] getHostByName pattern matching: "*.fresh" => "www.fresh"
INFO[0000] Host www.fresh
INFO[0000]   ControlMaster auto
INFO[0000]   ControlPath ~/tmp/.ssh/cm/%h-%p-%r.sock
INFO[0000]   ControlPersist yes
INFO[0000]   ForwardAgent yes
INFO[0000]   HostName www.fresh
INFO[0000]   IdentityFile ~/.ssh/id_rsa
INFO[0000]   Port 22022
INFO[0000]   ServerAliveInterval 10
INFO[0000]   TCPKeepAlive yes
INFO[0000]   User andre
INFO[0000]   # Inherits: [private-template]
INFO[0000]   # ResolveCommand: /bin/sh -c "echo (echo %h | sed s/.fresh//).freshest.me"
DEBU[0000] Saving SSH config
DEBU[0000] Writing SSH config file to "/Users/andre/.ssh/config"
DEBU[0000] Proxying
DEBU[0000] Connecting without gateway
DEBU[0000] Preparing host object
DEBU[0000] Resolving host: "www.fresh" using command: "/bin/sh -c \"echo (echo www.fresh | sed s/.fresh//).freshest.me\""
FATA[0000] Proxy error: exit status 2
ssh_exchange_identification: Connection closed by remote host

Hopefully someone could help me.
Thank you very much.
Best regards,
André

Hi @edi-design, thank you for reporting,
Your configuration looks good, there is probably a bug when executing commands with double-quotes, I need to give a deeper look

It looks like the issue come from the dollar character
ResolveCommand: /bin/sh -c "echo $(echo %h | sed s/.fresh//).freshest.me"
# fatal error

ResolveCommand: /bin/sh -c "echo `echo %h | sed s/.fresh//`.freshest.me"
# resolving

I suggest you to switch to this syntax while I find a better solution

I just fixed the issue in #118, if you upgrade to the latest version (brew upgrade assh --HEAD for instance), you will be able to use your favorite syntax :)

do not hesitate to reopen the issue if the problem persists

Thank you very much.
It works now perfectly.
Again, thank you for your very fast fix and help.

:+1:


minigame Shades of Mort'ton is not listed in Drystreaks (therefore can't do drystreak for gary)

🐛 Bug Report
title says all

Shades of morton is now available under drystreaks (both bots) however gary cannot be check for.

Gary will be added to shades cl next BSO update.


unified memory

Is it possible/sensible to use unified memory to avoid errors like:
2021-03-22T19:54:56.782153 E 118135 617 BufferMgr.cpp:410 ALLOCATION failed to find 256000000B throwing out of memory GPU_MGR:3
2021-03-22T19:54:57.056019 E 118135 614 BufferMgr.cpp:410 ALLOCATION failed to find 256000000B throwing out of memory GPU_MGR:0
2021-03-22T19:54:57.314486 E 118135 616 BufferMgr.cpp:410 ALLOCATION failed to find 256000000B throwing out of memory GPU_MGR:2
2021-03-22T19:54:57.705913 E 118135 615 BufferMgr.cpp:410 ALLOCATION failed to find 256000000B throwing out of memory GPU_MGR:1
2021-03-22T19:54:57.714073 E 118135 1 DBHandler.cpp:1091 Exception: Failed to run the cardinality estimation query: Query couldn't keep the entire working set of columns in GPU memory

Nope, the two memory pools are managed internally and the way the system memory is allocated isn't compatible with unified memory.
I could instruct you how to set database parameters to stream data from system memory to GPU, but it wouldn't be a supported configuration and, likely, the performance wouldn't be optimal


How to change video quality manually ?

React-native 0.62.0

You can try "adaptive-logic" option in initOptions. It gives you an ability to select strategy for adaptive quality.
--adaptive-logic={,predictive,nearoptimal,rate,fixedrate,lowest,highest}
https://wiki.videolan.org/VLC_command-line_help


Added property resolution to maven visitor.

Added a check for property values if the groupId or artifactId fail to find a match.

fixed #585


Umbrella Phase 1 Requirements

For V1 release. Goal is March 1. In addition to: https://github.com/DAGWorks-Inc/burr/issues/29, we have:

[x] Example apps with tracking server

[x] Chatbot

[x] Add more complex example (simple chatbot) in getting started in docs
[x] Get video intro for those who want to watch
[x]  Roadmap in README
[ ] (stretch) Static server hosted online
[x] Streamed output https://github.com/DAGWorks-Inc/burr/issues/19
[ ] (stretch, with feedback) -- handling exceptions (https://github.com/DAGWorks-Inc/burr/issues/30)
[x] State persistence in a clean way
[ ] (directly post-release) Logging metadata -- https://github.com/DAGWorks-Inc/burr/issues/46
[x] Telemetry/tracking on posthog (with opt-out, same as hamilton)(https://github.com/DAGWorks-Inc/burr/issues/58)
[x] Figure out what slack to link to
[x] Add comparison matrix in README #76

[x] Langgraph
[x] Temporal
[x] langchain
[x] hamilton
[x] superagent.sh (burr is not agent specific, host/run wherever python runs)

[x] Change README gif to be of actual chatbot API

This is complete


fixing a lot of pedantic error (-Wall)

stack build --fast --ghc-options -Wall
Not everything done yet (but end of day)

@capitanbatata looks like codeclimate complains about existing issues if there's a change on their lines.

Code climate reports some new issues. Are we OK with those or do we want to fix them before we merge these changes?

Code climate doesn't report new issues:
when a line is changed the issue is assumed to be removed.
when the changed line still contains an issue, it is considered a new issue!
I propose to accept this pull request!

@PierreVDL @pjljvandelaar it is approved now. Feel free to sqash and merge it.


climb global implementation

This is a possible implementation for climb global. I have not tested this on Windows though.

Oh wait, forgot to fix the tests :)

Looks good! Could you just look at my inline comments and then rebase all the commits.

Done

Great! Could you squash them as well?

Done.

That is good but there is still 3 commits. We only want the first one.

There was some weird stuff going on because I only merged upstream after the initial commit.

Weird, I'll merge then. Thanks for this!


[Icon Request] Support for @master/cli

[x] I'm sure this issue is not a duplicate.

[x] I'm submitting an icon request:

Type: filename
Icon Name: master
Sample original Icon:
Filenames: master.json, master.js, master.mjs

More info: Support for configuration file of @master/cli

@0Miles do you have a link where we can see what this is all about?

@0Miles do you have a link where we can see what this is all about?

https://github.com/master-style/package
@master/cli can generate a package with master.json based on @master/package
And you can generate README.md and other files according to master.json at any time later
This is an example of master.json

Can you confirm the differences between this & #2880 so I can combine them into a single PR?

Can you confirm the differences between this and #2984 so I can combine them into a single PR?

#2984 is used to customize configurations for @master/styles
@master/package is a repo to get started a new project/package and we configure master.json via master.json


clarify alternative to wrapper.setState()

LGTM

@RebootJeff can you update your PR with the latest changes from master? We can merge after that!

@Aweary I used GitHub's "Update Branch" feature (new to me), which seems to have merged master into my patch-1 branch. Let me know if you prefer a rebase instead.

Looks good @RebootJeff thanks!

In the future, a rebase is preferred. Merge commits make git bisect cry.

@ljharb I squashed the commits before merging, is that still a problem?

@Aweary ah ok, that's better then, altho i dislike the squash feature too :-/ what I'd really like is for github to show a button to PR authors for "rebase on top of master", and for admins to be able to check a box to disallow merge commits, thus requiring PR authors to click that button / rebase before things are merged.

@ljharb got it. So for future reference, contributors should ask PR authors to rebase if there are any merge commits, then don't use the squash option when merging the PR. Does that sound right? I want to be sure we're all on the same page as far as commit/merge policies go.

Yes, ideally. Obviously tho it's unreasonable to ask every contributor to rebase every time, especially when the PR is documentation and was made in the web UI, so use your judgement.
Order of my merge preferences:

command-line-merged fast-forward of a rebased PR (no-merge, or otherwise-fast-forwardable merge commit, as appropriate)
"merge button" of an otherwise fast-forwardable rebased PR
"merge button" of a PR (that doesn't have a bunch of sloppy commits nor any merge commits)
"merge + squash button" of a PR that has those things ^

It's also always cool to use your own judgement, none of these things will be a catastrophe either way :-)

Awesome, thanks for clarifying. Saving this comment as a reference 👍

ping @blainekasten @nfcampos, probably good to all be on the same page 😄


Cache asm capabilities for reuse

Summary:
This PR adds an option to populate a yaml file containing the ASM capabilities and if it exists to re-use it.
Outcomes:
For short, iterative work using tensile this can significantly reduce the runtime. Further, when running the precheckin tests (i.e. tox -e ci) with this option enabled the runtime is reduce from 68 minutes to 56 minutes.
Notable changes:
Adds --asm-cache <path to file> to enable caching asm capabilities.
Testing and Environment:
Tested locally in ub22 image. Running CI pipelines.

Please do not forget to update year in each file.

Please do not forget to update year in each file.

Will do thanks.

I am not quite sure about the intention of this change.
Does this mean calling GetAsmCaps is slow?

Looks like CI tests are failing.
Please fix it.

I am not quite sure about the intention of this change. Does this mean calling GetAsmCaps is slow?

Yes it is relatively slow. It depends on the context as always.

Looks like CI tests are failing. Please fix it.

Working on it now. It's a bit complicated to get this working for the unit tests.

@nakajee Tests are passing.


[Performance] Non-owning string type

Can we have a string type which doesn't make a deep copy? It could be a big performance boost when we serialize some big Data Transfer Object to json. For example:
    const std::string s = make_some_string();
    json::object res;
    res.emplace("value", json::string_ref(s.c_str())); // string_ref or any name you like
    // ...
    return json::serialize(res);

Rapidxml already has simillar distinction between owning and non-owning strings:
https://rapidjson.org/md_doc_tutorial.html#CreateString
https://rapidjson.org/structrapidjson_1_1_generic_string_ref.html

Boost.JSON makes certain tradeoffs which advantage some use-cases but disadvantages others. One of the core tradeoffs is that the json::value type is copyable and never becomes invalid. If we support a "string reference" variant type, then the utility of json::value as a vocabulary type is diminished as users can no longer guarantee that elements of arrays or objects will not become invalid (when the underlying string is destroyed).
If possible, you should structure your code to deal with the native JSON types directly:
json::string s = make_some_string(); // return type is json::string
json::object res;
res.emplace( "value", std::move(s) ); // Complexity: constant.
...

@vinniefalco I see your point. Having safe type like current json::value is indeed convenient. But on the other hand the solution you presented break's the whole idea of encapsulation. One would have to completely change application logic design to use json::string instead of std::string all around the code. This might be impossible when using libraries that produces std::string (like fmtlib for example). Encapsulation of serialization layer inside separate module (possibly separate cmake target) would be impossible.
Some (but not all) of the problems could be resolved just by introducing json::string(std::string&&) constructor that takes ownership of underlying storage, yet I don't know if this is possible with current design.
Maybe modification of json::value is indeed not a good idea, but is it possible that in the feature we could develop different solution, something like json::unsafe_value that will support this feature? I think it is worth discussion and consideration.

I'd there's more chance we create an API for direct JSON serialization that sidesteps value over allowing string_view in value. The point of value is to own its data.

One of the axioms upon which the library is based is "there exists no single set of tradeoffs that will satisfy all JSON use-cases." Boost.JSON is designed to provide a container type which behaves as a value, that operates safely and correctly in all the ways that C++ developers expect such types to work. That is, they are intuitively movable, copyable, constructible, and the json::value operates similarly to a std::variant over the JSON subtypes (array, object, string, and native types). Compare this with RapidJSON where assignments have reference semantics instead of value semantics, and the allocator has to be passed in with every mutating operation.
In addition to emphasizing performance and compactness, the interface normalizes (or homogenizes) the library types. That is, they do not provide any user customization (this is why there are no templates). You can't choose the type of string or the type of hash table used for objects. A Boost.JSON array is the same for every program, on every platform. It can't be configured. Compare this with nlohmann whose basic_value is templated on 8 types.
In other words Boost.JSON types are suitable as vocabulary types. There will always be feature requests such as the one described in the issue, where users desire a different set of tradeoffs from those chosen by the library. These are valid requests, but I don't think they belong in Boost.JSON. Or rather, they should be explored with a completely different set of types and containers. Essentially a different JSON library, which chooses its tradeoffs to achieve a particular goal.