GPR review: privatize host_port.h

The functions supplied in this header were not used in any wrapped language implementation (though they were used in Objective-C tests). Additionally (and a bit surprisingly), these functions were not in use anywhere in the wild as far as I can tell with a Github search or an internal search. They are only used in forks of gRPC or projects under the control of the gRPC team.
Review request to Muxi for Objective-C code
And to Yash for everything else...

****************************************************************

libgrpc.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  +0.0%     +32 [None]    +112  +0.0%

  +0.0%     +32 TOTAL     +112  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  +0.0%     +32 [None]    +120  +0.0%

  +0.0%     +32 TOTAL     +120  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

This will make end2end tests stop building on Mac. The core's end2end tests on Mac depend on this function, and needs gRPC-Core to expose such function.
I don't know if there will be a better solution, but I wonder if we can have a filegroup which contains headers that are revealed to only tests, so that I can export them and depend on that in tests on Mac.

@muxi: Can you mention a specific test? I noticed that this was needed but also that you're already including core-internal headers in the end2end tests that I had seen (e.g., src/core/lib/gpr/env.h) . What method are you using to get those core-internal headers, and can we use that same method to get host_port.h ?

****************************************************************

libgrpc.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  +0.0%     +32 [None]    +120  +0.0%

  +0.0%     +32 TOTAL     +120  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Corrupt JSON data (indicates timeout or crash):
    bm_fullstack_streaming_pump.BM_PumpStreamServerToClient_SockPair__8.opt.old: 1

[microbenchmarks] No significant performance differences

Muxi, I made changes to both src/objective-c/tests files that use gpr_join_host_port , which are CoreCronetEnd2EndTests/CoreCronetEnd2EndTests.mm and CronetUnitTests/CronetUnitTests.m . Was there any other needed?

****************************************************************

libgrpc.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  +0.0%     +32 [None]    +112  +0.0%

  +0.0%     +32 TOTAL     +112  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

Sorry I probably overlooked the other one. LGTM.

The gRFC just landed, so this is going in.


Use 'with open() as' to automaticly close() files

@cclauss this is a most excellent pull request!  I'm happy to merge this.  :clap:
Thank you!    :clap:


Changes required for the SCARF cluster

By using add_scalars rather than add_scalar a set of tensorboard files were created in their respective cascading folder structure. Instead it is makes more sense to have a single tensorboard "experiment" with multiple scalars. Additionally a setup.py and init.py are used to add install the packages into the site packages of the conda/pip environment.

Hi Imraj,

@Imraj-Singh thanks for the changes. Can you improve the setup.py a bit to have at least the dependencies we need in there? You can have a look at one of my other python packages here

@gfardell @paskino should we create a mini stand-alone python package for the quality metrics or should be integrated into CIL / SIRF?

Georg

Hi @gschramm ,
I added numpy, scipy and tensorboardX to the dependencies, but did not specify specific versions. I guess either CIL or SIRF need to be install too. Should those be added?
Imraj


Data preparation functionalities

This PR implements the following:

updating schemas
create data structures locally with correct values
implements functions to place calls to the SciCat API endpoint

I'll merge this here and continue working on top of that : D


SA828 support.

Hello,
thanks for your work on this project. Do you think this is compatible also with the sa828 or that it could be possibly made compatible?
thanks

I'd be happy to send you an sa828 if it would help with development work and you were available

Don't worry. I should receive one in a couple of weeks. I will work on the 868 first, then focus on the 828.
You should get a new code in a few weeks.


add zoom feature

Hi man, Why do you change camera for flutter_better_camera?

Hi, i needed zoom feature. In flutter_better_camera realized one of many this feature.
for example
Issue 1
Issue 2
And i thought to share this funcionality

add zoom feature version 2.0.0


Add pop-up notifs + show a notif when an address has been copied

Show a notification when address is copied.
The bigger chunk of this PR is actually integrating the notification widget (from Grommet) in such a way that it's convenient to use anywhere inside the app.
The method of integration is almost exactly the same how Modal windows are integrated.dialogs.
Fixes #271.

Task linked: CU-3gb22g0 Add visual feedback when copying address to clipboard

@lukaw3d Thanks for all the input. I believe I have now addressed everything you mentioned.


New versions don't show at brew.sh

OS/Platform
macOS
Installed
OS/Platform's package manager
Version
115
Have you tested that this is not an upstream issue or an issue with your configuration?

[ ] I have tried reproducing this issue in Chrome and it could not be reproduced there
[ ] I have tried reproducing this issue in vanilla Chromium and it could not be reproduced there
[ ] I have tried reproducing this issue in ungoogled-chromium with a new and empty profile using --user-data-dir command line argument and it could not be reproduced there

Description
New versions don't show at brew.sh
How to Reproduce?

Go to brew.sh
Type eloston-chromium in the search box
You will see "Current version: [115.0.5790.170-1.1,1691361202]"
In reality ungoogled-chromium has already been updated to v116 2 times.
https://github.com/Homebrew/homebrew-cask/blob/d3fc6d93b693a2d5a5f93c14ea8a8fa9163c24f9/Casks/e/eloston-chromium.rb needs updating.

Actual behaviour
New versions don't appear.
Expected behaviour
To be able to download new versions of the app.
Relevant log output
No response
Additional context
No response

Please use search before filling a bug
https://github.com/ungoogled-software/ungoogled-chromium-macos/pull/119#issue-1837885892
https://github.com/ungoogled-software/ungoogled-chromium-macos/issues/122
https://github.com/ungoogled-software/ungoogled-chromium-macos/pull/124


CSS

CSS
User Story
As a boot camp student
I want the prework notes to be structured on a webpage
So that I can easily find and read the information
Acceptance Criteria
GIVEN a Prework Study Guide website
WHEN I view the study guide
THEN I see a dark blue header and footer, and four boxes with a shadow

Wasn't a huge fan of the dark blue header, changed to orange for my own fun.


Field validation inconsistent when having mounted/unmounted a field

Are you submitting a bug report or a feature request?

A bug report
What is the current behavior?

When submiting a form after having unmounted/mounted an input field, the fields' validation isn't triggered if you submit the form without having changed the value of the field
What is the expected behavior?
All fields within the component should be validated when clicking submit.
Sandbox Link

In this example there's an input field that requires a value. The first time you click 'show input' and try to submit the form the validation works as expected. However once you hide and show the input field (by using the checkbox), and then submit the form without changing value, the form submits without validating the field:
https://codesandbox.io/s/zn8z9z52p
What's your environment?

React 15.5.3
Redux 3.7.0
Redux-form 7.3.0 (& 7.4.2)
Chrome 67.0.3396.79

Very well reported, thank you. Linking to #2971 as it may or may not be related.

Same issue here :(


[hotfix][docs] Fix the example configuration of pipeline.cached-files.

What is the purpose of the change
The path of cached files should quote by either single (') or double quotes ("), not the back quote (`)
The path will parsed as '`file' when using back quote.

Brief change log

Fix examples of pipeline.cached-files in documents

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.

Hi, @reswqa Could you help review this hotfix?


Support passing a specific connection class to StrictRedisCluster

This cannot be done by using kwargs because kwargs are later passed on to the super init(which is StrictRedis) and it doesn't support arbitrary kwargs, so it fails when trying to pass connection_class as named argument to StrictRedis constructor.
StrictRedis constructor:
 def __init__(self, host='localhost', port=6379,                  db=0, password=None, socket_timeout=None,                  socket_connect_timeout=None,                  socket_keepalive=None, socket_keepalive_options=None,                  connection_pool=None, unix_socket_path=None,                  encoding='utf-8', encoding_errors='strict',                  charset=None, errors=None,                  decode_responses=False, retry_on_timeout=False,                  ssl=False, ssl_keyfile=None, ssl_certfile=None,                  ssl_cert_reqs=None, ssl_ca_certs=None,                  max_connections=None):
This doesn't break any interface.
I need this to use SSL connection class with my cluster connection.

@ilr39 Great find and thanks for the contribution


PYIC-1391 Added KMS Key for DynamoDb Tables

Proposed changes
What changed
Added KMS Key for DynamoDb Tables
Also fixed issues while running cfn-lint on the template.

Why did it change
Added KMS Key for DynamoDb Tables - for chekov tests

Issue tracking

PYIC-1391

Checklists
Environment variables or secrets

[ ] No environment variables or secrets were added or changed

[ ] Documented in the README
[ ] Added to deployment repository
[ ] Added to local startup repository

Other considerations

[ ] Update README with any new instructions or tasks

This branch is seriously out of date to save headache new branch and updates pushed to: https://github.com/alphagov/di-ipv-core-back/pull/452. This is no longer necessary


Timeout on push ?

Sometimes on our app we don't receive push .Is it possible that there is a timeout or something if we don't have internet connection for a long time ? i don't know how many times

If you use pushd to send notifications to the endpoints of google, apple or microsoft, then it is up to them how they schedule your notifications together with the other billions of notifications that they deliver to the different phone. If there is a peak of messages on the network already there might be a delay.

thanks for the answer :) :+1:


Fix x86 Warnings

Codecov Report

Merging #1434 into master will decrease coverage by -0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1434      +/-   ##
==========================================
- Coverage   70.73%   70.52%   -0.22%
==========================================
  Files         142      142
  Lines       19324    19130     -194
  Branches     2366     2345      -21
==========================================
- Hits        13669    13491     -178
+ Misses       4766     4756      -10
+ Partials      889      883       -6

Impacted Files
Coverage Δ

examples/apps/cli/main.c
100% <ø> (ø)
:white_check_mark:

src/core/thread/key_manager.hpp
80% <0%> (-20%)
:x:

src/core/api/thread_api.cpp
36.79% <0%> (-9.53%)
:x:

src/ncp/ncp_base.cpp
33.96% <0%> (-4.44%)
:x:

src/core/common/timer.cpp
89.33% <0%> (-2.67%)
:x:

src/core/thread/mle.cpp
80.71% <0%> (-0.58%)
:x:

src/core/thread/network_data_leader.cpp
80.09% <0%> (-0.5%)
:x:

src/core/thread/network_data_leader_ftd.cpp
68.22% <0%> (-0.47%)
:x:

src/core/common/message.cpp
93.99% <0%> (-0.42%)
:x:

src/core/thread/mle_router.cpp
79.59% <0%> (-0.27%)
:x:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8054fd2...3d83e25. Read the comment docs.


Initiate Repository

github.com/OpenEnergyPlatform/organisation/issues/92
Import features from existing software:

OEO
scientific-ontology-network template
super-repo

The import has been done with the robot library.
~/bin/robot.sh extract --method STAR --input ../OEO/ontology/src/ontology/oeo.omn --term-file term-file\ OEO2OTO.txt --output OTO.owl --catalog ../OEO/ontology/src/ontology/catalog-v001.xml --copy-ontology-annotations true --annotate-with-source true
The term file will also be added to the repository.

I just added some basic files for collaboration and release.

I have also some of the same files prepared here, already adpated to OTO (Contributing, Code_of_Conduct, Readme) they need a few adaptions to specific teams.

Did you use the ones from OEO or super-repo?
Super-Repo has the newest features that will be implemented into the OEFamily step-by-step.

I used the OEO.

I will update the new files with more content if necessary.

I created a project for the first release:
https://github.com/orgs/OpenEnergyPlatform/projects/51/views/1


API fixed_packages issues

from @tdruez
The current implementation of the fixed_packages on the package endpoint is not convient for the data consumer:
{
    'purl'<EMAIL_ADDRESS>    'affected_by_vulnerabilities': [{
        'summary': 'Insufficient Verification of Data Authenticity',
        'vulnerability_id': 'VULCOID-AWK',
     }],
    'fixed_packages': [{
        'fixing_vulnerabilities': [{
            'url': 'http://public.vulnerablecode.io/api/vulnerabilities/14132?format=json',
            'vulnerability_id': 'VULCOID-AWK',
        }],
        'purl'<EMAIL_ADDRESS>        'url': 'http://public.vulnerablecode.io/api/packages/136169?format=json',
    }],
}

To make use of this data, one has to reconcile both affected_by_vulnerabilities and fixed_packages data structure through the vulnerability_id.
This make the data hard to use for display.
A better way would be to include the fixed_packages in the affected_by_vulnerabilities data structure (which seems to be the current implementation on the vulnerabilities endpoint), such as:
{
    'purl'<EMAIL_ADDRESS>    'affected_by_vulnerabilities': [{
        'summary': 'Insufficient Verification of Data Authenticity',
        'vulnerability_id': 'VULCOID-AWK',
        'fixed_packages': [{
            'purl'<EMAIL_ADDRESS>            'url': 'http://public.vulnerablecode.io/api/packages/136169?format=json',
        }],
    }],
}

@TG1999 any thoughts on this?

This would be for a V2 of the API that will come in V31 milestone .... See also #810

As per discussion with @tdruez we can have this change in this version of the API.


Bug: No update to curtain status

Describe The Bug
Curtain status stuck at Open all the time.
To Reproduce
When you set a curtain close at a percentage (1~100%), the curtain does move correctly. But the home app status changes back to 100% open right after.
Expected behavior
Can not open the curtains by home app. Because it stuck at Open status all the them.
Relevant log output
[2022-11-13, 4:47:13 p.m.] [SwitchBot] [DEBUG] Curtain: Living Room openAPIRefreshStatus
[2022-11-13, 4:47:13 p.m.] [SwitchBot] [DEBUG] Curtain: Living Room sign: slyMj9ivaO6sAQBaqw5/ByKV5RhyWlWJ4v2dg6oXmyg=
[2022-11-13, 4:47:14 p.m.] [SwitchBot] [DEBUG] Curtain: Living Room statusCode: 200
[2022-11-13, 4:47:14 p.m.] [SwitchBot] [DEBUG] Curtain: Living Room d: {"statusCode":100,"body":{"deviceId":"F479D00DB650","deviceType":"Curtain","hubDeviceId":"FEAF3FEDE63C","calibrate":true,"group":false,"moving":false,"slidePosition":0},"message":"success"}
[2022-11-13, 4:47:14 p.m.] [SwitchBot] [DEBUG] Curtain: Living Room refreshStatus: {"statusCode":100,"body":{"deviceId":"F479D00DB650","deviceType":"Curtain","hubDeviceId":"FEAF3FEDE63C","calibrate":true,"group":false,"moving":false,"slidePosition":0},"message":"success"}
[2022-11-13, 4:47:14 p.m.] [SwitchBot] [DEBUG] Curtain: Living Room openAPIparseStatus
[2022-11-13, 4:47:14 p.m.] [SwitchBot] [DEBUG] Curtain Living Room CurrentPosition: 100
[2022-11-13, 4:47:14 p.m.] [SwitchBot] [DEBUG] Curtain: Living Room Standby, CurrentPosition: 100
[2022-11-13, 4:47:14 p.m.] [SwitchBot] [DEBUG] Curtain: Living Room Stopped
[2022-11-13, 4:47:14 p.m.] [SwitchBot] [DEBUG] Curtain: Living Room CurrentPosition: 100, TargetPosition: 100, PositionState: 2,
[2022-11-13, 4:47:14 p.m.] [SwitchBot] [DEBUG] Curtain: Living Room CurrentAmbientLightLevel: 6001
[2022-11-13, 4:47:14 p.m.] [SwitchBot] [DEBUG] Curtain: Living Room updateCharacteristic CurrentPosition: 100
[2022-11-13, 4:47:14 p.m.] [SwitchBot] [DEBUG] Curtain: Living Room updateCharacteristic PositionState: 2
[2022-11-13, 4:47:14 p.m.] [SwitchBot] [DEBUG] Curtain: Living Room updateCharacteristic TargetPosition: 100
[2022-11-13, 4:47:14 p.m.] [SwitchBot] [DEBUG] Curtain: Living Room updateCharacteristic CurrentAmbientLightLevel: 6001

Config for homebridge-switchbot
{
            "name": "SwitchBot",
            "credentials": {
                "token": "xxx",
                "secret": "xxx",
                "notice": "Keep your Token & Secret a secret!"
            },
            "options": {
                "logging": "debug"
            },
            "_bridge": {
                "username": "0E:66:1E:83:C5:66",
                "port": 59580
            },
            "platform": "SwitchBot"
        }

Screenshots
Recently updated SwitchBot hub mini firmware version to V5.2-3.3
Device & Model
SwithBot curtain
Node.js Version
v16.18.0
NPM Version
v8.19.2
Homebridge Version
v1.5.1
Homebridge Switchbot Plugin Version
v2.2.2, and v2.3.0-beta.2
Homebridge Config UI X Plugin Version
v4.50.2
Operating System
Raspbian

Also the SwitchBot light level sensor always return at 6001 lux

Just noticed that SwitchBot app cannot connect to the curtains over cloud. It can be used over Bluretooth while at home. I am thinking this should be related to the hub firmware update.

Hi. I’m experiencing the same since updating my Switchbot Hub Mini to firmware V5.2-3.3. Curtains constantly show as Open in the app. It’s not possible to open the curtains using Home app or Siri (I assume because Home thinks they are already open)

Just noticed that SwitchBot app cannot connect to the curtains over cloud. It can be used over Bluretooth while at home. I am thinking this should be related to the hub firmware update.

Wanted to chime in that I am having the same issue as this and the comment from AKWillows.

I contacted SwitchBot, and they just solved this issue on the server end. Now my Home app status can be updated properly. As you know it's 3:00 am local time in China. SwitchBot really care about their customers. I am not sure if the server end fix will apply to all users or not. If not please don't hesitate to contact them.

@jonpeng  Hi… after reading this, i checked my setup and it wasn’t fixed - even after rebooting the bridge.  So, it appears it was only fixed for you - unless I’m missing something? I emailed their support but I’ve been asked to complete feedback via the app so that they can “investigate’. Are you able to share the detail of who you contacted and what you actually asked please? Thank you!

For me the is this also not solved.

@AKWillows @Minsheng @SwitchBot With this firmware update issue, SwichBot app home page should not show the correct curtain status via cloud/Internet.

@jonpeng My Switchbot app is showing the correct status of the curtains and also showing that they are connected via cloud. The Apple Home app is still showing them permanently open.
Although I initially used the Support form at the @SwitchBot @SwitchBot-Wonderlabs website, the request is showing as a ticket in the Feedback section of the app. The latest response is “we will forward your problem to our tech team for further assistance. “ at about 9.30 this morning (UK time).

@AKWillows You can't trust the little cloud icon on the SwitchBot app, and determine the connection is over internet. To do the test correctly, you need to away from SwitchBot hub and other SwitchBot products. And only the home page of SwitchBot app doesn't update the status. Once you click into the individual curtain, the status shows correct.

@jonpeng Yes… it shows the cloud in the app when I’m away from home. I’ve had no issues with the Switchbot app…. Just Apple Home app via this homebridge plugin. I thought that was what Switchbot were able to fix for you?

@AKWillows Then mine was different. The following screen shots was my issues before they did the server end fix.

@jonpeng …oh, but this thread is about the switchbot plugin for homebridge … and that was what your initial post shows the log for. And you refer to the Home app and the log and config screenshots are for the Homebridge plugin. So it would appear that the action switchbot took has fixed the SWITCHBOT app for you. the homebridge issue is NOT fixed then?

@AKWillows I noticed the Home app status issue first. So I posted this thread here. I thought it was the plugin issue. Later on, I noticed the SwichBot app has this status issue as well when I away home. I was thinking that should be the same issue from the recent hub firmware update. So I contacted SwitchBot support. After they fixed the SwitchBot app issue, Home app backed to normal.

@jonpeng ah ok. I’ll open a new ticket here tomorrow for my problem then as this one is closed now and,unless Switchbot come back to me with anything I don’t think it will get resolved


kube-aws: cloudformation tags

Currently there is no way to specify tags to apply to the created cloudformation stack. Many companies use tags to audit their AWS environment and do cost analysis. This pull request adds the ability to specify cloudformation resource tags as a list of key-value pairs (string -> string) in the cluster.yaml file

@orkhanM looks good. Can you squash up w/ a commit message along the lines of kube-aws: cloudformation stack tag functionality

@orkhanM squash this up and we should be good to merge.

@orkhanM we should really have unit tests for this, but there is significant restructuring of how cluster.Create() function works in order for that to be possible. I'll \cc you when we have another PR which restructures the code in order to make it testable. (ref #415)
I have two more nits for you to address before we merge. Sorry about that.
Thanks for the contribution!

@colhom sounds good, I've made the changes you requested and re-squashed. Let me know when you can merge this in.

Thanks @orkhanM


cmd/go: spurious error about GOBIN during cross-compile

The error in title is the result of: GOARCH=386 go install -x
But $GOBIN is NOT set!
How do I install cross-compiled binaries now?
go version devel +aadd84e Sat Jul 18 01:35:25 2015 +0000 linux/amd64
Basically go1.5beta2 + some fixes

Looks like my attempt to fix #9769 is overzealous. Taking a look.

I suspect the way you are trying to use go install should fail, it's just a slightly confusing error message. When you go install mycmd, it typically installs in $GOPATH/bin, or if it's set, $GOBIN. When cross compiling, there is really no good place to do the installation. Both of those bin directories are designed to be on your $PATH, so creating subdirectories does not make sense.
In general with your own programs, you should go build cross-compiled binaries, not go install them. You can use -o to specify where you want the binary to end up.
However cross-compile go installs of cmd/* binaries should work, except cmd/go when GOBIN is set. It looks like that's one case I missed, so I'm looking at it and improving the error message.

Makes sense. I changed my rules from:
go install -x
GOARCH=386 go install -x

to
go install -x
GOARCH=386 go build -x -o $(GOBIN)/linux_386/binary

and it's now working as before.
Though, to be honest, I liked the previous way better, less typing, more streamlined rules for building. 386 binaries are executable on the amd64 platform, so makes sense to have them in the subdirectory of $GOPATH/bin.
If this change in policy is final, certainly the error message should be improved to tell that go install won't work for cross-compiling and that go build -o should be used.

Oh, few minutes later I see another bad consequence of this change in policy. go build is not the same as go install, now if I run it again it's again rebuilding from the scratch, even if there were no changes in the source code and the binary is up-to-date. go install is clever not to rebuild if not needed.
Now, seeing this behaviour, I don't like this policy change at all. There should be a way to go install even for cross-compiling, IMHO.

You should probably take up the issue of whether or not it is a good idea on #9769. I tend to think of cross compilation as a special case, but I see your point.

I left a note on #9769, too. Although, I'm still a bit puzzled, #9769 specifically mentions creating subdirectories under $GOBIN as problematic, where I see behaviour change even without $GOBIN set.

I'd just like to point out how problematic this issue is: When cross-compiling an executable, all dependencies are cross-compiled as well. This means that without functional cross compilation support for go install, all dependencies are rebuilt every time the end user's executable is built, which takes a lot of time.

I hit the same error and wonder what needs to be done to avoid rebuilding all the standard library dependencies on every invocation of GOOS=linux go build (when cross-compiling on a Mac).

The go build command has a -i flag that can be used when cross compiling.

@crawshaw Cool, that helps! It saves a lot of time when compiling. But of course it would still be great if with the release of Go 1.5 the build system will enable avoiding any gratuitous compilation when cross-compiling, even if it's just the end user's binary.

Came across this issue when trying beta2 out. Would also prefer the old behavior.

Error message text, so that it is possible to find this issue by exact text:
go install: cannot install cross-compiled binaries when GOBIN is set

This change completely breaks my cross-compilation workflow and is very frustrating. (GOBIN is not set)

FWIW, you should be able to say GOARCH=xxx go install -buildmode=archive prefix/... to only compile and install the non-main packages.


Add three more proxy-related headers and examples

Credit for these goes to Andres Tarasco Acuna, via his
random-ip-address-header Burp App.
https://github.com/PortSwigger/random-ip-address-header

Nice idea!


Ideas on making "Series description" look better?

@mccalluc what are our options here?

Two possibilities come to mind:

Ad-hoc regex: s/(\d\d\d--)/\n$1/g
Or edit the data in the database to include newlines where we need them.

and in either case respect NLs when rendering the HTML.
@Muraszko : would it be possible to get this bit of formatting in to the source data?

I think putting newlines in the database would be better, if that's not too troublesome

@Muraszko : I have a PR in to respect double lines as formatting. Assigning this to you clean up source data, at your convenience.


"on error"  isn't translated

In the edit cells > transform windows expression, the string "on error" have been translated in Italian, French or Chinese but it isn't displayed. See here for example:

I trace it down to this line but I don't see anything wrong with it: https://github.com/OpenRefine/OpenRefine/blob/9b2a506caada4ea6d580d2140184fef8caa7566c/main/webapp/modules/core/scripts/views/data-table/menu-edit-column.js#L103

Thanks for the bug report.  If the code is correct, the next place to check is the French translation.

This affect all translation, not just the French one. So I think it comes
from the core, but I haven't been able to narrow the root cause.
On Apr 21, 2015 1:43 PM, "Tom Morris"<EMAIL_ADDRESS>wrote:

Thanks for the bug report. If the code is correct, the next place to check
is the French translation.
—
Reply to this email directly or view it on GitHub
https://github.com/OpenRefine/OpenRefine/issues/980#issuecomment-94884209
.

https://github.com/OpenRefine/OpenRefine/blob/master/main/webapp/modules/core/scripts/views/data-table/text-transform-dialog.html

Should I expect a pull request for this?

I personally don't have the knowledge to fix that.

I will help with this to create a PR to fix this.


logrotate: add logrotate functionality for csi

Describe what this PR does

Make main container and csi addons container
log to a file(dependency on klog)

Add a log-rotate sidecar container,
so it can rotate the logs

Added other volume and volumemounts as needed

Added the privileged option for controllerplugin

Provide some context for the reviewer
Is there anything that requires special attention
Do you have any questions?
Is the change backward compatible?
Are there concerns around backward compatibility?
Provide any external context for the change, if any.
For example:

Kubernetes links that explain why the change is required
Ceph-CSI spec related changes/catch-up that necessitates this patch
golang related practices that necessitates this change

Related issues
Mention any github issues relevant to this PR. Adding below line
will help to auto close the issue once the PR is merged.
Fixes: #issue_number
Future concerns
List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.
Checklist:

[ ] Commit Message Formatting: Commit titles and messages follow
guidelines in the developer
guide.
[ ] Reviewed the developer guide on Submitting a Pull
Request
[ ] Pending release
notes
updated with breaking and/or notable changes for the next major release.
[ ] Documentation has been updated, if necessary.
[ ] Unit tests have been added, if necessary.
[ ] Integration tests have been added, if necessary.

@nb-ohad @Madhu-1 ^^

Testing:
[rider@localhost rbac]$ oc exec -it test.rbd.csi.ceph.com-nodeplugin-tg25d -n ceph-csi-operator-system  -c log-collector sh
kubectl exec [POD] [COMMAND] is DEPRECATED and will be removed in a future version. Use kubectl exec [POD] -- [COMMAND] instead.
sh-4.4#
sh-4.4# ls
bin  csi-logs  dev  etc  home  lib  lib64  logrotate-config  lost+found  media	mnt  opt  proc	root  run  sbin  srv  sys  tmp	usr  var
sh-4.4# cd csi-logs/
sh-4.4# ls
csi-rbdplugin.log
sh-4.4#
sh-4.4# cd ..
sh-4.4# cd logrotate-config/
sh-4.4# ls
csi
sh-4.4# cat csi

/csi-logs/*.log {
	daily
	missingok
	rotate 5
	compress
	copytruncate
	notifempty
    maxsize 500M
}sh-4.4# cd ..
sh-4.4# cd csi-logs/
sh-4.4# ls
csi-rbdplugin.log
sh-4.4# truncate -s 600M csi-rbdplugin.log
sh-4.4# ls -lh
total 4.0K
-rw-r--r-- 1 root root 600M Aug  7 18:47 csi-rbdplugin.log
sh-4.4#
sh-4.4#
sh-4.4# cd ..
sh-4.4# cd csi-logs/
sh-4.4# logrotate --verbose csi
error: cannot stat csi: No such file or directory
Reading state from file: /var/lib/logrotate/logrotate.status
Allocating hash table for state file, size 64 entries

Handling 0 logs
sh-4.4#
sh-4.4#
sh-4.4# ls
csi-rbdplugin.log
sh-4.4# cd ..
sh-4.4# cd logrotate-config/
sh-4.4# logrotate --verbose csi
reading config file csi
Reading state from file: /var/lib/logrotate/logrotate.status
Allocating hash table for state file, size 64 entries

Handling 1 logs

rotating pattern: /csi-logs/*.log  after 1 days (5 rotations)
empty log files are not rotated, log files >= 524288000 are rotated earlier, old logs are removed
considering log /csi-logs/csi-rbdplugin.log
Creating new state
  Now: 2024-08-07 18:48
  Last rotated at 2024-08-07 18:00
  log needs rotating
rotating log /csi-logs/csi-rbdplugin.log, log->rotateCount is 5
dateext suffix '-20240807'
glob pattern '-[0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9]'
renaming /csi-logs/csi-rbdplugin.log.5.gz to /csi-logs/csi-rbdplugin.log.6.gz (rotatecount 5, logstart 1, i 5),
old log /csi-logs/csi-rbdplugin.log.5.gz does not exist
renaming /csi-logs/csi-rbdplugin.log.4.gz to /csi-logs/csi-rbdplugin.log.5.gz (rotatecount 5, logstart 1, i 4),
old log /csi-logs/csi-rbdplugin.log.4.gz does not exist
renaming /csi-logs/csi-rbdplugin.log.3.gz to /csi-logs/csi-rbdplugin.log.4.gz (rotatecount 5, logstart 1, i 3),
old log /csi-logs/csi-rbdplugin.log.3.gz does not exist
renaming /csi-logs/csi-rbdplugin.log.2.gz to /csi-logs/csi-rbdplugin.log.3.gz (rotatecount 5, logstart 1, i 2),
old log /csi-logs/csi-rbdplugin.log.2.gz does not exist
renaming /csi-logs/csi-rbdplugin.log.1.gz to /csi-logs/csi-rbdplugin.log.2.gz (rotatecount 5, logstart 1, i 1),
old log /csi-logs/csi-rbdplugin.log.1.gz does not exist
renaming /csi-logs/csi-rbdplugin.log.0.gz to /csi-logs/csi-rbdplugin.log.1.gz (rotatecount 5, logstart 1, i 0),
old log /csi-logs/csi-rbdplugin.log.0.gz does not exist
log /csi-logs/csi-rbdplugin.log.6.gz doesn't exist -- won't try to dispose of it
copying /csi-logs/csi-rbdplugin.log to /csi-logs/csi-rbdplugin.log.1
truncating /csi-logs/csi-rbdplugin.log
compressing log with: /bin/gzip

sh-4.4#
sh-4.4#
sh-4.4# cd ..
sh-4.4# cd csi-logs/
sh-4.4# ls
csi-rbdplugin.log  csi-rbdplugin.log.1.gz

@Madhu-1 This PR is ready to be merged, but merging is blocked on a change request that you have asked for that is already resolved. Can you please add your approved review so we can merge this?

/hold more manual testing nedded

Testing results:
[rider@localhost dist]$ kubectl get pod -nceph-csi-operator-system  -o wide
NAME                                                    READY   STATUS    RESTARTS   AGE     IP               NODE           NOMINATED NODE   READINESS GATES
ceph-csi-operator-controller-manager-5b85f8c9b8-jbcns   2/2     Running   0          28m     <IP_ADDRESS>       minikube-m02   <none>           <none>
test.rbd.csi.ceph.com-ctrlplugin-54b744ff6c-chht6       6/6     Running   0          27m     <IP_ADDRESS>       minikube-m03   <none>           <none>
test.rbd.csi.ceph.com-nodeplugin-dn4ww                  3/3     Running   0          27m     <IP_ADDRESS>    minikube-m03   <none>           <none>
test.rbd.csi.ceph.com-nodeplugin-s62ts                  3/3     Running   0          3m40s   <IP_ADDRESS>   minikube       <none>           <none>
test.rbd.csi.ceph.com-nodeplugin-vj2f2                  3/3     Running   0          27m     <IP_ADDRESS>    minikube-m02   <none>           <none>
[rider@localhost dist]$
[rider@localhost dist]$ kubectl exec -it test.rbd.csi.ceph.com-nodeplugin-dn4ww  -nceph-csi-operator-system -c log-rotator sh
kubectl exec [POD] [COMMAND] is DEPRECATED and will be removed in a future version. Use kubectl exec [POD] -- [COMMAND] instead.
sh-4.4# ls
bin  csi-logs  dev  etc  home  lib  lib64  logrotate-config  lost+found  media	mnt  opt  proc	root  run  sbin  srv  sys  tmp	usr  var
sh-4.4# cd logrotate-config/
sh-4.4# cat csi
/csi-logs/*.log {
	missingok
	compress
	copytruncate
	notifempty
	rotate 5
	daily
	maxsize 500M
}
sh-4.4# cd ..
sh-4.4# cd csi-logs/
sh-4.4# ls
csi-rbdplugin.log
sh-4.4# cat csi-rbdplugin.log
Log file created at: 2024/08/16 08:10:18
Running on machine: minikube-m03
Binary: Built with gc go1.21.5 for linux/amd64
Log line format: [IWEF]mmdd hh:mm:ss.uuuuuu threadid file:line] msg
W0816 08:10:18.759665   17582 util.go:276] kernel 5.10.57 does not support required features
W0816 08:10:18.760132   17582 rbd_attach.go:252] kernel version "5.10.57" doesn't support cookie feature
sh-4.4#
sh-4.4#
sh-4.4# truncate -s 600M csi-rbdplugin.log
sh-4.4#
sh-4.4# ls -lh
total 4.0K
-rw-r--r-- 1 root root 600M Aug 16 08:15 csi-rbdplugin.log
sh-4.4#
sh-4.4# exit
exit
[rider@localhost dist]$ kubectl logs  test.rbd.csi.ceph.com-ctrlplugin-54b744ff6c-chht6  -nceph-csi-operator-system -c log-rotator
reading config file /logrotate-config/csi
Reading state from file: /var/lib/logrotate/logrotate.status
Allocating hash table for state file, size 64 entries

Handling 1 logs

rotating pattern: /csi-logs/*.log  after 1 days (5 rotations)
empty log files are not rotated, log files >= 524288000 are rotated earlier, old logs are removed
considering log /csi-logs/*.log
  log /csi-logs/*.log does not exist -- skipping
Creating new state
[rider@localhost dist]$
[rider@localhost dist]$
[rider@localhost dist]$ cd ..
[rider@localhost ceph-csi-operator]$ git add .
[rider@localhost ceph-csi-operator]$
[rider@localhost ceph-csi-operator]$
[rider@localhost ceph-csi-operator]$
[rider@localhost ceph-csi-operator]$
[rider@localhost ceph-csi-operator]$ kubectl exec -it test.rbd.csi.ceph.com-nodeplugin-dn4ww  -nceph-csi-operator-system -c log-rotator sh
kubectl exec [POD] [COMMAND] is DEPRECATED and will be removed in a future version. Use kubectl exec [POD] -- [COMMAND] instead.
sh-4.4# cd /csi-logs/
sh-4.4# ls
csi-rbdplugin.log  csi-rbdplugin.log.1.gz
sh-4.4#

@nb-ohad PTAL and merge it if everything is good.

@parth-gr may i know the recent change you pushed after i approved the PR?

LGTM
@Madhu-1 Are you ok with the state of the PR?


Close issue #866, Adding cloning of file name state of XmlSuite class

Here is the src change. There wasn't a unit test for this functionality, no unit test add/update in this PR.

Thanks!

:+1:


Separate modules for all services

An investigation for #80 that likely shouldn't be merged.

@jonnymacs what're your feelings about this? The tests are failing because the S3 tests themselves are hanging, but I can take a look after we sort out this idea. I think this would be a precursor to your work renaming the modules as we're automatically generating the names, but I don't want to push this through unless you're good with it too 👍

@Yasumoto ok yeah, this code builds module names off the directory structure. So should not need any changes once i get #78 finished.
I'm on board with this. Let's move forward with it.


What does the future look like for this project?

Given that this project hasn't seen much activity and that it used as a key dependency in several prominent projects (both opensource and private), I would like to know what are the maintainers' plans in the long term.

After getting a few v2.X releases out, the plan is to focus on v3 release. There is no ETA, but we're hoping it'll be out by the end of this year. I'm closing this issue, feel free to reopen or ask in CNCF community slack


Browser Extension "Play to Kodi" not working

share to kodi with chrome extensions "Play to Kodi", log:
2019-07-02 00:40:29.078 T:1937846288 ERROR: Playlist Player: skipping unplayable item: 0, path [plugin://plugin.audio.soundcloud/play/?audio_id=300297076]

See : https://github.com/jaylinski/kodi-addon-soundcloud/issues/13#issuecomment-507418132
This should be working according to the exposed API.

I could only reproduce the skipping unplayable item-error once, after that, another problem appeared. The addon adds the item correctly to the playlist, but since the chrome extension doesn't explicitly call "play", the item is not played. (In contrast to https://github.com/jaylinski/kodi-echo, which explicitly calls play.)
I think applications calling the public /play/ endpoints are right to expect the items to be played automatically, so I tried to add it. But currently Kodi is crashing as soon as I add a xbmc.Player().play() call. I will have to investigate why the code is crashing Kodi...

This was probably fixed with #20. But I could not test it, because the extension "Play to Kodi" doesn't even send a request... (maybe it's broken)
Fix will be released in v3.1.0.
@efirshik If the problem persists in the new version, feel free to open a new issue.


Minimum required version of activesupport is incorrect. Should be >= 5.0

Bug report
Added this to a rails 4.2 project and ran it and got this
kubernetes-deploy/duration_parser.rb:19:in `rescue in parse!': uninitialized constant ActiveSupport::Duration::ISO8601Parser (NameError)
	from /Users/jordan/.rvm/gems/ruby-2.4.3/gems/kubernetes-deploy-0.18.0/lib/kubernetes-deploy/duration_parser.rb:17:in `parse!'
	from /Users/jordan/.rvm/gems/ruby-2.4.3/gems/kubernetes-deploy-0.18.0/lib/kubernetes-deploy/kubernetes_resource.rb:313:in `validate_timeout_annotation'
	from /Users/jordan/.rvm/gems/ruby-2.4.3/gems/kubernetes-deploy-0.18.0/lib/kubernetes-deploy/kubernetes_resource.rb:81:in `validate_definition'
	from /Users/jordan/.rvm/gems/ruby-2.4.3/gems/kubernetes-deploy-0.18.0/lib/kubernetes-deploy/concurrency.rb:13:in `each'
	from /Users/jordan/.rvm/gems/ruby-2.4.3/gems/kubernetes-deploy-0.18.0/lib/kubernetes-deploy/concurrency.rb:13:in `block (2 levels) in split_across_threads'

Expected behavior: [What you expected to happen]
It should have run successfully since the minimum active support version in the gemspec is set at >=4.2
Actual behavior: [What actually happened]
It failed
Version(s) affected: [run kubernetes-deploy --version]
0.18.0
I believe this fails because ActiveSupport::Duration::ISO8601Parser wasn't added until activesupport 5.0.

Thanks for spotting this bug. Looks like ISO8601Parser
was added in 5.0 given: http://api.rubyonrails.org/v5.0/classes/ActiveSupport/Duration.html & http://api.rubyonrails.org/v4.2/classes/ActiveSupport/Duration.html. We'll get this fixed up.


Generalize dbm to support different SQL engines

Currently, SQLite is used as the sole SQL backend for the tower. However, the tower should allow having different SQL backends pickable during compilation.
Generalize the DBM so other backends can be added.
Further info: https://www.summerofbitcoin.org/project-ideas-details?recordId=rec7YMzzxpapE1d38
DISCLAIMER
This is a Summer Of Bitcoin (SOB) project. If you're considering tackling this but you are not part of SOB, please leave it until SOB is over. After that, feel free to jump in.

Hi, i came from summerofbitcoin, can i start working on this?

I'm interested into working on this one as I've some experience in working with relational databases. Besides I'm also the part of SOB. It'd be great if you could point out some relevant resources that would help me in drafting my proposal asap.

Hi @SpoonBuoy, the main resources are the ones listed in the SoB proposal. If you have any particular question, feel free to reach out using Slack, some other applicants have been asking questions there so you may find some of them useful.

Hi @sr-gi , I wanted to update you on my progress with the competence tests. I'm happy to report that I have successfully completed the first two tests, which were to compile rust-teos, run the tower, and run the test suite.
However, I'm feeling a bit stuck on the third test, which is to create a basic example of loading, storing, and updating data to the teos database. I'm not sure where to start with this, and I could use some guidance.
Would you be able to provide me with some direction or resources that could help me get started on this task? I'm eager to continue learning and growing my skills, and I'm confident that with your help, I'll be able to successfully complete this test as well.
Thanks for your help and support!


sending small amount from BTC wallet may have issue

step to try to reproduce:

create invoice from c-lightning with 20 sats amount in a not well connected node
pay from the freecorn cluster

the error message saying the amount was incorrect
after retrying multiple time, the error message changed to route error

@UncleSamtoshi can you double check if you can reproduce once the facade has been merged? we can close if we can't reproduce.


list apphooks cleanup

Fix #3776
Proposed output:
Example1App (draft)
NamespacedApp[instance: namespaced_app_ns] (draft)
ChildApp (draft)

@FinalAngel @mkoistinen Please review

No docs needed as it's just a display change

alright LGTM :)

@intellectronica , @mkoistinen any comment?

Looks real good! :+1:


Twilio Voice JS SDK : Immediate Disconnect when trying to Call

I have a in-browser calling system built on this code base:
https://github.com/TwilioDevEd/voice-javascript-sdk-quickstart-php
The system that I built was working for over a year, and recently it stopped working and cannot make any calls. The token seems properly generated and the system becomes "ready", but then fails when trying to make the call. When instantiating a call, the system immediately issues a disconnect.

I double checked the API keys, and established new API Keys (no change in issue)
The issue exists on the pure codebase found in the /voice-javascript-sdk-quickstart-php

The screenshot here shows the issue.
Screenshots

The code here is using:
Twilio.js: var RELEASE_VERSION = '2.4.0';  (Issue also exists in 2.1.1)
PHP Version 7.4.30 (Also present in PHP Version 8.1.10)
Twilio PHP 6.4.4
Desktop (please complete the following information):

OS: Windows 10
Browsers: Chrome and Firefox  Latest

Please let me know if anyone might have more insight into this issue or how I may further debug the issue and get more insights into the possible cause. Thank you.

This isn't a code issue, it's a device issue. Sorry for the bother!


Feature: add delete_unverified parameter to optimize operation

SDK
Node, Python
Description
Sometimes users will want to force a cleanup faster, but we don't expose this parameter to them.
https://lancedb.github.io/lance/api/python/lance.html#lance.LanceDataset.cleanup_old_versions
See example in: #1526

This has been added in Node, but still needs to be added in Python.


Create release notes for GOV.UK Frontend v4.3.1 (fix release)

What
Create release notes for GOV.UK Frontend v4.3.1 (fix release)
Why
To tell users about the fixes we've made.
Who needs to work on this
Technical Writer, Developers
Who needs to review this
Developers
Done when

[x] Technical writer / developer drafts release notes
[x] Not required for fix release - Release notes pass 2i
[x] PR raised for updating the release notes in the Changelog

2i not required for fix release notes, I'll share them (along with any drafted comms) with the team to look over.


cmd/list: --formula is no longer a default.

This behaviour is disabled.

Review period will end on 2020-11-26 at 13:48:13 UTC.

Review period skipped due to critical label.


Fix fileds Naming Issue

-Issue

In the resource_connector :  user-agent , client_secret' and 'developer_token' all of them are mapping to the same value "client_id"

Solution:
Correct mapping

Looks like tests failing because the PR os from outer contributor. I've just checked it on our internal PR - it works fine.

Fix will be included to next release at May 4-th


Add Simplified Chinese localization

Although there is already another translation, I'm convinced that this version is more natural and coherent than that one.

Hey, thanks for the PR!
I don't know Chinese, so maybe @meows6 can help review? This PR seems closer to the edits I will have to make, so I think I'm going to go with this one. (No hard feelings @meows6!)

Hey, thanks for the PR!
I don't know Chinese, so maybe @meows6 can help review? This PR seems closer to the edits I will have to make, so I think I'm going to go with this one. (No hard feelings @meows6!)

This PR is better,please merging this PR

Thanks a lot @refparo and @meows6! This is a huge help because I think a significant portion of the users speak Chinese.


Fix auto-keyframing to work with inspector properties

Closes https://github.com/godotengine/godot/issues/36140 https://github.com/godotengine/godot/issues/6201
Rationale for opening this PR:
I initially needed to fix https://github.com/godotengine/godot/issues/36140 because our artists were complaining about the state of the animation editor since they're used to the workflow of other engines (copy paste for keyframes is my next target).
However while doing that bugfix, I found it low-hanging fruit to go for https://github.com/godotengine/godot/issues/6201  as well which has been bothering us for over a year now (I commented on the issue in January of last year).
Comparing to other engines you can see that a Record button is a sensible proposition that makes artists' lives much easier.
Unity has a record button that allows you to switch between manual and auto keyframing:

Cocos Creator has only one mode to edit animations, and that is auto keyframing:

I hope to get some feedback to know whether I am headed in the right direction.
Current State of PR
Previously auto-keying only worked when node transforms were edited with gizmos. This PR fixes/expands the auto-keying behaviour to also work when values are modified in the inspector tab.
Now it also works for all properties, not only transforms, as long as a track for it already exists. Supports undo-redo with no extra effort.
The new auto-keyframing behaviour is currently toggled with the existing auto-key "Car" button in the canvas item editor:

The other toggles (loc, rot, and scl) still work as before i.e. they insert a keyframe if the canvas item was moved in the viewport.
What this needs to become a full PR:

Potentially add a separate "Record mode" button, either in the top bar or down in the animation panel.
Potentially remove the "Car" icon from the canvas editor toolbar (and the loc, rot, scl icons beside it) if it becomes redudant.
Either access the "auto-capture" boolean cleanly from inside the editor inspector without exposing protected variables OR connect to a signal from outside the editor inspector class and handle the keyframing there (e.g. in the animation editor).

I'm already happy with this change and have compiled release binaries for our team, and I think it would take little work to make this PR up to the engine standards if we reach a consensus.
Binary ready for QA (based on the 3.2.x branch): https://mega.nz/#!QdVlyCIa!5is9G7FowZi9Xa89XvD2lNWKvELY2snBUjZ05NwJgyQ

Is there anything 2D-specific about this PR? I would like this same functionality in 3D, for example recording keyframes onto a skeleton.
also some usecases for doing this at runtime, e.g. skeleton mocap, were discussed at GDC. and then the generated Animation resource could be saved to a .res file

@TokageItLab do you think this is still wanted?


Added Form Design Content

Fixes #290

No need to be sorry! Thanks for catching those, @dsaludares! Updated!

Thank you, @loganfranken!


r3nzskin doesnt work?

why?

install c++ redistributable 2015-2022 and .net framework 4.8.1

It worked thx


Magento v2.4.3(-p[123])? also affected?

Hey,
du you know if Magento v2.4.3(-p[123])? is also affected and need to be patched?

It is effected, there is a full-on patch available from Magento's side, but we ( @mooore-digital ) will be working on implementing patches for these soon too!

Can you refer the Magento official patch?
Only found this: https://helpx.adobe.com/security/products/magento/apsb22-48.html

@tim-breitenstein-it Those are the official patches but they're only available for Magento 2.4.5 and Magento 2.4.4. That's why we're working on creating separate patch files.


Add Tooltip shortcode

Feature Description
Add a shortcode to show a tooltip that the user can hover over to get extra information.
Problem/Solution
Docs sites often contain words of phrases that the reader isn't very familiar with. Adding a tooltip allows the reader to quickly find out (or remind themselves) what a particular word of phrase means. This is especially helpful when documentation contains lots of acronyms.
Shortcode usage could look something like this:
Lorem ipsum {{< tooltip "Dormouse" >}} more latin [...]

There would likely need to be a configuration file to list all the available tooltips and their descriptions.
Alternatives Considered

Create a separate Glossary page that the user needs to reference.
Add definitions for each uncommon word, phrase, or acronym.

Additional Context
The Flowbite framework (build with Tailwind, I believe) has built something similar: https://flowbite.com/docs/components/tooltips

I've done something like this by putting the terms in a YAML datafile and then making two separate shortcodes, one to generate a glossary and one to create tooltips:
https://wellshapedwords.com/posts/hugo-manage-terminologies/#more-uses-of-the-termbase
The only thing that bothers me about it is that it becomes tedious to write a bunch of abbr shortcodes. Sometime I'd like to experiment with using render hooks instead.


Warning Using Guard

Hello, I found a bug when using the version 0:12 this project with the guard 2.13.0.
I made some changes that corrected this problem.
If you want, I can submit a pull request.
Below are the error information
home/marcelo/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/guard-webpack-0.1.2/lib/guard/webpack.rb:2:in `module:Guard': superclass must be a Class (Module given) (TypeError)

Oh, thanks for catching this! If you'd be willing to submit a PR, I'd definitely appreciate it! I'm afraid I'm a bit swamped at the moment, so I might not be able to get to this until next week. Cheers!


Make chunked encoding test more resilient

Replace fixed port with auto selected port.

Cherry-picked to v9.0.x branch.


DateFromJulianDay : day is out of range for month

The following was raised in https://github.com/SciTools/cf_units/issues/77:
>>> import cftime
>>> cftime.DateFromJulianDay(2450022.5, "standard")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "cftime/_cftime.pyx", line 709, in cftime._cftime.DateFromJulianDay
ValueError: day is out of range for month

I haven't taken the time to dig further into this, but looks like reasonable input to the function.
When doing a bit of digging, I also tried:
>>> cftime.DateFromJulianDay(2450022.5, "standard", only_use_cftime_datetimes=True)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "cftime/_cftime.pyx", line 709, in cftime._cftime.DateFromJulianDay
  File "cftime/_cftime.pyx", line 1759, in cftime._cftime.DatetimeGregorian.__init__
  File "cftime/_cftime.pyx", line 1903, in cftime._cftime.assert_valid_date
ValueError: invalid day number provided in cftime.DatetimeGregorian(1995, 10, 32, 23, 59, 59, 999952, -1, 1)

Thanks @pelson for the report. This does seem like a bug.

pull request #65 fixes this (by re-introducing an old bug fix that was somehow lost)

fixed now in master, closing


OSD-10044 Add cluster ID to OCM Agent config

What type of PR is this?
Feature
What this PR does / why we need it?
OCM Agent requires the cluster's cluster ID in order to send Service Logs to OCM.
Given the cluster ID is always static, and rather than complicate OCM Agent by having it need to look it up itself, it makes more sense for OCM Agent Operator to collect the cluster ID and populate it for OCM Agent as config.
It will arrive to OCM Agent in the form of a clusterID ConfigMap key.
A PR for OCM Agent to acknowledge and read the cluster ID as a config item will arrive separately but is not required for this PR to be merged.
Which Jira/Github issue(s) this PR fixes?
OSD-10044
How to test
Note that this PR requires additional RBAC if you are testing via an image deployed on-cluster and running as the ocm-agent-oeprator ServiceAccount, notably this addition to the ClusterRole: https://github.com/mrbarge/ocm-agent-operator/blob/8419e0e602771b47df505df797850c58eca4e316/deploy/20_ocm-agent-operator.ClusterRole.yaml#L33
If you are testing locally via kubeadmin, no additional RBAC is required.
To test, simply run the operator and verify that the ocm-agent-config ConfigMap contains a clusterID key after the operator's successful reconcile.
$ oc get cm -n openshift-ocm-agent-operator ocm-agent-config -o yaml

Pre-checks (if applicable):

[X] Tested latest changes against a cluster
[ ] Ran make generate command locally to validate code changes
[ ] Included documentation changes with PR

Codecov Report

Merging #23 (5eae290) into master (9092834) will decrease coverage by 0.13%.
The diff coverage is 52.94%.

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   53.77%   53.64%   -0.14%
==========================================
  Files          19       19
  Lines         794      809      +15
==========================================
+ Hits          427      434       +7
- Misses        325      331       +6
- Partials       42       44       +2

Impacted Files
Coverage Δ

cmd/manager/main.go
0.00% <0.00%> (ø)

pkg/consts/ocmagenthandler/ocmagenthandler.go
100.00% <ø> (ø)

pkg/ocmagenthandler/ocmagenthandler_configmap.go
70.96% <64.28%> (-3.04%)
:arrow_down:

@mrbarge I test this with running an operator locally against a stg cluster and it worked as expected by populating my cluster's external id into the ocm-agent configmap.
/lgtm


"bs5-card-grid" shortcut gives a template with the deprecated "xs" breakpoint

In modern bootstrap the breakpoint "xs" is deprecated since it is the default

Thank you for reporting. We will add it to our backlog. Will fix those in our next release.

@anburocky3  @StefanoMiC I have fixed this in #14.

Fixed it in #18 Thank you for reporting.

Thank you @anburocky3 !


Why Counter parameter in SecretBox.Create

In the new implementation of SecretBox.Create for ChaCha20-Poly1305-AEAD, why is there a need for "Counter" to be a formal parameter, when the RFC 8439 says the value is always "1". Is there another use case where the caller needs to select a different Counter value?

I added it back as kind of a “just in case”situation. Does it make sense to use a default value of 1 but leave the parameter available?

Not sure... I am always wary to step away from what the RFC says unless absolutely sure. In this case, I don't know... so I would remove it unless someone comes along with a justified use-case for it to be there.  If you're OK with that, then I can make the changes here on master.
I have also sent an invite on GitHub to make you a collaborator on the main repo.

It’s easy enough to add it back in later, so I’d say remove it then. Thank you for the invite! I’m happy to accept.

The invitation should be in GitHub somewhere... it shows as "pending" at my end...

OK... done and pushed onto master.

Do you have plans for more updates? I need to get my new_mul branch merged soon to stop it rotting. The performance results are interesting... noticeable improvement at -O1, -O2 and -O3, but horribly slower at -O0 ... hmmm...


Add "final_price" to "configurable_children" to enable Catalog Price Rules

Hi guys and @afirlejczyk in particular!
I want to use Catalog Price Rules to discount products in Vue Storefront.
I can see the simple products get final_price exported to Elastic correctly but the configurable_children of a configurable product does not have the final_price at all. This means that Catalog Price Rules cannot be used in Vue Storefront if you are using configurable products.
When investigating this I found a comment from this commit:
https://github.com/DivanteLtd/magento2-vsbridge-indexer/commit/8eb09b53d5f0dd2fbc40da6aa8fc710e62b082ef#diff-7893eb8620a13730ae033dcc1d60c69eR163
So this would be the use case that makes it necessary to export final_price for configurable_children. @afirlejczyk
Would it be possible to have this added?

Hi @didkan,
Yes it can be added, but I can't let you know when it will happen..  I will try to take a look into this later this week.

@afirlejczyk Hi! Any updates on above? Did you have time to check it out?

Hi @didkan
Yes, I will push changes to develop branch later today.

@afirlejczyk
Great! Thanks! I will start testing tomorrow then.

Merged with #156


修复 example/aishell  目录中speech单词拼写错误问题

PR types

PR changes

Describe

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

请签署下  CLA 吧，我这边帮你重新跑下 CI


Graph visialization : intersections of connection lines can be reduced by adjusting node positions

I see a lot of intersections of connection lines on the graph visualization. And in some cases, it should be possible to reduce the intersections by adjusting node positions.
yolov5n.onnx.

@beru please submit a pull request that shows this improvement to the layout algorithm.

@beru please submit a pull request that illustrates this improvement to the layout algorithm.

@lutzroeder I've opened #1261 for that. I only took care of low hanging fruits. So there's surely a lot of room for improvements. Please review it if you're somehow interested in it. If not, I'll close the PR.

I've just found a related issue.
https://github.com/dagrejs/dagre/issues/357


fix: Handle RateLimitError in BadRequestException

Purpose
Handle rate limit errors occurring within BadRequestException. In some cases, rate limit errors are not captured by the OpenAI RateLimitError exception type. Instead, they appear in the inner message of BadRequestException. These changes address this issue.

Does this introduce a breaking change?

[ ] Yes
[ x] No

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

What to Check
Use the platform heavily until the subscription token limit is reached.
Observe the alert popup.
Verify that the message.

Based on your screenshot, the code that was being used when you saw this was before we started catching the RateLimitError exception which was added by https://github.com/Azure-Samples/chat-with-your-data-solution-accelerator/pull/1105
Are you sure this is still required?

Based on your screenshot, the code that was being used when you saw this was before we started catching the RateLimitError exception which was added by #1105
Are you sure this is still required?

Yes, it is still required. We have observed that the rate limit error can also occur within the BadRequest exception type, which means it is not always caught by the OpenAI.RateLimitError exception type alone.

It's a shame it's not easy to extract the 429 error from the response/exception! I'm wondering if we take a slightly different approach with this to keep it simple. Instead of catching RateLimitError, we could catch it's parent class ApiStatusError. We can then do something like this:
        except APIStatusError as e:
            error_message = str(e)
            logger.exception("Exception in /api/conversation | %s", error_message)
            response_json = e.response.json()
            response_message = response_json.get("error", {}).get("message", "")
            if "Rate limit is exceeded" in response_message:
                return jsonify({"error": ERROR_429_MESSAGE}), 429

            return jsonify({"error": ERROR_GENERIC_MESSAGE}), 500

This would then allow us to remove all of the other checks we have in the other catch blocks. What do you think?

APIStatusError

As discussed, We have updated the code to handle ratelimit exceptions using the APIStatusError type. Additionally, we catch any other exceptions with the generic Exception type. (as we've noticed that ValueError exceptions are not being caught with APIStatusError).

@Pavan-Microsoft Changes look good! Can we also apply this to the /conversation/custom endpoint for consistency? Thanks!

@Pavan-Microsoft Changes look good! Can we also apply this to the /conversation/custom endpoint for consistency? Thanks!

Updated the rate limit exception handling for /conversation/custom to be consistent with the BYOD flow. Additionally, we added a code check because we observed that the error message in the /conversation/custom flow does not include the '429' error number.


Alert handler for Microsoft Teams

Required for all non-trivial PRs

[x] Rebased/mergable
[x] Tests pass
[x] CHANGELOG.md updated
[x] Sign CLA (if not already signed)

Required only if applicable
You can erase any checkboxes below this note if they are not applicable to your Pull Request.
N/A
This adds support for sending alerts via Microsoft Teams (similar to Slack or HipChat).  I followed the alert handlers guide where possible, and when I ran into problems, I looked at the source code for other alerts (e.g., HipChat).  The tests implemented follow the same pattern of tests performed by the HipChat handler.
All tests are passing for me locally (except some unrelated UDF tests which fail due to python issues on my Mac).

Is there anyone who can take a look at this?  @nathanielc?  I'll be happy to update the docs once this is approved and merged.

Has this been merged as a change? I know that we use this heavily internally and this feature would be a huge plus.

Is this planned to be merged soon?

Wonder as well if this will be merged soon?

@StefanSa, unfortunately there is no way to change the theme or text color within a card.  I agree that this is a significant shortcoming compared to Slack.

@mmindenhall  think that is not 100% correct.
An example as sh script, zabbix to teams:
https://github.com/spasticate/zabbix-MSTeams-alertscript/blob/master/teams.sh
or alerta to teams:
https://github.com/alerta/alerta-contrib/blob/master/plugins/msteams/alerta_msteams.py

Ah, yes, you are right @StefanSa. I never tried the themeColor setting for this plugin, but had included it in a similar Java notifier library I wrote for some of our other projects.
According to the message card reference, the setting is intended for branding rather than communicating status:

themeColor
String
Specifies a custom brand color for the card. The color will be displayed in a non-obtrusive manner.Do use themeColor to brand cards to your color.Don't use themeColor to indicate status.

It would be easy to add to the card...but all it does is change the color of a line across the top of the card (screenshot).

@mmindenhall
For me it works as expected with this example.
Playground on MS
https://messagecardplayground.azurewebsites.net
Alert
    "@type": "MessageCard",
    "@context": "http://schema.org/extensions",
    "themeColor": "EA4300",
    "summary": "Larry Bryant created a new task",
    "sections": [
        {
            "activityTitle": "Service ftp1-server /cpu is  CRITICAL CPU is at 99.70",
              "facts": [
                {
                    "name": "Assigned to",
                    "value": "Unassigned"
                },
                {
                    "name": "Due date",
                    "value": "Mon May 01 2017 17:07:18 GMT-0700 (Pacific Daylight Time)"
                },
                {
                    "name": "Status",
                    "value": "Not started"
                }
            ],
            "markdown": true
        }
    ]
  }

OK
    "@type": "MessageCard",
    "@context": "http://schema.org/extensions",
    "themeColor": "00AA5A",
    "summary": "Larry Bryant created a new task",
    "sections": [
        {
            "activityTitle": "Service ftp1-server /cpu is  OK CPU is at 1",
              "facts": [
                {
                    "name": "Assigned to",
                    "value": "Unassigned"
                },
                {
                    "name": "Due date",
                    "value": "Mon May 01 2017 17:07:18 GMT-0700 (Pacific Daylight Time)"
                },
                {
                    "name": "Status",
                    "value": "Not started"
                }
            ],
            "markdown": true
        }
    ]
  }

@StefanSa, I think the best way to implement support for themeColor would be to add additional elements to the Teams config struct to enable/disable using the themeColor, and to define colors (with defaults) for each alert level.  For example, this might be the default configuration:
[teams]
theme-color-enabled = true  # enabled by default
ok-color = "008000"         # green
info-color = "008080"       # teal
warning-color = "FFFF00"    # yellow
critical-color = "FF0000"   # red
max-level-color = "800000"  # maroon

When the theme color is enabled, the Teams handler will configure the card with the color matching the alert level.
HOWEVER, it's been more than 10 months since I submitted this PR, and for some reason the team has ignored it completely.  I don't plan to add to this PR unless/until it either gets merged, or the team lets me know what needs to be done for it to be merged.

@mmindenhall yes, unfortunately it has become quiet around kapacitor.
I have a bug ticket open since mid-December, with no response. Apparently all the energy and power goes into the development of influxdb v2.
@nathanielc @rbetts
Is there a chance to accelerate this whole, otherwise the community probably loses the desire to contribute something to the project here.

@StefanSa It doesn't seem like it's that quiet, as many other pull requests have been accepted.  Hard to think of a good reason why nice work like this that has no conflicts wouldn't be accepted.  I can't think of a few really lame reasons (mostly having to do with bias towards certain vendors).

So that there is no further speculation, it would be helpful if explained here why this good PR
not accepted / was.
This is not necessarily motivating, for the so-much-touted community.

Please merge this.  Microsoft Teams support is an important feature to those of us who use Microsoft Teams.

Bump and +1 . Is there any word on what needs to happen to move this one along?
Also, as an aside as to why this PR is important, Microsoft Teams is now bigger than Slack

Please accept this.

I'm investigating whether my company can use TICK. This feature is vital for us (thanks, mmindenhall for creating it!). Can we have an indication as to whether it's going to be merged?

More than a year, and this is still open. Every check passed, except the merge button. This is an important feature, please just merge.

I did a little script in the meantime. If it helps... Https://github.com/UpperM/kapacitor-msteams

any news on this ?

pls merge :(

Hi.
I am actually also very interested in this. Unfortunately, the company I work for loves M$ and their products, so, Teams it is.
It would indeed be nice to get some feedback from @nathanielc or anyone else form @Influxdata.
I could also help hands-on if that is what it takes.
Cheers,
Ezra.

Any news @nathanielc ?

Hi everyone!
We would really like to use Kapacitor at my current company as well, and since all our communications use Microsoft Teams, this is a real blocker for us.
Is there any thing we can do to help this PR to be merged @nathanielc ?
Thanks a lot!

Hi,
I totally need this feature! :+1:

Hey @docmerlin I saw you've been going through other PRs, any plans to review this one?

@mattnotmitt I do!  I have to get a Microsoft Teams account first to test it though.

Hi, I see that this is merged already. Is this feature available or waiting for next release? May I ask the eta for next release?

Great to see this was merged. Like what @mertbakir mentioned, is there a preferred means to monitor for upcoming releases and features/fixes contained within?

@southbay82 click the Watch button on the repository and choose "releases only". You'll get an email/github notification when a release gets pushed on the repo. CHANGELOG.md should contain any updates when the release is created.

When will you planning to release this feature?

The documentation is there but it do not seems to be released right?
Documentation URL: https://docs.influxdata.com/kapacitor/v1.5/event_handlers/microsoftteams/#set-up-teams
I tried it and i ended up with this error while declaring a topic-handler
failed to create handler: unsupported action kind "teams"

Any update about this?

OK this works now with Kapacitor 1.8.5 but it sends:
{{.Level}} {{.ID}} as title
.message as body.
It should be:
.message as title
.details as body.
Can we fix this? Should I open a new issue?
Also, chronograf needs a small update to add Teams as a handler.

I'm running Kapacitor 1.5.6-1 and Chronograf 1.8.5-1, and I've enabled Teams Event Handler as described here https://docs.influxdata.com/kapacitor/v1.5/event_handlers/microsoftteams/#set-up-teams
Kapacitor service restarts fine (no apparent errors in log messages) after configuration changes, however I'm not seeing "Teams" in Chronograf under "Alert Handlers", which I am guessing it should. Am I missing anything?

@StefanSa, unfortunately there is no way to change the theme or text color within a card. I agree that this is a significant shortcoming compared to Slack.

Which is the limitation? If we look for instance to Grafana Alerts via webhooks they have a kind of separator red or green according to the status. Could it be implemented in similar way?

OK this works now with Kapacitor 1.8.5 but it sends:
{{.Level}} {{.ID}} as title
.message as body.
It should be:
.message as title
.details as body.
Can we fix this? Should I open a new issue?
Also, chronograf needs a small update to add Teams as a handler.

Did you addressed this as an issue?

OK this works now with Kapacitor 1.8.5 but it sends:
{{.Level}} {{.ID}} as title
.message as body.
It should be:
.message as title
.details as body.
Can we fix this? Should I open a new issue?
Also, chronograf needs a small update to add Teams as a handler.

Did you addressed this as an issue?

No, I didn't.


Instrucction for use without Netlify and Forestry

Hi,
Thanks @mehedi-sharif for all your precious work. I wanna use this theme only with github pages. I don't want use another services. Maybe another people wants the same thing.
Can you explain or add in the documentation how to use this theme without Netlify and Forestry?

Hello @gulpa
Here is great documentation for doing this https://gohugo.io/hosting-and-deployment/hosting-on-github/

I am going to close this issue, if you fetch any more problem then feel free to re open or create a new issue. than you


Assertion failed: uiSubdiv

Hello,
After I finish compiling the HM_dl, and get TAppEncoder.exe of HM_dl, but, when I run
" .\TAppEncoder.exe -c .\encoder_intra_main.cfg -c .\bitstream.cfg ", error occurs by the following:

Could you help me? Thank you!

It's been some time and I don't quite remember this problem...
I think it's because the pipeline generates ctu files in parallel and some ctu files are used before they are generated. You can try to set a time lag to see if this assumption is right.
Also try to run a second time to see if there's still an error.
Sorry can't help more.

Thank you for your help.

Hello,
I think you are right. I try to finish running use_model.py before encoding, not CTU splitting and encoding are running at the same time, it's ok. But I can't find the mistake. Because,  In your TEncCu.cpp file, the code exists to determine whether ctu files exists in the following:

and exist Sleep function. Why do this error occur that some ctu files are used before they are generated.
Could you help me? Thank you!

Hello,
I sincerely hope to get your help, I have been studying for a long time, but I can't solve the error. Thank you !!!

This is a bug, and I didn't solve it. I just set a larger time lag for these two to run in parallel. Maybe the code to determine the existence of ctu file is not correct?

Hello,
I run into the same problem , is there any possiblility that it is because i didn`t build the original HM before ? Wandering how you solve the problem : )


The post processing method for the scene generation

Hi! I collected a 3D dataset with a Matterport pro2 camera and since the dataset is collected at a library, moving people are collected in several scans.
I bought the MatterPak to get a *.obj file and transformed it into a *.glb file to use it at the habitat simulator.
Since the matterport3d dataset is so clean, I think you used post-processing for making the scene clean.
If you did use the post-processing algorithm, could you let me know how you removed cluttered point clouds?
Thanks :)

Same question here. Thanks!

Same question here. Thanks!


Problem of  converting model from 32-bit to 16-bit

When converting a model from 32-bit to 16-bit, the attributes of the RandomUniform module do not change.

fixed by https://github.com/microsoft/onnxconverter-common/pull/239


Add "contructionYear" in real_estates

Add "contructionYear" into real_estates, to be compatible with RealT constructionYear Data

"contructionYear" is available in finary api ?

Hum i don't know, but available on portfolio :

"building_period": "between_1975_1984", ?

Yes, we need a list of the possible value, and decide how we pass it to the function...


Unexpected message type

super minor issue, but it looks like postlite will simply log an error when it receives an unexpected message type. I saw elsewhere in the code that you already have a pattern for sending errors to the client, so maybe this would be a good candidate for something worth sending errors to the client about? Otherwise, ~I'm pretty sure the connection will get into an inconsistent state where the client is stuck waiting for a response, and~ the end user will likely be very confused.
(edit: I see that the connection will be terminated, which at least helps a bit)
https://github.com/benbjohnson/postlite/blob/main/server.go#L239

Thanks for the bug report. Yeah, the error handling could be better. I've been overly prudent so far by just killing the connection and logging the error but I'll get that fixed it. 👍


闪退频率太高了

经常在双击打开文件或文件夹之后闪退
经常在全选右键选择属性后闪退

Thanks for this report. Known issues with version 1.2.2. Both should be fixed in 1.2.3.


stylesheets on page using ../ gets confused more than one directory in

Take the home page of a site. This works fine.
file: index.md
---
theme: "base"
stylesheets:
- "foo.css"
-<EMAIL_ADDRESS>- "../.poco/css/featuretable.css"
- "featuretable.css"
---

hello, world.

Works fine by itself with no subdirectories.
The problem is when you go down a level and try to do the same thing.
$ mkdir deeper

Here's a file using the deeper directory:
file: deeper/index.md
---
stylesheets:
- "../.poco/css/featuretable.css"

---

Result:
PocoCMS /Users/tom/pococms/poco/tmp/deeper/index.md:
 	 open /Users/tom/pococms/poco/tmp/Users/tom/pococms/poco/tmp/.poco/themes/.poco/css/featuretable.css: no such file or directory

Uh pilot error. It should work that way


index.html and index.js are missing

The files index.html and index.js are missing from the top-level directory. The readme instructions still specifies that index.html should opened.

My mistake: noflo-ui needed to be built  first.


Show original file path with 'args.artlbl' and preprocessing2

Expected Behavior
Printing a filepath to the source image.
So after a document review, anybody can find the bitmap to update for change request to a figure.
[image]
subdir\images\figure.jpg
Figure 1: This is a caption for the figure

Actual Behavior
Printing of the hashed filename, as introduced in DITA-OT 3.0.
Great for debugging, but as a temporary file, does not makes sense to an end-user of a PDF.
[image]
429954c4b28a55d144ff42e5a07b51ffda9d185a.jpg
Figure 1: This is a caption for the figure

Possible Solution
Steps to Reproduce
Calling DITA-OT from commandline
dita.bat -i path\to\bookmap.ditamap -f pdf -Dargs.artlbl=yes
Environment
Windows 10, DITA-OT 3.2

Not sure how best to manage this, but it's pretty clear the current result for args.artlbl in PDF is not usable for the originally intended purpose.

document (@xtrf)/image[@xtrc]/@href
Something like that?
Op vr 7 dec. 2018 16:54 schreef Robert D Anderson<EMAIL_ADDRESS>
Not sure how best to manage this, but it's pretty clear the current result
for args.artlbl in PDF is not usable for the originally intended purpose.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dita-ot/dita-ot/issues/3154#issuecomment-445275511,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AnqIYq-XQHeNKjOenp3QI1uCGRZEJPYQks5u2o8wgaJpZM4Yq0qQ
.

I also agree that when producing the PDF errors like this:
  [DOTX031E]: The file 774e41ff5f82421fb7ad88659287b754810c368a.dita            is not available to resolve link information.

are not helpful at all, maybe when computing the error message you should look in the ".job.xml" and also show the original file name and path for the hashed topic.

Suggested solution/override for

<xsl:template match="" mode="image.artlabel">
<xsl:variable name="artRef"     select="tokenize(@xtrc,';')[1]"/>
<xsl:variable name="artElement" select="xs:string(tokenize($artRef,':')[1])"/>
<xsl:variable name="artIndex"   select="xs:int(tokenize($artRef,':')[2])"/>
<xsl:variable name="artHref"    select="document(@xtrf)//[name() = $artElement][$artIndex]/@href"/>
    <fo:block xsl:use-attribute-sets="image.artlabel">
        <xsl:text> </xsl:text>
        <xsl:value-of select="concat(@xtrf,',',$artHref)"/>
        <xsl:text> </xsl:text>
    </fo:block>
</xsl:template>

Suggested solution (or customization):
    <!-- Override for dita-ot-3.2.1\plugins\org.dita.pdf2\xsl\fo\topic.xsl -->
    <xsl:template match="*" mode="image.artlabel">
        <xsl:variable name="artRef"     select="tokenize(@xtrc,';')[1]"/>
        <xsl:variable name="artElement" select="xs:string(tokenize($artRef,':')[1])"/>
        <xsl:variable name="artIndex"   select="xs:int(tokenize($artRef,':')[2])"/>
        <xsl:variable name="artHref"    select="document(@xtrf)//*[name() = $artElement][$artIndex]/@href"/>

        <fo:block xsl:use-attribute-sets="image.artlabel">
            <xsl:text> </xsl:text>
            <xsl:value-of select="concat(@xtrf,',',$artHref)"/>
            <xsl:text> </xsl:text>
        </fo:block>
    </xsl:template>

The template is primarily called for images, but other use cases may be valid so I explicitly extract and use $artElement.
The did not resolve into a full filepath because I don't know how this works out for references when using a CCMS.
I changed the fo:online into and fo:block, so it is rendered nicely below the image.

@qvrijt Note that @xtrc is not available if you use generate-debug-attributes=false.

@jelovirt Good point. Never noticed it, because i used the option in combination with debugging.
Change of tactics: Capture output of placeImage and extract fo:external-graphic/@src.
In my case, it also returns the resolved path to the original source.
See attachement artlabel-from-fographic.txt

    <!-- Override of dita-ot-3.2.1\plugins\org.dita.pdf2\xsl\fo\topic.xsl -->
    <!--
        Print the path of the image source file.
        To use @xtrf, render document with DITA argument -Dgenerate-debug-flags=yes
    -->
    <xsl:template match="*" mode="image.artlabel">
        <fo:inline xsl:use-attribute-sets="image.artlabel">
            <xsl:choose>
                <!-- Added workaround for dita-ot-3.x -->
                <xsl:when test="@xtrf">
                    <xsl:text> </xsl:text>
                    <xsl:value-of select="@xtrf"/>
                    <xsl:text> </xsl:text>
                </xsl:when>
                <!-- Correct for dita-ot-1.x/2.x. Returns tempdir file name for dita-ot-3.x -->
                <xsl:when test="@href">
                    <xsl:text> </xsl:text>
                    <xsl:value-of select="@src"/>
                    <xsl:text> </xsl:text>
                </xsl:when>
                <!-- May work for HTML -->
                <xsl:when test="@src">
                    <xsl:text> </xsl:text>
                    <xsl:value-of select="@src"/>
                    <xsl:text> </xsl:text>
                </xsl:when>
            </xsl:choose>
        </fo:inline>
    </xsl:template>

    <!-- Override of dita-ot-3.2.1\plugins\org.dita.pdf2\xsl\fo\topic.xsl -->
    <!--
        Print the path of the DITA source file after the topic title.
        To use @xtrf, render document with DITA argument -Dgenerate-debug-flags=yes
    -->
    <xsl:template match="*[contains(@class,' topic/topic ')]/*[contains(@class,' topic/title ')]">
        <!-- render title by current template -->
        <xsl:next-match/>
        <!-- postfix source file name -->
        <xsl:if test="$artLabel='yes' ">
            <xsl:apply-templates select="." mode="image.artlabel"/>
        </xsl:if>
    </xsl:template>


Multiple consecutive identical dialogs

VSCode Version: 1.6.1
OS Version: macOS Sierra 10.12.1 Beta

Steps to Reproduce:

Open a file
Make some changes
Repeat N times cmd+w
Close the dialog
The same dialog will be opened N -1 more times

This issue has already been reported. Please use the search function next time or this time if you are curious about the progress of the issue.


Add changelog for 1.2.0

This project hadn't had a release for a long time and contained some unflushed PRs.

Thank you @manics!


pull request for e2e test at 12/03/2016 16:15:04

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


TypeError inside Regedit!

Hi,
I am getting TypeError: Cannot read property 'toUpperCase' of undefined when all I am passing to putValue is the same object I retrieved from list.
The path is at renderValueByType (C:\...\node_modules\regedit\index.js:283:13)
Is this related to #15?
Thank You!

Never mind ... Needed to go more specific ... can't just put the whole object.


Pass engine_args to create_engine in get_embedding_column_definition

Pass engine_args to create_engine in get_embedding_column_definition.
Encountered this error when connecting to tidbcloud serverless cluster:
sqlalchemy.exc.OperationalError: (pymysql.err.OperationalError) (2003, "Can't connect to MySQL server on 'gateway01.eu-central-1.prod.aws.tidbcloud.com' ([SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1000))")

@michaelwnyc thanks for your contribution. Can you fix the lint ci issue?

@IANTHEREAL It should have been fixed

@michaelwnyc Thanks again

@IANTHEREAL Any chance to release a new version and also update llama-index-vector-stores-tidbvector's version list?

@michaelwnyc we will release it ASAP in this week

@michaelwnyc  We had released the update in tidb-vector 0.0.8. You can now update 'tidb-vector' in your environment.  Because the 'llama-index-vector-stores-tidbvector' requires 'tidb-vector' to be version '>=0.0.3,<1.0.0', it will also work


WIP: Turn off az fm rate mismatch

This PR is to explicitly turn off the functionality for azimuth FM rate mismatch mitigation (FM mismatch hereinafter), which is in the PR on s1-reader here
The FM mismatch requires extracting a sequence of azimuth FM rate and Doppler centroid polynomial information from the annotation file. This adds up extra workload to the reader. Some OPERA SAS such as RTC does not need this feature, so it would be beneficial to turn this off.
The change on RTC side is very simple; Just turning off a flag flag_az_fmrate_mismatch_mitigation will do the job. However, the PR on s1-reader needs to be merged before getting this PR merged. Otherwise it will cause an error because the flag does not exists on the main branch of s1-reader.
Therefore this PR needs to be held for a while. The WIP in the title and the label will be removed when it is ready to be merged.

Closing this PR as we do not have the flag in s1-reader. See here for details.


Unified account - Update the latest code

Describe the task
Update the latest code:

[x] Update for issue https://github.com/Koniverse/SubWallet-Extension/pull/3464
[x] Update for #3477, #3484
[x] #2703

Version test : https://drive.google.com/file/d/1Dfr6KG58tM7m4GHbeZv7EOiuTMeAjO2K/view?usp=drive_link

[ ] Validate network address on some screen
Actual :

[ ] Update content for https://github.com/Koniverse/SubWallet-Extension/issues/3477, https://github.com/Koniverse/SubWallet-Extension/issues/3484
Actual :

Expect : https://www.notion.so/subwallet/Th-ng-b-o-warning-unstake-v-confirmation-cho-c-c-user-ang-c-c-pool-v-direct-c44ca43088b047488fce087cdfa5565e#2ff07c7fa9f5455eb84c02bbc7b095b0

Version test : https://drive.google.com/file/d/1I043C3fEeeXHuuuuSawrQklFv32By64t/view?usp=sharing
Validation passed in case :

Install/Update version
Check all cases with updated lastest code


Improve support for contracts

I am closing this issue because it is way too general. Support for information related to contracts is involved in various parts of the product which in no way can be addressed in a single issue/task.


Help needed in testing my VM with all the softwires installed to run my CI pipeline

Task name
No response
Task version
No response
Environment type (Please select at least one enviroment where you face this issue)

[X] Self-Hosted
[ ] Microsoft Hosted
[x] VMSS Pool
[x] Container

Azure DevOps Server type
dev.azure.com (formerly visualstudio.com)
Azure DevOps Server Version (if applicable)
No response
Operation system
Windows Server -2019 Datacenter
Question
I am setting up a VM image that can be used for creating the VMs that can run the azure devops agents. This VM image is provisioned via packer and I want to test if the software (Docker, Visual Studio Build Tools, Nodejs, etc., ) provisioned via packer, will support the azure DEVOPS tasks such as Docker2, Npm@1, VSBuild@1,  VSTest@2.

IMP: Here I want to test if the above tasks will work during the VM image provisioning only and I want to integrate these tests as part of my packer pipeline.

Any suggestions?

Hi @gyuvaraj10,tion
Thank you for your question!
If I got your question right, you may implement some similar checks used in agent to detect capabilities

Hi @kirill-ivlev , Thank you for reply, I have noticed that the User capabilities are not visible for vmss type agent pool. In my usecase, I can not check the User Capabilities. Please suggest.


Getting scope.$on is not a function exception in api.core call

Hi,
I am not sure, Y am I getting this error. I am attaching api in gantt and calling api.core.on.ready function. I am getting an exception on this as scope.$on is not a function. Please see the example in plnkr
http://plnkr.co/edit/0wxNn5h7w8Wuj4D2hkoN?p=info

Sorry, my mistake. Its just my ignorance of scope and as variable. Now understood clearly.
http://codetunnel.io/angularjs-controller-as-or-scope/
Anyway, thanks for the effective gantt chart.


Python version

Hi thanks for sharing this, I'm wondering if it's possible to set the python version somewhere?

It's now possible to choose a specific Python version with 8bc1c9d9f111fcd4a6f417474a3f5e4882b655af
Please report here if it works well for you.

It works, thank you!


Avoid some unnecessary resource recreations

Ignore changes to ami for instances and to availability_zone for subnets. The latter especially tends to cascade into a tsunami of recreates.

If availability_zone is ignored for subnets does that mean that currently misconfigured clusters (e.g. no spread across availability zones) would silently continue to be misconfigured?

If availability_zone is ignored for subnets does that mean that currently misconfigured clusters (e.g. no spread across availability zones) would silently continue to be misconfigured?

Yes. One would have to explicitly terraform taint the subnet resource to achieve that. However, it would prevent redundant az hopping in the (hypothetical) case of amazon messing with the availability of our desired instance types in the currently used availabilty zones. So it's sorta subtle tradeoff that I'd leave you to decide on.

Closing in favour of https://github.com/input-output-hk/bitte/pull/157


buildwrapper-0.7.5 won't build against cabal-1.18

Hello!
I'm trying to install EclipseFP on Gentoo with cabal-1.18.0, ghc-7.6.3.  I get the errors below when I try to build buildwrapper-0.7.5.  I checked the cabal docs on Hackage and it looks like those functions disappear (or are moved?) in 1.18.  In the mean time, downgrading to cabal-1.16 works.
Cheers.
>>> Compiling source in /mnt/portage/build/portage/dev-haskell/buildwrapper-0.7.5/work/buildwrapper-0.7.5 ...
./setup build
Building buildwrapper-0.7.5...
Preprocessing library buildwrapper-0.7.5...
[1 of 7] Compiling Language.Haskell.BuildWrapper.Base ( src/Language/Haskell/BuildWrapper/Base.hs, dist/build/Language/Haskell/BuildWrapper/Base.o )
[2 of 7] Compiling Language.Haskell.BuildWrapper.GHCStorage ( src/Language/Haskell/BuildWrapper/GHCStorage.hs, dist/build/Language/Haskell/BuildWrapper/GHCStorage.o )
[3 of 7] Compiling Language.Haskell.BuildWrapper.Src ( src/Language/Haskell/BuildWrapper/Src.hs, dist/build/Language/Haskell/BuildWrapper/Src.o )
[4 of 7] Compiling Language.Haskell.BuildWrapper.GHC ( src/Language/Haskell/BuildWrapper/GHC.hs, dist/build/Language/Haskell/BuildWrapper/GHC.o )

src/Language/Haskell/BuildWrapper/GHC.hs:16:1: Warning:
    The import of `Language.Haskell.BuildWrapper.Src' is redundant
      except perhaps to import instances from `Language.Haskell.BuildWrapper.Src'
    To import instances alone, use: import Language.Haskell.BuildWrapper.Src()

src/Language/Haskell/BuildWrapper/GHC.hs:64:1: Warning:
    The import of `unless' from module `Control.Monad' is redundant

src/Language/Haskell/BuildWrapper/GHC.hs:568:17: Warning:
    Pattern match(es) are non-exhaustive
    In an equation for `sfile': Patterns not matched: UnhelpfulSpan _
[5 of 7] Compiling Language.Haskell.BuildWrapper.Packages ( src/Language/Haskell/BuildWrapper/Packages.hs, dist/build/Language/Haskell/BuildWrapper/Packages.o )
[6 of 7] Compiling Language.Haskell.BuildWrapper.Cabal ( src/Language/Haskell/BuildWrapper/Cabal.hs, dist/build/Language/Haskell/BuildWrapper/Cabal.o )

src/Language/Haskell/BuildWrapper/Cabal.hs:503:63:
    Not in scope: `libraryConfig'

src/Language/Haskell/BuildWrapper/Cabal.hs:510:79:
    Not in scope: `executableConfigs'

src/Language/Haskell/BuildWrapper/Cabal.hs:517:81:
    Not in scope: `testSuiteConfigs'

src/Language/Haskell/BuildWrapper/Cabal.hs:555:77:
    Not in scope: `libraryConfig'

src/Language/Haskell/BuildWrapper/Cabal.hs:564:94:
    Not in scope: `executableConfigs'

src/Language/Haskell/BuildWrapper/Cabal.hs:576:97:
    Not in scope: `testSuiteConfigs'

src/Language/Haskell/BuildWrapper/Cabal.hs:576:141:
    Not in scope: `testSuiteConfigs'

Old bug, closing, thanks.


typo: propety -> property

OPS Build status updates of commit f9332c7:
:clock10: Preparing: average preparing time is 3 min(s) 17 sec(s)

OPS Build status updates of commit f9332c7:
:clock10: Incremental building: average incremental building time is 54 min(s) 18 sec(s)

OPS Build status updates of commit f9332c7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

api/Access.NavigationButton.ParentTab.md
:white_check_mark:Succeeded
View

api/PowerPoint.MotionEffect.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Folder Structure and Naming Conventions

The folder structure of the project is a bit odd in some places, owing to the fact that it has been left to grow organically for so long. Examples of this are

src/component-library folder (can be flattened)
component-library/components folder (can be cleaned -- some files are floating around outside of the newly established hierarchy)
API routes under source/app
... and others

[ ] Clean these up!

In addition, it might make sense to do the following

[ ] Come up with naming conventions (or formalise the ones which already exist) and put them into writing.

Components cleaned up in #266


When pressing the submit edit request in public cloud for a product that already exists the user sees a window for a submission request

Current:

Updated Public and Private Cloud edit page thank you modals:

Updated Public and Private Cloud create page thank you modals:


WIP: Add Windows support

This is an overhaul of the CMake code, based on what I wrote for mcsema1 (but never merged).
New features:

Windows (Visual Studio 2017 and 2015) and macOS support
Adds support for the install target
Adds a CMake config file in the library folder that can be automatically used by other projects by calling find_package(remill)
Detects changes to the semantic files and automatically recompiles the runtimes!

Note that his PR requires my other alessandro/feature/windows-support branch on the mcsema repository!

This branch is now passing all tests locally; Travis reports an error on the same FPU instruction that fails on master

Hello,
We've been trying to use this branch to evaluate if this fixes #265.
Unfortunately, we ran into some issues:

CMAKE_ASM_COMPILER and friends have a mangled value
** (see inline comment for details)

"Wrong" version of LLVM is selected

I have several versions of LLVM on my computer. I have a system-installed LLVM 3.5, plus a LLVM 5.0.2 in a custom directory.  I build remill with the the LLVM_INSTALL_PREFIX set to the specific path that contains the LLVM 5.0.2 installation.
On master, the detected remill version is 5.0.2, which is what I want (since I specified this in the LLVM_INSTALL_PREFIX). However, on this branch, the detected version is my system version (3.5).
This is critical because my code using remill relies on LLVM 5.

Compilation fails with the same message as in the travis builds

/usr/include/x86_64-linux-gnu/bits/fenv.h:29:5: error: expected identifier
    __FE_DENORM = 0x02

remil/remill/Arch/Float.h:22:22: note expanded from macro '__FE_DENOM'
# define __FE_DENORM 0x02

We couldn't test if this branch fixes the issue with remill lib installation, since we couldn't actually reach the make install step. However, reading the code, we believe that it would be the case. Thank you for this PR.


if you zoom with rect selector with xlim=strecth it will unzoom you

long term the solution here is to create xlim functions and then handle this at the controls level.

See https://github.com/ianhi/mpl-interactions/issues/173#issuecomment-808065308 for a nice example


Add React-dom

In react 0.14 we have two separate packages — React and React-DOM. findDOMNode now part of React-DOM.

Thx for your enhancement!

@sergeylaptev can you bump and update package on npm?

@7rulnik You are welcome!