Can download video but no channel: "not available in your country" although set "--geo-bypass-country US"

Checklist

[x] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2020.07.28
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

$ # video URI:

$  youtube-dl --write-description --no-post-overwrite --rm-cache-dir --ignore-errors  --geo-bypass-country US  -f 18        https://www.youtube.com/watch?v=3lZiwteg-kw
Removing cache dir /home/peter/.cache/youtube-dl ..
[youtube] 3lZiwteg-kw: Downloading webpage
[info] Writing video description to: Die Post ist da!  Der Postvertrag regiert die Welt.-3lZiwteg-kw.mp4 has already been downloaded
[download] 100% of 27.19MiB

$ # identical channel as video before, using channel URI instead of video URI:

youtube-dl --write-description --no-post-overwrite --rm-cache-dir --ignore-errors  --geo-bypass-country US  -v  -f 18        **https://www.youtube.com/channel/UCaU13kUFBJF5QGTY8ZPDBAA**
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--write-description', '--no-post-overwrite', '--rm-cache-dir', '--ignore-errors', '--geo-bypass-country', 'US', '-v', '-f', '18', 'https://www.youtube.com/channel/UCaU13kUFBJF5QGTY8ZPDBAA']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2020.07.28
[debug] Python version 3.6.10 (CPython) - Linux-5.3.18-lp152.33-default-x86_64-with-glibc2.3.4
[debug] exe versions: ffmpeg 3.4.4, ffprobe 3.4.4
[debug] Proxy map: {}
Removing cache dir /home/peter/.cache/youtube-dl ..
[debug] Using fake IP <IP_ADDRESS> (US) as X-Forwarded-For.
[youtube:channel] UCaU13kUFBJF5QGTY8ZPDBAA: Downloading channel page
[youtube:channel] UCaU13kUFBJF5QGTY8ZPDBAA: Downloading page #1
ERROR: Youtube said: This channel is not available in your country.
Traceback (most recent call last):
  File "/usr/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 2998, in _real_extract
    next(self._entries(channel_page, channel_id))
StopIteration
Traceback (most recent call last):
  File "/usr/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 2998, in _real_extract
    next(self._entries(channel_page, channel_id))
StopIteration

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 797, in extract_info
    ie_result = ie.extract(url)
  File "/usr/bin/youtube-dl/youtube_dl/extractor/common.py", line 530, in extract
    ie_result = self._real_extract(url)
  File "/usr/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 3004, in _real_extract
    raise ExtractorError('Youtube said: %s' % alert_message, expected=True)
youtube_dl.utils.ExtractorError: Youtube said: This channel is not available in your country.

Description

I can download video of a channel using the video URI but I cannot all videos of the channel using the channel URI.
Error message: "not available in your country"
I have set --geo-bypass-country US

Geo bypass will only work if X-Forwarded-For is respected be the server.

I think the real issue is that you can download the video normally but not  the channel videos.

Try video and channel URI with --geo-bypass-country.


Is there a way to specify a team name for pgp_key instead of keybase username?

Presently, it is creating a dependency on one person to decrypt the encrypted values given through the module as output.
We want to allow everyone in a team to be able to decrypt the outputs such as secrets produced through Terraform. Is this feature planned? or is there some way to achieve this already?

Hi @sharath-yml !
This module creates IAM users passwords which can be decrypted with provided PGP keys (read this).
If you want users to be able to decrypt their own passwords they have to specify their own PGP keys as pgp_key argument to the module (see inputs).
Hope it helps.

Also, if you need to use not unique PGP keys, but some kind of team name I would recommend to look into what keybase.io has to offer. I personally have never used teams before.


Can't create Animated form from examples

Summary
Hey, guys. How can I create an animated form from examples with react-stripe-elements? Sorry for this issue but I have no ideas right now :)

Hi @kotchuprik -- that link is actually to older examples. We recommend looking at https://stripe.com/elements/examples right now.
As far as helping with animations -- that's beyond the scope of this library. If there's something specific that doesn't work in react-stripe-elements, please let us know!

well, the main problem is I can't set classes and handling functions (focus, blur, key press) via props :) I guess react-elements does not allow setup these params.


allow react 18 as peer dependency

I agree

please merge this PR

@RubenMateus could this be merged soon? or are there any issues of this lib with react 18?

It has already been merged through another pull request #793. Unfortunately this change is still not available on NPM.


FontFaceSet sample

R: @addyosmani @gauntface @beaufortfrancois
CC: @toyoshim, who I believe worked on the Chrome implementation.
This is a sample for the FontFaceSet interface in M48, https://www.chromestatus.com/feature/4594172182921216
I'm not 100% sure that it illustrates all the best practices properly, so it would be great if @toyoshim could offer some advice/review. It's also attempting to show off a few different things at once (loading custom FontFaces via both JS and CSS, hiding text until the fonts have loaded, iterating over all the loaded FontFaces) so let me know if you feel like I should cut something out to make it more focused.
You can view a live version at https://jeffy.info/samples/font-face-set/

Maybe adding a log font loading progress would help to visualize the process.
Otherwise LGTM.

That's an interesting idea. I don't know very much about this API, so I'm poking around a bit to see what's available...
There are loading/loadingdone/loadingerror events exposed on the FontFaceSet, but when those fire, I don't see anything in the corresponding FontFaceSetLoadEvent parameter indicating which underlying FontFace the event applies to. So I'm not sure it offers more of a benefit vs. just using the document.fonts.ready promise to wait for the whole set of fonts to load.
There aren't any events exposed on the individual FontFace objects, though there is a .loaded promise you can wait for. The problem with that is I'm not sure how to construct a new FontFace object corresponding to the font loaded via @font-face in CSS, so I would only be able to show waiting on .loaded for the font loaded via JavaScript.

Sample LGTM. I wasn't able to find additional benefits to using more than document.fonts.ready to wait on the entire set of fonts to load vs. using the additional events exposed, but this might just be my poor reading of the material around this feature.

I'm a bit confused at what this demo is trying achieve.
Oxygen is hidden but the font is defined in CSS. Bitter is visible but loaded via JS.
Why toggle oxygen visibility?
Why Load one in CSS the other in JS?
How does blocking in CSS affect visibility of fonts with all of this?
Is it possible to get a callback when a specific font is loaded?
This still seems to exhibit the same behaviour as the web has today (i.e. it will just display when all fonts are loaded.
Is it worth:

removing any unneccessary steps (i.e. toggling visibility)
Splitting out into multiple small demos (i.e. here the font is loaded via CSS and we know when it's upgraded by callback X. Here the font is loaded via JS and we get a callback when its loaded).

Yeah, the sample does try to cover a lot.
I toggle the visibility inside the .ready promise because that seems to be the intended use of that promise. It's the example in the spec as well. That does seem legitimate to me, but I could explain it better in the sample—it prevents you from seeing the text temporarily in the default font and then having it flash into the custom font.
I can remove loading the font via CSS, as it's not part of the new functionality. I thought it would be nice to have multiple fonts loaded, since one of the other pieces of new functionality is the ability to iterate over all the custom fonts on the page.
It's possible to use a promise to check one a single font is loaded via JavaScript, but like I mentioned in my previous comment, I don't see that as being possible with the font loaded via CSS.
I could change the sample to load multiple fonts via JavaScript and log once each is loaded, and then log again once the .ready promise is resolved. Would that address the feedback?

Totally would yes :)
On Thu, 26 Nov 2015 at 14:29, Jeffrey Posnick<EMAIL_ADDRESS>wrote:

Yeah, the sample does try to cover a lot.
I toggle the visibility inside the .ready promise because that seems to
be the intended use of that promise. It's the example in the spec
https://drafts.csswg.org/css-font-loading/#font-load-event-examples as
well. That does seem legitimate to me, but I could explain it better in the
sample—it prevents you from seeing the text temporarily in the default font
and then having it flash into the custom font.
I can remove loading the font via CSS, as it's not part of the new
functionality. I thought it would be nice to have multiple fonts loaded,
since one of the other pieces of new functionality is the ability to
iterate over all the custom fonts on the page.
It's possible to use a promise to check one a single font is loaded via
JavaScript, but like I mentioned in my previous comment, I don't see that
as being possible with the font loaded via CSS.
I could change the sample to load multiple fonts via JavaScript and log
once each is loaded, and then log again once the .ready promise is
resolved. Would that address the feedback?
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleChrome/samples/pull/256#issuecomment-159927646.

PTAL.

LGTM

Ouch. I rarely checked github notifications.
Please ping me by mail or something if you ask me here and can not get a resoponse in the future.


Not all .wav files generate corresponding spec.pt

I notice that the spec.pt generated are missing for some .wav files in the dataset, even after training of thousands epochs. What cause this issue?

Too big wav files are omitted:
https://github.com/jaywalnut310/vits/blob/main/data_utils.py#L302
You can try to change it from here (increase numbers in boundaries, for example [32,300,450,600,750,1000,1200,1400,1600]):
https://github.com/jaywalnut310/vits/blob/main/train.py#L70
(but note that too big files may lead to worse alignment, though you must experiment with it)

Or nicer way - move it in config and setup as you want:
https://github.com/jaywalnut310/vits/pull/119/commits/490b60abe3978650d4341c0c64dc49ab76287d58


Missing closing square braces in example

Not sure if you really need a changeset for a doc change 😅 I can add one or you can if you like


Unscore invalid matchpredictions, verify probabilites in edge calc

The hypothesis is that there were already previously match predictions which yielded ridiculous probabilities in the database already before the change for (61418b9e6e9532f6d4f301b8e7162fa9a48d8016](https://github.com/sportstensor/sportstensor/commit/61418b9e6e9532f6d4f301b8e7162fa9a48d8016) was merged. This led to some invalid requests making it through before they were rejecting by the previous commit. This hotfix unscores all of these invalid predictions, and modifies the edge_calculation function to rescore them as if they were never there.

Thank you! We're going to hold off on nuking any scores as the new gaussian filter will handle edge cases.


No information on Geographic Feature Resource type in terms page

Like all other resource types, information on Geographic Feature Resource type needs to be included here: www.hydroshare.org/terms/

The doc is there. Closing


Branch name and commit message written by the user are sent to backend

When frontend sends a request to save a file, it should include the name of the branch and commit message selected by the user in the save dialog.

This is waiting for #113, #114 and #115.


quick EFI_LOCATE_PROTOCOL text fix

Version and Platform (required):

Binary Ninja Version: 3.5.4332-dev, 90f160d9
OS: windows
OS Version: 11
CPU Architecture: x86_64

Bug Description:
Current:
EFI_LOCATE_PROTOCOL LocalProtocol;
Steps To Reproduce:
Check struct EFI_BOOT_SERVICES type definition
Expected Behavior:
Expeted:
EFI_LOCATE_PROTOCOL LocateProtocol
Screenshots:
Additional Information:
https://uefi-d.dpldocs.info/uefi.spec.EFI_LOCATE_PROTOCOL.html

Fixed in 3.5.4333


Added 'Code of Conduct'

Added 'Code of Conduct' file in reference to the issue #2

Great Work @theflash-17 !! I am merging your PR.


Version v0.2.2: introduction of strategies

Codecov Report

Merging #66 (fb6518d) into main (a2bc9e7) will decrease coverage by 3.12%.
The diff coverage is 80.64%.

@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
- Coverage   84.89%   81.76%   -3.13%
==========================================
  Files          20       24       +4
  Lines         642      806     +164
==========================================
+ Hits          545      659     +114
- Misses         97      147      +50

Impacted Files
Coverage Δ

src/MOI_wrapper/objectives.jl
42.10% <0.00%> (-14.15%)
:arrow_down:

src/constraint.jl
100.00% <ø> (ø)

src/objective.jl
100.00% <ø> (ø)

src/model.jl
97.27% <57.14%> (-2.73%)
:arrow_down:

src/strategies/tabu.jl
64.00% <64.00%> (ø)

src/configuration.jl
65.21% <65.21%> (ø)

src/utils.jl
92.85% <66.66%> (-7.15%)
:arrow_down:

src/state.jl
80.85% <83.33%> (-17.19%)
:arrow_down:

src/strategies/restart.jl
85.00% <85.00%> (ø)

src/solver.jl
95.93% <88.33%> (-3.36%)
:arrow_down:

... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2bc9e7...fb6518d. Read the comment docs.


Fixed missing arguments in lr_find call

There seem to be 3 arguments missing in the lr_find call in the tunining.py file.
What does this PR do?
Adds the 3 arguments stated in the issue to the lr_find call.
Fixes #6783
Before submitting

[ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

are there tests for this?


Long number format ignored

The software doesn't appear to accept the Long number format for the foundation height attribute in the structure inventory: Double number format is required. It may be a good idea to allow Long.
Foundation heights with Long number format defaulted to -999. This may also pertain to other attributes in the structure inventory or other imported data. I have only encountered it with foundation height in the structure inventory.
Obviously this isn't critical as one can simply convert to Double number format, which is best practice anyway. But I encountered this when importing a txt file into ArcGIS Pro using XY coordinates and then imported that into FDA. It appears that Arc Pro may default to Long number format for txt files imported this way in some cases. I have done that a lot historically (since FDA generates structure details in txt), so I can imagine this may pop up fairly regularly when the software is released.

Tell me more about what you mean by long number format. meaning you can't use decimals?

Tell me more about what you mean by long number format. meaning you can't use decimals?

Double allows decimals, Long does not (only integers). That's why I say it's best practice to the convert data to Double (because we work in decimals when it comes to foundation heights), which you can do in Arc Pro.
Another option would be to reject Long numbers with a warning message telling the user to convert to Double.

this is showing up in multiple studies and causes funny results without good communication about why results are funny, I think we should prioritize this to reduce the amount of user support we'll have to do

Crops_Sac39_NAD_1983_StatePlaneCA.zip


Tagging option for util rule-merger

Is your feature request related to a problem?
We are reviewing the merger rules after each consolidation task. Some rules ,however correctly merged, may need to be split again due to admin practices and/or individual mgmt choices. Also we need to fix the merged descriptions acc to customer standards again manually.
Having a tag for merged rules makes would make it easier to review these rules.
Describe the solution you'd like
Add an optional attribute in util rule-merger to tag all merged rules. It can be a tag named "merged" by default or we can specify the name at each run. Obviously we would need to check existence of that tag in that DG and create it if necessary.
Describe alternatives you've considered
Filtering out the set output for merged rules and tagging them manually as an extra step
Additional context

introduced with PR #592


Sources for com.github.parboiled.custom are missing

Hello
I am trying to package lombok-ast for Debian and I discovered that lombok-ast fails to build from source with the latest version of parboiled from https://github.com/sirthias/parboiled. Apparently this project uses a custom version of parboiled. I downloaded http://projectlombok.org/ivyrepo/parboiled/parboiled-<IP_ADDRESS>-src.jar but it contains no source and only class files.
Could you provide the sources for your custom version of parboiled please?

The sources can be downloaded from https://github.com/sirthias/parboiled. They are in fact not a custom version of parboiled but simply a seven year old version.
Please consider to use the latest version of parboiled for lombok.ast which would simplify its packaging for Linux distributions.


Replace Write trait with a write fn in Logger.

The "remove dyn Write" part of of #257 contained breaking changes, so it's extracted here as a separate PR. See that PR for details.

triage: added to the 0.2.0 milestone.
status: blocked on deciding a set of new features and changes for the 0.2.0 release.
These breaking changes need to be evaluated against other changes that will be included in the 0.2.0 release

I was wondering if it's still possible to implement a lock-free logger with the proposed trait changes and it seems possible but these changes may impact performance negatively (don't know by how much though).
One way to implement such a logger on Cortex-M is to have one RTT channel per priority level. With this design interrupts running at different priorities don't need to lock (disable interrupts / cause priority inversion) a single logger, instead they grab their interrupt-priority-local (similar to a thread-local) logger.
With the current trait, the implementation of that lock-free logger looks like this (off the top of my head: may not be correct / accurate):
// an RTT channel
struct Channel { taken: AtomicBool, /* .. */ }
impl defmt::Write for Channel { /* .. */ }

static mut CHANNELS: [Channel; N] = [/* .. */];

unsafe fn grab() -> Option<&mut Channel> {
    let static_priority = get_static_priority();
    // omitted: scaling priority down to a logical index
    let channel = CHANNELS.get_mut(index);
    // omitted: check `taken` flag; return `None` if already taken
}

impl defmt::Logger for Logger {
    fn acquire() -> Option<NonNull<dyn defmt::Write>> {
        let channel = unsafe { acquire() };
        // omitted: set `taken` flag; cast into trait object
    }
    fn release(channel: Option<NonNull<dyn defmt::Write>>) {
        // omitted: downcast `channel` to `Channel` then clear `taken`
    }
}

With the proposed Logger trait changes, the grab operation (or something like it?) needs to be called on each Logger::write call because Logger::write doesn't get a handle to the interrupt-priority-local logger (the dyn Write trait object).
impl defmt::Logger for Logger {
    unsafe fn write(bytes: &[u8]) {
        // no handle passed as an argument; logger needs to be retrieved again
        if let Some(channel) = grab() {
            channel.write() // Channel::write
        }
    }
}

So that's extra overhead per write operation.

Indexing into CHANNELS should be just a handful of asm instructions, which I think is comparable to the overhead of doing a write call through a vtable.
Aside from that, this new API allows for inlining write, plus in many cases it allows completely optimizing away the entire Formatter.
I'd be very surprised if it's slower all things considered.

Also, your example can be optimized a bit more: it's enough to check TAKEN in acquire instead of every write.

Ran the numbers again on my project. This is still 54% code size savings!
               total  defmt
no defmt      115922
defmt main    151746  35824
defmt nowrite 132378  16456

Thinking about this, could we make write a safe function by passing a &mut self to it and returning Option<Self> from acquire?

Thinking about this, could we make write a safe function by passing a &mut self to it and returning Option<Self> from acquire?

That would be nearly the same as the current code, only folding Writer and Logger into the same trait: defmt would have to hold a dyn Logger instead of a dyn Writer. I don't think it'd realize any code-size savings.

That would be nearly the same as the current code, only folding Writer and Logger into the same trait: defmt would have to hold a dyn Logger instead of a dyn Writer. I don't think it'd realize any code-size savings.

This is now heavily bitrotten. I was hoping this could be in 0.2 but nope :(
Is there still interest in doing this? @japaric @jonas-schievink

Yeah, I do think we want this, or something like this. I don't currently have the time to come up with the best solution here though.

Rebased (rewrote) on latest master. Here are the numbers. This time reduction is only 27%. I still haven't investigated why. Maybe it's other kind of bloat introduced in 0.2 that doesn't get removed by this?


Let users specify the lags the time series pipelines should compute in AutoMLSearch

As a user of EvalML for time series problems, I expect to be able to configure a set of lags all time series pipeline should compute. This would let me incorporate my business knowledge into the search.
Came up during the design of #2733.  I think it will be a useful feature but this is nice-to-have for down the road as it's blocked by other issues and it's not part of our beta requirements.

Yep this seems quite helpful.
Don't we already support this in automl search via pipeline_parameters? Or would that not work for the time series params?


Enable-WriteCore-feature-for-securitycenter

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.ResourceManager.SecurityCenter


Makefile paths & binary files

Changed reference in Makefile to /src/Parser/lex.yy to src/Parser/lex.yy
Added .gitinore file
Added rules to .gitignore file to ignore executables and intermediate compilation files (*.o, etc.)
Removed binary files from repo

Are you sure we should ignore the makefile?

Hi,
It's been months, but probably not, one doesn't want to ignore the Makefile :) I can't remember why I put it there, really.
Miquel

Aside from the need of removing the Makefile from the .gitignore file, the rest of this PR would be quite useful, since as of now the fact of having all the object files downladed from the repo makes it necessary to issue a "make clean" before the build, otherwise on some architectures the linker finds trouble linking the mix of newly-created .o files with the old ones.

+1 this PR solved my problems compiling.

Dear VAL supporters. We've recently managed to re-merge a large fork (see https://github.com/KCL-Planning/VAL/pull/42) and in the process resolved many popular requests, did a major clean-up and made things ready for continuous integration, which will help us safely service future pull requests. We've also setup a build pipeline to democratize binaries for Linux, Windows and MacOS users.
We understand that resolving merge conflicts in your forks may be difficult and will cause some short term pain, but we believe this is a good investment for the future of the project and hope to see your future contributions into this cleaned-up codebase!


date-picker :clearable="false" not work with type="datetimerange"

Element UI version
2.2.1
OS/Browsers version
win10 google & firefox
Vue version
2.5.13
Reproduction Link
https://jsfiddle.net/ng347h9m/1/
Steps to reproduce
1.use el-date-picker
2.set type as datetimerange
3.set clearable as false
What is Expected?
the clear button appeared and clickable
What is actually happening?
this clear button should not appear

If you add a clearable prop for an element, the clearable value will be true. If you want to set this prop as false, you should add :clearable="false" for the component.
Update example here: https://jsfiddle.net/mmx38qxw/476/

@furybean im using :clearable="false" certainly
sorry for the code was wrong, however the issue can be reproduced
i just updated the code, and u can see in
https://jsfiddle.net/mmx38qxw/489/

:clearable="false" means there is no clear button
:clearable="true" means there is clear button

Your demo behaves correctly.

try this plz
https://jsfiddle.net/ng347h9m/1/

By "clear button", we mean this one:

You can hide the Clear button by using the below css snippet. it's a hack though 😞
<style scoped>
button.el-button.el-picker-panel__link-btn.el-button--text.el-button--mini {
  display: none;
}
</style>

How to catch or how name is event when  happens click  'clear button'?


Category on Y axis or reverse graph?

Hello,
I am trying to move from Chartjs to C3js. I have no problems with lines and donuts charts.
In this case (chartjs graph)  https://codepen.io/prtome/pen/aGWqWJ   I have a time series on x axis and a category on y axis.
Following a previous question I understand that categories on Y axis are not supported.
I tried the following : https://codepen.io/prtome/pen/zjVJEX
I get my data from a database, so I use the ids for the Y columns, and provide the names:
var toto={};
toto[0]="start date";
toto[1]='AAA';
toto['1_unica']='AAA';
toto[4]='BBBB';
etc...  Then my column datasets are:
['1',null, 1, 1, 1, null, null],
['1_unica',null, null, null, null, 1, 1],
['4',null, 4, 4, 4, null, 4],
etc..
the ticks are defined as
tick: {
values: [0,1,4,8, 18],
count:1,
format: function (d) { return toto[d]; }
}
It all works, I get the correct labels etc, BUT the spacing between my different Y ticks correspond to the values. Is there a way I can have regular ticks independently of the values ?
if not, I though about 2 solutions, one being to modify the retrieved data so that values are linear , or reverse the graph while building it: Y axis linear, x axis category and then rotate it to have the X and Y as I want them. Is that possible ? I could not find anything in the docs about that.
One last question, is it possible to change the colours of the grid? I cannot find that either .
Thanks a lot .

Hi,
The issue queue is to be used for reporting defects and problems with C3.js, in addition to feature requests and ideas.
It is not a catch-all support forum.
For general support enquiries, please use the Google Group at https://groups.google.com/forum/#!forum/c3js.
All questions involving the interplay between C3.js and any other library (such as AngularJS) should be posted there first!
Thank you!


Remove explicit prefix for email subjects and use $prefix instead.

Rather than explicitly prepending the prefix to the subject in code, have individual spreadsheets add the prefix themselves, this simplifies code logic and makes subjects more explicit and flexible.

Changing this will likely warrant moving to v1.1.x since this breaks existing data.


Bioconda CDN sync is down

Checklist

[X] I added a descriptive title
[X] I searched open reports and couldn't find a duplicate

What happened?
The CDN hasn't synced for Bioconda in roughly 24 hours. I'm rolling out updates to ~3000 packages at the moment so I imagine it's being stressed.
For testing, you can check https://anaconda.org/bioconda/ucsc-hggcpercent, which has a new version now returned by conda search or mamba search.
Conda Info
NA

Conda Config
NA

Conda list
NA

Additional Context
NA

Thanks for your report, I've forwarded it to the infra team at Anaconda to review what's going on

@dpryan79 The sync has been kicked off again, would you mind verifying if this works now?

Thanks @jezdez it seems to be back. We'll see what happens when I slam it with more packages :P

We're looking into it

Is this still an issue or was this addressed?

This was addresses as part of #836. Closing as duplicate.


mc_pos_control limit to 50 Hz

partially helps with https://github.com/PX4/Firmware/issues/11604

Tested on Pixhawk 4 v5; no issues were noted, good flight in general.
https://review.px4.io/plot_app?log=a5db1a1c-644f-43bf-acf5-390844fc685d
Master was tested as well; no noticeable differences.
https://review.px4.io/plot_app?log=c3e08940-4078-466e-aff1-853e28aad108
Tested on Pixhawk 4mini v5; no issues were noted, good flight in general.
https://review.px4.io/plot_app?log=2c918d21-88e7-4932-9ee3-c440b8200646
Master was tested as well; no noticeable differences.
https://review.px4.io/plot_app?log=a6268987-ab5c-4d87-8bbf-e503b30964f1

Tested on Pixhawk cube v2;
It was tested in all modes Position, Altitude, Stabilized, Mission and RTL and it works very well in all modes.
Note;
It was compared with mater and no noticeable change was seen, but it went well.
FLIGHT (PR11639)
https://review.px4.io/plot_app?log=b5d31c42-f989-485d-846e-d3c3d06138f5
FLIGHT IN MASTER  (COMPARISON)
https://review.px4.io/plot_app?log=69241f72-179d-4095-9a32-a22e9c371875


Bulk2

Bulk file upload

Description

Types of changes

Checklist

[x] I have read the CONTRIBUTING doc
[x] I have checked that unit tests pass locally with my changes
[x] I have run the npm script lint on the frontend and backend
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)
[x] I have approval from the product owner for the contribution in this pull request

Further comments

It failed


Feature:dont use query port

This PR adds an optional option to connectionOptions.dontUseQueryPort which causes the library to not try to connect to the "query port".
The motivation for this is that I've noticed that some servers doesn't expose that port, which causes that connection to fail repeatedly, flooding the logs with errors, even though the other functions still work fine.

Are these servers off-spec in the sense that those query port messages should be sent over a upper or lower port instead or do they just not use any query port features?

Are these servers off-spec in the sense that those query port messages should be sent over a upper or lower port instead or do they just not use any query port features?

I'm not sure tbh. I've only gotten so far that I see that it's not possible to open the socket connection to the query-port at all. I'm guessing (not verified) that it's an issue with a firewall, and that the functionality that uses the query-port simply does not work atm.


Inconsistent behavior when adding dependency tracked in workspace to member

Problem
When I declare a dependency that includes an underscore (_) in its name under [workspace.dependencies] in the manifest of my virtual workspace and then add that dependency to a member crate using cargo add, I get different results depending on how I invoke the command:

If I specify the dependency with an underscore, it is added to the member manifest as <dependency>.workspace = true
If I specify the dependency with a hyphen, it is translated but then added to the member manifest as <dependency> = "version"

Expected behavior: Since the dependencies are the same in both cases, I would expect both invocations to result in <dependency>.workspace = true.
Steps
Folder structure
|-- Cargo.toml
|-- crate/
|---- Cargo.toml

Cargo.toml (workspace)
[workspace]
members = ["crate"]
resolver = "2"

[workspace.dependencies]
env_logger = "0.11.5"

Cargo.toml (crate)
[package]
name = "foo"
version = "0.1.0"
edition = "2021"

[dependencies]
env_logger.workspace = true # cargo add env_logger
env_logger = "0.11.5" # cargo add env-logger

Possible Solution(s)
It seems like Cargo compares the desired dependency to the dependencies listed in the workspace manifest at some point, to decide when to use <dependency>.workspace = true. It also seems like Cargo translates hyphens to underscores when appropriate. But perhaps the comparison happens before the translation, so we see this behavior (just my guess). If we reverse the order of those operations, then that should solve the issue.
Notes
No response
Version
cargo 1.76.0 (c84b36747 2024-01-18)
release: 1.76.0
commit-hash: c84b367471a2db61d2c2c6aab605b14130b8a31b
commit-date: 2024-01-18
host: x86_64-apple-darwin
libgit2: 1.7.1 (sys:0.18.1 vendored)
libcurl: 8.7.1 (sys:0.4.70+curl-8.5.0 system ssl:(SecureTransport) LibreSSL/3.3.6)
ssl: OpenSSL 1.1.1w  11 Sep 2023
os: Mac OS 14.6.1 [64-bit]

It looks like a dup of https://github.com/rust-lang/cargo/issues/13702 and has already been fixed by https://github.com/rust-lang/cargo/pull/13765. The fix is available in latest nightly and targeted at 1.83 release. Close as resolved. Thank you.


Update PEER

Hi professor: this is the updated version of PEER factor analysis with all detailed documentations and minimum working examples using sample data from PEER. A small bug is listed.  I will wrap up the docker image for PEER and APEX tmr. Hope it can be finished by Thursday.

@Gou-29 terrific! Do you think you can base your docker image on an existing docker config I have? eg check it here:
https://github.com/gaow/misc/blob/master/docker/base-notebook.dockerfile
this is avaiable from dockerhub as gaow/base-notebook.

@Gou-29 one suggetsion is don't include numbers in section titles. Just use the proper level of # that's enough and is better Otherwise it looks good! I like it that you do show results generated. Do you think you can explain in a few words the take home information from those plots?

I will try it then. I think PEER is very special in its dependent. It cannot work for a higher version of R as well as a lower version of R... I will work on it then to see what will happen. Also, I failed to download APEX so I will try to wrap APEX in the same docker file.

Posted here: https://cumc.github.io/xqtl-pipeline/pipeline/data_preprocessing/covariate/PEER_factor.html

I think PEER is very special in its dependent. It cannot work for a higher version of R as well as a lower version of R...

In that case feel free to create its own minimal docker image!

I failed to download APEX so I will try to wrap APEX in the same docker file.

I think it is best to make seperate images for different notebook modules. Then it will make more sense that each image is as small as possible. For APEX, do you think we can use a basic, < 100Mb Debian Linux image to execute?


Con 2423 product reviews for base product

Coverage increased (+0.003%) to 23.911% when pulling b14c24c1fc28a073de63df332942f6d3d9de863b on CON-2423-product-reviews-for-base-product into 558de9ad02455e11e9e552a23b1ae124a8f19143 on master.

Coverage increased (+0.003%) to 23.896% when pulling fcd8cb53cc9dbe8ccd854da231e95f93b094f862 on CON-2423-product-reviews-for-base-product into 4e29f5f2f2c88fe8540a5979cca2a5a99aea8906 on master.


Condensed theme for desktop

Info density has increased quite a bit since this issue was opened. Compressing further would not look as nice.


Skip tests that are flaking, holding up merge queue

Signed-off-by: Jhon Honce<EMAIL_ADDRESS>

LGTM


coverted spec to MD

Move text to Markdown format and did my best to add the correct formatting

Ok. I did the file conversion in my own cloned copy and made the formatting changes as needed. Merge if it looks good to youo

Coverage remained the same at 98.626% when pulling 293989ce52f9311cd62d9e3685cf319a11065f24 on jhdalek55:patch-1 into 2674d6e289af7ba864dd793d8380b9c0b105422d on theupdateframework:develop.

Coverage remained the same at 98.626% when pulling 293989ce52f9311cd62d9e3685cf319a11065f24 on jhdalek55:patch-1 into 2674d6e289af7ba864dd793d8380b9c0b105422d on theupdateframework:develop.

Coverage remained the same at 98.626% when pulling a2581dc19335e2e86434459df109b6bbe4b58d13 on jhdalek55:patch-1 into 2674d6e289af7ba864dd793d8380b9c0b105422d on theupdateframework:develop.


obsidian integration

an obsidian vault just md files organized in regular directories. it would be pretty cool to have daylog write its files into an obsidian vault—the tools would play pretty seamlessly together.
daylog would need to have support added for choosing where a project lives.
what does work though is symlinking daylog's data directory to an obsidian vault, ln -s "/Users/nate/Library/Application Support/daylog" /path/to/obsidian/vault/

hrm, obsidian has a daily note feature already :\


Updates for stencil storybook angular

Hello. The essence of this PR unconditionally enables Webpack 5, Babel 7 for Storybook, but just for Stencil package of this repository. No Nx migration additions have been developed since this is my first Nx development which I'm still learning it's internal api. To mention one of the several reasons for this development on my part is to use .tsx files for Storybook stories without lit-html, which this PR introduces, but with one caveat. That caveat is in the __componentFileName__.stories.tsx.template file along with a comment above it.
Feel free to ask any questions and or make edits. Thanks again for this this repo!
Also, prior to using the script below, run verdaccio locally and: clone, build and publish (/dist/packages/stencil package) with semver version of choice. Below I used 14.0.3-local.1.


Add /gala page

As a visitor,
When I visit /gala
There should be a page highlighting our Gala fundraiser, including, location, date & time, quick summary, planning committee co-chairs & members (along w/ their Slack handle), sponsorship prospectus, a way for companies to pay for a table or seats.

We need copy for this.

Nov 10, 2017
Governor's Ballroom, Sentinel Hotel
Portland, Oregon

On Apr 23, 2017, at 3:36 PM, Conrad Hollomon<EMAIL_ADDRESS>wrote:
We need copy for this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Going to track this in operationcode/operationcode_frontend#44.

Any images or format you'd like this page in?
claimed


MATT DOESNT HAVE THE RIGHT PERSMISSIONs

someone please give Matt permitions so that I can assign him stuff

Sent him a member invite to GCTC-NTGC.


remove pending pipelinerun related code; leverage k8s resource quota in e2e; sandbox quotas in stonesoup

hey @stuartwdouglas
my official follow up from PLNSRVCE-928 and its findings that we discussed back in January, where the pending pipelinerun stuff is not providing any real value if k8s resource quotas are in place
tl;dr at https://docs.google.com/presentation/d/1-59oAK3fdlWlrvFXTnheRLFtSLh1fOYiE-7BEh4-C1I/edit#slide=id.p
So I've removed the functionality in the PR to free up cycles/mem in the controller
the service registry / periodic should sufficiently throttle with the policy in place

/test jvm-build-service-in-repo-apicurio-e2e

/test jvm-build-service-in-repo-apicurio-e2e

One of the Apicurio failures looks like a PipelineRun failed to launch any pods. I don't think this is unique to this PR (we have definitely seen it before), but I do wonder if moving to a pod based limit will mean that sometimes pipelines will fail if there are too many concurrent runs.
I have opened https://github.com/redhat-appstudio/jvm-build-service/pull/517 to get the PipelineRun yaml as well as the log files to try and get more information about what has happened. Once this is merged I will rebase this one and see if it happens again.

One of the Apicurio failures looks like a PipelineRun failed to launch any pods. I don't think this is unique to this PR (we have definitely seen it before), but I do wonder if moving to a pod based limit will mean that sometimes pipelines will fail if there are too many concurrent runs.
I have opened #517 to get the PipelineRun yaml as well as the log files to try and get more information about what has happened. Once this is merged I will rebase this one and see if it happens again.

yeah during my https://issues.redhat.com//browse/PLNSRVCE-928 testing @stuartwdouglas I never saw k8s fail a pod launch because of quota (i.e. a timeout)
now, I could see launched containers get cpu/mem constrained and lead to resource constraint flakes
but yeah, let's wait on #517 and re-analyze with that change in to confirm one way or the other

/test jvm-build-service-in-repo-apicurio-e2e

/test jvm-build-service-in-repo-apicurio-e2e

wow @stuartwdouglas @dwalluck since I last paid any attention the dependency builds are getting really close now for service registry :-)
    types.go:24: time: 2023-03-03 05:37:22.778199327 +0000 UTC m=+2736.327186512: dependencybuild FINAL created count: 130 complete count: 126, failed count: 4, contaminated count: 0
taking a look at the failures now

Yeah, moving forward, if there is a pipeline run failed to launch a pod, I would be curious about cross referencing any pods whose name prefix correlates with the pipelinerun name in the events.json.
A resource constraint around pod launch should be captured in the events.

Lastly,  if we ever see cpu/mem related resource constraints, even with the 50 pod count limit, instead of reverting back to employing pending pipeline runs, we'll want to replicate more of the sandbox ResourceQuota and LimitRanges in the periodic e2e
Where we pick somewhere in between what I had from https://github.com/redhat-appstudio/jvm-build-service/pull/422 which were the original sandbox defaults, to https://github.com/redhat-appstudio/jvm-build-service/pull/421, which was optimized for fastest completion.

Those are all known failures that we are working on. This is looking good so lets get it in.


fix(updates): select Titanium SDK after installing it

Updates titanium-editor-commons to fix an oversight where the SDK wasn't selected after installing it. If any errors occur (for example appc ti sdk requires a login) then we'll prompt to run it in the terminal
Also fixes a deprecation warning in executeTask

Messages

:book:

:white_check_mark: All tests are passing
Nice one! All 98 tests are passing.
(There are 3 skipped tests not included in that total)

:book:

:floppy_disk: Here's the built vsix for this change.

  Generated by :no_entry_sign: dangerJS against 4c2c526ef3c16252e126138590b0ecc88328f7a5


Make buoyancy gradients work with non-equilibrium moisture model

Is it that the code breaks? Or is it not correctly configured wrt the physics?

I noticed they were not implemented at all for the non-equilibrium moisture model. So I added that in this PR:
https://github.com/CliMA/ClimaAtmos.jl/commit/313f2b079b41bd5de4462182130085a98e46f848
However it's not really used anywhere - we don't have any non-equilibrium simulations running. So I'm not 100% sure if everything else is configured


App stuck in splashscreen in Android 4.3

It seems to be an issue related to Ionic2 running in the webview. It is not running in Android 4.3 and running with issues in 4.4.

Crosswalk may be a solution.
Reference: https://github.com/crosswalk-project/cordova-plugin-crosswalk-webview

Resolved by https://github.com/RioBus/ionic/pull/52.


Use clang on osx and use toolchain

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Create the overall structural layout

General

[ ] semantic markup

[ ] ARIA roles where required

[ ] responsive layout, without JS, pure HTML/CSS

Layout

[ ] [Desktop] 2 columns, centered in the page body

[x] Header spans both columns and includes the primary navigation
[ ] Main column contains the actual text body, including images. The width is determined by a maximum readable line length, depending on the font-size, probably specified in rem
[x] Aside column contains additional content in boxes. This might be meta information like tags, or totally unrelated stuff (like quotes/tubhrq)
[x] Footer spans both columns and includes three columns

the primary navigation
administrative navigation (required links to privacy document(s), ...)
copyright notice

[ ] [Mobile] On smaller screens, switch to a one column layout

[x] Define the required breakpoint for media queries in a central position
[ ] Include the media queries in the SASS files, where they need to be applied
[ ] Header includes the primary navigation

[ ] keep the primary navigation as long as possible, then switch to a burger menu
[ ] Burger Menu with pure HTML/CSS !!!

[ ] Main Column contains the actual text body, including images. width will generally be 100%, might add some horizontal margins

[ ] Admonitions should retain their boxed look
[ ] Images still should have horizontal margins

[x] Aside column below the main column, width at 100%, but keep the boxes (vertically stacked)
[x] Footer, columns will now be rows

Resources

CSS Tricks: Flexbox
CSS Tricks: Grid
MDN Grid


allow cgroup for hidraw device

As it stands simply mounting the HIDRAW devices doesn't allow the Speed Editor to work - the Docker container must also have permission to access it.
This adds permissions to all HIDRAW devices (device major number 239) to the container, allowing the Speed Editor (and presumably any other attached HIDRAW panels?  I don't have anything else to test with) to work.

Hey thanks for this!  👍
Strange--  the speed editor was already working on Ubuntu for me.  From inside the container,  Here's my ls -la /dev/hidraw0
crw-------  1 nobody nobody 240, 0 Apr 25 11:46 /dev/hidraw0

I have a major dev # of 240 from both the host and the container.. does yours say 239?  Apparently this major device # is dynamically enumerated.
If you ARE having an issue accessing (docker?  podman?) maybe the run command should check for the major # and dynamically put it in?
Something like:
 HEX=`stat -c %t /dev/hidraw0` && echo "obase=10; ibase=16; ${HEX^^}" | bc

(if you're trying it in zsh it's)
 HEX=`stat -c %t /dev/hidraw0` && echo "obase=10; ibase=16; ${(U)HEX}" | bc

Thoughts?

Might something like this work?  It's a bit lazy and can be cleaned up, but this is would be the basic idea (rename to test.diff from test.diff.txt as it wouldn't let me attach a .diff)
test.diff

Okay, that suggests my fix is overly simplistic and we should do something like you say but we can't necessarily assume it's /dev/hidraw0!  I'll see if I can work out a way to probe for the Speed Editor on startup.
Mine shows up as crw-rw-rw- 1 root root 239, 0 Apr 26 07:52 /dev/hidraw0 on Ubuntu 22.04

Gotcha.  My method of picking the last /dev/hidraw# and then using that as the device number is definitely not elegant, nor is the kludgy way of setting a BLANK environment variable to "fill the spot" where the ${CGROUP_RULE} goes, but this was my fast fix to issues with quotes inside of quotes causing problems... maybe you have a nicer solution?
(I'm using podman btw with Ubuntu 22.04)

Oh, and I wasn't assuming it was /dev/hidraw0 in particular!  -- but I was assuming all the /dev/hidraw's were using the same major device number.

I have a better fix now


adding more details / clarify workflow chart

feedbacks from the channel

side note - maybe the Lab list box in https://github.com/instruct-lab/cli/blob/main/docs/workflow.png should say view the taxonomy diff to be clear
-- Jaideep

There's going to be a heavy lift of docs with the upcoming release - this one is fairly out-of-date at this point so I'm going to close it


Update README.md

fix outdated README section under csharp with working example.
#304

Thanks @Misterhex!


Would be great to be able to attach encoder to multiplexer inputs

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
As it is now it appears that you can only attach buttons to input multiplexers.  I am looking to migrate from SimVim to MobiFlight, and already have some G1000 panels where encoders connect to MUXs.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Would like the ability to map encoders to multiplexer inputs.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
**Stuck at the moment.  My current configuration leverages 10x MUXs for inputs and all buttons and encoders are connected to the MUXs.
Additional context
Add any other context or screenshots about

the feature request here.

I am running into the same problem. I am migrating from SimVim with some avionics that have encoders on the mux inputs.

Bumping up this request, as I am in the process of creating a G1000 look-alike with pretty much the above MUX / encoder issue as well. I would love to have this MobiFlight compatible, because creating and maintaining my own source code for something that already exists for 97% is not something I aspire to do ;)


Phrase CLI force Mac M2 to crash

Hey Phrase Team, i am struggling currently with  the phrase init command. The command takes 1 minute before he ask me for the token. if i enter the token, he told me that the client got a timeout while fetching the project list. Then my mac is kind of crashed. Applications with internet access are not responding, chrome self is responding but if i try to reload a page, also nothing happends. Like the internet is very slow. so have to hard shut up my mac in this case.  i tested it 5 times. every time the same issue. i work with a MacBook Pro 2022 with M2 Chip.
did you have any idea whats going wrong or how i can find out whats wrong?
thank you.

First, thanks for the very fast Answer! i tried the amd64 release and got the same behaviour. Just to be sure, steps to reproduce on my side.
Start Terminal with Rosetta.
uninstalled homebrew version of phrase cli
Download the  amd64 release, make it executable.
do phrase init with the amd64 release.
again the command is waiting one minute before asking for token.
then he tries to load projects. after 2-3 minutes i got this message: "Error: Get "https://api.phrase.com/v2/projects?page=1&per_page=100": dial tcp: i/o timeout". and then the most programms on my mac are gain not responding or has any internet connection.

Okay after a long exchange with the support (thanks for that) we came to the conclusion that the developers can not reproduce the bug and therefore unfortunately can not do anything for me.
The assumption was that maybe something with my firewall etc. could not be right. But when I fetch the project list manually via curl, I get everything I need. Also, even the "phrase info" command doesn't work, which shouldn't make a call.
i checked out the project locally and executed the commands via go. they work without problems. only with the finished package i have the problems.
Until I can spend more time again, I now use the not built version via go. thanks again for the effort and the attempt of the help

I've recently ran into this problem when setting up a new project with Phrase:
% phrase init
Loading projects...
Error: Get "https://api.phrase.com/v2/projects?page=1&per_page=100": dial tcp: i/o timeout

Same response (dial tcp: i/o timeout) when I try phrase pull on an existing and previously working project.
I'm using 2.5.3 (latest) on a 2020 Intel MacBook (so the issue is not specific to M2 it seems).

This turned out to be an DNS issue, so following the steps at this guide (https://developers.google.com/speed/public-dns/docs/using) has resolved the issue, and I'm able to run the phrase commands again. I'm not entirely sure why this problem was so specific to Phrase's CLI, but at least there's a workaround for now.

Just for the record, I had the exact same issue as @CevinEichnau
Using the Phrase CLI v2.5.3 on a MacBook Pro M1 from 2020.
Trying the DNS fix and updating to the last version of the binary.


More problems related to zone.js, ZoneAwarePromise and Handsontable

Description
Steps to reproduce

I create a new project based on the starter kit on https://github.com/AngularClass/angular-starter
I install angular handsontable according to https://handsontable.github.io/angular-handsontable/quick-start
I run yarn install
I run yarn start
I expect the project to run but instead it hangs on Loading... and the console says

In Firefox:
Error: Zone.js has detected that ZoneAwarePromise `(window|global).Promise` has been overwritten.
Most likely cause is that a Promise polyfill has been loaded after Zone.js (Polyfilling Promise api is not necessary when zone.js is loaded. If you must load one, do so before loading zone.js.)
Stack trace:
ac_polyfills</</</Zone.assertZonePatched@http://localhost:3000/polyfills.bundle.js:87042:23
NgZone@http://localhost:3000/main.bundle.js:5348:9
ac_main</</PlatformRef_.prototype._bootstrapModuleFactoryWithZone@http://localhost:3000/main.bundle.js:6065:22
ac_main</</PlatformRef_.prototype._bootstrapModuleWithZone/<@http://localhost:3000/main.bundle.js:6110:53
run@http://localhost:3000/main.bundle.js:122622:22
notify/<@http://localhost:3000/main.bundle.js:122635:30
flush@http://localhost:3000/main.bundle.js:134300:9
ac_polyfills</</</ZoneDelegate.prototype.invoke@http://localhost:3000/polyfills.bundle.js:87389:17
ac_polyfills</</</Zone.prototype.runGuarded@http://localhost:3000/polyfills.bundle.js:87152:28
ac_polyfills</</</Zone.prototype.wrap/<@http://localhost:3000/polyfills.bundle.js:87130:24

In Chrome:
Error: Zone.js has detected that ZoneAwarePromise `(window|global).Promise` has been overwritten.
Most likely cause is that a Promise polyfill has been loaded after Zone.js (Polyfilling Promise api is not necessary when zone.js is loaded. If you must load one, do so before loading zone.js.)
    at Function.Zone.assertZonePatched (polyfills.bundle.js:87042)
    at new NgZone (main.bundle.js:5348)
    at PlatformRef_._bootstrapModuleFactoryWithZone (main.bundle.js:6065)
    at main.bundle.js:6110
    at run (main.bundle.js:122622)
    at main.bundle.js:122635
    at MutationObserver.flush (main.bundle.js:134300)
    at ZoneDelegate.invoke (polyfills.bundle.js:87389)
    at Zone.runGuarded (polyfills.bundle.js:87152)
    at MutationObserver.<anonymous> (polyfills.bundle.js:87130)
(anonymous) @ main.bundle.js:53202

Demo
A demo is available here:
https://github.com/eitland/angular-starter
(just copied the starter repo and added angular-handsontable according to my reading of the documentation).
Your environment

Wrapper version: 1.0.0-beta2
Browser Name and version: Firefox 55.0.3 and Chrome 60.0.3112.113
Operating System: Windows 10 64 bit

Also see the description here https://github.com/handsontable/handsontable/issues/4495#issuecomment-329110036

Hi @eitland ,
did you tried this Method: #11
It works great for me !

@yehia2amer Haven't tried yet. I guess this will solve the problem but it is more than just a little bit hackish IMO so I'll keep this issue open for now.

OK, so I have a less hacky solution:
https://github.com/eitland/angular-starter/commit/27d3a414204a007a135c4f4ee12b495d9a19af85
and
https://github.com/eitland/angular-starter/commit/eb3cd223f1faee16503b2f2d09427047ad8caa28
I still think this should be solved upstream though, this is just for anyone else who happen to run into the same while using angularclass (no endorsement, I prefer the official angular-cli solution).

Thank you for sharing your thoughts. @swistach is currently out of the office until 25th of September. He'll take a look at the issue in the earliest convenience.

Any progress on this issue?
I get the same error message when I build with AOT and I can't seem to get any of the suggested solutions to work =/

I've made a Stackblitz example to show the problem

Sorry guys for keeping you waiting. @swistach has been given an important task that will take him at least two weeks so there is a huge possibility that we won't be able to examine this issue before the end of October.

Any update on this? We cant use Handsontable at the moment.

Here was my fix which is implemented in an angular directive I created.  It just lets Handsontable do whatever it wants and then cleans it up.
I think that this solution could be included in the handsontable.full.js so it cleans up after itself.  Better fix would be to just put the Promise rewrite code in a testbench as opposed to the main run code.
declare var require: any
let Promise0 = Promise;
let Handsontable = require('handsontable-pro/dist/handsontable.full.js');
Promise = Promise0;

Hi guys :).
Please also try to build app using (angular-cli) ng build --env --prod. Below you can check errors:

ng build works fine

@Berus
/***************************************************************************************************
 * Zone JS is required by Angular itself.
 */
import 'handsontable';
import 'angular-handsontable';
import 'zone.js/dist/zone';

Import like this solves build-prod

@fluxxu thanks for quick response
I was trying your solution but without luck :/. I still have the same error

any update on this?

shouldn't this situation be handled in USE_NATIVE (detect zone.js and do not overwrite the Promise in case of presence of zone.js)?

@fluxxu Your fix works, but unfortunately only with older node version (previous lts - 6.12.0), but on current lts (8.9.1) sill logs error on startup. (e.resolve is not a function)

@Reggis Do you know if the workaround works on node 6.12.0 with --aot?

 I haven't tried with<EMAIL_ADDRESS>I'm using the latest version. That's the only difference I see...


cargo install rerun-cli fails for v0.17.0

On macOS with rust 1.79.0:
rustc --version
rustc 1.79.0 (129f3b996 2024-06-10)

cargo install rerun-cli
    Updating crates.io index
  Installing rerun-cli v0.17.0
    Updating crates.io index
     Locking 618 packages to latest compatible versions
      Adding accesskit v0.12.3 (latest: v0.16.0)
      Adding accesskit_consumer v0.16.1 (latest: v0.24.0)
      Adding accesskit_macos v0.10.1 (latest: v0.17.0)
....

   Compiling re_types_core v0.17.0
error: Parse error while parsing value description: unbalanced source
  --> /Users/andres/.cargo/registry/src/index.crates.io-6f17d22bba15001f/re_types_core-0.17.0/src/lib.rs:15:10
   |
15 | #![doc = document_features::document_features!()]
   |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: this error originates in the macro `document_features::document_features` (in Nightly builds, run with -Z macro-backtrace for more info)

   Compiling arboard v3.4.0
   Compiling fsevent-sys v4.1.0
   Compiling filetime v0.2.23
error: could not compile `re_types_core` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
error: failed to compile `rerun-cli v0.17.0`, intermediate artifacts can be found at `/var/folders/5b/jlxfj70x1fb_n2l6qh21xxfh0000gn/T/cargo-installTQB5ME`.
To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.

Can confirm 😬

The fix is to add --locked:
cargo install rerun-cli --locked

Upstream issue: https://github.com/slint-ui/document-features/issues/26

Add recommendation to use --locked here: https://github.com/rerun-io/rerun/pull/6868

The faulty document-features version has been yanked: https://crates.io/crates/document-features/0.2.9
Thanks for reporting this to us!


Proposal: Second set of slides

I propose to create a second set of slides to be shown before and during the break after the 4th presentation.

The first slide would have a "Flea market" headline and a quick summary of the flea market rules (line up, 1-2 sentences, etc.)

It would be shown only during the flea market.

The second slide would point to Lucas' small bottles project.
The third and final slide would be shown during the whole break, containing just 3 bullet points:

Asking the audience to bring their bottles to the bar.
Asking the presenters-so-far to contribute to the presentation list of the pad, repeating the pad URL (https://pad.systemli.org/p/bhnt082), maybe including a QR code.
Showing the end time of the break. (Since that is a dynamic during value the event, it could be realized by a large <input> field injected into Markdown, to be filled in live on stage while the slide is shown. Alternatively, the organizer could edit and rebuild the slides, but I imagine this to be quite cumbersome to do live on stage.)

My questions:

Would that make sense to you?
How would we include these slides? Separate file? Add to the end of the existing slides? Other ideas?

great idea - would just put them to the normal slides - we also have the voting slide there as this is only shown on the end we can do the same with the "in-between-slide"

Okay, pull request provided. Two remarks on that:

Please note especially the input field at "Until"
I was using inline styling to fix some issues. Feel free to convert them into a custom SCSS file if you think this is appropriate.
@lucasrangit Feel free to fill in the "Help Lucas!" section and/or to add some picture as you see fit.

Okay, pull request provided. Some remarks on that:

I edited the existing slides for BHNT#81, so it will serve as a proper template for the upcoming BHNT#82.
Please note especially the input field after "Until" ;-)
I was using inline styling to fix some issues. Feel free to convert them into a custom SCSS file if you think this is appropriate.
@lucasrangit Feel free to fill in the "Help Lucas!" section and/or to add some picture as you see fit.

Changing assignee to @lucasrangit for my final question:
@lucasrangit Please adjust the "Help Lucas!" section as you see fit.

Fixed by #319


chore: Use slsa-verifier v2.2.0 in generate-builder

Fixes #1996

Blocked by #1984

Was blocked by Docker updating the golang base image again. Resolved by #1988
This PR should be able to move forward.

Blocked by #1996

Blocked by #1996

We need to wait until v1.6.0 is released and update the builder ref to refs/tags/v1.6.0

We need to wait until v1.6.0 is released and update the builder ref to refs/tags/v1.6.0

Actually we can't do that because we need this change to be merged for adversarial tests in RELEASE.md to work. So we need to temporarily disable the branch protection check for generate-builder-generic-no-compile and merge this change, do the v1.6.0 release which includes no-compile checks, and then after the release update the  builder ref  to v1.6.0 and reinstate the branch protection check.

I actually managed to get around the issue by adding a new testing flag to generate-builder which sets the SLSA_VERIFIER_TESTING flag. This should allow us to keep the pre-submit test.
Once we release v1.6.0 we can use that release for the pre-submit test and remove the testing input on generate-builder.


Uncomment Status Tracking test

Description
Uncomment test that required browser control of feature flags
Release notes
The title of the pull request will be used as the default release notes description. If more detail is needed to communicate to partners the scope of the PR's changes, use this release notes section.
Checklist
General

[x] Added the correct label: < feature | bug | dependencies | infrastructure | ignore-for-release >
[ ] Created tests which fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

User visible changes

[ ] Wrote browser tests using the validateAccessibility method
[ ] Manually tested at 200% size
[ ] Manually evaluated tab order

New Features

[ ] Add new FeatureFlag env vars to server/conf/application.conf
[ ] Conditioned new functionality on a FeatureFlag
[ ] Wrote browser tests with the feature flag off and on, etc.

Issue(s) this completes
Fixes #3071

Codecov Report

Merging #3993 (215747b) into main (356cef9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #3993   +/-   ##
=========================================
  Coverage     80.04%   80.04%
  Complexity     2450     2450
=========================================
  Files           298      298
  Lines          9790     9790
  Branches        663      663
=========================================
  Hits           7836     7836
  Misses         1698     1698
  Partials        256      256

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add initial top/left properties

This should fix an issue with header panels getting pushed up too much. In this case tool-bar.
Note: I couldn't reproduce this issue myself, but props to @jerone + @abdelouahabb who figured it all out. :clap: :heart:
Closes https://github.com/suda/tool-bar/issues/130

Sorry @simurai but this doesn't work for me: https://github.com/suda/tool-bar/issues/130#issuecomment-201225605

NP.. let's close this again.


Onboarding wiki page

https://github.com/LDSSA/wiki/wiki/Batch3-Student-Onboarding
Here's the first draft. Anything that anyone wants to add?

We could add the following:

Catarina Freitas (@catarinacf), who is in charge of student success, is a very good point of contact too! Just to give an example, last time we talked, we thought about having study groups on the days before the hackathons, and since I won't be in person in all of them, she is a very good backup contact in that case.
Another important item in "Important stuff to do" is to join the students slack
If we have 2., where we mention the tech-setup, we could link the slack channel where they can ask for support. I know this will probably be in the student repo too, but it can still be useful!


Select Bays in sidebar

As a user I want to select the bays in the sidebar-dropdown to get a better understanding which IEDs are part of which bay.
ACs:

[x] show Bays in the Bay selection dropdown
[x] it is possible to select a Bay via the dropdown – the Bay will be selected in the diagram

Selection and filtering:

@pwinkelholzS1 do you know what comes next here ? should we review the code PR or is it only a UI review ?

Current status: Needs clarification with TBW whether we use 1 or 2 dropdowns

Waiting for customer feedback


Feature: Grant followers modal

Ticket #3407
Description

Adds modal for displaying grant followers
Updates pagination for grant followers to allow for sorting by specific fields (created_at vs user name).

Screenshots / Demo Video

Testing
Automated and Unit Tests

[x] Added Unit tests

Manual tests for Reviewer

[ ] Added steps to test feature/functionality manually

Checklist

[x] Provided ticket and description
[x] Provided screenshots/demo
[ ] Provided testing information
[x] Provided adequate test coverage for all new code
[x] Added PR reviewers

Ok gotcha, this makes sense, thanks for the background. The story AC requests sorting alphabetically by name, if we don't need this change I can return to ordering by creation. While making this change I added support on the response to identify a final result set (next) to avoid the user clicking "Show More" an extra time at the end, do you have a preference for supporting this in cursor-based approach? e.g. paginateBefore

@greg-adams

The story AC requests sorting alphabetically by name, if we don't need this change I can return to ordering by creation.

Yeah, I just noticed that; we'd discussed in the comments of the parent issue (#2960) and decided to go with with most-recent-first instead, but it seems the DoD on #3407 was never updated to reflect that decision 🤦 .

While making this change I added support on the response to identify a final result set (next) to avoid the user clicking "Show More" an extra time at the end, do you have a preference for supporting this in cursor-based approach? e.g. paginate.before

I think the look-ahead behavior that you implemented in the query is exactly right! Since cursor pagination is typically based on an exclusive filter, I think the way we would incorporate that as a conditional instruction for cursor-based pagination would look something like this:
        pagination: {
            next: grantFollowersResult.length > limit ? grantFollowersResult[limit - 1].id : null,
        },

Essentially, we're instructing the client that

If pagination.next is not null, then there are more results.
To continue paginating (in the same direction) from where the final result left off, provide the value of the final result from this current page, which will then be used as an exclusive filter on the next request.

Note that the above is pretty implementation-specific, as it relies on the concept that a higher grant_followers.id value implies a higher grant_followers.created_at value as well. If we were paginating by user name if alphabetical order, this wouldn't work. In fact, it could be argued that the more "correct" way to provide a cursor for follower recency would be to provide pagination.next as a created_at timestamp (I chose to go with id in the original spec because it avoids an edge case stemming from more than one row with the same created_at value). But that shouldn't really matter as long as the client is treating the cursor as an arbitrary value.
A more agnostic way to implement cursors that support multiple ordering schemes could be to provide the value of grantFollowersResult[orderBy] as the pagination.next cursor, but I think that gets a little dicey/brittle without having a clearer sense of what scenarios we'd need to support.

No worries - I've updated to maintain use of created_at, keeping the next property to indicate an additional set


Getting an TraceBack error everytime i text from telegram

whatever i text on telegram i get this error, and the telegram bot says its typing and then just stops and doesn't send anything
This is the traceback error
user_text What’s up
user_text What’s up
generate_answer local variable 'tokens' referenced before assignment
cannot unpack non-iterable NoneType object
Exception in thread Thread-14 (thread_get_message):
Traceback (most recent call last):
File "E:\oobabooga_windows\installer_files\env\lib\threading.py", line 1016, in _bootstrap_inner
self.run()
File "E:\oobabooga_windows\installer_files\env\lib\threading.py", line 953, in run
self._target(*self._args, **self._kwargs)
File "E:\oobabooga_windows\text-generation-webui\extensions\telegram_bot\TelegramBotWrapper.py", line 765, in thread_get_message
raise e
File "E:\oobabooga_windows\text-generation-webui\extensions\telegram_bot\TelegramBotWrapper.py", line 746, in thread_get_message
answer, system_message = self.generate_answer(
TypeError: cannot unpack non-iterable NoneType object

Add some new parameters to config #130. At my config (llama.cpp + llama-2-7b) works fine.
Also, you can try to use api mode:

add --api to oobaboga flags
in telegram_config.json set "generator_script": "GeneratorTextGeneratorWebuiApi".

Please, share if it helps or not.

im not sure what i did wrong when i tried here.. but idk after restarting the webui it started to work

Can't this be closed, then?


[Suggestion] [1.18.2] Honey Glazed Walnut Usage

Hi there! Your mod is a nice compat layer for FD and Ecologics- thanks for the work you've put into it!
Not sure if it's been changed for 1.19, but in 1.18.2, the food values of the Honey Glazed Walnut are barely an improvement on the Ecologics Walnuts all by themselves. As honey can be annoying to get, I'd love to see a slight buff to the saturation of the Honey Glazed Walnut. I know it's a small detail, but I'd appreciate it.
Thanks!
-LilJagty

Done in 1.19.2, however 1.18.2 isn't in active development. If you want, you could PR the change for 1.18.2 and I will merge it. You can then retrieve the build from the workflow artifacts.

Done in 3.2.1


BUILD FAIL IN ANDROID

When I run flutter run :
Launching lib/main.dart on Moto G 5 Plus in debug mode...
Initializing gradle...                                       0.8s
Resolving dependencies...

Error running Gradle:
Exit code 1 from: /home/keshav/Projects/Flutter Projects/map_snippet/android/gradlew app:properties:

FAILURE: Build failed with an exception.

Where:
Build file '/home/keshav/Projects/Flutter Projects/map_snippet/android/build.gradle' line: 25

What went wrong:
A problem occurred evaluating root project 'android'.

A problem occurred configuring project ':app'.
org.xml.sax.SAXParseException; systemId: file:/home/keshav/Projects/Flutter%20Projects/map_snippet/android/app/src/main/AndroidManifest.xml; lineNumber: 1; columnNumber: 74; The prefix "android" for attribute "android:name" associated with an element type "uses-permission" is not bound.

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

Get more help at https://help.gradle.org

BUILD FAILED in 2s
Please review your Gradle project setup in the android/ folder.
This is how my what my pubspec.yml has :
dependencies:
  flutter:
    sdk: flutter
  cupertino_icons: ^0.1.0
  map_view: ^0.0.10
  matcher: '>=0.12.0 <0.13.0'
  utf: '>=0.8.10 <=0.10.0'
  quiver: '>=0.17.0 <=0.26.2'

dev_dependencies:
  test: '>=0.12.0 <=0.13.0'

Looking at the output error:
file:/home/keshav/Projects/Flutter%20Projects/map_snippet/android/app/src/main/AndroidManifest.xml; lineNumber: 1; columnNumber: 74; The prefix "android" for attribute "android:name"
It looks like you put the uses-permission in the wrong spot. You can refer to the example project to see where the uses-permission belongs.


Just the first word

Thank you for the lib. It´s amazing.
I had a problem with the text. For example:
instapy -u USR -p PSW -f FILE/LINK -t 'TEXT CAPTION'
I just post"TEXT". I can´t get the other words.

Maybe it's the string quotation that need to be changed from 'X' to "X"? (or viceversa?)

Please, reopen this issue if you get the same problem and add other useful details and your specific code.
🥂


GitHub Action to send notification to Slack when project is starred

How can we help?
As we track the adoption and use of Meshery as an open source project, it would be nice to see notifications sent to #meshery-notifications channel when a user stars the project.
Implementation
Use GitHub Actions to publish to Meshery's slack account.

We can leverage:
this to do it using GitHub Actions.
Events we can use are listed here - WATCH


SSHNPD Docker Image

Is your feature request related to a problem? Please describe.
N/A
Describe the solution you'd like
Docker image which accepts the arguments required to install sshnpd to a container.

Doesn't need tmux / to run in the background
Should be capable of being entirely configured via docker compose

For running on the docker host network

Describe alternatives you've considered
No response
Additional context
No response

I think this is already done here, it just needs to be documented.

@cpswan can you confirm what, if anything, needs to be done here?


Sema: Fix crash when defining an extension of a nested type with constrains

If the nested type itself has generic constraints, we would
hit an assertion in requirement inference. Refactor some code
so that we can make the assertion more accurate.
Fixes rdar://problem/30353095.

@swift-ci Please smoke test


Use predicted MV from larger size parent partitions for the ME for smaller block sizes < 32x32

Instead of always using 32x32 pred MVs as ME seed, which pre-computed for each SB and does not change during the encoding of the SB.

Done by 70005e353aa8ce21e3ecd257c927f71d4012a117
https://github.com/xiph/rav1e/pull/1177


Remove version: CheatBreaker.CheatBreaker version 2.4.3

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

For moderators or/and anyone else

[!Caution]
As a result of several personal problems I've had over the last few months + my final exams coming up very soon, I'm currently unable to look at my GitHub notifications every day and maintain my executions correctly.
If you detect a certain problem on a certain pul request:

Either you can close the pull request directly without mentioning me.
Or you can send me a message on X (Twitter): @Exorcism0666

Thank you for your understanding, and I'm sorry if some pull requests can't be approved due to the situation I'm in.

This account is automated by Github Actions and the source code was created by CoolPlayLin. If you have any questions about any pull request, don't hesitate to ping Exorcism0666.

[!warning]
With the new version of Komac, numerous Pull Requests may contain bugs or unwanted elements. If such issues arise, please tag russellbanks so that these bugs can be addressed in future updates.

[!important]
Please carefully review these Pull Request before merging. If it is a Pull Request for removing incorrect content and the URLs are issue, free upon manual checking, please close this Pull Request directly. (It is best to inform Exorcism0666 of the closure.)

良い一日をお過ごしください！

URL: https://github.com/CheatBreakerNet/Launcher/releases/download/2.4.3/CheatBreaker_Setup.exe
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 912)

Hi @Exorcism0666,
This manifest has the highest version number for this package. Is it available from another location? (This might be in error if the version is switching from semantic to string, or string to semantic.)
(Automated response - build 887.)

URL: https://github.com/CheatBreakerNet/Launcher/releases/download/2.4.3/CheatBreaker_Setup.exe
Response status code does not indicate success: 404 (Not Found).
(Automated message - build 887)

Close with reason: Duplicate of #163539;


display uiScanning component when marker is lost.

At present when the marker is lost  the uiScanning setting isn't displayed, ideally this should be displayed again once a market is lost.

yes. that sounds reasonable.

@JamesBotterill i think we can achieve this by making the mindar image systems subscribe to onMarkerFound and onMarkerLost event


[cherry-pick] cherry-pick release pr list

cherry-pick release pr list

Codecov Report

:exclamation: No coverage uploaded for pull request base (2.0.0-release-prepare@61d3fec). Click here to learn what that means.
The diff coverage is n/a.

@@                   Coverage Diff                    @@
##             2.0.0-release-prepare    #6739   +/-   ##
========================================================
  Coverage                         ?   37.65%
  Complexity                       ?     3212
========================================================
  Files                            ?      648
  Lines                            ?    26381
  Branches                         ?     2849
========================================================
  Hits                             ?     9934
  Misses                           ?    15533
  Partials                         ?      914

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61d3fec...523357f. Read the comment docs.

unused pr, i close it.


Add parse text error check

https://github.com/redibox/schedule/blob/master/src/hook.js#L21
If an invalid text schedule is passed, errors are not caught.  E.g. every 60 seconds:

https://github.com/redibox/schedule/commit/e2f2cb730add3ac8c0601b648eb82be5fe516aa6


chore(deps) bump Zipkin plugin to 1.1

This is conditional on:

Merging https://github.com/Kong/kong-plugin-zipkin/pull/78
Releasing a new version of the rock to Luarocks

It is already bumped, so closing this.


Fix: profiling for condition lines (e.g. elseif)

Problem summary
There is a case that script line is not profiled in spite of executed.
Repro steps
func.vim
func! Foo()
  if 0
    let x = 0
  elseif 1
    let x = 1
  endif
endfunc
call Foo()

vim --clean +'profile start prof.log' +'profile func Foo' +'so func.vim' +'qall!'
prof.log
FUNCTION  Foo()
Called 1 time
Total time:   0.000026
 Self time:   0.000026

count  total (s)   self (s)
    1              0.000007   if 0
                                let x = 0
                              elseif 1
    1              0.000004     let x = 1
    1              0.000003   endif

(snip)

The line of elseif 1 was executed but not profiled (0 count).
Cause
https://github.com/vim/vim/blob/master/src/ex_docmd.c#L2009-L2021
When ea.skip is false, func_line_exec() is called and do profiling for the line.
Basically means ea.skip depends on the state of the last line: (cstack->cs_idx >= 0 && !(cstack->cs_flags[cstack->cs_idx] & CSF_ACTIVE)), but elseif (or else) is executed when the last line is not active (==ea.skip is true).
Therefore I think it should take into account what the command of the line is, regarding to whether do profiling or not.
In addition
func! Foo1()
  while 1
    break
  endwhile
endfunc

func! Foo2()
  while 1
    return
  endwhile
endfunc

Currently, profiling this, both endwhile of Foo1 and Foo2 are counted 0:
count
    1   while 1
    1     break
    0   endwhile

    1   while 1
    1     return
    0   endwhile

I think it should endwhile of Foo1 is counted 1.
That is, when leaving from while (also for) loop by break or by the loop condition failure, I think endwhile (endfor) should be treated as executed and counted up.

Codecov Report

Merging #2499 into master will increase coverage by 0.03%.
The diff coverage is 96.15%.

@@            Coverage Diff             @@
##           master    #2499      +/-   ##
==========================================
+ Coverage   74.59%   74.62%   +0.03%
==========================================
  Files          92       92
  Lines      133004   133019      +15
==========================================
+ Hits        99208    99265      +57
+ Misses      33796    33754      -42

Impacted Files
Coverage Δ

src/ex_docmd.c
75.66% <96.15%> (+0.09%)
:arrow_up:

src/os_unix.c
54.33% <0%> (-0.19%)
:arrow_down:

src/gui_gtk_x11.c
47.65% <0%> (-0.05%)
:arrow_down:

src/message.c
68.67% <0%> (-0.05%)
:arrow_down:

src/if_py_both.h
76.59% <0%> (-0.01%)
:arrow_down:

src/userfunc.c
86.79% <0%> (+0.05%)
:arrow_up:

src/term.c
50.8% <0%> (+0.1%)
:arrow_up:

src/ui.c
46.39% <0%> (+0.15%)
:arrow_up:

src/window.c
81.94% <0%> (+0.16%)
:arrow_up:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de04654...88155d0. Read the comment docs.

Ozaki Kiichi wrote:

Problem summary
There is a case that script line is not profiled in spite of executed.
Repro steps
func.vim
func! Foo()
  if 0
    let x = 0
  elseif 1
    let x = 1
  endif
endfunc
call Foo()

vim --clean +'profile start prof.log' +'profile func Foo' +'so func.vim' +'qall!'
prof.log
FUNCTION  Foo()
Called 1 time
Total time:   0.000026
 Self time:   0.000026

count  total (s)   self (s)
    1              0.000007   if 0
                                let x = 0
                              elseif 1
    1              0.000004     let x = 1
    1              0.000003   endif

(snip)

The line of elseif 1 was executed but not profiled (0 count).

Yes, Vim does evaluate the condition.

Cause
https://github.com/vim/vim/blob/master/src/ex_docmd.c#L2009-L2021
When ea.skip is false, func_line_exec() is called and do profiling for the line.
Basically means ea.skip depends on the state of the last line: (cstack->cs_idx >= 0 && !(cstack->cs_flags[cstack->cs_idx] & CSF_ACTIVE)), but elseif (or else) is executed when the last line is not active (==ea.skip is true).
Therefore I think it should take into account what the command of the line is, regarding to whether do profiling or not.
In addition
func! Foo1()
  while 1
    break
  endwhile
endfunc

func! Foo2()
  while 1
    return
  endwhile
endfunc

Currently, profiling this, both endwhile of Foo1 and Foo2 are counted 0:
count
    1   while 1
    1     break
    0   endwhile

    1   while 1
    1     return
    0   endwhile

I think it should endwhile of Foo1 is counted 1.
That is, when leaving from while (also for) loop by break or by the loop condition failure, I think endwhile (endfor) should be treated as executed and counted up.

I don't agree for the "return" case.  The "return" means Vim jumps out
of the function.  What follows is not executed, only skipped over.
While with the "break" Vim does sort-of execute the endwhile, it
terminates the matching "while".
--
"Hit any key to continue" it said, but nothing happened after F sharp.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

I don't agree for the "return" case.  The "return" means Vim jumps out
of the function.  What follows is not executed, only skipped over.

Sorry for the lack of clarity, I think so too: when return, endwhile should not be counted (0 count), same as current.

Another (problematic) example
func.vim:
func! Cond()
  sleep 1
  return 1
endfunc
func! Foo()
  if 0
    let x = 0
  elseif Cond()
    let x = 1
  else
    let x = 2
  endif
endfunc
call Foo()

This is the case that a process taking time is called at elseif-conditional sentense.
vim --clean +'profile start prof.log' +'profile func Foo' +'so func.vim' +'qall!'
prof.log
FUNCTION  Foo()
Called 1 time
Total time:   1.005080
 Self time:   0.000050

count  total (s)   self (s)
    1              0.000004   if 0
                                let x = 0
                              elseif Cond()
    1              0.000018     let x = 1
    1              0.000002   else
                                let x = 2
                              endif

FUNCTIONS SORTED ON TOTAL TIME
count  total (s)   self (s)  function
    1   1.005080   0.000050  Foo()

FUNCTIONS SORTED ON SELF TIME
count  total (s)   self (s)  function
    1   1.005080   0.000050  Foo()

Foo() took about 1 second, but this profiling result does not show where took time although elseif Cond() was executed.

Are your comments / problems all fixed?

Are your comments / problems all fixed?

Yes (by latest commit).

There is also a known problem that while skipping contributes to self time, profiling will give you no idea where time was actually spent. This is not a theoretical issues because skipping is fast, this is one of the major causes leading to my formatvim plugin being written using code generation, 2html may have had the same issue.
You may see the problem by running vim -u NONE -i NONE -N --cmd 'so proftest.vim' with proftest.vim containing
function! Test()
    let i = 0
    while i < 1000
        let i += 1
        if 0
            t
            " Repeat the above line another 1023 times
        endif
    endwhile
endfunction

profile start /tmp/profile.log
profile func Test
call Test()
profile pause
qa

.
Maybe try rebasing / retriggering the build?

There was a CI failure, this usually causes the coverage to be inaccurate.
About skipping lines: it's hard to say where the time for skipping should be counted.  We could put it on the "if 0", but then it merges with the time spent evaluating the expression.  Putting the time on the lines themselves would give the impression that they were executed.  In the example we could put the time on the "endif", but if an "elseif" follows it gets confusing again.  Would need to do something weird, such has having the "elseif" line twice, once with the skip time and once with executed time.

@brammool
There was no CI error IIRC (looks like this was pushed again after my comment).

About skipping lines: it's hard to say where the time for skipping should be counted.

Having the line twice would be really weird indeed.
Couldn't there be another total ("Misc time") where it would be added to, without being on the line itself?

I've used this patch with Neomake's test now.
You can see the difference at: https://codecov.io/gh/neomake/neomake/pull/2027/changes

Yeah, the current build ran 3h ago.
Now one job timed out, that could be restarted.
However, coverage looks OK now.


How to update Thumbor and Python Pillow

Thanks for all your work on this @stevemorad
Really appreciate it.
Unfort, it seems like there are some issues in Thumbor / Python Pillow that prevent this solution from being 100% ready for a production environment. Specifically, it doesn't work properly for a number of PNGs that have transparent backgrounds (which is quite a common use-case).
Here is the ticket I opened with Thumbor:
https://github.com/thumbor/thumbor/issues/987
My question is: when Thumbor and Pillow are fixed/patched, what's the best process to update the Lambda function? Can I simply download Thumbor/Pillow exactly how they're released, download the Lambda package, replace the existing folders with the updated releases, and then re-upload?

Please post back when this issue is resolved. When it's fixed, your approach will work. We will also look to rebuild the published version to include updated Thumbor/Pillow after the issue is fixed.

Okay thanks I’ll check in with Thunbor

Version 2.2 now includes Thumbor 6.4.2 and Pillow 4.3.0. I believe this issue is now resolved. Would you confirm and close this issue if so?

Sure I'll test this after the easter-weekend and reply back here.

Just ran into this:
1 validation error detected: Value '%%BUCKET_NAME%%-us-west-2' at 'code.s3Bucket' failed to satisfy constraint: Member must satisfy regular expression pattern: ^[0-9A-Za-z\.\-_]*(?<!\.)$ Client Request Token:Console-CreateStack-1a5ee31e-4bb5-4ea9-bc4d-48e11328a5c6
I ran into something a while back; my bucket is named (something like):
app.local.domain.com.s3.amazonaws.com

Did you test the new template directly from GitHub without running it through the build process? The bucket name variable does not appear to be configured properly (%%BUCKET_NAME%%-us-west-2).
If you want to test a precompiled version, please use the published template:
https://s3.amazonaws.com/solutions-reference/serverless-image-handler/latest/serverless-image-handler.template
Or make sure you follow the build process and use the build-s3-dist.sh file in the deployment directory to build the zip files using your own distribution bucket (e.g. ./build-s3-dist.sh mybucketname)

Also, I tested with sih.origin as the origin bucket and did not have any problems with the constraint or lambda functions using a bucket with a dot (.) in the name.

If you want to deploy our prebuilt version of the solution, then you do not need to modify the template above. Just configure CloudFormation to launch the template, and provide your image bucket as an input parameter when uploading to CloudFormation. Alternatively, use this link and configure your AWS region to the region you want to launch the solution:
https://console.aws.amazon.com/cloudformation/home?region=us-east-1#/stacks/new?stackName=ServerlessImageHandler&templateURL=https:%2F%2Fs3.amazonaws.com%2Fsolutions-reference%2Fserverless-image-handler%2Flatest%2Fserverless-image-handler.template
More information about launching the prebuilt version is available here:
https://docs.aws.amazon.com/solutions/latest/serverless-image-handler/welcome.html
You only need to replace "solutions" in the template when you want to deploy your own/modified version of the solution. The solution has 3 parts, so you only need to modify the template to point to the specific part(s) you modified:

The main function that implements thumbor is called serverless-image-handler.zip and line #106 tells the template what bucket you have put your modified version of this lambda function zip file. Line #258 will actually take this bucket name and add "-region" to the end of it. We do this because CloudFormation requires the bucket with your lambda code be in the same region as you are launching the template. We stage copies of the lambda files in every region to support this requirement. So, the prebuilt zip files are located in solutions-region buckets (e.g. solutions-us-east-1).
The solution has a CloudFormation custom resource called serverless-image-handler-custom-resource.zip that helps with automating the solution deployment. For example, it deploys the demo website to your S3 bucket if requested. Line #116 tells the template the bucket prefix for where this custom resource.
The demo website is zipped in serverless-image-handler-ui.zip and the bucket prefix is configured with line #128

We offer a prebuilt version so you don't have to worry about any of this if you just want to launch the solution. If you want to modify it, we provide the code and build scripts here on GitHub so you typically don't have to worry about modifying specific lines in the template (but that also means you will need to put the three zip files mentioned above into your own distribution bucket).
Hope this helps.

Thanks for all the details @stevemorad
I really appreciate it.
I was able to get the stack up and running, but wanted to document a couple things here for anyone who stumbles on this (along with a concern around this being production-ready; albeit it may be an issue with Pillow/Thumbor and not this repo).
I needed to change the stack region.
From this:
https://console.aws.amazon.com/cloudformation/home?region=us-east-1#/stacks/new?stackName=ServerlessImageHandler&templateURL=https:%2F%2Fs3.amazonaws.com%2Fsolutions-reference%2Fserverless-image-handler%2Flatest%2Fserverless-image-handler.template
To this:
https://console.aws.amazon.com/cloudformation/home?region=us-west-2#/stacks/new?stackName=ServerlessImageHandler&templateURL=https:%2F%2Fs3.amazonaws.com%2Fsolutions-reference%2Fserverless-image-handler%2Flatest%2Fserverless-image-handler.template
Notice the region value; otherwise it was creating a stack in the wrong region for me.

When defining the value for my bucket, I initially entered the wrong value.
I entered it as: app.local.domain.com.s3.amazonaws.com
The correct value was app.local.domain.com, since that's the actual bucket name. I was incorrectly appending .s3.amazonaws.com
Heads up in case anyone else does this by accident.

Finally: this version of the template is definitely an improvement.
I noticed:

An increase in the quality of the thumbs produced (old version / new version); if you zoom in in your browser, you'll see a substantial improvement in the quality
Some png/gif cases that errored out are now able to be served: ( before #1 / after #1, before #2 / after #2, before #3 / after #3)

The concerns around this being production ready:
In before/after cases #2 and #3 above, the resulting resized thumb isn't valid. What I mean by that is some or all of the background-transparent pixels are being converted to black. I'm going to list out below the two cases again, along with the original file, and what the resulting thumb should look like (which I currently use Cloudinary for conversion, which does it correctly):
Case #2:
Original file: http://s3-us-west-2.amazonaws.com/app.local.getstencil.com/upld564d2305
Resized thumb using this version of the template: https://d3jqyot5ky4oh9.cloudfront.net/full-fit-in/304x212/filters:quality(100)/upld564d2305
What it should look like (served by Cloudinary): https://dx5683gi1tv0w.cloudfront.net/dtrjyhj9q/image/upload/if_ar_gt_1.0,h_212,c_scale/if_else,w_304,c_scale/s3.local/upld564d2305
Case #3:
Original file: http://s3-us-west-2.amazonaws.com/app.local.getstencil.com/upldfc4d6cb3
Resized thumb: https://d3jqyot5ky4oh9.cloudfront.net/full-fit-in/304x212/filters:quality(100)/upldfc4d6cb3
What it should look like (served by Cloudinary): https://dx5683gi1tv0w.cloudfront.net/dtrjyhj9q/image/upload/if_ar_gt_1.0,h_212,c_scale/if_else,w_304,c_scale/s3.local/upldfc4d6cb3
I'm assuming these may be Thumbor/Pillow converting issues. But because of that, I can't rely on the CloudFormation for all my production needs.
The way I get around this is by only serving images that have the mime type value image/jpeg through this CloudFormation stack, and then using Cloudinary for all other types.
@stevemorad sorry if this is overly long. It took me a lot of work to figure out all this, so I'm hoping this is useful for this project to be improved, and/or anyone else who's considering using this in a production environment.

@stevemorad  This ticket has a comment that Version 2.2 includes thumbor 6.4.2 which would make this pull request able to be closed.  But I don't see thumbor 6.4.2 in the master/source/image-handler/setup.py (says 6.2.1).  Can you confirm if I am missing something silly or if perhaps something was not checked in to setup.py?

Did you test the new template directly from GitHub without running it through the build process? The bucket name variable does not appear to be configured properly (%%BUCKET_NAME%%-us-west-2).
If you want to test a precompiled version, please use the published template:
https://s3.amazonaws.com/solutions-reference/serverless-image-handler/latest/serverless-image-handler.template
Or make sure you follow the build process and use the build-s3-dist.sh file in the deployment directory to build the zip files using your own distribution bucket (e.g. ./build-s3-dist.sh mybucketname)

Just FYI, I was also getting the error @onassar reported, but my problem ended up being that I was using the uncompiled template directly from the repo. Once I used the compiled version linked by @stevemorad I no longer got the bucket name error.