PromiseKit version of .observe conflicts with Apple's defined .observe for KVO operations

PromiseKit version: 5.0.1
Today I was attempting to use KVO to monitor the title attribute within a WKWebView. Using the definition provided by Apple presented some very odd compiler warnings referring to PMKNamespacer. Digging in shows that PromiseKit has a wrapper of sorts for working with KVO in a promise fashion. I'm confused why this function is conflicting with the standard library's definition though as they don't match in type or even parameter order.
// Error: Cannot convert value of type 'KeyPath<WKWebView, String?>' to expected argument type 'PMKNamespacer'
webView.observe(\WKWebView.title) { (_, title) in
    print("Title: ", title)
}

// Error: Extra argument 'options' in call
webView.observe(\WKWebView.title, options: [.initial]) { (_, title) in
    print("Title: ", title)
}

// Error: Incorrect argument label in call (have '_:changeHandler:', expected '_:keyPath:')
// The compiler's autocorrect wants to swap the two parameters here.
webView.observe(\WKWebView.title, changeHandler: { (_, title) in
    print("Title: ", title)
})

// Apple's method definition (with WKWebView context)
observe(
    keyPath: KeyPath<WKWebView, Value>,
    options: NSKeyValueObservingOptions,
    changeHandler: (WKWebView, NSKeyValueObservedChange<Value>) -> Void
)

// PromiseKit's definition
public enum PMKNamespacer {
    case promise
}

public func observe(_: PMKNamespacer, keyPath: String) -> Guarantee<Any?> {
    return Guarantee { KVOProxy(observee: self, keyPath: keyPath, resolve: $0) }
}

Wondering if there is a way to address this conflict, or if we are forced to use the PromiseKit version. This doesn't seem to be an "ambiguous context" issue since the definitions are very obviously different. Note: this is also in a file that doesn't import PromiseKit.

I imagine swift is lying and there’s another syntax error there actually. This is usually what it is.

@mxcl I think you are right. This was causing enormous issues yesterday, and I even tested within a Playground to ensure I wasn't using incorrect syntax. Sure enough though this morning I went back to it and the compiler started behaving and no longer flagging the line as an error.
I'll close this issue as resolved then. Thanks.

So what was/is the resolution to this?

OK.  Nevermind.  It taks a string.


Add anticaptcha support and change project structure

Ref #8

Codecov Report

Merging #9 into master will decrease coverage by 6.36%.
The diff coverage is 71.92%.

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
- Coverage   65.31%   58.95%   -6.37%
==========================================
  Files           2        5       +3
  Lines         173      229      +56
  Branches       26       28       +2
==========================================
+ Hits          113      135      +22
- Misses         54       87      +33
- Partials        6        7       +1

Impacted Files
Coverage Δ

freepacktbook/anticaptcha.py
45.71% <45.71%> (ø)

freepacktbook/utils.py
64.28% <64.28%> (ø)

freepacktbook/freepacktbook.py
80% <80%> (ø)

freepacktbook/__init__.py
23.52% <85.71%> (-43.77%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c7bcb3...385bd88. Read the comment docs.


Code art

[ ] PEP8 compliance
[X] make it usable in a virtualenv
[ ] modularize methods and functions more

Working on rewriting georeaders. Which formats are done:

[ ] Esri Shapefile
[ ] Esri FileGDB
[ ] MapInfo Tables
[ ] KML / KMZ
[ ] GML
[ ] GeoJSON
[ ] GXT
[ ] GeoPDF
[ ] DXF
[ ] DWG
[ ] SpatiaLite
[ ] Rasters


1.20.0 is not fully released everywhere

Expected Behavior
Consistent display of 1.20.0 in all locations.
Observed Behavior
https://detekt.dev/changelog.html 1.20.0 released 2 weeks ago
https://github.com/detekt/detekt/releases 1.20.0-rc2
https://search.maven.org/artifact/io.gitlab.arturbosch.detekt/detekt-cli 1.20.0-rc2 (update 15 Apr, sonatype propagation done 1.20.0)
https://plugins.gradle.org/plugin/io.gitlab.arturbosch.detekt 1.20.0
https://detekt.dev/compatibility.html 1.19.0
https://github.com/detekt/detekt#requirements 1.19.0
Context
I got the notification of the new version from renovatebot, so it might be too eagerly notifying before you finished the process.

Tip: do you have a play-by-play which nudges to update compatibility table, etc.?

I got the notification of the new version from renovatebot, so it might be too eagerly notifying before you finished the process.

This 👆
We're waiting for this #4719 to be merged to update everything.

I understand the announcement but this is confusing to see binaries on maven central and gradle plugins but not here.

I agree with @bric3, you should push to master and tag before publishing the binaries.
You don't need to promote the sonatype staging repository immediately. After closing it you can test by referencing the private staging repo, and then either publish or make changes as necessary.
So the best DX from a user's perspective is:

commit
build
upload to staging
close staging repo to validate
test via staging repo url
repeat from step 1 if there are problems
tag
push
promote staging
publish draft release on GitHub

I agree with @bric3, you should push to master and tag before publishing the binaries.

That's not possible at the moment. The project relies on the existence of detekt-gradle-plugin (and all the other artifacts) on Gradle Portal/Maven Central. Therefore if we commit/merge before publishing we will effectively break master. In other words, this PR https://github.com/detekt/detekt/pull/4719 won't be green till the artifacts are available online.
I agree that this is sub-optimal and we should look into migrating to a composite build, as it would solve this and other problems.

detekt.dev/changelog.html 1.20.0 released 2 weeks ago

This was a mistake on my end. The changelog generator uses the milestone name. We don't have milestones for RCs and here I forgot to rename it to -RC2. Reviewers also missed that.

detekt/detekt/releases 1.20.0-rc2

That's updated now

search.maven.org/artifact/io.gitlab.arturbosch.detekt/detekt-cli 1.20.0-rc2 (update 15 Apr, sonatype propagation done 1.20.0)

That's correct as 1.20.0 was published on the repos yesterday night CEST time.

plugins.gradle.org/plugin/io.gitlab.arturbosch.detekt 1.20.0

Same as above.

detekt.dev/compatibility.html 1.19.0
detekt/detekt#requirements 1.19.0

Those two are generally updated in a subsequent PR:

https://github.com/detekt/detekt/pull/4725

Also our review policy requires to have at least one approval before merging, therefore things move as fast as our reviewers speed (i.e. the compat table won't be updated till #4725 is merged, so you will still see outdated information).
Finally, I wrote a long discussion on our release process some weeks ago here:

https://github.com/detekt/detekt/discussions/4696

As I received no comments/feedbacks, would be awesome if you folks could comment over there how you would like the release process to look like and what is creating confusion/problems for you.
Closing as this got solved with the merge of #4719


Ensure Request::$data is always an array

This fixes the behaviour of JSON requests which were previously storing data in the request as an object (of type stdClass) rather than as an array which appeared to be the correct behaviour.

why wasn't this merged?

Because I must have missed it last year.

thanks!


API for users executing app-model commands

This has been mentioned in https://github.com/napari/napari/issues/7148#issuecomment-2264953312 and https://github.com/napari/napari/issues/6917 but I think this deserves it's own issue.
What should the API for users executing app-model commands be?
app-model actions can be triggered with execute_command which takes a command ID. I think there has been support to expose this but I was thinking that we could extend this function for users, where we could add things like:

fuzzy search / giving list of options if >1 matches found
maybe list all actions from a plugin/specific napari menu etc (though I appreciate the name execute_command would not be appropriate here)

Open for discussion, should we use a different API? What does that currently look like with action manager?
Related: I have suggested that we add a @register_action(menu, keybinding) decorator to be used with a function, allowing the user to easily create and register an action via a function definition. We can allow the user to specify command ID in the decorator, defaulting to the callback name. Note that app-model does not allow duplicate command IDs. (raised in #7056)

Just documenting a quick discussion with @DragaDoncila
Some considerations:

Do we want to expose all commands or keep some private? Potentially we could prepend '_' to command IDs of private commands, and the API would exclude these?
What do we do with commands that already have an API, e.g., File -> Open menu item can be achieved via viewer.open. Is it bad practice to have 2 ways of doing something?

Do we just expect them to (always?) import the command callbacks directly?

When executing commands in a script, the above API I suggest would not be useful and the user would need the full command ID string, which is difficult. I think if we do a good job of formatting the command ID, it shouldn't be harder than working out which function to call and importing it (e.g., id should start with source, 'napari' or plugin name, and final word should be the function name)


Added the description field to the Database class

Description
Added the description field to the Database class to support reading and writing database descriptions.
Fixes #255
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[x] I have checked my code and corrected any misspellings

@IsmaelLiriano12 what went wrong?


Long text in Search Within overlaps clear button

Description

Steps to reproduce

Go to http://spectrum-css-archives.s3-website.us-east-2.amazonaws.com/2.16.0/docs/searchwithin.html#standard
Type lots of text into the search field
Observe the text overlaps the clear button

Expected behavior

The text stops before it hits the butt, like it does here http://localhost:3001/docs/search.html
Screenshots

Environment

Spectrum CSS version: 2.16.0
Browser(s) and OS(s): Chrome on macOS

Looks fixed in the currently released version.


[media/CircleGraph] Introduce visqMetric

This will introduce visqMetric to store metric of quantization error.
ONE-vscode-DCO-1.0-Signed-off-by: SaeHie Park<EMAIL_ADDRESS>

from  #1387


task bar app stops responding in Windows 10

Keybase GUI Version: 1.0.16-20160713110836+a1c00b3
Windows 10 Pro
Intel i5 2400 cpu 16GB RAM
MSI GTX960
MSI motherboard
When I click the icon to restore the program I can see the task bar gui pop up but none of the selections respond. I click private or public and it changes the color from blue to green.  When I kill the program from the task manager and relaunch it will work for a period of time (which is how I got to the "report a bug" feature), but it seems to stop working again when I select "new private folder".

Thanks, we're aware of this, should have a fix out soon.  There might already be a fix available if you update?

I installed it yesterday, but will check for an update tomorrow and let you know.


Added Telemetry Ingest assets for wfs

Added  BitbucketToInsights & JiraToInsights assets to assist with webhook integrations

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.hsinghkalsi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@aso1124  Removed Heroku reference. we want to keep it generic, its node so really the only thing we need to make sure is to make sure user understand what the URL should look like


Frontend - Header Quick Menu

Context
Users of the Grant Finder Tool want a way to easily access their "My Profile" user account and manage their team(s) no matter what screen they are currently on within either tool.
Current State

In the Grant Finder Tool, a Quick Menu current exists in the top ribbon, with limited fields available (see below).

The ARPA Reporter does not currently have a Quick Menu for users to adjust their user account or team information.

Open Questions
None
Future State (design)

The Grant Finder will have an improved Quick Menu that can be easily accessed from the top ribbon of the tool.
Desired Info/Fields within the Quick Menu are as follows:

(Display, Not Editable) Name/Initials/Team name
(Display, Not Editable) My Profile
(Display, Not Editable) Give feedback
(Display, Not Editable) Sign out

Future State Mock Figma:

https://www.figma.com/file/gi975Am6lHBFbjCZeVBzb5/Settings?type=design&node-id=618-17726&mode=design&t=nF7VLubxCpnL5uWt-4

Within Figma see "Frame 84", AKA "Entry Point"

@kevin-kasunic file is updated here https://www.figma.com/file/gi975Am6lHBFbjCZeVBzb5/Settings?type=design&node-id=633%3A20155&mode=design&t=7Eg67RgOP8DovVC4-1.
Please let me know if there is anything missing or if dev has any additional needs within how I set up the file.

NOTE - dependent on #1588 being completed

From when this changed was designed, there was a new dropdown option added for "Training Guide" in https://github.com/usdigitalresponse/usdr-gost/pull/1950. Should that stay in the future state, and if so should it be added to the mocks since each option has a different icon? @ClaireValdivia since I'm not too sure who is working on the design currently.

Thanks for catching this, Ines! Yes, we want Training Guide to stay as a link. @caitlinwinner thoughts on an icon that can be used there for consistency?

Looking in the figma design library, it says these are bootstrap icons @inesfranch

tested and looks great in staging, matches design and decisions on new icons.


Updated content to address build issues

Addressed build issues.

Docs Build status updates of commit 69fc235:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/extensions-chromium/getting-started/part1-simple-extension.md
:bulb:Suggestion

Details

microsoft-edge/extensions-chromium/getting-started/part2-content-scripts.md
:bulb:Suggestion

Details

microsoft-edge/extensions-chromium/developer-guide/alternate-distribution-options.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/developer-guide/native-messaging.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/developer-guide/port-chrome-extension.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/enterprise/hosting-and-updating.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/enterprise/match-patterns.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/getting-started/index.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/publish/create-dev-account.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/publish/manage-settings.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/publish/publish-extension.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/publish/submission-states.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/publish/update.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/store-policies/ada-addendum.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/store-policies/csp.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/store-policies/developer-policies.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/getting-started/part1-simple-extension.md

Line 2, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'Extensions Getting Started Part 1' is duplicated in 'extensions-chromium/getting-started/part1-simple-extension.md(2,14)', 'extensions-chromium/getting-started/part2-content-scripts.md(2,14)'. NOTE: This Suggestion will become a Warning in late October, 2020.

microsoft-edge/extensions-chromium/getting-started/part2-content-scripts.md

Line 2, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'Extensions Getting Started Part 1' is duplicated in 'extensions-chromium/getting-started/part1-simple-extension.md(2,14)', 'extensions-chromium/getting-started/part2-content-scripts.md(2,14)'. NOTE: This Suggestion will become a Warning in late October, 2020.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 5875114:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/extensions-chromium/developer-guide/alternate-distribution-options.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/developer-guide/native-messaging.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/developer-guide/port-chrome-extension.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/enterprise/hosting-and-updating.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/enterprise/match-patterns.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/getting-started/index.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/getting-started/part1-simple-extension.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/getting-started/part2-content-scripts.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/publish/create-dev-account.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/publish/manage-settings.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/publish/publish-extension.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/publish/submission-states.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/publish/update.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/store-policies/ada-addendum.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/store-policies/csp.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/store-policies/developer-policies.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 97286c7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/extensions-chromium/developer-guide/alternate-distribution-options.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/developer-guide/native-messaging.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/developer-guide/port-chrome-extension.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/enterprise/hosting-and-updating.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/enterprise/match-patterns.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/getting-started/index.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/getting-started/part1-simple-extension.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/getting-started/part2-content-scripts.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/publish/create-dev-account.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/publish/manage-settings.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/publish/publish-extension.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/publish/submission-states.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/publish/update.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/store-policies/ada-addendum.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/store-policies/csp.md
:white_check_mark:Succeeded

microsoft-edge/extensions-chromium/store-policies/developer-policies.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

#signed-off and merged.


Transform dialect bringup

Bringup a generalized form of the transform dialect:

Transform Dialect Bringup Branch
Improve tests/transform_dialect/cuda/reduction.mlir by making input a… (#11208)
[NFC] Refactor transform dialect matcher. (#11211)
Add back mistakenly removed execution test in matmul CPU (#11209)
[DONOTMERGETOMAIN] Drop a bunch of CI stuff we do not care about for … (#11215)
Move transform dialect builder file to Common (#11216)
Move the CPU to not use attributes. (#11219)
NFC - Apply minor API cleanups (#11238)
Add basic structured op matcher with fluent API (#11237)
Add another cuda reduction test with other sizes and always tiling th… (#11243)
Matcher API for inputs and inits/outputs (#11240)
Support reduction+elementwise in transform dialect strategies (#11288)
Refactor the matching code and move all the parameters into structs (#11222)
[DONOTMERGETOMAIN] Add a flag to disable tensor fusion in flow (#11314)
Add strategy+test for reduction(elementwise) (#11315)
Add matcher callback operations to the transform dialect (#11389)
Fixes related to IREEEraseHALDescriptorTypeFromMemRefOp
Revert "[DONOTMERGETOMAIN] Add a flag to disable tensor fusion in flow (#11314)"
Revert "[DONOTMERGETOMAIN] Drop a bunch of CI stuff we do not care about for … (#11215)"
Revert "Transform Dialect Bringup Branch"
Drop tests using --iree-disable-fusion-of-tensor-ops
Use C++ callbacks to match reductions inside the transform dialect (#11390)

Co-authored-by: Oleksandr "Alex" Zinenko<EMAIL_ADDRESS>Co-authored-by: Nicolas Vasilache<EMAIL_ADDRESS>Co-authored-by: Thomas Raoux<EMAIL_ADDRESS>Co-authored-by: Matthias Springer<EMAIL_ADDRESS>

I did say please wait for @dcaballe and @hanhanW to finish their reviews... its generally expected that everyone who has commented on the PR/ has opinions on the PR should have reviewed the changes.... especially for PRs like this

Did the DONOTMERGETOMAIN commits get merged?

There were no changes to Flow AFAICS.

+1 to waiting for reviewers for big branch merges like this - a warning that we're more likely to push back against this development style in the future (lightly reviewed or unreviewed branches that get merged to main without all reviewers fully getting a chance to participate).

I was planning to review it for a couple rounds because it is a very big PR. I can still leave some comments here and we can fix it afterwards...

I'd prefer a revert - it's clean right now and will only get harder after integrates/etc.

If this wasnt a big PR, and just results in a lot of churn, I would have voted for revert too... but at the very least, please address any other comments by @dcaballe and @hanhanW before any further PRs on merging the transform dialect. I think in future, landing PRs without reviewers looking at it fully are grounds for revert.

~Did the DONOTMERGETOMAIN commits get merged?~ nevermind looks like they were reverted?

Yes of course

I did say please wait for @dcaballe and @hanhanW to finish their reviews... its generally expected that everyone who has commented on the PR/ has opinions on the PR should have reviewed the changes.... especially for PRs like this

Then I'd suggest to either not click accept or disable the auto-merge button: github is oblivious to words.

I did say please wait for @dcaballe and @hanhanW to finish their reviews... its generally expected that everyone who has commented on the PR/ has opinions on the PR should have reviewed the changes.... especially for PRs like this

Then I'd suggest to either not click accept or disable the auto-merge button: github is oblivious to words.

Hmm, I didnt see the auto merge enabled. Something to keep in mind for future. Down side of auto merge feature. Maybe not good idea to have it on large PRs

I took a deeper look, and think there are two things we can improve:

I believe I addressed that API-related comments in #11458.
Moving code around and into llvm-external-project can be done as a separate followup.

I took a deeper look, and think there are two things we can improve:

I believe I addressed that API-related comments in #11458. Moving code around and into llvm-external-project can be done as a separate followup.

Thanks for the detailed and explanation, and addressing the comments! The patch looks good to me!
Yeah, I agree that moving code around can be done as a separate follow-up, since it's a big PR (which already contains a lot of commits). Do we plan to do it after merging more things to main branch?


Ad failed to load on iOS, error 11, Request Error: Internal error

Its working on Android but failed to work on iOS repeatedly even with test ad unit. it gives the error message:
error code: 11, Request Error: Internal error

Error on AdMob side.
I recommend checking with the actual machine.
https://developers.google.com/admob/ios/api/reference/Enums/GADErrorCode#/c:@E@GADErrorCode@kGADErrorInternalError

I just noticed that the didReceive ad is also called with the loaded ad
after the ad failure call. But however the ad isn't showing. What could be
the problem?
On Tue, 26 Nov 2019, 2:28 pm sakebook<EMAIL_ADDRESS>wrote:

Error on AdMob side.
I recommend checking with the actual machine.
https://developers.google.com/admob/ios/api/reference/Enums/GADErrorCode#/c:@E@GADErrorCode@kGADErrorInternalError
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sakebook/flutter_native_ads/issues/37?email_source=notifications&email_token=AK57Y2NGHDLK5EA4NRT2LITQVUQA7A5CNFSM4JRKY64KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFF7ZEQ#issuecomment-558627986,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AK57Y2PU6CQWQ2TA5DHN5ELQVUQA7ANCNFSM4JRKY64A
.

The example project is also not working. Could you test it and ensure it's
not broken?
On Tue, 26 Nov 2019, 2:30 pm Calistus Ibeme<EMAIL_ADDRESS>wrote:

I just noticed that the didReceive ad is also called with the loaded ad
after the ad failure call. But however the ad isn't showing. What could be
the problem?
On Tue, 26 Nov 2019, 2:28 pm sakebook<EMAIL_ADDRESS>wrote:

Error on AdMob side.
I recommend checking with the actual machine.
https://developers.google.com/admob/ios/api/reference/Enums/GADErrorCode#/c:@E@GADErrorCode@kGADErrorInternalError
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sakebook/flutter_native_ads/issues/37?email_source=notifications&email_token=AK57Y2NGHDLK5EA4NRT2LITQVUQA7A5CNFSM4JRKY64KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFF7ZEQ#issuecomment-558627986,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AK57Y2PU6CQWQ2TA5DHN5ELQVUQA7ANCNFSM4JRKY64A
.

I found bug. Will fix.

Please use v0.4.0


Desktop version

I modified the whole project using media queries for the desktop version of the portfolio figma template 5 as required by the Microverse assignment. I added additional images in SVG format and worked on transitions and animations through the different sections to make the project more visually engaging. Although the works/projects section was extremely challenging and I'm quite satisfied with the result, I will improve it. 😅 Let me know what you think!

@zieeco thank you for your comments and your suggestion! I wonder what could be wrong because I even tried it with the netlify app on my phone and my boyfriend's phone which is a bit bigger and it seems good.
https://mcportfoliolivedemo.netlify.app/
I checked maybe it could be the overflow: hidden property I used in the body? I just disabled it and tried it again. Hope it's solved! 👍

Thank you @amon-cofie for telling me this! It seems to be that when I was resolving some conflicts in my branches, some of the final code was overwritten by error, but it seems to be fixed now. I've attached a video as well. Thank you! I sincerely hope you see this as well on your screens because this is my last review request! I'm so nervous.
https://user-images.githubusercontent.com/120128067/221329982-19e9326d-d911-4923-bd79-982bc196d3f9.mp4

@NduatiKagiri Thank you!!! I'm so happy! Template 5 was very hard but I learned so much!


Added documentation and samples for all chart types. Added tests.

Q
A

Bug fix?
[ ]

New feature?
[ ]

New sample?
[x ]

Related issues?

What's in this Pull Request?

Added documentation for every chart type supported by the ChartControl.
Added tests.
Added support for palette generation for multiple datasets or single datasets.
Removed non-localized warning messages

(Sorry to be creating so many pull requests!)

Codecov Report

Merging #202 into dev will increase coverage by 4.99%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##              dev     #202      +/-   ##
==========================================
+ Coverage   72.24%   77.23%   +4.99%
==========================================
  Files          15       16       +1
  Lines         645      659      +14
  Branches      123      117       -6
==========================================
+ Hits          466      509      +43
+ Misses        139      113      -26
+ Partials       40       37       -3

Impacted Files
Coverage Δ

src/controls/chartControl/ChartControl.types.ts
100% <ø> (ø)
:arrow_up:

src/controls/chartControl/index.ts
100% <100%> (ø)

src/controls/chartControl/ChartControl.tsx
69.4% <100%> (+1.51%)
:arrow_up:

src/controls/chartControl/AccessibleChartTable.tsx
85.71% <100%> (+9.71%)
:arrow_up:

src/controls/chartControl/PaletteGenerator.ts
58.53% <44%> (+32.22%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eb0ea7...d31d5d1. Read the comment docs.

Closing -- will re-submit new version with built-in capability to handle data promises.


ipns / promise support

Issue Type

[x] Feature (https://github.com/silentcicero/ipfs-mini/blob/master/.github/CONTRIBUTING.md#feature-requests)

Description
Sorry, these are actually two feature requests.

How do you feel about promise support? Think: when a callback is passed, the callback will be used, otherwise we return a promise.

Do you think it would be possible to add ipns (publish / resolve) support as well?

I'd happily provide PRs for both of them.

Would love Promise support, was going to add but never got around to it.
IPNS sounds awesome.
Sounds like you have work to do ;) @chmanie

Hey, thanks for the quick answer. Will start right away.
One question: how about browser support? Meaning, shall I assume native Promise support or do we want to include a polyfill?

Assume native thank you
Sent from my iPhone

On Aug 2, 2017, at 4:51 PM, Christian Maniewski<EMAIL_ADDRESS>wrote:
Hey, thanks for the quick answer. Will start right away.
One question: how about browser support? Meaning, shall I assume native Promise support or do we want to include a polyfill?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.


Tag truncated logs

What does this PR do?
Adds an optional config option to add truncated tags to file logs.
This will make searching for truncated logs much easier since tags get indexed atomically.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

in datadog.yaml

logs_enabled: true
logs_config:
    tag_truncated_logs: true
    max_message_size_bytes: 10

Create a logs integration config with a bad multi_line rule:

    log_processing_rules:
      - type: multi_line
        name: nevermatch
        pattern: nevermatch

Send logs to the agent that never match the pattern.

Search the logs explorer for tags:truncated

/merge


subsys: mqtt: Return meaningful error code from mqtt_init() function

The condition checks whether the connection was established or not. The
return value should reflect that.
Signed-off-by: Caspar Friedrich<EMAIL_ADDRESS>

Minor nit pick, please change the commit subject to this: net: mqtt: Return meaningful error code from mqtt_init()
we do not put subsys string to commit subject string, also the function is pointless as the mqtt_init() is clearly a function so no need to mention this. This way the subject can be made a little shorter.

Thanks, done.


How to download a list of tickers of an exchange?

Could you please provide an example on how I should write the name of the index?
Is it possible to download a list of all the tickers filtered by index right?
YahooTickerDownloader.py index='BIT' would work?
(I am not sure where to find the code of the index used by Yahoo)
Thanks

YahooTickerDownloader.py {desired ticker type} -E {exchange name}
Some examples:
YahooTickerDownloader.py stocks -E NMS
YahooTickerDownloader.py stocks -E NYQ
YahooTickerDownloader.py stocks -E FRA
I got these by going to https://de.finance.yahoo.com/lookup/S?s=a&b=0&m=ALL&t=S&bypass=true

Does this answers your question?

Yes, thanks!
(Trying with another query I found that Italy exchange code is 'MIL' )

Actually it didn't work as expected.
It didn't filter on the exchange as you can see here:
req https://de.finance.yahoo.com/lookup/S?bypass=true&s=a&b=120&m=ALL&t=S
Retry attempt: 1. Sleep period: 5 seconds.
req https://de.finance.yahoo.com/lookup/S?bypass=true&s=a&b=120&m=ALL&t=S
Got 20 downloaded Stock symbols:
 Stock NNS.DE GER Nanostart AG
 Stock NGLB.DE GER Anglo American PLC
  ect...
Progress: Query 0/26. Items handled in current query: 140/Unknown. Total collected unique Stock entries: 140

req https://de.finance.yahoo.com/lookup/S?bypass=true&s=a&b=140&m=ALL&t=S
Got 20 downloaded Stock symbols:
 Stock AFRB.L LSE AFI Development PLC
 Stock ADSK NMS Autodesk, Inc.
  ect...
Progress: Query 0/26. Items handled in current query: 160/Unknown. Total collected unique Stock entries: 160

req https://de.finance.yahoo.com/lookup/S?bypass=true&s=a&b=160&m=ALL&t=S
Retry attempt: 1. Sleep period: 5 seconds.
req https://de.finance.yahoo.com/lookup/S?bypass=true&s=a&b=160&m=ALL&t=S
Retry attempt: 2. Sleep period: 25 seconds.
req https://de.finance.yahoo.com/lookup/S?bypass=true&s=a&b=160&m=ALL&t=S
Got 20 downloaded Stock symbols:
 Stock UHRN.SW EBS The Swatch Group AG
 Stock UHAL NMS AMERCO
  ect...
Progress: Query 0/26. Items handled in current query: 180/Unknown. Total collected unique Stock entries: 180

req https://de.finance.yahoo.com/lookup/S?bypass=true&s=a&b=200&m=ALL&t=S
Got 20 downloaded Stock symbols:
 Stock AVL.TO TOR Avalon Advanced Materials Inc.
 Stock ATM.NZ NZE The a2 Milk Company Limited
  ect...
Progress: Query 0/26. Items handled in current query: 220/Unknown. Total collected unique Stock entries: 220

^CSuspending downloader to disk

The filtering is done after all the symbols have been downloaded.
I will change this to a bug to alter the description to make this behavior clear.

I tried the following but get a blank csv and excel file
python3 YahooTickerDownloader.py stocks -E FRA -e
how do I export the ticker list
Thanks

@abhandari73 The -e switch will immediately export the current .pickle file without downloading. I just tested it and it worked as expected. Run without the -e switch first to gather the symbols from Yahoo.

The changes for making the help text more descriptive are applied just now in e6e2c6311c641aebd870c929ec440c408c429207

Thank you Benny.
Since it is downloading symbols for all exchanges and then applying the filter.
I guess then it is better to download the symbols and then sort it in excel and get the relevant symbols?
Kind Regards,
Arjun Bhandari
+97150 780 5672

On Feb 4, 2017, at 10:02 PM, Benny Jacobs<EMAIL_ADDRESS>wrote:
Closed #20 https://github.com/Benny-/Yahoo-ticker-symbol-downloader/issues/20.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/Benny-/Yahoo-ticker-symbol-downloader/issues/20#event-949186440, or mute the thread https://github.com/notifications/unsubscribe-auth/AOkgEBfVyeO9cHquXp5ey2kMcGCmybp0ks5rZL0jgaJpZM4L1K4e.

I don't know if it is "better" but it should give the same result in the end.


add Constant, Zeros and Ones

similair to the python versions
W = tf.Variable(tf.zeros([784, 10]))
b = tf.Variable(tf.zeros([10]))

Thanks for the contribution!   I was on vacation, but will review this week as I get back.

Hi @larcai,
Have you got some time to review Miguel's remarks above? Your PR is quite useful, but I think those explicit references to Anaconda are blocking its acceptance. I would also be interested in using Zeros and Ones methods in forthcoming TFS versions 😅
Regards,
Cesar

I cleaned up the patch by hand and applied it.


Bug? in tabulator headers parameter

We're confused by a behavior of tabulator when parsing multiple rows as header rows.
https://github.com/frictionlessdata/tabulator-py/blob/master/tabulator/stream.py#L607
The line above is an if statement that only adds the value of the row to the header if the value inside that row is not equal to the end of the header that has up to then been generated.
We have an excel sheet with 4 rows to be used as headers.

The expected header value would be 135 C 182 2 but because 182 ends in 2, the 2 is truncated and the resulting header is 135 C 182.
Can we either change this behavior or add a flag to tabulator that will overwrite this behavior?
Thanks!
A basic csv to test this would be:
1
1
abc
def
ghi

Load as csv, set the header rows to 1 and 2, expected header 1 1 but end up seeing just 1.

@cschloer
I don't know what this line does TBH (it was a quick feature we added). It looks like some heuristic but a comment on what exactly would not hurt
I think we need to fix it

I added the original data file to usecases here: https://github.com/BCODMO/frictionless-usecases/tree/master/usecases/786028_abund/orig
But basically this is a good example of what we are doing when data needs to be unpivoted.  We have to first load multiple header rows in the load step to have one set of field names.
In this case we need to load data from header rows 1-4 in the original file.  All the columns loaded correctly except this one cell that is missing the 2. It should have loaded as 135 C 182 2 not 135 C 182

screenshot shows original Excel data below and above shows the field names loaded with setting header rows 1-4.

We then parse that (e.g. 135 C 182 2 ) apart into actual data columns in unpivot in a later step.  Which has some other issues related to having space as the delimiter, but I am putting together a clear example of how we are using unpivot to explain why that is an issue for us.  That is a pending issue.


Claimed trip not deleted after being moved to Sent Trips

One trip (of two claimed trips) remained in "trips" for Agency A even after being claimed, and correctly copied over to sent trips. It was the last trip of 3, in which two were claimed and one was declined.

Issue shows that there is definitely concurrency happening within sheets operations. Solution was to reverse array, but we will have to be careful in the future figuring out what runs synchronously.


chore(curriculum): Updating the assets to be served by the CDN - Music Player Project

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #54710

@RafaelDavisH, you know better about the images for each video.
At a point, they were different, but I don't remember which point. Could you please provide more insights about this?


Wide image doesn't take all available horizontal space in previewer when using a different aspect ratio

What system are you running Yazi on?
Linux X11
What terminal are you running Yazi in?
kitty 0.35.2
yazi --debug output
Yazi
    Version: 0.3.1 (Arch Linux 2024-08-17)
    Debug  : false
    OS     : linux-x86_64 (unix)

Ya
    Version: 0.3.1 (Arch Linux 2024-08-17)

Emulator
    Emulator.via_env: ("xterm-kitty", "")
    Emulator.via_csi: Ok(Kitty)
    Emulator.detect : Kitty

Adapter
    Adapter.matches: Kitty

Desktop
    XDG_SESSION_TYPE: Some("x11")
    WAYLAND_DISPLAY : None
    DISPLAY         : Some(":0")

SSH
    shared.in_ssh_connection: false

WSL
    /proc/sys/fs/binfmt_misc/WSLInterop: false

Variables
    SHELL              : Some("/usr/bin/bash")
    EDITOR             : Some("nvim")
    VISUAL             : Some("nvim")
    YAZI_FILE_ONE      : None
    YAZI_CONFIG_HOME   : None

Text Opener
    default: Some(Opener { run: "${EDITOR:-vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })
    block  : Some(Opener { run: "${EDITOR:-vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })

Multiplexers
    TMUX               : false
    tmux version       : No such file or directory (os error 2)
    ZELLIJ_SESSION_NAME: None
    Zellij version     : No such file or directory (os error 2)

Dependencies
    file             : 5.45
    ueberzugpp       : No such file or directory (os error 2)
    ffmpegthumbnailer: 2.2.2
    magick           : No such file or directory (os error 2)
    fzf              : 0.54.3
    fd               : 10.1.0
    rg               : 14.1.0
    chafa            : No such file or directory (os error 2)
    zoxide           : No such file or directory (os error 2)
    7z               : 17.05
    7zz              : No such file or directory (os error 2)
    jq               : No such file or directory (os error 2)

Did you try the latest nightly build to see if the problem got fixed?
Yes, and I updated the debug information above (yazi --debug) to the nightly that I tried
Describe the bug
When previewing images with a greater width than its height, the image might not take all the available horizontal space. This only happens when using a different ratio in yazi.toml, but not when using the default value.
With default config:

With custom ratio (notice the empty space to the right of the image):

Minimal reproducer
In ~/.config/yazi/yazi.toml
# This is the configuration that I'm using, but any ratio
# will work as long as the third panel has the greater width
[manager]
ratio = [1, 3, 4]

Download this image and preview it in yazi:

Anything else?
No response

Does https://yazi-rs.github.io/docs/image-preview#size help?

Yes, it worked, I've should of read the docs with more care!


Add support for Uniform Distribution

Go through the Gaussian distribution class, the Binomial class and the Exponential class which are subclasses of General distribution class.
The uniform distribution is the simplest probability distribution.
I would like to expand this to include the Uniform Probability Distribution.
It should be able to calculate mean, standard deviation, and create basic plots like those in the classes I linked.

Hi @hot9cups I would like to work on this!

@fibonacci-spirals Hope you're doing well. How are you progressing with the issue? :)

@hot9cups Raised a PR here Please let me know if there are any changes required.


feat: api to fetch fnames

What is the feature you would like to implement?
Make it easy to get the current fnames associated with an fid from Hubble
Why is this feature important?
Developer experience is significantly better if you don't have to also connect to Ethereum, and Hubble already has this information about fnames
Will the protocol spec need to be updated??
No
**How should this feature be built? **
Since an account may have multiple fnames, the current fname is determined by the following pseudocode:

If UserData.fname && fname in user's address, select fname
If !UserData.fname, select earliest fname that transferred into users account.
Otherwise return none

A few API's can be provided to make this easy for developers:

A fetch api that accepts N fids and returns N fnames
A subscription api that accepts a blockheight and returns all fname changes since that block

API already exists to fetch an fname given an fid, but we should consider doing the batch api at some point. Moving to v2.1 for now.

@sanjayprabhu is this relevant given the new api's you're introducing?

this is less relevant given the recent move to username proof apis


Add prompt to install required extensions for resource deployment

Adds support for Resource Deployment URIs to specify an extension that must be installed to start the deployment, prompting the user to install it if it isn't installed.
There's still a slight gap here in that RD doesn't pick up the new resource types until the window is reloaded. I'll follow up with a separate PR to fix that.

Pull Request Test Coverage Report for Build 687480695

7 of 20 (35.0%)  changed or added relevant lines in 2 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.005%) to 43.268%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

extensions/resource-deployment/src/services/uriHandlerService.ts
3
16
18.75%

Files with Coverage Reduction
New Missed Lines
%

extensions/import/src/wizard/pages/fileConfigPage.ts
3
72.99%

Totals

Change from base Build 687256397:
-0.005%

Covered Lines:
25473

Relevant Lines:
53717

💛  - Coveralls

ideally this should be exposed through API, but given how less likely this will be used by others, this seems fine to me.

Getting the extension info from the gallery? Yeah - I considered that. But I didn't really feel like it brought much value given the very specific use case. Something to keep in mind for sure if something else needs it.


fix ARM64 docker image build

For building VPP was used gcc-7 which ended by failure on ARM64 platform
gcc-8 and g++-8 are installed and used instead to ensure successfull build
Signed-off-by: Stanislav Chlebec<EMAIL_ADDRESS>

Coverage decreased (-0.02%) to 71.811% when pulling d908a1a201a3f86af05c2d27ea3cd305c996cc13 on stanislav-chlebec:arm64_gcc8 into c5ee50dc43f892a78564f4232f9e8b5abba68bf2 on contiv:master.


Capacitor 3 not registering pluging automatically

Describe the bug
I have upgraded from capacitor 2 to capacitor 3 . The issue I am facing on both plugins push notifications and background geolocation . Getting same error that is “Plugin not implemented for android”
According to the docs it should automatically register in MainActivity.java file but that is not happening I have to remove init method from that file
package siloc.xyz;

import android.os.Bundle;

import com.getcapacitor.BridgeActivity;
import com.getcapacitor.Plugin;

import java.util.ArrayList;
import com.hemangkumar.capacitorgooglemaps.CapacitorGoogleMaps;
import com.getcapacitor.community.bglocation.BackgroundGeolocation;
public class MainActivity extends BridgeActivity {

    @Override
    public void onCreate(Bundle savedInstanceState) {
      super.onCreate(savedInstanceState);
}

}

To Reproduce
I upgraded from capacitor 2 to capacitor 3
Expected behavior
It suppose to register these plugins
Screenshots
If applicable, add screenshots to help explain your problem.
Smartphone (please complete the following information):
vivo v2029

I would try this:

Delete your node_modules directory
Recreate your node_modules directory
Run npx cap sync
Run Build -> "Clean Project" in Android Studio
Run File -> "Sync Project with Gradle settings" in Android Studio


feat!: switched to esm, code cleanup

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@293df66). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             master        #9   +/-   ##
==========================================
  Coverage          ?   100.00%
==========================================
  Files             ?         6
  Lines             ?       200
  Branches          ?         0
==========================================
  Hits              ?       200
  Misses            ?         0
  Partials          ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 293df66...5443ebf. Read the comment docs.


Change Font Size for Mushroom Title Card (I know this has been asked many times)

Requirements

[X] I have updated Mushroom to the latest available version
[X] I did a search to see if there is a similar issue or if a pull request is open.

Current Behavior
I've search Google for days. I can't seem to find a SIMPLE approach to using card_mod to change the Font Size (and ultimately the line-height) of the Mushroom Title Card.
My current incarnation is as follows:
type: layout-card
layout_type: custom:masonry-layout
layout: {}
cards:
  - type: custom:mushroom-title-card
    title: Lighting
    subtitle: Bedroom
    card_mod:
      style: |
        ha-card {
          --card-primary-font-size: 40px;
        }
      action: none
    subtitle_tap_action:
      action: none

But I've literally tried every suggestion on the web that I can find. I've tried the --title-font-size, --mush-title-font-size.
I've tried to  use mushroom-title-card instead of ha-card. I've tried adding h1 and .title, but nothing is working. I am sure that the answer is pretty straightforward, but I'm new to CSS, and despite looking at the CSS literally for hours, I can't make it work.
So, I hope that someone can walk me through this. I know this question has been asked before, and most of the answers point me back to Thomas Loven's great work on the layout card and card_mod, but there isn't enough of a NOOB how-to or tutorial to get me on the right track.
Thanks in advance.
Expected Behavior
No response
Steps To Reproduce
No response
Context
YAML state

Environment
- Browser:
- HA Version:
- Mushroom:

Anything else?
No response

Which documentation? There is no mention of card_mod support for all the cards in the documentation.

Which documentation? There is no mention of card_mod support for all the cards in the documentation.

Fair enough! I wasn't suggesting that there was any. So, is there actually a way to change the font-size and also the spacing between the Title and the Subtitle please? Thanks in advance.

Thank you for the education. I NEVER would have found it in a million years!!
So for others looking for this, you need to go into
config/themes/[theme].yaml
and you add mush-title-font-size.
The various variables that can be defined can be found https://github.com/piitaya/lovelace-mushroom-themes#build-your-own


fix: set a cwd for biome

According to the docs:

The Biome configuration file is named biome.json and should be placed in the root directory of your project. The root directory is usually the directory containing your project’s package.json.

https://biomejs.dev/guides/how-biome-works/#configuration

Thanks for the PR!


PKCE with optional Client Secret

Preflight Checklist

[X] I could not find a solution in the existing issues, docs, nor discussions
[X] I have joined the ZITADEL chat

Describe your problem
Opening this is a continuation of #6886, which was closed prematurely. I would still like this feature:

Include an option to create a client secret to be used in conjunction with PKCE

Describe your ideal solution
From #6886:

In the UI one can have a checkbox, in Terraform and additional field, in api an additional parameter or boolean to define whether a client secret will be created or not when using PKCE

Version
No response
Environment
Self-hosted
Additional Context
No response

I also agree this would be useful to have. I have encountered several applications that used PKCE but also required a client secret, some of which I currently have not used because I could not get them to work with Zitadel because of that missing client secret when using PKCE.

Thank you for sharing your idea.
If there is a significant demand from customers/community, we will carefully consider implementing the feature.
Currently, the issue will be added to our product backlog.
Meanwhile, if you're interested in implementing it yourself, we also welcome pull requests.

Also waiting for this.
Here it says that PKCE is not a replacement for client authentication.
https://oauth.net/2/pkce/


MM-31697- Remove OpenId from System Console

Summary
Hides OpenID section in System Console as we don't want to release it until mobile is complete.
Ticket Link
https://mattermost.atlassian.net/browse/MM-31697
Screenshots

Does anyone see a reason to remove the code? We are expecting to add it back as soon as mobile gets merged.

This also needs to be cherry-picked to cloud.

This also needs to be cherry-picked to cloud.

@furqanmlk @mkraft Kind reminder to prioritize review (this will be included for January 12th cloud release).

@furqanmlk @mkraft Kind reminder to prioritize review (this will be included for January 12th cloud release).

/cherry-pick cloud

/cherry-pick cloud

Cherry pick is scheduled.

Cherry pick is scheduled.


Polygon.from_bounds() accepts a tuple rather than 4 positional arguments

Ready for review @snorfalorpagus or @sgillies.
We pass spatial bounds around as a (xmin, ymin, xmax, ymax) almost everywhere across Fiona, Rasterio, and Shapely, so this class method should not be an exception.  See https://github.com/Toblerity/Shapely/pull/392#issuecomment-237355773 for background.

Coverage decreased (-5.5%) to 71.993% when pulling 9dac2b1d89de5b5b0a3c089fa644dda38b74ee67 on poly-from-bounds-2 into 1d2dc8599a3851566e1f5397577c2e257adf4f5d on master.

@geowurster in Rasterio we have individual positional arguments https://github.com/mapbox/rasterio/blob/master/rasterio/windows.py#L163. I think it's so easy to unpack a tuple using *bounds that these forms are pretty much equivalent.


ALB secure session cookie

Hi;
I am using tomcat 9.0.16 in my StatefulSets. I have configured secure cookie w.r.t. https://geekflare.com/secure-cookie-flag-in-tomcat/. However, it doesn't take effect. I wonder if this is due to the ALB and if yes, how could I configure secure cookie? Thanks.
ALB annotation of cookie used:
alb.ingress.kubernetes.io/target-group-attributes: stickiness.enabled=true,stickiness.lb_cookie.duration_seconds=600

$ curl -i https://mydomain.com/ui
HTTP/2 302
date: Tue, 05 Mar 2019 02:53:18 GMT
set-cookie: AWSALB=1XBgICNPmhP57p6LFFewu6+wt2MiKySbrAKoGEPGtUl0+NJWRhr+A6dY5ncdfRp6JCfUTQjt0AaM7SzcWKbOfxLSTH2s5jAFIC7/4hkoGnZhmz3NYEvIsaQeUiwn; Expires=Tue, 12 Mar 2019 02:53:18 GMT; Path=/
location: /ui/

I am running penetration tests using https://github.com/zaproxy/zaproxy and always gets "insecure cookie" low-risks alerts.

Found these:
(1) https://serverfault.com/questions/570470/load-balancer-on-amazon-does-not-have-secure-flag-set-for-cookie
(2) https://docs.aws.amazon.com/elasticloadbalancing/latest/classic/elb-sticky-sessions.html
How to enable / use cookie from the App server? Thanks.


Problem with storing actor method reference in object

Acton Version
0.17.0
Steps to Reproduce
Not sure how to describe this. I'm trying to store references to actor methods in an object and I'm getting errors.
actor TestFoo(env):
    def test():
        print("Testing Foo")

def _test_foo(env):
    f = TestFoo(env)
    return f.test

class EnvTest():
    def __init__(self, name, met):
        self.name = name
        self.met = met

actor main(env):
    EnvTest("", _test_foo)
    env.exit(0)

Building file examples/foo.act
  Compiling foo.act for release
actonc: ### contArg $Cont[$action[(), None]]
CallStack (from HasCallStack):
  error, called at ./Acton/LambdaLifter.hs:312:43 in main:Acton.LambdaLifter

Expected Behavior
No compilation errors!
Actual Behavior
Building file examples/foo.act
  Compiling foo.act for release
actonc: ### contArg $Cont[$action[(), None]]
CallStack (from HasCallStack):
  error, called at ./Acton/LambdaLifter.hs:312:43 in main:Acton.LambdaLifter

Fixed by #1553. Closing.


Replace GitVersionTask and GitVersion.MsBuild with Docker images

Having GitVersion run as part of our MsBuild process has been causing me problems lately. For example, when I check out the fieldworks8-master branch (where GitVersionTask is still used since https://github.com/sillsdev/LfMerge/commit/fca2ca30f6270470bff262cafd2de35c69e23902 was only added to the master branch and not fieldworks8-master), I often find that Omnisharp crashes with errors like "The type initializer for 'LibGit2Sharp.Core.NativeMethods' threw an exception. Unable to load DLL 'git2-15e1193': The specified module could not be found." And then I don't have Intellisense in VS Code, can't ctrl-click on a method call to go to its definition, and so on, because the underlying language server crashed while trying to load LfMerge.Core.csproj.
The underlying issue (binary-incompatible versions of libssl between what libgit2 wants (libssl 1.0) and what most distros offer (libssl 1.1)) might be resolved by libgit2 1.2.0 which released last week (it includes a feature to load OpenSSL libraries dynamically). But that fix will only show up in GitVersion once LibGit2Sharp updates to use libgit2 1.2.0 and then GitVersion updates to use the new LibGit2Sharp. Since LibGit2Sharp's most recent release (as of when I'm writing this) was in December 2019, I'm not really expecting LibGit2Sharp to produce a new release soon, and therefore GitVersion will continue making it hard for me to use Omnisharp as long as it's in our .csproj files.
Which means that I want to take GitVersion out of the MsBuild process and isolate it somewhat, so that Omnisharp won't crash every time it tries to load a .csproj file. One way to do it would be to use dotnet gitversion, which we've already done to some extent. But another way would be to use one of the official GitVersion Docker images, which would allow GitVersion to run in an isolated environment where all of its dependencies (libgit2, etc.) are at the right version to work together.
At some point when I have time, I plan to work on the LfMerge build process to replace dotnet gitversion (which still needs GitVersion to use the system-provided versions of C libraries like libgit2, libssl, etc.) with docker run gittools/gitversion instead. That will allow me to work on the fieldworks8-master branch and still have C# language features like Intellisense in VS Code.

One security consideration, the usual one with Docker images: since we'd be pulling down a Docker image built by someone else, and running it inside our repo, it's theoretically possible that someone could insert malware into one of the GitVersion Docker images that would modify the code in our repo, thereby inserting malware into LfMerge Debian images as we build them. This can be mitigated, and probably entirely overcome, by mounting the /repo volume read-only. The GitVersion Docker instructions recommend mounting the repo with -v "${pwd}:/repo", but if instead we use -v "${pwd}:/repo:ro" then the GitVersion tool will only have read access to our repo, and won't be able to do anything nefarious with it.

Now that we've replaced GitVersion with a GitHub Actions workflow step that calculates the version using git describe, this issue is basically done, as there will be no more crashes due to GitVersion issues.


Adding epochs as a parameter to the constructor for MatrixFactorization class

This will make the epochs tunable.

Thanks for the PR! Just one little style comment.

You also forgot a comma, so the builds are failing.

Pull Request Test Coverage Report for Build 187

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 72.203%

Totals

Change from base Build 185:
0.03%

Covered Lines:
613

Relevant Lines:
849

💛  - Coveralls

Thanks again!


story3/populate-account-index

Purpose of this branch is to add the missing menu items from the AccountController into the IndexController

@erchiggins : This branch is ready for review.


blacklist is ignored when component is 'extend'ed

system({
  blacklist:['whatever']
});

vs
system({
  extend: Something,
  blacklist:['whatever']
});

I've noticed the same thing - reproduced it here: https://codesandbox.io/s/j43vv5w2k9
<div class="sc-bdVaJa jZblEN" p="5">
    <button class="sc-jtRfpW kBOnIP">Boop</button>
    <button class="sc-jtRfpW cTvhTf" uppercase="true">Boop</button>
</div>

@alexlouden @purge I noticed it too! and  also that you cannot merge the blacklist of the original component with the one extending it. Anyone interested in opening a PR for this? I can start but i'd need someone else for sanity :)


Is this possible to search in files that are open in the current windows but not inside the working directory?

Hi!
Super works, I would like to know if it is possible to be capable of searching the files present in the current Visual Studio windows (even if the files are not in the current directory explorer)
for example here:

However, while running the search within file this is looking for too many files that is really slow.
My option for now:

Thanks for the suggestion! It looks like it might be possible to do so by keeping track of open files using onDidOpenTextDocument and onDidCloseTextDocument, and a couple other related events. It seems like a useful feature, though would require a good bit of work to implement correctly in all cases. I'll look into the feasibility of this.
As for searching within files being slow, you could try using search within files (with type filter). Generally, the search tends to be slow only because rg ends up running through a bunch of files that shouldn't be indexed in the first place.

Super thanks for trying to improve this feature!
And will have a look on the filter side thx!


program: Add version to DID account data

Problem
Over time, as the program and spec evolves, the program will need to potentially handle multiple different formats for the DID document.
Solution
Forward compatibility!  Add a version field at the start of SolidData, and make sure that it can't be written by the Write instruction

Closing this since @context actually gives a version


nginx-1.8.1 fatal error ldap.h: No such file or directory when trying to make

When I was trying to make nginx 1.8.1 with the ngx_http_auth_ldap_module the following below and I have no idea how to fix this. I'm hoping someone can give me some guidance.I am trying to do this on Centos7 I have installed openssl-devel, pcre-devel
/nginx-1.8.1/src/http/modules/nginx-auth-ldap//ngx_http_auth_ldap_module.c:33:18: fatal error: ldap.h: No such file or directory
#include <ldap.h>
^
compilation terminated.
make[1]: *** [objs/addon/nginx-auth-ldap/ngx_http_auth_ldap_module.o] Error 1
make[1]: Leaving directory `/custom-nginx/nginx-1.8.1'
make: *** [build] Error 2

Figured out that openldap-devel was not installed and once I did I no longer got an error


Replace manual constructions of AST elements in visitors with TreeBuilder.

TreeBuilder can be used to create arbitrarily complex statements, with full type attribution, including for types not on the original project's classpath (new types introduced by the migration).
This includes locating all of the types visible from the insertion point's lexical scope, plus any manually supplied classpath entries supplied to the treebuilder.

[ ]  #118

Duplicate of #173


fix(deps): update terraform github.com/terraform-ibm-modules/terraform-ibm-powervs-infrastructure to v8.2.1

This PR contains the following updates:

Package
Type
Update
Change

github.com/terraform-ibm-modules/terraform-ibm-powervs-infrastructure
module
minor
v8.1.4 -> v8.2.1

Release Notes

terraform-ibm-modules/terraform-ibm-powervs-infrastructure
v8.2.1
Compare Source
Bug Fixes

remove vpn gateway from slz presets for power (#536) (297d8b4)

v8.2.0
Compare Source
Features

add quickstart solution (#526) (26bced6)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

:tada: This PR is included in version 0.2.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 0.2.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Get Not compatible with the version of your running IDE (WebStorm 2023.1.2)

i try to dawnload the plugin but it is not compatible

good


Context drawing image has some global rendering state that can affect pixel data

I wrestled with this all day, but with some combinations of ctx.drawImage calls, some will be anti-aliased and some will be aliased (regardless of image smoothing settings.) This behavior is also browser-specific, and so is the actual image produced by the draw call (in both aliased and anti-aliased modes.)
It seems like in Firefox, minified images appear to always be smoothed regardless of settings, and magnified images will honor the setting, but in Chrome, small images are drawn smooth (if instructed to) until a large image is drawn, then small images are drawn rough after that regardless of settings. This causes hash differences based on the rendering state of Chrome. Also, Chrome's "smooth" images are 'smoother' than Firefox's.

These 3 images have different pixel data but were all drawn from the same image source URL.
Setting willReadFrequently to true seems to bring Chrome's behavior into line with Firefox, but again, the images they produce and thus hashes, are different.
const ctx = canvas.getContext("2d", {willReadFrequently: true});

Chrome hashes:

Firefox hashes:

As you can see, they're pretty consistent with themselves but different between themselves. This presents an issue with compatibility.
With smooth scaling disabled, Chrome makes a mess of it (scaling down by a factor of about half makes a huge difference in the hash.)

Drawing the image to a canvas at its original size does, at least, give a pixel-accurate representation between Firefox and Chrome. From there, we might need to implement our own scaling algorithm or some such to guarantee compatibility and determinism from that point onward.

I'm going to sleep now but something like Two.js might do said heavy lifting.

Thanks for testing! That sucks.. I changed it so that it uses the pica library to resize images, which should have the same behaviour across browsers. The only API change is that hash functions are async now, i.e. change phash(...) to await phash(...).

Wow, so fast. Awesome, thanks! I'll check it out tonight. I see you added in whash too, nice. I had to look it up and I came across this paper. Looks interesting!

Did you include the pica lib in the repository?

Could you produce a non-minified dist js for debugging purposes?

Could you produce a non-minified dist js for debugging purposes?

Done!


Snow unstacked etcd support

Issue #, if available:
#1105
Description of changes:
Hold till CAPAS adds the address field to awssnowmachine.status.
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/override eks-anywhere-release-tooling-test-presubmit

/lgtm

/lgtm

/retest


WhisperModel initial_prompt

Feature request
https://github.com/huggingface/transformers/pull/28556
The core transformers library is moving to allow an extra parameter for the WhipserModel to bring initial_prompt in.
As one of the fastest, most supported implementations of Whisper in the browser it would be awesome to have this included in Transformers.js too
Motivation
Adding initial_prompt allows for use cases where the transcribed text needs to match jargon specific to an installation
Your contribution
I've tried getting to a point where I could make a PR with this but my lack of experience with both libraries has made that quite challenging. From the looks of it if we can get prompt_ids from the processor and pass them off to the WhisperModel it shouldn't be too hard to copy the core transformers implementation

Modify the Processor to Support Initial Prompt
Code for it:-
from transformers import WhisperProcessor
Assuming you have an initial prompt you want to use
initial_prompt = "This installation uses technical terms like thermodynamics and calibration."
Load Whisper processor
processor = WhisperProcessor.from_pretrained("openai/whisper-small")
Tokenize the initial prompt to get the prompt_ids
prompt_ids = processor(initial_prompt, return_tensors="pt").input_ids

Modify the Processor to Support Initial Prompt
from transformers import WhisperProcessor
initial_prompt = "This installation uses technical terms like thermodynamics and calibration."
processor = WhisperProcessor.from_pretrained("openai/whisper-small")
prompt_ids = processor(initial_prompt, return_tensors="pt").input_ids

Pass the prompt_ids to the Whisper Model
from transformers import WhisperForConditionalGeneration
model = WhisperForConditionalGeneration.from_pretrained("openai/whisper-small")
audio = processor("path_to_audio_file.wav", return_tensors="pt").input_features
output = model.generate(audio, prompt_ids=prompt_ids)

Integrating with transformers.js:
const processor = await WhisperProcessor.from_pretrained('openai/whisper-small');
const model = await WhisperForConditionalGeneration.from_pretrained('openai/whisper-small');
const initialPrompt = "This installation uses technical terms like thermodynamics and calibration.";
const prompt_ids = processor.tokenize(initialPrompt);
const audio = await processor("path_to_audio_file.wav");
const output = await model.generate(audio, { prompt_ids: prompt_ids });


Mute/fade for AUX and FX bus

Setting fader levels and muting channels was only possible for the master bus.
This PR extends the functionality: Fader levels and mute can now be set on AUX and FX buses as well.
For this, the action has two new options now:

bus type (master/aux/fx)
the bus number

The bus number must only be provided if the bus is not master.
This PR also brings some minor code formatting changes.

Open topics

Is there a way to conditionally hide action option fields? If yes, we should hide the "bus number" field if "master" is selected as bus type.
Is this a breaking change? IMO it will be compatible with the current state.

I test your request later on my hardware. But so far it looks promising.


fix runIOS: appPath is hardcoded, read from log

The runIOS command currently assumes the path to the xcodebuild product - it's hardcoded
  const appPath = `build/Build/Products/Debug-iphonesimulator/${inferredSchemeName}.app`;

https://github.com/facebook/react-native/blob/master/local-cli/runIOS/runIOS.js#L87
This can be a problem, when you e.g. install a release version of the app to the simulator using the cli. We use a separate schema for that, which can be selected with --scheme.
This fix reads the output of the xcodebuild call and searches for the path and the name of the *.app file. If it's found, then it will be used to spawn in the simulator. If not, the default (as before) is used.

By analyzing the blame information on this pull request, we identified @frantic and @markrickert to be potential reviewers.

@javache please have a look again, I refactored the process a bit

@javache thanks for your input, all changes applied

rebased to master

@facebook-github-bot shipit

Thanks for importing. If you are an FB employee go to Phabricator to review.

thanks!


h-full is unintuitive when compared to w-full

I'm not sure if that is by design or a bug, but I couldn't find any issue about it.
Basically, these two lines of code should work in the same way, right? Wrong.

The first line will work as expected, but the second line doesn't unless the parent has a defined height. This is documented:

Use h-full to set an element's height to 100% of its parent, as long as the parent has a defined height.

On most languages and frameworks, width and height work similarly. I was expecting this to also be the case on Tailwind, but I learned it is different. This difference is weird, bad for discoverability, looks like a bug (even if it is documented) and I wish it was fixed. The need for h-screen or an additional div to set the height feels wrong.

Could you share examples of languages and frameworks that have this behavior?
I will tell you about what I'm familiar with, that is Tailwind, Bootstrap and common CSS, but these 3 work exactly the same way:

Boostrap https://getbootstrap.com/docs/4.5/utilities/sizing/#relative-to-the-parent
The CSS definition here and here

The percentage is calculated with respect to the height of the generated box's containing block. If the height of the containing block is not specified explicitly (i.e., it depends on content height), and this element is not absolutely positioned, the value computes to auto. A percentage height on the root element is relative to the initial containing block.

https://css-tricks.com/almanac/properties/h/height/
https://stackoverflow.com/a/7049918/4480553
[pt_BR] https://medium.com/@tassiogoncalvesg/entenda-de-uma-vez-por-todas-como-utilizar-o-height-100-no-css-6d72914a6748

Uh oh! Thanks! I didn't know this also differed in others, even tried Bootstrap in a playground to make sure. Very weird, indeed.  I was actually referring to other non-css stuff, but I never thought it came from css. Thanks!


Add SB Health Check Probe

Add SB Health Check Probe to go-shuttle.
Example usage:
clients := map[string]*azservicebus.Client{
	"namespace1": { client1 },
	"namespace2": { client2 },
}
entity := "testEntity"
subscription := "testSubscription"
interval := 5 * time.Second

hc := NewHealthChecker(clients, &HealthCheckerOptions{
	HealthCheckInterval: interval,
})

shc := &SenderHealthChecker{EntityName: entity}
rhc := &ReceiverHealthChecker{EntityName: entity, SubscriptionName: tc.subscription}

ctx := context.Background()
hc.StartPeriodicHealthCheck(ctx, shc)
hc.StartPeriodicHealthCheck(ctx, rhc)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

113 of 113 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.6%) to 86.154%

Totals

Change from base Build<PHONE_NUMBER>:
1.6%

Covered Lines:
728

Relevant Lines:
845

💛  - Coveralls

curious how usasble this will be, considering that you also need to take into account the prometheus scraping interval?
or do you plan to use this via the informer in a liveness probe?

This will tell us the current health status of any namespace. I am planning to use this with ADXMon to alert on namespace unavailable

note: confirmed the metrics to be working


Align class and property descriptions with the new DCAT scope

Related issue: SEMICeu/DCAT-AP/issues/128
Property and class descriptions are not taking into account that the scope of the new version of DCAT includes other resource types (e.g., data services).
They should be updated accordingly, by replacing catalogue and datasets with the general notion of Resource (dcat:Resource).
If this revision will be implemented, it would be desirable that future versions of DCAT-AP be aligned accordingly.

Relevant changes made via PR https://github.com/SEMICeu/GeoDCAT-AP/pull/42
Revisions have been made by listing, when necessary, the different classes / resource types to which a class / property description refers.
The term "resource" was never used in the narrow sense of dcat:Resource without a proper qualification, and always complemented with the list of relevant resource types - e.g., "a resource documented in a Catalogue (as a Data Service, Dataset, or another Catalogue)".
For more details, please see PR https://github.com/SEMICeu/GeoDCAT-AP/pull/42


Custom URDF File to use with Moveit2

I am trying to run the driver with moveit and a custom urdf description. I am using a ur10e, with other components (a frame the robot is attached to and cart) in the urdf file. On the readme, there is a mention of testing launch files and descriptions. I believe moveit2 does not have a setup assistant yet, how were the examples with the robot alone set up?

@ppascotto You are right, the moveit2 setup assistant is not ready yet, but it is on its way to became available in the future releases of Moveit2.
However, you can easily follow this moveit launch file which starts the robot with moveit2. You have to follow the existing instructions here under the point To test the driver with the example MoveIt-setup, first start the controllers then start MoveIt. (This requires a vcs import of MoveIt packages) .
For this it will be helpful to also check out ur_moveit_config subpackage. Here you can find an examples of .srdf, .yaml and .rviz files that are used with basic configurations of ur robots with combination with moveit2 and ros2_control. If you take a closer look, the files are actually quite the same as in the ROS(1) version that are generated by setup_assistant.
If you don't want to write some of the moveit2-required files manually for your specific robot ( it si not too complicated ) you can generate these files with setup_assistant from ROS(1) version and then just adapt the launch file which is referencing .srdf, .yaml and .rviz files.

@ppascotto Here is the issue you can follow for further information. Feel free to continue collaboration there.


iio: Add support of IIO sampling frequency to channel level

Fix issue #2101
Signed-off-by: Yong Li<EMAIL_ADDRESS>

@laykuanloon @edersondisouza  please help to review/test, I am using the HMC5843 to test it

I tested is working.

@laykuanloon I updated the PR to follow your comments, I also added the accel/gyro devices support, please review

@yongli3
+1

Sorry for the delay, but other than increasing struct version, PR looks good to me.

Merged, tks!


av_libglesv2.dll not copied to output directory with win-x(86|64) RID

Describe the bug
When building an Avalonia project, or projects with a transitive dependency on an Avalonia project, av_libglesv2.dll is not copied to the output directory unless the RID is set to win(7|81|10)-x(86|64).
This throws an exception when AllowEglInitialization is set to true.
This causes any DPI scale over 200% to become unusable on Windows due to lag.
To Reproduce
Steps to reproduce the behavior:

Create a new Avalonia MVVM project.
Set the runtime identifier in csproj:

<RuntimeIdentifier>win-x64</RuntimeIdentifier>

Build the project
Observe that the output directory does not contain av_libglesv2.dll

Expected behavior
The ANGLE assembly should be copied to the output directory for all windows RIDs.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: Windows 19043
Version 0.10.3

@danwalmsley do you remember if we had copy .targets for the legacy dotnet?

This also breaks Desktop Bridge, since AFAIK it forces win-x(64|86) RID on the publish profile.

@kekekeks I only remember it only worked with win7-x64.. probably we did not have a targets file to copy. Will check package.

It looks like to be a new SDK issue, so we probably need to add another set of directories to the runtimes dir

I've noticed this on my current project. Without the file in the directory the app runs fine but has a glass see-through chrome on the window. If I place the file in the directory and run the application, it runs fine but with a normal window chrome ...
Is this required but only on Win 7 boxes? It's a bit confusing.


tpch use two phase aggregate if group by key is not unique.(q16/20)

Proposed changes

aggregate phase: if group-by-keys contains unique column, we prefer one phase aggregate, otherwise we prefer two phase aggregate.

in two phase aggregate with distinct, local aggregate's required distribution should be ANY, not SHUFFLE.

Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.42 seconds
stream load tsv:          424 seconds loaded<PHONE_NUMBER>9 Bytes, about 168 MB/s
stream load json:         23 seconds loaded<PHONE_NUMBER> Bytes, about 97 MB/s
stream load orc:          73 seconds loaded<PHONE_NUMBER> Bytes, about 14 MB/s
stream load parquet:          29 seconds loaded 861443392 Bytes, about 28 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230406093127_clickbench_pr_125529.html

run buildall

run buildall

run buildall

run buildall

run buildall

run buildclickbench

run buildall


script.getComponentParts() call returns null

Whenever the script.getComponentParts()['repo'] or the script.getComponentParts()['organization'] from the src/ni/vsbuild/stages/Archive.groovy stage are being called they give null. Is this a bug or have I configured something wrong?

The values returned from those calls are based on the JOB_NAME set in the build environment by Jenkins. If you check the build environment, what is the value of JOB_NAME. Also, in your Jenkins setup, what is the Full Project Name for the branch you are trying to build?

Hi!  Thanks for the reply! I have defined a Multibranch pipeline named GeneralTools. It contains only one branch named master. The JOB_NAME environmental value is GeneralTools/master (acquired using echo "Running ${env.JOB_NAME}" in the Jenkinsfile). The Full Project name is GeneralTools/master

This isn't a bug per se. This system was designed to be used with the GitHub Branch Source Plugin for Jenkins. The mulitbranch pipelines for building are actually created by the plugin, instead of us manually creating them. The format of those jobs is <github organization>/<repo>/<branch>, so there will always be at least 3 parts to the JOB_NAME.
In your case, there are only 2 parts: repo and branch, so groovy is likely returning an array index error and setting the output map to null.
That said, we could fairly easily accommodate your use case. I'll try to get something today.

Thanks! I didn't know that. It worked straight away with the organisation setup instead of a multibranch.


Move linux provision scripts to virtual-environments

Description
Scripts that are related to system configuration moved from MMS to virtual-environments repository.

Related issue: actions/virtual-environments-internal#1189
Check list

[ ] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

This change seems to have broken our build.
==> azure-arm: Provisioning with shell script: /agent/_work/1/s/images/linux/scripts/installers/post-deployment.sh
==> azure-arm: mv: cannot stat '/imagegeneration/post-generation': No such file or directory
==> azure-arm: Provisioning step had errors: Running the cleanup provisioner, if present...

Are there any additional settings I need for this to work? In case it is related, my build uses modified ubuntu2004.json to publish to SIG.
+ "managed_image_name": "{{user `image_name`}}",
+ "managed_image_resource_group_name": "{{user `sig_resource_group_name`}}",
+ "shared_image_gallery_destination": {
+     "resource_group": "{{user `sig_resource_group_name`}}",
+     "gallery_name": "{{user `sig_name`}}",
+     "image_name": "{{user `image_name`}}",
+     "image_version": "{{user `image_version`}}",
+     "replication_regions": ["{{user `location`}}"]
+ },

@Yanson , please make sure that you have this line in your template. May be some conflicts

Thanks. I do have that but note ubuntu 16 and 18 show "destination": "{{user `image_folder`}}" but 20 shows "destination": "{{user `installer_script_folder`}}". Is that intentional? Could it be a problem? (I only build 20).

Good point, not sure why we have missed Ubuntu 20.04 validation.
@LeonidLapshin could you please take a look?

Can confirm https://github.com/actions/virtual-environments/pull/1812 fixes this issue for me.


Recommend JS design patterns over others

Should we go further and tackle the problem of JavaScript having so many ways to write things? Not just at the commonjs level, but also things like => vs function, class vs function, for vs forEach vs map, Promises vs async/await, TypeScript vs Flow, etc.
Every other language has the same issue, of course. But JS happens to be worse, and this can result in code being very hard to read and modify by devs inheriting a JS codebase (which is the main problem the GDS Way is trying to solve, I think).  Should we encourage some of those practices and reject others?
I'm afraid I don't have a PR that answers this, but I think an extra conversation about higher-level abstract patterns is worth having.

Not a comment about what style of JavaScript we recommend but a proposal for the upper limit of new JavaScript features we support.
I'd propose the following:

Avoid stage-3 candidates and below
Track the V8 version in the LTS Node.js release

This means avoiding transpiling entirely, and use only features natively available.
See https://zeit.co/blog/next#data-fetching-is-up-to-the-developer
"Our stance of what features we transpile (like async/await) can be summed up as: we target V8's capabilities. Since our goal is code-sharing between server and client, this gives us great performance when executing the code on Node and developing on Chrome or Brave, for example."

In terms of actual style, I'd propose that we use the more immutable functional methods for data manipulation where possible.
Making use of ES5 .map() .filter() .reduce() .concat() .
Related:

https://eloquentjavascript.net/1st_edition/chapter6.html
http://cryto.net/~joepie91/blog/2015/05/04/functional-programming-in-javascript-map-filter-reduce/

We definitely need to expand the Node.js style guide to have a section on preferred JavaScript coding styles.
@Nooshu shared this link to a repo of best practices a couple of weeks back and we could just wholesale appropriate a lot of it as our own opinions.
We could enforce these opinions with an even more opinionated linter than Standard such as xo.
For instance xo prefers const over var (unless a let is appropriate) and also => vs function.
Right now on Pay we’re still on node 6.11.12 so we’re not doing any async/await stuff so I dunno what we’d say about that stuff.

I can't find the article now, it was by Google or Mozilla.
But their argument for writing async/await was that they intend to optimise the implementation heavily in future so while it may be slower now, in future it will be the fastest way to handle async.

I think I'll try and write something up, maybe during the next firebreak.

Max's PR was merged, closing.


Improve unit test coverage

I have improved code coverage in Application module to 96%, but there are still a couple lines in ConsoleController that doesn't seem to be easy to test.
I just created the pull request so that we can see coveralls result to be sure.
The rest of the modules seem to already have 100% code coverage.

Thank you. it should pointed to master first ;) as it's a hotfix ( 0.0.3 milestone ). it's ok. I'll take care on merging ;) and because there is no issue left in master ( 0.0.3 milestone ), develop can be merged into master after this PR commits cherry-picked into master.

merged.
master : https://github.com/sitrunlab/LearnZF2/commit/17e2a72dc668e9bf4dba17f52662955ca2e9075a
develop : https://github.com/sitrunlab/LearnZF2/commit/58d818fd1f5c22d65427ee9b076f3a1494170294


I want to use space to accept suggestion

I'd like to use space to accept suggestion, not enter

You can configure this by binding "acceptSelectedSuggestion" to "space". For example, see this issue: https://github.com/Microsoft/vscode/issues/26285#issuecomment-300406707


Add initial CONTRIBUTING.md.

Cool!

Update README.md, please.

@elfet In regards to what specifically?

Will do it myself later :)


Callbacks not working under Ubuntu

I am writing an application using GLFW 3.2, but when a window or key event is triggered the corresponding callbacks are not called. I have the same code working under Windows. This is how I have it in my code:
Inside window init:
// Create renderer for window
glfwMakeContextCurrent(m_window);
// Setup callbacks
glfwSetWindowSizeCallback(m_window, windowResize);

The callback:
void windowResize(GLFWwindow *window, int width, int height)
{
    std::cout << "Here" << std::endl;
    glViewport(0, 0, width, height);
}

"Here" is never printed in the console when I resize the window. The same happens with keyboard input.
Thanks.

My bad, I wasn't calling "glfwPollEvents()"


Protocol Buffer update for release 2.29.x at Fri Nov 11 12:45:23 UTC 2022

FYI, this PR does not contain any changes that are relevant for iOS. Anyway, I would suggest to merge it anyway to keep future ProtoBuf replications in sync.