2Ship2Harkinian has weird slow down issues

[ ] I have checked the known issues and searched Github to ensure this issue has not already been reported.
[ ] This is not a feature request, I know those belong on Discord/Github Discussions.

Description of the bug:
When playing on Windows for a good while, the game will suddenly have a massive slowdown that last forever.
Expected behavior:
When playing the game, it should run like normal all the time.
System Information:

OS: Windows 10, 19045.4529
GFX Backend: DirectX
Game Version: V1.0.1
Rom Version: US V1.0

Additional Information:

Seconded!

Same issue here. It's not normal "the PC can't handle it" slowdown, either--it almost feels like the game logic (pre-extrapolation to extra framerate) is being slowed down, somehow? The game is clearly still rendering at a very high framerate--100 fps, in my case--but is visibly and audibly experiencing slowdown and "chugging," if that makes any sense. Very odd.
I experienced it within the first cycle (towards the end of Night 1), which prevented me from finishing said cycle and thus being able to save and quit to test whether or not it persists after loading an affected save file.

Same issue here,
OS Windows 10 22H2 Build 19045.4651
GFX Backend: DirectX
Game Version: V1.0.2
Rom Version: US V1.0
Graphics adjustment: 60 fps
After starting the game for the first time and gone to the 'Deku' Cycle I got to learn the Song of Healing.
Then the slowdown started. It's an 'steady' slowdown (audio also stutters enormously)
I've managed to save at an owl statue. The reset option does nothing anymore. I have to close soh and reopen it.
Then everything works as normal. This is only the second time I used 2s2h so I cant say it will slow down next time.

This has been fixed in the repository, further corroborating reports are not necessary.

This slowdown fix has been released starting with Satoko 1.1.x

Hey, sorry it took so long for me to respond, but I played the latest version of 2Ship2Harkinian, and the slowdown issue seem to have gotten worse when I started playing. Not sure if it’s my PC that’s outdated now, but it didn’t seem to fix the issue.


Does not install the kernel modules on Debian

Hi and thanks for your work on this module.
I notice that it doesn't actually install the zfs-dkms package on Debian 9, which would be really useful.

Did you see the note in the README for Debian 9? You need to enable the contrib repository with something like:
::apt::source { 'contrib':
  location => 'http://deb.debian.org/debian',
  repos    => 'contrib',
}

From memory I found it wouldn't install the dkms bits otherwise. If you have done that and it still doesn't work, let me know.

Thanks for your reply.
Yes, I have the contrib repository enabled. I believe that the problem is that the zfsutils-linux package only recommends the zfs-dpks package. I have an apt preference not to install recommended packages, which is why it didn't pull it in automatically. Otherwise I think it would have worked.

I will likely change the package_name parameter to also take an array which can then be set to ['zfsutils-linux', 'zfs-dkms']. The zfs-zed recommendation is covered already by the ::zfs::zed class.

@tullis I've been meaning to ask, would you mind sharing with me how you configured apt to not install recommended packages (presumably you've done it with the apt Puppet module somehow and I'm not a Debian user). I'd like to add it to my acceptance tests going forward so it catches things like this.

Until now I have been doing it with a simple file resource in puppet that manages an apt_preferences fragment.
  file { '/etc/apt/apt.conf.d/50disable-recommends':
    ensure => present,
    owner  => 'root',
    group  => 'root',
    mode   => '0644',
    source => 'puppet:///modules/base/50disable-recommends',
  }

That fragment file contains the following:
APT::Install-Recommends "false";
APT::Install-Suggests "false";

I am planning to change it to use an [apt::setting](https://forge.puppet.com/puppetlabs/apt#defined-type-aptsetting) type, but I haven't got round to it yet.

Sorry for the delay fixing this, I've pushed v2.2.3 to the forge which now works on Debian if you have APT configured to not install recommended packages. Thanks for the bug report!


Youtube Playlist Wrong loading

Hi,
If I am entering a Playlist in the loadTrack() and the input is a ytsearch: playlist.
Then I dont get back the right playlist. I got only one song or another Playlist.
Also If im only searching for Strings like "ytsearch: SDP" or "ytsearch: KDA" He wants to get me a full playlist.
Is that a bug with the playlists?

If you pass a string that starts with ytsearch, lavaplayer loads a playlist containing all search results. The usual way to deal with this is to only queue the first track.
if you already have a playlist's URL, just pass it to loadTrack without the ytsearch: prefix

Mhhh but now I am filtering if its a playlist and if I now try it with for example this link:https://www.youtube.com/watch?v=oUiOylPbfV0&list=PLJ9wRRCY-gY1YMnDTThA6HW-5dFIc9z-V
There is noMatches().

Ah got It fixed. Unfortunally I casted the URI to lowercase xD


We updated our AWS SDK v1 version and existing code started failing. I distilled it down to this minimal case. The issue happens when the generated object in the GOCACHE goes above 4GB. The goobj/objfile Header appears to be using a uint32, which seems like an overflow might be happening when calculating the offsets. I dumped the headers from one of the objects while investigating (not the minimal case above, so offsets are a little different):
BlkAutolib:<PHONE_NUMBER>
BlkPkgIdx:<PHONE_NUMBER>
BlkFile:<PHONE_NUMBER>
BlkSymdef:<PHONE_NUMBER>
BlkHashed64def:<PHONE_NUMBER>
BlkHasheddef:<PHONE_NUMBER>
BlkNonpkgdef:<PHONE_NUMBER>
BlkNonpkgref:<PHONE_NUMBER>
BlkRefFlags:<PHONE_NUMBER>
BlkHash64:<PHONE_NUMBER>
BlkHash:<PHONE_NUMBER>
BlkRelocIdx:<PHONE_NUMBER>
BlkAuxIdx:<PHONE_NUMBER>
BlkDataIdx:<PHONE_NUMBER>
BlkReloc:<PHONE_NUMBER>
BlkAux:<PHONE_NUMBER>
BlkData:<PHONE_NUMBER>
BlkRefName: 10123514
BlkEnd: 10148874

I tested it in a few other versions:
1.22.1 - compiles
1.22.0 - compiles
1.22rc2 - compiles
1.22rc1 - fails for same reason
What did you see happen?
panic: runtime error: slice bounds out of range [::3237855945] with capacity 26478551

goroutine 1 [running]:
cmd/internal/goobj.(*Reader).BytesAt(...)
	cmd/internal/goobj/objfile.go:622
cmd/internal/goobj.(*Reader).uint32At(...)
	cmd/internal/goobj/objfile.go:635
cmd/internal/goobj.(*Reader).StringRef(0x0?, 0x1be438?)
	cmd/internal/goobj/objfile.go:675 +0xf8
cmd/internal/goobj.(*Reader).Autolib(0xc000014120)
	cmd/internal/goobj/objfile.go:688 +0x71
cmd/link/internal/loader.(*Loader).Preload(0xc0000ec000, 0xa, 0xc000028020, 0xc0001c2000, 0xc0000cc410, 0x46f725?)
	cmd/link/internal/loader/loader.go:2147 +0x395
cmd/link/internal/ld.ldobj(0xc00019e000, 0xc000028020, 0xc0001c2000, 0x194086c, {0xc00001a300, 0x2c}, {0x7ffcd10911bc, 0x24})
	cmd/link/internal/ld/lib.go:2294 +0xa8f
cmd/link/internal/ld.loadobjfile(0xc00019e000, 0xc0001c2000)
	cmd/link/internal/ld/lib.go:1136 +0x7f3
cmd/link/internal/ld.(*Link).loadlib(0xc00019e000)
	cmd/link/internal/ld/lib.go:544 +0x214
cmd/link/internal/ld.Main(_, {0x20, 0x20, 0x1, 0x7, 0x10, 0x0, {0xc000012439, 0x1, 0x1}, ...})
	cmd/link/internal/ld/main.go:284 +0x104b
main.main()
	cmd/link/main.go:72 +0xdfb

What did you expect to see?
A successful build

Currently there is no plan to support an object larger than 4 GiB. Try refactoring the code or splitting to multiple objects. We can emit a better error, though.

Sorry for not being clear, I'm not asking for >4GB support. Having a better error message would suffice. Especially because we are unblocked by just using Go 1.22 which generates a much smaller object. I didn't analyze the objects from 1.22, but the largest object in the cache is ~75MB for the same sample program.
I mainly opened the issue because the behavior is so vastly different between 1.21 and 1.22. The suspected overflow seems to result in strange offsets. The end offset in the object says it ends at about 10MB, but the previous offsets are in the 3GB range. I couldn't find another object in the cache that seems to have an end offset before the other offsets. So my thought was that if the overflow issue was addressed, it might actually produce a much smaller object file and be able to compile. But this is my first time looking at any of this code (I freely admit being a complete noob 😄), so it might be completely acceptable that those offsets are after the end offset.


The url for your website needs to be updated

The heroku url is no longer active. Could you consider changing it to https://mohamedebrahim96.vercel.app/

Thanks alot for your review.
I updated it


"no relay/exit support" when running default executable

This is the output I get when running the default exe generated by a successful build:
[2016-03-26 12:16] Credentials created.
[2016-03-26 12:16]   Signing key fingerprint: 8134b7fba2aa271884c7ccf9ac4314b056f68784
[2016-03-26 12:16]   Onion key fingerprint:   6cb4771e317699b5f06497a18488314131a78787
[2016-03-26 12:16]   TLS key fingerprint:     b111b5ce1c241663f8d6c8c22a7c16cc96c55cfa
[2016-03-26 12:16] Fetching credentials for default directory moria1 [<IP_ADDRESS>:9131]
[2016-03-26 12:16] Fetch failed: Fetch timed out.
[2016-03-26 12:16] Fetching credentials for default directory tor26 [<IP_ADDRESS>:80]
[2016-03-26 12:16] Fetching credentials for default directory dizum [<IP_ADDRESS>:80]
[2016-03-26 12:16] Fetching credentials for default directory Tonga [<IP_ADDRESS>:80]
[2016-03-26 12:16] Fetch failed: Parser error: Failed reading: HTTP Error: Not found ["\r\n"]
[2016-03-26 12:16] Fetching credentials for default directory gabelmoo [<IP_ADDRESS>:80]
[2016-03-26 12:16] Fetching credentials for default directory dannenberg [<IP_ADDRESS>:80]
[2016-03-26 12:16] Weird: fingerprint mismatch. Ignoring dir.
[2016-03-26 12:16] Fetching credentials for default directory Faravahar [<IP_ADDRESS>:80]
[2016-03-26 12:16] Fetching credentials for default directory longclaw [<IP_ADDRESS>:80]
[2016-03-26 12:16] 5 of 8 default directories loaded.
[2016-03-26 12:16] String consensus document update.
[2016-03-26 12:16] Using directory dizum for consensus.
[2016-03-26 12:16] Waiting for Tor connections on port 9002
[2016-03-26 12:16] Added new directory entry for dannenberg
[2016-03-26 12:16] Added new directory entry for maatuska
[2016-03-26 12:16] Added new directory entry for urras
[2016-03-26 12:17] Failed to add new directory for moria1
[2016-03-26 12:17] Found enough valid signatures: dannenberg, tor26, longclaw, maatuska, urras, dizum, gabelmoo, Faravahar
[2016-03-26 12:17] New router processing complete. 2950 of 6177 routers available.
[2016-03-26 12:17] Will reload census at 13:53
[2016-03-26 12:17] Trying to connect to <IP_ADDRESS>
[2016-03-26 12:17] Just built connection with them.
[2016-03-26 12:17] Created new link to <IP_ADDRESS> ("OdyX")
[2016-03-26 12:17] Built initial link to "<IP_ADDRESS>" with circuit ID<PHONE_NUMBER>
[2016-03-26 12:17] Created circuit<PHONE_NUMBER>
[2016-03-26 12:17] Extending circuit to "<IP_ADDRESS>"
[2016-03-26 12:17] Extending circuit to "<IP_ADDRESS>"
[2016-03-26 12:17] Extending circuit to "<IP_ADDRESS>"
[2016-03-26 12:17] Extending circuit to "<IP_ADDRESS>"
[2016-03-26 12:17] Extending circuit to exit node "<IP_ADDRESS>"
[2016-03-26 12:17] I believe I have the following addrs: [IP4 "<IP_ADDRESS>"]
[2016-03-26 12:17] Trying to connect to <IP_ADDRESS>
[2016-03-26 12:17] Just built connection with them.
[2016-03-26 12:17] Created new link to <IP_ADDRESS> ("Unnamed")
[2016-03-26 12:17] Built initial link to "<IP_ADDRESS>" with circuit ID<PHONE_NUMBER>
[2016-03-26 12:17] Created circuit<PHONE_NUMBER>
[2016-03-26 12:17] Extending circuit to "<IP_ADDRESS>"
[2016-03-26 12:17] Extending circuit to "<IP_ADDRESS>"
[2016-03-26 12:17] Extending circuit to "<IP_ADDRESS>"
[2016-03-26 12:17] Extending circuit to "<IP_ADDRESS>"
[2016-03-26 12:17] Extending circuit to exit node "<IP_ADDRESS>"
[2016-03-26 12:17] Failed to create connection to myself. No relay/exit support.
--
I have bolded the lines of output I am unsure about-- are these errors, or are some directories expected to not be fetched correctly? Do I have to configure a port on my laptop to act as an exit node? Thanks in advance!

Well, regarding the first set, I've had some timeout problems with directory servers before, so that's not too unusual.
With regard to the "failed to create a connection to myself" error, that's fine, too, as long as you don't want to be a relay or exit node. :) You'll get that error when either one of your firewalls blocks incoming connections to your address from the Internet, your NAT'd without the appropriate forwarding rules, or (more annoyingly) when something in the circuit (typically the exit node) flakes out on you. Are any of those conditions likely?

Ahh, so let me confirm that this isn't necessarily unexpected behavior?
I'm pretty sure I'm not behind a firewall (home router) and I'm unsure how to check if the net addr was translated with the proper forwarding rules... can you tell me where I might read more about this? I'm also unsure how to diagnose whether the exit node failed or not; does the execution output I listed above give any insight into this? If I run the program 5 times in a row, I get pretty much the same output every time.

Nope, it can happen. Try running it a couple times; it should get through once.
Also, upon a second look, it appears that it did correctly generate a circular route:
[2016-03-26 12:17] I believe I have the following addrs: [IP4 "<IP_ADDRESS>"]
So really, it's just a matter of a really bad message in an exception handler.


Fix compatibility with Python 3.7

In Python 3.7, async is a reserved keyword and cannot be used anymore
as a method or a variable without triggering a syntax error. The
compatibility with older versions of Python (3.2 and 3.3) need to be
removed.

Thank you for raising this PR!
Could you please elaborate a bit on the syntax error you mention - in which case is it happening? The CI jobs seem to pass under 3.7....

Actually, what do you think about #179?
Moving async from program text helps retaining compatibility with old Pythons (which is somewhat insignificant feature, but still...).

I think it is not needed to remove support for older python , i think it can be fixed by elegant way in my pull request https://github.com/etingof/pysnmp/pull/179 , just replacing asyncio.async by getattr(asyncio, 'async') which returns asyncio.async function ...but not causing SyntaxError on python3.7 as async in getattr is String :)

@etingof  I've closed my pull request and created new with all fixed asyncio.async issues https://github.com/etingof/pysnmp/pull/180 , before I  forgot on one usage ...
Michals-MacBook-Air:pysnmp kevin$ grep -R asyncio.async .
./pysnmp/carrier/asyncio/dispatch.py:            # Avoid deprecation warning for asyncio.async()
./pysnmp/carrier/asyncio/dgram/base.py:            # Avoid deprecation warning for asyncio.async()
comment in code not causing SyntaxError ... :)

Package builded from this repo working and not throwing SyntaxError https://salsa.debian.org/python-team/modules/python-pysnmp4

Awesome, thank you! #180 has been merged.

Out of curiosity, is a release planned soon?

The plan is to release 4.4.5 soon-ish. Well, given the 3.7 fix within a week (hope time permits).
Most of the background work is happening in branches around master. That would be pysnmp 5, release time is hopefully before the end of this year.

The plan is to release 4.4.5 soon-ish. Well, given the 3.7 fix within a week (hope time permi

fyi: 4.4.5 has been release on PyPI


Compilation fails at SpatialConvolutionFFT

[ 25%] Building CXX object CMakeFiles/fbcunnlayers_cuda.dir/src/fft/SpatialConvolutionCuFFT.cpp.o
In file included from /mnt/hfsshare/LIBRARIES/fbcunn/src/fft/Utils.h:99:0,
                 from /mnt/hfsshare/LIBRARIES/fbcunn/src/fft/SpatialConvolutionCuFFT.cpp:11:
/mnt/hfsshare/LIBRARIES/fbcunn/src/fft/Utils-inl.h:25:70: error: redeclaration of ‘template<int FFTDim> std::unique_ptr<THCudaTensor, CudaTensorDeleter> facebook::deeplearning::torch::makeCuFFTTensorReal(THCState*, THCudaTensor*, const std::vector<long int>&, THCudaTensor*, facebook::deeplearning::torch::FFTOutputSpecification)’ may not have default arguments [-fpermissive]
   FFTOutputSpecification inPlace = FFTOutputSpecification::OutOfPlace) {
                                                                      ^
/mnt/hfsshare/LIBRARIES/fbcunn/src/fft/Utils-inl.h:143:70: error: redeclaration of ‘template<int FFTDim> std::unique_ptr<THCudaTensor, CudaTensorDeleter> facebook::deeplearning::torch::makeCuFFTTensorComplex(THCState*, THCudaTensor*, const std::vector<long int>&, THCudaTensor*, facebook::deeplearning::torch::FFTOutputSpecification)’ may not have default arguments [-fpermissive]
   FFTOutputSpecification inPlace = FFTOutputSpecification::OutOfPlace) {
                                                                      ^
/mnt/hfsshare/LIBRARIES/fbcunn/src/fft/Utils-inl.h:202:54: error: redeclaration of ‘template<int FFTDim> std::unique_ptr<THCudaTensor, CudaTensorDeleter> facebook::deeplearning::torch::makeCuFFTTensorComplex(THCState*, const std::vector<long int>&, THCudaTensor*)’ may not have default arguments [-fpermissive]
   THCudaTensor* candidateCudaStorageComplex = nullptr) {
                                                      ^
/mnt/hfsshare/LIBRARIES/fbcunn/src/fft/Utils-inl.h:243:70: error: redeclaration of ‘template<int FFTDim> std::pair<std::unique_ptr<THCudaTensor, CudaTensorDeleter>, std::unique_ptr<THCudaTensor, CudaTensorDeleter> > facebook::deeplearning::torch::makeCuFFTTensors(THCState*, THCudaTensor*, const std::vector<long int>&, facebook::deeplearning::torch::FFTOutputSpecification)’ may not have default arguments [-fpermissive]
   FFTOutputSpecification inPlace = FFTOutputSpecification::OutOfPlace) {
                                                                      ^
/mnt/hfsshare/LIBRARIES/fbcunn/src/fft/Utils-inl.h:260:70: error: redeclaration of ‘template<int FFTDim> std::pair<std::unique_ptr<THCudaTensor, CudaTensorDeleter>, std::unique_ptr<THCudaTensor, CudaTensorDeleter> > facebook::deeplearning::torch::makeCuFFTTensors(THCState*, thpp::Tensor<float>&, const std::vector<long int>&, facebook::deeplearning::torch::FFTOutputSpecification)’ may not have default arguments [-fpermissive]
   FFTOutputSpecification inPlace = FFTOutputSpecification::OutOfPlace) {
                                                                      ^
/mnt/hfsshare/LIBRARIES/fbcunn/src/fft/SpatialConvolutionCuFFT.cpp: In member function ‘facebook::deeplearning::torch::detail::cufftPlan* facebook::deeplearning::torch::detail::CuFFTBuffers<FFTDim>::plan(THCState*, THCudaTensor*, THCudaTensor*, facebook::deeplearning::torch::FFTParameters, uint32_t)’:
/mnt/hfsshare/LIBRARIES/fbcunn/src/fft/SpatialConvolutionCuFFT.cpp:250:63: error: no matching function for call to ‘make_unique(int&)’
     auto h = folly::make_unique<cufftPlan, CuFFTPlanDeleter>(p);
                                                               ^
In file included from /usr/local/include/folly/io/Cursor.h:31:0,
                 from /usr/local/include/thpp/if/gen-cpp2/Tensor_types.h:13,
                 from /usr/local/include/thpp/Storage.h:15,
                 from /usr/local/include/thpp/Tensor.h:18,
                 from /mnt/hfsshare/LIBRARIES/fbcunn/src/fft/Utils.h:5,
                 from /mnt/hfsshare/LIBRARIES/fbcunn/src/fft/SpatialConvolutionCuFFT.cpp:11:
/usr/local/include/folly/Memory.h:49:1: note: candidate: template<class T, class ... Args> typename std::enable_if<(! std::is_array< <template-parameter-1-1> >::value), std::unique_ptr<T> >::type folly::make_unique(Args&& ...)
 make_unique(Args&&... args) {
 ^
/usr/local/include/folly/Memory.h:49:1: note:   template argument deduction/substitution failed:
/mnt/hfsshare/LIBRARIES/fbcunn/src/fft/SpatialConvolutionCuFFT.cpp:250:63: note:   cannot convert ‘p’ (type ‘int’) to type ‘facebook::deeplearning::torch::detail::CuFFTPlanDeleter&&’
     auto h = folly::make_unique<cufftPlan, CuFFTPlanDeleter>(p);
                                                               ^
In file included from /usr/local/include/folly/io/Cursor.h:31:0,
                 from /usr/local/include/thpp/if/gen-cpp2/Tensor_types.h:13,
                 from /usr/local/include/thpp/Storage.h:15,
                 from /usr/local/include/thpp/Tensor.h:18,
                 from /mnt/hfsshare/LIBRARIES/fbcunn/src/fft/Utils.h:5,
                 from /mnt/hfsshare/LIBRARIES/fbcunn/src/fft/SpatialConvolutionCuFFT.cpp:11:
/usr/local/include/folly/Memory.h:56:1: note: candidate: template<class T> typename std::enable_if<std::is_array< <template-parameter-1-1> >::value, std::unique_ptr<T> >::type folly::make_unique(size_t)
 make_unique(const size_t n) {
 ^
/usr/local/include/folly/Memory.h:56:1: note:   template argument deduction/substitution failed:
/mnt/hfsshare/LIBRARIES/fbcunn/src/fft/SpatialConvolutionCuFFT.cpp:250:63: error: wrong number of template arguments (2, should be 1)
     auto h = folly::make_unique<cufftPlan, CuFFTPlanDeleter>(p);
                                                               ^
In file included from /usr/local/include/folly/io/Cursor.h:31:0,
                 from /usr/local/include/thpp/if/gen-cpp2/Tensor_types.h:13,
                 from /usr/local/include/thpp/Storage.h:15,
                 from /usr/local/include/thpp/Tensor.h:18,
                 from /mnt/hfsshare/LIBRARIES/fbcunn/src/fft/Utils.h:5,
                 from /mnt/hfsshare/LIBRARIES/fbcunn/src/fft/SpatialConvolutionCuFFT.cpp:11:
/usr/local/include/folly/Memory.h:64:1: note: candidate: template<class T, class ... Args> typename std::enable_if<(std::extent<_Tp>::value != 0), std::unique_ptr<T> >::type folly::make_unique(Args&& ...) <deleted>
 make_unique(Args&&...) = delete;
 ^
/usr/local/include/folly/Memory.h:64:1: note:   template argument deduction/substitution failed:
/usr/local/include/folly/Memory.h: In substitution of ‘template<class T, class ... Args> typename std::enable_if<(std::extent<_Tp>::value != 0), std::unique_ptr<T> >::type folly::make_unique(Args&& ...) [with T = int; Args = {facebook::deeplearning::torch::detail::CuFFTPlanDeleter}]’:
/mnt/hfsshare/LIBRARIES/fbcunn/src/fft/SpatialConvolutionCuFFT.cpp:250:63:   required from here
/usr/local/include/folly/Memory.h:64:1: error: no type named ‘type’ in ‘struct std::enable_if<false, std::unique_ptr<int, std::default_delete<int> > >’
CMakeFiles/fbcunnlayers_cuda.dir/build.make:6053: recipe for target 'CMakeFiles/fbcunnlayers_cuda.dir/src/fft/SpatialConvolutionCuFFT.cpp.o' failed
make[2]: *** [CMakeFiles/fbcunnlayers_cuda.dir/src/fft/SpatialConvolutionCuFFT.cpp.o] Error 1
CMakeFiles/Makefile2:130: recipe for target 'CMakeFiles/fbcunnlayers_cuda.dir/all' failed
make[1]: *** [CMakeFiles/fbcunnlayers_cuda.dir/all] Error 2
Makefile:116: recipe for target 'all' failed
make: *** [all] Error 2

I'm installing on Ubuntu 15.10 with gcc 5.2. Because of that, I varied the install instructions by installing folly and fbthrift from the trunk instead of the tagged versions.

hmm, the tagged versions of folly are the ones that are compatible with fbcunn on github.
Which functionality do you need in fbcunn? I can see if i can isolate it out for you.

@soumith  The lookup table and hierarchical softmax functionality - and thank you!
Is there any plan to bring fbcunn up to date with current libraries?  I mean, it has to be causing some difficulty for you folks if its incompatible with the current versions of your own libraries?
Or perhaps to make it run consistently on docker?

nn.LookupTable is faster than fbcunn's version now.
I'll try to get HierarchicalSoftmax out as well.
I'll also work on pushing out latest fbcunn changes out.

@soumith  re: lookuptable, perhaps, but I think it still doesn't handle sparse updates.  The Dictionary class does, but I've had some bugs with it.
Thank you!!!
Is there any way I can be helpful to you in all of this?

LookupTable handles sparse updates if you use :accUpdateGradParameters

hello, i got the same issue. is there any way to fix this ?

I'm having the same issue. Did you find a way? @elbamos @soumith


which of the svgs should i use?

which of the svgs should i use?

robot 1 or robot 2

@owocki I think you should use robot 1

ok that robot needs to have permuations of appendages/heads/eyes/whatever to go into the avatar builder. its just 1 avatar rn

@owocki I have updated it. You can review it.


fix broadcast repopulate

https://github.com/andrewgazelka/hyperion/blob/ecf1a13de69a1cc666b630183f13b9bed2ffca35/crates/broadcast/src/lib.rs#L159-L163

we removed broadcast crate.


🐛 Do not count docs/scripts/generated_script.sh

Summary
This PR trims one more bit of junk before counting.
Related issue(s)
Fixes #

/cc @waltforme

/lgtm
/approve


Test more configurations on CI

Ideally we could fill this table:

osx
linux

native
x
x

cuda

opencl

Given the recent issue ( #61 ) I would propose we could also add Windows to that matrix.
CI solutions could be:

Appveyor & Travis to support at least with native
or set up a dedicated CI server on AWS/Azure (as proposed by reem in #59 )


treewide: remove global with lib; statements in pkgs/development

Description of changes
I am trying to split #211241 into smaller changes to get it into a reviewable bulk and try to approach that in smaller groups by pkgs category.
This PR removes the global with lib; statements of pkgs/development.
I tried to follow the rule to replace all with lib; with lib. but if its for the meta attr. For meta i replaced it with  meta = with lib; { if there was no other scoping before that. It there was other scoping i tried to follow that.
Some packages like gcc i have skipped as it does not look super trival for me (it also imports builtins globally).
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@ofborg build libvirt


closer integration with assertion libraries

describe("functionName", () => {

    it("it's passing because you forgot to write its body", () => {

    });

causes:
  ✓ it's passing because you forgot to write its body

I suggest:
  - it's passing because you forgot to write its body (body is empty)

Can you point to any other test framework that does this?
A naive implementation is a regexp trying to match () => {}, function () {}, and their variations in spacing/indentation/formatting, etc. But it seems like a little too much hand holding, and there's very little we can do to prevent people from writing useless tests. So I'd just rather avoid going down that rabbithole. For example, this is a useless test with a body:
it('adds numbers', function() {
  var a = 1 + 2;
  // no assertion, can't fail
});

I just started test-driven development yesterday. Mocha is the first test framework I've used.
I like it because you can program in English: take an English paragraph about how something should work, e.g. in a tutorial, boil it down to something to put in it's first argument. If there are more than one of these at a time, I need to make more than one it, so there's a risk that you'll forget to write the body of each it. I think Mocha should help.

@danielstjules @willnwhite
QUnit has a feature wherein you can assert that n assertions were made.  I think it's configurable such that if a test makes no assertions, it will fail.  So there's a precedent for this, at least, but Mocha doesn't currently have any such feature.
Implementing such a feature may be exceedingly difficult, since we're not guaranteed any given assertion framework will be running at any time.  That means we don't know what to check to make sure an "assertion" was indeed made; some libs will throw an AssertionError, some will throw an Error, some will throw something else entirely.
If we wanted this, we'd need closer integration between Mocha and assertion libraries.  A solution may be to wrap assertion libraries in plugins.  For example, the mocha-chai plugin would mark Chai as the assertion library in use (and optionally install Chai itself); from there we could write custom code that is able to detect when a Chai assertion is made, and react accordingly.  Given that there are umpteen assertion libraries, perhaps supporting a few popular libs out-of-the-box would be fine; users can always write new plugins to support integration with other libs.
I'm not sure what other use cases there are surrounding this sort of integration.  If this is the only one, it's probably not worth the effort.
Anyway, I'm open to more ideas.

I'm going to reopen this and leave it for discussion.

cc @mocha

@boneskull Seems like this diverges from the original issue of an empty body?
As for counting assertions, it's been previously discussed here: https://github.com/mochajs/mocha/issues/1651 Maybe close this in favor of the other issue?

yeah, good idea.

see #2044

In the workflow I've described, it's unlikely that once you write something in it's body you'll forget to write an assertion, so just testing for an empty body should be enough.

as @danielstjules wrote, anything along those lines will be a brittle hack, since we're not in the business of analyzing an AST.


Upping Angular and Dart versions

Will review/merge next week.

Install docs also need to be updated.


Report Bug Translation Error

Microsoft PowerToys version
0.64.0
Utility with translation issue
General
🌐 Language affected
French
❌ Actual phrase(s)
Signaler un bogue
✔ Expected phrase(s)
Signaler un bug
ℹ Why is the current translation wrong
because a "bogue" does not correspond to a word in the French language

https://microsoft.visualstudio.com/OS/_workitems/edit/42592620 /loc

This should be fixed in a newer build such as .70.1, can you please verify? /needinfo


Post tweet source with ACAccount

I'm using Swifter in an utility that tweets and I've been wondering how can I pass to Twitter the source of the tweet. Currently, in Tweetbot, tweets sent from my app show „via iOS”.

In order for Twitter to recognize your app, you must be using application tokens (Token & Secret) from Twitter API. Using ACAccount to tweet is using the system's application token & secret, which is why it shows up as "via iOS"

I see. I'll convert to that option then.
Thanks!


block_info kwarg from map_blocks - error when mixing array input with dataframe/series output

What happened:
You cannot use the block_info keyword argument with map_blocks if the processing function returns anything other than an array. For example, you can't use the block_info kwarg with functions returning Series or DataFrame objects (similar to the examples in this blogpost).
This might be more of an edge case that isn't supported, rather than a bug. Still I feel obligated to mention it, now I've come across it.
What you expected to happen:
I expected things that worked with map_blocks to work the same way, regardless of whether the block_info keyword argument was passed in or not.
Minimal Complete Verifiable Example:
import dask.array as da
import pandas as pd

def func(x, block_info=None):
    return pd.DataFrame({'x': [1,2,3], "y": [4,5,6]})

arr = da.random.random((100,100), chunks=(50,50))
result = arr.map_blocks(func, drop_axis=1, dtype=float)

Error message (click to expand details):
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-22-dde43f1e2f6d> in <module>
----> 1 result = arr.map_blocks(func, drop_axis=1, dtype=float)

~/anaconda3/envs/dask/lib/python3.8/site-packages/dask/array/core.py in map_blocks(self, func, *args, **kwargs)
   2362     @wraps(map_blocks)
   2363     def map_blocks(self, func, *args, **kwargs):
-> 2364         return map_blocks(func, self, *args, **kwargs)
   2365
   2366     def map_overlap(self, func, depth, boundary=None, trim=True, **kwargs):

~/anaconda3/envs/dask/lib/python3.8/site-packages/dask/array/core.py in map_blocks(func, name, token, dtype, chunks, drop_axis, new_axis, meta, *args, **kwargs)
    766                     ]
    767                     num_chunks[i] = arg.numblocks
--> 768         out_starts = [cached_cumsum(c, initial_zero=True) for c in out.chunks]
    769
    770         block_info_name = "block-info-" + out.name

~/anaconda3/envs/dask/lib/python3.8/site-packages/dask/dataframe/core.py in __getattr__(self, key)
   3993             return self[key]
   3994         else:
-> 3995             raise AttributeError("'DataFrame' object has no attribute %r" % key)
   3996
   3997     def __dir__(self):

AttributeError: 'DataFrame' object has no attribute 'chunks'

If you take block_info=None out of the function signature, the code above works fine.
Anything else we need to know?:
We run into this error because there is no .chunks attribute with this kind of non-array output. Here is the relevant line of code:
https://github.com/dask/dask/blob/7772ee32352daf800561ac08fc05f4ba1546e88f/dask/array/core.py#L773
Environment:

Dask version: 2021.06.2'
Python version: 3.8
Operating System: Ubuntu 20.04 LTS
Install method (conda, pip, source): conda

Thanks for writing this up @GenevieveBuckley! I didn't know you could create dataframes from array.map_blocks like this. I'll take a look.

Huh. So block_id and block_info both use the output as well as the input and they both assume that the output is a dask.Array. I am wondering if this should be treated as a supported workflow. If not we should raise a warning as soon know that the output is not a dask.Array. If we do want to support it then we should generalize the block_id and block_info logic.
I am leaning towards explicitly forbidding this workflow.

This is right up the alley of something I ran into while working on dask-histogram. In that case, I was looking for a way to have the behavior of map_blocks while returning a custom (histogram) object. To me the map_blocks API is quite rigidly "array in and array out" (with the dtype, chunks, and meta argument docstrings making that pretty explicit). I reached for dask.delayed-- just calling to_delayed on the input array and passing the delayed blocks to another delayed function that returns a histogram object.
what I do:
@delayed
def _delayed_fill(data, axes)
    h = Histogram(axes)
    h.fill(data)
    return h

def fill(data, template):
    array_parts = data.to_delayed()
    axes = *template.axes
    fills = [_delayed_fill(a, axes) for a in array_parts]
    # could also be
    # fills = [_delayed_fill(a, axes) for a  in data.blocks]
    final_result = delayed(sum)(fills)
    return final_result

x = dask_array_factory(...)
h = Histogram(...)
h = fill(x, h)
h.compute()

Would it make sense to provide an API that allows map_blocks like behavior but instead of returning an array, explicitly return a Delayed object? My example above would become:
def fill(data, axes):
    h = Histogram(axes).fill(data)

x = dask_array_factory(...)
h = Histogram(...)
axes = *h.axes
h = x.map_blocks_custom(fill, axes)
h.compute()

At the end of the day this would be syntactic sugar, as explicitly taking advantage of delayed works fine.

A similar conversation has been happening on #4148. I have yet to see a really compelling reason why using delayed (like you are saying Doug) or iterating over the blocks. is not sufficient. But I am totally open to being shown such a reason :)

Yes, iterating over the blocks and using delayed is what I'm using instead.
I'm happy for https://github.com/dask/dask/issues/7921 (this) and https://github.com/dask/dask/issues/4148 to be closed as out of scope. I mostly just wanted to make sure to make a record of what I found (there are discussions elsewhere about why can't we just use $foo instead).
I would be less happy if there was a move to forbid mixed output entirely, particularly after publicizing that you can. (Maybe you hadn't realized I was going to highlight that, which is fine - I also hadn't realized you might want to ban it).

A similar conversation has been happening on #4148. I have yet to see a really compelling reason why using delayed (like you are saying Doug) or iterating over the blocks. is not sufficient. But I am totally open to being shown such a reason :)

@jakirkham might have an opinion here.
(Tagging him in since he mentioned memory issues as a potential problem elsewhere. I don't fully understand that concern though, so it might not be relevant here)

Fair enough. I think for now we can raise an error sooner that is very explicit about block_id and block_info not being supported for this kind of output.


transaction confirmation popup: params--message synchronization

https://github.com/oasisprotocol/oasis-wallet-ext/blob/f912f132cc22bec5d70541ddf46b90d7d28c6c6d/src/background/service/ExtDappService.js#L215
the signature request 'message' is sent over popup url parameters, but the parsed parameters are requested over the message bus, which retrieves it from the top of a queue. how does the extension make sure these stay in sync?
i.e. is there any guarantee that the popup will receive the correct params set corresponding to the message+context by the time it loads and asks the background?
blocks #1

@lvshaoping007 please comment on this, thanks!

i will take look here

reexamining issues I opened. this issue remains


Step 3

Closes #
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

Resolving the issue. Looking into it.


Custom serializer (ConnectionSettingsAwareSerializerBase), StringEnumConverter ignored in some cases

NEST/Elasticsearch.Net: 6.2.0
Elasticsearch version: 6.2.4
Description:
After upgrading to NEST 6.2, the StringEnumConverter setting is ignored for terms searches.
My Custom JSON serializer:
public class CustomJsonNetSerializer : ConnectionSettingsAwareSerializerBase
{
    public CustomJsonNetSerializer(
        IElasticsearchSerializer builtinSerializer,
        IConnectionSettingsValues connectionSettings)
        : base(builtinSerializer, connectionSettings)
    {
    }

    protected override IEnumerable<JsonConverter> CreateJsonConverters() =>
        Enumerable.Empty<JsonConverter>();

    protected override JsonSerializerSettings CreateJsonSerializerSettings() =>
        new JsonSerializerSettings
        {
            NullValueHandling = NullValueHandling.Ignore,
            Converters = new List<JsonConverter> { new StringEnumConverter(true) }
        };

    protected override void ModifyContractResolver(ConnectionSettingsAwareContractResolver resolver) =>
        resolver.NamingStrategy = new CamelCaseNamingStrategy();
}

My ConnectionSettings:
private ElasticClient GetElasticClient()
{
    var uris = _configuration.Urls.Select(x => new Uri($"http://{x.Host}:{x.Port}"));

    var connectionSettings = new ConnectionSettings(
            new StaticConnectionPool(uris),
            (builtin, settings) => new CustomJsonNetSerializer(builtin, settings))
        .DisableDirectStreaming();

    IConnectionSettingsValues s = connectionSettings;
    s.DefaultIndices.Add(typeof(ElasticProperty), _configuration.LiveIndexAlias);
    s.IdProperties.Add(typeof(ElasticProperty), nameof(ElasticProperty.Id));

    return new ElasticClient(connectionSettings);
}

Prior to version 6, I used to filter on an array of values like this:
var filters = filteringHeader.Filter.PropertyTypes?.Where(x => x > 0).ToList();
container &= Query<ElasticProperty>
    .Terms(p => p.Field(f => f.PropertyType)
        .Name(FILTER_BY_PROPERTYTYPE)
        .Terms(filters));

... more filters

return container;

As of version 6, the enum to string conversion is no longer applied for this type of queries, this is what I get (which obviously gives no results):
Valid NEST response built from a successful low level call on POST: /***/elasticproperty/_search?typed_keys=true
# Audit trail of this API call:
 - [1] PingSuccess: Node: http://***:9200/ Took: 00:00:00.0653370
 - [2] HealthyResponse: Node: http://***:9200/ Took: 00:00:00.2185688
# Request:
{ ... "query":{"bool":{"must":[{"terms":{"propertyType":[1],"_name":"FILTER_BY_PROPERTYTYPE"}} ... }
# Response:
...

I had to switch to the following approach:
Expression<Func<ElasticProperty, object>> expression = p => p.PropertyType;
var filters = filteringHeader.Filter.PropertyTypes?.Where(x => x > 0).ToList();
var query = filters.Aggregate<PropertyType, QueryContainer>(null,
    (current, value) => current | new TermQuery { Field = new Field(expression), Value = value });

container &= Query<ElasticProperty>
    .Bool(b => b
        .Should(query)
        .Name(FILTER_BY_PROPERTYTYPE));

In this approach, the enum to string conversion is working again and I get results:
Valid NEST response built from a successful low level call on POST: /***/elasticproperty/_search?typed_keys=true
# Audit trail of this API call:
 - [1] PingSuccess: Node: http://***:9200/ Took: 00:00:00.0363266
 - [2] HealthyResponse: Node: http://***:9200/ Took: 00:00:00.4077386
# Request:
{ ... "query":{"bool":{"must":[{"bool":{"_name":"FILTER_BY_PROPERTYTYPE","should":[{"term":{"propertyType":{"value":"house"}}}]}} ... }
# Response:
...

So was I using the wrong approach, or is this a bug?

Thanks @VanHuychemG sorry for the late reply
Starting with 6.x rather then using the user provided serializer for the whole request and the whole response we only apply it known places where we can expect a user provided value e.g _source in hits. Values in scripts. Query values.
We were missing the terms values as a known user provided value.
Opened https://github.com/elastic/elasticsearch-net/pull/3344 to address this.


WIP: Add authority for instance_aware in 'AuthResponse'

#968 and #969 address this PR. Closing this one.


Added version(commit hash) on  vimrc

As suggested in #249, I introduce version based on hash to make easier to verify errors. When we write a contribution guideline, it should be added.

@avelino ???


Check semi logic for bugs

The final bug that stopped the previous tournament was that the start button softlocked because the interface did not properly realize that the first semi could be started. IIRC this was because the tournament thought it had 3 semis instead of two, which got it confused.
This needs verification and fixing if so. Most of the logic problem is probably in the frontend.
Relates to #146, or is at the very least caused by it.
It's possible that a workaround is to have a FORCE START button that lets the match start regardless of the semi state. Not great, but would have kept the last tournament running.

So, starting a tournament fails the following TestStartingGivesTheRightAmountOfPlayoffs expectation: 15 player tournament had 11 matches, not 4.
So I'm pretty sure that #146 is the root cause of this.


While building LiveKit for visionOS Simulator, no library for this platform was found in WebRTC.xcframework directory.

We want to create a voice call application for the VisionOS simulator; however, it appears that LiveKit lacks support for this platform. During the process of building for the VisionOS simulator, we encountered an issue where no library for this platform was found within the 'artifacts/specs/WebRTC/WebRTC.xcframework' directory. We managed the integration of LiveKit through SPM "client-sdk-swift".
Has anyone successfully compiled LiveKit for the VisionOS simulator?
Thanks in advance

As of now we don't support visionOS but we have plans to support this 😎

Hi, any updates on this? Don't know what it would entail but happy to help if I can.

Support visionOS please

We have use-cases that also require support for VisionOS as well. Primarily for spatial experiences and consuming streams from iOS/Web.

we are working on this folks! will have some news in ~ a month


Problem with DT

After TF2 update I can barely move when DT is enabled :100:

Turn off stop when recharge or whatever the feature is called, it's not working for some players.


Add Cairn gear packages

Add https://cairnrpg.com/cairn-srd/#optional-gear-packages as ItemCairn arrays
to allow for more flexible character generation.

Refactoring Cairn items like armors #88, would allow for us to save Gear packages using something like this:
export const GEAR_PACKAGES = {
    cleric: [
        WEAPONS['War Hammer'],
        ARMORS['Chainmail'],
        ARMORS['Gauntlets'],
        ... createWeapon('Cleansing Blade', 'd6') // can be used for custom non-SRD items, which are not repeated elsewhere
        ... createItem('Holy Symbol (Ward once per day)'),
        ... createItem('Cloak of the Order')
    ]
}

I have a preference for the following:
const createItem = ({ name, description, bulky, stacks }: {
    name: string,
    description?: string,
    bulky?: boolean,
    stacks?: boolean,
}
): ItemCairn => {
    return { name: name, type: 'item', description: description, bulky, stacks: stacks, };
}

This allows createItem({ name: "Dice Set", stacks: true }) instead of createItem("Dice Set", "", false, true).


This line breaks ie supports even if there is babel

https://github.com/d3/d3-force/blob/8c4d113979291aa21a9639263c43aa494a191a94/src/link.js#L55

This line of code should be like below
nodeById = new Map(nodes.map(function(d, i) {
    return [id(d, i, nodes), d];
 })),

Please find another forum to request help with Babel.

There is a working example at https://github.com/Fil/d3-template
Live version https://d3-template.fil.vercel.app/
Tested both with es-check es5 dist/*js and with browserstack against IE9.

There is a working example at https://github.com/Fil/d3-template
Live version https://d3-template.fil.vercel.app/
Tested both with es-check es5 dist/*js and with browserstack against IE9.

Thank you @Fil . We are developing quasar spa vue application in our company. This library is used in Amcharts as a dependency.  By the way, I solved my problem with the quasar.conf.js like below
build: {       transpileDependencies: [         '@amcharts',       ], ... }


script position moved from body to head

The keyword "defer" inside the script element allows us to place it in the head section without encountering issues with the loading of the DOM. Therefore, I changed the position of the script from the bottom of the body to the head.

You have also removed some script in main.js

Just indentation changed, because i pressed ALT + SHFT + F.


Make Aviz into an extension package

Re-configures the Aviz companion package into an extension package (supported by Julia v1.9 and above).
User now only needs to install/"using" required visualization packages (GLMakie, GeoMakie and GraphMakie).
GraphMakie is currently unused but is intended to be used to display connectivity data.
See updated readme for usage examples.

Hi Takuya, just checking I understand this. So now instead of "using Aviz" we use "using GLMakie, GeoMakie, GraphMakie" and the extention will precompile?

Hi Takuya, just checking I understand this. So now instead of "using Aviz" we use "using GLMakie, GeoMakie, GraphMakie" and the extention will precompile?

Yes, that's right.
It means if the user only wants to select intervention locations or run ADRIA-mod, but don't care for any of the analysis/visualization stuff, they don't have to install the Makie ecosystem which is quite big/heavy, and slows ADRIA start times.

Hi Takuya, just checking I understand this. So now instead of "using Aviz" we use "using GLMakie, GeoMakie, GraphMakie" and the extention will precompile?

Yes, that's right.
It means if the user only wants to select intervention locations or run ADRIA-mod, and don't care for any of the analysis/visualization stuff, they don't have to install the Makie ecosystem which is quite big/heavy, and slows ADRIA start times.

Thanks, I'm just running it now to check it out then I'll approve.

Hi Takuya, does Aviz have to be run in a particular place to work? I just precompiled ADRIA, then GLMakie, GeoMakie and GraphMakie and now I'm running parts of the example from the docs in my sandbox folder but I'm getting the error "viz not defined" when I run
ADRIA.viz.scenario(rs, s_tac; axis_opts=Dict(:ylabel => "Example Metric")) for example. Is there another setup step I'm missing?

Hi Rose,

You've checked out the right branch?
You're running Julia v1.9?
You've run instantiate or up for both ADRIA and sandbox environments?

If yes to all three, then it's something else and we'll need to chat online so I can see what's happening.

Hi Rose,

You've checked out the right branch?
You're running Julia v1.9?
You've run instantiate or up for both ADRIA and sandbox environments?

If yes to all three, then it's something else and we'll need to chat online so I can see what's happening.

I did 1. and 2., but I updated my ADRIA and sandbox environments instead of instantiate- I'll do this step now

Hi Rose,

You've checked out the right branch?
You're running Julia v1.9?
You've run instantiate or up for both ADRIA and sandbox environments?

If yes to all three, then it's something else and we'll need to chat online so I can see what's happening.

I just ran instantiate and I'm getting the same. I can do a quick call now or if you're finishing now happy to chat tomorrow.


[WFCORE-4596] Do not acquire the write lock reading core-service patching resource

The read operation should not acquire the write lock, I haven't found a useful use case where this could be necessary. This patch prevents that HAL could get stuck clicking on Patching when there is already a write operation in progress.
Jira issue: https://issues.jboss.org/browse/WFCORE-4596

Minor point about 'protected' aside, LGTM.

@yersan thanks


stacked bar graph does not "stack" all data with same label

Introduction
The stacked bar graph does not handle well same label.
To Reproduce
CREATE TABLE `test` (
  `series` varchar(18) CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci DEFAULT NULL,
  `x`      varchar(4)  CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci DEFAULT NULL,
  `value`  bigint(21)  NOT NULL
) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;

INSERT INTO `test` (`series`, `x`, `value`) VALUES
('1 an <= x', '1/5', 1),
('x < 6 mois', '1/5', 1),
('x < 6 mois', '3/5', 1),
('x < 6 mois', '4/5', 1),
('1 an <= x', '5/5', 9),
('6 mois <= x < 1 an', '5/5', 9),
('x < 6 mois', '5/5', 14);
COMMIT;

select
    'chart'   as component,
    'freq' as title,
    'bar'     as type,
    TRUE      as horizontal,
    TRUE      as stacked,
    TRUE      as labels,
    true as toolbar,
    'pink'    as color,
    'azure'   as color,
    'lime'    as color;

select * from test;

Actual behavior
The three "5/5" (three values: 9, 9, 14) are not represented on the same line.
Screenshots

Version information

OS: Xubuntu
Database: MariaDB 10.3
SQLPage Version: 0.31

Thanks for the report ! The fix will be in 0.32 :)


Delete untracked resources of manifest work

/assign @deads2k

/assign @pmorie

/assign @qiujian16

solid idea, but I think needs some updates.
/approve
/assign @qiujian16
@qiujian16 owns lgtm

/lgtm


/api/github-webhook-pullrequest failing to process request

GitHub Error:
  Message: Invalid request.

Only 65535 characters are allowed; 74057 were supplied.

#0      GitHub.handleStatusCode (package:github/src/common/github.dart:429:9)
#1      GitHub.request (package:github/src/common/github.dart:372:7)
<asynchronous suspension>
#2      GitHub.requestJson (package:github/src/common/github.dart:268:22)
<asynchronous suspension>
#3      GithubChecksUtil.updateCheckRun.<anonymous closure> (package:cocoon_service/src/foundation/github_checks_util.dart:63:7)
<asynchronous suspension>
#4      RetryOptions.retry (package:retry/retry.dart:131:16)
<asynchronous suspension>
#5      Scheduler.triggerPresubmitTargets (package:cocoon_service/src/service/scheduler.dart:377:7)
<asynchronous suspension>
#6      GithubWebhook._scheduleIfMergeable (package:cocoon_service/src/request_handlers/github_webhook.dart:162:5)
<asynchronous suspension>
#7      GithubWebhook._handlePullRequest (package:cocoon_service/src/request_handlers/github_webhook.dart:117:9)
<asynchronous suspension>
#8      GithubWebhook.post (package:cocoon_service/src/request_handlers/github_webhook.dart:62:11)
<asynchronous suspension>
#9      RequestHandler.service.<anonymous closure> (package:cocoon_service/src/request_handling/request_handler.dart:49:22)
<asynchronous suspension>
#10     main.<anonymous closure>.<anonymous closure> (file:///app/bin/server.dart:254:9)
<asynchronous suspension>

@CaseyHillers did you get a chance to triage this issue?

I haven't looked at this. Should this be in the ticket queue?

It would be useful to get it triaged when the context is fresh. Most likely it will require batch processing using cloud functions or similar. Once it is triaged we can move it out of the queue.

\cc @keyonghan can you please update this bug with the triage data

Most likely this is due to summary consolidation of all sub tests (triggered from the builder itself) exceeding the limit.
See also: https://github.com/flutter/flutter/issues/90224


Fix Scroll bar issues and implement design without scroll bars

Parent Issue: https://github.com/fossasia/open-event-webapp/issues/515#issuecomment-234709757
In the below screenshot you can see 4 scroll bars. There should only be one scroll bar, the one to scroll from top to down.

[x] Ensure no scroll bars in the scroll over content
[x] Ensure the page does not scroll from left to right
[ ] Ensure all is working well on mobile screens

@mariobehling  This will be solved after merging  #529 Please check


Test Case 10 : Application Scaler fails due to missing secrets

Issue:
After setting up the demo environment with the scripts, the Application Scaler cron job is tested with command:
kubectl create job --from=cronjob/application-scaler manuallytriggered -n application-beta
However it fails with this error:
MountVolume.SetUp failed for volume "tokendata" : secret "prometheus-token-secret" not found.
It seems the script did not setup the secret described in the documentation linked below.
FYI, the associated secret prometheus-cert-secret was created successfully.
Link to the documentation:
https://github.com/IBM/operator-sample-go/blob/main/documentation/AppSetupWithOLM.md

Which name must the  prometheus-token-secret exist? @deleeuwblue
Code to create the secret in the script automation:
https://github.com/IBM/operator-sample-go/blob/main/scripts/ci-create-operator-application-openshift.sh#L34

@deleeuwblue the automation is updated in that commit: https://github.com/IBM/operator-sample-go/commit/b7b1fa29443f0e4fd2419d9f17d5687e558e9146 when you updated the manual documentation we can close that issue.

@thomassuedbroecker I have updated the manual documentation, so I'm closing this issue.

I tested again, the secret prometheus-token-secret was still created in namespace openshift-operators instead of application-beta.  This is because you fixed the problem in ci script, but not demo script. @thomassuedbroecker

You are right. I fixed it in this commit: https://github.com/IBM/operator-sample-go/commit/2d7115412ce2967799e23bcd16d1d0e6915b5a6b

Completed Test case 10


Graph construction during DVC repro --single-item

With large project graphs, the dvc repro --single-item file.dvc command spends a very long time (minutes) on constructing the graph before running the command.
Do we need to construct the whole graph in single mode?

Hi @prihoda !
Indeed, there seems to be no need in constructiong graph before running this command. Though, the delay is mostly caused by the inefficiency of graph construction and related to #711 . I will look into solving this today.
Thanks,
Ruslan


Ollie: Watch qualitycryptominers.com

Ollie requests the watch of the watch_keyword qualitycryptominers\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

qualitycryptominers\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by tripleee in Charcoal HQ


LOOP AT need support for FROM and TO

This should produce 345:
DATA num_table TYPE STANDARD TABLE OF i.
DATA num TYPE i.

DO 10 TIMES.
  APPEND sy-index TO num_table.
ENDDO.

LOOP AT num_table INTO num FROM 3 TO 5.
  WRITE  num.
ENDLOOP.

Closed by #260


document or remove insecureAcceptAnything sources in policy.json

           "": [
                {
                    "type": "insecureAcceptAnything"
                }
            ]
        },
        "docker-daemon": {
            "": [
                {
                    "type": "insecureAcceptAnything"
                }
            ]
        },
        "atomic": {
            "": [
                {
                    "type": "insecureAcceptAnything"
                }
            ]
        },
        "containers-storage": {
            "": [
                {
                    "type": "insecureAcceptAnything"
                }
            ]
        },
        "dir": {
            "": [
                {
                    "type": "insecureAcceptAnything"
                }
            ]
        },
        "oci": {
            "": [
                {
                    "type": "insecureAcceptAnything"
                }
            ]
        },
        "oci-archive": {
            "": [
                {
                    "type": "insecureAcceptAnything"
                }
            ]
        },
        "docker-archive": {
            "": [
                {
                    "type": "insecureAcceptAnything"
                }
            ]
        },
        "tarball": {
            "": [
                {
                    "type": "insecureAcceptAnything"
                }
            ]
        }

It's not clear what purpose these serve if any. If they do serve a purpose, they should be documented. If they don't, they should be removed.

I am almost certain that those are there, because something was broken if they aren't. However, I am no expert on policy.json, so @gerblesh should take a look at this.

mainly comes from upstream uBlue to not break compatibility with unsigned images or images that can't be verified, it has led to some unwanted behavior when leaving a lot of it to "reject" from users, which is why presumably it has been configured this way. While this definitely isn't the best, I don't want to change anything in fear of breaking someone's containers. I'd take this up with upstream uBlue and ask around.


"VsTest task failed" with no additional info or errors

Required Information
Type: Bug
Task: Visual Studio Test
Environment
Private Agent on Windows 10, version 2.181.0
Issue Description
Our Visual Studio Test task is failing in or YAML build on only one of our agents sometimes.

We started experiencing the issue around the 27th. It was happening about 1 in 5-7 times. On the 28th I deleted the work folders and the _temp and _tasks cache folders. It then worked for a while (15ish hour period with around 20 builds) with no issues. But then on the 29th it started happening again (2 out of the last 3)
Task logs
Starting: Run parallel tests
==============================================================================
Task         : Visual Studio Test
Description  : Run unit and functional tests (Selenium, Appium, Coded UI test, etc.) using the Visual Studio Test (VsTest) runner. Test frameworks that have a Visual Studio test adapter such as MsTest, xUnit, NUnit, Chutzpah (for JavaScript tests using QUnit, Mocha and Jasmine), etc. can be run. Tests can be distributed on multiple agents using this task (version 2).
Version      : 2.170.1
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/test/vstest
==============================================================================
SystemVssConnection exists true
SystemVssConnection exists true
Running tests using vstest.console.exe runner.
======================================================
Test selector : Test assemblies
Test filter criteria : null
Search folder : C:\A\Default\w\2181\s\Output\Debug
Action when minimum tests threshold not met : fail
Minimum tests expected to be run: 10
VisualStudio version selected for test execution : latest
Attempting to find vstest.console from a visual studio installation with version [16.0,17.0).
Run settings file : C:\A\Default\w\2181\s\TestRunConfigurationInParallel.runsettings
Run in parallel : false
Run in isolation : false
Path to custom adapters : null
Other console options : --blame
Code coverage enabled : false
Diagnostics enabled : false
SystemVssConnection exists true
Run the tests locally using vstest.console.exe
========================================================
Source filter: **\*vision*.dll,**\*expenses*.dll,**\*financial*.dll,**\*general*.dll,**\*inventory*.dll,**\*labor*.dll,**\*sales*.dll,!**\*general_*.dll,!**\General.Demo.dll,!**\General.Reporting.Communications.dll,**\model.dll,!**\Common\model.dll,!publish\**,!**\ref\**,!**\win-x86\**,!**\*microsoft*,!**\testhost*
======================================================
##[error]VsTest task failed.
Finishing: Run parallel tests

I am enabling debug logs and will update when I get another failure with that enabled.
Error logs
##[error]VsTest task failed.

@damccorm we're getting this very frequently now. Here are the debug logs for the step:
vstest.txt

We again deleted the _temp, _tasks, and additionally this time the _tools directories and it worked for about a week, but the issue came up again. I'm uninstalling and deleting the agent and reinstalling to see if that makes any difference.

It seems like an issue with the environment.

Please check agent diagnostic logs (which can be enabled from the UI) to see if the azure pipeline agent is giving some error.
Can you please check if publish test results task is running fine?
Also, please check if it's running on the hosted agents?

We haven't gotten this in a long time, so it seems the uninstall and reinstall of the agent fixed the issue.

I guess there was some miscommunication regarding my asks. I meant to check 'Agent Diagnostics logs'. The tagged logs are for vstest task logs. And in the third point, I meant for you to validate if the issue goes away if you switch to hosted agents.
But good to know that the issue is now fixed.

Well, it happened again today. Same machine. Same issue. I'll uninstall and reinstall again so it doesn't happen, but it seems like there is still an issue here...

@ankit-arora12, can this be reopened?

Can you please try if the issue goes away when you switch to the hosted agent?

We cannot run this build on a hosted agent

Since these are private agents, we need some help from you to debug the issue better. Can you please add console.log around a js file mentioned below and rerun the pipeline and share the debug logs with us?
Lines where these logs need to be added:

https://github.com/microsoft/azure-pipelines-tasks/blob/acc64cc7292c98597908325e53af9f898a896189/Tasks/VsTestV2/nondistributedtest.ts#L92
https://github.com/microsoft/azure-pipelines-tasks/blob/acc64cc7292c98597908325e53af9f898a896189/Tasks/VsTestV2/nondistributedtest.ts#L95

These lines are part of file nondistributedtest.js which can be found in the agent directory of vstest task.


UI Regression on searching

We just upgraded to 2.22.3, and it looks like there's a bug/regression in the UI. It used to be that when you clicked any of the sidebar links (All, Running, Completed, etc). It would issue a "search" automatically and populate the table.
However, it appears that the auto-Search of whatever item you select on the sidebar doesn't kick off a search. You now have to click the actual "Search" button to search.

Can reproduce. Browser console shows errors as well.

@ml- what are the JS errors you see? I see Warnings, but I don't see errors necessarily.

@demichej Sorry, I'm at home now and post the errors (or warnings?) monday the earliest. Or maybe I can so a quick build locally, we'll see.
Will make sure I don't forget this!

You're right @demichej, those messages are Warnings:
Warning: Failed propType: Invalid prop `allowNew` of type `string` supplied to `Typeahead`, expected `boolean`. Check the render method of `OnClickOutside(Typeahead)`. app.js:7:4674
Warning: Failed propType: Invalid prop `search.version` of type `array` supplied to `t`, expected `string`. Check the render method of `Connect(t)`. app.js:7:4674

Right, but those are just warning @ml-
I haven't had a chance to debug locally, but would to try and figure out a fix :)

@ml- Looks like this commit made that change:
https://github.com/Netflix/conductor/commit/2cf4f0413f452e4f9549726a3571c336bec83ee5#diff-03e4bf1f523c6bb8e97e4eef067cce3f
I'll reach out to @mstier-nflx to see if we can either revert it, or get a fix in so that we fetch.

@ml- made a PR for this:
https://github.com/Netflix/conductor/pull/1447

@demichej Cool, thanks. Will check out later. Hope it gets merged

Sorry, my previous PR was in a bad state. This is the right PR now: https://github.com/Netflix/conductor/pull/1451

@demichej @ml- Thank you for reporting the issue. We will review the PRs and merge these soon.
@mstier-nflx for visibility.


OpenGL / SDL support on Windows

Currently there's no support for OpenGL on Windows, mostly because of difficulties with building SDL on Windows. Inanity has special support for OpenGL on Windows without SDL, maybe should do the same here.

Implemented OpenGL support for Windows without SDL since dee6e479cae7d206296abb2ff28fc163a1f11e50.


listener: fix ipv6 error

Signed-off-by: Rama<EMAIL_ADDRESS>Description:
Fixes the bug https://github.com/envoyproxy/envoy/issues/3911
Risk Level: Low
Testing: Automated
Docs Changes: N/A
Release Notes: N/A
Fixes #3911

@PiotrSikora I am not 100% sure if this is the right fix because I am fully familiar with this part. PTAL and suggest. I can change based on your feedback.

@ggreenway Thanks. I was thinking about such a test and checked to see if we can write a mock but looks like for functions like this writing mock is not possible with gmocks. If there is any possible way to do it, do let me know. I will look in to it.

@ramaraochavali The way to mock this is to add socket() to OsSysCalls (see envoy/include/envoy/api/os_sys_calls.h). Then use OsSysCalls::socket() in ipFamilySupported(). You can then mock the behavior of ::socket().


How can i input Chinese

when i get a input element, i have tried many ways to input Chinese, but i found that result is only can input the first character repeat, i dont know winappdriver if support input Chinese.

I don't think it is supported yet; we use something like this:
https://github.com/charygao/MouseKeyboardLibrary/

@Cmelon9 You can try to use copy-paste https://github.com/microsoft/WinAppDriver/issues/1194#issuecomment-643433910

I use webelement.sendKeys(“中文”)  to input Chinese, and it works very well.
The language of my test scripts is java.

I use webelement.sendKeys(“中文”) to input Chinese, and it works very well.
The language of my test scripts is java.

i have tried this way, but result is just like i say in question only can input the first character repeat..
For example, i use element.sendKeys("中文名"). but input result is "中中中"

You must change your input method's  state to english before you run the scripts.

You must change your input method's state to english before you run the scripts.

i have tried change my input method, but input result is same...confused...


Only subclasses

Closes #190

[x] Make Function, SingleValue, and Macro abstract
[x] Update docstrings
[x] Update tests
[ ] Update README
[ ] Update notebooks

Per the discussion in #190, let's better do this by modifying __new__


tour: cannot allocate memory

Context: https://tour.golang.org/concurrency/4
In this slide I expected the code sample to work right unmodified, but I got a "cannot allocate memory" error.

It seems a duplicate of https://github.com/golang/tour/issues/512

Closing as a dup of  #541


Make options reloadable

API changes
IReloadOptions NEW
public interface IReloadOptionsManager
{
    IChangeToken GetReloadToken<TOptions>();
    void Reload<TOptions>();
}

IReloadableOptions NEW
public interface IReloadableOptions<T>
{
    T Value { get; }
    IDisposable Subscribe(Action<T> value);
}

Design Summary
With this approach, there's a new type for consumers of options which want the ability to see updates that occur after
application startup.
Consumers can DI the IReloadableOptions<T> and see updates according to three supported patterns:
1.) Get the current value when the component was created (useful for scoped and transient business objects who don't want
to deal with concurrency issues).
public class HomeController
{
    private AppSettings _settings;

    public HomeController(IReloadableOptions<AppSettings> options)
    {
        _settings = options.Value;
    }

    private bool PriceOfGas => _settings.PriceOfGas;
}

This differs from the normal IOptions<T> behavior. Value can change after it is first accessed.
2.) Get the current value each time .Value is called. Useful when you want realtime updates, but don't have a complicated
set of concurrency behaviors to deal with.
public class HomeController
{
    private IReloadableOptions<AppSettings> _options;

    public HomeController(IReloadableOptions<AppSettings> options)
    {
        _options = options;
    }

    private bool PriceOfGas => _options.Value.PriceOfGas;
}

3.) Be notified when the value changes. Useful for long-lived components that was to recompute data when options change.
public class ProductPriceService : IDisposable
{
    private AppSettings _settings;
    private IDisposable _subscription;

    public ProductPriceService(IReloadableOptions<AppSettings> options)
    {
        _subscription = options.Subscribe(s => _settings = s);
    }

    private bool PriceOfGas => _settings.PriceOfGas;

    public void Dispose()
    {
        _subscription?.Dispose();
    }
}

When using this pattern you WILL LEAK if you don't unregister your callback. The callback is called immediately and
the surrounding object needs to be prepared to deal with that case.

ec13249a35bbf1d4a8a381a9697965cc1208fe82


create databases error.

hi.
i should create a database.
but occurred error it.
"ERR: error parsing query: found -, expected SELECT, DELETE, SHOW, CREATE, DROP, GRANT, REVOKE, ALTER, SET at line 1, char 25"
create a database to can't use "-"?
help me.

Use double quotes.
> create database db-with-dashes
ERR: error parsing query: found -, expected ; at line 1, char 19
> create database "db-with-dashes"
> show databases
name: databases
---------------
name
_internal
db-with-dashes


Share button should enabled

Idea Description
Currently share button is not working.
Please enable share function.
Reference images and links

@takahirom
This issue is now blocked, but when it opens, I will try it 🙏
Is it possible ??

@matsuurayuki1219 It is ok! I assigned you!

@takahirom
Thank you !!
When you remove the blocked label from this issue  please tell me, and I will fix it 👍

@matsuurayuki1219 The web page is out. We can move on this issue!

@matsuurayuki1219 @takahirom
If it seems difficult to complete the task, I would like to receive this task myself.🙋

If @matsuurayuki1219 doesn't respond by noon, please go ahead 🙏

@Corvus400
You may take this issue instead of me.

@matsuurayuki1219 @takahirom
Understood!
I'll do it instead!💪

Thanks!


CreateToken does not accept nil value for expiration

The CreateToken function should accept nil as a value for token expiration. The expire value is a time.Time type and it cannot be set to nil.
Also, the documentation on the site it wrong. It shows: token := client.CreateToken("john", null) which is a copy error as null isn't valid Go code.

@lukef zero time is fine, and it will be treated as nil (no expire). For backward compatibility, better to keep it as now.
Regarding doc, you're right. Updated. Thanks for catching.


Implementing API data caching

Hi guys,
What would be the best way to handle caching the results of my API calls? I've been playing with the ApiClient.js file (in src/helpers) and tried to replace superagent with superagent-cache, but as far as I can tell it has compatibility issue (see the issue I opened there https://github.com/jpodwys/superagent-cache/issues/21 ).
Has anybody successfully implemented caching with this boilerplate?

Hi,
we've implemented api cache using memory-cache and writing simple cachedRequest function that we used in api/actions (see below). It is very simple one, it is set to 60 seconds as you can see, in other part of app we have also webhook to invalidate this cache so we could probably switch it to more than 60 sec. We've also implemented cache for html itself if you're intrested i can also post that. in normall production world you would use some reverseproxy anyway
import request from 'request';
import config from '../../src/config.js';
import cache from 'memory-cache';

export default function cachedRequest(url) {
  return new Promise((resolve, reject) => {
    let cachedResponse = cache.get(url);

    if (cachedResponse) {
      resolve(cachedResponse);
    } else {
      request({
        url: url,
        json: true,
      }, (error, response, body) => {
        if (error) {
          reject(error);
        }
        else if (response.statusCode !== 200) {
          reject ({'statusCode': response.statusCode});
        }
        else {
          cache.put(url, body, 60*1000);
          resolve(body);
        }
      });
    }

  });
}

and somewhere in api/actions just use like this
export default function list(req, params) {
  return cachedRequest(`http://${config.dbHost}/banners/${params[0]}`);
}

@isilweo thanks! If I understand correctly caching is implemented for use with the custom api server in /api. What would have to change to make it work with an external API ? I followed these steps to set-up mine https://github.com/erikras/react-redux-universal-hot-example/blob/master/docs/ApiConfig.md
For now I've tried adding it to src/helpers/ApiClient.js but can't wrap my head around it.

As i understand this project correctly you should always use /api proxy and then download data from external api using actions in api/actions. So it works like this

use redux action to ask for data from api - example here https://github.com/erikras/react-redux-universal-hot-example/blob/master/src/redux/modules/info.js#L42
[few things happen here]
it goes to [api/actions/loadInfo.js] (https://github.com/erikras/react-redux-universal-hot-example/blob/master/api/actions/loadInfo.js)
So in here instead

export default function loadInfo() {
  return new Promise((resolve) => {
    resolve({
      message: 'This came from the api server',
      time: Date.now()
    });
  });
}

you should do something like
import cachedRequest from '../../utils/cachedRequest';

export default function list(req, params) {
  return cachedRequest(`http://somehost.com/api/info`);
}

you can also change somehost.com to your own config var and put it into src/config.js

@dagobertrenouf i think there are two places that make good candidates for caching:

ApiClient
something to do with your proxy
the /api route

Of those, I think the last is the best if you are not doing server side rendering. You have to setup a cache here: https://github.com/erikras/react-redux-universal-hot-example/blob/master/src/server.js#L38 where your code would either call from cache or resort to using the proxy to call API, put into cache and return results.
If you are using server-side rendering, you may find libraries out there to help with caching and proxy, hence why point 2. You can have callbacks on the proxy cycle, see: https://github.com/nodejitsu/node-http-proxy#listening-for-proxy-events
You may find ways to cache the superagent call but I don't recommend it as it would act differently on the server and the client (at least I believe so) and caching on the proxy level makes more sense.
At my current job we have this very challenge too and what I am recommending is using a layer between the frontend app and the api app, something like varnish. I don't want my frontend, although it's based on nodejs express server, to handle writing and loading from cache.

@isilweo I don't think you understand the purpose of the /api folder. It represents a demo source of API data, but it has nothing to do with the proxy. The proxy is created in a couple of lines in src/server.js. They have the same name but they work independently. As a proof of that, I keep making proxied api calls (to my own api) and I have deleted the whole /api folder for a long time!
@mmahalwy Thanks for taking the time. My goal is really server side rendering. I agree that having an intermediate layer would be ideal, however I don't have the chops to do it, so I'm resorting to the nasty approach.
I've used a modified version of superagent-cache, it works very well to accomplish my goal of loading the site extremely fast, as it doesn't need to make any API round-trip call except for the first time. For the needs of a static website (with wordpress cms to power the api) it's very good. I get all the react goodness + insane speed + seo ability + content management system :)
However I might have a bit of a challenge ahead when I need to add pagination, I will see how it goes and keep you posted.

Awesome! Looking forward to it @dagobertrenouf


Use custom exception instead of InvalidArgumentException

The current parsing of UUID is throwing an InvalidArgumentException, that is too generic IMHO.
See StringCodec.
Since I'm using UUIDs in web application URLs, I can't be sure that I'll get valid ones. So, when I transform the  UUID string I'm getting from URL into an UUID object, by calling Uuid::fromString(), I'd like to get a possible specific exception, something like InvalidUuidException.
This change should cause no BC break, if InvalidUuidException extends  extend InvalidArgumentException

This sounds good to me. Would you like to open a PR to get the commit credit for it? Otherwise, I don't mind doing the work.

Of course, I'll do it tomorrow

Great. I look forward for a tag. Thanks.

Thanks for the reminder. Just tagged 3.6.0. :smile:


User Popover doesn't closes on clicking again on chevron.

Current behavior-
Once we open the user popover, clicking again on chevron doesn't closes it.

Expected behavior-
Popover should close after opening the popover by clicking again on chevron.

Seems worth changing.

@zulipbot claim


Quick scan blocks

Currently, jumping out of blocks requires linear scanning the opcodes until it finds the corresponding target, then unwinding the stack based on the scan. Obviously this is really slow.
Idea 1:

Each break saves the target block + stack unwind.
What do we do about br_table?

Idea 2:

Each instruction saves the inner most block + stack unwind if we break here.
Blocks will do the same.
Breaking outside of the current block becomes a linked list traversal.

Idea 3: Separate data structure:
const Lookup = struct { func: u32, instr: u32 };
_jumps: HashMap(Lookup, struct {
    has_return: bool,
    stack_unroll: u32,
    targets: [*]u32, // length matches args
});

General breaks can use jump(0) while br_table else uses arg.data[idx].
Instructions that should have a corresponding jump:

br
br_if
br_table — uses arg indexing
if — jumps to else
else — behaves like a break (jumps to end)

Hey this is done! https://github.com/fengb/wazm/blob/master/src/module/post_process.zig#L107


fix: bump collect-data image for bug fix

Bump the image used in the collect-data task to get a bug fix in the merge-json script. Also removes all references to extraData in the task and replaces it with data to align with recent API changes.

@johnbieren can you link to the PR with the bugfix in the description please?

@johnbieren can you link to the PR with the bugfix in the description please?

done


.explore(), .annotate(), .evaluate(...).explore() all flush some debug output to the console

macOS 10.14
Python 3.6
Here is the debug output:
<CFBasicHash 0x7fca61c5be60 [0x7fff863d67c0]>{type = mutable dict, count = 6,
entries =>
	0 : <CFString 0x7fff8657c318 [0x7fff863d67c0]>{contents = "software_renderer"} = <CFBoolean 0x7fff863d6e90 [0x7fff863d67c0]>{value = false}
	2 : <CFString 0x7fff8988e100 [0x7fff863d67c0]>{contents = "CoreUI"} = <CFBoolean 0x7fff863d6e80 [0x7fff863d67c0]>{value = true}
	3 : <CFString 0x7fff8657c2d8 [0x7fff863d67c0]>{contents = "working_color_space"} = <CGColorSpace 0x7fca64200d80> (kCGColorSpaceICCBased; kCGColorSpaceModelRGB; sRGB IEC61966-2.1)
	4 : <CFString 0x7fff8657c2b8 [0x7fff863d67c0]>{contents = "output_color_space"} = <CGColorSpace 0x7fca64200d80> (kCGColorSpaceICCBased; kCGColorSpaceModelRGB; sRGB IEC61966-2.1)
	5 : <CFString 0x7fff8657c2f8 [0x7fff863d67c0]>{contents = "working_format"} = <CFNumber 0x975fe399ce159519 [0x7fff863d67c0]>{value = +22, type = kCFNumberSInt32Type}
	6 : <CFString 0x7fff8988e120 [0x7fff863d67c0]>{contents = "kCIContextAllowLowPower"} = <CFBoolean 0x7fff863d6e80 [0x7fff863d67c0]>{value = true}
}

I'm guessing this is a stray NSLog somewhere.

Cannot reproduce.


CONTOUR crashes if too many levels specified

Reported by Ansley B Manke on 27 Feb 2002 19:02 UTC
Under Solaris, segfault; Under linux, does not plot any contours,
and subsequent CONTOUR commands plot no contours.
yes? use coads_climatology
yes? contour/l=1/lev=.01dc sst  !v5.22 gives segfault for this
yes? contour/l=1 sst            !blank
Note: in subroutine plotz, a loop fills arrays ZLEV, etc, which
are dimensioned 1:500.   So need a warning if more levels than
500 ar requested.
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/364

Comment by<EMAIL_ADDRESS>on 21 Oct 2003 20:15 UTC
Moving from the<EMAIL_ADDRESS>user to the<EMAIL_ADDRESS>user.


How to do join with multiple entity from streams with speedment

You can do joins using the stream function .flatMap() . We are working on an improved way of join:ing in version 3.0.0 that should be released real soon.

Read more on how to do this here:
https://github.com/speedment/speedment#join


Unpick doesn't transform 0 constants in some cases

Say there is a use case of an unpick:
private static final int SOME_VALUE = 0;

public void user() {
  call(0);
}

public void call(int value) {
  if (value == 0) { /* do stuff */ }
}

If it's unpicked, unpick will only replace the 0 in the user(); it won't replace that in call(int)'s value == 0 check.
Screenshot:

@modmuss50 If you don't mind, consider allowing issues on unpick (and cfr) so we can track these bugs better.

I’ve enabled issues on unpick


make mlag Dual Primary Detection disabled by default

Change Summary

this PR makes mlag Dual Primary Detection disabled by default
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes)
[ ] Documentation content changes
[x] Other (please describe):

Related Issue(s)

#601
Component(s) name
Proposed changes

mlag Dual Primary Detection was enabled by default (when mlag was enabled).
this PR makes mlag Dual Primary Detection disabled by default (for L2 leaf and L3 leaf)

How to test

configure mlag_dual_primary_detection: true l3leaf.defaults or  l3leaf.node_groups. or l2leaf.defaults or  l2leaf.node_groups.
run eos_l3ls_evpn role
check intended structured_config and verify there is this for the appropriate devices

  peer_address_heartbeat:
    peer_ip: <IP_ADDRESS>
    vrf: MGMT
  dual_primary_detection_delay: 5

then, dont configure mlag_dual_primary_detection
run eos_l3ls_evpn role
check intended structured_config and verify there is no

  peer_address_heartbeat:
    peer_ip: <IP_ADDRESS>
    vrf: MGMT
  dual_primary_detection_delay: 5

Checklist:

[x] My code has been rebased from devel before I start
[x] I have read the CONTRIBUTING document.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[ ] I have updated molecule CI testing accordingly
[ ] All new and existing tests passed (pre-commit, make linting and make sanity-lint).

Done (CI updated).

Done (CI updated).


Cannot upload to CWS 400 Bad Request

Hi!
We've been using chrome-webstore-upload to upload our chrome extension for a while now and recently have consistently been getting a 400 Bad Request error for about 1.5 weeks whenever we tried to upload the extension. Initially we thought it was a transient error but it has yet to be resolved. Manually uploading the extension package has been successful.
I tried to log out the error stack to have more context, unfortunately, all it says is Bad Request without any further helpful information.
Here is the error from our GitHub Actions deployment pipeline:
HTTPError: Response code 400 (Bad Request)
    at Request.<anonymous> (/home/debian/actions-runner/_work/castify/castify/node_modules/got/dist/source/as-promise/index.js:118:42)
    at processTicksAndRejections (internal/process/task_queues.js:[95](https://github.com/screencastify/castify/actions/runs/8298882997/job/22713298715#step:6:96):5) {
  code: 'ERR_NON_2XX_3XX_RESPONSE',
  timings: {
    start:<PHONE_NUMBER>120,
    socket:<PHONE_NUMBER>124,
    lookup:<PHONE_NUMBER>157,
    connect:<PHONE_NUMBER>159,
    secureConnect:<PHONE_NUMBER>164,
    upload:<PHONE_NUMBER>164,
    response:<PHONE_NUMBER>233,
    end: 17[105](https://github.com/screencastify/castify/actions/runs/8298882997/job/22713298715#step:6:106)18525235,
    error: undefined,
    abort: undefined,
    phases: {
      wait: 4,
      dns: 33,
      tcp: 2,
      tls: 5,
      request: 0,
      firstByte: 69,
      download: 2,
      total: [115](https://github.com/screencastify/castify/actions/runs/8298882997/job/22713298715#step:6:116)
    }
  }
}

And here is the code snippet of the deploy script:
  const cws = await getCwsClient(secrets, extensionId);
  // Generate zip on the fly from dist/ folder
  const zipStream = new PassThrough();
  const zipPromise = generateZip(
    { forCws: true, env: args.env as TEnvironment },
    zipStream,
  );
  const uploadResponse = await cws.uploadExisting(zipStream);

I double checked the OAuth client secret, it's in good standing and we've been using it for 3 years without an issue. It happens both locally on my machine and the GitHub Actions pipeline.
Other triagings I've tried including trying a different zipStream by zipping the extension first and converting to a read stream using fs.createReadStrem(<PATH_TO_ZIP>) as instructed on the README since 400 Bad Request usually means the client data is no good, but resulting a 400 Bad Request as well; and updating the chrome-webstore-upload version (Unfortunately, this is deploying some legacy code so we can't go beyond 0.5.0).
Please let me know if you've had other users reporting this issues lately. We have not changed the deploy script for quite some time but we did update the extension itself and we are looking to deploy it.
The other possibility is the Google cws API endpoint has changed the way it processes data. I have not looked into it yet and successfully manually uploading the package on the Chrome Web Store told me it's not our zip file or the extension itself that has the problem. Please advise, thank you very much!

Please update the version you're using. This package hasn't used got in a while.

You can save the artifact in a job and then run the latest version of chrome-webstore-upload-cli. Your app's node version does not have to match the node version you use to deploy.
You can refer to the readme of the CLI project for the suggested workflow. In my projects, I build once and then in a separate matrix job I publish to two stores.

Thank you! I tested with Axios and the 400 errored at fetch token. Our secret credentials for some reason are no longer good. So it's not because of the lib got. Now the upload results a 403, even though access tokens are successfully generated with the correct scope, still not resolved but it's progress.


Improve auto selection rules

We should give preference for interpreters inside the workspace when auto selecting. If there isn't any, we should be auto selecting the most up to date global interpreter.

Done :)


⚠ Avatar API Endpoint has degraded performance

In ceb2e6c, Avatar API Endpoint (https://avatar.roblox.com/v1/avatar-rules) experienced degraded performance:

HTTP code: 200
Response time: 5687 ms

Resolved: Avatar API Endpoint performance has improved in ec268ce after 9 minutes.


Fix memory management of nodes

Fix #38.

Codecov Report

Merging #39 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   98.02%   98.03%   +<.01%
==========================================
  Files           7        7
  Lines         659      660       +1
==========================================
+ Hits          646      647       +1
  Misses         13       13

Impacted Files
Coverage Δ

src/node.jl
98.9% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4378f6...a5064a6. Read the comment docs.


configure email sending for devise

Need to be able to send registration, forgotten password emails from the service.
Might be best to use Mandril (12k free emails per month) which is a Heroku add-on

I did not get a registration email having re-registered

Password re-set request works but just need the 'welcome' email

The application isn't configured to sent a welcome email. Some questions:

Do we want users to have to confirm their accounts? In which case I can activate this and include a suitable welcome message?
What do you want in the welcome email?
Or did you want confirmation AND a welcome message?


Shortcuts in Startmenu / Desktop

Maybe just a question: I run a Win Server 2016 with docker for a development team. Now when I deploy a new Container the very convenient shortcuts are generated in the user context, so nobody else sees them.
Is there a way to have the shortcuts generated for all users instead?

Today this is not possible, you can only do Desktop, Startmenu or none.
I guess it would be easy to include CommonStartMenu in the enum.

That would be cool

This will be included in the next version of navcontainerhelper.

Version <IP_ADDRESS> has been released


Confused on extracting xbl from samsung

(I don't know where to ask about the tutorial about porting edk2 to SM8150 in the website, so I asked here.)
I extracted the xbl from the BL....md5 file from the Samsung firmware, but opening it in 7-zip resulted in an error
So, I am going to extract xbl from the device, but I don't know which xbl I get:
/dev/block/by-name/xbl
/dev/block/platform/soc/......ufshc/by-name/xbl
(I found the xbl paths by running find / | grep xbl and seeing the last few lines.)
Can someone please answer this question? thanks.

These two paths are the same thing, as they are linked to the same block device.

You don't really have to "open" it.
Open just 7zip from "start" panel. The go to path with file and when follow instruction - click "open #" over it