Decoder input

Hi, I am not sure if you are feeding the right input to the decoder.
(pg. 2) "Given z, the decoder then generates an output sequence (y1, ..., ym) of symbols one element at a time. At each step the model is auto-regressive, consuming the previously generated symbols as additional input when generating the next."
I believe your decoder input is a batch of target sequences.

Hi @mun94 ,
I think it is not clear that this paragraph is talking about training phase or inference phase.
Therefore, I follow the classic Recurrent Sequence to Sequence training style.
The method of feeding the target sequence into the decoder during training phase is called "teacher forcing", which can make the model converge faster.
Training with the last output from decoder may also works well, but may take longer time to train.
In the inference phase, I use the last output from the decoder as its next input.
However, I may be wrong.
If you found out that the authors do train without teacher forcing, please let me know.
Thank you!
Yu-Hsiang

Yeah it was not clear to be as well, but when I looked at their tensorflow implementation, I realized that their decoder works like word-based RNN. They feed back the output word token and append the output word token to the encoder input at each time with the shift.
For example, the input at the very first input looks like yt = 0 = [[0, 0, 0, 0, 2], [0, 0, 0, 0, 2]] (batch=2, max_seqlen=5, '2'='<s>']. Then, once you get the output ('4'='hi') from the decoder, it gets fed back into the input sequence and shift by one, which results in y1 = [[0, 0, 0, 2, 4], [0, 0, 0, 2, 4]].

And, wow, 'teacher forcing' seems powerful.

How do you deploy the model? In other words, during testing/deployment (not validation), what do you put in replace of target sequences?

Would you mind linking the paper that you are referenced?

Thank you!

Hi @mun94 ,
Would you mind to provide the link and the exact code part about the tensorflow implementation you mentioned?
I haven't have time to dig into the official tf code.

I believe this does it. Let me know if I am wrong :) https://github.com/tensorflow/tensor2tensor/blob/master/tensor2tensor/utils/data_reader.py#L227

Hi @mun94 ,
The teacher forcing concept are first named in A Learning Algorithm for Continually Running Fully
Recurrent Neural Networks .
However, it has been well described in the introduction part in Professor Forcing: A New Algorithm for Training Recurrent Networks.

Hi @mun94 ,
I am sorry. I did not see where the decoder take the last output instead of ground truth in your link.
The part you post seems only padding the data instances to the same length for mini batch operation.
I am not an expert of TensorFlow, so please highlight the exact code statements for me instead of just the function name. Thank you.

I am not an expert either so I am not sure if my explanation will make sense for you lol.
But basically, in the function below
def infer_step(recent_output, _),
you it does extra padding and add the 'recent output' (line 273):
padded = tf.pad(recent_output, [[0, 0], [0, 1], [0, 0], [0, 0]]).
Then they slide the window of the decoder input (line 305-309):
result = tf.foldl(           infer_step,           tf.range(decode_length),           initializer=initial_output,           back_prop=False,           parallel_iterations=1)
where 'decode_length=50' (line 140) is the window size.
They do it token-wise. I guess you are giving the whole sequence (which you referred as the 'last output from the decoder') into the decoder, right?

Excuse me.

I guess you are giving the whole sequence (which you referred as the 'last output from the decoder') into the decoder, right?

Yes, I did.
And I also said that the teacher forcing (whole target seq into the decoder) is only used in training phase.
The code you paste is under the function called infer and it is for inference phase.
In the inference phase, I do the exact same thing as they did.
I think we are discussing about the teacher forcing method in the training phase.

Sorry, I just wasn't clear about the term inference phase.

The inference phase is simply the prediction phase (or test phase).
You could take a look on the following resources to get more background knowledge.
Tensorflow tutorial: step by step, with original paper.
OpenNMT-py: very well-written, a little bit complex
Since the misunderstanding is cleared up, let me close this issue.

Can you please send me the link to your code where the decoder behaves in a regressive manner? THank you :)

The code is here: https://github.com/jadore801120/attention-is-all-you-need-pytorch/blob/master/transformer/Translator.py#L81-L102
This part also include the beam search part (not a greedy infer), so maybe hard to read.
Long story short.
The decode output is stored in beam b.
And the last output from decoder are retrieved with the get_current_state and take as the next input.
https://github.com/jadore801120/attention-is-all-you-need-pytorch/blob/master/transformer/Translator.py#L81-L82 .

It might be good to stop using teacher forcing after certain epochs, if we can put such a hyperparameter in the scheduler.

@jadore801120
Hi guy, you are very nice to provide the pytorch code of transformer, great work!
But I have a question for you, do you implement the teacher-forcing strategy in your training process below?
https://github.com/jadore801120/attention-is-all-you-need-pytorch/blob/master/transformer/Models.py#L204-L206
It seems you did not use the teacher forcing in the training, right?


Rename common to conf

So that we will have a common directory to hold common codes,
the previous common is actually a mix with configurations, debug
flags, helpers. We can further move those helpers into common module
and let conf only handles configurations.

I like the idea of separating them from the actual common code, but I don't like the name 'conf' as it makes it seem like it's related to keylime.conf handling. Is there a better more descriptive name we could use? flags? globals?

The intent is to extract configuration unrelated codes out to a common module, so the original file is renamed to conf, it will only do configuration related things, probably having keylime.conf autogeneration in this file in the future.
So, the name conf seems fit for this purpose, config is also fine. Using global variables as configuration options is a good choice at early development, I guess it would be good to gradually migrate those into configuration file.

I like config and have seen that a lot before.
@kaifeng , nothing to do with this PR, but are you able to jump on our cncf slack channel and ping me when you're there?


add lifecycle

in some case we need update source_image_id or source_image_reference by Ansible in vmss. so terraform should ignore them.
for that reason we need to manage lifecycle.

I am not sure this is yet supported on Terraform. As far as I can see it is a requested feature. Can you confirm you wanted to achieve the same as defined in this issue?  https://github.com/hashicorp/terraform/issues/24188

Closing as not active.


ASP.NET Core 3.1 GitThisAssemblyMetadata setting?

I have tried setting GitThisAssemblyMetadata to true using a property group in the project .csproj and Directory.Build.props but the ADDMETADATA doesn't get defined.  I'm not sure how to get this setting to work with .net core.
TEST.App.csproj.txt

Hi @Aaron-P
Have the same issue. Setting the ADDMETADATA as Conditional compilations symbols (Right click csproj > Properties > Build) explicitly works. Then you can get them
var gitAttributes = typeof(Startup).Assembly.GetCustomAttributes(typeof(System.Reflection.AssemblyMetadataAttribute));

I manually add the symbol for now, but this question would still matter for the other options that you can set.


No access to base station

I do not see any way to connect and interact with the base station that is included with the Wyze Outdoor Cam.

@l0rddarkf0rce you should be able to retrieve the base station with a standard listing of devices. I don't have cameras/base stations, so I was not aware there was anything you could "do" with them.
If you want to describe what you need, should be too hard to add it


[T4A3][W09-A1]Teo Tian Song

Ready for review.

@ephyra
Some comments added. Please close the PR after reading comments.


Multi-sequence support for all MultiTransformBlocks

Adds multiple sequence support to all MultiTransformBlocks with the self.trigger_sequence switch.

In the read/write loop, set self.trigger_sequence=True and modify the headers and gulp_sizes appropriately, and the next loop iteration will allocate outspans on new sequences (it triggers new sequences on multiple output rings).

NumpyBlock and NumpySourceBlock create new sequences automatically when their input headers or outputted data changes.
Also creates _main() function in MultiTransformBlocks, which performs tedious activities like setting affinity.core and creating empty headers for the rings. The _main() function is called automatically by the pipeline and calls main() when finished.

Is this test failure a problem?

It might be another problem with the CPU-only build of Bifrost. My GPU build of this branch works for all 86 tests. Have you seen a problem on your machine?

You need to merge or rebase onto master locally before testing (e.g., git checkout feature/multi-sequence-support ; git rebase master). I get lots of test errors after doing this.

Strange—I am merging master before building. The only conflict was whitespace inside of config.mk.
I can see all of your new unit tests running as well.
What errors are you seeing?

 I now see no failures.
I guess the jenkins failure is just the same thing we've been seeing in master? (Initially I had thought it was something new.)

Does this look good for merging? I should be pushing the travis-ci fix later today.


CLOUDSTACK-9135 - As a Developer I want the test_internal_lb.py to test Redundant VPCs

This PR refactors the existing tests and adds tests to cover internal LB with Redundant VPCs.
In order to make it possible I had to change the base.py, allowing multiple providers per service. This change requires the changes in the Java side which were dealt with PR #1215 .

Ping @remibergsma @DaanHoogland @borisroman @michaelandersen @bhaisaab @karuturi @miguelaferreira
Please, keep in mind that this PR depends on PR #1215.

Environment

1 KVM host on CentOS 7.1
Management Server on CentOS 7.1
Agent + Common RPMs built from source

Test executed

nosetests --with-marvin --marvin-config=/data/shared/marvin/mct-zone2-kvm2-ISOLATED.cfg -s -a tags=advanced,required_hardware=true smoke/test_internal_lb.py

Results

[root@cs2 integration]# less /tmp//MarvinLogs/test_internal_lb_DXYD14/results.txt
Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's in a Single VPC ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's in a Redundant VPC ... === TestName: test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 4 tests in 6681.151s

OK
/tmp//MarvinLogs/test_internal_lb_DXYD14/results.txt (END)

Hi @wilderrodrigues ,
Looks good! Thanks for making the tests compliant!
Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's in a Single VPC ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's in a Redundant VPC ... === TestName: test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 4 tests in 5901.365s

LGTM :+1:

Thanks for the reviw, @borisroman! :)

LGTM based on running the tests:
[root@cs1 integration]# cat /tmp//MarvinLogs/test_internal_lb_SFTBEY/results.txt
Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's in a Single VPC ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's in a Redundant VPC ... === TestName: test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 4 tests in 3847.453s

OK


Provide Converter for Kafka Connect.

Supply an out the box converter to support Kafka Connect

@satishd I'm thinking of bumping this to 0.3.2 as independent and i think getting 0.3.1 out the door with the critical blocking bits for migration is more important, and worst case is if a user needs this, they could run with confluent bits for an interim. WDYT?

@michaelandrepearce Sure, not really needed for 0.3.1.

Hi Satish,Michael,
Is this covering bytearrayconvertor?

Hi @gavintgh ,
This is to be an Converter for Kafka Connect, similar in nature to https://github.com/confluentinc/schema-registry/tree/master/avro-converter/src/main/java/io/confluent/connect/avro
When doing some of the confluent compatibility bits i have some of this done already locally but haven't had the time due to other project pressures to complete it off.
Is this what you're asking for? Is there a specific need for this now?
Just so i prioritise what open source work i work on over the next month. For me and my org this is low priority so i had semi dropped it for now.

Any updates on this?


How can we make a SSR call?

Hi,
How can we make a SSR call?
When i try this:
const { workspaces: workspaceData } = await $fetch<any>("workspaces");

It's always client side. When I add ssr:
const { workspaces: workspaceData } = await $fetch<any>("workspaces", {
       server: true
});

https://nuxt.com/docs/getting-started/data-fetching
It's not working , and still making a client side call (I have SSR enabled in my nuxt.config file).
Thanks!

Hi, you can see an example here https://github.com/k2so-dev/laravel-nuxt/blob/main/nuxt/app/pages/account/devices.vue


SITE-45: Migrate GPU Day website to DotNest Tenants Core

SITE-45

These changes aren't actually needed.


Ability to have multiple SetErrorInterceptors

I have multiple modules and each one might handle a different status code like 401 or 409. Would it be possible to support multiple error interceptors? https://github.com/mgonto/restangular/issues/488
Maybe it runs all of them and stops when one of them is handled.

I've just got the same issue. That would be very good.

This is already implemented and unit tests are passing, what's the issue you are having (code samples plz) ?
See those lines https://github.com/mgonto/restangular/blob/master/test/restangularSpec.js#L183-L211

I had multiple interceptors setup in different modules and the ordering of them really messed up things.  It's been a while (I sense reverted the code), but basically I always wanted them all to run, not stop after the first one returned a result.

@niemyjski Any update? Is this still an issue?

Yes I do think so. I haven't tried for a long while as there hasn't been any updates to this lib

Okay, would you mind providing a live example on Plunkr?


Initial Migration fails on Django 1.7.4 & Python 2.7

I followed the install directions on Read the Docs and I'm pretty sure I did that right.
When I do the initial:
$ python manage.py migrate photologue
I get the following error:
Applying photologue.0001_initial...Traceback (most recent call last):
File "manage.py", line 10, in
execute_from_command_line(sys.argv)
File "/root/.virtualenvs/photolouge_test/lib/python2.7/site-packages/django/core/management/init.py", line 385, in execute_from_command_line
utility.execute()
File "/root/.virtualenvs/photolouge_test/lib/python2.7/site-packages/django/core/management/init.py", line 377, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
File "/root/.virtualenvs/photolouge_test/lib/python2.7/site-packages/django/core/management/base.py", line 288, in run_from_argv
self.execute(*args, **options.dict)
File "/root/.virtualenvs/photolouge_test/lib/python2.7/site-packages/django/core/management/base.py", line 338, in execute
output = self.handle(*args, **options)
File "/root/.virtualenvs/photolouge_test/lib/python2.7/site-packages/django/core/management/commands/migrate.py", line 161, in handle
executor.migrate(targets, plan, fake=options.get("fake", False))
File "/root/.virtualenvs/photolouge_test/lib/python2.7/site-packages/django/db/migrations/executor.py", line 68, in migrate
self.apply_migration(migration, fake=fake)
File "/root/.virtualenvs/photolouge_test/lib/python2.7/site-packages/django/db/migrations/executor.py", line 102, in apply_migration
migration.apply(project_state, schema_editor)
File "/root/.virtualenvs/photolouge_test/lib/python2.7/site-packages/django/db/migrations/migration.py", line 108, in apply
operation.database_forwards(self.app_label, schema_editor, project_state, new_state)
File "/root/.virtualenvs/photolouge_test/lib/python2.7/site-packages/django/db/migrations/operations/fields.py", line 37, in database_forwards
field,
File "/root/.virtualenvs/photolouge_test/lib/python2.7/site-packages/django/db/backends/sqlite3/schema.py", line 176, in add_field
self._remake_table(model, create_fields=[field])
File "/root/.virtualenvs/photolouge_test/lib/python2.7/site-packages/django/db/backends/sqlite3/schema.py", line 144, in _remake_table
self.quote_name(model._meta.db_table),
File "/root/.virtualenvs/photolouge_test/lib/python2.7/site-packages/django/db/backends/schema.py", line 102, in execute
cursor.execute(sql, params)
File "/root/.virtualenvs/photolouge_test/lib/python2.7/site-packages/django/db/backends/utils.py", line 81, in execute
return super(CursorDebugWrapper, self).execute(sql, params)
File "/root/.virtualenvs/photolouge_test/lib/python2.7/site-packages/django/db/backends/utils.py", line 65, in execute
return self.cursor.execute(sql, params)
File "/root/.virtualenvs/photolouge_test/lib/python2.7/site-packages/django/db/utils.py", line 94, in exit
six.reraise(dj_exc_type, dj_exc_value, traceback)
File "/root/.virtualenvs/photolouge_test/lib/python2.7/site-packages/django/db/backends/utils.py", line 65, in execute
return self.cursor.execute(sql, params)
File "/root/.virtualenvs/photolouge_test/lib/python2.7/site-packages/django/db/backends/sqlite3/base.py", line 485, in execute
return Database.Cursor.execute(self, query, params)
django.db.utils.OperationalError: table photologue_gallery__new has no column named photos
This appears ( to me ) to be a problem with the models or migrations or the DB layer
As you can see I'm just using SQLite right now. Is that going to cause a problem?
I didn't see anything in the docs suggesting that was a problem.
I am also using Django 1.7.4
I noticed your latest Travis tests are using 1.7.2
Do you think this could have anything to do with this error?
I am fairly new to using Django 1.7 so I'm not super familiar with the new built in migrations and what can go wrong there and what kinds of errors might be thrown, but the directions are pretty simple and I followed them.
I'm at a loss to what could cause this kind of error, I imagine your models themselves  are pretty stable  by now so it must be something to do with how they are being introduced to the fresh DB.

Its seems like there were two problems I ran into working from the docs:
What I think the problem was is that in the docs you mention that using Django <1.7 you need to include the South Migrations setting:
SOUTH_MIGRATION_MODULES = {
'photologue': 'photologue.south_migrations',
}
It seemed to imply that you don't need that setting if you're running Django 1.7.x
The error above I got while migrating went away when I included this setting:
MIGRATION_MODULES = {
'photologue': 'photologue.south_migrations',
}
Perhaps I was supposed to know that's how it worked but if so the docs where written in a confusing way to people who are new to Django 1.7,
I'm assuming this setting is necessary, it seemed to solve my problem.
If so maybe its worth mentioning in the docs.
Also, probably unrelated,
I needed to include 'django.contrib.sites' in INSTALLED_APPS
because photolouge seemed to be dependant on it.
This was not listed in the docs under the required INSTALLED_APPS

Hi @web-snake - I've checked and there is an issue with Django 1.7.4; I will investigate this and the other issues that you have raised. Thanks for the report!

Django-photologue depends on django-sortedm2m, which has been broken by Django 1.7.4. See gregmuellegger/django-sortedm2m#43.
When sortedm2m fixes this and releases a new version, I will prepare a new release of Photologue that uses the fixed sortedm2m.
For now - the workaround is to use Django 1.7.3.

@web-snake: In MIGRATION_MODULES you should not be pointing to the old South-compatible migrations - I'm not sure why it worked for you! You shouldn't have to configure anything in Django 1.7.x.
Also, I've made a few changes to the documentation; hopefully it's a little bit clearer, but feedback is always welcome!

The next release of Photologue will install the latest version of django-sortedm2m, which should fix this migrations issue.
I'll close this issue, but please do not hesitate to re-open it if the problem reoccurs.


Lock yarn and nodejs versions

Why: We were seeing a flaky bug introduced by a new version of yarn released

Yarn 1.9.4
Nodejs 8~

See https://github.com/yarnpkg/yarn/pull/6302 for more information on the upstream yarn bug


FR: add permissions

Create a permission so folks can prevent some roles from updating the config

@edalzell this would be very useful, please! Currently, we will not be able to prohibit "content editors" from fiddling with Mailchimp form configs (or will have to somehow patch Statamic navigation on top of this, which will not be clean)...

added in 1.0


dplug.org issues

Phone

[ ] should have link to dplugdocs
[ ] shoudl have question about UI-less plug-ins


Unable to publish

npm ERR! You do not have permission to publish "whodidwhat". Are you logged in as the correct user? : whodidwhat

@tgetgood Any ideas?

What's your username on npm? I'll add you to the collaborators. Ideally I would transfer ownership of it, do you know how to do that with npm packages?

I'm on npm as richardlitt. npm owner --help should give all of the information needed. Thank you!

You are now an owner. Try it out and let me know if everything's good.

It worked! Thanks, @tgetgood.


Respecting XDG vars correctly

distributions:  XDG_CONFIG_HOME + '/binenv/'
cache:          XDG_CACHE_HOME + '/binenv/'
🧨 this might break tools relying on the old places!
Fixes #241

Many thanks @AXGKl , that's great.

landing in v0.19.10


Don't treat NewConnectionErrors as timeouts.

Resolves #2811.
Fundamentally I view this mostly as a compatibility change, to get us back into line with how we've processed this kind of error in the 2.X series. I think I'd like to back it out in 3.0.0, which is why I've left a note in the code to that effect.

@sigmavirus24 How do you feel about removing this in 3.0.0?

+0

@Lukasa I've found a TODO made by you and associated with this issue https://github.com/requests/requests/blob/3.0/requests/adapters.py#L531


Local account - HTTP 401

When attempting to authenticate using a local user against a domain-joined machine, a HTTP 401 response is returned. Setting the domain appears to have no affect (.\myuser , TEST\myuser etc.)

I believe this has something to do with the target (domain) in the authenticate message being set from the challenge message:
https://github.com/Azure/go-ntlmssp/blob/4b934ac9dad38d389d34f0b98d98b2467c422012/authenticate_message.go#L117
https://github.com/Azure/go-ntlmssp/blob/4b934ac9dad38d389d34f0b98d98b2467c422012/authenticate_message.go#L68

I also encounter 401 error when using go-ntlmssp.
I use https://github.com/vadimi/go-http-ntlm, it works.
So I guess NTLMv2 implementation of go-ntlmssp is different from https://github.com/ThomsonReutersEikon/go-ntlm (which is used by https://github.com/vadimi/go-http-ntlm)

I am reasonably sure this is because the workstation that is being provided in the authenticate message is not one that the local account has permission to log into. vadimi/go-http-ntlm does not set this value, but this library sets it to "go-ntlmssp". I was seeing this issue with accounts that only had access to log into certain machines - even when running on those machines. By providing a blank workstation name int authenticate_message.go I was able to log in successfully.


Implement missing_methods.rb diff in Sorbet

Motivation

Test plan

See included automated tests.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_Ke15SJq2cQa45h
→ https://go/builds/bui_Ke15gFDtwlZWTe

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_Ke1n1y0aX3Q1jP
→ https://go/builds/bui_Ke1nJv2FFMVd63


Fix monthly stats being incorrectly calculated when calculated over multiple years

Checklist

[ ] You added tests to cover the change
[ ] mvn clean install build and test completes
[ ] You changed or added to the documentation

As long as we're sure that API Config gets loaded in at the developer desktop, CICD pipeline, and in PRD then this is good.

@karianna Yeah it will


str crash due to timeout in fetchart plugin

This looks like more of an issue with the urllib3 package than beets, but beets could do with a workaround to avoid crashing when this exception occurs while fetching album artwork:
  File "/usr/local/lib/python2.7/dist-packages/beets-1.3.14-py2.7.egg/beetsplug/fetchart.py", line 385, in fetch_art
	path = self.art_for_album(task.album, task.paths, local)
  File "/usr/local/lib/python2.7/dist-packages/beets-1.3.14-py2.7.egg/beetsplug/fetchart.py", line 488, in art_for_album
	candidate = self._fetch_image(url)
  File "/usr/local/lib/python2.7/dist-packages/beets-1.3.14-py2.7.egg/beetsplug/fetchart.py", line 425, in _fetch_image
	with closing(requests_session.get(url, stream=True)) as resp:
  File "/home/ben/.local/lib/python2.7/site-packages/requests/sessions.py", line 477, in get
	return self.request('GET', url, **kwargs)
  File "/home/ben/.local/lib/python2.7/site-packages/requests/sessions.py", line 465, in request
	resp = self.send(prep, **send_kwargs)
  File "/home/ben/.local/lib/python2.7/site-packages/requests/sessions.py", line 573, in send
	r = adapter.send(request, **kwargs)
  File "/home/ben/.local/lib/python2.7/site-packages/requests/adapters.py", line 370, in send
	timeout=timeout
  File "/home/ben/.local/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 544, in urlopen
	body=body, headers=headers)
  File "/home/ben/.local/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 344, in _make_request
	self._raise_timeout(err=e, url=url, timeout_value=conn.timeout)
  File "/home/ben/.local/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 314, in _raise_timeout
	if 'timed out' in str(err) or 'did not complete (read)' in str(err):  # Python 2.6
TypeError: __str__ returned non-string (type Error)

Wow, that's quite a bug. FWIW, it's tracked (and unfixed): https://github.com/shazow/urllib3/issues/556


Add support for VSTS.TCM.AutomatedTestName

Automated Tests can be associated to Test Cases using Visual Studio. These values can also be assigned through the Azure DevOps REST API.
When associating tests, the following properties are set:

Microsoft.VSTS.TCM.AutomatedTestName: The name or identifier of the automated test associated with the test case
Microsoft.VSTS.TCM.AutomatedTestStorage: The assembly that contains the automated test case
Microsoft.VSTS.TCM.AutomatedTestId: unique identifier
Microsoft.VSTS.TCM.AutomatedTestType: descriptor for the test type, "Unit Test", "Coded UI", etc
Microsoft.VSTS.TCM.AutomationStatus: Automated, Not Automated, Planned

The logic to generate the unique identifier is described in this log: https://devblogs.microsoft.com/devops/how-to-associate-automation-programmatically/
Expected behaviour:

.NET test automation using NUnit, xUnit, MSTest formats:

developers should be able to use the associate to test case feature of Visual Studio
the Microsoft.VSTS.TCM.AutomatedTestName in the TestCase should automatically line up to the testcase.name property from the test-result-parser library as this typically represents the full-class-name-method in those formats.
if the test class, method or assembly are modified, users would need to re-associate the test case.

Other platforms (JUnit, Mocha, Cucumber):

Out of scope for now

I would gladly appreciate this, because we are currently using the VSTest@2 task to run our tests on windows. But now we are switching over some tests to linux/docker where the task is no longer supported, but we still want to be able to associate the test results with the test cases/test points.
As we already have the AutomatedTestName set on all test cases for the VSTest task to work, it would make the transition to this task a lot easier, if it would be automatically picked up.
Do you have a workaround for this until this is implemented? My first guess would be to use a regex because some of our test method names match the format "TC__*". Or do you have a better suggestion?

I'm glad to hear that you've found a valid use case for this. I just assumed that if teams were using the test automation property they wouldn't need this extension and would simply use VSTask. The VSTask has a windows executable that performs the look-up (and also has some awesome test sharding features for parallel execution). I hadn't considered the Windows to Linux conversion scenario.
I'd be happy to look at adding this, but I'll need some time to create a reproducible scenario. Also, I'm confident that  it'll work for TRX, because .NET has fully-qualified test case names, but other frameworks don't, so the solution would likely only use Microsoft.VSTS.TCM.AutomatedTestName and we'd need guidance for other platforms if they intend to use this. I should be able to find some cycles for this, hopefully before month's end. I'd also welcome pull requests.

Do you have a workaround for this until this is implemented?

Adding the TestCaseId to the name of the Test would be my first recommendation for a workaround.

The problem is that we create a new test plan for each iteration which clones all the test cases and they end up with a new ID that doesn't match the associated test name anymore.

Unless you are deliberately making duplicate Test Cases and then manually re-associating the Microsoft.VSTS.TCM.AutomatedTestName, that's not my understanding. Test Cases and their IDs are fixed. When you create a new Test Plan and copy Test Suites into it, new Test Suites are created, but they include references to the original Test Cases. Within a Test Plan, the uniqueness of the TestPlan+TestConfig+TestCase is used to establish the TestPoint. To illustrate this, link a Test Case in a Test Suite to a User Story, then clone the Test Suite. The Story will only have one TestedBy association. You can get the TestCaseId in the URL when you edit the TestCase definition. If you're seeing something else, I'd be curious to learn how your team is setting this up.

Thanks for the quick reply!

I should be able to find some cycles for this, hopefully before month's end.

No rush, I am currently fine with porting tests to linux and view the test results within the release pipeline using the PublishTestResults@2 task. I am just glad that this is actually possible because Microsoft doesn't seem to have this scenario anywhere in their sight.
Having support for Microsoft.VSTS.TCM.AutomatedTestName and attachments (which we rely on) would be optimal for us to switch over to your extension.

I'd also welcome pull requests.

I played around with the REST API already locally using C# and at least the automated test name feature doesn't look too complicated but Typescript ain't my daily work therefore it would also take me a while when I find the time.

I'd be curious to learn how your team is setting this up.

Basically we clone the test plan for each iteration using these steps:

In this scenario the test cases are cloned and therefore get new IDs while the automated test name stays the same. We then clone the release pipeline and/or adjust it the VSTest task to the new testplan and avoid having to update all method names in the source code.
I am not a big fan of the cloning to be honest and it wasn't my decision but it's not really my focus to look for an alternative.

Shame about cloning the test cases, but I definitely see the value of using the automated test name for your scenario.
A few other bugs came in this weekend. Hopefully I can carve some time this weekend for these.

@C0nquistadore This is now available!
I was able to perform some limited testing on my end, but I would to hear feedback if this is working for you.

I have tried this out without any specific configuration (using testCaseMatchStrategy: auto) and it works great! Thanks!


[API DOC] add explain for addIDToDataFrame since it's special

I add a explain since it's special that start from 1 but not 0.
I will try add scala version to make this parameter-able in another pr.

ping @niketanpansare
It's a simple doc change.

@Wenpei LGTM.  I just wanted to follow the conversation on the other PR prior to merging this.
Thanks!


Schedule regression

This was removed by mistake, causes https://github.com/rtic-rs/cortex-m-rtic/issues/364

bors merge


Supporting Geospatial Operations

Hello,
Currently, MapD does not support a variety of geo-spatial operations such as spatial kNN queries, spatial join queries, etc. Since, these queries are compute intensive, GPUs will be tremendously beneficial for boosting their performance. I (as a part of my PhD work), am working towards adding this functionality in MapD-core and planning to release it to the community. I am currently understanding the code.
Here's a post from mapd-core forum where I has posted my queries related to code docs. I am creating an issue (as suggested by @aaron_mapd) here to get more help. I am willing to work with the dev team to better understand the existing code of MapD-core, designing my solution, and releasing it. Any help in this regard will be greatly appreciated!
Thanks,
Harshada

Hi Harshada,
Welcome to the MapD community!
In case you missed it, we do have some geospatial features in the works:
https://github.com/mapd/mapd-core/blob/master/ROADMAP.md#gis
Hopefully you'll be able to build upon this functionality, once it lands.
Spatial kNN in particular could be implemented through sorting by ST_Distance() to the neighbors, in ascending order, and then taking the top K to get just the nearest ones.
It would be great if you could share technical details on all the queries you'd like MapD to support. Maybe a technical specification, use cases, etc? If you start developing, please share your design first, let's coordinate our efforts to avoid duplication. And of course let us know if you need any assistance.
Regards,
Dmitri

Hi Dmitri,
Thanks for the help. I will share my plane with the team.
Could you please let me know which files contain the implementation for the existing geospatial operators such as ST_Distance?
Thanks,
-Harshada

Hi Harshada,
This is work in progress, I will point you to the changes once they land in mapd-core.
Thanks,
Dmitri

Do you have any kind of spatial indexing like R-tree or KD-tree  in MapD ?

Currently we don't have many indexing data-structures specially not R-tree or KD-trees. If you feel you can contribute to the project we would love to support your efforts.

Hi, I have two tables, a shapefile and a table of records with lat, lon.  Is it possible to do a spatial join such that for each point I know into which polygon it falls into?  Also, what's the status of this, plans to release them soon?

mapdql> SELECT ST_X(ST_ENDPOINT(ST_GeomFromText('LINESTRING(-118.243683 34.052235)', 4326))) from geo22 limit 1;
EXPR$0
-118.243683

mapdql> SELECT ST_X(ST_ENDPOINT(ST_GeomFromText('LINESTRING(34.052235 -118.243683)', 4326))) from geo22 limit 1;
Exception: Imported WGS84 latitude -118.243683 is out of bounds

mapdql> SELECT ST_X(ST_ENDPOINT(ST_GeomFromText('LINESTRING(234.052235 -118.243683)', 4326))) from geo22 limit 1;
Exception: Imported WGS84 longitude 234.052235 is out of bounds

mapdql> SELECT ST_X(ST_ENDPOINT('LINESTRING(234.052235 -118.243683)')) from geo22 limit 1;
EXPR$0
234.052235

Closing this; MapD does now support selected geospatial operations. As we develop our roadmap, we'll consider adding these types of spatial queries


java.lang.IllegalArgumentException: newPosition > limit: (67079825 > 8454316)

version 1.4.4
The Error info
/* JADX WARN: Failed to parse debug info
java.lang.IllegalArgumentException: newPosition > limit: (67079825 > 8454316)
at java.base/java.nio.Buffer.createPositionException(Unknown Source)
at java.base/java.nio.Buffer.position(Unknown Source)
at java.base/java.nio.ByteBuffer.position(Unknown Source)
at jadx.plugins.input.dex.sections.SectionReader.absPos(SectionReader.java:82)
at jadx.plugins.input.dex.sections.debuginfo.DebugInfoParser.process(DebugInfoParser.java:84)
at jadx.plugins.input.dex.sections.DexCodeReader.getDebugInfo(DexCodeReader.java:118)
at jadx.core.dex.nodes.MethodNode.getDebugInfo(MethodNode.java:564)
at jadx.core.dex.visitors.debuginfo.DebugInfoAttachVisitor.visit(DebugInfoAttachVisitor.java:39)
*/
Now, I think  how to resole this question.
Thanks

Now, I think how to resole this question.

@janecms do you want to prepare a PR for that issue? PR is always welcome :slightly_smiling_face:
Anyway, it will be nice to provide a sample, so we can reproduce/check this issue.

how to resole??

@sulab999 @janecms The best way to resolve an issue that is caused by a certain DEX/APK files is providing the APK file.
@janecms In your original post you wrote  Now, I think how to resole this question. Most people would interpret this sentence this way "I think now I know what changes needed to be done in Jadx to resolve this issue in Jadx". Thus skyot proposed to you to open a PR. If this sentence was meant in a different way please tell it to us.

this apk
https://www.amazon.com/clouddrive/share/jADAfCDcUu9dEnrxSUwe0MS3aCCVg7CBGWvthsD90mk

Hey there! any updates about this?

@ya121y we still do not have sample to reproduce this issue.
Sample provided by @sulab999 not having this exact issue (checked with latest unstable build).
@ya121y if you can share a sample please open a new issue, I will close this one because it is old and useless now.

I know this was closed for lack of info but am getting it with the coospo CoospoRide app (current app  com.onecoder.coosporide v2.5.31 does as well as prior versions). Was trying to figure out how it talks to my ble hardware but nothing gets decoded. App can be had off the Play store or from apkpure https://apkpure.com/coosporide/com.onecoder.coosporide
One example error message from one of the fragment classes, but this seems to happen with pretty much all the classes.
`/* JADX WARN: Failed to parse debug info
java.lang.IllegalArgumentException: newPosition > limit: (67042708 > 8843904)
at java.base/java.nio.Buffer.createPositionException(Buffer.java:318)
at java.base/java.nio.Buffer.position(Buffer.java:293)
at java.base/java.nio.ByteBuffer.position(ByteBuffer.java:1094)
at jadx.plugins.input.dex.sections.SectionReader.absPos(SectionReader.java:82)
at jadx.plugins.input.dex.sections.debuginfo.DebugInfoParser.process(DebugInfoParser.java:84)
at jadx.plugins.input.dex.sections.DexCodeReader.getDebugInfo(DexCodeReader.java:118)
at jadx.core.dex.nodes.MethodNode.getDebugInfo(MethodNode.java:626)
at jadx.core.dex.visitors.debuginfo.DebugInfoAttachVisitor.visit(DebugInfoAttachVisitor.java:39)
*/
@Override // androidx.fragment.app.Fragment
public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
    return null;
}
`

@draekko Thanks for providing a sample app. Which Jadx version have you used when the posted error occurred?
I wasn't able to reproduce your problem using Jadx 1.5.0 and also not with latest stable version decompiling androidx.fragment.app.Fragment of CoospoRide_2.5.31_APKPure.apk (SHA-1 hash 9F8D9CFED84E2514EBE644235B289E26A914C41D).

I tried 1.5.0 release which i've been using since it was released and tried the latest unstable build this morning.
Java says this
openjdk 21.0.4 2024-07-16
OpenJDK Runtime Environment (build 21.0.4+7-Ubuntu-1ubuntu224.04)
OpenJDK 64-Bit Server VM (build 21.0.4+7-Ubuntu-1ubuntu224.04, mixed mode, sharing)
Using it on latest Ubuntu 24.04.1 LTS

hmmm seems to have a different hash as the one i extracted off the device which i got it via the play store using aurora store for v2.5.31.
7a14391791d3d9666bc784083dabd109f1a3aa8f

Does jadx use JAVA_HOME or does it use the default path for the jdk?

Verified - com.onecoder.coosporide.main.ChartFragment causes multiple errors like java.lang.IllegalArgumentException: newPosition > limit: (67042709 > 8843904) in APK CoospoRide_2.5.31_APKPure.apk (SHA-1 hash 9F8D9CFED84E2514EBE644235B289E26A914C41D) from https://apkpure.com/coosporide/com.onecoder.coosporide

It is likely to be caused by NOP padding in the method bytecode, after the return instruction. It can be seen below with JEB, with the "Show instructions in gap" option enabled.

@draekko, @jpstotz thanks for sample and issue confirm
This issue caused by incorrect debug info offset in dex method code section.
(Check DEX format docs https://source.android.com/docs/core/runtime/dex-format#code-item for debug_info_off field.)
Looks like it was corrupted intentionally to disrupt decompilation or dissemble.
Anyway, such incorrect data clearly reported by ApkTool/Smali like this:
Lcom/onecoder/coosporide/main/ChartFragment;->createCircleGradientDrawable(II)Landroid/graphics/drawable/Drawable;: Invalid debug offset

So I also commit a similar check and now instead of error with stacktrace, simple warning is added:
    /* JADX WARN: Invalid debug info offset */
    public final Drawable createCircleGradientDrawable(int startColor, int endColor) {
        return null;
    }

Funny that here argument names comes from Kotlin metadata, which are not removed :rofl:

Just tried apktool and all the smali code is nop'ed out as jackpwa mentioned, any suggestions on how i might go about to retrieve the code? Thanks in advance

any suggestions on how i might go about to retrieve the code?

@draekko looks like this is not possible using only static analysis tools like jadx, so you also need a dynamic/runtime tool like frida to catch dex files restored/decrypted at runtime. ApkId report that this apk uses Ijiami packer, so you can try to search guides to fight it.

Thanks for the suggestion, will look into them.


memory budget exceeded

I have used below expression
let two = {"one":1000000}; let resultMap = {0 : two.one in 1000000..2000000}; resultMap
and getting below error
memory budget exceeded (2:40)  | let resultMap = {0 : two.one in 1000000..2000000}; resultMap  | .......................................^

1000000..2000000 creates a huge array. Expr prevents those kind of misuse.
But sometimes Expr can modify code to make it faster: 42 in 1000000..2000000 will be converted to 1000000 <= 42 <= 2000000.
Expr will not modify code if type of variable is any:
let x = [1, "a"][0]; // Trick type checker to thinking x is of "any" type.
x in 1000000..2000000 // Will result in error.

but then how its working when i'm adding a patcher
binary, ok := (*node).(*ast.BinaryNode) 	if ok { 		if binary.Operator == "in" { 			ast.Patch(node, &ast.BinaryNode{ 				Operator: binary.Operator, 				Left: &ast.ConditionalNode{ 					Cond: &ast.BinaryNode{ 						Left:     binary.Left, 						Operator: "==", 						Right:    &ast.NilNode{}, 					}, 					Exp1: &ast.IntegerNode{Value: 0}, 					Exp2: binary.Left, 				}, 				Right: binary.Right, 			}) 		} 	}

by replacing ==


Search text Misbehaves with TRUE boolean

If User uses search text Like -> Field isAuth and Value true , then It does not return any Search Result Coz , it gets "true" in the server which is not liked by MongoDB

@mrvautin Please have a look here . Its fixed . I will provide more PRs ... Thanks ! Nice Project !


Unable to find module in node_modules only when targeting ES6, ES5 works fine

TypeScript Version: 1.8.10 and higher
Code
Actual code that causes the problem can be found on this issue: https://github.com/ReactiveX/rxjs/pull/1637
# clone the repo
git clone git@github.com:ReactiveX/rxjs.git

# get PR branch
git fetch master pull/1637/head:pr-1637
git checkout pr-1637

# install dependencies (runs build, too, which will fail, but that's okay)
npm i

# try building the CJS version (success)
npm run build_cjs

# try building the ES6 version (failure)
npm run build_es6

The exact scripts being run are:
tsc typings/main/ambient/es6-shim/index.d.ts ./dist/cjs/src/Rx.ts ./dist/cjs/src/Rx.KitchenSink.ts ./dist/cjs/src/Rx.DOM.ts ./dist/cjs/src/add/observable/of.ts                             -m commonjs --sourceMap --outDir ./dist/cjs --target ES5 -d --diagnostics --pretty --noImplicitAny --suppressImplicitAnyIndexErrors
tsc                                          ./dist/es6/src/Rx.ts ./dist/es6/src/Rx.KitchenSink.ts ./dist/es6/src/Rx.DOM.ts ./dist/es6/src/add/observable/of.ts                             -m es2015   --sourceMap --outDir ./dist/es6 --target ES6 -d --diagnostics --pretty --noImplicitAny --suppressImplicitAnyIndexErrors

Expected behavior:
Both build successfully.
Actual behavior:
Only the CJS build succeeds, the ES6 build fails:
11 import * as observableSymbol from 'symbol-observable';
                                     ~~~~~~~~~~~~~~~~~~~

dist/es6/src/Observable.ts(11,35): error TS2307: Cannot find module 'symbol-observable'.

16 import * as observableSymbol from 'symbol-observable';
                                     ~~~~~~~~~~~~~~~~~~~

dist/es6/src/observable/FromObservable.ts(16,35): error TS2307: Cannot find module 'symbol-observable'.

11 import * as observableSymbol from 'symbol-observable';
                                     ~~~~~~~~~~~~~~~~~~~

dist/es6/src/util/subscribeToResult.ts(11,35): error TS2307: Cannot find module 'symbol-observable'.

142 import * as observable from 'symbol-observable';
                                ~~~~~~~~~~~~~~~~~~~

dist/es6/src/Rx.ts(142,29): error TS2307: Cannot find module 'symbol-observable'.

cc @kwonoj @jayphelps for visibility

I noticed specifying moduleResolution (--moduleResolution node) makes es15 build works, but not sure why CJS doesn't affected. (on 1.8.10)

I noticed specifying moduleResolution (--moduleResolution node) makes es15 build works, but not sure why CJS doesn't affected. (on 1.8.10)

Is that the answer then? Perhaps targeting commonjs forces that behavior?

Perhaps targeting commonjs forces that behavior?

: maybe? at least I could apply that explicitly on build script to ensure for immediate resolution.

"there's a CLI flag for that"™

Closing for now, I guess.

This is the expected behavior. The ES6 module spec does not say "Go look in node_modules for a matching folder", so --module es6 doesn't do that either. Since you're loading modules from node_modules, commonjs is the correct module target for your project.

Yes, that's indeed the behavior of their code:
https://github.com/Microsoft/TypeScript/blob/81ebab4c391bef98299321e0cce7090edff36c35/src/compiler/program.ts#L297-L302
if (moduleResolution === undefined) {
    moduleResolution = getEmitModuleKind(compilerOptions) === ModuleKind.CommonJS ? ModuleResolutionKind.NodeJs : ModuleResolutionKind.Classic;
    if (traceEnabled) {
        trace(host, Diagnostics.Module_resolution_kind_is_not_specified_using_0, ModuleResolutionKind[moduleResolution]);
    }
}


Add --dry-run feature for downloading tools

Signed-off-by: Yankee Maharjan<EMAIL_ADDRESS>
Description

Allows the user to run a dry run of tool download to view what version of the tool is being downloaded, and what up version is available. In general what the download would look like without actually downloading the tool.
Motivation and Context

[x] I have raised an issue to propose this change (required)

How Has This Been Tested?

Are you a GitHub Sponsor (Yes/No?)

[ ] Yes
[x] No

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Documentation

[x] I have updated the list of tools in README.md if (required) with ./arkade get -o markdown
[ ] I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

[ ] I have tested this on arm, or have added code to prevent deployment

Closes #518

LGTM!

The only issue I have with this, is that the output is the same as a regular download, including the extraction of files.
I expected --dry-run to print which URL/version would be downloaded and then exit.
The message saying how to run dive for instance, would be invalid if dive hadn't actually been downloaded.

The only issue I have with this, is that the output is the same as a regular download, including the extraction of files.
I expected --dry-run to print which URL/version would be downloaded and then exit.
The message saying how to run dive for instance, would be invalid if dive hadn't actually been downloaded.

I think it makes sense that dry-run  provides the user an end-to-end preview of what running that command looks like. That's what I thought of while creating the PR. What do you think?
The user gets to see:

download URL with version
how it will get extracted
where it will get stored
what commands to run after the installation.
@alexellis

@alexellis Update the PR, now the logs stop after showing the Download URL.

@rgee0 I guess, it's best that we create new issues to address your comments and pick them up from there. :slightly_smiling_face:

@alexellis ready for merge


DEL: Non-functional UI elements from production

Remove:

[ ] Save results
[ ] Existing clients section
[ ] Login button
[ ] Alert that occurs after one submits a new client's info

Rationale:  Current version shows potential functionality.  Moving to production, therefore removing non-functional elements.

*[ ] @lianilychee test check boxes

Are you saying that you'd prefer that the demo go straight to filling out the form instead of going through the other steps first?

I made a pull request to the dev branch with a completely simplified (just the form) version a few days ago. Pinged you folks for a review of it, but I think you haven't had a chance to review it.
Also, there seemed to still be some discussion going on as to whether to go with such a simplified version or not.

I saw a comment in slack from Alec (@danaher2):

the search function is working, albeit with fake client data. My 2 cents is that I think we should only remove functionality that is truly not functional such as the login and creating a new client account. I think getting feedback on what has been built so far, including selecting a client and adding a visit is worthwhile.

I think we should remove the search functionality for now, because we can't save clients, and so the search functionality can't search real clients. I'd like to differentiate between a high fidelity mockup, which should be used in client interviews to get feedback on potential direction, and a minimum viable product, which should be include only features that provide current value.
While we want to include features like search in something like a high fidelity mockup, we should keep it out of our production release until case workers can use it to make their jobs easier.

(Taking it as a given that not all forms/questions/calculations have been implemented yet)
@carpeliam or any folks: Have you had a chance to clone and try the simplified version (https://github.com/knod/cliff-effects-1/tree/simple for a direct link)? If so, is it what you think the flow of the project is looking for right now? It's simplified down to just the form, but the goal is currently everything except the listed items, I can try to do a version like that too.

Starting work on item 1.

Starting work on item 2

Starting work on item 3

Starting work on item 4

The changes should now be deployed. Just to confirm, you don't want any of the other non-functioning elements removed?

@knod yup, that's right!


Branding is not applied to sub-organization sign in page

Describe the issue:

Branding is not applied to sub-organization sign in page
https://github.com/wso2/product-is/assets/40081059/8d01d79e-71bd-41b2-bfaf-fba97760ee7a
How to reproduce:

Expected behavior:

Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: [wso2is-7.0.0-m4-SNAPSHOT-src.zip]
OS: [e.g., Windows, Linux, Mac]
Database: [e.g., MySQL, H2]
Userstore: [e.g., LDAP, JDBC]

Optional Fields
Related issues:

Suggested labels:

The branding resolver caching issue is tracked by https://github.com/wso2/product-is/issues/16890.
Furthermore, in order to enable the branding resolver for sub-orgs in product-is, the following lines should added to the deployment.toml (because tenanted urls need to be activated, to resolve branding).
[tenant_context]
enable_tenant_qualified_urls=true
enable_tenanted_sessions=true

@chamathns   @dhaura once we add the configs to the deployment.toml  its working as expected.However these
changes should be merged ASAP inorder to assure the stability of the relevant functionalities

[tenant_context]
enable_tenant_qualified_urls=true
enable_tenanted_sessions=true

tenanted URLs and sessions will be enabled with the alpha milestone. We are working on stabilizing the test suite to support these configs by default.


Add more feature for RAM information

Hi Team,
For a long time am using this ARI and am very happy with it- is it possible to add get RAM/Memory information as well?
Thanks

Hello,
First of all, thanks for using the tool!
Regarding adding RAM information, I suppose you are talking about the VM and VMSS sheets right? It would be somehow possible, but it would be necessary to add extra API calls to Azure.
Right now Resource Graph only provides the VM size (i.e: Standard_D2_v3), to find the memory and vCPU it would require to consult a separated API just for that. For small environments it would not be a very heavy process, but for larger environments it might impact the overall speed of the report.
Performance is always some of our priorities, so it would be somehow possible, but we would have to validate and test how much it will impact on performance. We are planning to add some extra API call in the next version, so this is something we might consider add as well.

Hello,
I just approved a PR from Seppohto that addes CPU and RAM information to VM sheet.


Html2parquet example

Why are these changes needed?
This PR includes a example showing how html2parquet can be used in a notebook
Related issue number (if any).
https://github.com/IBM/data-prep-kit/issues/788

@shahrokhDaijavad @sungeunan-ibm Before I forget and drop this thread, please review/edit/approve as you see fit. this is the notebook showing how to invoke the html2parquet from within a notebook that I created last week. It can be further evolved based on direct reviews. Thanks

Superseded by another PR


How to implement example packing with flash_attn v2?

Hi Friends 👋
To increase training efficiency, I would like to pack multiple examples into the same input sequence and separate them with EOS tokens. The attention mask will probably have to look like this:

Is there a simple way to implement this using flash attention? If yes, how?

You can try the varlen variants. The QKV will contain embeddings for ['a', 'b, 'c', 'eos', 'd', 'e', 'f', 'eos'] and you pass in cu_seqlens = [0, 4, 8] to tell the function that there are 2 sequences, one from position 0 to 3, and one from position 4 to 7.

Okay, thank you very much. Can I also pass multiple samples as a batch? And is there documentation for those functions anywhere?

Should be in the docstring.

Okay, so if I have a batch [['a', 'b, 'c', 'eos', 'd', 'e', 'f', 'eos'], ['a', 'eos', 'b', 'eos', 'c', 'd', 'e', 'eos']], cu_seqlens would be [[0,4, 8], [0,2, 4, 8]] but I can't put these values into a tensor. Will it be [[0,4, 8, 8], [0,2, 4, 8]] or [[0,4, 8, -1], [0,2, 4, 8]] or something different?

You can just have a batch with 5 examples ['a', 'b, 'c', 'eos'] ['d', 'e', 'f', 'eos'] ['a', 'eos'] ['b', 'eos'] ['c', 'd', 'e', 'eos']
cu_seqlens = [0, 4, 8, 10, 12, 16].

See https://github.com/Dao-AILab/flash-attention/issues/432#issuecomment-1698610752


'ChatOllama' object has no attribute 'bind_tools'

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
from dotenv import load_dotenv
from langchain_community.chat_models import ChatOllama
from langchain_community.tools import DuckDuckGoSearchRun
from langchain_community.utilities import DuckDuckGoSearchAPIWrapper
from transformers import AutoTokenizer
from langchain.tools import Tool

load_dotenv()
hf_token = os.environ.get("HF_TOKEN")
llm = ChatOllama(model="qwen:14b")
tokenizer = AutoTokenizer.from_pretrained("Qwen/Qwen1.5-14B", token=hf_token)
search_wrapper = DuckDuckGoSearchAPIWrapper(region="en-us", max_results=5)
# Set up the DuckDuckGo search tool
search_tool = DuckDuckGoSearchRun(verbose=True, api_wrapper=search_wrapper)

# Set up the search tools list
search_tools = [
    Tool(
        name="Search",
        func=search_tool.run,
        description="Use the DuckDuckGo search engine to find information",
    ),
]

llm_with_tools = llm.bind_tools(tools=search_tools)

Error Message and Stack Trace (if applicable)
AttributeError                            Traceback (most recent call last)
Cell In[1], [line 26](vscode-notebook-cell:?execution_count=1&line=26)
     [17](vscode-notebook-cell:?execution_count=1&line=17) # Set up the search tools list
     [18](vscode-notebook-cell:?execution_count=1&line=18) search_tools = [
     [19](vscode-notebook-cell:?execution_count=1&line=19)     Tool(
     [20](vscode-notebook-cell:?execution_count=1&line=20)         name="Search",
   (...)
     [23](vscode-notebook-cell:?execution_count=1&line=23)     ),
     [24](vscode-notebook-cell:?execution_count=1&line=24) ]
---> [26](vscode-notebook-cell:?execution_count=1&line=26) llm_with_tools = llm.bind_tools(tools=search_tools)

AttributeError: 'ChatOllama' object has no attribute 'bind_tools'

Description
In the docs for ChatOllama it says there is the method bind_tools() here. When I attempt to run the Ollama instance and bind the search tool it throws the AttributeError saying it has no attribute 'bind_tools'
System Info
System Information

OS:  Darwin
OS Version:  Darwin Kernel Version 23.4.0: Fri Mar 15 00:10:42 PDT 2024; root:xnu-10063.101.17~1/RELEASE_ARM64_T6000
Python Version:  3.12.2 | packaged by conda-forge | (main, Feb 16 2024, 20:54:21) [Clang 16.0.6 ]

Package Information

langchain_core: 0.1.40
langchain: 0.1.14
langchain_community: 0.0.31
langsmith: 0.1.38
langchain_experimental: 0.0.56
langchain_text_splitters: 0.0.1

Packages not installed (Not Necessarily a Problem)
The following packages were not found:

langgraph
langserve

You can refer to this
https://python.langchain.com/docs/integrations/chat/

@natecard The documentation is out of sync with the code.
The addition of the the bind_tools interface (#20360) to the BaseChatModel (which ChatOllama subclasses) was merged after the last release of langchain-core (#20332). With the next release of langchain-core you should see a slightly more informative "Not Implemented" message.
All of which is to say that please check the page sent by @liugddx - hopefully one of the models that supports the bind_tools interface right now is available to you and can be used in your project.

Posted a PR to add bind_tools to OllamaFunctions
https://github.com/langchain-ai/langchain/pull/20881

reference for javascript implementation for bindtool?

There still is no bind_tools for ChatOllama in the latest version from today's github. Any suggestions how this can be implemented?

There still is no bind_tools for ChatOllama in the latest version from today's github. Any suggestions how this can be implemented?

bind_tools is included in OllamaFunctions which is part of the langchain-experimental package.
OllamaFunctions is an extension of ChatOllama for tool calling.
The latest version of the published package is still missing some functionality, however a PR #22339 was approved and merged today which fixes that.

Take a look at #22339 which should have addressed this issue.
The PR was approved and merged yesterday but a release is yet to be cut from it and should happen in the next few days.
In the meantime, you may try and install langchain-experimental directly from langchain's source like this:
pip install git+https://github.com/langchain-ai/langchain.git\#egg=langchain-experimental\&subdirectory=libs/experimental

I hope this helps.

thanks! is it possible to use FewShotPrompting with OllamaFunctions?

The Javascript SDK is also missing the implementation for tools using Ollama.

The official documentation says that ChatOllama supports bind_tools: https://python.langchain.com/v0.2/docs/integrations/chat/ollama/#tool-calling , is that true ? from my test it does not seem like it but i might have done something wrong.

The official documentation says that ChatOllama supports bind_tools: python.langchain.com/v0.2/docs/integrations/chat/ollama#tool-calling , is that true ? from my test it does not seem like it but i might have done something wrong.

are you sure you are pulling ChatOllama as in from langchain_ollama import ChatOllama with package langhain-ollama installed?

hmm I think I had an issue with my installations, that's what i imported from at the start but it did not work, so i switched back to from langchain_community.chat_models.ollama import ChatOllama and then i forgot i did this change.
thanks !

The official documentation says that ChatOllama supports bind_tools: https://python.langchain.com/v0.2/docs/integrations/chat/ollama/#tool-calling , is that true ? from my test it does not seem like it but i might have done something wrong.

are you sure you are pulling ChatOllama as in from langchain_ollama import ChatOllama with package langhain-ollama installed?

@natecard I think this resolves the issue.


Functions: isPerfectSquare problem

added some clarification language around the isPerfectSquare problem prompt

Specifically, I wanted to define "perfect squares" clearly for the folks who aren't necessarily math savvy and I wanted to strongly imply that the function should return a boolean

👍


docs: create manage keys admin doc

This comes out of the Rafiki work week.
The previous version of the docs had a page for "key registry". We need to determine if we:

still need this info
need this info in its own page, page named Manage Keys and placed in the Admin section
need to add anything to it

We'll need to talk about this some first, because the key registry is heavily on the Open Payments side of things, and we need to figure out whether we want to duplicate information between the two doc sets, or link to the OP docs from Rafiki.
http://web.archive.org/web/20240225131259/https://rafiki.dev/concepts/open-payments/key-registry/
Note that we also have https://rafiki.dev/integration/requirements/wallet-addresses/#create-a-wallet-address-key-pair.

Made a number of updates to the OP docs to support this issue, including adding the sequence diagram that was formerly in the Rafiki docs. https://github.com/interledger/open-payments/pull/516
Now we need to decide what to do with the Rafiki docs.


Question - Difference between AsyncCollection and AsyncProducerConsumerQueue

Hello,
If this has already been asked please point me there. The usual search tools didn't provide any result, so I am asking here.
In a typical Producer Consumer Scenario, AsyncEx Library offers the AsyncCollection and the AsyncProducerConsumerQueue. Per Default the AsyncColletion behaves as a Queue, so I am asking what exactly is the difference? Sure, the API is a little bit different, instead of "Add" there is "Enqueue", instead of "Take" there is "Dequeue".
Thanks for your help and thank you for the great Library. Also purchased your Book, which I highly enjoyed reading.
Regards,
Arne

I consider these both "historical" types, and recommend Channels for modern development.
AsyncProducerConsumerQueue<T> was designed as an async equivalent of ConcurrentQueue<T>. AsyncCollection<T> was designed as an async equivalent of BlockingCollection<T>.
Historically, AsyncProducerConsumerQueue<T> supported more platforms (Windows Phone Silverlight 7.5/8.0 and Silverlight 4/5), but these days those platforms are no longer supported anyway. AsyncCollection<T> is more complex since it does support non-FIFO storage.
Again, these days I would recommend Channels over both of these types for most scenarios.

Thank you very much for the quick response.


Fake

Description:
Implemented RandomUUID, RandomDate, RandomPhoneNumber, and RandomAddress functions in the new fake package.
Checklists:

[ ] Tests passing

If added a new utility function or updated existing function logic:

[ ] Added fake
[ ] Added fake
[ ] Updated readME.md
[ ] Updated go.mod

Summary by CodeRabbit

New Features

Introduced a new package for generating fake data with utilities for creating random UUIDs, dates, phone numbers, and addresses.
Added examples demonstrating the usage of the new functions in the documentation.

Bug Fixes

Implemented error handling in data generation functions to ensure reliability.

Tests

Added comprehensive tests for each new function to validate their output and format.

Documentation

Updated the README to include a new section detailing the fake data generation functions.
Expanded the EXAMPLES.md with usage examples for the new functions.

I'll approve once examples are added in the EXAMPLES.md

Will let Kashif review and merge. Thanks for the contribution.


What's up with Git version control addin?

Great work, @cra0zy! 👍
I also hope that Git version control addin will make it way to the installer in the one of the nearest releases.

The Git addin depends on some outdated libs, and it will cause some crashes to occur so I skipped adding it: https://github.com/cra0zy/monodevelop-run-installer/blob/master/generate.sh#L44
That being said MD 7.1 decided to go in a route that... well.. includes custom? msbuild, newest version of gtk-sharp-2, etc. so I don't think repackaging will be an option any longer :(

Sad news... I thought Xamarin ship newest versions of msbuild, gtk-sharp-2, etc. using its own Linux repositories!..

I have definitely phrased myself badly there, sorry, my thinking was more on these 2 points:

only xamarin repos contain the needed newest stuff (so only Ubuntu, Debian and CentOS can really get them installed... even Arch Linux doesn't have some of the stuff...)
with what they started they will probably start using some native stuff which some distros don't have

So in short, repackaging is possible right now, it already became a pain to setup on any Linux distro that xamarin does not provide a repo for, and it might become even more problematic down the line.
PS. They are not using custom msbuild, its just that msbuild is split in 2 packages in their repos, didn't notice it before.

I've updated the script for the latest MD, and also made some adjustments so that Git Version Control addin can be used.

Thanks! 👍


chore: support for running npm scripts in windows

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #7982
Resolve local 'npm run start' Out of Memory issue
What is the new behavior?
The 'npm run start' command now uses more memory to prevent out of memory errors.
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

Hi there, thank you for your suggestion!
I have already updated the package-lock.json file by running npm i cross-env --save-dev as you instructed.

@HyperLife1119 why do you add these commits?

@HyperLife1119 why do you add these commits?

I didn't do anything, maybe @wisenchen didn't rebase correctly.

@HyperLife1119 why do you add these commits?

I didn't do anything, maybe @wisenchen didn't rebase correctly.

@wisenchen Could you please rebase again and make this pr only include your commits?

@HyperLife1119 why do you add these commits?

I didn't do anything, maybe @wisenchen didn't rebase correctly.我什么都没做，也许@wisenchen没有正确地变基。

@wisenchen Could you please rebase again and make this pr only include your commits?
Sure, I apologize for the confusion earlier. I have corrected the issue by rebasing and ensuring that this pull request now only includes my commits.


Keep Metadata Near Content

Occasionally in the digest metadata such as timestamp, and username can get separated from its content by a page break. Is it possible to link them such that they will both get moved to the next page if they both cannot fit on the current page?

I've set the page-break-after, page-break-inside, break-after, and break-inside properties all to avoid for the metadata tag however it seems the epub-reader does not adhere to them :/


notifications: Provide desktop app inline notification reply data.

Testing Plan:
I pasted the script below into desktop app, more specifically Devtools of Active Tab when the development server running this PR's code is focused:
class TestNotification extends Notification {
  constructor(title, opts) {
      super(title, opts);

      const message_id = data.tag;
      const reply = '** *Reply for testing desktop app notification reply!* **';
      electron_bridge.send_event('send_notification_reply_message', message_id, reply);
  }
}

window.Notification = TestNotification;

Then in browser tab send Private and Group PM along with Stream message mentioning the user logged in to desktop app. It should send back Reply from desktop app inline notification reply and in the desktop app should narrow to the message.

This looks great, but I'm not sure about the variable names:
opts.inline_notification_data = desktop_inline_notification_data
I think maybe we want inline_reply_data?  I feel like the "reply" part is important for the "inline" making any sense.

@timabbott I updated this PR, the new version should make things a lot simpler. We now only have on event listener which takes message_id and reply and then just sends the message. For variable name's I went for notification_reply instead of inline_reply, since I agree the inline deesn't imply notification reply which is what this is.
Also, #796 is how it should work on desktop side just pass in message id and reply.

OK, this is great!  I'm ready to merge this code, but it'd be really nice if you added a unit test to frontend_tests/node_tests/notifications.js covering this code path as a follow-up.

Merged, thanks @priyank-p!

I can unit tests for this feature.


Simplify CI image build workflow before v1.15 branch

These files end up with massive diffs when trying to create a stable branch
from the main branch. With some minor care and attention, we can simplify the
steps to create a branch with identical workflows to the main branch.
See commits for more details:

.github: Remove branch names from step ids
.github: Only create Go cache for main branch push

CI passed with pull_request: https://github.com/cilium/cilium/actions/runs/7188393385?pr=29834
Dropping the test commit.


Category reordering

Describe the solution you'd like
It would be nice if one could reorder the categories.
Especially, I'd like the 'recent', to be shown first for example, if there are recents available

@michaelpomogajko check this: https://thewidlarzgroup.github.io/rn-emoji-keyboard/docs/api/modal#categoryorder

@efstathiosntonas the answer works! I've specified ['recently_used'] and it became first!