Create e2e test to make sure accounts are generated correctly

Validate the following situation:

Import account from seed phrase
create new account (Account 2)
create new account (Account 3)

now in other scenario

import account from same seed phrase as below
create a new account from a private key
create new account (Account 2)
create new account (Account 3)

the test should validate that Account 2 and  Account 3 are the same in both scenarios. cuz they are derivated from same root account with same seed phrase

closed in #1281


chore(docs): Minor updates to improve the API Reference

Hey, I just made a Pull Request!

TSDoc only changes to improve the API Reference in alignment with https://github.com/backstage/backstage/issues/7162.
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[ ] All your commits have a Signed-off-by line in the message. (more info)

Oh and we would need changesets for these changes to make it into the bundled type definitions, even though the microsite gets updated immediately


Caroline/single page

made a nice profile page

There's also other stuff to do with accepting the user's profile picture through maybe a CesnsoredUser as a prop (instead of just a preset image)?

There's also other stuff to do with accepting the user's profile picture through maybe a CesnsoredUser as a prop (instead of just a preset image)?

Yeah this need to request the api to get the current users information, you can look at any of my PRs for examples of how to use useAsync to request api.user().me()


fixes #74 fixes #75

fixes matteobortolazzo/HtmlLabelPlugin#74
fixes matteobortolazzo/HtmlLabelPlugin#75

You are welcome. Indeed I have to thank you for providing this package. It really helped me a lot quite some time ago.


Out of memory (and solution)

For some reason, I got consistent crashes ("out of memory") when trying to use this plugin. With debug-by-print, I was able to narrow down the bug to the while true loop in read_file, and specifically to the final line in that loop: https://github.com/nvim-telescope/telescope-bibtex.nvim/blob/master/lua/telescope/_extensions/bibtex.lua#L114
The crash always happened, but not always at the same point in the file. Sometimes it read more entries, sometimes fewer.
My target Zotero isn't that large --- about 5 MB --- so there should be plenty of memory (especially on my 32 GB RAM machine!).
Interestingly, I was able to fix (or work around) this problem by combining that while loop with the adjacent loop over entries, such that each raw entry is fully parsed right as it's read:
  local data = p:read()
  data = data:gsub('\r', '')
  local entry = ''
  while true do
    entry = data:match('@%w*%s*%b{}')
    if entry == nil then
      break
    end
    local label = entry:match('{%s*[^{},~#%\\]+,\n')
    if label then
       -- Do stuff...
    end
    data = data:sub(#entry + 2)
  end

With that fix, it takes a few seconds to do the initial parsing of the bibtex file, but after that, the package works exactly as I would have expected.
Relevant system information:
Windows Subsystem for Linux (v1)
Ubuntu 22.04
NVIM v0.10.0-dev

Thanks for pointing this out. I'd be happy to merge this fix. If you already have implemented it, can you open a PR?


Feature/search refactoring

Front page search now links to search page
Fixed search icon
Removed search from datatables on search page
If over 200 results, a message will be displayed (Is the message ok?)
Moved some of the helper/initialisation functions for search component to search service

Codecov Report

Merging #84 into develop will decrease coverage by 1.65%.
The diff coverage is 25.39%.

@@             Coverage Diff             @@
##           develop      #84      +/-   ##
===========================================
- Coverage    74.03%   72.37%   -1.66%
===========================================
  Files           81       82       +1
  Lines         1837     1904      +67
  Branches       225      237      +12
===========================================
+ Hits          1360     1378      +18
- Misses         327      376      +49
  Partials       150      150

Impacted Files
Coverage Δ

src/app/listentry/listentry.component.ts
44.73% <100%> (+1.49%)
:arrow_up:

src/app/search/search.service.ts
32.74% <23.33%> (-10.66%)
:arrow_down:

src/app/home/home.component.ts
84.61% <50%> (-6.3%)
:arrow_down:

src/app/shared/models/SubBucket.ts
50% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69e128e...9abdd75. Read the comment docs.


initial integration of redistimeseries

q1 to q10 supported

hi there @itamarhaber @danni-m and @yaeltzirulnikov ,
updated the branch with to make usage of the latest changes we've submitted to timescale.
cc @ashtul since this might be handy:
pre-steps:
Make sure redis-server is running with the correct module ( from with RedisTimeseries Folder run ):
redis-server --protected-mode no --save "" --appendonly no --loadmodule ./bin/macosx-x64-release/redistimeseries.so

To easily test this follow:

build the binaries

git clone https://github.com/RedisTimeSeries/tsbs/tree/redistimeseries
git checkout redistimeseries
make

generate the dataset
Generate the 30 days dataset that is the largest in terms of samples per time-series:

INTERLEAVED_GENERATION_GROUPS=8 DEBUG=3 TS_START=2016-01-01T00:00:00Z TS_END=2016-02-01T00:00:10Z FORMATS="redistimeseries" SCALE=100 SEED=123 scripts/generate_data.sh

generate the query set

QUERIES=10000 QUERY_TYPES="single-groupby-1-1-1 single-groupby-1-1-12 single-groupby-1-8-1 single-group by-5-1-1 single-groupby-5-1-12 single-groupby-5-8-1 cpu-max-all-1 cpu-max-all-8 double-groupby-1 double-groupby-5 double-groupby-all" TS_START=2016-01-01T00:00:00Z TS_END=2016-02-01T00:00:10Z FORMATS="redistimeseries" SKIP_IF_EXISTS=FALSE  SCALE=100 SEED=123 scripts/generate_queries.sh

real write/read performance starts here:

OSS Write performance

REPORTING_PERIOD=1s scripts/load_redistimeseries.sh

Output:
$ REPORTING_PERIOD=1s scripts/load_redistimeseries.sh
Bulk loading file /tmp/bulk_data/redistimeseries-data.gz
+ redis-cli -h localhost -p 6379 flushall
OK
+ redis-cli -h localhost -p 6379 config resetstat
OK
+ cat /tmp/bulk_data/redistimeseries-data.gz
+ gunzip
+ /Users/filipeoliveria/go/bin/tsbs_load_redistimeseries --workers=8 --batch-size=10000 --reporting-period=1s --host=localhost:6379 --connections=10 --pipeline=100
+ tee ./load_result_redistimeseries-data.out
time,per. metric/s,metric total,overall metric/s,per. row/s,row total,overall row/s
1574776556,795647.57,7.977500E+05,795647.57,79789.16,8.000000E+04,79789.16
1574776557,800016.50,1.597750E+06,797829.13,80001.65,1.600000E+05,79895.27
1574776558,801946.54,2.397750E+06,799198.18,80194.65,2.400000E+05,79994.81
1574776559,797471.55,3.197750E+06,798765.52,79747.15,3.200000E+05,79932.75
1574776560,1102593.81,4.297750E+06,859375.95,110259.38,4.300000E+05,85982.59
1574776561,1300430.59,5.597750E+06,932852.37,130043.06,5.600000E+05,93322.73
1574776562,799438.16,6.397750E+06,913783.57,79943.82,6.400000E+05,91410.49
1574776563,800761.02,7.197750E+06,899669.95,80076.10,7.200000E+05,89995.12
1574776564,796998.10,7.997750E+06,888224.34,79699.81,8.000000E+05,88847.42
1574776565,1304499.34,9.297750E+06,929705.14,130449.93,9.300000E+05,92993.01
1574776566,1099774.81,1.039775E+07,945167.84,109977.48,1.040000E+06,94537.24
1574776567,799856.91,1.119775E+07,933057.58,79985.69,1.120000E+06,93324.51
1574776568,796793.56,1.199775E+07,922537.73,79679.36,1.200000E+06,92271.07
1574776569,803864.63,1.279775E+07,914102.04,80386.46,1.280000E+06,91426.28
1574776570,798473.46,1.359775E+07,906379.90,79847.35,1.360000E+06,90652.99
1574776571,1603382.13,1.519775E+07,949850.23,160338.21,1.520000E+06,94999.09
1574776572,798964.78,1.599775E+07,940963.87,79896.48,1.600000E+06,94109.62
1574776573,798643.16,1.679775E+07,933045.12,79864.32,1.680000E+06,93317.01
1574776574,801342.84,1.759775E+07,926125.57,80134.28,1.760000E+06,92624.40
1574776575,801034.90,1.839775E+07,919879.17,80103.49,1.840000E+06,91999.17
1574776576,1595296.73,1.999775E+07,952131.93,159529.67,2.000000E+06,95223.91
1574776577,802335.81,2.079775E+07,945342.91,80233.58,2.080000E+06,94544.52
1574776578,799885.95,2.159775E+07,939017.89,79988.59,2.160000E+06,93911.57
1574776579,796192.98,2.239775E+07,933039.68,79619.30,2.240000E+06,93313.34
1574776580,803835.20,2.319775E+07,927896.23,80383.52,2.320000E+06,92798.62
1574776581,1400101.98,2.459775E+07,946056.46,140010.20,2.460000E+06,94614.30
1574776582,1000001.37,2.559775E+07,948054.39,100000.14,2.560000E+06,94813.77
1574776583,796621.63,2.639775E+07,942624.03,79662.16,2.640000E+06,94270.44
1574776584,802334.74,2.719775E+07,937800.81,80233.47,2.720000E+06,93787.84
1574776585,798733.65,2.799775E+07,933158.39,79873.37,2.800000E+06,93323.34
1574776586,1103266.16,2.909775E+07,938629.45,110326.62,2.910000E+06,93870.20
1574776587,1295939.52,3.039775E+07,949829.19,129593.95,3.040000E+06,94989.95
1574776588,802550.26,3.119775E+07,945380.40,80255.03,3.120000E+06,94544.86
1574776589,796218.20,3.199775E+07,940973.08,79621.82,3.200000E+06,94103.92
1574776590,803854.74,3.279775E+07,937074.22,80385.47,3.280000E+06,93713.85

Summary:
loaded 33480130 metrics in 35.025sec with 8 workers (mean rate 955882.34 metrics/sec)
loaded 3348238 rows in 35.025sec with 8 workers (mean rate 95594.66 rows/sec)
+ redis-cli -h localhost -p 6379 info commandstats
+ redis-cli -h localhost -p 6379 info commandstats
# Commandstats
cmdstat_config:calls=1,usec=10,usec_per_call=10.00
cmdstat_ts.madd:calls=3347988,usec=11791414,usec_per_call=3.52
cmdstat_ts.add:calls=250,usec=10359,usec_per_call=41.44
cmdstat_info:calls=1,usec=21,usec_per_call=21.00

OSS Read performance

REPORTING_PERIOD=1s scripts/run_queries_redistimeseries.sh

Output:
(...)
Running queries_redistimeseries_single-groupby-5-8-1__10000_100_123_2016-01-01T00:00:00Z_2016-02-01T00:00:10Z_cpu-only.dat.gz
Saving output to /tmp/results_queries/result_queries_redistimeseries_single-groupby-5-8-1__10000_100_123_2016-01-01T00:00:00Z_2016-02-01T00:00:10Z_cpu-only.dat.out
Saving HDR Latencies to /tmp/results_queries/HDR_TXT_result_queries_redistimeseries_single-groupby-5-8-1__10000_100_123_2016-01-01T00:00:00Z_2016-02-01T00:00:10Z_cpu-only.dat.out
Run complete after 10000 queries with 8 workers (Overall query rate 612.44 queries/sec):
RedisTimeSeries 5 cpu metric(s), random    8 hosts, random 1h0m0s by 1m:
min:     0.42ms, med:     4.39ms, mean:     6.14ms, max:  402.11ms, stddev:    18.35ms, sum:  61.4sec, count: 10000
all queries                                                            :
min:     0.42ms, med:     4.39ms, mean:     6.14ms, max:  402.11ms, stddev:    18.35ms, sum:  61.4sec, count: 10000
Saving High Dynamic Range (HDR) Histogram of Response Latencies to /tmp/results_queries/HDR_TXT_result_queries_redistimeseries_single-groupby-5-8-1__10000_100_123_2016-01-01T00:00:00Z_2016-02-01T00:00:10Z_cpu-only.dat.out
wall clock time: 16.359547sec
# Commandstats
cmdstat_config:calls=1,usec=10,usec_per_call=10.00
cmdstat_ts.mrange:calls=10000,usec=5679593,usec_per_call=567.96
cmdstat_info:calls=1,usec=16,usec_per_call=16.00

@filipecosta90 thats a lot of code :)
Generally this looks good, when we extend this and try to use more shards we might hit a CPU bottleneck and we would need to consider maybe using https://github.com/mediocregopher/radix.

I agree with you @danni-m . My main goal as for now is to support all queries for this use case and afterward get new values, and optimize if required. btw the optimizations will need to be in place in redistimeseries-go (so upstream ) when we officially do an external PR. So we can consider this an intermediate state.


Speeding up fetching geo boundaries

So far we're fetching boundaries from unpkg but:

we can't control the request headers
we're seeing is that the first time we access the app, unpkg seems to take a bit longer than next sessions, probably because it needs to cache the files (which requires fetching them from npm then sending them to the client, npm -> unpkg + unpkg -> client).

To speed things up we might want to:

have a script that fetches and stores all NUTS boundaries to static/
have the app fetching use those boundaries from static instead of those provided on unpkg.com
setup custom headers for client caching

duplicate of #239, closing


Breaks the latest Quickstart (Angular 2.0)

Hello,
I'm trying to use ngrx/store with the final Angular 2.0 release, but it generates a weird error, probably related to dependencies:
zone.js:1263 GET http://localhost:3000/traceur 404 (Not Found)
(index):18 Error: Error: XHR error (404 Not Found) loading http://localhost:3000/traceur(…)

Removing the catch() function from the SystemJS bootstrap I get a more useful error:
Error loading<EMAIL_ADDRESS>as "@ngrx/store" from http://localhost:3000/dist/app.module.js ;

Example
I set up a minimal example forking Angular 2 Quickstart and adding just one reducer and the ngrx import in the ngModule file:

my current branch
the diff with Quickstart

System information

node: v4.5.0
npm: v2.15.9
Chrome: 52.0.2743.116
OS/X Yosemite 10.10.5

Thank you for helping,
Pietro

Sorry, it turns out that it was my mistake in system.config.js. Rather than mapping the ngrx modules to the new bundles/*.umd.js standard, I was still using index.js.
This correction fixed my issue:
System.config({
    // ...
    packages: {
           // ...
            '@ngrx/core':                   { main: 'bundles/core.umd.js', defaultExtension: 'js' },
            '@ngrx/store':                  { main: 'bundles/store.umd.js', defaultExtension: 'js' }

Can I point out that the error handling of SystemJS is everything but meaningful?

Had the same issue. Your fix worked. Thank you!


date filter in the excel is not working when I use XLSX.utils.json_to_sheet(res).

I am not able to filter the date column when I use XLSX.utils.json_to_sheet(response). I can only filter based on all the dates, but the actual behavior should be according to year and according to the months. Can anybody help asap.

I'm having the same problem! Did you find the solution? @Ashab31

That looks like the column is text.  json_to_sheet does not automatically convert text-containing-dates into numeric or date cells -- they are still text.  You need to go back and convert strings to dates:
var fixed_data = response.map(row => Object.assign({}, row, {Request: new Date(row.Request)}));
var ws = XLSX.utils.json_to_sheet(fixed_data);


[Project Addition] : Pharmaceutical Drugs and Vitamins Images Detection

Deep Learning Simplified Repository (Proposing new issue)
:red_circle: Project Title : Pharmaceutical Drugs and Vitamins Images Detection
:red_circle: Aim : The below dataset includes images of popular pharmaceutical drugs and vitamins in the Philippines. This is dataset can be used for classifying drug images using CNN and transfer learning. Currently, there are ten available classes of pill images.
:red_circle: Dataset : https://www.kaggle.com/datasets/vencerlanz09/pharmaceutical-drugs-and-vitamins-synthetic-images
:red_circle: Approach : Try to use 3-4 algorithms to implement the models and compare all the algorithms to find out the best fitted algorithm for the model by checking the accuracy scores. Also do not forget to do a exploratory data analysis before creating any model.

📍 Follow the Guidelines to Contribute in the Project :

You need to create a separate folder named as the Project Title.
Inside that folder, there will be four main components.

Images - To store the required images.
Dataset - To store the dataset or, information/source about the dataset.
Model - To store the machine learning model you've created using the dataset.
requirements.txt - This file will contain the required packages/libraries to run the project in other machines.

Inside the Model folder, the README.md file must be filled up properly, with proper visualizations and conclusions.

:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Follow Contributing Guidelines & Code of Conduct before start Contributing.

:white_check_mark: To be Mentioned while taking the issue :

Full name : Aaradhya Singh

GitHub Profile Link : https://github.com/kyra-09

Email ID<EMAIL_ADDRESS>

Participant ID (if applicable):

Approach for this Project :

Utilizing 5 models such as DenseNet121 , Xception, VGG16, ResNet50, and InceptionV3 for image classification.
I'll also be using Yolov5 to annotate the images.
Applying data augmentation (rotation, zooming, flipping, shearing, brightness) to enhance dataset robustness.
Comparing model performance using accuracy scores, loss/accuracy graphs, and confusion matrices.
Conducting EDA for dataset insights, including image distribution, quality, class imbalances, and sample visualization.
Documening the process in a comprehensive README file.

What is your participant role? (Mention the Open Source program) - GSSOC-2024 Contributor

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

Hi @kyra-09 assigning this issue to you.


Add version number and potentially other data to splash screen

Change "Starting . . ." to "Starting SemVer 2.6.0 . . ." or something of the sort


trainer.save_model(“gs://*****/“) doesn’t save the mode in GCP bucket?

Expected Behavior
The model should be saved in GCP bucket using trainer function.
Actual Behavior
The model is not saved.
Steps to Reproduce the Problem
train.py inside Custom Container
training_args = tr.TrainingArguments(

     output_dir='gs://****/results_mlm_exp2'
    ,logging_dir='gs://****/logs_mlm_exp2'        # directory for storing logs
    ,save_strategy="epoch"
    ,learning_rate=2e-5
    ,logging_steps=2000
    ,overwrite_output_dir=True
    ,num_train_epochs=20
    ,per_device_train_batch_size=4
    ,prediction_loss_only=True
    ,gradient_accumulation_steps=16

)
trainer = tr.Trainer(
    model=model,
    args=training_args,
    data_collator=data_collator,
    train_dataset=train_data
)
# print("training to start without bf16")
trainer.train()
trainer.save_model("gs://****/model_mlm_exp2")

Hi @pratikchhapolika , is this code from a notebook in this repo?

I checked  (using grep) if any of our notebooks have the code sequence: trainer.save_model. No do. I am closing this issue as not an issue on our content.


Open Source Api Portal

Hi, we would like to follow approach of Zalando's API development model. It would be cool if Api Portal can be open sourced. Any plan for it?

Hi, thank you for your interest. However, we do not plan to open source the API Portal -- it has too many dependencies to Zalando specific (infrastructure) aspects and is not designed as a general purpose portal.


standalone remote ng app - error loading

Hello,
having some issues trying to load a standalone remote app into shell
Shell code:
https://github.com/mirzinho/microFrontEnds
works perfectly
Standalone app
https://github.com/mirzinho/ngHello
based on
https://github.com/manfredsteyer/angular-app1
Router on shell:
{
    path: 'hello',
    component: WebComponentWrapper,
    data: {
      remoteEntry: 'http://localhost:5000/remoteEntry.js',
      remoteName: 'hello',
      exposedModule: './web-components',
      elementName: 'hello-app'
    } as WebComponentWrapperOptions
  }

Standalone app serves and loads in browser with no issues, but when i try to load it into the shell i get these errors:

Hello,
I managed to resolve this issue by adding
module.exports = {
  output: {
    uniqueName: "hello",
    publicPath: "auto",
    scriptType: 'text/javascript'
  }
  ...
}

And changing bootstrap.ts file to this code on both shell and remote app.
import {enableProdMode, VERSION} from '@angular/core';

import { AppModule } from './app/app.module';
import { environment } from './environments/environment';
import {platformBrowser} from "@angular/platform-browser";

if (environment.production) {
  enableProdMode();
}

const ngVersion = VERSION.full;

(window as any).plattform = (window as any).plattform || {};
let platform = (window as any).plattform[ngVersion];
if (!platform) {
  platform = platformBrowser();
  (window as any).plattform[ngVersion] = platform;
}

platform.bootstrapModule(AppModule)
  .catch((err: any) => console.error(err));

Apparently this issue appears if the shell and remote app have the identical version of angular.
@manfredsteyer can you confirm or clarify this.
Thank you


replace "endianess" with "byteorder" in SegyAbstractHeader

"byteorder" makes more sense. "endianess" is a made up word!

@anthonytorlucci can I work on this ?

@anthonytorlucci can I work on this ?

Thank you for taking an interest @karthikmurali60, but I'm not quite ready to take on contributors. I will begin working on a contributor guide soon.

completed version 0.2.1


calls async_forward_entry_setup stop working in Home Assistant 2025.1.

Registratore: homeassistant.helpers.frame
Fonte: helpers/frame.py:151
Prima occorrenza: 10:13:11 (4 occorrenze)
Ultima registrazione: 10:13:11
Detected code that calls async_forward_entry_setup for integration dpc with title: Home and entry_id: 898c14588c83e4ee636685db4bad6bd6, during setup without awaiting async_forward_entry_setup, which can cause the setup lock to be released before the setup is done. This will stop working in Home Assistant 2025.1. Please report this issue.
after update HA to 2024.7.0

The issue could be resolved in replacing the statement here below in the init.py line 73
old            hass.async_create_task(hass.config_entries.async_forward_entry_setup(entry, platform))
new           await hass.config_entries.async_forward_entry_setup(entry, platform)

Done!. Thank you so much @micium

the correct statement is:
await hass.config_entries.async_forward_entry_setups(entry, [platform])
"platform" in square brackets


Don't send empty team_id in Slack-format outgoing webhooks, when string_id empty

Discussed here: https://chat.zulip.org/#narrow/stream/127-integrations/topic/gitlab.20slash.20commands/near/1247658
On a single-realm server slack-compatible outgoing webhook sends an empty team_id.
GitLab's Slack slash commands, for example, relies on the team_id field being non-empty.

Thanks for the report @esamson!  I've opened a pull request with what I believe to be the correct fix for this.  It'd be amazing if you could test the changes on your Zulip server; I'll ping you in chat.zulip.org to discuss details of doing that.


[SLAM]Should get reject promise when invoke  loadOccupancyMap()/loadRelocalizationMap() without parameter

According spec:
Promise<void> loadOccupancyMap(String mapFileName);
Promise<void> loadRelocalizationMap(String mapFileName);

Method should have a mandatory parameter input, when missing it, method should return reject promise
Test Code:
let argv = '/tmp/loadOccupancyMap.map';
     slamAddon.createInstance().then((Instance) => {
        slamInstance = Instance;
        return slamInstance.start();
      }).then(() => {
        return slamInstance.saveOccupancyMap(argv);
      }).then(() => {
        return slamInstance.loadOccupancyMap();
      }).then((Data) => {
        reject('Promise should reject, but got resolved');
      }).catch((err) => {
        resolve();
      });

Result:
Error: the string "Promise should reject, but got resolved" was thrown, throw an Error :)

As #153 merged, please double check if this bug still exist. @zhaoming0 Thanks!

@lisa0314 and @DonnaWuDongxia , this issue could reproduce on 0.10.0 pre-release.
Case located at https://github.com/01org/node-realsense/blob/master/src/slam/test/Instance/test-loadOccupancyMap.js#L52, please remove the ".skip" when you try it.

@haoyunfeix we changed the interface, https://github.com/01org/node-realsense/blob/master/src/idl/slam/slam.widl#L129, only two interfaces(getOccupancyMap[Update] ) have optional arguments, so the test cases should be modified accordingly.

@DonnaWuDongxia - This is a Negative test case, we specially design it to see what will happen when call a method without "Mandatory" argument. We expected to receive "reject" promise in this pattern.

Verified with @kenny-y that we need to modify the WILD-NAN tool to fix this bug, so move it out of this milestone.


Register re-entrancy and pulse values

There are two current (related) issues that I am aware of with respect to registers in the interpreter. One is that they are not executed as often as required due to the current change based execution approach taken by group simulation. Fortunately, this is a relatively easy fix as we simply need to ensure that as long as the register's write_en is high it gets executed at every cycle, even when there's no change. In the limit, perhaps it makes sense to separate combinational and non-combinational cells and mandate that the interpreter re-run all non-combinational cells on every tick, regardless of whether any input values have changed.
The second issue is that when a register's write signal is held high, we expect the done signal to be low for a cycle and then remain high for N+1 cycles where N is the number of cycles that the write_en signal remains high. Currently the register will output a new pulsevalue that overwrites the existing one and will in-fact cause the register's done signal to remain low until cycle N and then high on N+1. Obviously this is incorrect, though the fix is not immediately obvious to me.
Perhaps these should be two separate issues.

Sounds about right! For the first issue:

In the limit, perhaps it makes sense to separate combinational and non-combinational cells and mandate that the interpreter re-run all non-combinational cells on every tick, regardless of whether any input values have changed.

Is it correct to assert that this would be "just an optimization," and it would also be correct to rerun every component on every cycle, even if there's no change? If so, maybe it's a good idea to approach it that way to avoid premature optimization—that is, start by removing the change sensitivity altogether and then, if it becomes a bottleneck, come back along later and add the distinction for speed alone.

Yes I believe that is correct! I think it makes sense to de-complexify the simulation logic as described since it gives us fewer failure points initially.
As for the latter, I think executing a primitive could be done more directly with the environment as context to avoid incorrect value trampling, which, if we're clever could free the interpreter from needing to extract the input port values on its own.

This also gives me a good idea about how to unify group & continuous interpretation w/o significant code duplication


The Javascript tutorial doesn't work on Mac

It cause /proc/1/cgroup not found. The issue is fixed alread on this issue/pull request.
https://github.com/metaparticle-io/package/issues/9
However, the npm package seems not updated. Someone who is doing this tutorial might have a problem on Mac until now.
https://www.npmjs.com/package/@metaparticle/package

I'll try to push a new package soon.

I just pushed 0.3.0 to npm.

Thank you, @brendandburns ! I'll try that!

Closing since this is fixed (please re-open if you continue to see issues)


[WIP][first draft]translate installation, introduction, linear-networks, notation and preface to Chinese

The following chapters have been preliminarily translated:

Installation
Notation
Linear-networks

It will be further improved.
The following chapters have been simple polish based on machine translation results

Preface
Introduction

It looks like a short story and will take more time to translate.

We can leave aside the introduction chapter, which still requires major revisions

Job d2l-zh/PR-549/2 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-549/

Job d2l-zh/PR-549/3 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-549/

Job d2l-zh/PR-549/4 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-549/


Crash on tap -[UIGestureRecognizer _isExcludedByGesture:]

Thread : Crashed: com.apple.main-thread
0  libobjc.A.dylib                0x0000000194d6bbd0 objc_msgSend + 16
1  UIKit                          0x0000000187ea4330 -[UIGestureRecognizer _isExcludedByGesture:] + 464
2  UIKit                          0x0000000187e661a4 _UIGestureRecognizerUpdate + 936
3  UIKit                          0x0000000187ea282c -[UIWindow _sendGesturesForEvent:] + 1044
4  UIKit                          0x0000000187ea1ee4 -[UIWindow sendEvent:] + 660
5  UIKit                          0x0000000187e75120 -[UIApplication sendEvent:] + 264
6  UIKit                          0x00000001881162b8 _UIApplicationHandleEventFromQueueEvent + 15424
7  UIKit                          0x0000000187e73634 _UIApplicationHandleEventQueue + 1716
8  CoreFoundation                 0x00000001833b4240 CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION + 24
9  CoreFoundation                 0x00000001833b34e4 __CFRunLoopDoSources0 + 264
10 CoreFoundation                 0x00000001833b1594 __CFRunLoopRun + 712
11 CoreFoundation                 0x00000001832dd2d4 CFRunLoopRunSpecific + 396
12 GraphicsServices               0x000000018cbe36fc GSEventRunModal + 168
13 UIKit                          0x0000000187edaf40 UIApplicationMain + 1488
14 InfinityNovita                 0x00000001000756bc main (main.m:16)
15 libdyld.dylib                  0x0000000195402a08 start + 4
That's the log of the error. I even tried to use this library on a brand new clean project. It just crashes whenever I tap the photo. I tried portrait mode, landscape mode, iPhone, iPad. Always same crash.

This is because the view on which gesture is added is released before action is performed of gesture's selector, either remove the added gesture in viewWillDisappear method or do not call any selector (popViewController or dismissViewController ) until gesture's selector is performed by the user

@albyok Guessing you have already figured this out since it was from a while ago, but seems like the suggestion by @AkshayHastekar may do the trick. Sounds like there may be an issue in how you're setting up and retaining your views and initial tap gesture recognizers that could be resulting in the crash.


use transform-class-properties and support component unmount

Noticed that plaid link would throw out an error when unmounted before onScriptLoaded() gets called.
Also noticed that transform-class-properties is being used in .babelrc so figured take advantage of that.

This should be fixed now in https://github.com/plaid/react-plaid-link/pull/81/
v2.0.0 was just released, so please test it out by checking the updated README and let me know!
There's also a storybook to test using Hooks and the Component wrapper:
https://plaid.github.io/react-plaid-link


Retrieve a single a customer

Codecov Report

Merging #135 (03cc766) into master (a7b2d7d) will decrease coverage by 1.41%.
The diff coverage is 44.44%.

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
- Coverage   97.88%   96.47%   -1.42%
==========================================
  Files           8        8
  Lines         331      340       +9
==========================================
+ Hits          324      328       +4
- Misses          7       12       +5

Impacted Files
Coverage Δ

service/routes.py
96.55% <44.44%> (-3.45%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vrangr1 I deleted the duplicate code


restore original folder resolution but leave path.join

Undo change in folder path resolution introduced in https://github.com/pyros2097/rust-embed/commit/f7cc15722d0b9d93cfe3ff4481a46f4823ce7e75 but leave let file_path = Path::new(#folder_path).join(file_path); to fix #30.

LGTM! @vemoo thanks.


Add Netty 5 HttpClient implementation

We should begin the investigation and development of a Netty 5 HttpClient implementation. Ideally it would reuse much of the code already developed for Netty 4, but with the newer dependency. We should not baseline on this as our new HTTP client, as it pushes the JDK baseline to JDK 11, I believe.

btw, what about a HttpClient implementation based on spring's WebClient

btw, what about a HttpClient implementation based on spring's WebClient

Let's chat about this and, if appropriate, create a new issue for this request. If you think it would play more nicely in a Spring context, let's discuss and plan for that!

Adding Azure.Core.V2 label


<EMAIL_ADDRESS>

See https://github.com/microsoft/node-pty/pull/487

There's something wrong here, integration tests fail on Linux and macOS; terminal seems to be broken.


Adding Governance Competency to the Maturity Doc

Article suggestion
On https://github.com/MicrosoftDocs/microsoft-365-community/blob/live/Community/microsoft365-maturity-model--intro.md  I would like to recommend a "Governance competency" unless folks feel it falls under (or is already covered!) in one of the other sections.  Within Governance would be the Licensing Competency as in "not afraid of the licensing" as was put in a SIG discussion but, more importantly, UNDERSTANDING so that it does not become a bottle neck for adoption and implementation.  Thoughts @sympmarc and Co, ?

Hello Ralph,
Great question! We started by trying to embed them in each competency (ex: Communication- https://docs.microsoft.com/en-us/microsoft-365/community/microsoft365-maturity-model--communication). Our focus was to first see if it can be covered within each competency with the intention to revisit once all are done as we might need a standalone governance competency like you are suggesting. Are there some specific topics you'd like covered in this? Would love to hear your thoughts as this might push us in a specific direction :)
Cheers,
Emily

It's a great point Ralph
Governance is one of those things that appears as both a top down and bottom up. We debated having it as a competency in its own right, took the decision to try and embed it as characteristics in many of the competencies but have as something we might come back to as a standalone competency too. The same is somewhat true of security.
We would be very interested in what you would see in the Governance Competency. Your thoughts will help us get our creative juices flowing. So please start throwing your thoughts on what it encompasses and what some characteristics might be...
and thanks for the feedback!

I waited for awhile to see what has evolved since this posting to give a chance for the community to coalesce on this given the key importance of Governance in its own right ... Also, I have changed to a job where I get to look at this more "en masse" for very large organizations where you would think it is embraced on its own as part of their corporate cultures .., it turns out the results are mixed even at that level!   As we are focused on M365 Maturity rather than "Organizational Maturity", we seem to be addressing the governance points pretty well with my only main suggestion perhaps for the overview is to discuss the concept of "agnostic" Maturity either as a precursor or the CAVEAT (yes, the caveat) for achieving the levels here .. all fine and dandy to follow all the items here but if your own corporate culture mandates the undoing or downplaying of your M365 achievements, you might as well not bothered to begin the journey.  I am seeing "self sabotage" where one group is diligently moving forward to be the best of the best with another hell bent on stopping them because the change is NOT in their interest  ....  It almost feels like a Harvard Business Review article or Ted Talk and not the purview of a doc.microsoft.com missive as it even feels preachy to me :)   ... Let me know if we should keep the issue open for further discussion or just call it a day with some action we can post separately and more specifically.


Severe Remote Code Execution vulnerability

The article at https://thehackernews.com/2022/04/critical-chipset-bug-opens-millions-of.html
reported on a severe security vulnerability in this repository, but I see no mention here about it.
The master branch has seen no updates in 6 years. Have the vulnerabilities been patched?
https://nvd.nist.gov/vuln/detail/CVE-2021-0674
https://nvd.nist.gov/vuln/detail/CVE-2021-0675
https://nvd.nist.gov/vuln/detail/CVE-2021-30351

After some short fuzzing sessions, they have definitely not been patched. The issues also run deeper and exist at many spots in the code (and additionally can cause double-free besides the out of bound read/writes).
Gave up trying to fully patch this walking colander for personal projects, frameLength too small causes double-free on deletion of the decoder.
Additionally, other places exist where bound checking is not done, and values coming from bitstream are fully trusted.
diff --git a/codec/ALACBitUtilities.c b/codec/ALACBitUtilities.c
index 9414889..92a2c21 100644
--- a/codec/ALACBitUtilities.c
+++ b/codec/ALACBitUtilities.c
@@ -37,6 +37,8 @@ void BitBufferInit( BitBuffer * bits, uint8_t * buffer, uint32_t byteSize )
 	bits->byteSize	= byteSize;
 }

+#define AssertBufferReadBounds(b, n) RequireAction( b->end >= (b->cur + ((b->bitIndex + n) / 8 + ((b->bitIndex + n) % 8 > 0))), return 0; );
+
 // BitBufferRead
 //
 uint32_t BitBufferRead( BitBuffer * bits, uint8_t numBits )
@@ -45,6 +47,8 @@ uint32_t BitBufferRead( BitBuffer * bits, uint8_t numBits )

 	//Assert( numBits <= 16 );

+	AssertBufferReadBounds(bits, numBits)
+
 	returnBits = ((uint32_t)bits->cur[0] << 16) | ((uint32_t)bits->cur[1] << 8) | ((uint32_t)bits->cur[2]);
 	returnBits = returnBits << bits->bitIndex;
 	returnBits &= 0x00FFFFFF;
@@ -55,7 +59,7 @@ uint32_t BitBufferRead( BitBuffer * bits, uint8_t numBits )

 	bits->cur		+= (bits->bitIndex >> 3);
 	bits->bitIndex	&= 7;
-
+
 	//Assert( bits->cur <= bits->end );

 	return returnBits;
@@ -69,6 +73,8 @@ uint8_t BitBufferReadSmall( BitBuffer * bits, uint8_t numBits )
 	uint16_t		returnBits;

 	//Assert( numBits <= 8 );
+
+	AssertBufferReadBounds(bits, numBits)

 	returnBits = (bits->cur[0] << 8) | bits->cur[1];
 	returnBits = returnBits << bits->bitIndex;
@@ -92,6 +98,8 @@ uint8_t BitBufferReadOne( BitBuffer * bits )
 {
 	uint8_t		returnBits;

+	AssertBufferReadBounds(bits, 8)
+
 	returnBits = (bits->cur[0] >> (7 - bits->bitIndex)) & 1;

 	bits->bitIndex++;
diff --git a/codec/ALACDecoder.cpp b/codec/ALACDecoder.cpp
index ce3340d..c8f0d17 100644
--- a/codec/ALACDecoder.cpp
+++ b/codec/ALACDecoder.cpp
@@ -128,8 +128,13 @@ int32_t ALACDecoder::Init( void * inMagicCookie, uint32_t inMagicCookieSize )
         theConfig.sampleRate = Swap32BtoN(((ALACSpecificConfig *)theActualCookie)->sampleRate);

         mConfig = theConfig;
-
+
+		//sanity checks
         RequireAction( mConfig.compatibleVersion <= kALACVersion, return kALAC_ParamError; );
+		RequireAction( mConfig.bitDepth == 16 || mConfig.bitDepth == 20 || mConfig.bitDepth == 24 || mConfig.bitDepth == 32, return kALAC_ParamError; );
+		RequireAction( mConfig.frameLength > 0 && mConfig.frameLength <= 16384, return kALAC_ParamError; );
+		RequireAction( mConfig.sampleRate > 0 && mConfig.sampleRate <= 384000, return kALAC_ParamError; );
+		RequireAction( mConfig.numChannels > 0 && mConfig.numChannels < kALACMaxChannels, return kALAC_ParamError; );

         // allocate mix buffers
         mMixBufferU = (int32_t *) calloc( mConfig.frameLength * sizeof(int32_t), 1 );
@@ -251,6 +256,8 @@ int32_t ALACDecoder::Decode( BitBuffer * bits, uint8_t * sampleBuffer, uint32_t
 				{
 					numSamples  = BitBufferRead( bits, 16 ) << 16;
 					numSamples |= BitBufferRead( bits, 16 );
+
+					RequireAction( numSamples <= mConfig.frameLength, status = kALAC_ParamError; goto Exit; );
 				}

 				if ( escapeFlag == 0 )
@@ -402,6 +409,8 @@ int32_t ALACDecoder::Decode( BitBuffer * bits, uint8_t * sampleBuffer, uint32_t
 				{
 					numSamples  = BitBufferRead( bits, 16 ) << 16;
 					numSamples |= BitBufferRead( bits, 16 );
+
+					RequireAction( numSamples <= mConfig.frameLength, status = kALAC_ParamError; goto Exit; );
 				}

 				if ( escapeFlag == 0 )

They're not patched.
I did a quick fuzz run ca. 20 hours ago and rediscovered CVE-2021-0674 CVE-2021-0675 almost instantly (few seconds)
In my case found out of bounds read in ALACEncoder (possibly CVE-2021-0674) and out of bounds write in DecodeALAC (possibly CVE-2021-0675)

They're not patched.
I did a quick fuzz run ca. 20 hours ago and rediscovered CVE-2021-0674 CVE-2021-0675 almost instantly (few seconds)
In my case found out of bounds read in ALACEncoder (possibly CVE-2021-0674) and out of bounds write in DecodeALAC (possibly CVE-2021-0675)

In my testing, if frame sizes etc. are small enough but everything else is fine enough, ALACDecoder destructor will trigger a double-free but haven't checked further, afaik it's a corrupted allocation by an OOB write.

Good to know. Maybe it will help others.
Below is the OOB read in ALACEncoder (wav to caf)
=================================================================
==222777==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x621000002500 at pc 0x0000004e7ffe bp 0x7fff1f779130 sp 0x7fff1f779128
READ of size 8 at 0x621000002500 thread T0
    #0 0x4e7ffd in ALACEncoder::EncodeMono(BitBuffer*, void*, unsigned int, unsigned int, unsigned int) /src/fuzzers/alacfuzzer/alac/codec/ALACEncoder.cpp:850:36
    #1 0x4e84fe in ALACEncoder::Encode(AudioFormatDescription, AudioFormatDescription, unsigned char*, unsigned char*, int*) /src/fuzzers/alacfuzzer/alac/codec/ALACEncoder.cpp:1056:18
    #2 0x4d63a0 in EncodeALAC(_IO_FILE*, _IO_FILE*, AudioFormatDescription, AudioFormatDescription, int) /src/fuzzers/alacfuzzer/alac/fuzzer/main.cpp:491:21
    #3 0x4d36cb in main /src/fuzzers/alacfuzzer/alac/fuzzer/main.cpp:160:13
    #4 0x7f4542deb0b2 in __libc_start_main /build/glibc-sMfBJT/glibc-2.31/csu/../csu/libc-start.c:308:16
    #5 0x429109 in _start (/home/user/alacfuzzer+0x429109)

Ahh ... oh so even the convert-utility has a bug. So I found this one, not the CVE-2021-0675
(caf to wav)
=================================================================
==226015==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x625000002108 at pc 0x000000440f9e bp 0x7ffcadcedd50 sp 0x7ffcadced518
WRITE of size 8336 at 0x625000002108 thread T0
    #0 0x440f9d in fread (/home/user/convert-utility+0x440f9d)
    #1 0x4d7a2b in DecodeALAC(_IO_FILE*, _IO_FILE*, AudioFormatDescription, AudioFormatDescription, int, unsigned int) /src/fuzzers/alacfuzzer/alac/convert-utility/main.cpp:660:73
    #2 0x4d3901 in main /src/fuzzers/alacfuzzer/alac/convert-utility/main.cpp:173:13
    #3 0x7f8a56dfb0b2 in __libc_start_main /build/glibc-sMfBJT/glibc-2.31/csu/../csu/libc-start.c:308:16
    #4 0x429109 in _start (/home/user/convert-utility+0x429109)

0x625000002108 is located 0 bytes to the right of 8200-byte region [0x625000000100,0x625000002108)


Grid Align Feature

Grid Align Feature
This will make elements in a group align into a grid and resize the group element to wrap around them.
How should this feature be activated?

Key command
Dedicated button in pallete
Button appearing in floating menu or top right menu when multiple elements are selected.

We could simply use the GridSnapping feature of diagram-js for this.

The Grid Snapping feature is really nice!  Maybe in one of the readme's in any of the library repos
we should list all available extensions.
Yet, what I have a mind is a button that will grid snap all elements in a selection AND snap the box around it. Core or not?

Sounds like another cool extension to me 🚀🍾

I have uploaded the feature as a module in https://github.com/xanpj/postit-js-extensions

Cool! Thanks a lot 👍
I just added an extension section to the readme (https://github.com/pinussilvestrus/postit-js/commit/a847bbff46dada573a873d04fc3aba150f954a0e) and tweeted about it: https://twitter.com/lutki95/status/1272521690430550018
🚀


2.13 cross compile support

I have used the processors package quite a bit in projects of my own. It has recently become necessary to support Scala 2.13, so this PR does that. It is a relatively big PR, but unit tests work for 2.13, 2.12 and 2.11. I've tried to resist the temptation to make idiomatic or style changes (a few minor ones snuck in).
I've also tried to be conscious of the optimizations that have been part of the codebase. Sometimes it just wasn't reasonable. For instance overriding the HashMap class so you can change the initial capacity relies on functionality that isn't available in 2.13. In the cases where the optimization was not easily supported in 2.13, I opted for eliminating the optimization rather than adding to the version-specific code footprint.
The PR utilizes some adapter classes in version-specific source folders. I've worked to minimize the footprint of the version-specific code.

Added support for 2.13. The main source of trouble was from Scala's updated collections implementation
Substituted Map.mapValue for Map.map to assure cross platform integrity
Addressed deprecation wherever it could be done without breaking backwards builds
Made explicit calls to Array.toIndexedSeq, as the implicit conversion is both deprecated and slow
Procedure declaration style has been deprecated for a long time, I eliminated it wherever I found it.
Updated dependencies to be more modern wherever 2.13 support was unavailable
IMO the riskiest change is away from Array.view, which in 2.13 is both deprecated and uses a copy of the array, so some functions were broken (specifically, the norm method in WordEmbeddingsMap). In this case, I found the best way to update this so we could maintain the same performance characteristics, was to provide a version of norm that takes the sub-array indexes and work against the backing array.

Wow, nice!  It's going to take a lot of time to digest this.  It would have been nice to collaborate.  You couldn't have known, but we had a local branch, scala2.13, or two, scala3, already in the works that I just pushed for comparison.  I do not recall right away what was preventing the update.  It's probably time to revisit.

Thank you @thebrenthaines ! We will carefully look at this.

I've been working on reconciling the two sets of changes.  In many many cases they match and afterwards perhaps @thebrenthaines can look at the few that remain to see if the clulab's version is reasonable and avoid any forking.  I made the mistake of basing the Scala 3 branch off the 2.13 branch, so it would be useful to not switch to this branch so that continuing through to Scala 3 might be easier.  I especially appreciate the changes like
    for(i <- 0 until avgWeights.size) {
    // becomes
    for(i <- avgWeights.indices) {

and many replacements of string addition.

I've been working on reconciling the two sets of changes. In many many cases they match and afterwards perhaps @thebrenthaines can look at the few that remain to see if the clulab's version is reasonable and avoid any forking. I made the mistake of basing the Scala 3 branch off the 2.13 branch, so it would be useful to not switch to this branch so that continuing through to Scala 3 might be easier. I especially appreciate the changes like
    for(i <- 0 until avgWeights.size) {
    // becomes
    for(i <- avgWeights.indices) {

and many replacements of string addition.

I'm happy to take a look when you're ready. Just let me know and I'll jump on it.
I wonder if it would be worthwhile merging / rebasing the clulab 2.13 branch forward to the latest master first? (Maybe you've already done this locally). This PR is my second attempt at making processors compile with 2.13, the first was about 9 months ago and something popped up that made me say "screw it" ;). I can't recall what that was, but I had an unexpectedly straightforward time with the latest master branch, so...

I did merge master back into the 6-month-old Scala 2.13 branch first thing (and was reminded why it's not a good idea to wait so long) :-(

Yeah. I think we've all re-learned that lesson a few times. :) Let me know when the branch is ready and I'll take a look. I'm happy to help.

So I'd like to close this PR unmerged and substitute #661 in its place.  Even if the files were exactly the same, the commit history is different and that might eventually be important.  They are different, though, and I diffed all of them to see what I might have missed or should have been done differently.  Below is a summary of some of the things I noticed.  Right now the branch is compiling and testing cleanly, so it's OK to look at the code and send feedback.  I'm still going to do some regression and performance tests.

PR #658
PR #661
Notes

import scala.collection.BufferedIterator
import org.clulab.scala.BufferedIterator
org.clulab.scala is intended for code that smoothes out differences between Scala versions.

array.slice
import org.clulab.utils.ArrayViewimport org.clulab.utils.MutableArrayView
Check performance

HasParallelSupport
ThreadUtils
661 is less elegant, but interfaces better with our other projects, I think.

import scala.collection.JavaConverters._
import scala.jdk.CollectionConverters._
This may be foreshadowing Scala 3.

Stream
import org.clulab.scala.LazyList
Likewise

import org.scalatest.flatspec.AnyFlatSpecimport org.scalatest.matchers.should.Matchers
import org.scalatest.{FlatSpec, Matchers}
I avoided needing this change by holding back on the scalatest update.  A different round is planned for this.  This fix will be to inherit from Test as in this example.

toIndexedSeq
sometimes toSeq when possible
Check performance

So I'd like to close this PR unmerged and substitute #661 in its place. Even if the files were exactly the same, the commit history is different and that might eventually be important.

Works for me. Is there any work you deferred that you would like for me to look at? Thanks!


add allowSaveImage flag

@minestarks So this would be merged first, followed by the merge from https://github.com/nirajvenkat/qsharp/tree/unitaryhack into main right?


Thoughts: Synthetic Transaction Support?

My current org (and many previous places i've been a part of) have a need for a tool which can be used to drive synthetic transactions by applying an application level input on a schedule (much like registering a probe :p).  This service could measure latency/success of message processing (with a timeout).  In my head this service is different from a probe as it would potentially need to support many different application level protocols ie (send a message over cloud pub/sub, kakfa, nsq, sqs, grpc, http/json, etc)
I was imagining that the input would contain a unique id for each synthetic transaction and when the target service is finished processing it would make an RPC call with the transaction status back to this service:
The reason I'm wondering about this in cloudprober is because cloudprober has all the pieces for something like this:

config system
scheduling system
surfacer architecture
probe architecture

In order for something like above I imagine it would require some additional features like:

stateful storage of active synthetic transactions
grpc service for clients to modify synthetic transaction states (ie success/failure/completion)

@manugarg I would love to hear your thoughts on synthetic transactions and if cloudprober might be a home for features like this?

Ah i thu j

@dmicanzerofox Sorry, I completely forgot about this. About your proposal, we have internally been talking about adding ad-hoc probe execution capabilities (through a gRPC service) to cloudprober but haven't gotten around to designing and implementing it. Your sounds similar and makes sense to me.
Now that you closed this issue, did you think of some other ways of doing it? :)


Fix/carousel view error

Implemented Changes:
Fix carousel error: not displaying correctly when less than 4 concerts

It Will display 1, 2, or 3 cards depending on how many concerts does exist.

Before

After

@danifromecuador @rudicarrilloypr Hello guys, since we have collaborated on this project, I would like to share with you guys the changes I have implemented,  if you have time, take a look at the corrections I have made, if not, just ignore it. I'll merge all changes in 3 days.

Sure @Diegogagan2587 I'll be happy to review your PR


Refactor the project files et. al.

This PR:

Removes unnecessary package dependencies
Updates the tests and benchmarks to .NET Core 3.1, whose support ends by the end of 2022.
Multi-targets .NET Standard 2.0 and 2.1 on the main project to reduce transitive dependencies when used by newer frameworks.
Switches the project's license URL property to an SPDX license expression.
Removes some unnecessary and placeholder project properties.
Fixes some easy warnings.

Thanks a lot for the contribution!

The validation is failing. If you have time, could you please have a look at the failure? Otherwise I'll take a look later this week.


Disable Browse* debugger frame list menu options if method not visible

Per https://github.com/GemTalk/Jadeite/issues/765, disable debugger's frame Browse menu options if method isn't visible to the user.
The use case is to try browsing the upper frames of a server stack using services, say a method on RowanAnsweringService.

I don't understand why preventing browsing is the desirable behavior here. You do have the method object and therefore the class object. They could be browsed.

@rjsargent Yes, they could be browsed but not for 3.1.0.  It's a fair bit of work to make the browsers handle all the nuances of code that's not visible. See this comment. https://github.com/GemTalk/Jadeite/issues/765#issuecomment-614317314

Fixed in 3.1.0pre-release5. Re-enablement will be when #765 is fixed & browsers can handle non-visible code better.

I agree with deferring making this work correctly, I think that is outside the scope of this bug, I just don't like error dialogs.   I think we need a separate bug for the future work.
As for this bug:  If I double click on one of these lower methods in the list of frames, I do still get an error.  It would be nice to close this hole.

The failure I found was with a class method. Similar to one of the problems in #765 https://github.com/GemTalk/Jadeite/issues/765#issuecomment-613693480.  If there is a further problem, please provide the stack & stack frame to aid debugging.

Did you miss that this was only for attempting to browse using double-click?
You did fix this issue for the browse menu item, that is now disabled.  But the double-click performs a Browse and runs into the same problem.
Since this bug was only for the browse menu item, perhaps I should file a separate bug?

Yes, I did notice it was only for double-click. And, after trying every frame in the stack I found that the class side methods failed. So I fixed that. The example that you provided doesn't fail for me. https://github.com/GemTalk/Jadeite/issues/774#issuecomment-617929130

I don't see any class methods in my typical example, which very reliably always triggers an error and leaves an PB around.

I was able to reproduce and have a fix in 3.1.0.


Make GitHub releases in addition to GitLab releases

I've found GitLab Releases to be significantly slower than GitHub Releases for downloading assets. I did some testing to verify everything, and this is what I found (using curl on the arch.tar.gz images):
GitLab (almost 6 minutes):
root@2269f44a3f54:~# curl 'https://gitlab.com/api/v4/projects/43000137/packages/generic/fim/continuous/arch.tar.xz' > arch.tar.xz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  409M  100  409M    0     0  1176k      0  0:05:56  0:05:56 --:--:-- 1497k

GitHub (almost 50 seconds):
root@2269f44a3f54:~# curl 'https://github.com/hwittenborn/release-testing/releases/download/0.0.0/alpine.tar.xz' -L > arch.tar.xz.2
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 54.1M  100 54.1M    0     0  1143k      0  0:00:48  0:00:48 --:--:-- 1645k

It would be great if I could use GitHub Releases, as it would make my CI runs significantly quicker.

I don't know how I overlooked it, it looks like I accidentally used the alpine image for my testing on GitHub Releases though. Looking at things like the average download speeds it looks like they're pretty identical, I'll go ahead and get this closed.
Sorry about that!


window.TAURI.invoke() throws "_this.transformCallback is not a function"

Describe the bug
Whenever I call window.__TAURI__.invoke(), I get this error:
_this.transformCallback is not a function. (In '_this.transformCallback(function (r) {
        resolve(r);
        delete window[error];
      }, true)', '_this.transformCallback' is undefined)

To Reproduce
Code:

Make a custom command
Run that command with window.__TAURI__.invoke() (see also line 4)

Runnable example:

Clone https://github.com/edbrannin/multi-diff (at commit: 70a8f04a78ef8e0effc0052ea98077c0be1c2bb8)
Run yarn tauri dev

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Platform and Versions (please complete the following information):
Operating System - Mac OS, version 10.15.7 X64

Node.js environment
  Node.js - 12.20.1
  @tauri-apps/cli - 1.0.0-beta-rc.2
  @tauri-apps/api - 1.0.0

Global packages
  npm - 6.14.11
  yarn - 1.22.10

Rust environment
  rustc - 1.51.0
  cargo - 1.51.0

App directory structure
/node_modules
/public
/src-tauri
/build
/.git
/src

App
  tauri.rs - 1.0.0-beta-rc.0
build-type - bundle
CSP - default-src blob: data: filesystem: ws: http: https: 'unsafe-eval' 'unsafe-inline'
distDir - ../build
devPath - http://localhost:3000

Additional context
I've been using window.__TAURI__.invoke() because of #1512 -- I'll try using the imported version now that rc2 is out.
Stack Trace
[Error] Error:
TypeError: _this.transformCallback is not a function. (In '_this.transformCallback(function (r) { resolve(r); delete window[error]; }, true)', '_this.transformCallback' is undefined)
user-script:3:101:45
Promise
invoke — user-script:3:100
(anonymous function) — App.js:48
asyncFunctionResume
(anonymous function) — App.js:30
asyncFunctionResume
(anonymous function) — App.js:41
invokePassiveEffectCreate — react-dom.development.js:23487
callCallback — react-dom.development.js:3945
dispatchEvent
invokeGuardedCallbackDev — react-dom.development.js:3994
invokeGuardedCallback — react-dom.development.js:4056
flushPassiveEffectsImpl — react-dom.development.js:23574
unstable_runWithPriority — scheduler.development.js:468
(anonymous function) — react-dom.development.js:23324
workLoop — scheduler.development.js:417
flushWork — scheduler.development.js:390
performWorkUntilDeadline — scheduler.development.js:157
	(anonymous function) (main.chunk.js:86)
	asyncFunctionResume
	(anonymous function)
	promiseReactionJobWithoutPromise
	promiseReactionJob

Can you please update and try again? It seems that tauri.rs is out of date:
https://crates.io/crates/tauri/1.0.0-beta-rc.2

Whoops, I thought tauri deps update would take care of that.  It seems like it's checking, but isn't finding the update...
yarn run v1.22.10
$ tauri deps update
[tauri]: running deps
 dependency:manager Updating dependencies... +0ms
 app:spawn [sync] Running "rustup update" +190ms

info: syncing channel updates for 'stable-x86_64-apple-darwin'

  stable-x86_64-apple-darwin unchanged - rustc 1.51.0 (2fd73fabe 2021-03-23)

info: cleaning up downloads & tmp directories
 dependency:cargo-commands "tauri-bundler" is up to date +942ms
 dependency:crates "tauri" is up to date +298ms
 dependency:npm-packages "@tauri-apps/api" is up to date +2s
 dependency:npm-packages "@tauri-apps/cli" is up to date +1s
✨  Done in 4.99s.

Sorry, I'm a rust newbie; I'll try to figure this out

dang - you're right! it seems that it won't find the beta. @lucasfernog - got an idea here? this will probably follow us for a while

I ran cargo update in src-tauri and it's updated:
    Updating crates.io index
    Updating jobserver v0.1.21 -> v0.1.22
    Updating open v1.6.0 -> v1.7.0
    Updating tauri v1.0.0-beta-rc.0 -> v1.0.0-beta-rc.2
    Updating weezl v0.1.4 -> v0.1.5

I tried again and it's still happening.

It works when I import invoke, so this may just be a problem with window.__TAURI__:
import { invoke } from '@tauri-apps/api/tauri';

I'm going to move on now, but let me know if I can be useful for resolving the root cause somehow. :)

Thanks for the headsup and the speedy resolution. Going to close this, since your issue was resolved.

Sounds good, though I hope you won't forget to check on window.__TAURI__.invoke() :)

Hmmm the issue happened because you changed the context of window.__TAURI__.invoke. I can change it to not rely on this and it'll work.


feat: fluent async api

this PR enables to await a method chain on a retrieved UI5 control:
const title = await browser.asControl(listSelector).getItems(1).getTitle()
expect(title).toBe('Andrew Fuller')

this should not only reduce refactoring efforts on existing, sync-style notation tests, but also leads to more concise code.
without the fluent async api, the above example would have been:
const list = await browser.asControl(listSelector)
const item = await list.getItems(1)
const title = await item.getTitle()
expect(title).toBe('Andrew Fuller')

additionally, tests in wdio-ui5-service/test got restructured so they can run in parallel, cutting down test-/ci-time.

great, looks good.


Recommend defining CompatiblePSEditions

The module manifest has a PowerShell requirement. If this is true, I would also recommend setting CompatiblePSEditions = 'Core'" in the manifest. I know that's the first place I look when checking for compatibility. The module name should be a good indication, but it never hurts to be thorough.

Thanks for the recommendation Jeff. That psd1 format has so many options.
It means a lot to know you've taken a peek at my code, thanks for all the work you do in the powershell space (and for all the QotD content in my twitter feed 😆)


Change severity level for logs like "IDX10223: Lifetime validation failed. The token is expired"

Microsoft.Identity.Web Library
Microsoft.Identity.Web
Microsoft.Identity.Web version
2.16.1
Web app
Sign-in users and call web APIs
Web API
Protected web APIs (validating tokens)
Token cache serialization
Not Applicable
Description
Every day I got a lot of error logs like

IDX10223: Lifetime validation failed. The token is expired...
IDX10205: Issuer validation failed...

The 1st one is not an error and we want to ignore it: this means that some of our clients make a request with an expired token, then the 401 will be returned and the client goes to the refresh endpoint for the new token. So it's not an error on the server side, we can't fix it from the server side. Why is it treated as an error?
How to disable/ignore/change-severity them?

@jennyf19
Any plans or news on this issue?
We need this too.
Treating IDX10223 as an error in logs (Server-side) seems wrong.
An expired token is not an error on the Server side, it's a Client-side problem.
It just fills up the logs.
https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/issues/2614#issuecomment-2135739124 is not really the solution to this issue, cause it's about deactivating Identity logs completely, like shown here
However, we do not want to disable all Identity logging.
IDX10223 should be treated as a Warning.
Alternatively, it would be nice to have a way to "opt-out" from it.

I agree that there is nothing the web API can do when it receives expires tokens.
@jennyf19 @brentschmaltz any objections changing the severity to warning or info?


fix typo in code.

two commit here to fix typo:

preSandboxInitDecoder in vpp/vaapipostprocess_host.cpp will conflict with decoder/vaapidecoder_host.cpp. Halley assume preSandboxInitXXX will called by chrome, but actually it's not. Since nobody use it, we'd better remove it all.
fix == error in assignment

The two commits lgtm +1


HTTP 1.1 LINK und UNLINK commands are missing

LINK and UNLINK are part of HTTP 1.1.
They are not widely used, but still useful for some REST applications.

Can now be done using custom methods.


upgrade bootstrap from 4.0.0-alpha.6 to 4.1.1

Description
Just upgrading Boostrap, ya know

SHIP IT

Merging is blocked for mio


Logo For Android Basic Quiz

Hi @basillink , I'm a graphics designer, after I review your project I want to contribute by creating a logo for your project and you do not have to pay for this because it's free. What do you think?

Hi @zularizal , thanks for the kind gesture. I'd really appreciate it if you could help out.


Enable eslint for more filetypes

Thanks for your work on this plugin!
eslint is not enabled for filetypes it natively supports right now. It is missing "html", "vue", "markdown".
See https://github.com/microsoft/vscode-eslint/blob/a0e49f3807c1616cf75c5aa576070a663a5af2b4/package.json#L292 for the complete list.
Could you add these filetypes?

@mjlbach Ah, I see – so I guess I'll file this again for https://github.com/neovim/nvim-lspconfig/blob/dd8c77a689b9e69bb08693d6d387cbb93669a791/lua/lspconfig/eslint.lua


delete drive layout via IOCTL

execute the Windows API function DeviceIoControl with the control code IOCTL_DISK_DELETE_DRIVE_LAYOUT, the effect of which would be to remove the boot signature from the master boot record, so that the disk will be formatted from sector zero to the end of the disk.

also references here:

https://www.crowdstrike.com/blog/the-anatomy-of-wiper-malware-part-3/
https://tyleo.github.io/sharedlib/doc/winapi/winioctl/constant.IOCTL_DISK_DELETE_DRIVE_LAYOUT.html

IOCTL_DISK_DELETE_DRIVE_LAYOUT	0x7c100		Removes the boot signature from the master boot record, so that the disk will be formatted from sector zero to the end of the disk. Partition information is no longer stored in sector zero.


Add index to reply field on replies collection

It would be nice if I could perform text search on replies collection. Would it be possible if I do a PR for this one?
https://github.com/silentrob/superscript/blob/master/lib/topics/reply.js#L11

Absolutely. I'm not sure why I didn't add that to begin with.
Having said that, can you walk me through your use case.

On May 15, 2015, at 1:28 PM, Noppanit Charassinvichai<EMAIL_ADDRESS>wrote:
It would be nice if I could perform text search on replies collection. Would it be possible if I do a PR for this one?
https://github.com/silentrob/superscript/blob/master/lib/topics/reply.js#L11
—
Reply to this email directly or view it on GitHub.

My use case is. People ask for a machine on Slack channel a lot. Instead of having everyone saying it's ok to use the machine.
I was thinking of having the bot to check a particular keyword in the database. Then the bot can reply who's the last person mentioned the keyword. To do that I need to use db.replies.find( { $text: { $search: "machine" } } ) which requires an index on the collection.
Do you think this makes sense?

I think I follow you. The replies however are the canned responses the bot can say.
If you want to know who asked the bot for something or how the bot replied, you need to check the user model / history.
Does that make sense? I'm afk at the moment or I would show your the line / code that does that.

On May 15, 2015, at 1:48 PM, Noppanit Charassinvichai<EMAIL_ADDRESS>wrote:
My use case is. People ask for a machine on Slack channel a lot. Instead of having everyone saying it's ok to use the machine.
I was thinking of having the bot to check a particular keyword in the database. Then the bot can reply who's the last person mentioned the keyword. To do that I need to use db.replies.find( { $text: { $search: "machine" } } ) which requires an index on the collection.
Do you think this makes sense?
—
Reply to this email directly or view it on GitHub.

Oh, that makes more sense. Yes can you please show me that line and does users collection has index for full-text search? If not do you want me to make a PR for that?

So the line you want to look at is here - https://github.com/silentrob/superscript/blob/master/lib/users.js#L28
I should point out that you only get the last 15 messages and there is no index on it.
There is also 2 public interfaces for users here.
https://github.com/silentrob/superscript/blob/master/index.js#L263-L273.
Lastly, if you are feeling brave. I wrote a utility that walks the users history searching for things (nouns, names etc.) it might be worth looking at too. It is designed to be called from within a plugin function.
https://github.com/silentrob/superscript/blob/master/lib/history.js
I would happily take a pull request to make the system better in anyway! Thanks for your interest in Bots and SuperScript.

I have one question. I have decided to go a different path. I'm going to use plugin instead and I'm going to create a new collection in the database that way it's going to be easier and faster than fetching data from history every time.
Here's my code. However, I don't see the way to parse mongoose object to the plugin. Am I missing something? Can I call parse any object from server.js to the plugin?
var StagingUtil = function(mongoose) {
	var CheckStagingSchema = mongoose.Schema({
		user: String,
		createdAt: { type: Date, default: Date.now }
	});

	this.CheckStaging = mongoose.model('CheckStaging', CheckStagingSchema);

}

StagingUtil.prototype.lastPersonAskedForInHour = function(user, message, callback) {
	var self = this;
	if(message.indexOf('staging') > -1) { // This is going to be deleted because I'm going to use Superscript instead.

		this.CheckStaging.findOne(function(err, record) {
			if (err) return console.error(err);

			if(record) {
				record.user = user;
				record.createdAt = new Date();
				record.save();
				callback(record);
			} else {
				var lastPersonMentionedStaging = new self.CheckStaging({
					user: user
				}).save(function(err, lastPersonMentionedStaging) {
					if (err) return console.error(err);

					callback(lastPersonMentionedStaging);
				});
			}
		});

	}
}

Always happy to help out. So if you want some custom function (or object) available from within a plugin you just need to pass it into the bot options.
Here is an example.
var superscript = require("superscript");

var options = {};
options['factSystem'] = factSystem;
options['mongoose'] = mongoose;
options['scope'] = {
  'customFunction': function(a, b) { return a + b }
}

new superscript(options, function(err, bot) {
   // bot stuff, request, reply
});

So the key here is the 'scope' key will mixin to the plugins.
Then from your custom plugin you have the function available. ie: this.customFunction()
Here is the line that calls the plugin.
https://github.com/silentrob/superscript/blob/master/lib/processtags.js#L51-L52

Im going to close this issue, but if you still have more questions, please re-open or create a new issue.


Man, why Anne name week is goin like thiz ;-;?

Expain me? Why u use like thiz ;-;

Is not really a bug. But eh, closing


"Unresolved assembly" or "missing assembly" in the report is confusing

The Missing assemblies section in the report is confusing to customer.
May change the report section name from "Missing assemblies" to "Unresolved assembly".
May change the "Header for assembly name entries" to "dependency assemblies not analyzed"
May change the "Reason" to "possible Reason" with the value like "The assembly was not included in the analyzing run. It it is an assembly that you own, include it as part of the analysis. If is third party owned assembly, work with the owner to update it to .NET standard or .NET Core"
The used by column currently is empty, it may be populated by the assembly name, which reference to the listed assembly.

Agree, and additionally I was confused to see everything "green" on the summary after I wanted to test the analyzer by adding EF6 to a 4.7.1 project and referencing it in a .NET Core 3.0 project (with .NET Core 3.0 checked in settings).

@martinoss Thank you for the feedback!
"additionally I was confused to see everything "green" on the summary", I want to make sure that I understand what you did correctly. Did you created two projects, one is 4.7.1 project referencing EF6 as a class library; another project is .NET Core 3.0 project, which reference to the 4.7.1 project?

Exactly, but just for testing purposes to see what the analyzer is telling
me.
Alicia Li<EMAIL_ADDRESS>schrieb am Do., 17. Okt. 2019, 18:09:

@martinoss https://github.com/martinoss Thank you for the feedback!
"additionally I was confused to see everything "green" on the summary", I
want to make sure that I understand what you did correctly. Did you created
two projects, one is 4.7.1 project referencing EF6 as a class library;
another project is .NET Core 3.0 project, which reference to the 4.7.1
project?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/dotnet-apiport/issues/774?email_source=notifications&email_token=AATX2JSCDY7E27UXSPLASJ3QPCE2VA5CNFSM4H4JBPVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBQU2ZA#issuecomment-543247716,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AATX2JX35FZJ2CIRQND4EADQPCE2VANCNFSM4H4JBPVA
.


Review accessibility guidance on page titles

What
As part of the review of our accessibility pages, the guidance for content on setting page titles (linked here) needs to be reviewed.
Current guidance

Why
The guidance needs to clarify how page titles differ from page names.
Done when

[x] New guidance drafted
[ ] Guidance reviewed and approved
[ ] Updated guidance released

Hi @AJSMITH1512, here's the current guidance: https://service-manual.nhs.uk/accessibility/content#set-page-titles
Is the following text clearer? I'll run it by a few content designers this week, and will check it with Dave and Ben too before asking the AWG to approve the change.
Set page names and page titles
For: Content, Development, Testing
The page name:

is in the  tag in the  of the page, for example: "Achalasia"
shows at the top of the page

The page title:

is in the  tag in the  section of the page
consists of the page name and the website name, like this: Page name – Site name, for example: "Achalasia – NHS"
shows in the browser window and search results snippet
is the first thing a screen read will read out

If you can, use templates to keep things consistent and use your content management system (CMS) to add the site name after the dash. That way you can focus on the page name in the H1.
Good page names:

help users find what they want and recognise they're in the right place
are unique, concise and descriptive
put important keywords near the beginning

Should probably go to AWG too. I'm testing it with some content designers this morning.

Notes from crit with content designers

Confusion about words "page name" and "page title". Explain up front that they can be confused and then explain key differences? Better to talk about "title" and "H1" or main heading.
Consider putting content for content designers under "Use headings correctly" and leave "Set page titles" for devs and testers? But some content designer duplicate H1 in title or write different page titles. Some are just aware of and use H1 and rely on CMS creating page title.
For content designers, it's about "writing good page titles". "Set" doesn't make sense to them. In what sense to devs "set" page titles?
When would we have different info in page title and H1? (See Slack conversation.)
Make it clear that title doesn't appear on page but does appear in search results. While H1 is visual, on page.
Consider using accordions for what devs need versus what content designers need?
Section heading: Set page titles and write good page headings?

See Slack thread: https://nhsuk.slack.com/archives/C6S0QTW9X/p1624370799028200?thread_ts=1624368546.027100&cid=C6S0QTW9X

We say this in the accessibility guidance: https://service-manual.nhs.uk/accessibility/content#set-page-titles, i.e. Page title - Site name. For example: Achalasia - NHS.
I think we're OK on the health content front, because it's templated in Wagtail. But we're not consistent with services.
We have some services that follow the GOV.UK pattern: eg: Do you know your NHS number? - Book a coronavirus vaccination - NHS. https://www.nhs.uk/book-a-coronavirus-vaccination/do-you-have-an-nhs-number.
And some which don't mention that it's the NHS website, e.g.: Search - Find a walk-in coronavirus (COVID-19) vaccination site. https://www.nhs.uk/service-search/find-a-walk-in-coronavirus-covid-19-vaccination-site

Had a chat with Alistair Duggin and Sarah Norman about this. We know that some transactional services are failing WCAG2.1 AA on page titles. Other pages are not following latest best practice.
Alistair is going to draft a brief note with examples and best practice that could go in the accessibility guidance.
We also need a way to make this guidance easier to find in the service manual. It's not just an accessibility issue.

This all needs further review and testing. Put back into team backlog for now.

See also our draft URL guidance: https://github.com/nhsuk/nhsuk-service-manual-community-backlog/issues/265
The BBC guidance for title is
Page name - Section name - BBC
And the GOV.UK guidance (if I remember correctly) is:
Page name - service name - GOV.UK
eg https://www.registertovote.service.gov.uk/register-to-vote/country-of-residence

Page titles should be short. WebAim says generally no more than a few words. https://webaim.org/techniques/pagetitle/
DigitalA11y says: "Make sure that title is between 50-75 characters." https://www.digitala11y.com/understanding-sc-2-4-2-page-titled/
A lot of our page titles are very lengthy.

Page title - HMRC guidance

I think we've seen teams struggling with titles, H1s and URLs for fail pages. I'll see if I can find some examples.

I'm a new user of the NHS Design system so recently queried the policy on titles.
There's some guidance under the accessibility section, but alas I didn't find it.
Some extra things it would be good to cover:

The example seems suited to content pages on nhs.uk, but not services where I think we'd want to include the service name. It would be good to explicitly add an example like the one @sarawilcox has found above.
As well as services, it would be good to cover what things within the NHS App should do - should they end in - NHS or - NHS App?

I think the app itself might use NHS App, but we may decide that services within it don't - many things are available both within the app and via the web. If we ask them to add NHS App to the end of their titles I think it implies the page title being dynamic based on use case - which might be challenging for some services.

Interestingly the NHS.UK CMS uses a hyphen by default, but it would not be v difficult to change this to an en-dash.


Fix logging error in run_openeye_oe

Description
It's embarassing to get an error within the error messaging
During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/paynea/miniconda3/envs/ad-3.9/lib/python3.9/logging/__init__.py", line 1083, in emit
    msg = self.format(record)
  File "/home/paynea/miniconda3/envs/ad-3.9/lib/python3.9/logging/__init__.py", line 927, in format
    return fmt.format(record)
  File "/home/paynea/miniconda3/envs/ad-3.9/lib/python3.9/logging/__init__.py", line 663, in format
    record.message = record.getMessage()
  File "/home/paynea/miniconda3/envs/ad-3.9/lib/python3.9/logging/__init__.py", line 367, in getMessage
    msg = msg % self.args
TypeError: not all arguments converted during string formatting
Call stack:
  File "/home/paynea/miniconda3/envs/ad-3.9/bin/run-docking-oe", line 8, in <module>
    sys.exit(main())
  File "/lila/data/chodera/paynea/asapdiscovery/asapdiscovery-docking/asapdiscovery/docking/scripts/run_docking_oe.py", line 608, in main
    logger.error("Docking timed out for", docking_run_name)
Message: 'Docking timed out for'
Arguments: ('hybrid',)

Todos

[ ] fix how the string is passed

Status

[ ] Ready to go

Codecov Report

Merging #579 (af094f2) into main (0432f69) will decrease coverage by 24.89%.
The diff coverage is n/a.

Additional details and impacted files


Question/Issue: Batch insert

Hi @landawn
I am trying to perform batch insert but somehow my data is not getting committed in batches.
Like i have passed SQLExecutor.JdbcSetting with batch size as 1000, but if conn is null then it set autoCommit as false and commit data for all batches at once.
can you please suggest something, I need to finish this part urgently.
Thank you in advance.

is the batchInsert executed in any transaction? how did you verify if the records are inserted or not?
Here is a test sample: SQLExecutorTest. please take a look. if there is anything different from your batch insert code?

Noh, there is no transaction.
records are getting inserted but records of all batches getting inserted at once.
Like i have 10,000 record and my batch size is 1,000, so it should get committed in database in a batch of 1000, but currently 10,000 records are getting inserted in a single go.

code is written in the same way as specified in the SQLExecutorTest.

Got it. that's right behavior.
They're not inserted in single go. The records are inserted into db batch by batch, but committed at the end.  If i understand correctly, commit most likely just tell db that update is done, not sending all data to db for update. there is no limit/(performance) impact to records you want to do in batch. you can insert 10,000, 100,000, or even 1 millions records in one batchInsert call.
if the size of parameters list is bigger than batch size, yes, the auto commit will be set to false, and commit once at the end of execution. because batchInsert is one shot. we can't tell user: your batchInsret is failing: 30 records are inserted and committed to db, 70 records not.

There is one scenario: huge(>10k or 100k) data import. and you don't want to insert from the begin if it fails. Do this:
StreamEx.of(myHugeDataRecordList).split(batchSize)
    .forEach(batchParameters -> sqlExecutor.insert(sql_insert, batchParameters));

Or:
StreamEx.of(myHugeDataRecordList).split(batchSize)
    .forEach(batchParameters -> {
	try {
	    sqlExecutor.insert(sql_insert, batchParameters);
	} catch (Exception e) {
	    // continue, or mark/save the failed batchParameters for retry? whatever
	}
     }
);


Update quickstart guide to use KDD mode

Gets rid of the current etcd.yaml, which isn't production ready and trips people up in multi-master scenarios.

[ ] Tests
[ ] Documentation
[ ] Release note

None required

Deploy preview for calico ready!
Built with commit 7965b7d5bc07698ae2b0ca5c5d86f82bbda957b6
https://deploy-preview-2435--calico.netlify.com


add normalized mseloss

Add custom MSE loss function for non-contrastive self-supervised learning (BYOL) in BasicLoss.py, or should I add the function in other py file?

Hmm I think putting it in the basic loss will be more appropriate. I will merge


README.md: handle the citations using the Github mechanisms

For now I'm just using footnotes, which doesn't quite work. The references are always superscripts and the rendering at the bottom of the page is a little janky.
Read, understand, and use the Github citation system: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-citation-files#citing-something-other-than-software

But does the Github mechanism allow clean citation handling in README.md markdown, or is for the "how to cite this project" popup?
https://stackoverflow.com/questions/26587527/cite-a-paper-using-github-markdown-syntax

Maybe we just want links: https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet#links


Proposal: Promote Amanda McGuinness(@amanda11) to Senior Maintainers

With the amount of dedication, leading the full v3.5.0 release successfully: (https://stackstorm.com/2021/06/29/stackstorm-v3-5-0-released/), contributing to the st2 overall direction, teamwork, maintenance, guiding others and sharing the knowledge about all the StackStorm parts, the requirements in https://github.com/StackStorm/st2/blob/master/GOVERNANCE.md#how-to-become-a-senior-maintainer tick every possible option.
Amanda drove, contributed to the major projects and was heavily involved in:

st2mistral deprecation project (https://github.com/orgs/StackStorm/projects/16)
EL6 Deprecation project (https://github.com/orgs/StackStorm/projects/17)
Python 2 deprecation (https://github.com/orgs/StackStorm/projects/15)
Python 3 plan execution (https://stackstorm.com/2020/11/15/python-2-deprecation-plan-say-goodbye-to-python-2/)
v3.5.0 release (https://github.com/orgs/StackStorm/projects/20) (https://github.com/StackStorm/discussions/issues/81)

v3.5.0 Python 2->3 was a really huge one with many people and lots of sub-projects put together. It also had one of the biggest amount of moving items that demonstrated some awesome teamwork and coordination. Besides that, she led maintenance updates like security, nodejs, pip, st2web, mongodb across all the dark places of the StackStorm and just being on top of the game.

Amanda got an insight about almost all the aspects of the systems: st2 core, installers, packaging, Ansible, st2web, docker, chatops, st2cicd, workflows and infrastructure, and also active on forums (https://forum.stackstorm.com/u/amanda11/activity), github, Slack, always willing to help the community and grow the new TSC members. It's also nice to see Amanda pro-active for every release, helping with the significant roadmap efforts during the past 1.5 years.
I'd like to propose promoting Amanda McGuinness to the StackStorm TSC Senior Maintainers and more than happy to see such a strong support to StackStorm. Thank you for being such an inspiration for the entire StackStorm community! ✌

Congrats @amanda11, well deserved!


Add basic header support

This PR adds basic header support for publishing. It also adds a Headers field for when listening to messages.

@boekkooi-fresh really appreciate it, thank you 🥇


update accerate to 34.0 causes RuntimeError: Error(s) in loading state_dict for UNet2DConditionModel

System Info
Custom sdxl training script using fsdp GRAD_SHARD_OP with cpu offset.

After upgrading accelerate from 33.0 to 34.0, after collecting state_dict with accelerator.get_state_dict(), error when using load_state_dict(). Works correctly on accelerate version 33.0.  Same unet model used for initiating training is used for load_state_dict().

Also tried unwrapping the model (unet).  But that also doesn't work, fails when saving pipeline via save_pretrained.  But that's a different issue.

accelerate env:
- `Accelerate` version: 0.34.0
- Platform: Linux-6.8.0-40-generic-x86_64-with-glibc2.35
- `accelerate` bash location: /mnt/storage/projects/sdxl_trainer_v3/venv/bin/accelerate
- Python version: 3.10.12
- Numpy version: 2.1.1
- PyTorch version (GPU?): 2.4.0+cu124 (True)
- PyTorch XPU available: False
- PyTorch NPU available: False
- PyTorch MLU available: False
- PyTorch MUSA available: False
- System RAM: 251.57 GB
- GPU type: NVIDIA GeForce RTX 4090

accelerate config yaml:
compute_environment: LOCAL_MACHINE
debug: false
distributed_type: FSDP
downcast_bf16: 'no'
enable_cpu_affinity: true
fsdp_config:
  fsdp_activation_checkpointing: true
  fsdp_auto_wrap_policy: SIZE_BASED_WRAP
  fsdp_backward_prefetch: BACKWARD_PRE
  fsdp_cpu_ram_efficient_loading: false
  fsdp_forward_prefetch: true
  fsdp_min_num_params: 5000000
  fsdp_offload_params: true
  fsdp_sharding_strategy: SHARD_GRAD_OP
  fsdp_state_dict_type: SHARDED_STATE_DICT
  fsdp_sync_module_states: true
  fsdp_use_orig_params: true
gpu_ids: 0,1,2
main_process_port: 29051
machine_rank: 0
main_training_function: main
mixed_precision: fp16
num_machines: 1
num_processes: 3
rdzv_backend: static
same_network: true
tpu_env: []
tpu_use_cluster: false
tpu_use_sudo: false
use_cpu: false

Information

[ ] The official example scripts
[X] My own modified scripts

Tasks

[ ] One of the scripts in the examples/ folder of Accelerate or an officially supported no_trainer script in the examples folder of the transformers repo (such as run_no_trainer_glue.py)
[X] My own task or dataset (give details below)

Reproduction
code snippet - collecting unet to put into sdxl pipeline for save_pretrained:
unet_state_dict = accelerator.get_state_dict(unet)
if accelerator.is_main_process:
pipeline_unet = UNet2DConditionModel.from_pretrained(
pretrained_model_name_or_path, subfolder="unet"
)
pipeline_unet.load_state_dict(unet_state_dict) ##fails here
error when using accelerate version 34.0, does not error with accelerate version 33.0:
[rank0]: Traceback (most recent call last):
[rank0]:   File "/mnt/storage/projects/sdxl_trainer_v3/sdxl_v3_train_05.py", line 848, in
[rank0]:     main()
[rank0]:   File "/mnt/storage/projects/sdxl_trainer_v3/sdxl_v3_train_05.py", line 600, in main
[rank0]:     pipeline_unet.load_state_dict(unet_state_dict)
[rank0]:   File "/mnt/storage/projects/sdxl_trainer_v3/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 2215, in load_state_dict
[rank0]:     raise RuntimeError('Error(s) in loading state_dict for {}:\n\t{}'.format(
[rank0]: RuntimeError: Error(s) in loading state_dict for UNet2DConditionModel:
[rank0]: 	size mismatch for conv_in.weight: copying a param with shape torch.Size([11520]) from checkpoint, the shape in current model is torch.Size([320, 4, 3, 3]).
[rank0]: 	size mismatch for time_embedding.linear_1.weight: copying a param with shape torch.Size([409600]) from checkpoint, the shape in current model is torch.Size([1280, 320]).
[rank0]: 	size mismatch for time_embedding.linear_2.weight: copying a param with shape torch.Size([268802]) from checkpoint, the shape in current model is torch.Size([1280, 1280]).
[rank0]: 	size mismatch for time_embedding.linear_2.bias: copying a param with shape torch.Size([0]) from checkpoint, the shape in current model is torch.Size([1280]).
[rank0]: 	size mismatch for conv_norm_out.weight: copying a param with shape torch.Size([0]) from checkpoint, the shape in current model is torch.Size([320]).
[rank0]: 	size mismatch for conv_norm_out.bias: copying a param with shape torch.Size([0]) from checkpoint, the shape in current model is torch.Size([320]).
[rank0]: 	size mismatch for conv_out.weight: copying a param with shape torch.Size([0]) from checkpoint, the shape in current model is torch.Size([4, 320, 3, 3]).
[rank0]: 	size mismatch for conv_out.bias: copying a param with shape torch.Size([0]) from checkpoint, the shape in current model is torch.Size([4]).
Expected behavior
Expect same behavior on accelerate version 34.0 as accelerate version 33.0, load_state_dict() processes correctly.

Hey @minienglish1, thanks for reporting ! I think you are experiencing the same issue as this one: https://github.com/huggingface/accelerate/issues/3061. Could you try set unwrap=False in your case ? We will try to fix this asap.

@SunMarc
Thanks for the response.  No rush to fix this.
Using accelerator.get_state_dict(unet, unwrap=False) appears to have fixed the problem, or at least let the pipeline be saved via save_pretrained.  I haven't tried using the saved_pipeline yet.

This seems to solve my size mismatch issue after training with fsdp and reload from pretrained


export using newest meshio

In the newest version of meshio, gmsh2-binary and gmsh2-ascii are no longer the correct options
https://github.com/bempp/bempp-cl/blob/c8db14562ade22801dad9dc62a225256423e3cca/bempp/api/grid/io.py#L80-L91
For now, I've set meshio==4.0.1 in environment.yml to avoid this issue

This is now fixed in the staging branch


Bug in code snippet

I believe that the last line of the last code snippet should read:
visual.StartAnimation("Offset", animation);
The target property of the Vector3 animation is the whole Offset and not just Offset.X

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cd76f137-7acf-075b-2eda-fdc0b377c052
Version Independent ID: 468ea2ed-216f-6b04-f81c-9cb78c05f386
Content: Time animations - Windows UWP applications
Content Source: windows-apps-src/composition/time-animations.md
Product: uwp
GitHub Login: @jwmsft
Microsoft Alias: jimwalk

Same for the snippet before that, it should become:
redVisual.StartAnimation("Offset", animation);

@XamlBrewer, thanks for pointing out this error. The code has been updated.


ads: add test for ads ack/nack handling

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
7169b3ec4cbecb119b6e10f19722a6083d20165c
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio


Reprioritize how to install and add caveat for AS 5.0

FactoryGirl installation should occur through Bundler, so it can resolve
dependencies correctly.
When installing manually, include a caveat when installing on older
Rubies on how to handle breakages in the README.
Resolves #929, Resolves #928

LGTM.


Use v(k) - v(k-1) as the fixed point residual of the ADMM_cs solver for MPCT

Do this for the C solver as well as for the Matlab one. Currently, we use z(k) - z(k-1).

This should be checked in all solvers. In fact, I need to check which dual residual exit condition is more appropriate and make that change across all the ADMM-based solvers.

This has been fixed as of 59ad2db1446f19a2e6245080c483f092696bead2.


hide button copy when flash is none

hi @asafdav, I have change commit and README. Now, you can merge .

Hi, please see my comment, you don't have to create a new pull request, you can just squash your commits and push it again.
Thanks !

sorry @asafdav . Thanks you !

@dtagdev1 awesome, thank you!


Testing multi-arch images for non-x86 platform support

https://docs.google.com/document/d/1B2wx5548-juts5NnDPlf9EotwmuonuJCbNZxT_P7-aQ/edit?usp=sharing

/test gke-upgrade-test

/test gke-upgrade-tests

/test gke-upgrade-tests

/test gke-upgrade-tests

/test gke-upgrade-tests

@sbostick you will need to take this PR out of draft to get the images built so that the test can find them.

Moving to review-ready so the images get built. Thanks, @gavin-stackrox.

I use the PR view to try to make sense of what OpenShift CI is doing: https://prow.ci.openshift.org/pr-history/?org=stackrox&repo=stackrox&pr=3499
/test gke-upgrade-tests
^^ should get one running so it finds the images when they are done and starts to test.

/test gke-upgrade-tests

/test gke-upgrade-tests

/test gke-upgrade-tests

/test gke-upgrade-tests

/test gke-upgrade-tests

/test gke-upgrade-tests

/test gke-upgrade-tests

/test gke-upgrade-tests

/test gke-upgrade-tests

/test gke-upgrade-tests

/test gke-upgrade-tests

/test gke-upgrade-tests

/test gke-upgrade-tests

/test gke-upgrade-tests

/test gke-upgrade-tests

/test gke-upgrade-tests

/test gke-upgrade-tests

/test gke-upgrade-tests

/test gke-upgrade-tests

/test gke-upgrade-tests

/test gke-upgrade-tests

/test gke-upgrade-tests

/test gke-upgrade-tests

/test gke-upgrade-tests

/test gke-upgrade-tests

/test gke-upgrade-tests

/test gke-upgrade-tests


[Backport 0.5-nexus] Translate PPL dedup Command Part 2:  allowedDuplication>1

Translate PPL  Command Part 2:  allowedDuplication>1

Signed-off-by: Lantao Jin<EMAIL_ADDRESS>
update document

Signed-off-by: Lantao Jin<EMAIL_ADDRESS>
remove the CatalystQueryPlanVisitor.java.orig

Signed-off-by: Lantao Jin<EMAIL_ADDRESS>
refactor

Signed-off-by: Lantao Jin<EMAIL_ADDRESS>
add IT for reordering field list

Signed-off-by: Lantao Jin<EMAIL_ADDRESS>
remove useless code

Signed-off-by: Lantao Jin<EMAIL_ADDRESS>
Signed-off-by: Lantao Jin<EMAIL_ADDRESS>Co-authored-by: YANGDB<EMAIL_ADDRESS>(cherry picked commit cc52b1c3e68b87dfb735c3fcd055b5e93d015720 from #543)

Oh, this dedup part 2 requires Spark 3.5.0+. Close it.


Are there specific settings recommended for API Gateway?

https://bigb0ss.medium.com/rotating-source-ips-part-1-aws-api-gateway-fe29d2c5e008
Try using the instructions in this blog post to set up the AWS gateway then LMK what the results are.

Closing this old issue.

-debug shows the following
Debug: {"message":"Missing Authentication Token"}
when run without gateway -url the AADSTS codes come back in response

Is there a fix or workaround for this?