Controller code refactor

Describe the problem
A lot of the hierarchy code of the MRTK controllers can be refactored in being more readable, a little more automatic and easier to use for new controllers.
Describe the solution you'd like
BaseController:

The method SetupDefaultInteractions is abstract. First of all, not all controllers do need to call this, but have to implement it anyway. Second, the only place this is ever called is in SetupConfiguration of the same class. And third, overrides of the default controller mappings and SetupDefaultInteractions makes it kind of redundant what mapping will be used. I think this can be refactored to auto assign a mapping based on handedness by just overriding any of the three DefaultInteractions, as in case of null, DefaultInteractions will be used. (Leaves the case where the base class defines left and/or right and you only want to provide default)

UnityTouchController is the only class that does more than just assigning mappings, but that could be done in the constructor.

Mouse and Joystick controller switch over Interactions[i].AxisType every frame even though the method called does not change. It would be easier to add them to MixedRealityInteractionMapping directly and just call them one after the other

There is no apparent reason for SetupConfiguration to exist at all. All it get's passed in is either known by the constructor of the type, or by the type itself. The constructor in a lot of cases does nothing and could very well undertake SetupConfiguration's roll. As an example, the MouseController passes the type of itself to it.

MixedRealityInteractionMapping:

The mapping ID, as far as the overridden default mappings go, follow their containing array index exactly. This could be factored out of there and therefore make it less error prone to put numbers the wrong order or use duplicates...

Additional context
In my opinion it's worth streamlining this as good as possible so new controllers can be added more easily and existing controllers can be read without thinking about why they are so different where they shouldn't be. As an example, the structure of the MouseController looks completely different than the other controllers (using if statements instead of switch, calling things in different locations than the others...).

A Little feedback from the operation of controllers:

The method SetupDefaultInteractions is abstract.
The Windows / OpenVR platforms don't use this much.  However other SDK's and such require subtle overriding for this function.  It's simply abstract to allow platform overriding as necessary.

Mouse and Joystick controller switch over Interactions[i].AxisType
Mouse doesn't use Switch, Joystick does.  However, this is the standard pattern, looping through the Interaction Mappings assigned to the controller in an efficient way.  For each configured interaction, we get the relevant data from the configured input, which is wholly dynamic.

There is no apparent reason for SetupConfiguration to exist at all.
SetupConfiguration (like Setup Mappings) is an abstract capability to initiate any given platform. Granted, Windows and Unity input don't need it (simply because Unity does this internally). Almost every other platform does need this to perform pre-setup for that given platform.

While the suggestions are well thought through, they don't include the scope for all other platforms.
If however, (@davidkline-ms ) the intention is not to support other platforms or rely solely on OpenXR when it's available, this may be worth trimming down to avoid other platforms complexities

Mouse doesn't use Switch, Joystick does. However, this is the standard pattern, looping through the Interaction Mappings assigned to the controller in an efficient way. For each configured interaction, we get the relevant data from the configured input, which is wholly dynamic.

What I meant with this is that the linking between method and axistype is reevaluated every time the loop runs. If the methods were moved into the definition of the mappings (as System.Actions for example) they could just be called, no matchmaking.

SetupConfiguration (like Setup Mappings) is an abstract capability to initiate any given platform. Almost every other platform does need this to perform pre-setup for that given platform.

The thing about this method is that it's called immediately after the constructor was and that it's two parameters are Type, which the controller that was instantiated just IS, and InputSourceType, which is the same case. The method is defined in BaseController, so we are talking about controllers only and the only exceptions from being a controller are two hand classes that define this as hand. I don't see where it's relevant to tell the Hand class that it's a hand.

What I meant with this is that the linking between method and axistype is reevaluated every time the loop runs. If the methods were moved into the definition of the mappings (as System.Actions for example) they could just be called, no matchmaking.

Can you elaborate on this point?  Not seeing where you are heading.
Based on the Axis, each platform interrogates for the data differently, this is determined in either the dataprovider or controller depending on the complexity of the API.
And the Axis type is evaluated for each mapping per update, to query the platform data and check it.

Can you elaborate on this point?

Sure. As you can see in the following code, for example AxisType.Digital always maps to UpdateButtonData. That doesn't change. And it's always the Interactions that are getting looped over switching on their axis every time. The method used by each axis could very well be part of the interaction itself, evaluated once and assigned.
Now Interactions are assigned in two places, once per the BaseController constructor (which is acutally never the way it's getting assigned, I checked the references) and in the AssignControllerMappings method of it. Just like overriding what default mappings go into the controller in derived classes, AssignControllerMappings could be made abstract so you can override which method goes into which mapping, assigning them once and for the rest of the application just iterate the interactions and call their System.Actions. Something like that, I hope that was clear enough.
https://github.com/microsoft/MixedRealityToolkit-Unity/blob/9b6b91aa5729f5710ed5db1b7e80824416cb88cf/Assets/MixedRealityToolkit/Providers/UnityInput/GenericJoystickController.cs#L52-L73

@Alexees

BaseController:
The method SetupDefaultInteractions is abstract. First of all, not all controllers do need to call this, but have to implement it anyway. Second, the only place this is ever called is in SetupConfiguration of the same class. And third, overrides of the default controller mappings and SetupDefaultInteractions makes it kind of redundant what mapping will be used. I think this can be refactored to auto assign a mapping based on handedness by just overriding any of the three DefaultInteractions, as in case of null, DefaultInteractions will be used. (Leaves the case where the base class defines left and/or right and you only want to provide default)

This was updated to be virtual in #7374, to keep allowing devs to override it if needed. I refactored down a combination of the actual implementations of this class (which were largely identical). The existing version was additionally deprecated and replaced with a parameter-less version that gets the handedness from the controller itself.

Mouse and Joystick controller switch over Interactions[i].AxisType every frame even though the method called does not change. It would be easier to add them to MixedRealityInteractionMapping directly and just call them one after the other

I think this is an interesting point, though it does match the pattern in the other controllers at the moment (other than switch vs ifs, like you mentioned). I'm working on a larger controller refactor proposal, and will see if I can address this there. Filed https://github.com/microsoft/MixedRealityToolkit-Unity/issues/7433 to track.

There is no apparent reason for SetupConfiguration to exist at all. All it get's passed in is either known by the constructor of the type, or by the type itself. The constructor in a lot of cases does nothing and could very well undertake SetupConfiguration's roll. As an example, the MouseController passes the type of itself to it.

This method was deprecated in #7375 with the work moved to the constructor.

MixedRealityInteractionMapping:
The mapping ID, as far as the overridden default mappings go, follow their containing array index exactly. This could be factored out of there and therefore make it less error prone to put numbers the wrong order or use duplicates...

This last part hasn't yet been addressed, but I filed a more targeted issue for it: https://github.com/microsoft/MixedRealityToolkit-Unity/issues/7432

In my opinion it's worth streamlining this as good as possible so new controllers can be added more easily and existing controllers can be read without thinking about why they are so different where they shouldn't be.

Agreed! That's the main focus of my upcoming proposal.


Refactor order filters

I want to merge this change because refactoring orders filters:

[ ] refactor filtering by customer
[ ] refactor order search
[ ] drop all usage of filter_by_query_param
[ ] Add db indexing

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-3114 Drop usage of filter_by_query_param in order filters


Color-String Makeover

Alright, the next step in the eventual color makeover.
The reason behind this PR is to allow better enumeration of methods in order to allow automatic conversion within the color module, without having to piece together strings or manually specify conversion functions. It'll keep the eventual color makeover even cleaner.

This PR makes slightly less drastic changes than the color-convert makeover, but still clean things up a little bit. This will be released as a major version.
There are two commits to this PR; in the event the second PR is too magic for peoples' tastes, it'll be reverted.
Commit 1:

.getXXX() functions -> .get.xxx()
.xxxString() functions -> .to.xxx()
.getXXXa() functions removed; all .getXXX() functions always return alpha
.percent[a]String() -> .to.rgb.percent()
Swizzling! See below.
removed the .getAlpha() function - just use .get.xxx(...)[3]. This is partially because there is no real analogous .to.alpha() function.
Under the Hood: scale() -> clamp()
Under the Hood: color-string.js -> index.js

Commit 2:

.xxxaString() functions (note the a, for alpha-enabled strings) -> .to.xxx(); the returned string is determined if alpha has been supplied to the call and if it is not 1. In such a case, rgb(...) and hsl(...) are returned. In the event alpha was supplied and is a value other than 1, then rgba(...) and hsla(...) are used.

Swizzling has been added. While a slight misnomer, this provides the ability to construct function parameters by passing a mixture of values and arrays.
var cs = require('color-string');

cs.to.rgb(143, [16, 123], 0.5); // rgba(143, 16, 123, 0.5)

This is what will keep compatibility with the previous .rgbaString(color, alpha) calls, while adding the ability to accommodate code that does more per-channel stuff. There is little overhead in this change, other than an added dependency (simple-swizzle).
This change also cleans up the code quite a bit.

In the event the second commit is deemed "too magical" we can definitely remove it. However, with both commits in place, the API has been reduced to this:
.get.rgb()
.get.hsl()
.get.hwb()

.to.rgb()
.to.rgb.percent()
.to.hsl()
.to.hwb()
.to.hex()
.to.keyword()

Would love some feedback, especially regarding the second commit.
// @sindresorhus @MoOx @kevinSuttle @OEvgeny @jbnicolai

:+1:  * :100:

Also apologies for moving the file around; Github doesn't understand files being moved and modified at the same time :|

git should be able to do so, unless you changed too many (which is the case) and the diff consider this as a new file (which is kind of the case too right?). Or maybe it's just github yeah.

Ah nope turns out Git didn't catch it as a rename.
deleted:    color-string.js
new file:   index.js

Shucks.

:+1:

@Qix- once I even tried to use git mv, then changed it a lot: detected as a delete/new file :(

Yeah there isn't a great way to approach it other than to not change it until after this PR, which kind of defeats the purpose a bit IMO.

Btw the tests are, indeed, passing. Travis and Coveralls have been having mini-meltdowns today.

Maybe @SamVerschueren has an opinion, too.

:+1: Looks good.

Like it :+1:

:shipit: :+1:

Published as 1.0.0. Thanks everyone!


ViewStartProvider \ ViewStartUtility can cache results on a per directory basis

The code might move from ViewStartProvider once this change goes in - https://github.com/aspnet/Mvc/pull/946/files#diff-3b8b6fe6d5352a75ce9e1fa8b0a2185dR38, but we can certainly cache the results on a per-directory basis for the lifetime of an app.

Unless this shows up in profiles, or we get user feedback for this, lets not spend more time here.


what is 'input_aspect'

Hi
Can I ask that what is input_aspect ?
Is the aspect  like query terms? If so , then what is training[1] in 'history = nn_model.fit(training[0], training[1]' of model_target.py ?

input_aspect refers to the words of the aspect. In the target based tasks (B, C, D, E) we have to estimate the sentiment polarity of a tweet with respect to a given aspect, which may be one or more words.
It corresponds to the topic input in the following figure (same thing - different name).


form dosen't submit in laravel

Hi
My Form Does not submit in laravel and in Console this error appears: Uncaught (in promise) null.
If I remove @captcha('en') from blade template the problem solved and form submit successfully.
Do you have any solution?

Can you provide more detail? I think it can be a simple script about that. Cause I can't replicate the issue in my side.

@zhanang19 detail like what? can you expain a liitle bit more?

@zhanang19
My form (blade template) is:
				<form action="{{route('save-comment')}}" method="post" id="commentform" class="comment-form">

                        name

                            <input class="form-item" id="author" name="author" type="text" value="" size="30" maxlength="245" aria-required="true" required>

                        email

                            <input class="form-item" id="email" name="email" type="email" dir="ltr" value="" size="30" maxlength="100" aria-describedby="email-notes" aria-required="true" required>

                        your commenet

                            <textarea class="form-item" id="comment" name="text" cols="45" rows="8" maxlength="65525" aria-required="true" required></textarea>

                    @captcha('en')
                    @csrf

                        <input class="btn btn-primary btn-lg" name="submit" type="submit" value="submit">

                </form>

And that's it. no more information!

@zhanang19 sorry for my comments
the debug in console return this error:

Just had this exact issue and it turns out it was because my localhost domain wasn't an allowed domain. Make sure you can see the badge by setting INVISIBLE_RECAPTCHA_BADGEHIDE=true in your .env. Once I added my domain it works fine - hope this helps!


Edit: Boing Spain

Channel ID (required)
BoingSpain.it
Channel Name
Boing Spain
Alternative Names (optional)
No response
Network
No response
Owners
No response
Country
ES
Subdivision
No response
City
No response
Broadcast Area
c/ES
Languages
spa
Categories
No response
NSFW
FALSE
Launched
No response
Closed
No response
Replaced By
No response
Website
www.boing.es
Logo
https://upload.wikimedia.org/wikipedia/commons/thumb/9/95/Boing_2020.svg/300px-Boing_2020.svg.png
Notes
Boing Spain is incorrectly categorised as an Italian channel. Please change tvg-id suffix to .es
EPG is available at https://www.movistarplus.es/programacion-tv but I will raise an issue in the EPG section if necessary.

Fixed in https://github.com/iptv-org/database/commit/75bfc4bd421c88a8df01ae9783a3ce7f391de0b3


Fix function name in 03-transfer-assets.md

fix function name and grammar issue

I have read the CLA Document and I hereby sign the CLA


wait longer for binding test to receive event to hopefully fix tests

Description
Please explain the changes you've made
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation

I agree, increasing time doesn't hurt. But, I don't think that is the issue here.
binding test is passing intermittently.
There are runs in existing PRs #616 and #615 which have un-successful runs as well.
I tried to reproduce on my local and it passed consistently, without any changes as well.


Corrected oAuth Access Method

removed the "requesterCredentials" method, added the authorization token to the TradingService Configuration options. The previous configuration would return error: [Error: Auth token is invalid. Validation of the authentication token in API request failed.]. The patch allows successful authorization.

👍


After Enabling Application Sharing, New User Creation Doesn't Prompt for Organization Input

Description
After modifying the 'deployment.toml' configuration to enable application sharing, an issue arises during the creation of new users. According to the documentation, the system should prompt for organization input when creating a new user. However, this prompt is no longer appearing, resulting in users being created without association to any organization.

Steps to Reproduce

Enable application sharing
Navigate to the developer portal
Sign in --> Create Account --> Proceed to self register

Affected Component
APIM
Version
4.3.0
Environment Details (with versions)
No response
Relevant Log Output
No response
Related Issues
No response
Suggested Labels
No response

Seems like <SupportedByDefault /> under claim section related to claim http://wso2.org/claims/organization is removed in the repository/conf/claim-config.xml file in 4.3.0. This is available in 4.2.0

PR https://github.com/wso2/carbon-identity-framework/pull/4433 is missing in the 5.25.x branch

PR to upgrade framework in product https://github.com/wso2/product-apim/pull/13416


Make GPU offload library linking behaviour configurable

When linking a single FIELD_API build to multiple libraries, we may want to only selectively enable GPU offload in the downstream target libraries.
This PR enables optional private linking of OpenACC and cuda to libfield_api_dp/sp to prevent FIELD_API from always exporting GPU offload libraries to downstream targets.
(I am on leave so will probably be slow to respond to requested changes, apologies in advance!)

Closing this as it was superseded by #56.

Closing this as it was superseded by #56.


Option to force all connections to HTTPS

An option to re-write all url's to https:// and if the website don't respond to https then don't download.
This option would useful to force all Reddit and Imgur links to https because they support it but uploaders don't always use a https url.
And if a website don't support https then don't try to use http. It should only try https when the "force https option" is enabled.

I think two separate options could be good here.
Check a box to try to force rips to use https.
Check a box to try falling back on the original http link if https fails. Definitely don't try falling back on http if the original link was https and 404'd.


TLS Known Hosts Fix

This patch updates the TLS parser to fix the issue where a user-scoped known_hosts file wasn't enabling TLS insecure in conjunction with peer validation.

Codecov Report

Merging #534 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #534      +/-   ##
==========================================
- Coverage   28.53%   28.52%   -0.02%
==========================================
  Files          34       34
  Lines        1994     1995       +1
==========================================
  Hits          569      569
- Misses       1364     1365       +1
  Partials       61       61

Impacted Files
Coverage Δ

api/utils/utils_tls.go
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44a5d1c...95ede84. Read the comment docs.


Styling changes for file versions and share popup

Purpose
There are some final tweaks to be done for parts of Quick Files before sending off to QA.  This PR handles some of the style and functionality changes.
Summary of Changes

Used the outsideClick function to determine if the user clicks outside of the popup (and toggles accordingly)
Added bootstrap classes to the file versions table's columns to make them disappear when the screen is medium width or smaller.

Ticket
None
Reviewer Checklist

[ ] meets requirements
[ ] easy to understand
[ ] DRY
[ ] testable and includes test(s)
[ ] changes described in CHANGELOG.md (don't have initial release yet)

Coverage increased (+2.2%) to 5.645% when pulling fb234b0af5d47995f29712dd320cc95659b0e6f1 on baylee-d:feature/style-changes into f901d9f30a8c7e4793de9a929f37812ec81b6eef on CenterForOpenScience:develop.


Guys, what's the problem? Suddenly report an error

`2021-07-29T18:32:08.471 INFO   🏷  Price in BTC: 0.0048449
2021-07-29T18:32:08.472 INFO   🏷  Price in ETH: 0.08444829
2021-07-29T18:32:32.121 INFO   🛑 Shutting down!
2021-07-29T18:32:32.125 ERROR  Unclosed client session
client_session: <aiohttp.client.ClientSession object at 0x7fc02bb335e0>
2021-07-29T18:32:32.125 INFO   👋 Bye!
2021-07-29T18:32:32.157 ERROR  Task exception was never retrieved
future: <Task finished name='Task-11' coro=<WsCollector.task() done, defined at /home/chia/soft/chia-monitor/monitor/collectors/ws_collector.py:78> exception=KeyboardInterrupt()>
Traceback (most recent call last):
File "/home/chia/soft/chia-monitor/monitor/collectors/ws_collector.py", line 81, in task
msg = await self.ws.receive_json()
File "/home/chia/.local/share/virtualenvs/chia-monitor-Iocbb-0M/lib/python3.8/site-packages/aiohttp/client_ws.py", line 291, in receive_json
data = await self.receive_str(timeout=timeout)
File "/home/chia/.local/share/virtualenvs/chia-monitor-Iocbb-0M/lib/python3.8/site-packages/aiohttp/client_ws.py", line 276, in receive_str
raise TypeError(f"Received message {msg.type}:{msg.data!r} is not str")
TypeError: Received message 257:None is not str
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/chia/soft/chia-monitor/monitor/main.py", line 136, in
asyncio.run(aggregator(exporter, notifier))
File "/usr/lib/python3.8/asyncio/runners.py", line 44, in run
return loop.run_until_complete(main)
File "/usr/lib/python3.8/asyncio/base_events.py", line 603, in run_until_complete
self.run_forever()
File "/usr/lib/python3.8/asyncio/base_events.py", line 570, in run_forever
self._run_once()
File "/usr/lib/python3.8/asyncio/base_events.py", line 1859, in _run_once
handle._run()
File "/usr/lib/python3.8/asyncio/events.py", line 81, in _run
self._context.run(self._callback, *self._args)
File "/home/chia/soft/chia-monitor/monitor/collectors/ws_collector.py", line 91, in task
File "/usr/lib/python3.8/logging/init.py", line 1458, in warning
self._log(WARNING, msg, args, **kwargs)
File "/usr/lib/python3.8/logging/init.py", line 1589, in _log
self.handle(record)
File "/usr/lib/python3.8/logging/init.py", line 1599, in handle
self.callHandlers(record)
File "/usr/lib/python3.8/logging/init.py", line 1661, in callHandlers
hdlr.handle(record)
File "/usr/lib/python3.8/logging/init.py", line 954, in handle
self.emit(record)
File "/usr/lib/python3.8/logging/init.py", line 1085, in emit
msg = self.format(record)
File "/usr/lib/python3.8/logging/init.py", line 929, in format
return fmt.format(record)
File "/home/chia/.local/share/virtualenvs/chia-monitor-Iocbb-0M/lib/python3.8/site-packages/colorlog/colorlog.py", line 135, in format
message = super(ColoredFormatter, self).format(record)
File "/usr/lib/python3.8/logging/init.py", line 670, in format
record.asctime = self.formatTime(record, self.datefmt)
File "/usr/lib/python3.8/logging/init.py", line 606, in formatTime
ct = self.converter(record.created)
KeyboardInterrupt`

I have three full nodes, only this one can work normally

While waiting for my Pull Request to get merged you can try editing the file "monitor/collectors/ws_collector.py". Change the line:
self.ws = await self.session.ws_connect(f"wss://{self_hostname}:{daemon_port}",
                                                    ssl_context=self.ssl_context)

to:
self.ws = await self.session.ws_connect(f"wss://{self_hostname}:{daemon_port}",
                                                    ssl_context=self.ssl_context, max_msg_size=52428800)

And report if it does in fact fix the issue. Thanks.

It looks normal now. I'll observe it for some time. Thank you very much

Fixed in https://github.com/philippnormann/chia-monitor/commit/6ff3a230bd3b4fc065f0dbb9327909e387c5573a


Remove isSameAs from FlexField

Description
Usages of isSameAs can be replaced with === since all implementations of FlexField are now cached.

Sadly, I don't think this is really safe since our field reuse caching isn't known to be robust in all cases.
/**
 * Reuse fields.
 * Since field currently own cursors and register themselves for disposal when the node hit end of life,
 * not reusing them results in memory leaks every time the field is accessed.
 * Since the fields stay alive until the node is end of life reusing them this way is safe.
 *
 * This ins't a perfect solution:
 *
 * - This can cause leaks, like map nodes will keep all accessed field objects around. Since other things cause this same leak already, its not too bad.
 * - This does not cache the root.
 * - Finding the parent anchor to do the caching on has significant cost.
 *
 * Despite these limitations, this cache provides a large performance win in some common cases (over 10x), especially with how simple tree requests far more field objects than necessary currently.
 */
const fieldCache: WeakMap<LazyTreeNode, Map<FieldKey, FlexTreeField>> = new WeakMap();

Mainly that middle bullet point (note that applies to not just he document root, but detached roots). We also don't currently document that making fields without going through the cache is invalid, which we would have to do if we wanted to ensure the no duplicated field invariant.

Sadly, I don't think this is really safe since our field reuse caching isn't known to be robust in all cases.
/**
 * Reuse fields.
 * Since field currently own cursors and register themselves for disposal when the node hit end of life,
 * not reusing them results in memory leaks every time the field is accessed.
 * Since the fields stay alive until the node is end of life reusing them this way is safe.
 *
 * This ins't a perfect solution:
 *
 * - This can cause leaks, like map nodes will keep all accessed field objects around. Since other things cause this same leak already, its not too bad.
 * - This does not cache the root.
 * - Finding the parent anchor to do the caching on has significant cost.
 *
 * Despite these limitations, this cache provides a large performance win in some common cases (over 10x), especially with how simple tree requests far more field objects than necessary currently.
 */
const fieldCache: WeakMap<LazyTreeNode, Map<FieldKey, FlexTreeField>> = new WeakMap();

Mainly that middle bullet point (note that applies to not just he document root, but detached roots). We also don't currently document that making fields without going through the cache is invalid, which we would have to do if we wanted to ensure the no duplicated field invariant.

After more discussion, it sounds like we can still move forward with this removal since the API is relatively unused.


I can redirect usb web camera?

Sorry to ask a question here, but I do not know where to ask it.
TS: Windows server 2019
RDP client on Linux(xubuntu 20.04): FreeRDP 2.2.0 (n/a)
Need redirect sound, microphone, and usb web camera. Sound and microphone work perfectly, but how you can throw the camera? What I just haven't tried. RDP v8 on Windows can natively redirect web camera. Help please.

Hi, you can use /usb:dev,id:0000:1111 and hope it works.
[MS-RDPECAM], that is high level camera stream redirection, is currently not supported.

See #4971


Update ar.toml - Replaced word for “case” to “report”, closer to issue.

اقتراح باستبدال كلمة “قضية” ب
“بلاغ”
وهي أقرب لمفهوم المشكلة.
Suggested replacement of the word normally used for “case” to something closer to “report”, closer to issue concept.

Description

Issue

Closes: #

/area localization
/language ar


possible to run local machine ?

Resource attribute "@main_title" was not found. Please ensure that each resource has a corresponding
@resource.
Generating synthetic localizations package has failed.
getting this error while 'flutter pub get' run on terminal. how can i run this on local machine?

I can't reproduce this issue, please get the latest commit from master and try again


stackoverflow when using autocompletion

thread '<unknown>' has overflowed its stack
fatal runtime error: stack overflow

Issue

Snippet
use std::io;

fn main() -> Result<(), io::Error> {
    write!(io::stdout().lock(), "input/ a folder with side_files");

    Ok(())
}

Comments
After automatic restart of rust-analyzer it works without this issue but after manual restart it causes this in any way.
I am not sure if it is a redundant issue.
Version
rust-analyzer version: 2020-09-28 (277488b)

I also noticed this once today. I couldn't reproduce it though.

I can reproduce this on two-releases old rust-analyzer, but can't reproduce on master. Looks like fixed by #6222


Mismatched color palette and forced button layout

Hi,
I've noticed that the current color palette is not align with the current green design system. Many of the gray colors is off or have different names.
Another thing is that the button styling is forced on every button element with the exceptions of a small number of exceptions. We have numerous cases where we need a different design to the button than the base styling.

Hey @Hybral, could you provide some examples of the cases where you need different styling for buttons? (Screenshots or links or markup.) It would be really helpful to have some examples of real-life use cases where the current implementation doesn't work well!

Closing as lacking information. If this is still an issue for you and you have more information, leave a comment and we can reopen it! @Hybral


where can I find the https://github.com/CarlaUnreal/UnrealEngine.git

in the https://carla.readthedocs.io/en/0.9.15/build_linux/
we need the  https://github.com/CarlaUnreal/UnrealEngine.git for the next step libCarla build
then can we build pythonAPI for python 3.8
but where can we find the lib, without it, we cannot build the next steps

You need to link an Unreal Engine's account linked to your GitHub account.

Unreal Engine
Starting with version 0.9.12, CARLA uses a modified fork of Unreal Engine 4.26. This fork contains patches specific to CARLA.
Be aware that to download this fork of Unreal Engine, you need to have a GitHub account linked to Unreal Engine's account. If you don't have this set up, please follow this guide before going any further.

Here the link to the guid.
https://www.unrealengine.com/en-US/ue-on-github

let me try, thanks @PatrickPromitzer

verified and closed


Public Website Design

Description
We want to design/redesign the public facing side of our website to better serve our members and add more useful features.
Approach
The following are requirements for the new design:
Navbar

The navbar should feature all of the prominent pages as direct links
Any associated pages can be grouped into a dropdown list (if applicable)

Sections/pages

Home

Think typical new-age home page (hero section with CTA to register with the club)
Other sections can be debated (about us, photo carousel, testimonials, etc.)

Sponsors

Section that lists all of our sponsors with their provided copy

Join

Should include a form with all of the fields that currently exists in user creation
Should include some way of linking to our other social accounts

Events/Calendar

Page/section that will list our events for the term
Either in a calendar format or list format
Events should include date, time, and location(s)

Rankings

Page/section that will include the top 100 ranking at the time
Can maybe include some sort of podium design for the top 3 players?

Related To
Blocked By
Blocks

This is only the design component, once we have the design somewhat finalized/agreed upon we'll make new tickets for the individual pages/sections.

Currently in progress by Laurie


Template params

Improvements:

An extensible model for future purposes
More declarative/self-documenting templates
( {{ params.id }} instead of just {{ id }} )
Future support for nested template parameter bindings
(
Reduces code and drops the property assignment loop (injectModelProperties)
Prevents the behavior that any query parameter can override HTMLElement properties
such as ?id=mynewid or hiding one/many elements/layouts with ?hidden=true

As discussed in #81

This can be closed since it depends on auto-binding template support, which won't get merged.


Communication between esp32 using Windows 11 as development host and ESP-IDF (CON-286)

Hi,
I have three LOLIN D32 boards with esp32 chips and two temperature sensors DS18B20. My objective is to have two boards with a temperature sensor each one and the other board to act as a central node, which would receive the information from the two boards with temperature sensors. My question is to know if the board that acts as the central node can receive the information from the two boards with sensors through the MATTER protocol instead of using the ESP-NOW protocol, all this with Windows 11 using WSL and the ESP-IDF framework.
Regards, thank you.

@SergiSoler8 What is the use/purpose of the central node? Does it send the temperature values to the cloud or something and the other nodes/boards do not connect to the internet? If you explain your usecase then I can provide an appropriate solution.

all this with Windows 11 using WSL and the ESP-IDF framework.

We have tested Windows 10 with WSL and not Windows 11. Please see the documentation here

@dhrishi Hi,
The purpose of the central node is to send the temperature values to a web server. Only the board that acts as the central node would be connected to the internet to send the values to the web server, while the rest of the boards would not be connected to the internet, because they would send the temperature values to the central board using the Matter protocol.
Regards, thank you.

@SergiSoler8 Ok. There are 2 options -

The 2 other boards having temperature sensors connected can run the Matter stack with a device type having the temperature measurement server cluster. The central node can run the Matter stack with a device type having the temperature measurement client cluster. This would not require using the ESP-Now protocol at all.
Now, a user can commission/setup all the three devices into the Matter network. Once done, a binding relationship can be established between the central node and the 2 boards, after which the central node can subscribe to the temperature attribute and get the updates over Matter when the temperature changes. It can then send it to the web server, in the same way that it is currently doing.

Your central node runs Matter to ESP-Now bridge and bridges the non-Matter temperature sensor boards so that they are available over Matter. In this case, you won't have to change anything on the temperature sensor boards and they would continue using ESP-Now. But, you will have to additionally add Matter bridge functionality on the central node. Sending the temperature to the web server still stays the same.

Closing as the question is answered


Update JWT configuration section for JWK and aud

For begriffs/postgrest#919 and begriffs/postgrest#975.

Thanks!


Conversations: Compose new message issue.

Sending a message via Profile page -> Actions -> Start Conversation returns 'Access Denied' after form submission.
Sending a message directly from Conversations module -> Compose refreshes the form only.
In the same time messages are sent in both cases:

However the first variant doesn't have sender in Participants list.
P.S. If BxBaseModProfileModule.php file is replaced with the previous version, it then seems to work normally.

Related issue - Ticket #2751


feat: add generated .NET 6 heads from UnoPlatformApp

GitHub Issue: #
PR Type
What kind of change does this PR introduce?

Feature
Build or CI related changes

Description

Theses new project have been added without any changes made to them, a shared generated by Uno. More pipeline changes will be committed to publish the new blank app.
Update: The pipeline builds the platform with the exception of iOS when built on a Mac agent. I had to use a hosted agent instead because I had a permission issue when running the installation of dotnet 6 workloads.
PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Interface members are XML documented
[ ] Documentation (XML or comments) has been added and/or existing documentation has been updated
[ ] Architecture documents have been updated
[ ] Tested on all relevant platforms

Other information

Internal Issue (If applicable):

Please mac and mac catalyst support


AudioEffects documentation enhancements

Enhancing documentation and readability of some audio effects that were not yet documented.
I did some heavy guessing with StereoEnhance, so please double check if the things I determined it to do are actually the things it is intended to do.

Your commit seems not to be linked to your GitHub account. See why are my commits linked to the wrong user? for more info.

BTW: I have now installed a spell checker for my VSCode.

I'm unsure why but some of the typo fixes did get lost in the first squash, but i did another fixup squash and now alll should be good :)

Thanks, and congratulations on your first contribution! 🎉


Github

Type: Bug
I am not able to push my code to github. showing below error.
fatal: 'JavaScript' does not appear to be a git repository
fatal: Could not read from remote repository.
Github repository link - https://github.com/akshaykumar004/JavaScript
git ls-files --stage -- C:\Users\77079\OneDrive\Desktop\JavaScript\Days\Day2\variables.js
VS Code version: Code 1.84.2 (1a5daa3a0231a0fbba4f14db7ec463cf99d7768e, 2023-11-09T10:51:52.184Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i3-7020U CPU @ 2.30GHz (4 x 2304)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
3.90GB (0.34GB free)

Process Argv
--crash-reporter-id a9c78f3c-b8ff-4d7e-95e2-355284fa82b6

Screen Reader
no

VM
0%

Extensions (17)

Extension
Author (truncated)
Version

flutter-snippets
ale
3.0.0

doxdocgen
csc
1.4.0

dart-code
Dar
3.76.1

flutter
Dar
3.76.0

better-cpp-syntax
jef
1.17.2

remote-containers
ms-
0.321.0

remote-ssh
ms-
0.107.0

remote-ssh-edit
ms-
0.86.0

remote-wsl
ms-
0.81.8

cmake-tools
ms-
1.16.31

cpptools
ms-
1.18.5

cpptools-extension-pack
ms-
1.3.0

remote-explorer
ms-
0.4.1

awesome-flutter-snippets
Nas
3.0.3

java
red
1.24.0

cmake
twx
0.0.17

vscode-java-debug
vsc
0.55.0

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
py29gd2263:30880072
vscaat:30438848
vsclangdc:30486549
c4g48928:30535728
dsvsc012:30540252
pynewext54:30695312
azure-dev_surveyone:30548225
3biah626:30602489
f6dab269:30613381
2i9eh265:30646982
showlangstatbar:30737416
pythonfmttext:30731395
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
pythonnosmt12:30797651
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30869155
dsvsc013:30795093
dsvsc014:30804076
dsvsc015:30845448
pythontestfixt:30871694
pythonregdiag2:30871582
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
pythontbext0:30879054
accentitlementsc:30887149
dsvsc016:30886110
dsvsc017cf:30886113
dsvsc018:30886114
aa_t_chat:30882232

/gifPlease

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.
If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.
Happy coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!

/close

From: VSCode Triage Bot @.>
Sent: Friday, November 24, 2023 3:16:09 AM
To: microsoft/vscode @.>
Cc: Subscribed @.***>
Subject: Re: [microsoft/vscode] Github (Issue #198887)
Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.
If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.
Happy coding!
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vscode/issues/198887#issuecomment-1824503105, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXPWG6ZOSN3HS57YWH6GDD3YF5LCTAVCNFSM6AAAAAA7WYD7HKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRUGUYDGMJQGU.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


fix(deploy): add base images for ci-operator

The first step to fixing the manifests in the output image in release.
There will be one image for building, one for olm, and another for catalog and package-server. Only the base image for olm will contain the operator manifests.

/approve

/lgtm


Create a "Getting Started" example with Angular

Is your feature request related to a problem? Please describe.
As a developer, I'd like to easily stand up and demonstrate the capabilities of Iridium for use with the Angular framework
Describe the solution you'd like
I'd like documentation and supporting code to help me get started with Iridium and an angular client as easily as possible.
Describe alternatives you've considered
n/a
Additional context
n/a

in progress with #50

Code complete, need to write an article to explain how to use.


Newline in messageTemplate causes no logevent is stored

If there is a newline in the messageTemplate, which often is the case for a StackTrace, the message will not be stored in the azuretable.
Just adding a .Replace("\r\n", " ") to the message will solve the problem.

Thanks for the report. A PR would be welcome for this, if you are able to give one a shot. Cheers!

Any thoughts on getting this fixed? Makes the sink almost unusable.

Hi Matt, thanks for the note. Yes, a PR would be welcome if you have a chance to submit one. (Testing is a bit of a bottleneck at our end).

So this task is on hold? As far as i see - right now we have PR with merge conflict and almost unusable sink (any LogError with exception object is not logged in table).

Thanks for the nudge, @Arznaar.
No, it'd be great to move this one forwards. I am not 100% sure the PR is addressing the same issue, since it mentions row keys and not messages, but perhaps the description of this issue is inaccurate?
(The main problem is that no one on the maintainers list for the sink is actively using it day-to-day, as far as I can tell. It's not a great situation, unfortunately.)
I'll see if I can get the linked PR merged to dev - any feedback/validation of the results would be welcome 👍

The PR is out to NuGet as the latest dev package. If anyone can confirm the issue fixed, I'll push the 4.0 release.


Systems set to run on state resume do not respect .after() constraints

Bevy version
0.8.1
What you did
Describe how you arrived at the problem. If you can, consider providing a code snippet or link.
I have my game menus each have a corresponding AppState. For example, there is a state for options menu, main menu etc.
I have two systems:

on_previous_menu_event which I need ran before
on_resume, which gets ran when I resume a state.

I tried to achieve this by doing the following:
  .add_system(on_previous_menu_event.before(on_menu_spawn))
  .add_system_set(SystemSet::on_resume(AppState::MainMenu).with_system(on_resume.after(on_previous_menu_event)))

The ordering is required for the logic to work correctly.
What went wrong
By inserting print statements into both systems, I see that about half the time, the systems are ran in the opposite order in which I declared above.
Additional information
Other information that can be used to further reproduce or isolate the problem.
This commonly includes:

screenshots
logs
theories about what might be going wrong
workarounds that you used
links to related bugs, PRs or discussions

I don't think it's possible to order a system relative to a system in a different set, currently. I think this is supposed to throw a warning.
You can instead order the entire SystemSet to run after on_previous_menu_event.

You can instead order the entire SystemSet to run after on_previous_menu_event.

I didn't know that was possible, how do I do that?

I tried this which doesn't seem to work either.
.add_system_set(SystemSet::on_resume(AppState::MainMenu).after(on_previous_menu_event).with_system(on_resume))

I tried reproducing with the code below, but it behaves as i would expect.

Spoiler
use std::time::Duration;

use bevy::prelude::*;

#[derive(Clone, Copy, PartialEq, Eq, Debug, Hash)]
enum AppState {
    One,
    Two,
}

fn system_a(mut state: ResMut<State<AppState>>) {
    match state.current() {
        AppState::One => {
            println!("push two");
            let _ = state.push(AppState::Two);
        }
        AppState::Two => {
            println!("resuming one");
            let _ = state.pop();
        }
    }
    println!("a");
    std::thread::sleep(Duration::from_millis(500));
}

fn system_b() {
    println!("b");
    std::thread::sleep(Duration::from_millis(500));
}

fn main() {
    App::new()
        .add_plugins(DefaultPlugins)
        .add_state(AppState::One)
        .add_system(system_a)
        .add_system_set(SystemSet::on_resume(AppState::One).with_system(system_b.after(system_a)))
        .run();
}

I'll try to create a minimal reproduceable example, thanks a lot for that code sample. I'll build off on that to get something that better matches my code.

In the process of trying to emonstrate this bug, I believe I may have found another one.
use std::time::Duration;

use bevy::prelude::*;

#[derive(Clone, Copy, PartialEq, Eq, Debug, Hash)]
enum AppState {
    MainMenu,
    Options,
}

fn display_options_menu(mut state: ResMut<State<AppState>>) {
    std::thread::sleep(Duration::from_millis(500));
    println!("Switching to options menu");
    state.push(AppState::Options).unwrap();
}

fn resume_main_menu() {
    println!("Resuming main menu state");
}

struct PreviousMenuEvent;

fn return_to_main_menu(
    mut state: ResMut<State<AppState>>,
    mut prev_menu_evt: EventWriter<PreviousMenuEvent>,
) {
    // std::thread::sleep(Duration::from_millis(500));
    println!("Returning to main menu");
    prev_menu_evt.send(PreviousMenuEvent);
    state.pop().unwrap();
}

fn on_previous_menu_event(mut prev_menu_evt: EventReader<PreviousMenuEvent>) {
    println!("Running on_previous_menu_event system");
    for _ev in prev_menu_evt.iter() {
        println!("Got previous menu event");
    }
}

fn main() {
    App::new()
        .add_plugins(DefaultPlugins)
        .add_event::<PreviousMenuEvent>()
        .add_system(on_previous_menu_event)
        .add_state(AppState::MainMenu)
        .add_system_set(SystemSet::on_update(AppState::MainMenu).with_system(display_options_menu))
        .add_system_set(
            SystemSet::on_update(AppState::Options)
                .with_system(return_to_main_menu.before(on_previous_menu_event)),
        )
        .add_system_set(
            SystemSet::on_resume(AppState::MainMenu)
                .with_system(resume_main_menu.after(on_previous_menu_event)),
        )
        .run();
}

In this example, the bug I intended to demonstrate was resume_main_menu doesn't run properly after on_previous_menu_event.
However when I run this example, the on_previous_menu_event system is only ever run once and never gets run subsequently, which is a separate bug that I haven't encountered before.

When a state transition happens it re-runs on_update so the above code is entering an endless loop, it never even reaches the PostUpdate stage.
Jeez. The state stuff is super prone to footguns and nothing is documented :/
I'm glad we're going to yeet this implementation

I'm very confused that on_update gets run a second time during a state transition.
I'll refactor it so that it doesn't run during a state update and see if that fixes it.

I've reproduced the problem, where the resume code runs before the event is received. Although now I suspect that the event being received only after returning to the main menu is just due to the order that on_previous_menu_event runs.
on_previous_menu_event is probably run before switch_menus, which would explain why I only receive the event when returning to the main menu.
However, this doesn't explain why the .after constraint on on_resume doesn't seem to work.
use bevy::prelude::*;

#[derive(Clone, Copy, PartialEq, Eq, Debug, Hash)]
enum AppState {
    MainMenu,
    Options,
}

fn switch_menus(
    mut state: ResMut<State<AppState>>,
    mut input: ResMut<Input<KeyCode>>,
    mut prev_menu_evt: EventWriter<PreviousMenuEvent>,
) {
    if !input.just_pressed(KeyCode::Return) {
        return;
    }
    input.clear();
    match state.current() {
        AppState::MainMenu => {
            println!("Switching to options menu");
            state.push(AppState::Options);
        }
        AppState::Options => {
            println!("Returning to main menu");
            prev_menu_evt.send(PreviousMenuEvent);
            state.pop().unwrap();
        }
    }
}

fn resume_main_menu() {
    println!("Resuming main menu state");
}

struct PreviousMenuEvent;

fn on_previous_menu_event(mut prev_menu_evt: EventReader<PreviousMenuEvent>) {
    // println!("Running on_previous_menu_event system");
    for _ev in prev_menu_evt.iter() {
        println!("Got previous menu event");
    }
}

fn main() {
    App::new()
        .add_plugins(DefaultPlugins)
        .add_event::<PreviousMenuEvent>()
        .add_system(on_previous_menu_event)
        .add_state(AppState::MainMenu)
        .add_system_set(SystemSet::on_update(AppState::MainMenu).with_system(switch_menus))
        .add_system_set(SystemSet::on_update(AppState::Options).with_system(switch_menus))
        .add_system_set(
            SystemSet::on_resume(AppState::MainMenu)
                .with_system(resume_main_menu.after(on_previous_menu_event)),
        )
        .run();
}

I can work around this issue, e.g by using .add_system(on_previous_menu_event.after(switch_menus)) to get the desired effect.

Obsoleted by #7267. On enter / on exit systems are now found their own schedules.


Bump version for all changes since last bump (vs changes of last commit only)

Observed

Current bump only check changes of last commit to change versions of roles accordingly

Expected

Bump could check changes of all commits since last bump
Last bump identified using commit message versions bump

https://github.com/skilld-labs/plasmactl-bump/pull/13


Add STARKVIND Air purifier table model to quirk

Add the Ikea table model to starkvind quirk. #1215
Also needs to change the models in HA core to support all devices with an Ikea air purifier cluster.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.515%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5084

Relevant Lines:
7109

💛  - Coveralls


block certifyer: handle multiple certificates and equivocation

Motivation

Closes #3467

Changes

sql: add  table certificates to hold certificates. the reason why the certificate is not a property of a block is that the network will certify a empty layer (using types.EmptyBlockID in certificate) when the hare output an empty set.

mesh, tortoise: while multiple valid certificates are stored in the table, when requesting the block to apply/vote for, certificates.GetHareOutput will return types.EmptyBlockID as hare output when there are multiple valid certificates

sync, fetcher: only asked peers for certificate when the nodes doesn't have any. only serve a certificate to peers when there is just one

bors try

bors merge

bors merge


DSD-1121: SVG testing update

Fixes JIRA ticket DSD-1121
This PR does the following:

Adds jest-transformer-svg package
Updates component tests to use the new data-file-name prop generated in the SVG mock (closest we can get to testing that the correct icon is being displayed)

Icon, Logo, SocialMediaLinks, Banner

How has this been tested?

Tested a release candidate in Turbine, no reason to expect this would change anything there, but all tests passed and SVGs displayed as expected locally

Accessibility concerns or updates

Accessibility Checklist

[x] Checked Storybook's "Accessibility" tab for color contrast and other issues.
[x] The feature works with keyboard inputs including tabbing back and forward and pressing space, enter, arrow, and esc keys.
[x] For hidden text or when aria-live is used, a screenreader was used to verify the text is read.
[x] For features that involve UI updates and focusing on DOM refs, focus management was reviewed.
[x] The feature works when the page is zoomed in to 200% and 400%.

Open Questions

Checklist:

[x] I have updated the Storybook documentation and changelog accordingly.
[x] I have added relevant accessibility documentation for this pull request.
[x] All new and existing tests passed.

Front End Review:

[x] Review the Vercel preview deployment once it is ready.

Great, thanks! Was this package always installed so you didn't have to add it to package.json?

I think so, but since we were including svg in the list of elements for fileMock.ts, it wasn't being used.

I don't think all components need to test the SVGs they render, but I think more components can use the data-file-name confirmation test. For example, Accordion could use it but that's not needed for MultiSelect or FilterBarInline because those use Accordions internally. It's not necessary for this PR since it wasn't requested to update all tests, but we should aim to update other component tests later on.

Added Accordion test. I think it's definitely within the scope of this PR to update the tests but I guess by the same token, full coverage of the Icon component makes any tests we would do on Accordion, SocialMediaLinks, etc., redundant since they're using Icon internally. @EdwinGuzman

Yes, I'm also thinking about whether we should just write tests or if they're redundant since the Icon is already tested. I'm ok with what is already written.


Throwing exception in CI/CD build environment because no default credentials

Environment details

OS type and version: Linux (build running as a GitHub Action)
Python version: 3.*

Steps to reproduce

Write python that attempts to call secretmanager.SecretManagerServiceClient()
Try to have GitHub build it as part of a GitHub action

The Problem: CI/CD builds on GitHub fail because GitHub doesn't have cloud credentials
I'm trying to have GitHub do automatic python "builds" before I deploy to cloud.  This Google blog post by @sethvargo seems to indicate that it's possible to have a GitHub build access your secrets from a GitHub Action, but the explanation seems incomplete and I found no other documentation.  Perhaps more fundamentally, I'm not sure why a "build" of this sort should require access to secrets or cloud credentials, but per the error below SecretManagerServiceClient() seems to expect to have default credentials (by way of the main auth package).  That seems to make CI/CD hard or impossible.  Is this intended behavior?
...in <module>
secrets = secretmanager.SecretManagerServiceClient()
  File "/opt/hostedtoolcache/Python/3.7.10/x64/lib/python3.7/site-packages/google/cloud/secretmanager_v1/services/secret_manager_service/client.py", line 375, in __init__
    client_info=client_info,
  File "/opt/hostedtoolcache/Python/3.7.10/x64/lib/python3.7/site-packages/google/cloud/secretmanager_v1/services/secret_manager_service/transports/grpc.py", line 170, in __init__
    scopes=self.AUTH_SCOPES, quota_project_id=quota_project_id
  File "/opt/hostedtoolcache/Python/3.7.10/x64/lib/python3.7/site-packages/google/auth/_default.py", line 470, in default
    raise exceptions.DefaultCredentialsError(_HELP_MESSAGE)
google.auth.exceptions.DefaultCredentialsError: Could not automatically determine credentials. Please set GOOGLE_APPLICATION_CREDENTIALS or explicitly create credentials and re-run the application. For more information, please see https://cloud.google.com/docs/authentication/getting-started

This seems like a similar issue for python-datastore: https://github.com/googleapis/python-datastore/issues/11

You need to provide some authentication to the client. You can either set GOOGLE_APPLICATION_CREDENTIALS or use one of the Google Cloud GitHub Actions to manage authentication: https://github.com/google-github-actions/setup-gcloud.

Hi @steve-kidreads-app - did that solve your issue?

Yes I think so.  It all makes sense but I'm still working on it. Do you think it would be worth updating your article? I'd be happy to give recommendations and/or be the clueless user guinea pig.

Yea sure - let's close this out and email me directly (sethvargo at google) and we can work together to update it.

Ok, I'm re-opening because I've run stuck and it seems like maybe it's a bug (but probably user error).
Per Seth's suggestion and the documentation, I'm now trying to configure my Github Action to export the default application credentials before my Python code tries to use them.  I have this in my .yml Github Action:
    - name: Export GCP default credentials to get build secrets later
      uses: google-github-actions/setup-gcloud@master
      with:
        service_account_email: ${{ secrets.GCP_SERVICE_ACCOUNT_EMAIL }}
        service_account_key: ${{ secrets.GCP_SERVICE_ACCOUNT_KEY }}
        export_default_credentials: true

I've got GCP_SERVICE_ACCOUNT_EMAIL set in my GitHub secrets and I've also set the GCP_SERVICE_ACCOUNT_KEY GitHub secret to the JSON-onput key. When I build, this step is successful:
Run google-github-actions/setup-gcloud@master
/usr/bin/tar xz --warning=no-unknown-keyword -C /home/runner/work/_temp/[redacted] -f /home/runner/work/_temp/[redacted]
/opt/hostedtoolcache/gcloud/330.0.0/x64/bin/gcloud --quiet auth activate-service-account *** --key-file -
Activated service account credentials for: [***]
Successfully exported Default Application Credentials

But when I try to call secrets = secretmanager.SecretManagerServiceClient() in a later step:
  File "/opt/hostedtoolcache/Python/3.7.10/x64/lib/python3.7/site-packages/google/cloud/secretmanager_v1/services/secret_manager_service/client.py", line 375, in __init__
    client_info=client_info,
  File "/opt/hostedtoolcache/Python/3.7.10/x64/lib/python3.7/site-packages/google/cloud/secretmanager_v1/services/secret_manager_service/transports/grpc.py", line 170, in __init__
    scopes=self.AUTH_SCOPES, quota_project_id=quota_project_id
  File "/opt/hostedtoolcache/Python/3.7.10/x64/lib/python3.7/site-packages/google/auth/_default.py", line 441, in default
    credentials, project_id = checker()
  File "/opt/hostedtoolcache/Python/3.7.10/x64/lib/python3.7/site-packages/google/auth/_default.py", line 209, in _get_explicit_environ_credentials
    os.environ[environment_vars.CREDENTIALS]
  File "/opt/hostedtoolcache/Python/3.7.10/x64/lib/python3.7/site-packages/google/auth/_default.py", line 108, in load_credentials_from_file
    "File *** was not found.".format(filename)
google.auth.exceptions.DefaultCredentialsError: File /home/runner/work/kidreads-web/kidreads-web/[redacted] was not found.
Error: Process completed with exit code 1.

The line  os.environ[environment_vars.CREDENTIALS] indicates to me that it's looking at the env var CREDENTIALS instead of GOOGLE_APPLICATION_CREDENTIALS (where the credentials really are).  Is that accurate?  Why wouldn't auth be trying GOOGLE_APPLICATION_CREDENTIALS?

Can you please share your full action.yml? The error message is misleading, but it's looking at an environment variable as defined by the constant named CREDENTIALS. The string value of that constant is "GOOGLE_APPLICATION_CREDENTIALS".

Ahh, just figured it out.  I was exporting the creds before the step that sets up python using actions/setup-python.  So actions/setup-python creates a virtualenv that doesn't include the GOOGLE_APPLICATION_CREDENTIALS that I just exported.  Doing the GCP cred export after that step fixed it.
I had put the setup-cloud step at the very beginning because that "authenticates all future actions" according to the get-secretmanager-secrets documentation, but it looks like those docs don't account for the virtualenv.  The same might be said for the export_default_credentials documentation.
Before and after pasted below for anyone who may run across this in the future:
BEFORE (doesn't work):
name: Django CI

on:
  push:
    branches: [ master ]
  pull_request:
    branches: [ master ]

jobs:
  build:

    runs-on: ubuntu-latest
    strategy:
      max-parallel: 4
      matrix:
        python-version: [3.7, 3.8, 3.9]

    steps:
    - name: Export GCP default credentials to get build secrets later
      uses: google-github-actions/setup-gcloud@master
      with:
        service_account_email: ${{ secrets.GCP_SERVICE_ACCOUNT_EMAIL }}
        service_account_key: ${{ secrets.GCP_SERVICE_ACCOUNT_KEY }}
        export_default_credentials: true
    - uses: actions/checkout@v2
    - name: Set up Python ${{ matrix.python-version }}
      uses: actions/setup-python@v2
      with:
        python-version: ${{ matrix.python-version }}
    - name: Install Dependencies
      run: |
        python -m pip install --upgrade pip
        pip install -r requirements.txt
    - name: Run Tests
      run: |
        python manage.py test

AFTER (works):
name: Django CI

on:
  push:
    branches: [ master ]
  pull_request:
    branches: [ master ]

jobs:
  build:

    runs-on: ubuntu-latest
    strategy:
      max-parallel: 4
      matrix:
        python-version: [3.7, 3.8, 3.9]

    steps:
    - uses: actions/checkout@v2
    - name: Set up Python ${{ matrix.python-version }}
      uses: actions/setup-python@v2
      with:
        python-version: ${{ matrix.python-version }}
    - name: Install Dependencies
      run: |
        python -m pip install --upgrade pip
        pip install -r requirements.txt
    - name: Export GCP default credentials to get build secrets later
      uses: google-github-actions/setup-gcloud@master
      with:
        service_account_email: ${{ secrets.GCP_SERVICE_ACCOUNT_EMAIL }}
        service_account_key: ${{ secrets.GCP_SERVICE_ACCOUNT_KEY }}
        export_default_credentials: true
    - name: Run Tests
      run: |
        python manage.py test


Vite Chinese Page Has Been Reported Risky

Documentation is

[ ] Missing
[ ] Outdated
[ ] Confusing
[X] Not sure?

Explain in Detail

The web page has been alert by firefox browser.
Your Suggestion for Changes
Configure the server time setting.
Reproduction
https://vitejs.cn/
Steps to reproduce
Just open the pages on domain "vitejs.cn".

The official chinese docs of Vite is https://cn.vitejs.dev/. Not https://vitejs.cn

The official chinese docs of Vite is https://cn.vitejs.dev/. Not https://vitejs.cn

Oh,that's a mirror in China,I've mistaken them.


Piston Scepter can move protected blocks

it can grief in protected areas of FtbUtilities and protected blocks by better builder wands

Ah, thanks for reporting.  I hope its easy to detect if the area is protected or not.

I wonder if this same bug applies to other building type tools in here, such as the cyclic build scepter or the scythes

Copying reply here for posterity

LatvianModder commented 14 hours ago
First, you should make a permission nodes for your mod actions - like "cyclic.tool.break", "...place" or just one common node like "cyclic.tool.modify" or smth like that. Register that node in PermissionAPI during INIT (probably with value ALL by default) and then just check with PermissionAPI.hasPermission(gameProfile, node, context) context should contain BlockPos

Reference https://github.com/MinecraftForge/MinecraftForge/pull/3155

Looks like i need minimum forge version Build 1.10.2-<IP_ADDRESS>1

Updated in release 1.9.0 to use the api


added my school's 6th form

in footer of any page you can see proof of email format https://gosfordhillschool.org/sixth-form/sixth-form-prospectus/ page 15 of doc for proof of computer science course https://gosfordhillschool.org/sixth-form/pastoral-structure/ proof of 2y long course (y 12 &13 )
all https://gosfordhillschool.org/ links redirect to gosford-hill.oxon.sch.uk as gosford-hill.oxon.sch.uk is the schools old domain and still the main one for the website
feel free to contact me if you need more information

@voidapex11 I have to close this request without merging, because you requested to add a non-existent domain to this repository: Host students.gosford-hill-school.org not found: 3(NXDOMAIN) Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for your understanding!


Don't assume variables set in a try clause are available in the finally clause

This is not a critical bug!
This code led to another error because it was assuming the variables had been set but they were undefined for me when the finally clause ran.
https://github.com/yuvipanda/hubploy/blob/5b4443ff1f4e372c6faf47cb7d6dca363fd61a6f/hubploy/auth.py#L332-L340

Fixed by #105


'scan' is not a docker command

Looks like scan is now included in docker desktop (Windows/Mac OS) and apt version but not in snap version yet.
Is it possible to add docker-scan-plugin on the snap version ?
https://github.com/docker/scan-cli-plugin

I think installing this out-of-band is probably going to be the best option (given it's an optional CLI plugin and not all users will necessarily want it, and adding it by default increases the size/surface of the snap).  There should be some useful tips in https://github.com/docker-snap/docker-snap/issues/38 for doing so.


Implement remaining methods in akro.Dict

All methods currently raising a NotImplementedError should be completed within dict.py.

This was fixed by #40


Mantis version: 2.4.0
How to replicate
My settings
cropVC.config.presetFixedRatioType = .alwaysUsingOnePresetFixedRatio(ratio: 1/1)
cropVC.config.cropViewConfig.cropShapeType = .circle(maskOnly: true)

Example image 514 x 546

Size after cropping without zooming or panning: 514 x 513

I've added some extra check and cropping functionality in my code to get around this issue, but it would be ideal if the result for 1:1 images was actually 1:1 😅

@budidino
Can you have a test using Mantis 2.5.2 which I just just released for fixing this issue?
Thanks!

@guoyingtao I can confirm that it works 👍 🚀


whenLoaded sets attribute in resource even if relation is not loaded

Laravel Version: 5.7.19
PHP Version: 7.2.11
Database Driver & Version: mysql 8.0.13

Description:
I have a belongsTo relation from a SubscriptionPeriod to a Subscription and have the following resource:
<?php

namespace App\Http\Resources\Subscriptions;

use Illuminate\Http\Resources\Json\JsonResource;

class SubscriptionPeriodResource extends JsonResource
{
    /**
     * Transform the resource into an array.
     *
     * @param  \Illuminate\Http\Request $request
     *
     * @return array
     */
    public function toArray($request)
    {
        dump($this->resource);  // no `subscription` relation is loaded
        dump('is it loaded', $this->resource->relationLoaded('subscription'));  // returns `false`
        return [
            'id' => $this->id,
            'name' => $this->name,
            'subscription' => new SubscriptionResource($this->whenLoaded('subscription')),
        ];
    }
}

Even though, the subscription relation is not loaded and $this->resource->relationLoaded('subscription') returns false, my SubscriptionResource is still being included.
I have simplified my calling controller function a lot to isolate this:
    public function index(SubscriptionPeriod $subscriptionPeriod, GetAllMilestonesForSubscriptionPeriodWithStatus $getAllMilestonesForSubscriptionPeriodWithStatus)
    {
//        $subscriptionPeriod->load('milestones', 'previousPeriod', 'followingPeriod');

//        $subscriptionPeriod->milestones_with_status = $getAllMilestonesForSubscriptionPeriodWithStatus->execute($subscriptionPeriod);

        return response()->api('Milestone meta data', new SubscriptionPeriodResource($subscriptionPeriod));
    }

I haven't experienced this before and it works correctly with other relations so I'm not sure what I'm doing wrong here.
Even loading like this still loads the relation:
        dump($this->resource->relationLoaded('subscription')); // `false`
        return [
            'id' => $this->id,
            'name' => $this->name,
            'subscription' => $this->when($this->resource->relationLoaded('subscription'), function () {
                return new SubscriptionResource($this->subscription);
            }),   // somehow becomes `true` here

The response I'm getting when I hit the endpoint:
{
    "status": "positive",
    "messages": {
        "default": [
            "Milestone meta data"
        ]
    },
    "result": {
        "id": 2,
        "name": "Eveniet.",
        "subscription": {
            "id": 1
        }
    }
}

I have resorted to doing this for the time being which works as expected for some magical reason:
  $subscriptionLoaded = $this->resource->relationLoaded('subscription');

        return [
            'id' => $this->id,
            'name' => $this->name,
            'subscription' => $this->when($subscriptionLoaded, function () {
                return new SubscriptionResource($this->subscription);
            }),

Steps To Reproduce:
Create a resource and try to conditionally include a belongsTo relation using whenLoaded.

@Mr648 i just had this happen and your trick worked for me as well. I don't know why whenLoaded isn't working "as expected," especially because it does work as expected elsewhere in the same app.

This happens for resources only, collections works fine.


Enable building PowerShell for Apple M1 runtime

PR Summary
Add support to Start-PSBuild with runtime osx-arm64.  Requires https://github.com/PowerShell/PowerShell-Native/pull/64 to be published first.  A local build of both works.  When looking for crossgen, there appears to be one found under x64-arm64 folder which fails, but the one in the parent tools folder works so need to filter that out for when finding crossgen.
PR Context

PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[x] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ ] Issue filed:

So does this build a universal binary or just one compiled for arm64? Does it require any work from .NET, I remember reading something about M1 support in the new preview so assumed PowerShell had to wait for that.

@jborean93 This PR leverages dotnet to build M1 optimized binaries.  It depends on https://github.com/PowerShell/PowerShell-Native/pull/64 which builds universal native binaries for pwsh.

Awesome thanks for the info, will have to get a move on updating the mi fork to produce arm64 libraries so powershell can use them.

@TravisEz13 I spent some time looking at the yml and psm1 that does the build, but it's much more complicated now than the last time I made changes.  I would suggest having it integrated with the build as a separate PR.

@SteveL-MSFT  is this ready to merge?  Don't we need the updated native nuget?

The description says it is dependent on the PR in PS-Native repo. The NuGet package after merging that that PR has to be released too.


Breaking change in Node 13.13

Node v13.13 has made a breaking change to exports
To fix this babel/core needs to be upgraded to v7.9.0
This issue is detailed in issue nodejs/node#32852

babel-eslint doesn't depend on @babel/core. Also, it use ^ for its dependencies so you can automatically update them.

Sorry, I must have missed that


[CELEBORN-640][PERF] DataPushQueue should not keep waiting take tasks

What changes were proposed in this pull request?
In our prod meet many times of push queue stuck caused by PushState's status was not being removed.
Caused DataPushQueue to keep waiting for taking task.
Although have resolved some bugs, here we'd better add a max wait time for taking tasks since we already have the PUSH_DATA_TIMEOUT check method. If the target worker is really stuck, we can retry our task finally.
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?

ping @waitinfuture @RexXiong @FMX WDYT?

@RexXiong Any more suggestion?


Add additional instructions on how to configure orchestrators for worker nodes after joining

File: ee/ucp/admin/configure/join-nodes/join-linux-nodes-to-cluster.md
Currently there is no documented process for switching Orchestrators upon joining by CLI. The process for doing so via the UI is very well documented but the process of doing this by CLI is not documented. Below are some suggestions from the Docker team:
You can change orchestrators from Swarm to Kube after joining by setting the swarm node label "com.docker.ucp.orchestrator.kubernetes" to "true".
Node labels are how you change individual nodes' orchestrators; this is expected and this is the desired API for doing so. You can set node labels through the Docker API.
You can modify the UCP config through the /api/ucp/config-toml API as well:
https://docs.docker.com/reference/ucp/3.1/api/
This lets you change the default node orchestrator, although you shouldn't need to change this very often. You can also supply a config file at install time.
cc @paigehargrave

@david-yu Hi David - I think the CLI portion is documented here: https://docs.docker.com/ee/ucp/admin/configure/set-orchestrator-type/#use-the-cli-to-set-the-orchestrator-type. Please let me know if this is not what you are looking for. With regard to the API information, I can add a link to that in both https://docs.docker.com/ee/ucp/admin/configure/join-nodes/join-linux-nodes-to-cluster/ and https://docs.docker.com/ee/ucp/admin/configure/set-orchestrator-type/. Would that work, and if not, please let me know what you prefer. Thank you!

No I should've scrolled down. Thanks, I'll close this.

@david-yu - Seems like I should add a note about the API information - what do you think? Also, I'm happy to move the information to be in a more logical spot.

You mean this particular part? Yes it would be helpful to see that in the docs, but not a high priority item:

You can modify the UCP config through the /api/ucp/config-toml API as well:
https://docs.docker.com/reference/ucp/3.1/api/
This lets you change the default node orchestrator, although you shouldn't need to change this very often. You can also supply a config file at install time.


Remove all uses of User.admin

History:

A "super admin" user was original identified by User.admin = true
That was suboptimal, because it meant that it always applied to a user account, regardless of project, so a super admin could not use the same User for non admin work.  Therefore, they could not use Google auth / 2fa for the same account.
So, earlier this year, we replaced the model, so "super admin" is identified by Project.superAdmin = true
That allows a user to choose super admin status during the "Choose Profile" stage of login

There were still a handful of code paths that used User.admin, notably "Rebuild StructureDefinitions", "Rebuild SearchParameters", etc.  Those are rarely used features, but they do come up from time to time.
This PR removes all uses of User.admin.
In a future PR, we can remove the property entirely from schema and type definitions.  That will require a db migration to remove the admin property from all User objects though.

Coverage decreased (-0.002%) to 94.057% when pulling 892d09832d958dc1ddd96343f3de98331f060333 on cody-remove-user-admin-uses into efb5f360680434b17abe1818295d49442437e853 on main.


Using custom template, how can i call function that the tree component is on?

I have a tree that displays nodes.  On each node i have a custom template, which offers the options Edit, Copy and Delete.  When one of these options is pressed, i would like to open a modal window (using ng2-bootstrap) and ask the user to confirm their action.
Now i can do this, if I create a modal window in the custom template, but that seems like a lot of HTML to repeat for each node, so instead i would like to have my ModalComponent on the same component as my tree, and somehow raise an event when a button in a template is pressed....
How can i do this?  Here is what i have so far
pages.component.html
<Tree #tree [nodes]="nodes" [options]="options"></Tree>

    <page-copy-modal #copyModal="copyModal" [page]="tree.activeNode.data"></page-copy-modal>

pages.component.ts
import { Component, OnInit } from '@angular/core';
import { TreeComponent } from 'angular2-tree-component';
import { PagesTreeNodeComponent } from './pages-tree-node.component';
import { PageCopyModalComponent } from './page-copy-modal.component';

@Component({
    selector: 'pages',
    templateUrl: 'app/admin/page/pages.component.html',
    directives: [ TreeComponent, RouterLink, PageCopyModalComponent ]
})

export class PagesComponent implements OnInit {

    nodes: Page[];
    options: Object = {
        treeNodeTemplate: PagesTreeNodeComponent
    };

    ngOnInit() {
        // nodes loaded here
    }

   // need these functions to be called from pages-tree-node-component.ts
   onEdit () { }
   onCopy () { }
   onDelete () { }
}

pages-tree-node.component.html
{{ node.displayField }}

    Edit |
    Copy |
    Delete

pages-tree-node.component.ts
import { Component, Input } from '@angular/core';
import { Router } from '@angular/router-deprecated';
import { TreeNode } from 'angular2-tree-component';

@Component({
    selector: 'pages-tree-node',
    templateUrl: 'app/admin/page/pages-tree-node.component.html'
})

export class PagesTreeNodeComponent {

    @Input()
    node: TreeNode;

    // on editing a page
    onEdit() {
        // call event on PagesComponent for edit??
    }

    onCopy() {
        // call event on PagesComponent for copy??
    }

    onDelete() {
        // call event on PagesComponent for delete??
    }
}

page-copy-modal.component.html

Copy page

                Are you sure you want to copy this page, all its contents and all of it's child pages?

                <button type="button" class="btn btn-outline-primary" (click)="onCopy()" aria-label="Copy">
                    Copy
                </button>
                <button type="button" class="btn btn-outline-secondary" (click)="lgModal.hide()" aria-label="Cancel">
                    Cancel
                </button>

page-copy-modal.component.ts
import { Component, Input, ViewChild} from '@angular/core'
import { CORE_DIRECTIVES } from '@angular/common'
import { MODAL_DIRECTIVES } from 'ng2-bootstrap/components/modal';
import { ComponentsHelper } from 'ng2-bootstrap/components/utils/components-helper.service';

@Component({
    selector: 'page-copy-modal',
    directives: [ MODAL_DIRECTIVES, CORE_DIRECTIVES ],
    viewProviders: [ ComponentsHelper ],
    templateUrl: 'app/admin/page/page-copy-modal.component.html',
    exportAs: 'copyModal'
})

export class PageCopyModalComponent {

    @ViewChild('lgModal')
    lgModal;

    @Input: any
    page;

    show(){
        this.lgModal.show();
    }

    onCopy() {

    }
}

This is an interesting question. Sending events between components is bad practice IMO, since it's not a unidirectional data flow (if anything, rather use Redux).
I can allow passing a context to the tree node template. Something like:
options = {
  context: this,
  treeNodeTemplate: PagesTreeNodeComponent
}

{{ node.displayField }}

    Edit |
    Copy |
    Delete

Does that sound reasonable?

Yes that could work!  Is this functionality already within the code or do you need to do work to support this, and if so, how long? :)

I agree that events is not the way forward, but this is a very good solution and i think other users will want this sort of functionality in custom templates

It's still not in the code, I'll add it.
Hopefully I can get to it soon. Feel free to fork it and add it in the
meantime
On Thu, Jul 14, 2016 at 11:30 AM, Gillardo<EMAIL_ADDRESS>wrote:

I agree that events is not the way forward, but this is a very good
solution and i think other users will want this sort of functionality in
custom templates
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/500tech/angular2-tree-component/issues/15#issuecomment-232600719,
or mute the thread
https://github.com/notifications/unsubscribe/ACUsQxFYkM_h-EV3cjOucPJezbHHDyCBks5qVfOIgaJpZM4JKjhd
.

--
Adam Klein
CTO & Co-Founder
Tel. +972-52-747-5633
blog.500tech.com http://blog.500tech.com
meetup.com/angularjs-il

Published 1.1.10 to NPM which adds context to options


No viewBox for SVG

Hi, love the tool. I'm having a small problem with resizing the QR. In order for the PNG to export at the resolution required, I'm changing the width and height options to 1200, but this makes the SVG preview very large in the page, and I need it to stay small while being previewed.
This would be easy to do with CSS, but to resize an SVG you need a viewBox attribute specified and currently there isnt one, can you advise?

Hi @mpmrepository, you can change the size of the canvas container via CSS.
For the README example it will be:
`...

...
`

Thanks :) We actually need the SCG version rather than canvas for our purposes, but I've used
qrCode.firstChild.setAttribute('viewBox', '0 0 300 3000')
to achieve what i needed

@kozakdenys FWIW viewBox is critical if you want to generate inline SVGs that can resize dynamically. Without viewBox, the SVG just crops. This should be added by default.

Hi @graemeblackwood @mpmrepository
Sorry for missing
It was fixed in v1.8.0


VictoryGroup only renders children properly if "Debug JS Remotely" is enabled

Rendering without remote JS debugging:

Making no code changes, but using the Debug JS Remotely developer option:

Versions:
    "victory-native": "^0.13.0"

The problem isn't with VictoryLine, VictoryArea, etc. It's with VictoryGroup.
If you place a working chart inside <VictoryGroup /> this will happen. If you remove VictoryGroup then it works.

I had exactly the same problem


[@ngtools/webpack]: incorrent import of entry module since 1.8.0-rc.4

Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request

Versions.

os: windows 10
node: 8.8.1
npm: 5.3.0
webpack: 3.8.1
Repro steps.

I am using AngularCompilerPlugin like:
new ngc.AngularCompilerPlugin({
                tsConfigPath: helpers.root('tsconfig.aot.json'),
                entryModule: helpers.root('src/app/app.module.ts#AppModule')
            }),

In my main.ts I have the following bootstrap code:
import {platformBrowserDynamic} from "@angular/platform-browser-dynamic";
import {AppModule} from "../../app/app.module";

platformBrowserDynamic()
    .bootstrapModule(AppModule, {
        preserveWhitespaces: false
    })
    .catch(err => console.error(err));

It seems since 1.8.0-rc.4 plugin built incorrect import of AppModule while transforming main.ts code, because I receive an build error: ERROR in ./src/platform/browser/main.ts Module not found: Error: Can't resolve './../../app/app.module.ts.ngfactory' . The import must be ./../../app/app.module.ngfactory. Reproduces in last 1.8.0-rc.6
This error does not occurs in 1.8.0-rc.3

You shouldn't have the file extention in the entry module. Can you try this instead?
entryModule: helpers.root('src/app/app.module#AppModule')

It might have been working before but that wasn't intended.

@filipesilva thank you, it helps


Update benchmarks.tsx

Added missing space

Fixing Prettier now

@lucacasonato Running format + lint, no issues?


Could not decode variant with type_name: "tensorflow::DatasetVariantWrapper"

Hi,
When I tried to modify the source code to support distributed training, the following error happened:
E tensorflow/core/framework/variant.cc:102] Could not decode variant with type_name: "tensorflow::DatasetVariantWrapper".  Perhaps you forgot to register a decoder via REGISTER_UNARY_VARIANT_DECODE_FUNCTION?

It seems that tensorflow::DatasetVariantWrapper is not supported, but I did run it successfully in a standalone machine. Anyone knows why the error happens?
Thanks

I have the same issue. Did you resolve this?

I have the same issue too. It seems that make_initializable_iterator does not work

My case is that when I bacth the dataset this error appears, but when I cancel it other error happens.


(ANDROID) No response when selecting the notification while running the app

OnNotificationOpen is not called.
What can I do to solve the problem

Closing due to inactivity.  Please reopen if this is still an issue with v2 of the plugin.

Same here, tested it on various Android version (iOS works) but always get:
02-23 20:01:49.123  1845  3383 I ActivityManager: START u0 {act=FCM_PLUGIN_ACTIVITY flg=0x14000000 pkg=com.*** (has extras)} from uid 11042 on display 0 02-23 20:01:49.126  1845  2083 W InputMethodManagerService: Window already focused, ignoring focus gain of: com.android.internal.view.IInputMethodClient$Stub$Proxy@d1a22ef attribute=null, token = android.os.BinderProxy@f5dbbf


fix: roadmap modal overlay fix

This pull request fixes overlay issue of roadmap modal for both larger and smaller devices
Output on different screen sizes :-

Fixes #1906

@vishvamsinh28 sorry mate but I closing it in favour of https://github.com/asyncapi/website/pull/1918 as the priority here have people that report issue, if they create PR, their PR is first to take and I see the contributor continues the work. Feel free to jump in there and help with review.
Don't feel discouraged by the fact that I close your PR but please take it as a lesson. Open source is not about speed and who first creates a PR but more about collaboration and community. So if you want to take up some task, first clarify nobody else is working on it


Document how to create a "one-off" PyPI release

This was recently used for the DP-PCA
Document it for other team members

Actions > Show More Workflows... > Release > Run Workflow
Then choose the branch you want to release, and check dry run.
Here's how all the options work:

The target channel controls how the release is tagged, and what semantic version is given to the release
The "sync the Channel from upstream?" checkbox is for when you want to update the nightly, beta or stable branches. For when you want to commit to a new official nightly/beta/stable release.
Update the version counter when you want to release another nightly in a single day.
Dry runs get sent to test-pypi, and don't update the docs
Fake is for developer convenience when debugging CI: it skips compilation and inserts dummy binaries instead


Spelling and grammar changes

Troll PR request.

Just a well-intentioned (and hopefully harmless) joke PR :)


feat: add caching mechanism using localStorage

What is the current behavior?

Please describe the current behavior that you are modifying, or link to a relevant issue.

This PR will resolve #28
This pull request adds caching mechanism for data that expires in one day span using localStorage. Previously, the data will still be fetched on every revalidation which is unnecessary since the data itself is refreshed once per day.
What is the new behavior?
SWR will now check for cache existence in localStorage using custom provider.
If the data exist, SWR will also check whether the data is expired or not. If it's expired, it will return undefined and forces SWR to re-fetch the data. If it's not expired, the data is served without having to do any network requests.
Screenshots

Sorry for breaking the PR template.

Before
This network call will always exist on every revalidation scenario.

After
First request (same as before)

Subsequent request (network call is gone)
 |
Notes

We need to use swr/immutable since we are disabling automatic revalidation.
Since the timestamp is generated locally, the user might receive stale data for a period of time.

Checked the preview page, and it's also looks good


Fix add variant to cart test after removing cart view

Fix test and remove cypress from dependencies in app/storefront

You need to run pnpm i to update the lockfile @szczecha


STs seem to be broken on newer docker releases

I tried to run cd calico_node; make st on my dev machine.  I see errors in the console from docker.
Expected Behavior
Clean ST run.
Current Behavior
docker exec -it host1 sh -c 'docker network create --driver calico --ipam-driver calico-ipam  testnet1'
  # Return code: 1
  # Error response from daemon: legacy plugin: plugin not found
  #

Possible Solution
Looks like a change to the docker API has broken the STs?
Steps to Reproduce (for bugs)

cd calico_node
make st ST_TO_RUN=tests/st/policy/test_profile.py

Context
This is blocking development of STs for the feature I'm working on.
Your Environment

Calico version: master de0528c845e75998a02ff00923592f63819c5fbf
Orchestrator version (e.g. kubernetes, mesos, rkt):

$ docker version
Client:
 Version:      17.05.0-ce
 API version:  1.29
 Go version:   go1.7.5
 Git commit:   89658be
 Built:        Thu May  4 22:10:54 2017
 OS/Arch:      linux/amd64

Server:
 Version:      17.05.0-ce
 API version:  1.29 (minimum version 1.12)
 Go version:   go1.7.5
 Git commit:   89658be
 Built:        Thu May  4 22:10:54 2017
 OS/Arch:      linux/amd64
 Experimental: false

Operating System and version:
Ubuntu 16.04

$ uname -a
Linux smc-ubuntu 4.4.0-78-generic #99-Ubuntu SMP Thu Apr 27 15:29:09 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

Link to your project (optional):

@fasaxc do you recall if this is still an issue?

ISTR that others didn't have he same problem


Add GeoLocation field to profile

Add Optional Geolocation tag to profile.
People can choose to reveal their location or not.
Also, some Tasks might be needed to be done in a specific geo location. Add Geolocation to tasks as well.

I am removing the balance field from profile as its duplication and will not be updated by the balances pallet.

How do we check the balance for a profile then? We have to document this because it breaks the UI.

https://stackoverflow.com/questions/64210673/how-do-you-format-balances-with-the-polkadot-js-api


[PASS] fix buffer overlap when reuse small buffers

fix overlap issue in #942
for case in this patch, the ir after pass is
// attr [A] storage_scope = "local.L0A"
allocate A[int16 * 800]
for (i, 0, n) {
  for (j, 0, 10) {
    A[j] = (int16)1
    A[(200 + j)] = (int16)1
    A[j] = (A[j] + A[(200 + j)])
    A[j] = (int16)1
    A[(400 + j)] = (int16)1
    A[j] = A[j]
    A[j] = (int16)1
    A[(200 + j)] = (int16)1
    A[j] = (A[j] + A[(200 + j)])
  }
}

a simpler fix in #1012  we can migrate the additional testcase over if necessary


launcher, nic hotplug: use recommended attach device func

What this PR does / why we need it:
Reading the libvirt documentation it is clearly stated the AttachDeviceFlags command is preferred to the AttachedDevice call - [0]:

For compatibility, this method can also be used to change the media in an
existing CDROM/Floppy device, however, applications are recommended to use the virDomainUpdateDeviceFlags method instead.

[0] - https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainAttachDevice
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

NONE

/cc @ormergi

/sig network

/lgtm


Add new alternative email field on tester profile page

We found from #119 when checking if tester responses matched testers' profiles that they did not accurately include the email that they signed up for CUTGroup with. It would be just good practice to add a second email field that these testers' use as part of their profile.
This would not be added to the sign-up process, but be a place for us to add more information as we learn it from tests or other communications.

The second piece of this is when allowing a tester to use either email on the test forms and Patterns correctly associating the form with the tester.

Due to the complexity of checking two different email addresses in our current system, this is going to be a low priority item.
At this time, if we see cases of an alternative email address used, we will capture that in the "Notes" section on the tester profile page.
We will monitor the "Orphan" submissions (#170) to see if this is a bigger issue that needs to be addressed and is higher priority.


Build initial infrastructure for stock admin app

Build initial infrastructure for stock admin app

Create frontend app
Create backend app
Create initial design
Wire up frontend and backend
Add component lib other required initial frontend infrastructure

Feature completed


the file "preprocess.py" is missing

Hi, when I tried running the "get_data.sh" file, I found the "preprocess.py" file is missing. Could you upload it? Thanks!

Hi, the file is not missing and here it is
https://github.com/salesforce/DNNC-few-shot-intent/blob/master/data/nli/preprocess.py
Thanks!