Large file partitioning

For some larges files (typically generated) like Syntax.xml.generated.cs in Roslyn codebase, it might be nice to split them (along definition boundaries) so that they can more efficiently be pulled for peek definition and potentially even GoToDef would only show the fragment.

Also consider applying some of the same tricks SourceBrowser did to lighten up the page, turn off classification, etc.

That seems to be targeted at rendering which I don't believe is a substantial problem for Monaco (it only renders the visible lines). That said, I'm not sure how it factors into the minimap. If its a problem, the minimap can be disabled for large files.


IRWS publishing preference post (EDS-110)

Coverage increased (+0.63%) to 83.68% when pulling e2011a4acbe09fe4aa3dbfe84db27d6fe6e28651 on jeffFranklin:master into 74b8539d361ec741cc9969c9b3d4280b2e101c02 on UWIT-IAM:master.


Add a Codacy badge to README.md

@all-contributors

@all-contributors please add @dreambo8563 for code, doc and infra


Revert "Optimize Nigeria observed holidays"

Reverts dr-prodigy/python-holidays#978

Coverage: 100.0%. Remained the same when pulling aaa9b424d2bccd38e42e60c4d523917305033990 on revert-978-opt-nigeria-obs into 90297a52bbea87ff4cfe88c486d8e3b7237bc930 on beta.


Easier navigation via ToC - variation 1

Replaces pull request #28
Complete ToC at the top of the document. This might be to long. See therefore variation 2, where several ToCs are place at the top of each section (account, api, char etc.)

I like it all being together at the top like that, at the same time however it is really long and will just get longer.
Should we maybe consider different pages?

Should we maybe consider different pages?

Ha! That was my first thought when I had a look at the repository. But I thought "There must be a reason for crunching eventhing into one file." I'm all for splitting things up, even down to one page per endpoint ...

OK, serious suggestion:
We keep endpoint.md as an entry point to the various separate endpoint pages. We keep the ToC there. With no content but the ToC, the ToC can "spread a bit" and provide a one line sentence about what the endpoint is about in addition to linking to the separate page for that endpoint. So that newcomers to the APi get a clue where to look for what.
If we go for this scenario, the decision to make is wether each endpoint becomes a separate file (like xmlapi_account_accountbalance.md) or if we long for fewer files and split them amongst the main categories like /account, /api, /char etc.
I'd personally go for one endpoint per page/file. Results in a bunch of files, but should make merging pull requests less painfull than with one big file.

See #31 for an example of my above suggestion.

This is superseded by #31


Complementatry fix for issue #22 (taking project number prefix into account)

The default regex for "0 Error(s)" and "0 Warning(s)" don't work when lines start with a project number prefix.
Ex:
2>    0 Warning(s)
2>    0 Error(s)
This fix has been tested by building VSColorOutput.sln with VS 2022 Community.

Thanks!


Styling username input

Issue link

n/a
Closes #XXX
Types of changes

New feature (non-breaking change that adds functionality)
Notes


(maint) Add CODEOWNERS

Hey @mwaggett,
This module currently wouldn't be owned by the modules team and probably lives more under the umbrella of community maintained modules.

@pmcmaw Are you saying there are particular community members who want to take ownership of this module? Or should we move this project to the https://github.com/puppetlabs-toy-chest namespace? We are striving for everything in the puppetlabs namespace to have an owner, so if no one at Puppet wants to own this, we will move it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Creation of Consumption Views for RO List Report missing

The creation of the Consumption Views for the readonly list report is missing. This should be added to the ro_list_report.md file

fixed in b98522e


could not refresh installation id INSTALLATION_ID's token

I am trying to use the client, and I keep getting the error
Get "https://api.github.com/meta": could not refresh installation id INSTALLATION_ID's token: received non 2xx response status "404 Not Found" when fetching https://api.github.com/installations/INSTALLATION_ID/access_tokens

func main() {
	tr := http.DefaultTransport

	// Wrap the shared transport for use with the app ID 1 authenticating with installation ID 99.
	itr, err := ghinstallation.NewKeyFromFile(tr, APP_ID, INSTALLATION_ID, PEM_FILE)
	if err != nil {
		panic(err)
	}

	// Use installation transport with github.com/google/go-github
	gclient := github.NewClient(&http.Client{Transport: itr})
	_, _, err = gclient.APIMeta(context.TODO())
	if err != nil {
		panic(err) // ERROR HERE
	}
}

I am able to access the meta with the following curl commands -
curl --request POST \
--url "https://api.github.com/app/installations/INSTALLATION_ID/access_tokens" \
--header "Accept: application/vnd.github+json" \
--header "Authorization: Bearer JWT_TOKEN" \
--header "X-GitHub-Api-Version: 2022-11-28"

curl --request GET \
--url "https://api.github.com/meta" \
--header "Accept: application/vnd.github+json" \
--header "Authorization: Bearer ACCESS_TOKEN_FROM_RESPONSE" \
--header "X-GitHub-Api-Version: 2022-11-28"

What am I missing?

closing because my ide did me dirty and imported "github.com/DataDog/ghinstallation"


Mdoc datamodel

MDOC-CBOR Data Model
Content
This PR closes #18
Review

[x] Ensure your files are written following RST specs (not MD!)
[ ] Italian version
[x] English version
[ ] Example files
[x] Ask for review

@fmarino-ipzs introducing mdoc cbor has impacts on the issuance, credential_definition must use doctype instead of type or vct

@fmarino-ipzs introducing mdoc cbor has impacts on the issuance, credential_definition must use doctype instead of type or vct

I think that the Issuance protocol should be credential format agnostic. Otherwise, we have to parse the credential_definition claim according to the format one. The format should refer to the credential and not to the JSON which conveys the credential_definition claim.

@fmarino-ipzs it's not our choice, this comes from the standards OpenID4VC and HAIP


The webui are not showing the numpy version

It do not show in the first page:

But show in the internal page:

The cache are woking very well

The same happens with scipy package

Oh, good! Someone reported this a while ago but I was unable to reproduce it. I'll give it a try with numpy & scipy and see if I can track it down this time


Some enhancements that came up in my mind

I make a tour of the town with Hauk and some enhancements came up to my mind :

My phone kill the app to save the batterie, on the map its not showing that i'm not connected anymore it would be nice to have a timeout on the server side
When i'm not moving the arrow start doing some 360° freestyle, maybe you can attach it to the gyroscope of the phone ?
Is there any satellite maps except the one of google ? so we can choose on the live maps which one we want
And for the last its maybe a little overkill
Can you add a list of public server that the phone can ping to see if they are up so any users can share their position without setup a server ? I would love to share mine !
Thanks for your work and your fast support :smile:

Thanks for your requests!

My phone kill the app to save the batterie, on the map its not showing that i'm not connected anymore it would be nice to have a timeout on the server side

What phone do you have? Android may kill apps that are in the background if it needs resources, but normally killing a foreground service (like Hauk) should only happen if the resource pool is completely exhausted. Any idea if the similar app Glympse is also affected by this behavior?
Some manufacturers also like to put additional restrictions in place. OnePlus, for example, has its own "battery optimizations" section in device settings that you may have to manually whitelist the app in for it to work.
I don't have a timeout currently because there are legitimate reasons for the app to fail sending updates to the server, like if the phone moves out of cell service. I can see if I can add a feature to the client that shows a small notice when no updates have been received for the past X minutes (1 minute, 2 minutes, whatever works best).

When i'm not moving the arrow start doing some 360° freestyle, maybe you can attach it to the gyroscope of the phone ?

The phone gyroscope can be notoriously unreliable. I can certainly add this and test it, though.

Is there any satellite maps except the one of google ? so we can choose on the live maps which one we want

Yes, the map can use any provider that can be supported by Leaflet. Take a look at the Leaflet provider demo here, in particular the Esri.WorldImagery provider. I don't know what requirements Esri has, or if you have to subscribe to their service to be allowed to use their maps. Mapbox also offers satellite maps IIRC, I'm pretty sure these can also be used by Leaflet. You have to sign up for an account and get an API key to use it, but their free tier has a pretty generous quota.

Can you add a list of public server that the phone can ping to see if they are up so any users can share their position without setup a server ? I would love to share mine !

This is not really desirable right now, particularly from a privacy perspective. The issue is that if you connect the Hauk app to a third party server, you have to trust the administrator of that server that they don't log the data. There is nothing actually stopping a server owner from stalking you and otherwise using your location data maliciously if you send it to them. This is actually a generalized problem with self-hosted software - if anyone can host an instance, and you don't know who the host is, how can you hold them accountable? So you are strongly recommended to host your own instance.
Users unwilling to host their own instances will be left without any assurances of the privacy of their data, so they'd be actually better off using public services like Glympse, which at least have privacy policies to adhere to.
Thanks for your feedback, I appreciate it :-)

Hi this issue is for my phone only, Its even killing the sms app if I don't disable it lol I tested Glypse and yeah after 1-2 minutes the website didn't have any update of my phone.

I can add a feature to the client that shows a small notice when no updates have been received for the past X minutes (1 minute, 2 minutes, whatever works best).
Yeah you can maybe write a warning on the server side that show after 1 or 2 minutes there has been no update and after the time sharing duration that the client selected  before sharing the position the link would be either on a expired state or on a "archive" state where the last position is grayed for example

Users unwilling to host their own instances will be left without any assurances of the privacy of their data, so they'd be actually better off using public services like Glympse, which at least have privacy policies to adhere to.
Yeah you right on that point
Can't wait to see this app grow up !

When i'm not moving the arrow start doing some 360° freestyle, maybe you can attach it to the gyroscope of the phone ?

I don't like the idea of using the gyroscope for that. @bilde2910 How about changing the icon from an arrow to a circle?

How about changing the icon from an arrow to a circle?

That's actually a really good idea! I can change it to a circle if the speed is 0 km/h. Thanks for the suggestion :-)

The icon will now be a circle when the velocity is "0.0" of whichever unit of measurement is configured.


Updated helm chart based on latest code.

/cc @marun @shashidharatd @pmorie
I will update document as well for how to update the chart with https://github.com/kubernetes-sigs/federation-v2/blob/master/scripts/generate-install-crds-yaml.sh

/lgtm
Thanks @gyliu513!

/approve


Vike Extensions: Data Mangement Stores (Redux, Vuex, ...)

Develop Vike Extensions to automatically integrate with data mangement stores such as Vuex and Redux.
I expect such Vike Extension to resemble vike-react-query; checking how vike-react-query is implemented is a good start.
Prior art:

Vike + Redux: https://vike.dev/redux#examples
Vike + Vuex: https://vike.dev/vuex#examples
Vike + Pinia: https://vike.dev/pinia#examples

CC @lostpebble (creator of PullState) and @dai-shi (creator of Zustand/Jotai/Valtio).

@brillout I'll take a look at Pinia, Vuex is sorta deprecated nowadays.

Hi!
I'm interested in working on the integration of Vike + Redux.  Can I work on this? 👀

@yoshi2no Yes! I just grabbed vike-redux on npm; let me know your npm handle add I'll make you co-owner.

@brillout
Thank you!
https://www.npmjs.com/~yoshi2no

@yoshi2no Done.

Closing in favor of https://github.com/vikejs/vike/issues/1715.


Need help - Sample plugin fails to install

Following the directions here:  https://github.com/IBM/kui/tree/master/packages/kui-builder/examples/plugin-sample
I copied the plugin-sample directory from that location and placed it in the top level plugins directory, and then ran npm run compile in the root directory as indicated by directions.
Aftewards, I cd clients/default and tried rebuilding the proxy and webpack npm run build:proxy and npm run build:webpack.
I noticed that one of the steps fails in the link-universe.sh script in regards to the plugin-sample:

At some point during the proxy build, the plugin-sample in the top level plugins directory gets cleared out, and just leaves behind the .gitignore file.

Which then requires recopying the directory back in, in order to run the npm run build:webpack script. Started both containers, and loaded the web UI.  The sample commands failed with Command not found.

Thanks! This is caused by we forgot to update the plugin-sample for a while. Sorry about that!


Need a way to supply debug flags from command line

Hard to get the -vvv that's sometimes needed into the Makefile.
Suggest an extra variable PLAYBOOK_FLAGS_USER that can be set from the command line.

I added 'make apply-debug' and 'make test-debug'.  I also added OPTIONS= keyword.  All in d627e4471b2026897d93d678251445359ecc92d7


Add InsuredValue option for UPS packages

Fixes #52
Adds an optional :insured_value option to packages for use with UPS.

Thanks.
Build is 🔴 but it has to do with remote tests, unrelated to this change. I'll get those dealt with separately.

@kmcphillips Thanks! I was looking into the tests but it's good to hear it wasn't my change.


feat: support fused silu mul

Motivation
as titled
I implemented a simplified version based on FasterTransformers, and I am considering whether to use optimizations like half2, and whether to consider using CUTLASS's LeftSiLUAndMul. Do you have any suggestions? Thanks. @yzh119
Modification

[x] fused silu mul
[ ] test
[ ] benchmark
[ ] error handling
[ ] coding style (PascalCase)

Using cutlass would be great if they already incorporate half2 operations.

Using cutlass would be great if they already incorporate half2 operations.

make sense

Ok. I’ll take a look. Thanks!

import torch
from torch.utils.benchmark import Timer
from itertools import product

from vllm import _custom_ops as ops
from flashinfer.activation import silu_and_mul as flashinfer_silu_and_mul
from flag_gems import silu_and_mul as flag_gems_silu_and_mul

def forward_vllm(x: torch.Tensor) -> torch.Tensor:
    d = x.shape[-1] // 2
    output_shape = x.shape[:-1] + (d,)
    out = torch.empty(output_shape, dtype=torch.float16, device=x.device)
    ops.silu_and_mul(out, x)
    return out

def forward_flashinfer(x: torch.Tensor) -> torch.Tensor:
    d = x.shape[-1] // 2
    out = torch.empty((*x.shape[:-1], d), dtype=torch.float16, device=x.device)
    flashinfer_silu_and_mul(out, x)
    return out

def forward_flag_gems(x: torch.Tensor) -> torch.Tensor:
    d = x.shape[-1] // 2
    return flag_gems_silu_and_mul(x[..., :d], x[..., d:])

def test_consistency():
    x = torch.randn(2, 4, 2*d, dtype=torch.float16, device=device)
    out_vllm = forward_vllm(x)
    out_flashinfer = forward_flashinfer(x)
    out_flag_gems = forward_flag_gems(x)
    assert torch.allclose(out_vllm, out_flashinfer, atol=1e-3, rtol=1e-3)
    assert torch.allclose(out_vllm, out_flag_gems, atol=1e-3, rtol=1e-3)
    assert torch.allclose(out_flashinfer, out_flag_gems, atol=1e-3, rtol=1e-3)
    print("Consistency test passed!")

device = torch.device("cuda")
d = 4096

test_consistency()

results = []
sizes = [2, 8, 32, 128, 512]

for batch_size, seq_length in product(sizes, sizes):
    label = "SiLU and Mul"
    sub_label = f"[{batch_size}, {seq_length}]"

    input_tensor = torch.randn(batch_size, seq_length, 2*d, dtype=torch.float16, device=device)

    min_run_time = max(0.1, min(1, batch_size * seq_length / 1e6))

    for num_threads in [1, 4, 16, 32]:
        results.append(
            Timer(
                stmt="forward_vllm(input_tensor)",
                setup="from __main__ import forward_vllm",
                globals={"input_tensor": input_tensor},
                num_threads=num_threads,
                label=label,
                sub_label=sub_label,
                description="vLLM",
            ).blocked_autorange(min_run_time=min_run_time)
        )

        results.append(
            Timer(
                stmt="forward_flashinfer(input_tensor)",
                setup="from __main__ import forward_flashinfer",
                globals={"input_tensor": input_tensor},
                num_threads=num_threads,
                label=label,
                sub_label=sub_label,
                description="FlashInfer",
            ).blocked_autorange(min_run_time=min_run_time)
        )

        results.append(
            Timer(
                stmt="forward_flag_gems(input_tensor)",
                setup="from __main__ import forward_flag_gems",
                globals={"input_tensor": input_tensor},
                num_threads=num_threads,
                label=label,
                sub_label=sub_label,
                description="Flag_gems",
            ).blocked_autorange(min_run_time=min_run_time)
        )

compare = torch.utils.benchmark.Compare(results)
compare.print()

Consistency test passed!
[-------------------- SiLU and Mul --------------------]
                  |   vLLM   |  FlashInfer  |  Flag_gems
1 threads: ---------------------------------------------
      [2, 2]      |    11.8  |       7.8    |     123.5
      [2, 8]      |    11.7  |       7.9    |     121.3
      [2, 32]     |    12.4  |       7.9    |     123.7
      [2, 128]    |    12.1  |       7.8    |     123.5
      [2, 512]    |    17.6  |      15.6    |     122.1
      [8, 2]      |    12.0  |       7.9    |     121.1
      [8, 8]      |    12.0  |       8.0    |     109.4
      [8, 32]     |    12.3  |       8.0    |     124.1
      [8, 128]    |    17.6  |      15.5    |     117.6
      [8, 512]    |    90.2  |      85.7    |     122.7
      [32, 2]     |    11.9  |       7.9    |     123.6
      [32, 8]     |    12.8  |       8.3    |     121.3
      [32, 32]    |    17.6  |      15.5    |     123.2
      [32, 128]   |    90.3  |      85.7    |     120.7
      [32, 512]   |   347.5  |     329.6    |     264.4
      [128, 2]    |    12.2  |       8.0    |     121.9
      [128, 8]    |    17.7  |      15.5    |     125.1
      [128, 32]   |    90.3  |      85.7    |     121.2
      [128, 128]  |   347.3  |     330.0    |     264.4
      [128, 512]  |  1375.4  |    1305.8    |     967.7
      [512, 2]    |    17.8  |      15.8    |     123.4
      [512, 8]    |    90.2  |      85.7    |     122.3
      [512, 32]   |   347.6  |     329.3    |     264.6
      [512, 128]  |  1375.7  |    1305.9    |     967.4
      [512, 512]  |  5491.3  |    5204.4    |    3855.6
4 threads: ---------------------------------------------
      [2, 2]      |    12.4  |       8.1    |     122.2
      [2, 8]      |    11.9  |       7.9    |     125.1
      [2, 32]     |    11.8  |       7.9    |     115.1
      [2, 128]    |    11.1  |       8.0    |     123.4
      [2, 512]    |    17.6  |      15.6    |     124.8
      [8, 2]      |    11.8  |       7.8    |     122.2
      [8, 8]      |    12.2  |       8.0    |     122.5
      [8, 32]     |    12.9  |       7.9    |     122.0
      [8, 128]    |    17.6  |      15.6    |     120.8
      [8, 512]    |    90.3  |      85.7    |     122.6
      [32, 2]     |    11.9  |       7.9    |     122.7
      [32, 8]     |    12.9  |       8.1    |     123.2
      [32, 32]    |    17.6  |      15.5    |     124.2
      [32, 128]   |    90.3  |      85.8    |     123.5
      [32, 512]   |   347.7  |     330.0    |     264.3
      [128, 2]    |    12.1  |       7.9    |     123.0
      [128, 8]    |    17.6  |      15.6    |     125.4
      [128, 32]   |    90.2  |      85.7    |     122.8
      [128, 128]  |   347.5  |     329.3    |     264.3
      [128, 512]  |  1376.8  |    1309.1    |     968.9
      [512, 2]    |    17.8  |      15.8    |     123.9
      [512, 8]    |    90.3  |      85.7    |     124.0
      [512, 32]   |   347.4  |     329.6    |     264.6
      [512, 128]  |  1376.7  |    1304.5    |     967.6
      [512, 512]  |  5490.0  |    5211.0    |    3853.5
16 threads: --------------------------------------------
      [2, 2]      |    11.9  |       7.8    |     122.6
      [2, 8]      |    12.2  |       8.0    |     123.2
      [2, 32]     |    12.1  |       8.1    |     121.7
      [2, 128]    |    12.0  |       8.0    |     122.0
      [2, 512]    |    17.6  |      15.5    |     123.9
      [8, 2]      |    11.9  |       7.9    |     121.9
      [8, 8]      |    12.0  |       8.2    |     122.2
      [8, 32]     |    12.5  |       8.0    |     120.7
      [8, 128]    |    17.6  |      15.5    |     122.8
      [8, 512]    |    90.3  |      85.8    |     121.8
      [32, 2]     |    12.3  |       8.0    |     121.8
      [32, 8]     |    12.4  |       8.1    |     122.9
      [32, 32]    |    17.6  |      15.6    |     124.9
      [32, 128]   |    90.2  |      85.8    |     121.7
      [32, 512]   |   347.5  |     329.7    |     264.1
      [128, 2]    |    12.0  |       8.0    |     124.7
      [128, 8]    |    17.6  |      15.5    |     123.3
      [128, 32]   |    90.2  |      85.7    |     122.5
      [128, 128]  |   347.6  |     329.4    |     264.9
      [128, 512]  |  1375.7  |    1306.5    |     967.8
      [512, 2]    |    17.8  |      15.8    |     122.6
      [512, 8]    |    90.3  |      85.7    |     122.1
      [512, 32]   |   347.5  |     329.7    |     264.8
      [512, 128]  |  1376.2  |    1303.8    |     968.1
      [512, 512]  |  5491.3  |    5205.8    |    3860.3
32 threads: --------------------------------------------
      [2, 2]      |    11.6  |       7.9    |     123.9
      [2, 8]      |    12.1  |       7.9    |     124.2
      [2, 32]     |    12.1  |       8.0    |     122.2
      [2, 128]    |    12.2  |       8.0    |     123.5
      [2, 512]    |    17.6  |      15.5    |     125.5
      [8, 2]      |    12.0  |       8.1    |     120.9
      [8, 8]      |    11.9  |       8.0    |     122.2
      [8, 32]     |    12.5  |       8.0    |     123.0
      [8, 128]    |    17.6  |      15.5    |     124.5
      [8, 512]    |    90.2  |      85.7    |     122.9
      [32, 2]     |    11.9  |       8.2    |     122.5
      [32, 8]     |    12.2  |       8.1    |     124.3
      [32, 32]    |    17.6  |      15.5    |     124.4
      [32, 128]   |    90.2  |      85.7    |     122.8
      [32, 512]   |   347.5  |     329.5    |     264.3
      [128, 2]    |    12.2  |       7.9    |     122.8
      [128, 8]    |    17.6  |      15.5    |     124.3
      [128, 32]   |    90.3  |      85.6    |     123.9
      [128, 128]  |   347.4  |     329.4    |     264.1
      [128, 512]  |  1378.5  |    1304.8    |     967.9
      [512, 2]    |    17.9  |      15.8    |     123.8
      [512, 8]    |    90.2  |      85.8    |     122.6
      [512, 32]   |   347.5  |     329.4    |     264.6
      [512, 128]  |  1376.7  |    1304.8    |     968.6
      [512, 512]  |  5492.6  |    5208.3    |    3854.1

Times are in microseconds (us).


refactor(frontend): move network schemas

Motivation
As done for the other schemas, we move the network schemas to the specific folder. Furthermore we create some tests.
There is a commented test that will be un-commented when we will have zod for Onramper ids too.

@peterpeterparker yes... I forgot to add the files that had the imports modified in token.schema... 🤦♂


feat!: Webpack/Jest to Vite/Vitest migration

Summary
This is a conversion from using webpack/jest as bundler/test library to vite/vitest. This will ensure the react-uswds library can support the new ESM standard, while maintaining backwards compatibility with CJS. All npm scripts have been updated accordingly to perform the same intended actions. Building is two steps: build the library and build the uswds assets (css, related files, etc.) dictated by the --mode uswds argument (running just build will do these steps for you).
Vite

Output bundles for all formats Vite supports (umd, cjs, iife, es)
Output source maps for all bundles
package.json updated with (hopefully) best practices so that the correct bundle will always be selected by users of this library
Parity with all other outputs (styles and assets)

Vitest

Maintains parity with jest configuration (coverage, etc.)

Also included:

new eslinting for storybook and vitest with updates to fix warnings/errors they detected
husky added to project, with the precommit script set to run checks on: lint, format, test related (no more forgetting to run that darn format:fix!)
all dependencies up-to-date as of 2/4/24

Notes:

happo unfortunately still requires webpack and babel (if you ever move off of happo, these dependencies can likely be dropped)
the happo and happo-ci scripts were updated to properly point to the renamed .happo.cjs file
A new bundles.test.tsx file was added that is excluded during normal testing and is ran after building to do basic importing and rendering tests on each bundle format

Related Issues or PRs
#192
How To Test

Using whichever means available from your local project's package manager of choice: have it use this vite build for the react-uswds dependency
Verify your project continues to work as expected

As mentioned, this is merely a proof-of-concept to show one direction that the project can go to not use webpack. It is intended foremost to be educational and provide insight. There are no expectations that this goes beyond draft, but if it is desired then necessary cleanup will happen (ex: vite config for various builds).
Vite uses a mix of esbuild and rollup under the hood. The lib mode has it's fair share of warts to work around like any bundler but I think I have it tamed. I have it creating bundles for every format it supports, because why not XD . Vite/Vitest are ES-first, thus the move from Jest (ES support on Jest is still experimental). With jest migrated to vitest the configuration needed to run vite, vitest, and storybook is now capable of being handled under one roof. There are some important differences in how jest/vitest work (especially mocks) that need to be considered. With webpack/jest usage removed, I was able to drop all of their directly-related dependencies along with babel ones. The version of JSDom being used apparently requires node 18+ so there were project changes in that regard (drop node 16 related stuff). USWDS since 3.0 has not supported IE so the IE11 line in the browser support list was dropped and focus-trap-react updated to current major version. The JSDom workaround for focus-trap-react uses a mock for the react library that enforces the necessary setting to always be disabled instead of the recommended mock for its dependency as I currently could not get vitest to handle loading it directly for mocking (aka, it currently is not dev-friendly to tell Vitest to handle loading dependencies-of-dependencies. direct dependencies that you import in your code mocks fine). There are warnings that appear now during linting, mostly from the new storybook plugin. Getting the eslint config right to handle cli-side and lib-side stuff properly is where i'm the weakest.

Tagging current maintainer on rotation: @werdnanoslen

Additional work to do a dependency-roundup of sorts to get all dependencies updated (including the React 18 upgrade) without errors can be done if moving this beyond draft is desired (as this PR would be a good time to do it due to its slight disruptiveness).

@jpandersen87 we'd like to test this out on some internal projects soon — if this is ready, can you resolve the conflict please?

@werdnanoslen Branch updated

@jpandersen87 thanks so much for bearing with us while we found opportunities on projects to test this out! We'd be happy to approve and merge this as soon as those remaining conflicts are resolved. 🚀

I take that as meaning tests have gone well? Branch has been updated.

Just disabled the Node16 tests branch protection rule, since this PR removes tests for that legacy node version as well (rightly so). Once the pipeline re-runs, I expect it to be all green this time! 🤞🏻

In v8, I'm getting an error when I try to import index.css in my React project. v7 works fine.
ERROR in ./src/client/index.tsx 6:0-47
Module not found: Error: Package path ./lib/index.css is not exported from package C:\<path-to-project>\node_modules\@trussworks\react-uswds (see exports field in<EMAIL_ADDRESS>
and the import in index.tsx looks like:
import<EMAIL_ADDRESS>


error while running rc_drive.py

An exception has occurred, use %tb to see the full traceback.
SystemExit
C:\Users\Krishna\Anaconda3\lib\site-packages\IPython\core\interactiveshell.py:3304: UserWarning: To exit: use 'exit', 'quit', or Ctrl-D.
warn("To exit: use 'exit', 'quit', or Ctrl-D.", stacklevel=1)
I am getting this error while running rc_driver.py

It may be libraries issue do run environment.yml file to create environment. And then activate it before execution. Even though if problem exist compare the versions with repository versions.

@Devanshice020 Does it say what exception?

File "C:/Users/Krishna/Desktop/RPI/AutoRCCar-master/computer/rc_driver.py", line 160, in handle
sys.exit()
SystemExit
It shows this error while i run %tb in shell

@Devanshice020 Run the code in a terminal instead, sys.eixt() will exit python.

Thanks @hamuchiwa for your help and support I have solved this issue by importing every function from rc_driver_help.py manually.
And also by defining
d_sensor_thresh = 30
d_stop_light_thresh = 25
d_stop_sign = d_stop_light_thresh
d_light = d_stop_light_thresh
outside every function.

@hamuchiwa i have same issue. It says exception occurred and system exit. Please help

@apoorvyadav1111 @Devanshice020 #174


tapgarden: batch write boundaries and batch state when transitioning from planter to caretaker

Related to #820.
Tl;dr it's unclear what behavior we want around batch persistence to disk vs. the batch still being the pendingBatch if errors occur before or during finalization.
AFAIU, batch finalization means that no more seedlings can be added to the batch. The batch is still mutated before broadcast to add elements like the anchor tapscript sibling, funding TX, etc.
My understanding of the current behavior:
Pending Batch

A batch has state BatchStatePending until FinalizeBatch is called.
When new seedlings are added to a batch, we update the batch both in-memory and on disk:
https://github.com/lightninglabs/taproot-assets/blob/761ccca181599c40e56206869d57cff32346a983/tapgarden/planter.go#L944

Finalizing, before the Caretaker starts

If we fail to handle a finalize argument, like the manual fee rate or tapscript sibling, the pendingBatch is unchanged, and still in state BatchStatePending.
The batch state is updated to BatchStateFrozen both in-memory and on disk before starting a caretaker:
https://github.com/lightninglabs/taproot-assets/blob/761ccca181599c40e56206869d57cff32346a983/tapgarden/planter.go#L762
A copy of the batch is used to start the caretaker.

Finalizing, while Caretaker is progressing to Broadcast

The caretaker batch is updated both in-memory and on disk for each state transition of the caretaker.
If the caretaker fails before broadcast, we delete the caretaker and clear the  pendingBatch held by the planter. The batch is already on disk as frozen, so the user can retry the batch by resubmitting all seedlings manually.
https://github.com/lightninglabs/taproot-assets/blob/761ccca181599c40e56206869d57cff32346a983/tapgarden/planter.go#L659

Finalizing, after Broadcast

The planter clears its pendingBatch, and the caretaker is solely responsible for handling the batch after TX confirmation.
https://github.com/lightninglabs/taproot-assets/blob/761ccca181599c40e56206869d57cff32346a983/tapgarden/planter.go#L680

So, any error before finalization should leave the planter's pendingBatch populated with the state as BatchStatePending. The batch state should be BatchStateFrozen before starting a caretaker. Any caretaker error before batch broadcast should leave the planter's pendingBatch empty, with the previous batch on disk as BatchStateFrozen, or some later batch state before BatchStateBroadcast.
This relates to #820 as it means that failures from the new FundBatch and SealBatch calls should not clear the pending batch, nor modify its batch state. This also means that the batch should be funded and sealed before being frozen and starting a caretaker.
If we agree on that behavior, then we'll need to update the planter tests to match. This involves changing some assumptions about the batch state when funding or fee estimation failures occur, as right now those come from the caretaker after finalization. As part of #820, those would occur before finalization.

From offline discussion with Oli:
The behavior after finalizing and before broadcast should be to only clear the planter pending batch if broadcast succeeds. So caretaker error should not trigger clearing of the pending batch. This makes it easier to retry batch finalization in various error cases, without having to manually resubmit all batch elements. We'll need to test that resubmission, as the batch could be on disk with a state between Frozen and Broadcast (but the failed caretaker will be deleted).

Ticker is removed in #827, write boundaries can be fixed in a follow-up PR.


Several .js files not located when deploying image_space locally

When I deploy locally (build instructions are pretty much bang on, took me around 30 minutes), unfortunately when I open the main image_space app on http://localhost:8080 I get a blank screen, I also get the following screen shot.

Only one of the three JS files is referenced within Gruntfile.js as below
 64         files[staticDir + '/main.min.js'] = [
 65             jsDir + '/main.js'
 66         ];

AFAICS the others are not listed in any other code within image_space.
This is an issue as they are referenced for import and are missing.

@lewismc i'm not able to reproduce this, but one of the keys is that your imagespace.min didn't work. My thoughts are that the python you are using is messing up on the hack-around for Grunt that we did with imagespace to convert JS and Python dicts to one another. You may need to hack the Gruntfile.js (look up the python part, and then make sure that it's actually running against a 2.7 or later python which that python snippet depends on). Then re-run grunt from the girder main area and see if you get imagespace.min.* cc @jeffbaumes

Talked with @lewismc just now. This particular issue was resolved by re-running grunt. @lewismc will look into updating the README to make this more clear.

cool thanks @jeffbaumes was it the Python issue I described? I ran into that, the params.py hack in Gruntfile.js only works on Python 2.7+ or newer, so on systems where that isn't the case, there is a problem


chore(rust): update prost to v0.12

This counts as an API-breaking change for the Rust code, right?
What's the policy about crate versioning vs. ICS versioning? If we have a change to the Rust crate that's API-breaking but not different at the protocol level, how is that handled?


Provider side picks up the default profile yaml

Provider side picks up the default profile yaml
Provider side picks up the default profile yaml and tries to run it in consumer side
Sample
default profile and test profile on provider side

On the consumer side

Instead of picking the VM it picks the tcp (Provider side application yaml)

Please adivce @marcingrzejszczak  @OlgaMaciaszek

I don't think this is a problem with Spring Cloud Contract per se because we do not do anything with profiles. Maybe it's a problem with Spring Boot test support? What if instead of using the test profile you would pass the properties using manually through SpringBootTest ?

Please provide the properties manually  @SpringBootTest(properties=...)

Hi @marcingrzejszczak
No Luck either

I don't understand why, I guess you will need to file an issue in Spring Boot. Spring Cloud Contract does not modify the default Spring Boot test configuration mechanism. I'm closing this issue but feel free to open one in Spring Boot with a reproducer and a link to this issue.


Long load time for many children.

If I make a simple implementation like so:
const CustomComponent = (props) => (
  <View style={{ alignItems: 'center', justifyContent: 'center', flex: 1 }}>
    <Text>{props.item}</Text>
  </View>
)

const data = [...new Array(2000)].map((x, i) => `Item ${i}`)

export class Simple extends React.Component<PropsT> {
  render() {
    return (
      <Swiper>
        {data.map(x => (
          <CustomComponent item={x} />
        ))}
      </Swiper>
    )
  }
}

As soon as I try to render Simple the app chokes, presumably while trying to instantiate 2000 instances of CustomComponent.
Am I using the library incorrectly? This seems like a crucial performance issue.

I got a bit of a performance improvement when using showsPagination: false. Still a bit slow though

Maybe loadMinimal?

I have same this issue. I have 7 page, each page have one list data. I must to pay more 7 seconds for render UI, which is so long.


[Fastlane.swift] Fix swift function nesting

Checklist

[ ] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context

Following the work started in #15721, it was not possible to call another fastlane function from a callback, making it to hang forever and giving a poor experience compared to the Ruby version.
Description

I went for a full refactor of the Swift code, with different queues for reading, writing through the socket and a new non-blocking polling system that allows a command to wait for its children to be executed in order to start with the next step.
Testing Steps

It is pretty easy, install my fastlane version, generate the new Swift's interface and I use this snippet to test it out:
class Fastfile: LaneFile {
    func customLane() {
	desc("Description of what the lane does")
        sh(command: "ls -2") { _ in
            sh(command: "ls -3") { _ in
                sh(command: "ls -4") {
                    println(message: $0)
                }
            }
        }
        sh(command: "ls -ls")
        sh(command: "ls -la")
    }
}

Hapy coding and happy Swift 🚀

Gonna address those changes @jhandguy. Meanwhile could you accept the cla saying @googlebot I consent. So I can take your useful changes?

@googlebot I consent.

LGTM @minuscorp 👍
Would you mind waiting a bit until I test your change and make sure no regression issues are involved?

OFC!

@minuscorp awesome! I was more thinking about testing it with a real-world application, including testing with scan, taking screenshots with snapshot and uploading builds on Testflight with pilot and updating AppStore Connect with deliver.
Then we should have pretty decent coverage, I'll keep you posted soon 👍

@minuscorp Did you receive this at all? I got a EXC_BAD_INSTRUCTION when self.socketClient gets deallocated 😱

Never happened to me before during tests, which fastfile are you using?

@googlebot I consent.

This will need another weekend haha

@minuscorp can you delete the old PR? https://github.com/fastlane/fastlane/pull/15721
Seems like I can't do it myself. 🤔


Range subprocess failed(exit code : 2)

hi ~  i have a issue, could you help me ?
i run the commond in the README.md
'''''bash
python launch.py
--cfg configs/video/2d_best/01_R101_best_hungarian-4GPU.yaml
--mode test
TEST.WEIGHTS pretrained models/configs/video/2d_best/01_R101_best_hungarian-4GPU.yaml/model_final.pkl
'''''''
but it has the log......,  i am using linux ubuntu16.04, and have 4 GPU (TITAN XP 11G)
********* it is log **********
tools/test_net.py: 10: tools/test_net.py: Test a Fafst R-CNN network on an image database: not found
from: cannt read /var/mail/future
from: cannt read /var/mail/caffe2.python
tool/test_net.py:21: tools/test_net.py:syntax error;"(" unexpected
Traceback(most recennt call last);
File "tools/test_net.py", line 143, in
main(ind_rang=args.range, multi_gpu_testing=args.multi_gpu_testing)
File "tools/test_net.py", line 104, in main
engine.test_net_on_dataset(multi_gpu=multi_gpu_testing)
File "data/DetectAndTrack/lib/core/test_engine.py", line 319, in test_net_on_dataset
num_images, output_dir)
File "data/DetectAndTrack/lib/core/test_engine.py", line 284, in multi_gpu_test_net_on_dataset
'detection' , num_images, binary, output_dir
File "data/DetectAndTrack/lib/utils/subprocess.py", line 67, in process_in_parallel
log_subprocess_output(i, p, output_dir, tag, start, end)
File "data/DetectAndTrack/lib/utils/subprocess.py", line 97, in log_subprocess_output
assert ret == 0, 'Range subprocess failed (exit code: {})'.format(ret)
AssertionError:Range subprocess failed(exit code : 2)

and i have run track commonds , they are OK, only test have the issue

use command like below,all is right.
python launch.py
--cfg configs/video/2d_best/01_R101_best_hungarian-4GPU.yaml
--mode track
......

@mathpopo  can you fixed it?

@ezreal1129 sorry,not deal with it,if you have any idea,plz tell me,thanks!


Mouse delay and UI enhance request

But the interface is a little wonky inside of my Jupyter notebook. All the buttons on the side look kinda faint, and the GUI looks small with everything at a small font size. Also there is a mouse delay. I'm sure a lot of these problems could be solved on my end, but the package seems to work a lot better in the Google or Kaggle notebooks.

From Reddit user's comment

fixed


Python script to run this?

Anyone have a python script I can use to detect the whole body pose of objects?
Not sure what I should do to just get a pose of an image 😕  Should I do pip install this file and then get the annotator? but I'd have to download the weights? or if I download the hf_hub files, there are so many and I don't know what any of them mean lol
Would be greatly appreciated!

This topdown file works with .pth model. This pose file works with .onnx model. Both of them are fine to get an image.


Javascript should support defineProperty assignments to exports

// @noEmit: true
// @allowJs: true
// @checkJs: true
// @Filename: defaults.js
exports.Umask = Umask
function Umask() {}
Object.defineProperty(exports, 'defaults', {
    get: function() {
        return 1
    }
})

// @Filename: use.js
var def = require('./defaults').defaults
var one = def

Expected behavior:
defaults is bound
Actual behavior:
defaults is not bound

Looks like the same issue as https://github.com/Microsoft/TypeScript/issues/6651. In the past we have chose not to support such patterns, in general.

@mhegazy In the fruture, can you support this?

@hpmax00 We decide which patterns to support by the amount of usage we observe in popular code bases, plus upvotes on this issue. Right now I haven't seen many of either, but that might change in the future.


"Reject mouse drags by default in scrollable", breaks apps past behavior

Reject mouse drags by default in scrollable, breaks apps past behavior
This new default behavior that just landed in master channel "reject mouse drags by default in scrollable" via https://github.com/flutter/flutter/pull/81569 breaks past and expected Flutter de-facto default behavior.
Please keep this new change as an explicitly opt-in new feature
Don't make it one that breaks past prior default and already now expected and established default behavior. As a general principle, if not absolutely necessary don't change past behavior, new features should require opt-in.
I agree that the new behavior is more correct behavior for desktop apps. However, for the past +2 years this has not been the default behavior in Flutter desktop and web applications, thus creating a de-facto default expected behavior, that users have even gotten used to, and to some extent even like, so much that they now complain when it is gone.
New apps that do not want to have this Flutter "device" like behavior on desktop/web, should choose to opt-in to not use it and get the more real desktop/web like behavior, while apps already running should continue to behave as before unless they also opt-in to this new feature.
There probably is no past Flutter internal test for this that would break, but again the change does break de-facto established and in production used and expected Flutter app behavior.
Steps to Reproduce
When building with master channel 2.3.0-1.0.pre.226 or later, scrollable surfaces can no longer be drag scrolled with a mouse on desktop and web builds, nor can eg tab views be dragged with a mouse. This still works as before and expected in other channels dev 2.3.0-0.1.pre, beta 2.2.0-10.2.pre and stable 2.0.6.
cc: @mariamhas @jonahwilliams

Sidenote
We can currently only build apps on master channel due to issue https://github.com/flutter/flutter/issues/79195, that as far as we know so far only has a fix on master, so building on any other channel than master, in order to avoid this new breaking feature, is currently not an option.

Flutter doctor
```
> flutter doctor -v
[√] Flutter (Channel master, 2.3.0-1.0.pre.226, on Microsoft Windows [Version 10.0.19041.928], locale en-US)
• Flutter version 2.3.0-1.0.pre.226 at C:\Users\mryds\fvm\versions\master
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 51ca131e39 (10 hours ago), 2021-05-03 19:54:04 -0700
• Engine revision 378e4dbc41
• Dart version 2.14.0 (build 2.14.0-48.0.dev)
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
• Android SDK at C:\Users\mryds\AppData\Local\Android\sdk
• Platform android-30, build-tools 30.0.3
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
• All Android licenses accepted.
[√] Chrome - develop for the web
• Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe
[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.9.3)
• Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
• Visual Studio Community 2019 version 16.9.31129.286
• Windows 10 SDK version 10.0.19041.0
[√] Android Studio (version 4.1.0)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
[√] IntelliJ IDEA Community Edition (version 2021.1)
• IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2018.3.1
• Flutter plugin version 56.0.5
• Dart plugin version 211.7233
[√] VS Code (version 1.55.0)
• VS Code at C:\Users\mryds\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 3.21.0
[√] Connected device (5 available)
• Nexus 7 (mobile)  • 0a99f5e8    • android-arm    • Android 6.0.1 (API 23)
• SM T510 (mobile)  • R52N906MLAV • android-arm    • Android 10 (API 29)
• Windows (desktop) • windows     • windows-x64    • Microsoft Windows [Version 10.0.19041.928]
• Chrome (web)      • chrome      • web-javascript • Google Chrome 90.0.4430.93
• Edge (web)        • edge        • web-javascript • Microsoft Edge 90.0.818.51
• No issues found!

</details>

However, for the past +2 years this has not been the default behavior in Flutter desktop and web applications, thus creating a de-facto default expected behavior, that users have even gotten used to

Users should not have gotten used to anything in desktop Flutter applications over the last two years:

We don’t recommend releasing a desktop application until desktop support is stable

It would make no sense for scroll behavior on desktop to be wrong by default forever because some people ignored the guidance that desktop applications built with the pre-release versions of Flutter shouldn't be released to end users.

@stuartmorgan that is certainly a viewpoint too. You would then prefer that we, and others that use Flutter desktop should not have used Flutter at all for the past 2 years? I think it is much better and more productive to use it despite it not being quite ready, so we can move forward, provide feedback while doing so, rather than wait until it is deemed 100% complete, which might be a while still. We thought so already 2 years ago, when we still had to install the embedders/runners manually.
All that is needed for this particular case, and probably many more that will follow, is to make the new behavior opt-in, so that past desktop and web apps do not break. The changed default behavior also affects web desktop apps. 💙 😃

Like Stuart says, the current behavior is wrong and needs to be corrected. There is simply no point in supporting desktop target platform for Flutter if we're not going to support desktop interactive standards. The old behavior was unnatural, uncanny, and made it impossible to select text in lists/scrollables! (Not to mention our general issues with selectable text, which also needs to be fixed)
If you want to opt back into the old behavior (which I strongly discourage because it will make using your app harder), you can configure the scroll behavior of your app to accept mouse drags: https://github.com/flutter/flutter/pull/81569/files#diff-0a9866e7801b58e1846f8b24d69faf9204d14f8262bf79d85e5eb3949105a19eR22

You would then prefer that we, and others that use Flutter desktop should not have used Flutter at all for the past 2 years? I think it is much better and more productive to use it despite it not being quite ready, so we can move forward, provide feedback while doing so

Using it, building things with it, and providing feedback, are not the same thing as shipping products to end users.

rather than wait until it is deemed 100% complete

Stable release and 100% complete are not the same thing.

All that is needed for this particular case, and probably many more that will follow, is to make the new behavior opt-in, so that past desktop and web apps do not break.

But you want that applied based on criteria that you have decided unilaterally, supported by a user-based argument that is based on you having ignored explicit guidance from the project.

The changed default behavior also affects web desktop apps. 💙 😃

You want the same change made in two configurations: desktop and web. I'm only addressing the desktop aspect; I'll leave it to others to comment on web.

We thought so already 2 years ago, when we still had to install the embedders/runners manually.

(Also, I would encourage you to consider how painful your app setup would be if every behavior-changing fix or improvement that has been made to desktop support since the initial FDE work required you to opt in. E.g., would you like every desktop app you create to have to turn on scroll wheel support? The earliest versions of FDE didn't support it. How about text input? Hasn't always worked. Unicode support in text input? Fixing that changed behavior.)

A concrete examples on how/where to use the new APIs to put things back to how they where before this breaking change was introduced would be helpful and constructive.
Still, when we put it back, it also means we are stuck on whatever channel the new API for it has reached. Well currently we are stuck on master anyway due to https://github.com/flutter/flutter/issues/79195, so it does not matter so much, expecting its roll down to other channels to take a while too, so we can work with that.
There seems to be other related issues from this new breaking behavior change too, eg:
https://twitter.com/gerryhigh/status/1389566359437287424


Customize style

Hello there! I have a question about customization. Everything else is pretty good right now but I prefer to make some changes about how it looks. I tried to make changes in typescript files into /src or into build version but without success...

Hi @jwzdmitry, thanks for using my component.
In the later versions of this, i would make the API more flexible to allow better customization. If you want to make changes, you need to fork the repo and build it using npm run build, don't forget to run npm install.
Let me know if you have any further questions.

@matharumanpreet00 thank you for your answer! Yes, I have question cos' my project is pretty big and I actually have no idea about how to integrate forked and changed repo into my project. Maybe you have easier way to make changes? this is a question about 6 rows of css styles...

@jwzdmitry you can take a look HERE for using your forked project as npm module.

@matharumanpreet00 i think must added disable sidemenu & change choosed date & range cikir :grimacing:

@redbellswalking I am not actively working on this, but could you tell me the specifics of the things you are looking to customize ? For those, I can add customization props. I also welcome PRs, the codebase is very simple.

Is there a way to ovveride styles on this @flippingbitss ?


Fix Series.fillna to avoid Spark jobs.

DataFrame.fillna reuses Series.fillna which always runs a Spark job to check if there are null values, then it ends up with running many jobs if the DataFrame has a lot of columns.
We should avoid it, and we can check its nullability defined by Spark instead.

LGTM if tests pass

Codecov Report

Merging #1550 into master will decrease coverage by 2.13%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##           master    #1550      +/-   ##
==========================================
- Coverage   94.20%   92.06%   -2.14%
==========================================
  Files          38       38
  Lines        8608     8610       +2
==========================================
- Hits         8109     7927     -182
- Misses        499      683     +184

Impacted Files
Coverage Δ

databricks/koalas/series.py
97.53% <66.66%> (-0.23%)
:arrow_down:

databricks/koalas/internal.py
96.71% <100.00%> (+0.02%)
:arrow_up:

databricks/koalas/spark/accessors.py
91.45% <100.00%> (+0.14%)
:arrow_up:

databricks/koalas/usage_logging/__init__.py
25.00% <0.00%> (-69.65%)
:arrow_down:

databricks/koalas/usage_logging/usage_logger.py
50.00% <0.00%> (-50.00%)
:arrow_down:

databricks/koalas/__init__.py
78.43% <0.00%> (-13.73%)
:arrow_down:

databricks/conftest.py
88.67% <0.00%> (-7.55%)
:arrow_down:

databricks/koalas/frame.py
92.55% <0.00%> (-3.13%)
:arrow_down:

databricks/koalas/namespace.py
84.49% <0.00%> (-1.61%)
:arrow_down:

databricks/koalas/generic.py
95.88% <0.00%> (-1.18%)
:arrow_down:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fb85de...a69a514. Read the comment docs.


Add support for paring hex literals

Note: White space changes are an affect of running gofmt (Can remove them and re-raise the request).

Looks great to me. Whitespace changes as a result of fmt are no problem. Thanks for the PR!


BatchSpanProcessor ExportResult other than SUCCESS causes UnhandledPromiseRejectionWarning: 1

With @opentelemtry/tracing v0.12.0 we are observing unhandled promise rejections caused by the BatchSpanExporter not exporting results successfully https://github.com/open-telemetry/opentelemetry-js/blob/master/packages/opentelemetry-tracing/src/export/BatchSpanProcessor.ts#L110
While we use Node 14, we already exit on unhandled promise rejections as done by default on Node 15 (https://github.com/nodejs/TSC/issues/916) so an unhandled rejection is causing our processes to exit. Additionally the issue is challenging to pin down as the rejection value is a plain number, so the generated stack traces aren't really valuable.
Example trace:
Error: 1
  File "/app/node_modules/raven/lib/client.js", line 409, col 15, in Raven.captureException
    err = new Error(err);
  File "/app/node_modules/REMOVED/built/lib/instrument-process.js", line 13, col 30, in sentryId
    sentryClient.captureException(error, {
  ?, in new Promise
  File "/app/node_modules/REMOVED/built/lib/instrument-process.js", line 12, col 36, in null.<anonymous>
    const sentryId = await new Promise((resolve, reject) => {
  File "/app/node_modules/REMOVED/built/lib/instrument-process.js", line 67, col 16, in process.<anonymous>
    return exitFatal(err, 'unhandledRejection');
  File "events.js", line 315, col 20, in process.emit
  File "domain.js", line 486, col 12, in process.EventEmitter.emit
  File "internal/process/promises.js", line 245, col 33, in processPromiseRejections
  File "internal/process/task_queues.js", line 94, col 32, in processTicksAndRejections

How would a fix here look like? Add .catch() to each invocation of this._flush() as done here https://github.com/open-telemetry/opentelemetry-js/blob/master/packages/opentelemetry-tracing/src/export/BatchSpanProcessor.ts#L121? Or just remove the reject https://github.com/open-telemetry/opentelemetry-js/blob/master/packages/opentelemetry-tracing/src/export/BatchSpanProcessor.ts#L110 and rely on the global error logger (which similar to https://github.com/open-telemetry/opentelemetry-js/issues/1569 I assume)?
We are using the jaeger exporter, which is already logging the error itself https://github.com/open-telemetry/opentelemetry-js/blob/master/packages/opentelemetry-exporter-jaeger/src/jaeger.ts#L139-L141

Do you plan to work on this @johanneswuerbach  ?

I would have some capacity, but I would need some guidance what the solution should be here. Just remove the rejection?

@johanneswuerbach The way to go should be to use the globalErrorHandler like the metric do: https://github.com/open-telemetry/opentelemetry-js/blob/master/packages/opentelemetry-metrics/src/export/Controller.ts#L57

Thanks @vmarchaud, PR created https://github.com/open-telemetry/opentelemetry-js/pull/1622


update environment permissions

Release Playbook

[ ] Rebase against master
[ ] Code review
[ ] Merge into master
[ ] Verify changes at http://site-staging.convox.com
[ ] Promote release on site-production in the convox/production Rack

 Update RBAC doc on Developer env access


Linted line numbers (squigly locations) are sometimes one too low

I sometimes see linted messages (the squigly locations) one line lower than they should be placed in the code. Is this something anyone else is experiencing, and is there anything we can do to resolve?

Screenshots added for documentation:

@aaronsteers could you please provide a full example of where you see the mismatch? Thanks!

@aaronsteers this should now be fixed in 0.0.4


Bonito plotting example does not include any plots

This might be intended, but since the other two examples (CairoMakie and WGLMakie) do produce plots, I assumed that the Bonito one would do too.

That's a good point. I left out the graph embedding to showcase rendering a Bonito.App object and keep the examples brief - but this is probably more confusing since most people would expect to see a graph.
I'll go back and embed a similar heatmap example into bonito app to make this use case clearer


Component Specifications

Finish component specifications and finalize the user_stores.md file in docs

Finished component specifications, user stories, and use cases.


The connection in the TUN mode works only once

After launching the program, when you click the "start" button, administrator rights are requested, and a virtual network adapter is created in the system. After that, the connection is established, and everything works fine.
When you press the "stop" button, the virtual network adapter is removed from the system, and when you press the "start" button again, it no longer appears. At the same time, the program reports that the connection has been established, but in fact it is not there.
To reconnect, you need to exit the program and run it again.
OS Windows 7 x64
InvisibleMan-XRay v2.3.2 x32

@InvisibleManVPN seems like the last build is broken. I have the same issue where it's not working at all.
Do you have a vpn client without all that gui eye candy mess?

it's ridiculous that you can't even copy version info.

Hey @Bushroott!
Did you check both x64 and x86 versions? In both versions, you have this issue?

@Bushroott If you can please download the previous version of Invisible Man TUN v0.3.3 and extract it in the InvisibleManXRay-x86\TUN path and check whether the program is working properly.

@Bushroott If you can please download the previous version of Invisible Man TUN v0.3.3 and extract it in the InvisibleManXRay-x86\TUN path and check whether the program is working properly.

Unfortunately, the behavior of the program doesn`t change with the old driver either.

Hey @Bushroott! Did you check both x64 and x86 versions? In both versions, you have this issue?

Both versions are affected.

up
it's a little annoying to restart the app every time in order to reconnect to my VPN. is there a bugfix planned in the near future?

Hey @TemityStolyarov,
I'm working on it and for this reason, I postponed the new release to find a solution for that. Can I ask you to provide me a video about what you do in this process? Currently, this issue happens for some users and some others have no issue with that.

confirm issue

Hello @Bushroott @pps83 @TemityStolyarov @i0FFLINE
I couldn't regenerate the problem. As I know, this bug happens to some users. Can you try regenerating the bug and sending me the result?
If you can, please download one of these zip files (based on the architecture of your OS):

InvisibleManTUN-x64.zip
InvisibleManTUN-x86.zip

In these files, I developed a logger system to log the process and record it into a log.txt file. So, we can track the things happens in this process.
After downloading, just go to the {the path of the app}/TUN and extract it there. Then, start the Invisible Man XRay and try to regenerate the problem. After that, just send me the log.txt file here.
P.S: It would be great if you could record a video of the process you do. It may help us to know more about the problem.

this (InvisibleManTUN-x64.zip) file crashes after launching in a few seconds (runned as admin)

19-Oct-24 3:02:56 PM: Stop tunneling process.

Hello @TemityStolyarov
You should copy this file in the {Invisible Man XRay path}/TUN path and then open the Invisible Man XRay.exe app and try to click on the RUN button in TUN mode. You shouldn't open the InvisibleMan-TUN.exe directly.

You shouldn't open the InvisibleMan-TUN.exe directly

yep, my bad here is the contents

19-Oct-24 3:15:52 PM: Start tunneling process.
19-Oct-24 3:15:52 PM: Trying to cleanup profiles.
19-Oct-24 3:15:52 PM: Cleanup profiles successfully done.
19-Oct-24 3:15:52 PM: Trying to run tunnel.
19-Oct-24 3:15:52 PM: Wait until interface created.
19-Oct-24 3:15:52 PM: Set interface address.
19-Oct-24 3:15:52 PM: Wait until interface address set.
19-Oct-24 3:15:53 PM: Set interface DNS.
19-Oct-24 3:15:53 PM: Set routes.
19-Oct-24 3:16:02 PM: Stop tunneling process.
19-Oct-24 3:16:09 PM: Start tunneling process.
19-Oct-24 3:16:09 PM: Wait until interface created.
19-Oct-24 3:16:16 PM: Scheduler failed. Reason: Device with the name 'InvisibleMan-XRay' was not found.
19-Oct-24 3:16:16 PM: Start tunneling process failed. Reason: Device with the name 'InvisibleMan-XRay' was not found.
19-Oct-24 3:16:32 PM: Stop tunneling process.
19-Oct-24 3:16:34 PM: Stop tunneling process.
19-Oct-24 3:16:34 PM: Stop tunneling process.

video link

@TemityStolyarov Many thanks for your answer. Seems for some users, TUN can't detect that the tunneling process is finished (for the second time and so on). Can I ask you to open the Command Prompt and type this:
TASKLIST /FI "PID eq 12345"

I'm using the above command to ensure the tunneling process is finished and maybe the problem is here. Type it in your cmd and send me the result.

I suspect the cause is the Hyper-V installed on the machine. It has its own fancy ethernet interface(s).
If You have Windows 11 Pro - try to install and setup the second Virtual Switch with external connection type.
May be help.

same result for me: before the first connection, during use and after first disconnect

I suspect the cause is the Hyper-V installed on the machine. It has its own fancy ethernet interface(s). If You have Windows 11 Pro - try to install and setup the second Virtual Switch with external connection type. May be help.

I had the issue with win10 and win11 and on both of them I have hyper-v enabled, and softether vpn installed as well.

it worked

22-Oct-24 10:55:43 AM: Start tunneling process.
22-Oct-24 10:55:43 AM: Trying to cleanup profiles.
22-Oct-24 10:55:43 AM: Cleanup profiles successfully done.
22-Oct-24 10:55:43 AM: Trying to run tunnel.
22-Oct-24 10:55:43 AM: Wait until interface created.
22-Oct-24 10:55:44 AM: Set interface address.
22-Oct-24 10:55:44 AM: Wait until interface address set.
22-Oct-24 10:55:44 AM: Set interface DNS.
22-Oct-24 10:55:45 AM: Set routes.
22-Oct-24 10:55:55 AM: Stop tunneling process.
22-Oct-24 10:55:57 AM: Start tunneling process.
22-Oct-24 10:55:57 AM: Trying to cleanup profiles.
22-Oct-24 10:55:57 AM: Cleanup profiles successfully done.
22-Oct-24 10:55:57 AM: Trying to run tunnel.
22-Oct-24 10:55:57 AM: Wait until interface created.
22-Oct-24 10:55:57 AM: Set interface address.
22-Oct-24 10:55:57 AM: Wait until interface address set.
22-Oct-24 10:55:58 AM: Set interface DNS.
22-Oct-24 10:55:58 AM: Set routes.
22-Oct-24 10:56:09 AM: Stop tunneling process.

@TemityStolyarov Thank you too for testing and giving me feedback to find the problem.
@Bushroott @pps83 @i0FFLINE Guys please confirm that the issue is fixed for you as well. In the next release, I will push this fix.

works fine

@InvisibleManVPN
but there's a nuance.
After connecting to the server, there is no traffic for a very long time. up to 1 minute no website responds or loads as at speeds of 10 kilobits/sec.

but there's a nuance.
After connecting to the server, there is no traffic for a very long time. up to 1 minute no website responds or loads as at speeds of 10 kilobits/sec.

@i0FFLINE Sounds strange. Anyway, I don't think this problem is related to this issue. Didn't have this problem previously? Can you test more?

but there's a nuance.
After connecting to the server, there is no traffic for a very long time. up to 1 minute no website responds or loads as at speeds of 10 kilobits/sec.

@i0FFLINE Sounds strange. Anyway, I don't think this problem is related to this issue. Didn't have this problem previously? Can you test more?

my fault, its my provider laggy (i think router's uplink rebooted)
all works fine

my friend reported a bug: he presses the 'Run' button and there is no connection. it just spins a little bit and immediately turns off. is this some other already known issue?

my friend reported a bug: he presses the 'Run' button and there is no connection. it just spins a little bit and immediately turns off. is this some other already known issue?

@TemityStolyarov In the TUN mode or Proxy mode? To better track, please submit a new issue.

This issue resolved by did a fix on Invisible Man TUN service (see this)
In the next release of Invisible Man XRay, I will update the TUN service and this problem will be solved.


feat(prettier): format () => ({} ? 1 : 2); to () => ({}) ? 1 : 2;

Merge activity

Nov 24, 4:07 AM: @Boshen merged this pull request with Graphite.


linux_zen: 5.15.6-zen2 -> 5.15.8-zen1

Motivation for this change
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

LGTM. Not sure if the sysdig bump shouldn't have gone into its own PR.

Yes. This was added by accident.

╭─[~]
╰─ % uname -a
Linux turingmachine 5.15.8-zen1 #1-NixOS ZEN SMP Tue Jan 1 00:00:00 UTC 1980 x86_64 GNU/Linux


Close the connection on the server when the client closes it first

When the client closes the connection, the server will read EOF. In that case the connection should be closed on the server as well. Without this change the server goroutine will go into an infinite loop when the client closes the connection. It'll try to read, get an EOF, then "continue", go back to read, get another EOF and so on. That takes 100% CPU in this situation.

Thanks!


fix: update a few text/message in build/integration PLR

In STONEINTG-493, we split PLR controller to build PLR controller and integration PLR controller, this PR is to update some text/message which are not updated in https://github.com/redhat-appstudio/integration-service/pull/257
Signed-off-by: Hongwei Liu<EMAIL_ADDRESS>Maintainers will complete the following section

[ ] Commit messages are descriptive enough (hints)
[ ] Code coverage from testing does not decrease and new code is covered
[ ] Controllers diagrams are updated when PR changes controllers code  (if applicable)

Can you expand your commit message and mention the same thing you wrote in the PR description? To make the commit message description enough.
In STONEINTG-493, we split PLR controller to build PLR controller and integration PLR controller,
this PR is to update some text/message which are not updated in #257

Updated. Thanks.


copy of matterdocs

hey, freshman year computer science student here.
I program a lot in my free time. recently, I decided I wanted to learn matter.js so I could make some cool physics demos and things like that. I usually use vscode.dev on my school computer (it's a chrombook, sucks, I know), which means that the school website restrictions apply. this also means that brm.io is classified as a blocked website because it has the .io name. i'm wondering whether someone would be willing to port the matter.js documentation to a different website or file for me and others in my position?

Does archive.org circumvent the block?


Micawindow background breaks on Windows 10 when another window is opened

Hello,
A problem I have when I test my application with several WPF windows as MicaWindow on Windows 10:
The first (start-up) one show well, with correct theme and Light/Dark mode.
However, when I create and show another window, I don't have the background working. According if I tweak or not the WindowChrome.GlassFrameThickness, I get either a full-white or full-black background, no matter which Windows Mode I'm using.
Thank you for your answer.
UPDATE: Opening another window break the background on all windows.

Hello,
Thank you for posting this Issue, Do you have a code snippet I can use to create the other window so it can help me isolate the issue?
P.S I will create a Windows 10 VM and try.

Hello, I fixed this issue already. I forgot that I created this issue. I was using Modern WPF and it didn't change their color so I had to use ModernWPF window to fix it. But I'm not sure if it is a MicaWPF issue.

My friend had the same problem on Windows 10.

I Would like if any of you could try now if it breaks I did a couple of changes
Be sure to use (1.3.9)

This issue seems to have been fixed in version 2.0.0


1.16

https://github.com/4KSDXD/SBM-WoodenShears/tree/main
That is the link for the source code. I decided to use a fresh new Forge MDK. This isn't the most ideal way to do a pull request, but I wanted to keep things a bit cleaner :)
If you don't want to build the mod from the source code, I have a pre-built one from here: https://github.com/4KSDXD/SBM-WoodenShears/releases/tag/1.0.0
Curseforge username: gentworm
Discord username: GentWorm#8094
This is the port to 1.16.5

Invalid pull request, proper pull request you need to fork the branch. Then make changes to the branch before starting a pull request.


Status polling and broadcast methods for Socket

Resolves #20
Adds methods to poll for the socket status and to subscribe to broadcasts of the status changes.  The broadcast also includes tungstenite::Error when the reconnect fails, so subscribers can see if their authorization is no longer valid.

I don't want to expose State.  It is an implementation detail and has fields I don't think should be exposed.

I don't want to expose State. It is an implementation detail and has fields I don't think should be exposed.

Fair enough. The EnumDiscriminants macro can be used to generate Status from State and with the conversions


Archived Products only appear as such from that day onwards

Feature Request
As a People Allocator
I would like to go back to previous dates in the past and see a snapshot of all the active products at that time, even the archived ones
so that I can develop an accurate view of the Space at that time
Acceptance Criteria
If a product is active on 7/7
And I archive it on 7/15
And I go back to the space on date 7/7
Then that product should not be listed as archived on the space for that date
Notes
Please talk to Jenny/Sara for quick explanation before beginning this story.

Team discussed and removing the Archive checkbox should solve the problem outlined in this story.

Story complete, but 'archive' as a field in the Product object remains in the code. Keeping it and all the associated logic in there until we settle on how we want to use it in the future.


'Unable to update stock info' warning

After creating item.

We need to manage Stock Entry page first then we will calculate total Stock quantity to show in this Total Stock Inventory field


pylint results in errors using extension-pkg-whitelist on packages with deprecated members

Versions

Sublime: 3.2.2
Sublime build: 3211
SublimeLinter: 4.14.0
SublimeLinter-pylint: 1.5.2
pylint==1.9.5
astroid==1.6.6
Python interpreter running pylint: CPython 2.7.16

Problem Description
Specifically, I am running pylint on a file that imports wxPython4. With no configuration file, pylint fails to resolve imports and reports errors on all wx imports, so I created a config file (reran to check consistency, same results up to this points) and added extension-pkg-whitelist=wx to the config.
Under this configuration file, the script now seems to generate wxPyDeprecationWarning's (a wx warning type derived from DeprecationWarning) when run, which causes the pylint linter to fail in Sublime, reporting errors in the linter. However, if I run pylint in the same file from the command line, the warnings still get generated but the program completes successfully and generates the lints I'm looking for.
Workaround
My current workaround is to edit the source for astroid directly to hide any DeprecationWarning's when accessing module members. Specifically, in astroid.raw_building, I made these changes:
17a18
> import warnings
282,283c283,286
<                 member = getattr(obj, name)
<             except AttributeError:
---
>                 with warnings.catch_warnings():
>                     warnings.filterwarnings('error')
>                     member = getattr(obj, name)
>             except (AttributeError, DeprecationWarning):

Moving Forward
As I am not a contributor to this codebase, I leave any decisions on how to address this to the maintainers.

Hi 👋!
I guess pylint puts these warnings on stderr, normal results come in on stdout.  We handle stderr and already filter some common output. Please take a look a linter.py "on_stderr".  In particular, we just need a good enough regex and some example output to fix this.
Maybe you could help here 🙏

I'm down to help, for sure :) here's the warning output for my error (should've put this in the prompt to start with, sorry):
C:\PATH_TO_PROJECT\venv-py2\lib\site-packages\astroid\raw_building.py:284: wxPyDeprecationWarning: Accessing deprecated property. Use altDown instead.
  member = getattr(obj, name)
C:\PATH_TO_PROJECT\venv-py2\lib\site-packages\astroid\raw_building.py:284 wxPyDeprecationWarning: Accessing deprecated property. Use controlDown instead.
  member = getattr(obj, name)
C:\PATH_TO_PROJECT\venv-py2\lib\site-packages\astroid\raw_building.py:284: wxPyDeprecationWarning: Accessing deprecated property. Use metaDown instead.
  member = getattr(obj, name)
C:\PATH_TO_PROJECT\venv-py2\lib\site-packages\astroid\raw_building.py:284: wxPyDeprecationWarning: Accessing deprecated property. Use shiftDown instead.
  member = getattr(obj, name)

(tbh the fact that it pulls errors through the terminal output and not directly from the interpreter, or even through error codes (which it turns out are determined by the infractions pylint catches, and not it's run status), is kind of a shame. It makes the fixes feel like hacks...)
Regarding a regex, here are my thoughts:

if you want to catch all warnings, the only commonality among warning messages is that they contain the word "Warning" from when the warning class' name is printed. It's not a strict guarantee but will probably do the job.
if you want to catch only deprecation warnings, same thing as above w/ "DeprecationWarning".
if you want to catch deprecation warnings for explicitly this situation, you could also include the parts of the output re: the astroid package:

the file path "\astroid\"
not sure if "site-packages" always precedes that? but that could go in too
"raw_building.py" works for this version, and maybe every current astroid version available, but is still subject to change unexpectedly. So I don't recommend including this,
line number ":284", same as above but even more so
the following code line "member = getattr(obj, name)"; same issue as above

What do you think?
In the meantime, I think I'll submit this as a bug to the astroid dev's; it may not be desirable to have the code pushing warnings when walking a project's members, and if they fix it then this issues kind of disappears. I'll log any progress in this thread.

I'm surprised by this output, probably I don't follow.  You have this output from the Terminal, right?  What actually happens in SublimeLinter? Maybe I should have asked more.

Under this configuration file, the script now seems to generate ... [warnings] ... when run, which causes the pylint linter to fail in Sublime, reporting errors in the linter.

What does "reporting errors in the linter" mean?  What does "causes pylint to fail" mean. Do you get an error popup? Or the status bar indicating "(erred)".
SublimeLinter actually does not (iirc) look at the exit code.  (But it doesn't like text on stderr because pylint usually outputs on stdout.)
I'm also a bit confused about "extension-pkg-whitelist".  Is this also necessary for usage on the command line, or is this a specific hack for SublimeLinter?  (pylint can see other libs, it is just "wx" that causes the problem?)

You have this output from the Terminal, right?

The terminal output from running pylint directly is this (abbreviated for simplicity):
(venv-py2) $ python -m pylint PATH_TO_FILE\FILE.py
Using config file C:\PATH_TO_PROJECT\.pylintrc
************* Module PATH_TO_FILE\FILE
C: 49, 0: Exactly one space required around assignment
                cancelled=False
                         ^ (bad-whitespace)
C: 51, 0: Exactly one space required around assignment
            cancelled=True
                     ^ (bad-whitespace)
C:\PATH_TO_PROJECT\venv-py2\lib\site-packages\astroid\raw_building.py:285: wxPyDeprecationWarning: Accessing deprecated property. Use altDown instead.
  member = getattr(obj, name)
C:\PATH_TO_PROJECT\venv-py2\lib\site-packages\astroid\raw_building.py:285: wxPyDeprecationWarning: Accessing deprecated property. Use controlDown instead.
  member = getattr(obj, name)
C:\PATH_TO_PROJECT\venv-py2\lib\site-packages\astroid\raw_building.py:285: wxPyDeprecationWarning: Accessing deprecated property. Use metaDown instead.
  member = getattr(obj, name)
C:\PATH_TO_PROJECT\venv-py2\lib\site-packages\astroid\raw_building.py:285: wxPyDeprecationWarning: Accessing deprecated property. Use shiftDown instead.
  member = getattr(obj, name)
C: 26, 0: Constant name "progress_style" doesn't conform to UPPER_CASE naming style (invalid-name)
...
[other lints listed here]
...
------------------------------------------------------------------
Your code has been rated at 3.41/10 (previous run: 3.41/10, +0.00)

What actually happens in SublimeLinter?

Here's a screencap of the output in Sublime:

What does "reporting errors in the linter" mean? What does "causes pylint to fail" mean. Do you get an error popup? Or the status bar indicating "(erred)".

pylint is a linter. It's job is to report "errors" as a part of its expected functionality. But if the pylint code itself raises an error when running, this is also an "error" that is not a part of its expected functionality, and will "cause pylint to fail", meaning the process will terminate without completing execution. I'm trying to find some terminology to use that distinguishes from these two very different "errors" with the exact same name.

"extension-pkg-whitelist". Is this also necessary for usage on the command line, or is this a specific hack for SublimeLinter? (pylint can see other libs, it is just "wx" that causes the problem?)

extension-pkg-whitelist is required to resolve wx imports correctly.

Ok, sorry for my confusion. Looks exactly how I first understood the issue. Maybe I just don't like that pylint throws these depreciation warnings. I would prefer if it wouldn't. 🤪

How about we just add
stderr = re.sub('(?m)^.*DeprecationWarning.*\n.*\n', '', stderr)

after
https://github.com/SublimeLinter/SublimeLinter-pylint/blob/798bf4fd856fda8870a8a88b76ef330d404c6076/linter.py#L29

Hey! So they liked my ticket to fix this in astroid; it'll obviate the fix here for new versions of pylint. Do you think the fix you suggested would still be a good addition in order to support older pylint versions?

Regarding the fix itself, it's probably the best way to do the job?
The only downside is that it would also ignore any DeprecationWarnings that come from pylint's code (for example, the bug in this old astroid issue). If that's unacceptable (I don't know if it is, maybe it's fine), then you could maybe include the literal code line that goes afterwards? So some regex like (?m)^.*DeprecationWarning.*\n.*member = getattr\(obj, name\)\n$? But then it depends on that line of the code never changing, so that's not great either. Maybe this is better though, because it will allow false positives (e.g., letting dep warnings through if asteroid changes that line of code) instead of false negatives (e.g., blocking genuine dep warnings originating in pylint)?
Neither are perfect, I don't think a "perfect" solution exists, either would be better than having nothing. I'll leave the decision to you ;)

In the context of an editor, I don't think DeprecationWarnings are helpful at all, so I'm more 👍 to strip them.
So, hacking on this little plugin here, is trivial.  Just open the Packages folder. (E.g. from the main menu Preferences > Browse Packages.) Open a cmd here, and git clone https://github.com/SublimeLinter/SublimeLinter-pylint.git.  This will immediately take precedence over the "installed" one. Just add that line or a different one to linter.py. The linter will hot-reload on save, so that you see if it works immediately.  Commit to a new branch, and push it.
I don't use wx nor pylint, so we ❤ contributions.

Sounds good! My schedule's been really weird with everything going on in the states, so I may not get to this immediately. I'll try to have something in by the end of this weekend. If you don't hear from me by then, feel free to ping me :)

Ping as requested 👋

ping acknowledged, thanks :) this weekend, for sure this time :|


fromJS force parameter

Could there possibly be a "force" parameter for fromJS. I'm running into an issue using it alongside jsdom, where the === Object test is failing because the object was created in a different context (thus value.constructor === outside_context's Object). I could implement my own fromJS, but I'd prefer to then not have to track the official implementation, and I feel like its a somewhat common case to just want to unconditionally convert things to Map as well.

Thank you for reporting this issue and appreciate your patience. We've  notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

Merging into #1050 - sorry for the massive delay


[manuf] update perso flow to validate the DICE chain with OpenSSL on the host

This updates the perso flow to verify the entire DICE certificate chain using OpenSSL on the host side. This fixes #24954.

this could have been squashed with the last patch in this chain...

Done.


sanitize changes outputs

Description
Preform extra sanitisation on changes output json to ensure no sensitive values are output.
Release required?

[ ] No release
[x] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Preform extra sanitisation on changes output json to ensure no sensitive values are output.

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

/run pipeline

/run pipeline

:tada: This PR is included in version 1.23.6 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Chat Bot Epic

This Epic has tickets related to the chat bot functionality for IoGT. Significant work for the functionality has been done by @geoo89 and he should be the contact point for any questions/queries.
Here is a list of features that need to be done as a part of this epic:

Review messaging.models - Use managers where applicable
Refactor messaging app to be more django-esque
Replace urllib.request with requests package
Update existing test cases to use Django Test framework (contrary to DjangoTestPlus)
Add Model Factories for messaging Test Cases
Complete skipped test cases
Use https://github.com/rapidpro/rapidpro-python or write custom client for communication with RapidPro server
Decide on async/sync communication with RapidPro server
Refactor the RapidPro webhook to use DRF
Refactor Test Cases
Stitch longer messages to single message on the IoGT website
Make quick replies "clickable" so the user doesn't have to type them
Preview image links to show images (not a file)
Give the editor an option to start a chat with the chosen bot based on a button
Add Chatbot settings to Wagtail Admin

Additionally, once the above functionality is working, we'd have to look into the following problems:

The communication from IoGT to RapidPro isn't secure because there is no authentication layer. We need to figure out a way to make this communication secure.
Test the integration on a newer version of IoGT
Figure out a way to auto update the screen or intimate the user that their latest messages will be shown only when they update the page

@dannyparsons @geoo89 can you proofread this and add something I might have missed?

Thanks, this looks great! A few minor comments:

Use rapidpro-python or write custom client for communication with RapidPro server
I believe (but please double check) rapidpro-python is just a wrapper for this API, which allows you to access the content on the server (e.g. defined flows, contacts, etc), but is not for sending messages back and forth.

Stitch longer messages to single message on the IoGT website
You can identify messages that belong together in that they have the same rapid_pro_message_id. I don't think we can easily recover the correct order for stitching together though if the requests arrive in the wrong order.

Preview image links to show images (not a file)
Attachments can be of various media types (image, video, etc); RapidPro does store the media type of a file, but unfortunately doesn't transmit it via the External API channel. Attachment URLs are currently part of the message body. (I defined an attachments field, but it's not being populated yet, which needs to be done.)

Give the editor an option to start a chat with the chosen bot based on a button
Each button should probably have a bot and a trigger message associated to it (different triggers can start different chat flows within the same bot).

@dannyparsons Could you please confirm the following:

Can an article have more than one chat with bot buttons?
Do we want to dictate the order of contents and  chat with bot button e.g., some content then chat with bot button, and then again some content... or chat with bot button will always appear at the same place?

It would be good to have the chat with bot button as an element of the body which could be placed anywhere within the contents.
It would be good not to be restricted to one button only in an article.


Packaging HTML files as assets

I'm bundling a Lambda function using the @now/node-server builder. The function uses the fs to render some template (.html) files. Because it doesn't explicitly require them in the code, they get ignored and are not bundled within the function. Would it be possible to use the "asset" feature of ncc to package them explicitly with the function?
Thank you very much!

Yes, assets are included when you use the __dirname identifier to refer to them relatively, and then the reference will be rewritten.
Could you share how you were trying to load them? We are trying to understand the various usages, as we'd like to extend this support further.

I'm having the same issue when loading templates from a directory during runtime.
Easiest solution would be to be able to specify a list of paths that should be included as-is within the built directory (mapped to single-level, hashed directory names for example). So while the various directories to look for templates are known upfront (and can use __dirname for specifying them) the actual files are only resolved during runtime.

There will soon be a config options for includeFiles so you can specify which template files should be part of the lambda.
See this PR in the @now/node builder: https://github.com/zeit/now-builders/pull/277


issue: is the index_parallel file extensions not available in druid docker image version 25.0.0

@cryptoe Hi thanks for the sugeestion prompt, I was trying to ingetsion data in druid using an ingetsion spec,
In the input type we were able to define only 'index' and not 'index_parallel'
was getting error that index_parallel extension doesnt exist, I will have to manually add that in my container file


Refactor/rewrite unless else statements

Mini refactoring to rewrite unless/else statement as it is bad style!

:+1: ;)

LGTM :DDD


Claw Pack!

While you're changing things in the Dimension Gate pack, maybe also nerf Knighthood -- increase its cost and/or make it Ethereal?
This is what I posted in Discord two days ago (slightly edited for readability), don't know if you saw it:

One piece of feedback on your Dimension Gate pack, I think Knighthood could use a nerf. Permanently upgrading is a very strong effect and the "card in hand" restriction is much easier to meet than fatal restriction of Lesson Learned (which is already a great card and the closest base game comparison for Knighthood). This is based on my play experience with it -- I got Knighthood in one of my runs yesterday and felt it was too easy to use for how much benefit it provided.

My suggestion would be to at least make it cost 3 (like Wish, another card that gives a permanent benefit). Or consider some other nerf; my intuition is that even costing 3 it will be a strong card that might border on too strong. (It also encourages stalling, which isn't great but is inherent to cards like Knighthood and Wish, so I'm okay with that aspect of the card.)

Gk then suggested Ethereal to make it more awkward to play, which seemed like a good idea to me.
I know this is tangential to the main point of the PR, but thought it was worth mentioning. Feel free to postpone this discussion to some other time if you think this needs more consideration/discussion and don't want to derail things.

I took a pass through this to take some of the burden of PR reviews off Gk. Hope the comments all make sense, probably good for Gk or me to do a second pass after any changes based on the comments I've made.

P.S.: I really look forward to playing with this pack. Hard to judge where the balance ends up but there's enough Claw generation and scaling that it could be a strong way to do damage, and I'm excited to experience how it plays. If it ends up being too strong, it'll be pretty funny anyway.

The core set art is really cool. Awesome to see it.
Backpack Smack is absolutely hilarious.

Alright, I completed the last comments from modargo, as well as simplified the issues surrounding base Claw by just making a PMClaw duplicate.  This means the only time the GashAction override ever triggers is if you acquire a true prismatic shard Claw, but still works as it did before - I made this change because of the Sharpen keyword mentioning Ghost Claw by name, and just existing in general.  The PMClaw still looks like the Defect card, but reads "Sharpen 2" instead of the normal claw bonus card text.
I think we should be ready to roll now.