Improved Pep8 Compability for Autogenerated Code

Motivation
Even though this is a tiny change, for teams and single developers working on large projects, where pep8 and some other linting tool satisfaction is required for commit and push, this is a game changer, whereas the developer has control over the content of the cell, but not on how the cells are converted in auto generated code.
I do not want to make nbdev pep8 compatible, since I suppose you probably don't care for a reason, but this fix empowers the users who want to write pep8 compatible code with nbdev to do so.
Issues Addressed
This change ensures that there are two empty lines between every cell. Pep8 requires to have two lines before  a function call. The code from the cells itself is not modified, only the auto generation process. ("PEP 8: expected 2 blank lines, found 1")
To further improve the "pep8 correctness" of auto generated code, the generated comments contain a space between the hash and the comment. ("PEP 8: block comment should start with '# '")

Thanks for your PR! After discussing it with Jeremy, we will merge this PR and amend it a little bit:

the space after the # is fine
the two lines between any cell is a bit more annoying for users would don't really care about PEP8 so we will make this configurable with an int (default to 1) in the settings.ini file. You can then set it to 2 to conform to PEP8.

I will ensure this doesn't impact the conversion back and forth or the diff scrip, every should be finished by the end of today.
Thanks again!


MINOR: fix generics in KStream.groupBy(...)

The type param V1 in the KStream.groupBy(...) methods is not needed.
@guozhangwang

Thanks for the PR.
It would be easier to verify the change if the PR description included a bit more detail (e.g. why it's not OK to pass a Serde with V1 instead of V to groupBy). This may be obvious to @guozhangwang, but it's generally a good idea to explain things for a wider audience.
Also, the PR description becomes the commit message so it's better to use a PR comment for things unrelated to the code (like mentioning reviewers).

Thanks @ijuma - i'll close and do it again

@dguy, thanks. Btw, you can simply edit the PR title and/or description in the future instead of creating a new one.


deps: bump rustc-ap crates to v683

Resolves #4355

AppVeyor failures are spurious
Build started
git clone -q https://github.com/rust-lang/rustfmt.git C:\projects\rustfmt
git fetch -q origin +refs/pull/4469/merge:
git checkout -qf FETCH_HEAD
Running Install scripts
appveyor-retry appveyor DownloadFile https://win.rustup.rs/ -FileName rustup-init.exe
Downloading rustup-init.exe (6,663,680 bytes)...100%
if "%TARGET%" == "i686-pc-windows-gnu" set PATH=%PATH%;C:\msys64\mingw32\bin
if "%TARGET%" == "x86_64-pc-windows-gnu" set PATH=%PATH%;C:\msys64\mingw64\bin
set PATH=%PATH%;C:\Users\appveyor\.cargo\bin
rustup-init.exe --default-host %TARGET% --default-toolchain %CHANNEL% --profile minimal -y
info: profile set to 'minimal'
info: setting default host triple to i686-pc-windows-gnu
info: syncing channel updates for 'nightly-i686-pc-windows-gnu'
info: update not yet available, sorry! try again later
info: default toolchain set to 'nightly'
  nightly unchanged - (toolchain not installed)
Rust is installed now. Great!
To get started you need Cargo's bin directory (%USERPROFILE%\.cargo\bin) in
your PATH
environment variable. Future applications will automatically have the
correct environment, but you may need to restart your current shell.
rustc -Vv
info: syncing channel updates for 'nightly-i686-pc-windows-gnu'
info: update not yet available, sorry! try again later
error: toolchain 'nightly-i686-pc-windows-gnu' is not installed
Command exited with code 1


Sync runhouse before installing default_env.

#1019  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rohinb2 and the rest of your teammates on  Graphite

Merge activity

Jul 17, 11:02 AM EDT: @rohinb2 started a stack merge that includes this pull request via Graphite.


The process of grasping the robotic arm

Hello, how should I carry out the process of grasping the robotic arm? What is the approximate process?

Hi! If you’re referring to how we close the gripper that we have on the xArm, we just use a Dynamixel motor which is attached to our gripper mount: https://github.com/haritheja-e/robot-utility-models/tree/main/hardware/xArmMount. After that, we can just actuate the motor to close the gripper in code. One thing to note: our policies are limited to the same gripper used on our data collection tool, but it is pretty low-cost. Please let us know if you have any additional questions!

Thank you for your patient reply. Can we use the robotic arm's built-in point cloud camera for scene understanding, instead of attaching an iPhone to the gripper?

I'm not sure of the position of the robot arm's built in camera, but if it is similar to that of our iPhone, then it could potentially be used; however, you would need to do an affine transform to match the iPhone POV. We tried this ourselves using the Hello Robot Stretch's default RealSense D405 camera. But, while we were able to get non-zero success for simple tasks (bag and tissue pick up), it failed on other tasks as the focal length of the D405 camera was fixed and did not match the iPhone's focal length that we set (we disable autofocus). I've attached a figure showing images from the two cameras below:

This information can be found in section A.6 of the appendix of our paper. Overall, we found it hard to exactly match the iPhone view with other cameras, and thus could not produce the same success.


Doesn't run with Companion - URL

It's not running when image source is a URL

Neither with Google Drive source

Neither with Google Drive source


App not responding?

Hello,
I am little bit confused about how to use this app.
As far as I figured out so far, we are supposed to set two points in the camera and then the app would measure the distance between them for me. However, I have tried many times but it never comes up with any measurement estimate. Is this a bug or am I not correctly use the app?

Hello,
I am little bit confused about how to use this app.
As far as I figured out so far, we are supposed to set two points in the camera and then the app would measure the distance between them for me. However, I have tried many times but it never comes up with any measurement estimate. Is this a bug or am I not correctly use the app?

It looks like the background and text are both white so the inch measurement is being hidden. Change the measurement label background color to something like red and you will see the measurement
        // Makes the background red         measurementLabel.backgroundColor = .red


Breaking content into A4-sized pages

I am currently working on integrating sir-trevor for our editor and was wondering if there was a way to achieve the stated functionality. Basically the UI should know when the content is longer than one page and break to next page (just like a native word editor).
If anyone has any ideas or pointers on how to achieve this it would be great. I don't mind working on it and issuing a PR if it's not too complex.

Feels like this would be better as an output rather than a feature of the editor?
Something like print stylesheets, or calculate the height of blocks within your code and split as required.
In terms of code it's not something we'd accept as a PR, but is probably something you could patch on top of the current editor.

It needs to be both in the front-end (the editor) and in the back-end right? Because the user should be able to see when it breaks to the next page so they can edit accordingly?
Thanks anyway. Will have to figure out how to do this...


Add TripInfo to TimeTableScreen

TL;DR
Added origin and destination station names to the TimeTable screen header
What changed?

Added a trip property to TimeTableState to store trip information
Added two rows in the TimeTable screen header displaying the origin and destination station names
Each row includes a location icon and the station name in title medium style
Updated the onLoadTimeTable function to populate the trip information in the state

Why make this change?
To improve user experience by clearly displaying the selected journey's origin and destination stations in the TimeTable screen header, providing better context for the displayed timetable information.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#272
#271
#270
#269  👈
#268
#267
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ksharma-xyz and the rest of your teammates on  Graphite

Merge activity

Oct 31, 12:30 AM EDT: A user merged this pull request with Graphite.


Typo

tsconfig-path -> tsconfig-paths

I signed/agreed to CLA, but there may be a lag time / issue

Updated to fix second case
https://github.com/dividab/tsconfig-paths

Thanks!


Participating in Hacktoberfest?

Just a friendly suggestion to participate in the Hacktoberfest
https://hacktoberfest.digitalocean.com/resources/maintainers

I have signed up and added the label. Can you check if your PR now counts so everything's working?

I got my first counting PR. Thank you so much!


[BUG] No variable named EWW_TIME in scope

Checklist before submitting an issue

[X] I have searched through the existing closed and open issues for eww and made sure this is not a duplicate
[X] I have specifically verified that this bug is not a common user error
[X] I am providing as much relevant information as I am able to in this bug report (Minimal config to reproduce the issue for example, if applicable)

Description of the bug
I was trying to use formattime in eww and it throws this error:
error: No variable named EWW_TIME in scope
I went through the documentation and it did had EWW_TIME as a magic variable
Reproducing the issue
This happens everytime i declare EWW_TIME variable
Expected behaviour
No response
Additional context
No response

I also have this problem.
I have included my error message to add more detail to this report.
error: No variable named `EWW_TIME` in scope
    ┌─ ./bars/main.yuck:111:32
    │
111 │       (label :text {formattime(EWW_TIME, "+%H")} :class "clock_hour" )
    │                                ──────── Used here
    │
    → Hint: Either define it as a global variable, or add it to the argument-list of your `defwidget` and pass it as an argument
    → Hint: If you meant to use the literal value "EWW_TIME", surround the value in quotes

I am not re-defining the variable as well.

Sure, I've extracted the minimum amount of code to get it to happen on my end.
(defwidget clock_module []
  (box :class "module module-clock" :space-evenly "false" :orientation "h"
    (label :text " " :class "clock_start_pad" )
    (label :text {formattime(EWW_TIME, "+%H")}  :class "clock_hour" )))

(defwindow main
  :geometry (geometry
    :x "0%"
    :y "8px"
    :width "99%"
    :height "36px"
  :anchor "top center")
  :stacking "fg"
  :namespace "dock"
  :exclusive true

  (box :class "bar_class" :orientation "h"
    (clock_module)))

Version Information:

Linux <HOSTNAME> 6.5.7-arch1-1 #1 SMP PREEMPT_DYNAMIC Tue, 10 Oct 2023 21:10:21 +0000 x86_64 GNU/Linux

local/hyprland 0.30.0-1

eww 0.4.0 d58d91de78d2b9984a1bbb8314be197bc0e283dc

If there is any questions about specific environment information I am happy to provide that aswell.

The error is valid as EWW_TIME does not exist in the version you are using, and was added by this pr #792 in this commit.
You are using the latest release from the releases section, which does not include this variable.
You could switch to the latest version by building eww from source (check  the 'Building' section)

I get the same error on latest eww eww 0.4.0 65d622c81f2e753f462d23121fa1939b0a84a3e0
Built with
cargo b --release --no-default-features --features=wayland

Repro
(defwindow example
           :monitor 0
           :geometry (geometry :x "0%"
                               :y "0px"
                               :width "100%"
                               :height "30px"
                               :anchor "top center")
           :stacking "fg"
           :reserve (struts :distance "40px" :side "top")
           :windowtype "dock"
           :wm-ignore false
    EWW_TIME
)

Error
   ┌─ /home/[..]/.config/eww/eww.yuck:12:5
   │
12 │     EWW_TIME
   │     ──────── Used here
   │
   → Hint: Define it as a global variable
   → Hint: If you meant to use the literal value "EWW_TIME", surround the value in quotes

Probably this is because validate never used
Details

warning: method `validate` is never used
  --> crates/eww/src/state/one_to_n_elements_map.rs:72:12
   |
11 | impl<I: Copy + std::hash::Hash + std::cmp::Eq + std::fmt::Debug, T> OneToNElementsMap<I, T> {
   | ------------------------------------------------------------------------------------------- method in this implementation
...
72 |     pub fn validate(&self) -> Result<()> {
   |            ^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

warning: method `validate` is never used
   --> crates/eww/src/state/scope_graph.rs:113:12
    |
65  | impl ScopeGraph {
    | --------------- method in this implementation
...
113 |     pub fn validate(&self) -> Result<()> {
    |            ^^^^^^^^

warning: method `validate` is never used
   --> crates/eww/src/state/scope_graph.rs:508:16
    |
400 |     impl ScopeGraphInternal {
    |     ----------------------- method in this implementation
...
508 |         pub fn validate(&self) -> Result<()> {
    |                ^^^^^^^^

warning: `eww` (bin "eww") generated 3 warnings


Where should async communication between participants and mentors+organizers happen?

https://pymc-data-umbrella.xyz/en/latest/sprint/faq.html#is-there-a-requirement-to-have-attended-1-of-the-working-session points to the issues on this repo to ask questions. But as I mentioned in https://github.com/pymc-devs/pymc-data-umbrella/pull/47#discussion_r900183678 in my opinion it would be best to point them to discourse.
Here is the pro/con list of reasons I came across (didn't sit to think about this intensively though):
Pro discourse:

Single place for questions about the events themselves and about pymc installation, usage...
Engages the wider pymc community. There are also many users on discourse who can answer questions about installation and usage and answers should generally be faster than they'd be here

Against discourse:

Requires a new account (but one can sign in with github too)
Is a different website and interface to github

Side note: do we want to share the mentor signup on discourse (or a pre mentor signup form to do some vetting) in order to get more mentors for the events?

@OriolAbril
We can direct people to Discourse. I don't monitor it too much, but if you or @cluhmann see a question, can tag me on it.
Where on discourse?  Should we create a thread for the "Data Umbrella PyMC Open Source Working Sessions - July/Aug 2022"

I think the two most sensible options would be

Create an open source working sessions tag and have them use the Question/v4 or Question/version-agnostic tags
Create a subcategory Events/open source working sessions.

With alternatively also a tag that is date specific like osws_july_2022 to complement either option. I don't think we should use a date specific category.
I can't commit to answering or tagging (neither here nor on discourse though) until late July. So you and @cluhmann should be the ones to decide. That being said, discourse has the nice feature of allowing you to subscribe to both tags or categories. You can subscribe to the tag/subcategory we create for this and receive mails when a question is asked there (and not for all the other questions). That way you don't need to log in to discourse or have someone tag you to be notified of questions related to the sprint.

Ok, I'll let @cluhmann set that up.
Truth is, most people don't really read stuff very carefully and will post wherever they hear about the event. So, we'll still get questions all over the place.  But, that's to be expected, and ok.

I think discourse would be good for this.  It would help increase the visibility of the sprint to "non-participants" on discourse and it would get the sprint participants onto discourse.  Both good things.  I can set up whatever category/tags we need.

Truth is, most people don't really read stuff very carefully

Indeed, I am already painfully well aware of this :sweat:. I keep that in mind and try to use those admonition boxes, headings, hide useful but not key details in dropdowns... but I also try to write docs thinking about people who will read them carefully (sometimes that is directly future me too, for example with the pymc governance or sphinx-primer website)

Let's create a tag then: open-source-working-sessions and update the link. We can add info to the link so when they click on it they go directly to creating a topic with some pre-filled tags and categories. I'd make category Questions/v4 and tag open-source-working-sessions the default. It can be changed when editing (or by us later on once posted) if it were needed. If we use that, the link would look like:
https://discourse.pymc.io/new-topic?category=Questions/v4&tags=open-source-working-sessions

Ref: https://meta.discourse.org/t/how-to-create-a-new-topic-link-with-pre-filled-information/28074
Note: @cluhmann I don't know how to create tags without also creating a new topic, so I haven't created the tag yet.

Link updated in https://github.com/pymc-devs/pymc-data-umbrella/pull/87 but keeping the issue open as a reminder to create the tag

Updated https://discourse.pymc.io/t/data-umbrella-jul-aug-2022-contributing-to-pymc-open-source-working-sessions/9693 to have the tag so closing the issue as tag is now created


feat: custom overlay scrollbar, fixes #1045

fixes #1045
Type of changes

Feature (custom scrollbar without gutter)
Bug fix

How Has This Been Tested?

Visually tested

Looks good to me.
@sumanthyedoti Could you resolve the merge conflict, so that we can merge this in?

@riodeuno  Will do

@sumanthyedoti Hey, Your branch had some merge conflicts. A lot of code has been done since November. So couldn't fix the merge conflicts with the web editor. Created a new PR with the same changes - https://github.com/appsmithorg/appsmith/pull/2478
Thanks a lot for the PR. The fix is working as expected :D

@sumanthyedoti Hey, Your branch had some merge conflicts. A lot of code has been done since November. So couldn't fix the merge conflicts with the web editor. Created a new PR with the same changes - https://github.com/appsmithorg/appsmith/pull/2478
Thanks a lot for the PR. The fix is working as expected :D


Clean up the docs.

Add note.template to API.md.
Remove references to Request and RequestResponse methods that do not exist.

@bsatrom based on the git history of docs/api.md, it seems auto-genereated by some tool, but I'm not sure what, exactly. Do you know? It looks like you were last to touch that file.

@haydenroche5 it was Doxygen. Do I need to re-gen these?

@haydenroche5 it was Doxygen. Do I need to re-gen these?

I think so. Probably better than me editing manually.


Runtime Error when resuming training

I was trainig using multiple GPUs on my own dataset, but when resuming training, I got this error
Loading pretrained weights from data/pretrained_model/vgg16_caffe.pth
loading checkpoint models/vgg16/virtual_sign_2019/faster_rcnn_1_3_1124.pth
loaded checkpoint models/vgg16/virtual_sign_2019/faster_rcnn_1_3_1124.pth
Traceback (most recent call last):
  File "trainval_net.py", line 340, in <module>
    optimizer.step()
  File "/home/sy1806701/anaconda3/envs/pytorch/lib/python3.5/site-packages/torch/optim/sgd.py", line 101, in step
    buf.mul_(momentum).add_(1 - dampening, d_p)
RuntimeError: The expanded size of the tensor (3) must match the existing size (25088) at non-singleton dimension 3

Environment:
Pytorch 0.4.0
CUDA 9.0
cuDNN 7.1.2
Python 3.5
GPUs: 4 x Tesla V100
Command line I used:
CUDA_VISIBLE_DEVICES=2,3,4,5 python trainval_net.py --dataset virtual_sign_2019 --net vgg16 --bs 32 --nw 16 --lr 0.001 --cuda --mGPUs --r True --checksession 1 --checkepoch 3 --checkpoint 1124
I have tried everything I can to solve this problem, incluing many issue related to this, like #515 #475 #506 ,  but the problem still exists....... is there any possilbe solution? thanks....

Do you experience the same error when training on a single GPU, and then when resuming training on a single GPU?

Do you experience the same error when training on a single GPU, and then when resuming training on a single GPU?

Yes, when using single GPU, the same Runtime Error occurs.
I guess it's caused by
optimizer.load_state_dict(checkpoint['optimizer'])
in trainval_net.py while resuming training, because the error message points to "optimizer.step()" everytime. I tried to comment this  two lines in trainval_net.py:
https://github.com/jwyang/faster-rcnn.pytorch/blob/0797f6290e104e7d63cd487af759840d4a36985b/trainval_net.py#L283
# optimizer.load_state_dict(checkpoint['optimizer'])
# lr = optimizer.param_groups[0]['lr']

which means the saved state of optimizer wont't be loaded when resuming training, and actually it works, the Runtme Error never occurs again. But I've no idea is this the right solution, and whether it will affect later traning prosess, neither do I know what on earth caused this problem.......

I haven't been able to recreate your issue. Could you please send me the errors you get for 1 GPU and multiple GPUs?
Can you send me a snippet of the code you're using from
fasterRCNN.create_architecture()
till ...
if args.use_tfboard:
Maybe I can spot an abnormality

Sure. The errors I got for 1 GPU and multiple GPUs are the same, and both of them are as my description above, which is

Loading pretrained weights from data/pretrained_model/vgg16_caffe.pth
loading checkpoint models/vgg16/virtual_sign_2019/faster_rcnn_1_3_1124.pth
loaded checkpoint models/vgg16/virtual_sign_2019/faster_rcnn_1_3_1124.pth
Traceback (most recent call last):
  File "trainval_net.py", line 340, in <module>
    optimizer.step()
  File "/home/sy1806701/anaconda3/envs/pytorch/lib/python3.5/site-packages/torch/optim/sgd.py", line 101, in step
    buf.mul_(momentum).add_(1 - dampening, d_p)
RuntimeError: The expanded size of the tensor (3) must match the existing size (25088) at non-singleton dimension 3

The code snippet I‘m using is
    fasterRCNN.create_architecture()

    lr = cfg.TRAIN.LEARNING_RATE
    lr = args.lr
    # tr_momentum = cfg.TRAIN.MOMENTUM
    # tr_momentum = args.momentum

    params = []
    for key, value in dict(fasterRCNN.named_parameters()).items():
        if value.requires_grad:
            if 'bias' in key:
                params += [{'params': [value], 'lr': lr * (cfg.TRAIN.DOUBLE_BIAS + 1), \
                            'weight_decay': cfg.TRAIN.BIAS_DECAY and cfg.TRAIN.WEIGHT_DECAY or 0}]
            else:
                params += [{'params': [value], 'lr': lr, 'weight_decay': cfg.TRAIN.WEIGHT_DECAY}]

    if args.optimizer == "adam":
        lr = lr * 0.1
        optimizer = torch.optim.Adam(params)

    elif args.optimizer == "sgd":
        optimizer = torch.optim.SGD(params, momentum=cfg.TRAIN.MOMENTUM)

    if args.cuda:
        fasterRCNN.cuda()

    if args.resume:
        load_name = os.path.join(output_dir,
                                 'faster_rcnn_{}_{}_{}.pth'.format(args.checksession, args.checkepoch, args.checkpoint))
        print("loading checkpoint %s" % (load_name))
        checkpoint = torch.load(load_name)
        args.session = checkpoint['session']
        args.start_epoch = checkpoint['epoch']
        fasterRCNN.load_state_dict(checkpoint['model'])
        optimizer.load_state_dict(checkpoint['optimizer'])
        lr = optimizer.param_groups[0]['lr']
        if 'pooling_mode' in checkpoint.keys():
            cfg.POOLING_MODE = checkpoint['pooling_mode']
        print("loaded checkpoint %s" % (load_name))

    if args.mGPUs:
        fasterRCNN = nn.DataParallel(fasterRCNN)

    iters_per_epoch = int(train_size / args.batch_size)

    if args.use_tfboard:
        from tensorboardX import SummaryWriter

        logger = SummaryWriter("logs")

and by the way, the code actually wasn't modified, and is exactly the same as the master branch of this repo. Thanks~

Could you try and modify your code as suggested in this comment
It has been merged into the pytorch-1.0 branch, but not the main branch. Maybe it will solve your problem as well.

Could you try and modify your code as suggested in this comment
It has been merged into the pytorch-1.0 branch, but not the main branch. Maybe it will solve your problem as well.

Thanks... I've tried this code, I changed pytorch to 1.0 and used the 1.0 branch, and then moved
if args.cuda:     fasterRCNN.cuda()
above the assignment of the optimizer, but when resuming training, the problem still exist...

And you still get the same error?
Everything should work pretty much out-of-the-box; git pull and run..
As a sanity check, have you tried to simply run everything normally (not resuming, single gpu, etc.)? And then resuming with default parameters? Steadily working your way up to the full version of what you want to run.

Yes... if I just use the out-of-the-box code, everything works just fine when traing from scratch, either on single or multiple GPUs,  but the error always occurs when resuming training...
But as I descripted before, if I comment these two lines
# optimizer.load_state_dict(checkpoint['optimizer'])
# lr = optimizer.param_groups[0]['lr']

in trainvla_net.py when resuming training, the training process goes on normally, and I've tested the modified code on my own dataset, the loss converged normally and the mAP I got from test sets was also acceptable.
I'm using SGD optimizer, so it seems that there isn't any adverse effect so far if I don't load the state dict of this opptimizer when resuming training. But it remains to be varified that if it has any negative effect on other optimizers like Adam.
I'm using torchvision 0.2.1(Build py35_1).

You could try to update your torchvision version, read on a different repo that it might help.
But if, as you said, you have no negative side effects yet when not loading the optimizer's state dict, might as well resume the way you are currently doing.
Sorry I couldn't help you fix the problem.

You could try to update your torchvision version, read on a different repo that it might help.
But if, as you said, you have no negative side effects yet when not loading the optimizer's state dict, might as well resume the way you are currently doing.
Sorry I couldn't help you fix the problem.

Thanks a lot~ I'd try a higher torchvision version.

@HViktorTsoi
my mistake is the same as yours. Have you solved it?

@HViktorTsoi
my mistake is the same as yours. Have you solved it?

Yes, I solved this problem by this
https://github.com/jwyang/faster-rcnn.pytorch/issues/521#issuecomment-489911088
And it seems not having any side effect after a long time usage.

Hi, I am having a same problem.
I try to load the model that has been trained on pytorch==1.2.0 version.
When I load the model in pytorch==1.6.0 version and resumed training,
the training gets so corrupted right after optimizer.step() has been called.
Would loading optimizer that has been trained on different version be an issue??

thanks! I've encountered the same issue and this solution works for me.

Yes... if I just use the out-of-the-box code, everything works just fine when traing from scratch, either on single or multiple GPUs, but the error always occurs when resuming training...
But as I descripted before, if I comment these two lines
# optimizer.load_state_dict(checkpoint['optimizer'])
# lr = optimizer.param_groups[0]['lr']

in trainvla_net.py when resuming training, the training process goes on normally, and I've tested the modified code on my own dataset, the loss converged normally and the mAP I got from test sets was also acceptable.
I'm using SGD optimizer, so it seems that there isn't any adverse effect so far if I don't load the state dict of this opptimizer when resuming training. But it remains to be varified that if it has any negative effect on other optimizers like Adam.
I'm using torchvision 0.2.1(Build py35_1).

And you still get the same error?
Everything should work pretty much out-of-the-box; git pull and run..
As a sanity check, have you tried to simply run everything normally (not resuming, single gpu, etc.)? And then resuming with default parameters? Steadily working your way up to the full version of what you want to run.
EDIT: What version of torchvision are you using?


Add support for hide_selector and browser_width

These are options supported by depict but currently can not be set through whippersnapper.
This also renames selector to target_selector to remove any ambiguity now that there are two "selector" arguments/config options.

Great, thanks @chadmoone!


Include details on dependencies

Links for installing Jupyter notebooks and Python 3.5, poached from the Terra README.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Route to retrieve NCAA schools

Hey Henry -
One thing I'm running into is there are a few UX scenarios where someone would want to search/select a team. I'm wondering if it's possible to turn this page into a route:
https://www.ncaa.com/schools-index/
Ideally, just returning all schools. If that's out of the question, I think I'll just manually enter them all in a database and make my own endpoint for them.

Sure. I'll try to update it today, otherwise it will probably be Sunday.
Also, heads up that I'm changing the /game/id route to return some general info about the game. This will give you things like live stats (possession, field position, etc.), linescores, venue (if available), and which subroutes exist. So you should change any /game/id routes to /game/id/boxscore if you aren't using that already.
Example for https://www.ncaa.com/game/6305900:
{
  "contests": [
    {
      "__typename": "Contest",
      "id": "6305900",
      "sportCode": "MFB",
      "sportUrl": "football",
      "division": 11,
      "clock": "",
      "currentPeriod": "FINAL",
      "finalMessage": "FINAL",
      "gameState": "F",
      "statusCodeDisplay": "final",
      "network": null,
      "startTime": "12:00",
      "startTimeEpoch":<PHONE_NUMBER>,
      "week": "14",
      "seasonYear": 2024,
      "winner": 106,
      "hasStartTime": true,
      "hasBoxscore": true,
      "hasPbp": true,
      "hasScoringSummary": true,
      "hasPreview": false,
      "hasRecap": false,
      "hasTeamStats": true,
      "linescores": [
        {
          "__typename": "Linescore",
          "period": "1st",
          "home": "3",
          "visit": "0"
        },
        {
          "__typename": "Linescore",
          "period": "2nd",
          "home": "7",
          "visit": "10"
        },
        {
          "__typename": "Linescore",
          "period": "3rd",
          "home": "0",
          "visit": "0"
        },
        {
          "__typename": "Linescore",
          "period": "4th",
          "home": "0",
          "visit": "3"
        }
      ],
      "teams": [
        {
          "__typename": "ContestTeam",
          "teamId": "919",
          "isHome": true,
          "color": "#CE0F3E",
          "seoname": "ohio-st",
          "nameFull": "The Ohio State University",
          "nameShort": "Ohio St.",
          "name6Char": "OHIOST",
          "teamRank": 2,
          "gameRank": 2,
          "score": 10,
          "seed": null,
          "record": "(10-2-0)",
          "divisionName": "fbs",
          "division": 11,
          "isWinner": false
        },
        {
          "__typename": "ContestTeam",
          "teamId": "106",
          "isHome": false,
          "color": "#041E42",
          "seoname": "michigan",
          "nameFull": "University of Michigan",
          "nameShort": "Michigan",
          "name6Char": "MICH",
          "teamRank": null,
          "gameRank": null,
          "score": 13,
          "seed": null,
          "record": "(7-5-0)",
          "divisionName": "fbs",
          "division": 11,
          "isWinner": true
        }
      ],
      "liveVideos": [],
      "championship": null,
      "championshipGame": null,
      "links": [],
      "location": {
        "__typename": "Location",
        "venue": "Ohio Stadium",
        "city": "Columbus",
        "stateUsps": "OH"
      },
      "stats": {
        "__typename": "LinescoreStatsFootball",
        "down": null,
        "distance": null,
        "possession": null,
        "yardline": null,
        "yardsFromGoal": null
      }
    }
  ]
}

That'll be a great update - especially venue. Do you have anything setup to where I can donate to your repo or project financially? Would love to throw some bucks your way for the API, it's powering the whole app I'm doing.

This is live now in 2.0.0. Let me know if you have any questions.
I do have a Buy Me a Coffee page. I appreciate any support, but it's not required or expected.

Also, here's how to update if you're unsure how to do it.
Assuming you're using Docker Compose (recommended), navigate to the directory with the docker-compose.yml file and run these two commands:
# pulls latest image
docker compose pull
# restarts the service
docker compose up -d

You can also use Watchtower to automatically update your containers when new images are released.


Updating to compose 1.2.0-alpha build issue

This is not an issue with the current release. But I am attempting to update the project to use the latest compose-jb alpha 1.2.0-alpha01-dev707 supporting kotlin 1.6.21 to add js and native targets.
When building I get the error:
LazyPainterResource.kt: (49, 17): @Composable invocations can only happen from the context of a @Composable function

which is caused by: rememberVectorPainter being called in the map callback where map is not a @Composable function. And also it is called inside a flow. Which isn't allowed in the latest compose version. So this would probably need a rework.
        "xml" -> kamelConfig.loadImageVectorResource(data, resourceConfig).map { resource ->
            resource.map { imageVector ->
                rememberVectorPainter(imageVector)
            }
        }

I'm trying to think of a way to handle this. Would completely removing use of flows by loadImageVectorResource be an acceptable solution for vectors, as rememberVectorPainter can't be called inside a flow?
which would look something like this:
        "xml" -> flowOf(kamelConfig.loadImageVectorResource(coroutineScope, data, resourceConfig)
            .map { imageVector ->
                rememberVectorPainter(imageVector)
            }
        )

Or does anyone have another suggestion?

I have currently updated the compose version to the latest alpha, and I'm facing this problem. It worked before, I don't understand what's the problem now. Do you have any idea?

@alialbaali Well I explained the issue above. I was planning to take a look at it again soon. But I was wondering:
I'm trying to think of a way to handle this. Would completely removing use of flows by loadImageVectorResource be an acceptable solution for vectors, as rememberVectorPainter can't be called inside a flow?

To me seems that your solution to cache vector resources might not been needed as rememberVectorPainter can accomplish that? Or am I misunderstanding something

How about this?
    val painterResource by remember(data, resourceConfig) {
        when (data.toString().substringAfterLast(".")) {
            "svg" -> kamelConfig.loadSvgResource(data, resourceConfig)
            "xml" -> kamelConfig.loadImageVectorResource(data, resourceConfig)
            else -> kamelConfig.loadImageBitmapResource(data, resourceConfig)
        }
    }.collectAsState(Resource.Loading(0F), resourceConfig.coroutineContext)

    return painterResource.map { value ->
        when (value) {
            is ImageVector -> rememberVectorPainter(value)
            is ImageBitmap -> remember(value) { BitmapPainter(value, filterQuality = filterQuality) }
            else -> remember(value) { value as Painter }
        }
    }

This should be fixed in version 0.4.0.

working for me now 👍 thanks


Add minting/wrapping and faucet links on testnets

Description
It would be easier for people that want to test the dAPP to have easy access to a faucet (via a link) and to a mint/wrap function to create tokens for TTT (goerli) and W-ETH (rinkeby, ropsten).
(re-evaluate if the tokens are stll the same in other networks)
Acceptance criteria

Faucet icon button
Mint icon button

Tasks

[ ]

Story Points

Removing from product backlog in favor of #638 -> implementing it later

Minting is now available for tokens. Closing

We still don't have any links to faucets though :smiley:


Deploy to Function App Script Failed on (intermediate value).parsedBody.map is not a function

Using AZ function deploy (1.12.1) deploy:

Crashes on final step:
(intermediate value).parsedBody.map is not a function
Reverting to 1.10.4 solved this problem.
Windows, current
VS code, current

Happens to me as well, but randomly. Sometimes restarting the deployment process helps, but not reliably

Yes it do occur sometimes I figured that restarting vs code helps

I am facing similar erratic issues for Azure Web App deployment and restarting VS Code fixes this at times

me too

I have started seeing this error at random when deploying to Azure App Service.
This error started in the past couple weeks or so. I'd never seen it before, and in general never had problems with Azure App Service deployments from VS Code.
Thus far if I re-run the deployment after getting the error, it works, but I find it unsettling to see random errors in a deployment procedure.

In my case, re running didn't solve the problem. However I only tried a few time before reverting. I also tried several iterations back before eventually landing on 1.10.4.  So it could be that it just ran and the version wasn't the issue. However  in 1.10.4 I haven't had the issue.

just restart VS code and it will work  :)

Restarting VS Code is not working for me.

just restart VS code and it will work :)

Not reliably

Same here :|

Can anyone share the contents of the output channel when this error occurs? It'll help me figure out which call is causing the error.

10:06:26 AM: Failed to get latest templates: Cannot read properties of undefined (reading 'resources')
10:07:04 AM mycompany-dev-integrations-func: Starting deployment...
10:07:05 AM mycompany-dev-integrations-func: Creating zip package...
10:07:14 AM mycompany-dev-integrations-func: Zip package size: 25.2 MB
10:07:18 AM: Error: (intermediate value).parsedBody.map is not a function

@dfuchs-hitachi, thanks for providing the logs. We've fixed this in https://github.com/microsoft/vscode-azuretools/pull/1545 and hope to release it soon.

@dfuchs-hitachi, thanks for providing the logs. We've fixed this in microsoft/vscode-azuretools#1545 and hope to release it soon.

Is there any workaround in the interim?

for me the error occurs at
3:39:14 PM func-myfunc-dev-we-001: Preparing output...
3:39:14 PM func-myfunc-dev-we-001: Copying files to destination directory '/tmp/build/expressbuild'...
3:39:25 PM func-myfunc-dev-we-001: Done in 11 sec(s).
3:39:25 PM func-myfunc-dev-we-001: Removing existing manifest file
3:39:25 PM func-myfunc-dev-we-001: Creating a manifest file...
3:39:25 PM func-myfunc-dev-we-001: Manifest file created.
3:39:25 PM func-myfunc-dev-we-001: Copying .ostype to manifest output directory.
3:39:25 PM func-myfunc-dev-we-001: Done in 178 sec(s).
3:39:37 PM: Error: (intermediate value).parsedBody.map is not a function

and reverting to v1.11.0 worked
@thecury, revert to a previous extension version, it's a simple click away.

Fixed by https://github.com/microsoft/vscode-azurefunctions/pull/3786

Confirmed that v1.12.3 seems to be working. Thanks!

Thanks!

Still happening for web apps
VS Code: 1.81.1
Azure Tools: 1.2.0
Azure App Service: 0.25.0

Still happening for web apps
VS Code: 1.81.1 Azure Tools: 1.2.0 Azure App Service: 0.25.0

Sorry about that. The fix has been released in Functions, however is still waiting to be released in App Service.


[PROPROSAL] One documentation source

I'm confused as to why there are two sources of documentation mentioned in the README:
http://davidkpiano.github.io/react-redux-form/#/api/Home?_k=n9d8hp
https://davidkpiano.gitbooks.io/react-redux-form/content/
If the latter is the most up to date, why not just reference that and remove the former?

It's because I'm in the process of rewriting (updating) the documentation for 1.0 and still have a place for the recipes. I'm going to be moving the recipes to a separate location though (ideally a live playground where you can play around with the code).

Ahh ok.
BTW, great work on RRF! I've tried many a React/Redux form package, and IMO this is the best one.

Much thanks, @ffxsam! Feel free to let me know your pain points with creating forms, essential features you'd like to see, etc. as we get this ready for 1.0. (I am already using RRF in production, though)

The only thing so far (very minor) is that I think it'd be good to rename actions.xor to actions.pull, just for consistency (push vs pull).

Hm, the only problem with that is that actions.xor can add or remove a value in an array.
[1, 2, 3] xor 2 = [1, 3]
[1, 2, 3] xor 4 = [1, 2, 3, 4]


Why does EF Core pluralize table names by default?

As described in this post:
https://entityframeworkcore.com/knowledge-base/37493095/entity-framework-core-rc2-table-name-pluralization
I'm wondering why the EF Core team took the decision to use the name of the DbSet property for the SQL table name by default?  This is generally going to result in plural table names, as that is the appropriate name for the DbSet properties.  I thought this was considered bad practice, and that SQL table named should be singular - why this default?

Compatibility with EF6 mostly. 😶 #214 will allow you to remove the convention.

I thought this was considered bad practice, and that SQL table named should be singular - why this default?

@jez9999 can you provide any reference on this? Though it is easy to imagine different people having a strong opinion one way or the other, I cannot think of a reason this would really be a bad practice.
BTW, another thing you can do is iterate over the entities in the model using our metadata APIs in OnModelCreating and set the table name using whatever pattern you prefer.

Well it's considered a bad practice because a table already implies that multiple entites exist because it has multiple rows, so pluralizing the entity name is redundant.  It results in generated key names like FK_Users_Accounts which reads better as FK_User_Account, ie. "foreign key linking a user to an account".

You can configure the names the way you want using fluent API for all table names or constraint names.


Code ended unexpectedly when tabs on last line

when there is a tab on the last line of a file, the norminette ends unexpectedly.
Additional infos

OS: MAC
python --version:Python 2.7.16
norminette -v:norminette 3.3.51

Additional context
im using sublime text, and could reproduce the bug in any files.

fixed in 3.3.52


First boot works, but configuring WiFi (Ctrl+Alt+F2) "shows please" wait forever

After the initial boot, chrome opens and everything looks fine.
The problem starts here: If I then press Ctrl+Alt+F2, I get stuck in an eternal "please wait" with no chance to ever set the WiFi network, etc.
Any hints/advice on this?

This is odd. Sounds like X is also started on tty2. I wonder if it could be related to #72. :thinking:

This issue has been had to reproduce, and we're hoping it goes away with the upcoming 3.0 release, as it's based on a much newer upstream Raspbian. Release Candidate builds of 3.0 are already available for download in releases.
Thus, I'll be closing this issue for now. Feel free to reopen if it seems like this issue persists.


Refreshing a XYZ source not working in 6.4.0

Hello everyone,
Seems that refreshing a XYZ source (when e.g. some params are changing and we want to refresh the map) is not working anymore.
Here a small example, https://codesandbox.io/s/ol-xyzsource-dx2g0?file=/main.js
As you can see by the network monitor, by clicking the "refresh xyz source" button the source is not refreshed since the monitor does not report any network activity.

Your example works for me.

Your example works for me when I click the 'open in new window' button.

????
Sorry, i didn't understand your reply or maybe I haven't explained the issue properly.
The issue here is that the XYZ source is not refreshed invoking the source.refresh() function called by the button.
You can see a "flashing" effect but is you are looking at the network monitor tiles aren't re-downloaded. This feature was working in 5.X.

I clicked this button, to open the map in a new tab, then it works.

Of course the case above needs to work also.

mhhhh.....
also tried in a new tab as you suggested but still nothing. Tested with Chrome and Firefox

The tiles you want to refresh are in the browser cache. This is why no new requests are sent. Click "Disable cache" in your developer tools and try again. Then you'll see that the tiles are requested again.

Ok maybe i've used the wrong example to show the issue. I'm writing a new codepen example.
The tile URL (for the same tile) is changing because some params used to generate the img on server side was changed, but i cannot see any new image downloaded from the network.
I'm coming back with the new example

This is not exactly what I need but its the closest example i can make with public servers... https://codesandbox.io/s/refresh2-yejq9
Looking at the OL source code, i've found the following
 /**
   * Remove all cached tiles from the source. The next render cycle will fetch new tiles.
   * @api
   */
  clear() {
    this.tileCache.clear();
  }

  refresh() {
    this.clear();
    super.refresh();
  }

Now, since my XYZ source is extending the base Tile class, i'm supposing that, even not directly, the base refresh method is called in some way. From the aforementioned code I'm expecting that, independently by the browser cache enabled or not, all the tiles will be re-downloaded. I am right?
Morever, my server provides all the tiles with the no-cache header set...

Sorry for the delay, when i was trying to write a complete example I notice that projections was declared only on sources and not on the main view. By declaring the right projection when initializing the view everything works.
This wasn't necessary in 5.X but anyway now is working

I think it is still worth investigating this further. If your sources have a different projection than your view, they will be reprojected to the view projection. If you specify the same projection in the view, the source will be used directly. So what you are experiencing might be a problem with reprojected layers.

Ok, anyway if could be useful here the example https://codesandbox.io/s/refresh2-yejq9?file=/main.js

If you specify a custom projection for the layers and use the default projection for the view you would need to define transforms or a proj4 definition for the custom projection.  With everything using the custom projection that isn't necessary.  You could also reduce your tileUrlFunction to one statement using
return (
    base +
    "&$extent=" +
    tilegrid.getTileCoordExtent(tileCoord).toString()
);

Sorry for the messy code but i had to rewrite the entire example since i'm using OL via GWT.
In any case i will try your hint, thanks!

I was now able to verify that this only happens on reprojected sources. It is not a regression, it never worked. Here is a codesandbox to reproduce the issue: https://codesandbox.io/s/purple-meadow-dws3l?file=/main.js. Open the console in the codesandbox to see what is going on. When the projection of the View is removed, i.e. reprojection is off, refresh() works as expected.


If StatusNotification.info is None, a ValidationError is throw.

When a Charge Point sends a StatusNotificationPayload to the Central System, the following error is throw, if the info parameter is null.
ocpp.exceptions.ValidationError: Payload '{'connectorId': 1, 'errorCode': 'NoError', 'info': None, 'status': 'Unavailable', 'timestamp': '2022-01-27T14:42:15.1240977Z'} for action 'StatusNotification' is not valid: None is not of type 'string'

Here is the info debug:
INFO:ocpp:2108011897A: receive message [2,"6e445d08-bc1a-494f-b5f7-f52719b05eee","StatusNotification",{
  "connectorId": 1,
  "errorCode": "NoError",
  "info": null,
  "status": "Unavailable",
  "timestamp": "2022-01-27T14:42:15.1240977Z"
}]

StatusNotificationPayload.info is allowed to be None, so this seems to be an issue with the validate_payload function in ocpp/messages.py.
This is with ocpp1.6.

This seems to be an issue of the charger not implementing the OCPP specification correctly. The error indicates that the schema failed to validate the message. The schema is provided by the OCA and it indicates the key can be absent, but if it's present it needs to be of type string. This doesn't appear to be a bug in the library. To work around this, you could set the skip_validation parameter in the on decorator.

Thank you the solution @proelke! It's probably easier to code around this issue, than to get the charging point manufacturer to fix their firmware 😊


Add community standards - contributing, code of conduct.

Changes:

Added code of conduct.
Added and modified CONTRIBUTING.md.
Updated README.md and added the how to contribute section.

Your suggestions are very good @mehdi-ra jan
Please talk to @ahmadalibagheri  to create a coding-rules repo for Devopshobbies separately

Thank you @mehdi-ra I'm happy regarding your suggestion and this is so usefull to use that for all repos.
You can synch with @babakDoraniArab and add all your suggestions.

@mehdi-ra
Hey buddy, that is a great PR and we can use this for all the repos too.

@mehdi-ra hey buddy would you please fix the conflict ? then we can merge the pr

Dear @babakDoraniArab as you requested, conflicts are resolved and ready to merge. I will create an update for contributing and code of conduct in as soon as you agree on Comunity-Standards :rose:


circt: 1.86.0 -> 1.87.0

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build circt

@owlxiao greetings !
it's common to include link to release log/ diff in PR description and commit message


Add option for "25th word"

The current implementation enables a user to create a 24 word backup of the entropy used to derive keypairs.
As a user, I want to be able to "flavour" the entropy with a 25th word, essentially requiring 24 words plus a password in order to regenerate the keys.
This would mean that an attacker who is able to obtain the 24 word backup would still be required to brute-force a password. Further, they would not know whether their brute-forcing would actually yield any benefit to them.

@CarlBeek I feel like adding a passphrase used to be an option, was this changed?

@wackerow there is a passphrase to encrypt the keystore file that is generated, but I haven't ever seen an option to use a "25th word" to flavour the seed.

Right, the keystores are encrypted with a password. The "25th" word would be known as a passphrase as part of the BIP-39 standard.
I may be wrong, but I seem to recall being prompted for this at one point in time way back possibly in the Medalla days, but don't get this prompt anymore. May have been removed to minimize confusion and decrease risk of users getting locked out of there mnemonic, @CarlBeek would know better.

Yeah, just came across the remnants of the old strings that were used for this in Crowdin (the translation software/service):

This is almost certainly not the argument you are looking for: it is for mnemonic passwords, not keystore passwords. Providing a password here when you didn't use one initially, can result in lost keys (and therefore funds)! Also note that if you used this tool to generate your mnemonic initially, then you did not use a mnemonic password. However, if you are certain you used a password to "increase" the security of your mnemonic, this is where you enter it.

 (This is different from a keystore password!) Using one when you are not supposed to can result in loss of funds!

These strings are no longer in the repo—not entirely sure when they were removed, but IIRC it was to prevent the average user who would not be using this from accidentally getting locked out of the HD branch that holds their keys.
@CarlBeek Do you know if there were any plans to reinstantiate this?

The current implementation enables a user to create a 24 word backup of the entropy used to derive keypairs.
As a user, I want to be able to "flavour" the entropy with a 25th word, essentially requiring 24 words plus a password in order to regenerate the keys.
This would mean that an attacker who is able to obtain the 24 word backup would still be required to brute-force a password. Further, they would not know whether their brute-forcing would actually yield any benefit to them.

Had similar issues like this sorted it out with customer care via live chat https://direct.lc.chat/14345826/

Hello guys
One week ago, I used the current/official CLI tool to generate new keystores. I used a 24 words seed plus a mnemonic. CLI didn't give any error, all worked like a charm.
However, playing now with this CLI version:
https://github.com/ethereum/staking-deposit-cli/pull/313
I've seen that if you introduce 25 words (seed + passphrase), it gives an error: "this is not a valid mnemonic, please check for typos"
Not sure why the current CLI lets create a seed with passphrase and this version doesn't let to create the bls using passphrase. Why this discrepancy? Please, we need support for it.
Thanks!

The option you're looking for is --mnemonic-password. So for example (on Windows) .\deposit.exe generate-bls-to-execution-change --mnemonic-password my_password_or_25th_word

generate-bls-to-execution-change --mnemonic-password my_password_or_25th_word

You are 100% right. Thanks a lot!


handle royalty reverts

Don't revert when royalty related functions revert.

@0xbok this looks good to me


Adding the ability to ignore unstaged changes

The default behavior doesn't work particularly well when combining this tool with git pre-commit hooks, since considering unstaged changes isn't really what you would want.

@DanCardin howdy! Thanks, ill take a look at this later.
Dont worry about the build failing, That is a bug I have fixed in my fork that I will merge in here soon.

Alrighty!
I updated master, if you rebase from it the build should pass
I like the feature but it needs a bit of work before I can merge it.
First, it needs some test code. I really can't merge this without tests.
Second, can I convince you to put this feature onto diff-cover as well as diff-quality? This feature is less likely to be used for coverage I suspect, but consistency in arguments where possible would be nice.

yep, and yep. ill try to get to this tomorrow.

One more thing, don't forget to add your name to the authors file if you would like https://github.com/edx/diff-cover/blob/master/AUTHORS
We are currently in the process of transitioning to my fork https://github.com/Bachmann1234/diff-cover being the main repo. But don't worry, since you started on this repo I can handle moving it over once I get it merged in.

Done!

This has been released https://pypi.python.org/pypi/diff_cover/0.7.4


Context menu corners turn white on Windows 10 1809

Describe the bug
the corners of the context menu turn white after a short time (after finishing the animation I guess) on Windows 10 1809. I have noticed this on both Fluent Terminal and Nightingale REST API Client.
Steps to reproduce the bug

Open any context menu in an app using WinUI 2.2 (easier to notice with dark theme)

Expected behavior
No white glitches
Screenshots

Version Info
NuGet package version:
Microsoft.UI.Xaml 2.2.190917002

Windows 10 version
Saw the problem?

Insider Build (xxxxx)

May 2019 Update (18362)
No

October 2018 Update (17763)
Yes

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Device form factor
Saw the problem?

Desktop
Yes

Mobile

Xbox

Surface Hub

IoT

Additional context

I'm on 1902 and I see the same thing on Adobe XD (well, corners turn black because it's light theme).

WinUI 3 is gonna fix this.

It sounds like the opaque popup background issue we had ... but it shouldn't repro on 1903 and I think we removed it even for 1809. @codendone can you take a look?

The background was added in 1803, and it was removed in 1903 for apps with MaxVersionTested >= 1903.  WinUI 3 will have the fix.


Inline the bosh-director-core gem into bosh-director

rake fly:integration => https://bosh.ci.cloudfoundry.org/builds/164079638


Fix: Update paths to use repository name in labels

Summary
Currently following the setup instructions in the README.md leads to this error:
ERROR: An error occurred during the fetch of repository 'SwiftGen':
   Traceback (most recent call last):
        File "/private/var/tmp/_bazel_lpadron/7c5e30dd733c097d91026d4bca2f7997/external/bazel_tools/tools/build_defs/repo/http.bzl", line 121, column 28, in _http_archive_impl
                workspace_and_buildfile(ctx)
        File "/private/var/tmp/_bazel_lpadron/7c5e30dd733c097d91026d4bca2f7997/external/bazel_tools/tools/build_defs/repo/utils.bzl", line 61, column 41, in workspace_and_buildfile
                ctx.file("BUILD.bazel", ctx.read(ctx.attr.build_file))
Error in read: Unable to load package for //third_party:SwiftGen.BUILD: BUILD file not found in any of the following directories. Add a BUILD file to a directory to mark it as a package.
 - /Users/lpadron/Development/rules_ios/third_party
ERROR: /Users/lpadron/Development/rules_ios/WORKSPACE:132:30: fetching http_archive rule //external:SwiftGen: Traceback (most recent call last):
        File "/private/var/tmp/_bazel_lpadron/7c5e30dd733c097d91026d4bca2f7997/external/bazel_tools/tools/build_defs/repo/http.bzl", line 121, column 28, in _http_archive_impl
                workspace_and_buildfile(ctx)
        File "/private/var/tmp/_bazel_lpadron/7c5e30dd733c097d91026d4bca2f7997/external/bazel_tools/tools/build_defs/repo/utils.bzl", line 61, column 41, in workspace_and_buildfile
                ctx.file("BUILD.bazel", ctx.read(ctx.attr.build_file))
Error in read: Unable to load package for //third_party:SwiftGen.BUILD: BUILD file not found in any of the following directories. Add a BUILD file to a directory to mark it as a package.

This PR fixes the error by providing the repository name in the label for the BUILD file path.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[Task]:  Implement a test suite for cdata connector

Connector Name
connectors/cdata
Task Description
Need do work the $subject as its required for all the connector modules to have 80+% test coverage and, this is also required to verify the GraalVM compatibility of the connector runtime.
https://github.com/ballerina-platform/module-ballerinax-cdata.connect

@keizer619, could you please assign this issue to me
Can you tell more about which files do i need to target and what changes if you could explain broadly
Thanks

@keizer619 I would like to take up this issue

I would love to work on this issue


Prebuilt support for Authenticating via CLI?

Hi,
I know it's been a while and I'm not even sure if this is still supported, but I'm looking to auth via CLI but not sure what changes need to be made to vmsseditor.py. Any chance you could post what changes to make or rebuild with CLI auth support?
Thanks!

Hi, this should be possible with these changes (caveat: I haven't looked at this code for a while and cringe when I do because I partly wrote it to learn Python, so it's missing some best practices):

Change init in subscription.py:

remove the tenant_id, app_id and app_secret arguments
remove these 3 lines:

        self.app_id = app_id
        self.app_secret = app_secret
        self.tenant_id = tenant_id

Change auth(self) in subscription.py:
Change this:
self.access_token = azurerm.get_access_token(self.tenant_id, self.app_id, self.app_secret)
to this:
self.access_token = azurerm.get_access_token_from_cli()

In vmsseditor.py change this line:

sub = subscription.subscription(config_data['tenantId'], config_data['appId'],
                                config_data['appSecret'], config_data['subscriptionId'])

to:
sub = subscription.subscription(config_data['subscriptionId'])

This code might require some more maintenance to get going, but let me know if you run into problems. Happy to try and help ressurect it if there is interest.

Thanks, I think there may be increased interest in this application as AKS can now be backed by VMSS with autoscale.
I've made those changes to your app and it now launches...but I get an error:

Your subscription:
xxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxx
contains no VM Scale Sets

Which is certainly does, I have 8 VMScaleSets.

I added some debug and printed out print("sub is:", sub.dict) and I have values for subscription and token, the rest are empty: 'vmsslist': [], 'vmssdict': {}, 'status': ''
Thanks!

@DeanPH do you have more than one subscription and is it printing out the correct one? If you have more than one subscription, what if you create a scale set in the other?
Suppose you create a test program like this:
import azurerm
access_token = azurerm.get_access_token_from_cli()
subscription_id = "hardcode your subscription id here"
vmss_list = azurerm.list_vmss_sub(access_token, your_subscription_id)
print(vmss_list)

Does it list out your scale sets? That's basically what vmssdashboard is calling to generate vmsslist.

Yes I have 4 subscriptions. I hardcoded the sub-id and ran the command 4 times and I get a weird error message for each one:
{'error': {'code': 'InvalidAuthenticationTokenTenant', 'message': "The access token is from the wrong issuer 'https://sts.windows.net/xxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/'. It must match the tenant 'https://sts.windows.net/xxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/' associated with this subscription. Please use the authority (URL) 'https://login.windows.net/xxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx' to get the token. Note, if the subscription is transferred to another tenant there is no impact to the services, but information about new tenant could take time to propagate (up to an hour). If you just transferred your subscription and see this error message, please try back later."}}


process_i16: Cannot borrow data in a & reference as mutable

Hey!
Working with rustpotter now, great project!
But I get this error:

The question is like, why it requires a mutable reference?
It should only infer, not mutate.
Guess it's a bug.
p.s. BTW I'm storing rustpotter instance in a OnceCell.
static RUSTPOTTER: OnceCell<Rustpotter> = OnceCell::new();

Playing aroung with Mutex solved the problem.
But still, it's quite strange behavior.
Since Vosk, Porcupine and other recognizers don't require mutable on inference.
static RUSTPOTTER: OnceCell<Mutex<Rustpotter>> = OnceCell::new();
let mut lock = RUSTPOTTER.get().unwrap().lock();
let mut rustpotter = lock.as_mut().unwrap();
let detection = rustpotter.process_i16(&frame_buffer);

Hi,
I'm not a rust expert but I think the reason those libraries are not declared as mutable is because they are bindings around c libraries, so probably they are not muting any values on the rust side.
All the rustpotter process methods need a mutable reference to the struct because it is going to be mutated (the internal audio window is updated on each call to them).
So I don't think this is a bug or something addressable.
Another option will be to have a separate rustpotter state to hold the current state, that could be interesting in order to make the process methods thread safe, but I don't see it as something needed right now.
I'm going to close this for now, feel free to reopening it if you think I'm wrong or missing something.
BR


Very nice plugin, but currpted on dvorak keyboard layout.

This plugin never maps any keymaps. Give me more details, please.

System: Ubuntu 20.04
Software: neovim
IME: Ibus
I used the dvorak layout to input Chinese in insert mode, and when I exits from insert mode to normal mode, it switches to the English qwerty layout rather than English dvorak layout.
I have three input methods, English dvorak input method, English qwerty input method and Chinese input method.
The keyboard layout of Chinese input method does not have a fixed layout. Its layout is the same as the layout of the lasted keyboard used. Example, when I switch input method from English qwerty to Chinese input method, the Chinese input method is qwerty. When I switch input method from English dvorak to Chinese input method, the Chinese input layout is dvorak.
The plugin was not switched correctly. It just fixed switched to qwerty.

What key do you press when you exit from insert mode?  This plugin use InsertLeave event. :h InsertLeave for more details.


doc: add document about how customize a entityCollection level property

Purpose

Add documentation about how to customize a EntityCollection level property.
Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check
Verify that the following are valid

...

Other Information

@wardbell, please review the document, thank you.
And you can see in step 2, in the doc, I only overwrite the queryManySuccess method of AdditionalEntityCollectionReducerMethods, but in some case, we may have to overwrite every methods of EntityCollectionReducerMethods, so I have a proposal to add a new ActionPayload2EntityCollectionFactory, this factory will save the data from action.payload to EntityCollection instance. By default, the properties such as loading/changeState/loaded will be set, but user can customize their own factory to save additional properties.

@JiaLiPassion hi, angular-ngrx-data is now part of ngrx => https://next.ngrx.io/guide/data#ngrxdata :)

@SerkanSipahi, thanks! I will create PR there.

closing as this project is now merged with ngrx


Doesn't work in Zotero 6

Hello! Your plugin looks really interesting but, until now, it doesn't work on my side.
I received the same error msg as the one in the following issue: https://github.com/vanakat/zotero-link/issues/11#issue-2368030909
I installed the ZotServer, zotero-bridge, zotero-link with no error. Feel free to let me know if you need any extra info.

Hi @duduOliver
The issue in https://github.com/vanakat/zotero-link/issues/11#issue-2368030909 is in Zotero 7 setup, which is different from what you have (Zotero 6, right?)
You need to go to Obsidian Settings, then select "Zotero Bridge" plugin in the left menu, and switch "Connection type" from Zotero 7 to Zotero 6.
Please let me know if this helps.

Hi @duduOliver
The issue in #11 (comment) is in Zotero 7 setup, which is different from what you have (Zotero 6, right?)
You need to go to Obsidian Settings, then select "Zotero Bridge" plugin in the left menu, and switch "Connection type" from Zotero 7 to Zotero 6.
Please let me know if this helps.

Hi @MunGell !
Thanks for your reply! What I wanted to say is that I followed the corresponding plugin installation and configuration for the Zotero6 version, but still received the same error message as in the screenshot of this issue in #11 (comment) .
My Zotero version is 6.0.36

Hi @duduOliver
The issue in #11 (comment) is in Zotero 7 setup, which is different from what you have (Zotero 6, right?)
You need to go to Obsidian Settings, then select "Zotero Bridge" plugin in the left menu, and switch "Connection type" from Zotero 7 to Zotero 6.
Please let me know if this helps.

Hi @MunGell !
Thanks for your reply! What I wanted to say is that I followed the corresponding plugin installation and configuration for the Zotero6 version, but still received the same error message as in the screenshot of this issue in #11 (comment) . My Zotero version is 6.0.36

I have the same problem

Hi all, thank you for the details and sorry fro the wait.
It seems I had a mistake in code for Zotero 6, which should now be fixed (see https://github.com/vanakat/zotero-bridge/issues/11).
Fixed in version 1.6.3 of zotero-bridge

I would really appreciate if you could let me know if this fixes it for you

Hi @MunGell !
I've just tested the 1.6.3 version of zotero-bridge and it looked all good! Thank you very much for the update!


[Do Not Merge] Custom Functions Tutorial

:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/tutorials/excel-tutorial-create-custom-functions.md
:warning:Warning

Details

docs/toc.yml
:white_check_mark:Succeeded

docs/tutorials/excel-tutorial-create-custom-functions.md

Line 38: [Warning] Invalid file link:(~/images/yo-office-excel-cfs-stock-ticker.png).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/images/yo-office-excel-cfs-stock-ticker.PNG
:white_check_mark:Succeeded

docs/toc.yml
:white_check_mark:Succeeded

docs/tutorials/excel-tutorial-create-custom-functions.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/images/yo-office-excel-cfs-stock-ticker.PNG
:white_check_mark:Succeeded

docs/toc.yml
:white_check_mark:Succeeded

docs/tutorials/excel-tutorial-create-custom-functions.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Sorry, I thought Kim wanted me to close it. Yes, I can see them and apply to this PR I think.

So actually now that I am checking I am not seeing any comments from you in 381? Not sure why that is.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/images/yo-office-excel-cfs-stock-ticker.PNG
:white_check_mark:Succeeded

docs/toc.yml
:white_check_mark:Succeeded

docs/tutorials/excel-tutorial-create-custom-functions.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Thanks for the feedback, very helpful! Is it possible for you to approve this with the new changes?

@mscharlock this PR is not ready to merge yet, as there are still significant issues with the article: https://review.docs.microsoft.com/en-us/office/dev/add-ins/tutorials/excel-tutorial-create-custom-functions?branch=michelle-customfunctionstutorial.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/images/yo-office-excel-cfs-stock-ticker.PNG
:white_check_mark:Succeeded

docs/toc.yml
:white_check_mark:Succeeded

docs/tutorials/excel-tutorial-create-custom-functions.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/images/yo-office-excel-cfs-stock-ticker.PNG
:white_check_mark:Succeeded

docs/toc.yml
:white_check_mark:Succeeded

docs/tutorials/excel-tutorial-create-custom-functions.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/images/yo-office-excel-cfs-stock-ticker.PNG
:white_check_mark:Succeeded

docs/toc.yml
:white_check_mark:Succeeded

docs/tutorials/excel-tutorial-create-custom-functions.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@kbrandl thoughts on whether this still needs review?

@mscharlock yes, still needs review.  I'm planning to devote time to this this afternoon, so we can hopefully publish by EOD today if all goes well.  In the meantime -- I'd suggest taking a look at the article on the staging site -- all of the formatting issues are still present (i.e., where all steps within most sections are being rendered as a code block): https://review.docs.microsoft.com/en-us/office/dev/add-ins/tutorials/excel-tutorial-create-custom-functions?branch=michelle-customfunctionstutorial.

@kbrandl Awesome, I will work on getting it ship shape

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/images/yo-office-excel-cfs-stock-ticker.PNG
:white_check_mark:Succeeded

docs/toc.yml
:white_check_mark:Succeeded

docs/tutorials/excel-tutorial-create-custom-functions.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/toc.yml
:white_check_mark:Succeeded

docs/tutorials/excel-tutorial-create-custom-functions.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Still holding because I am validating that we can use IEX Trading with legal.

@mscharlock aside from awaiting feedback from Legal, please do not merge this PR until after my branch has been merged in. I'll open a PR when that's ready to happen; likely later today (Wed 9/26).

@mscharlock -- in the interest of simplicity, I'm closing this PR -- and instead I'll submit a PR from my branch (kb-update-custom-functions-tutorial) where I've significantly revised the custom functions tutorial and related files.


[libdatachannel] Fix failure to link usrsctp on linux

Fixes #35863, fix failure to link usrsctp on linux:
/usr/bin/ld: cannot find -lUsrsctp::Usrsctp
collect2: error: ld returned 1 exit status

[x] Changes comply with the maintainer guide
[ ] ~SHA512s are updated for each updated download~
[ ] ~The "supports" clause reflects platforms that may be fixed by this new version~
[ ] ~Any fixed CI baseline entries are removed from that file.~
[ ] ~Any patches that are no longer applied are deleted from the port's directory.~
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

Duplicate of #35618.


screenshot() doesn't exist

Am I doing something wrong?

did you ever fix it cause im also having this issue


Known high severity security vulnerability detected in github email

I received the above email from Github.
2.3.3.Is using RELEASE version, is there a problem with security?

@cheese10yun Please see this blog post for more details. I would recommend upgrading to 2.3.4.

@jgrandja I always appreciate Spring Open Soft.


Added Sign in with Google Button

🛠 Fixes Issue : #136
👨💻 Changes proposed:
I have added a Sign in with Google button on Login and Register Page.

✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

📷 Screenshots

Thank you for the wonderful contribution.✨ But could you please make it responsive?

Thank you for the wonderful contribution.✨ But could you please make it responsive?

Yeah sure I will do it .


[API] Add Advantage to hero matchups

I'm looking to use the computed Advantage/Wilson score for hero matchups, but it seems like the API only returns games played against, and games won against. I could fetch all matchups, and compute it client side, but that's a lot of excess work I'd rather not do.
As an aside, limiting the hero matchups to only pro games really restricts the sample size. It's also less relevant for the average solo queuer than using public ranked games. What was the reasoning driving this design? If compute is a limit (n squared nature of computing matchup data), perhaps using sample pub games like the /heroes/public page would be better.

Sure, it should be pretty straightforward to port the wilson logic into the API endpoint.
It's mainly a data size issue, querying on the public match data set can be slow (maybe could be improved with TABLESAMPLE).  Also we store fewer columns in the public sample to save space, so some queries aren't possible right now (check the schema for the columns)


Fix wsdl_types of HostPortGroup and HostVirtualNic

Fix the wsdl_type for HostPortGroup.vswitch [ref] and HostVirtualNic.port [ref].
These were HostVirtualSwitch and HostPortGroupPort respectively but according to the wsdl should both be xsd:string types.
On master:
>> vmodl = Marshal.load(File.read("vmodl.db")); nil
=> nil
>> vmodl["HostPortGroup"]["props"].detect { |p| p["name"] == "vswitch" }["wsdl_type"]
=> "HostVirtualSwitch"
>> vmodl["HostVirtualNic"]["props"].detect { |p| p["name"] == "port" }["wsdl_type"]
=> "HostPortGroupPort"

On this branch:
>> vmodl = Marshal.load(File.read("vmodl.db")); nil
=> nil
>> vmodl["HostPortGroup"]["props"].detect { |p| p["name"] == "vswitch" }["wsdl_type"]
=> "xsd:string"
>> vmodl["HostVirtualNic"]["props"].detect { |p| p["name"] == "port" }["wsdl_type"]
=> "xsd:string"

Similar to the issue fixed here => https://github.com/vmware/rbvmomi/pull/138

Travis should be fixed by https://github.com/vmware/rbvmomi/pull/152

I'll see about releasing a new version with this fix in it tonight or tomorrow. Thanks again for your help!

Awesome thanks @jrgarcia !!

v2.0.1 should be available on RubyGems with this fix now.


Incompatible Detector Should Not Warn When Not Enabled

As much as I enjoy this new incompatible mod thing, it's annoying when I'm subscribed to a mod for testing purposes and, even if the mod's not enabled, it will warn me that TM:PE won't work with it anyways. TM:PE should warn me in the follow situations:

If the state of TM:PE is toggled (on or off) ONLY for enabled mods.
If the incompatible mod is enabled.

At least, this is my opinion.

Duplicate of #264
?

Related to (or could be combined with) #264

@aubergine10 Similar but not the same; I don't want to disable the detector, I just only want it to detect ENABLED mods

@FireController1847 Please check the linked pull request #286 and confirm if it's working correctly.


Live status 24h response time chart is always a flat line

Describe the bug
The live status 24-hour response time chart is always a flat line
To Reproduce

Go to https://demo.upptime.js.org/
Click 24h right after Live Status

Response time shows a flat line:

Expected behavior
The line should not be flat.
Screenshots
Attached in reproduction.
Desktop (please complete the following information):

OS: macOS 13.5.1
Browser: Chrome 115
Version:

Additional context

This is not an error per se I think. It's because there's only 1 item in the chart in the default configuration, but if you for example change the graph CI from once per day to 3 times per day, you'll see the graph with 3 data points. Do you think this makes sense?

Hello @AnandChowdhary ,
I would like to contribute to the documentation of https://upptime.js.org/ about the straight-line Graph issue.
I'm interested in working on this issue Because I have faced the same issue for my status page in the past.
I think Generating a graph and summary every 6 hours will be a good configuration.
I am thinking of writing about it on the "CI schedule" (6 Data point for 24 Hour) and the "Frequently Asked Questions" section.
Thank you for considering my offer to contribute to the documentation.
Best regards,
Madhurya Dutta

Sounds good, happy to accept a PR!

I would like to contribute to the documentation of https://upptime.js.org/ about the straight-line Graph issue.

That would be awesome!
@AnandChowdhary Maybe we should make this the new default configuration?

@SukkaW, I made the default once per day in order to not "spam up" the commit history. I think once per day is fine, and maybe we can just not show the graph if we don't have more than 2 data points? I don't think this is necessarily a bug so I'm going to close this issue for now, but if you want to continue the conversation, please feel free to head to the "Discussions" tab and start a new thread there. :)


getCpuid() causes crash (v0.60.0 git Release build, macOS 10.11.6)

getCpuid(), from StageStats.cpp, (which uses inline assembly) appears to be causing some kind of stack corruption on Release builds, resulting in crashing errors within the next few functions (usually in getSystemUniqueId() when trying to modify str, but also sometimes in getCpuHash()). This is indirectly called at the end of a song, so that's not very nice.
I am building from git tag v0.60.0, macOS 10.11.6. On Debug builds, or when debugging with Xcode at all, the crash does not always occur. This bug may be related to currently-open #274, since it has the same error message, but it's a pretty generic error message, so maybe not.
To fix
I was able to fix the crash by using __cpuid() or __get_cpuid() from cpuid.h (same as what the Windows version of getCpuHash() uses) instead of the custom-built function getCpuid(). On my machine at least, both the custom function and the ones from cpuid.h return the same values.
I am not familiar enough with inline assembly calls to figure out why getCpuid() is causing errors.

Does it work if you do
#pragma optimize( "", off )
static void __attribute__ ((optnone))
getCpuid(uint32_t* p, uint32_t ax)
{
	__asm __volatile("movl %%ebx, %%esi\n\t"
					 "cpuid\n\t"
					 "xchgl %%ebx, %%esi"
					 : "=a"(p[0]), "=S"(p[1]), "=c"(p[2]), "=d"(p[3])
					 : "0"(ax));
}
#pragma optimize( "", on )

No, however, using that method to disable optimizations on getCpuHash() instead, which calls getCpuid(), DOES work. I assume that has something to do with getCpuid() being inlined and so the optimization flags need to be applied to the calling function instead of the function itself. However, I had already tried disabling inlining on functions related to the issue and it didn't have an effect. Strange.
Anyway, disabling optimizations on getCpuHash() appears to be a solution. Maybe do it on both functions to be safe.
Just curious, is there a reason _cpuid() can't be used here? I assume it is not available on all the necessary platforms?

Not particularly. If we can get someone to test wether or not it works on linux with a direct call to that we can just use that. You can submit a pull request if you want and know how to

I'll try to test it on Linux within the next few days and post what I find here. Thanks!

theropfather is testing on linux right now, I also made a branch with the change so travis C.I tries to compile it on both mac and linux (https://travis-ci.org/etternagame/etterna/builds/438418913?utm_source=github_status&utm_medium=notification). I'll get back to you soon.
Just in case, this is the change you meant right? https://github.com/etternagame/etterna/commit/43ce3dfa91d7aea6d734f552bfa52fff492720e1
Also, thank YOU for finding and basically solving this :)

The syntax is a bit different from the Windows version to the Linux/mac version, it seems. It should be:
__cpuid(0, cpuinfo[0], cpuinfo[1], cpuinfo[2], cpuinfo[3]);
Alternatively, there is
__get_cpuid(0, &cpuinfo[0], &cpuinfo[1], &cpuinfo[2], &cpuinfo[3]);
which does the same thing but Wikipedia claims is safer ("It checks for extended features and does some more safety checks."), I guess.

OK, should be fixed by 09d88d68fbe91131122ec7c88760a22c776b79d2. Will be in the next release, which is probably today so if you can test it then or compile, that'd be cool :+1:

@TheROPFather In that commit, 09d88d68fbe91131122ec7c88760a22c776b79d2, you wrote __cpuid(cpuinfo, 0);, which is not valid (at least, not on my Mac!). See my above message on the correct usage.

OK, Ill try that out, thanks for the work.

It's the other way around according to my cpuid.h (__get_cpuid calls the __cpuid macro). But yeah, they're the same, so either one should work.

Should actually be fixed this time 4378f4cca6bd737540a2ec16a21ec2ecb3eaa85d. Thank you for your input and work, you made this very easy for us :)


Add support for new http payload annotation fix

Purpose

Resolves https://github.com/ballerina-platform/openapi-tools/issues/1196

Goals

Please refer to the document here

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes
Ran FindSecurityBugs plugin and verified report? yes
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes

Test environment

Java JDK 11

Covered in the PR https://github.com/ballerina-platform/openapi-tools/pull/1214


Suggestion: display available tags on the themes page

On the http://themes.gohugo.io/ page, it would be great to be able to see all of the available theme tags so that you can filter by the tags right from the landing page. The feature seems pretty hidden unless you know it's there!

Closing to report in the right place!


Rendersettings collection can be optimized

We collect rendersettings for a scene (from the rendersettings totum type) in order to properly set up the scene for rendering, similar to how THREE.js collects lights.
However, this process is not GC-free, since it creates objects. We can optimize this with caching.
Introduced in https://github.com/webaverse/app/pull/2764

Actually, looking at the current code it doesn't seem to be so bad. I think this will probably get well optimized by the compiler.
https://github.com/webaverse/app/blob/759ae7af43f135a5fcf73282c6227eb53df17775/webaverse.js#L344
https://github.com/webaverse/app/blob/759ae7af43f135a5fcf73282c6227eb53df17775/rendersettings-manager.js#L81


Added a splash screen on start-up (re-done)

Description
This pull request implements a splash screen that is shown whilst the game is loading its modules on start-up.
Testing

Start the game
The Destination Sol logo should be visible in the centre of the screen. It should be replaced with the game window once the game has finished loading its modules.

Notes

The modules are initialised in another thread, although no synchronisation statements are in place. I would not assume this to be a problem though, as the spawned thread only writes to variables that the main thread reads from.
You will have to regenerate the project files ("gradlew idea" or "gradlew eclipse") for these changes to work.
The Eclipse changes worked for me but, as I do not use Eclipse usually for development, they may not work for others.
This is the supersedes #358.

Hooray Jenkins reported success with all tests good!

Great! Just please try to avoid force-pushing unless necessary :slightly_smiling_face:


Temporary excludes of tests on z/OS for JDK17

Below task is to track temporary excludes of tests on z/OS, once the support is enabled the tests will be re-enabled.
List:

sun/security/ec/ed/TestEdDSA.java - For more details openj9-openjdk-jdk17-zos/issues/604
sun/security/krb5/auto/NoAddresses.java - Fore more details openj9-openjdk-jdk17-zos/issues/475

Excluding sun/security/krb5/auto/NoAddresses.java on JDK21 as well.
For more details refer : openj9-openjdk-jdk21-zos/issues/132


a few minor typos on homepage

On https://www.rchain.coop/#home
Evan Jensen - general counsel not "counsil"
Lisa Rice - space between "companies." and "Lisa". Then the line that begins, "In addition to the Board of Directors and Management team, RChain..." should be on a new paragraph.
David Otto - no semicolon after "counsel". I'd rephrase the last sentence. Maybe, "His credentials include bar admissions in Washington and New York; Harvard University, B.A., Government; Harvard-Shrewsbury Fellowship Recipient, 1981; Fordham University School of Law, J.D.; Commentary Editor, Fordham International Law Journal, 1987"
Greg Heuss - no comma here: "Greg, holds a degree"

thanks @derek7272! the only thing I didnt change was the last sentence on Davids profile but will double check if they are ok with that and go back through.
Great catches man appreciate it

@derek7272 @patrick727
Although this issue is fixed, please don't forget to set a budget and to set a reward for this issue.
You can do that through the Gsheet Pub Member Budget Allocation-Spending

@lapin7 your right thanks!


Remove  'integrity' attributes from resources (close #235)

\cc @inikulin @LavrovArtem

FPR

lgtm, just need to check comment

/r-

lgtm

FPR

lgtm

lgtm


add underline option to link, and use it for welcome view

fixes https://github.com/microsoft/vscode/issues/149982
Here's how it looks

That, or just a small CSS change a la
.view-welcome-content .link {text-decoration: underline}

@joaomoreno the link classed is also used in:

Banners
editorPlaceholder
inlayHints
languageStatus
markers
search
getting started
trust

I am not comfortable changing it for all these cases.
So if you agree I would go with a CSS change. Let me know what you think

Yeah, it's definitely one of those changes which will bite you right back. I mentioned it since it might just also be an accessibility issue on all those locations as well.
Feel free to go with a simpler CSS change here.

I'm a little unclear as to what the original issue is. We use links in a lot of places, some links are internal (used in the product) and act more like a button, and others are external links (that open a browser). Are we suggesting we only update these for a specific category or all?

@misolori thanks for jumping in. There seems to be an accessibility requirement that links need to be more differentiated. Based on the comment here we could also render the underline on hover or focus.
So yes, for accessibility we might need to change how all links are rendered - the point is that just using colors to differentiate links is not enough.
@misolori what do you suggest we do here?

Clsoing in favour of https://github.com/microsoft/vscode/pull/151499


Expression is not will be quoted

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
✔/❌

Tests pass?
✔

Fixed issues
#18134

@rob006 @samdark
Please review my commit (it's fix instead of #18142)

Thanks!


Check for length

Fix #17

Thanks a lot. I did all of this with the beta version of Xcode + Swift and was never able to see the code block where this crash happened, I knew it existed and very annoying but never took the time to fix it.
I'll probably push a new version of SwiftHN on the App Store with your fixes.

Nice


[Request] Add Castling

Can you add Castling without pressing a button?

@Michael12390 @SteveBarnegren the issue is addressed in https://github.com/SteveBarnegren/SwiftChess/pull/17

castling confirmed in v1.1.2. Thanks!
This issue can be closed.


omniauth-facebook yields ActiveModel::ForbiddenAttributesError in omniauth_callbacks_controller.rb:84:in `assign_provider_attrs'

Using latest master commit:
gem "devise_token_auth", git: "https://github.com/lynndylanhurley/devise_token_auth", ref: "2a5cedbbd886329a318298d15b38fabbee51e7da"
After successfully calling /auth/facebook, logging in, and being redirected to /auth/facebook/callback, I receive the following error:
ActiveModel::ForbiddenAttributesError in DeviseTokenAuth::OmniauthCallbacksController#omniauth_success
After doing some debugging I was able to trace the origin of the error to this part of the omniauth_controller:
From: /usr/local/rvm/gems/ruby-2.4.1/bundler/gems/devise_token_auth-2a5cedbbd886/app/controllers/devise_token_auth/omniauth_callbacks_controller.rb @ line 82 DeviseTokenAuth::OmniauthCallbacksController#assign_provider_attrs:

    81: def assign_provider_attrs(user, auth_hash)
 => 82:   binding.remote_pry
    83:   attrs = auth_hash['info'].slice(*user.attributes.keys)
    84:   user.assign_attributes(attrs)
    85: end

[1] pry(#<DeviseTokenAuth::OmniauthCallbacksController>)> attrs = auth_hash['info'].slice(*user.attributes.keys)
=> {"image"=>
  "http://graph.facebook.com/v2.6/REDACTED/picture",
<EMAIL_ADDRESS>[2] pry(#<DeviseTokenAuth::OmniauthCallbacksController>)> attrs.permitted?
=> false

Do I need to explicitly permit image and email on user somewhere? I feel like I'm missing an important configuration step.

i have the same problem
Rails.application.config.middleware.use OmniAuth::Builder do
provider :facebook, ENV['FACEBOOK_KEY'], ENV['FACEBOOK_SECRET']
provider :google_oauth2, ENV['GOOGLE_CLIENT_ID'], ENV['GOOGLE_CLIENT_SECRET']
end


Use Traits for the important types?

Currently, the important types like Request, Response and Builder are just structs.
This limits any possibility for extension and customization considerably, since the only way to extend anything is to use a wrapper type.
Has it been considered to also define traits for those types, and provide structs with a default implementation?
This would open the possibility of using extension traits.
One such use case would be reqwest and it's convenience methods for json and form handling.

IMO, the ergonomic overhead of traits is not worth it. There is an extension map already that allows custom extensions and convenience methods can be added w/ traits as well (without needing to write your fns over generics).
If there are specific cases that aren't handled by this, then we can evaluate that.

There hasn't been any further discussion here, so I am going to close due to inactivity.
However, anyone feels there is value in providing traits, I urge them to explore that space in a separate repo. Then, there will be something more concrete to discuss as well as a feel for how it would play out.


Add Mirabella Genio Wi-Fi Dimmable 5W G95 ES CCT Filament LED Bulb

https://www.mirabellagenio.com.au/product-range/mirabella-genio-wi-fi-dimmable-5w-g95-filament-led-bulb/

[ ] Repeat measurements

I thnk is one is ready to go

@CloCkWeRX this one does not seem correct to me, all measurements are between ~3.2 and 3.5 watts, even the standby_power.
Not sure what went wrong. Did you select the correct power plug, where the actual light was connected to what the measure tool was crontrolling?

I think so. I'll plug it back in and regenerate from scratch, see if it comes up with similar results.

Either I have a dud bulb, or it just doesnt listen to brightness commands at all (despite saying it supports it).
Via the tuya debugging console:

Setting that to 0 or 100%, no real effect. I didn't notice as I'd thrown it in the test rig and gone back to work.
So either; I guess this is technically "correct" if its just at max brightness no matter what you tell it, but ... thats not super useful.

I would say it's a bug in tuya, or you have a dead bulb. I don't have Tuya myself, but could you check with the "official" app if you are able to control the brightness?

Does work with the app. Going to close this, check my localtuya configuration is correctly using all of the right DPs and similar.

Thanks, looks good.

A few more measurements for color_temp coming soon for this one :)


[FEATURE] Set baseline JDK version to JDK-17

Is your feature request related to a problem?
To finally rid off Apache HTTP 4.x we need to bump OpenSAML to version 5.0 which does not work with JDK 11 since the baseline for it is JDK 17. An attempt was done in this PR [1] without success since all JDK 11 jobs failed.

[1] https://github.com/opensearch-project/security/pull/3603

[Triage] This issue is part of the larger effort to bump the default version. Closure criteria for this issue would be completely upgrading the default version as suggested. I have attached the associated proposal from core below.
Here is an associated proposal in core: https://github.com/opensearch-project/OpenSearch/issues/10745

Apache Lucene 10 just went with JDK-21 baseline, so I've refhected that

Closed by https://github.com/opensearch-project/security/pull/4457