Maintenance: Sharding and parallelizing RSpec tests in CI

This started as experimental, but going to ship it now 🚢
This PR cuts total build time to ~4min!  The only downside was that the way the CoverageChecker worked each shard would fail, because none of the partial test runs reach 100% coverage on the expected files.  So I updated this to upload the coverage artifacts, and then added another step to merge them and run the coverage check.
This ran into a few issues:

The download action didn't support multiple files, but the v2-preview does.  That has a bug with not properly unzipping artifacts though, so we work around that in here, with comments to the upstream issue which should be resolved soon.
Unrelated: there were some severe latency spikes with cached folders for Ruby gems.  I commented upstream and it hasn't come up again this afternoon.
Unrelated: there's an incident now impacting node download servers, so this works around and adds comments on that.

EDIT2: Verifying code coverage check works, link:

EDIT3: example:

selfie


chore: require at lest node 14 and configure Github action accordingly

Node 12 is not maintained anymore. (Even if node 18 is not yet a LTS, I configure the test matrix with it to be future proof)

Good PR though I feel it's a bit too early to drop support for Node 12. We've just dropped support for 12 major Node versions in 6 months. See also metalsmith README.md. But definitely to be merged before 2023/ MS 3.0

Fixed in 190e0116733c699aa6ef2d4e43a101882c9e0248


FIX: typo that made browser example invalid

When you load the required scripts, eg:
<script<EMAIL_ADDRESS><script src="https://unpkg.com/markdown-it-anchor/dist/markdownItAnchor.umd.js"></script>
<script src="https://unpkg.com/markdown-it-toc-done-right/dist/markdownItTocDoneRight.umd.js"></script>

The markdownItAnchor and markdownItTocDoneRight are defined as window.markdownItAnchor and window.markdownItTocDoneRight, with the i of markdownit uppercased.
This typo makes the current code fail, but this PR fixes it accordingly.

Pull Request Test Coverage Report for Build 86

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.99%

Totals

Change from base Build 85:
0.0%

Covered Lines:
53

Relevant Lines:
53

💛  - Coveralls


feat(FN-980): list previous reports backend

Introduction
We need to allow users to see a list of previously submitted reports.
Resolution

Endpoint in DTFS Central API to get DB collection utilisation-reports
Endpoint in Portal API which calls above endpoint and maps data to format required in the frontend
In Portal call above endpoint
Started writing some tests but would be easier with the endpoint to create documents in this collection

To Do

Finish off tests
Add some validation for bank ID

Codecov Report

:exclamation: No coverage uploaded for pull request base (main-stbr@7bdec5e). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             main-stbr    #2153   +/-   ##
============================================
  Coverage             ?   15.24%
============================================
  Files                ?      843
  Lines                ?    20190
  Branches             ?     3128
============================================
  Hits                 ?     3078
  Misses               ?    14977
  Partials             ?     2135

Flag
Coverage Δ

ui-test
91.77% <0.00%> (?)

unit-test
2.80% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


No whl file that works with Python 3.13

We use github action to test our code.
https://github.com/SpiNNakerManchester/sPyNNaker
We install Morphio via https://github.com/NeuralEnsemble/PyNN
When testing with python 3.12 (or lower)
It reports
Downloading morphio-3.3.9-cp312-cp312-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl.metadata (3.5 kB)
and all works
When testing with python 3.13 (yes I know this is still in pre release)
it reports
Downloading morphio-3.3.9.tar.gz (600 kB)
And then fails to build.
Full error stack available if requested.

Hello,
Sorry about the slow reply; we'll be turning on Python 3.13 when it's officially released.
Unfortunately, we don't have the time to set it up at the moment.

Thank you for the new release!
We are now able to install with Python 3.13
OK to close.


Goroutine Leak monitoring request

I am experimenting with the codebase and I noticed goroutine leak regarding a goroutine quic-go http3/client.go monitoring the request after it was hijacked.
//`http3/client.go
func (c *client) RoundTrip(req *http.Request) (*http.Response, error) {
...
	// Request Cancellation:
	// This go routine keeps running even after RoundTrip() returns.
	// It is shut down when the application is done processing the body.
	reqDone := make(chan struct{})
	go func() {
		select {
		case <-req.Context().Done():
			str.CancelWrite(quic.StreamErrorCode(errorRequestCanceled))
			str.CancelRead(quic.StreamErrorCode(errorRequestCanceled))
		case <-reqDone:
		}
	}()
...
}

I got around this by making the context sent to Dial canceled-able and cleaning it up.

This should have been fixed in 00e56692d33eb9508a4ec1cf2c9f0943250cbfad.


Correct spelling of "cancelled" in events and docstrings

I realize it seems frivolous, but it's rather difficult to intentionally misspell things while coding.
Previous events and their respective methods still exist (on_canceled) for backwards compatibilty

Thanks for the PR, however, for consistency we typically use american english for spelling. So  the current usage is consistent with that. Also, this would not be backward compat anyway, because if you're listening to on_canceled events, you will stop getting them with this change.

That's a very interesting discovery for me as I am from the US.  I had to look it up because I've always spelled it as "cancelled".  Sorry for jumping the gun on that one and forgetting about the extra event trigger.

No worries :)


redlib: 0.35.1 -> 0.35.1-unstable-2024-09-22

Description of changes
https://github.com/redlib-org/redlib/issues/229

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 343649 run on x86_64-linux 1

1 package built:

redlib


feat: Sync with the latest protobuf definitions [DEV-1911]

Test buf.build generated ts-proto package

@DaevMithran @filipdjokic this seems to be a duplicate PR for https://github.com/cheqd/sdk/pull/98
Are they both valid PRs, or is the above the most recent version?
Can we close this one?

@Tweeddalex Yea this PR can be closed, this was used for testing the ts-proto


[bug] App icons are blurry and app name has weird hash inside parenthesis for AppImages only.

Describe the bug
The app icons are blurry in window view and in the dock for .AppImage only. The icon is crisp on the applications section though.
Dock:

Window viewer:

Applications:

App name has some kind of  hash:

Reproduction
https://github.com/niraj-khatiwada/tauri-nextjs
Expected behavior

The app icons must be crisp on all packaging.
The app name must be exact what it has been specified in tauri.conf.json

Full tauri info output
https://github.com/niraj-khatiwada/tauri-nextjs

Stack trace
No response
Additional context
No response

I can confirm that on Ubuntu 22.04. Pinned application icon is crisp, but the icon of the running AppImage is blurry. I created the Icon with tauri icon from a 1024x1024 px PNG file:

Depicted software can be downloaded here for reproduction: https://gitlab.com/planting-assistant/planting-assistant
Thank you for this awesome project, it was such a pleasure and easy to get started compared to electron. Basically just dropped it into an existing react project. 🙏


Revamp testing suite with new converted file from echopype 0.7.1

[ ] potentially use fixtures where possible
[ ] ensure testing with raw files, nc, zarr files
[ ] make sure only small testing files are in github

Do we still want to test on raw and zarr files? I was under the impression we were going to only work with .nc files.

This issue should be addressed in the same PR that addresses #107.

Here is a link to a zip file with a more recently converted example from 2019 Survey. It also has a bottom if needed. It is a whole transect but it can be cut into pieces/and possibly further subsampled if needed. I am assuming you want to test with an example which already has depth and regular grid incorporated? But could provide also some more raw files in .zarr format which have not been yet combined.

So the functions should be tested on an xarray (which may have come from .zarr or .nc), and for simplicity we can make the reading from .nc. I think the only difference that can come from the different formats is the way they are chunked, and whether they are loaded into RAM or not. I assume if they are not the regionmask function will invoke it? We have converted .zarr files handy, and I think opening them with xarray and converting them to .nc will be the same as converting them from scratch.

Do we still want to test on raw and zarr files? I was under the impression we were going to only work with .nc files.

So the functions should be tested on an xarray (which may have come from .zarr or .nc), and for simplicity we can make the reading from .nc. I think the only difference that can come from the different formats is the way they are chunked, and whether they are loaded into RAM or not. I assume if they are not the regionmask function will invoke it? We have converted .zarr files handy, and I think opening them with xarray and converting them to .nc will be the same as converting them from scratch.


We should add option to export HDFS data to local system

It would be useful from a usability  standpoint to add an option to export HDFS data to the local file system by right-clicking on the HDFS directory to ADS notebooks while connected to a SQL big data cluster.

You can save individual files locally already using the Save action :

Is there a specific case you're looking at that isn't covered by this already?


ImportError for graph_util from tensorflow.python.framework

Importing graph_util from tensorflow.python.framework fails with an ImportError.
I discovered this while I was trying to go through the TensorFlow for Poets Codelab, an the the re-training failed.
I can reproduce the same error in my Python shell. I am able to verify that TensorFlow is installed correctly by importing tensorflow, tensor_shape from tensorflow.python.framework, and gfile from tensorflow.python.platform (as in the retraining script); but trying to import graph_util results in the same ImportError:
>>> import tensorflow
# Success
>>> from tensorflow.python.framework import tensor_shape
# Success
>>> from tensorflow.python.platform import gfile
# Success
>>> from tensorflow.python.framework import graph_util
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: cannot import name graph_util

I have also posted this as a question on Stack Overflow, and haven't received any answers so far. I am not sure if this is a bug or a configuration problem etc. Feels like a bug, since I can import tensor_shape from tensorflow.python.framework no problem.
Environment info
Operating System: OS X El Capitan (v10.11.5)
Python: v2.7.11 via Homebrew
TensorFlow 0.9.0 installed from binary pip package for Mac OS X, CPU only, Python 2.7 (TF_BINARY_URL=https://storage.googleapis.com/tensorflow/mac/tensorflow-0.9.0-py2-none-any.whl).
Steps to reproduce
In Python shell:
>>> from tensorflow.python.framework import graph_util
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: cannot import name graph_util

What have I tried?

Looked to see if the file graph_util is there inside tensorflow/python/framework. It is.
Looked to see if the current source code I am examining has undergone any changes since v0.9.0 that would fix this issue that appears in the release that I am using. It doesn't appear so to me.

I'm having the same problem and can't seem to find a solution with the master branch.
While this is no real solution for the problem itself you could try pulling the r0.9 version from git.
This seems to work for me at the very least.

Assigning @danmane since he is on sync rotation next week to see the patch through.

I suspect the patch went through, though don't know which commit fixed this :(

The issue persists.

Ah, graph_util.py was moved from python/client to python/framework after r0.9.  You should either check out the code from the r0.9 branch, or use the nightly PIPs linked from github.com/tensorflow/tensorflow to get access to more recent installs that match the latest source code in master.

Solved my problem by checking out the r0.9 branch.


mraa's GPIO to work on SLES for Raspberry Pi

There are a number of things that are different between raspbian and other distros on Raspberry Pi. Overcame these to get mraa's gpio working on SLES (and openSUSE)

@alext-mkrs nice catch! I forgot about this one, and updated my branch with the proper value.

Merged! This is awesome, thanks alot for this.
Btw do you have a mraa project on suse's OBS? Myself and @tingleby where discussing doing this but if you have something already we could just link to it in our front page where we have our PPA link.

Btw do you have a mraa project on suse's OBS?

We have one with the patches from this PR in the hardware project

That's awesome, are you happy with us linking to these repos from the top
level README.md file?
I'll make a mraa release soon so you don't have to keep those patches like
this :)
On 2 March 2017 at 17:42, Cedric Bosdonnat<EMAIL_ADDRESS>wrote:

Btw do you have a mraa project on suse's OBS?
We have one with the patches from this PR in the hardware project
https://build.opensuse.org/package/show/hardware/mraa
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/intel-iot-devkit/mraa/pull/655#issuecomment-283707405,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAfZZr_YygGwH-iGeGUSyI_vpH67lGoAks5rhvGRgaJpZM4MKCdH
.

yeah sure, that'ld be awesome!

@arfoll done, see PR #657

Hello,
I have been using mraa on a raspberrypi 3 with a debian stretch without anay problem for months, but I have not been able to get an mraa functional image with a kernel younger than 4.4.37-v7+ . Issue #620 was closed without solution. I hoped  these contributions may have helped but  no change. Could you have please some advice or hint on how to compile an image with mraa and  a more recent kernel  on araspberrypi ? I do not want to go back to the dark corners of raspbian and things are working very well with the old kernel  raspi3image I have merged swig latest version with @arfoll  amandments and the compilation works  with Node 7.7.
Thanks for any help


Include base/view-filters in all assets that require it to ensure ckan.views is available

This fixes the old gallery view not being interactive. I'm not exactly sure why but I think it caused some of our code to fail to initialise properly and then the click events were just being missed. Not sure why this suddenly stopped working either? Bit weird but heyho. It is likely not all of these assets need base/view-filters, I just added it to every asset which included a JS file which references ckan.views to be safe.
Closes: #723

coverage: 32.901%. remained the same
when pulling db9e0dbc61e9c7e6075b9229b93b8d8bf184940c on josh/fix-old-gallery-view
into 4fce113167debe49831aa2c1fe001a4626ce6c63 on dev.


[change] Convert geocoding test to check #90

Closes #90

Will this check be mandatory? I have a controller without internet

Will this check be mandatory? I have a controller without internet

Good point @pniaps, in the current version, this check is enabled by default but now we're making it optional.


fix(cluster/staging): delete staging cluster

it not existed for longer than one year.
Signed-off-by: wuhuizuo<EMAIL_ADDRESS>

/approve


Crate-JDBC runing on Zeppelin (Spark 2.1.0) Issue

Hi,
I am getting the following exception when running the below code on zepplin (0.7.2) that uses spark interpreter (2.1.0).  Appreciate your quick response
org.apache.spark.SparkException: Job aborted due to stage failure: Task 0 in stage 2.0 failed 1 times, most recent failure: Lost task 0.0 in stage 2.0 (TID 2, localhost, executor driver): io.crate.shade.org.postgresql.util.PSQLException: ERROR: SQLParseException: line 1:29: mismatched input 'AS' expecting {'.', 'TO', '='}

import org.apache.spark.sql.functions.{concat, lit}
import sqlContext.implicits._
import org.apache.spark.sql.Row
import spark.implicits._
import org.elasticsearch.spark._
import org.elasticsearch.spark.sql._

val dbWriteMode = "append"
val dbUrl = "crate://localhost:5433"
val dbDriver = "io.crate.client.jdbc.CrateDriver"
val dbProperties = new java.util.Properties

dbProperties.setProperty("driver", dbDriver)

val testDF = Seq(
  (1, 5)
).toDF("id", "name")

val testWriter = testDF.write.mode(dbWriteMode)
testWriter.jdbc(url=dbUrl, table="test", dbProperties)

just to be sure - please can you try adding a trailing slash to the dbUrl?
https://crate.io/docs/clients/jdbc/#jdbc-url-format

I have done that, i still see the same issue

Please find the complete stack trace.. there is an issue when setting the transaction isolation from the spark library
org.apache.spark.SparkException: Job aborted due to stage failure: Task 0 in stage 3.0 failed 1 times, most recent failure: Lost task 0.0 in stage 3.0 (TID 3, localhost, executor driver): io.crate.shade.org.postgresql.util.PSQLException: ERROR: SQLParseException: line 1:29: mismatched input 'AS' expecting {'.', 'TO', '='}
at io.crate.shade.org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2458)
at io.crate.shade.org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:2158)
at io.crate.shade.org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:291)
at io.crate.shade.org.postgresql.jdbc.PgStatement.executeInternal(PgStatement.java:433)
at io.crate.shade.org.postgresql.jdbc.PgStatement.execute(PgStatement.java:359)
at io.crate.shade.org.postgresql.jdbc.PgStatement.executeWithFlags(PgStatement.java:306)
at io.crate.shade.org.postgresql.jdbc.PgStatement.executeCachedSql(PgStatement.java:292)
at io.crate.shade.org.postgresql.jdbc.PgStatement.executeWithFlags(PgStatement.java:269)
at io.crate.shade.org.postgresql.jdbc.PgConnection.execSQLUpdate(PgConnection.java:437)
at io.crate.shade.org.postgresql.jdbc.PgConnection.setTransactionIsolation(PgConnection.java:844)
at org.apache.spark.sql.execution.datasources.jdbc.JdbcUtils$.savePartition(JdbcUtils.scala:569)
at org.apache.spark.sql.execution.datasources.jdbc.JdbcUtils$$anonfun$saveTable$1.apply(JdbcUtils.scala:670)
at org.apache.spark.sql.execution.datasources.jdbc.JdbcUtils$$anonfun$saveTable$1.apply(JdbcUtils.scala:670)
at org.apache.spark.rdd.RDD$$anonfun$foreachPartition$1$$anonfun$apply$29.apply(RDD.scala:925)
at org.apache.spark.rdd.RDD$$anonfun$foreachPartition$1$$anonfun$apply$29.apply(RDD.scala:925)
at org.apache.spark.SparkContext$$anonfun$runJob$5.apply(SparkContext.scala:1944)
at org.apache.spark.SparkContext$$anonfun$runJob$5.apply(SparkContext.scala:1944)
at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:87)
at org.apache.spark.scheduler.Task.run(Task.scala:99)
at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:282)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:748)

Hi @jodok - I have found the issue, the spark code is setting the transaction isolation level and the postgres code is trying to run the following query to set the same which is when we are getting the error.
SET SESSION CHARACTERISTICS AS TRANSACTION READ COMMITTED;
I have checked out the code and commented out the code in PGConnection for setTransactionIsolationLevel() and ran my program again and it worked. we need a way to set or skip the transaction isolation level for crate

thanks @mvjkumar we also discovered the same :) working on a solution for that!

thanks @jodok

hey @mvjkumar we've done two things to work around your issue:

crate can "swallow" the SET SESSION CHARACTERISTICS command (https://github.com/crate/crate/commit/603ec1cade24be13e9c6d98c5adec162bc54a035) this is on master / nightly builds and will be released with the next major release (planned ~september).
if you set the JDBC drivers strict parameter to true crate will report that it doesn't support transactions and spark won't try to set the transaction isolation level. the fix just has been merged (https://github.com/crate/crate-jdbc/commit/4004a6d2eecc4ecd2b11bc5010588b916174f592) and the 2.2 version of driver will be shortly on bintray.
closing that issue for now. please let us know if this works :)

This works, thanks for accommodating this so quick

our pleasure :) please let us know if you hit further issues. we're committed to make crate work nice with spark.


The dynamic example is scary and needs a revamp

The example in question:
https://github.com/bevyengine/bevy/blob/259fb6896e07bed89df2637aace547f295fc7e82/examples/ecs/dynamic.rs
Does far more than presenting how to use the dynamic query API. Notably it:

Creates a custom components not tied to a rust type
It uses the dynamic query API
It uses std::alloc and NonNull to copy values from a Vec and point a OwningPtr to it.
It parses a mini syntax for querying.

To illustrate a dynamic querying API, I think (2) and (4) are sufficient. (1) should have a separate example. (3) could illustrate separately the bevy_ptr crate as well.
This might seem harmless, but in reality, it causes real problems: it confuses users. Here is an example: https://github.com/bevyengine/bevy/discussions/11424
Other problems with the example
https://github.com/bevyengine/bevy/blob/259fb6896e07bed89df2637aace547f295fc7e82/examples/ecs/dynamic.rs#L123-L128
There is direct calls to std::alloc functions, a lot of manual pointer fiddling (cast, copy_from, NonNull::new), Even a memory leak! (the data ptr is allocated without ever being freed) I think this kind of code has nothing to do in a bevy example, not only it isn't representative of general bevy usage, but it might scare off potential users. Especially given that supposedly people chose a rust game engine because they don't have to remember to free their dynamic arrays!
Proposed changes
In actuality, the currently exposed API do still require OwningPtr (the bevy_ptr type) at least for insertion but I think the best example would show how to convert between the Ptr returned by dynamic query iteration into a &dyn Reflect. This has already been a question (@coreh) and I suspect it's going to be super useful to a lot of users.

The way you go from the PtrMut to a &mut dyn Reflect is as follow:

Get the ReflectFromPtr for the component id. Here I cache it when I build the query state, so that I don't have to fetch it while iterating the query
https://github.com/nicopap/bevy_mod_dynamic_query/blob/149b5d4a5a3611373b99b83bc9075cbd7d03b01e/src/builder/named.rs#L28-L32

Get the Ptr or PtrMut returned by iterating a query in the #9774 API and call ReflectFromPtr::from_ptr on the individual fetch items, then you have a &dyn Reflect:
https://github.com/nicopap/bevy_mod_dynamic_query/blob/149b5d4a5a3611373b99b83bc9075cbd7d03b01e/src/fetches.rs#L167-L169
Here is a version of point (1) where I go from T: Component to ReflectFromPtr: https://github.com/nicopap/bevy_mod_dynamic_query/blob/149b5d4a5a3611373b99b83bc9075cbd7d03b01e/src/builder/methods.rs#L23-L29

Knowing how to convert into a &dyn Reflect a PtrMut is immediately more useful than knowing how to copy from a Vec<u64> into a custom component. It also has more applications, especially for someone who is interested into using the dynamic query API.

Your right that the memory allocation is scary, I don't believe it creates a leak though as the raw pointer is converted to the OwningPtr which will be freed when the component itself is freed. My reasoning for using a dynamically sized [u64] was to demonstrate that the layout of the dynamic component can be determined dynamically as well, rather than having to be tied to some existing type layout.
I do agree that having all of the dynamic ECS constructs in one example is a little overwhelming and makes it hard to parse for new users who probably only need 1 or 2 parts of it, so we should probably split it up or at the very least document it more thoroughly showing alternatives for simpler use cases. I do think there will be some people who want to do everything that the example is doing and it is non-trivial to figure out how to use bevy's dynamic APIs so I think all parts of it should still exist somewhere.
The main reason I made the example the way it is was to prove it was possible to have the components, queries and entities "fully" defined dynamically, but it's non-ergonomic and I think it also points to some areas where we could improve the bevy_ecs API itself.
I also agree that we should show how to convert from Ptr to a dyn Reflect, it doesn't necessarily have to be associated with dynamic queries since there are other scenarios you would have to perform that conversion but it's as good a place as any.

Yeah! In any case, I think you did great work, and seriously, even a non-pedagogically-optimal example shouldn't be a blocker to merge such an important feature as the one you implemented.
I want to say how much I'm glad you implemented dynamic queries. I personally need them a lot, and the rest of the community will be delighted, as direct users, and as users of the future functionalities built on top of dynamic queries.
Thank you again! I think it makes sense that the rest of the community (me included) cleans up behind. I wanted to direct attention to things that can be improved so that new users could use more effectively your work.


Show recommended DNS records for a site

It would be nice if there was a way to show all the recommended DNS records for a site.
Currently all I can find is a way to list all of the domains for a site:

terminus site hostnames <list|add|remove> [--site=<site>] --env=<env> [--hostname=<hostname>]

+1 this feature request


Automator: update proxy@master in istio/istio@master

Generated by Automator - 2023-10-19T13:46:22+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
070cbe7622eaee6f189f2a469722b9177f9d32cf
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests


Starfinder>Biohacker: Microlab + Biohack

Microlab:
For the creature identification: Should call out Life science (if living) or Physical Science (if unliving)
The attunement is 3+key ability mod max creatures
Biohacks:
On the minor, basic booster, + basic inhibitor, should note that you pick one of the listed items?
Spark of Ingenuity - this is a limited use ability, 1/day, 2/day @9th and 3/day @15th. Also Instinctive Lv9 enhancement - Inhibitor biohack gains off-target OR dazzled. The language is really messy on this one

Resolved.


[yaml] disable javascript mapping for python >=3.12

js2py is not supported in Python 3.12, so to prevent future issues arising from Beam Python 3.12 support, this js2py import is being excluded for Beam installs starting with Python 3.12 and the feature will throw error if the package does not exist.
Tracked in https://github.com/apache/beam/issues/30829

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

R: @tvalentyn

R: @robertwb


Feedback: Request to review Azure AD DS with Azure NetApp Files for MSIX Support

Hello, my customer has Azure NetApp Files working successfully with MSIX App Attach within an Azure AD DS environment.  We have a guide can provide if it helps to review/test and determine if it's feasible from a support statement.  Thanks!

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 3dc8c13a-2891-02e8-e4c5-b93e42f94121
Version Independent ID: 82a6a449-f47b-5a9d-051d-6b83003dad35
Content: Azure Virtual Desktop MSIX app attach FAQ - Azure
Content Source: articles/virtual-desktop/app-attach-faq.yml
Service: virtual-desktop
GitHub Login: @Heidilohr
Microsoft Alias: helohr

@brmcmill
Thanks for your feedback! We will investigate and update as appropriate.

@brmcmill
We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.


Feature request - Editing Multiple Keyframes in the Animation Timeline at once

Possible Duplicate:
https://github.com/godotengine/godot/issues/28477
Godot version:
Godot 3.1.1
OS/device including version:
Windows / Gtx 1080
Feature description:
Would it be possible to select multiple keyframes to edit at the same time?
For example, I have a simple animation for rocks assembling to a position, and need to scale them all up.

If this is not feasible, I can definitely animate them in Blender and just go with that.
Thanks!

@YeldhamDev Did #30778 fix that?

@akien-mga Pretty much.


MITgcmutils not compatible with Python 3.12

It seems that MITgcmutils does not support Python 3.12? I get the following error when trying to import MITgcmutils:
from MITgcmutils import rdmds
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
Cell In[12], line 1
----> 1 from MITgcmutils import rdmds

File /tank/spectre/tuchida/miniconda3/envs/spec12/lib/python3.12/site-packages/MITgcmutils/__init__.py:1
----> 1 from numpy import NaN, Inf
      2 from .mds import rdmds, wrmds
      3 from .ptracers import iolabel,iolabel2num

ImportError: cannot import name 'NaN' from 'numpy' (/tank/spectre/tuchida/miniconda3/envs/spec12/lib/python3.12/site-packages/numpy/__init__.py)

My numpy version is 2.0.0.
The importing works fine under Python 3.10.

This should be fixed as of June 2024 in the MITgcm repo.  In case you are using PyPI (pip), I have just uploaded the latest version (0.2) there too.


Always in STM32 Bootloader mode with J-Link plugged

With J-Link plugged, no matter powered by USB port or not, connecting host via USB port will get a STM32 Bootloader device in PC's device manager list.
Seems Cannon it's under Boot mode with this setup that results APP code cannot run.

—
Reply to this email directly or view it on GitHub.

Connected BOOT0 to GND, STM32 will not enter into boot mode.
But got USB enumeration failure when J-link plugged to PC.
There may have bugs in code somehow. Need to dig more.


[fix][managed-ledger] fix calculation in getNumberOfEntriesInStorage

Motivation
The number of entries in storage is between markDeletePosition and lastConfirmedEntry, which the markDeletePosition is excluded, and the lastConfirmedEntry in included.
The current algorithm yields 1 more because ledger.getLastPosition().getNext() is included.
Modifications
The right way is to make the algorithm not include ledger.getLastPosition().getNext().
Verifying this change

[x]  Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?

[x] no-need-doc

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks

The new test is failing in the release branches because, in order to pass, it needs also https://github.com/apache/pulsar/pull/14672
Caused by: java.lang.AssertionError: expected [2] but found [3]
	at org.testng.Assert.fail(Assert.java:99)
	at org.testng.Assert.failNotEquals(Assert.java:1037)
	at org.testng.Assert.assertEqualsImpl(Assert.java:140)
	at org.testng.Assert.assertEquals(Assert.java:122)
	at org.testng.Assert.assertEquals(Assert.java:907)
	at org.testng.Assert.assertEquals(Assert.java:917)
	at org.apache.bookkeeper.mledger.impl.ManagedLedgerTest.lambda$testGetNumberOfEntriesInStorage$34(ManagedLedgerTest.java:2296)
	at org.awaitility.core.AssertionCondition.lambda$new$0(AssertionCondition.java:53)
	at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:222)
	at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:209)
	... 4 more

I believe that we should NOT port https://github.com/apache/pulsar/pull/14672 to release branches since it's a behaviour change (even if internal). We can just modify the failing test
@HQebupt could you do it?


Exclude net4* from binskim

/azp run net - hdinsight - mgmt - ci

potentially fixes https://github.com/Azure/azure-sdk-tools/issues/7933


1.0.1 ?

Would be cool if you could tag a new release with the latest minors changes  including the new license header. It would clarify the legal stuff there.

Ping! :)
Any news on this?

Additionally, publishing this module to Hex would be great!
@yrashk Are you still maintaining this library? If not, we could move it to https://github.com/erlangpack where the ErlangPack team will take care of releasing and publishing it to Hex. Please let me know if you’re okay with that! Of course, you’ll keep full commit rights and get credits.

@ddeboer I am not. Happy to move it over.

However, unfortunately, I don't have admin rights in this org anymore. So it would have to be another repo.

@yrashk Thanks for the swift reply!
It would be best to move the repository (to the ErlangPack organization). That way, everyone will be redirected to the new location.
@kevinsalter @mtwilliams Do you have admin rights to this repository? If so, could you please move it to the ErlangPack organization (and let me know who I should grant full commit rights to)?

I've added @yrashk as an administrator.

I tried to transfer the repository, but GitHub says I don't have a right to create reois at erlangpack.

I invited you to the ErlangPack organization, which should grant you the required rights.

Done!

Thanks, @yrashk!


[Options] Typo in the "delimiter" option name

Hi there,
So uh, that's no big deal but I've just stupidly spent a wee bit too much time trying to figure out why the "delimiter" option didn't work, only to notice that there was in fact a typo and Taggle expected it to be written "delimeter" (that's also reflected in the documentation, so I guess it works as advertised).
Maybe it could be a good thing to support "delimiter", and maybe preserve BC for some time by re-routing "delimeter" options to "delimiter".

Also, some mechanism to catch undefined options could help in those situations :-)

Oh wow. 👍


Fake Client (feature request)

Hi!
My team has been using this client a lot to integrate our new CICD tool (Tekton) with Github. Thanks, btw! It mostly "just works" :)
To test these integrations, we implemented a simple fake client. I'd like to ask if a PR adding a fake client would be welcome.
This would require us to add interfaces for the client and its services..
Just a quick view of how that would look like:
package github

import (
	"context"
	"net/http"
)

type ChecksServiceInterface interface {
	//TODO finish me
	GetCheckRun(ctx context.Context, owner, repo string, checkRunID int64) (*CheckRun, *Response, error)
	CreateCheckRun(ctx context.Context, owner, repo string, opts CreateCheckRunOptions) (*CheckRun, *Response, error)
	UpdateCheckRun(ctx context.Context, owner, repo string, checkRunID int64, opts UpdateCheckRunOptions) (*CheckRun, *Response, error)
	ListCheckRunsCheckSuite(ctx context.Context, owner, repo string, checkSuiteID int64, opts *ListCheckRunsOptions) (*ListCheckRunsResults, *Response, error)
}

type RepositoriesServiceInterface interface {
	//TODO finish me
	ListHooks(ctx context.Context, owner, repo string, opts *ListOptions) ([]*Hook, *Response, error)
}

type IssuesServiceInterface interface {
	//TODO finish me
	CreateComment(ctx context.Context, owner string, repo string, number int, comment *IssueComment) (*IssueComment, *Response, error)
}

type Interface interface {
	//TODO finish me
	ChecksService() ChecksServiceInterface
	RepositoriesService() RepositoriesServiceInterface
	IssuesService() IssuesServiceInterface
	RateLimits(ctx context.Context) (*RateLimits, *Response, error)
}

func NewClientInterface(httpClient *http.Client) Interface {
	return NewClient(httpClient)
}

func (g *Client) ChecksService() ChecksServiceInterface {
	return g.Checks
}

func (g *Client) RepositoriesService() RepositoriesServiceInterface {
	return g.Repositories
}

func (g *Client) IssuesService() IssuesServiceInterface {
	return g.Issues
}

Then you could use the client though the interfaces:
githubClient := github.NewClientInterface(nil) // type github.Interface
_, _, err := githubClient.ChecksService().CreateCheckRun(...)
...

And it would be the same for fake client
githubClient := fakegithub.NewFakeClient(nil) // type github.Interface
_, _, err := githubClient.ChecksService().CreateCheckRun(...)
...

Thank you, @RafaeLeal - this sounds cool!  Before we proceed any further, could you please take a moment and read through #1800 since I think that is relevant.
We might recommend creating your fakegithub client in a separate repo (under your own corporate or personal GitHub username).  Please let us know what you think after reading that discussion.  (Sorry, but the discussion itself got branched out all over the place.)

Thank you, @RafaeLeal - this sounds cool!  Before we proceed any further, could you please take a moment and read through #1800 since I think that is relevant.
We might recommend creating your fakegithub client in a separate repo (under your own corporate or personal GitHub username).  Please let us know what you think after reading that discussion.  (Sorry, but the discussion itself got branched out all over the place.)

Thanks for the link, I read some of the discussion..
In my case, I don't need to embed interfaces into the struct, but I'd benefit from having interfaces for the client.
Although I could (and we already did actually) add interfaces on our side, I can not implement methods for the GitHub client.
So if we want to have a GitHub client interface as I showed I need to write a wrapper for the GitHub client.
type githubClient struct {
	client *github.Client
}

func New() (Interface, error) {
	gh, err := client.NewGithubClient()
	if err != nil {
		return nil, err
	}
	return &githubClient{client: gh}, nil
}

func (g *githubClient) ChecksService() ChecksServiceInterface {
	return g.client.Checks
}

func (g *githubClient) RepositoriesService() RepositoriesServiceInterface {
	return g.client.Repositories
}

func (g *githubClient) IssuesService() IssuesServiceInterface {
	return g.client.Issues
}

and this type of code seems a bad smell since it's going to require us to keep with the changes inside this repo.
I can't simply use
githubClient := github.NewClient(nil) // returns *github.Client
githubClient.Checks.CreateCheckRun(...)

because we need the interfaces to fake them

Hi @RafaeLeal , after lots of conversations and feedback about this topic from the folks from go-github, I've created https://github.com/migueleliasweb/go-github-mock. I had a similar issue as I needed to unittest my code that uses the go-github SDK. Have a look at that repo. Cheers!
https://github.com/google/go-github#testing-code-that-uses-go-github

Closing feature request. Please let us know (or submit a PR that updates README.md) if you decide to create another external helper repo that we can point to, @RafaeLeal .


Ember 3.5

Hi,
I try to update an old application based on Ember 2.13 to Ember 3.5 and now my last problem is to use your plugin in the new ember 3.5 environment.
This error occurred:
loader.js:247 Uncaught Error: Could not find module emberimported fromember-cli-slick/components/slick-slider     at missingModule (loader.js:247)     at findModule (loader.js:258)     at Module.findDeps (loader.js:168)     at findModule (loader.js:262)     at Module.findDeps (loader.js:168)     at findModule (loader.js:262)     at requireModule (loader.js:24)     at Class._extractDefaultExport (index.js:422)     at Class.resolveOther (index.js:101)     at Class.resolve (index.js:163)
Do you have a tipp for me?

Looks like a similar issue to what led me to submit PR #32. There seems to be an issue importing some addons using the old import Ember from 'ember' syntax into an Ember 3.x app.


Duplicate records from PURE

Still getting some duplicate records from PURE.

Ferg tested this and is seems to be fixed :)


Issue with k8s.io/docs/tasks/debug-application-cluster/events-stackdriver/

Using the provided yaml results in (GKE v1.12.9-gke.7):
E0902 08:12:44.409083       1 reflector.go:190] github.com/GoogleCloudPlatform/k8s-stackdriver/event-exporter/watchers/watcher.go:50: Failed to list *v1.Event: events is forbidden: User "system:serviceaccount:devops:event-exporter-sa" cannot list resource "events" in API group "" at the cluster scope
After modifying the clusterrolebinding to:
...
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: ClusterRole
  name: edit
...

it apparently work but these permission might be too wide.

Looking a bit deeper this whole guide is moot because the exporter is already installed in the kube-system namespace! Stackdriver instructions are out of date however and events appear in:
GKE Cluster Operations
NOT:
GKE Cluster

@kribor Thank you for reporting this issue! We are in the process of removing third-party content, which includes this Stackdriver page. See PRs #15748 and  #16203.  So I'm closing this Issue. Thanks.
/close


Access Violation with 24.11 version

I get an access violation on all tested win7 systems.
Both 32 and 64-bit system throws the error every time i try to open a media file or quit the application.
All systems are updated with latest ESU updates.
This is using the 24.11 version without installer.

Maybe duplicate of #943.
Please test this build.

That works, thanks !
I assume the unpleasing white background is due to that webview2 stuff, or is that by choice ?

JeromeMartinez
I test this build on to Win7 SP1 x64 (also installed hot fix Windows6.1-KB2619497-v2-x64 needed fo Xeon E5 2697 v2 - then CPU have 12 core /24 tread and L3=30 Mb gt then kernel limit <= 8 core and L3 <= 16 Mb) in to include and exclude Graph plug-in - work success w/o AV at read adress 0x18 (Interrupt vectors arrea - access hardware protected).

I assume the unpleasing white background is due to that webview2 stuff, or is that by choice ?

@tessa112 please test this build.

@tessa112 please test [this build]

Sorry for late reply, this one works fine for me as well as the previous 241108 version.
Really appreciate the quick fix, however i will stay on the 24.06 version with the grey background.


Work around the RSACryptoServiceProviderProxy crash on mono

While I understand that #179 was closed as wontfix because mono is not officially supported, this is a really trivial workaround that greatly helps mono users. To put this into perspective, we are currently IL-patching Microsoft.IdentityModel.Tokens.dll on every startup of our application because there is no easier way to work around this problem in our case (it's behind other libraries).

@main-- Which version of IdentityModel are you using?
This class is not available in our netstandard 2.0 target since v5.4.0.

This is on version 5.5.0 but on the net472 target.

Can you tell me how? From what I understand there is no way to build executables against netstandard because netstandard is not a runtime. Creating a class library with a Main() function and running that is not possible either because the resulting assembly will be missing an entry point. Using .NET Core is not an option as it doesn't run on FreeBSD. Mono is the only way for this and plenty of other platforms that are neither Windows nor Linux (nor Mac).
The point of this PR is to add a tiny trivial fix that costs basically nothing and brings a great improvement to all mono users (RSA JWT is broken completely -> RSA JWT works perfectly fine). While a merge would make things easier, the cost and risk of moving to netstandard is definitely not worth it for us. Sorry, I can't tell you whether or not that would solve this problem.

It looks like Mono supports libraries compiled against netstandard2.0:

Loading and running a library compiled against the 2.0 standard should work fine

https://www.mono-project.com/docs/about-mono/releases/5.2.0/#net-standard-20-groundwork
https://www.mono-project.com/docs/about-mono/releases/6.4.0/#net-standard-21-support
You should continue using net472, but consume IdentityModel compiled against netstandard2.0.
NuGet will automatically select the closest target, in this case net461. You can override this behavior by explicitly referencing IdentityModel assembly compiled against netstandard2.0.
<ItemGroup>
    <PackageReference Include="Microsoft.IdentityModel.Tokens" GeneratePathProperty="true">
      <Version>5.6.0</Version>
    </PackageReference>
    <Reference Include="Microsoft.IdentityModel.Tokens">
      <HintPath>$(PkgMicrosoft_IdentityModel_Tokens)\lib\netstandard2.0\Microsoft.IdentityModel.Tokens.dll</HintPath>
    </Reference>
</ItemGroup>

If you are not using NuGet, just manually reference IdentityModel assembly compiled against netstandard2.0.

Thank you! This also resolved the problem. As the project is using packages.config I simply change the HintPath in the csproj file.
Although this does seem like a really hacky workaround to me. What is the risk/drawback of doing it this way? Do I have to reapply this fix every time I update nuget packages?

I don't see any risks, expect that I don't know how well Mono plays w/ netstandard.
Just wanted to make sure that we look at alternative solutions before we review the PR as the previous issue was closed as "wontfix" (like you pointed out).

While this does fix the error, just including the fix would probably make life easier for everyone involved. Editing csproj files because a comment in an issue said so (with no documentation) is always more of a hassle than "it just works."
The PR will likely not affect code complexity, runtime performance or binary size significantly - but it makes the library work on a whole new platform. Sure, that platform is not the target, nonetheless people use it.
While perhaps the benefits of this PR aren't huge, I don't see much cost associated with clicking merge, either.

I agree that the proposed solution is not ideal, but It's still a working workaround.
Would you be interested in making some changes to this PR and testing one of the preview builds?

Sure, what changes?

Great! I'll put my comments in the review.

Thank you for your feedback. I fixed the typo.
While it's clearly unfortunate that Type.GetType("Mono.Runtime") != null is not a definitive check I would argue that it's so widespread that anyone who accidentally creates a Mono.Runtime class in their application should expect to see plenty of breakage from other dependencies as well. A quick search on github alone yields >35k results and includes big names like NUnit and even nuget!
And since the class is not used as of the netstandard2.0 target many users can't be impacted at all.
Alternatively, https://github.com/main--/azure-activedirectory-identitymodel-extensions-for-dotnet/commit/f043db6847ca082b5b8ed1e5eb6b838472547199 catches the exception from re-creating the CSP on mono. This avoids the performance hit of performing a dummy RSA operation every time.

@main-- The alternate solution seems good to me as it handles the corner cases where  Type.GetType("Mono.Runtime") != null  but Mono isn't being used. Can you modify the PR to include it?

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: main-- sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@mafurman I added the commit.

Hi, I understand that we submitted the final fix during the US thanksgiving weekend, so I'm poking just in case this was overlooked during all the festives.

@main, @moritzuehling - Apologies for the delay in response.
Please rebase this PR against the dev5x branch. We will publish a nightly build so you can verify that the fix is working for you.

The preview package seems to have disappeared off myget, (If I had to guess because of a retention policy) stopping our testing in its tracks.
When will it be decided if this makes it into a release, and if it is accepted will there be new preview builds containing it between now and next release?

@Vaskinn - Correct, the package is removed because of a retention policy.
This change will be available in all preview builds starting with "5.7.1-preview-10214203806".
We don't have an ETA for a new release yet.
@main--, @moritzuehling This is great, thank you for your contribution!

It looks like this never got released since the 5.6 is the latest stable release, then followed by 6.5 (ref https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/issues/1361)
I tried switching to the latest 6x - but I'm still getting "Keyset does not exist" on Mono.
Is that right?


Update some dependencies - fixes some vulnerabilities

After all updates npm audit found only 3 vulnerabilities - all in mocha pachage. I try update it also, but I need rewrite some tests first.
I want also update default electron version to latest (5.x).

Codecov Report

Merging #231 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #231   +/-   ##
=======================================
  Coverage   58.63%   58.63%
=======================================
  Files          20       20
  Lines        1494     1494
=======================================
  Hits          876      876
  Misses        618      618

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e4f21b...df86954. Read the comment docs.

@KoenLav @cbh6
Hello,
can you check this changes (code review and test in your projects will be great)?

@darqs I combined all changes and released a fork:
https://www.npmjs.com/package/meteor-desktop-next
We're testing this now, but first results look promising.

@KoenLav
Ok, nice. We need some time to test all things, and after it @wojtkowiak can merge it.


Add red broken icon for warnings. Blue always on users you don't follow

@keybase/react-hackers

:+1:


Bug fixing

This fixes two bugs:

Apple Web Services are very strict on the PList format (e.g. utf-8 must be capitalized); making the writer compliant
the parser doesn't handle correctly short empty elements (e.g.  vs. )

@aovestdipaperino this is awesome, really appreciate direct fixes / contribution!
Two requests:

please add a citation / authoritative source for Apple's format expectations (or even a StackOverflow question?)
please add unit test(s)

I will try, I tested by connecting to Apple developer WebServices, the ones used e.g. by fastlane. See here  but I doubt those are publicly documented. Based on empirical evidence of getting malformed request errors if the encoding is not capitalized and the " Computer" is left in the DTD reference. Would this be enough though?
will do, it should be pretty trivial to add one. Stay tuned. I found the empty tag bug in the same way, as the same services use this style of empty elements. It also makes the parser more robust.


Avoid checks when spring-cloud-gcp-config is disabled

Fixes #245

??? What is this about?
Looks like a duplication of the #252

Indeed, but @saturnism went on vacations and the tests were failing on his PR, so we couldn't merge.

Closed in favor of #260

Oh! Sorry, I've mixed this one with the just merged fix for SCOPES. Shame on me 😢

@artembilan test added. PTAL


Vulkan: VoxelGI metallic materials appear as bright as non-metallic materials in reflections

Godot version
4.0.dev (5efe80f30)
System information
Fedora 34, GeForce GTX 1080 (NVIDIA 470.74)
Issue description
Metallic materials appear as bright as non-metallic materials in VoxelGI reflections. Since we cannot have reflections within reflections in a performant manner, we should probably try to get closer to the actual rendering of the metallic material somehow. This can likely be done by using a darker color for the voxels (and a less contrasted one somehow, since shadows are less visible on metallic materials).
In addition, this would help make self-reflections less noticeable on metallic materials.
Preview

Albedo color multiplied by 0.5 on fully metallic material
This was emulated by modifying the sphere material's albedo color, baking the VoxelGI node and resetting the albedo color to its default white.

Steps to reproduce

Add a mesh with a non-rough, fully metallic material. Make sure its bake mode is set to Baked.
Add a third mesh with a non-rough, fully metallic material. Make sure its bake mode is set to Baked.
Add a VoxelGI node and bake it.
Notice how the metallic objects appear as white in their reflections.

Minimal reproduction project
test_gi_texture.zip

I'm not sure if just tinting will be appropriate. The trouble is metallic objects take their color from specular reflections. So their color is dependent on the environment around them.
I remember reading about how another game engine solved this problem (I think from one of the real time rendering SIGGRAPH presentations). I'll post a follow up if I can find it.


Location for experimental functionality

@ferrine mentioned having some experimental marketing functionality. Where would it make sense to include this in the package? A pymc_marketing.experimental module or pymc_marketing.mmm.experimental? In pymc_experimental itself?
What are people's thoughts to best convey what might not be fully supported or stable?

I'm for pymc_marketing.experimental, it will give exposure and time to crystallise the functionality. Something might go to pymc experimental later or in a new repo that will have shared components for time series

I think that is a fine location. I'd say, throw it directly in a new submodule of pymc_marketing.mmm as well. If you want to make it harder to reach then don't import it in pymc_marketing.mmm.__init__.py


Remove RabbitMQ support from docs

Codecov Report

Merging #69 (1efc982) into main (1e4cd19) will increase coverage by 1.53%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   75.13%   76.66%   +1.53%
==========================================
  Files         165      158       -7
  Lines        2984     2897      -87
  Branches       66       64       -2
==========================================
- Hits         2242     2221      -21
+ Misses        742      676      -66

Impacted Files
Coverage Δ

...health/windows/actor/HealthSignalWindowActor.scala
91.95% <0.00%> (-1.15%)
:arrow_down:

.../surge/internal/kafka/KafkaProducerActorImpl.scala
85.16% <0.00%> (-0.43%)
:arrow_down:

...src/main/scala/surge/rabbit/RabbitDataSource.scala

.../src/main/scala/surge/rabbit/PassThroughFlow.scala

...rc/main/scala/surge/rabbit/RabbitEventSource.scala

.../src/main/scala/surge/rabbit/AutoDeclarePlan.scala

...ge/rabbit/QueueDeclarationExtensionImplicits.scala

...c/main/scala/surge/rabbit/RabbitDataPipeline.scala

.../src/main/scala/surge/rabbit/RabbitEventSink.scala

...a/surge/kafka/KafkaPartitionShardRouterActor.scala
62.77% <0.00%> (+0.72%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e4cd19...1efc982. Read the comment docs.


["laravel-filemanager::lfm.error-invalid"] Error after uploading on laradock

Operating system : laravel workspace container

I'm not sure which OS it is using but I checked it with uname -a command and it says
Linux f99f2939faa8 4.9.49-moby #1 SMP Fri Dec 8 13:40:02 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

Laravel version :  "laravel/framework": "5.5.*",
Package version : "unisharp/laravel-filemanager": "~1.8"
Steps to reproduce your issue :
Screenshots of browser console :

Issue:

I'm using "unisharp/laravel-filemanager": "~1.8" and it works perfectly fine on local testing, however, when I try it on laradock, it is causing ["laravel-filemanager::lfm.error-invalid"] this error on ckeditor image uploading window.
Not sure what is causing problem. Can anybody give advice? Thanks in proceed.
Expected behavior:

It works fine with normal files and svg image file. But not with png, jpeg,jpg files.
Relevant Code:
I also get warning on my Chrome saying,
Resource interpreted as Document but transferred with MIME type application/json: "http://project-1.test/laravel-filemanager/upload?type=Images&_token=a07AjjZgbiauMPQmBXP9dpqQA2a9waLha19v2FEA&CKEditor=ckeditor&CKEditorFuncNum=0&langCode=ko".

I had a similar problem and when I checked the log it showed
Reading Exif data is not supported by this PHP installation.
I enabled PHP exif extension and that fixed the problem.
check http://php.net/manual/en/exif.installation.php

enabled fileinfo module in php, its working fine in server also


V1.0 backports

Backports for v1.0.1
Bunch of cherry-picks off of master. Notably missing: anything related to the remote client work, any vendor changes aside from a small containers/selinux change.

@baude @rhatdan @vrothberg @giuseppe Anyone care to give this an LGTM?

LGTM

Needs a version bump.  v1.0.1?
I question backporting
Add varlink support for prune
We should not do anything for varlink at this point.
podman image prune -- implement all flag
We should not backport any new features
But not enought to block the process.

Image prune isn't a new feature so much as a major behavior change - it
matches us to the expected behavior of 'docker prune' instead of removing
far more images by default than people would expect.
The Varlink patch was mostly to convince the other prune patch to apply
cleanly without a complete rewrite.
On Sat, Feb 9, 2019, 07:21 Daniel J Walsh<EMAIL_ADDRESS>wrote:

Needs a version bump. v1.0.1?
I question backporting
Add varlink support for prune
We should not do anything for varlink at this point.
podman image prune -- implement all flag
We should not backport any new features
But not enought to block the process.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/containers/libpod/pull/2294#issuecomment-462039956,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHYHCM3r-Rqjto9-fbHiWywF3Rpxk1Jcks5vLr1agaJpZM4axIqC
.

@mheon there was one AppArmor fix:

commit 18b7009754df

I think we may also need to vendor the latest containers/{image,storage} to pull in fixes, do we?

the rootless commits LGTM

@vrothberg Since this is an 8-specific backport, I didn't pull in the apparmor stuff. Same reason on c/storage and c/image - we did a massive revendor after 1.0 and I didn't want to break anything

@rhatdan Now includes a version bump to 1.0.1
I'll do proper release notes for the main branch once this lands

LGTM
bot, retest this please

Alright bumping build_each_commit timeout just for this branch - if we do more backports we'll probably hit it again

/lgtm


add policy exception

https://github.com/giantswarm/roadmap/issues/3662

This PR:

Replaces patches with a policy exception

Testing
Description on how csi-driver-nfs can be tested.

[ ] fresh install works

[ ] AWS
[ ] Azure
[ ] KVM

[ ] upgrade from previous version works

[ ] AWS
[ ] Azure
[ ] KVM

Other testing
Description of features to additionally test for csi-driver-nfs installations.

[ ] check reconciliation of existing resources after upgrading
[ ] X still works after upgrade
[ ] Y is installed correctly

Checklist

[ ] Update changelog in CHANGELOG.md.
[ ] Make sure values.yaml and values.schema.json are valid.

Noice, do you know how to test it or do you want a hand with that?

I have tested general does it get deployed, is it running type stuff and that's fine. (including the polex hook so I think we can merge this PR)
However, if you have time it'd be cool to get some advice on testing the app functionality.

Sure, you can test it in this gcapeverde demo cluster (branch), and then create a pvc using that storage class.
https://github.com/giantswarm/workload-clusters-fleet/tree/demo-test/management-clusters/gcapeverde/organizations/demo/workload-clusters/democluster/mapi/apps/nfs-csi


Failed to add account. No Azure tenants

Issue Type: Bug
I am trying to login into a reporting server, when I attempt to connect, it opens my Browser Windows and prompts me to select my Microsoft account.  I select the correct one and it says I'm logged in.
I go back to Azure Data Studio and it shows me 2 different errors, see screenshot named 'Azure Errors'
I try to delete my Account from ADS, as suggested by my DevOps team, but It wont give me the option to do so.  See my screenshot named 'Delete_user', there is no option to Delete.
Its expected that I am able to click "MONKEY Prod" and connect to the DB.  Or atleast have the option to Delete my ADS account and re add.  This started happening right after I updated to version 1.15.1.

Azure Data Studio version: azuredatastudio 1.15.1 (83544eba2504f564d785534cc780d2073feec2cc, 2020-02-15T05:01:39.777Z)
OS version: Darwin x64 18.7.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-8210Y CPU @ 1.60GHz (4 x 1600)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
6, 5, 4

Memory (System)
8.00GB (0.09GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (1)

Extension
Author (truncated)
Version

import
Mic
0.13.1

![Azure_Errors](https://user-images.githubusercontent.com/34957150/75372377-b04dba00-5885-11ea-9765-a8458285bbea.png)
![Delete_user](https://user-images.githubusercontent.com/34957150/75372387-b348aa80-5885-11ea-90cc-d42b8a6b4f8d.png)
![Screen Shot 2020-02-26 at 10 43 56 AM](https://user-images.githubusercontent.com/34957150/75372388-b348aa80-5885-11ea-92c6-b82f1bf6edae.png)

I'm having the same problem. The Microsoft account I'm trying to use in an O365 account in Azure AD.

I'm thinking the inability to delete my account is related to the length of my name, since the 'x' isnt visible at all and my email domain is cutoff directly before '.com'.  Other members of my team, with much shorter names, are able to delete and re ad their account and can connect with no problem once the account has been re added

@aaomidi have you seen this type of error before?

The no azure tenants error happens when the user doesn't have permission to request information from a tenant.
If you open the developer log (Help -> Toggle Developer Tools -> Console) you might get a little bit more details on why the tenant authentication is failing.
Regarding the issue with being unable to delete it, I've caught that issue and it's covered here: https://github.com/microsoft/azuredatastudio/pull/9141/files#diff-3d0a372d3cce36b373fec7fe04ba53d3

Hi,
how does https://github.com/microsoft/azuredatastudio/pull/9141/files#diff-3d0a372d3cce36b373fec7fe04ba53d3 help me?  Does this mean its being worked on?
Im able to login via the Azure web portal but not the ADS App.
Inspector Tools provides me no additional information.

Hi again,
I was able to fix by running mv ~/Library/Application\ Support/azuredatastudio ~/Desktop/ in terminal, re added my user and re added my connections to ADS (thanks aaron yeung! =))

@marcwied I'm glad you were able to find a solution!

Does this mean its being worked on?

Yeah, there were a few CSS issues that went unnoticed since they're only showing up if the text is a certain length.

@marcwied in what location did you run mv ~/Library/Application\ Support/azuredatastudio ~/Desktop/ ?

@Max-Eriksson ~ translates to your home directory - assuming you're on OSX.
What platform are you on?

Hi, I'm running into this issue as well though I'm on Windows machine. I'm not sure how moving files to the desktop would help -- In any case, I tried moving
C:\Users\myuser\AppData\Local\Programs\Azure Data Studio to my Desktop and running it from there and I'm still running into the Failed to add account. No Azure tenants error.
System Info:
Version: 1.15.1 (user setup)
Commit: 83544eba2504f564d785534cc780d2073feec2cc
Date: 2020-02-15T05:03:16.545Z
VS Code: 1.42.0
Electron: 6.1.6
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Windows_NT x64 10.0.18363
Error screenshot:

Path:
C:\Users{USERNAME}\AppData\Roaming\azuredatastudio\Azure Accounts

Expanding on @aaomidi 's answer, I experienced the same issue after previously being able to use Azure AD MFA authentication to our Azure Sql database(s).
On Win10 this was resolved by:
Navigate to %userprofile%\AppData\Roaming\azuredatastudio\Azure Accounts and delete the (only) file I found there azureTokenCache-azurePublicCloud
cd "%userprofile%\AppData\Roaming\azuredatastudio\Azure Accounts"
rm azureTokenCache-azurePublicCloud

FYI - we added a command to make that easier. Open the command palette and run the Azure Accounts: Clear Azure Account Token Cache command

Just to say that I had this after changing my password, clearing the cache did nothing - I would get the web page saying I was logged in but Azure Data Studio just kept re-opening that page.
I deleted my credentials and re-added and it seems to have worked (for now)

@Charles-Gagnon  - I just tried using your suggested command, but it did not clear my credentials cache.  I had to manually delete them using the path above to make it actually work.

Oh huh, yeah sorry @iamwyza looks like the command isn't currently hooked up to do anything.
@aaomidi - do you know why this was commented out in https://github.com/microsoft/azuredatastudio/pull/8483? https://github.com/microsoft/azuredatastudio/blob/master/extensions/azurecore/src/account-provider/azureAccountProviderService.ts#L73

This command and deleting the file didn't work.
On Thu, Mar 12, 2020, 1:24 PM Charles Gagnon<EMAIL_ADDRESS>wrote:

Oh huh, yeah sorry @iamwyza https://github.com/iamwyza looks like the
command isn't currently hooked up to do anything.
@aaomidi https://github.com/aaomidi - do you know why this was
commented out in #8483
https://github.com/microsoft/azuredatastudio/pull/8483?
https://github.com/microsoft/azuredatastudio/blob/master/extensions/azurecore/src/account-provider/azureAccountProviderService.ts#L73
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/azuredatastudio/issues/9350#issuecomment-598313312,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHWPJKZGYS4C3G6HZZSPXN3RHELFJANCNFSM4K4K2SAQ
.

@Charles-Gagnon I'm not sure. I'll actually make that a port request for next release.
@SQLArchitect What are the errors you're getting?

The no Azure tenants and the other one just like originally reported.
On Thu, Mar 12, 2020, 1:59 PM Amir Omidi<EMAIL_ADDRESS>wrote:

@Charles-Gagnon https://github.com/Charles-Gagnon I'm not sure. I'll
actually make that a port request for next release.
@SQLArchitect https://github.com/SQLArchitect What are the errors
you're getting?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/azuredatastudio/issues/9350#issuecomment-598337668,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHWPJK6RBOAHFPU24SDLRXDRHEPJPANCNFSM4K4K2SAQ
.

I had the same issue today on my Mac. (Re)moving the config folder by moving it with
mv ~/Library/Application\ Support/azuredatastudio ~/Desktop/
fixed for me also

If anyone hits this issue, I have a guide on how to cleanup your Azure Accounts folder:
https://github.com/microsoft/azuredatastudio/issues/9585#issuecomment-598359949

Not sure if the command is uncommented and actually wired up yet, but in case it isn't or doesn't give the expected results, it seems for v1.17.1 the name of the token file has changed (again!).  Today it is showing as azureTokeCache_azure_publicCloud versus the value that it had when @acblksun posted.  Next week? Who knows!

The name of that file changing shouldn't impact this. If you're seeing a specific error happen please open a new issue as we're trying to sift through all the various OAuth woes.

The name of that file changing shouldn't impact this. If you're seeing a specific error happen please open a new issue as we're trying to sift through all the various OAuth woes.

@aamidi , I didn't mean to imply the name change was an issue.  I was just mentioning it in case anybody else scripted the delete and then starts swearing when that token-delete workaround seems to no longer work.
Also, today I had to use my old friend SSMS and I want to tell you and everybody else working on ADS, THANK YOU!   Not disparaging SSMS (as it's been very good to me over the years).  But for 95% of what I do with SQL, ADS is amazingly better.  I feel so much more productive that it's like it's given me an extra hand to type with and ten IQ points (yippie, now up to 81! ). THANK YOU! THANK YOU!  Good luck with the OAuth sifting. I hope it goes well.

I'm having the same issue today, due to password change. but this command "clear azure account token cache" doesn't seem to be present anywhere in my command palette.
Has it been removed? I'll check the source.

What version are you using? It should still be there. If not check the logs to see if there were any failures when starting up the extension host or the Azure extension.


Rename ProgressBarBase to ProgressBar

Proposed refactor
Class Names (conform to standard of Callback, Strategy, Accelerator)

Rename LightningLoggerBase to Logger
Rename AbstractProfiler and BaseProfiler to Profiler
Rename ProgressBarBase to ProgressBar

Directory Names (conform to standard of callbacks/, strategies/, accelerators/)

Rename profiler/ directory to profilers/

File Names (conform to standard of accelerators/accelerator.py, strategies/strategy.py)

Rename loggers/base.py to loggers/logger.py
Rename profiler/base.py to profiler/profiler.py
Rename callbacks/base.py to callbacks/callback.py
Rename loops/base.py to loops/loop.py

Motivation
Consistency in naming is important to give users and developers the cleanest and simplest experience when interacting with the code. It also makes it easier to find things in the codebase when everything conforms to the same standard.
cc @borda @tchaton @rohitgr7 @akihironitta @justusschock @awaelchli

Hi would like to work on this issue. I mean the parts that have not been done yet

Hello, I'm a newbie to open source contribution. And I'm interested in this issue. If no one has been assigned, can I work on this issue?

Hi @haesungpyun! Thank you for showing your interest! Feel free to start working on this issue! (please note that it may take some time to merge your PR because the next 1.7 release is getting very close.)

Hello, I have an problem while renaming ProgressBarBase to ProgressBar.
There's a conflict in src/pytorch_lightning/callbacks/progress/rich_progress.py in 23 line and 33 line if ProgressBarBase renamed to ProgressBar.
The code use ProgressBar from rich package progress_bar.py.
How should I handle this conflict?
Thank you!
https://github.com/Lightning-AI/lightning/blob/master/src/pytorch_lightning/callbacks/progress/rich_progress.py
`import pytorch_lightning as pl
from pytorch_lightning.callbacks.progress.base import ProgressBarBase (Conflit if ProgressBar)
from pytorch_lightning.utilities.imports import _package_available
_RICH_AVAILABLE: bool = _package_available("rich") and _compare_version("rich", operator.ge, "10.2.2")
Task, Style = None, None
if _RICH_AVAILABLE:
from rich import get_console, reconfigure
from rich.console import RenderableType
from rich.progress import BarColumn, Progress, ProgressColumn, Task, TaskID, TextColumn
from rich.progress_bar import ProgressBar
from rich.style import Style
from rich.text import Text`

Hello, can I work on this?

Hello, can I work on this issue?

If this doesn't land for 2.0, it will likely not happen. Is anybody interested in gettting this done quickly?

@carmocca Hi, I make a quick replacement in https://github.com/Lightning-AI/lightning/pull/17058, I will check the test and doc tomorrow.


Create Transformation task for Project_group

As a developer, I want to have a Luigi task that transforms the data/metadata given by providers into a suitable format for the entity Project_group.
Design
Database Schema

Create entry in scripts/init.sql for the creation of the table, pk and fks.
Create entry in etl/workflow/transformer.py with the class TransformModel.
Create entry in etl/jobs/transformation/spark_transformation_job.py
Create job etl/jobs/transformation/project_group_transformer_job.py
Create entry in luigi.cfg
Create entry in etl/workflow/loader.py

Acceptance Criteria

[ ] Table model was created according with the designed database schema
[ ] The transformation task can be executed and it finishes correctly
[ ] Data in the Project_group table is the expected one for the provider(s)


Due to the proxy, the TSUN cloud always shows the inverter status as offline

Observed with all versions since version 0.5:
For some time now, the TSUN apps and the TSUN website have always shown the inverter as offline, although status data and measured values are displayed correctly.
This may be due to an interruption in the connection to the TSUN Cloud, especially if the connection to the inverter is maintained

fixed with #27, which come with version 0.5.3


Instalation without MS Visual Studio

Hi,
is there any chance to get working this library without using Visual Studio (Win7 64bit, Win10 64bit)?
a] pre-built, e.i. as mxnet is providing?
b] using something else like MinGW as XGBoost is supporting?

@gugatr0n1c , It haven't be tested. But if you have MSBuild installed, you can using cmake to build it. It could also be build under MinGW environment.

close for now, feel free to reopen

Is there a suggested version of MinGW to use? I tried the original and mingw-w64 and both failed to compile. At the make step

@sockfull
https://github.com/Microsoft/LightGBM/wiki/Installation-Guide#cmake-with-mingw

I was using those commands from the installation guide when I got errors. I am wondering if I have not setup MinGW appropriately though, I have only used it once before to compile . I downloaded it from here:
https://sourceforge.net/projects/mingw/files/ for the installer. The gcc and base installations are installed, and cmake from https://cmake.org.


amend: added missing permission

:tada: This PR is included in version 2.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update spelling error in faq.md

peak -> top of a mountain, while peek -> look into

@mergifyio queue


if else statement without curly brace gives a line break after else

@Bram-Zijp - Please replace your screenshots with text for input, expected output and actual output.

@Bram-Zijp - Thanks for the update.
When I try this on http://jsbeautifier.org/ , I do not get a repro.
What editor are you using that gets this output?

@bitwiseman
I use Atom and gulp+babel. Your comment got me thinking and after some testing i found out babel is the reason with the option retainLines: true. I should have tested this before posting.
From here on i think all that i would like to achief is a mather of personal preference and might have to be directed towards Stackoverflow.
e.g.
input:
daisy.chain().like().this();

if (bla === blabla) hello.world;else goodbye.world;

output with 'break lines on chained methods' option:
daisy.chain()
    .like()
    .this();

if (bla === blabla) hello.world;
else goodbye.world;

expected output:
daisy
    .chain()
    .like()
    .this();

if (bla === blabla)
    hello.world;
else
    goodbye.world;


Swagger UI for Documentation is comprehensible for both developers and non-developers like clients or project managers.

Is your feature request related to a problem? Please describe.
For developers and non developers that might take interest in this project might need swagger UI for easy documentation and comprehension
Describe the solution you'd like
Implement swagger UI. I mean the Open API version
Describe alternatives you've considered
Postman is an alternative sure. But it does not make documentation as easy and comprehensible as swagger UI
Additional context
I want to ask if I can go ahead with implementing swagger with the app

Hi @Kordedekehine,
Thank you for your suggestion. I want to let you know that I have added the Swagger API as well.

Hi @Kordedekehine,
Thank you for your suggestion. I want to let you know that I have added the Swagger API as well.

You are welcome. If there is anyway I can contribute kindly let me know please

You are welcome. If there is anyway I can contribute kindly let me know please

checkout readme file: https://github.com/abhi9720/BankingPortal-API?tab=readme-ov-file#how-to-contribute


Changing composer install location

Fixes #2014

Thanks, but this doesn't need changing on 1.x.

Why not?  Composer does complain as the referenced ticket mentions, and 1.11 shows as the default branch when you hit https://github.com/FriendsOfPHP/PHP-CS-Fixer, so people will see the fabpot package location rather than friendsofphp.

The old package is not deprecated yet. The packagist warning is too early.

I see, the plan is to deprecate when 2.0 is released?
Should the referenced ticket be closed then with wontfix?

There are over 10 tickets now.


Improve cleanpath* performance

Locally, I get:

cleanpath_aggressive 71.7% -> 89.5%
cleanpath_conservative 73.2% -> 90.9%

Coverage remained the same at 93.023% when pulling 0307128b17adb548ac704e4f3ff7ecb6034e2971 on glebm:cow-prepend into a004e246d419f1ad9052a486720e88c91c9e283f on danielpclark:master.

Coverage remained the same at 93.023% when pulling 0307128b17adb548ac704e4f3ff7ecb6034e2971 on glebm:cow-prepend into a004e246d419f1ad9052a486720e88c91c9e283f on danielpclark:master.


[BUG] : Signup Page Not Working Properly GSSOC'23

I would like to work on this bug and would like to improve other things in this project..!

@coding-geek21 can you please assign this under gssoc23..

Actually this project is not under gssoc'23..
This is previous year project.
On Mon, 22 May, 2023, 8:09 pm Bishal De, @.***> wrote:

@coding-geek21 https://github.com/coding-geek21 can you please assign
this under gssoc23..
—
Reply to this email directly, view it on GitHub
https://github.com/coding-geek21/classDeck/issues/108#issuecomment-1557341375,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMW3ZCR7764BAGTOFEQT56LXHN3CLANCNFSM6AAAAAAYKPXTKU
.
You are receiving this because you were mentioned.Message ID:
@.***>

Okay Thankyou..!!
I will be fixing this bug and a patch as soon as possible.!

please assign me this issue under gSSOC 2023

please assign me this issue under gSSOC 2023


fix combobox disabled items behavior

Changes

Adjusted css so that disabled items have proper focus outline
Adjusted react code so that onClickHandler will early return if the item is disabled

Both of these changes ensure that disabled items can be predictably focused but not selected. Fixes #1201
Testing
Tested in storybook and also in playground, both with previous version (which doesn't have ListItem changes) and with new code.
https://user-images.githubusercontent.com/9084735/231842528-de7bf044-0c21-407f-a672-16e6b05b6692.mov
Docs
N/A

How were you able to focus on disabled item? For testing purpose

How were you able to focus on disabled item? For testing purpose

Same as other items - using arrow keys. See the screen recording in my PR description.
I used this code in the playground:

App.tsx
import * as React from 'react';
import { ComboBox } from '@itwin/itwinui-react';

export default () => {
  return (
    <>
      <ComboBox
        options={[
          { label: 'Apple', value: 'apple' },
          { label: 'Banana', value: 'banana' },
          { label: 'Cantaloupe', value: 'cantaloupe' },
          { label: 'Grapefruit', value: 'grapefruit', disabled: true },
          { label: 'Lychee', value: 'lychee' },
          { label: 'Kiwi', value: 'kiwi' },
          { label: 'Orange', value: 'orange', disabled: true },
          { label: 'Strawberry', value: 'strawberry' },
          { label: 'Watermelon', value: 'watermelon' },
        ]}
      />
    </>
  );
};

Works in storybook as well.

How were you able to focus on disabled item? For testing purpose

Same as other items - using arrow keys. See the screen recording in my PR description.
I used this code in the playground:
App.tsx
Works in storybook as well.

I'm not sure why I can't do that. I built your branch, also in storybook, but whenever I focus/arrow to the disabled items they just get skipped. Is there a settings I need to enable?

i'm using firefox so that might be it.
i'll look into it. so far i notice one difference: disabled items are missing tabindex=-1


Authentication authorization

Need to make this more user functional. Should be done 11/17

Loom recording of new functionality.
https://www.loom.com/share/835c4290baee41c584bdd0bed7f32419
Currently just using one secret key for encryption. Will update when there is more than us to make a secret key based upon a researcher

I'll ping you once I pass the codeql. not too sure why its failing since i added csurf.

Annoyingly you have to add csurf to every file explicity for codeql to detect csurf protection. Putting the middleware in different file and importing causes a fail state.

Sure, but will that make it more problematic to call from remote places (e.g., a locally running R script?)

Let's keep it unprotected for now. We can evolve it to have api keys but let's leave that for another issue.


fix: Remove period from list line in removing-sensitive-data-from-a-repository#about-sensitive-data-exposure

Why:
This PR removes the missing period in this page: https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/removing-sensitive-data-from-a-repository#about-sensitive-data-exposure
Closes:
#34106

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

[x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[x] For content changes, I have completed the self-review checklist.

@shashwatpathak98 Thanks so much for opening a PR with this fix! I'll update the branch and get this merged once tests are passing 🍏


Is it possible to start the download in another tab?

What is the purpose of your issue?

[ ] Feature request (request for a new functionality)
[ ] Question

I am using OSX + iterm.
Is it possible that when I start a download, it happen in a new tab? Sometimes, I want to add another download and I have to wait for the existing one to complete.

Run it in another tab and in will download in another tab.


Bug: erratic robot response over serial when random pattern control is long-running

Expected Behavior
Outputs should be smoothly controlled regardless of runtime/length.
Current Behavior
User reports that if leaving Sine/Random running for a long enough period of time, the device will occasionally pause and later jump to another position
Possible Solution
TBD
Steps to Reproduce (for bugs)

Connect mosa web UI to OSR output by web serial.
Run the random program for a few minutes.

Context
This is a blocker for use of the random output control
Your Environment

Version used: latest on trymosa and master locally
Browser Name and version: Latest Chrome Version 86.0.4240.111 (Official Build) (64-bit) with the experimental flag enabled
Operating System and version (desktop or mobile): Windows 10

unable to reproduce this locally but will try reimplementing the random control with a different design to address some concerns about efficiency and command volume.

user has mentioned that they are unable to reproduce this issue with the new stroke implementation and no other reports of this issue have come in. Closing this issue for now.