Training details about HO3D

Hi, Hasson,
Thanks for your great work!
Could you be kind enough to share the training args when train the meshreg on HO3D dataset.
as well as the pretrained model (of HO3D)
Thanks 👍

Hi !
Could you clarify exactly which models you are referring to ?
Given that the early version of the HO3D dataset which I used for the paper is not publicly available, I do not currently plan on releasing these models. I could however  release code/models which train on the official version of their dataset and which would provide results close to the one I submitted to https://competitions.codalab.org/competitions/22485?secret_key=756c1c8c-84ec-47ec-aa17-42f1fa330fb4#results. Would that be of interest to you ?
All the best,
Yana
Best,
Yana

Hi Yana,
Thanks for your clear response.
I noticed that the CodeLab challenge only contains metrics of hand.  (no  object corners)
I would like to ask whether you are planing to release the MeshRegNet full-trained model on  HO-3D official version.
All the best.
Lixin

2020年9月1日 17:52，Yana<EMAIL_ADDRESS>写道：
Hi !
Could you clarify exactly which models you are referring to ?
Given that the early version of the HO3D dataset which I used for the paper is not publicly available, I do not currently plan on releasing these models. I could however release code/models which train on the official version of their dataset and which would provide results close to the one I submitted to https://competitions.codalab.org/competitions/22485?secret_key=756c1c8c-84ec-47ec-aa17-42f1fa330fb4#results https://competitions.codalab.org/competitions/22485?secret_key=756c1c8c-84ec-47ec-aa17-42f1fa330fb4#results. Would that be of interest to you ?
All the best,
Yana
Best,
Yana
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/hassony2/handobjectconsist/issues/6#issuecomment-684690397, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHZIZBR74OCKLQGX7CE6PVDSDS75XANCNFSM4QA2LQ4Q.

Hi @lixiny
I just released a pre-trained model on the HO-3D official version which you can find here.
You can check the updated readme for more details !
Best,
Yana


[MXNET-386] API Docs Generation

Description
API docs generation (Write file). Create a file (an abstract class) that can be inherited to the API classes.
@nswamy @yzhliu
Checklist
Essentials

[x] API file generator
[x] Maven build integration
[x] Current API integration
[ ] Operational and test checking
[x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Add 1 line change in Sync with this PR: https://github.com/apache/incubator-mxnet/pull/11021


Add generic Smartcard API

Hi,
we would like to use your great project to communicate with german healthcare smartcards (insurant, practitioner, institution). Therefore it would be great to have a generic Smartcard struct with some basic APDU API.
Later on we can contribute more features, like APDU-Builder, MF/EF Files, Certificates etc, if you like.
Thank you

Thanx for fast reply. We'll check what you license allows and decide how to proceed.
Thanks again for great code!

@spilikin I would love to separate out the apdu interface from the piv-go code.
I added pgp support in a fork, and was considering doing exactly this to make the pgp support cleaner.
My fork is here: https://github.com/areese/piv-go


Unrocognized device issue: provide a way to interactively input e-mail verification code

Since a few hours, we receive this message when trying to use dcos-login v0.24:
error: Unexpected error:
 Unexpected Github response

It must be an issue with unrecognized device, since we received an email from github with a verification code right after this error.

A sign in attempt requires further verification because we did not recognize your device. To complete the sign in, enter the verification code on the unrecognized device.
Device: Go-http-client
Verification code: xxxxxx

Same.

Got something working, will issue a PR after cleaning. 😅

I implemented the interactive device validation but unfortunately, it seems that the validation is bound to the current session and not to the client IP address. That would implies to enter the validation code for each login, making the whole thing useless. 😞
One could store and use the session cookie to keep the session valid for 14 days, but it's not enough in most use cases. Sadly, I think there is no longer a way to use github to login to DC/OS without user interaction.
Just in case someone would be interested, here is the relevant code to interactively ask the user to enter the device verification code (that needs to be added to followLoginRedirect in login.go):
var verificationForm *goquery.Selection
doc.Find("form").Each(func(i int, s *goquery.Selection) {
	action, _ := s.Attr("action")
	if action == "/sessions/verified-device" {
		verificationForm = s
	}
})

if verificationForm != nil {
	fmt.Print("Device verification required, this is normally required only one time per device so subsequent \ncalls should be non-interactive on this device. Enter the code you received by e-mail:\n")

	reader := bufio.NewReader(os.Stdin)
	verificationCode, _ := reader.ReadString('\n')
	verificationCode = strings.TrimSuffix(verificationCode, "\n")
	q := url.Values{}
	verificationForm.Find("input").Each(func(_ int, input *goquery.Selection) {
		name, _ := input.Attr("name")
		value, _ := input.Attr("value")
		q.Add(name, value)
	})
	q.Del("otp")
	q.Add("otp", verificationCode)

	response, err := c.PostForm("https://github.com/sessions/verified-device", q)
	if response.StatusCode != 200 || err != nil {
		return nil, errors.New("Unexpected Github response during device verification")
	}

	doc, err = goquery.NewDocumentFromResponse(response)

	redirectURL, found := doc.Find(".container div p a").Attr("href")
	// Easy path, no re-authorization
	if found {
		return c.Get(redirectURL, nil)
	}
}

I've also stumbled upon this issue. Any suggestion ?

For the ones running on the same issue, I've taken the following approach:
Installed dcos-cli: https://docs.d2iq.com/mesosphere/dcos/1.12/cli/install/
dcos cluster setup <cluster_url>

Then
cos config show core.dcos_acs_token

to obtain the token an use it with curl.
The inconvenience in this approach is that we have to pre-setup the dcos cli with all the clusters beforehand. And this solution is not very scalable... also not so nice is the fact that if you bundle that in a docker image, once configured, the tokens will be stored in the image which is not so secure.
We liked dcos-login approach better, so if anyone is able to make that work, that would be appreciated.


Remove reference to PY2 and add testing to github actions

This closes #166

Removes references to PY2, since we only use python3
Removed the current test file and instead created tests in a new tests directory
Added test github actions workflow to use pytest to run the new tests
Created pytest.txt in requirements directory which is used for the github actions CI

@ThiefMaster what else is needed for PR to be merged?

I'm not a maintainer of flask-session
so i'll leave that up to @pallets-eco/flask-session
PS: check the red icon below some files in the PR diff view. that indicates those files do not have a trailing linebreak. this should probably be fixed...

@ThiefMaster I'm more than happy to ping the maintainer. When I look at contributors I only see those that commit to repo, but not the owner or those that have write access. Can you let me know how I can see that, and I'll ping them? I fixed the minor newline.

I pinged them in my last comment

Hi @darless and @ThiefMaster
Thanks for this great PR. It has made things much easier after the difficulty in merging #170. I tried merging this and #188  in a development branch based on the last release (rather than from that merge) to see if that was a better path. I think it has gone well, pending some testing. I believe the recurring issues related to writing empty sessions and unneeded overwrites may be resolved.
We would then somehow reset/revert main and then continue to cherry pick other features and fixes from flask-session2 as required, and as we understand them more fully.
In this attempt, I have opted for your Pytest implementation over the refactor done in #188. However, I am not very familiar with it and having issues with the error assertion as you can see in https://github.com/pallets-eco/flask-session/actions/runs/7419702330, would you be able to assist?

I was also thinking it would be great to have tests that cover "nothing" endpoints first, where session isn't set or modified, to confirm that no session is unnecessarily set as per #193 and others. What are your thoughts?


specify # of cores per node on pool creation to bring down costs

From my understanding of our Azure architecture, we have 2 different kinds of nodes that tasks may be run on: D32S Series or A4m series. The D32S series has 32 cores, while A4m has 4 cores. They change the price of jobs significantly depending on which one is used.
I think it would be a good idea to default to this A4m node type on calls to client.create_pool with an optional parameter for either 4 or 32 cores.
In terms of how to do this I would start looking in the AzureBatchManagement class, I found a couple of promising places in the docs. Specifically in the Pool class.
https://learn.microsoft.com/en-us/python/api/azure-mgmt-batch/azure.mgmt.batch.operations.pooloperations?view=azure-python#azure-mgmt-batch-operations-pooloperations-create
https://learn.microsoft.com/en-us/python/api/azure-mgmt-batch/azure.mgmt.batch.models.pool?view=azure-python
I think there is a spot to specify it here in your helpers.py specifically the vmSize key
https://github.com/CDCgov/cfa_azure/blob/a46345a639c35f8a169610ccb7f26317eed5efb8/cfa_azure/helpers.py#L1071-L1098

@arik-shurygin those are just the two options we happen to be using right now, and we may not want to limit ourselves to just them. See an introduction to the Azure VMs for an idea of the families (not even all the node types) that are available.

Thanks for the heads up @natemcintosh  I actually dug a little deeper and found that there is actually a parameter in our configuration tomls called pool_vm_size that holds the value of what node the pools should be constructed from. I agree with you that this value should not be hard-coded.
What I am suggesting is a less expensive default node. I think for many CFAers who many just want to plug and play cfa_azure to run jobs on batch a 32 core machine is overkill. Obviously if they need stronger nodes they should be able to easily request them. I find default behavior to be the one most often used, so it should be cheaper unless necessary.
I think this is just something those who hand out configuration files and keys should be aware of. I am running some more tests to see if the pool_vm_size parameter does what it says it does and that cfa_azure passes along the value correctly, I will likely close this ticket if thats the case.

Old Issue here but I think this can be closed now, azure cores and number can be specified via the AzureClient.set_scaling() command and in the config toml specifying the node type to have a certain number of cores, for example STANDARD_D8S_v3 for 8 core machines


aloneguid/storage#104 Enable aws.s3 connection strings without keyId/key

Also:

Fixed a couple xmldoc errors
Add AWSS3.SecurityToken, which is needed for the SDK to be able to assume roles

Fixes #104

You might want to update docs to explain how to use this.


Halo finder

Work related to #161.
Remaining items:

[x] Re-add verify() in the driver
[ ] Resolve whether atomics are needed for OpenMP
Both in representative() and flatten()
[x] Fix Properties... compilation issue
[x] Add brief comments in the code about the algorithm
[x] Cleanup code
[x] Migrate from benchmarks to examples

That's the proper replacement for it according to https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html. Otherwise, the code does not even compile for the Cuda versions we have on the CI tester.

I'm testing using 10.1. Are you saying that's too old?

I am not sure if that's the issue. Honestly, part of me pushing the two changes was just to see if that fixes running the testers.

I forced-push a fix that uses __shfl_sync the (hopefully) correct way, see https://stackoverflow.com/questions/46345811/cuda-9-shfl-vs-shfl-sync.

Does this pull request pass the tests for you locally?

Technically yes, but it probably does not really. I have not put the code to copy the input.txt file to the build directory, for example.

Cleaned up and rebased on master.

Implemented v2 of the halo finder.
Changes
v1 did the following steps:

Construct tree
Do queries producing (indices, offset)
Call ECL-CC on (indices, offset) producing ccs
Postprocess ccs

v2 changed it to

Construct tree
Do queries with callback producing ccs
Postprocess ccs

I was able to combine init and compute1 stages of ECL-CC algorithm and use them inside inline callbacks. The benefits are tremendous:

Single pass in radius search
We never call insert(), instead updating a single array
Drastic reduction in used memory
We don't store results and just use a single extra array
Code can be used with any backend

Results
Timings (ran on Summit login node):

Step
v1
v2

construction
0.11
0.11

query
8.21
3.35

ccs + halos
0.15
0.05

total
8.47
3.50

Speedup: 2.4x
Memory footprint
In v1 the memory was split as follows (for the HACC data with 37M points):

Type
v1 size (MB)
v2 size (MB)

tree
2252.36
<-

tree query results (csr)
6517.58
gone

ccs
140.77
<-

halos (csr)
52.03
<-

total
8962.74
2445.16

Memory reduction: 3.6x
Misc comments
I see very few downsides to the new implementation. There are couple areas in callback that could be examined in a bit more details (such as initialization), as initialization. There is also the fact that original ECL-CC implementation separated all nodes into three groups depending on the degree. However, here we can't do that as node degrees are not available.
From the maintenance point of view, the new code is more fragile. The reason for that is that we have no way to verify whether connected components were computed correctly, as we don't have access to a graph anymore. I guess I may need to restore the verify code just for the driver to have something to test against.
I did verify that this code produces the same results as v1 for the HACC data.

The v2 algorithm is based on the [1] paper. The general gist of the algorithm can be found on the second page and reads:
...the majority of the parallel CC algorithms are based on the following                                                                                “label propagation” approach. Each vertex has a label to hold the component ID
to which it belongs. Initially, this label is set to the vertex ID, that is,
each vertex is considered a separate component, which can trivially be done in
parallel. Then the vertices are iteratively processed in parallel to determine
the connected components. For instance, each vertex’s label can be updated with
the smallest label among its neighbors. This process repeats until there are no
more updates, at which point all vertices in a connected component have the
same label. In this example, the ID of the minimum vertex in each component
serves as the component ID, which guarantees uniqueness. To speed up the
computation, the labels are often replaced by “parent” pointers that form a
union-find data structure.

Union-find algorithm is sped up through path compression:
Starting from any vertex, we can follow the parent pointers until we reach a
vertex that points to itself. This final vertex is the “representative”. Every
vertex’s implicit label is the ID of its representative and, as before, all
vertices with the same label (aka representative) belong to the same component.
Thus, making the representative u point to v indirectly changes the labels of
all vertices whose representative used to be u. This makes union operations
very fast. A chain of parent pointers leading to a representative is called a
“path”. To also make the traversals of these paths, i.e., the find operations,
very fast, the paths are sporadically shortened by making earlier elements skip
over some elements and point directly to later elements. This process is
referred to as “path compression”.

ECL-CC makes use of an intermediate pointer jumping:
Intermediate pointer jumping only requires a single traversal while still
compressing the path of all elements encountered along the way, albeit not by
as much as multiple pointer jumping. It accomplishes this by making every
element skip over the next element, thus halving the path length in each
traversal.

This is encoded in representative() function.
[1] Jaiganesh, Jayadharini, and Martin Burtscher. "A high-performance connected components implementation for GPUs." In Proceedings of the 27th International Symposium on High-Performance Parallel and Distributed Computing, pp. 92-104. 2018.

Per @dalg24's request:
Comparing query time:
Full callback (i.e., constructing stat): ~3.4
No-op callback: ~3.8
That's pretty funny. No idea why. Does it diverge less?

I addressed all issues other than the question of whether atomics are required for OpenMP backend. Please review.

OpenMP seems to produce correct results even without atomics.
However, timings are interesting:

Step
Cuda
OpenMP

construction
0.11
1.60

query + ccs
3.39
16.14

halos
0.05
70.44

It is certainly advisable to look at the postprocessing in more details, as there is something really not digestible for OpenMP there.

For me, it's OK to keep this is examples but we should provide some documentation, maybe in the form of a README.md.

For me, it's OK to keep this is examples but we should provide some documentation, maybe in the form of a README.md.

@masterleinad What kind of documentation do you envision?

@masterleinad What kind of documentation do you envision?

Something like
This example shows how ArborX can be used for ... The implementation follows the paper ...
The program expects as input file in the following format: ...
An example is given in "examples/halo_finder/input.txt". This case describes ...
Hence, we expect to see ... and this matches with the output when running the executable with that file as input.

@masterleinad I put some documentation in. It should be sufficient for now.

retest this please

@dalg24 Thanks for the review. I'll address your comments, but the main thing is that I still don't understand why PGI build fails:
"/var/jenkins/workspace/ArborX_PR-237/test_install/examples/halo_finder/ArborX_

          HaloFinder.hpp", line 15: catastrophic error: cannot open source file

          "ArborX_DetailsSortUtils.hpp"

  #include <ArborX_DetailsSortUtils.hpp>

Should be ready.


🚀 - New utility maskitoUnmaskNumber

Which package(s) are the source of the bug?
@maskito/angular
Please provide a link to a minimal reproduction of the bug
https://stackblitz.com/edit/angular-7qqzas
Description
Press "Log value"
Expected Result:
1234 in console
Actual Result:
1 234 in console
Maskito version
0.4.0
Which browsers have you used?

[X] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge

Which operating systems have you used?

[X] macOS
[ ] Windows
[ ] Linux
[ ] iOS
[ ] Android

Actually i'm using my own directive with @maskito and found a workaround:
constructor(private elRef: ElementRef, private ngControl: NgControl) {
    const original = this.ngControl.valueAccessor!.registerOnChange;

    this.ngControl.valueAccessor!.registerOnChange = (fn: (_: unknown) => void) => {
      return original.call(this.ngControl.valueAccessor, (value: unknown) => {
        if (typeof value !== "string") {
          return fn(value);
        }

        const parsedValue = parseFloat(value.replaceAll(this.thousandSeparator, ""));

        if (Number.isNaN(parsedValue)) {
          return fn(null);
        }

        return fn(parsedValue);
      });
    };
  }

But once you start typing any value in the input, it would become a string anyway. It's the responsibility of the component to interpret this string as number and store it as number in control. That said, we should definitely help with that, maybe provide a maskitoUnmaskNumber(formatted: string): number utility or something like that.

Within this issue we need to create this simple utility:
export function maskitoUnmaskNumber(maskedValue: string, decimalSeparator: string): number {
    return Number(
        maskedValue
            .replace(new RegExp(`[^\\d\\${decimalSeparator}]`, 'g'), '')
            .replace(decimalSeparator, '.')
    );
}

maskitoUnmaskNumber('1 000 000,37', ',') // 1000000.37

Within this issue we need to create this simple utility:
export function maskitoUnmaskNumber(maskedValue: string, decimalSeparator: string): number {
    return Number(
        maskedValue
            .replace(new RegExp(`[^\\d\\${decimalSeparator}]`, 'g'), '')
            .replace(decimalSeparator, '.')
    );
}

maskitoUnmaskNumber('1 000 000,37', ',') // 1000000.37

What about a custom thousand separator?

What about a custom thousand separator?

RegExp above will deal with any custom thousand separator :)


[BUG] App does not resize when opened from a monitor different from the one it closed in

When I close the app in monitor B after resizing, and then open the app from monitor A, the app opens up on monitor B in the same position except it does not get resized. When I open the app from the same monitor as the monitor I closed the app in, the resizing works as expected even after closing the window that was not resized.
App source (please do not use the provided binary) https://github.com/elibroftw/google-keep-desktop-app
Screenshots of Behaviour
Window in right monitor before close

Opening app from left monitor

Window opens up right monitor but not resized

Closed the window and now opening it from the right monitor

Window appears properly resized even after being closed with the wrong size

maybe a regression of https://github.com/tauri-apps/tauri-plugin-window-state/commit/2f4cd57b1e7544155484faab769c91c4bf25120e could you try the size-pos-order branch and see if it is fixed?

Seems like it can't be solved, the problem is that set_size will scale the size passed to it based on the scale_factor stored on the Window instance.
In this case, calling set_size right after set_position, the scale_factor will contain the scale factor of the monitor that launched the app because the OS still hasn't emitted the new scale factor so set_size will read the wrong value.
The only way this could be solved is if Tauri exposed a way to modify the WindowBuilder right before creating the window. cc @lucasfernog.
I think this could be possible in tauri v2, because it will require creating windows while the event loop is running so tauri can theoretically pass a mutable reference to the event loop which plugins can modify.

Is there no way for a single measurement independent of scale factor? Or at least assimilate this plugin into core since it's such a basic requirement imo.

@elibroftw Can you test the latest changes in the dev branch, I changed the handling to save/restore logical sizes and it may have solved this issue too.

The size does remain the same but now the position isn't always the same but it's not a bother so I'm happy.

Can you show me how off the position is?

Same behaviour but now the window also shows up in the default position and size before resizing and moving

I'm not sure if that new bug is caused by the plugin or something on my end though since I even used yesterday's revision and couldn't undo the bug

This information may be useful

You should also be aware that the coordinate system for window placement is not screen coordinates, but rather workspace coordinates. The consequence of getting this wrong is that your window creeps up (or to the left) over time, eventually getting itself stuck underneath the taskbar.

https://stackoverflow.com/questions/29747238/how-to-convert-workspace-coordinates-to-screen-coordinates

Same behaviour but now the window also shows up in the default position and size before resizing and moving
I'm not sure if that new bug is caused by the plugin or something on my end though since I even used yesterday's revision and couldn't undo the bug

The last commit in the dev branch was related to visibility. Try the commit before it or something.

Also make sure you have your window visible: false in tauri.conf.json (or in your app code if using the programmatic API).

The size does remain the same but now the position isn't always the same but it's not a bother so I'm happy.

Since I don't have a multi-monitor setup. I tested the following:

open the window on my monitor 1920*1080
move the window around, resize it and close it
change my monitor resolution in 1400*1050
open the app and the window spawned in the correct position with the correct size

I think maybe what you are experiencing is that because one of your monitors has a bigger resolution, it may seem to you that it is not the same position. For example, if your window position is 100px away from the left, on the smaller monitor this is a huge gap but on the bigger monitor it may seem way smaller because there are more pixels.
To confirm this, maybe log the position of the window before you close it and then log it again once you open it on the other monitor.

Please do not invalidate my experience when I posted screenshots of said behaviour. https://github.com/tauri-apps/tauri-plugin-window-state/issues/45#issuecomment-1306549972
It's not in my head, that's the screenshot of the same monitor, I didn't include the second monitor since it was not relevant, but I will include the second monitor here for proof that the window is on the same monitor.
Opening the app from my right monitor:

Opening the app from the left monitor:

Here are the position values when I open the app from left monitor and then the right monitor.
// left
innerPosition: {"type":"Physical","x":574,"y":297}
outerPosition: {"type":"Physical","x":566,"y":266}
// right
innerPosition: {"type":"Physical","x":385,"y":208}
outerPosition: {"type":"Physical","x":377,"y":177}

As you can see the position is not as expected.

Please do not invalidate my experience when I posted screenshots of said behaviour. https://github.com/tauri-apps/tauri-plugin-window-state/issues/45#issuecomment-1306549972

It was not my intention at all.

It's not in my head, that's the screenshot of the same monitor, I didn't include the second monitor since it was not relevant, but I will include the second monitor here for proof that the window is on the same monitor.

That's my bad, thought the position felt wrong for you because I assumed you closed the app on One monitor and tried to open it on the other when the first monitor is disconnected.

Here are the position values when I open the app from left monitor and then the right monitor.
// left
innerPosition: {"type":"Physical","x":574,"y":297}
outerPosition: {"type":"Physical","x":566,"y":266}
// right
innerPosition: {"type":"Physical","x":385,"y":208}
outerPosition: {"type":"Physical","x":377,"y":177}

As you can see the position is not as expected. Yes my monitors are different resolutions, however Microsoft TODO does not face this bug.

That's expected since it is physical position, can you try converting them to logical? Also if possible record the position right before closing the window the first time and compare it with the value stored in .window-state file

Where is the .window-state file in for debug?

it is stored in C:\Users\<username>\AppData\Roaming\<bundle-identifier>

Also how do I read the .window-state file without running code?

ah maybe you need to clone this plugin and add some println! to see the values when they are loaded

I decided to just read the source code and figure it out.
https://github.com/tauri-apps/tauri-plugin-window-state/blob/dev/src/lib.rs#L116
This is the problem, I think we should use the scale factor from the monitor from the for loop, not the current monitor.

nvm

I'll fork and figure it out myself

The bug is wherever the processing code of set_position is. I just saved the logical position on my right monitor, moved the window to the left monitor and called set position using the logical position I saved and the window had a major offset

setting position via physical position seems to work.

Also, why bother setting a position if there was no position saved? Shouldn't we just let the OS decide how to position the window if there's no position save state?

I fixed the issue in my repo, but I also found that if you maximize the window, close the window, and then open the app from the other monitor, the window does not maximize as expected.

I'll try fixing that too since I think I got the hang of this now

Can you see if saving the physical position fixes the position issue? use size-physical branch to test it out.

but I also found that if you maximize the window, close the window, and then open the app from the other monitor, the window does not maximize as expected.

I think there is already another issue open for this.

Saving the physical does fix the position, it's in my fork.

if it's an issue already I'll open a PR to close this issue at the very least

Saving the physical does fix the position, it's in my fork.

Yeah, I took a look at it, but you have other changes there that I think is unneeded so if you can confirm that changes in size-physical branch is enough, I will go ahead and merge it and close this issue.

Can you take a look at it now? It does the physical size and it removes using (100, 100) as a fallback


Support in-app based social verification

@e4drcf will provide endpoint details
https://github.com/lbryio/lbry-verification.go/pull/4/files

This will deprecate https://verify.lbry.com/

Discord verification is no longer a step. User is presented with option for social media verification. User must link two accounts.
Endpoints and the necessary feedback systems for the status of the verification process may be missing. Please raise with internal API team any changes required to support this flow end-to-end.

Issue moved to OdyseeTeam/odysee-frontend #30 via ZenHub


support URLSearchParams as data

axios supports passing a URLSearchParams object as data, when you need a post with "application/x-www-form-urlencoded".
curlirize prints an empty data object in the console.

I think is more or less related with this, in Nodejs v12.13.0  sending json in params field appears like this:
...
"curlCommand": "curl -X GET -H \"Authorization:Bearer xxxx\" \"http://localhost:3000/api/api-path?createdAt=[object Object]
...


Fix AFImageWithDataAtScale destroying animation images

AFImageWithDataAtScale destroys animated UIImages because initWithCGImage only uses the first frame.  This patch fixes the issue, though perhaps there is some way to scale each individual frame which would could be a huge CPU/mem drag.

Merged with fe0ddd06d8ad7d957c0e60cc9a3fff65d8c260b9. Thanks, @petrocket.


Improve definitions for Linux keyrings syscalls

Perfect! Thanks!
I see the commits are executed with cleanly.
I only have a small concern about reqkey_auth_key.

Thanks!


chore: remove compatibility with old pipeline SA

STONEBLD-1415
Title says it all.

Looks like that's it.


Make the logging interface slightly more usable

Nice. I have often forgotten to supply an array, to much confusion. A few things to look at before it's ready.

Comments from the review on Reviewable.io
Reviewed files:

src/logging/logging.spec.ts @ r2
src/logging/logging.ts @ r2

Nice to see energy on making logging better!
The use of switch and also the ability to use nary arguments instead of lists is good.
Probably want a try/catch around JSON.stringify.
Also: lets force a log statement to have at least one argument according to its type.
Don't use any type when you can use Object (for logging arguments, we only require them to be Object, and I think that's better, it's equivalent, I believe to the {} type.).

src/logging/logging.ts, line 63 [r2] (raw file):
Not sure we want to allow a debug call with no arguments.... ?
Maybe  a better type is: (msg: string, ...args:any[]) :void ?

Comments from the review on Reviewable.io

src/logging/logging.ts, line 63 [r2] (raw file):
Actually, (msg: Object, ...args:Object[]) :void is better. :)

Comments from the review on Reviewable.io

:+1:

src/logging/logging.ts, line 28 [r3] (raw file):
nit: i think the cast has no effect here

Comments from the review on Reviewable.io

src/logging/logging.ts, line 28 [r3] (raw file):
Correct, it was needed to silence Typescript though.


Importing Material Module

I want to know why import the MateriaModule module both into CoreModule and into AppModule? Why not add it to the CoreBundle module exports  and remove it from AppBundle?
Thanks

Hello @bilel-noomene,
CoreModule only exports components from it's own module, and the main reason to use exports is to allow other modules to import what you are exporting.
So, MaterialModule should be imported in every module that use angular material components. You have more info here.

@bilel-noomene thinking about this, I've made a change to only import MaterialModule in one point (SharedModule), and export it in that module because every module should import SharedModule...

Thank you @Ismaestro.
In this case, will it be more consistent to place MaterialModule under the shared folder?

@bilel-noomene Of course, done.


How to save hypergbm as PMML file?

There is not plan to support PMML now, python pickle  is recommended to store/load trained HyperGBM Model.


start fixing training memory estimation

not done yet
see #85

left to do:

[ ] pq estimation: clearly not right, it's not just 4 bytes total for PQ4
[ ] ivf estimation: it's more than just centroids and vectors, there is some additional memory usage
[ ] check with some tests

a possible short term solution would be to over estimate a bit opq + pq + ivf training by saying it's number of training vectors * 2

Closing because I can't push on this branch now
Will reopen from a fork

Indeed, pq estimation is incorrect, it should multiply by the number of training vectors like:
ceil(self.params["pq"] * self.params["nbits"] / 8) * nb_training_vectors
what do you think ?
I will look into for ivf estimation.


SPFx app not showing up in the webpart list

Thank you for reporting an issue or suggesting an enhancement. We appreciate your feedback - to help the team to understand your needs, please complete the below template to ensure we have the necessary details to assist you.
Category

[ ] Question
[ ] Typo
[x] Bug
[ ] Additional article idea

If you are planning to share a new feature request (enhancement / suggestion), please use SP Dev UserVoice at http://aka.ms/sp-dev-uservoice.

Expected or Desired Behavior
Upon installation of the app, it should create a list and i can add the webpart to the pages as well
Observed Behavior
The list is being created as i install the app, but when i try to add the app to my page, the app is not showing up in the list of the available apps.
Steps to Reproduce

Install the app
The list provisioned
add webpart to page
the app is not listed

This is my package-solution.json
{
  "solution": {
    "name": "our-applications-client-side-solution",
    "id": "c23661a1-50a2-4b69-b8f2-9b7a7a5db2b1",
    "version": "<IP_ADDRESS>",
"features": [
      {
        "id": "49280240-2932-4868-b668-19361475ac9b",
        "title": "Our Applications Web part feature",
        "description": "A feature which activates the Client-Side WebPart named Our",
        "version": "<IP_ADDRESS>"
      },
      {
      "title": "our-applications-client-side-solution",
      "description": "our-applications-client-side-solution",
      "id": "523fe887-ced5-4036-b564-8dad5c6c6e24",
      "version": "<IP_ADDRESS>",
      "assets": {
        "elementManifests": [
          "elements.xml"
        ],
        "elementFiles":[
          "schema.xml"
        ]
      }
    }]
  },
  "paths": {
    "zippedPackage": "solution/our-applications.sppkg"
  }
}

Hello, I encountered a similar problem.
I deployed a first version of my SPFx projects with <IP_ADDRESS> version. I could see my web parts without any problems.
After that, I wanted to upgrade my version to <IP_ADDRESS>. I'm upload my sppkg to catalog and I can see the update of its version on sharepoint. But, when I refresh my page I don't see my webparts !!!
After some tries, I founded a solution but it's not really very good ! I changed the solution ID when I increment my version (package-solution.json), I delete the old package and I upload the new solution with new ID and new version. With this way, I can see my webparts on the page.
Do you have any idea, why upgrading solution version doesn't work ?

Yes, this is a known issue. It should have been fixed with our rollout to 1.4.1.  Please see issue https://github.com/SharePoint/sp-dev-docs/issues/775 for details.

How can I do when we I have to upgrade sppkg with app installed in many sub-sites ? I have to delete, re-install app manually ?

@mimosa803 - unfortunately that is true... you can also programatically do it using our ALM API... but it has to be done in each web that you are using the SPFX solution.

#775 This issue is related.

This bug happened again on latest spfx 1.9.1 .

Yes I am facing the same issue in spfx 1.9.1

Also facing the same issue with 1.9.1

I think there is something broken in my E3 developer tenant. When I go into the admin center and go to the apps section in settings and then go to the catalog creation page in my E3 tenant I can create another appcatalog. In my E5 tenant when I go the the app section and go the the appcatalog link I am redirected to my appcatalog


feat: port MeasureTheory.Measure.MeasureSpace

This PR also renames instances in MeasureTheory.MeasurableSpace.

 Happy coding!

This PR/issue depends on:

leanprover-community/mathlib4#3351
leanprover-community/mathlib4#3349
leanprover-community/mathlib4#3800
leanprover-community/mathlib4#3816
leanprover-community/mathlib4#3325
leanprover-community/mathlib4#3674
By Dependent Issues (🤖). Happy coding!

Thanks
bors merge


Remove remaining usages of CotangentVector and tangentVector(from:).

https://github.com/apple/swift/pull/24825 follow-up.

@swift-ci Please test tensorflow


Please allow contain children

Please allow contain children, Thank you!

Children support was a feature deliberately removed in this commit to keep the API close to that of  and potentially other reasons.

We could add a ImageBackground Component. (https://facebook.github.io/react-native/docs/images.html#background-image-via-nesting)
In the meantime you can implement your own based on https://github.com/facebook/react-native/blob/8547b7e11163d545b7b99d4bdd063ef71129d62c/Libraries/Image/ImageBackground.js

It supports children now. I was sort of flip flopping on how exactly to implement it for a bit.

Hello,
the problem is that "justifyContent style" does not work for children.
I want to display children at the bottom of the image background by setting justifyContent : "flex-end", but it is not taken into account.
Do you know why ?
My code:

@subhamagr  I did not find any solution ...

Any updates on this?

@appli-intramuros, @subhamagr, justifyContent: 'flex-end' is working for me

The 2023 solution should be
import React from 'react';
import {StyleSheet} from 'react-native';
import FastImage from 'react-native-fast-image';

const ImageBackground = props => {
  const {children, style} = props;

  return (
    <FastImage {...props} style={[StyleSheet.absoluteFill, style]}>
      {children}
    </FastImage>
  );
};

export default ImageBackground;


Fixing typo for graph endpoint

@archieag changed to https://graph.microsoft.com instead of https://www.graph.microsoft.com.

lgtm @aiwangmicrosoft


is it need a better name?

What problem does this feature solve?
export function effect<T = any>(
  fn: () => T,
  options: ReactiveEffectOptions = EMPTY_OBJ
): ReactiveEffect<T> {
  if (isEffect(fn)) {
    fn = fn.raw
  }
  const effect = createReactiveEffect(fn, options)
  if (!options.lazy) {
    effect()
  }
  return effect
}

this function name and return value name is same
It can cause some confusion and make it difficult to read the code
What does the proposed API look like?
don't know

This is not a valid feature request, thanks.

This is not a valid feature request, thanks.

sorry
So what does this thing belong to and how should it be pushed forward

If you don't have enough reasoning behind this, we'll just keep it as-is. If you are suggesting a change of the public API, you should create an RFC for it.

@Justineo I think he doesn't want to change the public API. He is pointing to the line with:
  const effect = createReactiveEffect(fn, options)

Because the function name is also called effect it looks like tail-recursive call.
Solution should be to use different variable name for the effect, eg. reactiveFffect.
The interface with options is also called ReactiveEffectOptions and not EffectOptions.

@sionzeecz  thanks
I think they are the same cause of confusion and there should be a better name to distinguish them

such as
const effectInstance = createReactiveEffect(fn, options)


Unifies toString()

Current coverage is 97.09% (diff: 97.70%)

Merging #1768 into master will increase coverage by 0.08%

@@             master      #1768   diff @@
==========================================
  Files            87         87
  Lines         11200      11195     -5
  Methods           0          0
  Messages          0          0
  Branches       1863       1862     -1
==========================================
+ Hits          10865      10870     +5
+ Misses          212        203     -9
+ Partials        123        122     -1

Powered by Codecov. Last update fd3bb08...85f1568

Note: I marked it as backward-compatible-relevant because the behaviour of Tree.toString changed.


Database backed sessions with session rotation with many requests causes session to lose data

Steps to reproduce:

Add data to session such as person_id = 1 with the settings below for config.php
Refresh page repeatedly by holding down cmd + R (or ctrl + R) on windows
Notice that you are logged out  due to some sort of race condition as person_id = 1 is NOT available in session anymore.

It is my understanding that this should not happen due to session locking; but it does appear to come up against a race condition because during session rotation their could be 2 different locks and it allows for non blocking actions.. my reason for making the sess_time_to_update so small is so I can easily reproduce issue. This doesn't seem to happen when sess_regenerate_destroy is FALSE: but in theory it could still happen in php garbage collection takes over; although probably very rare.
config.php settings
$config['sess_driver'] = 'database';
$config['sess_cookie_name'] = 'phppos';
$config['sess_expiration'] = 0;
$config['sess_save_path'] = 'sessions';
$config['sess_match_ip'] = FALSE;
$config['sess_time_to_update'] = 1;
$config['sess_regenerate_destroy'] = TRUE;

mysql_general_log:
https://www.dropbox.com/s/ybsa5eo1bmmv44l/sessions_general_log.txt?dl=0

There's no bug here ...
This is where you lose the data (GET_LOCK(), RELEASE_LOCK() queries obviously stripped):

		   40 Query	SELECT `data` FROM `phppos_sessions`WHERE `id` = '61859a28c2d08b95db0be41e97f37f974e2b2fc4'
		   40 Query	DELETE FROM `phppos_sessions` WHERE `id` = '61859a28c2d08b95db0be41e97f37f974e2b2fc4'
		   41 Query	SELECT `data` FROM `phppos_sessions` WHERE `id` = '61859a28c2d08b95db0be41e97f37f974e2b2fc4'

		   --- irrelevant queries ---

		   41 Query	INSERT INTO `phppos_sessions` (`id`, `ip_address`, `timestamp`, `data`) VALUES ('61859a28c2d08b95db0be41e97f37f974e2b2fc4', '<IP_ADDRESS>',<PHONE_NUMBER>, '__ci_last_regenerate|i:1445995775;')

		   --- irrelevant queries ---

		   40 Query	INSERT INTO `phppos_sessions` (`id`, `ip_address`, `timestamp`, `data`) VALUES ('3b6824196f25dbd4e1ad7173858598fa882a2297', '<IP_ADDRESS>',<PHONE_NUMBER>, '__ci_last_regenerate|i:1445995775;person_id|s:1:\"1\";')

		   --- queries from connections 40, 42-51 ---

You're simply running simultaneous requests using the same session, either because of AJAX usage or because you're reloading the page while it is still executing.
The request that got control/lock for that session first (connection 40) regenerates the session - deletes the old one at the start of the request, creates a new one at the end of the request. Then another request (connection 40) plugs in as soon as the lock is released (after the DELETE) and tries to read the data for the same session that just got deleted, resulting in it having no data in the session.
If those were non-simultaneous requests, the second one (with connection id 41) would've had the new session ID and so would've read the newly-created session, but because they are simultaneous, there was never a chance for that to happen.
This race condition is unavoidable, that's exactly why 'sess_regenerate_destroy' is configurable instead of forced to TRUE.


What's the cookie_value in Session using for ?

Why the cookie_value is not cloned or serialized, I can't get the point of doing this. Can someone explain why we should have this field, and make it not cloned or serialized. Thanks a lot. 😂

cookie value is what is stored in the cookie, which may be either a unique identifier or the full encrypted value of the cookie, depending on the session store's implementation. https://docs.rs/async-session/3.0.0/async_session/struct.Session.html#cloning-and-serialization It is removed on clone in order to keep from accidentally persisting it in the session, and the only way to retrieve the cookie value is to consume the session, ensuring that this is only done by the framework that owns the "original" (pre-clone) session that was either retrieved from a session store or created for the current request. For datastore-based session stores (everything except the cookie store), we do not store the cookie value anywhere, and the lookup key is a sha256 hash of that cookie value. This ensure that if anyone compromised the session store database, they would not be able to generate a cookie. There is exactly one copy of the cookie value, and it is no longer available anywhere server-side once the set-cookie header has been assigned.

Are you writing a framework implementation of async-session, a session store, or using async-session with an existing framework implementation? The cookie value should not be available to framework users.

Yeah, I'm implementing my own postgresql session store because I'm currently using diesel instead of sqlx, so I want to prevent introducing a new db lib. And I'm integrating it into axum, I found that cookie_value will not be serialized.
I found this because the cookie_value will not be set if only deserialized from previously-stored JSON (and by reading the code). Then I think I should use the set_cookie_value to set the cookie_value by myself after retrieving it from the database? 🤔

If you want a security review, please open an issue here once it's open source. You may want to reference the warp or tide implementations for comparison. You should not need to set cookie value ever

Thanks again, I'll reference the tide implementations😄 .


Merge 3.0.2 to civis branch

This worked in staging

FWIW - it looks like the last two commits to README.md are unreleased on master. Still want to to merge this in as part of v3.0.2?
Comparing v3.0.0 to v3.0.2
https://github.com/tinfoil/devise-two-factor/compare/v3.0.0...v3.0.2
Comparing v3.0.0 to master
https://github.com/tinfoil/devise-two-factor/compare/v3.0.0...master


Set default Rust version when testing sdist

Test Plan
See: https://github.com/charliermarsh/ruff/actions/runs/5193203293/jobs/9363428303.

\cc @konstin


KOGITO-8696: [SWF Editor] Add support to Camel routes in Service Catalog

Hello,
Please review this PR which includes support to Camel routes in Service catalog.
Epic link: https://issues.redhat.com/browse/KOGITO-8324
JIRA issue: https://issues.redhat.com/browse/KOGITO-8696

@Sara4994 Can you please add a short gif/video to the PR description to show off this new feature?

https://user-images.githubusercontent.com/40579476/223709311-0bc0a36b-1d92-42c1-9f79-8cd58b23d617.mp4

@caponetto yep, here it is :)
https://user-images.githubusercontent.com/40579476/223709834-ec418c40-7f8f-4392-9cf9-0b86fa6b729c.mp4

I'll be on PTO for the next few weeks, so I'm refraining from reviewing this PR. Feature-wise looks exactly like what we were talking about. Many thanks!

I found two issues:

If a camel route file is added to the routes directory, it does not appear in the list of available functions after + Add function is clicked. VS Code needs to be restarted and then the function is there
+ Add function list displays the routes as [specsDirName]>> but there should be [routesDir] name instead

@tomasdavidorg Thanks for pointing these bugs, really good catch. these are fixed now 👍


Possible bug in break_up_space

Correct me if I'm wrong, but in the break_up_space method, shouldn't matching dimensions be added and subtracted?
For example: https://github.com/mushishi78/box_packer/blob/d840a56955f9e252860dc064f90d86592c3d9573/box_packer.rb#L92-L94
Shouldn't this rather be
 space[:dimensions][0] - placement[:dimensions][0],
 space[:dimensions][1],
 space[:dimensions][2]

I created a pull request, but it has an additional change that may not be desired behaviour.

You've got a point. I really should have written some better tests before I did a rewrite. The original used overloads to do vector math and this confused me when copying it over. Would probably be preferable to have a separate PR for the bugfix if possible. Thanks a lot.


D interface files are not passed as source file

For example if a .di stands in source/ it won't be passed as the other source files.
This case happens when one links an object file with dflag and that the object content is interfaced with a D interface.
Example:
http://code.dlang.org/packages/dbeaengine
In this package I had to add explicitly the di file, even if it stands in a folder specified in sourcePaths.

Does anyone knows where d sources are filtered ?
The only results I get seem unrelated:
/dub/compilers/compiler.d(401,48): "auto path = getTempFile("dub_platform_probe", ".d");"
/dub/generators/visuald.d(149,56): "if (!buildsettings.sourceFiles.any!(f => f.endsWith(".d"))())"
/dub/generators/build.d(199,82): "buildsettings.sourceFiles = buildsettings.sourceFiles.filter!(s => !s.endsWith(".d"))().array();"
/dub/generators/build.d(535,63): "foreach (f; ["source/app.d", "src/app.d", "source/"~prj.name~".d", "src/"~prj.name~".d"])"
/dub/generators/build.d(535,85): "foreach (f; ["source/app.d", "src/app.d", "source/"~prj.name~".d", "src/"~prj.name~".d"])"
/dub/dub.d(386,63): "custommodname = custom_main_file.head.toString().baseName(".d");"
/dub/dub.d(391,23): "if (file.endsWith(".d") && Path(file).head.toString() != "package.d")"
/dub/dub.d(396,49): "Path mainfile = getTempFile("dub_test_root", ".d");"
/dub/dub.d(892,26): "else ret ~= p.baseName(".d");"

This is the relevant place: https://github.com/D-Programming-Language/dub/blob/c5935829500dac1b6a2e5aa0dd628a3a694ab75c/source/dub/recipe/packagerecipe.d#L200
It would be interesting to clarify how this is supposed to behave from a spec point of view. Usually every .di file has a corresponding .d/.obj file which is linked together with the application somehow, so that it is not necessary, or even harmful (multiple definition linker errors), to also compile/link the .di file. If you have original content in the .di file, it should probably instead just get the .d extension, since .di files are not even required to be supported by the compiler at all (see here).
Note that .di files can also be included using a glob expression, if many are present: "sourceFiles": ["interface/*.di"]

my point of view is that if a .di stands in one of the source, src or sourcePaths folders then it should be included automatically. It's  a rare case but if someone puts it intentionally in one of these folder then he certainly wants it to be passed to the compiler.
Now the fact is that DUB doesn't allow to pass object or static library files directly (https://github.com/D-Programming-Language/dub/issues/591) and that .di files always go in pair with something like that.
In short the specification would be simple:

if a D interface file resides in one of the X,Y,Z folders then it'll be passed to the compiler. In case of name conflict, only the .d file will be passed.


Switch to codecov

Makes the actions a bit simpler, and I think the interface is nicer...

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@ba957ea). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #12   +/-   ##
=========================================
  Coverage          ?   80.11%
=========================================
  Files             ?       10
  Lines             ?      543
  Branches          ?        0
=========================================
  Hits              ?      435
  Misses            ?      108
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba957ea...b172692. Read the comment docs.

Honestly, when trying to browse the coverage, I feel that codecov looks like a huge step backwards.  Looks pretty but nothing seems to work.


Fixed #30913 -- Added support for adding non-key columns to indexes

Ticket: https://code.djangoproject.com/ticket/30913

@hannseman BloomIndex was added in #12004 which has now been merged. Could you also add the self.include check to BloomIndex.check_supported() as covering indexes are not supported there either. Thanks.

@hannseman Could you please go through the last assertLess and assertIn cases, to collapse them to possibly use assertEqual instead? And then squash the commits. The ticket is already in the review queue.

@atombrella many thanks, totally missed those assertLess and assertIn  that were left.
Squashed the commits and kept https://github.com/django/django/pull/11991/commits/132278b424b03f18bf81b1d2fa50d1c556df9c40 as a separate commit as requested in https://github.com/django/django/pull/11991#discussion_r340668028.

@hannseman Can you add a system check for non-local/invalid field names in include? (calling _check_local_fields() on include should be enough, see 3c7bf39e23fe9168f31132d929c9877c5835859b).

@felixxm Thanks for your fixups!

I pushed edits to docs.

I added system checks for covering indexes and unique constraints support.

buildbot, test on oracle.

@felixxm @charettes @atombrella @pope1ni @carltongibson many thanks for your reviews!


changes for input/output instead of subject/object

Help solve this issue

Closing as feature update has been rolled into #41


"OverlappingSelectors" fleet condition is misleading

I set-up two fleets:

eu-east-prod-001: This fleet has a  first-label=east label
eu-west-prod-001: This fleet has a second-label=west label

Then I created an enrollment request, and approved this with the labels:
first-label=east and second-label=west
The device was correctly given the annotation for MultipleOwners and the two matching fleets are included on it.
However, both fleets are marked with the condition OverlappingSelectors though in reality there's no overlap in either of the fleet's labels.
Pointing to the overlap in the fleet labels is misleading, as the problem in caused by the device and not on the Fleets.
Maybe we need a different Fleet condition annotation for a case like this ? Ideally, users should be told which device(s) are causing the problem .

The intent is that the selectors overlap in their device selection - both fleets have at least one device in common.  There's also an annotation placed on the device which we could consider making a Condition.  But I don't think we can really say if the problem is caused by a fleet or a device.  For example we can have fleet1 with selectors region=US,state=NY and region=US,state=CA which is totally legal.

The intent is that the selectors overlap in their device selection - both fleets have at least one device in common. There's also an annotation placed on the device which we could consider making a Condition. But I don't think we can really say if the problem is caused by a fleet or a device. For example we can have fleet1 with selectors region=US,state=NY and region=US,state=CA which is totally legal.

The message for this error in particular is not accurate: "Fleet's selector overlaps with at least one other fleet, causing ambiguous device ownership"
I understand it's not always easy to discriminate, but in the above example, the fleets selectors have no overlaps. That's why I wonder if we could have two cases, depending on whether or not there is overlap in the fleets' selectors.
Anyway, I think the proper solution will come when we can create actions to fix these type of issues. We should be able to pinpoint where the overlap is, so users can understand how to fix it.

Adddressed via Jira tickets.


frontend: Add a new tab for "Add a new bot" in '#settings/your-bots'.

"Add a new bot" UI used to be common in "Active bots" and
"Inactive bots". "Add a new bot" UI was below the list of all
active/inactive bots.
If the count of active or inactive bots is more than four,
then the user has to scroll down the entire list of bots to
"Add a new bot".

Automated message from Dropbox CLA bot
@abhijeetkaur, it looks like you've already signed the Dropbox CLA. Thanks!

@abhijeetkaur the tab switching here seems to be somewhat buggy.  But regardless, I was actually thinking we should do something that just moves the form into the "edit bot" form page:

So we'd just have a "+ / create bot" button near the top of the main page, and it would open that sidebar as a "create bot" UI.
(Before we rework this, I'd like a second opinion; what do you think @brockwhittaker and @showell ?)

My personal opinion is that the right-pane stuff would feel too claustrophobic for creating bots.  (I also want to re-visit the right-pane approach for creating streams, where it feels even more claustrophobic and busy.)
I do see some value in being able to see your existing bots either before or while creating a new bot, which the current UI in production allows, albeit kind of clumsily.
I'm not sure what the best solution is here, but I guess we probably all agree that having the create form below  the info boxes for all the existing bots is less than ideal.  If nothing else, I'd want the create form above, not below, the info boxes.
It might be good to get a round of feedback on chat.

Give that concern, the approach taken in this PR (of putting the "Create bot" form in a tab) is probably reasonable, and we can iterate from there.  So I think the next step is that we should fix the bugs I was seeing where the new tab didn't work properly.

@timabbott What tab switching bug are you facing? It seems to be working fine for me!
What am I missing?

@zulipbot label "area: bots"

Codecov Report

Merging #5096 into master will decrease coverage by <.01%.
The diff coverage is 91.31%.

@@            Coverage Diff             @@
##           master    #5096      +/-   ##
==========================================
- Coverage   86.64%   86.64%   -0.01%
==========================================
  Files         432      432
  Lines       53562    53565       +3
  Branches     2090     2092       +2
==========================================
  Hits        46411    46411
- Misses       7151     7154       +3

Impacted Files
Coverage Δ

zerver/models.py
97.71% <ø> (ø)
:arrow_up:

zerver/lib/bugdown/fenced_code.py
93.86% <ø> (ø)
:arrow_up:

zerver/lib/bugdown/__init__.py
89.44% <ø> (ø)
:arrow_up:

static/js/search_suggestion.js
100% <ø> (ø)
:arrow_up:

static/js/message_list_view.js
27.69% <ø> (ø)
:arrow_up:

static/js/message_store.js
100% <ø> (ø)
:arrow_up:

zproject/settings.py
84.81% <ø> (ø)
:arrow_up:

static/js/emoji_picker.js
13.55% <0%> (ø)
:arrow_up:

static/js/composebox_typeahead.js
36.01% <0%> (-0.39%)
:arrow_down:

frontend_tests/node_tests/search_suggestion.js
97.19% <100%> (ø)
:arrow_up:

... and 106 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6b22fb...c4e8f58. Read the comment docs.

@abhijeetkaur can you fix the broken Casper tests?

Fixed! Any idea why the coverage issue?

@abhijeetkaur it looks like codecov expects the code to have equal or more coverage than the previous commit and because the code added in this diff had no tests, the total coverage as well as this diff's coverage are both reduced. I think the 20% coverage it reports is some part of the file settings_bots.js that was being already tested. :)

Thanks @aero31aero! I'll work on adding adding the tests for this too

Squashed and merged, thanks @abhijeetkaur!  I don't feel we strictly need tests before merging this.
One bug that I notice, though, is that when you create a new bot with this UI, it doesn't show you the new bot that you created (in 2 ways: the new bot isn't added to the "active bots" tab and also the tab isn't switched to the "active bots" tab to show that new bot).  We should fix this; can you open an issue @abhijeetkaur?


Problems page: Add tags on each answer

Tags added and it changes color if you add it in your favorites.
Red - Not added
Green - Added


Trying to add 24 hour format to react-native DatePickerIOS

This is a long requested feature, but no one seems to be doing anything about it.
I'm trying to add a boolean value to our DateTimePickerIOS so that the js part of it looks like this:
const RCTDatePickerIOS = requireNativeComponent('RCTDatePicker', {
  propTypes: {
    ...DatePickerIOS.propTypes,
    date: PropTypes.number,
    uses24hourFormat: PropTypes.bool, // <---
    minimumDate: PropTypes.number,
    maximumDate: PropTypes.number,
    onDateChange: () => null,
    onChange: PropTypes.func,
  }
});

Then I modified React > Views > RCTDateTimePickerManager.m. Specifically I added this code:
RCT_CUSTOM_VIEW_PROPERTY(uses24hourFormat, BOOL, UIDatePicker)
{
  BOOL is24hFormat = json ? [RCTConvert BOOL:json] : NO;
  if (is24hFormat) {
    [view setLocale:[NSLocale localeWithLocaleIdentifier:@"NL"]];
  } else {
    [view setLocale:defaultView.locale];
  }
}

That solution is based on this SO answer.
I've tried to do this, but with no luck at all.. Even-though this code compiles with no errors, I can't seem to do what I want.
On the other hand, I know that solution works, because when I modify this code on the same react-native file:
- (UIView *)view
{
  UIDatePicker* datePicker = [RCTDatePicker new];
//  [datePicker setLocale:[NSLocale localeWithLocaleIdentifier:@"NL"]];  // If I uncomment this line
  return datePicker;
}

I do get a 24hour time picker, but I want to be able to do this from js.
Any ideas would be appreciated.
Also if someone from the fb team pointed me to the right direction I could open a pull request.
Thanks.

The UIDatePicker displays time based on the user's locale. It doesn't seem like you can override that behavior in terms of UI.

You can if you initialise it for a different locale, that's what     [view setLocale:[NSLocale localeWithLocaleIdentifier:@"NL"]]; does.
I tested it and it does work.

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!
If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.


CI states for merging develop to main

I encounter error It is impossible to change a nullable field 'address' on profile to non-nullable without providing a default. This is because the database needs something to populate existing rows. on the Run Migration section of build part in CI.
In user_profile app, there is only one migration file and address field is nullable.
I can't get to understand why there is an error and how to solve it.

It needed another migration on profile.
The issue is resolved.


Support docs generated with dbt docs generate --static

Right now the docs do not support docs generated with --static.
All that should be needed for this is searching for static_index.html in addition to searching for index.html in the path provided by the user; only return a 404 in the event that either cannot be found.

Resolved


improve debug output

The 'next run in {} ms' isnt great to read.
parse that into a readable format (divmod till quotient == 0), but leave the MS there as well

resolved in 27f323b1707929205fed4072d1a56099f2ca1bbf


Add prettier

Purpose
We already use code-formatting on the python side to avoid splitting hair over pointless style differences.
There's no reason not to use black's older brother on the JS side :)
Proposal

[x] add prettier to our dependencies
[x] make a minimal config file
[x] apply prettier to the whole codebase
[x] add a prettier check step to the CI
[ ] let each developer integrate prettier into their editor

@jmaupetit done! For some reason I still see the old lint-front task in the GitHub checks though

Thx!

For some reason I still see the old lint-front task (in addition to the 2 new names) in the GitHub checks though

I fixed this in the protected branch requirement settings.


feat: created a pretty-printing formats package

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #18   +/-   ##
=======================================
  Coverage   92.00%   92.00%
=======================================
  Files          10       10
  Lines         200      200
=======================================
  Hits          184      184
  Misses         16       16

Impacted Files
Coverage Δ

packages/formats/index.js
100.00% <ø> (ø)

packages/formats/serializers/graphy.js
37.50% <ø> (ø)

packages/formats/serializers/jsonld.js
0.00% <ø> (ø)

packages/rdf-editor/src/RdfEditor.js
94.82% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca04ad4...ad02ed4. Read the comment docs.


ON-12177 # Added encryptPdf prop to hcms submission event

Go to merge once those two things are fixed.


Create index.js

Not finished yet just saving

This is awesome, thank you 🙏 I'll build out a language switcher soon.

The language switcher is done! Would you mind adding in an arabic version of the dropdown components as well? It's all ready to go, just needs the translation. THANK YOU!

I will add them tomorrow,
Regards
On Fri, Dec 29, 2017 at 6:48 PM Sarah Drasner<EMAIL_ADDRESS>wrote:

The language switcher is done! Would you mind adding in an arabic version
of the dropdown components as well? It's all ready to go, just needs the
translation. THANK YOU!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sdras/array-explorer/pull/15#issuecomment-354462295,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABwscK8JXjlgx7lLCUEwNZHPkKLajiK1ks5tFQnkgaJpZM4ROcij
.

--
Salah Al-Shawdhabi
Head Developer
One Graphics
Tel : +967 1 48 38 38
Fax : +967 1 48 03 81
Mobile: +967 777300180
website: www.onegr.com
website2: www.salah1.com


Changing the help text for the option to publish run attachments

We were using the same string as for a different option leading to confusion
https://developercommunity.visualstudio.com/content/problem/279688/the-publish-test-result-task-has-2-identical-toolt.html

Looks fine


Dynamic Properties: UI Switch

Using Dynamic Properties Best Practices, implement:

Label
Passthru
Decouple
offcolor
oncolor

as dynamic properties.

Hi @joepavitt,
I had most of this completed tonight.  Will try to finish it tomorrow evening.
So you can assign this one to me.


[Feature Request] Re-design the sharding strategy

Is your feature request related to a problem? Please describe
By default, system index settings are set to auto_expand_replicas to 0-all and number of primary shards to 5. This is causing the issues like single node cluster turning yellow after configuring plugins, increase in JVM pressure
Describe the solution you'd like
RE-design of sharding strategy
Related component
Plugins
Describe alternatives you've considered
No response
Additional context
No response

[Triage - attendees 1 2 3 4]
@riysaxen-amzn Thanks for creating this issue; however, it isn't being accepted due to it being unclear why this is an issue, as cluster operators can change defaults. Please feel free to re-open after addressing the reason.


Divide config and slack handler from save_log module

Description
Currently config is handled by save_log module to call get_options module.
This structure is taken over from external repository, but it looks weird to handle config files through log handler module.
Sample methods save_log.py contains:

get_version() # for reading config
get_training_logger() # log
send_message() # for slack

I want to remove methods for config and slack  from save_log module.
Goal
Separate configure and save_log module into individual codes.
Impact
Clear architecture.
Reference
Current save_log.py

Tasks

[ ] Divide slack methods
[ ] Divide config methods

This issue was solved in #16
close #7


Build source map file size

When I create a project in which the final .js file has around 900K, the *.map grows to 6.8M. This problem makes the first render on any browser of the app extremely long, sequential reloads are good due to the implicit hash cache.
This happened after updating the react-scripts version, previously the source map file size was quite small.
I'm using react-scripts 0.7.0.
Node version: v6.8.1
NPM version: 3.10.9

This problem makes the first render on any browser of the app extremely long

To be clear, we're talking about load time with open devtools? Sourcemaps aren't loaded for users of your app.

 Yes, both times has the console been open during the large loading times on the first render in each machine.

Browsers don't download the sourcemaps if devtools aren't open so I don't think it's a big issue. I'm not sure if the sourcemap size is normal—perhaps you could report this upstream to Webpack if its size changed in past releases? Unfortunately I'm not a sourcemap expert and can't say for sure.

I'll do. Thanks @gaearon.

I'll close since it's not directly actionable for us (in fact it might indicate a bug has been fixed on Webpack side, for example). Cheers!


PHP-CS-Fixer v2.1.1  not support --level option and  PSR2

The --level option was removed in 2.x, you should use --rules=@PSR2 instead. See Upgrade guide.


Missing SDL2 in custom build

I didn't build the framework for a while so I'm not much up to date, but I'm having trouble with the SDL2/SDL.h include. Googling I found sources/installs for it, but I'm not sure what exactly I need.
I tried the sample project and it works fine but I don't see where it includes SDL2 (I see it's in the third_party folder).
Anyways when I make a custom build with:
../configure --ios --cpu arm64 --disable-demo --disable-tests --eme-impl ../wv_prebuilt_cdm/shaka_plugin/release_cdm.json
(I paste the shakaplayer, ffmpeg and widevine cdm frameworks into my project, I assume I need all 3 now, as it's not just 1 file as before)
I get errors for file paths in ShakaPlayerEmbedded (all includes that have ../*), I fix those by just removing ../ as the files are actually in the same directory... I checked the sample build and it works with "../" which confuses me even more. But the one I don't know how to fix is the #include <SDL2/SDL.h> in sdl_frame_drawer.h. Any suggestions on how to fix this, or where to include it?

We should remove that include so users don't need it.  Especially on iOS where we may not want to include that file at all.  As a workaround, the headers are in $build_dir/gen/sdl2/include.  The demo works since it uses Objective-C; if you are using Objective-C++, then we'll include the C++ headers too and that gets included with it.  If you use Objective-C/Swift, then only the Objective-C headers will be included and that one won't be.

Thanks, I'll try it tomorrow in office. Just to make sure, since I use Objective-C++, do I need to wait any update, or both Objective-C and Objective-C++ versions are present?

If you include the headers in that folder, it should work fine.  You could also try:

Removing the sdl_frame_drawer.h include from ShakaPlayerEmbedded.h.
Including ShakaPlayer.h and ShakaPlayerView.h directly instead of the umbrella header.

Managed to get it running by including the headers in my project. After that had to remove a bunch of ../media/ and ../ in includes, but the app launched.


/setCMCoords not working

I am using Compact Machines 1.21.
In both Singleplayer (cheats) and Multiplayer (OP), I am unable to use /setCMCoords as it returns "You do not have permission to use this command" I'm pretty sure I'm doing everything right like holding a blank CM block of the right size, and I know the id.

Are you in creative mode?

Yes

Currently working on a 1.10.2 version, the 1.7.10 version is not being maintained anymore, sorry.
Closing all issues not relevant for the new version.


Add count parameter to make()

Added a $count parameter as the third argument to make(). This will let you count the records yourself to make sure the count query is as minimal as possible, especially when you have complicated queries. As this is nullable, everything works as it previously did.

@TobyRyuk, thanks for the PR but I already did something like this a week ago. Please see this issue #578 and let me know if it works for you.

Oh, totally missed that. Sorry for the unnecessary PR.

No problem and thanks for the intent to contribute. I also added a demo for ref: https://datatables.yajrabox.com/eloquent/manual-count


ci: consolidating E2E test report and publish steps

Description
This pull request changes the following:

Consolidating E2E test report and publish steps

Related Issues

Closes #573

:tada: This PR is included in version 0.30.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Make the API iterator test asynchronous.

This was my WIP when testing https://github.com/NativeScript/ios-runtime/pull/196 but it could be merged alone.
I think, that It allows the GC to kick more sporadically and sometimes RecordFields are released before they are assigned to RecordPrototype.

Out of curiosity, did this allow the UIApplicationDidReceiveMemoryWarningNotification handler in #196 to be invoked?

I couldn't make it to invoke it, but I'll try again.


Add android build guide

What about adding android example ?
Can make a PR if needed

I'd be interested to see that. Would you use the same template but just build for android?

Yes of course !
It's here https://github.com/emilk/eframe_template/pull/162
Default : cargo run
Web : trunk serve
Android : cd android && make && make run-on-device
:)

Thanks, I'll definitely check it out once I get a chance.


Use docker's ParseRepositoryTag when pulling

Let's try this again :smile:
@smarterclayton @dchen1107 @zmerlynn @vmarmol
I've modified parseImageName to just delegate to docker, restored the test I had deleted, and added a new test for Pull. I just ran a full e2e and it all passed for me.

LGTM

LGTM


ServiceHost/Named Pipe Not Listening

What App Center service does this affect?
Microsoft.AppCenter.Analytics
Microsoft.AppCenter.Crashes
Describe the bug
Configuring and starting AppCenter before starting a WCF ServiceHost seems to interfere with a named pipe endpoint. Clients report that no endpoint is listening at net.pipe://...
Switch the start order around (open ServiceHost first, then start AppCenter) and all seems to be okay (clients can connect, AppCenter can track and report).
To Reproduce
The code is:
      using static Microsoft.AppCenter.AppCenter;
      using static System.Globalization.RegionInfo;

      var countryCode = CurrentRegion.TwoLetterISORegionName;
      SetCountryCode(countryCode);

      Start(
        appCenterSecret,
        typeof(Analytics),
        typeof(Crashes)
        );

      using (var host = new ServiceHost(typeof(Service)))
      {
        var endpoint = host.AddServiceEndpoint(
          typeof(IService),
          ServiceHelper.MakeNetNamedPipeBinding(),
          ServiceHelper.GetServiceNamedPipeAddress(_serverID)
          );
        endpoint.EndpointBehaviors.Add(new ProtoEndpointBehavior());

        host.Open();
        Application.Run();
        host.Close();
      }

Expected behavior
Order of starting components to be irrelevant or else a warning in the docs.
Desktop (please complete the following information):

OS: Windows 10 Home

Additional context
.NET 4.7.1
AppCenter 2.2.1-preview

Thanks for reporting this our team will take a look at this.

Hi, @thehoglet! Thank you for contacting us! Could you please share the verbose logs? Please add this  AppCenter.LogLevel = LogLevel.Verbose;  before AppCenter.Start.

Attached are two files containing the debugging output to the VS2019 console. One for the successful start-up (ServiceHost ctor before AppCenter.Start()), one for the failed start-up.
Note that, as written, debugging was required to be terminated in both cases with a Shift+F5 in VS in order to break the server app out of its message loop (i.e. the call to the blocking Application.Run()).
startup-success.txt
startup-failure.txt

Hi, @thehoglet! Thank you for providing logs. I need more time to investigate it. Thank you for your patience.

@jwallra
The issue occurs with a start-up of just Crashes, and just Analytics.
The endpoint address is formed using $"net.pipe://localhost/rvis{id}/service" where id is a positive integer.
The ctor for the binding is this:
new NetNamedPipeBinding()
      {
        MaxReceivedMessageSize = 100000000,
        MaxBufferSize = 100000000,
        SendTimeout = TimeSpan.FromMinutes(10),
        ReceiveTimeout = TimeSpan.FromHours(9)
      }

The single endpoint behavior in use by client and server is this:
ProtoEndpointBehavior
via the protobuf-net nuget pkg.
More info here:
Protocol Buffers and WCF

Hey @thehoglet, we don't have an immediate fix planned for this so I advise that you start the services in the manner that already works. Thanks for bringing it to our attention, though!


updateField doesn't support broken paths

I have to map an object with a two level depth of nested dynamic properties.
i.e. myContainer.$category.$name.value
I am calling commit('updateField', {path:myContainer.${category}.${name}, value:metric.value});
If $category has never been set separately this break with an error 'Cannot set property ... of null'.
This should be an easy fix, to ensure path safety by creating empty objects if the key doesn't exist already.

Hey @fusionbeam! This seems to be the same as https://github.com/maoberlehner/vuex-map-fields/issues/41 (I know, the title is a bit misleading I guess)
Pull requests are welcome!
I'll close this issue, please use https://github.com/maoberlehner/vuex-map-fields/issues/41 for further discussion of the topic.
Please let me know if I miss understood your problem and I'll reopen this. Thanks!

@maoberlehner technically this is different but I can see how working on a fix for #41 can include a fix for this use case as well.
I'm working on a pull request.


[📑 Docs]: add the 2022 blog summary in the about section

What Dev Docs changes are you proposing?
Add the 2022 blog summary  in About section

File:-https://github.com/asyncapi/website/blob/master/pages/about/index.md
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hey @roopeshsn we don't assign issue, you can raise a PR directly.

/gfi

/help

/gfi docs


“drawer”

draw
𐑛𐑮𐑷
VVI
drɔː
4109

drawer
𐑛𐑮𐑹

i think there might need to be a word for a person that draws. 𐑛𐑮𐑷𐑼?

I don't think "drawer" could mean "a person that draws" except in an ironic meme.

It would be useful to know the frequency of 'drawer' meaning 'person who draws'. Adding it to the ReadLex would mean that every time the word 'drawer' (as in furniture) appears in a text, it would become a heteronym that needs to be resolved manually. Given I have never seen the word 'drawer' outside legal texts, as in a person who draws a cheque, I wonder if it would actually help to add it or just make more work.

Adding it to the ReadLex would mean that every time the word 'drawer' (as in furniture) appears in a text, it would become a heteronym that needs to be resolved manually

I think this should only be a consideration if the primary usage of the dictionary is in crude latin-to-shavian transliteration programs. If it is meant to be a standalone dictionary, "a person that draws" is indeed a word (and it is pronounced differently from the furniture as well).

@trosel Agreed, it is a legitimate heteronym. I've added it.


Project Idea: [Mentorship Program 2023] AsyncAPI Website: Migrate codebase to TypeScript

Project Idea: [Mentorship Program 2023] AsyncAPI Website: Migrate codebase to TypeScript
🚀 Introduction:
AsyncAPI Website is Powered by Next.js and uses JavaScript to build all components. This project aims to migrate this project to TypeScript for catching errors in compile time, rather than runtime. This would help in better Type Definitions, Self Documenting code, and would further reduce the first-contributions time due to increase in code readability.
💡 Project Description:
The aim of this project is to introduce the most popular type system to AsyncAPI website. Next.js provides a TypeScript-first development experience for building React application, and migration to TypeScript would thus unlock several development benefits.
🔧 Approach:
The approach for migrating AsyncAPI website from JavaScript to TypeScript would be like this:

Install the necessary packages such as TypeScript.
Add all of the necessary packages which are required for migration, whether it be TypeScript
Change the extensions of files from js/jsx to ts/tsx.
Refactor the code according to the TypeScript standards. Add prop types, variable types.

Migration would need to be done part-by-part, and a separate branch typescript-migration needs to be created from the master branch.
This would ensure that the current website stays in-place and other contributions related to the codebase can be merged during the migration process.

I'm not sure I like concept of rewriting to TypeScript 😃 definitely won't be able to mentor it 😃
Especially that I do not believe in statements like This would help in better Type Definitions, Self Documenting code, and would further reduce the first-contributions time due to increase in code readability..
@akshatnema @magicmatatjahu you folks?

@derberg are you serious man? 😄
This idea isn't about migration, it is about rewriting the whole Next js app in Typescript. Definitely, I'm not in the favor of this.

@derberg @akshatnema
Thanks for your opinions upon this idea.
The idea was to migrate the project, instead of re-writing it in whole.
Since, you, the mentors are not in favor for it, I would retract it. Thanks again!

The idea was to migrate the project, instead of re-writing it in whole.

@anshgoyalevil This idea isn't about just defining types in the present implementation of the website. Instead, it is about understanding the whole codebase and then re-defining these file as .ts and then defining boundaries for each props.

@akshatnema
Thanks for clarification 😄 . I got your point, and I too agree with that. Since, this project, if started might disrupt a lot of other such projects.
What do you suggest? Like, As an alternative, we can use prop-types package to validate this, and could further solve such eslint errors.
An example using prop-types, which fixes this error:
import PropTypes from 'prop-types';

export default function Meeting({
    name = '',
    purpose = '',
    host = '',
    hostProfile = '',
    youtube = '',
    bg = ''
}) {
Meeting.propTypes = {
    name: PropTypes.string,
    purpose: PropTypes.string,
    host: PropTypes.string,
    hostProfile: PropTypes.string,
    youtube: PropTypes.string,
    bg: PropTypes.string
};

Should I update the idea to fix eslint error in the codebase? Since, there are over 800+ such errors.

Better if you should ignore them. We can't define such strict types for each prop because Every component is a reusable component and can be extended or reused in different manners. So, it may happen that a prop may act as an array for one page and an object for another page for the same component. Hence, defining strict types to these props may cause problems of having flexibility.

Hmm. Got it. 🛩 Closing the issue as not planned.


[tests-only] Log requests and responses for the failing tests

Description
This PR adds the logging feature to the API tests. All the requests and responses from scenario start to end will be logged in a file and accumulated to a failed log file if the scenario fails. And the logs can be viewed in the CI pipeline if the pipeline has a test failure.

view logs in CI
logs example

We do have options to debug api calls using DEBUG_ACCEPTANCE_API_CALLS but it logs on the fly which will clutter the test logs. And we want to log only the calls that were performed during the scenario that fails and is not expected to fail.
Motivation and Context
Get an overall view of requests and responses whenever there is API test failure. Helps in debugging flaky tests
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[x] Tests only (no source changes)

Checklist:

[ ] Code changes
[ ] Unit tests added
[ ] Acceptance tests added
[ ] Documentation ticket raised:

do we need add a few words to docs?

debugging options are not documented at all in https://owncloud.dev/ocis/development/testing. So I would suggest let's do the docs part for various debugging options available in separate PR


Fix mutation consequence in GFD adaptor

This fixes the bug  in https://github.com/EBI-G2P/gene2phenotype_app/pull/49.
Thanks @dglemos


nextToken not being sent via getReports

I have the following piece of code to retreive settlement reports:
async function getReports(reportTypes, marketplaceIds = ["ATVPDKIKX0DER"], nextToken = null) {
  try {
    let query = {
      reportTypes,
      marketplaceIds,
      pageSize : 20 //later increased to 100
    };

    if (nextToken) {
      query.nextToken = nextToken;
    }

    let reportData = await sp.callAPI({
      operation: "getReports",
      endpoint: "reports",
      query: query,
    });
    console.log(reportData)
    // If there's a NextToken, recursively call this function to get more reports
    if (reportData.NextToken) {
      let additionalReports = await getReports(reportTypes, marketplaceIds, reportData.NextToken);
      // Combine the current report data with the additional reports
      reportData.reports = reportData.reports.concat(additionalReports.reports);
    }

    return reportData;
  } catch (e) {
    logger.error(e);
  }
}

When I do this, and at least only tried this while I'm asking for settlement reports, no nextToken is provided.
The call looks like this
await getReports("GET_V2_SETTLEMENT_REPORT_DATA_FLAT_FILE_V2");
however, after checking the console.log with the response, no nextToken was sent, and then I increased the page size to 100, and there were indeed more settlement reports to be downloaded. I cannot access any of the rest of the 100.
Any idea if this may be Amazon's mistake?

As much as I like to blame Amazon as well, this is actually an issue with amazon-sp-api.  I have made a pr fixing the issue https://github.com/amz-tools/amazon-sp-api/pull/239

So as somebody pointed out to me this was an issue with the 2020-09-04 endpoint.  The v2021-06-30 endpoint does correctly return the nextToken in the payload.  The v2020-09-04 endpoint will stop working on 18th October 2023 so it is best to start using the new endpoint.


Add stochastic policy gradient

It would be nice to have stochastic policy gradient in this. It would help implement things like
https://papers.nips.cc/paper/5542-recurrent-models-of-visual-attention.pdf

Do you mean something like this? http://www-anw.cs.umass.edu/~barto/courses/cs687/williams92simple.pdf

Yes, I am essentially referring to the REINFORCE method


Document that RouterMixin requires 'state.route'.

It took me a long time to figure out how this was supposed to work.  I built an app which used the RouterMixin, but I wasn't setting my top component's state.route, which resulted in none of this actually working.  :P  The example doesn't make it clear that this is an explicit requirement.
It kind of feels like there should be a less clunky way to do this... But for now, documenting this is a good idea.

CLA is valid!

Thanks @jwalton.  We are including a RouteStore as part of a major refactoring PR: https://github.com/yahoo/flux-router-component/pull/81   We are merging that PR this week.  After that, the route state will be handled by the RouteStore.  In addition, RouterMixin will also be replaced by the handleHistory high-order component.


renaming plugin ID to fix the fr... package in package.json (Issue #59)

I renamed the package names to cordovarduino, which is the name on npm, so this does not break npm install. I also increased the version number, feel free to skip that part.

commits slipped into this PR that don't belong here, I opened #108 instead.


🐬 FIX - dead link and additional context for RH Labs 🐬

The labs-ci-cd project was sunset a few years ago in favour of Ubiquitous Journey. Also added a bit more fluff around what it is for context.

@springdo thanks for the support and hope you are all good fella


Problems integrating tree.io with LDAP

User authentication is now working using django-auth-ldap, however as it seems Django won't create profiles for users upon user creation. It would have been nice if things were working somehow out of the box. What I'm currenty getting upon user login is:
[error] Django user foobar does not have a profile to populate
None of the solutions posted online are working for me or I have no idea how to get them to work since I have no prior knowledge of neither Python nor Django. Tree.io Documentation does not have a step-by-step general guide on how to do this and in my humble opinion, that's a shortcoming OR do I miss something really huge here?

currently the code has a post save signal on the auth.user model creating a profile, meaning it will create a profile when creating a new user. please test with the 2.0 branch.
let me know if you still need any help or is having any issues, otherwise I'm closing the ticket