requestSizeFilter hardcoded

It seems, that the following line is a little hardcoded.
private static final int MAX_CONTENT_LENGTH = 1048576;
Why can not the user decide how big his transfers are?
TomCat has already a few mechanisms to protect from DDOS attacks through huge filesizes. In my humble opinion it would be better to let tomcat handle the size restriction.

It definitely makes sense to make this configurable.

This is also often a configuration option in the web server.
Jesse
On Jun 18, 2015 2:46 PM, "Tobias Sauerwein"<EMAIL_ADDRESS>wrote:

It definitely makes sense to make this configurable.
—
Reply to this email directly or view it on GitHub
https://github.com/mapfish/mapfish-print/issues/257#issuecomment-113144378
.

This issue can be closed - I had a long journey finding the solution....
The hardcoded configuration is overwritten by the web.xml file.
Adjusting these lines here helped:
<filter>
    <filter-name>requestSizeFilter</filter-name>
    <filter-class>org.mapfish.print.servlet.RequestSizeFilter</filter-class>
    <init-param>
            <!-- The maximum request size in bytes (default: 1 MB). -->
        <param-name>maxContentLength</param-name>
        <param-value>16777216</param-value>
    </init-param>
</filter>

Maybe it would be better if the adjustment happens in the print-apps config? Just an idea... ;)


Questions on constructing pairs with distributed batch size in SimCLR

Hi! From the original SimCLR paper the performance benefits from large batch size, i.e., a large number of negative pairs for the NT-Xent loss:

however, when we run training with DDP, the batch is divided into K sub-batches and the loss is calculated with only the samples from the sub-batch on each rank (i.e., each rank sees only N/K). In this case, how do we reproduce the original setting where the contrastive distribution is over 4096 examples?
Thank you!

Hi @DianCh we all_gather the embeddings from each distributed rank: https://github.com/facebookresearch/vissl/blob/main/vissl/losses/simclr_info_nce_loss.py#L139.
Our config has 64 batchsize per gpu, 8 gpus, and 8 nodes, which is a global batchsize of 4096.

Thank you @iseessel ! It's great to know that your gather implementation doesn't cut off the gradient, which I think answers exactly the main issue.

Hi, I do not understand why the GatherLayer function "all_reduce" the gradients in the backward function. In my understanding, for all the ranks, the "*grad" are the same, which is already carried all the gradients from all the samples. Thus this all_reduce op will enlarge the gradient by "dist.word_size()" times.


fix: Going back after pressing sign in on public room

Details
This is a border case, only anonymous users can go through this flow. I created a library called BackButtonUtils which only has Android and website implementations, when the anon user visited a public room and goes to login if the user presses the back button on Android or on the browser then the user is taken to the room again. More of a feature than an issue.
PS: Left it as backButtonHandler because it validates if should send to a report or close, so naming the method might complicate it
Fixed Issues
$ https://github.com/Expensify/App/issues/20558
PROPOSAL: https://github.com/Expensify/App/issues/20558#issuecomment-1585445290
Tests

Open a public room as unauthenticated user (i.e. https://staging.new.expensify.com/r/8813851443373010)
Click on sign-in
Click on the back button, should see the public room instead of closing the app
Tested in Browser, mobile browser and Android native

Offline tests
N/A anonymous users only work online
QA Steps
Same as test steps
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
New Recording - 13_6_2023, 20_05_24.webm

Mobile Web - Chrome
New Recording - 13_6_2023, 20_06_59.webm
PS: These is the default navigation behavior if open report is called in mobile sign in page, we can work it as a separate bug or fix it here I think is out of scope of the error or maybe another way of opening it in mobile @marcochavezf

Mobile Web - Safari
https://github.com/Expensify/App/assets/13544910/32ed5ad1-80e4-47ca-bb45-f3bbc5117045

Desktop
N/A anonymous users not supported atm on desktop

iOS
N/A iOS has no back button on sign in page

Android
New Recording - 13_6_2023, 20_01_55.webm
PS: These is the default navigation behavior if a deep link is called in android sign in page, we can work it as a separate bug @marcochavezf

I have read the CLA Document and I hereby sign the CLA

@marcochavezf  did you guys rollback the migration of signinpage from function component to class component? The conflicts are a bit weird because of this.
Also, shall we review that behavior I explained in the video no this same PR or handle it as a different issue? (Opening report as a deeplink opens the main view with menu opened instead of the public room). If there is any other way of opening the public room let me know is just changing two lines.

yeah just saw @mountiny did the rollback. @marcochavezf let me know if I should update the PR to support class component or wait for that commit to enter main branch again.

Hi @daordonez11, there's an existing issue related to the deep link problem, so I think that will be addressed there.

Regarding updating the PR to support the class, it's hard to tell since it will depend on when the new changes will be integrated. You could update the PR to adapt the changes, but there could also be the risk of updating the PR again if the new changes are merged to main first.

Ah also you might want to run npm run lint and npm run prettier to fix some styling issues (there's GH action to check that automatically but for some reason is not running, maybe because of the conflict).

For sure! Ran lint but not prettier, in terms of variable and function naming looks good?

Got it @marcochavezf  and actually with that merge of main the deeplink error is already fixed! Ran prettier, everything is up to date

Also @marcochavezf  I was testing and found a specific issue, the second time I press "Sign in" the "componenDidMount" of AuthScreens is called so you are automatically sent to the room, and you get no chance of sign in, I know pressing it twice does not sound like a general user flow but wanted to point it out: video of the error.
New Recording - 13_6_2023, 23_50_04.webm
I'm not sure if it counts as a regression since before my implementation you cannot press it twice, it happens in browser web and mobile. In native it works fine

@marcochavezf  with this in line 125 of AuthScreens.js the autoredirect is fixed but the error of seeing the whole OptionsList reappears, still the origin is this issue We can add my proposed line, avoid the regression and wait for this solution
if (this.props.lastOpenedPublicRoomID && !Session.isAnonymousUser()) {
            // Re-open the last opened public room if the user logged in from a public room link
            Report.openLastOpenedPublicRoom(this.props.lastOpenedPublicRoomID);
        }

Will it work after some more navigation happens? Also, is it the only case when such flow happens? Is it a generic enough behavior so it could be applied to other cases? Also, is there no option to just save the previous route somewhere in the AppNavigator. It seems rather like a bug with the implementation at our side, but I may be missing something.

Hey @mountiny we discussed a bit about this in the issue with Marco, basically AuthScreens and PublicScreens are in different navigation roots, I began last week so I'm not sure what was the scope of the navigation refactor but if we want to tackle this from the root we would have to join everything in a single Navigation root and use protected views only with groups and screens. Actually my original proposal was just to navigate if the lastRoomKey exists but this navigation is not possible between different Roots

Hi @WoLewicki I think when Appnavigator was created the anonymous user flow was no taken into account , AuthScreens and PublicScreens are created with different RootStacks instead of having protected views in a single stack, I'm not sure how much impact joining both would have but that is the root of why I implemented pop state listener. I would try to propose something additional but it is a bit out of my league for my first bug in expensify😅

@daordonez11 you are doing great job for your first bug for sure, thanks for your patience.
I would probably prefer a proper discussion and research of options we have here to fix such bug and not rush this solution. I think what the bug itself is not minor but also not that critical to rush solution right now.

Totally agree playing with navigation is tricky! Maybe I can try a POC of joining both RootStacks or focus in a more specific bug while you guys decide. Also watch out for the line I mentioned in AuthScrens, that might be a possible regression in the PR of navigating to last room ( @marcochavezf )

Yeah, would be nice to have a POC to test for sure :rocket:

Had to force push because forgot to sign the merge :/ will work tonight on change requested by @mollfpr and the POC of joining the RootStack

Quick update after the Slack discussion: Probably this PR will be discarded, the scope of the issue changed a bit and the idea would be to move the sign-in page to the RHN modal, I will discuss with @marcochavezf  to make sure the new scope is clear for a new PR to be developed.

@danieldoglas yes lets start a new clean PR

@mountiny wrong daniel, I think?

@mountiny @marcochavezf @WoLewicki Here you can find a branch with the POC https://github.com/daordonez11/DanielExpensify/tree/poc-shared-root
Left this message in slack:
I just did a mini POC of joining all in AuthScreens, its kinda feasible and actually the back button in the browser works :laughing:  but the thing is that Sidebar and Signin both share "Screens.Home" as the path, we need to register a new path e.g. "Signin" for them to work, it does work easily buuut everywhere sign in is called now it should do something like: Navigation.navigate(SCREENS.SIGNIN); in the poc I just included it in SignInRedirect.js you can find a working branch HERE. hehe I just wanted to check how hard it was but I don't have enough knowledge for a deep testing for testing viability. https://github.com/daordonez11/DanielExpensify/tree/poc-shared-root
Based on this I think testing might be huge due to the routes that are impacted. I think we can focus on
@Thiago Brezinski
’s PR and handle it as a modal in RHN to avoid testing impact (Although I have to admit joining everything does seem clearer and we can remove some classes and code, navigating to "SignIn" is more readable than going home in a different root)

Closed after discussions, creating this one purpose code should be avoided, we will focus in the two alternatives of using a modal on RHN and merging the whole navigation in a single RootStack.


AIY Voice - Too Many Requests

I have been using the AIY Voice kit for a couple of weeks, and all was going well - initially just with the assistant_library_demo, and more recently experimenting with local commands.
Then today, literally mid-conversation it completely died. I now get error message "429 Client Error: Too Many Requests for url: https://embeddedassistant.googleapis.com...." (full version below) every time I run any of the demo scripts. I don't believe I changed anything since it was working, and my usage has not been excessive, so it very much looks like an issue at google's end.
Thanks in advance. The full text of the error is below:
pi@raspberrypi:[tilde]/AIY-projects-python $ src/examples/voice/assistant_library_demo.py
Traceback (most recent call last):
File "src/examples/voice/assistant_library_demo.py", line 74, in
main()
File "src/examples/voice/assistant_library_demo.py", line 68, in main
with Assistant(credentials) as assistant:
File "/opt/aiy/projects-python/src/aiy/assistant/library.py", line 33, in init
self._model_id = device_helpers.register_model_id(credentials)
File "/opt/aiy/projects-python/src/aiy/assistant/device_helpers.py", line 93, in register_model_id
r.raise_for_status()
File "/usr/local/lib/python3.5/dist-packages/requests/models.py", line 928, in raise_for_status
raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 429 Client Error: Too Many Requests for url: https://embeddedassistant.googleapis.com/v1alpha2/projects/voice-assistant-213123/deviceModels/voice-assistant-213123-voice-kit
pi@raspberrypi:~/AIY-projects-python $

The issue resolved itself the next day, so all is good for now. I am assuming it was a glitch at google's end.

Which is the quota?
I have had the same problem sometimes / days.

@sjesusma You can probably find this at https://console.cloud.google.com/

Thanks @dmitriykovalev, my problem is in the quotas on Google Assistant API (max. 500 requests every 24h). When someone is developing, sometimes are required a lot more. I have asked to Google for an extension of this quota, I hope they accept it. :)

@sjesusma Sounds good!


fix and, or, xor in logical operations

[x] Closes #380
[x] Tests added:

test_series.py:test_logical_operators()

Not sure that I am covering all the cases, but this improves where we were.

Thanks @Dr-Irv !


How to get position element?

I want to test the listview when sorting data. Please help me!
ex: item A below item B, item B above item C

Stack Overflow.


How to Intercept attack requests on nginx

I just load the ngx_cp_attachment_module.so  to nginx configure file. Then run the waf-comparison-project to attack it. But all requests was passed and the log files recorded only like '{"eventTime": "2024-04-15T08:45:08.054","eventName": "Check Point Nano-service started","eventSeverity": "Info","eventPriority": "Medium","eventType": "Event Driven","eventLevel": "Log","eventLogLevel": "info","eventAudience": "Security","eventAudienceTeam": "","eventFrequency": 0,"eventTags": ["Informational"],"eventSource": {"agentId": "Unknown","eventTraceId": "","eventSpanId": "","issuingEngineVersion": "1.1.8-open-source","serviceName": "HTTP Transaction Handler","serviceId": "1"},"eventData": {"logIndex": 2,"serviceName": "HTTP Transaction Handler"}}'.

Hi,
Have you configured a reverse proxy? You can follow the instructions here - https://docs.openappsec.io/troubleshooting/troubleshooting-guides/agent-fails-to-recognize-http-transactions-with-nginx

Yes, i did.But it's not work.My configure like these.
location / {
proxy_set_header Host  $host;
proxy_set_header X-Real-IP $remote_addr;
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
proxy_set_header Accept-Encoding '';
proxy_pass http://pweb;
}
Clicking the url with '?shell_cmd=cat/etc/passwd' return normal page.

Hi @roycyz,
Have you configured a reverse proxy? You can follow the instructions here - https://docs.openappsec.io/troubleshooting/troubleshooting-guides/agent-fails-to-recognize-http-transactions-with-nginx

I'm accessing the nginx's ip and port.

Hi @roycyz,
I'm closing this issue as we're waiting for your response, please reopen once you've attached the needed details.


IP Addresses RSS Feed Link Incorrect

The "RSS/Atom" feed link points to this page source markdown in GitHub, not to an RSS/Atom feed.

Alternatively, you can subscribe to this page as an RSS feed by adding https://github.com/MicrosoftDocs/azure-docs/blob/main/articles/azure-monitor/app/ip-addresses.md to your favorite RSS/ATOM reader to get notified of the latest changes.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 3942b937-b212-3ceb-d356-450b7f598f68
Version Independent ID: 8b015b42-cf02-3942-3cc3-6e0f977d191a
Content: IP addresses used by Azure Monitor - Azure Monitor
Content Source: articles/azure-monitor/app/ip-addresses.md
Service: azure-monitor
Sub-service: application-insights
GitHub Login: @AaronMaxwell
Microsoft Alias: aaronmax

@ChrisRomp
Thanks for your feedback! We will investigate and update as appropriate.

@ChrisRomp - Thanks again for bringing this to our attention. We have updated the doc and it will be live once it's merged.  We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Uncaught TypeError: callback is not a function

I get an error after updating to the 7.0.1 version from 6.0.0:
Uncaught TypeError: callback is not a function
    at TextareaAutosize._this._resizeComponent

Please upgrade to 7.0.2 - it should be fixed in it.


Needs to recognize more codes: R, N

R - rename
N - new

A PR is coming soon.

Oops, the N code is not valid. A “new” file is shown as ‘Added’. I’ll clean up the mess and submit another PR soon.


Remove misleading line in fix_error.py description

Previously said: "Needed to allow mod_chi2 to behave correctly".  My understanding is that this stage reduces the accuracy of mod_chi2 by approximating MC errors throughout the space as the initial MC errors.

Looks good to me

The original reason for this treatment was a bias in the nutau appearance analysis when this error was not fixed. So maybe instead we could explicitly write here that this was needed to be fixed for Dragon nutau

The original reason for this treatment was a bias in the nutau appearance analysis when this error was not fixed. So maybe instead we could explicitly write here that this was needed to be fixed for Dragon nutau

This makes sense to me, will amend and do a new pull request.


Error during build on Heroku

The package works great on local env, however pushing to Heroku it breaks.
remote:        [4/4] Building fresh packages...
remote:        error /tmp/build_ec62596718e2fd57917c6c2b077c5bc9/node_modules/sqlite3: Command failed.
remote:        Exit code: 1
remote:        Command: node-pre-gyp install --fallback-to-build
remote:        Arguments:
remote:        Directory: /tmp/build_ec62596718e2fd57917c6c2b077c5bc9/node_modules/sqlite3
remote:        Output:
remote:        node-pre-gyp ERR! Tried to download(403): https://mapbox-node-binary.s3.amazonaws.com/sqlite3/v3.1.13/node-v64-linux-x64.tar.gz
remote:        node-pre-gyp ERR! Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v64 ABI, glibc) (falling back to source compile with node-gyp)
remote:        node-pre-gyp ERR! Tried to download(undefined): https://mapbox-node-binary.s3.amazonaws.com/sqlite3/v3.1.13/node-v64-linux-x64.tar.gz
remote:        node-pre-gyp ERR! Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v64 ABI, glibc) (falling back to source compile with node-gyp)

I am not using any of the built-in strategies, and especially not the sqlite one, and yet it seems to be trying to download sqlite?

Hi @Werbelow , do you use same node versions on your local machine and heroku ?
sqlite3 version 3 is not supported by node 10 and must be updated, there is already PR, but not merged..

or use @topmonks/shopify-express, forked from this repo, maintained by me (I removed sqlite3 lib)

Hey @janfabian I just checked my node version on heroku and you are correct, it was not the same as my local env. Once I updated that, the build worked.
Thanks!

What node version are you on that works?

I am using version 8.9.1


Update dependencies

I needed to upgrade postgrex and ecto in my apps and ex_admin
requirements were conflicting with it. My own app seems to be
working alright with these changes.

Thanks


feat(RHTAPREL-815): create-advisory-internal-request passes repo

This commit modifies the create-advisory-internal-request task to require a parameter providing the path to the ReleaseServiceConfig json in the data workspace. The json is then read to fetch the advisoryRepo and that is passed to the InternalRequest as a parameter.

/test release-pipelines-e2e-suite

/test release-pipelines-e2e-suite

/test release-pipelines-e2e-suite

/test release-pipelines-e2e-suite

/test release-pipelines-e2e-suite

/test release-pipelines-e2e-suite

/test release-pipelines-e2e-suite

This task is not included in any pipeline that is run as part of the release-pipelines-e2e-suite, so I am not holding this PR up on that suite flaking


Importing data don't change locale

Fixed partially at https://github.com/MarckFp/ppoc-gen/commit/8b768762813fe2a6c1847013a18a46f7006e0573 Apparently lang select don't change

Workaround deployed at https://github.com/MarckFp/ppoc-gen/commit/8a6eb39fa12dcaa9a9adf6538b63d8f64491ea85


feat(es/lint): add partial max-length rule implementation

Description:
Add partial max-length rule implementation.
Now implemented:

max code length check
max comment length (works for single line and multiline)
tab width option
ignoring trailing comments
ignoring string (single line and multiline)
ignoring template literals

Other functions I'll implement future. I need to relax after this rule =)
BREAKING CHANGE:
No

I think we should not have rule for code styles.

Why? Code style rules is useful by my mind

Strictly, rules about code style shouldn't be a part of linter. Though current ESLint supports many rules about code style, actually, very early version of ESLint doesn't have any rules about code style. Also, there're already some mature formatter tools: Prettier and dprint, etc.

Agree, let's avoid most of stylistics rules, but note - there are some differences between them, for example:

padding-line-between-statements, prettier respects newlines between code structures from original code, this may be useful for more struct code style
max-length is fully unnecessary, because prettier (and most of other formatters) found better length and reformat code for better readable

Anyway I think it should be not rules, it should be options for formatter


Graph prioritization problem

I'm trying to track down a graph prioritization/ordering problem, tasks are being run in an order that is not conducive to low-memory use.  Here is a minimal example provided by a collaborator
import dask.array as da

# n, k = 250, 10000  # big enough to fill memory
n, k = 5, 100  # for experimentation
x  = da.random.normal(size=(n, k), chunks=(1, k))
y  = da.random.normal(size=(n,), chunks=(1,))
xy = (x * y[:, None]).cumsum(axis=0)
xx = (x[:, None, :] * x[:, :, None]).cumsum(axis=0)
beta = da.stack([da.linalg.solve(xx[i], xy[i]) for i in range(xx.shape[0])],
        axis=0)
ey = (x * beta).sum(axis=1)

Trace
This results in the following trace:

Created by
from trace import Track
Track(save_every=1, rankdir='LR', path='every-svg', format='png',               node_attr={'penwidth': '6'}).register()

import dask
ey.compute(get=dask.get)

Trace provided here: https://gist.github.com/5b7bf78621496697fa3001462e1910ae
Looking at order
If we look just at the prioritization created by dask.order.order we find that there are some unfortunate jumps around the graph.  We would want this to be pretty smooth

Created by
import matplotlib.pyplot as plt
import dask.order
from dask.dot import dot_graph
from dask.core import get_dependencies, reverse_dict

def colorize(t):
    t = t[:3]
    i = sum(v * 256 ** (len(t) - i - 1) for i, v in enumerate(t))
    return "#" + hex(int(i))[2:]

def color_dict(o, cmap=plt.cm.viridis):
    mx = max(o.values())
    colors = {k: colorize(cmap(v / mx, bytes=True)) for k, v in o.items()}
    return colors

def visualize_colors(dsk, filename='dask.pdf', cmap=plt.cm.viridis, **kwargs):
    o = dask.order.order(dsk)
    mx = max(o.values())

    colors = {k: colorize(cmap(v / mx, bytes=True)) for k, v in o.items()}

    dot_graph(dsk, filename=filename,
              function_attributes={k: {'color': v, 'label': str(o[k])} for k, v in colors.items()},
              data_attributes={k: {'color': v} for k, v in colors.items()},
              node_attr={'penwidth': '6'}, **kwargs)

(depends on #2987 )

Interestingly, the following reversal of our priorities significantly reduces our memory footprint
diff --git a/dask/order.py b/dask/order.py
index 9649b75..ceb371f 100644
--- a/dask/order.py
+++ b/dask/order.py
@@ -175,7 +175,7 @@ def dfs(dependencies, dependents, key=lambda x: x):
     i = 0

     roots = [k for k, v in dependents.items() if not v]
-    stack = sorted(roots, key=key, reverse=True)
+    stack = sorted(roots, key=key, reverse=False)
     seen = set()

     while stack:
@@ -188,7 +188,7 @@ def dfs(dependencies, dependents, key=lambda x: x):
         deps = dependencies[item]
         if deps:
             deps = deps - seen
-            deps = sorted(deps, key=key, reverse=True)
+            deps = sorted(deps, key=key, reverse=False)
             stack.extend(deps)
         i += 1

This means that we now prefer to traverse down branches of our computation that have relatively few dependencies.  We avoid exposing parallelism and instead try to finish off branches that are relatively isolated.

This causes workloads/tests like the following to fail
    def test_base_of_reduce_preferred():
        """
                   a3
                  /|
                a2 |
               /|  |
             a1 |  |
            /|  |  |
          a0 |  |  |
          |  |  |  |
          b0 b1 b2 b3
            \ \ / /
               c

        We really want to run b0 quickly
        """
        dsk = dict((('a', i), (f, ('a', i - 1), ('b', i))) for i in [1, 2, 3])
        dsk[('a', 0)] = (f, ('b', 0))
        dsk.update(dict((('b', i), (f, 'c', 1)) for i in [0, 1, 2, 3]))
        dsk['c'] = 1

        o = order(dsk)

>       assert o == {('a', 3): 0,
                     ('a', 2): 1,
                     ('a', 1): 2,
                     ('a', 0): 3,
                     ('b', 0): 4,
                     'c': 5,
                     ('b', 1): 6,
                     ('b', 2): 7,
                     ('b', 3): 8}
E       AssertionError: assert {('a', 3): 0,...', 2): 3, ...} == {('a', 3): 0, ...', 0): 3, ...}
E         Omitting 2 identical items, use -vv to show
E         Differing items:
E         {('a', 2): 3} != {('a', 2): 1}
E         {('b', 3): 1} != {('b', 3): 8}
E         {('b', 2): 4} != {('b', 2): 7}
E         {('b', 0): 8} != {('b', 0): 4}
E         {'c': 2} != {'c': 5}...
E
E         ...Full output truncated (4 lines hidden), use '-vv' to show

dask/tests/test_order.py:84: AssertionError

Tests for what I think we want added in https://github.com/dask/dask/pull/3017

I believe that this has been resolved.


Render error: CODE: ERR_INVALID_ARG_TYPE

Describe the bug
I am using udacimak 1.4.0 and getting the following error.
2019-05-17T14:49:15.955Z [error]: TYPEERROR [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type undefined
CODE: ERR_INVALID_ARG_TYPE
STACK: TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type undefined
    at validateString (internal/validators.js:125:11)
    at Object.extname (path.js:830:5)
    at downloadMediaInHtml (C:\Users\sstih\AppData\Roaming\npm\node_modules\udacimak\lib\commands\utils\downloadMediaInHtml.js:66:37)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Desktop (please complete the following information):

OS: Windows
Node version: v10.15.3
npm version: 6.4.1
Udacimak Version: v1.4.0

Course Information

Nanodegree or Course name: Fundamentos Web Front-End nd-041
Version: v2.0.0
Locale: pt-br

@sstihler
Please provide the command that you wrote in the terminal that throws the error.
It looks like the error was due to an invalid command.

The error is occurring at the time of rendering the course.
To download I have used: udacimak download nd041
There was no mistake.
To render I used: udacimak render "Fundamentos Web Front-End v2.0.0"
When it arrives in the folder
Fundamentos Web Front-End v2.0.0\Part 02-Module 01-Lesson 02_Lab - Sintaxe de HTML\08. Construindo links.html
the error happens.


The world seed in this dimension is different

have solution? java 1.20.1

This message will always appear when traveling between Overworld/Nether/End dimensions, or additional dimensions if a server has the MultiVerse plugin installed.
If multiple Overworlds, the same method of lifting bits and finding structures is the same.
For Nether, one would need the Nether Cracker and manually enter in coords for bedrock blocks from both floor and ceiling (Hit F3, use the "looking at block" on the right side to get the coords).
For the End, you'd need to defeat the Dragon (or simply be fast about bridging to the outer islands, and find at least 5 cities for their bits, then come back to the main island for the pillars to get the seed.
If you already have the seeds for each of these dimensions, then this message can be ignored always. This is simply the mod detecting a different seed between what was generated for two different dimensions.


Survey not show: WOOTRIC_SDK: API error

I just got error when try to display survey:
10-12 23:15:53.069 32562  1667 E WOOTRIC_SDK: API error: java.io.FileNotFoundException: https://api.wootric.com/v1/end_users?email=nps%40example.com&os_name=Android&os_version=8.0.0&sdk_version=android-2.13.0 10-12 23:15:53.073 32562 32562 D WOOTRIC_SDK: response: null
I tested with version 2.13.0, It work fine about 5 hours ago but suddenly it not display survey anymore. I notice there are abnormal log related to API error that may related to this error.
Please let me know if you need more information.

Issue close, It work again, It seem issue have been fixed from API side. Thanks
10-13 08:41:01.775 29343 30054 D WOOTRIC_SDK: request: https://api.wootric.com/v1/end_users?email=nps%40example.com&os_name=Android&os_version=6.0.1&sdk_version=android-2.13.0 10-13 08:41:02.303 29343 29343 D WOOTRIC_SDK: response: [{"id":198118636,"created_at":"2019-10-11 01:56:32 -0700","updated_at":"2019-10-12 00:39:09 -0700","email":"nps@example.com","last_surveyed":"2019-10-12 00:39:09 -0700","external_created_at":1234567890,"last_seen_at":null,"properties":{},"phone_number":null,"external_id":null,"last_response":{"id":40011533,"score":10,"text":null,"survey":{"channel":"mobile"}},"settings":{"email_nps":true,"mobile_nps":true,"web_nps":true,"surveys_disabled_by_end_user":null}}]

Hi @nguyendat I am glad it's working again. We had some infra hiccup yesterday. Looking at logs I would recommend to hange email, created_at parameter of user with value that's specific to user who logged in. The place holder value like<EMAIL_ADDRESS>is just to show how it is supposed to work.


Unbound log to dedicated file

Switch log to dedicated file (/var/log/unbound.log) and log blocked queries

Moved to https://github.com/CFCC/TurboStacks/issues/3


Add CORS support for Upload-Defer-Length header

This is a followup to #182 that adds the Upload-Defer-Length header to the Access-Control-{Allow,Expose}-Headers lists and addresses feedback from the earlier PR.
cc @Acconut @kvz

Thank you very much :+1:


ISPN-14428 size() and keySet() are not reliable and return fuzzy results

https://issues.redhat.com/browse/ISPN-14428
A couple of things here:

Key tracker allows duplicates;
The IntSet keeping track segments not completed;

The latter I guess is a visibility issue. We have only a single outstanding request for each target, but we have a concurrency of # of target servers. We update by removing the completed segments when a response is received, and the flowable uses the segment again to request the not completed. Not sure how to create a test for this, tough.
A log from a local execution:
18:18:42.200 INFO [org.jabolina.playground.TestHotRodClient] (1) SIZE: 10
18:18:42.200 INFO [org.infinispan.client.hotrod.impl.iteration.RemotePublisher] (15) [HotRod-client-async-pool-1-1] Segments left to process are {60-62 79-91 103-107 113-115 117-122 187-202 205 209-216 218-234 238-249} <--- Causes a request for these segments again.
18:18:42.202 INFO [org.infinispan.client.hotrod.impl.iteration.RemotePublisher] (18) [HotRod-client-async-pool-1-4] Segments left to process are {} <--- After receiving the segments.
18:18:42.202 INFO [org.jabolina.playground.TestHotRodClient] (1) KEYS [10]: [test4, test3, test1, test6, test9, test7, test2, test8, test5, test10, test6]
18:18:42.202 INFO [org.jabolina.playground.TestHotRodClient] (1) FOUND 10 KEYS

Fixed, I've tested with >1M invocations and double checked without the PR

@wburns Do you think we need to backport this?

We should make a 14.0.x PR sure. It looks like this affects all versions back to 11.0.0 though.

Looks like CI found some issues with segments being completed before the key. It could be related to local cache which don't have segments, which is the one exception where we would have to track all keys sadly :(

Looks like CI found some issues with segments being completed before the key. It could be related to local cache which don't have segments, which is the one exception where we would have to track all keys sadly :(

It was the remote store with a cache with a type of object. The approach would be to check the data format to check if is a store object instead of the HR constant.
There is a negotiation for the type of the remote cache in the remote store, and if the media type is not binary (in the test we use MediaType.APPLICATION_OBJECT), it fallback to the marshaller configuration media type (in the test, x-protostream). When receiving a response for a segment, the KeyTracker does not identify the status as an object store (as it checks the HR constants), then gets a different segment number since it has some additional bytes. But because segments not found would go to the keyOnlyTracker, this wrong key-to-segment mapping would end up accepting the key to an incorrect segment.
Using the DataFormat#isObjectStorage, the values can be marshaled with protostream, and we can identify if the store is an object store, thus correctly mapping the key to the segment.
Let's see how CI goes.

Still some failures for size operations, looking into it.

LGTM.
Please confirm we have a test that runs with a local cache to make sure there is no problem there as well.

The BulkOperationsTest should cover that:
https://github.com/infinispan/infinispan/blob/710ecbcb2a0daf64f8e4ad93b8e4bfe101cb2493/client/hotrod-client/src/test/java/org/infinispan/client/hotrod/BulkOperationsTest.java#L110

Integrated into main, thanks @jabolina !


[FLINK-23313][docs] Reintroduce temporal table function documentation

What is the purpose of the change

This pull request reintroduce the temporal table function documentation,  it backports #17356 to release-1.14 branch

Brief change log

Reintroduce the documentation of temporal table function
Fix typo in tableApi.md

Verifying this change
This change is a documentation change without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): ( no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

manually merged


for operator, use to_xxx() rather than _check_xxx or convert

What is the expected enhancement?
Since current operator support single representations, use convert method results in error, it is safer to use to_matrix() or to_paulis() or to_grouped_paulis()

resolved by #188


Placement of the Total Size Element

Currently the total size element is shown at the very top at the page. This was intentional as then it is always visible when navigating around a repo's page. However, we should consider also displaying it at more intuitive places on the repo's home page. As a side-note the element is currently by mistake inside the settings li element. This creates an unexpected look when selecting the settings tab.
.
Files to look at:

src/scripts/internal/selectors.ts
src/scripts/internal/dom-manipulator.ts
src/scripts/internal/element-factory.ts

so far i've made some progress on this i managed to separate the elements, but for some reason the underline effect is still there, its a part of UnderlineNav-item but i couldn't find what exactly does or undoes it


Am I looking at it wrong or is the "prediction" simply a time delayed noisy copy of the input sequence?

I have not looked through the project yet but it seems like you went through an extremely complex method just to generate a poor quality time delayed duplicate of the input?
I am not critical I am just trying to understand what I am seeing?

Hi @donjonson,
The idea here is to use deep learning to predict a certain value in the future. So whatever you are seeing in the output is part of a decision made by the network which is in line with the market trend and with very little error (MSE (Mean Square Error) of 0.14%). This might seem overly complicated but it's a good way to build a history on previous values (given a time window to inspect) and then see a prediction given by the model.


Disable or hide the chart when data is null

What problem does this feature solve?
There are mutiple charts on the page, however, some of them have no data. We need to hide or disable those charts with no data.
What does the proposed API look like?
series.visible = true/false
or
series.display= true/false
or
series.show = true/false

Why not use css property display or visibility to control the visibility of chart?

The charts are all in one diagram, while the css can only control the visibility of charts in seperate diagrams.

Did you try to control it thru legend.selected ?  It works:
        legend: {
            right: 20,
            data: ['SGE', 'XAU', 'London'],
            selected: { 'SGE': true, 'XAU': true, 'London': false }   // false hides it
        },


Documentation updates

This PR does a couple things:

update documentation to be up to date with Presenter's intercept() (was register())
add ActionButton example to quickstart guide
fix various grammar typos and invalid code segments

Codecov Report

Merging #273 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #273   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          23     23
  Lines         750    750
=====================================
  Hits          750    750

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2523bb...0d07cf0. Read the comment docs.

@nhunzaker this probably clashes with #272, so let's be sure to coordinate when things are to be merged in.

@mackermedia did you want to take a gander at this?

@efatsi Feel free to merge at your leisure.

👍


Fix black flicker on resize

Describe the issue
Previously resize happened in the OnImGuiRender function
this runs after OnUpdate where the framebuffer gets filled.
This resulted in ImGui rendering an unfilled/new texture on every
resize.
Proposed fix
This changes the code to do the resize as the first step in OnUpdate before we will render to the framebuffer, so we always have a filled framebuffer to render in OnImGuiRender.

Looks like a good solution to me 👍
This does feel like part of the renderer preparations, so maybe this should be part of the renderer prep scope, right before binding the framebuffer?
https://github.com/TheCherno/Hazel/blob/24990184428c4a0e96f9a752df49f00459f79766/Hazelnut/src/EditorLayer.cpp#L49-L54
Another reason why I would change this, it does feel like the CameraController should be updated depending on the current visible frame instead of on the new one, meaning that the first thing would be the m_CameraController.OnUpdate(ts);
So my suggestion would look like:
	void EditorLayer::OnUpdate(Hazel::Timestep ts)
	{
		HZ_PROFILE_FUNCTION();

		// Update
		m_CameraController.OnUpdate(ts);

		// Render
		Hazel::Renderer2D::ResetStats();
		{
			HZ_PROFILE_SCOPE("Renderer Prep");

			// Resize
			if (Hazel::FramebufferSpecification spec = m_Framebuffer->GetSpecification();
				m_ViewportSize.x > 0 && m_ViewportSize.y > 0 && // zero sized framebuffer is invalid
				(spec.Width != m_ViewportSize.x || spec.Height != m_ViewportSize.y))
			{
				m_Framebuffer->Resize((uint32_t)m_ViewportSize.x, (uint32_t)m_ViewportSize.y);
				m_CameraController.OnResize(m_ViewportSize.x, m_ViewportSize.y);
			}

			m_Framebuffer->Bind();
			Hazel::RenderCommand::SetClearColor({ 0.1f, 0.1f, 0.1f, 1 });
			Hazel::RenderCommand::Clear();
		}

		... // The rest of the existing code

Any thoughts?

Hmm, not entirely sure. Would have to look into how the camera does things. But I think right now it doesn't really make any difference.
The PR as is was to maintain original resize 'flow'.
Before:
OnUpdate
OnImGuiRender <- Resize Happened in here
OnUpdate

After:
OnUpdate
OnImGuiRender <- Resize change 'request' here
OnUpdate <- Change viewport and camera before actual render

I am happy to change it, but I am not sure what the intended 'flow' is supposed to be here now. Right

Hmm, not entirely sure. Would have to look into how the camera does things. But I think right now it doesn't really make any difference.
...
I am happy to change it, but I am not sure what the intended 'flow' is supposed to be here now. Right

You don't have to change it. I can see that you want to keep the layout, and it won't affect the camera at all as of now.
The main reason I asked is for the profiler, where it doesn't make a lot of sense (to me) that the resize would be counted as part of the on_update loop, and not part of the rendering, hence why I would've put it inside the "Renderer prep" scope. Another thought would be to put a profile scope "Renderer resize" or something. However this might indeed be outside the scope of this PR, so no need to change that.

Hmm, not entirely sure. Would have to look into how the camera does things. But I think right now it doesn't really make any difference.
...
I am happy to change it, but I am not sure what the intended 'flow' is supposed to be here now. Right

You don't have to change it. I can see that you want to keep the layout, and it won't affect the camera at all as of now.
The main reason I asked is for the profiler, where it doesn't make a lot of sense (to me) that the resize would be counted as part of the on_update loop, and not part of the rendering, hence why I would've put it inside the "Renderer prep" scope. Another thought would be to put a profile scope "Renderer resize" or something. However this might indeed be outside the scope of this PR, so no need to change that.

I agree, though I think eventually this frame buffer resize should probably live in some other place, like a PreUpdate or PostRender phase maybe, not sure.

My Purposed Solution :
the variable 'last' is declared global for temporary purpose, as it's not a good coding convention, it should be moved at any other place.
ImVec2 last;

void EditorLayer::OnUpdate(Hazel::Timestep ts)
{
	HZ_PROFILE_FUNCTION();

	// Update
	if (m_ViewportFocused)
		m_CameraController.OnUpdate(ts);

	// Render
	Hazel::Renderer2D::ResetStats();
	{
		HZ_PROFILE_SCOPE("Renderer Prep");

		if (m_ViewportSize != *((glm::vec2*) & last))
		{
			m_Framebuffer->Resize((uint32_t)last.x, (uint32_t)last.y);
			m_ViewportSize = { last.x, last.y };

			m_CameraController.OnResize(last.x, last.y);
		}

		m_Framebuffer->Bind();
		Hazel::RenderCommand::SetClearColor({ 0.1f, 0.1f, 0.1f, 1 });
		Hazel::RenderCommand::Clear();
	}

		m_Framebuffer->Bind();
		Hazel::RenderCommand::SetClearColor({ 0.1f, 0.1f, 0.1f, 1 });
		Hazel::RenderCommand::Clear();
	}

        //-----------exisiting code.................

and
ImGui::PushStyleVar(ImGuiStyleVar_WindowPadding, ImVec2{ 0, 0 });
ImGui::Begin("Viewport");

m_ViewportFocused = ImGui::IsWindowFocused();
m_ViewportHovered = ImGui::IsWindowHovered();
Application::Get().GetImGuiLayer()->BlockEvents(!m_ViewportFocused || !m_ViewportHovered);

ImVec2 viewportPanelSize = ImGui::GetContentRegionAvail();
last = viewportPanelSize;

uint32_t textureID = m_Framebuffer->GetColorAttachmentRendererID();
ImGui::Image((void*)textureID, ImVec2{ m_ViewportSize.x, m_ViewportSize.y }, ImVec2{ 0, 1 }, ImVec2{ 1, 0 });
ImGui::End();
ImGui::PopStyleVar();

My Purposed Solution :
the variable 'last' is declared global for temporary purpose, as it's not a good coding convention, it should be moved at any other place.
ImVec2 last;

void EditorLayer::OnUpdate(Hazel::Timestep ts)
{
	HZ_PROFILE_FUNCTION();

	// Update
	if (m_ViewportFocused)
		m_CameraController.OnUpdate(ts);

	// Render
	Hazel::Renderer2D::ResetStats();
	{
		HZ_PROFILE_SCOPE("Renderer Prep");

		if (m_ViewportSize != *((glm::vec2*) & last))
		{
			m_Framebuffer->Resize((uint32_t)last.x, (uint32_t)last.y);
			m_ViewportSize = { last.x, last.y };

			m_CameraController.OnResize(last.x, last.y);
		}

		m_Framebuffer->Bind();
		Hazel::RenderCommand::SetClearColor({ 0.1f, 0.1f, 0.1f, 1 });
		Hazel::RenderCommand::Clear();
	}

		m_Framebuffer->Bind();
		Hazel::RenderCommand::SetClearColor({ 0.1f, 0.1f, 0.1f, 1 });
		Hazel::RenderCommand::Clear();
	}

        //-----------exisiting code.................

and
ImGui::PushStyleVar(ImGuiStyleVar_WindowPadding, ImVec2{ 0, 0 });
ImGui::Begin("Viewport");

m_ViewportFocused = ImGui::IsWindowFocused();
m_ViewportHovered = ImGui::IsWindowHovered();
Application::Get().GetImGuiLayer()->BlockEvents(!m_ViewportFocused || !m_ViewportHovered);

ImVec2 viewportPanelSize = ImGui::GetContentRegionAvail();
last = viewportPanelSize;

uint32_t textureID = m_Framebuffer->GetColorAttachmentRendererID();
ImGui::Image((void*)textureID, ImVec2{ m_ViewportSize.x, m_ViewportSize.y }, ImVec2{ 0, 1 }, ImVec2{ 1, 0 });
ImGui::End();
ImGui::PopStyleVar();

I watched the video for the first time because i was having some aspect ratio in my engine, and found the flash issue isn't fixed in current branch, I faced such issue before so i caught it, it is,
we have bind the framebuffer
we filled framebuffer and unbind
we resized framebuffer, which resulted in an empty texture
we passed empty texture to ImGui


Create single file in TensorBoardLogger

What does this PR do?
Fixes #740
The idea is to hack into add_hparams method and instead of creating new tfevents file use existing one.

@festeh mind rebasing?

@williamFalcon done


Hops not working properly

Calling $this->flashMessenger()->addMessage("Message text", "namespace", 2) does not work as desired. It seems that the method getMessagesFromContainer() in vendor/zendframework/zend-mvc/src/Controller/Plugin/FlashMessenger.php unsets all namespaces, but it shouldn't do so.

does not work as desired

Can you explain:

What is the behavior you expect?
What are you actually observing?

I've created a pull request. https://github.com/zendframework/zend-mvc/pull/9


mac build fails with "ld: library not found for -lTHC"

mac build fails with "ld: library not found for -lTHC"
https://travis-ci.org/hughperkins/clnn/builds/99839333

(Note: the pull referenced above has nothing to do with this issue)

I think this is fixed by https://github.com/hughperkins/clnn/commit/7c83307de34c291bebccb129f27aaa17e0ce406c

After updating to most recent clnn version, build goes through, but now ´require 'clnn'´ fails:
´´´
th> require 'clnn'
libthclnn_searchpath	nil
...ta/Users/jan/torch/install/share/lua/5.1/clnn/THCLNN.lua:11: bad argument #1 to 'load' (string expected, got nil)
stack traceback:
[C]: in function 'load'
...ta/Users/jan/torch/install/share/lua/5.1/clnn/THCLNN.lua:11: in main chunk
[C]: in function 'require'
...Data/Users/jan/torch/install/share/lua/5.1/clnn/init.lua:5: in main chunk
[C]: in function 'require'
stdin:1: in main chunk
[C]: at 0x010486aba0
´´´

Ah, interesting.  Getting closer :-)  Will take a look.

(created new issue for this)


Upgrade: set provisionGeneration when reset RKEConfig

To prevent another RKE2 server/agent restart on all nodes when an upgrade is done.
Problem:

We reset RKEConfig to default after an upgrade and this trigger RKE2 server/agent restarts.
Solution:

Fill in the right provisionGeneration so the rancher agent doesn't restart RKE2 server or agents.
Related Issue:
https://github.com/harvester/harvester/issues/2984
Test plan:

References:

In rancher, it writes ProvisionGeneration as restart_stamp.
In system-agent, it read restart_stamp from the file and check with prior value. If they are different, it will restart rke2.


Signal padding for matching start and end points

Cool package!
I'm trying to understand the _padding_signal function here.
Why do you take the abs values of the difference for padding, and why do you add the padding to the end values instead of subtracting?
I'm trying to get the smoothed signal to match the start and end point of the original filter, and when I change these two things, it works.
Just wondering if doing it my way breaks something else?

Thanks for the message.
If you have an MWE would be useful. The padding is just to match the implementation here: https://scipy-cookbook.readthedocs.io/items/SavitzkyGolay.html.

Here's a MWE:
using SavitzkyGolay, Plots

w = 3
o = 1

# Non-matching start point

x = [1;0;1]
plot(x)
plot!(savitzky_golay(x,w,o).y)

# Non-matching end point

x = [0;1;0]
plot(x)
plot!(savitzky_golay(x,w,o).y)

# Matching start and end point with modified padding

function SavitzkyGolay._padding_signal(y::AbstractVector, hw::Int64)
    initvals = y[1] .- (reverse(y[2:hw+1]) .- y[1])
    endvals = y[end] .- reverse(y[end-hw:end-1] .- y[end])
    return vcat(initvals, y, endvals)
end

x = [1;0;1]
plot(x)
plot!(savitzky_golay(x,w,o).y)

x = [0;1;0]
plot(x)
plot!(savitzky_golay(x,w,o).y)

A new tag was created. The tagbot should add it soon. Thanks!


Question: UITableViewCell

Would it be possible to add this to a UITableViewCell?

I have add some tags in to contentView, and I can scroll through the tags, but It is not smooth


Evaluate static styles during initialization phase

Currently all styles are processed during render phases, however, there's a subset of styles that can be evaluated during the factory phase to prevent additional computations that can be avoided during the render phases.

An example can be pointed to in glamorous-native:

When the factory is called, the provided styles are immediately evaluated to process any static styles.
During the render phase, the styles (which include the processed static styles) are sent off for processing.
When processing we now only care to process style functions, and the rest are handled by react native (in your case, glamor)

I love this plan. Need two caveats.

The user could manipulate static style objects and expect that to change styles on next render. So I wonder if we could warn the user if they try that in development mode. If that's not reasonable then we can just document it...
 So we don't pay for what's not rendered. So yes it's only evaluated once, but it's only evaluated when it's first rendered if that makes sense.

Thanks for the issue. This would be great!

So I wonder if we could warn the user if they try that in development mode.

I like this -- Object.freeze in dev?

Brilliant - so run on first render, rather than on factory initialization?

I like this -- Object.freeze in dev?

Unfortunately Object.freeze wont warn the user. We'd have to replace all properties with getters and setters. Probably not worth it but maybe?

so run on first render, rather than on factory initialization?

Yes

In any case, this could technically be a breaking change so I'd prefer to get this implemented before v4 is pushed out :smile:

Just looking into this, it appears glamor already does some* of this when passed predefined objects.
https://github.com/threepointone/glamor/blob/master/docs/weakmaps.md
so this could be as simple as adding something like
      warmUpGlamorCache(GlamorousComponent.styles)
      return GlamorousComponent
...
/**
 * This function takes styles and runs css on them to ensure they
 * end up in the glamor WeakMap cache
 * https://github.com/threepointone/glamor/blob/master/docs/weakmaps.md
 */
export function warmUpGlamorCache(...styles) {
  let current
  const cacheableStaticStyles = []
  for (let i = 0; i < 3; i++) {
    current = styles[i]
    if (typeof current !== 'function' &&
      typeof current !== 'string' &&
      Array.isArray(current) === false
    ) {
      cacheableStaticStyles.push(current)
    }
  }
  css(...cacheableStaticStyles)
}

note only for the first three args.

I'd thought that maybe glamor already optimized for this! Considering we wanted to do lazy evaluation, I think it's actually it's probably best as it is now. So I'm going to close this.
However, if anyone wants to make a benchmark and see what's actually faster that'd be cool 😉

Thank you for looking into that @luke-john!

Oh that is awesome. Sunil killing it ofc.


The Vault issuer can now be given a serviceAccountRef

⚠ I paused this PR due to the security concerns with regards to the RBAC rules required by this PR

As detailed in #4144, the Vault issuer is only able to use a Secret in order to use the "Kubernetes authentication" method. The downside to this service account Secret token is that it has the default JWT is "kubernetes/serviceaccount" (along with the fact that the token is not bound to a particular pod and has no expiry).
With the new serviceAccountRef field, cert-manager now requests the token on behalf of the pod in order to authenticate with Vault.
I manually tested the feature on these environments:

kind cluster (Kubernetes 1.21) with an internal Vault running as a deployment.
EKS cluster (Kubernetes 1.20) with an internal Vault running as a deployment.

Still to be done:

[ ] Unit tests,
[ ] End-to-end tests,
[ ] Documentation on the website.

Notes to the reviewer:

No token rotation is done here, which might become a problem since a TokenRequest API call to the apiserver is made every time the Vault client is created, which happens every time a resync of a CertificateRequest referencing a Vault issuer.
This approach requires cert-manager to be given even more permissions.
The expiry is currently hardcoded to 2 hours.
The audience is currently hardcoded to vault.
I had to change the vault.auth.kubernetes.secretRef from mandatory to optional; I don't think that's a breaking change since I am relaxing constraints.

UPDATE: another idea, suggested in https://github.com/jetstack/cert-manager/issues/2345, is to reuse cert-manager's own token to do the authentication. I don't know what are the security implications of this yet.

We just hit this in one of our dev environments. What's the likely timeline for a release assuming this solution is accepted (I see some alternatives being mentioned)?

Hi. If this solution is accepted (it seems like the discussion is going towards implementing it with serviceAccountRef), I plan on getting this PR merged for 1.7, but you can expect a 1.7.0-alpha.0 to test the feature probably next week or the week after.

I feel more and more uncomfortable with the idea of giving even more privileges to cert-manager. More specifically, this feature requires adding to everybody's cert-manager a "god-like" role:
- apiGroups: [""]
  resources: [serviceaccounts/token]
  verbs: [create]

With this new role, cert-manager is able to make requests to the apiserver using any service account that exists across all namespaces. If one of them has more privileges than cert-manager's own service account, it is a privilege escalation.
I have looked around to see if anyone else is using this role and the TokenRequest API, and whether there is a way to "minimize" the impact of this new role.
It seems like only cloud providers controllers, such as cloud-provider-aws, have "seriously" been using this feature.
cloud-provider-aws is only able to request tokens for three service accounts using resourceNames:
- apiGroups:
  - ""
  resourceNames:
  - node-controller
  - service-controller
  - route-controller
  resources:
  - serviceaccounts/token
  verbs:
  - create

The strings node-controller, service-controller and route-controller are
"controller roles" as described in Roles for built-in controllers. These are service accounts that can't be "seen" using kubectl get sa.

I feel more and more uncomfortable with the idea of giving even more privileges to cert-manager. More specifically, this feature requires adding to everybody's cert-manager a "god-like" role:
- apiGroups: [""]
  resources: [serviceaccounts/token]
  verbs: [create]

With this new role, cert-manager is able to make requests to the apiserver using any service account that exists across all namespaces. If one of them has more privileges than cert-manager's own service account, it is a privilege escalation.
I have looked around to see if anyone else is using this role and the TokenRequest API, and whether there is a way to "minimize" the impact of this new role.
It seems like only cloud providers controllers, such as cloud-provider-aws, have "seriously" been using this feature.
cloud-provider-aws is only able to request tokens for three service accounts using resourceNames:
- apiGroups:
  - ""
  resourceNames:
  - node-controller
  - service-controller
  - route-controller
  resources:
  - serviceaccounts/token
  verbs:
  - create

The strings node-controller, service-controller and route-controller are
"controller roles" as described in Roles for built-in controllers. These are service accounts that can't be "seen" using kubectl get sa.

I would also prefer the approach outlined in #2345. We currently use Banzai Bank-Vaults to inject Vault secrets into the pod's ENV which also makes requests to Vault using the pod's service account token.

Hi,
After a discussion on Slack, due to the high level of privileges required for the serviceAccountRef to be implemented this way, I decided to close this PR and try to think of a better way.
On a positive note, #2345 suggests re-using the existing token mounted to the cert-manager pod, which seems a much better approach. The only issue is that when we hand Vault the token, it will have way too many permissions (such as reading secrets). Vault does not require any permission to call the the tokenreview API.

As we can see the implementation for this particular feature presented multiple security challenges, that are currently reflected in https://hackmd.io/MNQf9ReSR6GdkFl04oS-fA
However, It seems that even the Vault team is actually advising to set "disable_iss_validation=true" (or leave blank for 1.9+ as it's default) on the authentication engine:
This would be the most straightforward fix and the threat modelling from Vault seems to indicate this is a "double" validation anyways.
So to summarise there are 2 main options at present:

Disable iss validation on Kubernetes engine as Vault post suggests.
Have two different Kubernetes Auth engines with different iss validation values and bind service accounts accordingly, this is more secure but add a configuration burden.

If you're actually already on Vault 1.9 the iss issuer validation, which is causing this whole issue is being deprecated.
this means installing for example on EKS 1.21 with Vault 1.9+ without setting the issuer for the Kubernetes engine is now recommended (because of this exact issue) as first reported here, thanks to @avoidik for the heads' up!
So that first workaround of disabling the disable_iss_validation=true for (1.9 or below) and leaving blank from 1.9+ is now the most sensible approach for Kubernetes vault auth engine, which sidesteps the issue.
Aside from issuer validation, we would want to natively support bounded service accounts as it adds an extra layer of security but we can now say conclusively that this is not a blocker to cert-manager vault issuer setup in Kubernetes 1.21+.
Thus I think we can safely close this issue and open a separate one for bounded service account support for issuers in general in cert-manager.

Note: I re-created this PR in https://github.com/cert-manager/cert-manager/pull/5502.


Add workflow sample fanout/fanin

Description
Please reference the issue #1203

@MregXN First of all, thank you very much for your contributions!
I'd like to merge this and your other PRs, but it looks as though they're using the since-deprecated methods on the DaprClient instead of those from the separate Dapr.Workflow client.
Each client had the same general layout, so I created a matching review on each and suggested a few typo corrections to the README. If you're able to get these changes made, I don't see any other blockers to merging each of these into 1.15 barring a brief review following your updates.


translation , column sorting and on type search

Hello, i've added portuguese translation by myself, but if you could add it by default would be awesome, also, i'm not sure yet if there is already, but sorting columns (if there isnt already) like this
https://jbaysolutions.github.io/vue-bootstrap-table/examples/01-basic.html
and the thing I would really appreciate if you could do is search on the type, like this thing (above example have on type filtering as well)
https://www.w3schools.com/howto/howto_js_filter_table.asp
Thanks in advance

This feature will be available in the next version :+1:


subscription or tenant level - looks wrong

[Enter feedback here]
Hi should this say root or "tenant" level rather than subscription level ?
A management group tree can support up to six levels of depth. This limit doesn't include the root or subscription level.
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e38786a5-e931-e614-55a1-2980b8a28087
Version Independent ID: a72b6f97-dd0f-252c-f6d9-f1c517aa9a2f
Content: Management group and subscription organization - Cloud Adoption Framework
Content Source: docs/ready/enterprise-scale/management-group-and-subscription-organization.md
Service: cloud-adoption-framework
Sub-service: ready
GitHub Login: @BrianBlanchard
Microsoft Alias: brblanch

Thanks for reporting - this issue is under review.  This is a Microsoft Internal DevOps Bug ID AB#241656

Updating the sentence to: "This limit doesn't include the tenant root level or the subscription level."
The subscription level and below are not included in the hierarchy limit.
This issue will be resolved via a PR in the next several days.


win: add S_ISFIFO macro

Needed now that libuv is setting the mode correctly for named pipes.
Refs: https://github.com/libuv/libuv/pull/3811

Released as v0.0.18. The Node.js update PR is at https://github.com/nodejs/node/pull/47866


Expand available filters, give applications the ability to filter and order via ENV

Developer

[ ] All new ENV is documented in README
[ ] All new ENV has been added to Heroku Pipeline, Staging and Prod
[ ] ANDI or Wave has been run in accordance to
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
[ ] Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

[ ] The commit message is clear and follows our guidelines
(not just this pull request message)
[ ] There are appropriate tests covering any new functionality
[ ] The documentation has been updated or is unnecessary
[ ] The changes have been verified
[ ] New dependencies are appropriate or there were no changes

Requires database migrations?
YES | NO
Includes new or updated dependencies?
YES | NO

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

9 of 9 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 99.465%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
372

Relevant Lines:
374

💛  - Coveralls

One more thing to add, in case you mention this detail in an amended commit message: GDT-128 can actually merge without the access type filter. That one has its own ticket (GDT-140), as it's a bit different from the others.


Inspections: amsmath is included in mathtools package

When checking for required packages of things like align* or cases environment, currently amsmath is required but if you require the mathtools package then the amsmath package is included so that will also suffice.
This generates inspection error but compiles:
\documentclass{article}
\usepackage{mathtools}
\begin{document}
    \begin{align*}
        1
    \end{align*}
\end{document}

This is something that will definitely be fixed when we figure out a way to include LaTeX SDKs, which will resolve package dependencies and includes automatically.
Until that time, we may need a temporary fix where we list package inclusions by hand (paging @RubenSchellekens for his opinion on this).

Yes


Update README.md for prettier-plugin-sort-imports change

Ref: https://github.com/cpojer/vite-ts-react-tailwind-template/commit/165a5ff75bb272799d156befbc5c8ccc9ef65bf6

Missed this reference, thank you!


Automated cherry pick of #1248: fix share resource left join

Cherry pick of #1248 on release/2.10.0.
#1248: fix share resource left join

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.10.0@af73a69). Click here to learn what that means.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             release/2.10.0   #1250   +/-   ##
================================================
  Coverage                  ?   7.92%
================================================
  Files                     ?     367
  Lines                     ?   57357
  Branches                  ?       0
================================================
  Hits                      ?    4547
  Misses                    ?   52410
  Partials                  ?     400

Flag
Coverage Δ

#aFlag
7.92% <0%> (?)

Impacted Files
Coverage Δ

pkg/cloudcommon/db/sharablevirtual.go
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af73a69...d17a767. Read the comment docs.

/lgtm
/approve


Create otpverification.html

Description
Please include a summary of the change and which issue is fixed.
Fixes #(issue_no)
Replace issue_no with the issue number which is fixed in this PR
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] My code follows the style guidelines(Clean Code) of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have created a helpful and easy to understand README.md
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works

hello, please accept this as a contribution to hacktoberfest. I am new to coding so forgive me for this.


Revert "Create usePaginatedReportActions hook"

Reverts Expensify/App#44412

Not saying this is causing any problems just trying some stuff


Update xtensor-zarr=0.0.7

Trigger CI

The error is related to zarr.js:
(node:3417) ExperimentalWarning: The ESM module loader is experimental.
file:///home/runner/work/zarr_implementations/zarr_implementations/generate_data/js/src/index.js:3
import { PNG } from "pngjs";
         ^^^
SyntaxError: The requested module 'pngjs' does not provide an export named 'PNG'
    at ModuleJob._instantiate (internal/modules/esm/module_job.js:92:21)
    at async ModuleJob.run (internal/modules/esm/module_job.js:107:20)
    at async Loader.import (internal/modules/esm/loader.js:179:24)

Maybe @manzt has some ideas?

Looks like a node version? No sure when/where that changed. The experimental warning is like from node pre-14. Ideally it should be node v15.

Thanks, maybe adding the gdal dependency is responsible for downgrading node.

Can reproduce locally with node v12.
$ fnm use 12 # change node version
Using Node v12.19.1

$ npm start

> @ start /Users/fm813/github/manzt/zarr_implementations/generate_data/js
> node src/index.js

(node:43251) ExperimentalWarning: The ESM module loader is experimental.
file:///Users/fm813/github/manzt/zarr_implementations/generate_data/js/src/index.js:3
import { PNG } from "pngjs";
         ^^^
SyntaxError: The requested module 'pngjs' is expected to be of type CommonJS, which does not support named exports. CommonJS modules can be imported by importing the default export.
For example:
import pkg from 'pngjs';
const { PNG } = pkg;
    at ModuleJob._instantiate (internal/modules/esm/module_job.js:97:21)
    at async ModuleJob.run (internal/modules/esm/module_job.js:143:20)
    at async Loader.import (internal/modules/esm/loader.js:182:24)
    at async Object.loadESM (internal/process/esm_loader.js:84:5)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @ start: `node src/index.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the @ start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      /Users/fm813/.npm/_logs/2021-05-01T13_02_24_462Z-debug.log

on 15,
$ fnm use 15
Using Node v15.6.0

$ npm start

> start
> node src/index.js

@manzt I worked around the older version of npm, but I'm not sure if the changes would be acceptable to you.
Now the failures seem to be caused by the zarr-python implementation:
FAILED test/test_read_all.py::test_correct_read[read zarr (FSStore, nested) zarr using zarr, blosc]
FAILED test/test_read_all.py::test_correct_read[read zarr (FSStore, nested) zarr using zarr, gzip]
FAILED test/test_read_all.py::test_correct_read[read zarr (FSStore, nested) zarr using zarr, raw]
FAILED test/test_read_all.py::test_correct_read[read zarr (FSStore, nested) zarr using zarr, zlib]

@davidbrochart, this has to deal with how modules written for a legacy module system (common-js) are loaded in Node & browser as more modern ES modules. ESM is experimental in Node 12, but the changes you've made are supported in 12 and later. Changes totally acceptable -- thanks!

Thank you @manzt.
@grlee77 any idea why zarr-python tests are failing?

I'd suspect due to https://github.com/zarr-developers/zarr-python/pull/729

I'd suspect due to zarr-developers/zarr-python#729

agreed. it should be fixed again after zarr-developers/zarr-python#709 is finished

This branch works locally with zarr 2.8.3 if you want to bump environment.yml to use that version here.


Mixamo support

This PR adds support to import mixamo animations, they can be set in manifest and dragged and dropped into the scene for quick testing, issue #18
https://github.com/M3-org/CharacterStudio/assets/1117257/e243719f-e783-465a-9929-ddaa0a1a0929

Did a few tests on new downloaded models and had some issues, will correct and pr again

Should be working now :)
https://github.com/M3-org/CharacterStudio/assets/1117257/81276eaa-29fb-46a2-92f7-d3569ca3254b

LGTM


add shipping svc integration with UI

This PR is included in version 1.0.0 :tada:

This PR is included in version 1.0.0 :tada:


Assign $$observable to prototype directly

The previous implementation didn't work because you can't assign
an object's Symbols to another object. Symbol properties
aren't enumerable, so they don't get assigned with extend.
It has to be assigned directly to the prototype object.

Done. There's a fuller explanation in the git commit as well.

Thanks! Released 3.2.5 with it.


Fix welcome text contrast

Description
Attempt to close #1787 by only applying additional scaling on macOS.
In long term we should move welcome visual to be done with Qt widget and not vispy, but that can come later
cc @jni @VolkerH
Type of change

[x] Bug-fix (non-breaking change which fixes an issue)


The sync feature flag is not compatible with no_std

when i enable both the sync and the no_std feature flags, rhai won't compile due to using std::sync::RwLock, which is not provided by the no-std-compat crate due to not using the compat_sync feature flag of that crate.
this can simply be solved by enabling the compat_sync feature flag of the no-std-compat crate.

Ah, thanks for this. Will you make a PR? Or I can do it.


fix: Replace table instead of dropping and renaming for BigQuery

This avoids getting a 404 error and then creating, which sometimes is cached by the BigQuery service and then reports a 404 even when the table has just been created.
https://github.com/googleapis/google-cloud-go/issues/975#issuecomment-383294334

I think you answered your own question. Creating a table is an eventually consistent operation: it may not appear to exist everywhere until after some time has passed. In the screenshots above, the second request, which happens 2 seconds after the first, may end up at a different location where the creation hasn't yet propagated.

Disclaimer
I think this works. There is no real way to test but to release it to users and await complaints.

closes FEA-156

https://github.com/fal-ai/fal/actions/runs/2464595265

https://github.com/fal-ai/fal/actions/runs/2469745557


drivers: serial: uart_mcux_lpuart: Add configure functions

This allows changing baudrate, parity, stop bits, data bits and flow
control in runtime with the uart_configure function from the UART API.
The implementation is very similar to that of nrf52.
It's been tested on the MIMXRT1020EVK board and signals have been
verified with an oscilloscope.

@galak I have implemented config_get and the uart_basic_test was successful with the following output:
*** Booting Zephyr OS build zephyr-v1.14.0-13508-g37480e532ed7  ***
Running test suite uart_basic_test
===================================================================
START - test_uart_configure
 PASS - test_uart_configure
===================================================================
START - test_uart_config_get
This is a configure_get test.
 PASS - test_uart_config_get
===================================================================
START - test_uart_fifo_fill
This is a FIFO test.
 PASS - test_uart_fifo_fill
===================================================================
START - test_uart_fifo_read
Please send characters to serial console
 PASS - test_uart_fifo_read
===================================================================
START - test_uart_poll_in
Please send characters to serial console
 PASS - test_uart_poll_in
===================================================================
START - test_uart_poll_out
This is a POLL test.
 PASS - test_uart_poll_out
===================================================================
Test suite uart_basic_test succeeded
===================================================================
PROJECT EXECUTION SUCCESSFUL

@MaureenHelm As requested I've removed the irq locks. The uart_basic_test was successful with the same results as before

@endianjesper Will you please rebase to rerun CI? This PR didn't quite make it in time before merge window closed for the 2.4 release, but the merge window reopened today for the next release.

@MaureenHelm I've rebased and pushed.


How to add attributedString in the subtitle?

It is a great work! Can I add some attributedString in the subtitle?

The 3.0 branch allows you too but unfortunately it is a bit out of sync with the main master branch in terms of bug fixes right now due to the branches diverging. I plan on resolving that problem sometime soon.

Attributed string support is coming very soon I believe. RMessage has been rewritten in Swift for 3.0.0.

Closing this issue, support for attributed strings can be done by customizing the passed in RMessageSpec before displaying a message.


fix: Fix artwork information overlap in first inquiry collapse

The type of this PR is: Bugfix
This PR resolves PURCHASE-2248
Description
Replaced the makeshift component with Pallette's collapse to avoid issue where artwork information would visually overlap. See ticket for former behaviour. Current behaviour:

PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a CHANGELOG.yml entry or my changes do not require one.

Oops. Fixing test.

Looks good 👍. Will have it squash on green.


Add Support for Single Vm Deployment

What does this PR do?
This PR adds support for Single Virtual Machine Deployment of OCP.
How should this be manually tested?
Create a deployment using the template, verify that resource group is created, one vm is created,
and that openshift is installed, and a app can be launched.
Is there a relevant Issue open for this?
None
Who would you like to review this?
cc: @e-minguez  @cooktheryan  PTAL

Switched to off already
Sent from my iPhone

On 8 Aug 2017, at 2:17 PM, Eduardo Mínguez<EMAIL_ADDRESS>wrote:
@e-minguez commented on this pull request.
In reference-architecture/azure-ansible/allinone.json:

 "metadata" : {

   "description" : "Azure AD Client Secret"

 }

},
"metrics" : {

 "type" : "bool",

 "defaultValue" : true,

 "metadata" : {

   "description" : "Enable OCP metrics"

 }

},
"logging" : {

 "type" : "bool",

 "defaultValue" : true,

 "metadata" : {

   "description" : "Enable OCP aggregated logging"

Making it default is overkill (3 elasticsearch pods + kibana + curator + fluentd) for an all-in-one.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


fix: typescript types on abstractchart (#368 #363)

Closes #368 and #363
This makes the types in AbstractChart optional. I ran the app with the changes in expo and didn't see any issues.
Let me know if there was anything I missed or further testing I need to do.

thanks, this is now available in v6.4.1


Loading progress animation?

Hello, was wondering how it's possible to achieve the downward animation of the progress bar when loading is complete as it simply disappears for me (without any animation). Thanks.

The reason is because I wasn't handling the adapter states correctly. Always make sure to notify the adapter with the correct range and size.


Binding failed in parent class

this is my code:
`
public class BaseActivity extends AppCompatActivity {
public enum ToolbarMode {
    MODE_BACK,
    MODE_NONE
}

@BindView(R.id.toolbar)
Toolbar mToolbar;

@BindView(R.id.toolbar_title)
TextView tvToolbarTitle;
@Override
public void setContentView(@LayoutRes int layoutResID) {
    super.setContentView(layoutResID);
    ButterKnife.setDebug(true);
    ButterKnife.bind(this);
}
public void setContentView(@LayoutRes int layoutResID, @StringRes int titleID) {
    setContentView(layoutResID, titleID, ToolbarMode.MODE_BACK);
}
public void setContentView(@LayoutRes int layoutResID, @StringRes int titleID, ToolbarMode mode) {
    setContentView(layoutResID);
    tvToolbarTitle.setText(titleID);

`
and this is the log:
D/ButterKnife: Looking up binding for cn.com.xx..MainActivity
D/ButterKnife: Not found. Trying superclass cn.com.xx.base.BaseActivity
D/ButterKnife: Not found. Trying superclass android.support.v7.app.AppCompatActivity
D/ButterKnife: MISS: Reached framework class. Abandoning search.
what should i do

Do you see the generated ViewBinder classes in your build/generated/ folder?

There is no such file. I can only find a R.java in butterKnife package, and it's empty.

Have you followed the instructions in the README for setting up the
annotation processor?
On Sun, Aug 13, 2017 at 11:47 PM chengz<EMAIL_ADDRESS>wrote:

Reopened #1054 https://github.com/JakeWharton/butterknife/issues/1054.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/JakeWharton/butterknife/issues/1054#event-1204262767,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEEEU8LTc-SyeHm3MTqJOW5k_HUnt3zks5sX-1_gaJpZM4O1_DE
.

Yes, that's the reason. I'm very sorry to bother you.  I got used to the old version.