pythonPackages.alarmdecoder: init at v1.13.9

Motivation for this change
This includes:

pythonPackages.pyftdi: v0.44.2 -> 0.49.0
pythonPackages.alarmdecoder: init at v1.13.9
home-assistant: regenerate component-packages.nix (alarmdecoder)

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

> nixpkgs-review rev HEAD
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
$ git worktree add /home/cole/.cache/nixpkgs-review/rev-d18e1c1740bbf7080a075a27c5b05c8087d88a7a/nixpkgs 7dc2439a1be07be4ed6a0e0fb9f6e6e3c97ab126
Preparing worktree (detached HEAD 7dc2439a1be)
Updating files: 100% (21298/21298), done.
HEAD is now at 7dc2439a1be Merge pull request #83515 from snicket2100/firejail-fix
$ nix-env -f /home/cole/.cache/nixpkgs-review/rev-d18e1c1740bbf7080a075a27c5b05c8087d88a7a/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit d18e1c1740bbf7080a075a27c5b05c8087d88a7a
Auto-merging pkgs/top-level/python-packages.nix
Auto-merging pkgs/servers/home-assistant/component-packages.nix
Automatic merge went well; stopped before committing as requested
$ nix-env -f /home/cole/.cache/nixpkgs-review/rev-d18e1c1740bbf7080a075a27c5b05c8087d88a7a/nixpkgs -qaP --xml --out-path --show-trace --meta
3 package added:
python2.7-alarmdecoder (init at 1.13.9) python3.7-alarmdecoder (init at 1.13.9) python3.8-alarmdecoder (init at 1.13.9)

31 package updated:
bcc bpftrace caffe can-isotp chipsec clang-wrapper-with-reexport-hack digimend-unstable digitalbitbox evdi-unstable evdi-unstable flit-build-hook libselinux mba6x_bl musl newlib nix-linter-unstable octave php-couchbase php-couchbase php-pcs php-pcs php-php_excel php-php_excel php-php_excel php-php_excel php-php_excel php-php_excel poezio prl-tools python3.7-pyftdi (0.44.2 → 0.49.0) python3.8-pyftdi (0.44.2 → 0.49.0)

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/cole/.cache/nixpkgs-review/rev-d18e1c1740bbf7080a075a27c5b05c8087d88a7a/build.nix
[3 built, 6 copied (3.2 MiB), 0.7 MiB DL]
30 package marked as broken and skipped:
clang-sierraHack digitalbitbox linuxPackages_4_4.evdi linuxPackages_hardkernel_4_14.bcc linuxPackages_hardkernel_4_14.bpftrace linuxPackages_hardkernel_4_14.can-isotp linuxPackages_hardkernel_4_14.chipsec linuxPackages_hardkernel_4_14.digimend linuxPackages_hardkernel_4_14.evdi linuxPackages_hardkernel_4_14.mba6x_bl linuxPackages_hardkernel_4_14.prl-tools muslCross newlibCross nix-linter octave-jit php72Packages-unit.php_excel php72Packages.php_excel php73Packages-unit.php_excel php73Packages.php_excel php74Packages-unit.couchbase php74Packages-unit.pcs php74Packages-unit.php_excel php74Packages.couchbase php74Packages.pcs php74Packages.php_excel python27Packages.alarmdecoder python27Packages.caffe python27Packages.flitBuildHook python38Packages.libselinux python38Packages.poezio

4 package built:
python37Packages.alarmdecoder python37Packages.pyftdi python38Packages.alarmdecoder python38Packages.pyftdi

$ nix-shell /home/cole/.cache/nixpkgs-review/rev-d18e1c1740bbf7080a075a27c5b05c8087d88a7a/shell.nix

cc: @Mic92

I'm actually a bit confused. It seems like alarmdecoder doesn't build with Python 3.5 since pytfdi isn't supported for Python 3.5. Should I then make alarmdecoder disabled = pythonOlder "3.6"? But it seems like the library works with python2?

I'm actually a bit confused. It seems like alarmdecoder doesn't build with Python 3.5 since pytfdi isn't supported for Python 3.5. Should I then make alarmdecoder disabled = pythonOlder "3.6"? But it seems like the library works with python2?

Someone probably froze it for python2, and the python3 release doesn't support python3.5

It just needs to be disabled for python35 than. We don't support any other older 3.x python interpreter.

pyftdi is optional anyway, so I think this should suffice?

as of that last push there:
> nix-build -A python36Packages.alarmdecoder
/nix/store/i7387ih3liins42k7mxn612crjms3k3b-python3.6-alarmdecoder-1.13.9
> nix-build -A python35Packages.alarmdecoder
error: alarmdecoder-1.13.9 not supported for interpreter python3.5


Everything is an error

Hello, I've recently got ACF 3 and the missile pack, but I can't see anything, I've taken some screenshots to show the problem, and yes I've installed it properly

.

Ensure you do not have any ACF content from the workshop. ACF 3 is not on workshop (yet).
Delete all ACF content from garrysmod/garrysmod/addons
Follow the installation guide here: https://github.com/Stooberton/ACF-3#manually

You can get better with diagnosing your issue in the discord server: https://discord.gg/TgDWWwFA

Ok thanks

Also It says this when I join the server, idk if this will hel

p

That's the servers version, as it says. Please refer to my previous comments for installation and further assistance.

That's the servers version, as it says. Please refer to my previous comments for installation and further assistance.

So, I have to get the servers version?
(And I did what you said from your previous comment.)

Also, it turns out that only some weapons are errors for some reason, i made a new issue about that here #224


Dual control plane upgrade support

Umbrella issue to capture work to support dual control plan upgrade. Some work will be in the installer charts, some UX changes may also be appropriate. Pending a more detailed design for 1.6.
https://docs.google.com/document/d/1d1z5PC8wvh9QiR3NesAaPm6w2HnE4-KIfjB7GB-_Wf8/edit#heading=h.qlmnvhzb2ib2
https://docs.google.com/document/d/1yxoQNfWgNFFPgyGHGvpTMN_Xy6KAoq57O2U8Wx0Nv8A/edit#heading=h.qex63c29z2to
Actual work items should refer back to this issue.

In the approved "Multiple Control Planes" document a workflow involving --set global=true is shown:
$ apply istio-1.5.0 --set revision stable --set global=true
...
# Because I made this the "global" deployment, I also get service: istiod.

During one of the UX working groups I asked if this field was in IstioOperatorSpec and I learned it was not yet present.  Can someone from Environments Create an Issue in istio/api to create that field?
(I am not thrilled with the global key name; we use global elsewhere, and it is hard to search for global in docs.  Please consider using --set default-istio=false, or --set master-istio-controlplane=false.  (The default should be true, and the name should be chosen for understandability/searchability)).

@ostromart I notice that when I supply --set revision=foo the name foo makes it into the Ingress through manifests/gateways/istio-ingress/templates/deployment.yaml doing service.istio.io/canonical-revision: {{ .Values.revision }}
To support multiple control planes the troubleshooting subcommands of istioctl need to find the correct Pilot.  That means we need to label Istiod.  I did not see anything to set the revision in manifests/istio-control/istio-discovery/files/gen-istio.yaml.  Is there a work item?

Its added by istioctl at runtime
On Mon, Mar 16, 2020 at 2:17 PM Ed Snible<EMAIL_ADDRESS>wrote:

@ostromart https://github.com/ostromart I notice that when I supply --set
revision=foo the name foo makes it into the Ingress through
manifests/gateways/istio-ingress/templates/deployment.yaml doing
service.istio.io/canonical-revision: {{ .Values.revision }}
To support multiple control planes the troubleshooting subcommands of
istioctl need to find the correct Pilot. That means we need to label
Istiod. I did not see anything to set the revision in
manifests/istio-control/istio-discovery/files/gen-istio.yaml. Is there
a work item?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/21934#issuecomment-599762246, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXJ6T44LPQZZXOUP6F3RH2JNLANCNFSM4LDHI5AA
.

We may need to change that to include it in the templates though, but thats
how it works for now.
On Mon, Mar 16, 2020 at 2:21 PM John Howard<EMAIL_ADDRESS>wrote:

Its added by istioctl at runtime
On Mon, Mar 16, 2020 at 2:17 PM Ed Snible<EMAIL_ADDRESS>wrote:

@ostromart https://github.com/ostromart I notice that when I supply --set
revision=foo the name foo makes it into the Ingress through
manifests/gateways/istio-ingress/templates/deployment.yaml doing
service.istio.io/canonical-revision: {{ .Values.revision }}
To support multiple control planes the troubleshooting subcommands of
istioctl need to find the correct Pilot. That means we need to label
Istiod. I did not see anything to set the revision in
manifests/istio-control/istio-discovery/files/gen-istio.yaml. Is there
a work item?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/21934#issuecomment-599762246, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXJ6T44LPQZZXOUP6F3RH2JNLANCNFSM4LDHI5AA
.

Related: https://github.com/istio/istio/issues/19860

@howardjohn The Istiod I created from master today did not have these labels.  Has this been merged?  Is this part of https://github.com/istio/istio/pull/22056 ?

@ostromart My comment https://github.com/istio/istio/issues/21934#issuecomment-598754147 .  Is there API support for selecting the "global" control plane?

@ostromart
The "Istio Installer Experience" doc is pretty old, replace it with UX For Multiple Control Planes.

Is there a Docs issue for dual control plane?
I tried https://preliminary.istio.io/docs/setup/additional-setup/sidecar-injection/ today and it won't work if revision is set.
cc @istio/wg-docs-maintainers

I think this can be considered complete in 1.6


Install python-gpgme so dropbox can verify its binary download

We need to trust Dropbox (well, not really, that's why we're running
it in a Docker container :-), but we shouldn't need to trust any
random FBI or KGB agent trying to carry out a man-in-the-middle
attack.
Signed-off-by: Theodore Ts'o<EMAIL_ADDRESS>

Thanks @tytso


fix: tinacms/dist/cache not found error

Fix issue #4773
Switch to dynamic imports to load the cache module so that webpack loads it properly. Also fix the cache directory to use /tmp when needed.

pushed some changes to allow dynamic imports to be used. There's still an issue with the cli dev/build commands on this project: https://github.com/comboomPunkTsucht/comboom.sucht-BLOG
Not sure what exactly is the cause yet though

This also includes CLI updates to fix #4788


Student Profile Page

Description
Students should be able to view a page with their basic profile information.

kicking this off until editor is complete


Missing receive addresses on wallet restoring fix

TICKET: https://emurgo.atlassian.net/browse/YOMO-433
The receive addresses discovering depends on external chain sync and transactions cache sync to set the lastGeneratedAddressIndex. As this action was being done between external chain sync and the transactions cache sync, not all receive addresses were being gotten in the first background sync iteration when the wallet was restored and opened first time.
Also, the receive component receive addresses hook wasn't subscribed to the transactions event, so it was unaware of the transaction cache syncs.
FIX APPLIED:

The lastGeneratedAddressIndex is set after external chain sync and transactions cache sync are done in every background sync iteration.
Receive addresses hook is subscribed to the event transactions.
The receive and send buttons are disabled while background sync is loading. This avoids accessing these components if the syncs aren't done.

Used addresses still need the transactions cache, this will be removed when adopting the address module from the lib


Improvements and bugs in Navbar elements fixed

Title and Issue number

Title :  'Featured' section added to Navbar and 'About' and 'Contact' page redirection fixed
Issue No. :164
Code Stack : HTML,CSS
Close #164

Video (mandatory)

Checklist:

[X] I have mentioned the issue number in my Pull Request.
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have created a helpful and easy to understand README.md
[X] I have updated the projectData.json file for my contribution
[X] I have added the img of my project in the assets/img section

Additional context (Mandatory )
Changes proposed in the issue, fixed. Suggestions to better the changes, welcome!
Are you contributing under any Open-source programme?

Codepeak 2023

@Swap-nil-2003 great! thanks for your contribution!


Add alias challenge-docker-stop to stop running containers

The projects that compose the backend have now the task serve-detach that start the project using docker. For example, running challenge-registry-serve automatically starts all the required backend services using docker.
I currently need to often stop all the containers using docker stop $(docker ps -q). It's not a complicated command but I could use an alias, which what this PR suggest. The alias is named challenge-docker-stop.

The alias is prefixed with challenge- to group it with other aliases defined by this project. I could be convinced to rename it docker-stop. :-)


[haxe] Function body without braces breaks completion

In Haxe, braces around function bodies are optional in case the body is a single expression.
E.g. the following is valid code
    static function formatEvenness(i:Int):String
    	return i % 2 == 0
            ? "even"
            : "odd";

However it seems support for this style was never added to FD.
E.g. trying to write code like this (note that _ represents the caret, not the _ character):
package;

class Main {
	var str:String;

	function foo()
		st_
}

Press Ctrl-Space.
Expected: str offered as completion.
Actual: static offered as completion and other keywords suitable for class members, line is unindented one level. It's clear that FD thinks we're still in the class context, not inside the body of function foo as should be the case.
This is quite serious limitation when working with code written in this avoid-unnecessary-braces style.

#1907


[BUG] Website is Not Responsive

Hi @akshitagupta15june . I would like to make the webpage responsive, so that user can access the website seamlessly on all devices.
Please assign me this issue under GSSOC'23.

Hi @akshitagupta15june . I would like to make the webpage responsive, so that user can access the website seamlessly on all devices. Please assign me this issue under GSSOC'23.

Including Navigation Bar alignment and Mobile-friendly UI.

some are already working on this


Unable to match command output after in v.1.12.0

Hello 👋 . I'm a maintainer for the Homebrew project. While packaging v1.12.0 of oauth2c, we are encountering a test failure matching the "Authorization completed" output. It appears this was changed in https://github.com/cloudentity/oauth2c/pull/77. Our test is not just receiving the access token response instead of the full output. Is there any way to resolve this? Thanks!
Relates to https://github.com/Homebrew/homebrew-core/pull/147883

Hi @p-linnane
Could you change the assertion to look for access_token instead of Authorization completed in line 28?
In #77 I moved all the diagnostic output to the stderr so it is possible to use it in scripts as requested in #76.
That's why the testing is failing now, as it expects the Authorization completed in stdout, not stderr.

Thank you. I've made that change and the test is passing now.


[nodejs] trim "-pre" suffix when getting nodejs library version

Motivation
We use prerelease versions in our master branch like 6.0.0-pre. Those prerelease versions cannot be compared to the semver version definitions in the manifest, and thus put all tests as xpass instead of pass.
Changes
Trim that "-pre" suffit, it's not important really.
Workflow

⚠ Create your PR as draft ⚠
Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
Mark it as ready for review

Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
Framework is modified, or non obvious usage of it -> get a review from R&P team

:rocket: Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist

[ ] Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
[ ] If PR title starts with [<language>], double-check that only <language> is impacted by the change
[ ] No system-tests internal is modified. Otherwise, I have the approval from R&P team
[ ] CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
[ ] A docker base image is modified?

[ ] the relevant build-XXX-image label is present

[ ] A scenario is added (or removed)?

[ ] Get a review from R&P team

@robertomonteromiguel on master we always have a major above what we release, so for example latest is 5.x.x but on master we have 6.0.0-pre

Those prerelease versions cannot be compared to the semver version definitions in the manifest

If I'm not wrong, in semver, 6.0.0-pre will be after any 5.x.x version, which is what we want, no ? Or do I miss something ?

@cbeauchesne

6.0.0-pre will be after any 5.x.x version

From what I can tell the spec is not super clear on it, but npm and the python library used in the system-tests do not agree with you, this is what i'm trying to solve. Basically without this fix, all the test from dev are xpass because 6.0.0-pre is considered not satisfying the >=5 filter
See:

I'm trying to fix it for node for now, we'll see if it impacts other libs when they start using it

I think the reason why they differ is because the NpmSpec is mimic'ing the npm semver module. Here is a quote from its docs:

So a prerelease version will only match if compared to another prerelase version.
@cbeauchesne The problem with the SimpleSpec, is that it's actually too simple. It doesn't look like it supports OR clauses like the npmspec do, and that's like the whole reason why we're using it in the first place.

indeed.
let's go with a custom one !

LGTM thank you so much, way better solution, and i confirmed it works great locally :+1:


Temporary fix for statspusher logging - log the error at the top

Description:
Quick fix for statspusher error logging. Log the error at the top. Will need to revisit eventually to make sure it's not double logging and that everything is eventually getting logged.
Issues affected:
#232

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


swift 3.0 branch Can not be used in Xcode 8 beta6, there are a lot of error

I downloaded the latest 3.0 branch, but can no longer use under Xcode 8 beta6

Have you tried it with the Xcode 8 GM? I haven't encountered any errors with the swift3 branch and the GM.
If you continue getting errors with the GM, could you list some of them here?

Xcode 8 GM is OK, thinks! @nmccann


Editor.json : Add functionality to read data into the form from datasource configuration or datasource structure

Is this a duplicate? https://github.com/appsmithorg/appsmith/issues/2504

@somangshu : No. #2504 is a feature request for generation of queries. This is simply an enhancement of editor.json which is used to display the query pane. As part of this change, we should be able to provide dynamic data to the generated fields via editor.json for better usability of query pane. One use case is that when creating a query for mongo, you should be able to select the collection name from a dropdown instead of writing the name as raw text. This would reduce the developer user errors in writing the collection name

@trishaanand is this the same as dynamic triggers?

@trishaanand is this the same as dynamic triggers?

Yes it is. We can close this once trigger functionality is in release.

@ayushpahwa Please attach the dynamic trigger PR to this issue.


Emulator freezes after moving mouse

Strangely, this issue does NOT occur on copy.sh/v86, only on my own copy of v86 with a custom theme (Source code here). Whenever I try to load a disk image, it will work perfectly fine as long as I keep my mouse cursor away from the screen. However, as soon as I move my mouse into the screen canvas area, the VM will completely freeze after a few seconds. The disk image I've been testing with is here, but I also tried a Windows XP disk image that previously worked fine and experienced the exact same issue.
Is this an issue with my configuration? Something to do with the structure of my index.html? I tried updating the network adapter and screen in the config to their new object versions (screen and net_device instead of screen_container and network_relay_url), but it didn't fix anything, so I reverted those changes since they seemed to have no impact on the bug. The version of libv86.js and v86.wasm I'm using is the latest as of 12/31/2024.
I created a new copy of the emulator with libv86-debug.js and the associated wasm file and tested it there, but no error appeared in the console. After moving my mouse, the VM simply froze and the console stopped updating.
No idea why this is happening. This doesn't happen on the official site.
Edit: I should probably specify that this issue did not ever occur before I updated to the latest libv86.js and v86.wasm today. The version I was using prior to updating was from July(?) 2024.

For me, Windows 3.1 works properly, but RetrOS-32 is stuck on the login screen.
Can you try to build v86 or use this artefact from commit https://github.com/copy/v86/commit/298da237c2e8ae3b605ab60a5f873884a96ed054 and test it?

This doesn't happen on the official site.

copy.sh/v86 uses an older version than on GitHub

For me, Windows 3.1 works properly, but RetrOS-32 is stuck on the login screen. Can you try to build v86 or use this artefact from commit 298da23 and test it?

This doesn't happen on the official site.

copy.sh/v86 uses an older version than on GitHub

That artifact works like a charm! I've replaced the version in my repository with it, but in case it's necessary for testing, I made a branch that has the latest (broken) version.

After my small research, I can assume that PIC changes in commit https://github.com/copy/v86/commit/9beaccc8baa96a4271e6d091930ee77691c134d1 may cause this bug on some OSes.
If you are using Linux and Windows XP as a guest OS, can you try enabling acpi in your V86 constructor?


Does not work in  Headless JS

Good afternoon!   In the simple mode of the application, everything works well.
Permissions have already been requested and received.
Now I want the Headless (https://reactnative.dev/docs/headless-js-android)  script to work with coordinates, but I always get null
Here are excerpts from the code:
index.js
...
import { BackgroundTask } from './src/utils/BackgroundHeadlessJSTask';

AppRegistry.registerHeadlessTask('Sync', () => BackgroundTask);
AppRegistry.registerComponent(appName, () => App);

BackgroundHeadlessJSTask.js
export const BackgroundTask = () => {
	Geolocation.setRNConfiguration({
		skipPermissionRequests: true,
		locationProvider: 'playServices',
	});

	Geolocation.getCurrentPosition(
		(position) => {
			console.log('position', position);
		},
		(error) => {
			// mReactContext.getCurrentActivity() returned null but should be non-null in getCurrentLocationData
			console.log(error);
		},
		{
			timeout: (1000 * timeout),
			maximumAge: (1000 * 60 * 2),
			enableHighAccuracy: true,
		}
	);
};

After analyzing the situation, I began to receive an error:
mReactContext.getCurrentActivity() returned null but should be non-null in getCurrentLocationData
Error in file:
<EMAIL_ADDRESS>
I do not know what to do...

any ideas how to fix the problem?

I edited the file you suggested to change in your PR #254 but it still doesn't work when the app is not focused (Location request timed out).
I don't directly use headless-js-android but I use react-native-background-actions which relies on it.
With all the permissions checked I launch a background task that chronically check for geolocalisation, but as soon as I leave my app in background I can't collect it.
I use this option set: enableHighAccuracy: true,             timeout: 20000,             maximumAge: 10000,
Do you have any clue on that problem ?

Everything worked for me.  To do this, I made my own fork  https://github.com/valery-lavrik/react-native-geolocation
But, in order for everything to work properly, I had to:

enable autorun of the application in the android settings (my application should start itself after reboot)
for my application, in the android settings you need to specify "allow access to geolocation in any mode" (I have Redme 10C)

It is this switch from point 2 that prevents the application from using GPS when the application is not running

and more.   So that the timeout does not fall (sometimes this happens) I made a wrapper with my artificial timeout

My bad, I did forgot to ask for background geolocation permission. You're correction is working great once this one is collected 😅
But thank you for your response and time (it still might help someone else 😃)

Shipped in version 3.1.0


Add diff to mocha warning

For mocha diff to work correctly, the diff library is required. It isn't installed by default so added to the warning message when it fails to detect the library.

Well, actually the diff module is a dependency of the mocha module. So i left it out since you need mocha anyway to use the diff output.
See https://github.com/mochajs/mocha/blob/master/package.json#L279

The problem is the require('diff') is looking for a node_modules package, but it doesn't exist.
It would exist in npm3, but in npm2 it's within the sub directory of mocha. Do you have npm3 installed locally?

Good catch. I have npm@3 installed. I did not take npm@2 in account.

Good stuff - And thanks a lot for your great library :+1:

My pleasure. New version will be released to npm tomorrow.

Released as v1.2.2


feat(server): set ratelimit middlewares for each route

Description
We reorganized the ratelimiter and made some changes to the ratelimits.
with @lareii

Checklist

[x] A description of the changes in this PR is mentioned above.
[x] All the new and existing tests pass.
[x] The code follows the code style and conventions of the project.
[x] No plagiarized, duplicated, or repetitive code that has been directly copied from another source.
[x] I have read the whole Contributing Guidelines of the project and its resources/related pages.

Screenshots (if any)

Note to reviewers

Thanks for your collaboration!


Prevent arbitrary file writes with malicious resource names.

 Will revisit after some learning/research

I still think that we can stick to extracting to the same path inside of the apk/zip itself. Basically unzipping but decoding some types on-the-fly.

The challenge I suffer with here is that Path/File want to detect the path separator from the host OS. I want to specify one because as you mentioned these are paths correlating to Zip/Apk and then transitioned to host system. So for now - a basic check for traversal, which should suffice.

Looks nice. Great effort!

@iBotPeaches Can you cut a new release for apktool with this patch? I see that there is 2.10.0 scoped for April. Since this is a security fix, can we get a fixed version in the interim?

@iBotPeaches Can you cut a new release for apktool with this patch? I see that there is 2.10.0 scoped for April. Since this is a security fix, can we get a fixed version in the interim?

I was planning a patch release this weekend.

@iBotPeaches Can you cut a new release for apktool with this patch? I see that there is 2.10.0 scoped for April. Since this is a security fix, can we get a fixed version in the interim?

Now its out - v2.9.2 - https://apktool.org/blog/apktool-2.9.2


Set host before attempting request

Fixes local spec failure for MarkdownApi by setting the host env var before attempting request.

i believe this error was fixed by the changes in #239

Looks like it should be, but I can't build master and run the specs without first doing a bundle install from a bash prompt in the container from the master branch right now. This PR is superseded by that one, though, so closing this.

Looks like it should be, but I can't build master and run the specs without first doing a bundle install from a bash prompt in the container from the master branch right now. Specs all pass locally though so this PR is superseded by that one and I'll close this.

I've added instructions to the readme in https://github.com/zooniverse/talk-api/pull/241. the bundle install is required as we now cache the gems in a volume via https://github.com/zooniverse/talk-api/blob/f44b6a665cc98eb7c29e4e3211bf2933100c8b67/docker-compose.yml#L26
this won't auto update even with new docker image builds (unless you recreate the volume) but will save install times when doing dev work and the bundle changes.


Allow multi-index column names for inferring return type schema with names.

Allow multi-index column names for inferring return type schema with names.

Before

>>> pdf = pd.DataFrame({("x", "a"): [1, 2, 3], ("y", "b"): [3, 4, 5]})
>>> def func() -> ks.DataFrame[zip(pdf.columns, pdf.dtypes)]:
...     pass
>>> infer_return_type(func).tpe
Traceback (most recent call last):
...
TypeError: not all arguments converted during string formatting

After

>>> pdf = pd.DataFrame({("x", "a"): [1, 2, 3], ("y", "b"): [3, 4, 5]})
>>> def func() -> ks.DataFrame[zip(pdf.columns, pdf.dtypes)]:
...     pass
>>> infer_return_type(func).tpe
StructType(List(StructField((x, a),LongType,true),StructField((y, b),LongType,true)))

Codecov Report

Merging #2117 (db4c122) into master (deccf33) will decrease coverage by 2.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2117      +/-   ##
==========================================
- Coverage   95.36%   93.17%   -2.19%
==========================================
  Files          60       60
  Lines       13544    13545       +1
==========================================
- Hits        12916    12621     -295
- Misses        628      924     +296

Impacted Files
Coverage Δ

databricks/koalas/typedef/typehints.py
84.78% <100.00%> (-9.76%)
:arrow_down:

databricks/koalas/usage_logging/__init__.py
27.27% <0.00%> (-65.29%)
:arrow_down:

databricks/koalas/usage_logging/usage_logger.py
47.82% <0.00%> (-52.18%)
:arrow_down:

databricks/koalas/missing/series.py
62.66% <0.00%> (-37.34%)
:arrow_down:

databricks/koalas/missing/frame.py
76.19% <0.00%> (-23.81%)
:arrow_down:

databricks/koalas/__init__.py
80.26% <0.00%> (-11.85%)
:arrow_down:

databricks/koalas/missing/indexes.py
88.63% <0.00%> (-11.37%)
:arrow_down:

databricks/conftest.py
89.06% <0.00%> (-10.94%)
:arrow_down:

databricks/koalas/accessors.py
86.43% <0.00%> (-7.04%)
:arrow_down:

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deccf33...db4c122. Read the comment docs.

Thanks! merging.


Die gracefully on legacy compiler errors (fixes #166)

\сс @AlexanderMoskovkin @helen-dikareva

FPR

I don't really like that path for compiler is 'src/compiler/index.js' by default LegacyCompilerAdapter class (not Compiler) is exported.

@helen-dikareva It's temporary solution, Later it will be moved to the separate package in context of #167

FPR

lgtm

lgtm

@inikulin Should a technical writer check the strings or we can merge the pr?

@AlexanderMoskovkin yes, thank you for the reminder \cc @MargaritaLoseva @VasilyStrelyaev

\r-

FPR

lgtm

ping @churkin

ping @VasilyStrelyaev @helen-dikareva

lgtm

lgtm


Cocoapods is still delivering v1.1.2

Cocoapods is still dispensing v 1.1.2 of the repository instead of 1.4.0. My workaround is to use the direct link for now:
pod 'ZoomTransitioning', :git => 'https://github.com/WorldDownTown/ZoomTransitioning.git'

@gravicle Hi, thank you for opening issue. Sorry, I had a mistake. I had updated ZoomTransitioning for CocoaPods. Please check it out.
https://cocoapods.org/pods/ZoomTransitioning

Thank you for the quick fix and for the pod 🙌🏼


[Feature request] Eager load relationships

Hi,
I've read the entire docs but found no mention on how to eager-load relationships.
I've tried to use ::with or ->with with no success.
I think that's an important feature, if you aprove, I can implement and do a PR.

Hi @iget-esoares,
I added the feature you have requested, now you can use it like this:
App\MyModel::search('phone')
    ->with('makers')
    ->get();

Thank you! :-)

I confirm that it's impossible to eagerload when paginating :-(

@iget-esoares hey, for some reason this issue slipped from my attention. Now it's fixed in v3.2.1.

@babenkoivan Love you man! :+1: Thanks


New API

Coverage increased (+0.06%) to 98.305% when pulling 60f5ff0ec8efa02233e41772d6942077424d7ac7 on rbino:new-api into 67690c510133de7648562fe83c4b417982e851f3 on ispirata:master.


[Docbug][Webhooks and connectors]

Minor edit

Docs Build status updates of commit d03ff18:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/webhooks-and-connectors/how-to/connectors-using.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


HEADER attribute

all endpoints that make use of a requestbody now have the HEADERS attribute
which is used by the client to automatically set the required headers
for the request.

Coverage remained the same at 100.0% when pulling 1b086ce8bb778ddf9f56bed6a1a9543062214bcd on headers into 10a2a15c51004121162fa193869c3f71d3e45c3f on development.

Coverage remained the same at 100.0% when pulling 1b086ce8bb778ddf9f56bed6a1a9543062214bcd on headers into 10a2a15c51004121162fa193869c3f71d3e45c3f on development.


Fix for MOBILE screen

WebMasterLog Repository (Proposing new issue)
:red_circle: Project Title :WebMastarLog
:red_circle: Enhancement Aim : Make responsive for mobile screen
:red_circle: Category :  CSS
:red_circle: Changes : Fix card to be fit for mobile screen, fix padding and margin according to mobile screen.
It should be fixed to improve the user experience on all devices.

i would love to contribute to this

:white_check_mark: To be Mentioned while taking the issue :

Full name :  Utsav Ladia
GitHub Profile Link : https://github.com/utsavladia
What is your participant role? GSSOC

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

@Utsavladia fill the issue template. It is mandatory and join the project discord server.

@Avdhesh-Varshney  sure, I have filled the issue template.

@Utsavladia go ahead.


Enhancement | Design/Architectural Improvements

Describe the Feature
We should take this notes in consideration to reduce the complexity and readability of the source code in general, which should bring the benefit of optimizing the times and costs involved on new developments.
Describe Ideal Solution
1. Extract all the docker/container logic related from LeverageContainer into its own class.
That would mean, move the methods:

start
exec
run
create_container
docker_logs
etc..
into the new class. More or less, it would be an interface to the docker library we use.
Unit tests would become way easier to write because the interface should be totally mockable.
LeverageContainer would still be in charge of loading the correct en vars, region, config files and the base logic of the CLI.

2. Don't force an entrypoint
Leave it empty and use it only on the required scenarios.
That would simplify a lot the code base, by avoiding the use and abuse of the context managers to switch it.
3. Container.py should be split in N files
Inside leverage/containers/. One file per binary/container representation. That should improve readability.
4. Create a mixin with all the AWS credentials logic
It would be used by the AWS, Terraform and Kubectl containers, and any new command in the future.
Logic shouldn't be repeated. It would be as simple as inheriting the mixin, so your env vars and methods to authenticate
against AWS would be guaranteed.
Adding value
Potential complexity analyzer we could use to measure the code improvements: https://pypi.org/project/wily/

Another potencial enahncement:

https://github.com/binbashar/leverage/issues/210


New coverage

Codecov Report

Merging #194 into master will decrease coverage by 0.57%.
The diff coverage is 93.61%.

@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
- Coverage   98.42%   97.84%   -0.58%
==========================================
  Files          62       63       +1
  Lines        2349     2465     +116
==========================================
+ Hits         2312     2412     +100
- Misses         37       53      +16

Impacted Files
Coverage Δ

...ime-ganache-deployer/etherlime-ganache-deployer.js
100% <ø> (ø)
:arrow_up:

cli-commands/commands.js
89.16% <0%> (-10.84%)
:arrow_down:

cli-commands/etherlime-test/etherlime-coverage.js
100% <100%> (ø)

...r/jsonrpc-deployer/jsonrpc-private-key-deployer.js
100% <100%> (ø)
:arrow_up:

cli-commands/etherlime-test/test.js
100% <100%> (ø)
:arrow_up:

cli.js
64.28% <0%> (-7.15%)
:arrow_down:

...nds/compiler/etherlime-compile/compilerSupplier.js
77.77% <0%> (-0.8%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b5f67e...b21a741. Read the comment docs.


🐛 pkg/reconciler/apis/apibinding: return error in case of conflicts

Summary
This fixes failed local sharded startup failures. The observed symptom was:
- apiVersion: apis.kcp.io/v1alpha1
  kind: APIBinding
  metadata:
    annotations:
      kcp.io/cluster: system:shard
    creationTimestamp: "2023-01-18T14:29:39Z"
    finalizers:
    - apis.kcp.io/apibinding-finalizer
    generation: 1
    labels:
      internal.apis.kcp.io/export: bmCdly9xXiUpEHe3ypvDwvXMTfoVZUE92mqAQf
    name: tenancy.kcp.io
    resourceVersion: "195"
    uid: 9cf38f12-663c-4673-84be-b5aae0cb4bdc
  spec:
    reference:
      export:
        name: tenancy.kcp.io
        path: root
  status:
    conditions:
    - lastTransitionTime: "2023-01-18T14:29:42Z"
      message: 'Unable to bind APIs: error checking for naming conflicts for APIBinding
        system:shard|tenancy.kcp.io: error getting CRDs: APIResourceSchema.apis.kcp.io
        "v220628-546034da.negotiatedapiresources.apiresource.kcp.io" not found'
      reason: NamingConflicts
      severity: Error
      status: "False"
      type: Ready
    - lastTransitionTime: "2023-01-18T14:29:41Z"
      message: Invalid APIExport. Please contact the APIExport owner to resolve
      reason: InternalError
      severity: Error
      status: "False"
      type: APIExportValid
    - lastTransitionTime: "2023-01-18T14:29:42Z"
      message: 'Unable to bind APIs: error checking for naming conflicts for APIBinding
        system:shard|tenancy.kcp.io: error getting CRDs: APIResourceSchema.apis.kcp.io
        "v220628-546034da.negotiatedapiresources.apiresource.kcp.io" not found'
      reason: NamingConflicts
      severity: Error
      status: "False"
      type: BindingUpToDate
    - lastTransitionTime: "2023-01-18T14:29:42Z"
      message: 'Unable to bind APIs: error checking for naming conflicts for APIBinding
        system:shard|tenancy.kcp.io: error getting CRDs: APIResourceSchema.apis.kcp.io
        "v220628-546034da.negotiatedapiresources.apiresource.kcp.io" not found'
      reason: NamingConflicts
      severity: Error
      status: "False"
      type: InitialBindingCompleted
    phase: Binding

In case of temporary failures the api binding controller didn't retry.
This fixes it.
Related issue(s)
N/A

@s-urbaniak some unit tests are failing :( (https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/kcp-dev_kcp/2645/pull-ci-kcp-dev-kcp-main-test/1615726119036653568)

/lgtm


Fix padding and hover/focus styling on password input

What
Fix two things:

Long values in the password input (or with a small screen) the show/hide button no longer covers over the input text.
Remove the focus outline (we already apply an underline on focus) on the show/hide button.
Add cursor pointer on hover of the show/hide button.

How to review
Going to the login screen and check that the styling bugs above are fixed.
Who can review
Anyone but me.

Still getting the issue where the show/hide covers the text. Haven't run Florence in a while but did a pull and checked out this branch, still see it. Is there anything else I should have done?


Maintain the span from HTTP calls using feign clients with micrometer

Hi,
I am using spring boot 3.1.5.  I migrated my code from sleuth to micrometer for tracing. I have it working logging traceId and spanId. But as somebody already asked here https://stackoverflow.com/questions/77044612/should-micrometer-generate-a-new-span-each-time-a-spring-boot-server-receives-a , I am trying to maintain the spanId when I call to other microservices through http  using spring cloud open feign but it maintains only the traceId. I specify below the feign configuration I have:
@Configuration
public class FeignConfiguration {

    @Bean
    public Capability capability(final MeterRegistry registry) {
      return new MicrometerCapability(registry);
    }

    @Bean
    public Logger.Level loggerLevel() {
        return Logger.Level.FULL;

    }
}

The logs enabled with loggerLevel method for feign clients are already logging with same traceId but different spanId. And of course when you call to other microservice, the spanId is different too. How to maintain the spanId in the feignClient and propagate it to other microservices as it worked with the old spring sleuth?.  Thanks!!

@jonatan-ivanov, could you take a look at this issue?

This issue somewhat seems like a duplicate of https://github.com/spring-cloud/spring-cloud-openfeign/issues/1014.
Creating a new span for every single http request is the normal/default behavior since processing an http request is a separate operation that you usually want to observe. PLease check Brave's joint spans feature and enable it like you did it in https://github.com/spring-cloud/spring-cloud-openfeign/issues/1014.

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


Arguments with Double Dashes (--) not parsed correctly on at least 1 data import tool

Hi and thanks for this tool!
I'm having trouble using arguments with double dashes on the SharpHound data import.
Example of sharphound working as expected with single dash argument -c:

Attempting execute the same command with a double dash argument --CollectionMethod:

This is preventing me from using arguments that don't have single dashes associated with them, like --LdapUsername or --LdapPassword and therefore i'm not able to use the tool currently

Could you try splitting to different arguments? For example:


Cannot import module "daprclient" in daprclient_pb2_grpc.py

When trying to import daprclient_pb2_grpc.py to access the OnInvoke method, an error is thrown. Without this, a correct example utilizing the OnInvoke method can not be created, disallowing the E2E communication of 2 RPC microservices (client and server).
It seems that on the source repo the following proto files are found:

https://github.com/dapr/dapr/blob/master/pkg/proto/daprclient/daprclient.proto
https://github.com/dapr/dapr/blob/master/pkg/proto/dapr/dapr.proto

It might be that there is some wrong packaging behavior happening?
Expected Behavior
This should work to allow the creation of the OnInvoke method.
Actual Behavior
== APP == Traceback (most recent call last):
== APP ==   File "server.py", line 7, in <module>
== APP ==     from dapr import daprclient_pb2_grpc as servicesClient
== APP ==   File "C:\Python37\lib\site-packages\dapr\daprclient_pb2_grpc.py", line 4, in <module>
== APP ==     from daprclient import daprclient_pb2 as daprclient_dot_daprclient__pb2
== APP == ModuleNotFoundError: No module named 'daprclient'

Steps to Reproduce the Problem

Create a new Python file (e.g. server.py)
Add line from dapr import daprclient_pb2_grpc as services
Run the application (e.g. dapr run --app-id python-grpc --port 3500 --protocol grpc --grpc-port 50001 python server.py)

This can be fixed by changing daprclient to dapr but these files are generated upstream so the issue may be the protoc command used to generate them?

Agreed, would love a fix upstream with a pip repo update to be able to access the daprclient. Adding @youngbupark

Agreed, would love a fix upstream with a pip repo update to be able to access the daprclient. Adding @youngbupark

In this milestone, we've refactored proto files. We will try to fix it in upstream repo.
cc/ @amanbha @yaron2


new package: iproute2 5.5.0

Description of package
Checklist

[ ] Latest upstream version.
[ ] I agree to maintain this package (required).
[ ] I agree to notify KISS if I can no longer maintain this package (required).

SBINDIR is needed for second make. --sbindir=/usr/bin does nothing on configure, and I am unsure if --prefix=/usr does anything useful or not, however I have added it per your last comment, just incase.

Ok got it

As I said above, they don't do anything ;)

merge me baby


Health async interfaces

Draft for adding a new IAsyncHealthContributor with CheckHealthAsync() method. Steeltoe already supports adding IHealthContributor implementations in addition to Microsoft HealthCheckRegistrations. In order to be flexible to Steeltoe consumers, who want to continue using IHealthContributor, we want to support IAsyncHealthContributor in addition to the other options.

I will recreate this by cherry-picking the last commit.


[Bug] Won't start, directory not found?

Logs:
angel@linux-B550:~$ git clone https://github.com/androidWG/Discord.fm
cd Discord.fm
python setup.py setup
Cloning into 'Discord.fm'...
remote: Enumerating objects: 3546, done.
remote: Counting objects: 100% (1072/1072), done.
remote: Compressing objects: 100% (387/387), done.
remote: Total 3546 (delta 680), reused 990 (delta 650), pack-reused 2474
Receiving objects: 100% (3546/3546), 21.55 MiB | 24.85 MiB/s, done.
Resolving deltas: 100% (2231/2231), done.
Getting venv...
Running simple command "pipenv --venv"...
Traceback (most recent call last):
File "/home/angel/Discord.fm/setup.py", line 202, in
check_venv(args.force, args.no_venv)
File "/home/angel/Discord.fm/setup.py", line 73, in check_venv
env_name = _run_simple("pipenv --venv")
File "/home/angel/Discord.fm/setup.py", line 50, in _run_simple
process = subprocess.Popen(
File "/usr/lib/python3.10/subprocess.py", line 971, in init
self._execute_child(args, executable, preexec_fn, close_fds,
File "/usr/lib/python3.10/subprocess.py", line 1863, in _execute_child
raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'pipenv'
OS Info:
OS: Linux Mint 21.3 x86_64
Host: B550
Kernel: 6.5.0-1027-oem
Uptime: 2 hours, 7 mins
Packages: 3042 (dpkg), 13 (flatpak)
Shell: bash 5.1.16
Resolution: 3840x2160
DE: Xfce 4.18
WM: Xfwm4
WM Theme: Mint-Y-Aqua
Theme: Adwaita-dark [GTK2/3]
Icons: Mint-Y-Sand [GTK2/3]
erminal: xfce4-terminal
Terminal Font: Monospace 12
CPU: AMD Ryzen 7 5700G with Radeon G
GPU: AMD ATI 08:00.0 Cezanne
GPU: NVIDIA GeForce RTX 3060 Lite Ha
Memory: 4388MiB / 63674MiB

Update:
angel@linux-B550:~/Discord.fm$ python setup.py setup
Getting venv...
Running simple command "pipenv --venv"...
No virtualenv has been created for this project/home/angel/Discord.fm yet!
Aborted!
Running pipenv...
Running simple command "pipenv --python=3.11 install --dev"...
Warning: Python 3.11 was not found on your system...
Neither 'pyenv' nor 'asdf' could be found to install Python.
You can specify specific versions of Python with:
$ pipenv --python path/to/python
Running simple command "pipenv --venv"...
No virtualenv has been created for this project/home/angel/Discord.fm yet!
Aborted!
Running simple command "pipenv --py"...
No virtualenv has been created for this project /home/angel/Discord.fm  yet!
Aborted!
Python path:
Env path:
Pip path: ['', '-m', 'pip', 'install']
Setup completed
angel@linux-B550:~/Discord.fm$

Another Update:
angel@linux-B550:~/Discord.fm$ python setup.py setup
Getting venv...
Running simple command "pipenv --venv"...
No virtualenv has been created for this project/home/angel/Discord.fm yet!
Aborted!
Running pipenv...
Running simple command "pipenv --python=3.11 install --dev"...
Creating a virtualenv for this project...
Pipfile: /home/angel/Discord.fm/Pipfile
Using /usr/bin/python3.11 (3.11.9) to create virtualenv...
created virtual environment CPython3.11.9.final.0-64 in 232ms
creator CPython3Posix(dest=/home/angel/.local/share/virtualenvs/Discord.fm-stLX6RFd, clear=False, no_vcs_ignore=False, global=False)
seeder FromAppData(download=False, pip=bundle, setuptools=bundle, wheel=bundle, via=copy, app_data_dir=/home/angel/.local/share/virtualenv)
added seed packages: pip==24.1, setuptools==70.1.0, wheel==0.43.0
activators BashActivator,CShellActivator,FishActivator,NushellActivator,PowerShellActivator,PythonActivator
✔ Successfully created virtual environment!
Virtualenv location: /home/angel/.local/share/virtualenvs/Discord.fm-stLX6RFd
Pipfile.lock not found, creating...
Locking [packages] dependencies...
Building requirements...
Resolving dependencies...
False
✘ Locking Failed!
Could not find a matching version of pywin32>=306; sys_platform == "windows" for your environment, its dependencies will be skipped.
Could not find a matching version of aquaui>=0.0.1.post2; sys_platform == "darwin" for your environment, its dependencies will be skipped.
Could not find a matching version of pyobjc>=10.0; sys_platform == "darwin" for your environment, its dependencies will be skipped.
ERROR:pip.subprocessor:pip subprocess to install build dependencies exited with 1
[ResolutionFailure]:   File "/home/angel/.local/lib/python3.10/site-packages/pipenv/resolver.py", line 645, in _main
[ResolutionFailure]:       resolve_packages(
[ResolutionFailure]:   File "/home/angel/.local/lib/python3.10/site-packages/pipenv/resolver.py", line 612, in resolve_packages
[ResolutionFailure]:       results, resolver = resolve(
[ResolutionFailure]:       ^^^^^^^^
[ResolutionFailure]:   File "/home/angel/.local/lib/python3.10/site-packages/pipenv/resolver.py", line 592, in resolve
[ResolutionFailure]:       return resolve_deps(
[ResolutionFailure]:       ^^^^^^^^^^^^^
[ResolutionFailure]:   File "/home/angel/.local/lib/python3.10/site-packages/pipenv/utils/resolver.py", line 932, in resolve_deps
[ResolutionFailure]:       results, hashes, internal_resolver = actually_resolve_deps(
[ResolutionFailure]:       ^^^^^^^^^^^^^^^^^^^^^^
[ResolutionFailure]:   File "/home/angel/.local/lib/python3.10/site-packages/pipenv/utils/resolver.py", line 700, in actually_resolve_deps
[ResolutionFailure]:       resolver.resolve()
[ResolutionFailure]:   File "/home/angel/.local/lib/python3.10/site-packages/pipenv/utils/resolver.py", line 457, in resolve
[ResolutionFailure]:       raise ResolutionFailure(message=str(e))
[pipenv.exceptions.ResolutionFailure]: Warning: Your dependencies could not be resolved. You likely have a mismatch in your sub-dependencies.
You can use $ pipenv run pip install <requirement_name> to bypass this mechanism, then run $ pipenv graph to inspect the versions actually installed in the virtualenv.
Hint: try $ pipenv lock --pre if it is a pre-release dependency.
ERROR: pip subprocess to install build dependencies exited with 1
Traceback (most recent call last):
File "/usr/bin/pipenv", line 33, in
sys.exit(load_entry_point('pipenv==11.9.0', 'console_scripts', 'pipenv')())
File "/home/angel/.local/lib/python3.10/site-packages/pipenv/vendor/click/core.py", line 1157, in call
return self.main(*args, **kwargs)
File "/home/angel/.local/lib/python3.10/site-packages/pipenv/cli/options.py", line 58, in main
return super().main(*args, **kwargs, windows_expand_args=False)
File "/home/angel/.local/lib/python3.10/site-packages/pipenv/vendor/click/core.py", line 1078, in main
rv = self.invoke(ctx)
File "/home/angel/.local/lib/python3.10/site-packages/pipenv/vendor/click/core.py", line 1688, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/home/angel/.local/lib/python3.10/site-packages/pipenv/vendor/click/core.py", line 1434, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/home/angel/.local/lib/python3.10/site-packages/pipenv/vendor/click/core.py", line 783, in invoke
return __callback(*args, **kwargs)
File "/home/angel/.local/lib/python3.10/site-packages/pipenv/vendor/click/decorators.py", line 92, in new_func
return ctx.invoke(f, obj, *args, **kwargs)
File "/home/angel/.local/lib/python3.10/site-packages/pipenv/vendor/click/core.py", line 783, in invoke
return __callback(*args, **kwargs)
File "/home/angel/.local/lib/python3.10/site-packages/pipenv/cli/command.py", line 209, in install
do_install(
File "/home/angel/.local/lib/python3.10/site-packages/pipenv/routines/install.py", line 93, in do_install
do_init(
File "/home/angel/.local/lib/python3.10/site-packages/pipenv/routines/install.py", line 653, in do_init
do_lock(
File "/home/angel/.local/lib/python3.10/site-packages/pipenv/routines/lock.py", line 66, in do_lock
venv_resolve_deps(
File "/home/angel/.local/lib/python3.10/site-packages/pipenv/utils/resolver.py", line 873, in venv_resolve_deps
c = resolve(cmd, st, project=project)
File "/home/angel/.local/lib/python3.10/site-packages/pipenv/utils/resolver.py", line 737, in resolve
raise RuntimeError("Failed to lock Pipfile.lock!")
RuntimeError: Failed to lock Pipfile.lock!
Running simple command "pipenv --venv"...
/home/angel/.local/share/virtualenvs/Discord.fm-stLX6RFd
Running simple command "pipenv --py"...
/home/angel/.local/share/virtualenvs/Discord.fm-stLX6RFd/bin/python
Python path: /home/angel/.local/share/virtualenvs/Discord.fm-stLX6RFd/bin/python
Env path: /home/angel/.local/share/virtualenvs/Discord.fm-stLX6RFd
Pip path: ['/home/angel/.local/share/virtualenvs/Discord.fm-stLX6RFd/bin/python', '-m', 'pip', 'install']
Setup completed
angel@linux-B550:~/Discord.fm$


samples: add sample code to query regional Dialogflow CX agent

Add logic to query regional Dialogflow CX endpoint for the following methods:

CreateFlow
CreateIntent
CreatePage
DetectIntent
DetectIntentStream

Overall, do we want to have separate samples for regional endpoints versus the global (or default) endpoint?
Is the documentation where these are referenced ok with a sample with the conditional logic versus suggesting separate snippets for using regional endpoints?

I think for CX it's better to have samples in one place with the condition, because, different from DF v2, location ID must always be present in the resource names, so the only difference is setting different endpoints based on location ID, which may be better to put in one sample.
The documentation should be ok to reference the current snippet.


Can't generate report for my project written in Go (with glide)

I was trying to run this command "license_finder  report --recursive=RECURSIVE  --format=csv --save=my_report.csv" in my github project repo.  And I got the following output from the shell:
warning: "./..." matched no packages
warning: "./..." matched no packages
warning: "./..." matched no packages
warning: "./..." matched no packages
warning: "./..." matched no packages
warning: "./..." matched no packages
warning: "./..." matched no packages
I am expecting to receive my report in csv to show all the OSS projects and dependencies.  However, the my_report.csv file has 0 bytes (empty file) in it.  My project source is written in Go and using Glide as package management.   Am I missing something here?

Unfortunately, LicenseFinder doesn't yet include support for Glide.
Issue #270 captures the request to add support for that package manager.


Anyone knows a way to obscure part of the tiles without using layers?

Description of Problem or Question
i was wondering if theres a way to obscure a tile or part of the tile to allow:
1- investigators entering removing the obscure tile with for example some kind of light?
2- Another example would be for the group investigating outside the mansion and upon entering remove the obscured part.
something like this?

Valkyrie Version
Attach Save, Quest or Scenario
Saves:
%appdata%/Valkyrie/MoM/Save
%appdata%/Valkyrie/D2E/Save
Quest:
%appdata%/Valkyrie/D2E/Editor
Scenario:
%appdata%/Valkyrie/MoM/Editor

Not that I know of natively.
It is possible to create your own tiles, but it's a very manual process.

Not that I know of natively.
It is possible to create your own tiles, but it's a very manual process.

hey thats a good idea!
i have no problem at all with manual process, i guess you mean:
a) manually  obscuring tiles and saving them.-
b) Saving/Locating them in the same reservoir where the rest of the tiles are located?
c) Then i can pick the obscured tile and with and entry event locate the normal tile?
Still i have no idea where to find or put my special tiles? Its on my reservoir or valkyre official reservoir??
thanks in advance!

What you are describing @newusergettingnuts would not work, tiles are embedded in the app, not in the scenario.
So your scenario would try to load not existing tiles for other players.
Scrubbless is referring to UI element I guess, or something else that I don't know of.

still i dont know if it shows this way just for me or for anybody that plays the scenario

Yes, only you would see the change.
Other would just see the normal tile

how about obscuring all existing tiles and having both versions (obscured and unobscured) within the app for a new Valk version??
you think it is possible? that way maybe within the index we can put another index as obscured tiles for people to pick??
I see great potential with something like that but maybe its just me and its a waste of time.

bahh nevermind...a thing like this will need also the physical tiles also obscured and that is impossible.
close

True !  :P
Closing


What should I do if I use Your Excellent Work in CPU mode?

Recently, I'm trying to use part of your excellent work in nodule dectection. Be more exact, I use the detection net of Deeplung to test on my CT data. But I need to transform the GPU mode into CPU, what should I modify in the test part of "main.py" in the "detector" folder?
I hope to receive your reply. Thanks.

You can take a look at how to use CPU in pytorch. We use pytorch for the implementation. Thank you very much for your interest!

Thanks a lot.


Conversion simply does not work

Hi, I installed foundryVTT yesterday, installed this addon too (tested it with v9 and v10 of foundryVTT) and when I try to batch-convert the compendiums it just throws the following error for every compendium and does nothing:

Okay, the conversion seemed to be done, but every compendium with "Metrified" attached to the name is empty. After looking in the console, the following error came up:
Compendium5eConverter.js:134 TypeError: relinkTypeMap[type] is not a function
at relinkTypeSelector (Compendium5eConverter.js:109)
at relinkCompendium (Compendium5eConverter.js:120)
at async relinkCompendiums (Compendium5eConverter.js:131)
at async Dnd5eConverterNew.js:134

Hi, i just released an update that makes this module functional for foundry 10. But this will most likely be the last update, i don't plan on supporting any of my foundry modules.
From what i have heard someone called Ethanks (on discord) is currently working on a replacement for this module, so in the future i suggest moving to that.


Cask request: pdf to keynote

Cask details
Name: pdf to keynote
Homepage: https://www.cs.hmc.edu/~oneill/freesoftware/pdftokeynote.html
Download URL: https://www.cs.hmc.edu/~oneill/freesoftware/PDFtoKeynote-v1.04a.dmg
Description:
PDF to Keynote converts PDF-based presentations (e.g., made using LaTeX with Prosper, Beamer or foiltex) into Apple's Keynote format.
Once translated into Keynote format, every page of your original PDF file becomes a PDF image, properly scaled and centered on its own slide.

Ping @vitorgalvao This only seems to export to Keynote 5 (iWork 09), hasn't been updated for several years.

Definitely too outdated and not popular enough to consider inclusion.


Fix #61

Coverage decreased (-0.4%) to 91.42% when pulling d530918cfd8c95bfbb41d3d1ede6880df6458ed4 on wd:master into e0a6862f3160c8afda41d8c592fa0bcd3cbed599 on chaseadamsio:master.

Coverage increased (+0.01%) to 91.84% when pulling 3a075d77357a7579dfdaa11303f5e7f2410d913e on wd:master into e0a6862f3160c8afda41d8c592fa0bcd3cbed599 on chaseadamsio:master.

thanks @wd.


Update request: clickhouse v<IP_ADDRESS> → v<IP_ADDRESS>-stable

Package name: clickhouse
Latest released version: v<IP_ADDRESS>-stable

Current version on the unstable channel: <IP_ADDRESS>
Current version on the stable/release channel: <IP_ADDRESS>

[X] Checked the nixpkgs pull requests

The clickhouse package currently in nixpkgs tracks an old LTS version.
This package needs to be updated to default install the latest stable version, as this is recommended by upstream: https://clickhouse.com/docs/en/faq/operations/production - we also then need to provide users with a clickhouse_lts package.
Notify maintainers
@mbalatsko @orivej

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

I've upgraded clickhouse to the latest LTS. I'm a little bit concerned about having stable version as clickhouse package, I'd suggest making it the other way around. clickhouse == lts, and clickhouse-stable == latest stable

Adding latest stable would require a lot more work, I'll try to find capacity on it, but no promises

24.8 is now the latest LTS

I have a work-in-progress branch now at: https://github.com/NixOS/nixpkgs/compare/master...jpds:nixpkgs:clickhouse-<IP_ADDRESS>-lts+<IP_ADDRESS>-stable
The Rust component currently fails with:
[5993/13663] cd /build/source/build/rust/workspace/prql && /nix/store/hx89vlv61l4vm0dvn0zww817nckzh7ls-cmake-3.29.6/bin/cmake -E env CARGO_TARGET_X86_64_UNKNOWN_LINUX_GNU_LINKER=/nix/store/ilqwhw4wa7xn7w3fiqmacvpxsac7zb3l-clang-wrapper-17.0.6/bin/clang CC_x86_64_unknown_linux_gnu=/nix/store/ilqwhw4wa7xn7w3fiqmacvpxsac7zb3l-clang-wrapper-17.0.6/bin/clang CXX_x86_64_unknown_linux_gnu=/nix/store/ilqwhw4wa7xn7w3fiqmacvpxsac7zb3l-clang-wrapper-17.0.6/bin/clang++ AR_x86_64_unknown_linux_gnu=/nix/store/ilqwhw4wa7xn7w3fiqmacvpxsac7zb3l-clang-wrapper-17.0.6/bin/ar CORROSION_BUILD_DIR=/build/source/build/rust/workspace CARGO_BUILD_RUSTC=/nix/store/g1rc6b7ab28h1sga2kvxfiwp6dqblgzg-rustc-wrapper-1.80.1/bin/rustc /nix/store/8k428qrvnnfg91v6qcvkjm5dpgrgig49-cargo-1.80.1/bin/cargo rustc --lib --target=x86_64-unknown-linux-gnu --package _ch_rust_prql --manifest-path /build/source/build/rust/workspace/prql/Cargo.toml --target-dir /build/source/build/./cargo/build --profile=release-thinlto --offline --locked -- -Cdefault-linker-libraries=no
warning: `/build/.cargo/config` is deprecated in favor of `config.toml`
note: if you need to support cargo 1.38 or earlier, you can symlink `config` to `config.toml`
error: source `https://github.com/azat-rust/tuikit.git?rev=e1994c0e03ff02c49cf1471f0cc3cbf185ce0104` defines source https://github.com/azat-rust/tuikit.git?rev=e1994c0e03ff02c49cf1471f0cc3cbf185ce0104, but that source is already defined by `git+https://github.com/azat-rust/tuikit.git?rev=e1994c0e03ff02c49cf1471f0cc3cbf185ce0104`
note: Sources are not allowed to be defined multiple times.
FAILED: rust/workspace/CMakeFiles/_cargo-build__ch_rust_prql /build/source/build/rust/workspace/CMakeFiles/_cargo-build__ch_rust_prql
cd /build/source/build/rust/workspace/prql && /nix/store/hx89vlv61l4vm0dvn0zww817nckzh7ls-cmake-3.29.6/bin/cmake -E env CARGO_TARGET_X86_64_UNKNOWN_LINUX_GNU_LINKER=/nix/store/ilqwhw4wa7xn7w3fiqmacvpxsac7zb3l-clang-wrapper-17.0.6/bin/clang CC_x86_64_unknown_linux_gnu=/nix/store/ilqwhw4wa7xn7w3fiqmacvpxsac7zb3l-clang-wrapper-17.0.6/bin/clang CXX_x86_64_unknown_linux_gnu=/nix/store/ilqwhw4wa7xn7w3fiqmacvpxsac7zb3l-clang-wrapper-17.0.6/bin/clang++ AR_x86_64_unknown_linux_gnu=/nix/store/ilqwhw4wa7xn7w3fiqmacvpxsac7zb3l-clang-wrapper-17.0.6/bin/ar CORROSION_BUILD_DIR=/build/source/build/rust/workspace CARGO_BUILD_RUSTC=/nix/store/g1rc6b7ab28h1sga2kvxfiwp6dqblgzg-rustc-wrapper-1.80.1/bin/rustc /nix/store/8k428qrvnnfg91v6qcvkjm5dpgrgig49-cargo-1.80.1/bin/cargo rustc --lib --target=x86_64-unknown-linux-gnu --package _ch_rust_prql --manifest-path /build/source/build/rust/workspace/prql/Cargo.toml --target-dir /build/source/build/./cargo/build --profile=release-thinlto --offline --locked -- -Cdefault-linker-libraries=no

With rustSupport set to false it compiles just fine. And at some point I want to combine the two edition files into one like nginx/postgresql does.


move to pyproject.toml

Lets move to pyproject.toml in the most tool agnostic way using pip-tools and no poetry for a while.

Hey @rochacbruno I'm happy to give this a shot.


Add repo level support for DependenciesOnly PackageVersionPropsFlowType

The DependenciesOnly PackageVersionPropsFlowType feature is only supported in the full product source-build.  This means in the repo source-build legs the versions of the dependencies referenced by the repo are what are used rather than the latest/current.  This introduces a couple problems.

This is a cause for a difference in the repo legs versus full source-build.  The repo legs can be referencing an older version not even the same major version which can be a cause of breaks in the source-build.
The version referenced by the repo can be a source of repo level prebuilts if the version is not in SBRP.  We want to avoid adding SBRPs that are not referenced in the product build so these prebuilts get added as allowed prebuits.

Ideally when building the repo legs, we would be able to reference a relatively recent version of these dependencies.

One option is to add a version.details.xml attribute that would indicate latest for source-build.  One entry would be used for the MSFT build and the adorned one would only be used for the source-build repo leg.  This would require a dependency flow that would need to be kept relatively up-to-date.

This could be a solution for https://github.com/dotnet/source-build/issues/3566

https://github.com/dotnet/source-build/issues/3985 is an example of this issue. The prebuilts specified in that issue were not detected in the repo-level build but were detected in the VMR build.
This occured because the product (VMR) build relies on Version.Details to determine current package versions and detect prebuilts, whereas the repository builds use intermediates to determine current package versions and detect prebuilts.
In simpler terms, if the intermediate packages at the repository level contain packages that match the specified package versions within the repository (as defined in the Versions.Props file), prebuilts won't be detected. This occurred with the prebuilts specified in https://github.com/dotnet/source-build/issues/3985. The VMR, however, determines the current package versions from the bootstrapped SDK and Version.Details.xml, and this can result in the VMR expecting higher versions than those defined by the repo. Consequently, prebuilts can be detected in the repo build within the VMR but not by repo itself at the repository level.


Detect invalid guide structure in model-guide enumeration

Addresses #915
Pair coded with @eb8680
This adds a check to handle the changing of iarange contexts during model-side enumeration.
Tested

[x] added a death test to ensure invalid model+guide structure is detected
[x] added a test verifying that sequential guide enumeration + parallel model enumeration combine

Codecov Report

Merging #1356 into dev will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev    #1356      +/-   ##
==========================================
+ Coverage   95.76%   95.76%   +<.01%
==========================================
  Files         124      124
  Lines        6553     6560       +7
==========================================
+ Hits         6275     6282       +7
  Misses        278      278

Impacted Files
Coverage Δ

pyro/infer/traceenum_elbo.py
98.61% <100%> (+0.07%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 823ec5c...3765ed4. Read the comment docs.


Put tracery up on npm

I've not looked properly at this, but from my previous experience, the problems I had were largely down to code that implicitly depended on globals defined elsewhere (ie, jQuery, or other parts of the library). npm uses, as good practice(?) things like this:
var local = require('dependency');
Previously, I just took a hacksaw to the library and glommed it into a single file, stripped out any external dependencies, and hacked out all the AMD stuff, but this time round it'd be good to keep the two versions a bit more in sync (or even identical)
There's a further stage to this, which is somewhat separate, which is to test for breaking changes in the syntax against the current CBDQ corpus. The only one I can think of off the top of my head is //, but it's worth thinking of a way to look for others.

Ok, this one is AMD-free, and should 'just work' with no dependencies, JQuery is only needed if you run the test functions.
It's in a closure, so everything will be inside the 'tracery' global-scope object.  The other issue is that I split out the modifiers into mods-eng-basic.js, so you have to add import those separately, like this:
app.grammar = tracery.createGrammar();
app.grammar.addModifiers(baseEngModifiers);

Also, this one is a single file.  Last time I was trying to use Require, but I think I need an actual expert in it to show me how to do it properly (next hackathon I'll bribe someone)

It's done! It's got some manual changes, though, :<
https://github.com/v21/tracery/commit/e44886274798cd9629531c7becb6e2155ab48134

Oh, I literally just pushed a new version:

Fixing push/pop
added modifiers with parameters (like replace(a, b)

Other than that, not much in the way of changes, though.
https://github.com/galaxykate/tracery/tree/tracery2
On Tue, Jan 5, 2016 at 3:58 PM, George Buckenham<EMAIL_ADDRESS>wrote:

It's done! It's got some manual changes, though, :<
v21@e448862
https://github.com/v21/tracery/commit/e44886274798cd9629531c7becb6e2155ab48134
—
Reply to this email directly or view it on GitHub
https://github.com/galaxykate/tracery/issues/9#issuecomment-169173112.

ah, beautiful!


ffmpeg binary not found: /usr/local/bin/ffmpeg

Hi mate, freshly new containers, on a fresh server, using your SMA-MOD gives me this in SAB.
I tried bounding sma folder like this: /opt/scripts/sma/nzb:/usr/local/sma and when that didn't work, like this: /opt/scripts/sma/nzb/config:/usr/local/sma/config. Didn't help!
I also tried rebuilding containers. Still, getting below:
2021-07-10 22:32:39 - SABPostProcess - INFO - SAB post processing started.
2021-07-10 22:32:39 - resources.readsettings - INFO - /usr/local/sma/venv/bin/python3
2021-07-10 22:32:39 - resources.readsettings - INFO - Loading config file /usr/local/sma/config/autoProcess.ini.
2021-07-10 22:32:39 - SABPostProcess - INFO - Performing conversion
2021-07-10 22:32:39 - SABPostProcess - ERROR - Unexpected exception.
Traceback (most recent call last):
File "/usr/local/sma/SABPostProcess.py", line 60, in <module>
mp = MediaProcessor(settings)
File "/usr/local/sma/resources/mediaprocessor.py", line 51, in __init__
self.converter = Converter(settings.ffmpeg, settings.ffprobe)
File "/usr/local/sma/converter/__init__.py", line 27, in __init__
ffprobe_path=ffprobe_path)
File "/usr/local/sma/converter/ffmpeg.py", line 475, in __init__
raise FFMpegError("ffmpeg binary not found: " + self.ffmpeg_path)
converter.ffmpeg.FFMpegError: ffmpeg binary not found: /usr/local/bin/ffmpeg

What am I missing? :)

Ok, so I bashed in and deleted venv and rebuilt. Now they work as intended. Not sure why this behavior was on new containers.

Actually! the fix was only a one-time thing. I had to recreate the container for another reason, and it went back to script exit code 1 with the log above. I checked container logs, and usually when downloading and installing ffmpeg it takes 3-5 minutes, but everytime I delete the venv and recreate the container the process of downloading and installing ffmpeg takes less than 10 seconds, which is odd to me.
Not sure if this is helpful! But could it be that the ffmpeg repo in the mod perhaps is outdated or something?

You might be getting throttled from too many download attempts

So I'll be good recreating them tomorrow you think? :)

FFMpeg is handled at container start and has nothing to do with the container being rebuilt. No need to rebuild

Ah that makes sense. Thanks!
Best,
Morgan
On 11 Jul 2021, 20:36 +0200, Michael Higgins @.***>, wrote:

FFMpeg is handled at container start and has nothing to do with the container being rebuilt. No need to rebuild
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.


Add unit tests stage on Validator and Merger pipelines

SonarQube analysis reported 1 issue
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 MockClass.java#: Move this file to a named package.


Suggest error detail fields as named arguments in an error constructor expression

Description:
Creating a new issue for IV of https://github.com/ballerina-platform/ballerina-lang/issues/24382.
When a record is specified as the detail type of a user-defined error, can we suggest the names of the fields in the detail as the named args in the error constructor?

Blocked by https://github.com/ballerina-platform/ballerina-lang/issues/32755


Makes it possible to disable the vent pressure lockout temporarily with a screwdriver

About the PR
Using a screwdriver on a pressure-locked-out vent (yellow lights) disables the lockout for 30 seconds.
Why / Balance
When there is no gas on top of an air vent, the vent enters pressure lockout. To undo this, you need to go to the air alarm and set it to fill, which disables the lockout, or wait most of the round for the air to leak out. There are 3 problems with this.

You need atmos access to edit the air alarms, which means that an engi can have rebuilt everything, but you'll still need to get an atmos tech to refill the air.
It's a permanant change. The atmos tech then has to wait around for a minute while it refills. It's common for the tech to just leave the air alarm on fill, making the pressure lockout irrelevant.
There's no way to disable this without an air alarm.

This fixes all 3 of these problems.
Balance wise, the same effect can be achieved with a crowbar, wrench, and 2 sheets of steel by replacing the vent with a passive vent. It's actually less powerful than that, since it's only a temporary change.
From testing, 30 seconds is enough to fill a 5x5 room from a single vent.
Technical details
If a player uses a screwdriver on a vent, it checks if it's locked out. If it is, it starts a do-after. Once the do-after finishes it disables the lockout, and makes note of the current time + some delay. If the vent is locked out and the time is longer than the stored time, it re-enables the lockout.
Media

Vent just after being screwdrivered.

30 seconds later.

Requirements

[X] I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes
No breaking changes
Changelog

:cl:

tweak: Vent pressure lockout can be temporarily disabled with a screwdriver

Hello and thank you for your work on this PR.
I'm not entirely convinced that this is a mechanic that needs to exist, because:

You need atmos access to edit the air alarms, which means that an engi can have rebuilt everything, but you'll still need to get an atmos tech to refill the air.

Why is this a problem? We have engineers and atmos techs as separate jobs/access levels for a reason. We need to give more reasons for atmos techs to do things on the station (e.g. fix stuff) instead of sit around cooking frezon.

It's a permanant change. The atmos tech then has to wait around for a minute while it refills. It's common for the tech to just leave the air alarm on fill, making the pressure lockout irrelevant.

Why is this a problem? If you set the PA to 3, it's also a "permanent" change until the singularity looses. There should be consequences for atmos techs being lazy and/or incompetent.

There's no way to disable this without an air alarm.

Why should there be?
If we get down to the fundamental issue, maybe it's that atmos techs physically present at a vent should be able to control it or perhaps override air alarm settings. If that is truly the underlying issue, then we should be advocating replicating the air alarm UI elements for individual vents, instead of doing a one-off screwdriver hack. Why does the screwdriver change lockout, instead of something else more normal like the pressure threshold?
Or, if we want to enforce that air vents must be controlled through an air alarm, then given that you can already disable lock-out from an air alarm, that should be the canonical way to do so.

Yeah if you have a screwdriver you're already half way to hacking the air alarm and set it to fill yourself.

I think a better solution would be to add a button to each individual vent that allows it to bypass lockout, similarly to how each scrubber has the option to be set to widenet individually

i agree with Lank, should be a button in air alarm ui like all the others settings

i think this is good imo

someone without atmos access can already do this with a wrench and 4 steel, make a gas pump and passive vent there you go
this is just convenience, and since it automatically turns off its less prone to spacing all of distro

If you wanna fuck with atmos devices without required access, hacking an air alarm isn't very hard.

Yeah if you have a screwdriver you're already half way to hacking the air alarm and set it to fill yourself.

I don't think that having to hack into a panel to fill an an area with air as a non-antag engineer is a good thing. Instead what usually happens is you play the game of "how many doors do I have to open before the average pressure is above the lock-out value?" which is frustrating and usually makes the problem worse.

Why is this a problem? We have engineers and atmos techs as separate jobs/access levels for a reason. We need to give more reasons for atmos techs to do things on the station (e.g. fix stuff) instead of sit around cooking frezon.

I actually agree with this, and ideally you would bring an atmos tech to repressurise everything. But this game is inherently about chaos. In a lot of cases there's more places spaced than atmos techs. Also a lot of times atmos techs just don't respond to things. Having to stand around while you wait for an atmos tech to who isn't actually coming to push a button is a pain. It's a smaller, less severe version of the "if engineering is bad nobody else gets to have fun" problem.

I think a better solution would be to add a button to each individual vent that allows it to bypass lockout, similarly to how each scrubber has the option to be set to widenet individually

I'm not opposed to this as long as the button can be pushed by anyone. I wanted to keep it as simple as possible, and didn't want to mess around with UI stuff. It would mean that the system doesn't fix the following problem:

Why should there be?

It's impossible to bootstrap repressurising a room if the air alarm is destroyed / if you're building a new room without one. Having to grab a new air alarm board means one person walking to the tech vault / cargo, while everyone else stands around outside the spaced room waiting for them. With this you can open the vents, let people start doing stuff (healing people, brigging people, etc) and come back with the air alarm. It's a small thing but it means being less reliant on what the engineer choses to spend their time doing.

someone without atmos access can already do this with a wrench and 4 steel, make a gas pump and passive vent there you go
this is just convenience, and since it automatically turns off its less prone to spacing all of distro

This is pretty much my thought process in terms of balance, anyone who wants to sabotage distro has better methods than what this PR adds.
This is supposed to be a small thing that engineers can do, for minor spacing, or for situations where there isn't an atmos tech can't or won't come.

Hey, I gave it an in-game test and found a small problem: If you use a screwdriver on an unanchored vent in pressure lockout it will sometimes take priority over deconstructing, meaning you cannot deconstruct it. So you should check for anchoring in OnInteractUsing.
Otherwise this should be good to merge.

Looks good to me now. Thank you for your contribution!


Adding possibility to change SA in deployment

This is needed to easily change the SA in the operator deployment.
A fix for #361

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Looks good to me!
I'll go ahead and do some testing on this today.

Thanks for your quick response.
Do you plan to release any minor version anytime soon?