fix calculate price with tax rules in backend

Description

Questions
Answers

Why?
in Shopware we have an option to add Tax rules depend on customer group. when we add this rules. it's works fine in the frontend but not in the backend. The backend always take the default tax value instead off the customer group tax rule value.

BC breaks?
no

Tests exists & pass?
yes

Related tickets?
--

How to test?
look down

Requirements met?
ja

How to test?
we have two place to check in the backend the first one in articles management:

add a new customer group (e.g 'DK') .
add tax entry (e.g 19%) then add a rules to this tax entry (e.g 'DK' => 25%).
add new article (e.g net price 100 euro) that mean you must write for 'EK' => 119, 'DK' => 125
add this prices in the backend then check it in the Front End you will find that the EK price is right but the DK price is 131,30 because the backend controller calculate the net price depend on the default tax value not the tax rule related to the DK customer group ( if you check the database you will find that the net price for Ek is 100 and for Dk is<PHONE_NUMBER>0672 not 100 )

the second place is in the Marketing => items export => e.g Google Produktsuche :
before we start let us clear something. now in the database we have the net prices like the following:
EK => net price : 100 => +19% tax => price : 119
DK => net price :<PHONE_NUMBER>0672  => +25% tax rule => must be 131.30
now let us start :

make a copy from Google Produktsuche.
in the setting change the customer group to DK
run the code
you will see it will give you 125 it calculate the price depend  on the default tax value 19%

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-18507.
Please use this issue to track the state of your pull request.

Thanks @ahmad-saad. This change is critical and needs to be tested well. Please add some unit tests to verify your changes to the tax calculation.

This PR was closed due to inactivity. If this change is still important to you, feel free to create a new pull request.
For more information about our contribution guidelines, see https://developers.shopware.com/contributing/contribution-guideline/.


[Event Change Request] - SalesPost.Codeunit.al - OnInsertShipmentLineOnAfterInitQuantityFields

We like to request the following event change:
Object: SalesPost.Codeunit.al
ToDo: add var to SalesShptLine parameter
Where is the event placed:
local procedure InsertShipmentLine(SalesHeader: Record "Sales Header"; SalesShptHeader: Record "Sales Shipment Header"; SalesLine: Record "Sales Line"; CostBaseAmount: Decimal; var TempServiceItem2: Record "Service Item" temporary; var TempServiceItemComp2: Record "Service Item Component" temporary)
var
    ...
begin
    SalesShptLine.InitFromSalesLine(SalesShptHeader, xSalesLine);
    SalesShptLine."Quantity Invoiced" := -RemQtyToBeInvoiced;
    SalesShptLine."Qty. Invoiced (Base)" := -RemQtyToBeInvoicedBase;
    SalesShptLine."Qty. Shipped Not Invoiced" := SalesShptLine.Quantity - SalesShptLine."Quantity Invoiced";
    OnInsertShipmentLineOnAfterInitQuantityFields(SalesLine, xSalesLine, SalesShptLine);

    if (SalesLine.Type = SalesLine.Type::Item) and (SalesLine."Qty. to Ship" <> 0) then begin
        ...

Event Code:
[IntegrationEvent(false, false)]
local procedure OnInsertShipmentLineOnAfterInitQuantityFields(var SalesLine: Record "Sales Line"; var xSalesLine: Record "Sales Line"; var SalesShptLine: Record "Sales Shipment Line")
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


#2 - Upgrade Issues Templates

Resolves issue #2

@Christian-Oleson  Great work. One more change before we can approve. We have made few changes in the language and also the format of Code of conduct. Please check https://github.com/appwrite/appwrite template and update accordingly.
Thank you.

@Christian-Oleson Great work. One more change before we can approve. We have made few changes in the language and also the format of Code of conduct. Please check https://github.com/appwrite/appwrite template and update accordingly. Thank you.

I made a modification from what I found in the template. Please let me know if I have missed anything. Thanks!


Change log or release history?

Is there any consolidated info on the changes between versions, a change log perhaps?
It would be really nice if the releases were tagged in github and had information about the changes since the last version. And/or there could be a CHANGELOG.md. It's difficult to upgrade if we have to read the diffs of every commit to see what changed!

This is old, but still a very relevant request.


README update

Signed-off-by: Cristián Gutiérrez<EMAIL_ADDRESS>Description
This PR fixes #153
Notes for Reviewers
Signed commits

[X] Yes, I signed my commits.

Done @Anita-ihuman. Tell me if I can help you with anything else. Have a nice day!


⚠ Carbubu has degraded performance

In 6a6cd4c, Carbubu (https://carbubu.fr) experienced degraded performance:

HTTP code: 200
Response time: 5258 ms

Resolved: Carbubu performance has improved in b9fec2c after 6 minutes.


[BEAM-7390] Add code snippet for Top

Adding the code snippets for Top.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Run Portable_Python PreCommit

Run Python PreCommit

@pabloem friendly ping :)


local variable 'url' referenced before assignment

Hi, I keep getting this error whenever I try to play any videos using this integration. Music files work just fine it just does this with the videos. Is there something I'm missing? Or is this a bug, and if so is there any kind of workaround?
Here is the full log out gives with the error:
`Logger: homeassistant.components.websocket_api.http.connection
Source: custom_components/jellyfin/init.py:1264
Integration: Home Assistant WebSocket API (documentation, issues)
First occurred: 5:20:21 PM (1 occurrences)
Last logged: 5:20:21 PM
[281473142058432] local variable 'url' referenced before assignment
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 185, in handle_call_service
await hass.services.async_call(
File "/usr/src/homeassistant/homeassistant/core.py", line 1491, in async_call
task.result()
File "/usr/src/homeassistant/homeassistant/core.py", line 1526, in _execute_service
await handler.job.target(service_call)
File "/usr/src/homeassistant/homeassistant/helpers/entity_component.py", line 213, in handle_service
await self.hass.helpers.service.entity_service_call(
File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 658, in entity_service_call
future.result()  # pop exception if have
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 760, in async_request_call
await coro
File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 695, in _handle_entity_call
await result
File "/usr/src/homeassistant/homeassistant/components/cast/media_player.py", line 453, in async_play_media
sourced_media = await media_source.async_resolve_media(self.hass, media_id)
File "/usr/src/homeassistant/homeassistant/components/media_source/init.py", line 85, in async_resolve_media
return await _get_media_item(hass, media_content_id).async_resolve()
File "/usr/src/homeassistant/homeassistant/components/media_source/models.py", line 83, in async_resolve
return await self.async_media_source().async_resolve_media(self)
File "/config/custom_components/jellyfin/media_source.py", line 116, in async_resolve_media
t = await self.jelly_cm.get_stream_url(media_content_id, media_content_type)
File "/config/custom_components/jellyfin/init.py", line 1264, in get_stream_url
_LOGGER.debug("stream info: %s - url: %s", info, url)
UnboundLocalError: local variable 'url' referenced before assignment
`

Hi. Please set the component in "debug" and provide the logs.
Thanks.
logger:
  default: info
  logs:
    custom_components.jellyfin: debug
    JELLYFIN.jellyfin_apiclient_python: debug
    JELLYFIN.jellyfin_apiclient_python.ws_client: debug

Is this what you're looking for?
https://pastebin.com/VEXprrUJ

Hi. Yes, but I'd need you to reproduce the issue, then sending me those logs.
Thanks

Ah gotcha, try this one: https://pastebin.com/C9WVX3dF

Thanks.
The problem here is that the file is basically not playable: 'SupportsTranscoding': False, 'SupportsDirectStream': False, 'SupportsDirectPlay': False
I'll fix that in the integration code.


Problem connecting, sending, receiving mails

Hi !,
Actually I've some problems about the connection t omy mailserver using Thunderbird.
When I wanna send a mail through my personnal email adress, the result is a 502 Bad Gateway error.
I've generated the dkim key and added to my domain name provider (OVH) but I'm blocked, if someone can help me I'll be happy.
Thanks in advance.
(sorry if my english isn't correct at 100%)

Provide some proper logging and maybe we can assist.


cardano-node OBFT - test integration setup

Issue Number

#1346
Overview

25fe5815f66de7a909a915dbcc2aa1dd517d4f68
make byron's 'newNetworkLayer' use bracket style allocation
So that the underlying connection to the node gets cleaned-up when the network layer is destroyed.
Also, make sure to clean up past clients when creating new cursors

b2b466064e1d0eaa5e47716faa77d1ad88ae8b9a
Retry connecting to client when the socket does not exist

fc51990aa95d43d6476e0012adb343cb7e6c6414
move byron integration scenarios requiring a shelley wallet to Scenario/API/Wallets

230ac845bcb62c116d511652b7ca7ad04e04e563
implement 'getCurrentNodeTip' for Byron's network layer

bf65a99611e863175d1b220f2eec077205f3e1bf
Move faucets declarations to core-integration for sharing

455aba4264a5cfa8cd72cfc314479fbd339d2118
add basic integration setup for cardano-node OBFT

99de24a5697fb9f04038ec536c732a9c5bbde308
fixup Byron network layer implementation.

b32000c67b71cdc6852898a946893c9c13264fb6
remove hard-coded blockchain parameters from integration scenarios
The parameters are actually different for each network, in particular on Byron where the start_time
changes on every restart

2cfee3c199188c5f957307ff593bba27e59972a2
remove unused dependencies and weeds

cd4f04dec3a16c3f514f8f19df5fa810fcec409a
re-generate nix machinery

a10afb5c5575a19024dc22704565afa1c8e80f70
remove unavailable commands from cardano-wallet-byron
These require non-byron wallets, so it doesn't make sense to have them part of the command-line.

fcaed2b76b2d06179c761bd78d05b90741db3635
Fix wrong protocol magic for TestNet
Whoops. Fortunately, we only used MainNet Byron addresses on the ITN :no_mouth:

4c970983bf0634dd70b51e91e5ecc814450ce683
require no magic for cardano-node in the integration setup
We use the 'mainnet' network target which doesn't require any magic inside addresses and such.

Comments

$ stack test cardano-wallet-byron:integration
.
.
.
.
Finished in 385.0136 seconds
62 examples, 0 failure

:warning: There's two scenarios that are pretty long to run in the NETWORK_ group: they need to wait for the next epoch, but in OBFT byron, the epoch length is 10*k. I am not quite sure about setting k to values that are too small, so I set it to k=10 at the moment which seems fine (might revisit later) but still leads to an epoch length of 100 slots.

bors r+

bors r+

bors r+


Fix error is not assigned correctly.

when error is used inside a block of -enumerateKeysAndObjectsUsingBlock:. It setups an autorelease pool, by the time it returns, any out error will be deallocaed. we need to use __block, as in code *tmpError
I assume put error in enumerateKeysAndObjectsUsingBlock is equal to code below.
- (void)produceError3:(NSError **)error {
    void (^errorProduceBlock)() = ^{
        @autoreleasepool {
            *error = [NSError errorWithDomain:@"AWESOME ERROR" code:0 userInfo:nil];
        }
    };

    errorProduceBlock();
}

- (void)produceError5:(NSError **)error {
    [@{@"DD":@"YY"} enumerateKeysAndObjectsUsingBlock:^(id key, id obj, BOOL *stop) {
        *error = [NSError errorWithDomain:@"AWESOME ERROR" code:0 userInfo:nil];
    }];
}

Both code will crash. But I don't know why MTLManagedObjectAdapter won't crash, it will just silently ignore the error.

I think this also addressed some of the discussion in https://github.com/Mantle/Mantle/pull/120


Buildscript Remake

📝 Description
This PR remakes the build script from scratch, converting it to KTS, and updating Gradle.
🎯 Goals

Fix issues like the mod sometime not compiling changes or compiling at all
Make the build script cleaner
Prepare for switching to from tags to buildConfig

❌ Non Goals

It is not a goal to make compiling faster

🚦 Testing
Running the client in dev env, building the mod.
⏮ Backwards Compatibility
This is an internal change that will not impact the mod in a direct manner.
📚 Related Issues & Documents
None.
🖼 Screenshots/Recordings
None
📖 Added to documentation?

[ ] 📜 README.md
[ ] 📑 Documentation
[ ] 📓 Javadoc
[x] 🍕 Comments
[ ] 🙅 No documentation needed

@coderabbitai review


feat: Ability to see debug information and console at the same time

Ability to see debug information and console at the same time
Move console below the Cairo code editor, similar to evm.codes, so that it is visible all the time.
Note: do not forget to update keyboard shortcuts accordingly (KBar).

Can I jump on that?

Please go ahead @LukaszMMazur !
Also feel free to join the cairovm.codes telegram group chat for contributors here: https://t.me/+DYI4FMia43I1NDI8

@LukaszMMazur if you need any help, please let me know, I would like to collaborate


Update tinyproxy to 1.8.3

We already updated to 1.8.3 but then the container does not start and logs the following message
tinyproxy: Could not open config file "/data/etc/tinyproxy.conf".
Let's revert to latest and fix this issue for the time being and later upgrade to 1.8.3 and fix this.

We no longer use proxies


Specify what parts of the programmatic API that are part of the public API

According to semver, anything that is not part of the public API can change at any time, even between patch releases.
For projects that have a dependency on JSCS and that are using the programmatic interface it would be really useful to know what parts of that interface, if any, are part of the public API.
For example, in a project I am maintaining I am using the functions shown in the "Programmatic usage" section in the documentation. In addition, I am expecting a result from checker.checkString(stringOfCode).getErrorList() to return an array of objects with properties message, line, and column if applicable. The return value of getErrorList is not in the documentation, so I guess that in theory even a patch release of JSCS can break my application.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/27038476-specify-what-parts-of-the-programmatic-api-that-are-part-of-the-public-api?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github).

Are you getting a specific error? If it's the same as https://github.com/jscs-dev/node-jscs/issues/1816, then I think https://github.com/jscs-dev/node-jscs/commit/f12830a469959f3543c51bfc632fe37292ea6d09 should fix it - we will release a patch version since it was a regression (so I don't think that was intended)

Ok released 2.2.1

Sorry if I was unclear. This is a problem with the documentation, not the code, so there is no error.
I am wondering if it would be possible to add something to the documentation that clearly states what parts of the programmatic interface that are part of the public API? When I say "public API", I mean public  API according to the [http://semver.org](semver documentation):
"Software using Semantic Versioning MUST declare a public API. This API could be declared in the code itself or exist strictly in documentation. However it is done, it should be precise and comprehensive."
JSCS uses semver, and there is a section "Versioning & Semver" in the JSCS documentation with details.
For projects that have a dependency on JSCS and that use the programmatic interface it would be really useful to know what parts of the programmatic interface that are parts of the public API.

Ok I think https://github.com/jscs-dev/node-jscs/issues/1084 is similar - so at least those, but yeah that's certainly something that should be added.

At this point only major and CST related bugs will be fixed.


Adapt to new db structure and naming

All dbs are now under mainnet or testnet. There is no reference to the chain in the sub directories.
Db files are ending with .sqlite.
const prefix =
  target === "mainnet"
    ? "mainnet"
    : target === "xenon"
    ? "testnet"
    : target === "mocknet"
    ? "mocknet"
    : "regtest"
const peer_db_path = `${prefix}/peer_db.sqlite`
const burnchain_db_path = `${prefix}/burnchain/burnchain.sqlite`
const sortition_db_path = `${prefix}/burnchain/sortition/marf.sqlite`
const vm_db_path = `${prefix}/chainstate/vm/index.sqlite`
const staging_db_path = `${prefix}/chainstate/vm/index.sqlite`

not sure about the header db, is it the same as the staging db?

Already fixed


Install and configure Vite

This application will use Vite for the front-end tooling. It will need to be added as a dependency, and configured. It should be created with the react preset.

This was completed with commit: 1077a3d80861240b06350c0fe37eaf708d681f90


remove 4 bill status from reports and bridge docs

@santosh-setu Any update here? It's been open since long


Optimizer api change

Changed the optimizer's API (little but breaking).
improved criterion for SLIM convergence
Addition of UserKNN (Asymmetric) Cosine
Remove RandomWalkWithRestart (almost never useful)

Codecov Report

Merging #35 (55d924a) into main (cb1fde4) will decrease coverage by 0.13%.
The diff coverage is 94.31%.

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   95.38%   95.24%   -0.14%
==========================================
  Files          61       60       -1
  Lines        3010     2988      -22
==========================================
- Hits         2871     2846      -25
- Misses        139      142       +3

Codecov Report

Merging #35 (55d924a) into main (cb1fde4) will decrease coverage by 0.13%.
The diff coverage is 94.31%.

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   95.38%   95.24%   -0.14%
==========================================
  Files          61       60       -1
  Lines        3010     2988      -22
==========================================
- Hits         2871     2846      -25
- Misses        139      142       +3


Low performance while generating millions of utterances

I noticed that the performance get very low when you generate a lot of permutations. The issue is that you validate every new sentence with every generated so far.
The performance issue is located in UtteranceGenerator.store(). For my usage I removed the check and added a post processing check.
Please consider to move the check out of the storage.

Sounds reasonable :)
I did never stress this tool like you did. I agree this needs an improvement even though it is not very relevant for the use case of Alexa skills. Interaction model size is limited and won´t store millions of utterances. The most I`ve seen so far was about 15k utterances.

Hi Rekire,
with the new version 2 of the generator I paid more attention to runtime performance. Even though I followed your suggestion and now do validation and double detection at the very end of the process I still takes ages to process millions of utterances. I am sorry. I tried to improve the detection logic but seems like there is still room for improvement. If you want to give it a try, here it goes: https://github.com/KayLerch/alexa-utterance-generator/blob/master/src/main/java/io/klerch/alexa/utterances/model/InteractionModel.java#L110


Split Terminal Command based on Workspace Path  #45694

Made Split Terminal work like the Create Terminal command including (In Active Workspace) option.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: kennyle1412 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @kennyle1412! I'll check this out soon for the April release as we're currently in endgame/testing for the March release. Could you fix the conflicts in the meantime?

@Tyriar yeah, no problem! Take as long as you need.


Fixed code style issues in lib/Rpc

Fixed code style issues in lib/Rpc folder.
For more details about code style issues see #67.

NOTE: This PR can be merged once all CI builds are green.


IOError: [Errno socket error] [Errno 0] Error

Configure the environment on x86 linux, then connect the computer data cable to the arm andriod device to run "bash tools/benchmark.sh --benchmark_option=Performance --target_abis=armeabi-v7a,arm64-v8a,aarch64,armhf", error "IOError: [Errno socket error] [Errno 0] Error"
INFO: Analysed target //aibench/python:benchmark (0 packages loaded).
INFO: Found 1 target...
Target //aibench/python:benchmark up-to-date:
bazel-bin/aibench/python/benchmark
INFO: Elapsed time: 0.289s, Critical Path: 0.00s
INFO: 0 processes.
INFO: Build completed successfully, 1 total action
downloading mobilenet-v1_1544063874.pb...
Traceback (most recent call last):
File "/home/liupeng/mobile-ai-bench-master/bazel-bin/aibench/python/benchmark.runfiles/aibench/aibench/python/benchmark.py", line 299, in
main(unused_args=[sys.argv[0]] + unparsed)
File "/home/liupeng/mobile-ai-bench-master/bazel-bin/aibench/python/benchmark.runfiles/aibench/aibench/python/benchmark.py", line 252, in main
FLAGS.output_dir)
File "/home/liupeng/mobile-ai-bench-master/aibench/python/sh_commands.py", line 368, in prepare_all_models
get_model(model, output_dir, push_list)
File "/home/liupeng/mobile-ai-bench-master/aibench/python/sh_commands.py", line 306, in get_model
output_dir, push_list)
File "/home/liupeng/mobile-ai-bench-master/aibench/python/sh_commands.py", line 293, in get_model_file
urllib.urlretrieve(file_path, local_file_path)
File "/usr/lib/python2.7/urllib.py", line 98, in urlretrieve
return opener.retrieve(url, filename, reporthook, data)
File "/usr/lib/python2.7/urllib.py", line 245, in retrieve
fp = self.open(url, data)
File "/usr/lib/python2.7/urllib.py", line 213, in open
return getattr(self, name)(url)
File "/usr/lib/python2.7/urllib.py", line 443, in open_https
h.endheaders(data)
File "/usr/lib/python2.7/httplib.py", line 1038, in endheaders
self._send_output(message_body)
File "/usr/lib/python2.7/httplib.py", line 882, in _send_output
self.send(msg)
File "/usr/lib/python2.7/httplib.py", line 844, in send
self.connect()
File "/usr/lib/python2.7/httplib.py", line 1263, in connect
server_hostname=server_hostname)
File "/usr/lib/python2.7/ssl.py", line 369, in wrap_socket
_context=self)
File "/usr/lib/python2.7/ssl.py", line 617, in init
self.do_handshake()
File "/usr/lib/python2.7/ssl.py", line 846, in do_handshake
self._sslobj.do_handshake()
IOError: [Errno socket error] [Errno 0] Error

It seems like a network issue, so you can try something below to check it.

use urllib.urlretrieve in python code to download a file.

or

use wget in command line to download a file.

You can select a url from here to test.


Adding time to task removes all other block properties

What happens: If you add time to a task in the calendar view, it will remove all the block properties.
To Reproduce
Create a task
TODO do something
date:: [[Jun 26th, 2022]]
project:: [[Test Project]]

Go to calendar view
Set "All Day" to "No"
Set the "start" and "end" time of the task
Click OK

The task becomes
TODO 00:02-00:32 do something
Expected behaviour
Task should contain the original block properties
TODO 00:02-00:32 do something
date:: [[Jun 26th, 2022]]
project:: [[Test Project]]

Hi @haydenull, I'm not sure if you've recently re-looked at this bug, but it is severely hampering the ability to track Project tasks from the Journal or anywhere that isn't the "Project page", going against the general intended Logseq flow.
I think it is a fairly critical, core-feature breaking bug.
Thanks in advance! 🙏

I apologize for the delay in my response. The reason for my delay was that I was waiting for official API to improve.
However, considering that this problem is quite serious for some people, I will temporarily fix it using some less concise methods.
It can be expected that the issue will be fixed in the new version, which will be released in one day.

Yout can try version 1.5.2 to see if it solves this issue. Please feel free to let me know if you encounter any problems.


Websocket route and catch all route doesn't work together

If I have the following route definiton:
http.webSocket("/api/service", websocket);
http.get("*", (req, res) -> new String(Files.readAllBytes("index.html")));

The catch all route will actually shortcut the websocket connection.

Additionally, if you use the notFound handler, it will not be triggered, and the default 404 page is returned:
http.webSocket("/api/service", websocket);
http.notFound((req, res) -> new String(Files.readAllBytes("index.html")));

I can confirm that if you add a webSocket() the notFound() stops working.


Determine ATL03 variables needed for consolidated HDF5 test file

Utilized ATBD and earthdata-varinfo to inform what information is needed for a controlled ATL03 HDF5 test file.

Closing this ticket in favor of task under #27


Need to figure out GDAL version

Right now it is hard-wired to my local GDAL version, need to somehow set pyproject.toml so it installs whatever the local version is.

See https://github.com/digitalearthpacific/dep-coastlines/issues/8

In lieu of pinning, easiest way is to try to install (poetry install) then if it fails due to gdal version mismatch, pip install the appropriate version for the system then try to install via poetry again


make gpgsql-password optional

At least for postgresql it's not required that the database_user has a password.

I'm not sure about this PR. I'm leaning towards forcing database passwords as it is more secure. I also understand that flexibility is really useful too. I'd probably introduce a new variable myself which specifically disables the need for it. This would make it really explicit.

@ju5t can you take a look again?

hi @ju5t , let me know if you're happy with this or want more/other tests.

@ju5t can you please take a look again?

Sorry for the delay. Looks good to me thanks!


怎么不放糖才能让煎饼果子的味道变成甜的？

VSCode Version:
OS Version:

Steps to Reproduce:

This issue is totally spam :rage:


NameError: name 'prod_smarts_fp_to_templates' is not defined

You'll need to pass in argument or define tem as global


New definitions for office-js library

office-js/office-js.d.ts
check list

[ ] is collect naming convention?

https://www.npmjs.com/package/office-js
http://bower.io/search/?q=office-js
others?

[X] has a test file? (office-js/office-js-tests.ts or others)
[ ] pass the Travis-CI test?

Removed the license from the file.  Regarding naming, the library is not on npm or bower - only available via CDN.

https://www.npmjs.com/package/office-js is already exists.
please rename something else ... like ... microsoft-office-js? it is not exists on npm and bower.

I don't think renaming is going to help much. Because there are no packages for it on bower or npm, someone can come along after this is added here and use the same name in npm or bower, regardless of what we choose. I'll see what we can come up with, though.

Talked with the owner of office-js and he unpublished his project.  I think we should be good to go with the naming now.

wow, okay. it merged.


JAX elements transposed relative to NumPy

For some usages of JAX, the elements of an array seem to be transposed relative to NumPy leading to unexpected result. This is for example the case for matplotlib histograms.
import jax.numpy as jnp
import matplotlib.pyplot as plt
import numpy as np

fig, axs = plt.subplots(1, 3)
axs.flat[0].hist(np.linspace(0., 1.))
axs.flat[0].set_title("Expected Result (NumPy)")
axs.flat[1].hist(jnp.linspace(0., 1.))
axs.flat[1].set_title("JAX Result")
axs.flat[2].hist(np.linspace(0., 1.).reshape(1, -1))
axs.flat[2].set_title("JAX Result w/ NumPy")
fig.tight_layout()
plt.show()

What versions of jax and jaxlib are you using?
With the most recent jax and jaxlib releases, I find that the jax result matches the numpy result.

The numpy version might be relevant as well, because the first thing matplotlib does is check np.isscalar(x) and reshape the input if it returns True: https://github.com/matplotlib/matplotlib/blob/5bb1449ced7653ba5357c43017ba6c8a04e1f21a/lib/matplotlib/axes/_axes.py#L6538

I ran the above code using the CPU backend and jax==0.2.26 but I also tested the most recent commit 83174dc14. I have jaxlib==0.1.75, numpy==1.21.3 and matplotlib==3.5.0 installed.
Furthermore, I tested the same code snippet on a different computer with jax==0.2.26, jaxlib==0.1.75, numpy==1.21.2 and matplotlib==3.4.3.

I've narrowed it down to a matplotlib issue. In matplotlib 3.2.2 and older, the plot shows up correctly. In matplotlib 3.3.0 and newer, the plot is incorrect. You might look through the matplotlib changelog to figure out what's changed.
In the meantime, you should know that in general it is not 100% safe to pass JAX arrays to packages that expect numpy arrays as input, because those packages do not always do correct input validation (in this case, matplotlib fails to call np.asarray() before applying numpy functions like np.isscalar to the inputs).

I'm going to close, because I don't think is a JAX issue.

I am pretty sure that this changed at some point when updating jax or jaxlib and I never had a matplotlib version older than 3.4.1 installed on my system.

I can reproduce the "correct" histogram with jax==0.2.20, jaxlib==0.1.71 and matplotlib==3.5.0.

In the meantime, you should know that in general it is not 100% safe to pass JAX arrays to packages that expect numpy arrays as input, because those packages do not always do correct input validation (in this case, matplotlib fails to call np.asarray() before applying numpy functions like np.isscalar to the inputs).

Sure, binary compatibility with numpy is not a sensible goal. However, matplotlib certainly is not any arbitrary library. Furthermore, the input validation you are referencing is not meant to catch JAX arrays. I.e. calling np.asarray on objects will most likely not be the solution here. np.isscalar works on many more objects than np.asarray, see here.

The best thing to do is call np.asarray yourself.

That is exactly what I am currently doing but I though JAX might treat this as a regression considering that it worked in the past.

I think the relevant change is this: starting in JAX 0.2.26, iter(device_array) returns jax arrays rather than numpy arrays.
Here is the difference between JAX 0.2.25 and JAX 0.2.26:
from matplotlib import cbook
import numpy as np
import jax.numpy as jnp
import jax

print(jax.__version__)
# 0.2.26

x = jnp.arange(2)
x_np = np.arange(2)
print(list(x))
# [DeviceArray(0, dtype=int32), DeviceArray(1, dtype=int32)]

# Utility used by hist():
print(cbook._reshape_2D(x, 'x'))
# [array([0], dtype=int32), array([1], dtype=int32)]

print(cbook._reshape_2D(x_np, 'x'))
# [array([0, 1], dtype=int32)]

from matplotlib import cbook
import numpy as np
import jax.numpy as jnp
import jax

print(jax.__version__)
# 0.2.25

x = jnp.arange(2)
x_np = np.arange(2)
print(list(x))
# [0, 1]

# Utility used by hist():
print(cbook._reshape_2D(x, 'x'))
# [array([0, 1], dtype=int32)]

print(cbook._reshape_2D(x_np, 'x'))
# [array([0, 1])]

I think where this falls afoul of matplotlib's assumptions is in this line: https://github.com/matplotlib/matplotlib/blob/c2a5e22baf6eeb4c5e49028d8ef10adf5a6f4f32/lib/matplotlib/cbook/init.py#L1392-L1393
JAX arrays are iterable, and numpy scalars are not.
For what it's worth: you can cause the same failure mode without JAX by passing a list of zero-dimensional numpy arrays (with matplotlib version 3.4.1):
fig, axs = plt.subplots(1, 2)
axs.flat[0].hist(np.linspace(0., 1.))
axs.flat[1].hist([np.array(i) for i in np.linspace(0., 1.)]);

It looks like a bug in how matplotlib treats iterables of zero-dimensional arrays, and not a bug in JAX.

Thank you for the detailed explanation. I see that returning 0D DeviceArrays when iterating over a 1D DeviceArrays is desirable but "breaks" some edge-cases when one relies on the numpy behavior of the iterables of a 1D array being python native datatypes.

This issue is now fixed in matplotlib https://github.com/matplotlib/matplotlib/pull/22018


Remove override for karaf jaxb-api following upgrade to 4.2.7

Following #1068 "Bumps karaf version to 4.2.7 (latest)" the Brooklyn build was
failing with the below error.
Seems we can now remove the override from 81edd728
as part of #1035 "Use dependencyManagement from Karaf as a bom".
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-remote-resources-plugin:1.5:process (default) on project rpm-packaging: Failed to resolve dependencies for one or more projects in the reactor. Reason: Missing:

[ERROR] ----------

[ERROR] 1) javax.xml.bind:jaxb-api:jar:2.3.2

[ERROR]

[ERROR]   Try downloading the file manually from the project website.

[ERROR]

[ERROR]   Then, install it using the command:

[ERROR]       mvn install:install-file -DgroupId=javax.xml.bind -DartifactId=jaxb-api -Dversion=2.3.2 -Dpackaging=jar -Dfile=/path/to/file

[ERROR]

[ERROR]   Alternatively, if you host your own repository you can deploy the file there:

[ERROR]       mvn deploy:deploy-file -DgroupId=javax.xml.bind -DartifactId=jaxb-api -Dversion=2.3.2 -Dpackaging=jar -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]

[ERROR]

[ERROR]   Path to dependency:

[ERROR]   	1) org.apache.brooklyn:rpm-packaging:pom:1.0.0-SNAPSHOT

[ERROR]   	2) org.apache.brooklyn:apache-brooklyn:zip:1.0.0-SNAPSHOT

[ERROR]   	3) org.apache.karaf.features:enterprise:xml:features:4.2.7

[ERROR]   	4) org.hibernate:hibernate-osgi:jar:5.4.2.Final

[ERROR]   	5) org.hibernate:hibernate-core:jar:5.4.2.Final

[ERROR]   	6) javax.xml.bind:jaxb-api:jar:2.3.2

[ERROR]

@kemitix can you take a look at this?

@geomacy LGTM, let see if Jenkins is happy with that. If yes, happy merge!


A valid CSV mapped as not valid?

Hi,
I have this CSV, that seems to me valid.
But if I run validate on it, I have a lot of errors.
Am I wrong or frictionless cli?
Thank you

Hi @aborruso,
It seems Python's csv sniffer can't detect delimiter correctly. It works if we provide it explicitly:
frictionless describe tmp/issue-1384.csv --dialect '{"csv": {"delimiter": ";"}}'

schema:
  fields:
    - name: Codice univoco programma
      type: string
    - name: Programma
      type: string
    - name: Descrizione programma
      type: string

Please let me know if we can help with something else

thank you @roll


[stdlib] use a primary associated type for initialize(fromContentsOf:)

Express Slice<UnsafeMutableBufferPointer>.initialize(fromContentsOf:) using some notation
(primary associated type).
Follow-up to SE-0370 (https://github.com/apple/swift/pull/41608)

@swift-ci please test linux platform


Unindentation of new lines

Summary:
In a indented block of code, making a new line break precedent indentation by replacing tabs with 4 spaces : unindent with 'shift+tab' or 'del' is no more available.
Steps to reproduce:

write a line of code ; go to next line
indent then write another line ; go to next line
try to unindent

Software used:

ungoogled-chromium (both online and pwa versions)

Hi, thanks for the feedback.
I am looking to fix this, it seems that this is the default behavior of Codemirror and I need to rewrite some of the smart indentation function.
I will work on this problem next week.

Fixed in b4f2c5 ✅
I also changed the tab size for 2 spaces to respect Ocaml Style Guide.


Refresh sequence control for shared configuration

For configurations shared among multiple services, sometimes we may need to control the configuration refresh sequence depending on the services. Do you plan to support refresh sequence control for shared configuration cases?

@lissdy can you provide us an example so we can confirm that we understand the ask here?

@lissdy please let us know when you have an update. Closing for now.


Load fixers from StyleCI config instead of PHP-CS-Fixer

Note that the fixer names match that of 2.0, not 1.x. There are some differences.

For example, phpdoc_align is named phpdoc_params in 1.x.

Oh, yeh, I see you copied the aliases stuff over. :)

You'll need to work the aliases backwards to be compatible with 1.x.

Note that the fixer names match that of 2.0, not 1.x. There are some differences.

For aliases and missing fixers, this is plan on #10 and #13.
I just made a quick fix to make this bridge more compliant with StyleCI.
And yeah, we have Laravel preset now. \o/ ;-)

:)

Can I chat to you on slack or something?

Or skype. Got some things I want to discuss with you. :)

The best for me is to contact me by mail at soullivaneuh(at)gmail.com. :+1:
You can also add me at hangout if you want direct chat.


Command Block Permission node

Need to allow admin users to place and modify command blocks without having 'OP' as it is disabled.

If you're using Sponge, you get access to two permission nodes

Allow editing an ordinary commandblock of the given name: minecraft.commandblock.edit.block.
Allow editing a minecart commandblock of the given name: minecraft.commandblock.edit.minecart.
As well as a spawn protection bypass.

using spigot

Spigot doesn't have a permission for it.

Switching server APIs is ultimatly up to you.
Most Spigot plugins and mods won't work on Sponge, but in many cases there is already a Sponge or Forge replacement.
There is a slight learning curve when switching, but I personally think it's worth it.

Installed a bukkit plugin that provided the permission nodes https://dev.bukkit.org/projects/commandblockperms


fix: incorrect sortition params

Hardcode sortition params change because of a bug where different nodes around hard fork have difference data

prnet cleaned-up successfully


Cannot use Access mode: Browser (direct) as queries are always sent though Grafana

Describe the bug
Setting the Zabbix data source access mode to browser (direct) does not change how the data source accesses Zabbix. It always uses Grafana as proxy.
Screenshots
When clicking Save & Test

Network data
Grafana returns the correct information when saving the data source

{"id":1,"uid":"12WroeCMk","orgId":1,"name":"Zabbix-datasource","type":"alexanderzobnin-zabbix-datasource","typeLogoUrl":"","access":"direct","url":"http://<IP_ADDRESS>:8080/api_jsonrpc.php","password":"","user":"","database":"","basicAuth":false,"basicAuthUser":"","basicAuthPassword":"","withCredentials":false,"isDefault":false,"jsonData":{"addThresholds":false,"alerting":true,"alertingMinSeverity":0,"cacheTTL":"","dbConnection":{"enable":false},"disableDataAlignment":false,"timeout":"","trends":true,"trendsFrom":"7d","trendsRange":"7d","username":"Admin"},"secureJsonFields":{"password":true},"version":23,"readOnly":false}

Software versions

Grafana
Zabbix
Grafana-Zabbix Plugin

7.4.5
4.0.18
4.1.4

Direct browser access seems to be unsupported in versions starting from 4.0
https://github.com/alexanderzobnin/grafana-zabbix/issues/1037


account abstraction using its own "custom" constants instead of using shared constants...

Problem
Consider abi.nr where we store MAX_ARGS. If I want to change this, I need to manually find all places where this is used and update there too since I can't read the MAX ARGS slot like in  entrypoint.nr - notice how because we can't do math or refer other storage slots, we have to manually update the counts everywhere.
When updating MAX_ARGS, I actually didn't know where else it had to be updated (because relevant comments weren't there) so everything broke temporarily (ty @sirasistant for your help btw!)
Happy Case
Instead of
// MAX_ARGS * (ACCOUNT_MAX_PUBLIC_CALLS + ACCOUNT_MAX_PRIVATE_CALLS)
global ACCOUNT_FLATTENED_ARGS_SIZE: comptime Field = 32;

have:
global ACCOUNT_FLATTENED_ARGS_SIZE: comptime Field = abi::MAX_ARGS * (....)

this would also prevent the number of vars that need to be passed in!
Alternatives Considered
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response

This looks like a potential duplicate of https://github.com/noir-lang/noir/issues/1734. Can you confirm if allowing globals to reference other globals would solve your issue?

yup is a duplicate my bad!


First Commit

Hi Chris,
You sent a PR to this master repo but it looks like you are working on your solution instead. Did you real mean to send this? Also FYI, never check in API keys/secrets/passwords on GitHub.com, even if it is for free.


docs: Add peripheral registers

Generates documentation for the Snitch cluster peripheral registers, including the performance counters, from the respective .hjson description file.
Depends on https://github.com/pulp-platform/register_interface/pull/42, so wait for it to be merged first and update Bender dependency.

I think we can already review/merge this and then as soon as https://github.com/pulp-platform/register_interface/pull/42 is released we can update the Bender dependency.


ARROW-13382: [C++] Avoid multiple definitions of same symbol

Two questions:

Is there a reason that Sum is the only kernel affected? Should we expect others (present and future) to need the same treatment?
Just confirming, the base commit of this PR is before the one that breaks with zstd? Otherwise I'd expect the autobrew job to still fail, just differently.

Sum happens to be one of the few functions with explicit kernels for differing SIMD levels, and it accomplishes this with some common code. In the future, hopefully we'll have a better approach for SIMD, but this sort of thing will be something we need to keep in mind.
The base commit here is the original commit that broke the sum kernel.


Realigning after tracking loss

Hello,
We are using the OakD with SDK 1.14.
Is there a way(either by saving or by setting the last co-ordinates before tracking loss) to correct the camera pose.
We are seeing huge jumps, sometimes back to 0,0 when the SpecAI reports a tracking loss.
Thank you!

Hello. Currently we do not have this relocalization feature (after tracking loss) in the SDK and there are no immediate plans to implement it, unfortunately.

@oseiskar
Could you explaing what happens to the pose, once tacking recovers from a loss? If I can understand the recovery model, I can manage it on the host side.
Thank you.

We do not specify/guarantee what exactly happens in this case. It is implementation specific and subject to change between SDK versions. In practice, the SDK currently tries to restart from a "last good known position", but this may have large errors depending on how the tracking fails and what happens just prior to that. To be on the safe side, I would recommend to handle each contiguous sequence of poses in TRACKING states (after startup or a LOST state) as if the initial position and heading were arbitrary/random.


Custom DNS in container

Hi all!
if i start container from console  by
docker run --rm -it alukar/host /bin/bash
container@0407b52ac07c:~$ cat /etc/resolv.conf
search XXXX.org
nameserver 91.XX.XX.XX
nameserver 91.XX.XX.XX

And all ok for me
If i start contaner from panel  by Pterodactyl daemon i get this in resolv.conf/
I have no name!@container:~$ cat /etc/resolv.conf
search XXXX.org
nameserver <IP_ADDRESS>
options ndots:0

And container can't reslove any host . Pls help with this problem. I need use my custom dns server.
I think by default it use google dns . But my ddos protection are block it.

How did you set your DNS server to Docker?

@ET-Bent i try add my dns to /etc/docker/daemon.json
{
"dns": ["91.XX.XX.XX","91.XX.XX.XX"]
}
But Pterodactyl daemon start container with own rules

@ET-Bent
I change dns servers in
https://github.com/Pterodactyl/Daemon/blob/35d65b5eecf9361b0b2fba41868b92888385173b/src/controllers/docker.js#L391
and all start working for me.
But last problem how change dns in pterodactyl SFTP container ?
For futher may by you can add dns setting while installing deamon??

We also figured this issue out. Editing these lines https://github.com/Pterodactyl/Daemon/blob/43b0dea759527e152cc4eee86f1a6aa023d97fad/src/controllers/sftp.js#L102 and removing the sftp container + restarting the daemon lead to the expected behavior.
@schrej please close this ticket. RESOLVED

finde sftp and change it for me
https://github.com/Pterodactyl/Daemon/blob/43b0dea759527e152cc4eee86f1a6aa023d97fad/src/controllers/sftp.js#L102
thx  FlatronEZ from support in discord )

@alukar4eg as you opened the issue you can close it yourself btw ;)

IMHO it is a solution to modify the code itself... It would be nice to have a setting in Pterodactyl to specify custom DNS servers.

It appears that for most people this isn't an issue though.


[WIP] Run e2e tests using a VPN Tunnel

Description
Now, the connection between the actions runner and the AKS clusters is over a VPN tunnel using tailscale. To achieve that was required basically two main changes:

Our AKS cluster is now configured using a tailscale basic subnet router configuration (allowing action runner to call internal IPs directly)
The actions runner is connecting to tailscale using an Ephemeral Key (so that, when the actions runner finish its work, the node is basically discarded)
The app manager now exposes the app private IP rather than external loadbalancer one.

Issue reference
Please reference the issue this PR will close: #4962
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[x] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

I love that as a side effect to this, the tests are also quite a bit faster! Hopefully you can sort out the last hurdles :)

We have faced some limitations using tailscale related to the solution maintainability. Unfortunately, tailscale does not support an automatic way to rotate client keys, and the client keys has only 1-month expiry.
Things that we should consider when back to this in the future:

Auth Keys rotation
Only 1 subnet router is allowed for free plan
Cluster CIDR isolation (we should avoid using the same CIDR for parallel tests running)
ACL should be configured for the generate keys. Use autoApprovers feature (https://tailscale.com/kb/1018/acls/#auto-approvers-for-routes-and-exit-nodes)

I'm putting this PR on hold until we have a way to rotate auth keys.
issue

While this can't be merged yet as-is today because of a missing feature that we need in our CI, do you think you could split out the change to the workflow file and then we could merge this PR regardless?
Although that won't make our CI better yet, I for one would LOVE to have this as it makes running E2E tests manually (and developing them) much, much faster (just not having to wait for the load balancer would be awesome).
(PS: don't forget to add some docs here too please: https://github.com/dapr/dapr/blob/master/tests/docs/running-e2e-test.md )

@mcandeia why did you close this?


Parsing HTML with libxml2 and xpath

I'm interested in parsing HTML with libxml2, but the XML module doesn't currently support it. I would be happy to contribute the code to interface with the html functions from libxml2, but before I do, should it go under the HTML module or the XML module?
The HTML and XML interfaces share a lot and one could conceivably swap out xmlReadMemory for htmlReadMemory and be on their way (which I have done locally to make sure it works).
I'm open to suggestions on where to put this integration. Personally I'm on the side of adding a parseHTML method to the XML module and being done with it.

@ryanworl That would be a very welcome addition!
You mean parseHTML would return an XML::Node and you would interface to it just like you interface with an XML document? If so, I'd prefer this option.

@asterite That is correct. htmlReadMemory and xmlReadMemory have the same C function signature and the return value interoperates with the rest of the XML functions. This is how many HTML/XML parsing libraries are implemented in Swift and Objective-C, for example.
It would also make sense to create an XML::HTMLParserOptions enum to encapsulate the few differences from XML::ParserOptions.

@ryanworl Sounds good :-)

Fixed by #1244


Added template save auto select functionality

Hey! can you describe how i would go about testing this? I'm not even exactly sure what button clicks i'd need to do to engage this feature :P

LGTM :D


Initial spike for object store

This follows on from https://github.com/alphagov/whitehall/pull/9063 to add the initial scaffolding for an object store in Whitehall, which will allow us to manage reusable blocks of content.
An item for an object store is an editionable object which inherits from the root Edition model. We did look at defining a smaller subset of code that would make a model editionable, but this turned out to be too much of a rabbit hole.
Items can have a shape which is defined in config, for now we're having one content type, an email address, but going forward, we will want many different types of object. Ideally, we'd also like these content types to be defined by non-developers.
I've added a very basic create/edit flow for items too (which will need iteration, both for design and functionality), but this gives us a good idea of how this will all fit together, as well as highlighting the changes that need to be made upstream for us to send content to the Publishing API.

@ryanb-gds Thanks for the feedback I did give the idea of a "Lite Edition" a go in the previous PR, but I was concerned that it was going to eat up too much time and risk impacting the wider team too much, as there's a ton of moving parts in the concerns that make assumptions about the shape of the inheriting model.
Part of my thinking re: JSON columns was to give flexibility to create new content types on the fly. I did consider using the Publishing API schemas to define the types, but I was actually thinking about making the schemas on the Publishing API less strict, so an "Object Store Item" schema could, in effect accept any shape / size of object.
Would be good to have a bit more of a detailed chat about all of this, there's definitely some interesting stuff in that ADR we could adapt too.

@pezholio Great to see LiteEdition emerging 🎉
It's difficult for me to see and feel confident that we've drawn the lines of responsibility right.
Are we the first to have the need for a LiteEdition? I'm thinking that if any part of the codebase has needed something similar in the past it might be an idea to compare their needs and review what we've got.
If we're setting the path and the concept is agreed on then I wonder if a next step could be to move this set of changes into a Whitehall fork so that we can take it forward at pace. I think it would be good to test this theory out and be able to tweak it without having to overly worry about all the considerations of merging it into main. Once we've proved LiteEdition works and we've got a reasonable boundary we could make a clearer proposition? I'm assuming we can do a meaningful test with a local set up that has all parts of the stack we need?

Closing in favour of https://github.com/alphagov/whitehall/pull/9204


Fix some issues found through linting

Mostly:

Close http bodies (otherwise connctions are leaked)
Remove unusued function parameters
Remove unneccesary conversions
Remove deadcode

This change shouldn't result in any change in behavior other than not
leaking connections anymore.

/lgtm


Allow Python 3.6 usage.

Python 3.6 is still widely deployed. RHEL 8 and its derivatives (CentOS 8 being the one which brings me here), is still supported in its "stream" flavour until the end of May 2024. Allowing this library to be used with a slightly older python would be quite helpful.

Thanks for the quick merge, and especially thanks for the point release!


osiris crashing at injection

im using csghost as injector

Uid issue. Please close this issue.

Uid issue. Please close this issue.

ah yes


Add benchmarks for object unions

Local run:

[snip other benchmarks]
z.union: double: valid: a x 1,782,636 ops/sec ±0.29% (94 runs sampled)
z.union: double: valid: b x 376,857 ops/sec ±5.40% (88 runs sampled)
z.union: double: invalid: null x 21,091 ops/sec ±1.87% (78 runs sampled)
z.union: double: invalid: wrong shape x 18,656 ops/sec ±1.97% (90 runs sampled)
z.union: many: valid: a x 1,519,189 ops/sec ±1.28% (88 runs sampled)
z.union: many: valid: c x 189,522 ops/sec ±5.15% (82 runs sampled)
z.union: many: invalid: null x 12,368 ops/sec ±1.46% (85 runs sampled)
z.union: many: invalid: wrong shape x 11,144 ops/sec ±2.35% (86 runs sampled)

Interesting that getting a miss on the first member of the union is so expensive, and seems to get more expensive the further "away" the correct member is from the first one.

I think we can/should(/I might take a swing at) do something similar to this suggestion: https://github.com/colinhacks/zod/issues/311#issuecomment-818266883
It'd be nice to be able to tell Zod which field was the discriminant so we didn't have to run the full schema parsing on each schema at runtime.


[fix](jdbc catalog) [fix](jdbc catalog) fix string type insert into odbc table

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.87 seconds
stream load tsv:          514 seconds loaded<PHONE_NUMBER>9 Bytes, about 138 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size:<PHONE_NUMBER>4 Bytes

run external


updated react-native-dotenv link

the react-native-dotenv repo has migrated from zetachang to goatandsheep

issue #2325

I've since signed the CLA. What do I need to do next?

@goatandsheep Will you work on the versioned docs files update or should I handle that?

Oh sorry one sec


added virtualenv dependency

trying to fix virtualenv dependency https://github.com/StackStorm/st2-packages/issues/50

LGTM, but lets also pin it to some known working version / set of versions.

just a moment... i want to add  st2-auth-backend-flat-file here as well...
I thought recent versions works fine. It'll be > 13.1, @Kami Do you have any specific suggestion?

>=13.1.2,<14.0 just in case :)

I'm fine to add this version specification. Maybe somebody else wants to draw a word... If not I'll add the above and merge it tomorrow.

Just FYI - this change (including virtualenv in top level requirements.txt) might some how breaking workroom.
For now I will remove it from top level requirements.txt (this shouldn't affect your changes), but we should try to dig in and find the root cause,

Hmm. @Kami I actually haven't added into top level reqs. It shouldn't be there. Where I've added it is fixed-requirements.txt. I'd like to add that it's added automatically when you regenerate requirements.

@dennybaa I know you haven't added it but we generate top-level requirements.txt from those component specific requirements inside our Makefile and include it in the repo.

@Kami we can easily  remove it from st2client if it's needed. Since there's no use for it until something is decided about refactoring to support STANDALONE components. Split packages can't be used until then anyway.

@dennybaa It's fine for now, #2332 solves it :)
But if we decide it it's not needed, then we should remove it, yes.


Chore: Add spanish translation file

Signed-off-by: chepew23<EMAIL_ADDRESS>

Thank you very much for that translation!  We're going to make more of the site available for translation later today


Implement various Math functions

This pull request implements various math functions.
Event Types
Copy Value From Variable
Copies value from variable B into variable A
Math Add
Adds value to variable
Math Subtract
Subtracts value from variable
Math Multiply
Multiplies variable by value
Math Divide
Divides variable by value
Math Modulo
Performs modulo on variable by value
Math Add Variable
Adds value from variable B to variable A
Math Subtract Variable
Subtracts variable A by value from variable B
Math Multiply Variable
Multiplies variable A by value from variable B
Math Divide Variable
Divides variable A by value from variable B
Math Modulo Variable
Performs modulo on variable A by value from variable B

Can you add comparisons, such as var1 =< var2 and so on?

@WAUthethird Yeah, I updated the PR now with a "If Variable Compare" event

Hi Thomas, was really hoping to get this one tested and merged today, from the little testing I managed to do it all seems to work great but without being able to see the values directly it was quite tedious (I was having to do If Value == 1 Display Text "One", If Value == 2 Display Text "Two" etc.) So I decided instead we needed #54 to be implemented to make this easier. Managed to get a bit of time today to implement that one which I've done in 4bc17c4169663e9bde372488c3671fa96c6f7390. So hopefully should get time to test this pull request and the other one you've submitted over the next day or two (it's my wedding anniversary tomorrow so probably shouldn't be doing too much on this!! :-D)

Great! Yeah, it should work. I testet it the same way as you described it. But have not been able to test it on other platforms yet. I have a working CircleCI config in my fork that I could PR to this repo if you like. That way you could always have up to date develop builds that you could link to.

This all worked great, I've added a project for testing each math event in 1f554ef2885536d19f30a846277b373efca537fa.


Wallet connect modal has different design according to Figma

Describe the bug
Wallet connect modal has different design in top part according to Figma
To Reproduce
Steps to reproduce the behavior:

Open a wallet without ETH acc
Click on wallet connect icon
Compare to Figma design
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: macOS
Browser:chrome
Version 127

Additional context
Add any other context about the problem here.

Figma: https://www.figma.com/design/3oGLWzSH0oJljo4RETZtur/Superhero-Wallet-UI-(✔Updated)?node-id=33084-205065&t=yjPI737bWSLmAZtC-4

@onvisions I would like to close this issue, because we don’t know what we are connecting to dapp at this stage, where the icon dapp will come from.
I propose to leave it as it is.

@onvisions please close the issue


Training on custom dataset loss is inf or nan

Hi! I'm retraining a ssd model using train_ssd.py. I tried both, the default mobilenet-ssd-v1 and vgg16-ssd networks. On both the Avg loss and Avg Regression loss is infinity or nan for many samples.
I tried the steps proposed in https://github.com/dusty-nv/jetson-inference/issues/814. There I noticed that some samples had a -1 Position. This is caused by voc_dataset, since it subtracts 1 from every coordinate. after I fixed that the loss wasn't nan anymore. Unfortunately it still is inf for most samples.

I tried different learning rates and batch sizes and freezing the base-net.

Hi @fschiegg, hmm, normally NaN or inf loss means that something is malformed/corrupt in your annotations - which you have found how to track down.  Assuming that isn't the case with your annotations, since you have already looked through them.  Is your dataset fairly straightforward, or does it have lots of bounding boxes per image, or perhaps overlapping or small bounding boxes?   Without taking a look, I'm not sure how to characterize it.
You may want to start with a "simplified" version of your dataset to see if you can characterize what it is about the training data that is leading to this issue.

Hi @dusty-nv . Thank you very much for your fast response! Indeed, the bounding boxes do often overlap. This didn't cause a problem when I trained a similar network in Tensorflow. Regarding the amount of boxes, usually there are around 2-10 bounding boxes per image (as far as I know thats a normal range).
I'll try to create a simplified case in order to isolate the problem and keep you posted on the issue.

I solved the problem. Indeed, there existed mislabeled samples. Single pixels were accidentally labeled. I guess that those small bounding boxes caused the error, since they have no area after the resizing process.
Thank you again @dusty-nv  for your help!


Lab 4 & 5 - Implementation numeronyms values and stringer interface

Fixes #67, fixes #70
Changes proposed in this PR:
Implement numeronyms and unit test
Make IPAddr type implement Stringer interface to print ipaddress

Codecov Report

Merging #95 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #95   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          14     16    +2
  Lines         202    227   +25
=====================================
+ Hits          202    227   +25

Impacted Files
Coverage Δ

04_numeronym/sksandani/main.go
100% <100%> (ø)

05_stringer/sksandani/main.go
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b64e3b8...1092fdf. Read the comment docs.

Hi,
There has been  no activity in the last 20 days so I will close this PR.
Feel free to open it again if you have something to add.
Thanks!
Julia


Neutral Tokens Not up to date with Figma

The neutral related tokens in our codebase is not synced with the corresponding value in Figma

tested & validated ✅  @acd02


Import the same sub ids

After creating the backup, how can we import the same sub ids when we restore to a new pool? It generates new sub ids when you restore.

As per the response from AWS Employee on this thread, sub is globally unique and hence is unique for user pool as well. Unlike username, which can be reassigned to another user in user pool, sub is never reassigned.
Hope this answers your question.


Review Ticket Week 7

I fixed all the errors in the programs and modified the burgers/ fries program
I made a submenu showing a Netflix top 10 movies API
I complete the cb MCQs

Graded by: Shreya Sapkal
Grade: 2.7+/3
Jiya deserves a 2.7+/3 for this week. Her code for the burger/fries program was concise but still did the work she wanted it to do. It takes real skill to be able to simplify code and still have it do the same job as it would if there were more lines. Jiya also helped her group members with API work, and picked her own API to make a submenu with. She made a group flask repository for us to do our group project on, showing her team spirit.

SSJN is project.  6 rubric completed.   Emotion 2 Songs.  Application to API.
Jiya - API element, top ten movies.  No parsing.  Similar loop on burgers and fries.  Has a blog for AP.  2.7
Shreya - Jupyter notebook.  Condition is hard coded.  Took API notes, added comments to code provided.  Tasty API, key values.  No blogging. 2.


Add missing usings

Fixes https://github.com/dotnet/docs-desktop/issues/1381

Do not merge until the question is answered in the related issue

@ShreyasJejurkar thank you for submitting the update, however, I don't think it's required. Cheers!


Contribute section instructions

I'm thinking that will be nice create a section in the README file with installation and requirements for people that want to contribute with the source code and maybe don't know everything about Jekyll and themes.
What do you think @WendellAdriel?

That's an awesome idea @akfzambrana. Do you want to write this section???

I can try 😸

Thank you very much @akfzambrana
Can I put this issue on in progress status?

I've seen some commits to finish this issue, though what is the status ? is it in progress ?

I don't know if @akfzambrana is writing this section. I think she is focused in some style enhancements. Wanna help us with this section too @marabesi ???

Hi, I'm not writing this section yet, sorry. If you want to do it @marabesi be our guest 😄

Is this ongoing? I can help :D


How do I round trip ron files preserving formatting and comments?

Are there Ron parsers for making automated edits to Ron files?
As far as I understand, whitespace-preserving parsing should be based on something other that Serde. Does Ron have some Ron-specific crate that goes beyond Serde's API?

Oh interesting! I'm not aware of anything like that, no.

I would also like to see a feature to modify ron files preserving the comments. (format would be nice-to-have).
One option would be to edit the file directly.
However preserving comments (but not format) would be possible by saving comments to in deserialize, and print them back on serialize.
This could allow config files with alternatives
{
   // supported: http, https, ftp
   "protocol": "http"
}

Could you tell more? What RON would you modify programmatically, and how, while preserving comments?

I contribute to a rust game called veloren (https://gitlab.com/veloren/veloren/)
We are storing our settings file with the help of RON format.
E.g.
$cat server_settings.ron
(
    gameserver_address: "<IP_ADDRESS>:14004",
    metrics_address: "<IP_ADDRESS>:14005",
    auth_server_address: Some("https://auth.veloren.net"),
    max_players: 100,
    world_seed: 59686,
    server_name: "Veloren Alpha aa",
    server_description: "dddd",
    start_time: 32400,
    admins: [

        "Pfau",
        "zesterer",
        "xMAC94x",
        "Timo",
        "Songtronix",
        "slipped",
        "Sharp",
        "Acrimon",
        "imbris",
        "YuriMomo",
        "Vechro",
        "AngelOnFira",
        "Nancok",
        "Qutrin",
        "Mckol",
        "Treeco",    ],
    map_file: None,
    persistence_db_dir: "saves",
    max_view_distance: Some(30),
    banned_words_files: [],
    max_player_group_size: 6,
    player_timeout: (
        secs: 2,
        nanos: 0,
    ),
)

now the user has the option to modify his settings during the game. e.g. by writing in the chat
/adminify foovar to add user foobar to the admin list.
When we add someone to the admin list we want to store this. so we are saving the information back to the file.
So we are reading and writing to our settings file.
In this process, all comments get lost.
However, it would be awsome, to allow comments.
E.g. we as developers, might want to put the default world_seed as a comment.
Or a user wants to temporarrily removes an admin from the list. but when he comments a person out, and restarts the game (and the file got saved again) the name is completly lost.

Interesting, thank you for the info!
I wonder how difficult this would be. Is there a precedent in other formats (JSON/YAML/TOML) based on Serde that would preserve the comments?

Yes: https://github.com/ordian/toml_edit

This crate allows you to parse and modify toml documents, while preserving comments, spaces* and relative order* or items.

I don't think it's using serde though.

Maybe like with cbor rewrite, RON should have two crates: low-level serde-independent and high-level serde-based?

A full rewrite on non-serde would also open up some possibilities, but that's a huge amount of work that we don't know how to allocate resources into. So this would unlikely happen until somebody motivated would do it.

I'd also really like to have this feature, also for modifying user-written config files.
Btw, is there something like serde that preserves whitespace & comments, that any format can piggyback on? If not, how hard would it be to write?
So that not every format crate has to reinvent the wheel..

One workaround I can think of, to get this feature with the current crates, (but with some overhead) is:

Use serde to parse, then serialize it again to string.
"zip" the original source with the re-serialized one, to generate a source map (containing spans, also keep comments)
edit the data
serialize the data to string
inverse apply the source map to the serialized string to restore original structure

Might be worth looking at Serde alternatives for this, such as https://github.com/dtolnay/miniserde and https://github.com/not-fl3/nanoserde

@kvark It looks like those 2 crates also don't preserve whitespace/comment information.

@Boscop sounds like a feasible workaround. it would be cool if there exist a procmacro/Serializer or at least an example coding for that :)

@xMAC94x I implemented this approach once, for my transpiler from Rust to "Rust with pythonic syntax" because I needed to have the exact spans of all tokens, to be able to generate a sourcemap, so that I could backtranslate the lines/columns of compilation errors back to lines/columns in the pythonic source code (in my cargo proxy).

Just to express interest in this old issue,  I want comments in the config file that explain what the specific option does. Ideally, it would just take the doc comments of the field and insert those into the serialized format. pretty much all existing crates like toml/yaml/json/xml parsers have atleast one issue asking for this. but it seems this is not happening as serde doesn't provide doc comments to the backend crates :(
having comments in the config file really helps users to be a little more daring and try out various options, so its a good thing to have imo. one of the core strengths of Rust is documentation of libraries. compared to older languages, documentation was part of the codebase for rust from early on and it makes sense for RON to consider it :)

but it seems this is not happening as serde doesn't provide doc comments to the backend crates :(

What if, to store data about comments and whitespace style, do one of:

Store things in adjacent "hidden" elements in parent dicts. This would allow editing them prior to serialisation;
Store things in root dictionary being serialized/deserialized. This would make attaching round-trippable deserialisation into exsting system easier, but less convenient for editing comments from code;
Make deserialization produce two things: main object and special metadata block that can be optionally used for serialisation to fine-tune it?

Bump. Still an issue. Also, serde independence (or ability to use something smaller) would be very welcome.

Given ron is designed to support all of serdes data model, and serde is a rust standard, I think serde independence is likely a bad idea, at least for the main parser (although an altnerate fork such as ron-noserde maybe, but as mentioned that is a lot of work).
I think the work around suggested by xMAC94x could be good! Though I highly suspect that a non-destructive serialisation would come with performance downsides, so it should be a feature that swaps the standard functions for a non-destructive set.

altnerate fork such as ron-noserde

Maybe it should be something like ron-lowlevel, which can be used directly (for tricky cases) or through ron facade (for basic use cases).

serde is a rust standard

Serde is something like "greatest common divisor" of all parsing formats - it allows swapping formats for simple cases, but when you need something tricky (human-editable files, super performance, support of somewhat incorrect files), you often skip Serde and work directly with a low-level library.
Each format being represented as a Serde library (if possible) is a good idea; formats being limited to what Serde can is not, even for formats which are directly inspired by Serde.

serde is a rust standard

Serde is something like "greatest common divisor" of all parsing formats - it allows swapping formats for simple cases, but when you need something tricky (human-editable files, super performance, support of somewhat incorrect files), you often skip Serde and work directly with a low-level library.
Each format being represented as a Serde library (if possible) is a good idea; formats being limited to what Serde can is not, even for formats which are directly inspired by Serde.

I think that's a good way to think about it. @torkleyy in the past put some work into a rewrite of ron that has its own AST parsing with more functionality and then uses that to also provide serde features. As we are trying to make ron more robust, in particular to enhance its Value type, I do think we'll end up somewhere in this direction. Especially since I've been working on fuzzing all of ron, including its interaction with serde attributes, I've realised just how much the current serde limitations also impact ron. While serde could be extended to fix most of these issues, now that impl trait in trait function return types is stable, this may take a while. Once I have some more time and energy to put into ron again (or if anyone wants to push this feature earlier), slowly transitioning towards a non-serde-driven parser might be a good direction to take.

altnerate fork such as ron-noserde

Maybe it should be something like ron-lowlevel, which can be used directly (for tricky cases) or through ron facade (for basic use cases), with ron depending on ron-lowlevel.

serde is a rust standard

Serde is something like "greatest common divisor" of all parsing formats - it allows swapping formats for simple cases, but when you need something tricky (human-editable files, super performance, support of somewhat incorrect files), you often skip Serde and work directly with a low-level library.
Each format being represented as a Serde library (if possible) is a good idea; formats being limited to what Serde can is not, even for formats which are directly inspired by Serde.

and

serde is a rust standard

Serde is something like "greatest common divisor" of all parsing formats - it allows swapping formats for simple cases, but when you need something tricky (human-editable files, super performance, support of somewhat incorrect files), you often skip Serde and work directly with a low-level library.
Each format being represented as a Serde library (if possible) is a good idea; formats being limited to what Serde can is not, even for formats which are directly inspired by Serde.

I think that's a good way to think about it. @torkleyy in the past put some work into a rewrite of ron that has its own AST parsing with more functionality and then uses that to also provide serde features. As we are trying to make ron more robust, in particular to enhance its Value type, I do think we'll end up somewhere in this direction. Especially since I've been working on fuzzing all of ron, including its interaction with serde attributes, I've realised just how much the current serde limitations also impact ron. While serde could be extended to fix most of these issues, now that impl trait in trait function return types is stable, this may take a while. Once I have some more time and energy to put into ron again (or if anyone wants to push this feature earlier), slowly transitioning towards a non-serde-driven parser might be a good direction to take.

I did not realise that, I thought serde did some of the heavier lifting for parts. As long as there is a simple serde interface I would have no problems of it being independent now that I know that. (Even though I see myself working with lowlevel-ron directory a considerable amount for non-destructive serialisation).

Bump


Linux distros to test

Linux kernels to test with:

[x] Ubuntu 20.04 (local)
[x] Bottle rocket EKS
[x] Amazon linux EKS
[ ] Amazon EKS Fargate
[ ] RedHat OpenShift
[ ] GKE

Regarding OpenShift (copied from internal message):
The 2 things were kernel compatibility and the presence/absence of certain Linux headers that needed to be mounted from the host which required rootlike access from the container.
- Red hat didn't have a new enough kernel. Updated that.
- Red hat's Linux kernel headers directory was different from all the managed k8s Linuxes so the deployment had to be adjusted.
- Openshift's ability to do rootlike things is diminished or blocked by policy in most open shift deployments that I encountered. These were at big financial companies and federal agencies so policy overrides usefulness more often than not.

Fargate does not allow NET_RAW capabilities so agent does not work there.

Note
Tasks launched on AWS Fargate only support adding the SYS_PTRACE kernel capability.

Tested to confirm using AWS Fargate in EKS 2023-09-28

Verified v0.0.19-alpha on GKE 1.27.3. You have to use a Standard cluster (as opposed to Autopilot), because enabling hostNetwork is not allowed in Autopilot.

Confirmed AKS works with @martinjt


Fails to compile

Hi,
I get the following error when trying to compile imageproc:
$ cargo build
   Compiling imageproc v0.1.0 (file:///Users/phi/Documents/workspace/rust-imageproc)
failed to run custom build command for `imageproc v0.1.0 (file:///Users/phi/Documents/workspace/rust-imageproc)`
Process didn't exit successfully: `/Users/phi/Documents/workspace/rust-imageproc/target/debug/build/imageproc-f73ade026b903961/build-script-build` (exit code: 101)
--- stdout
running: "make" "-j4"

--- stderr
make: *** No targets specified and no makefile found.  Stop.
thread '<main>' panicked at 'assertion failed: t!(cmd . status (  )).success()', build.rs:15

I have written a sobel convolution kernel and would like to submit a pull request for this but I'd like to test it before I do that.

It seems I forgot to call
git submodule update --init

I do seem to have trouble compiling FreeImage itself now. I am on OS X and have FreeImage installed via the package manager (homebrew). Is there any way I can avoid the compilation of FreeImage and use the installed version instead?

An alternative solution is to replace these lines in build.rs:
    run(Command::new(make())
        .arg("-j4")
        .current_dir("3rdparty/FreeImage"));
    run(Command::new("cp")
        .arg("3rdparty/FreeImage/Dist/libfreeimage.a")
        .arg(format!("{}/", out_dir)));

with these:
    run(Command::new("cp")
        .arg("/usr/local/Cellar/freeimage/3.17.0/lib/libfreeimage.a")
        .arg(format!("{}/", out_dir)));

depending on where freeimage is installed locally. This is the location homebrew installed it in.
With this change I was able to get imageproc to compile.


animation issue with different mocap data

Hi, I kept the same setting and test it with different mocap data. It ended up look like this. Do you know the possible reason?😅

Hi!
When changing the mocap there are some settings in the MMData that should be changed. That is, the animation with tpose,  the SkeletonToMecanim mapping, and from the images it looks like the Hips forward and up vectors should be updated as well. These vectors should be from the .bvh skeleton.
More information: https://jlpm22.github.io/motionmatching-docs/basics/animation_database/
Feel free to send me the .bvh file if you want me to take a look :)

Thanks for your kind response.😊 Below are the files I tested.
subject1_tpose.bvh.txt
walk1_subject1.bvh.txt

Hi!
When changing the mocap there are some settings in the MMData that should be changed. That is, the animation with tpose, the SkeletonToMecanim mapping, and from the images it looks like the Hips forward and up vectors should be updated as well. These vectors should be from the .bvh skeleton.
More information: https://jlpm22.github.io/motionmatching-docs/basics/animation_database/
Feel free to send me the .bvh file if you want me to take a look :)

Hi!
I think with this configuration, it should work! I just tried it:

Remember to click Generate Databases again!
I guess the problem was the definition of the local hips vectors. For the next version of the package, I'll try to make a process to automatically compute these vectors to facilitate the incorporation of new motion capture data :)
Let me know if it works or there are any further problems!

Thx It works! Wait for your wonderful work~


How to add Multi Mail Services Support?

Hello!
Thank you for your work!
Please tell me, How to add Multi Mail Services Support?

Hey,
What are you trying to do exactly ?

Hello! I apologize for the long answer. I was on a business trip.

I mean this function.


Crashed when input Chinese comments

Hey there, welcome to Github :) When posting issues, make sure you provide the error messages and plenty of detail (i.e. what plugin crashes? what characters?) so I can help you


An event listener for globalState changes.

For my current extension, I need to do fs.write() on sync data(globalState).
Current Solutions for that

Do fs.write() whenever my extension is activated. [Hurt performance]
Need to store two additional times globalState [local_update, global_update] (one with sync and another without sync) and compare those two on extension activation and do fs.write()

But it would be nice to have a globalState change event listener.

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Words' gender should be shown (when applicable)

In many languages (e.g. German, French) nouns are gendered and it's important to know which one applies to a given word.  This should be shown in the definition.  On the wiktionary website this is indicated by the f (feminine), m (masculine), and n (neuter) abbreviations being shown after the word.

Can you please link a couple Wiktionary pages for words in gendered languages?

Hi, I've looked into the API and this is currently not technically possible. I'll add it if the API improves.


Shift-Click blueprint to remove custom trade

Shift click with a blueprint on a villager to remove the custom trade corresponding to the blueprint form the villager if they have that custom trade.

Added with:

https://github.com/Reldeam/CustomVillagerTrades/commit/e70e95dedc4d8fc03944518e94f16120fa5aa2e3
https://github.com/Reldeam/CustomVillagerTrades/commit/1bea2b9a4ea68745fda10a83ab4e7a608d536a06


Preserve Indentation of Unwrapped Lines

Thanks for the wonderful library! :heart:
Issue
I ran into some unexpected behaviour recently when I was attempting to print a paragraph with some indentation in wrapping mode – TUI was stripping the leading whitespace from my lines.
I've since discovered that this is an intentional behaviour, but that leaves me unable to print a paragraph like this:
MW Word of the Day
*verb*
   1) to diffuse through or penetrate something
   2) to spread or diffuse through
   3) to pass through the pores or interstices of

Changes
In this PR, I simply disabled this behaviour, as I feel it's more predicable.
The above paragraph now wraps as follows:
MW Word of the Day
*verb*
   1) to diffuse through or
penetrate something
   2) to spread or diffuse
through
   3) to pass through the
pores or interstices of

Justification
Slightly funky? Perhaps, but much more predicable and arguably clearer than no indentation whatsoever.
Comparing to the current master TUI branch:
MW Word of the Day
*verb*
1) to diffuse through or
penetrate something
2) to spread or diffuse
through
3) to pass through the pores
or interstices of

The lack of indentation makes it hard to tell that those are distinct "bullet points". The user can always trim strings in their application, but can't re-add the spacing TUI strips.
Tests
I adapted one of the leading-space tests to test indentation is preserved, but the other two I removed. If you are curious, the output of the removed tests was:
---- widgets::reflow::test::line_composer_char_plus_lots_of_spaces stdout ----
thread 'widgets::reflow::test::line_composer_char_plus_lots_of_spaces' panicked at 'assertion failed: `(left == right)`
  left: `["a", "                    ", "                    ", "       "]`,
 right: `["a", ""]`', src/widgets/reflow.rs:401:9

---- widgets::reflow::test::line_composer_lots_of_spaces stdout ----
thread 'widgets::reflow::test::line_composer_lots_of_spaces' panicked at 'assertion failed: `(left == right)`
  left: `["                    ", "                    ", "                    ", "      "]`,
 right: `[""]`', src/widgets/reflow.rs:385:9

Are a load of lines filled by nothing but spaces useful? Probably not, but at least this gives the user the choice to keep or remove them. This new behaviour is also somewhat more in line with the LineTruncator which leaves the trailing whitespace.

Instead of removing the existing the existing behavior that might be still useful to some users, have you considered exposing this as an option on the composers ?

That's certainly something I could look into! Are you thinking some sort of builder method like .wrap()? Perhaps something like .trim()? If we do something like that, should the default behaviour be removing the whitespace or keeping it?
I'd be happy the try to find a middle-ground :)

Yeah adding a trim option is good idea. To preserve backward compatibility for now, I would suggest that trim be true by default, unless we see a lot of reports of people confused by this.

Sounds good! I'll add that to my schedule for tomorrow and will try to come up with something backwards compatible and clean :) Thanks for the pointers today!

Hey @fdehau ! I've given this some testing and it works for my application without any changes in the default behaviour – I just call  .trim_wrapped(false) on my Paragraph widget and everything works! I've also added a couple of new tests for this indentation preservation and all of the tests for the previous behaviour are still in there :)
Let me know what you think!

The changes and the tests look good. I'm just wondering if we could improve the API a bit further, I worry that having a distinct method on the widget will hurt the discoverability of this behavior. What do you think if we had the following:
struct Wrap {
  pub trim: bool
}

struct Paragraph {
   wrap: Option<Wrap>,
}

impl Paragraph {
  fn wrap(mut self, wrap: Wrap) -> Paragraph {
    self.wrap = Some(wrap);
    self
  }
}

so that it used like this:
// No wrapping
let p = Paragraph::default();
// Wrap but not trim
let p = Paragraph::default().wrap(Wrap { trim: false });
// Wrap and trim
let p = Paragraph::default().wrap(Wrap { trim: true });

My motivation is that when a user want wrapping in a paragraph, they are already aware of this option and have to look up what it does.
We could also add your bullet points example in the documentation as it helps visualize the difference very quickly.

Hi @fdehau !
I've thought over that proposed API and while I agree it would make the trim option much more visible, it seems to come at the cost of some breaking changes and ultimately more verbose code. While I obviously need this trim option, it seems like plenty of applications built on tui get by fine without needed to think about trimming on wrap. I think that all of those cases are still best suited by the default behaviour and might not need breaking changes.
Though I personally might prefer that the builder-style API is used, I'm open to giving this alternative struct-based API a shot if that's what you think is best.
We can certainly still include that documentation showing off the trim option with the example in this version as well; that might draw some additional attention to the feature.
Let me know what you think!

it seems to come at the cost of some breaking changes

This change will be included in a release that is likely to include a lot of breaking changes (though easy to fix). I wouldn't worry so much about that in this discussion. We could add a From<bool> implementation with a deprecation notice if we really want to avoid this. Plus I always include a migration guide in the changelog for each of those breaking changes.

and ultimately more verbose code

I don't really buy this from the end-user perspective:
.wrap(Wrap { trim : true })

vs
.wrap(true)
.trim_wrapped(true)

is about the same amount of characters and the both solutions are explicit enough.

While I obviously need this trim option, it seems like plenty of applications built on tui get by fine without needed to think about trimming on wrap

But that was exactly my point. I want to be 100% that people have seen this option and made a conscious choice. If the wrapping result is not the one they expected they already know that they have at least one option to tweak. Beside if the documentation is clear enough about the differences of the two behaviors, that will certainly make the library easier to use and reduce the chance of people asking questions which is always good from a maintainer point of view :).

We can certainly still include that documentation showing off the trim option with the example in this version as well; that might draw some additional attention to the feature.

If you could include that in code examples of the wrap method it would be awesome.

Hi @fdehau ! You bring up some very good points, and I'd be happy either way, so I think I'll re-implement it tomorrow using the API you've proposed! I'll try to find a place for that example as well :smile:

Hey @fdehau !
I've moved to the API you proposed and have added some documentation for the Wrap struct, showing the effect it has on indented text.
Let me know what you think!

This looks good. Some conflicts to resolve and we will be good to go =).

Haha, darn! I almost snuck ahead of that other PR. Things should be rebased now :)


Added additional package details for RPiOS Lite

Hi - first of all, thanks for developing an awesome sensor! I've tweaked your RasPi documentation slightly to list the additional packages that need to be installed if you use the cut-down RasPi OS "Lite" distro - I've connected my sensors to a set of Pi Zero W's so don't need the rest of the "full-fat" RasPi distro, which I suspect may be true for many potential users of these.

Thanks very much. We are preparing a big update to the repository so will include this with it.


Remove old package versions from published repository

Doing a date-based removal (e.g. keep versions from the last 2 weeks) is not trivial since the mtimes of published files can be arbitrary (they follow the timestamp= field defined in the recipes, to ensure build reproducibility). I think I’ll simply remove all versions except the most recent one, which should not cause problems if people update before upgrade-ing, and even less so since stable will move more slowly than testing.


fix #1450 aria.utils.Date._interpretAgainstPattern has changed to face any pattern

:ok: e25687f4257adba283821ae61f262d24947cd4ab seems fine for me

f6c8ca0 change a function name for a better understanding


Also delete system blobs from the unpublishedpremiumstore.

We were only deleting blobs from the images directory, which was
pretty good, but the system directory wound up filling up our quota.
This change deletes from both directories.

LGTM


Add emoji/new line at cursor position

Describe the bug
It would be nice to add the selected emoji from the picker at the position of the cursor.
I have just tested it on my mobile chrome browser, it will always add the emoji at the end of the text.
The same applies to the return key(new line) which is always added to the end of the message text.
Steps to reproduce

Go to demo page on a mobile phone
Enter text and move cursor into text
Open emoji picker and select one
Emoji will be added to the end of the text

Device (please complete the following information)

OS: [android]
Browser: [Chrome 107]
Package version: [2.0.4]

Hi @NINI1988 @antoine92190 !! :)
Can you let me know if this problem is fixed please? Because in version 2.0.7, the bug still happens.
Thanks.


Downloading movie from YouTube gives "Failed to download MPD manifest" and 404; movie does not play

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.11.23. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2018.11.23

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'https://www.youtube.com/watch?v=5T_CqqjOPDc']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.11.23
[debug] Python version 2.7.15+ (CPython) - Linux-4.18.0-2-amd64-x86_64-with-debian-buster-sid
[debug] exe versions: ffmpeg 4.0.3-1, ffprobe 4.0.3-1
[debug] Proxy map: {}
[youtube] 5T_CqqjOPDc: Downloading webpage
[youtube] 5T_CqqjOPDc: Downloading embed webpage
[youtube] 5T_CqqjOPDc: Refetching age-gated info webpage
[youtube] 5T_CqqjOPDc: Downloading MPD manifest
WARNING: [youtube] 5T_CqqjOPDc: Skipping DASH manifest: ExtractorError(u'Failed to download MPD manifest: HTTP Error 404: Not Found (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.',)
...

Description of your issue, suggested solution and other information
YouTube recently made various movies available for free. For instance, https://www.youtube.com/watch?v=5T_CqqjOPDc . Attempting to download that with youtube-dl produces the above output, and the resulting downloaded file seems corrupted after the initial opening logo.

That's a rather opaque bug closure. Could you elaborate, please?
Is this something youtube-dl can't fix? Or is there some other issue about this that I didn't find?

Nope, no other issue yet as far as I know. You came to the right spot.
Will or can it be fixed? Good question. I don't know, depends on the DRM used or how it is implemented (Is it Widevine?).
But this feature (full movies) is still very new on YT, right? Not surprising that they use a new mechanism here.

How would that make it not a bug?
Is this report covered by #1774?

Ditto. I was trying to download a few videos from https://www.youtube.com/playlist?list=PLHPTxTxtC0ibVZrT2_WKWUl2SAxsKuKwx. :(