Generate and review validation reports: Nuxeo UCM UCCE (repository #238)

Step 2: Generate reports

[x] Generate validation reports (run validate_by_mapper DAG): https://7a8067cb-3b99-477e-a883-7e311175a9b4.c3.us-west-2.airflow.amazonaws.com/dags/validate_by_mapper_type/grid?dag_run_id=manual__2024-01-18T21%3A02%3A51%2B00%3A00
[x] Add a comment (in this issue) to the output URLs
[x] Download the validation reports locally; prepend the collection registry number to the filename
[x] Upload validation reports to the Rikolti Data Validation folder

Step 3: Review reports

[x] Review sample collections validation reports; leave notes in the spreadsheet
[x] Quickly (and not very deeply) scan through other validation reports (to identify if any new metadata fields surface)
[x] Synthesize notes at the mapper level
[x] Share an update (and surface any anomalies) during a weekly check-in (Mondays at 3:00pm)

Step 4: Have data validation issues? Address & resolve validation issues (synthesized mapper-level):

[ ] Create a new issue (“Validation results: Rikolti mapper name“) and report/request fixes & investigations. Add to current sprint.
[ ] Add a comment to link to the new “validation results” issue.
[ ] Add a “blocked/paused” label to this issue. Include a status note in this issue title (e,g., HOLD for fixes; HOLD for code review; etc.)
[ ] Move this issue back to the “To Do” pile.
[ ] Reset tasks listed in steps 2-3 above; re-generate & re-review (repeat steps 2-3 above, as needed.)

Step 5: Have acceptable validation reports?

[x] Move the valid (accepted) reports to the “VALID” folder in google drive.

[2024-01-19, 00:16:31 UTC] {{logging_mixin.py:150}} INFO - Download validation report at: https://rikolti-data.s3.amazonaws.com/27012/vernacular_metadata_2024-01-18T21:03:06/mapped_metadata_2024-01-18T23:31:22/validation_2024-01-19T00:00:26.csv
[2024-01-19, 00:16:31 UTC] {{logging_mixin.py:150}} INFO - Review collection data at: https://rikolti-data.s3.us-west-2.amazonaws.com/index.html#27012/vernacular_metadata_2024-01-18T21:03:06/mapped_metadata_2024-01-18T23:31:22/data/
[2024-01-19, 00:16:31 UTC] {{logging_mixin.py:150}} INFO - Download validation report at: https://rikolti-data.s3.amazonaws.com/27013/vernacular_metadata_2024-01-18T21:26:06/mapped_metadata_2024-01-18T23:34:31/validation_2024-01-19T00:02:28.csv
[2024-01-19, 00:16:31 UTC] {{logging_mixin.py:150}} INFO - Review collection data at: https://rikolti-data.s3.us-west-2.amazonaws.com/index.html#27013/vernacular_metadata_2024-01-18T21:26:06/mapped_metadata_2024-01-18T23:34:31/data/
[2024-01-19, 00:16:31 UTC] {{logging_mixin.py:150}} INFO - Download validation report at: https://rikolti-data.s3.amazonaws.com/27014/vernacular_metadata_2024-01-18T21:40:10/mapped_metadata_2024-01-18T23:37:27/validation_2024-01-19T00:04:34.csv
[2024-01-19, 00:16:31 UTC] {{logging_mixin.py:150}} INFO - Review collection data at: https://rikolti-data.s3.us-west-2.amazonaws.com/index.html#27014/vernacular_metadata_2024-01-18T21:40:10/mapped_metadata_2024-01-18T23:37:27/data/
[2024-01-19, 00:16:31 UTC] {{logging_mixin.py:150}} INFO - Download validation report at: https://rikolti-data.s3.amazonaws.com/23389/vernacular_metadata_2024-01-18T21:53:28/mapped_metadata_2024-01-18T23:40:19/validation_2024-01-19T00:06:45.csv
[2024-01-19, 00:16:31 UTC] {{logging_mixin.py:150}} INFO - Review collection data at: https://rikolti-data.s3.us-west-2.amazonaws.com/index.html#23389/vernacular_metadata_2024-01-18T21:53:28/mapped_metadata_2024-01-18T23:40:19/data/
[2024-01-19, 00:16:31 UTC] {{logging_mixin.py:150}} INFO - Download validation report at: https://rikolti-data.s3.amazonaws.com/27428/vernacular_metadata_2024-01-18T22:12:28/mapped_metadata_2024-01-18T23:43:44/validation_2024-01-19T00:08:28.csv
[2024-01-19, 00:16:31 UTC] {{logging_mixin.py:150}} INFO - Review collection data at: https://rikolti-data.s3.us-west-2.amazonaws.com/index.html#27428/vernacular_metadata_2024-01-18T22:12:28/mapped_metadata_2024-01-18T23:43:44/data/
[2024-01-19, 00:16:31 UTC] {{logging_mixin.py:150}} INFO - Download validation report at: https://rikolti-data.s3.amazonaws.com/27754/vernacular_metadata_2024-01-18T22:22:23/mapped_metadata_2024-01-18T23:46:27/validation_2024-01-19T00:08:38.csv
[2024-01-19, 00:16:31 UTC] {{logging_mixin.py:150}} INFO - Review collection data at: https://rikolti-data.s3.us-west-2.amazonaws.com/index.html#27754/vernacular_metadata_2024-01-18T22:22:23/mapped_metadata_2024-01-18T23:46:27/data/
[2024-01-19, 00:16:31 UTC] {{logging_mixin.py:150}} INFO - Download validation report at: https://rikolti-data.s3.amazonaws.com/27767/vernacular_metadata_2024-01-18T22:24:44/mapped_metadata_2024-01-18T23:46:42/validation_2024-01-19T00:10:42.csv
[2024-01-19, 00:16:31 UTC] {{logging_mixin.py:150}} INFO - Review collection data at: https://rikolti-data.s3.us-west-2.amazonaws.com/index.html#27767/vernacular_metadata_2024-01-18T22:24:44/mapped_metadata_2024-01-18T23:46:42/data/
[2024-01-19, 00:16:31 UTC] {{logging_mixin.py:150}} INFO - Download validation report at: https://rikolti-data.s3.amazonaws.com/27803/vernacular_metadata_2024-01-18T22:46:51/mapped_metadata_2024-01-18T23:49:37/validation_2024-01-19T00:11:44.csv
[2024-01-19, 00:16:31 UTC] {{logging_mixin.py:150}} INFO - Review collection data at: https://rikolti-data.s3.us-west-2.amazonaws.com/index.html#27803/vernacular_metadata_2024-01-18T22:46:51/mapped_metadata_2024-01-18T23:49:37/data/
[2024-01-19, 00:16:31 UTC] {{logging_mixin.py:150}} INFO - Download validation report at: https://rikolti-data.s3.amazonaws.com/27809/vernacular_metadata_2024-01-18T22:52:59/mapped_metadata_2024-01-18T23:51:17/validation_2024-01-19T00:13:51.csv
[2024-01-19, 00:16:31 UTC] {{logging_mixin.py:150}} INFO - Review collection data at: https://rikolti-data.s3.us-west-2.amazonaws.com/index.html#27809/vernacular_metadata_2024-01-18T22:52:59/mapped_metadata_2024-01-18T23:51:17/data/
[2024-01-19, 00:16:31 UTC] {{logging_mixin.py:150}} INFO - Download validation report at: https://rikolti-data.s3.amazonaws.com/27812/vernacular_metadata_2024-01-18T23:10:00/mapped_metadata_2024-01-18T23:54:05/validation_2024-01-19T00:14:52.csv
[2024-01-19, 00:16:31 UTC] {{logging_mixin.py:150}} INFO - Review collection data at: https://rikolti-data.s3.us-west-2.amazonaws.com/index.html#27812/vernacular_metadata_2024-01-18T23:10:00/mapped_metadata_2024-01-18T23:54:05/data/
[2024-01-19, 00:16:31 UTC] {{logging_mixin.py:150}} INFO - Download validation report at: https://rikolti-data.s3.amazonaws.com/27831/vernacular_metadata_2024-01-18T23:23:37/mapped_metadata_2024-01-18T23:55:48/validation_2024-01-19T00:15:01.csv
[2024-01-19, 00:16:31 UTC] {{logging_mixin.py:150}} INFO - Review collection data at: https://rikolti-data.s3.us-west-2.amazonaws.com/index.html#27831/vernacular_metadata_2024-01-18T23:23:37/mapped_metadata_2024-01-18T23:55:48/data/
[2024-01-19, 00:16:31 UTC] {{logging_mixin.py:150}} INFO - Download validation report at: https://rikolti-data.s3.amazonaws.com/27839/vernacular_metadata_2024-01-18T23:25:15/mapped_metadata_2024-01-18T23:56:05/validation_2024-01-19T00:16:19.csv
[2024-01-19, 00:16:31 UTC] {{logging_mixin.py:150}} INFO - Review collection data at: https://rikolti-data.s3.us-west-2.amazonaws.com/index.html#27839/vernacular_metadata_2024-01-18T23:25:15/mapped_metadata_2024-01-18T23:56:05/data/
[2024-01-19, 00:16:31 UTC] {{logging_mixin.py:150}} INFO - Download validation report at: https://rikolti-data.s3.amazonaws.com/27851/vernacular_metadata_2024-01-18T23:30:37/mapped_metadata_2024-01-18T23:57:53/validation_2024-01-19T00:16:31.csv
[2024-01-19, 00:16:31 UTC] {{logging_mixin.py:150}} INFO - Review collection data at: https://rikolti-data.s3.us-west-2.amazonaws.com/index.html#27851/vernacular_metadata_2024-01-18T23:30:37/mapped_metadata_2024-01-18T23:57:53/data/

Validation reports (2024-01-31): https://drive.google.com/drive/u/0/folders/1o8CoCgYLL69K5SDJ0xQhgcNZ6igNK317

Spot checked, not seeing any issues

Accepted on 2024-02-05!


Chapter 16: issue with animation

I noticed that as using "%matplotlib nbagg" in chapter 16, I am not able to see images and animation. While the images are saved in the directory but now shown in the notebook, animation is not working.
An error is shown: Javascript Error: IPython is not defined
I tried replacing "%matplotlib nbagg" with "%matplotlib inline". This solves the problem with the image visualization, but the animation obviously does not work and visualizes only one frame. Any help?

Hi @marco82ger ,
Thanks for your feedback, I'll check that.  FYI, I also ran into some issues sometimes when using nbagg: if I ran the whole notebook in one shot, it would reach a cell that would perform some animation before the previous animation had finished, and it then sometimes it would actually display the new animation in the previous cell's output, giving the impression that nothing worked (but the animation actually worked, it was just in the wrong cell output). However, it always worked for me if I just went through the notebook cell per cell, giving each animation the time to finish (that said, I wonder if I didn't have to explicitly close the previous animation sometimes). Could you please try that? If it does not work, it might be a new Matplotlib bug.

Hi @ageron ,
thanks always for your reply. If I run the notebook cell by cell, already when I plot just the image MsPacman (cell 7) I get "Javascript Error: IPython is not defined"
I have Jupyter Version 0.35.4
Python 3.7.2
I looked on stackoverflow but probably I am searching in the right direction.
thanks

Perhaps try updating Jupyter and matplotlib to the latest versions:
pip3 install -U jupyter matplotlib

Running pip3 freeze, you should see (among other packages):
jupyter==1.0.0
jupyter-client==5.2.4
jupyter-console==6.0.0
jupyter-core==4.4.0
matplotlib==3.0.3

Thanks, I have now all updated versions as you suggest, except for Matplotlib that I am having some trouble to upgrade in the virtual env.
matplotlib==3.0.2
and when trying to upgrade, I get

Will not install to the user site because it will lack sys.path precedence to matplotlib

Still not working. I will try to fix this issue with matplotlib and let you know.
Thanks anyway

I had the same issue while trying to run the notebook on Google Colab.
I found a solution in this medium article: Making animations work in Google Colaboratory
In short:
from matplotlib import rc
rc('animation', html='jshtml')

video = plot_animation(frames)  #original line in notebook
video

Renders a nice video player with play-pause button...

That's really nice, I'll update the notebook, thanks @cyildiz !


Updated the utils.init and documentation

utils.__init__ has not been updated to include all of the new utils functions that users will commonly used.
Adding these functions to the __init__ should make the imports shorter and easier to remember for users.
In addition, we can update the documentation to use these shorter links

It seems like the circular imports makes this too difficult to practically achieve


[WWB]: Add support for text-to-text GenAI pipelines

Test is failed due to the known issue "packages/openvino_genai/libopenvino_tokenizers.so: cannot open shared object file: No such file or directory"

Test is failed due to the known issue "packages/openvino_genai/libopenvino_tokenizers.so: cannot open shared object file: No such file or directory"

Do we have a ticket for it? I have not seen such issue

Test is failed due to the known issue "packages/openvino_genai/libopenvino_tokenizers.so: cannot open shared object file: No such file or directory"

Do we have a ticket for it? I have not seen such issue

I am not sure if the issue is filled already but we discussed this recently in the chat. One of the reasons why the issue is observed here is that nightly packages are used in WWB tests.


[AutoPR eventgrid/data-plane] EventGrid data spec for Microsoft.Devices/Iothub

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/2424

Codecov Report

Merging #1904 into restapi_auto_eventgrid/data-plane will increase coverage by <.01%.
The diff coverage is 54.05%.

@@                          Coverage Diff                          @@
##           restapi_auto_eventgrid/data-plane    #1904      +/-   ##
=====================================================================
+ Coverage                               52.9%    52.9%   +<.01%
=====================================================================
  Files                                   4698     4714      +16
  Lines                                 116020   116168     +148
=====================================================================
+ Hits                                   61383    61463      +80
- Misses                                 54637    54705      +68

Impacted Files
Coverage Δ

azure-eventgrid/azure/eventgrid/models/__init__.py
100% <100%> (ø)
:arrow_up:

...d/models/iot_hub_device_created_event_data_twin.py
25% <25%> (ø)

...d/models/iot_hub_device_deleted_event_data_twin.py
25% <25%> (ø)

...ntgrid/models/iot_hub_device_deleted_event_data.py
40% <40%> (ø)

...ntgrid/models/iot_hub_device_created_event_data.py
40% <40%> (ø)

...vice_created_event_data_twin_properties_desired.py
57.14% <57.14%> (ø)

...ice_created_event_data_twin_properties_reported.py
57.14% <57.14%> (ø)

...t_hub_device_created_event_data_twin_properties.py
57.14% <57.14%> (ø)

..._device_created_event_data_twin_x509_thumbprint.py
57.14% <57.14%> (ø)

..._device_deleted_event_data_twin_x509_thumbprint.py
57.14% <57.14%> (ø)

... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0f1bbb...95dae39. Read the comment docs.


Best Way (any way) to Render from string/path

I've been using the library to get the HTML. I'd pass the path to the slice and a model to a method and return the HTML (for the body of an email). The methods s looked like (this is part of a bigger library):
public async Task<string> GetHtml<T>(string pathToView, T model)
{
     var html = await (RazorSlice.Create(pathToView, model)).RenderAsync();
     return html;
}

The changes seem to indicate that the only way to do it now is:
var razorSlice = MyProject.Slices.MyCoolView.Create(model);

But you have to know the type a compile time. It seems there's no longer an option of a string to find the slice. What's the best way to do the same with the changes If we don't know the type at compile time? Maybe I missed an extension method or other method.
Perhaps Activator.Create or some way using something like GetHtml<TSlice, TModel>(....) but I haven't figured that one out yet.
Is there a prescribed way to do this?

The new version went wholesale on source generators and optimizing to support trimming and native AOT. As such, the old approach was completely replaced by the new approach. That said, I could introduce a new way to get a slice instance via its path by code generating a type/method with a big switch statement in it that news up and returns the relevant slice instance for the path passed.
I just need to decide the API shape as there isn't a natural place to generate such an API too. The usual approach for this type of thing in the world of source generators is to make users declare a partial class (that may or may not derive from a base class depending on the needs of the generated code) and is decorated with some marker attribute and then have the source generator generate the other part of that partial. The advantage of this approach is that it leaves the issue of what to call and where to put this class (from an assembly, namespace, visibility, and name point of view) to the consumer.
So, imagine something like this in your project:
namespace MyApp;

// You can name this class whatever you like
[RazorSliceFactory]
public static partial class SliceFactory { }

Would end up with something like the following being generated by the Razor Slices generator:
namespace MyApp;

public static partial class SliceFactory
{
    public static bool TryCreateSlice(string path, [NotNullWhen(true)] out RazorSlice? slice)
    {
        slice = CreateSliceImpl(path);
        return slice != null;
    }

    public static bool TryCreateSlice<TModel>(string path, TModel model, [NotNullWhen(true)] out RazorSlice<TModel>? slice)
    {
        slice = CreateSliceImpl(path, model);
        return slice != null;
    }

    public static RazorSlice CreateSlice(string path)
    {
        return CreateSliceImpl(path) ?? throw new SliceNotFoundException($"Razor Slice with path '{path}' could not be found.");
    }

    public static RazorSlice<TModel> CreateSlice<TModel>(string path, TModel model)
    {
        return CreateSliceImpl(path, model) ?? throw new SliceNotFoundException($"Razor Slice with path '{path}' and model type {typeof(TModel)} could not be found.");
    }

    public static IEnumerable<string> AllSlicePaths { get;} = ["/Foo.cshtml"];

    private static RazorSlice<TModel>? CreateSliceImpl<TModel>(string path, TModel? model = null)
    {
        // TODO: Need to figure out case-sensitivity, leading slash, etc.
        return path switch
        {
            "/Foo.cshtml" => model is FooModel m ? MyApp.Slices.Foo.Create(m) : null,
            "/Bar.cshtml" => model is null ? MyApp.Slices.Bar.Create() : null,
            "/Foo/Bar/Index.cshtml" => model is IndexModel m ? MyApp.Slices.Foo.Bar.Index.Create(m) : null,
            _ => null
        };
    }
}

Then you could use it like this in your original example:
public async Task<string> GetHtml<T>(string pathToView, T model)
{
     var html = await (MyApp.SliceFactory.CreateSlice(pathToView, model)).RenderAsync();
     return html;
}

That makes a lot of sense and so does the proposal. At the same time, I wonder if it's better to get away from magic strings altogether (the paths).
Since the views are inheriting from RazorSlice or RazorSliceHttpResult anyway, perhaps that gets passed in to the library and take it from there, or just get the html outside of the library and send in the generated HTML. This also allows for better compile time safety.
I think the time is better spent on other features since this just takes a change of how one thinks about these things. I'm going to close this as not needed, unless you feel it's worth tracking.


The addition of plotly breaks nix-shell on macOS.

The addition of plotly breaks nix-shell on macOS.
There seems to be a problem with iconv. The linker does not find the library when building R (r-hexbin). Here is a log file: nix-shell.log
Quick fix: remove plotly from shell.nix.
Upgrading to R-4.0.0 may fix everything on MacOs.
I have tried using this fix, but it failed to work.

Proposed workaround: just only add it to the shell if the platform is linux, so it works for Simon at least. Include an note that it'll be fixed when we upgrade to 20.09 if we still care.


[user-story]: Download of table description/definition

What user story would you like to add?
As a (Data)Administrator, I want to be able to download a copy of my table definitions in the same format that I completed it in, so that I can edit it offline.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

As described in the next user story, it would be good if we had an option for people to upload a definition straight to Seedcase, bypassing the whole 'upload and analyse the csv' step.

We decided to start the web app from scratch after the major design/architecture decisions and changes we made. No longer relevant.


Can't test lambda deployment from AWS Console test

Right now the lambda deployment only takes triggers from HTTP request. This makes it hard if we want to test within the aws console lambda.  Throws the following error.
{
  "errorMessage": "Error: Unexpected Lambda event data received. Currently BentoML lambda deployment can only handle event triggered by HTTP request from Application Load Balancer.",
  "errorType": "RuntimeError",
  "requestId": "f7659e4f-1e39-44a4-88f4-bdc2ab1d2f26",
  "stackTrace": [
    "  File \"/home/bentoml/bundle/app.py\", line 43, in api_func\n    raise RuntimeError(error_msg)\n"
  ]
}

The alternative is to test it with the API Gateway console or locally. Make sure to have the proper headers

Another minor change is providing automatic handling when clear an existing deployable folder. Most of the time, when experimenting with the deployment template, if an existing deployable is present in the location, the scrip throws and error and exists
    os.makedirs(dst, exist_ok=dirs_exist_ok)
  File "/home/jjmachan/miniconda3/envs/bento-dev/lib/python3.8/os.py", line 223, in makedirs
    mkdir(name, mode)
FileExistsError: [Errno 17] File exists: './IrisClassifier-20210803234622_65F4F4-azure-deployable'

This can be improved by providing a prompt for the user to delete the existing folder and overriding it with the new deployable. Since deployables are easily replicable provided a bentoml version this should have not a lot of chances for accidental deletions.


Timeout not working as expected

client = await emcache.create_client(
    [node], autobatching=True,autobatching_max_keys=128, min_connections=0, max_connections=32
)

        import time
        t = time.time()
        try:
          async with asyncio.timeout(3):
            item = await client.gets(key, return_flags=return_flags)
        except asyncio.TimeoutError:
            print(time.time() -t, ' seconds elapsed')
            print('timeout mc key: ', key)
            mg=client.cluster_managment()
            print(mg.unhealthy_nodes())
            print(mg.connection_pool_metrics())

The client is supposed to have the default timeout of 1 second. However the exception is raised after 3 seconds.
3.001142740249634  seconds elapsed
timeout mc key:  b'..'
[]
{MemcachedHostAddress(address='mc276', port=11211): ConnectionPoolMetrics(cur_connections=1, connections_created=1, connections_created_with_error=0, connections_purged=0, connections_closed=0, operations_executed=16, operations_executed_with_error=0, operations_waited=1, create_connection_avg=0.0011269636452198029, create_connection_p50=0.0011269636452198029, create_connection_p99=0.0011269636452198029, create_connection_upper=0.0011269636452198029)}

Also, the connetion time is fast and the key is not large. It looks like a deadlock somewhere in emcache.

This is Python 3.11 and all usage of OpTimeout is already replaced by asyncio.timeout as suggested in #105.

Does this happen when you are not using autobatching? if not this might indicate a bug with the autobatching feature. I would need to debug and fix the issue, but I have limited time. Is there any chance that you could dig more into it and check what could be the reason on not having the timeout being raised?

@pfreixes Sorry, closing this.
We quickly migrated to aiomcache and found out-of-open-file logs, increased the limit, and there has been no timeout anymore.
However we didn't manage to go back to emcache and confirm again with emcache + increased nofile limit.


feat: Generate C header file for prql-lib

The C header file libprql_lib.h was generated using cbindgen.
To generate a new one run:
cargo install --force cbindgen
cbindgen --crate prql-lib --output libprql_lib.h

Closes #1858

Great, thanks @vanillajonathan !
I don't have much context on this and possibly it's difficult to add tests? @aljazerzen does it look reasonable to you?

Yeah, I wouldn't know how to test it. But when the API of library gets changed then header file needs to be regenerated using the command mentioned above.

Yeah, I wouldn't know how to test it. But when the API of library gets changed then header file needs to be regenerated using the command mentioned above.

I guess one test would be running the cbindgen command and ensuring that didn't fail?
But if someone like @aljazerzen says it looks good, we can merge, I don't want to slow us down.

Just putting this out: https://github.com/PRQL/demo-c-program
We may want to include this in the main repo and run it in some test.

Good demo C program!
Yeah, we might also want to generate C++ headers.

@vanillajonathan thank you for the contribution! We appreciate your dedication and patience with these PRs.
You may also want to add these as entries in the CHANGELOG.md, so folks know about them, and you have your name in the repo.


fix: requirements.txt to reduce vulnerabilities

:warning: Note on feature completeness :warning:
We are narrowing the scope of acceptable enhancements to DefectDojo in preparation for v3. Learn more here:
https://github.com/DefectDojo/django-DefectDojo/blob/master/readme-docs/CONTRIBUTING.md
Description
Describe the feature / bug fix implemented by this PR.
If this is a new parser, the parser guide may be worth (re)reading.
Test results
Ideally you extend the test suite in tests/ and dojo/unittests to cover the changed in this PR.
Alternatively, describe what you have and haven't tested.
Documentation
Please update any documentation when needed in the documentation folder)
Checklist
This checklist is for your information.

[ ] Make sure to rebase your PR against the very latest dev.
[ ] Features/Changes should be submitted against the dev.
[ ] Bugfixes should be submitted against the bugfix branch.
[ ] Give a meaningful name to your PR, as it may end up being used in the release notes.
[ ] Your code is flake8 compliant.
[ ] Your code is python 3.11 compliant.
[ ] If this is a new feature and not a bug fix, you've included the proper documentation in the docs at https://github.com/DefectDojo/django-DefectDojo/tree/dev/docs as part of this PR.
[ ] Model changes must include the necessary migrations in the dojo/db_migrations folder.
[ ] Add applicable tests to the unit tests.
[ ] Add the proper label to categorize your PR.

Extra information
Please clear everything below when submitting your pull request, it's here purely for your information.
Moderators: Labels currently accepted for PRs:

Import Scans (for new scanners/importers)
enhancement
performance
feature
bugfix
maintenance (a.k.a chores)
dependencies
New Migration (when the PR introduces a DB migration)
settings_changes (when the PR introduces changes or new settings in settings.dist.py)

Contributors: Git Tips
Rebase on dev branch
If the dev branch has changed since you started working on it, please rebase your work after the current dev.
On your working branch mybranch:
git rebase dev mybranch

In case of conflict:
 git mergetool
 git rebase --continue

When everything's fine on your local branch, force push to your myOrigin remote:
git push myOrigin --force-with-lease

To cancel everything:
git rebase --abort

Squashing commits
git rebase -i origin/dev

Replace pick by fixup on the commits you want squashed out
Replace pick by reword on the first commit if you want to change the commit message
Save the file and quit your editor

Force push to your myOrigin remote:
git push myOrigin --force-with-lease

gunicorn removed in #9953
pillow handled in #9950


Restore count to "Others" label

This restores the count to "Other/Others" labels, shown via the top costliest projects in the Overview and Cost Explorer pages.
The costs API removed the "others" count from each project ID (e.g., "1 Other", "6 Others", etc.). There is now a single project, named "Others" and the count is provided via meta data.
https://issues.redhat.com/browse/COST-1328
Cost Explorer

Cost by projects

Top regions

Codecov Report

Merging #1956 (95e80b6) into master (dd43ec9) will increase coverage by 0.46%.
The diff coverage is 56.25%.

@@            Coverage Diff             @@
##           master    #1956      +/-   ##
==========================================
+ Coverage   71.16%   71.62%   +0.46%
==========================================
  Files         372      372
  Lines        6228     6824     +596
  Branches     1120     1468     +348
==========================================
+ Hits         4432     4888     +456
- Misses       1678     1915     +237
+ Partials      118       21      -97

Impacted Files
Coverage Δ

src/api/reports/report.ts
100.00% <ø> (ø)

...nents/reports/reportSummary/reportSummaryItems.tsx
81.48% <0.00%> (+2.31%)
:arrow_up:

src/utils/computedReport/getComputedReportItems.ts
81.39% <60.00%> (+24.43%)
:arrow_up:

...c/pages/costModels/createCostModelWizard/table.tsx
34.28% <0.00%> (-10.16%)
:arrow_down:

src/components/i18n/i18nProvider.tsx
57.14% <0.00%> (-9.53%)
:arrow_down:

src/pages/state/maintenance/maintenanceState.tsx
66.66% <0.00%> (-8.34%)
:arrow_down:

.../pages/costModels/createCostModelWizard/markup.tsx
27.27% <0.00%> (-8.03%)
:arrow_down:

...ges/costModels/costModelsDetails/utils/toolbar.tsx
77.50% <0.00%> (-7.80%)
:arrow_down:

...ostModels/createCostModelWizard/priceListTable.tsx
32.07% <0.00%> (-7.46%)
:arrow_down:

.../costModels/costModelsDetails/bottomPagination.tsx
82.60% <0.00%> (-7.40%)
:arrow_down:

... and 126 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd43ec9...95e80b6. Read the comment docs.


tf.sparse.softmax lack support for float16

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Y
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: N
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 2.7.0
Python version: 3.8
Bazel version (if compiling from source): N/A
GCC/Compiler version (if compiling from source):N/A
CUDA/cuDNN version: N/A
GPU model and memory: N/A

Standalone code to reproduce the issue
import tensorflow as tf
logits = tf.random.uniform([16, 1, 10], dtype=tf.float16)
r1 = tf.nn.softmax(logits,axis=-1) # pass
logits_sp = tf.sparse.from_dense(logits)
r2 = tf.sparse.softmax(logits_sp) # InvalidArgumentError

Describe the current behavior
tf.sparse.softmax cannot accept a tensor of type float16. However, tf.nn.softmax do support half.
For the above code snippet, the error message is:
InvalidArgumentError: Value for attr 'T' of half is not in the list of allowed values: float, double
	; NodeDef: {{node SparseSoftmax}}; Op<name=SparseSoftmax; signature=sp_indices:int64, sp_values:T, sp_shape:int64 -> output:T; attr=T:type,allowed=[DT_FLOAT, DT_DOUBLE]> [Op:SparseSoftmax]

Describe the expected behavior
According to the document for tf.sparse.softmax, it is equivalent to tf.nn.softmax (but for sparse tensors), so tf.sparse.softmax should also support float16 inputs.

Was able to reproduce the issue with tf-nightly-2.11.0-dev20220829 . Please find the gist here. Thank you!


[Test] Refactor import path

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Doesn't wait for cover bell

As they're not part of the generated row, they aren't expected once in the method.
I'd started refactoring to fix this, but will wait for #111 first.

Sounds good!


Add Account Linking flow

What needs to be done here? Happy to tackle to close the column

See https://dust4ai.slack.com/archives/C0512MMRACQ/p1710228327699549?thread_ts=1710141236.277919&cid=C0512MMRACQ.

Won't do
Context: https://dust4ai.slack.com/archives/C050SM8NSPK/p1710321759823659


Please remove from pypip

If you're not going to maintain this, please remove it from distribution. It's wasting people's time should they inadvertently put this library into their dependencies instead of python-dotenv.

Second this. Please remove it and archive this repo. Be responsible and don't pollute the package space.

Clearly, this is not going to happen. The maintainer of https://github.com/theskumar/python-dotenv needs to follow the process of taking over the name on pypip, if you find yourself frustrated, please upvote the issue here: https://github.com/theskumar/python-dotenv/issues/448

Unfortunately it seems that on the other issue there isn't movement, with the amount of downloads from this package on pypi being cited, even though I think they are mostly in error.


easy_install installation location not controlled by --prefix

Hi, Spack developer here.
One of our users noticed that when setuptools is installed, it tries to install its easy_install.py file to the site-packages directory of the Python installation, even though we explicitly provide an alternate --prefix to install to. This is particularly a problem for users who use a system Python with Spack that they don't have install permissions to. Is there some other way to tell easy_install.py where to install to besides the --prefix option of setup.py install? See https://github.com/spack/spack/issues/13738 and https://github.com/spack/spack/issues/13955 for the original issues.
@LDAmorim @ax3l

I ran into this issue today.  This is annoying bug. To get around it I had to do a new install of python and all my packages.  It would be really great if this could be addressed soon.

Are there any setuptools developers who can take a look at this issue? Note that "easy_install is deprecated" is not an answer. We aren't trying to use easy_install, we're trying to install setuptools, but easy_install is being installed to a system location.

Hi @adamjstewart, thanks for bringing this subject forward.
If I understood correctly you are trying to install setuptools itself, and not calling easy_install.
Could you provide a little snippet that shows how you are installing setuptools?

Yes, see the spack-build-out.txt file in https://github.com/spack/spack/issues/13738

I see... Thanks for that!
It seems that you guys are using python setup.py install.
I will try to have a look on that but I cannot promise I will manage it soon (unfortunately... sorry for that).
If you need something quick, I recommend having a look on https://installer.readthedocs.io/en/latest/.
Maybe you can write an auxiliary script and use it in your procedure (the maintainers are still trying to finalize a good design for its CLI, but you can borrow some ideas from https://github.com/pradyunsg/installer/pull/94 or https://github.com/pradyunsg/installer/pull/92).
It is highly likely that the standard install functionality in the Python ecosystem will rely on this package on the near future. Meanwhile you can also try https://github.com/layday/pyproject-install (transitional).

Yes, we are planning on moving from python setup.py install to pip install in https://github.com/spack/spack/pull/27798. @LDAmorim @ax3l can one of you see if this issue still exists when using https://github.com/spack/spack/pull/27798?
I would love to use build and installer instead of pip, but unfortunately build/installer require build/installer to build and install all of their run-time dependencies 😆

Maybe copying build/src/build/ and installer/src/installer/ to a site-packages directory could work? (just guessing here...)

Wow, I see the egg/chicken problem now!
I wonder if this problem with build, installer is being discussed in https://github.com/pypa/packaging-problems or https://discuss.python.org/c/packaging/14...

Hi @adamjstewart, I tried to replicate (a simplified version of) this issue, using both a clone of the repository and the latest sdist in PyPI. You can follow the steps I took bellow:
git clone
cd /tmp
mkdir -p /tmp/_prefix
git clone https://github.com/pypa/setuptools
cd setuptools
python3 setup.py --no-user-cfg egg_info
python3 setup.py --no-user-cfg install --prefix=/tmp/_prefix --root=/

setuptools_clone_logs.txt
sdist
wget https://files.pythonhosted.org/packages/d9/15/0c48951d6fe38d7b3396401f2cfc43c86bc32408ed6c637ce1a9c6df1bdd/setuptools-60.3.1.tar.gz
tar xf setuptools-60.3.1.tar.gz --directory=.
cd setuptools-60.3.1
rm -rf /tmp/_prefix
mkdir /tmp/_prefix

setuptools_sdist_logs.txt
Conclusions
I cannot see in the logs any attempt to create site-packages/easy_install.py in a global folder, everything seems to be installed in the prefix as intended:
$ fd 'easy_install' /tmp/_prefix
/tmp/_prefix/lib/python3.8/site-packages/setuptools/command/__pycache__/easy_install.cpython-38.pyc
/tmp/_prefix/lib/python3.8/site-packages/setuptools/command/easy_install.py

Because of this I am assuming that:

either this issue was already fixed in a more updated version of setuptools,
or that is is OSX specific.

If this issue is OSX specific, I am afraid I will not be able to help since I only have access to Ubuntu machines :/
Could you try again with the latest version of setuptools and see if this problem still exists?
Is there any chance the build system you guys are using is patching the installation schemes?

@adamjstewart in Nixpkgs I've been experimenting with migrating from pip to build and installer. I strongly suggest to go that direction as well, in time. Currently we're stuck at requiring --prefix support. Could you also have a look at https://github.com/pradyunsg/installer/pull/94#issuecomment-1013876999. If I'm correct you need it as well.
Regarding this issue, here's what we do in Nixpkgs. Maybe it helps you. For bootstrapping setuptools we create an sdist first
${python.pythonForBuild.interpreter} setup.py egg_info
${python.pythonForBuild.interpreter} setup.py sdist --formats=gztar

# Here we untar the sdist and retar it in order to control the timestamps
# of all the files included
tar -xzf dist/${pname}-${version}.post0.tar.gz -C dist/
tar -czf dist/${name} -C dist/ --mtime="@$SOURCE_DATE_EPOCH" --sort=name ${pname}-${version}.post0

Then we install this and pip and wheel
# Give folders a known name
mv pip* pip
mv setuptools* setuptools
mv wheel* wheel
# Set up PYTHONPATH. The above folders need to be on PYTHONPATH
# $out is where we are installing to and takes precedence
export PYTHONPATH="$out/${python.sitePackages}:$(pwd)/pip/src:$(pwd)/setuptools:$(pwd)/setuptools/pkg_resources:$(pwd)/wheel:$PYTHONPATH"

echo "Building setuptools wheel..."
pushd setuptools
rm pyproject.toml
${python.pythonForBuild.interpreter} -m pip install --no-build-isolation --no-index --prefix=$out  --ignore-installed --no-dependencies --no-cache .
popd

echo "Building wheel wheel..."
pushd wheel
${python.pythonForBuild.interpreter} -m pip install --no-build-isolation --no-index --prefix=$out  --ignore-installed --no-dependencies --no-cache .
popd

echo "Building pip wheel..."
pushd pip
${python.pythonForBuild.interpreter} -m pip install --no-build-isolation --no-index --prefix=$out  --ignore-installed --no-dependencies --no-cache .
popd

This results in a folder with a functioning pip + setuptools + wheel which can then be used for installing everything else.

Wow, I see the egg/chicken problem now!
I wonder if this problem with build, installer is already being discussed in https://github.com/pypa/packaging-problems or https://discuss.python.org/c/packaging/14...

This is a common issue with bootstrapping. Unfortunately, there are quite some packages involved in this case. It has been discussed a bit on Discourse, and it's primarily up to the distro maintainers to work this out. For non-distro Python it is easy; just use pre-built wheels.

Yes, we first used Nix's approach for bootstrapping pip/wheel/setuptools from source, but eventually moved to self-installing wheels as suggested in https://discuss.python.org/t/bootstrapping-a-specific-version-of-pip/12306. We found this to be much simpler since we need to support a wide range of Python versions that aren't all supported by the latest versions of pip/wheel/setuptools.
We would love to use build/installer, but unfortunately we need to support Python 2 for the foreseeable future. Many of our packages aren't compatible with Python 3, and are no longer maintained so there's no hope for them to be ported to Python 3. Many of these are important scientific libraries needed for reproducibility, so we can't just remove them.

Getting back to the original issue, @LDAmorim @ax3l can you try to reproduce this with the tip of develop in Spack? If you can't reproduce the issue anymore then I'm guessing this has been fixed (either in setuptools or in Spack).

@adamjstewart @LDAmorim @ax3l, please also notice that using python -s might be problematic.
The current version of setuptools rely on a .pth file to load the correct version of distutils.
This is required during the transition period while distutils is deprecated and scheduled to be removed from the stdlib (i.e. will be necessary until the EoL of 3.11)


version 8.0.2 breaks bearer tokens

I know this might sound weird... but I recently Microsoft updated their recommended .Net 8.0 references. They got rid of many of the deprecated messages by using a framework reference or a framework ref that is implicit in the "Microsoft.NET.Sdk.Web" project (see link). https://learn.microsoft.com/en-us/aspnet/core/fundamentals/target-aspnetcore?view=aspnetcore-8.0&tabs=visual-studio#use-the-aspnet-core-shared-framework
To keep working bearer tokens I had to remove "Microsoft.IdentityModel.JsonWebTokens" and other Microsoft.IdentityModel dlls. My code works great...
but... if I attempt to update "EfCore.SchemaCompare" 8.0.1 to 8.0.2 it brings back the usage of Microsoft.IdentityModel.* ... which breaks the bearer tokens authentication.
The database access is in a completely different dll... but just having the Microsoft.IdentityModel.Tokens (Abstraction, Logging, etc.) dlls back in the code seems to be causes errors.
If anyone has been pulling their hair out trying to figure out why this happens... add my name to the list. Do we have to have that for Identity modeling or something? Maybe someone else can reproduce, or at least this will help them figure out its not their code.

Hi @haldiggs,
Yes, in version 8.0.2 I did use the Microsoft.IdentityModel.Tokens because the line containing IsNullOrEmpty wouldn't build.
I thought it was odd at the time, but the System IsNullOrEmpty didn't work and Resharper recommend Microsoft.IdentityModel.Tokens and it works.
I agree that Microsoft.IdentityModel.Tokens is very odd and I could use
x.Name == null || x.Name.Length == 0) instead of IsNullOrEmpty.
Any comments?

Hi @haldiggs,
I have released version 8.0.3 which doesn't use the Microsoft.IdentityModel.Tokens NuGet. In end I used string.IsNullOrEmpty(x.Name) to use the System IsNullOrEmpty method.
Thanks for pointing this out.

Same problem with broken bearer token authentication here with version 8.0.2 but unfortunately still not resolved with 8.0.3 at least on my end.
Everything works fine with version 8.0.1.
Something with the token seems to be broken because login (token creation) is possible but I think it fails at the validation of the token processing inside microsoft identity code.
I got no error message and had no time to look further into it. It's not possible for me to share parts of the code. If I got time I try to build a small reproducible example.
@haldiggs does version 8.0.3 fixes your case?

There seems to be a using statement that's dragging in the old Microsoft
identity DLLs. There's some sort of conflict whenever you're using the full
framework reference that they've moved to for an 8.0 application.
Right now working with an application and a state that I can't break to
test at this time. I will soon as I can and get back.
On Thu, May 2, 2024, 3:05 PM packone @.***> wrote:

Same problem with broken bearer token authentication here with version
8.0.2 but unfortunately still not resolved with 8.0.3 at least on my end.
Everything works fine with version 8.0.1.
Something with the token seems to be broken because login (token creation)
is possible but I think it fails at the validation of the token processing
inside microsoft identity code.
I got no error message and had no time to look further into it. It's not
possible for me to share parts of the code. If I got time I try to build a
small reproducible example.
@haldiggs https://github.com/haldiggs does version 8.0.3 fixes your
case?
—
Reply to this email directly, view it on GitHub
https://github.com/JonPSmith/EfCore.SchemaCompare/issues/36#issuecomment-2091461968,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAM5KUSFDBGZR7ZD6ZAY3R3ZAKMCJAVCNFSM6AAAAABGTSNWMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJRGQ3DCOJWHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Sorry all, I changed the code but forgot take out the Microsoft.IdentityModel.Tokens. Version 8.0.4 is out with the correct NuGets.

Update to version 8.0.4 resolved it on my side, thanks and have a great weekend!


fix: remove 'ref is not a prop' warning

What:
I've swapped the order of the operands in validateGetRootPropsCalledCorrectly to remove unnecessary warning from react.

Why:
I'm messed up short-circuit logic in 3.1.3 and now getting this warning for composite components with forwardRef API.

How:

Checklist:

[ ] Documentation
[ ] Tests
[x] Ready to be merged

[ ] Added myself to contributors table

:tada: This PR is included in version 3.1.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Failed to update/create file after Gitea upgrade

Gitea version (or commit ref): 1.7.0 -> 1.7.3
Git version: 2.11.0
Operating system: Debian 9 Stretch
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ X] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[X ] Not relevant

Log gist:

Description
I recently upgraded my Gitea binary from 1.7.0 to the latest stable release (1.7.3) after which I notice that I can no longer edit to upload files to my existing repository with the following error (Note some information has been redacted for privacy/security reasons:
Failed to update/create file '[MY FOLDER NAME]/[FILE NAME].json' with error: git push origin master: exit status 1 - remote: ./hooks/pre-receive.d/gitea: line 2: /root/gitea: No such file or directory To /root/gitea-repositories/[MY USERNAME]/[MY PROJECT NAME].git ! [remote rejected] master -> master (pre-receive hook declined) error: failed to push some refs to '/root/gitea-repositories/[MY USERNAME]/[MY PROJECT NAME].git'

Currently if I run my original binary (1.7.0) everything seems to work as normal and I have confirmed that the files exist in the location that the error mentions so I think this maybe an issue with the newer binary or perhaps a permission related problem? all of the repository's and files were originally created or uploaded to Gitea v1.7.0 so currently this seems to be an issue with migrating to newer versions. any help would greatly be appreciated. Additionally nothing appears to be out of place in the log files regarding this issue.
...

Update: It appears after renaming my binary file from gitea-1.7.3-linux-amd64 to just gitea has solved this issue however I am going to leave this issue open as I feel that Gitea should be able to identify its own binary file such as the argv[0] function in C is used to get the current binary name. I feel this should be added as I and I assume other people may wish to have the Gitea binary called some else to make it easier to manage in my case I like to have the binary labelled by their version number.

It is git hooks that have the filename in them that are failing. We are unable to use argv[0] due to git being the executable being called. The way around this would be to override the githooks each push, however some people customize their git hooks, so this isn't a possible outcome either.
In admin dashboard there is a setting to overwrite all hooks for exactly this situation. There is also the troubleshooting section of documentation https://docs.gitea.io/en-us/install-from-binary/ which would help you in this sitiuation.


Hide pagination for one page

showing pagination for only one page is not necessary

Yeh! Exactly! Thank you for your fix :+1:

@mkoosej  Hi Mkoosej. Do you mind me adding you in contributer list??

@DONGChuan Not at all, That would be great. I may do further contributions.


Add undo functionality for delete

Currently, the delete feature is complete and there are no further changes needed for delete. Furthermore, the clear feature (which essentially deletes all) has been implemented. Hence, an undo functionality will be a nice addition to delete. This saves the user time as the user does not need to manually re-type an add function for the deleted person.
Undo will undo the most recent delete performed by the user. Undo can only be performed once and after a delete. If 2 deletes are performed in a row, only the most recent delete can be undone.
Possible increments: Undo for the adding of a person, but this is essentially delete.

CodeCov checks have passed!


UpSampling1D not able to handle sequences of unknown length

The code below throws error for unknown dimension. Since UpSampling1D is repeating each element 'size' times along axis 1, I thought it should be able to handle unknown length sequences.
I have a time sequence of 2D vector with an unknown length. I wanted to perform a time convolution on the sequence to extract some features over the 2D vector's time trajectory, and classify based on these features. Since the classification needs to be done on a per-sample basis, I upsample back to the original length via UpSampling1D.
Is there something wrong with the way I am using this or is there a bug? Thank you for an amazing platform.
I am using the latest version of Keras from GitHub, and Tensorflow-GPU 1.0.1.
x = Input(shape=(None, 2,))

y = x
y = Conv1D(32, 3, activation='relu', padding='causal')(y)
y = Conv1D(32, 3, activation='relu', padding='causal')(y)
y = MaxPooling1D(pool_size=2, strides=2)(y)

# Upsample back so output length matches input length
y = UpSampling1D(size=8)(y)

# Classification
y = TimeDistributed(Dense(128, activation='relu'))(y)
y = TimeDistributed(Dense(6, activation='softmax', name='predictions'))(y)

model = Model(inputs=x, outputs=y)

ValueError: Axis 1 of input tensor should have a defined dimension, but is None. Full tensor shape: (None, None, 32). Typically you need to pass a fully-defined input_shape argument to your first layer."

See https://github.com/fchollet/keras/issues/2054#issuecomment-200533670
It seems that variable-length segments are only available with RNN layers under Theano only.

I see. Thank you.


Table 207 OnValidate Work Type Code

We don't need the Resource Unit of Measure in all occasions and therefor we have modified the table 207 with a small IF ... THEN construction on two places.
Herewith the request to adopt this is in the Base App

and

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


[experiment] try using settings for peertube

Motivation for this change
Things done
Alternative idea to https://github.com/NixOS/nixpkgs/pull/119110
@Izorkin This probably won't make it - I just want to get some feedback regarding some problems with this approach and if that can be somehow improved. It would get a mess in the other PR.
@aanderse Pinging you is evil :D but it was your idea and I need some help. (Others are also welcome to help of course)
The important file is the module.

The problem is that some additional options for e.g. redis are needed that are not in the official peertube configuration (createLocally and passwordFile in this case). Should I use a) the current approach of splitting these up into two places, b) putting the options into settings where they are currently ignored by peertube, c) put all options that are usually needed outside of settings like before (inconsistent) or do you have another idea?
any idea how I can incoporate the settings.storage options without a lot of option declarations?
Is the way the passwords are read in now fine (the future encrypted nix secrets provisioning may unify this whole approach AFAICT)?
Anything else that comes to your mind in regard to the settings implementation?

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@mohe2015 fair. I will try to take a look in the next day or so :+1:

This seems nice. It's going to be a bit more work to maintain and it will also be tied more closely to the peertube version being used.

Closing in favor of #119110


Enable searching for photos from the Flickypedia homepage

I'm going to close this as WONTFIX – this was an idea where you could type a free text term into the Flickypedia input box, and it would map that to a Flickr search under the hood.
We don't support Flickr searches (see #72) and it's unclear if/when we will. I'm not even sure if this is an idea we'd want to implement (because it makes the input to that field harder), so I'm going to close this for now.


SavedModel support

TensorFlow has support for exporting models using SavedModel that can be deployed using TensorFlow Serving.
The Callback class within keras.models.Model can be extended to support this within this implementation.
Opening issue and will implement proper branching structure for this repo.

SavedModel support has been added and integrated with the chexnet_client.py module. TensorFlow Serving now returns serializes the model to the appropriate ./experiments/ directory.


Make width of bar configurable

Is your feature request related to a problem? Please describe.
I would like a wider level bar
Describe the solution you'd like
A configuration option to specify the width of the level bar
Describe alternatives you've considered
Changing CSS (did not work)
Additional context
Add any other context or screenshots about the feature request here.

Hi,
Thank you for your interest and contribution. I see that your requests are somehow connected.
Make bar size configurable and remove tickmarks. Can you describe more clearly (or may be sketch) what the widget should do for you. Even it is complicated, the option to consider may be that bar will fullfill whole widget area if let's say all text options are turned off at configuration page. Just to make bar wider will be hard many things go wrong with text sizes. (devices tend to lie about sizes)
Let's take all discussion in here and make decisions about other (seems to me connected) requests afterwards

I will make these changes and will make some pull requests when finished.


Boolean fields in the view default to “false” when form and schema are set from within $http.get()

I posted a detailed question in stackoverflow with JSFiddle examples:
http://stackoverflow.com/questions/33963976/boolean-fields-in-the-view-default-to-false-when-scope-form-and-scope-schema

@mutharasus I'm new to the project, can you check/update the JSFiddles, perhaps the URLs to this repo are different so they aren't loading now for me. If you do that I will take a look at what is happening.

I'm also having this issue. I'm writing a 'bulk edit' form where I create a checkbox for each form field to enable modifying of that field. I then use a watcher to copy the fields (and not the enabling checkboxes) into the binding value of my directive. The problem is that these forced defaults is setting all my checkboxes to false.

@slyadams
I believe this is fixed in the latest updates (alphas) for the eventual 1.0.0 release.
Please re-open if there are still issues in these versions.

If anyone wants this re-opened I need a gist or plunker please.


Space in Range header result in a ParseException

Hey Ramsey,
thanks for the great work. I used your range parser as base for a new PSR Handler & Middleware, that I will publish soon. With my tests, a found an issue in your parser.
Best regards,
Tim
Description
I got this ParseException "Unable to parse range:  210-250" if the header is "bytes=0-199, 210-250"
Steps to reproduce
Call your code with a Range header incl. multiple ranges separated by space: bytes=0-199, 210-250
Expected behavior
I would expect the same behavior as with this header bytes=0-199,210-250 (without space). The space is allowed in this context and should be trimmed/skipped in the parsing process.
Same docs:

https://developer.mozilla.org/en-US/docs/Web/HTTP/Range_requests
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Range

Environment details

version of this package: dev-main
PHP version: 8.2.7
OS: current macOS

Thanks for the bug report!
I just realized that I've not updated the GitHub Actions workflows to test this library on PHP 8.1 or 8.2 yet, so I'll handle that while taking a look at this issue.


Update vendor/knative.dev/test-infra

Major changes:

display E2E cluster setup during tests
dump failed pod status when waiting for pods to come up during test setup
fix detection of retriable failures during test cluster creation
fix parsing error for autogenerated code in flaky test reporter
fix automatic dot releases for 0.10+ branches

Part of https://github.com/knative/test-infra/issues/1542
/cc @grantr

/lgtm
/approve

/assign @houshengbo

Obsoleted by #32.
/close


Support for unstructured text corpus datasets for CPT

Context
What is the purpose of this PR? Is it to

[x] add a new feature
[ ] fix a bug
[x] update tests and/or documentation
[ ] other (please add here)

Please link to any issues this PR addresses: #845, #809
Continued pre-training involves an identical data processing pipeline as standard pre-training, where the model simply predicts the next token and completes the text. It does not require any templating or prompt formatting. Our existing dataset classes are specifically designed for instruct and chat tuning, but don't support free-form text corpuses.
Here, we add a dataset class TextDataset that simply calls load_dataset and tokenizes the text directly without any further processing. It uses encode which simply adds BOS/EOS tokens if needed. This should be compatible with llama2, llama3, and other model's formatting requirements.
Changelog
What are the changes made in this PR?

Add TextDataset and appropriate tests
Add an example dataset builder, cnn_dailymail_articles_dataset and appropriate tests

Test plan
Please make sure to do each of the following if applicable to your PR. (If you're not sure about any one of these just ask and we will happily help.)

[x] run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
[x] add unit tests for any new functionality
[x] update docstrings for any new or updated methods or classes
[x] run unit tests via pytest tests
[x] run recipe tests via pytest tests -m integration_test
[x] manually run any new or modified recipes with sufficient proof of correctness

[x] include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

Ran the full finetune distributed recipe with the cnn dailymail dataset.
2024-04-24:23:12:06,234 INFO     [_utils.py:34] Running FullFinetuneRecipeDistributed with resolved config:

batch_size: 2
checkpointer:
  _component_: torchtune.utils.FullModelMetaCheckpointer
  checkpoint_dir: /tmp/Meta-Llama-3-8B/original/
  checkpoint_files:
  - consolidated.00.pth
  model_type: LLAMA3
  output_dir: /tmp/Meta-Llama-3-8B/
  recipe_checkpoint: null
dataset:
  _component_: torchtune.datasets.cnn_dailymail_articles_dataset
device: cuda
dtype: bf16
enable_activation_checkpointing: true
epochs: 3
gradient_accumulation_steps: 1
log_every_n_steps: null
loss:
  _component_: torch.nn.CrossEntropyLoss
max_steps_per_epoch: null
metric_logger:
  _component_: torchtune.utils.metric_logging.WandBLogger
  log_dir: /tmp/alpaca-llama3-finetune
  name: cnn_dailymail
  project: torchtune
model:
  _component_: torchtune.models.llama3.llama3_8b
optimizer:
  _component_: torch.optim.AdamW
  foreach: false
  lr: 2.0e-05
output_dir: /tmp/alpaca-llama3-finetune
resume_from_checkpoint: false
seed: null
shuffle: true
tokenizer:
  _component_: torchtune.models.llama3.llama3_tokenizer
  path: /tmp/Meta-Llama-3-8B/original/tokenizer.model

do we in general plan to support CPT in torchtune and plan for an RFC around this possibly?
I don't know that CPT will be sufficiently different from our finetune recipes to warrant its own, besides different data handling. @rohan-varma would you know :) or maybe @pbontrager ?

I don't know that CPT will be sufficiently different from our finetune recipes to warrant its own, besides different data handling. @rohan-varma would you know :) or maybe @pbontrager ?

I don't think so initially. I think this dataset is good and we could add a recipe in the future if there are additional custom things that people want for advanced use cases.

Codecov Report
Attention: Patch coverage is 55.20833% with 43 lines in your changes are missing coverage. Please review.

Project coverage is 27.20%. Comparing base (cb8e65a) to head (6ead093).
Report is 2 commits behind head on main.

Files
Patch %
Lines

torchtune/datasets/_text_completion.py
44.00%
14 Missing :warning:

...torchtune/datasets/test_text_completion_dataset.py
44.44%
10 Missing :warning:

...s/torchtune/datasets/test_cnn_dailymail_dataset.py
57.89%
8 Missing :warning:

tests/torchtune/datasets/test_wikitext_dataset.py
57.89%
8 Missing :warning:

torchtune/data/_utils.py
50.00%
1 Missing :warning:

torchtune/datasets/_cnn_dailymail.py
80.00%
1 Missing :warning:

torchtune/datasets/_wikitext.py
80.00%
1 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #868       +/-   ##
===========================================
- Coverage   67.10%   27.20%   -39.91%
===========================================
  Files         174      180        +6
  Lines        7423     7518       +95
===========================================
- Hits         4981     2045     -2936
- Misses       2442     5473     +3031

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Any update here? I want to train on https://huggingface.co/datasets/allenai/dolma soon.


Add ruby-cleanup to clear the bundler/gems and cache folder

Signed-off-by<EMAIL_ADDRESS>Description
The size of the installer on platforms has doubled after moving to chef-foundation.
Fix Includes cleanup of the bundler caches. This will remove ohai,rest-client,ruby-proxifier,and ruby-shadow caches. On cleaning the cache and bundler folder reduces the overall package size.
Related Issue

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] All commits have been signed-off for the Developer Certificate of Origin.

Test Build - https://buildkite.com/chef/chef-chef-main-validate-adhoc/builds/384

pre and post chef-foundation versions seem to indicate that the ruby-cleanup dependency was removed. Shouldn't we start with reintroducing the dependency first (or has that already been tried and I'm missing that detail?)

@tpowell-progress
I have already tried adding a ruby-cleanup dependency. Build failed [Error] ](https://buildkite.com/chef/chef-chef-main-validate-adhoc/builds/369#01876b25-45f2-4d3c-af0b-3f0f41252e35/310-1603)
bundler: failed to load command: omnibus (/opt/omnibus-toolchain/embedded/lib/ruby/gems/3.1.0/bin/omnibus)
/opt/omnibus-toolchain/embedded/lib/ruby/3.1.0/fileutils.rb:367:in `symlink': File exists @ syserr_fail2_in - /opt/chef/embedded/ssl/cert.pem (Errno::EEXIST)

Since the cert files already get copied with the chef-foundation install. It is throwing the above error.
The cacerts dep comes from ruby-cleanup --> ruby --> openssl --> cacerts
Hence I made a  project local copy of ruby-cleanup and removed the ruby dep in it as ruby would already be there on the build agent.

@poorndm what if we removed the ruby dependency in the original ruby-cleanup omnibus-software definition? i believe we will still be able to get successful builds for other products that rely on ruby-cleanup minus that.

Test Build

BadSSL errors will be fixed in an upcoming PR.


Simplified the Entities.escape method

Introduced an options bitset instead of all those boolean method options. Reduced cyclomatic complexity of from 29 to 14.
Improved throughput of escape around 22% if the content contains characters in supplemental plane, by no longer going through the charset encoder to test can encode, but pushing it into the CoreCharset. That removes a ByteBuffer allocation on each hit.

I perf tested using this wiki list of colors, which has some interesting attributes like <p title="𝗛𝗦𝗩 (34° 14% 98%)
𝗥𝗚𝗕 (250 235 215)
𝗛𝗘𝗫 #FAEBD7">. Those are mathematical sans-serif bold capital h etc; 𝗛 if encoded in ASCII (in UTF we don't need to encode).
Average html() operations per second wen from ~ 156 to ~ 186.

And some further improvements in 27e7d5f03d85bea15fbfe5432c37c6de94965a82. Getting around 235 ops/sec (from 156 -- so about 49% faster now!)


[bug] INT-1765 filter deprecated configs

Resolves: INT-1765
Problem
We used to have logic that looked for a deprecated comment at the top of a config file and hid it from users. The logic has been removed, and we can now see all the deleted config files.
Solution
Add logic that was previously in the Console to filter templates that are marked # deprecated. This
Additional Notes
This change is implemented on the Blueprints side due to changes in fetching configs - in Console, we use the manifest to know which config files are available; we then categorize them by model type and fetch their contents on demand based on user selection, rather than fetching them all and deciding which to display by model type.
Open Questions
Are there other consumers than Console that rely on the manifest? Will these changes adversely affect those consumers?
Testing
Before:
[
 'config_templates/gretel/classify/classify-all-entities.yml',
 'config_templates/gretel/classify/default.yml',
 'config_templates/gretel/classify/classify-pii-nlp-off.yml',
 'config_templates/gretel/classify/classify-pii-regex.yml',
 'config_templates/gretel/classify/classify-pii-nlp-on.yml',
 'config_templates/gretel/synthetics/low-record-count.yml',
 'config_templates/gretel/synthetics/default.yml',
 'config_templates/gretel/synthetics/tabular-actgan.yml',
 'config_templates/gretel/synthetics/high-dimensionality.yml',
 'config_templates/gretel/synthetics/time-series.yml',
 'config_templates/gretel/synthetics/tabular-differential-privacy.yml',
 'config_templates/gretel/synthetics/natural-language.yml',
 'config_templates/gretel/synthetics/amplify.yml',
 'config_templates/gretel/synthetics/tabular-lstm-evaluate.yml',
 'config_templates/gretel/synthetics/tabular-lstm.yml',
 'config_templates/gretel/synthetics/complex-or-free-text.yml',
 'config_templates/gretel/synthetics/high-accuracy.yml',
 'config_templates/gretel/evaluate/default.yml',
 'config_templates/gretel/transform/default.yml',
 'config_templates/gretel/transform/redact-pii-regex.yml',
 'config_templates/gretel/transform/redact-pii-nlp-off.yml',
 'config_templates/gretel/transform/transform_v2.yml'
]

After:
[
 'config_templates/gretel/classify/classify-all-entities.yml',
 'config_templates/gretel/classify/default.yml',
 'config_templates/gretel/classify/classify-pii-nlp-off.yml',
 'config_templates/gretel/classify/classify-pii-regex.yml',
 'config_templates/gretel/classify/classify-pii-nlp-on.yml',
 'config_templates/gretel/synthetics/tabular-actgan.yml',
 'config_templates/gretel/synthetics/time-series.yml',
 'config_templates/gretel/synthetics/tabular-differential-privacy.yml',
 'config_templates/gretel/synthetics/natural-language.yml',
 'config_templates/gretel/synthetics/amplify.yml',
 'config_templates/gretel/synthetics/tabular-lstm-evaluate.yml',
 'config_templates/gretel/synthetics/tabular-lstm.yml',
 'config_templates/gretel/evaluate/default.yml',
 'config_templates/gretel/transform/default.yml',
 'config_templates/gretel/transform/redact-pii-regex.yml',
 'config_templates/gretel/transform/redact-pii-nlp-off.yml',
 'config_templates/gretel/transform/transform_v2.yml'
]

Hey there 👋,  you'll want to PR your changes against develop instead of main for Blueprints repo changes, so that we can adequately test the integration with Console dev environments. Then, once we've confirmed it all works the way we want, we'll cherry-pick your commit into a PR against main.
The main and develop branches don't share the same full git history, so it can be a bit funky to try to move changes over -- might be easiest to start a fresh branch off develop and copy the code changes in fresh. just a heads up! 😀

Hey there 👋, you'll want to PR your changes against develop instead of main for Blueprints repo changes, so that we can adequately test the integration with Console dev environments. Then, once we've confirmed it all works the way we want, we'll cherry-pick your commit into a PR against main.
The main and develop branches don't share the same full git history, so it can be a bit funky to try to move changes over -- might be easiest to start a fresh branch off develop and copy the code changes in fresh. just a heads up! 😀

ah yes, thank you 🙃 the diff should be based on develop now.


When using websockets as a client, how to send a pong when receiving a ping?

nevermind, found it implemented here: https://github.com/python-websockets/websockets/blob/main/src/websockets/protocol.py#L644

In case someone lands on this question - official answer here: https://websockets.readthedocs.io/en/stable/faq/common.html#how-do-i-respond-to-pings


No assets found in release

Hi@robinraju
I used the release-downloader and get the latest version. The problem and error appearing is: Error: there are no assets found.
The problem is, there are assets. Is there a solution for this?
Note - with version 1.8, it works.

name: Dummy Release
uses<EMAIL_ADDRESS>with:
tag: ${{ xyx 'latest' }}  # If tag is not provided, default to 'latest'
fileName: "*.zip"
token: ${{ xyx }}
latest: true  # Always set to true to download the latest release if tag is not provided or is invalid
tarBall: true
zipBall: true
repository: xyx

This error happens when you specify a file name and it couldn't find that asset.
The flags tarBall: true and zipBall:true will download both of the following files, which are available in all releases.
Source code (zip)
Source code (tar.gz)
The fileName input is used when you have any additional files apart from these two,
Otherwise you can remove the fileName: "*.zip" part.
Let me know if you are trying to download a different .zip file available in the release and see this error.

Thanks much for your respond Robinraju.
I do not want to download a different .zip file.
I removed the fileName: "*.zip" from my file but i am getting the same error again.
Here is my workflow.
on:
push:
branches:
- xyz
workflow_dispatch:
inputs:
tag:
description: 'Specify the tag of the release to download, or leave empty for the latest release'
required: false
jobs:
download-release:
name: Dummy Release with tag input
runs-on: ubuntu-latest
steps:

  - name: Dummy Release with tag input
    uses<EMAIL_ADDRESS>    with:
      tag: ${{ xyz || 'latest' }}  # If tag is not provided, default to 'latest'
      token: ${{ xyz }}
      latest: true  # Always set to true to download the latest release if tag is not provided or is invalid
      tarBall: true
      zipBall: true
      repository: xyz

here is the error.

Same error here

@mcfdez  Not yet, Still waiting for @robinraju  to respond.

Looks like a bug in the downloader when it tries to resolve various assets based on the user input.
I just reproduced it here:
The downloader always look for an asset by its name. That shouldn't be the case if you just want to download a zipBall or tarBall only.
I'll fix it soon.

A fix for this is merged now, you may test it using the latest commit hash on main branch as follows.
- uses: robinraju/release-downloader@cb096d8fa1fcb0e897f30b1c571f07e2c8e12479
  with:
    repository: "owner/repo"
    latest: true
    tarBall: true
    zipBall: true

Hi @robinraju
I confirm that works like a charm. Thx!


minor: fix typo in comments.

Which issue does this PR close?
N/A
Rationale for this change
N/A
What changes are included in this PR?
N/A
Are these changes tested?
N/A
Are there any user-facing changes?

Thanks @jackwener


Remove usages of jQuery from JS client as much as possible

The JavaScript client should stop depending on jQuery and use the builtin Fetch API https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API, so that the client app doesn't need to bother depending on jQuery for just using the Jolokia JS client.

@tadayosi please add very quick info about such changes to https://github.com/jolokia/jolokia/blob/2.0/src/site/asciidoc/migration.adoc - at some point (soon) I'll prepare proper "changes in 2.0" page.

What remain to be done:

[ ] $.extend
[ ] $.ajax

The current jolokia.js provides both sync and async modes, which is based on the $.ajax feature. I found it hard to completely replace it with Fetch API as it only supports async API. So forcing replacing $.ajax with Fetch API will bring destructive, backward incompatible changes to jolokia.js, which we should avoid.
It should be still preferable to have removed the rest of jQuery API usages from the JS client to minimise dependency to external libs.
Instead, I propose to create a yet another base JS client jolokia-fetch.js which is based on Fetch API and only supports async mode. Users who don't want to bring dependency to jQuery for their apps will be able to use this version of base JS client. jolokia-simple.js should be compatible with both versions, now that it itself doesn't have dependency to jquery.
@grgrzybek @rhuss FYI

:+1:

I'll close this and follow it up with #580.


DBZ-5578 Add description to connector metadata

https://issues.redhat.com/browse/DBZ-5578
I'm still waiting on details internally about additional changes that may be needed.  Once confirmed that we have all changes needed I'll convert from draft to ready.

@Naros I suggest doing this with the "additional fields" pattern that we are already using for the config options. So having a more flexible way to add additional fields to the metadata block? Wdyt?

@rk3rn3r @Naros Do you mean builder pattern instead of constructor?
I'd say it depends on the scale/urgency? If this needs to be done fast then let's make it done as is now and just log a follow-up Jira. If not we can talk about an API for that.

I'll happily change this if you want @rk3rn3r but I tend to agree with @jpechane just given the current workload and resource constraints.  wdyt?

@Naros @jpechane I am sorry your reply got lost over my PTO back then.
What I meant was, when I remember correct what I had in mind back then lol, that instead of doing this here upstream (adding metadata that are only needed downstream for MCS) that we only do it here with additional properties that are statically rendered to the descriptors: https://github.com/bf2fc6cc711aee1a0c2a/cos-fleet-catalog-debezium/blob/main/src/main/java/io/debezium/mcs/envelope/ConnectorTypesEnvelope.java#L100
And add a way to add additional fields to the connector type descriptor (metadata) block.
I don't see a reason to add this to upstream (and later on require upstream releases or build to update downstream).

@rk3rn3r It sounds logical, just who will do the call and provide those additional metadata?

Not needed anymore, see Jira issue for the details.


to_if_alone sends KeyUp first, is it right behaviour?

All of my to_if_alone settings along with your default SandS configuration sends KeyUp first followed by KeyDown.
Due to this behaviour, for example, QuickLook does not work correctly when I applied SandS in Karabiner-Elements.
Is this behaviour within your expectation?
Or does something go wrong with my Karabiner-Elements?
eventType:FlagsChanged    code:0x38       name:left_shift      flags:Shift                              misc:
eventType:FlagsChanged    code:0x38       name:left_shift      flags:                                   misc:
eventType:KeyUp           code:0x31       name:spacebar        flags:                                   misc:
eventType:KeyDown         code:0x31       name:spacebar        flags:                                   misc:

I am wondering most users are not affected by this issue.
So this seems related to my local environment, but uninstall and re-install of Karabiner-Elements does not solve this issue.
And this seems not to be a conflict between Karabiner-Elements and other apps because only activating Karabiner-Elements does cause the issue.
I am wondering updating Karabiner-Elements from wwwjfy's patch might cause the problem, though I don't know at all.
My environment is:
macOS Sierra 10.12.6
Karabiner-Elements 11.1.0
MacBook Pro (Retina, 15-inch, Mid 2014)
A clean install of OS would solve this but it's too tough a process which I don't want to do.
However, I'm suffered from this behaviour so long.
I hope the issue would be clarified.
Thank you for the great software.

I've increase the wait between continuous key events at v11.1.12.
Please confirm the latest beta version.
https://pqrs.org/osx/karabiner/document.html#check-for-updates

@tekezo Thank you for your prompt reply!
I tried v11.1.18-11.2.0.
Although I found the issue is calmed down until the second or third attempts, to_if_alone still sends KeyUp first in most cases after that.
If this is a just my-device-specific issue, I am sorry for that.
I apologise for bothering you.
For your information, I put an example where only the default SandS rule is applied and pressing space_bar several times.
eventType:FlagsChanged    code:0x38       name:left_shift      flags:Shift                              misc:
eventType:FlagsChanged    code:0x38       name:left_shift      flags:                                   misc:
eventType:KeyDown         code:0x31       name:spacebar        flags:                                   misc:
eventType:FlagsChanged    code:0x38       name:left_shift      flags:Shift                              misc:
eventType:FlagsChanged    code:0x38       name:left_shift      flags:                                   misc:
eventType:KeyDown         code:0x31       name:spacebar        flags:                                   misc:
eventType:KeyUp           code:0x31       name:spacebar        flags:                                   misc:
eventType:FlagsChanged    code:0x38       name:left_shift      flags:Shift                              misc:
eventType:FlagsChanged    code:0x38       name:left_shift      flags:                                   misc:
eventType:KeyDown         code:0x31       name:spacebar        flags:                                   misc:
eventType:KeyUp           code:0x31       name:spacebar        flags:                                   misc:
eventType:FlagsChanged    code:0x38       name:left_shift      flags:Shift                              misc:
eventType:FlagsChanged    code:0x38       name:left_shift      flags:                                   misc:
eventType:KeyDown         code:0x31       name:spacebar        flags:                                   misc:
eventType:KeyUp           code:0x31       name:spacebar        flags:                                   misc:
eventType:FlagsChanged    code:0x38       name:left_shift      flags:Shift                              misc:
eventType:FlagsChanged    code:0x38       name:left_shift      flags:                                   misc:
eventType:KeyDown         code:0x31       name:spacebar        flags:                                   misc:
eventType:FlagsChanged    code:0x38       name:left_shift      flags:Shift                              misc:
eventType:FlagsChanged    code:0x38       name:left_shift      flags:                                   misc:
eventType:KeyUp           code:0x31       name:spacebar        flags:                                   misc:
eventType:KeyDown         code:0x31       name:spacebar        flags:                                   misc:
eventType:FlagsChanged    code:0x38       name:left_shift      flags:Shift                              misc:
eventType:FlagsChanged    code:0x38       name:left_shift      flags:                                   misc:
eventType:KeyUp           code:0x31       name:spacebar        flags:                                   misc:
eventType:KeyDown         code:0x31       name:spacebar        flags:                                   misc:
eventType:FlagsChanged    code:0x38       name:left_shift      flags:Shift                              misc:
eventType:FlagsChanged    code:0x38       name:left_shift      flags:                                   misc:
eventType:KeyUp           code:0x31       name:spacebar        flags:                                   misc:
eventType:KeyDown         code:0x31       name:spacebar        flags:                                   misc:
eventType:FlagsChanged    code:0x38       name:left_shift      flags:Shift                              misc:
eventType:FlagsChanged    code:0x38       name:left_shift      flags:                                   misc:
eventType:KeyUp           code:0x31       name:spacebar        flags:                                   misc:
eventType:KeyDown         code:0x31       name:spacebar        flags:                                   misc:
eventType:FlagsChanged    code:0x38       name:left_shift      flags:Shift                              misc:
eventType:FlagsChanged    code:0x38       name:left_shift      flags:                                   misc:
eventType:KeyUp           code:0x31       name:spacebar        flags:                                   misc:
eventType:KeyDown         code:0x31       name:spacebar        flags:                                   misc:

I get similar results with my mapping of caps-lock to escape if pressed alone, and to left-control if held.
The left control flags always change, but the escape key sometimes only has the key up, or only the key down event fire.  I experience having to hit the caps lock key multiple times in some instances to get the program I'm using to register the escape press.
I'm not sure if this is the same issue as above, or if it's an unrelated issue.  If it's unrelated, I'll move to a new issue, but if not, I thought I would throw my info out there.  If I can help debug anything, let me know, I would be happy to help!

And following the official manual, I added "lazy": true to to sections of each to_if_alone settings, which resulted that eventType:FlagsChanged disappers when I hit to_if_alone-enabled key alone.
Things pretty work well at this moment.
Thank you so much, my productivity has been revitalised!


Upgrade npm to pnpm

As much as a good default npm is, there are better tools out there that leverage caching solutions and make builds significantly faster.
Yarn was initially a good approach to this and pnpm followed.
Pnpm used to be an immature package manager but it has become very popular amongst library authors becoming a standard in modern js development.
https://pnpm.io/benchmarks
What this upgrade will bring to the table

Faster CI/CD installs
Faster local installs
Readable yaml lock files (cut the package.lock / yarn.lock nonsense diffs)
This might not be game changing bc who really reads lock files but if you ever want to check on sub deps of installed packages it is a nice to have!

pnpm is not supported by heroku  so we would have to have a different set up for heroku ? @lakardion


fixed alert dialog

fixed the tables alertdialog in accordance with design guidlines.

Thank you for the review @Redeem-Grimm-Satoshi

@wbrunette @maprehensive This looks good


Add Tests For Controllers

Summary
Following the project requirements outlined, I have done the following:

Added RSpec as a gem to the project.
Created a Request spec file for all controllers.
Made sure that for each action the following check were carried:

If response status was correct.
If a correct template was rendered.
If the response body includes correct placeholder text.

All tests passing as shown below:


No matches when apostrophe mismatch

match-sorter version: 6.3.0
node version: N/A

Relevant code or config
import { matchSorter } from "match-sorter"

const items = ["Don’t", "Foo"]

console.log(matchSorter(items, "Don't")) // -> []

What you did:
Search with ' but results contains ’
What happened:
No results returned
Reproduction repository:
See code above
Problem description:
When an item contains ’ and you query by ' you get no matches.
Suggested solution:
It would be nice if this was handled directly in the lib, but if there is a way of fixing this in the code let me know. Would still be valuable to support this OOTB though imo

Hi @alexandernanberg,
I'm afraid that's out of scope for this package.


No Auth Mechanism Defined Error

I was about the rebase the image but I encounter an issue when the tool try to push the rebased image.

Can I know what should I do to get rid of this issue? I am trying push to dockerhub public repo.
Thanks.

You can set user and password with the environment variables DOCKER_USER and DOCKER_PASS. I hope this helps.


Init container exists beta in 1.6.

NOTE: Please check the “Allow edits from maintainers” box below to allow
reviewers fix problems on your patch and speed up the review process.
Please delete this note before submitting the pull request.

Fixed #3649

This change is

/cc @hodovska @smarterclayton

@gyliu513 Sorry, I made a change to the text in init-containers.md so you'll need to resolve that conflict.

@chenopis updated, thanks.

/cc @hodovska @smarterclayton can you please help approve this?

/approve

@smarterclayton @chenopis  can you please help commit this as well?


[cpp-client] Fix compilation issue caused by non-virtual destructor

Related issue: #9105

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

@tongsucn Could you please rebase the master branch since there is a test fix in the master branch? It's better do not use the master branch to push PRs. For more details, you can refer to http://pulsar.apache.org/en/contributing/

@tongsucn Could you please rebase the master branch since there is a test fix in the master branch? It's better do not use the master branch to push PRs. For more details, you can refer to http://pulsar.apache.org/en/contributing/

@codelipenghui It's done, sorry for my fault. I'll use another branch next time :D

@codelipenghui It's done, sorry for my fault. I'll use another branch next time :D

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks


fix: typo

thanks for fixing those

unfortunately, your commit isn't signed... To accept your submission, you'll need to sign your commits.


[Hub Generated] Review request for Microsoft.Security to add version preview/2020-03-01-preview

If you are a MSFT employee you can view your work branch via this link.
Contribution checklist:

[x] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

/azp run automation - sdk

Can one of the admins verify this patch?

/azp run automation - sdk

@kfbehar - since a new type is being added, it may be quicker to do the review over a meeting. PLease set something up with armapireview.

@kfbehar what's the status of this PR? Do you still need to merge it?

@kfbehar what's the status of this PR? Do you still need to merge it?

Yes, please :)

@kfbehar Can you resolve the conflicts and fix the errors for the required CI? You can follow https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md

@kfbehar any update?

Close idle PR. Please feel free to reopen it and continue the work if you still need it.