Make it more obvious that the calibration grid doesn't need to be the size of the cutting mat

I'm getting a lot of messages about people not knowing that they can size their calibration grid to be smaller than their mat and still cut to the edge of the projection area. I'm not sure how to make this more obvious.
Some ideas:

Remove the border from the projecting grid
Pad the projecting grid with a few more rows and columns
Have some sort of tutorial popup or button on the calibration page that explains how to use it
Reword info page steps

I think a section in the documentation titled "Choosing a Calibration Size" would be helpful for people who read the documents! Maybe put it near the top because it's one of the first things you have to decide (like even before "Calibration" or as a subheader just under "Calibration" maybe).
I think that would get the point across. There will always be limitations to grid size from a technical perspective, so education seems more straightforward here.

I think you're right. I'll try to write something up.

I've noticed on the FB group that Sasha recommends the calibration grid be at least 16"x24". Maybe include that somewhere? To be honest, I'm very new at projector sewing, haha. I think I've only cut out one pattern using a projector! So I will definitely defer to you on docs here.

I think it'd be great to have a number so people will feel confident that they have the minimum grid size. I've only cut one pattern as well! I needed this app working for my cutting setup to make sense and now I've been using all my spare time working on the app instead of sewing, lol!

I needed this app working for my cutting setup to make sense and now I've been using all my spare time working on the app instead of sewing, lol!

Same!

Me too except you all are on such a spree that now I can't keep up with either my sewing or the programming 😂

Looking at the Dutch translation which I'm tweaking now, I would put this extra note as a 'step 6' under the 'Calibration' part. It could be something like "6) Tip: if your projector shows an image that is smaller than your cutting mat, that's fine! You can still calibrate the grid on only some of the inner squares on your cutting mat. Your calibration will be more accurate if you make the calibration rectangle as large as possible though, so do try to use as much of your projected area as you can!".
(at least I'm hoping this is the correct interpretation and explanation of what you're talking about!)
Furthermore, I think the manual should have something on how to calibrate when you have a transparent cutting mat and need to mark out your own calibration pattern underneath the mat using masking tape. But before I write that, one preliminary issue: I do think that the documentation system with i18n strings will get unwieldy very quickly, as it's quite hard to update strings and keep all translations and newly added strings sync'ed . I do not have experience with more elaborate documentation/translation management systems, does any of you? I think that having the manual (where one wants more more to change things like adding bullet points without touching code) and website/app UI (where such restrictions are less important and even undesirable, you need one string per UI item) in separate systems is more logical. Then again, this would call for a more structured release process, so that translations can be checked, sync'ed and updated at appropriate moments - which I think is not quite appropriate in this stage of the software's life cycle.
Until then, it would at least be nice to have a 'step 6' under 'calibration'.

I agree that the internationalization process for the landing page is a bit bonkers. I'm in the process of starting to use weblate for translations. I'm hoping that will simplify the process. The person who provided the danish translation suggested it and it seems like it will be much easier to keep things in sync. Once I get that fully set up I'll add in step 6 and send it to you if that's ok. We can see if it makes things any easier!

Weblate looks amazing, I'd never heard of it. Let's see how it works out.


Chosen project choice is never taken into account with multiple projects config

Hi,
I started using git lab a few days ago. I set up a multi-projects configuration with a .git-lab file in my home directory.  The config file looks like this
[gitlab]
project_id=123
url=https://gitlab.smonff.com/api/v4
token=S3kR3t

[preferences]
user=sf
max_length=80

[project Backend]
project_id=456
[project API]
project_id=123
[project Dotfiles]
project_id=789
[project Frontend]
project_id=567

As far as I can say, the chosen project that should be set after the menu get displayed is never taken into account: the default project is always used, or an undef value is used if no default project exists (in the [gitlab] section).
Looks like it is because the $project_id value is never overwritten by the $chosen value:
https://github.com/Ovid/git-workflow/blob/105bb1d5176ee29779739cd9a7d9b0039600916b/bin/git-lab#L101
Doing something like this, before returning the $project_id should help :
    my $name = $name_for_id{$chosen};
        say "You chose project $name";
+       $project_id = $chosen;
    }
    return $project_id;
}

Note that I didn't try to reproduce the issue with a per-repository .git-lab configuration. Maybe the behaviour is different then.
I will follow up with a MR if it makes sense.

Closed by #10 .

Thank you again for this, Seb :)


Sampler cuts off wav file sound midway when using playNote

I'm trying to play a custom sound saved in a wav file (unzip attached for wav file).
TCM_Snare_4.wav.zip
But, when running the sampler.playNote() the audio file is played and then maybe 30% into the sound it cuts off for about 1/4 of a sec and then continues finishing the sound (it's a long snare drum sound).
Here is my playground code  - running the latest audiokit-develop branch (downloaded about 2 days ago)
import XCPlayground
import AudioKit

let sampler = AKSampler()

sampler.loadWav("Sounds/TCM_Snare_4")

let ampedSampler = AKBooster(sampler, gain: 3.0)

AudioKit.output = ampedSampler
AudioKit.start()

AKPlaygroundLoop(every: 4) {
    sampler.playNote(60) // this should play the custom snare drum sound for about 2 sec but it
                                       // gets cut off midway and then continues after 1/4 sec
}

XCPlaygroundPage.currentPage.needsIndefiniteExecution = true

Any idea why this would happen?
It works for samples that are shorter, but not for longer drawn out samples.
Thank you for any help with this :)

I'm thinking that maybe it's due to the higher frequencies involves in the snare sample. Because I have a kick sample that is similar in length that works fine....

The kick sample has much lower frequencies

It can't have to do with the content of the file, but it could be due to the encoding.
This wav file has sample rate of 48000Hz.  I wonder if the problem will go away if you use a 44.1kHz file?  Is the other file 44.1?

Hi Aure,
I'll check and see what the other sample frequencies are at.
Thank you for your help :)

Hi Aure,
What is the optimum bit depth for sampled sounds?

Infinity minus one!  :)  I think 16-bit is fine though.

Ha! Touché...
Ok, thank you:)
On Saturday, May 21, 2016, Aurelius Prochazka<EMAIL_ADDRESS>wrote:

Infinity minus one! :) I think 16-bit is fine though.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/audiokit/AudioKit/issues/383#issuecomment-220807409

--
Joshua Thompson
Firmware Engineer
Sonic Sensory Inc
Mobile:<PHONE_NUMBER>

Wondering what the status of this issue is...

Hi Aure,
Sorry, yes your suggested bit depth fixed our problem.
Thank you!


Wording for the "Proposal Status" needs to be changed

Currently, the SLC proposal status can be marked as completed, approved, or pending. This wording is confusing and needs to be changed to where they are all in the same tense. Approved is good, but pending and completed could use some rewording.

Completed is past tense like approved. Not sure if pended sounds any better than pending. What did you have in minde?

@lodenrogue  agree

The issue was worded poorly. The tense isn't the major issue. The issue is the fact that "Completed" doesn't convey what that means: the proposal is completed, or the approval process is completed? Same with Pending... is the proposal pending approval, or is the proposal incomplete (i.e., pending its own completion).
There are three states of an SLC proposal that need captured with the correct term:

the proposal has not been completed by the faculty member(s), and is in a saved state (pre-submitted)
the proposal has been completed by the faculty member(s), and is awaiting approval by CELTS staff
the proposal has been approved by the CELTS staff

Currently on the whiteboard we have proposed these 3 statuses:
1 - Incomplete (also talked about In-Progress)
2 - Submitted
3 - Approved

PR merged, closing issue.


Impact Values not Updated for Google cloud

Hello,
Please note that impact values are not updated on  codecarbon/data/cloud/impact.csv
Find updated values in : https://cloud.google.com/sustainability/region-carbon?hl=fr
thank you.

Hi,
the values for AWS are also not up to date updated values are here below the Map:
https://sustainability.aboutamazon.com/environment/the-cloud?energyType=true#renewable-energy-map
thanks

Hi all, if no one has picked up this. I wouldn't mind having ago

Hi I created a branch and I update the google values (here https://github.com/mlco2/codecarbon/tree/UpdateData/codecarbon/data/cloud ) . If you have more recent values for aws and azure feel free to update the datas too 😄

We just opened the PR https://github.com/mlco2/codecarbon/pull/350
GCP data has been updated from https://github.com/GoogleCloudPlatform/region-carbon-info/tree/main/data/yearly
If you could not find Azure or AWS data, I think we could switch to the country data in https://github.com/mlco2/codecarbon/blob/master/codecarbon/data/private_infra/global_energy_mix.json


pull request for e2e test at 01/28/2017 01:45:20

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add HuggingFacePipeline LLM

https://github.com/hwchase17/langchain/issues/354
Add support for running your own HF pipeline locally. This would allow you to get a lot more dynamic with what HF features and models you support since you wouldn't be beholden to what is hosted in HF hub. You could also do stuff with HF Optimum to quantize your models and stuff to get pretty fast inference even running on a laptop.

#354
Add support for running your own HF pipeline locally. This would allow you to get a lot more dynamic with what HF features and models you support since you wouldn't be beholden to what is hosted in HF hub. You could also do stuff with HF Optimum to quantize your models and stuff to get pretty fast inference even running on a laptop.
Let me know if you want this code and I will clean it up.

want it? i need it!
but in all seriousness, i love it, and i know others will as well (has been a common ask) - thank you!!!

@hwchase17 Last issue I am having is that the integration tests now require torch to be installed for HF pipelines to run. I am trying to add it to poetry but I might do it incorrectly. Any examples of that I can look at?

So I added torch to the pyproject.yaml and am still seeing errors for torch missing in the poetry environment. Not really sure if I'm missing something or not.
test_huggingface_pipeline.py::test_huggingface_pipeline_text_generation FAILED [100%]None of PyTorch, TensorFlow >= 2.0, or Flax have been found. Models won't be available and only tokenizers, configuration and file/data utilities can be used.

@hwchase17 One last time!

ah very close! just some lint. lmk if you want me to tackle
hoping to get this in release tmrw. whats your twitter? want to give you a big shoutout

@hwchase17 got it. take a look.
I have no twitter but definitely shout out my company's socials https://twitter.com/YouSearchEngine


Rename protobuf benchmarks dir to benchmark

"benchmarks" directory is causing this warning when publishing packages:
Rename the top-level "benchmarks" directory to "benchmark".
The Pub layout convention is to use singular directory names.
Plural names won't be correctly identified by Pub and other tools.
See https://dart.dev/tools/pub/package-layout.

Closes #106

Could also move them out of the package and to the top-level of the repo. Really no need to publish these.

Make sense. Do you have any naming suggestions? We have query_benchmark, api_benchmark. Not sure what to call these benchmarks.

@sigurdm moving benchmarks to top-level will also simplify golem config. Do you have any naming suggestions for these benchamrks?


method add

moment('2017-12-10').add(9,'days')
the result  is wrong

Could you provide more information?

I recommend reading more of the documentation.
https://momentjs.com/docs/#/displaying/format/
Try comparing
moment('2017-12-10').format()

with
moment('2017-12-10').add(9,'days').format()

Thanks, But this way is so trouble， do you think so?

It all depends on what you are trying to do.
There are some guides available here: https://momentjs.com/guides/


How to use it? Is it publicly available?

Hello,
I would love to play around with this client but at the moment I have no idea how.
I configured my .env file as follows
RPC_URL=https://polygon-mumbai.infura.io/v3/infuraidentifirer
PK=0xMY_PRIVATE_KEY
CLOB_API_KEY=
CLOB_SECRET=
CLOB_PASS_PHRASE=
CLOB_API_URL=https://clob.polymarket.com/

I left CLOB_API_KEY, CLOB_SECRET and CLOB_PASS_PHRASE blank.
Then I tried to run createApiKey.ts and I'm getting 405 Method Not Allowed.
What am I missing?

Hi @arekgotfryd, the production CLOB API is geoblocked. You are welcome to use the staging API, which runs on Mumbai testnet at https://clob-staging.polymarket.com.
See the polymarket clob documentation for more details(contract addresses, endpoints, etc): https://polymarket.gitbook.io/clob/#rest-endpoint


feat(image_projection_based_fusion, roi_cluster_fusion): roi and obstacle fusion method

Description
I plan to add a feature roi_detected_object_fusion to fuse ROIs from images and Detected Objects,  but the most of the implementation is the same as roi_cluster_fusion. Therefore, I created a new package image_projection_based_fusion  and it has these two packages.
roi_cluster_fusion:

The latest tf is used to transform from the frame_id of a cluster to that of an ROI. I changes to use tf at the stamp of a ROI.

roi_detected_object_fusion:

The fusion algorithm is the same as roi_cluster_fusion, except that a classification label of a detected object doesn't have UNKNOWN.

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author
PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
Reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has the write access can merge the PR.

I changed to draft

Might take some time to review.

I found that 2d-3d projeciton fails on some images, so I'll fix it.

The PR to launcher is created at https://github.com/tier4/autoware_launch/pull/274


Fix popup windows content margins

Closes https://github.com/godotengine/godot/issues/89718
This does 2 things:

Makes AcceptDialog use margins that scale with the editor scale to support HiDPI displays

Unifies all of the popup margins in the editor by decreasing the margins of the Project/Editor Settings popups and increasing them for AcceptDialogs, making them meet halfway at the same value

Visual comparison (default theme, 1.5 editor scale):
Before:

After:

@AThousandShips this isn't macos-specific as I originally thought, this is HiDPI-specific. The linked issue just wasn't updated

Increased the margin multiplier to make sure buttons align perfectly vertically when using the default base margin value. It's a bit of a magic number but it's best to change the multiplier for popups instead of the base margin value so that only popups are affected with this change

Tested this with both high and low dpi, both with custom and the default theme

but this may need to be handled in its own PR

Yeah tbh I've been kind of ignoring the existence of compact mode so far because iirc the plan was to first introduce those spacing presets in one PR and then make them look not broken at a later point (which never happened so compact mode now has 0px margins all over the place). By the look of it compact mode will need a big amount of work, so I'm wondering if the spacing presets will need to be re-evaluated to better understand how they fit into future plans, especially for 4.4 in case any UI/theme related changes are planned
CC @coppolaemilio @adamscott

Thanks!


Fix for issue #196

Works for me, but I barely know what I'm doing ;)

r? @BurntSushi

Awesome, thank you for fixing this! I'll put out a new release now.

OK, docopt_macros 0.6.86 is on crates.io. Thank again, I really appreciate it!

Thanks for the quick review & merge & crate update!


What am I doing wrong to get this error? DPAPI NG (With SID)

From @eyrenshaw on Monday, March 13, 2017 4:54:27 PM
I must be missing something with this setup.  Any ideas would be appreciated!
I have 2012 R2 server.
I see my SID on that server (S-1-5-21-606747145-1060...)
The share location for the key (I have full rights to the location)
I setup the following in code:
`var serviceCollection = new ServiceCollection();
serviceCollection.AddDataProtection().PersistKeysToFileSystem(new DirectoryInfo(sharedKeyDirectory))
.ProtectKeysWithDpapiNG("SID=S-1-5-21-606747145-1060...", DpapiNGProtectionDescriptorFlags.None).SetApplicationName("myApp");
        return serviceCollection.BuildServiceProvider();`

Not matter what I do I get the following error:
System.Security.Cryptography.CryptographicException: Encryption failed.
at Microsoft.AspNetCore.Cryptography.UnsafeNativeMethods.ThrowExceptionForNCryptStatusImpl(Int32 ntstatus)
at Microsoft.AspNetCore.DataProtection.Cng.DpapiSecretSerializerHelper.ProtectWithDpapiNGCore(NCryptDescriptorHandle protectionDescriptorHandle, Byte* pbData, UInt32 cbData)
at Microsoft.AspNetCore.DataProtection.Cng.DpapiSecretSerializerHelper.ProtectWithDpapiNG(ISecret secret, NCryptDescriptorHandle protectionDescriptorHandle)
at Microsoft.AspNetCore.DataProtection.XmlEncryption.DpapiNGXmlEncryptor.Encrypt(XElement plaintextElement)
at Microsoft.AspNetCore.DataProtection.XmlEncryption.XmlEncryptionExtensions.EncryptIfNecessary(IXmlEncryptor encryptor, XElement element)
at Microsoft.AspNetCore.DataProtection.KeyManagement.XmlKeyManager.Microsoft.AspNetCore.DataProtection.KeyManagement.Internal.IInternalXmlKeyManager.CreateNewKey(Guid keyId, DateTimeOffset creationDate, DateTimeOffset activationDate, DateTimeOffset expirationDate)
at Microsoft.AspNetCore.DataProtection.KeyManagement.XmlKeyManager.CreateNewKey(DateTimeOffset activationDate, DateTimeOffset expirationDate)
at Microsoft.AspNetCore.DataProtection.KeyManagement.KeyRingProvider.CreateCacheableKeyRingCore(DateTimeOffset now, IKey keyJustAdded)
at Microsoft.AspNetCore.DataProtection.KeyManagement.KeyRingProvider.Microsoft.AspNetCore.DataProtection.KeyManagement.Internal.ICacheableKeyRingProvider.GetCacheableKeyRing(DateTimeOffset now)
at Microsoft.AspNetCore.DataProtection.KeyManagement.KeyRingProvider.GetCurrentKeyRingCore(DateTime utcNow)
at Microsoft.AspNetCore.DataProtection.KeyManagement.KeyRingProvider.GetCurrentKeyRing()
at Microsoft.AspNetCore.DataProtection.KeyManagement.KeyRingBasedDataProtector.Protect(Byte[] plaintext)
at Microsoft.AspNetCore.DataProtection.DataProtectionCommonExtensions.Protect(IDataProtector protector, String plaintext)
Copied from original issue: aspnet/DataProtection#205

From @natemcmaster on Thursday, May 4, 2017 12:48:45 PM
@eyrenshaw I'm able to reproduce the error too. Unfortunately, "Encryption failed" is a generic error that often hides another problem. To make sure we are both seeing the same error, can you provide more information from Windows logging?

Launch Event Viewer from Start Menu > Administrative Tools > Event Viewer.
The ncrypt logger is found in Event Viewer > Application and Services Logs > Microsoft > Windows > Crypto-NCrypt > Operational.
Right click on "Operational" and select "Enable log" from the context menu.
Re-run your .NET app that produces the error.
One or more errors should appear in the logger when you click "Refresh".

Any additional info you can share from this logger will help us be sure we've traced down the source of the issue. My logger shows two errors. The first one ("Protect Secret operation failed", return code 0x80090034) is the generic error that .NET is throwing. The second error is the real issue that was wrapped by the first. In my repro, it's "Protect Key operation failed.", return code 0x80070005. I'm still investigating a fix for this, but want to make sure this is the same thing you are seeing.
Don't forget to disable the logger after you're finished. (Right click on "Operational" and select "Disable log")

From @eyrenshaw on Thursday, May 4, 2017 4:36:41 PM
Hi Nate,
Yes I am seeing the same thing in the event logs:
First event ---
Protect Key operation failed.
Cryptographic Parameters:
Protector Name:        SID
Protector Attributes:
S-1-5-21-60674714...
Flags:         0x40
Failure Information:
Return Code:   0x8007054B
Second event ---
Protect Secret operation failed.
Cryptographic Parameters:
Flags:       0x40
Failure Information:
Return Code: 0x80090034
Thank you for taking a look. It will be great to get this working.

From @natemcmaster on Thursday, May 4, 2017 5:00:00 PM
Thanks. The error code you're getting (0x8007054B) is ERROR_NO_SUCH_DOMAIN. Can you tell me more about your domain infrastructure? i.e. what type of domain controllers do you have and how many? what's the domain environment? Are you able to ping the domain controller from the box that produces this error?

From @comburo on Wednesday, June 21, 2017 5:31:39 AM
I'm seeing the same issue.
I am able to ping the domain controllers, but I know little else about the domain configuration, since that is handled outside my team. I know the domain works for this server, because I can log in with my domain account and it runs on of our applications that runs under domain credentials and allows people to log in using their domain credentials.

From @j-tee on Friday, June 23, 2017 9:52:45 AM
Just got into a similar difficulty here. Wished you had found a solution

From @carl-thomas on Monday, July 3, 2017 9:30:43 AM
I am trying to use a certificate and I get the following error in the Event Viewer NCrypt log
Protect Key operation failed.

 Cryptographic Parameters:
 	Protector Name:	CERTIFICATE
 	Protector Attributes:
			HashId:***
 	Flags:		0x40
 Failure Information:
 	Return Code:	0x80090005

Protect Secret operation failed.

 Cryptographic Parameters:
 	Flags:		0x40
 Failure Information:
 	Return Code:	0x80090034

This error is not very descriptive. What is this error telling me? It cannot read the certificate? The certificates private key? It just failed during encryption??
Can anyone help?

This is really old, but it looks like this is a bug in Windows unfortunately, so we await a fix from them


Update an existing codebase after Tokio reform

Recently the tokio-rs crate was reformed so that existing APIs was changed. Therefore, for avoiding a broken pathfinder app, necessary to apply a new changes to Tokio:

Replace in Cargo.toml file the tokio-core crate onto  the tokio crate
Remove deprecated parts of code with setting up the event loop via tokio_core::reactor::Core
and replace it onto tokio::executor::current_thread task executor instead
Make ensure that &handle as a part of old Core functionality won't broke the existing code (for example, when we're using middlewares)

Done in pull request #12


Alpha

:tada: This PR is included in version 3.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.2.2-alpha.1 :tada:
The release is available on npm package (@alpha dist-tag)
Your semantic-release bot :package::rocket:


what is wireframe-10iters.yaml like, how can I set my dataset?

In [docs/HAWPv3.train.md], there is code:
python -m hawp.ssl.homoadp-bm --metarch HAWP-heatmap \
    --datacfg hawp/ssl/config/exports/wireframe-10iters.yaml \
    --workdir exp-ssl/hawpv3-round0 \
    --epoch 10 \
    --modelcfg exp-ssl/hawpv3-round0/model.yaml \
    --min-score 0.75   --batch-size=16

but I can't find hawp/ssl/config/exports/wireframe-10iters.yaml, what is this file?

Hi @bluove, I have pushed the related files in this directory


feat: install starship bash prompt in dx

Installs the Starship prompt by default, for all users - without needing to mess with any justfiles.
Only possible issue is it's not easy to disable this.
Keen to hear ideas for if/how to improve this.

This breaks global aliases.  Will investigate other ways to do this

How do we turn it off? I can just add the instructions to the docs. Also thinking it might be easier long term to just have it as the default for non dx too?

How do we turn it off? I can just add the instructions to the docs. Also thinking it might be easier long term to just have it as the default for non dx too?

If you comment it out / remove it from bashrc it will turn off.

But what will happen, if it will try to load starship, after some bashrc edit from the user, which will overide the default config. You will end up with an error opening the terminal bash: starship: command not found if you switched from bluefin-dx to bluefin for example.

What I have done to solve that in another image is configure my main's /etc/bashrc to source all shell scripts from /etc/bashrc.d (similar to profile.d) and the eval is added to a /etc/bashrc.d/starship.sh.  No need for anybody to edit that one.
Thought it's too many changes to bring over here without a discussion

That is a neat solution, good to know! But maybe enabling it for all variants is easier in the end tho :smiley:


vimPlugins.luvit-meta: init at 2024-01-20

Description of changes
Add vimPlugins.luvit-meta.
https://github.com/Bilal2453/luvit-meta/
Some more context, I ran into this repo as a dependency while trying to use the lazydev.nvim plugin which is already available in nixpkgs as vimPlugins.lazydev-nvim.
I used vim-plugins-updater add to insert this entry. Should I also run vim-plugins-updater itself to generate the generated.nix change too? I wasn't sure if that was going to attempt to update all plugin revs.

Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Should I also run vim-plugins-updater itself to generate the generated.nix change too? I wasn't sure if that was going to attempt to update all plugin revs.

It will, just commit only changes related to this plugin (as it is done in other PRs: 1, 2, 3)

Looks good to me, but are you sure that this is actually a vim plugin ?
Have you been able to successfully test it locally ?

The lua code seems to load correctly when its pushed on to the vim rtp. That said, I don't know if it's better organized in nixpkgs along with other lua packages rather than under vimPlugins namespace.

The lua code seems to load correctly when its pushed on to the vim rtp. That said, I don't know if it's better organized in nixpkgs along with other lua packages rather than under vimPlugins namespace.

Probably under luaPackages. then. What do you think @teto ?

if it worked like this then this is fine and we can merge. It seems to be just definitions, not a library. It has no rockspec, is not on luarocks.org either.


add search index to whisks database in Cloudant

PG 171

Any idea whether this is actually Cloudant-specific or generally supported by CouchDB installations?
The TravisCI log (where we run CouchDB) says:

[exec] Create Cloudant Query search index
[exec] {"error":"bad_request","reason":"Referer header required."}

superseded by #130


feature: add support for named constructors

Adds support for named constructors in "create" factory.
I would love to add tests, but I did not find tests for the "create" factory itself.
This PR also allows "hack" where not-a-module is passed as module. It can be then used as factory. Maybe name of "constructorName" option should reflect this, and be "method" instead? And add "factory" as an alias for "module"?

Thanks, @OJezu!  I should have time to look at this in the next couple days.

This looks good @OJezu.  Could you add unit tests for the new namedConstructor feature?  Thanks!

@briancavalier I will get on those tests in a two-three days.

Great, thank you.

@briancavalier I've added tests. I might have been a little drunk when writing them, so I am even more open to criticism than usual.
I've also added some more recent versions of node.js to .travis.yml, I hope it's not a problem.

@OJezu great, thank you.  I'll take a look in the next couple days.

Tests look good, @OJezu, thank you!

I've also added some more recent versions of node.js to .travis.yml, I hope it's not a problem.

Not a problem at all.  I appreciate it.

I'll get a release ready soon.


Make watchers subscribe to the store earlier

Just to reproduce an issue we've experienced while using two watchers on the same query.

After some slack discussion, we realized this is a race between 2 coroutines:
coroutine1:

get R2-D2
emit R2-D2
subscribe to cache changes

coroutine2:

get Artoo
emit Artoo
publish Artoo change

What happens when the bug happens is that the coroutine2 publishes the changed keys before coroutine1 has a chance to subscribe to the store. This has very little chances of happening with a real network but is happening in tests because the network is mocked with a synchronous implementation.
I slightly modified the runtime to subscribe to the store before emiting the first item in a watch. This way, coroutine 2 can use the first item as a synchronisation point before starting the "Artoo" request.
Many thanks @olivierg13 for catching and troubleshooting this 💙

Thanks for the throrough investigations! Looks good to me! 😃

Heads up we had to change the implementation of this a bit to support the CacheAndNetwork fetchPolicy: https://github.com/apollographql/apollo-kotlin/issues/3946
I think the buffer(2) should still allow these tests to pass but let us if you notice anything weird

Sounds good thanks!
Which version are these new changes gonna be included onto?

3.1.1+ (most likely going to be a 3.2.0 but not 100% sure yet)


Problem sending any transaction - 2 hours and nothing

I can receive transactions, but i cannot send any amounth out.  0/unconfirmed, in memory pool, broadcast through 7 nodes.
Windows wallet - Recomended fee
I was waiting 2 hours and nothing

Same problem. I can not send any transactions. I tried to put different commissions up to 1NIX per kilobyte.

finally tx came through it took 3 hours

The problem is the place to be! Outgoing transactions from the NIX Windows wallet do not work (v.1.0.1)!

Status: 0/unconfirmed, in memory pool, broadcast through 21 nodes
Date: 29/06/2018 22:27 now it 1:18 and transaction didn't came through v.1.0.1

Update 1.0.2 fixes transaction broadcast issues fully.


Install RMolNetEnhancer

Dear Mr/Mrs. Madeleineernst,
I would like to install RMOLNETENHANCER by using the Anaconda program with Jupyter Notebook.
Could you guide me on how to install the RMOLNETENHANCER step by step.
Thank you very much for your help!
Best regard,
DDLe.

Dear Mr/Mrs. Madeleineernst,
I would like to install RMOLNETENHANCER by using the Anaconda program with Jupyter Notebook.
Could you guide me on how to install the RMOLNETENHANCER step by step.
Thank you very much for your help!
Best regard,
DDLe.


Compilation failure against YARP master (future YARP 3.8) November 2022

In YARP 3.3 (released in 2019) the following headers where deprecated (see https://www.yarp.it/latest/v3_3_0.html#autotoc_md512):

Deprecated Header
Replacement

yarp/dev/SerialInterfaces.h
yarp/dev/ISerialDevice.h

yarp/dev/PreciselyTimed.h
yarp/dev/IPreciselyTimed.h

yarp/dev/GenericSensorInterfaces.h
yarp/dev/IGenericSensor.h

yarp/dev/Wrapper.h
yarp/dev/IWrapper.h and/or yarp/dev/IMultipleWrapper.h

However, the inclusion of the deprecated headers, so probably the deprecation went unnoticed. However, in YARP master branch (future YARP 3.8) the headers were removed, so it would be great to remove the use of this deprecated headers, as it has been detected that this repo is using those headers.
Cross-ref : https://github.com/robotology/robotology-superbuild/issues/1303

After the finals, we had a bunch of modifications on the code. Before moving on and fixing this, I would merge the code for the finals. Is that ok?

After the finals, we had a bunch of modifications on the code. Before moving on and fixing this, I would merge the code for the finals. Is that ok?

Ok! I would probably temporary disable the WALKING_TELOPERATION from Unstable's tags CI in that case.

Related PR: https://github.com/robotology/walking-teleoperation/pull/118


RolloTron-Basis-DuoFern-1200 open/close not possible

Hello,
I was able to pair my RolloTron-Basis-DuoFern-1200. The state is reported correctly (position and state), but open_cover and close_cover is not working. I don't see any error in the logs.
How I can troubleshoot that?

It is expected, that I don't see 0.2.0-beta in HACS? Should I deploy it manually?

@tringler yes, running pyduofern directly will let you talk to the shutters more directly, and allows you to produce more debug log. (It is also possible to enable debug level logging in homeassistant for specific modules, but I guess playing with a second pi is favourable if has that option).
One possible software-unrelated cause for the behaviour that you observe was reported by another user in the past: his stick was positioned just at the edge of RF range. This lead to the effect that the stick was able to reliably receive status messages from the shutters but commands were not transferring reliably to the shutters. So with your second pi I would suggest running the experiment not too far from the shutter to exclude RF range as the cause of the issue.

What's the status on this? Given that there was no activity for a few months I will close this next time I come by in a few weeks/months unless anyone has opposed this by then.

What's the status on this? Given that there was no activity for a few months I will close this next time I come by in a few weeks/months unless anyone has opposed this by then.

@tringler any update? I use a lot of those 1200 devices and they work pretty well (in regards to the commands focused in this issue).

Sorry for the huge delay! I tried it successfully with the pyduofern on another Raspberry successfully. After that I tried it again on the HACS integration and the problem went away.


fix(actions): allow creating a release

include the permission to write to contents to allow writing artefacts to a release
more info https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions

Good fix!


TcpStream & TcpListener rely on internals

I'm working on UDS support for Windows. I hope to start with my own mio-uds-windows crate and maybe get it merged into mio-uds at some point. I'm new to all this so I'm probably missing something obvious, but I've had a really hard time finding a good starting point for my Windows UnixStream and UnixListener.
The obvious choice was to start with mio's TcpStream and TcpListener. But I can't build them outside of the mio codebase. They make use of SelectorId, which isn't public. I can make a copy of the SelectorId code, but it accesses the private selector field on Poll. Also, they wrap the public mio::windows::Binding with ReadyBinding. When I copy that type, it won't build because it accesses the private selector field to get/put buffers down in BufferPool.
I could start from mio-named-pipe, but it only implements the stream not the listener, it doesn't implement read_bufs/write_bufs (even if it did, it wouldn't be able to use the internal BufferPool), and it preallocates memory and does an extra copy for reads (8K).
Anyway, I'm wondering if it would be possible to extricate TcpStream and TcpListener in such a way that they make a good example for other streams and listeners, but without breaking things?

Sorry for the delay. It looks like you found a work around? I'm not entirely sure I follow the original question.
In general, the windows impl strategy is most likely going to significantly change in the future. I expect we will use a strategy similar to http://github.com/piscisaureus/wepoll.

@carllerche Yes I found a workaround, although it's not something we want to stick with long-term.
@arsing describes the problem more succinctly in this comment on alexcrichton/mio-uds#7.

@carllerche
The problem we're trying to solve is that we want mio-uds and downstream crates to support Unix Domain Sockets on Windows. Currently we have a hacky way of doing this that involves duplicating a lot of code from libstd, mio and mio-uds into https://github.com/Azure/mio-uds-windows and using [replace] to swap out mio-uds for that repo. But we want to work out a way to upstream this into mio-uds in the long term.
As Damon mentioned in the OP of this issue and I wrote in https://github.com/alexcrichton/mio-uds/issues/7#issuecomment-473412700, the mio::windows::TcpListener and TcpStream encapsulate working with IOCP and buffer pools but this functionality is not separately exposed by mio::windows. So it's not possible to write a listener and stream in mio-uds that can also use the system selector in the same way without duplicating all that code.
I wanted to see if it was possible to abstract out the internals of TcpListener and TcpStream that are not TCP-specific into a separate public type, that can then be parameterized to work with mio's TCP types and mio-uds's UDS types.
That change is here. It creates a bunch of new traits that can be implemented by any SOCKET-based listener and stream type outside mio, and two new SocketListener<TListener: Listener> and SocketStream<TStream: Stream> types that contain the bulk of generic functions that TcpListener and TcpStream used to have but are not specific to TCP sockets.
With this, mio-uds can have
struct UnixListenerImp;

impl mio::windows::Listener for UnixListenerImp { ... }

struct UnixListener {
    inner: SocketListener<UnixListenerImp>,
}

struct UnixStreamImp;

impl mio::windows::Stream for UnixStreamImp { ... }

struct UnixStream {
    inner: SocketStream<UnixStreamImp>,
}

What do you think of this approach? Would it be something that can be merged into mio 0.6 ? Is there a better way of doing this?

@arsing Yes, right now a lot of mio's internals have to be copied out, which is not great.
I would like to re-implement Mio's windows support using the wepoll strategy. Once this happens, socket types will be able to use the regular non-OVERLAPPED Winsock API. This will make things much easier.

Right. As I said in our email conversation, if the wepoll implementation results in an EventedSocket just like the existing EventedFd, then it should make the mio-uds part trivial.

@carllerche I ran into the need for wepoll/epoll/kqueue myself, as part of my work on Inko. Since MIO has various issues with Windows, and the API isn't stable (and seems to be scheduled for lots of changes based on the various issues), I ended up writing my own wrappers around these libraries. For epoll and kqueue I used the nix crate, but for wepoll I had to write my own wrappers:

https://crates.io/crates/wepoll-binding: safe bindings to wepoll
https://crates.io/crates/wepoll-sys: raw bindings to wepoll

The wepoll-sys crate bundles the wepoll code and compiles it upon installation, as I don't have the time and resources to port the code to Rust. The wepoll-binding crate provides a safe interface around wepoll-sys. The safe bindings are fairly lightweight, and the API is based on (and should feel similar to) MIO. Using these crates might be useful for MIO, and I'm happy to review any patches MIO might need to make things work.
p.s. should MIO be interested in using these crates, it might be worth renaming wepoll-binding to just wepoll, but that name is currently reserved.

If I'm reading this correctly basically this issue asking for a SourceFd (previously EventedFd) equivalent for Windows. This is on the list of item to after the rewrite of the Windows implementation, see #1041. @damonbarry, @arsing could you share your ideas on how that should look for your use cases?

If I'm reading this correctly basically this issue asking for a SourceFd (previously EventedFd) equivalent for Windows.

That's right; see https://github.com/tokio-rs/mio/issues/880#issuecomment-478139530
It would presumably be SourceSocket and wrap a SOCKET. I would guess wepoll makes the event::Source impl identical for both.
Then the UDS side can forward to SourceSocket just like the existing mio-uds forwards to EventedFd today.

I'm not a Windows guy, but would also need a wrapper around a HANDLE then (for files if I'm correct)? Although I'm not sure if there is any non-blocking filesystem stuff on Windows.

The wepoll approach won't work for file HANDLEs. It only works for things managed by the AFD driver.

Now that #1064 is merged I'm working on this, I intend to provide a SourceFd like abstraction for at least socket (and maybe handles if that is possible).

@Thomasdezeeuw what would this look like? I'm not sure how something like that would work for windows, except maybe: https://github.com/tokio-rs/mio/issues/1047

@carllerche my current idea is to add a wrapper type that adds InternalState and change all net types to use the new type, just like on Unix. The only problem is re-registering on would block errors. Currently this is on done in try_io, I was think about adding method do_io that would replicate the macro.

oh, you mean an internal refactor?

Yes, but also make the wrapper type public.

I've created #1183, I don't really like the API but it follows SourceFd. We should discuss in #1183, but maybe we should consider making the fd/socket owned.

I'm just not sure how we can make the wrapper type public. It is pretty specific. I would love to hear your planned strategy.

@carllerche I already implementation something here: https://github.com/tokio-rs/mio/pull/1183/files#diff-2ace2cbf884d3de3ae825a07c3e5bffdR101. Usage in UdpSocket: https://github.com/tokio-rs/mio/pull/1183/files#diff-c9ef904d3020aa1431eaa718ee98c307R153-R154.
But like I said I don't really like the API as its rather fragile to use, but its modelled after SourceFd.

Right, I see how you could model an abstraction that is used across TCP & UDP internally. I just don't see how it can become a public API.

This isn't going into alpha1.

We still don't have a good solution for this, but I want to release v0.7 so punting this to v1.

This is not going to block a v1.0 release.

This is not going to block a v1.0 release.

We're keeping the current AFD based implementation, so there isn't anything to do here.

We're keeping the current AFD based implementation, so there isn't anything to do here.


Don't work search in HashModels

My model:
class Customer(HashModel):
    first_name: str
    last_name: str
    join_date: datetime.date
    age: int
    bio: Optional[str]

    class Meta:
        database = redis_connection

[x] Save customer (it work):

andrew = Customer(
        first_name="Andrew",
        last_name="Brookins",
        join_date=datetime.date.today(),
        age=38,
        bio="Python developer, works at Redis, Inc."
    )
andrew.save()

[x] Get customer by pk (it work):

andrew_in_redis = Customer.get("01GQ73JNMTA3Q4MYY2V79E7V5X")
print(andrew_in_redis)

[ ] Find customer by first_name (it doesn't work):

andrew_in_redis = Customer.find(Customer.first_name == "Andrew").all()
print(andrew_in_redis)

Result:
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/starlette/middleware/errors.py", line 162, in __call__
    await self.app(scope, receive, _send)
  File "/usr/local/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 79, in __call__
    raise exc
  File "/usr/local/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 68, in __call__
    await self.app(scope, receive, sender)
  File "/usr/local/lib/python3.11/site-packages/fastapi/middleware/asyncexitstack.py", line 21, in __call__
    raise e
  File "/usr/local/lib/python3.11/site-packages/fastapi/middleware/asyncexitstack.py", line 18, in __call__
    await self.app(scope, receive, send)
  File "/usr/local/lib/python3.11/site-packages/starlette/routing.py", line 706, in __call__
    await route.handle(scope, receive, send)
  File "/usr/local/lib/python3.11/site-packages/starlette/routing.py", line 276, in handle
    await self.app(scope, receive, send)
  File "/usr/local/lib/python3.11/site-packages/starlette/routing.py", line 66, in app
    response = await func(request)
               ^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/fastapi/routing.py", line 236, in app
    raw_response = await run_endpoint_function(
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/fastapi/routing.py", line 164, in run_endpoint_function
    return await run_in_threadpool(dependant.call, **values)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/starlette/concurrency.py", line 41, in run_in_threadpool
    return await anyio.to_thread.run_sync(func, *args)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/anyio/to_thread.py", line 31, in run_sync
    return await get_asynclib().run_sync_in_worker_thread(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/anyio/_backends/_asyncio.py", line 937, in run_sync_in_worker_thread
    return await future
           ^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/anyio/_backends/_asyncio.py", line 867, in run
    result = context.run(func, *args)
             ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/python/app/auth/routes.py", line 42, in check_code
    andrew_in_redis = Customer.find(Customer.first_name == "Andrew", Customer.age==38).all()
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/redis_om/model/model.py", line 1212, in find
    return FindQuery(expressions=expressions, model=cls)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/redis_om/model/model.py", line 350, in __init__
    if not has_redisearch(model.db()):
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/redis_om/checks.py", line 25, in has_redisearch
    if has_redis_json(conn):
       ^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/redis_om/checks.py", line 17, in has_redis_json
    command_exists = check_for_command(conn, "json.set")
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/redis_om/checks.py", line 9, in check_for_command
    cmd_info = conn.execute_command("command", "info", cmd)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/redis/client.py", line 1258, in execute_command
    return conn.retry.call_with_retry(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/redis/retry.py", line 46, in call_with_retry
    return do()
           ^^^^
  File "/usr/local/lib/python3.11/site-packages/redis/client.py", line 1259, in <lambda>
    lambda: self._send_command_parse_response(
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/redis/client.py", line 1235, in _send_command_parse_response
    return self.parse_response(conn, command_name, **options)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/redis/client.py", line 1285, in parse_response
    return self.response_callbacks[command_name](response, **options)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/redis/client.py", line 553, in parse_command
    cmd_name = str_if_bytes(command[0])
                            ~~~~~~~^^^
TypeError: 'NoneType' object is not subscriptable

Why it doesn't work? Am I doing something wrong?

Ensure you have rejson and redisearch modules enabled.
If you use docker, you can use the one from here:
https://hub.docker.com/r/redis/redis-stack-server

Ensure you have rejson and redisearch modules enabled. If you use docker, you can use the one from here: https://hub.docker.com/r/redis/redis-stack-server

what if i don't use Docker? i use heroku dynos for my flask api to run and i wan to migrate my db from postgres to redis. how can i enable redisearch module?

Ensure you have rejson and redisearch modules enabled. If you use docker, you can use the one from here: https://hub.docker.com/r/redis/redis-stack-server

what if i don't use Docker? i use heroku dynos for my flask api to run and i wan to migrate my db from postgres to redis. how can i enable redisearch module?

Refer to the redis modules docs. You'll have to compile modules from source.
I personally found this to be a headache and settled on using the docker container system.

You can install redis-stack from a variety of different sources, include Redis Cloud.


Update release-java.yml

Codecov Report
Base: 21.75% // Head: 13.15% // Decreases project coverage by -8.59% :warning:

Coverage data is based on head (6d5ad38) compared to base (0304f27).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #572      +/-   ##
============================================
- Coverage     21.75%   13.15%   -8.60%
  Complexity       33       33
============================================
  Files            87       19      -68
  Lines         15554    11665    -3889
  Branches       1897     1897
============================================
- Hits           3383     1535    -1848
+ Misses        11864     9837    -2027
+ Partials        307      293      -14

Impacted Files
Coverage Δ

java/src/main/java/trinsic/okapi/OkapiNative.java
51.92% <0.00%> (-1.93%)
:arrow_down:

python/tests/okapi_demo.py

ruby/lib/okapi/keys/v1/keys_pb.rb

dotnet/Library/Okapi/Native.cs

ruby/lib/okapi.rb

ruby/lib/okapi/ld_proofs.rb

ruby/lib/okapi/metadata/metadata_pb.rb

go/okapi/native_call_windows.go

ruby/test/util_test.rb

go/okapi/oberon.go

... and 59 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Confirmed functional release. admin-merging


Day50: Power of Three - Recursion

Power of Three
https://leetcode.com/problems/power-of-three/
Given an integer n, return true if it is a power of three. Otherwise, return false.
An integer n is a power of three, if there exists an integer x such that n == 3x.

Example 1:
Input: n = 27
Output: true
Example 2:
Input: n = 0
Output: false
Example 3:
Input: n = 9
Output: true


getDescendances() and getAncestors() dont work

i'm trying to get access to all children of a root node using getDescendants() . but no child is fined and an empty array is returned. also getAncestors() doesn't return parent node of a child node

is there any method to get a complete array of all trees in table?

try all()

#214


[SPARK-32635][SQL][FOLLOW-UP] Fix foldable propagation

What changes were proposed in this pull request?
This is a follow-up PR to https://github.com/apache/spark/pull/29771 and just adds a new test case.
Why are the changes needed?
To have better test coverage.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
New UT.

cc @dongjoon-hyun, @maropu

Test build #128870 has started for PR 29802 at commit b3751da.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33492/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128870/
Test PASSed.

late LGTM, thanks, all!


New Claude Model just released

The Haiku model for Claude was just released. Good news, the model list implementation worked fine. We should update the backup array, it is not urgent though. Should I create a new PR or can we sneak it in another one? It's just this line of code.
"claude-3-haiku-20240307".to_string()

A short one liner PR would be totally fine :)


fix: UIView not supporting box-none ~> none

As mentioned in this issue but never PR'd;
https://github.com/Charanor/react-native-highlight-overlay/issues/3

Awesome :) sorry I haven't gotten to it sooner!


Remove expect/actual from enums that lack extra properties

As the title says. Quite some files changed, but the commits are self contained. So I recommend reviewing per commit to make sense of it all.

Closes SDK-3526

@tonidero It was actually a net-negative before I added the API dump. Let's see if we can keep that up 😄


feat: add idp templates

Adds Instance IDP Templates
Adds Org IDP Templates
Enables testing them with TF_ACC=1 TF_ACC_ZITADEL_TOKEN=<my_json_token> go test -v ./...
Makes them addable to login policies

@adlerhurst I've implemented the GitHub org and instance templates. Will roll them out now.
The PR is ready for an early review.


Allow java-saml to be used in non-JavaEE containers

Fixes #115
The default Auth and ServletUtils classes were previously tied to the javax.servlet APIs, so couldn't be used in other frameworks (e.g. Play).
Instead, introduce abstract HttpRequest and HttpResponse classes which can be used as wrappers around different request and response objects depending on the framework (plus default javax implementations).
A nice result of this is that Auth and ServletUtils can move to the core module - the toolkit jar now contains only the javax.servlet wrappers.

Coverage decreased (-0.3%) to 94.845% when pulling 89ce1571c4855d196660e784235c87c550ea0e03 on ashleymercer:master into 9274e6bc5601e5114b3fc6668d526a822aba9b66 on onelogin:master.

Coverage increased (+0.4%) to 95.544% when pulling<PHONE_NUMBER>44fa89f38c3d4ab255cee1ef5757d0 on ashleymercer:master into 9274e6bc5601e5114b3fc6668d526a822aba9b66 on onelogin:master.

That solution breaks environments that currently use HttpServletRequest and HttpServletResponse on Auth.

@pitbulk any update on this PR?  I'm finding myself in the same boat as @ashleymercer here.  Specifically, I'd like to pass my own version of com.onelogin.saml2.http.HttpRequest into com.onelogin.saml2.Auth, but Auth appears to be strongly tied to javax.servlet.
I'm having to implement my own skinny version of HttpServletRequest and pass that into Auth instead, which is effectively a wrapper on top of my underlying request object.  If I could only pass my own HttpRequest implementation into Auth that would get me most of the way there.

We need to find a solution compatible with current Auth API... so we need to
Since request and response attributes from the Auth class are private, I'm ok replacing then from HttpServletRequest/HttpServletResponse to HttpRequest/HttpResponse, but we need to
keep the way of initialize the Auth class with HttpServletRequest and HttpServletResponse objects, so be able to transform those objects on HttpRequest/HttpResponse objects.

@pitbulk I think it would be completely reasonable to add a few additional constructors to Auth that take a com.onelogin.saml2.http.HttpRequest and com.onelogin.saml2.http.HttpResponse instead of a HttpServletRequest and HttpServletResponse.
In other words, leave the existing constructors alone (for backwards compatibility sake), but add a means for consumers to pass their own HttpRequest and HttpResponse instances into a new set of Auth constructors.
I still contend though that definitions like HttpRequest and HttpResponse should be interfaces, not concrete classes.  Just looking at how java-saml uses the request and response, the toolkit only uses a small subset of methods defined by HttpServletRequest and HttpServletResponse.  I think it would be much cleaner if HttpRequest and HttpResponse were interfaces that defined only what java-saml needs from each entity, instead of requiring the consumer to pass around implementations of HttpServletRequest and HttpServletResponse.

@markkolich +1
We can't integrate java-saml with the Play Framework because of the Servlet API dependence...

As far as the solution keep compatible with the current Auth class, I'm open for merge it.

Hey, wondering if this can be used with play now?
I've seen the parameter "stay" which avoid writing to the response and instead just returns the url, is this enough to solve the problem?
https://github.com/onelogin/java-saml/issues/86

FWIW, I think https://github.com/SAML-Toolkits/java-saml/pull/395 now supersedes this PR


Import wallet

Need a label :label: “imported” or something on the wallet tile. We may have more in the future.
We can also simply use the description to say “Imported Wrapped Segwit”

Verified this issue on keeper app v 1.1.7(259)


Editing Size of the Text area

Hi,
I could see that the Text area size has been in Inline and I could not edit the css of the text-area. is there an alternative way to change the style ?

Hi,
Bootsy will reuse whatever style you add to your textarea element. You can a class, an id or anything also to apply the css you want.


As an HR advisor I want to produce a report on the salary of all employees so that I can support financial reporting of the organisation.

As an HR advisor I want to produce a report on the salary of employees in a department so that I can support financial reporting of the organisation.

As an department manager I want to produce a report on the salary of employees in my department so that I can support financial reporting for my department.

As an HR advisor I want to produce a report on the salary of employees of a given role so that I can support financial reporting of the organisation.

As an HR advisor I want to add a new employee's details so that I can ensure the new employee is paid.

As an HR advisor I want to view and employee's details so that the employee's promotion request can be supported.

As an HR advisor I want to update an employee's details so that employee's details are kept up-to-date.

As an HR advisor I want to delete an employee's details so that the company is compliant with data retention legislation.


Cannot read props on a component that uses v-repeat

So I'm trying to setup a slideshow. This is what I have so far:
<slider inline-template img-count="4">

		<sliderslide v-repeat="4" inline-template v-ref="slide">

		</sliderslide>

			<sliderthumb v-repeat="4" send-index="@{{ updateIndex }}" inline-template slide-index="@{{ $index }}" v-ref="thumb">

						Newest Product

			</sliderthumb>

</slider>

Of course I'm expecting to loop through my images with some back-end code. I'm using Laravel so I put @ before any brackets.
So far this is what I have for my javascript:
var Slider = Vue.component('slider', {
	template: '',

	data: function() {
		return {
			current: 0, // Current slide
			speed: 700, // Speed of animation to slide
			margin: 0, // The margin left on the entire slider container (to flip slides)
			count: 0, // How many slides are in this slider object
			thumbnailHeight: 200, // The height of the thumbnails
			slideWidth: '',
			width: '',
			height: '' // All populated in the ready method
		}
	},

	props: ['imgCount'],

	ready: function() {
		this.count = this.imgCount;
		this.slideWidth = this.$el.parentElement.offsetWidth;
		this.height = this.$el.parentElement.offsetHeight;
		this.width = this.slideWidth * this.count;

		var self = this;
		this.$.slide.forEach(function( slide ) {
			self.setSlideDimensions( slide );
		});

		this.$.thumb.forEach(function( thumb ) {
			self.setThumbDimensions( thumb );
		});
	},

	methods: {
		// Set default data
		setDefaults: function() {
			// Set width of slide
			var self = this;
			this.$children.forEach( function(slide) {
				self.setSlideDimensions( slide );
			});

			this.$set('sliderWidth', screen.width * this.count); // Set the width of the slider width
			this.$set('sliderHeight', screen.height); // Set the height of the slider
		},

		// Set slide width
		setSlideDimensions: function( slide ) {
			slide.width = this.slideWidth;
			slide.height = this.height;
		},

		// Size the thumbnails according to the screen
		setThumbDimensions: function( thumb ) {
			thumb.height = $('.thumbnails').height();
		},

		// Update index of current slide based on thumb clicked
		updateIndex: function( index ) {
			this.current = index; // Set current slide to thumbnail img clicked
			this.margin = this.slideWidth * (index); // Set margin how many pixels it should move to the left

			this.animateSlides(); // ANIMATE SLIDES
		},

		// Animate slides to move based on margin
		animateSlides: function() {
			var self = this;

			$('.slides').animate({
				'margin-left': '-' + self.margin
			}, self.speed, function() {
				// If the current slide is the amount of slides
				if( self.current === self.count )
				{
					// Reset slider
					self.current = 1;
					$('.slides').css('margin-left', 0);
				}
			});
		}
	}
});

var SliderThumb = Vue.component('sliderthumb', {
	template: '',

	data: function() {
		return {
			height: 200
		}
	},

	props: ['slideIndex', 'sendIndex'],

	ready: function() {},

	methods: {
		handleClick: function(e) {
			console.log( this.slideIndex );
			this.sendIndex( this.slideIndex );
		}
	}
});

var SliderSlide = Vue.component('sliderslide', {
	template: '',

	data: function() {
		return {
			width: 500,
			height: 500
		}
	},

	props: [],

	ready: function() {},

	methods: {}
});

However when I try to get the prop from the thumbnail slide-index on the sliderthumb component on the v-on="click: handleClick" it says undefined. But before I did the v-repeat on it, it shows the slide-index. I put spit out the $index variable and it's spitting out the right number. I just can't select any props that are passed on a component that uses v-repeat. Is there anyway around this?

This is a scope gotcha with v-repeat: once you use a component with v-repeat, the root node is compiled in parent scope. So when you do slide-index="{{$index}}" it actually sends in undefined because the parent scope doesn't have $index. Instead, $index is automatically available inside the component. See http://vuejs.org/guide/components.html#Repeat_Component_with_alias
Note in 1.0.0 v-repeat will be replaced by v-for, which has a different scoping behavior and works the way you expected.

Ah that's what I figured.. is there anyway to achieve this? I read that guide over and over again. I would like to pass in a prop with that index value..

You don't need to. Just access $index inside the component template. It's already there.

I want to access it in the component though. Not the template. I wanted to pass it as a prop so inside the Vue component, I can do this.slideIndex. I wanted to access that prop in my component code so I know what slide that thumbnail refers to.

Inside component it's just this.$index

Oh WOW. Thanks.. I didn't realize it was that easy!

Same here
<vue-map-hint v-repeat="hint in hints">

</vue-map-hint>

Vue.component('vue-map-hint', {
    replace: false
});

new Vue({
    el: 'selector',
    data: {
        hints: [
            {
                some: 'text'
            },
            {
                some: 'text_2'
            }
        ]
    }
});

Is there way get hit inside the template?


[To Main] Task - DESENG-682: Upgrade to node 20

Issue #: 🎟 DESENG-682
Description of changes:

Task Upgrade to Node v20

Upgraded deployment / CI configs to reference Node v20

User Guide update ticket (if applicable):

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.03%. Comparing base (be4394d) to head (a60c957).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2583   +/-   ##
=======================================
  Coverage   76.03%   76.03%
=======================================
  Files         609      609
  Lines       22105    22105
  Branches     1797     1797
=======================================
  Hits        16808    16808
  Misses       5033     5033
  Partials      264      264

Flag
Coverage Δ

metweb
65.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


kodiPlugins.visualization-waveform: init at 19.0.2

Description of changes
I notices kodi didn't have any visualizations. After digging a bit, I found out they are referenced in the binary-addons-repo. Just to get the hang of it, I packaged visualization.waveform and made sure it works.
For testing purposes, it can be build with nix-build -A kodiPlugins.visualization-waveform . and activated within kodi with pkgs.kodi.withPackages (p: with p; [ visualization-waveform])
@NixOS/kodi shall I leave you as maintainers, or shall I add myself?
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1186


I cannot finalize ZKP2P Trusted Setup Ceremony V2

Prerequisites
Please answer the following questions for yourself before submitting an issue.

[x] I am running the latest version
[x] I checked the documentation and found no answer
[x] I checked to make sure that this issue has not already been filed

Expected Behavior
I can finalize ZKP2P Trusted Setup Ceremony V2
Current Behavior
I cannot finalize ZKP2P Trusted Setup Ceremony V2
Failure Information
I cannot finalize ZKP2P Trusted Setup Ceremony V2 and my command show error.
Steps to Reproduce
Please provide detailed steps for reproducing the issue.
I just run command phase2cli auth && phase2cli contribute -c zkp2p-trusted-setup-ceremony-v2
Context
Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

Platform: MacOS Sonoma 14.1.2
Node version: v20.10.0
phase2cli version: v1.1.0

Failure Logs
`
🕛  Computing contribution... (ETA 00:00:03:09).
⚠ This may take longer or less time on your machine! Everything's fine, just be patient and do not stop the computation to avoid starting over again/Users/minhdoan/.nvm/versions/node/v20.10.0/lib/node_modules/@p0tion/phase2cli/node_modules/solc/soljson.js:133
process["on"]("unhandledRejection", function (reason) { throw reason; });
^
[Error: ENOENT: no such file or directory, open './output/contribute/zkeys/zkp2p-venmo-send-v2_00002.zkey'] {
errno: -2,
code: 'ENOENT',
syscall: 'open',
path: './output/contribute/zkeys/zkp2p-venmo-send-v2_00002.zkey'
}
`

I also encountered the same problem

Possible causes: - Ceremony begun on 1 machine, resumed on another; or environment cleaned, then ceremony resumed.

To follow up, we would need the exact steps prior to this error.

@glamperd Yes,  I started the ceremony on a VPS then resumed on my Mac


Update play-json to 2.9.3

Updates com.typesafe.play:play-json from 2.9.2 to 2.9.3.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.typesafe.play", artifactId = "play-json" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "com.typesafe.play", artifactId = "play-json" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #773.


Anime not downloading

Steps to Reproduce
When I am trying to download an episode from animephae server the download starts gets completed 98 percent and then it vanishes and the downloaded video is not inside downloads tab
Expected Outcome
Downloaded video
Actual Outcome
No video
Error Logs (if applicable)
No response
AnymeX Version
2.8.5
Operating System Version
Android 14
Device Information
OnePlus nord 3
Additional Information
No response
Submission Checklist

[X] I have searched existing issues to confirm this is not a duplicate.
[X] I have provided a clear and descriptive title.
[X] I am using the latest version of AnymeX. If not, I have provided a reason for not updating.
[X] I have updated all relevant extensions or dependencies.
[X] I have filled out all the requested information accurately.

Do not create issues if your alpha app isn't working as expected. Join our discord server for that.
Also we don't provide support for extensions.


Update direct-routing-border-controllers.md

@NMuravlyannikov @CarolynRowe Greetings, could you please review and merge? Thanks


[Feature Request] Allow the user to cancel an appointment booking after showing time, date and place of booking

When an available appointment has been found, www.impfterminservice.de usually reserves the appointment for 10 minutes (at least using the webpage, I do not know if their API, if existent, offers a similar service – this would be important to know). After the script found the appointment, it appears to print a BELL character to alert the user that an appointment became available, then immediately books the appointment. However, since it is not possible at the moment to consider times and days where the user cannot attend the appointment, it would be helpful (and may be easier to implement) to have a short time period (e.g. 30 seconds) where the user can manually check whether he is able to attend the proposed appointment and, if not, can cancel the booking process at the press of a button. Therefore, the amount of misbookings can be minimized. After a booking has been canceled, it may be advisable to pause the script for a few moments to wait for the appointment being taken by another person so the appointment will not be reserved and released by our script multiple times.

I had quite a bit trouble with "reserved for 10min". This does not really work! If you are to slow (<<10min) - I guess it took me <<2min it happens quite often (about 1 out of 10 bookings) that this appointment was taken by some else.
So I'm not sure about this feature. If it is implemented the waiting-time should be flexible. I will always stick with "0" :-)
For me the given options from Beta 1.0.5. on is perfekt!

The idea is good!
I had the same experience as andoorius. I found an appointment, but didn't know exactly what the address was. So I entered all the data 5 minutes later and wanted to book the appointment -> appointment no longer available...
@marvinruder

However, since it is not possible at the moment to consider times and days where the user cannot attend the appointment[...]

Maybe to get around your problem with unavailable dates, you could use the Beta v1.0.6 GUI. Here you can exclude certain days up to 1 week in advance:

As @andoorius already mentioned the reservation time is not really reliable.
@Floskinner offers a nice feature in its GUI that we're implementing in the non-GUI version aswell in the near future. Setting day and time range has to be sufficient. We don't want the user to interact with the script after starting the appointment search.
Misbookings may happen, but this shouldn't be an issue since people can (and I hope they do) easily cancel their appointment online at "Buchung verwalten". Once it is cancelled the appointment is thrown back into the queue and will be offered to the next one (just after a few minutes, no needs to worry at all).


[ENG-733] Osf layout

Ticket: ENG-733
Feature flag: n/a

Purpose
Add <OsfLayout/> component
Summary of Changes

Side Effects

QA Notes

Pull Request Test Coverage Report for Build 3520

21 of 25 (84.0%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.03%) to 75.527%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/osf-components/addon/components/osf-layout/component.ts
20
24
83.33%

Files with Coverage Reduction
New Missed Lines
%

lib/registries/addon/overview/controller.ts
1
76.92%

Totals

Change from base Build 3519:
0.03%

Covered Lines:
7934

Relevant Lines:
9216

💛  - Coveralls


Added link to the documentation in README.md. #79

Fixes #79 for GitHub README.

Looks fine, although I would change a few articles:
Documentation
Full documentation is available at BIASlab website.
It is also possible to build documentation locally. Just execute
$ julia make.jl

in the docs/ directory to build a local version of the documentation.


Not loading Images ( Newtoki)

Source information
Newtoki 1.4.29
Source language
Korean
Steps to reproduce
Solve captcha
Click any chapter (Old and New)
It says no image
Expected behavior
Can load images
Actual behavior

Mihon/Tachiyomi version
0.16.0
Android version
Android 10
Other details
Webview is okay
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.15.3.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[ ] I have admitted that I am a clown by having checked this box, as I have not read these acknowledgements.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

I am also experiencing the same issue as this.  Other extensions work, but this one doesn't work.

能读取到作品更新目录，但在线观看和webview单图查看都是链接失效

The image URL is fetched correctly. However, Newtoki is performing a referrer check, and if there is no referrer or wrong referrer, it sends a 404 not found error.
For example, if you send a request like
curl "https://img1.newtoki21.org/data/file/webtoon/25185533/36125141/U8w_zmraL0lp.jpg"
it will result in a 404 not found error. But if you send it with a referrer like
curl "https://img1.newtoki21.org/data/file/webtoon/25185533/36125141/U8w_zmraL0lp.jpg" -H "Referer: https://newtoki325.com/"
it will download correctly.

@jake1015 I still don't get it, the URL works fine, but the image doesn't show up, and if I want to view a single image, I still have to tap on the corresponding chapter on the web side first. Newtoki's 3rd party app has fixed this issue, hopefully the plugin here will as well.

Can you tell me what kind of 3rd party app it is?

@jake1015 I still don't get it, the URL works fine, but the image doesn't show up, and if I want to view a single image, I still have to tap on the corresponding chapter on the web side first. Newtoki's 3rd party app has fixed this issue, hopefully the plugin here will as well.

Can you tell me what kind of 3rd party app it is?

Just search Newtoki in github.（Java）

thanks


Text field label not adjusting to state change

What RMWC Version are you using?
3.0.4
What build system are you using?
Create React App, we're using flow as well
What are the steps to reproduce the bug?
When text is added via a state change to a text field which does not originally have any value, the label of the textfield does not automatically adjust to accommodate the text
What is the expected behavior?
The label should shift/shrink to the top of the text field
What is the actual behavior?
Currently, the label remains in its original location until the text field is put in focus by clicking on it

Fixed in 3.0.5. Sorry for the delay on this one.

Thank you!


goftp tests FAIL

for anyone reading

do not put goftp in /root as the tests will FAIL
edit build_test_server.sh and replace curl -O http://download.pureftpd.org... with curl -k -O https://download.pureftpd.org...
if you ran build_test_server.sh as root:

edit ftpd/users.txt and replace uid & gid (now 0:0) with numbers above 1000 (eg 1001:1001)
run chown -R 1001:1001 testroot (replace 1001:1001 with your numbers)
in ./ftpd run pure-ftpd-1.0.36/src/pure-pw mkdb users.pdb -f users.txt

tests should now work

Thanks for opening an issue. By "root goftp directory" the instructions mean the root directory of the project wherever you cloned it to, not /root. I admit it could be worded better. You should not need to run the build_test_server.sh script as root (I set up all the configuration to work as an unprivileged user). The README could probably do with some improvements, so feel free to open a PR with any fixes, or I'll get around to it sometime later.
Why is the -k flag needed? Seems like they serve the downloads over HTTPS now which is good, but they have a valid cert so we shouldn't need -k.

I know, I just wanted to clarify as the ftp servers would not start when "testroot" is within /root (I was lazy and cloned it in /root)
On a dev system I usually run things directly as root so I ran into that issue (Everything was ok when I switched to a unprivileged user).
yes but the local system might have the root certificate needed for validation (older distro)

done, check out my pull request


fix(button): fixed size of secondary button

The height of the secondary button is different from the normal one, removing the box-shadow inset is fixing the problem.
Before:

After:

:tada: This PR is included in version 3.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[DO NOT MERGE] Porting ROCm batch_gemm support to master-rocm-enhanced

This PR is to port the ROCm batch_gemm support from the develop-upstream to the master-rocm-enhanced branch.
We need to have a few pre-reqs in place before we can take this PR

[ ] identidy a commit on the upstream/master branch for which all ROCm CI jobs (rocm, rocm-cpp, rocm-xla)  are passing, aka the ROCm CI qualified commit
[ ] rebase the master-rocm-enhanced branch to the ROCm CI qualified commit
[ ] Setup ROCm CI jobs to run on PRs filed on the master-rocm-enhanced branch

The purpose of filing this PR now is to assist with filtering out the changes in this PR, from the set of diffs in develop-upstream that we need to triage before we abandon that branch
/cc @deven-amd

closing PR as we are no longer attempting to switch our development model.


chore: code modernization

This PR fixes a few warnings raised by javac and sonar. Each type of change is encapsulated in a separate commit for better understanding and easier review.

@seize-the-dave please review. thanks in advance!

Thanks @sebthom.  Not sure why I didn't get a notification for this.


Create use case model

Create a use case model that provides the information of what features are to be added.

@codebee12 Upload the pictures of the use case diagram


Removing ZKClient dependency from Pinot Client

Currently, Pinot client uses ZK client to watch on list of available brokers to send the request to. While this works well to keep the live broker list up-to-date, the dependency on ZK connectivity may not be desirable. One way to eliminate this would be to:

Use controller apis to get the list of brokers to query for a table.
Use polling to keep the broker list up-to-date
Additionally, also update broker list in case of errors (related to broker connectivity).

Another issue documented in #7166 is about the broker address we are
publishing to client is for inter-Pinot cluster communications. It’s not
guaranteed that client side is within same network.
E.g. Pinot client outside k8s cluster doesn’t have access to broker exposed
through controller API.
On Thu, Aug 5, 2021 at 09:11 Mayank Shrivastava @.***>
wrote:

Currently, Pinot client uses ZK client to watch on list of available
brokers to send the request to. While this works well to keep the live
broker list up-to-date, the dependency on ZK connectivity may not be
desirable. One way to eliminate this would be to:

Use controller apis to get the list of brokers to query for a table.
Use polling to keep the broker list up-to-date
Additionally, also update broker list in case of errors (related to
broker connectivity).

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/pinot/issues/7256, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJFPSH6MFQ42PO7VWD34XTT3KZ2LANCNFSM5BUFJEHA
.

I'm working on the changes to support controller based broker selector in the client.
Initial PR: https://github.com/apache/pinot/pull/8467/files
@mayankshriv


typosupplement the document content for grouping_id.md.

Proposed changes
Issue Number: close #xxx
Problem summary
According to the guidance https://doris.apache.org/zh-CN/community/how-to-contribute/contribute-doc/#如何编写命令帮助手册, add more explanation and explanation about grouping_id.md.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[x] Has document been added or modified
[ ] Does it need to update dependencies
[x] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


[incubator/istio] helm chart uses different app labels than manual istio install

Is this a request for help?:

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
BUG REPORT

Version of Helm and Kubernetes:
Which chart:
istio
What happened:
The helm chart uses different label selectors for the various services than the istio yaml files used when installing Istio manually.  As a result, the port forwarding instructions in many of the Istio tasks don't work. For example, https://istio.io/docs/tasks/telemetry/using-istio-dashboard.html says to use the following command to access the grafana service:
 kubectl -n istio-system port-forward $(kubectl -n istio-system get pod -l app=grafana -o jsonpath='{.items[0].metadata.name}') 3000:3000 &

This doesn't work if istio was installed using this chart, because with it the label is: app: istio, and it uses another label to identify the grafana component.
The chart needs to use the same app labels for the components as when Istio is manually installed.
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know:

/cc @lachie83


Update Node SDK wrappers for patch properties

Created by: @bayegan Sep 13 2021 at 14:33 CET
Last updated: Jul 18 2022 at 11:13 CET
ClickUp ID: IK-1501
Update Node SDK wrappers for patch properties

Commented by: @bayegan Sep 22 2021 at 18:23 CET
As part of v0.1.7 release.


"ConvertToManaged" does not seem to be working properly.

I exported the Unmanaged Solution from the development environment and Unpack as follows.
steps:
- task: PowerPlatformExportSolution@2
  displayName: 'Power Platform Export Solution'
  inputs:
    authenticationType: 'PowerPlatformSPN'
    PowerPlatformSPN: 'Dev'
    SolutionName: '$(SolutionName)'
    SolutionOutputFile: '$(Build.ArtifactStagingDirectory)/$(SolutionName).zip'
    AsyncOperation: true
    MaxAsyncWaitTime: '60'
    Managed: false
    ExportCustomizationSettings: true
    ExportExternalApplicationSettings: true
    ExportGeneralSettings: true
    ExportAutoNumberingSettings: true
    ExportRelationshipRoles: true

- task: PowerPlatformUnpackSolution@2
  displayName: 'Power Platform Unpack Solution'
  inputs:
    SolutionInputFile: '$(Build.ArtifactStagingDirectory)/$(SolutionName).zip'
    SolutionTargetFolder: '$(Build.SourcesDirectory)/$(SolutionName)'
    SolutionType: Unmanaged

I then pack the Solution as follows and import it into the production environment with the "ConvertToManaged" property set to true.
steps:
- task: PowerPlatformPackSolution@2
  displayName: 'Power Platform pack Solution'
  inputs:
    SolutionSourceFolder: '$(Build.SourcesDirectory)/$(SolutionName)'
    SolutionOutputFile: '$(Build.ArtifactStagingDirectory)/$(SolutionName).zip'

- task: PowerPlatformImportSolution@2
  displayName: 'Power Platform Import Solution'
  inputs:
    authenticationType: 'PowerPlatformSPN'
    PowerPlatformSPN: 'Prod'
    SolutionInputFile: '$(Build.ArtifactStagingDirectory)/$(SolutionName).zip'
    ConvertToManaged: true
    SkipProductUpdateDependencies: true
    OverwriteUnmanagedCustomizations: true
    AsyncOperation: true
    MaxAsyncWaitTime: '60'
    PublishWorkflows: true
    UseDeploymentSettingsFile: true
    DeploymentSettingsFile: 'Settings/DeploymentSettings-Prod.json'

I expected this to import the Managed Solution into the production environment, but it imported it as an Unmanaged Solution.

@koruneko The ConvertToManaged parameter is intended to convert components to managed state if they are found to be in an unmanaged state at the time of the managed solution import. It does not convert a solution
In order to to deploy a managed solution you need to export (and unpack) as managed from your source environment and import that managed solution file into the target environment

@parvezghumra Thank you for your reply.
I would like to confirm, by components do you mean objects? Or do you mean component library?
Also, it would be helpful if you could add an explanation of this issue to this document as well, as I think it would be easier for others to understand.
https://learn.microsoft.com/en-us/power-platform/alm/devops-build-tool-tasks#parameters-import

@koruneko Yes, I'm referring to objects in the solution when I say 'components'. Apologies for the confusion.
Thanks for your suggestion on updating the docs. I've created this PR to clarify the purpose of the 'Convert to Managed' parameter on the 'Import Solution' task: https://github.com/MicrosoftDocs/power-platform/pull/2443


Fix JSON generation in events.go

Got the hint to look at this via https://github.com/unpoller/unpoller/issues/412
I tested the fix (7.2 and 7.3 controller) and it worked for me. Although given that this file hasn't changed in 2 years, I wonder whether it would break really old unifi installs. Not sure.

Thanks! Question. Do I need to put up PRs to update inputunifi+unpoller to pull this in, or does that happen as part of some automagic process? Thanks again. cc @davidnewhall , @platinummonkey

It'll happen as more changes land in these packages. Pulling in the deps is a manual process.

Great. I'm perfectly happy to wait for it to trickle down as more changes land :) Thanks.


Add logging to piranha module

Sub task to issue #36

As the sources are available online additional logging beyond what is currently logging should not be necessary, closing as wont fix


Sequence ESC D is defined as IND on vt100

ESC D is defined as IND and not CUB on vt100. Is there a reason for this incompatibility?

Oh, well that's odd. Yea those definitely aren't the same thing.
I could be mistaken, but I thought it might have had something to do with trying to emulate old ANSI.SYS behavior, but that could be totally wrong.
I've filed microsoft/terminal/976 to make sure that's investigated

I believe this changed recently. Needs research against Microsoft/Terminal repo.

Is the behavior currently as discussed in https://github.com/microsoft/terminal/issues/976?

Is the scope for just A,B,C,D  or is it a more full scale evaluation of the documentation as compared to the standards?
ESC D = https://vt100.net/docs/vt510-rm/IND.html
ESC B = https://vt100.net/docs/vt510-rm/DD1.html
ESC A = https://vt100.net/docs/vt510-rm/LS.html/ https://vt100.net/docs/vt510-rm/SCS.html ?
ESC C = https://vt100.net/docs/vt510-rm/RIS.html
Do we want to document ANSI mode https://vt100.net/docs/vt510-rm/DECANM.html?

ESC B and ESC C weren't used in any of the ANSI-compatible DEC terminals as far as I'm aware (outside of VT52 mode), but they were defined in ECMA-48 as BPH (Break Permitted Here) and NBH (No Break Here). ESC A was apparently defined in an early draft of ISO 10646 as HOP (High Octet Present), but again was not used in DEC terminals.
You can find more info in the C0/C1 Wikipedia article here:
https://en.wikipedia.org/wiki/C0_and_C1_control_codes#C1_control_codes_for_general_use

Thank you @j4james, I think this documentation edit might require more domain expertise than I have.

We will need to make a clarification in the documentation. When this issue was filed, we had a section on "basic cursor positioning" which included ESC D.
That was removed in 22c98c4c51fd5ff034cd34f257be73cd39bc452b (#215), so now we we aren't documenting ESC D at all--correctly or incorrectly.
What we are documenting is CSI D (ESC [ D), which is correct.
I believe that means we do not need to make any changes here, and that this issue is resolved for now. In the future, we may want to document IND and other non-CSI positioning sequences separately.


Capture function doesn't work on Some devices

I used this code on my phone（Redmi 4x）and saw nothing happened after pressing the "Picture" button, by tracing the state of "afState" , I found that the case “STATE_WAITING_LOCK” did nothing when “afState==0”,which is the exact returned value of Redmi 4x.

This sample has been migrated to a new location where we can accept Pull Requests (check README for more information).
As recommended by GitHub, we are closing all issues and pull requests now that this older repo will be archived.
If you still see this issue in the updated repo, please reopen the issue/PR there. Thank you!


Can we use constants from rambafile in templates?

I need a project_name key from Rambafile in template for
@testable import {{ project_name }}

Can I get it?

@appleios once again, you can check the corresponding page in our WIki: https://github.com/rambler-ios/Generamba/wiki/Template-Structure.

Sorry, I should've looked into docs first.

@appleios That's ok - we added docs just a few weeks ago.


Security concerns using ngrok webhooks -> unprotected, public accessible switchbot-mqtt interface

Following the provided install instructions leaves you with an unprotected ngrok reverse proxy, e.g. https://yyyy-xxx-xxx-xxx-xxx.ngrok-free.app, where yyyy ist the instance id and xxx-xxx-xxx-xxx is your (router's) public ip. So there is already a fair chance to guess the link.  This provides intruders an easy door to get full access to your Switchbot devices, which can especially include doorlocks. The redirected switchbot-mqtt page is publicly accessible including all controls!
This is a serious security issue that I would like to address here. As I am not familiar with the (free) ngrok services, I would like to ask if there are ways to improve this and include proper instructions in the installation guide to close this vulnerability.

Thank you for pointing that out.
I initially intended to block access to the Ingress page. However, due to an error in the port number passed to Ngrok, it was inadvertently exposed.
The issue has been fixed, and version v1.0.19 has just been released.

Thanks for quick reaction 👍


map.setClickable(true) also disable touch/click on the element inside of the map_canvas

I am having one circle inside map_canvas div. I can fire click and pan event(pan using hammer.js) when map.setClickable(false). But when I set map.setClickable(true) the circle becomes non-clickable.
As per the documentation, the setClickable(ftrue) property only applies to the div present outside of map_canvas. How can I pan/drag the html element above the map. I think issue is before the pan event on html element, the camera_change event by native app is getting triggered. Please let me know of there is any workaround for both iOS and Android to pan/drag the html element above map.

I think the thing is that this map calculates the clickable space dynamically, so after every move of your circle you need to call map.refreshLayout which I dont think is very light (performance wise) function. Also to check what is exactly happening you should use map.setDebuggable(true)

I'm not familiar with hammer.js, but it seems the hammer.js moves the dom position.
In that case, you need to call map.refreshLayout() everytime as @denkomanceski describes.


[QUESTION] 部署到linux上datax日志报错

*For better global communication, please give priority to using English description, thx! *
Describe the question
datax-web部署到linux上，web系统运行正常，但是datax任务运行不成功
Which version of DataX Web:
2.1.2-release
Additional context

**Requirement or improvement

Please describe about your requirements or improvement suggestions.

+1

+1


Mock Helper

Enhanced the mock helper give a more fluent api for expression on how you would like your mock object back from the helper.
Refactored tests to use the new syntax.

May want to take this a little further but wanted to wait until I get some feedback on the approach.
This causes us to need to use php 5.6 for running tests, (so travis may break on CI right now) since I am using splats in functions.
( see https://travis-ci.org/blainesch/alfred-chrome-bookmarks/jobs/91126534 )

We could use..
if (version_compare(PHP_VERSION, '5.3.0') >= 0) {
    echo 'I am at least PHP version 5.3.0, my version: ' . PHP_VERSION . "\n";
}

This check could eval some different code based on which php version is being used.  That way our mocking api would work for all versions previous to 5.6.  I would ideally want to organize it in a way so that we would use a completely different version of the Unit class based on the php version.
We could just not use the splat feature but I almost think that's the wrong path to take.

@afaur I'll go over this now. As far as 5.3 goes we have a dependency already in the package.json:
https://github.com/blainesch/alfred-chrome-bookmarks/blob/master/composer.json#L7

@afaur  you should also make this pr into my branch feature/character-escape so it doesn't include my changes in the diff.


pylint score is too low

The pylint score for this project is terribly low at 6.57. Many of the issues are non-issues for a project such as this, eg. broken naming conventions because of typical algorithm variable naming. However, there are still a ton of issues that should be dealt with, including but not limited to trailing whitespace, missing docstrings, dead code (after return), uncaught strings, and out-dated iteration using range with len.
Many of these issues could be taken care of automatically. I propose that we start with that.

Sure

sounds good!
I wanted to clean the repo up so bad, but didn't have time :(.
Would be awesome if we could get contribution.

Ready to contribute :)

@Cawibo are you still interested working on this?

@ericklarac @keon I can work on this! Can I pick this up?

Yes :) feel free to take any tasks you want