MNT: Re-render the feedstock [ci skip]

Hi! This is the friendly conda-forge-admin automated user.
I've re-rendered this feedstock with the latest version of conda-smithy (2.0.1) and noticed some changes.
If the changes look good, then please go ahead and merge this PR.
If you have any questions about the changes though, please feel free to ping the 'conda-forge/core' team (using the @ notation in a comment).
Remember, for any changes to the recipe you would normally need to increment the version or the build number of the package.
Since this is an infrastructural change, we don't actually need/want a new version to be uploaded to anaconda.org/conda-forge, so the version and build/number are left unchanged and the CI has been skipped.
Thanks!

@jakirkham I regenerated with smithy on a PR I just merged, so this can be closed?


Generate and Render Past Events

Create sample data task to create past events: will Improve this later to contain messages as well as 6 fights per event for more stats.
Render Previous and Future Bouts in User#Show

closes #54
closes #22


Update java ver

Geyser now needs java 17 to run

Looks good, can you change the title on the standalone setup page to remove the iOS mention? Since that's no longer feasible


Gratuitous ARP fix + IP neighbor scanning

Fixed? :)
On 7 Jun 2018, at 11:09, Rastislav Szabo <notifications<EMAIL_ADDRESS>wrote:

You can view, comment on, or merge this pull request online at:
https://github.com/contiv/vpp/pull/848
Commit Summary

Gratuitous ARP fix + IP neighbor scanning
Merge remote-tracking branch 'upstream/master'

File Changes

M Gopkg.lockhttps://github.com/contiv/vpp/pull/848/files#diff-0 (4)
M Gopkg.tomlhttps://github.com/contiv/vpp/pull/848/files#diff-1 (16)
M k8s/contiv-vpp.yamlhttps://github.com/contiv/vpp/pull/848/files#diff-2 (1)
M k8s/contiv-vpp/README.mdhttps://github.com/contiv/vpp/pull/848/files#diff-3 (1)
M k8s/contiv-vpp/templates/vpp.yamlhttps://github.com/contiv/vpp/pull/848/files#diff-4 (1)
M k8s/contiv-vpp/values.yamlhttps://github.com/contiv/vpp/pull/848/files#diff-5 (1)
M plugins/contiv/host.gohttps://github.com/contiv/vpp/pull/848/files#diff-6 (17)
M plugins/contiv/plugin_impl_contiv.gohttps://github.com/contiv/vpp/pull/848/files#diff-7 (1)
M plugins/contiv/remote_cni_server.gohttps://github.com/contiv/vpp/pull/848/files#diff-8 (4)
M vendor/github.com/ligato/vpp-agent/plugins/defaultplugins/common/bin_api/ip/ip.gohttps://github.com/contiv/vpp/pull/848/files#diff-9 (43)
M vendor/github.com/ligato/vpp-agent/plugins/defaultplugins/common/bin_api/ip/pkgreflect.gohttps://github.com/contiv/vpp/pull/848/files#diff-10 (4)

Patch Links:

https://github.com/contiv/vpp/pull/848.patch
https://github.com/contiv/vpp/pull/848.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/contiv/vpp/pull/848, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABK2G5ILHC4Y-Yp-rkD3aHiCUETS8iePks5t6PvzgaJpZM4UeHmw.

Coverage decreased (-0.1%) to 76.475% when pulling 8926bb04d6c3bce9612e90657718709359adb173 on rastislavszabo:master into 51cdb2dada4869fbe101ce5828ce04b39ed91d6b on contiv:master.


Update bindings for merge of Mina's develop branch

This updates the bindings based off https://github.com/MinaProtocol/mina/pull/15049.

stale


How to install jsfft

Hi,
Excuse my ignorance I am new to JavaScript.  I am trying to install the jsfft library.  I tried using npm install jsfft but I got an error that jsfft cannot be a dependency of itself.  Do you know what is going on here or what I could do differently to get this library to install?
Thanks,
Daniel Haverporth

Hmmm, I'm not an npm expert, but this worked for me (on OSX):
=> mkdir fft-demo
=> cd fft-demo/
=> npm install jsfft
...
+<EMAIL_ADDRESS>added 1 package in 0.979s
=> node
> require('jsfft')
{ ComplexArray: [Function: ComplexArray],
  FFT: [Function: FFT],
  InvFFT: [Function: InvFFT],
  frequencyMap: [Function: frequencyMap] }


error with command in emptytrash alias

This works in my terminal:
sqlite3 ~/Library/Preferences/com.apple.LaunchServices.QuarantineEventsV2 'select LSQuarantineDataURLString from LSQuarantineEvent'

But this command does not; note the database file is now V*:
sqlite3 ~/Library/Preferences/com.apple.LaunchServices.QuarantineEventsV* 'select LSQuarantineDataURLString from LSQuarantineEvent'

I get this error message:
Error: near "/": syntax error

Google and StackOverflow searches revealed no help.

I am guessing you have multiple files that match ~/Library/Preferences/com.apple.LaunchServices.QuarantineEventsV*. The expectation is exactly one. The second one is getting interpreted as a SQLite command.

In ~/Library/Preferences, I have both:
com.apple.LaunchServices.QuarantineEventsV*
com.apple.LaunchServices.QuarantineEventsV2

I deleted com.apple.LaunchServices.QuarantineEventsV* which is not the most sophisticated way of solving this problem but now it is fine.


Web console: add tile for Azure Event Hubs (via Kafka API)

Adding a tile to the web console that helps users wanting to ingest data from Azure Event Hubs to ingest the data via the Kafka compatible API.

There is no functional change to "core" Druid, just a nice UI flow for the Azure Event Hubs users
This PR has:

[x] been self-reviewed.
[x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[x] been tested in a test Druid cluster.

👍

@vogievetsky I tried this locally and it looks like the Event Hubs tile isn't greyed out when the kafka extension is not loaded


UrlValidator can not validate for http://localhost

Please look at this picture. When I typed the url, it showed an error in the browser. This is not server validation because I did not click the submit button.

example code in Model
    /**
     * @return array the validation rules.
     *
     * @see https://www.yiiframework.com/doc/guide/2.0/en/tutorial-core-validators
     */
    public function rules()
    {

        return [
            [['name' , 'redirect_uri' , 'status'], 'required'],
            ['redirect_uri' , 'url'],
        ];
    }

example code in view
        <?php $form = ActiveForm::begin(); ?>
        <?= $form->field($model, 'name')->textInput(['maxlength' => true]) ?>
        <?= $form->field($model, 'redirect_uri')->textInput(['maxlength' => true]) ?>
        <div class="form-group">
            <?= Html::submitButton(Yii::t('app', 'Save'), ['class' => 'btn btn-success']) ?>
        </div>

        <?php ActiveForm::end(); ?>

Additional info

Q
A

Yii version
2.0.38

PHP version
7.4.11

Operating system
WSL2 run yii2-docker

Not going to be changed. See https://github.com/yiisoft/validator/issues/4

Not going to be changed. See yiisoft/validator#4

It seems that this effects not only localhost.
For me it seems the every local domain name (without a dot) seems to be declared as invalid.
Could you add an optional config param e.g. allowLANdomains with default-value to false, what would allow to disable / enable the support for simple lang domains and/or localhost?


Request support scss.liquid and css.liquid files

Currently, the extension only works on HTML within a liquid file. Would like to see support for style blocks within HTML files and liquid syntax highlighting for stand-alone stylesheet files (*.css.liquid, *.scss.liquid).

Example of what is currently seen in a *.css.liquid file.

@UncleRemus Support for this is available in the vs-code extension.

@panoply are you sure that https://github.com/panoply/vscode-liquid support scss.liquid and css.liquid files ? in the documentation they first claim that they support. *. liquid, but in the next paragraph they warn that it is dangerous to use them for these types of files and recommends disabling them for all except .liquid (html). worse still it does not support script and style tags in html.

That's incorrect. I maintain the project.
You will need to disable code validations as Liquid is not apart of CSS or SCSS (they a completely different projects) and yes you should avoid writing Liquid infused with CSS/SCSS as if you architect you application correctly you should really need to do that. In terms of <script> and <style> tags that refers only to formatting when Liquid code is found present within said HTML tags, which again you should avoid because it's hacky.

Hi @panoply  Okay, I wish I was wrong about this extension that you maintain. But I'm totally confused about what she can do and what she can't .
I just installed it, can you please explain to me clearly what it does and what it does not (.liquid / .scss.liquuid / .js.liquid ...) (formating / syntax highlinting / validation ...), I have a hard time understanding documentation as it contains contradictions.
anyway, Thank you for your response and the time invested in developing this extension.
PS: the inclusion of the liquid code in the .scss and style is mandatory, as we are developing themes that the end user must be able to customize through a GUI and the user settings are mapped through liquid to the. scss.liquid or style tags. Also inclusion of the liquid in the tags script is inevitable in for example the data structured json-ld (you can't hard code these strings).

Hey @Ben-Abbes probably best to move this conversation away from this repository as the extension grammar here is suited for the standard variation of Liquid and whereas the grammar and extension I maintain covers multiple variations (Shopify, Jekyll etc).
From what you are communicating here, it seems you are having trouble understanding some terminologies. Here is a brief breakdown of what the current version of the extension I maintain does:

Supports Liquid syntax highlighting in multiple languages, so you will get support in HTML, CSS, SCSS and JavaScript languages.
Supports Liquid formatting in HTML, which means it will beautify Liquid contained in HTML, additionally it will format/beautify <script>, <style>, {% schema %}, {%  style %} etc tags.
Supports HTML validations and completion features.

Feel free to open an issue in the repository, so as to avoid creating noise here for the maintainer.


Reduce GPU mem usuage

Using torch.no_grad() reduces GPU memory usage significantly. But I am aware that Cellpose not only uses pytorch for GPU calculation. Any idea how to detect GPU backend and take advantage of torch.no_grad() if it is pytorch?
Related issue in image.sc forum

torch.no_grad()
https://forum.image.sc/t/napari-cellpose-out-of-memory/60742/3

Codecov Report

Merging #16 (ad2be8e) into main (895b909) will increase coverage by 0.78%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   30.09%   30.87%   +0.78%
==========================================
  Files           3        3
  Lines         216      217       +1
==========================================
+ Hits           65       67       +2
+ Misses        151      150       -1

Impacted Files
Coverage Δ

cellpose_napari/_dock_widget.py
19.02% <100.00%> (+0.98%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 895b909...ad2be8e. Read the comment docs.

sorry for the general inactivity here.  I'm afraid I don't know enough to comment either way here.  Can you think of any potential downsides here?  Seems like since it's never training, only inferring, it should be safe, yes?
Also, since they don't directly depend on torch in this package, we should use a try: import block (with a no-op fallback decorator)

let's go with it :) added a try/import block for you


Injimob 781 app tour guide walkthrough features

Implemented Tour guide of the app to walkthrough the features in the Home Page.
INJIMOB-781

created another PR. Hence closed


Integrate the Authentication (OAuth2 OIDC)

A local Keycloak server can be used for testing and developing.

Does it have to be a Keycloak or could it be any OIDC provider, e.g. https://github.com/Soluto/oidc-server-mock.

I think this one depends on the actual dev setup, as authentication is also crucial for talking to the API.


Support Eclipse 3.7 (Indigo)

This merge is the result of @emolitor work done in the platform/indigo-37 branch. I've simply squashed all changes made in platform/indigo-37 in a single commit, as I feel it keeps history cleaner (and there are not that many changes anyway).
Eric, I only made two, hopefully minor, changes:

Using the released AJDT 2.1.3 instead of 2.2-SNAPSHOT. (I don't see a need to link against 2.2, at least until there is a stable release)
Call mapModifiers to map modifiers of a Scala's symbols to JDT flags (there was a big TODO comment in the code, which I hence removed).

Here follows the list of changes applied in this commit:

Created a repo.ajdt entry and use 2.1.3 for JDT 3.7 (we could also use AJDT
2.2 snapshot, but I still think it's better to use the currently released
AJDT and move to 2.2 only after it is officially released).

Use Eclipse Indigo release site (this fixes JDK 7 builds).

Pass isMember correctly derived if the owner is a class.  Obtain jdtFlags
using ScalaJavaMapper.mapModifiers(symbol).

Add flags and methodParameter to ScalaLocalVariableElement.

Looks good.
Please go ahead, merge and inform the community.

Alright, it is now in master


Future contribution

Here will be some contribution from me :)

https://github.com/beautify-web/js-beautify/issues/1527

This is fix for https://github.com/beautify-web/js-beautify/issues/1651

@bitwiseman, I think you should merge this at the current state to avoid future conflicts because of lots of changes in tests.

@HanabishiRecca
Thanks again for contributing!


Wrapping Radix DropdownMenu.Item with styled breaks keyboard navigation

Bug report
An issue when combining stitches + radix.
Describe the bug
When wrapping DropdownMenu.Item with styled keyboard navigation is broken upon rendering an Item as an anchor tag.
To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:

Sandbox
Compare keyboard navigation between the two examples

Expected behavior
Keyboard navigation should work the same when wrapping Dropdown.Item with styled
System information

OS: macOs
Browser (if applies): FF / Chrome
Version of Stitches: 0.1-canary.18
Version of Node.js: 14.15.1

Additional context
Not sure if this belongs here, or in the Radix repo :)

Looks like this is the same issue noted a few days ago:  https://github.com/modulz/stitches/issues/448
Reading that issue, I now understand what's going on, but unsure how best to fix it 😄

Closing because the title of this issue is inaccurate. It's the same issue as #448.


Rename logitech-g900-wireless.device to logitech-lightspeed.device?

There are a lot of mice using this Lightspeed connector, I think it would make more sense to rename the device file logitech-lightspeed.device.

yeah, we should change the svg to something more generic and add a wiki page explaining what's going on here. Once the kernel patches are in place, we should even be able to leave this one in, presumably the new files will then just work.

Yeah, I though the same about the svg file but then I remembered it won't really matter when the kernel patches get upstreamed.
Perhaps we could still make the new svg file for users that don't meet the kernel version requirements or have the driver disabled.

@FFY00 want to send us a MR for this? Fame and fortune guaranteed*
* this is not a guarantee.


Upgrading MLKit dependencies

Greetings,
We are attempting to use this nuget package alongside MLKit text recognition through own custom binding libraries on iOS. There seems to be version conflicts caused by the MLKit frameworks, where our binding libraries are pulling latest cocoapod versions while this project is using older versions. Would you be willing to upgrade the MLKit dependencies referenced in this project?
Thanks,
DK

May I ask which version are you in?
It was just updated to

MLKitBarcodeScanning-2.2.0
MLKCore-8.0.0
MLImg-1.0.0beta3
MLKVision-4.2.0
MLKMDD-4.2.0
It looks there are newer version in the list in MLKit official page (released on 17 April 2024)
But it looks the cocoapod is not available.

@JimmyPun610 - we'll shortly have new versions of the MLKit.BarcodeScanning libraries available from here (https://github.com/AdamEssenmacher/GoogleApisForiOSComponents), if I get a PR put together, any chance we can get that merged in here :)

@JimmyPun610 Sorry for late response, we ended up writing our own binding libraries as we needed to use MLKitTextRecoginition library besides the barcode scanning stuff, kudos for updating the dependencies tho!
@bengavin will check out this fork, thanks!
I would close this issue now but I don't want to drop your communication efforts, please feel free to close at your convenience.

closing.
Thanks for the effort from @bengavin


[Event Request] Page 802 Online Map Address Selector - LoadLocationLookup / SetTableNo

Please extend the CASE structures in functions LoadLocationLookup / SetTableNo to provide support to integrate a new custom entity in Page 802.

In addition, the 'LookupSelection' variable optioncaption property needs to be extendable as well.


Unable to checkout Bundler repo on Windows

It is currently not possible to checkout the Bundler repo on Windows due to the vcr_cassettes containing question marks in folder names added in #5220.
Would it be possible to convert the serialized request/response to another format?
D:\Dropbox\GIT_Workspaces>git clone https://github.com/bundler/bundler
Cloning into 'bundler'...
remote: Counting objects: 70934, done.
remote: Compressing objects: 100% (18/18), done.
remote: Total 70934 (delta 18), reused 14 (delta 10), pack-reused 70906
Receiving objects: 100% (70934/70934), 31.52 MiB | 6.92 MiB/s, done.
Resolving deltas: 100% (45282/45282), done.
fatal: cannot create directory at 'spec/support/artifice/vcr_cassettes/realworld/api.rubygems.org/api/v1/dependencies?gems=bundler': Invalid argument
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry the checkout with 'git checkout -f HEAD'

\cc @segiddins

Why is ? in file names an issue? As far as I'm aware, it's not File::SEPARATOR on any platform?

The following are reserved characters on Windows:
The following reserved characters:
- < (less than)
- > (greater than)
- : (colon)
- " (double quote)
- / (forward slash)
- \ (backslash)
- | (vertical bar or pipe)
- ? (question mark)
- * (asterisk)

https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247

fixed in #5829

Thanks! It is now possible to check out the repo.


Update mmap-alloc for the new nightly Alloc trait

Note: I did not attempt to update any of the other crates in this repo that wee_alloc does not depend on.

@fitzgen Is this the same code that's currently working for y'all in wee_alloc? Just want to make sure it's battle-tested since the CI tests are failing (and since I'm going to merge this first before fixing the other crates).

Yep!
See
https://github.com/rustwasm/wee_alloc/blob/master/wee_alloc/Cargo.toml#L37
On Tue, Apr 17, 2018, 9:53 PM Joshua Liebow-Feeser<EMAIL_ADDRESS>wrote:

@fitzgen https://github.com/fitzgen Is this the same code that's
currently working for y'all in wee_alloc? Just want to make sure it's
battle-tested since the CI tests are failing (and since I'm going to merge
this first before fixing the other crates).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ezrosent/allocators-rs/pull/181#issuecomment-382260868,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEjSzeiXd1iplgbLH40phO29i8642g2ks5tpsazgaJpZM4TXWq0
.

Superseded by #184.


Twig and Visual Basic support only

Hi, I just created a branch which only contains the changes to regex related files. Kind regards.

thank you so much

thank you so much


netCDF4: support byte strings as attribute values

What is your issue?
When I have a string attribute with special characters like '°' or German Umlauts (Ä, Ü, etc) it will get written to file as type NC_STRING. Other string attributes not containing any special characters will be saved as NC_CHAR.
This leads to problems when I subsequently want to open this file with NetCDF-Fortran, because it does not fully support NC_STRING.
So my question is:
Is there a way to force xarray to write the string attribute as NC_CHAR?
Example
import numpy as np
import xarray as xr

data = np.ones([12, 10])
ds = xr.Dataset({"data": (["x", "y"], data)}, coords={"x": np.arange(12), "y": np.arange(10)})
ds["x"].attrs["first_str"] = "foo"
ds["x"].attrs["second_str"] = "bar°"
ds["x"].attrs["third_str"] = "hää"
ds.to_netcdf("testds.nc")

The output of ncdump -h looks like this, which shows the different data type of the second and third attribute:

The reason for this behavior is that the netcdf4 python package automatically determines the type of the attribute (NC_CHAR or NC_STRING) by attempting the conversion to ASCII: https://github.com/Unidata/netcdf4-python/issues/529 However, if the value is a byte string, no conversion is done. So, the easiest solution would be to manually convert to utf-8 and then passing the byte string to netcdf4. Unfortunately, xarray doesn't support byte strings as attribute values even though this is a valid data type for the netcdf4 engine:
https://github.com/pydata/xarray/blob/6cb97f645475bddf2f3b1e1a5f24f0f9de690683/xarray/backends/api.py#L175
In the long term, I would suggest to add bytes as a supported type in that list above on xarray's side.
A quick workaround for you might be to encode the string as utf-8 and convert to a numpy array, since xarray accepts numpy arrays as data type and netcdf4 automatically extracts the data if the array contains only a single item:
ds["x"].attrs["third_str"] = np.array("hää".encode("utf-8"))

Thank you @tovogt! The workaround fits my needs for now.
Nevertheless, I would leave this issue open as a note for @tovogt 's suggestion to add bytes as a supported type for attributes.

I plan to implement this in the next couple days.

That would be much appreciated. Thanks!

A comment about the proposed solution. Allowing bytes as a valid_type for attributes will allow not just encoded strings but arbitrary binaries to be saved as attributes (after conversion to strings). I'm not sure to what extent this is inherently problematic/unsafe, but a concrete issue is that the h5netcdf engine does not accept null characters. (You need to add bytes to valid_types to run the following example.)
import numpy as np
import xarray as xr

all_bytes = bytes(range(256))
good_bytes = "bar°".encode("UTF-8")
bad_byte = b'\x00'
not_bytes = "hää"

data = np.ones([1])
ds = xr.Dataset({"data": (["x"], data)}, coords={"x": np.arange(1)})
# ds["x"].attrs["first_str"] = all_bytes
ds["x"].attrs["second_str"] = bad_byte
ds["x"].attrs["third_str"] = good_bytes
ds["x"].attrs["fourth_str"] = not_bytes

# ds.to_netcdf("testds.nc", engine = "netcdf4")
# ds.to_netcdf("testds.nc", engine = "scipy")
ds.to_netcdf("testds.nc", engine = "h5netcdf")

!ncdump -h testds.nc

I propose adding a check to check_attr that if an attribute has type bytes it is a utf-8 encoded string free of null characters:
    def check_attr(name, value, valid_types):
        ...

        if isinstance(value, bytes):
            try:
                value.decode('utf-8')
            except UnicodeDecodeError as e:
                raise ValueError(
                    f"Invalid value provided for attribute '{name!r}': {value!r}. "
                    "Only binary data derived from UTF-8 encoded strings is allowed."
                ) from e

            if b'\x00' in value:
                raise ValueError(
                    f"Invalid value provided for attribute '{name!r}': {value!r}. "
                    "Null characters are not permitted."
                )

If it's only unsupported by h5netcdf, it would be good to specialize the check to just that engine.


The height of the sidebar increases continuously

The height of the sidebar increases continuously;
I clicked on the outline and then on the timeline, and their containers kept getting higher and higher

this sounds like https://github.com/microsoft/vscode/issues/126523


Added Depth First Traversal [Ruby]

Fixes #529
By submitting this pull request I confirm I've read and complied with the below declarations.

[x] I have read the Contribution guidelines and I am confident that my PR reflects them.
[x] I have followed the coding guidelines for this project.
[x] My code follows the skeleton code structure.
[x] This pull request has a descriptive title. For example, Added {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
[ ] This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.

Hi! Thanks for showing interest in contributing to this repository.
Please make sure that you have ticked the points mentioned in PR description correctly.
Thanks again!

@sathiyaseelan: Please resolve conflicts in README. Since this change would introduce a new column, the conflicts have to be there. We'll be good if this gets merged at the earliest.


[Syntax] Provide a generic casting function that can cast any protocol type

This is useful for clients to be able to cast to their own protocol types. This replaces the existing casting functions that were going through existentials.

@swift-ci Please test

Build failed
Swift Test OS X Platform
Git Sha - ebb1a0c1dac923fce56ed47e9514a0ffe587ecbf

The generic cast function has a serious flaw in that it is preferred over a specific cast function that returns non-optional, when optional chaining. I've reverted to original casts and kept only the Syntax constructor that accepts an optional parameter.

@swift-ci Please test

Build failed
Swift Test OS X Platform
Git Sha - ebb1a0c1dac923fce56ed47e9514a0ffe587ecbf


Add site banner content

@tysongach I'd appreciate a second look here. Thanks!

This looks great! 💃 💃


Result.from_xml data argument has a wrong type doc

Passing Element as a data argument to Result.from_xml() as docstring suggests raises Exception.
>>> overpy.Result.from_xml(xml.etree.ElementTree.fromstring("<osm />"))
Traceback (most recent call last):
  File "<input>", line 1, in <module>
  File "/home/w/osm-borders/lib/python3.5/site-packages/overpy/__init__.py", line 310, in from_xml
    source = StringIO(data)
TypeError: initial_value must be str or None, not xml.etree.ElementTree.Element

It looks like it expects string right now:
>>> overpy.Result.from_xml("<osm />")
<overpy.Result object at 0x7faf632b2eb8>

My python version is:
$ python --version
Python 3.5.2
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=16.10
DISTRIB_CODENAME=yakkety
DISTRIB_DESCRIPTION="Ubuntu 16.10"
(My guess that Ubuntu's Python 3.5.2 is far more similar to Python 3.6 than to 3.5)

Thanks for reporting the issue.
I have merged a fix into the master branch. The fix will be in the next release.


{AKS} Fix several cases broken by network module bumping API

This checklist is used to make sure that common guidelines for a pull request are followed.
{AKS} Fix several cases broken by network module bumping API.
Related command

General Guidelines

[ ] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
[ ] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
[ ] My extension version conforms to the Extension version schema

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

AKS


Illegal Invocation Intermittent error on Windows

Description
Using New Relic's APM, we are experiencing intermittent errors in the hundreds surfaced in Sentry as of the last 2 months.
TypeError

Illegal invocation

Steps to Reproduce
It is intermittent but always specific to Windows 10 Chrome and initial page loads.
Expected Behavior
No error
Relevant Logs / Console output

Your Environment

NR Python Agent
APM Lite
Chrome
Windows 10

Additional context
Similar conversations:

https://discuss.newrelic.com/t/illegal-invocation/148978
https://discuss.newrelic.com/t/uncaught-typeerror-illegal-invocation-error-thrown-in-js-agent-newrelic-com/154260

+1
Same for me, I see a lot of these for users on Chrome on Windows 10

Thanks for the bug report @dvnrsn and the confirmation @ionTea . I'll work with the team to see if we can reliably reproduce the issue and get to the bottom of it.


chore(deps): update common-dev-assets digest to 76ee835

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
1115b74 -> 76ee835

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.1.4 :tada:
The release is available on:

GitHub release
v1.1.4

Your semantic-release bot :package::rocket:


Update crate dependencies exept clap

Hello Tasuku,
thank you very much for the PR!

Hi @snshn,
Thank you for the project and merging my request. I hope I can get it through https://crates.io/crates/dataurl soon :)

It will be in the next release.  This crate will eventually be used as a dependency of https://crates.io/crates/monolith for dealing with data URLs.


airflow: new extractor for S3ToSnowflakeOperator

Signed-off-by: Manmeet Kaur<EMAIL_ADDRESS>Problem
This is related to this issue #1335 . It only covers a part of it, I intend to add more Extractors in this PR but want to get feedback on one first before proceeding ahead.
Closes:
Solution
Includes just adding an extractor for S3ToSnowflakeOperator using the existing extractors or utilities. Tested on my local using Marquez using S3 Object Storage and Snowflake Account.
Checklist

[X] You've signed-off your work
[ ] Your pull request title follows our guidelines
[ ] Your changes are accompanied by tests (if relevant)
[ ] Your change contains a small diff and is self-contained
[ ] You've updated any relevant documentation (if relevant)
[ ] You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
[ ] You've versioned the core OpenLineage model or facets according to SchemaVer (if relevant)
[ ] You've added a header to source files (if relevant)

SPDX-License-Identifier: Apache-2.0
Copyright 2018-2022 contributors to the OpenLineage project

Hey @manmeetkaur , there are mypy errors: https://app.circleci.com/pipelines/github/OpenLineage/OpenLineage/5575/workflows/3ca25a15-61d9-407c-9726-a926ef6b7ae2/jobs/77512

Hey @manmeetkaur , there are mypy errors: https://app.circleci.com/pipelines/github/OpenLineage/OpenLineage/5575/workflows/3ca25a15-61d9-407c-9726-a926ef6b7ae2/jobs/77512

Hey @mobuchowski Sorry for ghosting on this. I fixed the mypy issue, but now getting error in dagster tests section, can you provide guidance there ?

Hey @manmeetkaur. Can you first rebase your work on latest main branch?

@mobuchowski rebase done. no changes

resolved all the ruff errors, now getting ```py3-airflow-2.5.0: commands[0]> flake8 --extend-exclude tests/integration,scripts/
py3-airflow-2.5.0: commands[1]> bash -ec 'if [[ ! -f $0/airflow.db ]]; then airflow db reset -y; fi' /home/circleci/openlineage/integration/airflow/.tox/py3-airflow-2.5.0
py3-airflow-2.5.0: failed with bash is not allowed, use allowlist_externals to allow it
py3-airflow-2.5.0: FAIL code 1 (116.01 seconds)
evaluation failed :( (116.09 seconds)
Exited with code exit status 1

Hey @manmeetkaur I think it would be fixed if you rebased the code, where we've fixed this problem before. I see the first commits in this PR are still from December 7th - this means it's running against over 2 months old pipeline.
git rebase --onto main HEAD~7

Codecov Report

Merging #1397 (ed70af2) into main (00b4033) will decrease coverage by 0.34%.
The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##               main    #1397      +/-   ##
============================================
- Coverage     82.75%   82.42%   -0.34%
============================================
  Files            89       65      -24
  Lines          4041     3595     -446
  Branches         29        0      -29
============================================
- Hits           3344     2963     -381
+ Misses          665      632      -33
+ Partials         32        0      -32

Impacted Files
Coverage Δ

...neage/airflow/extractors/s3_snowflake_extractor.py
0.00% <0.00%> (ø)

...a/io/openlineage/client/transports/HttpConfig.java

...penlineage/client/transports/ConsoleTransport.java

.../openlineage/client/transports/KafkaTransport.java

integration/dagster/openlineage/dagster/sensor.py

...o/openlineage/client/transports/ConsoleConfig.java

...c/main/java/io/openlineage/client/Environment.java

.../openlineage/client/DefaultConfigPathProvider.java

...o/openlineage/client/transports/KinesisConfig.java

...ntegration/dagster/openlineage/dagster/__init__.py

... and 16 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


comments are badly misplaced in linear view

Binary Ninja Version
Version 2.5.3129-dev (Build ID 9038e9f1)
Describe the bug
A comment placed on an instruction appears somewhere that doesn't make sense.
To Reproduce
From some quick tests it seems like this happens in a broad range of circumstances, but here's a specific way to reproduce.

Open this file and go to _test.  It decompiles as follows:

00003f50      if (arg1 == 0)
00003f5c          _bar()
00003f54      else
00003f54          _foo()
00003f6c      return 5

Add a comment at address 0x3f54.
Go to linear HLIL view.
Huh??

00003f50      if (arg1 == 0)
00003f54          // test comment
00003f5c          _bar()
00003f54      else
00003f54          _foo()
00003f6c      return 5

Expected behavior
The comment should be after else or _foo().
Version and Platform (required):

Binary Ninja: Version 2.5.3129-dev (Build ID 9038e9f1)
OS: macOS
Version 11.6

Additional context
This is not the same as #2728, which is about comment placement not being sufficiently granular.  In this case the placement is just wrong.

This has been addressed as of 2.5.3158-dev and should hopefully be usable again. Notably, comments should no longer be misplaced in a block when there are large jumps in the address (eg inside a conditional or switch). Additionally, addresses which appear in multiple disjoint places in HLIL will have the comment applied to all of those places. This is still suboptimal, but at least now the comments will show up where they're supposed to.
There's a longer-term Hard Problem to solve for this to be perfect, as mentioned in #2728 / #1598, of trying to serialize consistent locations in HLIL instructions (and MLIL, LLIL) so that comments don't move or disappear when analysis changes. I'm not sure if something like that is possible yet, but this specific issue should be fixed.


Marketplace extension preview does not initially display whether there are updates

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.71-insider
OS Version: Windows 11

Steps to Reproduce:

Publish an update to an extension
Check that the update is available on the marketplace page
Go to insiders.vscode.dev
Open the extension page from the Installed section of the extension panel
:bug: page doesn't show that an update is available
Now search explicitly for the extension id in the extensions view
Now the page shows that an update is available

I would expect that opening the extension page alone is sufficient to trigger a check for newer versions. I hit this all the time with Azure Repos and GitHub Repositories not getting a new update in insiders.vscode.dev

What is your extensions.autoCheckUpdates setting?

🤦 Had it set to false at some point and clearly forgot to reset that. Thanks @gjsjohnmurray!

I just hit this again and this time I did have auto updates and auto checking updates enabled:

https://user-images.githubusercontent.com/30305945/187984492-7ef96460-9e93-4ee2-8d24-de566bc635a2.mp4

Generally we try to auto updated when the window is loaded. If there are no auto updates we check every 12 hours. Meanwhile you can browse for the extension for the auto update to kick off. So an extension get auto updated in current session or in next session.

@sandy081 I guess this issue is a feature request to kick off an auto update check when the extension view receives focus or when the preview for a given extension is opened. Without this, the extension view arguably shows the user stale information and claims that the user is up to date (in the recording I attached above, I clicked the refresh button and even then it said no updates)

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.
If you wonder what we are up to, please see our roadmap and issue reporting guidelines.
Thanks for your understanding, and happy coding!


Use saturating_add in shared_object_congestion_tracker.rs

SUI fixed some overflows in the shared object congestion tracker.
We should fix those as well, and go through the rest of the code base if there are similar bugs.
https://github.com/MystenLabs/sui/commit/837bf41c6f5b44258774d30484a1e2ecb4687e18
https://github.com/MystenLabs/sui/commit/a139ef255ae7c123b356e131f7796cbe5283f194
I'm wondering about the change with the <=, I think they refer to that with 0-cost tx, but what exactly is a 0-cost tx?

I'm wondering about the change with the <=, I think they refer to that with 0-cost tx, but what exactly is a 0-cost tx?

Since the active cost mode is the GasBudget mode, one could specify a high budget to cause overflow. Since they used saturating_add to address this issue, now it's possible that a transaction will not increase an already saturated number.  So the problem is not 0-cost transactions but rather continuing to evaluate transactions after saturation occurred.

I do not approve of the changes in these commits. Saturating arithmetic is lossy, adds a precondition on upper bound limit value, plus they had to weaken their assert condition. The issue could have been fixed with precise arithmetic without any such limitations.

This is a tricky issue for a number of reasons:

The logic details of the component in question (SharedObjectCongestionTracker) is not fully clear. It's hard to asses if a certain arithmetic expression is even semantically correct in a particular place.
There are no docs about various value invariants. Eg. a var: u64 is allowed to take any value of type u64 or is there a max limit (that can be computed at run time)? Often there are such limits, but they are unclear and have to be deduced from the code.
Practically any arithmetic operation (eg. +, -, *) can result in overflows which are usually ignored at runtime as cargo flag overflow-checks is false by default in release (overflow checks are enabled in simulator profile). There are some modules with_checked_arithmetic (see below), but the rest of the crates/modules use unchecked arithmetic. So, the main question is "What should be the logic in case of overflows?" Can potential overflows be ignored as unlikely (eg. increment of a u64 value)? Is lossy saturating a viable solution? Is "approximate" value good enough or should the exact value (at the cost of additional computations) be preferred?
No unit tests that cover edge/overflow cases.
There is a number of possible techniques to deal with such cases:

use a correct arithmetic flavour (see below);
cast to a bigger type (eg. u128) and perform arithmetic in it;
statically guarantee that overflows are impossible;
rewrite expression in a safe manner;
provide a newtype wrapper, eg. instead of representing object cost as u64 there can be struct ObjectCost(u64) wrapper type;
provide unit tests to test boundary cases;
Which one should be preferred?

Saturating arithmetic is lossy & potentially dangerous. In some cases it can be avoided entirely.
In some places checked arithmetic is used, in some saturating, in some default. The logic behind such choices is unclear.

with_checked_arithmetic macro provides a syntactic transformation to an annotated module by replacing occurrences of arithmetic operators with checked counterparts panicking on overflows. The implementation, however, doesn't handle functions implemented outside of the guarded module but which are called inside of it. For example, u32::MAX + 1_u32 will correctly overflow and panic, but [u32::MAX, 1_u32].iter().sum() will ignore overflow (with overflow-checks = false). Thus, with_checked_arithmetic makes a false sense of safety. A better solution would be to introduce a struct Checked<T>(pub T) wrapper and implement arithmetic traits for it.
Arithmetic flavours:

default: panic or ignore overflows depending on overflow-checks flag;
stable:

checked: lossy, returns None if overflows;
overflowing (for add/sub): precise, returns overflow flag;
overflowing (for mul): lossy, returns overflow flag;
saturating: lossy, returns U::MAX if overflows;
unchecked: lossy, UB if overflows;
wrapping: lossy, ignores overflows;

nightly:

carrying/borrowing/widening: precise, returns overflow flag/value;
strict: precise, panics if overflows;

For saturating and wrapping arithmetic there are wrapper types in core::num.
Examples. To illustrate these points, let's consider a few examples from the code.
Example 1.
let lowest_available_checkpoint = checkpoint_store
    .get_highest_pruned_checkpoint_seq_number()?
    .saturating_add(1);

Checkpoint sequence number is of type u64 and is incremented by 1 infrequently (say 1 per second). There is no way it can overflow except for bugs or logic errors. Saturating add ignores overflow and silently breaks the invariant (the resulting value or lowest_available_checkpoint is not actually available). A better solution would be to use checked arithmetic and return StorageError in case of overflow.
Example 2.
if start_cost.saturating_add(tx_cost) <= max_accumulated_txn_cost_per_object_in_commit {...}

This is not unlikely case, start_cost can overflow in practice. But if max limit is equal to u64::MAX overflow will lead to logic error: start_cost.saturating_add(tx_cost) <= max is true, but start_cost + tx_cost <= max (as unbounded integers) is false. In such case either max limit can't be u64::MAX (there is no such checks in the code), or it can be avoided entirely by properly handling overflow.
Example 3.
self.total_stake += stake;
self.stake_requested_retry_after
    .entry(retry_after)
    .and_modify(|s| *s += stake)
    .or_insert(stake);

Here, self.total_stake is "total stake of validators that are overloaded and request client to retry". Safety of the code depends whether added stake comes from trusted source (ie. it depends on safety of some other code, but can we really assume so?). If so, the total stake would not exceed the total stake unit supply. Otherwise overflow is possible. In this example the best solution also depends on now the total stake is used later: if it is used in calculating refund amount later then strict arithmetic (panic on overflow) must be used, if it is used as a mere validator overload indicator then it should be safe to use saturating arithmetic.

I propose to introduce the following
ARITHMETIC GUIDELINES

The main issue is overflows: What should be the logic in case of overflows?
Consider probability of overflow:

unlikely (eg. u64 counter overflow);
rare but possible;
likely (eg. u64 total cost overflow).

Consider losses:

huge (eg. total network compromise);
high (eg. possibility of token loss, network DoS);
low (node delay, wallet app crash).

Consider risks (expectations of losses):

critical: use precise (overflowing) arithmetic or panic in case of overflows (strict, checked);
moderate: use saturating when suitable;
low: able to not handle overflows.

Use standard num wrappers (eg. Saturating) or provide custom wrappers.
Prefer precise arithmetic and handle overflows.
Give reasons for using saturating arithmetic.
Provide variable invariants in the docs.
Provide unit tests for edge/overflowing cases.
Avoid with_checked_arithmetic macro except for special cases (where manually unwrapping checked arithmetic results is too noisy).
Common expression patterns:

x += 1 counter -- overflow unlikely, can ignore overflow;
total_cost += cost counter -- overflow likely and critical, panic on overflow;
a+b >= max, max > a+b -- safe to use a.saturating_add(b), comparison will always produce the same result;
a+b > max, max >= a+b:

unsafe to use saturating arithmetic in cases when max == U::MAX;
safe to use saturating arithmetic if max < U::MAX;

a*b -- use overflowing_mul if the product should fit into integer type, cast to double integer type otherwise;
a*b/c<=>d -- can be rewritten as a*b<=>c*d, use double integer types, or as a/c<=>d/b for approximate results.


[Fix_#3465] Adds DMN support to SonataFlow

Fixes https://github.com/apache/incubator-kie-kogito-runtimes/issues/3465
A new DMN custom type (called "dmn") has been added to swf parser.
The mapping is automatically performed from the workflow model (if the name matches), so there is not need to provide args (though we might add argument matching with a a follow up PR)
This is the workflow definition used in the unit test (which just calls the traffiction violation decision from the workflow)
{
  "id" : "traffic-violation",
  "name" : "traffic-violation",
  "version" : "1_0",
  "start" : "traffic-violation",
  "functions" : [ {
    "name" : "DMNTest",
    "operation" : "dmn",
    "type" : "custom",
    "metadata" : {
      "file" : "Traffic Violation.dmn",
      "namespace" : "https://github.com/kiegroup/drools/kie-dmn/_A4BCA8B8-CF08-433F-93B2-A2598F19ECFF",
      "model" : "Traffic Violation"
    }
  } ],
  "states" : [ {
    "actions" : [ {
      "functionRef" : "DMNTest"
    } ],
    "name" : "traffic-violation",
    "type" : "operation",
    "end" : true
  } ]
}

Hi, I opened a thread on the dev mailing list about this, because I didn't saw one there. Let's see if we have an agreement about this there.


Why is the data received from kafka like this?

jarger version is 1.9
kafka version is 0.10
spark version is 2.3
set SPAN_STORAGE_TYPE=kafka and --kafka.encoding json, then i consume kafka message
I think the key is a traceId, the traceId and key in value are different.
The problem I encountered is the same as this issue:
https://github.com/jaegertracing/jaeger/issues/1130

{"traceId":"AAAAAAAAAAADtYnuz5+J/Q==","spanId":"A7WJ7s+fif0=","operationName":"a","flags":1,"startTime":"2019-04-06T10:06:25.640Z","duration":"0.032187s","tags":[{"key":"http.status_code","vType":"INT64","vInt64":"200"},{"key":"component","vStr":"java-web-servlet"},{"key":"span.kind","vStr":"server"},{"key":"sampler.type","vStr":"probabilistic"},{"key":"sampler.param","vType":"FLOAT64","vFloat64":1},{"key":"http.url","vStr":"http://localhost:8080/db/"},{"key":"http.method","vStr":"GET"}],"logs":[{"timestamp":"2019-04-06T10:06:25.642Z","fields":[{"key":"handler.class_simple_name","vStr":"DbController"},{"key":"handler","vStr":"public java.lang.String com.trace.controller.DbController.a()"},{"key":"event","vStr":"preHandle"},{"key":"handler.method_name","vStr":"a"}]},{"timestamp":"2019-04-06T10:06:25.672Z","fields":[{"key":"event","vStr":"afterCompletion"},{"key":"handler","vStr":"public java.lang.String com.trace.controller.DbController.a()"}]}],"process":{"serviceName":"demo","tags":[{"key":"hostname","vStr":"B000000137570D"},{"key":"jaeger.version","vStr":"Java-0.27.0"},{"key":"ip","vStr":"<IP_ADDRESS>"}]}}
spark code:

the record key is the trace-id encoded as hex digits.
the trace-id in the json are encoded as base64

the record key is the trace-id encoded as hex digits.
the trace-id in the json are encoded as base64

Base64 can't decode it.

I also encountered the same problem, and unable to decrypt trace_id using base64.

I used the following class to successfully parse the protobuf messages from Kafka written there by Jaeger collector: https://github.com/PacktPublishing/Mastering-Distributed-Tracing/blob/master/Chapter12/src/main/java/io/jaegertracing/api_v2/Model.java
The class was generated from the main model.proto file by removing gogo annotations.

@code98  you can refer the code (the method  asHexString)
https://github.com/PacktPublishing/Mastering-Distributed-Tracing/blob/master/Chapter12/src/main/java/model/ProtoUnmarshaler.java

@code98 you can refer the code (the method asHexString)
https://github.com/PacktPublishing/Mastering-Distributed-Tracing/blob/master/Chapter12/src/main/java/model/ProtoUnmarshaler.java

are you sure the method 'asHexString' can decode traceid like 'AAAAAAAAAADlP4sqB+IBqA==' ?
my result is '41414141414141414141446C50347371422B494271413D3D' with this method
:(

so how you resolve this ....
now I'm using Python decode traceid from kafka and :<

See #2591.

Would love to get some help as I'm not sure how to best tackle this. Also trying to read exported spans from Kafka using (Kafka-streams) and traceId and spanIds look like the above.
I do want to keep using the original format (i.e. hex digits). Which method should I use to decode it back?
Your help is much appreciated 🙏🏻

@sumancoder https://www.jaegertracing.io/docs/latest/faq/#why-do-jaeger-trace-ids-look-differently-in-kafka-and-in-the-ui

@sumancoder we use a function to manually convert the ID to hex-encoded strings:
export function base64ToHex(s: string): string {
    return Buffer.from(s, 'base64').toString('hex');
}


install command issue

Install command in readme, without -name/-n option.
If update readme, more friendly to install for new be.
serverless plugin install serverless-alexa-skills

  Serverless Error ---------------------------------------

  Serverless command "plugin install serverless-alexa-skills" not found. Did you mean "uninstall"? Run "serverless help" for a list of all available commands.

  Get Support --------------------------------------------
     Docs:          docs.serverless.com
     Bugs:          github.com/serverless/serverless/issues
     Forums:        forum.serverless.com
     Chat:          gitter.im/serverless/serverless

  Your Environment Information -----------------------------
     OS:                     darwin
     Node Version:           9.4.0
     Serverless Version:     1.26.0

$ serverless plugin install

  Serverless Error ---------------------------------------

  This command requires the --name option / -n shortcut. Usage: The plugin name

  Get Support --------------------------------------------
     Docs:          docs.serverless.com
     Bugs:          github.com/serverless/serverless/issues
     Forums:        forum.serverless.com
     Chat:          gitter.im/serverless/serverless

  Your Environment Information -----------------------------
     OS:                     darwin
     Node Version:           9.4.0
     Serverless Version:     1.26.0

it can needed from past.
https://github.com/serverless/serverless/commit/b70acb1594d5733b8cd055526081d53c98920b77#diff-be230fb02e4d1dcff1041a6e9090c5c3

I'll send pr after.

Thank you for you pr ! #7


Reshape the Z array to work with the Gelman-Rubin code (multiproc branch)

Currently the Z array is a 2D array [Nsamples, Nfree].  It need to be reshaped into a 3D array (separating the different chains).  See the GR documentation to find out the required input shape.

Or, edit the Gelman-Rubin code to accept the Z array in it's current shape.


First Stage of Auto Typing Download Work - Detecting new packages

First step of implementing automatic type downloading -  #694 . This pull request just adds an internal interface for detecting when a new npm package is installed. We will hook into this interface to automatically download the typings for new packages.
New Interface
The new interface is the PackagesAdded event on NodeModulesNode. This event is invoked whenever NodeModulesNode detects that a new package has been added.
Adding this logic at this level is a little strange since NodeModulesNode is conceptually a user interface component, but it was the best place I found that had all the module data available and would also know which modules have already been loaded.
Other Changes
The majority of the other changes are simple method extractions from reshaper. I'm still trying to find the best way to hook this work up for testing, and I explored a few different options up and down the object hierarchy. These extractions were made to make testing easier or clarify the existing implementations of various methods.
I still don't have a good story for testing at the level of NodeModulesNode yet though. It's too reliant on UI concepts and too tightly coupled to everything else at the moment.

Hi @mjbvz, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Matt Bierner). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Haven't gotten a chance to take a look at this, but can you instead make this PR on the auto-dts feature branch (just created it)?
https://github.com/Microsoft/nodejstools/tree/auto-dts

Moved to #721 to target the new branch.


New rule: Compose functions should be top-level functions

Non compilant
class A : Activity() {

  @Component
  fun Asdf() {
    // ...
  }
}

Compilant
class A : Activity() {
  // ...
}

@Component
fun Asdf() {
  // ...
}

Context
A composable function shouldn't have access to mutables states that a Activity or Fragment store. For that reason those functions should be declared as top-level functions

When we were transitioning from using Conductor library (alternative to Fragment), we could have:
// base class
class ComposeController : Controller /* a-la Fragment */ {
   val state = mutableStateOf<ViewState>()

   init {
      presenter.stateFlow.onEach { state.value = it }.launchIn(scope)
      composeView.setContent { Content(state) }
   }

   @Composable
   abstract fun Content(state: ViewState)
}

// individual screen
class ScreenController : ComoseController<ViewState>() {
   private val someOtherState = mutableStateOf<MyState>()

   @Composable
   override fun Content(state: ViewState) { renderState(state); renderSometing(someOtherState) }
}

So theoretically private compose functions can be useful when used in inheritance-based frameworks. They could be still factored out as top-level, but all state which came from surrounding class would need to be passed explicitly as an argument.
Of course having this state implicit like this also relies on proper lifecycle management by the base class so that composable doesn't leak, but this could be done.
Anyway, after we've migrated completely away from legacy Fragments/Controllers we now have all "screen" composables as a top-level functions, so this rule makes sense!
And for someone who doesn't wish to follow: it can always be disabled :)

Yes, I agree that this one could be a bit controversial but good on general cases. Maybe this one could be disabled by default. And let users to enable it.


Typo "a Azure Files"→"an Azure Files"

https://learn.microsoft.com/en-us/azure/azure-functions/storage-considerations?tabs=azure-cli
https://github.com/MicrosoftDocs/azure-docs/blob/main/articles/azure-functions/storage-considerations.md
#PingMSFTDocs

Thanks, @hyoshioka0128!


Signing with AWS session credentials

Hi Chengpohi,
First, great plugin. I'm using it and come across an issue where I need to access ES using credentials provided by stsAssume.
It has three parts
aws_access_key_id
aws_secret_access_key
aws_session_token
First two can be entered by
ApiKeyId
ApiKeySecret
but there is no way for entering session token.
As per AWS documentation, it can either be entered as a header 'X-Amz-Security-Token' or part of query string not both. https://docs.aws.amazon.com/IAM/latest/UserGuide/id_credentials_temp_use-resources.html
It would be great if this support can be added.

closed by: https://github.com/chengpohi/edql/issues/4


Detect required linux dependencies.

On a fresh ubuntu install of the pip package, rerun fails with:
ImportError: libXrender.so.1: cannot open shared object file: No such file or directory

As a minimum, need the list of required system deps in the documentation. Better would be catching these import errors and printing a helpful message for the user.

I'd say this is done?


feature request: add grade accuracy to results

curious how you'd feel if we added the grade accuracy of a climb in the results list? it feels a lil confusing if someone filters by grade accuracy, but that value isn't shown to a user in  the results 🤔
that's exposed via the quality property in the api, right? would love to contribute if possible

I think that would be a nice addition. I think it would be even more useful if the difficulty_average was just displayed directly, which is what the database field that the grade accuracy is based off of. One problem I'd be a little worried about is general noise and readability of the list, especially on mobile. In the database, the difficulty_average is a number like 22.01234 which corresponds to something like V6.01234. I think this would be a little confusing to look at, given that we aren't use to decimals in climbing grades. We could add another value next to the rating, but it seems like it could get wordy. Do you have an idea for how we could represent this nicely?
quality is the star rating.

perhaps we make it an opt in feature? we could display a "show grade average" toggle at the top of the search results to control whether the average grade is displayed per result. the toggle could default to off.
if it's on, i could see us either being specific, like displaying Grade average: V6.0023 per result, or display that value next to some sort of icon [src] to reduce real estate. this would only apply to desktop, but we could go further and add a title element witihin the icon to displays Grade average if a user hovers over it and also add the icon to the initial filter search section to better associate the two things.
curious what you think of either of these ideas!

I like the idea of toggling. Maybe just

Where the parentheses value is the +/- over the grade. The toggle could be somewhere below the back link in the result header:

This has been implemented and deployed. I opted to go without the toggle, it seemed clear enough and I felt like toggling may have been more of a source of confusion/hassle then necessary.
Feel free to reopen/create a new issue if you run into any problems with it! Thanks for the idea.


Problem installing cmdstan on Mac

Hi all,
I think this is a known issue but I have not find any solution so far on the web. I ran the below code in MatlabStan:
model = StanModel('verbose',true);
model.compile('stanc');
schools_code = {
'data {'
'    int<lower=0> J;         // number of schools '
'    real y[J];              // estimated treatment effects'
'    real<lower=0> sigma[J]; // s.e. of effect estimates '
'}'
'parameters {'
'    real mu; '
'    real<lower=0> tau;'
'    real eta[J];'
'}'
'transformed parameters {'
'    real theta[J];'
'    for (j in 1:J)'
'    theta[j] = mu + tau * eta[j];'
'}'
'model {'
'    eta ~ normal(0, 1);'
'    y ~ normal(theta, sigma);'
'}'
};
schools_dat = struct('J',8,...
'y',[28 8 -3 7 -1 1 18 12],...
'sigma',[15 10 16 11 9 11 10 18]);
fit = stan('model_code',schools_code,'data',schools_dat);
The error :
compile: make: `bin/stanc' is up to date.
Compile failed with exit value: 2
Error using StanModel/compile
Warning in '/Users/tasos/Desktop/test.stan', line 3, column 4: Declaration of
arrays by placing brackets after a variable name is deprecated and will
be removed in Stan 2.32.0. Instead use the array keyword before the type.
This can be changed automatically using the auto-format flag to stanc
Warning in '/Users/tasos/Desktop/test.stan', line 4, column 4: Declaration of
arrays by placing brackets after a variable name is deprecated and will
be removed in Stan 2.32.0. Instead use the array keyword before the type.
This can be changed automatically using the auto-format flag to stanc
Warning in '/Users/tasos/Desktop/test.stan', line 9, column 4: Declaration of
arrays by placing brackets after a variable name is deprecated and will
be removed in Stan 2.32.0. Instead use the array keyword before the type.
This can be changed automatically using the auto-format flag to stanc
Warning in '/Users/tasos/Desktop/test.stan', line 12, column 4: Declaration
of arrays by placing brackets after a variable name is deprecated and
will be removed in Stan 2.32.0. Instead use the array keyword before the
type. This can be changed automatically using the auto-format flag to
stanc
error: half args and returns was enabled in PCH file but is currently disabled
error: PCH file was compiled for the target 'arm64-apple-macosx12.0.0' but the current translation unit
is being compiled for target 'x86_64-apple-macosx12.0.0'
2 errors generated.
make: *** [/Users/tasos/Desktop/test] Error 1
Error in StanModel/sampling (line 736)
self.compile();
Error in stan (line 138)
fit = model.sampling(p.Unmatched);
Error in eight_schools_example (line 31)
fit = stan('model_code',schools_code,'data',schools_dat);
I am using:
Mac 12.5.1 - Processor M1 Pro
MatlabStan <IP_ADDRESS>
CmdStan-2.30.1
gcc --version
Apple clang version 13.1.6 (clang-13<IP_ADDRESS>.5)
Target: arm64-apple-darwin21.6.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

solved

Hi @magiceule19, I am facing the same problem right now, how did you solve it? Thank you!

hey, you need to install it from somewhere that arm64 is used. For me works through Spyder terminal.
have a look there:https://github.com/stan-dev/cmdstanr/issues/627
Regards


Add 32-bit builds to GitHub Actions CI

Ideally, we should add 32-bit builds to the GitHub Actions CI to prevent problems with 32-bit architectures from creeping into the source code in the future.
https://dev.to/drhyde/automatic-cross-platform-testing-part-6-32-bit-linux-fh2

Need to do the 32-bit builds in a Docker container, I think. Would 32-bit Alpine work?
https://github.com/marketplace/actions/setup-alpine-linux-environment


fix(system-restore): blocking uninstall

https://github.com/longhorn/longhorn/issues/5133

A breaking change is to remove the finalizer mechanism from SystemRestore, but only delete a SystemRestore resource until the dependent resources are deleted (like rollout job). Right?

Deleting the SystemRestore will also delete the dependent rollout job by ownerReference.

@Mergifyio backport v1.4.x


[Website] ROA state

If I edit the default example’s announcement from the attacker to have a /16 prefix an a 777 origin, the ROA state is still invalid when it should be valid

Should be fixed now


ESMValTool setup.py

As a developer I want a setup.py script to build and install ESMValTool.
This will also, for example, allow me as a developer to perform a python setup.py develop into a conda environment, as part of the development workflow.
Using setup.py can also be used as a hook to commence the stock of unit/integration tests with
$ python setyp.py test

Addressing this issue will also include the work of purging calls to sys.path.append peppered throughout the code base ... :scream:

@mkuzak You did some work on this issue, can you add some details and (in case) close the issue?

I think this issue should only be closed if we have a working setup.py which is merged into dev.

First tested and working version of setup.py in commit 780e61962b78679c83eb497b8f22c37e56ad57c9 (currently on branch https://github.com/ESMValGroup/ESMValTool/tree/REFACTORING_tests)
Note that I had to rename the 'orchestrator' directory to 'esmvaltool', because this makes much more sense as a python package name. For now, I only put the renamed 'orchestrator' directory in the package, because this seems to contain the most recent code.
Using setup.py, tests can be run by using 'python setup.py test'.

A working setup.py now available in REFACTORING_backend, I think this issue can be closed, unless we want to wait until it is merged into development or master.


NBT data loss for items on 1.20.1

I have a datapack that allows for smithing templates to be applied to tools. With specifically Paper (I am on 1.20.1-69) the NBT data is semi-randomly cleared.
Steps I took to replicate:

booted fresh 1.20.1-69 server on local
installed datapack to allow for tools to have armor trim applied (nothing else, no plugins, no config changes, etc)
restarted server
gave myself op, changed gamemode to creative, gave myself needed items for recipe
apply template to tool
quickly randomly move tool around inventory/rapidly click on it (if its slow enough it doesnt seem to happen)
NBT data for trim is lost.

Notes:

I was not able to replicate this on a vanilla local server, or singleplayer
I also tested it in survival and experienced the same NBT data loss
all tests were done with a vanilla client (resource packs only)
other NBT data (for enchants, names, etc) is not lost

Attached (redacted) log and datapack.
dp-trimmable-tools-mc1.20-v1.0.4.zip
latest.log

Issue created in docs instead of development, issue closing and creating in correct location


Source maps not working in Safari

Safari may not support the complete set of webpack dev server options.
current configuration is:
    if (isTestEnv) {
        config.devtool = 'inline-source-map';
    } else if (ENV === 'build') {
        config.devtool = false;
    } else {
        config.devtool = 'cheap-module-eval-source-map';
    }

consider using one of the following:  source-map, cheap-source-map, cheap-module-source-map
See https://github.com/survivejs/webpack_react/issues/260

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/34161304-source-maps-not-working-in-safari?utm_campaign=plugin&utm_content=tracker%2F32095848&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F32095848&utm_medium=issues&utm_source=github).

closing this as dup of https://github.com/cmelion/generator-ng2-webpack/issues/27


Inquiry Regarding Confidence Threshold in CZ Detector for VisDrone Dataset

In the paper, it mentions that a confidence threshold of 0.7 was used for the CZ Detector to obtain 1-3 crops per image for a fair comparison. However, in your provided code, I noticed that the confidence threshold is set to 0.85 in the rcnn_crop.py configuration.
In particular, I noticed that when the confidence threshold is set to 1 during evaluation, the AP results are nearly identical to those obtained with a threshold of 0.85, despite no cropped regions being processed when the threshold is set to 1. This outcome raised some questions for me regarding the behavior of the detector under these conditions.
Could you please clarify why this happens, and whether this is expected behavior when the confidence threshold is set to 1? I would also appreciate any insights into why 0.85 was chosen as the default threshold in rcnn_crop.py instead of 0.7.
For more details, during my testing, I used the following command for training:
python train_net.py
--num-gpus 1
--config-file configs/RCNN-FPN-CROP.yaml
OUTPUT_DIR outputs_FPN_CROP_VisDrone
For evaluation, I modified the confidence threshold but did not change any training-related parameters. The evaluation command was:
python train_net.py --eval-only --num-gpus 1 --config-file configs/RCNN-FPN-CROP.yaml MODEL.WEIGHTS model_0089999.pth
I noticed that the confidence threshold is set to 0.85 in the rcnn_crop.py configuration.
(crop_boxes = crop_boxes[crop_boxes.scores>0.85])

Here’s the result of evaluation using a confidence threshold of 0.7:

Here’s the result of evaluation using a confidence threshold of 0.85:

Here’s the result of evaluation using a confidence threshold of 1:

Hi Li,
The threshold of 0.85 might be because I pushed a version when I was experimenting with a different set of values.
When using Faster RCNN, the difference in gain for overall mAP is not that big in my experience too (I got something in the range of 0.3-0.5). However, the small objects AP is improved;  You can also see that when you use 0.7 the APs is 26.19 and when you use 1 (no crops) the APs is 25.61.
However, the FCOS detector had a different profile. For FCOS, the overall mAP showed a difference of 1.2-1.4 when the threshold was set properly. As you can see from the tables in the paper, FCOS performs better than Faster RCNN.
I think Faster RCNN is already filtering ambiguous small object detection in its two-stage process after training with augmented crops. FCOS on the other hand deals with many more candidate regions before the filtering (the NMS), so the detection from scaled crops is helping it with more confident small object detection.


checking different aliases for the same package

Problem:
Importas uses rules to standardize package aliases. But as the project gets bigger, there will be more and more rules and it is difficult to maintain. There may be cases where the same package has different aliases because this package is not covered by the rules. Importas cannot handle this situation because it does not support checking whether there are different aliases for the same package in different go files or in same go file without rules.
solution you'd like.
Checking whether there are different aliases for the same package before checking the aliases according to the importas rules.
Like this :

This little implement, https://github.com/Rodge0/samealias, maybe useful.
Appreciate!

I built https://github.com/grosser/dotfiles/blob/master/bin/golangci-importas-refresh to auto-update the alias setting in golangci which basically does what you wanted, making sure only 1 alias is used for each package
@julz would that be something that can sit in this repo as script, binary, or part of the existing binary ? (I can rewrite it in go for that)


Make long text in README.md easier to read

Current coverage is 97.99% (diff: 100%)

No coverage report found for master at b66e7ed.

Powered by Codecov. Last update b66e7ed...56fd2eb


create icons search input

@hamidrezaramzani
Thanks for your PR. Please create an issue and describe the feature/bug first, then submit your PR.
And use a conventional commit message.

@hamidrezaramzani Thanks for your PR. Please create an issue and describe the feature/bug first, then submit your PR. And use a conventional commit message. (I will create documentation for contributing)

Sure, i close this PR with comment and then create a new one


use_effect with value

Feature Request
Hi,
Could we have a hook that captures the variable that is about to change to store its state in another signal ?
My goal is to manage a page that has a selector which enable to load text in a Vec of structures.
But use_effect get the new value of the reactive value after it has changed.
Some thing like:
 use_effect(move || {

           let _ = my_var.read();

            // do things with the new my_var value, after the update
});
 use_effect_before(move || {

           let _ = my_var.read();

            // do things with the my_var value, before it updates
});

That would be handy and avoid a myriad of signals down the components. Cleaner API.
Any opinion on this?
Thanks

A way to filter the signals that trigger a re loop would be nice:
 use_effect(move || {

           let _ = my_var.read();
           let _ = another_signal_that_should_not_retrigger.read()
});

That would avoid infinite loop management when some effect have signals useful in the callback but that mess up the logic when they are "active" otherwise.

That would be handy and avoid a myriad of signals down the components. Cleaner API.

What use case would use_effect_before simplify? Could you show how you would approach your problem now vs with use_effect_before

A way to filter the signals that trigger a re loop would be nice:

You can use the peek method on signals to read a value without subscribing to the signal


Drag and Drop Feature

Hi,
Do we get the Drag and Drop feature in this tree Widget?
Thanks,
Anjan Kumar M

Hi,
Sadly no.


I am getting ERROR: No key or keyFile set

const {smarthome} = require('actions-on-google');
const app = smarthome({
jwt:'./MyFirstProject_7XXfd.json'
});
app.reportState({
requestId: XXXX,
agentUserId: 'XXX-XXX-XX105',
payload:{
devices: {
states: {
"light-123": {
on: true
}
}
}
}
})
.then((res) => {
// Report state was successful
console.log("Report state was successful in sync");
})
.catch((res) => {
// Report state failed
console.log("Report state failed sync" + res);
});

if I execute this file I am getting error like No key or keyfile set

I added my json file in the same directory where my js file present.

You need to import the JSON file, not pass the filename, ie.
const app = smarthome({
  jwt: require('./MyFirstProject_7XXfd.json')
});

Thank you so much for replying,   I added that now the error is

Report state failed sync{  "error": {    "code": 404,    "message": "Requested entity was not found.",    "status": "NOT_FOUND"  }}

If you are getting a 404, then that likely means the agentUserId you are providing does not yet exist in the homegraph, either because the user disconnected or the user was never added.

I am using my project ID as agentuserId, and hardcoding the device for testing purpose am I going in a rite way or I am not getting exactly what to send in a agentuserId.. can u please help me out on this thank you.

The agentUserId needs to be the same user ID you pass in the SYNC response the first time, and used later on to report the state.

Thank you for your help its working fine now,
I am able to sync data in smart home dashboard now, but while testing through Smart Home Test Suite its getting failed for example  "turn on light" its getting failed, may I know where exactly I am doing wrong.

It's not clear where in the system the command is failing. You may need to do some manual debugging.

can you please provide me the exact payload structure needs to be for Sync , Query and execute.
because I am getting Invalid JSON payload received.

The documentation for processing intents shows the structures you're supposed to send. If you are using the Node.js library with Typescript, you can get the structure as type bindings.

yes i am using Node.js, even for report state do I need to send the same payload ? if answer is yes then I am sending the same payload in report state as per the documentation you have mentioned in above comment but am getting the  error.
This is the payload I am sending to report state api:

"devices":[{"id":"97_fueb4_Switch_Light2","type":"action.devices.types.LIGHT","traits":["action.devices.traits.OnOff"],"name":{"name":"Light2"},"willReportState":true,"attributes":{},"deviceInfo":{"manufacturer":"openHAB","model":"Lighting","hwVersion":"2.1","swVersion":"2.1"},"customData":{"itemType":"Switch","itemTag":"Lighting","openhabVersion":"2.1"}},{"id":"97_fueb4_Switch_Light1","type":"action.devices.types.LIGHT","traits":["action.devices.traits.OnOff"],"name":{"name":"Light1"},"willReportState":true,"attributes":{},"deviceInfo":{"manufacturer":"openHAB","model":"Lighting","hwVersion":"2.1","swVersion":"2.1"},"customData":{"itemType":"Switch","itemTag":"Lighting","openhabVersion":"2.1"}},{"id":"97_fueb4_Switch_Dim","type":"action.devices.types.LIGHT","traits":["action.devices.traits.Brightness","action.devices.traits.OnOff"],"name":{"name":"Dimmer"},"willReportState":true,"attributes":{},"deviceInfo":{"manufacturer":"openHAB","model":"Lighting","hwVersion":"2.1","swVersion":"2.1"},"customData":{"itemType":"Dimmer","itemTag":"Lighting","openhabVersion":"2.1"}}]}

The error I am getting is:

Report state failed sync{ "error": { "code": 400, "message": "Invalid JSON payload received.  Unknown name "devices" at 'payload': Proto field is not repeating, cannot start list.", "status": "INVALID_ARGUMENT", "details": [ { "@type": "type.googleapis.com/google.rpc.BadRequest", "fieldViolations": [ { "field": "payload", "description": "Invalid JSON payload received. Unknown name "agent_user_id" at 'payload': Cannot find field." }, { "field": "payload", "description": "Invalid JSON payload received. Unknown name "devices" at 'payload': Proto field is not repeating, cannot start list." } ] } ] } }

But the device list is showing in dashboard, but only when I test through smart home test suite its getting failed.

Whatever the state I am updating, its updating in the report state dashboard as well when I click refresh button.

But in smart home test suite I am getting this result for the same states updated in the above screenshot, I am confused why some of the test cases are getting failed.

It seems like you may not be reporting on: false in the last case for the Dimmer, if the screenshots were taken at the same time.
For Report State you should be following a payload similar to what you'd return for a QUERY.

yes i am using Node.js, even for report state do I need to send the same payload ? if answer is yes then I am sending the same payload in report state as per the documentation you have mentioned in above comment but am getting the error.
This is the payload I am sending for SYNC request in report state api:

"devices":[{"id":"97_fueb4_Switch_Light2","type":"action.devices.types.LIGHT","traits":["action.devices.traits.OnOff"],"name":{"name":"Light2"},"willReportState":true,"attributes":{},"deviceInfo":{"manufacturer":"openHAB","model":"Lighting","hwVersion":"2.1","swVersion":"2.1"},"customData":{"itemType":"Switch","itemTag":"Lighting","openhabVersion":"2.1"}},{"id":"97_fueb4_Switch_Light1","type":"action.devices.types.LIGHT","traits":["action.devices.traits.OnOff"],"name":{"name":"Light1"},"willReportState":true,"attributes":{},"deviceInfo":{"manufacturer":"openHAB","model":"Lighting","hwVersion":"2.1","swVersion":"2.1"},"customData":{"itemType":"Switch","itemTag":"Lighting","openhabVersion":"2.1"}},{"id":"97_fueb4_Switch_Dim","type":"action.devices.types.LIGHT","traits":["action.devices.traits.Brightness","action.devices.traits.OnOff"],"name":{"name":"Dimmer"},"willReportState":true,"attributes":{},"deviceInfo":{"manufacturer":"openHAB","model":"Lighting","hwVersion":"2.1","swVersion":"2.1"},"customData":{"itemType":"Dimmer","itemTag":"Lighting","openhabVersion":"2.1"}}]}

The error I am getting is:

Report state failed sync{ "error": { "code": 400, "message": "Invalid JSON payload received.  Unknown name "devices" at 'payload': Proto field is not repeating, cannot start list.", "status": "INVALID_ARGUMENT", "details": [ { "@type": "type.googleapis.com/google.rpc.BadRequest", "fieldViolations": [ { "field": "payload", "description": "Invalid JSON payload received. Unknown name "agent_user_id" at 'payload': Cannot find field." }, { "field": "payload", "description": "Invalid JSON payload received. Unknown name "devices" at 'payload': Proto field is not repeating, cannot start list." } ] } ] } }

can you please have a look on this as well

Your report state should look similar to the snippet below. It returns states. It should not be the same as a SYNC response, but like a QUERY response (but slightly modified).
app.reportState({
  requestId: '123ABC',
  agentUserId: 'user-123',
  payload: {
    devices: {
      states: {
        "light-123": {
          on: true
        }
      }
    }
  }
})


phone number validation in user profile

fix and implement validation of phone number input in profile

fix and implement validation of phone number input in profile

it's fixed.


The owners check does not seem to respect the OWNER_CHECKER_IGNORED_OWNERS

Description
We have multiple outside contributors added to a github org repo. The github org does not contain the outside contributors and so complains even tho we have OWNER_CHECKER_IGNORED_OWNERS set.
Expected result
It should ignore the users that are outside contributors.
Actual result
==> Executing Valid Owner Checker (1.05608306s)
    [err] line 19: User "@user1" is not a member of the organization
    [err] line 19: User "@user2" is not a member of the organization
    [err] line 19: User "@user3" is not a member of the organization

Steps to reproduce
.github/CODEOWNERS
* @user1 @user2 @user3 @githuborg/otherteam

.github/workflows/validate-codeowners.yml
name: Validate Codeowners
on:
  pull_request:

jobs:
  validate-codeowners:
    runs-on: ubuntu-latest
    env:
      OWNER_CHECKER_IGNORED_OWNERS: "@user1,@user2,@user3"
    steps:
    - name: "Checkout source code at current commit"
      uses: actions/checkout@v2
    - uses<EMAIL_ADDRESS>      with:
        checks: "syntax,owners,duppatterns"
        github_access_token: "${{ secrets.CODE_OWNER_VALIDATION }}"

Troubleshooting

Tried OWNER_CHECKER_IGNORED_OWNERS
What are some ways around this besides disabling the owners check ?

Hi @nitrocode
Thanks for reporting that. It's a problem with workflow syntax. You need to define it as action argument, not enviromnet variable, see:
name: Validate Codeowners
on:
  pull_request:

jobs:
  validate-codeowners:
    runs-on: ubuntu-latest
    steps:
    - name: "Checkout source code at current commit"
      uses: actions/checkout@v2
    - uses<EMAIL_ADDRESS>      with:
        checks: "syntax,owners,duppatterns"
        github_access_token: "${{ secrets.CODE_OWNER_VALIDATION }}"
        owner_checker_ignored_owners: "@user1,@user2,@user3" # you need to define them as action argument

The codeowners validator can be used directly as binary e.g. locally or on other CI system and also natively as GitHub Action.
When it is used as a GitHub action, the configuration needs to be specified as action arguments. This is the preferred way. You can also use the env variable but then you need to add INPUT_ prefix which GitHub adds by default, so on GitHub action OWNER_CHECKER_IGNORED_OWNERS becomes INPUT_OWNER_CHECKER_IGNORED_OWNERS.
I will update GitHub action documentation to make it clear also for others.
Thanks!

[NOTE] relates to: https://github.com/mszostok/codeowners-validator/issues/73


fix annotation transform bug

Motivation:
when transform annotation props info params. there is a bug . jvm first is true default, so after jvm first added to sofa boot, we tested in wrong env.
Modification:
fix it
Result:

Codecov Report

Merging #54 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master      #54   +/-   ##
=======================================
  Coverage   54.87%   54.87%
=======================================
  Files          51       51
  Lines        1549     1549
  Branches      264      264
=======================================
  Hits          850      850
  Misses        552      552
  Partials      147      147

Impacted Files
Coverage Δ

...pc/boot/runtime/converter/RpcBindingConverter.java
40.38% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e12621...3083a60. Read the comment docs.


update version to 0.0.3

Checklist

[X] Used a personal fork of the feedstock to propose changes
[X] Bumped the build number (if the version is unchanged)
[X] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[X] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

LGTM, don't think your changes would have updated any dependencies, no?

Thanks! Looking at the test_env it seems that the toolkit is the only pin we need.


No Storage Operators for Ceph in OKD 4.6

Hi,
I just installed a fresh Version of OKD 4.6. Accessing the Webconsole and searching for Operators under Operatorhub returns neither the Rook Operator or the Openshift Container Storage Operator. Is this software only in Openshift Enterprise accessible?
Regards Lucas

See https://github.com/openshift/okd/blob/master/FAQ.md#how-can-i-enable-the-non-community-red-hat-operators

Thanks for your quick reply. This means I can not use the Openshift Container Storage Operator for free in Production correct, as it does not  belong to the community operators?
Rook however is as i read Opensource, why is it not included in the OperatorHub?
Do you have recommendation for a Storage Operator, or a Storage Solution that offers Dynamic Provisioning and is free? I installed the Cluster in VMWare.
Thanks and regards Lucas

Rook however is as i read Opensource, why is it not included in the OperatorHub?

That needs to be tracked in https://github.com/operator-framework/community-operators

@lukonjun Until the operator is available in the OperatorHub, you can roll your own install with the files here:
https://github.com/rook/rook/tree/master/cluster/examples/kubernetes/ceph
I have instructions that are opinionated toward my own lab setup here:
https://github.com/cgruver/okd4-upi-lab-setup
These are not updated to the latest version of Rook/Ceph yet, but should still work.


fix: FluentDialog overlay dismiss broken in published release build…

… for Azure SWA
This fix is related to #280 , but for FluentDialog

Pull Request
📖 Description

🎫 Issues

👩💻 Reviewer Notes

📑 Test Plan

✅ Checklist
General

[ ] I have added tests for my changes.
[ ] I have tested my changes.
[ ] I have updated the project documentation to reflect my changes.
[ ] I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

[ ] I have added a new component
[ ] I have added Unit Tests for my new compontent
[ ] I have modified an existing component
[ ] I have validate Unit Tests for an existing component

⏭ Next Steps

I don't think this PR will change the problem indicated in issue #280.
Indeed, the DynamicDependency attribute can be used to inform tooling of a dependency that is otherwise not evident purely from metadata and IL, for example, a member relied on via reflection (see this doc page).
The FluentDialog.razor file does not use reflection. This will not add a sub-component to the Trimming process exclusions. I think the best way to avoid an error like #280 is to create a reference to the dialog box called: var myTempDialog = new MyDialog().

Closing this in favor of the workaround mentioned here. Thanks @dvoituron


Decide how to handle HTML in clues

Today's (Oct. 10, 2021) Sunday puzzle contains clues like:
4 Across: The universe has an estimated 1082  of them
23 Across: Field of Dreams
As of now, any HTML contained in clues is passed through unchanged. How this is handled on the user side depends on the client. Black Ink doesn't process any HTML tags, and shows them verbatim to the user. downforacross.com shows the  tag verbatim but applies the  tag to the rendered clue, yielding italicized text.
How to handle this is a matter of debate. The worst solution IMHO is removing all HTML because that can render clues meaningless; see how 4 Across is handled here. It may be possible to convert certain tags to sensible Latin-1 equivalents; for example the above clue could be rendered as The universe has an estimated 10^82 of them, although whether that is clearer to the average person is debatable. Yet a final option is to leave it as-is, which seems reasonable as long as HTML doesn't appear too often in clues.

Sounds like a good approach! It's interesting to see the html usage in puzzles across time. Great idea to separate out the numeric and non-numeric cases of .
Regarding strikethrough <s> I notice the NYT's .puz version of the June 8, 2014 puzzle (titled "Strike One") renders them as, e.g.:
23 Across: [*cross out* Symbols of happiness] Transmissions with colons, dashes and parentheses?
which is maybe the most sensible way to handle it. Ignoring the markup, or swallowing the entire contents of the <s> tag, would render a less understandable clue IMHO. Granted this case is very rare!

Thanks for the feedback 40dbf7c4ea21bea4242ba48c60e8d080d7a4fbf6 should implement this behavior.


Permit Transport Protocols Managing StreamId

Adding text as suggested by @tmontgomery that permits an implementation to move management of streamId to the underlying transport.

LGTM, I will wait for @tmontgomery to approve.


data-on-close-click wont work for windows

If i use the "data-on-close-click" attrib for windows objects, the js crashed with the error:
o.onCloseClick is not a function
I removed the brackets from Line 297 (window.js) and all work finde...
Utils.exec(o.onCloseClick(), [win], element[0]);

Thank you, I fix it today or tomorrow.

fixed


Enhancement: Show File Name

Would like to see the gcode file name shown some place.
My gcode file names contain information about the job, like order, max depth, speed and bit selection, so it would be nice to easily see this.
EX. Widget_1_0.75D_2S_EM250

Added in v1.8.9.


Feature/improve test script

Closes #152

@rictic can u review this one plz?

Friendly ping
@garlicnation @mikesamuel @cgilson

Due the lack of attention to this PR it will be closed in a few days

due the lack of attention to this PR I'm closing it


Verifying Bcrypt passwords of version '2b' instead of '2a'

Recently I noticed that when I receive Bcrypt hashes from Node.js programs, I can't successfully verify them in Crystal.
Upon closer examination, the issue is that Node.js specified the hash version as 2b.
This version seems unsupported in Crystal, even though for passwords less than 256 chars in length it is identical to 2a which is supported.
Example:
require "crypto/bcrypt"

# Version 2a works
pass = Crypto::Bcrypt::Password.new "$2a$10$XERbBh4EeswcvuiiwFMc8OWfrD3w/AIQ308iGMLSOENWSaKEWhsDy"
p pass.verify "test" # ==> true

# Version 2b silently doesn't work
# (2b has the same hash for password "test", just the version is `2b`)
pass = Crypto::Bcrypt::Password.new "$2b$10$XERbBh4EeswcvuiiwFMc8OWfrD3w/AIQ308iGMLSOENWSaKEWhsDy"
p pass.verify "test" # ==> false

Play: https://play.crystal-lang.org/#/r/cft3
Additional discussion on SO:
https://stackoverflow.com/questions/54135603/why-would-2a-vs-2b-matter

Problem is Password#verify method, which performs a complete comparison (version, cost, salt, digest) and that shouldn't be correct. It should only be comparing the digest of provided hash and that of calculated digest of provided password string.
Fix should require changing the https://github.com/crystal-lang/crystal/blob/6529d725a/src/crypto/bcrypt/password.cr#L68 to something like below
  def verify(password : String) : Bool
    hashed_password = Bcrypt.new(password, salt, cost)
    hashed_pwd_digest = Base64.encode(hashed_password.digest,hashed_password.digest.size-1)
    Crypto::Subtle.constant_time_compare(@digest, hashed_pwd_digest)
  end

Play: https://play.crystal-lang.org/#/r/cfwk

Apparently, there is currently no validation of the version field in a serialized password. I think we should restrict that to only those versions that we know about and are supported. That means 2a, with a fix for this also 2b. I suppose 2 should probably also be supported.


No way to override uid mount setting?

Please use the following bug reporting template to help produce issues which are actionable and reproducible, including all command-line steps necessary to induce the failure condition. Please fill out all the fields! Issues with missing or incomplete issue templates will be closed.
If this is a console issue (a problem with layout, rendering, colors, etc.), please post to the console issue tracker.
Important: Do not open GitHub issues for Windows crashes (BSODs) or security issues.  Please direct all Windows crashes and security issues to<EMAIL_ADDRESS> Ideally, please configure your machine to capture minidumps, repro the issue, and send the minidump from "C:\Windows\minidump".\
See our contributing instructions for assistance.
Please fill out the below information:

Your Windows build number:  (Type ver at a Windows Command Prompt)
10.0.18363.693

What you're doing and what's happening:  (Copy&paste the full set of specific command-line steps necessary to reproduce the behavior, and their output. Include screen shots if that helps demonstrate the problem.)
sudo mount -t drvfs C: /mnt/c -o metadata,uid=1000
cd /mnt/c
sudo touch test.txt
stat -c '%u' test.txt
Output:
1000

What's wrong / what should be happening instead:
Output should be:
0 (root)

Strace of the failing command, if applicable:  (If some_command is failing, then run strace -o some_command.strace -f some_command some_args, and link the contents of some_command.strace in a gist here).

For WSL launch issues, please collect detailed logs.

I admit I'm not sure whether this is a bug or if this is how it's supposed to be, but it just seems wrong that not even the root can override the mount settings for uid. This creates problems for processes in WSL not owned by user 1000 that access the Windows file system, e.g., a web server process running as another user with a virtual host located on the C: drive can't create files that are owned by itself, they're always owned by user 1000. If this is how mounting with a specified uid is supposed to work, then why do it in the first place? Might as well go back to how it was before the feature was added. Unless, of course, there's some setting or option I'm just not aware of that can allow exceptions?

Can't repro here.

[Full disclosure this was on more recent 19569 and WSL1, but that won't matter.]

I think I know what might (?) be happening here. I get nonobvious behavior if I don't umuont(1) /mnt/c first. I think that might be variation my dead crickets #3963. Here is a more complete sequence showing both root and ken in the same directory.

I forgot I already had automount settings in wsl.conf. I unmounted C: and rebooted my computer, but that didn't fix things. The settings in wsl.conf included case=dir. On a hunch, I unmounted C: again and remounted it without the case option. That fixed things. I edited wsl.conf so it's case=off. Do you know why having case=dir would cause this?

You don't have metadata in the options. The default is no metadata.

D'oh! Updated wsl.conf, will unmount and reboot later, let you know how it goes.

[n.b. You're on your own with case=dir.]

Can confirm that it's fixed now. Thanks!


Exercises for understanding the module system

Here's a straightforward one to start:
// Make this compile!

mod sausage_factory {
    fn make_sausage() {
        println!("sausage!");
    }
}

fn main() {
    sausage_factory::make_sausage();
}

Another:
// Make this compile!

mod presidential_frontrunners {
    use self::democrats::HILARY_CLINTON as democrat;
    use self::republicans::DONALD_TRUMP as republican;

    mod democrats {
        pub const HILARY_CLINTON: &'static str = "Hilary Clinton";
        pub const BERNIE_SANDERS: &'static str = "Bernie Sanders";
    }

    mod republicans {
        pub const DONALD_TRUMP: &'static str = "Donald Trump";
        pub const JEB_BUSH: &'static str = "Jeb Bush";
    }
}

fn main() {
    println!("candidates: {} and {}",
             presidential_frontrunners::democrat,
             presidential_frontrunners::republican);
}

Added these in a modules section! Thank you!!! I'm adding this one and the std library types ones first since they're less advanced than the other exercises you've made so I wanted to incorporate them first :) I will add the others though, they're awesome!!