EE does not have access to SSH keys when running a playbook

ISSUE TYPE

Bug Report

SUMMARY
When performing :run <playbook> -i <inventory> with an EE, no SSH connection succeeds using keys. However disabling with --ee false allows execution to work as expected.
ANSIBLE-NAVIGATOR VERSION

ansible-navigator 0.7.2

CONFIGURATION

LOG FILE

210618112952.534 INFO 'ansible_navigator.setup_logger' New ansible-navigator instance, logging initialized
210618112952.534 INFO 'ansible_navigator.setup_logger' New ansible-runner instance, logging initialized
210618112952.534 DEBUG 'ansible_navigator.main' Share directory '/home/student/ansible-latest-complete/lib64/python3.9/site-packages/share/ansible_navigator' not found (development path)
210618112952.534 DEBUG 'ansible_navigator.main' Share directory '/home/student/.local/share/ansible_navigator' found (userbase)
210618112952.534 DEBUG 'ansible_navigator.main' Default collection_doc_cache_path set to: /home/student/.cache/ansible-navigator/collection_doc_cache.db
210618112952.534 DEBUG 'ansible_navigator.main' EDITOR environment variable not set
210618112952.534 DEBUG 'ansible_navigator.main' Default editor_command set to: vi +{line_number} {filename}
210618112952.534 DEBUG 'ansible_navigator.main' No config file set by ANSIBLE_NAVIGATOR_CONFIG
210618112952.534 DEBUG 'ansible_navigator.main' Looking in /home/student
210618112952.534 DEBUG 'ansible_navigator.main' Looking for '/home/student/.ansible-navigator.yml', '/home/student/.ansible-navigator.yaml' and '/home/student/.ansible-navigator.json'
210618112952.534 DEBUG 'ansible_navigator.main' Found 0:
210618112952.534 DEBUG 'ansible_navigator.main' Looking in /home/student/navigator-intro
210618112952.535 DEBUG 'ansible_navigator.main' Looking for '/home/student/navigator-intro/ansible-navigator.yml', '/home/student/navigator-intro/ansible-navigator.yaml' and '/home/student/navigator-intro/ansible-navigator.json'
210618112952.535 DEBUG 'ansible_navigator.main' Found 0:
210618112952.535 DEBUG 'ansible_navigator.main' All found 0:
210618112952.535 DEBUG 'ansible_navigator.main' Using: None
210618112952.535 DEBUG 'ansible_navigator.main' No valid settings file found, using all default values for settings.
210618112952.535 DEBUG 'ansible_navigator.main' Command provided: '--ll debug welcome'
210618112952.535 DEBUG 'ansible_navigator.main' Completed post processing for ansible_runner_artifact_dir. (changed=False)
210618112952.535 DEBUG 'ansible_navigator.main' Completed post processing for ansible_runner_rotate_artifacts_count. (changed=False)
210618112952.535 DEBUG 'ansible_navigator.main' Completed post processing for ansible_runner_timeout. (changed=False)
210618112952.535 DEBUG 'ansible_navigator.main' Completed post processing for cmdline. (changed=False)
210618112952.535 DEBUG 'ansible_navigator.main' Completed post processing for collection_doc_cache_path. (changed=False)
210618112952.535 DEBUG 'ansible_navigator.main' Completed post processing for container_engine. (changed=True)
210618112952.535 DEBUG 'ansible_navigator.main'  before: 'auto'
210618112952.535 DEBUG 'ansible_navigator.main'  after: 'podman'
210618112952.535 DEBUG 'ansible_navigator.main' Completed post processing for display_color. (changed=False)
210618112952.535 DEBUG 'ansible_navigator.main' Completed post processing for editor_console. (changed=False)
210618112952.535 DEBUG 'ansible_navigator.main' Completed post processing for execution_environment. (changed=False)
210618112952.535 DEBUG 'ansible_navigator.main' Completed post processing for execution_environment_image. (changed=False)
210618112952.535 DEBUG 'ansible_navigator.main' Completed post processing for execution_environment_volume_mounts. (changed=False)
210618112952.535 DEBUG 'ansible_navigator.main' Completed post processing for help_config. (changed=False)
210618112952.535 DEBUG 'ansible_navigator.main' Completed post processing for help_doc. (changed=False)
210618112952.535 DEBUG 'ansible_navigator.main' Completed post processing for help_inventory. (changed=False)
210618112952.535 DEBUG 'ansible_navigator.main' Completed post processing for help_playbook. (changed=False)
210618112952.535 DEBUG 'ansible_navigator.main' Completed post processing for inventory. (changed=False)
210618112952.535 DEBUG 'ansible_navigator.main' Completed post processing for inventory_column. (changed=False)
210618112952.535 DEBUG 'ansible_navigator.main' Completed post processing for log_append. (changed=False)
210618112952.535 DEBUG 'ansible_navigator.main' Completed post processing for log_file. (changed=False)
210618112952.535 DEBUG 'ansible_navigator.main' Completed post processing for mode. (changed=False)
210618112952.535 DEBUG 'ansible_navigator.main' Completed post processing for osc4. (changed=False)
210618112952.535 DEBUG 'ansible_navigator.main' Completed post processing for pass_environment_variable. (changed=False)
210618112952.535 DEBUG 'ansible_navigator.main' Completed post processing for playbook. (changed=False)
210618112952.535 DEBUG 'ansible_navigator.main' Completed post processing for playbook_artifact_enable. (changed=False)
210618112952.535 DEBUG 'ansible_navigator.main' Completed post processing for playbook_artifact_replay. (changed=False)
210618112952.535 DEBUG 'ansible_navigator.main' Completed post processing for plugin_name. (changed=False)
210618112952.535 DEBUG 'ansible_navigator.main' Completed post processing for set_environment_variable. (changed=False)
210618112952.535 DEBUG 'ansible_navigator.main' Collection doc cache not mounted
210618112952.535 DEBUG 'ansible_navigator.main' Collection doc cache: 'path' is '/home/student/.cache/ansible-navigator/collection_doc_cache.db'
210618112952.535 DEBUG 'ansible_navigator.main' Collection doc cache: 'current version' is '1.0'
210618112952.535 DEBUG 'ansible_navigator.main' Collection doc cache not attached to args.internals
210618112952.535 DEBUG 'ansible_navigator.main' Running with ansible_runner_artifact_dir as 'Constants.NOT_SET' (Constants/value has not been set)
210618112952.535 DEBUG 'ansible_navigator.main' Running with ansible_runner_rotate_artifacts_count as 'Constants.NOT_SET' (Constants/value has not been set)
210618112952.535 DEBUG 'ansible_navigator.main' Running with ansible_runner_timeout as 'Constants.NOT_SET' (Constants/value has not been set)
210618112952.535 DEBUG 'ansible_navigator.main' Running with app as 'welcome' (str/cli parameters)
210618112952.536 DEBUG 'ansible_navigator.main' Running with cmdline as 'Constants.NOT_SET' (Constants/value has not been set)
210618112952.536 DEBUG 'ansible_navigator.main' Running with collection_doc_cache_path as '/home/student/.cache/ansible-navigator/collection_doc_cache.db' (str/default configuration value)
210618112952.536 DEBUG 'ansible_navigator.main' Running with config as 'Constants.NOT_SET' (Constants/value has not been set)
210618112952.536 DEBUG 'ansible_navigator.main' Running with container_engine as 'podman' (str/default configuration value)
210618112952.536 DEBUG 'ansible_navigator.main' Running with display_color as 'True' (bool/default configuration value)
210618112952.536 DEBUG 'ansible_navigator.main' Running with editor_command as 'vi +{line_number} {filename}' (str/default configuration value)
210618112952.536 DEBUG 'ansible_navigator.main' Running with editor_console as 'True' (bool/default configuration value)
210618112952.536 DEBUG 'ansible_navigator.main' Running with execution_environment as 'True' (bool/default configuration value)
210618112952.536 DEBUG 'ansible_navigator.main' Running with execution_environment_image as 'quay.io/ansible/ansible-navigator-demo-ee:0.4.0' (str/default configuration value)
210618112952.536 DEBUG 'ansible_navigator.main' Running with execution_environment_volume_mounts as 'Constants.NOT_SET' (Constants/value has not been set)
210618112952.536 DEBUG 'ansible_navigator.main' Running with help_config as 'False' (bool/default configuration value)
210618112952.536 DEBUG 'ansible_navigator.main' Running with help_doc as 'False' (bool/default configuration value)
210618112952.536 DEBUG 'ansible_navigator.main' Running with help_inventory as 'False' (bool/default configuration value)
210618112952.536 DEBUG 'ansible_navigator.main' Running with help_playbook as 'False' (bool/default configuration value)
210618112952.536 DEBUG 'ansible_navigator.main' Running with inventory as 'Constants.NOT_SET' (Constants/value has not been set)
210618112952.536 DEBUG 'ansible_navigator.main' Running with inventory_column as 'Constants.NOT_SET' (Constants/value has not been set)
210618112952.536 DEBUG 'ansible_navigator.main' Running with log_append as 'True' (bool/default configuration value)
210618112952.536 DEBUG 'ansible_navigator.main' Running with log_file as '/home/student/navigator-intro/ansible-navigator.log' (str/default configuration value)
210618112952.536 DEBUG 'ansible_navigator.main' Running with log_level as 'debug' (str/cli parameters)
210618112952.536 DEBUG 'ansible_navigator.main' Running with mode as 'interactive' (str/default configuration value)
210618112952.536 DEBUG 'ansible_navigator.main' Running with osc4 as 'True' (bool/default configuration value)
210618112952.536 DEBUG 'ansible_navigator.main' Running with pass_environment_variable as 'Constants.NOT_SET' (Constants/value has not been set)
210618112952.536 DEBUG 'ansible_navigator.main' Running with playbook as 'Constants.NOT_SET' (Constants/value has not been set)
210618112952.536 DEBUG 'ansible_navigator.main' Running with playbook_artifact_enable as 'True' (bool/default configuration value)
210618112952.536 DEBUG 'ansible_navigator.main' Running with playbook_artifact_replay as 'Constants.NOT_SET' (Constants/value has not been set)
210618112952.536 DEBUG 'ansible_navigator.main' Running with playbook_artifact_save_as as '{playbook_dir}/{playbook_name}-artifact-{ts_utc}.json' (str/default configuration value)
210618112952.536 DEBUG 'ansible_navigator.main' Running with plugin_name as 'Constants.NOT_SET' (Constants/value has not been set)
210618112952.536 DEBUG 'ansible_navigator.main' Running with plugin_type as 'module' (str/default configuration value)
210618112952.536 DEBUG 'ansible_navigator.main' Running with pull_policy as 'tag' (str/default configuration value)
210618112952.536 DEBUG 'ansible_navigator.main' Running with set_environment_variable as 'Constants.NOT_SET' (Constants/value has not been set)
210618112952.536 INFO 'ansible_navigator.image_manager.puller._log_message' Image tag is: 0.4.0
210618112952.693 DEBUG 'ansible_navigator.ui_framework.curses_window.init' self._ui_config: UIConfig(color=True, colors_initialized=False, grammar_dir='/home/student/.local/share/ansible_navigator/grammar', osc4=True, terminal_colors_path='/home/student/.local/share/ansible_navigator/themes/terminal_colors.json', theme_path='/home/student/.local/share/ansible_navigator/themes/dark_vs.json')
210618112952.694 DEBUG 'ansible_navigator.ui_framework.curses_window._set_colors' curses.COLORS: 256
210618112952.694 DEBUG 'ansible_navigator.ui_framework.curses_window._set_colors' curses.can_change_color: True
210618112952.694 DEBUG 'ansible_navigator.ui_framework.curses_window._set_colors' term_osc4_supprt: True
210618112952.694 DEBUG 'ansible_navigator.ui_framework.curses_window._set_colors' Custom colors set
210618112952.694 DEBUG 'ansible_navigator.ui_framework.curses_window.init' self._ui_config: UIConfig(color=True, colors_initialized=True, grammar_dir='/home/student/.local/share/ansible_navigator/grammar', osc4=True, terminal_colors_path='/home/student/.local/share/ansible_navigator/themes/terminal_colors.json', theme_path='/home/student/.local/share/ansible_navigator/themes/dark_vs.json')
210618112952.774 DEBUG 'ansible_navigator.actions.welcome.run' welcome requested
210618112952.798 DEBUG 'ansible_navigator.ui_framework.ui._color_lines_for_term' Added color: 16:(807, 568, 470)
210618112952.798 DEBUG 'ansible_navigator.ui_framework.ui._color_lines_for_term' Added color: 17:(403, 588, 901)
210618112952.798 DEBUG 'ansible_navigator.ui_framework.ui._color_lines_for_term' Added color: 18:(337, 611, 839)
210618113003.213 DEBUG 'ansible_navigator.actions.run.run' run requested in interactive mode
210618113003.221 DEBUG 'ansible_navigator.actions.run_0f18._update_args' No config file set by ANSIBLE_NAVIGATOR_CONFIG
210618113003.221 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Looking in /home/student
210618113003.221 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Looking for '/home/student/.ansible-navigator.yml', '/home/student/.ansible-navigator.yaml' and '/home/student/.ansible-navigator.json'
210618113003.221 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Found 0:
210618113003.221 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Looking in /home/student/navigator-intro
210618113003.221 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Looking for '/home/student/navigator-intro/ansible-navigator.yml', '/home/student/navigator-intro/ansible-navigator.yaml' and '/home/student/navigator-intro/ansible-navigator.json'
210618113003.221 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Found 0:
210618113003.221 DEBUG 'ansible_navigator.actions.run_0f18._update_args' All found 0:
210618113003.221 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Using: None
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' No valid settings file found, using all default values for settings.
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Command provided: 'run intranet.yml -i inventory'
210618113003.222 INFO 'ansible_navigator.actions.run_0f18._update_args' 'display_color' cannot be reconfigured. (restore original)
210618113003.222 INFO 'ansible_navigator.actions.run_0f18._update_args' 'mode' cannot be reconfigured. (restore original)
210618113003.222 INFO 'ansible_navigator.actions.run_0f18._update_args' 'display_color' cannot be reconfigured. (apply defaults)
210618113003.222 INFO 'ansible_navigator.actions.run_0f18._update_args' 'mode' cannot be reconfigured. (apply defaults)
210618113003.222 INFO 'ansible_navigator.actions.run_0f18._update_args' 'display_color' cannot be reconfigured (apply previous cli)
210618113003.222 INFO 'ansible_navigator.actions.run_0f18._update_args' 'mode' cannot be reconfigured (apply previous cli)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Completed post processing for ansible_runner_artifact_dir. (changed=False)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Completed post processing for ansible_runner_rotate_artifacts_count. (changed=False)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Completed post processing for ansible_runner_timeout. (changed=False)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Completed post processing for cmdline. (changed=False)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Completed post processing for collection_doc_cache_path. (changed=False)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Completed post processing for container_engine. (changed=True)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args'  before: 'auto'
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args'  after: 'podman'
210618113003.222 INFO 'ansible_navigator.actions.run_0f18._update_args' 'display_color' cannot be reconfigured. (post process)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Completed post processing for editor_console. (changed=False)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Completed post processing for execution_environment. (changed=False)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Completed post processing for execution_environment_image. (changed=False)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Completed post processing for execution_environment_volume_mounts. (changed=False)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Completed post processing for help_config. (changed=False)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Completed post processing for help_doc. (changed=False)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Completed post processing for help_inventory. (changed=False)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Completed post processing for help_playbook. (changed=False)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Completed post processing for inventory. (changed=True)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args'  before: '[['inventory']]'
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args'  after: '['/home/student/navigator-intro/inventory']'
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Completed post processing for inventory_column. (changed=False)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Completed post processing for log_append. (changed=False)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Completed post processing for log_file. (changed=False)
210618113003.222 INFO 'ansible_navigator.actions.run_0f18._update_args' 'mode' cannot be reconfigured. (post process)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Completed post processing for osc4. (changed=False)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Completed post processing for pass_environment_variable. (changed=False)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Completed post processing for playbook. (changed=True)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args'  before: 'intranet.yml'
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args'  after: '/home/student/navigator-intro/intranet.yml'
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Completed post processing for playbook_artifact_enable. (changed=False)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Completed post processing for playbook_artifact_replay. (changed=False)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Completed post processing for plugin_name. (changed=False)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Completed post processing for set_environment_variable. (changed=False)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Collection doc cache not mounted
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Collection doc cache: 'path' is '/home/student/.cache/ansible-navigator/collection_doc_cache.db'
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Collection doc cache: 'current version' is '1.0'
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Collection doc cache not attached to args.internals
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with ansible_runner_artifact_dir as 'Constants.NOT_SET' (Constants/value has not been set)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with ansible_runner_rotate_artifacts_count as 'Constants.NOT_SET' (Constants/value has not been set)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with ansible_runner_timeout as 'Constants.NOT_SET' (Constants/value has not been set)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with app as 'run' (str/cli parameters)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with cmdline as 'Constants.NOT_SET' (Constants/value has not been set)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with collection_doc_cache_path as '/home/student/.cache/ansible-navigator/collection_doc_cache.db' (str/default configuration value)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with config as 'Constants.NOT_SET' (Constants/value has not been set)
210618113003.222 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with container_engine as 'podman' (str/default configuration value)
210618113003.223 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with display_color as 'True' (bool/default configuration value)
210618113003.223 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with editor_command as 'vi +{line_number} {filename}' (str/default configuration value)
210618113003.223 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with editor_console as 'True' (bool/default configuration value)
210618113003.223 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with execution_environment as 'True' (bool/default configuration value)
210618113003.223 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with execution_environment_image as 'quay.io/ansible/ansible-navigator-demo-ee:0.4.0' (str/default configuration value)
210618113003.223 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with execution_environment_volume_mounts as 'Constants.NOT_SET' (Constants/value has not been set)
210618113003.223 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with help_config as 'False' (bool/default configuration value)
210618113003.223 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with help_doc as 'False' (bool/default configuration value)
210618113003.223 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with help_inventory as 'False' (bool/default configuration value)
210618113003.223 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with help_playbook as 'False' (bool/default configuration value)
210618113003.223 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with inventory as '['/home/student/navigator-intro/inventory']' (list/cli parameters)
210618113003.223 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with inventory_column as 'Constants.NOT_SET' (Constants/value has not been set)
210618113003.223 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with log_append as 'True' (bool/default configuration value)
210618113003.223 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with log_file as '/home/student/navigator-intro/ansible-navigator.log' (str/default configuration value)
210618113003.223 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with log_level as 'debug' (str/previous cli command)
210618113003.223 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with mode as 'interactive' (str/default configuration value)
210618113003.223 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with osc4 as 'True' (bool/default configuration value)
210618113003.223 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with pass_environment_variable as 'Constants.NOT_SET' (Constants/value has not been set)
210618113003.223 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with playbook as '/home/student/navigator-intro/intranet.yml' (str/cli parameters)
210618113003.223 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with playbook_artifact_enable as 'True' (bool/default configuration value)
210618113003.223 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with playbook_artifact_replay as 'Constants.NOT_SET' (Constants/value has not been set)
210618113003.223 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with playbook_artifact_save_as as '{playbook_dir}/{playbook_name}-artifact-{ts_utc}.json' (str/default configuration value)
210618113003.223 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with plugin_name as 'Constants.NOT_SET' (Constants/value has not been set)
210618113003.223 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with plugin_type as 'module' (str/default configuration value)
210618113003.223 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with pull_policy as 'tag' (str/default configuration value)
210618113003.223 DEBUG 'ansible_navigator.actions.run_0f18._update_args' Running with set_environment_variable as 'Constants.NOT_SET' (Constants/value has not been set)
210618113003.224 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: container_image:quay.io/ansible/ansible-navigator-demo-ee:0.4.0
210618113003.224 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: process_isolation_executable:podman
210618113003.224 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: process_isolation:True
210618113003.224 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: container_volume_mounts:None
210618113003.224 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: container_options:None
210618113003.224 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: container_workdir:None
210618113003.224 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: private_data_dir:/tmp/ansible-navigator
210618113003.224 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: json_mode:True
210618113003.224 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: quiet:True
210618113003.224 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: cancel_callback:<bound method BaseRunner.runner_cancelled_callback of <ansible_navigator.runner.api.CommandRunnerAsync object at 0x7f31aea75580>>
210618113003.224 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: finished_callback:<bound method BaseRunner.runner_finished_callback of <ansible_navigator.runner.api.CommandRunnerAsync object at 0x7f31aea75580>>
210618113003.224 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: artifacts_handler:<bound method BaseRunner.runner_artifacts_handler of <ansible_navigator.runner.api.CommandRunnerAsync object at 0x7f31aea75580>>
210618113003.224 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: timeout:None
210618113003.224 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: envvars:{}
210618113003.224 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: host_cwd:/home/student/navigator-intro/
210618113003.224 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: executable_cmd:ansible-playbook
210618113003.224 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: cmdline_args:['/home/student/navigator-intro/intranet.yml', '-i', '/home/student/navigator-intro/inventory']
210618113003.225 DEBUG 'ansible-runner._handle_command_wrap' containerization enabled
210618113003.225 DEBUG 'ansible-runner.wrap_args_for_containerization' container engine invocation: podman run --rm --tty --interactive -v /home/student/navigator-intro/:/home/student/navigator-intro/ --workdir /home/student/navigator-intro -v /home/student/.ssh/:/home/runner/.ssh/ --group-add=root --userns=keep-id --ipc=host -v /tmp/ansible-navigator/artifacts/:/runner/artifacts/:Z -v /tmp/ansible-navigator/:/runner/:Z --env-file /tmp/ansible-navigator/artifacts/57af9158-daed-4f73-a799-c3649b9981e3/env.list --quiet --name ansible_runner_57af9158-daed-4f73-a799-c3649b9981e3 quay.io/ansible/ansible-navigator-demo-ee:0.4.0 ansible-playbook /home/student/navigator-intro/intranet.yml -i /home/student/navigator-intro/inventory
210618113003.225 DEBUG 'ansible-runner._handle_command_wrap' command: podman run --rm --tty --interactive -v /home/student/navigator-intro/:/home/student/navigator-intro/ --workdir /home/student/navigator-intro -v /home/student/.ssh/:/home/runner/.ssh/ --group-add=root --userns=keep-id --ipc=host -v /tmp/ansible-navigator/artifacts/:/runner/artifacts/:Z -v /tmp/ansible-navigator/:/runner/:Z --env-file /tmp/ansible-navigator/artifacts/57af9158-daed-4f73-a799-c3649b9981e3/env.list --quiet --name ansible_runner_57af9158-daed-4f73-a799-c3649b9981e3 quay.io/ansible/ansible-navigator-demo-ee:0.4.0 ansible-playbook /home/student/navigator-intro/intranet.yml -i /home/student/navigator-intro/inventory
210618113003.226 DEBUG 'ansible_navigator.actions.run_0f18._run_runner' runner requested to start
210618113003.226 INFO 'ansible_navigator.actions.run_0f18._init_run' Run initialized and playbook started.
210618113003.328 DEBUG 'ansible_navigator.actions.run_0f18._take_step' autoscroll enabled
210618113006.432 DEBUG 'ansible_navigator.runner.api._event_handler' ansible-runner event handle: {'uuid': '178f9e78-7ddc-4bc9-bd84-be914e901f29', 'counter': 1, 'stdout': '', 'start_line': 0, 'end_line': 0, 'runner_ident': '57af9158-daed-4f73-a799-c3649b9981e3', 'event': 'playbook_on_start', 'pid': 25, 'created': '2021-06-18T11:30:06.430731', 'event_data': {'playbook': '/home/student/navigator-intro/intranet.yml', 'playbook_uuid': '178f9e78-7ddc-4bc9-bd84-be914e901f29', 'uuid': '178f9e78-7ddc-4bc9-bd84-be914e901f29'}}
210618113006.433 DEBUG 'ansible_navigator.runner.api._event_handler' ansible-runner event handle: {'uuid': 'c69dd851-3636-5451-1ab7-000000000006', 'counter': 2, 'stdout': '\r\nPLAY [Enable intranet services] ************************************************', 'start_line': 0, 'end_line': 2, 'runner_ident': '57af9158-daed-4f73-a799-c3649b9981e3', 'event': 'playbook_on_play_start', 'pid': 25, 'created': '2021-06-18T11:30:06.433095', 'parent_uuid': '178f9e78-7ddc-4bc9-bd84-be914e901f29', 'event_data': {'playbook': '/home/student/navigator-intro/intranet.yml', 'playbook_uuid': '178f9e78-7ddc-4bc9-bd84-be914e901f29', 'play': 'Enable intranet services', 'play_uuid': 'c69dd851-3636-5451-1ab7-000000000006', 'play_pattern': 'servera.lab.example.com', 'name': 'Enable intranet services', 'pattern': 'servera.lab.example.com', 'uuid': 'c69dd851-3636-5451-1ab7-000000000006'}}
210618113006.446 DEBUG 'ansible_navigator.runner.api._event_handler' ansible-runner event handle: {'uuid': 'c69dd851-3636-5451-1ab7-000000000013', 'counter': 3, 'stdout': '\r\nTASK [Gathering Facts] *********************************************************', 'start_line': 2, 'end_line': 4, 'runner_ident': '57af9158-daed-4f73-a799-c3649b9981e3', 'event': 'playbook_on_task_start', 'pid': 25, 'created': '2021-06-18T11:30:06.445979', 'parent_uuid': 'c69dd851-3636-5451-1ab7-000000000006', 'event_data': {'playbook': '/home/student/navigator-intro/intranet.yml', 'playbook_uuid': '178f9e78-7ddc-4bc9-bd84-be914e901f29', 'play': 'Enable intranet services', 'play_uuid': 'c69dd851-3636-5451-1ab7-000000000006', 'play_pattern': 'servera.lab.example.com', 'task': 'Gathering Facts', 'task_uuid': 'c69dd851-3636-5451-1ab7-000000000013', 'task_action': 'gather_facts', 'task_args': '', 'task_path': '/home/student/navigator-intro/intranet.yml:2', 'name': 'Gathering Facts', 'is_conditional': False, 'uuid': 'c69dd851-3636-5451-1ab7-000000000013'}}
210618113006.447 DEBUG 'ansible_navigator.runner.api._event_handler' ansible-runner event handle: {'uuid': '2102f240-d0f5-46c9-8b16-290bfc18bca1', 'counter': 4, 'stdout': '', 'start_line': 4, 'end_line': 4, 'runner_ident': '57af9158-daed-4f73-a799-c3649b9981e3', 'event': 'runner_on_start', 'pid': 25, 'created': '2021-06-18T11:30:06.446772', 'parent_uuid': 'c69dd851-3636-5451-1ab7-000000000013', 'event_data': {'playbook': '/home/student/navigator-intro/intranet.yml', 'playbook_uuid': '178f9e78-7ddc-4bc9-bd84-be914e901f29', 'play': 'Enable intranet services', 'play_uuid': 'c69dd851-3636-5451-1ab7-000000000006', 'play_pattern': 'servera.lab.example.com', 'task': 'Gathering Facts', 'task_uuid': 'c69dd851-3636-5451-1ab7-000000000013', 'task_action': 'gather_facts', 'task_args': '', 'task_path': '/home/student/navigator-intro/intranet.yml:2', 'host': 'servera.lab.example.com', 'uuid': '2102f240-d0f5-46c9-8b16-290bfc18bca1'}}
210618113006.475 DEBUG 'ansible_navigator.actions.run_0f18._dequeue' Drained 4 events
210618113010.648 DEBUG 'ansible_navigator.runner.api._event_handler' ansible-runner event handle: {'uuid': '70010100-155d-4df4-b761-6aa7eb35b1ad', 'counter': 5, 'stdout': '\x1b[1;31mfatal: [servera.lab.example.com]: UNREACHABLE! => {"changed": false, "msg": "Failed to connect to the host via ssh<EMAIL_ADDRESS>Permission denied (publickey,gssapi-keyex,gssapi-with-mic,password).", "unreachable": true}\x1b[0m', 'start_line': 4, 'end_line': 5, 'runner_ident': '57af9158-daed-4f73-a799-c3649b9981e3', 'event': 'runner_on_unreachable', 'pid': 25, 'created': '2021-06-18T11:30:10.645886', 'parent_uuid': 'c69dd851-3636-5451-1ab7-000000000013', 'event_data': {'playbook': '/home/student/navigator-intro/intranet.yml', 'playbook_uuid': '178f9e78-7ddc-4bc9-bd84-be914e901f29', 'play': 'Enable intranet services', 'play_uuid': 'c69dd851-3636-5451-1ab7-000000000006', 'play_pattern': 'servera.lab.example.com', 'task': 'Gathering Facts', 'task_uuid': 'c69dd851-3636-5451-1ab7-000000000013', 'task_action': 'gather_facts', 'task_args': '', 'task_path': '/home/student/navigator-intro/intranet.yml:2', 'host': 'servera.lab.example.com', 'remote_addr': 'servera.lab.example.com', 'start': '2021-06-18T11:30:06.446697', 'end': '2021-06-18T11:30:10.645695', 'duration': 4.198998, 'res': {'unreachable': True, 'msg': 'Failed to connect to the host via ssh<EMAIL_ADDRESS>Permission denied (publickey,gssapi-keyex,gssapi-with-mic,password).', 'changed': False}, 'uuid': '70010100-155d-4df4-b761-6aa7eb35b1ad'}}
210618113010.649 DEBUG 'ansible_navigator.runner.api._event_handler' ansible-runner event handle: {'uuid': 'acea1d5c-0b98-4620-ad3b-4bd55228f9e9', 'counter': 6, 'stdout': '\r\nPLAY RECAP *********************************************************************\r\n\x1b[0;31mservera.lab.example.com\x1b[0m    : ok=0    changed=0    \x1b[1;31munreachable=1   \x1b[0m failed=0    skipped=0    rescued=0    ignored=0   \r\n', 'start_line': 5, 'end_line': 9, 'runner_ident': '57af9158-daed-4f73-a799-c3649b9981e3', 'event': 'playbook_on_stats', 'pid': 25, 'created': '2021-06-18T11:30:10.648462', 'parent_uuid': '178f9e78-7ddc-4bc9-bd84-be914e901f29', 'event_data': {'playbook': '/home/student/navigator-intro/intranet.yml', 'playbook_uuid': '178f9e78-7ddc-4bc9-bd84-be914e901f29', 'changed': {}, 'dark': {'servera.lab.example.com': 1}, 'failures': {}, 'ignored': {}, 'ok': {}, 'processed': {'servera.lab.example.com': 1}, 'rescued': {}, 'skipped': {}, 'artifact_data': {}, 'uuid': 'acea1d5c-0b98-4620-ad3b-4bd55228f9e9'}}
210618113010.749 DEBUG 'ansible_navigator.actions.run_0f18._dequeue' Drained 2 events
210618113010.938 DEBUG 'ansible_navigator.runner.api.runner_artifacts_handler' ansible-runner artifact_dir set to: '/tmp/ansible-navigator/artifacts/57af9158-daed-4f73-a799-c3649b9981e3'
210618113010.952 DEBUG 'ansible_navigator.actions.run_0f18.update' runner finished
210618113010.952 INFO 'ansible_navigator.actions.run_0f18.update' Playbook complete
210618113010.953 DEBUG 'ansible_navigator.actions.run_0f18.write_artifact' Formatted artifact file name set to /home/student/navigator-intro/intranet-artifact-2021-06-18T11:30:10.953072+00:00.json
210618113010.953 DEBUG 'ansible_navigator.actions.run_0f18.write_artifact' Resolved artifact file name set to /home/student/navigator-intro/intranet-artifact-2021-06-18T11:30:10.953072+00:00.json
210618113010.953 INFO 'ansible_navigator.actions.run_0f18.write_artifact' Saved artifact as /home/student/navigator-intro/intranet-artifact-2021-06-18T11:30:10.953072+00:00.json
210618113014.436 DEBUG 'ansible_navigator.actions.back.run' back requested
210618113014.437 DEBUG 'ansible_navigator.actions.back.run' Return to run_0f18, at last step
210618113014.437 DEBUG 'ansible_navigator.actions.run_0f18.run' No steps remaining for 'run_0f18' returning to calling app
210618113014.439 DEBUG 'ansible_navigator.actions.welcome.run' welcome requested
210618113016.228 DEBUG 'ansible_navigator.actions.back.run' back requested
210618113016.229 DEBUG 'ansible_navigator.actions.back.run' Return to action_runner, at last step
STEPS TO REPRODUCE

ansible-navigator welcome

:run <playbook.yml> -i <inventory>

ansible-navigator --ee false welcome

:run <playbook.yml> -i <inventory>

EXPECTED RESULTS
PLAY NAME        OK CHANGED UNREACHABLE FAILED SKIPPED IGNORED IN PROGRESS TASK COUNT  PROGRESS
0│Enable intranet s 6       0           0      0       0       0           0          6  COMPLETE
1│Test intranet web 2       0           0      0       0       0           0          2  COMPLETE
ACTUAL RESULTS
8│res:
9│  changed: false
10│  msg: 'Failed to connect to the host via ssh<EMAIL_ADDRESS>Permission
11│    denied (publickey,gssapi-keyex,gssapi-with-mic,password).'
12│  unreachable: true
ADDITIONAL INFORMATION
NAME                                     TAG    EXECUTION ENVIRONMENT    CREATED	SIZE
0│ansible-navigator-demo-ee (primary)      0.4.0                   True    3 days ago   1.33 GB
1│ansible-runner                           devel                   True    10 days ago  724 MB

@mweetman-redhat thanks for this.... hope you are enjoying navigator....  I don't have an answer yet as to why this is failing as I wasn't able to recreate it here locally.  In the log file, this is the critical line, where ansible-runner fires up the container.
There's a difference between the above and my lab:
-------- from above -------------

210618113003.225 DEBUG 'ansible-runner.wrap_args_for_containerization' container engine invocation:
podman run --rm --tty --interactive -v /home/student/navigator-intro/:/home/student/navigator-intro/
    --workdir /home/student/navigator-intro
    -v /home/student/.ssh/:/home/runner/.ssh/
    --group-add=root
    --userns=keep-id
    --ipc=host
    -v /tmp/ansible-navigator/artifacts/:/runner/artifacts/:Z
    -v /tmp/ansible-navigator/:/runner/:Z
    --env-file /tmp/ansible-navigator/artifacts/57af9158-daed-4f73-a799-c3649b9981e3/env.list
    --quiet
    --name ansible_runner_57af9158-daed-4f73-a799-c3649b9981e3
    quay.io/ansible/ansible-navigator-demo-ee:0.4.0 ansible-playbook /home/student/navigator-intro/intranet.yml -i /home/student/navigator-intro/inventory

--------- my lab ---------------

210621130231.651 DEBUG 'ansible-runner.wrap_args_for_containerization' container engine invocation:
podman run --rm --tty --interactive -v /home/bthornto/github/nav_install/:/home/bthornto/github/nav_install/
    --workdir /home/bthornto/github/nav_install
    -v /run/user/1000/keyring/:/run/user/1000/keyring/
    -e SSH_AUTH_SOCK=/run/user/1000/keyring/ssh
    -v /home/bthornto/.ssh/:/home/runner/.ssh/
    --group-add=root
    --userns=keep-id
    --ipc=host
    -v /tmp/ansible-navigator/artifacts/:/runner/artifacts/:Z
    -v /tmp/ansible-navigator/:/runner/:Z
    --env-file /tmp/ansible-navigator/artifacts/1afabf65-88f8-4cef-ae75-cafa8312fd81/env.list
    --quiet --name ansible_runner_1afabf65-88f8-4cef-ae75-cafa8312fd81
    quay.io/ansible/ansible-navigator-demo-ee:0.4.0 ansible-playbook /home/bthornto/github/nav_install/site.yaml -i /home/bthornto/github/nav_install/inventory.yaml

What missing is the SSH_AUTH_SOCK and key ring mount.
Can you rpovide the ansible-runner version you have installed?  ansible-runner --version  and maybe try again with a fresh virtual environment?  I'm wondering if there is an older version of runner....

Oh, and try with 0.7.3 or 1.0.0rc1 please.  (these 2 share the same bits and will converge this friday when 1.0.0 is released)

@cidrblock, I'm on the same team as Morgan and I had a similar issue. I saw that my test system did not have the /run/usr/1000/keyring/ssh file until I ran the ssh-agent command. Could your system be running ssh-agent by default? Are there other options available besides SSH (similar to using -k and -K with the ansible-playbook command)? Those options do not work with the ansible-navigator command, but I can create a credential in Ansible Controller that contains a username, password, and become password.

Yes, ssh-agent is running by default.......  if I kill it and unset the var, the playbook fails.
What's interesting ansible-navigator run site.yaml -i inventory.yaml --ll debug --la false --private-key /home/runner/.ssh/id_rsa does work because the .ssh directory is mounted there, what's more interesting
podman run --rm --tty --interactive -v /home/bthornto/.ssh/:/home/runner/.ssh/ --userns=keep-id quay.io/ansible/ansible-navigator-demo-ee:0.4.0 /bin/bash

If I ssh from within the container the identity files used are in /runner
debug1: identity file /runner/.ssh/id_rsa type -1
debug1: identity file /runner/.ssh/id_rsa-cert type -1
debug1: identity file /runner/.ssh/id_dsa type -1
debug1: identity file /runner/.ssh/id_dsa-cert type -1
debug1: identity file /runner/.ssh/id_ecdsa type -1
debug1: identity file /runner/.ssh/id_ecdsa-cert type -1
debug1: identity file /runner/.ssh/id_ed25519 type -1
debug1: identity file /runner/.ssh/id_ed25519-cert type -1
debug1: identity file /runner/.ssh/id_xmss type -1
debug1: identity file /runner/.ssh/id_xmss-cert type -1

not where we mounted them
still researching

interesting this works with docker but not podman, still looking into it.
For now, with podman, I would suggest using ssh-agent since that avoids the podman identity file issues...


Riak client ignoring error codes

Hi,
I found an error related to this one in the server: https://issues.basho.com/show_bug.cgi?id=1324
The client receives a 400 but does not seem to treat it correctly. The problem seems to lie on the method:
public FetchResponse(HttpResponse r, RiakClient riak) throws RiakResponseRuntimeException, RiakIORuntimeException
which treats 300 code, successful codes, but does nothing in case of error codes (500, 400 which is my specific cas). In my example as you can read in the test the server is returning a 400 (which is not correct, it comes from a server bug, but should be detected for the client, not hidden).
The behavior I would expect (maybe I am wrong ;) ) is to get a RiakException when that happens instead of a null IRiakObject.
My fix suggestion is throwing a RiakException if the code is null in FetchResponse but I don't know the code in depth so there might be a better place to do it.
Thanks a lot and keep on working like that!

I was working on a problem last where the java client was not throwing an exception when r was set to greater than n on a request and found what you describe as being the root cause. Once that gets merged into master it will now throw a  RiakResponseRuntimeException on 400 Bad Request responses. I'll have to look at what generates 500s and see if that's also an easy fix.
Thanks for the info!

Welcome!

This has now been merged into master. 4xx except for 404 and 412 (See comments on pull request:https://github.com/basho/riak-java-client/pull/101)  will throw exceptions, as well as any 5xx.


Able to run azure function locally, but when deployed to azure - hitting the endpoint giving 404 Site Not Found error

Is your question related to a specific version? If so, please specify:
Python 3.7.9
What binding does your question apply to, if any? (e.g. Blob Trigger, Event Hub Binding, etc)
Http Trigger
Question
I created a azure function using python extensions in visual code. I am using requests library inside it to hit an external api. When I run it locally it is working as expected but when I deployed it on azure and hit the URL it isn't working (404 Site Not Found). I tried to check whether sample azure function created by visual studio is working or not when deployed to azure, It is working.
requirements.txt
azure-functions
requests

I am deploying azure function through vs code.
Below is the code which when deployed is not working - 404 Site Not Found error is coming.
init.py
import requests
import azure.functions as func

def main(req: func.HttpRequest) -> func.HttpResponse:
    baseuri = 'https://hrshsample.com/Isda.aspx'
    response = requests.post(
            baseuri, req.get_body(), headers=dict(req.headers))
    header = dict(response.headers)
    if 'transfer-encoding' in header.keys():
        del header['transfer-encoding']
    if 'Content-Encoding' in header.keys():
        del header['Content-Encoding']
    return func.HttpResponse(body=response.content.decode("utf-8"), headers=header, status_code=response.status_code, mimetype="text/xml")

@hrsh2512 Hey, could you share your functions app? Please follow this guide to do so: https://github.com/Azure/azure-functions-host/wiki/Sharing-Your-Function-App-name-privately

@hcnirwal1 can you please share your function.json and host.json as well? your function seems to be  very basic, so ideally it should run without any problem. also can you please let us know whats your deployment method means how are you deploying it to azure ? via visual studio code only?


Documentation

Hi guys, is your documentation completed or you need to do more?

We think we are almost complete. You can check it in our repo.


ac_hanami_npc0 OK

Since ac_hanami_npc0 and ac_hanami_npc1 are so similar, I've divided the write-ups for the PR into two sections--the first is shared between them, while the second contains the aspects unique to each file. Hopefully this will reduce the review workload somewhat.
Shared
The Hanami_Npc0 struct
I did my best to document/scaffold the Hanami_Npc0 struct, but I suspect I went too far. Beyond putting in struct members that were explicitly referenced and padding out large sections with UNK_TYPE1 arrays, I also added members that I thought would exist based on alignment rules (e.g. if I know that there's some 1-byte member at 0x7C5, I infer there must also be a 1-byte member at 0x7C4 even though none is explicitly referenced in this actor). That seemed relatively sound, but I was less sure about also including things like 0x7C7 if a one-byte member exists before and after (i.e. at 0x7C6 and 0x7C8). since it could just be a padding byte. Also, anywhere I used u8 instead of UNK_TYPE1 was when there was an explicit access with lbu.
I left in the comments I used while documenting the struct to make the review more straightforward (and make it easier for me to tear out anything that's too speculative), but I assume you'll want me to remove those after the review.
Observations
I thought it notable that in struct_809AEFA4, while the *_talk_init return type is void in the other place it's popped up so far (ac_kamakura_npc0.c), it's s32 here. I suspect that it's a case of immediately returning the integer result of the called clip function (so no return register is explicitly touched) whereas in this file there's an immediate value returned. It's something I'll keep in mind if and when I tackle the NPC clip functions.
Naming

this->unk_7C0 = aHM0_schedule_proc;
this->unk_7D0 = aHM0_act_proc;
this->unk_7A4 = aHM0_think_proc;

All of these functions have the signature
(Actor* thisx, Game_Play* game_play, s32 processIndex)

ac-decomp creates a separate typedef for each individual function class (schedule_proc, act_proc, etc.) and puts them in ac_npc.h. That's probably the appropriate place for them, but using our project's style something like an overall NpcProcFunc analogous to ActorFunc might be in order.

In aHM0_setupAction, this->unk_93C stores a reference to an array of function pointers

static Hanami_Npc0_unk_93C process[] = { aHM0_wait, aHM0_merry, aHM0_drink };
...
this->unk_938 = processIndex;
this->unk_93C = process[processIndex];

all with the function signature
`void (struct Actor*)`

I imagine this will pop up again plenty, so it's probably worth a typedef, but I'm not sure what to call it or where to put it (perhaps also in ac_npc.h?).
Style
I used the same style as the profiles for the ct_data struct--makes it a lot easier to read with all the function pointers.
Changes that affect other files

The actor_draw and actor_move functions would technically match if they took anywhere from zero to two arguments provided the clip function took all arguments passed, but having an ActorFunc signature makes the most sense (and that's what ac-decomp does). In order to implement this, I had to change the signature of the clip functions that these call as well as update the other three NPC files which already included calls using the old signature.

I added a field to the end of the struct_809AEFA4 type used by _ct_data, so I had to update the files that used it by adding an extra NULL to the end of their data. It wasn't clear from looking at the data file whether those last 4 bytes of zeros were padding or part of the struct, but I had alignment problems and couldn't get a match until I added it (which is also in line with ac-decomp).

Unique
Other observations
aTOL_birth_proc takes a *ToolActor as the third argument, which requires a cast when it's called in aHM0_make_tumbler, but ac-decomp uses a plain *Actor. Not sure which is more appropriate.
Other questions
I'm not quite sure what to make of the unk_940 actor struct member. In aHM0_schedule_init_proc, it's used as an index into the angle array, but
it has all but the least significant bit masked out in two functions (aHM0_make_tumbler, aHM0_think_main_proc) and is multiplied by 3 in another (aHM0_set_talk_info).  Also, the way its value is derived is strange, extending the 2-byte fgName with the addition of a magic number 0xFFFF2FCE which doesn't appear anywhere else:
s32 angleIndex = this->actor.fgName + 0xFFFF2FCE;
Could this be some sort of bitwise operation that was optimized out by the compiler? I only found a few similar accesses to this:
./asm/jp/nonmatchings/overlays/actors/ovl_Hatumode_Control/ac_hatumode_control/func_80A8E770_jp.s:
/* 94EA68 80A8E7E8 3C01FFFF */  lui         $at, (0xFFFF2FA8 >> 16)
...
:/* 94EA94 80A8E814 3C01FFFF */  lui         $at, (0xFFFF2FA8 >> 16)
...
/* 94EABC 80A8E83C 3C01FFFF */  lui         $at, (0xFFFF2FA8 >> 16)
./asm/jp/nonmatchings/overlays/actors/ovl_Taisou_Npc0/ac_taisou_npc0/func_809E3BB8_jp.s:
/* 8C73A4 809E3BD4 3C01FFFF */  lui         $at, (0xFFFF2FB2 >> 16)
./asm/jp/nonmatchings/overlays/actors/ovl_Hanabi_Npc1/ac_hanabi_npc1/func_809DDDEC_jp.s:
/* 8C161C 809DDE2C 3C01FFFF */  lui         $at, (0xFFFF2FD8 >> 16)
./asm/jp/nonmatchings/overlays/actors/ovl_Hanami_Npc0/ac_hanami_npc0/aHM0_schedule_init_proc.s:
/* 8C2030 809DE840 3C01FFFF */  lui         $at, (0xFFFF2FCE >> 16)

Hopefully it will become more clear once those overlays are decompiled.
Challenges
aHM0_setupAction was a bear because of the compiler optimizing out the index comparison and instead doing pointer comparisons--had to first identify the fake symbol, and then help from the Discord got it fully matching.

for the tool actor argument it's possible it should just be actor. If we find more instances of it being used I could make a pr to switch it at some point.


HIVE-28522: Fix actions/upload-artifact

What changes were proposed in this pull request?

Replace actions/upload-artifact@v2 with actions/upload-artifact@v4.
Why are the changes needed?

CI pipeline will fail as we use a deprecated actions/upload-artifact@v2.
https://github.com/apache/hive/actions/runs/10827752595/job/30041603070
https://github.com/apache/hive/actions/runs/10830075344/job/30049009968?pr=5444
Error: This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v2. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

Does this PR introduce any user-facing change?

No
Is the change a dependency upgrade?

No
How was this patch tested?

Check the CI.

https://github.com/apache/hive/actions/runs/10831413979/job/30053374116?pr=5446
I don't figure out why it still fails?

maybe the reason on failure is because the github action is configured as "pull_request_target" not "
You can read here https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request_target
This event runs in the context of the base of the pull request, rather than in the context of the merge commit, as the pull_request event does.

@ayushtkn Good catch. I think we can merge this change first. I have tested with my forked hive master branch with the same change(v4 action).
https://github.com/zhangbutao/hive/actions/runs/10843868605/job/30091738355
After merged this change, other commits will be ok.


ARC in real world use

Hi,
Is there a plan to make a software which would convert real world scenes/tasks to/from ARC tasks?
I guess this is not trivial to do but it would be worth as AI researchers would be much more interested in ARC if they saw that ARC helps different general AI algos to be tested in real world usage via the converter + ARC.
br
Lajos

Its a next phase of development of general ai.
Pay attention that all visual tasks here are quantized to pixels and have not many dots in it because of insane complexity of calculations, which first machines+algorithms would do to solve it.
After I read white-paper i was amazed how much work it nerds to do to solve even simpler tasks in required general ai way.

@lkelemen you might be interested in the work of Dileep George and colleagues who have defined and solved tasks which are ARC-like in some ways, but are applicable to real-world robotics. Eg https://arxiv.org/pdf/1812.02788.


OS.mac and Formula.lib_prefix are not working?

it seems both of these  got broken recently (they formula i tried worked some weeks ago):
Error: undefined method `mac' for OS:Module`

and
Error: undefined method `lib_prefix' for <Formulary::Formulae::Openblas:0x000000012d89c0>

sorry, my fault, never mind the issue!


[Shadow of the Demon Lord] Fixed bugs and changed query string so it's more self explanatory.

[Shadow of the Demon Lord] Fixed bug causing issues with the weapon and attributes section in the previous build.

The most obvious bugs on the sheet seem to be fixed with this, please merge ASAP.


Would like PHP syntax colors to be more prominent

Perhaps making the <?php and ?> in red or something that's a stark contrast to the HTML. Right now the PHP snippets and HTML just sort of blend in with each other.

Hi @tzhu07,
you can override the keyword .cm-m-clike.cm-meta to achieve that:
.cm-m-clike.cm-meta {
color: red;
}

which will look something like this:

To do this, you'll need to create a theme and in your package.json you'll need to make sure that _Mode aware styles` are enabled with
"theme": {
  "file": "theme.less",
  "addModeClass": true
},

To get started, see https://github.com/adobe/brackets/wiki/Creating-Themes and sure to post back if you have any issues!

@humphd I can try this as well for lab 5:)

Hello, I'd like to try to help with this bug.

Closing as answered 👍


Run cargo fmt

Just run cargo fmt on the whole repo.

Thanks - I'll do this myself, else you'll get git-blamed for all my bugs in all eternity :)


Feature Request - Support for .NET Core 2.2 and 3.x?

Hi,
I was wondering if there were plans for .NET Core 2.2 and the imminent .NET Core 3.x?

Pinging @allantargino as the maintainer but we are open to contributions here!

Hi @natiki
Currently the .NET Core 2.1 is the main one just because it is the official LTM (long term support). We can try to support both (specially if there is any business case around new features in
https://docs.microsoft.com/en-us/aspnet/core/release-notes/aspnetcore-2.2?view=aspnetcore-2.2).
It should be easy to keep up with all versions, but we need to plan how to support all older versions.
For 3.x, since it is still in preview now, I would prioritize 2.2  - but as @andresmgot said, we are open to contributions :)

Hi,
The way I see things is that "we do" 2.2 and use that as the vehicle to bring down the image size. Ultimately I am happy to go with bitnami/minikube or anything else for that matter as long as we focus on getting the image size down.
I am happy to tackle doing 2,2 along these lines as long as both of you are happy to put up with heaps of questions ;-) as I am a total noob for some of the tech used in kubeless.
@andresmgot is there any chance of placing 2.2 onto the kubless docker repo as previously discussed? I can do the same as @allantargino and spin up my own repo but ultimately it would be best if 2.2 was done where @allantargino and optionally myself were repo owners. That will keep the fracturing to a minimum long term.
Once I have figured out 2.2 then 3.x can be done with minimal effort I am assuming. 3.x can stay as experimental until its release. The reason for the push to 3.x although it is still in preview is that we are already gearing up some new deliverables based on 3.x being available in Sept as per M$ current roadmap.
At that point 2.1, 2.2, 3.x can be maintained and upgraded side by side. And then when .NET 5 surfaces we do that as well. ie Leave 2.1 alone as it works and focus on the rest.
Thoughts?

Hi,
Yes, you can do as many questions as you want :) (I can answer the ones related to Kubeless)

@andresmgot is there any chance of placing 2.2 onto the kubless docker repo as previously discussed? I can do the same as @allantargino and spin up my own repo but ultimately it would be best if 2.2 was done where @allantargino and optionally myself were repo owners. That will keep the fracturing to a minimum long term.

You can use your personal repo in the meantime, later one I can manually copy images to the kubeless registry if needed.


Allow users to display local time in profile

Implements https://codeberg.org/forgejo/forgejo/issues/1089
This allows users to set their timezone in the profile settings, so their local time will be displayed on the profile.
Where does the data came from?
From this CSV
Why use the CSV instead of the built-in timezone support of Go?

Go don't provide a function to list all available timeszones. There are workaround to this, but they are just not more than workarounds.
Go uses the timezone information from the system. You can compile timezone iformation in the binary, but Go still prefers the system timezones. by using the CSV we can be sure every Gitea instance uses the same information by default.
Admins can easily update the timezones if needed

Screenshoots:

As usual, the migration will be added when everything reviewed

Just a thought and question.
Can't we do it in simple js.
Getting the local time zone and set the UTC to local.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/getTimezoneOffset

If we use JS, we can't return the current time with the API. We also can't be sure every users sees the same time. Maybe a timezone changes e.g daylight saving time. In this case, the users will eventually see different times on different devices, depending how up to date it is. Also some people want to use at least JS as possible.

Also some people want to use at least JS as possible.

Include me that,
I understood your solution. Give me today's time to review this change. Will share my findings.


Shrine of the Legend optional for lategame modpacks?

I've found the shrine of the legend to be highly disruptive to my mod pack balanced for going for very long runs and would greatly appreciate a config option to disable it.

How is it disruptive if you aren't obligated to use it? It's also supposed to be very rare, so if you have a mod that makes them more common, then it's on that mod. I don't want to add an option for disabling them because it's nearly useless under normal circumstances and it would spoil the surprise for those who just want to disable certain items in the config.

I guess I can play with the rules established that "oh if this thing appears you're not allowed to use it", but like, a config option doesn't have to say anything about what it does just a disable for structures added by the mod. Also being secretive about the shrine could be cool for some players but I found it just made it a lot harder for me to even figure out what mod added it and if I could disable it to improve the modpack's balance.

I would understand keeping certain features in a mod secret, but that would only work if the initial content was highlighted (for example, a survivor mod doesn't need to explain the challenge behind a skin unlock, for it's up to the players to actually play the character and find out). In this case the mod is adding something completely different from what's advertised and would arguably benefit from pointing it out, aswell as avoid general confusions since that same question will be asked over and over. It's also good practice to let players decide which features they prefer to keep enabled or not.

Changed my mind. This option will be added in the next update.


Improve error reporting: property setter in constructor expression

fixes #1112

I think this one is ready for review.

Looks, good, probably the message needs tweaking though:
The object constructor 'MyClass' has no argument or settable property named 'Property'.  The required
signature is new : unit -> MyClass.
Consider:
MyProperty
MyProperty2
ABigProperty

I thought we were dropping ' for types?
Kevin- do we really need "object constructor" or can "constructor" suffice?

@KevinRansom the "maybe you want part" is from the little helper that we brought in for "elm like" suggestions. We should change it to something that works everywhere. I agree the text should start with "Consider" since that is what we did for other messages as well.

@isaacabraham

I thought we were dropping ' for types?

I'm wasn't aware of this.  In that case, would we then want to update other PRs to not longer use ' for types, such as #1219 and #1229?  I'm fine with any approach so long as it's consistent.

I think we didn't really come to a conclusion about wrapping types in ',
yet.  But since generic types ''a' look weird there is room to improve
that.
On Jun 2, 2016 6:29 PM, "Phillip Carter"<EMAIL_ADDRESS>wrote:

@isaacabraham https://github.com/isaacabraham
I thought we were dropping ' for types?
I'm wasn't aware of this. In that case, would we then want to update other
PRs to not longer use ' for types, such as #1219
https://github.com/Microsoft/visualfsharp/pull/1219 and #1229
https://github.com/Microsoft/visualfsharp/pull/1229? I'm fine with any
approach so long as it's consistent.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/visualfsharp/pull/1228#issuecomment-223346323,
or mute the thread
https://github.com/notifications/unsubscribe/AADgNJV3kaSH2yAGSJ4NRJ3bZhpH-cazks5qHwTbgaJpZM4Ip5Hk
.

Sorry - wasn't my intention to come across so strong there :) Agree 100% consistency - thought ppl had agreed upon no quotes but I guess I wasn't correct there :)

One thing I wish we had done before we started this is define the style of error messages we wanted, like slightly refined from what we have now or the whole shebang like Elm.

@isaacabraham I'm okay with us iterating towards the best style.  Already we understand a lot more about these messages than we did at the start.  The bug fixes are easy to implement, try out and discuss.  I think we are now in a much better state than we were and the more bugs we look at the better our understanding.
Right now we quote replaceable types in messages.  We could change that, it is however, a painful experience, given the various different types of tests we have.

rebased

Merged on behalf of @KevinRansom who is heads-down in tuples, and @otawfik-ms who is heads down in Roslyn Workspaces :)
Thanks for the great contribution @forki, and for @isaacabraham too for kicking off this error message initiative


After upgrading to 0.3, can't use with webpack directly

import { polyfill } from 'smoothscroll-polyfill';
console.log(polyfill) // empty object

import polyfill from 'smoothscroll-polyfill';
console.log(polyfill) // empty object

import { polyfill } from 'smoothscroll-polyfill/src/smoothscroll';
console.log(polyfill) // function! works!

I guess the issue is that the dist file does not contain module.exports but only exports.

Agreed. https://github.com/iamdustan/smoothscroll/blob/master/dist/smoothscroll.js#L278-L280 appears to be the issue. Perhaps this would be better:
if (typeof module==="object" && typeof module.exports==="object") {
  module.exports = UniqueNumber;
}

Sorry, @satazor. Last night I fixed this but forgot to npm run build, this is now fixed in 0.3.2, please update and let me know if the issue is no longer present.

It's working correctly now for me.

Same. Thanks!


demo: flesh out the demo script

Hello @jazzdan, @yuindustries,
Please review the following commits I made in branch nicks/demo3:
a6cf27d73fb299e9542eff8eea0756ac80f08a57 (2018-10-18 16:17:17 -0400)
demo: flesh out the demo script

https://asciinema.org/a/GpvT8wegPD7qkMcLhe7ekhMd2


Support creating tables from a scratch

Overview
After you create a file e.g. table.csv you should be able to add data there. Currently, it's not possible to add columns/rows, only edit existent ones

Hey @roll ! I'm closing this issue for now. Thanks!

Hi @roll! We will review this issue after the launch of the stable version. Thanks!


unneeded files

The latest version on npm contains a node.dtps file which is 28MB, is that really necessary?

AFAICT deleting it doesn't have any effect.

Thanks for reporting this problem<EMAIL_ADDRESS>is now released which avoids adding this large file.


Hi there.

Hi Robert,
I originally intended to fix the problem on the original library where the notifyAll could have been done before the new server thread was listening for it, but a few moments after forking I realized that you had already taken care of it. Thanks!
While I was in there, I updated a few Eclipse config items and did a tiny refactor in the server factory class. If you'd like to include them, here they are.
Have a good one!
-Matt

The project I am working on has been using reflection to clear Dumbster's inbox, so I added a quick little method for that.
Also, I fixed a bug wherein a the String array of headers returned by a message was sized incorrectly.


The list of CI checks in the repo header is broken on Discussion page

Please ensure:

[X] The bug is caused by Refined GitHub. It doesn't happen if I disable the extension.

Example URLs
https://github.com/cli/cli/discussions
Browser(s) used
Firefox
Description

Note that this doesn't happen when navigating using pjax, like when switching tabs in a repo.
Include in this issue:

[X] Screenshots/video/gif demonstrating the bug, if it’s visual
[ ] Console errors, if any

Seems like https://github.githubassets.com/assets/github-<hash>.css isn't loaded on Discussions page. It can be obtained with the icon together though.


Cancelled uploads continue to completion and appear in the collection

I created a collection. I cancelled multiple NaN uploads. The uploads disappeared from the list. Then I allowed a Nan to continue to completion. The final collection shows multiple NaN(s) in the list.

Issue moved to chanzuckerberg/corpora-data-portal #849 via ZenHub

Issue moved to chanzuckerberg/corpora-data-portal #849 via ZenHub


Add Lint check for commas in percentage arrays

I believe it may helpful to add check for commas in percentage arrays of words/symbol.
%w(array, of, words)

Commas in those arrays look like a mistake and more often than not, they are.
There have already been PR considering the issue: #2807, but I wanted to ask for your opinion regardless.

I've got a open, pending PR for this: #3165

@owst :+1:


Update codeql-analysis.yml

Update codeQL analysis from v2 to v3 according to warning of EOL Dec 2024 for v2

Updated code scanning version from v2 to v3 for codeQL


Svgo v2

Ref: #307
NodeJS releases status and END-OF-LIFE
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version ">=10.13.0". Got "8.17.0"
https://github.com/svg/svgo/blob/b37d90e12a87312bba87a6c52780884e6e595e23/package.json#L52-L54
Travis build
https://app.travis-ci.com/github/boopathi/react-svg-loader/jobs/550900558

@boopathi can you review this, please? We use your loader and it fails vulnerability check every build.


Turbo randomly hangs for 60-90 seconds in between task commands during a Docker image build

Verify canary release

[X] I verified that the issue exists in the latest Turborepo canary release.

Link to code that reproduces this issue
https://github.com/ondrej/letsgo/tree/turbo-bug
What package manager are you using / does the bug impact?
Yarn v1
What operating system are you using?
Mac
Which canary version will you have in your reproduction?
1.12.4-canary.1
Describe the Bug
When executing a task (e.g. turbo run build --filter=api...), Turborepo 1.11.0 and higher will frequently, randomly hang for 60-90 seconds before proceeding to the next task. Debugging confirms the previous task completed (e.g. tsc && echo 'Done') and control seems to return back to Turbo, which then waits before successfully moving on to the next task. Running Turbo with -vvv doesn't show Turbo generating any traces between when the previous command completes and when Turbo moves on to the next one. I was never able to reproduce the bug outside of a Docker image build.
Expected Behavior
Turbo will immediately move on to the next command, as it does in versions up to 1.10.16.
To Reproduce

git clone git@github.com:ondrej/letsgo.git
git switch turbo-bug
yarn install
yarn build
cd apps/api
yarn buildx

You may need to run the last command 2-3 times to see the bug reproduce. If you do, change a source file (e.g. edit the log in src/index.ts) to avoid a cached layer.
Additional context
I tested my reproduction with versions 1.10.16, 1.11.0, 1.12.4, and 1.12.4-canary.1. It works on version 1.10.16, fails on the others.
The repro repo uses yarn but the bug reproduces with npm as well.
The bug reproduces frequently, maybe 4/5 times. When it does reproduce, it can reproduce multiple times for multiple commands in a single task, extending total run time by 60-90 seconds for every time it hits.
I experimented with different --concurrency= values but it made no difference.
Docker Desktop for Mac is on version 4.27.1.

Hello, I tried to repro this on linux + podman and with macos + docker desktop and can't seem to get the hang. I will mention that to make buildx play nicely with turbo you should probably ensure it is logging in 'plain' mode (rather than 'tty' mode). The latter will break formatting which (maybe..?) causes turbo to look like it's not doing anything.
To give more detailed advice given I can't reproduce I would request you produce a profile (using the --profile flag)

I have CI job hang indefinitely until the CI timed out (6h)
https://github.com/repobuddy/repobuddy/actions/runs/8490047264/job/23260750272
Also observe the same issue on Macbook randomly, from multiple people.

Hey @unional I let my machine run overnight with the command that failed on CI using node 20 to try to collect a profile and can't repro it. If you are able to run turbo with the --profile command for a while and upload the result I can try to investigate.


Transformer no load loss units?

It apppears that the "xfmr_nll_ts" output may in fact be in kWh rather than kW as it's labeled:
from lib_pv_io_manager.cpp line 805:
p_transformerNoLoadLoss = cm->allocate("xfmr_nll_ts", numberOfWeatherFileRecords);
from cmod_pvsamv1:
line 2154: ssc_number_t xfmr_nll = PVSystem->transformerNoLoadLossFraction * static_cast<ssc_number_t>(ts_hour * transformerRatingkW);
line 2164: ssc_number_t xfmr_loss = xfmr_ll + xfmr_nll; // kWh
line 2182: PVSystem->p_transformerNoLoadLoss[idx] = xfmr_nll;
@sjanzou could you please confirm or contradict when you have a chance?

This issue was first reviewed and closed in pull request 353 and SAM issue 274. The timestep values were indeed in kWh and have been updated to kW and tested with project files from SAM issue 274 and updated in ssc_400 branch. See pull request #401

Verification of 30 min weather file and annual values and comparison with hourly data from SAM  274 and pull request #353
GitHubIssuesSAM_274_ssc_400.docx
30min sub hourly.xlsx

Closed with pull request #401


Is it possible to download or get the contents from a single file in a remote using go-git

I have a situation where I need to get the contents of a single JSON file from my companies remote repo from within one of my Go programs. Does this package provide a method for doing that? From the CLI you can achieve similar functionality using a command similar to
git archive<EMAIL_ADDRESS>HEAD path/to/file.json | tar -x
Just curious if it's possible to do something similar directly in Go.

Not in a particularly efficient way. You can just clone the repository (you can clone just HEAD to save bandwidth and storage) and look up the file.


set vespa version

@tokle please merge - this works, tested from a blank laptop

I've added the same version on all samples.


chore: Required for runtime GA: add api-extractor

-runtime libraries' public methods are currently too frequently update to make api-extractor worthwhile, so add it in right before GA.
Steps:

Copy api-extractor.json from another library,
Add "test:compat": "api-extractor run --verbose" to package.json scripts
Run yarn test:compat
Fix any errors
Copy ./temp/*.md file to ./etc/*.md
Run yarn test:compat
Commit changes

Reviewed by the SDK team. Closing as Not Needed.


Restore package-lock.json

Deleting it in 2bf4d44b51f72b307ee7a5decfb3f3e2c192849c caused CI to fail.
Please don't let CI fail...

8be4b4a4c36bfb1be5e47cf967d19f03ae82eb86


ASP.NET Core Identity Cosmos DB SQL API Support

Is there any plan to support ASP.NET Core Identity with Cosmos DB?

Not directly, the EF Core backing identity can use Cosmos DB, so there's no need for us to get specific.
There are 3rd party implementations for the specific documentdb api
https://github.com/codekoenig/AspNetCore.Identity.DocumentDb
https://github.com/FelschR/AspNetCore.Identity.DocumentDB

We're closing this issue as the behaviour discussed seems to be by design.


Allow different separators in customer_order_ref.

Change
def customer_order_ref(self) -> str:
    return "{0}-{1}".format(self.trade.strategy.name_hash, self.id)

to:
def customer_order_ref(self) -> str:
    return "{0}{1}{2}".format(self.trade.strategy.name_hash, self.sep, self.id)

, where self.sep defaults to '-'

Validation on type and length on init?

Validation on type and length on init?

I'll set it to length 1, and conform to allowed characters specified in here:
https://docs.developer.betfair.com/display/1smk3cen4v3lu3yomq5qye0ni/placeOrders


Automated Package Upgrade

:tada: This PR is included in version 5.0.319 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add a method to create an id if "id" is not specified.

@AustinLMayes Good work! I believe @KyloCode is away, so he won't be able to merge it.

Sounds good. I do dislike the online ifs though :P


[BEAM-12589] - exclude testTwoTimersSettingEachOtherWithCreateAsInput…

…Unbounded from Dataflow ValidatesRunner tests.
See discussion in https://github.com/apache/beam/pull/15135#issuecomment-877372199.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Java Dataflow V2 ValidatesRunner

Run Dataflow ValidatesRunner

Run Java PreCommit

This test should already be excluded due to the requires timer ordering tag. Is it not?

This test should already be excluded due to the requires timer ordering tag. Is it not?

The test is running in 'batch' ValidatesRunner tests. Can we exclude that whole category for batch?
e.g.:
https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/6697/testReport/org.apache.beam.sdk.transforms/ParDoTest$TimerTests/testTwoTimersSettingEachOtherWithCreateAsInputUnbounded/
https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/6696/testReport/org.apache.beam.sdk.transforms/ParDoTest$TimerTests/testTwoTimersSettingEachOtherWithCreateAsInputUnbounded/

We should be able to I think.

We should be able to I think.

OK -- one sec, I'll do it now.

Add org.apache.beam.sdk.testing.UsesStrictTimerOrdering  to commonLegacyExcludeCategories

Although this test was never excluded from batch in the past. Do you have an example of the failure?

Although this test was never excluded from batch in the past. Do you have an example of the failure?

Yes, I commented two examples above. The last 2 or 3 VR attempts have failed due to the test for both legacy/V2 runners.

Actually looking at the code for Dataflow batch, it looks like it does not handle this case correctly and the test was only excluded for streaming, so the failures there are expected. pr/15123 (out for review)  fixes Dataflow streaming and removes the exclusion, but looks like I have to fix Dataflow batch as well!

Actually looking at the code for Dataflow batch, it looks like it does not handle this case correctly and the test was only excluded for streaming, so the failures there are expected. pr/15123 (out for review) fixes Dataflow streaming and removes the exclusion, but looks like I have to fix Dataflow batch as well!

Aha! OK cool. We can leave this unmerged then if you're planning to fix the batch soon?

LGTM (pending verification)
I would suggest merging this. pr/15123 has some complexities and is still out for review, and we should prioritize getting green test runs.

Run Dataflow ValidatesRunner

Run Java Dataflow V2 ValidatesRunner

Run Dataflow Streaming ValidatesRunner

Run Java Dataflow V2 ValidatesRunner Streaming

@reuvenlax the tests are passing, the category is excluded. Please merge when you get a chance!

PreCommit failures unrelated.


Donation Account>UI issue

On Android devices, Showing a rectangular outline on the "Donation Webpage" button.

-Vrified this issue on dev app v1.7.5(300)


Changing Time Capsule/AirPort country (apple-sku)

I have some instructions on how to change the value "apple-sku" in my Time Capsule using ssh, but I am stopped by not being allowed to communicate through port 22.
Can anyone tell me how I open ssh communications to my TC, or Airport Extreme?

Try this #1

@1gr8dane can you please share the instructions for to change country code


Move dev dependencies to requirements-dev.txt (#61)

I used pip-tools to generate a requirements file. Also added a
Makefile to emulate how the requests package is laid out. Added
some documentation for using pip-tools. Finally, removed the
attrs dependency which wasn't really being used heavily enough
to justify its inclusion on this project.

This isn't working as intended, yet. It is supposed to install trio-websocket in the development environment, so I put -e . in the dependencies file, but pip-compile expands this to a full path that only exists on my machine -e file:///Volumes/Case_Sensitive/trio-websocket. There's an issue filed on pip-tools but it looks like it's a complex interaction between pip and pip-tools that isn't likely to be solved anytime soon. I'll take another shot at this tomorrow.

It's certainly possible to get by without using "-e .".  Just prefix commands with appropriate setting of PYTHONPATH.
test:
	PYTHONPATH=. pytest --cov=trio_websocket

Pull Request Test Coverage Report for Build 81

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.5%) to 91.644%

Totals

Change from base Build 71:
0.5%

Covered Lines:
340

Relevant Lines:
371

💛  - Coveralls

This still doesn't work for RTD builds. RTD does not use the Makefile, so it does not know where trio-websocket is. RTD can be configured to install from setup.py, but then it installs packages that conflict with requirements-dev.txt. I've pushed a quick fix on master that abandons pip tools and uses a hand-written requirements-dev.txt instead.


check word boundaries before replace

(closes #687 )
What was wrong?
While creating a new fork for Shanghai using Paris, the new fork tool replaces paris in the word Comparison with shanghai. This should not happen.
Related to Issue #687
How was it fixed?
Check word boundaries before replace

Codecov Report
Patch and project coverage have no change.

Comparison is base (410f99e) 71.89% compared to head (c1fee23) 71.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #732   +/-   ##
=======================================
  Coverage   71.89%   71.89%
=======================================
  Files         570      570
  Lines       31572    31572
=======================================
  Hits        22698    22698
  Misses       8874     8874

Flag
Coverage Δ

unittests
71.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


feat(ui): support table partitioned details

Describe your changes:
Fixes #12992

I worked on ... because ...

Type of change:

[ ] Bug fix
[ ] Improvement
[ ] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] My PR title is Fixes <issue-number>: <short explanation>
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@chirag-madlani are we going to close this?

@chirag-madlani are we going to close this?

Yes. I need to make few changes and we can merge this 🚀

@harshach can you review it again?


Adding Romanian date resources

This PR adds partial support for the Romanian language, which can be used to make aria.utils.Date.format return formatted dates in Romanian.

@fbasso Thank you for your review!


shell

How to do shell interaction

This feature is not currently available, though is coming soon. If you really need to execute a command you can use the sharpwmi command to do so.


[GOBBLIN-960]Resolving multiple templates in top-level

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

https://issues.apache.org/jira/browse/GOBBLIN-960

Description

[ ] Here are some details about my PR, including screenshots (if applicable):
It contains some fixes on access-modifier of Avro2ORC while reading through code, but the major part is to enabled gobblin.templates.uri to be able to accept multiple templates.

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

@jack-moseley  @sv2000  Can you take a look once you have time? Thanks

Codecov Report

Merging #2809 into master will decrease coverage by 0.94%.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##             master    #2809      +/-   ##
============================================
- Coverage     45.47%   44.52%   -0.95%
+ Complexity     8908     8750     -158
============================================
  Files          1899     1899
  Lines         71096    71130      +34
  Branches       7833     7846      +13
============================================
- Hits          32332    31674     -658
- Misses        35784    36517     +733
+ Partials       2980     2939      -41

Impacted Files
Coverage Δ
Complexity Δ

...in/java/org/apache/gobblin/util/AvroFlattener.java
71.33% <ø> (ø)
33 <0> (ø)
:arrow_down:

...he/gobblin/runtime/template/StaticJobTemplate.java
82.5% <100%> (+3.08%)
14 <1> (+1)
:arrow_up:

...rg/apache/gobblin/runtime/AbstractJobLauncher.java
58.99% <100%> (-0.15%)
34 <5> (+1)

...n/java/org/apache/gobblin/runtime/api/JobSpec.java
80.13% <80%> (-0.01%)
17 <0> (ø)

...obblin/runtime/template/InheritingJobTemplate.java
90.36% <81.39%> (+0.22%)
29 <3> (+9)
:arrow_up:

...re/filesystem/FsDatasetStateStoreEntryManager.java
0% <0%> (-100%)
0% <0%> (-3%)

...askStateCollectorServiceHiveRegHandlerFactory.java
0% <0%> (-100%)
0% <0%> (-2%)

...gobblin/runtime/mapreduce/GobblinOutputFormat.java
0% <0%> (-100%)
0% <0%> (-2%)

...in/runtime/mapreduce/CustomizedProgresserBase.java
0% <0%> (-83.34%)
0% <0%> (-1%)

...rg/apache/gobblin/runtime/ZkDatasetStateStore.java
0% <0%> (-80.77%)
0% <0%> (-7%)

... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a714c94...9fa6a54. Read the comment docs.


Mark ZMQ tests as local because they don't need a DFK

This will run these tests with --config local instead of once per DFK configuration.
Changed Behaviour
Nothing user facing. These tests shouldn't be interacting with the surrounding DFK, so the absence of a DFK shouldn't affect test behaviour.
Type of change

Code maintenance/cleanup

this was done in #3030 - no need to merge this


Beginner questions

Hello,
I'll start with a disclaimer saying that I am a novice when it comes to reinforcement learning and RL frameworks. My goal is to determine if applying specific structural changes to the MultiAgentMLP and to the loss in various algorithms would lead to different outcomes for specific tasks. For this purpose I wanted to work with an environment where the agent reward has a shared and individual component, have the agents not share parameters or critics or observations. I think that I managed to select a baseline this by using the simple_reference environment and setting share_policy_params: False, share_param_critic: False and using the MADDPG/IDDPG algorithm.
However, I am confronted with 2 questions:

What would be the best approach to implement logging per agent so that we can see individual losses and rewards even if the agents are part of the same group?
Did I understand correctly that in the DDPG loss, the loss_actor for example is first computed per agent (as it has the shape batch_size x n_agents) and then it's reduced to an average which is a single number that is used to calculate the gradients for both agent's MLPs? I was guessing that each agent would have its own loss component drive its MLP's gradients.

Hey!
Thanks for reaching out, feel free also to use the discord link in the readme if you want to PM me directly.

What would be the best approach to implement logging per agent so that we can see individual losses and rewards even if the agents are part of the same group?

For rewards and other data that comes from collection, I normally use the callbacks to log custom stuff or per-agent things.
For example in on_batch_collected you can do something like this
    def on_batch_collected(self, batch: TensorDictBase):
        for group in self.experiment.group_map.keys():
            keys_to_log = [
                (group, "logits"),
                (group, "observation"),
                (group, "reward"),
                (group, "estimated_snd"),
                (group, "scaling_ratio"),
            ]
            to_log = {}

            for key in keys_to_norm:
                value = batch.get(key)
                for i,agent in enumerate(self.experiment.group_map[group]):
                    to_log.update(
                        {f"{key}_{agent}": torch.mean(value[...,i,:]).item()}
                    )
            self.experiment.logger.log(
                to_log,
                step=self.experiment.n_iters_performed,
            )

For losses, there is no way to log individual lossess (unless you modify the loss class) and they are aggregated within the loss class itself. My suggestion here, if you really want to log individual losses is to put agents in different groups.

Did I understand correctly that in the DDPG loss, the loss_actor for example is first computed per agent (as it has the shape batch_size x n_agents) and then it's reduced to an average which is a single number that is used to calculate the gradients for both agent's MLPs? I was guessing that each agent would have its own loss component drive its MLP's gradients.

You seem to understand correctly. However, averaging them toghether won't cause any mixing issues. This is because summing values coming from different networks and then taking the gradient of that value with respect to each individual network will discard the contributions from the other elements in the sum.
if you have $L = f_\theta(x) + g_\eta(x)$ then $\frac{\partial L}{\partial \theta} = \frac{\partial f}{\partial \theta}$ and $\frac{\partial L}{\partial \eta} = \frac{\partial g}{ \partial \eta}$

Thank you Matteo, on_batch_collected worked beautifully at least for logging episode_reward.
The derivative explanation makes perfect sense.
I realized that putting each agent in a different group, at least in case on MADDPG, would be wrong because the agents wouldn't be able to share experience.

Yeah that is the catch... but if it is just for debugging it won't matter much.
I'll close this now, feel free to reopen if you have further problems.


Security baselines for Azure Services mapping to Azure Security Benchmark(v2) not available

Security Baselines for Azure Services defined are based on Azure Security Benchmark(v1) . when if expected to map to revised Azure Security Benchmark(v2) be available for each Azure services providing security configurations for all categories under v2 benchmarking/Controls

Thanks for leveraging Azure docs feedback channel to raise this question. This channel is reserved for ‘Azure docs’ feedback- for sharing doc feedback and suggesting content improvements. Could you please share the Azure documentation for which this feedback is applicable to?

I am referring to Security baselines for Azure documentation.  Please follow this link - https://docs.microsoft.com/en-us/security/benchmark/azure/security-baselines-overview
There is security baseline for each Azure service separately based on Azure Security benchmarks - https://docs.microsoft.com/en-us/security/benchmark/azure/overview-v1
I suppose security benchmarks are revised with v2 release - https://docs.microsoft.com/en-us/security/benchmark/azure/overview
I am looking for a security baseline for each azure service based on domains specified under v2. Most of the service baseline currently are based on domains specified in v1 only handful is based on v2

@Sudhirga
Thank you for the quick follow up on this!
Since you're looking for more specific security baselines for the different Azure services (i.e. Network security, Identity Management, etc.) within the Azure Security Benchmark (V2) domains. Did the Overview of the Azure Security Benchmark (V2) documentation not have the information you were looking for?
I'd also recommend reaching out to the Azure Security Benchmark team via their Azure Security Benchmark Feedback form.

If you have any other questions, please let me know.
Thank you for your time and patience throughout this issue.

@Sudhirga
I just wanted to check in and see if you had any other questions or if you had a chance to review my previous comment?


Pre-loading background noise (and IR) in init?

If one of the objective of torch-audiomentations is to do fast augmentation on GPU as part of a larger network, reading from disk for each new audio sample would slow down the forward pass dramatically, wouldn't it?
https://github.com/asteroid-team/torch-audiomentations/blob/02752c9d6b7892c67d541af0c5279ec00f8216e3/torch_audiomentations/augmentations/background_noise.py#L47-L51
Would it make sense to allow the user to preload the whole background noise collection in memory during __init__ and then read from memory in apply_transform?

I've tried both, and it turns out that when I have a fast SSD and a swift wav loader, it doesn't really make much of a difference, as the bottleneck is usually elsewhere.
In my case, I had like 6 GB of IRs, which I didn't want to keep in memory, and I had a fast SSD. In a different scenario where the IR files are much fewer/smaller and I/O is a bottleneck, it does indeed make sense to cache these files.

I usually have 64GB or more of RAM but quite slow I/O, so yes, it makes complete sense.

This is more complicated, because you don't know what the user can afford etc.. But still doable.
But the first option is definitely possible and a preload_wavs flag or something like that could completely do the job.

Yes. Big RAM, slow I/O as well, here :)

But the first option is definitely possible and a preload_wavs flag or something like that could completely do the job.

also maybe caching as they are read.

Maybe better than loading everything at the beginning, yes. So we don't have to wait when we instantiate the class.


Let the Prettier formatter do its thing

I'm now using Prettier as a JS formatted and it wanted to adjust my formatting.
Doing this as a separate PR as it's only formatting changes which can cloud other PRs with noise. There are no functionality changes here.
Merge after #940

This is now good to go, right?

I've clicked "Update branch" here, which maybe I shouldn't have give there's the other branch also based on these changes (a rebase would be clearer, I think). I can fix that up but I don't want to force push your branches.
Just let me know or update and merge yourself, I'm marked them approved!


"class" keyword is not highlighted

Example:
class Dillo(val tailLength : Int)

Produces this HTML:

class Dillo(val tailLength : Int)

Same for object, enum and interface
object MyObject {}
interface MyInterface {}
enum class MyEnum {}

#20 will solve it.


deploy.php for laravel error

Deployer 3.0.6 on mac

When I use this:
require 'recipe/laravel.php';
server('prod1')
    ->user('root')
    ->env('deploy_path', '/var/www/deploy')
    ->env('branch', 'master')
    ->stage('production');

then run dep deploy -p production I got error Unable to login with the provided credentials.   .
I find the server default use config file ~/.ssh/config to auth from source code. I can use ssh prod1 to login server.
When I add ->configFile('~/.ssh/config'), I got error You need to specify authentication method.  It's very strange.
So anybody know what's the problem, how can I fix it?
Thanks!

Hello, anybody here? Is it a bug?
I'm not  clear how to debug or develop deployer, I want to help, is there any development intro?
Thanks!

Dear @mani95lisa,
Using config file for authentication only be supported by ext-ssh2.
Please try install ext-ssh2 and add this line to deplo.php file:
require 'recipe/laravel.php';
set('ssh_type','ext-ssh2'); // <-- add this line
server('prod1')
    ->user('root')
    ->env('deploy_path', '/var/www/deploy')
    ->env('branch', 'master')
    ->stage('production');

Otherwise, please try other authentication method.

@oanhnn Thanks，I installed ssh2, and error gone, but new problem got.
dep deploy -p production -vvv
➤ Executing task deploy:prepare
⤷ on [prod]

Whatever I use config or servers.yml or identityFile method to deploy, I got above informations.
And progress is paused, no error or anything else.
require 'vendor/autoload.php';
require 'vendor/deployer/deployer/recipe/laravel.php';

set('ssh_type', 'ext-ssh2');

$server = server('prod1')
    ->user('root')
    ->env('deploy_path', '/var/www/deploy')
    ->env('branch', 'master')
    ->stage('production');

set('repository', 'git@git.rsct.com:mani/rsct-backend.git');

Please have a look, thanks!


++FPS Limiter, fixing common complaint

Hey,
A few issues i.e. #283 were complaining about CPU utilization.
On inspection of performance, I found that this is due to requestAnimationFrame calls (approximately line 1309). Normally this is okay,  it functions well for high-performance high FPS web-applications and uses resources well i.e. FPS games could be a good use case for this. But for almost imperceptible effects, i.e. my website callumleach.com, we really don't need that kind of CPU utilization.
To resolve this issue I have added a basic FPS limiter. This is compatible with your JSON configuration as it includes default values by taking advantage of the way you have coded it. If the fps_limit is set to 0, then the framerate of redrawing the particle effects is not limited. I have made additional documentation in your documentation and your code.
To demonstrate the impact of this we can see https://vincentgarreau.com/particles.js/ clocks nearly 50% CPU utilization on my browser as an active tab regardless of particle speed or shape (unrestricted calling to requestAnimationFrame) https://imgur.com/fwiExys. However the particle effects at callumleach.com now only use 6% CPU utilization https://imgur.com/P8TEncG. Album https://imgur.com/a/XOoMZ for a side by size comparison.
Please consider merging this request then changing the comments I have left to best suit you!

I'm a little bit tied up but I can make some systematic improvements to this over the next few weeks that you can review when I get chance to explore different methodologies [expect updates over time]!
Thanks for the cool project.

Had a bit of a carry on with formatting (trying to edit on Github.com, bad idea). All sorted now.

Closing and opening a new pull request from another branch / cleaner comments.