Remove Windows specific code

#1534

@KrzysztofCwalina, if you have any concerns we can discuss, but I believe this is in line with what you were expecting.

@MisinformedDNA, @JeremyKuhne, the main objective for this component was to have zero allocations when nothing changes in the watched directories. Is this still true after the change? If yes, the change is great. Otherwise, I would like to see how much is allocated when the pooling timer runs.

I updated the code to use the new APIs. I don't see any allocations in the Diagnostics windows.
The one thing of note in this commit is that the extension comparison, is now case-sensitive (which can be wrong for Windows), but it was previously case-insensitive (which is wrong for Linux).
I will file an API Proposal, that resolves this while making it more flexible and more inline with the new .NET APIs.

Fixed the extension and var issues. Will fix the others in subsequent PR (as mentioned earlier).

@MisinformedDNA can you click on the Details link for the Pre-Merge signing tool and sign off?

can you click on the Details link for the Pre-Merge signing tool and sign off?

I don't think external contributors can do it. It is also not necessary.

I don't think external contributors can do it. It is also not necessary.

Hmm. I'm clearly misinformed about what this is. :)


Release date - UI note needs to be more descriptive

User-friendly explanation
Notification in advance to be able to update the release date
Embargo - reviewer access links

Also disable selection of past dates from Date Time Picker. #1076


Move without_versioning to model

The current implementation ofwithout_versioning is incorrectly set as an instance method when it should be part of the class which the current behaviour clearly shows. This PR fixes this and deprecates the old behavior.
The only difference with the new method is that it no longer accepts a method name, as its on the class not the instance. I didnt want to add this to the new implementation because I believe it is an unnecessary addition to the API.
This was somewhat related to Issue #916

The current implementation of without_versioning is incorrectly set as an instance method when it should be part of the class ..

I agree it's misleading. However, instead of moving it, we could just drop it and people could use PaperTrail.request(enabled_for_controller: false) do .., right?
Please rebase.

Rebased.
Your suggestion could work but enabled_for_controller seriously needs to be renamed its awful, especially for this use case. Its not even a good name for the controller method because it says enabled for controller but really its enabled for the request/action.
Why not change it to without_versioning. Ex.
PaperTrail.request(without_versioning: true) do .. end

and the controller method name
class MyController < ApplicationController

def paper_trail_request_without_versioning

end

Another note is that, there would no longer be an option to disable only 1 model as its now disabled for all models within that block. But I'm not sure that even matters because anyone should be able to easily organize the code around this.

Closing via #1069


Implement the ability to swap the caret position between beginning and end of selected region.

When selecting text, I would like to be able to move the cursor to the other end of the selected text block so that I can expand it in that direction.  E.g.  If I have the following text:
Here is some text to select.

and I start selecting from the beginning of  some to the end of some, I'd then like to be able to expand the selection in the direction of Here is, whereas atm I can only select in the direction of text to select..
Main use case is if I select a bracketed region by way of Select to bracket, I'd like to be able to expand the selection from the left bracket, whereas atm I can only expand the selection from the right bracket. There is a way to do this in Visual Studio, which was called Edit.SwapAnchor and can be seen in this SO post: Visual Studio - keyboard shortcut to move caret/cursor to start or end of selection.  Vim has a command v_o as seen by this SO post Adjust the other end of a visual selection.
I did look through the commands available by filtering them by the keyword select, anchor and swap, but didn't find anything that did the job.

An extension could do this

For example: Select By  extension can swap cursor positions around a selection.


ComponentDownload property of MSI is outdated in 4.3.2

I confirm (by marking "x" in the [ ] below: [x]):

[x] This is not a troubleshooting question. Troubleshooting questions go here: http://www.mattermost.org/troubleshoot/.
[x] This doesn't reproduce on web browsers (such as in Chrome). If it does, issue reports go to the Mattermost Server repository.
[x] I have read contributing guidelines.

Summary
ComponentDownload property in the Property table of the Mattermost Desktop 4.3.2 x64 MSI points to an old version.
https://releases.mattermost.com/desktop/4.1.2/mattermost-setup-4.1.2-win64.msi
Environment

Operating System: Windows 10 x64
Mattermost Desktop App version: 4.3.2 x64 MSI

Expected behavior
Value should be the current MSI
Observed behavior
Value is for v4.1.2

Also reported here: https://community.mattermost.com/core/pl/echd4mo6t7bipee8kj9458hf8y perhaps @amyblais can create some Jira Tickets?

Ticket here: https://mattermost.atlassian.net/browse/MM-20931.


Inactive account and display message

this line of code is never executed because the authenticate method always return None when the user is inactive https://github.com/sunscrapers/djoser/blob/master/djoser/serializers.py#L95

Hi.
What you say is true, but only in case of Django >= 1.10:

The new AllowAllUsersModelBackend and AllowAllUsersRemoteUserBackend ignore the value of User.is_active, while ModelBackend and RemoteUserBackend now reject inactive users.
https://docs.djangoproject.com/en/1.11/releases/1.10/#django-contrib-auth

We still support Django 1.8, so it is necessary to validate that user account is active.
Thank you for pointing it out, though, because it may not be obvious at first that it will need to be changed when 1.8 is dropped.

Yeah, it's true. Sure, no problem. I’m happy to help @piotr-szpetkowski 🙂

A follow-up on this: DRF has dropped support for Django 1.8 and therefore we have done the same thing for 1.0.0. I've removed the obvious pieces, however I've postponed the full-cleanup to 1.1.0.


Update driver-registrar to use CSI spec 1.0

/hold
Needs to be updated again after csi-test is cut

/hold cancel

/lgtm
/approve


fast_update dies when a field is provided multiple times in the fields parameter

Hey, was testing the package (coming from the django ticket, it was reported based on the data I gathered) and this was a thing that took me a while to figure out. In one of my company's projects I replaced all of the usages of django-bulk-update with fast_update and ran tests and some began failing and I figured out that in some cases we sent fields duplicated in the fields parameter and it failed with an ugly error in the SQL, after fixing that on our part all tests passed.
The error looked something like
E               django.db.utils.ProgrammingError: column reference "b" is ambiguous
E               LINE 1: UPDATE "A" SET "b"=CAST("d"."b"...
E

Because the query looked something
UPDATE "A"
SET "b"=CAST("d"."b" AS numeric(20, 2)),
    "c"=CAST("d"."c" AS varchar(255)),
    "b"=CAST("d"."b" AS numeric(20, 2))
FROM (VALUES (%s, %s, %s, %s)) AS "d" ("id", "b", "c", "b")
WHERE "A"."id" = "d"."id"

It would be nice to get a more explicit message for this, for example from the sanity_check function? Should be an easy check on whether the length of fields is the same as length of set of fields?

@mikicz
Thx for testing it out :+1:
Oh well I did not even think anyone would try to send duplicated fields, so this is not tested for/dealt with. Will have to check, how bulk_update deals with that, easiest is prolly to do a set reduction in sanity_check (if its compatible to bulk_update).

I'm not sure about the efficiency of how it works in bulk update, but it definitely doesn't throw an error. I am definitely going to deduplicate the fields even for bulk update though, just because it's nicer

bulk_update makes an implicit field reduction in https://github.com/django/django/blob/0b31e024873681e187b574fe1c4afe5e48aeeecf/django/db/models/query.py#L766 by possibly overwriting previously set key/value. In terms of efficiency thats somewhat wasteful, as the constructed CASE value will be the same as before (since field values cannot change in between). Imho that should be reduced prehand there as well.
Imho a simple set reduction as fields = list(set(fields)) will do the trick here, we dont even have to track initial field ordering (for the created SQL it does not matter where the non pk columns occurs). We still need a stable ordering down the road (thus the list conversion), so values dont slip into the wrong columns.


Build error on macOS: ar: Argument list too long (there is a fix, but a better one wanted)

On macOS there is an issue with length of ar arguments: I get an error ar: Argument list too long.
I made a fix, but it is quite ugly :)
I had to split the target here: https://github.com/macports/macports-ports/blob/1c8cb98aa54e71148f4a5c416a6c82adb20f5a00/math/AlphaSparse/files/0010-Makefile.tail-split-lib-target-to-fix-ar-error.patch
And also re-shuffle files from plain/kernel: https://github.com/macports/macports-ports/blob/1c8cb98aa54e71148f4a5c416a6c82adb20f5a00/math/AlphaSparse/Portfile#L42
Can it be fixed in a neater way?

Turned out that the failure occurs even on x86_64 and recent macOS like Catalina: https://build.macports.org/builders/ports-10.15_x86_64-builder/builds/130695/steps/install-port/logs/stdio

I guess the problem is that ar is being given the absolute paths of each object file, and the path to the directory that MacPorts builds happen in is rather long to begin with. Could the Makefile call ar with relative paths to the objects, perhaps even just the filenames?

@NCIC-AlphaSparse Any chance of addressing this?


@conda-forge-admin, please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/soapysdr-feedstock#4.


don't return scheduler agent if host is reconnecting or disconnected

https://github.com/rancher/rancher/issues/7729

@StrongMonkey Also test the scenario manually with real hosts

@cjellick updated.

LGTM


Remove workaround of wrapping CamelEndpointDetails class due to CAMEL-12635

see https://issues.apache.org/jira/browse/CAMEL-12635 and #30

verified with master branch


Variable scoping compatibility mode

BeanShell 3.0.0 has made a change to the rules for scoping loosely defined variables.  In BeanShell version 2 loosely defined variables were defined in the enclosing scope.  According to the BeanShell documentation:

Blocks are statements between curly braces {}. In BeanShell, as in Java, blocks define a level of scope for typed variables: typed variables declared within a block are local to the block. Other assignments within the block occur, as always, wherever the variable was defined.
Untyped variables in BeanShell, however, are not constrained by blocks. Instead they act as if they were declared at the outer (enclosing) scope's level. With this in mind, BeanShell code looks just like Java code. In BeanShell if you declare a typed variable within a block it is local to the block. But if you use an untyped variable (which looks just like an ordinary assignment in Java) it behaves as an assignment to the enclosing scope.

For example while using BeanShell 2 the following code the assertion will pass because the x variable is declared in the outer namespace.
{
  x = 5;
}
assert(x==5);

In BeanShell 3.0.0 untyped variables are always declared within the block where they are encountered, behaving more like Java.  Using the same code in BeanShell 3 the assertion will fail because the x variable has been declared within the block, and that scope has gone out of context.  In the assert statement x will be undefined.
Regardless of how you feel about the sensibility of the earlier behaviour, the reality is that there exists legacy BeanShell V2 code that relies upon the previous behaviour for this feature.  When running old V2 code using a version 3 interpreter errors will occur.  Although the best long-term fix is to edit the code to adapt to the new behaviour, some users might not have the programming capability to make these updates.  For this segment of the BeanShell user base a compatibility mode would help with the transition.
A Bsh2 variable scoping compatibility mode could be used restore the previous behaviour and allow old scripts to run unchanged.  The compatibility mode could be activated by calling a method on the interpreter (such as interpreter.setBsh2ScopingCompatibility(true);), or by setting a command line flag (such as -Dbsh.Bsh2ScopingCompatibility=true),

We have had this discussion already: https://github.com/beanshell/beanshell/issues/555#issuecomment-559629112
And the change will be documented as per #555
Also there is a simple work around:
{
  super.x = 5;
}
assert(x==5);

Closed: Won't break again it is fixed

From #720

The point is that there is a large code base that I can not access to make changes.

If you can't change the code, why change the interpreter? You want to use BeanShell 3.0 because you want to use the new features, right?
If you can change the interpreter, you should be able to change how the interpreter receives the code. Which is only one step away from changing the code, before the interpreter sees it. I'm thinking regex...and you don't have to make changes to the code base.

There is also the option of writing a code migration tool, which would be able to identify and correct these upgrade fixes.
It should equally be able to transform inline, for a read only code base, as well as persist a script upgrade, I don't see why not.
Since it only applies to the script loading pipeline, running performance will remain unimpeded.

The problem is that scripts can be loaded by the source() or sourceRelative() commands, and the values for these cannot be statically determined in advance.  So the 'transform before load' doesn't work easily in all cases.
If you are dead set against this then close this issue, I have the fix for this in my tree anyway.


Maintenance: manually bump @aws-cdk/cli-lib-alpha

Summary
While we use Dependabot for automatically updating our dependencies, the @aws-cdk/cli-lib-alpha is being excluded by the updates (example) despite being included in the config.
We should update the dependency manually until we find a solution.
Why is this needed?
With the other AWS CDK related dependencies moving forward with versions and this one being left behind, the integration tests fail.
We need to manually update so that we can continue running the tests.
Which area does this relate to?
Other
Solution
No response
Acknowledgment

[X] This request meets Powertools for AWS Lambda (TypeScript) Tenets
[ ] Should this be considered in other Powertools for AWS Lambda languages? i.e. Python, Java, and .NET

Future readers
Please react with 👍 and your use case to help us understand customer demand.

Reopening the issue to track remaining tasks on this area.
It's still unclear why exactly Dependabot is not seeing the version, but @sthulb who has investigated the issue suggests it might be related to it being a pre-release.
Dependabot seems to ignore the latest release when checking for updates as evidenced by the logs here:

Looking at the Dependabot repo, there seem to be at least two related issues, one of which is directly related to our case as it involves an AWS CDK package:

https://github.com/dependabot/dependabot-core/issues/10458
https://github.com/dependabot/dependabot-core/issues/6741

I have left a comment under both, hoping they would get some traction given that a high level exploration of the Dependabot codebase seems to imply this type of update should work.
Depending on whether this is a bug on Dependabot side, the root cause of the issue could be that the package is published using a pre-release suffix while being tagged as latest which might confuse the bot. We could explore the option of asking CDK to publish pre-releases with the correct tag (i.e. alpha) but before doing this we should try reproducing the issue with a dummy package and see if having a different tag with the same version pattern would fix the issue.
We have also left a comment under the RFC for the package on CDK side to see what's the progress on the package becoming stable, which might probably bypass the issue entirely.


feat(linter): add fixer for no-empty

adds a suggestion for no-empty eslint lint rule

#5276  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @camc314 and the rest of your teammates on  Graphite


fix(codegen): print if else without block wither proper indentation

#8135  👈 (View in Graphite)
main

How to use the Graphite Merge Queue
Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.


Android: Add Req Please move the download location so that it is in the Download folder, not in the android/data folder

Please move the download location from android/data to internal/Download
Thank You

+1


[DOC] Move Reporting to high-level section in nav menu

Description
Reporting is used in Dashboards and the Reporting CLI (non-Dashboards). Documentation about both options need to be in a main section in the nav menu. Moved Reporting content from OpenSearch Dashboards to Reporting to make the content more user-friendly and easier to find.

Issues Resolved
Checklist

[X] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.


Markdown for nodes' text

Is your feature request related to a problem? Please describe.
Particularly for source nodes, it'd be nice to add links to the text
Describe the solution you'd like

paste link on text to create linked text
node doesn't have any rich text toolbar, so doesn't take extra space up
details pane does have rich text toolbar
can rich text support hover-for-clarification-text?

maybe hypothes.is can be added as a plugin or something?

Describe alternatives you've considered
Additional context
Technical ideas
There are a bunch of rich text editors out there, but Facebook's currently-experimental rich text editor seems really good! https://github.com/facebook/lexical.

Issues run into:

lexical generally has very poor documentation and seems not ready for usage without going through library code and asking questions
tiptap seems further along and maybe preferable, better docs, though lexical seems like it'd be better if it were further along
putting the rich text editor into the small node size will likely be problematic for floating text e.g.:

but using a rich text editor with only shortcuts seems fine for short-term, as advanced users would still be able to present optimally-formatted text to others


Fixed graph schema drop and init error when edge_kinds's src or dst gone

What do these changes do?
Fixed graph schema drop, origin labels return string but expect get object
Fixed init error when edge_kinds's src or dst gone, because can't get label from id_to_label by id

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #1922 (2adae13) into main (7009cca) will decrease coverage by 4.76%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1922      +/-   ##
==========================================
- Coverage   76.15%   71.38%   -4.77%
==========================================
  Files          89       89
  Lines        9816     9816
==========================================
- Hits         7475     7007     -468
- Misses       2341     2809     +468

Impacted Files
Coverage Δ

python/graphscope/framework/graph_schema.py
65.19% <0.00%> (-0.25%)
:arrow_down:

python/graphscope/tests/unittest/test_download.py
20.00% <0.00%> (-80.00%)
:arrow_down:

python/graphscope/dataset/ppi.py
31.25% <0.00%> (-56.25%)
:arrow_down:

python/graphscope/dataset/cora.py
31.25% <0.00%> (-56.25%)
:arrow_down:

python/graphscope/dataset/ogbl_ddi.py
31.25% <0.00%> (-56.25%)
:arrow_down:

python/graphscope/dataset/ogbn_mag.py
31.25% <0.00%> (-56.25%)
:arrow_down:

python/graphscope/dataset/ogbn_arxiv.py
31.25% <0.00%> (-56.25%)
:arrow_down:

python/graphscope/dataset/ogbl_collab.py
31.25% <0.00%> (-56.25%)
:arrow_down:

python/graphscope/dataset/u2i.py
35.29% <0.00%> (-52.95%)
:arrow_down:

python/graphscope/tests/unittest/test_java_app.py
49.33% <0.00%> (-50.67%)
:arrow_down:

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7009cca...2adae13. Read the comment docs.

@iamdrq  Merged, Thanks!


git-subcopy: init at 0.1.0

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
x ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Not sure, but I feel like a bump is in order?

Not sure, but I feel like a bump is in order?

That doesn't help as no one is "watching" this repo because of the enormous amount of PRs.

Also, you should use "init at" and not "new at" in your PR title, as explained in CONTRIBUTING.md.

I no longer care about this project, let's not put it in nixpkgs :)


[core]CI execution optimization

Purpose
-T 1C to speed up build efficiency
Tests

API and Format

Documentation

Let's see if optimization is effective.

No need to use mvnw.
the related pr: #1178

No need to use mvnw.
the related pr: #1178

Thanks for the reminder, I have removed mvnw

@JingsongLi PTAL

Let's see if optimization is effective.

@JingsongLi PTAL,thanks.
A few minutes of optimization.Is this PR still worth merging?

after change：


Add infos about Wowza streaming configuration changes to upgrade guide

I just performed an update and I wish I knew that before. Maybe this can help others.
CC @lkiesow @KatrinIhler #1179
Your pull request should…

[ ] have a concise title
[ ] close an accompanying issue if one exists
[ ] be against the correct branch (features can only go into develop)
[ ] include migration scripts and documentation, if appropriate
[ ] pass automated tests
[ ] have a clean commit history
[ ] have proper commit messages (title and body) for all commits

Ups, this completely slipped my mind. Sorry. Merging…


Don't assume server is mounted at /graphql

The GraphQL server happens to be mounted at graphql in this case (https://github.com/graphql/graphiql/blob/master/example/server.js#L28), but we shouldn't assume that.
This fix should allow the GraphQL server to be mounted anywhere.
The reason this is important is that we use this template in GraphQL Elixir (other implementations would likely do something similar). Our template can be found here https://github.com/graphql-elixir/plug_graphql/blob/master/templates/graphiql.eex
We found some issues when we took this template verbatim before line 111.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

CLA is signed, also I have investigated those test failures and could not figure out why the linter is broken. This is also happening on master locally for me so suspect this might be a dependency change causing this.

@joshprice - Sorry for keeping you hanging! I'm taking a look at the linter issue, and although I have no idea why this is happening yet, I'll see if I can unblock you from this as soon as possible.

Rebased and pushed to retrigger the build, looks like it was transient. I did see an explanation somewhere but can't seem to track it down right now.

Me neither, but props for solving the issue! Thanks for the contributions :D
I was caught up solving this linter issue, but what do you think about optionally parameterizing the custom endpoint pathname? Something like:
function graphQLFetcher(graphQLParams, endpointURL = '/graphql') {
  return fetch(window.location.origin + endpointURL, {});
}

This way we can customize the URL as we want, but it'll default to /graphql when not supplied. Aside form the customization, I was also thinking this change may break other applications if it relies on /graphql URL to use fetcher somehow.

As mentioned in the issue description we have the situation where we have many GraphQL endpoints mounted at various locations and your code would involve us configuring GraphiQL differently for each endpoint whereas using the current path makes it work transparently.

Sure - again, thanks for the contribution!


[cloud_firestore] build failed on ios after upgrading to Flutter 1.12.13

After upgrading flutter stable to 1.12,  cloud_firestore 0.13.0+1  failed to build on ios (it still work on Android).
To reproduce the bug, on a new flutter project, just add the dependencies to pubspec.yaml:
dependencies:
  flutter:
    sdk: flutter
  firebase_core: ^0.4.3+1
  cloud_firestore: ^0.13.0+1

(and GoogleService-Info.plist in ios/Runner).
Then the build fails for ios (and works for android).
I flush .pub-cache to no avail.
32m@dev Test % flutter doctor -v
[✓] Flutter (Channel stable, v1.12.13+hotfix.5, on Mac OS X 10.15.2 19C57, locale fr-FR)
    • Flutter version 1.12.13+hotfix.5 at /Users/em/Dev/Softs/flutter
    • Framework revision 27321ebbad (2 days ago), 2019-12-10 18:15:01 -0800
    • Engine revision 2994f7e1e6
    • Dart version 2.7.0

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/em/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.3, Build version 11C29
    • CocoaPods version 1.8.3

[✓] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 42.1.1
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] VS Code (version 1.40.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.6.0

[✓] Connected device (2 available)
    • AOSP on IA Emulator • emulator-5554                        • android-x86 • Android 9 (API 28) (emulator)
    • iPhone 8            • 3998CCF4-0C57-4E0D-A6A7-196B5445E265 • ios         • com.apple.CoreSimulator.SimRuntime.iOS-13-3 (simulator)

• No issues found!

Here's the message when I try to build:
Launching lib/main.dart on iPhone 8 in debug mode...
Running pod install...
Running Xcode build...
Xcode build done.                                           99,5s
Failed to build iOS app
Error output from Xcode build:
↳
    ** BUILD FAILED **

Xcode's output:
↳
    /Users/32m/AndroidStudioProjects/Test/ios/Pods/FirebaseFirestore/Firestore/Protos/objc/google/firestore/v1/Write.pbobjc.m:33:10: warning: non-portable path to file '<protobuf/Timestamp.pbobjc.h>'; specified path differs in case from file name on disk [-Wnonportable-include-path]
     #import <Protobuf/Timestamp.pbobjc.h>
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             <protobuf/Timestamp.pbobjc.h>
    1 warning generated.
    /Users/32m/AndroidStudioProjects/Test/ios/Pods/FirebaseFirestore/Firestore/Protos/objc/firestore/local/Target.pbobjc.m:33:10: warning: non-portable path to file '<protobuf/Timestamp.pbobjc.h>'; specified path differs in case from file name on disk [-Wnonportable-include-path]
     #import <Protobuf/Timestamp.pbobjc.h>
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             <protobuf/Timestamp.pbobjc.h>
    1 warning generated.
    /Users/32m/AndroidStudioProjects/Test/ios/Pods/FirebaseFirestore/Firestore/Protos/objc/google/rpc/Status.pbobjc.m:33:10: warning: non-portable path to file '<protobuf/Any.pbobjc.h>'; specified path differs in case from file name on disk [-Wnonportable-include-path]
     #import <Protobuf/Any.pbobjc.h>
             ^~~~~~~~~~~~~~~~~~~~~~~
             <protobuf/Any.pbobjc.h>
    1 warning generated.
    /Users/32m/AndroidStudioProjects/Test/ios/Pods/FirebaseFirestore/Firestore/Protos/objc/google/firestore/v1/Query.pbobjc.m:33:10: warning: non-portable path to file '<protobuf/Wrappers.pbobjc.h>'; specified path differs in case from file name on disk [-Wnonportable-include-path]
     #import <Protobuf/Wrappers.pbobjc.h>
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
             <protobuf/Wrappers.pbobjc.h>
    1 warning generated.
    /Users/32m/AndroidStudioProjects/Test/ios/Pods/FirebaseFirestore/Firestore/Protos/objc/firestore/local/Mutation.pbobjc.m:33:10: warning: non-portable path to file '<protobuf/Timestamp.pbobjc.h>'; specified path differs in case from file name on disk [-Wnonportable-include-path]
     #import <Protobuf/Timestamp.pbobjc.h>
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             <protobuf/Timestamp.pbobjc.h>
    1 warning generated.
    /Users/32m/AndroidStudioProjects/Test/ios/Pods/FirebaseFirestore/Firestore/Protos/objc/firestore/local/MaybeDocument.pbobjc.m:33:10: warning: non-portable path to file '<protobuf/Timestamp.pbobjc.h>'; specified path differs in case from file name on disk [-Wnonportable-include-path]
     #import <Protobuf/Timestamp.pbobjc.h>
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             <protobuf/Timestamp.pbobjc.h>
    1 warning generated.
    /Users/32m/AndroidStudioProjects/Test/ios/Pods/FirebaseFirestore/Firestore/Protos/objc/google/firestore/v1/Firestore.pbobjc.m:33:10: warning: non-portable path to file '<protobuf/Empty.pbobjc.h>'; specified path differs in case from file name on disk [-Wnonportable-include-path]
     #import <Protobuf/Empty.pbobjc.h>
             ^~~~~~~~~~~~~~~~~~~~~~~~~
             <protobuf/Empty.pbobjc.h>
    /Users/32m/AndroidStudioProjects/Test/ios/Pods/FirebaseFirestore/Firestore/Protos/objc/google/firestore/v1/Firestore.pbobjc.m:34:10: warning: non-portable path to file '<protobuf/Timestamp.pbobjc.h>'; specified path differs in case from file name on disk [-Wnonportable-include-path]
     #import <Protobuf/Timestamp.pbobjc.h>
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             <protobuf/Timestamp.pbobjc.h>
    2 warnings generated.
    /Users/32m/AndroidStudioProjects/Test/ios/Pods/FirebaseFirestore/Firestore/Protos/objc/google/firestore/v1/Document.pbobjc.m:33:10: warning: non-portable path to file '<protobuf/Struct.pbobjc.h>'; specified path differs in case from file name on disk [-Wnonportable-include-path]
     #import <Protobuf/Struct.pbobjc.h>
             ^~~~~~~~~~~~~~~~~~~~~~~~~~
             <protobuf/Struct.pbobjc.h>
    /Users/32m/AndroidStudioProjects/Test/ios/Pods/FirebaseFirestore/Firestore/Protos/objc/google/firestore/v1/Document.pbobjc.m:34:10: warning: non-portable path to file '<protobuf/Timestamp.pbobjc.h>'; specified path differs in case from file name on disk [-Wnonportable-include-path]
     #import <Protobuf/Timestamp.pbobjc.h>
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             <protobuf/Timestamp.pbobjc.h>
    2 warnings generated.
    /Users/32m/AndroidStudioProjects/Test/ios/Pods/FirebaseFirestore/Firestore/Protos/objc/google/firestore/v1/Common.pbobjc.m:33:10: warning: non-portable path to file '<protobuf/Timestamp.pbobjc.h>'; specified path differs in case from file name on disk [-Wnonportable-include-path]
     #import <Protobuf/Timestamp.pbobjc.h>
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             <protobuf/Timestamp.pbobjc.h>
    1 warning generated.
    /Users/32m/.pub-cache/hosted/pub.dartlang.org/cloud_firestore-0.13.0+1/ios/Classes/FLTCloudFirestorePlugin.m:155:24: error: no visible @interface for 'FIRQuery' declares the selector 'queryWhereField:arrayContainsAny:'
            query = [query queryWhereField:fieldName arrayContainsAny:value];
                     ~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    /Users/32m/.pub-cache/hosted/pub.dartlang.org/cloud_firestore-0.13.0+1/ios/Classes/FLTCloudFirestorePlugin.m:157:24: error: no visible @interface for 'FIRQuery' declares the selector 'queryWhereFieldPath:arrayContainsAny:'
            query = [query queryWhereFieldPath:fieldPath arrayContainsAny:value];
                     ~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    /Users/32m/.pub-cache/hosted/pub.dartlang.org/cloud_firestore-0.13.0+1/ios/Classes/FLTCloudFirestorePlugin.m:163:24: error: no visible @interface for 'FIRQuery' declares the selector 'queryWhereField:in:'
            query = [query queryWhereField:fieldName in:value];
                     ~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
    /Users/32m/.pub-cache/hosted/pub.dartlang.org/cloud_firestore-0.13.0+1/ios/Classes/FLTCloudFirestorePlugin.m:165:24: error: no visible @interface for 'FIRQuery' declares the selector 'queryWhereFieldPath:in:'
            query = [query queryWhereFieldPath:fieldPath in:value];
                     ~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    4 errors generated.
    note: Using new build system
    note: Planning build
    note: Constructing build description
    warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 5.0, but the range of supported deployment target versions is 8.0 to 13.2.99. (in target 'leveldb-library' from project 'Pods')
    warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 7.0, but the range of supported deployment target versions is 8.0 to 13.2.99. (in target 'Protobuf' from project 'Pods')
    warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 4.3, but the range of supported deployment target versions is 8.0 to 13.2.99. (in target 'nanopb' from project 'Pods')
    warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 7.0, but the range of supported deployment target versions is 8.0 to 13.2.99. (in target 'BoringSSL-GRPC' from project 'Pods')
    warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 7.0, but the range of supported deployment target versions is 8.0 to 13.2.99. (in target 'gRPC-Core' from project 'Pods')
    warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 7.0, but the range of supported deployment target versions is 8.0 to 13.2.99. (in target 'gRPC-C++' from project 'Pods')
    warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 7.0, but the range of supported deployment target versions is 8.0 to 13.2.99. (in target 'gRPC-C++-gRPCCertificates-Cpp' from project 'Pods')

Could not build the application for the simulator.
Error launching application on iPhone 8.

Hi @32mandev
does this solution solve the issue?
thank you

Hi,
unfortunately  flutter clean; flutter pub cache repair doesn't solve the issue.

cd ios pod update Firebase/Firestore
try this it fixed a similar issue for me in the past.  If that doesn't work the more drastic measure is to delete the "Pods" folder and "Podfile.lock".

cd ios
pod update Firebase/Firestore

It worked! Thank you very much.


Feat/pro 4252/rocko

I'll create a PR to updater-repo in order to test rocko/master branches.

I'm stuck on bitbake errors like the following:
ERROR: gettext-minimal-native-<IP_ADDRESS>-r0 do_patch: Command Error: 'quilt --quiltrc /home/patrick/Code/qemu_rocko/build/tmp/work/x86_64-linux/gettext-minimal-native/<IP_ADDRESS>-r0/recipe-sysroot-native/etc/quiltrc push' exited with 0  Output:
/bin/sh: 1: quilt: not found

I cannot figure out why it can't find quilt. That's pretty basic.

Never seen that, looks like the environment is fundamentally broken. I think quilt should be pulled by some bbclasses belonging to oe-core on early stages. Do you use updater-repo to pull everything together?

Yeah, I'm pretty confused. This was a new build directory, and yes, I'm using updater-repo.


Allow struct/struct[] as an action/function parameter

This is supported in the latest release (v0.8.2)


Need a hyperlink for more details of "Hot Exit"

In Settings section of Vscode, there is a configuration called Hot Exit. The one-liner description of Hot Exit can be made more detailed by adding a hyper link to https://code.visualstudio.com/docs/editor/codebasics#_hot-exit. This pattern is followed in some other setting configurations of Vscode i.e. adding hyperlinks for more details of a topic.

Can I work on this issue?

Yes, feel free to do a PR with what you think makes this easier to understand.

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

So, I can't work on it? I have figured out the way how to resolve it.

Anyone can work on this. Go ahead.

Thank you. I opened the Pull Request on #193354.


Untar into the right dir when verifying

We'd previously dump it in the package's directory which is wrong when
working in a workspace.
Closes #4304
r? @alexcrichton

@bors: r+

:pushpin: Commit c4565a6 has been approved by alexcrichton

:hourglass: Testing commit c4565a63114f43e4f64ab15ae2b566e11f0b52db with merge 848eb156ef088bbfb60225e0d608a96471f29aef...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 848eb156ef088bbfb60225e0d608a96471f29aef to master...


add unit tests coverage reports

Hi @jhadvig added a new coverage script which can be used to run unit test and generate coverage report, I'm not sure if I should update existing test script or a new one. Could you help review?

/assign @jhadvig

From the description

...I'm not sure if I should update existing test script or a new one...

@yapei The test.sh in the root is what the CI bot triggers off of when a PR is created/updated. It's the ci/prow/test script after the various containers are created and setup stuff is done. If you would like the coverage to be part of work the developers do to the repo/PRs, we'll need it in that script.
I believe the files it generates are .gitignore'd though so they won't be committed. Hopefully whatever you're looking to do with them is at time of generation here in the hosted container we build/test in and nothing you need to be stored in git.
I'm not quite sure what you're after, but I'd be happy to help if you can let me know what the process you're trying to apply is.

Per discussion with @yapei we should also incorporate the the coverage report upload. that would need to be part of the test.sh. Also linking the release PR thats updating ci-operator config for hac-infra.
https://github.com/openshift/release/pull/26709

1. with the change of collectCoverageFrom now we have correct coverage report credit to @andrewballantyne
[fedora@preserved-ui-fedora35 hac-infra]$ yarn coverage
yarn run v1.22.17
$ jest --coverage --runInBand --detectOpenHandles --forceExit
 PASS  src/PluginEntry/PluginEntry.test.tsx (6.619 s)
  ✓ that the header presents the welcome message (57 ms)

------------------|---------|----------|---------|---------|-------------------
File              | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
------------------|---------|----------|---------|---------|-------------------
All files         |     100 |      100 |     100 |     100 |
 NotFound         |     100 |      100 |     100 |     100 |
  NotFound.tsx    |     100 |      100 |     100 |     100 |
  index.ts        |     100 |      100 |     100 |     100 |
 PluginEntry      |     100 |      100 |     100 |     100 |
  PluginEntry.tsx |     100 |      100 |     100 |     100 |
  index.ts        |     100 |      100 |     100 |     100 |
------------------|---------|----------|---------|---------|-------------------
Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        7.492 s
Ran all test suites.
Done in 8.67s.

2. yarn test in test.sh is updated to yarn coverage
it looks like we need have openshift/release#26709 to be merged first otherwise our test will fail with error
 ./test.sh: line 11: CODECOV_TOKEN: unbound variable

This looks good to me. Minor nit that could be completed or not. Just thinking forward to the next diff 🙂
/lgtm


confix reload lock

confix reload should have an option to make it explode if there are any changes to the confix files. This option is useful to validate all necessary files have been checked in and are up-to-date in the ci pipeline

it should work similar to npm ci
https://docs.npmjs.com/cli/v9/commands/npm-ci

this no longer needed https://github.com/SwissLife-OSS/Confix/pull/82


Does tfidf support localization?

unfortunately right now the tokenizer is hard-coded (see https://github.com/NaturalNode/natural/blob/master/lib/natural/tfidf/tfidf.js#L24-L25) shouldn't be too hard to refactor though.
we spoke awhile ago (cant seem to find the issue where this happened) about refactoring things so that one could set a global language and all the tools could automatically infer which algorithms to use. i dont think we ever really made any progress in that direction though


UnixPB: Arm specific adoptopenjdk_install task

fixes: #697
The issues listed on the #697  are no longer relevant to the current playbooks as the adoptopenjdk9 role no longer exists, and we're not able to add the openjdk-7-jdk package as the openjdk-r repository doesn't have it available for arm, however we can build jdk8 with jdk8 so this isn't an issue.
However, whilst running through the playbook to ensure it worked, the adoptopenjdk_install role doesn't work as the ansible_architecture variable is set as armv7l, not arm as APIv3 requires, so I've made an ARM specific role for it.

Could we set a api_architecture variable and use that instead to avoid duplication. Set it to ansible_architecture by default, and override if on arm32?

Changes put in - this does still have duplication of tasks, but I agree that it's probably the better way to do it.

Testing at https://ci.adoptopenjdk.net/view/work in progress/job/VagrantPlaybookCheck/385/


[WIP] HWKAGENT-156 - Support for EAP7.1

Adds support for restarting hawkular-agent when modifying a property with the flag RESTART_RESOURCE_SERVICE.

Still need to:

[x] Check support for EAP6
[x] Workaround an exception (see MonitorService.java)

Question: suppose someone changes N attributes (for example, suppose I want to change the collection interval for 5 metric sets defined in the subsystem) - is this going to restart the agent repeatedly for N times? Or does the system somehow avoid this?

If executed all of them in a single compose operation, it will restart once.
If executed each one, it will restart once for every attribute with Flag.RESTART_RESOURCE_SERVICE.

An alternative for this behavior would be to define our own operation to reload the service and mark a reload required on the subsystem.
I'm not aware of any way to actually mark a service a service for reload.
As far i could tell, on EAP7, these properties acted like RESTART_ALL_SERVICES. See AbstractWriteAttributeHandler [1] and ReloadRequiredWriteAttributeHandler [2] for more info.
[1] https://github.com/wildfly/wildfly-core/blob/8814b2af45a23af556a58a685bc0f0a02a71dca4/controller/src/main/java/org/jboss/as/controller/AbstractWriteAttributeHandler.java#L104-L106
[2] https://github.com/wildfly/wildfly-core/blob/73cc07034d5ca660a6bab890e2e951b80c6f34d9/controller/src/main/java/org/jboss/as/controller/ReloadRequiredWriteAttributeHandler.java#L54-L55

I think we need to fix OperationStart. All that does is start or restart MonitorService but it doesn't get that service to reload the new configuration. If you changed some agent config via CLI, just merely starting/stopping the agent via startMonitorService is not enough because it would still have the old configuration still.
We need to somehow get OperationStart to invoke SubsystemRemove (to stop) and SubsystemAdd (to start). But Wildfly has to trigger those calls because Wildfly needs to pass in the proper context and config to those methods. But we don't want to remote the entire agent subsystem's config - we just want to force WildFly to restart our services.
What we have to end up doing is creating a new MonitorService object, passing in the new config to the constructor and then having the start() called. this is what SubsystemAdd does.

Ignore my last comment. The fix would be to change the new method: org.hawkular.agent.monitor.extension.MonitorServiceRestartParentAttributeHandler.recreateParentService()
I'm experimenting with this as the new implementation of that method:
    @Override
    protected void recreateParentService(OperationContext context, PathAddress parentAddress, ModelNode parentModel)
            throws OperationFailedException {
        SubsystemAdd.INSTANCE.performRuntime(context, null, parentModel);
        try {
            ServiceName name = SubsystemExtension.SERVICE_NAME;
            ServiceRegistry serviceRegistry = context.getServiceRegistry(true);
            MonitorService service = (MonitorService) serviceRegistry.getRequiredService(name).getValue();
            service.startMonitorService();
        } catch (Exception e) {
            throw new OperationFailedException("Failed to recreate Hawkular WildFly Agent service", e);
        }
    }

Merged josejulio/hawkular-agent#1 and rebased.

The travis failure happens to me locally as well. Investigating...

OK, the itest error is definitely showing a bug in the new PR code. I do not think the implementation of MonitorServiceRestartParentAttributeHandler.recreateParentService() is correct.
Here's the stack trace of importance:
07:28:17,235 ERROR [org.jboss.as.controller.management-operation] (management-handler-thread - 1) WFLYCTL0013: Operation ("write-attribute") failed - address: ([
    ("subsystem" => "hawkular-wildfly-agent"),
    ("managed-servers" => "default"),
    ("remote-jmx" => "Remote JMX")
]): java.lang.IllegalArgumentException: Missing storage adapter configuration: {"enabled" : false, "url" : "http://localhost:8080/jolokia-war", "username" : null, "password" : null, "security-realm" : null, "set-avail-on-shutdown" : null, "resource-type-sets" : "MainJMX,MemoryPoolJMX", "tenant-id" : null, "metric-id-template" : null, "metric-tags" : "feed=%FeedId,Label Remote=Value Remote"}
	at org.hawkular.agent.monitor.extension.MonitorServiceConfigurationBuilder.determineStorageAdapterConfig(MonitorServiceConfigurationBuilder.java:857)
	at org.hawkular.agent.monitor.extension.MonitorServiceConfigurationBuilder.<init>(MonitorServiceConfigurationBuilder.java:94)
	at org.hawkular.agent.monitor.extension.SubsystemAdd.performRuntime(SubsystemAdd.java:46)
	at org.hawkular.agent.monitor.extension.MonitorServiceRestartParentAttributeHandler.recreateParentService(MonitorServiceRestartParentAttributeHandler.java:66)
	at org.jboss.as.controller.RestartParentWriteAttributeHandler.applyUpdateToRuntime(RestartParentWriteAttributeHandler.java:72)
	at org.jboss.as.controller.AbstractWriteAttributeHandler$1.execute(AbstractWriteAttributeHandler.java:104)
	at org.jboss.as.controller.AbstractOperationContext.executeStep(AbstractOperationContext.java:890)
	at org.jboss.as.controller.AbstractOperationContext.processStages(AbstractOperationContext.java:659)
	at org.jboss.as.controller.AbstractOperationContext.executeOperation(AbstractOperationContext.java:370)
	at org.jboss.as.controller.OperationContextImpl.executeOperation(OperationContextImpl.java:1344)
	at org.jboss.as.controller.ModelControllerImpl.internalExecute(ModelControllerImpl.java:392)
	at org.jboss.as.controller.ModelControllerImpl.execute(ModelControllerImpl.java:217)

So we are writing an attribute metric-tags to the remote JMX managed server element (remote-jmx) so the MonitorServiceRestartParentAttributeHandler.recreateParentService is getting the ModelNode of that resource, but it is expecting the FULL agent configuration model node starting at the top level subsystem.
The itest is writing an attribute when it gets this error message - here's the test error message:
FAILED: testDmrResources
org.hawkular.dmrclient.FailureException: Cannot set metric tags on remote JMX managed server: {
    "outcome" => "failed",
    "failure-description" => "WFLYCTL0158: Operation handler failed: java.lang.IllegalArgumentException: Missing storage adapter configuration: {\"enabled\" : false, \"url\" : \"http://localhost:8080/jolokia-war\", \"username\" : null, \"password\" : null, \"security-realm\" : null, \"set-avail-on-shutdown\" : null, \"resource-type-sets\" : \"MainJMX,MemoryPoolJMX\", \"tenant-id\" : null, \"metric-id-template\" : null, \"metric-tags\" : \"feed=%FeedId,Label Remote=Value Remote\"}",
    "rolled-back" => true
}
	at org.hawkular.agent.jmx.test.LocalAndRemoteJmxITest.setMetricTagsOnJmxManagedServers(LocalAndRemoteJmxITest.java:228)
	at org.hawkular.agent.jmx.test.LocalAndRemoteJmxITest.testDmrResources(LocalAndRemoteJmxITest.java:51)

The test code that is writing the new metric-tags attribute is here:
https://github.com/hawkular/hawkular-agent/blob/master/hawkular-wildfly-agent-itest-parent/hawkular-wildfly-agent-all-itests/hawkular-wildfly-agent-jmx-itest/src/test/java/org/hawkular/agent/jmx/test/LocalAndRemoteJmxITest.java#L212-L236
So this needs to be fixed before we can merge this.

OK, the easier way to replicate this problem (rather than running that long itest) is to simply run the agent and via the JBoss CLI execute this command:
jboss-cli.sh --connect '--commands=/subsystem=hawkular-wildfly-agent/managed-servers=default/local-dmr=Local/:write-attribute(name=metric-tags,value="a=b")'

You will get this error which is essentially what the itest failure is:
{     "outcome" => "failed",     "failure-description" => "WFLYCTL0158: Operation handler failed: java.lang.IllegalArgumentException: Missing storage adapter configuration: {\"enabled\" : true, \"set-avail-on-shutdown\" : null, \"resource-type-sets\" : \"Standalone Environment,Deployment,Web Component,EJB,Datasource,XA Datasource,JDBC Driver,Transaction Manager,Messaging,Socket Binding Group,Clustering,Hawkular\", \"tenant-id\" : null, \"metric-id-template\" : null, \"metric-tags\" : \"a=b\"}",     "rolled-back" => true }

I think we have a major problem. itests show failure trying to start up in domain mode. i have a feeling the stuff we added to plug into the servers lifecycle doesn't work in domain mode. Still investigating.

This is definitely a problem. Install the agent now in a host controller, and try to start it via domain.sh and it immediately aborts startup.
Install:
java -jar target/hawkular-wildfly-agent-installer-full-*.jar --target-location=$HOME/bin/eap/jboss-eap-7.0 --username=jdoe --password=password --server-url=http://localhost:8080 --module-dist=classpath: --target-config=$HOME/bin/eap/jboss-eap-7.0/domain/configuration/host.xml

Run $HOME/bin/eap/jboss-eap-7.0/bin/domain.sh
See error:
05:50:30,799 INFO  [org.jboss.modules] (main) JBoss Modules version 1.5.1.Final-redhat-1
05:50:30,983 INFO  [org.jboss.as.process.Host Controller.status] (main) WFLYPC0018: Starting process 'Host Controller'
[Host Controller] 05:50:31,617 INFO  [org.jboss.modules] (main) JBoss Modules version 1.5.1.Final-redhat-1
[Host Controller] 05:50:31,864 INFO  [org.jboss.msc] (main) JBoss MSC version 1.2.6.Final-redhat-1
[Host Controller] 05:50:31,930 INFO  [org.jboss.as] (MSC service thread 1-7) WFLYSRV0049: JBoss EAP 7.0.0.GA (WildFly Core 2.1.2.Final-redhat-1) starting
[Host Controller] 05:50:33,390 INFO  [org.jboss.as.host.controller] (Controller Boot Thread) WFLYHC0003: Creating http management service using network interface (management) port (9990) securePort (-1)
[Host Controller] 05:50:33,395 INFO  [org.xnio] (MSC service thread 1-4) XNIO version 3.3.6.Final-redhat-1
[Host Controller] 05:50:33,408 INFO  [org.xnio.nio] (MSC service thread 1-4) XNIO NIO Implementation Version 3.3.6.Final-redhat-1
[Host Controller] 05:50:33,418 ERROR [org.jboss.as.controller.management-operation] (Controller Boot Thread) WFLYCTL0013: Operation ("add") failed - address: ([
[Host Controller]     ("host" => "master"),
[Host Controller]     ("subsystem" => "hawkular-wildfly-agent")
[Host Controller] ]) - failure description: "WFLYCTL0216: Management resource '[(\"subsystem\" => \"hawkular-wildfly-agent\")]' not found"
[Host Controller] 05:50:33,456 FATAL [org.jboss.as.host.controller] (Controller Boot Thread) WFLYHC0034: Host Controller boot has failed in an unrecoverable manner; exiting. See previous messages for details.
[Host Controller] 05:50:33,473 INFO  [org.jboss.as] (MSC service thread 1-7) WFLYSRV0050: JBoss EAP 7.0.0.GA (WildFly Core 2.1.2.Final-redhat-1) stopped in 7ms
[Host Controller]

found the problem - in SubsystemAdd this subsystem address must be incorrect when running in domain mode and thus this throws an exception and halts the boot up:
        ModelNode subsystemConfig = Resource.Tools.readModel(context.readResourceFromRoot(
                WildflyCompatibilityUtils.parseCLIStyleAddress("/subsystem=" + SubsystemExtension.SUBSYSTEM_NAME)
        ));

Finally got travis to go green. All other testing looks good. This is ready to be merged.


Fix test for desktopWallpaper

This fixes the test for when we switched "DesktopWallpaper" to "desktopWallpaper"

@msftbot merge this in 5 minutes


Create StatusLED

Create status led that can display more complex sequences.

Also add abiltity to set it to single shot or periodic or maybe even a burst


Setting car charging max current

Is your feature request related to a problem? Please describe.
I would like to ask for a feature to set the charging max current through HA
Describe the solution you'd like
Instead of read-only sensor there could be an entity, through which current could be set (in my case (Skoda iV Superb) Maximum/Reduced is enough, but probably some other cars need also numeric values).
Additional context
The charger that comes with my Skoda iV Superb does not handle "Maximum" setting and I always need to switch to "Reduced" through dashboard or app. I'd like to build the automation which can automatically set the max charging current based on the car location (since I know that if I charge in certain location, I'll use car charger, not any other charge station).
I tried to use set_charger_current() from the scodaconnect library and it works nicely so backend functionality exists.
Thank you.

This feature is already available through a service call:

A switch has been requested enough times now though so I will implement it.

Since you have a Superb iV you can set charging current to any value from 1-16 that you'd like through the service call. A switch will be maximum/reduced only (16/6)

Great! Thanks a lot for the hint!


Confused about the pylinting

Hi @poojashresthacode @WildJimmy,
Are we supposed to do pylint using git hub action too? I am confused whether we have to resolve the issues we get from pylint or write git hub action only?

I think we're supposed to write the action for linting, then resolve the issues raised by the action on the original solution. So you then end up with a 'cleaner' version of the original homework solution

Thanks I will do the linting first.

I think we have to do linting for the unit test.

I did the pylinting for the algorithm with module too. So is it okay to make just the issues about what I get or make a pull request on it.


ETCD-520: add BackendQuotaGiB example

This PR adds an example for a new field BackendQuotaGiB within EtcdSpec type.
Example for https://github.com/openshift/api/pull/1736
see https://issues.redhat.com/browse/ETCD-513
cc @openshift/openshift-team-etcd  @JoelSpeed  @deads2k

Example looks good, you'll need to update the existing test cases now though as the new default value is making the expected values wrong

updated 👍🏽

You'll need to update all the cases not just the first one, quite a few will have the new default effect them

You'll need to update all the cases not just the first one, quite a few will have the new default effect them

i dont think all the other cases, because the failure differs on specific case for specific feature gate iiuc
lets see how it goes now, then i update the failures :)
thanks a lot for your quick reviews 🙏🏽 🙏🏽 🙏🏽

/lgtm


Fix literal

Hi, thanks for this project! 🙌
A quick PR to fix the literal in the config.
As a side note, you may want to switch to the following import, so that you don't need to define your own type for this:
/** @type {import('@typescript-eslint/utils').TSESLint.Linter.Config} */

More details about that type here: https://github.com/typescript-eslint/typescript-eslint/issues/2153#issuecomment-637817367

Glad to help, thanks for the merge!


At least a Typo...

Above it says:
Enable-CsMeetingRoom -Identity $rm -RegistrarPool'sippoolbl20a04.infra.lync.com' -SipAddressType EmailAddress
At a minimum, this is missing a space... -RegistrarPool'sippoolbl20a04.infra.lync.com' should be -RegistrarPool 'sippoolbl20a04.infra.lync.com'
Anddddd when the space is added, it gives an error about moving... and this error is not well documented.  I'm stuck.
Cannot move user in enable operation. Use the Move user cmdlet instead.
+ CategoryInfo          : InvalidOperation: (Enable-CsMeetingRoom:String) [Enable-CsMeetingRoom], InvalidOperationException
+ FullyQualifiedErrorId : ProcessRecord,Microsoft.Rtc.Management.AD.Cmdlets.EnableOcsMeetingRoomCmdlet
+ PSComputerName        : admin1a.online.lync.com

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9978e48b-5b8d-df59-d8d3-d3c90a8efafb
Version Independent ID: 52429f1d-39a1-49fb-c9dd-d4bafa19760d
Content: Deploy Skype Room Systems v2 with Exchange Online
Content Source: Skype/SfbServer/deploy/deploy-clients/with-exchange-online.md
Product: skype-for-business-itpro
GitHub Login: @jambirk
Microsoft Alias: jambirk

@davgroom, @sohailta any updates on this issue? Thanks.

@ChrisAtkinsonAL we recently refreshed that page with some info from the Exchange doc set, and your typo was fixed along the way. Are you still seeing this problem?

I can see the typo is fixed, which is great.
The error I had related to moving is because new users seem to be created in the correct SIPPool these days, so enabling it and specifying a New pool equal to the value of the Current pool fails the "move operation".  So, it's worth noting that you don't need to specify "-sippool $sippool -sipaddresstype emailaddress" if your new user's sippool already matches the other users in your organization.  That's why I was getting the move error.  Once I removed those paramaters, viola!

@ChrisAtkinsonAL Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.

@officedocsbot close


Deployed apps don't reevaluate cells marked as 'Reevaluates automatically'

Environment

Elixir & Erlang/OTP versions (elixir --version):  v1.15.7
Operating system: macOS 14.4.1
How have you started Livebook (mix phx.server, livebook CLI, Docker, etc):  macOS app
Livebook version (use git rev-parse HEAD if running with mix):  v0.12.1
Browsers that reproduce this bug (the more the merrier): Safari, Firefox
Include what is logged in the browser console: N/A
Include what is logged to the server console: N/A

Current behavior
Deployed apps don't reevaluate cells marked as 'Reevaluates automatically'.
For instance, in this example, when selecting a new entry in the dropdown menu in the deployed app, the following cell is not evaluated automatically.
However, it's the case when the entry is changed in Livebook (thus, not in deployed apps).
Expected behavior
I would expect the cells to be reevaluated automatically to offer a consistent experience.

@jonatanklosko do you remember why we disable reevaluate automatically for apps? I think it makes sense to keep due to the input behaviour, no?

@josevalim it may have been a side effect, we first had automatic reevaluation for everything (#1928), so we skipped the logic for "automatically reevaluating" cells, and then we reverted to reevaluate changes with a button (#2066), but the "automatically reevaluating" logic is still skipped. I don't remember nor couldn't find if we actually discussed "automatically reevaluating" cells specifically.
So with that context, I think it's fine to allow them. It should cover some of the use cases where reevaluating manually is awkward, but it's optional, so doesn't break the use cases where we want to avoid eager reevaluation. Hopefully it's not confusing to have yet another behaviour in the equation, but in terms of consistency it probably makes sense.

Oh, looking at #2066, this test indicates it could've been intentional.

@josevalim perhaps initially we said that "automatically reevaluating" doesn't apply to apps and just rolled with it. Anyway, I'm ok making the change, wdyt?

Agreed. I also think we forgot about the input cases and I would reenable it :)

Thanks! This small change will make much easier to deploy prototype web apps 🙏


polymer properties -- need Property to support synchronous notifications

 Issue by jmesserly
Originally opened as dart-lang/sdk#18343

as implemented by observe-js Observer.createBindablePrototypeAccessor and Observer.bindToInstance.
https://github.com/Polymer/observe-js/commit/762f600d31b3a25152cf6b16585ef507d5f51f2e
I've been ignoring this problem for a while because final Property<T> fieldName = new Property<T>(val); is more verbose than @published T fieldName = val;, and it adds verbosity to usage. But I don't think we can anymore. On the bright side, we can more easily experiment with other ways of doing notifications.

 Comment by jmesserly

correction to above:

T set fieldName(x) { _fieldName.value = x; }

set fieldName(T x) { _fieldName.value = x; }

 Comment by blois

Ideas on how this would impact memory usage? In a system with an extremely rich set of bindable properties but which only a fraction of which are actually set, there's going to be quite a bit of overhead of these per-instance Property fields.
If there's a base-class for these then there could be sparse storage of non-default properties in a dictionary on the base, using something such as:
static const _fieldName = const Property<bool>(#fieldName, initialValue);
bool get fieldName => _fieldName.get(this);
void set fieldName(bool value) { _fieldName.set(this, value); }
Alternatively, may be able to do:
bool get fieldName => get(#fieldName, orElse() => defaultValue);
void set fieldName(bool value) { set(#fieldName, value); }

 Comment by jmesserly

Also, maybe this is a better pattern to encourage:
final _fieldName = new Property<T>(val);
T get fieldName => _fieldName.value;
T set fieldName(x) { _fieldName.value = x; }
... it's even worse at declaration time, but avoids the ".value" for access.
@blois @sigmund -- thoughts here on best looking API?

cc @blois.
cc @sigmundch.

 Comment by jmesserly

we need a property that redirects the getter/setter to another object, immediately. And is configured at runtime.
https://github.com/Polymer/observe-js/blob/master/src/observe.js#L1277 that one and bindToInstance right below it.
The only way I could think of to get that indirection is having an object for indirection.
We could do a transformation, but... it would have to be on in development mode too :(. I'm not really a fan of that, personally... At that point, it feels like we're inventing language syntax instead of just optimizing for deployment. But if you & Justin & Pete like the idea, go for it...

cc @justinfagnani.

 Comment by jmesserly

Removed Area-Polymer label.
Added Pkg-Polymer, Area-Pkg labels.

 Comment by sigmundch

Added this to the Later milestone.
Removed Priority-Unassigned label.
Added Priority-Medium label.

 Comment by jmesserly

Issue dart-lang/observe#43 has been merged into this issue.

 Comment by sigmundch

I'm trying to think of other alternatives, but I'm not sure I have the whole picture yet. Do we need both sync and async notifications, depending on how the property is used? Is this needed for Observable, or only for Bindable?
Some ideas I'm trying to think about is whether this could this be addressed by adding a second API that provides the other notification timing. For example, '.changesSync' in Observable, or 'openSync' in Bindable?

 Comment by sigmundch

Removed this from the Later milestone.

 Comment by sigmundch

Added Polymer-P-2 label.

 Comment by sigmundch

Removed Polymer-P-2 label.
Added Polymer-Milestone-Later label.

 Comment by sigmundch

I've been looking into this while working on rolling the polymer package.
The good news - the hacky code moved out of observe-js and now lives in polymer.
The bad news - the hack of redefining the prototype is still there and is also used for computed properties.
If I understand correctly, here is my understanding of how timing is different here. The logic is differs when there is a binding on a property and when there is not, so here is are details for each case. I am using foo as an example. In JS it represents the public property, and foo_ is the private property (copied from the originally declared foo).
No bindings:
  - js read operation
      - invoke foo getter
      - returns foo_
    (all sync)
  - dart read operation
      - read foo's value
    (this is the only case where Dart and JS match in timing)
  - js write operation
      - invoke foo setter
      - set foo_
      - reflect foo_ value to attribute (if any)
    (all sync)
   - dart write operation
      - set foo
      ... (async break)
      - on change event, reflect to attribute
With a binding on the property:
   - js read operation
       - invoke foo getter
       - invoke bindable.deliver()
          - deliver may set foo_
          - if so, it reflects to attribute too
       - return latest value of foo_
     (all sync)
   - dart read operation
      - read foo's current value
        (which may not include latest changes from bindable)
   - js write operation
      - invoke foo setter
      - set value on bindable
      ... (async break)
      - when bindable delivers, set foo_
      - reflect to attribute

    - dart write operation
      - set foo
      ...
      - on change event, set value on bindable
      - also on change event, reflect to attribute
        (which may not be synchronously at the same time as we update bindable).

 Comment by sigmundch

Removed Polymer-Milestone-Later label.
Added PolymerMilestone-Later label.

 Comment by jmesserly

this was landed a while back

 Comment by sigmundch

I decided to go with Pete's suggestion. Part of the reason is that notifications are delivered from the object that contains the property, not the property object itself.
The syntax looks like this:
  @published
  int get property => readValue(#property, () => 42);
  set property(int value) => writeValue(#property, value);
The change is included in the roll of polymer to match 0.3.4 of polymer.js, which includes also computed properties. See:
  https://codereview.chromium.org/420673002/

Added Started label.


FLV streaming

Proxy RTMP->HTTP/WS, transmux FLV on client: https://github.com/Bilibili/flv.js

As server: https://github.com/winshining/nginx-http-flv-module


Simplify authorization for table config get

Minor improvement on top of #11621

Codecov Report

Merging #11640 (00fa0f5) into master (9bcbef8) will decrease coverage by 48.65%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master   #11640       +/-   ##
=============================================
- Coverage     63.10%   14.46%   -48.65%
+ Complexity     1120      201      -919
=============================================
  Files          2335     2335
  Lines        125212   125206        -6
  Branches      19209    19208        -1
=============================================
- Hits          79018    18111    -60907
- Misses        40560   105568    +65008
+ Partials       5634     1527     -4107

Flag
Coverage Δ

integration
?

integration1
?

integration2
?

java-11
?

java-17
14.46% <ø> (-48.50%)
:arrow_down:

java-20
?

temurin
14.46% <ø> (-48.65%)
:arrow_down:

unittests
14.46% <ø> (-48.64%)
:arrow_down:

unittests1
?

unittests2
14.46% <ø> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

...oller/api/resources/PinotTableRestletResource.java
47.13% <ø> (-0.03%)
:arrow_down:

... and 1509 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Scenes may get stuck when scrolling

Removing this code seems to fix it, but it is probably a hard performance hit when scrolling pages with many 3D objects (i.e.: CadQuery's documentation):
        // check if it's offscreen. If so skip it
        if ( rect.bottom < 0 || rect.top > renderer.domElement.clientHeight ||
             rect.right < 0 || rect.left > renderer.domElement.clientWidth ) {

            return; // it's off screen

Maybe we can do something else to fix it without sacrificing performance.

Fixed with 544d46de049c7cd5cb70450d2a32db538a23f70c.
The performance hit does not seem to be catastrofic...
Opened https://github.com/Peque/sphinxcadquery/issues/18


link-to-file-in-file-history is failing

https://github.com/sindresorhus/refined-github/commits/master/source/features/releases-tab.tsx
❌ Refined GitHub: feature `link-to-file-in-file-history`

 TypeError: "rootLink.closest(...) is null"
    link_to_file_in_file_history_init moz-extension://f449a952-bd7e-9d45-8185-d66afa8184e6/content.js:8043

I think we should wait a day. Looks like they are change a whole bunch of css there. would not be surprised to see other things break


Disposable/hres

Some cleaning
New styles
Responsive datepickers
Notification the first time you use it

@mbarrenechea is cookie just a wrapper and handler of document.cookie?

It's the js-cookie library that we were already using. So, answering your question, yes, I think that it's a wrapper of documet.cookie.
https://github.com/js-cookie/js-cookie
https://github.com/Vizzuality/gfw/blob/90918be507a9c39956f9375010b161a2c7b4c560/config/requirejs.yml#L39

Cool


feat: Provide a catalog for identifiable items in a statement.

wip
wip
scope v1.
scope v2
scope v3
first attempt at comparisons.
Add clause
use expressions.
provide parameters.
First round of polishing.
Polish context api.
docs
Polish.
Polish.

Hej @ikwattro from my perspective this is what the API would look like. There's room for extension, but for now, I think it solves the use cases.

One comment : Thanks a lot !


1.0.0 - Rewrite

Major rewrite

Structure is handled differently
Uses RethinkDB now
Has ability to remove any song by urlID

...and many more great improvements.

Might push one more thing before 1.0.0, so beware.


Update LLVM, unstable Rust and crate.io registry

Also drops Rust-specific LLVM patch and enables system LLVM for unstable Rust.
Cargo release fails to build with nightly Rust, so I've added cargoUnstable pointing at the git snapshot.

(llvm is already on staging, see #12200)

I think I'll test building this on an older LLVM later, and if not then rebase on staging. Thanks for the heads up!

This works with 3.7.0 but I think let's push this into staging to avoid Rust double rebuild (with 3.7.0 on master and 3.7.1 when staging is merged). I'm going to pick this into staging in several days if no issues are found before...

It looks good to me on the Rust / cargo side.


Fix code of conduct title (German localization)

Use German language title for German code of conduct.
Fixup for PR #18981
/kind cleanup
/priority backlog

/lgtm
/approve


Fix failing travis job

My best guess is that the issue is a solve that is timing out. To get to that job quickly it is temporarily added to the initial tests.

Merging without review to get the tests working again....

Black magic! 👏

This showed up in another package. I am so glad you figured it out so that I don't have to! 🙏 🙏 🙏

No worries; I picked up the trick from some other package (don't remember which one, it was last week 🤣)


update Readme.md

Fixes #1530
Describe the changes you have made in this PR -
which allows  ->  that allows

Coverage remained the same at 85.801% when pulling 273de5fa7c2d478a9f9c6d158f1125becec68258 on Sapna2001:readme into 032b6aa6640b6e14c981a2056a2e322bf5163b9e on CircuitVerse:master.

Thanks for the contribution, but it seems that there is already discussion about when to use which and that. Usage which seems fine here. I don't see any value in changing this
https://www.youtube.com/watch?v=6Js8tBCfbWk


Burn TX Fees

This is a concept to create a more anti-deflationary process within RBX. Since the TX fees are already so small the rewarded user doesn't see much benefit, but these fees globally added up over time and being burned can create a nice way for coins to leave the ecosystem in a healthy way.
Please feel free to comment with thoughts.

TX Fees will begin being burnt upon next version release.


Change connection api in data prep

Describe the bug
API regarding connection is changed and must be implemented in db type dataset creation process.
To Reproduce
Expected behavior
Check if db type dataset is created successfully
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

This is an urgent issue.


support PHP 8.0

@mjpvandenberg Hi, support for php 8 will come within the next few days.

@mjpvandenberg Hi, support for php 8 will come within the next few days.


feat(access): allow more flexible access checks

Description
Enable access checks with arbitrary check functions.
Why
Currently the frontend role check is only based on role name assuming the roles names are unique across clients. This assumption can be incorrect so we implemented a more flexible access check which allows to check for client id and role name. To be future-proof the mechanism now allows arbitrary checks to be executed for decision whether access is granted or not.
In the process some redundant code has been identified and removed.
Issue
#657
Checklist

[x] I have followed the contributing guidelines
[x] I have performed a self-review of my own code
[x] I have successfully tested my changes locally
[x] I have added tests that prove my changes work
[x] I have checked that new and existing tests pass locally with my changes
[x] I have commented my code, particularly in hard-to-understand areas

Looks good in general but as the impact of this change could be quite huge if there was some inconsistency in which client was validated updated to now:

The logic now intersects the resourceAccess attribute from the keycloak user token with a same object securing any resource. Access is granted if the intersection is not empty which means that at least one required client+role combination has been found in the user token. Tests for this logic are here:
https://github.com/eclipse-tractusx/portal-frontend/blob/feat/657/allow-clientid-for-rolecheck/src/utils/dataUtils.test.ts#L169-L176

did you check the following?: " The following resource needs to get checked when the user access the respective page:
URL	Ressource
/registration/*	Cl1-CX-Registration

Those URLs are from the registration app and the check must be implemented there.

/registration	Cl1-CX-Registration

https://github.com/eclipse-tractusx/portal-frontend/blob/feat/657/allow-clientid-for-rolecheck/src/types/Config.tsx#L111-L112

/?overlay=consent_osp	Cl1-CX-Registration

Looks like this overlay is not implemented any more.
https://portal.dev.demo.catena-x.net/?overlay=consent_osp
There is a page with this name - but it's broken
https://portal.dev.demo.catena-x.net/consent_osp
@jjeroch has this logic been changed or is it broken for other reasons?

/semantichub	Cl3-CX-Semantic

https://github.com/eclipse-tractusx/portal-frontend/blob/feat/657/allow-clientid-for-rolecheck/src/types/Config.tsx#L169-L175

/admin-credential	Cl24-CX-SSI-Credential-Issuer

https://github.com/eclipse-tractusx/portal-frontend/blob/feat/657/allow-clientid-for-rolecheck/src/types/Config.tsx#L567-L568

/usecase-participation	Cl2-CX-Portal
/certificate-credential	Cl2-CX-Portal
all others	Cl2-CX-Portal

all other pages are using userHasPortalRole checking for that client id if correctly injected:
https://github.com/eclipse-tractusx/portal-frontend/blob/feat/657/allow-clientid-for-rolecheck/src/services/AccessService.tsx#L97-L98

@oyo beside the comment added to the code; one more thing

Wallet UI - the revocation button should also need a {userHasSsiCredentialRole could you please check this once
Partner Network - for the Partner Network UI the user needs to have BPDM roles assigned; do we have this validation somewhere included? I couldnt see it

Wallet UI - the revocation button should also need a {userHasSsiCredentialRole could you please check this once

added userHasSsiCredentialRole(ROLES.REVOKE_CREDENTIALS_ISSUER) to the check

Partner Network - for the Partner Network UI the user needs to have BPDM roles assigned; do we have this validation somewhere included? I couldnt see it

it is implemented with the check allowTo: () => userHasBpdmRole(ROLES.READ_PARTNER),
https://github.com/eclipse-tractusx/portal-frontend/pull/873/files#diff-f207e98afeed11e7e08f809e36fa97a268e311ceeeebb779c00d05f3bf99ba6aR210

@oyo could you please resolve the conflicts? I'd approve it then.

@evegufy conflicts resolved and PR updated


remove global observability scope

motivation: better fit with long running process likes IDEs
changes:

remove the global bootstrap and scope
add observabilityScope argument to functions that need to emit diagnostics
adjust call sites and tests

@swift-ci please smoke test

@swift-ci please smoke test


feat: Add MDX rehypeSyntaxHighlight plugin options

What is it?

[x] Feature / enhancement
[ ] Bug
[ ] Docs / tests

Description
fixes #3603
Add plugin options for all 3 core plugins.
Use cases and why
// vite.config.mts

import fsharp from "refractor/lang/fsharp";

export default defineConfig(() => {
  return {
    plugins: [
      qwikCity({
        mdxPlugins: {
          remarkGfm: {
            singleTilde: false,
          },
          rehypeSyntaxHighlight: {
            setup(refractor) {
              refractor.register(fsharp)
            }
          },
          rehypeAutolinkHeadings: false,
        }
      })
    ]
  }

Checklist:

[x] My code follows the developer guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] Added new tests to cover the fix / functionality

This fix still contains a problem, types of refractor, remark-gfm and rehype-autolink-headings must be installed manually to have full functionality.
i.e. You must install remark-gfm manually to make remarkGfm option in mdxPlugins have type boolean | import('remark-gfm').Options, otherwise it will be any due to the bundle step doesn't bundle external types all together.
Despite this little problem, other functionalities just works fine.

It's a big problem, no? if we merge this, it will break everybody's project because of missing types

It's a big problem, no? if we merge this, it will break everybody's project because of missing types

@manucorporat I think it's possible to inline all the types to handle this problem, but I think the original solution requires more API design thinking.
The original issue wants to have setup function for configuring refractor, but qwik-city bundled every dependency into a single package, and user manually installed refractor package version may differ than our bundled version. Combining pieces of code from different versions of a package has a high potential for bugs and vulnerabilities.


Updated 1.0.5 npm package is broken, src folder is not included

I just wanted to mention again that the updated 1.0.5 npm package is broken, as the src folder is not included. So upon install nothing works.
Originally posted by @Abasz in https://github.com/8beeeaaat/web-ant-plus/issues/8#issuecomment-2098224231

Wow!! I'm sorry about this.
Just a moment.

I have one question, why do you need the src directory?
After npm install web-ant-plus is it used in your application as follows?
import {
  HeartRateSensor,
  HeartRateSensorState,
...
} from "web-ant-plus";

In my environment, web-ant-plus with npm install is working properly.

In general, NPM packages do not include development sources (src).It is bloated and users need the deliverables provided as a result of the build = dist directory, not the development sources.


Add docstrings.

You never document full_event and termination_result_fn which are passed as the kw args to every flow.
Not sure about the termination but the full_event indication should be documented somewhere i think

You are referring to V3ioDriver in your docs, but haven't documented this class.. so add docs to the driver


Fix Layer.affine assignment and broadcasting

Description
This changes Layer.affine.setter to index the TransformChain by integer index rather than key/name, which does not seem to work for TransformChain and maybe for EventedList in general. It also makes ndim a required keyword argument of coerce_affine (to be consistent with the other transform coercion functions) and passes that to Affine in all cases to ensure that the matrix is broadcast to the same number of dimensions as the layer.
I'm not sure if coerce_affine should also apply ndim when the input affine argument is an Affine transform. I think it probably should, but I haven't made that change yet, and would appreciate some input.
Type of change

[x] Bug-fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

References
Closes #3045
How has this been tested?

[x] new tests added to cover assignment and construction.
[ ] existing related tests continue to pass.

The new tests just use an identity affine matrix, as the main concern here is that the matrix is broadcast in some legal way. I did start writing tests with random linear/translate components of that matrix, but that takes a little complex to setup correctly. Let me know if you think that's a better idea.
Final checklist:

[x] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[ ] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

just tried this and it appears to fix both the problems I encountered in #3045 , yay !


[SPARK-15269][SQL] Removes unexpected empty table directories created while creating external Spark SQL data sourcet tables.

This PR is an alternative to #13120 authored by @xwu0226.
What changes were proposed in this pull request?
When creating an external Spark SQL data source table and persisting its metadata to Hive metastore, we don't use the standard Hive Table.dataLocation field because Hive only allows directory paths as data locations while Spark SQL also allows file paths. However, if we don't set Table.dataLocation, Hive always creates an unexpected empty table directory under database location, but doesn't remove it while dropping the table (because the table is external).
This PR works around this issue by explicitly setting Table.dataLocation and then manullay removing the created directory after creating the external table.
Please refer to this JIRA comment for more details about why we chose this approach as a workaround.
How was this patch tested?

A new test case is added in HiveQuerySuite for this case
Updated ShowCreateTableSuite to use the same table name in all test cases. (This is how I hit this issue at the first place.)

Test build #59169 has started for PR 13270 at commit f376332.

@xwu0226 Would you please help review this one? It's based on our discussion in your PR (#13120). The benefit of this version is that it avoids the bad case mentioned in this comment.

@liancheng sure. Thanks!

Test build #59169 has finished for PR 13270 at commit f376332.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59169/
Test FAILed.

Test build #59224 has started for PR 13270 at commit 7c77dc1.

Test build #59224 has finished for PR 13270 at commit 7c77dc1.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59224/
Test FAILed.

Test build #59246 has started for PR 13270 at commit 193e005.

Test build #59246 has finished for PR 13270 at commit 193e005.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59246/
Test FAILed.

Test build #59295 has started for PR 13270 at commit 64a0cfd.

@xwu0226 Thanks. Handled Hive compatible tables here. CatalogTable should be implementation agnostic, so it's infeasible to add a Hive specific flag to CatalogTable.

@liancheng Thanks! I see what you mean for the code you handle the hive compatible tables. This will handle the table lookup time.. But for creating table , we still possibly wrongly set the locationURI with <warehouse.dir>/tableName/__PLACEHOLDER__ for hive-compatible table. such that querying from Hive shell will not return any results, right?
This is one reason why I just wanted to tough the code path for creating non-hive compatible datasource table in createDataSourceTables.scala -> CreateDataSourceTableUtils.createDataSourceTable in my PR.

Test build #59295 has finished for PR 13270 at commit 64a0cfd.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59295/
Test FAILed.

@xwu0226 No we shouldn't have problem with Hive compatible tables now since we only add the placeholder location URI when table.storage.locationUri is empty (see here), while Hive compatible tables always set this field.
(BTW, the placeholder path is <warehouse-dir>/<tableName>-__PLACEHOLDER__. String __PLACEHOLDER__ is part of the directory name rather than name of a sub-directory.)

@xwu0226 I should probably add a comment to explain the locationUri.isEmpty thing since it's not quite intuitive.

@liancheng I see. Thank you!!

@xwu0226 For your last comment in your PR, I also realized that we are not really using CatalogTable.storage.locationUri for data source tables while doing this PR.
This means we can set an arbitrary location URI to that field as long as this location:

is either an existing directory, or
a non-existing location, but can definitely be created as a new directory successfully by Hive

This PR takes the 2nd approach. Namely make a temporary directory and remove it later. The reason is that, I think it can be dangerous to set existing directories as location URI. I was afraid of the fact that Hive may try to delete that directory because of bugs in either Hive side or Spark side. Actually I tried to set / (which definitely exists) as location URI when doing this PR, and Hive tries to delete my root directory during unit test execution... (But that was probably caused my own bugs though.)

Test build #59311 has started for PR 13270 at commit db06f13.

@liancheng Thanks for the explanation!! It is safer this way. :)

Test build #59313 has started for PR 13270 at commit 1545f04.

Test build #59311 has finished for PR 13270 at commit db06f13.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59311/
Test PASSed.

Test build #59313 has finished for PR 13270 at commit 1545f04.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59313/
Test PASSed.

cc @yhuai

Test build #59632 has started for PR 13270 at commit 3830dbb.

Test build #59632 has finished for PR 13270 at commit 3830dbb.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59632/
Test FAILed.

Test build #59635 has started for PR 13270 at commit 336fb55.

Test build #59635 has finished for PR 13270 at commit 336fb55.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59635/
Test PASSed.

Test build #59687 has started for PR 13270 at commit 7d0122f.

Test build #59687 has finished for PR 13270 at commit 7d0122f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59687/
Test PASSed.

LGTM. @liancheng Can you merge this?

Merging to master and branch-2.0.
@xwu0226 @yhuai Thanks for the review!


Authorization completed with an error   com.twitter.sdk.android.core.TwitterAuthException: Authorize failed.

How to resolve this error
Authorization completed with an error
com.twitter.sdk.android.core.TwitterAuthException: Authorize failed.
at com.twitter.sdk.android.core.identity.TwitterAuthClient.handleAuthorize(TwitterAuthClient.java:112)
at com.twitter.sdk.android.core.identity.TwitterAuthClient.authorize(TwitterAuthClient.java:103)
at com.twitter.sdk.android.core.identity.TwitterLoginButton$LoginClickListener.onClick(TwitterLoginButton.java:160)
at android.view.View.performClick(View.java:5106)
at android.view.View$PerformClick.run(View.java:20329)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:135)
at android.app.ActivityThread.main(ActivityThread.java:5912)
at java.lang.reflect.Method.invoke(Native Method)
at java.lang.reflect.Method.invoke(Method.java:372)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1405)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1200)

I have this problem, too.Thanks for helping out.

Where's Twitter dev team? This issue was opened 2 months ago. And dev team still on holiday?

I received this error this morning. It was working earlier this week.

But it's not working on my side
On Wed, Jun 20, 2018, 6:46 PM Will<EMAIL_ADDRESS>wrote:

I received this error this morning. It was working earlier this week.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/twitter/twitter-kit-android/issues/123#issuecomment-398754091,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOkFL0E_5_2wx1lEfQWTfwGyGt4afKN0ks5t-lJNgaJpZM4Tp5dC
.

If you get any problem. please contact me on Skype: dung.nguyen-iavtech

I am also getting this kind of erro for Twitter sign in.
I have also updated Callback URL in my app settings.
I am using this gradle
`implementation 'com.twitter.sdk.android:twitter-core:3.3.0'
OAuth web view completed with an error
   com.twitter.sdk.android.core.identity.WebViewException
       at com.twitter.sdk.android.core.identity.OAuthWebViewClient.onReceivedSslError(OAuthWebViewClient.java:79)
       at yk.a(PG:494)
       at aiN.run(Unknown Source:2)
       at android.os.Handler.handleCallback(Handler.java:789)
       at android.os.Handler.dispatchMessage(Handler.java:98)
       at android.os.Looper.loop(Looper.java:164)
       at android.app.ActivityThread.main(ActivityThread.java:6541)
       at java.lang.reflect.Method.invoke(Native Method)
       at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)

I'm using android galaxy S6 Edge and had the same problem at first time login. Other device working fine. Please fix it !

config is option but this work
TwitterConfig config = new TwitterConfig.Builder(this)     .logger(new DefaultLogger(Log.DEBUG))     .twitterAuthConfig(new TwitterAuthConfig("CONSUMER_KEY", "CONSUMER_SECRET"))     .debug(true)     .build();   Twitter.initialize(config);

I have the same issue!! Please check...

Thanks!! :)


when value greater than 999, not count up expected

[x] Bug
[ ] Build issue
[ ] Feature request

Version info

Angular: 5
Angular CLI:
countup.js-angular2:

Description

Hi @inorganik ,
when start value and end value both greater than 999, the component become count down, not count up expected.
for example
start value is 100000
end value is  100099
I think the issue caused by this code.
    if (end > 999) {
      // make easing smoother for large numbers
      countUp = new CountUp(this.el.nativeElement, sta, end - 100, dec, dur / 2, this.options);
    }

Please have a look.
Thanks.

Ah, yes that is a bug. I'll make a fix soon. Thanks.

Fixed in v6.0.0


Added gateway functionality for dahsboards

Added kxdash.q file which allows async queries while connected to the gateway via kx dashboards

@jonnypress have pushed some updates here addressing comments. Have tested with @MorrisStranger-aq