LLVM Optimization Pass Crash on Merge successive reallocations of the same variable

I'm going through the this book. When I compile my tests on this branch of my code I sometimes get this issue during the optimization step.
$ (cd test && ponyc)
Building builtin -> /usr/lib/pony/0.28.0/packages/builtin
Building . -> /home/jwashton/Projects/ray_tracer_challenge/test
Building ponytest -> /usr/lib/pony/0.28.0/packages/ponytest
Building time -> /usr/lib/pony/0.28.0/packages/time
Building collections -> /usr/lib/pony/0.28.0/packages/collections
Building random -> /usr/lib/pony/0.28.0/packages/random
Building .. -> /home/jwashton/Projects/ray_tracer_challenge
Building promises -> /usr/lib/pony/0.28.0/packages/promises
Generating
 Reachability
 Selector painting
 Data prototypes
 Data types
 Function prototypes
 Functions
 Descriptors
Optimising
Stack dump:
0.	Running pass 'Function Pass Manager' on module 'test'.
1.	Running pass 'Merge successive reallocations of the same variable' on function '@_TestCanvas_ref_apply_oo'

Sometimes it works, sometimes it doesn't. Sometimes the issue disappears if I just try to compile again. Other times I find that any change I make to the code will make it go away (for example commenting out any one of the test suites in test/main.pony). This fact has so far frustrated my attempts to make a more minimal test case, but I'll keep trying.
Is the issue perhaps related to this loop from the _TestCanvas test?
This is on Fedora 29, kernel 5.0.4-200, using ponyc straight from the Fedora copr repository, per the readme.
$ ponyc --version
0.28.0 [release]
compiled with: llvm 3.9.1 -- cc (GCC) 8.3.1 20190223 (Red Hat 8.3.1-2)
Defaults: pic=false ssl=openssl_1.1.0

I'm very willing to provide more information upon request.

I'm unable to reproduce on MacOS El Capitan Ponyc 0.28.0 built with LLVM 7.0.1

Also unable to reproduce using Ubuntu Bionic with Ponyc 0.28.0 built with vendored LLVM 7.0.1

@Jwashton would you be able to build a version of ponyc from source, use that and see if you run into an issue?

I can't seem to reproduce this issue with a locally built version of ponyc and the system LLVM. Now recompiling with the vendored LLVM...

For the locally built, can you post the ponyc --version output?

$ ./build/release/ponyc --version
0.28.0-13fe1d39 [release]
compiled with: llvm 7.0.1 -- cc (GCC) 8.3.1 20190223 (Red Hat 8.3.1-2)
Defaults: pic=false ssl=openssl_1.1.0

So this could be an llvm 3.9.1 issue.

I am able to reproduce this using MacOS, latest ponyc and llvm 3.9.1.
So, this would be somehow related to the llvm version.

Can anyone else triage and verify my findings?

This could exist in other non-LLVM 7 versions, if anyone can test for that, it would be great.

I can try testing this in conjunction with #3122 for multiple LLVM versions.

I tested this on my Arch Linux desktop:
$ uname -a
Linux wink-desktop 5.0.4-arch1-1-ARCH #1 SMP PREEMPT Sat Mar 23 21:00:33 UTC 2019 x86_64 GNU/Linux

I tried 7.0.1 and 3.9.1:
$ ~/prgs/ponylang/ponyc-wink1/build.7.0.1/release/ponyc --version
0.28.0-b3200b21 [release]
compiled with: llvm 7.0.1 -- cc (GCC) 8.2.1 20181127
Defaults: pic=true ssl=openssl_1.1.0
$ ~/prgs/ponylang/ponyc-wink1/build.3.9.1/release/ponyc --version
0.28.0-b3200b21 [release]
compiled with: llvm 3.9.1 -- cc (GCC) 8.2.1 20181127
Defaults: pic=true ssl=openssl_1.1.0
wink@wink-desktop:~/prgs/graphics/ray_tracer_challenge/test ((remotes/origin/compilation_issue))

It worked 10 times with 7.0.1 and failed 5 in 10 times with 3.9.1:
$ for i in {1..10}; do ~/prgs/ponylang/ponyc-wink1/build.3.9.1/release/ponyc; done
Building builtin -> /home/wink/prgs/ponylang/ponyc-wink1/packages/builtin
Building . -> /home/wink/prgs/graphics/ray_tracer_challenge/test
Building ponytest -> /home/wink/prgs/ponylang/ponyc-wink1/packages/ponytest
Building time -> /home/wink/prgs/ponylang/ponyc-wink1/packages/time
Building collections -> /home/wink/prgs/ponylang/ponyc-wink1/packages/collections
Building random -> /home/wink/prgs/ponylang/ponyc-wink1/packages/random
Building .. -> /home/wink/prgs/graphics/ray_tracer_challenge
Building promises -> /home/wink/prgs/ponylang/ponyc-wink1/packages/promises
Generating
 Reachability
 Selector painting
 Data prototypes
 Data types
 Function prototypes
 Functions
 Descriptors
Optimising
Stack dump:
0.	Running pass 'Function Pass Manager' on module 'test'.
1.	Running pass 'Merge successive reallocations of the same variable' on function '@_TestCanvas_ref_apply_oo'
Segmentation fault (core dumped)
Building builtin -> /home/wink/prgs/ponylang/ponyc-wink1/packages/builtin
Building . -> /home/wink/prgs/graphics/ray_tracer_challenge/test
Building ponytest -> /home/wink/prgs/ponylang/ponyc-wink1/packages/ponytest
Building time -> /home/wink/prgs/ponylang/ponyc-wink1/packages/time
Building collections -> /home/wink/prgs/ponylang/ponyc-wink1/packages/collections
Building random -> /home/wink/prgs/ponylang/ponyc-wink1/packages/random
Building .. -> /home/wink/prgs/graphics/ray_tracer_challenge
Building promises -> /home/wink/prgs/ponylang/ponyc-wink1/packages/promises
Generating
 Reachability
 Selector painting
 Data prototypes
 Data types
 Function prototypes
 Functions
 Descriptors
Optimising
Stack dump:
0.	Running pass 'Function Pass Manager' on module 'test'.
1.	Running pass 'Merge successive reallocations of the same variable' on function '@_TestCanvas_ref_apply_oo'
Segmentation fault (core dumped)
Building builtin -> /home/wink/prgs/ponylang/ponyc-wink1/packages/builtin
Building . -> /home/wink/prgs/graphics/ray_tracer_challenge/test
Building ponytest -> /home/wink/prgs/ponylang/ponyc-wink1/packages/ponytest
Building time -> /home/wink/prgs/ponylang/ponyc-wink1/packages/time
Building collections -> /home/wink/prgs/ponylang/ponyc-wink1/packages/collections
Building random -> /home/wink/prgs/ponylang/ponyc-wink1/packages/random
Building .. -> /home/wink/prgs/graphics/ray_tracer_challenge
Building promises -> /home/wink/prgs/ponylang/ponyc-wink1/packages/promises
Generating
 Reachability
 Selector painting
 Data prototypes
 Data types
 Function prototypes
 Functions
 Descriptors
Optimising
Writing ./test.o
Linking ./test
Building builtin -> /home/wink/prgs/ponylang/ponyc-wink1/packages/builtin
Building . -> /home/wink/prgs/graphics/ray_tracer_challenge/test
Building ponytest -> /home/wink/prgs/ponylang/ponyc-wink1/packages/ponytest
Building time -> /home/wink/prgs/ponylang/ponyc-wink1/packages/time
Building collections -> /home/wink/prgs/ponylang/ponyc-wink1/packages/collections
Building random -> /home/wink/prgs/ponylang/ponyc-wink1/packages/random
Building .. -> /home/wink/prgs/graphics/ray_tracer_challenge
Building promises -> /home/wink/prgs/ponylang/ponyc-wink1/packages/promises
Generating
 Reachability
 Selector painting
 Data prototypes
 Data types
 Function prototypes
 Functions
 Descriptors
Optimising
Stack dump:
0.	Running pass 'Function Pass Manager' on module 'test'.
1.	Running pass 'Merge successive reallocations of the same variable' on function '@_TestCanvas_ref_apply_oo'
Segmentation fault (core dumped)
Building builtin -> /home/wink/prgs/ponylang/ponyc-wink1/packages/builtin
Building . -> /home/wink/prgs/graphics/ray_tracer_challenge/test
Building ponytest -> /home/wink/prgs/ponylang/ponyc-wink1/packages/ponytest
Building time -> /home/wink/prgs/ponylang/ponyc-wink1/packages/time
Building collections -> /home/wink/prgs/ponylang/ponyc-wink1/packages/collections
Building random -> /home/wink/prgs/ponylang/ponyc-wink1/packages/random
Building .. -> /home/wink/prgs/graphics/ray_tracer_challenge
Building promises -> /home/wink/prgs/ponylang/ponyc-wink1/packages/promises
Generating
 Reachability
 Selector painting
 Data prototypes
 Data types
 Function prototypes
 Functions
 Descriptors
Optimising
Writing ./test.o
Linking ./test
Building builtin -> /home/wink/prgs/ponylang/ponyc-wink1/packages/builtin
Building . -> /home/wink/prgs/graphics/ray_tracer_challenge/test
Building ponytest -> /home/wink/prgs/ponylang/ponyc-wink1/packages/ponytest
Building time -> /home/wink/prgs/ponylang/ponyc-wink1/packages/time
Building collections -> /home/wink/prgs/ponylang/ponyc-wink1/packages/collections
Building random -> /home/wink/prgs/ponylang/ponyc-wink1/packages/random
Building .. -> /home/wink/prgs/graphics/ray_tracer_challenge
Building promises -> /home/wink/prgs/ponylang/ponyc-wink1/packages/promises
Generating
 Reachability
 Selector painting
 Data prototypes
 Data types
 Function prototypes
 Functions
 Descriptors
Optimising
Stack dump:
0.	Running pass 'Function Pass Manager' on module 'test'.
1.	Running pass 'Merge successive reallocations of the same variable' on function '@_TestCanvas_ref_apply_oo'
Segmentation fault (core dumped)
Building builtin -> /home/wink/prgs/ponylang/ponyc-wink1/packages/builtin
Building . -> /home/wink/prgs/graphics/ray_tracer_challenge/test
Building ponytest -> /home/wink/prgs/ponylang/ponyc-wink1/packages/ponytest
Building time -> /home/wink/prgs/ponylang/ponyc-wink1/packages/time
Building collections -> /home/wink/prgs/ponylang/ponyc-wink1/packages/collections
Building random -> /home/wink/prgs/ponylang/ponyc-wink1/packages/random
Building .. -> /home/wink/prgs/graphics/ray_tracer_challenge
Building promises -> /home/wink/prgs/ponylang/ponyc-wink1/packages/promises
Generating
 Reachability
 Selector painting
 Data prototypes
 Data types
 Function prototypes
 Functions
 Descriptors
Optimising
Writing ./test.o
Linking ./test
Building builtin -> /home/wink/prgs/ponylang/ponyc-wink1/packages/builtin
Building . -> /home/wink/prgs/graphics/ray_tracer_challenge/test
Building ponytest -> /home/wink/prgs/ponylang/ponyc-wink1/packages/ponytest
Building time -> /home/wink/prgs/ponylang/ponyc-wink1/packages/time
Building collections -> /home/wink/prgs/ponylang/ponyc-wink1/packages/collections
Building random -> /home/wink/prgs/ponylang/ponyc-wink1/packages/random
Building .. -> /home/wink/prgs/graphics/ray_tracer_challenge
Building promises -> /home/wink/prgs/ponylang/ponyc-wink1/packages/promises
Generating
 Reachability
 Selector painting
 Data prototypes
 Data types
 Function prototypes
 Functions
 Descriptors
Optimising
Writing ./test.o
Linking ./test
Building builtin -> /home/wink/prgs/ponylang/ponyc-wink1/packages/builtin
Building . -> /home/wink/prgs/graphics/ray_tracer_challenge/test
Building ponytest -> /home/wink/prgs/ponylang/ponyc-wink1/packages/ponytest
Building time -> /home/wink/prgs/ponylang/ponyc-wink1/packages/time
Building collections -> /home/wink/prgs/ponylang/ponyc-wink1/packages/collections
Building random -> /home/wink/prgs/ponylang/ponyc-wink1/packages/random
Building .. -> /home/wink/prgs/graphics/ray_tracer_challenge
Building promises -> /home/wink/prgs/ponylang/ponyc-wink1/packages/promises
Generating
 Reachability
 Selector painting
 Data prototypes
 Data types
 Function prototypes
 Functions
 Descriptors
Optimising
Writing ./test.o
Linking ./test
Building builtin -> /home/wink/prgs/ponylang/ponyc-wink1/packages/builtin
Building . -> /home/wink/prgs/graphics/ray_tracer_challenge/test
Building ponytest -> /home/wink/prgs/ponylang/ponyc-wink1/packages/ponytest
Building time -> /home/wink/prgs/ponylang/ponyc-wink1/packages/time
Building collections -> /home/wink/prgs/ponylang/ponyc-wink1/packages/collections
Building random -> /home/wink/prgs/ponylang/ponyc-wink1/packages/random
Building .. -> /home/wink/prgs/graphics/ray_tracer_challenge
Building promises -> /home/wink/prgs/ponylang/ponyc-wink1/packages/promises
Generating
 Reachability
 Selector painting
 Data prototypes
 Data types
 Function prototypes
 Functions
 Descriptors
Optimising
Stack dump:
0.	Running pass 'Function Pass Manager' on module 'test'.
1.	Running pass 'Merge successive reallocations of the same variable' on function '@_TestCanvas_ref_apply_oo'
Segmentation fault (core dumped)

While testing #3122 I created a debug version of llvm-3.9.1 and linked it to a release version of ponyc:
wink@wink-desktop:~/prgs/ponylang/ponyc-wink1 (support-simultaneous-llvm-checkouts)
$ time make -j12 -f Makefile-lib-llvm default_pic=true default_ssl=openssl_1.1.0 use=llvm_link_static LLVM_CFG=llvm-3.9.1.cfg LLVM_BUILD_TYPE=Debug
make[1]: Entering directory '/home/wink/prgs/ponylang/ponyc-wink1/lib/llvm'
getting /home/wink/prgs/ponylang/ponyc-wink1/lib/llvm/gen/v3.9.1-Debug/tgt/get-submodule
Synchronizing submodule url for 'src'
Submodule path 'src': checked out 'd0d8eb2e5415b8be29343e3c17a18e49e67b5551'
checkout 41dbbb7c22da5
Checking out files: 100% (49116/49116), done.
Previous HEAD position was d0d8eb2e541 Merging r345839:
HEAD is now at 41dbbb7c22d Merging r288433:
generate v3.9.1-Debug hash=41dbbb7c22d ref= (HEAD, tag: llvmorg-3.9.1-rc3, tag: llvmorg-3.9.1, origin/release/3.9.x)

...

heap.cc
pool.cc
Linking libponyrt
Linking libblake2
Linking libponyrt-pic
Linking libgtest
Linking libgbenchmark
Linking libponyc
Linking libponyrt.tests
Linking libponyrt.benchmarks
Linking ponyc
Linking libponyc.benchmarks
Linking libponyc.tests
make[1]: Leaving directory '/home/wink/prgs/ponylang/ponyc-wink1'

real	12m41.963s
user	112m40.493s
sys	7m1.313s

Here is the version info:
wink@wink-desktop:~/prgs/ponylang/ponyc-wink1 (support-simultaneous-llvm-checkouts)
$ ~/prgs/ponylang/ponyc-wink1/build.3.9.1/release-llvm-Debug/ponyc --version
0.28.0-536bdefd [release]
compiled with: llvm 3.9.1 -- cc (GCC) 8.2.1 20181127
Defaults: pic=true ssl=openssl_1.1.0

I then tested it in the loop as before and all 10 succeeded. I'm not sure what that proves but its a data point that seems to point to a problem in LLVM as in this test and in my other test pony was compiled in Release mode:
$ for i in {1..10}; do ~/prgs/ponylang/ponyc-wink1/build.3.9.1/release-llvm-Debug/ponyc; done
Building builtin -> /home/wink/prgs/ponylang/ponyc-wink1/packages/builtin
Building . -> /home/wink/prgs/graphics/ray_tracer_challenge/test
Building ponytest -> /home/wink/prgs/ponylang/ponyc-wink1/packages/ponytest
Building time -> /home/wink/prgs/ponylang/ponyc-wink1/packages/time
Building collections -> /home/wink/prgs/ponylang/ponyc-wink1/packages/collections
Building random -> /home/wink/prgs/ponylang/ponyc-wink1/packages/random
Building .. -> /home/wink/prgs/graphics/ray_tracer_challenge
Building promises -> /home/wink/prgs/ponylang/ponyc-wink1/packages/promises
Generating
 Reachability
 Selector painting
 Data prototypes
 Data types
 Function prototypes
 Functions
 Descriptors
Optimising
Writing ./test.o
Linking ./test
Building builtin -> /home/wink/prgs/ponylang/ponyc-wink1/packages/builtin
Building . -> /home/wink/prgs/graphics/ray_tracer_challenge/test
Building ponytest -> /home/wink/prgs/ponylang/ponyc-wink1/packages/ponytest
Building time -> /home/wink/prgs/ponylang/ponyc-wink1/packages/time
Building collections -> /home/wink/prgs/ponylang/ponyc-wink1/packages/collections
Building random -> /home/wink/prgs/ponylang/ponyc-wink1/packages/random
Building .. -> /home/wink/prgs/graphics/ray_tracer_challenge
Building promises -> /home/wink/prgs/ponylang/ponyc-wink1/packages/promises
Generating
 Reachability
 Selector painting
 Data prototypes
 Data types
 Function prototypes
 Functions
 Descriptors
Optimising
Writing ./test.o
Linking ./test
Building builtin -> /home/wink/prgs/ponylang/ponyc-wink1/packages/builtin
Building . -> /home/wink/prgs/graphics/ray_tracer_challenge/test
Building ponytest -> /home/wink/prgs/ponylang/ponyc-wink1/packages/ponytest
Building time -> /home/wink/prgs/ponylang/ponyc-wink1/packages/time
Building collections -> /home/wink/prgs/ponylang/ponyc-wink1/packages/collections
Building random -> /home/wink/prgs/ponylang/ponyc-wink1/packages/random
Building .. -> /home/wink/prgs/graphics/ray_tracer_challenge
Building promises -> /home/wink/prgs/ponylang/ponyc-wink1/packages/promises
Generating
 Reachability
 Selector painting
 Data prototypes
 Data types
 Function prototypes
 Functions
 Descriptors
Optimising
Writing ./test.o
Linking ./test
Building builtin -> /home/wink/prgs/ponylang/ponyc-wink1/packages/builtin
Building . -> /home/wink/prgs/graphics/ray_tracer_challenge/test
Building ponytest -> /home/wink/prgs/ponylang/ponyc-wink1/packages/ponytest
Building time -> /home/wink/prgs/ponylang/ponyc-wink1/packages/time
Building collections -> /home/wink/prgs/ponylang/ponyc-wink1/packages/collections
Building random -> /home/wink/prgs/ponylang/ponyc-wink1/packages/random
Building .. -> /home/wink/prgs/graphics/ray_tracer_challenge
Building promises -> /home/wink/prgs/ponylang/ponyc-wink1/packages/promises
Generating
 Reachability
 Selector painting
 Data prototypes
 Data types
 Function prototypes
 Functions
 Descriptors
Optimising
Writing ./test.o
Linking ./test
Building builtin -> /home/wink/prgs/ponylang/ponyc-wink1/packages/builtin
Building . -> /home/wink/prgs/graphics/ray_tracer_challenge/test
Building ponytest -> /home/wink/prgs/ponylang/ponyc-wink1/packages/ponytest
Building time -> /home/wink/prgs/ponylang/ponyc-wink1/packages/time
Building collections -> /home/wink/prgs/ponylang/ponyc-wink1/packages/collections
Building random -> /home/wink/prgs/ponylang/ponyc-wink1/packages/random
Building .. -> /home/wink/prgs/graphics/ray_tracer_challenge
Building promises -> /home/wink/prgs/ponylang/ponyc-wink1/packages/promises
Generating
 Reachability
 Selector painting
 Data prototypes
 Data types
 Function prototypes
 Functions
 Descriptors
Optimising
Writing ./test.o
Linking ./test
Building builtin -> /home/wink/prgs/ponylang/ponyc-wink1/packages/builtin
Building . -> /home/wink/prgs/graphics/ray_tracer_challenge/test
Building ponytest -> /home/wink/prgs/ponylang/ponyc-wink1/packages/ponytest
Building time -> /home/wink/prgs/ponylang/ponyc-wink1/packages/time
Building collections -> /home/wink/prgs/ponylang/ponyc-wink1/packages/collections
Building random -> /home/wink/prgs/ponylang/ponyc-wink1/packages/random
Building .. -> /home/wink/prgs/graphics/ray_tracer_challenge
Building promises -> /home/wink/prgs/ponylang/ponyc-wink1/packages/promises
Generating
 Reachability
 Selector painting
 Data prototypes
 Data types
 Function prototypes
 Functions
 Descriptors
Optimising
Writing ./test.o
Linking ./test
Building builtin -> /home/wink/prgs/ponylang/ponyc-wink1/packages/builtin
Building . -> /home/wink/prgs/graphics/ray_tracer_challenge/test
Building ponytest -> /home/wink/prgs/ponylang/ponyc-wink1/packages/ponytest
Building time -> /home/wink/prgs/ponylang/ponyc-wink1/packages/time
Building collections -> /home/wink/prgs/ponylang/ponyc-wink1/packages/collections
Building random -> /home/wink/prgs/ponylang/ponyc-wink1/packages/random
Building .. -> /home/wink/prgs/graphics/ray_tracer_challenge
Building promises -> /home/wink/prgs/ponylang/ponyc-wink1/packages/promises
Generating
 Reachability
 Selector painting
 Data prototypes
 Data types
 Function prototypes
 Functions
 Descriptors
Optimising
Writing ./test.o
Linking ./test
Building builtin -> /home/wink/prgs/ponylang/ponyc-wink1/packages/builtin
Building . -> /home/wink/prgs/graphics/ray_tracer_challenge/test
Building ponytest -> /home/wink/prgs/ponylang/ponyc-wink1/packages/ponytest
Building time -> /home/wink/prgs/ponylang/ponyc-wink1/packages/time
Building collections -> /home/wink/prgs/ponylang/ponyc-wink1/packages/collections
Building random -> /home/wink/prgs/ponylang/ponyc-wink1/packages/random
Building .. -> /home/wink/prgs/graphics/ray_tracer_challenge
Building promises -> /home/wink/prgs/ponylang/ponyc-wink1/packages/promises
Generating
 Reachability
 Selector painting
 Data prototypes
 Data types
 Function prototypes
 Functions
 Descriptors
Optimising
Writing ./test.o
Linking ./test
Building builtin -> /home/wink/prgs/ponylang/ponyc-wink1/packages/builtin
Building . -> /home/wink/prgs/graphics/ray_tracer_challenge/test
Building ponytest -> /home/wink/prgs/ponylang/ponyc-wink1/packages/ponytest
Building time -> /home/wink/prgs/ponylang/ponyc-wink1/packages/time
Building collections -> /home/wink/prgs/ponylang/ponyc-wink1/packages/collections
Building random -> /home/wink/prgs/ponylang/ponyc-wink1/packages/random
Building .. -> /home/wink/prgs/graphics/ray_tracer_challenge
Building promises -> /home/wink/prgs/ponylang/ponyc-wink1/packages/promises
Generating
 Reachability
 Selector painting
 Data prototypes
 Data types
 Function prototypes
 Functions
 Descriptors
Optimising
Writing ./test.o
Linking ./test
Building builtin -> /home/wink/prgs/ponylang/ponyc-wink1/packages/builtin
Building . -> /home/wink/prgs/graphics/ray_tracer_challenge/test
Building ponytest -> /home/wink/prgs/ponylang/ponyc-wink1/packages/ponytest
Building time -> /home/wink/prgs/ponylang/ponyc-wink1/packages/time
Building collections -> /home/wink/prgs/ponylang/ponyc-wink1/packages/collections
Building random -> /home/wink/prgs/ponylang/ponyc-wink1/packages/random
Building .. -> /home/wink/prgs/graphics/ray_tracer_challenge
Building promises -> /home/wink/prgs/ponylang/ponyc-wink1/packages/promises
Generating
 Reachability
 Selector painting
 Data prototypes
 Data types
 Function prototypes
 Functions
 Descriptors
Optimising
Writing ./test.o
Linking ./test

If this is looking like a bug in earlier versions of LLVM, I'm tempted to say we shouldn't bother investigating further until it's been reproduced on a more recent version of LLVM.

Managed to reproduce this behaviour on LLVM 7.1.0 with the following code:
actor Main
  let a: Array[(U64, U64)] = [as (U64, U64):
    (0,0); (1,0); (2,0); (3,0); (4,0); (5,0); (6,0)
    (7,0); (8,0); (9,0); (0,2); (9,2); (0,3); (9,3)
    (0,4); (9,4); (0,5); (9,5); (0,6); (9,6); (0,7)
    (9,7); (0,8); (9,8); (0,9); (1,9); (2,9); (3,9)
    (4,9); (5,9); (6,9); (7,9); (8,9)
  ]

  new create(env: Env) => None

(although the code works correctly in the pony playground)
Compiling the above:
$ ponyc test/
Building builtin -> /usr/local/Cellar/ponyc/0.33.0/packages/builtin
Building test/ -> ~/Downloads/test
Generating
 Reachability
 Selector painting
 Data prototypes
 Data types
 Function prototypes
 Functions
 Descriptors
Optimising
Stack dump:
0.	Running pass 'Function Pass Manager' on module 'test'.
1.	Running pass 'Merge successive reallocations of the same variable' on function '@Main_Dispatch'
Segmentation fault: 11

This is on macOS Mojave 10.14.6, ponyc version:
ponyc --version
0.33.0 [release]
compiled with: llvm 7.1.0 -- Apple clang version 11.0.0 (clang-1<IP_ADDRESS>)
Defaults: pic=false

Not an issue with LLVM version we currently support.

@SeanTAllen I can still reproduce this crash on my machine (macOS Mojave 10.14.6) with the example I posted in my comment above. This is with LLVM 9.0.1
$ ponyc test/
Building builtin -> ~/.local/share/ponyup/ponyc-release-0.37.0-x86_64-darwin/packages/builtin
Building ptest/ -> ~/Downloads/test
Generating
 Reachability
 Selector painting
 Data prototypes
 Data types
 Function prototypes
 Functions
 Descriptors
Optimising
Stack dump:
0.	Running pass 'Function Pass Manager' on module 'test'.
1.	Running pass 'Merge successive reallocations of the same variable' on function '@Main_Dispatch'
Segmentation fault: 11

$ ponyc --version
0.37.0-991bec5c [release]
Compiled with: LLVM 9.0.1 -- AppleClang-<IP_ADDRESS>30032-x86_64
Defaults: pic=true

@ergl can you open a new issue?


[Bug] @openapi.parameter(allowed_values=...)

Describe the bug
Missed the possibility to point out allowed values of path or query string parameters in sanic-ext openapi decorator.
I remember it was possible when openapi docs were settled with @doc decorator. But in @openapi.parameter I don't see any possible keys to set such values. Key kwargs decieves me in this case.
Expected behavior
For example I have a parameter which shall accept an int in range from 0 to 2.
I'd like to point it out in swagger and to make this field accept not any input, but only preset choices: 0, 1 and 2.
So I expect to find in @openapi.parameter a key like allowed_values or something like that:
@openapi.parameter(..., allowed_values=list(range(3)))
Additional question
Is it possible to make swagger fields to be dependant from the value set in other fields?
For example I have a field device with allowed values screen, phone, tablet and a field size.
Each kind of device has its correspondent range of sizes, e.g.: screens: 15''-40'', phone: 5''-8'', tablets: 9''-15''.
Depending on the device value field size shall allow in swagger to choose any size from the correspondent range.
Is it possible?

Documentation, yes! But I want to leave it because it points to a larger issue in needing to update the API to make it more intuitive.

You're the boss))


We should try larger datasets

In order to be able to test higher and larger datasets we should probably try the following datasets:
http://massive.ucsd.edu/ProteoSAFe/static/massive-kb-libraries.jsp

Other larger datasets:
https://chemdata.nist.gov/dokuwiki/doku.php?id=peptidew:cdownload

all data already indexed and DB created.


Add Unit Testing for AspNet* Triggers

Adds unit testing for AspNet* triggers. Noticed that RequestCount and ResponseCount were not causing errors when omitted in the testing; this was because their values were not nullable (they defaulted to 0). Users will now see the error message when these properties are omitted due to switching to the int? type.

/backport to release/6.x

/backport to release/6.x


Fix volume scheudling fixes

addresses https://github.com/rancher/rancher/issues/6661

LGTM

Failures unrelated


Click on desktop – Widgets appear again

Hello and thank you for a MUCH needed feature for the new widgets – very happy that you made this.
I noticed that when you click the desktop in order to show the desktop, the widgets appear again (even though they are hidden by widgettoggler). As soon as you click again to let the windows appear again, the widgets disappear again.

Hey, thank you!
Sadly I have no control over temporarily showin g the widgets when clicking on the desktop.
You can disable this behaviour in system settings though:

Stumbled upon the same issue.
Suggestion: Maybe you add that info (or a link to this issue) to the readme.
Thanks, though 💚


Summary: chore(*): reconfigure automatic closing of issues and PRs

With this change, all PRs and issues are subject to automatic timeout after 28 days of inactivity.
KAG-875

Hans, please see my note on this one. This may be too broad of a change for the open-source community.


Becky edits

@teixeirak I think I've sorted the Fortuna sites - there were multiple citation references in the Taylor databases, but the Adamek one seems to be incorrect, so I'm not sure why it was in there.
The plot co-ordinates are from Heineman_2016_viwn - this paper contains slightly different precipitation values to Heineman_2016_vicl (where the litterfall values come from). The precipitation values I've put in the database are from Heineman_2016_vicl, so they're from the same pub as the litterfall data.
All a bit complicated, but hopefully sorted!

Thanks @beckybanbury !


XPlat Solution for reading XEL

https://www.nuget.org/packages/Microsoft.SqlServer.XEvent.XELite/

currently read-dbaxefile is broken on some systems because xevents dll and new smo or something. this may help.

@StartAutomating - can you take a look at this? I tried for a few minutes but could not progress much at all. I added a couple commits to https://github.com/sqlcollaborative/dbatools/tree/xplatxe

there's this which can be peeked upon using dnspy https://www.powershellgallery.com/packages/SqlServer.XEvent/1.3 or adding the DLL thta makes it work when sql is installed locally


Hardware id for signing?

Hi barry, I need to support my print support app on every printer of computer. What should I write for hardware id at device metadata package file to get signed by hardware center? Here is the discussion on osr community(windows driver community):
[Enter feedback here]
https://community.osr.com/discussion/294124/uwp-psa-app-for-every-printer#latest
Below I copied the contents from osr:
I am trying to write a uwp app for every printer on my local computer. My starting point is https://github.com/Microsoft/print-oem-samples .I managed to succeed on test mode of windows. Basically, I install my inf file with pnputil, and copy device metadata under C:\ProgramData\Microsoft\Windows\DeviceMetadataStore\en-US and finally install my appx package (build by visual studio). Whenever I try to submit device metadata on windows hardware dev center I got error
UpdateExperienceSubmission failed  ExperienceError: The provided Bus type: PRINTENUM is not supported

Even suggested example has a hardware id that starts with printenum. github.
Below are my inf and packageinfo.xml files (added 2 hardware id's to the example metadata). I can share a github url if you want to reproduce this on your environment.
<?xml version="1.0" encoding="utf-8"?>
<PackageInfo xmlns="http://schemas.microsoft.com/windows/DeviceMetadata/PackageInfo/2007/11/">
  <MetadataKey>
    <HardwareIDList>
      <HardwareID>DOID:PRINTENUM\{1d929688-31c7-44c5-aa61-8e6683046df0} </HardwareID>
      <HardwareID>DOID:{1d929688-31c7-44c5-aa61-8e6683046df0}</HardwareID>
      <HardwareID>DOID:LocalPrintQueue</HardwareID>
      <HardwareID>DOID:PRINTENUM\LocalPrintQueue</HardwareID>
    </HardwareIDList>
    <Locale default="true">en-US</Locale>
    <LastModifiedDate>2023-11-17T07:48:08.7420452Z</LastModifiedDate>
    <MultipleLocale xmlns="http://schemas.microsoft.com/windows/2010/08/DeviceMetadata/PackageInfov2">true</MultipleLocale>
  </MetadataKey>
  <PackageStructure>
    <Metadata MetadataID="http://schemas.microsoft.com/windows/DeviceMetadata/DeviceInfo/2007/11/">DeviceInfo</Metadata>
    <Metadata MetadataID="http://schemas.microsoft.com/windows/DeviceMetadata/WindowsInfo/2007/11/">WindowsInfo</Metadata>
    <Metadata MetadataID="http://schemas.microsoft.com/windows/DeviceMetadata/PackageInfo/2007/11/">PackageInfo.xml</Metadata>
    <Metadata MetadataID="http://schemas.microsoft.com/windows/2010/08/DeviceMetadata/SoftwareInfo">SoftwareInfo</Metadata>
  </PackageStructure>
  <Relationships>
    <ExperienceID>aabe74d8-31a2-461b-9039-8687e960e0e0</ExperienceID>
  </Relationships>
  <MetadataBuilderInformation>
    <Application>Microsoft Device Metadata Package Authoring Tool</Application>
    <Version>10.0.15063.0</Version>
  </MetadataBuilderInformation>
</PackageInfo>

[Version]
Signature = "$WINDOWS NT$"
Class = Extension
ClassGuid = {e2f84ce7-8efa-411c-aa69-97454ca4cb57}
Provider = %ManufacturerName%
ExtensionId = {D4D9196A-105B-4B76-B693-84BD33A7A703}
CatalogFile = psa.cat
DriverVer = 05/19/2020,<IP_ADDRESS>2
PnpLockdown = 1

[Manufacturer]
%ManufacturerName% = Microsoft, NTamd64.6.3

[Microsoft.NTamd64.6.3]
%Device.ExtensionDesc% = PSA-Install, %PrinterHardwareId%
%Device.ExtensionDesc% = PSA-Install, %PrinterHardwareId2%
%Device.ExtensionDesc% = PSA-Install, %PrinterHardwareId3%

[PSA-Install.NT]
AddProperty = Add-PSA-Property

[PSA-Install.NT.Software]
AddSoftware = %SoftwareName%,, Microsoft-PSA-SoftwareInstall

[Microsoft-PSA-SoftwareInstall]
SoftwareType = %MicrosoftStoreType%
SoftwareID = pfn://%PackageFamilyName%

[Add-PSA-Property]
{A925764B-88E0-426D-AFC5-B39768BE59EB}, 1, 0x12,, %AUMID%

[Strings]
ManufacturerName = "Microsoft"
SoftwareName = "Microsoft Print Support App"
Device.ExtensionDesc = "Print Support App Extension"
MicrosoftStoreType = 2
PackageFamilyName = "Microsoft.WorkflowAndWSDACombinedSamplee_c814c02khqfpc"
AUMID = "Microsoft.WorkflowAndWSDACombinedSamplee_c814c02khqfpc!App"
PrinterHardwareId = "PRINTENUM\LocalPrintQueue"
PrinterHardwareId2 = "LocalPrintQueue"
PrinterHardwareId3 = "PSA_BrotherMFC-J775DWF678"

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: cce233db-310f-5eda-3f9a-676a6b7c60af
Version Independent ID: 42521d92-86d5-1fc5-2049-8abd741db835
Content: Print support app association - Windows drivers
Content Source: windows-driver-docs-pr/devapps/print-support-app-association.md
Product: windows-hardware
Technology: devapps
GitHub Login: @barrygolden
Microsoft Alias: bagold

@lapaz17 , thanks for reaching out to the Windows Driver Developer Documentation team.
Unfortunately, we are a small team and do not have the resources to provide technical support to individual driver developers.
You may have success posting your question in the following forum, where other driver developers and Microsoft engineers can be found.
Microsoft Q&A: Windows Hardware development


Tests failing on master

To help us save time and help you faster
Tests consistently fail locally and in CI , they have been failing in CI for quite some time. @ioolkos not sure if this is a known issue , if there is another open one feel free to close this one. Also if you have some clues or info about when this started happening, it will be great to help fix.
Environment

VerneMQ Version: master branch
OS: OSX, Ubuntu Linux
Erlang/OTP version (if building from source): 24.1 but fails on all version in Github Actions

Expected behaviour

CT tests fail locally and on CI

Actual behaviour

Run ./rebar3 ct, will notice failures like the following which seem to be an issue with clique?:

vmq_cluster_SUITE ==> {{badmatch,
     {badrpc,
         {'EXIT',
             {{badarity,
                  {#Fun<vmq_config_cli.11.101367952>,
                   [["shared_subscription_policy"],"random"]}},
              [{clique_config,run_callback,3,
                   [{file,
                        "/Users/codeadict/Hack/vernemq/_build/default/lib/clique/src/clique_config.erl"},
                    {line,268}]},
               {clique_config,'-run_callback/1-lc$^1/1-1-',4,
                   [{file,
                        "/Users/codeadict/Hack/vernemq/_build/default/lib/clique/src/clique_config.erl"},
                    {line,259}]},
               {clique_config,run_callback,1,
                   [{file,
                        "/Users/codeadict/Hack/vernemq/_build/default/lib/clique/src/clique_config.erl"},
                    {line,259}]},
               {clique_config,set,2,
                   [{file,
                        "/Users/codeadict/Hack/vernemq/_build/default/lib/clique/src/clique_config.erl"},
                    {line,142}]},
               {clique_command,run,1,
                   [{file,
                        "/Users/codeadict/Hack/vernemq/_build/default/lib/clique/src/clique_command.erl"},
                    {line,87}]},
               {vmq_server_cli,command,2,
                   [{file,
                        "/Users/codeadict/Hack/vernemq/apps/vmq_server/src/vmq_server_cli.erl"},
                    {line,41}]},
               {vmq_server_cmd,set_config,2,[]}]}}}},
 [{vmq_cluster_SUITE,'-set_shared_subs_policy/2-fun-0-',2,
      [{file,
           "/Users/codeadict/Hack/vernemq/apps/vmq_server/test/vmq_cluster_SUITE.erl"},
       {line,904}]},

@codeadict Thanks, the local failings look new to me. (not talking about the CI ones). But yes, I can reproduce the local ones; something we need to investigate.

:point_right: Thank you for supporting VerneMQ: https://github.com/sponsors/vernemq
:point_right: Using the binary VerneMQ packages commercially (.deb/.rpm/Docker) requires a paid subscription.

There must have been a breaking change in the commit history, related to the ETS-stored clique Callbacks.
(dev0@<IP_ADDRESS>)1> vmq_server_cmd:set_config(shared_subscription_policy, "prefer_local").
** exception error: vmq_config_cli:'-fun.register_config_callback/3-'/3 called with two arguments

:point_right: Thank you for supporting VerneMQ: https://github.com/sponsors/vernemq
:point_right: Using the binary VerneMQ packages commercially (.deb/.rpm/Docker) requires a paid subscription.

It's a little bit of a mess.
The reason is the updated clique dependency. The main differences are in clique_config.erl.
Old version, for which the internal VerneMQ API was built:
https://github.com/vernemq/clique/blob/rel_0.3.6-verne/src/clique_config.erl
The run_callback function works slightly differently in the currently locked (updated) clique dependency.

:point_right: Thank you for supporting VerneMQ: https://github.com/sponsors/vernemq
:point_right: Using the binary VerneMQ packages commercially (.deb/.rpm/Docker) requires a paid subscription.

I see now @ioolkos , i'll try fixing this before sending my formatting PR :)

@codeadict Awesome!
I tried a simple 2-arity callback in vmq_config_cli:
register_config_callback([StrKey], _) ->
    Key = list_to_existing_atom(StrKey),
    {ok, Val} = application:get_env(vmq_server, Key),
    vmq_config:set_env(vmq_server, Key, Val, false),
    vmq_config:configure_node().

Ultimately, the "set" will be handled by this clique command spec:
-define(SET_CMD_SPEC, {["_", "set"], '_', clique_config:config_flags(),
                       fun (_, SetArgs, SetFlags) ->
                               clique_config:set(SetArgs, SetFlags)
                       end}).

but somehow the clique printer trips over the [ok,ok,ok] below (no clue where it comes from):
(VerneMQ@<IP_ADDRESS>)55> MM = clique_config:do_set([{"shared_subscription_policy", "prefer_local"}]).
{'VerneMQ@<IP_ADDRESS>',[["shared_subscription_policy",32,115,
                       101,116,32,116,111,32,"\"prefer_local\""],
                      10,
                      [ok,ok,ok]]}

:point_right: Thank you for supporting VerneMQ: https://github.com/sponsors/vernemq
:point_right: Using the binary VerneMQ packages commercially (.deb/.rpm/Docker) requires a paid subscription.

The ok ok ok comes from each node the config is applied, this is the new behavior in clique, it run the callback in every node if -all is given to the command and returns the result for each node.

What's funny is that I did the tests on a single node, but apparently clique found 2 other Verne nodes running on my local machine (non clustered). Therefore [ok ok ok]. :)

:point_right: Thank you for supporting VerneMQ: https://github.com/sponsors/vernemq
:point_right: Using the binary VerneMQ packages commercially (.deb/.rpm/Docker) requires a paid subscription.


install dev dependencies as devDependencies

Thanks but this is intentional. You can search for past pull requests that did the same for rationale :-) Cheers!


Timestamp attribute

Add a clarification on builds timestamp attribute:

Great addition, @pzeballos!!
Sorry, I didn't see that you've already requested @plaindocs' review so I went ahead and tweaked your commit a little.  :sweat_smile:


Release crates

Description

stackable-certs:0.2.0
stackable-operator-derive:0.2.0
stackable-operator:0.66.0
stackable-webhook:0.2.0

Operator upgrade instructions
Prerequisites
These appear to have already been done as part of the post-release tasks

[x] operator-templating: bump the rust version in config/rust.yaml to 1.77 (https://github.com/stackabletech/operator-templating/pull/350)

[x] Generate the operator-templating PRs for all operators

[x] docker-images: bump rust version in ubi8-rust-builder/Dockerfile (https://github.com/stackabletech/docker-images/pull/601)
[ ] Create tags for each crate (after merge)

For each operator

[x] Merge the generated operator-templating PRs (with the hash: ded546b)
[ ] Fix the stackable-operator import tag in Cargo.toml (eg: 0.65.0 -> stackable-operator0.66.0)
[ ] Fix any of the other imports from the same repo based on their new tags (eg: stackable-certs0.2.0)

Definition of Done Checklist

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
Please make sure all these things are done and tick the boxes

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@Techassi, can you please suggest what the new tags should look like?
Considering how they will look in the downstream crates:
stackable-operator = { git = "https://github.com/stackabletech/operator-rs.git", tag = "stackable-operator0.66.0" }

Depending on your response, the examples in the PR description might need updating.

I would use stackable-<CRATE>-<VERSION>, because we already use the same format in stackable-cockpit (The tag looks like this: stackablectl-24.3.1)
Regarding how it will look in the downstream crates: This can be resolved as soon as we publish these crates on crates.io. The dependency would then look like this:
stackable-operator = "0.66.0"
stackable-certs = "0.2.0"


Nokogiri 1.8.4 installation challenges on macOS Mojave

If you're having trouble installing Nokogiri ...
Have you tried following [the installation tutorial][tutorial]?
yes
What is the output of gem install?
Building native extensions with: '--use-system-libraries --with-xslt-dir=/usr/local/opt/libxslt --with-xslt-dir=/usr/local/opt/libxml2'
This could take a while...
ERROR:  Error installing nokogiri:
	ERROR: Failed to build gem native extension.

    current directory: ~/.gem/ruby/2.5.1/gems/nokogiri-1.8.4/ext/nokogiri
~/.rubies/ruby-2.5.1/bin/ruby -r ./siteconf20180926-34637-1628dkt.rb extconf.rb --use-system-libraries --with-xslt-dir=/usr/local/opt/libxslt --with-xslt-dir=/usr/local/opt/libxml2
checking if the C compiler accepts ... yes
checking if the C compiler accepts -Wno-error=unused-command-line-argument-hard-error-in-future... no
Building nokogiri using system libraries.
ERROR: cannot discover where libxml2 is located on your system. please make sure `pkg-config` is installed.
*** extconf.rb failed ***
Could not create Makefile due to some reason, probably lack of necessary
libraries and/or headers.  Check the mkmf.log file for more details.  You may
need configuration options.

Provided configuration options:
	--with-opt-dir
	--without-opt-dir
	--with-opt-include
	--without-opt-include=${opt-dir}/include
	--with-opt-lib
	--without-opt-lib=${opt-dir}/lib
	--with-make-prog
	--without-make-prog
	--srcdir=.
	--curdir
	--ruby=~/.rubies/ruby-2.5.1/bin/$(RUBY_BASE_NAME)
	--help
	--clean
	--use-system-libraries=true
	--with-zlib-dir
	--without-zlib-dir
	--with-zlib-include
	--without-zlib-include=${zlib-dir}/include
	--with-zlib-lib
	--without-zlib-lib=${zlib-dir}/lib
	--with-xml2-dir
	--without-xml2-dir
	--with-xml2-include
	--without-xml2-include=${xml2-dir}/include
	--with-xml2-lib
	--without-xml2-lib=${xml2-dir}/lib
	--with-libxml-2.0-config
	--without-libxml-2.0-config
	--with-pkg-config
	--without-pkg-config
	--with-xslt-dir
	--with-xslt-include
	--without-xslt-include=${xslt-dir}/include
	--with-xslt-lib
	--without-xslt-lib=${xslt-dir}/lib
	--with-exslt-dir
	--without-exslt-dir
	--with-exslt-include
	--without-exslt-include=${exslt-dir}/include
	--with-exslt-lib
	--without-exslt-lib=${exslt-dir}/lib
	--with-libexslt-config
	--without-libexslt-config

To see why this extension failed to compile, please check the mkmf.log which can be found here:

  ~/.gem/ruby/2.5.1/extensions/x86_64-darwin-18/2.5.0-static/nokogiri-1.8.4/mkmf.log

extconf failed, exit code 1

Gem files will remain installed in ~/.gem/ruby/2.5.1/gems/nokogiri-1.8.4 for inspection.
Results logged to ~/.gem/ruby/2.5.1/extensions/x86_64-darwin-18/2.5.0-static/nokogiri-1.8.4/gem_make.out

What are the contents of the mkmf.log file?
"clang -o conftest -I~/.rubies/ruby-2.5.1/include/ruby-2.5.0/x86_64-darwin18 -I~/.rubies/ruby-2.5.1/include/ruby-2.5.0/ruby/backward -I~/.rubies/ruby-2.5.1/include/ruby-2.5.0 -I. -I~/.rubies/ruby-2.5.1/include  -D_XOPEN_SOURCE -D_DARWIN_C_SOURCE -D_DARWIN_UNLIMITED_SELECT -D_REENTRANT    -O3 -Wno-error=shorten-64-to-32  -pipe  conftest.c  -L. -L~/.rubies/ruby-2.5.1/lib -L. -L~/.rubies/ruby-2.5.1/lib  -fstack-protector -L/usr/local/lib     -lruby.2.5.1-static -framework Foundation  -lpthread -lgmp -ldl -lobjc  "
checked program was:
/* begin */
1: #include "ruby.h"
2:
3: int main(int argc, char **argv)
4: {
5:   return 0;
6: }
/* end */

"clang -I~/.rubies/ruby-2.5.1/include/ruby-2.5.0/x86_64-darwin18 -I~/.rubies/ruby-2.5.1/include/ruby-2.5.0/ruby/backward -I~/.rubies/ruby-2.5.1/include/ruby-2.5.0 -I. -I~/.rubies/ruby-2.5.1/include  -D_XOPEN_SOURCE -D_DARWIN_C_SOURCE -D_DARWIN_UNLIMITED_SELECT -D_REENTRANT    -O3 -Wno-error=shorten-64-to-32  -pipe    -Werror -c conftest.c"
checked program was:
/* begin */
1: #include "ruby.h"
2:
3: int main() {return 0;}
/* end */

"clang -I~/.rubies/ruby-2.5.1/include/ruby-2.5.0/x86_64-darwin18 -I~/.rubies/ruby-2.5.1/include/ruby-2.5.0/ruby/backward -I~/.rubies/ruby-2.5.1/include/ruby-2.5.0 -I. -I~/.rubies/ruby-2.5.1/include  -D_XOPEN_SOURCE -D_DARWIN_C_SOURCE -D_DARWIN_UNLIMITED_SELECT -D_REENTRANT    -O3 -Wno-error=shorten-64-to-32  -pipe  -Wno-error=unused-command-line-argument-hard-error-in-future   -Werror -c conftest.c"
error: unknown warning option '-Werror=unused-command-line-argument-hard-error-in-future'; did you mean '-Werror=unused-command-line-argument'? [-Werror,-Wunknown-warning-option]
checked program was:
/* begin */
1: #include "ruby.h"
2:
3: int main() {return 0;}
/* end */

"pkg-config --exists libxml-2.0"
| pkg-config --libs libxml-2.0
=> "-lxml2\n"
"clang -o conftest -I~/.rubies/ruby-2.5.1/include/ruby-2.5.0/x86_64-darwin18 -I~/.rubies/ruby-2.5.1/include/ruby-2.5.0/ruby/backward -I~/.rubies/ruby-2.5.1/include/ruby-2.5.0 -I. -I~/.rubies/ruby-2.5.1/include  -D_XOPEN_SOURCE -D_DARWIN_C_SOURCE -D_DARWIN_UNLIMITED_SELECT -D_REENTRANT    -O3 -Wno-error=shorten-64-to-32  -pipe  conftest.c  -L. -L~/.rubies/ruby-2.5.1/lib -L. -L~/.rubies/ruby-2.5.1/lib  -fstack-protector -L/usr/local/lib     -lruby.2.5.1-static -framework Foundation -lxml2 -lpthread -lgmp -ldl -lobjc  "
checked program was:
/* begin */
1: #include "ruby.h"
2:
3: int main(int argc, char **argv)
4: {
5:   return 0;
6: }
/* end */

| pkg-config --cflags-only-I libxml-2.0
=> "-I/usr/include/libxml2\n"
| pkg-config --cflags-only-other libxml-2.0
=> "\n"
| pkg-config --libs-only-l libxml-2.0
=> "-lxml2\n"
package configuration for libxml-2.0
cflags:
ldflags:
libs: -lxml2

"pkg-config --exists libexslt"
| pkg-config --libs libexslt
=> "-lexslt -lxslt -lxml2 -lz -lpthread -licucore -lm -lxml2\n"
"clang -o conftest -I~/.rubies/ruby-2.5.1/include/ruby-2.5.0/x86_64-darwin18 -I~/.rubies/ruby-2.5.1/include/ruby-2.5.0/ruby/backward -I~/.rubies/ruby-2.5.1/include/ruby-2.5.0 -I. -I/usr/include/libxml2 -I/usr/local/opt/libxml2/include -I~/.rubies/ruby-2.5.1/include  -D_XOPEN_SOURCE -D_DARWIN_C_SOURCE -D_DARWIN_UNLIMITED_SELECT -D_REENTRANT    -O3 -Wno-error=shorten-64-to-32  -pipe   conftest.c  -L. -L~/.rubies/ruby-2.5.1/lib -L/usr/local/opt/libxml2/lib -L. -L~/.rubies/ruby-2.5.1/lib  -fstack-protector -L/usr/local/lib      -lxml2 -lruby.2.5.1-static -framework Foundation -lexslt -lxslt -lxml2 -lz -lpthread -licucore -lm -lxml2 -lpthread -lgmp -ldl -lobjc  "
checked program was:
/* begin */
1: #include "ruby.h"
2:
3: int main(int argc, char **argv)
4: {
5:   return 0;
6: }
/* end */

| pkg-config --cflags-only-I libexslt
=> "-I/usr/include/libxml2\n"
| pkg-config --cflags-only-other libexslt
=> "\n"
| pkg-config --libs-only-l libexslt
=> "-lexslt -lxslt -lxml2 -lz -lpthread -licucore -lm -lxml2\n"
package configuration for libexslt
cflags:
ldflags:
libs: -lexslt -lxslt -lxml2 -lz -lpthread -licucore -lm -lxml2

"clang -E -I~/.rubies/ruby-2.5.1/include/ruby-2.5.0/x86_64-darwin18 -I~/.rubies/ruby-2.5.1/include/ruby-2.5.0/ruby/backward -I~/.rubies/ruby-2.5.1/include/ruby-2.5.0 -I. -I/usr/include/libxml2 -I/usr/include/libxml2 -I/usr/local/opt/libxml2/include -I~/.rubies/ruby-2.5.1/include  -D_XOPEN_SOURCE -D_DARWIN_C_SOURCE -D_DARWIN_UNLIMITED_SELECT -D_REENTRANT    -O3 -Wno-error=shorten-64-to-32  -pipe     conftest.c -o conftest.i"
conftest.c:3:10: fatal error: 'libxml/xmlversion.h' file not found
#include <libxml/xmlversion.h>
         ^~~~~~~~~~~~~~~~~~~~~
1 error generated.
checked program was:
/* begin */
1: #include "ruby.h"
2:
3: #include <libxml/xmlversion.h>
/* end */

What operating system are you using?
macOS 10.14 Mojave
I've tried to reinstall everything what I could but without any success. I used pkg-config, libxml2 and libxslt from Homebrew...

I was successful with gem install nokogiri -- --use-system-libraries=true --with-xml2-include="$(xcrun --show-sdk-path)"/usr/include/libxml2
But not with libxml2 from Homebrew.

I'm sorry y'all are having trouble.
If someone who is a Mac user would care to verify that this works and submit a PR to the installation tutorial, I would be very grateful. Alternatively, if there's something we can change in the extconf, I'd appreciate a PR.
Also tagging @zenspider as he's been kind enough to offer assistance on behalf of Mac users in the past.

@zenspider I put one of many iterations made by me here. The problem is still same if I just gem install nokogiri. It's not possible to install nokogiri without additional parameters.
You're right. There is a mistake in the command --with-xslt-dir=/usr/local/opt/libxml2' => --with-xml2-dir=/usr/local/opt/libxml2'`
But the result is the same. Installation of Nokogiri failed on Mojave.
Only this worked
gem install nokogiri -- --use-system-libraries=true --with-xml2-include="$(xcrun --show-sdk-path)"/usr/include/libxml2

I had this same problem. The fix? I needed to reinstall my xcode-select tools on Mojave.
In terminal, run: xcode-select --install, then you I was able to bundle install or gem install nokogiri and everything worked.

OK. I found the reason why it's happening on Mojave
See https://developer.apple.com/documentation/xcode_release_notes/xcode_10_release_notes#3035624
It's needed to make another step and install this:
/Library/Developer/CommandLineTools/Packages/macOS_SDK_headers_for_macOS_10.14.pkg

For explanation see the Xcode release notes

@deepj Thank you for following up on the thread. Would you be so kind as to submit a PR to this file that includes steps other Mojave users can follow?
https://github.com/sparklemotion/nokogiri.org-tutorials/blob/master/content/installing_nokogiri.md
I unfortunately don't have a Mac and so can't verify the steps that I might write up are correct. I'd really appreciate your help!

@flavorjones I'll do. But what I got from the Xcode release notes, it's needed to change for looking headers on macOS 10.14 and later. Can @zenspider help here? I don't have no insight how these compilation stuffs work.

I just hit this same problem on a machine upgraded to 10.14.

Updating command line tools for Xcode fixed this for me.
Command Line Tools for Xcode 10.14

Again, an open request for Mac users to help support the Ruby community: Can someone please submit a PR to the installation tutorial explaining how to update xcode tooling on 10.14?

I was successful with gem install nokogiri -- --use-system-libraries=true --with-xml2-include="$(xcrun --show-sdk-path)"/usr/include/libxml2
But not with libxml2 from Homebrew.

This actually worked for on Mojav Mac OS X

Once more, this time with gusto: can a Mac user on this issue please help support the Ruby community by submitting a PR to the installation tutorial explaining how to update xcode tooling on 10.14?

@flavorjones the xcode command line tools is updated via app store. @wsizoo note seems to be confusing here. Just read the xcode release notes https://developer.apple.com/documentation/xcode_release_notes/xcode_10_release_notes#3035624
My understanding is that nokogiri needs to change a way where is looking for the headers on Mojave 10.14 with new xcode command line tools 10.x. As Apple noted in the release notes they offer a temporary workaround to install the headers to the old place. This won’t be possible later. Apple recommends to change the place where looking for the headers to new one.
That is my understanding the situation.

I managed to install it by running:
xcode-select --install
sudo installer -pkg /Library/Developer/CommandLineTools/Packages/macOS_SDK_headers_for_macOS_10.14.pkg -target /

Followed by:
sudo mv /usr/local/include /usr/local/include_old

Happy to submit a doc update PR if this solution appears to help others.

@grega the problem with this, it won't work in the future. It's just a temporary solution offered by Apple. Just read this https://developer.apple.com/documentation/xcode_release_notes/xcode_10_release_notes#3035624

Ok, I better understand the underlying challenge, which is to look for header files and libraries in the right place with the new XCode SDK. Thanks for that.
This is still not something I'm personally equipped to handle, so I'd like to ask that someone who cares about Mac support help me either by submitting a PR or working with me to figure out what an appropriate solution looks like. I don't own a Mac, and and in addition this is something I'd expect someone from the community can help with or own entirely.

OK, maybe if I provide a bit more information on how I'd address this if I had access to a Mac running Mojave, somebody can verify that the approach would work.
extconf.rb is a pretty big file at this point, but if someone can find the section, at line 395, which hacks CFLAGS for OpenBSD, we can try something similar for Mojave:
if darwin?
  ENV['CFLAGS'] = "#{ENV['CFLAGS']} -I /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk"
end

Is anyone here able to try patching their extconf.rb in this manner and see if it addresses the underlying problem?

I was able to install Nokogiri on Mojave after running only xcode-select --install.

For people using homebrew the documentation around macOS and homebrew install helped me figure out the command bellow which worked for me:
gem install nokogiri -v '<IP_ADDRESS>' -- --use-system-libraries --with-iconv-dir=$(brew --prefix libiconv) --with-xml2-include=$(brew --prefix libxml2)/include/libxml2

@bbonamin you're probably talking about a clean install where there was no nokogiri in the past. I think half the people come here because it breaks after os or brew upgrade. Definitely was the case for me.

I managed to install it on 10.14 by running:
xcode-select --install
sudo installer -pkg /Library/Developer/CommandLineTools/Packages/macOS_SDK_headers_for_macOS_10.14.pkg -target /

Followed by:
sudo mv /usr/local/include /usr/local/include_old
gem install nokogiri

Happy to submit a doc update PR if this solution appears to help others.

I am so happy this solved my problem I've been trying to fix this for the past few days. Y'all need to fix these installation issues.

@kenkuts Did you happen to read any of my comments above where I'm trying to get someone to confirm that a one-line change in extconf.rb works?
Once again: any Mac users arriving at this issue, STOP trying to hack it.  Read this comment above:
https://github.com/sparklemotion/nokogiri/issues/1801#issuecomment-438526682
Please clone the repository, make this small change to extconf.rb, run rake compile and respond if it completes successfully with the change, and fails without the change.
I'm about to cut v1.9.0 and to date nobody who is using a Mac has been able to tell me if that fix works, and so it's not going to be in this release. It won't be in a release until someone can confirm that it works.
Snarky comments will not get the job done; testing a suggested fix will.

@flavorjones I finally got working macOS in VirtualBox. I've tried to install the latest nokogiri 1.9.0
It was successful.
I could install only macOS Mojave 10.4.0 not 10.4.1 or 10.4.2
Here my steps what I made on the freshly installed macOS

Install Homebrew (this installs Command Line Tools)
/usr/bin/ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)"
Install Ruby 2.5.3
brew install ruby
Add Ruby into PATH
echo 'export PATH="/usr/local/opt/ruby/bin:$PATH"' >> ~/.bash_profile
"Restart" bash
source  ~/.bash_profile
Install nokogiri
gem install nokogiri

Here is the result (sorry for pixalated screenshot but there is no way to copy out it from VM)

Here is brew config

@flavorjones I guess, nokogiri 1.9.0 seems to be OK by default CTL installation. If someone else confirms this as well, we can close this issue

In my case, the problem was more related to https://stackoverflow.com/questions/14607193/installing-gem-or-updating-rubygems-fails-with-permissions-error
Basically, when I run the bundle install command it wasn't able to "understand" that I had rbenv
Once I make sure that after run which gem I got /Users/justin/.rbenv/shims/gem everything runs smoothly

Updating to the latest version of Nokogiri 1.9.0 solved the problem for me
git install nokogiri

OK, maybe if I provide a bit more information on how I'd address this if I had access to a Mac running Mojave, somebody can verify that the approach would work.
extconf.rb is a pretty big file at this point, but if someone can find the section, at line 395, which hacks CFLAGS for OpenBSD, we can try something similar for Mojave:
if darwin?
  ENV['CFLAGS'] = "#{ENV['CFLAGS']} -I /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk"
end

Is anyone here able to try patching their extconf.rb in this manner and see if it addresses the underlying problem?

Hey @flavorjones , this seems to work for me (I used ENV['CFLAGS'] = "#{ENV['CFLAGS']} -I /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk" instead though because that's where my SDK is). However, it also seems to compile successfully without this change. I'm using macOS Mojave 10.14.2 Beta (18C52a) with Xcode 10.1 (10B61). Please let me know if you'd like me to try anything else. One note though, I do seem to have problems when installing nokogiri if it's in a Gemfile and I run bundle install.

I was successful with gem install nokogiri -- --use-system-libraries=true --with-xml2-include="$(xcrun --show-sdk-path)"/usr/include/libxml2
But not with libxml2 from Homebrew.

This worked for me. Tried almost all the suggestions available on google, stackoverflow, github but failed. This is like life saver for me.

@deepj Thanks for your reply -- there's a lot of noise in this thread and you're providing some clarity.
Can you provide your mkmf.log file from a failed bundle exec compile in which you had the suggested patch applied and you saw the "cannot discover where libxml2 is located on your system" error message? It would also be helpful to provide all of the commands you're running so I have that context as well.

@flavorjones Hello, I'll look at it this weekend and then I let you know. I'm sorry for the late answer, holidays here.

I've merged #1851 into master. I'm considering cutting a v1.10.1 release with this change. Will leave this open until a version is shipped.

I had the error for a specific version <IP_ADDRESS> this solved for me -> gem install nokogiri -v '<IP_ADDRESS>' -- --use-system-libraries=true --with-xml2-include="$(xcrun --show-sdk-path)"/usr/include/libxml2


Not submitted program/application by a client is displayed as "Submitted" on the TI login dashboard.

Describe the bug
An application/program which is not yet submitted for a client is showed as application submitted on Trusted Intermediary dashboard against the client's name.
To Reproduce
Steps to reproduce the behavior:

Login as Trusted Intermediary
Click on 'View Applications' against any client.
On the Dashboard, Click on "View and Apply" on any of the available programs.
In the midst of submitting the application, perform any action (Select new client or Logout)
On the TI dashboard, verify the application submitted row for that particular client.
Now click on 'View Applications' again on client, on the Program box it shows as Not yet submitted.

Expected behavior
The Application status on the program box and TI dashboard should match.
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: iOS
Browser: Chrome

@plabanTest1 can you confirm if this is happening when the NORTH_STAR_APPLICANT_UI flag is both turned on and turned off or just with it turned on? Thank you!

With the flag turned OFF, it is working as expected. The issue seems to be with flag turned ON.

With the flag turned OFF, it is working as expected. The issue seems to be with flag turned ON.

Great, thank you so much for confirming! I added the label "[Epic] Northstar Applicant UI" - for any future northstar-specific issues you find, please add that label. Great find!


*_Decorated classes do no match instance of original class, tasks.withType broken.

Expected Behavior
"*_Decorated" classes of created tasks (by some plugin) should be caught by instanceof and project.tasks.withType(...) in particular.
Current Behavior
..they are not caught and empty result is returned when I call project.tasks.withType("my.desired.class")
Context
I can't use tasks.withType, even though I see those tasks are in a taskContainer when I print it on the screen. I also checked the type and it's "my.desired.class_Decorated".
Steps to Reproduce
plugins {
  id "org.scoverage" version "7.0.0" apply false
}

allprojects {
  apply plugin: "org.scoverage"
  scoverage {
    scoverageVersion = "1.4.10"
  }
}

subprojects {
  afterEvaluate {
      def reportTasks = project.tasks.withType(org.scoverage.ScoverageReport)
      println(reportTasks)
  }
}

Your Environment
Gradle 7.2
scala 2.12.15

If _Decorated tasks weren't matched, then basically Gradle wouldn't work at all, so I doubt this is the problem. My educated guess would be that you expect all tasks to be eagerly created, when they are lazy.
e.g if you do:
tasks.register("foo", Foo) { ... }
tasks.withType(Foo).configureEach {
    println "hello"
}

then nothing would print, because  the Foo task won't be realized (that's configuration avoidance). Note the same thing without the .configureEach would force realization, but you must avoid this at all costs.

I run in to exactly this problem today using Gradle 8.1.1
My code looks like
project.gradle.projectsEvaluated {
  project.rootProject.subprojects.each { p ->
     anotherTask.dependsOn ( p.tasks.withType(MyTask ) )
  }
}

In debugger I can see that p.taskContainer contains MyTask_Decorated.
But running p.tasks.withType(MyTask) return nothing.
My workaround is to instead use
project.gradle.projectsEvaluated {
   project.rootProject.subprojects { p ->
      if(p.pluginManager.hasPlugin('myTaskPlugin')) {
          anotherTask.dependsOn(p.tasks.named('myTask').get())
      }
  }
}

Any plans on fixing this?

Any updates?
In an Android project I want to modify certain task in a gradle script and then apply it from project level gradle file; however, I encountered the same issue.
My script like this:
tasks.configureEach { Task task ->
    if (task.name.contains("NativeLibs")) {
        println("class: ${task.class}")
        println("superClass: ${task.class.getSuperclass()}")
        println("superClass isAssignableFrom task: ${task.class.getSuperclass().isAssignableFrom(task.class)}")
        println("MergeNativeLibsTask isAssignableFrom task: ${MergeNativeLibsTask.class.isAssignableFrom(task.class)}")
        println("task isinstanceof MergeNativeLibsTask: ${task instanceof MergeNativeLibsTask}")

        println("whether superClass and MergeNativeLibsTask have the same name: ${task.class.getSuperclass().name == MergeNativeLibsTask.class.name}")
        println("whether class and MergeNativeLibsTask have the same classloader: ${(task.class.classLoader == MergeNativeLibsTask.classLoader)}")
        println("whether class and MergeNativeLibsTask have the same parent classloader: ${(task.class.classLoader.parent == MergeNativeLibsTask.classLoader.parent)}")
    }
}

And the output is as follow:
class: class com.android.build.gradle.internal.tasks.MergeNativeLibsTask_Decorated
superClass: class com.android.build.gradle.internal.tasks.MergeNativeLibsTask
superClass isAssignableFrom task: true
MergeNativeLibsTask isAssignableFrom task: false
task isinstanceof MergeNativeLibsTask: false
whether superClass and MergeNativeLibsTask have the same name: true
whether class and MergeNativeLibsTask have the same classloader: false
whether class and MergeNativeLibsTask have the same parent classloader: true

It seems that my problem is caused by different classloaders?
My Environment
Gradle 6.7.1
AGP 4.1.0

This affects Extensions as well.
For example following line: https://github.com/jk1/Gradle-License-Report/blob/master/src/main/groovy/com/github/jk1/license/LicenseReportPlugin.groovy#L35 creates an extension.
When I try to access the extension via project.extensions.configure(LicenseReportExtension::class.java) { ... }, it trows
java.lang.NoClassDefFoundError: com/github/jk1/license/LicenseReportExtension.
And project.extensions.findByName("licenseReport") returns an extension of type com.github.jk1.license.LicenseReportExtension_Decorated
Gradle v8.6

@little-fish same here!
While using compileOnly(kotlin("gradle-plugin")) as a lazy dependency, and trying to access KotlinMultiplatformExtension from the dependency during runtime, I am faced with an error:
java.lang.NoClassDefFoundError: org/jetbrains/kotlin/gradle/dsl/KotlinMultiplatformExtension
And while printing the class of actual extension, I see that it is decorated as KotlinMultiplatformExtension_Decorated, as well as other extensions including android's com.android.build.gradle.LibraryExtension

I have the same issue, and seems this related to the external script.
For example I use it on android project and have following situation:
In build.gradle it works as expected:
android.applicationVariants.configureEach { variant ->
    String variantName = variant.name.capitalize()

    if (variantName.contains("Release") && !variantName.contains("NonMinified")) {
        tasks.named("minify${variantName}WithR8").configure { r8Task ->
            logger.lifecycle("configure r8Task by name") // works
        }
    }

    tasks.withType(com.android.build.gradle.internal.tasks.R8Task.class).configureEach { r8Task ->
        logger.lifecycle("configure r8Task by type") // works
    }
}

But if you move the same code into separated file it stops working:
build.gradle:
apply from: "../../gradle-plugins/separated.gradle"

separated.gradle:
buildscript {
    repositories {
            google()
            mavenCentral()
    }
    dependencies {
        classpath libs.android.gradle
    }
}

android.applicationVariants.configureEach { variant ->
    String variantName = variant.name.capitalize()

    if (variantName.contains("Release") && !variantName.contains("NonMinified")) {
        tasks.named("minify${variantName}WithR8").configure { r8Task ->
            logger.lifecycle("configure r8Task by name") // works
        }
    }

    tasks.withType(com.android.build.gradle.internal.tasks.R8Task.class).configureEach { r8Task ->
        logger.lifecycle("configure r8Task by type") // does not work
    }
}

Is this some kind of limitation for external scripts?


fix: call and estimateGas nonce check failure

Fixes #500

Coverage increased (+0.04%) to 82.139% when pulling eaaa2865d4000383ed76d95f7d734f551ca598f9 on fix/eth_callNonceCheck into 8836520da717b80ccfb8db2186700094288c732f on develop.


Technical error - Coding Challenge 3, Tutorial 3

Regarding Coding Challenge 3, Tutorial 3
I seem to be getting an error that says:
Status: FAILED!
Check: 1
Test: Create a style rule for the section element with the id container that sets the width of the element to 900 pixels and the height to 370 pixels.
Reason: Assertion failed: The height of the section is not set to 370px, expected 370px but found 355px
Error : AssertionError - The height of the section is not set to 370px, expected 370px but found 355px
I am not sure why it is saying this or if anyone else is having this issue, but as you can see in the attached screensnip I already have the Height set to 370px.
Version: 1.94.2
Commit: 384ff7382de624fb94dbaf6da11977bba1ecd427
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
Embedder: codespaces

/question please use your course support channel.


Drop support for Python 3.7

Drop support for Python 3.7, and remove it from the tox and CI/CD configurations.
Upgrade mypy to avoid https://github.com/python/mypy/issues/13499, and add checks for 'None' to account for newly reported errors.

The required 3.7 run will need to be removed in the branch protection rules; instead we can add 3.11.


Can't auth after cvat update

My actions before raising this issue

[x] Read/searched the docs
[x] Searched past issues

I have updated CVAT instances with: git pull, edit docker-compose.yml for my setup and docker-compose up
And now I can't login to the system
in docker logs:
cvat          | 2021-02-16 16:47:39,647 DEBG 'runserver' stderr output:
cvat          | [Tue Feb 16 16:47:39.647044 2021] [wsgi:error] [pid 453:tid<PHONE_NUMBER>52864] [remote <IP_ADDRESS>:48430] [2021-02-16 16:47:39,646] WARNING django.request: Bad Request: /api/v1/auth/login
cvat          |
cvat          | 2021-02-16 16:47:39,647 DEBG 'runserver' stderr output:
cvat          | [Tue Feb 16 16:47:39.647129 2021] [wsgi:error] [pid 453:tid<PHONE_NUMBER>52864] [remote <IP_ADDRESS>:48430] WARNING - 2021-02-16 16:47:39,646 - log - Bad Request: /api/v1/auth/login

in CVAT UI:
Could not login on the server
Error: Request failed with status code 400. {"non_field_errors":["Unable to log in with provided credentials."]}.

You can try creating one more superuser account with python manage.py createsuperuser  (see. installation guide) to access all your data. Then using admin panel you can change password for the previous user and login.


Revert "Revert to traceGroup from traceGroupFields (#37)"

This reverts commit c84ecb4f3d429e75d923a54dbcf8462642b5402c.
Issue #, if available:

#27

Description of changes:

revert to use traceGroupFields.xxx and traceGroup (which is trace group name)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Though not in scope of the revert - would it be possible to update some of the test data documents to not contain traceGroupFields to test data emitted by v0.8.0 of Data Prepper? As new fields are added and schema minor versions are incremented, it'd be good for the test suite to cover the range of possible minor versions.
Even though the introduction of traceGroupFields happened in the bump from 0.8.0 to 1.0.0, this was more like a minor version change. I know we're just now starting to formalize schema versioning, going forward these changes will be well documented in the Data Prepper repo.

Good point, added some data that doesn't have fields denormalized into cypress test


UI Kit UX improvements

WHY are these changes introduced?
We'd like to make some UX improvements to UI kit.
WHAT is this pull request doing?
This PR packs the following improvements:

Paths are now rendered with italics

Added table example to kitchen sink and renamed banners sub-command to static

renderConfirmationPrompts will now allow users to to submit answers just by pressing the shortcut, without also having to press enter.

How to test your changes?

Post-release steps

Measuring impact
How do we know this change was effective? Please choose one:

[x] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
[ ] Existing analytics will cater for this addition
[ ] PR includes analytics changes to measure impact

Checklist

[x] I've considered possible cross-platform impacts (Mac, Linux, Windows)
[x] I've considered possible documentation changes
[x] I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

cc @MeredithCastile


Fix warnings in Jumbling logic

Problem description:
Following warning messages appear
"WARNING: unrecognized node type: 925"
"WARNING: unrecognized node type: 924"
if 'pg_stat_statements' extension is enabled and a query containing GROUP BY
clause or GROUPING function is executed.
Expected correct behavior - no warning or error messages during the query
execution.
Cause:
In JumbleExpr, called from JumbleQuery, there is no handling for node tags
T_GroupingClause and T_GroupingFunc.
Fix:
Added handling logic for missed node tags.
According to comments in queryjumble.c, main guideline how to handle
query tree is: "Rule of thumb for what to include is that we should ignore
anything not semantically significant (such as alias names) as well as
anything that can be deduced from child nodes (else we'd just be double-
hashing that piece of information)."
For T_GroupingFunc we append to the jumble the tag itself and a list of
arguments. Field 'ngrpcols' is not appended to the jumble, because it can be
deduced from the list of groupsets in grouping clause. 'ngrpcols' is the
number of unique grouping attributes in grouping clause. Equivalent queries
must have the same groupsets in grouping clause. Thus they will have the same
'ngrpcols'. So, adding 'ngrpcols' to jumble is redundant.
Plus added handling for the T_Integer tag, because it is required to parse
the list of arguments.
For T_GroupingClause we append to the jumble the tag itself, grouping type
and list of groupsets. Field 'location' is not appended to the jumble because
it is the textual location from parser and is not semantically significant.
After this change, no warning messages appear.

Allure report https://allure-ee.adsw.io/launch/60788

Failed job Resource group isolation tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/909714

Failed job Resource group isolation tests on ppc64le: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/909715

Allure report https://allure-ee.adsw.io/launch/60873

Failed job Resource group isolation tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/915047

Failed job Resource group isolation tests on ppc64le: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/915048

Allure report https://allure-ee.adsw.io/launch/60887

Failed job Resource group isolation tests on ppc64le: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/915839

Failed job Behave tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/917776

Failed job Behave tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/920047

Allure report https://allure-ee.adsw.io/launch/61084

Failed job Resource group isolation tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/928426

Failed job Resource group isolation tests on ppc64le: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/928427

Failed job Regression tests with ORCA on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/928417

Failed job Regression tests with ORCA on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/928525

Can you provide a test not only to check for the absence of warnings, but also that the query text in pg_stat_statements differs with and without a patch (if possible). To check the correctness of the logic implementation.

it seems to me that the problem is more that queryId is calculated incorrectly (for example, the group by type is not taken into account). it is worth mentioning this as a problem in the description and testing it.

Allure report https://allure-ee.adsw.io/launch/61416

Failed job Resource group isolation tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/949680

Failed job Resource group isolation tests on ppc64le: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/949681

Can you provide a test not only to check for the absence of warnings, but also that the query text in pg_stat_statements differs with and without a patch (if possible). To check the correctness of the logic implementation.

Test was updated.

it seems to me that the problem is more that queryId is calculated incorrectly (for example, the group by type is not taken into account). it is worth mentioning this as a problem in the description and testing it.

Description and test were updated to reflect this aspect.

does the added test run during regression tests? I can't find it in the logs.

Allure report https://allure-ee.adsw.io/launch/61432

Failed job Resource group isolation tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/950363

does the added test run during regression tests? I can't find it in the logs.

Indeed, looks like the test is not executed automatically. Will fix it.

Allure report https://allure-ee.adsw.io/launch/61438

Failed job Resource group isolation tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/950782

Failed job Resource group isolation tests on ppc64le: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/950783

Allure report https://allure-ee.adsw.io/launch/61485

Failed job Resource group isolation tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/953352

Failed job Resource group isolation tests on ppc64le: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/953353

Failed job Deploy multiarch Dockerimages: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/955119

Failed job Resource group isolation tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/955129

Failed job Resource group isolation tests on ppc64le: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/955130

Allure report https://allure-ee.adsw.io/launch/61797

Failed job Resource group isolation tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/967112

Failed job Behave tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/967110

Allure report https://allure-ee.adsw.io/launch/62084

Failed job Resource group isolation tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/979606

Failed job Resource group isolation tests on ppc64le: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/979608

Allure report https://allure-ee.adsw.io/launch/62087

Failed job Resource group isolation tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/979746

Failed job Resource group isolation tests on ppc64le: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/979747

Allure report https://allure-ee.adsw.io/launch/62194

Failed job Resource group isolation tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/984402

Failed job Resource group isolation tests on ppc64le: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/984403

Failed job Regression tests with ORCA on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/984396

Failed job Regression tests with ORCA on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/986170

Allure report https://allure-ee.adsw.io/launch/62293

Failed job Resource group isolation tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/988007

Failed job Resource group isolation tests on ppc64le: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/988008

Allure report https://allure-ee.adsw.io/launch/62408

Failed job Resource group isolation tests on ppc64le: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/992651

Failed job Behave tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/992648

Allure report https://allure-ee.adsw.io/launch/62478

Failed job Resource group isolation tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/996082

Failed job Resource group isolation tests on ppc64le: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/996083

Failed job Regression tests with ORCA on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/996076

Failed job Behave tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/996080


Hide step in stepper

I am trying to find out the solution to hide step in stepper on the basis of user input for other field using hide expression. But when user unhides it looses the control of the route. I wonder if this is supported by formly or if there is any way around this problem?

Hi,
The question is not clear, could you please provide an example using the following stackblitz starter example:
https://stackblitz.com/edit/ngx-formly-ui-bootstrap
Thanks!


Query search in a time slot always return same group of tweets

When I try to search tweets in a certain topic in a given time slot, it always returns the same group of tweets no matter what the 'maxtweets' is. I am wondering if anyone has the same issue.
For example, when I use the follow command to search, it always return the same 20 tweets over and over, and it is also different from the twitter advanced search page.
python Exporter.py --querysearch 'europe refugees' --since 2016-10-13 --until 2016-10-17 --maxtweets 100
Thanks for your code! @Jefferson-Henrique

Duplicate. Original issue is https://github.com/Jefferson-Henrique/GetOldTweets-python/issues/217

Thanks! @Mottl


Auto switch audio device

Hi, is there a way to not have the output of an audio device automatically selected as soon as it is replaced?
Like I select "AirPods Pro" and he changed to the equalized version "AirPods Pro eqMac"
Thanks

Hi, this is necessary because this is how we capture audio. We currently need to set the system output to our virtual device to get the audio for processing. We plan to change this in the future, and not require a virtual device. But this would take a long time, since there is a lot of code that has to be rewritten. I would close this issue for now, but feel free to comment on any thing related to this.


fixed version fetch

Signed-off-by: Rodrigo Passos<EMAIL_ADDRESS>

Closing as this was rolled into 2.0.


How to keep track of technical requirements / feature requests / general ideas parking lot?

Discussions with the data science team have continued and they're yielding some excellent insights and feature requests about how to process patient information. Want to figure out the best way to log them in git -- either a wiki page, separate git issues, or a unified issue backlog.

I have started to push people to create issues for this kinda stuff. Closing.


Docker agents launch issue

Getting the following error when running docker agents:
DOCKER_AGENT_AGENT_CLASS=a.docker.pommerman.simple_agent.agent.Agent \
python games/run_battle.py \
    --agents="random::null,random::null,random::null,docker::pommerman/test-agent"

Starting container...
Traceback (most recent call last):
File "/usr/local/lib/python3.6/runpy.py", line 183, in _run_module_as_main
mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
File "/usr/local/lib/python3.6/runpy.py", line 109, in _get_module_details
import(pkg_name)
File "/app/games/a/init.py", line 1, in
from . import agents
File "/app/games/a/agents.py", line 9, in
from tensorforce.agents import PPOAgent
ModuleNotFoundError: No module named 'tensorforce'
Starting the Game.
/home/az/git_repos/ml/rl/playground/bomberman_proj/lib/python3.6/site-packages/scipy/misc/pilutil.py:480: FutureWarning: Conversion of the second argument of issubdtype from int to np.signedinteger is deprecated. In future, it will be treated as np.int64 == np.dtype(int).type.
if issubdtype(ts, int):
/home/az/git_repos/ml/rl/playground/bomberman_proj/lib/python3.6/site-packages/scipy/misc/pilutil.py:483: FutureWarning: Conversion of the second argument of issubdtype from float to np.floating is deprecated. In future, it will be treated as np.float64 == np.dtype(float).type.
elif issubdtype(type(size), float):
localhost
1003
Traceback (most recent call last):
File "/home/az/git_repos/ml/rl/playground/bomberman_proj/lib/python3.6/site-packages/urllib3/connection.py", line 143, in _new_conn
(self.host, self.port), self.timeout, **extra_kw)
File "/home/az/git_repos/ml/rl/playground/bomberman_proj/lib/python3.6/site-packages/urllib3/util/connection.py", line 83, in create_connection
raise err
File "/home/az/git_repos/ml/rl/playground/bomberman_proj/lib/python3.6/site-packages/urllib3/util/connection.py", line 73, in create_connection
sock.connect(sa)
ConnectionRefusedError: [Errno 111] Connection refused
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/az/git_repos/ml/rl/playground/bomberman_proj/lib/python3.6/site-packages/urllib3/connectionpool.py", line 601, in urlopen
chunked=chunked)
File "/home/az/git_repos/ml/rl/playground/bomberman_proj/lib/python3.6/site-packages/urllib3/connectionpool.py", line 357, in _make_request
conn.request(method, url, **httplib_request_kw)
File "/home/az/anaconda3/lib/python3.6/http/client.py", line 1239, in request
self._send_request(method, url, body, headers, encode_chunked)
File "/home/az/anaconda3/lib/python3.6/http/client.py", line 1285, in _send_request
self.endheaders(body, encode_chunked=encode_chunked)
File "/home/az/anaconda3/lib/python3.6/http/client.py", line 1234, in endheaders
self._send_output(message_body, encode_chunked=encode_chunked)
File "/home/az/anaconda3/lib/python3.6/http/client.py", line 1026, in _send_output
self.send(msg)
File "/home/az/anaconda3/lib/python3.6/http/client.py", line 964, in send
self.connect()
File "/home/az/git_repos/ml/rl/playground/bomberman_proj/lib/python3.6/site-packages/urllib3/connection.py", line 168, in connect
conn = self._new_conn()
File "/home/az/git_repos/ml/rl/playground/bomberman_proj/lib/python3.6/site-packages/urllib3/connection.py", line 152, in _new_conn
self, "Failed to establish a new connection: %s" % e)
urllib3.exceptions.NewConnectionError: <urllib3.connection.HTTPConnection object at 0x7f35c4335080>: Failed to establish a new connection: [Errno 111] Connection refused
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/az/git_repos/ml/rl/playground/bomberman_proj/lib/python3.6/site-packages/requests/adapters.py", line 440, in send
timeout=timeout
File "/home/az/git_repos/ml/rl/playground/bomberman_proj/lib/python3.6/site-packages/urllib3/connectionpool.py", line 639, in urlopen
_stacktrace=sys.exc_info()[2])
File "/home/az/git_repos/ml/rl/playground/bomberman_proj/lib/python3.6/site-packages/urllib3/util/retry.py", line 388, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPConnectionPool(host='localhost', port=1003): Max retries exceeded with url: /action (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f35c4335080>: Failed to establish a new connection: [Errno 111] Connection refused',))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "games/run_battle.py", line 96, in
actions = env.act(obs)
File "/home/az/git_repos/ml/rl/playground/games/a/pommerman/envs/v0.py", line 94, in act
action = agent.act(obs[agent.agent_id], action_space=self.action_space)
File "/home/az/git_repos/ml/rl/playground/games/a/agents.py", line 90, in act
"action_space": pickle.dumps(action_space, protocol=0).decode("utf-8")
File "/home/az/git_repos/ml/rl/playground/bomberman_proj/lib/python3.6/site-packages/requests/api.py", line 112, in post
return request('post', url, data=data, json=json, **kwargs)
File "/home/az/git_repos/ml/rl/playground/bomberman_proj/lib/python3.6/site-packages/requests/api.py", line 58, in request
return session.request(method=method, url=url, **kwargs)
File "/home/az/git_repos/ml/rl/playground/bomberman_proj/lib/python3.6/site-packages/requests/sessions.py", line 508, in request
resp = self.send(prep, **send_kwargs)
File "/home/az/git_repos/ml/rl/playground/bomberman_proj/lib/python3.6/site-packages/requests/sessions.py", line 618, in send
r = adapter.send(request, **kwargs)
File "/home/az/git_repos/ml/rl/playground/bomberman_proj/lib/python3.6/site-packages/requests/adapters.py", line 508, in send
raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPConnectionPool(host='localhost', port=1003): Max retries exceeded with url: /action (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f35c4335080>: Failed to establish a new connection: [Errno 111] Connection refused',))
Stopping container..
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
File "/home/az/git_repos/ml/rl/playground/bomberman_proj/lib/python3.6/site-packages/docker/api/client.py", line 222, in _raise_for_status
response.raise_for_status()
File "/home/az/git_repos/ml/rl/playground/bomberman_proj/lib/python3.6/site-packages/requests/models.py", line 935, in raise_for_status
raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 404 Client Error: Not Found for url: http+docker://localunixsocket/v1.30/containers/173409928b662f09dba9af5d7cc9a031eecd08645548ed1366d2e6b66be7627e?v=False&link=False&force=True
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/az/git_repos/ml/rl/playground/bomberman_proj/lib/python3.6/site-packages/docker/api/client.py", line 224, in _raise_for_status
raise create_api_error_from_http_exception(e)
File "/home/az/git_repos/ml/rl/playground/bomberman_proj/lib/python3.6/site-packages/docker/errors.py", line 31, in create_api_error_from_http_exception
raise cls(e, response=response, explanation=explanation)
docker.errors.NotFound: 404 Client Error: Not Found ("No such container: 173409928b662f09dba9af5d7cc9a031eecd08645548ed1366d2e6b66be7627e")

works fine if I just run:
DOCKER_AGENT_AGENT_CLASS=a.docker.pommerman.simple_agent.agent.Agent python games/run_battle.py

Yes I did, using:
docker build -t pommerman/test-agent . -f games/a/docker/Dockerfile

Can you try now following the updated (and quick) README for docker: https://github.com/MultiAgentLearning/playground/tree/master/games/a/docker

Yes, working fine now.


Prepare master for next version

Prepare master for next version:

Clean accepted API changes
Update version to 8.7
Clean release notes and welcome message for 8.7
Update library versions in build init to latest for 8.7
Update released version to latest snapshot

@bot-gradle test and merge

I've triggered a build for you. Click here to see all failures if there's any.

Pre-tested commit build failed. Click here to see all build failures.

@bot-gradle merge

I've triggered a build for you. Click here to see all failures if there's any.

Pre-tested commit build failed. Click here to see all build failures.

@bot-gradle merge

I've triggered a build for you. Click here to see all failures if there's any.

Pre-tested commit build failed. Click here to see all build failures.

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

I have squashed this PR as 9e75105b9e9430afb7142486e036bb7b21390878

Your PR is queued. See the queue page for details.

I've triggered a build for you. Click here to see all failures if there's any.


Add Fos77's file

created a branch, created a file, made a commit, opened a pull request

trying this in learning course


Allow spells by name

Follow up #32

[ ] !Ignifaxius@12 => !MU,KL,CH@12 => !10,14,12@12

The HEROKU_POSTGRESQL_COBALT_URL DB now has a table "zaubersprüche", "rituale" and "magische handlungen" with column "titel" (name of the talent) and "probe". This is probably helpful for matching. (see branch regelwiki for the exact column definition)


Integrate Api Check

Api Check can be integrated into our build to help avoid unintentional breaking changes between releases. The tool and the process to add exceptions is described at https://github.com/aspnet/BuildTools/wiki/Api-Check.
An example of a baseline Initial baselines have been checked in at https://github.com/aspnet/EntityFramework/tree/javiercn/breaking-changes (although they may need updating).
cc @javiercn

Last time we talked about checking in a modified baseline every time we make changes instead of checking in the list of exceptions.
The problem with that approach is that Api-Check generates a JSON representation of the whole public surface, therefore any time we make any breaking or non-breaking change (e.g. any time we add any new public API) to the public surface we would have a huge file to diff.
The exceptions file on the other hand only requires changes when there is an intentional breaking change, which should be less often and a much smaller file.
Clearing up milestone to re-discuss.

@smitpatel talk to @javiercn

Any update on this? We should get this integrated to we can keep an eye on breaking changes... We'll certainly have some breaking changes for 2.0 but we want to make sure they're all intentional, which this tool will help catch.

@Eilon yes, we are making progress. @smitpatel already started on it and now needs to talk to @javiercn about some issues.

@divega @Eilon - Does this tool need to run on Specification tests?

@smitpatel I think the answer is no. My reasoning is that we are not committed to avoid breaking changes in the spec test but rather to communicate them to provider writers as needed.

Yeah I agree with this.


Update the sender of the email

The email that we sent is currently from "example.com". It should come from<EMAIL_ADDRESS>

Hey team! Please add your planning poker estimate with Zenhub @carolyncole @hectorcorrea @JaymeeH @leefaisonr @kelynch

Please add your planning poker estimate with Zenhub @jrgriffiniii


You can move pieces when the countdown is shown.

This seems like a touch only problem. Touches aren't disabled.


Users should be able to register for a new profile

During onboarding flow when the user first logs in

Closed via #62


prestate tracers excludes accessed accounts for reverted transactions

ref https://github.com/paradigmxyz/reth/issues/9455
this is because:
https://github.com/paradigmxyz/evm-inspectors/blob/b9850ffe4d67aadc46cba5e3798bee459a01a560/src/tracing/builder/geth.rs#L211-L212
some sample (failed) transactions that are different in https://github.com/paradigmxyz/reth/issues/9455
https://etherscan.io/tx/0x4bef128f2f891751fd69bbcd9a3bd54976bc24b8272207d0c5ce991839b36cd2
https://etherscan.io/tx/0x8711a82e13a02bc97dbe28ddb815e8392bbbb73a6ff76c51ece4135bf037ff76
https://etherscan.io/tx/0x7cab92729136baf6c13e1f77881abc471bc435d04a30e1eefff6200d3ff83fd7
https://etherscan.io/tx/0xb81f85bdf6eb6fc812b8be5f12fc10fff90d92a7562aa5352780ad9412fcf458

this is no longer the case with https://github.com/bluealloy/revm/commit/9955d9faa5ca4cefc30bde3eb37ba11af7ef474d


Add support for Log4j API and SLF4J

The logging backends supported by the default LogFactoryImpl have all reached their end-of-life (except JUL and SimpleLog). Third-generation logging backends, such as Log4j Core, support multiple logger contexts per application and therefore can not be handled by the simplified caching mechanism in LogFactoryImpl.
This PR introduces two new LogFactory implementations, Log4j2LogFactory and Slf4jLogFactory, that forward messages to the Log4j API and SLF4J respectively.
During initialization the three existing factories are checked in the following order:

the Log4j2LogFactory has highest priority, since the Log4j API can faithfully transmit messages of type Object,
the Slf4jLogFactory is the next choice. However, if the Log4j-to-SLF4J bridge is present we log directly to SLF4J instead of the Log4j API.
the legacy LogFactoryImpl has lowest priority.

All the messages produced by loggers from Log4j2LogFactory and Slf4jLogFactory are marked with a COMMONS-LOGGING marker.
This PR also marks the old Log4jLogger class as deprecated.

@garydgregory,
Could you take a look at this?

@garydgregory,
Could you take a look at this?

@ppkarwasz
I should be able to get to it tomorrow hopefully.

TY @ppkarwasz !


feat: re-export tokio runtime

use deno_runner::{Builder, Runtime};
use std::collections::HashMap;

#[test]
fn test_tokio_runtime() {
    // Using re-exported tokio runtime
    let rt = Runtime::new().unwrap();
    let out = rt.block_on(async {
        let custom_code = r#"
            const add = (a, b) => a + b;
            add(a, b)
        "#;

        let runner = Builder::new().build();
        let vars = HashMap::from([("a", 1), ("b", 2)]);
        let result = runner.run(custom_code, Some(vars)).await.unwrap();

        result
    });

    assert_eq!(out, "3");
}

Codecov Report
Base: 99.13% // Head: 99.13% // No change to project coverage :thumbsup:

Coverage data is based on head (d5654a0) compared to base (1463e41).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master       #3   +/-   ##
=======================================
  Coverage   99.13%   99.13%
=======================================
  Files           1        1
  Lines         116      116
=======================================
  Hits          115      115
  Misses          1        1

Impacted Files
Coverage Δ

src/lib.rs
99.13% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Update gir

See https://github.com/gtk-rs/gir/pull/1357

 error: returning the result of a `let` binding from a block
   --> gtk4/src/auto/assistant.rs:219:13
    |
218 |             let res = (*callback)(current_page);
    |             ------------------------------------ unnecessary `let` binding
219 |             res
    |             ^^^
    |

So still one left in another context (CC @filnet). Let's keep the clippy warning for now until that's covered at some point too.


Error 500

I'm getting Error 500 using CachetHQ on a Docker Toolbox.

There's any log file that I need to show too?

Nvm, I figured it out, only needed to add "base64:" to the APP_KEY on docker-compose.yml!


ryw:blog not runnning properly w/ Meteor 0.9.3

Nice package, but:
Two errors are thrown when starting up Meteor after adding ryw:blog:
(STDERR) js-bson: Failed to load c++ bson extension, using pure JS version
and
Meteor._wrapAsync has been renamed to Meteor.wrapAsync
as no other packges are added I guess  that these are caused by ryw: blog
To reproduce:
meteor create blogtest
cd blogtest
meteor add ryw:blog
`meteor'
Any hint how to solve this?

Hi, seems to me, it is not fixed.
When using<EMAIL_ADDRESS>on Windows 8.1. I tried fresh install (besides having same error in my app)
$ meteor create testblog && cd test-blog && meteor
$ meteor add iron:router
$ meteor add ryw:blog

which resulted then in error (app works, but I would rather not have this error message in my log):
W20170215-14:58:17.158(1)? (STDERR) js-bson: Failed to load c++ bson extension, using pure JS version
I20170215-14:58:17.159(1)? { [Error: Cannot find module '../build/Release/bson'] code: 'MODULE_NOT_FOUND' }

Error was also mentioned in 2016 by @LisaKG in the last comment https://github.com/meteor/meteor/issues/7477

I assume this won't get fixed unless someone else picks up developing CollectionFS. CollectionFS has been deprecated. In order to get ryw:blog working, I had to go back to an earlier version of Meteor. I can't remember exactly what version that was, but I think it was the last of the 1.3 versions. Hope that helps.