after failover pvc and vr remain on "from" cluster with non-zero deletion timestamps and replication.storage.openshift.io finalizers

configuration:

hub: hub
dr-clusters: cluster1 hub

test:

busybox-sample application initial deployment on cluster1: succeeded
busybox-sample application failover to hub: succeeded
busybox-sample namespace delete on cluster1: failed because pvc and vr remain

I understand that a vrg creates child vrs and is also responsible for deleting them when it is deleted.  I wonder how the vrg was deleted but the vr was not.
logs:
hub-operator-log.txt
dr-cluster-operator-log-cluster1.txt
dr-cluster-operator-log-hub.txt
hub objects:
drpc.txt
placementrule.txt
dr-cluster objects:
vrg-hub.txt
vr-cluster1.txt
vr-hub.txt
pvc-cluster1.txt
pvc-hub.txt

@hatfieldbrian the deletion of the VRG was correct.  I have seen this problem once and I investigated half part of it.  Basically, the way it works is that the DRPC deletes the VRG only after the VRG has reported that it has transitioned successfully to secondary.  The PVC was stuck in the terminating state because the VR finalizer was not removed by the VR (and not the VRG). The VRG deleted the VR and removed its VRG protection finalizer, but somehow the VR didn't finalize as expected.  A successful finalization will remove the pvc-protection from the PVC and they both terminate.  That didn't happen.  Can you please include the VR logs from cluster1?

@BenamarMk I'm not sure which "vr" pod and container you want logs from, e.g.:
$ kubectl --context cluster1 get po -A
NAMESPACE                       NAME                                                   READY   STATUS      RESTARTS   AGE
busybox-sample                  busybox                                                1/1     Running     0          2m48s
kube-system                     coredns-74ff55c5b-4xqhv                                1/1     Running     0          6d20h
kube-system                     etcd-cluster1                                          1/1     Running     0          6d20h
kube-system                     kube-apiserver-cluster1                                1/1     Running     0          6d20h
kube-system                     kube-controller-manager-cluster1                       1/1     Running     0          6d20h
kube-system                     kube-proxy-8ptzx                                       1/1     Running     0          6d20h
kube-system                     kube-scheduler-cluster1                                1/1     Running     0          6d20h
kube-system                     storage-provisioner                                    1/1     Running     1          6d20h
minio                           minio-5f9c5bd8cd-5hskr                                 1/1     Running     0          6d20h
minio                           minio-setup-pk899                                      0/1     Completed   2          6d20h
multicluster-operators          multicluster-operators-subscription-5cb7dd8d68-5dflg   1/1     Running     0          6d20h
open-cluster-management-agent   klusterlet-addon-workmgr-fd8b8449b-dj7x6               1/1     Running     0          6d20h
open-cluster-management-agent   klusterlet-registration-agent-74c8c64f49-gjtp2         1/1     Running     0          6d20h
open-cluster-management-agent   klusterlet-work-agent-865f5949f8-r5rmt                 1/1     Running     0          6d20h
open-cluster-management         klusterlet-5c9d6c5476-rxf8x                            1/1     Running     0          6d20h
ramen-system                    ramen-dr-cluster-operator-bdd4cc95d-6mfv6              2/2     Running     0          8m54s
rook-ceph                       csi-cephfsplugin-9ntlv                                 3/3     Running     0          6d20h
rook-ceph                       csi-cephfsplugin-provisioner-85dd6fd578-vhrzp          6/6     Running     0          6d20h
rook-ceph                       csi-rbdplugin-gbcg7                                    3/3     Running     0          6d20h
rook-ceph                       csi-rbdplugin-provisioner-7f8f7d4bf4-l7jl9             8/8     Running     0          6d20h
rook-ceph                       rook-ceph-mgr-a-58c7b496dc-gz5p2                       1/1     Running     0          6d20h
rook-ceph                       rook-ceph-mon-a-d9cf84946-f9zq4                        1/1     Running     0          6d20h
rook-ceph                       rook-ceph-operator-5b94b79f5-fwkkl                     1/1     Running     0          6d20h
rook-ceph                       rook-ceph-osd-0-785bbc98c-xj4hz                        1/1     Running     0          6d20h
rook-ceph                       rook-ceph-osd-prepare-cluster1-zz5nz                   0/1     Completed   0          6d20h
rook-ceph                       rook-ceph-rbd-mirror-a-57d6f77987-hjf8j                1/1     Running     0          6d20h
rook-ceph                       rook-ceph-tools-6bc7c4f9fc-ddjn4                       1/1     Running     0          6d20h

container image identifiers:
$ kubectl --context cluster1 describe po -nrook-ceph csi-rbdplugin-provisioner-7f8f7d4bf4-l7jl9

  volume-replication:
    Image:         quay.io/csiaddons/volumereplication-operator:latest
    Image ID:      docker-pullable://quay.io/csiaddons/volumereplication-operator@sha256:9c53ce8e3de3348dff5305fce4ff62eeaf02988855bb7bac246

csi-rbdplugin:
    Image:         quay.io/cephcsi/cephcsi:canary
    Image ID:      docker-pullable://quay.io/cephcsi/cephcsi@sha256:70e019ad56bd409f6ab46748a64de331ee1b87b3aedc68d50689dda3bede321a

cluster1 vr log:
$ kubectl --context cluster1 -nrook-ceph logs deploy/csi-rbdplugin-provisioner volume-replication

vr-log-cluster1.txt
cluster1 vr log corresponding to its deletionTimestamp: "2021-09-29T22:46:51Z":
```sh
{"level":"info","timestamp":"2021-09-29T22:41:59.270Z","logger":"controllers.VolumeReplication","caller":"controller/controller.go:298","msg":"volume is marked primary","Request.Name":"busybox-pvc","Request.Namespace":"busybox-sample"}
{"level":"info","timestamp":"2021-09-29T22:46:33.212Z","logger":"controllers.VolumeReplication","caller":"controller/controller.go:298","msg":"volume handle","Request.Name":"busybox-pvc","Request.Namespace":"busybox-sample","VolumeHandleName":"0001-0009-rook-ceph-0000000000000002-741c9bcc-2176-11ec-99a4-0242ac11000a"}
{"level":"info","timestamp":"2021-09-29T22:46:33.988Z","logger":"controllers.VolumeReplication","caller":"controller/controller.go:298","msg":"volume is not ready to use","Request.Name":"busybox-pvc","Request.Namespace":"busybox-sample"}
{"level":"info","timestamp":"2021-09-29T22:46:49.009Z","logger":"controllers.VolumeReplication","caller":"controller/controller.go:298","msg":"volume handle","Request.Name":"busybox-pvc","Request.Namespace":"busybox-sample","VolumeHandleName":"0001-0009-rook-ceph-0000000000000002-741c9bcc-2176-11ec-99a4-0242ac11000a"}
{"level":"info","timestamp":"2021-09-29T22:46:49.254Z","logger":"controllers.VolumeReplication","caller":"controller/controller.go:298","msg":"volume is marked secondary","Request.Name":"busybox-pvc","Request.Namespace":"busybox-sample"}
{"level":"info","timestamp":"2021-09-29T22:46:51.375Z","logger":"controllers.VolumeReplication","caller":"controller/controller.go:298","msg":"volume handle","Request.Name":"busybox-pvc","Request.Namespace":"busybox-sample","VolumeHandleName":"0001-0009-rook-ceph-0000000000000002-741c9bcc-2176-11ec-99a4-0242ac11000a"}
{"level":"error","timestamp":"2021-09-29T22:46:51.520Z","logger":"controllers.VolumeReplication","caller":"controllers/volumereplication_controller.go:175","msg":"failed to disable volume replication","Request.Name":"busybox-pvc","Request.Namespace":"busybox-sample","error":"rpc error: code = InvalidArgument desc = secondary image status is up=true and state=unknown"}
{"level":"error","timestamp":"2021-09-29T22:46:51.520Z","logger":"controllers.VolumeReplication","caller":"controller/controller.go:298","msg":"failed to disable replication","Request.Name":"busybox-pvc","Request.Namespace":"busybox-sample","error":"rpc error: code = InvalidArgument desc = secondary image status is up=true and state=unknown"}
{"level":"error","timestamp":"2021-09-29T22:46:51.521Z","logger":"controller-runtime.manager.controller.volumereplication","caller":"controller/controller.go:253","msg":"Reconciler error","reconciler group":"replication.storage.openshift.io","reconciler kind":"VolumeReplication","name":"busybox-pvc","namespace":"busybox-sample","error":"rpc error: code = InvalidArgument desc = secondary image status is up=true and state=unknown"}
{"level":"info","timestamp":"2021-09-29T22:46:51.526Z","logger":"controllers.VolumeReplication","caller":"controller/controller.go:298","msg":"volume handle","Request.Name":"busybox-pvc","Request.Namespace":"busybox-sample","VolumeHandleName":"0001-0009-rook-ceph-0000000000000002-741c9bcc-2176-11ec-99a4-0242ac11000a"}
{"level":"error","timestamp":"2021-09-29T22:46:51.594Z","logger":"controllers.VolumeReplication","caller":"controllers/volumereplication_controller.go:175","msg":"failed to disable volume replication","Request.Name":"busybox-pvc","Request.Namespace":"busybox-sample","error":"rpc error: code = InvalidArgument desc = secondary image status is up=true and state=unknown"}
{"level":"error","timestamp":"2021-09-29T22:46:51.595Z","logger":"controllers.VolumeReplication","caller":"controller/controller.go:298","msg":"failed to disable replication","Request.Name":"busybox-pvc","Request.Namespace":"busybox-sample","error":"rpc error: code = InvalidArgument desc = secondary image status is up=true and state=unknown"}
{"level":"error","timestamp":"2021-09-29T22:46:51.595Z","logger":"controller-runtime.manager.controller.volumereplication","caller":"controller/controller.go:253","msg":"Reconciler error","reconciler group":"replication.storage.openshift.io","reconciler kind":"VolumeReplication","name":"busybox-pvc","namespace":"busybox-sample","error":"rpc error: code = InvalidArgument desc = secondary image status is up=true and state=unknown"}

volume-replication finalize failure issue: https://github.com/csi-addons/volume-replication-operator/issues/119

more logs:
vr-log-hub.txt
csi-rbdplugin-log-hub.txt
csi-rbdplugin-log-cluster1.txt

Updated cephcsi from:
quay.io/cephcsi/cephcsi@sha256:70e019ad56bd409f6ab46748a64de331ee1b87b3aedc68d50689dda3bede321a to
quay.io/cephcsi/cephcsi@sha256:81148b52ae3b78efbd029615fadcc50dd02a9e628b53683de2406794911a8ec4 and restarted csi-rbdplugin-provisioner deployment on each cluster, but unfinalized vr and pvc issue remains.

Updated volume-replication from
quay.io/csiaddons/volumereplication-operator@sha256:9c53ce8e3de3348dff5305fce4ff62eeaf02988855bb7bac246 to
quay.io/csiaddons/volumereplication-operator@sha256:f6659107601fdb55835855cfd59de66e311972894efbf60ac6e136fb90a13c64 and restarted csi-rbdplugin-provisioner deployment on each cluster, and unfinalized vr and pvc due to replication.storage.openshift.io finalizer issue is not present!
However, pvc and vrg remain due to volumereplicationgroups.ramendr.openshift.io/pvc-vr-protection and volumereplicationgroups.ramendr.openshift.io/vrg-protection finalizers respectively.

End-to-end test now checks for pvc and vr resources to be removed on "from" cluster for both failover and relocate and now seem to be reliably removed.

@hatfieldbrian @BenamarMk Hello, so I'm trying to do some tests using Ramen on Openshift, The failover and relocation worked fine, but, now, strangely, it does not work anymore, after a failover, the PVC is stuck in terminating status in the "from" cluster, neither the VR nor the VRG is deleted. so I cannot relocate.

So when the failover succeeds, DRPC will try to clean up the 'from'
cluster.  In doing so, it will first update the Manifestwork (on the
hub) for the 'from' cluster. The VRG is changed to Secondary.  That
update must be applied to the 'from' cluster. So, you will need to make
sure the VRG in the 'from' cluster spec.ReplicationState == Secondary.
If it is still saying Primary, then the Manifestwork hasn't been applied on
the 'from' cluster. The status of the Manifestwork will give you a hint.
If the .spec.ReplicationState is secondary, then the VR is trying to demote
the image to secondary and resyncs with the new primary.  Nothing will
happen until that step is complete.  Once that step is complete, then the
VRG status will be updated to reflect the ReplicationState (secondary).
After that, the DRPC will delete the VRG on the 'from' cluster.  Deleting
the VRG will first delete the VR, the finalizers will be removed from the
PVC and then the PVC goes away.  That's what happens in a nutshell.
On Thu, Jul 21, 2022 at 4:03 AM VphDreamer @.***> wrote:

@hatfieldbrian https://github.com/hatfieldbrian @BenamarMk
https://github.com/BenamarMk Hello, so I'm trying to do some tests
using Ramen on Openshift, The failover and relocation worked fine, but,
now, strangely, it does not work anymore, after a failover, the PVC is
stuck in terminating status in the "from" cluster, neither the VR nor the
VRG is deleted. so I cannot relocate.
—
Reply to this email directly, view it on GitHub
https://github.com/RamenDR/ramen/issues/302#issuecomment-1191172865, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AJED3EDOTKTAOG6BC3EZR53VVD74XANCNFSM5FBAT7CA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@BenamarMk here is the VRG in the from cluster, the spec.ReplicationState is set to secondary, but, in status, we can see a primary:
apiVersion: ramendr.openshift.io/v1alpha1
kind: VolumeReplicationGroup
metadata:
  resourceVersion: '36810651'
  name: busybox-drpc
  uid: 8649bf70-9a88-46d0-a57a-8d03e628ed34
  creationTimestamp: '2022-07-21T07:28:49Z'
  generation: 2
  managedFields:
    - apiVersion: ramendr.openshift.io/v1alpha1
      fieldsType: FieldsV1
      fieldsV1:
        'f:metadata':
          'f:finalizers':
            .: {}
            'v:"volumereplicationgroups.ramendr.openshift.io/vrg-protection"': {}
      manager: manager
      operation: Update
      time: '2022-07-21T07:28:49Z'
    - apiVersion: ramendr.openshift.io/v1alpha1
      fieldsType: FieldsV1
      fieldsV1:
        'f:status':
          .: {}
          'f:conditions': {}
          'f:lastUpdateTime': {}
          'f:observedGeneration': {}
          'f:protectedPVCs': {}
          'f:state': {}
      manager: manager
      operation: Update
      subresource: status
      time: '2022-07-21T07:29:48Z'
    - apiVersion: ramendr.openshift.io/v1alpha1
      fieldsType: FieldsV1
      fieldsV1:
        'f:metadata':
          'f:ownerReferences':
            .: {}
            'k:{"uid":"7b45e3b3-7d17-4a72-b693-9847b5f43e0c"}': {}
        'f:spec':
          .: {}
          'f:action': {}
          'f:async':
            .: {}
            'f:mode': {}
            'f:replicationClassSelector': {}
            'f:schedulingInterval': {}
          'f:pvcSelector':
            .: {}
            'f:matchLabels':
              .: {}
              'f:appname': {}
          'f:replicationState': {}
          'f:s3Profiles': {}
          'f:sync':
            .: {}
            'f:mode': {}
      manager: work
      operation: Update
      time: '2022-07-21T07:38:18Z'
  namespace: busybox-sample
  ownerReferences:
    - apiVersion: work.open-cluster-management.io/v1
      kind: AppliedManifestWork
      name: >-
        5c41238f1c4c5b9b686bdb1d16b10dab6e9dffed3808268a14c4062954601b04-busybox-drpc-busybox-sample-vrg-mw
      uid: 7b45e3b3-7d17-4a72-b693-9847b5f43e0c
  finalizers:
    - volumereplicationgroups.ramendr.openshift.io/vrg-protection
spec:
  action: Failover
  async:
    mode: Enabled
    replicationClassSelector: {}
    schedulingInterval: 5m
  pvcSelector:
    matchLabels:
      appname: busybox
  replicationState: secondary
  s3Profiles:
    - s3profile-dr-primary-ocs-storagecluster
    - s3profile-dr-secondary-ocs-storagecluster
  sync:
    mode: Disabled
status:
  conditions:
    - lastTransitionTime: '2022-07-21T07:38:18Z'
      message: VolumeReplicationGroup is progressing
      observedGeneration: 2
      reason: Progressing
      status: 'False'
      type: DataReady
    - lastTransitionTime: '2022-07-21T07:38:18Z'
      message: VolumeReplicationGroup is replicating
      observedGeneration: 2
      reason: Replicating
      status: 'False'
      type: DataProtected
    - lastTransitionTime: '2022-07-21T07:29:48Z'
      message: Restored PV cluster data
      observedGeneration: 1
      reason: Restored
      status: 'True'
      type: ClusterDataReady
    - lastTransitionTime: '2022-07-21T07:38:18Z'
      message: Cluster data of all PVs are protected
      observedGeneration: 2
      reason: Uploaded
      status: 'True'
      type: ClusterDataProtected
  lastUpdateTime: '2022-07-21T07:38:19Z'
  observedGeneration: 2
  protectedPVCs:
    - conditions:
        - lastTransitionTime: '2022-07-21T07:38:18Z'
          message: Updated VolumeReplication resource for PVC
          observedGeneration: 2
          reason: Progressing
          status: 'False'
          type: DataReady
        - lastTransitionTime: '2022-07-21T07:29:49Z'
          message: >-
            Done uploading PV cluster data to 2 of 2 S3 profile(s):
            [s3profile-dr-primary-ocs-storagecluster
            s3profile-dr-secondary-ocs-storagecluster]
          observedGeneration: 1
          reason: Uploaded
          status: 'True'
          type: ClusterDataProtected
        - lastTransitionTime: '2022-07-21T07:29:49Z'
          message: PVC in the VolumeReplicationGroup is ready for use
          observedGeneration: 1
          reason: Replicating
          status: 'False'
          type: DataProtected
      name: busybox-pvc
  state: Primary

and this is the VR :
apiVersion: replication.storage.openshift.io/v1alpha1
kind: VolumeReplication
metadata:
  resourceVersion: '36896180'
  name: busybox-pvc
  uid: 72d2620b-8085-4152-97b3-bc3751aebb1f
  creationTimestamp: '2022-07-21T07:29:48Z'
  generation: 2
  namespace: busybox-sample
  ownerReferences:
    - apiVersion: ramendr.openshift.io/v1alpha1
      blockOwnerDeletion: true
      controller: true
      kind: VolumeReplicationGroup
      name: busybox-drpc
      uid: 8649bf70-9a88-46d0-a57a-8d03e628ed34
  finalizers:
    - replication.storage.openshift.io
spec:
  dataSource:
    apiGroup: ''
    kind: PersistentVolumeClaim
    name: busybox-pvc
  replicationHandle: ''
  replicationState: secondary
  volumeReplicationClass: rbd-volumereplicationclass-1625360775
status:
  conditions:
    - lastTransitionTime: '2022-07-21T07:39:27Z'
      message: ''
      observedGeneration: 2
      reason: Demoted
      status: 'True'
      type: Completed
    - lastTransitionTime: '2022-07-21T07:38:20Z'
      message: ''
      observedGeneration: 2
      reason: VolumeDegraded
      status: 'True'
      type: Degraded
    - lastTransitionTime: '2022-07-21T08:39:23Z'
      message: ''
      observedGeneration: 2
      reason: ResyncTriggered
      status: 'True'
      type: Resyncing
  lastCompletionTime: '2022-07-21T07:29:54Z'
  lastStartTime: '2022-07-21T07:29:48Z'
  message: volume is degraded
  observedGeneration: 2
  state: Secondary

So the VR looks like is resyncing

 lastTransitionTime: '2022-07-21T08:39:23Z'
      message: ''
      observedGeneration: 2
      reason: ResyncTriggered
      *status: 'True'*
      type: Resyncing

On Thu, Jul 21, 2022 at 4:40 AM VphDreamer @.***> wrote:

and this is the VR :
apiVersion: replication.storage.openshift.io/v1alpha1
kind: VolumeReplication
metadata:
resourceVersion: '36896180'
name: busybox-pvc
uid: 72d2620b-8085-4152-97b3-bc3751aebb1f
creationTimestamp: '2022-07-21T07:29:48Z'
generation: 2
namespace: busybox-sample
ownerReferences:
- apiVersion: ramendr.openshift.io/v1alpha1
blockOwnerDeletion: true
controller: true
kind: VolumeReplicationGroup
name: busybox-drpc
uid: 8649bf70-9a88-46d0-a57a-8d03e628ed34
finalizers:
- replication.storage.openshift.io
spec:
dataSource:
apiGroup: ''
kind: PersistentVolumeClaim
name: busybox-pvc
replicationHandle: ''
replicationState: secondary
volumeReplicationClass: rbd-volumereplicationclass-1625360775
status:
conditions:
- lastTransitionTime: '2022-07-21T07:39:27Z'
message: ''
observedGeneration: 2
reason: Demoted
status: 'True'
type: Completed
- lastTransitionTime: '2022-07-21T07:38:20Z'
message: ''
observedGeneration: 2
reason: VolumeDegraded
status: 'True'
type: Degraded
- lastTransitionTime: '2022-07-21T08:39:23Z'
message: ''
observedGeneration: 2
reason: ResyncTriggered
status: 'True'
type: Resyncing
lastCompletionTime: '2022-07-21T07:29:54Z'
lastStartTime: '2022-07-21T07:29:48Z'
message: volume is degraded
observedGeneration: 2
state: Secondary
—
Reply to this email directly, view it on GitHub
https://github.com/RamenDR/ramen/issues/302#issuecomment-1191209557, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AJED3EBRJ6GE6FFAAF6JJR3VVEEIDANCNFSM5FBAT7CA
.
You are receiving this because you were mentioned.Message ID:
@.***>

I am not sure what other things are preventing the resync to complete.  We
need to look at the logs and run a few RBD commands in order to determine
the cause.
On Thu, Jul 21, 2022 at 5:04 AM Benamar Mekhissi @.***>
wrote:

So the VR looks like is resyncing

 lastTransitionTime: '2022-07-21T08:39:23Z'
      message: ''
      observedGeneration: 2
      reason: ResyncTriggered
      *status: 'True'*
      type: Resyncing

On Thu, Jul 21, 2022 at 4:40 AM VphDreamer @.***>
wrote:

and this is the VR :
apiVersion: replication.storage.openshift.io/v1alpha1
kind: VolumeReplication
metadata:
resourceVersion: '36896180'
name: busybox-pvc
uid: 72d2620b-8085-4152-97b3-bc3751aebb1f
creationTimestamp: '2022-07-21T07:29:48Z'
generation: 2
namespace: busybox-sample
ownerReferences:
- apiVersion: ramendr.openshift.io/v1alpha1
blockOwnerDeletion: true
controller: true
kind: VolumeReplicationGroup
name: busybox-drpc
uid: 8649bf70-9a88-46d0-a57a-8d03e628ed34
finalizers:
- replication.storage.openshift.io
spec:
dataSource:
apiGroup: ''
kind: PersistentVolumeClaim
name: busybox-pvc
replicationHandle: ''
replicationState: secondary
volumeReplicationClass: rbd-volumereplicationclass-1625360775
status:
conditions:
- lastTransitionTime: '2022-07-21T07:39:27Z'
message: ''
observedGeneration: 2
reason: Demoted
status: 'True'
type: Completed
- lastTransitionTime: '2022-07-21T07:38:20Z'
message: ''
observedGeneration: 2
reason: VolumeDegraded
status: 'True'
type: Degraded
- lastTransitionTime: '2022-07-21T08:39:23Z'
message: ''
observedGeneration: 2
reason: ResyncTriggered
status: 'True'
type: Resyncing
lastCompletionTime: '2022-07-21T07:29:54Z'
lastStartTime: '2022-07-21T07:29:48Z'
message: volume is degraded
observedGeneration: 2
state: Secondary
—
Reply to this email directly, view it on GitHub
https://github.com/RamenDR/ramen/issues/302#issuecomment-1191209557,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJED3EBRJ6GE6FFAAF6JJR3VVEEIDANCNFSM5FBAT7CA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@BenamarMk what are the logs that I need to check ?

You can always start by looking at the VR log, which is found in one of the
csi-rbdplugin-provisioner instances
oc logs -n openshift-storage  csi-rbdplugin-provisioner-85559d89d8-fdbpf -c
volume-replication
replace the namespace and the pod name with the correct ones.
On Thu, Jul 21, 2022 at 5:09 AM VphDreamer @.***> wrote:

@BenamarMk https://github.com/BenamarMk what are the logs that I need
to check ?
—
Reply to this email directly, view it on GitHub
https://github.com/RamenDR/ramen/issues/302#issuecomment-1191239998, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AJED3EBQVW2XDAXI7EUU32TVVEHVVANCNFSM5FBAT7CA
.
You are receiving this because you were mentioned.Message ID:
@.***>

is this can be helpful:
{"level":"info","timestamp":"2022-07-21T09:32:07.254Z","logger":"controllers.VolumeReplication","caller":"controller/controller.go:298","msg":"volume is not ready to use, requeuing for resync","Request.Name":"mongodb","Request.Namespace":"letschat-rhacm"}            {"level":"info","timestamp":"2022-07-21T09:32:16.258Z","logger":"controllers.VolumeReplication","caller":"controller/controller.go:298","msg":"volume handle","Request.Name":"busybox-pvc","Request.Namespace":"busybox-sample","VolumeHandleName":"0001-0011-openshift-storage-0000000000000001-e645c90a-08c6-11ed-9975-0a580a870010"}                             {"level":"info","timestamp":"2022-07-21T09:32:16.478Z","logger":"controllers.VolumeReplication","caller":"controller/controller.go:298","msg":"volume is not ready to use, requeuing for resync","Request.Name":"busybox-pvc","Request.Namespace":"busybox-sample"}

Most likely the issue is some kind of rbd split-brain error on that image.
We definitely can't debug it through emails.  We should probably have
access to the cluster or at least collect must-gather.
In the meantime, I'll be interested to see the output of rbd mirror image status for that image.
On Thu, Jul 21, 2022 at 5:36 AM VphDreamer @.***> wrote:

is this can be helpful:
{"level":"info","timestamp":"2022-07-21T09:32:07.254Z","logger":"controllers.VolumeReplication","caller":"controller/controller.go:298","msg":"volume
is not ready to use, requeuing for
resync","Request.Name":"mongodb","Request.Namespace":"letschat-rhacm"}
{"level":"info","timestamp":"2022-07-21T09:32:16.258Z","logger":"controllers.VolumeReplication","caller":"controller/controller.go:298","msg":"volume
handle","Request.Name":"busybox-pvc","Request.Namespace":"busybox-sample","VolumeHandleName":"0001-0011-openshift-storage-0000000000000001-e645c90a-08c6-11ed-9975-0a580a870010"}
{"level":"info","timestamp":"2022-07-21T09:32:16.478Z","logger":"controllers.VolumeReplication","caller":"controller/controller.go:298","msg":"volume
is not ready to use, requeuing for
resync","Request.Name":"busybox-pvc","Request.Namespace":"busybox-sample"}
—
Reply to this email directly, view it on GitHub
https://github.com/RamenDR/ramen/issues/302#issuecomment-1191266732, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AJED3EG22OTDJF27J2XQPPTVVEKYXANCNFSM5FBAT7CA
.
You are receiving this because you were mentioned.Message ID:
@.***>

I find that the status of the image is correct, it "up+replaying" in the "from" cluster and primary in the failover cluster.
One thing I tried is that I deleted the VRG manually and then the "from" cluster is cleaned (VRG, VR and PVC are deleted), and then I managed to relocate. Personally, I think for some reason, it's just that the VRG that is not updated.

Well, the VRG gets deleted when its status state is updated to Secondary.
That wasn't the case and you force deletion.  Anyway, there was a glitch
somewhere.  The mismatch state between the VRG and VR didn't make sense to
me.  If it happens again, we would be interested in digging further.  BTW,
what version is this?
On Thu, Jul 21, 2022 at 6:31 AM VphDreamer @.***> wrote:

I find that the status of the image is correct, it "up+replaying" in the
"from" cluster and primary in the failover cluster.
One thing I tried is that I deleted the VRG manually and then the "from"
cluster is cleaned (VRG, VR and PVC are deleted), and then I managed to
relocate. Personally, I think for some reason, it's just that the VRG that
is not updated.
—
Reply to this email directly, view it on GitHub
https://github.com/RamenDR/ramen/issues/302#issuecomment-1191320310, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AJED3EDUJCVK7FQPJOPEYLTVVERHDANCNFSM5FBAT7CA
.
You are receiving this because you were mentioned.Message ID:
@.***>

I'm working on Openshift, so, I don't know exactly the version of ramen, but, these are the versions of Openshift and the installed operators:

Openshift: 4.10.20
ACM : 2.0.5
ODF Multicluster Orchestrator: 4.10.5
Openshift DR Hub Operator: 4.10.5
Openshift DR Cluster Operator: 4.10.5

I don't know how can I help to debug this, the clusters are provisioned on-premises, they are not accessible to public. and I'm not yet sure how to reproduce the issue.

@BenamarMk So, If I do understand, having the VR status as secondary is not sufficient so that VRG status will be set to secondary , other checks are done right ? https://github.com/RamenDR/ramen/blob/26b5feac8a8a1eeea94226a2091b33faaa977814/controllers/vrg_volrep.go#L1110
l need to have the Rysincing set to false, is that right? does this depends on the RBD layer ?

That's correct. VR needs to mark the volume as secondary and resyncs
successfully before the VRG .status.state is updated. Only after all VRs
have been moved to secondary successfully, the VRG .status.State is updated
to secondary.  From the VR output above, the condition shows that the
volume was degraded.
Can you attach the Ramen log file from the 'from' cluster?
On Thu, Jul 21, 2022 at 9:22 AM VphDreamer @.***> wrote:

@BenamarMk https://github.com/BenamarMk So, If I do understand, having
the VR status as secondary is not sufficient so that VRG status will be set
to secondary , other checks are done right ?
https://github.com/RamenDR/ramen/blob/26b5feac8a8a1eeea94226a2091b33faaa977814/controllers/vrg_volrep.go#L1110
l need to have the Rysincing set to false, is that right? does this
depends on the RBD layer ?
—
Reply to this email directly, view it on GitHub
https://github.com/RamenDR/ramen/issues/302#issuecomment-1191479151, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AJED3EAKFMY5HMAUN23VIBLVVFFIJANCNFSM5FBAT7CA
.
You are receiving this because you were mentioned.Message ID:
@.***>

logs_ramen.log

@BenamarMk, So I tried to force the image resyncing with the following command:
rbd mirror image resync csi-vol-84d312cc-08ee-11ed-9c73-0a580a850422
Then I noticed these changes in the VR status, It tried to Resync but failed and then after it returns to its previous status.
status:
  conditions:
    - lastTransitionTime: '2022-07-21T20:01:30Z'
      message: ''
      observedGeneration: 2
      reason: FailedToResync
      status: 'False'
      type: Completed
    - lastTransitionTime: '2022-07-21T12:22:47Z'
      message: ''
      observedGeneration: 2
      reason: Error
      status: 'True'
      type: Degraded
    - lastTransitionTime: '2022-07-21T20:01:30Z'
      message: ''
      observedGeneration: 2
      reason: FailedToResync
      status: 'False'
      type: Resyncing
  lastCompletionTime: '2022-07-21T12:13:28Z'
  lastStartTime: '2022-07-21T12:13:24Z'
  message: 'failed to get local status: rbd: ret=-2, No such file or directory'
  observedGeneration: 2
  state: Secondary

I want to indicate that I now think it's not a Ramen bug, it may be more related to my environment, something maybe changed.
Say that I have two clusters "east" and "west". In a scenario where the app is deployed originally in the cluster "east", I manage to failover to cluster "west", but, the cluster "east" is not well cleaned up. However, if I tried to deploy originally the app in the cluster "west", the failover, the cleanup, the relocating, all work fine. So, guess in my cluster "east", I may accidently deleted or changed something that triggered this behavior.


Use the vscode extension "logPath" to dump the relevant information into a file, which we can directly ask the users for while dealing with issues on github

vscode recently added "logPath" to be used by the extensions for some logging.
We can use this file to detect possible causes of failures lusing:

Omnisharp log
C# log
Mono path used by the extension
MSBuild instances used
dotnet --info
extension version
vscode version

The contents of this file can then be directly posted to the github issue and we will have better context of the problems the users face.
Questions:

[ ] Whenever the extension is activated we will discard the old one and create a new file right ?

[ ] What is the path of the file extensionpath/logging.txt ?

cc @TheRealPiotrP @rchande Any other thing you think we should add ? Also, whenever the extension is activated we will create a new file right ?

Closing due to lack of activity.


Add retry_n_times functionality for sucker_punch

details in https://app.clubhouse.io/rollbar/story/4704/add-retry-n-times-functionality-for-sucker-punch

Hi there, I’m closing out all issues opened before 2018 that haven’t had any activity on them since the start of this year. If this is still an issue for you, please comment here and we can reopen this. Thanks!


Missing instruction in README

It is needed to set datafile separator otherwise gnuplot ignores X axe.
gnuplot
set datafile separator ","
plot ...

Can you please open a pull request with the change you'd like to see?


Can I new a sol::state with my own lua_State pointer?

My project use two language,and I have to create a lua_State in another project,so is there any way I can use the already exist lua_State to create a new sol::state.I'm already search out the doc but get no luck.so anyone can help?Thanks.

You can use sol::state_view. It's documented here: http://sol2.readthedocs.io/en/latest/api/state.html?highlight=state_view
It's basically the same as sol::state but you get to manage the actual lua_State yourself. Which sounds like what you need.

@Sixmorphugus is exactly right. This is information is also present in the Quick 'n' Dirty Tutorial and in the Integrating Existing Code tutorial.
Good luck.


added 8ball app and changed boxclk to use clockbackgrounds app

added an app called 8ball (a magic 8ball) and updated the clock boxclk to use the new app clockbackgrounds

fixed the warnings


Update the copy icon in snippets and samples to use the standard one

Description
This updates the copy icon for copying sample code to use content_copy instead of assignment.
Before:

After:

Related Issues

Fixes https://github.com/flutter/flutter/issues/122246

Tests

No tests needed.

@gspencergoog in that screenshot of the after change, the icon is upside-down from the one in the material spec: https://fonts.google.com/icons?selected=Material+Symbols+Outlined:content_copy:FILL@0;wght@400;GRAD@0;opsz@48
Maybe they changed that icon at some point?  Or maybe we have a subtle bug in Flutter.

That's the "Material Symbols" version.  We're using the "Material Icons" version.  https://fonts.google.com/icons?selected=Material+Icons+Outlined:content_copy:&icon.set=Material+Icons
Why they are inverted is a mystery you'll have to ask the material team.


Deploy safe fails to confirm on latest version with ethers v6

Expected behavior: Safe is deployed, then receipt is confirmed and returned
Current behavior: Safe is deployed, but the receipt fails to be confirmed with the following error:
TypeError: receipt.confirmations is not a function
    at ContractTransactionResponse.wait (provider.js:1066:1)
    at async ContractTransactionResponse.wait (wrappers.js:115:1)
    at async eval (SafeProxyFactoryEthersContract.js:27:1)
    at async SafeFactory.deploySafe (index.js:101:1)

Reproducing code:
"ethers": "^6.7.1"
"@safe-global/protocol-kit": "^2.0.0
import { ethers } from 'ethers';
import {
  SafeFactory,
  SafeAccountConfig,
  EthersAdapter,
} from '@safe-global/protocol-kit';

  const ethAdapter = new EthersAdapter({
      ethers,
      signerOrProvider: sdk.signer, // ethers v6 `Signer`
  });

  const safeAccountConfig: SafeAccountConfig = {
      owners: [sdk.signerAddress],
      threshold: 1,
    }

  async function deploySafe() {
    const safeFactory = await SafeFactory.create({ ethAdapter });

    const safeSDK = await safeFactory.deploySafe({
      safeAccountConfig,
      saltNonce: safeDeploymentConfig.saltNonce,
    });
    const safeAddress = await safeSDK.getAddress();

    console.log('Your Safe has been deployed:');
    console.log(`https://arbiscan.io/address/${safeAddress}`);
    console.log(`https://app.safe.global/arb1:${safeAddress}`);

    return safeSDK;
}

@froggiedev thank you for your report. Could you also share which chain, Safe version and RPC provider you were using?
Thank you!

@froggiedev thank you for your report. Could you also share which chain, Safe version and RPC provider you were using?
Thank you!

Chain: Arbitrum Goerli
Safe Version: 1.4.1 (package version shared above)
RPC Provider: Quicknode

@froggiedev as far as I checked the issue is not coming from ethers v6 migration but because the Arbitrum contracts v1.4.1 are not yet on safe-deployments and we are not correctly handling this. You shouldn't find this issue if you try to deploy the contract v1.3.0. We will investigate further.

@froggiedev as far as I checked the issue is not coming from ethers v6 migration but because the Arbitrum contracts v1.4.1 are not yet on safe-deployments and we are not correctly handling this. You shouldn't find this issue if you try to deploy the contract v1.3.0. We will investigate further.

Does contract v1.3.0 work with ethers v6?

Yes, you can safely use ethers v6 in the safe-core-sdk and v1.3.0 version of the smart contracts

Yes, you can safely use ethers v6 in the safe-core-sdk and v1.3.0 version of the smart contracts

Ah, but v1.3.0 does not support the Safe ERC-4337 module if I remember correctly.

The issue should be now solved for Arbitrum, as the addresses are available at safe-deployments package.
Also this ticket relates better to the issue that causes this unexpected behavior.


add valid flag on dbs api.

Following is the method in dbs client which need to have validOnly flag. Yuyi told me the last 2 is already has. So listFiles is the only one which needed this flag.

Flag should be independent of other parameters especially 'detail ' - regard less detail option it should return the correct result.
File should be invalid if dataset is invalid (so returns nothing if dataset is invalid)
REST api need to have the same behavior as dbsClient behavior.

listFiles
listFileLumis
listFileSummaries

To have all the ValidFileOnly flag returns the same set of results, we have to update the other APIs that  use this flag to check if the dataset is valid or not. Current implementation only checks is_file_valid of files table.

Sure, as you said, it has to be consistent.

Interesting. The sql was originally only pick valid files, but it was commented out and changed to pick all the files. It did not say what triggered the changed.

Can you track to when? Before/after the github migration?

Interesting. The sql was originally only pick valid files, but it was commented out and changed to pick all the files. It did not say what triggered the changed.

When did this happen? Maybe DBS2 was that way before. For me, default value returning only valid files makes more sense.

The change happened more than 4 years ago. The dao started without checking is_file_valid column so it had all files.
Then it required is_file_valid=1
https://svnweb.cern.ch/trac/CMSDMWM/browser/DBS/trunk/Server/Python/src/dbs/dao/Oracle/File/List.py?rev=9873
Later, it changed to all files
https://svnweb.cern.ch/trac/CMSDMWM/browser/DBS/trunk/Server/Python/src/dbs/dao/Oracle/File/List.py?rev=9974
So this is not a new thing. It has been return all files more than 4 years.
Seangchan, I cannot change the behavior of DBS API to return valid file by default as I mentioned before. the thing I can do is what we discussed in this issue.

Seangchan, I cannot change the behavior of DBS API to return valid file by default as I mentioned before. the thing I can do is what we discussed in this issue.

Sure, I just meant the other way make more sense. :smile:

@ticoann
I have have update dbs vm with validFileOnly flag for listFiles api under both detail=0/1.
https://dbs3-test1.cern.ch/dbs/dev/global/DBSReader/
Please take a look and let me know if this works for you or not.

Thanks Yuyi, I guess it is not yet in master branch.
https://github.com/dmwm/DBS/blob/master/Client/src/python/dbs/apis/dbsClient.py#L839
Let me know when it gets updated.

Works to be done on daos of listFileLumis and listFileSummeris to check dataset access type is VALID or PRODUCTION.

Done as discussed in DBS 3.2.9.


Configure the actor for the failure animation

Now we are creating a black box actor but there is not reason that we can not just use an actor from our entities and just specify the entity name which to spawn

Why not go crazy and make it a list of entitie names which it spawns iteratifly like it does with color iteration

Done


Update plugin and dependency versions

Update dependency-check-maven to 6.0.5
Update guava (CVE-2020-8908)
Update spring (CVE-2020-5421)
Update junit version

Related to #55

👍

👍


[FEAT] - tree-view grid

This feature would be a combination of grouping and expandable row. Each row could be expanded, but the expansion would be considered as a part of the main grid, so their virtualization be calculated together.
So the look and feel would be like a grouped grid, but the rows would look like an expandable grid (the "group headers" would have their own data sources).
Some thoughts:
@PaulL1 :

potentially treeview could be added to grouping rather than duplicating. Probably the main change is to use the existing row as a groupHeader rather than inserting a new row. But not quite sure how we'd decide which row is the "parent" row
since at the moment we sort then look for breaks in value. Would the first row with a given value always be the "parent". Or would we have some other way to tell the code which rows are nodes and which rows are leaves?```

Further, we could store the number of child nodes for any given node in row.numChildren, and then use a custom cell template to add the number of children in brackets if the user wanted
You could reuse the header column logic and the indenting of the + from grouping
it'd be nice to have a combined code base, but perhaps it's easier to just copy the bits that are useful.
Since treeview would (I presume) be more of a programatically set thing - I'm assuming you can't just sort by any arbitrary column then turn that into a treeview - so it would probably be a much smaller code base```

Would you see the expanded sections having their own data sources, or all the data returned as part of one server call?  The latter would be much more efficient, if we did the former we'd need a "get children of this node" type method, and we'd need to original data to tell us which nodes had children under them.  Seems like you'd be making your server a lot more complicated with not much benefit?

I've started on this: https://github.com/PaulL1/ng-grid/tree/treeView
It doesn't run yet, but the basics are there.  I haven't done any work on dynamic loading.  I need to add a tutorial.  But just so we don't double up, I'm posting.

I've completed the base implementation of this.  It runs, has unit tests, has a tutorial and supports dynamic loading.  It has some outstandings that we might want to implement as noted in the tutorial: http://ui-grid.info/docs/#/tutorial/215_treeView

Refer discussion on the commit for potential extensions and fixes.

I think this is now resolved, closing.

Hi, I cannot build a tree using UI-Grid , please help me to fix this below is the code what i got:
I also have a json which i need to build the treeview
var app = angular.module('app', ['ngAnimate', 'ngTouch', 'ui.grid', 'ui.grid.treeView' ]);
app.controller('MainCtrl', ['$scope', '$http', '$interval', 'uiGridTreeViewConstants', function ($scope, $http, $interval, uiGridTreeViewConstants ) {
$scope.gridOptions = {
enableSorting: true,
enableFiltering: true,
showTreeExpandNoChildren: true,
columnDefs: [
  { name: 'id', width: '20%' },
  { name: 'parentId', width: '20%' },
  { name: 'name', width: '30%' }
],

};
var data = [
{
"id": 1,
"parentId": 1,
"name": "TopLoc1",
"children": [
{
"id": 2,
"parentId": 1,
"name": "Loc1 child",
"children": [
{
"id": 4,
"parentId": 2,
"name": "Loc2 child",
"children": []
}
]
},
{
"id": 3,
"parentId": 1,
"name": "Loc1 child",
"children": []
}
]
},
{
"id": 5,
"parentId": 5,
"name": "Top Loc 2",
"children": [
{
"id": 6,
"parentId": 5,
"name": "Loc5 child",
"children": [
{
"id": 8,
"parentId": 6,
"name": "Loc6 child",
"children": []
},
{
"id": 9,
"parentId": 6,
"name": "Loc5 child",
"children": []
},
{
"id": 10,
"parentId": 6,
"name": "Loc5 child",
"children": [
{
"id": 11,
"parentId": 10,
"name": "Loc10 child",
"children": [
{
"id": 12,
"parentId": 11,
"name": "Loc11 child",
"children": []
}
]
}
]
}
]
},
{
"id": 7,
"parentId": 5,
"name": "Loc5 child",
"children": []
}
]
}
];
$scope.gridOptions.data = data;

$scope.expandAll = function(){
$scope.gridApi.treeBase.expandAllRows();
};
$scope.toggleRow = function( rowNum ){
$scope.gridApi.treeBase.toggleRowTreeState($scope.gridApi.grid.renderContainers.body.visibleRowCache[rowNum]);
};
$scope.toggleExpandNoChildren = function(){
$scope.gridOptions.showTreeExpandNoChildren = !$scope.gridOptions.showTreeExpandNoChildren;
$scope.gridApi.grid.refresh();
};
}]);
Please reply as early as you could :)


Fixed stripped example parts in mixed gloss-plain example lists

Thanks for the useful filter!
Problem:
With Pandoc 2.14.1 and the current version of the filter, example (1a) is stripped in the example below
:::ex
a. Something
a.
|
| lima tarakta al-hisaan waahidan?
| why left.2sg the-horse alone?
| Why did you leave the horse alone?
:::

Rendered as:
(1) a. lima tarakta al-hisaan waahian?
         why left.2sg the-horse alone?
         Why did you leave the horse alone?

Plus, bugs arise in the following example:
:::ex
a. Something
a.
|
| lima tarakta al-hisaan waahidan?
| why left.2sg the-horse alone?
| Why did you leave the horse alone?
a. fezfezfez efzojfezj fezj
a. pkezapkfez ofezkpfêz fezoi
:::

Error running filter build/pandoc-ling.lua:
build/pandoc-ling.lua:763: bad argument #1 to 'insert' (table expected, got nil)
stack traceback:
        [C]: in function 'pandoc.List.insert'
        build/pandoc-ling.lua:763: in function 'pandocMakeList'
        build/pandoc-ling.lua:837: in function 'pandocMakeMixedList'
        build/pandoc-ling.lua:538: in function 'pandocMakeExample'
        build/pandoc-ling.lua:261: in function 'processDiv'

Suggested fixes:

In pandocMakeList, change indexing for the case from=1
In pandocMakeMixedList, fixed the loop that renders adjacent plain example parts + keep track of glossed examples

Hope I didn't break anything valuable!

thanks for the help! I hope it works now. It took a while because I was busy with other stuff... The whole code actually needs a complete rework, but that will have to wait.

Thanks ! Since the PR, I've made some more modifications on my fork. Let me know if you find any useful and I'll do a PR.

made filter compatible with version 2.16.1 of Pandoc (there apparently has been some breaking API changes)
gloss are rendered using flexbox, rather than arrays ; it makes it possible to have multi-line gloss. One issue is that it may not render well with .docx or .epub (haven't tried).
fixed some next and previous ref problem in LateX conversion

I agree a rework would be good and if I find time myself, I can help you.

I think I fixed all incompatibility with pandoc already last weekend. There were some changes with the handling of Lua. Minor fixes please as PR in the main branch! For major reworking I'll add a dev branch. Looking forward to your suggestions!


[Question] How to run specific version of model from huggingface

Checklist

[X] 1. I have searched related issues but cannot get the expected help.
[X] 2. The bug has not been fixed in the latest version.
[X] 3. Please note that if the bug-related issue you submitted lacks corresponding environment info and a minimal reproducible demo, it will be challenging for us to reproduce and resolve the issue, reducing the likelihood of receiving feedback.

Describe the bug
Hi. I want to run 'unsloth/Llama-3.3-70B-Instruct-GGUF:F16' but serve returns following error. How can i fix this?
$ lmdeploy serve api_server 'unsloth/Llama-3.3-70B-Instruct-GGUF:F16'
Traceback (most recent call last):
  File "/home/bghadiri/miniconda3/bin/lmdeploy", line 8, in <module>
    sys.exit(run())
             ^^^^^
  File "/home/bghadiri/miniconda3/lib/python3.12/site-packages/lmdeploy/cli/entrypoint.py", line 31, in run
    args.model_path = get_model(args.model_path,
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/bghadiri/miniconda3/lib/python3.12/site-packages/lmdeploy/utils.py", line 206, in get_model
    model_path = snapshot_download(pretrained_model_name_or_path,
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/bghadiri/miniconda3/lib/python3.12/site-packages/huggingface_hub/utils/_validators.py", line 106, in _inner_fn
    validate_repo_id(arg_value)
  File "/home/bghadiri/miniconda3/lib/python3.12/site-packages/huggingface_hub/utils/_validators.py", line 160, in validate_repo_id
    raise HFValidationError(
huggingface_hub.errors.HFValidationError: Repo id must use alphanumeric chars or '-', '_', '.', '--' and '..' are forbidden, '-' and '.' cannot start or end the name, max length is 96: 'unsloth/Llama-3.3-70B-Instruct-GGUF:F16'.

Reproduction
lmdeploy serve api_server 'unsloth/Llama-3.3-70B-Instruct-GGUF:F16'
Environment
-

Error traceback
No response

To run specific version of model, you can add --revision parameter, but we dont' support gguf format.
Maybe you could run lmdeploy serve api_server unsloth/Llama-3.3-70B-Instruct --revision b6284849f6901630c95ed3a4f3345a2b4f2bc759


feat: add the 2.3.0.json version, and add the Solace binding.

Description
This adds a new version 2.3.0.json and adds the solace binding to the list of bindings.
Related issue(s)
The related PR on the spec itself is here: https://github.com/asyncapi/spec/pull/666

@MichaelDavisSolace sorry but unfortunately you will have to recreate this PR, like create new, unless you are a git expert and can handle it here.
Basically problem is that you cat your branch from master and not release branch and you are now pushing lots of stuff not related to your PR. We should have only your solace binding related things.
Also to better handle next contribs, we need to let #139 in tomorrow first and this will for sure cause some conflicts in your PR, sorry about that :(

No problem!

Replaced by 143, which branches off the feature branch.


Refactor hasCause tests

Check List:

Unit tests : YES
Javadoc with a code example (API only) : NA

Refactoring of hasCause tests, as promised... I didn't parameters the "passing" ones as there were only 2.

Thanks @goughy000 !


Please respect semantic versioning, 3.4.2 dropped py36 support

I do not think it is unreasonable to expect a bump of at least the minor version when dropping a supported python version (3.6) instead of just releasing a patch.
Not following the semantic versioning, or not doing code reviews is a bad practice that may alienate other consumers.
I would have being enough to version it 3.5.0 or even 4.0.0 as it clearly is a breaking change.
Related:

https://github.com/tox-dev/py-filelock/pull/125
https://github.com/tox-dev/py-filelock/releases/tag/3.4.2

Duplicate of https://github.com/tox-dev/py-filelock/issues/126


SITL Iris: BAT_A_PER_V, 'BAT_V_DIV' missing from parameter list

Sync to latest firmware laster
PX4_SIM_SPEED_FACTOR=2 HEADLESS=1 make px4_sitl_default gazebo_iris
Start QGC, go to Power page
It will report the two param as missing. They are required by QGC power setup to exist.

FactPanelControllerLog: Missing parameter: "1:BAT_A_PER_V"
FactPanelControllerLog: Missing parameter: "1:BAT_V_DIV"

Problems seems to be SITL only. Flash master to a board and the params are there.

Thanks for reporting this Don. Those parameters aren't there because SITL doesn't have analog power input in any form. I can rearrange things to keep it in the build for now.
At a minimum could we maintain a list of parameters QGC expects to exist? Then for optional things we could talk about the appropriate mechanisms to detect.

At a minimum could we maintain a list of parameters QGC expects to exist? Then for optional things we could talk about the appropriate mechanisms to detect.

That's not super easy to do as it currently stands. It just happens randomly. Let me figure out how to re-architect QGC ui so that this becomes obvious. Not going to happen super quick.

I think there is a new stable in RC? If so, this is important for that.

make px4_sitl_nolockstep flightgear_rascal
will shows sensors not calibration and BAT_* parameters missing

@dagar please let me know if this same thing can be applied to what I think is holding up https://github.com/PX4/Firmware/pull/14852
thanks!

Should be fixed by https://github.com/PX4/Firmware/pull/15535.


Flutter Drive Run All Test

In our Flutter application we have multiple integration tests.
I run them one by one by issuing:
flutter drive --target=test_driver/screenshot.dart
However I can't seem to figure out how to run all integration test inside the test_driver folder?
The official documentation does not tell.

I know there is no such thing yet.

We're not going to add this functionality to flutter drive because it is trivially scriptable for CI systems or locally.


Fix for ":noclip" command and improve of the script's readability

Idk why changing the root part cframe.. it was causing the character to repeatly go up and down lol.

We don't like readability in our EISS era scripts.


Fix property key template type

What changes are proposed in this pull request?
Make the template setting the type with the default property creator instead of String type.
Why are the changes needed?
The current template doesn't respect the new property type.
Does this PR introduce any user facing changes?
N/A

alluxio-bot, merge this please

alluxio-bot, cherry-pick this to branch-2.8 please

alluxio-bot, cherry-pick this to branch-2.8 please


Fix logic async gas consumption

Context
When prolog executing query through the logic Ask gRPC query, the prolog predicates are executed in a separate goroutine. In case this goroutine panic we are not able to recover from it, so the https://github.com/okp4/okp4d/pull/312 introduced a change in the gas consumption handling, making the goroutine stop instead of panic. This works on async parts, but may be problematic on synchronous parts.
Description
Since https://github.com/ichiban/prolog/pull/290 released in the v1.1.0 version any panics occurring while executing predicates are recovered and an error is returned back to the interpreter client through the Solutions.Err() func. The panic being recovered, this PR adds a check on gas consumption to panic again with the ErrorOutOfGas error letting the gRPC Ask query handle it.

:tada: This PR is included in version 5.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Infinite scroll rss feed page

Implemented a basic infinity scroll functionality for RSS feeds.

Thanks for your review, @paulschuetz .

If the users scrolls down the list, all posts which were already fetched from
the rss-feed-source will be re-fetched.
Due to certain restrictions regarding the RSS/ATOM specs, the actual fetching cannot be optimized away - unless we accept a loss of generality (see below). But some optimization can be done regarding the widgets state - I will make these changes and create a new pull request.

I would suggest to only fetch the new items and to successively add them to the list of posts,
instead of fetching the whole feed in the rssposts-Future again and again.
Unfortunately, this cannot be done with RSS/ATOM: RSS feeds will, in general, only deliver the n youngest posts. The server software might give the blogger an opportunity to tweak n - or not. But it will, in general, not have any kind of pagination whatsoever (see http://www.rssboard.org/rss-specification ).

This implies: if this RSS feed reader functionality should work with arbitrary RSS/ATOM feeds we will have no choice but to forgo "real" infinity scroll. By RSS/ATOM desing, this simply is not possible. But, we can still give users the impression of such a scroll experience - given that the amount of feed items delivered by the server is sufficiently large. That's what the implementation does right now.


Add 1.25 tags to artifacts docs, include missing commands

Update bundle release number
Adding 1.25 tags to artifacts docs
Include missing commands for directory change, SSH directory, etc

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/cherrypick release-0.14

/approve

/lgtm


Class not found for android

Cordova native settings is not working properly on Android Ionic Apps. When i call any of the page. It throws an error "Class Not Found".
Can anyone have a solution for this?

Which Android version?

Android 7.0

Found out the solution was to remove platform after installing plugin and add the android platform back


Code Inspection: npm audit on cljeditors-index

marked:>=0.3.14 <0.6.2

(warn) Regular Expression Denial of Service Upgrade to version 0.6.2 or later.

marked:0.4.0:

typedoc>marked

[atomist:code-inspection:cljeditors-index=@atomist/atomist-sdm]

Issue closed because branch cljeditors-index was deleted.


UTF8 Symbols not shown on WIN

add_wchar not available
printw work on Linux and Mac, not on Win

Fixed by changing font to one of:
SimSum-ExtB
[15:46]
NSimSun
[15:47]
MSGothic
[15:47]
DejaVu Sans Mono


Game crashes when an Item is attacked

If you happen to attack a tile with an item in it the game crashes.
happened to me when using the whip and a dagger was in a tile past an enemy.
Error AttributeError: 'Dagger' object has no attribute 'alive'
attackaction.py line 32

Summary
This was introduced in 78e05809b949a281a4cf9dc0840dc5d6732801ef and fixed in 50456b4ba9f65a14da436226c427745341ef638e.
Details
I incorrectly introduced a check for target.alive because I was seeing actions being performed on dead creatures. The real issue was I overloaded RatClaws.get_special_action() that did side-effecty stuff but did not return an action. Returning the side effect stuff wrapped in an Action was the correct thing to do here.


Enable prometheus scraping in values.yaml

What would you like to be added?
Add Prometheus annotations to Pods automatically by setting a value in the Helm chart. Something like metrics.prometheus.enabled=true.
Why is this needed?
It's difficult and error-prone to get Prometheus monitoring working with our Helm chart. Users can add annotations to Pods in statefulset.annotations, but I couldn't get the Prometheus Helm chart to find the Pods and scrape the metrics: https://github.com/prometheus-community/helm-charts/tree/main/charts/prometheus#scraping-pod-metrics-via-annotations
If we had a well tested way of integrating with Prometheus, we could provide a switch to enable/disable Prometheus scraping.

I got it working with annotations. The steps are documented here: https://docs.redpanda.com/docs/manage/kubernetes/monitor/#configure-prometheus

I couldn't however get it to work with TLS enabled. It requires configuring tls_config for the Kubernetes Pods: https://github.com/prometheus-community/helm-charts/blob/3f829dc1814913ccad2f444ddfbb45c3e7c67bf5/charts/prometheus/values.yaml#L929

Fixed by #498


Add support for generic @FreeBuilder types

This fixes #1.

As with last time, most of this change is refactoring, which the character-level source test is validating, so you don't need to be excessively paranoid :)

I'm pulling this out of the 1.0 release plan.

Closing for now as we won't be including this in v1 after all.


Subscriptions API

When using streaming sources, such as orbit-firebase (which receives updates in realtime) the query API is lacking because while it provides enough information for a subscription to be established no reference to the subscription is maintained and so there's no way to control it e.g. there's no way to unsubscribe. This is a proposal for an API that would handle this scenario.
Currently queries are performed with:
var results = source.query(queryObject); // results is an object or array

and it's possible to assist or rescue queries to a particular source by registering another source as a handler for each scenario e.g.
memorySource.on('rescueQuery', remoteSource.query);

Sources provide support for queries by implementing the Queryable interface.
A minimal subscriptions API could follow this form with:
var subscription = source.subscribe(queryObject);
var results = subscription.get('results'); // results is an object or array proxy that is updated as changes are streamed over the subscription

subscription.cancel();

In the same way that a query can be rescued a subscription could be rescued with:
memorySource.on('rescueSubscribe', remoteSource.subscribe);

An interface corresponding to Queryable would be introduced, Subscribable with the single method subscribe().

One nice feature of this API is that you could potentially modify a subscriptions query e.g.
var subscription = source.subscribe({type: 'planet', limit: 10});
var results = subscription.get('results'); // results contains 10 records

subscription.modify({limit: 20}); // results has an additional 10 records streamed into it

Subscriptions have been introduced as "live queries" via via #299


Unable to run nintendo64build.sh

I'm at a point where I have libdragon fully setup and have ran libdragon make which successfully creates a "Hello World" ROM, but I can't get the script from this repo to work. I'm not sure if there's some way I need to build out Raylib in this instance, but any help would be appreciated. The error mentions mips6-elf-gcc is not found, though I thought that's what the package I installed was for? It's not in the libdragon/bin folder, and I'm not sure how to get it there since I don't have it, if it even matters.

I am using libdragon unstable
N64_INST=/opt/libdragon
I have installed gcc-toolchain-mips64-x86_64 with dpkg
I have already ran apt update and installed build-essential
I doubt it matters, but I'm running this on Linux Mint through VMware Workstation. It was setup fresh to test this today.

+ make PLATFORM=PLATFORM_NINTENDO64
/opt/libdragon/bin/mips64-elf-gcc -c rcore.c -march=vr4300 -mtune=vr4300 -I/opt/libdragon/mips64-elf/include -falign-functions=32    -ffunction-sections -fdata-sections -g -ffile-prefix-map="/home/zen/Desktop/libdrago/raylib4Nintendo64/raylib/src"= -ffast-math -ftrapping-math -fno-associative-math -DN64 -O2 -Wall  -Wno-error=deprecated-declarations -fdiagnostics-color=always -Wno-error=unused-variable -Wno-error=unused-but-set-variable -Wno-error=unused-function -Wno-error=unused-parameter -Wno-error=unused-but-set-parameter -Wno-error=unused-label -Wno-error=unused-local-typedefs -Wno-error=unused-const-variable -std=gnu99 -Wno-error=incompatible-pointer-types -DPLATFORM_NINTENDO64 -DGRAPHICS_API_OPENGL_11  /opt/libdragon/mips64-elf/include
/bin/sh: 1: /opt/libdragon/bin/mips64-elf-gcc: not found
make: *** [Makefile:873: rcore.o] Error 127
+ make PLATFORM=PLATFORM_NINTENDO64 install
mkdir -p /opt/libdragon/mips64-elf/lib
mkdir -p /opt/libdragon/mips64-elf/include
cp --update --verbose ../src/libraylib.a /opt/libdragon/mips64-elf/lib/libraylib.a
cp: cannot stat '../src/libraylib.a': No such file or directory
make: *** [Makefile:970: install] Error 1

Figured it out - with this being my first time using Docker I didn't realize that I needed to run the script from within the container. For anyone with this issue in the future, I used libdragon start to get the container ID(?), then ran docker exec -it <containerID> bash to get into it, then it worked fine.


restic: allow prune without backup

Motivation for this change
fixes #97820
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I know this has been sitting dormant for a while (from before I even had commit access!), but could I also ask you to add a test for this to the restic test(s) in nixos/tests/restic.nix?

Done, thanks for the suggestion!  :)


Function has_extension() doesn't understand field name

Hello! I don't know if there is a bug or feature.
I got files extend.proto and extensions.proto from the test/erlang_protobuffs_SUITE_data/ directory.
Then I scaned file:
protobuffs_compile:scan_file("extend.proto").

Then I ran test:
extension_test() ->
    Message0 = #extendable{},
    {ok, Message1} = extend_pb:set_extension(Message0, bar, 25),

    ?assertEqual(1, extend_pb:extension_size(Message1)),
    ?assertEqual({ok, 25}, extend_pb:get_extension(Message1, bar)),
    ?assert(extend_pb:has_extension(Message1, bar)),    %% <<< Why does it return false?!
    ok.

Test fails in last assert.
I checked extend_pb.erl. It contains:
    ...
    has_extension(#extendable{'$extensions' = Extensions},
              bar) ->
        dict:is_key(bar, Extensions);
    ...
    set_extension(#extendable{'$extensions' = Extensions} =
              Record,
              bar, Value) ->
        NewExtends = dict:store(126,
                    {optional, Value, sint32, none}, Extensions),
    {ok, Record#extendable{'$extensions' = NewExtends}};
    ...

In function has_extension() it tries to search for atom key in the dictionary.
But set_extension() inserts only numeric key in dictionary.
It seems to me it's bug in the code generator.

FYI, this project (erlang_protobuffs) is no longer actively maintained. Please use gpb instead. gpb has erlang_protobuffs compatibility and is actively maintained by @tomas-abrahamsson


PackageId:CPython39.Exe.x64;PackageAction:DownloadPackage;ReturnCode:0x80072ee2;

This issue has been moved from a ticket on Developer Community.

[severity:I'm unable to use this version]
在此处描述你的问题
===DO NOT EDIT BELOW THIS LINE===
PackageId:CPython39.Exe.x64;PackageAction:DownloadPackage;ReturnCode:0x80072ee2;

Original Comments
Feedback Bot on 12/4/2022, 04:53 PM:
(private comment, text removed)
Graham Wheeler [MSFT] on 12/14/2022, 02:54 PM:
(private comment, text removed)

Original Solutions
(no solutions)

Hi there, please see https://learn.microsoft.com/en-us/visualstudio/python/installing-python-support-in-visual-studio?view=vs-2022#troubleshooting and reopen the ticket if it doesn't resolve your issue. Thanks!


Context3D not available! Possible reasons: wrong renderMode or missing device support.

I'm getting this error when working with Starling Framework.
I get this error when i run my .swf file.
I setup all necessary things in my project to work with Starling Framework.
this is my asconfig.json file:
{
	"config": "air",
	"compilerOptions": {
		"source-path": [
			"src",
		],
		"output": "bin/Spacer1.swf",
		"use-direct-blit": true
	},
	"application": "src/Spacer-app.xml",

	"files": [
		"src/Spacer.as"
	],

	"airOptions": {	}
}

Here, "use-direct-blit": true
I found this on documentation file which tells that this sets wmode value to "direct". but, after making it true, it also not works. I'm facing the same problem again and again :(
I also set renderMode to "direct" in my app.xml file. Here is my app.xml file:
<?xml version="1.0" encoding="utf-8" ?>
<application xmlns="http://ns.adobe.com/air/application/32.0">
	<id>com.hii22.Spacer</id>
	<versionNumber>0.0.0</versionNumber>
	<filename>Spacer</filename>
	<name>Spacer</name>
	<initialWindow>
		<content>[Path to content will be replaced by Visual Studio Code]</content>
		<visible>true</visible>
                <renderMode>direct</renderMode>
	</initialWindow>
</application>

Screenshot:

Closing due to inactivity. However, you can still leave a comment and I will be notified.


Fix composer dump autoload issue on fresh installation

There was a commer after the last parameter of str_replace() on line 63 this affect composer autoload to complete after instalation
Thanks.

This has no effect on composer.


Bluetooth: Controller: Fix missing reset of coded PHY scanning

When switching from Extended Scanning by Extended
Advertising HCI commands back to Legacy Scanning after a
HCI reset it is required that the coded PHY scanning
context is reset.
Signed-off-by: Vinayak Kariappa Chettimada<EMAIL_ADDRESS>

@cvinayak can you please address this?


Make frontend parsing more robust to incomplete JSON

Motivation and Context
Attempt to resolve #596 and #579 by making the frontend more robust to incomplete JSON messages during streaming.

Description
Use a running string to assemble parse-able JSON when reading in the chat response.

Contribution Checklist

[x] I have built and tested the code locally and in a deployed app
[x] For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
[x] This is a change for all users of this app. No code or asset is specific to my use case or my organization.
[x] I didn't break any existing functionality :smile:

Hello,
Thanks a lot for the contribution. I struggled with this and your PR came at the exact right time I needed it.
I juste want to say that I, maybe, spotted a little mistake in the condition in the catch block of the JSON.parse.
The commited code is :
if (e !instanceof SyntaxError) {
    console.error(e);
    throw e;
} else {
    console.log("Incomplete message. continuing")
}

Shouldn't be something like (condition) :
if (!(e instanceof SyntaxError)) {
    console.error(e);
    throw e;
} else {
    console.log("Incomplete message. continuing")
}

Thanks again!

Thanks @HamzaAssouane - fixed accordingly!


Error in running demo.py

When running in the CPU only tensorflow environment, I have met a problem.  The instruction is
python demo.py --input_image data/demo.png
And finally get the error information
'''
INFO Restoring parameters from RUNS/KittiSeg_pretrained/model.ckpt-15999
terminate called after throwing an instance of 'std::bad_alloc'
what():  std::bad_alloc
Aborted (core dumped)
'''
Since my server hasn't got a GPU, and I want to apply the model for testing, and I won't use the train part, is it able to apply it with CPU-only?

this maybe caused by your computer's RAM is not enough.


{Packaging} Build RPM with Mariner 2.0 image

Description
According to the mail conversation, Mariner 1.0 is a little outdated. Mariner 2.0 is latest. As public access to cblmariner2preview.azurecr.io has been granted, we should be able to access Mariner 2.0 anonymously.
Email: Use Mariner 2.0 to build Azure CLI

Packaging


General: Permit deploying from contract type

Overview
Right now, we can only deploy from an account.
Like brownie, we want to also be able to support deploying from a contract type
Specification
from ape import project
from ape import accounts

me = accounts.load("me")
contract = project.MyContract.deploy(sender=me)  # <--- new syntax

Dependencies
Include links to any open issues that must be resolved before this feature can be implemented.

Not all ecosystems require an account to deploy!
Bumps.


Rename to feathers-authentication-hooks

As discussed, most these hooks will be part of the Auk release so they are not really legacy.

:shipit:


All resource groups show in the "Resources" tree view after refreshing it

OS: M1 & Win10
Azure Resource Extension Build Version: 20220522.1
Repro Steps:

Make sure the resource groups by Resource Group.
Click the "Focus this Group" icon to focus a resource group -> Refresh "Resources" tree view.
Check whether the focused resource group shows in the "Resources" tree view.

Expect:
Only the focused resource group shows in the "Resources" tree view.

Actual:

All resource groups show in the "Resources" tree view.
The icon of the previous focused resource group still is "Unfocus Group".

We should fix this before //Build. Focusing on groups is one of our highlight features.

It's happening because the focusedGroupId is different from the id of the tree item after refreshing. The easiest solution might be to just use regex to ignore the resourceGroups part. This only reproduces with resource groups.
Example focusedGroupId: /subscriptions/570117a0-fe37-4dfe-ae48-b692c1b25f70/resourceGroups/angular-basic-dotnet
Example tree item id: /subscriptions/570117a0-fe37-4dfe-ae48-b692c1b25f70/angular-basic-dotnet

Does the grouping (i.e. the /resourceGroups) need to be in the focusedGroupId?

Does the grouping (i.e. the /resourceGroups) need to be in the focusedGroupId?

is there any reason the focusedGroupId should ever be different from the tree ID?

It shouldn't ever be different. I'm not sure why the tree ID is different after refreshing. That is the root cause. I'm a bit wary of changing how we generate tree IDs at this point.
https://github.com/microsoft/vscode-azureresourcegroups/compare/main...alex/focus-refresh might be the simplest solution. Not pretty, but it shouldn't break anything else.

Is the tree ID changing, or is the focusedGroupId just incorrect?

Ah, actually it was because we are using Object.values when we should have been using the focusedGroupId as a key.
I've updated the PR to show what I mean https://github.com/microsoft/vscode-azureresourcegroups/compare/main...alex/focus-refresh


Error handling UX

error popup for all unhandled exceptions
maintenance page to be only switched on when we make migration
reuse popup/modals from wordbazaar
error send endpoint documented here

PR #1027


[BREAKINGCHANGE] Upgrade to React 18.2.0

Description
Upgrade all package to React 18
Checklist

[x] Pull request has a descriptive title and context useful to a reviewer.
[x] Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, IGNORE.
[x] All commits have DCO signoffs.

UI Changes

[x] Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
[x] Code follows the UI guidelines.
[x] Visual tests are stable and unlikely to be flaky. See Storybook and e2e docs for more details. Common issues include:

Is the data inconsistent? You need to mock API requests.
Does the time change? You need to use consistent time values or mock time utilities.
Does it have loading states? You need to wait for loading to complete.

@Gladorme Unfortunately I think it might break some components for us. Is there a strong reason why we should change the useId hook already provided by perses components package?

@jgbernalp No strong reasons, I saw we had some warnings about deps vulnerability and I wanted to update of our deps. I know we had an topic about React 17 -> React 18, so I started by this 😄
Let's put in standby for now

@jgbernalp is it still not ok to drop the support of react v17 ?

@Nexucis unfortunately yes. We still depend on react 17 for dynamic plugins on the OpenShift console, this is to add support for Perses dashboards to web consoles for older OpenShift versions. But we can make an assessment of the impact once we have the console plugin ready for distributed tracing and revisit this PR.

let's close this PR.
When we will be able to make the upgrade there will be more changes anyway. So this PR cannot be merged just like that.


Added GPT Vision Support to Telegram Bot

Reference issue #390
This PR introduces the integration of GPT Vision into existing Telegram bot. With this update, the bot is now capable of describing images based on user inputs, leveraging the power of OpenAI's GPT Vision model.
Changes include:

Added new model.
Integrated GPT Vision API calls within the bot's message handling logic.

Usage:

Send a plain and compressed photo to the chat, don't forget to put a proper caption to it.
Wait for the response.
Profit!

Please review and provide any feedback.

I was testing this branch but I'm unable to make it work.
It returns the message"
Something went wrong during completion. Reason: local variable 'n_input_tokens' referenced before assignment
```.

Removing the exception capture:

Traceback (most recent call last):
File "/usr/local/lib/python3.8/site-packages/telegram/ext/_application.py", line 1184, in process_update
await coroutine
File "/usr/local/lib/python3.8/site-packages/telegram/ext/_basehandler.py", line 141, in handle_update
return await self.callback(update, context)
File "/code/bot/handlers.py", line 53, in wrapper
return await func(update, context, *args, **kwargs)
File "/code/bot/handlers.py", line 62, in wrapper
return await func(update, context, *args, **kwargs)
File "/code/bot/handlers.py", line 596, in message_handle
await task
File "/code/bot/handlers.py", line 53, in wrapper
return await func(update, context, *args, **kwargs)
File "/code/bot/handlers.py", line 62, in wrapper
return await func(update, context, *args, **kwargs)
File "/code/bot/handlers.py", line 171, in _message_handle_fn
async for gen_item in gen:
File "/code/bot/openai_utils.py", line 270, in send_message_stream
n_input_tokens,
UnboundLocalError: local variable 'n_input_tokens' referenced before assignment

Any idea what it could be?

I have taken a look at your changes, but I have no idea what could be producing that error.

Do you want to start a fork of this bot that we can maintain? I don't like how unresponsive the original author is.

Would be nice, but I do not have much spare time. Sorry
El lun, 11 dic 2023 a las 8:22, Henry van Megen @.***>)
escribió:

Do you want to start a fork of this bot that we can maintain? I don't like
how unresponsive the original author is.
—
Reply to this email directly, view it on GitHub
https://github.com/father-bot/chatgpt_telegram_bot/pull/404#issuecomment-1849460029,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAYWPGG6JYMNERN5YDQY26DYI2YFDAVCNFSM6AAAAAA73BPNUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBZGQ3DAMBSHE
.
You are receiving this because you commented.Message ID:
@.***>

I'm good with our own fork of it. But not sure how else can we improve the bot :)

Something went wrong during completion. Reason: Unknown model: gpt-4-vision-preview
I don't think it's working

Something went wrong during completion. Reason: Unknown model: gpt-4-vision-preview
I don't think it's working

Thank you for your message.
Can you please clarify how did you set up your environment?

I have clone this branch
https://github.com/ArtemStepanov/gpt4_vision_telegram_bot/tree/feat/gpt-vision
And I have setup by running docker-compose as usual, but it’s not working.
When I try to add gpt-4-vision-preview in array that cause this error, it
returns new error message:
Something went wrong during completion. Reason: expected string or buffer
On Sat, 23 Dec 2023 at 00:14 Artem Stepanov @.***>
wrote:

Something went wrong during completion. Reason: Unknown model:
gpt-4-vision-preview
I don't think it's working
Thank you for your message.
Can you please clarify how did you set up your environment?
—
Reply to this email directly, view it on GitHub
https://github.com/father-bot/chatgpt_telegram_bot/pull/404#issuecomment-1867910926,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANAKT5GGPDMIBRNQFEBQ7MDYKW5Y7AVCNFSM6AAAAAA73BPNUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRXHEYTAOJSGY
.
You are receiving this because you commented.Message ID:
@.***>


Searching doesn't work on linux

Describe the bug
Search in logs via xterm doesn't work due to
chunk-DSUIPI7G.js?v=bde2e788:10628 Uncaught Error: You must set the allowProposedApi option to true to use proposed API
    at d._checkProposedApi (@xterm_xterm.js?v=bde2e788:5944:79)
    at d.registerDecoration (@xterm_xterm.js?v=bde2e788:6064:25)
    at n._createResultDecoration (@xterm_addon-search.js?v=bde2e788:322:27)
    at n._highlightAllMatches (@xterm_addon-search.js?v=bde2e788:145:31)
    at n.findNext (@xterm_addon-search.js?v=bde2e788:133:168)
    at handleFindNext (LogViewer.tsx:303:29)
    at handleInputKeyDown (LogViewer.tsx:333:9)
    at HTMLUnknownElement.callCallback2 (chunk-DSUIPI7G.js?v=bde2e788:10552:22)
    at Object.invokeGuardedCallbackDev (chunk-DSUIPI7G.js?v=bde2e788:10577:24)
    at invokeGuardedCallback (chunk-DSUIPI7G.js?v=bde2e788:10611:39)

To Reproduce
Steps to reproduce the bug:

Go to pods
Select a pod
Navigate logs and try to search
There error is in the console.

Environment (please provide info about your environment):

dev installation via npm start

Are you able to fix this issue?
Yes (I will propose a PR)

Do you want to help fix this issue? Please see our contribution docs. For any non-trivial contributions, we advise you to join our our slack channel to discuss the implementation with Headlamp's core developers.

Additional Context
I tried one solution, and it's working now.
https://github.com/xtermjs/xterm.js/blob/41e8ae395937011d6bf6c7cb618b851791aed395/src/browser/public/Terminal.ts#L67
https://github.com/xtermjs/xterm.js/blob/41e8ae395937011d6bf6c7cb618b851791aed395/src/common/services/OptionsService.ts#L43

Thanks @veyselsahin . We will take a look.


How to transpile external dependency in angular-cli?

I have an angular-cli application and i use Angular IMask Plugin. Angular IMask Plugin wraps vanila imaskjs which has "package.module" in es2015 format alongside with "package.main" in es5 umd format. While building angular-cli takes "package.module" but does not transpile it with babel and therefore my app does not work in IE.
How can i configure angular-cli to include imaskjs to be transpiled? It could be solved in webpack like this But what about angular-cli? Is eject is the only solution?
Is it ok to distribute "package.module" in es2015 format for libraries or it should be in es5 as well?
Angular CLI: 1.6.4
Node: 7.10.0
OS: win32 x64

Libraries that are meant to support older browser versions should ship both ES2015 and ES5 code. And it will be up to the build system to determine which on to use.
See https://docs.google.com/document/d/1CZC2rcpxffTDfRDs6p1cfbmKNLA6x5O-NtkJglDaBVs/preview#heading=h.k0mh3o8u5hx for more details.

@alan-agius4 I agree that libraries should ship transpiled code so they are usable in older browsers, but I've run into quite a few that do not. (And at least one prominent maintainer has a policy of not providing transpiled code.)
It's painful to have to maintain and package a fork or copy-paste source code into the consuming project. It would be nice if Angular CLI could assist somehow, even if some manual configuration per library is required.

I think its an unreasonable expectation that library maintainers provide multiple builds to cater to all environments. As @alan-agius4 pointed out, some maintainers have taken a stance against this needless complexity by distributing only a single library build. The purpose of our tooling (i.e. the bundler) is to isolate us complexity and increase productivity. Supporting transpilation of dependencies would really be helpful.


Update dependencies

In preparation for release later this week.
I have verified this PR works with

[ ] Online form submission
[ ] Offline form submission
[ ] Saving offline drafts
[ ] Loading offline drafts
[ ] Editing submissions
[ ] Form preview
[ ] None of the above

What else has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
I decided to switch over to @cypress/request to address security issue. Cypress' fork is mentioned in the Dependabot report for those.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
I did bump vite and vite-node major versions which carries some risk. I reviewed vite's breaking changes and nothing looked concerning. I think if there were significant issues the build would just not work.
Do we need any specific form for testing your changes? If so, please attach one.

There's been some kind of change in behavior in node between 20.5.1 and 20.12.2 that results in string values that end in a number preceded by a non-alphanumeric character passed to date() to convert to true in the invalid dates test.
date(opv_3) is now failing. So do date(opv 3) or date(opv.3) but not date(opv3).
I see that the first three are being evaluated to 2001-03-01. date(afdf_4) evaluates to 2001-04-01. date(jkfdk_32) evaluates to 2032-01-01.
I can see that in asDate from openrosa-extensions all of these values get passed to new Date().


how to get related commits of pytorch/pytorch and pytorch/functorch ?

For some reason, i need to install newest pytorch/functorch from sources. but i don't know the related pytorch/pytorch newest source. if the pytorch/pytorch and pytorch/functorch is not compatible, functorch will not work. how i get a newest relative pair of pytorch/pytorch commit and pytorch/functorch commit ?
does pytorch/functorch only match the released or nightly version of pytorch/pytorch?

@GipsonLeo The main branch of pytorch/functorch matches the nightly version of pytorch/pytorch.
If you're using PyTorch 1.10.1, you can install it like so: https://github.com/pytorch/functorch#locally-1
@zou3519 I remember we have some wheels now, can that replace installing from functorch from source?

i'm  using PyTorch 1.11, the newest ( unreleased ).  how to build a nightly version of pytorch/pytorch from source?  :)

is there a url about functorch wheels like this (torch wheels):  https://download.pytorch.org/whl/nightly/cpu/torch_nightly.html

The functorch main branch is guaranteed to work with the latest PyTorch nightly binary. You can install the latest nightly (which is version 1.11) by choosing one of the following lines:
# For CUDA 10.2
pip install --pre torch -f https://download.pytorch.org/whl/nightly/cu102/torch_nightly.html --upgrade
# For CUDA 11.1
pip install --pre torch -f https://download.pytorch.org/whl/nightly/cu111/torch_nightly.html --upgrade
# For CPU-only build
pip install --pre torch -f https://download.pytorch.org/whl/nightly/cpu/torch_nightly.html --upgrade

and then installing functorch from source (see https://github.com/pytorch/functorch#installing-functorch-main).


Java indexer: add --ignore_vname_paths flag to fix graph cohesion for small projects [phab:D522]

Created by schroederc at 2015-09-21 22:06:45:
This change also reverts a prior deletion of the JCommander third_party
library and uses it to reimplement the configuration parsing for each
Java indexer binary.

shahms accepted this revision at 2015-09-21 22:12:43

schroederc closed via commit f20093f567773e7cfbea479dd095b895ae406c56 at 2015-09-21 22:17:28


Add support for scaling fees for objective values

We had previously discussed using the solver's fee_factor parameter to scale fees when computing objective values. It was meant as a way to avoid negative objective values and promote more aggressive merging of single order settlements.
Now that we have a full_fee_amount, the existing fee_factor can no longer be used for this purpose, so this PR introduces a new fee_objective_scaling_factor. Furthermore, I noticed that the fee being given to the MIP/Quasimodo solver was the original fee amount, and not the unsubsidized fee amount meaning that it wasn't getting the fee amount that was used for the objective value, putting it at a disadvantage. This required changing the LimitOrder type to pipe the scaled unsubsidized amount for orders to the HTTP solver.
Test Plan
Added unit test to check unsubsidized fee scaling logic.

Didn't think about this in detail but I thought we would add a factor to the objective value computation. Whereas here we are changing the input order data. Any preference? Or is it necessary to do it this way?


Add execution engine step and a generic build operation for work execution

In build scans, we want to capture more information about artifact transform executions, which are executed as work in the execution engine. We are starting with capturing the outcome of the execution of individual transform executions.
Artifact transforms make use of an identity cache. The cache is used immediately after the identify step to short-curcuit the execution pipeline.
A new ExecuteWorkBuildOperationFiringStep step is added after the identity cache step to capture the part of the execution that actually includes input snapshotting and the rest of the pipeline. The step emits a new ExecuteWorkBuildOperationType operation. The operation's result contains a skipMessage detailing a reason why an execution have been avoided (NO-SOURCE, FROM-CACHE, UP-TO-DATE). The message is mapped from the execution engine's outcome.

[x] Javadocs
[x] Tests for skipMessage

@bot-gradle test this

I've triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

I've triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

I've triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test and merge

I've triggered a build for you. Click here to see all failures if there's any.


Load all pages at once in memory

I used PDFDocument.fromURL(url) to load the document and view using PDFViewer(document:document).
Now, when I try to move to another page, it loads the next/previous page asynchronously every time I move to a new page and shows a CircularProgressIndicator for that period.
To provide a better user experience, you should load all the pages at once or load 3-4 pages next and previous to the current page in advance, so the user doesn't have to wait while moving between pages.

I agree with this 100%. @CrossPT, and plans for this? I'd be happy to help if needed.

100% agree for sure, it will be painful for me to read 9 pages and i have to wait for a several seconds to go to the next page


Unable to parse Sass (.scss)

Unable to get Webpack 2.2.1 to parse a .scss file
I'm not sure what's going on with these loaders. I'm following the setup guide and getting module parsing errors for some reason. I can get the CSS-Loader to work but when it comes to sass the provided plugins aren't working. What am I doing wrong in this setup?
package.json
...
"devDependencies": {
  "css-loader": "^0.26.1",
  "extract-text-webpack-plugin": "^2.0.0-rc.3",
  "favicons-webpack-plugin": "0.0.7",
  "html-webpack-plugin": "^2.28.0",
  "node-sass": "^4.5.0",
  "sass-loader": "^6.0.2",
  "style-loader": "^0.13.1",
  "webpack": "^2.2.1"
},
...

Structure:
/webpack-demo
  /app
    /assets
      /stylesheets
        test-style.css
        test-style.scss
    index.js

test-style.css:
a {display: flex;}
test-style.scss:
a{display: flex;}
index.js
import './assets/stylesheets/test-style.scss';
import _ from 'lodash';

function component () {
  var element = document.createElement('div');

  /* lodash is required for the next line to work */
  element.innerHTML = _.join(['Hello','webpack', 'what up breh'], ' ');

  return element;
}

document.body.appendChild(component());

webpack.config.js
const path = require('path');
let HtmlWebpackPlugin = require('html-webpack-plugin');
let FaviconsWebpackPlugin = require('favicons-webpack-plugin');
const ExtractTextPlugin = require("extract-text-webpack-plugin");
module.exports = {
  entry: './app/index.js',
  output: {
    filename: 'bundle.js',
    path: path.resolve(__dirname, 'dist')
  },
  module: {
    rules: [{
        test: /\.scss$/,
        //use: ['style-loader', 'css-loader']
        use: ExtractTextPlugin.extract({
          fallback: "style-loader",
          //use: "css-loader"
          use: ['css-loader', 'sass-loader']
        })
    }]
  },
  plugins: [
    new HtmlWebpackPlugin(),
    new FaviconsWebpackPlugin('./app/images/me.png'),
    new ExtractTextPlugin('./assets/stylesheets/styles.css')
  ]
};

Errors:
ERROR in ./~/sass-loader/lib/loader.js!./app/assets/stylesheets/test-style.scss
Module parse failed: /Users/steve_fuller/development/react-tutorials/webpack-demo/node_modules/sass-loader/lib/loader.js!/Users/steve_fulle
r/development/react-tutorials/webpack-demo/app/assets/stylesheets/test-style.scss Unexpected token (1:2)
You may need an appropriate loader to handle this file type.
| a {
|   display: flex; }
|
 @ ./app/assets/stylesheets/test-style.scss 4:14-92
 @ ./app/index.js

/Users/steve_fuller/development/react-tutorials/webpack-demo/node_modules/sass-loader/lib/loader.js!/Users/steve_fulle
r/development/react-tutorials/webpack-demo/app/assets/stylesheets/test-style.scss Unexpected token (1:2)

@wsfuller Seems lika Syntax Error in test-style.scss missing . before a (ClassSelector)
a {} => .a {}

But I wonder still, bc it should work, sass-loader seems to be executed nevertheless

The intent was to purposely apply that to the anchor tag. I would run this through Gulp and the lib-sass compiler, the only reason is to then test autoprefixer and make that is working since the display property needs vendor prefixes and easy to write.
I've added:
{
  test: /\.scss$/,
  loader: ExtractTextPlugin.extract({
    fallback: "style-loader",
    use: "css-loader!sass-loader",
  }),
}

And that is working as expected. The starter documentation isn't really getting me in a good spot to start working imo. Like to troubleshoot to understand as much as the next person but the way Webpack works has been interesting to say the least.

I understand :), this maybe related SASS Loader #372. Could you please post your issue there aswell, maybe sass-loader recently introduced a bug somwhere. Thx in advance 👍 💯

You got it, posted answer on that issue.

I seem to be facing this issue as well. The solution posted so far is to use the string form of stacked loaders... "css-loader!sass-loader"... which, reading the code gets transformed into [{loader: 'css-loader'},{loader:'sass-loader'}].  I'm a little at a loss here.
{
    test: /\.(s?)css$/,
    use: ExtractTextPlugin.extract({
        fallback: 'style-loader',
        use: [
            {
                loader: 'css-loader',
                options: {
                    sourceMap: true
                }
            },
            {
                loader: 'postcss-loader',
                options: {
                    sourceMap: 'inline',
                    plugins: () => [
                        autoprefixer({ browsers: ['> 1% in US', 'last 2 versions', 'iOS > 8'] })
                    ]
                }
            },
            {
                loader: 'resolve-url-loader'
            },
            {
                loader: 'sass-loader',
                options: {
                    sourceMap: true
                }
            }
        ]
    })
}

I think I miss-read the solution... was it adding an additional loader rule for /.scss$/? :/

I'm starting to wonder if the test expression is no longer working (was in v1). The regexp matches both '.scss' and '.css'.

Could very well be, know there has been a lot going on behind the scenes. I haven't read all the way through this https://github.com/webpack/webpack/issues/2797 but you can take a look through and see if it leads to any answers. The elephant in the room is to try and find a balance of low versus high level setup and trying to standardize the tool since everyone has a different spin on their configurations because the tool is so open.

ah, i believe the problem is the use of the property use: .... The working examples have loader: .... I will have to test to verify, but i've seen other hints that this is the key.

Both use and loaders should be valid syntax. Looking back over your code could you try to make loaders plural? Just want to eliminate that being a possibility as well. Watching a very good series that was crated in 02/17 that's going through some explanations. YouTube: Webpack 2 - Style, CSS and Sass loaders

Based on @bebraw 's comment here on webpack/webpack#2797 , I believe my problem is the use of the plural properties (use/loaders) and needs to be the singular loader property.

Update: my extract text config works on scss files when my js files import scss files explicitly. eg:
import './main.scss';

export default class Main ...

but I also have a convention pre-loader that adds imports to scss files that match component file names using the baggage-loader. eg: Button.js auto imports Button.scss. These imports are failing to go through my loader rules. :/

Found it. The baggage-loader was erroneously prefixing '!' to the require :/

wasted quite a bit of time on this. Having to import the scss is rather unintuitive and not mentioned in the docs

Note to @webpack-contrib/org-maintainers - Once this has been worked out, review the documentation around the issue for clarity.

I should reiterate, my issue was from an error in another loader (baggage-loader) that auto-imports files based on convention. (it was bypassing loaders for files it included by prefixing the request with "!")
When I imported sass files explicitly, things worked fine with the config i posted above.

@d3viant0ne It's literally one of the first sentences at the documentation: "It moves all the require("style.css")s in entry chunks into a separate single CSS file. So your styles are no longer inlined into the JS bundle, but separate in a CSS bundle file (styles.css). If your total stylesheet volume is big, it will be faster because the CSS bundle is loaded in parallel to the JS bundle.".
That said, if someone wants to clean that up, PR is welcome.
Time to close this issue.

Yeah, I just read through it. It's clear enough for me :)


Added tap functionality in the contributiongraph

with an optional delegate to return the date and value of the tapped
location

Hi, thank you so much for your contribution! Could you avoid unnecessary reformatting and conform to my original coding style?

Thank you!

thank you for the library :+1:


Bring dependencies to source-stable versions

Some official projects are using source-stable dependencies while some are not. Bringing all to 1.x.y avoids dependency resolution conflicts.
Checklist

[x] I've read the Contribution Guidelines
[x] My contributions are licensed under the Swift license.
[x] I've followed the coding style of the rest of the project.
[ ] I've added tests covering my changes (if appropriate).
[x] I've verified that my change compiles and works correctly, and does not break any existing tests.
[ ] I've updated the documentation (if appropriate).

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci test


Smart Bulbs appearing in homebridge even though added directly to homekit

Model number: MSL120D
Probably just needed to be added to the list of models which can be directly added to homekit.

Hi @JaiR236 please let me know which hardware version you have of this model

7.0.0

Thank you. New beta should remove this device:
https://github.com/bwp91/homebridge-meross/wiki/Beta-Version