Linking ext on Windows Python 3.5 do not quote libpath params

Hi.
I have a problem to link an extension from a project.
LINK : fatal error LNK1181: cannot open input file 'Files.obj'
It fail with python 3.5 and setuptools > 23 (all versions of branch 24 and 25 fail).
Here it fail
(venv) >pip list
cycler (0.10.0)
Cython (0.24.1)
fabio (0.4.0)
h5py (2.6.0)
lxml (3.6.0)
matplotlib (1.5.1)
numpy (1.11.1+mkl)
Pillow (3.3.0)
pip (8.1.2)
pyparsing (2.1.5)
python-dateutil (2.5.3)
pytz (2016.6.1)
scipy (0.17.1)
six (1.10.0)
wheel (0.29.0)

(venv) >pip install setuptools
Collecting setuptools
  Using cached setuptools-25.1.0-py2.py3-none-any.whl
Installing collected packages: setuptools
Successfully installed setuptools-25.1.0

(venv) >python setup.py build
running build
running build_py
running build_ext
No module named 'numpy.distutils._msvccompiler' in numpy.distutils; trying from
distutils
building 'pyFAI.ext.splitPixelFullCSR' extension
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\x86_amd64\cl.exe /c /
nologo /Ox /W3 /GL /DNDEBUG /MD -IpyFAI\ext\include -IpyFAI\ext -IC:\Users\valls
\pyFAI_venv\lib\site-packages\numpy\core\include -Ic:\python35-amd64\include -Ic
:\python35-amd64\include -I"C:\Program Files (x86)\Microsoft Visual Studio 14.0\
VC\INCLUDE" -I"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\INC
LUDE" -I"C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\ucrt" -I"C:
\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\include\um" -I"C:\Program Files
 (x86)\Windows Kits\10\include\10.0.10586.0\shared" -I"C:\Program Files (x86)\Wi
ndows Kits\10\include\10.0.10586.0\um" -I"C:\Program Files (x86)\Windows Kits\10
\include\10.0.10586.0\winrt" -I"C:\Program Files (x86)\Microsoft Visual Studio 1
4.0\VC\INCLUDE" -I"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC
\INCLUDE" -I"C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\ucrt" -
I"C:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\include\um" -I"C:\Program F
iles (x86)\Windows Kits\10\include\10.0.10586.0\shared" -I"C:\Program Files (x86
)\Windows Kits\10\include\10.0.10586.0\um" -I"C:\Program Files (x86)\Windows Kit
s\10\include\10.0.10586.0\winrt" /TcpyFAI\ext\splitPixelFullCSR.c /Fobuild\temp.
win-amd64-3.5\Release\pyFAI\ext\splitPixelFullCSR.obj /openmp
Found executable C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\x86_
amd64\cl.exe
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\x86_amd64\link.exe /n
ologo /INCREMENTAL:NO /LTCG /DLL /MANIFEST:EMBED,ID=2 /MANIFESTUAC:NO /LIBPATH:c
:\python35-amd64\Libs /LIBPATH:C:\Users\valls\pyFAI_venv\libs /LIBPATH:C:\Users\
valls\pyFAI_venv\PCbuild\amd64 /LIBPATH:C:\Program Files (x86)\Microsoft Visual
Studio 14.0\VC\LIB\amd64 /LIBPATH:C:\Program Files (x86)\Microsoft Visual Studio
 14.0\VC\ATLMFC\LIB\amd64 /LIBPATH:C:\Program Files (x86)\Windows Kits\10\lib\10
.0.10586.0\ucrt\x64 /LIBPATH:C:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\
lib\um\x64 /LIBPATH:C:\Program Files (x86)\Windows Kits\10\lib\10.0.10586.0\um\x
64 /LIBPATH:C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\LIB\amd64 /LI
BPATH:C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\LIB\amd64 /L
IBPATH:C:\Program Files (x86)\Windows Kits\10\lib\10.0.10586.0\ucrt\x64 /LIBPATH
:C:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\lib\um\x64 /LIBPATH:C:\Progr
am Files (x86)\Windows Kits\10\lib\10.0.10586.0\um\x64 /EXPORT:PyInit_splitPixel
FullCSR build\temp.win-amd64-3.5\Release\pyFAI\ext\splitPixelFullCSR.obj /OUT:bu
ild\lib.win-amd64-3.5\pyFAI\ext\splitPixelFullCSR.cp35-win_amd64.pyd /IMPLIB:bui
ld\temp.win-amd64-3.5\Release\pyFAI\ext\splitPixelFullCSR.cp35-win_amd64.lib
Found executable C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\x86_
amd64\link.exe
LINK : fatal error LNK1181: cannot open input file 'Files.obj'
error: Command "C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\x86_a
md64\link.exe /nologo /INCREMENTAL:NO /LTCG /DLL /MANIFEST:EMBED,ID=2 /MANIFESTU
AC:NO /LIBPATH:c:\python35-amd64\Libs /LIBPATH:C:\Users\valls\pyFAI_venv\libs /L
IBPATH:C:\Users\valls\pyFAI_venv\PCbuild\amd64 /LIBPATH:C:\Program Files (x86)\M
icrosoft Visual Studio 14.0\VC\LIB\amd64 /LIBPATH:C:\Program Files (x86)\Microso
ft Visual Studio 14.0\VC\ATLMFC\LIB\amd64 /LIBPATH:C:\Program Files (x86)\Window
s Kits\10\lib\10.0.10586.0\ucrt\x64 /LIBPATH:C:\Program Files (x86)\Windows Kits
\NETFXSDK\4.6.1\lib\um\x64 /LIBPATH:C:\Program Files (x86)\Windows Kits\10\lib\1
0.0.10586.0\um\x64 /LIBPATH:C:\Program Files (x86)\Microsoft Visual Studio 14.0\
VC\LIB\amd64 /LIBPATH:C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATL
MFC\LIB\amd64 /LIBPATH:C:\Program Files (x86)\Windows Kits\10\lib\10.0.10586.0\u
crt\x64 /LIBPATH:C:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\lib\um\x64 /
LIBPATH:C:\Program Files (x86)\Windows Kits\10\lib\10.0.10586.0\um\x64 /EXPORT:P
yInit_splitPixelFullCSR build\temp.win-amd64-3.5\Release\pyFAI\ext\splitPixelFul
lCSR.obj /OUT:build\lib.win-amd64-3.5\pyFAI\ext\splitPixelFullCSR.cp35-win_amd64
.pyd /IMPLIB:build\temp.win-amd64-3.5\Release\pyFAI\ext\splitPixelFullCSR.cp35-w
in_amd64.lib  " failed with exit status 1181

Here it is ok
(venv) >pip install --upgrade setuptools==23
Collecting setuptools==23
  Using cached setuptools-23.0.0-py2.py3-none-any.whl
Installing collected packages: setuptools
  Found existing installation: setuptools 25.1.0
    Uninstalling setuptools-25.1.0:
      Successfully uninstalled setuptools-25.1.0
Successfully installed setuptools-23.0.0

(venv) >python setup.py build
running build
running build_py
running build_ext
No module named 'numpy.distutils._msvccompiler' in numpy.distutils; trying from
distutils
building 'pyFAI.ext.splitPixelFullCSR' extension
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\x86_amd64\cl.exe /c /
nologo /Ox /W3 /GL /DNDEBUG /MD -IpyFAI\ext\include -IpyFAI\ext -IC:\Users\valls
\pyFAI_venv\lib\site-packages\numpy\core\include -Ic:\python35-amd64\include -Ic
:\python35-amd64\include -I"C:\Program Files (x86)\Microsoft Visual Studio 14.0\
VC\INCLUDE" -I"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\INC
LUDE" -I"C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\ucrt" -I"C:
\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\include\um" -I"C:\Program Files
 (x86)\Windows Kits\10\include\10.0.10586.0\shared" -I"C:\Program Files (x86)\Wi
ndows Kits\10\include\10.0.10586.0\um" -I"C:\Program Files (x86)\Windows Kits\10
\include\10.0.10586.0\winrt" -I"C:\Program Files (x86)\Microsoft Visual Studio 1
4.0\VC\INCLUDE" -I"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC
\INCLUDE" -I"C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\ucrt" -
I"C:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\include\um" -I"C:\Program F
iles (x86)\Windows Kits\10\include\10.0.10586.0\shared" -I"C:\Program Files (x86
)\Windows Kits\10\include\10.0.10586.0\um" -I"C:\Program Files (x86)\Windows Kit
s\10\include\10.0.10586.0\winrt" /TcpyFAI\ext\splitPixelFullCSR.c /Fobuild\temp.
win-amd64-3.5\Release\pyFAI\ext\splitPixelFullCSR.obj /openmp
Found executable C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\x86_
amd64\cl.exe
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\x86_amd64\link.exe /n
ologo /INCREMENTAL:NO /LTCG /DLL /MANIFEST:EMBED,ID=2 /MANIFESTUAC:NO /LIBPATH:c
:\python35-amd64\Libs /LIBPATH:C:\Users\valls\pyFAI_venv\libs /LIBPATH:C:\Users\
valls\pyFAI_venv\PCbuild\amd64 /LIBPATH:"C:\Program Files (x86)\Microsoft Visual
 Studio 14.0\VC\LIB\amd64" /LIBPATH:"C:\Program Files (x86)\Microsoft Visual Stu
dio 14.0\VC\ATLMFC\LIB\amd64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\10\l
ib\10.0.10586.0\ucrt\x64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\NETFXSDK
\4.6.1\lib\um\x64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\10\lib\10.0.105
86.0\um\x64" /LIBPATH:"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\LI
B\amd64" /LIBPATH:"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC
\LIB\amd64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\10\lib\10.0.10586.0\uc
rt\x64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\lib\um\x64"
 /LIBPATH:"C:\Program Files (x86)\Windows Kits\10\lib\10.0.10586.0\um\x64" /EXPO
RT:PyInit_splitPixelFullCSR build\temp.win-amd64-3.5\Release\pyFAI\ext\splitPixe
lFullCSR.obj /OUT:build\lib.win-amd64-3.5\pyFAI\ext\splitPixelFullCSR.cp35-win_a
md64.pyd /IMPLIB:build\temp.win-amd64-3.5\Release\pyFAI\ext\splitPixelFullCSR.cp
35-win_amd64.lib
Found executable C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\x86_
amd64\link.exe
building 'pyFAI.ext.relabel' extension
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\x86_amd64\cl.exe /c /
nologo /Ox /W3 /GL /DNDEBUG /MD -IpyFAI\ext\include -IpyFAI\ext -IC:\Users\valls
\pyFAI_venv\lib\site-packages\numpy\core\include -Ic:\python35-amd64\include -Ic
:\python35-amd64\include -I"C:\Program Files (x86)\Microsoft Visual Studio 14.0\
VC\INCLUDE" -I"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\INC
LUDE" -I"C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\ucrt" -I"C:
\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\include\um" -I"C:\Program Files
 (x86)\Windows Kits\10\include\10.0.10586.0\shared" -I"C:\Program Files (x86)\Wi
ndows Kits\10\include\10.0.10586.0\um" -I"C:\Program Files (x86)\Windows Kits\10
\include\10.0.10586.0\winrt" -I"C:\Program Files (x86)\Microsoft Visual Studio 1
4.0\VC\INCLUDE" -I"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC
\INCLUDE" -I"C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\ucrt" -
I"C:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\include\um" -I"C:\Program F
iles (x86)\Windows Kits\10\include\10.0.10586.0\shared" -I"C:\Program Files (x86
)\Windows Kits\10\include\10.0.10586.0\um" -I"C:\Program Files (x86)\Windows Kit
s\10\include\10.0.10586.0\winrt" /TcpyFAI\ext\relabel.c /Fobuild\temp.win-amd64-
3.5\Release\pyFAI\ext\relabel.obj
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\x86_amd64\link.exe /n
ologo /INCREMENTAL:NO /LTCG /DLL /MANIFEST:EMBED,ID=2 /MANIFESTUAC:NO /LIBPATH:c
:\python35-amd64\Libs /LIBPATH:C:\Users\valls\pyFAI_venv\libs /LIBPATH:C:\Users\
valls\pyFAI_venv\PCbuild\amd64 /LIBPATH:"C:\Program Files (x86)\Microsoft Visual
 Studio 14.0\VC\LIB\amd64" /LIBPATH:"C:\Program Files (x86)\Microsoft Visual Stu
dio 14.0\VC\ATLMFC\LIB\amd64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\10\l
ib\10.0.10586.0\ucrt\x64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\NETFXSDK
\4.6.1\lib\um\x64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\10\lib\10.0.105
86.0\um\x64" /LIBPATH:"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\LI
B\amd64" /LIBPATH:"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC
\LIB\amd64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\10\lib\10.0.10586.0\uc
rt\x64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\lib\um\x64"
 /LIBPATH:"C:\Program Files (x86)\Windows Kits\10\lib\10.0.10586.0\um\x64" /EXPO
RT:PyInit_relabel build\temp.win-amd64-3.5\Release\pyFAI\ext\relabel.obj /OUT:bu
ild\lib.win-amd64-3.5\pyFAI\ext\relabel.cp35-win_amd64.pyd /IMPLIB:build\temp.wi
n-amd64-3.5\Release\pyFAI\ext\relabel.cp35-win_amd64.lib
building 'pyFAI.ext.bilinear' extension
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\x86_amd64\cl.exe /c /
nologo /Ox /W3 /GL /DNDEBUG /MD -IpyFAI\ext\include -IpyFAI\ext -IC:\Users\valls
\pyFAI_venv\lib\site-packages\numpy\core\include -Ic:\python35-amd64\include -Ic
:\python35-amd64\include -I"C:\Program Files (x86)\Microsoft Visual Studio 14.0\
VC\INCLUDE" -I"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\INC
LUDE" -I"C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\ucrt" -I"C:
\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\include\um" -I"C:\Program Files
 (x86)\Windows Kits\10\include\10.0.10586.0\shared" -I"C:\Program Files (x86)\Wi
ndows Kits\10\include\10.0.10586.0\um" -I"C:\Program Files (x86)\Windows Kits\10
\include\10.0.10586.0\winrt" -I"C:\Program Files (x86)\Microsoft Visual Studio 1
4.0\VC\INCLUDE" -I"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC
\INCLUDE" -I"C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\ucrt" -
I"C:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\include\um" -I"C:\Program F
iles (x86)\Windows Kits\10\include\10.0.10586.0\shared" -I"C:\Program Files (x86
)\Windows Kits\10\include\10.0.10586.0\um" -I"C:\Program Files (x86)\Windows Kit
s\10\include\10.0.10586.0\winrt" /TcpyFAI\ext\bilinear.c /Fobuild\temp.win-amd64
-3.5\Release\pyFAI\ext\bilinear.obj /openmp
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\x86_amd64\link.exe /n
ologo /INCREMENTAL:NO /LTCG /DLL /MANIFEST:EMBED,ID=2 /MANIFESTUAC:NO /LIBPATH:c
:\python35-amd64\Libs /LIBPATH:C:\Users\valls\pyFAI_venv\libs /LIBPATH:C:\Users\
valls\pyFAI_venv\PCbuild\amd64 /LIBPATH:"C:\Program Files (x86)\Microsoft Visual
 Studio 14.0\VC\LIB\amd64" /LIBPATH:"C:\Program Files (x86)\Microsoft Visual Stu
dio 14.0\VC\ATLMFC\LIB\amd64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\10\l
ib\10.0.10586.0\ucrt\x64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\NETFXSDK
\4.6.1\lib\um\x64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\10\lib\10.0.105
86.0\um\x64" /LIBPATH:"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\LI
B\amd64" /LIBPATH:"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC
\LIB\amd64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\10\lib\10.0.10586.0\uc
rt\x64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\lib\um\x64"
 /LIBPATH:"C:\Program Files (x86)\Windows Kits\10\lib\10.0.10586.0\um\x64" /EXPO
RT:PyInit_bilinear build\temp.win-amd64-3.5\Release\pyFAI\ext\bilinear.obj /OUT:
build\lib.win-amd64-3.5\pyFAI\ext\bilinear.cp35-win_amd64.pyd /IMPLIB:build\temp
.win-amd64-3.5\Release\pyFAI\ext\bilinear.cp35-win_amd64.lib
CTRL-C

We can see that setuptools 25 do not quote /LIBPATH files.
Do you have any idea where this change of the behavior come from? I try another project containing extension with the same environment and it looks to work. Can it come from a bad setup of my project? My extensions come from Cython.
Thanks a lot.

My guess is that setuptools==23.2.1 also works, which implicates setuptools 24, which did explicitly make a change to the way VC tools were handled.
@JGoutin Can you investigate?

I can confirm setuptools==23.2.1 is working.

The MSCV patch return environment as a single string with unquoted paths separated by ;.
distutils._msvccompiler._get_vc_env (The patched function for MSVC14) return environment in same format.
I checked by running:
import setuptools
# Patch
setuptools.msvc.EnvironmentInfo('x64', vc_min_ver=14.0).return_env()['libpath']
# Original Function
setuptools.msvc.unpatched['msvc14_get_vc_env']('x64')['libpath']

On my PC, there is no quote in all cases.
So, it seem quotes come from another piece of code.
To be sure, maybe try to run your build after disabling the patch in setuptools/msvc.py, by example by adding a return  line 60 of this file at the tart of the patch_for_specialized_compiler function. And see if the bug is always here.

Hi. I try to disable the patches, but nothing changed.
The behaviour is always the same.
I also check which patches are applied, and both MSVC9 and MSVC14 are used in normal condition.

I also try to use distutils instead of setuptools. And it is a surprise for me, but it is working well...
running build_ext
No module named 'numpy.distutils._msvccompiler' in numpy.distutils; trying from distutils
building 'pyFAI.ext._geometry' extension
creating build\temp.win-amd64-3.5
creating build\temp.win-amd64-3.5\Release
creating build\temp.win-amd64-3.5\Release\pyFAI
creating build\temp.win-amd64-3.5\Release\pyFAI\ext
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\x86_amd64\cl.exe /c /nologo /Ox /W3 /GL /DNDEBUG /MD -IpyFAI\ext\include -IpyFAI\ext -IC:\Users\valls\pyFAI_venv\lib\site-packages\numpy\core\include -Ic:\python35-amd64\include -Ic:\python35-amd64\include -I"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE" -I"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\INCLUDE" -I"C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\ucrt" -I"C:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\include\um" -I"C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\shared" -I"C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\um" -I"C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\winrt" -I"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE" -I"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\INCLUDE" -I"C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\ucrt" -I"C:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\include\um" -I"C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\shared" -I"C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\um" -I"C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\winrt" /TcpyFAI\ext\_geometry.c /Fobuild\temp.win-amd64-3.5\Release\pyFAI\ext\_geometry.obj /openmp
Found executable C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\x86_amd64\cl.exe
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\x86_amd64\link.exe /nologo /INCREMENTAL:NO /LTCG /DLL /MANIFEST:EMBED,ID=2 /MANIFESTUAC:NO /LIBPATH:c:\python35-amd64\Libs /LIBPATH:C:\Users\valls\pyFAI_venv\libs /LIBPATH:C:\Users\valls\pyFAI_venv\PCbuild\amd64 /LIBPATH:"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\LIB\amd64" /LIBPATH:"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\LIB\amd64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\10\lib\10.0.10586.0\ucrt\x64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\lib\um\x64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\10\lib\10.0.10586.0\um\x64" /LIBPATH:"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\LIB\amd64" /LIBPATH:"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\LIB\amd64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\10\lib\10.0.10586.0\ucrt\x64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\lib\um\x64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\10\lib\10.0.10586.0\um\x64" /EXPORT:PyInit__geometry build\temp.win-amd64-3.5\Release\pyFAI\ext\_geometry.obj /OUT:build\lib.win-amd64-3.5\pyFAI\ext\_geometry.cp35-win_amd64.pyd /IMPLIB:build\temp.win-amd64-3.5\Release\pyFAI\ext\_geometry.cp35-win_amd64.lib
Found executable C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\x86_amd64\link.exe
building 'pyFAI.ext.reconstruct' extension
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\x86_amd64\cl.exe /c /nologo /Ox /W3 /GL /DNDEBUG /MD -IpyFAI\ext\include -IpyFAI\ext -IC:\Users\valls\pyFAI_venv\lib\site-packages\numpy\core\include -Ic:\python35-amd64\include -Ic:\python35-amd64\include -I"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE" -I"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\INCLUDE" -I"C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\ucrt" -I"C:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\include\um" -I"C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\shared" -I"C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\um" -I"C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\winrt" -I"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE" -I"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\INCLUDE" -I"C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\ucrt" -I"C:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\include\um" -I"C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\shared" -I"C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\um" -I"C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\winrt" /TcpyFAI\ext\reconstruct.c /Fobuild\temp.win-amd64-3.5\Release\pyFAI\ext\reconstruct.obj /openmp
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\x86_amd64\link.exe /nologo /INCREMENTAL:NO /LTCG /DLL /MANIFEST:EMBED,ID=2 /MANIFESTUAC:NO /LIBPATH:c:\python35-amd64\Libs /LIBPATH:C:\Users\valls\pyFAI_venv\libs /LIBPATH:C:\Users\valls\pyFAI_venv\PCbuild\amd64 /LIBPATH:"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\LIB\amd64" /LIBPATH:"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\LIB\amd64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\10\lib\10.0.10586.0\ucrt\x64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\lib\um\x64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\10\lib\10.0.10586.0\um\x64" /LIBPATH:"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\LIB\amd64" /LIBPATH:"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\LIB\amd64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\10\lib\10.0.10586.0\ucrt\x64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\lib\um\x64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\10\lib\10.0.10586.0\um\x64" /EXPORT:PyInit_reconstruct build\temp.win-amd64-3.5\Release\pyFAI\ext\reconstruct.obj /OUT:build\lib.win-amd64-3.5\pyFAI\ext\reconstruct.cp35-win_amd64.pyd /IMPLIB:build\temp.win-amd64-3.5\Release\pyFAI\ext\reconstruct.cp35-win_amd64.lib
building 'pyFAI.ext.splitPixel' extension
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\x86_amd64\cl.exe /c /nologo /Ox /W3 /GL /DNDEBUG /MD -IpyFAI\ext\include -IpyFAI\ext -IC:\Users\valls\pyFAI_venv\lib\site-packages\numpy\core\include -Ic:\python35-amd64\include -Ic:\python35-amd64\include -I"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE" -I"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\INCLUDE" -I"C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\ucrt" -I"C:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\include\um" -I"C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\shared" -I"C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\um" -I"C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\winrt" -I"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE" -I"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\INCLUDE" -I"C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\ucrt" -I"C:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\include\um" -I"C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\shared" -I"C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\um" -I"C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\winrt" /TcpyFAI\ext\splitPixel.c /Fobuild\temp.win-amd64-3.5\Release\pyFAI\ext\splitPixel.obj
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\x86_amd64\link.exe /nologo /INCREMENTAL:NO /LTCG /DLL /MANIFEST:EMBED,ID=2 /MANIFESTUAC:NO /LIBPATH:c:\python35-amd64\Libs /LIBPATH:C:\Users\valls\pyFAI_venv\libs /LIBPATH:C:\Users\valls\pyFAI_venv\PCbuild\amd64 /LIBPATH:"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\LIB\amd64" /LIBPATH:"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\LIB\amd64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\10\lib\10.0.10586.0\ucrt\x64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\lib\um\x64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\10\lib\10.0.10586.0\um\x64" /LIBPATH:"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\LIB\amd64" /LIBPATH:"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\LIB\amd64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\10\lib\10.0.10586.0\ucrt\x64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\lib\um\x64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\10\lib\10.0.10586.0\um\x64" /EXPORT:PyInit_splitPixel build\temp.win-amd64-3.5\Release\pyFAI\ext\splitPixel.obj /OUT:build\lib.win-amd64-3.5\pyFAI\ext\splitPixel.cp35-win_amd64.pyd /IMPLIB:build\temp.win-amd64-3.5\Release\pyFAI\ext\splitPixel.cp35-win_amd64.lib
...

So, if problem occur also with patches disabled, the problem seem to not come from setuptools/msvc.py but from another change from Setuptools 24. But I don't see other change in changelog.

I can try a git-bisect next week, if it can help

Git-bisect is a good idea. Also, for reference, here's the difference between v23.2.1 and v24.0.0. Basically everything in the MSVC support changed :/ and nothing else.

Also, there were some regressions identified, so do try the latest version also to see if perhaps that helps.

Hi. Here is the result of git bisect
75282e5568039e3dae52ee41ada35baf56f0567c is the first bad commit
commit 75282e5568039e3dae52ee41ada35baf56f0567c
Author: JGoutin<EMAIL_ADDRESS>Date:   Wed Mar 2 18:51:40 2016 +0000

Commit https://github.com/pypa/setuptools/commit/75282e5568039e3dae52ee41ada35baf56f0567c

Iv got something which work.
Here is my patch
 try:
     # Distutil file for MSVC++ 14.0 and upper
-    import distutils._msvccompiler as msvc14compiler
+    import distutils.msvc9compiler as msvc14compiler
 except ImportError:
     pass

Does it means distutils._msvccompiler is buggy?

With this, the monkey patch line 81 will fail. So distutils._msvccompiler is used unpatched. This confirm the issue is msvc.py related.

Oh... of cours...
Last things,

when linking fail gen_lib_options come from distutils
when it works gen_lib_options come from numpy

Im lost for today :-)

You are true, there is nothing for handle space in paths in distutils, but Numpy patch this.
Is your build working with this patch: #715

Good needs,
With that patch (https://github.com/vallsv/setuptools/commit/7bbf32709a5bf7ee349e6529ecb8c386b972d6b3) over your patch, here it is working.

Thanks for the fix.
And yes for the except Exception, theses exceptions should be more precisely catched.

It's fine for me. Thanks a lot for the help.
It was a big problem for us.

It seems like 25.1.4 was supposed to fix this, but I'm still seeing this error it; see appveyor/ci#963.  Am I missing something (quite possible, Python really isn't my thing)?

I quess, when both numpy monkey-patch gen_lib_options and setuptools monkey-patch MSVCCompile it can unfortunatly occure this kind of problem...

numpy.distutils.misc_util.quote_args (https://github.com/numpy/numpy/blob/master/numpy/distutils/misc_util.py) check if there is a quote on the first char, then before /LIBPATH:path. while library_dir_option check quotes on path.
Maybe there is two way to fix the problem:

monkey-patch numpy.distutils.misc_util.quote_args with a[-1] instead of a[0] if it exists
or we should patch gen_lib_options like numpy instead of library_dir_option.
Both should work.

They don't use Numpy. The script only install Setuptools and Wheel.
Here, it quote complete argument (Not exactly see from where) :
"/LIBPATH:C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\LIB"
Numpy quote only path :
/LIBPATH:"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\LIB\"

BTW somebody already proposed a patch https://github.com/pypa/setuptools/pull/723. Hope it fix the problem

:+1:

#723 does not solve the problem we have when building brotli. The quotes are now added twice.
Cf. https://github.com/pypa/setuptools/issues/722#issuecomment-237858062
The thing is, it was working just fine using either plain distutils, or setuptools before you monkeypatched distutils._msvccompiler.MSVCCompiler.library_dir_option with setuptools.msvc.msvc14_library_dir_option.
I think the problem is that the distutils.spawn._spawn_nt, which is used to call the linker with /LIBPATH arguments, already adds quotes to the subprocess arguments containing spaces.
So it should be unnecessary to do it in setuptools as well:
https://hg.python.org/cpython/file/3.5/Lib/distutils/spawn.py#l43

Then maybe i have to try on my side why it is not the behaviour on my project.
I only check if my os.name is nt and if i have more or less the same distutils.spawn.py file. Both are true.
Then, work for monday.

In the meantime, I think that both #715 and #723 should be reverted, to restore the previous correct behavior.

I did a PR for revert this patch.
@vallsv : This error is maybe only on your project (Not in the most generic case, in any case). Maybe a conflict with Numpy distutils fixes ?

FWIW 25.1.6 seems to have fixed the issue for Brotli.

@JGoutin yes, it looks like it is something like that. If we use numpy Extension, the spawn function is the one from numpy, but not gen_lib_options (i guess, i dont check). And numpy choose to quotes args on gen_lib_options.
After fixing another problem, i only did that on our setup.py
#from numpy.distutils.core import Extension as _Extension
from setuptools import Extension as _Extension

But i think our project needs some compilation optimizations from numpy.distutils.
I have to ask my co-worker (who is not here), and i will come back to that issue if we really need to mix tools. Thanks a lot for your help again. And sorry others for the problem on the 25.1.4.
BTW do you have idea if there is plan to merge distutils on setuptools, or if numpy will use setuptools? It can remove a lot of monkey-patch.

Numpy seem to already use Setuptools.
You should maybe report your problem to them.
For merging distutils on setuptools, there is no PEP on this, so I think this is not planned.

Just as an FYI, distutils._msvccompiler is the correct module for using MSVC (the others only still exist for back-compat - they are unused and unsupported). It is still supported, so if there are bugs in it please report them on bugs.python.org so we can fix them.
As for path quoting, that's handled in distutils.spawn._nt_quote_args, which is not safe against arguments ending in a backslash, but apparently has been good enough for a long time now. If someone else overrides spawn, then it's on them to get quoting correct and there should be no need to patch distutils.

how can i solve istutils.errors.LinkError: command 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\link.exe' failed with exit status 1104 when installing basemap am using python36 32bit .any help will be highly appreciated.

@Aaron-joshua: you could sidestep the problem by installing from a pre-built wheel, see: http://www.lfd.uci.edu/~gohlke/pythonlibs/#basemap


cmd/compile: spurious "declared but not used" errors

Not a release blocker but good to fix if easy.
package p

func f() {
	x := 1
	v := 2
	switch v.(type) {
	case int:
		println(x)
	}
}

% go tool compile /tmp/x.go
/tmp/x.go:4:2: x declared but not used
/tmp/x.go:6:9: v (variable of type int) is not an interface

Looks like because the switch header couldn't type-check, the bodies were not considered. And since the bodies were not considered, it looks like x was never used. The compiler should print the real error on line 6 and not print about line 4.

@rsc
I try  to fix this issue, but I found a similar issue(https://github.com/golang/go/issues/50639).


Publish a spec for generators.yml

Problem description
generators.yaml config is hard to discover
Why would it be useful?
if we could add a yaml spec and had completions would be easier to discover config
Describe the solution (optional)
you can do something like this # yaml-language-server: $schema=<urlToTheSchema>
https://github.com/redhat-developer/yaml-language-server

This is now released!
https://buildwithfern.com/learn/sdks/reference/configuration#schema-validation


The example/help in the config file generation uses the wrong shell quotes

# ### Variable `nfs_mounts` (optional, default: None):
#
#     export nfs_mounts='my-nfs-server-01-vm,/nfs-pool,.tmp/witness,/nfs01:\
#     nfs-42-vm,/nfs-pool,local/path/some/file,/nfs42'
#

The \ does not work with single quotes '..'

Now this (or arbitrary whitespace) works:
#     export nfs_mounts='my-nfs-server-01-vm,/nfs-pool,.tmp/witness,/nfs01:
#     nfs-42-vm,/nfs-pool,local/path/some/file,/nfs42'
#


./node_modules/react-instagram-zoom-slider/dist/index.es.js Module not found: Can't resolve 'react-spring' in 'C:\Users\binda\Desktop\painting webite\nepalese-artworks\node_modules\react-instagram-zoom-slider\dist'

🐛 Bug Report
(A clear and concise description of what the bug is.)
Steps to reproduce
Steps to reproduce the behavior:
Expected behavior
(A clear and concise description of what you expected to happen.)
Link to example (highly encouraged)
(Please provide either a CodeSandbox demo or an example GitHub repo.)
Environment

react-instagram-zoom-slider v1.x.x
react-spring v8.x.x
react-use-gesture v7.0.x
styled-components v5.0.x
react v16.12.x

Hi @ujjwal66,
react-spring is a peer dependency of this library - please see the installation instructions:
https://github.com/skozer/react-instagram-zoom-slider#install


Remove drush-laucher from cli container.

Fixes https://github.com/docksal/service-cli/issues/304. Fixes https://github.com/docksal/docksal/issues/1791

Thanks!


User's token holdings not displaying at all

This happened when I am not logged in.

maybe obfuscate the total number somehow

Currently it only shows 1 PAI for everyone


[Snyk] Upgrade org.webjars:bootstrap from 3.3.4 to 3.4.1

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade org.webjars:bootstrap from 3.3.4 to 3.4.1.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 6 versions ahead of your current version.
The recommended version was released 5 years ago, on 2019-02-19.

The recommended version fixes:

Severity
Issue
PriorityScore (*)
Exploit Maturity

Cross-site Scripting (XSS) SNYK-JAVA-ORGWEBJARS-451162
539/1000  Why? Has a fix available, CVSS 6.5
No Known Exploit

Cross-site Scripting (XSS) SNYK-JAVA-ORGWEBJARS-451164
539/1000  Why? Has a fix available, CVSS 6.5
No Known Exploit

Cross-site Scripting (XSS) SNYK-JAVA-ORGWEBJARS-451168
539/1000  Why? Has a fix available, CVSS 6.5
Proof of Concept

Cross-site Scripting (XSS) SNYK-JAVA-ORGWEBJARS-479505
539/1000  Why? Has a fix available, CVSS 6.5
No Known Exploit

Cross-site Scripting (XSS) SNYK-JAVA-ORGWEBJARS-451160
539/1000  Why? Has a fix available, CVSS 6.5
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

 Modified Files Coverage Summary

No coverage results for the modified files

 Overall Coverage Summary

            :green_circle: Instructions Coverage (29.93%)

            :red_circle: Branch Coverage (9.78%)


inf-haskell: fix mode-map name

I'll need someone to double-check this for me, but on my computer, I don't have any inf-haskell-mode-map, so I was getting errors like (void-variable inf-haskell-mode-map).
There is however an inferior-haskell-mode-map (seems like poor naming convention on their side...), which at least seems to remove the error when I replace it with.

Good catch, thanks!


Cannot pull the tradfri-mqtt image into docker

When I try to pull the tradfri-mqtt image in to my docker instance I get an error. I use the following command:
docker pull ghcr.io/hemtjanst/tradfri-mqtt

Next I get the following output:
Using default tag: latest
Error response from daemon: manifest unknown

It doesn't make any difference when I define a tag as v0.1.4 for example. I then also the get: manifest unknown. What am I doing?wrong?

It's not published on GHCR I'm afraid. The README has it as hemtjanst/tradfri-mqtt, meaning Docker Hub. Unfortunately that organisation got swept up in one of the many Docker Hub usage and pricing overhauls so it's gone now. You can still build it directly yourself by cloning the repository and running a docker build ..
However, we haven't developed this in years since we've stopped using the Trådfri gateway. I'm not entirely certain it works anymore with current firmware versions of the original Trådfri gateway. If you're looking to get started with this today, I would probably suggest using Home Assistant instead, with their built-in support for Trådfri. They can also publish services on MQTT which lets you recreate what this project does, but with a supported software stack.

@daenney, thanks for your very clear information. That explains why I sadly cannot pull the tradfri-mqtt image.
You wrote that it is still possible to build the image myself "by cloning the respository and running a docker build ..". You also wrote that you are not shure if a container -after building the image- will work with the Tradfri gateway these days. Nevertheless I want to give this a try (because I used tradfri-mqtt before and it was then working flawlessly). However I have never cloned and build a image from scratch before. Can you provide me some information (or probably an internet link) about how can I do this? This would help me a lot further.
Thanks in advance!

The image is still available at https://hub.docker.com/r/bonan/tradfri-mqtt
This should work:
docker pull bonan/tradfri-mqtt

@bonan, thanks for your information and help. I pulled the image and it is still working. With the docker-compose file which a created a long time ago it worked immediately (of course after editing the image location).
In the log I find the following warnings:

(node:1) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(Use node --trace-deprecation ... to show where the warning was created)

It seems that they do not prevent the container from operating normally on this moment.

I have played around a bit with the Tradfri-mqtt output in my MQTT broker.
I was hoping to see that pressing an IKEA remote creates an immediate message for the remote itself in the MQTT broker. But sadly that's not the case. Apparently Tradfri-mqtt do not send MQTT messages to the broker when a remote control is pressed. Of course, a message is sent for the device that is been linked with the to remote control.
Is my conclusion correct? Can I do something about this or can something be done about it?
My goal is to use the IKEA remote to control non-IKEA appliances. I want to do that by reading out the MQTT broker using the MQTT integration in Home Assistant. But then it is necessary that Tradfri MQTT sends a message to the MQTT broker as soon as a button on the IkEA remote control is pressed.

Can I do something about this or can something be done about it?

No. The Trådfri gateway does not send any messages when the remote is used on its own, so it's impossible for tradfri-mqtt to implement that feature.
You need to use zigbee2mqtt or similar with a supported ZigBee gateway/stick

Thanks for your reply. It's not the answer I was hoping for but what I although expected. Pitty that the Tradri hub does not sent messages when a remote button is pressed. Thanks for the Zigbee tip.


replace legacy plugin name by respective one

Hi,
using this svgo plugin with svg-sprite according docs, I realized it's not working. So I figured out, this is an old reference. See https://github.com/svg/svgo/pull/980
Furthermore I set to false in this case to reflect you actually want to override the default.
Have a nice week
midzer

Coverage remained the same at 78.922% when pulling bae6d78ef98aaded64f1730225a74b122eddff21 on midzer:patch-1 into<PHONE_NUMBER>b03471abd49a77c0f3d93255f3e534 on jkphl:master.


Revert "Merge pull request #8190 from MaxWang-MS/AxisFlags_fix"

This reverts commit 121c4573f2ffb4dc5853f2571f5f74905e572273, reversing
changes made to 5730fa18cbe5f300a5145ebd1013d35e203ef9b9.
Overview
reverted the changes to axis flag as it's breaking user asset files (and mrtk example scenes)
there needs to be more investigation on android side to tackle the original issue.

Reopens: https://github.com/microsoft/MixedRealityToolkit-Unity/issues/7463
Fixes parts of: #8555

/azp run

/azp run


helpers.send_file doesn't close file

Expected Behavior
send_file closes the file which it opens
https://github.com/pallets/flask/blob/0.12.2/flask/helpers.py#L549
Actual Behavior
File is not closed.
Tests are yelling:
tests2.py:14: ResourceWarning: unclosed file <_io.BufferedReader name='path/tests2.py'>
> python3 tests2.py
tests2.py:14: ResourceWarning: unclosed file <_io.BufferedReader name='path/tests2.py'>
  self.client.get('/')
.
----------------------------------------------------------------------
Ran 1 test in 0.012s

OK

> cat tests2.py
import unittest
from flask import Flask
from flask import current_app, send_from_directory
app = Flask(__name__)

@app.route("/")
def hello():
    return send_from_directory('.', __file__)

class TestCase(unittest.TestCase):
    def test_x(self):
        self.client = app.test_client()

        self.client.get('/')

if __name__ == '__main__':
    unittest.main()

Environment

Python version: Python 3.5.3
Flask version: Flask==0.12.2
Werkzeug version: Werkzeug==0.12.2

I tried your test on my local python2 (OS X 10.11.6 / Python 2.7.13) and in docker on your version (3.5.3) and both worked without issue.
# docker run --rm -v `pwd`:/tmp/ python:3.5.3 /bin/bash -c "pip install flask && python3 /tmp/tests2.py"
.
----------------------------------------------------------------------
Ran 1 test in 0.014s

OK

People misunderstand the fact that send_file opens the file but doesn't close it. Other parts of the WSGI flow will close files after the response is built, so that things like streaming work.
There are some cases where tests will raise this warning because other tests failed, but it's not really an issue because tests end, the file doesn't stay open. As far as I can tell, the test suite has cases for this already and passes.

I found that closing the response from the test client addressed the ResourceWarning: unclosed file <_io.BufferedReader I was getting:
response = self.client.get('/')
self.assertEqual(response.status_code, 200)
response.close()


Adding metadata flag to get information on the drand network

Thank you for this contribution, it definitely will be useful for tlock users!
Could you possibly add a few unit tests covering the Tlock.Metadata function? It looks right to me, it just ensures nobody can accidentally break it in future ^^
Otherwise it looks good to merge!

Oh was waiting for someone to review functionality wise so that I can add test cases :xD


fix(sdk-metrics): fix duplicated registration of metrics for collectors

Which problem is this PR solving?
Fixes https://github.com/open-telemetry/opentelemetry-js/issues/3472
Short description of the changes

Fixes that MetricStorageRegistry.findOrUpdateCompatibleCollectorStorage always returns undefined, which leads to duplicated registration of metric storage for a collector.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

[x] Verified that MetricStorageRegistry.findOrUpdateCompatibleCollectorStorage returns the expected value.

Checklist:

[x] Followed the style guidelines of this project
[x] Unit tests have been added

Simpler than expected fix


[QA Review]: NDFD Airtemp Data Type Issues

These issues exist in rsgis.dev.  Verify if they exist in corps.cloud.
The 3-hr and 6-hr airtemp records are being written to DSS with “PER-CUM” data type and record pathnames (with D- and E-part dates/times), but they are actually instantaneous data.
So, the 3-hr and 6hr airtemp records should be tagged in DSS as “INST-VAL” with record pathnames that only have the D-part filled out with a date and time, while the E-Part is blank.

Found several other airtemp products with the wrong temporal_duration which was causing the DSS type to be "PER-CUM" instead of "INST-VAL".  Migration to fix in progress.


docs: edge deploy with csr

Update readme.
Add copy past kubectl command tox deploy latest stable version.
Pull Request

What? (description)
Why? (reasoning)
Acceptance
Please use the following checklist:

[ ] you linked an issue (if applicable)
[ ] you included tests (if applicable)
[ ] you ran conformance (make conformance)
[ ] you linted your code (make lint)
[ ] you linted your code (make unit)

See make help for a description of the available targets.

/m


Button - light level incorrect intermediate level animation with HA grouped lights

Describe the bug
I'm pretty sure this has been logged before but was hoping it had been fixed in v2 beta but still there.
With some lights that are grouped in a group helper in HA (Lights are Philips Hue via the official integration), when I set a light brightness level, the slider 'bounces' around and animates to an intermediate level before then animating to the final level. I expect this is the code reading the level mid-operation and animating to that level and then to the final level. Maybe this is due to the delay in Hue reporting back to HA mid-dim operation? It only happens once in between the start and end levels.
To Reproduce
Happens all the time and consistently when using HA grouped lights. It does not happen if the group is set on the Hue platform. That can be the solution in some cases but would be good to have grouped lights working if possible.
Expected behavior
The intermediate state should not be shown.
Screenshots
This screen recording shows the issue:
https://github.com/Clooos/Bubble-Card/assets/513044/78ff15d0-c636-4523-ae65-d43e9cff2254
Desktop (please complete the following information):
All devices - desktop and android devices show this behaviour.
Thanks for the work on this card and the v2 updates :)

The cards you are showing in this video are not Bubble Cards, and indeed this issue is related to Hue, I have these too and this issue is already in Bubble Card. There is probably nothing that I can do.

Doh! My mistake, they're mushroom cards I think! I'm really stupid! lol


node['cpe_munki']['preferences']['LocalOnlyManifest'] = 'extra_packages' has to be explicitly set

I'm not sure if this is exactly the relevant line, however, in any case, the default fallback setting for  node['cpe_munki']['preferences']['LocalOnlyManifest'] doesn't get added to the Munki profile.
https://github.com/facebook/IT-CPE/blob/master/chef/cookbooks/cpe_munki/resources/cpe_munki_local.rb#L30
This preference doesn't get applied unless it is explicitly set. Currently I'm setting this in cpe_init::company_init.rb.

Looked at this, it appears that the configure resource just stuffs whatever is in the attributes into the profile. That is perfectly fine, but I'll add a check for LocalOnlyManifest and make sure it is set either way, unless there are objections. @mikedodge04 @nmcspadden

Its and order issue.
https://github.com/facebook/IT-CPE/blob/master/chef/cookbooks/cpe_munki/recipes/default.rb#L18
the local need to come before config, and then it will work.


How to use on a mips cpu?

system type		: Qualcomm Atheros QCA956X ver 1 rev 0
machine			: TP-Link Archer A7 v5
cpu model		: MIPS 74Kc V5.0
Is it even possible? i can't find a release package.

netbird_0.8.2-1_mips_24kc.ipk


Allow having lower_camel_case under schema validation

for all of the camel case lovers :)

Do you actually mean lower_snake_case (lower case separated by underscores, https://en.wikipedia.org/wiki/Snake_case) ?

:tada: This issue has been resolved in version 0.7.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


consdier renaming prelude

prelude is not a term that makes sense to me given my background and i think the use of this term is not helpful. would propose changing to convenience methods or index or manifest

prelude is the conventional name for "thing intended to be glob imported"

e.g. The std::prelude module is implicitly glob imported at the top of all Rust files that don't contain a flag for otherwise. Other examples from the std lib include
https://doc.rust-lang.org/nightly/std/io/prelude/index.html

Related: https://github.com/samphippen/expector/pull/11


Add application tags and hearbeater service

Please also run pylint checks against your code
$ pylint wavefront_sdk/ -d R0205
************* Module wavefront_sdk.direct
wavefront_sdk/direct.py:116:19: W0703: Catching too general exception Exception (broad-except)
************* Module wavefront_sdk.common.constants
wavefront_sdk/common/constants.py:7:0: W0105: String statement has no effect (pointless-string-statement)
************* Module wavefront_sdk.common.application_tags
wavefront_sdk/common/application_tags.py:14:4: R0913: Too many arguments (6/5) (too-many-arguments)
wavefront_sdk/common/application_tags.py:38:4: C0111: Missing method docstring (missing-docstring)
wavefront_sdk/common/application_tags.py:42:4: C0111: Missing method docstring (missing-docstring)
wavefront_sdk/common/application_tags.py:46:4: C0111: Missing method docstring (missing-docstring)
wavefront_sdk/common/application_tags.py:50:4: C0111: Missing method docstring (missing-docstring)
wavefront_sdk/common/application_tags.py:54:4: C0111: Missing method docstring (missing-docstring)
wavefront_sdk/common/application_tags.py:57:4: C0111: Missing method docstring (missing-docstring)
************* Module wavefront_sdk.common.heartbeater_service
wavefront_sdk/common/heartbeater_service.py:15:0: C0103: Constant name "logger" doesn't conform to UPPER_CASE naming style (invalid-name)
wavefront_sdk/common/heartbeater_service.py:21:4: R0913: Too many arguments (6/5) (too-many-arguments)
wavefront_sdk/common/heartbeater_service.py:60:15: W0703: Catching too general exception Exception (broad-except)
wavefront_sdk/common/heartbeater_service.py:61:12: W1201: Specify string format arguments as logging function parameters (logging-not-lazy)
wavefront_sdk/common/heartbeater_service.py:18:0: R0903: Too few public methods (0/2) (too-few-public-methods)
************* Module wavefront_sdk.entities.histogram.histogram_impl
wavefront_sdk/entities/histogram/histogram_impl.py:346:26: R0124: Redundant comparison - max_val == max_val (comparison-with-itself)
wavefront_sdk/entities/histogram/histogram_impl.py:360:26: R0124: Redundant comparison - min_val == min_val (comparison-with-itself)


Scroll directory flyout pane with scroll wheel

When clicking a directory in the menu bar, it opens up in a horizontal pane underneath. It would be a great usability improvement if it could be scrolled with the mouse wheel.

This is a huge usability win and will be in the next release. Thanks for the suggestion!

This should be resolved in the latest release.


JBPM-5030: Access control based on the new UF's authz subsystem

Changes required to support the new UF's security APIs as well as to integrate the following resource types intro the permission editor: Org. Units, Repositories & Projects.
This PR depends on uberfire/uberfire#321

some concerns... but would be ok to merge: +1

Jenkins please retest this.

retest


About page

@XhmikosR @jmervine need you to both review before merging
Fixes #1014.

[x] Typos
[x] Tests
[x] Footer link
[ ] Tweak looks

Thank you.  I made some updates to the text. I will pull and push

@jdorfman: make sure you don't overwrite my changes.

I keep getting merge conflicts can you please update about.pug with the following? I need to get to bed.
extends layout.pug

block content
    .row
        .col-12

            h2.text-center.mb-4 About

            p
                | BootstrapCDN was founded in 2012 by
                a(href='https://twitter.com/DavidHenzel', target='_blank', rel='noopener') David Henzel
                |  and Justin Dorfman at MaxCDN. Today, BootstrapCDN is used by over
                a(href='https://trends.builtwith.com/cdn/BootstrapCDN') 5.1 million sites
                |  delivering over 70 billion requests a month.

            p There are currently 3 maintainers:

            ul.list-unstyled
                each author in config.authors
                    li
                        a(href=author.url, rel='noopener', target='_blank')=author.name

            h2.my-4 Core Values

            h3.h4
                strong 1. Security

            p.
                We agree with StackPath, security should be built in, not bolted on.
                Our DNS & CDN is managed by StackPath. Our origin server is S3.
                This website is hosted by Heroku. We enforce 2-factor authentication
                on all services (including GitHub, MarkMonitor, AWS & Gmail).
                Our master branch on GitHub is protected to disable force pushing,
                prevent branches from being deleted, and require status checks before merging.
                Our domain (*.bootstrapcdn.com) is managed by MarkMonitor, an ICANN-accredited
                registrar and recognized industry leader since 1999. They have security measures
                in place such as registry locking and IP restrictions to help reduce security
                vulnerabilities and minimize the likelihood of successful domain hijacking.
                By default we include Subresource Integrity (SRI) hashes when users copy a code
                snippet from this site.

            h3.h4
                strong 2. Reliability

            p
                | Reliable services require reliable people. StackPath's network is monitored 24/7/365
                | and any incidents are posted to their
                a(href='https://status.stackpath.com/') status page
                | in real-time. Twitter is monitored for any mentions
                | of the terms "BootstrapCDN", "#BootstrapCDN", "Bootstrap CDN". There is someone
                | always on call and has direct access to the StackPath support team via a private
                | Slack channel. As mentioned above, we only use services that are secure & reliable.
                | Every Pull Request requires to pass a test that checks every file we deliver, making ~21K tests in total,
                | to make sure all of the HTTP headers are correct and SRI hashes match.

            h3.h4
                strong 3. Accessibility

            p
                | We must do everything we can to make sure this service is accessible to all.
                | We do that by providing IPv6 support, we are also whitelisted in
                a(href='https://github.com/ampproject/amphtml/search?utf8=%E2%9C%93&q=bootstrapcdn&type=') Google AMP
                | & the "Great Firewall of China".
                | Last but not least, we have Points of Presence (POPs) in North America, South America, Europe & Asia-Pacific region (
                a(href='https://www.stackpath.com/network/') view network map
                | ).

//- vim: ft=pug sw=4 sts=4 et:

Sure thing, don't worry about it :)

I think this is mostly ready.
Please verify and let me know if you want me to change something.


Remove the link to the unused page in the side menu

✅  Resolves #27398.

/assign @inductor

/lgtm

/approve


Request for a Basic Usage Tutorial or Guide

I think this is a great tool! Could we have a tutorial or guide for basic use cases? Something like this would be really helpful.

Basic workflow
Create a branch
st branch create some-branch
Commit your changes
git commit -m "commit"
Submit the branch
st branch submit

I'm glad you like it! If you've tried it out, I'm sure you've noticed that it's very incomplete and rough around the edges, both for installing and for using. While I've been using this for my day to day work for the past year, I don't consider it ready for wider adoption yet. It's still experimental and undergoing frequent infrastructure/API changes and I've just updated the README to indicate this.
With that in mind, I'm not in a place where I want to start writing guides and documentation. I will focus on that once things start to stabilize and are approaching an alpha release.


CookieConsent does not exist in MVC template

CookieConsent does not exist in MVC template
Using .NET Core 3.0 rc1 with VS 2019 Preview MVC template, the project does not contains CookieConsent.
Also...
I’ve tried to add CookieConsent partial view, added Startup config for CookieConsent and added partial tag helper to the _Layout but the consent still did not appear.

This issue was moved to aspnet/AspNetCore#14159


[stable/gocd] Support tls for ingress

What this PR does / why we need it:
Add tls support for gocd ingress.
Special notes for your reviewer:

/assign @viglesiasce

cc @varshavaradarajan

/assign

Any plan to merge this PR?

@hemslo - sorry for the late reply. Yes. I'm testing this out. I'll put up a comment once done.

@hemslo - can you please update the README.md ?

@varshavaradarajan sure, updated.

@unguiculus - the changes lgtm. Can you go ahead and review this and merge it if you have no problems?

@unguiculus The tls support is get by default when run helm create a new chart, so I think it's just a patch.

Can this PR be merged? TLS is needed for gocd agent outside kubernetes cluster, using official chart is easier than maintaining my own fork.

/ok-to-test

/lgtm


envoy communication is not working

We are trying to install edge-stack 3.6 and integrate with Cognito authorization for our product.
the communication from edge-stack to the cognito is failing and unable to reach grpc.

{"user_agent.name":"-","http":{"request":{"headers":{"x_forwarded_proto":"-","content-length":"-","correlation-id":"-","accept":"-","x_forwarded_for":"-","x_envoy_decorator_operation":"-","id":"-","session-id":"-","x_b3_parentspanid":"-","x_b3_traceid":"-","content-type":"-","authority":"-","x_envoy_internal":"-","x_envoy_expected_rq_timeout_ms":"-","host":"-","x_b3_spanid":"-","x_b3_sampled":"-"},"duration_req":"-","duration":"0","body":{"bytes":"0"},"path":"-","method":"-"},"version":"HTTP/1.1","response":{"headers":{"access-control-allow-origin":"-","date":"Thu, 18 May 2023 18:35:51 GMT","server":"envoy","content-length":"11","content-type":"text/plain"},"body":{"bytes":"11"},"status_code_details":"http1.codec_error","flags":"DPE","duration_tx":"-","duration_resp":"-","status_code":"400"}},"@timestamp":"2023-05-18T18:35:51.897Z","network":{"direction":"inbound"},"client":{"remote":{"address_no_port":"<IP_ADDRESS>"},"address":"<IP_ADDRESS>:65113","sni":"mydomain.com","tls":{"cipher":"-","version":"-","session_id":"-"},"local":{"address":"<IP_ADDRESS>:8443"},"direct":{"remote":{"address":"<IP_ADDRESS>:65113"}},"certificate":{"peer":{"cert_v_start":"-","serial":"-","cert_v_end":"-","issuer":"-","uri_san":"-","certificate":"-"},"local":{"uri_san":"-","subject":"-"}}},"host":{"hostname":"edge-stack-84cdb998b4-9tmf6"},"server":{"address":"-"},"log":{"level":"info"},"envoy":{"upstream":{"transport_failure_reason":"-","cluster":"-","localaddress":"-"},"route":{"name":"-"}}}

TLSContext
Name:         mydomain.com
Namespace:    ambassador
Labels:
Annotations:
API Version:  getambassador.io/v2
Kind:         TLSContext
Metadata:
Creation Timestamp:  2023-05-15T22:11:37Z
Generation:          4
Managed Fields:
API Version:  getambassador.io/v3alpha1
Fields Type:  FieldsV1
fieldsV1:
f:metadata:
f:annotations:
f:spec:
.:
f:hosts:
f:min_tls_version:
f:secret:
Manager:      kubectl-client-side-apply
Operation:    Update
Time:         2023-05-15T22:11:37Z
API Version:  getambassador.io/v2
Fields Type:  FieldsV1
fieldsV1:
f:metadata:
f:annotations:
f:kubectl.kubernetes.io/last-applied-configuration:
f:spec:
f:alpn_protocols:
Manager:         kubectl-edit
Operation:       Update
Time:            2023-05-16T20:27:13Z
Resource Version:  481783395
UID:               dee4ffb1-b381-4bdd-b282-5882f8247f2e
Spec:
alpn_protocols:  h2[, http/1.1]
ambassador_id:
--apiVersion-v3alpha1-only--default
Hosts:
mycorp.com
min_tls_version:  v1.2
Secret:           ambassador-certs
Events:

apiVersion: getambassador.io/v2
kind: TLSContext
metadata:
  name: hostkkk.zzz.com
  namespace: ambassador
spec:
  alpn_protocols: h2[, http/1.1]
  ambassador_id:
    - '--apiVersion-v3alpha1-only--default'
  hosts:
    - hostkkk.zzz.com
  min_tls_version: v1.2
  secret: ambassador-certs

Name:         ambassador
Namespace:    ambassador
Labels:       app.kubernetes.io/component=edge-stack-ratelimit
app.kubernetes.io/instance=edge-stack
app.kubernetes.io/managed-by=Helm
app.kubernetes.io/name=edge-stack
app.kubernetes.io/part-of=edge-stack
helm.sh/chart=emissary-ingress-8.6.0
product=aes
Annotations:  meta.helm.sh/release-name: edge-stack
meta.helm.sh/release-namespace: ambassador
API Version:  getambassador.io/v2
Kind:         Module
Metadata:
Creation Timestamp:  2023-05-12T18:47:15Z
Generation:          4
Managed Fields:
API Version:  getambassador.io/v3alpha1
Fields Type:  FieldsV1
fieldsV1:
f:metadata:
f:annotations:
.:
f:meta.helm.sh/release-name:
f:meta.helm.sh/release-namespace:
f:labels:
.:
f:app.kubernetes.io/component:
f:app.kubernetes.io/instance:
f:app.kubernetes.io/managed-by:
f:app.kubernetes.io/name:
f:app.kubernetes.io/part-of:
f:helm.sh/chart:
f:product:
f:spec:
.:
f:config:
Manager:      helm
Operation:    Update
Time:         2023-05-12T18:47:15Z
API Version:  getambassador.io/v2
Fields Type:  FieldsV1
fieldsV1:
f:spec:
f:config:
f:admin_port:
f:diagnostics:
f:enabled:
f:envoy_log_format:
.:
f:@timestamp:
f:client:
.:
f:address:
f:certificate:
.:
f:local:
.:
f:subject:
f:uri_san:
f:peer:
.:
f:cert_v_end:
f:cert_v_start:
f:certificate:
f:issuer:
f:serial:
f:uri_san:
f:direct:
.:
f:remote:
.:
f:address:
f:local:
.:
f:address:
f:remote:
.:
f:address_no_port:
f:sni:
f:tls:
.:
f:cipher:
f:session_id:
f:version:
f:envoy:
.:
f:route:
.:
f:name:
f:upstream:
.:
f:cluster:
f:localaddress:
f:transport_failure_reason:
f:host:
.:
f:hostname:
f:http:
.:
f:request:
.:
f:body:
.:
f:bytes:
f:duration:
f:duration_req:
f:headers:
.:
f:accept:
f:authority:
f:content-length:
f:content-type:
f:correlation-id:
f:host:
f:id:
f:session-id:
f:x_b3_parentspanid:
f:x_b3_sampled:
f:x_b3_spanid:
f:x_b3_traceid:
f:x_envoy_decorator_operation:
f:x_envoy_expected_rq_timeout_ms:
f:x_envoy_internal:
f:x_forwarded_for:
f:x_forwarded_proto:
f:method:
f:path:
f:response:
.:
f:body:
.:
f:bytes:
f:duration_resp:
f:duration_tx:
f:flags:
f:headers:
.:
f:access-control-allow-origin:
f:content-length:
f:content-type:
f:date:
f:server:
f:status_code:
f:status_code_details:
f:version:
f:log:
.:
f:level:
f:network:
.:
f:direction:
f:server:
.:
f:address:
f:user_agent.name:
f:envoy_log_type:
f:lua_scripts:
Manager:         kubectl-edit
Operation:       Update
Time:            2023-05-18T18:28:04Z
Resource Version:  482880666
UID:               f9405bc7-a102-4b43-b418-d1cb76816039
Spec:
ambassador_id:
--apiVersion-v3alpha1-only--default
Config:
admin_port:  8001
Diagnostics:
allow_non_local:  true
Enabled:          true
envoy_log_format:
@timestamp:  %START_TIME%
Client:
Address:  %DOWNSTREAM_REMOTE_ADDRESS%
Certificate:
Local:
Subject:  %DOWNSTREAM_LOCAL_SUBJECT%
uri_san:  %DOWNSTREAM_LOCAL_URI_SAN%
Peer:
cert_v_end:    %DOWNSTREAM_PEER_CERT_V_END%
cert_v_start:  %DOWNSTREAM_PEER_CERT_V_START%
Certificate:   %DOWNSTREAM_PEER_CERT%
Issuer:        %DOWNSTREAM_PEER_ISSUER%
Serial:        %DOWNSTREAM_PEER_SERIAL%
uri_san:       %DOWNSTREAM_PEER_URI_SAN%
Direct:
Remote:
Address:  %DOWNSTREAM_DIRECT_REMOTE_ADDRESS%
Local:
Address:  %DOWNSTREAM_LOCAL_ADDRESS%
Remote:
address_no_port:  %DOWNSTREAM_REMOTE_ADDRESS_WITHOUT_PORT%
Sni:                %REQUESTED_SERVER_NAME%
Tls:
Cipher:      %DOWNSTREAM_TLS_CIPHER%
session_id:  %DOWNSTREAM_TLS_SESSION_ID%
Version:     %DOWNSTREAM_TLS_VERSION%
Envoy:
Route:
Name:  %ROUTE_NAME%
Upstream:
Cluster:                   %UPSTREAM_CLUSTER%
Localaddress:              %UPSTREAM_LOCAL_ADDRESS%
transport_failure_reason:  %UPSTREAM_TRANSPORT_FAILURE_REASON%
Host:
Hostname:  %HOSTNAME%
Http:
Request:
Body:
Bytes:       %BYTES_RECEIVED%
Duration:      %DURATION%
duration_req:  %REQUEST_DURATION%
Headers:
Accept:                          %REQ(ACCEPT)%
Authority:                       %REQ(:AUTHORITY)%
Content - Length:                %REQ(CONTENT-LENGTH)%
Content - Type:                  %REQ(CONTENT-TYPE)%
Correlation - Id:                %REQ(CORRELATION-ID)%
Host:                            %REQ(HOST)%
Id:                              %REQ(X-REQUEST-ID)%
Session - Id:                    %REQ(SESSION-ID)%
x_b3_parentspanid:               %REQ(X-B3-PARENTSPANID)%
x_b3_sampled:                    %REQ(X-B3-SAMPLED)%
x_b3_spanid:                     %REQ(X-B3-SPANID)%
x_b3_traceid:                    %REQ(X-B3-TRACEID)%
x_envoy_decorator_operation:     %REQ(X-ENVOY-DECORATOR-OPERATION)%
x_envoy_expected_rq_timeout_ms:  %REQ(X-ENVOY-EXPECTED-RQ-TIMEOUT-MS)%
x_envoy_internal:                %REQ(X-ENVOY-INTERNAL)%
x_forwarded_for:                 %REQ(X-FORWARDED-FOR)%
x_forwarded_proto:               %REQ(X-FORWARDED-PROTO)%
Method:                            %REQ(:METHOD)%
Path:                              %REQ(X-ENVOY-ORIGINAL-PATH?:PATH)%
Response:
Body:
Bytes:        %BYTES_SENT%
duration_resp:  %RESPONSE_DURATION%
duration_tx:    %RESPONSE_TX_DURATION%
Flags:          %RESPONSE_FLAGS%
Headers:
Access - Control - Allow - Origin:  %RESP(ACCESS-CONTROL-ALLOW-ORIGIN)%
Content - Length:                   %RESP(CONTENT-LENGTH)%
Content - Type:                     %RESP(CONTENT-TYPE)%
Date:                               %RESP(DATE)%
Server:                             %RESP(SERVER)%
status_code:                          %RESPONSE_CODE%
status_code_details:                  %RESPONSE_CODE_DETAILS%
Version:                                %PROTOCOL%
Log:
Level:  info
Network:
Direction:  inbound
Server:
Address:        %UPSTREAM_HOST%
user_agent.name:  %REQ(USER-AGENT)%
envoy_log_type:     json
lua_scripts:        function envoy_on_request(request_handle)
local authority = request_handle:headers():get(":authority")
if(string.find(authority, ":") ~= nil)
then
local authority_index = string.find(authority, ":")
local stripped_authority = string.sub(authority, 1, authority_index - 1)
request_handle:headers():replace(":authority", stripped_authority)
end
end

previous version of module:
apiVersion: getambassador.io/v2
kind: Module
metadata:
annotations:
meta.helm.sh/release-name: edge-stack
meta.helm.sh/release-namespace: ambassador
creationTimestamp: "2023-05-12T18:47:15Z"
generation: 4
labels:
app.kubernetes.io/component: edge-stack-ratelimit
app.kubernetes.io/instance: edge-stack
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: edge-stack
app.kubernetes.io/part-of: edge-stack
helm.sh/chart: emissary-ingress-8.6.0
product: aes
name: ambassador
namespace: ambassador
resourceVersion: "482880666"
uid: e9405bc7-a102-4b43-b418-d1cb76816039
spec:
ambassador_id:

--apiVersion-v3alpha1-only--default
config:
diagnostics:
allow_non_local: true
enabled: true

`apiVersion: getambassador.io/v2
kind: Module
metadata:
annotations:
meta.helm.sh/release-name: edge-stack
meta.helm.sh/release-namespace: ambassador
creationTimestamp: "2023-05-12T18:47:15Z"
generation: 4
labels:
app.kubernetes.io/component: edge-stack-ratelimit
app.kubernetes.io/instance: edge-stack
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: edge-stack
app.kubernetes.io/part-of: edge-stack
helm.sh/chart: emissary-ingress-8.6.0
product: aes
name: ambassador
namespace: ambassador
resourceVersion: "482880666"
uid: e9405bc7-a102-4b43-b418-d1cb76816039
spec:
ambassador_id:

--apiVersion-v3alpha1-only--default
config:
diagnostics:
allow_non_local: true
enabled: true`

apiVersion: getambassador.io/v2
kind: Module
metadata:
annotations:
meta.helm.sh/release-name: edge-stack
meta.helm.sh/release-namespace: ambassador
creationTimestamp: '2023-05-12T18:47:15Z'
generation: 4
labels:
app.kubernetes.io/component: edge-stack-ratelimit
app.kubernetes.io/instance: edge-stack
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: edge-stack
app.kubernetes.io/part-of: edge-stack
helm.sh/chart: emissary-ingress-8.6.0
product: aes
name: ambassador
namespace: ambassador
spec:
ambassador_id:
- '--apiVersion-v3alpha1-only--default'
config:
admin_port: 8001
diagnostics:
allow_non_local: true
enabled: true

kind: Module
metadata:
  annotations:
    meta.helm.sh/release-name: edge-stack
    meta.helm.sh/release-namespace: ambassador
  creationTimestamp: '2023-05-12T18:47:15Z'
  generation: 4
  labels:
    app.kubernetes.io/component: edge-stack-ratelimit
    app.kubernetes.io/instance: edge-stack
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: edge-stack
    app.kubernetes.io/part-of: edge-stack
    helm.sh/chart: emissary-ingress-8.6.0
    product: aes
  name: ambassador
  namespace: ambassador
spec:
  ambassador_id:
    - '--apiVersion-v3alpha1-only--default'
  config:
    admin_port: 8001
    diagnostics:
      allow_non_local: true
      enabled: true```

Thanks for attending our help session.  As noted we are more strict about mapping gRPC calls than before.  gRPC clients may add the ports to the host header, as noted [here (https://www.getambassador.io/docs/emissary/latest/howtos/grpc#working-with-host-headers-that-include-the-port).
There is a Lua script noted there you can use in the Module to make headers align.  Also suggest using Linkerd with dashboard inspection which lets you inspect the request as it travels between ambassador and the Cognito device and any services acting as filters, to investigate further.

Hi @rmyadarapu , did these suggestions help at all?  Would you like to meet again in another help session to try them out?

Closing for lack of response.


rerender

Additional comment:
No response

@conda-forge-admin please rerender

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I rerendered the recipe in conda-forge/textual-feedstock#17.


Keybase sigchain and KBFS?

Quick question:
Does KBFS embed any statements in my signature chain? Files in my public directory? Creation of private sharing directories? Thanks!

In progress!

(Not implemented just yet, but close..)

To clarify, I think @maxtaco is talking about the site-wide Keybase merkle root, not your individual sigchain.  We can't embed anything into your individual sigchain since that would need to be signed by one of your devices!

Err, I guess your local KBFS install could add stuff to your local sigchain, but we have no plans to do that.  For what we are planning, see Section 5 of this doc: https://keybase.io/docs/crypto/kbfs

Thanks. This is the stuff my devs will be very interested in building on top of; so I am watching with bated breath.


refactor(connector): added amount conversion framework for gocardless

Type of Change

[x] Refactoring

Description

This PR adds amount conversion framework to gocardless
Note: gocardless works in MinorUnit
Additional Changes

[ ] This PR modifies the API contract
[ ] This PR modifies the database schema
[ ] This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Flows to test in Volt

Authorize

curl --location 'http://<IP_ADDRESS>:8080/payments/pay_vgk395wbqnod3OB2zXFp/confirm' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: pk_dev_04fba5ffde1d424db84230af54a85032' \
--data-raw '{
   "client_secret": "pay_vgk395wbqnod3OB2zXFp_secret_td2HlVcKKrNdLOrSKXKb",
   "return_url": "https://duck.com/completion",
   "payment_method": "bank_debit",
   "setup_future_usage": "off_session",
   "payment_method_type": "ach",
   "payment_type": "setup_mandate",
   "payment_method_data": {
       "bank_debit": {
           "ach_bank_debit": {
               "billing_details": {
                   "name": "Shivam S",
                   "email"<EMAIL_ADDRESS>                   "address": {
                       "line1": "123",
                       "line2": "123",
                       "city": "vjnsf",
                       "state": "Alaska",
                       "zip": "10001",
                       "country": "US"
                   }
               },
               "account_number": "27155003358",
               "bank_account_holder_name": "tests tests",
               "routing_number": "026073150",
               "bank_type": "checking"
           }
       }
   },
   "mandate_data": {
       "customer_acceptance": {
           "acceptance_type": "online",
           "accepted_at": "2023-12-07T12:16:08.622Z",
           "online": {
               "user_agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36"
           }
       }
   },
   "browser_info": {
       "user_agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36",
       "accept_header": "text\\/html,application\\/xhtml+xml,application\\/xml;q=0.9,image\\/webp,image\\/apng,*\\/*;q=0.8",
       "language": "en-GB",
       "color_depth": 24,
       "screen_height": 1440,
       "screen_width": 2560,
       "time_zone": -330,
       "java_enabled": true,
       "java_script_enabled": true,
       "ip_address": "<IP_ADDRESS>"
   }
}'
}'

Refund

Checklist

[x] I formatted the code cargo +nightly fmt --all
[x] I addressed lints thrown by cargo clippy
[x] I reviewed the submitted code
[ ] I added unit tests for my changes where possible

postman check and CI is failing, please check


[Bug] FlutterRustBridgeBase should be singletons

Describe the bug
The app can be compiled into a release version and it works on my phone.
Working well in the local environment, debugge, and release mode.
But, when published to Apple TestFlight, an error occurs.  It can't run on my phone
Exception: Subclasses of
'FlutterRustBridgeBase should be singletons - there should not be two instances (runtimeType=RustPlatform)

Codegen logs with RUST_LOG=debug environment variable
2023/09/21 01:51:24 [INFO] Phase: Running build_runner
2023/09/21 01:51:24 [INFO] Running build_runner at /Users/liuxing/Documents/gitproject/keychat-melos/packages/app
2023/09/21 01:51:24 [DEBUG] Guessing toolchain the runner is run into
2023/09/21 01:51:24 [DEBUG] execute command: bin=sh args="-c \"flutter\" \"pub\" \"run\" \"build_runner\" \"build\" \"--delete-conflicting-outputs\" \"--enable-experiment=class-modifiers\"" current_dir=Some("/Users/liuxing/Documents/gitproject/keychat-melos/packages/app") cmd=cd "/Users/liuxing/Documents/gitproject/keychat-melos/packages/app" && "sh" "-c" "\"flutter\" \"pub\" \"run\" \"build_runner\" \"build\" \"--delete-conflicting-outputs\" \"--enable-experiment=class-modifiers\""
2023/09/21 01:51:27 [DEBUG] command=cd "/Users/liuxing/Documents/gitproject/keychat-melos/packages/app" && "sh" "-c" "\"flutter\" \"pub\" \"run\" \"build_runner\" \"build\" \"--delete-conflicting-outputs\" \"--enable-experiment=class-modifiers\"" stdout=[INFO] Generating build script...
[INFO] Generating build script completed, took 225ms

[INFO] Initializing inputs
[INFO] Reading cached asset graph...
[INFO] Reading cached asset graph completed, took 137ms

[INFO] Checking for updates since last build...
[INFO] Checking for updates since last build completed, took 797ms

[INFO] Running build...
[INFO] Running build completed, took 15ms

[INFO] Caching finalized dependency graph...
[INFO] Caching finalized dependency graph completed, took 84ms

[INFO] Succeeded after 105ms with 0 outputs (0 actions)

 stderr=
2023/09/21 01:51:27 [INFO] Phase: Formatting Dart code
2023/09/21 01:51:27 [DEBUG] execute format_dart path=["/Users/liuxing/Documents/gitproject/keychat-melos/packages/app/lib/bridge_generated.dart", "/Users/liuxing/Documents/gitproject/keychat-melos/packages/app/lib/bridge_definitions.dart", "/Users/liuxing/Documents/gitproject/keychat-melos/packages/app/lib/bridge_definitions.freezed.dart"] line_length=80
2023/09/21 01:51:27 [DEBUG] execute command: bin=sh args="-c \"dart\" \"format\" \"--line-length\" \"80\" \"/Users/liuxing/Documents/gitproject/keychat-melos/packages/app/lib/bridge_generated.dart\" \"/Users/liuxing/Documents/gitproject/keychat-melos/packages/app/lib/bridge_definitions.dart\" \"/Users/liuxing/Documents/gitproject/keychat-melos/packages/app/lib/bridge_definitions.freezed.dart\"" current_dir=None cmd="sh" "-c" "\"dart\" \"format\" \"--line-length\" \"80\" \"/Users/liuxing/Documents/gitproject/keychat-melos/packages/app/lib/bridge_generated.dart\" \"/Users/liuxing/Documents/gitproject/keychat-melos/packages/app/lib/bridge_definitions.dart\" \"/Users/liuxing/Documents/gitproject/keychat-melos/packages/app/lib/bridge_definitions.freezed.dart\""
2023/09/21 01:51:28 [DEBUG] command="sh" "-c" "\"dart\" \"format\" \"--line-length\" \"80\" \"/Users/liuxing/Documents/gitproject/keychat-melos/packages/app/lib/bridge_generated.dart\" \"/Users/liuxing/Documents/gitproject/keychat-melos/packages/app/lib/bridge_definitions.dart\" \"/Users/liuxing/Documents/gitproject/keychat-melos/packages/app/lib/bridge_definitions.freezed.dart\"" stdout=Formatted /Users/liuxing/Documents/gitproject/keychat-melos/packages/app/lib/bridge_generated.dart
Formatted /Users/liuxing/Documents/gitproject/keychat-melos/packages/app/lib/bridge_definitions.dart
Formatted 3 files (2 changed) in 0.29 seconds.
 stderr=
2023/09/21 01:51:28 [INFO] Success!
2023/09/21 01:51:28 [INFO] Now go and use it :)

To Reproduce
No response
Expected behavior
No response
Generated binding code
No response
OS
MacOs
Version of flutter_rust_bridge_codegen
1.82.1
Flutter info
[✓] Flutter (Channel stable, 3.13.4, on macOS 13.5.2 22G91 darwin-arm64, locale zh-Hans-CN)
    • Flutter version 3.13.4 on channel stable at /Users/liuxing/fvm/versions/3.13.4
    • Upstream repository https://github.com/flutter/flutter.git
    • FLUTTER_GIT_URL = https://github.com/flutter/flutter.git
    • Framework revision 367f9ea16b (8 days ago), 2023-09-12 23:27:53 -0500
    • Engine revision 9064459a8b
    • Dart version 3.1.2
    • DevTools version 2.25.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
    • Android SDK at /Users/liuxing/Library/Android/sdk
    • Platform android-33, build-tools 33.0.2
    • ANDROID_HOME = /Users/liuxing/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A240d
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.82.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.72.0

[✓] Connected device (3 available)
    • Ttttttttttt (mobile) • ce2dc3828af67a761c80ba46ddcb842e41e18759 • ios            • iOS 16.6.1 20G81
    • macOS (desktop)      • macos                                    • darwin-arm64   • macOS 13.5.2 22G91 darwin-arm64
    • Chrome (web)         • chrome                                   • web-javascript • Google Chrome 117.0.5938.62
    ! Error: Browsing on the local area network for iPhone. Ensure the device is unlocked and attached with a cable or associated with the same
      local area network as this Mac.
      The device must be opted into Developer Mode to connect wirelessly. (code -27)

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Version of clang++
No response
Version of ffigen
ffigen: 8.0.2
Additional context
It work fine when Xcode 14, but the system automatically upgraded to Xcode 15
Init code
import 'dart:io';

import 'package:app/bridge_generated.dart';
import 'package:flutter_rust_bridge/flutter_rust_bridge.dart';

const _base = 'rust';

final _dylib = Platform.isWindows ? '$_base.dll' : 'lib$_base.so';
final dylib = loadLibForFlutter(_dylib);
final rustapi = RustImpl(dylib);

Hi, could you please provide a minimal reproducible sample?
Especially, check your subclasses of FlutterRustBridgeBase, and how they gets initilaized.

Hi, could you please provide a minimal reproducible sample?
Especially, check your subclasses of FlutterRustBridgeBase, and how they gets initilaized.

Init code
import 'dart:io';
import 'package:app/bridge_generated.dart';
import 'package:flutter_rust_bridge/flutter_rust_bridge.dart';

const _base = 'rust';
final _dylib = Platform.isWindows ? '$_base.dll' : 'lib$_base.so';
final dylib = loadLibForFlutter(_dylib);
final rustapi = RustImpl(dylib);

class RustImpl implements Rust {
  final RustPlatform _platform;
  factory RustImpl(ExternalLibrary dylib) => RustImpl.raw(RustPlatform(dylib));

Other files
rustapi.callA()
rustapi.callB()
dart is single-threaded
I can confirm that the code only calls the constructor once
why does this subclass get initialized twice?

I can confirm that the code only calls the constructor once
why does this subclass get initialized twice?

Then I suggest a simple print-based trick to see what happens:
Modify the constructor of FlutterRustBridgeBase - it is in frb library code, but you can just modify .dart file and it works.
Add like:
print(StackTrace.current.toString());

Then you know the full stack when it is called.
you should see 2 stacks (since the error says you init it twice) and debug the stack

It feels like there is a conflict with oneSingle 5.0.
It works fine with oneSingle3.5

@fzyzcjy I'm also getting this issue (when running on iOS - Android is totally fine). I tried adding that debugging line to the NativePlatform constructors (both the io and web versions), but nothing is output. I presume it's crashing in the super constructor call before reaching the print statements, but that also implies that one is calling the other recursively, as otherwise at least one of the print statements should have been executed...

I presume it's crashing in the super constructor call before reaching the print statements

Then maybe we can add print there. Dart/Flutter is quite friendly since we are allowed to modify any arbitrary 3rd party code (e.g. frb, when used in your project) and it understands that it is changed.
Btw, sometimes such modification does not work immediately. You may need not only a hot reload / hot restart, but also stop your app, and recompile it and rerun it (i.e. flutter run)

Cool, I didn't realize we could modify flutter dependencies like that. Alright, so from that I found that I had two stateful widgets making frb calls to my rust code in their initState functions. I guess flutter doesn't guarantee interleaving behavior of those calls, so it was working on Android but not on iOS. I believe that's fixed now and I'm just getting an unrelated error about it failing to lookup symbols in the dylib. But I can search elsewhere for that. Thanks!

Just as a note, though, I wasn't constructing the rust bridge object manually twice, I was just referencing the auto-generated static reference to it in two different places. So I feel like this is something that frb could actually fix. It seems like instead of using a constructor and asserting that it's a singleton, we could use a factory function that uses a global cache to automatically return the single instance if one already has been created.

I was just referencing the (same) auto-generated static reference to it in two different places.

That's weird! Could you please show a minimal reproducible sample? Then maybe we are able to fix it


fix(docs): Update Bootstrap to alpha.5 and switch to flexbox enabled …

Updated to Bootstrap v4-alpha.5 which contains a precompiled CSS file with flex enabled, and updated Webpack alias to use this one.
Now the Layout example in the docs is fine.

@ronnyhaase woot!


[procedures local to global Request] Table 900 - Assembly Header - ValidateDueDate, ValidateEndDate, ValidateStartDate

Dear ALAppExtensions team,
JesperShultz wrote on 22 Mar that request https://github.com/microsoft/ALAppExtensions/issues/11737 would be shipped either in an update for the current version or in the next major release.
At the the time of request https://github.com/microsoft/ALAppExtensions/issues/11737 te current version was 17.4
Current version is 18.2.
I did just download BC 18.2 but unfortunately the 3 regarding function are local still .

You have requested #11737 on March 19, and expected to get it into April 1 release. That was not possible as we had code freeze for April 1 release end of February. We already implemented required changes in next major version (=19.0). Please request earlier next time.


Skipping to specific timecodes of songs

I have no clue how this would be done but it would help with songs that have intros to their music videos. Whenever you get the chance.


verification/microdeposit: move routes, repository, etc into sub-package

Codecov Report

Merging #433 into master will decrease coverage by 4.11%.
The diff coverage is 55.38%.

@@            Coverage Diff             @@
##           master     #433      +/-   ##
==========================================
- Coverage   59.55%   55.43%   -4.12%
==========================================
  Files          88       92       +4
  Lines        7758     7744      -14
==========================================
- Hits         4620     4293     -327
- Misses       2469     2827     +358
+ Partials      669      624      -45

Impacted Files
Coverage Δ

internal/depository/admin.go
100% <ø> (ø)
:arrow_up:

internal/filetransfer/file_transfer.go
65.11% <ø> (ø)
:arrow_up:

.../depository/verification/microdeposit/attempter.go
59.25% <ø> (ø)

internal/depository/mock_depository_repo.go
25.64% <0%> (-2.94%)
:arrow_down:

...nal/depository/verification/microdeposit/cursor.go
70% <100%> (ø)

internal/depository/depository_admin.go
67.56% <100%> (ø)
:arrow_up:

...sitory/verification/microdeposit/micro_deposits.go
100% <100%> (ø)

...rnal/depository/verification/microdeposit/admin.go
62.96% <100%> (ø)

cmd/server/main.go
16.39% <14.28%> (-0.49%)
:arrow_down:

internal/depository/repository.go
58.91% <16.66%> (-5.66%)
:arrow_down:

... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 331713b...c3209a7. Read the comment docs.


account: Choose User is the default selection when the user role is Domain Admin

Fixes #746
@rhtyd cc @svenvogel

@blueorangutan package

@utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/754 (JID-3524)

@blueorangutan package

@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/754 (JID-3526)


regexpr.pas fix for Delphi 2010

Small fix for issue #244
Not tested under other Delphi version.

@andgineer we can apply but without 2nd part (refactoring for IFDEF Unicode).
No reason to refactor here.

@mirkasp
Could you please change PR according to Alexey's comment?

@andgineer Pls close w/o applying, the Delphi part of this patch was fixed already.


Implement list_languages

@pengwynn
I have finished the list_languages method as well as its spec, could you help me check if any problem with them? Thanks!

@zqzas Looks perfect! :zap:
Let me get the API docs in place first before we open a pull in the canonical repo. I'll ping you when I do.


frontend should know which hdx conf is being used

Fixed in 008180a3e7569c09bad55161172ca387920afddc by generating dataset URLs as part of HDXExportRegion.datasets


Use jaeger fraction in mp-ot example

Signed-off-by: Pavol Loffay<EMAIL_ADDRESS>

@kenfinnigan could you please review?


Disable path.config when using elasticsearch centralised pipeline management

Module version: 6.0.2
Puppet version: 4.8.7
OS and version: Debian Jessie

Expected behavior:
When using xpack.management.enabled: true logstash won't start and pop the following error.
Logstash logs:
[2018-03-06T14:27:11,489][ERROR][logstash.configmanagement.bootstrapcheck] There are config files (1) in the '/etc/logstash/conf.d' folder. Elasticsearch is configured as the config store so configs cannot be sourced via the command line with -f or via logstash.yml with path.config
[2018-03-06T14:27:11,495][ERROR][org.logstash.Logstash    ] java.lang.IllegalStateException: org.jruby.exceptions.RaiseException: (SystemExit) exit

As the way it's working for pipeline configuration, we should delete the path.config param from logstash.yml if the X-Pack management feature is used.
Exemple for pipeline management : here
Found in the puppet-logstash README file : "Note that specifying pipelines will automatically remove the default path.config setting from logstash.yml, since this is incompatible with pipelines.yml." (source)
Pretty easy to fix I guess. Actually I found a work-around using this in settings :
'path' => {
     'config' => ''
},

This is a truly excellent analysis and bug report. Thanks for your care and effort here!
#362 implements your suggestion. Very happy to have your feedback on this patch.
Thanks.


Automated conversion of plugin packages (PyPI -> Conda)

🧰 Task
This should be easy to automate with Grayskull and could give us an idea on how tricky this task might be, either if it's a one-off task (first migration) or a service we end up providing.

This issue was originally conceived to better support PyPI packages in the bundled plugin manager, but with NAP-2 we will offer direct support for them (as a warned fallback), so there's no need to convert anything.
Conversation might continue on https://github.com/napari/packaging/issues/7 if necessary.

so there's no need to convert anything.

Would we still first try to do some "conversion" or dependency checks so we only pip install any non found conda dependencies?

That will be provided by the npe2api payloads, I think!

That will be provided by the npe2api payloads, I think!

I am talking about non listed plugins here. An author wanting to share a plugin before hub publication.

At that point I'd say they are on their own, and we'll let them know with a big warning. I'll leave this open just in case, though.

Users following this issue should take a look at https://github.com/conda-incubator/conda-pypi, since it provides a way to install PyPI packages in a safe way for conda.

Jinkies! that looks really awesome @jaimergp !

This is madness, in the best possible way. 😃 🤯 The quickstart is super impressive: https://conda-incubator.github.io/conda-pypi/quickstart/
Can we recursively add this feature? micromamba uv pip install ... 😜
Seriously though: awesome work, a dream come true, and super important for the bundle/plugin ecosystem story. 🙏🙏🙏🙏🙏

Still super early development (added a warning in the docs now, hah), but it's indeed published in PyPI/conda-forge so feel free to try it out and submit your feedback. Just merged a PR so you can do:
cd napari/
conda pip install -e ./

It's veeeery barebones and somehow slow but should help with simple cases already.


Error when running New-AzSqlSyncMember

I am running the code snippet in this example in a very basic subscription that I only use for testing. When I run the command to create the new member I am getting the error.
New-AzSqlSyncMember: Cannot validate argument on parameter 'SqlServerDatabaseId'. The argument is null or empty. Provide an argument that is not null or empty, and then try the command again.
The reason seems quite obvious because in no point in the snippet $syncAgentInfo is initialized, which is used in one of the New-AzSqlSyncMember arguments:
-SqlServerDatabaseID  $syncAgentInfo.DatabaseId
This is puzzling me, is the code snippet incorrect?
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 856c3148-4309-2d97-d093-b29a4481cb8f
Version Independent ID: 0d057151-804f-3c7e-fc1f-be792b7e59f2
Content: PowerShell example-Sync between multiple Azure SQL databases - Azure SQL Database
Content Source: articles/sql-database/scripts/sql-database-sync-data-between-sql-databases.md
Service: sql-database
Sub-service: data-movement
GitHub Login: @stevestein
Microsoft Alias: sstein

@denimad, thank you for reaching out. We are looking into this and would get back to you soon on this thread.

@stevestein In reviewing this PowerShell example and as the customer has pointed out, the variable $syncAgentInfo has not been established anywhere is the script. The New-AzSqlSyncMember cmdlet is looking for the on-premise SQL Database ID (SqlServerDatabaseId as per the second example)
The Sync Agent Info section appears to not include a $syncAgentInfo variable to resolve:
 -SqlServerDatabaseID  $syncAgentInfo.DatabaseId

sync agent info
$syncAgentName = ""
$syncAgentResourceGroupName = ""
$syncAgentServerName = ""

Perhaps it should come from the member database info set of variables, where $memberDatabaseName is the correct value for -SqlServerDatabaseID but not sure if it is looking for an ID or Name value?

member database info
$syncMemberName = ""
$memberServerName = ""
$memberDatabaseName = ""
$memberDatabaseType = "SqlServerDatabase" # can be AzureSqlDatabase or SqlServerDatabase
$syncDirection = "Bidirectional" # can be Bidirectional, Onewaymembertohub, Onewayhubtomember

Hello, thank you for following up this case. For what´s worth, I have setup the data sync on my DB and setting the agent is not even necessary. You can delete all the syncAgent*** variables, remove the New-AzSqlSyncAgent command, and remove the -SyncAgent*** and -SqlServerDatabaseID arguments from New-AzSqlSyncMember command. DataSync Agent is necessary when using an on-prem DB, but in this tutorial, we are setting it between two Azure SQL DBs.
Other than that, this tutorial was very helpful for me, I wouldn't have found the information elsewhere.

@denimad Thank you for pointing this out and following-up with how you resolved it. Let me see if I can have the sample updated.

@denimad - thanks for the feedback.
We have an internal work item (1780954) to update the collection of data sync articles. Unfortunately, we currently don't have an estimated time of completion for this.
Thanks
#please-close


Add monthly contributor rewards claim

Added a new section under the Resources section called Rewards where the monthly contributor rewards can be claimed. I will be making it a bit easier for us to add new Merkle Distributors for future rewards in the next few days, but I wanted to get this out ASAP so everyone can easily claim their rewards.

Should be good to go now. Let me know if you want any additional changes.


Add support for mixed type introduced with PHP 8

Is your feature request related to a problem? Please describe.
With the introduction of PHP 8 JsonMapper should support the mixed type to support all active PHP versions.
Describe the solution you'd like
The parsing of doc block and properties should support the mixed return type which means the value is set as is from the json. No type casting should be applied. This has the downside that any implementation using the mixed type will not be type safe, this can be a implementation detail which should not affect JsonMapper
Describe alternatives you've considered
None, as the mixed type is a native feature of PHP 8 (and has been PHP < 8 using doc blocks)
Additional context
https://wiki.php.net/rfc/mixed_type_v2

Fixed with PR #39