Problem when trying to disable dark mode on Android.

Hello people,
I'm learning react / react native and along, making an app to practice. What is happening is that when the device's darkmode is active it implies the colors chosen in the application (an example below). I do not intend to invest time in and do darkmode now, I would like to learn more about React, make the whole app, and then go to the more "superficial" parts and make darkmode within the config of the app itself.
Would it be possible to inhibit / prevent the device's Dark Mode from interfering with the colors of the app?
It's done with my app design 😥
I'm testing the app on a Xiaomi Mi 9T Pro, I also tested it on the S10 + and it didn't happen, it seems that MiUI forces DarkMode ...
Thank you.
React Native version:
"react": "16.11.0",
"react-native": "0.62.2",
Possible solutions that I was unable to make work.
I found the following code below talking to put in the onCreate method of MainActivity.java, however it does not have this method there. I don't know where and how I can do it.
AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_NO)

MainApplication have onCreate method. But nothing changes. App still changes colors

Same problem here... Same React and RN version. Added AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_NO);to onCreate() method on MainApplication.java and on Xiaomi the background color changes, which is very bad for the app as it relies on a pure white background. On other devices it works ok. Any clue to a fix?

I also have the same problem. I'm running with Expo, also with Xiaomi devices something overrides my styles with Styled Components. Even the splash screen, that's an white SVG, is replaced by a black SVG.

How is this issue is closed? there is no answer at all...

Would it be possible to inhibit / prevent the device's Dark Mode from interfering with the colors of the app?

I'm certainly no expert on Android's dark mode support, but is there some top-level thing you can declare in the app that opts you out of this? Not a React Native things separately, but just something part of the Android platform that lets you opt out. It should be a standard scenario to have apps that aren't built to handle both light/dark mode and don't want the change in styling. I don't have that answer but maybe StackOverflow is a better resource here? Speak up if you think there's something specific to React Native that's going wrong here.

With RN version 0.63.2 this issue is solved. Checked just now.

@joan2404 Tried that. It didn't work for me. Checked the changelog and saw there was nothing specific to dark mode on Xiaomi devices. What I have noticed is that it only affects icons and svgs.

@ff-joaquin-rojas You're right, it could have been a temporary error of the device. I installed a new build with the latest react native and it worked fine, but after a reboot of the device the problem appeared again. However in my case the probem is with the background, it's pure white and it changes the color to black. Problem not fixed yet.

Same here w RN 0.63.2

Dear @RBalconi, the exact solution to turn off the force dark mode on Android is this Stack Overflow post.
@RigottiG @joan2404 @ff-joaquin-rojas @eliasjnior @inferusvv

Dear @RBalconi, the exact solution to turn off the force dark mode on Android is this Stack Overflow post.
@RigottiG @joan2404 @ff-joaquin-rojas @eliasjnior @inferusvv

I don't know who you are or where you came from, but thank you, it works like a charm! You deserve all the best!

@ff-joaquin-rojas, I'm Amer known as amerllica come from Iran, and actually, it is my pleasure, thank you ❤ 🌹

does anyone have a solution to a Expo application ? same issue here...

Caro @RBalconi , a solução exata para desligar o modo escuro forçado no Android é esta postagem do Stack Overflow .
@RigottiG @ joan2404 @ ff-joaquin-rojas @eliasjnior @inferusvv

This does not work for the Xiaomi Mi 9T Pro

Dear @RBalconi, the exact solution to turn off the force dark mode on Android is this Stack Overflow post.
@RigottiG @joan2404 @ff-joaquin-rojas @eliasjnior @inferusvv

Tnx it's worked:)

Hey guys! I've found a solution to force the app to stay in Light-theme, I hope this works for you!
For Android: Go to android/app/src/main/res/values/styles.xml
and add the following line:
<item name="android:forceDarkAllowed">false</item>

The file will look like this:
<resources>
    <!-- Base application theme. -->
    <style name="AppTheme" parent="Theme.AppCompat.Light.NoActionBar">
        <!-- Customize your theme here. -->
        <item name="android:textColor">#000000</item>
        <item name="android:forceDarkAllowed">false</item>
    </style>
</resources>

For iOS: Go to the Info.plist and add the following code:
```
UIUserInterfaceStyle
Light

It worked for me.
Thanks!
Don't forget to restart your project and if possible test in a Xiomi Device.
(Try turn off dark theme with application running after, try turn on the dark theme, just for test)
If for IOS doesn't work, you will need execute
pod install

The solution works for other devices, on Xiaomi case, do not works for TextView or or TextHint from native android layout side, soon as I find a solution I'll post it here

I use expo-splash-screen and fix work only if I add it in two places.
Without second line fix does'n work for me.

@AndreyBaryshev thanks a lot

<!-- Base application theme. -->
<style name="AppTheme" parent="Theme.AppCompat.Light.NoActionBar">
    <!-- Customize your theme here. -->
    <item name="android:forceDarkAllowed">false</item>
    <item name="android:textColor">#000000</item>
</style>
<style name="SplashScreenTheme" parent="SplashScreen_SplashTheme">
    <item name="colorPrimaryDark">@color/status_bar_color</item>
</style>

It work for me

Dear @RBalconi, the exact solution to turn off the force dark mode on Android is this Stack Overflow post.
@RigottiG @joan2404 @ff-joaquin-rojas @eliasjnior @inferusvv

This worked for me. Thanks for providing this link!


fixed response being the string representation of a bytes array instead of a string

Currently, the exec_command function returns a string (contrary to the README). This string contains the __str__ representation of an array containing a byte sequence.
Current output:
print(response)
=> [b'----- Recently Disconnected Players [Max of 15] -----\x00\x00']
print(repr(response))
=> "[b'----- Recently Disconnected Players [Max of 15] -----\\x00\\x00']"

Guilty lines of code:
body_parts = []
while True:
    [...]
    body_parts.append(response.body)
[...]
return RconPacket(req_pkt.pkt_id, SERVERDATA_RESPONSE_VALUE,
                    ''.join(str(body_parts)))

As you can see, instead of joining the elements of body_parts, body_parts itself is converted into a string, resulting in the final output being a string representation of an array instead of the actual response content.
Output with my patch:
print(response)
=> ----- Recently Disconnected Players [Max of 15] -----
print(repr(response))
=> '----- Recently Disconnected Players [Max of 15] -----\x00\x00'

It might be smart to strip the null-bytes from the response content, since they're part of the RCON protocol. It didn't affect my use case though.

 Feel free to just pull my fork and jank it into your project. (Or even publish it yourself to PyPI. I'm also not working on this anymore.)


cannot move object on blue axis

Operating system or device - Godot version:
OS X, Steam version and current github HEAD too. Not tested other OSes/versions.
Issue description (what happened, and what was expected):
I cannot drag objects on blue axis.
Steps to reproduce:
Create empy project and add test cube or open one of demos.
Probably it's a "feature" that prevents you from moving object on axis which you are near (angle-wise) with your camera, which imho should be changed.

After I move my camera a little for first time, blue axis gets unblocked. But it's blocked before that. Clearly a bug.

For whatever it is worth, I have it, too. Linux Ubuntu 16.04.1 x86_64 running MATE desktop. Godot version "Godot_v2.1-stable_x11.64"

Could not reproduce in master.

Thanks, assuming fixed.


Disable common data loading at vis endpoint fixes #3272

@rafatower CR this fix for #3272, please. cc @zenitraM

Frontend tests were OK :+1: (details)

:+1:


Add fork upgrade logic for altair and bellatrix

https://github.com/ethereum/consensus-specs/blob/dev/specs/altair/fork.md
https://github.com/ethereum/consensus-specs/blob/dev/specs/bellatrix/fork.md

stubs:
for altair: https://github.com/ralexstokes/ethereum-consensus/blob/main/src/altair/beacon_state.rs#L101
for bellatrix: https://github.com/ralexstokes/ethereum-consensus/blob/main/src/bellatrix/beacon_state.rs#L120

added in #136


Fixed batchExecutor to not be useless

Promise.all() doesn't trigger the promises to start their work, creating the promise itself does. Reference:
https://stackoverflow.com/a/40639551
Currently, all batchExecutor does is waiting for the promises in chunks, but they're still all executed in parallel. This pull request changes the code so that instead of (already running) promises, promise generator functions are passed, so that the promises are created (and actually executed) in chunks.
Another unfixed issue is that batchExecutor is used recursively, so if the batch limit is, say, 50, and the tree depth is 3, the limit is actually 50^3=125000 since each batchExecutor instance manages its own limit.

👍 this would be great to have!

+1
How can we make this happen?

Would be nice to solve merge conflicts

@jloosli Could you possibly give extra people write access?
@m417z and @Endran look like reasonable options as previous contributors.

@Lusitaniae done. Hopefully @jloosli will merge it soon to avoid more conflicts in the future.
@jloosli is there anything preventing from merging this pull request?


Add files via upload

@strongsilentype I am sorry, the domain mun.ca is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


Watch blacklist file to reload them automatically

Hello,
Would it be possible to implement a watcher for the blacklist file ?
You have the fsnotify lib that seems to be quite easy to add to the project.
This way, you could watch for file change for the blacklist and simply reload them.
Because even now, with the new code, it's still slow when you have more than 500k entries.
My use case is, I'm replacing pihole-FTL by dnscrypt-proxy since it's way more optimised in the term of memory usage for the same dataset of blacklist.
I'm also providing the service publicly and I don't really want to have any dns outage the time to restart the service for blacklist update.
ps: fsnotify also works on Windows.

Watching for file changes is trivial, but gracefully reloading configuration files is always a tricky thing to do.
You may have noticed a Reload() function in the plugin interface. This is exactly what it's here for. But currently, Reload() functions are empty.
It may do something like spawn a new goroutine that builds a new instance of the plugin, and then atomically replaces the previous one with the new one. And there's probably a generic way to do it for any plugin instead of reimplementing the same thing for every single plugin loading a configuration file.
It's been on my TODO list since the beginning, but I haven't found the time to do it. Could you possibly help?

Good point, I see it's not going to be the easiest system to implement, especially the logic behind each plugin for a graceful reload.
Another way to do it, supporting SIGHUP using TableFlip of CloudFlare. They made a whole article about their lib.
This way, the whole process is reloaded, all the config. They based their lib on how NGINX is doing the reload.

Tableflip also seems to require TCP connections. But DNS mostly uses UDP; there are no connections.
Also, it is only designed for Linux, whereas dnscrypt-proxy has to support many more operating systems, including Windows.

TableFlip support any socket that is provided by the network package of golang. Hence, UDP also supported. The idea been TableFlip is the main thread taking care of the network.
About Windows, golang does support the CTRL+C (^BREAK) of Windows. This could be the way to do the reload since it would only send a signal that is bindable. cf: Windows Signal Golang
However, there is also a discussion here about how to do reload in Windows:
https://github.com/nats-io/gnatsd/issues/521
They suggest making the program a service in Windows (which make a lot of sense) linking to how NGINX work in Windows.

Interesting. But how does UDP work?
The proxy gets a query from a client, hasn't responded yet, an we want to update the configuration.
Since there is no connection, how can tableflip know that this specific query shouldn't be handled by another instance yet?

After digging into the code of TableFlip (I'm still learning go, not an easy lib to read).
I'm not sure it could work with Windows as it used Unix Syscall to duplicate File Descriptor.
For what I gather, when you use the Listen on Fds in TableFlip, it will duplicate the Connection object and all the File Descriptor attached to it. It will also make it blocking. (their tests for that component is giving quite a lot of use cases)
In other words, all UDP packet sent to the socket will be queued until the parent shows up and start to read on it.
I'm thinking that going with the first idea of fsnotify on the plugin file would be a better idea, even if it means implementing a full reload logic that could be applied to any plugin. Not an easy task either.


Allow custom matchers to use methods in Pretty

When writing a failure_message for a custom matcher, the methods in Pretty are useful.
Maybe we don't need all of them to be public, but some, like to_sentence would be nice.
This PR is just to get the conversation started.

I'm open to exposing this, but have a few suggestions:

I really don't want name or name_to_sentence, in their current forms publicly exposed.  Relying upon the @name instance variable from the host class has always made me nervous and I don't want to encode that as part of the public API.
The more I think about it, the more convinced I am that this would work just as well, if not better, as a utility module that supports these methods being called directly on it rather than being a mix-in.  The only aspect that relies upon being mixed in is the name stuff I mentioned above, that I'd rather we refactor, anyway.
Pretty is OK as an internal module name, but isn't very descriptive as a public module.  I'm thinking we should rename it.  Maybe EnglishExpressions or something is better?

The more I think about it, the more convinced I am that this would work just as well, if not better, as a utility module that supports these methods being called directly on it rather than being a mix-in.  The only aspect that relies upon being mixed in is the name stuff I mentioned above, that I'd rather we refactor, anyway.
Pretty is OK as an internal module name, but isn't very descriptive as a public module.  I'm thinking we should rename it.  Maybe EnglishExpressions or something is better?

I like both these ideas, feel like tackling it @jaredbeck ?

I like both these ideas, feel like tackling it @jaredbeck ?

Heck yeah.  Let me give it a try.

Pretty is OK as an internal module name, but isn't very descriptive as a public module. I'm thinking we should rename it. Maybe EnglishExpressions or something is better?

EnglishPhrases is a bit easier to type, or how about simply English?

OK, after some heckling from rubocop and yard, I got the travis build passing, so I guess this is ready for review.  Please see the detailed commit message for an overview and rationale.
There's only one thing I'm not happy about.   It's easy to use English from within, e.g. BaseMatcher, but inside Matchers.define I had to use the fully-qualified RSpec::Matchers::English, as you can see in define_matcher.feature.  This feels awkward, and I'm hoping y'all can suggest a better way.

I'd prefer EnglishPhrases over English

I've changed the name to EnglishPhrases and replaced the changelog entry.

If these are still to be private they probably could have been left in Pretty...

I think there's some value in separating Naming from HashFormatting.  For example, there are two tests that include HashFormatting, but they don't need to include Naming.

I think there's some value in separating Naming from HashFormatting. For example, there are two tests that include HashFormatting, but they don't need to include Naming.

We try to reduce the number of files we use (because these things actually do matter when it comes to library load times etc) and as it's a private API that we've had in one place for a while I think it's ok to leave them there.

We try to reduce the number of files we use ..

Sounds good.  I've re-combined them.

Is there another way to do private module methods?

Use private_class_method :method_name.

Hmm. There isn't always a leading space. If we remove the leading space here, we could end up duplicating the "whitespace logic" in each of the call sites.

Good point.  I think you should add a @note YARD doc tag mentioning that the returned string has a leading space except when given an empty list.  That way we're explicitly telling people about it.

Use private_class_method ..
.. add a @note YARD doc tag ..

Done and done.  I also added unit tests for .split_words and .list (spec/rspec/matchers/english_phrasing_spec.rb) and I look forward to any feedback you might have there.

I also added unit tests ..

If you're satisfied with the unit tests, I'd suggest that they replace the cucumber test I wrote.  The unit tests are faster, and the cucumber test feels more like a test than like documentation.

I feel we should keep the cuke as it helps expose this feature...

I feel we should keep the cuke as it helps expose this feature...

I'm :-1: on this.  IMO, the cukes are not an effective way to document every API.  They are there to document the main use case but I don't expect this to be a commonly used API.  The YARD docs are better for that.  Plus having the cuke has a cost that the YARD docs have, in terms of longer build times, etc.

@jaredbeck -- sorry about the delay.  I left some more comments but this is getting close to ready to merge.

@jaredbeck -- sorry about the delay. I left some more comments but this is getting close to ready to merge.

No worries.  Thanks for the great comments, I'm learning from them.  I'll ping again when I've addressed them.  Let me know what you guys decide about the cuke.

Thanks for the great comments .. I'll ping again when I've addressed them.

Ready for another review, thanks!

I'm still in favor of this [cuke] scenario being removed, given the spec coverage you added.

Removed.

Thanks, @jaredbeck!

Thanks, @jaredbeck!

Thank you.  It was fun.


GSD Request

--- GSD JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v4.14 to before v4.14.261",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=d25adbeb0cdb860fb39e09cdd025e9cfc954c5ab",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=8873140f95d4977bf37e4cf0d5c5e3f6e34cdd3e"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "d25adbeb0cdb860fb39e09cdd025e9cfc954c5ab",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "8873140f95d4977bf37e4cf0d5c5e3f6e34cdd3e",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "sctp: use call_rcu to free endpoint\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v4.14.261 by commit 8873140f95d4977bf37e4cf0d5c5e3f6e34cdd3e, it was introduced in version v4.14 by commit d25adbeb0cdb860fb39e09cdd025e9cfc954c5ab. For more details please see the references link."
}
--- GSD JSON ---

This issue has been assigned GSD-2022-1000018


154 | Find Minimum in Rotated Sorted Array II | C++

Find Minimum in Rotated Sorted Array II -
What will change -
Type of Issue -
Please add/delete options that are not relevant.

[x] Adding New Code

Programming Language

[x] C++

Self Check

Ask for issue assignment and wait to get assigned to it before making Pull Request.
Add your file in the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Discord server ✉ - https://discord.gg/CXksGdn
Happy Coding,

Please assign me this issue :)


COMP_COEFFICIENTS in configs

Thank you for sharing the work. Quick question: what are COMP_COEFFICIENTS in configs? Thanks.

Thanks for the question. The COMP_COEFFICIENTS are the linear coefficient for the computational time in each layer of the network. Recall that in our modeling, the computation time of a network is calculated as:
$$
T=\sum_{l} \big[t_0^\text{(l)} + c^\text{(l)}\cdot (\text{number of params in layer }l)\big] \ \ ,
$$
where $l$ is the layer id, and $c^\text{(l)}$, $\forall l$ are the numbers in the COMP_COEFFICIENTS list.


Refactor vineyard hive filesystem.

What do these changes do?

Remove RawLocalFileSystem code
Use vineyard to store structure of file system.

Related issue number

Fixes #issue number

Is this pr ready for merging?


feat: adding in note about pending OAuth release

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Doesn't log anything to file transport when handleExceptions is true and exitOnError is true

Please tell us about your environment:

winston version?

[ ] winston@2
[x ] winston@3

node -v outputs: v8.11.2
Operating System? (Windows, macOS, or Linux) Windows 10 x64
Language? (all | TypeScript X.X | ES6/7 | ES5 | Dart) TypeScript 2.7.2

What is the problem?
Doesn't log anything to file transport with handleExceptions: true and exitOnError: true (default value).
What do you expect to happen instead?
Error is logged and then the process exits.
Other information
// Create winston logger for writing to the env log
const logger = winston.createLogger({
  level: 'debug',
  exitOnError: true,
  transports: [
    new winston.transports.File({
      handleExceptions: true,
      filename: `${__dirname}/logs/dev.log`,
      format: winston.format.combine(
        winston.format.timestamp({ format: 'YYYY-MM-DD HH:mm:ss' }),
        winston.format.printf(info => `[${info.timestamp}] ${info.level}: ${info.message}`)
      )
    })
  ]
});

logger.debug('throwing...');
throw new Error('foo');

If I set exitOnError: false , logging works again (but this is not what I need):
[2018-06-16 19:36:53] debug: throwing...
[2018-06-16 19:36:53] error: uncaughtException: foo
Error: foo
    at Object.<anonymous> (C:\Progetti\gremo\angular-fullstack\dist\server\app.js:40:7)
    at Module._compile (module.js:652:30)
    at Object.Module._extensions..js (module.js:663:10)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)
    at Function.Module.runMain (module.js:693:10)
    at startup (bootstrap_node.js:191:16)
    at bootstrap_node.js:612:3

This seems like a duplicate of #1289 which has a pending PR #1355 that would hopefully fix your problem as well.  (Waiting for some discussion with @indexzero before merging that in.)  Thanks for bringing this up!


Filter workflows to affected crates

This is first in a series of PR's meant to implement packaging, deployment and release changes discussed in #481.  This will be merged to the feature/ci-cd-dev branch, instead of master, so that this effort can have smaller PR's that can be reviewed individually for their scope of change, before making any alterations to the 'production' pipeline.
Summary
This PR implements a build-test workflow, which automatically determines crates affected by the change, and creates a matrix consisting of the affected crate and the nightly and stable toolchains.
Example:  if a change was made to any file in both /pac/atsamd11c, and boards/circuit_playground_express.  This action would run a generate-matrix action, then determine that 4 build jobs need to be run:

pac/atsamd11c, stable
pac/atsamd11c, nightly
boards/circuit_playground_express, stable
boards/circuit_playground_express, static

Other Notes

matrix will include a crate that has any file added/deleted/modified/renamed within it's file tree
matrix will not run a build if none of the files affected are a child of a crate directory

In-Scope for this PR

creating a filtered matrix of crates affected by changes, to be used by jobs and workflows in the pipeline

Out-of-scope for this PR

changes to build, test, release, or package versioning

Example runs:

test of deleting a file in a BSP
test of adding a file to a BSP

for now, I went with js based action, since I'm not as proficient with python. I wanted to start getting the concept out there so we could see what other parts of the pipeline this concept would affect.  We can always come back and make it python later/before we adopt this to master.
For any reviewers, please leave a note if your approval is contigent upon this being done in python prior to the new ci/cd being adopted into production

If atsamd11c was touched, shouldn't the BSC for SAMD11_bare also be triggered since it depends on it?

Usage of JS
Personally I don't really mind going with js, as long as we don't end up with a disparate collection of scripts in different languages. The only caveat I would see is that to me python is more readable to someone unfamiliar with the language, for example someone trying to understand why the CI is failing.
BSP triggered by PAC
@TDHolmes has a good point, especially for PAC builds, would the dependency in the BSP and HAL crates be updated automatically - and their version bumped? Or is that a manual step?
Similarly for tier 1 bsps, is there a mechanism we can put in place to automatically sync the hal version in their dependencies, and perhaps bump the (T1) bsp versions if the dependency is updated?

If atsamd11c was touched, shouldn't the BSC for SAMD11_bare also be triggered since it depends on it?

I wasn't aware of the BSC's in the boards directory, so this got by me.  However, I did propose an also_build for the [package.metadata.atsamd] in #503 just in case something like this came up.
That being said... it does feel like a code smell that there's a downstream crate that introduces build dependencies to an upstream crate.

Similarly for tier 1 bsps, is there a mechanism we can put in place to automatically sync the hal version in their dependencies, and perhaps bump the (T1) bsp versions if the dependency is updated?

Yes, in fact, the sync-pac-versions action in the release workflow does almost exactly this already (it just does it to every pac crate, instead of just affected pac/bsc crates).

The only caveat I would see is that to me python is more readable to someone unfamiliar with the language, for example someone trying to understand why the CI is failing.

Agreed... python is much easier to reason through at a glance.  So far, all the maintainers have basically said js is ok with them, and if we get through all this, i'll likely be the primary maintainer, and js is a language I can do in my sleep.
My primary reason for using js here is that I wanted to quickly see what the affects of this filtering would be, for which this has definitely succeeded.

as long as we don't end up with a disparate collection of scripts in different languages.

Agreed, I think we should stick to one language (either python or js) in addition to any bash needed.  That is one of my acceptance requirements for when we merge the feature/ci-cd-dev branch to master.
So, I'll either redo this in python... or remove any python through the remaining work.
I'm leaning more towards redoing this in python, as I think the users of these crates are more likely to have python experience/understand python... than they are js.

@TDHolmes has a good point, especially for PAC builds, would the dependency in the BSP and HAL crates be updated automatically - and their version bumped? Or is that a manual step?

I think with the discussion in #481, the implication is that we wouldn't automatically bump the dependencies in a crate when the dependency updates.  Reasons for this:

There aren't any tests for most crates, and just running a build does not guarantee functionality,
Not updating dependencies in a dependent crate decouples the PAC/HAL from their dependents, which makes it easier to implement changes to the codebase without maintaining several versions of an interface in an active codebase.
We can update rules for Tier 1 crates that state they will maintain forward compatibility with HAL/PAC, up to breaking changes. (will be compatible with Y or Z changes).
We can create an action that automatically determines if a crate is currently meeting Tier 1 rules, and adjust the listings in README and cargo.toml files accordingly automatically on each merge to master.

Unless there are no other concerns, let's merge for the moment so I can use the output of this in the other pieces of work for this feature.  I can come back and re-do in python prior to releasing into the wild

I kinda agreed with the code smell bit… but also agreed that this can be
iterated on and tweaked later
On Sat, Oct 9, 2021 at 9:09 AM Brian Vanderbusch @.***>
wrote:

Do we have a good plan for the concern I raised about more secondary
dependency paths?
… <#m_86844312127308339_>
On Sat, Oct 9, 2021 at 7:35 AM Brian Vanderbusch @.***> wrote: Unless
there are no other concerns, let's merge for the moment so I can use the
output of this in the other pieces of work for this feature. I can come
back and re-do in python prior to releasing into the wild — You are
receiving this because you were mentioned. Reply to this email directly,
view it on GitHub <#504 (comment)
https://github.com/atsamd-rs/atsamd/pull/504#issuecomment-939307063>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC5YNWR77CTK5B6FSOBU4Z3UGBHMBANCNFSM5FKAYZVQ
.
I believe so, if you read my comments above. Regardless, even if there
was enhancements needed, that would be in another PR. Keep in mind,
this is a feature branch so I can iterate rapidly while getting input. We
don't have to have every problem solved until we merge the
feature/ci-cd-dev into master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/atsamd-rs/atsamd/pull/504#issuecomment-939320738, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AC5YNWSY76S4VWFKJTVN4B3UGBSLFANCNFSM5FKAYZVQ
.


[Bug report] Unable to disable Git Contributors on site outside of Front Matter on specific pages

Bug report
Description
I am unable to disable Contributors and Last Updated on pages using the default theme unless I do it in the Front Matter.

Steps to reproduce

Note: after making any changes to config.ts related to this issue, I completely restart yarn docs:dev running in my terminal to avoid any issues with hot reloading.
Docs suggest I can disable this globally in the site config by disabling the git plugin via this in my .vuepress/config.ts file, Neither of the following works:
plugins: [
    ['@vuepress/plugin-git', {
      contributors: false,
      updatedTime: false,
    }]

plugins: [
    ['@vuepress/plugin-git', false]
}

I have added these parameters to themeConfig:
themeConfig: {
    contributors: false,
    lastUpdated: false,
}

I have also attempted to add the following under themePlugins:
themeConfig: {
    themePlugins: {
      git: false,
    },
}

Still, unless I add contributors: false to the front matter of a specific page, it shows up.
Documentation seems to indicate that the above steps should either disable the plugin that the Default Theme relies on, or stop it from gathering certain info.
No matter what from the above examples I try, I still see my name and last updated time on the page.

Reproduction link / repo:
Not currently available

Expected behavior

Disabling the git plugin disables "contributors" and "last updated" in the default theme.
Links to documentation:

https://vuepress.github.io/reference/plugin/git.html
https://v2.vuepress.vuejs.org/reference/default-theme/config.html#themeplugins-git
https://v2.vuepress.vuejs.org/reference/default-theme/config.html#contributors
https://v2.vuepress.vuejs.org/reference/default-theme/config.html#lastupdated

Link to example code from Vuepress:

https://github.com/vuepress/vuepress-next/blob/288927a9186cd2d50b0523c8970271d259279d04/docs/.vuepress/config.ts#L138

Screenshots

Environment info

Browser: Safari and Firefox on macOS
Output of vuepress info:

❯ vuepress info

  System:
    OS: macOS 11.3
    CPU: (8) x64 Intel(R) Core(TM) i5-1030NG7 CPU @ 1.10GHz
    Memory: 182.40 MB / 8.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 14.16.1 - /usr/local/opt/node@14/bin/node
    Yarn: 1.22.11 - /usr/local/bin/yarn
    npm: 6.14.12 - /usr/local/opt/node@14/bin/npm
  Utilities:
    Git: 2.24.3 - /usr/bin/git
  Browsers:
    Chrome: Not Found
    Edge: Not Found
    Firefox: 91.0.2
    Safari: 14.1
  npmPackages:
    @vuepress/bundler-vite: Not Found
    @vuepress/bundler-webpack:  2.0.0-beta.26
    @vuepress/cli:  2.0.0-beta.26
    @vuepress/client:  2.0.0-beta.26
    @vuepress/core:  2.0.0-beta.26
    @vuepress/markdown:  2.0.0-beta.25
    @vuepress/plugin-active-header-links:  2.0.0-beta.26
    @vuepress/plugin-back-to-top:  2.0.0-beta.26
    @vuepress/plugin-container:  2.0.0-beta.26
    @vuepress/plugin-debug: Not Found
    @vuepress/plugin-docsearch: Not Found
    @vuepress/plugin-git:  2.0.0-beta.26
    @vuepress/plugin-google-analytics: Not Found
    @vuepress/plugin-medium-zoom:  2.0.0-beta.26
    @vuepress/plugin-nprogress:  2.0.0-beta.26
    @vuepress/plugin-palette:  2.0.0-beta.26
    @vuepress/plugin-prismjs:  2.0.0-beta.26
    @vuepress/plugin-pwa: Not Found
    @vuepress/plugin-pwa-popup: Not Found
    @vuepress/plugin-register-components: Not Found
    @vuepress/plugin-search: Not Found
    @vuepress/plugin-shiki: Not Found
    @vuepress/plugin-theme-data:  2.0.0-beta.26
    @vuepress/plugin-toc: Not Found
    @vuepress/shared:  2.0.0-beta.25
    @vuepress/theme-default:  2.0.0-beta.26
    @vuepress/utils:  2.0.0-beta.25
    vue:  3.2.11
    vue-loader:  16.5.0
    vue-router:  4.0.11
    vuepress: ^2.0.0-beta.26 => 2.0.0-beta.26
    vuepress-vite: Not Found

Issue has been resolved on my end while reproducing.
.vuepress with config.ts was in my root project folder, rather than nested under docs as in the example here: https://vuepress2.netlify.app/guide/configuration.html#config-file.
What should have looked like this:
├─ docs
│  ├─ .vuepress
│  │  └─ config.ts
│  └─ README.md
├─ .gitignore
└─ package.json

instead looked like this:
├─ .vuepress
│ └─ config.ts
├─ docs
│  ├─ .vuepress
│  │  └─ config.ts
│  └─ README.md
├─ .gitignore
└─ package.json

On further testing, I suspect that at some point early on, I ran vuepress dev from the project root instead of vuepress dev docs and did not realize I was working in a .vuepress folder that was generated outside of where it should be when changing these settings.
Corrected the issues in my original repository and plugin disabling is now working as expected. Closing due to user error on my part.


When adding solidus_frontend and solidus_auth_devise I am getting an exception

When add these two gems together on my Gemfile:
solidus_frontend (~> 2.9.0)
solidus_auth_devise

I am getting the error below when trying to start the server
Before process_action callback :setup_for_current_state has not been defined (ArgumentError)
The only way we found to fix this is by doing this change to this file
lib/controllers/frontend/spree/checkout_controller_decorator.rb
-      base.skip_before_action :setup_for_current_state, only: [:registration, :update_registration]
+      base.skip_before_action :setup_for_current_state, only: [:registration, :update_registration], raise: false

Is this happening to someone else? Am I doing something wrong?

Hey @gugaiz, did you fixed it somehow? It's the first time I see this error, maybe it was something with your application?

Hey @kennyadsl, no I am still getting the same error. They way we solve it is by using this forked repo with this modification https://github.com/penrosehill/solidus_auth_devise/commit/d2937e0721e2bfff52af3a6486ceb55144d941b1


Establish relationships to easily access transaction and block information from inputs and outputs

Reimplements #196 due to master branch divergence, which supersedes #195 (Thanks @mebassett)
Includes:

input -> transaction
input -> source transaction (where it was an output)
output -> transaction

and expressions to use in filtering and sorting.

just an fyi  - this works fine for me and solves all the problems I was trying to address in #195.  thanks! :+1:


iOS does not find input audio devices

Describe the bug
Hi there,
I am having this issue with cpal on iOS and I'm not sure where the problem is.
Steps to reproduce
using cpal run on iOS (simulator/device, debug/release)
let hosts = cpal::available_hosts();
log_string(format!("Available hosts: {:?}", hosts));

let host = cpal::default_host();
log_string(format!("default host: {:?}", host.id()));

log_string(format!(
    "Host num input devices: {:?}",
    host.input_devices().unwrap().count()
));

log_string(format!(
    "Host num output devices: {:?}",
    host.output_devices().unwrap().count()
));

Logs
will result in

Available hosts: [CoreAudio]
default host: CoreAudio
Host num input devices: 0
Host num output devices: 1

The microphone is discoverable using dart, though.

### Expected behavior

_No response_

### Generated binding code

_No response_

### OS

iOS

### Version of `flutter_rust_bridge_codegen`

1.82.5

### Flutter info

```shell
Flutter 3.19.0 • channel stable • https://github.com/flutter/flutter.git
Framework • revision bae5e49bc2 (7 days ago) • 2024-02-13 17:46:18 -0800
Engine • revision 04817c99c9
Tools • Dart 3.3.0 • DevTools 2.31.1

Version of clang++
15
Additional context
No response

To investigate this issue I started a clean project with flutter_rust_bridge create. There seems to have been quite a lot of changes so maybe that'll fix it, and I wanted to isolate the problem.
Here's the project: https://github.com/tGrothmannFluffy/flutter_rust_test_ios_mic
Unfortunately, I cannot get it to run, because of flutter not finding the rust library.

Unfortunately, I cannot get it to run, because of flutter not finding the rust library.

It would be great to show the errors, then I can have a look at it :)

At first I got:
ld: Undefined symbols:
  _AudioComponentFindNext, referenced from:
      coreaudio::audio_unit::AudioUnit::new_with_flags::hf4630a21d4507d5a in librust_lib_ios_mic.a[x86_64][193](cpal-d9d78020be790fe8.cpal.3c4241f9eb44d5fe-cgu.1.rcgu.o)
  _AudioComponentInstanceDispose, referenced from:
      _$LT$coreaudio..audio_unit..AudioUnit$u20$as$u20$core..ops..drop..Drop$GT$::drop::hca9ac08a097ea638 in librust_lib_ios_mic.a[x86_64][207](coreaudio-6f99948436ab866b.coreaudio.a083936386d5d26e-cgu.0.rcgu.o)
  _AudioComponentInstanceNew, referenced from:
      coreaudio::audio_unit::AudioUnit::new_with_flags::hf4630a21d4507d5a in librust_lib_ios_mic.a[x86_64][193](cpal-d9d78020be790fe8.cpal.3c4241f9eb44d5fe-cgu.1.rcgu.o)
  _AudioOutputUnitStart, referenced from:
      coreaudio::audio_unit::AudioUnit::start::ha3f6f577c1e2c9e2 in librust_lib_ios_mic.a[x86_64][207](coreaudio-6f99948436ab866b.coreaudio.a083936386d5d26e-cgu.0.rcgu.o)
  _AudioOutputUnitStop, referenced from:
      coreaudio::audio_unit::AudioUnit::stop::h1ffe47b7eca246c4 in librust_lib_ios_mic.a[x86_64][207](coreaudio-6f99948436ab866b.coreaudio.a083936386d5d26e-cgu.0.rcgu.o)
  _AudioUnitGetProperty, referenced from:
      coreaudio::audio_unit::get_property::h2798000ba6c9efac in librust_lib_ios_mic.a[x86_64][207](coreaudio-6f99948436ab866b.coreaudio.a083936386d5d26e-cgu.0.rcgu.o)
      coreaudio::audio_unit::get_property::hb3df5bf4d6c13bc6 in librust_lib_ios_mic.a[x86_64][207](coreaudio-6f99948436ab866b.coreaudio.a083936386d5d26e-cgu.0.rcgu.o)
  _AudioUnitInitialize, referenced from:
      coreaudio::audio_unit::AudioUnit::new_with_flags::hf4630a21d4507d5a in librust_lib_ios_mic.a[x86_64][193](cpal-d9d78020be790fe8.cpal.3c4241f9eb44d5fe-cgu.1.rcgu.o)
      coreaudio::audio_unit::AudioUnit::initialize::h5dfce5fca15af1cb in librust_lib_ios_mic.a[x86_64][207](coreaudio-6f99948436ab866b.coreaudio.a083936386d5d26e-cgu.0.rcgu.o)
  _AudioUnitSetProperty, referenced from:
      coreaudio::audio_unit::set_property::heb86782b96e8de98 in librust_lib_ios_mic.a[x86_64][193](cpal-d9d78020be790fe8.cpal.3c4241f9eb44d5fe-cgu.1.rcgu.o)
      coreaudio::audio_unit::set_property::h06cbfefb4adac733 in librust_lib_ios_mic.a[x86_64][207](coreaudio-6f99948436ab866b.coreaudio.a083936386d5d26e-cgu.0.rcgu.o)
      coreaudio::audio_unit::set_property::h5d287565dc79a5e7 in librust_lib_ios_mic.a[x86_64][207](coreaudio-6f99948436ab866b.coreaudio.a083936386d5d26e-cgu.0.rcgu.o)
  _AudioUnitUninitialize, referenced from:
      coreaudio::audio_unit::AudioUnit::uninitialize::h6d92c7b18989dec5 in librust_lib_ios_mic.a[x86_64][207](coreaudio-6f99948436ab866b.coreaudio.a083936386d5d26e-cgu.0.rcgu.o)
      _$LT$coreaudio..audio_unit..AudioUnit$u20$as$u20$core..ops..drop..Drop$GT$::drop::hca9ac08a097ea638 in librust_lib_ios_mic.a[x86_64][207](coreaudio-6f99948436ab866b.coreaudio.a083936386d5d26e-cgu.0.rcgu.o)
clang: error: linker command failed with exit code 1 (use -v to see invocation)

I added AudioToolbox to the frameworks in thee runner xcode project.
also added let session = AVAudioSession.sharedInstance into AppDelegate.swift

After that the build succeeds, but I get this runtime error:
ArgumentError (Invalid argument(s): Failed to load dynamic library 'rust_lib_ios_mic.framework/rust_lib_ios_mic':
dlopen(rust_lib_ios_mic.framework/rust_lib_ios_mic, 0x0001):
tried: '/Library/Developer/CoreSimulator/Volumes/iOS_21C62/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 17.2.simruntime/Contents/Resources/RuntimeRootrust_lib_ios_mic.framework/rust_lib_ios_mic' (no such file),
'/Library/Developer/CoreSimulator/Volumes/iOS_21C62/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 17.2.simruntime/Contents/Resources/RuntimeRoot/usr/lib/swift/rust_lib_ios_mic.framework/rust_lib_ios_mic' (no such file),
'/usr/lib/swift/rust_lib_ios_mic.framework/rust_lib_ios_mic' (no such file, no dyld cache),
'/Users/fluffy/Library/Developer/CoreSimulator/Devices/A75E74E2-9876-48FB-9388-477EA4C0B6E4/data/Containers/Bundle/Application/157F1C2C-CB4E-42C9-88DB-FD309E41AA44/Runner.app/Frameworks/rust_lib_ios_mic.framework/rust_lib_ios_mic' (no such file),
'/Users/fluffy/Library/Developer/CoreSimulator/Devices/A75E74E2-9876-48FB-9388-477EA4C0B6E4/data/Containers/Bundle/Application/157F1C2C-CB4E-42C9-88DB-FD309E41AA44/Runner.app/Frameworks/rust_lib_ios_mic.framework/rust_lib_ios_mic' (no such file),
'/usr/lib/rust_lib_ios_mic.framework/rust_lib_ios_mic' (no such file, no dyld cache), 'rust_lib_ios_mic.framework/rust_lib_ios_mic' (no such file),
'/Library/Developer/CoreSimulator/Volumes/iOS_21C62/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 17.2.simruntime/Contents/Resources/RuntimeRoot/System/Library/Frameworks/rust_lib_ios_mic.framework/rust_lib_ios_mic' (no such file))

Hmm, looks like maybe something related to Cargokit. Maybe debug by, e.g.: Check the generated app - does it have that framewok? does that framework have that library file?

The issue seems to be closed by adding some code into AppDelegate. This is necessary since iOS 17.
https://github.com/RustAudio/cpal/issues/842#issuecomment-1966408740


SSR - detection on server side is different than on client side

Hello,
I don't know it's an issue but I got stuck, maybe someone will help me.
I have 2 languages on the page. The default is set as 'en' using fallbackLng.
import i18n from 'i18next';
import detector from 'i18next-browser-languagedetector';
import { initReactI18next } from 'react-i18next';

import translationEN from '../translations/en/translation.json';
import translationPL from '../translations/pl/translation.json';

const resources = {
    en: {
        translation: translationEN
    },
    pl: {
        translation: translationPL
    }
};

i18n
    .use(initReactI18next)
    .use(detector)
    .init({
        detection: {
            lookupLocalStorage: 'language',
            order: ['path'],
            lookupFromPathIndex: 0
        },
        resources,
        debug: true,
        caches: [],
        fallbackLng: 'en', // use en if detected lng is not available
        keySeparator: false, // we do not use keys in form messages.welcome
        whitelist: ['en', 'pl'],
        load: ['en', 'pl'],
        interpolation: {
            escapeValue: false // react already safes from xss
        }
    });

export default i18n;

I try to detect language by path:

https://localhost:3000/ - detected en on client and server side
https://localhost:3000/**pl/** - detected pl on client side but on server side it's "en" even when the browser is reloaded.

It's ok that on server side I have always "en" ?

do you SSR? do you use next-i18next? next.js?
load: ['en', 'pl'] -> there is no load option!!!
this detector does not work on serverside! -> https://github.com/i18next/i18next-express-middleware#language-detection

Yes, I use next.js and next-i18next
So, it's ok that I have always "en" on server side.
Thank you for the link, I will try to use it.

It's not optimal SSR will render "en" -> client eventual "pl" ---> mismatch of content (next will complain) -> you will need to detect on serverside too


Historical prices?

Is there a way to obtain historical prices for a product given a specific date or a date interval?

I'm interested in this too

Hello @AlphaJack,
these are the Chart related methods.
I just improved the Chart formatting : you should be able to retrieve and have a formatted DataFrame version of these timeseries.
I hope the documentation and the examples are explicit enough.
Let me know if you need more information.
Thanks

You didn't link anything @Chavithra

@hyperfraise It is the section called 2.3. How to get a Chart ? in the documentation.
Hope that helps


my first issue 6^^

What do we need to do in this?

What do we need to do in this?

same, i have no idea what should i do


Merge backoffice and backoffice internal APIs

Codecov Report
Base: 32.34% // Head: 32.04% // Decreases project coverage by -0.31% :warning:

Coverage data is based on head (ecca461) compared to base (6b17f12).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #556      +/-   ##
==========================================
- Coverage   32.34%   32.04%   -0.31%
==========================================
  Files         125      129       +4
  Lines       14838    15044     +206
  Branches     3794     3908     +114
==========================================
+ Hits         4800     4821      +21
- Misses       9844    10029     +185
  Partials      194      194

Impacted Files
Coverage Δ

...ime/runtime-domain-service/ballerina/watchApis.bal
56.58% <0.00%> (-6.68%)
:arrow_down:

...ime/runtime-domain-service/ballerina/APIClient.bal
52.12% <0.00%> (-1.91%)
:arrow_down:

...e/runtime-domain-service/ballerina/api_service.bal
5.35% <0.00%> (-0.15%)
:arrow_down:

...allerina/modules/org.wso2.apk.runtime/YamlUtil.bal
3.12% <0.00%> (ø)

...-service/ballerina/modules/java.io/IOException.bal
0.00% <0.00%> (ø)

...fasterxml.jackson.core/JsonProcessingException.bal
0.00% <0.00%> (ø)

...allerina/modules/org.wso2.apk.runtime/ZIPUtils.bal
3.17% <0.00%> (ø)

...g.wso2.apk.runtime.api/JAPIManagementException.bal
1.28% <0.00%> (+0.03%)
:arrow_up:

...-service/ballerina/modules/java.lang/Throwable.bal
1.44% <0.00%> (+0.04%)
:arrow_up:

...service/ballerina/modules/java.lang/JException.bal
1.44% <0.00%> (+0.04%)
:arrow_up:

... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

shall we remove backoffice-internal whole previous module and check as well?


sometimes Dropdown appears after an from the input

Hi, I have been using this dropdown in a few app places. Sometimes, it opens at the right place but sometimes with a wide offset. There are no styling changes anywhere. I have been using the same style in both places, but it is happening randomly. I am adding the screenshots so you can have a look.
With offset

Without offset

@hoaphantn7604 can you please have a look

anybody found a fix


angularjs-google-maps always asks for location permission

I have my cordova app with agularjs-google-maps. I don't need that my app asked for location permission every time user comes to map state. Of course if user allows the location permission - it's all ok. But when user don't want to give location permission it always ask's for it. I even did the native android app and added google maps to see is there is the same, but no, google maps don't ask for permission, it works without and never asks.
If there is the way that this map stop to ask for location???

Please specify location with lat/lng, not blank or string. It won't ask. It only asks when it is required.

Thx for your reply, i made a check that if GPS allowed then <ng-map center="current-position"... else if deny then <ng-map center="[55.1947157, 24.6297574]"...
So i think i did what you have told

Even if i just place the <ng-map center="[55.1947157, 24.6297574]"... it still asks the permission always...

I'm sorry, i forgot that i had current-location not only in ng-map center tag, but in my current location marker and direction tags.


Metrics: Start counting event loop metrics

As time moves on it would be good to have more metrics about how the event loop operates. To begin with we don't need to add any API surface for this: it would be sufficient to have these statistics available when debugging with LLDB while we work out what to gather and how expensive they are.
As a first pass, SelectableEventLoop could gather the following metrics:

Number of tasks enqueued
Number of "slow" task enqueues (where we have to wake the selector)
Number of "fast" task enqueues across loops (where the target loop is running so the selector does not need to be woken)
Number of "fast" task enqueues from within the loop
Number of event loop ticks iterated

These should all be extremely cheap to gather.

You mention that these could start out as simply being LLDB cmd's, how do you envision the API for this looking? Something like this or

Breakpoint in your EventLoop
ld selectableEL.enqueues

Or so you have some other workflow?

@Lukasa you don't want to add a dependency on swift metrics? These kind (of very useful) statistics is not so different from what swift-metrics-extras expose.

@BastianInuk In this instance I basically don't envision a stable API at all, but yeah, you'd break at some point and find the event loop.
@hassila Our big concern right now is the relative cost: we want it to be extremely cheap to produce these metrics, and for users who don't access them to essentially not pay for them. swift-metrics is not really optimised for that use-case. We would like to have an automatic way to translate from these metrics to swift-metrics for users who want to consume it that way, but otherwise to make it very cheap.

That makes sense, I haven't looked at the metrics implementation yet, but hoped it would be suitable. Definitely could publish to swift metrics in the future (e.g. once per minute or so) if it isn't fit for purpose - agree perf stats must be super cheap.

Seems there is room for a buffered interface towards swift metrics which flushes periodically - this seems like a common use case...

I can't see the type SelectableEventLoop, is this a proposed new type for the purpose, or am I missing something?
I may have an idea how this could be implemented for relatively cheap

SelectableEventLoop is an internal type that implements EventLoop for MultiThreadedEventLoopGroup.

From the 10th, I should have time to look into this!


Allow to setup LDAP auth

Be able to setup LDAP auth on Jenkins master. This resulted in splitting
set security method into three methods for setting:
ldap auth
password auth
unsecured
Also give choice to turn on the slave to master feature during
deployment.

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@mescanef My work to support configuring the security realm and authentication strategy via native types was merged in #382.  Do you think this work could be merge with the groovy get_security_realm() / get_authorization_strategy() methods on master and the providers for jenkins_security_realm and jenkins_authorization_strategy?  @daenney is also interested in configuring ldap.

Any news on this PR?

@rhoml At a minimum it needs to be rebased on the current master and I think it should be converted to passing json instead of CLI args.  I think it would be less work to add this to the jenkins_security_realm/jenkins_authorization_strategy types.

Hello everybody. I'm going to close this PR due to inactivity. Please reopen and rebase the PR if anybody is still interested in it.


skipgram predict throws an uncaught error

I have been using the package as a way to use more general fasttext features as it seems that the build from the official version doesn't work. I have trained a skipgram model through your package using the following script:
const ft = require('fasttext.wasm.js')
const fs = require('fs')

const ft2 = new (await ft.getFastTextClass({getFastTextModule: ft.getFastTextModule}))();
const trainCallback = (progress, loss, wst, lr, eta) => {
  console.log([progress, loss, wst, lr, eta]);
};

const trainingDataURI = URL.createObjectURL(
  new Blob([
    fs.readFileSync('./data.txt')
  ], {type: 'text/plain'})
)

const model = (await ft2.trainUnsupervised(trainingDataURI, 'skipgram', {
  'lr':0.1,
  'epoch':1,
  'loss':'ns',
  'wordNgrams':2,
  'dim':50,
  'bucket':200000
}, trainCallback))

There were no issues training the model and some methods of the model work as expected:
> model.getWordVector('deploy')
Float32Array(50) [
  0.013191827572882175,   0.14477281272411346,  0.03132225200533867,
  ...
]

However the predict method doesn't work and throws an uncaught WASM error.
> model.predict('deploy')
Uncaught 5679920

There is no more error stach information? And I'm not familier with training logic, If you provide a minimal reproduction, then I can try to investigate it.

@yuns You can try the code verbaitim from the original issue. along with the following data file, although you could try any data file you want.
data.txt

https://github.com/yunsii/fasttext.wasm.js/blob/8615449506a69b724b19891fc5f9b833de4be842/tests/training.ts
Unfortunately, run with npx tsx --trace-uncaught ./tests/training.ts throw error directly:
Read 0M words
Number of words:  0
Number of labels: 0

node:internal/process/esm_loader:40
      internalBinding('errors').triggerUncaughtException(
                                ^
120118296
Thrown at:
    at loadESM (node:internal/process/esm_loader:40:33)

Node.js v18.19.0

It seems too hard to investigate 😂

@yunsii Sorry, it seems to work on only some datasets. I shared a trimmed version of mine. That's another bug.
However, you can try this dataset, it is working on my end:
data2.txt

Read 0M words
Number of words:  34
Number of labels: 0
args 0 -1 0 0.1 2592000
Progress: 100.0% words/sec/thread:  208397 lr:  0.000000 avg.loss:  4.117721 ETA:   0h 0m 0s
before getWordVector

node:internal/process/esm_loader:40
      internalBinding('errors').triggerUncaughtException(
                                ^
113056
Thrown at:
    at loadESM (node:internal/process/esm_loader:40:33)

Node.js v18.19.0

Strange error, I have no good idea to investigate 😂 it seems we need to debug in submodule fasttext written in cpp, but I'm not familier with it.

@yunsii Can you try running it in pure JavaScript? getWordVector is supposed to work.

JavaScript is just a binding for fasttext wasm, there is no pure JavaScript to run.

Sorry I meant not running it through tsx.

ESM and CJS are just binding js for wasm, it must throw error when call predict method, we chould not do anything in JS side 🫠


Add missing flags to kurtosis run --help

Where did you see the issue in our documentation?
kurtosis run --help
Issue description
When you run kurtosis run --help, you should see all the possible parameters that you can pass.
A few missing features that I have failed to see are:
*--args-file flag now takes a URL.

--always-pull flag is missing.
I'm sure there are some other flags that are now implemented but are missing from the --help window.

Hey @barnabasbusa - what version of the CLI are you on? I see both of the flags when I run kurtosis run --help:
Flags:
      --args-file string            The file (JSON/YAML) will be used as arguments passed to the Kurtosis Package
      --image-download missing      If unset, it defaults to missing for fetching the latest image only if not available in local cache. Use `always` to always fetch the latest image. (default "missing")

I believe you are on an older version of the CLI so thats why you might not see it!

Closing this out as completed! Just make sure you're on the latest and greatest Kurtosis :)


Robot Process library incorrectly buffers file pipe output

While running the "Process.Run Process(command,stdout=/some/file,stderr=/some/file)" keyword with external programs that generate a lot of stdout data, RobotFramework seems to buffer the output before piping it to the file causing the commands to execute significantly slower than it's OperatingSystem.Run or external shell counterpart.
For example, using a db-query script which generates 174 MB of stdout data piped directly to a file, Process.Run Process takes about 150 seconds to complete while the script normally completes in about 17 seconds in the shell or the OperatinSystem Run methods.

This issue is also seen with the Process.Start Process keyword
Using Python's Subprocess.Popen directly completes in the expected, fast time frame. It is only not working properly in RobotFramework's abstraction of the process control functionality!

Interesting. Could you investigate how this could ne fixed? Process library uses subrocess.Popen internally, but apparently some of the configuration slows it down.

Ughhh... I can only reproduce this using the java based Robot runners--pybot works fine (I'm trying to build this test framework into our maven build system so I'm not sure if switching to pybot is an option yet). On top of that, using a simple 'Run Process    cat    /path/to/large/textfile    stdout=/path/to/out/file' test Robot program isn't enough to reproduce the issue. I have to use the java-based db-query application that I am running.
I ran an strace on both the pybot and the java robot runners. The only thing I noticed is that the java robot runner seems to use about 20 system write calls for every 1 system write call that the pybot runner uses. It seems to be chunking its data differently (10 bytes per write vs variable bytes per write)?
Eg a Single CSV record from the Pybot Runner:
1334  write(1, ""Xxx","70","xxx-xxx-7","x-xxxx""..., 191) = 191
Similar Single CSV record from the Java Robot Runner:
1381  write(47, "ED_INT"\n"X", 10)    = 10
1381  write(47, "xx","70","", 10)   = 10
1381  write(47, "xxx-xxxx-7", 10)       = 10
1381  write(47, "","x-xxxx"", 10)    = 10
1381  write(47, ","0","0","", 10)  = 10
1381  write(47, "SFP_TO_XXX", 10)       = 10
1381  write(47, "_XXXXX_A_F", 10)       = 10
1381  write(47, "AILURE",""", 10)    = 10
1381  write(47, ","2016-285", 10)      = 10
1381  write(47, "T21:54:28.", 10)       = 10
1381  write(47, "060","2013", 10)     = 10
1381  write(47, "-178T01:30", 10)       = 10
1381  write(47, ":49.198","", 10)     = 10
1381  write(47, "0425568774", 10)       = 10
1381  write(47, ".50000","1", 10)     = 10
1381  write(47, "","","Read", 10)   = 10
1381  write(47, "y","NONE",", 10)    = 10
1381  write(47, ""NONE","tr", 10)    = 10
1381  write(47, "ue","STATU", 10)     = 10
I don't know what would cause this or how I might control it. I'm guessing it's probably time to start looking for  a workaround to using the java robot runner or throw out using Process at this point rather than figure out what's actually going on here.

I was able to reproduce this using just java-Robot (jython) with Run Process directly calling my large mysql query (skipping my intermediate java application parsing) ... Since that is the case, I believe it's likely that other people will run into this bug at some point...
However, this doesn't seem to be a Robot bug but rather a bug with Jython (unless the jar version of Robot uses something else). I will create the bug report there instead.

Yeah, definitely sounds like a bug in Jython. It would be interesting to know what's the actual root cause, though. If we were lucky, we could perhaps workaround it on the Process library somehow.

Ooops, didn't mean to close this at this point. Damn GitHub for having Close and comment button next to Comment button...

I don't really know anything about how Jython converts python's Subprocess to Java but that seems to be what they're doing wrong.
Looking at the strace, File Descriptor 47 is a custom descriptor created by Jython while File Descriptor 1 is actually stdout. So... Jython needs to correctly direct stdout output to stdout instead of whatever they're actually doing with their Subprocess interpretation/implementation? Just a thought from somebody that knows nothing :)

Any new info about this issue? Have you tested do you get same slowdown if you use subprocess directly using Jython? Do you have an example that demonstrates this problem that I could try running locally?

And again I clicked the wrong button when just trying to add a comment!!

Closing due to lack of new info and an example I could try myself.


[feature] Support set ServiceUrlProvider when create client.

Master Issue: https://github.com/apache/pulsar/pull/2543
Motivation
#163
ServiceUrlProvider is provided so that users can dynamically update serviceUrl, and can be implemented #164 cluster level auto failover.
Modifications

Add the ServiceUrlProvider  function define.
Add the updateServiceUrl method in the Client.
Client add new constructor method to support set  ServiceUrlProvider instance param.

Verifying this change

Add ServiceUrlProviderTest to cover custom ServiceUrlProvider.

Documentation

[x] doc-required
(Your PR needs to update docs and you will update later)

[ ] doc-not-needed
(Please explain why)

[ ] doc
(Your PR contains doc changes)

[ ] doc-complete
(Docs have been already added)

We only need to support passing a std::functionstd::string(). The initialize and close methods are redundant.

The initialize and close methods are useful. We need pass Client& to ServiceUrlProvider by initialize method.
https://github.com/apache/pulsar-client-cpp/blob/7d91638513405ed3e9bc5e7cd782d30e8703679d/lib/Client.cc#L43
This way, if the user implements the ServiceUrlProvider. When it listens for a change in the service URL (such as through zk or other storage), it can invoke the client.updateServiceUrl method to update the URL.

We only need to support passing a std::functionstd::string(). The initialize and close methods are redundant.

Yes, you are right. The initialize and close methods are redundant.
In fact, The client already provides the updateServiceUrl method, which the user can use to implement dynamic update service URL. As for how the user implements it and how to close his resources, this is left to the user.
I changed to pass a std::function<const std::string&()> when creating a Client.

The initialize and close methods are redundant.

I reviewed the ServiceUrlProvider in Java client again. I have thought getServiceUrl() is called each time the service URL is needed (e.g. topic lookup) but it's actually not. The update of the service URL is actually done by PulsarClient#updateServiceUrl, which is triggered by the periodical task of ServiceUrlProvide#initialize.
If we want to implement AutoClusterFailover and ControlledClusterFailover in future, we actually don't need to implement a function that returns the service URL. Instead, we only need to implement the following methods:

PulsarClient#updateServiceUrl
PulsarClientImpl#updateAuthentication
PulsarClientImpl#updateTlsTrustCertsFilePath

The way of using ServiceUrlProvider is bad. It's more like a provider that can modify the internal state of PulsarClient.
For C++ client, this PR implements the similar way with Java that the ServiceUrlProvider (a function that returns the service URL) is only triggerred when constructing the Client instance. There will be no difference between
ServiceUrlProvider provider = /* ... */;
Client client(provider());

and
ServiceUrlProvider provider = /* ... */;
String serviceUrl = provider();
Client client(serviceUrl);

l'm going to send an email to dev mail list to discuss.

If we want to implement AutoClusterFailover and ControlledClusterFailover in future, we actually don't need to implement a function that returns the service URL. Instead, we only need to implement the following methods:

Yes, Actually, the ServiceUrlProvider  implemented here is just convenient for the user to return a function in order to get the service URL from elsewhere.
If we do not expose the set  ServiceUrlProvider, It's no problem too.
Use ServiceUrlProvider
Client client([]() {
    // get service URL from store.
    auto serviceUrl = xxx
    return serviceUrl;
})

ServiceUrlProvider is not used
    // get service URL from store.
    auto serviceUrl = xxx
    Client client(serviceUrl);

I exposed it just for ease of use.

If you feel redundant to expose this method, I can remove it. What do you think? /cc @BewareMyPower

I have sent an email: https://lists.apache.org/thread/cojz6qxpc7v0j8vy0w476ttt0f89zr3z

In short, a natural design is to save the ServiceUrlProvider in Client and call getServiceUrl() method (in C++ it's just a function invocation) each time we need a service URL. Maybe we need to maintain a key-value (serviceUrl -> ServiceNameResolver), when the serviceUrlProvider() returns a different result from the key, creating a new ServiceNameResolver for related lookup requests.

In short, a natural design is to save the ServiceUrlProvider in Client and call getServiceUrl() method (in C++ it's just a function invocation) each time we need a service URL. Maybe we need to maintain a key-value (serviceUrl -> ServiceNameResolver), when the serviceUrlProvider() returns a different result from the key, creating a new ServiceNameResolver for related lookup requests.

I think you only need the client to provide the updateServiceUrl method.
Users can take advantage of this approach to implement their own services. (Pseudocode)
class Store;
class AutomaticClusterService {
   public:
    explicit AutomaticClusterService(const Store& store, const Client pulsarClient)
        : store_(store), pulsarClient_(pulsarClient) {
        serviceUrlCache_ = store.queryServiceUrl();
        updateServiceUrlInterval_ = boost::posix_time::seconds(60);
        runUpdateServiceurl();
    }

    void start() {
        runUpdateServiceurl();
    }

    const std::string& getServiceUrl(){
        return serviceUrlCache_;
    }

    const void runUpdateServiceurl() {
        timer_->expires_from_now(updateServiceUrlInterval_);
        auto availableServiceUrl = store_.queryServiceUrl();
        timer_->async_wait([this](const boost::system::error_code& ec) {
          // Maybe some other implementation
          if (serviceUrlCache_ != availableServiceUrl) {
              serviceUrlCache_ = availableServiceUrl;
              pulsarClient_.updateServiceUrl(serviceUrlCache_);
            }
            runUpdateServiceurl();
        });
    }

   private:
    // External storage services
    Store store_;
    const Client pulsarClient_;
    std::string serviceUrlCache_;
    std::shared_ptr<boost::asio::deadline_timer> timer_;
    boost::posix_time::time_duration updateServiceUrlInterval_;
};

Store store;
Client client(store.queryServiceUrl());

AutomaticClusterService  automaticClusterService(store, client);
automaticClusterService.start();

//....

I think only need the client to provide the updateServiceUrl method.

This idea also looks good to me.

@shibd We should delay this feature until a result of this discussion.

Close this PR for now.


Resizing with bounds doesn't stop as it should

We need to re-implement or extract the bounds code from <Draggable> for use with Core.

Fixed in 0.10.2.


Error running word-count example

🐛 Bug Reports
Currently receiving this error when trying to run the word-count example. Am I missing a step in the build process?
C:\Users\kennedy-ryan\source\repos\pyo3\examples\word-count>python
Python 3.7.4 (tags/v3.7.4:e09359112e, Jul  8 2019, 20:34:20) [MSC v.1916 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> from word_count import search_py, WordCounter
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Users\kennedy-ryan\source\repos\pyo3\examples\word-count\word_count\__init__.py", line 1, in <module>
    from .word_count import WordCounter, count_line
ModuleNotFoundError: No module named 'word_count.word_count'

🌍 Environment

Your operating system and version: Windows 7 Enterprise Service Pack 1
Your python version: Python 3.7.4 (tags/v3.7.4:e09359112e, Jul  8 2019, 20:34:20) [MSC v.1916 64 bit (AMD64)] on win32
How did you install python (e.g. apt or pyenv)? Did you use a virtualenv?: From the Windows installer (https://www.python.org/ftp/python/3.7.4/python-3.7.4-amd64.exe)
Your rust version (rustc --version): rustc 1.38.0-nightly (2d1a551e1 2019-08-08)
Are you using the latest pyo3 version? Have you tried using latest master (replace version = "0.x.y" with git = "https://github.com/PyO3/pyo3")? Using the master branch as of todays date.

💥 Reproducing
git clone https://github.com/PyO3/pyo3.git
cd pyo3\examples\word-count
python setup.py install
python
from word_count import search_py, WordCounter

Problem:
python3
Python 3.7.4 (default, Jul  9 2019, 16:32:37)
[GCC 9.1.1 20190503 (Red Hat 9.1.1-1)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import word_count
>>> WordCounter("/home/davidm/Downloads/pyo3/examples/word-count/tests/test_word_count.py").search("import")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
NameError: name 'WordCounter' is not defined

SOLUTION:
>>> word_count.WordCounter("/home/davidm/Downloads/pyo3/examples/word-count/tests/test_word_count.py").search("import")
3

Thanks, I'll try doing a normal build and calling the module from it. So when would setuptools-rust or pyo3-pack be needed then? When making a wheel for someone else to install?

@omac777 Thanks for the tips and example. I was able to get it working by using cargo build --release. The only other change I needed to do was rename the dll to pyd.


Can't launch Spyder in Windows 11 with WSL2

Issue Report Checklist

[x] Searched the issues page for similar reports
[x] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
[x] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
[ ] Could not reproduce inside jupyter qtconsole (if console-related)
[ ] Tried basic troubleshooting (if a bug/error)

[ ] Restarted Spyder
[ ] Reset preferences with spyder --reset
[ ] Reinstalled the latest version of Anaconda
[ ] Tried the other applicable steps from the Troubleshooting Guide

[x] Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description
In Windows 11, i have installed WSL2 (Ubuntu 22.04.2), then proceeded to install miniconda inside WSL2 and created a new conda environment. After that, i install Spyder using conda install spyder, but when i try to launch it, i get this error:

What steps reproduce the problem?

Install WSL2 in Windows 11;
Install Miniconda in WSL2;
Create a fresh conda environment and install Spyder in it.

What is the expected output? What do you see instead?
Expect Spyder to launch, but got this error:
(tf) root@LDSPUFPE3:/mnt/c/Users/ldsp_# spyder
Could not load the Qt platform plugin "xcb" in "" even though it was found.
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: eglfs, minimal, minimalegl, offscreen, vnc, webgl, xcb.

Aborted

Paste Traceback/Error Below (if applicable)

PASTE TRACEBACK HERE

Versions

Spyder version: 5.4.3

Python version: 3.9.17

Qt version: Not really sure, there are too many qt related stuff i get from conda list. Here's a pic:

PyQt version: 5.15.7

Operating System name/version: Windows 11 with WSL2 (Ubuntu 22.04.2)

Dependencies
Can't launch Spyder, so i can't copy the dependencies.

Hey @muriloasouza, thanks for reporting. I don't think you'll be able to start Spyder as root in your system because graphical applications can't be started while you're root.
Instead, please log in as a regular user and try again. Let us know if that works for you.

Hello @ccordoba12, i have reinstalled WSL and now with a regular user i am having this problem:
(tf) ldsp@LDSPUFPE3:/mnt/c/Windows/system32$ spyder
Traceback (most recent call last):
  File "/home/ldsp/miniconda3/envs/tf/bin/spyder", line 11, in <module>
    sys.exit(main())
  File "/home/ldsp/miniconda3/envs/tf/lib/python3.9/site-packages/spyder/app/start.py", line 252, in main
    from spyder.app import mainwindow
  File "/home/ldsp/miniconda3/envs/tf/lib/python3.9/site-packages/spyder/app/mainwindow.py", line 46, in <module>
    from qtpy.compat import from_qvariant
  File "/home/ldsp/miniconda3/envs/tf/lib/python3.9/site-packages/qtpy/compat.py", line 18, in <module>
    from .QtWidgets import QFileDialog
  File "/home/ldsp/miniconda3/envs/tf/lib/python3.9/site-packages/qtpy/QtWidgets.py", line 14, in <module>
    from PyQt5.QtWidgets import *
ImportError: libGL.so.1: cannot open shared object file: No such file or directory

i have reinstalled WSL and now with a regular user i am having this problem:

Did you also install Xorg in WSL to be able to run graphical applications?

@ccordoba12 Thanks, following your advice i found some tutorial in how to do that. That fixed the issue.
Unfortunately, i found this is to be a bit complicated to make it work for the average user (like me), too many steps to make Spyder run in WSL.

A solution that worked for me is this
i) Open command prompt
ii)  run first, "wsl --update" ,  then "wsl --shutdown"
then open it back.
https://github.com/microsoft/WSL/issues/7950#issuecomment-1021203652


Only use customized JSON3-compactstringify within compactJSON filter

This library was globally overwriting the JSON object on window, which significantly decreased the performance of the application in some browsers because the try/catch within the custom code could not be optimized.
Test case: load a ~300kb dataset with 1000 rows, and profile the performance of adding the dataset with customized JSON3 and with the native JSON object.
Before this PR:

Initial dataset parsing time 3.03 seconds
After this PR:

Initial dataset parsing time 1.13 seconds

LGTM! -- the check isn't complete so I'll wait for it to complete first.

@kanitw my only concern with this was if we needed to use JSON3 anywhere else, but I did not see any other instances of it so my hope is that means we're good!

@kadamwhite   As far as I remember, we only use it here.
We also use it in vega-lite editor, but that does not depends on vega-lite-ui and the editor will be consolidated into vega-editor pretty soon so I think this is good.

:+1: Movin' on to the next thing, then


feat: 3207 - now displays a card for product website, if available

Impacted files:

app_en.arb: added 1 label for "website field title"
app_fr.arb: added 1 label for "website field title"
new_product_page.dart: now displays a card for website, if available
product_query.dart: added "website" product field

What

Added the product website to the product page, in READ and CLICK mode. Not on WRITE mode for the moment.

Screenshot

Part of

#3207

Codecov Report

Merging #3369 (682d6e2) into develop (b73cb76) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #3369      +/-   ##
===========================================
- Coverage    10.43%   10.41%   -0.02%
===========================================
  Files          256      256
  Lines        12466    12486      +20
===========================================
  Hits          1301     1301
- Misses       11165    11185      +20

Impacted Files
Coverage Δ

...smooth_app/lib/pages/product/new_product_page.dart
0.00% <0.00%> (ø)

packages/smooth_app/lib/query/product_query.dart
0.00% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


试试将MP3改为wav

@DinoChan
Just wondering why WAV instead of MP3? Licence issue?

@DinoChan
Just wondering why WAV instead of MP3? Licence issue?

I get a lot of complaints about TOAST, but I can't find the reason.Now I suspect these MP3 files are incompatible on some computers.It's just a try.


HIVE-23939: SharedWorkOptimizer: take the union of columns in mergeable TableScans

Work in progress...
Testing done:
mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestTezPerfCliDriver -Dqfile=query9.q -pl itests/qtest -Pitests
mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestTezPerfConstraintsCliDriver -Dqfile=query9.q -pl itests/qtest -Pitests

So looking through the Q tests (specifically auto_join_reordering_values.q.out) we have
explain select s.s_store_sk from store_n0 s join store_sales_n0 ss on (s.s_store_sk = ss.ss_store_sk) join store_n0 s1 on (s1.s_store_sk = ss.ss_store_sk) where s.s_floor_space > 1000
In the explain plan this produces
filterExpr: (((s_floor_space > 1000) and s_store_sk is not null) or s_store_sk is not null)
This filter expression can be reduced down to s_store_sk is not null
e.g. ([P && Q] || Q) => Q
This isn't correct since its going to ignore the where s.s_floor_space > 1000
It seems to me that the correct behavior would be to either...

Continue to combine them naively but with an and instead of an or and allow something downstream to optimize it out.
e.g. ([P && Q] && Q) which will get reduced down to (P && Q)
Optimize the statement here so that when they are combined you just get (P && Q)

There are similar issues in other Q tests but I chose this one for simplicity, if this isn't clear I'd be happy to clarify more.

@HunterL
Thanks for reviewing this patch.
The expression
filterExpr: (((s_floor_space > 1000) and s_store_sk is not null) or s_store_sk is not null)

is a result of merging two TableScanOperators. Both of them are scanning the same table: alias: s but they had different filterExpr.
TS1: ((s_floor_space > 1000) and s_store_sk is not null)
TS2: s_store_sk is not null
SharedWorkOptimizer naively combined the filter expressions using or because we need the union of the records produced by both TS. You are right in this particular case the filter expression could be reduced to s_store_sk is not null
The new TS has two children
TableScan
  alias: s
  filterExpr: (((s_floor_space > 1000) and s_store_sk is not null) or s_store_sk is not null) (type: boolean)
  Filter Operator
    predicate: ((s_floor_space > 1000) and s_store_sk is not null) (type: boolean)
    ...
  Filter Operator
    predicate: s_store_sk is not null (type: boolean)
    ...

both of them are Filter operators which are the root of subtrees to broadcast the proper subset of records to each reducer edge (Reducer 2 and Reducer 3)
If and were used for combining the filter expressions of TS operators the branch which does not have the filter s_floor_space > 1000 would loose a subset of records.


parse error message in case of assignment to literal

closes #509

Codecov Report

Merging #510 (cfd24bf) into master (0208b08) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #510   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           13        13
  Lines          734       734
=========================================
  Hits           734       734

Impacted Files
Coverage Δ

nbqa/output_parser.py
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0208b08...cfd24bf. Read the comment docs.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (0208b08) to head (b732dcf).
Report is 215 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##            master      #510   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           13        13
  Lines          734       734
=========================================
  Hits           734       734

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add package biblioteca_guarrilla

https://github.com/juancarlospaco/biblioteca-guarrilla#biblioteca-guarrilla

Oh no, you are right, I will check it later, thanks. :disappointed:

It should work now. :slightly_smiling_face:

Version Bump. Sync with Master.

Still the same message.
I guess you also need to bump the git tag/version, not only in the .nimble file.

Bump'd Git Tag 0.1.9.

Now it installs it successfully, but with some post-install quirks regarding the missing static directory.
I'm merging it, but if you like to solve it @juancarlospaco here is what happens:
   Success: biblioteca_guarrilla installed successfully.
    Prompt: Missing file /home/miran/.nimble/pkgs/biblioteca_guarrilla-0.1.9/src/static/css/spectre.min.css. Continue? [y/N]
    Answer: y
    Prompt: Missing file /home/miran/.nimble/pkgs/biblioteca_guarrilla-0.1.9/src/static/css/spectre-exp.min.css. Continue? [y/N]
    Answer: y
    Prompt: Missing directory /home/miran/.nimble/pkgs/biblioteca_guarrilla-0.1.9/src/static. Continue? [y/N]
    Answer: y
    Prompt: Missing directory /home/miran/.nimble/pkgs/biblioteca_guarrilla-0.1.9/src/static/css. Continue? [y/N]
    Answer: y

Thanks for the patience :grey_exclamation:
That is already documented on the readme of the project. Maybe on the future I can just staticRead it.


Updating language specification

This PR updates the language specification as follows:

Documents polymorphic this type (#4910).
Documents type parameters as constraints (#5949).
Fixes #537, #541, #543, #729, #1436, #1603, #1811, #4651, #4654.
Updates terminology from ECMAScript 6 to ECMAScript 2015.
Updates code generation examples for modules.
Adds TODO links for all new features.

A good deal of writing still needs to be done to eradicate all of the TODOs, but at least we now have everything collected in one up-to-date document.

@ahejlsberg the failing test should be fixed in master now.


1 Minute Overview

Script:

[ ] Write Script
[ ] Record Audio
[ ] Record Video
[ ] Attach Video and Audio

Points to talk about:

Website for users who are unsure what to cook for dinner
About page: about website authors and introduction for website
Spinning wheel to determine cuisine (Chinese, Indian, Japanese, Mexican, Thai, Indian)
After wheel spun, new page with 5 recipes: 1 overall recipe, 4 with dietary preferences (gluten free, low sodium, dairy free, vegetarian)
Chatbox/ gemini program, talk about user experiences with other users. Appears on each specific recipe page (every recipe has its own chatbox)
Form/ posting system for users to post recommendations of other recipes, recommendations, cuisines, etc,
Separate page to view the posts of recommendations (similar to social media site but food focused)


Build Error: no member named 'view' in 'std::stringstream'

Issue
I get the following error when trying to build the TUI:
/Users/kai/Projects/uulm-mensa-tui/src/main.cpp:68:48: error: no member named 'view' in 'std::stringstream'
        const json& api_response = json::parse(result.view());
                                               ~~~~~~ ^

Expected behavior
Should build without errors.
Additional Information

OS: macOS Sonoma 14.0
cmake version: 3.27.7

Yeah, Apple ships a custom build of clang which doesn't have full support for C++ 20. Try building with a recent version of g++ (I use 13.2).
You can instruct CMake to use g++ by setting the CMAKE_CXX_COMPILER variable.

Could you resolve your issue in the meantime?

No; I have no experience in CMake, so I'll have to look it up sometime in the next days.

Closed due to inactivity. But feel free to reopen this issue at any time!


fix gate check

What this PR does / why we need it:
Which issue this PR fixes(if applicable):
fixes #
Special notes for reviewers:

Release note:

NONE

we can close this? see https://github.com/kubernetes/cloud-provider-openstack/pull/2100


Move all modules into project namespace so it can be installed without conflicts

I started experimenting with this and particularly with building it as a system package so I can more easily use it as build tooling in other projects and immediately ran into at least this issue: everything gets installed into a top level directory with no namespacing at all in relation to the rockname.
There are some other issues that I'm trying to sort out to, but at the very least this move seems like a given: "zip" for example cannot be a module name claimed by this project and installed globally with this rock ;-)

This is perfect! thank you so much, I really should have done this myself. Let me do a bit of testing and ill merge

Alright, I just need to change the luaopen name of zip and it should work

There seems to be a linker error? trying to fix


Add versioned docs

I ran into the following problem trying to run the BG/NBD example code.  When I run the code block
model = clv.BetaGeoModel(data = data)
model.build_model()
model.fit()

I get the error
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Cell In[8], line 1
----> 1 model = clv.BetaGeoModel(data = data)
      2 model.build_model()
      3 model.fit()

TypeError: BetaGeoModel.__init__() got an unexpected keyword argument 'data'

After some investigation, this seems to be happening because the arguments for a new BetaGeomModel class changed from a 4 vectors -- customer_id, recency, frequency, and T -- to a pandas DataFrame with those columns sometime between version 0.1.1 (the version on conda-forge) and version 0.2.0 (the current version).
To fix this, I'd recommend adding a note in the documentation to flag the change for users, like this:
model = clv.BetaGeoModel(data = data)
# For versions prior to [version number], use the following instead:
# model = clv.BetaGeoModel(
#    customer_id = data['customer_id'],
#    frequency = data['frequency'],
#    recency = data['recency'],
#    T = data['T']
#    )
model.build_model()
model.fit()

I'm happy to create a pull request with this change, if you think it makes sense.  Thanks for considering, and for building this great package!

Hi,
I think we should have versioned docs so that you can select the specific version you have installed and check the API for that.
Otherwise things get messy if we change API again and now have to document the 2 old methods and so so on.
We'll also try to be more careful next time we break the API and at least raise an informative error.
About the changes I'll copy my message to another user who was surprised by the API changed:

Because we're still in an early state (version <1) the API is still subject to change. We're trying to get it right before we freeze it.

If you are doing production or sensitive work we suggest you pin your dependency versions in a >=0.x, <0.x+1 range, which will include only bugfixes but no breaking changes

That makes sense -- versioned docs would be fantastic.  And I definitely understand about the API changing in early versions.  If nothing else, hopefully having this issue open will help someone else sort out the error a little bit more easily.  Let me know if I can help, and thanks again.

Done! The docs for 0.1.1 version is available at https://www.pymc-marketing.io/en/0.1.1/
Thanks for bringing the issue up @jcfisher


Setting sync : Resolving conflict

We have written the needed data into your clipboard because it was too large to send. Please paste.

Not getting closed


[Feature Request] make Move package manager's git cache thread-safe

Problem
I ran into an issue when trying to use the package manager in a multithreaded context. Specifically:

I have some genesis modules w/ git dependencies on the Move stdlib that get built using the Move package manager
I have two Rust unit tests that each call this build
The tests are run concurrently and (occasionally, but not consistently) crash the package manager with a called Result::unwrap() on an Err value: No such file or directory (os error 2) message or a message about failing to resolve the Move stdlib in the package manager's cache.

I solved my problem by doing the genesis build lazily + only once via a once_cell constant, which removes the crashes described above. So this issue is by no means a blocker for me, but it would be nice if the package manager protected you from this by default (especially since it took me awhile to figure out what was going on).
Apologies for not providing a repro, but I think any code that tries to concurrently build a Move package w/ git dependencies should exhibit this problem.
Proposed solution
I believe cargo addresses this by using a file lock to ensure that multiple instances of cargo are never running concurrently while touching the file system--this is presumably what the Blocking waiting for file lock on build directory message you get while doing two builds at once means. I think a similar solution would work well for the Move package manager.

Closing as this issue should be resolved by https://github.com/diem/move/pull/13


Multiple export defaults in Typescript overloading

Issue Type: Bug
I have a function which is overloaded a few times and I exported it as default. When I do this, the first line of export default function Tstring get's it's syntax highlighting properly. Then the next few lines of those all turn yellow (the color of functions)
VS Code version: Code 1.53.2 (622cb03f7e070a9670c94bae1a45d78d7181fbd4, 2021-02-11T11:48:04.245Z)
OS version: Windows_NT x64 10.0.19041

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz (12 x 2208)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: enabledrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
7.86GB (1.14GB free)

Process Argv
--crash-reporter-id 0c07a3ea-19d3-4b7d-9182-a845b9918a7b

Screen Reader
no

VM
0%

Extensions (34)

Extension
Author (truncated)
Version

ng-template
Ang
11.2.2

jar-builder
asl
1.1.1

vscode-intelephense-client
bme
1.6.3

ng-html
dan
1.1.3

githistory
don
0.6.14

es7-react-js-snippets
dsz
3.1.0

EditorConfig
Edi
0.16.4

prettier-vscode
esb
5.9.2

php-debug
fel
1.14.9

php-intellisense
fel
2.3.14

php-pack
fel
1.0.2

code-runner
for
0.11.2

rest-client
hum
0.24.4

discord-vscode
icr
5.2.2

python
ms-
2021.2.576481509

jupyter
ms-
2021.2.576440691

reload
nat
0.0.6

vetur
oct
0.32.0

laravel-blade
one
1.25.0

colorful-comments
Par
0.6.0

material-icon-theme
PKi
4.5.0

java
red
0.75.0

rust
rus
0.7.8

swdc-vscode
sof
2.4.9

sass-indented
syl
1.8.15

tabnine-vscode
Tab
3.2.7

vscodeintellicode
Vis
1.2.11

vscode-java-debug
vsc
0.31.0

vscode-java-dependency
vsc
0.18.0

vscode-java-pack
vsc
0.12.1

vscode-java-test
vsc
0.28.0

vscode-maven
vsc
0.27.1

quokka-vscode
Wal
1.0.343

vscode-import-cost
wix
2.15.0

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstry914:30256638
pythonvsdeb440:30248342
pythonvsded773:30248341
vstes627cf:30244335
pythonvspyt875:30251590
pythontb:30258531

Minimal code example:
export default function foo(): any
export default function foo(): any {  }

I would assume that you don't have semicolons at the end of overload lines?
Reproduced only on lines that are after line without and requires default keyword

(Latest Insiders and typescript@next)

Ok this is what I was missing. thanks

Shouldn't this one be still open?
Because ; is not required here for TS to work properly, but highlight is broken.

Yes I'm reopening because this seems like a bug with the grammar


v2.0

Add /me endpoints
Remove user targetting on the /students endpoint

https://github.com/vtfk/azf-pifu-api/releases/tag/2.0.0

https://github.com/vtfk/azf-pifu-api/releases/tag/2.0.0


observatorium-logs: Add query-scheduler and index-gw components

This PR introduces the changes addressed in observatorium/observatorium#463 and observatorium/observatorium#464, i.e.:

Add new query-scheduler deployment and its service monitor resources
Add new index-gateway statefulset and its service monitor resources
Replace querier statefulset with a deployment resource.
Address Loki configuration changes to use the query-scheduler and the index-gateway.

Diff fails as it now adds a bunch of imagePullPolicy: IfNotPresent, so just running make all should take care of it! :)


Add " for --data on cURL document maker

Pull Request Test Coverage Report for Build 508

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.001%

Totals

Change from base Build 506:
0.0%

Covered Lines:
1708

Relevant Lines:
1817

💛  - Coveralls


Move processUtils to globals

Description
Move processUtils from process to globals.

Last time I tried this it broke the roll. Trying again with the fancy FRoB tools.


Knowing when typing ends

It would be very useful to know when they animation is done, or even when each index in sequence is done

Nvm, I  missed the callback in sequence array


[Feature][zentao] Collect&Extract&Convert tasks

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
Collect&Extract&Convert tasks
Use case
Collect&Extract&Convert tasks
Related issues
#2961
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I am willing to submit a PR

Hi @yuqiangabab Any updates about this issue?

Closed as it's finished.


Fix bug where ls misbehaves in the presence of modules

Fixes #3241

Also add some tests for DataServiceSpec regarding views and modules

A test timed out on appveyor, restarted, will merge when that's green!


Add kjnodes seed node for Teritori

Have added port for the seed node

Thanks for fixing, @kj89 !


Consolidate two for loops when poll data Block from multi stream consumers

Leverage the modular arithmetic to avoid code duplication.

Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b9ed378) 61.65% compared to head (b05a2e1) 27.61%.

Files
Patch %
Lines

...me/operator/utils/BlockingMultiStreamConsumer.java
0.00%
2 Missing :warning:

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #12071       +/-   ##
=============================================
- Coverage     61.65%   27.61%   -34.05%
+ Complexity     1152      201      -951
=============================================
  Files          2389     2389
  Lines        129819   129812        -7
  Branches      20082    20081        -1
=============================================
- Hits          80036    35842    -44194
- Misses        43958    91269    +47311
+ Partials       5825     2701     -3124

Flag
Coverage Δ

custom-integration1
?

integration
?

integration1
?

integration2
?

java-11
?

java-21
27.61% <0.00%> (-33.92%)
:arrow_down:

skip-bytebuffers-false
27.59% <0.00%> (-34.02%)
:arrow_down:

skip-bytebuffers-true
27.60% <0.00%> (-33.89%)
:arrow_down:

temurin
27.61% <0.00%> (-34.05%)
:arrow_down:

unittests
27.61% <0.00%> (-34.04%)
:arrow_down:

unittests1
?

unittests2
27.61% <0.00%> (-0.03%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.