Modify solarized themes for windows terminal to make all text visible

Summary of the Pull Request
I have been wanting to use the solarized theme provided in windows terminal since release. I have been unable to use it since the terminal becomes unreadable with the solarized themes supplied. The Solarized theme doesn't specify colors in a manner which complies with the options required by windows terminal. For example there is no concept of "bright" colors in the Solarized spec. This change treats the normal colors the same as the bright colors.
All of the text is at least visible now. The the colors (white/black/green/blue/etc..) no longer match the backgrounds. Black is still hard to read on the dark theme. White is still hard to read on the light theme.

PR Checklist

[ ] Closes #xxx
[X ] CLA signed. If not, go over here and sign the CLA
[ ] Tests added/passed
[ ] Requires documentation to be updated
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments
Dark Theme

Old
New

Light Theme

Old
New

Palette

Old
New

Validation Steps Performed

So, regarding there being no "bright" colors in the solarized spec: I don't believe we are using them as bright colors. Just like Solarized, we use them to gain an additional 9 color palette slots. These themes are specialized for things that know about Solarized, and perhaps they were not appropriate to ship for general purpose use as Terminal themes.
/cc @zadjii-msft thoughts?

I'm not going to try and defend the Solarized color schemes, because I think they're awful. But if you don't like those colors, then you really ought to come up with your own name for whatever alternatives you're proposing, and not just replace the official Solarized values. People that actually like the Solarized schemes assumedly expect the colors exactly the way they are.
And if it comes to proposing new schemes to be included in the app by default, I'd like to think we could do better than a scheme that can't distinguish bright from dark. At the very least open an issue first and give people a chance to vote on it.
Just my 2c.

Can you point me to the official Solarized documentation for its use with conhost/windows terminal? I don't see it listed on the website or repo. I see official use of the color palettes for other terminals but not conhost/wt.
To try and get a point of reference I remembered VS Code has a Solarized theme and a built in terminal. Below is a comparison of the wt theme and VS code terminal both using Solarized dark. One of several differences is that all text in VS Code is visible which is critically important.

wt
VS Code

If there is no room to change the the Solarized themes I agree with @DHowett-MSFT sentiment about removing them.

I'm mostly looking at the following table, which is taken from here on the solarized site. Clipped to only the relevant columns:

SOLARIZED
HEX
16/8
TERMCOL
M/HEX
RGB

base03
#002b36
8/4
brblack
#1c1c1c
0  43  54

base02
#073642
0/4
black
#262626
7  54  66

base01
#586e75
10/7
brgreen
#585858
88 110 117

base00
#657b83
11/7
bryellow
#626262
101 123 131

base0
#839496
12/6
brblue
#808080
131 148 150

base1
#93a1a1
14/4
brcyan
#8a8a8a
147 161 161

base2
#eee8d5
7/7
white
#e4e4e4
238 232 213

base3
#fdf6e3
15/7
brwhite
#ffffd7
253 246 227

yellow
#b58900
3/3
yellow
#af8700
181 137   0

orange
#cb4b16
9/3
brred
#d75f00
203  75  22

red
#dc322f
1/1
red
#d70000
220  50  47

magenta
#d33682
5/5
magenta
#af005f
211  54 130

violet
#6c71c4
13/5
brmagenta
#5f5faf
108 113 196

blue
#268bd2
4/4
blue
#0087ff
38 139 210

cyan
#2aa198
6/6
cyan
#00afaf
42 161 152

green
#859900
2/2
green
#5f8700
133 153   0

Which, if you re-order the rows to be in terminal color order, looks like the following:

SOLARIZED
HEX
16/8
TERMCOL
M/HEX
RGB

base02
#073642
0/4
black
#262626
7  54  66

red
#dc322f
1/1
red
#d70000
220  50  47

green
#859900
2/2
green
#5f8700
133 153   0

yellow
#b58900
3/3
yellow
#af8700
181 137   0

blue
#268bd2
4/4
blue
#0087ff
38 139 210

magenta
#d33682
5/5
magenta
#af005f
211  54 130

cyan
#2aa198
6/6
cyan
#00afaf
42 161 152

base2
#eee8d5
7/7
white
#e4e4e4
238 232 213

base03
#002b36
8/4
brblack
#1c1c1c
0  43  54

orange
#cb4b16
9/3
brred
#d75f00
203  75  22

base01
#586e75
10/7
brgreen
#585858
88 110 117

base00
#657b83
11/7
bryellow
#626262
101 123 131

base0
#839496
12/6
brblue
#808080
131 148 150

violet
#6c71c4
13/5
brmagenta
#5f5faf
108 113 196

base1
#93a1a1
14/4
brcyan
#8a8a8a
147 161 161

base3
#fdf6e3
15/7
brwhite
#ffffd7
253 246 227

This is also the order that the very excellent iTerm2-Color-Schemes repo uses

Until we can get to discussion consensus, I'm gonna close this one. Feel free to continue the chat - this just isn't actionable right now!

I'm mostly looking at the following table, which is taken from here on the solarized site. Clipped to only the relevant columns:

Ah I see! I wasn't interrupting that table correctly. Now I understand the comments about not following the Solarized scheme.

@DHowett-MSFT I know we don't love the default Solarized themes, and it's too late to remove them, but what are your thoughts on shipping these proposed changes as "Solarized [Light|Dark] (Patched)"?
Actually lets get some more peeps in this discussion: @carlos-zamora @leonMSFT @miniksa @cinnamon-msft @craigloewen-msft @the-entire-console-team-and-everyone-we-know-why-not

I'm okay with shipping these modified schemes. Also, if we're going to ship these, I feel like we could add more in? Not sure how everyone feels about shipping a ton of themes in-box.

In case anyone has missed this point, let me reiterate that these patched Solarized schemes are still very much broken. By making the light and dark colors the same, they are guaranteed to produce invisible text in some applications.
If we are going to include these, I'd urge you to try and find a bunch of good color schemes to include as well. Otherwise we're going to be left with 4 of the 9 bundled schemes being some variant of Solarized, all of which have problems of some sort. That's not a great user experience.


Added Kadane's Algorithm in JavaScript

Added Kadane's Algorithm in JavaScript and update the README.md file

Thanks, really grateful


machine: Handles undefined CPU and RAM Range max

Before this commit, if user constructs CPU and RAM Range
with only one number, e.g. new Range(2), the max of the
Range will be undefined, and inRange will return False.
This commit changes inRange function to treat undefined as
infinity.

Fixed.

Can you fix the commit name, consistent with the other PR?

What do we need to do for this to get merged? It's causing the build to fail for some of our example blueprints, so I'd like to get it in.

bump @ejj I think this is waiting on you

@HongjianZhang can you update the commit message here?


chore:interopnet&devnet:fix build error

Signed-off-by: detailyang<EMAIL_ADDRESS>Summary of changes
Fix the build error as the following:
   Compiling networks v0.1.0 (/Users/detailyang/art/github/detailyang/forest/types/networks)
error[E0659]: `UPGRADE_BREEZE_HEIGHT` is ambiguous (glob import vs glob import in the same module)
  --> types/networks/src/lib.rs:43:17
   |
43 |         height: UPGRADE_BREEZE_HEIGHT,
   |                 ^^^^^^^^^^^^^^^^^^^^^ ambiguous name
   |
note: `UPGRADE_BREEZE_HEIGHT` could refer to the constant imported here
  --> types/networks/src/lib.rs:16:9
   |
16 | pub use self::mainnet::*;
   |         ^^^^^^^^^^^^^^^^
   = help: consider adding an explicit import of `UPGRADE_BREEZE_HEIGHT` to disambiguate
note: `UPGRADE_BREEZE_HEIGHT` could also refer to the constant imported here
  --> types/networks/src/lib.rs:21:9
   |
21 | pub use self::interopnet::*;

Reference issue to close (if applicable)

Closes
Other information and links

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hello. It looks like the CI was failed because of the nightly build related (See PR #1154 ).

@detailyang Can you merge main onto this branch? It should resolve the CI issue.

@detailyang Can you merge main onto this branch? It should resolve the CI issue.

I can do that

Great!
@detailyang Thank you for your contribution!


Poseidon::Connection#read_response hides Timeout errors

I want to be able to read from Kafka indefinitely in an infinite loop. When developing locally on my laptop, I often have no messages to read. I'd like to just block the process calling #fetch by rescuing timeouts and rerunning #fetch. However, the exception class ConnectionFailedError is raised in place of not only TimeoutException, but also Errno::ECONNRESET and SocketError.
The consequence for me is that my spin loop can't distinguish between network errors and a partition that simply has no messages to send down to the client. Is there another way I should be doing this, e.g. detecting if I have no messages before I call fetch?

+1

+1


Move combinations, permutations, etc., from Array to Indexable

I tried to implement #10063 to help judging if it's feasible.
Moving Array.product to Indexable made no sense to me.  Therefore it was also not possible to move Array#repeated_permutations to Indexable
Fixes #10063

#repeated_permutations can be implemented on top of #10013.

#repeated_permutations can be implemented on top of #10013.

@wonderix This is great, thank you!

@wonderix This is great, thank you!


feat: add PropagateTags to RunTask call

By default, new Fargate Tasks don't have any Tags defined. For monitoring and cost explorer it would be nice to have tags at the running tasks as well.
ECS allows to propagate Tags from the Service or from the Task Definition when issuing a RunTask command.
this PR adds an additional option to enable this tag propagation.

Thanks!
Since we execute our own tasks and don't use a service, we can probably make this a boolean that ends up using PropagatedTagSource.TASK_DEFINITION when true. That said, I can't think of a reason someone would want to disable this in the first place. What do you think about making it on by default?

Totally fine by me. I just didn't want to introduce changes or side-effects.


Update docs with Crate Java client deprecation

Recent commits appear to deprecate the Crate Java client in favor of JDBC. The Crate.io website does not reflect this.

hi @varnerac, yes this is true and we will communicate this, but as you said at the moment we are "just" working on it.

Hi @varnerac - we actually did this some time ago now :) Thanks for reporting!
https://crate.io/docs/clients/java/


npm install mongo-express is different than github sources.

After install directly on my dev server with npm install mongo-express, I have some issue to install it automatically with ansible because of the git module.
git clone files are not the same than the npm install ones and present many errors.

@andzdroid

That means ?

same problem here, also the code (from npm) and documentation don't match

I ended up pulling directly from github:
npm install andzdroid/mongo-express
to fix the problem, I guess the npm package is just not updated

I've just been given write access to NPM, version bumped and pushed latest.


Spanish translation of faq-functions

References to #4
@dmoralesm , @carburo  and @alejandronanez

Hey @florenciasilva, welcome to the project!!! Is this ready for another review?
Thanks!

Hey @florenciasilva, welcome to the project!!! Is this ready for another review?
Thanks!

Hey! I just committed all the changes, so it should be ready for a review!

Thank you! I'm merging it then.


Query: Avoid anonymous type constants in expression tree

Pulled in 3.0. Required for case1 of #17048


Move 1.8.7 to GHA in 3.10

https://github.com/rspec/rspec-core/pull/2856
https://github.com/rspec/rspec-expectations/pull/1284
https://github.com/rspec/rspec-mocks/pull/1406
https://github.com/rspec/rspec-support/pull/491

Hooray! 👏 Thank you!

Hooray! 👏 Thank you!


Allow either path or env variable for credentials

init
Running init creates a .cogs directory containing configuration data. This also creates a new Google Sheets spreadsheet and stores the ID. Optionally, this new sheet may be shared with users.
cogs init -c [path-to-credentials] -t [project-title] -u [email] -r [role]

gspread needs credentials to create a service account; you can either provide these with a file (-c [path]) or with an environment variable (GOOGLE_CREDENTIALS). The environment variable should be a string containing the contents of the credentials file. You must surround the contents with single quotes when setting this variable:
export GOOGLE_CREDENTIALS='{...}'

We could also make each field in the credentials file its own environment variable, but then we would need 10 variables instead of just one.


Custom Data

Is it possible for me to add some custom fields to each country in addition to the ones provided in the YAML file so I can access that data via the Country class?
Thanks!

I think something like this is outside the scope of this gem. Maybe you should store this custom data in a Country Active Record model, and consider this gem be "static" data added on to your custom model.


Initial Integration with codecov

Solve issues #109

I think the coverage report from Vite (0.17.0) doesn't look compatible with Codecov.
How about trying to update the Vite version to the latest version?

I've downgraded the vitest, since too many breaking changes. Now it is working.


Use test resource location for files

Purpose
$subject

Codecov Report
Patch coverage has no change and project coverage change: +55.74 :tada:

Comparison is base (e67c395) 24.36% compared to head (d2b82e8) 80.10%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1453       +/-   ##
===========================================
+ Coverage   24.36%   80.10%   +55.74%
===========================================
  Files         260        9      -251
  Lines       30826      548    -30278
  Branches     4834      246     -4588
===========================================
- Hits         7512      439     -7073
+ Misses      23048      109    -22939
+ Partials      266        0      -266

Flag
Coverage Δ

adapter
?

common-controller
?

config-deployer-service
?

idp-domain-service
80.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 251 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


client objectmapper javadoc inconsistent with impl

https://github.com/palantir/http-remoting/blob/develop/extras/jackson-support/src/main/java/com/palantir/remoting2/ext/jackson/ObjectMappers.java#L52
the doc says it ignores unknown properties
which is the desired behaviour? (I can throw up a PR)

This is correct/consistent already; the Jackson settings are a bit annoying to read, but we're disabling the fail-on-unknown error, which means it accepts unknown properties.

eep sorry, misread.


ActiveRecordCoder: encode wether the record was persisted or not

Fix: https://github.com/Shopify/paquito/issues/10
Closes: https://github.com/Shopify/paquito/pull/11
Unfortunately AR::Base.instantiate doesn't provide a way to pass wether the record was persisted or not, so we have to bypass it.
By doing so we skip discriminate_class_for_record which decide which subclass to use for STI, but I don't think we need it.
Important Note: this change is able to read payload generated by older versions of Paquito, however older versions of Paquito will fail to read these new payloads
I'm tempted to release a 0.6.2 that would be able to handle the new format but keep generating the old one, and then release this as a 0.7.0.
cc @npezza93, @shioyama

Ok, 0.6.2 is out. We could merge this and release 0.7.0 now, but might be safer to let 0.6.2 sink for a week or so?


Add a finalizer to the ImagePolicy and ImageRepository resources

Fixes https://github.com/fluxcd/image-reflector-controller/issues/225
This PR adds a finalizer to the ImagePolicy and ImageRepository resources. This is to properly record the Deleted reconciliation status when the object is deleted from the cluster. Without this change, the resource would be deleted before the image reflector controller has a chance to properly report the resource's status in the metrics. As a result, end-users may see falsely reported metrics.
Signed-off-by: Kaden Nelson<EMAIL_ADDRESS>

@stefanprodan I had some community folks query about this PR.  Do you by any chance have any visibility into it or is it on someone else’s radar?


fix: don't run e2e tests against wrong anvil

This PR fixes an issue when running e2e tests locally against an already running instance of aztec

#5686  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alexghr and the rest of your teammates on  Graphite

Benchmark results
No metrics with a significant change found.

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
64 txs

l1_rollup_calldata_size_in_bytes
676
676
676

l1_rollup_calldata_gas
6,424
6,424
6,424

l1_rollup_execution_gas
585,757
585,757
585,757

l2_block_processing_time_in_ms
1,287 (-2%)
4,683 (+2%)
9,759 (-5%)

note_successful_decrypting_time_in_ms
260 (-12%)
492 (-1%)
940 (+8%)

note_trial_decrypting_time_in_ms
41.5 (-56%)
102 (-6%)
59.1 (-32%)

l2_block_building_time_in_ms
10,352 (+2%)
36,935 (+2%)
73,716 (+3%)

l2_block_rollup_simulation_time_in_ms
10,231 (+2%)
36,532 (+2%)
72,969 (+3%)

l2_block_public_tx_process_time_in_ms
4,888 (+3%)
19,134 (+3%)
38,107 (+3%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
14,060 (-1%)
27,255 (+3%)

note_history_successful_decrypting_time_in_ms
1,193
2,230 (-1%)

note_history_trial_decrypting_time_in_ms
37.6 (-12%)
78.3

node_database_size_in_bytes
18,628,688
34,992,208

pxe_database_size_in_bytes
29,859
59,414

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
144 (+1%)
44,281
26,164

private-kernel-inner
152 (+1%)
71,648
26,164

private-kernel-ordering
112 (+1%)
50,830
39,026

base-parity
4,001 (+1%)
128
311

root-parity
1,086
1,244
311

base-rollup
13,637 (+3%)
110,464
861

root-rollup
49.6 (+1%)
4,359
725

public-kernel-app-logic
79.7 (+1%)
47,599
40,661

public-kernel-tail
113 (+2%)
53,372
7,125

merge-rollup
11.4 (+6%)
2,568
861

public-kernel-teardown
75.8
47,599
40,661

public-kernel-setup
74.8
47,599
40,661

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
512 leaves
1024 leaves
2048 leaves
4096 leaves
32 leaves

batch_insert_into_append_only_tree_16_depth_ms
10.2 (+2%)
16.3 (+2%)
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.8
31.6
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.591 (+1%)
0.503 (+2%)
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
46.1 (+1%)
75.7 (+3%)
230 (+3%)
446
872 (+3%)
1,838 (+2%)
N/A

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
96.0
159
543
1,055
2,079
4,127
N/A

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.472 (+1%)
0.466 (+3%)
0.420 (+3%)
0.417
0.414 (+2%)
0.438 (+2%)
N/A

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
54.6 (+2%)
109
338 (+4%)
662 (-1%)
1,310 (+4%)
2,942 (+15%)
N/A

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
105
207
691
1,363
2,707
5,395
N/A

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.482 (+2%)
0.494
0.460 (+3%)
0.455
0.454 (+3%)
0.503 (+14%)
N/A

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
61.2

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
109

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
0.534

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
40,372
496,534

Transaction size based on fee payment method

Metric
native fee payment method
fpc_public fee payment method
fpc_private fee payment method

tx_with_fee_size_in_bytes
905
1,161
1,377

Transaction processing duration by data writes.

Metric
0 new note hashes
1 new note hashes
2 new note hashes

tx_pxe_processing_time_ms
1,176 (+1%)
821 (+1%)
3,975

Metric
1 public data writes
2 public data writes
3 public data writes
4 public data writes
5 public data writes
8 public data writes

tx_sequencer_processing_time_ms
423 (+1%)
283 (-1%)
734
365
1,200
428 (-1%)


Obsolete PushClient.SendAsync

PushClient was never to surface this API.  Instead, customers should be using the NotificationHubClient directly.
I also had to remove the test for SendAsync, since it's no longer relevant.

Hi @aziel, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (azepil). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

Resolves Issue#53


JS error for current time stuff on iPad Generation 1 original iOS Safari

This is a super old version of safari. Not sure if compatibility issue is with jQuery of plain vanilla js.

Wont' fix this - jQuery is not compatible with safari 4.0.4 on iOS 3.2.


Support html parser

Need to use HTML parser to format HTML files: https://github.com/prettier/prettier/issues/1882#issuecomment-437631682
Currently only babylon and flow are supported parsers for coc-prettier

What needs to be done to support the html-parser. The vetur plugin has something like:
vetur.format.defaultFormatter.css
vetur.format.defaultFormatter.js
vetur.format.defaultFormatter.html
.. and so on

Are you thinking something in lines of that?
prettier.parser = whatever the default is
prettier.parserOverride.html = html

and maybe from tailwind:
tailwindCSS.htmlLanguages = [
  html,
  blade,
  ejs
]

Just thoughts.


Route redirect url encoding

staticwebapp.config.json
{
    "routes": [
        {
            "route": "/tiktok",
            "redirect": "https://www.tiktok.com/@myuser",
            "statusCode": 301
        }
}

When navigating to https://myapp.com/tiktok redirects to https://www.tiktok.com/%40myuser
According to RCF 3986 the @ sign is a valid url component and should not be encoded
Also more generally speaking I agree with what was said in #1007

the service should not be URL encoding what we enter for redirect values without us explicitly telling it to. In other words, our redirect URLs should function exactly as we have written them.

@annikel you closed my previous issue (#1007) without any further clarification.
Meanwhile, it's clear that an RCF supports what was already my gut feeling. Good job @Xriuk, btw!
Could you please address this now?


benchmark runner is passed --bench even when harness = false

I'm experimenting with benchmarking for Rust stable. One way to tie into cargo is simply to use the benchmark facility:
[[bench]]
name = "benchmarks"
harness = false

This compiles and runs, using a dev-dependency in the benchmark runner and so on. The only unexpected part is that it is passed --bench as a command line argument (and to add to that, it's not the first argument but the last). I'd expect it does not use --bench when harness = false.

Sounds reasonable to me! Unfortunately this won't be trivial to implement in Cargo, but the info's all there in one way or another, just need to connect the dots.

Could you clarify what the downside is to --bench being passed in?
At this point, this seems like doing so would break backwards compatibility and I'd propose to the cargo team we close this.  There might be ways to make a transition for this (already for other issues, I want to offer ways to control the protocol between cargo and harnesses) but that is moving in the direction of opting into more requirements on harnesses, not less, and any work in this direction would come at a cost of time and complexity.

It's a while since I worked with this, but I think the gist of it is that for harness = false it's a custom program that can have its own command line interface. I think the user should be able to define this interface, or at least the mandatory parts of it (enforced --bench) should be documented.
If any of that is now documented and so on, I don't know now though. :slightly_smiling_face:

or at least the mandatory parts of it (enforced --bench) should be documented.

This sounds a preferable plan to me, though I found it already documented: https://doc.rust-lang.org/nightly/cargo/commands/cargo-bench.html#description

Cargo passes the --bench flag to the test harness to tell it to run only benchmarks.

I think we can add something like ", regardless the test harness is libtest or a custom harness", at the end of the sentence.


I add some code to clean up all test configmap after test

Test：I add some code to clean up all test configmap after test
Signed-off-by: leil24<EMAIL_ADDRESS>

I have updated my title to be consistent with the commit messages, please merge.


fix(parser): add acorn-import-meta plugin

Currently, any usage of import.meta makes the bundler to crash. This PR solves that. This PR does not implement any transformation in the webpack side, instead it just leaves import.meta untouched without crashing.
Relates with: https://github.com/webpack/webpack/issues/6719
What kind of change does this PR introduce?
It's a bug fix.
Did you add tests for your changes?
WIP, asking for feedback before further work!
Does this PR introduce a breaking change?
Nop

Also please accept CLA

@evilebottnawi I am happy to add the tests ASAP, asking for feedback:
Do you think this could get merged into webpack? so dependencies using import.meta does not make webpack to crash
It's a Stage 4 feature, already implemented by all major browsers (Chrome, Safari, Firefox and soon by Edge too). It's also a common feature used by web components libraries like LitElement and Stencil since it allows to reference relative assets to the script.
I can start working in new tests right away!

@manucorporat

Do you think this could get merged into webpack? so dependencies using import.meta does not make webpack to crash

Yes, it is stage 4 so we need fix it in webpack. Need tests and i think we can merge this

@evilebottnawi I might have to close the PR since i just noticed we have to replace import.meta with something else in order to evaluate in jest and run the tests.
I think we could implement a simple transformation of:
import.meta.url

into:
(typeof document === 'undefined' ? new (require('u' + 'rl').URL)('file:' + __filename).href : (document.currentScript && document.currentScript.src || new URL('umd.js', document.baseURI).href))

which should work outside esm in both node and browser.
It's exactly what rollup is doing:
https://github.com/rollup/rollup/pull/2785#issue-266095671
I am lacking knowledge in the webpack codebase to implement this code transformation though. Any advice?

Sounds good

@evilebottnawi I might have to close the PR since i just noticed we have to replace import.meta with something else in order to evaluate in jest and run the tests, and I lack the knowledge in the webpack's codebase to make this non-trivial change, any advice?

I don't see why a test for this feature needs to involve actually running the code at all. Instead, the test can just verify that code containing an import.meta expression is bundled correctly.
I think the initial idea of leaving the statement unmodified (and merely allowing webpack to parse these files) would be more prudent while the specifics of import.meta implementations are still in flux.

/cc @sokra

Fixed by https://github.com/webpack/webpack/pull/11075 (only webpack@5)


Add support for row value expression predicands

The SQL standard and various dialects support row value expressions both as predicands in predicates, as well as expressions in projections. The latter could be interesting too, in a second step, but for now, I'd like to add support for the former, namely:

[x] QOM.RowIsNull and QOM.RowIsNotNull (they're not inverses!):

[x] (a, b) IS NULL is just a IS NULL AND b IS NULL
[x] (a, b) IS NOT NULL is just a IS NOT NULL AND b IS NOT NULL

[x] QOM.RowCondition:

[x] (a, b) = (c, d) is just a = c AND b = d
[x] (a, b) > (c, d) is a > c OR a = c AND b > d

[ ] QOM.RowOverlaps:

[ ] (a, b) OVERLAPS (c, d): To be defined. jOOQ has a convenience OVERLAPS, SQL only supports temporal/interval overlapping

[ ] QOM.RowIsDistinctFrom

[ ] (a, b) IS DISTINCT FROM (b, c): To be investigated if Cypher has a DISTINCT predicate

[ ] QOM.RowInCondition:

[ ] (a, b) IN ((c, d), (e, f)) is just (a, b) = (c, d) OR (a, b) = (e, f) (and then recurse)

[ ] QOM.RowBetweenCondition

[ ] (a, b) BETWEEN [ SYMMETRIC ] (c, d) AND (e, f) is just (a, b) >= (c, d) AND (a, b) <= (e, f) (and then recurse)

[ ] QOM.RowSubqueryCondition

[ ] (a, b) IN (SELECT c, d FROM t) is emulated using EXISTS (SELECT 1 FROM t WHERE (a, b) = (c, d))

This should act as dogfooding catalyst for adding support to those objects int he jOOQ QOM API:

https://github.com/jOOQ/jOOQ/issues/13640

Kamino closed and cloned this issue to neo4j/neo4j-jdbc


git lfs support

https://github.com/git-lfs/git-lfs/blob/main/docs/api/server-discovery.md
it uses tusd to store the actual images. https://github.com/git-lfs/lfs-test-server
This allows git users to store large images..
Its pretty cool...

This is something we are planning to add.

An lfs server would be great. It's a great project, but I can't use it for most of my repos, as they use lfs.

Any update on this?


Safely terminate server RPC loops

Issue: Clean server shutdown is currently not supported. This is because the RPC loops in GrpcWorkerService and GrpcMasterService do not actually exit even after Shutdown() is called.
Fix: This commit adds the mechanism to break out of the RPC loops in both of these classes, modeled after how GrpcEagerServiceImpl does it.

This change is

I signed it!

It has been 14 days with no activity and the awaiting response label was assigned. Is this PR still valid? Assigning the stalled label. Please comment to reassure me that this is still being worked on.

@andrewor14 gentle ping to add test cases.

It has been 28 days that this pull-request has stalled. Please create a new pull-request with the requested changes.


[PROFILE] Highlight changes

Every time a profile is applied, a preference should be stored to say that is untouched and a marker (card color or icon) should highlight it, then for any changes to the profile e.g. new environment, update device, etc ... the preference should be updated.
This should help the user to notice if the profile is backed up properly for example

Hi,
It's just in time!!!
I today think how to copy profile to another phone )))) And I do it with beta version.
Marry Chrismas!!!!
Siva73


Fix the footer

In the footer side add some links like linkedin,github etc also modify the url of the footer...Can you assign this to me under GSSOC24..

I can solve this issue. Please assign me this issue.

I am Praful Nigam. Under GSSOC'24, I would like to work on this issue. Pls assign me this!!

I'd be delighted to contribute to open source through GSSoC 24. Please assign me this task


[TASK] Add 1.5 performance benchmark to performance benchmark WIKI page

What's the task? Please describe
https://github.com/longhorn/longhorn/wiki/Performance-Benchmark
Need to verify v1 and v2, and do the comparison.
Describe the items of the task (DoD, definition of done) you'd like

Please use a task list for items on a separate line with a clickable checkbox https://docs.github.com/en/issues/tracking-your-work-with-issues/about-task-lists

[ ] item 1

Additional context
cc @longhorn/dev-data-plane

cc @longhorn/qa

We only measure the performance on high-level machines such as Equinix m3.small.x86.
As well as the high-level machines, we can benchmark on low- or medium-level machines like AWS c5.xlarge (4 vCPU, 8GiB RAM).

Note: For the low-spec especially no dedicated disk machines, the performance gain is limited. Based on our testing result, the bandwidth of v2 volumes may be worse than v1 volumes:

Similar results are observed on AWS platform. I've added a disk requirement in https://longhorn.io/docs/1.5.0/spdk/prerequisites/#disk.

@derekbit Let's update https://github.com/longhorn/longhorn/wiki/Performance-Benchmark first to include 1.5 performance v1 & v2.

Updated. Thank you.


0.6.3 update console output issue

After installing the 0.6.3 panel update the console for servers will read out the logging of the past +-3 houres 1 line at a time and appending it to the bottom of the console output.
To see actual new command feedback/console logging you need to wait about 10 minuted for the log to finish reading.

That sounds like you have a very, very low throttle limit set, or an insane amount of data is being returned from the daemon, which shouldn't be the case.
/cc @Pterodactyl/support are you able to replicate this at all?

a lot of users have this, including me. whenever i navigate into the console page of any server, logs from 10-15 minutes ago start to spam it until it catches up. asked about this in #support channel of discord a few times too, no one really replied

Can you do me a favor and see if modifying CONSOLE_PUSH_COUNT and CONSOLE_PUSH_FREQ has any effect on the issue you're seeing? Those default to 10 and 200 respectively, which means every 200ms 10 new lines are flushed to the console. Try changing those to push 100 lines every 100ms, or quicker depending on what you think.
You'll need to re-run php artisan config:cache each time you edit them, and they can be defined in the .env file.
Let me know if that makes any difference.

@DaneEveritt I had these values set to the following before changing them to the values you specified.
CONSOLE_PUSH_FREQ=250
CONSOLE_PUSH_COUNT=10
Changed them to
CONSOLE_PUSH_FREQ=200
CONSOLE_PUSH_COUNT=10
Still the same result i'm afraid.

I would just force print the initial log by replacing lines 126-128 in /public/themes/pterodactyl/js/frontend/console.js with
data.split(/\n/g).forEach(function (item) {
  $terminal.append(
    '
' + AnsiUp.ansi_to_html(item + '\u001b[0m') + '
'
  );
});
window.scrollToBottom();

Or better, put that stuff into a function and call it at both spots that need it to avoid duplicated code.
That console thing needs a rewrite after that hotfix anyways though.

@schrej That fixed the issue for now :)

Dane is going through and fixing issues with the console, expect an update for it soon.

closed in 7463bea


Symfony 3.0

:+1:

@smoench do we still need to keep our own fork or could we switch to the original?

@tolry depends on https://github.com/asm89/twig-lint/pull/30 :wink:

this could take months :laughing:

@smoench great - let's merge this, until the master has caught up


Fix construction of (anonymous) BOSH connections and enable stats provider

Some small changes to be able to run successfully jigasi.

Thank you! :)


Some protobuf query methods lack .get option

Problem
While working on https://github.com/osmosis-labs/telescope/pull/296, I decided to use .get's value to extract the path to the query while generating grpc-gateway methods. The problem is, some protobuf files do not have .get, hence, by trying to generate query class for these files, generation fails.
Current design
Currently, the workaround is to construct the path to proto using context and service in case there is no .get option provided and wrap generation of query class in try/catch block in case something goes wrong.
With this design, there is currently one proto file that is not being generated - cosmos/tx/v1beta1/service.proto
Suggested design
@pyramation suggested to drop the try/catch block and generate queries only if there is a .get option provided. However, this implementation ends up NOT generating more than one file (around 6 or 7 lacking). We need to look into combining these designs, to improve dev-UX.
Acceptance
Try/catch block dropped, only one file might not being generated - cosmos/tx/v1beta1/service.proto (ideally would be nice to look into it as well, but afaik this file does not follow the convention of separating txs and queries)

I make a work around for that one. https://github.com/osmosis-labs/telescope/blob/0f9e8857752ca0af4f307ff62a570a522ec8271f/packages/ast/src/clients/rpc/class/grpc-gateway/grpc-gateway.query.ts#L445 maybe we can close this @pysel wdyt ?

makes sense to me!


Add Issue templates

Ive no idea why git keeps showing such a ridiculous merge history - I dont see it locally. Sorry!

Ive no idea why git keeps showing such a ridiculous merge history - I dont see it locally. Sorry!

Must be something wrong somewhere 🤷♂

Oops almost forgot there's a separate repo for GitHub templates at https://github.com/tastyigniter/.github.. Please send the PR there when you can :)


Update landscape.js

Checklist

[ ] npm test passes
[ ] tests and/or benchmarks are included
[ ] commit message follows commit guidelines

Description of change

结束标签少了个/


intLiteral fix

Source: https://github.com/mvdan/garble/pull/74#discussion_r461672649

Broken pull request


Contributors list not getting updated in the readme.md

fix the code in readme.md to show all the contributors.

Hey do you want it to be automatically updated or should i just do it manually?

Making it automatic would be nice

@subhashis2204 Can make it automatic. Please assign it to me.

@RashakDude you are good to go.

This issue has already been handled in #50. Kindly review and merge and close this.


Historical build chart is incomplete. Name of default branch is wrong.

Context
The historical build chart should include the latest build but does not. This can cause confusion. Also, the default branch name is wrong.
Current behaviour (examples provided)

This shows a green tick icon to say that the latest build has passed. This is corroborated by the build page. Note also that the default branch is incorrectly master

The build history for main shows

Expected behaviour
The build chart is meant to provide an overview of the recent builds of the default branch of a repo. It should include the latest build. The default branch should also be correct.
Reported by @tmcgilchrist

It looks like for some repos, the history includes the latest commit, and for some it does not.
This can be seen by visiting https://ci.ocamllabs.io/github/ocurrent and hovering over the last column of the charts. For example, ocaml-ci shows the latest ref as also being the last ref of its chart, but mirage-ci does not. This is consistent with the history page of the default branch of the repo.
Any ideas about what's going on here @maiste @benmandrew?

Thanks @benmandrew - that was useful information but after chasing it around, I think the issue here is a bit different. The build history comes from the ci_build_summary table of the database and so I spent some time simulating the scenario above (same commit on multiple grefs) to see if I could determine if the information was not being written correctly, or not being read correctly.
My conclusion at this point is that the information is being persisted. The same commit appears against multiple grefs. However, the query being used to read history is not picking up the commit on all the grefs.
I'm making progress and expect to have a fix soon. cc/ @maiste and @tmcgilchrist for information.


[feature] : RAG & inline Traces

Description

[SDK] Add inline traces to LLM Apps response
[SDK] Add @route on top of @entrypoint for more endpoints
[Backend] Add some RAG evaluators
[Docs] Improve Docs / examples

Related Issues

AGE-453 : Create basic RAG app with mflix dataset
AGE-454 : Update SDK to allow for multiple routes
AGE-455 : Update SDK to return intermediate outputs inline, optionally
AGE-457 : Display optional inline intermediate outputs in Playground
AGE-458 : Showcase a RAG application along with RAG evaluators
AGE-459 : Add RAG Generator evaluator: Faithfulness
AGE-460 : Add RAG Retriever evaluator: Context Relevancy
AGE-461 : Update evaluation worker to use inline intermediate outputs for RAG evaluators
AGE-466 : Workflow for configuring RAG evaluators (ongoing)
AGE-475 : Fix Playground drawer - Add accordion to all inputs/locals/outputs
AGE-476 : Fix Playground drawer - Add key to list
AGE-477 : Fix Playground typing - handle standard types properly
AGE-479 : Fix latency in Playground
AGE-483 : Fix testsets in Playground with non-string types

Changes

Add RAGAS Faithfulness & Context Relevancy in backend
Add inline trace tree processing and key accessing in backend
Add BaseResponse alongside FuncResponse parsing in backend
Fix flaky evaluators tests to allow for min/max score.
Add @route as an extension to @entrypoint
Add internals to span schemas as Dict and move outputs to Dict
Remove computed latency in @entrypoint
Swap FuncResponse for BaseResponse in @entrypoint
Add standard types to openapi schema in @entrypoint
Add Context Manager to Tracing()
Clean up @instrument with Tracing().Context()
Add internals and improve outputs management in Tracing()
Add inline trace dump in Tracing()
Add span encoder for inline trace dumping in encoder.py [duplicate code from core]
Handle both FuncResponse and BaseResponse in Evaluation Cards (frontend)
Display standard type hints in Playground inputs
Temporarily remove Playground input type validation

since only strings work, even though all standard types should be handled

Add trace drawer in Playground

reuse as much as possible from Observability view, but styling and inputs don't match

Add rag example app to repo
Add Using RAG Evaluators page to docs

QA

smoke

new FE/BE with existing SDK (template)
new FE/BE with existing SDK (custom app)
new FE/BE with new SDK (template)
new FE/BE with new SDK (custom app)

ready for review -- @mmabrouk @aakrem @aybruhm @bekossy @ashrafchowdury

(...) can we have a better approach for the rag tests app_output [?]

Let me trim down the test traces to its minimal expression.

For QA, I think we need to test:

Evaluation (old and new evaluators)
Playground (testing chat application too)
Deployment (deploying an application then calling the api /generate_deployed)

@aybruhm -- Tests now fail due to migration.
@mmabrouk -- I reviewed all your changes, of which 3-4 we can discuss on Slack.
@bekossy @aybruhm -- Ready for QA (in Cloud).
@aakrem -- Hopefully ready for release after all that.

The fix for the failing tests is here.


impossible to reach elasticsearch via VPN or basic auth+ssl

hi,
I'm trying to use docker elasticsearch_exporter 1.0.2 but I'm stuck because I get
msg="failed to fetch and decode cluster health" err="failed to get cluster health from http://<IP_ADDRESS>:9200/_cluster/health
At the first shot I thought it was caused by elasticsearch that is listening on an VPN interface and the docker cannot reach it, so I tried to make the docker requests to the Nginx process running on the same machine where ES is running but I get
msg="failed to fetch and decode cluster health" err="failed to get cluster health from https://user:password@mysite:443/_cluster/health
recap:
2 ways to reach ES:

via VPN, without basic auth, directly to es listening port
via internet contacting nginx reverse proxy with SSL and basic auth

how can I solve this?

Hi @Gappa88,
this doesn't sound like an exporter issue itself. Rather like a general docker/networking issue. Can you exec into the container (it's based on busybox) and check if you can ping/netcat/... the ES IP?

hi @zwopir ,
I logged in to the docker via:
docker exec -it container_id sh
and I successfully ping any local or remote or vpn ips.
I tryed to curl the ES url in order to verify the connection to the server but there is no curl program installed.
Is there any other test to do? I really don't understand why it doesn't work, I'm pretty sure it is my fault but I'm stuck.
Thanks

wget is installed in the container. So you can do a
wget http://<IP>:9200 -O -

thank you @zwopir I finally found the solution. It was caused by a bad firewall rule.


Explain what a static variable does.

The current tutorial just adds in a static variable without explaining what it really does...

I've updated the change, let me know what you think.

Your changes look good, @pavanagrawal123. I'll merge your PR now. The updated article will be live on docs.microsoft.com in the next day or two.


Ensure that blueoak licensed packages are detected

Prerequisites

[X] I have written a descriptive issue title
[X] I have searched existing issues to ensure the issue has not already been raised

Issue
According to @gurgunday tap is using BlueOak License and the license checked does not detect it as no allowed. We have to investigate on why this fails.

Yes. It seems there is a miss if it is a direct dependency?

It's because tap is a dev dependency and the license check in here is only looking at production ones.
It caught it in https://github.com/fastify/fastify-static/actions/runs/6177304982/job/16768155505 because @gurgunday was updating a production dependency.
https://github.com/fastify/workflows/blob/3ae0b4bec5551ee1370bd06c7f67a6c8217156cd/.github/workflows/plugins-ci.yml#L66C26-L66C55

@Uzlopak may no longer be an issue?
https://github.com/openjs-foundation/cross-project-council/issues/1170#issuecomment-1802733531

Everything should be ok in 2/3 months or so. There is 60 days grace time, then the OpenJS Board would issue a statement.

@Fdawgs
In a meeting with @rginn regarding some other OpenJS related topic last week I asked her about blueoak. She also said, that it should resolve positive.

"Should" and "are" are not equivalent. I am keeping an eye on the progress and will keep the task list updated. A major bump in tap after any v5 related release is an internal matter and will not necessitate another new major.

Maybe rename this issue as it was initially meant as a big report about blue oak (dev) dependencies not being found by the workflow but now seems to be about tracking Blue Oak's OSI approval 😌
Or maybe there's another issue tracking the OSI-approval? In that case this issue can be closed in favor of that one.

Blue Oak is OSI approved
https://twitter.com/MylesBorins/status/1752018663698321758

The OpenJS Board of Directors still need to vote to approve the Blue Oak license for OpenJS-hosted projects. The vote will take place this week.


Cannot restart after crash

VSCode Version: 1.20.1
OS Version: OSX 10.13.3

When VSCode crashes (not sure why), afterwards it won't start up, throwing this message:

Another instane of Code is running but not responding

I've sudo killed every code process I can find and still happens. Is there anything I can do to force it to start (some lock or PID file that can be deleted for ex) so I don't have to restart the whole computer?

htop didn't show any processes for vscode after I force killed everything due to the crash.  Using a different user-data-dir did work fine. This was a good hint, I checked the default user data dir and noticed a couple of .sock files. After removing those, I was able to start it up with the default user data dir w/o having to reboot.

I would assume the sock file to get deleted no matter how VS Code exits?

@bpasero Not on macOS or Linux, the files stay around after exit. But if the socket file is there and no one is serving on it, Code should properly delete it and start up.

@joaomoreno that is exactly what seems to happen, someone is still blocking that socket.
The dialog is from https://github.com/Microsoft/vscode/blob/master/src/vs/code/electron-main/main.ts#L189
@astanciu are you 100% sure there is no other code process running?

@bpasero I can confirm no processes containing "Visual Studio" or "code" or "Code" in their name exist.

But if the socket file is there and no one is serving on it, Code should properly delete it and start up.

I am not sure we can distinguish between the file being there but nobody serving and the file being there with someone serving, I always assumed this file would go away when the one that serves ends.

@astanciu can you run "code --verbose" from the command line and attach the output?

I restarted my computer and lost my ability to reproduce crashes ( #45256 ). I will need to put this on pause until it crashes again on it's own (it's been happening around once a day or so). I'll update when I have something.


fix: milestone date issue

closes #8155
Fixes Issue
fix the issue of invalid date string in user milestones data.

Changes proposed

Validate the milestone.date if invalid show an Alert at the top of page
Use red border to highlight the invalid date item

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

sorry but am i missing something here, or should i just wait. Also is it ok if i get started with another issue

Thank you for your contribution 👍 After discussing with the maintainers, we find this a difficult problem to solve and it might cause other challenges. So I will close this issue for now.
Yes please start on another issue, apologies for the confusion


Reduce waiting time while loading multiple images

Loading multiple large images in compare view can take several seconds.
Displaying them one at a time might make the wait time more bearable and transparent.
The amount of time is roughly the same for .nii and .nii.gz (with 15% of the size). Therefore, the time for loading is probably not vscode related but the data loading / preparation in NiiVue. <- Need to investigate this more closely to find out if a speedup is possible

Displaying one at a time works now.
Still trying to find out what takes most time in displaying remote images

Current react version loads first two simultaneously. Probably because of some init delay, then messages with data for first two images arrive together.
=> try to make a singleton image loader


Added function to safely downsize a HyperLogLog sketch

A new function called "downsize" to safely reduce the size of a HyperLogLog sketch. The error rate goes up correspondingly due to loss of information. Based on the ideas presented in: Set Operations On HLLs of Different Sizes and its follow-up HyperLogLog Engineering: Choosing The Right Bits.

Changed the logic to step through the source HLL data, instead of all the possible indices in the reduced HLL. This should make Sparse HLL faster by going through only the entries present in the map, and also make Dense HLL faster with better cache utilization from sequential scan of both source and the reduced HLL array.

Thanks for this contribution! Very helpful.


Clean up/optimize Dockerfile

Reduces Dockerfile image layers
re-organizes ARG and ENV placements

@ChaosCypher Thanks for volunteering to optimize our Dockerfile! 💪
I see that you are proposing at least two separate changes, but having them all proposed together is hard to review. Let's for now focus on reducing image layers, and leave ARG and ENV alone, ok?
Also, once you remove all the changes about ENV and ARG, can you show the difference in build time and image size before and after your changes?

Hi @deivid-rodriguez I pulled it back into draft to undo those exact changes 😄
I will provide the image size differences shortly, and revert the env/arg changes.

If you haven't seen it, dive can be very useful for optimizing layers. The project doesn't seem to be maintained anymore, but I've still found it helpful from time to time.

gentle nudge @ChaosCypher are you still interested in working on this?

@pavera and @jakecoffman are working on redoing our Dockerfile setup so that we can more easily split it on a per-ecosystem basis for efficiency instead of shipping a single monolothic dockerfile.
That will make much of this work outdated, so I'm going to close this.
Feel free to take another crack at it if you're interested after their changes land, or if there are specific improvements you want to break out separately from this PR go for it... I'm sure they're all ears for potential improvements.


[Identity] Move RequestsTransport Import

In an environment without requests the import from azure.identity.aio import EnvironmentCredential throws an ImportError: requests package is not installed.
Moving the RequestsTransports import inside build_pipeline so its imported when needed.

/azp run python - identity - tests

API change check
API changes are not detected in this pull request.

This would fix the immediate problem, but should we even be constructing our own pipeline here? I know we shouldn't for typical SDKs -- @xiangyan99, do you know if Identity is an exception?

bumping this up to see how to move forward with this?


Fix epoch_instant function, remove unreachable!() section

Fixed epoch_instant function, which was the reason of node failure, remove unreachable!() section and return just a current time

@stevenj cool, I will add some additional logging at this place. and will merge this pr


[BUG] Fix footer on mobile devices

Footer on mobile seems to be broken
Todo:

Center text when on mobile
Calculate font-size for footer according to vw (for small screens only)

Current
Expected

Hello, @yashchaudhari008! I would like to work on this.

Assigning to you @mademoiselle-chantal

Thank you, @yashchaudhari008. I'm working on the issue.

Thank you, @yashchaudhari008. I'm working on the issue.

any updates @mademoiselle-chantal

Hello @yashchaudhari008, I see this issue is still open. Can you please assign me? I am a new developer looking for first contributions and this looks like something I can do.


Dealbot not detecting task failures

I have found that many of my controller's "in progress" tasks are actually fast fails on the Lotus CLI.  Moreover, they are stuck in Dealbot's Status==2 with the most recent Log being [].
This leads me to wonder if the Dealbot is unable to detect some types of failures, and therefore never gives up even though the task has failed.
This problem is common for me.  I have reproduced 4 examples of this behavior below.
Example 1
Retrieval task for bafykbzacecbckhdfm7tfu33d2nf3ayak3eabz5jqnbq6fvvmkwz26snywfbak from f023868
When I try it on the CLI I get a <5 minute failure outcome with this output:

$ lotus client retrieve --miner f023868  bafykbzacecbckhdfm7tfu33d2nf3ayak3eabz5jqnbq6fvvmkwz26snywfbak /dev/null
> Recv: 0 B, Paid 0 FIL, ClientEventOpen (DealStatusNew)
> Recv: 0 B, Paid 0 FIL, ClientEventDealProposed (DealStatusWaitForAcceptance)
> Recv: 0 B, Paid 0 FIL, ClientEventDealAccepted (DealStatusAccepted)
> Recv: 0 B, Paid 0 FIL, ClientEventPaymentChannelCreateInitiated (DealStatusPaymentChannelCreating)
> Recv: 0 B, Paid 0 FIL, ClientEventPaymentChannelReady (DealStatusPaymentChannelAllocatingLane)
> Recv: 0 B, Paid 0 FIL, ClientEventLaneAllocated (DealStatusOngoing)
> Recv: 1.047 KiB, Paid 0 FIL, ClientEventBlocksReceived (DealStatusOngoing)
> Recv: 53.06 KiB, Paid 0 FIL, ClientEventBlocksReceived (DealStatusOngoing)
> Recv: 53.06 KiB, Paid 0 FIL, ClientEventPaymentRequested (DealStatusFundsNeeded)
> Recv: 1.052 MiB, Paid 0 FIL, ClientEventBlocksReceived (DealStatusFundsNeeded)
> Recv: 1.052 MiB, Paid 0 FIL, ClientEventSendFunds (DealStatusSendFunds)
> Recv: 1.052 MiB, Paid 0.000000000002097152 FIL, ClientEventPaymentSent (DealStatusOngoing)
> Recv: 1.052 MiB, Paid 0.000000000002097152 FIL, ClientEventPaymentRequested (DealStatusFundsNeeded)
> Recv: 1.052 MiB, Paid 0.000000000002097152 FIL, ClientEventUnknownResponseReceived (DealStatusFailing)
> Recv: 1.052 MiB, Paid 0.000000000002097152 FIL, ClientEventCancelComplete (DealStatusErrored)
> Recv: 0 B, Paid 0 FIL, ClientEventOpen (DealStatusNew)
ERROR: retrieval failed: Retrieve: Retrieval Error: Unexpected deal response status: DealStatusErrored

What /tasks endpoint shows for the same retrieval:

        {
                "UUID": "fccf2845-bab0-4cdd-bdd4-20ab3d5118e8",
                "Status": 2,
                "WorkedBy": "6c259ba9",
                "Stage": "FirstByteReceived",
                "CurrentStageDetails": {
                        "Description": "First byte of data received from miner",
                        "ExpectedDuration": "a few seconds, or several hours when unsealing",
                        "Logs": []
                },
                "PastStageDetails": [
                        {
                                "Description": "Miner is online",
                                "ExpectedDuration": "a few seconds",
                                "Logs": [
                                        {
                                                "Log": "Tipset successfully fetched",
                                                "UpdatedAt":<PHONE_NUMBER>472793116
                                        },
                                        {
                                                "Log": "Miner Info successfully fetched",
                                                "UpdatedAt":<PHONE_NUMBER>504882089
                                        },
                                        {
                                                "Log": "Miner address validated",
                                                "UpdatedAt":<PHONE_NUMBER>518991488
                                        },
                                        {
                                                "Log": "Connected to miner",
                                                "UpdatedAt":<PHONE_NUMBER>623349552
                                        }
                                ],
                                "UpdatedAt":<PHONE_NUMBER>623349552
                        },
                        {
                                "Description": "Miner responds to query ask",
                                "ExpectedDuration": "a few seconds",
                                "Logs": [
                                        {
                                                "Log": "Miner Offer Received",
                                                "UpdatedAt":<PHONE_NUMBER>674739455
                                        }
                                ],
                                "UpdatedAt":<PHONE_NUMBER>674739455
                        },
                        {
                                "Description": "Send proposal to miner",
                                "ExpectedDuration": "",
                                "Logs": [
                                        {
                                                "Log": "deal sent to miner",
                                                "UpdatedAt":<PHONE_NUMBER>687565263
                                        }
                                ],
                                "UpdatedAt":<PHONE_NUMBER>687565263
                        },
                        {
                                "Description": "Miner accepts deal",
                                "ExpectedDuration": "a few seconds",
                                "Logs": []
                        }
                ],
                "StartedAt":<PHONE_NUMBER>501184822,
                "RunCount": 1,
                "RetrievalTask": {
                        "Miner": "f023868",
                        "PayloadCID": "bafykbzacecbckhdfm7tfu33d2nf3ayak3eabz5jqnbq6fvvmkwz26snywfbak",
                        "CARExport": false
                }
        },

Miner seems to wait forever in Status==2.
Example 2
Trying to retrieve bafykbzacedxsme5frpjpvta3ah3w7vqmbz6nfgrplrgtl2mt5tf43zguxk6fe from f023861
Fast failure on CLI:

$ lotus client retrieve --miner f023861 bafykbzacedxsme5frpjpvta3ah3w7vqmbz6nfgrplrgtl2mt5tf43zguxk6fe /dev/null
> Recv: 0 B, Paid 0 FIL, ClientEventOpen (DealStatusNew)
> Recv: 0 B, Paid 0 FIL, ClientEventDealProposed (DealStatusWaitForAcceptance)
> Recv: 0 B, Paid 0 FIL, ClientEventDealAccepted (DealStatusAccepted)
> Recv: 0 B, Paid 0 FIL, ClientEventPaymentChannelCreateInitiated (DealStatusPaymentChannelCreating)
> Recv: 0 B, Paid 0 FIL, ClientEventPaymentChannelReady (DealStatusPaymentChannelAllocatingLane)
> Recv: 0 B, Paid 0 FIL, ClientEventLaneAllocated (DealStatusOngoing)
> Recv: 960 B, Paid 0 FIL, ClientEventBlocksReceived (DealStatusOngoing)
> Recv: 52.95 KiB, Paid 0 FIL, ClientEventBlocksReceived (DealStatusOngoing)
> Recv: 52.95 KiB, Paid 0 FIL, ClientEventPaymentRequested (DealStatusFundsNeeded)
> Recv: 1.052 MiB, Paid 0 FIL, ClientEventBlocksReceived (DealStatusFundsNeeded)
> Recv: 1.052 MiB, Paid 0 FIL, ClientEventSendFunds (DealStatusSendFunds)
> Recv: 1.052 MiB, Paid 0.000000000002097152 FIL, ClientEventPaymentSent (DealStatusOngoing)
> Recv: 1.052 MiB, Paid 0.000000000002097152 FIL, ClientEventPaymentRequested (DealStatusFundsNeeded)
> Recv: 1.052 MiB, Paid 0.000000000002097152 FIL, ClientEventUnknownResponseReceived (DealStatusFailing)
> Recv: 1.052 MiB, Paid 0.000000000002097152 FIL, ClientEventCancelComplete (DealStatusErrored)
> Recv: 0 B, Paid 0 FIL, ClientEventOpen (DealStatusNew)
ERROR: retrieval failed: Retrieve: Retrieval Error: Unexpected deal response status: DealStatusErrored

What /tasks endpoint shows:

        {
                "UUID": "68a0bc14-9dec-4332-bedd-aa9732b62c65",
                "Status": 2,
                "WorkedBy": "6c259ba9",
                "Stage": "FirstByteReceived",
                "CurrentStageDetails": {
                        "Description": "First byte of data received from miner",
                        "ExpectedDuration": "a few seconds, or several hours when unsealing",
                        "Logs": []
                },
                "PastStageDetails": [
                        {
                                "Description": "Miner is online",
                                "ExpectedDuration": "a few seconds",
                                "Logs": [
                                        {
                                                "Log": "Tipset successfully fetched",
                                                "UpdatedAt":<PHONE_NUMBER>387958001
                                        },
                                        {
                                                "Log": "Miner Info successfully fetched",
                                                "UpdatedAt":<PHONE_NUMBER>402519702
                                        },
                                        {
                                                "Log": "Miner address validated",
                                                "UpdatedAt":<PHONE_NUMBER>422614097
                                        },
                                        {
                                                "Log": "Connected to miner",
                                                "UpdatedAt":<PHONE_NUMBER>527582838
                                        }
                                ],
                                "UpdatedAt":<PHONE_NUMBER>527582838
                        },
                        {
                                "Description": "Miner responds to query ask",
                                "ExpectedDuration": "a few seconds",
                                "Logs": [
                                        {
                                                "Log": "Miner Offer Received",
                                                "UpdatedAt":<PHONE_NUMBER>590381478
                                        }
                                ],
                                "UpdatedAt":<PHONE_NUMBER>590381478
                        },
                        {
                                "Description": "Send proposal to miner",
                                "ExpectedDuration": "",
                                "Logs": [
                                        {
                                                "Log": "deal sent to miner",
                                                "UpdatedAt":<PHONE_NUMBER>604799120
                                        }
                                ],
                                "UpdatedAt":<PHONE_NUMBER>604799120
                        },
                        {
                                "Description": "Miner accepts deal",
                                "ExpectedDuration": "a few seconds",
                                "Logs": []
                        }
                ],
                "StartedAt":<PHONE_NUMBER>368890336,
                "RunCount": 1,
                "RetrievalTask": {
                        "Miner": "f023861",
                        "PayloadCID": "bafykbzacedxsme5frpjpvta3ah3w7vqmbz6nfgrplrgtl2mt5tf43zguxk6fe",
                        "CARExport": false
                }
        },

Example 3
Trying to retrieve bafykbzacebpmipdxeb7ylfophje7n3brzr7ziu7aln2qkdliendgrxwp7fl3c from f023871
Fast fail on CLI:

$ lotus client retrieve --miner f023871 bafykbzacebpmipdxeb7ylfophje7n3brzr7ziu7aln2qkdliendgrxwp7fl3c  /dev/null
> Recv: 0 B, Paid 0 FIL, ClientEventOpen (DealStatusNew)
> Recv: 0 B, Paid 0 FIL, ClientEventDealProposed (DealStatusWaitForAcceptance)
> Recv: 0 B, Paid 0 FIL, ClientEventDealAccepted (DealStatusAccepted)
> Recv: 0 B, Paid 0 FIL, ClientEventPaymentChannelCreateInitiated (DealStatusPaymentChannelCreating)
> Recv: 0 B, Paid 0 FIL, ClientEventPaymentChannelReady (DealStatusPaymentChannelAllocatingLane)
> Recv: 0 B, Paid 0 FIL, ClientEventLaneAllocated (DealStatusOngoing)
> Recv: 962 B, Paid 0 FIL, ClientEventBlocksReceived (DealStatusOngoing)
> Recv: 52.95 KiB, Paid 0 FIL, ClientEventBlocksReceived (DealStatusOngoing)
> Recv: 52.95 KiB, Paid 0 FIL, ClientEventPaymentRequested (DealStatusFundsNeeded)
> Recv: 1.052 MiB, Paid 0 FIL, ClientEventBlocksReceived (DealStatusFundsNeeded)
> Recv: 1.052 MiB, Paid 0 FIL, ClientEventSendFunds (DealStatusSendFunds)
> Recv: 1.052 MiB, Paid 0.000000000002097152 FIL, ClientEventPaymentSent (DealStatusOngoing)
> Recv: 1.052 MiB, Paid 0.000000000002097152 FIL, ClientEventPaymentRequested (DealStatusFundsNeeded)
> Recv: 1.052 MiB, Paid 0.000000000002097152 FIL, ClientEventUnknownResponseReceived (DealStatusFailing)
> Recv: 1.052 MiB, Paid 0.000000000002097152 FIL, ClientEventCancelComplete (DealStatusErrored)
> Recv: 0 B, Paid 0 FIL, ClientEventOpen (DealStatusNew)
ERROR: retrieval failed: Retrieve: Retrieval Error: Unexpected deal response status: DealStatusErrored

What /tasks shows:

        {
                "UUID": "99b021b2-f434-40ba-8bfa-617294f35f1a",
                "Status": 2,
                "WorkedBy": "6c259ba9",
                "Stage": "FirstByteReceived",
                "CurrentStageDetails": {
                        "Description": "First byte of data received from miner",
                        "ExpectedDuration": "a few seconds, or several hours when unsealing",
                        "Logs": []
                },
                "PastStageDetails": [
                        {
                                "Description": "Miner is online",
                                "ExpectedDuration": "a few seconds",
                                "Logs": [
                                        {
                                                "Log": "Tipset successfully fetched",
                                                "UpdatedAt":<PHONE_NUMBER>397905390
                                        },
                                        {
                                                "Log": "Miner Info successfully fetched",
                                                "UpdatedAt":<PHONE_NUMBER>418129877
                                        },
                                        {
                                                "Log": "Miner address validated",
                                                "UpdatedAt":<PHONE_NUMBER>442054420
                                        },
                                        {
                                                "Log": "Connected to miner",
                                                "UpdatedAt":<PHONE_NUMBER>592889453
                                        }
                                ],
                                "UpdatedAt":<PHONE_NUMBER>592889453
                        },
                        {
                                "Description": "Miner responds to query ask",
                                "ExpectedDuration": "a few seconds",
                                "Logs": [
                                        {
                                                "Log": "Miner Offer Received",
                                                "UpdatedAt":<PHONE_NUMBER>642600090
                                        }
                                ],
                                "UpdatedAt":<PHONE_NUMBER>642600090
                        },
                        {
                                "Description": "Send proposal to miner",
                                "ExpectedDuration": "",
                                "Logs": [
                                        {
                                                "Log": "deal sent to miner",
                                                "UpdatedAt":<PHONE_NUMBER>654350950
                                        }
                                ],
                                "UpdatedAt":<PHONE_NUMBER>654350950
                        },
                        {
                                "Description": "Miner accepts deal",
                                "ExpectedDuration": "a few seconds",
                                "Logs": []
                        }
                ],
                "StartedAt":<PHONE_NUMBER>375730804,
                "RunCount": 1,
                "RetrievalTask": {
                        "Miner": "f023871",
                        "PayloadCID": "bafykbzacebpmipdxeb7ylfophje7n3brzr7ziu7aln2qkdliendgrxwp7fl3c",
                        "CARExport": false
                }
        },

Example 4
Trying to retrieve bafykbzaceddea3nlgwfnn3npf62z3ny4vmlrrj23kdywfornxlwn65tel3liq from f024136
Fast fail on CLI:

$ lotus client retrieve --miner f024136 bafykbzaceddea3nlgwfnn3npf62z3ny4vmlrrj23kdywfornxlwn65tel3liq  /dev/null
> Recv: 0 B, Paid 0 FIL, ClientEventOpen (DealStatusNew)
> Recv: 0 B, Paid 0 FIL, ClientEventDealProposed (DealStatusWaitForAcceptance)
> Recv: 0 B, Paid 0 FIL, ClientEventDealAccepted (DealStatusAccepted)
> Recv: 0 B, Paid 0 FIL, ClientEventPaymentChannelCreateInitiated (DealStatusPaymentChannelCreating)
> Recv: 0 B, Paid 0 FIL, ClientEventPaymentChannelReady (DealStatusPaymentChannelAllocatingLane)
> Recv: 0 B, Paid 0 FIL, ClientEventLaneAllocated (DealStatusOngoing)
> Recv: 1.049 KiB, Paid 0 FIL, ClientEventBlocksReceived (DealStatusOngoing)
> Recv: 53.06 KiB, Paid 0 FIL, ClientEventBlocksReceived (DealStatusOngoing)
> Recv: 53.06 KiB, Paid 0 FIL, ClientEventPaymentRequested (DealStatusFundsNeeded)
> Recv: 1.052 MiB, Paid 0 FIL, ClientEventBlocksReceived (DealStatusFundsNeeded)
> Recv: 1.052 MiB, Paid 0 FIL, ClientEventSendFunds (DealStatusSendFunds)
> Recv: 1.052 MiB, Paid 0.000000000002097152 FIL, ClientEventPaymentSent (DealStatusOngoing)
> Recv: 1.052 MiB, Paid 0.000000000002097152 FIL, ClientEventPaymentRequested (DealStatusFundsNeeded)
> Recv: 1.052 MiB, Paid 0.000000000002097152 FIL, ClientEventUnknownResponseReceived (DealStatusFailing)
> Recv: 1.052 MiB, Paid 0.000000000002097152 FIL, ClientEventCancelComplete (DealStatusErrored)
> Recv: 0 B, Paid 0 FIL, ClientEventOpen (DealStatusNew)
ERROR: retrieval failed: Retrieve: Retrieval Error: Unexpected deal response status: DealStatusErrored

/tasks endpoint:

        {
                "UUID": "873ec235-6425-4fab-b4af-3d691de80297",
                "Status": 2,
                "WorkedBy": "6c259ba9",
                "Stage": "FirstByteReceived",
                "CurrentStageDetails": {
                        "Description": "First byte of data received from miner",
                        "ExpectedDuration": "a few seconds, or several hours when unsealing",
                        "Logs": []
                },
                "PastStageDetails": [
                        {
                                "Description": "Miner is online",
                                "ExpectedDuration": "a few seconds",
                                "Logs": [
                                        {
                                                "Log": "Tipset successfully fetched",
                                                "UpdatedAt":<PHONE_NUMBER>413038636
                                        },
                                        {
                                                "Log": "Miner Info successfully fetched",
                                                "UpdatedAt":<PHONE_NUMBER>438431872
                                        },
                                        {
                                                "Log": "Miner address validated",
                                                "UpdatedAt":<PHONE_NUMBER>466823138
                                        },
                                        {
                                                "Log": "Connected to miner",
                                                "UpdatedAt":<PHONE_NUMBER>575160249
                                        }
                                ],
                                "UpdatedAt":<PHONE_NUMBER>575160249
                        },
                        {
                                "Description": "Miner responds to query ask",
                                "ExpectedDuration": "a few seconds",
                                "Logs": [
                                        {
                                                "Log": "Miner Offer Received",
                                                "UpdatedAt":<PHONE_NUMBER>609506130
                                        }
                                ],
                                "UpdatedAt":<PHONE_NUMBER>609506130
                        },
                        {
                                "Description": "Send proposal to miner",
                                "ExpectedDuration": "",
                                "Logs": [
                                        {
                                                "Log": "deal sent to miner",
                                                "UpdatedAt":<PHONE_NUMBER>634306872
                                        }
                                ],
                                "UpdatedAt":<PHONE_NUMBER>634306872
                        },
                        {
                                "Description": "Miner accepts deal",
                                "ExpectedDuration": "a few seconds",
                                "Logs": []
                        }
                ],
                "StartedAt":<PHONE_NUMBER>386849567,
                "RunCount": 1,
                "RetrievalTask": {
                        "Miner": "f024136",
                        "PayloadCID": "bafykbzaceddea3nlgwfnn3npf62z3ny4vmlrrj23kdywfornxlwn65tel3liq",
                        "CARExport": false
                }
        },

should be fixed when bot is running with timeouts set from #147


Opening a file on a new document brings up a confirm dialog

At least check whether the document is modified or whether it contains no objects before confirming.
@cjquines can we also do the iterative check again?

okay, sure, we can check if it's modified or if there's no objects, but like, anything more and it probably should have the check

I will handle this after #65


docs: Nuke .travis.yml and make a doc from it

@ifcaro rejected the idea of enabling TravisCI

Signed-off-by: Caio Oliveira<EMAIL_ADDRESS>Pull Request checklist
Note: these are not necessarily requirements

[ ] I reformatted the code with clang-format
[ ] I checked to make sure my submission worked
[x] I am the author of submission or have permission from the original author
[ ] Requires update of the PS2SDK
[ ] Requires update of the gsKit
[x] Others (not tested)

Pull Request description
It make a global doc to building OPL under Ubuntu 14.04, not tested, anyway anyone better can improve it.

Send as resquest to merge to @rickgaiser, since I don't have voice (open source don't mean open community)

@Caio99BR I'm sorry you feel this way, but I cannot help you. Accepting your request would automatically mean I have become the maintainer of a fork. And I do not want OPL development to become fragmented.
@ the maintainers : who are the maintainers and why has no-one responded? Is @ifcaro still active?


Response not getting right status code

I was getting unexpected results for response.Ok and when I debugged I see Ok == false and am not sure why. The request is returning 201 Created so that should be good. I see Status == Created and StatusText == "Created" so I'm wondering if something is wrong here.

Good catch!
We'll get that fixed in the upcoming version.


29K+ problems detected when using paket: generate_load_scripts

Describe the bug
I use generate_load_scripts: true in my paket.dependencies to import netstandard in my fsx files.
#r "netstandard"
#load @"../../.paket/load/netstandard2.0/main.group.fsx"

Ionide type checks the whole .paket/load directory for errors and finds 29K+ problems. The folder is gitignored and i tried to add .paket to the exluded project directories, but it had no effect.
    "FSharp.excludeProjectDirectories": [
        ".git",
        "paket-files",
        ".fable",
        "node_modules",
        ".paket"
    ]

The whole typechecking takes a long time and until the process is finished no intellisense shows up.
To Reproduce
Steps to reproduce the behaviour:

Install dependencies with paket
Use generate_load_scripts: true  to create the .paket/load directory

Screenshots

Environment (please complete the following information):

OS: Windows 10 Enterprise 1709
Ionide version: 1.34.0
VSCode version: 1.34.0
dotnet SDK version: 2.2.300
mono / .Net Framework version:  4.6.1

While ionide might be affected for sure, In your screenshot the errors are from .csx files that are handled by Omnisharp, not ionide.

Hi @vbfox, thanks for pointing that out! I changed the description.

David I think what vbfox is highlighting is that you would need to raise this issue on a different repository i.e. it is not something within Ionide's control. I doubt it will be accepted as an Omnisharp issue either unfortunately, because any Omnisharp doesn't formally support F#.
I would guess that your issue can be closed and that you'll just need to keep an eye on the progress of this one: https://github.com/OmniSharp/omnisharp-vscode/issues/1694 or investigate other Omnisharp exclude settings.

@drk-mtr thanks for the explanation! I didn't know about Omnisharp, so i will close this in favor of the referenced issue!


Remove self from widgets that don't need referencing elsewhere in application.

Should make the code a bit more readable so it's obvious what widgets will be dynamically changing and what is static.

Implemented by #13


Lattice rescoring in *_decode.py

Hello, I trained transformer acoustic model on my dataset. I put existing files to data/lang_nosp. Then all processes are same with ctc_att_transformer_train.py. As a result, output of ctc_att_transformer_decode.py gives WER %100 because hyps are all empty. When I check lattices, they are similar to text. For example
Transcription -> berry
Output of decoding -> beerrll
or
Transcription -> thank you
Output of decoding -> tennkkyyhav
In detail, get_texts gives empty hyps.
I think that problem is converting phones to words. At this point, problem might be scoring lattices. Is there any script for rescoring lattices according to a language model?
or what can be the problem?
thanks in advance.

Not sure what you put in lang_nosp, something from an existing Kaldi setup?
I'm afraid we're not yet at the stage where we can easily support people trying to do things like this.
Eventually we'll reorganize the scripts and make things much easier (probably in the 'Icefall' iteration of this
project) but for now things are going to be a little hard to work with.

Thank you for information. Yes, files were taken from an existing Kaldi setup, I am still trying to find the glitch in my setup. It might be files in lang_nosp. I will update the issue if I find something new.


Support provider options in NodeCreateRequest

Provider options are present in the NodeCluster struct, but not in the NodeCreateRequest even though it is exposed in the API. After some playing around, adding a Provider_options field with the type ProviderOption does will cause the API to return "400 BAD REQUEST". By setting the NodeCreateRequest struct to require a pointer of a ProviderOption struct, the API allows the request to go through:
Using the ProviderOption struct and not setting it in the request:
type NodeCreateRequest struct {
  Disk             int             `json:"disk,omitempty"`
  Name             string          `json:"name,omitempty"`
  NodeType         string          `json:"node_type,omitempty"`
  Provider_options ProviderOption `json:"provider_options,omitempty"`
  Region           string          `json:"region,omitempty"`
  Target_num_nodes int             `json:"target_num_nodes,omitempty"`
  Tags             []NodeTag       `json:"tags,omitempty"`
}

Will result in a JSON payload with the VPC and IAM options as empty hashes:
{
    "name": "test",
    "node_type": "/api/infra/v1/nodetype/aws/t2.micro/",
    "provider_options": {
        "iam": {},
        "vpc": {}
    },
    "region": "/api/infra/v1/region/aws/us-east-1/"
}

Instead, using a pointer and not setting it in the request:
type NodeCreateRequest struct {
  Disk             int             `json:"disk,omitempty"`
  Name             string          `json:"name,omitempty"`
  NodeType         string          `json:"node_type,omitempty"`
  Provider_options *ProviderOption `json:"provider_options,omitempty"`
  Region           string          `json:"region,omitempty"`
  Target_num_nodes int             `json:"target_num_nodes,omitempty"`
  Tags             []NodeTag       `json:"tags,omitempty"`
}

Will result in the following, working request:
{
    "name": "foobar-test-terraform",
    "node_type": "/api/infra/v1/nodetype/aws/t2.micro/",
    "region": "/api/infra/v1/region/aws/us-east-1/"
}

@nextrevision I was messing with that earlier with some frustration.

Yeah, nested structs and don't play well with "omitempty".


Remove extraneous console.log in utils fuzzy search function

Removes a console.log that leads to an absurd amount of logging when searching.

dupe of https://github.com/HubSpot/Singularity/pull/1083

You are right. Not sure why I didn't see that


Add map-to-output --list-monitors

GNOME47 no longer lists the connector names though that one is likely to be most commonly used to map to an output since it's the only constant one (who knows their monitors product name or serial after all...)
Let's add a --list-monitors option to list the current ones, and list them on failure too while we're there.
cc @deevad

A great! Thank you for the new option. :+1:


search all pids and children for process checks

cgroup.procs only displays one layer, sometimes containers will have
child cgroups that we want to check.  This change allows us to switch
to a check that checks all descendants of a parent as well.
We do not use the lxc module here for two reasons.  One, it is built
only for python3, and two, it is not available in pypi (and is not
fun to build out of tree).
Connected: https://github.com/rcbops/u-suk-dev/issues/1001
(cherry picked from commit b8468b8695cd474483541cf06a33404a01419312)
Signed-off-by: Matthew Thode<EMAIL_ADDRESS>

xenial+newton+maas job has been triggered for this PR: http://jenkins.propter.net/job/JJB-RPC-AIO_newton-xenial-periodic/
Blocking this PR until it passes.

recheck_ceph

xenial+newton+maas job passed. Once the ceph jobs passes this can merge.

recheck_ceph


Multiplayer API now respects allow_object_decoding

Also adds doc about allow_object_decoding in PacketPeer.
Limited fix for #27395 dedicated to 3.0 branch.
bytes2var, base64_to_variant and File.get_var are still unsafe, but the high level multiplayer API is now safe.
People using functions that are still unsafe should update to 3.1 (where those functions are safe and have extra parameter to make them unsafe) or get the raw bytes, check that it's not an object type (first four bytes != 17) and only then use var2bytes.
This is done to avoid breaking compatibility as much as possible, especially with GDNative plugins.

Yeah, not really a cherrypick, just added the label to notify this is for 3.0.

Thanks!


Remove refresh organization endpoint

Is your feature request related to a problem? Please describe.
UI will no longer be invoking refresh organization endpoint, see dockstore/dockstore-ui2#987; we should remove the refresh organization API endpoint
Describe the solution you'd like
Remove the endpoint to refresh an organization.
Additional context
See #3522
┆Issue is synchronized with this Jira Story
┆Issue Type: Story
┆Sprint: Sprint 37 Lobster
┆Issue Number: DOCK-1392

It's removed


Cannot read property 'getTracks' of undefined

What kind of browser/os are using?

I have the same issue. tested in Brave and Chrome

You jsfiddle only seems to work in Firefox as well.

@grishkovelli  - confirmed on my macOS using Safari 11 in High Sierra, which doesn't work. Safari is set to ask for microphone access but it never gets to that. i set it to allow from JSFiddle and it still doesn't work. might be a WebAudio issue with Safari in my case but not sure. other WebAudio sites with audio recorder demos do work.

JSFiddle has an old version, anyway I'll check it. Try to pull master

same issue

upgrade to https save my day

I have the same issue.  In chorme(version:75.0.3770.100).

how to solve this error ...

hey @jiwan-gharti are you using the component in an http page? if so you should upgrade your site to https instead, more details camera and microphone will require an https connection to work. Access from insecure http will cease to work

浏览器输入 chrome://flags/#unsafely-treat-insecure-origin-as-secure ，把他开启之后，然后再输入框中键入你的开发地址，最后重启浏览器就可以了


fix: disable completion

This PR disables completion. It is too invasive. The LSP needs to be fixed first.

@bobbyiliev Headsup: The PR is about commenting two lines, so I will merge it to do the release!


Syntax highlighting for variable using a keyword

When I define a variable that uses a keyword as name, like this:
interface ITest {
  a: number;
  b: number;
  number: number;       // Weird highlighting.
  string: string;       // Weird highlighting.
}

var a = <ITest>{
  a: 100,
  b: 100,
  number: 123,          // Weird highlighting.
  string: 'Hello world' // Weird highlighting.
}

The variable name will be highlighted as if it is a keyword. It would be nice if it would remain the normal color.

Duplicate of : https://github.com/TypeStrong/atom-typescript/issues/71


Integration: Coqui AI

It would be great to see an integration with TTS by @coqui-ai, similar to bark by @suno-ai
For inspiration, check out XTTS space on HuggingFace

They have chosen this license: https://coqui.ai/cpml which makes it unreasonable to use xtts in open source projects. I have not investigated the latest version of XTTS but the older version was an improvement of Tortoise.

Closing this issue. If they change the license for XTTS or modify CPML.


Traversal Lens

There should be Traversal Lens implementation to effectively traverse arrays.
ref: https://hackage.haskell.org/package/lens-4.16.1/docs/Control-Lens-Traversal.html
I wonder if the method name should be .traverse or .map.

It should be traverse because it does more than map: It accumulates effects.
Here specialized for List and returning Applicative:
map ::      Applicative f => (a -> f b) -> [a] -> [f b]
traverse :: Applicative f => (a -> f b) -> [a] -> f [b]


Fix broken roles in  directus_config.js

Update default config (had issue with using the examples), align it with directus_config.ts

If you don't need to include it you can just add that in your config, however I don't feel it fits most use cases.


Flake8

Coverage remained the same at 90.977% when pulling 3b944e1c37425432104740f5fe6fd4a3e9d8fc97 on kpolimis:flake8 into e10edf1552eb039ebf769ff73bb10ac2e2533449 on uwescience:master.

Thanks!


security: basic improvements

Audit service, sudo to be exec only, removing default packages, and configure openssh for only SSH seem good ideas to take from https://xeiaso.net/blog/paranoid-nixos-2021-07-18

Closed by #32.


webhooks from gitlab freedesktop cannot be ingested

[Wed Oct 12 13:59:07.653036 2022] [wsgi:error] [pid 360:tid 372] [remote <IP_ADDRESS>:54220] 2022-10-12 13:59:07.652 webhooks.py INFO X-Gitlab-Token not in request.headers
[Wed Oct 12 13:59:07.660821 2022] [wsgi:error] [pid 360:tid 372] [remote <IP_ADDRESS>:54220] Authentication for url 'https://gitlab.freedesktop.org/polkit/polkit' is missing in the config.
[Wed Oct 12 13:59:07.662055 2022] [wsgi:error] [pid 360:tid 372] [remote <IP_ADDRESS>:54220] 2022-10-12 13:59:07.661 app.py ERROR Exception on /api/webhooks/gitlab [POST]
[Wed Oct 12 13:59:07.662068 2022] [wsgi:error] [pid 360:tid 372] [remote <IP_ADDRESS>:54220] Traceback (most recent call last):
[Wed Oct 12 13:59:07.662071 2022] [wsgi:error] [pid 360:tid 372] [remote <IP_ADDRESS>:54220] File "/usr/lib/python3.10/site-packages/packit/config/config.py", line 217, in _get_project
[Wed Oct 12 13:59:07.662074 2022] [wsgi:error] [pid 360:tid 372] [remote <IP_ADDRESS>:54220] project = get_project(
[Wed Oct 12 13:59:07.662077 2022] [wsgi:error] [pid 360:tid 372] [remote <IP_ADDRESS>:54220] File "/usr/lib/python3.10/site-packages/ogr/factory.py", line 103, in get_project
[Wed Oct 12 13:59:07.662079 2022] [wsgi:error] [pid 360:tid 372] [remote <IP_ADDRESS>:54220] raise OgrException(
[Wed Oct 12 13:59:07.662082 2022] [wsgi:error] [pid 360:tid 372] [remote <IP_ADDRESS>:54220] ogr.exceptions.OgrException: Instance of type GitlabService matching instance url 'https://gitlab.freedesktop.org/polkit/polkit' was not provided.
[Wed Oct 12 13:59:07.662084 2022] [wsgi:error] [pid 360:tid 372] [remote <IP_ADDRESS>:54220]
[Wed Oct 12 13:59:07.662087 2022] [wsgi:error] [pid 360:tid 372] [remote <IP_ADDRESS>:54220] During handling of the above exception, another exception occurred:
[Wed Oct 12 13:59:07.662089 2022] [wsgi:error] [pid 360:tid 372] [remote <IP_ADDRESS>:54220]
[Wed Oct 12 13:59:07.662091 2022] [wsgi:error] [pid 360:tid 372] [remote <IP_ADDRESS>:54220] Traceback (most recent call last):
[Wed Oct 12 13:59:07.662094 2022] [wsgi:error] [pid 360:tid 372] [remote <IP_ADDRESS>:54220] File "/usr/lib/python3.10/site-packages/flask/app.py", line 1513, in full_dispatch_request
[Wed Oct 12 13:59:07.662096 2022] [wsgi:error] [pid 360:tid 372] [remote <IP_ADDRESS>:54220] rv = self.dispatch_request()
[Wed Oct 12 13:59:07.662099 2022] [wsgi:error] [pid 360:tid 372] [remote <IP_ADDRESS>:54220] File "/usr/lib/python3.10/site-packages/flask/app.py", line 1499, in dispatch_request
[Wed Oct 12 13:59:07.662101 2022] [wsgi:error] [pid 360:tid 372] [remote <IP_ADDRESS>:54220] return self.ensure_sync(self.view_functions[rule.endpoint])(**req.view_args)
[Wed Oct 12 13:59:07.662103 2022] [wsgi:error] [pid 360:tid 372] [remote <IP_ADDRESS>:54220] File "/usr/lib/python3.10/site-packages/flask_restx/api.py", line 403, in wrapper
[Wed Oct 12 13:59:07.662106 2022] [wsgi:error] [pid 360:tid 372] [remote <IP_ADDRESS>:54220] resp = resource(*args, **kwargs)
[Wed Oct 12 13:59:07.662108 2022] [wsgi:error] [pid 360:tid 372] [remote <IP_ADDRESS>:54220] File "/usr/lib/python3.10/site-packages/flask/views.py", line 83, in view
[Wed Oct 12 13:59:07.662110 2022] [wsgi:error] [pid 360:tid 372] [remote <IP_ADDRESS>:54220] return self.dispatch_request(*args, **kwargs)
[Wed Oct 12 13:59:07.662113 2022] [wsgi:error] [pid 360:tid 372] [remote <IP_ADDRESS>:54220] File "/usr/lib/python3.10/site-packages/flask_restx/resource.py", line 49, in dispatch_request
[Wed Oct 12 13:59:07.662115 2022] [wsgi:error] [pid 360:tid 372] [remote <IP_ADDRESS>:54220] resp = meth(*args, **kwargs)
[Wed Oct 12 13:59:07.662118 2022] [wsgi:error] [pid 360:tid 372] [remote <IP_ADDRESS>:54220] File "/src/packit_service/service/api/webhooks.py", line 186, in post
[Wed Oct 12 13:59:07.662120 2022] [wsgi:error] [pid 360:tid 372] [remote <IP_ADDRESS>:54220] self.validate_token()
[Wed Oct 12 13:59:07.662122 2022] [wsgi:error] [pid 360:tid 372] [remote <IP_ADDRESS>:54220] File "/src/packit_service/service/api/webhooks.py", line 271, in validate_token
[Wed Oct 12 13:59:07.662125 2022] [wsgi:error] [pid 360:tid 372] [remote <IP_ADDRESS>:54220] self.create_confidential_issue_with_token()
[Wed Oct 12 13:59:07.662127 2022] [wsgi:error] [pid 360:tid 372] [remote <IP_ADDRESS>:54220] File "/src/packit_service/service/api/webhooks.py", line 230, in create_confidential_issue_with_token
[Wed Oct 12 13:59:07.662130 2022] [wsgi:error] [pid 360:tid 372] [remote <IP_ADDRESS>:54220] packit_user = project.service.user.get_username()
[Wed Oct 12 13:59:07.662132 2022] [wsgi:error] [pid 360:tid 372] [remote <IP_ADDRESS>:54220] File "/usr/lib/python3.10/site-packages/packit/config/config.py", line 223, in _get_project
[Wed Oct 12 13:59:07.662135 2022] [wsgi:error] [pid 360:tid 372] [remote <IP_ADDRESS>:54220] raise PackitConfigException(msg, ex)
[Wed Oct 12 13:59:07.662138 2022] [wsgi:error] [pid 360:tid 372] [remote <IP_ADDRESS>:54220] packit.exceptions.PackitConfigException: ("Authentication for url 'https://gitlab.freedesktop.org/polkit/polkit' is missing in the config.", OgrException("Instance of type GitlabService matching instance url 'https://gitlab.freedesktop.org/polkit/polkit' was not provided."))
<IP_ADDRESS> - - [12/Oct/2022:13:59:07 +0000] "POST /api/webhooks/gitlab HTTP/1.1" 500 37

The URL matching code doesn't work :/
TODO:

[ ] fix this :)
[ ] ping jrybar on internal IRC once this is available on stg

It does work… Just the token was gone from the config, I would love to know why, cause it is in the vault and also I remember updating the config on the running production :)

AFAIK this only affected production, which I fixed moments ago (updated secret and rescaled everything). Stage seems to have the correct version of the config.
My guesses:

redeploying without synced configs
OpenShift being unreliable with updates of secrets on-the-go

oh wow! Thanks for checking this b/c I looked into packit-service.yaml config in BW and was puzzled because all the data were there; @lachmanfrantisek also said that it should work


Tonomy Communication CD - publish docker container

Acceptance criteria

[ ] on a sucessful merge of a PR, the Docker container is built and pushed to Docker Hub tonomy/communication:development

Hints:

trigger https://github.com/Tonomy-Foundation/Tonomy-ID/blob/development/.github/workflows/deployment.yaml#L12
docker container push https://github.com/Tonomy-Foundation/Tonomy-Contracts/blob/development/.github/workflows/deployment.yaml#L70

please dont do this. we found a better way


Self-intersecting polygons

Polygons are already normalised into clockwise-only polygons, but that only works for polygons that don't intersect themselves. Polygons should be checked for intersections, which should be split up.
Note that, for fill-rules, one should also consider several polygons (which are at that point path components) intersecting each other.

So, I did some work and I have quite a few cases. Assuming intersections don't overlap (ugh), the following cases should be handled:

basic line-line intersections
multiple intersections in the same line segment (not sure about this one)
point-line and point-point intersections
intersections with coincident line segments
any of the above two cases where it doesn't actually cross the line, but "bounces" back

Things it doesn't handle:

multiple intersections in the same point
probably also things like pentagrams, but I haven't tested that yet


feature footer

Description
footer is not styled welled  I wanna add good CSS to it so look beautiful  its looking very basic and temporary

hey you there @itsmohit097 any updates?

hey @itsmohit097 if you dont want any updates let me know and close the issuse but i think it will be good to give good design to footer


Do not print stack traces unless --verbose or --debug?

See stack trace at #700.
You already print an ERROR:  and then print the Exception. No need to print the stack trace unless somebody is debugging?

@derekbekoe similar to, but not the same as #611.

The exception raised in #700 is a bug in the code that should be fixed (an unexpected exception). In this case, I think it's correct to show the stack trace.
In #611, the exception is 'expected' and not due to a bug in the code so there we should not print the stack trace.
To answer the question "Do not print stack traces unless --verbose or --debug?", yes we shouldn't print stack traces for expected exceptions but should print stack traces for unexpected exceptions (due to a possible bug in the code).

@tjprescott : is this addressed as part of #759?

@mayurid not really. #759 suppresses the stack trace for CloudErrors only. This is a suggestion that we not print any stack trace unless the user has opted-in with --verbose or --debug. That's open for discussion but our current policy is what Derek points out (that we print stack traces for unexpected errors regardless of --verbose/--debug).

IMO this can be closed. @tjprescott agree?

I will fix #700.
I agree this issue can be closed