Validate Against Org flag to rerun validation even if no changes are detected

Sometimes our Gitlab pipeline fails to complete during the sandbox validation job for various reasons (timeouts for instance), and when we try to rerun the job, we get the message validate will only execute if there is a change in atleast one of the packages.
It would be interesting to have a flag that allows us to rerun the sfdx sfpowerscripts:orchestrator:validateAgainstOrg command, even if no changes were detected in the packages.

@rrgripp  Can you explain the scenario further? If a particular package in a collection of packages fail, and some of them got deployed, we will redo the remaining if you retrigger.
Is there something where you went ahead discarding the output of validateAgainstOrg and went to publish?

Since we already have some source code in the happy soup, sometimes the test fails because of these files. But when I rerun the test, as there was no changes on the package source code, the test is not executed

In that case, it is better to remove --diffcheck option. Will that help?

That would be in which command?
Currently I'm using just
sfdx sfpowerscripts:orchestrator:validateAgainstOrg -u sandbox --loglevel=$LOG_LEVEL

In the case of validate command, remove sfpowerscripts artifact installed in the org. We will be introducing an environment variable for this shortly

Hi @azlam-abdulsalam, thanks for the reply! Yeah, I've been doing that to workaround the issue, but on the long run, it's not the ideal solution. Looking forward to this new release and what you guys have prepared for us :pray: !
Still regarding the matter of validateAgainstOrg, I opened a new issue with a suggestion of a new flag to the command. Not sure if it relates (or becomes useless) with this new release that's coming, but I think maybe it could help with this issue.
Anyway, thanks for all the support!

Closing this as there is an analysis triggered on #800


Need to backup open games when loading new ones

Need a way to zip up and move to trash a game that is currently being edited to avoid accidentally loosing work when switching between game projects.

When editing a new game, the current game folder is zipped up and moved to the trash.


Diagnostic hover sometimes not above/below cursor and occluding the variable hovered.

See Video, seems like it has something to do with the extra 'quick fix' line.
https://user-images.githubusercontent.com/773039/104216630-96d04500-543a-11eb-88b4-fa81d2609caf.mp4

This should be an issue of VSCode

This should be an issue of VSCode

It seems has been fixed in VSCode 1.53.0-insider.

It seems has been fixed in VSCode 1.53.0-insider.


Can't change request method from 'POST' to 'PUT'

With my code below, when I drop an image it still sends a 'POST' request.
Any help would be great!
  render() {
    const dropzoneConfig = {
      iconFiletypes: ['.jpg', '.png', '.gif'],
      showFiletypeIcon: true,
      uploadMultiple: false,
      postUrl: this.props.s3Url,
      method: 'put'
    };
    return (
      <Dropzone
        className={this.props.className}
        config={dropzoneConfig}
      >

Drag n Drop Promo Image here

      </Dropzone>
    );
  }

You probably meant to configure the method on the property djsConfig, which is passed through directly to Dropzone.js.


Fixed major bugs

Fixed README.md ( issue #15)
Fixed watch arguments that prevented the display of recieving chat messages

In the latest web3 version we removed the auto parsing of returned messages, as well as the message.payloadRaw, so you need to actually parse yourself using:
payload = EJSON.parse(web3.toAscii(message.payload));


Linear_search.py

instead of writing 'Linear Search in Python', write 'Linear_search.py' in the filename. Likewise do this same type in the other prs you have done.


Add that the default for a new style is paragraph

To test, run these lines in the immediate window.
ActiveDocument.Styles.Add "test"
? ActiveDocument.Styles("test").Type

Type 1 means paragraph style. See WdStyleType enumeration.

Docs Build status updates of commit b807210:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

api/Word.Styles.Add.md
:bulb:Suggestion
View
Details

api/Word.Styles.Add.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit b807210:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

api/Word.Styles.Add.md
:bulb:Suggestion
View
Details

api/Word.Styles.Add.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Support for Selecting Multiple Edges in Fillet UI

I need edges, lots of edges

This issue is part of the larger Fillet UI (#2606) project.
Problem
Currently, the Fillet UI only allows applying fillets to a single edge at a time.
Task
The goal of this issue is to extend that functionality to support the selection of multiple edges.
So you can apply fillets to several edges simultaneously.
Limitations
Currently the engine won't fillet any adjacent edges but otherwise is fine

I will dig into both options:

Iterating Over addFillet (easy)
Modifying addFillet to Handle Multiple Selections (performant)


strange behaviour when displaying laserscans

Hey everyone,
since i use noetic i have a strange behaviour in rviz. I'm not able to visualize a laserscan, both from real sensor data (SICK S300) and from a recorded bag file. Rviz says that scans are received and all tfs are fine. The rostopic echo tells me that everything is fine. Header looks good, included range data too. Maybe this issue is related to #1508. Even stranger is that very rarely points are displayed (image 1). But not all of them. The scanner has a fov of 180° and works fine for years with melodic.

Don't worry about the tf warning in the first image. Thats only because no slam node is running and therefore no transform from map to odom frame is available. But this should not matter, selected frame is base_link.
If i run a slam node a perfect map is build up (image 2). In this image you can see exactly one point from the scan that is displayed. Has anyone an idea??

My environment

OS Version: e.g. Ubuntu 20.04
ROS Distro: Noetic
RViz, Qt, OGRE, OpenGl version as printed by rviz:
[ INFO] [1593684896.992188484]: rviz version 1.14.0
[ INFO] [1593684896.992224227]: compiled against Qt version 5.12.8
[ INFO] [1593684896.992234742]: compiled against OGRE version 1.9.0 (Ghadamon)
[ INFO] [1593684897.000585023]: Forcing OpenGl version 0.
[ INFO] [1593684897.395518159,<PHONE_NUMBER>.094613020]: Stereo is NOT SUPPORTED
[ INFO] [1593684897.395573937,<PHONE_NUMBER>.094613020]: OpenGl version: 4.6 (GLSL 4.6).

Duplicate of #1511, which is fixed and released (but not yet synced). I suggest to use the ros-testing repos to get the released version already now.


Fix instance level metrics being way too far to the right

@teetone flagged this
"it's hard to read the instance-level numbers for some pages. We have to scroll all the way to the right to see them:"
need to see why the x-axis is so weird here

TBH I think we should just change the value column from right justify to left justify.

TBH I think we should just change the value column from right justify to left justify.

This seems like a reasonable solution


Prevent concurrent operator execution by removing leases discovery

With Cilium's minimum supported Kubernetes version being 1.19 and support for leases in Kubernetes having been around since 1.14, we can drop the discovery logic to check for the availability of leases. Instead, we will assume that the capability always exists.
The assumption helps with enforcing HA mode in cilium-operator at times when the API server is temporarily unavailable, preventing the case where multiple HA operator may run in leader mode concurrently (and break networking) due to the existing fallback logic that is now removed.
Fixes: #17870
Continuation of #18122
/cc @aanm @christarazi
Remove Kubernetes leases discovery to enforce HA mode in cilium-operator when the API server is unavailable

@tommyp1ckles @derailed thanks for the review! I have addressed all of your comments -- PTAL.

Squashed and re-pushed already.

/test

Hmm, are the test failures related to this code change or possibly flakes? 🤔

I had a brief look at the test failures, and they do seem potentially related:

Integration Tests (ci-integration): (link) error retrieving resource lock default/cilium-operator-resource-lock: Get "http://localhost/apis/coordination.k8s.io/v1/namespaces/default/leases/cilium-operator-resource-lock?timeout=5s": dial tcp [::1]:80: connect: connection refused

Conformance Runtime (ci-runtime): (link) E1108 11:53:26.519977   40553 leaderelection.go:332] error retrieving resource lock default/cilium-operator-resource-lock: Get "http://localhost/apis/coordination.k8s.io/v1/namespaces/default/leases/cilium-operator-resource-lock?timeout=5s": dial tcp [::1]:80: connect: connection refused
Worth diving deeper, I'd say, given these are similar and related to leases.

Thanks for the pointers @bimmlerd.
"connection refused" seems to indicate that the API server isn't even listening / accepting packets on the target port, which might hint at a more basic problem.
Is there a way to determine what the state of the control plane is/was when the failure occurred? (I skimmed over the various CI tasks but couldn't spot much helpful.)
I could also try to get this test up and running on my machine if the CI is executable locally as well (which I don't know  personally whether that's the case due to lack of experience with Cilium's CI test suite, but willing to dig deeper on my own if that makes sense).

"connection refused" seems to indicate that the API server isn't even listening / accepting packets on the target port, which might hint at a more basic problem. Is there a way to determine what the state of the control plane is/was when the failure occurred? (I skimmed over the various CI tasks but couldn't spot much helpful.)

Looking at the diff a bit closer, I'd assume https://github.com/cilium/cilium/pull/29001/files#diff-3e55605eff8a63c0fc2076db63b4c714b762c17135cd5ae5c4cdd5360b37c9b9L167 is the issue - without much context this suggests to me that these tests disable operator HA; without this I suppose they need further changes.

I could also try to get this test up and running on my machine if the CI is executable locally as well (which I don't know personally whether that's the case due to lack of experience with Cilium's CI test suite, but willing to dig deeper on my own if that makes sense).

I haven't had much luck with running these locally, personally, but maybe someone else knows more.

Right, the removed version.DisableLeasesResourceLock() call should cause the operator to run in HA mode (or, more accurately, start to request leases unconditionally). What I'm struggling to understand is how that may impact the test API server to not respond to requests at all anymore. 🤔
I'll try to do some further digging and look into how the tests work exactly. Thanks again.

It looks like the test/controlplane tests are already failing. I don't see any assertion failures being logged, however; I wonder if it's due to the pipe to tparse happening, although that tool should let any details bubble up in case of errors. Maybe that's not working for whatever reason.
I might push some temporary commits to tweak the CI.

It looks like the test/controlplane tests are already failing. I don't see any assertion failures being logged, however; I wonder if it's due to the piping to tparse happening, although that tool should let any details bubble up in case of errors according to its main README.

Running the controlplane tests locally I see this:
$ go test -v ./test/controlplane/...
...
=== RUN   TestControlPlane
=== RUN   TestControlPlane/CNPStatusNodesGC
E1110 17:12:06.362630  112868 leaderelection.go:332] error retrieving resource lock default/cilium-operator-resource-lock: Get "http://localhost/apis/coordination.k8s.io/v1/namespaces/default/leases/cilium-operator-resource-lock?timeout=5s": dial tcp [::1]:80: connect: connection refused
...

In "controlplane tests" we start both the agent and the operator with a mocked datapath layer. We do that in order to isolate and test the controlplane logic using fake k8s clientsets, thus without starting a full fledged cluster.
IOW there is no apiserver running, so all the GET requests for leases from the operator will timeout with no answer.
Specifically, the operator logic is tested in the CNPStatusNodesGC test (look at the StartOperator call), hence the error there.
I think your changes are correct, but unluckily disabling the leases resource lock in the mocked controlplane test environment breaks it.
Some possible approach:

supporting the leader election machinery in controlplane tests
reintroduce a way to forcibly disable the leader election only for the sake of contolplane tests, as before

The first is the cleanest but I think it might be pretty involved and so out of scope for this PR.
The other is surely not elegant, but maybe is enough until we properly support leader election in controlplane tests. Are you up to try this and see how it ends up?
Happy to hear other proposals from you or the other reviewers, if there any.

Hey @pippolo84 , thanks for the all the extra context.
Personally I'm happy to consider either route, including adding leader election support in the tests (possibly in a separate PR if that makes sense). I have to say that I don't have a clear picture yet of what's required in detail, however, so chances are I'm being a bit over-ambitious right now and might eventually go with your proposal to choose option (2) for practical reasons. But I'd at least like to try seeing through both paths.
For now, I'm trying to wrap my head around what exactly needs to be done with either option.
Regarding (1), you mention that timeouts are being produced, but we are actually seeing the connection being refused. Is that possibly because cilium-operator is not using the fake client in the leader election code path for some reason, and thus is trying to hit a real endpoint where it should instead be using the memory-served fake client? I'm currently looking at the test scaffolding to understand how things are exactly wired up and don't immediately see any exceptions, but I haven't gotten the full picture yet.
For (2), it seems like we'd have to restore functionality to disable leader election in the operator without making it accessible to the regular user. Definitely not great as it leaves some test-only no-HA bits around, so I can see how that's a short-term solution only.

Regarding (1), you mention that timeouts are being produced, but we are actually seeing the connection being refused. Is that possibly because cilium-operator is not using the fake client in the leader election code path for some reason, and thus is trying to hit a real endpoint where it should instead be using the memory-served fake client? I'm currently looking at the test scaffolding to understand how things are exactly wired up and don't immediately see any exceptions, but I haven't gotten the full picture yet.

That's correct. In controlplane tests, a fake clientset is created:
https://github.com/cilium/cilium/blob/adde8b22b3dc9202bfd3053c3b9e8c278c67530c/test/controlplane/suite/testcase.go#L62-L66
And then passed to the operator hive to be used in all its cells: https://github.com/cilium/cilium/blob/adde8b22b3dc9202bfd3053c3b9e8c278c67530c/test/controlplane/suite/operator.go#L36-L41
But the leader election machinery in runOperator uses a separate Kubernetes client, not the one we provide through dependency injection: https://github.com/cilium/cilium/blob/adde8b22b3dc9202bfd3053c3b9e8c278c67530c/operator/cmd/root.go#L380-L392
the reason for doing that  is explained in the PR that introduced it.
In order to fix this cleanly we might:

move the runOperator invoke (essentially, the leader election logic) away from the Controlplane operator module.
https://github.com/cilium/cilium/blob/adde8b22b3dc9202bfd3053c3b9e8c278c67530c/operator/cmd/root.go#L125-L127
use that only when building the real operator hive, in order to leave things unchanged when running in real clusters
https://github.com/cilium/cilium/blob/adde8b22b3dc9202bfd3053c3b9e8c278c67530c/operator/cmd/root.go#L68-L74
build the operator hive in controlplane tests with a mocked version (setting isLeader to true and calling lc.Start and lc.Stop in its start and stop hooks respectively, should be enough)
https://github.com/cilium/cilium/blob/adde8b22b3dc9202bfd3053c3b9e8c278c67530c/test/controlplane/suite/operator.go#L36-L41

If you are not familiar with it, for more info about Hive and Cells framework you can have a look here.

For (2), it seems like we'd have to restore functionality to disable leader election in the operator without making it accessible to the regular user. Definitely not great as it leaves some test-only no-HA bits around, so I can see how that's a short-term solution only.

Yep, I agree this is not that great, not even as a stopgap. Looking at the above steps, the "clean" fix seems more doable than I had anticipated. Would you be up to try that? If so, I suggest to open a separate PR (we can block this in the meantime). I'm happy to help if you need any kind of additional support. Otherwise I can give it a try and add you as a reviewer. Let me know :+1:

@pippolo84 I can definitely give it a whirl and work on a separate PR. Appreciate the suite of deep links, I think they'll be super useful. 👍

Hey @pippolo84 👋
I took your references and did some digging in the code (along with ramping myself up on Hive). One point I had trouble understanding was this one:

But the leader election machinery in runOperator uses a separate Kubernetes client, not the one we provide through dependency injection.

My (still rough) understanding of how dependency injection via Hive works is that dependencies requested through Invoke() commands are satisfied via type matching from Provide() calls. Climbing up the call chain, it seems that the runOperator function is Invoke()-ed from registerOperatorHooks which is part of the ControllPlane hive cell that, for the test in question, seems to be provided the fake clientset. Unless I am mistaken, it looks like we do have a fake client at our disposal for the operator-under-test.
My conclusion for now is that the problem lies with the usage of the clientset.RestConfig() call which returns an empty struct instance in the test implementation. I assume client-go turns this into a configuration that talks to localhost on the default port (where of course nothing is listening in our mocked world), causing the test to fail.
Instead of using the REST config, I adjusted the lock logic to leverage the coordination API from the client (which should be properly faked assuming my logic above is correct) as shown by one of the official client-go examples. You can see that change in my latest commit. The latest CI run still has two failing tests, but they look like real smoke tests operating on real processes (where Hubble seems to fail right now). Unless I'm missing it in the extensive Cilium test suite, I do not see the unit test in question failing anymore.
(I additionally wanted to verify by running the unit tests locally, but they come with some Linux-dependencies [understandably] which my poor Mac cannot provide. I couldn't spot an easy way to run the tests in a container/VM/Linux-ish environment, though if there is one I'd be curious to learn about for this and future testing needs.)
How does all of this sound to you? Could I have addressed the issue already possibly?

Just realized that many CI jobs have not been triggered/executed for whatever reason. 🤔 I guess I need some assistance in interpreting the output we've got so far.

Hi @timoreimann , first of all thanks for all the effort and the useful investigation!

I took your references and did some digging in the code (along with ramping myself up on Hive). One point I had trouble understanding was this one:

But the leader election machinery in runOperator uses a separate Kubernetes client, not the one we provide through dependency injection.

I was referring to the fact that resourcelock.NewFromKubeConfig takes just the config of the injected clientset, but it creates a new one here, in order to not be affected from client-side rate limiting due to other requests.

My conclusion for now is that the problem lies with the usage of the clientset.RestConfig() call which returns an empty struct instance in the test implementation. I assume client-go turns this into a configuration that talks to localhost on the default port (where of course nothing is listening in our mocked world), causing the test to fail.

I think this is correct. When running in controlplane tests, the new client created for the leader election takes an empty config and ends up talking to localhost.

Instead of using the REST config, I adjusted the lock logic to leverage the coordination API from the client (which should be properly faked assuming my logic above is correct) as shown by one of the official client-go examples. You can see that change in my latest commit.

I think this fixes the controlplane test issue, but I'm afraid this also defeats the purpose of the PR that introduced the separate clientset for the resource lease. If you look at the code changes in that PR, you can see that your latest changes are basically reverting the code in runOperator.

How does all of this sound to you? Could I have addressed the issue already possibly?

I think we still need to fix the controlplane tests while keeping the creation of a separate clientset for leader election.
Unfortunately I don't see any way to use something like PrependReactor or similar to change the behavior of the leader-election-specific clientset (in controlplane tests we don't have a reference to it). So I think we are left with what I suggested above: moving the leader election logic in a separate cell (or at least the logic that creates the leader-election-specific clientset) and swap that cell with a test-specific one in controlplane testing.

(I additionally wanted to verify by running the unit tests locally, but they come with some Linux-dependencies [understandably] which my poor Mac cannot provide. I couldn't spot an easy way to run the tests in a container/VM/Linux-ish environment, though if there is one I'd be curious to learn about for this and future testing needs.)

Can't really help in that regard because I'm on a Linux machine. Have you already checked the Cilium docs? If there's nothing there, I suggest to leave a message in the Cilium & eBPF Slack, hopefully someone with a Mac can chime in and give help.
Regarding the CI, it can be triggered by members of the GitHub org (see https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#getting-a-pull-request-merged), let me know if you need to do that after pushing the changes. :+1:

I think I still have some work to do on this one to address the concerns brought forward. I was running short on time recently, but I'm still committed to add the missing test pieces.

@timoreimann moved this PR to draft due to your latest comment.

I still got plans for this one, bot. Please be kind. 🙂

@timoreimann Ping. :wink:

Sorry, I've been meaning to get to this but struggle to find some spare time. :(


Vertical or sloping label

How can I make label (text) be vertical or sloping  with some angle?
I need it for vertical annotation lines with top-positioned labels.

This was added in #178, which will be released in v0.5.8

This was added in #178, which will be released in v0.5.8


Best Solution displayed in Pycharm but apparently not available with a field

Describe the bug
Hi, I'm extremely new to github so apologizes if there's something missing in my very first post.
I use a lot cvxpy at work and if I run it from Pycharm I can see the screen shows a "best solution" value. I would badly need to capture such value (other editors like Spyder don't even show such value) but it seems there's no field to capture it.
Notice how, as soon as the solver starts, Pycharm shows the current solution value found vs the best solution possible.
I know the "value" attribute captures the value at the end of the optimization, however if we use a timeout, it becomes hugely important to be able to compare the value found vs the optimal solution value.
Am I missing something?
Many thanks,
Andrea
To Reproduce
A minimal code example that reproduces the bug or unexpected behavior.
Unfortunately I can't share the massive code I have here at work but it's a portfolio optimization problem mix with integer optimization.
Expected behavior
A clear and concise description of what you expected to happen.
Offer a field that could be used to compare the optimal solution value.
Output
If applicable, include program output. If reporting a program crash, please include the entire stack trace.
Version

OS:  Windows 7.
CVXPY Version: version = "1.1.0a1"

Additional context
Add any other context about the problem here.

Once you solve an optimization problem, you can get the optimal value from the problem.value field and the solution from the variable.value fields. Is that the info you want?

Hello Steve,
thanks for your answer. No, that's what I need though.
Let me try please to be a little more accurate.
I have the following code:
prob = cvx.Problem(objfunction, constraints_list)
prob.solve(verbose=True, solver=cvx.CBC, maximumSeconds=40)

Given the big dimension of my problem, the timeout of 40 seconds will often cause the optimizer to find a non optimal solution.
if you run the python code using PyCharm, you will see something like:
"Cbc0010I After 3100 nodes, 458 on tree, -2001.0231 best solution, best possible -2042.2492 (96.78 seconds)"
what I need to capture is the best possible solution value because if at this point the timeout interrupts the optimization  'problem.value' will return -2001.0231 and I need also to capture -2042.2492
Any thoughts?
Thanks again, much appreciated,
Andrea

You'll need to manually change the Cbc interface to get that.

Any chance you could point me to where/how I could do that?
I spent two days already digging into tens of cvxpy python files with no luck.
Thanks Steve,
Andrea

Cbc interface is here: https://github.com/cvxgrp/cvxpy/blob/master/cvxpy/reductions/solvers/conic_solvers/cbc_conif.py


[Marker.io] Tablet- orange dot icons are shown in related project tiles

Steps to reproduce:
1)go to any project details page
2) scroll down to related projects section
3) notice the orange dots
Actual result: view project/orange dots are shown
Expected result: it should not be there on tablet

Reported by: Vinod<EMAIL_ADDRESS>- Contact via Marker.io
Source URL: https://kensway.webflow.io/projects/wellington-city-mission---whakamaru-14
Issue details: Open in Marker.io
Device typetabletBrowserSafari 17.3.1Screen Size768 x 1024OSiOS 17.3.1Viewport Size1024 x 698Pixel Ratio@2x

🤖 Marker.io bot - 💬 Vinod commented:

it can be observed in portrait mode of some tablets (browserstack ipad12.9.2021, safari )or the landscape mode of some tablets.(ipad 6th gen, )
when my real tablet device was in landscape mode, issue was observed (below are the dimensions)
resolution: 7681024
viewport: 1024665
(apple ipad 6th gen, safari,ios: 17.3.1)
dots are still visible

Reply here


[Bug Fix] force_encoding column name for multibyte letters

hi @wvanbergen .
I'm @civitaspo. Nice to meet you.
So,
Our Vertica sometimes uses multibyte letters as column name .
In this case, this library cannot read the column name.
This pull Request fix that case.
[example:before](I hide host and password)
irb(main):001:0> require 'vertica'
=> true
irb(main):002:0> client = Vertica.connect(:host => 'example.com', :user => 'dbadmin', :password => 'secret', :database => 'vdb')
=> #<Vertica::Connection: ...secret...>
irb(main):003:0> client.query("select 'あ' as あ")
=> #<Vertica::Result:0x007fea39264fc8 @row_style=:hash, @rows=[{:"\xE3\x81\x82"=>"あ"}], @columns=[#<Vertica::Column:0x007fea392664b8 @type_modifier=7, @format=:text, @table_oid=0, @name=:"\xE3\x81\x82", @attribute_number=0, @data_type=:varchar, @converter=#<Proc:0x007fea39199788@/Users/takahiro.nakayama/src/github.com/wvanbergen/vertica/lib/vertica/column.rb:9 (lambda)>, @size=65535>], @tag="SELECT">

[example:after](I hide host and password)
irb(main):001:0> require 'vertica'
=> true
irb(main):002:0> client = Vertica.connect(:host => 'example.com', :user => 'dbadmin', :password => 'secret', :database => 'vdb')
=> #<Vertica::Connection: ...secret...>
irb(main):003:0> client.query("select 'あ' as あ")
=> #<Vertica::Result:0x007ff73a057628 @row_style=:hash, @rows=[{:あ=>"あ"}], @columns=[#<Vertica::Column:0x007ff73a056660 @type_modifier=7, @format=:text, @table_oid=0, @name=:あ, @attribute_number=0, @data_type=:varchar, @converter=#<Proc:0x007ff7399926f8@/Users/takahiro.nakayama/src/github.com/civitaspo/vertica/lib/vertica/column.rb:9 (lambda)>, @size=65535>], @tag="SELECT">

Hi, thanks for looking into this. This looks like it'll fix the issue you are experiencing. However, I rather properly set the encoding as soon as it enters the system, which is here. Can you move your force_encoding on that location instead?

Thanks for the response.
I moved force_encoding to the new location!

thx! :+1:

I released 0.11.4 that includes this fix.


pg module not compatible with the latest version of python (python 3.8)

Compiler
Python3.8
Error from cloudwatch
[ERROR] Runtime.UserCodeSyntaxError: Syntax error in module 'lambda_function': invalid syntax (init.py, line 3)
Traceback (most recent call last):
File "/var/task/pg/init.py" Line 3
async,
Reason for error
Async a reserved word from python 3.7
https://docs.python.org/3/whatsnew/3.7.html
This is a very old package - should be replace with something newer which is compatible latest python version.
https://pypi.org/project/pg/#history
Even winding back to python 3.6 results in additional errors (_imaging module).

+1 Yes, it looks like that all code was created in 2018, you can see in header of scripts. I don't know if it will be updated.

+1 Yes, it looks like that all code was created in 2018, you can see in header of scripts. I don't know if it will be updated.

Got it working using psycopg2.
I will leave this open so that someone at AWS can update the sample.

Got it working using psycopg2.
I will leave this open so that someone at AWS can update the sample.

Yeah... that pg package is for OpenGL and installs pillow?

Thank you for opening this issue - we are looking into it.

The code in this repo is ok as far as python 3.8 compatibility; the problem lies in the pg driver pygresql and how it is compiled.  If you download it from the Lambda site, it is compiled in python 3.7.  If you try to compile it yourself in python 3.8 and try to use the postgreSQL 12 or 13 client files, it gets really complicated as the dependencies required and what's available on the Lambda are not the same.

Pillow happened to me when I tried to repackage lambda code from here into an independent layer using requirements.txt.  DO NOT REFERENCE "PG" THERE.  The proper name there is "PyGreSQL" which presents a "pg" module from PostgreSQL, not PIL/OpenGL.  The default "pg" will break your lambdas.
I ran into this because I was forced to reimplement the public template using terraform because the serverlessrepo package for this does not allow the attachment of required permissions boundaries.  If you want this fixed, please upvote #27

Got it working using psycopg2.
I will leave this open so that someone at AWS can update the sample.

Could you please tell me the changes you made?

Fixed it with psycopg2, if people are still interested : https://github.com/0xSeb/aws_secrets_manager_psql_rotation_lambda

U can do it with psycopg2, where u can follow as below:
1st, build the docker image, where this will prepare for the linux environment, using pip to download the pre-compile lib.
FROM python:3.8 as py

ARG PSYCOPG2_VER

RUN apt-get update && \
        apt-get install bison flex build-essential libpq-dev -y

WORKDIR /package/psycopg2
RUN python -m venv venv
RUN . venv/bin/activate && \
        pip install psycopg2-binary==$PSYCOPG2_VER --target /out_lib
WORKDIR /

then use docker cp to get the binary from container, repackage it with lambda "handler.py"
.PHONY: help
help: ## This help.
	@awk 'BEGIN {FS = ":.*?## "} /^[a-zA-Z_-]+:.*?## / {printf "\033[36m%-30s\033[0m %s\n", $$1, $$2}' $(MAKEFILE_LIST)

.DEFAULT_GOAL := package
APP_NAME = postgres_env
PSYCOPG2_VER = 2.9.3

# DOCKER TASKS

# Build the container
build: clean
	docker build -t $(APP_NAME) .  --build-arg PSYCOPG2_VER=$(PSYCOPG2_VER)

## Build the container without caching
build-nc: clean
	docker build --no-cache -t $(APP_NAME) . --build-arg PSYCOPG2_VER=$(PSYCOPG2_VER)

clean:
	rm -rf out
	rm -rf deployment.zip

clean-image:
	docker rmi -f $(APP_NAME)

package: build
	mkdir -p out
	$(eval CONTAINER_ID=$(shell docker create $(APP_NAME) --name $(APP_NAME)))
	docker cp $(CONTAINER_ID):/out_lib/. ./out
	docker rm $(CONTAINER_ID)
	cd out && zip -r ../deployment.zip .
	zip -g deployment.zip handler.py

run make, and it will generate the "deployment.zip" and u can upload this to lambda

In Q3/Q4 2022, Secrets Manager updated the python runtimes to v3.9. In certain circumstances, customers may have had a ZIP bundle that still included the 3.7 runtimes even though the Lambda runtime was updated to 3.9, causing some incompatibilities. We have exposed the Runtime attribute in the SAM template and have a blog available for impacted customers here: https://repost.aws/knowledge-center/secrets-manager-lambda-rotation. This particular issue has been resolved through documentation, so closing issue.


Add support for literal arguments overriding dynamic ones

This is a proposed fix for issue https://github.com/Incendo/cloud/issues/137
Prerequisite pulls:

https://github.com/Incendo/cloud/pull/146
https://github.com/Incendo/cloud/pull/147

TODO: Brigadier needs to be updated to supply the right suggestions
I've added support for literals overriding variable arguments in the command tree. In the past this threw ambiguity exceptions, I've rewritten the ambiguity detection to be smarter. It was checking whether the number of children was > 1 if any of the arguments was not static, which broke a lot of things.
Now it allows only one variable (parsed) argument as a child, but allows multiple literal static arguments to co-exist. When parsing the command, it will first check for the literal arguments (and aliases). If none of those match, then it will parse variable ones.
This adds support for command registration such as:
/command literal help
/command <variable> help

Which when invoked as:
/command literal help
Will execute the first, while invoked as:
/command arg help
Executes the other. Added a test for this as well.
In addition, I've had to fix a problem in the code itself that occurs when running tests. When doing the ambiguity test, it checks if an exception is thrown when ambiguity occurs. However, the tree does not clean up the failing command, so it is left in an invalid state. This caused all later-running tests to fail as well. As a result it heavily depended on test execution order whether all the tests succeeded. I fixed this by cleaning up some of the added node children upon failure.

One problem I've found is that the suggestions will only show the literals, not the variable-argument commands that also exist. If that is something I should fix first, let me know.

This type of behavior is not intended to be supported, and so it's not likely this will be merged. For it to be considered however, it would definitely need to have working suggestions, and it would need to take into account Brigadier.

That is fair, I'll keep it in-house then since it is very useful in my personal situation. When I fix the suggestion problems, I'll amend this PR with the relevant commits, unless this PR is closed by then.

Pardon my inability to test on my own: given a tree such that
/help
      | <arg> help
      | literal help

show the 2nd option as the 2nd option when typed into the client? If it does not, I don't believe we should consider this given Brigadier itself does not (though we would be open to it if a PR was opened to Brigadier to fix such an issue!). If it does however choose to show the 2nd option to the client where it's supposed to (and the 1st where it's supposed to), I'd love to :+1: this PR.

When you type:
/help lit
It will suggest 'literal' but none of the suggestions that  would give (if a suggestion provider is used)
When you type:
/help a
It will suggest the suggestions of  (if any start with 'a')
When you type:
/help l
It will suggest only 'literal', not any of the suggestions provided by  that start with l.
Correct me if I'm wrong, but I believe desired is that:
/help
Will show '' and all the literals in a single list
/help l
Will concatenate the 'literal' suggestion with any other suggestion provided by the  argument

Yeah this needs more work, also for how I'm using it myself, I'll post an update when things are fixed

I've fixed a lot of issues that happened because of https://github.com/Incendo/cloud/issues/144
Is this how it should work? I'll work on brigadier support next.

Example code
        manager.command(
                manager.commandBuilder("command", Description.of("Test cloud command using a builder"))
                        .argument(StringArgument.<CommandSender>newBuilder("argument").withSuggestionsProvider((context, inputQueue) -> {
                            return Arrays.asList("one", "two", "link");
                        }).build())
                        .literal("test")
                        .handler(context -> {
                            context.getSender().sendMessage("Argument: " + context.get("argument"));
                        })
        );

        manager.command(
                manager.commandBuilder("command", Description.of("Test cloud command using a builder"))
                        .literal("literal")
                        .handler(context -> {
                            context.getSender().sendMessage("Literal command executed");
                        })
        );

Video of it in action:
https://www.dropbox.com/s/6fpg2y7vhs0ar4w/2020-11-22 21-12-03.mp4?dl=0
It combines the suggestions from the literals with that of the variable argument, automatically hiding suggestions that don't apply (don't start with what the user typed)

A major problem with this is that there's no indications in existing contracts of the parsing order of nodes in the command tree. This behaviour is dependent on whether or not literal arguments are parsed before variable arguments, and existing contracts would need to be strengthened. Whether or not that should be done is something that needs to be discussed, as it will impact how the command tree code evolves.
Concatenating suggestions is quite awkward, but very necessary if this is the route we want to take. That shouldn't really have any significant impact on current suggestion providers, despite them being written under the assumption that they would be the sole suggestion providers for any given argument.
Do these changes allow for anything that wouldn't be possible with a custom argument type/string argument with custom suggestions?

Do these changes allow for anything that wouldn't be possible with a custom argument type/string argument with custom suggestions?
Yes, multiple variable tree nodes assigned to different literals. For example:
/command literal subcommanda
/command literal subcommandb
/command othercommand --flag hello
/command <variable> help

Can validly be registered with my changes, but break before. You would need to parse all variables (greedy), which breaks suggestions and renders the entire cloud api useless for everything under /command.
What I did prior to these fixes is store the full argument list using a preprocessor, and simply used an @Argument("name") @Greedy to parse anything. This was a placeholder, because this broke all suggestions.

I've fixed the duplicate suggestion problem with brigadier. One thing I don't really understand is why the brigadier argument names don't show anymore. The same happens when testing a command that doesn't mix arguments with literals. Seems almost like this thing broke entirely, because it does register the  or [flags] literal in the brigadier manager.
Could use some advice, I don't know that much about brigadier :<

This was not meant to be closed, I'm sorry D: I thought it'd let me change the target branch after 1.2.0-dev had been merged, but it doesn't... Thanks GitHub.


improve application/xiu readme, same default port.

As a newbie, just knows to copy/paste cmd, the same default port config in doc, can impove the first experience with this project.
e.g. the doc said to boot the server by this way: xiu -r 1935 -t 5544 -f 8080 -s 8081 -l info, while play the hls stream by this cmd: ffplay -i http://localhost:8080/live/test/test.m3u8. It took me a while to figure out what's going wrong.

Thanks.


Cannot read property 'offsetHeight' of null

Hi, i am getting the error: Cannot read property 'offsetHeight' of null, sometimes. I have a  element that is doing the following:
<ReactCSSTransitionReplace transitionName="fade-wait"
                                     overflowHidden={false}
                                     transitionEnterTimeout={Constants.Feed.FadeTransitionInterval.Enter}
                                     transitionLeaveTimeout={Constants.Feed.FadeTransitionInterval.Leave}>
            <MyElement key={this.state.key} data={data} />
</ReactCSSTransitionReplace>

In chrome:
 this.setState({
        nextChild: nextChild,
        height: _reactDom2['default'].findDOMNode(this.refs.curr).offsetHeight //<-- null
      }, function () {
        return _this2.setState({
          height: _reactDom2['default'].findDOMNode(_this2.refs.next).offsetHeight
        });
      });

I would like to narrow down the error for you, but it seems to happen very unpredicatbly, as i have an array of 15 objects and using setInterval, i'm replacing the element every 5s or so, when i idle for 20mins or so, the null exception occurs but in the timespan, it would have rotated at least a couple hundred times. Is it due to garbage collection?

The issue is that there is no currentChild component/element on the DOM to get the height from at that time. As to why there is no current child I can't say yet, since at first glance there should always be one. Garbage collection might be the culprit, but I'll investigate this further.
You did, however, point out through this that the component does not work correctly when it has no children, which I think it should. I've started working on a fix for that.

@murugaratham, I have yet to reproduce your error on my side, but what I did do is add support for having no children on the ReactCSSTransitionReplace component. Would you mind installing marnusw/react-css-transition-replace#noChild in your project and seeing whether you still get the error?

Sure, will update after testing, thanks for prompt response

I've released these changes as v1.0.1 and have subsequently released v1.1.0 as well. I did some reasonable testing and am pretty sure I didn't break anything, so even if the new version still doesn't solve your issue we should at least not be any worse off. I'll close this for now, but do let me know if this problem persists.

Many thanks
Sent from my iPhone, please excuse brevity.
Regards,
Gary
On 25 Nov 2015, at 05:35, Marnus Weststrate<EMAIL_ADDRESS>wrote:
I've released these changes as v1.0.1 and have subsequently released v1.1.0 as well. I did some reasonable testing and am pretty sure I didn't break anything, so even if the new version still doesn't solve your issue we should at least not be any worse off. I'll close this for now, but do let me know if this problem persists.
―
Reply to this email directly or view it on GitHub.

Height is still getting stuck at 0. My situation is when the parent is using the following styles:
position: absolute;
display: flex;
flex: 1;
top: 0;
bottom: 0;
left: 0;
right: 0;
To quickly solve the problem, I have to add some "important" flags:
.animation-height {
position: absolute !important;
display: flex !important;
flex: 1;
height: auto !important;
top: 0;
bottom: 0;
left: 0;
right: 0;
transition: 0.1s ease-out;
}
Is there a way to disable the use of the height if we don't need it? Or to adjust the styles so we don't have the important flags?
Thanks!


Security diagnostics for task recordings is missing in the security documentation

"Security diagnostics for task recordings" which is a menu in Dynamics 365 Finance & Operations is not mentioned anywhere in Docs. I suggest it is added under security somewhere

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9907d444-3d05-f72e-7a7d-9e667c344987
Version Independent ID: 4d757287-4674-dddf-1761-c57d0abe3530
Content: Role-based security - Finance & Operations | Dynamics 365 | #MSDyn365FO
Content Source: articles/fin-ops-core/dev-itpro/sysadmin/role-based-security.md
Service: dynamics-ax-platform
Product: ****
Technology: ****
GitHub Login: @sericks007
Microsoft Alias: sericks

@amadse, thanks for posting here!
@ChrisGarty, please update the documentation accordingly.

That is a task recorder behavior that I'll have to check with @jasongre about. I don't know if it will warrant mentioning here, but there should be some documentation for it somewhere...

It is the task recorder. I just got the 2 tools mixed up.
Thanks
Regards
Anders Madsen
Microsoft

From: Chris Garty<EMAIL_ADDRESS>Sent: Wednesday, November 6, 2019 5:45:23 PM
To: MicrosoftDocs/dynamics-365-unified-operations-public<EMAIL_ADDRESS>Cc: Anders Madsen<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/dynamics-365-unified-operations-public] Security diagnostics for task recordings is missing in the security documentation (#1815)
That is a task recorder behavior that I'll have to check with @jasongrehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjasongre&data=02|01|amadse%40microsoft.com|836593562b4f4f5114c308d762d8b811|72f988bf86f141af91ab2d7cd011db47|1|0|637086555251139724&sdata=y%2BPu7QS1%2BeB0Gk2EwxFIfZyyy%2FGgxWWsiNpwTkqABiY%3D&reserved=0 about. I don't know if it will warrant mentioning here, but there should be some documentation for it somewhere...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fdynamics-365-unified-operations-public%2Fissues%2F1815%3Femail_source%3Dnotifications%26email_token%3DAKFN637IZRWBFTGIARYINO3QSLYCHA5CNFSM4JJUNTQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDHGG4Q%23issuecomment-550396786&data=02|01|amadse%40microsoft.com|836593562b4f4f5114c308d762d8b811|72f988bf86f141af91ab2d7cd011db47|1|0|637086555251139724&sdata=c%2FPXETcgGPyUe68TKkgnvM%2FYowJtc0Fo6EKO%2B9jTneE%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKFN6373K7IXBE4KJM4ZWATQSLYCHANCNFSM4JJUNTQA&data=02|01|amadse%40microsoft.com|836593562b4f4f5114c308d762d8b811|72f988bf86f141af91ab2d7cd011db47|1|0|637086555251149680&sdata=ksFEGxSRPDXWNcwi98h9u%2BVlnEa8Io9STOd77%2BRIk3M%3D&reserved=0.

Assigning to @jasongre so that this can be added to the task guide documentation.  Bug 392056 has been logged to track this issue.

BUG 437649 created.


Add child with end tag

How to add child with end tag?
eg. I want to add Category node, and also end with .
<root>
<Category name: 'category'></Category>
</root>

it seems that you need to have a value for this node in order to generate the end tag too:
let doc = AEXMLDocument()
doc.addChild(name: "Category", value: "Test")
print(doc.xml) // <Category>Test</Category>


Update dependencies to resolve security concerns

npm audit had revealed the following security issues with the versions
of dependencies that were being used:

lodash - https://npmjs.com/advisories/1065
lodash.merge - https://npmjs.com/advisories/1066
lodash.mergewith - https://npmjs.com/advisories/1071
mixin-deep - https://npmjs.com/advisories/1013
set-value - https://npmjs.com/advisories/1012

This updates all these dependencies to versions where the security issue
has been fixed.

Thanks. 👍


Some sql cannot be parsered. afl_custom_fuzz_count return 0

I have some sql testcases. But it seems that they cannot be parsed by parser function in srcs/internal/postgresql/srcs/utils.cpp. Thus, afl_custom_fuzz_count return 0.
For example, a simple statement:
select a as b from c;

I have wrote a simple tool to call the parser function with a given sql statement to figure out which one is invalid. But it cannot tell me why a statement is invalid. This problem make me can't use some testcases from somewhere directly and I even don't kown how to fix them to make them work with Squirrel.
By the way, how to extend the parser to support more sql syntax for a specific database?

You can check the bison and flex files for each database (for your case, https://github.com/s3team/Squirrel/blob/master/srcs/internal/postgresql/parser/bison.y) and see whether the current grammar supports your sql. Similarly, if you want to extend the parser, you can modify the bison file and compile them.


Align HD account nomenclature in line with myTrezor.com, Mycelium

This morning I created a Mycelium HD wallet and then loaded the seed onto MBHD.
It works fine as long as the seed is loaded with 'What created these wallet words?' as Trezor BIP44
To make things a bit clearer I think we should change the answers of
What created these wallet words ?
to:
MultiBit HD (BIP32)
Trezor device, Mycelium (BIP44)
Of course we won't be able to list ALL compatible wallets but Mycelium is a biggie.
Also, in our Wallet capabilities we describe our compatibility as being:
BIP 44 m/44h/0h/0h (account 0 only)
to:
BIP 44 m/44h/0h/0h (Account 1 only)
Note the case change
It is a seemingly minor change but that will mean that all of myTrezor.com, Mycelium and MBHD are describing their compatibility identically.
i.e. "oh they all use 'Account 1' HD wallets'

Agreed. We can get this into Beta 5 easily enough.

I've done the changes to the languages.properties locally but haven't pushed them yet.
(Still checking the WalletType wallet changes I have locally)

As #364 is now pushed this is:
Awaiting review and closing

All good. Closing.


Converted all .asciidoc to .md.

Signed-off-by: dblock<EMAIL_ADDRESS>Description
While some of us do love asciidoc for its many claimed awesome features over markdown, none of those features seem to work in "safe" modes, such as GitHub. In such, we are effectively committing documents that are hard to read or unreadable on GitHub. It's time to standardize to the most widely adopted and least common denominator, GitHub-flavored markdown.
For the technically inclined this is what I followed these instructions:

Convert to .xml with asciidoc -b docbook TESTING.asciidoc.
Fix any errors in asciidoc above that asciidoc spews.
Convert xml to markdown, pandoc -f docbook -t markdown_strict TESTING.xml -o TESTING.md.
Cleanup markdown, such as 80-column layout, some syntax highlighting, add TOC, etc.

Check List
--[x] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

start gradle check


RuntimeError: Cannot re-initialize CUDA in forked subprocess. To use CUDA with multiprocessing, you must use the 'spawn' start method

Please check that this issue hasn't been reported before.

[X] I searched previous Bug Reports didn't find any similar reports.

Expected Behavior
It should run without any errors.
Current behaviour
Throws the error:

RuntimeError: Cannot re-initialize CUDA in forked subprocess. To use CUDA with multiprocessing, you must use the 'spawn' start method

Steps to reproduce
The latest pull with commit id 219cd0d with the following command and config below results in the error below
accelerate launch --use_deepspeed -m axolotl.cli.train ../examples/mistral/config.yml
Error:
sing the `WANDB_DISABLED` environment variable is deprecated and will be removed in v5. Use the --report_to flag to control the integrations used for logging result (for instance --report_to none).
/mnt/rishabh/anaconda3/envs/axolotl1/lib/python3.10/site-packages/huggingface_hub/utils/_deprecation.py:100: FutureWarning: Deprecated argument(s) used in '__init__': max_length, max_prompt_length, generate_during_eval, dataset_num_proc. Will not be supported from version '1.0.0'.

Deprecated positional argument(s) used in DPOTrainer, please use the DPOConfig to set these arguments instead.
  warnings.warn(message, FutureWarning)
/mnt/rishabh/anaconda3/envs/axolotl1/lib/python3.10/site-packages/trl/trainer/dpo_trainer.py:311: UserWarning: You passed `generate_during_eval` to the DPOTrainer, the value you passed will override the one in the `DPOConfig`.
  warnings.warn(
/mnt/rishabh/anaconda3/envs/axolotl1/lib/python3.10/site-packages/trl/trainer/dpo_trainer.py:389: UserWarning: You passed `max_length` to the DPOTrainer, the value you passed will override the one in the `DPOConfig`.
  warnings.warn(
/mnt/rishabh/anaconda3/envs/axolotl1/lib/python3.10/site-packages/trl/trainer/dpo_trainer.py:402: UserWarning: You passed `max_prompt_length` to the DPOTrainer, the value you passed will override the one in the `DPOConfig`.
  warnings.warn(
/mnt/rishabh/anaconda3/envs/axolotl1/lib/python3.10/site-packages/trl/trainer/dpo_trainer.py:519: UserWarning: You passed `dataset_num_proc` to the DPOTrainer, the value you passed will override the one in the `DPOConfig`.
  warnings.warn(
Loading checkpoint shards:  67%|█████████████████████████████████████████████████████████▎                            | 2/3 [01:12<00:36, 36.33s/it]Process ForkPoolWorker-1:
Traceback (most recent call last):
  File "/mnt/rishabh/anaconda3/envs/axolotl1/lib/python3.10/site-packages/multiprocess/process.py", line 314, in _bootstrap
    self.run()
  File "/mnt/rishabh/anaconda3/envs/axolotl1/lib/python3.10/site-packages/multiprocess/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/mnt/rishabh/anaconda3/envs/axolotl1/lib/python3.10/site-packages/multiprocess/pool.py", line 114, in worker
    task = get()
  File "/mnt/rishabh/anaconda3/envs/axolotl1/lib/python3.10/site-packages/multiprocess/queues.py", line 370, in get
    return _ForkingPickler.loads(res)
  File "/mnt/rishabh/anaconda3/envs/axolotl1/lib/python3.10/site-packages/dill/_dill.py", line 303, in loads
    return load(file, ignore, **kwds)
  File "/mnt/rishabh/anaconda3/envs/axolotl1/lib/python3.10/site-packages/dill/_dill.py", line 289, in load
    return Unpickler(file, ignore=ignore, **kwds).load()
  File "/mnt/rishabh/anaconda3/envs/axolotl1/lib/python3.10/site-packages/dill/_dill.py", line 444, in load
    obj = StockUnpickler.load(self)
  File "/mnt/rishabh/anaconda3/envs/axolotl1/lib/python3.10/site-packages/torch/storage.py", line 381, in _load_from_bytes
    return torch.load(io.BytesIO(b))
  File "/mnt/rishabh/anaconda3/envs/axolotl1/lib/python3.10/site-packages/torch/serialization.py", line 1040, in load
    return _legacy_load(opened_file, map_location, pickle_module, **pickle_load_args)
  File "/mnt/rishabh/anaconda3/envs/axolotl1/lib/python3.10/site-packages/torch/serialization.py", line 1272, in _legacy_load
    result = unpickler.load()
  File "/mnt/rishabh/anaconda3/envs/axolotl1/lib/python3.10/site-packages/torch/serialization.py", line 1205, in persistent_load
    obj = restore_location(obj, location)
  File "/mnt/rishabh/anaconda3/envs/axolotl1/lib/python3.10/site-packages/torch/serialization.py", line 390, in default_restore_location
    result = fn(storage, location)
  File "/mnt/rishabh/anaconda3/envs/axolotl1/lib/python3.10/site-packages/torch/serialization.py", line 267, in _cuda_deserialize
    with torch.cuda.device(device):
  File "/mnt/rishabh/anaconda3/envs/axolotl1/lib/python3.10/site-packages/torch/cuda/__init__.py", line 365, in __enter__
    self.prev_idx = torch.cuda._exchange_device(self.idx)
  File "/mnt/rishabh/anaconda3/envs/axolotl1/lib/python3.10/site-packages/torch/cuda/__init__.py", line 279, in _lazy_init
    raise RuntimeError(
RuntimeError: Cannot re-initialize CUDA in forked subprocess. To use CUDA with multiprocessing, you must use the 'spawn' start method

Config yaml
base_model: /mnt/rishabh/models/Mistral-7B-v0.2
model_type: MistralForCausalLM
tokenizer_type: LlamaTokenizer

load_in_8bit: false
load_in_4bit: false
strict: false

rl: dpo
rl_beta: 0.1
remove_unused_columns: false

datasets:
  - ds_type: json
    data_files:
      - /mnt/rishabh/data/dpo/m2lingual.json
    split: train
    type: chatml.mistral
  - ds_type: json
    data_files:
      - /mnt/rishabh/data/dpo/m2lingual1.json
    split: train
    type: chatml.mistral
  - ds_type: json
    data_files:
      - /mnt/rishabh/data/dpo/m2lingual2.json
    split: train
    type: chatml.mistral
  - ds_type: json
    data_files:
      - /mnt/rishabh/data/dpo/m2lingual3.json
    split: train
    type: chatml.mistral
  - ds_type: json
    data_files:
      - /mnt/rishabh/data/dpo/m2lingual4.json
    split: train
    type: chatml.mistral

dataset_prepared_path: last_run_prepared
val_set_size: 0.05
output_dir: /mnt/rishabh/checkpoints/axolotl/mistral_instrcut_dpo_m2lingual

sequence_len: 8192
sample_packing: false
pad_to_sequence_len: true
eval_sample_packing: false

use_tensorboard: true
wandb_project:
wandb_entity:
wandb_watch:
wandb_name:
wandb_log_model:

gradient_accumulation_steps: 4
micro_batch_size: 2
num_epochs: 3
optimizer: adamw_torch
lr_scheduler: cosine
learning_rate: 5e-7

train_on_inputs: false
group_by_length: false
bf16: auto
fp16:
tf32: false

gradient_checkpointing: true
early_stopping_patience:
resume_from_checkpoint:
local_rank:
logging_steps: 1
xformers_attention:
flash_attention: true

loss_watchdog_threshold: 5.0
loss_watchdog_patience: 3

warmup_steps: 100
evals_per_epoch: 1
eval_table_size:
eval_max_new_tokens: 128
saves_per_epoch: 1
deepspeed: ../deepspeed_configs/zero1.json
weight_decay: 0.0
fsdp:
fsdp_config:
special_tokens:

### Possible solution

_No response_

### Which Operating Systems are you using?

- [X] Linux
- [ ] macOS
- [ ] Windows

### Python Version

3.10

### axolotl branch-commit

main

### Acknowledgements

- [X] My issue title is concise, descriptive, and in title casing.
- [X] I have searched the existing issues to make sure this bug has not been reported yet.
- [X] I am using the latest version of axolotl.
- [X] I have provided enough information for the maintainers to reproduce and diagnose the issue.

@RishabhMaheshwary how many gpus and what gpu type? Thanks

@winglian 8GPUs, A100 80GB.

I am able to run without any errors when I use the examples/mistral/config.yml. But when I just replace the dataset and training method to dpo shown below it gives the above error.
rl: dpo
datasets:
  - path: Intel/orca_dpo_pairs
    split: train
    type: chatml.intel

@RishabhMaheshwary I've narrowed this down to an issue with DPO full finetuning. DPO LoRA doesn't exhibit the same error.

@RishabhMaheshwary a workaround for now is to append this in your launch command --dataset_processes=1
e.g.: accelerate launch --use_deepspeed -m axolotl.cli.train ../examples/mistral/config.yml --dataset_processes=1

Thanks a lot! Will give it a try and let you know.

There should be a fix upstream in trl too to fix this soon.


As a user I want to be able to create a trip folder so I can store my pictures in one place

creating trip folders


[Tracking issue] Onyx re-key effort

Open bugs since merging main:

[x] https://github.com/Expensify/App/issues/20800
[x] https://github.com/Expensify/App/issues/20801
[ ] https://github.com/Expensify/App/issues/20802
[ ] https://github.com/Expensify/App/issues/20803
[ ] https://github.com/Expensify/App/issues/20804
[x] https://github.com/Expensify/App/issues/20807
[ ] https://github.com/Expensify/App/issues/20809
[x] https://github.com/Expensify/App/issues/20811
[ ] https://github.com/Expensify/App/issues/20812
[ ] https://github.com/Expensify/App/issues/20813
[x] https://github.com/Expensify/App/issues/20816
[x] https://github.com/Expensify/App/issues/20820
[ ] https://github.com/Expensify/App/issues/20822
[ ] https://github.com/Expensify/App/issues/20830

Unrelated to this migration

[ ] https://github.com/Expensify/App/issues/20839

NVm going with a project

Reopening b/c projects are private unless org admin makes them public :D

bugs are getting worked out, most fixes are on staging or prod by now

Only two incomplete issues so far, not blocking SNH:

https://github.com/Expensify/App/issues/20830
https://github.com/Expensify/App/issues/20812

I don't think this issue is needed anymore, bugs are being handled separately as needed


Add Pytorch Resnet50 training script for RALI

@rrawther we a training script in the demo app, should we include this script in MIVisionX?

Done


ooshutup10_recommended

Why would you store the ooshutup10_recommended.cfg in a separate external file
https://github.com/ChrisTitusTech/winutil/blob/main/config/ooshutup10_recommended.cfg
When you can create it in script:
Invoke-WebRequest -Uri https://dl5.oo-software.com/files/ooshutup10/OOSU10.exe -OutFile $ENV:temp\OOSU10.exe
$OOSU10 = '############################################################################
# This file was created with O&O ShutUp10++ V1.9.1436
# and can be imported onto another computer.
#
# Download the application at https://www.oo-software.com/shutup10
# You can then import the file from within the program.
#
# Alternatively you can import it automatically over a command line.
# Simply use the following parameter:
# OOSU10.exe <path to file>
#
# Selecting the Option /quiet ends the app right after the import and the
# user does not get any feedback about the import.
#
# We are always happy to answer any questions you may have!
# © 2015-2023 O&O Software GmbH, Berlin. All rights reserved.
# https://www.oo-software.com/
############################################################################

P001	+
P002	+
P003	+
P004	+
P005	+
P006	+
P008	+
P026	+
P027	+
P028	+
P064	+
P065	+
P066	+
P067	+
P070	+
P069	+
P009	-
P010	-
P015	-
P068	-
P016	-
A001	+
A002	+
A003	+
A004	+
A006	+
A005	+
P007	+
P036	+
P025	+
P033	+
P023	+
P056	+
P057	-
P012	-
P034	-
P013	-
P035	-
P062	-
P063	-
P081	-
P047	-
P019	-
P048	-
P049	-
P020	-
P037	-
P011	-
P038	-
P050	-
P051	-
P018	-
P039	-
P021	-
P040	-
P022	-
P041	-
P014	-
P042	-
P052	-
P053	-
P054	-
P055	-
P029	-
P043	-
P030	-
P044	-
P031	-
P045	-
P032	-
P046	-
P058	-
P059	-
P060	-
P061	-
P024	-
S001	+
S002	+
S003	+
S008	-
E001	+
E002	+
E003	+
E008	+
E007	+
E010	+
E011	+
E012	+
E009	-
E004	-
E005	-
E013	-
E014	-
E006	-
Y001	+
Y002	+
Y003	+
Y004	+
Y005	+
Y006	+
Y007	+
C012	+
C002	+
C013	+
C007	+
C008	+
C009	+
C010	+
C011	+
C014	+
C015	+
L001	+
L003	+
L004	-
L005	-
U001	+
U004	+
U005	+
U006	+
U007	+
W001	+
W011	+
W004	-
W005	-
W010	-
W009	-
P017	-
W006	-
W008	-
M006	+
M011	-
M010	-
O003	-
O001	-
S012	-
S013	-
S014	-
K001	+
K002	+
K005	+
M003	-
M015	-
M016	-
M017	-
M018	-
M019	-
M020	-
M022	+
M001	+
M004	+
M005	+
M024	+
M012	-
M013	-
M014	-
M023	-
N001	-
'
New-Item -Path $ENV:temp\OOSU10.cfg -ItemType File -Value $OOSU10 -Force
Start-Process $ENV:temp\OOSU10.exe -ArgumentList "$ENV:temp\OOSU10.cfg /quiet" -Wait

Performance:
If you want to use Winutil but do not want to use the OO Tweaks, the config data is never downloaded to your PC and the compiled winutil script is a bit smaller which can reduce the time needed to download and start winutil on a slow network.
Maintainability
I thought it would be easier to export a new config from OO Shutup and replace the file the next time OO Shutup is updated than needing to copy-paste the content into the script which becomes a bit harder to read and easier to mess up if you include it in there. (Also the factory config would need to be incorporated the same...)
In the end, I don't see the upside of including the config in the script itself, because even the argument "what about running winutil offline" doesn't hold up, because the OOSU10.exe needs to be downloaded anyways...
Tangent: How could OOSU be implemented offline in winutil (not sensible)
If you wanted to make the functionality fully available in winutil in a single script without requiring internet connectivity, you would need to take extra steps like compressing the OOSU Executable, turning it into a string representation (eg. Base64), and including the blob of text in winutil so it can be turned into the executable offline.
Reasons why this is most likely not sensible for winutil

Performance: In my POC the b64 representation of OOSU10 ended up with a length of ~1.33 Million characters. -> Powershell is an interpreted language. I would be quite impressed if Powershell could handle such large scripts but I haven't tested it.
AV Detection: In my experience, AV Programs (and IT Security People) really don't like large obfuscated blocks of compressed, unreadable data included in scripts that unpack themselves, as this is not uncommon to see in malware samples.
Trustworthiness: At the moment the executable file is downloaded directly from OO Software (and every user can check the script quite easily to validate this) If you start including blocks of compressed third-party software in the script, who would validate that the compressed executable hasn't been tampered with? (Yes I know hash values exist but those are also not really easily verifiable by a normal user)

If anyone has a different take, please let me know :)

Regarding the Off-Topic bit.
I'm completely on your side here, I think in a perfect world, chocolatey could be completely removed from winutil, but because we live in a Microsoft Hell, sadly winget is pretty much broken on a new install, and installation/upgrade problems exist waaaay to often to be like "let's remove chocolatey and let the end user figure out how to get winget working", but IMHO it could be definitely an option to modify the loading to work like:

Check if Winget is installed and working
Try to Update/install Winget if not
If Install fails, install Chocolatey
Retry the winget install using Chocolatey

This way Chocolatey wouldn't need to be installed at all if a working winget install exists. (It could still be installed and used as a fallback obviously)
You are welcome to propose this as an idea/issue if you like it :)
Regarding the undocumented/miscategorized changes, those are definitely a worthy candidate for a new issue because this helps no one and is only annoying for anyone who has to debug a change they didn't intend to make.
In the end, it's up to you if you see the issues you created as answered or if you want to continue the discussion ;) In the grand scheme, I'm only a small fish contributor with my own opinion and I like it to be challenged if someone thinks otherwise.
And Chris has the last say anyway because he is the only one accepting and merging PRs

I'll give you a better idea, why not ditch winget and chocolatey?

The simple reason is, with winget/chocolatey someone else does the heavy lifting in case of Version Updates, Changing URLs, Installer Arguments for Silent install, Installer Arguments for User/Computer wide installations and so on.
Sadly on windows there are pretty much no standardization or conventions when it comes to packaging installers so this is an endless fight against the windmills


qt: fix unicode character display on osx when building with 10.7 sdk

I don't have a 10.7 SDK, and we probably will upgrade later on anyway if I'm not mistaken, so utACK.


Improve build and deploy output from docker daemon/registry

We are not processing the messages from the docker daemon or registry properly, so output isn't as pretty as it should be.


Duplicated commands detected in 1402.json

Home Assistant version
2024.12.5
SmartIR version
1.19.0
SmartIR configuration
climate:
  - platform: smartir
    name: Sala AC
    unique_id: ac_sala
    device_code: 1402
    controller_data:
      controller_type: Broadlink
      remote_entity: remote.broadlink_remote
      delay_secs: 0.5
      num_repeats: 3

Describe the bug
Just a note in the logs that says the following
2024-12-28 17:41:22.744 INFO (MainThread) [custom_components.smartir] Invalid climate device JSON file '1402.json': duplicated commands detected.

Expected behavior
No log entries. And I wonder if that should be a Warning level anyway
To Reproduce
Steps to reproduce the behavior:

start HA, it's logged at boot

Debug log
see attached
home-assistant_smartir_2024-12-28T16-50-53.852Z.log

Hello,
Climate JSON files should not contain the same commands. Please refer to the documentation what are the options. You can get rid of the warning if you modify the JSON file accordingly and I will accept PR of the modifications. This is exactly the reason for the warning - get the user attention and hope any similar file will be fixed. So this is not a bug, but a feature. :-)

I can try helping but I don't get what are the specs of these JSON files.
For what I can see in https://github.com/litinoveweedle/SmartIR/blob/master/codes/climate/1402.json
there is this structure:
  "commands": {
    "off": "JgAkAQABK...",
    "heat": {
      "low": {
        "swing": {
          "16": "JgAmAQA...",

which of those keys are considered commands? I would expect the keys under the commands entry.
And if that is the keys, there are no repetitions in the file, the only repetition I see in the files is down to those keys that are just numbers.

Hello, the documentation for the climate JSON files is here
The issue is not duplicate keys, but values as those are IR commands.


Avoid python libselinux bindings being hidded by tox

Adds libselinux python extensions to the default Dockerfile template
used by molecule in order to avoid failure to build it on selinux
systems.
Fixes: https://github.com/ansible/molecule/issues/1724
Signed-off-by: Sorin Sbarnea<EMAIL_ADDRESS>

Adds libselinux python extensions to the default Dockerfile template

I don't see any addition to the Dockerfile template!?

cc https://github.com/ansible/molecule/issues/1724#issuecomment-472173834

2019-03-13 IRC Meeting. Agreed this isn't 2.20 blocking

What information do you feel is missing? The current comment seems quite clear to me.

@fabianvf things tend to seem "obvious" once you already know a lot of details about them. I just want it to become more obvious to a person who has no context, sees it for the first time and tries to acquire such context. "Look at these 100+ comments" is not very helpful here. I think, this kind of comments should follow the same rules/considerations as good commit messages and docstings.

I'm not sure how many people would be building context from the tox.ini. I think it would be much more helpful to add a section to the docs explaining why Molecule doesn't work well in a normal virtualenv on Fedora-based distributions. If we wanted we could then link to it from here as well.


Try a fix for GitHub Enterprise request issue

Hey @alexr00 Is this fix available via pre release?
Sorry I haven't been able to work out if something is available pre release as they aren't displayed on the releases page

Hi @jpspringall, it is now, but it wasn't at the time of your comment. This fix didn't end up being the cause of the many requests issue though.


AlephBFT warning at session switch

These warnings are shown every single time we switch sessions:

Given they show up normally they should probably be downgraded to a debug message. This would need to be done upstream I fear, so maybe we can also check if there is a way of filtering input to AlephBFT from the network once we finish an epoch?

dev call: should this be closed after a PR disabling alephbft logging?

Can't see them in the log anymore, fixed by #3625


⚠ Bofrost.de has degraded performance

In 20185c9, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1554 ms

Resolved: Bofrost.de performance has improved in 88633c7 after 13 minutes.


Install plugin 'already exist' issue

If RpcNep5Tracker's releases package  included RpcServer.dll:
RpcNep5Tracker depend on RpcServer, if install RpcNep5Tracker first and install RpcServer after， will always print  Plugin already exist.
ZipFile.ExtractToDirectory was not overwrite files.

Now we released RpcNep5Tracker doesn't include RpcServer, so it's OK.
Users need installed RpcServer first if they want install RpcNep5Tracker.


Exclude Servers

Is your feature request related to a problem? Please describe.
There is a server close to me which always gives significantly slow speed results.
Describe the solution you'd like
I would like to exclude the server when running a speed test. Ookla have an exclude flag for this feature:
  --exclude EXCLUDE     Exclude a server from selection. Can be supplied multiple times
Additional context
Image that shows 47230 (Vorboss Limited) giving lower speeds than other servers. Current workaround is just to include a server that I know gives more accurate results.

I would suggest you do the exact opposite: instead of using auto selection by speedtest with exclusions, it's much more efficient for a speedtest tracker to be able to configure a good reliable server in the options, and this is already supported.
Server selection is critical if you want reliable results, I spent quite some time selecting the best server for my area.

Closed since inclusion list is good enough for what I need

@alexdelprete to add one thing: this is a request that I opened in the original speed tracker, too
I would like to exclude bad servers only. Simple because I think that if everyone uses just the three best servers at the moment, these three servers will get overloaded and start to give low values. So in some month one starts over and searches good quality servers.
It would be easier to just Use all servers and ignore slow ones.
(Starting the jobs at 00:58 instead 01:00 also helps to get better results, as most cronjobs run at the full hour, but still, the workload for a server will get higher after a while.
While I write this: maybe it’s an option to have some random delay for a task. So that the workload on the servers gets distributed over some minutes.)

Simple because I think that if everyone uses just the three best servers at the moment, these three servers will get overloaded and start to give low values. So in some month one starts over and searches good quality servers.

that's not been my experience using speedtest servers: I found out that the best ones are always reliable and predictable at any time of the day, even though they are very popular and used by a lot of people (I use a Vodafone server in Milan that is widely used because of its reliabaility) and it's also pretty far from my physical location, despite that I have the best latency results.
The only thing I asked the dev is to implement a list of servers, for redundancy. I think it's the best approach, at least for my experience.
Regarding the scheduling, I start my tests at minute 27, just because I know everybody uses round times (:00 or :30). The idea of a random "salt" for the start of the task is interesting, I like it.

Tried the speed test with the problematic server on Ookla's web interface, and had no issues getting full speed results.
I considered that this might be a docker networking issue even though other servers gave full speed results with docker networking, so I tried to run a speedtest against the id given in speedtest-tracker and was met with:
$ speedtest --secure --server 47230
Retrieving speedtest.net configuration...
Testing from Virgin Media (<IP_ADDRESS>)...
Retrieving speedtest.net server list...
ERROR: No matched servers: 47230

You can see that I used the same id as in the screenshot in the original post for this issue.

Working here:
 speedtest -s 47230

   Speedtest by Ookla

      Server: Vorboss Limited - London (id: 47230)
         ISP: Tecno General S.r.l
Idle Latency:    29.67 ms   (jitter: 1.56ms, low: 27.98ms, high: 34.04ms)
    Download:    50.24 Mbps (data used: 60.9 MB)
                 28.07 ms   (jitter: 3.34ms, low: 27.53ms, high: 291.46ms)
      Upload:     2.06 Mbps (data used: 3.4 MB)
                 28.09 ms   (jitter: 0.48ms, low: 27.67ms, high: 35.88ms)
 Packet Loss: Not available.
  Result URL: https://www.speedtest.net/result/c/06c955da-acd0-4349-85d7-18a1301d2438

What version of speedtest-cli are you using? Here's mine:
❯ speedtest --help
Speedtest by Ookla is the official command line client for testing the speed and performance of your internet connection.

Version: speedtest <IP_ADDRESS>

Usage: speedtest [<options>]
  -h, --help                        Print usage information
  -V, --version                     Print version number
  -L, --servers                     List nearest servers
  -s, --server-id=#                 Specify a server from the server list using its id
  -I, --interface=ARG               Attempt to bind to the specified interface when connecting to servers
  -i, --ip=ARG                      Attempt to bind to the specified IP address when connecting to servers
  -o, --host=ARG                    Specify a server, from the server list, using its host's fully qualified domain name
  -p, --progress=yes|no             Enable or disable progress bar (Note: only available for 'human-readable'
                                    or 'json' and defaults to yes when interactive)
  -P, --precision=#                 Number of decimals to use (0-8, default=2)
  -f, --format=ARG                  Output format (see below for valid formats)
      --progress-update-interval=#  Progress update interval (100-1000 milliseconds)
  -u, --unit[=ARG]                  Output unit for displaying speeds (Note: this is only applicable
                                    for ‘human-readable’ output format and the default unit is Mbps)
  -a                                Shortcut for [-u auto-decimal-bits]
  -A                                Shortcut for [-u auto-decimal-bytes]
  -b                                Shortcut for [-u auto-binary-bits]
  -B                                Shortcut for [-u auto-binary-bytes]
      --selection-details           Show server selection details
      --ca-certificate=ARG          CA Certificate bundle path
  -v                                Logging verbosity. Specify multiple times for higher verbosity
      --output-header               Show output header for CSV and TSV formats

It seems I was using https://github.com/sivel/speedtest-cli which must have some issues resolving Ookla ids. Using Ookla's speedtest cli I was able to confirm the slow speeds are not related to docker networking. Though it does bring up the question of why I can get full speed results via the web interface and not by cli.

I suspect it has something to do with the web interface using multiple servers to test on (but hiding that from the user +3 more)

Did you select Multi or Single below the gauge?

Single:

Multi:

You're right, I was on multi, and that is a terrible server!

I told you so. :)
find a good server, and configure its ID in speedtest-tracker, so it will use only that one.


Map Filtering

while introducing the Mapbox GL map, we have opportunity to detail how best to filter and if any other layer data would be useful.
/cc @sbma44

related #14


Reception Route Module (CDR)

Description
Please explain the changes you made here.
Checklist

[x] Created tests which fail without the change (if possible)
[x] All tests passing
[x] Extended the documentation, if necessary

Requires https://github.com/aeecleclair/Hyperion/pull/528


parsers.py docs need to link to more complete documentation for iterator and chunksize

I was very confused about the purpose of the iterator and chunksize parameters when looking at the help for read_csv. It wasn't until I Google'd upon the docs for IO Tools that I began to understand.
I propose that links to the IO Tools docs be included in the docstrings for the iterator and chunksize parameters.

I guess this could have a link the on-line docs (near the top of it I suppose).
want to do a pull-request?

closed by #11505


JSON Schema

I noticed that the properties throughout the JSON are not in a consistent order. This is generally fine as it is a human-drive process, but it complicates efforts to automate data transformations. For instance, I could fix all of #148 in a second with my tooling, but it would trigger a massive diff due to all the properties being rearranged.
Maybe we just rip the band-aid off and have one PR that standardizes the property ordering. We could either add a file detailing the official order of properties, or we just settle on a rule of alphabetizing all properties.
Thoughts?

Unlike a list, keys are the primary entry point to a value. The order of keys is not important within a map.

Not sure how you are outputting the JSON, but if you follow the ordering here:
https://github.com/scottrick/swccg-json-parser/tree/main/src/main/kotlin/com/hatfat/swccg/json/parse/data
I think it should be mostly correct.

@scottrick I figured just switching to raw alphabetization would be the most future-proof solution and no one would ever need to lookup the order of fields.

Yeah that might be better.  I did it in this order because it minimized the diff while giving everything the same order.


Bypasses NPE when the hosting server has no CDI.

The default Jetty server run in super-dev-mode fails to start with an NPE prior to this change.

Thanks @smoyer64!


revenue, income, other major financials from XBRL

From @bkj on March 24, 2016 1:30
Need to have data to be able to flag companies for having "no business, no revenues or no product".
Can proxy this with revenue and income from XBRL forms.
XBRL is painful but we need at least an approximate solution in the near term, which includes historical/prospective scraping plus basic parsing.  Can iterate on the parsing later.
I know @Emmett-Culhane has already done some work to this end.
Copied from original issue: bkj/edward#20

@Emmett-Culhane Status?


Add ADFS authentication scheme

This might help us retrieve information like major/minor etc
bu adfs metadata.zip

After talking with IS&T, ADFS can't do this. Need to get info from Registrar.


[WIP] hermes relayer

Description
This PR ...
Checklist

[ ] I have made sure the upstream branch for this PR is correct
[ ] I have made sure this PR is ready to merge
[ ] I have made sure that I have assigned reviewers related to this project

Changes

[ ] Added ...
[ ] Changed ...
[ ] Removed ...

Screenshots
...
Testing

Open page ...
Click ...
Make sure that ...

Links/References

...
...
...

Notes

...
...
...

Hermes has now been integrated here: https://github.com/strangelove-ventures/interchaintest/pull/396
Closing as stale.


Fix flaky LoanReschedulingWithinCenterTest so that it also passes on Sunday (FINERACT-820)

see https://issues.apache.org/jira/browse/FINERACT-820

Hm, looks like fixing FINERACT-820 is not quite as trivial as this? I'll close this again, for now.


Update main.cpp

Add getchar(); at the end so if you run a program by drag-dropping a file, it doesn't exit without you seeing it.

Sorry, I don't really understand this. What does this achieve?

Say I write Hello World. It will look something like this. (("Hello World!"sP. I now want to run this by drag-dropping the file hello_world.sm, but if I do, it will exit so fast I don't see my program. However, adding a getchar(); after you run the program fixes this. (This patch is targeted at MS-Windows users).

I've decided to work on this a bit more. I'll open again once I've finished.


QN: How to hide console for Blazor Server APP

I downloaded your BlazorServerAppDemo.
When I ran it a console is also opening in the background.
How can I prevent it?
I changed application type to Windows from Console. But it does not work.

@VarunSaiTeja I think you need to verify first what triggers the console - The Web Server App or Chromely desktop app. The way it is done, Chromely is more or less a child process - so I doubt you can solely control that.
If it is what I think it is, you may need to look at how console is suppressed in a normal ASP.NET Core app.
These may also help:
https://github.com/chromelyapps/Chromely.Legacy/wiki/Getting-Started-CefGlue-Winapi-(.NET-Core)#how-to-hide-net-core-console
https://docs.microsoft.com/en-us/cpp/build/reference/editbin-reference?view=msvc-160

@VarunSaiTeja I think you need to verify first what triggers the console - The Web Server App or Chromely desktop app. The way it is done, Chromely is more or less a child process - so I doubt you can solely control that.
If it is what I think it is, you may need to look at how console is suppressed in a normal ASP.NET Core app.
These may also help:
https://github.com/chromelyapps/Chromely.Legacy/wiki/Getting-Started-CefGlue-Winapi-(.NET-Core)#how-to-hide-net-core-console
https://docs.microsoft.com/en-us/cpp/build/reference/editbin-reference?view=msvc-160

The normal Web Server app not showing console. When I copied Program.cs and ServerAppUtil.cs from the demo. I am seeing console

The normal Web Server app not showing console. When I copied Program.cs and ServerAppUtil.cs from the demo. I am seeing console


feat(middleware/jwt): improve error handling

Improves error handling in the JWT middleware by passing error descriptions to message prop in HTTPExceptionOptions.
Author should do the followings, if applicable

[ ] Add tests
[x] Run tests
[x] yarn denoify to generate files for Deno

Hi @tfkhdyt
Looks good! This is minor but a new feature. So, we'll ship it as a "minor-release". I'll create a "next" branch for it and merge this later! Thanks.


add version command

@jsingle cc @thieman

I'm not the one with the vision for the separate dusty -v and dusty version commands.  Seems to me like we should print out the client version as well in this command

Also it would be kind of funny to run dusty version and get a RuntimeError saying the client and daemon versions are different lol.  Not sure if that's worth addressing


Schema is incorrect

Hello, the schema https://docs.microsoft.com/en-us/azure/azure-stack/media/azure-stack-integrate-dns/integrate-dns-01.png is incorrect :

Name servers are azs-ns01/ns02 and not azs-Dns01/Dns02 (the D should be removed)
forwarded zone should be the same as in the text (east.cloud.fabrikam.com and not sea.azurestack.external)
another zone should be included in the ns01/ns02 servers : east.cloudapp.cloud.fabrikam.com)

Please update it to match the rest of the doc.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4cf7c779-041d-a232-b441-b769be1aaa67
Version Independent ID: 2b4f5bc1-66f6-4c7f-c06e-bc32f2acd383
Content: Azure Stack datacenter integration - DNS
Content Source: articles/azure-stack/azure-stack-integrate-dns.md
Service: azure-stack
GitHub Login: @jeffgilb
Microsoft Alias: jeffgilb

@jbpaux Thanks for your feedback. I have a note out and will update as soon as I have an updated diagram. #in-progress

@PatAltimore @mattbriggs This is still not fixed, bumping this issue up.

Updated diagram based on feedback.
#please-close

@PatAltimore I don't see updates :(
https://github.com/MicrosoftDocs/azure-stack-docs/blob/master/azure-stack/operator/media/azure-stack-integrate-dns/integrate-dns-01.svg
There are sill mention of azs-Dns01 instead of ns01, the sea.azurestackhub.external, the missing zone for cloudapp.


error subscribing to headers on yarn testnet

[ ] Resolve the error

this shouldn't be an issue anymore since we updated / fixed RPC subscription in node.js


scala v2.11

Looks great. Is it possible to publish to scala v2.11?
Thanks

Sorry, we cannot do a 2.11 compatible release. It has been more than a year since 2.12 got out and it is pretty stable at this point.


fix: fix typing in DsfrDataTableV2

:tada: This PR is included in version 1.12.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


refactor fields rendering, default value rendering and retention of entered value on error

fixes #486,
fixes #498,
fixes #487,
fixes #503,
fixes #499,
fixes #504,
fixes #508

refactor and simplify fields rendering
fixes date and datetime field rendering
if default value is given for field then autofill it

update help text for default value to use pipe (|) for checkboxes

retain entered values on error
fix section name display for polls start button
unify poll, survey, and quiz UI for label and question count and their CSS
refactor help text for field
fix poll direct display crash
dynamically change answer option label
add validation for pipe symbol in choice of skip logic

I managed to crash a survey with skip logic. Steps to reproduce:
Q1: Question with checkbox, checking the checkbox goes to Q3
Q2: anything
Q3: Dropdown: Option 1 goes to end, Option 2 goes to next default question.
Q4: anything

Go through the survey, check the checkbox in Q1. Pick option 2 in Q3. Q3 will be repeated (this is a bug too). Pick anything for Q3 and Q4. Upon submission of Q4 the page crashes: "list index out of range" (related to the pagination)
Regardless of your choices, the question counter never seems to be beyond "question 2 out of 4"

dynamically change answer option label

This doesn't appear to be working?
Everything else seems to be working great though, excellent!

dynamically change answer option label

This doesn't appear to be working?

could you try after clearing the browser cache, or try in incognito?

Thanks, I managed to get it to work, not sure what the issue was.
This only leaves the skip logic crash from the previous comment.

I managed to crash a survey with skip logic. Steps to reproduce:
Q1: Question with checkbox, checking the checkbox goes to Q3
Q2: anything
Q3: Dropdown: Option 1 goes to end, Option 2 goes to next default question.
Q4: anything

Go through the survey, check the checkbox in Q1. Pick option 2 in Q3. Q3 will be repeated (this is a bug too). Pick anything for Q3 and Q4. Upon submission of Q4 the page crashes: "list index out of range" (related to the pagination)
(minor issue) Regardless of your choices, the question counter never seems to be beyond "question 2 out of 4"

unable to recreate this, and I'm able to submit the survey successfully.

unable to recreate this, and I'm able to submit the survey successfully.

It appears there's another requirement: Q2 needs to have a "go to end of survey" option.


Make error types non-exhaustive

Relevant API guidelines
Using enums for capturing possible error cases is convenient, but it can be tricky for future-proofing because adding new variants is a breaking change because users can exhaustively match them.
We should think about how we can make the error types more resilient to future changes by either:

Adding a non exhaustive variant (until we've got a stable #[non_exhaustive] attribute this could be a hidden variant with an ugly name, like #[doc_hidden] __NonExhaustive)
Refactoring the errors into structures with private fields

The first option is a good step, but we would need to be careful about adding new variants that change the conditions under which other variants are returned. This would be a semantic breaking change. The second option is less ergonomic for downstream users, but provides the best future-proofing.
I think this will need some more discussion to come up with a design we're all happy with going forward to 1.0.
Mentoring instructions
Leave a comment here on the thread and we'll work out how to get started.

The error type in 1.0.0 no longer publicly exposes variants.


Felix/realsense sim bringup

Integrating the Realsense camera into Sim so that the Camera transforms are published and so we can see things in gazebo.
Currently all camera streams are online but the Sim performance does suffer with around 8 fps. The point cloud looks good and the camera stream makes sense. Able to move robot and see camera update which is cool. Also can see arms moving in front and the planned path from the camera's view.
See this link for some more context. https://bdschnap.atlassian.net/wiki/spaces/FYDP/pages/34635777/Simulation
This plugin also requires the PAL Realsense plugin to be downloaded and built once with catkin. https://github.com/pal-robotics/realsense_gazebo_plugin
To turn off the point cloud and improve performance go to movo_common/movo_description/urdf/sensors/_d435.gazebo.xacro and set to be false
Below is a sample sim use. The camera stream in the bottom left has the lens in frame but those have since been removed by moving the optical joints 0.005m forward.

since two different urdf files are used, one for sim and one for real life, the environment variable MOVO_SIM must be set to true (export MOVO_SIM=true) to enable the camera in SIM. Otherwise, the model will default to the real life camera

Will add devnote update on how to download the necessary files and build them in next commit

Added the laser scan merger and the scans from front laser and camera laser can be seen. However, seems like there is some other extrapolation or filtering so I'm not sure if the closest point is always seen.
Here is the scan from the camera

Here is the scan from the front laser

Here is the combined scan on base_scan_filtered. The frequency is 4hz for the combined and camera while the front scan publishes at around 14 hz

@younesr1 Could I get a review for this one? I think it's straight forward and doesn't impact other things in sim much other than it gives us simulated camera

@younesr1 do you need to go onto the nightingale account to also approve this?