Anchor wrapped in partial does not work as expected

Description:
I develop an app that uses anchor as a mount point for my components. Everything works just fine untill I use this approach inside a partial of a parent component. Following behavior appears if I do so.

children that are attached to my anchor gets rendered correctly for the first time but changing data via set method does not propagate down the component tree anymore.

on-click handlers gets called twice.

Versions affected:
0.10.9, 0.10.10, 1.0.0
Platforms affected:
Tested on MS Windows 10 (Chrome, FF, Edge)
Reproduction:
Here is a code snippet.

I've simplified the issue. It has nothing to do with partials, although the log still appears twice. It's more of how components work when dynamically mounted.
In the following example, if you replace <#mountPoint/> with <View/> (register View as a component of Layout), everything starts working.
const Clock = Ractive.extend({
  template: `

Time in Clock: {{ time }}

  `
});

const View = Ractive.extend({
  components: {
    Clock
  },
  data: () => ({
    time: Math.random()
  }),
  template: `

Time in view: {{ time }}

    <Clock time="{{ time }}" />
    <button on-click="@this.getTime()">Get time</button>
  `,
  getTime() {
    this.set('time', Math.random());

    console.log('View time is ', this.get('time'));
  }
});

const Layout = Ractive.extend({
  template: `

App with anchor

<#mountPoint/>

  `,
  oninit() {
    const component = new View();
    this.attachChild(component, {
      target: 'mountPoint'
    });
  },
});

const app = new Layout({
  el: '#root'
});

This is actually two separate semi-related bugs that I've identified, but it may take me a bit to squish the broken bindings side. What happens is the instance unbinds and binds again when it's attached to the anchor, which causes the Clock instance to unbind and tear down, which leaves it in a dead state even though it is rendered.

I forgot that anchors are inherently async, so getting a test case that would break took a bit. I think I've got it now, and the fix should be on edge, v0.10.11-dev and v1.0.1-dev as soon as travis finishes travising.


Avoid unintentionally marking messages as unread in interleaved views

As discussed on CZO, we should ask for confirmation when marking a lot of messages as unread in interleaved views, as this may have unexpected consequences, and cannot be easily undone.
So, in interleaved views only, we should show a confirmation modal, as described below.
When we know how many unread messages would be affected
If 50+ messages would be affected, show the following confirmation modal:

Mark messages as unread?
Are you sure you want to mark {N} messages as unread? Messages in multiple conversations may be affected.
[Cancel] [Confirm]

When we don't know how many unread messages would be affected

If we know at least 10 messages will be affected:

Mark messages as unread?
Are you sure you want to mark {N}+ messages as unread? Messages in multiple conversations may be affected.
[Cancel] [Confirm]

I think it's OK not to worry about rounding the number, and just use 237+ if that's what we know. But we could round as we do for user counts in the right sidebar, if that's easy.

If fewer than 10 messages might be affected, we can omit the number.

Mark messages as unread?
Are you sure you want to mark messages as unread? Messages in multiple conversations may be affected.
[Cancel] [Confirm]

Notes

As usual, keyboard focus should be on the Confirm button to start with.

CZO thread

@zulipbot claim

@alya @Niloth-p I would like to work on this issue.  As the last commit made in this issue was 2 months ago.

@imkurosaki Sorry, I have updated the branch locally with all the feedback addressed, I just haven't pushed it yet. So, please pick something else. Thank you for the reminder :)


Java 8 support please

It would be good if you can support java 8

Thanks for being active, can you advice what is the missing piece for java 8 support?

There are some old AOT native compilers like Excelsior JET they only work on java 8....


[PE-D][Tester D] Does Not Allow Adding New Person With Same Name

When trying to add a new person named Bernice Yu, the following error is thrown.

In the real world, there is quite a high possibility of people having the same names even though they are different people, evident by having a different phone number, email address, and address. Would it be possible to allow this?

Labels: type.FeatureFlaw severity.Medium
original: johnrhimawan/ped#3

Duplicate #137


Update library @ipcrmdemo/npm-test to 0.2.35

Nudge generated by Atomist

Pull request auto merged by Atomist.

No reviews
1 successful check

[atomist:generated] [auto-merge:on-check-success]


[NFC][Cleanup] Switch to use upstream methods.

Cool Thanks!. One of the things I'd like to do though is to use the upstream scf::TileUsingSCFForOp method. Issue is that it doesnt support distribution

Intersting stuff! I haven't followed the code for a while, but it looks like we'll be able to enhance the method and drop our own logics. cool cool


YARN-11289. [Federation] Improve NM FederationInterceptor removeAppFromRegistry.

YARN-11289. [Federation] Improve NM FederationInterceptor removeAppFromRegistry.
1.FederationInterceptor#finishApplicationMaster needs to check getFinalApplicationStatus, and clean up when the status is SUCCESS.
2. When FederationInterceptor#shutdown, perform CleanUp on Application.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  0s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
38m  4s

trunk passed

+1 :green_heart:
compile
1m 38s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
1m 36s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 49s

trunk passed

+1 :green_heart:
mvnsite
1m  4s

trunk passed

+1 :green_heart:
javadoc
1m  5s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 46s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 53s

trunk passed

+1 :green_heart:
shadedclient
21m 30s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 40s

the patch passed

+1 :green_heart:
compile
1m 29s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
1m 29s

the patch passed

+1 :green_heart:
compile
1m 23s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 23s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 32s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1 :green_heart:
mvnsite
0m 46s

the patch passed

+1 :green_heart:
javadoc
0m 35s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 33s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 32s

the patch passed

+1 :green_heart:
shadedclient
20m 58s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
24m  7s

hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
asflicense
0m 43s

The patch does not generate ASF License warnings.

123m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4836/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4836

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux a76445a5ca3b 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b8167866b398428df4d2421b5ab3c6c9b38503cf

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4836/2/testReport/

Max. process+thread count
756 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4836/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m  0s

trunk passed

+1 :green_heart:
compile
1m 54s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
1m 46s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 52s

trunk passed

+1 :green_heart:
mvnsite
1m  1s

trunk passed

+1 :green_heart:
javadoc
1m  3s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 50s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 56s

trunk passed

+1 :green_heart:
shadedclient
24m 10s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 44s

the patch passed

+1 :green_heart:
compile
1m 41s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
1m 41s

the patch passed

+1 :green_heart:
compile
1m 27s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 27s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 33s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1 :green_heart:
mvnsite
0m 47s

the patch passed

+1 :green_heart:
javadoc
0m 40s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 36s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 38s

the patch passed

+1 :green_heart:
shadedclient
23m 11s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
24m 33s

hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

132m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4836/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4836

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 568aa73a66ce 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b8167866b398428df4d2421b5ab3c6c9b38503cf

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4836/1/testReport/

Max. process+thread count
723 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4836/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
38m 16s

trunk passed

+1 :green_heart:
compile
1m 44s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
1m 35s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 47s

trunk passed

+1 :green_heart:
mvnsite
0m 58s

trunk passed

+1 :green_heart:
javadoc
1m  5s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 53s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 46s

trunk passed

+1 :green_heart:
shadedclient
21m 11s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 39s

the patch passed

+1 :green_heart:
compile
1m 27s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
1m 27s

the patch passed

+1 :green_heart:
compile
1m 22s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 22s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 29s

the patch passed

+1 :green_heart:
mvnsite
0m 46s

the patch passed

+1 :green_heart:
javadoc
0m 39s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 36s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 33s

the patch passed

+1 :green_heart:
shadedclient
20m 39s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
24m  4s

hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
asflicense
0m 44s

The patch does not generate ASF License warnings.

122m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4836/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4836

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux b850bfbeecf0 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / fa722601ee8c7fa82f7c7d54aaf9c3ce1a1d9820

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4836/3/testReport/

Max. process+thread count
559 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4836/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 47s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
38m 44s

trunk passed

+1 :green_heart:
compile
1m 45s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
1m 37s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 48s

trunk passed

+1 :green_heart:
mvnsite
1m  3s

trunk passed

+1 :green_heart:
javadoc
1m  2s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 44s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 47s

trunk passed

+1 :green_heart:
shadedclient
21m  5s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 44s

the patch passed

+1 :green_heart:
compile
1m 26s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
1m 26s

the patch passed

+1 :green_heart:
compile
1m 21s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 21s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 33s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
mvnsite
0m 47s

the patch passed

+1 :green_heart:
javadoc
0m 34s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 33s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 32s

the patch passed

+1 :green_heart:
shadedclient
20m 53s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
24m  4s

hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
asflicense
0m 49s

The patch does not generate ASF License warnings.

123m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4836/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4836

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux e5808ac234d6 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3d5023ca32a67e1600cd29de01e1fac4991f849f

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4836/4/testReport/

Max. process+thread count
647 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4836/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
13m 18s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
38m 54s

trunk passed

+1 :green_heart:
compile
1m 42s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 36s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 57s

trunk passed

+1 :green_heart:
mvnsite
1m  5s

trunk passed

+1 :green_heart:
javadoc
0m 59s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 44s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 46s

trunk passed

+1 :green_heart:
shadedclient
21m 47s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 44s

the patch passed

+1 :green_heart:
compile
1m 31s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 31s

the patch passed

+1 :green_heart:
compile
1m 29s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 29s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 30s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
mvnsite
0m 45s

the patch passed

+1 :green_heart:
javadoc
0m 39s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 36s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 32s

the patch passed

+1 :green_heart:
shadedclient
20m 54s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
23m 47s

hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

136m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4836/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4836

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux c4766b77a121 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 1f0c1d5f40c5758b56a778499c19e2d541e914ac

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4836/5/testReport/

Max. process+thread count
559 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4836/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 26s

trunk passed

+1 :green_heart:
compile
1m 52s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 44s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 51s

trunk passed

+1 :green_heart:
mvnsite
1m  1s

trunk passed

+1 :green_heart:
javadoc
0m 59s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 51s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 51s

trunk passed

+1 :green_heart:
shadedclient
24m 55s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 44s

the patch passed

+1 :green_heart:
compile
1m 43s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 43s

the patch passed

+1 :green_heart:
compile
1m 34s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 34s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 33s

the patch passed

+1 :green_heart:
mvnsite
0m 48s

the patch passed

+1 :green_heart:
javadoc
0m 43s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 36s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 43s

the patch passed

+1 :green_heart:
shadedclient
23m 39s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
25m 18s

hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
asflicense
0m 53s

The patch does not generate ASF License warnings.

135m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4836/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4836

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux d098cf732689 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / af340243fabdf00a153c15d42eb8583b20ab979b

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4836/6/testReport/

Max. process+thread count
554 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4836/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri Thank you very much for helping to review the code!


chore: add Hashable as ignored words

Signed-off-by: hsgwa<EMAIL_ADDRESS>"Hashable" is used in CARET_trace.
https://github.com/tier4/CARET_trace/pull/52/files

@bopeng-saitama  cc: @takam5f2
Please could you review this PR?


multi-threading

Currently we're running everything on a single thread. I wonder if there is a straightforward way to provide a wrapper that allows multi-threading (or even distributing) tokenization.

Unfortunately we cannot achieve parallelization with multi-threading in python because og the GIL (Global Lock Interpreter), which only allow one thread to run on a process. But we can do mutli-processing to achieve parallelization, which I have implemented in the script to do Google OCR on bunch of images.
https://github.com/Esukhia/Google-OCR/blob/1d19e9e0ce6872988365b0d8805c9cb96269f913/usage/bdrc/image_to_text.py#L114
I will send PR on this later on.

A simple way of doing it would be to change this line: https://github.com/Esukhia/botok/blob/improve-tok/botok/tokenizers/wordtokenizer.py#L80.
Creating a new method that returns tokens where all the multiprocessing happens will keep things simple, and would even allow for two modes to choose from: single processing or multi-processing.

The below example seems to work. The benefit is that it does not require any changes to Botok. The trick is to find the right number for Pool. I could do around 20 on a 16-core machine, but after that massive memory leak takes over. It seems that Pool has a lot of issues with memory, so that's probably expected. It seems that performance gain is linear. 16x processes, 16x faster tokenization.
I have OpenPecha repos in texts/ so that just the directory containing the volumes an the volumes are there.
from botok import TokChunks

def tokenization(text, tokenizer):

    out = []

    preproc = TokChunks(text)
    preproc.serve_syls_to_trie()
    tokens = tokenizer.tokenize(preproc)

    for i in range(len(tokens)):

        out.append(tokens[i]["text"])

    del preproc, tokens

    return out

def init_tokenizer():

    from botok import BoSyl, Config, Tokenize, Trie

    config = Config()
    trie = Trie(BoSyl,
                profile=config.profile,
                main_data=config.dictionary,
                custom_data=config.adjustments,
                pickle_path=config.dialect_pack_path.parent)

    tokenizer = Tokenize(trie)

    return tokenizer

def create_paths():

    import os

    paths = []

    for text_dir in os.listdir('texts'):
        for text in os.listdir('texts/' + text_dir):
            paths.append(text_dir + '/' + text)

    return paths

def create_tokens(path):

    import os
    import gc

    # handle input
    docs = open('texts/' + path, 'r').read()
    tokens = tokenization(docs, tokenizer)

    # handle output
    os.makedirs(os.path.dirname('tokens/' + path), exist_ok=True)
    out = open('tokens/' + path, 'w')
    out.write(' '.join(tokens))
    del tokens
    out.close()

    gc.collect()

    print(path)

from multiprocessing import Pool
import warnings

warnings.simplefilter('ignore')

tokenizer = init_tokenizer()
p = Pool(20)
paths = create_paths()
p.map(create_tokens, paths)

:)

Nice!


Tests for CVE-2021-3807

It'd probably be a good idea to add tests to make sure the changes that fixed CVE-2021-3807 don't regress in the future. I'll work on this in my fork and mention it in my PR.

There is no reliable way to my knowledge. Please correct me if I'm wrong.
These vulnerabilities are so incredibly edge-case and low severity (despite the broken CVE scoring system) that I'm honestly losing patience in the entire effort made by Snyk researchers to nit-pick these away. They create loads of overhead and drama all so the same researchers can farm money on huntr.dev.
For now, I'm going to close this. If someone wants to revive with concrete steps needed to reliably test for this, I'm all ears.


multiple drafts support

Hi, I am using draftsman for a quite large project at my company, that project needs a multiple drafts functionality, unfortunately draftsman lakes for that. So I decided to support multiple drafts and push draftsman to version 1.
Changes:

remove deprecated methods and callbacks
change has_drafts to has_draftsman
change draft? to has_drafts?
every update is considered a drafts, no updates to existing drafts
change belongs_to association to has_many
change draft association name to drafts
most functions now operates on a ActiveRecord::Associations::CollectionProxy instead of Draftsman::Draft

To change:

edit readme.md to reflect new changes
review draft_publication_dependencies and draft_reversion_dependencies to make them work with multiple drafts or remove them if possible
make sure new changes passes all tests or add tests for new functionality

@yasser-sobhy Thank you for the pull request!
I am very interested in this feature, but I think that some things would need to change with the implementation.

Don't make it version 1. I'd probably release this as 0.7 or 0.8 honestly. So put those
deprecated methods back in too. Focus this pull request just on the new feature instead of
trying to manage the overall project.
Create an optional setting on .has_drafts that lets the developer decide if they're going to
have a single draft per record or multiple drafts.
Bring #draft? back as an alias of #has_drafts? for the single draft scenario that I mention
above.
Change .has_draftsman back to .has_drafts. There is no real conflict there because that
is a class-level method.

There is probably some opportunity to refactor this logic into includeable modules, kind of the way that concerns work in Rails. Maybe it should be architected so that the single draft and multiple draft strategies are their own modules that mix in common logic and implement the custom bits that each needs.
If you don't have the bandwidth to make these changes, I can probably get around to it eventually. I'll be honest though: I don't need this feature myself, so I don't have much motivation myself (though again, I'd love to see support for it).
Let's discuss. Anyone, jump in.

@chrisdpeters I have cloned the latest Dratfsman with Rails 5.1 support and rewritten the changes again and separated single and multiple drafts functionality as you suggested. Have a look at my PR #71 .

Closing this in favor of #71.


auto-update: use image's arch

Use the architecture of the local image when looking for a new image on
a registry.  It seems to be common practice on ARM to tweak the
architecture choice to pull the correct image.
Fixes: #6613
Signed-off-by: Valentin Rothberg<EMAIL_ADDRESS>

LGTM

/hold

LGTM but one of the tests is stumbling around.

LGTM, for the record

/hold cancel


Check breaking changes

Thanks @thomasvl, have been using that locally - will start opening PRs for the changes.


As a library member I want to view a list of requests I’ve placed

What is it and who's it for?
Library users
User story
In order to plan my research time efficiently
As a Researcher
I need to see what I've requested from the library.
Feature: 4. As a library member, I want to view a list of requests I’ve placed
Acceptance criteria
Scenario: I view a list of my active requests under my account
Given that I have placed a number of requests previously
When I login I can view my account
Then I can select to see a list of the requests I’ve made
Implementation
Testing and tracking

Have you talked to Tacey?
Test plan
Will you need to set up additional tracking?
What is the expected life span for tracking?

Measurement
Related KPIs (e.g. breadth of collection accessed, reading time, etc.)
Other considerations
<---Delete as appropriate--->

Impact on URL design
Cardigan documentation

Closing as done; you can see a list of requests on your account page. If we need further tweaks we can open a new ticket.


Consider building an ES6 Module as well

Matt from Burlington, VT office here. Howdy team!
I've got a feature request: publish your package as an es6 module. I believe you can do this side by side with an es5 build (nwb does).
The reason: tree shaking. Webpack 2 offers tree shaking, but in order to take advantage of the feature, the module needs to be published as an ES6 module.
Obviously this is a huge package as it includes a ton of SVGs. It would be great if our users only had to pay the cost of the icons they were seeing.
I think all it might take is updating your .babelrc: https://medium.com/modus-create-front-end-development/webpack-2-tree-shaking-configuration-9f1de90f3233#b26a
Disclaimer: this is my first foray into webpack 2 and I don't know much about publishing modules. I just created a component library and was surprised that my library clocked in at >1MB and was further surprised to see that 450k of that comes from react-entypo.
BTW, I found this library organically, meaning Google, while looking for a way to get the new tracksuit icons in React. Was surprised to see you guys as the owners. Nice work!

Hi Matt!
I totally get the issue you're having.  May I ask how you're importing the icons you need?
If you import the icons specifically they shouldn't take up so much space.
Like so:
import EntypoArrowBoldRight from 'react-entypo/lib/entypo/ArrowBoldRight';
import EntypoCalculator from 'react-entypo/lib/entypo/Calculator';

We recommend this approach.  I see the examples aren't very good at explaining that and we can work on updating them to be more specific.
Does that help?

TL;DR: feel free to kill this issue! ES6 modules aren't all the way there yet and above solution works well enough
Though above solution works, I was still interested in experimenting with webpack tree shaking and so looked into getting a PR together that also built an ES6 module (basically transpile all code down into ES5, but use ES6 import/export instead of require). However upon investigating it looks like support for this sort of thing isn't official yet:
https://github.com/nodejs/node-eps/blob/4217dca299d89c8c18ac44c878b5fe9581974ef3/002-es6-modules.md#51-determining-if-source-is-an-es-module
and there are some recent reported issues with the not-yet-official approach:
https://github.com/infernojs/inferno/issues/928
So, someday!

It can simply be done with Webpack2's built-in tree shaking feature for es2015 modules. All you need to do is create a custom lib/react-entypo.js in your repo:
export Entypo500px from 'react-entypo/lib/entypo/500px';
export Entypo500pxWithCircle from 'react-entypo/lib/entypo/500pxWithCircle';
export EntypoAddToList from 'react-entypo/lib/entypo/AddToList';
// full list `ls node_modules/react-entypo/lib/entypo | pbcopy`
...

Then inside webpack.config.js, redirect your 'react-entypo' imports:
externals: {
  'react-entypo': path.join(__dirname, 'lib/react-entypo'),...

That is it.
I tried a plugins for commonjs lib shaking, webpack-common-shake, but somehow it failed to shake. It's probably because the babel-transformed code at node_modules/react-entypo/lib/index.js is too complex for the plugin to handle.
Would be nice if we can just remove src/ from .npmignore providing users an option to import es code directly.


Add missing ol.style.AtlasManager goog.require

Without it, I've the following error:
mkdir -p schweizmobil/static/build/
node tasks/build.js build.json schweizmobil/static/build/build.js
info schweizmobil Parsing dependencies
info schweizmobil Compiling 426 sources
ERR! compile /xxx/node_modules/openlayers/src/ol/style/regularshapestyle.js:384: ERROR - Property hitImage never defined on info
ERR! compile       this.hitDetectionCanvas_ = info.hitImage;
ERR! compile                                       ^
ERR! compile
ERR! compile /xxx/node_modules/openlayers/src/ol/style/regularshapestyle.js:386: ERROR - Property hitImage never defined on info
ERR! compile           [info.hitImage.width, info.hitImage.height];
ERR! compile                 ^
ERR! compile
ERR! compile /xxx/node_modules/openlayers/src/ol/style/regularshapestyle.js:386: ERROR - Property hitImage never defined on info
ERR! compile           [info.hitImage.width, info.hitImage.height];
ERR! compile                                      ^
ERR! compile
ERR! compile
ERR! compile 3 error(s), 0 warning(s),
ERR! compile 96.7% typed
ERR! compile
ERR! Process exited with non-zero status, see log for more detail: 3

This is strange. Adding a goog.require to this file doesn't make too much sense, does it?

ol.style.RegularShape#render_ takes an ol.style.AtlasManager param; what is strange to me is that the compiler didn't complain about the lack of goog.require

ol.style.RegularShape#render_ takes an ol.style.AtlasManager param; what is strange to me is that the compiler didn't complain about the lack of goog.require

To me that doesn't mean a goog.require is required.

This error is triggered by a custom interaction that requires ol.style.RegularShape.
I will try the reproduce the error with a minimal example.

ol.style.RegularShape#render_ takes an ol.style.AtlasManager param; what is strange to me is that the compiler didn't complain about the lack of goog.require

To me that doesn't mean a goog.require is required.

But the compiler should include src/ol/style/atlasmanager.js anyway to be able to check ol.style.AtlasManager#add return type. (called in render_)

But the compiler should include src/ol/style/atlasmanager.js anyway to be able to check ol.style.AtlasManager#add return type. (called in render_)

Ok I understand. I think this is good to merge.

Note: I was not able to reproduce the issue in ol3, only in my project. My closure-util config file must be wrong


[BUG] Dashboard values cannot handle base64 '=' padding characters

Addresses #369
Utilize the parts option to only split once to ensure correct key=value decoding behavior.
See Hex docs
Matches what wash does. See wash

I love how simple this solution turned out to be.

I love how simple this solution turned out to be.

There's still time to write it all with a parser combinator... 😈

I love how simple this solution turned out to be.

There's still time to write it all with a parser combinator... smiling_imp

Or better yet, create the "properly splits key=value pairs" programming language. It'll be huge.


Make image-size selectable in "image" URLs

The "image" button generates a URL to an image of the graph.  It would be nice if fields could be added to the URL that change the size.  Currently I'm using the IMG HEIGHT field to shrink the field after the fact.  This isn't as efficient.

Closed due to age and there being a potential work around


Composite showing ready status when one of the resources cannot render

In porting over platform-ref-aws to P&T, I noticed that the Helm releases were unhealthy, but the overall composite showed healthy:
kubectl get composite
xeks.aws.platformref.upbound.io/borrelli-function-test-9pq6z-62qdh   True     True    xeks.aws.platformref.upbound.io   70m

This helm ProviderConfig and KubernetesClusterAuth not generating was due to a patch that needed a field Type added to it:
        transforms:
                - type: string
                  string:
                    type: Format # missing
                    fmt: "%s-ekscluster"

  Warning  ComposeResources         4m48s (x43 over 70m)  defined/compositeresourcedefinition.apiextensions.crossplane.io  Pipeline step "patch-and-transform": cannot render FromComposite patches for composed resource "kubernetesClusterAuth": cannot apply the "FromCompositeFieldPath" patch at index 1: transform at index 0 returned error: string transform could not resolve: type  is not supported for string transform type

I believe this composite should have shown that it could not render a resource:
Status:
  Conditions:
    Last Transition Time:  2023-09-30T07:11:06Z
    Reason:                ReconcileSuccess
    Status:                True
    Type:                  Synced
    Last Transition Time:  2023-09-30T08:19:07Z
    Reason:                Available
    Status:                True
    Type:                  Ready

I believe this should be fixed with https://github.com/crossplane-contrib/function-patch-and-transform/pull/81?
Anyways, I created a PR for a similar problem that makes a composite show to be ready although some resources are skipped due to missing required patches: https://github.com/crossplane-contrib/function-patch-and-transform/pull/137.


Allow different headings and captions in outline and bookmark

Closes #1889, closes #1295, implements https://github.com/typst/typst/pull/1892#issuecomment-1729119959.
Summary
Added a (non-exposed) outlined-content element to be used for figure captions and headings. It is created internally by casting the dictionary
(
  document: [...],
  outline: [...],
  bookmark: "...",
)

where only the key document is required for the default value. If any of the other keys are omitted, outline is derived from the default value, and bookmark from the outline value. The bookmark value has to be of a string, while the other two can be any content. If this dictionary is not used when passing the body of a heading or figure caption, the element is still created implicitly with all fields having the same value (bookmark being converted to a string).
Example

Code
Output

#show outline: set heading(outlined: true)

#outline(title: (
  document: [Outline],
  outline: [Outline in Outline]
))

#outline(title: "Figures", target: figure)

#heading((
  document: [Document Heading],
  outline: [Outline Heading],
  bookmark: "Bookmark Heading"
))

#figure(
  rect(),
  caption: (
    document: [A rectangle],
    outline: [A rect in the outline]
  )
)

Notes

The title parameter of outline and bibliography elements also supports this new type.
You can currently still specify the bookmark option for figure captions, even though it won't be displayed anywhere.
In show rules, the heading.body and figure.caption.body elements are now of the type outlined-content which always has the fields document, outline and bookmark available. The type itself also has a show rule and returns the document value by default.
I decided to only go for the document / outline / bookmark style and not also for long / short because long would only be a synonym for document, and because bookmark inherits its value from outline, so short would also basically only be a synonym for outline (when bookmark is not set).

To-do

[ ] Decide on name of element (I don't really like outlined-content but couldn't think of anything better)
[ ] Decide whether the outlined and bookmarked parameters of headings should somehow be replaced by this
[ ] Maybe improve documentation

Doesn't this make heading's outlined and outlined, and figure's outline parameters obsolete? Because with this PR I feel like this could be done simply by setting the corresponding argument to none or some content / string.

That's what I meant with the second to-do item.
One drawback is that something like show heading.where(level: 3): set heading(bookmarked: false) wouldn't be possible anymore, or at least not as easy. This is also the case for things like adding the outline in the outline (or removing the bibliography, etc.), as it is now usually done via show outline: set heading(outlined: true)

Regarding the design, in principle this is already possible for arbitrary content in any context using state, at least for the outline. I wonder, therefore, if the only further step we need to take is to expose such an API (which applies to more general contexts as well) but more ergonomically. Though I do understand the appeal of a more minimal API, but maybe this is currently a bit too minimal / ad-hoc? Or are there going to be extra features within heading and figure themselves which integrate with / are aware of the dictionary separating normal, outline and bookmark content?

Regarding the design, in principle this is already possible for arbitrary content in any context using state, at least for the outline.

Indeed. It would still require something for the bookmarked title though.

I wonder, therefore, if the only further step we need to take is to expose such an API (which applies to more general contexts as well) but more ergonomically.

Do you mean something in the likes of (exact design aside)
#heading(context if inside(outline) [ ... ] else [ ... ])

which would resemble the behavior of the commonly used in-outline state but internally? I agree that something more generally applicable would be nice.

Or are there going to be extra features within heading and figure themselves which integrate with / are aware of the dictionary separating normal, outline and bookmark content?

A nice to have would be to allow configuration of whether the heading number should be part of the bookmarked title, but that doesn't seem to be something that can be implemented nicely with either design.

I generally like the context-based solution, though I see how even just context if inside(outline) [ ... ] else [ ... ] might be a bit alienating and feel too complex for inclusion in the non-template prose part of a document.
As for the bookmark: Is it truly necessary to distinguish between the outline and the bookmark text or could the bookmark just always resolve to the outline variant?

It seems to be that we need more discussion (ideally on Discord) before settling on a solution, so I'll close this for now. Thanks still!


text-[0.7rem] is generating wrong CSS

Interactive docs: View
Tailwind play: View

Currently this is intentional. See #935.

@chu121su12 Maybe we could do an auto-detection when the context is not specified?


[lockfile] When updating store-paths, we should also update the resolved field

Summary
How was it tested?

Current dependencies on/for this PR:

main

PR #1530   👈

This comment was auto-generated by Graphite.


Accessing HttpContext.Current.User.Identity.Name in the DbContext

Hello, I'm going to use the UserName for tracking Created and Modified fields. To do that I have referenced to the System.Web assembly directly inside DbContext:
public void auditFields()
 {
            var auditDate = DateTime.Now;
            foreach (var entry in this.ChangeTracker.Entries<BaseEntity>())
            {
                switch (entry.State)
                {
                    case EntityState.Detached:
                        break;
                    case EntityState.Unchanged:
                        break;
                    case EntityState.Added:
                        entry.Entity.CreatedOn = auditDate;
                        entry.Entity.ModifiedOn = auditDate;
                        entry.Entity.CreatedBy = HttpContext.Current.User.Identity.Name ?? "anonymouse";
                        entry.Entity.ModifiedBy = HttpContext.Current.User.Identity.Name ?? "anonymouse";
                        break;
                    case EntityState.Deleted:
                        break;
                    case EntityState.Modified:
                        entry.Entity.ModifiedOn = auditDate;
                        entry.Entity.ModifiedBy = HttpContext.Current.User.Identity.Name ?? "anonymouse";
                        break;
                    default:
                        throw new ArgumentOutOfRangeException();
                }
            }
}

It works, But it's tightly coupling the DbContext with HttpContext which is not a good idea in case we'll expose the DbContext to a non-web environment.
So I use this way:
public class ApplicationDbContext :
        IdentityDbContext<ApplicationUser, CustomRole, int, CustomUserLogin, CustomUserRole, CustomUserClaim>,
        IUnitOfWork
{
	public ApplicationDbContext()
            : base("ConnectionString")
        {
        }
        public ApplicationDbContext(string userName)
            : base("ConnectionString")
        {
            UserName = userName;
        }
	//Other codes
	public string UserName
        {
            get;
            private set;
        }
	public void auditFields()
 	{
            var auditDate = DateTime.Now;
            foreach (var entry in this.ChangeTracker.Entries<BaseEntity>())
            {
                switch (entry.State)
                {
                    case EntityState.Detached:
                        break;
                    case EntityState.Unchanged:
                        break;
                    case EntityState.Added:
                        entry.Entity.CreatedOn = auditDate;
                        entry.Entity.ModifiedOn = auditDate;
                        entry.Entity.CreatedBy = UserName ?? "anonymouse";
                        entry.Entity.ModifiedBy = UserName ?? "anonymouse";
                        break;
                    case EntityState.Deleted:
                        break;
                    case EntityState.Modified:
                        entry.Entity.ModifiedOn = auditDate;
                        entry.Entity.ModifiedBy = UserName ?? "anonymouse";
                        break;
                    default:
                        throw new ArgumentOutOfRangeException();
                }
            }
	}
}

And in the Ioc config project:
ioc.For<IUnitOfWork>()
                   .HybridHttpOrThreadLocalScoped()
                   .Use<ApplicationDbContext>()
                   .Ctor<string>().Is(HttpContext.Current.User.Identity.Name);

But when I run the application I'll get this error in above line:
Object reference not set to an instance of an object
It seems that it can't inject HttpContext.
Any idea?

HttpContext won't be available during EF migrations in Application_Start.


Peering Request

Full Name
i3D.net
ASN
49544
PeeringDB Integration

[X] My PeeringDB Entries are current
[ ] Peer at ALL EXCHANGES (and skip the Peer Address(es) field below)

Peer Address(es)
<IP_ADDRESS> 2a00:1630::61
Multihop

[X] Multihop Peering Request

Code of Conduct (TODO)

[X] I agree to follow this project's code of conduct

The peerings are up on our side:
    Neighbor        V         AS   MsgRcvd   MsgSent   TblVer  InQ OutQ  Up/Down State/PfxRcd   PfxSnt Desc
    <IP_ADDRESS>   4      49544         0         0        0    0    0    never      Connect        0 i3D.net
    Neighbor                              V         AS   MsgRcvd   MsgSent   TblVer  InQ OutQ  Up/Down State/PfxRcd   PfxSnt Desc
    2a00:1630::61                         4      49544         0         0        0    0    0    never      Connect        0 i3D.net

Our details:

asn: 6447
ip4: <IP_ADDRESS>
ip6: 2001:468:d01:33::80df:3369

collector fqdn: route-views5.routeviews.org


[path] returns full absolute path, can we have a little more control or relative ?

Hi,
I am importing a image using require from /src/client/info/app-1/assets/images/backgroup.jpg
Problem is that this file is now being copied to my dist folder as /src/client/info/app-1/.... etc
I want to be able to copy it to /dist/app-1/.... etc which is where my index.html is.
I am using
      {
        test: /\.(png|jpe?g|gif|svg|woff|woff2|ttf|eot|ico)$/,
        loader: 'file-loader?name=[path][name].[hash].[ext]'
      },

So of course the [path] is returning the full path, but this path isn't fixed, is there  a way to use a relative [path] or manipulate the [path] on the fly by removing /src/client/info from the url ?
if I remove the [path] it ends up in the root which isn't what I am looking for either.
A little confused, any help really appreciated
Thanks

Can this not be solved by removing [path] and using outputPath (+publicPath if needed)?

Thanks @BTMPL , but I cant hard code the app-1, is this is dynamic and will change. It would be great if i could do a SubString :-)
I also found I can pass in the querystring "context" but the problem here is that i can do a "../../" but this doesn't from the right hand side.
The [path] is exactly what I need but its padded with some things I wish to remove..

@appsolutegeek I had a similar problem, where the emitted files would be placed in a directory with a random name (for cache busting purposes) and the bundle would be placed in a different location that the app base URL. To solve that I just made the app accept assetsUrl as a param (with redux store hydration) and I add it  before the relative image url.
const image = require('image.jpg');
// later on
render() {
  return <img src={this.props.assetsUrl + image} alt="" />
}

Thanks @BTMPL, yep thats probably not my case though.

got the same problem today.
solved it like this:
{
	test: /\.(png|jpg|gif|svg)$/,
	loader: 'file-loader',
	options: {
		**context: path.resolve(__dirname, "./src/client/info"),**
		name: '[path][name].[ext]?[hash]'
	}
}

seems like file-loader used 'context' as root of the 'path' witch can be override by options
P.S. use webpack2 .  hope helpful.

got the same problem today.
solved it like this:
{
	test: /\.(png|jpg|gif|svg)$/,
	loader: 'file-loader',
	options: {
		**context: path.resolve(__dirname, "./src/client/info"),**
		name: '[path][name].[ext]?[hash]'
	}
}

seems like file-loader used 'context' as root of the 'path' witch can be override by options
P.S. use webpack2 .  hope helpful.

Nice!!!!, This seems to work! :-)
Great! Thanks.


Title/Body Positioning and LabelBox Width Not Able to Be Manipulated

@lucaslcode @talamaska hello - This package has been working great, but it seems as if I'm unable to manipulate the positioning of title/body texts within the overlay, as well as manipulate the labelBoxes to fit the width of my paragraph. I have attempted to manipulate the labelBoxPadding property, but that did not seem to provide any solution. Is there anything you suggest to help fix this problem?
Thanks!

Manipulating the width of the label box was never intended, it could lead to really unwanted behavior and hard to control side effects. The position of the label box is somewhat pre-calculated depending on the position of the focused widget position. Look at line 30 in stepper.dart. Place shorter texts or manipulate the textStyle, like making smaller font.


Fix: Typing requires extra spaces #127

Fix: Typing requires extra spaces #127
Discord Username: @sudo-adduser-jordan
What type of PR is this? (select all that apply)

[ x ] 🐛 Bug Fix
[ x ] 🧑💻 Code Refactor

Description

Extensive refactor
Typing will now behave as expected
Disabled backspace
Removed results from /race page
Removed dead code

Related Tickets & Documents

Closes #127

QA Instructions, Screenshots, Recordings

Add code snippet.
Navigate to /race page.
Type to end of snippet.
Navigate to  /race. page.
Hold enter to end of snippet.
Navigate to /race page.
Hold space to end of snippet.

https://github.com/webdevcody/code-racer/assets/108599131/5efb43b6-0439-403e-9a7d-112f9860b170
Added/updated tests?

[ x ] 🙅 no, because they aren't needed

Additional Comments
This should cover all edge cases, including unformated code.
Mash the keyboard and let me know how it goes.
May need to be optimized. Brute force solution.
Open to code review / suggestions / opinions.

Currently,there is no option to upload html. This should be fixed in another issue.
HTML should not render and will need to be escaped before insert into database.

Currently there is no support for HTML. Please sync your fork, delete you Docker volume and try again. I am unabled to upload HTML to database. A new issue may need to be created when HTML support for is added.

https://github.com/webdevcody/code-racer/assets/108599131/27d3ef9d-c97f-4ec7-8aa2-66be62425e1a

https://github.com/webdevcody/code-racer/assets/108599131/691c8a39-3b12-4240-9ecc-e528af28f2d7

Updated with HTML snippet with line breaks.
https://github.com/webdevcody/code-racer/assets/108599131/d5b1e31d-c442-45ff-b8dd-48b67d50a6f8


Project Ideation

Overarching Features:
Calendar (Home)
Personal Tasks
Assignment
Presentation
Idea:

Assignment with calendar, similar to GitHub pages
Under each assignment
provides place for each user to comment once
after a certain due date, no more comments can be placed, but non-empty comments can be updated
teacher account can set assignment to include what (i.e. link)
accounts are organized into periods, under an assignment going to a periods tab pulls up a list of every single person in that period
presentation feature can be enabled
queue is created, and students from personal computer can be add and remove themselves from queue, sort of like GitHub scrum board with columns for done and yet to go and queue
will automatically fetch blog page content and display on board, so everyone can see from computer
comments built in, no more issue problems
need to add

This group definitely thought about how their project would help Mr. Mortensen, as they targeted a very real problem in the classroom that I related to, and that has been happening this year.
They had drawings of their design, which included rough outlines of where things would go on their site
They talked about how they would store the data for users, including having a queue for students waiting to do reviews, as well as having personal data that each student could store on their account via the website.
They showed some of both their frontend and backend running. This included menus and different sections on the frontend, and connecting users together for a screensharing feature for the backend.
This team definitely did their research, The screensharing feature is really creative, and definitely required a lot of research to learn how to use, and connect users with.

This group definitely knows what they are doing, having plans for their project, having their project address a very real issue in the classroom. and already having a nice portion of their project running.
.9/.9

#
Feedback
Score

1
I like how they picked a problem that affects both Mr. Mortensen and also our CSA class. I also like how they chose a certain technology from Mr. Mortensen's class and chose to improve on it. The problem of screensharing has definitely been relatable, especially during the class Team Teach Review.
0.9

2
They had a couple of online diagrams which showcased the outlines of their project and showed the overall design.
0.89

3
They covered this in their diagrams and talked about having a queue for students which they would try to store in a SQL DB, as well as smaller assignment lists, etc.
0.9

4
Both their frontend and backend for the main feature was running. They showed us a live demo of their tool for screensharing.
0.91

5
The research is evident in the fact that their proof of concept code is already running for the screenshare, which definitely took a lot of research.
0.9

Overall Score: 0.9; I am really excited to see this project during n@tm and maybe even incorporated in Mr.Mortensen's class later in the year.

This group definitely thought about how their project would help Mr. Mortensen by tackling a real classroom problem that I’ve noticed too this year. They had sketches of their design, showing where things would go on the site, and explained how they'd handle data—like a queue for students waiting to do reviews and personal info each student could save on their account. They showed parts of their frontend and backend in action, including menus on the frontend and a screensharing feature on the backend.
I like how they chose a problem that affects both Mr. Mortensen and our CSA class, especially how they took a specific technology from his class and aimed to improve it. The issue of screensharing has been particularly relatable during the Team Teach Review. They showcased online diagrams that outlined their project’s design, including plans for a student queue and assignment lists stored in a SQL database. Both the frontend and backend for their main feature were functioning, and they even gave a live demo of their screensharing tool. Their research really shows, as their proof-of-concept code for screensharing is already up and running, which clearly required significant effort.

I think this project is going in a good direction! The idea of combining a calendar with assignments and using a queue system like a scrum board is very creative, especially for handling screensharing and organizing presentations. I can tell they really thought about how users would interact with it. The built-in comments feature is also very creative because it avoids the whole problem of feedback getting lost. I’m excited to see where this goes, especially with adding the blog page content—it’ll definitely make things more transparent and collaborative.


Add separator to poseidon hash

Look for TODO(#5714) in the codebase.

Closing this as there is not really a notion of "separator" the same way it is in pedersen so having a separate param for it is not necessary. Here is Mike's comment for context:

So Poseidon hashes don't need generators and generator indices in the same way that pedersen does.
With pedersen, to compute pedersen_hash(val1, val2, val3), we do val1G1 + val2G2 + val3*G3. The generator indices that we defined via enums were then used to derive the generator points G1, G2, G3. (Very roughly speaking).
So domain separation with pedersen was quite clever: we could derive a different set of points H1,H2,H3 if we wanted to hash three values under different circumstances.
With poseidon, there aren't generator points, so we have to explicitly domain-separate by passing a domain separator to the hash.
So poseidon(val1, val2, val3) isn't domain separated. We'd need to do poseidon(my_domain_separator, val1, val2, val3).
In the specs & diagrams, I've proposed that we write strings for domain separators, and convert each string to a field.
E.g. poseidon("az_nullifier".to_field, val1, val2, val3). That's just an example. I'm a bit more explicit in the spec as to what the domain separator strings could be.


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc knative-sandbox/channel-wg-leads
/assign knative-sandbox/channel-wg-leads
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping knative.dev/eventing 5c7b553...e7445c5:
  > e7445c5 Enable OPTIONS and CloudEvent Webhook headers (# 5542)
  > ca9e469 Prevent teardown in ugprade tests on failure (# 5624)
  > 8551625 Update actions (# 5627)

/lgtm
/approve


sfm: init at 0.1

Motivation for this change
sfm is a simple file manager for unix-like systems.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Added a release notes entry if the change is major or breaking
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 125217 run on x86_64-linux 1

1 package built:

sfm

It builds and it works, nice app! :+1:


Hiding the proxy itself

Are there any plans on adding an option to hide the proxy server itself?
For example removing the via header. I know this would violate the HTTP 1.1 spec but some people may want this as some sites don't allow connections from proxies.

@OmgImAlexis, we can hide the via header (btw, is it possible with existing Caddyfile syntax?)
Unfortunately, this won't be enough to hide the proxy, as there are numerous other such channels from TCP-related ones(timing, discrepancy between client and proxy tcp implementations, etc.) to WebRTC outright leaking the real IP address via STUN.


Minor optimization

in SVGParse.pas
function ParseFontStyle(AFontStyle: string): Integer;
Could be
function ParseFontStyle(const AFontStyle: string): Integer;

Looks like you ran FixInsight over the sources. Thank you :)

yes In did, we are starting to use SVGIconImageList, so I also ran the FixInsight on it.

Fixed in 2.2.1 version


DiagnosticVerifier: Implement defaulting behavior for lines in expected fix-it replacement range

An audaciously late follow-up to https://github.com/apple/swift/pull/39572#discussion_r795089230.

Default the start line to the line of the expected diagnostic.
Default the end line to the start line.

Previously, the start and end lines of a replacement range were verified only when specified in the expected fix-it, e.g. {{+1:5-10=bla}}. This patch implements a sensible defaulting behavior for lines in an expected replacement range and thus enables unconditional rigorous full-range verification, which I believe is essential going forward. No noticeable difference is visible or expected performance-wise:

We have fast paths for the common case of an intra-line source range (when the end location is on the same line).
The LLVM source manager exhaustively fills a line offset cache the first time a line number is requested in a given buffer. This already happens when the line of the expected diagnostic is computed.

Test changes are mostly cosmetic.

@swift-ci please smoke test macOS

@rintaro ping

@rintaro ping

Sorry for the delay. I will review this PR this evening.

@swift-ci Please smoke test

Note: Test changes is test case rearrangements (test/Generics/associated_type_where_clause_hints.swift; authored by me) and repositioning of verifications (the rest) for optimal offsets.

@swift-ci please smoke test


Basic support for Curve448

This patch add basic support for Curve448.
It runs at about half the speed of Curve25519, which is acceptable given the key size is twice as big. I don't know how fast it should be, it may be possible to optimize further. I don't know much about optimising bignum arithmetic, so I'd say that what I've done here is "basic" rather than super-quick. In particular, doing naive modular reductions requires two rounds of reduction (and therefore two multiplications) for typical inputs; I'd gladly accept a hint for improving that!
Also up for deciding: what should the validation behaviour be for ECDH public points with Curve448! I know there was lots of discussion on this, with the current IRTF draft saying that Curve25519 implementations SHOULD ignore the top bit in public keys and silently set it to zero, while implying that validation SHOULD be done for Curve448, but it doesn't say if the bottom bits should be validated as well..? I haven't been following the discussion, but I'm sure someone will chip in with the right answer.
Supported: ECDH seems to work fine!
Not yet done: tests, optimising.

Automatic CI verification build not done, please verify manually.

I've added a test to test suite now, using the test vectors from the standard: https://tools.ietf.org/html/draft-irtf-cfrg-curves-11
My code agrees! That's a relief.

Link to initial feature request on the support forum: https://tls.mbed.org/discussions/feature-request/support-for-ed448-goldilocks

OK, I've optimised it now, after working out an efficient modular reduction formula. I couldn't track down Mike's formula in any of his papers, so I don't know how Curve448 reduction is "meant" to be done, but I like the solution I came  up with, which uses just three additions.
On my machine, a full Curve25519 DH exchange takes 5.53 ms (rather, 100 of them take 553ms); that time includes two lots of public key generation and two lots of secret generation. I measure Curve448 to be 12.2 ms.

Sounds good! Did you test your reduction routine on both 32 bit and 64 bit targets?
It would be great if you could integrate Curve448 to programs/test/benchmark.c in the same way Curve25519 is. That would allow easy benchmarking for everyone, including heap usage (which I suspect will be smaller that for NIST P-384).

Good idea, I've just added support to programs/benchmark. It comes out at 54 handshakes/s on my machine, compared to 115 handshakes/s for Curve25519 (ECDHE). Sadly it's a tiny bit slower than P521, which I'd expect it to beat, and P384 has the same speed as Curve25519, so maybe our Montgomery routines are a bit slow in general. I don't mind though! A millisecond here or there during connection establishment is utterly unimportant to my application.
I hadn't tested on 32-bit, but I did run the tests this morning and the test vectors pass there too. I've also just tested on Windows, and using valgrind on Linux to make sure there aren't any overruns of the bignum limbs.
Finally, I posted a couple of questions to the "Modern crypto" mailing list, which confirms that we don't need to worry about point validation for public curve points, and that the reduction formula I came up with is good to use.

It's been a little while now since there's been any movement in this pull request.
Some news from yesterday: curve448 has now been standardised! https://tools.ietf.org/html/rfc7748
It's a shame that the TLS document has just expired: https://datatracker.ietf.org/doc/draft-ietf-tls-curve25519/

Yeah, sorry, we've been busy with other things.
The TLS draft that has just expired is superseded by this one which is alive: https://tools.ietf.org/html/draft-ietf-tls-rfc4492bis-05 So the curves (more precisely, the associated DH functions) are still progressing towards inclusion in TLS!

@NWilson - this is just to let you know we're holding off merging this to see what comes out of IETF. As ever, feel free to respond if you think we're neglecting this.

Automatic CI verification build not done, please verify manually.

Thanks. I don't mind waiting, but the Curve448 RFC has been published; even though the corresponding TLS cipher suites are still pending, it would be possible to merge support for the Curve448 primitive, on the same basis as the existing Curve25519 support.
However, I realise it would take time though to look it, and there's little justification until you can ship it to your users as a cipher suite.

@NWilson: I've reviewed and requested a few minor changes. Please let us know if you're willing and able to rework according to those suggestions (otherwise we're likely to do it ourselves in order to finally get this merged). Thanks again!

@hanno-arm Regarding breaking abstraction in the fast quasi-reduction routines, I've been wondering about the same thing and had a hard time making up my mind. Tomorrow I'll write a version that only uses the public MPI API (probably extended to provide a fast "mod 2^n" function) and see if it makes any performance difference. Unless the new version is noticeable slower, I'll switch to that version, as it is indeed cleaner and safer.

retest

Note to gatekeepers:
A ChangeLog entry needs to be added when merging. Quoting @mpg's suggestion from above:
Add initial support for Curve448 (RFC 7748) - only mbedtls_ecp_mul()
for now, integration in other modules to be done later.
Contributed by Nicholas Wilson (#348).

@mpg @hanno-arm If Curve448 is only supported in a low-level function then the feature should default off in config.h. But if I understand correctly, it is supported in ECDH, right? Then 1. that's what the changelog should state and 2. there should be a test case in test_suite_ecdh.data.


Add created_time for ASG

Added created_time for auto scaling groups in order to allow detection
of old obsolete stack versions.
Resolves https://github.com/zalando-zmon/zmon-aws-agent/issues/139

👍

Thanks @oporkka


Get rid of all deprecated code before 1.0 release

We should delete all the code that was deprecated at least 3 months ago before naj 1.0.0 release.
Bonus points for deprecating code in other places, like this one: https://github.com/near/near-api-js/blob/master/src/utils/serialize.ts#L3

@volovyk-s Hey, if no one is currently working on it, may be i can help sparing my free time on this.
Let me know

Hey @zurgl! Thank you, we always need some help.
You can work on this issue, but we will merge it only before the 1.0 release. So there is a risk of conflicts.
Check this one: https://github.com/near/near-cli/issues/751
If you are interested - post a comment there and I will assign you.

@volovyk-s The related issue have already been assigned and link to a PR almost completed. When the 1.0 release his expected to occur ?

Currently, I'm focused on NEAR CLI.
If you want to work on near-api-js - here is a great ticket to work on: https://github.com/near/near-api-js/issues/627


Drop support for swift language version 4.0

This will also simplify slightly the following PR that implements hash(into:).

cool!

@swift-ci please smoke test


Replaces "cmp" with "Buffer.compare".

When reading over the code I noticed that the cmp operation is using > instead of Buffer.compare. The problem is that these operations are not equal (see this gist) and it seems that the buffer comparison may be using the .toString() value of Uint8Arrays for comparison? In any case, I tested the performance for the methods and the result is that Buffer.compare is a lot faster than >. Which is why this PR replaces cmp with Buffer.compare.

Ya that's just leftover from when keys where strings so sounds good!
Can you update the iterators also?
https://github.com/mafintosh/hyperbee/blob/master/iterators/diff.js
https://github.com/mafintosh/hyperbee/blob/master/iterators/range.js

Thanks for pointing those out 😜 . Fixed in https://github.com/mafintosh/hyperbee/commit/dc8853b9afdc35641f51e5d6ba656d9151b4f737

1.1.1


Limiting the number of items displayed

When I open Maccy, I would like to see only like the 10 first element to avoid having all the height of my screen to be filled.
I only see one approach: limiting the number of returned items and taking search field in account, but this means that by using the arrow key I will not be able to manually search the 11th copied item. (1)
This arrow appears when the list is long enough to not fully fit on the screen height.

I wonder if this is possible to have this behaviour by limiting the height of the list. (2)
Edit: See that this feature is implemented and editable via Menu Size preference and this is the approach (1), so the point remain for the point (2).

Duplicate of #229


Meltano elt run fails with a “pipe closed” exception

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/2478
Originally created by @ets1 on 2020-12-09 20:38:49

What is the current bug behavior?
I’m stress testing my meltano installation with an elt run using tap-spreadsheets-anywhere and a custom loader-kafka plugin. I'm finding that after running an elt job full throttle for about 30-45 minutes, meltano consistently fails with a “pipe closed” exception.  Here’s the message I see repeated by Meltano when the error occurs "meltano          | pipe closed by peer or os.write(pipe, data) raised exception."
What is the expected correct behavior?
An ELT run that begins to load data should finish doing so. At minimum I would expect a better error message indicating a root cause for the failure.
Steps to reproduce
I have meltano configured for extremely high throughput on the tap side and a slightly slower loader.  My guess is that without loader backpressure to slow the rate of production of records from the tap - this will eventually happen to any sufficiently long-running/large elt run where tap is faster than loader.
Relevant logs and/or screenshots
I captured this log with PYTHONASYNCIODEBUG env var enabled.
tap-spreadsheets-anywhere | INFO Found credentials in environment variables.
meltano                   | Executing <Handle <TaskWakeupMethWrapper object at 0x7fb78aa93378>(<Future finis...events.py:299>) created at /usr/local/lib/python3.6/asyncio/streams.py:399> took 4.405 seconds
meltano                   | Executing <Handle <TaskWakeupMethWrapper object at 0x7fb78aa93378>(<Future finis...events.py:299>) created at /usr/local/lib/python3.6/asyncio/streams.py:399> took 6.464 seconds
meltano                   | <_UnixWritePipeTransport fd=17 polling bufsize=1786482688> was closed by peer
meltano                   | Executing <Handle cancelled _UnixWritePipeTransport._read_ready() created at /usr/local/lib/python3.6/asyncio/selector_events.py:251> took 0.115 seconds
meltano                   | <_UnixReadPipeTransport fd=20 polling> was closed by peer
meltano                   | <_UnixReadPipeTransport fd=18 polling> was closed by peer
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
meltano                   | <_UnixSubprocessTransport pid=166 running stdin=<_UnixWritePipeTransport closed fd=17 closed> stdout=<_UnixReadPipeTransport closed fd=18 closed> stderr=<_UnixReadPipeTransport closed fd=20 closed>> exited with return code -9
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
meltano                   | pipe closed by peer or os.write(pipe, data) raised exception.
tap-spreadsheets-anywhere | ERROR Pipe to loader broke after 134629 records were written
tap-spreadsheets-anywhere | BrokenPipeError: [Errno 32] Broken pipe
tap-spreadsheets-anywhere | Exception ignored in: <_io.TextIOWrapper name='<stdout>' mode='w' encoding='UTF-8'>
tap-spreadsheets-anywhere | BrokenPipeError: [Errno 32] Broken pipe
meltano                   | <_UnixReadPipeTransport fd=16 polling> was closed by peer
meltano                   | <_UnixSubprocessTransport pid=165 running stdout=<_UnixReadPipeTransport closed fd=14 closed> stderr=<_UnixReadPipeTransport closed fd=16 closed>> exited with return code 120
meltano                   | Extraction failed (120): BrokenPipeError: [Errno 32] Broken pipe
meltano                   | Loading failed (-9): INFO in target
meltano                   | <_UnixReadPipeTransport fd=12 polling> was closed by peer
meltano                   | ELT could not be completed: Tap and target failed
meltano                   | <_UnixReadPipeTransport fd=10 polling> was closed by peer

Possible fixes
I couldn't reproduce this issue with debug enabled so that's an unfriendly workaround.  The write to disk apparently slowed the tap enough to allow the loader to stay current. Realistically - some type of back-pressure that slows the tap based upon how much data is buffered for the reader is likely the only real solution.
Further regression test
Load test religiously?

View 6 previous comments from the original issue on GitLab


Review

New code deserves review — in this case, since this is a new repository, I posted the code directly instead of via PR.
The initial four commits are exactly those found in https://github.com/rust-random/rand/pull/554 (just rebased).
Perhaps @burdges or @vks would care to review based on the state of this repository?

Update: I pushed two commits to fix the Miri issues (hopefully) and fix a portability issue (not covered by tests).

I donno if this needs a separate crate really..

There's more than a few lines here. It also offers another feature: a portable hasher. And it's still a very light crate. I don't personally have any use for this, but I think it's interesting enough to be worth publishing (given that I already did most of the work).

Tests pass now. We have no eager reviewers (not that I expected anything else for this crate), so it makes sense to go ahead and publish 0.1.0.

Looks good! I only have minor comments:

The following names might be more idiomatic: new_with_keys -> from_keys, make_rng -> into_rng.
"This might break the hasher's security." should probably be added to the docs of SipHasher::make_rng.
"It is statistically high-quality, passing practrand tests to at least 4 TiB." should probably be added to the docs of SipRng.
The documentation of the rand_seeder module should probably be extended to include the information from the README. This would help a lot when looking at the library on docs.rs.
The links in the README are somewhat broken.

The docs upload makes Travis fail and should probably be removed:
$ travis-cargo --only nightly doc-upload
uploading docs...
Cloning into 'ghp-import'...
remote: Enumerating objects: 308, done.
remote: Total 308 (delta 0), reused 0 (delta 0), pack-reused 308
Receiving objects: 100% (308/308), 77.66 KiB | 1.32 MiB/s, done.
Resolving deltas: 100% (166/166), done.
remote: Invalid username or password.
fatal: Authentication failed for<EMAIL_ADDRESS>

Ah, thanks for the review; I assumed you were not interested. I will get to this shortly (and maybe deprecate the old method names).


Better documentation for the code is needed

sphinx or readthedocs could work well

Documentation has been add. Requires further iterations.


Remove duplicate links

@NextTurn : Thanks for your contribution! The author(s) have been notified to review your proposed change.

confirmed fix


Full payload building

It might be useful for eleel to build non-dummy payloads. One strategy would be to require the controlling CL to build a payload, and then serve this to all requesters

We have something like this now, but the payloads are invalid post-Capella due to the presence of withdrawals (we can't calculate the state root).
A better solution would be to integrate Besu's engine_preparePayload method, or maybe something from Reth

Besu: https://github.com/hyperledger/besu/pull/4427


[REQ] font example when applying font

Acknowledgement of preliminary instructions

[X] I have read and acknowledged the preliminary instructions.

What idea do you have?
When applying font, bloxstrap shows an example of letters or numbers to show what the font will look like. (idk, maybe its unnecessary but i thought it would be cool)

Duplicate of #1345

Duplicate of #1345
oh, my bad then


Make return() more forgiving

Looks like the nested synth() is breaking the regex for return(). I removed the catch all error, so this should relax things a bit.

Thanks! I'll look into a proper fix as well.


AttributeError: module 'builtins' has no attribute 'interpreter' when you do anything in the debug console

@lovettchris commented on Thu Dec 13 2018
Repro

Create test.py containing:

print("Hello World")

then run "code hello.py" from a console that is configured with an Anaconda version of Python 3.6.
put a breakpoint on that line and press F5
click "Debug Console" and type in "import os"

Actual
Traceback (most recent call last):
  File "c:\Users\clovett\.vscode\extensions\ms-python.python-2018.12.0\pythonFiles\lib\python\ptvsd\_vendored\pydevd\pydevconsole.py", line 449, in get_interpreter
    interpreterInterface = getattr(__builtin__, 'interpreter')
AttributeError: module 'builtins' has no attribute 'interpreter'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "c:\Users\clovett\.vscode\extensions\ms-python.python-2018.12.0\pythonFiles\lib\python\ptvsd\_vendored\pydevd\_pydevd_bundle\pydevd_comm.py", line 1381, in do_it
    msg = _pydev_completer.generate_completions_as_xml(frame, self.act_tok)
  File "c:\Users\clovett\.vscode\extensions\ms-python.python-2018.12.0\pythonFiles\lib\python\ptvsd\_vendored\pydevd\_pydev_bundle\_pydev_completer.py", line 167, in generate_completions_as_xml
    completions = pydevconsole.get_completions(act_tok, act_tok, updated_globals, frame.f_locals)
  File "c:\Users\clovett\.vscod...

Did you mean to move this to the debugger repo?

Yep, sorry about that.

so how did you figure this problem?

@GuKerui it eventually got fixed in ptvsd.


Query parameters in obj[key] format are not loaded or validated

Because of the way Express and qs handle query parameters, obj[key]=value becomes obj = { key: 'value' }. If there's no obj parameter defined in the Swagger spec, the obj value is left undefined. Even once that parameter is defined, obj[key] is not validated (trying to enforce obj[key] is of type "integer", for example).
Fortunately, however, the UI works flawlessly, constructing requests with the proper obj[key] syntax for each defined query parameter.
This is required to use swagger-tools with JSON API.
Example spec (complete with including page as a hack to at least load the parameters, though neither is validated):
{
    "name": "page",
    "in": "query",
    "required": false,
    "type": "string"
},
{
    "name": "page[number]",
    "description": "Requests the given page number, based on `page[size]`.",
    "in": "query",
    "required": false,
    "type": "integer",
    "minimum": 1
},
{
    "name": "page[size]",
    "description": "Requests this many objects in the response.",
    "in": "query",
    "required": false,
    "type": "integer",
    "minimum": 10
}

What version of swagger-tools are you using?  We addressed this already, unless there is a bug in the implementation.

:facepalm: It looks like we weren't as up-to-date as I assumed—we were on 0.9.7. That said, it looks like the results are provided as page[number] and page[size] verbatim, rather than as an object, page. I couldn't find an issue that discussed the changes; was the object version discussed?
Thanks for taking the time to respond to this; sorry for failing to do enough of the due diligence on my end.

Not a problem at all.  This was addressed in #294 and was released in v0.9.11: https://github.com/apigee-127/swagger-tools/blob/master/RELEASE_NOTES.md#v0911-2016-01-14


Add the ddim sampler

Describe the feature you'd like to see:
as I know that one of the next features will be the implementation of animations, I suggest adding the sampler ddim. I had better results with coherence between frames using this sampler in Deforum notebook.
Additional information
No response

Ah, good call. I will do that! Thanks so much for letting me know.

Fixed in 9f354c4ef7c36883e30b6381451d9f85ee650e41


Generating PRN or navigation message only?

Hello guys, I'm writing bachelor's thesis about GNSS SDR simulation and I want to desribe, how this SW works. Can I ask if this code is generating only navigation message or nav message + PRN code (pseudorandom noise)? I guess both of them but I want to make sure. Thx

Both.


copy in most unexported funs and hack environment

Should fix #9 .
Copy in most exported functions from @carlomedina original fork carlomedina/dplyr. Most of these are in R/context.R
This on it's own did not fix things, also did hack that sets mask to dplyr (see pwiser:::context_peek_bare()). This is an absolute hack and means that checks on whether pairwise() is being used in appropriate contexts is no longer being checked...
Also updated README to add note about overlap with more mature package {dplyover} and limitations (pointing to #1).

Awesome, thanks!
Didn't know about dplyover, will check it out.
Are you planning to submit this package to CRAN at some point?

Are you planning to submit this package to CRAN at some point?

Initially I was thinking after getting to issues # 1, 2 and (maybe) 8 might take steps to set-up with CRAN. (Note though that # 1 is a hurdle as current set-up is just modifying copied code from {dplyr} and neither Carlo nor I really have a firm understanding of how masking etc is working -- e.g. see hack indicated above 😅. So were debating rewriting removing dependencies on unexported funs and other things. (Shared publicly perhaps a bit prematurely but figured may as well see if people like idea of and get some feedback -- thanks for opening issue!)
After discovering {dplyover} am a bit less sure what will do with {pwiser} (for reasons now noted in README) and am starting talks with Tim (owner of package). My plan was in the next few weeks to do a deep dive on {dplyover}. If works the way I expect it to, I will likely just devote energy there and see if can help with some of the documentation and maybe giving feedback on interface etc. Tim is a lot further along and has a lot more comprehensive set of functionality (which I think has the possibility of becoming a relatively popular + useful {dplyr} extension.)
But will have a more firm idea after talking with Tim and reviewing dplyover a bit more.

Makes sense!
If there is an overlap of functionality and none of the packages are on CRAN, maybe it makes more sense to join forces and combine functionalities. :)
Either way, looking forward to using them in my workflow!

Yeap, pwiser::pairwise() essentially represents a particular use of dplyover::across2(). Yes, Tim has plans of getting {dplyover} on CRAN, will likely devote energy there.


Database creation

Acceptance Criteria

Create a MongoDB instance

Initialize according to the agreed database schema

Link to subfeature: https://jinaai.productboard.com/feature-board/planning/features/7126964


css: Add nightmode variant for fetching more messages loading indicator

Fixes: #12522
Added white color to the loading spinner that is displayed when more messages are fetched.
The first GIF I just changed the code so that the spinner is displayed all the time so the change can be seen easier.

For the second one, I am not sure why the spinner is not displayed all the times.

Awesome, thanks for fixing!
For the second one, I think what's going on is this:

The actual fetch from the server is extremely fast because it's the dev environment with no latency, so it only spins for a fraction of 100ms before having the data.  It then freezes for a moment while the browser does a rerender to add the newly fetched messages.

This seems not a huge problem but not ideal; users who are self-hosting and have a fast network will likely see this funny behavior as well.  From reading the message_fetch.js code, it looks like we're already calling the message_scroll.hide_loading_older function after doing the request to insert messages into the DOM (it goes through the cont argument).  So I think our options are to add some sort of delay or animation in the hide function, or maybe to try to trigger the browser to finish its repaint earlier?  I think it's worth spending 15 minutes playing around with things like adding a setTimeout(, 0) in exports.hide_loading_older to see if that helps, but it might not be a super solvable problem.
Also, do we need to use rgb in this context, or can we use HSL?  We generally aim for HSL across the codebase.  I notice via git grep 'rgb(' that we have a few things that are fill or similar rules that use RGB; assuming those all support HSL, we should probably convert them all and update our linter rules to ban rgb(; @amanagr has been in the linter codebase and can probably help with that.

sure! Added to my todo list.

@timabbott I tried playing with setTimeout but there is no difference. But I observed that the funny behavior happens only when you scroll very fast, which usually doesn't happen. If you scroll with the speed like searching for a message or reading, then it looks ok.
We don't need to use the rgb here, I used it because there was another rgb above to the place where I added the color. I can add changing the rgbs to hsl on my todo list.


Add a Pharo variant to open a connection with a timeout

In case the destination blackholes (no RST being sent) waiting Stocket standardTimeout is a very long time. Add an overload to use the Pharo sockets directly and allow to specify a timeout.  In the long run I want to have a Context ( https://golang.org/pkg/context) that allows to specify an absolute timeout for a logical operation.

I want to use this in Voyage.

@noha @tinchodias @estebanlm For the replicationSet failover code we shouldn't wait 45 seconds for the first URL to never connect to.