MUMUP-2643 : Prompt users to reauth

When a user pulls a @jimhelwig and leaves their browser open for really really really long periods of time, things get funky. Shib sessions timeouts so things looks like they are working but getting any server side content can be strange. This puts a timeout component in place (placed in the footer) that notifies the user "hey, you need to reauth".

I like this!

Coverage increased (+0.03%) to 33.524% when pulling 1e264e696f5a350b825ab0b9aa6feab3174cc6b7 on utilize-shib.json into 01fe335d39d0f24399870f1090252f34be29ca32 on master.

Will users see this in frame apps too? Just wondering if we need to warn users that any info entered that wasn't saved/submitted might be lost.
Otherwise, just some small tweaks to the wording:
Your Login Session Expired
Please click below to log back in, or close your window to log out.

@jjones770

will other frame apps see this?
If they enable this feature. Maybe we could make this text changeable so they could say something about lose of data?

I can make the text changes, thanks for reviewing!


Icons missing in some resolutions

Icons appear to be missing in some resolutions, when comparing the different directories.
Only one has raised an error so far: 64DPI/djvIconPlaybackReverse.png, when setting the interface size to Small.

Thanks, I just checked in a fix for this.


session: add grace period after extend and DisableIPCheck && login: ZxcvbnLogicComponent

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.


Support "plantuml" languageid for preview

If the extension of a file is .plantuml then preview shows "no plaintext". Please support languageid === 'plantuml'.
The following change fixes the problem:
if (!(editor.document.languageId === 'plaintext' || editor.document.languageId === 'restructuredtext' ||
    editor.document.languageId === 'plantuml')) {

Thank you for your feedback.
I released v0.2.2. Please check.


Brain-Life status page

We should consider creating a page on brain-life that shows

Current status of the brain-life systems
Status of various resource configured for brain-life (project specific resource should be displayed under project page)
Some statistics about the number of tasks running, has run in the last 24 hours, number of users, etc..

Inspirations

https://status.github.com
https://status.uits.iu.edu/
https://osf.io/wfc6u/analytics/

https://status.discordapp.com/


Installed package is empty

Hi,
Looks like after installing the package from NPM i get empty directory.
ls -al ./node_modules/probably-flow-typed
total 44
-rw-r--r--     1 hagai hagai 11357 Oct 25 00:38 LICENSE
-rw-r--r--     1 hagai hagai   578 Oct 25 00:38 .npmignore
-rw-r--r--     1 hagai hagai  2447 Nov 16 11:22 package.json
-rw-r--r--     1 hagai hagai   810 Oct 25 00:38 README.md

also, there is nothing related on .bin directory.

Yeah, because the project is a complete WIP and the NPM package is currently just there to name camp.

ACK, Thanks.


Add conference paper citation to README

Close #19.

Not sure about the commits on this branch :sweat_smile: but the diff looks ok at least...

Looks like my main branch is not clean anymore. :disappointed: I only have "Squash and merge" enabled so there is not risk to pollute the commit history. I'll fix my main branch later.


Promoting SRS use

addressed #16

I'd say that LIDAR data isn't elevation data so this extension doesn't solve your problem.
For now you can either produce an elevation product from the LIDAR or you can make your own extension (preferably informed by this one) for holding the LIDAR data.
There has been talk of an extension for general-purpose coverages but to this point it hasn't bubbled up as a priority. There was a strong urge to solve the elevation problem as quickly as possible.

Ignore the LIDAR part - the source of elevation data isn't relevant here. If I give you elevation data in GeoTIFF format, referenced to EPSG:2193 (real world example: https://data.linz.govt.nz/layer/1768-nz-8m-digital-elevation-model-2012/) , that is going to be hard to convert to GeoPackage.

Because I mismanaged my repo (making a change to jyutzler/.../master instead of a branch), this comment got put in the wrong place.
https://github.com/opengeospatial/geopackage-elevation/pull/18#issuecomment-159172888

This was supposed to have been merged. I must have missed it before.

I though there was no concensus and we were still discussing it...


Acme http challenge custom dns

What this PR does / why we need it:
This PR add a acme-http01-solver-nameservers flag to configure custom DNS servers for the ACME HTTP01 challenges propagation checks.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #4286, fixes #1292
Special notes for your reviewer:
Release note:

Add acme-http01-solver-nameservers flag to enable custom nameservers usage for ACME HTT01 challenges propagation checks.

Any chance to see this PR reviewed and merge soon? This PR fixes #4286, #1292 and likely also #3238. To work around this issue, people are adding unnecessary complexity to their stacks that I think we should avoid.
Thank you! 🙇

I think this will always fail if your Kubernetes cluster is IPv6 only and the target domain is dual stack. Perhaps this isn't an issue, as if a user sets the new flag and has an invalid configuration, it's on their head. However, if you are replacing the default dial context it should be with one that can retry on a different address family.
It would be nice to have an e2e test for the new flag, but it might be awkward to setup, requiring another resolver to be deployed just for this test.

As an aside, if you add a new import you need to update the bazel BUILD files. There is a helper script that will check everything is up-to-date, so you can run ./hack/update-all.sh to ensure the preflight checks for your PR will pass.

Thanks for the info. I'll take a look as soon as I can.

/kind feature


Device Update instance: Missing message route in connected IoT Hub

I am following Create Device Update for IoT Hub resources to create Device Update account and instance. After generation, I find one message route is missing. According to Message Routing,  there should be 4 routes:

DeviceUpdate.DeviceTwinChanges
DeviceUpdate.DigitalTwinChanges
DeviceUpdate.DeviceLifecycle
DeviceUpdate.DeviceConnectionState

But my Device Update instance only shows 3: DeviceUpdate.DeviceConnectionState is missing

Hi @ccli8, DeviceUpdate.DeviceConnectionState is not created and needed with Device Update.
I have also updated the docs to reflect the correct message routes. The changes will be merged by tomorrow.
Closing this issue. But please feel free to open a new issue if there are any other issues in the update workflow.


Add troubleshooting & dev docs

Local build requirements for mac
Formatting command

looks good
do you know if the macos pyo3 issues are still present after this commit 8766fd6d73756dab98dd3049af726d311a65526f ? had you run into these issues yourself?
ideally would make this part as foolproof as possible for python users. would rather solve it in build.rs instead of having them tweak their cargo config

Yea i encountered the issue when trying to build, but not on install. Can check if it can be solved with build.rs instead

looks good
do you know if the macos pyo3 issues are still present after this commit 8766fd6 ? had you run into these issues yourself?
ideally would make this part as foolproof as possible for python users. would rather solve it in build.rs instead of having them tweak their cargo config

Issue is not still present. Can close this


InteractionModelEngine's CommandHandler pool is unsafely destroying handlers

Problem
In the IM engine:
    // Since modifying the pool during iteration is generally frowned upon,
    // I've chosen to just destroy the object but not necessarily de-allocate it.
    //
    // This poses a problem when shutting down and restarting the stack, since the
    // IMEngine is a statically constructed singleton, and this lingering state will
    // cause issues.
    //
    // This doesn't pose a problem right now because there shouldn't be any actual objects
    // left here due to the synchronous nature of command handling, but it should be fixed.

    mCommandHandlerObjs.ForEachActiveObject([](CommandHandler * obj) -> bool {
        obj->~CommandHandler();
        return true;
    });

@mrjerryjohns Is this required for V1.0? Not clear if things work now, and could be better or we have an issue?

Has since been fixed.


Poor contrast for active tab with hidden file names on macOS .env

This might be more me than the theme, but I can not see the .env file at all in the tab.  If there is a setting or an option to enable/disable that would be great. I was not able to find anything obvious.
I have File Colors disabled, and the related issues showed a fix when updated to 2019.1.3

The contrast in the sidebar is fine.

PHP Storm Build 2019.2.4

Related to #99

Hi @adampatterson :wave:, thanks for your contribution :+1:
Looks like this is related (or almost a duplicate) of #99. The problem with VCS ignored files are unfortunately a well-known problem or better named a missing feature from the theme API to better handle situations where multiple color are combined.
I'm still trying to figure out how to solve this tricky design without breaking the theme's appearance and feeling while also keep track of reported problems to the Jetbrains bug tracker in order to fix this within the theme API itself.

Thanks for the quick reply,
Would it help to open an issue with JetBrains?

Any news ?

This is still an ongoing topic and there might be a solution by revisiting the current syntax theme file that might include definitions from the “old“ theme API that are now in conflict with the new theme API, but it requires more reproduction and testing.

Is there any open issue in JetBrains' issue tracker?

Found a workaround:

File | Settings | Version Control | File Status Colors
Select Ignored → Unselect File Status Color

Yes, already explain here: https://github.com/arcticicestudio/nord-jetbrains/issues/57 :)


Add context support

Hello, I made an attempt to add context support lika React has.
Usage:
import { h, render, createContext, useContext, useState } from "fre"

const Context = createContext('initial')

const App = () => {
  const [value, setValue] = useState('hello value')

  return (
    <Context value={'parent'}>
      <Context value={value}>
        <button onClick={() => setValue((value) => value + '1')}>Change</button>
        <Component />
        <Component />
      </Context>
    </Context>
  )
}

const Component = () => {
  const value = useContext(Context);

  return
Hello, {value}!

}

render(
  <App />,
  document.getElementById("app")
)

Codecov Report

Merging #352 (bda8d22) into master (027c25b) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #352      +/-   ##
==========================================
+ Coverage   98.32%   98.43%   +0.11%
==========================================
  Files           8        8
  Lines         778      833      +55
  Branches      194      194
==========================================
+ Hits          765      820      +55
  Misses         13       13

Impacted Files
Coverage Δ

src/hook.ts
99.34% <100.00%> (+0.34%)
:arrow_up:

src/index.ts
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

It looks good to me. We can merge first. Thank you!


The users' avatars in Gitlens use default style, not Github account

VS Code Version: 1.88.0
OS Version: Ubuntu 22.04

As follow image, The commit made by Github's merge shows correct avatar, but other commits show "robo" avatar.

The avatar worked well in my previous VM, but it doesn't works on my new VM. Because previous VM has other issues, I setup a new one.
Is there any extra settings for this?

Please file this issue in the GitLens extension repository. Thanks!


Add muhammad  to yjaf and yjsm repos

Use this issue template if you do not feel comfortable raising a PR with the required changes to files in the terraform/ directory.
Please supply all the requested information, so that your request can be processed as quickly as possible.
Which MoJ repository are you requesting access to (e.g. money-to-prisoners)?
All yjaf-* repos and yjsm-* repos
What is the GitHub username of the person who needs access?
waheedanjum
What is their full name?
Muhammad Anjum
What is their email address?
<EMAIL_ADDRESS>What company/organisation do they belong to (e.g. "MadeTech", "Department for Education")?
NPS (northgate)
What level of access should they have?
Developer
Why is this access being requested?
dev needs access to make app changes
Which MoJ team/person is responsible for this request?
Greg Whiting -<EMAIL_ADDRESS>- Devops for northgate
Review date
2021-12-31

Please approve the access


Failed to build Objective-C

When importing Cards it just says 'Failed to build objective-C library'. Im running the latest xcode and swift versions. Please help as I really want to use this awesome pod!

Can you post a screenshot and an example project ?
Are you using cocoapods or importing manually ?

Worked for me :

Quit XCode
Delete project's temp files located at ~/Library/Developer/Xcode/DerivedData
Delete ProjectName.xcworkspace, Podfile.lock file and Pods folder
Run pod install
Open the newly created ProjectName.xcworkspace file and build

Thanks for the help but that didn't work for me :(

Thanks that worked! Any words on when an update to support Swift 4.2 will come?

Glad you solved your issue !
Now it fully supports 4.2 :D


Generalize the Downloader and DownloadWorkManager API to not sequentially download resource by type

Describe the Issue
context: https://github.com/google/android-fhir/pull/1572#discussion_r1109879492
quoting from @jingtang10
i think we have moved away from the idea that the download work manager needs to download resource by type sequentially. The apis in this interface should really be agnostic to resource type... BUT I do ackowledge that in Downloader.kt we still report the download status by resource type...

Let's generalise this API in a following PR -> this should really be an API that just returns an overall percentage or something similar.

Would you like to work on the issue?
N/A

@maimoonak @f-odhiambo

@anchita-g fyi

Hello @FikriMilano , @jingtang10
I'm interested in this issue but needs more clarification about the exact requirement
Is it about update the return type of getSummaryRequestUrls of the interface  DownloadWorkManager from Map<ResourceType, String> into percentage only?
Or updateing DownloadWorkManager implementing  classes like ResourceParamsBasedDownloadWorkManager to download resource independent of the resource type?
From my understanding of the mentioned comment in the issue description, DownloadState should be updated to be unaware of the resource type?
"If you could clarify that further, I would appreciate it."


Fix sftp_upload

Motivation for changes:
I'm using the format Series Name (Year)/{{Season Number}}/Series Name(Year).ext to rename my series and upload them to the media server with the sftp_uploadplugin.
All was working fine until a a new series appeared and the content wasn't uploaded because of the file [Errno 2] No such file. Another issue is that the original file was deleted from the origin computer
Detailed changes:

Whenever there is a sftp file upload error, return before checking for the file deletion flag
Check if parent directories of the file exist, and if not, create them

Addressed issues:
N/A. Let me know if an issue is needed and I can create it.
Implemented feature requests:

N/A

Config usage if relevant (new plugin or updated schema):
    sftp_upload:
      host: "{? sftp.host ?}"
      username: "{? sftp.username ?}"
      to: "{? sftp.tv_path ?}/{{ tvdb_series_name }}/S{{ tvdb_season | pad(2) }}"
      delete_origin: yes

Log and/or tests output (preferably both):
Before PR
➜ flexget execute --task move-series-server
2021-01-16 21:47:29 VERBOSE  task_queue                    There are 1 tasks to execute. Shutdown will commence when they have completed.
2021-01-16 21:47:29 VERBOSE  filesystem    move-series-server Starting to scan folders.
2021-01-16 21:47:29 VERBOSE  filesystem    move-series-server Scanning folder /home/guilherme/Videos/TV Shows. Recursion is set to False.
2021-01-16 21:47:29 VERBOSE  details       move-series-server Produced 1 entries.
2021-01-16 21:47:29 VERBOSE  task          move-series-server ACCEPTED: `Law.and.Order.SVU.S01E01` by accept_all plugin
2021-01-16 21:47:29 VERBOSE  details       move-series-server Summary - Accepted: 1 (Rejected: 0 Undecided: 0 Failed: 0)
2021-01-16 21:47:29 VERBOSE  sftp_client   move-series-server Connected to localhost
2021-01-16 21:47:29 ERROR    entry         move-series-server Failed Law.and.Order.SVU.S01E01 (Failed to create remote directory ./Videos/TV Shows/Law and Order Special Victims Unit/S01 (Failed to create remote directory ./Videos/TV Shows/Law and Order Special Victims Unit/S01 ([Errno 2] No such file)))
2021-01-16 21:47:29 VERBOSE  task          move-series-server FAILED: `Law.and.Order.SVU.S01E01` by sftp_upload plugin because failed to create remote directory ./Videos/TV Shows/Law and Order Special Victims Unit/S01 (Failed to create remote directory ./Videos/TV Shows/Law and Order Special Victims Unit/S01 ([Errno 2] No such file))

A detail is that the file is also deleted from the machine
After PR
➜ flexget execute --task move-series-server
2021-01-16 21:49:43 VERBOSE  task_queue                    There are 1 tasks to execute. Shutdown will commence when they have completed.
2021-01-16 21:49:43 VERBOSE  filesystem    move-series-server Starting to scan folders.
2021-01-16 21:49:43 VERBOSE  filesystem    move-series-server Scanning folder /home/guilherme/Videos//TV Shows. Recursion is set to False.
2021-01-16 21:49:43 VERBOSE  details       move-series-server Produced 1 entries.
2021-01-16 21:49:43 VERBOSE  task          move-series-server ACCEPTED: `Law.and.Order.SVU.S01E01` by accept_all plugin
2021-01-16 21:49:43 VERBOSE  details       move-series-server Summary - Accepted: 1 (Rejected: 0 Undecided: 0 Failed: 0)
2021-01-16 21:49:43 VERBOSE  sftp_client   move-series-server Connected to server
2021-01-16 21:49:44 VERBOSE  sftp_client   move-series-server Successfully uploaded /home/guilherme/Videos/TV Shows/Law.and.Order.SVU.S01E01.mkv to sftp://guilherme@server/Videos/TV Shows/Law and Order Special Victims Unit/S01/Law.and.Order.SVU.S01E01.mkv

To Do:

[x] Don't check for origin deletion if there is an error on the upload
[x] Create recursive directories if they don't exist on the server

Hi @ianstalk. Thanks for the thorough review. Somehow I read the docs but missed this builtin option from pysftp.
I tested with the makedirs method now and the result is the same.

Hi @ianstalk. Thanks for the thorough review. Somehow I read the docs but missed this builtin option from pysftp.
I tested with the makedirs method now and the result is the same.

Hi @ianstalk. Thanks for the thorough review. Somehow I read the docs but missed this builtin option from pysftp.
I tested with the makedirs method now and the result is the same.

Thanks for the fixes. As the author of this plugin, I dunno how I missed either of these. 😅

Hi @ianstalk. Thanks for the thorough review. Somehow I read the docs but missed this builtin option from pysftp.
I tested with the makedirs method now and the result is the same.

Thanks for the fixes. As the author of this plugin, I dunno how I missed either of these. 😅

Don't sweat about it. Your plugin was a godsend for me, so you have credits! :wink:

Don't sweat about it. Your plugin was a godsend for me, so you have credits! :wink:

Awesome, thanks guys!

Awesome, thanks guys!


rem go thread to add to unschedulable queue

Issue link

#569
What changes have been made

Verification steps

Checks

[X] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[ ] Manual tests
[ ] Testing is not required for this change

/approve


One file missing from coverage

Expected Behavior
All files in a certain directory instrumented and reported on for coverage. Four files are here:

The test suite includes four tests, each of which exercises one of these files. The code within the createFlag.js file is successfully executed:

Observed Behavior
The file actions/flags/createFlag.js is missing from the coverage output. All other files in the entire project (there are 30+ files in various folders) are properly instrumented and reported on:

Environment
https://gist.github.com/crrobinson14/b09ae1d65eade891cdd26c811e940dc9
  "scripts": {
        "test": "cross-env NODE_ENV=test node_modules/.bin/nyc --reporter=text-summary --reporter=html mocha"
   },
  "nyc": {
    "exclude": [
      "config/**/*.js",
      "bin/**/*.js",
      "test/**/*.js"
    ]
  },

This project is NodeJS-only and does not include Babel. There is no .babelrc file in the folder. There are no other exclusions specified anywhere. There are no Istanbul "ignore" comments in any of these files. I have tested using various combinations of "all" and "manually requiring the file" in the test.
I realize this is a mystery that may not be solved in a single response. What I'm asking for here is any ideas or guidance about how I can even begin to debug this issue. The test suite is running 100% properly. I have verified that the code within this file is actually being executed in various ways (e.g. console logging output from it). I can't for the life of me figure out why it's not included in the coverage report.
Where do I start? Is there some way to view verbose output from the instrumenter and reporter to determine where and why it might be getting excluded?

For some reason I can't identify (npm update reported no modules to update, and on a whim I had tried a rm -rf node_modules/.cache to no effect), a complete removal of node_modules and package-lock.json followed by an npm i has resolved this issue.

I have just encountered this problem, the solution that worked for @crrobinson14  does not work for me. I have a file whose coverage reports are not being shown by nyc. I even tried adding a nycrc with just the missing file in the "include" parameter and the result of that was
----------|----------|----------|----------|----------|----------------|

File
% Stmts
% Branch
% Funcs
% Lines
Uncovered Lines

All files
Unknown
Unknown
Unknown
Unknown

----------
----------
----------
----------
----------
----------------

Am i missing anything?

I confirm the bug and how to correct it by @crrobinson14  ;)
Thanks !

I am experiencing the same problem as described by @aneeshmg
Two or three directories that match the glob pattern in my include values do not appear in any of the coverage reports. Explicitly targeting the missing directories returns an empty report.
----------|----------|----------|----------|----------|-------------------|
File      |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
----------|----------|----------|----------|----------|-------------------|
All files |        0 |        0 |        0 |        0 |                   |
----------|----------|----------|----------|----------|-------------------|

Might be worth opening a new Issue to look into this bad behavior.

I am having the same problem. I deleted node_modules and my lock file, and reinstalled all dependencies but no luck.

@tbell511 Did you see the comment the core team made in #980? They're hoping somebody can provide a repo with sample code that reproduces the issue. The trouble is a lot of us are seeing this, but having to move on with workarounds and not always able to provide an example. If you have one it would be great!

@crrobinson14 thanks for the reply.  Yes, I did see the comment but I am in the same boat as most.  My repo is private.  I would be willing and happy to get on a call though with someone from the core team to investigate my repo though.  Maybe a screen share would help them out.
That being said, last night while I was trying to fix the issue I made it worse :( After I deleted my node_modules folder, and lock file, nyc is not covering any of my files.  Nothing changed between the deleting of the node_modules and lock file.  Even if I specify a specific file with include, it doesn't work.
Any ideas on what could have caused nyc to stop covering all files?

I'm not sure if this will help anyone with their specific situation, but I was encountering the same issue described. I enabled strict mode ('use strict') on my files and found my unit tests started failing due a few variables not being initialized with "var". Upon resolving these issues, the missing files were included in the coverage report.

I'm getting this weird experience too. You can use this project: https://github.com/Alberto85ariel13/vts where i'm a collaborator. I'm using nyc with mocha and ts-node/register config for tests.
All mocha tests are passing but nyc is working completely crazy in that some times it convers all files in /src directory but other times it only cover 10 files.
To reproduce this behavior, just keep doing npm run test many times and you will eventually run into the problem.
Don't know how to solve this and becouse i have integration with coveralls.io, some times my coverage data only covers 10 files when my CI runs the coverage workflow.

If this gets fixed I will be super happy. I have had to stop using NYC because of this very issue.

For some reason I can't identify (npm update reported no modules to update, and on a whim I had tried a rm -rf node_modules/.cache to no effect), a complete removal of node_modules and package-lock.json followed by an npm i has resolved this issue.

For me just the rm -rf node_modules followed by npm i resolved the issue. Interesting. Thanks for the tip, @crrobinson14!

My pleasure, @markf-hubdoc-com . For what it's worth, I haven't had this issue recur in a long time. I switched to yarn as a package manager last year. Possibly that had something to do with it?

My pleasure, @markf-hubdoc-com . For what it's worth, I haven't had this issue recur in a long time. I switched to yarn as a package manager last year. Possibly that had something to do with it?

Good to know, @crrobinson14. Still on npm over here - could be due to some code running on older npm (v5.6.0) with Node.js 8. Will keep your comment in mind as we upgrade to Node.js 10 and 12 with the corresponding npm upgrades. Thanks!

I've discovered that when I see this issue, i can resolve it by updating to the latest "sub-dependecies" by running yarn upgrade (i can do this as I run fixed versions for my dependencies)

I faced this issue too. Turns out nyc ignores files which has issues that, in general, won't throw an error either. In my case, i had two functions with same name in my file. This was by mistake, and shouldn't be there. But since JS doesn't throw error for this, I had no idea till I started to check after nyc coverage was missing for this file.
Good option - Use a default linting guide like the one from Airbnb - https://github.com/airbnb/javascript

I faced this issue too. Turns out nyc ignores files which has issues that, in general, won't throw an error either. In my case, I had two functions with same name in my file. This was by mistake, and shouldn't be there. But since JS doesn't throw error for this, I had no idea till I started to check after nyc coverage was missing for this file.
Good option - Use a default linting guide like the one from Airbnb - https://github.com/airbnb/javascript

Quick note, and similar to @ashwani. After using arguments as a variable name (with const, not let), nyc would break and not render any coverage (on that file only, but the rest would be fine).
function()
{
  if (something)
  {
     const arguments = ...
  }
}

It's not something that is raised by linters or Js.

Quick note, and similar to @ashwani. After using arguments as a variable name (with const, not let), nyc would break and not render any coverage (on that file only, but the rest would be fine).
function()
{
  if (something)
  {
     const arguments = ...
  }
}

It's not something that is raised by linters or Js.

I got this error as well, @ashwani-pandey's suggestion pointed me in the right direction. One of my files wasn't getting picked up despite having 100% coverage and passing tests. Turns out I had a variable called "package", which I suppose is legal but ill-advised. If you have a file that refuses to show up in your coverage list, comment all code out and rerun cover, if the file shows up, you likely have a soft error somewhere.

I ran into this issue today. Deleting node_modules and package-lock.json did not solved the issue in my case. I undid my recent changes & could see the same file appear in the reporting again. So, I checked the recently added method's content. There was a variable with the name interface. It was causing the issue. So, I renamed it to _interface(was checking) & it solved the issue. So, I guess, files missing from report has also to do something with some kind of reserved names.

I had a similar problem with a file not showing in coverage. The problem was a line that was something like
let x = y * 001;
The 001 for some reason stopped the file from being included.


Tag Filtering not working in GovCloud

We are using Cloud Custodian for tag Enforcement. We have several AWS accounts, one that is in the GovCloud. Lambda, RDS, and Elasticache are all returning incorrect results when running within the govcloud. Here is an example:
  - name: elasticache-tag-compliance-notification
    comments: |
      The following elasticaches are either have an incorrect Group or the Group doesn't exist
    resource: cache-cluster
    filters:
    - type: value
      key: tag:Group
      op: ni
      value: ["value_1","value_2","value_3","value_4","value_5","value_6","value_7","value_8","value_9"]

In our normal accounts, this filter easily filters out any value for the 'Group' tag that doesn't match up. However, in govcloud, this returns 100% of the resources located within a resources within one of the resources above:
custodian run --output-dir=/opt/cloud_custodian/logs/ custodian run --output-dir=/opt/cloud_custodian/logs/ /opt/cloud_custodian/reports/absent_report.yml --cache-period 0 --region us-gov-west-1 -p elasticache-tag-compliance-notification -d
2018-06-20 18:30:19,549: custodian.policy:INFO policy: elasticache-tag-compliance-notification resource:cache-cluster region:us-gov-west-1 count:44 time:2.81

Please advise if there is any sort of special configuration that I need to do to get these resources working in govcloud.

that implies a missing api in gov cloud, I'd contact your aws account rep wrt to the availability of the resource group tagging api in that region. we use that api preferentially for resource tags whose services apis would otherwise force us to fetch tags per resource, as it gives us a 20x api call count reduction vs the native service api.


Cannot use the hoodie playground sample app

Hi all,
I followed all the steps described in the Hood.ie docs and created the sample app.
Starting the hoodie server was not a problem.
When I try to sign-up in hoodie playground sample app - I get the following error in the console:
Unhandled promise rejection Promise {_isHoodiePromise: true, done: function, fail: function, always: function, progress: function…}_isHoodiePromise: true_progressCallbacks: Array[0]always: function always(callback) {catch: function catch_(error) {done: function done(callback) {fail: function fail(callback) {progress: function progress(callback) {then: function (onResolve, onReject) {__proto__: Promise[[PromiseStatus]]: "rejected"[[PromiseValue]]: HoodieErrorconstructor: function HoodieError(properties) {arguments: nullcaller: nulllength: 1name: "HoodieError"prototype: Error__proto__: function Empty() {}<function scope>message: ""_design" is invalid object type. lowercase letters, numbers and dashes allowed only. Must start with a letter."name: "HoodieObjectTypeError"rules: "lowercase letters, numbers and dashes allowed only. Must start with a letter"stack: (...)type: "_design"__proto__: Error
I'm using Apache CouchDB 1.6.1
Please help resolving this issue...
Idanb11

These are warnings, not errors. You can ignore them, we'll get rid of the Unhandled promise soon, sorry for the inconvenience

@gr2m - thanks for your feedback.
I'm not sure that this is only a warning since this part is related to creating '_design/permissions',
which control the access to the CouchDB - which in turns causes to my sample hoodie app not to have access to the DB - hence the errors i reported above.

When enter the Admin Dashboard and go to users tab - http://<IP_ADDRESS>:6005/#plugin/users
I get the following error:
 GET http://<IP_ADDRESS>:6005/_api/plugins/_changes?include_docs=true&since=0 401 (Unauthorized)vendor.js:5 ab.ajaxTransport.Z.cors.a.crossDomain.sendvendor.js:5 ab.extend.ajaxadmin-dashboard.js:1 badmin-dashboard.js:1 w.requestadmin-dashboard.js:1 w.pulladmin-dashboard.js:1 w.bootstrapadmin-dashboard.js:1 w.connectadmin-dashboard.js:1 cadmin-dashboard.js:1 b.extendadmin-dashboard.js:1 cadmin-dashboard.js:2 (anonymous function)admin-dashboard.js:2 42.../../../helpers/namespaceadmin-dashboard.js:1 eadmin-dashboard.js:1 (anonymous function)admin-dashboard.js:3 86../components/admin-dashboard/entities/adminEntityadmin-dashboard.js:1 eadmin-dashboard.js:1 aadmin-dashboard.js:1 (anonymous function)

Hmmmmm what system are you on? Could you try the following?
1, In your app's folder: rm -rf ./data
2. Make sure no extra CouchDB process is running in the background
3. Make sure you have the latest hoodie-server and hoodie-plugin-users installed
4. hoodie start
If that all doesn't help. Maybe you can give me access to your app's code? Happy to help! We can also pair on fixing this if you like, always glad to get in touch with the community :)

closing this one.


[docs] Update Gradle docs to show how to publish to Maven central

We need to update the internal/builders/gradle/README.md, the actions/gradle/publish/README.md with an example.
@AdamKorcz

Added this as blocker to release the builders


Usage Details

Hi,
Can you share the way to change Logo as per our requirement. The one used in the checked in code has been discontinued.

Hi, Please provide more details on what has changed? You can look into comon/iiththesis.cls to see how the logo is created in LaTeX. I have one more version with Telugu text in it. You can refer to my thesis here.

Yeah you pointed out the exact thing. I want to change the logo to the one that has Telugu text as well. Can you the share the latex copy of your thesis for reference.
I'm unable to understand the way to refer Figures and Tables in the Github Format. This will save my time. Thanks for understanding.

I have added the telugu language line in \node section in .cls file. Thanks for the help.


U256 log may return incorrect values

U256.log implementation may return incorrect values due to rounding errors.

Closing in favor of https://github.com/FuelLabs/sway/issues/6126


TypeError: object of type 'NoneType' has no len()

TypeError: object of type 'NoneType' has no len()
I am getting this error every time trying to run the main.py
Traceback (most recent call last):   File "D:\Fake-Verification-Bot-main\Fake-Verification-Bot-main\main.py", line 95, in <module>     bot = commands.Bot(command_prefix=prefix, description="Fake Verification Bot - Made by Infinimonster#1312 & Astraa#6100", intents=intents)   File "C:\Users\Admin\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\nextcord\ext\commands\bot.py", line 1686, in __init__     BotBase.__init__(   File "C:\Users\Admin\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\nextcord\ext\commands\bot.py", line 218, in __init__     or len(self.command_prefix) > 0

TypeError: object of type 'NoneType' has no len() I am getting this error every time trying to run the main.py
Traceback (most recent call last): File "D:\Fake-Verification-Bot-main\Fake-Verification-Bot-main\main.py", line 95, in <module> bot = commands.Bot(command_prefix=prefix, description="Fake Verification Bot - Made by Infinimonster#1312 & Astraa#6100", intents=intents) File "C:\Users\Admin\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\nextcord\ext\commands\bot.py", line 1686, in __init__ BotBase.__init__( File "C:\Users\Admin\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\nextcord\ext\commands\bot.py", line 218, in __init__ or len(self.command_prefix) > 0

Grab the new config.json. The issue was caused due to upper-lowercase text formatting in the config.json file.


Why does the before-visit event not get called when navigating via history?

This is driving me mad, and I can't understand why this would be the case. Is it a technical limitation, or a design decision?

It's a technical limitation. The purpose of the before-visit event is to give your app a hook for canceling application visits before they begin. In the case of history navigation, the user has already clicked the Back button and the URL has changed. There's no way to cancel that.

The problem is that I can usually get around that using the beforeunload event, but that won;'t work with TL . Oh well :( thx anyway

See #146 for an alternative to the beforeunload event.

Yeah I've seen that, but I want to be able to cancel the event (navigating) based on some behaviour


Cop idea: Limits and Offsets

Describe the solution you'd like
If you have something like this:
Fault.limit(10).offset(100)

and you change the offset to 10,000 you'll see that the number of rows scanned jumps to 10010.
If you're unable to reduce your record set, your best bet may be to replace offset/limit with where clauses.
# You could use a date range
Fault.where("created_at > ? and created_at < ?", 100.days.ago, 101.days.ago)

# ...or even an id range
Fault.where("id > ? and id < ?", 100, 200)

Source: Common Rails Idioms that Kill Database Performance

It's an interesting suggestion. However, the performance bottlenecks and improvements of queries often depend on the context of the application, data, and the actual queries. I'm not sure about applying the same detection method to all applications might not always be accurate or beneficial for users. So I'll close this proposal, but thank you for the proposal!


Basic elgamal encryption gadget

I implemented a basic ElGamal encryption gadget for #21.
Does this look ok?

I have the following concern:
Note that Jubjub is a curve with cofactor 8, which means that the generator of Jubjub forms a group that is not prime-order. This may affect the security guarantee of ElGamal---it requires a prime-order group/subgroup.
One solution, which we are likely going to do, is that our ElGamal always clears the cofactor. That is, instead of choosing a random generator for the ElGamal encryption,
let generator = C::rand(rng).into();

we always multiply this generator by the cofactor.
Or, we can insist on existing groups where the cofactor is 1. Very few curves in arkworks/curves satisfy this requirement, but G_1 of BN254 satisfies this: https://github.com/arkworks-rs/curves/blob/master/bn254/src/curves/g1.rs. But this is not a TE curve so the performance suffers. It seems that, when people are searching for TE curves, many curves naturally have some cofactors.
Now, the second part.
If we clear the cofactor of the generator, we also need to handle the "cofactor" that the plaintext may have. That is, plaintext, which currently consists of group elements, must also be in the prime-order subgroup.
We could not simply multiply the plaintext with the cofactor---decryption would be extremely challenging.
At this moment, maybe all we need to do is to add sanity checks---only allowing plaintext in which all elements are inside the subgroup. This check does not need to be included in the constraint system but can be done outside, and we may have an unchecked version of encryption that disables this check.

Yes, we have to be careful to remain in the prime-order subgroup of JubJub, e.g. using cofactor multiplication. However, I believe the call let generator = C::rand(rng).into(); already does this and hence yields a safe generator? See: https://github.com/arkworks-rs/algebra/blob/master/ec/src/models/twisted_edwards_extended.rs#L359
Regarding the embedding of plaintext in the subgroup: I agree we should add an according sanity check (e.g., multiplying plaintext by the subgroup order) in the encrypt function. How to embed an actual bitstring message is indeed a separate concern.

You are right. The C::rand would scale the element by the cofactor. So this part is done.
Regarding the sanity check, we can use is_in_correct_subgroup_assuming_on_curve.

Should we be exposing El-Gamal, versus something like Cramer-Shoup?
(I don't feel too great about only exposing something that isn't CCA secure)

I think exposing ElGamal is good since in many applications CPA security suffices. And Cramer-Shoup has additional overhead that such applications may want to avoid.

I think having multiple encryption schemes with different properties is valuable (ultimately, the user of the library should decide).
Regarding the sanity check: I just noticed that ProjectiveCurve::Affine (which is used as the plaintext type for the ElGamal implementation) has a bound on AffineCurve which, according to its documentation, already guarantees that the point lies in the correct prime order subgroup. So I believe no check is needed.

I agree. I checked the code. Even if the element is from outside (allocated via canonical deserialization), there is a check for subgroup membership.
https://github.com/arkworks-rs/algebra/blob/e7eeea3f2ac7d621f68089b978097403dd02e91b/ec/src/models/twisted_edwards_extended.rs#L784


Setup status page to monitor outages

This service should run on a different server.
Evaluate existing solutions that are free for open source projects.

They have monitor-specific API keys and it looks like this should work: https://uptimerobot.com/api

It's there: https://stats.uptimerobot.com/JEGW7u8QAv
I also set up a CNAME record for status.keedrop.com, it should become available in a bit.
Right now it sends mail to my personal mail account as well as a webhook to OpsGenie which will deliver a SMS message.


Transform Vite HTML imports for Civet

This PR transforms the index.html file when being used with vite to add outExt?transform to the end of the import so that it gets transformed by the unplugin

I replaced the cheerio dependency with what I think is a reasonable regex HTML parser (for the purpose of detecting <script> tags). However, I can't get this to work on Linux or Windows. I get this error:
[vite] Internal server error: ENOENT: no such file or directory, open '/src/main.civet'

Is this some form of #774? The path is relative in the HTML file, though.
It also seems that, by the time the id is passed to resolveId, it has lost the ?transform suffix. So I think the code might be getting confused because of that... Did you actually get this working in some test environment?

Strange, I did have it working on MacOS. Let me check once again

This change should no longer be required with #786. Also I'm pretty sure I've come across a bug either in Unplugin or Vite regarding how the paths are passed in from resolveId to load. Will investigate further to check which package is causing it


[BUG] Unable to add ContentType to List when Site was created in german.

Reporting an Issue or Missing Feature
I am unable to add a ContentType to a List, when the site was not created in english.
(I'm not really sure whether this is really a bug "here" or some quirky language setting in SPO/M365.)
Expected behavior
The (existing) contentType was added to the (existing) list.
Actual behavior
The Commandlet aborts with an exception, the contentType is not added to the list.
Steps to reproduce behavior
$tenant = "mytenant"
$site = "test3"
connect-PnPOnline -Interactive "https://$($tenant)-admin.sharepoint.com/"
New-PnPSite -Type CommunicationSite `
        -SiteDesign Blank `
        -Lcid 1031 `
        -Title $site `
        -Url https://$($tenant).sharepoint.com/sites/$site `
        -Wait | Out-Null
connect-PnPOnline -Interactive "https://$($tenant).sharepoint.com/sites/$site"
$ct = Add-PnPContentType -Name "Test" -ContentTypeId 0x010100E4E6B3CDBCEA495CB5854144F092741E
$l = Get-PnPList "Dokumente"
Add-PnPContentTypeToList -List $l -ContentType $ct

Additionally, and I'm not sure if this has always been the case:
I can not access the Library called "Documents" (fine, the site is not english..) and I can access the library "Dokumente". However:
➜  get-pnplist "Dokumente"

Title     Id                                   Url
-----     --                                   ---
Documents 0db0a920-38dc-4c80-9b3e-a6b82c6b5b6f /sites/test3/Freigegebene Dokumente

Notice, here how (Get-PNPList "Dokumente").Title yields the result Documents.
The script fails with:

➜  Get-PnPException
Message          : List 'Documents' does not exist at site with URL 'https://mytenant.sharepoint.com/sites/test3'.
Stacktrace       :    at PnP.PowerShell.Commands.Base.PnPConnectedCmdlet.ProcessRecord() in c:\build\src\Commands\Base\PnPConnectedCmdlet.cs:line 98
at System.Management.Automation.CommandProcessor.ProcessRecord()
ScriptLineNumber : 1

What is the version of the Cmdlet module you are running?
➜  Get-Module -Name "PnP.PowerShell" -ListAvailable

    Directory: C:\Users\andresen_n\Documents\PowerShell\Modules

ModuleType Version    PreRelease Name                                PSEdition ExportedCommands
---------- -------    ---------- ----                                --------- ----------------
Manifest   2.1.1                 PnP.PowerShell                      Desk      {Add-PnPAdaptiveScopeProperty, Add-PnPPropertyBagValue, Add-PnPSiteCla…

Which operating system/environment are you running PnP PowerShell on?

[x] Windows
[ ] Linux
[ ] MacOS
[ ] Azure Cloud Shell
[ ] Azure Functions
[ ] Other : please specify

Hi @nils-a , looks like some quirk with M365 , wont be able to do anything around this.
As a workaround, you can use the Id of the list :
$l = Get-PnPList "Dokumente"
Add-PnPContentTypeToList -List $l.Id -ContentType $ct

@gautamdsheth While I have not tested your workaround, I'd argue that it is unlikely that this works, since Add-PnPContentType will work with the list title, internally.
Have you tested your workaround?


nomad: 1.7.6 -> 1.7.7

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/hashicorp/nomad/releases.
meta.description for nomad is: A Distributed, Highly Available, Datacenter-Aware Scheduler
meta.homepage for nomad is: https://www.nomadproject.io/
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 1.7.7 with grep in /nix/store/83zll22k4mrj0sbscdypajrn1am2gjzi-nomad-1.7.7
found 1.7.7 in filename of file in /nix/store/83zll22k4mrj0sbscdypajrn1am2gjzi-nomad-1.7.7

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath
nomad
nomad_1_7

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/83zll22k4mrj0sbscdypajrn1am2gjzi-nomad-1.7.7 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A nomad https://github.com/r-ryantm/nixpkgs/archive/e8abfd98b083c86c1dee005456ae19700be9b1e0.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/e8abfd98b083c86c1dee005456ae19700be9b1e0#nomad

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/83zll22k4mrj0sbscdypajrn1am2gjzi-nomad-1.7.7
ls -la /nix/store/83zll22k4mrj0sbscdypajrn1am2gjzi-nomad-1.7.7/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

nomad (nomad_1_7)

Maintainer pings
cc @rushmorem @pradeepchhetri @endocrimes @amaxine @techknowlogick @cottand for testing.

Result of nixpkgs-review pr 304689 run on x86_64-linux 1

1 package built:

nomad (nomad_1_7)


Load new files in the API

Everything seems to be working fine, but I'm not sure I'm loading the correct data for the expression frequencies in the swarmplot. Can you take a look at the api code @Munfred and let me know if I'm reading the data correctly?


Include description of the time format for Backup Creation and Backup Retention parameters.

Rancher Version:  v1.2.0-pre4-rc3
K8s 1.4 version from - https://github.com/rancher/infra-catalog
Include description of the time format for Backup Creation and Backup Retention parameters.

@LLParse , Assigning this issue to you for now.
Reassign this issue back to me when the updated K8s templates is made available in qa branch of infra catalog.

Tested with latest K8s template from https://github.com/rancher/infra-catalog in qa branch.
Following description of the time format for Backup Creation and Backup Retention parameters are incldued in the template.
The backup period durations must be a sequence of decimal numbers, each with optional fraction and a unit suffix, such as 300ms, 1.5h or 2h45m. Valid time units are ns, us or µs, ms, s, m and h.


Provide booking agents with access to their activities

Update the "My Activities" section of the guest-facing site to show activities for booking agents, including existing and past activities, as well as appropriate actions:

[ ] Show activities on the "My Activities" page
[ ] Show basic customer information next to each activity
[ ] Modify registration for booking agents (emphasizing inviting customers)
[ ] Modify waiver process for booking agents
[ ] Review other actions (invitations, photo site, etc)

Notify AZRA once complete.


add tab completion for installed packages

This is in progress.

This will also allow me to add tab completion to several of commands that need a list of currently installed package names.

This is ready to go. Looks like I updated paket.lock accidently. Let me know if you want me to roll that back.

Very cool


Add Send-Return Models

Pull Request Generated.  Still need to check if it covers everything for Helix Floor

I'm validating for Helix Floor now

Checks out. Closing.


Fix bfloat16_bits union so that it always the sizeof unsigned short.

Fix bfloat16_bits union so that it always the sizeof unsigned short.

Unless we packed the bfloat16_bits structure, it can be something besides the sizeof unsigned short (AKA 2).  On AIX with OpenXLC, without this change the size is 4.

Also ensure that the sizeof float32_bits is the sizeof float (AKA 4)

I wonder how portable this attribute is ?

I wonder how portable this attribute is ?

This is is tested on powerpc Linux and AIX with gcc and Open XL C. We can protect this with ifdef AIX, if needed.

Thanks. Either ifdef AIX or (I guess) ifndef MSVC would do then - bet Microsoft wants some #pragma  here instead


fixFix AnalysisTaskExecutor unit test timeout.

Deencapsulation.getField sometime doesn't work as expected, which may cause FE unit test timeout.


creating some level examples and fixing api errors

I mistakenly implemented a getOne client API but there is no corresponding server endpoint. This has been removed.

@zchapman-gei and @devinrei - please add any feedback


Test Issue created at Fri, 04 Jun 2021 13:35:21 GMT

Test issue body  Fri, 04 Jun 2021 13:35:21 GMT

Comment on issue at Fri, 04 Jun 2021 13:35:22 GMT


ability to customize the yum properties via attributes

this allows the yum properties to be configurable
resolves issue #2
@tas50 i dont have access to this repo in supermarket so I can't push this out

Thanks @chasebolt. I'll clean up the cookstyle failure and release this


add a discovery event example from a bacnet scan

We'd like to ensure that the discovery events our scanner is emitting our valid UDMI, so we're checking an example into the tests directory. This example is constructed from a live building controller and includes some of its quirks and field naming conventions

Hi Nathan,
You can run these tests locally on your machine by using bin/test_schema, and then looking at the .out file which in this example would be tests/event_discovery.tests/from_bacnet.out. If the file is blank then there are no errors

Yep, ran locally before putting the PR up.
Also maybe I'm missing something but it looks to me like the test runner actually compares the .out file with the actual output to make sure they match (rather than writing to it). So that's why e.g. https://github.com/faucetsdn/udmi/blob/master/tests/event_discovery.tests/errors.out is checked in, to make sure that the validator produces those same messages. Is that right?

Nathan, yes -- that is correct.  Some .out files are not empty because they are specifically testing that errors are handled correctly -- but in your case it's good/appropriate that it's empty!
Note that given some of the other changes I'm proposing this will likely need to be adjusted, but that'll come out when I put that PR together.


npx oxlint@latest --max-warnings=0 doesn't tell the warning details

For eslint, they will
npm-download-stat git:(readme) npx oxlint@latest --max-warnings=0

Finished in 4ms on 17 files with 79 rules using 12 threads.
Exceeded maximum number of warnings. Found 2.

There is a --deny-warnings flag for exiting CI with exit code 1.
I'll take a look at the no printing issue.

Thanks

@Boshen is this issue because we exit early before printing warn details?
https://github.com/oxc-project/oxc/blob/2b7ca5962f7961adac92c5bc23741f65b419c037/crates/oxc_cli/src/result.rs#L68-L82 - ref

Looks so, I'd like improve this when I'm avaliable

I think it's this check, I didn't know eslint advices --max-warnings=0, which is a weird indirection for aborting CI with 1.
https://github.com/oxc-project/oxc/blob/78916703c50a04c66c149bcb61e2851e9b1d0c81/crates/oxc_diagnostics/src/service.rs#L118


ESC AWS OIDC provider does not support Gov Cloud

What happened?
Trying to use the AWS login provider to create OIDC temporary creds for AWS gov  cloud.
But get an error when doing an "open":
values.aws.login:
                                Error: WebIdentityErr: failed to retrieve credentials
caused by: InvalidIdentityToken: No OpenIDConnect provider found in your account for https://api.pulumi.com/oidc
                status code: 400, request id: xxxxxxxx

Also tested running on command line with export AWS_ENDPOINT_URL_STS=sts.us-gov-west-1.amazonaws.com and then esc open to see if ESC would consume the gov cloud endpoint. But it didn't.
Example
values:
  aws:
    region: us-gov-west-1
    creds:
      fn::open::aws-login:
        oidc:
          duration: 1h
          roleArn: arn:aws:iam::xxxxxxxxxx:role/yyyyyyyyyyy
          sessionName: zzzzzzzzzz
  environmentVariables:
    AWS_ACCESS_KEY_ID: ${aws.creds.accessKeyId}
    AWS_SECRET_ACCESS_KEY: ${aws.creds.secretAccessKey}
    AWS_SESSION_TOKEN: ${aws.creds.sessionToken}
  pulumiConfig:
    aws:region: ${aws.region}

Output of pulumi about
Happens in Pulumi Cloud UI as well as on command line with esc version 0.8.0
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

I'm trying to use the Pulumi OIDC provider in our AWS GovCloud account to support Pulumi Deployments.
I have successfully created the api.pulumi.com/oidc provider and IAM Role per the Pulumi OIDC AWS Provider doc
I have Enabled the AWS Integration in Pulumi Deployments settings and put in the IAM Role ARN and Session Name.
When I manually trigger a Preview Deployment, it fails consistently with this error:
Fetch provider credentials via OIDC
 $ /pulumi-deploy-executor oidc --workDir="/deployment"

 Error: fetching AWS credentials: WebIdentityErr: failed to retrieve credentials
 caused by: InvalidIdentityToken: No OpenIDConnect provider found in your account for https://api.pulumi.com/oidc
 	status code: 400, request id: 47841196-a280-4c19-a9c4-0938618aba7d

Separately, I have successfully set up a similar OIDC provider for GitHub Actions which we use for ECS Deployments. This works. The Pulumi OIDC provider does not.


feat(installer): add windows installer script

Description of change
Adds Powershell script, following steps as in bash install script, closes #1496.
Install command added to readme will work once shuttle-hq/www#220 is merged.
How has this been tested? (if applicable)
Tested locally on multiple machines, including commenting out codepaths to check both sides of branches. The section for downloading a binary may need to be updated in the future if CI is updated to produce aarch64 windows binaries.

Tried it on a machine that has tar but not rust:

Script assumes Home.cargo\bin exists, and fails if it doesn't (which is not a blocker; we can add checking for sufficient rust install to both scripts later)

(added the bin folder manually, then)

The exit call after successful install made my powershell window close itself, which is probably not desired. (is it due to not running in a subshell anymore?)

(opened and ran it again)

The raw download route fails if the destination file already exists. It should overwrite an existing destiantion.

Other caveat: Only if on non-AMD64 and with no tar.exe does it offer to install rust :thinking: . As said above, we will probably revisit this for both scripts so that the rust check+install can be the first step for both.

Maybe the binary download section can go before cargo.exe install cargo-shuttle --locked inside the cargo.exe check, since this would indicate cargo_home should exist?

Should the script create the bin folder in cargo_home if it doesn't exist?

Yes, running in the same shell means it exits, 2 options, prompt user to press enter before exiting, or nest the code in if-else branches and remove all exit calls?

I can just add -Force to the Move-Item call?

Not sure what you mean by that. The binary download is higher prio than cargo install. I don't think we should create "our own" cargo bin folder, but instead let the check (in later PR) for that cargo is installed guard against this error.
Hmm, ok. I guess that is due to iex not spawning a sub-process for evaluating it. Maybe it is possible to wrap it in a function and use Return instead? This isn't a major blocker, so it can be left to fix in an upcoming PR.
Sounds good.

After resolving (3), this is probably ready to be merged.

Added the -Force flag and wrapped it in a function, it also restores the $ErrorActionPreference since it no longer exits.


Method does not exist: showLoading(show)

In your API documentation you specified:

showLoading(show)
Show or hide the loading icon. Pass either true or false. If the method setRowData is called, the loading icon is automatically hidden.

This function did not work for me, and I could not find this function in the source code.
To show loading, I still can use showLoadingOverlay
But there is no method that I found to hide it, except for the one above, which does not exists in:

ag-grid/dist/ag-grid.js
f8e67d4  13 days ago
release of 4.1.5

Is that documentation of v4.1.6? If so, do you have a release time frame? It's a bit confusing..
I love this table very much, especially the always continued support and new releases.
Thanks!

docs are wrong, i've updated them (will be in next release).
what you want are the methods:
showLoadingOverlay()
showNoRowsOverlay()
hideOverlay()

Thanks!


TVOS Support

You want to:
There does not seem to be TVOS support for asyncstorage
Details:

pod 'RNCAsyncStorage', :path => '../../node_modules/@react-native-community/async-storage'
and this gives error:
[!] The platform of the target RNVAppTVOS (tvOS 12.0) is not compatible with RNCAsyncStorage (1.5.0), which does not support tvos.

Seems like there is some support for TV_OS, but original authors left a note that it might not work as expected
cc @tido64

just edit the podspec file from s.platform      =:ios, "9.0" to s.platform      =:tvos, "9.0" then it works

Sounds like we can change this to:
s.ios.deployment_target = '9.0'
s.tvos.deployment_target = '9.0'

@MwareSolutons Are you working with tvOS? It would be awesome if you could test this and submit a PR if everything works as expected.

Hi Tido64 that worked perfectly just tested it thanks !

@tido64 Do you think that we could add this target to podspec?

Sorry, I've been out (and still am). Does #167 solve your issue?

#167 is merged, so hopefully, it fixed this.
thanks.


PMM-11751: Verify pmm-server collects data after disconnect

https://pmm.cd.percona.com/blue/organizations/jenkins/pmm2-ui-tests/detail/pmm2-ui-tests/31826/pipeline/


targeted mutations not showing up in vcf output

I am using the following options when trying to call variants:
   -@ --variant-input VCF
                   Use variants reported in VCF file as input to the algorithm.
                   Variants in this file will included in the output even if
                   there is not enough support in the data to pass input filters.
   -l --only-use-input-alleles
                   Only provide variant calls and genotype likelihoods for sites
                   and alleles which are provided in the VCF input, and provide
                   output in the VCF for all input alleles, not just those which
                   have support in the data.

I am attempting to identify a deletion that is present in only a handful of reads (< 10) out of a depth of 2000+. I don't expect freebayes to call the variant, but I did expect it to tell me the depth at the location of the deletion (since 'variants in this file will be included in the output even if there is not enough support') - but that variant (and many others) are not present in the output.
I've attached my vcf.gz and .bam file in a zip downloadable here (https://www.dropbox.com/s/spsgqko75orxhlg/test.zip?dl=0)
In particular, there are numerous variants at position 55242464 of chromosome 7.

The example in issue #3894 has 28 reads supporting the deletion (and a couple thousand wild type reads). We confirmed AF, MAPQ and number supporting reads were not the reason the variant is filtered.

I will check this out.
Is it possible that there is a mismatch in the position of the deletion in
the vcf and that in the alignments?
It could be something else is going on.
On Feb 1, 2016 11:48 PM, "haimesjd"<EMAIL_ADDRESS>wrote:

The example in issue #3894 has 28 reads supporting the deletion (and a
couple thousand wild type reads). We confirmed AF, MAPQ and number
supporting reads were not the reason the variant is filtered.
—
Reply to this email directly or view it on GitHub
https://github.com/ekg/freebayes/issues/242#issuecomment-178262382.

Have you had a chance to look at this?

Note that we have been using version 0.9.21 up to this point. I will try 1.0.2 today.

Yes please update and let me know if it changes things!
On Feb 19, 2016 12:22 AM, "Erik Reckase"<EMAIL_ADDRESS>wrote:

Note that we have been using version 0.9.21 up to this point. I will try
1.0.2 today.
—
Reply to this email directly or view it on GitHub
https://github.com/ekg/freebayes/issues/242#issuecomment-185771798.

chr7	55242458	.	CTATCAAGGA	CA,T	1.9166e-13	.	AB=0,0;ABP=0,0;AC=0,0;AF=0,0;AN=2;AO=0,0;CIGAR=1M8D1M,1X;DP=3291;DPB=3423.4;DPRA=0,0;EPP=0,0;EPPR=2086.79;GTI=0;LEN=8,1;MEANALT=0,0;MQM=0,0;MQMR=43.0058;NS=1;NUMALT=2;ODDS=4682.66;PAIRED=0,0;PAIREDR=0;PAO=6,0;PQA=29.5,0;PQR=7723.5;PRO=231;QA=0,0;QR=114564;RO=3250;RPL=0,0;RPP=0,0;RPPR=490.299;RPR=0,0;RUN=1,1;SAF=0,0;SAP=0,0;SAR=0,0;SRF=1478;SRP=60.7621;SRR=1772;TYPE=del,snp	GT:DP:RO:QR:AO:QA:GL	0/0:3291:3250:114564:0,0:0,0:0,-1053.3,-10743.4,-1053.3,-10750.7,-10737.3
chr7	55242468	.	ATTAAGAGAAGCAACATCTCCGAAAG	AC,AC,AT,AC,AG,AG,AG,T	0	.	AB=0,0,0,0,0,0,0,0;ABP=0,0,0,0,0,0,0,0;AC=0,0,0,0,0,0,0,0;AF=0,0,0,0,0,0,0,0;AN=2;AO=0,0,0,0,0,0,0,0;CIGAR=1M10D1M,1M13D1M,1M15D1M,1M18D1M,1M24D1M,1M6D1M,1M9D1M,1X;DP=3039;DPB=3383.23;DPRA=0,0,0,0,0,0,0,0;EPP=0,0,0,0,0,0,0,0;EPPR=24.4185;GTI=0;LEN=10,13,15,18,24,6,9,1;MEANALT=0,0,0,0,0,0,0,0;MQM=0,0,0,0,0,0,0,0;MQMR=43.0725;NS=1;NUMALT=8;ODDS=4602.25;PAIRED=0,0,0,0,0,0,0,0;PAIREDR=0;PAO=0.875,0.875,10.875,0.875,7.125,7.125,7.125,0;PQA=24.875,24.875,324.375,24.875,117.875,117.875,117.875,0;PQR=22513.4;PRO=660.125;QA=0,0,0,0,0,0,0,0;QR=101670;RO=2897;RPL=0,0,0,0,0,0,0,0;RPP=0,0,0,0,0,0,0,0;RPPR=680.912;RPR=0,0,0,0,0,0,0,0;RUN=1,1,1,1,1,1,1,1;SAF=0,0,0,0,0,0,0,0;SAP=0,0,0,0,0,0,0,0;SAR=0,0,0,0,0,0,0,0;SRF=1170;SRP=235.56;SRR=1727;TYPE=del,del,del,del,del,del,del,snp	GT:DP:RO:QR:AO:QA:GL	0/0:3039:2897:101670:0,0,0,0,0,0,0,0:0,0,0,0,0,0,0,0:0,-1124.65,-10831.4,-1124.65,-10848.2,-10831.4,-1124.65,-10861.5,-10861.5,-10832.6,-1124.65,-10848.2,-10848.2,-10861.5,-10831.4,-1124.65,-10933.6,-10933.6,-10946.9,-10933.6,-10886.6,-1124.65,-10933.6,-10933.6,-10946.9,-10933.6,-10933.6,-10886.6,-1124.65,-10933.6,-10933.6,-10946.9,-10933.6,-10933.6,-10933.6,-10886.6,-1124.65,-10848.2,-10848.2,-10861.5,-10848.2,-10933.6,-10933.6,-10933.6,-10783.7

This is the line before and after the variant coordinate we're looking for.
chr7	55242464	COSM13549	AGGAATTAAGAGAAGCAA	AAG	.	.	GENE=EGFR;STRAND=+;CDS=c.2235_2251>AG;AA=p.E746_T751>A;CNT=1
chr7	55242464	COSM13550	AGGAATTAAGAGAAG	AAATTC	.	.	GENE=EGFR;STRAND=+;CDS=c.2235_2248>AATTC;AA=p.E746_A750>IP;CNT=3
chr7	55242464	COSM13551	AGGAATTAAGAGAAGCAAC	AAAT	.	.	GENE=EGFR;STRAND=+;CDS=c.2235_2252>AAT;AA=p.E746_T751>I;CNT=3
chr7	55242464	COSM13552	AGGAATTAAGAGAAGCAA	AAATTC	.	.	GENE=EGFR;STRAND=+;CDS=c.2235_2251>AATTC;AA=p.E746_T751>IP;CNT=2
chr7	55242464	COSM14243	A	G	.	.	GENE=EGFR;STRAND=+;CDS=c.2234A>G;AA=p.K745R;CNT=2
chr7	55242464	COSM1451585	A	T	.	.	GENE=EGFR;STRAND=+;CDS=c.2234A>T;AA=p.K745M;CNT=1
chr7	55242464	COSM24869	AGGAATTAAGAGAAGCAAC	A	.	.	GENE=EGFR;STRAND=+;CDS=c.2235_2252del18;AA=p.E746_T751delELREAT;CNT=1
chr7	55242464	COSM255152	A	AAACTCCCGTCGCTATCAA	.	.	GENE=EGFR;STRAND=+;CDS=c.2234_2235ins18;AA=p.K745_E746insTPVAIK;CNT=1
chr7	55242464	COSM28517	AGGAATTAAGAGA	A	.	.	GENE=EGFR;STRAND=+;CDS=c.2235_2246del12;AA=p.E746_E749delELRE;CNT=9
chr7	55242464	COSM51504	A	AAATTCCCGTCGCTATCAA	.	.	GENE=EGFR;STRAND=+;CDS=c.2234_2235ins18;AA=p.K745_E746insIPVAIK;CNT=5
chr7	55242464	COSM6223	AGGAATTAAGAGAAGC	A	.	.	GENE=EGFR;STRAND=+;CDS=c.2235_2249del15;AA=p.E746_A750delELREA;CNT=911
chr7	55242464	COSM85797	AGGAATTAAGAGAAGCAACATC	AGGT	.	.	GENE=EGFR;STRAND=+;CDS=c.2235_2255>GGT;AA=p.E746_S752>V;CNT=1

These are the relevant lines in the targeted mutations file.

So, we have now missed a variant with about 70% depth due to this issue.
Consider the following targeted mutation VCF lines:
chr12	25398285	COSM516	C	A	.	.	Archer_Gene=KRAS;STRAND=-;CDS=c.34G>T;Archer_MutationAA=p.G12C;CNT=3660
chr12	25398285	COSM517	C	T	.	.	Archer_Gene=KRAS;STRAND=-;CDS=c.34G>A;Archer_MutationAA=p.G12S;CNT=1496
chr12	25398285	COSM518	C	G	.	.	Archer_Gene=KRAS;STRAND=-;CDS=c.34G>C;Archer_MutationAA=p.G12R;CNT=1015
chr12	25398285	COSM87301	C	CAGCTCC	.	.	Archer_Gene=KRAS;STRAND=-;CDS=c.33_34insGGAGCT;Archer_MutationAA=p.A11_G12insGA;CNT=2

(You can ignore the Archer stuff.) With the CAGCTCC insertion in this file, our call looks like this:
chr12	25398285	.	CA	CAGCTCCA,A,G,T	0	.	AB=0,0,0,0;ABP=0,0,0,0;AC=0,0,0,0;AF=0,0,0,0;AN=2;AO=0,0,0,0;CIGAR=1M6I1M,1X,1X,1X;DP=779;DPB=779;DPRA=0,0,0,0;EPP=0,0,0,0;EPPR=25.6826;GTI=0;LEN=6,1,1,1;MEANALT=0,0,0,0;MQM=0,0,0,0;MQMR=247.348;NS=1;NUMALT=4;ODDS=245.82;PAIRED=0,0,0,0;PAIREDR=0;PAO=26,0,0,0;PQA=926,0,0,0;PQR=0;PRO=0;QA=0,0,0,0;QR=5575;RO=161;RPL=0,0,0,0;RPP=0,0,0,0;RPPR=119.663;RPR=0,0,0,0;RUN=1,1,1,1;SAF=0,0,0,0;SAP=0,0,0,0;SAR=0,0,0,0;SRF=101;SRP=25.6826;SRR=60;TYPE=ins,snp,snp,snp	GT:DP:RO:QR:AO:QA:GL	0/0:779:161:5575:0,0,0,0:0,0,0,0:0,-56.2926,-490.398,-56.2926,-498.225,-573.739,-56.2926,-498.225,-573.739,-573.739,-56.2926,-498.225,-573.739,-573.739,-573.739

However, if you take out the insertion and run with just the three snps, you get this:
chr12	25398285	.	C	A,G,T	15275	.	AB=0.76799,0,0;ABP=505.8,0,0;AC=1,0,0;AF=0.5,0,0;AN=2;AO=619,0,0;CIGAR=1X,1X,1X;DP=806;DPB=806;DPRA=0,0,0;EPP=12.8644,0,0;EPPR=22.5303;GTI=0;LEN=1,1,1;MEANALT=1,0,0;MQM=224.174,0,0;MQMR=248.412;NS=1;NUMALT=3;ODDS=611.425;PAIRED=0,0,0;PAIREDR=0;PAO=0,0,0;PQA=0,0,0;PQR=0;PRO=0;QA=21664,0,0;QR=6529;RO=187;RPL=228,0,0;RPP=96.2152,0,0;RPPR=55.1372;RPR=391,0,0;RUN=1,1,1;SAF=338,0,0;SAP=14.4079,0,0;SAR=281,0,0;SRF=114;SRP=22.5303;SRR=73;TYPE=snp,snp,snp	GT:DP:RO:QR:AO:QA:GL	0/1:806:187:6529:619,0,0:21664,0,0:-1600.01,0,-334.95,-1656.31,-521.288,-2177.25,-1656.31,-521.288,-2177.25,-2177.25

There is a clear C->A snp here.

Please see https://github.com/ekg/freebayes/pull/257 for a proposed solution.  I'm not entirely confident that it is correct however; feedback welcome.


Smart commit

Description
We want to check preexisting channel balances on commit so that we don't unnecessarily open channels if they already exist. If channels are already open during commit, check balances, if the balance is low, ask user to release channels, if balance is enough do not open channels.
Related PRs
https://github.com/sparkswap/lnd-engine/pull/91
Todos

[x] Tests
[x] Documentation
[x] Link to Trello

 "Smart" commit

@martineehrlich LGTM


Revert arguments of denops#server#connect()

Revert #3
I was confused which one is the latest specification.
https://github.com/vim-denops/denops.vim/blob/53ce6187e04da044c85b79ef856f1487326a7ac5/autoload/denops/server.vim#L11
Is this okay?

OK.


2671: Clone draft functionality with react query

What does this PR?
-clone button added on draft list item

user can clone a draft

Issue number
https://github.com/ecency/ecency-mobile/issues/2671
Screenshots/Video
https://user-images.githubusercontent.com/39906620/235132628-1780b581-343d-4dc0-9f65-430fe242aef2.mov

Thank you for the feedback. The PR has been updated, Please review it.


After upgrade to 1.8.1, LDAP auth stops working.

I have made a fresh 1.8.1 install on Ubuntu 16, imported the PostgreSQL DB of our 1.6 instance, ran the DB migrations, everything seems to work.
./manage.py sync_ldap_user_data works, it updates all of our existing accounts (all LDAP).
./manage.py query_ldap <any user email> is found, so the LDAP config/connection is fine.
I'm tailing LDAP logs on our OpenLDAP server, I try to log in and I get a "Please enter a correct email and password." error - and absolutely no connection to LDAP shows up in the logs, even on max verbosity.
ZulipLDAPAuthBackend is the only auth backend enabled.
We've had no LDAP issues in any of the previous versions. Is there a flag in the DB that's missing? It does look like Zulip is not even pretending to try any LDAP authentication at login.

@Senso sorry for the very slow reply!  I somehow missed this.  Can you try setting AUTH_LDAP_GROUP_CACHE_TIMEOUT=60 in the settings.py file?  That's the only change we made in 1.8.0 that could be related to this.

@Senso just wanted to check in if you had a chance to try that?
I think this will go away when we upgrade django-auth-ldap regardless.

@timabbott I confirm that adding AUTH_LDAP_GROUP_CACHE_TIMEOUT=60 (or setting it to 10) doesn't change anything. Tailing the OpenLDAP logs, I noticed that a search isn't performed every time I try to login (and fail) in Zulip.
Running sync_ldap_user_data lists all existing users, saying they're not found in LDAP. Our Django LDAP config is identical to other apps we already use, like Sentry and some in-house apps.
auth_ldap_bind_password is properly set in zulip-secrets.conf, I'm not sure where it fails exactly but it looks like it's at the initial bind.
My last attempt will be to try to upgrade django-auth-ldap inside the virtualenv, otherwise we'll be sticking to Zulip 1.7 for the foreseeable future.

Update: Upgrading django-auth-ldap to 1.7.0 via pip, I'm now able to run ./manage.py sync_ldap_user_data and ./manage.py query_ldap `, so that's a good change.

OK, thanks for the info.  I'm confused why this isn't working, but it sounds like we should probably just push forwarde with upgrading django-auth-ldap and go from there.

@Senso can you test with 1.6.0?  That's what we currently are using in Zulip master, and I suspect is what is needed to fix this.

@timabbott I never had that issue with 1.6.0 and we're using it in production so I didn't want to test changing versions there.
In any case, I trashed my attempt at upgrading and started from scratch - I was able to make LDAP authenticate even with django-auth-ldap 1.3.0, it turns out the issue was much simpler:
It turns out that ZulipLDAPAuthBackend.authenticate() was receiving an empty realm, hence why I was not even seeing authentication attempts in my OpenLDAP logs. I "forced" a realm object with realm = get_realm("<our org name") and then LDAP worked. Tracking that down in the code, I noticed that we were missing the REALM_HOSTS config option. That option is not in use on our 1.6.0 prod server and settings.py was not updated by the migration to 1.8.1. So I spent all that time debugging LDAP while it was caused by a missing config option. :/
So 1.8.1 does appear to work out of the box and does not require django-auth-ldap 1.7.0 (probably wouldn't hurt anyway). I'll be migrating our prod to 1.8.1 soon enough, very satisfied with our testing so far.

@Senso awesome, thanks for the follow-up!


Initial support for iOS4

… while using iOS5 features when possible. (uses weak when available)
There are still some problems with getting the Gesture Recognizers and changing layout strategy doesn't work yet, but it's a start.
Plus, this fixes a missing subclass from NSObject in GMGridViewLayoutStragegyFactory, which works for iOS5 but crashes with runtime problems in NSInvocation in iOS4.

Great! Thank you very much.
Defining the gm_weak is a very elegant solution.
About the gesture recognizer, I fixed it by changing your code this way :
for (UIGestureRecognizer *gestureRecognizer in _scrollView.gestureRecognizers)
{
if ([gestureRecognizer  isKindOfClass:NSClassFromString(@"UIScrollViewPanGestureRecognizer")])
{
panGestureRecognizer = (UIPanGestureRecognizer *) gestureRecognizer;
break;
}
}
Works fine now.
I'll look into the layout strategy issue that you mentioned, although it seems to be working fine.
I already pulled your code on my local repo. I'll do some more testing and push it on github in a few days.
Thanks again!

Merged


[Safari] Please add link to this Github-Repo

Information about your system

Extension Version: 2018.1.25
Browser and Version: Safari 11.0.3
Operating System: MacOS 10.13.3 High Sierra

What does not work?
When I click on "more options" (Hamburger Menu), I cannot find a link to this repository.
What is the expected behavior?
Please add a link to this repository in the "more options" menu and/or in the settings menu.

Hi @clemensbartz, thank you for sharing this feedback. We handle suggestions like this internally so I will be bringing your thoughtful request to the team.
Thanks again!

Hi folks,
Things have moved on a bit since this was last updated.
We have a new extension for Safari that uses Tracker Radar and you can install it from the App Store:
https://apps.apple.com/us/app/duckduckgo-privacy-essentials/id1482920575?mt=12
You can find the code for it here:
https://github.com/duckduckgo/privacy-essentials-safari
Thanks!


doc: Update README.md about proguard

Building on Android with proguard enabled will require this rule to avoid crashing on release app.
Updating the readme to include this.
Relate to #44 and #42

Thanks for the update, however thats not what I meant. I want to keep the installation section at the top short - thus I don't want to move the whole block there.
Can you please put the block back at the bottom where it was initially and just add a one liner like I suggested to the installation section? Thanks!

Gotcha. I've amended.


kernel: API to pin thread to a CPU

kernel: introduce convinience apu to pin thread to a cpu
samples: synchronization: use k_thread_cpu_pin

Codecov Report

Merging #44896 (c5dc184) into main (2824696) will increase coverage by 0.01%.
The diff coverage is 68.57%.

:exclamation: Current head c5dc184 differs from pull request most recent head 5cf09c9. Consider uploading reports for the commit 5cf09c9 to get more accurate results

@@            Coverage Diff             @@
##             main   #44896      +/-   ##
==========================================
+ Coverage   49.77%   49.78%   +0.01%
==========================================
  Files         642      642
  Lines       79837    79894      +57
  Branches    18748    18763      +15
==========================================
+ Hits        39738    39778      +40
- Misses      33523    33527       +4
- Partials     6576     6589      +13

Impacted Files
Coverage Δ

include/zephyr/device.h
85.71% <ø> (ø)

include/zephyr/drivers/can.h
95.58% <ø> (ø)

include/zephyr/drivers/i2c.h
95.23% <ø> (ø)

include/zephyr/kernel.h
97.95% <ø> (ø)

include/zephyr/logging/log_ctrl.h
100.00% <ø> (ø)

include/zephyr/logging/log_internal.h
100.00% <ø> (ø)

include/zephyr/pm/device.h
100.00% <ø> (ø)

kernel/timeout.c
96.57% <ø> (-0.03%)
:arrow_down:

lib/libc/newlib/libc-hooks.c
52.00% <ø> (ø)

lib/os/heap.h
84.61% <ø> (ø)

... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2824696...5cf09c9. Read the comment docs.

@stephanosio

Should add a test for k_thread_cpu_pin in:

done


Handle batch requests concurrently

Issue #839

@kirugan can we address the comments here? It should be a good addition.

@kirugan can you rebase?


test-branch/execute-job/wrong-commit-sha-on-pr/8ad3ab0e-128e-4004-9701-945d69d857a7

PR for testing 0e8a804667ca3eb6c07d8bfa381b1ace69f3ef5b

/canonical/self-hosted-runners/run-workflows 931ad21dd9ace68aaa0a7d341e94de96ad93fa6b


Selecting GitLab repository belonging to group prevents file browser from displaying files [OSF-9077]

After I enabled the GitLab add-on, the file browser stopped displaying my files. I only see a spinning wheel next to my projects name (see screenshot). Everything works fine if I disable the add-on by disconnecting the account but not if I do not select any GitLab repository. The issue appears in both Chrome and Firefox with no plugins/extensions enabled. Here are the errors from the console in Chrome:

jquery.min.js:2 jQuery.Deferred exception: Cannot read property 'branch' of undefined TypeError: Cannot read property 'branch' of undefined
at o (https://osf.io/static/public/js/gitlab/files.8c0a241b61af243e576d.js:1:277)
at n.s (https://osf.io/static/public/js/gitlab/files.8c0a241b61af243e576d.js:1:1156)
at https://osf.io/static/public/js/vendor.5cdfb267d6a9e799e7c5.js:12:3405
at Array.map ()
at https://osf.io/static/public/js/vendor.5cdfb267d6a9e799e7c5.js:12:2989
at Array.map ()
at Object.m.view (https://osf.io/static/public/js/vendor.5cdfb267d6a9e799e7c5.js:12:1864)
at Object.i [as view] (https://osf.io/static/public/js/vendor.5cdfb267d6a9e799e7c5.js:10:14496)
at m (https://osf.io/static/public/js/vendor.5cdfb267d6a9e799e7c5.js:10:14809)
at Function.r.redraw (https://osf.io/static/public/js/vendor.5cdfb267d6a9e799e7c5.js:10:21166)
at n.refreshRange (https://osf.io/static/public/js/vendor.5cdfb267d6a9e799e7c5.js:11:23788)
at n.calculateVisible (https://osf.io/static/public/js/vendor.5cdfb267d6a9e799e7c5.js:11:23521)
at https://osf.io/static/public/js/vendor.5cdfb267d6a9e799e7c5.js:11:22169
at i (https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js:2:28017)
at Object.add [as done] (https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js:2:28316)
at n.toggleFolder (https://osf.io/static/public/js/vendor.5cdfb267d6a9e799e7c5.js:11:21076)
at n.updateFolder (https://osf.io/static/public/js/vendor.5cdfb267d6a9e799e7c5.js:11:20706)
at n.q (https://osf.io/static/public/js/vendor.5cdfb267d6a9e799e7c5.js:19:13248)
at n.ondataload (https://osf.io/static/public/js/vendor.5cdfb267d6a9e799e7c5.js:20:532)
at https://osf.io/static/public/js/vendor.5cdfb267d6a9e799e7c5.js:11:14315
at i (https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js:2:28017)
at fireWith (https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js:2:28783)
at j (https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js:2:30283)
at k (https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js:2:30313)
at c (https://osf.io/static/vendor/bower_components/raven-js/dist/raven.min.js:2:3899) undefined
r.Deferred.exceptionHook @ jquery.min.js:2
k @ jquery.min.js:2
c @ raven.js:267
setTimeout (async)
(anonymous) @ raven.js:641
(anonymous) @ jquery.min.js:2
i @ jquery.min.js:2
add @ jquery.min.js:2
(anonymous) @ jquery.min.js:2
Deferred @ jquery.min.js:2
then @ jquery.min.js:2
a @ treebeard.js:1667
m.controller @ treebeard.js:2051
n @ mithril.js:554
r.mount.r.module @ mithril.js:598
v @ treebeard.js:2702
_initGrid @ fangorn.js:2875
init @ fangorn.js:2871
ye @ fangorn.js:2861
(anonymous) @ files-page.js:18
i @ jquery.min.js:2
fireWith @ jquery.min.js:2
A @ jquery.min.js:4
(anonymous) @ jquery.min.js:4
c @ raven.js:267
XMLHttpRequest.send (async)
(anonymous) @ raven.js:695
send @ jquery.min.js:4
ajax @ jquery.min.js:4
(anonymous) @ files-page.js:15
j @ jquery.min.js:2
k @ jquery.min.js:2
c @ raven.js:267
setTimeout (async)
(anonymous) @ raven.js:641
(anonymous) @ jquery.min.js:2
i @ jquery.min.js:2
fireWith @ jquery.min.js:2
fire @ jquery.min.js:2
i @ jquery.min.js:2
fireWith @ jquery.min.js:2
ready @ jquery.min.js:2
S @ jquery.min.js:3
c @ raven.js:267
(index):1 The SSL certificate used to load resources from https://bam.nr-data.net will be distrusted in M70. Once distrusted, users will be prevented from loading these resources. See https://g.co/chrome/symantecpkicerts for more information.

Apparently, osf is unable to access the branch property.
I have given osf full access to the GitLab api (api scope).
Please let me know how I could provide more info if needed.

I'm unable to reproduce this bug, but I'd still like to get to the bottom of it. I've looked through our error logging system but didn't find anything relevant.
@vkehayas, can you confirm whether or not the stack trace in the browser console is the same in both cases you described (account and repo connected, or just account connected), and if not, provide a trace for the other case?
Also, would you mind emailing your project's GUID (the 5-character string after osf.io/ when viewing your project) to<EMAIL_ADDRESS>so that we can investigate if the project's state is related?

Thank you for your prompt response.
After I disabled and re-enabled GitLab I was able to browse my files before selecting a GitLab repo and the stack trace was clean. After selecting a GitLab repo, I got the same trace as before. I realize that de-selecting the repo has no effect - upon page refresh the same repo is selected. I guess selecting ---- is not a valid option once you 've selected a repo.
I've sent an email with my GUID, as instructed.

Thanks, @vkehayas. I've diagnosed the bug, I expect we'll have a fix out later today. I'll keep this issue open until it's deployed

Thanks @mfraezz for the fix.
@vkehayas The fix is now deployed. Can you please verify that the issue is fixed?

No, sorry, I still get similar output.

jquery.min.js:2 jQuery.Deferred exception: Cannot read property 'branch' of undefined TypeError: Cannot read property 'branch' of undefined
at o (https://osf.io/static/public/js/gitlab/files.8c0a241b61af243e576d.js:1:276)
at n.s (https://osf.io/static/public/js/gitlab/files.8c0a241b61af243e576d.js:1:1156)
at https://osf.io/static/public/js/vendor.5cdfb267d6a9e799e7c5.js:12:3405
at Array.map (native)
at https://osf.io/static/public/js/vendor.5cdfb267d6a9e799e7c5.js:12:2989
at Array.map (native)
at Object.m.view (https://osf.io/static/public/js/vendor.5cdfb267d6a9e799e7c5.js:12:1864)
at Object.i [as view] (https://osf.io/static/public/js/vendor.5cdfb267d6a9e799e7c5.js:10:14496)
at m (https://osf.io/static/public/js/vendor.5cdfb267d6a9e799e7c5.js:10:14809)
at Function.r.redraw (https://osf.io/static/public/js/vendor.5cdfb267d6a9e799e7c5.js:10:21166)
at n.refreshRange (https://osf.io/static/public/js/vendor.5cdfb267d6a9e799e7c5.js:11:23788)
at n.calculateVisible (https://osf.io/static/public/js/vendor.5cdfb267d6a9e799e7c5.js:11:23521)
at https://osf.io/static/public/js/vendor.5cdfb267d6a9e799e7c5.js:11:22169
at i (https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js:2:28017)
at Object.add [as done] (https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js:2:28316)
at n.toggleFolder (https://osf.io/static/public/js/vendor.5cdfb267d6a9e799e7c5.js:11:21076)
at n.updateFolder (https://osf.io/static/public/js/vendor.5cdfb267d6a9e799e7c5.js:11:20706)
at n.q (https://osf.io/static/public/js/vendor.5cdfb267d6a9e799e7c5.js:19:13248)
at n.ondataload (https://osf.io/static/public/js/vendor.5cdfb267d6a9e799e7c5.js:20:532)
at https://osf.io/static/public/js/vendor.5cdfb267d6a9e799e7c5.js:11:14315
at i (https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js:2:28017)
at fireWith (https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js:2:28783)
at j (https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js:2:30283)
at k (https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js:2:30313)
at c (https://osf.io/static/vendor/bower_components/raven-js/dist/raven.min.js:2:3899) undefined

However, looking at https://github.com/CenterForOpenScience/osf.io/commit/b7c494ed1148cc69597054a4e5189852e33b63e8 I realized that the problem seems to be that my repo is inside a nested folder (a "group" in GitLab's terminology). Indeed, I created a test repository that is at the top of the tree (i.e. gitlab.com/username/repo instead of gitlab.com/username/group/repo) and the sync with osf.io was successfull. Of course, GitLab allows for more than one levels of grouping and I do not expect you to support that feature, so let me know if a single group level is possible to parse without too much effort or not and I'll adjust the organization of my repos accordingly.
I still got some apparently innocuous errors in the console - probably nothing to worry about:

raven.js:695 GET https://files.osf.io/v1/resources/7qe4j/providers/gitlab/?branch=&meta=&_=1513283374168 400 (Bad Request)
(anonymous) @ raven.js:695
D @ mithril.js:1086
r.request @ mithril.js:1142
i.request @ treebeard.js:43
(anonymous) @ treebeard.js:1050
i @ jquery.min.js:2
add @ jquery.min.js:2
toggleFolder @ treebeard.js:1046
onclick @ treebeard.js:2319
(anonymous) @ mithril.js:482

@vkehayas Thanks for digging into that and for the thorough report. We'll evaluate what it will take to support repos within groups within the next week. Thanks for your patience!

@vkehayas OK, we released a fix that should allow repos within groups. Can you verify that you can connect your repo(s)?

Great! Thanks for reporting the issue and for your patience while we fixed it.


Repack the intellij-agent artifact to kover-jvm-agent

In the case where the kover-cli is used for generating reports, users may need to perform on the fly instrumentation that will produce compatible results.
Since intellij-agent has a versioning that differs from the version of Kover, it will be problematic for the user to choose the appropriate version.
It can also confuse the use of dependencies from intellij, which is not explicitly related to Kover for the user.
Additionally, in the new artifact, we may pass parameters and system variables in a different form and with different names, more typical for Kover

Introduced in 0.8.0-Beta.


update badges

Pull Request Test Coverage Report for Build 217125222
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 217112386:
0.0%

Covered Lines:
129

Relevant Lines:
129

💛  - Coveralls


Update PR template with correct ICLA link

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[ ] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[ ] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[ ] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

R: @aaltay @davorbonaci PTAL
Same as https://github.com/apache/beam-site/pull/200

Coverage remained the same at 70.134% when pulling 4768e9b3ef48e1167b96b3bd324a22f7c1e133ad on sb2nov:BEAM-fix-ICLA into 6d223bb13596998a227e055335c8b4e3e91020ec on apache:master.

LGTM