adding query parameters to get servicetags

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[x] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet. : Feb 2021
When you expect to publish swagger? Please provide date, or month to public if date is not available yet. : Feb 2021
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[x] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[x] PowerShell
[x] CLI
[ ] Terraform
[ ] No, no need to refresh for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of “no breaking changes
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable version with Breaking Change Validation errors
[ ] Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

@msyyc Please check Python SDK breaking changes. Thanks

@msyyc Please check Python SDK breaking changes. Thanks

@ArcturusZhang, GO SDK generation failed. Please have a look. Thanks.

@ArcturusZhang, GO SDK generation failed. Please have a look. Thanks.

I have checked, the breaking change for Python is OK.

I have checked, the breaking change for Python is OK.

/azp run

/azp run

@guptas14, it seems you added new parameters which is considered as a breaking change.  Is it better to handle it in the new API version?

@guptas14, it seems you added new parameters which is considered as a breaking change.  Is it better to handle it in the new API version?

Hi, @guptas14. The PR has be closed for a long time and it's related branch still exist. If no further used for over 14 days, I will delete this related branch. Please tell me if you still need this branch.

Hi, @guptas14. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

Hi, @guptas14. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

Hi, @guptas14. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.


[Feature 5.2]  create staff schedule

each staff needs a schedule (from plot)
done by checking what line they're working on that day
line assigned to train engineers/operators by admins
AddToLine interface has methods addEmployeeToLine and checkLine, and admin implements that interface so they can do both administrative things. employees call on the public methods written in admin to check what line they're on

done in management page


[1.10.2] Foce Gamemode

Hallo together,
if I set a gamemode like "/world gamemode  [value]", I get an output, that the gamemode was set. But if a player joins the world he is in his last gamemode, not in the gamemode of the world.
Plugins installed:

PEX
PJW
PJP
RedProtect

Thanks

Player needs permission pjw.options.gamemode

Okay, I will try it. Thanks :)

Okay, it works. Sorry it isn't a bug, its a feature :)


error python version in compile_and_run.sh

I try to build in Ubuntu 22.04, python3.10
install prerequisites.
and run compile_and_test.sh
but.. error like that,
g++ -MMD -I. -O3 -g -DDEBUG -mavx2 -DBUILD_DIR="build" -Ibuild/include -DFMT_HEADER_ONLY -Ithird_party/fmt -Ithird_party/pybind11/include -Wall -Wextra -Wno-pragmas -DUTILS_LOGGER_PYTHON_OSTREAM_REDIRECT=1 --std=c++17 -maes -mavx  -shared -fPIC -Ipybuda/csrc -Ithird_party/json -Ithird_party/budabackend -Ithird_party/budabackend/netlist -I/usr/include/python3.8 -isystem build/python_env/lib/python3.8/site-packages/torch/include -isystem build/python_env/lib/python3.8/site-packages/torch/include/torch/csrc/api/include -c -o build/obj/pybuda/csrc/passes/bind_reshape_to_io.o pybuda/csrc/passes/bind_reshape_to_io.cpp
In file included from third_party/pybind11/include/pybind11/detail/../attr.h:13,
from third_party/pybind11/include/pybind11/detail/class.h:12,
from third_party/pybind11/include/pybind11/pybind11.h:13,
from pybuda/csrc/passes/bind_reshape_to_io.cpp:6:
third_party/pybind11/include/pybind11/detail/../detail/common.h:211:10: fatal error: Python.h: No such file or directory
211 | #include <Python.h>
|          ^~~~~~~~~~
I was fix PYTHON_VERSION in tt_buda/python_env/module.mk
and delete "git reset -hard " ,  in compile_and_run.sh
please fix script and document (https://docs.tenstorrent.com/tenstorrent/v/tt-buda/installation#python-environment-installation)

Thanks for the report. Presently, Tenstorrent software is only supported on the Ubuntu 20.04 LTS (Focal Fossa) operating system. Let me check if we support python 3.10 currently. I will work with the team to provide an appropriate update.

Vladimir, can you update the compile_and_run.sh to work with 3.10 / 22.04 and have the documentation updated to reflect that support as well?

PyBuda is now also supported on Ubuntu 22.04, we will update the documentation to reflect that.
The script compile_and_run.sh is a utility script for running specific tests, and you shouldn't use it for initial compilation.
Instead, you can use env_for_silicon.sh script that activates the Python environment and starts the build for grayskull.
Environment variable PYTHON_VERSION tells PyBuda which version of Python to use and where to look for Python.h. Ubuntu 20.04 comes with Python 3.8 by default and you should set it to PYTHON_VERSION: "python3.8", while Ubuntu 22.04 comes with Python 3.10 and it should be set to PYTHON_VERSION: "python3.10".
You can take a look at the Github action that builds the PyBuda for reference
https://github.com/tenstorrent/tt-buda/actions/runs/8853304872/job/24313841016

uses Ubuntu 22.04
installs dependencies
sets environment variable PYTHON_VERSION: "python3.10"
source env_for_silicon.sh to start the build

We have updated the docs and this will be published with our next release. Thank you all for contributing to the project.


test: Cypress - Fix Flaky Tests

Description
Fixed below flaky tests

Listv2_Meta_Hydration_ServerSide_spec
Listv2_dataIdentifierProperty_spec.js

Type of change

Flaky test fix

How Has This Been Tested?

Cypress test runs

Checklist:
QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

/ok-to-test sha=e0dde13


Search and Pagination problem

Hi,
I have an issue related to search and pagination(remote).
If I have more then 10 rows and sizePerPage is 10. When table is already loaded and I click on the next button and then search I expect to back to fist page of pagination, but this is not the current bihavior.
Also in dev tools, I have warning error during searching
Warning: Cannot update during an existing state transition (such as within render or another component's constructor). Render methods should be a pure function of props and state; constructor side-effects are an anti-pattern, but can be moved to componentWillMount.
All data came from third part API.
Thanks :)

@feather-jmalone sorry busy on my work, wil get back to you guys ASAP. thanks

If I have more then 10 rows and sizePerPage is 10. When table is already loaded and I click on the next button and then search I expect to back to fist page of pagination, but this is not the current bihavior.

Hi everyone, there're two case here:

pagination + search without remote
In this case, no matter what page you are in, after search/filter trigger, react-bootstrap-table2 will switch first page automatically

pagination + search with remote
In this case, when search/filter trigger, react-bootstrap-table2 do nothing .
Why do nothing, that is because you enable the remote mode, which mean you have to tell react-bootstrap-table2 which page you want to go and what data you want to display.

Remember, the remote mode is meaning you have control everything, page, sort, data, filter, search etc.
Please let me know your idea or your thought about this case. thanks

Thanks @feather-jmalone I agree with your idea, we can create custom input to build search functionality, but I think this is workaround and it’s not the best solution.
@Allen I understood your points, I’d like to ask, how we can set pagination to one before API call for searching, I try to set pagination option - page: 1, it doesn’t work, thanks

@maspasov I think it work for me, but there're are some UI part can enhance is that when you assign page to one but the page one button seems not being update so that it will look like not selected but the data is display correctly. Following is my dummy code:

import BootstrapTable from 'react-bootstrap-table-next';
import ToolkitProvider, { Search } from 'react-bootstrap-table2-toolkit';
import paginationFactory from 'react-bootstrap-table2-paginator';

const { SearchBar } = Search;

const RemoteAll = ({ data, page, sizePerPage, onTableChange, totalSize }) => (

When remote.pagination is enabled, the filtering,
      sorting and searching will also change to remote mode automatically

    <ToolkitProvider
      keyField="id"
      remote
      data={ data }
      columns={ columns }
      search
    >
      {
        toolkitprops => [
          <SearchBar { ...toolkitprops.searchProps } />,
          <BootstrapTable
            { ...toolkitprops.baseProps }
            remote
            pagination={ paginationFactory({ page, sizePerPage, totalSize }) }
            onTableChange={ onTableChange }
          />
        ]
      }
    </ToolkitProvider>

);

RemoteAll.propTypes = {
  data: PropTypes.array.isRequired,
  page: PropTypes.number.isRequired,
  totalSize: PropTypes.number.isRequired,
  sizePerPage: PropTypes.number.isRequired,
  onTableChange: PropTypes.func.isRequired
};

class Container extends React.Component {
  constructor(props) {
    super(props);
    this.state = {
      page: 1,
      data: products.slice(0, 10),
      totalSize: products.length,
      sizePerPage: 10
    };
    this.handleTableChange = this.handleTableChange.bind(this);
  }

  handleTableChange = (type, { page, sizePerPage, searchText }) => {
    setTimeout(() => {
      let newPage = page;
      let result = products;
      if (searchText) {
        //  If user search something
        result = products.filter((row) => {
          for (let cidx = 0; cidx < columns.length; cidx += 1) {
            const column = columns[cidx];
            let targetValue = row[column.dataField];
            if (targetValue !== null && typeof targetValue !== 'undefined') {
              targetValue = targetValue.toString().toLowerCase();
              if (targetValue.indexOf(searchText) > -1) {
                return true;
              }
            }
          }
          return false;
        });
        // back to first page
        newPage = 1;
      }
      // calculation pagination
      const currentIndex = (newPage - 1) * sizePerPage;
      const data = result.slice(currentIndex, currentIndex + sizePerPage);
      const totalSize = result.length;
      this.setState(() => ({
        page: newPage,
        data,
        totalSize,
        sizePerPage
      }));
    }, 2000);
  }

  render() {
    const { data, sizePerPage, page } = this.state;
    return (
      <RemoteAll
        data={ data }
        page={ page }
        sizePerPage={ sizePerPage }
        totalSize={ this.state.totalSize }
        onTableChange={ this.handleTableChange }
      />
    );
  }
}

RELEASE NOTE
Please upgrade to<EMAIL_ADDRESS><EMAIL_ADDRESS>and<EMAIL_ADDRESS>

Hi @AllenFang I am facing the same issue in UI, the data is updated but the page number is not updated to 1 in the UI. Is this issue resolved?

Hi, I'm having this issue, the UI pagination is been updating but the data is not, this is the my table with the data:
import React, { Component } from 'react';
import BootstrapTable from 'react-bootstrap-table-next';
import paginationFactory from 'react-bootstrap-table2-paginator';

const columns = [
  {
    dataField: 'id',
    text: 'Product ID'
  },
  {
    dataField: 'name',
    text: 'Product Name'
  }
];

const products = [
    {
      "id": "5c6ed942a297a3fd2c391bd2",
      "name": "Shauna Cunningham"
    },
    {
      "id": "5c6ed9422edfa1cff2761660",
      "name": "Bennett Nielsen"
    },
    {
      "id": "5c6ed9427e8b3764ea416fba",
      "name": "Milagros Castro"
    },
    {
      "id": "5c6ed9426494a3a6aeaf9701",
      "name": "Essie Ratliff"
    },
    {
      "id": "5c6ed94250fadbdb73470196",
      "name": "Parker Yang"
    },
    {
      "id": "5c6ed9427b1d8222ca970a0f",
      "name": "Castro Bartlett"
    },
    {
      "id": "5c6ed94271b56acd240e47ac",
      "name": "Patrick Bender"
    },
    {
      "id": "5c6ed9426bfb5b8a894d3b83",
      "name": "Mallory Valenzuela"
    },
    {
      "id": "5c6ed942c95b2efc59fbc59f",
      "name": "Elma Dillard"
    },
    {
      "id": "5c6ed94230d5c90a438e0df8",
      "name": "Olsen Kidd"
    },
    {
      "id": "5c6ed94257edb011816fcdac",
      "name": "Pamela Vargas"
    },
    {
      "id": "5c6ed9425dcf25100ffefe5c",
      "name": "Deloris Bradford"
    },
    {
      "id": "5c6ed94285397a10901e83f1",
      "name": "Noreen Burnett"
    },
    {
      "id": "5c6ed9422248399cf2952de4",
      "name": "Allen Mcintyre"
    },
    {
      "id": "5c6ed9421995c1bdcd629d06",
      "name": "Elsa Bray"
    },
    {
      "id": "5c6ed942f10dbfba3e5b41c6",
      "name": "Walker James"
    },
    {
      "id": "5c6ed94220075eec954a0dae",
      "name": "Nita Banks"
    },
    {
      "id": "5c6ed942fbd3f411edb53230",
      "name": "Doyle Gould"
    },
    {
      "id": "5c6ed942cd7feb0ad7e78b42",
      "name": "Mcguire Pope"
    },
    {
      "id": "5c6ed9429d0b6f31a031e939",
      "name": "Tricia Hopkins"
    },
    {
      "id": "5c6ed94208c5f0b429aee20b",
      "name": "Mcintyre England"
    },
    {
      "id": "5c6ed942e4df118a8a4e3c70",
      "name": "Farley Barber"
    },
    {
      "id": "5c6ed9420dc6bb0014a0d36c",
      "name": "Adriana Tran"
    },
    {
      "id": "5c6ed942ab8497f3880c1bba",
      "name": "Angelia Riddle"
    },
    {
      "id": "5c6ed942ec1027456d1b3155",
      "name": "Hardin Franks"
    },
    {
      "id": "5c6ed9429b0031cd25ef2cde",
      "name": "Sherri Moody"
    },
    {
      "id": "5c6ed942d3dc925f14ca95dd",
      "name": "Hobbs Aguirre"
    },
    {
      "id": "5c6ed94231c5bb03e3d32dad",
      "name": "Ryan Brennan"
    },
    {
      "id": "5c6ed942d36ffc3f1d1a4352",
      "name": "Rosales Alexander"
    },
    {
      "id": "5c6ed94235921d05ad276011",
      "name": "Eleanor Maddox"
    },
    {
      "id": "5c6ed9427e16e666990d5daa",
      "name": "Haynes Willis"
    },
    {
      "id": "5c6ed9421ab59c155264fec8",
      "name": "Santos Chavez"
    },
    {
      "id": "5c6ed942e6545f6cfc61b0cb",
      "name": "Lott Harding"
    },
    {
      "id": "5c6ed94265694d4ecafd37a0",
      "name": "Henrietta Fleming"
    },
    {
      "id": "5c6ed9426dea9f61772d1d10",
      "name": "Alyson Mooney"
    },
    {
      "id": "5c6ed94293d466654e9b006f",
      "name": "Joyce Walsh"
    },
    {
      "id": "5c6ed9425ec0a5e9b407dc1e",
      "name": "Gena Hampton"
    },
    {
      "id": "5c6ed942ead4a243d2a7775d",
      "name": "Bertie Wong"
    },
    {
      "id": "5c6ed942d9fea35665c9f700",
      "name": "Courtney Blackburn"
    },
    {
      "id": "5c6ed942ebec8fd7c33afbdc",
      "name": "Harmon Melton"
    },
    {
      "id": "5c6ed9428fbb5723c85de41a",
      "name": "Glenna Sullivan"
    },
    {
      "id": "5c6ed942926aebdb479d29af",
      "name": "Adele Owens"
    },
    {
      "id": "5c6ed94235b44eca57ae126c",
      "name": "Deborah Glenn"
    },
    {
      "id": "5c6ed942bd6772286bc0b2a2",
      "name": "Osborne Harrison"
    },
    {
      "id": "5c6ed9429d7cd05c6484526e",
      "name": "Barlow Chang"
    },
    {
      "id": "5c6ed942105b2bb0bd0d1082",
      "name": "Horn Hancock"
    },
    {
      "id": "5c6ed9427cbb2864eb2e896c",
      "name": "Eve Jones"
    },
    {
      "id": "5c6ed942e92b65abca8433f4",
      "name": "Katie Richard"
    },
    {
      "id": "5c6ed942c45089f95f8a0bbf",
      "name": "Mcfadden Bentley"
    },
    {
      "id": "5c6ed94232c578c31832d181",
      "name": "Summers Calderon"
    },
    {
      "id": "5c6ed942bce870f638f6da69",
      "name": "Martinez Booker"
    },
    {
      "id": "5c6ed9425e1f43744c67f2c1",
      "name": "Beasley Howard"
    },
    {
      "id": "5c6ed94271ab8b6850f2e9e6",
      "name": "Olivia Lynch"
    },
    {
      "id": "5c6ed9424e39076ed20fb1f4",
      "name": "Brock Oneal"
    },
    {
      "id": "5c6ed942285ba70c6e70f20b",
      "name": "Eugenia Gutierrez"
    },
    {
      "id": "5c6ed942538fffd529d2f732",
      "name": "Shelia Reese"
    },
    {
      "id": "5c6ed942029a49a93d865775",
      "name": "Elena Morris"
    },
    {
      "id": "5c6ed942f568f60fbfe7c3b1",
      "name": "Mccormick Hendrix"
    },
    {
      "id": "5c6ed942802015744ec22463",
      "name": "Lynne Paul"
    },
    {
      "id": "5c6ed94247c000882da54887",
      "name": "Lakisha Mcknight"
    },
    {
      "id": "5c6ed942329bcb4d227a0729",
      "name": "Hodges Todd"
    },
    {
      "id": "5c6ed942180919ad0f4d118c",
      "name": "Colon Patel"
    },
    {
      "id": "5c6ed942df9732f9530e0ad6",
      "name": "Cohen Mcmahon"
    },
    {
      "id": "5c6ed94216d680d2a4274fcb",
      "name": "Odom Waters"
    },
    {
      "id": "5c6ed94289578f46445cb713",
      "name": "Alberta Blankenship"
    },
    {
      "id": "5c6ed9427ff46e8a08f4c1e1",
      "name": "Marlene Franco"
    }
  ]
export class Grid extends Component {
  render() {
    return (
        <BootstrapTable
          keyField="id"
          data={products}
          columns={columns}
          pagination={paginationFactory()}
        />
    );
  }
}

the lib version is:
    "react-bootstrap-table-next": "^1.2.1",
    "react-bootstrap-table2-paginator": "^1.0.3",
    "react-bootstrap-table2-toolkit": "^1.1.1"

@AllenFang  how are you Allen? I am currently experiencing an issue where every time im in the firstPage the previous button is enabled and if clicked, crashes de the app. I am currently working on a NO remote table.

Hope you are all well and sound, thanks in advance!

@AllenFang  how are you Allen? I am currently experiencing an issue where every time im in the firstPage the previous button is enabled and if clicked, crashes de the app. I am currently working on a NO remote table.

Hope you are all well and sound, thanks in advance!


User social media profiles

Added additional 3 columns to the users table:

facebook_account: type: string, for storing user's Facebook account
twitter_account: type: string, for for storing user's Twitter account
is_verified: type: boolean, true for verified accounts, and false otherwise

Also Added some code in the frontend, but commented it as I didn't like the view. So, everything is working, just need some frontend work to show it to the users.

I think a better way to address this is by creating a new model for Links in general and then add a relation to the User model (User has_many :links). This will allow the user to add as many links to their profile as they'd like.
And the client side can determine if this is a special link (social accounts, and display an icon or something).
What do you guys think?

Hmmm! You may have a point (closest to G+ profiles I presume), but I think that we shouldn't show many links in user profiles, only the famous ones, it's not a CV after all.
I was thinking of adding additional two columns for user website and G+ profile, but I thought it wouldn't be a big deal as the majority of users don't have websites and the popular social websites in the Arab world are Facebook and Twitter. I only wanted to add the links I'm sure that users have.
If you think that treating the links as a separate model would be better, I can change the code.

I think that would be a better generic solution, otherwise we'll start
receive more request to add more links and so on. People want to add their
blog, or their arabia.io profile or other stuff. Mind trying to implement
it in a separate model? Happy to discuss this further.
On Mon Feb 02 2015 at 1:50:00 PM Ahmed Gaber<EMAIL_ADDRESS>wrote:

Hmmm! You may have a point (closest to G+ profiles I presume), but I think
that we shouldn't show many links in user profiles, only the famous ones,
it's not a CV after all.
I was thinking of adding additional two columns for user website and G+
profile, but I thought it wouldn't be a big deal as the majority of users
don't have websites and the popular social websites in the Arab world are
Facebook and Twitter. I only wanted to add the links I'm sure that users
have.
If you think that treating the links as a separate model would be better,
I can change the code.
--
Reply to this email directly or view it on GitHub
https://github.com/manshar/manshar/pull/156#issuecomment-72545332.

Will implement it as you suggested, and will get back to you if I have any question.

Cool. I think we need a title and a url for the model and user_id. Anything
else?
On Mon Feb 02 2015 at 2:09:47 PM Ahmed Gaber<EMAIL_ADDRESS>wrote:

Will implement it as you suggested, and will get back to you if I have any
question.
--
Reply to this email directly or view it on GitHub
https://github.com/manshar/manshar/pull/156#issuecomment-72548935.

is this for share ? or just to show it on the user profile ? :smile: , am not in the same paper with you guys.
IMHO: for user profile, we need to show some social accounts, the minimum actually, most sites are biased on this, producthunt, gittip (gratipay now) used to add twitter exclusively ?, so of course we need a couple of them, not to mention the ability to log in socially of course.
for the implementing, any thing could work. but the neater way is always the best.
the generic one will work amazing for link aggregation : "Read it later"
so idk if it will be good there. but if we will have a separate models for aggregating and social accounts, that would be cool, amd always down for generics, that cause it to be easy on the extending and future expansions :dancer:

"the minimum actually", I like this statement. The implementation is not our problem here, the UX is.

they are related in way or another. :icecream:

I will do it in @mkhatib's way. And no, Mk, I don't think we need anything else.


[$500] Chat - Attachment page keeps on loading infinitely.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Go to https://staging.new.expensify.com/
Tap on a report
Tap plus icon near compose
Tap Add attachment
Take a picture using camera and send it
Turn off mobile data
Open the attachment

Expected Result:
Attachment page must show the image and must not load infinitely.
Actual Result:
Attachment page keeps on loading infinitely.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/6fe79ab0-0e8f-42ee-8d14-a2811d39de75
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~019f92fc532944b2e5
Upwork Job ID:<PHONE_NUMBER>717834752
Last Price Increase: 2024-03-14
Automatic offers:

situchan | Reviewer | 0
FitseTLT | Contributor | 0

@kbecciv Please check recent changes. I can't send attachments to reproduce this issue.

Hi there,
The root cause of the problem, as I see it, lies in the undefined nature of "fallbackSource" in AttachmentView. To address this, we may need to revisit and ensure proper initialization of this variable, Like:

Simple and easy way:
Implement a mechanism to display informative error messages to users when the "fallbackSource" is undefined. This enhancement aims to provide clarity in the event of an error, thus improving the overall user experience.

Using Chat Image as Fallback within the chat if "fallbackSource" is undefined.

Uploading and Hashing Images in Memory:
Uploading images to memory and subsequently hashing them after a successful upload. This approach ensures that the "fallbackSource" is always defined.

@kbecciv Please check recent changes. I can't send attachments to reproduce this issue.

I believe you can reproduce the issue on any device by following these steps

Upload any image
Immediately disconnect your internet connection after success
open the image
This results in an infinite loading state.

FYI: I am using "version": "1.4.34-1".

Could you review @situchan?

@Amoralchik thanks for the proposal. The root cause doesn't make sense to me. It's incorrect.

We're waiting proposals

@situchan Let me try once again.
I propose adding a setAllSourceError function and incorporating it into the onError handler of AttachmentViewImage. This function will set allSourceError to true if both source and fallbackSource return errors.
https://github.com/Expensify/App/blob/554276f05e0165c6705e019729c050a462176d6f/src/components/Attachments/AttachmentView/index.js#L171-L190
       onError={() => {
            setImageError(true);
            if (imageError) setAllSourceError(true);
        }}

After this, we can add a check for allSourceError in the if (!allSourceError || isImage || (file && Str.isImage(file.name))) condition, and then include:
    else if (allSourceError) return (
        <Text style={[styles.textStrong, styles.flexShrink1, styles.breakAll, styles.flexWrap, styles.mw100]}>
            Unexpected error, please try again later
        </Text>
    );

This way, if both source and fallbackSource are absent in ONYX or return errors, we can display an error message instead of getting stuck in an infinite loading loop.

Could you review this again @situchan?

@Amoralchik sorry but your latest comment still doesn't explain the root cause correctly.
For proposals to be accepted, both root cause and solution should be correctly provided.

Still looking for proposals.

@situchan - Should we raise the bounty here or start a conversation in Slack?

Thoughts on this one @situchan?

cc: @Expensify/design ^

Yeah, I would think that if you go offline, the attachment modal would not show an infinite spinner but rather some kind of small "you're offline" icon + message or something.

Curious if the other designers agree though!

I agree the infinite loading spinner isn't great, but I think this is a dupe and been around for a long time.
The real solution for this is better support for image caching, isn't it? So while you're offline, you'd see a local cached version of the attachment. That's being worked on elsewhere, starting with here. @situchan let me know if I'm missing something though!

@trjExpensify this is not image caching problem. Please check my comment.

small thumbnail image might be cached but big image with original size isn't cached as user hasn't opened attachment modal yet.

Yeah, I would think that if you go offline, the attachment modal would not show an infinite spinner but rather some kind of small "you're offline" icon + message or something.

Honestly even if we just showed the Offline icon the way we do for thumbnails, that would be better than an infinite spinner.

Agreed

@trjExpensify this is not image caching problem. Please check https://github.com/Expensify/App/issues/35502#issuecomment-1964484878.

Do you not agree this issue is the same as the issue created in Dec 2022, so it's not a "new" regression here?

small thumbnail image might be cached but big image with original size isn't cached as user hasn't opened attachment modal yet.

Oh, but in the video in the OP the user uploads a picture > goes offline > then tries to open it. If we had implemented better image caching, why wouldn't the original image be stored in the cache layer or whatever we decide to do?
A broader overview of series of improvements we're going to start chomping down on is here for ref.

Yeah, I would think that if you go offline, the attachment modal would not show an infinite spinner but rather some kind of small "you're offline" icon + message or something.
Honestly even if we just showed the Offline icon the way we do for thumbnails, that would be better than an infinite spinner.
I'm
Agreed

@shawnborton @dannymcclain @dubielzyk-expensify ultimately I'm not passionate about going forward and doing this btw, I think it sounds reasonable. 👍

Oh, but in the video in the OP the user uploads a picture > goes offline > then tries to open it. If we had implemented better image caching, why wouldn't the original image be stored in the cache layer or whatever we decide to do?

If user already opened modal before going offline, then image cache problem like you said.
But if user hasn't ever opened modal before going offline, big image is never fetched at all so cache doesn't make sense.

Okay, well sounds like we're going to add an offline indicator either way. 👍

Where'd we end up on this one @situchan? What's the next step?

This is still awaiting proposals

yes, External

Proposal
Please re-state the problem that we are trying to solve in this issue.
When attachement is loading and user is offline we show loading indicator infinitely
What is the root cause of that problem?
We show loading indicator when the image is loading here
https://github.com/Expensify/App/blob/a04481ffef2c60243c8c5680222a01a82e162916/src/components/ImageView/index.tsx#L246-L247
So when the user is offline it will not finish loading until he gets back online so it will show loading indicator infinitely
What changes do you think we should make in order to solve the problem?

We should only display it when the user is on line
            {isLoading && !isOffline && <FullscreenLoadingIndicator style={[styles.opacity1, styles.bgTransparent]} />}

And prepare a component that will be displayed when the attachement is loading but user offline. That component will depend on the UI the design team will give us but it should prompt the user is offline and the image will load as soon as the get back online
What alternative solutions did you explore? (Optional)

@situchan could you review the proposal?

yes, I will provide feedback on Monday

@situchan will update today

Could you please update @situchan?

I reviewed proposal. Will comment soon

Updating today after handling urgent PR review

@FitseTLT the proposal looks good. Do you mind sharing demo screenshot (with existing offline icon) so design team can give feedback?

Also, please make sure that we should still show the image when offline if it's previewed before and already cached locally.

In that screenshot, the icon should not be black - it should use our standard icon color.

So @shawnborton U have any other comment from design perspective??

Nope - what you have above looks correct.

Should this be assigned to @FitseTLT? @shawnborton @situchan?

Curious what @situchan thinks from a technical perspective.

@FitseTLT's proposal looks good to me.
🎀 👀 🎀 C+ reviewed

@shawnborton @marcochavezf does this bug fit in a specific wave or VIP project?

Hmm maybe #vip-vsb?

Curious what @marcochavezf thinks though!

Catching up long convo, I suspect #vip-vsb will be the best fit since it can impact any customer who attaches an image in a chat

PR will be up in 2 days

I think @marcochavezf can get copy from marketing team

I think @marcochavezf can get copy from marketing team

We're already using that copy in the App, right? I will apply the Waiting for copy label to get a second opinion

I am not sure "This feature requires an active internet connection to be used" is correct.
This feature actually doesn't require online when image is already cached.

Hi @LLPeckham, what do you think about the copy in this screenshot? https://github.com/Expensify/App/issues/35502#issuecomment-2025746302 We're already using that copy in other parts of the app, but we want to gut-check if it is suitable for not displaying attachments when the app is offline.

Definitely this cannot be used. It should be something like The attachment (image/video) will load when u get back online or sth but this feature needs connection is not right for an attachement that is seeking connection to load

@marcochavezf - the screenshot is showing as broken for me, are you able to repost? Or copy and paste the copy?

@LLPeckham

Thanks, @situchan. Ok so if this is just about attachments not being available while offline, then I agree the error copy above isn't clear enough.
We can keep the header if we want to have it the same, but I think the sub-copy should be more related to viewing an attachment than a feature requiring an active connection.
What about:
You appear to be offline.
Attachment will be available once back online.

Thanks looks good to me.
Hope @marcochavezf would agree too.
@FitseTLT let's implement that.

Sounds good, the translation would be:
El archivo adjunto estará disponible cuando vuelvas a estar en línea.

@marcochavezf The translation you gave me is for Attachment will become available once back online. right??

created draft pr and discussing with design team for some UI input 👍

I can take over this issue as a C+ reviewer because @situchan is OOO in April

What's the latest here @FitseTLT? Did you get the feedback you needed from Design?

@situchan is out OOO, reassigning a C+ via the auto-assigner for fairness.

What's the latest here @FitseTLT? Did you get the feedback you needed from Design?

Yep, working on it based on the reponse.

Looks like we've got a PR drafted that's waiting on some design input: https://github.com/Expensify/App/pull/39290

Any update @FitseTLT?

It will be ready for review by EOD

Any change @FitseTLT?

PR ready for review

PR still being actively worked on https://github.com/Expensify/App/pull/39290#issuecomment-2085198610

So close to merging...
https://github.com/Expensify/App/pull/39290#issuecomment-2110701118

Issue not reproducible during KI retests. (First week)

FYI I think this PR caused a regression, see: https://github.com/Expensify/App/issues/42316#issuecomment-2123926673

FYI I think this PR caused a regression, see: #42316 (comment)

It is not a regression but rather a missed edge case for a single/ios native platform.

Issue not reproducible during KI retests. (Second week)

Issue not reproducible during KI retests. (Third week)

Looks like the automation failed on this one and the PR was merged on May 22nd.
I'll update and add a payment summary shortly.

Closing :)

$250 approved for @mollfpr


400- Bad Request - Reset by Peer

HI,
We get the below Response, How can solve it, Is any configuration changes required?
[status] => 400
[statusText] => Bad Request
[error] => Reset by peer

我也遇到一样的问题，
使用openssl  后  就出现这样的问题


[XLA] Add DT_HALF to the list of floating point types

This should not affect the existing CPU and GPU devices, as they do not claim support for D_HALF, and the final registration for each device is the intersection of their advertised list and the global lists.
This merely adds DT_HALF as a kind of floating point number, which will allow MatMul to work with DT_HALF.
Lots of other arithmetic ops don't restrict themselves to any specific types, so they accept DT_HALF by default.
Why isn't Convolution restricted to kFloatTypes?  I don't see why convolution and matmul are not very similar in backend implementation?
[I can't imagine why I had not spotted this before]

Can one of the admins verify this patch?

@frankchn Would be good to get this one run through the unit tests.  I suspect it will be good, but it is a bit of a risk.

Jenkins, test this please.

thanks.  i suspect that the failure to build is something to do with a dependency management error by someone else.
the only file that i have changed is xla_op_registry.h and this is not mentioned.  xla_op_registry.cc is mentioned, but only because of the old favourite 'tensorflow/compiler/xla/service/hlo_instruction.h' producing a signed/unsigned comparison warning.
hopefully if I merge in master then this error will go away.

@DavidNorman The tests have been flaky lately, but can you rebase to the latest master and push again? I am happy to retest it.
@hawkinsp ping on review.

@frankchn done :)

Jenkins, test this please.


Docs updates

Fixes #
Proposed Changes

Pull Request Test Coverage Report for Build 88

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.09%

Totals

Change from base Build 86:
0.0%

Covered Lines:
55

Relevant Lines:
67

💛  - Coveralls


Fix markdown in README.md

Add missing spaces in README.md headings

Oh, I haven't noticed there are many PRs like this.
Can be closed.


onZoomEnd method is deprecated in v2

I just upgraded to v2 and stumbled upon this issue, in a ZoomableGroup component:
Unknown event handler property onZoomEnd. It will be ignored.
While the types still show
    onZoomStart?: (event: any, position: Position) => void;
    onZoomEnd?: (event: any, position: Position) => void;

it seems these methods are deprecated, judging by the fact that even the official example uses onMoveEnd now, instead of onZoomeEnd as mentioned in the docs (see Events section).
Since types are maintained in a whole different repo, should I at least open a PR updating the docs here?

Thanks for flagging, updated the docs accordingly.


Exception running simple example

c:\TFS\PracticeManagement\dev\>"C:\TFS\PracticeManagement\dev\packages\Templatus.0.2.0\tools\Templatus.exe" -t "C:\TFS\PracticeManagement\dev\Project\Template.ttus" -p name=Timmy;age=3
Degree of parallelism: 1
Starting...

Unhandled Exception: System.Exception: Error creating evaluation session: System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.Build.Framework, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified.

To enable assembly bind failure logging, set the registry value [HKLM\Software\Microsoft\Fusion!EnableLog] (DWORD) to 1.
Note: There is some performance penalty associated with assembly bind failure logging.
To turn this feature off, remove the registry value [HKLM\Software\Microsoft\Fusion!EnableLog].

   at Microsoft.FSharp.Compiler.Interactive.Shell.-ctor@2498-115.Invoke(String message)
   at Microsoft.FSharp.Compiler.Interactive.Shell.FsiEvaluationSession..ctor(FsiEvaluationSessionHostConfig fsiConfig, String[] argv, TextReader inReader, TextWriter outWriter, TextWriter errorWriter, Boolean fsiCollectible)
   at Microsoft.FSharp.Compiler.Interactive.Shell.FsiEvaluationSession.Create(FsiEvaluationSessionHostConfig fsiConfig, String[] argv, TextReader inReader, TextWriter outWriter, TextWriter errorWriter, FSharpOption`1 collectible)
   at Templatus.Core.OutputGenerator.generate(FSharpList`1 templateParameters, ProcessedTemplate processedTemplate)
   at Templatus.Main.fSuccess@1(FSharpFunc`2 f, ProcessedTemplate x, FSharpList`1 msgs)
   at Templatus.Main.processChunk@47-2.Invoke(Result`2 result)
   at Microsoft.FSharp.Primitives.Basics.List.map[T,TResult](FSharpFunc`2 mapping, FSharpList`1 x)
   at Templatus.Main.processChunk@45.Invoke(FSharpList`1 list)
   at Microsoft.FSharp.Primitives.Basics.List.map[T,TResult](FSharpFunc`2 mapping, FSharpList`1 x)
   at Microsoft.FSharp.Collections.ListModule.Map[T,TResult](FSharpFunc`2 mapping, FSharpList`1 list)
   at Templatus.Main.main(String[] _arg1)

Do you have VS installed on that machine?

Yes VS 2010 SP1, and VS 2015 with SP1 are installed

with a runtime redirect of "Microsoft.Build.Framework" (Version("<IP_ADDRESS>")) "b03f5f7f11d50a3a" it works in Visual Studio with the code in my fork, but still fails to run in LINQPad with
Degree of parallelism: 1

Starting...
Caught exception System.MissingMethodException: Method not found: 'FsiEvaluationSession FsiEvaluationSession.Create(FsiEvaluationSessionHostConfig, System.String[], System.IO.TextReader, System.IO.TextWriter, System.IO.TextWriter, Microsoft.FSharp.Core.FSharpOption`1<Boolean>)'.
   at Templatus.Core.OutputGenerator.generate(FSharpList`1 templateParameters, ProcessedTemplate processedTemplate)
   at Templatus.Main.processChunk@64-9.Invoke(ProcessedTemplate processedTemplate)
   at Templatus.Main.processChunk@64-11.Invoke(Tuple`2 tupledArg)
   at Templatus.Main.processChunk@64-10.Invoke(Result`2 result)
   at Microsoft.FSharp.Primitives.Basics.List.map[T,TResult](FSharpFunc`2 mapping, FSharpList`1 x)
   at Microsoft.FSharp.Collections.ListModule.Map[T,TResult](FSharpFunc`2 mapping, FSharpList`1 list)
   at Templatus.Main.processChunk@62.Invoke(FSharpList`1 list)
   at Microsoft.FSharp.Primitives.Basics.List.map[T,TResult](FSharpFunc`2 mapping, FSharpList`1 x)
   at Microsoft.FSharp.Collections.ListModule.Map[T,TResult](FSharpFunc`2 mapping, FSharpList`1 list)
   at Templatus.Main.createOutput@73-6.Invoke(FSharpList`1 list)
   at Templatus.Main.main(String[] s)
   at <StartupCode$query_enjpgi>.$Main.main@() in C:\Users\User\AppData\Local\Temp\LINQPad5\_ogikuift\query_enjpgi.fs:line 12

Interestingly, as far as I've tried to figure out the error only occurring in LINQPad, it appears that at the point it loads the OutputGenerator module for some reason in LINQPad it attempts to load FSharp.Core, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a from file:///C:/Program Files (x86)/Linqpad/Beta5/LINQPad.exe

If I am not mistaken, the guys maintaining the compiler service have done some adjustments to the dependency on MSBuild recently. I think updating to the latest version is worth a shot as the first problem might just go away on its own.
As far as the second problem is concerned, I believe that the compiler services require FSharp.Core.optdata and FSharp.Core.sigdata right next to FSharp.Core.dll, which is why they're a part of Templatus' Nuget package. So, regardless of why LinqPad tries to load FSharp.Core from a different location, the absence of the 2 extra files might be the cause of the issue.
FSharp.Core as a dependency is a huge mystery to me.

b01fdba fixes this for me (indeed by updating the compiler service). Unless you still have any issues (apart from LinqPad), I'll release a new nuget package.


Use rvm for deployment only when available

Our Windows image does not have rvm installed, so the deployment
will fail. In such a case, we will try installing dpl with the one ruby we have.

Here's a test from yesterday: https://staging.travis-ci.com/BanzaiMan/com_testing/builds/233647
On Windows, I/O can happen out of order, and it is a little difficult to see that it is working here. https://staging.travis-ci.com/BanzaiMan/com_testing/jobs/233648#L77 shows the script deployment's output "yes!" (among other outputs from deployment) before deployment's folds happen.
Today, the deployment is failing because Sauce Labs is having a problem and our deployment currently depends on it.


[JavaCC] JavaCC compilation issue

I'm trying to compile a JJT file using JavaCC on my own, but I'm not sure if the placement of the comment at line 743, which is 'Block Block() #Block,' is correct.
Block Block() #Block :
Or could it be an issue with my JavaCC version? The compiler no longer reports an error when I change it to 'Block Block() :.' I apologize, as I am new to using JavaCC.
Block Block() :

I am sorry, but this is not a JSQLParser issue, but rather a question about how to use JavaCC.
You could easily use the Maven or Gradle JavaCC plugin as shown in the JSQLParser build.


WIP: Add gateway-api

testing...

Codecov Report

Merging #18 (3b3ef9f) into main (215d013) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   87.39%   87.41%   +0.02%
==========================================
  Files         195      195
  Lines        9638     9638
==========================================
+ Hits         8423     8425       +2
+ Misses        931      929       -2
  Partials      284      284

Impacted Files
Coverage Δ

pkg/autoscaler/statserver/server.go
79.61% <0.00%> (+1.94%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 215d013...3b3ef9f. Read the comment docs.


Very quiet videos...

I've built the latest commit and the app is still very quiet when playing videos. It should be 2 even 3 times louder. I have a speaker wired up as well so my device could go even louder than that. Possibly even adding an autogain to the converter script.

same

I've required my flipper and removed the buzzer so it's been replaced with a very decent laptop speaker. Volume and quality is improved over the buzzer but it leaves more to be desired from both as it has a much higher capacity to sound better.


Can't ignore tube with name 200 chars long

Though it is possible to watch a tube with a name 200 char long, it is not possible to ignore that tube. Ignoring a tube of len 200 returns BAD_FORMAT.
I haven't been able to figure out why however since ignore seems to use the same pattern for checking the length of the tube name that watch uses. Len 199 does work for me, so probably a comparison type issue somewhere.
Ultimately, since a tube with a name 200 chars long cannot be used (as noted by #211), there's not much reason to watch such a tube until that is fixed.
You should be able to reproduce this issue with the following:
watch xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
ignore xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

For reference, I am using version 1.9+9+g157d88b on Ubuntu 12.04.

Fixed in 2279f1815d33d1eddacbaaca0b09384c4c50c1f6.


Add function latest_article to class section_page

@miltontony @smn ready for review

:+1:

Just a note that this will need a new release for you to be able to use it

@miltontony yes thanks :)


🎨 Extend release drafter

Type of Change

[ ] Bugfix
[x] Enhancement / new feature
[ ] Refactoring
[ ] Documentation

Description

add explicit secrets to release drafter
add hint for GITHUB_TOKEN limitations

Checklist

[x] Add relevant labels (for example type of change or patch/minor/major)
[x] Make sure not to introduce some mistakes
[x] Update documentation
[x] Review the Contributing Guideline and sign CLA
[ ] Reference relevant issue(s) and close them after merging

Sorry for jumping in so late, but I am not happy with this implementation. The default behavior was to use the GitHub Token without it being provided by the calling workflow. Now we need to update the workflows everywhere. Can we switch the behavior to use the GitHub Token by default and only use the app credentials if they are provided? What was the purpose of removing that default setting?


[multiple] Fixes cold start errors for Firestore extensions (issue #48)

Fixes https://github.com/firebase/extensions/issues/48
Extensions affected:
delete-user-data
firestore-counter
firestore-send-mail
firestore-shorten-urls-bitly
firestore-translate-text
There are also some trivial changes to jest.config.js files, that was done by the auto formatter when I ran "npm run format" from root.
Commands I ran from root directory:
npm run format
npm run lint
npm run test
npm run build

@Salakar and @Ehesp can you verify that the changes to jest.config.js are OK?

Closing because there might be a better approach that doesn't add a large dependency (which has impact on cold start & install times. )


Added two unit test for point

Fixes #2512

Added two unit tests for Point data class

isEmpty()
getArea()

These tests confirm that if in future the hardcoded value of Point changes, these test will fail and notify team to update test or to make sure the changes are correct or not.

@shobhitagarwal1612 PTAL?

/gcbrun


Using CRUH/CRUSH/MIX for RUL

Hello - I'm new to ML.
I have an assignment to train a model for battery RUL. Kindly answer the following questions:
How can I download CRUH/CRUSH/MIX? Do I just download the datasets they use and use them together?
How do I get the RUL estimations? Do I have to train the model myself?
note: I'm after the dataset and its results only, not the training (though I'll use the paper and the training results as a benchmark for my University assignment)

CRUH and CRUSH requires some datasets from the Battery Archive. At the time we started to develop BatteryML, their datasets are directly download-able from their website. Nowadays you should email them to ask for the datasets. We will incorporate more data soon.


Example usage of onClick

I am currently attempting to use 'onClick' as per the instructions, however I get the following error:
'Uncaught TypeError: this.onClick is not a function'
Please add an example of onClick being used to the documentation.

@kirk2022 can you show your usage?
onClick needs to be a function for example:
<vue-good-table
      :columns="columns"
      :onClick="onClickFn"
      :rows="rows"/>
// where data
data(){
      return {
       // rows, columns ...
        onClickFn: function(){
          console.log('something random');
        },
      };

readme updated to better show this. closing.


Description missing

Hi guys, thanks for the work 👍
I just found this bot and found that there is not proper description what is he doing and how.
Can you add this?

Hi, I apologize for the delay in response.
In the nearest future, I will try to create some description, but at this moment I have some other improvement to do.

@distolma  Thanks


LTFS Extended Attributes

I've been trying to write extended attributes (EA) to files stored on an LTO-5 tape but have been prevented from writing EAs that begin with user.ltfs.*.  This seems like it may be a bug so I wanted to highlight the issue and seek advice/feedback.
IBM's documentation (https://www.ibm.com/docs/en/spectrum-archive-sde/<IP_ADDRESS>?topic=tips-extended-attributes) on this subject is slightly confusing and seems to imply that Linux systems would save user.* attributes and yet as I will show later, the schema doesn't show user.* EAs.  It seems that Linux is unusual in already having defined prefix's for file EAs, unlike Windows and Mac OSX.  On a Linux file system a user is only permitted to write an EA that begins with user.*.  As an example the attribute ltfs.hash.md5sum on Windows and Mac is written as user.ltfs.hash.md5sum under Linux. An SNIA LTFS Format Specification document (https://www.snia.org/sites/default/files/technical_work/LTFS/LTFS_Format_2.4.0_TechPosition.pdf) mentions on page 83 that hash values may be stored in the form of ltfs.hash.<hashtype> as an LTFS extended attribute.
After some experimentation it seems that the current ltfs implementation here prevents any EA that begins user.ltfs from being written to a file stored on an LTFS volume.  Consider the following examples:
$ setfattr -n user.ltfs.hash.md5sum -v dbb78ccc96d658b5a00ebbe543a9706e /mnt/ltfs/python/md5sum.py
setfattr: /mnt/ltfs/python/md5sum.py: Permission denied

$ setfattr -n ltfs.hash.md5sum -v dbb78ccc96d658b5a00ebbe543a9706e /mnt/ltfs/python/md5sum.py
setfattr: /mnt/ltfs/python/md5sum.py: Operation not supported

$ xattr -w user.ltfs.hash.md5sum dbb78ccc96d658b5a00ebbe543a9706e /mnt/ltfs/python/md5sum.py
[Errno 13] Permission denied: b'/mnt/ltfs/python/md5sum.py'

and yet the following is fine
$ xattr -w user.rabbit.hash.md5sum dbb78ccc96d658b5a00ebbe543a9706e /mnt/ltfs/python/md5sum.py
$ xattr -p user.rabbit.hash.md5sum /mnt/ltfs/python/md5sum.py
dbb78ccc96d658b5a00ebbe543a9706e

and for files not stored on an ltfs volume
$ xattr -w user.ltfs.hash.md5sum dbb78ccc96d658b5a00ebbe543a9706e /home/lee/Documents/md5sum.py
$ xattr /home/lee/Documents/md5sum.py
user.ltfs.hash.md5sum
$ xattr -p user.ltfs.hash.md5sum /home/lee/Documents/md5sum.py
dbb78ccc96d658b5a00ebbe543a9706e
$ getfattr -d /home/lee/Documents/md5sum.py
getfattr: Removing leading '/' from absolute path names
# file: home/lee/Documents/md5sum.py
user.ltfs.hash.md5sum="dbb78ccc96d658b5a00ebbe543a9706e"

One oddity I've found using Debian is that the attr package (which also provides getfattr and setfattr) doesn't report the user prefix (even though getfattr does), which confused me to begin with so I thought it worth pointing out.
$ attr -l /mnt/ltfs/python/md5sum.py
Attribute "rabbit.hash.md5sum" has a 32 byte value for /mnt/ltfs/python/md5sum.py

An extract from the tape schema recorded following unmounting of the tape is shown below and demonstrates that the EAs are reported without the leading user.* prefix which is what I'd expected for cross platform compatibility.
<ltfsindex version="2.4.0">
<creator>IBM LTFS <IP_ADDRESS> (Prelim) - Linux - ltfs - Unmount</creator>
...
<file>
<name>md5sum.py</name>
<length>4608</length>
<readonly>false</readonly>
<creationtime>2021-06-20T14:54:07.289473210Z</creationtime>
<changetime>2021-06-21T19:23:49.361383276Z</changetime>
<modifytime>2021-06-13T15:13:35.247889000Z</modifytime>
<accesstime>2021-06-21T19:14:16.846963870Z</accesstime>
<backuptime>2021-06-20T14:54:07.289473210Z</backuptime>
<fileuid>4</fileuid>
<extendedattributes>
<xattr>
<key>rabbit.hash.md5sum</key>
<value>dbb78ccc96d658b5a00ebbe543a9706e</value>
</xattr>
<xattr>
<key>squirrel.hash.md5sum</key>
<value>dbb78ccc96d658b5a00ebbe543a9706e</value>
</xattr>
</extendedattributes>
<extentinfo>
<extent>
<fileoffset>0</fileoffset>
<partition>b</partition>
<startblock>8</startblock>
<byteoffset>0</byteoffset>
<bytecount>4608</bytecount>
</extent>
</extentinfo>
</file>

For reference, the tape was formatted and had data written to it using "LTFS version <IP_ADDRESS> (Prelim)", the latest stable-2.4 build downloaded and compiled 2 weeks ago. The OS used is Debian 10 (Buster) on an Intel x64 platform using an HP LTO-5 Ultrium 3000 tape drive in an external SAS enclosure and an HP SAS9205-4i4e HBA.

At this time,  EAs for hash value is not implemented at all. So LTFS rejects the request against user.ltfs.hash.foo (in Linux) because under user.ltfs is reserved area.
From the format point of view, they are optional (See F.3.1 in the LTFS Spec 2.4). So it is not a violation. But it is good to support in the near future.


SVG Fragment identifiers - Safari Technology Preview now supports it.

It was fixed in release 40.
https://developer.apple.com/safari/technology-preview/release-notes/#r40

Thanks!


Can cli.py be renamed to main.py to allow python -m identify?

Refer https://docs.python.org/3/library/main.html#main-py-in-python-packages
TIA!

no thanks


Compilation error: 'USBSerial' was not declared in this scope

I use the Arduino IDE (v.2.2.1) and have M5Stack board manager 2.0.8 and M5CoreS3 library v0.0.4
When I try to compile HelloWorld.ino from the examples directory, I get:
Compilation error: 'USBSerial' was not declared in this scope

When I comment out the SerialUSB statement in the example, the compiler now complains about USBSerial in the I2C_IMU library.

None of examples seem to compile, so I must be doing something wrong.

@ropg I also encountered the same problem, but I was able to resolve it by uninstalling V0.0.4 and installing the latest revision.
The following revision appears to have fixed the problem.
https://github.com/m5stack/M5CoreS3/commit/a9187b74aa3d6c90cc2cfc8f7e6d466ae3dd6cd7
Below is the procedure I have tried. I hope this will be helpful.
1. Uninstall V0.0.4
Remove V0.04 in Library Manager.

2. Download zip
Download the latest revision from this repository.

3. Install the zip to Arduino IDE
Select menu. Sketch -> Include Library -> Add .ZIP Library

Select the ZIP file you downloaded in Step 2.

4. Build

Thank you! this fixed it for me, too. The one installed via the package manager is broken.

OK, some stuff now works. Sadly no example how to talk to the touch screen, some examples do not compile and boy these people hate documentation and clarity.

OK, some stuff now works. Sadly no example how to talk to the touch screen, some examples do not compile and boy these people hate documentation and clarity.好的，现在一些东西可以运行。可惜没有关于如何与触摸屏交互的示例，有些示例无法编译，这些人讨厌文档和清晰度。

Add it.
https://github.com/m5stack/M5CoreS3/blob/9e73b0a61e91e7270850a0ca56c041f58cc108d3/examples/Basic/button/button.ino


add refresh button and show/hide expired button on namespace page

before:

after:

fixed with 32adc15c


Update index.md

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

jasontest0712/index.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Wildly incorrect parse error

My build.sbt looks like:
import com.unhandledexpression.sbtclojure.ClojurePlugin.clojure
import Keys

scalaVersion := "2.11.6"

seq(clojure.settings :_*)

resolvers += "clojars" at "http://clojars.org/repo/"

libraryDependencies += "org.scalatest" % "scalatest_2.11" % "2.2.4" % "test"
libraryDependencies += "org.scalacheck" %% "scalacheck" % "1.12.2" % "test"
libraryDependencies += "org.clojure" % "clojure" % "1.6.0"
libraryDependencies += "instaparse" % "instaparse" % "1.4.0"

// Remove the clojurec Task from the standard `compile` dependencies
clojure.clojurec in Compile := Seq.empty

clojure.clojurec <<= clojure.clojurec.dependsOn(Keys.compile)

(I'm using the sbt-clojure plugin for clojure interop.) Things get interesting when I run sbt:
$ sbt
[info] Loading project definition from /.../project
[error] ======
[error] import com.unhandledexpression.sbtclojure.ClojurePlugin.clojure
[error] import Keys
[error]
[error] scalaVersion := "2.11.6"
[error]
[error] seq(clojure.settings :_*)
[error]
[error] resolvers += "clojars" at "http://clojars.org/repo/"
[error]
[error] libraryDependencies += "org.scalatest" % "scalatest_2.11" % "2.2.4" % "test"
[error] libraryDependencies += "org.scalacheck" %% "scalacheck" % "1.12.2" % "test"
[error] libraryDependencies += "org.clojure" % "clojure" % "1.6.0"
[error] libraryDependencies += "instaparse" % "instaparse" % "1.4.0"
[error]
[error] // Remove the clojurec Task from the standard `compile` dependencies
[error] clojure.clojurec in Compile := Seq.empty
[error]
[error] //
[error] clojure.clojurec <<= clojure.clojurec.dependsOn(Keys.compile)
[error] ======
[error] [/.../build.sbt]:4: '.' expected but ';' found.

Not only is this error message unhelpful, there is no semicolon anywhere in the file at all!

Wow, you're getting attacked by scala's silent ; addition at the end of statements...

@jsuereth Interesting... I had no idea that scala had such nonsense.

There's a PR against scala to offer a less cryptic message.

@som-snytt that's great to hear. do you have a link to that PR by chance?


Added bash as explicit dependency to fix OSX issue

Describe your changes
Improved ordering of bashpile.rb dependencies.
Issue ticket number and link
Fixes Bug #25.  Debian build wouldn't work, Brew path not passed into Bashpile JVM shell
Merge to Development - Checklist before requesting a review

[x] I have performed a self-review of my code.  It runs with mvn clean verify
[x] I have added thorough tests.

Merge to Main - Checklist before requesting a review

[x] I have installed this version locally
[x] I have tested on Debian with docker build --no-cache -t "debian-bashpile" src/test/resources/docker/debian
[x] I have regenerated the docutils documentation with bin/generate-docs

LGTM

Merge into develop


ocamlPackages.tls*: 0.15.2 -> 0.15.3

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Closed because this needs to be upgraded in lock-step with the janestreet packages.  Working on that in another PR.


Chester helping out

added tag to images, standardized image imports and bottombar, deleted placeholder image, fixed formatting @Nielsencu  review and merge b4 doing anything if not there will be merge conflicts

tag looks like that (bottom left).

@thewongwayround would need you to deconflict the files, thanks chester!

nielsen has went ahead with his branch. changes made here are now obsolete so i will be closing this PR


removes proto files from celestia-core

Description
Moves proto files to celestia-core.
Closes: https://github.com/celestiaorg/celestia-core/issues/566

For the Protobuf CI, will we still need it ? Since it basically checks if the proto files are not deleted...
Maybe move it to spec repo ?

For the Protobuf CI, will we still need it ? Since it basically checks if the proto files are not deleted...
Maybe move it to spec repo ?

yeah good idea, we no longer need to check if the proto is breaking here. I also don't think that we have to check that the proto is breaking in the specs repo either, as most PRs will be changes to the proto files.
imho, I think we can remove that check

Sounds good, thanks. Will remove it then look at e2e test

Was thinking about this a bit more, and it might be the case that the e2e test is failing because we could be using mismatched versions of the proto files and tendermint. I would think that more tests would fail if that's the case, but either way, we need to make sure that we use matching versions of each.
This could mean ditching the master branch all together, and only use the latest stable version, or some ABCI++ verison.

great find!

Sure, will do. Thanks

Can you do it please? I don't have permissions


sqlite: query! borrows Copy parameters

I've struck a strange issue with sqlite.
This code
fn query<'a, 'c: 'a>(
    con: impl Executor<'c, Database = Sqlite> + 'a,
    limit: i64,
    offset: i64,
) -> BoxStream<'a, sqlx::Result<i64>> {
    sqlx::query_scalar!("SELECT id FROM users LIMIT ? OFFSET ?", limit, offset).fetch(con)
}

fails to compile with sqlite with this error:
error[E0515]: cannot return value referencing function parameter `limit`
  --> example-sqlite/src/main.rs:23:5
   |
23 |     sqlx::query_scalar!("SELECT id FROM users LIMIT ? OFFSET ?", limit, offset).fetch(con)
   |     ---------------------------------------------------------------------------^^^^^^^^^^^
   |     |
   |     returns a value referencing data owned by the current function
   |     `limit` is borrowed here

error[E0515]: cannot return value referencing function parameter `offset`
  --> example-sqlite/src/main.rs:23:5
   |
23 |     sqlx::query_scalar!("SELECT id FROM users LIMIT ? OFFSET ?", limit, offset).fetch(con)
   |     ---------------------------------------------------------------------------^^^^^^^^^^^
   |     |
   |     returns a value referencing data owned by the current function
   |     `offset` is borrowed here

error: aborting due to 2 previous errors; 2 warnings emitted

The same happens with query! and query_as!. The equivalent code compiles fine on MySql and Postgres.
It's only on sqlite that the stream borrows the parameters.

I see that this error is raised because a local value here is borrowed. The local value itself is borrowed from the argument bindings. This means that even if a reference with static lifetime is used for argument binding, we will still see an error.
let arg_bindings = quote! {
    #(let #arg_name = &(#arg_expr);)*
};

IMHO, passing by reference should be the users responsibility. But we can't break this syntax now. Maybe this should be part of #875.
I have a more backward compatible solution in mind. Would it make sense to allow prepending & before the argument to signal that its already a reference? So if arg_expr is already a reference then we don't prepend &. This would allow the following code to work
fn query<'a, 'c: 'a>(
    con: impl Executor<'c, Database = Sqlite> + 'a,
    limit: &'x i64,
    offset: &'x i64,
) -> BoxStream<'x, sqlx::Result<i64>>
  where
    'a: 'x
{
    sqlx::query_scalar!("SELECT id FROM users LIMIT ?  Do you think its worth spending time on this?

I just ran into this as well, is there any way to work around this?

I'm hitting this problem as well :-(


model export to the database raises an error of unexpected keyword argument

The following error showed when running flow model export -c ${path_to_config} --to-database:

I found it's solved in 1.9.1, will close it


[9.x] Add existsWhere to Eloquent Builder

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


chore: regenerate README from templates

Dependent on adding the min_java_version in https://github.com/googleapis/synthtool/pull/577

Just the docs link that needs an update. LGTM.


Fix control multiple switches at once causes MALFORMED_REQUEST error

Added an async queue to the main controller in the processor/consumer pattern to deal with incoming requests. This causes all incoming requests to change state to have an 800ms delay between calls as specified in the official Deako github to avoid request corruption by the devices.
TODO: make the delay configurable

Hey @sebirdman, could you please review these changes? :)

I wanted to be able to configure the delay time using a configuration parameter, but thought I would get this reviewed first before I invest more time into it.

This looks pretty good to me.
Do you think the time needs to be configurable?

Depends on the direction you want to take this project.
Having this configurable could be a good setting for someone that only has one or very few light switches. For a lot of light switches, 800ms is pretty much the sweet spot, but you can probably make them a little more responsive with some trial and error.

Lets merge it for now and then maybe put a separate MR for tweaking it later.


Automatically set Random Password when Password Parameter not specified

With MSOnline I use to create Accounts using Azure Automation.
In MSOnline, when I don't specify a password, a random password is set and displayed in the result.
In my code I pick this result and send the password to the users via an Alternate Email- Address.
Is this possible in New-AzureAdUser?
The switch from MSOnline to Azure AD Module is making easy, straight- through things as complicate as possible. Password- Setting and Licenses Assingment are only two examples!

Hi @mwe-microsoft
Thank you for your issue submission.  I have created a work item to track this issue and will be sending it to engineering.  At this point, I am going to go ahead and close this issue.  I will post an update as soon as I have any additional information.
Thank you!
Bill


Build the OpenVPN AMI on a Graviton (AMD64) instance

🗣 Description
This pull request modifies the Packer code to build the OpenVPN AMI on a Graviton (AMD64) instance.
💭 Motivation and context
Running the AMI on Graviton should be cheaper and better for the environment.
🧪 Testing
All automated tests pass.  I also built a staging AMI with these changes and verified that it functions as expected.
✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[ ] All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
[ ] All new and existing tests pass.
[ ] Build and test a staging AMI with these changes.

✅ Pre-merge checklist

[ ] Finalize version.

✅ Post-merge checklist

[ ] Create a release.

The CDM Nessus agent does not support ARM64 on Debian, although it does on Ubuntu.

The CDM Nessus agent does not support ARM64 on Debian, although it does on Ubuntu.

Do you think the Ubuntu package may work given the relationship between Ubuntu and Debian?

The CDM Nessus agent does not support ARM64 on Debian, although it does on Ubuntu.

Do you think the Ubuntu package may work given the relationship between Ubuntu and Debian?

My thought was to convert to an Ubuntu base AMI instead of restoring to such chicanery.

Closed in favor of #112.


firmware error D415

Required Info

Camera Model
D415 }

Firmware Version
<IP_ADDRESS>

Operating System & Version
{Win (10)

Issue Description
Cannot update the firmware to <IP_ADDRESS> using DFU tool
The issue in the DFU tool
=======================================================================================================
Intel (TM) Firmware Update:
[1] Intel(R) RealSense(TM) 415 Depth (FW Version: <IP_ADDRESS>)
Enter camera number to update: (any out of bounds index to go back to main menu)1
Enter path and filename (e.g. c:\Documents\newFirmware.bin: )c:\Documents\newFirmware.bin
Updating firmware to c:\Documents\newFirmware.bin
WaitForState(DFU_STATE::dfuMANIFEST_WAIT_RESET, 30000) Failed with status-2147467259
ManifestAndReset() Failed with status-2147467259
Press any key to continue . . .

the bin file from intel was missing solved


Adopt Inline Caching from AST interpreter in BC one

Made the BC interpreter use the same inline caching strategy as the AST one, through relying on a CachedDispatchNode instead of the previous two lists for expected layout and invoke. This makes the max inline cache go from 2 to 8 (the value of INLINE_CACHE_SIZE, used in the AST interpreter)
This causes many minor slowdowns of around 2-4%, with some benchmarks (Mandelbrot, NBody) seemingly experiencing closer to 10% slowdowns. Some benchmarks seem to get a bit more performance out of it, around 2-5%

The performance issues seem resolved now: https://rebench.dev/RPySOM/compare/6ad9262edc431f9b2155b9f945263c9b255a41b3..d3896e26eaa9a3b0786f454f6dc5131f80955abc
I am seeing some good performance gains across the board.
There are some slowdowns, not sure what they are about, might be noise, might not be. Unclear. But Mandelbrot shouldn't have any inline caches, so, I count that one as noise.
This seems to be the last old one, which doesn't actually seem too bad either:
https://rebench.dev/RPySOM/compare/51f41feda17521b4e8723a6b6958b4b36c6e2d13..76c352250aac846e22bf425da0c59ff4b77c0696

Ah, right, this would now be ready to merge, I think.


trailingSlash: "always" changes external URLs

Describe the bug
When using configuration: trailingSlash: "always" then external URLs will also get a trailing slash.
There is a workaround if you set some kind of taget to the anchor element. For example target="_self" but it's still a bug that shoud be fixed.
Reproduction
You can see repro: https://sveltejs-kit-template-default-tq3lbk--3000.local.webcontainer.io/
"Click me" should link to the URL: https://example.com/foo.php?bar=baz&more=params
But it actually navigates to: https://example.com/foo.php/?bar=baz&more=params
Notice the extra slash before the question mark.
You can see source of this example: https://stackblitz.com/edit/sveltejs-kit-template-default-tq3lbk?file=src/lib/header/Header.svelte
Logs
No response
System Info
not applicable

Severity
annoyance
Additional Information
No response

A workaround right now is adding rel="external" to the a tag to mark the link as external.
(To other maintainers: I hope I got the labels right.)

I'm seeing similar problems, but it is even worse. I have a statically generated site and the HTML has the links right (no trailing slash), but on click, something adds the slash before navigating.  This happens for external links, but also to internal links to static assets like PDFs. So Download PDF is generated correctly, but if someone clicks it, they get a 404.  The rel="external" trick doesn't make sense for the static asset use case. Finding and modifying all of the links to add extra attributes isn't ideal, so I'm hoping someone picks this up.  The broken links on our site are not a good look.

Update: the target="_self" trick does not seem to work for me as a workaround -- at least not when the link is to a local asset. The problem also happens when referencing things like images.

[...] The rel="external" trick doesn't make sense for the static asset use case. Finding and modifying all of the links to add extra attributes isn't ideal, so I'm hoping someone picks this up. The broken links on our site are not a good look.

You can use rel="external", the download attribute or the sveltekit:reload, see https://github.com/sveltejs/kit/blob/373ff63433cfca3ac7119a5d6da7956dfb5f4740/packages/kit/src/runtime/client/client.js#L1158
I think, in your case I would use the download attribute.

Nice, the sveltekit-reload option looks like the "right" way to bypass the javascript navigation when that's needed and that will workaround. Appreciate the code reference.
The function that adds the slash is here: https://github.com/sveltejs/kit/blob/373ff63433cfca3ac7119a5d6da7956dfb5f4740/packages/kit/src/utils/url.js#L49
Seems like it could detect non-relative links easy enough, but unfortunately, I'm not sure how that function (or the navigate function that calls it) might be able to discern static assets from routes before adding the slash.  For now I guess I'll go annotate all the links I can find that are broken, but hopefully someone with more experience in Svelte Kit can craft a fix.


Updated Documentation for GEDDatasets

Added some caveats for working with this Dataset for Graph Similarity Computation. (PR ready to be merged)

Codecov Report

Merging #2773 (2fc64f6) into master (0b107cb) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2773      +/-   ##
==========================================
- Coverage   84.54%   84.49%   -0.05%
==========================================
  Files         206      206
  Lines        9400     9371      -29
==========================================
- Hits         7947     7918      -29
  Misses       1453     1453

Impacted Files
Coverage Δ

torch_geometric/data/temporal.py
28.57% <0.00%> (-2.68%)
:arrow_down:

torch_geometric/utils/homophily.py
85.71% <0.00%> (-1.25%)
:arrow_down:

torch_geometric/nn/models/schnet.py
18.90% <0.00%> (-0.41%)
:arrow_down:

torch_geometric/data/data.py
91.45% <0.00%> (-0.37%)
:arrow_down:

torch_geometric/nn/models/dimenet.py
18.92% <0.00%> (-0.29%)
:arrow_down:

torch_geometric/transforms/gdc.py
78.10% <0.00%> (-0.22%)
:arrow_down:

torch_geometric/data/graph_saint.py
97.97% <0.00%> (-0.05%)
:arrow_down:

torch_geometric/nn/models/gnn_explainer.py
94.33% <0.00%> (-0.04%)
:arrow_down:

torch_geometric/nn/conv/rgcn_conv.py
98.51% <0.00%> (-0.03%)
:arrow_down:

torch_geometric/nn/models/re_net.py
100.00% <0.00%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b107cb...2fc64f6. Read the comment docs.

Thanks a lot. This should be helpful :)


Storage Format XHTML for home

The XHTML format (see storageformat_guide) seemed unsupported.
<site> <home uri="xhtml/mydoc.xhtml" name="pagename"> </site>
I get the one-on-one replication of the mydoc.xhtml on the page. E.g. <ac:link> instead of a link.

Hi
Which version are you using ... ? the last one ?

I've tested following page against last release and all seems work well

Running into above problem with Release 5.0-rc1 from MAVEN CENTRAL also with your example page.
Also strange: the expression <![CDATA[got to home]]>in storageFormat.xhtml becomes

<![CDATAgot to home]>

on the confluence page, missing the inner square brackets.

Oops. Wrong button

Which version of confluence are you using ?

I confirm that testing page on  confluence 5.10.0  all seems work well

To test I use module maven-confluence-test running task mvn confluence-reporting:deploy@local

Giving up on Confluence 6.0.1 (data-aui-version="5.10.1"??) while getting message
error generating report: unexpected port: -1 using module maven-confluence-test running
task mvn confluence-reporting:deploy@local

Such error looks a bit weird ... it isn't related to storage format but seems mostly related to configuration. I'll investigate on
However, about Storage Format issue,  I'll try with 6.0.1

Seems that the problem: error generating report: unexpected port: -1 should be related to getting port from URL parsed using given end point and passed to OkHttp3.HttpUrl.Builder()
To simplify diagnosis and fix it,  could you share your endpoint ?

Storage Format - "error generating report: unexpected port: -1"  #133

Can you retry using module maven-confluence-test running
task mvn confluence-reporting:deploy@local on version 5.0-SNAPSHOT ?
Thanks in advance

I have tested storageFormat.xhtml page on  confluence 6.0.1 and  all seems work well

To test I use module maven-confluence-test running task mvn confluence-reporting:deploy@local

Sorry, can't reproduce error on maven-confluence-test. Instead getting a
org.springframework.transaction.UnexpectedRollbackException: Transaction rolled back because it has been marked as rollback-only.
My endpoints are of the form
<endPoint>https://intranet/confluence/rpc/xmlrpc</endPoint> or
<endPoint>https://intranet/confluence</endPoint>

In my experience the error: Transaction rolled back because it has been marked as rollback-only is raised when there is another page in another space or in different parent that has the same title of one that you are trying to generate.
Hope this help


Adds game fortnight

Description
Adds game FortNight
Fixes:  #1942

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] I have made this from my own
[x] I have taken help from some online resourses
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

@Sulagna-Dutta-Roy I have added all the reqd files and also the manifest files. Please merge this


Support for add all features

Support for add all features
import pandas_ta as ta
df = pd.read_csv(csv_path)
df = ta.add_all_ta_features(df, open="open", high="high", low="low", close="close", volume="volume", fillna=True)

Thanks

Hello @diegolovison,
Thanks for using Pandas TA!
On the README, it shows you how to run ALL the indicators/features with the strategy method, you just have to use the DataFrame mode.
In short:
import pandas as pd
import pandas_ta as ta

df = pd.read_csv("path/to/symbol.csv") # Or however you access data
df.ta.strategy(verbose=True) # Runs ALL the indicators and appends to the DataFrame
print(', '.join(list(df.columns)))

Here is the README excerpt on the strategy method and how to create Strategies in this Example Notebook.

Add a :star: if you find this library useful.
Thanks,
KJ


Recursion

Can this be used for recursive async functions?

Yes, for example:
    #[test]
    fn recursive_test() {
        #[async_recursion::async_recursion]
        async fn recursive(data: &mut String, count: usize) {
            if count == 10 {
                return;
            }
            data.push('a');
            recursive(data, count + 1).await;
        }
        let rt = make_runtime();
        let scoped = scoped(rt.handle());
        let mut data = String::new();
        scoped.scope(|scope| {
            scope.spawn(async {
                recursive(&mut data, 0).await;
            });
        });
        assert_eq!(data, "aaaaaaaaaa");
    }

    #[tokio::test(flavor = "multi_thread")]
    async fn recursive_test2() {
        #[async_recursion::async_recursion]
        async fn recursive(data: &mut String, count: usize) {
            if count == 10 {
                return;
            }
            super::scope(|scope| {
                scope.spawn(async {
                    recursive(data, count + 1).await;
                });
            });
            data.push('a');
        }
        let mut data = String::new();
        recursive(&mut data, 0).await;
        assert_eq!(data, "aaaaaaaaaa");
    }

Is this not what you had in mind?

How do the nested calls stay within the same scope if you aren't passing the scope variable to them? Unless the async_recursion macro is doing more than I thought it was doing


Official Gradle Wrapper Validation Action

See: https://github.com/gradle/wrapper-validation-action

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 All committers have signed the CLA.

 All committers have signed the CLA.

 All committers have signed the CLA.


Ability to ignore some filenames with yml/file-extension

Hi!
First of all, thank you for all your work, not only this plugin - I use your solutions every day and work becomes much easier with it :)
I noticed the new rule yml/file-extension doesn't have an option to skip some filenames.
I personally prefer full .yaml extension, but some environments doesn't provide a way to use it.
For example, dependabot.yml is forced to have .yml extension - it's just doesn't work if you rename it to use .yaml.
(Actually I checked this like a year ago, but I didn't see any updates on this)
Also I never saw .gitlab-ci.yml file written with full extension - maybe there is the same limitation.
I use the shared ESLint configuration across all projects and it seems a bit annoying to reconfigure the rule per-project again and again :)
So, can we extend this rule to skip some names?
Like:
'yml/file-extension': ['warn', {
  extension: 'yaml',
  caseSensitive: true,
  ignore: [
    '.gitlab-ci.yml',
    'dependabot.yml',

   // I'm not sure we have the full path in the code,
   // but if - would be nice here
   /\.github/
  ]
}]

Can this be done? Do you need a PR?
Thanks :)

Thank you for posting issue.
I think you can already make some files ignored.
  "overrides": [
    {
      "files": [".gitlab-ci.yml", "dependabot.yml"],
      "rules": {
        "yml/file-extension": ["off"]
      }
    }
  ]

https://eslint.org/docs/latest/user-guide/configuring/configuration-files#how-do-overrides-work
So I don't think we need new options. What do you think?

Yeah, I did exactly that for a couple of projects locally, but for some reason I didn't think about doing it once in a shared configuration.. Kinda brainlag, sorry for your time and attention to this. :)
Although I still think this is may be a good option within the rule itself, this is not an issue anymore - overrides is a good option as well.
Thank you for help and quick response, I close this.


Fix problem loading daily chart on node page

Fix for #424 by referencing base site url plus daily report location.

Coverage remained the same at 81.76% when pulling be78d9d06bc59709ab9cb687c0af7271aa4ba3dc on kirkins:patch-5 into d456d19bb4125bdb570c4d7f037edc84f100517d on voxpupuli:master.

Daily node page with change:

Chart on front-page still working:

Can we trust that DOM value for all browsers?

@mterzo good call, I think there are some older browsers that will have trouble with window.location.origin I'm going to add a polyfill to handle that.

Updated for IE, with solution from here https://stackoverflow.com/a/25495161/773263

Coverage remained the same at 81.76% when pulling 85c096e1bb39a2b493a8390e5e8ba6e93e7729d7 on kirkins:patch-5 into d456d19bb4125bdb570c4d7f037edc84f100517d on voxpupuli:master.

I was gonna keep this simple and move dailychart to the templates and generate the base url.

@mterzo can you please take a look at this again?


Fixed issue

What is the current behavior?

Issue Number: #1308

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out my other projects. Just click here to find more. These projects contain real issues that you can help resolve. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


Beginner Guide

I don´t know how to set all this up.
Could someone help me out?

should just be as simple as getting your discord token , and then also setting up settings_mudae


Support OTP 18.1

It still needs https://github.com/basho/cluster_info/pull/22, but make test passed with it.

make test and make dialyzer passed, diff looks nice :+1:


Remove videos older than a week

Appears to be an issue with removing videos older than a week. Youtube's 'hide' implementation appears to be broken (and has been for some time discussion 1, discussion 2). Unfortunately YouTweak relies on this functionality so there isn't much I can do...

Suggest using collapsable subscriptions to help hide some of the older videos from view.


Save novel covers locally

Describe your suggested feature
When you select the Novel's cover you can save it like you can with Tachiyomi.
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with a source, I should be opening an issue in the sources repository.
[X] I have updated the app to version 1.1.17.
[X] I will fill out all of the requested information in this form.

Yes


Checking if object of triple is a literal when creating edges

As of right now in the code implementing within the cytoscape visualization the code is checking to make sure the object of the triple is not a literal before adding it to the group of edges, do we want this behavior? or do we want triples which have literals as their objects also?

Marking this as a bug because it likely has unintended consequences if we do not investigate.


can't set ludusavi up

The thing is, playnite won't show the ludusavi plugin settings... any help?

Hi! Just to confirm, in the installed > generic section, is Ludusavi listed as installed and enabled?

Hi! Just to confirm, in the installed > generic section, is Ludusavi listed as installed and enabled?

this is how it is listed

Hmm, I haven't seen that "extension failed to load properly" message before. Could you please send me a few files for troubleshooting?

%APPDATA%/Playnite/playnite.log
%APPDATA%/Playnite/extensions.log
%APPDATA%/Playnite/ExtensionsData/72e2de43-d859-44d8-914e-4277741c8208/config.json

playnite.log
extensions.log
config.json

Somehow, your config.json got into a bad state, but I'm not sure how. The issue is that the paths, like D:\Programas\Ludusavi\ludusavi.exe, should have the backslashes escaped, as in D:\\Programas\\Ludusavi\\ludusavi.exe. Normally, when you edit the paths in Playnite, they get written with the escapes in the config file automatically, so I'm not sure why they didn't in this case. Did you edit the file manually, by any chance?
To  fix it, you can replace your config.json with this one, and it should start working: config.json

you genius, all fixed!!!! thank you so much for taking the time to help a fellow gamer ♥
althoug is weird how this happened, bc it was all clean install, even my windows, i just formatted my pc due to an error during a mainteinance (and i hadn't formatted it in like 3 years), and no manual setting on path either, it auto set by opening playnite with ludusavi opened...
anyway, thanks again, you're a ray of sunshine ♥


Will this fork get updates?

I implemented this set in a project because I like to manage my icons through scss so was really happy to find this fork! Last week though I was noticing some icons were missing, and after some comparison its clear that this fork isn't complete anymore.
Is there any chance this fork will be updated to add the icons that were added in the original set from colebemis? If not, I'm thinking on switching back to the original implementation of the icons.

ok, I will synchronize missing ICONS today or tomorrow.

Thank you @koppthe. awaiting the awesome update to the icon set. Cheers

@koppthe please any update with this? Or could you please share how you generate this.
Thank you.

@papakay I will update with this today.

@koppthe thanks for your effort! Will await the update today :)

Done

Awesome! Thank you so much.

I have tried to generate font icons with icomoon.io but was not successful. Please how do you generate yours?
Thank you.

Hello together, I'm having the same problem as @gmvoliveira when they started this thread - icons are missing. Since I don't know how the font is generated and I'd love to use it in one of my projects, may I ask somebody who has more knowledge than me for an update?


Security problem with dependency

Hi, library use
"symfony/http-foundation": "^3.4||^4.2.12||^5.0",
but must in Symfony 4.4.7 and 5.0.7.
Symfony Security Check Report
1 packages have known vulnerabilities.
symfony/http-foundation (v4.4.0)

[CVE-2020-5255][]: Prevent cache poisoning via a Response Content-Type header
[CVE-2020-5255]: https://symfony.com/cve-2020-5255
Note that this checker can only detect vulnerabilities that are referenced in the SensioLabs security advisories database.
Execute this command regularly to check the newly discovered vulnerabilities.

Hi @otis22 thank you. You're correct. However I lock to majors / LTS versions and use packages like roave/security-advisories (added to the "suggest" section of my packages) to make sure packages with known security vulnerabilities are avoided and I don't have to manually maintain version constraints like "symfony/http-foundation": ">=3,<3.4.35|>=4,<4.2.12|>=4.3,<4.3.8|>=4.4,<4.4.7|>=5,<5.0.7" (this would be the current to avoid security vulnerabilities) all the time. There are tools for that ;)


Handle configuration secrets in system-probe

What does this PR do?
This PR aims to make system-probe handle configuration secrets

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes
Host based environment

Define a secret in datadog.yaml
For example: api_key: ENC[my_api_key]
Provide an executable  in datadog.yaml to retrieve the secret
For example: secret_backend_command: "/home/lima.linux/reveal_secrets.sh"
Make sure to respect the spec of the executable (it should be owner by the dd-agent user and not by any group or others)
The executable should look like this

#!/bin/bash
# some operations...
echo '{
  "my_api_key": {"value": "XXXXXXXXXXXXX", "error": null},
  "other_secret": {"value": "false", "error": "could not fetch the secret is_enabled"}
}'

More instructions

Won't this allow a non-privileged user to provide a program that would be executed by root? That seems like a privilege escalation?

This was previously intentionally disabled in #18222 so what has changed?

Same question than @brycekahle: Not enabling secrets on system-probe was required by the security-team.
It also raise more issue as we require the the binary being executed to be own by the same user than the agent process. On a host install we can't have the same binary own by dd-agent for the core-agent and root for system-probe.
We have a feature, disable right now, that allow different Datadog processes to fetch the API key from the core-agent which already uses secrets. We could work on enabling it by default and updating our HELM chart. This would give system-probe access to the API key through secrets without directly executing anything.

Yep, that makes sense, thanks for raising this issue. I'll explore another approach using the feature that syncs the secrets resolved by the core-agent with other agents.

Can you explain why the system-probe needs the API key (or other secrets)?

In an effort, to use CWS with system-probe only, we are migrating some of the security-agent functionalities to system-probe.


fix: Fix handling listener return value

Fixes #1491
Link to related issue (if applicable)
https://github.com/sampotts/plyr/issues/1492
Summary of proposed changes
Only ignore default listener if custom listener explicitly returns false.
Checklist

[x] Use develop as the base branch
[x] Exclude the gulp build (/dist changes) from the PR
[x] Test on supported browsers

I'm not sure if any of the built-in plugins depend on the old behavior. I clicked around in the demo for a bit around things like full-screen, and I didn't notice any odd behavior there.

Thanks for this 👍