Write documentation for and refactor the notetaking system

This PR will add rustdoc documentation for the note_db module. It also brings a couple of refactorings to the interface of the note database to improve usability.

The singleton will no longer use a Option<NoteDB> but a NoteDB directly. The singleton is a thread_local RefCell which only gets initialized on the first call to the note functions (which call with). Because of this change it will be no longer necessary to initialize the note_db explicitly.
The dump_vcd function was previously the only public function on NoteDB. By moving that to a separate note_export_vcd function it is more unified with the rest of the note* functions. We also no longer need to have the NodeDB struct public, because there are no methods left. This means that we also no longer need the  node_take function was previously only used to take the NoteDB singleton for dumping it to a vcd file.
The note_init_db will be renamed to note_reset_db because that better reflects its behaviour.

Hi @zebreus !
Thank you for this PR!  It looks great!  I do have one question.  How does one opt out of using trace functionality with this update?  In other words, if I want to run a simulation, but do not want to record values in the DB, how do I do so?  In the old API, I could simply omit the call to init_db and the note calls would do nothing.  How did you imagine this would be done now?
Samit

Hey @samitbasu
Thanks for your response.
You are of course right, the new API does provide no way of not recording values to the database. I did not think of that use case when adjusting the API, but in hindsight it seems quite obvious. The main reason for removing the need for explicit initialization was to simplify the interface, so that one less call is required.
The other changes also focus on simplifying, and unifying the interface ,e.g. all functionality is exported as functions instead of a mix of functions and methods.

So I spend a bit of time thinking about a more polished API for the noting system. I would be interested to hear your thoughts on the following proposed API.
Proposed API

note(key, value): Create a note
note_enable(): Initiate noting to a database. Sets up a fresh database and enable noting
note_disable(): Stop noting to the database.
note_set_time(time): Set the current time
note_get_time(): u64: Get the current time
note_push_path(path): Add path section
note_pop_path(): Remove path section
note_get_path(): Vec<...>: Get a path section
note_export(writer): Export the current state to a vcd. Does not clear the DB.

One of the core ideas of the proposed API is that the user should has no guarantees about the state of the NoteDB at the start of a test. The original API implied that the NoteDB is disabled if the users did not set it up explicitly, but that breaks if the user forgot to call dump_vcd at the end of the previous test (or a assertion failed the test before the end). My first proposed API changed that behaviour to have noting always enabled, which comes with some new problems. The proposed API has explicit function to enable or disable noting. These should be called at the start of a test to indicate whether the user wants to take notes. I would have liked the note database to be setup implicitly before each test, but that is not really possible.
The note_export function does no longer clear the database. As the proposed API does not pretend, that the NoteDB is disabled by default, it does not need to clear it here. This changes also makes it possible to dump intermediate versions of the NoteDB which is useful when using assert! halfway during a longer simulation.
A note_get_time and note_get_path function have been added to enable accessing the current simulation time and path.
The note_export function does no longer take ClockDetails inputs. This simplifies the interface. We could add a separate note_add_clock(clock_details) function that adds a clock to the NoteDB. Not sure if that function should create a clock signal until the current time, or just store the clock and add it at the end.
Additional ideas and thoughts
We could remove note_export and just write the VCD when the NoteDB is dropped. The note_enable function would then take the writer as an argument and store it until it is used. When note_enable or note_disable is called or the program exits, the NoteDB would then be written to a file.
Note is a bit of a confusing word to use, as I am not sure what it means. The verb note has two similar meanings: to notice or pay particular attention to (something) or to record (something) in writing. While the second meaning is probably closer to what we want, it is usually used with another word like note down or notetaking. In the documentation I used notetaking quite often, because noting kind of implies the first meaning. I think for consistency it would be better to use noting everywhere even though it sounds weird. Or just rename it to trace, dump, report, log or something else.
We could add a separate note_add_clock(clock_details) function that adds a clock to the NoteDB. Not sure if that function should create a clock signal until the current time, or just store the clock and add it when exporting.

Thanks for the detailed summary and proposal.  I will study and respond soon.  I largely agree with your proposed API changes, but want to think through them carefully.
One reason to avoid log is to allow for the developer to use both the traditional logging and the signal logging in the same code.  There are use cases for that I can think of from my own experience.  Of course, we could just use a namespace to avoid the confusion.  Maybe that is better, and I was trying to be too cute with the name.

So I spend a bit of time thinking about a more polished API for the noting system. I would be interested to hear your thoughts on the following proposed API.
Proposed API

note(key, value): Create a note
note_enable(): Initiate noting to a database. Sets up a fresh database and enable noting
note_disable(): Stop noting to the database.

This is pretty simple and easy to use.  I imagine we could have a guard or something that calls enable and disable automatically.  So something like:
let guard = note_enable();   // Returns a thing that calls disable when it is dropped

note_set_time(time): Set the current time
note_get_time(): u64: Get the current time
note_push_path(path): Add path section
note_pop_path(): Remove path section
note_get_path(): Vec<...>: Get a path section
note_export(writer): Export the current state to a vcd. Does not clear the DB.

Not sure why you want to export without clearing the DB.  Is there a

One of the core ideas of the proposed API is that the user should has no guarantees about the state of the NoteDB at the start of a test. The original API implied that the NoteDB is disabled if the users did not set it up explicitly, but that breaks if the user forgot to call dump_vcd at the end of the previous test (or a assertion failed the test before the end). My first proposed API changed that behaviour to have noting always enabled, which comes with some new problems. The proposed API has explicit function to enable or disable noting. These should be called at the start of a test to indicate whether the user wants to take notes. I would have liked the note database to be setup implicitly before each test, but that is not really possible.

Agreed.  One of the issues in rust-hdl that I had was that VCD generation was somewhat invasive.  I wanted it to behave more like logging if possible.  You add log::debug! to your code, but if you do not set up the logger somewhere, it does nothing.  Of course, there are differences, since without tying the logs to the code that generated (or the test) they are far less useful.
If we think of the DB as more of an "opt-in" mechanism, then leaving it always disabled, and then requiring the enable call to both enable and reset the DB (with the disable being called automatically when the enable object goes out of scope) may address both of your concerns?  I.e., we follow the MutexGuard pattern.  So just to be clear, I'm proposing that:

The DB is assumed to be disabled always
If you want to use it, you must call enable and hold the returned object for as long as the test is complete.
A natural consequence of this would be that the guard can be used to "close" the DB and write it to a file.

So, maybe something like:
let guard = db.enable();
// Run test stuff
guard.write_vcd(...); // (consumes `self`)

This would, in a single call, ensure that all the writes between the enable and the write are recorded in a single test case.  If you don't write the vcd, the guard will still be dropped, so the DB will still be disabled when a different test is run.
Thoughts?

The note_export function does no longer clear the database. As the proposed API does not pretend, that the NoteDB is disabled by default, it does not need to clear it here. This changes also makes it possible to dump intermediate versions of the NoteDB which is useful when using assert! halfway during a longer simulation.

This is a good point.  A global export function is useful for this reason, so maybe the guard solution above is not good for this case.  I agree that capturing the state of the DB when an assert! is triggered is pretty critical.  So maybe we could have both?  A snapshot function that exports the current DB, but leaves it intact, and then the guard automatically calls that snapshot function when it is dropped.

A note_get_time and note_get_path function have been added to enable accessing the current simulation time and path.
The note_export function does no longer take ClockDetails inputs. This simplifies the interface. We could add a separate note_add_clock(clock_details) function that adds a clock to the NoteDB. Not sure if that function should create a clock signal until the current time, or just store the clock and add it at the end.

Yes - there is a slight subtlety there - but it may not matter.  Originally, I was assuming that clocking was handled outside the framework.  And that the update functions were pure, and only computed new state and output given the current state and inputs.  But that is no longer the case.  I abandoned that approach as being too inflexible to deal with real world situations.  So now, the clock signal is passed through the design, just like any other, and we can drop the whole notion of ClockDetails.

Additional ideas and thoughts
We could remove note_export and just write the VCD when the NoteDB is dropped. The note_enable function would then take the writer as an argument and store it until it is used. When note_enable or note_disable is called or the program exits, the NoteDB would then be written to a file.

This is very similar to the idea I proposed above.  I.e., that enable return a guard, that can be used to write the VCD when it is dropped.

Note is a bit of a confusing word to use, as I am not sure what it means. The verb note has two similar meanings: to notice or pay particular attention to (something) or to record (something) in writing. While the second meaning is probably closer to what we want, it is usually used with another word like note down or notetaking. In the documentation I used notetaking quite often, because noting kind of implies the first meaning. I think for consistency it would be better to use noting everywhere even though it sounds weird. Or just rename it to trace, dump, report, log or something else.

As I mentioned, I wanted something distinct from logging.  And logging already covers trace.  The word dump is not right either, since it implies (to me, anyway), a complete capture of state or memory, and that is no longer the case.
It was log at one point, so if note is too confusing, we can change it back.  I'm not committed to it.

I think all of your concerns are now addressed.  The API needs documentation, no doubt, but the basic concerns @zebreus raised are now addressed.  The flow looks like this:
    let guard = note_init_db(); // Enable and initialize the DB
    note_time(0);
    note("simple", simple);
    note_time(1_000);
    let simple = Simple {
        a: false,
        b: Bits::from(0b01010101),
    };
    // We can "borrow" the DB any time via a global (thread-local) borrow.
    let mut snapshot = std::fs::File::create("snapshot.vcd").unwrap();
    with_note_db(|db| db.dump_vcd(&mut snapshot).unwrap());
    note("simple", simple);
    note_time(2_000);
    note("simple", simple);
    let mut vcd_file = std::fs::File::create("test.vcd").unwrap();
    guard.take().dump_vcd(&mut vcd_file).unwrap(); // Consumes the guard

I believe this behavior aligns with what you suggested:

The DB does nothing by default (default disabled)
The enable of the DB is scoped, and will be disabled when the guard is dropped
Taking the DB from the local store also consumes the guard
At any point during running, the DB can be borrowed via the provided lambda


feat(node): Control + C not working when running in docker container

Can we add graceful shutdown to the project? So when I press Control + C(Sends SIGINT), the graceful shutdown should begin. It should drain the current workers and stop accepting new connections.
When all workers are freed up, it should terminate the main process.
Dockerfile used
FROM node:6.9.2

ENV APP_DIR /home/app/frontend/
RUN mkdir -p $APP_DIR

# Install yarn
RUN npm install --global<EMAIL_ADDRESS>
ENV PATH "$PATH:/opt/yarn/bin"

ADD package.json yarn.lock /tmp/

# Install packages
RUN cd /tmp && yarn

ARG NODE_ENV=production
ENV NODE_ENV ${NODE_ENV}

# Copy the code
COPY . $APP_DIR

WORKDIR $APP_DIR
RUN ln -s /tmp/node_modules

# Create a mount point for node_modules but not mount when running the docker image
# adapted from http://jdlm.info/articles/2016/03/06/lessons-building-node-app-docker.html
VOLUME  /home/app/frontend/node_modules/

# set the node env after install or only prod dependencies will be installed
EXPOSE 3000

ENTRYPOINT ["/usr/local/bin/yarn", "run"]
CMD ["start"]

Updated Dockerfile used to reproduce the problem

Issue relate to https://github.com/npm/npm/issues/4603


Bp update

What is being added?
Is this a fix for a bug?  What's the bug?  Is this a new feature? Please describe it. Is this just a small typo fix?  That's fine too!
boilerplate update
What?
make boilerplate-update
make e2e-harness-generate
Why?
For better e2e-saas pipeline artifact persisting
Checklist before requesting review

[ ] I have tested this locally
[ ] I have included unit tests
[ ] I have updated any corresponding documentation

Steps To Manually Test
Please provide us steps to reproduce the scenarios needed to test this.  If an integration test is provided, let us know how to run it. If not, enumerate the steps to validate this does what it's supposed to.

Start the operator
Run the thing
Observe X in the spec for the thing
Clean up the thing

Ref OSD-0000

/lgtm
/approve


fixed alert() to display error message instead of Error object

The error that thrown from API.post() is an object type. So, we should display an error message by e.message, not e

Oh. I'll need to test this. But if this is the case then we need to make this change in all the other places that we call the API.

More information :
When I call API.get('notes', '/random-path-that-does-not-exist'), Amplify throws Error: Network Error which is an object.
By the way, if I call API.get('random-name', '/notes'), the error will be a string.
It's confusing.

Oh that's not good. I hope they standardize this

Then, should we add alert(e.message || e) to every catch block?

Do you have any suggestion on what is the proper way to check for the error type?
Should we use typeof e, e.message || e or something else?

Honestly I'm not too sure. Internally we use typeof but in some cases we fallback to checking it directly.


Remote user defined functions (table valued and scalar)?

The docs on Azure SQL Server cross-database queries seem to be fairly vague when addressing remote user defined functions, as if it would be straightforward or altogether impossible. 'Remote' as in: defined in another Azure SQL Database, for which a Master Key + DB Scoped Credential and Data Source was already created.
Well, if for example I reference a remote table valued function in my DB using EXTERNAL TABLE, then calling it fails with the parameter not being submitted.
Is it supposed to work? If yes, what is the proper syntax? Also, since one of the use cases of functions is inside SELECT statements, how would you reference a remote user defined function in an Azure SQL SELECT?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4ced437f-a827-a5da-df6f-b081e3857f94
Version Independent ID: cb21ad58-282b-98b7-fa63-d0981af99153
Content: Get started with cross-database queries (vertical partitioning)
Content Source: articles/sql-database/sql-database-elastic-query-getting-started-vertical.md
Service: sql-database
GitHub Login: @stevestein
Microsoft Alias: sstein

@pekkaar Thanks for the feedback. We are actively investigating and will get back to you soon.

@stevestein If you follow the tutorial verbatim you get an error when querying an empty table:
Msg 46823, Level 16, State 1, Line 1 Error retrieving data from miubezziexternal.database.windows.net.External.  The underlying error message received was: 'Invalid object name 'dbo.CustomerInformation'.'.

@Mike-Ubezzi-MSFT thanks for following up, for my curiosity, can you please direct me to this tutorial you mentioned, which I assume is dealing with calling an external UDF? Is this a public document? Thanks!

@pekkaar The steps are part of this document: Get started with cross-database queries (vertical partitioning), which is the document this GitHub issue was filed under. The functionality does work, it's just that the steps need to be more explicit in regards to creating an external data source (which is my case) versus creating a third database on the same SQL Server (Customers, Orders, and 'External' databases), and then executing the SELECT statement against the correct database. The tutorial should walk the user through a successful outcome.

@Mike-Ubezzi-MSFT thanks for the tutorial. Can you direct me to the part where it demonstrates how to use user defined functions from an external table?

@pekkaar Here are a couple links (below) regarding User Defined Functions but they are not part of the tutorial. Were you looking for this tutorial, or another tutorial, to demonstrate this functionality or, are you simply looking for general information?
The below content applies to both SQL Server and Azure SQL Database:
Create User-defined Functions (Database Engine)

User-Defined Functions

@Mike-Ubezzi-MSFT thanks for the docs on UDFs, these are non-Azure SQL specific. My problem is that I am migrating a solution consisting of two databases from SQL Server 2016 to Azure SQL and there are a number of external references in these referencing each others. I had no issues whatsoever setting up the Elastic Query solution (with the Master Key, DB Scroped Cred and the External Table statements) for table and view objects. However we also have a couple of user defined functions (scalar and table valued) in the on-prem solution that are also being called externally: the UDFs are defined in DB A and are routinely being called from DB A but are sometimes called from DB B as well.
So my question is where is the documentation describing how to call a scalar UDF in the definition of a view in DB A if the UDF is actually defined in DB B? This works no problem in the on-prem world, and makes an efficient solution. Is there no other way than to actually duplicate the UDF in DB B into DB A with referencing every single table / view object it works with also into DB A as Ext Tables? This would be a dreadfully unefficient solution.
So I am guessing there is in fact a method to use a scalar (or table valued) UDF in an Azure SQL Database even if it is actually defined in another Azure SQL Database? Yes? No? The documentation is totally avoiding the topic, no clear guidance whatsoever.

@stevestein I have changed this to a product-question, as I am hoping to get product related feedback to answer the question but, I still think the document needs to be looked at for tutorial accuracy and doc-enhancement as @pekkaar has pointed out.

@Mike-Ubezzi-MSFT are you able to feedback on the progress of this ticket? Namely, to answer the question on what is the supported method to call a user defined function in a remote database in Azure SQL (both scalar and table-valued) ? Thanks!

@pekkaar - Hi Peter, You can call remote UDFs using sp_execute_remote:
execute sp_execute_remote @data_source_name = N'external_source_name', @stmt = N'select dbo.function_on_db2()'
The Elastic query documentation has some info, and the examples section of the sp_execute_remote article also might be helpful.

@pekaar Calling remote UDF from a SELECT statement is generally not supported in Azure SQL Database, however its new flavor Azure SQL DB - Managed Instance does support three-part and four-part name syntax, just like on-premises SQL Server, so in Managed Instance you could execute something like 'SELECT DB_A.dbo.functionA' from the database DB_B on the same Managed Instance, or go step further and leverage linked servers feature and call function on the other Managed Instance. Please check the following link for more information about Managed Instance: https://docs.microsoft.com/en-us/azure/sql-database/sql-database-managed-instance#key-features-and-capabilities-of-a-managed-instance

@pekkaar Does the thread clarify whats supported? Is there anything else we can assist you with before closing this thread?

@amanarneja @MladjoA thanks for confirming the current behaviour, you answered my original question.


Feat: refactor envbinding for adapt policy placement

Description of your changes

Fixes #
I have:

[x] Read and followed KubeVela's contribution process.
[ ] Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
[ ] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Continue to optimize after merging.


Avoid trailing comma for single-argument with positional separator

Summary
In https://github.com/astral-sh/ruff/pull/8921, we changed our parameter formatting behavior to add a trailing comma whenever a single-argument function breaks. This introduced a deviation in the case that a function contains a single argument, but also includes a positional-only or keyword-only separator.
Closes https://github.com/astral-sh/ruff/issues/9074.

The one ecosystem change matches Black's formatting (i.e., it's more consistent than on main).

Yes lets go.


Deprecate this repo

deprecate or event better, rename vigour-url to vigour-router!

@jimdebeer So I guess what is needed here is to merge (and fix) the functionalities of vigour-url and vigour-router and name the result vigour-router?


Problem setting blockbogons interface param

It would appear that regardless of which Boolean param passed for "blockbogons" (true/false) the end result is that blockbogons is set to <null/blank> on API interface create calls. Not setting a value causes PfSense to label the interface as block bogons enabled (within the UI). This creates a bogon firewall rule for the interface as well.
Request (api/v1/interface) - POST
{
    "client-id": "admin",
    "client-token": "pfsense",
    "if": "vmx2.10",
	"descr": "VLAN10",
	"enable": "true",
	"type": "staticv4",
	"ipaddr": "<IP_ADDRESS>",
	"subnet": "24",
	"blockbogons": false
}

Request Response
{
    "status": "ok",
    "code": 200,
    "return": 0,
    "message": "Success",
    "data": {
        "opt2": {
            "if": "vmx2.10",
            "enable": "",
            "descr": "VLAN10",
            "blockbogons": "",
            "ipaddr": "<IP_ADDRESS>",
            "subnet": "24"
        }
    }
}

As a side note I also noticed that the documented list of params for "/api/v1/interface" does not include a param for blockbogons; however, the sample code on github does. Thanks for any insights you might have.

I just noticed that the same behavior occurs for the enable param as well. Doesn't matter which Boolean value I send in the request (true/false) quoted or unquoted the end result is the same--the interface is enabled.

So this behavior may be expected. The model shows that if either enable or blockbogons simply exists then set to true.
// Check for our enable value
        if (isset($this->initial_data["enable"])) {
            $enable = true;
            $this->validated_data[$next_if]["enable"] = "";
        }

// Check for our block private IP value
        if (isset($this->initial_data["blockbogons"])) {
            $block_bogons = true;
            $this->validated_data[$next_if]["blockbogons"] = "";
        }

Removing blockbogons from the request does in fact mitigate the issue (blockbogons is not set to true). Removing enable from the request payload does set the interface as disabled.

Hey!
This is a known issue addressed in #23. It cleans up the interface endpoint a lot and removes most of the sloppy proof-of-concept code I had left over. There is a pre-release build available within that pull request if you want to give it a try. I am probably a couple days or so away from merging those changes. If you do try the pre-release build, note the interface endpoint now contains an apply parameter that controls whether the configuration is applied immediately or not. You can read more about it in the documentation page or the readme on that branch.
Thanks!

Thanks for the update. I looked around prior to submitting but missed the notes for #23 .  Thanks again for the quick response and I really like what you are doing with this project. One day perhaps PfSense will create/finish an API but until then your work goes a long way to making it possible.


No description for "Run build at low process priority" option

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: c89753a0-032d-637f-22e4-573153ae55e0
Version Independent ID: b8974a32-45f1-c92d-8d30-6fa1bfeebc3a
Content: Options dialog, Projects and Solutions, Build and Run - Visual Studio (Windows)
Content Source: docs/ide/reference/options-dialog-box-projects-and-solutions-build-and-run.md
Product: visual-studio-windows
Technology: vs-ide-compile
GitHub Login: @ghogen
Microsoft Alias: ghogen

@BvoDev -- thank you for your feedback.  Please consider these resources:

Ask a question or find an answer on the Microsoft Q&A page for Visual Studio.
Check the Visual Studio MSDN Forum.
Stack Overflow
Reddit

@ghogen -- please look into this issue.

This article will be updated soon with the explanation of this setting. It is designed to make it easier to continue working while VS is building. By setting the build to a lower priority, the computer remains responsive rather than becoming slow to respond and perhaps unusable in some situations (depending on hardware capabilities).


[FEATURE] Add token manager to security plugin

This issue describes the addition of a feature that will add a token manager implementation to allow for the creation of auth tokens for both Users and InternalUser objects. The User objects will make use of the OnBehalfOfTokens while InternalUsers make use of a encoded basic authtoken.
After this feature is added, it will be possible for a request to get an authtoken for a User or InternalUser account and then use that token with the corresponding handling mechanism.
This change has been in progress since it is blocked by current work in the feature/extensions branch.
Current PR: https://github.com/opensearch-project/security/pull/2787.

[Triage] This is part of the Identity work being done to support extensions.

#3176 is taking care of that, closing


Initial commit

Description

Fix https://github.com/kubewarden/kubewarden-controller/issues/312

Test

e2e tests, unit tests.

Additional Information
Changed the implementation of the policy listed in https://github.com/kubewarden/kubewarden-controller/issues/312; simplified settings without reducing features.
Tradeoff

Potential improvement

[ ]. Mark the main branch as default in this repo. Made the mistake of pushing the policy branch to the empty repo first, instead of an empty main, so the policy policy branch is set as default: https://github.com/kubewarden/volumeMounts-policy/branches.


Could not click using ocrClickOnText() on a desktop browser version

Environment:

Node.js version: 14.18.1
Platform name and version: Chrome
WebdriverIO version: 7.16.4
wdio-ocr-service version: 1.1.0

Config of WebdriverIO + wdio-ocr-service
 services: ['image-comparison', {
            baselineFolder: join(process.cwd(), './test/imageComparisonBaseline/'),
            formatImageName: '{tag}-{width}x{height}',
            screenshotPath: join(process.cwd(), '.tmp/'),
            savePerInstance: true,
            autoSaveBaseline: true,
            hideScrollBars: true,
            scaleImagesToSameSize: true,
        }], [ 'ocr', {

                ocrImagesPath: 'ocr-images/',
            },
        ]
    ],

Description
I have tried to use this service on a webapp. I have tried to use ocrGetText() with great success and then I was trying to use ocrClickOnText(). The issue that occurred was that I was constantly getting an exception for invalid argument and that the x must be an integer.
To Reproduce
I have tried to use ocrClickOnText() without any option and I have tried also using iosRectangles and androidRectangles (I just use this even I tried on a desktop Chrome browser). e.g
 await browser.ocrClickOnText(
            'PLAY NOW',
            {
                iOSRectangles: {
                    top: 700,
                    left: 650,
                    right: 0,
                    bottom: 0,
                },
            },
        );

Expected behavior
The function should perform the click on the text on the screen.
Log
invalid argument
from invalid argument: 'x' must be an int

Additional context
I know that this library is meant to be used on mobile, although I found it very interesting using it for a webapp on a desktop version of a browser.
I did a first debug on determineClickPoint() and I found that the calculation of the x and y was actually a float number. e.g. element position  x=1249.7098377812663 y=828.4536891679749. In performActions() method the x and y should be an integer.
If you decide that this should be fixed then I can give it a try...

Hi @gromanas
Thanks for the issue and debugging this. Also great that this works for Desktop.
I have two suggestions:

we need a fix for the int, can you create a PR for this
based on what you found this module can also be used for desktop. Can you file a ticket that would be a feature request for this which should update the docs, check on cross browser and so on?

Thanks for your contribution so far!


set_name! with existing name errors

The IS companion to https://github.com/NREL-Sienna/PowerSystems.jl/issues/1161. If one sets a component's name to that component's existing name:

it is an error. I propose we add a special case in set_name! to turn this into a no-op.

Why would this operation happen?

Why would this operation happen?

Seems unlikely for someone to intentionally do this as a one-off, but maybe it could occur as part of some batch process. Anyway, even if it is unlikely to happen, it still strikes me as buggy behavior we ought to fix.


Provide link to alertmanager silence

When looking at a silenced alert it would be nice to be able to get a link to the silence in alertmanager.
If nothing else it would be acceptable to be able to get the silence id to search in amtool

Care to elaborate in a bit more detail @Kellel?

So In this screenshot I would like to be able to get the silence_id of the silence or just a link to the silence in alertmanager

Let's start with showing the id, since Alertmanager API doesn't give us explicit URLs for silences in the UI.


Stream delete modal popup below stream lists

Modal popup to delete a stream is  below stream lists and unclickable. This is  visible only in admin view.

I can't reproduce this in Chrome or Firefox on Linux, are you on upstream/master?

Yeah on latest upstream/master, even on zulipchat.com.
Ubuntu - Chrome.

I also cannot reproduce this. @abhigyank do you still experience this bug? If so what browser version are you using?

Cannot reproduce now. Closing.


[osx] virtualized memory mapping

Fixes #1911
PR checklist:

[x] make succeeds (on *nix)
[x] make reftests succeeds
[x] tested examples with the following backends: Metal

It doesn't work yet (for some reason)

If it's useful, I started to expose the capture manager for use with Xcode to start the capture during queue creation:

metal-rs changes
using capture manager on queue creation in gfx

However attaching the debugger appears to resolve this bug and everything renders fine in the hal/quad example... so maybe there is a synchronization issue.

(As per gitter discussion)
Bors r=grovesNL

On Apr 8, 2018, at 03:07, Josh Groves<EMAIL_ADDRESS>wrote:
If it's useful, I started to expose the capture manager for use with Xcode to start the capture during queue creation:
metal-rs changes
using capture manager on queue creation in gfx
However attaching the debugger appears to resolve this bug and everything renders fine in the hal/quad example... so maybe there is a synchronization issue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Avoid Circular imports related to bigquery_schema_tools

PR 17159 contains logic to convert a BQ Schema into a Beam Schema, but it seems like there's an issue with the new Beam release in calling the bigquery_schema_tools.py file. This PR fixes that. Note that this issue was highlited in my local IDE, but still compiled anyway and didn't get caught in our testing infrastructure.
This addresses https://github.com/apache/beam/issues/23760

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to

automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @ahmedabu98

Hm I'm not sure this is a circular import, I think those usually manifest as an ImportError that specifially identifies it as such, not an AttributeError like your screenshot. Let's sync on this tomorrow

Run Python 3.7 PostCommit

Run Python 3.8 PostCommit

@chamikaramj I think we'd like to CP this change, if possible

Yes, but did we confirm this to be an actual issue ? Seems like we are just pushing imports to the module level ?

And if so, is there a test that this should have broken ?

I put an explanation for how this got through testing in the issue: https://github.com/apache/beam/issues/23760#issuecomment-1286252080
@svetakvsundhar verified that this addresses the issue by using read_gbq in a clean python environment, could you share the evidence here Svetak?

Yes, ran it on a local Python shell and confirmed the error does not surface.

Sound good. Thanks. Feel free to send a cherry-pick.


Implement --extend-fixable option

Summary
This PR adds an --extend-fixable command-line and configuration file option, and changes the semantics to match those of --select (i.e., providing a new --select wipes out previous ignores, and so on).
Closes #4289.

My concern with adding --extend-fixable, or any other new CLI argument that directly match to a configuration optionis that we ultimately end up with a whole lot of CLI arguments: One to override every option in the configuration. What do you think of adding a--config [key1=value1,key2=value2,...]option that allows specifying ANY option in the configuration similar torustfmtorclippy`?

I'm generally open to something like that, though I think in this case, it does make sense to add --extend-fixable, since it's an inconsistency in the API:
Rule selection:
      --select <RULE_CODE>
          Comma-separated list of rule codes to enable (or ALL, to enable all rules)
      --ignore <RULE_CODE>
          Comma-separated list of rule codes to disable
      --extend-select <RULE_CODE>
          Like --select, but adds additional rule codes on top of the selected ones
      --per-file-ignores <PER_FILE_IGNORES>
          List of mappings from file pattern to code to exclude
      --fixable <RULE_CODE>
          List of rule codes to treat as eligible for autofix. Only applicable when autofix itself is enabled (e.g., via `--fix`)
      --unfixable <RULE_CODE>
          List of rule codes to treat as ineligible for autofix. Only applicable when autofix itself is enabled (e.g., via `--fix`)

(Notice that --extend-select exists, but not --extend-fixable.)

I'm generally open to something like that, though I think in this case, it does make sense to add --extend-fixable, since it's an inconsistency in the API:

What is your suggestion to decide on when we should add new explicit options? Should we also add extend-ignore, extend-per-file-ignores, and extend-unfixable? That's why I think I would prefer to potentially decide on adding support for --config (and rename the existing --config option to --config-path?) because I fear that it will always be possible to reason that some option should be supported because we already support some other option.

I think we should add these for all of the rule selection APIs, but not for the rule configuration APIs. That's my general stance right now.


⚠ Bofrost.at has degraded performance

In ab35c0f, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1275 ms

Resolved: Bofrost.at performance has improved in 90f3729.


Browing RSS link no longer adds a livemark, instead browser hangs

Add-on version
Add-on version: 3.7 (last updated 1 March 2024) running in Firefox 123.0 (64-bit) on Win10
Describe the bug
In Firefox, when I click on a link to an RSS feed, the page freezes or opens a blank page, and the livemark isn't added. Page Refresh button is greyed out.
To Reproduce
Steps to reproduce the behavior:

Go to https://www.bbc.co.uk/programmes/m001wjf8/episodes/downloads
Click on the link "RSS" (on the right hand side, just below the button labelled 'subscribe in sounds').
NB The URL of that link is https://podcasts.files.bbci.co.uk/m001wjf8.rss
The pointer changes to a hand and stays like that. The page is static - it can be scrolled up/down but none of the buttons or links on the page work. The Page Refresh button is greyed out. The feed has not been added to my list of livemarks.
NB if I open the RSS link in another browser (MS Edge) I see that it does contain XML - the first line is
(angle bracket)?xml version="1.0" encoding="UTF-8"?>(angle bracket)rss version="2.0" xmlns:media="http://search.yahoo.com/mrss/" xmlns:atom="http://www.w3.org/2005/Atom" xmlns:ppg="http://bbc.co.uk/2009/01/ppgRss" xmlns:itunes="http://www.itunes.com/dtds/podcast-1.0.dtd">
-- or --
Go to https://podbay.fm/p/inglorious-treksperts
Click on the link "RSS" (in the centre panel, just below the "Share" heading with its facebook/twitter/etc icons.
The URL of that link is https://anchor.fm/s/7067f3c/podcast/rss
A new blank page opens. It appears to be empty. The Page Refresh button is greyed out. The feed has not been added to my list of livemarks.
NB If I open the link in another browser (MS Edge) I see that it does contain XML. The first line is
(angle bracket)?xml version="1.0" encoding="UTF-8"?>(angle bracket) rss xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:content="http://purl.org/rss/1.0/modules/content/" xmlns:atom="http://www.w3.org/2005/Atom" version="2.0" xmlns:itunes="http://www.itunes.com/dtds/podcast-1.0.dtd" xmlns:anchor="https://anchor.fm/xmlns">

Expected behavior
When I click on an RSS link, used to get the message saying that the livemark had been added to my (by default) Bookmarks folder (or whatever non-default folder I had confirgured in Options > Default folder).
Extra context
Workaround: Right-click on the "RSS" link > "Copy link". Go to Addons Manger and to the right of Livemarks click "..." > "Options" which should take you to a "Your Livemarks" page. Click on the "+New Livemark" button (in top right-hand corner). Paste the copied RSS link's URL into the "Enter Feed URL" box, then click on OK.

Thanks for the great report.


feat: create a new "Install Dev Container feature" module

I think we should have an easy way to install Dev Container features in Coder workspaces (even outside of Dev Containers).
My reasoning behind that is that there is already a lot of great Dev Container features that you are currently unable to use with Coder without hacks.
There are also quite a lot of active modules that are used to maintain dependencies and collide w/ Coder modules (e.g nodejs and jupyterlab).
Given these points, I think we could replace part of our modules with existing Dev Container features and maybe migrate some of our existing features to contribute back to the Dev Container ecosystem.

Example usage
module "nodejs" {
  source   = "registry.coder.com/modules/install-devcontainer-feature/coder"

  # Ideally could be either a Git URL, a local folder or a path to an image
  # AFAIK the images are only used to store data and not really as proper images.
  feature = "ghcr.io/devcontainers/templates/javascript-node:4.0.2"

  version  = "1.0.0"
  agent_id = coder_agent.example.id
}

I have created an issue over @ the Envbuilder repo to discuss how we could maybe add a command that would use the existing feature logic.
https://github.com/coder/envbuilder/issues/361

Do you want this to work on any workspace or only with an existing devcontainer spec?

Do you want this to work on any workspace or only with an existing devcontainer spec?

All workspaces.

@phorcys420 The devcontainer feature script should be intelligent enough to exist cleanly if it is incompatible with the workspace image. As per my experience, most devcontainer features are only compatible with Debian/ubuntu images.

@phorcys420 The devcontainer feature script should be intelligent enough to exist cleanly if it is incompatible with the workspace image. As per my experience, most devcontainer features are only compatible with Debian/ubuntu images.

I agree, usually devcontainer features already handle that and most of our users are using Debian/Ubuntu anyways, but we can probably wrap it in a try/catch or something just to exit cleanly.


feature: add partial update ability.

usage like indexing:
                $params = array(
                    '_refresh_' => false,
                    'index'     => $update->indice,
                    'type'      => $update->type,
                );

                $es->update($update->document, $id, $params);

You can create a document then update just its state.

Do you mind adding a paragraph in the readme @1e1 so we can get this merged?


Support for automate ansible job/workflow template method.

Add new location ansibletemplate for automate Ansible template method.
Part of https://github.com/ManageIQ/manageiq-automation_engine/pull/265.
Related to https://github.com/ManageIQ/manageiq-automation_engine/pull/284.
https://bugzilla.redhat.com/show_bug.cgi?id=1591797
@miq-bot assign @gmcculloug
@miq-bot add_label enhancement

@mkanoor @bzwei Please review.

@bdunne Please review.
@lfu Is this basically trying to support Ansible Runner but for automate methods?

@lfu Can you explain the high level of what you are trying to solve?

@Fryguy This PR is to add automate method for running an Ansible template. I have renamed some of the methods to be not confused with Ansible Runner.

for running an Ansible template

Do you mean an Ansible Tower template?  (just want to make sure, because Ansible core doesn't have the concept of a template, and a few things in this PR, like the Mixin, are named as Ansible instead of AnsibleTower/EmbeddedAnsible)

I have renamed some of the methods to be not confused with Ansible Runner.

I also just want to be sure that these changes do not prevent us from moving to Ansible Runner in the future.  That is, we should not be exposing JobTemplates directly to the end user, because those things won't exist in Runner.

@mkanoor @bzwei Please review.

@martinpovolny we need to add support for 2 new types of Automate Methods in UI, you think this form should be converted to data-driven form. Currently method editor is a mix of both angular and ruby form depending upon the type of method. Please advice.

@lfu: Can you provide steps how to find the form in picture in the UI? I am not familiar with what I see in the screenshot.
Each time a visible change to the UI is made the UX should be involved. @terezanovotna should know about this.
It all that is to do is in the screenshot then this is pretty straightforward and should be quickly doable with the data-driven forms.

@h-kataria : Thank you for pinging me.

Automation -> Automate -> Explorer -> Datastore -> expand tree to a class Class -> switch tab to Methods -> Configuration -> Add new a New Method
(credits: @ZitaNemeckova)
@lfu : is that correct?

Automation -> Automate -> Explorer -> Datastore -> expand tree to a class Class -> switch tab to Methods -> Configuration -> Add new a New Method

Correct!

@lfu: I find it very difficult to orient in the conversation in this PR.
Can you, please, create a new issue (in the manageiq-ui-classic repo) with a more detailed description?
Some points to clarify:

are we adding a new type of method or chaning an existing one?
what is the name of the new/changed method ("Type" with value of "playbook" in the screenshot above)?
the above may answer if the repository and host options are to be kept (in case of adding a new method) and only replaced for the new type or changed in the existing type?
4 ) The classes ManageIQ::Providers::AnsibleTower::AutomationManager::ConfigurationScript and ManageIQ::Providers::AnsibleTower::AutomationManager::ConfigurationWorkflow - one is the new one and one is the already existing one?

Thank you!
I will need to do changes to the existing form. The interactions in this page require too many new components that need to be created prior to rewriting this form to React/data-driven forms.

@miq-bot add_label hammer/no


chore(clarification): rename "exhaustive" to "not-so-exhaustive"

Something wrong on windows 🤔
  ● Test suite failed to run

    Your test suite must contain at least one test.


error with nodeMcu v1.0

i compiling with nodeMcu and getting error

You might have to modify code for this manually. The generator was originally intended only for Arduino. The evaluation code itself should be fine, likely the issue is with how the pins are configured.
I will add support for this if I see enough demand for this.

thanks. it will be nice if support in nodeMCU board


The document claims to support annotation for AVI files, but in reality, AVI files cannot be annotated.

document ：

reality：

We've filed a ticket to resolve this in the documentation. Thanks.

Updated the docs to remove .avi as supported file type


gem -> package

Coverage remained the same at 99.652% when pulling cfadcebc796c85b4234d7ec84d5aa7a782e9fd0f on PharkMillups-patch-1 into 9e6dd62e121d6e89d77b4229a03e8ae604a5dc7b on master.


Write a markdown doc describing the common design patterns used in this code base.

Relevant: https://github.com/googleapis/google-cloud-cpp/issues/2001
There are many minor/major design strategies used in our code that we should document and explain so we don't have to keep making the same decisions. We might want one doc to briefly cover all these things. It should cover things like:

Returning (by value) Status or StatusOr to indicate error.
How to iterate objects that might have errors (i.e., iterator over StatusOr)
How to write async APIs that might fail

etc.
cc @coryan @devbww

I believe this is basically done in the https://github.com/googleapis/google-cloud-cpp/blob/main/ARCHITECTURE.md that we now have.


Which weight decay?

Hi,
In your paper at 2) Training details you used a weight decay of 0.5 but in the readme at the bottom a different weight decay of 0.001 is noted. Which did you use or do I confuse something here?

Hey @SiBensberg,
They are two different types of decays. 0.5 for the decay of the learning rate, which is related to the scheduler. The later is for the decay of weights for the trained model (0.001), which is related to regularization of the model from overfitting.
Hope this clarifies your confusion.

Hi @donkeymouse ,
thank you for your reply. I already guessed that just wanted to be sure.


When textfield text is clipped entire line is hidden

So im not sure if this is by design of a bug, but i feel like on previous version of openfl this was working.
Basically, if you create a multiline textfield and set its height so it will clip the last line of text then the whole line is hidden. I could be wrong, but this feels like incorrect / odd behaviour (i would expect the line to show, but clipped).
            var tf = new TextField();
            tf.text = "Line 1\nLine 2\nLine 3\nLine 4";
            tf.border = true;
            tf.x = 100;
            tf.y = 100;
            tf.type = TextFieldType.DYNAMIC;
            tf.selectable = false;
            tf.mouseEnabled = false;
            tf.autoSize = TextFieldAutoSize.LEFT;
            Lib.current.stage.addChild(tf);

            var tf = new TextField();
            tf.text = "Line 1\nLine 2\nLine 3\nLine 4";
            tf.border = true;
            tf.x = 140;
            tf.y = 100;
            tf.type = TextFieldType.DYNAMIC;
            tf.selectable = false;
            tf.mouseEnabled = false;
            tf.height = 55;
            Lib.current.stage.addChild(tf);

            var tf = new TextField();
            tf.text = "Line 1\nLine 2\nLine 3\nLine 4";
            tf.border = true;
            tf.x = 240;
            tf.y = 100;
            tf.type = TextFieldType.DYNAMIC;
            tf.selectable = false;
            tf.mouseEnabled = false;
            tf.height = 60;
            Lib.current.stage.addChild(tf);

Did you try with latest ( dev) OpenFL  version ?
I think it's similar as this one : https://github.com/openfl/openfl/issues/2484

Yeah, im on latest openfl:
c:\SDK\openfl\openfl>git branch -vv
* develop 7f09386c0 [origin/develop] Set extension property

Cheers,
Ian

Sadly, this is actually the correct flash behavior. I would love to come to some kind of consensus to go beyond mimicking flash behavior and improving upon the flash expectations, but this is still under some amount of debate.
This is your sample code built with flash/air.

Fair enough... ive worked around it in haxeui-openfl so it doesnt have any "serious" impact... I do agree with you about the flash api... its a little outdated, and who knows, maybe this is a bug there - so wouldnt make sense to repro bugs in openfl... but, then where do you draw the line... ...
anyways, thanks for the clarification!
Ian

No problem. I closed the issue but I've made an internal memo to address this at some point in time.


Error while merging

TypeError: (0 , import_merge_html.default) is not a function
at  (/home/runner/app/scr/index.ts:239:21)
at FSReqCallback.readFileAfterClose [as oncomplete] (node:internal/fs/read_file_context:68:3)

Sory i just fixed myself and I'm not currently using your lib thx


Small changes to GetInstances data source

1st commit msg: Add -> add
2nd commit: I don't see the behaviour change

1st commit msg: Add -> add
Will fix.
2nd commit: I don't see the behaviour change
The behaviour is actually changed in the terraform driver this commit just points to the new driver instead of the old one

1st commit msg: Add -> add 2nd commit: I don't see the behaviour change

Addressed.


Core: added validations greaterThan and lessThan

New validation methods added for number for greaterThan and lessThan checks.
i.e  we can make a check on obtain marks and total marks of students

Thanks but these methods already exist https://github.com/jquery-validation/jquery-validation/tree/master/src/additional


I have updated the requirement from python version 3.6 to 3.12

#6
I have updated the requirement from python version 3.6 to 3.12 and made changes in deprecated lines in v3.12

@trishap-16 please refer it to the assigned issue no#

#6
I have updated the requirement from python version 3.6 to 3.12 and made changes in deprecated lines in v3.12

@whyvineet @mvp-2003 Please verify the change. I think the level will be degraded to level 1-2 with these changes.
Expecting more changes as per the functionality of the project.

@whyvineet @mvp-2003 Please verify the change. I think the level will be degraded to level 1-2 with these changes. Expecting more changes as per the functionality of the project.

I'm currently testing the changes! I think we should be degraded to level 1 with these changes if the test passes!

Hi @trishap-16  , I can see with the latest 3.12 it's not compatible especially as it used virtual Python space to work in 3.6.
Could you please make every script and requirement compatible, in that case, we can make it level 3?

Hey @trishap-16
This PR is a commendable initial step towards upgrading the bot from Python 3.6 to 3.12. However, it is currently incomplete and may introduce potential issues for future contributors.
Specific Concerns:

Incompleteness: The PR does not appear to address all the necessary changes to ensure full compatibility with Python 3.12. This includes potential updates to libraries, code refactoring, and handling of deprecated features.
Future Contributor Impact: If this PR is merged in its current state, it could create confusion and additional work for future contributors who may need to address the remaining upgrade tasks.


Cut and Paste

Would it be possible to add "cut" and "paste"  functionality also?

Hey @addcms, we already provide cut command. But paste still not very supported in most browsers.

@zenorocha thanks for building this library, this is awesome. I think you should add in the homepage why the paste functionality is not supported (privacy issues & cross-browser support). This will avoid many issues "how to paste" etc... ;)

Thanks @pomeh! I'm thinking about creating a FAQ page for this and other questions that always come up ;)


New RT link. AnnoCPAN is dead. Replace CPAN Search with MetaCPAN.

Thanks for the contributions. @davorg


web footer icon

Other PHP frameworks have web page footer icons so you can display the fact that you are using the PHP framework. The CI guys tell me mine is "Tacky" :
https://twitter.com/andybrookestar/status/851158749750464512
&  i can get one here - can't see any png, gif nor jpg in download zip of repo.

Not so much that your icon is tacky, but ising a grunge font and abbreviating CodeIgniter to "C.I" is tacky.
The website/assets/images folder contains a number of gif & png renderings of the logo, and the media/ci-logo folder contains an Illustrator format original.


Ensure compiles now and in the future.

Added libigl as a submodule because they are planning breaking changes.
Added project name in CMakeLists to silence a warning.
Removed /opt/local/lib as a library path, since that isn't where eigen would be installed by brew.

Thank you for keeping me posted.


Sidecar migration

This PR migrates the gatekeeper manager operator charm to using the latest version of the ops library. The old charm was outdated and using the podspec operator pattern.
We had to patch the StatefulSet to mount a volume to the gatekeeper container in order to make the charm work. This causes the charm operator to restart when first installing the charm.
Some notes/TODOs:

Add more descriptive README?
The audit operator will be migrated in a separate PR.
Fix github workflow
Do we need more tests?
This charm uses the built in opa cert-controller, should we allow for the use of cert-manager instead? Perhaps this way we can avoid mounting to the container.

Add more descriptive README?: Good idea
Fix github workflow: Yes definitely move the .github folder up to the project root. We need to ensure the unit and integration tests run for the PR
Do we need more tests?: Yes, I added some review comments with some suggested unit tests. Integration tests look great, but the unit tests are a bit light.
Re: cert-manager, great idea, although possibly outside the scope of the migration task, however depending on complexity it could be added in in this PR, similar to how prometheus integration is going.


no way to unselect a point in the visualization plot

If I want the projection plot to not have any points with a large red symbol, there's no way that I can find to go back to the state where no points are selected for viewing in the structure plot.  If there is a way to reset, it should be made more obvious.

this is not supported, as there always is a selected structure.
if you need this to make a figure, when you save a figure in 2D it seems to be saving only the main trace, so you don't have the red dot. however in 3D it does save all traces, maybe this is something that can at least be made homogeneous.

Is there a way to save in 2D given that I want a particular orientation in the 3D space that I'm viewing and selecting interactively, when the clusters line up just right?  It's not necessarily in the plane of 2 of the PCA vectors.

BTW, I think that sometimes you probably want the red dot (i.e.g if you're planning to show the map alongside the structure it corresponds to), and sometimes you don't (if you're not planning to show any structures, just the clustering).

When using chemiscope in jupyter with chemiscope.show, you can use mode="map" to only show the map/clustering. It has all the same options.
We could try to provide this (and mode="structure") as well on the website, we would mainly have to find a way to show this choice to the user.

Creating a new 2D projection from 3D data + camera orientation sounds like an interesting idea, but will require some work. A first step could be #74, allowing to save the camera orientation & reload it on the next view of the same dataset.

chemiscope.show(..., mode="map") also picks one map point to be a large red dot, despite having no structure that it can correspond to.

PyPI Releases correspond to tags on this repo, so tab10 it is not yet available there. I'll do a new release tomorrow to include it.

0.8.3 has been released on PyPI, it should contain the new palettes!

I just updated, chemiscope.__version__ is showing 0.8.3, but I'm getting the same message from the jupyter interface. Any idea what I should investigate?

I didn't, because I didn't realize the distinction between the imported chemiscope in the kernel vs. the extension that the server uses.  Now it works, with the same legend symbol bug, but that's another story.  Thanks for the quick update.
I still want to be able to unselect all the points (so there's no random arbitrary large red symbol) when exporting the bitmap (the original topic of this issue).

Is there any chance you could suggest even a hacky workaround that'd remove the large red symbol for the selected environment when exporting to png?  I'd like to use these outputs in a paper, just showing the clustering, and the red symbol is just confusing in that context.

The point is a separate trace. You could try to hide it before the export
and re-show it after it. That IMO could also be made standard,
and a first step towards making the exported images better for papers
(vector output of 2D plots would be another great thing to achieve).
On Tue, 19 Nov 2024 at 16:02, bernstei @.***> wrote:

Is there any chance you could suggest even a hacky workaround that'd
remove the large red symbol for the selected environment when exporting to
png? I'd like to use these outputs in a paper, just showing the clustering,
and the red symbol is just confusing in that context.
—
Reply to this email directly, view it on GitHub
https://github.com/lab-cosmo/chemiscope/issues/389#issuecomment-2485961962,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIREZ6C4OK7UY3V6YLFLET2BNHJNAVCNFSM6AAAAABRJUYQCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBVHE3DCOJWGI
.
You are receiving this because you commented.Message ID:
@.***>

Thanks @ceriottm  - adding visible: 'legendonly' when created the selected trace worked.  I'd do a PR, but I'm guessing that sometimes people will want the selected marker shown, if they're also going to show the corresponding environment in the structure viewer, and I'm not sure how to add the UI to control that, so for now I'll just use it as a workaround when generating my figures.

Thanks @ceriottm - adding visible: 'legendonly' when creating the selected trace worked. I'd do a PR, but I'm guessing that sometimes people will want the selected marker shown, if they're also going to show the corresponding environment in the structure viewer, and I'm not sure how to add the UI to control that, so for now I'll just use it as a workaround when generating my figures.

My personal viewpoint is that if you want to add snapshots of the structures, you'll do some manual editing anyway and then you can add the markers manually - then one can do a screenshot to use as reference, so IMO there is no need for an UI element, just as I wouldn't add a UI element to decide whether to output as vector or bitmap.

In that case, do you want a PR?  It really is just a single line.

In that case, do you want a PR? It really is just a single line.
[edited] correction - my workaround, which always turns off the selected marker, is 1 line. I'd have to understand the callback structure in the function that the "export to PNG" (and SVG) buttons trigger to figure out how to do it only while the exported image is being constructed. And so far that hasn't been obvious to me.

OK yeah I was hoping for an implementation that would only change the exported graphics, we definitely ALWAYS want the marker on in the interactive viewer (because of the info panel, also when showing only the map)


rule of the ability test

Would it be allowed that the member can do more than one time of the ability test? As member who fail the test may want to pass it, in order to get the tag of the ability, or the test can only do one time?

I think you should add a date property to save when the user took the quiz and prevent them from redoing the quiz within a period of time(just say 1 month). As user may improve their skills in the future, it is better to let them redo the quiz after some time.


Sigh crash in spaceship's parse_response function

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I have read the Contribution Guidelines

Issue Description
Fastlane crashes when running sigh.
Complete output when running fastlane, including the stack trace and command used
Joyable: fastlane alpha                                                                                master
[15:07:10]: -------------------------------------------------
[15:07:10]: --- Step: Verifying required fastlane version ---
[15:07:10]: -------------------------------------------------
[15:07:10]: fastlane version valid
[15:07:10]: ------------------------------
[15:07:10]: --- Step: default_platform ---
[15:07:10]: ------------------------------
[15:07:10]: Driving the lane 'ios alpha' 🚀
[15:07:10]: -------------------------------------
[15:07:10]: --- Step: ensure_git_status_clean ---
[15:07:10]: -------------------------------------
[15:07:10]: Git status is clean, all good! 💪
[15:07:10]: -----------------------
[15:07:10]: --- Step: cocoapods ---
[15:07:10]: -----------------------
[15:07:10]: $ bundle exec pod install
[15:07:11]: ▸ Updating local specs repositories
[15:07:23]: ▸ CocoaPods 1.0.0.beta.6 is available.
[15:07:23]: ▸ To update use: `sudo gem install cocoapods --pre`
[15:07:23]: ▸ [!]  There are 20 dependencies from the Podfile and 22 total pods installed.
[15:07:34]: ▸ [!] The `Joyable [Debug]` target overrides the `EMBEDDED_CONTENT_CONTAINS_SWIFT` build setting defined in `Pods/Target Support Files/Pods-Joyable/Pods-Joyable.debug.xcconfig'. This can lead to problems with the CocoaPods installation
[15:07:34]: ▸ [!] The `Joyable [Staging]` target overrides the `EMBEDDED_CONTENT_CONTAINS_SWIFT` build setting defined in `Pods/Target Support Files/Pods-Joyable/Pods-Joyable.staging.xcconfig'. This can lead to problems with the CocoaPods installation
[15:07:34]: ▸ [!] The `Joyable [Sassy]` target overrides the `EMBEDDED_CONTENT_CONTAINS_SWIFT` build setting defined in `Pods/Target Support Files/Pods-Joyable/Pods-Joyable.sassy.xcconfig'. This can lead to problems with the CocoaPods installation
[15:07:34]: ▸ [!] The `Joyable [Release]` target overrides the `EMBEDDED_CONTENT_CONTAINS_SWIFT` build setting defined in `Pods/Target Support Files/Pods-Joyable/Pods-Joyable.release.xcconfig'. This can lead to problems with the CocoaPods installation
[15:07:34]: ▸ [!] The `Joyable [Beta Release]` target overrides the `EMBEDDED_CONTENT_CONTAINS_SWIFT` build setting defined in `Pods/Target Support Files/Pods-Joyable/Pods-Joyable.beta release.xcconfig'. This can lead to problems with the CocoaPods installation
[15:07:34]: ▸ - Use the `$(inherited)` flag, or
[15:07:34]: ▸ - Remove the build settings from the target.
[15:07:34]: ▸ - Use the `$(inherited)` flag, or
[15:07:34]: ▸ - Remove the build settings from the target.
[15:07:34]: ▸ - Use the `$(inherited)` flag, or
[15:07:34]: ▸ - Remove the build settings from the target.
[15:07:34]: ▸ - Use the `$(inherited)` flag, or
[15:07:34]: ▸ - Remove the build settings from the target.
[15:07:34]: ▸ - Use the `$(inherited)` flag, or
[15:07:34]: ▸ - Remove the build settings from the target.
[15:07:34]: ------------------------------------
[15:07:34]: --- Step: increment_build_number ---
[15:07:34]: ------------------------------------
[15:07:34]: $ cd /Users/noratrapp/source/ios/Joyable && agvtool new-version -all 2<IP_ADDRESS>.07
[15:07:35]: ▸ Setting version of project Joyable to:
[15:07:35]: ▸ 2<IP_ADDRESS>.07.
[15:07:35]: ▸ Also setting CFBundleVersion key (assuming it exists)
[15:07:35]: ▸ Updating CFBundleVersion in Info.plist(s)...
[15:07:35]: ▸ Updated CFBundleVersion in "Joyable.xcodeproj/../Extensions/Info.plist" to 2<IP_ADDRESS>.07
[15:07:35]: ▸ Updated CFBundleVersion in "Joyable.xcodeproj/../Joyable/Info.plist" to 2<IP_ADDRESS>.07
[15:07:35]: ▸ Updated CFBundleVersion in "Joyable.xcodeproj/../JoyableTests/Info.plist" to 2<IP_ADDRESS>.07
[15:07:35]: ▸ Updated CFBundleVersion in "Joyable.xcodeproj/../JoyableUITests/Info.plist" to 2<IP_ADDRESS>.07
[15:07:35]: ▸ Updated CFBundleVersion in "Joyable.xcodeproj/../SDK/Info.plist" to 2<IP_ADDRESS>.07
[15:07:35]: ------------------
[15:07:35]: --- Step: sigh ---
[15:07:35]: ------------------

+-------------------------------------+----------------------------+
|                      Summary for sigh 1.6.0                      |
+-------------------------------------+----------------------------+
| app_identifier                      | com.joyable.JoyableApp     |
| adhoc                               | false                      |
| skip_install                        | false                      |
| development                         | false                      |
| force                               | false                      |
| username                            |<EMAIL_ADDRESS>|
| ignore_profiles_with_different_name | false                      |
| skip_fetch_profiles                 | false                      |
| skip_certificate_verification       | false                      |
+-------------------------------------+----------------------------+

[15:07:36]: Starting login with user<EMAIL_ADDRESS>[15:07:37]: ----------------------------
[15:07:37]: --- Step: reset_git_repo ---
[15:07:37]: ----------------------------
[15:07:37]: $ git reset --hard HEAD
[15:07:37]: ▸ HEAD is now at 9d4c4a0 some logs to debug failure
[15:07:37]: $ git clean -qfdx
[15:07:37]: Git repo was reset and cleaned back to a pristine state.
[15:07:37]: Variable Dump:
[15:07:37]: {:DEFAULT_PLATFORM=>:ios, :PLATFORM_NAME=>:ios, :LANE_NAME=>"ios alpha", :GIT_REPO_WAS_CLEAN_ON_START=>true, :BUILD_NUMBER=>"2<IP_ADDRESS>.07"}
[15:07:37]: {"creationTimestamp"=>"2016-03-22T22:07:34Z", "resultCode"=>0, "userLocale"=>"en_US", "protocolVersion"=>"QH65B2", "requestUrl"=>"https://developerservices2.apple.com:443/services/QH65B2/listTeams.action", "responseId"=>"5a3e4309-3168-4be3-91a5-51960efa9105"}

+------+-------------------------------------+-------------+
|                     fastlane summary                     |
+------+-------------------------------------+-------------+
| Step | Action                              | Time (in s) |
+------+-------------------------------------+-------------+
| 1    | Verifying required fastlane version | 0           |
| 2    | default_platform                    | 0           |
| 3    | ensure_git_status_clean             | 0           |
| 4    | cocoapods                           | 23          |
| 5    | increment_build_number              | 1           |
| 6    | sigh                                | 1           |
| 7    | reset_git_repo                      | 0           |
+------+-------------------------------------+-------------+

[15:07:37]: fastlane finished with errors
Successfully submitted a crash report. If this is a problem with one of the tools specifically,
please submit an issue on GitHub and attach the following number to it: 'f9eba1726db8f087dbaff870de38211d'
The crash report has been stored locally '/tmp/sentry_f9eba1726db8f087dbaff870de38211d.json'
/Users/noratrapp/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/spaceship-0.24.0/lib/spaceship/client.rb:328:in `parse_response': [!] {"creationTimestamp"=>"2016-03-22T22:07:34Z", "resultCode"=>0, "userLocale"=>"en_US", "protocolVersion"=>"QH65B2", "requestUrl"=>"https://developerservices2.apple.com:443/services/QH65B2/listTeams.action", "responseId"=>"5a3e4309-3168-4be3-91a5-51960efa9105"} (Spaceship::Client::UnexpectedResponse)
	from /Users/noratrapp/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/spaceship-0.24.0/lib/spaceship/portal/portal_client.rb:63:in `teams'
	from /Users/noratrapp/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/spaceship-0.24.0/lib/spaceship/portal/ui/select_team.rb:35:in `select_team'
	from /Users/noratrapp/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/spaceship-0.24.0/lib/spaceship/portal/portal_client.rb:79:in `select_team'
	from /Users/noratrapp/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/spaceship-0.24.0/lib/spaceship/portal/spaceship.rb:37:in `select_team'
	from /Users/noratrapp/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/spaceship-0.24.0/lib/spaceship/portal/spaceship.rb:81:in `select_team'
	from /Users/noratrapp/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/sigh-1.6.0/lib/sigh/runner.rb:16:in `run'
	from /Users/noratrapp/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/sigh-1.6.0/lib/sigh/manager.rb:7:in `start'
	from /Users/noratrapp/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/fastlane-1.67.0/lib/fastlane/actions/sigh.rb:20:in `run'
	from /Users/noratrapp/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/fastlane-1.67.0/lib/fastlane/runner.rb:143:in `block (2 levels) in execute_action'
	from /Users/noratrapp/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/fastlane-1.67.0/lib/fastlane/actions/actions_helper.rb:35:in `execute_action'
	from /Users/noratrapp/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/fastlane-1.67.0/lib/fastlane/runner.rb:129:in `block in execute_action'
	from /Users/noratrapp/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/fastlane-1.67.0/lib/fastlane/runner.rb:128:in `chdir'
	from /Users/noratrapp/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/fastlane-1.67.0/lib/fastlane/runner.rb:128:in `execute_action'
	from /Users/noratrapp/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/fastlane-1.67.0/lib/fastlane/fast_file.rb:149:in `method_missing'
	from Fastfile:42:in `block (2 levels) in parsing_binding'
	from /Users/noratrapp/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/fastlane-1.67.0/lib/fastlane/lane.rb:36:in `call'
	from /Users/noratrapp/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/fastlane-1.67.0/lib/fastlane/lane.rb:36:in `call'
	from /Users/noratrapp/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/fastlane-1.67.0/lib/fastlane/runner.rb:52:in `block in execute'
	from /Users/noratrapp/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/fastlane-1.67.0/lib/fastlane/runner.rb:46:in `chdir'
	from /Users/noratrapp/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/fastlane-1.67.0/lib/fastlane/runner.rb:46:in `execute'
	from /Users/noratrapp/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/fastlane-1.67.0/lib/fastlane/lane_manager.rb:46:in `cruise_lane'
	from /Users/noratrapp/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/fastlane-1.67.0/lib/fastlane/command_line_handler.rb:30:in `handle'
	from /Users/noratrapp/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/fastlane-1.67.0/bin/fastlane:38:in `block (2 levels) in run'
	from /Users/noratrapp/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/commander-4.3.5/lib/commander/command.rb:178:in `call'
	from /Users/noratrapp/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/commander-4.3.5/lib/commander/command.rb:178:in `call'
	from /Users/noratrapp/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/commander-4.3.5/lib/commander/command.rb:153:in `run'
	from /Users/noratrapp/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/commander-4.3.5/lib/commander/runner.rb:428:in `run_active_command'
	from /Users/noratrapp/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/fastlane_core-0.39.0/lib/fastlane_core/ui/fastlane_runner.rb:23:in `run!'
	from /Users/noratrapp/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/commander-4.3.5/lib/commander/delegates.rb:15:in `run!'
	from /Users/noratrapp/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/fastlane-1.67.0/bin/fastlane:156:in `run'
	from /Users/noratrapp/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/fastlane-1.67.0/bin/fastlane:162:in `<top (required)>'
	from /Users/noratrapp/.rbenv/versions/2.2.2/bin/fastlane:23:in `load'
	from /Users/noratrapp/.rbenv/versions/2.2.2/bin/fastlane:23:in `<main>'

Configuration Files
Please copy the complete content of your Fastfile and any other configuration files you use below:
Fastfile:
# Customise this file, documentation can be found here:
# https://github.com/KrauseFx/fastlane/tree/master/docs
# All available actions: https://github.com/KrauseFx/fastlane/blob/master/docs/Actions.md
# can also be listed using the `fastlane actions` command

# Change the syntax highlighting to Ruby
# All lines starting with a # are ignored when running `fastlane`

# By default, fastlane will send which actions are used
# No personal data is shared, more information on https://github.com/fastlane/enhancer
# Uncomment the following line to opt out
# opt_out_usage

# If you want to automatically update fastlane if a new version is available:
# update_fastlane

# This is the minimum version number required.
# Update this, if you use features of a newer version
fastlane_version "1.44.0"

default_platform :ios

platform :ios do
  before_all do
    ensure_git_status_clean

    # ENV["SLACK_URL"] = "https://hooks.slack.com/services/..."
    ENV['APP_IDENTIFIER'] = "com.joyable.JoyableApp"
    cocoapods

    # Increment build number to current date
    build_number = Time.new.utc.strftime("%Y.%m.%d.%H.%M")
    increment_build_number build_number: build_number

    # xctool # run the tests of your app
  end

  desc "Submit a new Alpha Build to Apple TestFlight"
  desc "This will also make sure the profile is up to date"
  lane :alpha do
    sigh(app_identifier: ENV["app_identifier"], output_path: "./build")
    ENV["PROFILE_UUID"] = lane_context[SharedValues::SIGH_UDID]
    gym(scheme: "Joyable", use_legacy_build_api: true) # Build your app - more options available
    pilot(skip_submission: true)
  end

  desc "Submit a new Beta Build to Apple TestFlight"
  desc "This will also make sure the profile is up to date"
  lane :beta do
    # Switch to the beta identifier
    ENV['APP_IDENTIFIER'] = "com.joyable.JoyableApp-Beta"
    sigh(app_identifier: ENV["app_identifier"], output_path: "./build")
    ENV["PROFILE_UUID"] = lane_context[SharedValues::SIGH_UDID]
    gym(scheme: "Joyable", configuration: "Beta Release", use_legacy_build_api: true) # Build your app - more options available

    pilot(skip_submission: true)
  end

  desc "Deploy a new version to the App Store"
  lane :deploy do
    # snapshot
    sigh(app_identifier: ENV["app_identifier"], output_path: "./build")
    ENV["PROFILE_UUID"] = lane_context[SharedValues::SIGH_UDID]
    gym(scheme: "Joyable") # Build your app - more options available
    deliver(force: true)
    # frameit
  end

  # You can define as many lanes as you want

  after_all do |lane|

    reset_git_repo

    # This block is called, only if the executed lane was successful

    # slack(
    #   message: "Successfully deployed new App Update."
    # )
  end

  error do |lane, exception|

    reset_git_repo

    # slack(
    #   message: exception.message,
    #   success: false
    # )
  end
end

# More information about multiple platforms in fastlane: https://github.com/KrauseFx/fastlane/blob/master/docs/Platforms.md
# All available actions: https://github.com/KrauseFx/fastlane/blob/master/docs/Actions.md

Environment
fastlane version (fastlane -v): fastlane 1.67.0
Do you use bundler, rbenv or rvm? bundler + rbenv

@Imperiopolis Thanks for reporting! Is this a new or transient issue? https://github.com/fastlane/fastlane/issues/2015 is a currently open issue that describes similar issues and might offer insights into the failure, such as, is this user in a team and have appropriate permissions? Let me know if this helps!

This issue seems to occur every time I attempt to run a lane containing sigh when my credentials are provided via environment variables (DELIVER_PASSWORD, DELIVER_USER). If the password is stored in keychain it works correctly.
I'm not sure if this is a new issue as this is my first time attempting to auth via a method other than keychain.

Thanks, that is helpful info! :+1:

@Imperiopolis Can you try using FASTLANE_PASSWORD instead?

The results appear the same with FASTLANE_PASSWORD.

Any update on this? Anything else I can try?

@Imperiopolis Thanks for following up. We are going to take a look at this as a team and will follow up. Hope that you have a wonderful day! 👍

This message was created automatically by mail delivery software.
A message that you sent could not be delivered to one or more of its
recipients. This is a temporary error. The following address(es) deferred:
<EMAIL_ADDRESS>Domain zyapps.com has exceeded the max emails per hour (490/400 (122%)) allowed.  Message will be reattempted later
------- This is a copy of the message, including all the headers. ------
Received: from o5.sgmail.github.com ([<IP_ADDRESS>]:20062)
by serveur.ex2-p10.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128)
(Exim 4.87)
(envelope-from<EMAIL_ADDRESS>id 1bEKuO-002lwg-7e
for<EMAIL_ADDRESS>Sat, 18 Jun 2016 20:23:57 +0200
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=github.com;
h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe;
s=s20150108; bh=A+V1Fq7hpm63dyVPpp7kP2ozaUw=; b=iwzzw0/gAKI3+fR4
4GnfYE89iLwPGyyB2ioQ9ElW3dW3UEr1dy23UEOiytqP6FuT+Vj+7Pt14aMOO0XC
gTvgL66eWYYSV9VKJcJf7vLWXvZmiARtwYNy5dcmaFwgxvKeamxBWNWQrTnH9l9F
w6Sou/WJdCpBW4DiCzsUDYhd98k=
Received: by filter0627p1mdw1.sendgrid.net with SMTP id filter0627p1mdw1.24383.5765918C11
2016-06-18 18:23:08.379121851 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [<IP_ADDRESS>])
by ismtpd0003p1iad1.sendgrid.net (SG) with ESMTP id OdHwCKM7RoG4DBMf7pNLVA
for<EMAIL_ADDRESS>Sat, 18 Jun 2016 18:23:08.378 +0000 (UTC)
Date: Sat, 18 Jun 2016 11:23:08 -0700
From: fastlane bot<EMAIL_ADDRESS>Reply-To: fastlane/fastlane<EMAIL_ADDRESS>To: fastlane/fastlane<EMAIL_ADDRESS>Cc:
Message-ID<EMAIL_ADDRESS>In-Reply-To<EMAIL_ADDRESS>References<EMAIL_ADDRESS>Subject: Re: [fastlane/fastlane] Sigh crash in spaceship's parse_response
function (#3891)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_5765918c491a7_14fe3f982201729c226824";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: fastlane-bot
X-GitHub-Recipient: yanndupuy
List-ID: fastlane/fastlane <fastlane.fastlane.github.com>
List-Archive: https://github.com/fastlane/fastlane
List-Post<EMAIL_ADDRESS>List-Unsubscribe<EMAIL_ADDRESS>https://github.com/notifications/unsubscribe/AA3w3FaiD6tNK316xn91PY98Z_UHa4Isks5qNDeMgaJpZM4H2lMQ
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address<EMAIL_ADDRESS>X-SG-EID: /bDRkhSo/GH2gzZXMo5AKhbuTgLDPkexBjh/BYa140EqdR1eFDT7JB3J0EfgLNUeLLLJobRhm1aRHe
CEjQ/y6TeJdl+Nl+8DFSfnGobkAMatZigQkMujoFlNlyjuYZYKa0OvOEzBkz6/LP3LTGz3UyK/aZqD
6c8LfbZ4YLtHDsj9W5Yh11VcpjDSX8A5TwTLezbCKR3Gg6TYw8Nt9tnFjno1QY8x7zTdm5dhTvAYxX
g=
X-Spam-Status: No, score=-2.8
X-Spam-Score: -27
X-Spam-Bar: --
X-Ham-Report: Spam detection software, running on the system "serveur.ex2-p10.com",
has NOT identified this incoming email as spam.  The original
message has been attached to this so you can view it or label
similar future email.  If you have any questions, see
root@localhost for details.
Content preview:  There hasn't been any activity on this issue recently. Due
to the high number of incoming GitHub notifications, we have to clean some
of the old issues, as many of them have already been resolved with the latest
updates. [...]
Content analysis details:   (-2.8 points, 5.0 required)
pts rule name              description

-2.3 RCVD_IN_DNSWL_MED      RBL: Sender listed at http://www.dnswl.org/, medium
trust
[<IP_ADDRESS> listed in list.dnswl.org]
-0.0 RCVD_IN_MSPIKE_H3      RBL: Good reputation (+3)
[<IP_ADDRESS> listed in wl.mailspike.net]
-1.4 RP_MATCHES_RCVD        Envelope sender domain matches handover relay domain
0.0 HTML_MESSAGE           BODY: HTML included in message
1.0 HTML_IMAGE_ONLY_16     BODY: HTML: images with 1200-1600 bytes of words
-0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
-0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from author's
domain
0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily valid
-0.0 RCVD_IN_MSPIKE_WL      Mailspike good senders
X-Spam-Flag: NO
----==_mimepart_5765918c491a7_14fe3f982201729c226824
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest fastlane version and check if that solves the issue. Let us know if that works for you by adding a comment :+1:

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/fastlane/fastlane/issues/3891#issuecomment-226957471
----==_mimepart_5765918c491a7_14fe3f982201729c226824
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: quoted-printable
There hasn't been any activity on this issue recently. Due to the high n=
umber of incoming GitHub notifications, we have to clean some of the old is=
sues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest fastlane version a=
nd check if that solves the issue. Let us know if that works for you by add=
ing a comment =F0=9F=91=8D
&mda=
sh;You are receiving this because you are subscribed to this thread.<=
br />Reply to this email directly, view it on GitHub, or mute the thread.

----==_mimepart_5765918c491a7_14fe3f982201729c226824--


how to disable logx print 404 healthcheck info ?

i use the tencent nginx,print to many healthcheck log,

In RPC services?


Ubuntu 17.10 issues with Locale's

after upgrading wsl to ubuntu 17.10 several unfixable error's have been plaguing the terminal.
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
LANGUAGE = (unset),
LC_ALL = (unset),
LANG = ""en_US.UTF-8""
are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
LANGUAGE = (unset),
LC_ALL = (unset),
LANG = ""en_US.UTF-8""
are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").

see https://github.com/Microsoft/WSL/issues/1878#issuecomment-294203566 for a temporary workaround until this known problem is fixed. after unzipping, regenerate the locale.
sudo gunzip --keep /usr/share/i18n/charmaps/UTF-8.gz
sudo dpkg-reconfigure --frontend=noninteractive locales

That works for now :)


Make compatible with ansible-lint >= 4.3.1

This version of ansible-lint replaced ansiblelint.default_rulesdir with
ansiblelint.constants.DEFAULT_RULESDIR.
This obviates the need to pin the version of ansible-lint (see PR #92).

Noticed there are a few things missing which I've fixed locally but first want to test.

@nphilipp just wondering if this PR is ready for review.


⚠ PrivateHD has degraded performance

In 587db3e, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 2061 ms

Resolved: PrivateHD performance has improved in 1f19afd.


feature: filter/sort/paging GlobalTransaction data in the memory for the file mode of 'seata-server'

Ⅰ. Describe what this PR did
新特性：在内存中，对全局事务数据进行数据筛选、排序、分页等功能，主要用于file模式。
注：此PR仅提供功能类，但并未使用。后面的PR将会用于没有筛选、排序或分页功能的store中。如：store.mode=file时。
从PR #2828 拆分出来的第3个PR。
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #2845 into develop will decrease coverage by 0.12%.
The diff coverage is 45.39%.

@@              Coverage Diff              @@
##             develop    #2845      +/-   ##
=============================================
- Coverage      50.14%   50.01%   -0.13%
- Complexity      2951     2980      +29
=============================================
  Files            591      596       +5
  Lines          18950    19065     +115
  Branches        2285     2263      -22
=============================================
+ Hits            9502     9535      +33
- Misses          8503     8545      +42
- Partials         945      985      +40

Impacted Files
Coverage Δ
Complexity Δ

.../java/io/seata/core/store/BranchTransactionDO.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...ore/src/main/java/io/seata/core/store/Querier.java
0.00% <0.00%> (ø)
0.00 <0.00> (?)

...ta/core/store/db/sql/log/AbstractLogStoreSqls.java
100.00% <ø> (ø)
10.00 <0.00> (ø)

...o/seata/core/store/GlobalTransactionCondition.java
25.00% <25.00%> (ø)
9.00 <9.00> (?)

...main/java/io/seata/core/store/AbstractQuerier.java
52.38% <52.38%> (ø)
10.00 <10.00> (?)

...a/server/storage/db/store/LogStoreDataBaseDAO.java
71.08% <87.50%> (-0.10%)
31.00 <4.00> (ø)

...ain/java/io/seata/core/store/GlobalTableField.java
93.75% <93.75%> (ø)
2.00 <2.00> (?)

.../java/io/seata/core/store/GlobalTransactionDO.java
28.57% <100.00%> (+28.57%)
7.00 <1.00> (+7.00)

...e/src/main/java/io/seata/core/store/SortOrder.java
100.00% <100.00%> (ø)
1.00 <1.00> (?)

...seata/core/store/db/sql/log/MysqlLogStoreSqls.java
100.00% <100.00%> (ø)
7.00 <1.00> (ø)

... and 39 more

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: wangliang181230:x: a364176773You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: a364176773:x: wangliang181230You have signed the CLA already but the status is still pending? Let us recheck it.


The LeRobot TODO hyperlink in CONTRIBUTING.md is not working

System Info
The "LeRobot TODO" hyperlink in the contribution guide (lerobot/CONTRIBUTING.md) redirects to a 404 page.
The hyperlink currently redirects to: https://github.com/orgs/huggingface/projects/46

Reproduction

Click the "LeRobot TODO" hyperlink in the contribution guide (lerobot/CONTRIBUTING.md)

Expected behavior
The hyperlink should ideally redirect to a page with a list of to-do tasks.

Thanks @vinayakkgarg for reporting this. We forgot to make the board public. We'll get it organized and update the link shortly. cc @Cadene @aliberts

Fixed ;) https://github.com/orgs/huggingface/projects/46


Highlight 'text/ng-template' (Angular) in script tags as HTML, not plain text

Brackets does not highlight syntax for code inside  tags.
That is not convenient when, for example, a tab-based interface is build using AngularUI Router since the code for each tab would be inside  tags. See for example the following implementation using ionic framework http://ionicframework.com/docs/api/directive/ionNavView/  the code in the third box would not get syntax highlight.
Is there any configuration or extension to fix this?

Marking as a starter bug since the fix for this specific case should be easy (and changed to a more specific title).
The Language Extensibility epic card on our feature backlog tracks the idea of making nested languages extensible in a more general sense.  (Though extensions could use CodeMirror overlay modes to hack in support for nested languages now, it could be done more cleanly if we put some effort into it).

Hi, sorry for the noise, but same problem exists for "text/x-kendo-template". Could we please have a more generic solution?

Hi, I would like to work on this. Can someone guide me?

This should already work as of Release 1.3 (#10666). Does it not work for you?
Closing for now. We'll reopen if there are any issues.

Using Brackets 1.7:

@ShinDarth Use text/ng-template instead of text/template for the type.


STYLE: Use MakePoint, MakeVector, MakeIndex, MakeSize from itk namespace

Replaced calls to the Make functions from the namespace
itk::GTest::TypedefsAndConstructors by calls to the function templates
from itk, that were added by:
pull request https://github.com/InsightSoftwareConsortium/ITK/pull/2633
commit 8aed68490b733ba45b36b2e8e84e99980db45948
"ENH: Add MakePoint, MakeVector, MakeIndex, MakeSize function templates"

@blowekamp Is it OK to you if we just use the new itk::Make function templates now, instead of the original Make functions (from itk::GTest::TypedefsAndConstructors) that you wrote before?

I guess end-users could access them, but GTest sub-namespace implied they are for tests. Not many new tests were written even within ITK. Maybe ask on the forum whether anyone used them? If not (I assume so), we could just remove them and add a not in the migration guide. If somebody did use them, I guess we could
#if defined(legacy)
  using itk::MakeIndex; // make it also available in itk::GTest namespace

Maybe ask on the forum whether anyone used them? If not (I assume so), we could just remove them and add a not in the migration guide.

@dzenanz Shall we then first merge this single-commit PR, and have a new separate PR which removes the original Make functions? The new PR could then be discussed at discourse.


Bump Quarkus to 2.11 and then log the org id in access log.

Also log orgId on slow rbac
This will then look like
2022-07-20 17:33:26,462 INFO  [access_log] (executor-thread-0) "<IP_ADDRESS> - hrupp 20/Jul/2022:17:33:26 -0400 "GET /api/policies/v1.0/policies HTTP/1.1" 403 - orgId=1234567"

<3


Gradient generator

I am a GSSoC'22 Participant
Worked on issue number : #331
It has been added.

@manisha-27 please check it when you are free.

@manisha-27 @heet-kumar please check it.