⚠ Bofrost.lu has degraded performance

In f9a80cd, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1669 ms

Resolved: Bofrost.lu performance has improved in 2608a7f after 42 minutes.


[Queue] Model serialization does not consider selected columns from the original query

Laravel Version: 5.7
PHP Version: 7.4
Database Driver & Version: Mysql 7

Description:
Custom attributes in models get lost after serialization for the queue.
$users = Users::select('email')->where('is_active', 0)->get();

DeactivationReminderJob::dispatch($users);

When the job runs in the worker. Unserialize method will execute the query like
select * from users where is_active = 0

// instead of

select emails from users where is_active = 0

Expected behavior
Expected behaviour is that the serializer should respect the selected columns

Hey there,
Unfortunately we don't support this version anymore. Please check out our support policy on which versions we are currently supporting. Can you please try to upgrade to the latest version and see if your problem persists? If so, please open up a new issue and we'll help you out.
Thanks!


Quotation marks around absolute path contains spaces in tasks.json

VSCode Version: 1.16.1
OS Version: Windows 10, Version 1703, OS Build 15063.608

Steps to Reproduce:

Create project with tasks.json, and input absolute path contains spaces with quotes as args

In Windows 10, double quotes around absolute path contains spaces do not work, but apostrophe works
However, it is just the opposite in Windows 7/8.

Reproduces without extensions: Yes
tasks.json
Reference:
https://github.com/Microsoft/devkit-sdk/issues/585

The problem is that in Windows 10 we use PowerShell as the default shell but under Windows 7/8 cmd.exe,
However if you switch to task version 2.0.0 you can nicely control the shell to use to run the commands making it the same on Windows 10 and 7/8/
Something like:
	"tasks": [
		{
			"type": "shell",
			"taskName": "...
			"command": "..."
			"options": {
				"shell": {
					"executable": "...\\cmd.exe",
					"args": [
						"/d", "/c"
					]
				}
			}
		}

Thanks for the information!


[web]: Flutter command not working in terminal in beta version for web developments

Flutter command is not working even setting the PATH properly in mac machine. But same path is working in stable version but not in beta version. I am developing flutter web.

after running this command "flutter channel beta" it is not working.

Hi @ngts-global
to use flutter web your flutter channel needs to be beta or above;
making sure that you updated your path
could you please run from terminal (not android studio or other IDEs)
flutter channel beta
flutter upgrade -f
flutter create test
cd test
flutter run -d chrome -v

thank you

thank you for the response. I am developing both flutter web  & mobile from my mac. If I just install flutter and try mobile app(android) works fine. But after I "flutter channel beta" run this command , flutter is not getting recognized in terminal though the path is available in bash_profile. here is the output
xxxxx:~$ flutter --version
Flutter 1.17.4 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 1ad9baa8b9 (12 days ago) • 2020-06-17 14:41:16 -0700
Engine • revision ee76268252
Tools • Dart 2.8.4
xxxxx:~$ flutter channel beta
Switching to flutter channel 'beta'...
git: From https://github.com/flutter/flutter
git:    f994b7697..9b9b543d9  beta                   -> origin/beta
git:  + 4656a18fa...f42735ca4 dds_integration_take_2 -> origin/dds_integration_take_2  (forced update)
git:    d9653445f..15a28159b  dev                    -> origin/dev
git:  * [new branch]          experimental_skshaper  -> origin/experimental_skshaper
git:    f994b7697..9b9b543d9  flutter-1.19-candidate.4 -> origin/flutter-1.19-candidate.4
git:  * [new branch]          flutter-1.20-candidate.2 -> origin/flutter-1.20-candidate.2
git:    747fe345f..df98ad6b2  master                 -> origin/master
git:  * [new tag]             1.19.0-4.2.pre         -> 1.19.0-4.2.pre
git:  * [new tag]             1.20.0-1.0.pre         -> 1.20.0-1.0.pre
git:  * [new tag]             1.20.0-2.0.pre         -> 1.20.0-2.0.pre
git: Switched to a new branch 'beta'
git: Branch 'beta' set up to track remote branch 'beta' from 'origin'.
Successfully switched to flutter channel 'beta'.
To ensure that you're on the latest build from this channel, run 'flutter upgrade'
xxxxx:~$ flutter upgrade -f
env: bash\r: No such file or directory
xxxxx:~$

Hi @ngts-global
After executing flutter channel beta, immediately execute flutter upgrade --force and then flutter doctor -v
if you mean flutter upgrade --force isn't after flutter channel betathen provide complete logs forflutter upgrade --force --verbose` with verbose added
Also please check your path as mentioned by @iapicca
Thank you

@ngts-global
I hope you've solved the issue.
Closing since long time without a response


AzureFeed 'dotnetcli.azureedge.net/dotnet' in dotnet-install script was too slow in China

As dotnet/install-scripts#236 , I tried to install sdk with version 5.0.404, it was slow too. So I guss, it is not about latest.version.
Here are the cmds:
./dotnet-install.sh --version 5.0.404
./dotnet-install.sh --version 6.0.100

The script showed their download urls(sdk v5.0 and v6.0):
https://dotnetcli.azureedge.net/dotnet/Sdk/5.0.404/dotnet-sdk-5.0.404-linux-musl-x64.tar.gz
https://dotnetcli.azureedge.net/dotnet/Sdk/6.0.100/dotnet-sdk-6.0.100-linux-musl-x64.tar.gz

Here is my speed in browser:

For current situation, it is always blocked and finally failed when I use the scripts in linux server in China.
Would you like please to check agin and resolve it, THX!

reopen

@rbhanda who should look into this?

Hi @mairaw this doesn't look like something we control. As @bekir-ozturk  mentioned, this is not related to the install scripts.

But who owns the hosting site?

I'm also located in China but cannot reproduce your issue. This may be a networking issue of your ISP (aliyun).

I'm also located in China but cannot reproduce your issue. This may be a networking issue of your ISP (aliyun).

But who owns the hosting site?

The packages are delivered by a CDN.

Are you using VPN or other similar magical things?
I don't think it is aliyun cloud's problem, because it is also slow when I download it in my local PC. As the picture in my first comment, it is my local browser(Edge), and the problem remains.

Are you using VPN or other similar magical things?

No.

I'm in Korea, but I'm experiencing slow downloading, too.
Usually, it's fast and I think it seems to slow down every time updates are distributed.
Visual Studio Installer also stuck in checking updates forever whenever this happened.
I put the traceroute results in Korea below for your reference:
$ traceroute dotnetcli.azureedge.net
traceroute to cs9.wpc.v0cdn.net (<IP_ADDRESS>), 64 hops max, 52 byte packets
 1  <IP_ADDRESS> (<IP_ADDRESS>)  3.967 ms  3.331 ms  3.731 ms
 2  <IP_ADDRESS> (<IP_ADDRESS>)  6.850 ms  6.415 ms  8.109 ms
 3  <IP_ADDRESS> (<IP_ADDRESS>)  12.895 ms  6.539 ms  4.912 ms
 4  <IP_ADDRESS> (<IP_ADDRESS>)  3.861 ms  3.806 ms  3.718 ms
 5  <IP_ADDRESS> (<IP_ADDRESS>)  6.890 ms
    <IP_ADDRESS> (<IP_ADDRESS>)  4.284 ms
    <IP_ADDRESS> (<IP_ADDRESS>)  7.315 ms
 6  * * *
 7  <IP_ADDRESS> (<IP_ADDRESS>)  9.966 ms
    <IP_ADDRESS> (<IP_ADDRESS>)  10.320 ms
    <IP_ADDRESS> (<IP_ADDRESS>)  9.956 ms
 8  <IP_ADDRESS> (<IP_ADDRESS>)  10.946 ms
    <IP_ADDRESS> (<IP_ADDRESS>)  10.911 ms
    <IP_ADDRESS> (<IP_ADDRESS>)  9.293 ms
 9  63-218-147-1.static.pccwglobal.net (<IP_ADDRESS>)  80.820 ms  86.375 ms  82.483 ms
10  bundle-eth53.clbr01.tok02.pccwbtn.net (<IP_ADDRESS>)  80.196 ms  83.689 ms  86.468 ms
11  <IP_ADDRESS> (<IP_ADDRESS>)  108.177 ms  83.993 ms *
12  ae-65.core1.tka.edgecastcdn.net (<IP_ADDRESS>)  93.113 ms  85.440 ms  88.137 ms
13  <IP_ADDRESS> (<IP_ADDRESS>)  87.993 ms  86.437 ms  84.730 ms
14  <IP_ADDRESS> (<IP_ADDRESS>)  84.639 ms  88.155 ms  88.049 ms

this is a cdn error,we can use vscode.cdn.azure.cn host download vs code exe
Example Used:
https://az764295.vo.msecnd.net/stable/d045a5eda657f4d7b676dedbfa7aab8207f8a075/VSCode-darwin-universal.zip
replace
https://vscode.cdn.azure.cn/stable/d045a5eda657f4d7b676dedbfa7aab8207f8a075/VSCode-darwin-universal.zip
this url use cdn node in china，is fast
the same issues like packages.microsoft.com is to lower in chinese
https://github.com/tuna/issues/issues/335
https://github.com/dotnet/core/issues/2882
So can we use the same solution as the VScode team？for example use cdn.azure.cn？

Any progress on this?
It's occasionally slow and occasionally fast, which seems to CDN cause problems.

I also occurred this very slow when config the maui env, I also report to vs feedback. But any progress on this? I also in China.
https://developercommunity.visualstudio.com/t/Download-dotnet-sdk-is-very-slow-in-Chin/10704045


Log cleanup

I've closed my previous PR and opened this one covering only the log cleanup, not touching the bindings. I'll deal with those on a different branch.

Codecov Report

Merging #24 (6e93d74) into boba-develop (336d4ed) will increase coverage by 0.07%.
The diff coverage is 62.50%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files

@@               Coverage Diff                @@
##           boba-develop      #24      +/-   ##
================================================
+ Coverage         45.20%   45.28%   +0.07%
================================================
  Files               439      439
  Lines             30132    30121      -11
  Branches           1975     1975
================================================
+ Hits              13620    13639      +19
+ Misses            15039    15014      -25
+ Partials           1473     1468       -5

Flag
Coverage Δ

bedrock-go-tests
50.22% <62.50%> (+0.10%)
:arrow_up:

cannon-go-tests
81.74% <ø> (ø)

chain-mon-tests
26.95% <ø> (ø)

common-ts-tests
26.82% <ø> (ø)

contracts-bedrock-tests
41.54% <ø> (+0.07%)
:arrow_up:

contracts-ts-tests
6.88% <ø> (ø)

core-utils-tests
44.24% <ø> (ø)

sdk-next-tests
42.60% <ø> (ø)

sdk-tests
42.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

op-chain-ops/state/state.go
63.23% <ø> (-0.54%)
:arrow_down:

op-node/rollup/derive/attributes_queue.go
38.29% <ø> (+0.79%)
:arrow_up:

op-node/rollup/derive/batch_queue.go
72.67% <ø> (-0.16%)
:arrow_down:

op-node/rollup/derive/l1_traversal.go
76.08% <ø> (-0.51%)
:arrow_down:

op-node/rollup/derive/pipeline.go
0.00% <ø> (ø)

op-node/rollup/driver/state.go
0.00% <ø> (ø)

op-node/sources/eth_client.go
40.25% <0.00%> (ø)

op-chain-ops/genesis/layer_one.go
74.17% <50.00%> (ø)

op-node/eth/account_proof.go
60.78% <100.00%> (-2.18%)
:arrow_down:

op-node/node/api.go
42.16% <100.00%> (ø)

... and 5 files with indirect coverage changes


feat(behavior_path_planner): add goal planner

Description

Make pull_over execute when the vehicle is approaching the goal. (within minimum_request_length)
put goal in road

2D Goal Pose in road

modifyPathForSmoothGoalConnection (same as current lane following arrival path)

2D Rough Goal Pose in Road

pull over to the modified goal in road or road_shoulder with the select policy (e.g. parking left_side, right side)

check 2D Goal Pose and 2D Rough Goal Pose
https://user-images.githubusercontent.com/39142679/232829485-b9adcb85-c112-4ba1-972b-8440974c1e17.mp4
check planning to the fixed goal within minimum_request_length
https://user-images.githubusercontent.com/39142679/232829800-fdaf2e3c-ce74-483b-beb7-9b780d9b540f.mp4
lane_change ->goal planner
https://user-images.githubusercontent.com/39142679/232833424-ef5fcad0-3396-4348-a3fc-8e8906ddedc4.mp4
todo: need to execute lane_change and goal_planner wit new behavior path architecture to deal the situation the end of lane change is close to the goal. need
https://user-images.githubusercontent.com/39142679/232833442-83c42958-9d43-47ca-9b97-e21d53a78e88.mp4
put goal in road_shoulder: no change with this PR

pull over the modified goal in road_shoulder with the select policy (e.g. parking left_side, right side)

Related links

https://github.com/autowarefoundation/autoware.universe/issues/3223
Tests performed

psim
tier4 internal scenario test 1325/1330 -> 1325/1330
Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

(plan to rename pull_over to goal_planner in other PR not to mix diff)


OSX install hangs on node scripts/install.js

Running OSX 10.11.6
Node v6.1.0
node -p process.versions -
{ http_parser: '2.7.0',
  node: '6.1.0',
  v8: '<IP_ADDRESS>',
  uv: '1.9.0',
  zlib: '1.2.8',
  ares: '1.10.1-DEV',
  icu: '56.1',
  modules: '48',
  openssl: '1.0.2h' }

node -p process.platform - darwin
node -p process.arch - x64
Installing gulp-sass hangs on the dependancy install of node-sass. This is the same issue as raised here https://github.com/sass/node-sass/issues/1265 I just get:
npm info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>
><EMAIL_ADDRESS>install /Usersproject-path/node_modules/node-sass
> node scripts/install.js

Build timed out (after 35 minutes). Marking the build as failed.

However, I think in my case it may be a network issue (had no problems until recent network changes). What exactly is it that scripts/install.js does? Which URLs / ports should I be checking to see if they've been blocked or throttled?

This does sound like a networking problem. The installation fetching a prebuilt binary from a github release see https://github.com/sass/node-sass/releases.
If you have firewall contraints you can use a set of ENV variables to point the install script at a different location - https://github.com/sass/node-sass#binary-configuration-parameters
It's interesting that the fetch didn't timeout gracefully. A lack of timeouts could be related to some other issues we've seen @saper.

Great, thanks for the info, will take a look at our end - it'll just be a http get though, right? I don't imagine the port is blocked... It may just be a general performance issue at our end.
Does it just attempt to download one of the ...binding.node files? They're only a few MB for OSX by the looks of it.

Yes it's a simple HTTP GET which downloads one of the attached binding.node files based on the local environment.

We're going to add a timeout the binary fetch to hopefully prevent this in the future https://github.com/sass/node-sass/pull/1691.


disable automatic screenshot capture for test failure

In 21st century most of the hub providers provide asynchonously video and screenshots. let's minimize automatic actions we do on carina failure listener especially on test finish.
Reason: driver might be closed/killed/crashed and AfterTest we try to perform screenshot over broken driver.
All failures should be catched by test project

automatic screenshot generation is disabled in listeners


HiveScheduler dispatch behavior configuration

Organization Name: Advantech
Question description:
The hivescheduler seems to dispatch task to new Physical placement only until the GPU/CPU resource in the previous  Physical placement is exhausted by default. For example, In a VC with 2 4-GPU workers named worker0 and worker1, the hive scheduler will place the task to worker1 only until all 4-GPU in worker0 are used.
Could I change the scheduling behavior to load-balancing dispatching so that the hivescheduler will do Physical placement based on the current maximum resources? E.g. At first all 4 GPU are available in both worker0 and worker1, and 1-GPU task will be placed on worker0. Upon the next task is given and worker0 has 3 free GPU and worker1 has 4 free GPU, the hivescheduler will dispatch the task to worker1.
OpenPAI Environment:

OpenPAI version: v1.0.1
Hardware (e.g. core number, memory size, storage size, GPU type etc.):
2 4-GPU workers and 2 16-CPU workers

This is the default behavior of our intra-VC scheduler. https://github.com/microsoft/hivedscheduler/blob/fbff5b09b49f3373b192e3eead9cede2634a4732/pkg/algorithm/intra_vc_scheduler.go.
Currently the VC scheduler does not support anti-affinity scheduling policy.
Can you explain why do you need such behavior?

In openpai v0.10.1, the scheduling seems to distribute jobs among available instead of occupying jbos to worker node one by one.
Just curious that why the default scheduling policy is not as same as before.

Compared with previous policy, current default policy is generally better for deep learning batch jobs, such as improved training perf, and reduced intra-VC resource fragments.
We can add more policys in future.
Pls reopen if any unclear :)


safe nil

@kusakari is there a specific situation in which a nil exception is being thrown because we're not checking for nil here? If there is, it's probably a bug higher up in the call chain—these methods should not be called unless the record set's current state allows it (and callers typically assume a non-nil return value).

@outoftime  Thank you very much for your reply.
I want you to see the below pattern.
class UserGift
  include Cequel::Record

  key :user_id, :uuid
  column :gift_id, :uuid, :index => true
  column :type_id, :int, default: 1
  timestamps
end

user_gifts = UserGift.where(user_id: user.id, gift_id: gift.id).to_a
NoMethodError: undefined method `name' for nil:NilClass
from /Users/xxxxx/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/cequel-101b07cb8cdc/lib/cequel/record/record_set.rb:804:in `next_unscoped_key_name'

@kusakari I see—I do think we're doing something wrong higher in the call chain here; I will take a look.

Thanks!


Fix #176: Create semver 3.0.0-dev.1

This branch contains a first alpha version of the upcoming 3 release of semver. It contains the following changes:

Update README.rst and remove anything related to Python2
Mention maintenance branch maint/v2
setup.py

Update Trove classifiers
Require now Python >=3.6.*
Remove Tox and Clean classes, try to make it as simple as possible

semver.py

Change version number to "3.0.0-alpha0"
Remove old code related to Python2

.travis.yml and tox.ini:

Remove targets py27, py34, py35, and pypy
Add py38, py39, and nightly (allow to fail)

Configure and add Towncrier and the changelog.d/ directory
Improve semver documentation
Rework .gitignore file

HINT

~The commits may be disorganized. I will organize them later.~
~I will update the above description when more corrections/additions are added~

@tlaferriere Thanks for your suggestions, much appreciated! :+1:  I committed all except the Travis part. Im not sure about that, it gave me an error.
I'm not completely finished with all, I'm currently working on separating the tests into different files. Seems I discovered a different (blocker?) bug.

@tlaferriere @python-semver/reviewers @gsakkis @ppkt
I've condensed the commits into more manageable units. Hope all the changes that I did make sense. That's why I've integrated some (hopefully) helpful commit messages. :wink:
Sorry, I know it's a big change, but I guess, this was inevitable. I hope we can release the alpha version soon. My plan is if you don't have any major objections, I'd would like to merge it to master. If all goes well, we can create a next alpha or beta versions.
What do you think?

I've integrated all the changes from @tlaferriere regarding type hints now. Thank you very much! You're awesome! :clap:
As we also deprecated some function, I'm thinking about removing them in the next 3.0.0-dev.2 release (this keeps things a bit organized). What do you think?
If noone objects, I would like to merge that on Sunday.

NB: There's a particular gotcha with type hints. By default mypy will not typecheck functions with no annotations.
Note that
def test_foo(self):
    ...

is not annotated, so it won't be checked. This is the really common way of writing test functions, so by default you have a pretty big gap in type-checking coverage.
You can either enable mypy's check_untyped_defs option (which is "nuclear", and may not be what you want), or add annotations everywhere. The following will be checked:
def test_foo(self) -> None:
    ...

@sbrudenell I tried to type hint as completely as possible except the deprecated functions. I think we will add check_untyped_defs to tox when we remove them. Thanks for the suggestion 👍


Check more things

connect_to_wireguard_with_token.sh only checks for the existence of wg-quick, but not jq or curl.
commit #1 in this pull fixes that - with the added feature that it will complain about all missing tools in a single invocation.

connect_to_wireguard_with_token.sh attempts to write to /etc/wireguard/pia.conf without checking if /etc/wireguard exists
commit #2 in this pull fixes that with a simple mkdir -p /etc/wireguard

connect_to_wireguard_with_token.sh complains about ipv6 being enabled even if it's already been disabled as per the script's suggestion
commit #3 only warns about ipv6 if the suggestion hasn't been heeded

get_region_and_token.sh doesn't provide a way to externally specify the maximum latency
commit #4 allows the default maximum_allowed_latency to be overridden by an external environment variable.

Thank you for your PR!
1

* `connect_to_wireguard_with_token.sh` only checks for the existence of `wg-quick`, but not `jq` or `curl`.
  [commit #1](../commit/0867a3e0e4c2294ed60a24ab29c4d60021dd6dc6) in this pull fixes that - with the added feature that it will complain about _all_ missing tools in a single invocation.

Agreed. This is required.
can you please try to pack that within a function to something like this?
if ! command -v $command &> /dev/null
then
    echo "$command could not be found."
    echo "Please install $command"
    exit 1
fi

2

* `connect_to_wireguard_with_token.sh` attempts to write to `/etc/wireguard/pia.conf` without checking if `/etc/wireguard` exists
  [commit #2](../commit/1788dd58a35ae72fa72bdfb948e4e8b54dae13f8) in this pull fixes that with a simple `mkdir -p /etc/wireguard`

In theory wireguard-tools creates the folder on all distros, but this is good in case something strange happened.
3

* `connect_to_wireguard_with_token.sh` complains about ipv6 being enabled even if it's already been disabled as per the script's suggestion
  [commit #3](../commit/5893acbba462655baf23ab28115bc74cdccfe8f8) only warns about ipv6 if the suggestion hasn't been heeded

Yes, this is nice to have!
4

* `get_region_and_token.sh` doesn't provide a way to externally specify the maximum latency
  [commit #4](../commit/1e9e09c36a7a9c9f2f35f7ce0db4aaac826025a0) allows the default `maximum_allowed_latency` to be overridden by an external environment variable.

As required as the previous commits, however env vars should be written in uppercase. I think MAX_LATENCY is a good name for the variable. Maybe something like this?
if [ -z "$MAX_LATENCY" ]; then
  export MAX_LATENCY=0.05
fi

In theory wireguard-tools creates the folder on all distros

That doesn't help if a user's first invocation of wireguard is via this script, since we invoke curl to write a file there before calling any wireguard tools.
Pushed requested changes :)

Changing MAX_LATENCY may merge-collide with #1, it'll look neater to fix it in merge but I can update that pull too if you prefer.

This looks a lot better now. Thank you for the changes.
I would like to have a look at all PRs before approving this, as you are right, there could be conflicts.

This got merged and modified a bit, to align it with the coding style of the project. After all modifications, it looks like this: https://github.com/pia-foss/manual-connections/tree/9a3d77ac4ed00ecb33b299eecaf2c160cdbe6895
I think we can move on to the other PRs.

Oh nice, you copied check_tool into get_region_and_token.sh, that makes sense


Potential Conflict with Video Embeds?

I'm embedding AdThrive videos into the Slick slider on this homepage (Watch My Latest Video):
https://brownedbutterblondie.com
But only the first video (slide) plays as expected. The second video slider is blank.
I did create a test page to make sure it's possible to embed multiple videos on a page -- and it is.
Is it possible this slider script is conflicting with the videos? Any recommendations?
Thank you for your help.

The culprit seems to be the transform: translate3d(-1820px, 0px, 0px); CSS for the .slick-track DIV.
Can this be worked around?


Set inherit button weight - fix tabs bold font

Fix https://github.com/cesko-digital/mistoveskole/issues/66

Quite bold to apply stuff globally :)
I'd suggest either:

Easier solution: to just apply this but to only those buttons in that component.
Refactor li tabs to roughly this structure:

li
> button (move classes from li here)
->svg
->text

@quentincaffeino updated


Support openSUSE Tumbleweed

When running prisma on openSUSE Tumbleweed, it shows this warning:
prisma:warn Prisma doesn't know which engines to download for the Linux distro "opensuse-tumbleweed". Falling back to Prisma engines built "debian".
Please report your experience by creating an issue at https://github.com/prisma/prisma/issues so we can add your distro to the list of known supported distros.

Can support be added for openSUSE?

Hi @cubetastic33, Alberto from Prisma here. I can confirm Prisma works on OpenSuse Tumbleweed on amd64 / x86_64.
We'll make sure you will no longer see this warning in the next Prisma release.


Added TV Natura

Hi, it throws error "The head commit for this pull_request event is not ahead of the base commit. Please submit an issue on this action's GitHub repo." What can I do about it? Rebase?

Fixed.

Fixed.

Can I somehow prevent it for next time?

This was an internal bug, it will be permanently fixed in the next patch.

This was an internal bug, it will be permanently fixed in the next patch.

Thank you for information, I thought I am making something wrong.


Recommend .NET Standard 2.1 rather than .NET Framework 4.7.2

.NET Framework is old, and completely unsupported, while .NET Standard is still supported and supports all new features of .NET. (And works on Subnautica)

Nevermind!


Add default imbalanced dataset

It could be nice to have a module allowing to load imbalanced dataset from the web.
A list (pp. 40) proposed by Z. Ding could be used for that matter. Some txt file where available at some points but we could take directly the original data.

@glemaitre http://sci2s.ugr.es/keel/imbalanced.php

We could add a data loader/downloader for these files. Keel data format its like arff. I have a draft implementation for generic reading of keel dat files.

Pretty cool. And the link should be always up.

I have this from my MSc experiments:
`def load_database(string, separator=","):
try:
f = open(string, "r")
s = [line for line in f]
f.close()
except:
print 'ERROR LOADING DATABASE ' + string
s = []
s = filter(lambda e: e[0] != '@', s)
s = [v.strip().split(separator) for v in s]
df = np.array(s)
X = np.asarray(df[:,:-1], dtype=float)
d = {'positive': 1, 'negative': 0}
y = np.asarray([d[v[-1].strip()] if v[-1].strip() in d else v[-1].strip() for v in s])

return X, y

`

In fact there is a lot of redundant dataset which differs by the considered class during binarization.
I would think that it could be more efficient to download the original data and apply on the top the imbalancing. Furthermore all or almost all the data come from the UCI which should be also available in mldata.org, this we could directly use the scikit-learn downloader.
What is less clear to me is how to provide several imbalancing ratio for the same dataset and moreover in an easy manner for the user.
What are you thought about that.

@dvro @glemaitre Do we need this after #115?

We have 3 possibilities:

we close that issue considering that the user can download the datasets through sklearn and make it imbalanced.
we provide overload the fuction from sklearn by making a pipeline to load follow by the make_imbalance.
we add new functions to load specific datasets which are redundant in the literature for the imbalancing problem.

In my opinion I would go with choice 1 and make something about 3.

+1 for 1.

@glemaitre @chkoar agreed!


Plassembler stops at Processing Sam/Bam Files and extracting Fastqs

Hi @gbouras13,
Many thanks for your excellent tool. I am trying to implement Plassembler (v1.6.2) within one of my in-house Nextflow pipelines on a Linux machine. Plassembler analysis ran successfully for one of two genomes of interest. For the second genome, Plassembler stopped at the processing Sam/Bam Files and extracting Fastqs step. Kindly find the error message below.
 2024-05-10 17:24:08.037 | INFO     | plassembler:run:793 - Mapping short reads.
  2024-05-10 17:24:08.037 | INFO     | plassembler.utils.external_tools:run_to_stdout:67 - Started running minimap2 -ax sr -t 1 15059/flye_renamed.fasta 15059/trimmed_R1.fastq 15059/trimmed_R2.fastq ...
  2024-05-10 17:25:00.741 | INFO     | plassembler.utils.external_tools:run_to_stdout:69 - Done running minimap2 -ax sr -t 1 15059/flye_renamed.fasta 15059/trimmed_R1.fastq 15059/trimmed_R2.fastq
2024-05-10 17:25:00.742 | INFO     | plassembler:run:800 - Processing Sam/Bam Files and extracting Fastqs.
Traceback (most recent call last):
    File "/MIGE/04_PROJECTS/DAIKOS/longread_analysis/work/conda/plassembler-2a63b87dbbb2cd95edb41776d561fd4c/bin/plassembler", line 10, in <module>
      sys.exit(main())
    File "/MIGE/04_PROJECTS/DAIKOS/longread_analysis/work/conda/plassembler-2a63b87dbbb2cd95edb41776d561fd4c/lib/python3.9/site-packages/plassembler/__init__.py", line 1666, in main
      main_cli()
    File "/MIGE/04_PROJECTS/DAIKOS/longread_analysis/work/conda/plassembler-2a63b87dbbb2cd95edb41776d561fd4c/lib/python3.9/site-packages/click/core.py", line 1157, in __call__
      return self.main(*args, **kwargs)
    File "/MIGE/04_PROJECTS/DAIKOS/longread_analysis/work/conda/plassembler-2a63b87dbbb2cd95edb41776d561fd4c/lib/python3.9/site-packages/click/core.py", line 1078, in main
      rv = self.invoke(ctx)
    File "/MIGE/04_PROJECTS/DAIKOS/longread_analysis/work/conda/plassembler-2a63b87dbbb2cd95edb41776d561fd4c/lib/python3.9/site-packages/click/core.py", line 1688, in invoke
      return _process_result(sub_ctx.command.invoke(sub_ctx))
    File "/MIGE/04_PROJECTS/DAIKOS/longread_analysis/work/conda/plassembler-2a63b87dbbb2cd95edb41776d561fd4c/lib/python3.9/site-packages/click/core.py", line 1434, in invoke
      return ctx.invoke(self.callback, **ctx.params)
    File "/MIGE/04_PROJECTS/DAIKOS/longread_analysis/work/conda/plassembler-2a63b87dbbb2cd95edb41776d561fd4c/lib/python3.9/site-packages/click/core.py", line 783, in invoke
      return __callback(*args, **kwargs)
    File "/MIGE/04_PROJECTS/DAIKOS/longread_analysis/work/conda/plassembler-2a63b87dbbb2cd95edb41776d561fd4c/lib/python3.9/site-packages/click/decorators.py", line 33, in new_func
      return f(get_current_context(), *args, **kwargs)
    File "/MIGE/04_PROJECTS/DAIKOS/longread_analysis/work/conda/plassembler-2a63b87dbbb2cd95edb41776d561fd4c/lib/python3.9/site-packages/plassembler/__init__.py", line 804, in run
      extract_long_fastqs_slow_keep_fastqs(outdir, samfile, plasmidfastqs)
    File "/MIGE/04_PROJECTS/DAIKOS/longread_analysis/work/conda/plassembler-2a63b87dbbb2cd95edb41776d561fd4c/lib/python3.9/site-packages/plassembler/utils/sam_to_fastq.py", line 92, in extract_long_fastqs_slow_keep_fastqs
      "".join(chr(q + 33) for q in quality) + "\n"
  TypeError: 'NoneType' object is not iterable

The bash command;
#!/bin/bash -ue
plassembler run \
        \
-d plassembler_db \
-l 15059.fastq.gz \
-1 15059_1.fastq.gz \
-2 15059_2.fastq.gz \
-m 1  \
-p 15059  \
-o 15059 \
--keep_fastqs \
--keep_chromosome  \
       -r \

My guess is that there are no fastqs to be extracted by Plassembler (using the --keep_fastqs argument). Is this correct? If so, does this mean that no plasmids are present in this genome? If truly there are no plasmids, is it then possible that an empty fastq file (e.g., within the plasmid_fastqs directory) is produced and the run continues with a warning message in the logs rather than stopping altogether (thinking Nextflow/Snakemake application)?

I just did a quick check by running the bash script outside the Nextflow pipeline, with or without the --keep_fastqs argument. Plassembler ran successfully, and showed that there at least 2 circularized plasmids
>1 length=263626 plasmid_copy_number_short=1.04x plasmid_copy_number_long=1.14x
>2 length=43380 plasmid_copy_number_short=0.75x plasmid_copy_number_long=0.47x circular=true
>3 length=42020 plasmid_copy_number_short=1.4x plasmid_copy_number_long=1.36x
>4 length=13841 plasmid_copy_number_short=4.31x plasmid_copy_number_long=1.79x circular=true
>5 length=11136 plasmid_copy_number_short=1.03x plasmid_copy_number_long=0.62x

So, I think it has something to do with my Nextflow pipeline.

I found the cause of the error. The error occured only when I set the argument -m to 1. If -m is not specified (default is 500), the pipeline runs successfully. Is it possible to make the run continue with a warning message in the logs rather than stopping altogether (for the sake of Nextflow/Snakemake)?

Hi @ayoraind ,
Thanks so much for this detailed bug report - I'll put in a fix soon for sure (probably will just skip all really short reads that seemingly cause this issue)
George

Hi @gbouras13,
Thank you very much.


ffe-icons-react: IconProps interface does not allow for rest parameters

Which package is this issue related to?
ffe-icons-react
Describe your issue (screenshots welcome!)
After upgrading ffe-icons-react to 7.2.2 (from 7.0.3, typescript declarations for all icons was added in the 7.1.0) I get a type errors like this
ERROR in /home/sb1a.sparebank1.no/a500118/git/kundeklient-forsikring-bm/kfb-frontend/src/main/components/Huskeliste/Oppgave.tsx(25,30): TS2322: Type '{ className: string; }' is not assignable to type 'IntrinsicAttributes & IconProps & { children?: ReactNode; }'.   Property 'className' does not exist on type 'IntrinsicAttributes & IconProps & { children?: ReactNode; }'.
The code:
<LyspareIkon className="kfb-icon--sm kfb-icon--blue-royal"/>
What is the expected behavior?
As the generated component accepts rest-parameters standard HTML attributes, such as className, should be allowed.
IconProps should probably extend React.HTMLAttributes .

@tutturen can you take a look at this?

Hi! :wave:
I recently joined the new design-system team, and figured this might be a good first issue to resolve :smile:
It seems to me that the most correct attribute to extend is React.SVGAttributes, not React.HTMLAttributes (but I might be wrong here). I tried with both of them, but the latter lacks elements specific to SVG elements. I've created a PR (see mention above this comment).


Updating Office 365 SMTP Server link

The link to the Office 365 SMTP page didn't actually contain the SMTP settings, only POP and IMAP. Updating the link to an article which does contain the Office 365 SMTP Server settings.

Docs Build status updates of commit 0b22df1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/actionable-messages/send-via-email.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Update RubyGems version

The docs mentions how syntax highlighting can be provided via Pygments and also states that the easiest way to get the gem is through RubyGems gem install gollum. However, the RubyGems version hasn't been updated since July and does not have Pygments support. Not very consistent.

+1


XMVectorNegativeMultiplySubtract does not perform negative multiply subtract

It appears that the name of XMVectorNegativeMultiplySubtract is very misleading as the function does not perform what its name states. It would benefit from being renamed to XMVectorMultiplySubtract or XMVectorNegativeMultiplyAdd.
XMVectorMultiplyAdd(a, b, c) does (ab)+c
XMVectorNegativeMultiplySubtract(a, b, c) currently does -(ab)+c (effectively mul/sub or negmul/add)
A true negative multiply subtract such as FMA's _mm_fnmsub_ps(..) cannot be mapped without conflicting with the existing name which uses _mm_fnmadd_ps(..): a negative multiply add.
See here: https://github.com/Microsoft/DirectXMath/blob/ffb2edbd1627e9eec75f68b4ff00e0861ad84ebe/Inc/DirectXMathVector.inl#L3079

Most of the function definitions in DirectXMath date back to xboxmath, which was created for Xbox 360 using an Altivec variant known as VMX128. I've in general not made any breaking changes to the API since that time through xnamath and DirectXMath with respect to what a given function is named and the computation it executes.
The original definition of XMVectorNegativeMultiplySubtract is from that library which as shown on Microsoft docs is:
XMVECTOR result;
result.x = V3.x - V1.x * V2.x;
result.y = V3.y - V1.y * V2.y;
result.z = V3.z - V1.z * V2.z;
result.w = V3.w - V1.w * V2.w;
return result;

Which exactly matched the Xbox 360 VMX128 instruction __vnmsubfp(V1, V2, V3).
This exactly matches the FMA3 instruction _mm_fnmadd_ps(V1, V2, V3) as you note.
For ARM/ARM65, it's vfmsq_f32( V3, V1, V2 ) (true-fused ARMv8) or vmlsq_f32( V3, V1, V2 )
The choice of name here is a bit arbitrary, but it really can't be changed without breaking client code.


Travis config updates

adding auto-deploy to PyPi, assuming version increment
using Trusty
updating cache config, should be a no-op except maybe successfully caching pip files now
installing pandoc with Conda instead of add-ons; necessary for correct README md -> rst conversion
moving pyensembl installs into a before_script section

Coverage decreased (-0.7%) to 91.141% when pulling ef4104af8793cd06442c90202439d2a53bcab454 on travis-config-updates into 4c537240ae82235854d9acdf3b3099a861cf902b on master.

Coverage decreased (-0.7%) to 91.141% when pulling ef4104af8793cd06442c90202439d2a53bcab454 on travis-config-updates into 4c537240ae82235854d9acdf3b3099a861cf902b on master.

Coverage decreased (-0.5%) to 91.312% when pulling ef4104af8793cd06442c90202439d2a53bcab454 on travis-config-updates into 4c537240ae82235854d9acdf3b3099a861cf902b on master.

LGTM


Retries after timeout errors immediately run into timeout after 0 ms

Retries after timeout errors immediately run into timeout after 0 ms
It looks like the SDK is reusing the AbortController from the initial request. But this is already timed out and will no longer work. Possible solution: Create a new AbortController for every request/retry
Here is a screenshot from our logs when the issue happens: The logging is done by wrapper around the fetch function. NETWORK_ERROR means there was no HTTP response status code

here the init of the client
const ctpClient = new ClientBuilder()
            .withProjectKey(config.projectKey)
            .withClientCredentialsFlow({
                host: `https://auth.${config.region}.gcp.commercetools.com`,
                httpClient: fetchWithDefaults,
                projectKey: config.projectKey,
                credentials: {
                    clientId: config.clientId,
                    clientSecret: config.clientSecret,
                },
            })
            .withHttpMiddleware({
                host: `https://api.${config.region}.gcp.commercetools.com`,
                httpClient: fetchWithDefaults,
                enableRetry: true,
                timeout: 5000,
                retryConfig: {
                    retryOnAbort: true,
                    maxRetries: 4,
                    retryDelay: 400,
                    retryCodes: [504, 503, 502, 500],
                },
            })
            .withConcurrentModificationMiddleware()
            .build()

Fixed with the latest version. Thank you


Ensure to wait a second before next tick()

When developing a custom TestShape, a developer needs to implement tick() method, that manages Users spawning. As mentioned in the official documentation:

Locust will call the tick() method approximately once per second.

Therefore, a developer may design a TestShape with a strong assumption that the number of Users will be adjusted with ~1 second interval. Unfortunately, the interval is indeed kept only when no adjustment in Users number is made - hence it seems useless, as any interval is meaningful only during some changes. Here's an example of logs from Locust master when a custom TestShape was implemented and  the tick() method is clearly triggered too often:

the timestamps of log messages show, that 20 Users were spawned within ~6 seconds, while the spawn rate is set to 1.0. In fact I was able to achieve much bigger discrepancies between expected/declared and actual number of users.
In this PR I provide a small adjustment in Runner's code to ensure the ~1 second interval is maintained. Also a small code optimization in handling the current_tick Tuple was added to keep the file length almost unchanged :)

@cyberw I've also added a dedicated test case that doesn't base on get_run_time when modifying the Users count, but relies on 1-sec interval

nice!!

@wiatrak2 is it possible that one of the test cases got a little flaky from this change?  Perhaps it should be adjusted? https://github.com/locustio/locust/actions/runs/6919408511/job/18822743361?pr=2472

@wiatrak2 Can you have a look at the occasionally failing test case? While I do believe your change is good, it did break the test case and I dont have time to analyze why it is breaking, so I might have to revert it...

@cyberw it happened in the worst possible moment - I'm on vacation and away from my computer until December 16th :( I won't be able to have a look before

No worries! I can disable the tests for now (I dont think anything is actually broken, and if it is its a small issue)

Yep, the change was not a sufficient one. If you can disable the test - let's do it. I will have a (very fresh) look once I'm back to the business ;)


cigien: Watch nowgoal3.com

cigien requests the watch of the watch_keyword nowgoal3\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

nowgoal3\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by tripleee in Charcoal HQ


Inconsistency between api doc and implementation

I'm using the compiler API and the specs as references to port handlebars to pascal
The API  states that BlockStatement path must be a PathExpression but the parser accepts string,number and even boolean literals in path.
The examples below works:
{{#1}}ss{{else}}xx{{/1}}
{{#true}}ss{{else}}xx{{/true}}

The current implementation gives the expected behavior and the doc is misleading?

I'm pretty sure that it's due to backwards-compatibility with Mustache

#1277

The documentation has actually been updated in 8088a466cdc204bd97f. Closing


Mutex: implement #try_lock and #sleep

Hello,
If possible, it would be useful to implement Mutex#try_lock and Mutex#sleep in a similar way to the Ruby interface:
try_lock → true or false
Attempts to obtain the lock and returns immediately. Returns true if the lock was granted.
sleep(timeout = nil) → number
Releases the lock and sleeps timeout seconds if it is given and non-nil or forever.
Thanks

@docelic Could you show us use cases of those methods?

I'm interested in use cases, too. I can fathom the need for trying to lock or doing something else, but I can't find actual any use case.
Though, it can help to avoid deadlocks when more than 1 mutex can be locked.

Hey, the specific use case I have here is that multiple threads (or in the case of Crystal, fibers currently) are reading/writing data on a single TCP connection, properly guarded by a Mutex.
Each of these fibers may encounter/detect a broken connection during execution. If that happens, they attempt to re-establish the connection. The one fiber that succeeds calling #try_lock will actually go ahead and run the connection re-establishment loop. Others who don't succeed on #try_lock go do something else until the connection is re-established and they can re-attempt their initial task.
Also somewhat related to this is the Mutex#owned? method, and the Ruby's interface is documented on e.g. http://ruby-doc.org/core-2.4.1/Thread/Mutex.html
Thanks!


The proof of concept assignment completed

Completed part 2 of portfolio project!

I only did basic methods for the proof of concept to be honest. It's 5/8 of my original ideas, didn't create anymore or remove any.

Nice work! Just missing the CHANGELOG (which may be on main, I'll take a look).

Sounds good! I had updated it, I just didn't save it for it to get committed :(


QGIS 3.8.3 crushing at closure

QGIS 3.8.3 crushing at closure report is as follows Crash ID: f4475de87e6a815390b3363a83d3fb7ae10fc9c9
Stack Trace
proj_lpz_dist :
proj_lpz_dist :
proj_lpz_dist :
proj_lpz_dist :
QgsCoordinateTransform::transformPolygon :
QgsCoordinateTransform::transformPolygon :
QgsCoordinateTransform::QgsCoordinateTransform :
QHashData::free_helper :
QgsCoordinateTransform::addToCache :
QgsCoordinateTransform::invalidateCache :
QgsApplication::exitQgis :
QgisApp::~QgisApp :
CPLStringList::operator[] :
main :
BaseThreadInitThunk :
RtlUserThreadStart :
QGIS Info
QGIS Version: 3.8.0-Zanzibar
QGIS code revision: 11aff65f10
Compiled against Qt: 5.11.2
Running against Qt: 5.11.2
Compiled against GDAL: 2.4.1
Running against GDAL: 2.4.1
System Info
CPU Type: x86_64
Kernel Type: winnt
Kernel Version: 10.0.18363
QGIS Bug report should not be reported here.
Check https://qgis.org/en/site/getinvolved/development/bugreporting.html for the proper repository.
Tickets created here will be closed.

Hi @pilipr
As stated in the template of the issue report:

QGIS Bug report should not be reported here.
Check https://qgis.org/en/site/getinvolved/development/bugreporting.html for the proper repository.
Tickets created here will be closed

Issues with the software should be reported at https://github.com/qgis/QGIS/issues.
In your case, 3.8 development is finished almost a year ago so you need to upgrade to active version (currently 3.10 LTR and 3.14) and check whether you still have the bug before any report.
Thanks


Documentation for lean --server

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Checked that your issue isn't already filed.

Specifically, check out the wishlist, open RFCs,
or feature requests.

Reduced the issue to a self-contained, reproducible test case.

Description
Is there any documentation for lean --server? I want to implement a Lean mode for Sublime Text (similar to my Coq mode) but I wasn't able to find any documentation for the server protocol. I looked at the source code but I don't really understand it just from that. A high-level introduction would be appreciated.

Development of Lean 3 has stopped as the developers focus on Lean 4. You can post your issue on the community fork of Lean instead: https://github.com/leanprover-community/lean/issues. But the short answer may be that you'll have to write that documentation yourself as you discover how it works.

Yes, the server mode is sorely lacking documentation because most clients so far have been written by core developers. The lean-client-js server API should at least be much more readable than the C++ code. There's also an LSP implementation in that repo, which AFAIK is used by the vim client (but not by the VS Code extension).
In general, most requests should be relatively self-explanatory, perhaps with the exception of the roi request. This "range of interest" determines what parts of a file should be processed; for parts outside the ROI, neither informational nor error messages will be reported. At least in Emacs, the entire client-server communication can also be inspected by lean-turn-on-debug-mode.

Other sources of information:

the original discussion at https://github.com/leanprover/lean/pull/1227
https://github.com/leanprover/lean-client-js/blob/master/lean-client-js-core/src/commands.ts (this is a more specific version of Sebastian's suggestion)
you can have a look at https://github.com/leanprover-community/format_lean/blob/master/src/format_lean/server.py which is a rough python interface which is enough to produce the tactic state display in https://www.math.u-psud.fr/~pmassot/lean/ for instance (you need to click on math to see Lean code and then click on the darker areas around Lean lines to see the tactic state)

Thanks everyone!


BREAKING CHANGE: TransportMaintenance.psm1 Update-EntriesTracker: Remove default value for Switch Param

Details of the scenario you tried and the problem that is occurring:
Suggested by DSC Resource Kit PSSA Rule Severities, Switch parameters should always default to 'not provided'.
File impacted by this breaking change: TransportMaintenance.psm1
Function impacted: Update-EntriesTracker
Parameter impacted: $DetailLogging
Issue fixed in PR #218
The DSC configuration that is using the resource (as detailed as possible):
n/a
Version of the Operating System, Exchange Server and PowerShell the DSC Target Node is running:
n/a
Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev

Removed breaking change as per https://github.com/PowerShell/xExchange/pull/218#issuecomment-389579101.

This was merged in #218.


scss indentation problem

I wonder why need these indentation here, and also Prettier fix the indentation for me when I save so I cannot be the save with yours. Could you explain why? Thanks!

Hmm good catch @Jexxie, sorry about that not sure why Prettier didn't catch this one for me. Fixed: https://github.com/thomaswangio/vue-admin-dashboard/commit/579aa281c4bd69e9cdf136236ff55f95fdc61197


Tracer implements Closeable

Codecov Report

Merging #242 into master will decrease coverage by 0.14%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #242      +/-   ##
============================================
- Coverage     82.02%   81.87%   -0.15%
+ Complexity      526      524       -2
============================================
  Files            87       87
  Lines          2003     2003
  Branches        236      236
============================================
- Hits           1643     1640       -3
- Misses          262      263       +1
- Partials         98      100       +2

Impacted Files
Coverage Δ
Complexity Δ

...ger-core/src/main/java/com/uber/jaeger/Tracer.java
85.52% <ø> (ø)
18 <0> (ø)
:arrow_down:

...jaeger/reporters/protocols/ThriftUdpTransport.java
77.96% <0%> (-5.09%)
14% <0%> (-2%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d4f0ee...554e933. Read the comment docs.

Shouldn't be hard to write a test for this :) Other than that, LGTM

I would expect the test to be like the testClose, but with a try-with-resources approach. But ensuring it implements the proper interface + keeping the testClose would be enough.

Can somebody merge? (I don't have write access)

Looks like I can't:

any idea what's up with coverage? why does it show a drop in a file that should not be affected?


xWebConfigPropertyCollection: braces not accepted in ItemKeyValue

Details of the scenario you tried and the problem that is occurring
I'm trying to add a URL Rewrite condition that has the ItemKeyValue "{HTTPS}".  When applying this via DSC, I get this error logged to the DSC Operational log:
MIResult: 1 Error Message: The PowerShell DSC resource '[xWebConfigPropertyCollection]HSTS_Condition' with SourceInfo '::688::9::xWebConfigPropertyCollection' threw one or more non-terminating errors while running the Test-TargetResource functionality. These errors are logged to the ETW channel called Microsoft-Windows-DSC/Operational. Refer to this channel for more details. Message ID: NonTerminatingErrorFromProvider Error Category: 7 Error Code: 1 Error Type: MI
Troubleshooting and trying to manually add this using the Add-WebConfigurationProperty cmdlet, the condition is not fully added.  Example:
add-WebConfigurationProperty -pspath "MACHINE/WEBROOT/APPHOST" -Filter "system.webServer/rewrite/outboundRules/rule[@name='Add Strict-Transport-Security when HTTPS']/conditions" -name "." -value @{name='{HTTPS}'}

results in this being added to the applicationHost.config:
<conditions>
<add />
</conditions>

Running the same DSC resource and powershell cmdlet without the { } around the HTTPS results in the condition being added correctly - obviously missing the { } braces.
I'm not sure if this is an escaping issue to do with the braces that I'm missing, or if there is something in the background that is unable to handle them correctly.
If it's a simple escaping issue, any help pointing me in the right direction is appreciated.
The DSC configuration that is used to reproduce the issue (as detailed as possible)
xWebConfigPropertyCollection HSTS_Condition {
            WebsitePath = 'MACHINE/WEBROOT/APPHOST'
            Filter      = "system.webServer/rewrite/outboundRules/rule[@name='Add Strict-Transport-Security when HTTPS']"
            CollectionName = 'conditions'
            ItemName = 'add'
            ItemKeyName = 'input'
            ItemKeyValue = "{HTTPS}"
            ItemPropertyName = 'pattern'
            ItemPropertyValue = 'on'
            Ensure = 'Present'
            DependsOn = '[xWebConfigPropertyCollection]OutboundRuleName_HSTS'
        }

The operating system the target node is running

OsName               : Microsoft Windows Server 2012 R2 Datacenter
OsOperatingSystemSKU : DatacenterServerEdition
OsArchitecture       : 64-bit
WindowsBuildLabEx    : 9600.19376.amd64fre.winblue_ltsb_escrow.190520-1700
OsLanguage           : en-US
OsMuiLanguages       : {en-US}

Version and build of PowerShell the target node is running

Name                           Value
----                           -----
PSVersion                      5.1.14409.1005
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14409.1005
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

Version of the DSC module that was used ('dev' if using current dev branch)
PowerShell      WebApplicationHandler     xWebAdministration             <IP_ADDRESS>
PowerShell      xIisFeatureDelegation     xWebAdministration             <IP_ADDRESS>
PowerShell      xIisHandler               xWebAdministration             <IP_ADDRESS>
PowerShell      xIisLogging               xWebAdministration             <IP_ADDRESS>
PowerShell      xIisMimeTypeMapping       xWebAdministration             <IP_ADDRESS>
PowerShell      xIisModule                xWebAdministration             <IP_ADDRESS>
PowerShell      xSSLSettings              xWebAdministration             <IP_ADDRESS>
PowerShell      xWebApplication           xWebAdministration             <IP_ADDRESS>
PowerShell      xWebAppPool               xWebAdministration             <IP_ADDRESS>
PowerShell      xWebAppPoolDefaults       xWebAdministration             <IP_ADDRESS>
PowerShell      xWebConfigKeyValue        xWebAdministration             <IP_ADDRESS>
PowerShell      xWebConfigProperty        xWebAdministration             <IP_ADDRESS>
PowerShell      xWebConfigPropertyColl... xWebAdministration             <IP_ADDRESS>
PowerShell      xWebsite                  xWebAdministration             <IP_ADDRESS>
PowerShell      xWebSiteDefaults          xWebAdministration             <IP_ADDRESS>
PowerShell      xWebVirtualDirectory      xWebAdministration             <IP_ADDRESS>

Nice timing. I actually ran into this issue recently as well.
I could not find a way to properly escape the key name for the XPath query. However, I was able to partially fix the issue on my local copy of the module by tweaking this in Get-ItemValues
From
    $filter = "$($Filter)/$($CollectionName)/$($ItemName)[@$($ItemKeyName)='$($ItemKeyValue)']"

    $item = Get-WebConfigurationProperty `
                -PSPath $WebsitePath `
                -Filter $filter `
                -Location $Location `
                -Name "." `
                -ErrorAction SilentlyContinue

To
    $filter = "$($Filter)/$($CollectionName)/$($ItemName)"

    $item = Get-WebConfigurationProperty `
                -PSPath $WebsitePath `
                -Filter $filter `
                -Location $Location `
                -Name "." `
                -ErrorAction SilentlyContinue |
                Where-Object -FilterScript {$_.$ItemKeyName -eq $ItemKeyValue}

That handles Get and Test. Set is already fine when an item with that key doesn't already exist. I still haven't quite figured out how to make Set work when the item does already exist with an incorrect property value. A similar approach doesn't seem to work since the item returned by Get-WebConfigurationProperty is read-only and and other specifiers on Set-WebConfigurationProperty (like -AtElement) just build a similar, broken XPath string.


chore: bdd-nh-1597083349 to 0.0.1

chore: Promote bdd-nh-1597083349 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Implement a CLI for Nuclei Classification

The inputs to this CLI should be:

Whole slide image path
Nuclei annotation file (*.anot)
Nuclei feature file (*.hdf5)
Takes a scikit-learn model file (*.pkl)

The outputs of this CLI should be:

Outputs an annotation file (*.anot) with +ve nuclei in one color and -ve nuclei in another color
Outputs probability map at low-res that will be rendered as a heat map

@neal-siekierski here is a link to the heatmap generation we created for cell classification with the active learning system:
https://github.com/cooperlab/ActiveLearning/blob/8508d8cb938d5c39fa59ca612850e7a0adc0f36e/al_server/src/learner.cpp#L2434
A lot of trial and error to get the normalization and window sizes correct.

We have a heatmap view in geojs that scales a scalar value over arbitrary points in a field: http://opengeoscience.github.io/geojs/examples/heatmap/ -- see the earthquake data set for 1.3 million points.  You can tweak all sorts of parameters live there.  @cdeepakroy and I were just discussing adding something to the annotation spec to support this as a first-class output.

This was added in #337.


Library build failing on windows

I'm trying to use diesel in project, developing in windows, pgsql is installed, C compilers probably not.
So my code is
#[macro_use]
extern crate diesel;

fn main() {
    println!("Hello, world!");
}

With cargo:
[dependencies]

diesel = "*"

And after
cargo build

i get this error:
https://gist.github.com/Virviil/79d816aab58822dd9461

It looks like pg_config.exe isn't on your PATH. How did you install postgres on your machine? Can you make sure that executable is on your path and try again?

I have installed it by the "official" way frm here: http://www.enterprisedb.com/products-services-training/pgdownload#windows
...\PostgreSQL\9.5\bin realy was not in my PATH.
After adding problem is not solved.

Can you give the output of where pg_config.exe and also the output of pg_config --libdir?

I've set up appveyor to confirm I didn't have anything funky setup locally. The only step required to get it to build was SET PATH=%PATH%;C:\Program Files\PostgreSQL\9.4\bin (note: Make sure you run cargo clean after setting that if it wasn't set before). I'm going to close this issue, as the library does appear to build on Windows just fine.
I'm happy to help you figure out the issue with your setup though, feel free to continue to comment.

Yes, cargo clean solved the problem. Mb you previous post should be somehow added to readme or faq, i didn't found anything about PATH, and in windows world it's probably not so obvious as in nix.


Use IPv6 in case is the first configured IP with dualstack

Proposed Changes

Use always IPv6 when the first configured node-ip is IPv6 also in case of dualstack.
This fix also will always use the configured node-ip on kubelet to address https://github.com/rancher/rke2/issues/4759
In case of dualstack node-ip it adds CloudDualStackNodeIPs=true as feature-gates configuration to fix https://github.com/k3s-io/k3s/pull/6023 from k8s 1.27 version and it doesn't require to add node-ip=<IP_ADDRESS> within the kubelet args.
The PR also fix https://github.com/k3s-io/k3s/issues/8467#issuecomment-1749125924 showing the IPv6 when listing pods.
Types of Changes

Verification

Testing

Linked Issues

#8467
User-Facing Change

Further Comments

Since CloudDualStackNodeIPs=true starts in 1.27, we won't be able to backport it to all branches. What if you split the PR into two commits? One without the  CloudDualStackNodeIPs=true which can be backported to 1.25 and 1.26 and one with the  CloudDualStackNodeIPs=true (or two PRs, whatever is easier to you)

I already edited a different commit for 1.26 and 1.25. The fix is not working and kubelet is still prioritising the IPv4 as pod IP on those versions.


Flowbite.js stops working with Vite HMR and SolidJS.

Describe the bug
When using Vite HMR with SolidJS, Flowbite.js often stops working when new update is injected.
To Reproduce
Steps to reproduce the behavior:

Install Flowbite with SolidJS
Put a component with JS behavior on the page
Do an update

Expected behavior
Component should keep working.
Additional context
Not a big problem but frustrating because the only way to fix it is to manually refresh the page which nulls and voids the point of using HMR in the first place. Probably a HMR issue only but I included SolidJS in case it matters.

Hi, have you found a workaround for this, I am trying to figure it out too...


LEAN-2403: Remove bundle detection from JATS import

@mbetamony did you try to import a package and check if it goes through?

Also, please fix the failing test.

@mbetamony did you try to import a package and check if it goes through?

Yes, I did via pressroom and everything works fine

Also, please fix the failing test.

Fixed, the snapshot had information about MPBundle

Fixed the manuscripts-data to use the new number found in this PR
Fixed version number

rerun

@mbetamony you need to run yarn install locally and push the updated yarn.lock file.

@mbetamony you need to run yarn install locally and push the updated yarn.lock file.
Done, also removed ticket number from version number since no QA testing is required for this

@mbetamony there is still a failing test.

test are failing in manuscript-dependencies.test.ts, which is testing manuscript-dependencies.ts
The failing test is a result of this PR, It's failing to fetch the data from some of these files.(since manuscripts-data version  is now updated)
I don't see a need or a usage for manuscript-dependencies.ts, should I proceed with removing it along with the test file?


Investigate what is out there- SEO

We need to investigate the other applications with similar names and see what shows up when we search for the website.
We already know that:

The website in French cannot be found as Choix Santé. It can be found as Choix Sante .
Also when we search in French the English version of our website will come up.

No longer relevent


Update / new feature

I have enhancment / suggestion to your awesome bot:)
The thing is Development Points(DP) and their spending, I have noticed that
when u acquire expedition chest there is % chance to get DP and while you
have already acumulated around 9-10 DP then when u get mentioned reward u
will actualy lose 5 or 10 DP, dunno if the same goes with great buildings
which produce DP.
I thought about simple mechanic like playing normal manualy and starting some
research by spending 1DP in prefered tech. After that bot would recognize
marked technology and fullfill it untill end. After that it would spend DP
on others "marked" technologies. If technology is not marked by already
spent point it would start acumulating them.
Other solution for user is to set manualy amount of DP acumulated in time. If user set it manualy to let say "3" everything above 3 will be put in any or somehow prioritized technology.
Some functionality to choose betwen spending DP point on tech or own Great Building would also be very appreciated.
Hope my thoughts will make your bot even better :+1:

I really like this idea! At the moment, I am not sure how sure to implement it, but we welcome pull requests with all proposed code changes.

How about making it multi-language entirely? I mean, besides the in-game language make the full stuff dynamic-multi-language. ..tho i translated the strings to my language, if you make changes it may overwrite the translation after updating.

Hi.. Great work... I have a silly question(newbie here)...
How do i change production from 5 minutes(default) to 15 minutes...??
I totally depend on Terrace farms for supplies..


Compatibility with MechEngineer v0.8.21

LadyAlekto reports that Turbine is incompatible with MechEngineer 0.8.21. Specifically, the free heatsink does not work.  Bug is fixed in 0.8.22.  May be a good idea to learn why.

Code comapre is pure feature implementation and ui mod. Closing for now.
https://github.com/CptMoore/MechEngineer/compare/v0.8.21...v0.8.22


Crash when building if both part 1 and part  2 is implemented.

Thank you for the template, I get a weird issue:
app [main] {
    pf: platform "https://github.com/roc-lang/basic-cli/releases/download/0.17.0/lZFLstMUCUvd5bjnnpYromZJXkQUrdhbva4xdBInicE.tar.br",
    aoc: "https://github.com/lukewilliamboswell/aoc-template/releases/download/0.2.0/tlS1ZkwSKSB87_3poSOXcwHyySe0WxWOWQbPmp7rxBw.tar.br",
}

import pf.Stdin
import pf.Stdout
import pf.Utc
import aoc.AoC {
    stdin: Stdin.readToEnd,
    stdout: Stdout.write,
    time: \{} -> Utc.now {} |> Task.map Utc.toMillisSinceEpoch,
}

main =
    AoC.solve {
        year: 2020,
        day: 1,
        title: "Report Repair",
        part1,
        part2,
    }

## Implement your part1 and part2 solutions here
part1 : Str -> Result Str _
part1 = \_ ->
    Ok "test"

part2 : Str -> Result Str _
part2 = \_ ->
    Ok "test"

Gives me the following output when running run or build
thread '<unnamed>' panicked at crates/compiler/mono/src/ir.rs:6246:56:
called `Option::unwrap()` on a `None` value
stack backtrace:
   0: rust_begin_unwind
   1: core::panicking::panic_fmt
   2: core::panicking::panic
   3: core::option::unwrap_failed
   4: roc_mono::ir::late_resolve_ability_specialization
   5: roc_mono::ir::with_hole
   6: roc_mono::ir::from_can_let
   7: roc_mono::ir::from_can
   8: roc_mono::ir::specialize_variable
   9: roc_mono::ir::call_by_name
  10: roc_mono::ir::with_hole
  11: roc_mono::ir::assign_to_symbol
  12: roc_mono::ir::assign_to_symbols
  13: roc_mono::ir::call_specialized_proc
  14: roc_mono::ir::call_by_name
  15: roc_mono::ir::with_hole
  16: roc_mono::ir::from_can
  17: roc_mono::ir::specialize_variable
  18: roc_mono::ir::specialize_external_help
  19: roc_mono::ir::specialize_all
  20: roc_load_internal::file::run_task
  21: core::ops::function::FnOnce::call_once{{vtable.shim}}
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

The weird thing is that I dont get this error if I have Err TODO in any of the functions, so I can work with part1 and as soon as I get to part 2 it starts crashing.
Running on a basic nix devenv.sh:
{ pkgs, lib, config, inputs, ... }:

{
  env.GREET = "devenv";
  dotenv.enable = true;
  packages = [ pkgs.git
    inputs.roc.packages."x86_64-linux".cli
    inputs.roc.packages."x86_64-linux".lang-server  ];
  scripts.hello.exec = ''
    echo hello from $GREET
  '';

  enterShell = ''
    hello
    git --version
  '';

  enterTest = ''
    echo "Running tests"
    git --version | grep --color=auto "${pkgs.git.version}"
  '';
}

Thank you for your work in putting together a template, been really fun to explore roc so far.

Pretty sure this is a known bug, if you change the error from _ and give it something concrete it should work. The compiler is getting stuck trying to infer that type.
Thank you for reporting.

If anyone else finds this, function signature to: Str -> Result Str Str  solves it


Removal of body and some headers on redirects

PR Checklist:

[x] I have run npm test locally and all tests are passing.
[x] I have added/updated tests for any new behavior.

[ ] If this is a significant change, an issue has already been created where the problem / solution was discussed: #2464 (please note that an related issue has already been created, however no solution had been discussed)

PR Description
As pointed out in issue #2464 some headers, body and _form are being remove on redirects.
Added options followOriginalBody (boolean) and followOriginalBodyForCodes (list) such that if the response status is in followOriginalBodyForCodes ([401, 307] by default to maintain current behavior) or followOriginalBody is true (false by default to maintain current behavior), then host, content-type and content-length headers, body and _form are not removed.
Added the debug information of the headers, body and _form on redirection as the debug info in request.init(options) contains the options, which are not defined in case of redirections.
Also added some tests to check that in case of redirection the above mentioned headers are being removed when the response status is not in followOriginalBodyForCodes and followOriginalBody is false, and not being removed otherwise. The removal or not of the body and _form should also be tested but couldn't find them in the request (indications on how to test them are welcome and appreciated).
Please find below the debug output, including the empty "REQUEST" and the added "REQUEST redirect with headers", "REQUEST redirect with body" and "REQUEST redirect with _form".
REQUEST { uri: 'http://localhost:56556/temp',
  jar:
   RequestJar {
     _jar:
      CookieJar {
        enableLooseMode: true,
        store:
         { idx: { localhost:
            { '/':
               { quux: Cookie="quux=baz; Path=/; hostOnly=true; aAge=3ms; cAge=178ms",
                 ham: Cookie="ham=eggs; Path=/; hostOnly=true; aAge=3ms; cAge=157ms" } } } } } },
  headers: { cookie: 'foo=bar' },
  agentOptions: {},
  agentClass: [Function: FakeAgent],
  callback: [Function],
  method: 'GET' }
REQUEST make request http://localhost:56556/temp
REQUEST onRequestResponse http://localhost:56556/temp 301 { location: 'http://localhost:56556/temp_landing',
  'set-cookie': [ 'ham=eggs' ],
  date: 'Wed, 22 Feb 2017 14:54:58 GMT',
  connection: 'close',
  'transfer-encoding': 'chunked' }
REQUEST redirect http://localhost:56556/temp_landing
REQUEST redirect to http://localhost:56556/temp_landing
REQUEST redirect with headers { cookie: 'foo=bar; quux=baz; ham=eggs',
  referer: 'http://localhost:56556/temp' }
REQUEST redirect with body undefined
REQUEST redirect with _form undefined
REQUEST {}
REQUEST response end http://localhost:56556/temp_landing 301 { location: 'http://localhost:56556/temp_landing',
  'set-cookie': [ 'ham=eggs' ],
  date: 'Wed, 22 Feb 2017 14:54:58 GMT',
  connection: 'close',
  'transfer-encoding': 'chunked' }
REQUEST make request http://localhost:56556/temp_landing
REQUEST onRequestResponse http://localhost:56556/temp_landing 200 { 'x-response': 'GET temp_landing',
  date: 'Wed, 22 Feb 2017 14:54:58 GMT',
  connection: 'close',
  'transfer-encoding': 'chunked' }
REQUEST reading response's body
REQUEST finish init function http://localhost:56556/temp_landing
REQUEST response end http://localhost:56556/temp_landing 200 { 'x-response': 'GET temp_landing',
  date: 'Wed, 22 Feb 2017 14:54:58 GMT',
  connection: 'close',
  'transfer-encoding': 'chunked' }
REQUEST end event http://localhost:56556/temp_landing
REQUEST has body http://localhost:56556/temp_landing 16
REQUEST emitting complete http://localhost:56556/temp_landing

any updates about the merge of it?

I would like to see it merged, too.
Any chance of it happening soon?

+1 It's best


Missing documentation

I stumbled upon a few attributes, which I don't fully understand.

#CertificateRequest/orderContact and #CertificateRequest/approverContact

What are these for and how are they different from each other?

#Order/validationDate

Why is this field writable when creating an order?

Can you elaborate on these? (Please don't add a doc string "Order contact of the CSR" ;-)

Certificate

ownerContact: Owns the certificate.
approverContact: Validates the certificate. This contact will usually receive a phone call from the CA or PSW.

Owner and approver are normally only required for OV and EV certificates.
Order

orderContact: Receives the order confirmation email and all order related notifications.
invoiceContact: Receives the invoice. Can only be changed in the customer portal and is therefore not part of the API.

#Order/validationDate
This field applies to OV and EV certificates. It accepts a date and time when the approver contact wants to be called. It should be in the business hours of PSW. PSW cannot guarantee that the call will happen at this time in all cases. If it doesn't matter to you when you receive a validation phone call then leave it blank.

Thank you for the details.

(#Order/validationDate) It accepts a date and time when the approver contact wants to be called

Currently, we submit a time frame to PSW (via mail), i.e. "between 10am and 3pm". I guess this is not possible to model with this API? (We could use the start of that frame).

Time ranges are not supported. Please use the first possible time.


[FEATURE REQUEST] Add an "underfunded" filter

Is your feature request related to a problem? Please describe.
I find it difficult to quickly identify what categories are underfunded.
Describe the solution you'd like
A way to filter categories for ones that are underfunded.
Describe alternatives you've considered
Scanning and scrolling; frustratingly time consuming
Additional context
Might be best with a similar solution to this: https://github.com/toolkit-for-ynab/toolkit-for-ynab/pull/2803#issue-1275650452
Like so:

@brandon-toner Isn't this already a feature outside of toolkit?

@brandon-toner Isn't this already a feature outside of toolkit?

There's not a way to filter the category list as far as I can tell, however clicking "Underfunded" in Auto-assign will show a list of underfunded categories.

What's nice about filter:underfunded vs the auto-assign route is that it gives you better data. Filtering the list gives you full context: what is assigned, what's the goal; and allows you to evaluate all of the insufficiencies fully, at a glance. Plus, it would work well as a filtering workflow in concert with the "available" filter.

@brandon-toner Sorry, my apologies. I should have read more slowly and clearly here... You are asking for underfunded against goals, not overspent. That's the distinction. Thank you for clarifying!!


New users that are validated with id.me are put on a separate Sendgrid list

Feature
Why is this feature being added?
I want to ensure our scholarship emails are only going to validated members of the military community.
What should your feature do?
New users validated with id.me are put on a separate Sendgrid contact list.

Revisit after the admin interface goes in.


>                       .format(self.name, instance_shape, out.shape))

E                   ValueError: attribute obstime should be scalar or have shape (2, 1), but is has shape (2,) and could not be broadcast.

/home/travis/miniconda/envs/test/lib/python2.7/site-packages/astropy/coordinates/baseframe.py:234: ValueError

=============== 7 failed, 94 passed, 2 skipped in 183.81 seconds ===============

astropy dev is no longer the 1.3 branch but ahead of that. In travis the required tests are for astropy dev, which should probably be an allowed failure for right now. Same with the required numpy tests, which currently skips 1.11 and 1.12 but does require numpy prerelease (related: #272). If we cleaned up which builds were required and integrated #279 that I just commited (small documentation failures), many of the current PRs would start to pass so we could begin work on the updated astropy and numpy fixes easier.

One reason: The logic in parallactic_angle() in observer.py in astroplan 0.2 to figure out the type of the 'target' parameter fails as follows:
In astropy 1.3 the SkyCoord does have a iter attribute, but it is not a vector:
[user@linux astroplan]$ python
Python 2.7.5 (default, Sep 15 2016, 22:37:39)
[GCC 4.8.5 20150623 (Red Hat 4.8.5-4)] on linux2
Type "help", "copyright", "credits" or "license" for more information.

import astropy
from astropy import coordinates
import astropy.units as u
p = astropy.coordinates.SkyCoord(20.0u.deg,20.0u.deg)
getattr(p,'iter')
<bound method SkyCoord.iter of <SkyCoord (ICRS): (ra, dec) in deg
( 20.,  20.)>>
astropy.version
u'1.3'

This means if we construct a SkyCoord() object and plug this as the last parameter into parallactic_angle() of observer.py, an error of the following type is thrown:
coordinate = SkyCoord(list(map(get_coord, target)))
TypeError: argument 2 to map() must support iteration

@rmathar - Yes, the iter related bug is already fixed in #274. There were quite a few regressions, but most of them are fixed in various PRs that are to be merged.
The only remaining one is the broadcasting issue also reported above. I haven't got much time to get to debug it, but there is a slight chance that even those are to be fixed with the various work in progress enhancement PRs.


Uncaught TypeError: Cannot read property 'id' of null

My main app has an iframe within a component that looks as follows:
 <iframe id="frameId1" src="http://localhost:51219/" style="width: 100%;" scrolling="no"/>
with
 plugins: [         broadcast('frameId1')     ]
within the store.
The localhost URL is obviously what the iframe is displaying. It displays it fine (it is also a Vue application) and I need to sync my Vuex state with it. (Is it possible to share state with a Vue application specified in the iframe as a URL like this??? I am trying to move towards microfrontends and thus want components to be deployable separately so they will live on a different server/domain.)
It has
    plugins: [         transfer()     ]
Within its store in order to sync the Vuex state from the main app in to the child app.
However, I just get this same error on the frame app displayed in console:
vuex-iframe-sync.es.js?4ec3:1
Uncaught TypeError: Cannot read property 'id' of null
at eval (vuex-iframe-sync.es.js?4ec3:1)
at eval (vuex.esm.js?edaa:343)
at Array.forEach ()
at new Store (vuex.esm.js?edaa:343)
at eval (store.js?ac69:12)
at Object. (commons.js?v=636849159444181352:170)
at webpack_require (commons.js?v=636849159444181352:55)
at eval (layout.js?5b7c:1)
at Object.9 (layout.js?v=636849159444111345:29)
at webpack_require (commons.js?v=636849159444181352:55)
I cannot for the life of me figure out what is causing this error?
Would really appreciate it if we could figure out the problem.

I have got the same issue. Can anyone report any progress on this?

I have got the same issue. Can anyone report any progress on this?

I'm starting to think that the plugin doesn't intend on being able to actually share state between Vue apps, running on different servers/that have different URLs - despite state being stored client side - as the examples he's given use iframes that are hosted on the same server.
Would be great if @L-Chris could chime in.

Hi @karam94, I was having a very similar issue and in my case it turned out I was installing the plugin during the ssr phase of my app and the code uses window. internally.
So I have to change the logic of when the plugin would be injected.
I hope it helps anybody.

Hi @rulrok , I am using a standard SPA build with Vue, yet still getting this error. Can you let me know how you changed the logic to make this library detect the window object?
Thanks

@ogulcantumdogan Any more details of frameworks and libraries you are using?
In my case, I am building an app with quasar framework for a spa+ssr (server side rendering).
I just don't run this code during the ssr phase, i.e, I don't run this code on node.js which would throw an error because window object does not exist on node.js.
But running it on a browser I don't remember having this problem.
Are you building your app with ssr?

@rulrok I am using the standard setup with webpack build, Vue.js v2.6.12, Vuex and Vue router. I don't think the issue would be about window not existing when the plugin is initialized in Vuex.  Can you maybe share how you initialized the plugin inside your child and parent projects?
Here's my store.js in the parent project:
`import Vue from 'vue'
import Vuex from 'vuex'
import axios from 'axios'
import { getField, updateField } from 'vuex-map-fields'
import { auth, db, firestore, functions, GoogleProvider } from './firebaseConfig'
import {broadcast} from "vuex-iframe-sync";
Vue.use(Vuex)
export default new Vuex.Store({
plugins:[broadcast("flowFrame")],
state: {
... }
... })
`
here's my store.js in the child project:
`
import Vue from 'vue'
import Vuex from 'vuex'
import {transfer} from 'vuex-iframe-sync'
Vue.use(Vuex)
export default new Vuex.Store({
plugins: [
transfer()
],
getters:{
},
state: {
}
.....})
`
Do you think there could be a problem about dependencies of this project, since apparently it is not maintained anymore by @L-Chris  ?

Based on plugin's source code:
https://github.com/L-Chris/vuex-iframe-sync/blob/6fddf4b353b96a1a4b75f9b60ec3c86655d492e3/src/index.js#L22-L28
you are able to pass an id of the child frame into the transfer() function.
After that, the error is gone, but there appears another one with the browser's CORS things.

可以尝试 看下，是否window.$vm 未挂载vue 实例


Change demo instructions to use the correct package manager

The repo is using pnpm as package manager. This pull request changes the Demo instructions to use pnpm instead of yarn.

coverage: 81.714%. remained the same
when pulling 5c8adf67c9851110cdbf559e0b19bbeda9a0e23e on change_demo_instructions
into 410df802e792acbbf93237ca4f8d7a4735ef2de2 on master.


doc: minor CONTRIBUTING tweaks after onboarding

Pull Request Description

Small improvements I found missing while onboarding.
Also, based on info from @MichaelMauderer, rustfmt is now used in ide
codebase.
Important Notes

Checklist
Please include the following checklist in your PR:

[ ] The documentation has been updated if necessary.
[ ] All code conforms to the Scala, Java, and Rust style guides.
[ ] All documentation and configuration conforms to the markdown and YAML style guides.
[ ] All code has been tested where possible.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Mateusz Czapliński seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Disable ripple effect?

Hi!
How can I disable ripple effect for android 4.x?

+1

You can hide the view with the effect:
mTabHost.newTab().getView().findViewById(R.id.reveal).setVisibility(View.GONE);

Works perfectly, though I find this an ugly hack :/ Thank you anyway! :)


Fixed navbar issue

Related Issue
#799
Description
Fixed navbar CSS in mobile view
Type of PR

[ ] Bug fix
[X] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
Before:

After :

Checklist:

[x] I have performed a self-review of my code
[x] I have read and followed the Contribution Guidelines.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.

Additional context:
[Include any additional information or context that might be helpful for reviewers.]

@Suchitra-Sahoo please add gssoc label also

It has not changed

it is working fine on local host

should i make a new PR ?

But on my side its looking like this only.

But on my side its looking like this only.

I think there is some problem in merge

The changes i have made is not changed in repo files

please check PR #822

please add gssoc label in PR
unless it will not be counted as contribution

@Suchitra-Sahoo Please add Gssoc label Mam


ruby-saml library invalidating SAML assertion signature where xmlns:ds namespace declaration is missing

We are using your ruby-saml library to enable SSO for customers into our web application.
One of our customers is using Tivoli's FIM platform for SAML SSO. Previously they only signed their SAML assertion and everything worked fine. The OneLogin ruby-saml library began invalidating their SAML assertion signature when they began signing their SAML assertion and response. After some troubleshooting we discovered that the Tivoli FIM platform moved the xmlns:ds="http://www.w3.org/2000/09/xmldsig#" namespace declaration out of the assertion signature element and put it in the first line of the <samlp:Response> element expecting it to be inherited by any <ds:signature> elements that follow. This behavior appears to be hard-coded into the Tivoli FIM product and may be impossible to change.
Is there any way to get the OneLogin ruby-saml library to honor the xmlns:ds="http://www.w3.org/2000/09/xmldsig#" namespace when it is declared only once at the top of the SAML response?
Thanks!
Here is a copy of the SAML response (relevant elements only) that ruby-saml sees as invalid:
<samlp:Response xmlns:ds="http://www.w3.org/2000/09/xmldsig#"
xmlns:saml="urn:oasis:names:tc:SAML:2.0:assertion"
xmlns:samlp="urn:oasis:names:tc:SAML:2.0:protocol"
xmlns:xs="http://www.w3.org/2001/XMLSchema"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
....
<saml:Assertion ID="Assertion-uuidae349e99-014f-11c6-844c-a6a86d8ccbb1"
IssueInstant="2015-09-08T18:25:28Z"
Version="2.0">
<saml:Issuer Format="urn:oasis:names:tc:SAML:2.0:nameid-format:entity">https://abc.com/auth/sps/samlidp/saml20</saml:Issuer>
<ds:Signature Id="uuidae349e9a-014f-1e8d-b0b2-a6a86d8ccbb1">
....

SAML implementations used to delegate Signature/Encryption on 3rd party libraries.
The problem is that in order to decrypt or validate a sign the 3rd party library expects the part that you want to valdate/decrypt , not the whole XML. Not providing the namespace on the part will produce decrypt/sign validation problems.
That is why most of the SAMLResponse that you will see not declares ds/xs/xsi on the top.
A possible trick to solve it: Before decrypt/validate the signed element, check if contains the namespace and if they are not there, inject them (but only a duped version, never modify the original).

Sixto,
Any plans for OneLogin to update its ruby-saml library to inherit and honor namespaces declared at the top of an SAML XML document?

Right now I'm focused on the java-saml improvement. (It will take 2-3 weeks more). After that we will improve these kind of issues.

@dgindin-cp this should solve your issue:
https://github.com/onelogin/ruby-saml/commit/46c221f6bc3379523781394e4a34b7329d5a4e18

I'm also running into this issue, in combination with xmlns:ds becoming xmlns:dsig

I am also facing this issue, When SAML response comes back to SP got the following error.
SAML Response invalid
Invalid SAML Response. Not match the saml-schema-protocol-2.0.xsd
Thanks in advance!


Content_based and Collaborative Suggestion not appear

I run the lda model and fwls calculator as well as the other calculator module from builder folder. All the recommendations shows up on the main page of main user except the content-based and collaborative-based recommendation. But I could see few suggestion of them in the other users page. Did I make any mistake here?

About the CF recs, u may need to run builder.user_cluster_calculator to get current user into one of 23 default cluster beforehand.

But about the CB recs, I haven't got them to show up. Any idea?

After reviewing the code in builder/lda_model_calculator.py, i found that smthing off in that. Changing the movie_id in save_similarity_with_* functions does help fix the error.