JsonConvert getting reported as not supported on 4.7.2, .net Standard 2.0 and .net Core 2.1

Whilst trying to use the Compatability Analyzer to convert a library from .net framework to .net standard 2.0 compliant, I have noticed that it is reporting JsonConvert SerializeObject and DeserializeObject as NOT being compatible with ANY of .net framework 4.7.2, .net core 2.1 or .net standard 2.0
This doesn't make any sense.
To reproduce:

Create a new .net Standard 2.0 class library.

Add NewtonSoft.Json nuget

In class1.cs add:
public class Class1
{
public void DoSomething()
{
const string data = "Hello";
   var json = JsonConvert.SerializeObject(data);
}

}

Build and then run the Analyzer (v2.5.0)
The result on my machine (using VS 15.9.2) is:

Hey,
This tool focuses on APIs shipped by the .NET Framework (ie. System., Microsoft.). We don't currently take into consideration third party libraries like Newtonsoft.Json.
I hope this helps,
Connie

@conniey I've downloaded the code, compiled it and ran it again against the same test app, this time it comes back as 100% compatible for all platforms.
When you say "we don't currently take into consideration third party libraries" do you mean that the VS "extension/plugin" version doesn't but the console app has the ability to scan these 3rd party dependencies?
It's rather confusing as the extension results read to me that it knows Newtonsoft.json isn't compatible - wouldn't a question mark symbol be more appropriate for "i don't know about this library"?
i'm now trying to figure out why there's a difference between the VS extension and the commandline versions?

@terrajobst Looks like JSON.NET is in the catalog. Are 3rd party libraries like this marked in the catalog in a special way to filter out?

This looks similar to #702

@terrajobst Looks like JSON.NET is in the catalog. Are 3rd party libraries like this marked in the catalog in a special way to filter out?

Not systematically. Looking at JSON.NET it seems we added because ASP.NET Core depends on it.

We should probably filter those out I'm thinking. They aren't really helpful for the ApiPort scenarios


Service parameter not accepting multiple services

Describe the bug
When passing a list of services to -Service parameter an error message shows up that parameter can not be converted to String.
To Reproduce

Import / Install Module
Call Connect-MS365 -Service EOL,AAD

Expected behavior
All services named in the parameter should be accepted and iterated if valid.
Should open two connections, one to EOL, one to AAD

ba29d0664f41e0146dd5e559acfc41aeeb881a5e


[5.8][Runtime] Fix key paths on 32-bit with KVC string pointers in the top half of memory.

Cherry-pick https://github.com/apple/swift/pull/63302 to release/5.8.
Key paths can store an offset or a pointer in the same field. On 32-bit, the field is considered to be an offset when it's less than the 4kB zero page, and a pointer otherwise.
The check uses a signed comparison, so pointers in the top half of memory would look like negative offsets. Add a check that the offset is zero or positive to avoid this.
rdar://103886537

@swift-ci please test

@swift-ci please test macos platform


FIX: Adjust month in getDateFromUTCSeconds

The Date.prototype.getMonth() returns a zero-based value (docs), similar to Date.prototype.getDay() (day of the week, not used here) but different from Date.prototype.getDate() (day of the month, 1-31). So we need to add one to month (but not day and year).
Alternatively, we could get date string with d.toISOString().substring(0,10)
Fixes #90

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@7e55357). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #144   +/-   ##
=======================================
  Coverage        ?   74.84%
=======================================
  Files           ?       19
  Lines           ?     1296
  Branches        ?        0
=======================================
  Hits            ?      970
  Misses          ?      326
  Partials        ?        0

Flag
Coverage Δ

unittests
74.84% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e55357...1e03509. Read the comment docs.


feature: add cappyzawa/telescope-terraform.nvim and ANGkeith/telescope-terraform-doc.nvim to lazyvim.plugins.extras.lang.terraform

Did you check the docs?

[X] I have read all the LazyVim docs

Is your feature request related to a problem? Please describe.
cappyzawa/telescope-terraform.nvim provides information about terraform modules, resources, & data through Telescope.
ANGkeith/telescope-terraform-doc.nvim provides terraform documentation information through Telescope
Describe the solution you'd like
Enabling lazyvim.plugins.extras.lang.terraform should automatically setup these telescope extensions
Describe alternatives you've considered
Overriding telescope plugin to manually setup additional extensions.
Additional context
No response

You don't have to overwrite the telescope plugin, you can just extend it. Also, most contributions come through PRs, so feel free to make one that extends the current terraform extra. Otherwise, you'll have to wait for someone who uses the plugins to make the PR.

@dpetka2001 - Thank you. I am working on a PR as we speak 😄


publish<EMAIL_ADDRESS>

Requested by: @armcknight
Merge target: (default)
Quick links:

View changes
View check runs

Assign the accepted label to this issue to approve the release.
Leave the #retract comment under this issue to retract the release (original issuer only).
Targets

[ ] github
[ ] cocoapods[sentryprivate-cocoapod]
[ ] cocoapods[sentry-cocoapod]
[ ] registry

Targets marked with a checkbox have already been executed.  Administrators can manually tick a checkbox to force craft to skip it.

@armcknight

is the changelog messed up?

#retract


chore(master): release 9.1.6

:robot: I have created a release beep boop
9.1.6 (2023-02-17)
⚠ BREAKING CHANGES

add forwardRef to all components that contain innerRef

Features

add forwardRef to all components that contain innerRef (17a141a)

Bug Fixes

convert functional components to be forwardRef components vs redefining them as such (86578ab)
Label: migrate label to rtl (#2665) (8c5cc2b)
revert v10 merge (3392ce9)

Miscellaneous

release 9.1.6 (f32f3d2)

This PR was generated with Release Please. See documentation.

This is a fake release because we couldn't rewrite our history. There are actually no breaking changes, so we will rewrite the changelog manually. This only reverts any v10 changes that were on master.


the select for multi-GPU card

"How to specify the specific GPU number, such as GPU:3 or GPU:2, in a multi-GPU card setup?"

Hi @sysusicily, when you launch these scripts like composer train.py ..., the Composer launcher script will attempt to run on all available GPUs. There are some arguments you can use to control this behavior like composer -n 4 train.py ... which would limit to using only 4 GPUs.
But to get fine-grained control, I would recommend setting the environment variable CUDA_VISIBLE_DEVICES before running a script to target exactly the GPUs you want.
# This will run on all available GPUs
composer train.py ...

# This will run on first 4 available GPUs
composer -n 4 train.py ...

# This will run across 4 GPUs but exactly GPUs #2, #3, #4, #5
export CUDA_VISIBLE_DEVICES="2,3,4,5"
composer train.py ...

# This will run on 1 GPU but exactly GPUs #3
export CUDA_VISIBLE_DEVICES="3"
composer train.py ...


Xcode archive step mac

@viktorbenei @godrei can you please take look if it seems right/if you miss something? I have some issues with that rvm workaround, but the problem might be with my setup. Still, I might need some clarification on that part to be able to test it.

and merry Xmas 😄🎄🎁

We'll do it ASAP, thanks for the PR and Merry Christmas! 🎄😉

Sent a PR with proposed, non critical changes, but this version is perfectly acceptable as it is - merged! 🚀🎉


Updated the linter settings image.

I have updated the image for linter setting, so it lines up with the updated setting in Visual Studio. There are some docs that have this image referenced but the image wasn't displaying the right information.

@TylerMSFT
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

#sign-off

@ShannonLeavitt , the system isn't allowing us to #sign-off.  Do you know what the deal is? I own the docs in this directory.

@ShannonLeavitt , interesting. How would I set the author for an image?

@TylerMSFT - I don't think there's a way to do that. Fortunately, image-only PRs are rare; when these PRs pop up we can manually assign and merge them.


stdout backend, invalid command

Hi,
i've checked out the master branch and compiled with:
cargo build --features stdout-backend
but on connect it panics:
obelix debug # ./librespot -u machine-username -p machine-password --backend stdout -n test --device /tmp/snapfifo
INFO:librespot::main_helper: librespot 5ae1397 (2016-11-22). Built on 2017-03-03.
INFO:librespot::session: Connecting to AP gew1-accesspoint-a-t74a.ap.spotify.com:4070
INFO:librespot::session: Authenticated !
 Built on 2017-03-06.
INFO:librespot::session: Connecting to AP "lon6-accesspoint-a13.ap.spotify.com:4070"
INFO:librespot::session: Authenticated as "xxx" !
INFO:librespot::player: Loading track "For A Day - Extended Mix"
Ungültiger Maschinenbefehl

I'll take it that Ungültiger Maschinenbefehl means Illegal Instruction.
This usually happens on ARM devices when compiling for the wrong architecture variant, but you mentioned x64.
Are you compiling on the same device you are running it on ? Is this some exotic / very old CPU ?
Do other audio backends work fine ?
If you run librespot in gdb, can you get the location of the crash ?
The pipe backend outputs to stdout if the --device argument is omitted.

It is a virtual Maschine (VMware esx)
The CPU:
model name      : Intel(R) Xeon(R) CPU           X5650  @ 2.67GHz
I've compiled it on this Maschine, it is running Ubuntu 14.04 with actual Rust stabel
A mopidy Server with Pipe to snapcast works fine, official Spotify through alsa and and a Pipe to snapcast also works fine.
If ich compile it for armf and Run it on a raspberry everything works as expected
What do you mean with gdb?
http://www.9folders.com/

Von: Paul Liétar<EMAIL_ADDRESS>Gesendet: 06.03.2017 5:04 nachm.
An: plietar/librespot
Cc: Philipp Zeitschel; Author
Betreff: Re: [plietar/librespot] stdout backend, invalid command (#155)
I'll take it that Ungültiger Maschinenbefehl means Illegal Instruction.
This usually happens on ARM devices when compiling for the wrong architecture variant, but you mentioned x64.
Are you compiling on the same device you are running it on ? Is this some exotic / very old CPU ?
Do other audio backends work fine ?
If you run librespot in gdb, can you get the location of the crash ?
The pipe backend outputs to stdout if the --device argument is omitted.

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/plietar/librespot/issues/155#issuecomment-284441212, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAOL9eyMw1Hd1-nFMeD0ZIjx56bHD33Qks5rjC5qgaJpZM4MSKCH.

I meant can you run librespot with the alsa backend fine ?

What do you mean with gdb?

$ gdb --args target/release/librespot -c /tmp/librespot/ -n obelixTest -u xxx -p xxx --backend pipe --device /tmp/snapfifo
[ ... ]
(gdb) run
[ wait for it to crash ]
(gdb) backtrace

obelix librespot # gdb --args /usr/src/librespot/target/release/librespot -c /tmp/librespot/ -n obelixTest -u xxx --backend pipe
GNU gdb (Ubuntu 7.7.1-0ubuntu5~14.04.2) 7.7.1
Copyright (C) 2014 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from /usr/src/librespot/target/release/librespot...done.
(gdb) run
Starting program: /usr/src/librespot/target/release/librespot -c /tmp/librespot/ -n obelixTest -u xxx --backend pipe
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
INFO:librespot: librespot 6a0657f (2017-02-22). Built on 2017-03-06.
[New Thread 0x7ffff39ff700 (LWP 27372)]
[New Thread 0x7ffff37fe700 (LWP 27373)]
[New Thread 0x7ffff31ff700 (LWP 27374)]
[New Thread 0x7ffff2bff700 (LWP 27375)]
[Thread 0x7ffff31ff700 (LWP 27374) exited]
[Thread 0x7ffff37fe700 (LWP 27373) exited]
[Thread 0x7ffff2bff700 (LWP 27375) exited]
[Thread 0x7ffff39ff700 (LWP 27372) exited]
INFO:librespot::session: Connecting to AP "gew1-accesspoint-a-t4hh.ap.spotify.com:4070"
INFO:librespot::session: Authenticated as "xxx" !
[New Thread 0x7ffff39ff700 (LWP 27376)]
INFO:librespot::player: Loading track "#Eroina - Midi Culture Remix"

Program received signal SIGILL, Illegal instruction.
[Switching to Thread 0x7ffff39ff700 (LWP 27376)]
0x0000555555879f11 in rust_crypto_aesni_setup_working_key_128 ()
(gdb) backtrace
#0  0x0000555555879f11 in rust_crypto_aesni_setup_working_key_128 ()
#1  0x0000555555879ea7 in rust_crypto_aesni_setup_working_key_128 ()
#2  0x0000555555878490 in crypto::aesni::setup_working_key_aesni_128::h76af4df5a4d993d9 ()
#3  0x000055555586fb1d in crypto::aes::ctr::h2259629bc992a715 ()
#4  0x000055555568ab82 in librespot::player::PlayerInternal::load_track::h5c9f56c136d2c7fc ()
#5  0x00005555556856ac in librespot::player::PlayerInternal::run::hddb41b3ee2b02210 ()
#6  0x00005555555f5991 in std::panicking::try::do_call::h1aff37fc44677d52 ()
#7  0x00005555559178ab in panic_unwind::__rust_maybe_catch_panic ()
    at /buildslave/rust-buildbot/slave/stable-dist-rustc-linux/build/src/libpanic_unwind/lib.rs:98
#8  0x00005555555fa29d in _$LT$F$u20$as$u20$alloc..boxed..FnBox$LT$A$GT$$GT$::call_box::ha9cb8bac9b2551f3 ()
#9  0x000055555590f6f5 in call_once<(),()> () at /buildslave/rust-buildbot/slave/stable-dist-rustc-linux/build/src/liballoc/boxed.rs:615
#10 start_thread () at /buildslave/rust-buildbot/slave/stable-dist-rustc-linux/build/src/libstd/sys_common/thread.rs:21
#11 std::sys::imp::thread::{{impl}}::new::thread_start () at /buildslave/rust-buildbot/slave/stable-dist-rustc-linux/build/src/libstd/sys/unix/thread.rs:84
#12 0x00007ffff739f184 in start_thread (arg=0x7ffff39ff700) at pthread_create.c:312
#13 0x00007ffff6c9537d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111
(gdb) quit

obelix librespot # cargo build --release --features "alsa-backend portaudio-backend pulseaudio-backend"
   Compiling alsa v0.0.1 (https://github.com/plietar/rust-alsa#8c63543f)
   Compiling libpulse-sys v0.0.0 (https://github.com/astro/libpulse-sys#3e167c0d)
   Compiling librespot v0.1.0 (file:///usr/src/librespot)
    Finished release [optimized] target(s) in 79.44 secs

obelix librespot # target/release/librespot -c /tmp/librespot/ -n obelixTest -u xxx --backend ?
INFO:librespot: librespot 6a0657f (2017-02-22). Built on 2017-03-06.
Available Backends :
- alsa (default)
- portaudio
- pulseaudio
- pipe

obelix librespot # target/release/librespot -c /tmp/librespot/ -n obelixTest -u xxx --backend alsa
INFO:librespot: librespot 6a0657f (2017-02-22). Built on 2017-03-06.
INFO:librespot::session: Connecting to AP "gew1-accesspoint-a-sssh.ap.spotify.com:4070"
INFO:librespot::session: Authenticated as "xxx" !
INFO:librespot::audio_backend::alsa: Using alsa sink
INFO:librespot::player: Loading track "#Eroina - Midi Culture Remix"
Ungültiger Maschinenbefehl

obelix librespot # target/release/librespot -c /tmp/librespot/ -n obelixTest -u xxx --backend pulseaudio
INFO:librespot: librespot 6a0657f (2017-02-22). Built on 2017-03-06.
INFO:librespot::session: Connecting to AP "lon3-accesspoint-a9.ap.spotify.com:4070"
INFO:librespot::session: Authenticated as "xxx" !
INFO:librespot::player: Loading track "#Eroina - Midi Culture Remix"
Ungültiger Maschinenbefehl

Thanks, that's not related to the pipe backend but to rust-crypto's manual assembly.
I've updated the title to reflect this.
The bug has already been reported in https://github.com/DaGenix/rust-crypto/issues/391 and  https://github.com/DaGenix/rust-crypto/issues/390 .
Unfortunately rust-crypto isn't seeing many updates these days. I'll try to find a workaround.

thank you for your feedback and work!
i've tried it on ubuntu 16.04 also but same error.
crossing fingers rust-crypto is fixing it fast

with the codechanges suggested by @yd021976 in https://github.com/DaGenix/rust-crypto/issues/390 it works like a charme!

Thank you ! Happy my codechabge is helping :-)
I think my patch should be improved by selecting asm code according cpu plateform.
Can't do this actually becausr i switched from linux to windows on my living room media center (and have no time to code at this time)

can you tell me what steps I need to take to fix this ? I have the same issue trying to run librespot on a x86 machine

What I did to fix this was:

Search for a fork of rust-crypto that has the patch already applied (I used this one)
Edit Cargo.toml to use the patched fork, i.e. change the line
rust-crypto = "0.2.34" to
rust-crypto = { git = "https://github.com/awmath/rust-crypto.git", branch = "avx2" }
cargo build <...> librespot again: That's it!

Now librespot finally works on my Intel Braswell Atom CPU :)

@suluke thanks for your answer, that indeed did the trick for me too.

Fixed by @shanemeagher in #208.
Thanks


Added fake_pathlib implementation

added implementation and test for fake pathlib
moved some functionality from FakeOsModule to FakeFilesystem to be
able to use it from fake pathlib
added follow_symlinks argument to to some funxtions in FakeOsModule
(stat, chmod, chown, access, utime)
added replace() and lchmod()
fixes #29

@jmcgeheeiv: Please review when you find time.
Also note that I took the liberty of closing the other issue, as it is clearly fixed.

Ok, I'm going to merge this - you can review it anyway when you get time, or back it out in the worst case.


[Bug report] Cyrillic "ё" is replaced by "е" and "й" is replaced by "и" in heading URLs

Bug report
Description

In the heading URLs Cyrillic "ё" is replaced by "е" and "й" is replaced by "и". For example, heading # Учёный becomes #ученыи in the generated link. It breaks TOC generation and makes it hard to create links in large documents.
Steps to reproduce

Reproduction link / repo: https://dg.ruleplaying.com/agents/profession.html#ученыи

Expected behavior

"ё" and "й" should not be replaced with other characters.
Screenshots

Environment info

Browser: Google Chrome
Output of vuepress info:

# Paste output of `vuepress info` here
  System:
    OS: Windows 10 10.0.19043
    CPU: (16) x64 Intel(R) Core(TM) i7-10700KF CPU @ 3.80GHz
    Memory: 21.13 GB / 31.81 GB
  Binaries:
    Node: 15.4.0 - ~\AppData\Local\Temp\yarn--1628050631067-0.2130519351535134\node.CMD
    Yarn: 1.22.10 - ~\AppData\Local\Temp\yarn--1628050631067-0.2130519351535134\yarn.CMD
    npm: 7.0.15 - C:\Program Files\nodejs\npm.CMD
  Utilities:
    Git: 2.29.2. - C:\Program Files\Git\cmd\git.EXE
  Browsers:
    Chrome: Not Found
    Edge: Spartan (44.19041.1023.0), Chromium (92.0.902.62)
  npmPackages:
    @vuepress/bundler-vite: Not Found
    @vuepress/bundler-webpack:  2.0.0-beta.22
    @vuepress/cli:  2.0.0-beta.22
    @vuepress/client:  2.0.0-beta.21
    @vuepress/core:  2.0.0-beta.22
    @vuepress/markdown:  2.0.0-beta.22
    @vuepress/plugin-active-header-links:  2.0.0-beta.22
    @vuepress/plugin-back-to-top:  2.0.0-beta.22
    @vuepress/plugin-container:  2.0.0-beta.22
    @vuepress/plugin-debug: Not Found
    @vuepress/plugin-docsearch: Not Found
    @vuepress/plugin-git:  2.0.0-beta.22
    @vuepress/plugin-google-analytics: Not Found
    @vuepress/plugin-medium-zoom:  2.0.0-beta.22
    @vuepress/plugin-nprogress:  2.0.0-beta.22
    @vuepress/plugin-palette:  2.0.0-beta.22
    @vuepress/plugin-prismjs:  2.0.0-beta.22
    @vuepress/plugin-pwa: Not Found
    @vuepress/plugin-pwa-popup: Not Found
    @vuepress/plugin-register-components: Not Found
    @vuepress/plugin-search: Not Found
    @vuepress/plugin-shiki: Not Found
    @vuepress/plugin-theme-data:  2.0.0-beta.22
    @vuepress/plugin-toc: Not Found
    @vuepress/shared:  2.0.0-beta.21
    @vuepress/theme-default:  2.0.0-beta.22
    @vuepress/utils:  2.0.0-beta.21
    vue:  3.1.5
    vue-loader:  16.3.3
    vue-router:  4.0.10
    vuepress: ^2.0.0-beta.22 => 2.0.0-beta.22
    vuepress-vite: Not Found

It's handled by the default slugify function:
https://github.com/vuepress/vuepress-next/blob/49c5eed250ebb2ec6e62cf26c1c91d368cc67e33/packages/%40vuepress/markdown/src/utils/slugify.ts#L2-L22
https://github.com/vuepress/vuepress-next/blob/49c5eed250ebb2ec6e62cf26c1c91d368cc67e33/docs/guide/migration.md#L47-L51

I changed  .normalize('NFKD') to  .normalize('NFC'). Everything seems to work fine now.


Change Docker-Compose PostGres Volume

See https://github.com/cisagov/crossfeed/issues/1727

I've tweaked the docker-compose file so that it works for development but this needs fixed in production.


auto exposure unreliable

Think this is a regression related to adding gain. Auto-exposure required some really careful coordination to not thrash exposure but I don't think that same care was given when gain was added

Looks like a combination of several issues. Think should be fixed

One of the fixes was incorrect. Needs revisiting

I've rewritten ImagerControlScroll to hopefully more permanently solve this. The implementation has been simplified by changing the API


aio app run --local should be more verbose by default

On success, aio app run --local output currently is:
   create .vscode/launch.json

No change to package.json was detected. No package manager install will be executed.
press CTRL+C to terminate dev environment

This is far too few information for end-users, especially when running headless apps locally.
The aio app run --local --verbose should be fully output to the user terminal for better guidance and UX.
Workaround: run aio app run --local --verbose

Agreed. The verbose output could be the default. At least the information that the Docker image is being downloaded and OpenWhisk is started as well as the URL of the testing endpoint has to be output by default.
In case of UI actions the testing URL (port 9080) are printed by default, for headless actions (enpoint on port 3233) no output of the URL is created, so the user can't know where to test the local app. This should be consistent for all actions.
Moreover the documentation (https://www.adobe.io/project-firefly/docs/getting_started/first_app/#61-running-the-application) should state with which action you can expect which testing endpoint.

To get the actions URL while running locally, now you can use: aio app get-url --local.
Available once the PR gets merged.


Drop zones do not always appear.

ℹ Computer information

PowerToys version: v0.33.1
PowerToy Utility: Fancy Zones
Running PowerToys as Admin: Yes
Windows build number: 20H2 19042.867

📝 Provide detailed reproduction steps (if any)

Klick & Drag Window
Press Shift-Key

✔ Expected result
Drop zones should appear.
❌ Actual result
Drop zones do not appear.
Workaround:
Press Shift-Key first and then Click & Drag to activate drop zones.

@zech
the bug report is too vague, can you elaborate on the repro steps?

Okay ... I did not think that it is that complex to reproduce. Well...
Click the title bar of any window of your choice first and drag that window. Then, while dragging, hold the Shift-Key because my intent is to trigger the fancy zones to drop my window in any area. The fancy zones do not appear on my machine.
Doing it the other way around however the fancy zones appear:
Hold the Shift-Key first and then click the title bar of any window and drag it. In this order you'll see the fancy zones and you can drop your window into one of them.
I don't know if it is a setting or a bug. But I expected it to work in both sequences.

@zech
is this happening for all windows? For example if you test it with Notepad does it happen?

I've got this effect with all windows. Notepad/Chrome/Edge/VSCode anything. However if my machine was in standby and I wake it up it sometimes works as expected.
It does almost never work as expected after a cold boot in the morning.

@zech
it's a very unusual bug. We are improving the FZ logging to investigate issues like this one, we will get back to you after 0.35 is released.
Thanks.

Hi, is there a way by now to debug this issue? Currently I'm on v0.37
It's still bugging me every now and then. Unfortunately I cannot pinpoint the exact issue thats causing this behaviour.

@zech
are you running PowerToys as administrator?
When the problem happens, are you dragging an elevated app or a particular app such as a virtual machine?

are you running PowerToys as administrator?

Yes it runs as administrator.

When the problem happens, are you dragging an elevated app or a particular app such as a virtual machine?

Those are mostly non elevated programs like Chrome, VSCode or MS Terminal. However, I cannot exclude that sometimes programs with elevated privileges are among them.
I've tested it right now and it works as expected. But the day I wrote my last comment it did not work. So I asked if there's a way to debug it by now. So I can pull the log file the moment it appears again.
I still can not determine the steps to reproduction.

I feel like I can consistently repro this with an elevated Windows Terminal, and ONLY ELEVATED Windows Terminal. I can snap with Teams, Edge, notepad, even non-elevated Windows Terminal running at the same time, but an elevated Windows Terminal doesn't work consistently.
Repro steps:

Run power toys NOT as admin.
Run Windows Terminal AS ADMIN
Try to snap the elevated WT

Here's a GIF of me repro-ing the issue. What I do is I start PowerToys, then start normal Windows Terminal. Snaps correctly. Then I start elevated Windows Terminal, doesn't snap. Next, I restart PowerToys, but elevated. The elevated Windows Terminal can now be snapped.

I'm also MSFT internal, feel free to reach out internally if there are more questions, I can consistently repro.

@QueenCitySmitty
that is the expected behavior, you need to run PowerToys elevated in order to be able to zone an elevated window.

Perfect, didn't know that. For clarity, just looked up the docs and that's mentioned here.

Thanks for replying. But this is not quite my issue.
PowerToys is running as aministrator. And for me it's the order of pressing shift and clicking the title bar. I'll quote myself here:

Click the title bar of any window of your choice first and drag that window. Then, while dragging, hold the Shift-Key because my intent is to trigger the fancy zones to drop my window in any area. The fancy zones do not appear on my machine.

Doing it the other way around however the fancy zones appear:

Hold the Shift-Key first and then click the title bar of any window and drag it. In this order you'll see the fancy zones and you can drop your window into one of them.

I also have similar issue, fancy zones wont appear unless I use the shift key before or after dragging.
running v0.37.0 both in admin
Windows 19041.928

I wasn't able to reproduce the issue with any order of the keys pressed. @zech @benmjacobs, could you be more specific with what app you're experiencing the problem?

Hi, thanks for replying.

any app (as described before)
it does not matter if the app is in admin or user scope
power toys is running as administrator
unfortunately not consistently reproducible

That's why I asked for a way to log things until it strikes again. I've tried to find a way to find out which key bindings are globally defined in the current session but had no success so far.
Sometimes I suspect another app blocking this shortcut but unfortunately I have not yet been able to see any connections between this behavior and any running apps.

This issue has been open for a while and there have been lots of improvements since then! I'm on 0.47.0 and I can't reproduce this issue, could you please update to the latest and see if this issue still repros? Thanks!

Hi,
sorry for the delayed response. I did not notice it in the latest time, maybe I've just got used to it 😏.
Currently I'm on v0.47 and did several Windows 10 Updates in between.

Is this still an issue in v0.51?

It doesn’t appear to be an issue any longer.
On Tue, Nov 30, 2021 at 9:24 PM Franky Chen @.***>
wrote:

Is this still an issue in v0.51?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/PowerToys/issues/10236#issuecomment-983223047,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMCJLZ3EQNM7TERVCXUOKG3UOWBM7ANCNFSM4ZGBKWWA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--
Ben Jacobs
cell:<PHONE_NUMBER>


Support audio and video in Mallard output

Looks good to me.  Any thoughts, @mojavelinux?

Also, tests for this would be super awesome if possible.


Naming conventions: compilation of to-dos

Add naming convention items here that still need to be addressed

Christina has created a spreadsheet to compile these in here: https://docs.google.com/spreadsheets/d/1tHKFBax2FOTv0G8ouuvkCNvLVR_ma2awvZ2wu0xA5kI/edit#gid=0


[OPENJDK-1065] Add PNC Metadata to artifacts

This causes OSBS-builds of these containers to consume the artifacts from an internal PNC instance.
The 'md5' key is not valid when the pnc keys are present. Remove it, but add two tests that check the md5 checksum of the JARs inside an image.
https://issues.redhat.com/browse/OPENJDK-1065

Review tip:
check internal Brew for taskinfo?taskID=48451353. That was built from an in-development tree where the jolokia portion of this was done but the prometheus was not. Notice "user_warnings = No source-url found for…"
taskinfo?taskID=48452279 was built after the prometheus changes in this PR. Notice no warnings in the Result section.

This breaks GitHub Actions, because the currently configured cekit version for those is 3.11.0, and PNC support was added in 3.12.0. However, we have no GitHub CI coverage for the RHEL7-based images anyway. I coudl push a commit that bumps the cekit version so the lights go green, but we should consider the more drastic removal of GitHub CI for the rhel7 branch.

Please push to newer cekit in GHA. It's a CI only change and should do no harm, right?. I think the latest version these days is cekit 4.x anyway.

Done (let's see what GHA makes of it). If it works commit is suitable for cherry-picking over to the other branches, and I'll do that.


Update language specific colors to match official theme

I started to research the possibility of using a python script to convert the official syntax colors to JetBrains. I realized that building such a tool beyond a single editor would be very complicated and difficult to maintain. Instead, I think it would be better to replicate the colors manually.
To make this happen, I need to compare the official VSCode/Sublime colors with JetBrains one language at a time. This will introduce breaking changes, so updates will occur in a separate branch until they can be fully tested (see https://github.com/subtheme-pro/monokai-pro/issues/16).

I would like to help to update the JavaScript/TypeScript colors. However, I don't know what keys to use in the XML to represent the elements of JS/TS code I want to fine tune (like it's done for java, see attached img).
Where can I get these keys names? I would like to be pointed to a site or resource I can use for that, or learn how.


Impossible to expand a list of matches into the argument of a function (trailing comma)

In a macro expansion such as
function (·vars ··· { ·var , }) { return ·expr; }

It is impossible to specify the correct amount of commas (to my knowledge of YAY functionality) - the last match will always add a trailing comma which is invalid syntax.
On function calls this can be alleviated by using array destructuring ...[var, var, var, ] but function definitions do not have this workaround.

This one is listed on the roadmap issue #3. Basically we need an expander called ·ls(·vars, ',', YAY_NO_TRAILING) that would allow you to decide if a trailing separator (in your case a comma) should be added or not.
Or maybe we need syntax support on the current unpacking syntax to indicate how to make delimiters behave.

Expanders are declared here, btw https://github.com/marcioAlmada/yay/blob/master/src/expanders.php.
They are just functions that receive a TokenStream and return another TokenStream.

@marcioAlmada What do you think about an IRC channel on freenode? Would you mind if I implemented some of the easy picks?

I'm currently in transit :airplane: so there won't be time to create a real time support channel withing the next 3 days. But feel free to get some easy picks. I'll try to reply ASAP.

Ah okay. Safe travels!

·implode(·vars, ',') is probably more self explanatory.

Turns out adding first class trailing token control to the already existing unpacking syntax ··· look way more expressive. See the tests at  	e79505a.


Changes to parser to pass all fixture/good tests

There are a lot of changes to the parsing and I admit some of them are not ideal, but they have precedent in the data. I am kind of stumped that Gherkin does not have some kind of official regex and even the specification itself does not clearly state all things that should be parsed but I know I'm barking at the wrong tree here.
This includes changes in #31.
To pick a few of the worst things, as per gherkin documentation about Description: You can write anything you like, as long as no line starts with a keyword. which however breaks current smoke2 test which starts feature description lines with * and but. A case could be made that each description (and there can be descriptions for Feature, Example/Scenario, Background, Scenario Outline and Rule) could be made context-aware in the sense that only the subset of keywords that may follow the given described keyword would be considered as ending the description.
Another sub-par thing is that an empty file (or a file with just comments) is considered valid feature file, for which I had to return default feature, i.e. no rules, no steps, empty name. Returning Option<Feature> would be probably better, but it would require non-trivial changes as well as changes to downstream services (i.e. cucumber).
Also steps may now start with a keyword without a space, e.g. Butterscotch would now be a valid step parsed as But: terscotch. This is because of a fixture with the emoji language. It turns out people using emojis seem to not use spaces and I didn't feel like introducing logic to require spaces only for this language.
I kind of like the experience with peg I'm getting so I would love to help some more (maybe getting rust cucumber to be semi-official implementation) so if there's anything I would love to know.

@mladedav

I am kind of stumped that Gherkin does not have some kind of official regex and even the specification itself does not clearly state all things that should be parsed but I know I'm barking at the wrong tree here.

Yeah, thats really unfortunate, we suffer from this all the time 😔

as per gherkin documentation about Description: You can write anything you like, as long as no line starts with a keyword.

To be fair I don't really trust Gherkin reference on cucumber.io as it's pretty outdated and skips some caveats for simplicity. Thats ok for general user, but doesn't work for implementors.

A case could be made that each description (and there can be descriptions for Feature, Example/Scenario, Background, Scenario Outline and Rule) could be made context-aware in the sense that only the subset of keywords that may follow the given described keyword would be considered as ending the description.

I like that way more. So instead of using general purpose description() parsing rule for all descriptions, we should make special parsing rule for each one.

Another sub-par thing is that an empty file (or a file with just comments) is considered valid feature file, for which I had to return default feature, i.e. no rules, no steps, empty name. Returning Option would be probably better, but it would require non-trivial changes as well as changes to downstream services (i.e. cucumber).

👍

Also steps may now start with a keyword without a space, e.g. Butterscotch would now be a valid step parsed as But: terscotch. This is because of a fixture with the emoji language. It turns out people using emojis seem to not use spaces and I didn't feel like introducing logic to require spaces only for this language.

Actually, I don't think you are right. The way this is handled is that space is a part of keyword. Emoji language definition clearly shows that *  has a trailing space and 🙏 doesn't

Actually, I don't think you are right. The way this is handled is that space is a part of keyword. Emoji language definition clearly shows that *  has a trailing space and 🙏 doesn't

You're right, the issue why this did not work is that this repo has possibly outdated languages.json without the spaces. With them this works properly.

I added the description excludes per keyword. Maybe some could be contracted (e.g. scenario and scenario outline) into a single function, but I decided to play it safely. I also added just the ones that seemed logical (e.g. scenario has to have steps---the data seem like that's true but I would not be surprised if it wasn't).
I had some troubles with the borrow checker (as I do in virtually every pull request I open) and I ended up cloning the keywords iterable in the keyword rule because of lifetimes. If there is another way to do this that would be great. The only thing that came to mind was creating arrays of keywords to be skipped through build.rs same as the Keyword structures are made, but that felt too cumbersome.
I also noticed that this should fix #10.

ping @mladedav
Are you going to continue work on this, or we should pick it up?

Sorry I didn't get back to you on this sooner.
I plan to finish this, I hope to get some work here done during the week.

Sorry it took longer than I had hoped, but I am fairly happy with the extent that the AST is checked against the fixtures. It uncovered a few bugs concerning which keywords can be used in a description so I guess it was worthwhile.
The AST parsing checks just backgrounds, scenarios, and rules. There are no checks for stuff like tags.

@mladedav so this PR is ready for review?

@mladedav released in 0.12.0.

@mladedav released in cucumber 0.13.0.


Moved sitl targets to cmake to easily support more board configs.

Also adds  make px4fmu-v2_default config     etc... This allows you to pull up the cmake gui configuration tool easily.

Example of new usage:
make posix_sitl_default run_sitl_quad

Example debugger usage:
Command line:
DEBUGGER=gdb make posix_sitl_default
make posix_sitl_default run_sitl_quad

Cmake GUI:
make posix_sitl_default
make posix_sitl_default config (--> select your debugger from DEBUGGER drop down list)
make posix_sitl_default run_sitl_quad

@mcharleb, @tumbili, @LorenzMeier Any input on this PR?

I'm slightly confused by the instructions? How do I run a pure simulation run? I'm not sure if you're trying to show that I can run multiple make targets or are the multi-line things needed to run debug?

@LorenzMeier  The multi-line is just for debug. To run a pure simulation including building it, just type:
make posix_sitl_default run_sitl_quad

This sticks to the existing structure for the makefile controlling cmake of:
make BOARD_NAME TARGET

Now in master.


MudDrawer doesn't respect the custom breakpoint because of new ResizeOptions

Things to check

[X] I have searched the existing issues for this bug
[X] To rule out a caching problem I made sure the bug also happens in an incognito tab

Bug type
Component
Component name
MudDrawer
What happened?
MudDrawer create a new instance of ResizeOptions
ResizeOptions IBrowserViewportObserver.ResizeOptions { get; } = new()
        {
            ReportRate = 50,
            NotifyOnBreakpointOnly = false
        };

see https://github.com/MudBlazor/MudBlazor/blob/v7.6.0/src/MudBlazor/Components/Drawer/MudDrawer.razor.cs at line 453
but this create a new instance of BreakpointDefinitions because is contained inside of ResizeOptions  class and this create an issue not respecting the custom breakpoint that i made in Program.cs with the lines:
config.ResizeOptions = new ResizeOptions()
{
    BreakpointDefinitions = new Dictionary<Breakpoint, int>
    {
        { Breakpoint.Xs, 0 },
        { Breakpoint.Sm, 576 },
        { Breakpoint.Md, 768 },
        { Breakpoint.Lg, 992 },
        { Breakpoint.Xl, 1200 },
        { Breakpoint.Xxl, 1400 }
     }
};

So, if I set the breakpoint of the MudDrawer to Breakpoint.Xl it breakpoint at 1920px (the default value of Xl ) instead of my custom 1200px
Expected behavior
MudDrawer should not create a new instance of ResizeOptions but retrieve the custom ResizeOptions passed in configuration changing only the vaues ReportRate = 50 and NotifyOnBreakpointOnly = false or at least setting the BreakpointDefinitions using BreakpointGlobalOptions.GetDefaultOrUserDefinedBreakpointDefinition
Reproduction link
https://github.com/MudBlazor/MudBlazor/blob/v7.6.0/src/MudBlazor/Components/Drawer/MudDrawer.razor.cs
Reproduction steps

Customize the breakpointdefinition in Program.cs for example

config.ResizeOptions = new ResizeOptions()
{
    BreakpointDefinitions = new Dictionary<Breakpoint, int>
    {
        { Breakpoint.Xs, 0 },
        { Breakpoint.Sm, 576 },
        { Breakpoint.Md, 768 },
        { Breakpoint.Lg, 992 },
        { Breakpoint.Xl, 1200 },
        { Breakpoint.Xxl, 1400 }
     }
};

Set the MudDrawer Breakpoint on Xl
See that it breaks at 1920 (default for Xl ) instead of the customized 1200

Relevant log output
No response
Version (bug)
7.6.0
Version (working)
No response
What browsers are you seeing the problem on?
Chrome
On which operating systems are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Thanks, will be fixed in next release.


MB-5421 Remove unused swagger definitions

Description
Removed unused swagger definitions in a few of the yml files. Also updated a test to use model constants instead of generated enum constants from a swagger definition.
Setup
Add any steps or code to run in this section to help others prepare to run your code:
make server_test

Code Review Verification Steps

[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story

Messages

:book:
:link: MB-5421

  Generated by :no_entry_sign: dangerJS against e3ae914e2e32895a93cab06b5b7d8a385eeb99f8


Tip labels of time-scaled tree are cut off by adjacent SVG

Proposed solutions

draw vertical line as visual cue of cutoff
truncate labels with "..."
relocate labels to start of branch
implement pop-out button to allow user to expand tree plot to larger portion of window
allow horizontal scroll of SVG within div

Enable user to drag the border separating the tree plot from the beadplot to expose more of the tip labels.
(beadplot becomes relative width?)

This will not be an issue when we substitute lineages for clusters, see #110


Couldn't install pyats[full] 23.6/23.5 with poetry

Use poetry to install pyats[full] will fail because of package dependencies. This happen when I try to install 23.5 version and latest 23.6.
error message is :
Invalid requirement (backports.ssl (>=0.0.9backports.ssl-match-hostname>=<IP_ADDRESS>)) found in ixnetwork-9.0.1915.16 dependencies, skipping
I cannot control backports.ssl and  backports.ssl-match-hostname version.

This error cause by pyats-datastructures (23.6)
$poetry show pyats-datastructures
 name         : pyats-datastructures
 version      : 23.6
 description  : pyATS Datastructures: Extended Datastructures for Grownups

required by
 - pyats >=23.6.0,<23.7.0
 - pyats-aetest >=23.6.0,<23.7.0
 - pyats-connections >=23.6.0,<23.7.0
 - pyats-easypy >=23.6.0,<23.7.0
 - pyats-kleenex >=23.6.0,<23.7.0
 - pyats-log >=23.6.0,<23.7.0
 - pyats-tcl >=23.6.0,<23.7.0
 - pyats-topology >=23.6.0,<23.7.0
 - pyats-utils >=23.6.0,<23.7.0

This error relate to ixnetwork package
Source (PyPI): 5 packages found for ixnetwork *
Invalid requirement (backports.ssl (>=0.0.9backports.ssl-match-hostname>=<IP_ADDRESS>)) found in ixnetwork-9.0.1915.16 dependencies, skipping
   1: fact: ixnetwork (9.0.1915.16) depends on pyopenssl (>=17.5.0)
   1: fact: ixnetwork (9.0.1915.16) depends on requests (>=2.18.4)
   1: fact: ixnetwork (9.0.1915.16) depends on websocket-client (>=0.47.0)
   1: selecting ixnetwork (9.0.1915.16)
   1: derived: websocket-client (>=0.47.0)
   1: derived: pyopenssl (>=17.5.0)

I've created a new repo then first install pyats[full] and it works...
The package pyats-datastructures is successful installed but the error message is still there.
Invalid requirement (backports.ssl (>=0.0.9backports.ssl-match-hostname>=<IP_ADDRESS>)) found in ixnetwork-9.0.1915.16 dependencies, skipping

I don't know what wrong...

Hi seisokeii,
After installing the pyats using /auto/pyats/bin/pyats install  this command, can you try to upgrade using pip install --upgrade "ats[full]" . It will help to resolve your issue..

Sorry, I forget to say that I use poetry to install pyATS.
pyATS is work fine now, but there's a dependency warning when execute python script.
NotOpenSSLWarning: urllib3 v2.0 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with 'LibreSSL 2.8.3'
I think this is not a critical problem.
Thank for your help~

This issue does not appear on virtual environments based on python binaries built with openssl. If you want to avoid this error make sure your python binary is built with openssl, or downgrade urllib to a version that supports libressl

This issue is solved.  I appreciate your help~


forks should not run publishing actions

Pushing to my own fork of and adobe repo modifies package.json, which in turn triggers the publish action.  I of course do not have the npm credentials in my repo's secrets, so the publish fails, but it would be better if it did not run at all.
This will require some research into how repo-forks might be created without also forking the workflows, or having the workflows somehow aware that they are fork .. or check for existence of required secrets before running install/test actions which are resource hogs.

I did something in this workflow where I checked for forks: https://github.com/adobe/aio-cli-plugin-doc/blob/33ffb99e36e0c2b067830f8e72adbdfb6252714f/src/generator/templates/.github/workflows/pr-approved.yml#L17-L34

I did something in this workflow where I checked for forks: https://github.com/adobe/aio-cli-plugin-doc/blob/33ffb99e36e0c2b067830f8e72adbdfb6252714f/src/generator/templates/.github/workflows/pr-approved.yml#L17-L34


MSSQL data integration source - add support for DATETIMEOFFSET type

Description
Implemented the code from here pyodbc wiki:
https://github.com/mkleehammer/pyodbc/wiki/Using-an-Output-Converter-function
Note: Similar patch is probably needed in mage_ai/io/mssql.py. I had not run into that yet, and had no time to fix that right now. Likely I will run into it soon, though.
How Has This Been Tested?
Tested in local pipeline w/ mssql source.
Against:

local postrgesql - ended up as timestamp_tz
local mssql, ended up as text , this could be fixed by adding support for timestamp_tz in MSSQL as DATETIMEOFFSET

Checklist

[ ] The PR is tagged with proper labels (bug, enhancement, feature, documentation)
[X] I have performed a self-review of my own code
[ ] I have added unit tests that prove my fix is effective or that my feature works
[X] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] If new documentation has been added, relative paths have been added to the appropriate section of docs/mint.json

cc:
@wangxiaoyou1993

I will create another PR, sorry. I forgot to create a dedicated branch in my repo and now commits could creep into this one. :S


PIXI v4.1 is undefined webpack

Since recently PIXI the import of PIXI is undefined  (using webpack but I guess it is the same with browserify)
PIXI v4.1.1
import PIXI from 'pixi.js' // returns undefined

PIXI v4.0.3
import PIXI from 'pixi.js' // returns PIXI Object

Correct me if I'm wrong but I also noticed that the path is wrong in package.json it should not be the builded project but the main source file isn't it ?

anwsered in comments of https://github.com/pixijs/pixi.js/issues/3224

Also this: https://github.com/pixijs/pixi.js/issues/3204#issuecomment-256751902


merge sql before release version

Current Behavior
current sql/schema have some breaking change with truncate table
Proposed Behavior
follow the rule: try keep the original data and update it
Solution Proposal
merge sql/schema before release version, and wo need follow the rules later

https://github.com/star-whale/starwhale/pull/592


chore: remove host root mount from csi-node daemonset

Host root mount was required to support iscsi protocol. Now since we have removed the support for iscsi protocol, we can avoid mounting the host root filesystem.
Signed-off-by: Payes Anand<EMAIL_ADDRESS>

bors try

bors try

bors merge


Is it possible to allow to visit a value referencing data owned by the current function?

AFAIK, in the current API, Valuable cannot be implemented well if I need a temporarily owned value for serialization.
struct PathAsString(std::path::PathBuf);

impl Valuable for PathAsString {
    fn as_value(&self) -> Value<'_> {
        /*
        error[E0515]: cannot return value referencing temporary value
          --> lib.rs:74:9
           |
        74 |         Value::String(&self.0.display().to_string())
           |         ^^^^^^^^^^^^^^^----------------------------^
           |         |              |
           |         |              temporary value created here
           |         returns a value referencing data owned by the current function

        error: aborting due to previous error
        */
        Value::String(&self.0.display().to_string())
    }

    fn visit(&self, v: &mut dyn Visit) {
        v.visit_value(Value::String(&self.0.display().to_string()))
    }
}

Is there a way to handle such cases well?
(I was thinking a bit about removing the Valuable::as_value, but not sure if that would be a good idea.)

Another case of this problem is when I want to pass Value::Error to visitors. This can be avoided by making the error static (like the following example), but the problem remains that the error message cannot contain the details.
struct PathAsStr(std::path::PathBuf);

impl Valuable for PathAsStr {
    fn as_value(&self) -> Value<'_> {
        #[derive(Debug)]
        struct Error;
        static ERROR: Error = Error;
        const MSG: &str = "path is not valid UTF-8 string";
        impl std::fmt::Display for Error {
            fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
                std::fmt::Display::fmt(&MSG, f)
            }
        }
        impl std::error::Error for Error {}

        match self.0.to_str() {
            Some(s) => Value::String(s),
            None => Value::Error(&ERROR),
        }
    }

    fn visit(&self, visit: &mut dyn Visit) {
        visit.visit_value(self.as_value());
    }
}

Well, the intent is that we avoid work in the as_value() fn, so a conversion to string should be avoided. For both cases, we could possibly add a Display variant:
Value::Display(&dyn Display)

In the second case, the error is then received when visiting and the visitor can handle it as it wishes.

Ref: #4
We also may want to add a Debug(&dyn Debug) fallback option?

so a conversion to string should be avoided. For both cases, we could possibly add a Display variant:

Hmm. The creation of String is a red herring. The struct returned by Path::display() is also owned by the function, so the addition of Value::Display does not solve the problem.
That said, I think that Value::Display might be useful regardless of this problem.

When I ran into this case in the past I ended up with an API like this: https://docs.rs/value-bag/1.0.0-alpha.7/value_bag/fill/index.html
The variant on Value is effectively a &'a dyn Fn(Visit), so your value itself satisfies the 'a lifetime, but the data you pass to the visitor can be short-lived.

@taiki-e Ah right, my mistake.
The strategy we use is similar to what @KodrAus is describing, but we use *able traits instead of fns. So, here, hypothetically, we would have trait Displayable and that would call a Visit::visit_display(display: &dyn Display) or something.

When working with valuable in handlebars, I may have a case for this issue as well.
During a template rendering process, some intermediate values are computed and are owned by internal context. If I will use valuable::Value as my internal type system, it needs capability to hold data like CoW.
Not quite sure if this matches original rational of valuable. But it seems to be required to use in handlebars.

triage: A variant of Value to handle this (Value::Displayable?) can be added later without API break, so there is no need to consider this as a blocker of 0.1.0.


Not hint about newer version when toolkit default is used

Version(s)
1.1.2
Describe the bug
[hint] ./examples/SimpleTest.test.scala:1:19
[hint] "toolkit is outdated, update to 0.2.2"
[hint]      toolkit 0.2.1 -> 0.2.2
[hint] //> using toolkit default
[hint]

The log above appears.
To Reproduce
Release locally toolkit 0.2.2 and run a script with
//> using toolkit default

Expected behaviour
No warning

...why shouldn't we have a hint about it, though? 🤔
default may point to an outdated version and the warning should point out to the user that a newer version is available, no?

We should probably improve the warning to say more about default, so that it's not confusing to the user.

I think that we have two user paths for using the toolkit:

Short snippets (toolkit default)
Specifying version directly
There is no way to apply a change to the version in the first path, if there is no scala-cli released with a newer toolkit. So I think the warning could appear only if there is a new scala-cli with newer toolkit, a it could be a bit different (there is a newer toolkit default available in newer scala-cli, please update it0


feat(config): Change manufacturer for nzw31s and nzw30s

Changing manufacturer from "NIE Technology Co., Ltd." to "Inovelli".
Edit: Fixing some discrepancies between the labels and descriptions for the NZW30, NZW30S, NZW31 and NZW31S files too.

Not sure what to do with the param 3 ("LED Indicator") or where to find the proper info. The NZW30 have 3 options and NZW30S only 2 options, The NZW31 and NZW31S don't have it at all but I remember being able to change it in OZW.

Before I merge - is this ready? :D

Yes I'm done. Thank you.

No, thank you!


quinn-proto: document when a stream has been destroyed

From the quinn-proto documentation, it is not clear when further Events are guaranteed not to mention a particular StreamId unless the StreamId has been subsequently opened again.  This is crucial for my code, which will panic if an event is received for an unknown StreamId.
Is there a way to immediately destroy a stream?  I don’t care if the stream is immediately destroyed at the protocol level, but I do need to know when I can release all associated state.

Thanks for the issue! We should definitely be clearer about this. The general rule of thumb is that quinn-proto discards state for a stream only after the stream is dead for state machine purposes and the caller has consumed a notification of this, but we should be able to pin this down more concretely.

Note that stream IDs are never reused, incidentally.

Can I assume that:

Once finish has succeeded, a stream will not report itself as open for writing?
Once stop_sending has succeeded, a stream will not report itself as open for reading?

Once finish has succeeded, a stream will not report itself as open for writing?

On inspection, I don't think this is the current behavior, but we can easily provide it. #545 should correct that, and I'm happy to consider failure to do so a bug. The same guarantee should be provided for reset.

Once stop_sending has succeeded, a stream will not report itself as open for reading?

stop_sending is purely advisory to the peer; it does not influence the local endpoint behavior at all. A well-behaved peer should usually reset the stream immediately upon receiving the message, but even then data that's already in-flight may still be delivered. Hence you should either tolerate readable events for forgotten streams, or retain state until reading produces an Ok(None) or Err(ReadError::Reset { .. }).

@DemiMarie-parity, does #545 clarify things sufficiently?

@Ralith yes, it does.


Certain transparent backgrounds render as blue since SDL_image 2.8.3 on Mac OS X

I'm sorry for this being rather vague because I'm not sure of the actual cause.
I've installed SDL_image 2.8.3 using Homebrew on my MacOS X 12.7.6 machine and I'm linking SuperTux against it.
Certain previously transparent images now render with a blue background:
https://github.com/user-attachments/assets/2c76cf8a-f16a-4a1a-8e57-1f7809bd666a
I then disabled the homebrew formula and compiled 2.8.2 manually and the issue is gone:
https://github.com/user-attachments/assets/32876aa7-2afc-4f9c-9be7-6c1b9c91c1f3
If there's anything more you need, just tell me.

Do you get the issue if you build 2.8.3 manually? If not, what are the configure options being used by the homebrew formula?

Do you get the issue if you build 2.8.3 manually? If not, what are the configure options being used by the homebrew formula?

Apparently, linking against a self-built 2.8.3 worked just fine. Here are the homebrew configure flags: https://github.com/Homebrew/homebrew-core/blob/dba938d9df5b2e1fe399ef345d64cfa3df0c1f79/Formula/s/sdl2_image.rb#L43C1-L50C51

The snow particles in question should be https://raw.githubusercontent.com/SuperTux/supertux/refs/heads/master/data/images/particles/snow0.png https://raw.githubusercontent.com/SuperTux/supertux/refs/heads/master/data/images/particles/snow1.png and https://raw.githubusercontent.com/SuperTux/supertux/refs/heads/master/data/images/particles/snow2.png

Can you reproduce it if you build with the same configure options that homebrew uses, and then run showimage on that image?

Reproduces on linux with --disable-stb-image, thus using libpng, in both release-2.8.x and SDL2 branches. Should possibly reproduce in SDL3 (main) branch too.
Commit https://github.com/libsdl-org/SDL_image/commit/0000fb07f267eb53023b9e648f6d126025708ada (which was cherry-picked to release-2.8.x too) seems to be the culprit.

Can confirm that by adding the flags from the homebrew formula, the bug re-appears.

Fixed! Thanks for the help tracking this down.


[date-picker] add prop open to toggle the dialog

linked to the PR #424

I'm using the flex architecture and I have an URL fragment that determine if the dialog is shown or not.
With this solution, I just have to pass a boolean to show or hide the dialog

Ok, I close this PR,  I will use show() and dismiss().


The cookbook has an issues_url in its metadata.

:+1:

I'd like the + to be higher here, but this is a huge one to check for :+1:

@tas50 @johnbellone how much higher to you think the + should be?  maybe 5 points?

Five points is better than one, but what's the yard stick that we should be using?

:+1: We can worry about the point scale later.


Feat/add hyper pane

navigate through panes with arrows — plugin we all wanted
https://www.npmjs.com/package/hyper-pane
/cc @chabou

Nothing to do with the PR, but we get 429 HTTP errors on the CI tests now ("too many requests").
Is there a way to throttle these requests?

@iamstarkov ❤  you made my day
I would suggest to not mention shortcut because it will be configurable very soon.
Something like: "Navigate through panes with arrows or jump directly to a specific pane with digit" or something like that.
(No need to mention "switch" functionality)

@chabou fixed description here and i think you would need to update yours github/npm/readme descriptions as well =)

@darahak

Is there a way to throttle these requests?

i dont know, why do we need to use API for linting README files

It looks for dead links, so I guess it's useful but it generates a lot of false positives :man_shrugging:
Probably something to be discussed on #180


ERROR: Failed to retrieve the next key.

I had the 6.1Gb file and tried to shrink it with this tools.
I was able to process 1250 records and failed with:

modsec-sdbm-util.c:332:dump_database(): Failed to retrieve the next key.

I then move the 6.1Gb file and let mod_sec recreate the file. But I still get the same error when running either -x or -k, on the newly created file.
I tried this on the lastest master branch.

Interesting, I've had some large modsec db files before but haven't run into this before unless the db files are corrupted. Are you able to perform a dump of the database or does it result in the same error?

@nitriques this is an exception or that is happening consistently with different databases?

@bostrt Can you tell me how can I perform other operation on the database ?
@zimmerle consistenly, even with fresh/new databases that are a couple of minutes old.
I had a 6.1Gb file this morning also. so it grows at 1.2Gb per day right now.
I do run OWASP ruleset BTW.

@nitriques I recommend creating a copy of the db that you can reproduce issues with. Try running the shrink operation (-k) or extract (-D). Basically, anything else besides dumping; just curious if the issue is isolated to dump.

I tried this on the lastest master branch.

Did you test with latest ModSecurity master branch?

@bostrt Thanks for the help
I just copied the existing ip.pag file. Then:
# /root/modsec-sdbm-util/modsec-sdbm-util -k ip.pag.bak
Checking target directory: /tmp
Target directory exists.
Opening file: ip.pag.bak
Failed to open sdbm: ip.pag.bak

# /root/modsec-sdbm-util/modsec-sdbm-util -D ip.pag.bak

-D yeilds no output.

Did you test with latest ModSecurity master branch?

No, I can't. I have
Server version: Apache/2.2.34 (Unix)
Server built:   Aug 28 2017 14:35:15
Cpanel::Easy::Apache v3.34.16 rev9999

And from what I can tell from this page it is running 2.9

@nitriques I think you are running into an issue with how modsec-sdbm-util picks up files by name:

Failed to open sdbm: ip.pag.bak
Try dropping the .bak extension like this:

# mkdir /tmp/sdbm
# cp ip.pag.bak /tmp/sdbm/ip.pag
# cp ip.dir /tmp/sdbm/ip.dir

Note that I copied in the ip.dir file too. The database is split into two the .pag and .dir so both are required to get some output.
Basically, I'm curious if you can shrink (-k) or extract (-n) the database and then run the dump operation.
Testing with the latest ModSecurity would probably be best next step, but sounds like that might not be an option. FYI, latest version is ModSecurity 2.9.2: https://github.com/SpiderLabs/ModSecurity/releases/tag/v2.9.2

FYI, latest version is ModSecurity 2.9.2:

I still can't find how to get the version I am running :(
# /root/modsec-sdbm-util/modsec-sdbm-util -D /tmp/ip.pag

Still nothing
# /root/modsec-sdbm-util/modsec-sdbm-util -k ip.pag
Checking target directory: /tmp
Target directory exists.
Opening file: ip.pag
Database ready to be used.
 [/] 700 records so far.
Total of 700 elements processed.
700 elements removed.
Expired elements: 700, inconsistent items: 0
Fragmentation rate: 100.00% of the database is/was dirty data.

And then,
# /root/modsec-sdbm-util/modsec-sdbm-util -x ip.pag
Checking target directory: /tmp
Target directory exists.
Opening file: ip.pag
Database ready to be used.

Should I run /root/modsec-sdbm-util/modsec-sdbm-util -k ip.pag via cron ?

With -v I still see
modsec-sdbm-util.c:163:modsec_unpack(): Expired:<PHONE_NUMBER>,<PHONE_NUMBER> delta: -380
modsec-sdbm-util.c:332:dump_database(): Failed to retrieve the next key.

I still can't find how to get the version I am running :(

You should see a notice in your main Apache log stating the version. Something like this:
[Fri Oct 20 18:43:49.298214 2017] [:notice] [pid 25472:tid<PHONE_NUMBER>24832] ModSecurity for Apache/2.9.1 (http://www.modsecurity.org/) configured.
[Fri Oct 20 18:43:49.298220 2017] [:notice] [pid 25472:tid<PHONE_NUMBER>24832] ModSecurity: APR compiled version="1.5.2"; loaded version="1.6.2"
[Fri Oct 20 18:43:49.298222 2017] [:warn] [pid 25472:tid<PHONE_NUMBER>24832] ModSecurity: Loaded APR do not match with compiled!
[Fri Oct 20 18:43:49.298242 2017] [:notice] [pid 25472:tid<PHONE_NUMBER>24832] ModSecurity: PCRE compiled version="8.40 "; loaded version="8.41 2017-07-05"

Yours will look a bit different b/c above is from Apache 2.4 and you are using 2.2.
So I'm not sure of why exactly is causing the Failed to retrieve the next key, has got to be some sort of database corruption/badness.
700 elements removed.
Expired elements: 700, inconsistent items: 0
Fragmentation rate: 100.00% of the database is/was dirty data.

This is promising though and potentially a workaround. You can try shrinking the database (-k) or extracting it to a new file (-n) occasionally using a cron job. However, some funny race conditions might come up doing a extract (-n) while Apache is up-and-running trying to access the ModSecurity db. I advise a cron job that stops Apache, extracts, starts Apache back up.

Thanks for your help @bostrt

You should see a notice in your main Apache log stating the version. Something like this:

I did, and could not find anything :(
Thanks for the idea about the cron job.


Sign in problem

Every time i try to sign in web is recoded automatically

If you need invite Code : 5VU285


Where is the roi mask??

Hi,
Now I'm using your tool clinicadl.
I have some problem while training ROI.
I searched many area to find left hippocampus & right hippocampus masks, but can't.
How do I download the ROI masks??
The error messeges are bellow
Thank you for your answer in advance.
Best Regards,
joblib.externals.loky.process_executor._RemoteTraceback:
"""
Traceback (most recent call last):
File "/opt/conda/lib/python3.8/site-packages/joblib/externals/loky/process_executor.py", line 436, in _process_worker
r = call_item()
File "/opt/conda/lib/python3.8/site-packages/joblib/externals/loky/process_executor.py", line 288, in call
return self.fn(*self.args, **self.kwargs)
File "/opt/conda/lib/python3.8/site-packages/joblib/_parallel_backends.py", line 595, in call
return self.func(*args, **kwargs)
File "/opt/conda/lib/python3.8/site-packages/joblib/parallel.py", line 262, in call
return [func(*args, **kwargs)
File "/opt/conda/lib/python3.8/site-packages/joblib/parallel.py", line 262, in
return [func(*args, *kwargs)
File "/opt/conda/lib/python3.8/site-packages/clinicadl/extract/extract.py", line 152, in prepare_roi
check_mask_list(
File "/opt/conda/lib/python3.8/site-packages/clinicadl/extract/extract_utils.py", line 328, in check_mask_list
raise FileNotFoundError(
FileNotFoundError: The ROI 'rightHippocampusBox' does not correspond to a mask in the CAPS directory. The mask should follow the pattern caps_new/masks/tpl-MNI152NLin2009cSym/res-1x1x1_roi-rightHippocampusBox_mask.nii. and contain 'desc-Crop' string.
"""
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/opt/conda/bin/clinicadl", line 8, in
sys.exit(cli())
File "/opt/conda/lib/python3.8/site-packages/click/core.py", line 1130, in call
return self.main(*args, **kwargs)
File "/opt/conda/lib/python3.8/site-packages/click/core.py", line 1055, in main
rv = self.invoke(ctx)
File "/opt/conda/lib/python3.8/site-packages/click/core.py", line 1657, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/opt/conda/lib/python3.8/site-packages/click/core.py", line 1657, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/opt/conda/lib/python3.8/site-packages/click/core.py", line 1404, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/opt/conda/lib/python3.8/site-packages/click/core.py", line 760, in invoke
return __callback(*args, *kwargs)
File "/opt/conda/lib/python3.8/site-packages/clinicadl/extract/extract_cli.py", line 285, in roi_cli
DeepLearningPrepareData(
File "/opt/conda/lib/python3.8/site-packages/clinicadl/extract/extract.py", line 173, in DeepLearningPrepareData
Parallel(n_jobs=n_proc)(delayed(prepare_roi)(file) for file in input_files)
File "/opt/conda/lib/python3.8/site-packages/joblib/parallel.py", line 1056, in call
self.retrieve()
File "/opt/conda/lib/python3.8/site-packages/joblib/parallel.py", line 935, in retrieve
self._output.extend(job.get(timeout=self.timeout))
File "/opt/conda/lib/python3.8/site-packages/joblib/_parallel_backends.py", line 542, in wrap_future_result
return future.result(timeout=timeout)
File "/opt/conda/lib/python3.8/concurrent/futures/_base.py", line 444, in result
return self.__get_result()
File "/opt/conda/lib/python3.8/concurrent/futures/_base.py", line 389, in __get_result
raise self._exception
FileNotFoundError: The ROI 'rightHippocampusBox' does not correspond to a mask in the CAPS directory. The mask should follow the pattern caps_new/masks/tpl-MNI152NLin2009cSym/res-1x1x1_roi-rightHippocampusBox_mask.nii. and contain 'desc-Crop' string.

Hello @BanDoong ,
Sorry for the late reply.
We don't provide the mask for the regions of interest you need. In fact the mask depend on the data you have and the region you need to extract.
Here, in the documentation, we give the exemple of left hippocampus & right hippocampus masks just for the files names. However you have to bring your own masks.
To make a mask you can simply use a brain atlas with the region of interest you need and binarize it.
Once you have your file, you have to properly name it and store it in the right location in the CAPS directory.
Do not hesitate if you have more questions,
Regards


hsetroot: new pkg at 1.0.5

Read: <getkiss.org/guidestones.txt>
Description of package
a simple wallpaper changer that supports solid colors, gradients, and images
New package

[x] Latest upstream version.
[x] I agree to maintain this package.
[x] I agree to notify @dylanaraps if I can no longer maintain this package.

Build should be:
#!/bin/sh -e

mkdir -p "$1/usr/bin"

make
make PREFIX="$1/usr" install

There is no DESTDIR support and make install doesn't create the directories.

oops

Sorry, I feel really bad about doing all this stuff wrong 😄


Fix and restructure async workflows execution

Restructure the internal call flow in OpenXPKI::Server::API::Workflow to remove duplicate code in execute_workflow_activity and __wakeup_resume_workflow and a huge if-branch.
Fix __watch_workflow to monitor state and proc_state instead of last_update. With the current behaviour, if workflow steps are really fast the last_update might not change and __watch_workflow would not notice any change.

Coverage increased (+0.03%) to 41.004% when pulling f1f425eb06e14affadb4fea160922c216e704017 on maxhq:fix-async-wf into cb8c5c7e8a5573b5c2ff54342bc48eebfde4f404 on openxpki:release/v2.


Fixed 6 flaky-tests using Nondex

Flaky Test Fixes
Overview
This document outlines the issues identified in flaky tests and the corresponding fixes applied to address them. The changes were made in commit f11dbd9.
Test 1: JobTest.shouldJsonSerialiseAndDeserialise
Issue
The test was failing due to a strict assertion comparing order-sensitive elements.
Fix
Replaced the strict assertEquals with the more flexible JsonAssert from common-util to accommodate variations in element order.
Reproduction
To reproduce the error, use the following command:
mvn -pl core/operation edu.illinois:nondex-maven-plugin:2.1.1:nondex -Dtest=uk.gov.gchq.gaffer.jobtracker.JobTest#shouldJsonSerialiseAndDeserialise -DnondexRuns=10

Test 2: JSONSerialiserTest.shouldSerialiseWithHistoricValues
Issue
The test failed due to a strict byte array comparison that did not account for variations in element order.
Fix
Changed the assertion to use containsExactlyInAnyOrderElementsOf() to allow for a more flexible comparison.
Reproduction
To reproduce the error, use the following command:
mvn -pl core/operation edu.illinois:nondex-maven-plugin:2.1.1:nondex -Dtest=uk.gov.gchq.gaffer.jobtracker.JobTest#shouldJsonSerialiseAndDeserialise -DnondexRuns=10

Tests 3, 4, 5: MapSerialiserTest, SetSerialiserTest, FreqMapSerialiserTest
Issue
Similar to Test 2, strict assertions caused failures due to order-sensitive comparisons.
Fix
Replaced strict assertions with containsExactlyInAnyOrderElementsOf() to account for variations in element order.
Reproduction
To reproduce the error, use the following command for each test:
mvn -pl core/serialisation edu.illinois:nondex-maven-plugin:2.1.1:nondex -Dtest=uk.gov.gchq.gaffer.serialisation.implementation.MapSerialiserTest#shouldSerialiseWithHistoricValues -DnondexRuns=10

Test 6: StorePropertiesTest.shouldSetJsonSerialiserModules
Issue
The test failed due to a strict comparison that did not consider the initial order.
Fix
Used a HashSet for expected and actual to account for variations in element order.
Reproduction
To reproduce the error, use the following command:
mvn -pl core/store edu.illinois:nondex-maven-plugin:2.1.1:nondex -Dtest=uk.gov.gchq.gaffer.store.StorePropertiesTest#shouldSetJsonSerialiserModules -DnondexRuns=10

Testing the Fixes
All fixes were tested by running the affected tests with the proposed changes to ensure reliability.
Conclusion
These changes aim to address flakiness in the identified tests and improve the overall stability of the test suite.
Additional Information
The fixes were identified and tested using the nondex tool.
Please do let me know if have any queries or these fixes look good to you!

Can you provide me with details on what is not being preserved within the Java object?
Rather than making the test more "Loose" would it be better to make the serialisers more more consistent?


Emojis in Markdown breaking

In Markdown you can add emojis BUT ⚠ this emoji work and 💻 this doesn't
In kitchen sink example all are working because top Column has the scrollable: true property, but I've Emoji in a external widget so it not working even if I try to add scrollable: true anywhere

I"m not clear on what the ask is. @sharjeelyunus  please attach a picture of some sort. Scrollable should not be breaking emoji, plus the fact that some work and some don't make me think this is not a regression.

See the emoji on line 19 (⚠) it works

Now see the emoji on line 19 again (💻). this doesn't work

@sharjeelyunus @vusters I tried the Markdown issue
Here's my code:
This is not working. I got an exception in the YAML parser, it couldn't parse this emoji.
CustomMarkdown:
  inputs:
    emoji: 💻

When I wrapped the emoji into a string literal, then it's working
CustomMarkdown:
  inputs:
    emoji: "💻"

Custom Widget:
CustomMarkdown:
  inputs:
    - emoji
  body:
    Column:
      styles:
        gap: 16
      children:
        - Markdown:
            text: |
              ${emoji}


Sensors not working with SMART enabled [Bug]

Describe the issue
All OMV Sensors showing as unavailable, but very briefly appearing with correct values, and then going unavailable again.
Started happening after I updated my OMV to 6.9.10-4
If I disable S.M.A.R.T then all sensors become available again and everything works as expected, apart from the HDD temps which all read 0°C

How to reproduce the issue

Steps to reproduce the behavior:
Update to latest OMV Version, make sure that S.M.A.R.T is enabled
Expected behavior

Sensors to be available and showing the correct value with S.M.A.R.T enabled
Screenshots

Software versions

Home Assistant version: 2023.12.3
openmediavault integration version: 1.4.2
openmediavault software version: 6.9.10-4
Diagnostics data

config_entry-openmediavault-93de8c64700efb2495cf83f10489aed8.json.txt
Traceback/Error logs

This error originated from a custom integration.
Logger: custom_components.openmediavault.omv_api
Source: custom_components/openmediavault/omv_api.py:302
Integration: OpenMediaVault (documentation, issues)
First occurred: 13:36:14 (62 occurrences)
Last logged: 13:53:21
OpenMediaVault <IP_ADDRESS> unable to fetch data (500)
Logger: homeassistant
Source: /usr/src/homeassistant/homeassistant/runner.py:145
First occurred: 13:36:14 (192 occurrences)
Last logged: 13:54:54
Error doing job: Fatal write error on datagram transport
Traceback (most recent call last):
File "/usr/local/lib/python3.11/asyncio/selector_events.py", line 1190, in sendto
self._sock.sendto(data, addr)
TypeError: str, bytes or bytearray expected, not NoneType
Additional context

try using master, it is most likely related to already solved issue

That hasn't fixed it. It seems that every time it polls it shows the values for 3-4 seconds, then they dissappear again.

can you run it in debug to capture the error? using master version

I have had Debug running for a while, the whole log is now 185MB, heres a section of it
debug log.txt

I see only radarr integration and one of your template sensors crashing. OMV integration works normally.
Try to solve those, it could be messing up something in HA.

I have removed the radarr integration completely as I wasn't using it anyway. I tried disabling all of my template sensors and still the same behaviour.
I have this error in my log that increases about 5 times per minute :
This error originated from a custom integration.

Logger: custom_components.openmediavault.omv_api
Source: custom_components/openmediavault/omv_api.py:302
Integration: OpenMediaVault (documentation, issues)
First occurred: December 16, 2023 at 14:21:23 (4812 occurrences)
Last logged: 10:05:54

OpenMediaVault <IP_ADDRESS> unable to fetch data (500)

It goes away if I disable the OMV integrationand restart.
I still have this one though:
Logger: homeassistant
Source: /usr/src/homeassistant/homeassistant/runner.py:145
First occurred: 10:36:22 (12 occurrences)
Last logged: 10:36:22

Error doing job: Fatal write error on datagram transport
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/asyncio/selector_events.py", line 1190, in sendto
    self._sock.sendto(data, addr)
TypeError: str, bytes or bytearray expected, not NoneType

I don't know if it is related

ok, can you run debug now? I need it to capture above error from omv integration.

Here you are:
home-assistant_openmediavault_2023-12-17T11-04-42.990Z.log

I see, API behavior changed again. OMV changes API so often, its getting messy.

Thanks for all your efforts mate, I really appreciate it. For now I have found a workaround using command line sensors to extract HDD temps and I can just disable SMART data so I am not in need of an urgent fix.

is fd27480 not working?

Sorry, I hadn't actually downloaded the latest version after you updated. Yes, it has fixed it. Thank you very much for such a quick turn-around!!!

Hi. Im experiencing the same issue and i was wondering if it would be possible to merge the PR above?

I got the same issue. How do I update to the working version? I tried to replace the file above but it didn't help. Sorry for being such a newbie.

its not PR, its in master already. you can switch branch to master in HACS if you want to use it right away.


Modify description of latest Elastirini reproduction log

Forgot to say that I had reproduced for MS MARCO Doc as well.

Codecov Report

Merging #1738 (990e00c) into master (a62aca0) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1738   +/-   ##
=========================================
  Coverage     57.58%   57.58%
  Complexity     1032     1032
=========================================
  Files           173      173
  Lines          9781     9781
  Branches       1344     1344
=========================================
  Hits           5632     5632
  Misses         3675     3675
  Partials        474      474

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a62aca0...990e00c. Read the comment docs.


CDH: way to define alternative location of the config file?

At the moment (CCv0) kata-agent launches CDH with no arguments.
if let Err(e) = launch_process(
    logger,
    CDH_PATH,
    &vec![],
    CDH_SOCKET,
    DEFAULT_LAUNCH_PROCESS_TIMEOUT,
) ...

This means it will attempt to read a default config file at /etc/confidential-data-hub.toml. The config file is supposed to be dynamic, i.e. it will be populated at guest launch with values retrieved from init-data.
In a measured rootfs for peerpods /etc is on a read-only, dmverity-checked volume. all the dynamic files go into a (memory backed) /run folder. (I think this would also be a good pattern independent of how peerpod does it).
I see different ways of addressing this:

default config path to /run/confidential-containers/confidential-data-hub.toml (unintuitive, possibly)
make the default path for the config file configurable via env CDH_CONFIG_PATH (fine IMO, feels a bit weird that we have to do such gymnastics, there is precedent with KATA_AGENT_CONFIG_PATH, though)
do not launch CDH programmatically from agent, but use an init system instead (a comfortable option, a systemd directive can be easily adjusted. I think there were plans for this in the merge-to-main, however since those dynamic values are supposed to be set via agent RPC endpoint I wouldn't know how this works. can someone confirm?)
instead of (or prior to) defaulting to offline-fs-kbc if the config-file is not found, we could fall back to the AA_KBC_PARAMS env (not sure, we probably want to retire that variable).

do not launch CDH programmatically from agent, but use an init system instead (a comfortable option, a systemd directive can be easily adjusted. I think there were plans for this in the merge-to-main, however since those dynamic values are supposed to be set via agent RPC endpoint I wouldn't know how this works. can someone confirm?)

Although this would be my preference, we've a lot of folks who don't want to rely on systemd for reasons, and maybe it's time to have the conversation on whether it's worth or not, as it seems that we end up adding a lot of complexity for no good reason.

This is probably way off topic, but once init process comes in would this effect anything? My understanding is that with the current kata-agent driving initProcess/policy endpoint, we need to start the guest-components is a semi-initialised state from kata-agent as we don't have received the initdata from the pod spec when we create the sandbox and kata-agent and then send through the config later and fully initialise it (which feels like weirdness to me, but that's a different issue). If we have a pre-canned config/template that we pass from kata-agent at launch, would that result in the guest-components getting confused and either thinking it's fully initialised in the init-process world, not not fully initialised now? Or is this going to change once we adopt init-data, so not worth trying to predict?

When it comes to where to find the config file, I don't mind adding an optional env var to override the default location. It's maybe a bit inelegant, but that's easy to implement in the short term.
There are some other things we need to think about regarding config for the guest components, but I think we can consider them separately. The main quirks are probably that some components need to be (partially) configured prior to InitData being received (this is mainly the AA not the CDH) and on some platforms we will need fallback configurations because InitData isn't supported. We've thought about both of these cases already but we should try to document more clearly what the plan is. Like I said, I don't think it really affects this issue.

Hi @mkulke To fix this issue I prefer to CDH_CONFIG_PATH way rather than  AA_KBC_PARAMS way. The former could also help to config the resource configuration parts, while the latter can only config the remote kbs addr and kbc type.
Thanks @stevenhorsman for sharing your idea upon init system and I also agree that an init system before kata-agent would be a best choice to me now. The current design, s.t.

Without systemd
Kata-agent handle initdata set request

will result in that a partial initialized component like AA as @fitzthum mentioned. A workaround up to now before initdata is implemented is

kata-agent will still launch AA and CDH
kata-agent receives initdata, launch CDH and update configuration of AA

With init system solution we can avoid partial initialized state. As for a binary to handle Setinitdata RPC, things could also somehow be simpler, s.t.

Use virtio-fs/9p from kata-runtime/VMM to mount initdata to a specific path in pod like /run/confidential-containers/initdata
Launch AA and check the contents under /run/confidential-containers/initdata if its integrity is bound to the field in evidence
launch kata-agent, CDH, stc.

For scenarios who might not support virtio-fs, probably peer-pod. Still use user-data-processor solution.

Ok, I see a consensus forming around adding CDH_CONFIG_PATH  for the time being, until we settle on a lean solution for seeding configuration to CVMs (I hope we don't end up setting it in kata-agent w/ env::set_var(...) 🙏)


[CXF-8935]:Add doPrivileged block to httpclient.sendAsync() in HttpCl…

…ientHTTPConduit

Thanks for the review @reta


UnicodeDecodeError: 'utf-8' codec can't decode byte 0xab in position 286: invalid start byte

Hello and sorry for asking here. I am quite new to mirge3.0 and programming and am struggling on this issue:
I typed in this command:
miRge3.0 -s SRR_Acc_List_fastq.txt -lib /home/user/miRge3_Lib -on human -db miRBase -o output_dir -cpu 1 -a TGGAATTCTCGGGTGCCAAGG -pbwt /home/user/bowtie-1.3.0-linux-x86_64
and was returned with this error:
bowtie version: 1.3.0                                                                                cutadapt version: 4.4                                                                                Traceback (most recent call last):                                                                                File "/home/user/.local/bin/miRge3.0", line 8, in                                                                                sys.exit(main())                                                                                File "/home/user/.local/lib/python3.8/site-packages/mirge/main.py", line 42, in main                                                                                check_dependencies(args, str(runlogFile))                                                                                File "/home/user/.local/lib/python3.8/site-packages/mirge/libs/miRgeEssential.py", line 56, in check_dependencies                                                                                samtools = subprocess.run(str(samtoolsCommand), shell=True, capture_output=True, text=True)                                                                                File "/usr/lib/python3.8/subprocess.py", line 495, in run                                                                                stdout, stderr = process.communicate(input, timeout=timeout)                                                                                File "/usr/lib/python3.8/subprocess.py", line 1028, in communicate                                                                                stdout, stderr = self._communicate(input, endtime, timeout)                                                                                File "/usr/lib/python3.8/subprocess.py", line 1922, in _communicate                                                                                stdout = self._translate_newlines(stdout,                                                                                File "/usr/lib/python3.8/subprocess.py", line 905, in _translate_newlines                                                                                data = data.decode(encoding, errors)                                                                                UnicodeDecodeError: 'utf-8' codec can't decode byte 0xab in position 286: invalid start byte
Can anyone give me a hand please...?

Hi @johnjamespeter,
Don't be sorry, this is the right place to ask.
This issues seems to be with in-built Python function unable to read the encodings. However, to better understand this, I want to know more about which operating system you are running miRge3.0 on and also, on the command line, can you check if you have samtools installed.
The command which samtools should give you the following or similar output. or it should say samtools not found. If it is not found then can you try running miRge3.0 after installing Samtools.
$ which samtools
/usr/local/bin/samtools

Also, since it is your first time, can you try a test run as shown in the tutorial:
https://mirge3.readthedocs.io/en/master/quick_start.html#cli-example-usage
Thank you,
Arun.

Hi @arunhpatil , thank you for the reply! I am going to need some help for sure!
By typing the command you sent me, the reply was:
/usr/local/bin/samtools: No such file or directory
But I am sure I have installed samtools and it is because when I type:  samtools --version
I am replied with samtools 1.13
When I tried to run one of your given test sample file. There are some difference as well after trying to specify the location of the samtools:
miRge3.0 -s SRR772403.fastq.gz -lib /home/user/miRge3_Lib -a illumina -on human -db mirbase -o output_dir -gff -cpu 1 -pbwt /home/user/bowtie-1.3.0-linux-x86_64 -psam /usr/bin/samtools
bowtie version: 1.3.0                                                                                cutadapt version: 4.4                                                                                Samtools error!: samtools, command not found. Type "samtools --version" and check the version                                                                                Use argument -psam                                                                                NOTE: Will not exit unless you encounter this error otherwise                                                                                Collecting and validating input files...                                                                                miRge3.0 will process 1 out of 1 input file(s).                                                                                Cutadapt finished for file SRR772403 in 2.1457 second(s)                                                                                Collapsing finished for file SRR772403 in 0.0054 second(s)                                                                                Matrix creation finished in 0.0091 second(s)                                                                                Data pre-processing completed in 2.1671 second(s)                                                                                Alignment in progress ...                                                                                Alignment completed in 2.1315 second(s)                                                                                Summarizing and tabulating results...                                                                                Summary completed in 0.5375 second(s)                                                                                The path to ourput directory: /home/user/output_dir/miRge.2024-02-08_09-57-30                                                                                The analysis completed in 4.9032 second(s)
I try uninstall and reinstall samtools but that doesn't help...
Thank you anyways!

Hi @johnjamespeter,
I am glad it worked. You may raise a new issues (if you encounter any) in the future. I will consider it completed and close the issue.
Thank you,
Arun.


OpenLineage configuration inconsistencies

For Python Kafka transport config looks like this:
https://openlineage.io/docs/client/python#kafka
transport:
  type: kafka
  config:
    bootstrap.servers: mybroker
    acks: all
    retries: 3
  topic: my_topic
  flush: true

For Java it looks like this:
https://openlineage.io/docs/client/java/configuration#kafka
transport:
  type: kafka
  topicName: openlineage.events
  properties:
    bootstrap.servers: localhost:9092,another.host:9092
    acks: all
    retries: 3
    key.serializer: org.apache.kafka.common.serialization.StringSerializer
    value.serializer: org.apache.kafka.common.serialization.StringSerializer

Keys are named differently - topic vs. topicName, config vs. properties, no flush option in Java config. Is that okay? Is there any plan to synchronise config naming?
For Spark it is also different:
spark.openlineage.transport.topicName	Required, name of the topic	topic-name
spark.openlineage.transport.localServerId	Required, id of local server	xxxxxxxx
spark.openlineage.transport.properties.[xxx]	Optional, the [xxx] is property of Kafka client	1

What is localServerId, why is it required in Spark, but not in Java and Python clients?

IMO this needs consistency.

looks like topic is the proper option for Kafka libraries
I don't have opinion on message key. From backwards-compatibility perspective it would naturally easier to have this optional rather than required across all integrations. I'm also not sure why this would be called localServerId instead of Kafka's key name. @mobuchowski @pawel-big-lebowski, any thoughts on this?
config vs properties - again no strong opinion. I don't see any reason or library dependency that would force naming convention either in Java or Python. And again - this would be backwards-compatible, e.g. renaming config to properties but keep the old one with deprecation warning.

Spark transport is on the top of Java client, so localServerId should not be required for Spark while being optional for Java client. This particular example looks to me like a documentation mismatch.

What localServerId even means? It's value is put to server.id option of Kafka client, but I don't see any documentation related to this.
localServerId is marked as required, but actually an openlineage-java value is used if it is not explicitly provided by user.

https://github.com/OpenLineage/OpenLineage/blob/526f5dc5ef8160a60c1521f42bd5c2eddc5aab96/client/java/src/main/java/io/openlineage/client/transports/KafkaTransport.java#L38
while constructor of ProducerRecord is public ProducerRecord(String topic, K key, V value) {
This looks like someone in the past was trying to guarantee event ordering per job, based on localServerId and this super custom usage became part of our config.

@pawel-big-lebowski is working on configuration right now.

While working on https://github.com/OpenLineage/docs/pull/319 I've found more config options that are different in Java and Python clients:

Transport
Java
Python

http
timeoutInMillis: int
timeout: float

urlParams: dict
-

headers: dict
-

-
verify: boolean

kafka
topicName: str
topic: str

parameters: dict
config: dict

-
flush: boolean

file
location: str
log_file_path: str

-
append: boolean

So, should be Java & Python clients config syncronized? Is it worth it?


don't flag that a model has changes unless values are different

Fixes #17.
Turns out this was a straight forward change. LMK if you have any questions. Works flawlessly on my code base (with

As said in https://github.com/team23/pydantic-changedetect/issues/17 having the field marked as changed is the intended behaviour for now. If we change this we will need to have a good idea of what this means and handle more cases accordingly. Also this then needs to be documented.
So I'm closing this PR for now, while keeping the issue open for a discussion about the best behaviour. ;-)


Does this require npm on the user's system?

I can't find this info in the readme, and it's unclear scanning over the source:
Does this package require npm to be installed on the user's computer for it to work?

No it doesn't. It should be stand alone, it doesn't mimick all of the features of npm either. It only dumbly fetches code from packages. It doesn't, for example, run scripts such as "npm install" and subsequently doesn't compile native modules on the users system. It will instead download binaries that are pre-built. That should be in there now but its a bit of a work in progress still.

Got it, cheers


Migrate to caniuse-api 2.0.0

Please, migrate to caniuse-api v2.0.0, which depends on caniuse-lite and more than 7 times smaller than previous version.

Done (user now can choose which version to use)


Does not install on Retroid Pocket 3

I cannot update the app (says "not installed" for recent releases). I'm trying this on a Retroid Pocket 3 with Android 11.

Does it work for some releases and not for the other? Are you sure it's not your phone blocking the install? Sometimes there's a popup where you have to select "Install anyway".


make navbar phone-friendly

We should allow users to click to expand the sub-menu.

@hongsudt should the hover functionality be removed? or should we support both click and hover?

It was decided to only support click.

Assigning to @hongsudt  to verify this is working as expected.

Yes.. This is working as expected.


NETBEANS-896 Added missing nullcheck on JCTree.ErrorneousTree

Would somebody check and merge this one. It potentially prevents the IDE log pumped with NPE-s when nb-javac is not installed. This shall be cherry picked into release90 branch as well.

+1 Makes sense to me.

Looks sane to me too. The NULL check is safe in any case and should not be harmful to performance. I'll merge and also cherry-pick this into release90.

I cherry-picked the changeset into release90 and ran it through the quick-tests manually. That came back cleanly, so it was pushed.