fixes #51  white flash bug

fixes #51
adds modified assets
huge thanks to @finthecat
he did most ( all of the work on the assets ) of the work
adds a couple of missing emotions in constants
adds testing scripts for the assets

Replacements for the faulty assets :
Sprites-Apollo.zip
Sprites-Klavier.zip
Sprites-mia.zip

I threw the gifs into Aseprite, changed their color profiles to RGB, then exported them:
sprite > color mode > rgb
file > export > (enter, enter)
file > close
(repeat for all the files)
The shadow frame bug caused by the error (explained here) was fixed by throwing the gifs into Photoshop, and exporting them (with the default settings) to fix the shadowing:
File > Export > Save for Web (Legacy)
My assumption is that I just could have thrown them into Photoshop, have the color profile automatically be changed to RGB / sRGB, then export it.

Codewise the bug was originating in the pillow code to convert to RGBA mode found in the constructor of AnimImg in beans>img.py where it was possibly using a faulty palette. also confirmed by @FinTheCat

fixed that with 105c06f


nodejs16 typescript image task cleanup - removed cypress

Fixes #426
Tasks:

[ ] Updated design documents in docs/design directory or not applicable
[ ] Updated user-facing documentation in docs directory or not applicable
[ ] Ran tests (e.g. make test) or not applicable
[ ] Updated changelog or not applicable

This line could now be adjusted as well https://github.com/opendevstack/ods-pipeline/blob/937093380d7f2e1cc3d77f6ed7e9a32fce7971a1/Makefile#L116

👍
It would be nice to add a follow-up issue to figure out if moving to another base image that already includes Node would make sense.

@michaelsauter I forgot that and did a new commit with a new base image 👍


Update README.md

@ewjoachim updated

The PR points to your own fork. I f you want tu submit this to the repo, you need to edit or recreate the PR so that it points to the v3 on the upstream fork. I'll do this for you if you want.


Drop min thread count of threads doing Next to 1

When num_cores returns 1, there will be at most 2 executor threads and both of them will have long job. Thus a short job will fail to get registered and cause a hang.

Oh wow, never thought this case would happen!

This does suggest, btw, that I should stop using the executor for next-ing threads. I didn't realize that the executor had its own constraints.


Updated it for .net 8

Had to change it to use .net 8 and also replace the way you got the assembly location for the image since they got rid of that. the new way is 'DalamudPluginInterface.AssemblyLocation.FullName'

Very sorry for the delayed response. I've had some family medical issues to deal with. I should be back now.
Thank you for taking the time to work on this. I will pull it and try it out and push it to Dalamud. No that I'm back I'm going to move it to a non-testing plugin.

Glad to help <3 hope everything is ok!


Pending migration check SQL gets logged on every request in development

Hello, and thanks again for a great library.
I've just noticed that the 'pending migration check' SQL (example below) is logged before every request in my Phoenix app (in development), which adds quite a bit of unnecessary noise to the logs.
[debug] QUERY OK db=0.2ms
begin
[debug] QUERY OK db=0.1ms
LOCK TABLE "schema_migrations" IN SHARE UPDATE EXCLUSIVE MODE
[debug] QUERY OK source="schema_migrations" db=0.3ms
SELECT s0."version"::bigint FROM "schema_migrations" AS s0
↳ anonymous fn/5 in Ecto.Migrator.lock_for_migrations/4, at: lib/ecto/migrator.ex:533
[debug] QUERY OK db=0.2ms
commit

I wondered if this was some sort of configuration issue in my particular app, but I was able to reproduce in a new phoenix app with ecto_dev_logger installed/configured.
The reproduction repo can be found at https://github.com/vanderhoop/reproduction_of_schema_migrator_sql_logging_issue

Hi @vanderhoop
The issue was raised here https://github.com/phoenixframework/phoenix_ecto/issues/152
And we have a fix for this here https://github.com/fuelen/ecto_dev_logger/commit/56f3114c28e0bd3b3863e069a35507e7cce268a0
You have to use newer version of ecto_sql package.

Gotcha, and thanks for the quick response.
For anyone else coming here with this issue,  note that the change needed in ecto_sql hasn't been released as of today. Based on the changelog, it'll be a part of 3.9 once that's released.

https://github.com/elixir-ecto/ecto_sql/commit/1dfbf29e818793609dc3be3f564f6362791cdb2f
released 2 hours ago


CB-11839 Cloudwatch alarms are not deleted in case of sdx delete

Adding additional logging to try and trace the cloudwatch SDX deletion failures.
I wasn't able to recreate a failure to delete the cloudwatch alarms in my local CB environment, nor was I able to find a clear code path that would lead to deletion being skipped. I also don't see any "Unable to delete cloudwatch alarms" in Kibana at all over the last 30 days, which makes me think deletion is being skipped, not failing. This change adds more logging to the full call stack, so that we can better identify why deletion isn't always happening.

@hreeve-cloudera have you tested the scenario when you delete the instance on the provider side, let CB to recognize it (state changes to DELETED_ON_PROVIDER) then terminate the cluster?

I did try deleting a single EC2 instance and then doing a repair, to trigger the downscale operation. But I didn't try a terminate of the cluster with a deleted instance. I'll try that today.

Abandoning this because I think I may have found a proper fix thanks to the suggestion from @lacikaaa


Fix typos

Hello,
Here are 4 typos I found when looking in the documentation of Logfire.
I hope that's fine with you.
Thanks,
Avi

Thanks :)


new data is not parsed

Hi Darold
I am trying to parse and monitor logs from a remote server to a central pg_badger server with pg_badger as follows.
However, after the first log file is read, new data added to the log file is not parsed by pg_badger.
pgBadger version 11.7
#!/bin/bash
LOG_DIR=/data/dbcluster_name/11/data/log
LOG_FILE=postgresql-(date +'%a').log
REMOTE_PG=ssh://postgres@machine_ip:22
OUTDIR=/var/www/html/pg_reports_cluster_name/
/usr/bin/pgbadger -v  --retention 2 -I   -q $REMOTE_PG/$LOG_DIR/$LOG_FILE -O $OUTDIR -f stderr --prefix "[%m pid=%p] app=%a user=%u db=%d host=%h sessid=%c txid=%x"  --rebuild
crontab-e
58 */2 * * *  /usr/bin/sh  /var/lib/pgsql/badgersh/badger_cluster_name.sh >> /var/lib/pgsql/badgersh/badgerout.log 2>&1

Could be similar to #723 , try adding -r machine_ip to your pgbadger invocation.
This could cause the log to be read from the very beginning, but seems to work with version 11.7 and 11.6.

@kevser2761 , as Luca mention this could be related to #723. I have just published a fix, please give a try to latest development code and confirm if it solves your issue.

Commit 6a4750b fixes this issue.

hi,
ı tried with -r optıon and my pgbadger verison is 11.7
but ı stıll taking this error code in below and there are new data my log file
no new entries in your log(s) since last run.

The issue should have been fixed, so it is worth getting the latest code out of the git repository and try it.
Otherwise, please ensure you command line is like:
/usr/bin/pgbadger -v -r machine_ip  --retention 2 -I $LOG_DIR/$LOG_FILE -O $OUTDIR -f stderr --prefix "[%m pid=%p] app=%a user=%u db=%d host=%h sessid=%c txid=%x" --rebuild

and post the output if there are still problems. However, I encourage you to check out HEAD.


Adding GCC_EXE_SUFFIX to make-gcc-rpm.sh path to search for gcc executable

Fixing an issue in the rpm build script:
When defining GCC_EXE_SUFFIX in gcc-build-vars.sh,
make-gcc-rpm.sh is faling due to missing gcc executable.
The executable will be named differently in this case,
according to the value of GCC_EXE_SUFFIX.

Thanks for the fix!


Make VanillaDataManager generic

This PR makes VanillaDataManager a generic class which reduces the amount of boilerplate code when implementing different datasets:

The VanillaDataManager now takes the Dataset type as a generic parameter
Default generic parameter value is InputDataset (to preserve backward compatibility)
Removes DepthDataManager, SemanticDataManager, SDFDataManager (VanillaDataManager is used for everything, Dataset type is specified)
Added tests to ensure the correct dataset types are instantiated

I tested nerfacto and neus, both seems to work correctly.

I have updated the code, the question is now if we want to use current code with "orig_class" or switch to "class_getitem"

Can we merge this?

Done, thanks for the bump @jkulhanek!

Thank you!

@assafbot, can you please try if you still experience the error with #2129 version?


BaseSettings fails to load nested models overridden by ENV with case_senitivity=False

How to reproduce:
requirements.txt
pydantic==2.7.0
pydantic-settings==2.2.1

config.py
import os
from pydantic import BaseModel
from pydantic_settings import BaseSettings, SettingsConfigDict

os.environ['TEST_nested_nestedNested_var1'] = 'test'

class NestedNested(BaseModel):
    var1: str

class Nested(BaseModel):
    nestedNested: NestedNested

class Config(BaseSettings):
    model_config = SettingsConfigDict(
        case_sensitive=False,
        env_prefix='TEST_',
        env_nested_delimiter='_'
    )

    # optional, it should be None if no env is set
    nested: Nested | None = None

if __name__ == '__main__':
    config = Config()

This throws error:
Traceback (most recent call last):
  File "/pydanticTest/src/config.py", line 28, in <module>
    config = Config()
             ^^^^^^^^
  File "/pydanticTest/venv/lib/python3.12/site-packages/pydantic_settings/main.py", line 84, in __init__
    super().__init__(
  File "/pydanticTest/venv/lib/python3.12/site-packages/pydantic/main.py", line 175, in __init__
    self.__pydantic_validator__.validate_python(data, self_instance=self)
pydantic_core._pydantic_core.ValidationError: 1 validation error for Config
nested.nestedNested
  Field required [type=missing, input_value={'nestednested': {'var1': 'test'}}, input_type=dict]
    For further information visit https://errors.pydantic.dev/2.7/v/missing

Process finished with exit code 1

If I change case_sensitivity=True, it works fine.

Thanks for reporting this.
pydantic-settings convert all the env variables to lowercase if case_sensitivity=False(the default). that's why it can't find value for the field nestedNested.
This was the default behavior on V1 and we keep it on V2. So, we can't change it in V2

Is there any reason why this can't be fixed?
What about solution where the field name nestedNested would be coverted to lowercase too during matching?

Is there any reason why this can't be fixed?

I think it needs a big change in pydantic-settings and it can't be done in V2 because it will introduce some breaking changes.

What about solution where the field name nestedNested would be coverted to lowercase too during matching?

This is also happening. That's why you see the lowercase fieldname in error input_value={'nestednested': {'var1': 'test'}} but pydantic needs the real field name nestedNested

@chuckyblack
I created https://github.com/pydantic/pydantic-settings/pull/294 to fix the problem.
Could you please confirm it?

Great, it's working. Could you release a new version, please?

This will be included in the new release. I am trying to prepare a new release in couple of days


Clarify how store_location_for modifies URIs

This fairly straightforward refactor extracts the most obtuse portions of store_location_for into the following discrete private methods:

extract_path_from_location
remove_domain_from_uri
add_fragment_back_to_path

This may seem like indirection but it was very unclear what operation was being performed on the location sent to store_location_for prior to this change.
I considered documenting the behavior but the code seemed like a prime candidate for method extraction.

@lucasmazza Let me know if this makes sense. The only failures in the build seem unrelated. Also this is sort of staging area for a bugfix I'd like to introduce if it makes sense to you.

@olivierlacan Thanks for your contribution! Sorry for taking so long to review it.
I just triggered a rebuild and everything is green again 💚


Disabled fields are submitted

Are you submitting a bug report or a feature request?

bug
What is the current behavior?

All disabled field are submitted.
What is the expected behavior?
As per specification, no input should be submitted if any of it contains disabled attribute.
In form of
<!DOCTYPE html>

<form action="/action_page.php" method="POST">
  First name:

  <input type="text" name="firstname" value="Mickey">

  Last name:

  <input type="text" name="lastname" disabled value="Mouse">

  <input type="submit" value="Submit">
</form>

If you click the "Submit" button, the form-data will be sent to a page called "/action_page.php".

lastname is not sent to the action point.
Sandbox Link

Use html above
What's your environment?

React 16
Forms 7.2.0
Other information

We don't have any support for disabled fields, so that would be a new feature instead of a bug 😃

What's the best way to handle this situation, without the support for disabled fields from redux-form?
I am keeping a list of disable fields in react state, and use this list in handleSubmit() before sending out the result, but this feels weird. I'd be appreciated if someone could enlighten me with a better/standard solution.


how to automatically load specified plugins at startup

Hello, big brother, how to automatically load specified plugins at startup? Looking forward to your reply. Thank you very much for your project.

If you're referring to extensions, there isn't a direct way to preload them. However, there's a method for loading unpacked extensions, though it's not secure. An alternative approach is to store your Chromium user data in a Docker volume, which ensures that your browser state persists across restarts.


Deploying problems on Chinese servers

Updated version today，I am in Japan, but deploying the application on a Chinese server,Post-run redirect cn.codecombat.com, This will not happen in previous versions, how should I solve it?

Disable setupCountryRedirectMiddleware in server_setup.coffee.


Update UserGuide and Fix several Event-related Bugs

Pull Request Test Coverage Report for Build 159

8 of 19 (42.11%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.3%) to 81.199%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/address/logic/parser/AddEventCommandParser.java
4
5
80.0%

src/main/java/seedu/address/logic/parser/ParserUtil.java
2
4
50.0%

src/main/java/seedu/address/logic/commands/EditEventCommand.java
0
4
0.0%

src/main/java/seedu/address/logic/parser/EditEventCommandParser.java
0
4
0.0%

Totals

Change from base Build 158:
-0.3%

Covered Lines:
2168

Relevant Lines:
2670

💛  - Coveralls


Set testdata / example CA expiry to 20 years from issue date

Also add human-readable x509 text format (as requested by @SuperQ in related PR https://github.com/prometheus/prometheus/pull/14696)
Fixes: #3962

Incidentally, the expiry dates of the certs (both CA and server/client) seem to be a bit wild and inconsistent. The original CA had a lifetime of only 5 years, whilst the node{1,2}.pem certs had a 100 year lifetime (!). Usually the CA lifetime would be longer than host/node certs (although 100 years is a bit excessive).
It might be worth regenerating all the test / example certs with more sane lifetimes - and possibly consider bumping the key length to 4096 bits.


Failed to pull image at init stage (v0.9.0)

Throwing the following error: Failed to pull image "ghcr.io/galleybytes/terraform-operator-tftaskv1:latest": rpc error: code = NotFound desc = failed to pull and unpack image "ghcr.io/galleybytes/terraform-operator-tftaskv1:latest": failed to resolve reference "ghcr.io/galleybytes/terraform-operator-tftaskv1:latest": ghcr.io/galleybytes/terraform-operator-tftaskv1:latest: not found
Trying docker pull ghcr.io/galleybytes/terraform-operator-tftaskv1:latest returns: Error response from daemon: manifest unknown
Missing tag? https://github.com/isaaguilar/terraform-operator/blob/c5e61165398300d9d8efe972c752d64cb38b471c/pkg/apis/tf/v1alpha2/terraform_types.go#L15

It's not missing, it's not the decision of tfo to decide on the version of terraform to use. This was allowed before v0.9.x, but I thought it was a bad design to pick a version for the user. I can make a latest, but if latest bumps a minor version, who is responsible for ensuring the module is compatible?

Thanks for the reply. I think making a latest tag would be useful for those like me who try to use the terraform operator without specifying, however it does make sense to force the user to specify it with terraformVersion.


compiler 1.12.1

@lukechurch

Landing, this changes the version of dart2js used, but 1.12.1 does not actually have any dart2js changes.


The result of  the depth contronext

I run the pipeline of controlnext-SDXL(depth), but the change of the base model influences the result, in some cases, the generated image does not align with the depth.
With Animagine-XL-3.1
prompt: a dress

With Juggernaut-X-RunDiffusion
prompt: a dress

With SDXL1.0-base
prompt: a dress

Thank you for your feedback! I believe the issue is related to the data. Due to limitations in computational power and time, we trained the model for only a few thousand steps using images from a 12k dataset as a demo. This appears to be insufficient for achieving perfect generalization across various types of substrates.


Buddy Enabled Causes Error on Exit

Expected Behavior

The bot should exit without error
Actual Behavior

I get an error
Your FULL config.json (remove your username, password, gmapkey and any other private info)

Just a subset of tasks

"tasks": [
    {
        "type": "HandleSoftBan"
    },
    {
        "type": "CompleteTutorial",
        "config": {
            "enabled": true,
            "// set a name": "",
            "nickname": "",
            "// 0 = No Team, 1 = Blue, 2 = Red, 3 = Yellow": "",
            "team": 0
        }
    },
    {
        "type": "CollectLevelUpReward",
        "config": {
            "collect_reward": true,
            "level_limit": 2
        }
    },
    {
        "type": "BuddyPokemon",
        "config": {
            "enabled": true,
            "buddy_list": "charmander, squirtle, bulbasaur",
            "best_in_family": true,
            "// candy_limit = 0 means no limit, so it will never change current buddy": {},
            "candy_limit": 0,
            "candy_limit_absolute": 0,
            "// force_first_change = true will always change buddy at start removing current one": {},
            "force_first_change": false,
            "buddy_change_wait_min": 3,
            "buddy_change_wait_max": 5,
            "min_interval": 120
        }
    }
]

Output when issue occurred

[2017-02-21 08:27:36] [       cli] [INFO] Encountered 0 pokemon, 0 caught, 0 released, 0 evolved, 0 never seen before ()
[2017-02-21 08:27:36] [       cli] [INFO] Threw 0 pokeballs
[2017-02-21 08:27:36] [       cli] [INFO] Earned 0 Stardust
[2017-02-21 08:27:36] [       cli] [INFO] Hatched eggs 0
[2017-02-21 08:27:36] [       cli] [INFO]
[2017-02-21 08:27:36] [       cli] [INFO] Highest CP Pokemon:
[2017-02-21 08:27:36] [       cli] [INFO] Most Perfect Pokemon:
Traceback (most recent call last):
  File "pokecli.py", line 865, in <module>
    main()
  File "pokecli.py", line 206, in main
    bot.tick()
  File "/home/tony/bot/PokemonGo-Bot/pokemongo_bot/__init__.py", line 778, in tick
    if worker.work() == WorkerResult.RUNNING:
  File "/home/tony/bot/PokemonGo-Bot/pokemongo_bot/cell_workers/buddy_pokemon.py", line 135, in work
    if self._km_walked() - self.buddy['last_km_awarded'] >= self.buddy_distance_needed:
KeyError: 'last_km_awarded'

Steps to Reproduce

run latest master branch using buddy and have it exit using CollectLevelUpReward max level
Other Information
OS: Ubuntu 16.04 server

Branch: master

Git Commit: e00e8db36ca095c42a98e8925c454edc682eb13a

Python Version: 2.7

Any other relevant files/configs (eg: path files)

I had the same issue. Adding the following code on line 135 fixed it for me:
        if not 'last_km_awarded' in self.buddy or ('last_km_awarded' in self.buddy and not isinstance(self.buddy['last_km_awarded'],int)):
            self.buddy['last_km_awarded']=0

@mlussi Thanks, that worked.
Hopefully they can find out why it isn't being set in the first place and fix it.

@Holzberg My Guess is the buddy got evolved and removed from buddy list. But the bot still think that the buddy is still there.
Modified my codes and now testing if that the case.

I don't think that's the case for me because I am using a starter as a
buddy and only leveling to 3 so there would be no way it would have enough
candy to evolve.
On Mar 4, 2017 9:47 PM, "MerlionRock"<EMAIL_ADDRESS>wrote:

@Holzberg https://github.com/Holzberg My Guess is the buddy got evolved
and removed from buddy list. But the bot still think that the buddy is
still there.
Modified my codes and now testing if that the case.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/PokemonGoF/PokemonGo-Bot/issues/5928#issuecomment-284203147,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGWsOvN5TJ2E0NPD0j6ezon5KWaXfPFEks5rijBDgaJpZM4MHYTc
.

As a note, I have check level up reward enabled and have it set to max
level 3.  I think what happens is the bot starts, sees it has level 3 and
stops before the buddy module is initialized.
On Mar 4, 2017 11:55 PM, "Tony Holzer"<EMAIL_ADDRESS>wrote:

I don't think that's the case for me because I am using a starter as a
buddy and only leveling to 3 so there would be no way it would have enough
candy to evolve.
On Mar 4, 2017 9:47 PM, "MerlionRock"<EMAIL_ADDRESS>wrote:

@Holzberg https://github.com/Holzberg My Guess is the buddy got
evolved and removed from buddy list. But the bot still think that the buddy
is still there.
Modified my codes and now testing if that the case.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/PokemonGoF/PokemonGo-Bot/issues/5928#issuecomment-284203147,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGWsOvN5TJ2E0NPD0j6ezon5KWaXfPFEks5rijBDgaJpZM4MHYTc
.

seems to be resolved in later builds. closing

As far as I can see, the problem is still there.
It seems to be related to the account. I created a new account, and did the initial steps on the phone, included setting a buddy. Immediately afterwards I switched to the bot. It failed with KeyError: 'last_km_awarded' every time I had the buddy enabled. After running the bot for some time I opened the account on the phone, collected the buddy candies, and afterwards the bot run with buddy enabled without issues.


Remove RefCell from Class and Module specs

Just make Define mutable and store the RClass. In ClassLike::rclass, short circuit if rclass is Some and resolve the RClass using the mruby C API. Don't store this result to keep the API simple and not require mutability.

Accidentally filed this here https://github.com/mruby/mruby/issues/4543 😞 oops


Bug: The schemas of the response models are generated using aliases in the models as keys instead of property names in the models as keys

The schemas of response models are used in the auto-generated OpenAPI documentation of the API. These schemas of the response models are currently generated using aliases in the models as keys, and this way of generation is wrong for the API returns the models using the property names as the keys. Rectify the auto-generation of the OpenAPI documentation by having the schemas of the response models generated using the property names in the model as keys.

Made an attempt to rectify the auto-generated OpenAPI documentation without success.
A request has been made to add a new feature in flask-openapi3 to support the desired OpenAPI documentation generation.

FTR, by_alias from the request referenced above was implemented and released in https://github.com/luolingchun/flask-openapi3/blob/master/CHANGELOG.md#v250-2023-08-02


getElementsAtEvent for nearest

Expected Behavior

When click on canvas i want getElementsAtEvent for nearest point.
Current Behavior

I got empty array
Possible Solution

Environment

Chart.js version:
Browser name and version:
Link to your project: https://jsfiddle.net/6er6z89w/

@ar53n you need to use a newer version of chart.js and set the intersect and mode settings on the tooltp config. See https://jsfiddle.net/d20qe9r2/1/

is there a way to target the nearest data without having to click on the exact point

@projectcalix getElementsAtEventForMode: https://jsfiddle.net/f42b1nmq/

@projectcalix getElementsAtEventForMode: https://jsfiddle.net/f42b1nmq/

does this work in react-chartjs-2?


Inconsistent configuration properties names for aws credentials

TF provider uses inconsistent names for the AWS key/secret pairs.
For example
Kinesis source
aws.access.key.id
aws.secret.key.id

S3 source
aws.access.key.id
aws.secret.access.key

@Schekn thanks for reporting an issue!
Unfortunately it's not something that can be fixed in a client but I'll pass this to our backend team to update our Connect API.


Remove actors from screen when they are supposed to

🦟 Bug fix
Fixes #
Summary
Found that when actors are De-spawned the actor visuals are not destroyed. This commit addresses this bug by adding the missing remove logic in RenderUtils.
Before

After

Notes:
Theres a lot of hashmaps being populated in RenderUtils whenever a new actor is spawned. I hope I've caught them all.
Also while I need these working in garden (as all the projects Im working on use garden), should I backport these changes?
Checklist

[ ] Signed all commits for DCO
[ ] Added tests
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

should I backport these changes?

Can you go ahead and target this to the earlier version and we can get it on a forward port?


Fix installation instructions in README.md

Issue: closes #838

The issue is explained in detail there.
I think the template below is not relevant since this PR is simply a document change...
Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.

[ ]  issue was opened to discuss proposed changes before starting implementation. It is important do discuss changes before implementing them (Why should we add it? How should it work? How should it look? Where will it be? ...).
[ ]  during development, node version specified in package.json was used (ie using nvm).
[ ]  package versions and package-lock.json were not changed (npm install --no-save).
[ ]  app version number was not changed.
[ ]  all new code has tests to ensure against regressions.
[ ] npm run lint reports no offenses.
[ ] npm run test is error-free.
[ ]  README and CHANGELOG were updated accordingly.
[ ]  after PR is approved, all commits in it are squashed

Description of the Change

Verification Process

Other information

Thank you!

Thank you!


Check question provider parameters

Check the parameters for the question provider at the entry of question module to avoid unexpected loop / other errors.

[x] Provide special validate functions at the entry of question module
[x] Provide general validate functions integrated in setting.

Fixed in v0.3.0


Wrong error type in error callback

The typings of the errorCallback have that the returned error is a string, but in reality its an error Frame or a CloseEvent.

I assume you are talking about the typescript definition. I am not maintaining it I accept PR from typescript community. If the typescript community is not capable of maintaining it I will remove it. That was my only condition when I accepted the PR that add it the 1st time.


Does Android app support it now?

The article write in 06/07/2018 and Note: Viewing Power BI Reports hosted in Power BI Report Server using WAP to authenticate is currently supported only in iOS app. Android app is not officially supported at this time.
Does Android app support it now?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e74357ec-d4ac-973f-64ca-f8f4ca4e431a
Version Independent ID: 0e59b701-0c57-6b4d-40bd-5f5f2734cf96
Content: Using OAuth to connect to Power BI Report Server and SSRS - Power BI
Content Source: powerbi-docs/consumer/mobile/mobile-oauth-ssrs.md
Service: powerbi
Sub-service: powerbi-mobile
GitHub Login: @maggiesMSFT
Microsoft Alias: maggies

Hi, @angiwang -- thanks for your question! Assigning this to someone who can answer. Thanks!

Hey @angiwang,
Starting from 112683 app update, it is also supported in Android.
Maya

Great! Thank you so much!
From: Maya Shenhav<EMAIL_ADDRESS>Sent: Tuesday, July 2, 2019 5:30 PM
To: MicrosoftDocs/powerbi-docs<EMAIL_ADDRESS>Cc: Wang, Angi<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/powerbi-docs] Does Android app support it now? (#1150)
Hey @angiwanghttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_angiwang&d=DwMCaQ&c=-5LgSL_TkF3nGRQI95ci6eeFVMQ5VESHPf5koMIAxOA&r=6GdTxRKvVINiXvqWTExo2VxM9hLMzOiUbaFFYN4UbF4&m=EgaUNmGCslPWoLfl55d6iSuAiumnix3S8FdPHEQD3ro&s=mssVUYAhXamYQAc1mf2XvzmB_8EqIIFwFTLG-k0bF3c&e=,
Starting from 112683 app update, it is also supported in Android.
Maya
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_MicrosoftDocs_powerbi-2Ddocs_issues_1150-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAMMSDIHDIMXLWHIN6FBFZKLP5MN2XA5CNFSM4HZFGYU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZAVLYQ-23issuecomment-2D507598306&d=DwMCaQ&c=-5LgSL_TkF3nGRQI95ci6eeFVMQ5VESHPf5koMIAxOA&r=6GdTxRKvVINiXvqWTExo2VxM9hLMzOiUbaFFYN4UbF4&m=EgaUNmGCslPWoLfl55d6iSuAiumnix3S8FdPHEQD3ro&s=IKAHM8npO75pgoAPtOKEXufMSdUA9vQ7IQO8pCVaLYw&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AMMSDIFESP2DO67SEVKFWX3P5MN2XANCNFSM4HZFGYUQ&d=DwMCaQ&c=-5LgSL_TkF3nGRQI95ci6eeFVMQ5VESHPf5koMIAxOA&r=6GdTxRKvVINiXvqWTExo2VxM9hLMzOiUbaFFYN4UbF4&m=EgaUNmGCslPWoLfl55d6iSuAiumnix3S8FdPHEQD3ro&s=8UGzaHGr_Sd5gJlIJeRVL5UimsZKe3xY9g2J7NK07gU&e=.


Update APP Instructor

Removed Charlie, added Kieron.

:tada: This PR is included in version 6.12.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Some text was indented and recognized as code.

@LokiMidgard : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


#enhancement# Add Debug Function :smile:

This is an awesome plugin of vscode and it indeed help me configure my projects, while I think it will be better if the debug properity is added into this system.
At last, thanks for your working!:smile:

good idea !，I'm going to do that


Cannot resolve when removing recipe with wildcard

Input/output : http://i.imgur.com/TTwk2FY.png
Tweaker log : http://beta.pastee.com/b3rtz
tested without wildcard syntax because I thought that may work for some reason
non-wildcard recipe removals work fine

You can't use a wildcard to get any item from a mod.

Dang, how should i go about removing crafting recipes from all items in a mod then?

Add all the items to an array, loop through array.


Add basic support for adding SVG pictures to docx files #1343

See issues https://github.com/python-openxml/python-docx/issues/351, https://github.com/python-openxml/python-docx/issues/651, https://github.com/python-openxml/python-docx/issues/659.
This replaces both earlier pull requests:

https://github.com/python-openxml/python-docx/pull/1343: 2024-02-22
https://github.com/python-openxml/python-docx/pull/1107: two years ago

Hello, Is there a target date for this code to be committed to the master ?
I really need this implementation.
Thanks for the awesome software.

Hi @marcuoli,
No, unfortunately not.
I do try to keep my fork in sync with the main repository.

I hope this patch will be merged soon.
I'm trying to use your patch, but it doesn't appear to work with matplotlib figures since their sizes are in pt rather than pixels.
Example:
import docx
from docx.shared import Inches

import numpy as np
import matplotlib.pyplot as plt
from io import BytesIO

from tempfile import mktemp

x = np.linspace(-2*np.pi, 2*np.pi, 100)

fig, ax = plt.subplots()
ax.plot(x, np.sin(x), color="C0")
ax.plot(x, np.cos(x), color="C1")

buf = BytesIO()
fig.savefig(buf, format="svg")
w, h = (Inches(s) for s in fig.get_size_inches())

p = mktemp(suffix=".svg")
fig.savefig(p)

# doesn't work
doc = docx.Document()
doc.add_picture(buf, w, h)

Traceback:
File c:\Users\rpr\.conda\envs\funandgames\Lib\site-packages\docx\image\svg.py:43, in Svg._dimensions_from_stream(cls, stream)
     40 root = ET.fromstring(data)
     41 # FIXME: The width could be expressed as '4cm'
     42 # See https://www.w3.org/TR/SVG11/struct.html#NewDocument
---> 43 width = int(root.attrib["width"])
     44 height = int(root.attrib["height"])
     45 return width, height

I think a pt is 1.33x a pixel in svgs. If so, it might be easy to at least handle pt. But maybe it depends on dpi?
For matplotlib at least, I think dpi is fixed at 72 (e.g. here)
An example of an mpl svg is attached.

With this patch I can insert mpl figures. It's written rather verbose, as I don't really know the style of python-docx.
@takis would you consider adding this patch or something similar?
From 458df2e57c57be410e6d2486ae67e44cebbd177e Mon Sep 17 00:00:00 2001
From: Rasmus<EMAIL_ADDRESS>Date: Fri, 18 Oct 2024 10:02:49 +0200
Subject: [PATCH] svg: Handle non-pixels units

---
 src/docx/image/svg.py | 32 ++++++++++++++++++++++++++++----
 1 file changed, 28 insertions(+), 4 deletions(-)

diff --git a/src/docx/image/svg.py b/src/docx/image/svg.py
index 0247a77..4be43e1 100644
--- a/src/docx/image/svg.py
+++ b/src/docx/image/svg.py
@@ -33,13 +33,37 @@ class Svg(BaseImageHeader):
         """
         return "svg"

+    @classmethod
+    def _dimension_to_px(cls, s):
+        """Convert SVG unit *s* to pixels.
+
+        Based on the `table`_ on absolute length in W3 CSS Values 3.
+
+        .. table: https://www.w3.org/TR/css-values-3/#absolute-lengths
+        """
+        s = str(s)
+        unit = s.lstrip("0123456789.").casefold()
+        snumber = s[:-len(unit)] if len(unit) > 0 else s
+        number = float(snumber)
+        inch = 96
+        cm = inch/2.54
+        units = {"cm": cm,
+                 "mm": cm/10,
+                 "q": cm/40,  # 'Q' in W3 table
+                 "in": inch,
+                 "pc": inch/6,
+                 "pt": inch/72,
+                 "px": 1}
+        # Unitless is pixels
+        number_px = number * units.get(unit, 1)
+        return int(number_px)
+
     @classmethod
     def _dimensions_from_stream(cls, stream):
         stream.seek(0)
         data = stream.read()
         root = ET.fromstring(data)
-        # FIXME: The width could be expressed as '4cm'
-        # See https://www.w3.org/TR/SVG11/struct.html#NewDocument
-        width = int(root.attrib["width"])
-        height = int(root.attrib["height"])
+        # The width could be expressed as '4cm'
+        width = cls._dimension_to_px(root.attrib["width"])
+        height = cls._dimension_to_px(root.attrib["height"])
         return width, height
--
2.44.0.windows.1
```


Default Testnet Factory Contract Is Not Available

Describe the bug
The default Testnet factory contract is not available.
To Reproduce
Steps to reproduce the behavior:

Clone the repo
Run npm install
Configure env files as required
Run npm run start in "web" subdirectory
Select HashPack wallet
Select Testnet and click Accept

Expected behavior
No 404 error to be displayed regarding the factory contract.
Screenshots
Via Web UI:

Desktop (please complete the following information):

OS: WSL2 (Ubuntu 22.04.3 LTS) under Windows 11 (22631.3155)
Browser: Brave
Version: v1.63.165 (Chromium 122.0.6261.94)

Additional context

The current, unavailable, Testnet factory is listed at: https://github.com/hashgraph/stablecoin-studio/tree/main/cli#factories
The contract id can be seen as unavailable at: https://hashscan.io/testnet/search-result/0.0.14455068

@app-matt the Testnet Factory proxy address we deployed after the testnet reset is : 0.0.2167166. could you set it in your .env and test again (we will update the documentation during the day since we noticed that it is still displaying the old address)

@app-matt yes please open a new issue, it's very strange, it should only take the local rpc node if you explicitly set it in your .env file or if you do not configure anything at all (in which case the local rpc is set as the default node). Let's continue the discussion in a new issue.


animation bugs / unexpected behaviours

need of ng-leave on state transition animations
The effect itself doesn't need any manipulation with the state that is being removed, it just needs to stay where it was until the new state is on position, but if I don't specifiy ng-leave, it's gonna disappear right away, so I have to specify it
So I thought no problem, I'll specify it, but with the same property on both ng-leave and ng-leave-active(like opacity: 1), so it visually stays the same, see http://plnkr.co/edit/QsUxRYCH1lpXhywPCNLg?p=preview so the element that was being removed stayed on the place just fine, but didn't get removed at the correct time(I assume) so both enter and leave elements are at one point visible at the same time!
The only way to make it working was to actually set different opacity on ng-leave-active see http://plnkr.co/edit/6VRykxIOBr3Tz6FWxViM?p=preview old state still seems to flash there, but only very briefly. But it still sucks having to change that opacity.
ng-repeat animation not working on initial load
From this(http://plnkr.co/edit/jtXu7ZioEdA4yYxPSSFB?p=preview) example from @matsko I got the impression repeater animation would work on init, but when using it along ui-router, it just does not http://plnkr.co/edit/WHicNh8m22HArcfogbBC?p=preview .. I could make it work by adding a $timeout before setting the object.. which kind of sucks
ng-repeat animation not working after state change
See http://plnkr.co/edit/49WX9PsGbHmGTkQYfHOd?p=preview click on page b and the back to page a.. I have encoutered this quite a few times, it doesn't seem to be able to perform two different animation at the same time..
These angular animation are pretty damn useful.. if only I did not encounter a problem everytime I try to do like anything..
cc @matsko

@matsko - Is this issue now outdated and ready to be closed?

Problem 1) is inconvenient, but I don't think we should include a new state / class for this rare case. If the value ng-leave-active is very similar to the value in ng-leave, there should be no visual difference.
Problem 2) is solves by using $animate.enabled() when appropriate, see https://code.angularjs.org/snapshot/docs/guide/animations
Problem 3) is solved by using https://code.angularjs.org/snapshot/docs/api/ngAnimate/directive/ngAnimateChildren


WooCommerce Subscriptions compatibility

Can you reproduce this issue on default Wordpress theme (eg Storefront)?
Yes.
Can you reproduce this issue when all other plugins are disabled except WooCommerce, Polylang and Hyyan WooCommerce Polylang Integration?
Yes.(it requires WooCommerce Subscriptions)
What product versions and settings are you using when this issue occurs?

PHP: 7.1
WordPress: 4.8.2
WooCommerce: 3.1.2
Polylang: 2.2.3
Hyyan WooCommerce Polylang Integration: 1.0.3
Browser: Safari 11.0

Steps to Reproduce

Add variable subscription product to the cart;
Go to the cart;

What I Expected

What Happened Instead
Wrong price interval.

PR: https://github.com/hyyan/woo-poly-integration/pull/228

@Jon007 199$ is for 1 year of updates and support :)
This seems like official repo of the plugin: https://github.com/wp-premium/woocommerce-subscriptions
GPLv3 license is also included in the plugin files downloaded from woocommerce.com.

wp-premium says it is just a mirror, it is not the master repository.
curiously the repo does not include the GPL licence text however the readme file is marked with the licence.  This may be historic or error since none of the other wp-premium projects I sampled include a GPL reference.  I would guess from the name "wp-premium" that they are normally intended to be premium, ie paid.

@Jon007 I've asked the creators (https://prospress.com) of WooCommerce Subscriptions about the repository, here is the answer:

So believe it or not this plugin is free :)

wontfix , This is out of the plugin's scope


Encryption Model and key management table is out of date

The table information is out of date for the following services

Azure Table Storage - https://docs.microsoft.com/en-us/azure/storage/common/account-encryption-key-create?toc=%2Fazure%2Fstorage%2Fqueues%2Ftoc.json&tabs=azure-cli
Azure Queue Storage - https://docs.microsoft.com/en-us/azure/storage/common/account-encryption-key-create?toc=%2Fazure%2Fstorage%2Fqueues%2Ftoc.json&tabs=azure-cli
Azure Managed Disk - https://docs.microsoft.com/en-us/azure/virtual-machines/windows/disk-encryption-faq#does-azure-disk-encryption-allow-you-to-bring-your-own-key-byok
Azure CosmosDB - https://docs.microsoft.com/en-us/azure/cosmos-db/how-to-setup-cmk
Azure MySQL DB - https://docs.microsoft.com/en-us/azure/mysql/howto-data-encryption-portal#setting-data-encryption-for-azure-database-for-mysql
Azure PostgreSQL - https://docs.microsoft.com/en-us/azure/postgresql/concepts-data-encryption-postgresql
Azure Kubernetes Service - https://docs.microsoft.com/en-us/azure/aks/azure-disk-customer-managed-keys
Log Analytics Workspace - https://docs.microsoft.com/en-us/azure/azure-monitor/platform/customer-managed-keys

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cd0472f9-1ed9-0154-3bfd-b25e5da64cd1
Version Independent ID: 846187d4-c24c-279f-e216-80b6507228b3
Content: Microsoft Azure Data Encryption-at-Rest
Content Source: articles/security/fundamentals/encryption-atrest.md
Service: security
Sub-service: security-fundamentals
GitHub Login: @barclayn
Microsoft Alias: barclayn

@aalewismsft Thanks for the feedback !  I have assigned this issue to content author to investigate and update the document as appropriate.

#reassign:msmbaldwin

Hi, @aalewismsft. We have verified that the table is now up-to-date, including for these rows. Thank you! #please-close


pkg/mock should rely on method cascades

This issue was originally filed by<EMAIL_ADDRESS>
Behavior.* and LogEntryList.verify currently return this for chaining.  They should instead be void, and method cascades should be used by users of the APIs.  See issue #14714.

This issue has been moved to dart-lang/mock#1.


Use current code, not published images, in ES integration tests

https://github.com/jaegertracing/jaeger/blob/3b9428e616223259454951cf635ce3b892fc8e1e/plugin/storage/integration/es_index_cleaner_test.go#L35-L36
This test is invoked from scripts/es-integration-test.sh.
Here the test is using :latest build of the helper containers. This is what happens in the CI:
=== RUN   TestIndexCleaner_doNotFailOnEmptyStorage
Unable to find image 'jaegertracing/jaeger-es-index-cleaner:latest' locally
latest: Pulling from jaegertracing/jaeger-es-index-cleaner
Digest: sha256:9020812f290230b65e2ada3dcab193c419b7f8bb29435bab045f8802482d0004
Status: Downloaded newer image for jaegertracing/jaeger-es-index-cleaner:latest

In other words, instead of testing the current code (which could've been changed in the PR under test), we are using a published image built from the main branch.
We need to refactor this test. Since these helper containers are not used in any other CI workflows, it's good to test them in this workflow. We need to build the containers locally similar to this other script: https://github.com/jaegertracing/jaeger/blob/3b9428e616223259454951cf635ce3b892fc8e1e/scripts/build-upload-docker-images.sh#L61-L62
And then use a specific tag (not :latest) when executing the test.

@yurishkuro, can you give a reference to how containers are built locally and tested in other scripts?

I already have a link in the description


Account registration incomplete

I just wrote my first package that I wanted to publish on PyPI and didn't have an account. I have registered yesterday through the new registration form: https://pypi.org/account/register/.
The registration process had no issues, the account was directly active and the log in worked. Today I prepared the package for upload but i received a 401 error:
Upload failed (401): You must be identified to edit package information
After some research, I saw also other people complaining, and this might happen if the activation link in the email is not clicked. So one problem might be that the activation email is not being sent and the account is directly active.
Since I don't found any way resending an activation link, and the login with the account worked normally I have deleted the account and made another registration using the old PyPI website: https://pypi.python.org/pypi?%3Aaction=register_form
This time I received an activation link, which led me to a page where I also had to accept the submission terms. So probably this part is missing and this is why the authorization failed with the other account.

Hello, I think the same fix needs to happen for test pypi.  The guide asks you to register with a link to https://test.pypi.org/account/register/.  I was getting some 401 responses as well, and then found this issue.  Using the linked site, I never received a confirmation e-mail.
Solution: I went to https://testpypi.python.org/pypi (where the difference is a .python after testpypi), deleted the account I just made, and re-registered using this site (so following the link to https://testpypi.python.org/pypi?%3Aaction=register_form) and saw both a terms agreement as well as received a confirmation e-mail letting me finish the registration.
I believe the https://github.com/pypa/python-packaging-user-guide repo is the source code, would a PR fixing the testpypi URL be helpful or is the problem more complicated?

I can confirm the reported behavior. I just recently wrote up my learnings from publishing a package to PyPI for the first time (link to my blog post) and found that

The registration form on test.pypi.org seems to work
... but the confirmation email never arrives and there is no indication to the user that one should arrive
... therefore users never get to see the terms and cannot activate their account
... and then get a confusing error message when attempting to upload a package

The workaround is to use the registration form on pypi.python.org/pypi, but then complete all other steps on pypi.org.
@svenevs: This is my .pypirc with URLs for Test PyPI and real PyPI that worked for me:
 #~/.pypirc

 [distutils]
 index-servers =
   pypi
   pypitest

 [pypi]
 repository: https://pypi.org/legacy/
 username: YOUR_USERNAME_GOES_HERE

 [pypitest]
 repository: https://test.pypi.org/legacy/
 username: YOUR_USERNAME_GOES_HERE

The workaround is to use the registration form on pypi.python.org/pypi, but then complete all other steps on pypi.org.

Interesting.  It doesn't work for me, I was already registered on "real" pypi before getting the e-mail from the way I went about it (delete, alternative url).  As such, the URL you have gives me 403 errors :S  Hopefully your fix will apply to most situations.  I think I pigeonholed myself somehow.

Branch for this is here: https://github.com/pypa/warehouse/tree/verify-email-on-registration, blocked on merging #2898.


maybe the model par names change?

Traceback (most recent call last):
  File "attack_iter.py", line 243, in <module>
    tf.app.run()
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/platform/app.py", line 126, in run
    _sys.exit(main(argv))
  File "attack_iter.py", line 229, in main
    s1.restore(sess, FLAGS.checkpoint_path_inception_v3)
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/training/saver.py", line 1755, in restore
    {self.saver_def.filename_tensor_name: save_path})
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 905, in run
    run_metadata_ptr)
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 1137, in _run
    feed_dict_tensor, options, run_metadata)
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 1355, in _do_run
    options, run_metadata)
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 1374, in _do_call
    raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.NotFoundError: Tensor name "InceptionV3/AuxLogits/Conv2d_2a_3x3/BatchNorm/beta" not found in checkpoint files inception_v3.ckpt
         [[Node: save/RestoreV2 = RestoreV2[dtypes=[DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, ..., DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT], _device="/job:localhost/replica:0/task:0/device:CPU:0"](_arg_save/Const_0_0, save/RestoreV2/tensor_names, save/RestoreV2/shape_and_slices)]]

Caused by op u'save/RestoreV2', defined at:
  File "attack_iter.py", line 243, in <module>
    tf.app.run()
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/platform/app.py", line 126, in run
    _sys.exit(main(argv))
  File "attack_iter.py", line 219, in main
    s1 = tf.train.Saver(slim.get_model_variables(scope='InceptionV3'))
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/training/saver.py", line 1293, in __init__
    self.build()
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/training/saver.py", line 1302, in build
    self._build(self._filename, build_save=True, build_restore=True)
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/training/saver.py", line 1339, in _build
    build_save=build_save, build_restore=build_restore)
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/training/saver.py", line 796, in _build_internal
    restore_sequentially, reshape)
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/training/saver.py", line 449, in _AddRestoreOps
    restore_sequentially)
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/training/saver.py", line 847, in bulk_restore
    return io_ops.restore_v2(filename_tensor, names, slices, dtypes)
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/ops/gen_io_ops.py", line 1030, in restore_v2
    shape_and_slices=shape_and_slices, dtypes=dtypes, name=name)
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/framework/op_def_library.py", line 787, in _apply_op_helper
    op_def=op_def)
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/framework/ops.py", line 3271, in create_op
    op_def=op_def)
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/framework/ops.py", line 1650, in __init__
    self._traceback = self._graph._extract_stack()  # pylint: disable=protected-access

NotFoundError (see above for traceback): Tensor name "InceptionV3/AuxLogits/Conv2d_2a_3x3/BatchNorm/beta" not found in checkpoint files inception_v3.ckpt
         [[Node: save/RestoreV2 = RestoreV2[dtypes=[DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, ..., DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT], _device="/job:localhost/replica:0/task:0/device:CPU:0"](_arg_save/Const_0_0, save/RestoreV2/tensor_names, save/RestoreV2/shape_and_slices)]]

i get the  error above ,what should i do?

Traceback (most recent call last):
  File "attack_iter.py", line 243, in <module>
    tf.app.run()
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/platform/app.py", line 126, in run
    _sys.exit(main(argv))
  File "attack_iter.py", line 229, in main
    s1.restore(sess, FLAGS.checkpoint_path_inception_v3)
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/training/saver.py", line 1755, in restore
    {self.saver_def.filename_tensor_name: save_path})
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 905, in run
    run_metadata_ptr)
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 1137, in _run
    feed_dict_tensor, options, run_metadata)
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 1355, in _do_run
    options, run_metadata)
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 1374, in _do_call
    raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.NotFoundError: Tensor name "InceptionV3/AuxLogits/Conv2d_2a_3x3/BatchNorm/beta" not found in checkpoint files inception_v3.ckpt
         [[Node: save/RestoreV2 = RestoreV2[dtypes=[DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, ..., DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT], _device="/job:localhost/replica:0/task:0/device:CPU:0"](_arg_save/Const_0_0, save/RestoreV2/tensor_names, save/RestoreV2/shape_and_slices)]]

Caused by op u'save/RestoreV2', defined at:
  File "attack_iter.py", line 243, in <module>
    tf.app.run()
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/platform/app.py", line 126, in run
    _sys.exit(main(argv))
  File "attack_iter.py", line 219, in main
    s1 = tf.train.Saver(slim.get_model_variables(scope='InceptionV3'))
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/training/saver.py", line 1293, in __init__
    self.build()
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/training/saver.py", line 1302, in build
    self._build(self._filename, build_save=True, build_restore=True)
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/training/saver.py", line 1339, in _build
    build_save=build_save, build_restore=build_restore)
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/training/saver.py", line 796, in _build_internal
    restore_sequentially, reshape)
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/training/saver.py", line 449, in _AddRestoreOps
    restore_sequentially)
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/training/saver.py", line 847, in bulk_restore
    return io_ops.restore_v2(filename_tensor, names, slices, dtypes)
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/ops/gen_io_ops.py", line 1030, in restore_v2
    shape_and_slices=shape_and_slices, dtypes=dtypes, name=name)
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/framework/op_def_library.py", line 787, in _apply_op_helper
    op_def=op_def)
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/framework/ops.py", line 3271, in create_op
    op_def=op_def)
  File "/home/jitao/anaconda3/envs/tf1/lib/python2.7/site-packages/tensorflow/python/framework/ops.py", line 1650, in __init__
    self._traceback = self._graph._extract_stack()  # pylint: disable=protected-access

NotFoundError (see above for traceback): Tensor name "InceptionV3/AuxLogits/Conv2d_2a_3x3/BatchNorm/beta" not found in checkpoint files inception_v3.ckpt
         [[Node: save/RestoreV2 = RestoreV2[dtypes=[DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, ..., DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT], _device="/job:localhost/replica:0/task:0/device:CPU:0"](_arg_save/Const_0_0, save/RestoreV2/tensor_names, save/RestoreV2/shape_and_slices)]]

i get the error above ,what should i do?

Hello, are you still studying this field? How is your reproduction of the author's method?


Connect to Websocket

Was wondering whether there will be a way of connecting to Websockets.
This would allow certain situations where Proxies could be used.

The current adapter relies on ODBC. As far as I know there aren't any immediate plans for a connector using web sockets. I've raised the issue with product management and will get back to you on that.

Feedback from Product Management: a port to web sockets is not planned. I am closing this ticket.


feat: c at_activate and required components

Closes https://github.com/atsign-foundation/at_c/issues/176 and https://github.com/atsign-foundation/noports/issues/1325. Partially satisfies https://github.com/atsign-foundation/at_c/issues/399
- What I did

ATAUTH introduction

Introduced implementation for atactivate.
Introduced package atauth that holds impl for atactivate, atactivate-arg-parser, sending enroll request and fetching home dir.

ATCHOPS changes

Introduced hex_utils in atchops that has impl to convert data from byte-to-hex and hex-to-bytes.
Allow SHA512 as a valid hash type in atchops_sha_hash().
Introduced utf8 utils in atchops that utf8 encodes string data (converts string to bytes).

ATCLIENT changes

Introduce impl to perform cram authentication.
Introduced method to create/construct reserved keys.
Rename atclient_pkam_authenticate_options -> atclient_authenticate_options.
Rename ATCLIENT_PKAM_AUTHENTICATE_DEFAULT_ROOT_SERVER_HOST -> ATCLIENT_AUTHENTICATE_DEFAULT_ROOT_SERVER_HOST
Rename ATCLIENT_PKAM_AUTHENTICATE_DEFAULT_ROOT_SERVER_PORT -> ATCLIENT_AUTHENTICATE_DEFAULT_ROOT_SERVER_PORT
Introduced new param in atclient_delete_request_options named "skip_shared_by_check" and supporting method: init, set, unset, free and is_initialized.
Updated atclient_delete impl to ensure that keys can be used without "shared_by" param.
Updated atkey.c to ensure that is_shared_by_initialized check is skipped for reserved keys.
Added impl in connection.c to ensure that when mbedtls_ssl_write performs a partial write, the rest of the data is recursively written until the entire data is written.
Added error_buffers and pass them to mbedtls_ssl_read and mbedtls_ssl_write to get accurate error messages in case of failure

ATCOMMONS introduction

Introduced package atcommons that currently hold impl for the following:

enroll_command_builder - constructs an enroll:request command based on the params passed
enroll_namespace_struct - struct to hold enroll namespace  and enroll_namespace_list. Also has a toJson method.
enroll_params_struct - struct to hold enroll params. Has init and toJson methods
enroll_operation_enum - enum to specify enroll operation. Has a toString method
enroll_status_enum - enum to specify enrollment status. Has a toString method

- How to verify it
Tests on the way
- Description for the changelog

Implement atactivate, enroll:request, cram auth support and other minor components required by atactivate

Look into args.c in the repl example on how I used 3rdparty/argparse
https://github.com/atsign-foundation/at_c/blob/trunk/examples/desktop/repl/src/args.c

See how I defined a size and len and sent the len
  const size_t update_cmd_size =
      strlen("update") + metadata_protocol_str_len + strlen(":") + atkey_str_len + strlen(" ") + value_encrypted_base64_len + strlen("\r\n") + 1;
  if ((update_cmd = malloc(sizeof(char) * update_cmd_size)) == NULL) {
    ret = 1;
    atlogger_log(TAG, ATLOGGER_LOGGING_LEVEL_ERROR, "Failed to allocate memory for update_cmd\n");
    goto exit;
  }

  snprintf(update_cmd, update_cmd_size, "update%s:%s %s\r\n", metadata_protocol_str, atkey_str, value_encrypted_base64);
  const size_t update_cmd_len = update_cmd_size - 1;

  /*
   * 7. Send update command
   */
  if ((ret = atclient_connection_send(&ctx->atserver_connection, (unsigned char *) update_cmd, update_cmd_len, recv, recv_size,
                                      &recv_len)) != 0) {
    atlogger_log(TAG, ATLOGGER_LOGGING_LEVEL_ERROR, "atclient_connection_send: %d\n", ret);
    goto exit;
  }

@srieteja To clarify requirement a little bit more; the normal sequence for usage of the C at_activate will be as follows:
On some host which is not the device host

using the dart at_activate program
user onboards their @device atSign at_activate onboard

result: the primary atKeys file is generated

user generates an enrollment OTP for their device at_activate otp

result: an OTP is generated and output - e.g. 4A8QFZ

On the device host

using the C at_activate program
user runs at_activate enroll with parameters the same as those which the dart program uses

For example: at_activate enroll -s 4A8QFZ -p noports -d device_name -n "sshnp:rw,sshrvd:rw" -a @device
sends enroll request and goes into attempt-pkam-auth loop
result: an atKeys file unique to this device

See how I defined a size and len and sent the len
  const size_t update_cmd_size =
      strlen("update") + metadata_protocol_str_len + strlen(":") + atkey_str_len + strlen(" ") + value_encrypted_base64_len + strlen("\r\n") + 1;
  if ((update_cmd = malloc(sizeof(char) * update_cmd_size)) == NULL) {
    ret = 1;
    atlogger_log(TAG, ATLOGGER_LOGGING_LEVEL_ERROR, "Failed to allocate memory for update_cmd\n");
    goto exit;
  }

  snprintf(update_cmd, update_cmd_size, "update%s:%s %s\r\n", metadata_protocol_str, atkey_str, value_encrypted_base64);
  const size_t update_cmd_len = update_cmd_size - 1;

  /*
   * 7. Send update command
   */
  if ((ret = atclient_connection_send(&ctx->atserver_connection, (unsigned char *) update_cmd, update_cmd_len, recv, recv_size,
                                      &recv_len)) != 0) {
    atlogger_log(TAG, ATLOGGER_LOGGING_LEVEL_ERROR, "atclient_connection_send: %d\n", ret);
    goto exit;
  }

I tried this approach for the cram command. It worked. Thanks, @JeremyTubongbanua

All of the review comments have been adressed as part of 5162fb8.


RenderTexture draws blurry images when resolution is not 1

When the resolution for a game is greater than 1 an image drawn too a RenderTexture will become blurry. It seems to be scaled up from a lower resolution. For phaser version 3.16.1 and 3.16.2 the resolution is hardcoded to 1. I've therefor made a fiddle using the previous version (3.15.1) which demonstrates the issue:
https://jsfiddle.net/a35gcot8/2/

Closed via https://github.com/photonstorm/phaser/issues/4417#issuecomment-691461351


Fix HID serial on mac

Fixing hid serial on mac for detecting the micro:bit.
Fixes #2259

Will cherry pick to master once this goes in.

@pelikhan @microsoftsam  The HID serial uses our custom HF2 protocol. The microbit HID device uses DAPLink protocol. Also I don't believe it can run serial over it (but I'm not sure).
Merging this  will cause all sort of random devices being detected as HF2 devices.

@mmoskal is there somewhere else we test the device to see if its a microbit? in order to get serial working?
I thought the filter for release numbers was filtering for microbits on windows..

microbit does not use hid, it uses serial-over-usb. See https://github.com/Microsoft/pxt/blob/master/cli/serial.ts#L66

Okay so did some debugging and the serial info for the microbit on windows is:
comName: 'COM18',
  manufacturer: 'mbed',
  serialNumber: undefined,
  pnpId: 'USB\\VID_0D28&PID_0204&MI_01\\9900000040304E4500431003000000150000000097969901',
  locationId: 'mbed Serial Port',
  vendorId: '0D28',
  productId: '0204'

and on MAC it's:
comName: '/dev/cu.usbmodem1422',
  manufacturer: 'ARM',
  serialNumber: '9900000040304e4500431003000000150000000097969901',
  pnpId: undefined,
  locationId: '0x14200000',
  vendorId: '0x0d28',
  productId: '0x0204'

we are currently filtering for manufacturer:
        "manufacturerFilter": "^mbed$",

so a simple fix would be to change pxtarget filter to:
        "manufacturerFilter": "^(mbed|ARM)$",

which I've tested works, @mmoskal do you see any issues with that?
I wonder if this filters for all ARM devices, and not just micro:bits. The product ID is the same on both, should we switch to filtering based on the product id instead of manufacturer?

Yes, we should use the vendor/product id.

Yeah, the USB numeric ID is probably the way to go. OTOH maybe capturing any and all USB Serial ports wouldn't be that bad either.


gapi.load() clears the console.

I have a weird bug where as soon as I do gapi.load('client:auth2') it will clear out the console.
This makes it hard to debug stuff that happen before gapi.load.
Is this the normal behaviour?

@mesqueeb Is it on Chrome? If so, this is an issue with Chrome itself not the library. Adding an IFrame to the DOM does that in newer versions of Chrome. You can click the option to Preserve Log to avoid the console being cleared.

@TMSCH
Thank you very much. Preserve Log in the console does keep the logs.
Now I noticed the behaviour that when I open my app it says:

Navigated to https://accounts.google.com/o/oauth2/postmessageRelay?parent=http%3A%2F%2Flocalhost%3A5000&etc........ (omitted)

Is this behaviour normal? (If so you can just thumbs up this post)  : D

It is yes.

Sorry to unburry this thread but you say it's a Chrome bug, is there anywere I can find mention on this ?
I couldn't find anyone talking about this bug until this thread, I'm at least glad I'm not the only one.
I just can't find the proper words to search this bug online ... :(

Alright found it
TL;DR: Wait for chrome 66
https://bugs.chromium.org/p/chromium/issues/detail?id=823894
https://bugs.chromium.org/p/chromium/issues/detail?id=818209


Better ECS error checking

Try harder to query all the possible ec2 instances, and filter on instance state / lack of IP address.
Attempting to fix #1140

ping @containous/traefik

This looks fine, but it would be nice to cover some or all of these cases with unit tests, its getting quite complex allready!

@errm I've updated the PR with additional tests


Allow trailing newline to have fake position

In #17121, an assertion was added to catch when we calculated a position outside a file's bounds; however the pretty diagnostic printer relies on the fact that for a trailing newline we calculate a position one after the actual bounds of the file as the position for the first (nonexistant) character on that last line. An alternative was to adjust computeLineStarts to not include trailing newlines in the list of things calculated, then also adjust the baseline code to not consider trailing newlines as lines for writing errors on, then updating all the baselines; but that seemed a little less elegant than just allowing the one-character overflow; seeing as the calculated position always works as intended with substring.
Also modifies the test harness a little bit to allow it to baseline pretty-formatted diagnostics. They don't look terribly pretty in the baseline since they have ANSI escapes, but so be it.
Fixes #18216

Will there be another 2.5 bugfix release? This one is getting in my way of open-sourcing another part of the bazel typescript rules.

We have no plans for a 2.5 release at the moment. is this a blocking issue for you? can you move to 2.6?

No problem. I worked around it by swapping out
formatDiagnosticsWithColorAndContext for formatDiagnostics in our bazel
implementation, for now.
On Mon, Nov 6, 2017 at 1:49 PM Mohamed Hegazy<EMAIL_ADDRESS>wrote:

We have no plans for a 2.5 release at the moment. is this a blocking issue
for you? can you move to 2.6?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/TypeScript/pull/18298#issuecomment-342298907,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAC5I-UoibgS5cW9Q-4YFgxTzCoha_hiks5sz372gaJpZM4PPKU-
.


Broken DatePicker

Hi there,
I'm currently having an issue with the DatePicker. I have a simple layout with a DatePicker nested within a div and when I click on the the TextField, although the DatePicker show up it is missing the Calendar and is not set up right. Here's a screenshot of the issue.

The version I am running are:
material-ui: 0.11.1
react: 0.14.0-rc1
react-tap-event-plugin: 0.2.0
This is on chrome by the way. Thanks.

So taking a closer look at it, the DateDisplay component in the Calendar had a height set to 100% which was pushing the remainder of the calendar to the bottom. I'm not sure why it's happening but I'll update if I find the source of the problem.

Line 98 in calendar.jsx. 100% should be replaced by 64. So the dateDisplay style object should be,
dateDisplay: {
  width: isLandscape ? 120 : '',
  height: isLandscape ?
    weekCount === 5 ? 238 :
    weekCount === 6 ? 278 :
    198 : 64,
  float: isLandscape ? 'left' : 'none',
}

I'm seeing the same effect in the timepicker

PRs welcome :-)

Cool, I'll try to get one in during the weekend.

Fixed in PR #1726. This PR also fixes the TimePicker that CuthbertJungle was having.

@shaurya947 This can be merged also I think

@yulric You are not the only one to have this issue.
It was fixed by adding the missing <!DOCTYPE html>.
I'm closing the issue.


schedule_idle not taking &self

Is there a reason why IdleHandle::schedule_idle takes a &mut self instead of just &self like add_idle_callback? The underlying function add_idle_token doesn't seem to require mut access in any of the backends.

I haven't dug into the history to find out why, but I think it's fine to change it to &self


SCP-2256: remove fee inputs

These don't exist any more, instead there will be separate collateral
inputs which we don't see.
Fortunately, we hadn't even got around to using them.

Pre-submit checklist:

Branch

[x] Commit sequence broadly makes sense
[x] Key commits have useful messages
[x] Relevant tickets are mentioned in commit messages
[x] Formatting, materialized Nix files, PNG optimization, etc. are updated

PR

[x] Self-reviewed the diff
[x] Useful pull request description
[x] Reviewer requested

Pre-merge checklist:

[ ] Someone approved it
[ ] Commits have useful messages
[ ] Review clarifications made it into the code
[ ] History is moderately tidy; or going to squash-merge

Sorry! They should be trivial though, since you can just delete any references.


EC xref issues on peptidase terms

id: GO:0034701
name: tripeptidase activity
xref: EC:3.4.13
=> remove this EC (this is for dipeptidases - GO:0016805)
id: GO:0008239
name: dipeptidyl-peptidase activity
&
id: GO:0008240
name: tripeptidyl-peptidase activity
xref: EC:3.4.14
=> either both or neither of these terms should have this EC (which is for "Dipeptidyl- and tripeptidyl-peptidases")
id: GO:0070005
name: cysteine-type aminopeptidase activity
xref: EC:3.4.18
=> remove this EC (its for cysteine-type carboxypeptidases - GO:0016807)
id: GO:0016920
name: pyroglutamyl-peptidase activity
xref: EC:3.4.19
=> either remove this EC (it's for the parent term, GO:0008242) or maybe put both EC:<IP_ADDRESS> & EC:<IP_ADDRESS>??
id: GO:0070008
name: serine-type exopeptidase activity
xref: EC:3.4.21
=> remove this EC (it's for serine-type endopeptidases - GO:0004252)
id: GO:0042500
name: aspartic endopeptidase activity, intramembrane cleaving
xref: EC:3.4.23
=> not sure about this EC..strictly, this partial EC is for the parent "aspartic-type endopeptidase activity" GO:0004190 term

Gathering notes
GO:0034701    EC:<IP_ADDRESS> (Tripeptide aminopeptidase.)
This EC can be applied to this and also GO:0008240
EC:3.4.14 can be both di and tri (grouping term)
EC <IP_ADDRESS> suitable for GO:0016920

Hi @hdrabkin
I just came across some of these issues again - can we proceed with fixing the above?

Hi @hdrabkin @pgaudet
This ticket is ~2 years old.  Can we fix these five EC xref issues -  I think they are relatively straightforward?

Excellent, thanks.
Out of interest, what you did you decide to do with GO:0016920 - no EC xref, or add  EC:<IP_ADDRESS> & EC:<IP_ADDRESS>.  Looking at things like GO:0008239, seems like policy would be to add both those ECs?

These were already used as dbxrefs for the definition. I have added them to the xrefs as narrow matches  I have also replaced the two ecs in the def refs with PMID:9920379, a review article covering all types of this activity.


Must add reference to Microsoft.VisualStudio.Web.BrowserLink package

I had to manually add a nuget packet reference to Microsoft.VisualStudio.Web.BrowserLink in ASP.NET Core 2.1 Web application. Also must add 'using ' statement.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1fcc1fa9-004b-0be3-6148-e8c075e5b2bc
Version Independent ID: 78a1947e-dea7-65b4-2376-05c7795e4bf9
Content: Browser Link in ASP.NET Core
Content Source: aspnetcore/client-side/using-browserlink.md
Product: asp.net-core
GitHub Login: @ncarandini
Microsoft Alias: riande

@psijkof In which file did you have to add the using statement? I haven't been able to reproduce this.

I'm using VS 2017 CE 15.7.3
New project, ASP.NET Core Web App, Web App.
In Startup.cs, Configure method,
app.UseBrowserLink() does not resolve.
To resolve, must add reference to said nuget package and add using statement manually in startup.cs.


refactor(mocks): replace faker with @faker-js/faker

Status

READY
Description
Replace faker.js with its stable fork faker-js/faker to resolve #303
Related PRs
List related PRs against other branches:

branch
PR

Todos

[x] Tests
[x] Documentation
[x] Changelog Entry (unreleased)
[x] Resolve import issue described below

This should be ready to review. I hope I did not miss something :)
There is no changelog to add an entry, right?

Thanks! 🥳

Wow, such a great PR

Hi @konstantinkreft
Can you also publish to the npm, seems like it was merged but the NPM version is still not updated.
Thanks

@stijnvanhulle I'm not a maintainer of this package and I don't know when @anymaniax plans to release the next version.

Hey guys, probably tomorrow I will do a release


Removed hard-coding CC and CXX env variables for ninja

Fixed one of the Windows CI platforms yesterday as Visual Studio Tools was not configured correctly. So, don't need the hard-coded CC and CXX env variables for ninja anymore.

bors try

Should these still be defined for the non-Ninja generator? Sorry, I'm not quite sure what the original bug was and how this resolves it. Would you mind explaining a bit please?

Different libcxx tests are failing with Ubuntu 18.04 Linux CI runs since PR #1434

bors r+

bors r-

bors r+

Closing this as this Power shell script has been deprecated with the PR #1428 . This PR also does not hard code the env variables CC and CXX, so the essence of my PR has been incorporated.


Ability to set fade bias to BOTH -1 and 1?

Pyscenedetect has been working great for me until I ran into some video where commercial content was taken out, leaving just a black screen for minutes at a time.  Under these situations PSD will still only make one cut (under default fade bias 0.0 it will cut at the middle, leaving a chunk of black screen on the end of scene 1 and the beginning of scene 2).
My question is: Is there any simple way to change this behavior so that BOTH the fade out to black AND the fade in to content are counted as cuts (resulting in 3 scenes, with the middle "scene" being the entire time that the screen is blank)?
I know I could process the video twice, once with fade bias at -1 and a second time with fade bias at +1 but since it's taking me ~15 minutes to process a 1 hr long video, I really don't want to have to do two runs.
Lastly, thank you so much for this incredible open source resource, it's amazing!

Thanks for the tip - this will be very helpful.  I tried implementing the two detectors with different fade biases, and it does indeed capture the black screens, but there's still an issue:
Even when I set the min_scene_len on both detectors to 60 frames (or ~2 secs), I am getting the creation of tiny scenes that last only 20 frames or so.  Does this behavior make sense?  Other than min_scene_len, I don't see a place where I can prevent the creation of these tiny scenes.
After inspecting the source code and I tried to make this change to the ThresholdDetector() class and run only one detector, but this didn't work either.
  `
    min_frame_for_black = 60
    if self.last_frame_avg is not None:
        if self.last_fade['type'] == 'in' and self.frame_under_threshold(frame_img):
            # Just faded out of a scene, wait for next fade in.
            self.last_fade['type'] = 'out'
            self.last_fade['frame'] = frame_num

        elif self.last_fade['type'] == 'out' and not self.frame_under_threshold(frame_img):
            if (frame_num - self.last_scene_cut) >= self.min_scene_len:
            # Only add the scene if min_scene_len frames have passed.
                if (frame_num - self.last_fade['frame']) < min_frame_for_black:
                    # Do the normal thing if fade to black section is very small
                    f_out = self.last_fade['frame']
                    f_split = int((frame_num + f_out + int(self.fade_bias * (frame_num - f_out))) / 2)
                    cut_list.append(f_split)
                    self.last_scene_cut = frame_num
                    self.last_fade['type'] = 'in'
                else:
                    # Add both fade in and fade out frames to the cut list if the black section is long
                    f_out = self.last_fade['frame']
                    cut_list.extend([f_out, frame_num])
                    self.last_scene_cut = frame_num
            self.last_fade['frame'] = frame_num
    else:
        self.last_fade['frame'] = 0
        if self.frame_under_threshold(frame_img):
            self.last_fade['type'] = 'out'
        else:
            self.last_fade['type'] = 'in'
    # Before returning, we keep track of the last frame average (can also
    # be used to compute fades independently of the last fade type).
    self.last_frame_avg = frame_avg
    return cut_list

`
Any ideas of how I can get rid of those small scenes?  Thanks for your help.

For what it's worth, I tried this out using the cli and it worked just fine. I made an altered version of the Goldeneye clip from the docs examples that includes several sections where it fades to black for long periods and then fades back to the content. This was simply a matter of listing the detect-threshold command twice with different fade biases.
scenedetect -i goldeneye_fades.mp4 -s stats.csv detect-threshold -f -100 detect-threshold -f 100 split-video

This successfully isolates the black sections from the sections with content.

For what it's worth, I tried this out using the cli and it worked just fine. I made an altered version of the Goldeneye clip from the docs examples that includes several sections where it fades to black for long periods and then fades back to the content. This was simply a matter of listing the detect-threshold command twice with different fade biases.
scenedetect -i goldeneye_fades.mp4 -s stats.csv detect-threshold -f -100 detect-threshold -f 100 split-video

This successfully isolates the black sections from the sections with content.


make proxy httpNumThreads configurable

Fixes https://github.com/apache/pulsar-helm-chart/issues/250
Motivation
httpNumThreads is hardcoded to 8 in charts/pulsar/templates/proxy-configmap.yaml
When trying to override in values.yaml by using proxy.configData.httpNumThreads we get an error because the keys get duplicated.
This happens because {{ toYaml .Values.proxy.configData | indent 2 }} doesn't deduplicate the keys and there is no other way to set httpNumThreads
Modifications
Removing the key from charts/pulsar/templates/proxy-configmap.yaml and adding it to the values yaml solves the problem.
Verifying this change

[x] Make sure that the change passes the CI checks.

Dear @MarvinCai, could we merge that please 🙏

Dear @MarvinCai, could we merge that please 🙏

Thank you for your contribution @filipecaixeta!


Feed the cat with commits

There could be an extra mode where the cat got hungry after some time and you had to feed it with git commits, a coding tamagotchi basically. This could even be an actually helpful feature for some people as it puts some kind of pressure on the developer to not let their pet starve.

my whole team's pets would die.


Support a Newer Version of vlucas/phpdotenv

Is your feature request related to a problem? Please describe.
When attempting to use other plugins & composer libraries that also leverage vlucas/phpdotenv we're having a problem being able to install them as WPStarter is locked to an old ^2.0 version of the package, 5.5 being the latest.
Describe the solution you'd like
Update the code to be compatible with 5.2+ versions of vlucas/phpdotenv and optionally update the package dependency requirements to ^2.0|^5.0.
Describe alternatives you've considered
Attempt to manually install vlucas/phpdotenv using an alias so that it sees 5.2 as 2.x.
Additional context
Specifically this is an issue when using the Roots Acorn library/plugin. https://docs.roots.io/acorn/2.x/installation/#installing-acorn-with-composer

WP Starter v3 is not using  vlucas/phpdotenv anymore, but symfony/dotenv instead.
vlucas/phpdotenv is used on the "old" v2.
I would suggest moving to WP Starter v3 because v2 is not really supported right now.
That said, I could find some time to review a PR that supports more recent version(s) of vlucas/phpdotenv, but I don't have the time to do that myself.

@gmazzap I only see v3 as being in beta, and when I attempted to try the beta I was still getting warnings about needing the vlucas/phpdotenv library.

@timnolte The goal is to release v3 as stable very soon.
Regarding documentation, v3 does are up-to-date https://github.com/wecodemore/wpstarter/tree/version-3/docs


Debug mode

Can you make instructions to run in debug mode?

What do you want to debug? If you want GDB to print out the RSP packets while it interacts with the stub you can use set debug remote 1. If you want to debug the stub code, you can run with qemu and use qemu's built-in gdb server.


Add an option to use Docker!

Docker is great, especially when paired with a VPN container.

LGTM, seems to be very straightforward.

very cool. thank you for adding this!


Viable anomaly creatures drop skulls on butchered (Suggestions welcome)

Add the ability to extract skulls or have them drop at workbench from sensible humanoid anomaly creatures
Achievable with just configs, but might want a more solid approach

Resolved with Keyz addition of additional butcher comps, and the default "butcherProducts" def


Set up automated tests

Add tests to the project to detect broken links.

Consider using https://github.com/dkhamsing/awesome_bot for this. Should be easy to set up.

Thank you so much for the valuable suggestion. I will get this up and running and then send a PR 😄


isort insists on moving PyCharm noinspection comment, breaking it

This import statement imports several protected (start with underscore) members from a module. PyCharm includes a special comment that instructs its inspector to ignore this and not issue a warning:
# noinspection PyProtectedMember

This comment must go directly above the import statement that imports the protected members. If it goes anywhere else, it has no effect and PyCharm issues the warning. isort insists on moving this comment from where it's supposed to go to above the import group:
@@ -10,11 +10,11 @@
 import time
 import unittest

+# noinspection PyProtectedMember
 import pysoa
 import pysoa.client
 import pysoa.server
 import pysoa.server.autoreload
-# noinspection PyProtectedMember
 from pysoa.server.autoreload import (
     NEED_RELOAD_EXIT_CODE,
     AbstractReloader,
Apply suggested changes to '/Users/nwilliams/eventbrite/pysoa/tests/server/test_autoreloader.py' [y/n/q]? n

I have to skip it every time, which triggers warnings from our linter. isort should not attempt to move this comment to the top of the group. It should leave it where it is.

I filed this almost a year ago. Any chance we can get it fixed sometime soon?

Nothing?


[flutter_tools] Set basic error matcher for Linux builds

Description
This improves the situation a lot because, in contrast to not showing any error, this patch makes at least the most important part of the error visible. Notice that Clang includes expressive diagnostics on consequent lines, but they are not caught by this regexp.
Before
Any build error:
Launching lib/main.dart on Linux in debug mode...
Building Linux application...
Exception: Build process failed

After
Dart error:
Launching lib/main.dart on Linux in debug mode...
Building Linux application...
lib/main.dart:10:3: Error: Type 'UnknownWidget' not found.
Exception: Build process failed

C++ error:
Launching lib/main.dart on Linux in debug mode...
Building Linux application...
/path/to/linux/main.cc:4:3: error: unknown type name 'UnknownType'
Exception: Build process failed

Related Issues
#33584
Tests
I added the following tests:

test/commands.shard/hermetic/build_linux_test.dart: 'Linux build extracts errors from stdout'

Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

Related: https://github.com/ninja-build/ninja/issues/1537


Add github sponsor button when available

Hello !
I just wanna add the github sponsor button when available on the module page. Script based on github file: .github/FUNDING.yml
See the render when available:

hope this can be usefull

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I am not supportive of this. GitHub sponsors is a feature of GitHub. Adding it to deno.land/x would make it seem like Deno is somehow affiliated with the program or promoting it. Deno doesn't control the program, nor who participates in it, nor how any sponsorship money is held or distributed. It also isn't the only way to provide funding for open source projects.
We already provide a link to the published repo and there is nothing preventing someone from linking to sponsorship in their README.

Also, with #2339, this wont be possible anymore as there wont be a directory listing

Given that #2339 landed, this is no longer possible, so respectfully closing


Collapse and two columns layout

I am trying to use one accordion for two columns layout and this is only working in bootstrap 4 alpha and is NOT working since any beta release (tried even with the latest beta 3).
Steps to reproduce with CodePen examples
Take a look at this codepen - once you click on any collapsible element it stays collapsed forever unless you click on it again. However the expected behaviour is that only one element should be collapsed at a time.
Take a look at the very same HTML markup using Bootstrap Alpha 6. Everything is working as expected. You are not able to have more than a one element collapsed.
Related issues
There is a similar issue #24810 but I am not sure whether it is related or not.
Environment

Windows 7 64 bit
Chrome version 63 (64 bit)

On line 133 of collapse.js only children of children of the accordion parent are filtered to hide.
actives = $.makeArray($(this._parent).children().children(Selector.ACTIVES))

I changed this behaviour in #25121
actives = $.makeArray(
  $(this._parent)
    .find(Selector.ACTIVES)
    .filter(`[data-parent="${this._config.parent}"]`)
)

This works, but throws an error during the karma test, does anyone know how to fix this?

@MartijnCuppens: did you run your branch locally with npm test? Maybe an existent test needs adaptation.

@XhmikosR, the unit tests indeed needed some adaption. PR #25121 is just updated.


notes for external_c_calls and R calls

These are currently a draft feature.

Make them work uncompiled when possible (R calls, at least).

Maybe make nimbleFunction be able to create them so that it is clear to a user that they are in fact nimbleFunctions, hence can be used in registerDistributions etc.

This was addressed already.


More lints

This enables some more lints and updates the comments on some that we will probably never enable.

cc @a14n, @goderbauer