async* inconsistency in DDC

We know we have several inconsistencies so far, here is a case originally reported in the flutter repo: https://github.com/flutter/flutter/issues/140199
import 'dart:async';

Future main() async {
  Stream<int> step1() async* {
    yield 0;
    await Future.delayed(const Duration(milliseconds: 100));
    yield 1;
    throw Exception('error');
  }

  Stream<int> step2() async* {
    await for (final v in step1()) {
      yield v;
    }
  }

  try {
    await for (final v in step2()) {
      print('v: $v');
    }
  } catch (e) {
    print('e: $e');
  }
  print('finish');
}

Output in VM and dart2js:
v: 0
v: 1
e: Exception: error
finish

Output in DDC:
v: 0
v: 1

Is there any progress on this? I find it quite difficult to debug my applications with this wrong behavior in dev build.
Thanks :)

@sigmundch are there any updates on this?

Thanks for following up, unfortunately no, we haven't been able to prioritize this :disappointed:
This may not be very helpful or you may already be aware of this, but just in case: some developers find useful to do some additional debugging with the --profile mode. That mode runs the dart2js compiler (same one use for release builds) in a mode that keeps around the original names of your classes and members. That compiler will have the correct async* semantics. However, it can only be used with the default browser devtools and not via the Dart Devtools. Anyways, sometimes it can provide a bit of additional info that it's otherwise hard to get in other ways today.

@natebiggs
I believe this has been corrected with your change. WDYT?

I just verified locally that DDC, with the new async changes, now shows an output aligned with the VM and dart2js. These changes should roll into Flutter soon but likely won't be in a stable release for a few months. Going to close out this issue though as the fix has been landed in the Dart SDK.

Just wondering, is it safe to assume the current test coverage also covers this case, or is it worth adding it as a regression test case?


Support for more platforms!

I would like to use one common package manager for my C/C++ libraries, across many different systems. It's awesome that vcpkg supports macOS, Windows, and Linux! Could we also test support for some more obscure systems like BSD's, Illumos, MINIX, and Haiku?

We need more contributors to write the related toolchain code first.

This issue hasn’t been updated in 3 month, if it is still an issue, please reopen this issue.


[tf][aws] add aws terraform for validator

Motivation
Open source terraform files for deploy validator node in AWS
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Will try to validate through my local nodes
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/diem/diem/tree/main/developers.diem.com, and link to your PR here.)
If targeting a release branch, please fill the below out as well

Justification and breaking nature (who does it affect? validators, full nodes, tooling, operators, AOS, etc.)
Comprehensive test results that demonstrate the fix working and not breaking existing workflows.
Why we must have it for V1 launch.
What workarounds and alternative we have if we do not push the PR.

@rustielin Yeah, README will come later once I got the vault stuff out as well.

/land

:broken_heart: Test Failed - ci-test

/land


Instagram

Prerna___226 I'd hack

Prerna___226 I'd hack

Who asked?

Prerna___226 I'd hack

bro can u hack a id for me i will pay for u

Prerna___226 I'd hack

bro can u hack a id for me i will pay for u

i can hack it for you for cheap, and quickly. You can contact me on my instagram: seve.services or on my discord svist#8888

can you tell me which protocol i have to use for proxies is it http or https

Im pretty sure that it's http

can you tell me which protocol i have to use for proxies is it http or https

http

Prerna___226 I'd hack

bro can u hack a id for me i will pay for u

I can help you <<<

Can u help me ? number +37498027027 It can change my fate, I beg you very much

Ok +18583792029
On Thu, Jan 19, 2023, 16:07 Hemant Chaudhary @.***>
wrote:

Prerna___226 I'd hack
bro can u hack a id for me i will pay for u
—
Reply to this email directly, view it on GitHub
https://github.com/Bitwise-01/Instagram-/pull/212#issuecomment-1397120377,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A4NBCFE3H3SLW4EIUQPG6NDWTFKCBANCNFSM6AAAAAASMU3ZG4
.
You are receiving this because you authored the thread.Message ID:
@.***>

No bro, the number I wrote is the number that is linked to the account


[WIP] Try implementing embulk-junit5-*

It's now being tried at: https://github.com/embulk/embulk-junit5-proto


Support Events. closes #64

Despite there being two pull request based on that I personally consider that:

Events, or followUpEvents is may be related with contexts but on the contrary they are a response themselves.
It might has no preference for tell or ask.

So I think events has to be in the response builder workflow. Then you can send them with ask or tell.
usage:
const googleResponse = .buildRichResponse(); // build your rich response as usual.
googleResponse.setEvent('event-name', {param1: value1, param2: value2, ...});
.ask(googleResponse); or .tell(googleResponse);
Speech and followupEvent will both be sent, although they are incompatible see https://dialogflow.com/docs/events#invoking_event_from_webhook but I personally believe it is responsible of the other side and this pull request won't block any future development.

Thank you for the PR! For now I think #84 provides the more straightforward solution to adding this functionality. Moreover, follow up events don't quite fit with the concept of RichResponses. That said, we definitely appreciate the high-quality contribution you're suggesting.

It is, when I saw the other PR I though.. damn it, it is already done, but I though about that dialogflow maybe can handle a response and an event at the same time, so you can say something (not ask) and then move to another intent right straight. That's my two cents.


add urlpattern to update-wpt.sh

Updates update-wpt.sh script to include url pattern files

The JSON schema has changed? Why did they make these changes?

The JSON schema has changed? Why did they make these changes?

unfortunately, url pattern json files have different schemas

@anonrig As far as the failing IDNA test goes, it is not a bug.
Unicode 16 came out in September:
https://www.unicode.org/versions/Unicode16.0.0/
We use Unicode 15. So we need to update.


Implement step size buttons

What's New?

Step size buttons actually do stuff.

Deploy completed.


Bluetooth keyboard...

Hi,
is there any way of making this work with a bluetooth keyboard?
Thanks!

Compile lsinput from Hawck and provide the output of the following command:
$ lsinput

This should print out something like this:
event18: Hawck virtual keyboard device
event8: ThinkPad Extra Buttons
    by-path: platform-thinkpad_acpi-event
event7: TPPS/2 IBM TrackPoint
    by-path: platform-i8042-serio-2-event-mouse
event6: SynPS/2 Synaptics TouchPad
    by-path: platform-i8042-serio-1-event-mouse
event3: AT Translated Set 2 keyboard
    by-path: platform-i8042-serio-0-event-kbd
event2: Power Button
event1: Sleep Button
event0: Lid Switch

In my case, the keyboard is "AT Translated Set 2 keyboard", so my keyboard device file is /dev/input/event3
You then want to find out which file in /dev/input/ your bluetooth keyboard corresponds to, and to run hawck-inputd --kbd-device $your_bluetooth_kbd_device.

Hi Jonas!
I got the following error trying to compile lsinput:
$ gcc lsinput.cpp
lsinput.cpp:47:10: fatal error: SystemError.hpp: No such file or directory
   47 | #include "SystemError.hpp"
      |          ^~~~~~~~~~~~~~~~~
compilation terminated.

I found the device with another method  and got the UI up and running but the Keymap button
on the settings tab  has no entries.

I'm running on Fedora 31.
Thanks!

Hmm, the UI looks for keymaps in these two directories:

/usr/share/keymaps
/usr/share/kbd/keymaps

On Debian based systems the console-data package is required to get the /usr/share/keymaps directory, I don't know what the setup looks like for Fedora, it would help if you could poke around with something like:
$ find / -name "*.kmap"
$ find / -name "*.map"
$ find / -name "*.kmap.gz"
$ find / -name "*.map.gz"

As for compiling lsinput, you can do this from the src/tools directory:
$ g++ -std=c++17 lsinput.cpp -I.. -o lsinput
$ sudo ./lsinput

You could also do it through the build system, the install script should compile lsinput and put it inside build/src/lsinput.

Hi Jonas!
On my Fedora machine, it appears the keymaps are in /usr/lib/kbd/keymaps. For now, I just copied the directory into /usr/share but when I click the button, nothing shows up.
When I activate example.hwk I get a notification saying "Require authentication as hawck-input".
I am a member of the hawck-input-share group.
I now have lsinput compiled, thanks!

The hawck-input-share group is a bridge group for communication via UNIX domain sockets, as of now you still need to authenticate in order to install key permission files (required for each script.)
The UI is a bit unstable I'm afraid, getting authentication prompts to reliably appear on different distributions has been an issue, you're supposed to get a polkit password entry prompt in this case (I'll have to do some testing on Fedora to see why it isn't appearing.)
The easiest way to get things up and running to test some scripts would be for you to just bypass the UI for now:

Make sure Hawck is properly installed, e.g you should have the ~/.local/share/hawck directory and the /usr/share/hawck directories set up.
Enable "unsafe mode", which sidesteps the need for authentication:

## __UNSAFE_MODE.csv can also be found in hawck-master/bin
$ sudo cp /usr/share/hawck/keys/__UNSAFE_MODE.csv /var/lib/hawck-input/keys/
$ sudo chown hawck-input:hawck-input /var/lib/hawck-input/keys/__UNSAFE_MODE.csv
$ sudo chmod 0644 /var/lib/hawck-input/keys/__UNSAFE_MODE.csv

Create a script inside ~/.local/share/hawck/scripts

$ nano ~/.local/share/hawck/scripts/my_script.lua
$ chmod 0744 ~/.local/share/hawck/scripts/my_script.lua

Start up hawck-inputd and hawck-macrod

macrod will automatically reload the script when you save it after a subsequent edit, so you don't need to restart macrod when changing the scripts.

The Hawck daemons log their errors to syslog, so you can check for errors with journalctl -n 10000 | grep -E "hawck-(inputd|macrod)"
You'll also have to edit the ~/.local/share/hawck/cfg.lua file, here's what mine looks like:

local config = {
  disable_on_err = false,
  eval_repeat = true,
  notify_on_err = true,
  -- This is the line you want to change, `macrod` will look for a file matching "$keymap.kmap" or
  -- "$keymap.kmap.gz", or "$keymap.map", etc in `$the_keymap_directory`
  keymap = "no-latin1",
  eval_keyup = true,
  disabled = false,
  eval_keydown = true,
}
return config

Here's an example script (note the lack of an => operator, the UI automates the process of translating a => b into __match[a] = b, but it can be tedious to run the scripts manually):
require "init"

__match[key "Caps" ] = replace "Escape"

__match[mode("Programming mode", -up + key "F7") + down ] = MatchScope.new(function (__match)
  __match[shift ] = MatchScope.new(function (__match)
    __match[key "ø" ] = insert "["
    __match[key "æ" ] = insert "]"
  end)
  __match[key "ø" ] = insert "{"
  __match[key "æ" ] = insert "}"
end)

__match[key "F7" ] = off

That got a bit long, but hopefully it solves your problem.
I'll have to add the Fedora keymap location to the list of possible keymap locations.


font: add cursor-height metric, and adjust- config for it.

Subsumes #2580 (which has multiple conflicts with main due to recent changes to metrics); I figured it'd be easier to just implement it this way.
#2580 claimed to solve #2487 but I don't think it really does- ideally we can think of a good way to configure each individual cursor type, but I don't wanna just do something ad hoc and add a bunch of config keys blindly so I limited the scope of this.

Yesss, thank you so much for this @qwerasd205 @mitchellh ❤


[$500] Web -  Admin can submit and approve their own report when "Prevent Self-Approval" is on

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v1.4.40-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Issue found when executing PR https://github.com/Expensify/App/pull/34450
Action Performed:
Precondition:

Admin is in the Collect workspace.
"Prevent Self-Approval" is enabled.

On OD, create a report and add an expense to it.
Copy the report ID n OD, and paste it after https://staging.new.expensify.com/r/
On ND, submit and approve the report.

Expected Result:
Admin will be prevented from submitting and approving the report as indicated by this line " Looks like you're submitting to yourself. Approving your own reports is forbidden by your policy." in Next step message.
Actual Result:
Admin is able to submit and approve their own report when "Prevent Self-Approval" is enabled.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/c7f8eac7-58cb-42fd-b4d4-6d600106f602
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~011beabd7ddef2a97c
Upwork Job ID:<PHONE_NUMBER>623985664
Last Price Increase: 2024-02-20
Automatic offers:

alitoshmatov | Reviewer | 0
barros001 | Contributor | 0

Issue OwnerCurrent Issue Owner: @kevinksullivan

We think that this bug might be related  #wave7-collect-approvers
CC @RachCHopkins

Proposal
Please re-state the problem that we are trying to solve in this issue.
We are able to approve reports in newdot when we configured on old dot to now allow this.
What is the root cause of that problem?
We are not using the logic
isPreventSelfApprovalEnabled && isSelfApproval  to decide whether or not to disable to approval action. We are using this condition however to decide whethhr or not to show the information that its not allowed.
What changes do you think we should make in order to solve the problem?
We can use the condition that determines isPreventSelfApprovalEnabled && isSelfApproval to disable to approval of the report. The back end is catching this error however we should prevent the user action.
We can additionally decide to just remove the approval button as well if this condition is met.
The conditions that determine the rendering of the button is found here:
https://github.com/Expensify/App/blob/19e28491a92d2ea74b85b73b86aad1f2f3e06174/src/components/SettlementButton.tsx#L36
What alternative solutions did you explore? (Optional)

@jeremy-croff Thank you for your proposal. There is not much details in your proposal and you are only suggesting to disable approve button whereas in OP expected result is to prevent user from submitting proposal to themself when self approving is disabled.

@barros001 Thank you for your proposal. Did you mean to say isAllowedToSumitDraftExpenseReport instead of isAllowedToApproveDraftExpenseReport? Other than that I do agree with your approach, but still we have to also disable approve button for cases where prevent self approval is disabled after submitting report.

So it looks like I have the steps for approval, and @barros001 for submit. And we need a combination of both.

We can go with @barros001 's proposal
@barros001 One note, can't we just not show approve button?
C+ reviewed 🎀 👀 🎀

I was meaning whole button with dropdown. But let's see what @lakchote thinks about it

Couple notes

it should be isAllowedToSubmitDraftExpenseReport instead of isAllowedToSumitDraftExpenseReport
I'm not a fan of hiding the whole Approve button with dropdown entirely. I'd prefer to make it disabled to inform the user the action is not possible, instead of making him wondering where did the button go.

Thanks @alitoshmatov for reviewing.
@barros001's proposal LGTM.

@barros001 when does the PR will be up do you think? Thanks!

The PR went into production in 27th of march, only payment is left.
https://github.com/Expensify/App/issues/38889 - This issue was also related. Not sure if we are going to treat it as regression and apply penalty here

I'd say it's not a regression and more of an edge case that wasn't properly handled.
Thoughts @kevinksullivan?

@kevinksullivan Friendly bump

DMed @kevinksullivan to make sure this is not missed.

Sorry for the delay, I missed this.

had to create a new job @barros001 @alitoshmatov . Lmk when you accept
https://www.upwork.com/ab/applicants/1793302649633525760/job-details

paid @barros001

Accepted the offer

@kevinksullivan Bump

Contributor: @barros001 paid $500 via Upwork (by Kev, as mentioned above)
Contributor+: @alitoshmatov paid $500 via Upwork
This looks like a bug we'd want a regression test for, do you agree @alitoshmatov ? IF so, please fill out the BZ checklist below.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@] Determine if we should create a regression test for this bug.
[ ] [@] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@BZ] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/28998
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/28998/files#r1650175146
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need
Determine if we should create a regression test for this bug. No need

@mallenexpensify Completed the checklist

Are we should we don't want a regression test for this? It was a bug that didn't come from an existing regression test.
@alitoshmatov can you provide reasoning why you don't think we need?
@lakchote , what do you think? Here's the PR

Disable Submit/Approve buttons when self approving is disabled and user is trying to self approve

Waiting for @alitoshmatov response here

@mallenexpensify I think regression tests created in this https://github.com/Expensify/App/issues/28771 should be sufficient.

@mallenexpensify Yep, we'll have to create a new one. The test steps given in the PR description https://github.com/Expensify/App/pull/34450 look comprehensive enough to me. Let me know if you need any help with those.

Based on this comment I think existing regression test steps are the same as test steps in https://github.com/Expensify/App/pull/34450 which caught this issue as OP states:

Issue found when executing PR https://github.com/Expensify/App/pull/34450

Thanks @alitoshmatov , I agree, closing
TR GH is here - https://github.com/Expensify/Expensify/issues/372499
Section is likely this one (there are many)


Media queries should be in em not rem

Since all media queries level one units are relative to the root element, setting the media queries in rems instead of ems, is useless and reduces the support for media queries in browsers like safari 5 (which do support rems but not in media queries)

Desktop Safari also has issues with rem in media queries. em are a safer choice: https://danburzo.ro/media-query-units/#the-trouble-with-safari-again-:~:text=The trouble with Safari (again)


properties of visualizers: separate control of optionality and indentation

This concerns how the properties of a visualizer are displayed to the user (currently in a dialog box).  Currently, making a property optional (its existence dependent on some other property) automatically indents it.  But in some cases we want to separate these.
See comment on PR 230 for an example.  That visualizer should be fixed once this is available.

Is this still an issue in ui2? If so, this should be implemented for beta, if not alpha. Putting a beta milestone for now.


[Bug] On premise error Ensure that the effective permissions are included in shared data.

Describe the bug
After installing the extension, going to the hub show nothing.
Only Projects list is fetched correctly, Repositories is empty.
To Reproduce
Steps to reproduce the behavior:

Install the extension
Go to Pull Request Manager Hub
See error

Expected behavior
List of PRs.
Screenshots
(won't really help)

Desktop:

OS: Windows 10 Pro 2004
Browser: Edge 89.0.774.63 (Official build) (64-bit)

Azure DevOps

Type: On premise
Version: 2020 Dev18.M170.6 (18.170.30525)
Auth type: basic
Extension version: 2.20210403.1

Additional context
Console logs:

Failed to set referrer policy: A policy specified by a meta element must contain only one token. The referrer policy has been left unchanged. VM3009 {PrjectName}:formatted
ms.vss-web.platform-content.es6.T1WfB1Bq6sDuC5Cr.min.js:1 No permissions found for security namespace '2e9eb7ed-3c0a-47d4-87c1-0ffdd275fd87' and token 'repoV2/98bddb60-ddf8-4e5f-ab96-7a05c94ae30d/4c58260d-5440-4934-965a-838f34ef241a/'. Ensure that the effective permissions are included in shared data. ms.vss-web.platform-content.es6.T1WfB1Bq6sDuC5Cr.min.js:formatted at L4555
Failed to load resource: the server responded with a status of 404 (Not Found) targeting: https://something.com/tfs/_apis/public/gallery/publisher/caribeiro84/extension/pull-request-manager-hub/2.20210403.1/assetbyname/build/[object%20Module]

Hi @Herve-M
Do you have any disabled repo? If so, try to Re-enable it again to check if the issues goes away. I've released this new version to fix this issue but it seems for OnPrem it didn't work. Please confirm if the above approach works.
Thanks a lot

We do not have any disabled repos and are seeing the same issue.

We are also having the same issue this morning. There is no way to roll back to a previous version of the extension either, so we have currently uninstalled this extension. :(

It's not clear for me what's the error itself. Those errors you mentioned seems to be an issue to load resources that drives me to an assumption of browser cache. Would you be able to clear the cache of your browser or try with Private Tab?
If you could provide more details (if exists) in the console tab from your developer tools (F12) window would be great.

@cribeiro84
We are seeing the same issue this morning. When you say disabled repo, you mean any project that has this feature disabled?

We do have one project with that flag disabled. I re-enabled it but it didn't have any effect on the issue.

About this disabled repo, I meant in the Repositories management where you can disable an individual repo, like:

@cribeiro84 You cannot disable repositories on-prem. (At least I cannot find a way)

Using Private Window in Firefox has no effect on the outcome.

Some PRs are listed in the PR tab

@cribeiro84 Repositories list in the filter is empty

Thanks for sharing more details. Would you be able to take a screenshot or to capture the console log entries (errors and logs)? Unfortunately, I don't have an OnPrem instance to test it.

@cribeiro84 Repositories list in the filter is empty

Is there a way for you to check on the Network tab the request to "Repositories" API? It should end like: /_apis/git/Repositories?includeLinks=true

Is there a way for you to check on the Network tab the request to "Repositories" API? It should end like: /_apis/git/Repositories?includeLinks=true

The response looks good on my side too. The json contains all the repos of the currently selected projects in the filter. However, I'm unable to change the project filters. After clicking a checkbox or two, you get this in the console:

Our repository data is also present/listed in the 200 response from the GET /git/Repositories call.

I don't think the problem is this 404 object/error because the APIs are being called and it's getting the results. This asset error might be related to an image for No PRs screen which is not being found.
It's not clear why the result is not being well handled. Do you have more than 1 project within the same instance? If so, are you able to select different project?

We only have one active TeamProject (it is the only one with PRs) but we have 3 other TeamProjects in the TPC and they do show up in the Projects filter list.

Got it! Just one thing that came up to my mind. Can you check if in the response from Repositories API call if there is an attribute called "isDisabled" that should be equal to false? I indeed did a change in the last release that could've broken for you in case this attribute doesn't exist at all in OnPrem versions.

There is a list of [object] that I've expanded one example of. Each [Object] seems to be a repository list item. There is no property on the list item of "isDisabled" that I can find.

I'm not seeing the field either on my onPrem environment.

Here's the response from my personal Azure Devops Services

I just released a new version with a possible fix. Can you try again to use the extension?

:(

Would you be able to fork/checkout this repo and debug from your OnPrem instance? I can assign you to a dev/test extension I have for development purposes to allow you to debug it. I would need your account/org name.

@cribeiro84 Sadly as agileramblings said, OnPremise don't have the feature of disabling a repository yet.
Questions:

I don't see any contribution  in the manifest, maybe it could lead to permission problems?
I found this issue (stack) but no real fix.

I got it debugging. Your instructions in the README were very helpful :+1:
No dice:

With filter commented out (this works)

Did a git bisect 78bb434 origin/main just to make sure the bad commit was the isDisabled introduction and it is:
$ git bisect good
d7cdc2a7729ab02a2280b4be90ba618dc327db15 is the first bad commit
commit d7cdc2a7729ab02a2280b4be90ba618dc327db15
Author: Carlos Alessandro Ribeiro<EMAIL_ADDRESS>Date:   Fri Apr 2 20:35:05 2021 -0300

    Bugfix/ignore disabled repos (#178)

    * Fixing isDisabled repos

    * trying to fix dependency tree

    * Fix for unselected proejcts on load PR manager without filter.

    * Trying to fix broken links

    Co-authored-by: Carlos Alessandro Ribeiro<EMAIL_ADDRESS>
 package-lock.json               | 32539 +++++++++++++++++++++++++++++++-------
 package.json                    |    12 +-
 src/models/PullRequestModel.tsx |     5 +
 src/tabs/PullRequestsTab.tsx    |   112 +-
 4 files changed, 26614 insertions(+), 6054 deletions(-)

Then I realized you just got your boolean logic bungled! On Server 2020, r.isDisabled !== undefined will always return false.
We want to keep all repos where the property is undefined or not disabled. If the API ever starts returning it, then it'll be fine.
const repos = (await this.gitClient.getRepositories(projectId, true) as GitRepositoryModel[]).filter(r => r.isDisabled === undefined || r.isDisabled === false);
Voila

See my PR!

Thanks @InKahootz for the PR! It has been released and hopefully it's now fixed! Thank you so much for the contribution!

@cribeiro84 / @InKahootz  Still have the issue with the last update, 2.20210405.1 :/

That's an older version, or at least is should be. 2.20210405.1 is for commit efa6a6a.
The latest is 2.20210406.1. Might take a little bit to show up but the pipeline showing that it was built and pushed is here:
https://dev.azure.com/caixaazul/Pull Request Manager Hub/_build/results?buildId=226&view=results

It is working now guys! Great work!! Thanks for a great extension @cribeiro84

Amazing! Thank all of you for raising the issues and PR! Thanks @InKahootz for the contribution
Don't forget to rate the extension in the marketplace that helps to get more contributions ;-)

i am facing same problem again,


Homebrew Release Process

Homebrew Release Process
We are utilizing Goreleaser to cut releases for Lula. Goreleaser uses a .goreleaser.yaml config file that sets up the release for GitHub and for Homebrew.
Issue
Currently we are unable to split the Goreleaser config in a way that will allow us to use multiple steps in CI to one create the release binaries and release for GitHub and second step to push the binaries into our homebrew-tap repo.
We are using GitHub App to provide access to the homebrew-tap repo by creating a token to pass to Goreleaser to access that repo. To push the releaser binaries and release to GitHub we are using a separate token that has access to the repo. GitHub Apps currently do not provide a way to split the permissions up to allow us to use the GitHub App to do both.
Possible Solution
A possible solution could be to use Pro Goreleaser which can provide us with the templates functionality. Using templates we could have essentially two configs that could allow us to split CI up into two stages so we can use split permissions to accomplish our tasks using least privilege.
There may also be other solutions or processes that could work for our use case too.
### Tasks
- [x] Decide on process to release to our homebrew-tap
- [x] Implement the process for releasing to our homebrew-tap
- [x] Test implementation to ensure proper functionality
- [x] Update documentation to explain the homebrew release process

Completed as a part of https://github.com/defenseunicorns/lula/pull/319


fix: List all shapes available for a given annotation.

Fixes #638
An annotation may contain files that represent multiple different annotation shapes, we should list all unique shape types available for an annotation. This produces a result like so:

iirc, according to the original design, we should have an individual record for each shape type.

iirc, according to the original design, we should have an individual record for each shape type.
Our schema design supports multiple shapes per annotation, probably intentionally?

iirc, according to the original design, we should have an individual record for each shape type.

Our schema design supports multiple shapes per annotation, probably intentionally?

Yes, that is correct. We should be able to support a single annotation with multiple different shapes.

iirc, according to the original design, we should have an individual record for each shape type.

Our schema design supports multiple shapes per annotation, probably intentionally?

Yes, that is correct. We should be able to support a single annotation with multiple different shapes.

You're saying the UI needs to draw a whole new row for each shape instead of listing multiple shapes on one row?


[Fix #9836] Fix incorrect corrections for Layout/HashAlignment when a kwsplat node is on the same line as a pair node with table style

Keyword splats were previously treated as pairs using colon style, which some hacks in the Alignment classes to handle them (see #3919). However, this did not account for all possibilities and would cause previous pairs on the same line as the kwsplat to be removed by autocorrection.
Instead, now a special KeywordSplatAlignment type was added to handle kwsplats. The previously behaviour about kwsplats was retained (they will still be aligned with the beginning of the rest of the hash, regardless of enforced style), and the hacks in KeyAlignment and TableAlignment for kwsplats were removed.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Looks solid. Thanks!


support flatlist

+1

ok, will support in the coming days.
or you can pull request.

@gyf19 already support FlatList


Privdrop is needed for OpenBSD if one desires to run it on port 53.

Right now dnscrypt-proxy does not have a privsep/privdrop/chroot mechanism. I made a small quick and dirty patch. This allows me to run it on the default port (53) with dropped permissions (not as root) on OpenBSD. However dnscrypt-proxy downloads the server list file (as root) as one of the first things it does before binding. The download should somehow happen only after a privdrop/chroot for security reasons. Talking to the network as root, subsequent permission issues, etc... It would take a substantial amount of work to rework it to download the file(s) after a privdrop/chroot. Otherwise it's great! Thank you for this new version. I hope it will get proper privdrop eventually so we can enjoy it on the default port on the BSDs with chroot.
dnscrypt-proxy-privdrop.patch.txt

Unfortunately, it isn't safe to do so: https://github.com/golang/go/issues/1435
fork+execute is a better approach, but passing the descriptors also seem tricky in Go.
pledge() is natively supported, though: https://go.googlesource.com/sys/+/8fd966b47dbdd4faa03de0d06e3d733baeb9a1a9^!/ -- maybe something we can use on OpenBSD.

Threads disrespecting privdrop changes seems to be a linux only issue. I could wrong, but I didn't see any threads continuing to run as root on OpenBSD.

Maybe, but this is not something that can be merged, unless it works as expected on all platforms, including Linux, Android, iOS and Windows.

I also wonder if it's possible to move the initial server list downloads into a separate process that can run privdropped in go? I guess BSDs could apply their own privdrop patches in packages, but the download part would result in a complete rewrite I think.


Linking error IOs

I installed the firebase messaging pod with no problems, after linking I got the following build error. I am unable to post my project publicly, but can email it to you if required.

"dependencies": {     "firebase": "^3.4.0",     "moment": "^2.15.1",     "react": "15.3.2",     "react-native": "0.34.0",     "react-native-fcm": "^2.2.0",     "react-native-vector-icons": "^2.1.0",     "react-redux": "^4.4.5",     "redux": "^3.6.0",     "redux-thunk": "^2.1.0"   }
pod 'Firebase'   pod 'Firebase/Messaging'

If you have installed firebase before updating please run pod update o  your ios project. I had this problem after updating, and the reason of the error was because I did not update my Firebase files.
Also check the AppDelegate.h and AppDelegate.m if they have been configured as it is described in the documentation.
I hope it helps.

I've switched to manually installing the firebase sdk and my issues resolved. I have quite a few issues with cocoa pods not working well with RN, it's a shame as its so handy.


Fixed negative tests baseline(calcite changes)

@Agirish, please review

Delete both the tests instead?

+1. Thanks Prasad.


feat: Add go.work file

Add a go.work file that lists all (current) modules in the repo.
This is an experiment to reduce unnecessary testing when modifying a single
module/package.

I'm going to close this, since I do not think this is costing us much beyond slightly messy go.mod files.


Port to Android

Changes proposed in this PR

Add a FILEPointer type alias, as FILE is an opaque struct since Android 7.
Add Android to existing OS specializations where needed.
Convert to mode_t in FIleManager+ZIP for Android armv7, where mode_t is narrower than st_mode.

Tests performed
I ran swift test on both linux x86_64 and Android AArch64 with this pull and all tests passed.
Further info for the reviewer
I used this pull when porting CookCLI as a package for Android, termux/termux-packages#11081. I used a similar typealias when porting apple/swift-tools-support-core#243 for Android last year.
Open Issues
None

Nice - thanks for the PR.
How do you execute the test suite on Android?
If we add Android as supported platform, I'd like to add a GitHub workflow for that.

Anything holding this up?

Merged - Thanks for contributing Android support!


google signin not working - gitpod

Describe the bug
Google signin in Gitpod not working
To Reproduce
Steps to reproduce the behavior:

Run gitpod on browser.
In launch window, go to signin.
Click on google sign-in.

Expected behavior
Successful signin
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

Gitpod

Additional context

Are you working on this issue? (Yes/No)
No.

gitpod bash :
Started GET "/users/auth/google_oauth2" for <IP_ADDRESS> at 2019-11-05 23:54:28 +0000 Cannot render console from <IP_ADDRESS>! Allowed networks: <IP_ADDRESS>, ::1, <IP_ADDRESS>/<IP_ADDRESS> I, [2019-11-05T23:54:28.666565 #25702]  INFO -- omniauth: (google_oauth2) Request phase initiated.

We will have to add documentation for how to configure fb and Google integration in gitpod and localhost


LICENSE: use MIT and attribute to 'The Clightningjs developers'

This was attributing myself in my own name, but @rsbondi conotributed too and others hopefully will now that it's part of the lightningd org!
Ping @rsbondi, as this change happens after your first contribution i'd like you to -if you agree- explicitly ACKknowledge it.

ACK


update image to v2.6.2

v2.6.1 will suffer from graphd crashing when host OS is in cgroupv2.

If you're familiar with helm charts, update helm charts together?

done on .Values.nebula.version changing to 2.6.2


Fix skit-verify if syntax

Saw this error happening:

https://cloud.ibm.com/devops/pipelines/tekton/d878b6ff-24a4-4736-a341-eb3e32bef226/runs/0d716c88-48a9-4022-a904-feb7a0aa4a8a/cf-skit-verify-alert-register/experience-test?env_id=ibm:yp:us-south
This was the culprit, here is PipelineRun with this small change:
https://cloud.ibm.com/devops/pipelines/tekton/d878b6ff-24a4-4736-a341-eb3e32bef226/runs/04c8553b-7ae7-45f7-8ab1-330fe7de9ab9/set-pr-status-pipeline-pending/fetch-git-information?env_id=ibm:yp:us-south


"idsvr" or "idsrv"?

I was going through the Constants.cs file and found that some of the strings and variables are called "idsvr" and some are called "idsrv". I then searched through the entire repo and found some other places. It seems that "idsrv" is more used than "idsvr"
Is this a typo or is there a reason for it?

that's a typo. we'll fix it.

"idsvr" is the right one.

maybe we should rename that to local?

for the idp i mean

I'm ok with that.

done on dev


Preffix and Suffix problem

Description
The server will incredibly lag and crash. Putting some prefix error on consle.
Reproduction Steps
idk
Expected Behaviour
no crash
Server Details
git-Paper-140
LuckPerms Version
LuckPerms-Bukkit-5.3.86
Logs and Configs
https://pastebin.com/E3f7jPyX
Extra Details
No response

Hi,
Those permission lag notice errors just mean that the server is lagging so it is taking longer for plugins to communicate with each other to receive player data. There isn't really anything we can do plugin side. It's more upto you to reduce or solve the lag that is happening on your server.

Idk, how... Start happening some days ago... With 2-4 players. I have 3 CPUs and 4GB ram. But thanks for answer.

There are many things that can cause your server to lag. A good idea would be to review a timings or spark report so you can see what is happening and help narrow down where the lag is coming from.

Im new with VPS, linux and staf. Idk how to get spark report. I will try to google that. Thanks for help!


Issue with Discord docs

subscript and superscript were added

Just found out it was only subscript, not superscript

nevermind it was shown as no why I thought it didn't exist but it was further down. Maybe add a yellow text saying "special"


Cloud REST API: Updated user properties are not propagated

Cloud REST API: Updated user properties are not propagated.
I updated the evalDaysLeft property for a user via the REST API and verified the success by another users data poll.
I expected the db.cloud.currentUser observable to trigger an event after the update, but this was not the case.
After logging out, logging in the same user the new evalDaysLeft value was visible.
All changes made by the REST API should be propagated right away.

Hi! Unlike other application data, properties on the users are not designed to be eagerly propagated. The reason is that the data comes from the token which is normally fetched once an hour. The use case where evalDaysLeft reaches 0 and the client goes into offline mode would not benefit of that anyway since it wouldn't have a websocket connection to the server.
If an expired evaluation user is lifted to prod or gets and increased evalDaysLeft, the client would need to either reload the application or call db.cloud.sync() to actively refresh the token and get the new license properties. Expired user will always get their token refreshed when db.cloud.sync() is explicitely called. This behavior should make sure that the application can provide a button or flow to actively update the license status after user has been purchasing a license from the app vendor or in other ways become informed that they got an extended license.

Thank you for the explanation.


Added functionality for searching and made loading speed of index.js of allcontributer fast

Please merge the code as soon as possible.
Thanks,
Regards

Great job man! @Satvik1769

Thanks @Rajdip019


Remove unused using declaration

std::sort in heap-profiler.cc is not in use, so remove it.

Applied. Thanks.


Rename experimental.nodeLabels to controller.nodeLabels

Closes #578
This is verified manually by running E2E

Codecov Report

Merging #755 into master will decrease coverage by 0.05%.
The diff coverage is 25%.

@@            Coverage Diff             @@
##           master     #755      +/-   ##
==========================================
- Coverage   34.28%   34.23%   -0.06%
==========================================
  Files          55       55
  Lines        3077     3079       +2
==========================================
- Hits         1055     1054       -1
- Misses       1863     1866       +3
  Partials      159      159

Impacted Files
Coverage Δ

model/node_pool_config.go
20.28% <ø> (ø)
:arrow_up:

model/controller.go
0% <0%> (ø)
:arrow_up:

core/controlplane/config/config.go
54.46% <100%> (-0.06%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a693ab...50de1e4. Read the comment docs.

/lgtm

@danielfm Thanks for your review 👍


fixes to docs

Current coverage is 96.84% (diff: 100%)

Merging #1575 into master will increase coverage by <.01%

@@             master      #1575   diff @@
==========================================
  Files            88         88
  Lines         10670      10670
  Methods           0          0
  Messages          0          0
  Branches       1818       1818
==========================================
+ Hits          10332      10333     +1
  Misses          194        194
+ Partials        144        143     -1

Powered by Codecov. Last update 49eccfc...fe7237d


The app pauses for a second when deleting a block

Fixed, I think this was to let voiceover finish speaking


Vectorization of boolean arrays

Builds on #852.
Adds support for vectorization of bitwise protocols, and adds vectorized version of compare_gt (used by quicksort).
Unvectorized bitwise protocols operate on AdditiveShare<BA>, as before (bits of the BA are different bits of multi-bit values associated with a particular record). Vectorized bitwise protocols operate on BitDecomposed<AdditiveShare<BA>>, where the elements of the outer BitDecomposed are different bits of multi-bit values associated with a particular record, and bits of the inner BA are the values of a particular bit position for a stripe of records. Adds an ArrayAccessRef variant of the ArrayAccess trait that is implemented for both kinds of inputs, and an ArrayBuilder trait that is implemented for both kinds of outputs.
Performance
compare_gt benchmark. Generates 131,072 64-bit values and compares each of them to a single 64-bit threshold. This is a proxy for quicksort.

Unvectorized: 39.6 s 🐢
Vectorized x256, bitvec version (what is in this PR): 320 ms
Vectorized x256, raw array version (see #928): 200 ms
Vectorized x1024, raw array version: 100 ms
Vectorized x4096, raw array version: 84 ms 🔥

Vectorized x4096, raw array version: 84 ms 🔥

this is just awesome


Tray title fix

https://github.com/DevilXD/TwitchDropsMiner/pull/486

Looks okay, but the logic seems to be a little bit whacky. You don't need more than a single set of the formatted strings, if you precalculate the expected lengths beforehand. The trimming cases should then be something like this:

If it's too long, drop the self.TITLE filler first, as that never changes and can be omitted when needed.
If it's still too long, shorten the drop name, then game name.

A better approach would be a system that'd do some intelligent trimming, as the most important part of drop names is usually at the very end, not the start. But that can be left for another time.
This change is probably the easiest to implement out of all of them, and I'll get to it first when I finally will be able to, unless this gets merged beforehand of course.

The way it's written makes it readable and makes changes easier.
I think the title should either always or never be there for consistency.
It does trim the end of names, leaving the drop name at least 30 chars long.


Error latest version 1.0.0

latest.log

[02:29:57] [main/INFO]: Loading tweak class name net.minecraftforge.fml.common.launcher.FMLTweaker
[02:29:57] [main/INFO]: Using primary tweak class name net.minecraftforge.fml.common.launcher.FMLTweaker
[02:29:57] [main/INFO]: Calling tweak class net.minecraftforge.fml.common.launcher.FMLTweaker
[02:29:57] [main/INFO]: Forge Mod Loader version <IP_ADDRESS>54 for Minecraft 1.12.2 loading
[02:29:57] [main/INFO]: Java is Java HotSpot(TM) 64-Bit Server VM, version 1.8.0_51, running on Windows 10:amd64:10.0, installed at C:\Users\Zanoza\Twitch\Minecraft\Install\runtime\jre-legacy\windows-x64\jre-legacy
[02:29:58] [main/INFO]: Searching C:\Users\Zanoza\Twitch\Minecraft\Instances\Multiblock Madness\mods for mods
[02:29:58] [main/INFO]: Searching C:\Users\Zanoza\Twitch\Minecraft\Instances\Multiblock Madness\mods\1.12.2 for mods
[02:29:58] [main/WARN]: Found FMLCorePluginContainsFMLMod marker in AdvancedRocketry-1.12.2-1.7.0-240-universal.jar. This is not recommended, @Mods should be in a separate jar from the coremod.
[02:29:58] [main/WARN]: The coremod AdvancedRocketryPlugin (zmaster587.advancedRocketry.asm.AdvancedRocketryPlugin) is not signed!
[02:29:58] [main/WARN]: Found FMLCorePluginContainsFMLMod marker in Apotheosis-1.12.2-1.12.5.jar. This is not recommended, @Mods should be in a separate jar from the coremod.
[02:29:58] [main/WARN]: The coremod ApotheosisCore (shadows.ApotheosisCore) is not signed!
[02:29:58] [main/WARN]: Found FMLCorePluginContainsFMLMod marker in AppleCore-mc1.12.2-3.4.0.jar. This is not recommended, @Mods should be in a separate jar from the coremod.
[02:29:58] [main/WARN]: The coremod AppleCore (squeek.applecore.AppleCore) is not signed!
[02:29:58] [main/INFO]: Loading tweaker org.spongepowered.asm.launch.MixinTweaker from arcanearchives-<IP_ADDRESS>-mixins8.jar
[02:29:58] [main/WARN]: Found FMLCorePluginContainsFMLMod marker in astralsorcery-1.12.2-1.10.27.jar. This is not recommended, @Mods should be in a separate jar from the coremod.
[02:29:58] [main/WARN]: The coremod hellfirepvp.astralsorcery.core.AstralCore does not have a MCVersion annotation, it may cause issues with this version of Minecraft
[02:29:58] [main/INFO]: [AstralCore] Initialized.
[02:29:58] [main/INFO]: Loading tweaker guichaguri.betterfps.tweaker.BetterFpsTweaker from BetterFps-1.4.8.jar
[02:29:58] [main/WARN]: Found FMLCorePluginContainsFMLMod marker in botaniatweaks-1.9.1.jar. This is not recommended, @Mods should be in a separate jar from the coremod.
[02:29:58] [main/WARN]: The coremod Botania Tweaks Core (quaternary.botaniatweaks.asm.BotaniaTweakerPlugin) is not signed!
[02:29:58] [main/INFO]: Loading tweaker codechicken.asm.internal.Tweaker from ChickenASM-1.12-<IP_ADDRESS>.jar
[02:29:58] [main/WARN]: Found FMLCorePluginContainsFMLMod marker in CreativeCore_v1.10.47_mc1.12.2.jar. This is not recommended, @Mods should be in a separate jar from the coremod.
[02:29:58] [main/WARN]: The coremod com.creativemd.creativecore.core.CreativePatchingLoader does not have a MCVersion annotation, it may cause issues with this version of Minecraft
[02:29:58] [main/WARN]: The coremod CreativePatchingLoader (com.creativemd.creativecore.core.CreativePatchingLoader) is not signed!
[02:29:58] [main/WARN]: Found FMLCorePluginContainsFMLMod marker in CTM-MC1.12.2-<IP_ADDRESS>.jar. This is not recommended, @Mods should be in a separate jar from the coremod.
[02:29:58] [main/WARN]: The coremod team.chisel.ctm.client.asm.CTMCorePlugin does not have a MCVersion annotation, it may cause issues with this version of Minecraft
[02:29:58] [main/WARN]: The coremod CTMCorePlugin (team.chisel.ctm.client.asm.CTMCorePlugin) is not signed!
[02:29:58] [main/WARN]: Found FMLCorePluginContainsFMLMod marker in cxlibrary-1.12.1-1.6.1.jar. This is not recommended, @Mods should be in a separate jar from the coremod.
[02:29:58] [main/WARN]: The coremod cubex2.cxlibrary.CoreModLoader does not have a MCVersion annotation, it may cause issues with this version of Minecraft
[02:29:58] [main/WARN]: The coremod CXLibraryCore (cubex2.cxlibrary.CoreModLoader) is not signed!
[02:29:58] [main/WARN]: Found FMLCorePluginContainsFMLMod marker in engineers_doors-1.12.2-0.9.1.jar. This is not recommended, @Mods should be in a separate jar from the coremod.
[02:29:58] [main/WARN]: The coremod EngineersDoorsLoadingPlugin (nihiltres.engineersdoors.common.asm.EngineersDoorsLoadingPlugin) is not signed!
[02:29:58] [main/WARN]: Found FMLCorePluginContainsFMLMod marker in EntityCulling-1.12.2-4.1.1.jar. This is not recommended, @Mods should be in a separate jar from the coremod.
[02:29:58] [main/WARN]: The coremod EntityCullingPlugin (meldexun.entityculling.plugin.EntityCullingPlugin) is not signed!
[02:29:58] [main/WARN]: Found FMLCorePluginContainsFMLMod marker in fluiddrawers-1.12.2-1.0.5.jar. This is not recommended, @Mods should be in a separate jar from the coremod.
[02:29:58] [main/WARN]: The coremod xyz.phanta.fluiddrawers.coremod.FluidDrawersCoreMod does not have a MCVersion annotation, it may cause issues with this version of Minecraft
[02:29:58] [main/WARN]: The coremod FluidDrawersCoreMod (xyz.phanta.fluiddrawers.coremod.FluidDrawersCoreMod) is not signed!
[02:29:58] [main/WARN]: Found FMLCorePluginContainsFMLMod marker in foamfix-0.10.11-1.12.2.jar. This is not recommended, @Mods should be in a separate jar from the coremod.
[02:29:58] [main/WARN]: The coremod pl.asie.foamfix.coremod.FoamFixCore does not have a MCVersion annotation, it may cause issues with this version of Minecraft
[02:29:58] [main/WARN]: Found FMLCorePluginContainsFMLMod marker in ForgeEndertech-1.12.2-<IP_ADDRESS>-build.0561.jar. This is not recommended, @Mods should be in a separate jar from the coremod.
[02:29:58] [main/WARN]: The coremod com.endertech.minecraft.forge.coremod.CorePlugin does not have a MCVersion annotation, it may cause issues with this version of Minecraft
[02:29:58] [main/WARN]: The coremod CorePlugin (com.endertech.minecraft.forge.coremod.CorePlugin) is not signed!
[02:29:58] [main/WARN]: Found FMLCorePluginContainsFMLMod marker in Forgelin-1.8.4.jar. This is not recommended, @Mods should be in a separate jar from the coremod.
[02:29:58] [main/WARN]: The coremod net.shadowfacts.forgelin.preloader.ForgelinPlugin does not have a MCVersion annotation, it may cause issues with this version of Minecraft
[02:29:58] [main/WARN]: The coremod ForgelinPlugin (net.shadowfacts.forgelin.preloader.ForgelinPlugin) is not signed!
[02:29:58] [main/WARN]: Found FMLCorePluginContainsFMLMod marker in HammerLib-1.12.2-<IP_ADDRESS>.jar. This is not recommended, @Mods should be in a separate jar from the coremod.
[02:29:58] [main/WARN]: Found FMLCorePluginContainsFMLMod marker in HardcoreDarkness-MC1.12.2-2.0.jar. This is not recommended, @Mods should be in a separate jar from the coremod.
[02:29:58] [main/WARN]: The coremod lumien.hardcoredarkness.asm.LoadingPlugin does not have a MCVersion annotation, it may cause issues with this version of Minecraft
[02:29:58] [main/WARN]: Found FMLCorePluginContainsFMLMod marker in iceandfire-1.9.1-1.12.2.jar. This is not recommended, @Mods should be in a separate jar from the coremod.
[02:29:58] [main/WARN]: The coremod iceandfire (com.github.alexthe666.iceandfire.asm.IceAndFirePlugin) is not signed!
[02:29:58] [main/WARN]: Found FMLCorePluginContainsFMLMod marker in InventoryTweaks-1.63.jar. This is not recommended, @Mods should be in a separate jar from the coremod.
[02:29:58] [main/WARN]: The coremod invtweaks.forge.asm.FMLPlugin does not have a MCVersion annotation, it may cause issues with this version of Minecraft
[02:29:58] [main/WARN]: The coremod ivorius.ivtoolkit.IvToolkitLoadingPlugin does not have a MCVersion annotation, it may cause issues with this version of Minecraft
[02:29:58] [main/WARN]: The coremod IvToolkit (ivorius.ivtoolkit.IvToolkitLoadingPlugin) is not signed!
[02:29:58] [main/WARN]: Found FMLCorePluginContainsFMLMod marker in LittleTiles_v1.5.0-pre327_mc1.12.2.jar. This is not recommended, @Mods should be in a separate jar from the coremod.
[02:29:58] [main/WARN]: The coremod com.creativemd.littletiles.LittlePatchingLoader does not have a MCVersion annotation, it may cause issues with this version of Minecraft
[02:29:58] [main/WARN]: The coremod LittlePatchingLoader (com.creativemd.littletiles.LittlePatchingLoader) is not signed!
[02:29:58] [main/INFO]: Loading tweaker org.spongepowered.asm.launch.MixinTweaker from malisiscore-1.12.2-6.5.1.jar
[02:29:58] [main/WARN]: Found FMLCorePluginContainsFMLMod marker in Mekanism-1.12.2-<IP_ADDRESS>0.jar. This is not recommended, @Mods should be in a separate jar from the coremod.
[02:29:58] [main/WARN]: The coremod mekanism.coremod.MekanismCoremod does not have a MCVersion annotation, it may cause issues with this version of Minecraft
[02:29:58] [main/WARN]: The coremod MekanismCoremod (mekanism.coremod.MekanismCoremod) is not signed!
[02:29:58] [main/INFO]: Loading tweaker org.spongepowered.asm.launch.MixinTweaker from MixinBootstrap-1.0.5.jar
[02:29:58] [main/WARN]: Found FMLCorePluginContainsFMLMod marker in NotEnoughIDs-<IP_ADDRESS>.jar. This is not recommended, @Mods should be in a separate jar from the coremod.
[02:29:58] [main/WARN]: The coremod ru.fewizz.neid.asm.Plugin does not have a MCVersion annotation, it may cause issues with this version of Minecraft
[02:29:58] [main/WARN]: The coremod Plugin (ru.fewizz.neid.asm.Plugin) is not signed!
[02:29:58] [main/WARN]: Found FMLCorePluginContainsFMLMod marker in OpenModsLib-1.12.2-0.12.2.jar. This is not recommended, @Mods should be in a separate jar from the coremod.
[02:29:58] [main/WARN]: The coremod openmods.core.OpenModsCorePlugin does not have a MCVersion annotation, it may cause issues with this version of Minecraft
[02:29:58] [main/WARN]: The coremod OTGCorePlugin (com.pg85.otg.forge.asm.excluded.launch.OTGCorePlugin) is not signed!
[02:29:58] [main/INFO]: Loading tweaker org.spongepowered.asm.launch.MixinTweaker from particleculling-1.12.2-v1.0.1.jar
[02:29:58] [main/INFO]: Loading tweaker org.spongepowered.asm.launch.MixinTweaker from performant-1.12.2-1.10.jar
[02:29:58] [main/WARN]: Found FMLCorePluginContainsFMLMod marker in Quark-r1.6-179.jar. This is not recommended, @Mods should be in a separate jar from the coremod.
[02:29:58] [main/WARN]: The coremod Quark Plugin (vazkii.quark.base.asm.LoadingPlugin) is not signed!
[02:29:58] [main/WARN]: The coremod com.therandomlabs.randompatches.core.RPCore does not have a MCVersion annotation, it may cause issues with this version of Minecraft
[02:29:58] [main/WARN]: Found FMLCorePluginContainsFMLMod marker in RandomThings-MC1.12.2-<IP_ADDRESS>.jar. This is not recommended, @Mods should be in a separate jar from the coremod.
[02:29:58] [main/WARN]: The coremod lumien.randomthings.asm.LoadingPlugin does not have a MCVersion annotation, it may cause issues with this version of Minecraft
[02:29:58] [main/WARN]: Found FMLCorePluginContainsFMLMod marker in ResourceLoader-MC1.12.1-1.5.3.jar. This is not recommended, @Mods should be in a separate jar from the coremod.
[02:29:58] [main/WARN]: The coremod lumien.resourceloader.asm.LoadingPlugin does not have a MCVersion annotation, it may cause issues with this version of Minecraft
[02:29:58] [main/INFO]: Loading tweaker org.spongepowered.asm.launch.MixinTweaker from Surge-1.12.2-2.0.77.jar
[02:29:59] [main/WARN]: Found FMLCorePluginContainsFMLMod marker in ThaumicAugmentation-1.12.2-2.0.13.jar. This is not recommended, @Mods should be in a separate jar from the coremod.
[02:29:59] [main/INFO]: Loading tweaker org.spongepowered.asm.launch.MixinTweaker from VanillaFix-1.0.10-150.jar
[02:29:59] [main/WARN]: The coremod blusunrize.immersiveengineering.common.asm.IELoadingPlugin does not have a MCVersion annotation, it may cause issues with this version of Minecraft
[02:29:59] [main/WARN]: The coremod IELoadingPlugin (blusunrize.immersiveengineering.common.asm.IELoadingPlugin) is not signed!
[02:29:59] [main/INFO]: Loading tweaker org.spongepowered.asm.launch.MixinTweaker from phosphor-1.12.2-0.2.6+build50-universal.jar
[02:29:59] [main/INFO]: Loading tweak class name net.minecraftforge.fml.common.launcher.FMLInjectionAndSortingTweaker
[02:29:59] [main/INFO]: Loading tweak class name org.spongepowered.asm.launch.MixinTweaker
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: java.lang.ClassFormatError: Invalid length 26 in LocalVariableTable in class file org/spongepowered/asm/launch/platform/MixinPlatformAgentFMLLegacy
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at java.lang.ClassLoader.defineClass1(Native Method)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at java.lang.ClassLoader.defineClass(ClassLoader.java:760)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at java.security.AccessController.doPrivileged(Native Method)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at net.minecraft.launchwrapper.LaunchClassLoader.findClass(LaunchClassLoader.java:106)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at java.lang.Class.forName0(Native Method)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at java.lang.Class.forName(Class.java:348)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at org.spongepowered.asm.service.mojang.MixinServiceLaunchWrapper.findClass(MixinServiceLaunchWrapper.java:304)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at org.spongepowered.asm.service.MixinServiceAbstract.getServiceAgents(MixinServiceAbstract.java:194)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at org.spongepowered.asm.service.MixinServiceAbstract.getSideName(MixinServiceAbstract.java:172)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at org.spongepowered.asm.mixin.MixinEnvironment$Side$2.detect(MixinEnvironment.java:180)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at org.spongepowered.asm.mixin.MixinEnvironment.getSide(MixinEnvironment.java:1174)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at org.spongepowered.asm.mixin.MixinEnvironment.printHeader(MixinEnvironment.java:973)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at org.spongepowered.asm.mixin.MixinEnvironment.(MixinEnvironment.java:966)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at org.spongepowered.asm.mixin.MixinEnvironment$Phase.getEnvironment(MixinEnvironment.java:152)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at org.spongepowered.asm.mixin.MixinEnvironment.getEnvironment(MixinEnvironment.java:1357)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at org.spongepowered.asm.mixin.MixinEnvironment.init(MixinEnvironment.java:1336)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at org.spongepowered.asm.launch.MixinBootstrap.start(MixinBootstrap.java:148)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at org.spongepowered.asm.launch.MixinTweaker.(MixinTweaker.java:46)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at java.lang.reflect.Constructor.newInstance(Constructor.java:422)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at java.lang.Class.newInstance(Class.java:442)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at net.minecraft.launchwrapper.Launch.launch(Launch.java:98)
[02:29:59] [main/INFO]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at net.minecraft.launchwrapper.Launch.main(Launch.java:28)

Did you figure it out?


Replacing tomcat-jdbc with HikariCP?

I'm wondering if we should migrate the default dropwizard-db implementation to https://github.com/brettwooldridge/HikariCP?
There are a few implementations of this already as bundles:

https://github.com/mtakaki/dropwizard-hikaricp
https://github.com/DeloitteDigitalUK/dropwizard-hikaricp
https://github.com/saem/dropwizard-hikaricp

I'll have to test this myself before suggesting it again.  The benchmarks on https://github.com/mtakaki/dropwizard-hikaricp don't paint it too highly (which seems suspect to me).


Memory error

1. What version of Caddy are you running (caddy -version)?
0.9.4 (armhf)
2. What are you trying to do?
accessing my site
3. What is your entire Caddyfile?
abctheater.be, www.abctheater.be {
	root /var/www/abc
	 fastcgi /  /var/run/php/php7.0-fpm.sock php
	rewrite {
        	to {path} {path}/ /index.php?{query}
    	}

}

4.  What did you expect to see?
site loading
6. What did you see instead (give full error messages and/or log)?
500 internal error
in journal:
Dec 25 17:52:34 maartje-tm caddy[11746]: 2016/12/25 17:52:34 [PANIC] runtime error: invalid memory address or nil pointer dereference
Dec 25 17:52:34 maartje-tm caddy[11746]: 2016/12/25 17:52:34 [PANIC] runtime error: invalid memory address or nil pointer dereference
Dec 25 17:52:36 maartje-tm caddy[11746]: 2016/12/25 17:52:36 [PANIC] runtime error: invalid memory address or nil pointer dereference
Dec 25 17:52:36 maartje-tm caddy[11746]: 2016/12/25 17:52:36 [PANIC] runtime error: invalid memory address or nil pointer dereference
Dec 25 17:52:44 maartje-tm caddy[11746]: 2016/12/25 17:52:44 http2: server: error reading preface from client <IP_ADDRESS>:57232: timeout waiting for client preface
Dec 25 17:52:44 maartje-tm caddy[11746]: 2016/12/25 17:52:44 http2: server: error reading preface from client <IP_ADDRESS>:57230: timeout waiting for client preface
Dec 25 17:52:44 maartje-tm caddy[11746]: 2016/12/25 17:52:44 http2: server: error reading preface from client <IP_ADDRESS>:57231: timeout waiting for client preface
Dec 25 17:52:44 maartje-tm caddy[11746]: 2016/12/25 17:52:44 http2: server: error reading preface from client <IP_ADDRESS>:57228: timeout waiting for client preface
Dec 25 17:52:44 maartje-tm caddy[11746]: 2016/12/25 17:52:44 http2: server: error reading preface from client <IP_ADDRESS>:57229: timeout waiting for client preface

7. How can someone who is starting from scratch reproduce this behavior as minimally as possible?
Install Caddy on an armhf device (I can provide a server if needed) and run Caddy to serve a php-fpm (my reverse proxy worked) site.
I suspect this has to do with it being 32bit, I have seen issues with that in golang apps before

Hey @meyskens, Merry Christmas.
This was already reported and fixed in #1306. Also see https://twitter.com/caddyserver/status/812057852558745600. Try building from source.


Frontend Parsing Layer

We need some mechanism to parse the JSON representation of MLTE artifacts to in-memory data structure representations. This will enable the frontend code to be logically separated from the object parsing functionality. These representations can be "static" in the sense that they will never be modified by complex logic on the frontend. The content may change (for instance, when updating content for writeback to the store) but these modifications will take place by accessing the fields of the object directly.
For non-polymorphic artifacts, there is a single structure that is the parse target. This will essentially equate to re-implementing the "model" representation from the MLTE backend in the frontend.
For polymorphic artifacts, like Value, there may be multiple parse targets. For instance, Integer looks different from Real. However, for the purposes of the frontend, it may be sufficient to parse to a generic type (just Value) and leave further parsing to a later implementation. At the very least, this will allow the bare minimum functionality to display information about individual artifacts in the frontend store UI.

Resolved by #254.


bad parsing results

i have got a bad parsing experience with a pdf file (uber annual report ) . the parsing results i got on an md file are so bad. ihave tried with many others pdf file and results are ok. i think the issue is related to the way this pdf has been designed .
e23076_uber-ars.pdf
MD results for example :
Uber
2022
Annual Report
Uber�s Mission
We reimagine the way the world moves for the better
Our Values

Do the right thing
Go get it
Trip obsessed
Build with heart

Period.
Bring the mindset of a champion.
Make magic in the marketplace.
We care.

Stand for safety
See the forest and the trees
One Uber
Great minds don't think alike

Safety never stops.
Know the details that matter.
Bet on something bigger.
Diversity makes us stronger.

UNITED
Large
UBER
SPECIA
looking
PART8+252=B.52?.;B;.201=
Platform>;!5*=/8;6

D
8+252=B

D
.52?.;B

.201=

8+252=B

D

we*=!;2?,B7-!;8=.,=287!B6.7=<<7-277,2*5#.;?2,.<7=2=;><=
software8+252=B.52?.;B6958B..<-*9=270 =8 * .@ 'B 8/ '8;42706958B..700.6.7=

6958B..
.?.5896.7=
*7-
".=.7=287

2?.;<2=B
*7-
7,5><287

;2?.;
*7-
8>;2.;
'.55
.270

social.;=27 /,=8;< 6B 1?.  6=.;25 -?.;<. .//.,= 87 8>; +><27.<< /277,25 ,87-2=287 7- ;.<>5=< 8/ 89.;=287< (8> <18>5-,;./>55B ,87<2-.; =1. /8558@270 ;2<4< =80.=1.; @2=1 55 8/ =1. 8=1.; 27/8;6=287 ,87=27.- 27 =12< 77>5 ".98;= 87 8;627,5>-270=1.<.,=287<=2=5.-E#9.,258=.".0;-2708;@;-884270#==.6.7=<F7-E70.6.7=G<2<,><<2877-75B<2<8/277,2587-2=2877-".<>5=<8/9.;=287<F7-8>;/277,25<==.6.7=<7-=1.;.5=.-78=.<27,5>-.-.5<.@1.;.27=12<77>5".98;=878;6 7B8/=1./8558@270;2<4<,8>5-1?.7-?.;<..//.,=878>;+><27.<</277,25,87-2=28789.;=270;.<>5=<8;9;8<9.,=<7-,8>5-,><.=1.=;-2709;2,.8/8>;,86687<=8,4=8-.,527.@12,1@8>5-,><.B8>=858<.558;9*;=8/B8>;27?.<=6.7= >; +><27.<< /277,25 ,87-2=287 89.;=270 ;.<>5=< 8; 9;8<9.,=< ,8>5- 5<8 +. 1;6.- +B ;2<4< 7- >7,.;=27=2.< 78=,>;;.7=5B478@7=8><8;=1=@.,>;;.7=5B-878=+.52.?.;.6=.;2*5

It looks like this PDF font is encrypted. We'll have a look at it.

I'm with the same issue...LlamaParse started to give me bad parsing results.
I tested the parsing of a pdf file that I already parsing to md with LlamaParse and now the result is so much worse.
I am not sure of what has changed with the API, but I am exploring alternative solutions.

Thanks for sharing the PDF, we identify the bug. The font is buggy in the pdf (try to copy paste from it), and we didn't identify it as such. This specific issue will be fixed with next release (this week) and I will let you know when it is available so you can test.

Hi!
This is now mostly fix in production. there still is an issue in some pages with uber custom font, and it will be address in a future release, most likely end of week or early next week (some text will appear as:
ride or received a Delivery order on our platform at least once in a given month  averaged over each month in the quarter  While a
unique consumer can use multiple product offerings on our platform in a given month  that unique consumer is counted as only one
MAPC  We use MAPCs to assess the adoption of our platform and frequency of transactions  which are key factors in our penetration
of the countries in which we operate
```  )


[OAP-Cache-OAP] fix pom and ci

What changes were proposed in this pull request?
using com.intel.arrow plasma since jars have update to central repo, remove install arrow in travis.
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Please create a JIRA to associate this.


Add cleaning

In this push, remove_excluded_positions builds a "excluded_positions" subfolder with parallel structure to standard experiment folders. The docstring has some extensive elaboration on this.

Good catch about the masks too!


Allow exporting of 64 bit version without needing 32 bit template installed

Fixes: #1404

+1

Also related is PR #2292

As was pointed out on IRC, this does not fix the issue of having only the debug template or only the release template setup for export.  I'm not sure if further down the line in the export process, godot is assuming that both debug and release are setup and working properly.

This works fine and I definitely want it implemented for 2.0 :)
Some remarks though:

The first check that gives "No 32 or 64 bit export templates found." seems redundant with the other two. Is there a use case where it would effectively be displayed?
The error message and export button active/inactive status are not refreshed when ticking/unticking the 64bit, e.g.:
** I have Linux 64 templates, no Linux 32
** I open the export popup with 64bit unticked, it will rightfully complain about missing 32bit templates
** I tick 64bit, it still complains about 32bit templates and the export button is still greyed out
** I need to click on another platform and then back on Linux X11 so that the error message disappears and the export button gets activated.

As stated above, PR #2292 also addresses the same issue and IMO in a more thorough way. It also takes into account the two bullet points I wrote above.
@firefly2442 Would you agree that we close this PR to the profit of PR #2292?

Sure, that one looks better.


add $fillable to EntrustRole & EntrustPermission

by default $fillable is null, when use
$owner = Role::firstOrCreate([
            'name' => 'owner',
            'display_name' => 'Project Owner',
            'description' => 'User is the owner of a given project',
        ]);`

is cause MassAssignmentException because it can't fill field.
So is it possible add protected $fillable = ['name', 'display_name', 'description']; in EntrustRole & EntrustPermission?

Thought i'd bump this by saying the issue encountered is still present. Appreciate if not mass assigning attributes this isn't a problem, however when bulk assigning this is very useful.

If you extend the default Permission and Role Models, you can update $fillable yourself.
Example:
namespace App;

use Zizaco\Entrust\EntrustRole;

class Role extends EntrustRole
{
	protected $fillable = [
		'name', 'display_name', 'description'
	];
}

NOTE You still have to call save() on your newly created Permission/Role, otherwise it will not write to the database.


[editing]discussion(optimizer): consider state table's primary key column order to achieve better spatial locality

We have found the state key's column order can affect performance during the previous explorations. This issue is to clarify the problem and discuss some potential ways to solve it.
introduction
Here is the query of nexmark q17
    SELECT
      channel,
      to_char(date_time, 'yyyy-MM-dd') AS day,
      max(to_char(date_time, 'HH:mm')) AS minute,
      count(*) AS total_bids,
      ... other agg functions ...
    FROM bid
    GROUP BY channel, to_char(date_time, 'yyyy-MM-dd');

The Aggregate executor needs to get the agg result of the group key during the processing. In other words, the executor will query the internal table many times like this
SELECT * from agg_result_table WHERE channel = $1 AND day = $2;

Is the edit done? 😄


Gesture detectors are unable to capture small, detailed gestures.

My app uses a GestureDetector's onPanStart, onPanUpdate and onPanEnd handlers to allow the user to draw on the screen. This worked great when I first developed the app in late 2018, but after recently updating Flutter and recompiling the app, I found that GestureDetector is much less sensitive to small movements.
By adding an onPanDown handler, I found that onPanDown is being called as soon as the pointer touches the screen, but then a fairly large drag movement is required before onPanStart will be called, and before onPanUpdate will then start being called for every ensuing movement of the pointer.
Because of how large of a movement is required before the gesture is considered a "pan", my app is no longer sensitive to small movements, and so users would not be able to draw small details as they previously could.
After digging into the Flutter code, the only solution I could find was to edit this file:
flutter\packages\flutter\lib\src\gestures\constants.dart
...to change the constant kTouchSlop from 18.0 to a lower number such as 4.0.
This is a messy solution and would need to be redone each time I update the Flutter code. So, I'm wondering if there's a better alternative method to allow GestureDetector (or ImmediateMultiDragGestureRecognizer, for multitouch gestures) to require less movement before it begins registering pans, and so to allow small, detailed gestures to be captured?
If not, I recommend adding the ability to change kTouchSlop on a case by case basis. Alternately, have the GestureDetector start reporting the gesture as soon as the pointer is down (rather than after it has already moved by kTouchSlop amount) if its dragStartBehavior is set to "down" rather than "start". (This is what I expected the behavior would be, but changing the dragStartBehavior to "down" seemed to make no difference.)

Flutter doctor -v
[√] Flutter (Channel beta, v1.5.4-hotfix.2, on Microsoft Windows [Version 10.0.17134.765], locale en-US)
• Flutter version 1.5.4-hotfix.2 at D:\src\flutter
• Framework revision 7a4c33425d (3 weeks ago), 2019-04-29 11:05:24 -0700
• Engine revision 52c7a1e849
• Dart version 2.3.0 (build 2.3.0-dev.0.5 a1668566e5)
[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
• Android SDK at C:\Users\frogr\AppData\Local\Android\sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-28, build-tools 28.0.3
• Java binary at: D:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
• All Android licenses accepted.
[√] Android Studio (version 3.2)
• Android Studio at D:\Program Files\Android\Android Studio
• Flutter plugin version 30.0.1
• Dart plugin version 181.5656
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
[√] Connected device (1 available)
• SAMSUNG SGH I337 • c65ac68a • android-arm • Android 5.0.1 (API 21)
• No issues found!

Hi @MichaelFerrier
Are you still experiencing this issue?
Thank yo

Yes, I'm still experiencing this. I recently upgraded to Flutter 1.14.6, and my app was once again unable to capture fine details that the user draws due to the problem described above.
Again I was able to fix this by changing kTouchSlop from 18.0 to 4.0. This is not an ideal solution; it requires modifying the flutter code after each upgrade, and applies globally so it makes other operations too sensitive (such as making it easy to accidentally swipe horizontally from one tab to another when trying to swipe vertically through a list). Thank you.

Hi @MichaelFerrier
like in this similar (not identical) issue
would making this issue a feature request for customisable touch slop
solve the problem?
thank you

Hi @iapicca
Yes, a good solution would be to allow the default touch slop to be over ridden on a per-widget basis. That way widgets could be set to capture small detailed gestures, as in my case of using GestureDetector to allow the user to draw on the screen.
Thank you,
Michael

I'd like to add that I'm also experiencing this issue. I am adding a pinch-zoom mechanic to change the zoom of a camera. But it feels unresponsive and not as accurate as the camera app usually provided on many devices.
A customisable touch slop would also be a good solution for me.

I also have a good use case for per-widget kTouchSlop managing. It would be really nice to have this feature.

I have experience this in the past, but noticed it very clearly in a Flame side project where it's almost impossible to have fine initial control of an on-screen joystick because of this issue.
https://user-images.githubusercontent.com/666539/204091320-6361b997-a4b7-4f25-a25c-55284720bb00.mp4

@TahaTesser
I think the labels as proposal new feature I added 1 million years ago are wrong (sorry guys)
what @lukepighetti is describing looks like bug to me

Hey guys, any update on this? Currently it's not able to draw a small line, and the drawing feature is not smooth. Or do you guys have any alternative on this when implementing a drawing feature?


feat(imagecard): hotspots support

Summary

Add hotspots support to ImageCard

Related Issues

Closes IBM/carbon-addons-iot-react#411

Acceptance Test (how to verify the PR)

Verify if ImageCard storybook contains hotspots

:tada: This PR is included in version 1.77.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0-beta.9 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.77.0 :tada:
The release is available on npm package (@release-1.x dist-tag)
Your semantic-release bot :package::rocket:


fix(article): add callback for remove article

fix(article): add callback for remove article
Add callback on remove article for state transition
Fixes #1274

Coverage remained the same at 73.224% when pulling 0b3f2a5a9e4af1d86132e927c0d1b62d9702377a on sujeethk:removecb into e3eafa6131ad799b77ada6e3bf1202fc686e0735 on meanjs:master.

Coverage remained the same at 73.224% when pulling 0b3f2a5a9e4af1d86132e927c0d1b62d9702377a on sujeethk:removecb into e3eafa6131ad799b77ada6e3bf1202fc686e0735 on meanjs:master.


Components should create a display:block style by default

From @SanderElias on September 7, 2018 11:19
I'm submitting a...

[ X ] Feature request
[ X ] Documentation issue or request

Current behaviour
When you create a new component, by default it gets no setting for css display.
Expected behavior
it should have display:block by default.
What is the motivation/use case for changing the behavior?
I know this has been discussed before (#5960), and pops up in (#12340) too.
Still, I'm putitng this back on the roll.  For the following reasons:

Current behaviour is confusing for new devs
Devs need display:block most of the time (for me, its 99+%)
The web doesn't break if we put this in place.
The expected impact of this "breaking" change is minimal
Saves a few bits from the app's payload
Less questions. no more, why does my css....
One more thing less to remember when creating a component.

I want to elaborate on point 3 a bit. The same discussion has been held in by standarts committee, If you follow along that discussion you will see that the general consensus is that it is actually a good idea, but it can't be changed because that would break the web. Angular does not have that issue. Angular can change this, and the impact of the change would be minimal.  probably something that has less impact as for example rxjs 5 to 6.
Others:
If we don't do this change, at least there should be more emphasis on this in the documentation.
Copied from original issue: angular/angular#25856

From @Meligy on September 8, 2018 1:3
This issue root is in how Angular keeps the component custom elements with their custom tag names in the rendered DOM, unlike other frameworks that omit these tags from output like React.
The design decision might not be bad overall, and is probably here to stay, but a problematic effect of this design is that these component elements get the display: inline; treatment by default. That's what browsers do when they see tags with no style, including built in user agent styles.
It's an instance where lack of action (no display setting) is equal to an action (setting display to inline).
Since it's not even inline-block, this often causes weird results when you try to use block styles to child elements in the template+styles of the component. The margins etc don't work as expected, and the Angular user has to track it all the way to understanding the above behaviour in order to understand and fix the problem.
This is where a documentation addition might help, also maybe using the Angular CLI default component schematic to add display: block; and/or a comment describing the behaviour, to default component styles.

From @trotyl on September 8, 2018 5:0
@SanderElias I don't think this is about component, but only for custom element. A directive could also have element selector, like <mat-tree-node>, people might want that to be block as well. But a component may not use custom element, like <button mat-button>, adding a display: block; for <button> doesn't make any sense.

From @SanderElias on September 8, 2018 4:18
@Meligy I'm aware of the history of this issue. I agree with the design choices. Still, Angular is in a position where we can change this browser default. The browsers can't do this, but Angular can.
Browsers behaviour as a default sounds good. However, in practice this thing more of a nuisance, as a benefit.
As in practice, you have a particular thing that is mandatory 99% of the time, and optional in 1%, it's a good idea to flip this around. No matter what, or how sound, the originating design choice is.
Angular is in a unique position, that can make the display:inline the option, and display:block the default.
Angular has also directives, aside from components. Those are here for the use-cases where you want a display:inline (or no real representation in the DOM at all.)
The cognitive load of Angular is already pretty high. Changing this would lower it a bit.

From @chaosmonster on September 8, 2018 9:8
I agree. I do this so many times that it feels a little bit cumbersome.
What I tried some time ago and it works under certain circumstances is to add a global css style
app-* {
  display: block;
}

That way I can override it where ever I need to.
Maybe something like this (using the prefixes defined in the angular.json) would be an option.
And I am aware that this wouldn't work with ViewEncapsulation.Native. It's more meant as a input to our creative thinking process.

From @robwormald on September 9, 2018 21:53
Thoughts: I agree with the stated problem (I forget this myself all the time!) but I'm not convinced that changing the default is a good idea. RE: cognitive overhead - my argument would be that any time that Angular diverges from the default browser behavior, that in itself increases the cognitive overhead (and load on docs team, etc).
It would likely break a number of apps as well - at least if we were to change something in the internals of Angular/Renderer, and (sorry) I'd argue again there's an increase in cognitive load here, because now something "invisible" (not in your component.css file) is changing behavior (and now you have to go look at the docs! How do I override it? etc )
If we want to avoid invisible / non-local problems (that is, I generally shouldn't have to look elsewhere to understand how a component works), I think that means that defaults like this have to exist in your app-component.css file.
We could use schematics or similar to augment the default css template, so ng g c foo would create a foo.component.css file like this out of the box:
:host {
  display: block;
}

One nice thing here is that many new developers have no idea that the :host selector is even a thing, so generating one for them teaches them something new for free.
One drawback here is that you then have to keep things "in sync" - if you change those default later, they won't affect already generated components.
We could provide a app/defaults.css file, that is added to the styleUrls of a new component:
:host {
  display: block;
}

@Component({
  styleUrls: [
   'app/defaults.css',
   './foo.component.css'
  ]
})

There's an argument to be made for CSS Variables (Custom Properties) here as well, because in a modern browser, rather than duplicating the app.defaults.css file per component, you would load it in index.html and do:
:root {
  --default-component-display: block;
}

Then the generated foo.component.css would look like this:
:host {
  display: var(--default-component-display);
}

This one feels the best to me:

it's explicit
sticks close to the platform (so you can go read MDN about CSS Variables, rather than Angular documenting a slightly different custom API.

This requires CSS Custom Property support - the good news is this is every browser BUT IE nowadays: https://caniuse.com/#feat=css-variables
Since Angular does require a compiler pass, we could potentially make a best effort to "downlevel" those properties - at compile time, rewrite the dynamic var(--some-variable) to with the variables specified in the app.defaults.css file. This would not allow for dynamically setting properties at runtime, but would provide a middle-ground until we drop IE support.
CSS is forgiving, so if we were to generate something like this - on IE, the 2nd line doesn't parse (and so the 1st line is used) - on browsers that support CSS Variables, the --default-component-display is used (or the fallback block if not defined)
:host {
  display: block;
  display: var(--default-component-display, block);
}

This is broadly useful for theming as well, and potentially Material.

From @SanderElias on September 10, 2018 4:27
@robwormald I would even prefer this over changing the default. I don't agree that changing the default would raise the cognitive load. But let us not go there, as we agree on the solution path.
I prefer your solution because as you said, it exposes new devs to :host :{}. This does even a better job in discouraging them to not use a wrapping element in their components.
And in the same go, it shows them about the display:block, which most of them not even realize is a thing and might encourage them to learn some stuff about CSS.
Also exposes it them to CSS custom properties. which is another plus. It is about time that this will get some more exposure and broader pick-up.
I could live with the fall-back for IE, but I would like to see a setting to turn that off. Ie support should be a thing of the past. It is for me already (for a long time), but aside from that, I don't think we should carry this forward. Having a setting means that in a couple of years, we can switch the default of the setting, to not generate the IE fallback anymore(but still be available for devs that still need to support Ie).

From @chaosmonster on September 10, 2018 6:17
I really like the idea to solve this via schematics.
About resolving css variables at build time.
In a way I like the idea, but I would like to point out as @SanderElias said, that this should be a compile flag.
What I could imagine, and this should be a separate issue, is a preprocessor step within webpack, that resolves all css variables. This seems so generic, that I think it might already exist or at least should be out of scope of the angular compiler or what so ever.
Alternatively to resolving the variables it could also add css lines as shown in @robwormald last example.

I like the idea of prefix-* selector in CSS.
It can be added along with comments explaining the issue and how to override the style using :host in the default Angular CLI style file, rather than adding another file to every component, and having to deal with whether the component has this default file or not, the order of file, specificity of selectors, etc.
If we want less cognitive overhead, and less magic, then not only we wouldn't add more default files, but I'd say also not to go for CSS variables for this specific case.
The CSS code itself would be commented like the CLI does with polyfills, and introduced in a feature (minor version) release. Later, it can be decided whether to uncomment it by default in a major version release, along with explanation in the release announcement of course.

To illustrate the issue which is a real problem especially with IE11:

@Meligy This change won't add a single file. It will add a bit of context to existing ones.
Also, most projects I have seen don't use a prefix, or use a prefix per feature, instead of a singe app-wide one.
By providing a sane default in the generated css for each new component you do reduce the cognitive overhead. Let me explain:

the display is set to 'block'. No need to remember that you need to do this.
if also shows how to use the :host selector. No need to look up how to do that again.
no more empty files, where you think, huh, what happened here and check history to figure out that it's just an empty file.
let me restate, its not an extra file, but default 'filling' for an existing empty one.

As this is in no way a breaking change, I don't think we need to wait for the next big release. As it happens on generation it only has influence on newly generated components, and exisitng ones remain untouched.
It is very much an convienent way to finally have a sane default in our components.

Regardless of the other points, this would be a breaking change as existing tooling solutions could very well assume that newly generated stylesheets are empty.
Something else to note is that a version of the css would be needed for each supported stylesheet preprocessor.  Generate creates a stylesheet file specific to the default style setting.
Also, if this is indeed a sane default for all components, would this be better addressed at the Angular level itself?

@clydin By no breaking change, I meant it's not a breaking change for Angular or any app that is written with it.
It might be a breaking change for tooling, but I think assuming empty files is more a bug as a feature ;)

After discussion in the CLI meeting, I just wanted to add that Google has a web components doc which recommends setting :host { display: block; } as a best practice because custom elements use display: inline; by default (though I'm told Angular components are not custom elements).
There is also an interesting foot gun, in that if a user manually adds :host { display: block; }, it will break the hidden attribute. The user actually wants:
:host {
  display: block;
}

:host([hidden]) {
  display: none;
}

Somewhat unrelated, but another mistake a user might run into is using :host[hidden], which doesn't work due to custom element styles weirdness. If we do decide to make display: block the default, we should also include the extra style for hidden and possibly reference this doc as some justification.

I discussed this with @StephenFluin and @jelbourn, both of whom were on board with the idea of adding this to the CLI schematic as an option. Since we have a PR for this, I think it's reasonable to go forward with it. It's just a matter of nailing down the best way of implementing this.
Also, just to include this here: @jelbourn argued against my previous point about :host([hidden]), because the hidden attribute is generally an antipattern (precisely because of this problem) and it might be better not to tacitly nudge users towards using hidden over *ngIf and other tools provided by Angular.

When this will be availabe for the current version? I see that It already merge to angular master branch

The PR was merged on Thursday so it just missed the last release, however it should be included in 9.1.0-next.3 which should be published later today.
Considering I don't think there's any more work to do here, I think we can close this issue. Just waiting for it to roll out.


How can I associate the key with the client_id？

How can I associate the key with the client_id. A client_id generates a fixed key. Return the public key to the client. However, I discovered that the public key will change periodically. Is it possible to store client_id and public and private keys together in the database?

Keys aren't associated with clients they're global to dex. Keys rotate occasionally in accordance with http://openid.net/specs/openid-connect-core-1_0.html#RotateSigKeys