Passing a completed future in FutureBuilder does not produce initial snapshot with data

When I pass an already completed future into a FutureBuilder, the initial data isn't reflected in the snapshot until the next build cycle.
The code below waits for a future to complete before passing it to a FutureBuilder. I would expect the snapshot to have data on the first instance of the widget yet it doesn't?
main.dart
import 'package:flutter/material.dart';

main() {
    runApp(
        MaterialApp(
            home: Scaffold(
                body: Page(),
            ),
        ),
    );
}

class Page extends StatefulWidget {
    createState() => PageState();
}

class PageState extends State<Page> {

    Future<int> myFuture;
    String myText;

    initState(){
        super.initState();
        myFuture = Future.delayed(Duration(seconds: 5)).then((_){
            setState(() => myText = "I want this to display");
            return 0;
        });
    }

    build(context){
        if(myText == null){
            return Center(
                child: Text('Waiting for future to complete')
            );
        } else {
            return FutureBuilder(
                future: myFuture,
                builder: (context, snapshot) {
                    if(!snapshot.hasData) myText = "I don't want this to display";
                    return Center(
                        child: Text(myText)
                    );
                }
            );
        }
    }
}

I'm aware of the 'initialData' parameter, but my use case means the the only data I can use only resides in the completed Future.
For now I'm using a workaround made of Stateful widgets but I would'nt think this was intended functionality of FutureBuilder?
Flutter Doctor
[√] Flutter (Channel master, v0.9.3-pre.17, on Microsoft Windows [Version 10.0.17134.285], locale en-GB)
[√] Android toolchain - develop for Android devices (Android SDK 27.0.3)
[X] Android Studio (not installed)
[√] VS Code (version 1.27.2)
[√] Connected devices (1 available)

! Doctor found issues in 1 category.

I think this is an issue with your example
import 'package:flutter/material.dart';

main() {
  runApp(
    MaterialApp(
      home: Scaffold(
        body: Page(),
      ),
    ),
  );
}

class Page extends StatefulWidget {
  createState() => PageState();
}

class PageState extends State<Page> {
  Future<int> myFuture;
  String myText;

  initState() {
    super.initState();
    myFuture = Future.delayed(Duration(seconds: 3)).then((_) {
      setState(() => myText = "I want this to display");
      return 0;
    });
  }

  build(context) {
    if (myText == null) {
      return Center(child: Text('Waiting for future to complete'));
    } else {
      return FutureBuilder(
          future: myFuture,
          builder: (context, snapshot) {
            if (!snapshot.hasData) {
              myText = "I don't want this to display";
            } else {
              myText = "I want this to display ${snapshot.data}"; // added
            }

            return Center(child: Text(myText));
          });
    }
  }
}

works.
return FutureBuilder(...) is executed when setState() is called and at first if (!snapshot.hasData) { return true even when the Future was already completed and this overrides myText.
When then then if (!snapshot.hasData) { becomes false, myText is already set to "I don't want this to display" and no code is executed anymore that would set it to "I want this to display".
Closing as working as intended.


Component Specific Policy Field Export

Requirements
As a user I want the ability to, when exporting a policy to, to select specific components of the policy to be exported instead of everything in one shot.
Pre-requisite
Policy Field  Information Architecture. Unit Tests.
Definition of Done
IA Diagram. Unit Testing Results.
Acceptance Criteria:
PDF or Other Documentation of DOD?

@danielnorkin is this really required?


refactor: Consolidate creator, storage and resolver DID under VDRI

closes #777
Signed-off-by: Firas Qutishat<EMAIL_ADDRESS>

@sandrask @talwinder50 @sudeshrshetty


Making the project more secure

I am looking into different methods to making this project more secure.

As it looks like the project is still not a Production ready product.
I did not find many approaches to secure the API as of this moment.
But did provided the user to add more Security options to there implementation: Here

Handled over here: https://github.com/kitarp29/kube-ez/pull/26


Update HELICSConfig CMake files

[ ] Update exported targets
[ ] Set variables

Blocks creating standalone CMake projects for #247

Do we know what is missing from the existing *Config.cmake?  There is a few other things in helicsImport.cmake.  we may want to merge those two files and just use Config so find_package(HELICS) works well.

I think the main thing keeping it from just working seems to be the exported targets, but I want to make sure that other variables are set to match whatever the convention is for CMake packages, and that the exported targets handle dependencies.

if you want to try in the broker_app branch.  I got it generate with find_package(HELICS) for Griddyn

still doing some work on that branch before I would get to a pull request

I got GridDyn to work with it? but when I tried with HELICS-FMI, the issue I run into is the libzmq when building from an installed location on Windows.  This will probably be an issue with the package as well.
There would be some license issues with including libzmq binaries with the package, so I can't really do that.  So I am considering other options,  (any suggestions)

What are the licensing issues?

libzmq is GPL,  it has a specific exclusion for linking with executables and independent modules.  Which means the shared library and executables are covered.  However, what is a little unclear would be distributing the static libraries of libzmq along with the other static modules of HELICS.  That situation is not explicitly covered by the modified GPL terms of libzmq.  Which would imply that a HELICS Executable would have to covered under a GPL.  which we don't want to do.    We deal with this at build by autobuilding from source ZMQ.  if it is just an install it shouldn't be an issue since that is contained to a single machine.  On Linux ZMQ is normally available so isn't much of an issue, but an executable installer, poses some complexity as far as what to do with ZMQ.

So its a problem for anyone using HELICS that is also directly using libzmq? Is distributing a copy as a shared library okay based on the license?

libzmq license

As a special exception, the Contributors give you permission to link this library with independent modules to produce an executable, regardless of the license terms of these independent modules, and to copy and distribute the resulting executable under terms of your choice, provided that you also meet, for each linked independent module, the terms and conditions of the license of that module. An independent module is a module which is not derived from or based on this library. If you modify this library, you must extend this exception to your version of the library.

So according to that since we are not modifying libzmq we can include it in the executables and as a shared library, and distribute the resulting libzmq.dll/so under the terms of the LGPL.
The issue comes from potentially including the static helics libraries in the installer,  I think the stub .lib are ok since they link to the DLL,  but I don't think we could include the static libs for instance for libzmq.
Either way we need to figure out how to deal with libzmq in the HELICSConfig.cmake so it finds stuff correctly on windows.


Add information in the guide about R-Ladies Zenodo Community

The materials generated from R-Ladies are huge but scattered (and mostly uncitable) - not easily searchable. In order to increase the discoverability, visibility, re-usability and make the materials citable, we recommend creating a Zenodo Community for R-Ladies where they can link not just their materials from GitHub (with two extra clicks) but also slides presentations, PDF and any type of output created by R-Ladies to make it citable. Every entry can be tagged by R-Ladise chapter name, the level of the materials and any other related metadata. You can also add the materials under more than one community (e.g. R-Ladies + another community helped with session (e.g. LatinR) ..) to increase the visibility, if wanted. Zenodo also provide a matric showing the numbers of downloads and views.
After an initial approval in Slack, I created a Zenodo community for R-Ladies and added one entry from a workshop by Allison Horst. However, if we want to proceed with this step, we need instructions to be added to the R-Ladies guidebook, how does this sound?
The wonderful @flor14 is working with me on this as well!

This sound great!!

Thank you!! Would you be able to make a PR to the guide?

Maybe organizers (https://guide.rladies.org/organization/events/promotion/?) but cross-linked from https://guide.rladies.org/comm/conferences/?
(I often have to use the search bar to find things in the guide myself :joy: :sob:)

Thanks, this makes more sense now!


[Skill] Handle EndOfConversation on Skill as part of core SDK

Use this query to search for the most popular feature requests.
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
The pattern to close out a ongoing skill dialog is for the parent bot to send over an activity that's type EndOfConversation. The skill has to handle it and clear out the dialog stack. Right now it's up to the skill developer to handle it, but it should be part of the core SDK.
For reference, in VA implementation, we added a component SkillMiddleware that's added for the skill's adapter to handle EndOfConversation: https://github.com/microsoft/botframework-solutions/blob/next/sdk/csharp/libraries/microsoft.bot.solutions/Skills/SkillMiddleware.cs
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
[enhancement]

This has been implemented in 4.8 in this commit.
closing


Fix LWJGL3 window not updating on resize. Resolves #6808

Since #6772, libGDX users have had an issue on the LWJGL3 platform when resizing the libGDX window on Windows. When players drag the window border, it does not call update. This results in black, unrendered areas until the user releases the mouse button. See #6808. This particularly impacts all tool developers who depend on UI reacting to window resize.
This fix, courtesy of @BambooBandit, addresses this problem. As noted in the issue, this only affects Windows users, so the fix should not be applied to Linux or Mac. Thank you.

Yes, this change basically stops Windows from being pulled down under with Mac

It was brought to my attention that Linux is actually affected by this issue, so I've included it with my fix. It is ready for review now. Thanks.

This PR looks great! However, I still think, we should check whether the postRunnable code is even needed on macOS (or maybe only when used with the gdx-lwjgl3-glfw-awt-macos extension).

I have an old mac laptop laying around (2015 model) I can test with if that would help. What should I try out? Running this branch with and without the postRunnable code while testing the resizing?
It seem's to be the rigth thing to test.
You can try to run master branch to compare with.

@JamesTKhan: Yes. I guess the simplest approach is to just include SharedLibraryLoader.isMac in this if-condition and then check whether it misbehaves with and without the gdx-lwjgl3-glfw-awt-macos extension.

I haven't forgotten about this, trying to test it today ran into some intellij version issues on the mac I gotta figure out.

Sorry guys, my Mac is apparently older then I thought. I cannot get latest libGDX to build on the Mac and on the current version of IntelliJ due to android and when I tried updating IntelliJ to a newer version it crashes on launch as IntelliJ is trying to make API calls this old OS does not have available

It seems I missed the conversation since Piotr's comment. I've implemented the suggested changes, however it seems I managed to break the build. Can someone help me out? I don't understand what has changed.

It seems I missed the conversation since Piotr's comment. I've implemented the suggested changes, however it seems I managed to break the build. Can someone help me out? I don't understand what has changed.

import org.lwjgl.opengl.GL32;

The import was added, but I think, it isn't needed.

Oh, I see some changes have been made to this file since I've made the PR. Am I supposed to pull origin? I thought that was frowned upon.

I think you can just remove the import? This whole thing will be probably squashed merged in any case.

Gah, Github Desktop just fetched the origin anyway. Oh well. Looks like it's ready for testing right now everyone. Thank you.

I'd like to review this, but I only have a Windows computer that I can easily test on. Has Mac been tested enough that we think it's good?


chore: promote account to primitive

Rationale
In the graph of the current schema, the Account and Transaction entities could be sharing an edge as the Transaction entity already contains a signerAddress field which would accurately represent this as a foreign key. I think this more accurate representation of the graph and resulting impact on the API increases ease of use of and reasoning about it. I see two options to establish this edge:

Using signerAddress directly as the foreign key

breaks convention in naming the field after the related model
is backwards incompatible (i.e. would have to be included in v1.x release if we wanted to do it)

Add new field

duplicates account ID scaling with number of indexed transactions
can deprecate signerAddress in a future release

good excuse to prioritize putting a plan together for deprecation

it's likely going to be difficult to avoid entirely despite graphql's flexibility

Changes
Going for option 2:

adds account field to the Transaction entity which relates to the Account entity

NOTE: a migration should not be necessary as the subquery node service will "do the right thing". It has its own, different, kind of "migration" (using sequelize model synchronization) which is sufficient for creating new tables on boot.
Depends on / TODO

#229

After #229 is merged, to rebase onto main run:
# assumes remote is named "origin", substitute if not
git fetch origin
git checkout chore/account-primitive
# assumes remote is named "origin", substitute if not
git rebase --onto origin/main origin/refactor/python-models chore/account-primitive
git push --force-with-lease origin chore/account-primitive

Code Review Checklist (to be filled out by reviewer)

[ ] Description accurately reflects what changes are being made.
[ ] Either the PR references an issue (via the "Development" combobox) or the description explains the need for the changes.
[ ] The PR appropriately sized.
[ ] The PR contains an idempotent DB migration.
[ ] I have verified the correctness of the DB migration using relevant data (e.g. test-generated data).
[ ] New code has enough tests.
[ ] New code has enough documentation to answer "how do I use it?" and "what does it do?".
[ ] Existing documentation is up-to-date, if impacted.

[End-to-end tests ]assed](https://github.com/fetchai/ledger-subquery/actions/runs/3789100516/jobs/6449038025) at commit 812e9f3


Configure innodb_log_file_size to a 128M limit

When a salt output is big enough, mysql will refuse to insert the offending
row for being too big, with an error:
[ERROR   ] Could not store events - returner 'mysql.event_return' raised exception:
(1118, 'The size of BLOB/TEXT data inserted in one transaction is greater than 10% of redo log size.
Increase the redo log size using innodb_log_file_size.')

Whatever we set as innodb_log_file_size will be an arbitrary number that will
eventually be flooded if the cluster is big enough, or if salt is noisy enough.
Given a cluster size, this can suddenly fail if we add more states (thus, increasing
salt's output). Obviously, given the same salt states, we can also reach this limit
by increasing the cluster size.
There is not a definitive fix for this issue, all we can do for now (without a proper
refactor of the way we integrate salt and velum) is to ensure that with todays salt
states we can reach a certain number of nodes. As said, this can no longer be true if
we add more salt states and we reach again the limit for the same cluster size.
Fixes: bsc#1095335
Depends on: https://github.com/kubic-project/container-images/pull/31

 Bug 1095335 - Bootstrapping hangs forever

Can we at least make the size of the log file configurable via an environment variable? By doing that some users could quickly change that to fit their needs.

Hmmm, I am not sure we can really do this. The config file will live in a RO filesystem and we don't really suggest users to remount the filesystem as RW. We can set that as an envvar, but I'm not sure if it's really worth it. What do you think?

Can we at least make the size of the log file configurable via an environment variable? By doing that some users could quickly change that to fit their needs.

Right - I'm not sure I see how an environment variable would make this dynamic? The env var would be set in the manifest, which we're going to override in salt time+time again.

The change unblocked the scaling tests and more nodes could be added to cluster (beyond 140 nodes)


Update deployment.mdx

Added mogenius as a platform to easily deploy a new Docusaurus project.

Motivation

Have you read the Contributing Guidelines on pull requests?

Test Plan

Related PRs

Please see our docs:

we have stopped accepting PRs adding new hosting options. You can, however, publish your writeup on a separate site (e.g. your blog, or the provider's official website), and ask us to include a link to your writeup.

I'm aware that this section is now used as an advertisement space for proprietary services, some of which are immature startups, so sorry, I'm not really willing to accept this change.


Map reduce in JDK 11 fails

Description:
In the jdk_11_migration branch, the following type of example test will not be executed successfully.
function test() {
    map<byte> m = {
            a: 3,
            b: 5,
            c: 1
        };

        int f = m.reduce(function (byte x, byte y) returns byte {
                             int res = x * y;
                             return <byte> res;
                         }, 2);
}

The gradle execution would be stuck at some point when this test case is being executed.
If only one key-value pair is included in the map<byte> m, the build would be successful.

Steps to reproduce:

Place only the above mentioned example code in the type_param_bound_type_as_cet.bal file (remove/comment out all the other functions within it).

In the TypeParamTest.java file, place only one new test case as following (remove/comment out all the other functions within it):

@Test(description = "Tests for the bound type as the contextually expected type for arguments")
public void testBoundTypeAsCET() {
    CompileResult result = BCompileUtil.compile("test-src/type-param/type_param_bound_type_as_cet.bal");
    Assert.assertEquals(result.getErrorCount(), 0);
    BRunUtil.invoke(result, "test");
}

Execute the following gradle command in order to build and test, only the above test case.

./gradlew :ballerina-langlib:test:test -x :composer-library:npmBuild -x :composer-library:npmInstall --tests TypeParamTest

Affected Versions:
Executed on the jdk_11_migration branch
OS, DB, other environment details and versions:
Executed on Ubuntu 20.04
Related Issues (optional):
#25041
Suggested Labels (optional):
Area/jBallerina, Priority/Blocker, Type/Bug
Suggested Assignees (optional):

@rdhananjaya @sanjana , refrenced PR should fix this issue.


cannot import name 'BertForSequenceEncoder' from 'transformers'

In the FEVER folder, the train.py file has this dependency -- "from transformers import BertTokenizer, BertForSequenceEncoder, RobertaTokenizer, RobertaForSequenceEncoder"
But I get this error message for both BertForSequenceEncoder and RobertaForSequenceEncoder like following
ImportError: cannot import name 'BertForSequenceEncoder' from 'transformers' (C:\ProgramData\Anaconda3\lib\site-packages\transformers_init_.py)
The other 2 are being imported

I guest the problem is about module path.
In this code, we create softlink from the directory "./transformers" to "fever/transformers".  It may not be available for Windows.
You can create the softlink manually or copy the train.py to the same directory with "./transformers".


Add branch testing workflow for devops#62

🗒 Summary
Merge this to add a branch testing workflow.
⚙ Test Data and/or Report
See the sandbox action run that uses the same workflow.
♻ Related Issues

devops#62

@nutjob4life Just a friendly reminder this Eddie has approved this PR.


*.pyi files not installed

Description
The Python interface files (*.pyi) are not installed into the install tree. As a result, they are missing from the 5.3rc4.post2 wheels.
Steps to Reproduce

Enable ITK_WRAP_PYTHON
ninja
DESTDIR=/tmp/itk-install ninja install
find /tmp/itk-install -name '*.pyi'

Expected behavior
The .pyi files are installed alongside the .py files.
Actual behavior
.pyi files are not installed.
Reproducibility
Always
Versions
ITK Git master, i.e.58ce6e84f2
Environment
Tested on Linux.

This is necessary to start getting the python system to be more consistent with remote modules:  https://github.com/InsightSoftwareConsortium/ITKSphinxExamples/pull/394

@thewtex I think I know how to manipulate the itk-stub files for installing, but I am not sure what is supposed to be done.
There is a variable called "PY_SITE_PACKAGES_PATH". That is sometimes set to CMAKE_INSTALL_PREFIX, and other times to the site-packages directory of the python interpreter.
Currently, the python stuff is installed to the python interpreter site-packages in the "itk" and "itk-stubs" directories, and I have confirmed that the type hints work in the PyCharm interpreter (after waiting for the indexing to complete).
I am not sure if this will allow for the stub files to be included in wheel packages, or if each wheel package will include duplicate copies of the itk-stub directories.
Please review the PR #3560 for the starting effort to make typehints more universally available.
Hans

@hjmjohnson to be included in the wheels, the *.pyi files need to be installed into PY_SITE_PACKAGES_PATH -- I would think the PY_SITE_PACKAGES_PATH/itk path. How does the interpreter understand that it needs to look into PY_SITE_PACKAGES_PATH/itk-stubs?

@thewtex   I followed the convention that would allow for making a separate type-hint package:  https://peps.python.org/pep-0561/#stub-only-packages by putting the .pyi files in a separate directory.
This was "doing it the hardest way" initially, knowing that if we wanted to collapse it later, it would be relatively easy to identify and change "itk-stubs" -> "itk"
I'll make a PR to review tonight.  It should be pretty easy.


Ecto.apply_changes not taking account of database default

Environment

Elixir version (elixir -v): 1.6.3
Database and version: Postgres 10.3
Ecto version: 2.2.9
Database adapter and version: 0.13.5
Operating system: unix

Current behavior
I have an ecto schema backed by a table that has a non_null column with a default. I want to add a validation that will check that column is in an enum of values:
    changeset
    |> Validations.validate_field_in_enum(:lead_status, ["active", "inactive"])

  def validate_field_in_enum(changeset, field, enum) do
    field =
      changeset
      |> Ecto.Changeset.apply_changes()
      |> Map.get(field)

    if field in enum do
      changeset
    else
      add_error(changeset, field, "Invalid #{field}", validation: field)
    end
  end

The problem is when I call Ecto.Changeset.apply_changes(), the struct returned will not include the default value the DB will eventually give the column I am checking. That means, when the record is being created without that specific field in the changes, I can't validate it. As the field comes back as nil.
Expected behavior
That the struct returned will contain that value.

So say a default on a field is something like "someDatabaseFunction()", what would you expect the default to be?  Defaults are database-side, not Elixir side, as only the database can truly know.  If a database can do the validation of something then it probably should do the validation.  :-)

Since the only way to access the database is through Repo, when it's not used we don't touch database (this is one of the basic guarantees of Ecto). This means there isn't even a way to make it work even if we wanted to.
Probably the only way to read the database defaults (if you really need to do this) would be to insert the value in a transaction just to immediately rollback.

Sorry to re-open the issue, but it appears that it doesn't seem to work with Repo.insert either.
if I do something like:
    %MyStruct{}
    |> create_and_validate_changeset(%{foo: "bar"})
    |> MyApp.Repo.insert()

The struct I am returned doesn't reflect the DB - the default boolean field gets set to null in the DB, but not in the struct returned from the Repo.insert.
I can fix this by adding a default to the model, is that what I am meant to do? Or should the insert return what the DB has?

Yes, use :default or read_after_write: true for a given field in your schema definition.

Ahh yes read_after_writes that’s what i was trying to remember!! Thanks

Why is the default not read_after_writes not the default though?

It increases IO and is not suppprted by all databases.
José Valim
www.plataformatec.com.br
Skype: jv.ptec
Founder and Director of R&D


Debezium CDC json unused schema field

For the mysql and postgres debezium connectors, the generated json (each cdc message) contains the schema field, which contains information about the upstream schema. However this field is not used by risingwave. Instead, the json parser on the RW side uses the schema provided by the user to parse the cdc message. Only the payload field in the json is used.
Also, since rw uses grpc to communicate with the connector node, the schema field generates useless network traffic (or unnecessary memory copies), which might have an impact on the connector throughput.
For complicated schemas, it is possible that that the schema field takes up a great portion of each CDC message. Maybe we should remove it.
Reference:

an example json can be viewed here https://debezium.io/documentation/reference/stable/connectors/postgresql.html#postgresql-create-events

By the way, I'm wondering if we can use a binary format to replace JSON for the protocol between the connector node and RisingWave... 🤔

Yes, we can. Technically, Debezium can output the events in Avro format, and recently there are some works on our Debezium Avro parser. In the current stage, I think JSON format is easier to track down issues. And we can evaluate the performance of both formats when direct CDC become more mature.


Wrong version on rubygems

Hey,
i reinstalled the gem from rubygems and there are the following code:
def primary(name)
  submit name, class: 'btn btn-primary'
end

I miss the 2. option parameter of the function.
Cheers,
Michael

The version bump was one commit before, please can you bumpversion 0.2.1 from the master?

Just pushed it to rubygems ;)


Add support to switch main GPU

Hi, wanted to ask if there is a way to swap GPU to use the second GPU because currently it will keep using the main GPU, unfortunately for me, my main GPU is 16GB while my second GPU is 24GB. I already tried replacing any mention of cuda:0 to cuda:1 but it still load in GPU 0 which trigger torch.OutOfMemoryError: CUDA out of memory. . Thank you for this awesome project.

I seems to manage to get it running by adding CUDA_VISIBLE_DEVICES=1 before running it and manage to start it but somehow I didn't get the advertised speed.
I only manage to get this result :
CPU: 7950X3D
GPU: 4080 Super, 3090
Ram: 192GB, speed limited to 3600
Model: DeepSeek-Coder-V2-Instruct
prompt eval count:    14 token(s)
prompt eval duration: 1.2786610126495361s
prompt eval rate:     10.948953523647642 tokens/s
eval count:           160 token(s)
eval duration:        24.879518270492554s
eval rate:            6.430992684844793 tokens/s

Hi, for now you can try export CUDA_VISIBLE_DEVICE= 1 (your second gpu idx)  in your bash when you start your program, and leave everything else unchanged.

I seems to manage to get it running by adding CUDA_VISIBLE_DEVICES=1 before running it and manage to start it but somehow I didn't get the advertised speed. I only manage to get this result : CPU: 7950X3D GPU: 4080 Super, 3090 Ram: 192GB, speed limited to 3600 Model: DeepSeek-Coder-V2-Instruct
prompt eval count:    14 token(s)
prompt eval duration: 1.2786610126495361s
prompt eval rate:     10.948953523647642 tokens/s
eval count:           160 token(s)
eval duration:        24.879518270492554s
eval rate:            6.430992684844793 tokens/s

However, I did notice that my ram is not getting filled :

Your RAM seems too low, which may cause extra time to load weights during inference. However, this shouldn’t happen because you have enough RAM for the weights to be loaded into it during the warm-up phase.
Any idea？
@chenht2022

In htop, green represents Kernel buffers, and orange represents Memory mapped.
The weights of experts in KTransformers are mmap-ed, so this portion of memory usage usually appears as orange.  In your screenshot, it accounts for at least 120GB, which is as expected.
Perhaps you can improve performance by increasing parallelism. Try using --cpu_infer 24.

Hi @chenht2022 , thanks for the suggestion but it seems setting it to 24 seems to reduce the eval speed a bit :
prompt eval count:    14 token(s)
prompt eval duration: 1.4017484188079834s
prompt eval rate:     9.987526871551813 tokens/s
eval count:           160 token(s)
eval duration:        26.098639011383057s
eval rate:            6.130587879705726 tokens/s

Maybe for extra context I'm running it from the main branch.

Since the MoE layer is offloaded to the CPU, its performance bottleneck during the generation phase is the memory bandwidth for reading weights. The comparison with llama.cpp shown in the video was conducted on a machine with an Intel 4th generation Xeon processor, equipped with 8 memory channels, each channel with 4800MHz. Achieving this level of performance places stringent requirements on the hardware.
As a reference, we also conducted tests on another setup configured with an Intel 14900KF + 4090D GPU + 192GB of memory, 2 memory channels, each channel with 4000MHz. The prefill performance for ktransformers and llama.cpp were 65.6 tokens/s and 8.93 tokens/s, respectively, the generate performance were 6.07 tokens/s and 1.23 tokens/s, respectively.
p.s.

You can use the following formula to calculate the equivalent memory bandwidth in generate phase. This value will be lower than the theoretical limit due to scheduling overhead and some GPU calculations

Bandwidth = num_hidden_layers * hidden_size * moe_intermediate_size * num_experts_per_tok * (bytes_per_elem_up + bytes_per_elem_gate + bytes_per_elem_down) * tokens_per_second / 10^9
= 60 * 5120 * 1536 * 6 * (0.562500 + 0.562500 + 0.820312) * 6.43 / 10^9
= 35.4 GB/s

Due to the sparsity of DeepSeek's MoE layer, prefill transitions from being memory bandwidth-bound to computation-bound when the prompt is long enough, so that there is a significant speedup compared to the generation phase.

Ah, I see. I thought the video being shared in the README actually just shows a standard consumer desktop machine, which rarely have more than 2 channels. Anyway, thank you for the explanations.


⚠ Secret Website 3 has degraded performance

In a7d9303, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 2247 ms

Resolved: Secret Website 3 performance has improved in d6d11df.


Add Makefile target to run all CI checks

And reorganize the docs to mention integration tests and this new target.
I also noticed an opportunity to update the pull request template. I think I prefer not mentioning make check-all there because I still haven't managed to run the integration tests locally!
Closes #1297

@elasticmachine test this please

@elasticmachine test this please

CI is green :)

@pquentin Ah sorry, yes this fell through the cracks. Merging.


README: Add basic guide how to set up dependencies for most common platforms

dependencies
-> python3.6
-> docker
-> docker-compose
-> invoke, virtualenv, tox
-> google chrome

chromedriver as well

Instead of writing some doc, a Vagrantfile has been made available instead, so people can set-up their working environment with a couple of commands.


Bump version in README to 3.5.0

Codecov Report

Merging #19 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #19   +/-   ##
=======================================
  Coverage   73.68%   73.68%
=======================================
  Files           4        4
  Lines          95       95
  Branches        9        9
=======================================
  Hits           70       70
  Misses         25       25

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92417d2...8dac153. Read the comment docs.


Cqe iterator

This adds a new API for processing CQEs as a psuedo-Iterator. Now, the APIs which return multiple CQEs (ending with for_cqes) return a CompletionQueueEvents type, which has a next_cqe and for_each method, which allow the user to advance through the ready CQEs on the queue.
This API is designed to synchronize with the kernel as few times as possible while processing all available CQEs. This is good if the code you perform for each CQE is very fast, but it can lead to a backed-up CQ if that code takes significant time. For example, this API would be good for a use which wakes tasks when IO events complete (e.g. in the reactor of a Rust Futures API), but not so much for something which actually completes the tasks synchronously on the same thread the events are completed.
This commit also collapses some repetitious unsafe code into singular underlying peek and wait functions, so that we should hopefully not see divergences and bugs.
Closes #14. There's substantial changes to unsafe code here, so I'd like other reviews and will review myself again next week before merging.

cc @michael-grunder

I updated my project to use the for_each iterators and everything seems to be working perfectly. 🎉

Awesome, glad to hear it :)

quininer (author of linux-io-uring) pointed out that CQEs are just 2 words of data. Instead of making our CompletionQueueEvent a reference into the completion queue, we can just copy the data out and return it. This avoids the lifetime issues and lets us make CompletionQueueEvents a real iterator.
I won't be able to revisit this code until after the new years, but I'll experiment with that approach.

Closing in favor of #47


elementPath not filled in with Raw Query

Grafana 10
Latest Grafana OSI Soft PI plugin version
Latest PI API

Can you give more details on how you use the API?

Can you give more details on how you use the API?

The elementPath is missing in the dashboard JSON Model if you add another panel with data from PI via the AF Raw Query Mode. See below example.

This is also true if you add 2 queries into the same panel. The one generated via the AF Raw Query Mode is missing the elementPath.

Fixed in PR #150


Set separate 'thumbnail_url' for SMK

Problem

The SMK provider script ingests records with ~2MB images. These files are overloading our thumbnail service and result in an unacceptable 6-10s load time. If these requests to the thumbnail server time out, the frontend will default to using the full image url (so a page with many results from SMK could end up downloading ~20 2MB images).
We would like to keep the high quality image for image_url, but supply a separate thumbnail_url with a smaller size.
Description

This was actually originally implemented in this way in #506, so much of this code can simply be reintroduced. For a given record, it will generate:
  "image_url": "https://iip.smk.dk/iiif/jp2/KKSgb5100_34.TIF.jp2/full/!2048,/0/default.jpg",         # Note filesize given as 2048
  "thumbnail_url": "https://iip.smk.dk/iiif/jp2/KKSgb5100_34.TIF.jp2/full/!2048,/0/default.jpg".  # Note filesize is 400

Currently, thumbnails are hard-coded to None for images by the ImageStore. This was done in #519, because at the time the thumbnail_url was always redundant (since thumbnails are generated by the server). Now that we have a use case for needing separate image and thumbnail urls, we should remove this hard-coding.
Additional context

This issue handles adding the data to the records in the Catalog. There will also need to be a change to the API to actually use the thumbnail_url in thumbnail generation. API issue: https://github.com/WordPress/openverse-api/issues/896
Implementation

[ ] 🙋 I would be interested in implementing this feature.

I wonder if it makes sense to have a separate column for thumbnail that is used only by a handful (currently, only SMK) of providers, or would it be better to save thumbnail to the metadata column?
I feel like it's better not to have a separate column if only one (or several) providers use it. If we decide to save thumbnail to the metadata object, we could either save the list of such providers and check if the provider is in it when generating thumbnails (I think this would be faster) or check if there's a thumbnail field in the metadata column, and use it, or fallback on the image url otherwise.

Anecdotally, I've noticed that the 512px endpoint seems to have quite fast responses: https://iip.smk.dk/iiif/jp2/KKSgb5100_34.TIF.jp2/full/!512,/0/default.jpg


/material-icons documentation page is hard to find

Hello,
I've been attempting to add icons to my site and I've find the process of finding the icon I need quite difficult.
Most of the material ui documentation links back to this page: https://material-ui.com/components/icons/
That page has some information on how icons work and potential issues etc, but it doesn't provide any listing of icons I can use.
I've ended up relying on sites like this: https://www.materialui.co/icons?s=load
It seems to me that the icon page on the material ui website should have functionality like this instead.
Edit: I've found https://material-ui.com/components/material-icons/ digging around more, it seems this should be easier to surface?
Thoughts?

Edit: I've found material-ui.com/components/material-icons digging around more, it seems this should be easier to surface?

It's mentioned on the page.
The goal is that the page will rank higher in search engine but it got added recently so this might take some time.

it seems this should be easier to surface?

Right on spot! I'm all ears to proposals to improve it. I was thinking of this very problem recently but I made no progress.
#17435 changes this link to redirect to the icons search page

My personal opinion is that it would be better suited on the right hand side quick menu with a name that indicates its a way to view all icons available. Something like this:

@azz0r I would propose the following diff to reduce the distractions, would it help?:
diff --git a/docs/src/pages/components/icons/icons.md b/docs/src/pages/components/icons/icons.md
index 15b38f076..03d0fcae1 100644
--- a/docs/src/pages/components/icons/icons.md
+++ b/docs/src/pages/components/icons/icons.md
@@ -7,13 +7,7 @@ components: Icon, SvgIcon

Guidance and suggestions for using icons with Material-UI.

-A [system icon](https://material.io/design/iconography/system-icons.html) or UI icon,
-symbolizes a command, file, device, or directory.
-System icons are also used to represent common actions like trash, print, and save,
-and are commonly found in app bars, toolbars, buttons, and lists.
-Google has provided a set of [Material icons](https://material.io/tools/icons/?style=baseline) that follow these guidelines.
-
-Material-UI provides two components to render system icons: `SvgIcon` for rendering SVG paths, and `Icon` for rendering font icons.
+Material-UI provides two components to render [system icons](https://material.io/design/iconography/system-icons.html): `SvgIcon` for rendering SVG paths, and `Icon` for rendering font icons.

 ## SVG Icons

@@ -38,7 +32,7 @@ It's interesting to have the building blocks needed to implement custom icons, b

 #### Usage

-You can use the [internal search](/components/material-icons/) or [material.io/tools/icons](https://material.io/tools/icons/?style=baseline) to find a specific icon.
+You can use the [dedicated search](/components/material-icons/) (recommended) or [material.io/tools/icons](https://material.io/tools/icons/?style=baseline) to find a specific icon.
 When importing an icon, keep in mind that the names of the icons are `PascalCase`, for instance:

 - [`delete`](https://material.io/tools/icons/?icon=delete&style=baseline) is exposed as `@material-ui/icons/Delete`

@azz0r Your proposal with available icons is interesting too as I expect most people to want to use it. Do you want to work on a pull request? :)

Indeed I remember I had trouble to find the icons too. Some times Ive been searching the MUI github source for the available icons.


MQ data directory changes

chante the configurations default directory

Describe the pull request:

[x] Bug fix
[x] Functional change

Pull request long description:

Solving issues like:
/usr/local/bin/ega-entrypoint.sh: line 8: /etc/rabbitmq/rabbitmq.conf: Read-only file system
chmod: /etc/rabbitmq/rabbitmq.conf: No such file or directory
/usr/local/bin/ega-entrypoint.sh: line 24: /etc/rabbitmq/definitions.json: Read-only file system
chmod: /etc/rabbitmq/definitions.json: No such file or directory
/usr/local/bin/ega-entrypoint.sh: line 74: /etc/rabbitmq/advanced.config: Read-only file system
chmod: /etc/rabbitmq/advanced.config: No such file or directory

Changes made:

change config directory path
making it more configurable by adding MQDATA

Additional information:

Changes incorporated in #4


add joint distribution

Given the probability distribution of the agents features provided by the LA, we now need to integrate whether there is any joint probability distribution among the agents' features. This issue can be resolved when the LA will give us info about which variables correlates with each other.
This task will allow us to generate agents' features which resemble more closely the reality of the population

literature on using census data to draw a population in ABMs:
Bruch & Antwell 2015

This issue is now outdated -- we have decided to go for the Bayesian Network, see issue #49


fix should not change SlotRef to NullLiteral

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

need to add some description


Proximity Feature Toggle Setting Text

ITS-Pro time category: https://its-pro.ucsd.edu/browse/MA-74
This is complete when:

[ ] The text for the user toggle for proximity is "Enable or disable proximity awareness"


Get CAMI2 plant-associated mock data

Acquire the plant-associated mock data
Only 10 of the 20 samples will be downloaded.
The bam and contig files will be avoided as we are only interested in reads.

I created a bash script that downloads samples 0 to 9 (10 first mock samples) using wget.


sih: move to PX4Accelerometer/PX4Gyroscope/PX4Magnetometer/PX4Barometer helpers

@romain-chiap

Discovered that astyle was chocking on PRINT_MODULE_DESCRIPTION, which is how this slipped through CI.


fix: DEV-2153: DEV-2526: Pagination, LSF undefined

DEV-2526: Don't crash because of undefined LSF
DEV-2153: Pagination

/frontend build dm master


Protractor doesn't clean up after uncaught exceptions

I've just encountered a similar issue as one reported earlier (#1072): Protractor sometimes doesn't clean up after itself; the chromedriver process and the Chrome browser are not killed if browser.driver.wait times out. The relevant function:
function waitForElementBySelector(selector) {
    browser.driver.wait(function () {
        return browser.driver.findElements(by.css(selector)).then(function (elementsArray) {
            return elementsArray.length === 1;
        });
    }, 30000);
}

Protractor 1.6.1 (latest), Node 0.10 & io.js 1.0.4.
The error message:
Starting selenium standalone server...
[launcher] Running 1 instances of WebDriver
Selenium standalone server started at http://<IP_ADDRESS>:64592/wd/hub

/Users/mgol/Documents/projects/bn/cbn/repo/polona-gui/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:1654
      var result = fn();
                   ^
Error: Wait timed out after 30026ms
    at /Users/mgol/Documents/projects/bn/cbn/repo/polona-gui/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:1425:29
    at /Users/mgol/Documents/projects/bn/cbn/repo/polona-gui/node_modules/protractor/node_modules/selenium-webdriver/lib/goog/base.js:1582:15
    at [object Object].webdriver.promise.ControlFlow.runInNewFrame_ (/Users/mgol/Documents/projects/bn/cbn/repo/polona-gui/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:1654:20)
    at notify (/Users/mgol/Documents/projects/bn/cbn/repo/polona-gui/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:465:12)
    at [object Object].then (/Users/mgol/Documents/projects/bn/cbn/repo/polona-gui/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:522:7)
    at Object.webdriver.promise.asap (/Users/mgol/Documents/projects/bn/cbn/repo/polona-gui/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:767:11)
    at newFrame.onComplete (/Users/mgol/Documents/projects/bn/cbn/repo/polona-gui/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:1670:25)
    at [object Object].webdriver.promise.Frame_.notify_ (/Users/mgol/Documents/projects/bn/cbn/repo/polona-gui/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:1914:5)
    at [object Object]._onTimeout (/Users/mgol/Documents/projects/bn/cbn/repo/polona-gui/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:1901:11)
    at Timer.listOnTimeout (timers.js:90:15)
==== async task ====
    at [object Object].webdriver.promise.ControlFlow.wait (/Users/mgol/Documents/projects/bn/cbn/repo/polona-gui/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:1410:15)
    at [object Object].webdriver.WebDriver.wait (/Users/mgol/Documents/projects/bn/cbn/repo/polona-gui/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/webdriver.js:646:21)
    at waitForFunction (/Users/mgol/Documents/projects/bn/cbn/repo/polona-gui/test/e2e/lib/helpers.js:22:20)
    at waitForElementBySelector (/Users/mgol/Documents/projects/bn/cbn/repo/polona-gui/test/e2e/lib/helpers.js:36:5)
    at Object.helpers.user.registerAccount (/Users/mgol/Documents/projects/bn/cbn/repo/polona-gui/test/e2e/lib/helpers.js:109:13)
    at onPrepare (/Users/mgol/Documents/projects/bn/cbn/repo/polona-gui/protractor.conf.js:47:22)
    at /Users/mgol/Documents/projects/bn/cbn/repo/polona-gui/node_modules/protractor/lib/util.js:54:41
    at Function.promise (/Users/mgol/Documents/projects/bn/cbn/repo/polona-gui/node_modules/protractor/node_modules/q/q.js:650:9)
    at Object.exports.runFilenameOrFn_ (/Users/mgol/Documents/projects/bn/cbn/repo/polona-gui/node_modules/protractor/lib/util.js:44:12)
[launcher] Process exited with error code 1

I've just tried this and I'm unable to reproduce. The timeout occurs as you say, but the instance of chrome is cleaned up and my output ends with
1 spec, 1 failure
Finished in 4.058 seconds
Shutting down selenium standalone server.
[launcher] 0 instance(s) of WebDriver still running
[launcher] chrome #1 failed 1 test(s)
[launcher] overall: 1 failed spec(s)
[launcher] Process exited with error code 1

Can you still reproduce this? Can you share some code that makes it happen?

Ah, I think I've figured out what you're doing. Are you doing this wait on onPrepare? I can reproduce if I try to do it there. I'm renaming the issue to clarify this.

I'll need to check but I think I use this in onPrepare as well so your observation is most likely true.

This is a quick way to reproduce the same behavior:
  onPrepare: function() {
    protractor.promise.delayed(30).then(function() {
      throw new Error('my error from onPrepare');
    });
  }

The issue here is that this is causing an uncaught exception. If we return a promise which errors, everything is cleaned up as expected. For the record, the same sort of issue happens with uncaught errors from tests:
  it('should clean up after itself', function() {
    protractor.promise.delayed(30).then(function() {
      throw new Error('my async error from the test');
    });
  });

So the question is, should we start catching uncaught exceptions and forcing cleanup in those cases? We should look into using node domains to do this.

We should look into using node domains to do this.

See https://iojs.org/api/domain.html. Domains are deprecated, I wouldn't dive into them with new code...

@mzgol thanks for the heads up. Do you have any idea what the non-deprecated path is?

From the site:

This module is pending deprecation. Once a replacement API has been finalized, this module will be fully deprecated

which means that for now the safest options seems to be just try-catching everything that might throw errors...

In that case, I think we can close this issue for now. Since the thing that might throw an error is user-written code in onPrepare, there's nothing that Protractor can add here.


Failed to make _jpegpy.so file

Hello, thanks for sharing your codes.
when I run make in CADDM/lib/data_preprocess/utils/jpegpy, It produces;
lto1: internal compiler error: in lto_tag_to_tree_code, at lto-streamer.h:1005
Please submit a full bug report,
with preprocessed source if appropriate.
See <file:///usr/share/doc/gcc-7/README.Bugs> for instructions.
lto-wrapper: fatal error: g++ returned 1 exit status
compilation terminated.
/usr/bin/ld: error: lto-wrapper failed
collect2: error: ld returned 1 exit status
Makefile:10: recipe for target '_jpegpy.so' failed
make: *** [_jpegpy.so] Error 1
I checked other issues related to _jpegpy.so and tried all of them, but they did not work.
Thank you in advance.

After changing this line
https://github.com/megvii-research/CADDM/blob/b3f761907ea773755d0a17fd88c5153516c6e156/lib/data_preprocess/utils/jpegpy/Makefile#L3
to
LDFLAGS = $(shell pkg-config --libs libjpeg) $(shell python3-config --ldflags) -fno-lto
it worked!


Ziti network digital ocean

Created the step by step to Configure open ziti network using digital Ocean cloud.

I suggest you start with a fresh branch and merge just your changes from this branch to the new branch, and make a clean PR.


td/telegram/Td.cpp - f (options_.api_id != 21724)

hi @levlam
  if (options_.api_id != 21724) {
    options_.application_version += ", TDLib ";
    auto version = OptionManager::get_option_synchronously("version");
    CHECK(version->get_id() == td_api::optionValueString::ID);
    options_.application_version += static_cast<const td_api::optionValueString *>(version.get())->value_;
  }

what does this check do?
why check whether the api_id matches the Telegram x application or not?

Apparently, the code inside the "if" you mentioned will force-append , TDLib v1.X to the provided application version. This checks makes sure it is not appended to the app version if this app is TGX. It's probably because it is not worth mentioning in that officla app

Telegram X has multiple other ways to see used TDLib version, so adding it to the app version isn't needed.


Media Migration

Added the hint to call the media migration after downloading them. Otherwise they wont be visible.

Hey @Dwza,
I think we can replace this:
wget -O test_images.zip http://releases.s3.shopware.com/test_images.zip

with this:
wget -O test_images.zip http://releases.s3.shopware.com/test_images_since_5.1.zip

Please update your pr and squash your commits.
Thanks!

thanks for your contribution :-)

To make this clean - could you @teiling88 fix this by yourself ;)

Closed during inactivity. Fixed with: https://github.com/shopwareLabs/shopware-vagrant/pull/41


feat: Upon test failure, output revert code with human-readable label and associated logs

Description
closes #3952.
This PR adds:

Revert code for failing tests
Known error signals for failing tests
Logs for failing tests

example:

Checklist

[x] I have linked to any relevant issues.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have updated the documentation where relevant (API docs, the reference, and the Sway book).
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
[x] I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
[x] I have requested a review from the relevant team or maintainers.

This is ready for re-review, I am planning to address #4002 in a separate PR which will enable us to see left vs righ values of assert_eq etc.


create_random_password cant be set as default to true

On the 20/01 you released new version that its great but you added new option in this version create_random_password that its default is true.
This issue made my team to troubleshoot an issue for 6 hours.
We set the rds password alone using this module but because this option is set to true by default the module ignored my password and set some random one.
I think that option like that should be false by default or at lest ignored is i'm setting my our password.
Thanks,
Eran.

It is bad that it caused such issues on your side but there was a bug introduced in the previous release where the password was not possible to create conditionally. Issue reported here - #183
There is no way to identify for sure in Terraform whether a password was provided or not when running this module, so create_random_password flag is required is set by default and used.
To prevent such things from happening in the future, always pin the version of Terraform modules you are using.

It is bad that it caused such issues on your side but there was a bug introduced in the previous release where the password was not possible to create conditionally. Issue reported here - #183
There is no way to identify for sure in Terraform whether a password was provided or not when running this module, so create_random_password flag is required is set by default and used.
To prevent such things from happening in the future, always pin the version of Terraform modules you are using.

Hello Anton,
Thanks for your awesome work! It is really helpful for my day to day job. :-)
I ran into the same problem than Eran today, and it took me quite a while to troubleshoot it. However, after more than an hour trying to find an alternative fix that would enable us to enforce the use of our own password even if create_random_password is set to "true" (without creating a random_password ressource because of the existence of my own), I surrendered. As you said, the problem stems from Terraform not knowing whether a password is provided or not, and I couldn't think of a creative way to pass around that.
The thing is, I am wondering if it's not more natural to set create_random_password to false by default. Indeed, when it's true by default, the use of the parameter "password" has no effect, and it is quite difficult to notice this behaviour before a problem happens. On the other hand, if create_random_password is set to false and we don't provide a password, we will automatically get an error when running terraform apply ("The parameter MasterUserPassword must be provided and must not be blank"). We would then put the variable to true, or use our own password, fixing the problem immediately.
It feels like a more natural design for me. What do you think?

Why not just a local for create_random_password = var.password == "" && var.create_random_password ? true : false or something with better logic if mine is off this morning.

I think that the problem resides on this line. We don't want to create a random_password resource if we provide our own, but if we use a conditional like var.password == "", Terraform won't be able to evaluate it if var.password depends on other resources that cannot be determined until apply (see #183).

I faced the same issues as mentioned above, I think it would be more logical to set random_password to false by default for better backwards compatibility for people upgrading modules.

I have created the below PR which updates the description of password in the readme to inform people that if they are going to provide a password then they need to set the random password generator field to false.
https://github.com/terraform-aws-modules/terraform-aws-rds-aurora/pull/196

Fixed in #201


Add more detailed prompt format documentation

@kouroshHakha can you also open a PR to modify the models/README.md in rayllm so they are consistent?

Just one small modification about trailing_assistant.

updated

@kouroshHakha can you also open a PR to modify the models/README.md in rayllm so they are consistent?
@akshay-anyscale can you open up a PR against rayllm as well?

@kouroshHakha can you approve?


[SPARK-9243] [Documentation] null -> zero in crosstab doc

We forgot to update doc. @brkyvz

Merged build triggered.

Merged build started.

Test build #38182 has started for   PR 7608 at commit 0ea3236.

Test build #38182 has finished for   PR 7608 at commit 0ea3236.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

LGTM

LGTM

I'm going to merge this since the test failures look unrelated.


kured-1.1.0.yaml references quay

I noticed that the file https://github.com/weaveworks/kured/releases/download/1.1.0/kured-1.1.0.yaml still references quay not dockerhub, so the installation instructions fail.

This is a duplicate of issue #68


Glob support

I don't see why this shouldn't be baked in so that downstream users like karma don't need to roll their own.
Also, as part of this, incorporate anymatch support for the ignored setting.

Just checked in an initial crack at the glob implementation. It's not very well vetted yet, so I assume there are still bugs and unmet use cases. Would appreciate help looking for cases that do not behave as expected. PRs with failing tests would be awesome.

@es128 Always open to new things :wink:

I haven't been able to find any more ways to break it. Going to call this one done :zap:
But please! everyone else try to break it too and open new issues if you find anything.

Hmm I was thinking of an API more like .watch(globs) instead of `.watch(folder, {ignore: ignoredGlobs})

Both ways should work. The ! negation syntax if passed within globs gets handled.

@es128 Oh I didn't see any docs on positive globs. Do you have any benchmarks of this in chokidar vs. gaze? If I can see that it works cross-platform and has better perf I could switch it out tonight

No, haven't evaluated comparative perf yet. Also, I've got a bit more to do before publishing as 1.0, trying to get it done over the long weekend.
Writing docs about the glob support would be one of the things that still needs to be done.

Besides performance, also keep in mind the bugs in Gaze :wink:


Light Codebox cutoff

The bar at the top of codeboxes cuts off the first 1-2 lines of code for the light version.

I don't have a light version of the theme - it's dark only? Can you grab a screenshot of the issue please?
It's also not been updated to cater to the newer "Live Preview" stuff and I'm aware that's not displaying too great at the moment.

Thanks,
I'll have a look into it - but I never finished the light variant and took it off the listing, it might be that despite flagging the theme as dark only, you can still switch to the half done light one.


etcd not joining cluster

I have an AWS stateless cluster.
I terminated one instance, and then I used etcdctl member remove on the dead node.
Another instance was spawned in its place, eventually. But this new member isn't joining anymore:
$ etcdctl cluster-health
member c075c2b2a194c97d is healthy: got healthy result from http://##.##.2.21:2379
member ef7f859394820d8d is healthy: got healthy result from http://##.##.1.66:2379

But in this node (.1.227), it seems everything is working fine.
ssh<EMAIL_ADDRESS>
$ etcdctl ls
/coreos.com
/deis
/registry
/sshHostKey

$ fleetctl list-machines
MACHINE         IP              METADATA
744acbe0...     XX.XX.1.227     controlPlane=true,dataPlane=true,routerMesh=true
a8317182...     XX.XX.1.66      controlPlane=true,dataPlane=true,routerMesh=true
e1a44903...     XX.XX.2.21      controlPlane=true,dataPlane=true,routerMesh=true

Any clues on what may be happening?

Okay, I got this:
https://github.com/coreos/etcd/issues/3938#issuecomment-221241209
Thanks to the folks over at slack.deis.io, I figured out that the new node is merely a proxy, and not a member. I had to do some etcd magic to add it as a member.


Can build y3 Packet with V from io.Reader

can do this:
var b y3.Builder
b.SetSeqID(4, false)
b.SetVarReader(quic.Stream)
packet, err := b.Packet()
// get reader
packet.Reader()

but code is still dirty, need refactor.

close this, as provided better in #9


Wrong order of arguments in roc --help output

roc --help prints:
    roc [OPTIONS] [ROC_FILE] [-- <ARGS_FOR_APP>...] [SUBCOMMAND]

But passing arguments in this order doesn't work:
$ roc --dev 1/1.roc run

No `.roc` file was specified, and the current directory does not contain a main.roc file to use as a default.

You can run `roc help` for more information on how to provide a .roc file.

(--dev is listed in OPTIONS in roc --help, 1/1.roc is a roc file, and run is a subcommand)

The help text changed some time in the last 2 years, now it says
Usage: roc [OPTIONS] [ROC_FILE] [ARGS_FOR_APP]...
       roc <COMMAND>


Map-Info doesn't show [Monsters Cannot be Taunted / Action Speed Cannot be Modified]

I know this is a small feature, but since I'm someone who largely plays Blight, I was hoping to be able to tag this when using Map-Info

Yes, I noticed that as well. GGG swapped the two lines around, which makes the tooltip miss the mod. I fixed it in a preliminary version I haven't officially released yet (I suddenly lost interest in the league and haven't fully tested all the changed I made).
You can edit the file "map mods.ini" in the "data" folder. Search for the line
[monsters' action speed cannot be modified to below base value|monsters cannot be taunted]
and replace it with
[monsters cannot be taunted|monsters' action speed cannot be modified to below base value]

Gotcha, thanks! Worked like a charm.
Thanks for the quick response despite your loss of interest too


Connector: Vitess Source

Work is being done in https://github.com/conduitio-labs/conduit-connector-vitess.

Closing because this connector exists in conduit labs.


ENH: allow summarize_plan to be terser

Description

Addresses #1254
Motivation and Context

Try to add a terser version of the summary
How Has This Been Tested?

not yet

rebased and fixed a closure bug.


Handle job-triggers for jobs with spaces

Job triggers are not processed properly if someone introduces a jenkins job name containing a space

Closed by #88


AFJ should favour non-revoked credentials for proof requests

I'm proposing that, when doing a proof, if there are both revoked and non-revoked credentials AFJ should favour the non-revoked credential over those that are revoked. To resolve this AFJ could:
a) If the schema is the same only return non-revoked matches; or
b) If all results must be returned, sort the revoked credentials to be first so they are preferred.
Proposed API:
const credentials = await agent.proofs.getRequestedCredentialsForProofRequest({
   proofRecordId: proof.id,
   config: {
      filterByNonRevocationRequirements: false,
      orderByRevocationState: true, // puts non-revoked credentials first.
    },
})

This is the data from credentials.proofFormats.indy?.requestedAttributes:
{
  "0_name_uuid": [
    {
      "credentialId": "02a8dab3-8aa1-4359-bce3-ad55df671d81",
      "timestamp":<PHONE_NUMBER>,
      "revealed": true,
      "credentialInfo": {
        "referent": "02a8dab3-8aa1-4359-bce3-ad55df671d81",
        "attrs": {
          "date": "2018-05-28",
          "timestamp": "1674163727",
          "degree": "Maths",
          "name": "Alice Smith",
          "birthdate_dateint": "19990119"
        },
        "schema_id": "79qrgFraLp5HTghZrhgiwk:2:degree schema:6.19.76",
        "cred_def_id": "79qrgFraLp5HTghZrhgiwk:3:CL:660901:faber.agent.degree_schema",
        "rev_reg_id": "79qrgFraLp5HTghZrhgiwk:4:79qrgFraLp5HTghZrhgiwk:3:CL:660901:faber.agent.degree_schema:CL_ACCUM:f57dd359-9b7d-4084-b2ce-c6a16ff7e03c",
        "cred_rev_id": "1"
      },
      "revoked": true
    },
    {
      "credentialId": "5530234b-d491-43fb-8484-903ebc9e4e8f",
      "timestamp":<PHONE_NUMBER>,
      "revealed": true,
      "credentialInfo": {
        "referent": "5530234b-d491-43fb-8484-903ebc9e4e8f",
        "attrs": {
          "birthdate_dateint": "19990119",
          "timestamp": "1674163933",
          "degree": "Maths",
          "name": "Alice Smith",
          "date": "2018-05-28"
        },
        "schema_id": "79qrgFraLp5HTghZrhgiwk:2:degree schema:6.19.76",
        "cred_def_id": "79qrgFraLp5HTghZrhgiwk:3:CL:660901:faber.agent.degree_schema",
        "rev_reg_id": "79qrgFraLp5HTghZrhgiwk:4:79qrgFraLp5HTghZrhgiwk:3:CL:660901:faber.agent.degree_schema:CL_ACCUM:f57dd359-9b7d-4084-b2ce-c6a16ff7e03c",
        "cred_rev_id": "2"
      },
      "revoked": false
    }
  ],
  "0_date_uuid": [
    {
      "credentialId": "02a8dab3-8aa1-4359-bce3-ad55df671d81",
      "timestamp":<PHONE_NUMBER>,
      "revealed": true,
      "credentialInfo": {
        "referent": "02a8dab3-8aa1-4359-bce3-ad55df671d81",
        "attrs": {
          "date": "2018-05-28",
          "birthdate_dateint": "19990119",
          "name": "Alice Smith",
          "timestamp": "1674163727",
          "degree": "Maths"
        },
        "schema_id": "79qrgFraLp5HTghZrhgiwk:2:degree schema:6.19.76",
        "cred_def_id": "79qrgFraLp5HTghZrhgiwk:3:CL:660901:faber.agent.degree_schema",
        "rev_reg_id": "79qrgFraLp5HTghZrhgiwk:4:79qrgFraLp5HTghZrhgiwk:3:CL:660901:faber.agent.degree_schema:CL_ACCUM:f57dd359-9b7d-4084-b2ce-c6a16ff7e03c",
        "cred_rev_id": "1"
      },
      "revoked": true
    },
    {
      "credentialId": "5530234b-d491-43fb-8484-903ebc9e4e8f",
      "timestamp":<PHONE_NUMBER>,
      "revealed": true,
      "credentialInfo": {
        "referent": "5530234b-d491-43fb-8484-903ebc9e4e8f",
        "attrs": {
          "degree": "Maths",
          "date": "2018-05-28",
          "name": "Alice Smith",
          "birthdate_dateint": "19990119",
          "timestamp": "1674163933"
        },
        "schema_id": "79qrgFraLp5HTghZrhgiwk:2:degree schema:6.19.76",
        "cred_def_id": "79qrgFraLp5HTghZrhgiwk:3:CL:660901:faber.agent.degree_schema",
        "rev_reg_id": "79qrgFraLp5HTghZrhgiwk:4:79qrgFraLp5HTghZrhgiwk:3:CL:660901:faber.agent.degree_schema:CL_ACCUM:f57dd359-9b7d-4084-b2ce-c6a16ff7e03c",
        "cred_rev_id": "2"
      },
      "revoked": false
    }
  ],
  "0_degree_uuid": [
    {
      "credentialId": "02a8dab3-8aa1-4359-bce3-ad55df671d81",
      "timestamp":<PHONE_NUMBER>,
      "revealed": true,
      "credentialInfo": {
        "referent": "02a8dab3-8aa1-4359-bce3-ad55df671d81",
        "attrs": {
          "birthdate_dateint": "19990119",
          "date": "2018-05-28",
          "timestamp": "1674163727",
          "degree": "Maths",
          "name": "Alice Smith"
        },
        "schema_id": "79qrgFraLp5HTghZrhgiwk:2:degree schema:6.19.76",
        "cred_def_id": "79qrgFraLp5HTghZrhgiwk:3:CL:660901:faber.agent.degree_schema",
        "rev_reg_id": "79qrgFraLp5HTghZrhgiwk:4:79qrgFraLp5HTghZrhgiwk:3:CL:660901:faber.agent.degree_schema:CL_ACCUM:f57dd359-9b7d-4084-b2ce-c6a16ff7e03c",
        "cred_rev_id": "1"
      },
      "revoked": true
    },
    {
      "credentialId": "5530234b-d491-43fb-8484-903ebc9e4e8f",
      "timestamp":<PHONE_NUMBER>,
      "revealed": true,
      "credentialInfo": {
        "referent": "5530234b-d491-43fb-8484-903ebc9e4e8f",
        "attrs": {
          "name": "Alice Smith",
          "date": "2018-05-28",
          "degree": "Maths",
          "timestamp": "1674163933",
          "birthdate_dateint": "19990119"
        },
        "schema_id": "79qrgFraLp5HTghZrhgiwk:2:degree schema:6.19.76",
        "cred_def_id": "79qrgFraLp5HTghZrhgiwk:3:CL:660901:faber.agent.degree_schema",
        "rev_reg_id": "79qrgFraLp5HTghZrhgiwk:4:79qrgFraLp5HTghZrhgiwk:3:CL:660901:faber.agent.degree_schema:CL_ACCUM:f57dd359-9b7d-4084-b2ce-c6a16ff7e03c",
        "cred_rev_id": "2"
      },
      "revoked": false
    }
  ]
}

This is what the Bifold UI looks like:
Actual Behaviour
Here are the 3 credentials displayed in the Aries Bifold wallet in the order of them being received:

This is what a proof match looks like for said credential. The proof does not specify any requirement on revocation status:

Expected Behaviour
If all credentials are equal, the non-revoked credential should be favoured above those that are revoked.

Yep makes sense! However, in this case the revoked credentials are just as usable as the non-revoked credentials.
Maybe the UI should nit show Revoked in red in the overview if it doesn't matter? Sometimes it's okay it is revoked (e.g prove you are or ever were a member of our gym).

We ask AFJ for revoked credentials even if they don't work because we want to show the user why the proof failed. Showing them they don't have a cred to make a proof work doesn't help them fix the problem.


Add Navigation Reader

Adds Controllers and Readers for every Navigation parsing controller class.
Tests have also been created for the controllers

Codecov Report

Merging #2 (81d8801) into main (239c1f4) will increase coverage by 21.37%.
The diff coverage is 51.72%.

@@             Coverage Diff             @@
##             main       #2       +/-   ##
===========================================
+ Coverage   14.91%   36.29%   +21.37%
===========================================
  Files          54      103       +49
  Lines        1522     2331      +809
===========================================
+ Hits          227      846      +619
- Misses       1295     1485      +190

Impacted Files
Coverage Δ

lib/src/enums/access_mode.dart
16.66% <ø> (ø)

lib/src/enums/accessibility_apis.dart
7.69% <ø> (ø)

lib/src/enums/accessibility_control.dart
12.50% <ø> (ø)

lib/src/enums/accessibility_feature.dart
3.12% <ø> (ø)

lib/src/enums/accessibility_hazard.dart
10.00% <ø> (ø)

lib/src/enums/epub_guide_reference_type.dart
7.14% <ø> (ø)

...ib/src/enums/epub_navigation_page_target_type.dart
100.00% <ø> (ø)

lib/src/models/container/epub_container.dart
9.37% <0.00%> (ø)

lib/src/models/container/rootfile.dart
13.63% <ø> (ø)

lib/src/models/epub.dart
0.00% <ø> (ø)

... and 106 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 239c1f4...81d8801. Read the comment docs.


Don't set force: no for copy_files task (to allow file updates)

With force: no, files will only ever be copied once, and any changes to those files will never be copied to the remote host(s) again. This is not the default behavior with the ansible copy_module https://docs.ansible.com/ansible/latest/collections/ansible/builtin/copy_module.html#id2, and makes this feature much less useful/practical. If it's necessary for some more obscure use-case, I could see making force a configurable param in the copy_files_* items, but it doesn't seem necessary to me or for our known use-cases.
@Adam-D-Lewis @costrouc

The files I want to set on the server are actually ones that are present by default as well (and I need to change), so the feature as-is can't be used for this situation unfortunately.


fix: do not focus input after user clicks the clear button

Resolves #270
Impact: minor
Type: bugfix

Remove input focus after user clicks on clear button, and when the user clicks away from the input.
Testing

Enter text into TextInput component
Click away from component
Verify green focus ring is not present.
Click on the input
Click on the clear button
Verify green input ring is not present and that text was cleared.

🚀 Preview deployed
Built with commit 4200c079e7f280efb28a1c8ee08f94697302951c
https://deploy-preview-306--stoic-hodgkin-c0179e.netlify.com

:tada: This PR is included in version 0.40.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Unable to deploy SolidStart with node though it works locally

So I have a bare bones JS only SolidStart app I created today, brand new. Node version is 18.
I create the initial app with the counter. It works great right out of the box. I do a build. I go into the dist directory and run node server.js. Works exactly the same.
I have a DO box I created just for this purpose. I scp the files over, no changes. Go into the directory and get the following error:
nyc1-01:/home/app/dist# node server.js
(node:3794) Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension.
(Use `node --trace-warnings ...` to show where the warning was created)
/home/app/dist/server.js:1
import require$$1, { resolve, join, normalize, dirname } from 'path';
^^^^^^

SyntaxError: Cannot use import statement outside a module
    at Object.compileFunction (node:vm:360:18)
    at wrapSafe (node:internal/modules/cjs/loader:1088:15)
    at Module._compile (node:internal/modules/cjs/loader:1123:27)
    at Module._extensions..js (node:internal/modules/cjs/loader:1213:10)
    at Module.load (node:internal/modules/cjs/loader:1037:32)
    at Module._load (node:internal/modules/cjs/loader:878:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:23:47

Node.js v18.12.1

I've looked through existing bugs but most of them focus on Prisma being an issue so I specifically avoided adding it. I read some documentation on the SolidStart site that you may need an adapter but didn't see anything about what I needed to use. Also, for whatever reason the node app has no trouble running.
I'm thoroughly confused why this would happen on remote boxes but not my own. I'm not sure if this is a bug or designed behavior (seems unlikely).
If this is an uncaught bug that's fine or if I'm just pointed in the wrong direction please let me know.
Thank you
    "solid-js": "^1.6.10",
    "solid-start": "^0.2.17",

Mind boggling to me why this works locally but not on any server...

Hi Matt, fyi, I'm on 0.2.21 and deploying to EC2 instance w/o any issues (using node adapter). Regarding prisma, I used workaround documented here: // https://github.com/solidjs/solid-start/issues/398#issuecomment-1398080969
i.e., ...
import {
	PrismaClient as ImportedPrismaClient
	// UserStatus as ImportedUserStatus,
} from "@prisma/client";
import { createRequire } from "module";
const require = createRequire(import.meta.url ?? __filename);
const { PrismaClient: RequiredPrismaClient } = require("@prisma/client");
const _PrismaClient: typeof ImportedPrismaClient = RequiredPrismaClient;
export class PrismaClient extends _PrismaClient {}

Odd that no such issue and hack needed for SvelteKit, which also packages using Vite / requires esm.

Weird... What is the Node adapter exactly? Is that something I need to add in specifically?

Unlike SvelteKit, node adapter is configured by default (at least my starter template was, which was auth-core option when creating new project). Screenshot below (note adapter:node). I haven't had any reason to explore further since I'm deploying to EC2 (so need node).

@MattStopa can you confirm you have "type": "module" in your package.json.
also can you clarify how you are getting your files on your server.. are you just copying the dist directory or the whole app and building it?

also, is your node on DO >=v16.2?

@MattStopa can you confirm you have "type": "module" in your package.json and its on your server
also can you clarify how you are getting your files on your server.. are you just copying the dist directory or the whole app and building it?

Yes type = module. I just copied the dist over. Am I supposed to do the build on that machine? I didn't even consider doing that.

@MattStopa can you confirm you have "type": "module" in your package.json and its on your server
also can you clarify how you are getting your files on your server.. are you just copying the dist directory or the whole app and building it?

Yes type = module. I just copied the dist over. Am I supposed to do the build on that machine? I didn't even consider doing that.

If you don't have any native dependencies just copying the dist folder is fine but you will also need to copy the package.json.. what you can try first is change the extension from .js to .mjs first

So... I just went ahead and built on my target machine and it works fine. That didn't work well because I was using a shared webhost and couldn't do an NPM install there but I tired on DO and it works fine. So there's that at least. I'm going to close


Add CYRES Training / Benefit Information in Website

As post for benefits and paid-training.  See email.
https://www.asrg.io/acp-level-1-foundation-training-from-cyres/

The second one is also posted according to the sample you shared, here is the link
https://asrg.io/acp-level-2-advanced-engineering-training-from-cyres/

Can you please remove the "-"?  It should just be a space.

Also, can you please update the template to have the information regarding the training aligned...

Also, please add the 3rd training opportunity, the internet based training. Let me know when you add it so I can review, update and release.

Done with the allignment

Here is the 3rd one and you can find it under the post as a draft.


Add support for as patterns

This close to impossible to support with the current architecture of Agda: as patterns are treated as let-bindings, and let-bindings are inlined eagerly in the internal syntax. So we would have to somehow reconstruct which terms correspond to a let-bound variable.

Actually, let-bindings do not work either, for the same reason.

Related: agda/agda#7253

Would preserving record update syntax currently be impossible for the same reason? It would be nice to have, so we can generate record update syntax in Haskell. Currently record update syntax is expanded to constructing a new record from scratch and I guess that it's expanded like that in Agda's internal syntax, so we can't distinguish between record update and manually constructed records in agda2hs?


Update maxmind-db submodule

Not really a bug but it'd be great if you can update it so I can use a single submodule instead of having to use libmaxminddb and maxmind-db separately.

Thanks. I updated it.


Toggle theme

Description

I am finally getting around to issue #669. This does not fix that issue, but it enables the user to toggle between light and dark modes from the GUI View menu.
I tried to make sure that the check mark would get updated if the palette was updated elsewhere. That seemed a little hack-y to me so I welcome any other ideas if there is a better way. Still learning the Qt world.
I will borrow a mac and try to fix the weird updating bug that others are seeing.
Type of change

[ ] Bug-fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

References

How has this been tested?

[ ] example: the test suite for my feature covers cases x, y, and z
[ ] example: all tests pass with my change

Final checklist:

[ ] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works

Hi @boonepeter.  thanks for the PR!  this looks/works good for me.
Ultimately, I think I'd like to see this functionality in a preferences menu, with a dropdown selection instead of a boolean choice (in case we expand theme options, or allow plugins).  I implemented that in the settings PR #834 (here is an example)... but I think it might be a while until there is sufficient demand to get that in.  So I have no problem with this solution for now.
will leave it for @sofroniewn to also review.  And you'll need to fix the black/flake8 errors before it can merge.
thanks again!

Thanks @tlambert03! Your #834 looks pretty slick and is definitely the way to go. I definitely won't be offended if this doesn't make the cut as it is just a small thing I wanted to add while looking into that other issue.

yeah, but that could take a while, and this is minimal.  The only possible argument against it is that we might eventually remove it.  but I don't mind that.  I'll approve this but leave the final decision to @sofroniewn.


Made long methodlines short and removes unnecessary comments

Pull Request Test Coverage Report for Build 975

1 of 2 (50.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 74.961%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/IMAPClient-Core.package/ICFolder.class/instance/fetchHeadersFrom..st
0
1
0.0%

Totals

Change from base Build 970:
0.4%

Covered Lines:
952

Relevant Lines:
1270

💛  - Coveralls


fixed action and separator visibility

Added two lines of code to hide the ActionButtons and separator if not applicable. This code was based upon the original project at https://github.com/zekunyan/TTGSnackbar and aligns the two project a bit more.
UPDATE:
I just noticed that another PR (this one) already solved the problem. However I think my simple addition is still good for code robustness. If somebody in the future forgets to set the ActionButton one way or another, this will make sure that the code is still consistent.
fixes #19

Thanks! I'll make a new nuget this week

I am waiting for new NuGet.

Yeah, me too...


Notebook save as is broken

With latest master, Notebook->File Menu->Save as, the notebook is not saves as new name. The untitled notebook is changed to not dirty.
I checked May release, which is working fine.
Not sure if it is related to recent VS code merge. Saw some changed in fileCommand.ts file.

The latest vscode merge did some stuff with how the editor status sets the mode, but thats the only big thing I remember from this area.


Add compatibility for webpack 3.5.6

In webpack 3.5.6, each assets in compilation.assets must have source and size, both being functions. Taking the existing setup, I added both to the object being written to compilation.assets.
Changes should be backwards-compatible, too - source and size only get set, if there weren't any!
Tested changes with webpack 3.5.6.
See https://webpack.js.org/development/how-to-write-a-plugin/

Thanks for your pull request. I will test and merge it.

Hi, I test your code  and the result is not correct. I plan to refactor the code and solve this problem


Need SBT 1.0 Feature Migration Guide

Filing per request of Josh Suereth on the sbt-dev mailing list in a message about AutoPlugin usage.
problem
Developer has sbt 0.13.1 build which uses Defaults.defaultSettings.  Developer upgrades to sbt 1.0 and receives warnings about defaultSettings being deprecated.  Developer looks for migration guide to detail changes needed, but finds none.
expectation
A migration guide should be provided in the SBT documentation, detailing how to convert pre-1.0 projects into idiomatic SBT 1.0 projects.  In particular, the guide should cover how the usage of AutoPlugins changes build definitions.
notes
Josh's description:
Hope that helps!  Also, please open a ticket about an sbt 1.0 feature migratoin guide.
As we backport sbt 1.0 features into 0.13, we should keep such a guide up-to-date
(e.g. AutoPlugins is one such aspect).   The 0.13.2 guide you see basically needs
to be morphed into the 1.0 guide.

Here is a draft of an 0.13.2 migration guide which can possibly be used as a starting point.

Thanks

The follow project definition from a  project/Build.scala  will fail in 0.13.2

To fix you need to add both the  autoPlugins  and  projectSettings  includes as shown

I was under the impression that project/Build.scala had been deprecated.

Since this page pops-up for google searches of "sbt 1.0 migration", it's worth noting that the completed guide is available and that this issue should probably be closed.

Yea. Let's close this up.


How to setup node.js & hub on Mac OS?

Unfortunately I'm not a node expert and can't manage to start the hub on my Mac. I have installed the node.js packages and started them by double clicking on "node". This opens a new terminal window.
What should I do now? Where do I enter the hub directory and how do I start it? What is meant by "npm run start"?
I would be very grateful for a more detailed explanation!
Thanks a lot!
Stefan

Welcome Stefan.
You need to open a good old terminal, change to the directory where you unpacked the downloaded files (like cd /your/path/to/wifi-tally-v0.1.0/hub) and run the command there npm run start.
I don't know what starting the node application does – but whatever it does, I am pretty sure it is not necessary to get the hub running. :wink:

Closed because discussion went stale.


Fix errors on Windows with paths to manifest

I'm having issues with Formie (on Craft 5) where the paths are resolving incorrectly for many things, but mainly the manifest.json.
There are two parts to this PR:
Fix path to manifest
You may have to explain to me why you use FileHelper::createUrl() to get the path for the manifest file. It's a path, not a URL?
Windows:
C:\Users\joshcrawford\public_html\formie-craft5\vendor/verbb/formie/src/web/assets/forms/dist/manifest.json

MacOS
/Users/joshcrawford/public_html/craft50-alpha/vendor/verbb/formie/src/web/assets/forms/dist/manifest.json

You'll notice in Windows that the slashes are incorrect for a path, but correct if we assumed a URL, or if we assumed Linux/MacOS.
There might be other instances of FileHelper::createUrl() being used when dealing with paths.
Fix isAbsoluteUrl check
When it comes to fetching the manifest, you fetch it with curl. With the path sorted, that should be working fine, but an interesting result happens for some UrlHelper::isAbsoluteUrl($pathOrUrl) checks in your FileHelper.
UrlHelper::isAbsoluteUrl('/Users/joshcrawford/public_html/craft50-alpha/vendor/verbb/formie/src/web/assets/forms/dist/manifest.json');
false

UrlHelper::isAbsoluteUrl('C:\Users\joshcrawford\public_html\formie-craft5\vendor\verbb\formie\src\web\assets\forms\dist\manifest.json');
true

Here, you can see we input the MacOS path and the WIndows path respectively into this function, expecting the same result - but it's not! It's treating the C:\Users\... as an absolute URL, which it certainly isn't. I'm surprised that Craft/Yii don't check if the string you pass into it is a URL first, but that's probably unique to your use-case here, where you allow either a path or URL.

I'm going to consider this a CraftCMS issue until otherwise informed -> https://github.com/craftcms/cms/issues/15043

Probably won’t fix https://github.com/nystudio107/craft-plugin-vite/pull/25/commits/13879346ffb8263354e89fb2cacf47de9a95431d but happy to wait

@engram-design you may be right... I'm just super confused on how it could never have worked on Windows... because the code is the same for Craft 3 / 4 / 5 and surely someone would have complained by now, whether users of my plugins (or yours that use it).
I'll look at your change and maybe cherry-pick it if you think it's unrelated.

Happy to wait for a resolution on https://github.com/craftcms/cms/issues/15043 before going ahead!

Looks like they fixed (one of) the issues in Craft 4.9.5 and 5.1.5 -> https://github.com/craftcms/cms/issues/15043#issuecomment-2125637951
I also pushed your normalizePath() fix in the above commits, I just moved it further down the chain to bottleneck it.
Can you update to the latest Craft, and then try it?
Craft CMS 3:
You can try it now by setting your semver in your composer.json to look like this:
    "nystudio107/craft-plugin-vite": "dev-develop as 1.0.35”,

Then do a composer clear-cache && composer update
…..
Craft CMS 4:
You can try it now by setting your semver in your composer.json to look like this:
    "nystudio107/craft-plugin-vite": "dev-develop-v4 as 4.0.11”,

Then do a composer clear-cache && composer update
…..
Craft CMS 5:
You can try it now by setting your semver in your composer.json to look like this:
    "nystudio107/craft-plugin-vite": "dev-develop-v5 as 5.0.1”,

Then do a composer clear-cache && composer update

Looks like that Craft fix alone has done the trick! Probably not a bad idea to normalize the path, but it's not seemingly needed on my end.
Thanks!


Adds the annotation app.openshift.io/vcs-uri to deployments

What type of PR is this?
/kind feature
What does this PR do / why we need it:
It adds the annotation app.openshift.io/vcs-uri to the deployment.
Which issue(s) this PR fixes:
Fixes #4544
PR acceptance criteria:

[X] Unit test

[X] Integration test

[ ] Documentation

[ ] Update changelog

[ ] I have read the test guidelines

How to test changes / Special notes to the reviewer:

Create a component using odo create and trigger odo push on a directory in which git has been initialized and a remote named origin is present.
Check if the annotation app.openshift.io/vcs-uri is present with the value which is to the fetch URL of the origin remote.
If the directory is not a git directory, the above annotation should be empty.

-e2e-kubernetes-integration-e2e-steps failed after 2h0m28s (failed containers: test): ContainerFailed one or more containers exited
ERRO[2021-06-01T14:17:50Z] Container test exited with code 1, reason Error

/retest

Just for the reference:
This is how it looked before:

After this PR is merged:


avoid fs caches

conv=fsync makes dd avoid fs cache. Without it you get wrong measurements about actual disk speed.

Hey @fastchain,
Sorry for the incredible delay, but I finally added the changes you suggested to both scripts today. Thanks for the suggestion!


Determine the (Windows) path of an attached device

Hi there!
How can I determine the path of an attached device in order to read a file from a USB device?
I'm running node on Windows and I want to read a specific XML file from a USB device when it's being attached.
Thanks in advance!

I'm assuming you're talking about a USB Mass Storage Class device, like a flash drive or hard drive. In that case, this library isn't what you're looking for.
This is for low-level raw access to USB endpoints. In the case of a mass storage device, you're using the driver in the kernel instead of writing a driver in Node with this library.

Thanks for your answer!
I'm quite a newbie in the low-level world. I was indeed talking about a USB flash drive device. I want to be able to put an XML configuration file on a USB drive from any pc. This configuration file should be loaded automatically by Node when inserted.
Does this mean there is no way to accomplish this in Node without writing any external driver / script?


Clear the search bar when we launch from the home activity

Fix for http://manage.dimagi.com/default.asp?183986
We were persisting the previous search in Entity/Form List activities both when re-launched from the home activity and when returning from form entry. This fix makes us only persist the search in the latter case

I just tried this on my phone and I don't think it works as expected.
When you back out of a case's form selection screen back to the case detail/selection screen, the detail/selection activity is (re)launched via the home screen, so it always has the clear flag you've created.
That said, I don't have any ideas of a way to tackle this.

(I was assuming this was ready for review; please mark your PRs so we can be sure)

@ctsims @phillipm you both bring up good edge cases and I'm also not sure the right way to do this anymore. Is it safe to say that if we hit "Back" from EntitySelectActivty we always want to clear the search? If so the cleanest way to do this might be just to Override the back command of that activity to clear the cache

"Is it safe to say that if we hit "Back" from EntitySelectActivty we
always want to clear the search?"
Assuming it's a big lift to make the search specific to each module type,
so I think the clearest expectation would be that we only auto-search again
if the user has moved backward onto the search screen or if the session has
restarted/a new session has started. Pressing back from the search screen
would trigger that as long as the session restarting also did it.
-Clayton
On Fri, Oct 16, 2015 at 1:52 AM, wpride<EMAIL_ADDRESS>wrote:

@ctsims https://github.com/ctsims @phillipm
https://github.com/phillipm you both bring up good edge cases and I'm
also not sure the right way to do this anymore. Is it safe to say that if
we hit "Back" from EntitySelectActivty we always want to clear the
search? If so the cleanest way to do this might be just to Override the
back command of that activity to clear the cache
—
Reply to this email directly or view it on GitHub
https://github.com/dimagi/commcare-odk/pull/694#issuecomment-148509701.

Let's go to voice on this at the standup tomorrow, still not clear to me what the desired behavior is

Addressed by https://github.com/dimagi/commcare-odk/pull/795


Investigate Microsoft test cloud

It looks like this supports only native apps, not Unity games. I am looking into alternate solutions.


Embed Weibenfalk video on Final Space API  to Examples section

Embed Weibenfalk video in Examples section
https://youtu.be/zmwG5lYQYRo
P.S. make sure to add links to his Twitter, website etc.

hello i want to take this issue

Awesome
Assigning to you @tiana30

Hey @tiana30
This resource maybe helpful
https://www.slideas.app/blog/how-to-embed-a-vimeo-or-youtube-video-in-markdown/

Hey @tiana30
Any update on this?

@lelouchB can I take this if it is not being taken. One more thing does this video needs to be embedded to the https://github.com/lelouchB/final-space-api/blob/main/README.md section or inside the docs in intro.md

Hey @adityatandon007
Thanks for your interest, I have pinged @tiana30
Let's just wait a day for her reply  and there is still no updates, I will assign this issue to you.
The video will in a separate page under Examples section in the docs.
Hope that answers your question

hello, i'm sorry to inform you i think there is something wrong with my internet connection i can't clone this project to my computer.
So you can assign anyone who interested.

@tiana30  No problem
@adityatandon007  assigned to you
Let me know if you have any questions

@lelouchB please review and merge