Repeatedly request sign in

The sign in dialog shows up repeatedly when trying to create a short link. This happens when user's Github email is empty.

I will like to work on this issue

@lawaloy Thank you!

@lawaloy Please join this Slack channel to discuss bugs, dev environment setup, tooling, and coding best practices.

@lawaloy May I have your email?

<EMAIL_ADDRESS>Kind Regards,
Oluwaseyi Lawal
On Fri, Oct 11, 2019 at 12:05 PM, Harry<EMAIL_ADDRESS>wrote:
@lawaloy May I have your email?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

@lawaloy May I have your email?

I was unable to see the link because your message is coming to my email box directly.

I invited you to Slack and you joined already.
On Sat, Oct 12, 2019 at 9:31 AM Oluwaseyi Lawal<EMAIL_ADDRESS>wrote:

@lawaloy https://github.com/lawaloy May I have your email?
I was unable to see the link because your message is coming to my email
box directly.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/byliuyang/short/issues/192?email_source=notifications&email_token=AA27XCNYPMENEKYMDTJTRSTQOH3W7A5CNFSM4I4ER64KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBCDHMI#issuecomment-541340593,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA27XCMFUJWZI7N56NVDVN3QOH3W7ANCNFSM4I4ER64A
.

Okay, thanks. I'm still working on that task.
On Sat, Oct 12, 2019 at 12:46 PM, Harry<EMAIL_ADDRESS>wrote:   I invited you to Slack and you joined already.
On Sat, Oct 12, 2019 at 9:31 AM Oluwaseyi Lawal<EMAIL_ADDRESS>wrote:

@lawaloy https://github.com/lawaloy May I have your email?
I was unable to see the link because your message is coming to my email
box directly.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/byliuyang/short/issues/192?email_source=notifications&email_token=AA27XCNYPMENEKYMDTJTRSTQOH3W7A5CNFSM4I4ER64KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBCDHMI#issuecomment-541340593,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA27XCMFUJWZI7N56NVDVN3QOH3W7ANCNFSM4I4ER64A
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Hi @lawaloy, this bug involves redesigning the database tables and changing Github OAuth & Authentication logic. It's very complex. Do you want to try a different issue instead? I am planing to take on this.

Okay, That is fine.

Okay, that is fine. I will take on another issue

@lawaloy Thank you!

Migrate from email to user ID.


Add ability to remove key bindings, rebind keys, assign action names to keys

This will be especially useful for key rebindings in menu, so that players can re assign keys to actions dynamically

done halfway, just need to add checks so that same action is not bound to multiple triggers, possibly use observable maps, so that bindings are auto propogated to UI (e.g menu)


Spotify

Added spotify web player + a control bar for adding currently playing songs as automatic preset triggers.

I see you have closed this pull requests.
Are you wanting to continue working on this before the merge?

Yeah, I'm adding support for time-position triggers. Had to rework a lot of it, and I still gotta clear up some issues


The window size of casual mode

Sorry to bother you again. I am not sure the window size of casual mode in Table 1 (a). Take the last column (sec. 60) for example, is the length of time window 30 in casual mode, while 60 for batch mode?

Thanks for your question! In the last column, in the causal mode it's from -60 to 0 while in the batch mode it's from -30 to 30.

Thanks for your reply.


WA-217: Use Solidity types from Bivrost

Changes proposed in this pull request:

Use Solidity types from Bivrost

@gnosis/mobile-devs

To merge only after Bivrost release

Codecov Report

Merging #13 into master will decrease coverage by 0.54%.
The diff coverage is 55.88%.

@@             Coverage Diff             @@
##             master     #13      +/-   ##
===========================================
- Coverage     66.15%   65.6%   -0.55%
+ Complexity      142     140       -2
===========================================
  Files            48      49       +1
  Lines          1052    1041      -11
  Branches        185     177       -8
===========================================
- Hits            696     683      -13
- Misses          268     273       +5
+ Partials         88      85       -3

Impacted Files
Coverage Δ
Complexity Δ

.../main/java/pm/gnosis/blockies/BlockiesImageView.kt
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...va/pm/gnosis/ethereum/rpc/RpcEthereumRepository.kt
93.87% <ø> (ø)
7 <0> (ø)
:arrow_down:

.../pm/gnosis/svalinn/accounts/base/models/Account.kt
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...tories/impls/models/db/SolidityAddressConverter.kt
0% <0%> (ø)
0 <0> (?)

...accounts/repositories/impls/models/db/AccountDb.kt
75% <0%> (ø)
1 <0> (ø)
:arrow_down:

utils/src/main/java/pm/gnosis/utils/Extensions.kt
95.74% <0%> (-2.09%)
0 <0> (ø)

erc67/src/main/java/pm/gnosis/erc67/ERC67Parser.kt
92.59% <100%> (ø)
0 <0> (ø)
:arrow_down:

...ckies/src/main/java/pm/gnosis/blockies/Blockies.kt
98.24% <100%> (+1.69%)
5 <0> (ø)
:arrow_down:

...is/svalinn/accounts/utils/TransactionExtensions.kt
75% <100%> (ø)
0 <0> (ø)
:arrow_down:

.../repositories/impls/KethereumAccountsRepository.kt
37.14% <33.33%> (+2.85%)
5 <0> (ø)
:arrow_down:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e6ee37...8f1fc8a. Read the comment docs.


QLoRa / LoRa issue

Hello, you have done an incredible job. I've read in the README file that QloRa and loRa integration is not well-tested.
I tried the getting started example for embeddings adding qlora and lora and the result is always:
TypeError: GemmaModel.forward() got an unexpected keyword argument 'labels'
I've tried other models and the output is the same.

Does it work without qlora/lora? This seems like a problem with labels being passed to forward - what attn are you using?

I've tried cccc, bb and cc. I've tried with tiny-mistral and other models like as gemma 2b.
torchrun --nproc_per_node 1 -m training.run --output_dir test_path --model_name_or_path openaccess-ai-collective/tiny-mistral --train_data training/toy_data/toy_data_embedding.jsonl --learning_rate 1e-5 --num_train_epochs 5 --per_device_train_batch_size 2 --dataloader_drop_last True --normalized True --temperature 0.02 --query_max_len 32 --passage_max_len 128 --train_group_size 2 --mode embedding --attn cccc --lora True

Does it work without qlora/lora?

I think it is because LoRA rewraps the model and then the label kwarg is not passed through or something; I don't have time to debug it atm but it shouldn't be too complicated - would be amazing if you open a PR in case you fix it :)

Of course. I'll give it a try. Congratulations again for your work.

I have created a PR: https://github.com/ContextualAI/gritlm/pull/21
I have tested with the embedding example. I haven't found the reason for this behaviour in the PEFT library. By removing the specific task parameter the training works.


Implement ipywidget support to same level as webview notebooks

Make sure you have the latest insiders when validating

Validated.
This worked for me across the range of stuff that I was testing with (basic widgets, py3js, qgrid, bqplot).
I did notice one fairly important issue that I logged with #4095. But that seems like a follow up issue / bug fix. The basic widget functionality all seems validated.

Cool. Thanks!


e2e: Use OPERATOR_NAMESPACE in k8sreporter

The operator working namespace should be specified by the user when running conformance tests.
amends:

https://github.com/k8snetworkplumbingwg/sriov-network-operator/pull/498

cc @liornoy

duplicate of

https://github.com/k8snetworkplumbingwg/sriov-network-operator/pull/506


Add Document for Map Program

Refer below commits:

Commit 1
Commit 2
Commit 3

Can u review and merge it? https://github.com/sagar-jadhav/go-examples/pull/76


removed AI in sidebar

To match console.

🚀 Deployed on https://67283498df9db0c3bfcd59c6--cozy-fox-0defec.netlify.app


Doesn't Work

i doesn't work after updating atom

Try using the new Experimental Atom plugin for new Emmet: https://github.com/emmetio/atom-plugin


[FIX] Delete button index fix

Description ✏
index + 1 changed to just index to fix delete message button

Checklist ✅

[x] I have added screenshots (if UI changes are present).
[x] I have done a self-review of my code.
[x] I have manually tested my code (if applicable).

Nice, works to delete the message. Though the next followup will say "sending [object Object]..." instead. Then only the next followup starts working. Example below. But gonna merge this for now.

@Fryingpannn That's interesting. I will look into this and push a fix in the future. I'll just open another PR.


Parse error: code mismatch with RND Parser output

Hi. I got the following error:

Parse error in line 90: code mismatch with RND Parser output
1 entry was added to the error log 'C:\Users\me\AppData\Roaming\SAP\ABAP
cleaner\user\error.log': the cleanup of a code file was cancelled

The log just says the same as the first line above.
The line 90 contains this:

call_subrc = me->fake_debug_error->get_fake_subrc_exception(
  EXPORTING context = asynch_dispatch_subrc_context
            probability = '0.05'
            id = !task_to_execute-task_id
  IMPORTING sys_msg = sys_msg ).

I use the "!" character in !task_to_execute to denote a method parameter.
Where the called method has the following signature:

METHODS get_fake_subrc_exception
  IMPORTING !subrc              TYPE sy-subrc DEFAULT 0
            !context            TYPE context
            !probability        TYPE f
            !id                 TYPE csequence
  EXPORTING !sys_msg            TYPE symsg
  RETURNING VALUE(result_subrc) TYPE sy-subrc.

Even when I hilight a snippet or a method, different to the one containing the issue above, I get the same error.

Hi Oscar,
ah, great, thanks for the hint! This was about the !task_to_execute-task_id, where the RND Parser simply omits the !, while ABAP cleaner keeps it (and then complained about the mismatch). ABAP cleaner already handled this correctly for simple identifiers such as !probability, but not yet for composed ones like !task_to_execute-task_id. It will be fixed in the next release!
Kind regards,
Jörg-Michael

Hi Oscar,
thanks again for reporting this bug! This should now be fixed with version 1.6.0, which was just released.
Kind regards,
Jörg-Michael


Latest Version of Firefox Breaks Rendering

I love this script and use it daily to render webGL animations. Unfortunately it looks like the latest Firefox update v55 breaks the rendering process. It took me awhile to figure out what was going on, but once I downgraded to Firefox v54 it worked flawlessly again. I assume this is related to the security part of the release notes. (https://www.mozilla.org/en-US/security/advisories/mfsa2017-18/). When on v55 the render can still be downloaded but it contains empty black frames for PNG sequences/gif frames.
Hope this helps someone else.

I just tried the example in Firefox 55.0.3 macOS Sierra, and it worked correctly, the PNGs are correctly generated and packed. Could this be an issue with your rendering or the interaction between your rendering and ccapture on FF55?

Hmm maybe it the OS difference and FF55? I am currently on El Capitan, and within a 24 hour period animations that rendered perfectly were spitting out blank frames. The only change that I discovered was FF updated within that time frame, and downgrading instantly fixed it.
It looks like I have an El Capitan update to install and if that doesn't work I will try updating to Sierra later today to see if it makes a difference. Thank you again for the fast response and for the awesome library!

Works with Sierra and Firefox 55.0.3 as you suggested. Seems to have been El Capitan causing the issue after all.


Review for renaming of stuttering collision of GO track2 SDK

I think as part of this exercise we’ll need to distill what exactly that guideline is.  We don’t have one in place as originally we weren’t planning on removing stuttering.
I need to look at these in more detail, but my knee-jerk is that we shouldn’t be renaming the ones where the names had stuttering removed.  i.e. ‘DataBoxJobDetails’ => ‘JobDetails’ should remain ‘JobDetails’ so that its fully qualified name is ‘databox.JobDetails’ (this matches what the swagger was conveying).  We should instead rename the thing it collides with, i.e. ‘JobDetails’ is renamed to something slightly different.
-Joel
Subject: RE: Review for renaming of stuttering collision of GO track2 SDK
It would be great if we can base our decisions on guidelines.
FWIW I’m not a big fan of shuffling AaBb into BbForAa.  Personally I’d rather stutter than name it like that.
Ex:
from: 'DataBoxJobDetails'
to: 'JobDetailsForDataBox'
_rick
Subject: Review for renaming of stuttering collision of GO track2 SDK
Hi all,
As stuttering removing has been introduced into the latest autorest.go to make GO track2 API more idiomatic, we have encountered some collision for some existed models or clients. To let the renaming more reliable, we’d like to have a quick review through the mail. I’ve listed all such renaming in current preview GO SDKs with directives and the collision type in the following table. If any suggestion, please feel free to reply directly. Thanks.
rp	directive	type
cdn	directive:

rename-model:
from: 'CdnEndpoint'
to: 'EndpointForCdn'	model collision
databox	directive:
rename-model:
from: 'DataBoxJobDetails'
to: 'JobDetailsForDataBox'
rename-model:
from: 'DataboxJobSecrets'
to: 'JobSecretsForDatabox'
rename-model:
from: 'DataBoxScheduleAvailabilityRequest'
to: 'ScheduleAvailabilityRequestForDataBox'	model collision
databoxedge	directive:
rename-model:
from: 'DataBoxEdgeSku'
to: 'SkuForDataBoxEdge'
rename-model:
from: 'DataBoxEdgeSkuList'
to: 'SkuForDataBoxEdgeList'	model collision
guestconfiguration	directive:
rename-model:
from: 'AssignmentReport'
to: 'BasicAssignmentReport'	model collision
labservices	directive:
rename-model:
from: 'LabServicesSku'
to: 'SkuForLabServices'	model collision
redis	directive:
rename-model:
from: 'RedisResource'
to: 'ResourceForRedis'	model collision
security	directive:
from: swagger-document
where: '$.paths.*[?(@.operationId.startsWith("SecurityConnectors_"))]'
transform: >
$["operationId"] = $["operationId"].replace("SecurityConnectors_", "ConnectorsForSecurity_");	operation group collision
signalr	directive:
rename-model:
from: 'SignalRResource'
to: 'ResourceForSignalR'
rename-model:
from: 'SignalRResourceList'
to: 'ResourceForSignalRList'	model collision
videoanalyzer	directive:
rename-model:
from: 'Properties'
to: 'MetricProperties'
from: swagger-document
where: '$.paths.*[?(@.operationId.startsWith("VideoAnalyzerOperationStatuses_"))]'
transform: >
$["operationId"] = $["operationId"].replace("VideoAnalyzerOperationStatuses_", "OperationStatusesForVideoAnalyzer_")
from: swagger-document
where: '$.paths.*[?(@.operationId.startsWith("VideoAnalyzerOperationResults_"))]'
transform: >
$["operationId"] = $["operationId"].replace("VideoAnalyzerOperationResults_", "OperationResultsForVideoAnalyzer_")	operation group collision
model collision
webpubsub	directive:
rename-model:
from: 'WebPubSubResource'
to: 'ResourceForWebPubSub'	model collision
web (appservice)	directive:
rename-model:
from: 'AppServiceCertificate'
to: 'CertificateForAppService'
rename-model:
from: 'AppServiceCertificateCollection'
to: 'CertificateCollectionForAppService'
rename-model:
from: 'AppServiceCertificatePatchResource'
to: 'CertificatePatchResourceForAppService'	model collision

Regards,
Chenjie Shi

The guiding principle should be that the type that was renamed to not stutter should not further be renamed to avoid a name collision.
Using DataBoxEdge as the example, there are types "DataBoxEdgeSku" and "Sku".  The former type is renamed to "Sku" to avoid stuttering which collides with the preexisting "Sku" type.  To avoid the collision, the preexisting "Sku" type should be appropriately renamed (e.g. maybe "SkuInfo" or "SkuData").  So the resulting codegen would look like this.
package databoxedge

// SKU was renamed from DataBoxEdgeSku to not stutter.
type SKU struct { /*...*/ }

// SKUInfo was renamed via an Autorest directive to avoid colliding with SKU
type SKUInfo struct { /*...*/ }

Update for the renaming:
cdn
directive:

rename-model:
from: 'CdnEndpoint'
to: 'LinkedEndpoint'

databox
directive:

rename-model:
from: 'JobDetails'
to: 'BaseJobDetails'
rename-model:
from: 'JobSecrets'
to: 'BaseJobSecrets'
rename-model:
from: 'ScheduleAvailabilityRequest'
to: 'BaseScheduleAvailabilityRequest'

databoxedge
directive:

rename-model:
from: 'Sku'
to: 'SkuType'

guestconfiguration
directive:

rename-model:
from: 'AssignmentReport'
to: 'BaseAssignmentReport'

labservices
directive:

rename-model:
from: 'LabServicesSku'
to: 'ExtendedSku'
rename-model:
from: 'PagedLabServicesSkus'
to: 'PagedExtendedSkus'

redis
directive:

rename-model:
from: 'RedisResource'
to: 'ResourceForRedis'

security
directive:

from: swagger-document
where: '$.paths.*[?(@.operationId.startsWith("Connectors_"))]'
transform: >
$["operationId"] = $["operationId"].replace("Connectors_", "AccountConnectors_");

signalr
directive:

rename-model:
from: 'SignalRResource'
to: 'ResourceForSignalR'
rename-model:
from: 'SignalRResourceList'
to: 'ResourceForSignalRList'

videoanalyzer
directive:

rename-model:
from: 'Properties'
to: 'MetricProperties'
from: swagger-document
where: '$.paths.*[?(@.operationId.startsWith("OperationStatuses_"))]'
transform: >
$["operationId"] = $["operationId"].replace("OperationStatuses_", "PrivateEndpointConnectionsOperationStatuses_")
from: swagger-document
where: '$.paths.*[?(@.operationId.startsWith("OperationResults_"))]'
transform: >
$["operationId"] = $["operationId"].replace("OperationResults_", "PrivateEndpointConnectionsOperationResults_")

webpubsub
directive:

rename-model:
from: 'WebPubSubResource'
to: 'ResourceForWebPubSub'
rename-model:
from: 'WebPubSubResourceList'
to: 'ResourceForWebPubSubList'

web (appservice)
directive:

rename-model:
from: 'Certificate'
to: 'AppCertificate'
rename-model:
from: 'CertificateCollection'
to: 'AppCertificateCollection'
rename-model:
from: 'AppServiceCertificatePatchResource'
to: 'AppCertificatePatchResource'

This has been resolved.


Fixes Borgs and Syndicats getting hurt by glass shards and other things + honkbot slipping 2

About the PR

Borgs and Syndicats no longer get hurt by things that require shoes.
The last branch for this got cooked whoops.
Why / Balance

🐛
Fixes #27492 and #27664
Technical details

see breaking changes
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

ClothingRequiredStepTriggerComponent has been renamed to PreventableStepTriggerComponent.
Removed StepTriggerImmuneComponent. Use the ProtectedFromStepTriggersComponent instead. Adding it to a clothing item will protect the wearer and adding it to a mob will protect the mob itself from step triggers on entities with thePreventableStepTriggerComponent.
 Time to remind them. Release the honkbots!
Thanks for the fix and sorry for the long wait on a review. I adjusted your breaking changes section to the new component names so people can easier fix it in forks.


Document CBO breaking up hotspots for time-ordered indexes via CHECK

Via discussion with @ajwerner on #4846, he pointed out a few updates to pay attention to re: schema design for performance, in particular that the CBO can add filters to a query based on CHECK constraints, which can lead to improved performance in some scenarios.  Specifically, he says, in reference to the other things linked here, that:

The technique allows users to alleviate write hot spots by making reads more expensive. It doesn't generally come up in cases where UUID is available to you but for time-ordered indexes it can be very powerful.

The linked ticket has more details, but one use case enabled by this in particular may be around breaking up hotspots for time-ordered indexes, as per this comment.
The specific use case described in that comment is probably the most "document-able", and is enabled by cockroach#37616 according to Werner (IIUC).
Estimated scope of work:

investigate / understand all of the above
see how / if it can be used to improve performance via proper schema design
document examples showing the above

IMO this might be one of most powerful but difficult to use features of 19.2. For applications which require a sequential insert pattern on an index this functionality is a game changer and provides a relatively clean solution to a problem we previously did not have a good answer for. This is the case, for example, if you are tracking a fleet of IOT devices and you want to know which devices are active in some time period.
For example, say we have devices we are tracking and each device creates events:
CREATE TABLE devices (id UUID PRIMARY KEY, metadata JSONB);

CREATE TABLE events (
    device_id
        UUID REFERENCES devices (id),
    event_id
        UUID,
    ts
        TIMESTAMP,
    data
        JSONB,
    PRIMARY KEY (device_id, ts, event_id),
    INDEX (ts)
);

You would have a hot spot on that INDEX (ts) which would be rather unfortunate.
You can alleviate this hot spot by sharding this time ordered index.
CREATE TABLE devices (id UUID PRIMARY KEY, metadata JSONB);

CREATE TABLE events (
    device_id
        UUID REFERENCES devices (id),
    shard
        INT8
        AS (fnv32(device_id) % 8) STORED
        CHECK (shard IN (0, 1, 2, 3, 4, 5, 6, 7)),
    event_id
        UUID,
    ts
        TIMESTAMP,
    data
        JSONB,
    PRIMARY KEY (device_id, ts, event_id),
    INDEX (shard, ts)
);

Just that schema change will now spread the write load out by a factor of 8 while increasing query costs. For single-column shard keys which can be readily cast to bytes it's not too hard to do. Using multiple columns as a shard key is much less fun. Perhaps we should work to make this functionality easier to use. I'll make an issue about improving this user story in the cockroach repo.


Problems with menubar icon hidden - access settings

Hey there,
I saw that this problem got tagged as solved before, but I'm a new user and have this problem now:
I want to hide the menubar icon, but then I cannot open the settings. Neither ´defaults write com.ameba.TRex ShowMenuBarIcon 1´ nor trying to get to the settings using the url ´trex://showPreferences´ works.
I had to uninstall the app with appcleaner and then uninstall and (re)install it in homebrew to get the menubar icon back; and now I don't want to hide it again for obvious reasons.
Could you check if that is perhaps fixable?
It would be cool if the settings pane could just be reached by open the app again when already running like many other apps behave.
I use the newest/updated version of Sonoma btw.
Best regards
Q
EDIT: I don't know why, but ´trex://showPreferences´ works now. I guess this can be closed. Thank you for this awesome app btw. ♥

Experiencing this as well. Agree that it would be cool if settings opens up by opening the app. The URL is not working for me in Arc or Raycast. Will try to uninistall and reinstall

            It's not that the settings window will open directly, but TRex will get set as the focused forefront app, hence shows in the menubar (left).You have to open the settings then on your own, for example by navigating through the menubar or simply pressing the usual hotkey `cmd - ,`.At least that’s how it works on my end.Am 17.09.24 um 04:38 schrieb Benny Goldman

                Von: "Benny Goldman"<EMAIL_ADDRESS>17. September 2024An: "amebalabs/TRex"<EMAIL_ADDRESS>"qns" ***@***.***>,"State change"<EMAIL_ADDRESS>Re: [amebalabs/TRex] Problems with menubar icon hidden - access settings (Issue #38)

Experiencing this as well. Agree that it would be cool if settings opens up by opening the app. The URL is not working for me in Arc or Raycast. Will try to uninistall and reinstall
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: @.***>


Display 'Posts' header only if the site has posts

This is an enhancement or feature.

Summary
Display the 'Posts' section only if there are posts available.

Context
Currently, there is no check whether there are posts available or not.
Due to this, even if there are no posts, still the 'Posts' header was visible.
So I added a check to display the posts section only if the site has posts available.

Thanks for the PR!


Travis-CI Test Build #447 introduced atexit._run_exitfuncs errors

I just noticed starting from Build #447 (https://travis-ci.org/openworm/PyOpenWorm/builds/70450878), we've had every test's atexit call fail as follows:
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
File "/opt/python/2.7.9/lib/python2.7/atexit.py", line 24, in _run_exitfuncs
func(*targs, **kargs)

File "./PyOpenWorm/init.py", line 114, in disconnect
if not m.connected:

AttributeError: 'module' object has no attribute 'connected'

You're right, this output doesn't seem to affect the passing/failing of tests but something weird is definitely going on. Good catch @cheelee

@kevcmk's #216 seems to fix this (or at least not flood the output with this text). If we can get the test numbers to match up we could potentially close this one.

Yah, agreed.

The test numbers match up. py.test is correct and our old test.py ended up generating 77 duplicate tests, whilst missing 12 tests that py.test caught. This is good. Thanks for the great feedback @travs and the awesome job using py.test @kevcmk . I'm closing this issue, and I think we can make that pull request merge official.

@cheelee Awesome! Thanks for looking into this :)


Add "Welcome Talk" session to FakeSessionsApiClient

Idea Description
In order to facilitate various testing scenarios, we need to add a "Welcome Talk" session to the FakeSessionsApiClient. This addition should follow the pattern established in Timetable.fake().
Reference images and links
For guidance on how to add the session to FakeSessionsApiClient, please refer to the following pull request: PR #576.

Can I take this issue ?

@sanao1006 Thanks! Assigned!

@takahirom
Hi, I have a question.
"Add "Welcome Talk" session to FakeSessionsApiClient" means adding a SessionResponse to the sessions in FakeSessionsApiClient.kt such that the title property is LocaledResponse(ja = " Welcome Talk", en = "Welcome Talk")?
ex)
    sessions.add(
        SessionResponse(
            id = "1",
            isServiceSession = true,
            title = LocaledResponse(ja = "ウェルカムトーク", en = "Welcome Talk"),
            speakers = listOf("1", "2"),
            description = "これはディスクリプションです。\n" + "これはディスクリプションです。",
            startsAt = LocalDateTime.parse("2023-09-15T10:00:00")
                .toInstant(TimeZone.of("UTC+9")).toString(),
            endsAt = LocalDateTime.parse("2023-09-15T10:20:00")
                .toInstant(TimeZone.of("UTC+9")).toString(),
            language = "JAPANESE",
            roomId = 1,
            sessionCategoryItemId = 1,
            sessionType = "NORMAL",
            message = null,
            isPlenumSession = false,
            targetAudience = "For App developer アプリ開発者向け",
            interpretationTarget = false,
            asset = SessionAssetResponse(
                videoUrl = "https://www.youtube.com/watch?v=hFdKCyJ-Z9A",
                slideUrl = "https://droidkaigi.jp/2021/",
            ),
            levels = listOf("INTERMEDIATE"),
        )
    )

If my recognition is incorrect, I would appreciate it if you could point it out to me!

@sanao1006
Thank you for confirming this! This is a real response we are using. For example we don't have speaker for it and sessionType is WELCOME_TALK. Could refer to it?
    {
      "id": "0570556a-8a53-49d6-916c-26ff85635d86",
      "title": {
        "ja": "Welcome Talk",
        "en": "Welcome Talk"
      },
      "description": null,
      "i18nDesc": {
        "ja": null,
        "en": null
      },
      "startsAt": "2023-09-15T10:30:00+09:00",
      "endsAt": "2023-09-15T10:45:00+09:00",
      "isServiceSession": true,
      "isPlenumSession": false,
      "speakers": [],
      "roomId": 35498,
      "targetAudience": "TBW",
      "language": "JAPANESE",
      "lengthInMinutes": 15,
      "sessionCategoryItemId": 182589,
      "interpretationTarget": false,
      "asset": {
        "videoUrl": null,
        "slideUrl": null
      },
      "message": null,
      "sessionType": "WELCOME_TALK",
      "levels": [
        "UNSPECIFIED"
      ],
      "noShow": false
    },

{
"id": "0570556a-8a53-49d6-916c-26ff85635d86",
"title": {
"ja": "Welcome Talk",
"en": "Welcome Talk"
},
"description": null,
"i18nDesc": {
"ja": null,
"en": null
},
"startsAt": "2023-09-15T10:30:00+09:00",
"endsAt": "2023-09-15T10:45:00+09:00",
"isServiceSession": true,
"isPlenumSession": false,
"speakers": [],
"roomId": 35498,
"targetAudience": "TBW",
"language": "JAPANESE",
"lengthInMinutes": 15,
"sessionCategoryItemId": 182589,
"interpretationTarget": false,
"asset": {
"videoUrl": null,
"slideUrl": null
},
"message": null,
"sessionType": "WELCOME_TALK",
"levels": [
"UNSPECIFIED"
],
"noShow": false
},

I could confirm that response from "https://ssot-api-staging.an.r.appspot.com/events/droidkaigi2023/sessions"!
These real responses have properties like "i18nDesc" and "noShow", but the SessionResponse class has no such properties.
So does this mean that a new data class is needed for the real responses?
Example of naming) WelcomeTalkResponse or WelcomeTalkSessionResponse, etc.

@sanao1006
Thanks for your question!

These real responses have properties like "i18nDesc" and "noShow", but the SessionResponse class has no such properties.
So does this mean that a new data class is needed for the real responses?

No, you don't have to implement of serialization about any unused property
so, Could you implement fake response about like this
speaker -> emptyList()
session-type -> WELCOME_TALK(maybe need to add WELCOME_TALK to enum)

@RyuNen344

speaker -> emptyList()
session-type -> WELCOME_TALK(maybe need to add WELCOME_TALK to enum)

I tried to implement adding a fake response to FakeSessionsApiClient that would satisfy the above conditions. Is there any problem?
(以上の条件を満たすようなfake responseをFakeSessionsApiClientに追加する実装をしてみました。どうでしょうか？)
    sessions.add(
        SessionResponse(
            id = "0570556a-8a53-49d6-916c-26ff85635d86",
            title = LocaledResponse(ja = "Welcome Talk", en = "Welcome Talk"),
            description = null,
            startsAt = "2023-09-15T10:30:00+09:00",
            endsAt = "2023-09-15T10:45:00+09:00",
            isServiceSession = true,
            isPlenumSession = false,
            speakers = emptyList(),
            roomId = 35498,
            targetAudience = "TBW",
            language = "JAPANESE",
            sessionCategoryItemId = 182589,
            interpretationTarget = false,
            asset = SessionAssetResponse(videoUrl = null,slideUrl = null),
            message = null,
            sessionType = "WELCOME_TALK",
            levels = listOf("UNSPECIFIED")
        )
    )

I set sessionType to String "WELCOME_TALK" because the type of SessionResponse is String. I am not sure what I should do if I use enum. Should I use TimetableSessionType or create a new enum class?
(SessionResponseの型がString型なのでsessionTypeをString型の"WELCOME_TALK"に設定しています。もしenumを使うならばどうすべきかよくわからないです. TimetableSessionTypeを使うのか、はたまた新しくenumクラスを作成するべきでしょうか)

@sanao1006
I think you can make PR and we can comment on it.
But can you use this time to see it in the screenshot tests?
startsAt":"2023-09-14T10:30:00+09:00","endsAt":"2023-09-14T11:00:00+09:00" (This is the start time of DroidKaigi)

That is correct. Anyway, I'll create a PR soon!


Search results appends to the end of previous results in gtk-pipe-viewer

And no error or warning. So, results not clear and replaced by new results (as gtk-straw-viewer do) but new results appends to the end. It's strange. I use pipe-viewer-git from AUR

Ah lol, I see in prefs "clear_search_list" string. I think 1 should be default.

The option clear_search_list is 1 by default (source). The option is also controlled by the "Clear search list" in "Other options".


GetFile -  allow file read to begin at a certain offset number of bytes

Story:
A user is downloading a big file, and that file download is interrupted/fails while it's successfully written a fraction of the total bytes.  The user would like to retry the download without having to re-load all of the completed bytes.
Proposed UX:
Add a --retry flag to pachctl get file <FILE> -o <OUTPUT> that is interpreted to only read the file's bytes beginning at the length of the current OUTPUT file.
As a part of this change, we also expose a --offset flag that can be used to specify getting file starting a certain offset number of bytes within the file.
See:
https://github.com/pachyderm/pachyderm/issues/6536

On Friday, @brycemcanally had mentioned that we will ultimately want to have resumable downloads/uploads implemented by potentially running the storage layer client-side, and have it be able to coordinate to see what data is stored in pach.
Is the behavior here any different than that of resumable downloads? My understanding is that this "retry" path is the more manual of the two, since it's initiated by the user, whereas the "resume" path could potentially automatically handle more failure scenarios.
Are there other future considerations we should be making as part of this story?
What do you think @brendoncarroll & @brycemcanally ?


cleanup injector

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 28 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 99.556%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
11740

Relevant Lines:
11744

💛  - Coveralls


Ingredient

Draft description:
From the ISO logical model and from discussion including in the latest FHIR Connectathon, having a separate Ingredient resource, while we can make it work, seems unnatural and not following the expected way the data is usually taken.
The link FROM the resources TO Ingredient seemed more natural, but this was changed. After several discussions, it seems that the Ingredient is needed under ManufacturedItem and AdministrableProduct (where it has slightly different meanings and sometimes the same data, sometimes not - example the ingredients in the solvable product vs the ingredients in the prepared solution) . Can this Ingredient resource be collapsed under those 2 resources?

https://jira.hl7.org/browse/FHIR-39138

This is resolved. Ingredient stays because it is perceived as convenient


请问下build会报错tauri-plugin-sql，是什么问题：）

error: no matching package named tauri-plugin-sql found
location searched: https://github.com/tauri-apps/plugins-workspace?branch=v1#a305ad3d
required by package tickets v0.0.0 (/Users/xxx/tmp/tickets/src-tauri)
Error failed to build app: failed to build app
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

这个包安装失败了。重新安装 包

上次build成功之后，后面还是会出现这问题orz

WARNING: Only one package manager should be used, but found npm and yarn.
Please remove unused package manager lock files, will use npm for now!
[✔] Environment
- OS: Mac OS 13.4.0 X64
✔ Xcode Command Line Tools: installed
✔ rustc: 1.63.0
✔ Cargo: 1.63.0 (fd9c4297c 2022-07-01)
✔ rustup: 1.26.0 (5af9b9484 2023-04-05)
✔ Rust toolchain: stable-aarch64-apple-darwin (default)
- node: 16.20.0
- pnpm: 8.6.3
- yarn: 1.22.19
- npm: 8.19.4
[-] Packages
- tauri [RUST]: 1.3.0
- tauri-build [RUST]: 1.3.0
- wry [RUST]: 0.24.3
- tao [RUST]: 0.16.2
- @tauri-apps/api [NPM]: 1.3.0 (outdated, latest: 1.4.0)
- @tauri-apps/cli [NPM]: 1.3.1 (outdated, latest: 1.4.0)
[-] App

➜  tickets git:(0a39048) yarn install
yarn install v1.22.19
warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 🔨  Building fresh packages...
success Saved lockfile.
✨  Done in 19.87s.
➜  tickets git:(0a39048) ✗ yarn tauri build
yarn run v1.22.19
$ tauri build
Running beforeBuildCommand yarn build
$ vite build
vite v4.3.9 building for production...
✓ 1151 modules transformed.
dist/index.html                   0.46 kB │ gzip:   0.31 kB
dist/assets/dm-84c08ce0.css       2.21 kB │ gzip:   0.61 kB
dist/assets/index-72465220.css  391.06 kB │ gzip:  47.81 kB
dist/assets/dm-2d967aaa.js       21.17 kB │ gzip:   8.88 kB
dist/assets/index-43eda9c6.js   932.12 kB │ gzip: 274.96 kB
(!) Some chunks are larger than 500 kBs after minification. Consider:

Using dynamic import() to code-split the application
Use build.rollupOptions.output.manualChunks to improve chunking: https://rollupjs.org/configuration-options/#output-manualchunks
Adjust chunk size limit for this warning via build.chunkSizeWarningLimit.
✓ built in 2.97s
error: no matching package named tauri-plugin-sql found
location searched: https://github.com/tauri-apps/plugins-workspace?branch=v1#a305ad3d
required by package tickets v0.0.0 (/Users/xx/tmp/tickets/src-tauri)
Error failed to build app: failed to build app
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

error: no matching package named tauri-plugin-sql found ，你的包不是下过吗

对，很奇怪，之前build成功了，也没更新啥，再build就不行了
QAQ

这边大麦bp，脚本，代码和猫眼bp可长期提供，有需要的来➕q2814249606，备注github。主打信任不扯皮

我是获取包的时候总是失败，依赖都下不下来。error Command failed.
Exit code: 128
Command: git
Arguments: ls-remote --tags --heads<EMAIL_ADDRESS>Directory: D:\IE下载\tickets-0.4.2\tickets-0.4.2
Output:
Host key verification failed.
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
研究了半天了，挂不挂梯子都这个报错。


Fix for Issues #11944 #12382 - pass along a custom referrer

Currently if you set a custom referrer with page.customHeaders, document.referrer remains untouched.
This is described in detail within Issue #11944.
I've added a test to reflect the issue, and a patch to pass along any custom Headers to the request Object.
This PR replaces my initial Pull request #12318

What is the new version that already fixed the document.referrer problem? thanks.

Hi, when is this going to get merged?