fix: fix IPv6 related multicast problem

I noticed that there is a problem with IPv6 multicast addresses in the server right now. This PR adds a test case to illustrate the problem, but no solution yet.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
662 unchanged lines in 15 files lost coverage.
Overall coverage decreased (-54.6%) to 32.595%

Files with Coverage Reduction
New Missed Lines
%

lib/incoming_message.ts
8
42.86%

lib/parameters.ts
12
56.1%

lib/retry_send.ts
12
63.79%

index.ts
19
57.14%

lib/observe_read_stream.ts
21
7.14%

lib/middlewares.ts
24
25.37%

lib/cache.ts
25
23.33%

lib/outgoing_message.ts
26
39.62%

lib/block.ts
32
8.62%

lib/observe_write_stream.ts
32
7.32%

Totals

Change from base Build<PHONE_NUMBER>:
-54.6%

Covered Lines:
483

Relevant Lines:
1262

💛  - Coveralls


Revert authentication changes

@rohansingh @davidxia @mattnworb

:+1:

:+1:
There are a few refactorings in SystemTestBase I'd like to keep, but I'll just cherry-pick those.

Parts of all of these commits should be cherry-picked back in:

ece828e251262b534efb7e54a9b87272276af5d2
a6dcc0f46c69a5ee3e392018bca118cf775a8e41
75d4107e416cbeca67805d6278198c76c4d4d9d2
1c0010de7bd444224b382aaede8e86badbc2b76b

branch with those commits picked: https://github.com/spotify/helios/tree/mattbrown/awesome-tests

Opened #725 on that branch. It builds. I vote we close this and merge that.

+1


$EDITOR warning when editing configurations

I get the following warning whenever I try to edit the configuration cmd + ,:
λ  echo Attempting to open ~/.hyper.js with your \$EDITOR
Attempting to open /Users/skippednote/.hyper.js with your $EDITOR
λ  echo If it fails, open it manually with your favorite editor!
If it fails, open it manually with your favorite editor!
λ  bash -c 'exec env ${EDITOR:=nano} ~/.hyper.js'

I'm using fish shell (v 2.4.0) and have exported the $EDITOR variable as well (set -gx EDITOR "vim") and doing this makes the configuration open in vim instead of nano but I still see the above warning.
(*fish) λ echo $EDITOR
vim
(*fish) λ fish -v
fish, version 2.4.0

i'm getting the same error but i haven't changed the default editor (nano).

I'm not sure it's related, but I just installed fish shell (2.5.0) and now whenever I try to access Hyper's settings via the keyboard shortcut or app menu it opens in TextWrangler (I have no idea why). My $EDITOR value is vim.

This should fix it 🤔 https://github.com/zeit/hyper/pull/1784 since now we don't use the commandline to open the editor.


update-doc-Klaw-Core

This PR will fixes #103  update docs to use the term "Klaw Core" correctly
fixes #103

For further queries feel free to connect.
Hope this will merge as soon as possible.

@Rawshansharma  thanks for your PR! 🎉
Could you check with npm run spell:error again? For me it flags one other file, too.
Also, your branch will need to be updated, since it's having a conflict with main.


Improved TypeScript 3.7 Support

I was running into an issue using TypeScript 3.7 with optional chaining and React Fragments using empty tags (<>...</>). In order to get both working properly the TypeScript preprocessor needs some minimal changes:
diff --git a/node_modules/i18n-tag-schema/dist/lib/preprocessors/typescript.js b/node_modules/i18n-tag-schema/dist/lib/preprocessors/typescript.js
index 0e5cd94..60923e3 100644
--- a/node_modules/i18n-tag-schema/dist/lib/preprocessors/typescript.js
+++ b/node_modules/i18n-tag-schema/dist/lib/preprocessors/typescript.js
@@ -15,8 +15,8 @@ exports.default = function (contents, filePath) {
   if (!ts) throw new Error('cannot find typescript compiler. check if \'typescript\' node module is installed.');
   var processed = ts.transpileModule(contents, {
     compilerOptions: {
-      target: ts.ScriptTarget.Latest,
-      jsx: path.extname(filePath) !== '.ts' ? ts.JsxEmit.Preserve : ts.JsxEmit.None
+      target: ts.ScriptTarget.ES2020,
+      jsx: path.extname(filePath) !== '.ts' ? ts.JsxEmit.React : ts.JsxEmit.None
     }
   });
   if (processed && processed.outputText) {

By setting ES2020 we force transpiling optional chaining syntax (such as foo?.bar and foo ?? bar). ts.JsxEmit.React is needed for proper fragment support.

Thank you for your contribution!
I don't want to enable ES2020 for the default preprocessor because it is still a draft. But you could release your preprocessor as an npm package with more sophisticated features and configurations.
The preprocessor that comes out of the box is really just a basic implementation for starters and to show what's possible with this library.
https://github.com/skolmer/i18n-tag-schema#-preprocessors


Added Digital Ocean Services to YML file

Fixes #95
Proposed Changes

Added Digital Ocean services to YML file

Services Added are:

ComputeInstance-Do Droplets
Kubernetes- Do Kubernetes
Nosql- Do Databases
RDBMS- Do Databases
DNS- Do Domains
LoadBalancer: Do LoadBalancer
KeyManagement: Do Keys
BlockStorage: Do Volumes

Few Issues:

There is problem in compute-instance where there is single function named requestActions for multiple services like starting instance, stopping, etc and they have to be passed as parameter to the function
Similarly there is single class called Database for nosql, RDBMS, etc and here also sql, nosql are to be passed as parameters to the functions
For now they have been added as it is, i.e, functions and classes are repeated in YML file for different functionalities(Only in Case of ComputeInstance, Nosql and RDBMS service)

Few Issues:

There is problem in compute-instance where there is single function named requestActions for multiple services like starting instance, stopping, etc and they have to be passed as parameter to the function
Similarly there is single class called Database for nosql, RDBMS, etc and here also sql, nosql are to be passed as parameters to the functions
For now they have been added as it is, i.e, functions and classes are repeated in YML file for different functionalities(Only in Case of ComputeInstance, Nosql and RDBMS service)

That's fine as we discussed in the meeting, can be improved in a future enhancement with a new design for the generator.


Remove UseExceptionHandler() extension

The ExcptionHanlerMiddleware no longer supports empty options. Either ExceptionHandler or ExceptionHandlingPath has to be set. Therefore, the ExceptionHandlerExtensions.UseExceptionHandler() overload that takes no arguments can't be used. Either remove this or set a default for the options.

This overload can be used with services.Configure<ExceptionHandlingOptions>(options => ...);

Thank you, I did not think of that.


Make global beforeAll function for integration tests

A number of the integration tests are currently broken on master and are still broken. I haven't had time to fix them all, but I will do that in a separate PR since it will take a fair amount of time. For now, this PR just lays the groundwork for having a global beforeAll function.

Pull Request Test Coverage Report for Build 1087

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 66.954%

Totals

Change from base Build 1083:
0.0%

Covered Lines:
3604

Relevant Lines:
4900

💛  - Coveralls

I'm going to go ahead and merge this since the LGTM analysis is currently broken.


Proof of concept - run as non root

Proof of concept PR only.
If the changes look okay I will apply these changes to max-base instead of each model:
RUN useradd --create-home max
WORKDIR /home/max/
RUN cd /home/max && mkdir assets

max-base PR: https://github.com/IBM/MAX-Base/pull/42

Tests failed due to an unrelated bandit bug


GitHub link content change

https://github.com/haveno-dex/haveno-site/blob/f5ed7caa15c319d9987e68a7bfa674f7fab8e1d3/index.html#L12
Content just needs changing to GitHub

Thanks @georgehanlon :) Fixing with #17


send to kindle resolution

Hello @celogeek
For your information, some people have reported that send to kindle is limited in resolution.
Down scaling to 1440x1920 might give the same result, but with more pages possible with the same size limit constraint -limitmb

@darodi I have sent recently several epubs to my Scribe using Send to Kindle via web. They are converted to AZW3, and to the best of my recent experience the image resolution is still downscaled (down to 1440x1920).
Originally posted by @nicoladicicco in https://github.com/ciromattia/kcc/issues/460#issuecomment-1523829841

Interesting. So amazon downgrade the image to a lower resolution.
The 1920x1440 as an aspect ration of 1:1.33 like the resolution of the kindle.
Amazon advice to use a ratio of 1:1.6, so image of 1920x1200 should be good enough.
But they also say if you are using zooming to send an image of twice this size: 3840x2400 ...
I create some HR profile, specially when you are using tablette or something else.
I will create a standard profile with the 1920x1200 resolution. It could be great then to upload HR & standard, and then compare what the kindle received.
If you are using kindlegen or kindlepreviewer -convert, do we have this limit ? like sideloading directly ?

Here: https://kdp.amazon.com/en_US/help/topic/G9GSTY4LTRT39D4Z

I've extract the AWZ3 I receive from the device. I used calibre to convert this into a zip.
The height is 1920 all the time, but the ratio is the one I've set.
I've got: 1226x1920, 1:1.56 for example.
It looks to be the maximum height allow. If it's lower, it keep the size.
I will see if I can create an AZW3 with higher resolution. I only know calibre that can do this. I wonder if they are library or tools that allow to create this format directly.
May be this format is a kind of simple zip with some html ... I need to study this.

I try kindlepreview epub -convert of my HR files.
It generate a mobi.
My epub size = 245M
The images size are 1814x3031 (3031 max)
The mobi size = 384M !
The images size is 1920x... or ...x1920 (max 1920 for width and height)
I can copy the file to the kindle, it works. So epub -> kindlepreviewer epub -covert, allow to copy the content to the kindle without the 200mb limit, but still, the image resolution stay limited like the website.
I see they is a GoLang module to create AWZ3 files directly !
It would be very interesting to be able to generate this format instead of the epub (or both may be).
And good point, is that I won't need external tools to do it.
I will do some test.
In the mean times, I will add a profile for the 1920 resolution, it will be far better for the size of the epub with the current limitation.

When I try with a standard resolution, the mobi size = 246M instead of 384M.
But when I ask calibre to transform to zip or epub, it's very fast, and the size of the file is 126M.
So Mobi from HR = 384M, Epub from it = 126M
Mobi from SD = 246M, Epub from it = 126M
Both image in the epub has 1920x max.
So the mobi is bigger from the bigger image. I wonder if the extract from calibre is not the one that truncate the image after all.

with kindlegen you should use -dont_append_source to get a correct size.
kindlegen -dont_append_source -locale en inputfile.epub

Trying.
The 1920 image size convert in few sec.
The bigger file take times, so I guess it's resizing (not in parallel).
SD = 124M
HR = 129M
Right, so it's clearly downsize here.
This "dont_append_source" seems to be an hidden parameters.
Why do they add the original source in the mobi ? is that for higher resolution screen ? or just to have a copy of the source there ? But it will be useless when we want to read this on device right ?

Any chance the high resolution device use this source image instead of the compacted version ?
The sendtokindle website strip the source too ?

I create the profile SR: Standard Resolution: 1200x1920 (aspect 1:1.6)
It max out what amazon support.
The size of the file is close to the mobi now.
The speed of conversion is awesome.
I've just send 110 comics, with 100M each, it take less than an half an hour.
I can see email incoming while I was sending batch of 20.
So I wonder if that really necessary to have all of those profiles finally.
And HR and SR is enough I guess.
HR if you don't use Kindle, and the reader support large image.
SR for kindle conversion and/or reasonable good size/quality.
Every other kindle may have smaller size result as I guess it won't display it better with larger image.
The advantage of the SR is that you can put the comics in the cloud, then read it on any kindle device you've got.

Out of curiosity, do you get the same result with a pdf input and send to kindle?

I've read that PDF put directly on device vs PDF sent in the cloud have different feature on the device.
I haven't check, the size and quality, but when I use the cloud, I have Advanced TypeSettings activated.
So I can change the contrast on device (I like this feature, but it's only for PDF sent in the cloud), and I think orientation.
But I don't have like ePub spreading 2 pages on the screen, or manga mode.
So PDF is more a static version of what you want in normal mode.
Also on GoLang I've found some module to create Mobi (PalmDoc).
I also find a module that is an helper for created KF8-style formatted MOBI and AZW3:
https://github.com/leotaku/mobi.
And the same author create a tools to convert manga directly to AZW3 that can be sideloaded on device.
https://github.com/leotaku/kojirou.
The generated file should have less feature as the one from amazon, but I note to try with bigger image in this.
I know mobi has limitation, so I will see if that is one.

I've do a test with kijirou tools and my local png.
So I've got full resolution scan with 1920x3031 size, color, in PNG format.
The tools will convert it to JPG but that's it, same resolution, same color, and default quality.
The image size vary from 300kb to 1.7mb. most are around 800kb.
I copy it to my kindle, I've got the thumbnail and the book that is working.
So definitively that's an interesting option I can add to my tools.
Like export-format: epub, awz3

It seems PDF support improved lately. I will check again. Stuff like 2 pages on landscape ...

PDF is not so good (no way to deal with double page properly, and landscape/portrait) and image are resized.
So the best for now is the SR profile I create with resolution of 1200x1920
This one won't need resizing from amazon and will have super fast processing speed.
It works on all devices, so best think I can do right now.
Creating AWZ3 in a custom format is also a solution, as it seems we can set a higher resolution.
I'm not sure it has a better rendering at the end.
May be we should wait that amazon increase the resolution they support with their conversion tools.

So I've got full resolution scan with 1920x3031 size, color, in PNG format.

Thank you for this test! I have tried it, I I really notice the difference between mobi using go-comic-converter and azw3 file generated from images in disk using kojirou. AZW3 It is MUCH sharper on Kindle Scribe.
It would be awesome if you can integrate awz3 generation the same way kojirou does :D

@romancin Good to know ! I was wondering. I will see what I can do.
I don't know if I can do everything I do with the ePub, I will need to try.
holidays soon, best time to do this kind of stuff ;)

@romancin Good to know ! I was wondering. I will see what I can do.
I don't know if I can do everything I do with the ePub, I will need to try.
holidays soon, best time to do this kind of stuff ;)

Awesome! Thank you very much! I can test everything you need in my scribe :)

Got a scribe too and use it to test, and an Oasis for smaller device ;)

Thank you for this test! I have tried it, I I really notice the difference between mobi using go-comic-converter and azw3 file generated from images in disk using kojirou. AZW3 It is MUCH sharper on Kindle Scribe.

The MOBI from Send to Kindle is compressed to 256K per image, up to 1920 height, though I've seen as low as 1257 height, so it's expected to be less sharp. Originally posted here: https://github.com/ciromattia/kcc/issues/460#issuecomment-1523995169

Hi again @celogeek ! Any news on this? It is still not possible to use native Scribe resolution?

Sorry, not yet. I've got plenty of update to do, I need to find time for working on it.
The primary goal of the project was to allow creation of ePub that can be uploaded to the AWS cloud and then the ability to read it on any device.
I need to create a todo list


Added Company Portfolio Extension

Description
I've added the company portfolio extension
This is the whole portfolio website with all working pages if you found it suitable for level 2 so please add level 2 i am attaching the video below
Fixes:  #829
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] I have made this from my own
[x] I have taken help from some online resourses
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK
https://github.com/Sulagna-Dutta-Roy/GGExtensions/assets/118350936/4870c866-8b1f-4954-ab98-eeb7c59bd383

@Sulagna-Dutta-Roy  i fixed it please review it again

@Sulagna-Dutta-Roy  i want to ask one question can i also open issues for the projects that are already in repository .


Error when generating app-shell

Versions
Angular CLI: 1.6.0
Node: 6.11.5
OS: linux x64
Angular: 5.1.0
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

@angular/cli: 1.6.0
@angular-devkit/build-optimizer: 0.0.35
@angular-devkit/core: 0.0.22
@angular-devkit/schematics: 0.0.41
@ngtools/json-schema: 1.1.0
@ngtools/webpack: 1.9.0
@schematics/angular: 0.1.10
@schematics/schematics: 0.0.10
typescript: 2.4.2
webpack: 3.10.0

yarn 1.3.2 (same with npm 3.10.10)

Repro steps

ng new testshell
set angular 5.1.0 and add @angular/router
npm install
ng generate component home
add router-outlet
setup routes like that:

import { BrowserModule } from '@angular/platform-browser';
import { NgModule } from '@angular/core';

import { RouterModule, Routes } from '@angular/router';

import { AppComponent } from './app.component';
import { HomeComponent } from './home/home.component';

const appRoutes: Routes = [
  { path: '', component: HomeComponent },
]

@NgModule({
  declarations: [
    AppComponent,
    HomeComponent
  ],
  imports: [
    BrowserModule, RouterModule.forRoot(appRoutes)
  ],
  providers: [],
  bootstrap: [AppComponent]
})
export class AppModule { }

Observed behavior
[~/projects/testshell]$ ng generate app-shell --route shell                                                                                *[master]
Cannot read property 'split' of undefined
TypeError: Cannot read property 'split' of undefined
    at Class.run (/home/tde/projects/testshell/node_modules/@angular/cli/commands/generate.js:110:63)
    at resolve (/home/tde/projects/testshell/node_modules/@angular/cli/ember-cli/lib/models/command.js:261:20)
    at Class.validateAndRun (/home/tde/projects/testshell/node_modules/@angular/cli/ember-cli/lib/models/command.js:240:12)
    at Promise.resolve.then.then (/home/tde/projects/testshell/node_modules/@angular/cli/ember-cli/lib/cli/cli.js:140:24)

I was getting the same error, but I figured out I was entering the wrong command.
What you need to do is either:
ng generate app-shell my-loading-shell   --universal-app=universal-app --route=app-shell-path

or
ng generate app-shell [ --universal-app <universal-app-name>] [ --route <route>] // notice the brackets

Closing...
Duplicate of #8793


CopyPasteManagerTest fails to test all values

CopyPasteManager unit tests were not fully run, the first item of arrays were never tested. (Luckily, the not-tested values were ok).
Description of the changes:
while(--size)
the following code won't run the code in the loop with size==0.
Instead we should use:
while(--size >= 0)
Before (first value not tested):

After (the test fails as expected):

Do we need to open a Issue ticket when it doesn't concern the app itself?

Woah. Nice catch, Rudy.
I detest pre-increment/decrement. In my experience, more times than not, their usage leads to bugs. Whenever I see pre-increment/decrement, Case in point. I have to slow down significantly when reading the code to understand why that part of the code is so special.
Your fix is correct. I'd much prefer it though if you simply switched it to being a for loop with an inline-declared int i iterator (e.g. for (int i = 0; i < size; i++)). You'd have to update the access at 31, 40 and 457, but I think it would be totally worth it for just code clarity. Modifying size to use as an iterator is a really bad pattern, as it gives the completely wrong impression on what is going on...especially at 457. Think you can do one additional update to simply switch this to a for loop instead?
As for whether or not this needs an issue -- I'm working on getting the updated contributing guidance up by tomorrow. We've internally settled on keeping it consistent that there should be an approved issue for every PR that is reviewed. The bar for getting an issue approved will be lower for changes that don't impact what an end-user will see. PR's that are out before the updated contribution documentation is committed will be grandfathered in on a case-by-case basis. This one will be grandfathered in to not need the issue.

I can't more agree, this is the kind of "I try to optimize my code" but in fact, it adds bugs/makes the code harder to read, create an .exe less optimized because the compiler had more troubles to optimize the code".

Closing (and will immediately re-open) in order to kick off the PR build again.


Upgrade 11.0

feign core 11.0 upgrade
 TEST_RESPONSE = Response.builder()         .status(500)         .body((Response.Body) null)         .headers(testHeaders)         .request(Request.create(Request.HttpMethod.GET, "http://test", testHeaders, null))         .build();   }
Request.create ERROR
When will versions be compatible?
project Run Error log
`
APPLICATION FAILED TO START

Description:
An attempt was made to call a method that does not exist. The attempt was made from the following location:
feign.error.ExceptionGenerator.<clinit>(ExceptionGenerator.java:44)

The following method did not exist:
feign.Request.create(Lfeign/Request$HttpMethod;Ljava/lang/String;Ljava/util/Map;Lfeign/Request$Body;)Lfeign/Request;

The method's class, feign.Request, is available from the following locations:
jar:file:/Users/sinsanghun/.gradle/caches/modules-2/files-2.1/io.github.openfeign/feign-core/11.0/29fd8a94cae3f0450894b3875398d57222fce03c/feign-core-11.0.jar!/feign/Request.class

The class hierarchy was loaded from the following locations:
feign.Request: file:/Users/sinsanghun/.gradle/caches/modules-2/files-2.1/io.github.openfeign/feign-core/11.0/29fd8a94cae3f0450894b3875398d57222fce03c/feign-core-11.0.jar

Action:
Correct the classpath of your application so that it contains a single, compatible version of feign.Request
Process finished with exit code 1
`

Looks like this repo may be getting merged into core Feign at some point in the near future.
https://github.com/OpenFeign/feign/issues/1447

included in https://github.com/OpenFeign/feign/releases/tag/11.3


migrate root ca from 0.2.x

I don't understand what you mean by this. The ticket is cut on the assumption that it didn't account for this. So which is it? Is the ticket invalid? or do we need to include this change?

for 0.3.0 backup recovery, this is accounted for. it just isn't for 0.2.x. the 0.2.x recovery just needs to splice its tor address and cert into that existing code

closed in favor of #1105


Support for Python3+

Getting below error when trying to install with python3.
Command "python setup.py egg_info" failed with error code 1 in /private/var/folders/fr/jtjjqpbs1sx0lxh6qbgzgdjw00gftq/T/pip-build-8bphgsa2/robotframework-sudslibrary/
Please support for the python3.

I don't know if it's possible, as the tests will never run from the provided code. I doubt that it's relevant, but I'm commenting anyways.


Unfork RCTLogBox

Please select one of the following

[ ] I am removing an existing difference between facebook/react-native and microsoft/react-native-macos :thumbsup:
[ ] I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos :thumbsup:
[x] I am making a fix / change for the macOS implementation of react-native
[ ] I am making a change required for Microsoft usage of react-native

Summary
These files have some 'unnecessary' changes which make it hard(er) to merge in recent changes as: https://github.com/facebook/react-native/commit/37e5fa3a6ce
Hence un-forking them were possible
Changelog
[macOS][Fixed] Unfork RCTLogBox
Test Plan
CircleCi for macOS and iOS
Show some beautiful logboxes ...
https://user-images.githubusercontent.com/484044/201546620-6d3bf508-391b-4393-9a40-17322519dc2d.mov

@amgleitman any opinions? I remember you ran into this same diff during one of your last merges.


also let bootstrap tell us where to find xargo

@bors r+

:pushpin: Commit e71ca965b9bfda52f6720e718a631c324c35b196 has been approved by RalfJung

:hourglass: Testing commit e71ca965b9bfda52f6720e718a631c324c35b196 with merge 247786dba612b7103c4eb694f80f28b75d2e242b...

:sunny: Test successful - checks-travis, status-appveyor
Approved by: RalfJung
Pushing 247786dba612b7103c4eb694f80f28b75d2e242b to master...


Conversation flow in botkit

Hi Ram,
Is there a way I can implement a conversation flow similar to javascript botkit framework. Can you provide me any hint of how to implement this.
Krishna

Ram,
Thanks for getting back to me, as you can see, I took your code and embedded in my application and it works like a charm. Ideally, I want to include your framework as a maven repo in a Spring Boot application. Please provide few examples how to use your botkit as a part of maven repo.
Thanks
Krishna

Hi Krishna,
Yes, you can easily include this project as a maven dependency after Botkit is released to the central repository. I will include a sample in README file as well.

Hi Krishna,
I am happy to tell you that I have added the conversation feature as you requested. Do let me know if find any bugs or you get stuck somewhere.
Hope it helps you!
Thanks,
Ram


(Sparse)BitSet as (Sorted/Navigable)IntSets

BitSets and SparseBitSets can be used as backing data structure for IntSets, or, with some more work, even SortedIntSet or NavigableIntSet (if they are supported eventually). In a nutshell, BitSet stores the contained integers as flipped bits in a long array.
The beauty of these structures is that they can very compactly represent a set of non-negative integers (if they aren't to sparse). Further, one can use these bit sets to store the complement, enabling an even more compact representation for some sets. Also, if one is not interested in the result of these operations, BitSets can perform operations like union and intersection amazingly fast (using a bitwise or of the longs for , for example). A use case would be if one for example wants to "mark" certain elements of [0, n]. In my particular case, I use this implementation to e.g. store reachable / interesting / etc. states in a numbered graph.
I already have a (more or less) finished and tested implementation of this (using both a slightly optimized version of the above linked SparseBitSet and the Java BitSet). Since the Java Collection API demands a boolean return for operations like addAll, I added a BitIntSet interface which allows for e.g. void union(IntSet other) in order to allow use of the faster implementations if possible.

On 31 May 2017, at 11:41, Tobias Meggendorfer<EMAIL_ADDRESS>wrote:
BitSets and SparseBitSets can be used as backing data structure for IntSets, or, with some more work, even SortedIntSet or NavigableIntSet (if they are supported eventually). In a nutshell, BitSet stores the contained integers as flipped bits in a long array.
The beauty of these structures is that they can very compactly represent a set of non-negative integers (if they aren't to sparse). Further, one can use these bit sets to store the complement, enabling an even more compact representation for some sets. Also, if one is not interested in the result of these operations, BitSets can perform operations like union and intersection amazingly fast (using a bitwise or of the longs for , for example). A use case would be if one for example wants to "mark" certain elements of [0, n]. In my particular case, I use this implementation to e.g. store reachable / interesting / etc. states in a numbered graph.
I already have a (more or less) finished and tested implementation of this (using both a slightly optimized version of the above linked SparseBitSet and the Java BitSet). Since the Java Collection API demands a boolean return for operations like addAll, I added a BitIntSet interface which allows for e.g. void union(IntSet other) in order to allow use of the faster implementations if possible.

Well, both structures are only useful if you have very specific data distribution. If you set bits at position 64*k the SparseBitSet structure will quickly explode. For BitSet, this is even more true. It is quite rare that this kind of approach is useful. Also, BitSets can be ridiculously slow if they are sparse (lots of work to scan empty data).
From what I see, you use BitSet as a kind of compact array of Booleans. This is a typical usage, and it is absolutely fine, albeit much slower than an array of Booleans (usually, the gain in space is irrelevant because other data takes orders of magnitude more space than a Boolean).
In fact, LongArrayBitVector (from the DSI utilities) provides such sets since a looong time:
http://dsiutils.di.unimi.it/docs/it/unimi/dsi/bits/AbstractBitVector.html#asLongSet--
Ciao,
				seba

From what I see, you use BitSet as a kind of compact array of Booleans.

Correct, but arguably, any set of nonnegative integers is equivalent to a boolean array. Interpretation as a set of integers is just more natural for my use case: In a nutshell, states of a graph are enumerated and then algorithms are run on it. I use (Sparse)BitSets to, e.g., represent strongly connected components or reachably areas of the graph. Since this approach may be rather specific, it might not be worth including it in fastutil. I just have the code more or less ready.

This is a typical usage, and it is absolutely fine, albeit much slower than an array of Booleans (usually, the gain in space is irrelevant because other data takes orders of magnitude more space than a Boolean).

The relevant thing is that bulk operations like containsAll, union, etc. can be performed very efficiently between (Sparse)BitSets. When dealing with, say, 1e12 elements, performing or with two boolean arrays should be slower than BitSets (I did not verify this; I actually could try and implement a boolean[] based version of my BitIntSet and profile a bit), and more importantly, the difference in memory footprint is immense. boolean[] a) takes up to a byte (!) per element instead of a bit and b) is not sparse.
From reading the documentation, LongArrayBitVector is similar in spirit to Java's BitSet (with more convenience methods on top and longs instead of ints), right? More specifically, it is not sparse, which I would require for my application.

@incaseoftrouble
You know about Roaring bitmaps...?
http://roaringbitmap.org/

No I didn't, thanks for the pointer! I will look into this. Admittedly, I am fairly new to highly optimized datastructures in Java (as are most people in my field). I was abstracting an existing codebase which used BitSets hard-coded. Using abstraction + sparse bitsets as backend already gave a huge benefit there.
Is there is any benefit of wrapping these roaring bitmaps into BooleanList and/or IntSet of fastutil?
One more question, although this is diverging from the original issue: Do you think pairing up your implementation with fastutil (replacing the primitive iterators etc.) is worth considering?

Is there is any benefit of wrapping these roaring bitmaps into BooleanList and/or IntSet of fastutil? One more question, although this is diverging from the original issue: Do you think pairing up your implementation with fastutil (replacing the primitive iterators etc.) is worth considering?

I am not sure what you mean by "benefit", but I expect that it can be done if you need it.

Benefit as in "someone might make use of this work", which in turn justifies implementing this in fastutil. Similarly, for my second question, it might make sense to replace your implementation with fastutil's if it e.g. adds some functionality or enables people to use the some generic code with this particular implementation.

@incaseoftrouble

Benefit as in "someone might make use of this work", which in turn justifies implementing this in fastutil.
Similarly, for my second question, it might make sense to replace your implementation with fastutil's

The Druid people have wrappers  that implement com.google.common.collect.Sets. It works well in production within Druid right now. The same work can be done with fastutil if you want. Should be fairly trivial.

On 5 Jun 2017, at 21:31, Daniel Lemire<EMAIL_ADDRESS>wrote:
Is there is any benefit of wrapping these roaring bitmaps into BooleanList and/or IntSet of fastutil? One more question, although this is diverging from the original issue: Do you think pairing up your implementation with fastutil (replacing the primitive iterators etc.) is worth considering?
I am not sure what you mean by "benefit", but I expect that it can be done if you need it.

I think Thomas means that by wrapping them in a (somewhat) standardized primitive-type interface they can be plugged in existing code.
Ciao,
				seba

On 5 Jun 2017, at 22:20, Daniel Lemire<EMAIL_ADDRESS>wrote:
@incaseoftrouble
Benefit as in "someone might make use of this work", which in turn justifies implementing this in fastutil.
Similarly, for my second question, it might make sense to replace your implementation with fastutil's
The Druid people have wrappers that implement com.google.common.collect.Sets. It works well in production within Druid right now. The same work can be done with fastutil if you want. Should be fairly trivial.

Er... what do you mean by "implement com.google.common.collect.Sets"? It's a static container, not an interface.
Ciao,
				seba

On 5 Jun 2017, at 21:03, Daniel Lemire<EMAIL_ADDRESS>wrote:
@incaseoftrouble
You know about Roaring bitmaps...?
http://roaringbitmap.org/

In fact, you can even get close to the information-theory lower bound with dynamic Elias-Fano:
http://pages.di.unipi.it/rossano/wp-content/uploads/sites/7/2017/04/CPM17.pdf
I don't know how practical that can be made, but static Elias-Fano is the basic data structure throughout Facebook.
Ciao,
				seba

Er... what do you mean by "implement com.google.common.collect.Sets"?

Right. It implements java.util.Set<Integer>, which you can then plug into com.google.common.collect.Sets (e.g.).

On 6 Jun 2017, at 00:22, Daniel Lemire<EMAIL_ADDRESS>wrote:
Er... what do you mean by "implement com.google.common.collect.Sets"?
Right. It implements java.util.Set, which you can then plug into com.google.common.collect.Sets (e.g.).

But it doesn't implement it.unimi.dsi.fastutil.ints.IntSet (or LongSet--much more interesting), which I think it's Thomas's point.
Ciao,
				seba

I was pointing at an example of what can be done without too much effort.

On 6 Jun 2017, at 00:31, Daniel Lemire<EMAIL_ADDRESS>wrote:
I was pointing at an example of what can be done without too much effort.

BTW, do you have an idea of the space/speed relationship between Roaring Bitmaps and SparseBitSets?

BTW, do you have an idea of the space/speed relationship between Roaring Bitmaps and SparseBitSets?

Comparing data structures or software libraries is a tricky business.
If you care about memory usage, then SparseBitSet is maybe not the best choice,  see https://github.com/brettwooldridge/SparseBitSet/issues/4 (compare the plots)
Roaring has more users though, for sure.

So what do you guys think. Should we connect fastutil with Sparse/Roaring? I guess, since the introduced dependencies are rather heavy and usage is very scarce, the best idea would be to create a separate project which contains the additional code. I could do that, then you can have a look at the code if you are interested and see if the implementation might be useful.

I think it could be interesting, but to be really useful you would have to contribute to those project code for primitive-type accessors—wrapping will not work in this case. I mean, it's not a matter of bringing SparseBitSets into fastutil, but rather of bringing fastutil's interfaces to SparseBitSets.

In fact, I'm seeing that roaring's bitmaps implementation in defining from scratch stuff line IntIterator:
https://github.com/RoaringBitmap/RoaringBitmap/blob/master/src/main/java/org/roaringbitmap/IntIterator.java
And Druid has correspondingly adapters for fastutil:
https://github.com/druid-io/druid/blob/master/processing/src/main/java/io/druid/segment/IntIteratorUtils.java


v2.7.0 win32-x64 Not usable: SyntaxError: Unexpected token *

Hi
After installation using "npm install -g @liara/cli" on windows 10x64, all commands (except -v and help) show the following error:
"SyntaxError: Unexpected token *"

Hi,
What is your NodeJS version? Use node -v to check it out.
We recommend using Node >= 10.

Hi,
What is your NodeJS version? Use node -v to check it out.
We recommend using Node >= 10.

It was 8,
Upgrading to the latest version (14) solved the problem

It was 8,
Upgrading to the latest version (14) solved the problem


fix(rpc/client): stop overwriting existing clients

While working on #2356 I uncovered a bug:
When using the client.NewClient constructor, it uses a global static struct to set the modules. This led to clients overwriting each other when multiple are initialized.

Codecov Report

Merging #2361 (1cec22a) into main (0823f6b) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2361      +/-   ##
==========================================
- Coverage   50.86%   50.84%   -0.03%
==========================================
  Files         154      154
  Lines        9742     9742
==========================================
- Hits         4955     4953       -2
- Misses       4353     4354       +1
- Partials      434      435       +1

see 1 file with indirect coverage changes


Hide Temperature Section

Hey,
Is it possible to hide the temperature section (current weather), so that only the conditions are shown?
Is it also possible to reduce the space between the current weather and the forecast?

You can hide the temperature section by using show_main: false
It is not possible to reduce the space between the current weather and the forecast.

Thank you, but then I don’t see the current conditions (Icon and weather).
I only want to hide the temp, but my temp is shown separately on a chart card.

Ok, I will make it optional to hide the current temperature in a next release.

Thanks.
Would be great, if it could like this (a combination of weather card and weather-chart-card)


step 3: handling JSON responses in favourite pokemon button

use the fetch() function to request comments data
server responds with some hard-coded JSON data
JavaScript should add these comments to the page on "Pokemon" button

fixed some items, let me know if this works thank you!


djangosaml2 - 0.16.0

This is an open issue to please not update djangosaml2 to version 0.16.0 or any version that pins to pysaml2==4.4.0, as it breaks Okta authentications. I didn't test OneLogin.
Once pysaml2 has another release we can retest.
All of this is so we can avoid maintaining patches in this docker container.

Ping @clburlison What do you want to do with this?

Closing. This was a no action reminder to not update djangosmal2.


Fix issue with commandsAfterLogin array being overwritten with default values

This should solve #9
@zone11, would you like to try this PR solves the issue?

I'm sorry to tell you, but still broken. Removing all commands works fine, but as soon as I add one or two commands, separated by a comma, the commands are filled up to have at least 3.
Examples:
["SET/NAME CHRISTIAN"] -> ["SET/NAME CHRISTIAN","SET/SKIMMER CW","SET/SEEME"]

["SET/NAME CHRISTIAN","SET/SKIMMER SSB"] -> ["SET/NAME CHRISTIAN","SET/SKIMMER SSB","SET/SEEME"]


Feature request: GitHub links from Codespaces

On this article:
https://www.freecodecamp.org/news/learn-programming-in-your-browser-the-right-way/
it says that adding this HTML to a page will let you import the repo into Codespaces:

Is it possible to make this work with code-server? It doesn't seem to work at the moment.

This would be cool although we don't have any plans to add this at the moment. See https://github.com/cdr/code-server/issues/1355

Sorry, I missed that because it was closed

Should this be closed?

For now let's leave it open in case someone wants to work on it.


Perl6 support

Currently there is only support for Perl.

@antoniogamiz You aren't volunteering to maintain Perl6 support by any chance, are you? -)

Lets close this in favor of:  https://github.com/highlightjs/highlight.js/issues/1674  We only need one issue to track this.
@marcoscaceres


Fix hdmi_cec entity race

Update shouldn't be called before adding the entity.
Description:

update() is moved outside of the __init__(), otherwise it triggers entity creation with entity_platform.async_add_entities, see f241becf7f1976ab148e396e38619542c8a9121d.
add_entities is now updating those entities instead.
Callback is now registered with async_added_to_hass.
Callback is only schedules update with self.schedule_update_ha_state(True)

Related issue (if applicable): fixes #12846
Example entry for configuration.yaml (if applicable):
hdmi_cec:

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.

Hi @yottatsa,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

@MartinHjelmare addressed. Now I'm using add_entities(entities, True), and self.schedule_update_ha_state(True) is in the proper place.

@MartinHjelmare addressed.

Has this issue being fixed? I am still having the same problem
2020-03-06 12:06:10 ERROR (MainThread) [homeassistant.core] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 425, in _async_add_entity
    raise HomeAssistantError(msg)
homeassistant.exceptions.HomeAssistantError: Entity id already exists: switch.hdmi_2


engine: fix exec syncing on busybox

Hello @jazzdan,
Please review the following commits I made in branch nicks/tarballs2:
dfa81af83362ddabb0465e48499ad24a9edca99b (2019-06-27 15:36:04 -0700)
engine: fix exec syncing on busybox
Fixes https://github.com/windmilleng/tilt/issues/1611

tbh no idea why this fixes the problem 🤷♂

that's weird @nicks - busybox doesn't respect /dev/stdin? :man_shrugging:

@matthiasak ya! it's definitely weird. I suspect the problem is that the busybox tar assumes all files are regular files (whereas /dev/stdin is an abstract file descriptor that doesn't support arbitrary seek)


bump node 18.18.0 LTS

Applied mkpr on package.json
sed s/"node": ">=18.17.1"/"node": ">=18.18.0"/

:tada: This PR is included in version 6.4.5 :tada:
The release is available on:

npm package (@latest dist-tag)
v6.4.5
GitHub release

Your semantic-release bot :package::rocket:


load the images to any CRI on start from the local filesystem in providers

Is your feature request related to a problem? Please describe.

Preload the images into CRI from local file system in the kairos providers.
Describe the solution you'd like

In the providers conditionally check the path provided for archive files and load into containerd or any CRI on start.
Describe alternatives you've considered

Additional context

to preload the CRI with archived (tar) images from the filesystem.

@santhoshdaivajna is this done?

yes!


Type inference is incorrect for pipe(source, consumer), if consumer returns a function

Currently, the typings for pipe() are arranged in such a way that the Source-specific patterns take precedence over the generic consumer, causing pipe(source, consumer) to be typed as Source<unknown> if consumer returns a function.  A trivial example:
// x is inferred to be Source<unknown>, but should be `() => number`
let x = pipe(empty, src => () => 42)

However, as far as I can tell, all the Source-specific typings aren't needed, since the actual pipe() implementation is generic and can take any functions, so the typings could just be e.g.:
interface pipe {
  /* pipe definitions for source + operators composition */

  <T, A>(source: T, op1: UnaryFn<T, A>): A;

  <T, A, B>(
    source: T,
    op1: UnaryFn<T, A>,
    op2: UnaryFn<A, B>
  ): B;

  // ...

  <T, A, B, C, D, E, F, G, H>(
    source: T,
    op1: UnaryFn<T, A>,
    op2: UnaryFn<A, B>,
    op3: UnaryFn<B, C>,
    op4: UnaryFn<C, D>,
    op5: UnaryFn<D, E>,
    op6: UnaryFn<E, F>,
    op7: UnaryFn<F, G>,
    op8: UnaryFn<G, H>
  ): H;
}

This fully-generic typing is shorter and does not get confused about consumers that return functions, and lets you pipe anything through anything.
Would you like a PR for this?

Is there any update on this from the maintainers? @kitten (sorry for the spammy tag)


NIFI-5082: Added support for custom Oracle timestamp types to Avro conversion

Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit?

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

I REALLY didn't want to have to do this explicit Oracle stuff in the generic code, but the other options I tried weren't viable. I tried isolating the SQL type conversion to the DatabaseAdapters, but ExecuteSQL uses JdbcCommon and does not use DatabaseAdapters, so the problem would still exist. I also tried calling getTimestamp() in the default handling block (before attempting to store a String) but that is really brittle since other drivers may or may not handle getTimestamp() in a manner we could rely on. This is a simple straightforward (but dirty) fix.

+1 LGTM. Passed the build and it matches my rough understanding of the issues w/ Oracle as well. I'm good to merge this if you don't think it needs further review.


React to consumer rebalance

From @janoskranczler on June 28, 2017 12:14
Hi guys,
Is there any way I can react on a consumer rebalance (Kafka), if autoRebalanceEnabled is set to false? In Kafka client there is ConsumerRebalanceListener, but how can I listen on rebalance in SCS?
(And if I can, what is the simplest way to determine the partition count before and after the rebalance?)
Copied from original issue: spring-cloud/spring-cloud-stream#1004

Hi @janoskranczler ,
For tracking this better, please create Kafka binder related issues here: https://github.com/spring-cloud/spring-cloud-stream-binder-kafka
I will move this now.

@janoskranczler,
Configuring ConsumerRebalanceListener feature has been added in spring-kafka 2.0.0.M1: https://github.com/spring-projects/spring-kafka/commit/e857c248eb88116bfd28ccf05671e5be13741f96 .
I think the Kafka binder can make use of this feature by setting the user provided ConsumerRebalanceListener to KafkaMessageListenerContainer once we update to spring-kafka 2.x.

Thanks, for your answer. Yes, it is a Kafka related question, sorry.

@janoskranczler No problem at all; thank you for the suggestion! If you would like to contribute this feature as a PR (once spring-kafka 2.x is updated), that would be great!

Is there still interest in a PR for this? I'd like to do it but might need some pointers.

@neilg Sure, if the user provided ConsumerRebalanceListener needs to be used, binder changes are required. Feel free to send a PR and we can review it. This is the main class for the Kafka biner implementation: https://github.com/spring-cloud/spring-cloud-stream-binder-kafka/blob/master/spring-cloud-stream-binder-kafka/src/main/java/org/springframework/cloud/stream/binder/kafka/KafkaMessageChannelBinder.java

Apologies if this is answered elsewhere, or if there's a more appropriate place to ask. Are there some IDE settings I can import for code style, etc? I'm using IntelliJ.

This commit introduced the ability for apps to provide custom rebalance listener. Closing the issue.


Validator for invalid turn restrictions

(I haven't found a validator for this - if we already have one in place feel free to close this)
For turn restrictions of the form (fromWayId, viaNodeId, toWayId) the viaNodeId needs to connect the way fromWayId to the way toWayId. Turn restrictions where the via node is not shared across the two ways are invalid.
Our routing engine filters via-node turn restrictions that are invalid and discards them. We should have a validator in place since this type of error should be easy to detect and fixing it is of high value for routing.

Related to that - turn restrictions have a well-defined format:
http://wiki.openstreetmap.org/wiki/Relation:restriction#Members
the relation members have to be:

from - of type way, exactly 1 way, except can be multiple ways only when no_entry restriction!
to - of type way, exactly 1 way, except can be multiple ways only when no_exit restriction!
via - either a single node or multiple ways

We should have a validator in place for checking all turn restrictions making sure they conform to this schema.
cc @srividyacb @Rub21

This is a must validator to have. Based on my knowledge - we use OSM-QA tiles and tile-reduce for most of the linters scripts to detect tagging and connectivity errors. But I don't think OSM-QA tiles have turn-restriction in it.
@Rub21 how can we build this validator?
cc @daniel-j-h

@ramyaragupathy have we ever made a global tileset of turn restrictions?

Nope, but this can be done with osmlazer @planemad

Flagging: there is also an edge case with no_entry and no_exit which we stumbled upon lately
https://github.com/Project-OSRM/osrm-backend/issues/4241
and our routing engine does not handle it yet. It's on our feature list to implement.
What's interesting in the context of validators is @mokob sampled the OpenStreetMap data for no_entry and no_exit and found quite a few issues with how they're getting used and simple mis-uses. At the moment there are only a couple hundreds no_entrys and no_exits in the dataset - it could make sense to check them, too.

@daniel-j-h , I thought this could be possible using the Multipolygon mbtiles that have been in the test(this contain some relations)  but not, it does not contain the TR relations.
@ramyaragupathy could we get TR data from osmlazer as geojson?
@daniel-j-h , Maybe do you know other ways to get these TR data as geojson?
if it so, we could use the geojson to combine with the osm-qa-tiles to do the analysis and detect those invalid TR.

could we get TR data from osmlazer as geojson?
Nope, only the count works @Rub21

Worked w/ @planemad to expand on earlier work of grouping relations. Script here regroups relations by their ID & append member geometries to each relation in a GeometryCollection.
We ran it against TRs in SF & got the geojson formatted to represent relations as Geometry Collection. Contents are shared in dropbox.

the input file  SFTR_Input.geojson
output file SFTR_reorganised.geojson & output.mbtiles

Interactive map
More on the data structure
Sample file of a TR as GeometryCollection.
All relation related properties at feature level:
"properties": {
    "type": "restriction",
    "restriction:type": "no_left_turn",
    "restriction:id": 6191617,
    "members": [
      {
        "label": "from"
      },
      {
        "label": "via"
      },
      {
        "label": "to"
      }
    ]
  }

members array within properties store info on each role that constitutes a TR.
Order within the member array matches the geometry order within geometries array of a feature.
cc @Rub21 @daniel-j-h @srividyacb @maning

@ramyaragupathy  This is nice!! the mbtiles works fine!! , I am doing some analysis to detect invalid TR,  but I could not find to any of this in SF, could you create a  mbtiles for US?

@ramyaragupathy nice work! the output.mbtiles you posted above doesn't seem to have any GeometryCollections. Is that right?
@Rub21 @ramyaragupathy @planemad - just want to flag that Tile Reduce does not support GeometryCollections, unfortunately, which means OSMLint may not work. We have tried this before.

Looks like tippecanoe just treats each geometry within the GeometryCollection as a separate feature, instead of treating all the geometries as an unit @geohacker @planemad @Rub21
Thinking of osmium here. For relations, though it does not return the geometry data, it contains details that can be used to generate geometries:
{ restriction: 'only_right_turn', type: 'restriction' }
[ { type: 'w', ref: 478760157, role: 'from' },
  { type: 'n', ref: 176581223, role: 'via' },
  { type: 'w', ref: 61840757, role: 'to' } ]

From the id's, geometries can be obtained and then linters could be run in the same script for validation.

yeah the workflow will be different from the existing ones @geohacker

Because  mbtiles does not support relation, we created another report to detect  invalid relations  https://github.com/osmlab/osmlint-osmium/tree/master/validators
Close this ticket here!!


Pascal highlighting

(Original issue 295 created by None on 2007-09-25T23:04:58+00:00)
Reported by guest

(Original issue was assigned to gbrandl)
(Original issue 295 last updated on 2007-10-14T16:22:03+00:00)
(Issue automaticaly closed due to status in Bitbucket: resolved)

(Original comment by gbrandl on 2007-10-14T16:22:03+00:00)
Sorry, I can't see what this issue is about.


HIVE-26738: Use spotless-maven-plugin to check and constrain unused imports

What changes were proposed in this pull request?

Introducing spotless-maven-plugin to check unused import in the project build phase.
Why are the changes needed?

There are many unused imports in the current project, and maven-checkstyle-plugin does not play a constraint role.
Introducing spotless-maven-plugin to check unused import in the project build phase.
Does this PR introduce any user-facing change?

No
How was this patch tested?

No

@ayushtkn Can you help review this PR? thx

@ayushtkn Have you had a chance to look over the PR I sent you? THX！

this makes sense to me, would need a rebase though. I think either we should add this unused import check in the build phase as well, else these will pop up again


Please add new requirement of scipy<1.13.0 to this package

Due to removal of scipy.linalg.triu from scipy in version 1.12.0 please add this
restriction of scipy version to requirements.txt and setup.py
scipy<1.13.0
node2vec uses the above library and that maintainer is no longer making fixes. This change breaks for versions of python 3.9 and above

done and tested


RN2903 + Arduino Nano Hangs when TXing Unconfirmed Mssg

I am using an Arduino Nano + RN2903, wired up as in this guide: https://www.thethingsnetwork.org/forum/t/how-to-build-your-first-ttn-node-arduino-rn2483/1574/69. Only difference is I am using a level shifter to connect TX, RX and reset, between Arduino and RN2903.
The radio seems to initialize OK, I get the following information:
Startup
When using OTAA, register this DevEUI:
<The EUI is printed here>
RN2xx3 firmware version:
RN2903 1.0.5 Nov 06 2018 10:45:27
Trying to join TTN
Successfully joined TTN
TXing

As you can see, the code stops after TXing, and the LED_BUILTIN remains high, although data is in fact transmitted to my Chirpstack LoRa Server. However, this only works once, and then the Arduino hangs. I am using a very slightly modified version of ArduinoUnoNano_basic.ino. And I am using ABP.
So, why would the module hang after TXing? Is there any other setting I must configure? It seems the code never escapes the myLora.tx("!") function, because the led_off() is never called.
Any help would be greatly appreciated!

Given you are using a modified version of the example code, I guess it is best to also include the code here, or place a link.
Make sure you don't include any 'secrets' in that code when posting it.

A thing you need to make sure of is that the RN2903 is the correct one for your region: https://www.microchip.com/wwwproducts/en/RN2903
US902-928: RN2903A-I/RM
AU915-928: RN2903A-I/RMSA

And then make sure your gateway is also using the same frequency plan.

@jpmeijers Inscription in my RN2903 only says RN2903 and below that 15454PQ. I purchased this module: https://www.digikey.com/es/products/detail/microchip-technology/RN-2903-PICTAIL/5975742. I don't exactly know how to determine what version it is. My GW is definitely operating in US902. And since I am able to receive uplinks (at least once, before the code hangs) in for example the 904.1 MHz channel, I assume it should be the RN2903A-I/RM module? SNR looks fine on these uplinks: > +10 SNR. If it were transmitting on an AU915 channel and the GW managed to decode it I'd expect very low SNR.

@TD-er I am not using TTN, rather I am using Chirpstack. As I mentioned, I am able to transmit 1 uplink, but then the node hangs in TXing and never turns off the LED (i.e. gets stuck in the loop). Here is my code, basically I just added a change in Frequency Plan (the code still gets stuck in TXing without this change), changed the baud rate for debug to 9600, commented out the startup message and set my keys for ABP.
/*
 * Author: JP Meijers
 * Date: 2016-02-07
 * Previous filename: TTN-Mapper-TTNEnschede-V1
 *
 * This program is meant to be used with an Arduino UNO or NANO, conencted to an RNxx3 radio module.
 * It will most likely also work on other compatible Arduino or Arduino compatible boards, like The Things Uno, but might need some slight modifications.
 *
 * Transmit a one byte packet via TTN. This happens as fast as possible, while still keeping to
 * the 1% duty cycle rules enforced by the RN2483's built in LoRaWAN stack. Even though this is
 * allowed by the radio regulations of the 868MHz band, the fair use policy of TTN may prohibit this.
 *
 * CHECK THE RULES BEFORE USING THIS PROGRAM!
 *
 * CHANGE ADDRESS!
 * Change the device address, network (session) key, and app (session) key to the values
 * that are registered via the TTN dashboard.
 * The appropriate line is "myLora.initABP(XXX);" or "myLora.initOTAA(XXX);"
 * When using ABP, it is advised to enable "relax frame count".
 *
 * Connect the RN2xx3 as follows:
 * RN2xx3 -- Arduino
 * Uart TX -- 10
 * Uart RX -- 11
 * Reset -- 12
 * Vcc -- 3.3V
 * Gnd -- Gnd
 *
 * If you use an Arduino with a free hardware serial port, you can replace
 * the line "rn2xx3 myLora(mySerial);"
 * with     "rn2xx3 myLora(SerialX);"
 * where the parameter is the serial port the RN2xx3 is connected to.
 * Remember that the serial port should be initialised before calling initTTN().
 * For best performance the serial port should be set to 57600 baud, which is impossible with a software serial port.
 * If you use 57600 baud, you can remove the line "myLora.autobaud();".
 *
 */
#include <rn2xx3.h>
#include <SoftwareSerial.h>

SoftwareSerial mySerial(10, 11); // RX, TX
uint8_t to_send[1];

//create an instance of the rn2xx3 library,
//giving the software serial as port to use
rn2xx3 myLora(mySerial);

// the setup routine runs once when you press reset:
void setup()
{
  //output LED pin
  pinMode(13, OUTPUT);
  led_on();

  // Open serial communications and wait for port to open:
  Serial.begin(9600); //serial port to computer
  mySerial.begin(9600); //serial port to radio
  Serial.println("Startup");

  initialize_radio();

  //transmit a startup message
  //myLora.tx("TTN Mapper on TTN Enschede node");

  led_off();
  delay(2000);
}

void initialize_radio()
{
  //reset rn2483
  pinMode(12, OUTPUT);
  digitalWrite(12, LOW);
  delay(500);
  digitalWrite(12, HIGH);

  delay(100); //wait for the RN2xx3's startup message
  mySerial.flush();

  //Autobaud the rn2483 module to 9600. The default would otherwise be 57600.
  myLora.autobaud();

  //check communication with radio
  String hweui = myLora.hweui();
  while(hweui.length() != 16)
  {
    Serial.println("Communication with RN2xx3 unsuccessful. Power cycle the board.");
    Serial.println(hweui);
    delay(10000);
    hweui = myLora.hweui();
  }

  //print out the HWEUI so that we can register it via ttnctl
  Serial.println("When using OTAA, register this DevEUI: ");
  Serial.println(myLora.hweui());
  Serial.println("RN2xx3 firmware version:");
  Serial.println(myLora.sysver());

  // setting fp
  //bool fp = myLora.setFrequencyPlan(TTN_US);
  //Serial.println("FP Set: ");Serial.println(fp);

  //configure your keys and join the network
  Serial.println("Trying to join TTN");
  bool join_result = false;

  /*
   * ABP: initABP(String addr, String AppSKey, String NwkSKey);
   * Paste the example code from the TTN console here:
   */
  const char *devAddr = "goes here";
  const char *nwkSKey = "goes here";
  const char *appSKey = "goes here";

  join_result = myLora.initABP(devAddr, appSKey, nwkSKey);

  /*
   * OTAA: initOTAA(String AppEUI, String AppKey);
   * If you are using OTAA, paste the example code from the TTN console here:
   */
  //const char *appEui = "70B3D57ED00001A6";
  //const char *appKey = "A23C96EE13804963F8C2BD6285448198";

  //join_result = myLora.initOTAA(appEui, appKey);

  while(!join_result)
  {
    Serial.println("Unable to join. Are your keys correct, and do you have TTN coverage?");
    delay(60000); //delay a minute before retry
    join_result = myLora.init();
  }
  Serial.println("Successfully joined TTN");

  // setting fp
  bool fp = myLora.setFrequencyPlan(TTN_US);
  Serial.println("FP Set: ");Serial.println(fp);
}

// the loop routine runs over and over again forever:
void loop()
{
    led_on();

    Serial.println("TXing");
    myLora.tx("!"); //one byte, blocking function
    //to_send[0] = 0x08;
    //myLora.txBytes(to_send, sizeof(to_send));

    led_off();
    delay(200);
}

void led_on()
{
  digitalWrite(13, 1);
}

void led_off()
{
  digitalWrite(13, 0);
}

At this point we need to figure out why the tx function never returns. Look at https://github.com/jpmeijers/RN2483-Arduino-Library/blob/401b7fca5530a87d72e1ed61d4c042e4b48fcdd9/src/rn2xx3.cpp#L387 and add a Serial.println(receviedData) there. The radio is likely responding with an error which is not correctly handled, and the while loop tries over and over forever.

@jpmeijers Could the module refuse to continue if there is a received message which has not been read/fetched?

Unlikely, because an RX message should be caught and read by this: https://github.com/jpmeijers/RN2483-Arduino-Library/blob/401b7fca5530a87d72e1ed61d4c042e4b48fcdd9/src/rn2xx3.cpp#L408

Hello, thank you both @jpmeijers and @TD-er for your continued support. I just added the following line right after the String receivedData = _serial.readStringUntil('\n'); line:
String receivedData = _serial.readStringUntil('\n');
Serial.print("Rcvd data type: ");
Serial.println(determineReceivedDataType(receivedData));

However, nothing gets printed after TXing, not even the "Rcvd data type:" string. So I believe the readStringUntil('\n') is not returning (not finding the termination character). Any further ideas of what we might try to figure this out?
If it helps, the downlink my Chirpstack server is sending right after the uplink is the following:

@jpmeijers
OK, so maybe this helps, I changed the code to the following:
//String receivedData = _serial.readStringUntil('\n');
String receivedData = "foo";
while(true)
{
  Serial.println(_serial.read());
}

And I get this output:
Startup
When using OTAA, register this DevEUI:
<EUI goes here>
RN2xx3 firmware version:
RN2903 1.0.5 Nov 06 2018 10:45:27
Trying to join TTN
Successfully joined TTN
FP Set:
1
TXing
-1
-1
-1
-1
-1
-1
-1

The -1 keep going on for a while and then stop.  If I set the debugging Serial to 57600 baud I get more -1 printed than when its at 9600 baud. So something with the Serial ports is in conflict/taking up resources as well? I am using SoftwareSerial at pins D10 and D11 for RX and TX with the RN2903.
Note that the section of the print saying FP Set: 1 is where I set the frequency plan to TTN_US via the setFrequencyPlan method.

Testing at different baud rates is a good idea to check if its behavior remains constant.
I sometimes have seen that the communication to the RN2xx3 is not 100% correct when using SW serial.
So just to make sure we're not looking at handling a bad command.
Getting more -1 values at higher baud rate makes sense if it is a fault state existing for a fixed amount of time.

OK, so I seem to have found the issue, but not the solution... I swapped out my Arduino Nano clone (this one) for an Arduino UNO. Ran the code again and it worked like a charm: continous transmission with no hanging on TXing. So, it seems to be a problem with the Arduino Nano I have. Swapped it for another Nano clone and same problem, so not an issue with that specific unit. I went and also updated the bootloader (because it was using the old bootloader for the ATMEGA328P), and that did not change much, although I did get the Arduino to print this:
Startup
When using OTAA, register this DevEUI:
<EUI goes here>
RN2xx3 firmware version:
RN2903 1.0.5 Nov 06 2018 10:45:27
Trying to join TTN
ABP Rcvd data: accepted
Successfully joined TTN
FP Set:
1
TXing
Rcvd data type: 14
Rcvd data: ⸮#=cs⸮
Rcvd data type: 14
Rcvd data:
Rcvd data type: 14
Rcvd data:
Rcvd data type: 14
Rcvd data:
Rcvd data type: 14
Rcvd data:
Rcvd data type: 14
Rcvd data:
Rcvd data type: 14
Rcvd data:
Rcvd data type: 14
Rcvd data:
Rcvd data type: 14
Rcvd data:
Rcvd data type: 14
Rcvd data:
TXing
Rcvd data type: 14
Rcvd data:

So it was receiving an UNKNOWN response from the RN2903. In general I have seen that it seems to be an issue with the SoftwareSerial library somehow becoming unresponsive. Also tried the AltSoftSerial library and same issues.
Any ideas guys? I'd like to get this working on my Nanos instead of the UNO, because of the size of the boards.

I don't know the Arduino Nano boards well, but doesn't that board have a HW serial port? (the one you look at for your logs)
So what you could try to do, is swap the serial ports for theRN2903 and the log (thus you probably need some USB to serial adapter for it).
Just to try if that makes a difference.
I think the SWserial is not that consistent with the pulse widths (thus timing).
Also on the ESP8266, SWserial isn't that stable and I have seen some issues with the RN2483 also, where I got either some bogus reply or the node acting strange.
So perhaps those RN modules are very strict on the serial timings.
If you do have a scope, you could also try to see if the levels of the digital signal are OK. Maybe the signal is not received well? (rounded edges, not a square wave pattern)
On some boards (I mainly have experience with ESP8266) and in some datasheets I have seen a 500 Ohm (or 470) resistor being used in series with the TX line to prevent "ringing".

Hi @TD-er
I actually went and swapped the serial ports as you suggested. Used AltSoftSerial at 9600 baud for debugging and HW serial at 57600 baud for comms with the RN2903. It made a difference, but behaviour was not nominal... The Nano no longer got stuck on TXing, but the RN2903 transmitted 10 times while TXing was only printed out to the console 6 times. Also, the frame counter did not increase, rather every uplink was sent with FCnt = 0. So, something very odd is happening. I think that for the time being I will use the Arduino UNO R3 which functions correctly.
I think the problem must lie in the main difference between my Arduino UNO and Nano: namely, that the Arduino UNO uses an ATmega16U2 to act as a serial-to-USB bridge, while the Nano uses the CH340G. So maybe this is messing with the serial comms? Very odd. I will try to use a Nano with maybe an FTDI chip or PL2303TA and see if there's any difference. Will post here if so.

As an update, I've moved on from this by using an Arduino Pro Mini with an external FTDI adapter. In that setup, this does not occur, so I don't know what might have caused the issues with my specific (chinese) version of the Nano. Gonna go ahead and close this as I feel this might have been specific to the type of Nano I was using and not a problem with the library. Great library btw!


The text file is too big when use Textual.from_path()

I used read pdf function on 2.3 MB "thousand n one nights" http://islamicblessings.com/upload/A-Thousand-And-One-Nights-1.pdf

Actually, since Conver_PDF returns the text from PDF, you just need to do:
textual = Textual(convert_PDF("/content/..../xxx.pdf"))


Suggestion: Avoid ErrorType

I agree that the ErrorType trait is somewhat useful, motivation here, but I think that it may actually in most cases be detrimental to the API?
In each of the cases where it is currently used, I think there is a better pattern to use instead, that will be simpler for users to understand, easier for implementers to use, and more flexible and correct.
Let's consider the modules one at a time:

embedded_hal::digital: ErrorType should be renamed Pin since that is what it logically represents (it is a supertrait of InputPin and OutputPin).

embedded_hal::i2c: ErrorType should be removed, and the associated Error type should be moved to I2c.
The downside is that now the error type is no longer shared between the blocking and the async version, though I believe this tradeoff is worth it, since it is very rare that you'd be working with both traits at the same time.

embedded_hal::pwm: ErrorType should be removed, and the associated Error should be moved to SetDutyCycle (unless you have other plans for extensions to this module, then it may make sense to rename the trait to Pwm or similar instead?)

embedded_hal::spi: Unsure about this, pending discussion in https://github.com/rust-embedded/embedded-hal/issues/525.

embedded-io: More unsure here, but I suspect the ErrorType design is also the wrong design here: an implementation of Read should be allowed to have a different error type from Write, even though it may be a bit more hazzle to work with types that are Read + Write (users would have to write <T: Read<Error = E> + Write<Error = E>, E> if they wanted to force the same error type).

ErrorType is separate even in modules with only 1 trait (like i2c, pwm) to acommodate for future extensions. For example PWM might get a SetFrequency trait in the future. For I2C it's harder to imagine what an extension could be, but it's still nice to leave the door open.

Naming it ErrorType always is good for consistency. I wouldn't rename it to e.g. Pin in the GPIO case. Also the Pin name might make sense today but it's not guaranteed to make sense with future extensions, while ErrorType for sure will.

more hazzle to work with types that are Read + Write (users would have to write <T: Read<Error = E> + Write<Error = E>, E> if they wanted to force the same error type).

this is exactly why the error type is shared. Using Read+Write is very common, the workaround of adding an extra E generic param is very annoying especially because the compiler can't infer it in all cases.


Response objects

Hi!
Regarding Issue #39 this PR adds:

Adds preconfigured CreatedResponse and it's test.

Let  me know if something must to be changed.
Thanks!

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 82.496%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
1395

Relevant Lines:
1691

💛  - Coveralls


[BEAM-4816] Rename JdbcJarTest to avoid run it in unit tests

Since classes whose name contains Test will be considered as unit tests, and JdbcJarTest can only run by :preCommit, rename JdbcJarTest to JdbcJarPreCommitCheck to avoid unit tests failures.

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---
---

Close this PR as it will remove JdbcJarTest in unit tests.


startingDayWeek not working

When im using the startingDayWeek to set monday to be the first day of the week (starting-day-week="1") it breaks the code. When swiping the week view it changes month at the same time, and it sets starting day to be wednesday when using the value 1.
Is this an issue or have i just misunderstood something about the option?

@GeekMediaDK It's a bug. I have fixed in version 0.2.4. Thanks!

You'r welcome @twinssbc
Hope you also can you my suggestion for the higlightclass function

@GeekMediaDK I have merged your PR and released in version 0.2.5. Thanks!

I just installed version 0.3.3 and startingDayWeek not work...

@twinssbc  can you check or hint ?

@veljkocasa startingDayWeek option is used like below. Could you have a try?
starting-day-week="1"

tnx @twinssbc  on quick response!
I was using it like you say, but when I added  starting-day-month="1" it started to work perfectly...
So I guess it have to be paired...
solution looks like
starting-day-week="1"  starting-day-month="1"
tnx again


Set node.style.cssText failed when value start with a semicolon (using Zepto way)

It can't be work when I add style string to node.style.cssText which start with a semicolon:
var jsdom = require("jsdom")

jsdom.env({
  html:'
balabala
',
  done:function (err, window) {
    var el = window.document.getElementById('el');
    el.style.cssText = ";display:none;";
    console.log(window.document.body.innerHTML);

  }
})

It will output:

balabala

But it can be used for most web browsers.
In fact, I found this issue when I was use Zepto, which implementation of  el.css() like this :
return this.each(function() {
    this.style.cssText += ';' + css
})

Should we support this? Maybe it's usefully.

Yes, this seems against the spec so we should support this. This has to be implemented in one of the css modules we use though.

+1


Can't upload an ApiView file more than 50MB.

When I upload an ApiView file to create a review, and the file is >50 MB, I get HTTP 413 "Request entity too large".
Maybe it has something to do with some server settings, where the app is deployed on.

Maybe this will help: https://techcommunity.microsoft.com/t5/iis-support-blog/solution-for-request-entity-too-large-error/ba-p/501134

Changes in the parsers have reduced file size such that this should be a rare problem, so reduced priority to low.

We no longer need to upload C++ ast file. Marking this issue as closed.


Youtube video ID

Does not detect youtube video ID. Version: 0.4.0

Fixed in v0.4.1
To see it run what-rs -r 0:1 dQw4w9WgXcQ
You need to add -r 0:1 to allow a more "lenient" filter.
By default, it filters everything with a rarity below 0.1 to avoid too many false positives.


sqlite3.OperationalError: no such column: qm_conformers.qcarchive_id

I am getting this error when I try to run the benchmarking code. The code appears to create and optimize the MoleculeStore, but when it calls get_dde this error arises. I tried reading the sqlite file into a new script and I see the MM records present with both conformers and energies. I was able to access the MM conformers with store.get_mm_conformers_by_molecule_id and I was able to access the energies by accessing the records with store.get_mm_energies_by_molecule_id and then taking the energy property, however I got the error again when calling store.get_mm_energies_by_molecule_id directly.
When I tried to call get_dde on the store, it did not recognize the MM records as being present and tried to re-optimize them all.
I got the error when running benchmarks on the big industry dataset, but I was able to create a small test example that is much faster to run.
This is the code i’m using: https://github.com/openforcefield/sage-2.2.0/blob/main/05_benchmark_forcefield/benchmark.py
Conda env: https://github.com/openforcefield/sage-2.2.0/blob/main/05_benchmark_forcefield/ib-env-full.yaml
(Note, I also tried it with your environment in this repo, as well as with the last two versions of SQLalchemy, and had the same issue)
The small test is here: https://github.com/openforcefield/sage-2.2.0/tree/main/05_benchmark_forcefield/test
With this dataset: https://github.com/openforcefield/sage-2.2.0/blob/main/05_benchmark_forcefield/datasets/OpenFF-Aniline-Para-Opt-v1.0.json
  File "/data/homezvol3/amcisaac/miniconda3/envs/ib-env/lib/python3.10/site-packages/sqlalchemy/engine/base.py", line 1969, in _exec_single_context
    self.dialect.do_execute(
  File "/data/homezvol3/amcisaac/miniconda3/envs/ib-env/lib/python3.10/site-packages/sqlalchemy/engine/default.py", line 922, in do_execute
    cursor.execute(statement, parameters)
sqlite3.OperationalError: no such column: qm_conformers.qcarchive_id

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/dfs6/pub/amcisaac/sage-2.2.0/05_benchmark_forcefield/benchmark.py", line 58, in <module>
    main()
  File "/data/homezvol3/amcisaac/miniconda3/envs/ib-env/lib/python3.10/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/data/homezvol3/amcisaac/miniconda3/envs/ib-env/lib/python3.10/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/data/homezvol3/amcisaac/miniconda3/envs/ib-env/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/data/homezvol3/amcisaac/miniconda3/envs/ib-env/lib/python3.10/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/dfs6/pub/amcisaac/sage-2.2.0/05_benchmark_forcefield/benchmark.py", line 50, in main
    store.get_dde(forcefield).to_csv(f"{out_dir}/dde.csv")
  File "/dfs6/pub/amcisaac/ib/ibstore/_store.py", line 492, in get_dde
    mm_energies = self.get_mm_energies_by_molecule_id(molecule_id, force_field)
  File "/dfs6/pub/amcisaac/ib/ibstore/_store.py", line 324, in get_mm_energies_by_molecule_id
    .all()
  File "/data/homezvol3/amcisaac/miniconda3/envs/ib-env/lib/python3.10/site-packages/sqlalchemy/orm/query.py", line 2693, in all
    return self._iter().all()  # type: ignore
  File "/data/homezvol3/amcisaac/miniconda3/envs/ib-env/lib/python3.10/site-packages/sqlalchemy/orm/query.py", line 2847, in _iter
    result: Union[ScalarResult[_T], Result[_T]] = self.session.execute(
  File "/data/homezvol3/amcisaac/miniconda3/envs/ib-env/lib/python3.10/site-packages/sqlalchemy/orm/session.py", line 2308, in execute
    return self._execute_internal(
  File "/data/homezvol3/amcisaac/miniconda3/envs/ib-env/lib/python3.10/site-packages/sqlalchemy/orm/session.py", line 2190, in _execute_internal
    result: Result[Any] = compile_state_cls.orm_execute_statement(
  File "/data/homezvol3/amcisaac/miniconda3/envs/ib-env/lib/python3.10/site-packages/sqlalchemy/orm/context.py", line 293, in orm_execute_statement
    result = conn.execute(
  File "/data/homezvol3/amcisaac/miniconda3/envs/ib-env/lib/python3.10/site-packages/sqlalchemy/engine/base.py", line 1416, in execute
    return meth(
  File "/data/homezvol3/amcisaac/miniconda3/envs/ib-env/lib/python3.10/site-packages/sqlalchemy/sql/elements.py", line 517, in _execute_on_connection
    return connection._execute_clauseelement(
  File "/data/homezvol3/amcisaac/miniconda3/envs/ib-env/lib/python3.10/site-packages/sqlalchemy/engine/base.py", line 1639, in _execute_clauseelement
    ret = self._execute_context(
  File "/data/homezvol3/amcisaac/miniconda3/envs/ib-env/lib/python3.10/site-packages/sqlalchemy/engine/base.py", line 1848, in _execute_context
    return self._exec_single_context(
  File "/data/homezvol3/amcisaac/miniconda3/envs/ib-env/lib/python3.10/site-packages/sqlalchemy/engine/base.py", line 1988, in _exec_single_context
    self._handle_dbapi_exception(
  File "/data/homezvol3/amcisaac/miniconda3/envs/ib-env/lib/python3.10/site-packages/sqlalchemy/engine/base.py", line 2344, in _handle_dbapi_exception
    raise sqlalchemy_exception.with_traceback(exc_info[2]) from e
  File "/data/homezvol3/amcisaac/miniconda3/envs/ib-env/lib/python3.10/site-packages/sqlalchemy/engine/base.py", line 1969, in _exec_single_context
    self.dialect.do_execute(
  File "/data/homezvol3/amcisaac/miniconda3/envs/ib-env/lib/python3.10/site-packages/sqlalchemy/engine/default.py", line 922, in do_execute
    cursor.execute(statement, parameters)
sqlalchemy.exc.OperationalError: (sqlite3.OperationalError) no such column: qm_conformers.qcarchive_id
[SQL: SELECT mm_conformers.energy AS mm_conformers_energy
FROM mm_conformers
WHERE mm_conformers.parent_id = ? AND mm_conformers.force_field = ? ORDER BY qm_conformers.qcarchive_id]
[parameters: (7, 'openff_unconstrained-2.2.0-rc1.offxml')]
(Background on this error at: https://sqlalche.me/e/20/e3q8)```

I was very confused until I came across this:
https://github.com/mattwthompson/ib/blob/de80859f37b345845f9a7ba5240a4279e5913458/ibstore/_store.py#L318-L326
Notice that it's querying _M_M conformers but trying to order by the QCArchive IDs of the _Q_M conformer records.
I'm still confused - shouldn't this have failed in one of the tests? - but this might be a fix.

I tagged 0.0.3 which I believe resolved this - let me know if that's not the case
https://github.com/mattwthompson/ib/releases/tag/0.0.3


Possible memory-leak

We are running 2 flask apps serving APIs for two separate projects.
Last two days we started getting alerts from monitoring systems on high memory usage on nodes running these apps.
We spent some time reviewing shared components and recent changes for potential cause until the only one left was elastic-apm module. API for one of the apps is normally running on 3 nodes and the traffic is load balanced via Amazon's Application Load Balancer, so every node receives a fair share. We disabled APM via the config on one of nodes and restarted gunicorns on all three. After 48 hours running we see the following:

app-01 node without elastic-apm: 3.4% to 5.4% node memory usage (across multiple gunicorn processes)
app-02 node with elastic-apm: 12.9% ... 16.6% memory usage
app-03 node with elastic-apm: 11.6% ... 18.9% memory usage

In absolute numbers, it is ~200Mb on app-01 vs 600-700Mb on 02 and 03.
All 3 nodes are brought up with orchestration tools, so identical in hardware and software and serve identical workload.
Due to the nature of the API, on weekends we do have quite low usage, which probably explains why after 48 hours we don't yet have alerts firing.
Versions installed:
Description:	Ubuntu 16.04.3 LTS

Flask==0.10.1
elastic-apm==2.1.1
gunicorn==19.4.1

Initialization:
    app = Flask(__name__, ...)
    ...
    # elastic apm
    app.apm = None
    if app.config.get('elastic', {}).get('service_name'):
        from elasticapm.contrib.flask import ElasticAPM
        app.apm = ElasticAPM(app, **app.config['elastic'])

Config:
[elastic]
service_name = "Production Application API"
server_url = "{{ .Data.server_url }}"
secret_token = "{{ .Data.secret_token }}"
environment = "production"

Please suggest how we can help investigating this issue. Thanks!

Thanks for the report @alexanderad, and sorry for the long answer time, I was under the weather for a few days 🤒
Some overhead is to be expected when using Elastic APM, but I agree that ~400MByte seems excessive.
One possible source for this could be internal caches that we use. The one with the largest impact is our source line cache, which is used when generating stack traces for errors and spans. Instead of reading the source file every time (which would cause a lot of I/O and be quite slow), we cache the result of the read:
https://github.com/elastic/apm-agent-python/blob/c8ae9e451ce216aac04cac477fd62d35f8ea98ef/elasticapm/utils/stacks.py#L30-L31
Could you try to disable capturing of stack traces for spans on one of your app servers and see if that helps? You can do that by setting span_frames_min_duration to 0.

@alexanderad good to hear that you found a workaround. I'm closing this for now, as I wasn't able to reproduce a memory leak.


Refactor cheatable starknet frontend

cheatcode_hint_processor.rs is starting to get way too big.

blocked by #327


Could not resolve host: influxdb

Hi,
I am trying to run docker-speedtest ni RPi3  and I have problem with accessing influxdb:8086 from speedtest container
here is log from docker
speedtest    | Speedtest exited with 0 speedtest     | Download: 49.34 speedtest     | Upload: 51.45 speedtest     | Packet Loss: 0.0 speedtest     | Latency: 8.12 speedtest     | Timestamp:<PHONE_NUMBER>36 speedtest     | Download (49.34 Mbit/s) send returned with 204 speedtest     | curl: (6) Could not resolve host: influxdb speedtest     | Upload (51.45 Mbit/s) send returned with 000 speedtest     | curl: (6) Could not resolve host: influxdb speedtest     | Packet Loss (0.0 %) send returned with 000 speedtest     | Latency (8.12 ms) send returned with 204 speedtest     | curl: (6) Could not resolve host: influxdb speedtest     | Jitter (16.71 ms) send returned with 000 speedtest     | Sleep 900 before next run. -6491260 s remaining speedtest     | sleep: invalid number '-6491260'

Hi, can you please provide more details? Did you use the docker-compose file from this repository? Can you please provide an output of docker ps?

HI @sthuber90 .
yes I used docker-compose file and after docker-compose up -d --build I have problem with speedtest container.
Container speedtest  can not resolve http://influxdb:8086
log.txt

The linking of the influxdb container to the speedtest container is done through Docker built in functionality. To help you I need to know exactly what you did and I need you terminal output for docker ps

I clone project and run docker build with next commands
 git clone https://github.com/sthuber90/docker-speedtest.git  cd docker-speedtest/  docker-compose  build --no-cache

Thank you for the details. Have you tried pinging inlfuxdb i.e. ping influxdb? If this does not, please also check

ping google.com
ping <IP_ADDRESS>

Let me know the output of the above commands, please.

pi@raspberrypi:~/dockers/docker-speedtest $ docker-compose ps
   Name                 Command                   State                Ports
-------------------------------------------------------------------------------------
chronograf   /entrypoint.sh chronograf        Up               <IP_ADDRESS>:8888->8888/tcp
influxdb     /entrypoint.sh influxd           Up               <IP_ADDRESS>:8086->8086/tcp
speedtest    /bin/sh -c ./init_test_con ...   Up (unhealthy)
pi@raspberrypi:~/dockers/docker-speedtest $
pi@raspberrypi:~/dockers/docker-speedtest $
pi@raspberrypi:~/dockers/docker-speedtest $ docker-compose exec speedtest sh
/opt/speedtest # ping google.com
ping: bad address 'google.com'
/opt/speedtest # ping <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>): 56 data bytes
ping: clock_gettime(MONOTONIC) failed
/opt/speedtest #

Hi @sthuber90 ,
I founded where is problem.
There is problem with alpine:3.13 (version 3.13) I switched to 3.12 and everything works.

Okay, glad you found it. Are you referring to the problem around https://wiki.alpinelinux.org/wiki/Release_Notes_for_Alpine_3.13.0#time64_requirements ? If so, you can still use alpine 3.13 but need to update your libseccomp version.
I'll go ahead and close the issue.

Hmh just saw this closed issue. Bad the same Problem and came to the same solution during a late night session... Why not fix it in the repo so people won't run into the same issue again and again? The fix is those additional 4 letters ":3.12" in your Dockerfile. I can make a fork and pull request for it but seems like overkill.
Will you fixe it?


Failing scenario - ms2_simple_monitoring - 01.08.2019

DevOpsBot 06:04
Starting run for scenarios ‘ms2_simple_monitoring’..
DevOpsBot 06:04
☠ Scenario incomplete. No result found in log file.
Log can be downloaded from:
http://scenario-player.ci.raiden.network/Scenario_player_Logs-ms2_simple_monitoring-1-latest-2019-08-01.tar.gz

Same problem as seen yesterday: https://github.com/raiden-network/scenario-player/issues/146
I have a difficult time figuring out if this happens every time mint_token_if_balance_low is used or only sometimes. Will invest further.

Opened a bug report for this in the SP instead: https://github.com/raiden-network/scenario-player/issues/175


6.2.4 “While” and “until” commands

shell_command =
rule_if
| rule_while
| rule_until
;
rule_while = 'while' compound_list 'do' compound_list 'done' ;
rule_until = 'until' compound_list 'do' compound_list 'done' ;

Je m'en occupe

Done emoji lunette de soleil de bg


[sw] Update outdated README.md

As the result of the build directories change in 6379357, the current
instructions in README.md are no longer correct.
Signed-off-by: Silvestrs Timofejevs<EMAIL_ADDRESS>

Thanks! And thanks @mcy for the review!


Fix using yo behind a proxy on Node versions >= 11.6.0

Type of issue
Bug
What happens
Running yo fails when using a system Proxy since Node.js 11.6.0.
Background
We are using global-tunnel-ng to make it possible to use yo behind a proxy. This was implemented in https://github.com/yeoman/yo/pull/573.
Sadly global-tunnel-ngis broken since Node.js 11.6.0 and according to one of the contributors it probably won’t support newer Node versions in the future.
How to fix this
Switch from using global-tunnel-ng to global-agent:

Change the global-tunnel initialization at the entry of the yo cli and yo doctor according https://github.com/gajus/global-agent/blob/master/README.md#usage should do the trick
Adding a note in the documentation would help, mainly because global-agent uses the environment variable GLOBAL_AGENT_HTTP_PROXY instead of the traditional HTTP_PROXY. Keep in mind global-agent does not look for a proxy in the npm configuration and may not support all the different kinds of proxy connections.

How to test this
This should be testable using a local proxy like Burp Proxy , Charles or mitmproxy.
Who could help with this
@gajus, the maintainer of 'global-agent' was so kind to offer his help in the Yeoman Chat 💖

Change the global-tunnel initialization at the entry of the yo cli and yo doctor according https://github.com/gajus/global-agent/blob/master/README.md#usage should do the trick

The only thing to consider is that global-agent in its current form support only Node.js v11.6.0+ (officially, v12+). I can implement support for older Node.js versions if it is required?

Oops. I just read that global-agent [only supports Node.js v12 and above].
So it’s probably a bit early to do a simple switch from global-tunnel-ng to global-agent.
@SBoudrias, What do you think to check the Node version and do a conditional require depending on that?

@gajus Yeah. We support Node back to the current Maintenance LTS version.

I can implement support for older Node.js versions if it is required?

Is this possible?

Is this possible?

Yes, it is relatively straightforward change. Just need to patch http.reqest and http.get methods.
Can have this out by mid week.

That would be awesome 💯
Could you ping us in this issue when it’s done?

Node v10 is supported as of v1.5.0.

@gajus yo requires node >=8, but global-agent requires node >= 10. Maybe we need to change engines to node: >=8?
Does global-agent support Node.js 8 in<EMAIL_ADDRESS>

Does global-agent support node >= 8 in 1.5.0?

I checked<EMAIL_ADDRESS>does not support 1.5.0.
@gajus Is that possible add support for Node.js 8?

@LitoMore Have you tested it with Node v8?
I have not tested it, but it should work. As far as I know, there were no features added to HTTP core module that would have changed http agent behaviour between v8 and v10.

@gajus Yes, I tested that<EMAIL_ADDRESS>does not support Node.js 8.
Could you add support for Node.js 8 also?

It is not something that I can take a look at immediately, but I have added it to my TODO list.
https://github.com/gajus/global-agent/issues/7

I have added example of how to conditionally use global-agent or global-tunnel-ng depending on the Node.js version. No plan to support Node.js <10.
https://github.com/gajus/global-agent#setup-proxy-using-bootstrap-routine


ActionController::ParamsWrapper is not on by default

The generated config/initializers/wrap_parameters files says that ActionController::ParamsWrapper is enabled by default, but it is not.
Perhaps it should be enabled by default, because when consuming JSON requests its pretty nice to not require the root object. If that's not going to happen, the generator should be modified so that it states that this module is disabled by default.

Using an rails-api generated (v0.4.0) the generated code in config/initializers/wrap_parameters.rb has the respond_to in there as expected but... it does not work. Had to go with @cimm fix.
If i got the discussion right it shouldn`t be the case. Am i missing something?

+1 with @LucasSubli


Added Azure.VM.MaintenanceConfig

PR Summary
Fixes #2121
Added Azure.VM.MaintenanceConfig rule.
PR Checklist

[x] PR has a meaningful title
[x] Summarized changes
[x] Change is not breaking
[x] This PR is ready to merge and is not Work in Progress
Rule changes

[x] Unit tests created/ updated
[x] Rule documentation created/ updated
[x] Link to a filed issue
[x] Change log has been updated with change under unreleased section

Other code changes

[ ] Unit tests created/ updated
[ ] Link to a filed issue
[ ] Change log has been updated with change under unreleased section

@BernieWhite Ready for review. No pre-condition for operating systems here either.


Build error when TLS 1.3 is enabled with MBEDTLS_SSL_KEEP_PEER_CERTIFICATE disabled

Summary
When MBEDTLS_SSL_PROTO_TLS1_3 (and MBEDTLS_SSL_TLS1_3_COMPATIBILITY_MODE) are defined and MBEDTLS_SSL_KEEP_PEER_CERTIFICATE is disabled, the following build error is observed:
../mbedtls/library/ssl_tls13_generic.c: In function ‘ssl_tls13_parse_certificate_verify’:
../mbedtls/library/ssl_tls13_generic.c:370:52: error: ‘mbedtls_ssl_session’ {aka ‘struct mbedtls_ssl_session’} has no member named ‘peer_cert’
  370 |     if( !mbedtls_pk_can_do( &ssl->session_negotiate->peer_cert->pk, sig_alg ) )
      |                                                    ^~
../mbedtls/library/ssl_tls13_generic.c:432:63: error: ‘mbedtls_ssl_session’ {aka ‘struct mbedtls_ssl_session’} has no member named ‘peer_cert’
  432 |                                        &ssl->session_negotiate->peer_cert->pk,
      |                                                               ^~
make[2]: *** [library/CMakeFiles/mbedtls.dir/build.make:232: library/CMakeFiles/mbedtls.dir/ssl_tls13_generic.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:876: library/CMakeFiles/mbedtls.dir/all] Error 2
make: *** [Makefile:141: all] Error 2

System information
Mbed TLS version (number or commit id): https://github.com/ARMmbed/mbedtls/commit/17f452aec42ba4675a778263a89b293b3a19cacc
Operating system and version: Linux/Pop!_OS 20.04
Configuration (if not default, please attach mbedtls_config.h): mbedtls_config.zip
Compiler and options (if you used a pre-built binary, please indicate how you obtained it): gcc 9.4.0 / cmake version 3.16.3 (Built with CMake with instructions given here - no additional flags)
Additional environment information: NA
Expected behavior
No build error
Actual behavior
Build error is observed
Steps to reproduce

In mbedtls_config.h, enable MBEDTLS_SSL_PROTO_TLS1_3 (and MBEDTLS_SSL_TLS1_3_COMPATIBILITY_MODE and disable MBEDTLS_SSL_KEEP_PEER_CERTIFICATE
Build as instructions given in README

Additional information
NA

Thanks for the report.
The TLS 1.3 implementation currently requires MBEDTLS_SSL_KEEP_PEER_CERTIFICATE, so this is more an issue in the documentation and check_config.h for allowing the combination

Also note that in docs/architecture/tls13-support.md it is already documented that MBEDTLS_SSL_KEEP_PEER_CERTIFICATE is not supported in conjunction with MBEDTLS_SSL_PROTO_TLS1_3


Add “boilerplate projects” blog post in README.md

📖 Description
Now that we have a published blog post that explain the reasoning behind our boilerplate projects, let’s reference it in them.

🦀 Requesting reviewers for this pull request:

@Madumo (contributor with 0 commits in the last 90 days and 19 commits overall)


[contracts] add and update contract tasks

initialize task
update existing depending on the changes

#884 already merged. will close this as well.