Refactor Http class to utilize ParameterHelper for http_params conver…

…sion
fix: #88

Brief Summary of The Change

Pull Request checklist
I confirm that the following checklist has been completed.

[x] Add/Change test cases for the changes.
[x] Add/Change the related documentation, should also change docs/source/config.rst when you change file default_config.yaml.
[ ] (Optional) Add your change to UPDATING.md when it is an incompatible change.

BTW, since it is an incompatible change, we should add some comments in https://github.com/apache/dolphinscheduler-sdk-python/blob/1b2ad576eef87430e0abee47cce60eec5a374475/UPDATING.md#L29 we already have some example in that.
And we better add some DeprecationWarning for the user who still passes old parameter type for it. the old parameter seems like
http = Http(
        name="http",
        url="http://www.google.com",
        http_method="GET",
        http_params=[
            {"prop": "abc", "httpParametersType": "PARAMETER", "value": "def"}
        ],
    )

And we should raise some warnings and tell users that the format is deprecation
https://github.com/apache/dolphinscheduler-sdk-python/blob/e1d15274a6ffc2cf2ee3236d3ba3e8a0b1cf70d3/src/pydolphinscheduler/core/task.py#L202-L207
maybe it can be
        if isinstance(http_params, list):
            warnings.warn(
                "The `http_params` parameter currently accept dict instead of list, you parameter is ignore.",
                DeprecationWarning,
            )

Hi @HarshitNagpal29, it is good to see you add some tests and fantastic docstring in this PR, well done 👍 +1
I had left some new comments for this PR, PTAL if you have time

@zhongjiajie sir i have made all the changes as you mentioned.

@zhongjiajie sir i am looking forward to participate in gsoc 2024 , i am new to open source contribution but i am well aware with javascript, node.js and somewhat python as well , i found your organisation pretty interesting and i am looking forward to contribute more, can you please provide some resources, places where i can connect with mentors more often , and some valuable feedback, i will be really grateful for that.
thank you

Hi @HarshitNagpal29, it is good to see you add some tests and fantastic docstring in this PR, well done 👍 +1 I had left some new comments for this PR, PTAL if you have time

sir please tell me what to do, i am happy to help

@zhongjiajie sir i am looking forward to participate in gsoc 2024 , i am new to open source contribution but i am well aware with javascript, node.js and somewhat python as well , i found your organisation pretty interesting and i am looking forward to contribute more, can you please provide some resources, places where i can connect with mentors more often , and some valuable feedback, i will be really grateful for that.
thank you

Great, do you have any resources about gsoc 2024? our project join gsoc 2022 but not in 2023, and I have act as mentor for 2022 too. I want to know the timeline about project submission.

can you please provide some resources, places where i can connect with mentors more often
you can find my email in my GitHub profile and connect me via that.

BTW, we have a code style check for our codebase, you could run the command tox -e auto-lint to format the code. for more information, you can see in https://github.com/apache/dolphinscheduler-sdk-python/blob/main/CONTRIBUTING.md#code-style-using-tox
and for how to set tox development you can see in https://github.com/apache/dolphinscheduler-sdk-python/blob/main/CONTRIBUTING.md#automated-testing-with-tox

And I have commit and change some code to you branch, so you should pull them to your local before you add your change

@zhongjiajie sir i have made the changes and added some tests as well suggested by you.

@zhongjiajie sir i have mailed you to connect with you

@zhongjiajie sir I am waiting for your response

I approval the CI run

Other LGTM, but it seems you forget to format the code by too -e auto-lint

Sorry for the inconvenience i will try to do it now.

you can run the command and then append one more commit this this PR

@zhongjiajie sir i don't know why but i am not able to setup and run tox command on my local machine, I have tried a lot really sorry for that but still I have done the formatting, linting, styling and all using black and ruff commands manually, please check if it still needs improvement, again sorry for inconvenience.

I approval CI run.
what OS do you use in your local machine?

@zhongjiajie sir i use mac os. Also sir what to do with these CI run which is failing.

@zhongjiajie sir i use mac os. Also sir what to do with these CI run which is failing.

tax should work with macOS, and you should format http.py files because log said
lint: 15588 W commands[0]> python -m black --check . [tox/tox_env/api.py:427]
[549](https://github.com/apache/dolphinscheduler-sdk-python/actions/runs/7435014085/job/20230557494?pr=130#step:5:550)
would reformat /home/runner/work/dolphinscheduler-sdk-python/dolphinscheduler-sdk-python/src/pydolphinscheduler/tasks/http.py
[550](https://github.com/apache/dolphinscheduler-sdk-python/actions/runs/7435014085/job/20230557494?pr=130#step:5:551)

[551](https://github.com/apache/dolphinscheduler-sdk-python/actions/runs/7435014085/job/20230557494?pr=130#step:5:552)
Oh no! 💥 💔 💥
[552](https://github.com/apache/dolphinscheduler-sdk-python/actions/runs/7435014085/job/20230557494?pr=130#step:5:553)
1 file would be reformatted, 157 files would be left unchanged.

do you install tox first then trying run command tox -e auto-lint?

@zhongjiajie sir i use mac os. Also sir what to do with these CI run which is failing.

tax should work with macOS, and you should format http.py files because log said
lint: 15588 W commands[0]> python -m black --check . [tox/tox_env/api.py:427]
[549](https://github.com/apache/dolphinscheduler-sdk-python/actions/runs/7435014085/job/20230557494?pr=130#step:5:550)
would reformat /home/runner/work/dolphinscheduler-sdk-python/dolphinscheduler-sdk-python/src/pydolphinscheduler/tasks/http.py
[550](https://github.com/apache/dolphinscheduler-sdk-python/actions/runs/7435014085/job/20230557494?pr=130#step:5:551)

[551](https://github.com/apache/dolphinscheduler-sdk-python/actions/runs/7435014085/job/20230557494?pr=130#step:5:552)
Oh no! 💥 💔 💥
[552](https://github.com/apache/dolphinscheduler-sdk-python/actions/runs/7435014085/job/20230557494?pr=130#step:5:553)
1 file would be reformatted, 157 files would be left unchanged.

@zhongjiajie sir I made changes in http.py file using tox , I used different machine with linux as OS , in my mac machine even after installing tox when I was inputting "tox -l" command, it was showing me only version of python that is "312" no file like tox.ini and all, maybe it was some kind of a glitch.

maybe you can remove the project and try clone from the GitHub again after this PR merged

@zhongjiajie ok I will try that method, but do you need any more changes in this pull request

lint still no pass, maybe you can run command python -m ruff check --fix --unsafe-fixes . to fix it
lint: 16342 W commands[1]> python -m ruff check . [tox/tox_env/api.py:427]
[553](https://github.com/apache/dolphinscheduler-sdk-python/actions/runs/7438828861/job/20249516885?pr=130#step:5:554)
tests/tasks/test_http.py:167:13: F841 Local variable `http` is assigned to but never used
[554](https://github.com/apache/dolphinscheduler-sdk-python/actions/runs/7438828861/job/20249516885?pr=130#step:5:555)
Found 1 error.
[555](https://github.com/apache/dolphinscheduler-sdk-python/actions/runs/7438828861/job/20249516885?pr=130#step:5:556)
No fixes available (1 hidden fix can be enabled with the `--unsafe-fixes` option).

@zhongjiajie sir please check it now, i fixed that linting issue and in my machine it is showing me everything fine

@zhongjiajie sir please provide approval now

test error for case test_http_params_deprecation_warning with link https://github.com/apache/dolphinscheduler-sdk-python/actions/runs/7445619872/job/20284481402?pr=130

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f16599f) 90.86% compared to head (3a22ec0) 90.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
+ Coverage   90.86%   90.89%   +0.02%
==========================================
  Files          64       64
  Lines        2354     2361       +7
==========================================
+ Hits         2139     2146       +7
  Misses        215      215

Flag
Coverage Δ

unittests
90.89% <100.00%> (+0.02%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Hi @HarshitNagpal29  I add and fix some tests in 3a22ec0
for the test_http_params we need to mock the return of function gen_code_and_version which is called with dolphinscheduler code in apache/dolphinscheduler
@patch(
    "pydolphinscheduler.core.task.Task.gen_code_and_version",
    return_value=(123, 1),
)

and for case test_http_params_deprecation_warning, w[-1].message is detail of warnings message, which depend on your     warning message in the class Http

Now all CI are green, merging 🎉 thanks for your contribution and looking forward your next contribute

@zhongjiajie sir i am really grateful that i was able to work on this issue with you and learn lot of new things, i am looking forward to contribute more , can you please suggest some good first issues which i can work upon or maybe some documentation changes in this project or some other.

Hi @HarshitNagpal29 here are two of issue maybe good and easy to fix

Docs changed only, you can learn how our docs build and render https://github.com/apache/dolphinscheduler/issues/8955
Code change, which you need to add utils class to detect and setValue and auto add out-put parameter for our code https://github.com/apache/dolphinscheduler-sdk-python/issues/61


Generated jupyter notebook cell ids (required for jupyter notebook format 4.5+)

Changes
Generated cell ids with nbformat.normalize
Related Issues
A workaround PR #806
Checks

[x] update example/tutorial notebooks

Related tools
nbformat=5.6.1
script:
import json
from glob import glob

import nbformat
from nbformat.validator import normalize

nbs = glob("*.ipynb")
for n in nbs:
    with open(n) as fh:
        print(f"loading file {n}")
        nb_data = json.load(fh)
    n_changes, nb_norm = normalize(nb_data, version=4, version_minor=5)
    if n_changes > 0:
        print(f"rewriting notebook {n}")
        NB = nbformat.from_dict(nb_norm)
        with open(n, 'w') as fh2:
            nbformat.write(NB, fh2, version=4)

xref: https://github.com/jupyter/nbformat/issues/303

Omitting the major/minor versions for normalize/validate seems to work. Now we have a dependency problem (xarray) due to the environment caching.


Fix for XLS0503

Not sure if this is the right fix but I was trying to run the sample but was getting the XLS0503 error

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Lazareena sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Mmmm in advance thanks @Lazareena for your PR :-)
Although this may fix the build issue I keep thinking it should work without such: as I told yesterday to another user in an issue I think this had to do with a temporal NuGet package which's no longer available.
If you try again with current develop branch, do you still see the error? If you do, which's your env set up?
Thanks again,
—Marcos

Let me please close this PR for now, feel free to reopen it if may be needed again.


Enhancing Register page

I really like the Your website! It's easy to navigate, but the sign-up page feels a bit outdated. I think I can design a more modern and visually appealing registration process that's still user-friendly.  I'm interested in working on this for GSSOC'24. With a fresh design, we can make signing up for Your website a smoother and more inviting experience!
Recent Page made my be was -

@kashisharora9462  good idea,
but already assigned to someone else on another issue,

@kashisharora9462  you can work on adding user experience section on home page,
see pinned issues.

Okay thank you sir.
On Wed, 19 Jun, 2024, 4:50 pm ADARSH MAURYA, @.***>
wrote:

@kashisharora9462 https://github.com/kashisharora9462 you can work on
adding user experience section on home page,
see pinned issues.
—
Reply to this email directly, view it on GitHub
https://github.com/4darsh-Dev/CogniGaurd/issues/103#issuecomment-2178429553,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BEQ6HA35ZEAMLUAH4YT2RILZIFSP7AVCNFSM6AAAAABJRMJDUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZYGQZDSNJVGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

⚠[URGENT]⚠ Reminder for GSSoC 24' Contributors Please join our CogniGuard Project #general GSSoC'24 Discord channel:
Here you can discuss your queries and doubts with your mentors.
See #109 issues section.

⚠[URGENT]⚠ Reminder for GSSoC 24' Contributors Please join our CogniGuard Project #general GSSoC'24 Discord channel:
Here you can discuss your queries and doubts with your mentors.
See #109 issues section.

@kashisharora9462  you haven't raised any PR?

@4darsh-Dev, could you please assign this task to me? I'm eager to work on it.

sure @ruthwikchikoti ,
you can work it.
see live URL, of web app and share ss of your proposed changes,
what changes you want and any design or something.

@4darsh-Dev, Should I submit the design of the register page first, or should I raise a PR for it?

@4darsh-Dev  is this good  !?

good work @ruthwikchikoti  it's much better,
raise the pr 👍🏻  with suitable description.
Make sure it's responsive on mobile display as well.

⚠[URGENT]⚠ Reminder for Closing of Contribution period for GSSoC 24'
Finish your work and raise the PRs ASAP to get your points.
Thanks💗 for your valuable Contributions!

GSSoC 24 has been completed Finally'
It was a great experience working with you all
Thanks💗 for your valuable contributions!
PA nomination has been started, Do fill out the forms soon. Share your experiences and let's connect on socials


Errors upon trying to launch

I get two errors in my command prompt when trying to launch.
[SCRIPT UI] [errr] COMPILE ERROR Undefined variable "Progression_GetPreference"
[SCRIPT UI] [errr] ui/menu_lobby.nut line [233] column [42]
I followed this tutorial here "https://www.youtube.com/watch?v=haDDq0BGbhc" and unable to find anyone else with this error online.
thank you for helping! :)

The video is out of date, follow the tutorial in the README.

@Rowdy09 are you still having issues or have you followed the instructions in the README?
Alternatively, if you really wanted a video guide, here's an up to date one: https://www.youtube.com/watch?v=1g_0y_bQxqc&t=72s&pp=ygUUcGVuZ29vbiB2YW5pbGxhIHBsdXM%3D

Hello, I'm having the same problem, I've followed the README instructions perfectly, and it works on my computer, but not on my laptop. Assistance would be appreciated.

@CoolDawg08 can you open your own issue and upload a log (the furthest down file in R2Titanfall/logs

This issue is about a month without a response, the issue is simply that the video was out of date
Please watch the video provided earlier, or follow the settings in the README, either on GitHub or on Thunderstore


Confetti Not Shown in Fullscreen

I am making an app that uses a full screen. However, when the confetti is executed, since the party-js element is outside of my fullscreen div element, it won't show when in full screen. Is there anyway to move the element and nest it inside my own element or manually render it?

Hi, the container element should automatically fit to screen size. Could you maybe provide a minimal, reproducable example?

`

        {/* Full Screen Content */}

`
My app allows the div to be viewed in full screen, however, the party js container is outside of that full screen. Therefore, it is not shown in the full screen container as it is not nested within it even if it is scaled to full screen size, it is not included in the full screen.

Hey, do you have any updates on this?

Hi sorry, uni is keeping me busy.
I'm currently not sure on how to approach this, since I'm unsure how the fullscreen API operates. I'll definitely look into this, and I will let you know what I can do!

No worries, take your time!

Hello, the project I'm working on that uses this needs the confetti effect to work soon and I believe I've found a solution. Since the fullscreen api selects an element and all its child nodes in it to be viewed in full screen, all that's needed is to have the option to move the confetti container.


missing step 3: Enable Access Tracing

the page lists:
To enable last access time tracking with the Azure portal, follow these steps:

Navigate to your storage account in the Azure portal.

In the Data management section, select Lifecycle management.

there is a step 3 missing: check the checkbox "Enable access tracking"

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 171a0dc0-35ad-be69-023c-4943195c0d7f
Version Independent ID: 0699b9e6-c72b-3527-7215-f629242828f5
Content: Configure a lifecycle management policy - Azure Storage
Content Source: articles/storage/blobs/lifecycle-management-policy-configure.md
Service: storage
Sub-service: common
GitHub Login: @normesta
Microsoft Alias: normesta

@indexample
Thanks for your feedback! We will investigate and update as appropriate.

@indexample
Thanks for reporting this! We have created a PR for this issue and the changes should go live soon.


Feature/argo config management

Description of changes:

Fixed the bug where the replicaCount for csi efs addon is not passing to ArgoCD
Fixed the csi efs node service account so it is consistent as Terraform implementation

note: container-insignt is not in sync due to endpoint of AMP is not provided (needs another PR to create the IRSA as well)

Notes:

Karpenter is actually working, out of sync is due to the ca-bundle in the secret is not in sync. Needs to add ignoreDifferences to let Argo know.
nginx is in sync.
need another PR to add kubevious to addon repo
need another PR to add velero to addon repo

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@shapirov103 ^^ when you get a chance, can you review this PR please. Thanks.


Performance improvement by user-provided CTR variable

This improvement has to be assessed with caution as it is not clear that it does not raise some concerns about the malleability of VRFs.

Closed because it is not clear that it completely secure (possible vulnerability in finding valid CTR values with lower hashes).


Use standard sh-style redirection for stderr

^ has been removed as a stderr redirection operator (fish-shell/fish-shell#4394) in future versions of fish.

Ready to merge!

I squashed and pushed with slightly modified commit message.
Thanks!


Test 3: Percy Automation via Jenkins

Reverted webhook to accept application/x-www-application-form-urlencoded.

fizzle


pipewire: 0.3.56 -> 0.3.57

libcamera: unstable-2022-07-15 -> unstable-2022-09-03

https://github.com/libcamera-org/libcamera/compare/e9b6b362820338d0546563444e7b1767f5c7044c...f1776100f55e70320a8938586bc8bf2f242addd4

pipewire: 0.3.56 -> 0.3.57

https://gitlab.freedesktop.org/pipewire/pipewire/-/releases/0.3.57
https://github.com/pipewire/pipewire/compare/0.3.56...0.3.57

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

we can use openssl instead of gnutls: libcamera-org/libcamera@12f48aa (not sure if it makes sense)

Yes, please!

Updated libcamera. libjpeg is only used by the Android bits, which we don't build.

They use the openssl tool at build time, so we do need it in both.

Should be OK to merge now? Want to get it in the next staging before we have to figure out LC3 for 0.3.58.
@jtojnar @jansol

No objections.


Allow to specify table header classes

There was no way to add classes to specify attributes in the header cells like it is possible to do with row cells, so here it is.
Plus, added a way to specify a class directly on the thead too.

Codecov Report

Merging #806 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #806      +/-   ##
==========================================
+ Coverage   99.76%   99.76%   +<.01%
==========================================
  Files         270      270
  Lines        6928     6930       +2
  Branches     1686     1686
==========================================
+ Hits         6912     6914       +2
  Misses         16       16

Impacted Files
Coverage Δ

src/components/tables/Table.tsx
100% <ø> (ø)
:arrow_up:

src/components/tables/TableHeaderCell.tsx
100% <ø> (ø)
:arrow_up:

src/components/tables/TableHeader.tsx
100% <100%> (ø)
:arrow_up:

...ponents/tables/table-children/TableChildHeader.tsx
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48eed47...8e9f2f4. Read the comment docs.


Implement payee dark tag obfuscation

According to the specification https://github.com/rgb-org/spec/blob/master/01-rgb.md#transfer-proofs

Closed because of https://github.com/rgb-org/spec/issues/86


setdir.c could include stdio for gcc-10

In compiling the MITgcm with gcc-10 on a MacOS machine, I needed to add #include <stdio.h> to the top of setdir.c, or else I would get and error trying to use sprintf.

Hi Jody, is this a bug in gcc-10? or a documented change in the behaviour of gcc? If adding this line still allows compiling with older gcc versions (I tried with gcc-9 on MacOS without any problems) on different operating systems, then I'd opt to add this line in a new PR.

I can't find where its documented in the gcc-10 changelog: https://gcc.gnu.org/gcc-10/changes.html
To be a bit more informative, without this, I get
mpicc  -DWORDLENGTH=4 -DALWAYS_USE_MPI -DALLOW_USE_MPI -DHAVE_SYSTEM -DHAVE_FDATE -DHAVE_ETIME_SBR -DHAVE_CLOC -DHAVE_SETRLSTK -DHAVE_STAT -DHAVE_FLUSH  -I/usr/local/include -c setdir.c
setdir.c:22:4: error: implicitly declaring library function 'sprintf' with type
      'int (char *, const char *, ...)' [-Werror,-Wimplicit-function-declaration]
   sprintf(RUN_DIR,"rank_%d",*myPEListId);
   ^
setdir.c:22:4: note: include the header <stdio.h> or explicitly provide a declaration for 'sprintf'
1 error generated.

mpicc is installed with brew install gcc and brew install open-mpi.   I'm not using gcc-10 for any particular reason other than its what home-brew happened to give me.


Issue running pod install

Hey just want to let you know that doing just pod install on the Example folder triggered this error:
[!] Unable to satisfy the following requirements:

BAFluidView (from ../) required by Podfile
BAFluidView (from ../) required by Podfile
BAFluidView (= 0.1.1) required by Podfile.lock

However, running pod update after solved it.

Ah that's because I did commit after running "pod update". The PodFile.lock is out of date. I'll fix it, but you can also do it too. Before running "pod install" in the Example directory, run "pod update".

Yep, as I mentioned doing pod update fixed it :+1:

Ha! How did I miss your last sentence? Either way it's updated and thanks for catching that good :)

Np, btw, awesome library. I loved going thro the logic of how you implemented it. Its awesome :)

Thanks! It's great to hear that the logic makes sense to people other than myself :)

Absolutely. I even learnt a lot by just seeing how you use made everything with just 3 animations, one horizontal one vertical and one that changes the waves. It's just fantastic :+1:


Doesn't load style from public folder

Hello, I have a stylesheet in the folder "public" named "style.css". I set the public page with this line of code:
app.use(express.static(__dirname + "/public"));

And it's working fine, except for one file: views\wiki\how_to_play.ejs. I just copy pasted the file and tried, but the style won't load. I used this code in the head:
<link rel="stylesheet" type="text/css" href="style.css">

In the same folder I have another file called index.ejs with the same code, and here the loading of the stylesheet works just fine.
Anyone knowing why? If you need to know enything, just ask. Sorry for my bad English.

I found the fix for the issue: First I had this:
<link rel="stylesheet" type="text/css" href="style.css">

But, when I chanced it to this:
<link rel="stylesheet" type="text/css" href="/style.css">

Everything worked just fine. Anyone knows why?

Hi @Paultje52, the reason it failed to load is because style.css is a relative link to the current page.  By adding the leading / you made it absolute to the domain name.  Glad you figured it out!


Elm Client

Would be nice to have a deepstream elm client like horizon-elm client . I wouldnt do much of a good job trying to write one at the moment as i just started learning elm. but any thought on this.

Hi @joshua1 !
We currently do not have this on our roadmap for a long future. Feel free to try it out and let us know if you need any support.


Add initial empty FMA template for Asterisc

This PR is for the Asterisc FMA.
Status: currently a very early draft, just started as a copy of the template.

We can share this branch to make edits as we think of things. (No rebasing and force pushing until it's done.)

I've taken this on and updated. The initial draft is ready for review.

This document often uses the fact that asterisc/kona will not be in the hot path as a justification for low risk. My understanding of the goal of the project is to have a fallback for cannon/op-program that maintains the permissionless property. Therefore it is assumed that it may be part of the hot path, we should be planning for that case. What happens if it fails when its in the hot path? Line 94 touches on this, but not on the case there is a failure for both op-program/cannon and kona/asterisc

Good point. I've updated to add a section to Failure Modes and Recovery Paths Analysis detailing this situation. I believe with this, your point should be covered but let me know if there's any other holes you can poke!

This document often uses the fact that asterisc/kona will not be in the hot path as a justification for low risk. My understanding of the goal of the project is to have a fallback for cannon/op-program that maintains the permissionless property. Therefore it is assumed that it may be part of the hot path, we should be planning for that case. What happens if it fails when its in the hot path? Line 94 touches on this, but not on the case there is a failure for both op-program/cannon and kona/asterisc

Yes, and I think "hot path" isn't really a meaningful concept to talk about in here, because any of these failures will only occur if we have switched the active game type to use Kona + Asterisc, i.e. it's "in the hot path", right? It's not going to be exercised if nobody is creating dispute games with it.
So it seems to me that "Kona and Asterisc Hot Path Failure" doesn't really add anything that's not covered in the other sections.

This document often uses the fact that asterisc/kona will not be in the hot path as a justification for low risk. My understanding of the goal of the project is to have a fallback for cannon/op-program that maintains the permissionless property. Therefore it is assumed that it may be part of the hot path, we should be planning for that case. What happens if it fails when its in the hot path? Line 94 touches on this, but not on the case there is a failure for both op-program/cannon and kona/asterisc

Yes, and I think "hot path" isn't really a meaningful concept to talk about in here, because any of these failures will only occur if we have switched the active game type to use Kona + Asterisc, i.e. it's "in the hot path", right? It's not going to be exercised if nobody is creating dispute games with it.
So it seems to me that "Kona and Asterisc Hot Path Failure" doesn't really add anything that's not covered in the other sections.

It sounds like your suggesting to remove the "Hot Path" section I added in response to the above is that correct? If so, then Mark's comment would be unsatisfied.

This is a blocker for this FMA: https://github.com/ethereum-optimism/design-docs/pull/140
We need to reference fma-generic-contracts.md from this doc.


Upload script should only look at files that match filetype in config.ini

The iteration loop here grabs all files and attempt to extract height and width without checking to see if the file is actually an image.

This could probably be done by replacing subfolder.iterdir() with subdir.rglob(filetype). Shouldn't be too hard to do, but I don't want to create new errors. Could @olgaliak  or someone else try changing this on their branch and seeing if it works?

@yashpande I know. Just logging the bug so we will fix. Most likely will rewrite this area.


Question: Where is the difference between: "Microsoft.Toolkit.HighPerformance.Buffers.SpanOwner" and "DotNext.MemoryRental"?

Title.
src for "SpanOwner": https://learn.microsoft.com/en-us/dotnet/communitytoolkit/high-performance/spanowner
I cant quite grasp in what scenario yours may be better or equal to that type? I liked from your type that it may rent from whatever pool depending on the size needed, although I dont know if the reasoning-algorithm for that beats the purpose of "SpanOwner" from "Microsoft.Toolkit.HighPerformance" Nuget-package.
Any advise to this is very very appreciated cause I am in process to determine the proper buffering-strategy and would be cool to get the best one selected ^^
Btw very strong and dedicated work you have put in here, you earned my highest respect!

Also, is it possible for either "MemoryRental" or "BufferWriterSlim" to allow for this:
Lets asume, you want to allocate a char[] buffer with 2KB of size, so (1KB * sizeof(char)) could either of the above Buffers just not create (safely) the first 1KB segment onto the Stack and then allocathe the other half (the next 1KB) onto the shared-pool with whatever pool the above Buffers choose, and obtain a reference internally to that 1KB segment in the heap?
The good thing with this approach would be that you can beautifuly have quite abit of stackmemory and the remaining in the heap without putting ÈVERYTHING onto the heap just because we want just abit more memory than our "allowedStackallocThreshold" allows us to put on stack, so:
int sizeOnSharedPool = myTotalSize - allowedStackallocThreshold;
so, example:
MemoryRental pool = new(


frontend: TopBar: Fix mobile menu to close when popup opens

So that people can interact with the new popup.
To test this, touch the notification icon from the mobile menu. Note how you can not scroll the list of notifications? With this fix people can scroll the list of notifications when it pops up.

The mobile menu moves and allows scrolling, looks like this works!


[Addition]:

Hotspot b58 Addresses
112wCgpp4n9WF6KkGTxiJaa9zNiFbee76f28P5a7DyQFN28QvdJ3
Discord Handle
xX4Shy2High0Xx#0694
Reason(s)
No hotspot at 80m high would make this on a 5.8 dbi antenna there is just no way this obvious gaming of the system and has huge impact on rewards for the area in which it is located.

Sorry to say, but what he is witnessing is possible, you can also see his beacons traveling that far. This spot, at first sight, seems legit enough. You say it is obvious, so if it is, give us prove it is cheating/gaming.
FYI: I get those distances with far less transmit power...

too many miners can witness  he is existing. case closed

This guy has only witnessed a total of 66 not 288 hotspots
On Fri, Mar 18, 2022, 10:02 AM Shiloh Pichette @.***> wrote:

His hotspot is inside of a hotel that is why it is relayed because he does
not have permission to have the hotspot up and running and has no access to
port forwarding capabilities copy and paste this in Google maps "1 km
hotspots ￼882a138345fffff ￼ tinton falls nj united states" his hotspot is
nowhere near 80m high off that building
On Fri, Mar 18, 2022, 12:15 AM Paashaas2000 @.***>
wrote:

Sorry to say, but what he is witnessing is possible, you can also see his
beacons traveling that far. This spot, at first sight, seems legit enough.
You say it is obvious, so if it is, give us prove it is cheating/gaming.
FYI: I get those distances with far less transmit power...
—
Reply to this email directly, view it on GitHub
https://github.com/helium/denylist/issues/2508#issuecomment-1072091674,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARJLQ4WLVVJSHO3JAE6NTW3VAQUP3ANCNFSM5RAS3T6Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>


Fix statement to make it more accurate

Fix applies to the 1.3 and the master/1.4 branches. Thanks.

Thanks, @lparis.


fix for python3.5 building

After https://github.com/IntelPython/daal4py/pull/169 was noticed that building with python 3.5 was broken. This PR fixes it.

@KalyanovD Could you please also check that build works fine with/without NO_DIST option

@KalyanovD
We already discussed it but I will save it here.
Previously we deleted definitions because we got 'multiple definition' error with some compilers from VS on Windows. Please look at these rows:
https://github.com/IntelPython/daal4py/blob/a6f2efd2a5a87b242769c6ca24704932697eedd7/src/daal4py.h#L220
https://github.com/IntelPython/daal4py/blob/a6f2efd2a5a87b242769c6ca24704932697eedd7/generator/wrapper_gen.py#L93
I suggest to remove the definition through data_management_NumericTablePtr and return one of deleted. (One of them is returned in first commit of this PR)

@Alexander-Makaryev, you were right, with returning one of removed definitions daal4py is started to build locally on Linux with Python 3.5 and 3.7 in batch and distributed modes(NO_DIST=1 or 0 for 3.7).

I am ok with changes


notifyDataSetChanged() method not working for BaseSwipeAdapter

In  notifyDataSetChanged() has not defined inside the BaseSwipeAdapter there for it cant use. but GitHub source code have defined this method but after build gradle it not taken for the project

how to fix this ?

I was having same issue and I solved it by putting notifyDataSetChanged() code in @Override
public void fillValues(int position, View convertView) {} method. Hope this will help you!!!


DOC: Fixes LaTeX build error

The PDF doc build was chocking on the Parameters section being the first item.

I might be pushing a few more stylistic changes here, so maybe hold on merging. e.g.

@TomAugspurger at your leisure

One API question, do we want to expose Resampler at the top level, similar to Grouper? The methods like Resampler.fillna weren't being linked to correctly in api.rst. Rebuilding now, but it may have been because panads.Resampler.fillna isn't a thing. Would need pandas.tseries.resample.Resampler.fililna.

Actually, that seems to be an issue just with my build, as the traivs docs have it linked correctly: http://pandas-docs.github.io/pandas-docs-travis/api.html#resampling

hmm, btw make sure that in your doc-build env you actually have an installed pandas of master/latest (you can simply install from conda), as it doesn't use the current one (as you are in pandas/doc)

side note, this is master: https://travis-ci.org/pydata/pandas/jobs/115054959
there is a seg fault right at the end of building the docs (before all of the create * stuff). Any idea what that is from?
I don't get this locally.

@TomAugspurger ok I am pretty much done with doc changes. So pls build at your leisure (or you can wait for the final tag prob sunday eve)

Ok, I'll merge this, and then build later tonight probably. You're last suggestion about having a real install fixed the link issues.
Not sure about the segfault in travis. The error this is fixing does occur towards the end of the build, but is probably unrelated. I'll look into it tonight.

gr8
yeah I noticed the segfault as was looking thru logs
i bet it's for the latex building on Travis

actually. let's let everything turn green. I'll push the 0.18.0 tag later today. You can build (and if anything else you need to fix, just include it and do a PR later). Then can release on sunday.

just did a quick build. Seems like the API reference is having trouble with the accessors (.str, .dt, .plot). It's also not linking /building those properly in the dev build. http://pandas-docs.github.io/pandas-docs-travis/api.html#string-handling Other than that, things seem ok at a glance.
Gotta run for now, but I'll investigate later.

thanks @TomAugspurger lmk.

@TomAugspurger about the API docs, yes, that is a known issue: https://github.com/pydata/pandas/issues/12161. I inteded to look at it, but won't be able to do this for 0.18.0. I can do it later in April, but if you can have a look now, great! (but if you cannot directly fix it, it shouldn't hold up the release. Another possibility is building with 1.1.3, which I thought still worked but I am not sure).

Oh, I assumed that section in the wiki with sphinx==1.1.3 was just out of date :)
I’ll try both 1.1.3 and seeing what’s wrong.

On Mar 11, 2016, at 9:49 AM, Joris Van den Bossche<EMAIL_ADDRESS>wrote:
@TomAugspurger https://github.com/TomAugspurger about the API docs, yes, that is a known issue: #12161 https://github.com/pydata/pandas/issues/12161. I inteded to look at it, but won't be able to do this for 0.18.0. I can do it later in April, but if you can have a look now, great! (but if you cannot directly fix it, it shouldn't hold up the release. Another possibility is building with 1.1.3, which I thought still worked but I am not sure).
—
Reply to this email directly or view it on GitHub https://github.com/pydata/pandas/pull/12586#issuecomment-195423140.

Well, it should be :-)
It's possible that it works with 1.2 as well, but I switched to 1.3 for speed (otherwise it wouldn't finish in time on travis). The reason we were still using 1.1.3 is that the API docs were broken on 1.3 for the first minor releases, and only recently was fixed.
We should maybe actually also test sphinx 1.4, which is in beta.

The instructions in the docs also need an update: http://pandas-docs.github.io/pandas-docs-travis/contributing.html#requirements (> 1.3.2 also works now: https://github.com/pydata/pandas/issues/10316)


vlc/nir/depth intrinsics

hi! thanks for the great repo, looking forward to trying it out.
do you support/have plans to support accessing the grayscale and AHAT depth/nir camera intrinsics, perhaps a way to get a uv-mapping look up table (since I think they dont really provide the traditional focal length/distortion parameters)?

Hello,
Yes, the plugin supports access to the MapImagePointToCameraUnitPlane and MapCameraSpaceToImagePoint methods of the Research Mode API which encode the intrinsics of the cameras.


WIP-refactoring nesting

In an effort to lower the generalized "cognitive complexity" score assessed by SonarCloud, this pr and branch serves as an effort to lower all cognitive complexity-assessments-points > 1 to be <= 0. Please refer to Issue "Lowering Cognitive complexity as per SonarCloud" for more information.

@AlexPatrie @eagmon   is this PR still about to be applied? We were informed about the biosimulator not solving simple SBML problems. So I was about to look into this, but would not want to change code if this PR is about to be merged in.
Critically there is an issue merging in the changes for the identifiers.org parts, where you are planing to commit  a change from
http://identifiers.org/combine.specifications/sbml

to
https://identifiers.org/combine.specifications/sbml

this should not happen, since http://identifiers.org/combine.specifications/sbml is a namespace, and the https version would be a different namespace. So if this PR is going to merge, then that should not be merged in.

@AlexPatrie @eagmon is this PR still about to be applied? We were informed about the biosimulator not solving simple SBML problems. So I was about to look into this, but would not want to change code if this PR is about to be merged in.
Critically there is an issue merging in the changes for the identifiers.org parts, where you are planing to commit a change from
http://identifiers.org/combine.specifications/sbml

to
https://identifiers.org/combine.specifications/sbml

this should not happen, since http://identifiers.org/combine.specifications/sbml is a namespace, and the https version would be a different namespace. So if this PR is going to merge, then that should not be merged in.

Hi @fbergmann! This is an outdated PR that I should have originally archived. Please feel free to do whatever work you need here. I will be closing this PR.


Think about using Datalog as a spec definition language

Currently the architecture spec files are using what they are using. Have you considered to use Prolog/Datalog syntax? It will ease the extension of the language, REPL-like architecture debugging during the implementation phase, will extend the flexibility of description.
Notable applications for using Datalog/Prolog in similar cases are:

GrammaTech ddisasm using Souffle Datalog-ish language
CMU SEI Pharos using Prolog for type rules

Prolog is actively developed these days, see the Awesome Prolog list. And there is work-in-progress high performance implementation in Rust - Scryer Prolog.

Intriguing idea - we've been playing around with other uses of Datalog via Souffle.  Was aware of the CMU SEI project and Scryer Prolog, but not ddisasm, so thanks for the pointer.  Could you ellaborate on your thoughts re "REPL-like architecture debugging"?  Souffle does not have a REPL and actually debugging in that environment is arguably the hardest part of using it.

Souffle doesn't (at least yet, but it's still a valid Datalog most of the time, so it's possible to reuse other implementations during the development.

I like your strategy  :)   Will definitely spend some time looking at the ddisasm strategy with an eye to future uses.  Cheers, D

@d-millar just for the record, the answer of Souffle developers, if you haven't seen it:

We add a new --repl option to Souffle, which calls a script something like the following:
#!/bin/bash
echo > ~/.souffle_1.tmp
echo > ~/.souffle_2.tmp
while true; do
   IFS= read -r -p "$ " LINE
   echo "${LINE}" >> ~/.souffle_1.tmp;
   souffle -F- -D- ~/.souffle_1.tmp && \
       cat ~/.souffle_1.tmp > ~/.souffle_2.tmp || \
       cat ~/.souffle_2.tmp > ~/.souffle_1.tmp;
done;


Add job_name as a staticmethod in SLURMEnvironment class

Proposed refactor
Add job_name as a staticmethod in SLURMEnvironment class to improve code quality of the staticmethod job_id:
https://github.com/PyTorchLightning/pytorch-lightning/blob/6fc7c54c3af6dc3a446253df379e459d18bacb85/pytorch_lightning/plugins/environments/slurm_environment.py#L41-L54
Motivation
Currently:
os.environ.get("SLURM_JOB_NAME")

is used to get the slurm job name. This could be replaced by a staticmethod in the SLURMEnvironment class to improve the code quality.
Pitch

Add a staticmethod job_name to the SLURMEnvironment class.
Replace os.environ.get("SLURM_JOB_NAME") with the staticmethod job_name in the staticmethod job_id.

Additional context
@awaelchli

If you enjoy Lightning, check out our other projects! ⚡

Metrics: Machine learning metrics for distributed, scalable PyTorch applications.

Lite: enables pure PyTorch users to scale their existing code on any kind of device while retaining full control over their own loops and optimization logic.

Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, fine-tuning, and solving problems with deep learning.

Bolts: Pretrained SOTA Deep Learning models, callbacks, and more for research and production with PyTorch Lightning and PyTorch.

Lightning Transformers: Flexible interface for high-performance research using SOTA Transformers leveraging Pytorch Lightning, Transformers, and Hydra.

cc @justusschock @awaelchli @akihironitta

This looks good! There are two usages of slurm job name, one in AcceleratorConnector and one inside SLURMEnvironment itself.


Chat - Extra lines appear after copy past text to chat

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to https://staging.new.expensify.com/
and login with any account
Open any chat
Copy text from file "carta familias 2.txt" attached to this report
Past to chat
File
carta familias 2.txt

Expected Result:
Text should be pasted without any extra lines appearing.
Actual Result:
Extra lines appear after copy past text to chat
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.2.510
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/211429846-d3f4030b-1d88-4f65-9ab3-3d188f813660.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

Taking a look!

Hmmm. I don't think this is a bug. Most likely, this is an issue with the txt, rather than our app.
New lines and spaces are hidden special characters. That includes new paragraphs (extra space). I believe that .txt has new paragraphs, but the .txt format can handle them. In fact, if I delete the new lines and re-add them, we do not see this behavior anymore.
Pasting the text in Word also adds the paragraphs, confirming my theory. Closing.


202210 fix for 37409 checking if property exists before reading it

Description

It is necessary to check if the focus value exists before trying to read it.
Without this, disposing of a modal after hiding it triggers the following error.
Uncaught TypeError: Cannot read properties of null (reading 'focus')

https://github.com/twbs/bootstrap/blob/961d5ff9844372a4e294980c667bbe7e0651cdeb/js/src/modal.js#L191
Here is the example: https://codepen.io/ernestobr/pen/zYarvQq
Motivation & Context

Error is thrown when disposing of a modal that is hidden.
Type of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactoring (non-breaking change)
[ ] Breaking change (fix or feature that would change existing functionality)

Checklist

[x] I have read the contributing guidelines
[ ] My code follows the code style of the project (using npm run lint)
[ ] My change introduces changes to the documentation
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] All new and existing tests passed

Unless I'm misunderstanding something, it is the same as https://github.com/twbs/bootstrap/pull/37410 already closed based on https://github.com/twbs/bootstrap/issues/37409 already closed as well.
So I'm closing it.


Make it possible to update a location of a node

This is incase autodetection of IPAddress is not working very well
Signed-off-by: Jo De Boeck<EMAIL_ADDRESS>

Christophe dCPM, [21.05.20 14:57]
You can choose the address of the farm
But only the node can report it's location.
Otherwise this can be abused
And I've seen some incentive to be located in remote location
The farmer can configure its farm location.
So you have choice what you want to trust when searching for node in certain Locations

You can choose the address of the farm but only the node can report it's location.
And since there are some incentive to be located in remote location this can be abused.
The farmer can configure its farm location. So the user have the choice what he wants to trust when searching for node in certain locations


Quick Start guide MSPL test fails

I tried to follow the readme install guide and when I try to execute the MSPL test if fails:
I think that the documentation is missing as a requirement is to have a Metaorchestartor running. That could be?
kubectl get pods
NAME                     READY   STATUS    RESTARTS        AGE
nginx-748c667d99-dxwfr   1/1     Running   7567 (8d ago)   76d
nginx-748c667d99-swzdm   1/1     Running   0               76d
nginx-748c667d99-vjp76   1/1     Running   0               76d

python -m pip list | grep fluidos
kubectl-fluidos            0.0.1

git@github.com:fluidos-project/kubectl-fluidos-plugin.git
cd kubectl-fluidos-plugin
kubectl fluidos -f tests/dataset/test-mspl.xml
 kubectl fluidos -f tests/dataset/test-mspl.xml
2024-04-19 10:25:06,541 - kubectl_fluidos - INFO - Starting FLUIDOS kubectl extension
2024-04-19 10:25:06,541 - kubectl_fluidos - INFO - Invoking MSPL Service Handler
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/urllib3/connection.py", line 169, in _new_conn
    conn = connection.create_connection(
  File "/usr/lib/python3/dist-packages/urllib3/util/connection.py", line 96, in create_connection
    raise err
  File "/usr/lib/python3/dist-packages/urllib3/util/connection.py", line 86, in create_connection
    sock.connect(sa)
ConnectionRefusedError: [Errno 111] Connection refused

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/urllib3/connectionpool.py", line 699, in urlopen
    httplib_response = self._make_request(
  File "/usr/lib/python3/dist-packages/urllib3/connectionpool.py", line 394, in _make_request
    conn.request(method, url, **httplib_request_kw)
  File "/usr/lib/python3/dist-packages/urllib3/connection.py", line 234, in request
    super(HTTPConnection, self).request(method, url, body=body, headers=headers)
  File "/usr/lib/python3.10/http/client.py", line 1283, in request
    self._send_request(method, url, body, headers, encode_chunked)
  File "/usr/lib/python3.10/http/client.py", line 1329, in _send_request
    self.endheaders(body, encode_chunked=encode_chunked)
  File "/usr/lib/python3.10/http/client.py", line 1278, in endheaders
    self._send_output(message_body, encode_chunked=encode_chunked)
  File "/usr/lib/python3.10/http/client.py", line 1038, in _send_output
    self.send(msg)
  File "/usr/lib/python3.10/http/client.py", line 976, in send
    self.connect()
  File "/usr/lib/python3/dist-packages/urllib3/connection.py", line 200, in connect
    conn = self._new_conn()
  File "/usr/lib/python3/dist-packages/urllib3/connection.py", line 181, in _new_conn
    raise NewConnectionError(
urllib3.exceptions.NewConnectionError: <urllib3.connection.HTTPConnection object at 0x7f35281c7c70>: Failed to establish a new connection: [Errno 111] Connection refused

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/ggari/.local/lib/python3.10/site-packages/requests/adapters.py", line 486, in send
    resp = conn.urlopen(
  File "/usr/lib/python3/dist-packages/urllib3/connectionpool.py", line 755, in urlopen
    retries = retries.increment(
  File "/usr/lib/python3/dist-packages/urllib3/util/retry.py", line 574, in increment
    raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPConnectionPool(host='<IP_ADDRESS>', port=8002): Max retries exceeded with url: /meservice (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f35281c7c70>: Failed to establish a new connection: [Errno 111] Connection refused'))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/ggari/.local/bin/kubectl-fluidos", line 8, in <module>
    sys.exit(main())
  File "/home/ggari/.local/lib/python3.10/site-packages/kubectl_fluidos/__init__.py", line 181, in main
    fluidos_kubectl_extension(
  File "/home/ggari/.local/lib/python3.10/site-packages/kubectl_fluidos/__init__.py", line 163, in fluidos_kubectl_extension
    return on_mlps(data)
  File "/home/ggari/.local/lib/python3.10/site-packages/kubectl_fluidos/__init__.py", line 184, in <lambda>
    on_mlps=lambda x: MSPLProcessor(MSPLProcessorConfiguration.build_configuration(sys.argv))(x),
  File "/home/ggari/.local/lib/python3.10/site-packages/kubectl_fluidos/mspl.py", line 130, in __call__
    response = post(self.configuration.get_url(), headers=self._build_headers(), data=data)
  File "/home/ggari/.local/lib/python3.10/site-packages/requests/api.py", line 115, in post
    return request("post", url, data=data, json=json, **kwargs)
  File "/home/ggari/.local/lib/python3.10/site-packages/requests/api.py", line 59, in request
    return session.request(method=method, url=url, **kwargs)
  File "/home/ggari/.local/lib/python3.10/site-packages/requests/sessions.py", line 589, in request
    resp = self.send(prep, **send_kwargs)
  File "/home/ggari/.local/lib/python3.10/site-packages/requests/sessions.py", line 703, in send
    r = adapter.send(request, **kwargs)
  File "/home/ggari/.local/lib/python3.10/site-packages/requests/adapters.py", line 519, in send
    raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPConnectionPool(host='<IP_ADDRESS>', port=8002): Max retries exceeded with url: /meservice (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f35281c7c70>: Failed to establish a new connection: [Errno 111] Connection refused'))

@ggari-robotnik thank you for pointing this out.
Yes one needs a MSPL-metaorchestrator to be available. Without specifying the endpoint the pluging assumes it runs on one of the control-plane nodes.
We will clarify that in the documentation, and produce more informative error messages.


Overview blade to show Key-Value explorer

Most often than not I'm going to the AppConfig service to manage/look-up keys and values. The default Overview blade is not useful and I always end up navigating to the Key-Value Explorer blade. So fill the Overview blade space with Key-Value Explorer.

Thanks for the feedback, @SeanFeldman. I know the overview page is pretty empty today so it feels reasonable to just put key-values there. At some point, I think we will want to put usage and other statistical information there just like other Azure services, so it won't be empty and may look weird to see key-values in the overview page.


Chapter 3 03_atari_gan.py

Hi,
Can you show how to get the sample images produced by the generator network like in Fig7 of chapter 3?
Many thanks,
Quang

Hi!
They are available via "Images" section in TensorBoard. Every 1000 iterations, new fake and real images are being added.


Apply initial patches

Cache results of getArchiveEntries calls in ArchiveResourceSet.list
Improve application initialization performance by caching results
of getArchiveEntries to avoid continual rereading of jar contents
@see AN-107228: Improve ArchiveResourceSet lookup performance

Avoid unnecessary substring calls for ArchiveResourceSet lookup paths
Use less substrings When assembling archive lookup path to
reduce heap usage and GC during application startup
@see AN-107228: Improve ArchiveResourceSet lookup performance

@fluetm for review. re-applying your changes from https://github.com/appian/tomcat85/pull/1


Svelte 5: $effect and $effect.pre destroy fn is not called when navigating to another route

Describe the bug
$effect and $effect.pre destroy functions are not called when navigating out of the page.
Reproduction
routes/something.svelte

  Link
  <button type="button" {onclick}>Goto</button>

Click on a link or button, no "remove" is logged
Logs
add +page.svelte:13
add +page.svelte:6

System Info
System:
  OS: macOS 14.2.1
  CPU: (8) arm64 Apple M1
  Memory: 89.69 MB / 8.00 GB
  Shell: 5.9 - /bin/zsh
Binaries:
  Node: 18.19.0 - ~/.nvm/versions/node/v18.19.0/bin/node
  Yarn: 1.22.21 - ~/.nvm/versions/node/v18.19.0/bin/yarn
  npm: 10.2.3 - ~/.nvm/versions/node/v18.19.0/bin/npm
  pnpm: 8.15.5 - ~/.nvm/versions/node/v18.19.0/bin/pnpm
  bun: 1.0.15 - ~/.bun/bin/bun
  Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
Browsers:
  Chrome: 123.0.6312.59
  Safari: 17.2.1
npmPackages:
  @sveltejs/adapter-auto: ^3.1.1 => 3.1.1
  @sveltejs/kit: ^2.5.4 => 2.5.4
  @sveltejs/vite-plugin-svelte: ^3.0.2 => 3.0.2
  svelte: ^5.0.0-next.82 => 5.0.0-next.82
  vite: ^5.2.2 => 5.2.2

Severity
blocking an upgrade
Additional Information
No response

Can you provide a proper reproduction in the form of a git repo?
routes/something.svelte isn't a valid way to create routes, so I can't really make sense of where that code is supposed to go.

Oh, sorry, it's routes/something/+page.svelte
I'll create a repro.

Here is a repro: https://github.com/ampatspell/effect-destruction-repro
Turns out it's related to +layout.ts being present, even if it's empty.


Memory optimization in GLUON

Related user issue - https://github.com/apache/incubator-mxnet/issues/10382

Supporting Memonger with GLUON will help in memory optimization. Memonger is currently supported only with Symbolic mode.
There is a new environment variable - MXNET_GPU_MEM_POOL_TYPE introduced for Memory pool strategy which significantly reduces memory usage in - https://github.com/apache/incubator-mxnet/pull/11041 We need to test/experiment and document this feature.

+1, memory optimization is important.

+1, we also agree with memory optimization. When we reimplement some experiment, we always  get stuck with out of memory error if we want to use enough batch size for the experiment. And we found that MXNET_GPU_MEM_POOL_TYPE is not helpful.

+1 on documenting this environment variable

#12668

This PR has a useful fix, however, it was not taken to completion and closed due to inactivity. https://github.com/apache/incubator-mxnet/pull/11658
When we work on this issue, we need to revisit the changes suggested in this PR - https://github.com/apache/incubator-mxnet/pull/11658


config: disallow encryption for v2

Signed-off-by: tabokie<EMAIL_ADDRESS>What is changed and how it works?
Issue Number: Ref #12842
The restriction can be lifted after https://github.com/tikv/tikv/pull/14095.

Related changes
Check List
Tests

Unit test

Release note
None

/merge


Adding SDK version to nav bar (header)

Adding SDK Version to nav bar as the first step to make versioning more manageable
It is important to sync the documentation with the version of SDK that people use. Otherwise, backward incompatible updates can cause frustration to users.
This PR does not solve the problem with best practices but makes the first step to more user-friendly handling to versions
Before:

After:

This is quite a large diff for such a small change. Do we need all of these files to be under version control?
They need to checked in to a GitHub branch. There are ways to deploy docs in the way that puts the build artifacts to a different branch but this requires additional set up that I don't have time for: https://docusaurus.io/docs/deployment#deploying-to-github-pages


convmv: add Darwin support, reformat & migrate to pkgs/by-name

Description of changes

Add support for Darwin to convmv. This required disabling the tests as APFS requires filenames to be valid UTF-8. This will also affect Linux if a filesystem that enforces valid UTF-8 is used (such as ZFS with utf8only=on).
While we're here, make some changes to clean up the derivation:

Replace use of rec with finalAttrs pattern
Replace fetchurl with fetchzip
Added separate man output
Replace preBuild hook with explicit makeFlags initialization
Replace explicit patchPhase override with prePatch hook
Enable strictDeps
Disable redundant patchShebangs call (already done in prePatch hook)
Address lints from nixpkgs-hammer
Reformat with nixfmt-rfc-style
Migrate to pkgs/by-name

Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[x] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 321858 run on x86_64-darwin 1

2 packages built:

convmv
convmv.man

Result of nixpkgs-review pr 321858 run on aarch64-darwin 1

2 packages built:

convmv
convmv.man

@ofborg build convmv

Result of nixpkgs-review pr 321858 run on x86_64-darwin 1

2 packages built:

convmv
convmv.man


[UI Tests]driver config / start failed chrome server returned empty list from localhost:(port) when run tests parallel on Native Chrome in Karate UI

Karate Version: 1.2.0.RC6
Browser Type : Native chrome
OS: Windows 10
I am running my tests in parallel in headless mode on Chrome native browser on my local machine. It passes some of the tests but most of the tests fails because of  "driver config / start failed chrome server returned empty list from localhost:(port)" this error. I tried after killing all the chrome instances but no luck.
Stack Trace:
14:55:49.885 [pool-1-thread-5] ERROR com.intuit.karate - driver config / start failed: chrome server returned empty list from http://localhost:55157, options: {type=chrome, headless=true, target=null}
java.lang.RuntimeException: chrome server returned empty list from http://localhost:55157
at com.intuit.karate.driver.chrome.Chrome.start(Chrome.java:82)
at com.intuit.karate.driver.DriverOptions.start(DriverOptions.java:316)
at com.intuit.karate.core.ScenarioEngine.driver(ScenarioEngine.java:861)
at com.intuit.karate.ScenarioActions.driver(ScenarioActions.java:414)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
at java.base/java.lang.reflect.Method.invoke(Method.java:577)
at com.intuit.karate.core.StepRuntime.execute(StepRuntime.java:296)
at com.intuit.karate.core.ScenarioRuntime.execute(ScenarioRuntime.java:486)
at com.intuit.karate.core.ScenarioRuntime.run(ScenarioRuntime.java:429)
at com.intuit.karate.core.FeatureRuntime.processScenario(FeatureRuntime.java:182)
at com.intuit.karate.core.FeatureRuntime.access$000(FeatureRuntime.java:44)
at com.intuit.karate.core.FeatureRuntime$1.process(FeatureRuntime.java:123)
at com.intuit.karate.core.FeatureRuntime$1.process(FeatureRuntime.java:119)
at com.intuit.karate.core.ParallelProcessor.lambda$toRunnable$0(ParallelProcessor.java:59)
at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:833)
14:55:49.887 [pool-1-thread-5] ERROR com.intuit.karate - classpath:examples/googleSearchInHeadless.feature:8

driver 'https://www.google.com/'
driver config / start failed: chrome server returned empty list from http://localhost:55157, options: {type=chrome, headless=true, target=null}
classpath:examples/googleSearchInHeadless.feature:8

Here I am attaching my project for your reference.
Thank you in Advance
karate-example.zip
e

immediately closing because you haven't followed the instructions, read them please: https://github.com/karatelabs/karate/wiki/How-to-Submit-an-Issue
that said, this is unlikely to be solved by anyone else, you need to figure it out. running tests on local machines is hugely problematic because of such issues, so for proper CI runs, use the docker option:
https://stackoverflow.com/a/62325328/143475
https://stackoverflow.com/a/66005331/143475
https://stackoverflow.com/q/66273843/143475


Cleanup unneeded and suspicious overrides in rook operator

Remove overrides for:

cephcsi image
csiaddon sidecar image

Both changes were copied from
https://github.com/RamenDR/ramen/blob/5b80317c82cb484f6a639e24967967adb38d708d/hack/minikube-rook-setup.sh#L154
Relevant historic changes:

https://github.com/RamenDR/ramen/commit/63728c20
https://github.com/RamenDR/ramen/commit/3d6e9a47

Tested with rook.yaml:
$ drenv start envs/rook.yaml
2023-11-06 20:40:37,281 INFO    [rook] Starting environment
2023-11-06 20:40:37,408 INFO    [dr1] Starting minikube cluster
2023-11-06 20:40:38,467 INFO    [dr2] Starting minikube cluster
2023-11-06 20:41:33,045 INFO    [dr1] Cluster started in 55.64 seconds
2023-11-06 20:41:33,046 INFO    [dr1/0] Running addons/rook-operator/start
2023-11-06 20:41:33,048 INFO    [dr1/1] Running addons/csi-addons/start
2023-11-06 20:42:05,170 INFO    [dr2] Cluster started in 86.70 seconds
2023-11-06 20:42:05,171 INFO    [dr2/0] Running addons/rook-operator/start
2023-11-06 20:42:05,172 INFO    [dr2/1] Running addons/csi-addons/start
2023-11-06 20:42:13,806 INFO    [dr1/1] addons/csi-addons/start completed in 40.76 seconds
2023-11-06 20:42:18,670 INFO    [dr1/0] addons/rook-operator/start completed in 45.62 seconds
2023-11-06 20:42:18,671 INFO    [dr1/0] Running addons/rook-cluster/start
2023-11-06 20:42:35,789 INFO    [dr2/1] addons/csi-addons/start completed in 30.62 seconds
2023-11-06 20:42:51,857 INFO    [dr2/0] addons/rook-operator/start completed in 46.69 seconds
2023-11-06 20:42:51,857 INFO    [dr2/0] Running addons/rook-cluster/start
2023-11-06 20:45:10,317 INFO    [dr2/0] addons/rook-cluster/start completed in 138.46 seconds
2023-11-06 20:45:10,317 INFO    [dr2/0] Running addons/rook-pool/start
2023-11-06 20:45:11,698 INFO    [dr1/0] addons/rook-cluster/start completed in 173.03 seconds
2023-11-06 20:45:11,698 INFO    [dr1/0] Running addons/rook-pool/start
2023-11-06 20:45:37,551 INFO    [dr1/0] addons/rook-pool/start completed in 25.85 seconds
2023-11-06 20:45:37,551 INFO    [dr1/0] Running addons/rook-toolbox/start
2023-11-06 20:45:39,613 INFO    [dr2/0] addons/rook-pool/start completed in 29.30 seconds
2023-11-06 20:45:39,613 INFO    [dr2/0] Running addons/rook-toolbox/start
2023-11-06 20:46:22,570 INFO    [dr1/0] addons/rook-toolbox/start completed in 45.02 seconds
2023-11-06 20:46:24,925 INFO    [dr2/0] addons/rook-toolbox/start completed in 45.31 seconds
2023-11-06 20:46:24,927 INFO    [rook/0] Running addons/rbd-mirror/start
2023-11-06 20:47:43,965 INFO    [rook/0] addons/rbd-mirror/start completed in 79.04 seconds
2023-11-06 20:47:43,965 INFO    [rook/0] Running addons/rbd-mirror/test
2023-11-06 20:48:03,739 INFO    [rook/0] addons/rbd-mirror/test completed in 19.77 seconds
2023-11-06 20:48:03,739 INFO    [rook] Environment started in 446.46 seconds

Tested also with regional-dr setup, self tests work but we never get to the first replication:
$ test/basic-test/run $env
2023-11-06 21:29:44,554 INFO    [deploy] Deploying application
2023-11-06 21:29:44,555 INFO    [deploy] Deploying channel
2023-11-06 21:29:46,740 INFO    [deploy] Deploying subscription based application
2023-11-06 21:29:49,146 INFO    [deploy] Waiting for 'placement.cluster.open-cluster-management.io/busybox-placement' decisions
2023-11-06 21:29:49,527 INFO    [deploy] Application running on cluster 'dr1'
2023-11-06 21:29:49,760 INFO    [enable-dr] Enable DR
2023-11-06 21:29:49,887 INFO    [enable-dr] Disabling OCM scheduling for 'placement.cluster.open-cluster-management.io/busybox-placement'
2023-11-06 21:29:50,172 INFO    [enable-dr] Waiting for 'placement.cluster.open-cluster-management.io/busybox-placement' decisions
2023-11-06 21:29:50,982 INFO    [enable-dr] waiting for namespace busybox-sample
2023-11-06 21:29:51,264 INFO    [enable-dr] Waiting until 'drplacementcontrol.ramendr.openshift.io/busybox-drpc' reports status
2023-11-06 21:29:51,823 INFO    [enable-dr] Waiting for 'drplacementcontrol.ramendr.openshift.io/busybox-drpc' Available condition
2023-11-06 21:29:52,065 INFO    [enable-dr] Waiting for 'drplacementcontrol.ramendr.openshift.io/busybox-drpc' PeerReady condition
2023-11-06 21:29:52,315 INFO    [enable-dr] Waiting for 'drplacementcontrol.ramendr.openshift.io/busybox-drpc' first replication
2023-11-06 21:34:52,498 ERROR   [enable-dr] test failed
Traceback (most recent call last):
  File "/home/nsoffer/src/ramen/test/basic-test/enable-dr", line 14, in <module>
    test.wait_until_drpc_is_stable()
  File "/home/nsoffer/src/ramen/test/drenv/test.py", line 362, in wait_until_drpc_is_stable
    drenv.wait_for(
  File "/home/nsoffer/src/ramen/test/drenv/__init__.py", line 52, in wait_for
    raise RuntimeError(
RuntimeError: Timeout waiting for 'drplacementcontrol.ramendr.openshift.io/busybox-drpc' output='jsonpath={.status.lastGroupSyncTime}' namespace='busybox-sample' profile='hub' timeout=300

May not be related to this change, need to test with older ramen version.

Tested with basic-test after adding recipe CRD to both clusters manually:
$ kubectl apply -f https://raw.githubusercontent.com/RamenDR/recipe/main/config/crd/bases/ramendr.openshift.io_recipes.yaml --context dr1
customresourcedefinition.apiextensions.k8s.io/recipes.ramendr.openshift.io created
$ kubectl apply -f https://raw.githubusercontent.com/RamenDR/recipe/main/config/crd/bases/ramendr.openshift.io_recipes.yaml --context dr2
customresourcedefinition.apiextensions.k8s.io/recipes.ramendr.openshift.io created

$ test/basic-test/run $env
2023-11-06 22:05:40,132 INFO    [deploy] Deploying application
2023-11-06 22:05:40,133 INFO    [deploy] Deploying channel
2023-11-06 22:05:42,187 INFO    [deploy] Deploying subscription based application
2023-11-06 22:05:44,582 INFO    [deploy] Waiting for 'placement.cluster.open-cluster-management.io/busybox-placement' decisions
2023-11-06 22:05:44,983 INFO    [deploy] Application running on cluster 'dr1'
2023-11-06 22:05:45,185 INFO    [enable-dr] Enable DR
2023-11-06 22:05:45,310 INFO    [enable-dr] Disabling OCM scheduling for 'placement.cluster.open-cluster-management.io/busybox-placement'
2023-11-06 22:05:45,638 INFO    [enable-dr] Waiting for 'placement.cluster.open-cluster-management.io/busybox-placement' decisions
2023-11-06 22:05:46,418 INFO    [enable-dr] waiting for namespace busybox-sample
2023-11-06 22:05:46,683 INFO    [enable-dr] Waiting until 'drplacementcontrol.ramendr.openshift.io/busybox-drpc' reports status
2023-11-06 22:05:46,989 INFO    [enable-dr] Waiting for 'drplacementcontrol.ramendr.openshift.io/busybox-drpc' Available condition
2023-11-06 22:05:47,241 INFO    [enable-dr] Waiting for 'drplacementcontrol.ramendr.openshift.io/busybox-drpc' PeerReady condition
2023-11-06 22:05:47,482 INFO    [enable-dr] Waiting for 'drplacementcontrol.ramendr.openshift.io/busybox-drpc' first replication
2023-11-06 22:05:47,629 INFO    [enable-dr] DR enabled
2023-11-06 22:05:47,805 INFO    [failover] Fail over application
2023-11-06 22:05:47,955 INFO    [failover] Waiting for 'drplacementcontrol.ramendr.openshift.io/busybox-drpc' Available condition
2023-11-06 22:05:48,197 INFO    [failover] Waiting for 'drplacementcontrol.ramendr.openshift.io/busybox-drpc' PeerReady condition
2023-11-06 22:05:48,441 INFO    [failover] Waiting for 'drplacementcontrol.ramendr.openshift.io/busybox-drpc' first replication
2023-11-06 22:05:48,703 INFO    [failover] Waiting for 'placement.cluster.open-cluster-management.io/busybox-placement' decisions
2023-11-06 22:05:49,192 INFO    [failover] Starting failover for 'drplacementcontrol.ramendr.openshift.io/busybox-drpc' to cluster 'dr2'
2023-11-06 22:05:49,524 INFO    [failover] Waiting for 'drplacementcontrol.ramendr.openshift.io/busybox-drpc' Available condition
2023-11-06 22:09:12,398 INFO    [failover] Waiting for 'drplacementcontrol.ramendr.openshift.io/busybox-drpc' PeerReady condition
2023-11-06 22:12:13,492 INFO    [failover] Waiting for 'drplacementcontrol.ramendr.openshift.io/busybox-drpc' first replication
2023-11-06 22:12:13,629 INFO    [failover] Application was failed over
2023-11-06 22:12:13,812 INFO    [relocate] Relocate application
2023-11-06 22:12:13,918 INFO    [relocate] Waiting for 'drplacementcontrol.ramendr.openshift.io/busybox-drpc' Available condition
2023-11-06 22:12:14,166 INFO    [relocate] Waiting for 'drplacementcontrol.ramendr.openshift.io/busybox-drpc' PeerReady condition
2023-11-06 22:12:14,451 INFO    [relocate] Waiting for 'drplacementcontrol.ramendr.openshift.io/busybox-drpc' first replication
2023-11-06 22:12:14,761 INFO    [relocate] Waiting for 'placement.cluster.open-cluster-management.io/busybox-placement' decisions
2023-11-06 22:12:15,270 INFO    [relocate] Starting relocate for 'drplacementcontrol.ramendr.openshift.io/busybox-drpc' to cluster 'dr1'
2023-11-06 22:12:15,611 INFO    [relocate] Waiting for 'drplacementcontrol.ramendr.openshift.io/busybox-drpc' phase 'Relocated'
2023-11-06 22:14:44,051 INFO    [relocate] Waiting for 'drplacementcontrol.ramendr.openshift.io/busybox-drpc' Available condition
2023-11-06 22:14:44,306 INFO    [relocate] Waiting for 'drplacementcontrol.ramendr.openshift.io/busybox-drpc' PeerReady condition
2023-11-06 22:15:12,725 INFO    [relocate] Waiting for 'drplacementcontrol.ramendr.openshift.io/busybox-drpc' first replication
2023-11-06 22:15:12,870 INFO    [relocate] Application was relocated
2023-11-06 22:15:13,060 INFO    [disable-dr] Disable DR
2023-11-06 22:15:13,220 INFO    [disable-dr] Deleting 'drplacementcontrol.ramendr.openshift.io/busybox-drpc'
2023-11-06 22:15:43,416 INFO    [disable-dr] Enabling OCM scheduling for 'placement.cluster.open-cluster-management.io/busybox-placement'
2023-11-06 22:15:43,593 INFO    [disable-dr] DR was disabled
2023-11-06 22:15:43,805 INFO    [undeploy] Deleting busybox example application
2023-11-06 22:15:43,805 INFO    [undeploy] Undeploying channel
2023-11-06 22:15:51,686 INFO    [undeploy] Undeploying subscription based application
2023-11-06 22:15:59,618 INFO    [undeploy] Application was undeployed successfully


the ports are not active even though they should be

This shows the same after page refresh

https://studio.record-evolution.com/en/marko/swarms/Logistikum/device/MIR_AGV

restarting the apps helped


No installation documentation

There is not documentation on GitHub README or the documentation website. Although it is very easy, it would be nice for beginners to have that documentation.

@necmettin Have you added the documentation for your suggestion in a pull request?

@surfer190 there are 13 pull requests not cared for, no use creating another one..


feat(backend):add Live account query and fix new create account query

fix #586

@icerove given the refactoring, it is hard to follow what was added. Please, provide me with some entries that needs to be reviewed. It seems that most of the PR is just reorganizing things (btw, given you created groups, it might be better to create a new folder, and split the file into smaller files just like you separated them into groups).

@frol
give some comments for the important functions


cleanup: slightly smarter release notes

The instruction update and script updates should probably be split into separate PRs, but eh.

Only include handwritten libraries in the sections
Only print changes that affect all libraries in "Common Libraries"
Do not list storage-only changes under "Common Libraries"

This is the change from mapfile to IFS
Credit to @devbww for this fix

Pre-change:
### [Assured Workloads](/google/cloud/assuredworkloads/README.md)

- fix: export headers with top-level Bazel targets ([#12762](https://github.com/googleapis/google-cloud-cpp/pull/12762))
- perf(otel): cache propagator in gRPC tracing stubs ([#12642](https://github.com/googleapis/google-cloud-cpp/pull/12642))
- feat(generator): configurable x-goog-api-client  ([#12571](https://github.com/googleapis/google-cloud-cpp/pull/12571))
-  fix(internal): change url_encode include from .h to .cc ([#12547](https://github.com/googleapis/google-cloud-cpp/pull/12547))
- fix: add implicit routing in GAPICs ([#12544](https://github.com/googleapis/google-cloud-cpp/pull/12544))

### [Batch](/google/cloud/batch/README.md)

- fix: export headers with top-level Bazel targets ([#12762](https://github.com/googleapis/google-cloud-cpp/pull/12762))
- perf(otel): cache propagator in gRPC tracing stubs ([#12642](https://github.com/googleapis/google-cloud-cpp/pull/12642))
- feat(generator): configurable x-goog-api-client  ([#12571](https://github.com/googleapis/google-cloud-cpp/pull/12571))
-  fix(internal): change url_encode include from .h to .cc ([#12547](https://github.com/googleapis/google-cloud-cpp/pull/12547))
- fix: add implicit routing in GAPICs ([#12544](https://github.com/googleapis/google-cloud-cpp/pull/12544))

### [Beyond Corp](/google/cloud/beyondcorp/README.md)

- fix: export headers with top-level Bazel targets ([#12762](https://github.com/googleapis/google-cloud-cpp/pull/12762))
- perf(otel): cache propagator in gRPC tracing stubs ([#12642](https://github.com/googleapis/google-cloud-cpp/pull/12642))
- feat(generator): configurable x-goog-api-client  ([#12571](https://github.com/googleapis/google-cloud-cpp/pull/12571))
-  fix(internal): change url_encode include from .h to .cc ([#12547](https://github.com/googleapis/google-cloud-cpp/pull/12547))
- fix: add implicit routing in GAPICs ([#12544](https://github.com/googleapis/google-cloud-cpp/pull/12544))

### [BigQuery](/google/cloud/bigquery/README.md)

- fix: export headers with top-level Bazel targets ([#12762](https://github.com/googleapis/google-cloud-cpp/pull/12762))
- fix(bigquery): Job Library fixes for InsertJob api ([#12746](https://github.com/googleapis/google-cloud-cpp/pull/12746))
- perf(otel): cache propagator in gRPC tracing stubs ([#12642](https://github.com/googleapis/google-cloud-cpp/pull/12642))
- feat(generator): configurable x-goog-api-client  ([#12571](https://github.com/googleapis/google-cloud-cpp/pull/12571))
-  fix(internal): change url_encode include from .h to .cc ([#12547](https://github.com/googleapis/google-cloud-cpp/pull/12547))
- fix: add implicit routing in GAPICs ([#12544](https://github.com/googleapis/google-cloud-cpp/pull/12544))

### [Bigtable](/google/cloud/bigtable/README.md)

- fix: export headers with top-level Bazel targets ([#12762](https://github.com/googleapis/google-cloud-cpp/pull/12762))
- fix(bigtable): the Location ctor takes project ids ([#12675](https://github.com/googleapis/google-cloud-cpp/pull/12675))
- perf(otel): cache propagator in gRPC tracing stubs ([#12642](https://github.com/googleapis/google-cloud-cpp/pull/12642))
- feat(generator): configurable x-goog-api-client  ([#12571](https://github.com/googleapis/google-cloud-cpp/pull/12571))
-  fix(internal): change url_encode include from .h to .cc ([#12547](https://github.com/googleapis/google-cloud-cpp/pull/12547))
- fix: add implicit routing in GAPICs ([#12544](https://github.com/googleapis/google-cloud-cpp/pull/12544))

### [Cloud Asset](/google/cloud/asset/README.md)

- fix: export headers with top-level Bazel targets ([#12762](https://github.com/googleapis/google-cloud-cpp/pull/12762))
- perf(otel): cache propagator in gRPC tracing stubs ([#12642](https://github.com/googleapis/google-cloud-cpp/pull/12642))
- feat(generator): configurable x-goog-api-client  ([#12571](https://github.com/googleapis/google-cloud-cpp/pull/12571))
-  fix(internal): change url_encode include from .h to .cc ([#12547](https://github.com/googleapis/google-cloud-cpp/pull/12547))
- fix: add implicit routing in GAPICs ([#12544](https://github.com/googleapis/google-cloud-cpp/pull/12544))

### [Cloud Run](/google/cloud/run/README.md)

- fix: export headers with top-level Bazel targets ([#12762](https://github.com/googleapis/google-cloud-cpp/pull/12762))
- perf(otel): cache propagator in gRPC tracing stubs ([#12642](https://github.com/googleapis/google-cloud-cpp/pull/12642))
- feat(generator): configurable x-goog-api-client  ([#12571](https://github.com/googleapis/google-cloud-cpp/pull/12571))
-  fix(internal): change url_encode include from .h to .cc ([#12547](https://github.com/googleapis/google-cloud-cpp/pull/12547))
- fix: add implicit routing in GAPICs ([#12544](https://github.com/googleapis/google-cloud-cpp/pull/12544))

### [IAM](/google/cloud/iam/README.md)

- fix: export headers with top-level Bazel targets ([#12762](https://github.com/googleapis/google-cloud-cpp/pull/12762))
- perf(otel): cache propagator in gRPC tracing stubs ([#12642](https://github.com/googleapis/google-cloud-cpp/pull/12642))
- feat(generator): configurable x-goog-api-client  ([#12571](https://github.com/googleapis/google-cloud-cpp/pull/12571))
-  fix(internal): change url_encode include from .h to .cc ([#12547](https://github.com/googleapis/google-cloud-cpp/pull/12547))
- fix: add implicit routing in GAPICs ([#12544](https://github.com/googleapis/google-cloud-cpp/pull/12544))

### [Pub/Sub](/google/cloud/pubsub/README.md)

- fix: export headers with top-level Bazel targets ([#12762](https://github.com/googleapis/google-cloud-cpp/pull/12762))
- pubsub: add message_batch.h to build ([#12744](https://github.com/googleapis/google-cloud-cpp/pull/12744))
- perf(otel): cache propagator in gRPC tracing stubs ([#12642](https://github.com/googleapis/google-cloud-cpp/pull/12642))
- fix(pubsub): change size_t -> int for otel attribute ([#12633](https://github.com/googleapis/google-cloud-cpp/pull/12633))
- feat(generator): configurable x-goog-api-client  ([#12571](https://github.com/googleapis/google-cloud-cpp/pull/12571))
-  fix(internal): change url_encode include from .h to .cc ([#12547](https://github.com/googleapis/google-cloud-cpp/pull/12547))
- fix: add implicit routing in GAPICs ([#12544](https://github.com/googleapis/google-cloud-cpp/pull/12544))

### [Spanner](/google/cloud/spanner/README.md)

- fix: export headers with top-level Bazel targets ([#12762](https://github.com/googleapis/google-cloud-cpp/pull/12762))
- fix: restore credential logic ([#12690](https://github.com/googleapis/google-cloud-cpp/pull/12690))
- docs(spanner): set max_delay to 16s ([#12680](https://github.com/googleapis/google-cloud-cpp/pull/12680))
- perf(otel): cache propagator in gRPC tracing stubs ([#12642](https://github.com/googleapis/google-cloud-cpp/pull/12642))
- feat(generator): configurable x-goog-api-client  ([#12571](https://github.com/googleapis/google-cloud-cpp/pull/12571))
-  fix(internal): change url_encode include from .h to .cc ([#12547](https://github.com/googleapis/google-cloud-cpp/pull/12547))
- fix: add implicit routing in GAPICs ([#12544](https://github.com/googleapis/google-cloud-cpp/pull/12544))

### [Storage](/google/cloud/storage/README.md)

- fix: export headers with top-level Bazel targets ([#12762](https://github.com/googleapis/google-cloud-cpp/pull/12762))
- fix(GCS+gRPC): race condition in async `Insert()` ([#12715](https://github.com/googleapis/google-cloud-cpp/pull/12715))
- docs(GCS+gRPC): additional `ReadObject()` example ([#12695](https://github.com/googleapis/google-cloud-cpp/pull/12695))
- fix: restore credential logic ([#12690](https://github.com/googleapis/google-cloud-cpp/pull/12690))
- fix(storage): trace auth when default credentials are assumed ([#12672](https://github.com/googleapis/google-cloud-cpp/pull/12672))
- perf(otel): cache propagator in gRPC tracing stubs ([#12642](https://github.com/googleapis/google-cloud-cpp/pull/12642))
- docs(storage): more on InsertObject vs. WriteObject ([#12577](https://github.com/googleapis/google-cloud-cpp/pull/12577))
- feat(generator): configurable x-goog-api-client  ([#12571](https://github.com/googleapis/google-cloud-cpp/pull/12571))
-  fix(internal): change url_encode include from .h to .cc ([#12547](https://github.com/googleapis/google-cloud-cpp/pull/12547))
- fix: add implicit routing in GAPICs ([#12544](https://github.com/googleapis/google-cloud-cpp/pull/12544))

### [Common Libraries](/google/cloud/README.md)

- feat(common): new `*Option` to configure HTTP proxy ([#12766](https://github.com/googleapis/google-cloud-cpp/pull/12766))
- doc(otel): update link ([#12768](https://github.com/googleapis/google-cloud-cpp/pull/12768))
- doc(compute): add create disk and delete disk samples ([#12749](https://github.com/googleapis/google-cloud-cpp/pull/12749))
- fix: export headers with top-level Bazel targets ([#12762](https://github.com/googleapis/google-cloud-cpp/pull/12762))
- doc(compute): update CHANGELOG and other docs for GA ([#12756](https://github.com/googleapis/google-cloud-cpp/pull/12756))
- feat(oauth2): add quickstart, README, etc. ([#12754](https://github.com/googleapis/google-cloud-cpp/pull/12754))
- doc(otel): GA ([#12748](https://github.com/googleapis/google-cloud-cpp/pull/12748))
- feat(otel): GA for cmake ([#12735](https://github.com/googleapis/google-cloud-cpp/pull/12735))
- feat(otel): GA bazel ([#12732](https://github.com/googleapis/google-cloud-cpp/pull/12732))
- feat(otel): promote `OpenTelemetryTracingOption` to GA ([#12728](https://github.com/googleapis/google-cloud-cpp/pull/12728))
- cleanup(otel)!: Drop `Options` from resource detector API. ([#12730](https://github.com/googleapis/google-cloud-cpp/pull/12730))
- fix: gRPC auth logging enabled by "auth" ([#12702](https://github.com/googleapis/google-cloud-cpp/pull/12702))
- fix(GCS+gRPC): race condition in async `Insert()` ([#12715](https://github.com/googleapis/google-cloud-cpp/pull/12715))
- doc(compute): add repo-metadata.json ([#12696](https://github.com/googleapis/google-cloud-cpp/pull/12696))
- docs(GCS+gRPC): additional `ReadObject()` example ([#12695](https://github.com/googleapis/google-cloud-cpp/pull/12695))
- compute: generate as non-experimental ([#12669](https://github.com/googleapis/google-cloud-cpp/pull/12669))
- fix: restore credential logic ([#12690](https://github.com/googleapis/google-cloud-cpp/pull/12690))
- fix(storage): trace auth when default credentials are assumed ([#12672](https://github.com/googleapis/google-cloud-cpp/pull/12672))
- doc(otel): clarify when `OpenTelemetryTracingOption` applies ([#12670](https://github.com/googleapis/google-cloud-cpp/pull/12670))
- perf(otel): cache propagator in gRPC tracing stubs ([#12642](https://github.com/googleapis/google-cloud-cpp/pull/12642))
- docs(storage): more on InsertObject vs. WriteObject ([#12577](https://github.com/googleapis/google-cloud-cpp/pull/12577))
- feat(generator): generate shortname from api id ([#12575](https://github.com/googleapis/google-cloud-cpp/pull/12575))
- feat(generator): configurable x-goog-api-client  ([#12571](https://github.com/googleapis/google-cloud-cpp/pull/12571))
- fix(internal): add url encoding for minimal iam creds ([#12558](https://github.com/googleapis/google-cloud-cpp/pull/12558))
- feat(netapp): generate library ([#12551](https://github.com/googleapis/google-cloud-cpp/pull/12551))
- feat(config): generate library ([#12545](https://github.com/googleapis/google-cloud-cpp/pull/12545))
- fix(discoveryengine): regenerate with latest generator ([#12549](https://github.com/googleapis/google-cloud-cpp/pull/12549))
-  fix(internal): change url_encode include from .h to .cc ([#12547](https://github.com/googleapis/google-cloud-cpp/pull/12547))
- fix(discoveryengine): update generated files ([#12546](https://github.com/googleapis/google-cloud-cpp/pull/12546))
- fix: add implicit routing in GAPICs ([#12544](https://github.com/googleapis/google-cloud-cpp/pull/12544))
- feat(discoveryengine): new *Client ([#12543](https://github.com/googleapis/google-cloud-cpp/pull/12543))
- doc(generator): add documentation links to discovery doc originated method headers ([#12534](https://github.com/googleapis/google-cloud-cpp/pull/12534))

Post-change:
### [BigQuery](/google/cloud/bigquery/README.md)

- fix(bigquery): Job Library fixes for InsertJob api ([#12746](https://github.com/googleapis/google-cloud-cpp/pull/12746))

### [Bigtable](/google/cloud/bigtable/README.md)

- fix(bigtable): the Location ctor takes project ids ([#12675](https://github.com/googleapis/google-cloud-cpp/pull/12675))

### [OAuth2](/google/cloud/oauth2/README.md)

- feat(oauth2): add quickstart, README, etc. ([#12754](https://github.com/googleapis/google-cloud-cpp/pull/12754))

### [OpenTelemetry](/google/cloud/opentelemetry/README.md)

- doc(otel): update link ([#12768](https://github.com/googleapis/google-cloud-cpp/pull/12768))
- doc(otel): GA ([#12748](https://github.com/googleapis/google-cloud-cpp/pull/12748))
- feat(otel): GA for cmake ([#12735](https://github.com/googleapis/google-cloud-cpp/pull/12735))
- feat(otel): GA bazel ([#12732](https://github.com/googleapis/google-cloud-cpp/pull/12732))
- feat(otel): promote `OpenTelemetryTracingOption` to GA ([#12728](https://github.com/googleapis/google-cloud-cpp/pull/12728))
- cleanup(otel)!: Drop `Options` from resource detector API. ([#12730](https://github.com/googleapis/google-cloud-cpp/pull/12730))

### [Pub/Sub](/google/cloud/pubsub/README.md)

- pubsub: add message_batch.h to build ([#12744](https://github.com/googleapis/google-cloud-cpp/pull/12744))
- fix(pubsub): change size_t -> int for otel attribute ([#12633](https://github.com/googleapis/google-cloud-cpp/pull/12633))

### [Spanner](/google/cloud/spanner/README.md)

- fix: restore credential logic ([#12690](https://github.com/googleapis/google-cloud-cpp/pull/12690))
- docs(spanner): set max_delay to 16s ([#12680](https://github.com/googleapis/google-cloud-cpp/pull/12680))

### [Storage](/google/cloud/storage/README.md)

- fix(GCS+gRPC): race condition in async `Insert()` ([#12715](https://github.com/googleapis/google-cloud-cpp/pull/12715))
- docs(GCS+gRPC): additional `ReadObject()` example ([#12695](https://github.com/googleapis/google-cloud-cpp/pull/12695))
- fix: restore credential logic ([#12690](https://github.com/googleapis/google-cloud-cpp/pull/12690))
- fix(storage): trace auth when default credentials are assumed ([#12672](https://github.com/googleapis/google-cloud-cpp/pull/12672))
- docs(storage): more on InsertObject vs. WriteObject ([#12577](https://github.com/googleapis/google-cloud-cpp/pull/12577))

### [Common Libraries](/google/cloud/README.md)

- feat(common): new `*Option` to configure HTTP proxy ([#12766](https://github.com/googleapis/google-cloud-cpp/pull/12766))
- doc(compute): add create disk and delete disk samples ([#12749](https://github.com/googleapis/google-cloud-cpp/pull/12749))
- fix: export headers with top-level Bazel targets ([#12762](https://github.com/googleapis/google-cloud-cpp/pull/12762))
- doc(compute): update CHANGELOG and other docs for GA ([#12756](https://github.com/googleapis/google-cloud-cpp/pull/12756))
- feat(oauth2): add quickstart, README, etc. ([#12754](https://github.com/googleapis/google-cloud-cpp/pull/12754))
- feat(otel): GA for cmake ([#12735](https://github.com/googleapis/google-cloud-cpp/pull/12735))
- feat(otel): GA bazel ([#12732](https://github.com/googleapis/google-cloud-cpp/pull/12732))
- feat(otel): promote `OpenTelemetryTracingOption` to GA ([#12728](https://github.com/googleapis/google-cloud-cpp/pull/12728))
- fix: gRPC auth logging enabled by "auth" ([#12702](https://github.com/googleapis/google-cloud-cpp/pull/12702))
- doc(compute): add repo-metadata.json ([#12696](https://github.com/googleapis/google-cloud-cpp/pull/12696))
- compute: generate as non-experimental ([#12669](https://github.com/googleapis/google-cloud-cpp/pull/12669))
- fix: restore credential logic ([#12690](https://github.com/googleapis/google-cloud-cpp/pull/12690))
- doc(otel): clarify when `OpenTelemetryTracingOption` applies ([#12670](https://github.com/googleapis/google-cloud-cpp/pull/12670))
- perf(otel): cache propagator in gRPC tracing stubs ([#12642](https://github.com/googleapis/google-cloud-cpp/pull/12642))
- feat(generator): generate shortname from api id ([#12575](https://github.com/googleapis/google-cloud-cpp/pull/12575))
- feat(generator): configurable x-goog-api-client  ([#12571](https://github.com/googleapis/google-cloud-cpp/pull/12571))
- fix(internal): add url encoding for minimal iam creds ([#12558](https://github.com/googleapis/google-cloud-cpp/pull/12558))
- feat(netapp): generate library ([#12551](https://github.com/googleapis/google-cloud-cpp/pull/12551))
- feat(config): generate library ([#12545](https://github.com/googleapis/google-cloud-cpp/pull/12545))
- fix(discoveryengine): regenerate with latest generator ([#12549](https://github.com/googleapis/google-cloud-cpp/pull/12549))
-  fix(internal): change url_encode include from .h to .cc ([#12547](https://github.com/googleapis/google-cloud-cpp/pull/12547))
- fix(discoveryengine): update generated files ([#12546](https://github.com/googleapis/google-cloud-cpp/pull/12546))
- fix: add implicit routing in GAPICs ([#12544](https://github.com/googleapis/google-cloud-cpp/pull/12544))
- feat(discoveryengine): new *Client ([#12543](https://github.com/googleapis/google-cloud-cpp/pull/12543))
- doc(generator): add documentation links to discovery doc originated method headers ([#12534](https://github.com/googleapis/google-cloud-cpp/pull/12534))

This change is

Argh.  I try to never comment of a draft PR, but failed to notice this time.  Sorry.

Argh. I try to never comment on a draft PR, but failed to notice this time. Sorry.

No worries. It was ready for review as soon as checkers-pr passed.


Greet.GreeterClient(channel) should be Greeter.GreeterClient(channel)

[Enter feedback here]
In this sentence,
"For example, a service called Greeter generates a GreeterClient type with methods to call the service."
but in code,
var client = new Greet.GreeterClient(channel);
so Greet.GreeterClient(channel) should be Greeter.GreeterClient(channel)
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3a7ec3c3-918c-6ffd-1ac0-4f88b89d9295
Version Independent ID: 1c1f72f1-3d5d-3397-c17d-1889dbae6fee
Content: Call gRPC services with the .NET client
Content Source: aspnetcore/grpc/client.md
Product: aspnet-core
Technology: aspnetcore-grpc
GitHub Login: @JamesNK
Microsoft Alias: jamesnk

Thanks for the report, @felinepunch. It seems that given so much of the topic uses Greet that the service should be called Greet to match rather than change all of the code blocks down the topic. I'll do that on the PR and ping James for review.

Greet is the name of the package that the Greeter service is in.


Add support for command GETSET

Add support for the GETSET command in DiceDB similar to the GETSET command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.
Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.
For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

@arpitbbhayani would like to work on this.
However looks like GETSET is deprecated now in favour of SET with the GET argument.
Link in description points to COMMAND LIST, can you please confirm once?

@lucifercr07 but we should still implement it to maintain full compatability.

@lucifercr07 do you have the bandwidth to actively work on this issue?

if anyone is not working can you pls assign it to me?

@JyotinderSingh have been working on this, will raise a PR by this week.

PR raised: https://github.com/DiceDB/dice/pull/377
@JyotinderSingh please review