msgpack_serialize does not work with FrozenDict PyTree

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 20.04
Flax, jax, jaxlib versions (obtain with pip show flax jax jaxlib: jax 0.3.1, jaxlib 0.3.0+cuda11.cudnn82, flax 0.4.0
Python version: 3.8.10
GPU/TPU model and memory:
CUDA version (if applicable):

Hey folks, I quickly wanted to save some flax.linen module params to disk. Because of https://github.com/google/flax/issues/1924 I am not using the checkpoints module, but instead I'm using the serialization module.
When trying to serialize my flax.linen module's params (FrozenDict) I get an error (see below). Unfreezing the FrozenDict before serializing works as a workaround. See self-contained reproducible example below.
The documentation makes it sound like it should work with FrozenDicts just as fine.
https://flax.readthedocs.io/en/latest/flax.serialization.html#flax.serialization.msgpack_serialize
>>> import jax
>>> import jax.numpy as jnp
>>> import flax.linen as nn
>>> from flax.serialization import msgpack_serialize, msgpack_restore
>>>
>>> params = nn.Dense(1).init(jax.random.PRNGKey(0), jnp.zeros((1,)))
>>> params
FrozenDict({
    params: {
        kernel: DeviceArray([[-1.4588346]], dtype=float32),
        bias: DeviceArray([0.], dtype=float32),
    },
})
>>>
>>> msgpack_serialize(params)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/python/.local/lib/python3.8/site-packages/flax/serialization.py", line 331, in msgpack_serialize
    return msgpack.packb(pytree, default=_msgpack_ext_pack, strict_types=True)
  File "/home/python/.local/lib/python3.8/site-packages/msgpack/__init__.py", line 35, in packb
    return Packer(**kwargs).pack(o)
  File "msgpack/_packer.pyx", line 294, in msgpack._cmsgpack.Packer.pack
  File "msgpack/_packer.pyx", line 300, in msgpack._cmsgpack.Packer.pack
  File "msgpack/_packer.pyx", line 297, in msgpack._cmsgpack.Packer.pack
  File "msgpack/_packer.pyx", line 291, in msgpack._cmsgpack.Packer._pack
TypeError: can not serialize 'FrozenDict' object
>>>
>>> msgpack_serialize(params.unfreeze())  # WORKAROUND
b'\x81\xa6params\x82\xa4bias\xc7\x11\x01\x93\x91\x01\xa7float32\xc4\x04\x00\x00\x00\x00\xa6kernel\xc7\x12\x01\x93\x92\x01\x01\xa7float32\xc4\x04\x18\xbb\xba\xbf'

What you expected to happen:
Serializing params (FrozenDict) works by default, because that is a common use case.
The manual unfreeze() is a workaround for now.

Hey! sorry msgpack_serialize and msgpack_restore are low-level function entrypoints that are only intended to work with native python objects + numpy arrays.  To serialize/restore general things including user-registered types, use serialization.to_bytes and serialization.from_bytes

Awesome, thanks this works! Maybe we should change the docs or even hide the internal functions then.
https://flax.readthedocs.io/en/latest/flax.serialization.html#flax.serialization.msgpack_serialize


Duration typing not accepting string

const period = 'week';
const date = moment().startOf(period);

Argument of type 'string' is not assignable to parameter of type "year" | "years" | "Y" | "quarter" ....
How to bypass this limitation? const date = moment().startOf('week'); doesn't bark.

Define your period type as a UnitOfTime.
const period : UnitOfTime = 'week';
const date = moment().startOf(period);

@mj1856 thanks, is UnitOfTime exported from moment?

Hmmm..  I think you just import moment then qualify the type with the namespace.  Try this:
const period: moment.UnitOfTime = 'week';

I've resorted to using it as such, which seems to work:
import * as moment from 'moment';
import { UnitOfTime } from 'moment';

I think either approach would work, if I'm understanding typescript imports correctly.

import * as moment from 'moment';
let type : moment.UnitOfTime = "week";
Namespace 'moment' has no exported member 'UnitOfTime'.

Urgh... The actual type you want is moment.unitOfTime.StartOf. unitOfTime is a namespace for some unknown reason.
let type: moment.unitOfTime.StartOf = week;
moment().startOf(type);

As far as importing in typescript, you can import types only using the import {<identifiers>} from 'moment' syntax, but moment declares itself as a default export, so you can't use that syntax for importing values, so
So the following will type check fine:
import moment from 'moment';
import {unitOfTime} from 'moment';

let period: string;
moment().startOf(period as unitOfTime.StartOf);

Oh, thank you!


Up dev issue#10388

What is the purpose of the change
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #10414 (bf89e89) into 3.0 (4b55862) will decrease coverage by 0.31%.
The diff coverage is 44.82%.

@@             Coverage Diff              @@
##                3.0   #10414      +/-   ##
============================================
- Coverage     65.66%   65.34%   -0.32%
+ Complexity      319      317       -2
============================================
  Files          1234     1238       +4
  Lines         53916    53908       -8
  Branches       8155     8126      -29
============================================
- Hits          35402    35228     -174
- Misses        14664    14799     +135
- Partials       3850     3881      +31

Impacted Files
Coverage Δ

...e/dubbo/common/concurrent/DiscardOldestPolicy.java
0.00% <0.00%> (ø)

...pache/dubbo/common/concurrent/RejectException.java
25.00% <25.00%> (ø)

...mmon/threadpool/MemorySafeLinkedBlockingQueue.java
48.27% <53.84%> (+9.38%)
:arrow_up:

...rg/apache/dubbo/common/concurrent/AbortPolicy.java
100.00% <100.00%> (ø)

.../apache/dubbo/common/concurrent/DiscardPolicy.java
100.00% <100.00%> (ø)

...dubbo/remoting/zookeeper/ZookeeperTransporter.java
50.00% <0.00%> (-33.34%)
:arrow_down:

...ng/zookeeper/curator5/Curator5ZookeeperClient.java
43.33% <0.00%> (-26.67%)
:arrow_down:

...dubbo/common/status/support/LoadStatusChecker.java
41.66% <0.00%> (-25.00%)
:arrow_down:

...nt/metadata/ServiceInstanceHostPortCustomizer.java
65.78% <0.00%> (-21.06%)
:arrow_down:

...ache/dubbo/remoting/transport/AbstractChannel.java
75.00% <0.00%> (-12.50%)
:arrow_down:

... and 59 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

ok


maybe some bug

hello, thanks your lib ,it work well on mac os, but when i work on centos ,it is worng
(.venv) [root@quant gamefi]# python3.8 -m venv .venv

(.venv) [root@quant gamefi]# python -V
Python 3.8.0a1
(.venv) [root@quant gamefi]# pwd
/home/Code/gamefi
(.venv) [root@quant gamefi]# ls
farmerworld.py
(.venv) [root@quant gamefi]# python farmerworld.py
Traceback (most recent call last):
  File "farmerworld.py", line 5, in <module>
    import eospyo
  File "/home/Code/gamefi/.venv/lib/python3.8/site-packages/eospyo/__init__.py", line 1, in <module>
    from . import exc, types
  File "<fstring>", line 1
    (response=)
             ^
SyntaxError: invalid syntax

i used python venv ,did it not work on venv?

Hello @grassroadsZ
Thanks for the feedback,
It seems that the alpha version of python 3.8 you're using has no support to f-strings equals (example bellow).
But the standard python 3.8 should have. Should work if you upgrade it. Let me know if it doesn't ; )
Python 3.8.0a1 (default, Feb 22 2019, 00:35:00)
[GCC 6.3.0 20170516] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> x = 1
>>> f"{x=}"
  File "<fstring>", line 1
    (x=)
      ^
SyntaxError: invalid syntax

Python 3.8.0 (default, Nov 23 2019, 05:36:56)
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> x = 1
>>> f"{x=}"
'x=1'
>>>


Angular 6 shared assets and fonts

Greetings, we are changing our structure from default angular app to single spa. We inject our current project as a MFE in root config as a default route for now.
The project is using Angular 6 so we build it using single-spa-angular:build without Webpack.
That means that we don't have a webpack_public_path to use AssetURL and Pipe. Also we would like to less on refactoring as much as possible since we have import images in ts, html, scss formats. The same thing is related to sharing fonts.
Question is:
How can we share assets with the least code changes? Or should we just move them to the root config and serve there? Or there are some workarounds?
Libs:

@angular/core version: 6.1.10
single-spa-angular version: 3.6.0

I ain't sure I can answer the question since it's not strictly related to Angular. I should emphasize that single-spa-angular drops support Angular versions that have been deprecated or deprecated long ago. So using Angular 6 is off the supported path. Try re-opening the issue in the single-spa repository, but w/o tying to Angular. The question is more general and might be related to any framework.


Update README.md

add missing articles

Also, the image has a similar problem: instead of "for Polkadot ecosystem" it should be "for the Polkadot ecosystem".


default contrast limits with signed data types

When adding an image, the view is created through
https://github.com/mobie/mobie-utils-python/blob/aa8ddda2b3ce43b0346810fdc4c6133fb7f1b13a/mobie/metadata/view_metadata.py#L339
which does not seem to pass any displaysettings  to get_view and finally get_image_display.
So it seems that independent of the input dtype the contrast limits will fall back to [0,255].
https://github.com/mobie/mobie-utils-python/blob/aa8ddda2b3ce43b0346810fdc4c6133fb7f1b13a/mobie/metadata/view_metadata.py#L20
Ideally these would be set according to the image data type limits. This is especially crucial for signed types.

@martinschorb this is implemented now.


Lauwsj/table improvement

Summary

Resolves #281
Resolves #265

Detail

Provide responsiveness to the table
Refresh the table for each update

Pictures / Gif

Checks

[x] Link PR to issue
[x] Add Reviewer
[x] Pass CI

Codecov Report

Merging #295 (433a2bd) into master (47d0b83) will decrease coverage by 0.74%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #295      +/-   ##
============================================
- Coverage     73.24%   72.50%   -0.75%
  Complexity     1037     1037
============================================
  Files           146      147       +1
  Lines          3428     3463      +35
  Branches        390      391       +1
============================================
  Hits           2511     2511
- Misses          774      809      +35
  Partials        143      143

Impacted Files
Coverage Δ

src/main/java/gomedic/ui/table/ActivityTable.java
0.00% <0.00%> (ø)

src/main/java/gomedic/ui/table/DoctorTable.java
0.00% <0.00%> (ø)

src/main/java/gomedic/ui/table/PatientTable.java
0.00% <0.00%> (ø)

src/main/java/gomedic/ui/table/TableUtil.java
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47d0b83...433a2bd. Read the comment docs.


v1.7

NOTE
Please verify that the base repository above has the intended destination!
Github by default opens Pull Requests against the parent of a forked repository.
If this is your personal fork and you didn't intend to open a PR for contribution
to the original project then adjust the base repository accordingly.

im a dumb guy


slice: default to throttling, fixes to manufactured 416 responses.

The slice plugin has a problem when consecutive slice blocks are held in ram cache and are shoved into the slice plugin without performing any throttling (which is done for other cases like TCP_HIT, etc).  This PR makes throttling the default and restores the data hand off to using TSIOBufferReaderAvail and TSIOBufferCopy instead of iterating through the TSIOBuffer blocks.
Also a bug was found with slice's 416 response creator, a bug exposed by the addition of slice self healing.
closes #7256
resolves #7179

Backported to 9.0.1 in #7435

Backported to 9.0.1 in #7435


Mention the use or requirements.txt in instructor guide

It is there but needs to be moved further down.


Map file might not get generated at editor launch if the project contains no scene assets

Which will in turn lead to null ref exceptions while trying to access the map.
We can employ two solutions (ideally both):

Generate an empty map in those cases.
Never return null from map providers, instead, return an empty map.

Included in 3.2.1.


Added preview and unlocked OS version

Looking into the comment thread, it seems this has been tested and is working. Correct?

@serge1peshcoff @i3anaan may tell about the iframe. I tested this plugin with OS 2.2b3 and it works fine, so the removal of the upper version limit is ok.

I believe I've seen the frame in action before. While I would prefer something that looks/feels a bit more elegant, this is definitely an improvement over not having anything.

I will re-check it in an hour if it's working, but thanks improving it anyway ;)

@FinnStutzenstein can you change the iframe's src from /projector to /projector/1? because for me it displays the main page instead of actual projector.
otherwise, looks really cool, thanks!

There is support for multiple projectors in OpenSlides now, right? I think there should be support for that as well, by selecting the active projector in a dropdown, just like the live preview in the sidebar does. For now, though, just always going for projector 1 is probably the right move.

Yes this should be faily ease, just look at the code for the projector sidebar. Also projectors can have different aspect ratios than 3:4. The projector preview also resizes the iframe to the correct ratio, too.

Please see the related issues.


Add --cpus option

Based on my experience with latest Nextstrain, --cpus option is required so this PR adds those in the relevant places.
Description of proposed changes
Make a minor fix to the documentation for the ingest step.
Related issue(s)
Testing
Tested by running the code suggested command line.

Note that it's only required (in a sense) when using the "native" runtime with Snakemake 5.11 or later. The Docker runtime does not require it. Relatedly, there's this proposed change which will make it optional regardless of runtime or Snakemake version.


Howelldh/optimize status blockers

Description
Add blockers to optimize status command and fix orion url in configure
Type of Change

[x] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

[x] I have read the contributing guidelines
[ ] Existing issues have been referenced (where applicable)
[x] I have verified this change is not present in other open pull requests
[ ] Functionality is documented
[ ] All code style checks pass
[ ] New code contribution is covered by automated tests
[ ] All new and existing tests pass

Codecov Report

Merging #223 (c70b4f0) into main (4bde18c) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@           Coverage Diff           @@
##             main     #223   +/-   ##
=======================================
  Coverage   27.34%   27.34%
=======================================
  Files          40       40
  Lines        4381     4381
=======================================
  Hits         1198     1198
  Misses       3094     3094
  Partials       89       89


(PUP-10104) Puppet device ssl oids

Not sure if I'd need some other tests, will gladly add them if necessary.

Can one of the admins verify this patch?

Let's give that second commit a more meaningful title too..

Thanks for your contribution @JonasVerhofste! Could you squash the commits?

Oh, sure! Assumed you guys would want tests and actual code in different commits, but if you don't, no probs.

@joshcooper There you go :)

Waiting for CLA signature by @JonasVerhofste
@JonasVerhofste - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/
Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html

CLA signed by all contributors.

Thanks for your contribution @JonasVerhofste, this will be released in the 6.11.0 release!


Link in HTML report is wrong

The link to the individual job session folder from the HTML report is wrong.
To Reproduce
Steps to reproduce the behavior:

Run report with default settings
Click on the link in the HTML Report (file:///C:/temp/vHC/JobSessionReports)
See error

Expected behavior
Use correct link (file:///C:/temp/vHC/Anonymous/JobSessionReports in my case - or Original instead of Anonymous when not anonymized)
Screenshots
N/A
Versions
vHC v<IP_ADDRESS>2

Issue resolved. Will be included in next update.


Rebuild to fix version info

Workaround for https://github.com/gwastro/pycbc/issues/3917.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Add control over the C/C++ standard

I'm confused about our resolutions over this issue. We discussed quite a bit about controlling the C/C++ standard in use, and part of this issue was (I thought) to define C++ standard enums to pass to link_stdlib. That method is not about the standard in use though, so I'm not clear on the design here.
What I think we want is:

Set the C89 / 90s-era C++ standards by default. There's some question though about whether we can accurately control this for all compilers
Add a c_standard method that takes an enum and causes the builder to pass the appropriate flags
Add a cpp_standard method that takes an enum ' '

Needs more discussion. cc @alexcrichton @sfackler @kimundi @dtolnay @burntsushi

I think there's sort of a general question about whether gcc-rs should attempt to provide a guarantee about the C/C++ standard level you're developing with. The thinking was that if we did that we'd have to be pretty conservative for something that worked across a wide range of compilers.
I'd personally be wary of attempting to provide such a guarantee though. If signaling this as an intent in a cross-platform manner makes sense I think we should at least have an option to specify doing it, but it seems like a lot of possible pain for not a lot a lot of possible gain otherwise.

Even if we don't set one by default we might want a way to select the standard in use so that users can have confidence what they are getting. I'm not sure how easy it is for users to get those flags right themselves today, maybe a dedicated method is worthwhile, like set_c_std(CStd::C89.
More generally, I don't know how easy it is to pick the correct compiler-specific flags with this crate today. I guess when people want to distinguish between compilers they probably ask the environment for the target family, and if it's MSVC, do the MSVC thing, otherwise do the gcc thing?

Yeah definitely makes sense to me to have these available, even if not set by default! Right now there's no way to query whether a compiler is msvc-like or gcc-like, it's just inference based on the target mostly.

MSVC has -std flag to control language standard. Can be only c++14, c++17 or c++latest.
GNU compiler's -std flag can be c++03, c++11, c++14 or c++17.
Clang -std flag can be c++11, c++14 or c++1z.
What to do if user wants to set standard which doesn't support by the compiler?

Thanks for the investigation! Seems like we can at least do 14 and maybe 17 as well?
Perhaps we could panic for now if the standard isn't supported? That should at least give us flexibility into the future

I think there's sort of a general question about whether gcc-rs should attempt to provide a guarantee about the C/C++ standard level you're developing with.

I have codebase that uses C99 features throughout, so I absolutely require a guarantee that at-least-C99 standard is supported, or my code simply won't compile.

Set the C89 / 90s-era C++ standards by default.

Is it to force users needing C99 to explicitly turn it on? Current versions of clang, gcc and MSVC all default to C99 (or at least their best attempt at it).

Please note that GCC takes -std=c89 very literally and disables support for // comments, which are common in C codebases, since all compilers accepted it by default for a long time.
If you set the default to -std=c89 then clang users may accidentally create broken builds for GCC users.
If you want to deliberately limit C support to lowest common denominator with older MSVC, then I suggest using -std=gnu90 for GCC.

I'm going to close this since I don't think it's a feature we'll want to add to cc for now, and I definitely don't think we'll want to start passing any flags by default. Otherwise this can always be controlled by various flag passing methods for now, so it's mostly set.


mextr: index out of bounds error

Hi Simon,
We are trying to run gemBS extract and are seeing the following error. Do you have any suggestions on how to get around this?
thread '<unnamed>' panicked at 'index out of bounds: the len is 2 but the index is 2', mextr/src/bbi/tree.rs:125:41

The full output is below:
$ gemBS extract  --cpg --barcode P2_BDDM200000221-1A_HJWYLDSXY
INFO - Launch:
	/usr/local/lib/gemBS/bin/mextr --loglevel info --compress --md5 --regions-file /scratch/secker/dnmt3a/gembs/extract/P2_BDDM200000221-1A_HJWYLDSXY/P2_BDDM200000221-1A_HJWYLDSXY_mextr_ctgs.bed --cpgfile /scratch/secker/dnmt3a/gembs/extract/P2_BDDM200000221-1A_HJWYLDSXY/P2_BDDM200000221-1A_HJWYLDSXY_cpg.txt.gz --bed-methyl /scratch/secker/dnmt3a/gembs/extract/P2_BDDM200000221-1A_HJWYLDSXY/P2_BDDM200000221-1A_HJWYLDSXY --tabix --threads 1 --threshold 10 --mode strand-specific /scratch/secker/dnmt3a/gembs/calls/P2_BDDM200000221-1A_HJWYLDSXY/P2_BDDM200000221-1A_HJWYLDSXY.bcf
WARN - Removing output file /scratch/secker/dnmt3a/gembs/extract/P2_BDDM200000221-1A_HJWYLDSXY/P2_BDDM200000221-1A_HJWYLDSXY_cpg.txt.gz
WARN - Removing output file /scratch/secker/dnmt3a/gembs/extract/P2_BDDM200000221-1A_HJWYLDSXY/P2_BDDM200000221-1A_HJWYLDSXY_cpg.bed.gz
WARN - Removing output file /scratch/secker/dnmt3a/gembs/extract/P2_BDDM200000221-1A_HJWYLDSXY/P2_BDDM200000221-1A_HJWYLDSXY_cpg.bb
WARN - Removing output file /scratch/secker/dnmt3a/gembs/extract/P2_BDDM200000221-1A_HJWYLDSXY/P2_BDDM200000221-1A_HJWYLDSXY_chg.bed.gz
WARN - Removing output file /scratch/secker/dnmt3a/gembs/extract/P2_BDDM200000221-1A_HJWYLDSXY/P2_BDDM200000221-1A_HJWYLDSXY_chg.bb
WARN - Removing output file /scratch/secker/dnmt3a/gembs/extract/P2_BDDM200000221-1A_HJWYLDSXY/P2_BDDM200000221-1A_HJWYLDSXY_chh.bed.gz
WARN - Removing output file /scratch/secker/dnmt3a/gembs/extract/P2_BDDM200000221-1A_HJWYLDSXY/P2_BDDM200000221-1A_HJWYLDSXY_chh.bb
ERROR - Error received from worker thread 7
ERROR - Worker thread 0 received error: receiving on a closed channel
ERROR - Worker thread 4 received error: receiving on a closed channel
ERROR - Worker thread 6 received error: receiving on a closed channel
ERROR - Worker thread 5 received error: receiving on a closed channel
ERROR - Worker thread 2 received error: receiving on a closed channel
ERROR - Worker thread 1 received error: receiving on a closed channel
ERROR - Worker thread 3 received error: receiving on a closed channel
Error: "Exiting after error"

$ /usr/local/lib/gemBS/bin/mextr --loglevel info --compress --md5 --regions-file /scratch/secker/dnmt3a/gembs/extract/P2_BDDM200000221-1A_HJWYLDSXY/P2_BDDM200000221-1A_HJWYLDSXY_mextr_ctgs.bed --cpgfile /scratch/secker/dnmt3a/gembs/extract/P2_BDDM200000221-1A_HJWYLDSXY/P2_BDDM200000221-1A_HJWYLDSXY_cpg.txt.gz --bed-methyl /scratch/secker/dnmt3a/gembs/extract/P2_BDDM200000221-1A_HJWYLDSXY/P2_BDDM200000221-1A_HJWYLDSXY --tabix --threads 1 --threshold 10 --mode strand-specific /scratch/secker/dnmt3a/gembs/calls/P2_BDDM200000221-1A_HJWYLDSXY/P2_BDDM200000221-1A_HJWYLDSXY.bcf
INFO - compress_bbi_thread starting up
INFO - write_bbi_thread starting up
thread '<unnamed>' panicked at 'index out of bounds: the len is 2 but the index is 2', mextr/src/bbi/tree.rs:125:41
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Aborted

Came across this again. It's due to a conflict between gemBS v3 and v4 - i.e. the mextr script from v3 was called instead of the updated version from v4.
Perhaps it makes sense to check the version of mextr (or rename the script in v4) to avoid this issue)...

Thanks for the report.  Could you give me more details on how exactly this
is triggered.  At the least I can try and give a more informative error
message!
Simon
On Thu, Jan 13, 2022 at 11:08 AM Ismail Moghul @.***>
wrote:

Came across this again. It's due to a conflict between gemBS v3 and v4 -
i.e. the mextr script from v3 was called instead of the updated version
from v4.
Perhaps it makes sense to check the version of mextr (or rename the script
in v4) to avoid this issue)...
—
Reply to this email directly, view it on GitHub
https://github.com/heathsc/gemBS-rs/issues/7#issuecomment-1011984642,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAY4652NR2O6K2QCM7P52VTUV2QDDANCNFSM444Q4VCQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


test: update paths for key_line_2d unit tests

The keyline2d tests and data were incorrectly categorised under keypoints before. This PR corrects the pathing (and categorisation) for the tests and data.

This change is

Thank you!


Changed the story a little bit.

Please review my work and merge to main branch

Everything looks good!


feat: add Mechanism to call uiQueueMain from other thread and send data between main thread => main thread

Fix #16
I don't know if this is the best API, but works well with my program.

I have fixed several error from example code.

Thanks a lot! Looks good! I'll check it out and run it myself this weekend, then merge it :)
If time allows I might push it to crates.io also. Last revision was some time ago.


How to remove wheel start backward rotation?

Is is possible to start wheel without this slightly backward rotation?

@arcz15 we added a disableInitialAnimation prop in version 1.4.1, hope it helps!


Add option for disabled tabs

Create a disabled tab if data-tabs-disabled is present on the original
panel. To create parity with the visual output, the disabled tabs can be
reached via keyboard navigation and assistive technology (AT).
Disabled tabs should be styled to look disabled, i.e. by decreasing their
opacity to 0.5. AT should then read out "tab, dimmed" or even
"tab, disabled" if they can interpret the aria-disabled attribute.
Disabled tabs do not activate their respective panels.

Hi @scottaohara,
thanks for the feedback! I have refactored the code and added a test case. Please let me know if I missed anything else!

Hi @scottaohara,
do you need anything else from me? Or do you question the merit of this feature in general? Would be great to move forward (mainly so I can close a ticket in our issue tracker 😅), but if you're busy there's no need to rush things.

hi @polarbirke
apologies this completely fell off my radar.  I'll give this a look asap.

hi @polarbirke
apologies this completely fell off my radar. I'll give this a look asap.

Hey @scottaohara, no worries. Happy to answer questions or debate the rationale behind it all any time. ☕

So, some additional things need to be updated here.
Being that the tab is only receiving aria-disabled, nothing actually is disabled about it.  I can still navigate to it with arrow keys, activate it with mouse or keyboard.  I shouldn't be able to do any of that.
The tab must not be able to receive keyboard focus, nor allow for mouse click / tab activation.

Ah, interesting. Thank you for looking into this! In my reasoning I (foolishly?) thought it would be beneficial if the tab was navigable but announced as disabled. I hoped this might lead to better parity for sighted/non-sighted users especially. My client uses a tabbed interface to disclose and present different kinds of data about a resource and in their domain a disabled tab is a way of showing "usually there is this kind of data for this kind of resource, but it's not published yet". What I have tried to build is a variant that tries to mimic the case where a sighted user can infer this information from the visual style, whereas users of AT can have it announced to them. Does that make any sense?
In case you at least partly agree, is there a way to have the tab label read out as "Tab, some info, disabled" without it gaining focus/being navigable?
In case you think my reasoning is flawed, I'll be quite happy to follow your judgment and disable it completely.
Thanks again!

I wouldn't describe your thinking as foolish, so please don't say that :), but it was flawed in this instance.
screen reader users could very well still navigate to a disabled tab element if they are navigating via the virtual cursor.  It'd be unexpected to navigate to elements that appear disabled, and completely unexpected for the disabled element to be functional in any way.
Even for screen readers that go into forms/application mode when entering a tablist, typically the number of tabs in the list will be announced.  So if one were to realize they only had access to 3 out of 5 tabs, they could disable forms mode and then navigate via virtual cursor to the other disabled tabs, per my description above.

hey @polarbirke, i appreciate you taking the time to give this another shot.
I'll give this a proper review as soon as i can.

Hi @scottaohara, just pinging to remind you of this PR. Still no hurry, though.

Hej Scott,
I'm not entirely sure what you mean here:

One additional request (if you have time) is might you provide an update to the example for disabled tabs to demonstrate how someone could re-enable a disabled tab? (e.g. press a button to make the tab enabled)

Would you like to illustrate the difference between enabled and disabled tabs in the demo by toggling the setting on the same tab? I don't yet understand the advantage over having two enabled and one disabled tabs, but I could of course add that. 👍

Do you think that users should be able to toggle the setting on real-life websites? The decision whether a tab is disabled has always been an editorial concern in my mind and not something that is customizable in user land. Am I missing something? 😳

As always, thank you for your feedback and time!

Sort of what you describe in bullet two, but not quite.
The situation I'm thinking of / have seen happen is using a Tab widget in a multi-step process, where a user completes a task in the exposed tab panel or panels, and then by completion of that task the next Tab becomes enabled.
Rather than simulating that exactly, I was thinking "just put a button within one of the tab panels that would enable the disabled tab"

Ah, fabulous! That sounds absolutely reasonable. I will mock that functionality with corresponding comments – thanks for the insight!
I should have time to work on it this week. 👨💻

Hey Scott,
my colleague Lukas gave me a leg up and added the demo – is this what you envisioned?

thanks!  will give it a review this weekend.

Hi Scott,
any thoughts on this PR? I just saw we missed its first anniversary 😁 The last update was the addition of a demo by my colleague.
All the best to you and yours!

@polarbirke, thank you again for this and sorry it took forever and a day for me to finally give this a proper review.
better late than never i suppose?

No worries, I see and appreciate the work you do everywhere else. 👍
Thanks for the merge!


How many levels deep can HNC go?

Can I create a subnamespace within a subnamespace, and if so, how many levels down?
e.g
namespace
--subnamespace1
--subnamespace2
--subnamespace3
--subnamespace4

I see you found the answer, but there's no official limit. We once tested dozens and they worked fine; I wouldn't recommend more than a few though.


https is not working

The current site seems to be using the certificate of choosealicense.com

https://electron.atom.io/

I believe this is a side-effect of using a sub-domain and GitHub Pages.  Not sure if there is even a solution to this while we are still on GitHub Pages

Suggestions in a recent meeting:

Put a CDN in front of the existing GitHub Pages app
Host it elsewhere, like Heroku or Surge

Filed an issue with the Pages and Security teams. They're working on issuing a new cert.

Fixed! Thanks to @parkr for setting up the new cert.


"bower install" latest listed Backbone Forms v0.14.0 but actually v0.13.0

after running bower install in console i get
bower backbone-forms#~0.14.0       not-cached git://github.com/powmedia/backbone-forms.git#~0.14.0
bower backbone-forms#~0.14.0          resolve git://github.com/powmedia/backbone-forms.git#~0.14.0
bower backbone-forms#~0.14.0         download https://github.com/powmedia/backbone-forms/archive/v0.14.0.tar.gz
bower backbone-forms#~0.14.0          extract archive.tar.gz
bower backbone-forms#~0.14.0         resolved git://github.com/powmedia/backbone-forms.git#0.14.0
bower backbone-forms#~0.14.0          install backbone-forms#0.14.0
actually I get v0.13.0

:+1: please fix.

:+1: Please fix!

This has happened because the release tag v0.14.0 was created before the version numbers were changed.
b1d90a5c1decaeeafe523037806fc61f780c3b8a - is the release tag.
e0f2e7a9403ab183f1fa533ad6c72bf13a71e7e2 - is the versioning increment.
bower.json was updated: fda7dc032dbce72e170c3d398129a4dadcf493b7
suggest fix: release new version number.

This is also a problem on npm! The builds are old and contain old bugs. Please release a new version!

:+1: Please fix!

Still not fixed, come on already, it's not that hard - they've told you how...

Even though @powmedia has public activity in the last few days, this project hasn't been touch since 7 months. I guess he's too busy.

Okay, I forked & created a branch from master (which doesn't seem to show up in Github even though my command line says it's on the remote).  I've updated the patch version in the files, fixed the build scripts and done a build based on fda7dc0  I tried to do a pull request #480, but this is relative to master which is wrong.
The commit bed2295 could be merged into a branch from the above commit and then tagged - which I've done on my fork - you can't merge tags across repos.  So @powmedia can do that if he wishes, then people with ~0.14.0 will be able to update via bower.

Issue is a year old and he's hardly active.

All hope is lost.
@powmedia at least add an admin contributor if one is willing to take over.

@glenpike I can see your repository.
Can you create a pull request? I think it will have better chances to be changed that way.
@maxmx maybe he's busy but just not on github or on private projects (as I am). But I agree, we need an admin. But who would it be?
I sadly don't have time for this. Anyway, I would prefer start from scratch in coffeescript and using backbone.marionette.

reach out<EMAIL_ADDRESS>

@fonji - do you know how I can create a pull request that doesn't go to master.  I think I need a branch in this repo to target?

Alas, I don't really have much time to be an admin, sorry :-1:

@glenpike I think you should target master (it's the branch where you want your stuff to go)

@fonji - not sure I want to target master as it's moved on since fda7dc0 and I was just creating a bower release version to fix the problem there rather than a "latest" release.

@glenpike I see. I guess we need input from @powmedia then...

@philfreo  is this something you can do or is it just @powmedia ?

Well this was a little frustrating. Never feels right using a module where the admin is MIA :(

Good news, I have managed to speak to Charles and he's opened up admin access for me and is hopefully doing the same for someone else :8ball:

Hooray for @glenpike ! :+1:

See the v0.14.1 release / tag.


Always getting this error i need some help

2:43,615] WARNING    Could not detect item_seperator_short.
[1.3.3 2023-11-05 14:32:43,645] WARNING    Failed to read properties. Keeping it
[1.3.3 2023-11-05 14:32:50,058] ERROR      Could not detect item descr. Timeout reached. Continue
[1.3.3 2023-11-05 14:32:53,792] INFO       Stoping Filter process

Hi, two things. Can you provide the full log? You can find it in the log folder. An can you provide the item_descr screenshot in logs/screenshots?

Closing cause of inactivity. Feel free to repon with the requested data.


add build instructions for openms

This is not perfect but hopefully get the job done.
Things to improve:

LDFLAG magic is not working and we need to export LD_LIBRARY_PATH

@natefoo I exported a few shared object files and enabled debian backports. Now this builds with ./build galaxy openms.
Could you please upload this tarball and the tpp tarball into the depot?
If you have any ideas how to make the copying if *.so files smarter, please let me know.

I wouldn't say it is a vast improvement but you could do something like what's done in ucsc.
The problem is you already have to know which linked libs are non-standard. I suppose if we had some kind of lib-collecting utility function that already knew which libs to exclude, that'd help?

@bgruening I've uploaded both to depot.galaxyproject.org

Thanks @natefoo! Can you help me to find the links? These are not working :(

https://depot.galaxyproject.org/openms-2.0-Linux-x86_64.tar.gz
https://depot.galaxyproject.org/tpp-4.8.0-Linux-x86_64.tar.gz


Introducing a media_player component for Yamaha Multicast devices

Description:
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for configuration.yaml (if applicable):
media_player:
  - platform: yamaha_musiccast
    name: "Living Room"
    host: 192.168.xxx.xx
    port: 5005

Checklist:
If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

Hello @jalmeroth,
When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).
The commits that are missing a linked GitHub account are the following:

a4fb64b53a79f68966d4af80fe9304d357bcd832 - This commit has something that looks like an email address (jan+github@almeroth.com). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.
Here are your options:

If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

If you only made a single commit you should be able to rungit commit --amend --author="Author Name<EMAIL_ADDRESS>
(substituting Author Name and<EMAIL_ADDRESS>for your actual information) to set the authorship information.
If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:

You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.

Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.
Thanks, I look forward to checking this PR again soon! :heart:

Hello @jalmeroth,
When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).
The commits that are missing a linked GitHub account are the following:

664c25d6571e2f49f635aea332a848655f220c36 - This commit has something that looks like an email address (jan+github@almeroth.com). Maybe try linking that to GitHub?.
a4fb64b53a79f68966d4af80fe9304d357bcd832 - This commit has something that looks like an email address (jan+github@almeroth.com). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.
Here are your options:

If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

If you only made a single commit you should be able to rungit commit --amend --author="Author Name<EMAIL_ADDRESS>
(substituting Author Name and<EMAIL_ADDRESS>for your actual information) to set the authorship information.
If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:

You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.

Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.
Thanks, I look forward to checking this PR again soon! :heart:

Hi @jalmeroth,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

this pull request also includes geofency support, which is nice but most likely will be rejected unless being in a separate pr.

Whoops, thanks for the heads-up @runningman84. Obviously something went wrong with the rebasing.

Thanks!


CodeWorld probably doesn't build with latest GHCJS

Looks like there was a change to remove the phantom type parameter from JSRef, which will definitely break CodeWorld.  Should be an easy fix, but I just need to spin up a new instance so I can rebuild without downtime.

Fixed


Crash reporting: avoid several dialog

Description
Apparently, if several errors are triggered, several crash reporting dialog were showing up, on top of each other so not allowing the user to enter his feedback.
So now:

the dialog is not displayed if a dialog is already being displayed
the dialog is not redisplayed if the same error happens several time (was already done by sentry but needs to be reimplemented with the previous change)

Test cases
I had to cause crashes in a branch to trigger that :-/

[auto-generated message] E2E test report on: https://algorea-static.s3.eu-central-1.amazonaws.com/branch/crash-reporting-avoid-several-dialog/playwright-report/index.html


$ref to other OAS file does not quite work as expected

Hi there!
I want to post a problem I've met when I use Portman to generate the multi-file OAS.
They are all defined under the same path, i.e.
├── A.yaml
├── B.yaml
├── C.yaml
Firstly, I have rootOAS A.yaml:
openapi: 3.1.0
...
paths:
  /a/b/{id}:
    summary: An Endpoint
    post:
      parameters:
        - in: path
          name: id
          schema:
            type: string
          required: true
      requestBody:
        required: true
        content:
          application/json:
            schema:
              $ref: "./B.yaml#/components/schemas/action"

As you can see, the rootOAS refers to B schema
B.yaml
components:
  schemas:
    action:
      anyOf:
        - $ref: "C.yaml#/components/schemas/Cart"

Which internally refers to C Schmea
C.yaml
components:
  schemas:
    Cart:
      type: object
            allOf:
              - properties:
                  id:
                    type: string

Then when I tried to generate collection with portman command feeding the rootOAS
portman -l ./A.yaml --cliOptionsFile ./portman/configs/portman-cli.json -o ./definitions/postman.json
I got error:
Portman config file not provided.
ResolverError: Error opening file "/Users/my.name/documents/tmp/converted/schemas/B.yaml"
ENOENT: no such file or directory, open '/Users/my.name/documents/tmp/converted/schemas/B.yaml'

I saw someone posted a similar question, and the answer said Portman will de-reference before doing the converting, but here the problem is obvisouly the rootOAS A.yaml got convert Before  dereferencing other OAS.
One workaround I've made it work is change the reference path from A to B:
$ref: "../../B.yaml#/components/schemas/action"
It works but not really seems to be correct to me.
Any help will be appreciated, thanks!

hi @cw112233
We will have to replicate the 3 references to see where de-reference goes wrong. It is a bit strange that Portman is looking for the referenced file in the "tmp" folder.

@thim81 I'm having the same problem, any clues on what might be causing this?

@andreicherechesbyx We briefly looked into to it, but we have not yet found any indication of the strange behaviour.
We have the info to be able to replicate it, we just need to find time to further dive in.

hi @andreicherechesbyx & @cw112233
We just release v1.30.3, which has improvements for handling $ref in multiple files.
Can you give the latest version a spin and see if it overcomes the reported issues?


Update index.js

:bar_chart: Metadata *
safe-flat is vulnerable to Prototype Pollution.
This package allowing for modification of prototype behavior, which may result in Information Disclosure/DoS/RCE.
Bounty URL: https://www.huntr.dev/bounties/1-npm-safe-flat/
:gear: Description *
Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as proto, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.
:computer: Technical Description *
The bug is fixed by validating the input strArray to check for prototypes. It is implemented by a simple validation to check for prototype keywords (proto, constructor and prototype), where if it exists, the function returns the object without modifying it, thus fixing the Prototype Pollution Vulnerability.
:bug: Proof of Concept (PoC) *
Clone the project, install the required dependencies and on running the below snippet of code, it triggers prototype pollution and logs true.
// poc.js
var {unflatten } = require("safe-flat")
console.log("Before : " + {}.polluted);
unflatten({"__proto__.polluted": "Yes! Its Polluted"})
console.log("After : " + {}.polluted);

https://drive.google.com/file/d/1uMhpweXblJJGzdAoS_5aum5S0UppfCtR/view?usp=sharing
:fire: Proof of Fix (PoF) *
After the fix is applied, it returns an error since the polluted referred in the PoC is no more accessible(which is intended). Hence fixing the issue.
https://drive.google.com/file/d/12UaRTT-4dR_NvYjb58ZAthHwdTqPmiQd/view?usp=sharing
:+1: User Acceptance Testing (UAT)
*I've executed unit tests.
*I've added unit tests to prove the fix.

LGTM smile cake
Maybe it's better returning the result unmodified object instead of false.
What do you think @bbeale @mufeedvh ?
Cheers,
Mik

Done @Mik317  https://github.com/418sec/safe-flat/pull/2/commits/2c7b07d8db1c0184c8167267bac60acc6a114292

Sorry Anon-Artist, we enjoyed reviewing your fix but it has not been selected this time. If this bounty has not been closed, please feel free to try again with a new pull request!
We appreciate your effort and look forward to reviewing more of your fixes in the future! 🔨😎
Come join us on Discord


Allow as in match statements

As in
let ptr = match mmap(...) {
    -1 as *mut c_void => panic!(),
    p => p,
}

This is very useful for FFI and #![no_std], I don't think it takes anything away, and it shouldn't be too difficult to add.
Possibilities right now include
let ptr = match mmap(...) as usize {
    -1 => panic!(),
    p => p as *mut c_void,
}

or
let ptr = match mmap(...) {
    p if p == -1 => panic!(),
    p => p,
}

Another possible idea, one that I doubt many people would like, is to allow *const and *mut pointers to be integrals. Then you could just do the C thing of
let ptr = match mmap(...) {
    -1 => panic!(), // -1 is a *mut c_void in this situation
    p => p,
}

Perhaps type ascription is a better choice here? That RFC actually says

An earlier version of this RFC covered type ascription in patterns too, that has been postponed

So there may already be existing discussion about this.

@kballard Type ascription asserts that the expression has the provided type, but it doesn't apply in this case: -1 is an integer, not a raw pointer. The casting is required.
That said, I think it is better to allow int ↔ raw pointer casting in CTFE to allow:
const INVALID_MMAP: *mut c_void = (-1usize) as *mut c_void;
match mmap(...) {
    INVALID_MMAP => ...
    p => ...
}

Oh you're right, for some reason I was thinking that integral literals could be used where pointers are expected, but no, you need the explicit as there.

That said, I think it is better to allow int ↔ raw pointer casting in CTFE

Huh, that seems a bit surprising that it doesn't work. Is there an issue that tracks this? If not, one should be filed.

I think that with  this is now doable as


Example on Android device

Hi.
First of all thanks for developing this package.
I run the example code on android device but nothing happening.

Hello, unfortunately in Android and iOS the package doesn't work on debug, only in release.
Did you run it in release and it didn't work?

First of all, I apologize for my late reply.
I built an APK file in release, but unfortunately not works.

I see.
Can you please tell me what phone do you have and what android version?

On xiaomi redmi note 10 pro max (android 13), and xiaomi poco x40 (android 11)

Hi, sorry for not answering but right now the situation in Israel is hard. I will get on it as soon as I have the time


Loop Animations

Great plugin! Works like a charm.
Not really an issue, but a question: Is it possible to loop animations infinitely?

Hallo :)
Well, if by infinite you mean: draw, undraw, draw, undraw, draw.... yeah it is.
In the callback of animation end, just check for the status use play() with a good value.
new Vivus('hi-there', {}, function (myVivus) {
  myVivus.play(myVivus.getStatus() === 'end' ? -1 : 1);
})

You can run this code on the demo page.
Is it what you're looking for?

new Vivus('hi-there', {}, myVivus => {
  if (myVivus.getStatus() === 'end') {
    myVivus.reset().play();
  }
});

it's so fast


Support the policy subscription function through Nacos configuration

Is your feature request related to a problem? Please describe.
Currently, we have implemented several methods to obtain policies through a fixed API. However, these methods are not general enough, and we hope that the policy content can be subscribed to through a configuration center (such as Nacos).
The implementation location is: joylive-implement/joylive-service
For reference: joylive-implement/joylive-service/joylive-service-multilive

with live policy

There are many config centers, so design a config api，watch config change event.

1、Design a Config API, watch config change event.
2、The API  supports Nacos.
3、Sync Policy by the API.


Buttons look bad in Outlook / Windows 10 Mail

This is a screenshot from the Windows 10 Mail app:

(same issue in Outlook).

Thanks for reporting this @sryze 😸
We'll have someone take a look.

Which inliner did you use before sending @sryze? It looks like there is padding missing around the title block too...
Maybe include your source code here (either what you sent or what you received in Outlook) so we can see which CSS declarations aren't being honoured

PR #45 should resolve this issue for all the Meow templates. Thanks everyone for bringing this to our attention and for helping out! 🐈


"Bărcănești" is listed in the drop-down menu

Description:
"Bărcănești" is listed in the drop-down menu alongside its corresponding county according to the law
Precondition:
The website is up an running.

Step 1
Type "Bărcănești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Bărcănești, IALOMIȚA".


CLI: Permit options be passed to hyper/electron bin

We need to permit users to pass options directly to hyper/Electron bin.
For example: hyper --ignore-gpu-blacklist

Hyper currently uses args to handle command-line arguments at runtime, but as far as I could tell, args has no way of handling unknown options. We'll either need to include all of the options that can be passed to Electron manually, or use a different implementation for handling CLI arguments.
In particular, yargs seems to have a way of routing the arguments through custom middleware before running the command associated with them.


[log_generator] Adding missing dependencies

Signed-off-by: Vicente Zepeda Mas<EMAIL_ADDRESS>Description
Adding pip upgrade to Dockerfiles and missing dependencies due to build failures.
Fixes

Codecov Report

Merging #395 (281716c) into master (0405986) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #395   +/-   ##
=======================================
  Coverage   39.35%   39.35%
=======================================
  Files          15       15
  Lines         869      869
=======================================
  Hits          342      342
  Misses        527      527

Flag
Coverage Δ

gha
39.35% <ø> (ø)

python-3.6
39.35% <ø> (ø)

unit
39.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0405986...281716c. Read the comment docs.

Results for SNAFU CI Test

Test
Result
Runtime

snafu/log_generator_wrapper
FAIL
00:00:35

Results for SNAFU CI Test

Test
Result
Runtime

snafu/log_generator_wrapper
FAIL
00:02:27

/rerun all

Results for SNAFU CI Test

Test
Result
Runtime

snafu/log_generator_wrapper
PASS
00:03:33


chore: release 0.21.1

:robot: I have created a release *beep* *boop*
0.21.1 (2021-12-07)
Bug Fixes

fix input box style of search page in dark mode (f233bce), closes #125

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/easyops-cn/docusaurus-search-local/releases/tag/v0.21.1 :sunflower:

Coverage remained the same at 76.61% when pulling 05bcbc657d3f79353ef7f04af818405170444ebb on release-v0.21.1 into 20e58a1dbb40b8665037e77a86ff6465816fb5bb on master.


Failed to download docker image

$ docker pull spg-registry.cn-hangzhou.cr.aliyuncs.com/spg/openspg-server:latest
Error response from daemon: Get "https://spg-registry.cn-hangzhou.cr.aliyuncs.com/v2/": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)

This link is failed to download, is possible to provide other image url like docker.io or gcr.io?

Thank you for your feedback. Please replace spg-registry.cn-hangzhou.cr.aliyuncs.com with  spg-registry.us-west-1.cr.aliyuncs.com and pull


source: Additional property source is not allowed

I have a file-entry in system.yml:
files:
- path: var/lib/tftpboot/boot.ipxe
  source: snponly.efi

On moby build system.yml I get the following error:
The configuration file is invalid:
- source: Additional property source is not allowed
FATA[0000] Invalid config: invalid configuration file

Are you sure you are using the latest version? This was only merged
yesterday, but I have been using it.
On 23 May 2017 16:11, "steigr"<EMAIL_ADDRESS>wrote:

I have a file-entry in system.yml:
files:

path: var/lib/tftpboot/boot.ipxe
source: snponly.efi

On moby build system.yml I get the following error:
The configuration file is invalid:

source: Additional property source is not allowed
FATA[0000] Invalid config: invalid configuration file

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/moby/tool/issues/40, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAdcPHhcpgtIODRuj0nuY2ja8ukBXys0ks5r8vb6gaJpZM4Nj16M
.

Jep, $PATH issue 😅


By mistake I pushed directly to houseofgeeks/hg

Apologies 😞

It's alright -:)

It's absolutely fine :-)


Contact List & Renaming Contacts

To add a layer to Synapse to allow matrix accounts to store a encrypted contacts list of their matrix friends will be handy and here is what can be done with such as feature.

Clients can access this contacts list
Contact lists will be saved on the matrix homeserver, only accessible to the user and can be synced to other clients like messages
Contact list is encrypted, it cannot be stored unencrypted
Ability to create contact groups and put contacts into groups for organization
Contact list will save the following fields (Name, Matrix address, groups)
Ability to save public and private rooms in contacts
Room in contacts will have the following fields (Name, matrix room id/hashtag, groups)

By having contacts, you can set a name you will know to a friend who has an obscure name and matrix address such as cyberguy2001 to something like John Smith that you will know or renaming a room name to something more familiar. Additional contact fields could be added such as email, notes, birthday, anniversary, phone number, etc but I think the bare minimum that is needed is Name, Matrix address/room and groups.
This will mean contacts will be kept more private since using a contacts application on a phone which people use to save their emails and phone numbers can be read by other apps, by having a built in matrix contacts system that does backup to your account and is encrypted will be a more private answer.

This sounds like it is probably a spec issue since it is talking about features that span both homeservers and clients. I've transferred this to the relevant repo.

This sounds like it is probably a spec issue since it is talking about features that span both homeservers and clients. I've transferred this to the relevant repo.


Multi-field search criteria (advanced search)

It should be possible to trigger advanced search (think about UXD) by multiple fields

Idea: search criteria like this "description: abcd && status: release". Maybe start with single field criteria (without &&, || and ! operators)


Make single_stream_expected_latency_ns configurable in benchmark_setting for Flutter app

Closes #291

Let's wait samsung backend changes.

@mohitmundhragithub and other Qualcomm colleagues, please help review this and change q backend for this latency parameter accordingly.

new log location

On Android Flutter app uses system-provided cache directory.
It prints it into logcat as output_dir=<path>. On my phone path is /data/user/0/org.mlcommons.android.mlperfbench/cache.
It seems like this path is not accessible on non-rooted devices so we may think about moving logs to somewhere else.
However, about a month ago we merged a PR that reads logs and marks invalid results in UI by red color. If results in UI use black/white color for text then loadgen marked them as valid.

Also loadgen short summary should be printer into logcat.

Thanks a lot @d-uzlov  for the steps. I was able to verify that this change is working fine for Qualcomm.

@d-uzlov Please review and approve as I needed to merge master to fix CI checks.

I forgot to delete it.


nfs3: add test for readdirplus records v3

Typo Fix :)

Previous PR: #674
S-V for unittests at OISF/suricata@4e2edd4

Followed by #683


Provide release for Ubuntu 22.04 "Jammy Jellyfish"

The CouchDB apt repository at https://apache.jfrog.io/artifactory/couchdb-deb/ does not include a release for the latest Ubuntu LTS, 22.04 "Jammy Jellyfish"
Description
Following the installation instructions provided in the official docs eventually fails with the message:
Failed to update apt cache: E:The repository 'https://apache.jfrog.io/artifactory/couchdb-deb jammy Release' does not have a Release file.

Steps to Reproduce
(Commands copy-pasted from installation instructions)
sudo apt update && sudo apt install -y curl apt-transport-https gnupg
curl https://couchdb.apache.org/repo/keys.asc | gpg --dearmor | sudo tee /usr/share/keyrings/couchdb-archive-keyring.gpg >/dev/null 2>&1
source /etc/os-release
echo "deb [signed-by=/usr/share/keyrings/couchdb-archive-keyring.gpg] https://apache.jfrog.io/artifactory/couchdb-deb/ ${VERSION_CODENAME} main" \
    | sudo tee /etc/apt/sources.list.d/couchdb.list >/dev/null

Expected Behaviour
Adding the apt repository succeeds because there is a release for this version of Ubuntu
Your Environment

Operating system and version: Ubuntu 22.04

Good idea @camtauxe.
For now I believe it might be possible to use the focal version

Good idea @big-r81

@camtauxe @big-r81 I uploaded a jammy CI / build image then built and uploaded packages for jammy in https://github.com/apache/couchdb-pkg/pull/100
I had noticed that either libicu or mozjs78 brings a tzdata package and then it ask for an interactive timezone choice during install.

Closing issue. Please reopen if there are any problems with the new jammy packages


CVS appointments not showing up?

I've been pulling the MN data from the JSON API, and I've noticed that no CVS appointments seem to show up in the data for at least the last three or four days, but the local MN vaccine hunters group has reported availability via the CVS website several times.  The CVS site also shows appointments are currently available (as of 11:17 AM central on 3/21) in Duluth, MN, and that isn't showing up on the site (or in the API).
So, I don't know if this is a nationwide issue, but at least in MN, CVS appointments don't seem to be getting picked up.

What does the bx at the bottom of the page say for CVS? when i go to the MN page i see this, indicating that CVS was recently updated. I'm not the maintainer but i feel like this might be useful to know

I suppose its also possible for the "last updated" data to be showing the last time CVS was updated for ANY state, which might be a different bug.

Ah, good question, I didn't specify that.  Yeah, the last updated is fine.  It's not a single point in time problem - it's been going for days, and the last updated is (every time I've looked) in the expected window of a few minutes max.

This happens because CVS doesn’t always update their main page (https://www.cvs.com/immunizations/covid-19-vaccine?icid=cvs-home-hero1-link2-coronavirus-vaccine) when appointments show up in the scheduler.

Jeff,
So you're saying the scripts rely on the landing page and don't scrape the API directly?  (Yes, I'm being lazy and not checking the code, sry)

Vaccine spotter pulls its availability data from the CVS endpoint that describes whether appointments are “available” or “fully booked” in a city, state. It does not pull from the appointment scheduler. Whether you can find additional appointments depends on whether CVS keeps the endpoint in sync.

I just did some brief poking around the appointment scheduler and have a Postman export. it seems like their requests are more complex than other places (theres a substantial body and a lot of cookies. not sure which are necessary). i was able to get a 200 OK in postman and change the zip code and distance in the body without issues. Api key appears to be the same for all requests, including with deleted cookies, a new browser, and a different IP.
heres the postman collection export (may need to change to .json)
CVS.postman_collection.json.txt


Fixes for wasm

Small fixes to get the wasm version to run again. This PR is based on top of #23, so please disregard that extra diff for now, I'll rebase once #23 is merged.
Primarily, this PR adds import checks for the parquet and feather format and pdf export. Some formatting changes occurred since I ran black at the end.
@Aggrathon I'm unsure about the optional dependency changes - these are the packages that cannot be used (or need to be lazily loaded for sklearn) in xiplot right now, but maybe there's a better way to represent that.
Once this PR is merged I have a follow-up for the WASM branch to update it - locally everything seems to be working.

And if optional dependencies are the best solution, then I would group all (non-dev) dependencies into one group.

I agree that the optional dependencies solution is not optimal. Unfortunately Python doesn't seem to have some kind of "default optional dependencies". The only thing I've been able to find is conditional dependencies.
So how about keeping the dependencies required but either:
a) Filter out the packages in the wasm branch. b) Add conditional specification that always evaluates to true, but can be detected (and filtered) in the wasm branch, e.g. kaleido ~= 0.2.1; platform_system!='xiplot_wasm'.

I like that idea and have implemented it :)

(Note that I haven't tried a custom conditional dependency myself, so something might complain. But in theory it should work.)

Using a pyodide REPL I get the following value:
>>> import platform
>>> platform.system()
'Emscripten'

Superseded by #28


Add option to query to treat null == undefined

Is your feature request related to a problem? Please describe.
When storing the documents, I would like them to be as concise as possible, which means not storing elements that are not set.
When upgrading the client-side data model, any new fields will be undefined on the stored documents. Any queries that evaluate these fields will then only perform a null check (either  == null or != null) which will always fail.
Describe the solution you'd like
The GetItemLinqQueryable<T>() method should have a option like treatUndefinedAsNull so the generated query will add the IS_DEFINED checks to any null compare.
Describe alternatives you've considered
One alternative is to change all queries to manually invoke the check, which is obtrusive and hard to use in testing.
Only other fix is to ensure that all values are always written to all documents with a null value, which causes issues on data model upgrades as each single document needs to be updated.
Additional context
This is similar to #3272

@kskem, there are existing LINQ extension methods such as IsDefined & IsNull that can be used to customize the generated query for solving this issue. Is this something that you can use to address this scenario?

@adityasa The problem with these methods is that they do not work client-side.
This means that we cannot test the code that uses them without being connected to a Cosmos instance (cumbersome for CI testing), and that we need to use different queries for the same "lists", depending on where the data is stored.

@kskem for testing - can you not baseline the query that gets generated when these methods are used without actually running the query?


How to convert json file to doc website

I have created a JSON format file for a particular module in my Deno project using "deno doc --Json > sample.json". This creates a sample.json file of the module. Then I cloned and setup the doc_website in my local.
But I am confused how to use sample.json file in doc_website. I am stuck with where to add this file in doc_wesite folder structure.
Thanks in advance.

I think you are looking for #77. This has not been implemented yet. For now you can take a look at ddoc, is a version of the doc website that runs on your local machine in a webview (with offline support).

I think you are looking for #77. This has not been implemented yet. For now you can take a look at ddoc, is a version of the doc website that runs on your local machine in a webview (with offline support).

I hosted it in vercel and get a url for this. But by default it displaying the deno doc. So how can I create a deno doc with created json or for my own project without json.

@davisjohndavis3
I have same problem (confused... my extract 'sample.json' how to show up locally?) and I solve that simple fixing code.
my solution is follow steps.
(1).  clone "doc_website" code (git clone https://github.com/denoland/doc_website)
(2). create folder and file 'pages/mydoc/sample.tsx'

(3). write code in sample.tsx (actually we don't need entrypoint and name -> because we already have sample.json)
import { useRouter } from "next/router";
import { Documentation } from "../../components/MyDocumentation";

const Page = () => {
  const { query } = useRouter();
  const version = query.version ?? "stable";

  return (
    <Documentation
      entrypoint={""}
      name={`openapi@${version}`}
    />
  );
};

export default Page;

(4) create myDocumentation component in components/MyDocumentation.tsx
import React, { useReducer, useEffect } from "react";
import Head from "next/head";
import useSWR from "swr";
import { DocsData } from "../util/data";
import { SinglePage } from "./SinglePage";
import jsDocJson from '../assets/data.json'; // !! data.json is same file your "sample.json"

export const Documentation = ({
  entrypoint,
  name,
}: {
  entrypoint: string;
  name: string;
}) => {
  const [loadCount, forceReload] = useReducer((i) => ++i, 0);
  const { data } = useSWR<DocsData, string>(
    [entrypoint, loadCount],
    () => {
      const docsData = {
        timestamp: '',
        nodes: jsDocJson,
      } as DocsData;
      return docsData;
    },
    {
      revalidateOnFocus: false,
      revalidateOnReconnect: false,
      refreshWhenHidden: false,
      refreshWhenOffline: false,
    }
  );
  const runtimeBuiltinsData = data;

  return (
    <>
      <Head>
        <title>{name} - deno doc</title>
        <meta
          name="description"
          content={`Automatically generated documentation for ${name}.`}
        />
      </Head>
      <SinglePage
        forceReload={forceReload}
        entrypoint={entrypoint}
        data={data}
        runtimeBuiltinsData={runtimeBuiltinsData}
      />
    </>
  );
};

MyDocumentation.tsx Don't need to call api/docs -> because we already have sample.json file (using "deno doc --json" cli command)
MyDocumentation.tsx -> import jsDocJson from '../assets/data.json'; <-- this "data.json" is same file your "sample.json"

we direct provide "sample.json" data~

(5) npm run dev (local develop mode next.js project(doc_website) running!)
(6) access browser (http://localhost:3000/mydoc/sample), you can see your sample doc~!!!!!

FYI new doc website is being worked on that will allow to easily deploy it yourself. Expect announcement in the coming weeks.

@bartlomieju
oh! nice news! I expected this week's announcement.


Equation rendering in HTML Help pages

Is your feature request related to a problem? Please describe.
R 4.2 added support for HTML5 in help pages: https://www.r-bloggers.com/2022/04/new-features-in-r-4-2-0/
Many of the features described above are working in VS Code (e.g., the Run Examples button, syntax highlighting), but equations are not being rendered correctly. R 4.2 supports either KaTeX or mathjaxr to render equations in help files such as in ?rnorm.
Describe the solution you'd like
Is it possible to make either katex (preferably) or mathjaxr available to render the equations in VS Code? VS Code ships with built-in KaTeX support for Markdown (https://code.visualstudio.com/updates/v1_58#_math-formula-rendering-in-the-markdown-preview), so it seems like it should be possible to enable for R help files.

Thanks for bringing this up. It would be quite nice if we could make it work in help pages.
@ManuelHentschel It looks like katex resources are blocked in the webview.

Is it possible we could somehow make it work in the webview?


Renamed VEL to ACC in instance file to match domain and prevent issues

That indeed looks like a bug, albeit a minor one since we set the values in the instance to their default anyways (so those lines are strictly not needed). Thanks for pointing it out though, and if you come across any other bugs, please let us know!

For undefined pvariables initialized in the instance, I think we actually want to handle this more elegantly in the future by raising a warning.

That indeed looks like a bug, albeit a minor one since we set the values in the instance to their default anyways (so those lines are strictly not needed). Thanks for pointing it out though, and if you come across any other bugs, please let us know!

Sure, will test it out and let you know. I'm looking forward to work more towards the UAV trajectory planning and if you guys have more examples in RDDL that is somehow related to UAV Trajectory planning or UAV inspection, please let me know so it would be useful for my thesis work.


npm and rnpm commands from generator

Some components will require to install a npm packages and native dependencies.  We'll need to install the dependencies on the fly when running the generator.

This is implemented here: https://github.com/thebakeryio/baker/pull/10


Run benchmarks in Continuous Integration

The package PkgBenchmark provides a tool for generating a benchmark report and comparing the performance between different commits. But it can only be viewed locally. I have found a package named BenchmarkCI, which can run benchmark in ci and upload a report by the form of comment. The question is that the package is still experimental, shall we use it?

I haven't used this. But since it depends on PkgBenchmarks, we can still
add the test suite for PkgBenchmarks first.
Check if it's a registered package. We want to have dependencies on
registered pkgs only. If it's not registered, maybe check what's been used
by other pkgs, e.g. Makie. I know they recently added a similar profiling
report in PR.
On Wed, Jul 13, 2022, 7:56 AM TianCheng Liu @.***>
wrote:

The package PkgBenchmark provides a tool for generating a benchmark
report and comparing the performance between different commits. But it can
only be viewed locally. I have found a package named BenchmarkCI
https://github.com/tkf/BenchmarkCI.jl, which can run benchmark in ci
and upload a report by the form of comment. The question is that the
package is still experimental, shall we use it?
—
Reply to this email directly, view it on GitHub
https://github.com/henry2004y/TestParticle.jl/issues/26, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEZN3YCAHCR26P3POFUOE6LVTZD7FANCNFSM53NK2YAQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I haven't used this. But since it depends on PkgBenchmarks, we can still add the test suite for PkgBenchmarks first. Check if it's a registered package. We want to have dependencies on registered pkgs only. If it's not registered, maybe check what's been used by other pkgs, e.g. Makie. I know they recently added a similar profiling report in PR.

I have checked the benchmark report and scripts of Makie, the script just contains BenchmarkTools and does not use PkgBenchmark or other benchmark packages. The profiling report in PR is upload by a bot named Makiebot. I don't know more details about this bot, but the format of these reports is prescribed in the benchmark script.
And BenchmarkCI is a registered package.

Then give it a try? If the CI part is not working, it's fine. Profiling is tricky in general: GitHub-hosted servers are not guaranteed to have the same hardwires all the time. The goal here is to first have a benchmark suite for checking performance regression.


[CLOSED] Publish schemas to content store

 Issue by tommyp
Monday 05 January 2015 at 14:33 GMT
Originally opened as https://github.com/alphagov/specialist-publisher/pull/369

As we want to remove Finder API from the stack we needed to find some other way of publishing Finders to the Content Store. Placing them into Specialist Publisher seemed like the most natural approach so this PR takes the steps required for this to happen. The following is contained within this PR:

Move the schemas and metadata from Finder API to a /finders folder and remove the old schemas
Change the file paths in the Wiring
Treat old style single select values as multi select
Add presenters for Finder Content Items
Add a publishing_api_finder_publisher class
Add a rake task to publish the Finders
Explain new finders and presenters folders in README

tommyp included the following code: https://github.com/alphagov/specialist-publisher/pull/369/commits

 Comment by tommyp
Monday 05 January 2015 at 17:35 GMT

Amended based on @evilstreak's comments. We now use the file modified time as the timestamp for the content item.


Update create-cluster-portal.md

I'm contributing specific steps to create a utility VM (Linux) to interact with the cluster

@bureado : Thanks for your contribution! The author(s) have been notified to review your proposed change.

also @SnehaGunda

LGTM. One comment: we specified JDK v8 because Cassandra stress does not work with a higher version. Unless you know a way around that, please revert. Otherwise, thank you for the great contribution!

p.s. note the exact same instructions are duplicated in create-cluster-cli.md and configure-hybrid-cluster.md. If you are willing to upgrade those in the same fashion, that would be great!

Closing/reopening to test diff view (currently showing as binary).

Hi @bureado - The MD file is in binary format in the pull request.

It's unusual to see, but apparently some content editors generate UTF-16 files by default. Git treats these files as binary by default. The file should be converted to UTF-8 format. This can be done in Visual Studio. Could you do this and try another pull request? We’ll close this one, because the MD file can’t be merged into the repo in this format. You can reach out for assistance to the Docs Support channel on Teams, if needed.

@ktoliver Interesting. I'll try. This was via GitHub's native "Edit".
@TheovanKraay OpenJDK 8 should be doable via https://adoptopenjdk.net/installation.html?variant=openjdk8&jvmVariant=hotspot#linux-pkg - I'll work on it.

@ktoliver Kristine Toliver (Aquent LLC) Vendor Interesting. I'll try. This was via GitHub's native "Edit".

@bureado Hmm, sounds like a bug. Let me talk more about it with the PR review lead. We might need to open a bug fix request. Thanks for letting me know.

@bureado Let me talk more about it with the PR review lead. We might need to open a bug fix request. Thanks for letting me know.

@bureado What browser did you use to edit the file?

@bureado We've discovered the issue. I've applied a fix in the private repo. I expect it to be synced to the public repo in the next hour. Could you resubmit your revision when you have a chance after that, if you still need to? Thanks.


Is S3Client thread safe?

Or should I create one for each thread?
If I use one S3Client object to send multiple requests, will we reuse the tcp connection underlying?
Thanks,

Yes it's thread safe.
Yes it uses a connection pool per client.

Is the instance of AmazonS3 thread safe here:
AmazonS3ClientBuilder
.standard()
.withEndpointConfiguration(new AmazonS3 s3Client = AwsClientBuilder.EndpointConfiguration(s3Config.getEndpoint(), s3Config.getRegion()))
.withPathStyleAccessEnabled(true)
.withClientConfiguration(clientConfiguration)
.withCredentials(new AWSStaticCredentialsProvider(credentials))
.build();


Execute drawAll function only once

BEGINRELEASENOTES

After taking a closer look at main.js, I've noticed that when an event is visualized, drawAll function runs twice without an apparent reason: once in the event listener, and a second time inside setTimeOut function. When start is called, it calls drawAll already. So I think that we can remove this.
The removal of setTimeOut will give a cleaner and faster experience when initially loading an event.

ENDRELEASENOTES

The drawAll() was there twice as a quick fix, because the latex particle names were not properly displayed. Not it works!


BrokenProcessPool

What version of fMRIPrep are you using? 2.2.0
What kind of installation are you using? docker
What is the exact command-line you used?
 fmriprep-docker ds001168-download/ ds001168-download-derivative/ participant --participant_label sub-01  --skip-bids-validation --fs-no-reconall --fs-license-file /Applications/freesurfer/7.1.1/licence.txt

Have you checked that your inputs are BIDS valid? No
Can you find some traces of the error reported in the visual report (at the bottom) or in crashfiles?
201111-22:14:10,109 nipype.workflow INFO:
[Node] Running "bold_to_std_transform" ("niworkflows.interfaces.itk.MultiApplyTransforms")
exception calling callback for <Future at 0x7f04deed4cc0 state=finished raised BrokenProcessPool>
Traceback (most recent call last):
File "/usr/local/miniconda/lib/python3.7/concurrent/futures/_base.py", line 324, in _invoke_callbacks
callback(self)
File "/usr/local/miniconda/lib/python3.7/site-packages/nipype/pipeline/plugins/multiproc.py", line 159, in _async_callback
result = args.result()
File "/usr/local/miniconda/lib/python3.7/concurrent/futures/_base.py", line 425, in result
return self.__get_result()
File "/usr/local/miniconda/lib/python3.7/concurrent/futures/_base.py", line 384, in __get_result
raise self._exception
concurrent.futures.process.BrokenProcessPool: A process in the process pool was terminated abruptly while the future was running or pending.
exception calling callback for <Future at 0x7f04df2c9c88 state=finished raised BrokenProcessPool>
Traceback (most recent call last):
File "/usr/local/miniconda/lib/python3.7/concurrent/futures/_base.py", line 324, in _invoke_callbacks
callback(self)
File "/usr/local/miniconda/lib/python3.7/site-packages/nipype/pipeline/plugins/multiproc.py", line 159, in _async_callback
result = args.result()
File "/usr/local/miniconda/lib/python3.7/concurrent/futures/_base.py", line 425, in result
return self.__get_result()
File "/usr/local/miniconda/lib/python3.7/concurrent/futures/_base.py", line 384, in __get_result
raise self._exception
File "/usr/local/miniconda/lib/python3.7/concurrent/futures/_base.py", line 324, in _invoke_callbacks
callback(self)
File "/usr/local/miniconda/lib/python3.7/site-packages/nipype/pipeline/plugins/multiproc.py", line 159, in _async_callback
result = args.result()
File "/usr/local/miniconda/lib/python3.7/concurrent/futures/_base.py", line 425, in result
return self.__get_result()
File "/usr/local/miniconda/lib/python3.7/concurrent/futures/_base.py", line 384, in __get_result
raise self._exception
concurrent.futures.process.BrokenProcessPool: A process in the process pool was terminated abruptly while the future was running or pending.

Check out the FAQ post on this issue, with many potential solutions:
https://fmriprep.org/en/stable/faq.html#my-fmriprep-run-is-hanging


Add an API to set FPU access mode

@homunkulus r+

:pushpin: Commit 0e3dd2d has been approved by japaric

:hourglass: Testing commit 0e3dd2d with merge 0e3dd2d...

:sunny: Test successful - status-travis
Approved by: japaric
Pushing 0e3dd2df58e52f9af80e47327a62a83511e010f9 to master...


list_indices and fetch_index implemented

I made a suggestion on how to implement

list_indices()
fetch_index()

There is certainly room for improvement, but we can use it as basis for further discussion.

@DanielaSchacherer to help take care of the CI issues, you can install pre-commit hooks with pre-commit install in the repo folder. This will apply those checks and auto-corrections every time you try to commit locally, so you do not need to wait to see what happens with CI.

Daniela, you didn't need to close the PR - all of those issues can be resolved by subsequent commits.

@DanielaSchacherer also here's a useful hint - if you are working on a PR and want to mark it as not ready for review, you can set it to "Draft" status - upper right corner of the page "Convert to draft" link.

Okay, sorry. I am not yet very familiar with CI tools in Github.
Very useful tipps! Thanks!

Comment: test will follow.
Note: I experienced a problem with accessing github assets, as there appears to be an API limit (error 403).
Also as a note: I changed the code to only consider parquet files, instead of parquet and csv. Is that alright?

Note: I experienced a problem with accessing github assets, as there appears to be an API limit (error 403). That's why one of the test fails.

There is a limit of 60 requests per hour.
https://docs.github.com/en/rest/using-the-rest-api/rate-limits-for-the-rest-api?apiVersion=2022-11-28#primary-rate-limit-for-unauthenticated-users

Also as a note: I changed the code to only consider parquet files, instead of parquet and csv. Is that alright?

CSV is too inefficient to revert to. Currently, all indices are generated in the parquet file format only.

Definitely, no need to consider CSV.

I believe it is failing because you are trying to access sm_index, which is indeed not installed. idc-index currently depends on idc-index-data, and specifically on version 18.0.1 of the latter, which does not contain sm_index release attachment. It was added in 18.1.0.

I think you are right. Additionally, I encountered some API limits before when using specifically the latest idc-index-data version. I am trying to reproduce it now.

I am also now questioning whether we should install all of the parquet attachments blindly. If we do that, we need to think how to communicate the descriptions. It might be more practical to hard-code installation of the additional indices. It might be easier this way to explain to the users what they are.

I am not concerned so much about whether we download all parquet attachments blindly or on user's request. I am struggling more with how to explain available indices and their use (especially, which one is used when calling a function).
Regarding what you said in Slack:

I don't recall when the decision to download all assets was made.
Did we make that decision at all? I thought we made the decision to download them by request? But as said above, in either case we will need good descriptions on the intended use and I am not sure how to do that.

Did we make that decision at all? I thought we made the decision to download them by request?

Sorry, I was not precise. What I meant is that right now the availability of indices is discovered on the fly by examining all release attachments that match a pattern. An alternative to this could be maintaining a list of known indices within the package, and interacting with GitHub only to retrieve (but not to discover) extra indices. Let's meet to discuss this @DanielaSchacherer.

Looking at the CI logs, it is error 403
INFO     idc_index.index:index.py:183 Fetching the list of indices from idc-index-data 18.1.0 release.
ERROR    idc_index.index:index.py:199 Failed to fetch releases: 403

At this point, I would just switch to the fixed list of external indices. I personally do not see the value in debugging this. I would do that independently from this error.

@fedorov I'll give it a last try, but you are probably right.

@DanielaSchacherer I forgot to mention it earlier, but I noticed you are working in the main branch of your fork. This, in my experience, is not a good idea, since usually you would want the main branch of your fork to track main upstream. This also creates challenges for collaborators, since they would need to deal with two main branches - yours and upstream.
Next time, I recommend you first make a dedicated branch for your PR.
This and earlier issues motivated me to add contribution guidelines to the repo - if you see anything missing there, please let me know: https://github.com/ImagingDataCommons/idc-index/blob/main/CONTRIBUTING.md.

@DanielaSchacherer I resolved the conflicts locally, and rebased to the current main branch. I have no idea why the author has changed. I also have no idea why the tests are now failing .... To be safe, I copied your main branch here so you can compare the content: https://github.com/fedorov/idc-index/tree/100-main-daniela-backup.
Maybe you can take a look first, and then I will continue with my review? Or you can make a separate from main branch, we can close this PR and open a new one, if we think it will take some more time to iterate on this...
Sorry for not providing the guidance how to set up dev process from the start. This contributed a lot to the current confusion...

I also have no idea why the tests are now failing

The tests are failing because.. the url is not correct.
If we are hardcoding the urls..there is no need to use API anymore..
we need to modify..
asset_endpoint_url to
https://github.com/ImagingDataCommons/idc-index-data/releases/download/{idc_index_data.__version__}
https://api.github.com/repos/ImagingDataCommons/idc-index-data/releases/tags/18.0.1

I also have no idea why the tests are now failing

What I meant to say is that I could not explain how the tests were succeeding before I resolved the conflict, but are failing now. Perhaps I messed something up while resolving the conflicts, and maybe that is the API URL. I was thinking Daniela would be best to review and confirm. I admit I did not have the time to actually review this PR.

We are still missing descriptions of the indices. Is that something we should target here or does it make sense to have a separate PR for that?

I will take a shot at that as part of my review!

@DanielaSchacherer I guess I lost track of the original purpose of this PR while reviewing yesterday. Are you planning to update the API to allow download of the instances based on the instance index as part of this PR?

@fedorov For that very reason, I would prefer to later make a new PR for this and for now continue the discussion that we started in https://github.com/ImagingDataCommons/idc-index/issues/97.


Leave open

Add a tool to check if some bugs are closed although leave-open keyword is here

Coverage decreased (-2.5%) to 50.188% when pulling 29c32b88087bf04672513a313901026dc8e9280b on calixteman:leave_open into d583183f6f7f29a38f3bb0feff933ba67f45c12a on mozilla:master.


avoid incoming breakage of for<'a> &'a T: 'a bounds

https://github.com/rust-lang/rust/pull/98109 fixes a soundness hole in rust. Unfortunately, this fix exposes an other known bug in reasoning about bounds of the form for<'a> &'a T: 'a. This bug can be illustrated in the following example which is rejected since v1.0!
fn require_bound<T>()
where
    for<'a> &'a T: 'a,
    // T: 'static // <- rustc incorrectly thinks it must prove this bound for the above bound to hold.
{
}

fn test<T>() {
    require_bound::<T>();
    //^ ERROR  type parameter T doesn't live long enough
}

One way to work around such bug is to simply remove the bound since it is always satisfied for any type T.
We tried to fix this in a timely manner, but it's not a particularly easy problem. Indeed it is part of a long-term initiative under the name of "implied bounds" to better support these bounds. Sorry for any inconvenience!

Confirmed locally and merged; Thank you for your contribution.

I'll note that #3 covered a bound missed by this PR on line 241. I'll be partially merging that as well. Following that, I will be publishing an update to a more-recent Rust version, which will set this in stone.


[SPO, SITE] Two bugs in running through relabeling process

No refresh once relabeling is requested.

Several times trying to block the kit with no success. The status is changed only after a hard refresh.

Point 1 remains (No refresh once relabeling is requested).

I am going to close this issue as point 1 is reported in #769


Not able to run release build

Discussed in https://github.com/callstack/repack/discussions/811

Originally posted by har2008preet December  6, 2024
Hi,
I can create and run my host application which is using modules via ScriptManager, but when i create release build, it is crashing on start with error ReferenceError: Property 'webpack_require' doesn't exist. I have already included export BUNDLE_COMMAND=webpack-bundle, but i think it is using metro to create release bundle.
How can i confirm it what it is using to create bundle and how to resolve it?

Closing this issue since it's a duplicate of the discussion and this is not following the template


Add mercurius fastify example

Fastify should be faster than express, its also gaining popularity lately.
https://www.fastify.io/benchmarks/

LGTM. Only if you don't mind: Could we use es6 imports instead of commonjs?

I'll take care of it


Update cmdlet-property-sets.md

Property Sets are not implemented for Get-MobileDeviceStatistics yet.

Docs Build status updates of commit 913db69:
:clock10: Full build: the average full build time is 11 min(s) 46 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 913db69:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/docs-conceptual/exchange-online/exchange-online-powershell-v2/cmdlet-property-sets.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 3e32296:
:clock10: Full build: the average full build time is 11 min(s) 46 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 3e32296:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/docs-conceptual/exchange-online/exchange-online-powershell-v2/cmdlet-property-sets.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.