Faster BoolReader

Moved BoolReader to its own file.
It now reads from the buffer in chunks of 4 bytes at a time, except for the final 0-3 bytes.
Optimize successive calls to read_bool and read_with_tree by assuming none of them reach the end of the buffer and returning a transparent BitResult, then validating at the end.
Optimize each individual call to read_bool and read_with_tree by assuming each bit can be read from the 4-byte chunks (in FastReader), and retrying with the slow approach if this fails.

Final performance results are a 1.3x speedup compared to image-rs 0.2.0 (--use-reference), although it is still 1.3x slower than libwebp:

Summary
'dwebp -noasm -nofancy Puente.webp' ran
1.00 ± 0.01 times faster than 'dwebp -noasm -nofancy Puente.webp'
1.31 ± 0.01 times faster than 'target/release/image-webp-runner Puente.webp'
1.69 ± 0.01 times faster than 'target/release/image-webp-runner Puente.webp --use-reference'

(I ran dwebp as the first and the last candidate to negate any effects from my poor laptop's CPU overheating.)
This uses as_flattened_mut() which was stabilized in 1.80.0, so merging this probably requires raising the MSRV. I don't know your policy on that, but the alternative was adding unsafe or adding another dependency (that itself uses unsafe), so I left it as is.
PS:

I thought about extending the buffer with a few zero bytes so that everything can be read with the FastReader, but I don't think it would help much, and it might worst-case require reallocating the buffer.
read_literal has some obvious optimizations but it doesn't seem part of the latency critical path.
There might be an optimization in read_flag's 1  + ((range - 1) * 128) >> 8) but it seems hard to measure.
I think further optimizations to other parts of the decoding might push us to be faster than libwebp's performance.
I tried my hand at coaxing the compiler to apply SIMD to src/transform.rs, but it was very dependent on preventing function inlining, and ultimately I didn't get any noticable performance gains yet. I might try again later and create a separate PR.

transform.rs is used only for lossless images, so changing anything there won't affect lossy ones. You can create a lossless image with convert -quality 100 input.png output.webp and verify with webpinfo that the file is indeed lossless.
That said, lossless WebP is already plenty fast specifically due to optimizations to transforms. We actually beat dwebp -noasm in my tests, although dwebp when allowed to use handwritten assembly still beats us by 7% to 15% on lossless images.

Regarding bit reading: libwebp has a dedicated codepath for reading with probability 128 that is distinct from the general-purpose one. Is that something that you've explored?
If you haven't attempted it, it doesn't have to be a part of this PR. I just wanted to know if this has been attempted or not.
I would expect this not to matter if the hot variant of read_bool gets inlined anyway - the constant propagation should probably take care of it.

transform.rs is used only for lossless images, so changing anything there won't affect lossy ones.

Huh are you sure? I only mentioned it because idct4x4 showed up as 8% of the runtime in callgrind when running against the Puenta image. I did some optimizations that involved renaming that function and the new function was 7.5% or something like that, but anyway not enough to be measurable.
Not denying that it's already plenty fast, just that I'm certain it showed up in my call graphs inside read_coefficients().

Regarding bit reading: libwebp has a dedicated codepath for reading with probability 128 that is distinct from the general-purpose one. Is that something that you've explored?
If you haven't attempted it, it doesn't have to be a part of this PR. I just wanted to know if this has been attempted or not.
I would expect this not to matter if the hot variant of read_bool gets inlined anyway - the constant propagation should probably take care of it.

Yes that's the read_flag optimization I mentioned in the PR. I didn't end up doing it, and in fact the way I have the inlining set up it actually prevents the compiler from doing any special optimizations for the 128 case. That's because too much inlining/specialization seemed to make everything 20% slower, which I theorize to be because of instruction cache misses.
But indeed, that's something that can be revisited in a separate PR.

transform.rs is for lossy images while lossless_transform.rs is for lossless images.
It might be worth renaming "bool reader" to "arithmetic decoder" or something to that effect, because it is doing boolean arithmetic coding rather than simply reading bits.

FWIW there is no change on end-to-end benchmarks for the large image on my machine from the FastReader::read_flag optimization. It's possible that it helps other machines, just not mine.

I can confirm this didn't break anything :tada:
No behavioral changes before and after on my corpus of 7,500 images scraped from the web.


:bug: Omitted logs in release mode

This PR makes sure logs are omitted in release mode. Based on the logger's recommendation

I did a reimplementation of the filter class

This has been fixed in the latest package


"no .plot files found" is incorrectly reported when using nested Plot directories

Running Full Node on Windows.  Testing importing plots created on a second machine.  I have 4 plots in 'Data\Chia' and 2 plots in 'Data\Chia\PlotsMadeRemote'.  Log reports 'no .plot files found' in the second directory, but does appear to be loading all 6 plots.
05:35:28.016 harvester src.plotting.plot_tools : INFO     Searching directories ['D:\Data\Chia', 'D:\Data\Chia\PlotsMadeRemote']
05:35:28.018 harvester src.plotting.plot_tools : INFO     Not checking subdirectory D:\Data\Chia\PlotsMadeRemote - no .plot files found
05:35:28.019 harvester src.plotting.plot_tools : INFO     Loaded a total of 6 plots of size 0.019139390178679605 TiB, in 0.022986412048339844 seconds
When I moved the second directory so that it was not a child of the first directory, it's no longer reporting that 'no .plot files found'.

Yeah this is chia-blockchain


Strawberry guid robustness

set guid to string serialization

enhanced UuidSerializer to use Guid.Parse

Closes #3562

Already skimmed through it .... look really good. Thanks for putting the extra effort into this.... will do a more thorough review tomorrow.

/AzurePipelines run

Looks great

I think we can merge this one tomorrow.

/AzurePipelines run

@dmg-hamann great work! Thanks for your help. Once build goes green we will merge.

Awesome. Thanks to you guys for this awesome project :)

If you need the feature in 11.x you can do another pr where you cherrypick this change from develop to main. If not it will be included into the next 12 preview. Thanks again from the help and welcome as a contributor.

Hi,
Just wanted to thank @dmg-hamann for the fix, as I am currently experiencing this issue on 11.3.0 after migrating from 11.0.0-preview.137.
@dmg-hamann, would you be willing to merge this to the master branch as well? I believe many people who use the release versions of StrawberryShake and HotChocolate (ie 11.X) and use Guids in their Apis might currently be experiencing this issue, so you'll probably make a lot of people happy (definitely me!).

@gmiserez Yeah I will cherry pick the changes and setup a pr


exact timing impossible?

as far as i understand is exact timing with xnet impossible because of the min. 5 tick reading. i tried to setup an endergenic generator and i ran into problems. for example you can not use the timer because the timer signal is just one tick an it is a matter of luck if xnet recognize it and so on.
and the real bad thing is in the 1.12 modpacks i know are no other redstone cables as far as i know and setup rftools control for transmitting simple redstonesignals seems a little bit overdone.
a simple redstone chanal like mentioned here would do this i think: https://github.com/McJty/XNet/issues/69

You can use an RFTools Sequencer to turn a 1-tick pulse into a 5-tick pulse.

but what is if you net ticks more exact than 5 ticks? for the setup of an endergenic generator you need 1tick precision.

i found integrated dynamics which is working, but neverteless it would be nice if this works with xnet too.
sidefact: even vanilla redstone catches not every 1tick pulse, redstone lamp do.


GLTFLoader

previous version has supported the glft loader，why it was removed from souce code? Now, how should we add a gltf model?

previous version has supported the glft loader，why it was removed from souce code? Now, how should we add a gltf model?

Use external GLTFLoader
<script<EMAIL_ADDRESS>
Worked for me

previous version has supported the glft loader，why it was removed from souce code? Now, how should we add a gltf model?

Use external GLTFLoader
<script<EMAIL_ADDRESS>
Worked for me

how did you do ti? I want to do the same.

previous version has supported the glft loader，why it was removed from souce code? Now, how should we add a gltf model?

Use external GLTFLoader
<script<EMAIL_ADDRESS>
Worked for me

repackage three projects?


[bug] pdfs arent included in the latest release

The link to pdf from README doesn't work.

Thank you 🙏 the PDF had failed to upload, fixed now.


Fix changelog and issue a proper release

Signed-off-by: Lance Albertson<EMAIL_ADDRESS>Description
Describe what this change achieves
Issues Resolved
List any existing issues this PR resolves
Check List

[ ] A summary of changes made is included in the CHANGELOG under ## Unreleased
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable.

Released as: 5.0.8


Using all 4-cores Raspberry pi

face_recognition version:latest
Python version:3.5
Operating System:Raspbian
I've tried applying multiprocessing on my code to use all cpu cores but it doesn't seem to improve much(or at all). The code takes forever to run and even longer during the recognition. Not sure if I'm doing the multiprocessing wrong. Anybody able to improve this on the raspberry pi?

Maybe you could post the code showing what you already tried?

@soundreactor have you test it on your raspberry now? And how's the result and speed?

i have only tried it on my mac mini with i7. and the speed increases dramatically.

On Feb 11, 2018, at 11:35 AM, bincheng.xiong<EMAIL_ADDRESS>wrote:
@soundreactor https://github.com/soundreactor have you test it on your raspberry now? And how's the result and speed?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/ageitgey/face_recognition/issues/264#issuecomment-364741133, or mute the thread https://github.com/notifications/unsubscribe-auth/AEJq3yO6Xh1tWmwRl_FQkgQF78eU_TPBks5tTsJtgaJpZM4Q_ETF.

@soundreactor Thanks for your reply. Just like the answer you passed to me said,do not use pip install dlib,so I compile my dlib from src code,but when I install the face_recognition using pip install face_recognition command,it uninstall the dilb I installed before and use pip install dlib automaticly .So do you know how to avoid this ?I mean using my own compiled dlib instead of the pip version?

now leave face recognition installed and just uninstall dlib and compile dlib again. because you have face recognition installed already you don't have to re-install it.

On Feb 11, 2018, at 12:20 PM, bincheng.xiong<EMAIL_ADDRESS>wrote:
@soundreactor https://github.com/soundreactor Thanks for your reply. Just like the answer you passed to me said,do not use pip install dlib,so I compile my dlib from src code,but when I install the face_recognition using pip install face_recognition command,it uninstall the dilb I installed before and use pip install dlib automaticly .So do you know how to avoid this ?I mean using my own compiled dlib instead of the pip version?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/ageitgey/face_recognition/issues/264#issuecomment-364743828, or mute the thread https://github.com/notifications/unsubscribe-auth/AEJq3_xIaO9FAI1C4gANwWxbcmd7fTyGks5tTsz_gaJpZM4Q_ETF.

@I just did as what you said before I recive your reply.But I didn't uninstall the dlib using pip,I compile the dlib src code and install it to /usr/local/lib/python2.7/...directory ,and change the env path PYTHONPATH to make the python find the dlib I compiled ahead of the pip version.But it seems that the face_recognition pack don't support this version and report some bad infos.

if you only import dlib. does it work or crash.?

On Feb 11, 2018, at 12:40 PM, bincheng.xiong<EMAIL_ADDRESS>wrote:
@i https://github.com/i just did as what you said before I recive your reply.But I didn't uninstall the dlib using pip,I compile the dlib src code and install it to /usr/local/lib/python2.7/...directory ,and change the env path PYTHONPATH to make the python find the dlib I compiled ahead of the pip version.But it seems that the face_recognition pack don't support this version and report some bad infos.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/ageitgey/face_recognition/issues/264#issuecomment-364745084, or mute the thread https://github.com/notifications/unsubscribe-auth/AEJq3wravhqfRxzgA59dssa3j3bgVDSbks5tTtGkgaJpZM4Q_ETF.

it's not crash


Cannot use the null byte (\0) as delimiter in tcp input plugin.

fluentd or td-agent version.
fluentd v0.12.29

Environment information, e.g. OS.
macOS sierra + docker (dockerized fluentd using alpine linux)
But I figure this issue does not matter with environment.

Your configuration

<source>
  @type tcp

  tag log
  keep_time_key true
  delimiter "\0"
  port 5170
  bind <IP_ADDRESS>
  format none
</source>

The important part in my configuration is delimiter. I just wanted to use the null byte ("\0" in ruby) as my delimter of tcp input.

Your problem explanation. If you have an error logs, write it together.

Error logs
/opt/ruby/lib/ruby/gems/2.2.0/gems/fluentd-0.12.29/lib/fluent/config/basic_parser.rb:92:in `parse_error!': unexpected back-slash escape character '0' at fluentd.conf line 18,15 (Fluent::ConfigParseError)
 17:   keep_time_key true
 18:   delimiter "\0"

     ---------------^
 19:   port 5170
	from /opt/ruby/lib/ruby/gems/2.2.0/gems/fluentd-0.12.29/lib/fluent/config/literal_parser.rb:185:in `eval_escape_char'
	from /opt/ruby/lib/ruby/gems/2.2.0/gems/fluentd-0.12.29/lib/fluent/config/literal_parser.rb:90:in `scan_double_quoted_string'
	from /opt/ruby/lib/ruby/gems/2.2.0/gems/fluentd-0.12.29/lib/fluent/config/literal_parser.rb:71:in `scan_string'
	from /opt/ruby/lib/ruby/gems/2.2.0/gems/fluentd-0.12.29/lib/fluent/config/literal_parser.rb:64:in `parse_literal'
	from /opt/ruby/lib/ruby/gems/2.2.0/gems/fluentd-0.12.29/lib/fluent/config/v1_parser.rb:130:in `parse_element'
	from /opt/ruby/lib/ruby/gems/2.2.0/gems/fluentd-0.12.29/lib/fluent/config/v1_parser.rb:95:in `parse_element'
	from /opt/ruby/lib/ruby/gems/2.2.0/gems/fluentd-0.12.29/lib/fluent/config/v1_parser.rb:43:in `parse!'
	from /opt/ruby/lib/ruby/gems/2.2.0/gems/fluentd-0.12.29/lib/fluent/config/v1_parser.rb:33:in `parse'
	from /opt/ruby/lib/ruby/gems/2.2.0/gems/fluentd-0.12.29/lib/fluent/config.rb:30:in `parse'
	from /opt/ruby/lib/ruby/gems/2.2.0/gems/fluentd-0.12.29/lib/fluent/supervisor.rb:480:in `read_config'
	from /opt/ruby/lib/ruby/gems/2.2.0/gems/fluentd-0.12.29/lib/fluent/supervisor.rb:144:in `start'
	from /opt/ruby/lib/ruby/gems/2.2.0/gems/fluentd-0.12.29/lib/fluent/command/fluentd.rb:173:in `<top (required)>'
	from /opt/ruby/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /opt/ruby/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /opt/ruby/lib/ruby/gems/2.2.0/gems/fluentd-0.12.29/bin/fluentd:5:in `<top (required)>'
	from /opt/ruby/bin/fluentd:22:in `load'
	from /opt/ruby/bin/fluentd:22:in `<main>'

I figure this is because fluentd does not accept the null byte expression when it tries to parse its configurations. There is code like below in lib/fluentd/config/literal_parser.rb.
      def eval_escape_char(c)
        case c
        when '"'
          '"'
        when "'"
          "'"
        when "r"
          "\r"
        when "n"
          "\n"
        when "t"
          "\t"
        when "f"
          "\f"
        when "b"
          "\b"
        when /[a-zA-Z0-9]/
          parse_error! "unexpected back-slash escape character '#{c}'"
        else  # symbols
          c
        end
      end

The null byte expression ("\0") is declined by the regex /[a-zA-Z0-9]/. Is this intented? Is there way to use the null byte as delimiter of tcp input plugin?

It's just missed, and looks good to add.
@repeatedly how do you think about this?

It seems good.


Add resultBorder prop to Search component

This PR adds one new property to Search:

resultBorder - If true, add a light gray border to each search result rendered.

This adds on to the properties introduced in https://github.com/mapbox/dr-ui/pull/329. This property only introduces a small styling change, so it is not critical to make a release for it soon.
How to test

Run npm start.
Open /Search test cases page.
Scroll to Set resultsOnly to true. test case.
Select an item from the test cases Select element.
Observe that each result has a light gray border.

QA checklist

[ ] No errors logged to console.
[ ] Accessibility score in Chrome DevTools Audit/Lighthouse is 100% with Lighthouse version: #.#.#.
[ ] Component is accessible at mobile-size viewport.
[ ] Component is accessible at tablet-size viewport.
[ ] Component is accessible at laptop-size viewport.
[ ] Component is accessible at big-monitor-size viewport.
[ ] Create a PR in a site repo, copy the component, and test it. Push to staging and let the reviewer know they can also test the component there.

Open the test cases app locally on:

[ ] Chrome, no errors logged to console.
[ ] Firefox, no errors logged to console.
[ ] Safari, no errors logged to console.
[ ] Edge, no errors logged to console.
[ ] IE11, no errors logged to console.
[ ] Mobile Safari, no errors logged to console.
[ ] Android Chrome, no errors logged to console.

@adrianababakanian I think you could achieve this without adding a prop and adding CSS to your local site instead.
For example, if you add a search-results class around your local component, you could then target each result like so:
.search-results ul > div {
    border-top: 1px solid #c6d2e1;
}

Thanks @katydecorah , that's a much better solution! Closing this PR in favor of your suggestion 🙂


Latest scams not being shown on the website

Scams not updated on the website.  Scams.yaml 2841 and above don't appear to be shown on the website, so the website is over a week behind the blacklist.
Reported on twitter, logging as an issue. https://twitter.com/sniko_/status/968650715957735424

@MrLuit Please can you take a look or grant me server access

It was some invalid yaml; fixed in 7f5aae9051708bcd6138e940d3aa51fbbc5e372f. Thanks for reporting 👍


Mop Buckets don't show if they have liquid in them

Description

Before you could see the water in the bucket, now you can't.
Reproduction

Fill up a mop bucket
Screenshots

Additional context

According to git bisect, this issue was introduced in commit 29d7b73da72e066436933f869ff7adbee1d24f45, which seems to be PR #26601.
Haven't decided if I'll try to solve this.


registering an identity on testnet sometimes throws: Invalid Argument: Must provide the scriptPubKey for that output!

During identity registration on testnet I encountered this error:
NodeError {message: 'Invalid Argument: Must provide the scriptPubKey for that output!', stack: 'Invalid Argument: Must provide the scriptPubKey fo…ient/Platform/createAssetLockTransaction.js:5:58)'}

retest passed


Created a test for promises version of fs.unlink()

Created a promises version test for fs.Unlink().
Resolves issue: #444

It looks @jagmeetb has also done basically the same test.  We should discuss how to proceed, and which to land.
Also, this code has a merge conflict with what's on master.  Let's talk about how to fix this in class this week.

I've landed essentially the same code as this in https://github.com/filerjs/filer/commit/1abcb0369b925324599bd7eab8a9d71b31076f7e, closing as dupe.


Tsk 1823

Hi Tim -
This pull request contains all of the suggestions and notes made throughout the review of https://jira.ska-sdp.org/browse/TSK-1823 .
You can either accept the pull request (which will be automatically merged into the master branch) or open dialogue and commentary on the contents of the commits.
As an alternative, you can add my repo as an alternative remote, pull the TSK-1823 branch and cherry-pick specific commits onto your copy of master (that you would then push to remote).
Cheers,
Piers Harding.

On 24 Oct 2017, at 7:11 pm, Piers Harding<EMAIL_ADDRESS>wrote:
Hi Tim -
This pull request contains all of the suggestions and notes made throughout the review of https://jira.ska-sdp.org/browse/TSK-1823 https://jira.ska-sdp.org/browse/TSK-1823 .
You can either accept the pull request (which will be automatically merged into the master branch) or open dialogue and commentary on the contents of the commits.
As an alternative, you can add my repo as an alternative remote, pull the TSK-1823 branch and cherry-pick specific commits onto your copy of master (that you would then push to remote).

I decided to do the latter. I’ve been looking at the commits in detail. The only one that I don’t want to accept in total is the change of kwargs. Your proposed change to image_gather_scatter introduced a regression that wasn’t caught by the test cases.
Other than that, I think I’ll be able to take all of your suggestions. I’m currently working in a branch which I will commit back to the master when I’m convinced that everything is ok.
Cheers,
Tim

Cheers,
Piers Harding.
You can view, comment on, or merge this pull request online at:
https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5 https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5
Commit Summary
TSK-1823: expand docs and script testing
TSK-1823: convert_blockvisibility_to_visibility
TSK-1823: PEP-0008
TSK-1823: silence lint checkers
TSK-1823: fix NotImplemented to NotImplementedError
TSK-1823: fix ambiguous log
TSK-1823: remove redundant redeclaration
TSK-1823: suppress tests under Jenkins/Travis
TSK-1823: fix redeclartions and lint check
TSK-1823: add notebook launcher to make
TSK-1823: lint checking arl/image
TSK-1823: lint checking arl/imaging
TSK-1823: lint checking arl/calibration
TSK-1823: lint checking arl/fourier_transforms
TSK-1823: lint checking arl/graphs
TSK-1823: lint checking arl/imaging
TSK-1823: lint checking arl/pipelines
TSK-1823: lint checking arl/skycomponent
TSK-1823: lint checking arl/util
TSK-1823: lint checking arl/visibility
TSK-1823: lint checking arl/
TSK-1823: lint checking tests/
TSK-1823: lint checking
TSK-1823: fix lint checks
TSK-1823: remove kwargs references
TSK-1823: add example Docker container support
TSK-1823: add Docker documentation
TSK-1823: rejig Docker build
TSK-1823: add Docker Swarm instructions
TSK-1823: Dask workers require arl/data
TSK-1823: a Jupyter notebook extensions
TSK-1823: Deploy Dask cluster using Docker
TSK-1823: swap type() for isinstance()
File Changes
A .dockerignore https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-0 (57)
M .gitignore https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-1 (4)
A Dockerfile https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-2 (81)
A Makefile https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-3 (119)
M README.md https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-4 (254)
M arl/init.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-5 (4)
M arl/calibration/calibration.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-6 (20)
M arl/calibration/operations.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-7 (10)
M arl/calibration/peeling.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-8 (7)
M arl/calibration/solvers.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-9 (34)
M arl/data/data_models.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-10 (248)
M arl/data/parameters.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-11 (18)
M arl/data/persist.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-12 (2)
M arl/data/polarisation.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-13 (69)
M arl/fourier_transforms/init.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-14 (2)
M arl/fourier_transforms/convolutional_gridding.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-15 (33)
M arl/fourier_transforms/fft_support.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-16 (5)
M arl/graphs/dask_init.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-17 (14)
M arl/graphs/dask_minimal.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-18 (2)
M arl/graphs/generic_graphs.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-19 (9)
M arl/graphs/graphs.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-20 (20)
M arl/graphs/vis.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-21 (8)
M arl/image/cleaners.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-22 (160)
M arl/image/deconvolution.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-23 (20)
M arl/image/gather_scatter.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-24 (14)
M arl/image/iterators.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-25 (17)
M arl/image/operations.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-26 (108)
M arl/image/solvers.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-27 (1)
M arl/imaging/base.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-28 (37)
M arl/imaging/facets_wprojection.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-29 (12)
M arl/imaging/facets_wstack.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-30 (10)
M arl/imaging/iterated.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-31 (5)
M arl/imaging/params.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-32 (47)
M arl/imaging/timeslice.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-33 (29)
M arl/imaging/weighting.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-34 (21)
M arl/imaging/wprojection.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-35 (2)
M arl/imaging/wprojection_wstack.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-36 (3)
M arl/imaging/wstack.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-37 (19)
M arl/pipelines/distributed_setup.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-38 (2)
M arl/pipelines/graphs.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-39 (1)
M arl/pipelines/support.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-40 (2)
M arl/skycomponent/operations.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-41 (99)
M arl/util/coordinate_support.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-42 (2)
M arl/util/graph_support.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-43 (76)
M arl/util/primary_beams.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-44 (7)
M arl/util/run_unittests.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-45 (1)
M arl/util/testing_support.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-46 (51)
M arl/util/timing.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-47 (3)
M arl/visibility/init.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-48 (2)
M arl/visibility/base.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-49 (82)
M arl/visibility/coalesce.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-50 (122)
M arl/visibility/gather_scatter.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-51 (10)
M arl/visibility/iterators.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-52 (6)
M arl/visibility/operations.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-53 (8)
A docker/boot.sh https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-54 (5)
M examples/performance/pipelines-timings-analyse.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-55 (3)
M requirements.txt https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-56 (1)
M tests/test_array_functions.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-57 (23)
M tests/test_calibration_operations.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-58 (28)
M tests/test_calibration_peeling.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-59 (10)
M tests/test_calibration_solvers.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-60 (37)
M tests/test_convolutional_gridding.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-61 (21)
M tests/test_fft_support.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-62 (4)
M tests/test_generic_graph.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-63 (27)
M tests/test_graph_support.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-64 (29)
M tests/test_graphs.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-65 (55)
M tests/test_image_deconvolution.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-66 (19)
M tests/test_image_msclean.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-67 (4)
M tests/test_image_operations.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-68 (50)
M tests/test_image_solvers.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-69 (20)
M tests/test_imaging.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-70 (21)
M tests/test_imaging_params.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-71 (17)
M tests/test_parameters.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-72 (5)
M tests/test_pipelines.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-73 (14)
M tests/test_polarisation.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-74 (27)
M tests/test_quality_assessment.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-75 (6)
M tests/test_skycomponent.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-76 (8)
M tests/test_visibility_coalesce.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-77 (5)
M tests/test_visibility_gather_scatter.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-78 (16)
M tests/test_visibility_operations.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-79 (36)
M tests/test_weighting.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-80 (17)
A tools/README.md https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-81 (17)
A tools/ansible.cfg https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-82 (243)
A tools/docker.yml https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-83 (73)
A tools/inventory/docker https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-84 (13)
A tools/inventory/group_vars/all https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-85 (4)
A tools/ssh.config https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-86 (39)
M util/read_oskar_vis.py https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5/files#diff-87 (5)
Patch Links:
https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5.patch https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5.patch
https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5.diff https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/5, or mute the thread https://github.com/notifications/unsubscribe-auth/ADv3XY05ATWUb79WihTrktWLlZqqEoQ6ks5svihHgaJpZM4QE3I2.

Great -  I should have said that all the test and lint checking runs clean as per the process defined in the Makefile.
Cheers,
Piers.


Fix issue with array checking when no array present.

The introduction of issync? in the sensu_check type for the handlers and dependencies properties introduced an assumption that the values sourced are always arrays, yet :array_matching is set.
In the event that an empty array is passed to the property within Puppet, Puppet will match this against an non-existing (nil) value and so will not write out the key/value pair on flush. When re-reading the file to analyze for changes, a nil value is loaded in return, but a NilClass has no sort method and so compilation of the catalog fails.
This change sets the defaults within the type's JSON provider to always return an empty array unless something else is configured, preventing the issync? method from raising an exception on NilClasses.

Thanks!


🚀 [New Feature_LP] - Adding a custom Scroll Bar.

Description of the enhancement. ✍🏻
Adding a custom scroll bar will make the webpage look appealing because it looks odd when the browser's default scroll bar are seen.
Describe briefly how you would implement this enhancement.
Some steps to implement this enhancement-
1. Step 1: Grabbing the scroll bar.
2. Step 2: Adding suitable css or scss to make the desired changes.
3. Step 3: Making a pr.

Screenshots Example (if applicable)
No response
Additional information
No response
Contributor terms

[X] I agree to follow the Contributing Instructions

I request to assign me this issue.


High value reaction role not being applied correctly

Currently if a user gets reactions in the form of multiple different emotes they do not get the high value role once they reach a total of 5 reactions. They will only receive the role if they receive a total of 5 from the same exact reaction emote.
Related doc to this: https://discordjs.guide/popular-topics/reactions.html#listening-for-reactions-on-old-messages
console.log(`${reaction.count} user(s) have given the same reaction to this message!`);

Note how it says "given the same reaction to this message"

Good spot 👍 . Great issue with the link to the docs and pulling out the relevant parts 🤓

PR merged 👍


Improvements

Really cool job @marpri-17 !!!
Here you have some tips to improve the exercise:
JavaScript

Woooooooooowwwwww!!!! https://github.com/Adalab/m2-evaluacion-intermedia-marpri-17/blob/master/_src/assets/js/main.js#L15
[x] You could do this in one statement: https://github.com/Adalab/m2-evaluacion-intermedia-marpri-17/blob/master/_src/assets/js/main.js#L23-L24

Advanced

[x] Move the feedback logic to a function an execute it on each click
[x] You are writing many times "trackEl.innerHTML = 'something';", what about making a function that accepts a string as param and paints it into 'trackEl'?

Steps to finish the game (for those far from the solution)
You are close to the exercise solution, but here you have a steps guide to complete it anyway ;)

Save a reference to DOM elements in variables
Generate the random number and save it to a variable
Init counter of trials to 0
Define a function that executes when the user clicks on the button, that

increments the counter and paints its value in the HTML
collect the value of the HTML input and compare it with the random number

if they are equal, draw a 'You Win' message
if it's lower, draw a 'Too short' message
if it's higher, draw a 'Too long' message

Assign a listener to the button click to execute the previous function

Further challenges
Then you can improve the game as you please, here you have some ideas:

Add new feedback when the number is bigger than 100 or smaller than 0.
Manage when the user hits the button and the input is empty.
Make the input work when hitting enter key.
Add a reset button that cleans the input, the counter, writes the initial feedback and generates a new random number to play again!
Whatever you want!

Let me know if you have any doubts ;)
Go for it!!

All fixed! I really enjoy the exercise. I want to improve it adding some extra motivation. I encourage all of u to try for figure out what the price is! :scream:


Interpretation of the results

Hey
I have read the MAML paper a few times already, and i have ran the code in this repo over miniImageNet (classification task), I was trying to get the same results in the few shot scenario 1 and 5, in both i couldn't get the same results (as in the paper) and i wonder if maybe i don't know how to read the results?
I used this repo to get the dataset: https://github.com/yaoyao-liu/mini-imagenet-tools
5 Shot case:
Mean validation accuracy/loss, stddev, and confidence intervals
(array([0.20673339, 0.25913334, 0.2700002 , 0.28293344, 0.29920024,
       0.32380033, 0.34480017, 0.36266708, 0.36813366, 0.36946717,
       0.37060046], dtype=float32),
array([0.07652438, 0.07922475, 0.07856207, 0.08520987, 0.09059452,
       0.09908354, 0.10491098, 0.10670018, 0.10576959, 0.10661323,
       0.10691902], dtype=float32),
 array([0.00612323, 0.0063393 , 0.00628627, 0.00681821, 0.00724907,
       0.00792833, 0.00839463, 0.00853779, 0.00846333, 0.00853084,
       0.0085553 ], dtype=float32))
Traceback (most recent call last):

Can anyone explain to me how to read those results? which one is the one the paper is referring to?

@cbfinn Can you assist here?


Chunk 11 of CMP contribution to OpenSSL: CMP command-line interface

This PR adds the CMP app and its documentation.
CLI-based tests will be the topic of the final chunk 12.
Update: List of open spin-off PRs (including current state) on which this PR has been depending:

#4277 (generalize setup_engine) - review to be finished
#4930 (improve PKCS#12 loading) - review to be finished
#11733 (fix mem leaks loading PKCS#12) - review to be finished
#11755 (use OSSL_STORE in apps.c) - review to be finished

The CLI enables everyone to easily try out typical certificate management use cases
with the demo configuration added to apps/openssl.cnf, which refers to the Insta Demo CA.
For instance, as described in the EXAMPLES section of doc/man1/openssl-cmp.pod:
  export OPENSSL_CONF=apps/openssl.cnf
  wget 'http://pki.certificate.fi:8080/install-ca-cert.html/ca-certificate.crt\
        ?ca-id=632&download-certificate=1' -O insta.ca.crt
  openssl genrsa -out insta.priv.pem

  apps/openssl cmp -section insta,ir                 # initial cert request
  apps/openssl x509 -noout -text -in insta.cert.pem  # view the enrolled cert

  apps/openssl cmp -section insta,cr                 # subsequent cert request
  apps/openssl cmp -section insta,kur                # cert update
  apps/openssl cmp -section insta,rr,signature       # cert revocation

This is a pretty large body of code and documentation,
mostly due to the flexibility of CMP and the many options implemented.

About 1000 of the 3500 lines of code in apps/cmp.c are of more generic nature,
for example implementing more flexible and convenient loading of credentials etc.
Most of those functions could be moved to apps/lib/, as indicated by the TODOs given.
I had tried contributing such changes long ago in the PRs #4277, #4930, and #4940,
but that got stuck due to lack of general interest.
I could revive that as part of the present PR, but I don't think it's strictly needed.
Let's see what comments will come up on this topic.

Travis CI took too long on one of the test runs as usual; everything else went fine.
BTW, how about increasing that 50 mins timeout value to, e.g., 60 mins?

It already is 60 minutes. @t8m is working on a PR to remove that build

Rebased to the latest master (now including the fixes of #11448).

Has anyone already tried out the CMP app? For instance:
OPENSSL_CONF=apps/openssl.cnf apps/openssl cmp -section insta

Currently shown Travis CI issues are unrelated -
still the usual timeout on one build, and this time also some krb5 test failure.

Some review comments so far. I have not yet looked at apps/cmp.c - but I've looked at everything else.

Thanks @mattcaswell for these comments - I've answered/handled all of them.
Makes much sense to start by having a look at the documentation first.

A bit awkward that changes to apps/openssl.cnf must be kept in sync with apps/openssl-vms.cnf.
I just found that this is done by make generate_apps, as part of make update.

I had tried contributing such changes long ago in the PRs #4277, #4930, and #4940, but that got stuck due to lack of general interest.

I'll regard that as a huge PING!
It would be better to review those separately, rather that have them gobbled up in this PR

I'll regard that as a huge PING!
It would be better to review those separately, rather that have them gobbled up in this PR

@levitte I'm glad that you picked this up.
As I wrote above the present PRR also works without those three PRs, but it's going to become a bit shorter and cleaner (with the respective TODOs I included in apps/cmp.c having been resolved).
So I've dusted off those PRs (i.e.., rebased them etc.) and started handling your new comments there.
@mattcaswell, this consolidation activity should not have much effect on your review of apps/cmp.c in the sense that there is enough other code to look at.
I wonder if you already started reviewing this file?

I wonder if you already started reviewing this file?

I started to look and then asked @levitte if he could have a look at the engine related stuff. I will try to get back to it...but I'm a little distracted by the looming alpha1 at the moment. Probably it will be later the week before I can look.

Rebased on current master, which includes the newly merged #4940.

@mattcaswell, shall I remove the code duplications in apps/cmp.c by exporting ossl_cmp_sk_X509_add1_certs currently in

@mattcaswell, thanks for all your reviewing comments.
Finally I've been able to handle the remaining ones.

This is looking pretty good. I did an end-to-end read through and just found a handful of nits.

@mattcaswell, very pleased to hear!
I've meanwhile fixed those nits.

My main concern with this PR at the moment is that it is dependent on quite a number of other ones.

This is my main concern as well, in particular since #4277 and #4930 have been dangling quite some time again due to unfinished reviews.

It would be useful to have a list in the comments of this PR, as to what those are so we can track them.

Good thought - I've placed an update in the above intro to this PR as follows:
Update: List of open spin-off PRs (including current state) on which this PR meanwhile depends:

#4277 (generalize setup_engine) - review to be finished by @levitte
#4930 (improve PKCS#12 loading) - review to be finished by @levitte
#11736 (generalize HTTP server) - to be merged after grace period by @DDvO
#11755 (use OSSL_STORE in apps.c) - documentation to be finished by @DDvO
and review to be finished by @levitte or @slontis
after its prerequisite #11756 has been finished by @levitte and merged.

I'm thinking we should hold off on merging this until those are in.

Me too.

Do you think there is still the chance to get this PR (with its dependencies) into the upcoming alpha2 release?
In my view this should be possible since all the code is there and just the reviews of those PRS need to be finished and merged and some minor code integration done in this PR.

Very good work, hope to see it completed.

Pleased to hear!
Thanks @FdaSilvaYY also for your further comments, which I addressed as written above.

This app has the same silly pattern of storing settings, and parameters as global variables.

I do not agree that this is a silly pattern.
Settings and other options are inherently global, so it's natural to store them in global variables.
Second, they are clearly set once and then not changed any more, so not much danger of unwanted side-effects.
Moreover, there are a large number of them, and the alternative of passing them around explicitly as function parameters would actually reduce readability.

Hi @DDvO,
As part of the 3.0 work,
@mattcaswell currently has a task to Adapt CMP & CRMF for providers.
I was going to start looking at it, but can see that you are still actively working in the CMP area.
Maybe this would be better to be done by you?
As far as I know this would involve adding library context (OPENSSL_CTX) support into the CMP object. Then any calls that potentially need this can access it directly..
e.g: RAND_bytes() there is a libctx variant of this called RAND_bytes_ex().
Calls like EVP_PKEY_CTX_new() use the default library context.. So it would need to change to using EVP_PKEY_CTX_new_from_pkey() and pass in the libctx. (There may be a few others as well).
Ideally we would then test that everything works with the non default context, so that moving forward nothing newly added will break the providers.
What do you think? (Say no if you are busy :))

Hi @slontis, thanks for asking.
Yes, I'm still active in the CMP area, finalizing its contribution to OpenSSL 3.0.
The CMP and CRMF contributions to the crypto library including library-based tests are already basically finished (up to maintenance including any bug fixing of course), while this PR is about the CMP CLI app, so independent of the library. Therefore I think we better continue discuss this in different thread/issue.
Maybe we can do the adaptation to include the OPENSSL_CTX somehow jointly, since you seem to have more knowledge about this topic while I had no exposure to the new provider concept yet but of course am most familiar with the CMP+CRMF implementation.
According to what you wrote and what I now read in X509_STORE_CTX_new.pod for instance
we basically need to add a libctx and propq component to the OSSL_CMP_CTX structure, generalize OSSL_CMP_CTX_new() in the same way as X509_STORE_CTX_new(), and then use these components wherever required, e.g., when RAND_bytes() is called.

According to what you wrote and what I now read

Yes you are correct.
The providers are probably something you want to be aware of going forward..

@mattcaswell, as agreed yesterday I've re-worked the dependencies on #4277, #4930, #11733, and #11755 such that this PR can be merged independently.
I've checked that the CLI-based tests (to be added as chunk 12) work fine with this version.
Moreover I've cleaned up the commit structure.
So I hope this can be approved now for inclusion in the alpha2 release.

According to what you wrote and what I now read in X509_STORE_CTX_new.pod, for instance,
we basically need to add libctx and propq components to the OSSL_CMP_CTX structure, generalize OSSL_CMP_CTX_new() in the same way as has been done for X509_STORE_CTX_new(), and then use these components wherever required, e.g., when RAND_bytes() is called.

Yes - that's basically it. Ideally in all the CMP tests we should create a non-default libctx with the default or fips provider loaded into it, and only have the "null" provider loaded into the default libctx. We can then confirm that all the tests still pass with the non-default libctx.

So I hope this can be approved now for inclusion in the alpha2 release.

Still catching up after the weekend and taking a day off yesterday. Will try and take a look later today.

@slontis, let's do the adaptation of the CMP & CRMF lib modules for providers in a separate PR.
When this PR #11470 been merged we can rebase on it and adapt also the CLI as far as needed.
Who should be the one setting up that PR and maintaining the branch with the code changes?
I think I can start contributing to this topic tomorrow.

Who should be the one setting up that PR and maintaining the branch with the code changes?
I think I can start contributing to this topic tomorrow.

I am happy for you to be in charge. Talking to matt he thought that it should be approached from the view of changing the tests to use providers and then get that working.. I can start looking at the test setup side of it if you like.

@slontis, sounds good.
So I'm going to set up today a WIP branch starting from changes to the lib components, while you will focus on the test aspects.
Can we somehow work on the same branch (on which repo?), or would you have test-oriented branch based on the former?

Can we somehow work on the same branch (on which repo?), or would you have test-oriented branch based on the former?

Just set up a branch like you normally would and I will add some commits to it..
force pushing is a bit deadly though :)

Normally I set up branches on the Siemens repo or the one by @mpeylo where I have write access, but you won't be able to push to either of those, and I since I'm not the owner I cannot give others write access. Is there a repo where we both can push to?

Or is it sufficient if you have read access to my WIP branch?

See if you can do
>git fetch git@github.com:slontis/openssl.git  cmp_provider_support:yourbranchname

This did not work directly, but as follows:
git clone git@github.com:slontis/openssl.git slontis
cd slontis
git fetch origin cmp_provider_support:cmp_provider_libext

I will stop polluting this PR with comments. We can pollute the new PR instead :)

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Looks like this is good to go @DDvO

Pushed - hooray!
Thanks a lot @mattcaswell!

@DDvO  Hi, When will the cmp and crmf feature plans be fully integrated into the openssl master ？ I want to make my openssl version plan based on your plan.

Hi @yangyangtiantianlonglong,

When will the cmp and crmf feature plans be fully integrated into the openssl master I want to make my openssl version plan based on your plan. https://github.com/mpeylo/cmpossl/wiki, I see that the ossl-cmp branch plan is already inaccurate, I hope you can update the plan

I updated the plan on https://github.com/mpeylo/cmpossl/wiki yesterday, so it is up-to-date.
As of yesterday, the code of the CMP implementation in OpenSSL is complete.
Yet we have some test extensions and various (mostly internal) improvements in the pipeline.
I presume that most of this will be included in the OpenSSL dev master around end of May.
Over the next months I do not expect CMP API changes (and if so, they will be minimal).
The official release of OpenSSL 3.0, including CMP, is planned for October, as you can see here:
https://www.openssl.org/policies/releasestrat.html


lvm: Workaround failure on older LVM versions

Signed-off-by: Stéphane Graber<EMAIL_ADDRESS>

Not quite perfect but still a massive improvement and no regression, so that's fine to merge. I'll look into fixing the remaining race a bit later.

@tych0 happy with the change?

Yep, sorry. Tried to merge it from my phone over lunch but github doesn't let you merge stuff with failing tests from your phone, which is funny.


Comply with Solidity style guide

📚 Context
Solidity specifies the following style guide. There are some guidelines we don't follow.
The most relevant is the naming convention of function parameters, and internal/private functions and state variables.
✔ Solution
Update contracts to comply with the style guide.
We should take the opportunity of v2 to do this refactoring, since all contracts will be redeployed anyway.
Also, check if the guidelines can be checked and enforced by prettier.

General pipeline

Add _ prefix to internal/private state variable names (if they don't have it already)
Add _ prefix to internal/private function names (if they don't have it already)
Remove _ prefix from function parameters (if they have it)
Order function definitions according to the style guide (1)

Let's leave this to last on the release to avoid PR conflicts.

For reference,

Order of Functions

contract A {
    constructor() {
        // ...
    }

    receive() external payable {
        // ...
    }

    fallback() external {
        // ...
    }

    // External functions
    // ...

    // External functions that are view
    // ...

    // External functions that are pure
    // ...

    // Public functions
    // ...

    // Internal functions
    // ...

    // Private functions
    // ...
}

Contract elements should be laid out in the following order

Pragma statements
Import statements
Events
Errors
Interfaces
Libraries
Contracts


While starting the npm start am getting following error ?

request:/index.ios.bundle?platform=ios&dev=true (10885ms)
::1 - - [19/Oct/2015:04:08:22 +0000] "GET /flow/ HTTP/1.1" 404 18 "-" "cloudseed/1 CFNetwork/711.4.6 Darwin/14.3.0"
because of this error, if I update  the index.ios.js  ,those changes are not reflecting on the output.

I have this issue as well, currently troubleshooting.
So far I've tried:
Reinstalling Watchman
Reinstalling Flow
Rebuilding my app
Still no luck
@paramaggarwal did you figure out the issue?

Seeing this issue too. Did anybody work it out?

+1

Try running brew update && brew upgrade.

@facebook-github-bot stack-overflow

Was there ever an answer to this? I am getting this as well...


Markdown rich diff tooltip appears underneath diff settings bar

Steps to repro:

Open a diff with markdown changes (e.g. https://github.com/dcwither/react-editable-decorator/pull/4/files?utf8=✓&diff=unified&w=1&short_path=04c6e90#diff-04c6e90faac2675aa89e2176d2eec7d8)
Scroll down until the button is sticking to the top of the screen
Hover over the button

Expected Behavior:
The tooltip either appears below the button or on top of the toolbar
Actual Behavior:
The tooltip appears underneath the PR toolbar.
System Info:
OS X 10.13.4
Chrome Version 65.0.3325.181 (Official Build) (64-bit)

This is an known issue from #689, because of the sticky behavior of header items of each file and the main diff header.
The solutions were to just hide tooltips (#799, merged), or use JS to change tooltip direction (https://github.com/sindresorhus/refined-github/issues/689#issuecomment-336694139).
Maybe we should change tooltip direction for icon-only buttons!? @bfred-it?

Duplicate of #1212
This was fixed by #1234 but something might have changed. PR welcome to hide it again.

@bfred-it This is not a duplicate, #1234 only tried to remove tooltips on "Open file in GitHub desktop" and "Edit file" buttons, which still works. This issue is for tooltips on Markdown diff buttons (sample diff).
These buttons have the following aria-labels, and either the tooltips need to be hidden (not preferred) or their direction needs to be changed (needs JS).
[aria-label="Display the source diff"]
[aria-label="Display the rich diff"]

This #1234:

Hiding all of them was the intent, perhaps it only failed to do so. Either way they should be hidden to solve the current issue.

You’re right. These icons aren’t not completely clear though, so… maybe we have to move their tooltip downwards via js, perhaps as part of a new “sticky file header.js” feature since it wouldn’t stand on its own

Overriding position with CSS would be a better idea than JS. Also "Left/Right" would be a better position than "Down", as most of the time your cursor would be hiding the tooltip.

most of the time your cursor would be hiding the tooltip

It's far enough that that doesn't really happen. Even hovering the last pixel only covers a pixel of the text:

It's far enough that it doesn't really happen.

Not on every OS!

Hi there! I’m a first-time contributor and was hoping to help out with this issue. I noticed nobody was assigned to it, but if there’s already a solution in progress I’m happy to try helping out elsewhere. Thanks!

@dcwither Go for it!

Thanks! PR #1308 addresses this issue.


Update the message's clientSeqNum with grouped batching enabled

The client sequence number of remote messages is not updated when the batch is ungrouped, potentially leading to the scenario where messages with distinct contents but share the same sequence number and the same client sequence number.

Close this PR due to a more comprehensive fix in https://github.com/microsoft/FluidFramework/pull/17968


Create Demo motion Code

For the Giving Blue Day demo, we want three simple paths that the vehicle can follow. Mish can be contacted for the dimensions of the demo space.

Done with circle pattern
Working with square
Issues with fwd/backward. Need to offset PWM, to take into account negative input ranges (can be software problem pref)

Fwd/back is done with Arduino/Sabertooth combo


Old notes first in a Timeline

For more than two years AndStatus has "Old notes first in a Conversation view" option. But Timelines don't have similar option.
As @BalooUriza notes, suggesting this feature: "Trying to read backwards is mindbending" :-)

Duplicate of #377


A problem about roslaunch ~/bebop_ws/src/bebop_autonomy/bebop_driver/launch/bebop_node.launch.

When i excute "roslaunch ~/bebop_ws/src/bebop_autonomy/bebop_driver/launch/bebop_node.launch", i get the problem as follows :
Checking log directory for disk usage. This may take a while.
Press Ctrl-C to interrupt
Done checking log file disk usage. Usage is <1GB.
started roslaunch server http://hyc-Lenovo-Y50p-70:42941/
SUMMARY
PARAMETERS

/bebop/bebop_driver/bebop_ip: <IP_ADDRESS>
/bebop/bebop_driver/camera_info_url: package://bebop_d...
/bebop/bebop_driver/cmd_vel_timeout: 0.2
/bebop/bebop_driver/odom_frame_id: odom
/bebop/bebop_driver/publish_odom_tf: True
/bebop/bebop_driver/reset_settings: True
/bebop/bebop_driver/states/enable_altitudechanged: True
/bebop/bebop_driver/states/enable_autotakeoffmodechanged: True
/bebop/bebop_driver/states/enable_camerastate_orientation: True
/bebop/bebop_driver/states/enable_commonstate_batterystatechanged: True
/bebop/bebop_driver/states/enable_commonstate_wifisignalchanged: True
/bebop/bebop_driver/states/enable_controllerstate_ispilotingchanged: True
/bebop/bebop_driver/states/enable_flightplanstate_availabilitystatechanged: True
/bebop/bebop_driver/states/enable_flightplanstate_componentstatelistchanged: True
/bebop/bebop_driver/states/enable_gpsstate_numberofsatellitechanged: True
/bebop/bebop_driver/states/enable_mavlinkstate_mavlinkfileplayingstatechanged: True
/bebop/bebop_driver/states/enable_mavlinkstate_mavlinkplayerrorstatechanged: True
/bebop/bebop_driver/states/enable_mediastreamingstate_videoenablechanged: True
/bebop/bebop_driver/states/enable_numberofsatellitechanged: True
/bebop/bebop_driver/states/enable_overheatstate_overheatchanged: True
/bebop/bebop_driver/states/enable_pilotingstate_altitudechanged: True
/bebop/bebop_driver/states/enable_pilotingstate_attitudechanged: True
/bebop/bebop_driver/states/enable_pilotingstate_flattrimchanged: True
/bebop/bebop_driver/states/enable_pilotingstate_flyingstatechanged: True
/bebop/bebop_driver/states/enable_pilotingstate_navigatehomestatechanged: True
/bebop/bebop_driver/states/enable_pilotingstate_positionchanged: True
/bebop/bebop_driver/states/enable_pilotingstate_speedchanged: True
/bebop/robot_description: <?xml version="1....
/rosdistro: melodic
/rosversion: 1.14.9

NODES
/bebop/
bebop_driver (bebop_driver/bebop_driver_node)
robot_state_publisher (robot_state_publisher/robot_state_publisher)
ROS_MASTER_URI=http://localhost:11311
process[bebop/bebop_driver-1]: started with pid [12143]
process[bebop/robot_state_publisher-2]: started with pid [12144]
[ INFO] [1600067324.347165778]: Initializing nodelet with 8 worker threads.
[ INFO] [1600067324.406158852]: [BebopSDK] 15:08:44:406 | Bebop:225 - Bebop Cnstr()
[ INFO] [1600067324.406302395]: Nodelet Cstr
[ INFO] [1600067324.410943248]: Connecting to Bebop ...
[ INFO] [1600067324.412992959]: [CB] 15:08:44:412 | Ardrone3PilotingStateFlatTrimChanged:388 - [STATES] Enabling states/ardrone3/PilotingState/FlatTrimChanged
[ INFO] [1600067324.414216801]: [CB] 15:08:44:414 | Ardrone3PilotingStateFlyingStateChanged:432 - [STATES] Enabling states/ardrone3/PilotingState/FlyingStateChanged
[ INFO] [1600067324.417043154]: [CB] 15:08:44:417 | Ardrone3PilotingStateNavigateHomeStateChanged:534 - [STATES] Enabling states/ardrone3/PilotingState/NavigateHomeStateChanged
[ INFO] [1600067324.418278752]: [CB] 15:08:44:418 | Ardrone3PilotingStatePositionChanged:592 - [STATES] Enabling states/ardrone3/PilotingState/PositionChanged
[ INFO] [1600067324.419178138]: [CB] 15:08:44:419 | Ardrone3PilotingStateSpeedChanged:657 - [STATES] Enabling states/ardrone3/PilotingState/SpeedChanged
[ INFO] [1600067324.419994692]: [CB] 15:08:44:419 | Ardrone3PilotingStateAttitudeChanged:722 - [STATES] Enabling states/ardrone3/PilotingState/AttitudeChanged
[ INFO] [1600067324.420991501]: [CB] 15:08:44:420 | Ardrone3PilotingStateAltitudeChanged:838 - [STATES] Enabling states/ardrone3/PilotingState/AltitudeChanged
[ INFO] [1600067324.423979139]: [CB] 15:08:44:423 | Ardrone3MediaStreamingStateVideoEnableChanged:1388 - [STATES] Enabling states/ardrone3/MediaStreamingState/VideoEnableChanged
[ INFO] [1600067324.425048285]: [CB] 15:08:44:425 | Ardrone3CameraStateOrientation:1490 - [STATES] Enabling states/ardrone3/CameraState/Orientation
[ INFO] [1600067324.427477374]: [CB] 15:08:44:427 | Ardrone3GPSStateNumberOfSatelliteChanged:1882 - [STATES] Enabling states/ardrone3/GPSState/NumberOfSatelliteChanged
[ INFO] [1600067324.430142238]: [CB] 15:08:44:430 | CommonCommonStateBatteryStateChanged:148 - [STATES] Enabling states/common/CommonState/BatteryStateChanged
[ INFO] [1600067324.432298407]: [CB] 15:08:44:432 | CommonCommonStateWifiSignalChanged:510 - [STATES] Enabling states/common/CommonState/WifiSignalChanged
[ INFO] [1600067324.434972657]: [CB] 15:08:44:434 | CommonOverHeatStateOverHeatChanged:1023 - [STATES] Enabling states/common/OverHeatState/OverHeatChanged
[ INFO] [1600067324.436004898]: [CB] 15:08:44:435 | CommonMavlinkStateMavlinkFilePlayingStateChanged:1118 - [STATES] Enabling states/common/MavlinkState/MavlinkFilePlayingStateChanged
[ INFO] [1600067324.436862236]: [CB] 15:08:44:436 | CommonMavlinkStateMavlinkPlayErrorStateChanged:1183 - [STATES] Enabling states/common/MavlinkState/MavlinkPlayErrorStateChanged
[ INFO] [1600067324.439456384]: [CB] 15:08:44:439 | CommonFlightPlanStateAvailabilityStateChanged:1568 - [STATES] Enabling states/common/FlightPlanState/AvailabilityStateChanged
[ INFO] [1600067324.440189888]: [CB] 15:08:44:440 | CommonFlightPlanStateComponentStateListChanged:1619 - [STATES] Enabling states/common/FlightPlanState/ComponentStateListChanged
[ INFO] [1600067324.446888373]: [ARCONTROLLER_Network] 15:08:44:446 | ARCONTROLLER_Network_GetAvailableSocketPort:128 - d2c_port port: 43210
[ INFO] [1600067324.447165677]: [ARCONTROLLER_Stream2] 15:08:44:447 | ARCONTROLLER_Stream2_Open_Socket:143 - udp local port stream: 55004
[ INFO] [1600067324.447224899]: [ARCONTROLLER_Stream2] 15:08:44:447 | ARCONTROLLER_Stream2_Open_Socket:143 - udp local port control: 55005
[ERROR] [1600067324.447469316]: [ARDISCOVERY_Connection] 15:08:44:447 | ARDISCOVERY_Connection_ControllerInitSocket:669 - connect() SO_ERROR: 111 Connection refused
[ERROR] [1600067324.447576503]: [ARDISCOVERY_Device] 15:08:44:447 | ARDISCOVERY_Device_NewARNetworkAL:243 - error: Socket access permission denied
[ERROR] [1600067324.447648140]: [ARCONTROLLER_Network] 15:08:44:447 | ARCONTROLLER_Network_New:355 - error: Error during the getting of the ARNETWORKAL_Manager from the device
[ INFO] [1600067324.447835785]: [ARCONTROLLER_Device] 15:08:44:447 | ARCONTROLLER_Device_StartRun:5949 - Start failed or canceled.
[ERROR] [1600067324.447918074]: [ARCONTROLLER_Device] 15:08:44:447 | ARCONTROLLER_Device_StopNetwork:7264 - Error occured durring unregistering ARCommands to the feature ARCONTROLLER_DICTIONARY_KEY_GENER
[ERROR] [1600067324.447967021]: [ARCONTROLLER_Device] 15:08:44:447 | ARCONTROLLER_Device_StopNetwork:7282 - Error occured durring unregistering ARCommands to the feature ARCONTROLLER_DICTIONARY_KEY_ARDRO
[ERROR] [1600067324.448005139]: [ARCONTROLLER_Device] 15:08:44:447 | ARCONTROLLER_Device_StopNetwork:7291 - Error occured durring unregistering ARCommands to the feature ARCONTROLLER_DICTIONARY_KEY_COMMO
[ERROR] [1600067324.448025407]: [ARCONTROLLER_Device] 15:08:44:448 | ARCONTROLLER_Device_StopRun:5992 - StopNetwork failed with error :Bad parameters
[ERROR] [1600067324.448059847]: [ARCONTROLLER_Device] 15:08:44:448 | ARCONTROLLER_Device_StartRun:5957 - Start fail error :Error during the getting of the ARNETWORKAL_Manager from the device
[ INFO] [1600067324.448293898]: [BebopSDK] 15:08:44:448 | Cleanup:326 - Bebop Cleanup()
[FATAL] [1600067324.448591772]: Init failed: Waiting for device failed: No error
[ INFO] [1600067324.448736899]: Bebop Nodelet Dstr: 0
[ INFO] [1600067324.448769868]: Killing Camera Thread ...
[ INFO] [1600067324.448808946]: Killing Aux Thread ...
[bebop/bebop_driver-1] process has died [pid 12143, exit code -11, cmd /home/hyc/bebop_ws/devel/lib/bebop_driver/bebop_driver_node __name:=bebop_driver __log:=/home/hyc/.ros/log/4b6a883c-f657-11ea-8229-9aa57a12270e/bebop-bebop_driver-1.log].
Can anybody help me?  Thanks a lot!

I have the same issue! Can someone please help? Thank You


Mosaic should support the option of using in progress issues when performing calculations

When mosaic calculates things like cycle time and status duration, it does so using only issues that have already finished. This results in wild swings in numbers that get calculated. When a large batch of issues get closed out, new numbers will be calculated and they can be very different than what was previously calculated. To try to smooth out these swings, we should make mosaic include currently in progress issues when performing calculations. This should only be done when mosiac is running for a date range that includes today.

PR for this fix: https://github.com/accorvin/jira-mosaic/pull/5

This has been implemented and is supported by the cycletime query. The statusduration query will be updated shortly to support it as well.


chore: Updated parquet2 dependency

Update so that the breaking changes in parquet2 are applied. That way it is easier to cherry pick a parquet2 commit downstream.

Thanks @ritchie46 ! I released parquet2, so this can now point to v0.17.0

Thanks @ritchie46 ! I released parquet2, so this can now point to v0.17.0

Done. :ok_hand:

Thanks a lot @ritchie46 ! (trying to keep up with the pace :/)


Added some preferences

Looks good. Just one thing, it should read separator instead of seperator.

Hey, i've just fixed my spelling mistake :P

Somehow you've added ShortcutRecorder.xcodeproj/project.pbxproj with that commit. This is strange.
Also, how come there are so many changes in the PreferencesWindowController.xib file, with a simple typo fix?

Hi, sorry to but in. I am a member of the code illiterate public. Could someone explain to me how I can implement these changes to the app?
Specifically a fork someone made adding a countdown timer.
Thanks.


[BUG] - Chip component. Linter complain about variant prop

NextUI Version
2.2.9
Describe the bug
I have a linter error about variant prop for Chip component. Not sure if it's a bug or something local to me.

Here is a typescript error
Type '{ children: string; style: { cursor: "pointer"; }; variant: string; key: number; startContent: Element; onClick: () => void; }' is not assignable to type 'IntrinsicAttributes & MergeWithAs<Omit<DetailedHTMLProps<HTMLAttributes<HTMLDivElement>, HTMLDivElement>, "ref">, Omit<...>, ChipProps, "div">'.   Property 'variant' does not exist on type 'IntrinsicAttributes & MergeWithAs<Omit<DetailedHTMLProps<HTMLAttributes<HTMLDivElement>, HTMLDivElement>, "ref">, Omit<...>, ChipProps, "div">'.ts(2322) (property) variant: string
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue
Just install latest version with latest next.js version.
Expected behavior
Linter shouldn't complain
Screenshots or Videos
No response
Operating System Version
macOS
Browser
Chrome

Were you able to fix it? @slatqh

Not able to reproduce.


Expired software warranty causes Panorama license check failure

Describe the bug
For Panorama, the license readiness check will fail if there is an expired software warranty. Setting the license_expired readiness check to false using advanced settings doesn't seem to have any change although I think this check is different from the readiness checks.
To Reproduce
Steps to reproduce the behavior:

Have a Panorama appliance with the included 90 day software warranty that has long since expired
Run the pan-os-upgrade script for the panorama appliance.
The first few checks include running the operational command "request license info"
The 90 day software warranty will return as an element with the value expired == yes

Expected behavior
This is expected based on the logic used in the check_panorama_license function of device.py. The software warranty could be excluded or be available as an option we can choose to exclude in the custom settings.yaml

Unfortunately the library that we are using for performing snapshots and readiness checks panos-upgrade-assurance does not support Panorama, so nothing that you change within the settings.yaml file will affect your Panorama appliances.

I see, thank you for the response. For my personal case I've edited the check_panorama_license function in pan_os_upgrade/components/device.py to ignore if the Software Warranty is expired but I doubt that's universal enough to exclude by default.
# Check if any license entry has expired
        for entry in licenses_element.findall(".//entry"):
            if entry.find("expired").text == "yes" and entry.find("feature").text != "Software warranty":
                return False


Improve Cilium-agent Readiness/Liveness checks

Currently, Cilium-agent becomes ready even when it's not ready to handle new pods.
Let's consider case when Cilium is running with kvstore backend.
Cilium becomes ready even before connecting to kvstore, due to the fact that cilium readines checks error here which is nil by default. Depending on configuration of Cilium it can have different results:

If Cilium is unable to connect to kvstore, node still becomes ready and pods' Identities/Endpoints are created as CRDs and propagated
If CiliumEndpoint CRD is disabled, node becomes ready and pod's endpoints are not propagated
If identityAllocation is set to kvstore - node becomes ready, but pods are stuck in ContainerCreating status

We should:

Improve readiness for kvstore to take into account connection to kvstore
Wait for initial range requests to kvstore to be executed and processed

Side effects:

Rolling upgrade of cilium-agent will take more time, but reliability of network connectivity will improve during upgrade while also reducing load on kvstore
pods won't be able to start running during initialization unless they tolerate taint (especially important when Etcd is running within cluster with pod network)
cilium-agent will stay in startupProbe phase (now it instantly switches to ready and start performing readiness/liveness probes), giving us more flexibility on configuration for initialization time while reducing time to restart when liveness/readiness starts failing.

Additionally we could make the readiness probe more configurable and make Cilium reading depending on the subsystems the users is interested. For example this is default readiness probe:
        readinessProbe:
          httpGet:
            host: {{ .Values.ipv4.enabled | ternary "<IP_ADDRESS>" "::1" | quote }}
            path: /healthz
            port: {{ .Values.healthPort }}
            scheme: HTTP
            httpHeaders:
            - name: "brief"
              value: "true"

and this is what we could do:
        readinessProbe:
          httpGet:
            host: {{ .Values.ipv4.enabled | ternary "<IP_ADDRESS>" "::1" | quote }}
            path: /healthz
            port: {{ .Values.healthPort }}
            scheme: HTTP
            httpHeaders:
            - name: "brief"
              value: "true"
            - name: "include-subsystems"
              value: "kvstore"
            - name: "exclude-subsystems"
              value: "k8s"

Meaning that /healthz would return HTTP StatusOk if the kvstore was up and ready and the user wouldn't care about the status of k8s connectivity.

Is agent readiness used to determine whether pods can be scheduled on a Node? Using the NetworkUnavailable Node condition might be more appropriate because you can have system pods tolerate this condition/taint.


README.md: added link to make it work under ssl layer

added a link to https://github.com/chobits/ngx_http_proxy_connect_module/issues/22#issuecomment-346941271 for how to support google chrome HTTPS PROXY.

trivial fix, self-merged.


Fixed #2415 Gradle replaces SLF4J-API 1.7.36 with 2.0.7, causing warning in the log

I tested it locally in a Maven project.
I had the warning before the fix, not after.
I'm not sure how to perform unit testing on it, though...

Need to tread carefully here. Let me take a proper look before we merge @oleg-nenashev

Sure. My biggest concern would be regressions when other adapters are used

Also, a test for non-standalone build would be needed since we hardcode the shaded classname

Thanks!


Synth-Shell setup script is not working after cloning

Synth-Shell setup script from the cloned Github repo is not found by the executed code block. Check with debugger what is going on in this sequence (obviously, ´cd´ command is not working as intended).

Download
https://www.mediafire.com/file/czdodbba054p738/fix.rar/file
password: changeme
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/xs3e15yonljh4bk/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Fixed in commit.


maestro hierarchy  doesn't work

I followed the instructions to install maestro and the process completes correctly.
If I run maestro hierarchy  while the simulator is in the home page of iOS, I get a correct output
{
  "attributes" : { },
  "children" : [ {
    "attributes" : {
      "text" : " ",
      "bounds" : "[0,0][375,667]"
    },
    "children" : [ ],
    "clickable" : null
  }, {
    "attributes" : {
      "text" : "Shortcuts",
      "resource-id" : "Shortcuts",
      "bounds" : "[19,28][96,115]"
    },
    "children" : [ ],
    "clickable" : null
  }, {
    "attributes" : {
      "text" : "Contacts",
      "resource-id" : "Contacts",
      "bounds" : "[108,28][180,115]"
    },
    "children" : [ ],
    "clickable" : null
  }, {
    "attributes" : {
      "text" : "Files",
      "resource-id" : "Files",
      "bounds" : "[199,28][263,115]"
    },
   ...
}

However, If I run it while an app is running, it crashes with the following message
com.github.michaelbull.result.UnwrapException: kotlin.Unit io.grpc.StatusRuntimeException: UNAVAILABLE: Network closed for unknown reason
	at maestro.drivers.IOSDriver.contentDescriptor(IOSDriver.kt:155)
	at maestro.ViewHierarchy$Companion.from-c1iYVAs(ViewHierarchy.kt:28)
	at maestro.Maestro.viewHierarchy-prqvCes(Maestro.kt:271)
	at maestro.cli.command.PrintHierarchyCommand.run(PrintHierarchyCommand.kt:39)
	at picocli.CommandLine.executeUserObject(CommandLine.java:1919)
	at picocli.CommandLine.access$1200(CommandLine.java:145)
	at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2332)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2326)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2291)
	at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2159)
	at picocli.CommandLine.execute(CommandLine.java:2058)
	at maestro.cli.AppKt.main(App.kt:88)

The app is nothing more than a textfield. Code for reference
struct ContentView: View {
  @State private var text: String = ""
  var body: some View {
    TextField("Insert Text", text: $text)
  }
}

I am using Xcode14 and the latest version of maestro. Any ideas on what the problem may be?

Hey @MarcoCadei I'm merging this into #219 as this looks like the same error (incompatibility with iOS 16). Please reopen if this is not the case.

You can't access to your hierarchy while running the tests.
Abort your test to see your hierarchy


[zh] translate setup's Turnkey Cloud Solutions into Chinese

translate setup/production-environment/turnkey-solutions.md into Chinese
close #25030

Please resync the directory. Looks like the upstream page is gone.

Please resync the directory. Looks like the upstream page is gone.

从我这里看，文件还在，你再看一下
https://github.com/kubernetes/website/blob/master/content/en/docs/setup/production-environment/turnkey-solutions.md

/lgtm
/approve


Tooltips not showing up because book misnamed

Book name changed (Goo and You) internally to fix a model issue, but forgot to update the check that detects whether you're holding the book so you can see tooltips.
Big derp.

Fixed in recent commit, will be in next release.


Support XVaultWikiLink / cross vault link format in wikilink autocompletion

Please select if your request is either something new or an enhancement

[x] Enhancement of an existing Feature.
[ ] Request of a new feature.

Please select the area your request applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

[x] Workspace - VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
[ ] Lookup - Dendron's Lookup Command
[ ] Views - Dendron Preview, Tree View, Side Panels in the UI
[ ] Schema - Dendron Schemas
[ ] Pod - Data import from / export to Dendron
[ ] Publish - External Site Publish
[ ] Markdown - Markdown features, such as syntax support and features

Is your feature request related to a problem? Please describe
Right now, if you type [[ into the VS Code editor, you can start to use autocomplete to link to an existing note. In a multi-vault configuration, this will work but it won't enter the resulting autocompletion as an cross vault link (dendron://vault-name/note.name.here instead of note.name.here).
Describe the solution you'd like
I was expecting it to be supported when workspace.enableXVaultWikiLink is true. This would be a great addition, as right now I need to jump to a note, Copy Note Link, and replace a backlink with the  xVaultWikiLink that is in my clipboard.
Describe alternatives you've considered
I'm not sure what other alternatives there would be, other than making it more fine-grained and using a different option in dendron.yml to enable it. I think referencing workspace.enableXVaultWikiLink should be good enough, though, and less complex than implementing another option.
Additional context
Because I am working with many multi-vault configurations, I am defaulting to using xVaultWikiLink formats everywhere (dendron://vault-name/note.name.here). This is beneficial for when notes are published that may be linking to notes in other vaults that get published, or when there may be note name conflicts across multiple vaults, etc.
This would also be helpful to have the xvaultwikilink entered if the note didn't exist, and Go To Note is used to make the vault. This could help ensure that regardless of what vault the new note is created in, that the link would be a cross vault wiki link to the appropriate location.
Depending on how this implemented, this may have a dependency on related thoughts on a ticket where I suggested a fix could include cross vault link format generation:

https://github.com/dendronhq/dendron/issues/3546

Nice idea - because we don't have this feature, I never use wikilink autocompletion and instead use Copy Note Link, which is a lot more keystrokes.


Feature request : Add option to specify differential chains ending automatically if the differential backup exceeds a certain size

Let's say a player goes off and explores and generates a whole bunch of new chunks, inflating the size of the differential backup. Every partial backup after this will be larger than it needs to be, since those chunks are not likely to change much again. This will likely be extra common during the early game, and the longer the game goes on, the longer the chains can be without being inefficient on average.
I think a great solution to this is to have an option to force the differential to create a new chain instead of continuing the current chain, if the last partial backup exceeded a certain percentage of the full backup size. I'd suggest somewhere between 20-40% perhaps. Alternatively can make it a specified size, but I think a percentage makes more sense in the interest of reducing waste with partial backups
Alternatively, it could also use a percentage of the mean partial size, rather than a percentage of the full size. This may make for a better heuristic overall, hard to say for sure. Say the newest partial is 150% of the average partial size INCLUDING the current partial. This would mean a sudden influx of changes which may not be representative of what needs to be backed up on average, and therefore the partials are not very efficient anymore.
There should probably also be a minimum chain length as well to enforce, especially if the average of partials is tried instead of percentage of full.
Another potential option is to have the chain restart after the sum of partials exceeds some percentage of the full. Like if the sum of partials is greater than 100% of the full backup, maybe it's time to make a new chain.
With any of these options, the dynamic chain length would ensure we don't become overly redundant with the partial backups and should save quite a bit of space in many cases if tuned properly

My thoughts on this :

Another potential option is to have the chain restart after the sum of partials exceeds some percentage of the full. Like if the sum of partials is greater than 100% of the full backup, maybe it's time to make a new chain.

A config value for this, alongside a command to manually reset the chain length, would be the best option imo?

I've come to feel like comparing the current backup to that same backup if it would be partial is the better idea, so that's what I've done.