Caster DC Adjuster?

Would it be possible to add an option to change the DC of spells your party casts without needing to modify ability scores or add feats? It'd help with certain enemies whose saving throws are overly high, especially on higher difficulties.

Well, I'll take what I can get. At this point, I'll be content to just have Toybox updated for the new DLC patch.

I don't remember if it's TabletopTweaks that introduces the Heighten Spell metamagic feat, but it's sometimes not horrible depending on the spell you apply it to. Combine it with Persistent Spell and use ToyBoy to set metamagic feats to not affect spell level (so you can apply them for "free" once you have the feats).
Persistent Spell will do the heavy lifting to help your spells stick but some spell levels are complete duds for some classes so being able to move your lower level spells into a tier where there's nothing useful to compete against also has the benefit of improving its save DC.
Altering the underlying code that the game uses to calculate saving throws is kind of out of scope of ToyBox though.


Fix the failing benchmarking suite

Fixes #183
Changes the default branch to develop!
The suite is running here - https://github.com/pybamm-team/liionpack/runs/8039227245?check_suite_focus=true - and should pass!

Ah, the benchmarks (and the re-run) failed as the workflows exceeded the time limit (6 hours). Here is the passing workflow (benchmarks running only on 2 commits) - https://github.com/pybamm-team/liionpack/actions/runs/2940377633


Use click API for output file handling in pip-compile

Use click's file option with atomic mode instead of ExitStack+AtomicSaver.
Less code, DRY.
Less untested code.

Changelog-friendly one-liner: Use click API for output file handling in pip-compile
Contributor checklist

[X] Provided the tests for the changes.
[X] Requested a review from another contributor.
[X] Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
[ ] Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev Thanks for that PR, I'm always interested in some cleanup/maintanabillity improvements.

Use click's file option with atomic mode instead of ExitStack+AtomicSaver.

Cool, let's get that in!

New feature: add support for stdout as output file, for example pip-compile -o- [...]

I'd suggest to take this one out of the current MR for now. The feature is pretty much unusable with the issue you've raised, so I wouldn't merge/release that yet.
I'm super happy about seeing work done to get this feature though, so you're more than welcome to open a second MR once this is merged to get the discussion going.
I'll get on the review proper soon:tm: too.

@vphilippon Thank you for the feedback! Yes, that'd be better to split up the changes.

Hello @vphilippon,
The PR is ready to review. If you have a time take a look please.

Conflicts are resolved.

@blueyed need your feedback :)

@blueyed thanks! I'll resolve the conflicts shortly.


ModuleNotFoundError: No module named 'ffmpeg.asyncio'

i have already install python-ffmpeg

i already solve this issue with this command
apt install python3.8 python3.8-venv python3.8-dev
cd /opt
git clone https://github.com/C0D3D3V/bbb-dl
cd bbb-dl
git checkout v1.0.8
python3.8 -m venv venv
source venv/bin/activate
python3.8 setup.py install
# Package Version Below Depends Of Error Return from executing ./bbb-dl So Run bbb-dl first after run setup.py and don't forget to upgrade pip
python3 -m pip install multidict==4.5 attr yarl async_timeout==4.0 chardet==2.1.1 attrs==17.3.0 greenlet pyee==11.0.1 aiofiles aiohttp>=3.8.3

I guess python-ffmpeg changed there interface again. Maybe we should set the version to a specific version instead of >=1.0.16. I will check it.... Until then I let this issue stay open.


Fix timeout error handling

Relates to issue #711
The main issues addressed here are:

When renderMiddleware timesout, it will send down what ever it has left but it fails to close out the body and html.
In ClientController there is a race condition between nodeArrival and failArrival. nodeArrival will receive a bunch of nodes since before failArrival is sent the nodes we have left are sent down. If failArrival runs an resolves retVal before the nodes can actually render the _previouslyRender flag will be set. Once that is set and the elements try to render, because _previouslyRender is set at the point _cleanup will be called which will wipe away everything on the page.

This looks good to me now.  Nice work @sresant!


Different build command for different branch

Please describe which feature you have a question about?
Configuring Build Setting
Provide additional details
I have 1 app with two different environments and domains. each environment has different domain. for example:

env blue will run in app.blue domain (for dev)
env red will rub in app.red domain (for demo)

each env will have different build command like:

npm run build:blue
npm run build:red

I also set up 2 branch to auto-deploy when the branch is created

red/** for red env
blue/** for blue env

So, when I create 2 branches called red/abc and blue/abc, I will have sub domains called red-abc.app.red and blue-abc.app.blue.
The problem is in the amplify.yml we only able to run one build command. but, there is a branch specific build settings to create some conditional command.

The above screenshot gave me an example of 2 fixed branches (main and dev) but my branches are dynamics so I made some command modifications like this:
if [ "${AWS_BRANCH}" = "red/**" ]; then npm run build:red; fi     //if [ "red/abc" = "red/**" ]; then npm run build:red; fi
if [ "${AWS_BRANCH}" = "blue/**" ]; then npm run build:blue; fi    //if [ "red/abc" = "blue/**" ]; then npm run build:red; fi

it's not working because "red/**" is a normal string.
So my question is. is it possible to make a configuration like what I expected?
What AWS Services are you utilizing?
Amplify Hosting
Provide additional details e.g. code snippets
none

Hello @hloriana 👋🏽. I will try your solution.

@hloriana it works. thanks a lot!


Create To Do App

In this PR, I used React to create a to do list app.

Good Job on Implementing all the requirements
✔ Good Pr Description
✔ Followed git flow
✔ Implemented all the functionality of the to do list app
♻ Requested Changes
Please Make sure to Add the navigations as well to complete the app

Use React Routers to navigate between links


Huge compiled CSS when extending grid

I noticed that when I extend the grid classes to make my markup more semantic the CSS file got super large (over 600kb).
By moving the .col def outside of the .row definition, the file compiled to significantly less size (100kb).
Hoping to get your thoughts on this

How exactly are you extending the grid? We use Sass loops to make all our grid classes so maybe you added something that is getting duplicated into all those classes.

Im just using a sass @extend.  for example (not my actual code):
.appBody {
@extend .row
}
questionText {
@extend .col;
@extend .l5;
@extend .m12;
}
I have a few instances of this.  I assumed something was wrong with my code when my css was comming out at 500+kb so i did some reasearch and it lead me to believe my problem was extending nexted selectors.  So while the sass the generates the grid was originally like this:
row {
margin-left: auto;
margin-right: auto;
margin-bottom: 20px;
// Clear floating children
&:after {
content: "";
display: table;
clear: both;
}
}

@kagneta Did you solve your problem?
Closed due inactivity, feel free to reopen it if it is still necessary.


Feat hive partitioning

Prework

[ ] I understand and agree to this repository's code of conduct.
[ ] I understand and agree to this repository's contributing guidelines.
[ ] I have already submitted an issue or discussion thread to discuss my idea with the maintainers.

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[ ] Feature
[ ] Documentation
[ ] Tutorial
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[ ] No

If yes, please describe the impact and communicate accordingly:
The PR fulfills these requirements:

[ ] It's submitted to the branch named as follow:

Fix a bug: bugfix-<some_key>-<word>
Improve the doc: doc-<some_key>-<word>
Improve a tutorial tutorial-<some_key>-<word>
Add a new feature: feature-<some_key>-<word>
Refactor some code: refactor-<some_key>-<word>
Optimize some code: optimize-<some_key>-<word>

[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[ ] Don't forget to link PR to issue if you are solving one.
[ ] All tests are passing.
[ ] New/updated tests are included

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Related GitHub issues and pull requests

Ref: #

Summary
Please explain the purpose and scope of your contribution.

This PR forces the id/var dir names to adopt a hive partitioning scheme - should it be optional?
For the partitions, this seems to be hardcoded at https://github.com/ltelab/tstore/blob/feat-hive-partitioning/tstore/archive/ts/writers/pyarrow.py#L77

I fixed some issues and rebased this to have a proper PR with this feature only. Now we can review it. I wonder: is it worth making the hive scheme optional at this point? I suggest we move forward with hive only. We may consider supporting futher schemes later on.

I will review this tomorrow or Friday @martibosch.
But as quick thought I would not enforce "store_id=1" and "variable=ts_variable" to have hive partitioning and neither the time series partitioning. In the case of not using hive partitioning for time series objects, if we want to enable the time filter function we still need to implement the listing of parquet files based on the partitioning info included in the TSTORE YAML file.
Two further considerations.
A TS object / partitioned parquet dataset is readable in whatever language-agnostic dataframe/query engine supporting reading parquet file.
A TSTORE directory structure with hive partitioning is not readable:

in LONG- format if a TS object contains more than a variable (is not a series but a dataframe ...)
it might not be neither readable in LONG-format even if the TS object contains a single variable. This should be tried out using i.e. duckdb or pyarrow.dataset ... for cases where a variable occurs in some store_id and not in others. It might well be that pyarrow/duckdb just infer the dataframe columns from the first store_id directory ;)

ok I can make it optional, but I understand that for now we still leave the "hive" time partitioning hardcoded at https://github.com/ltelab/tstore/blob/feat-hive-partitioning/tstore/archive/ts/writers/pyarrow.py#L77 ?

I amended the first commit in order to try to make this work not only for tslong but also for tsdf write/load.

I have added a second commit drafting what I understand should be the rationale f the id_var argument. I am probably overthinking stuff, but from the "TODO" in https://github.com/ltelab/tstore/blob/main/tstore/tests/conftest.py#L236, I suppose that the use of id_var in a TSDF is not clear anyway.

Sorry again for overthinking and for the likely premature optimization, but this is probably a good point to consider whether we need the time_var argument in the TSDF

Once the above issues are clear we can see how we make the id and var-level hive scheme optional, e.g., allow paths of the form my-tstore/1/temperature/year=2021/part.parquet (where 1 is an id value).


React Native 0.63 introduces Promise.allSettled but don't work

React Native 0.63 introduces Promise.allSettled but don't work.
Description
Until version 0.61 we have used the Promise.allSettled polyfill, but in React Native 63 it stopped working because the Promise.allSettled is a valid function and polyfill is ignored.
However, the native Promise.allSettled don't work as expected.
React Native version:
System:
    OS: macOS 10.15.7
    CPU: (4) x64 Intel(R) Core(TM) i5-7360U CPU @ 2.30GHz
    Memory: 136.63 MB / 8.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 12.19.0 - ~/.nvm/versions/node/v12.19.0/bin/node
    Yarn: 1.22.10 - ~/.nvm/versions/node/v12.19.0/bin/yarn
    npm: 6.14.8 - ~/.nvm/versions/node/v12.19.0/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.9.3 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 14.1, DriverKit 19.0, macOS 10.15, tvOS 14.0, watchOS 7.0
    Android SDK:
      API Levels: 23, 26, 27, 28, 29
      Build Tools: 23.0.1, 23.0.3, 24.0.3, 25.0.0, 25.0.1, 25.0.2, 25.0.3, 26.0.1, 26.0.2, 26.0.3, 27.0.3, 28.0.0, 28.0.0, 28.0.1, 28.0.2, 28.0.3, 29.0.0, 29.0.2, 30.0.1
      System Images: android-29 | Google Play Intel x86 Atom
      Android NDK: 20.1.5948944
  IDEs:
    Android Studio: 4.0 AI-193.69<IP_ADDRESS>26763
    Xcode: 12.1/12A7403 - /usr/bin/xcodebuild
  Languages:
    Java: 1.8.0_181 - /usr/bin/javac
    Python: 3.8.2 - /Users/douglas/.pyenv/shims/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: 16.13.1 => 16.13.1
    react-native: 0.63.3 => 0.63.3
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Steps To Reproduce

Run any code like that:

const successReq = (wait) => {
  return new Promise((resolve, reject) => {
    setTimeout(() => {
      resolve(new Date());
    }, wait);
  });
};

const errorReq = (wait) => {
  return new Promise((resolve, reject) => {
    setTimeout(() => {
      reject(new Date());
    }, wait);
  });
};

const makeRequest = async () => {
  const result = await allSettled([
    successReq(500),
    successReq(1000),
    errorReq(600),
    successReq(1500)
  ]);

  console.log({ result });
};

makeRequest();

See the buggy result in console:

{
    "result": [
        {
            "_bitField": 33554432,
            "_settledValueField": 2020-10-23T18: 43: 47.045Z
        },
        {
            "_bitField": 33554432,
            "_settledValueField": 2020-10-23T18: 43: 47.543Z
        },
        {
            "_bitField": 16777216,
            "_settledValueField": 2020-10-23T18: 43: 47.143Z
        },
        {
            "_bitField": 33554432,
            "_settledValueField": 2020-10-23T18: 43: 48.219Z
        }
    ]
}

Expected Results

{
  "result": [
    {
      "status": "fulfilled",
      "value": "2020-10-23T18:52:51.836Z"
    },
    {
      "status": "fulfilled",
      "value": "2020-10-23T18:52:52.336Z"
    },
    {
      "status": "rejected",
      "reason": "2020-10-23T18:52:51.936Z"
    },
    {
      "status": "fulfilled",
      "value": "2020-10-23T18:52:52.837Z"
    }
  ]
}

Snack, code example, screenshot, or link to a repository:
I don't think that is necessary.

From logging on iOS (real device without turning on remote debugging) using react-native v0.63, Promise.allSettled is undefined. So it's not supported.
But from the internals what I see is on android if you use Hermes engine then this Promise Object comes from it, instead of using a polyfill. May be Hermes engine might have a wrong implementation of Promise.allSettled. If you are using Hermes try disabling it for debugging (I have not used).
If you have any other details post here.

Good point. We dont use Hermes, but maybe we are using in debug mode.
I will check, thanks!

Solved, the problem happened because we used another promises polyfill (Bluebird) that ended up causing the problem.
Thank you for your help!

so, is Promise.allSettled supported in RN ?

Promise.allSettled is undefined in React Native 0.64.1 for me. Using Hermes for both iOS and Android now.

RN dont have allSettled by default, you need to use Promise.allSettled polyfill.

const allSettled = (promises) => {
  return Promise.all(promises.map(promise => promise
      .then(value => ({ status: 'fulfilled', value }))
      .catch(reason => ({ status: 'rejected', reason }))
  ));
}

under the hood react-native uses promise modules to polyfill Promise
https://github.com/facebook/react-native/blob/1a9e2d5d5589ce5cee92868ea5bccceb6e161eff/Libraries/Core/polyfillPromise.js#L36-L38
So if in that module will implemented allSettled it can be easily shipped to react-native

UPD: I made PR: https://github.com/then/promise/pull/171


npm package and/or index.js

Gents,
I'd like to fiddle around with the alpha release, therefore it would be extremely useful if you could provide an index.js - so one could use npm to grab and install the package.
Cheers

We'll publish to npm once the alpha.0 is ready. The announcement will probably be on Twitter, so stay tuned!


Air quality index always 0 with Pure Cool Link 475

Air quality index always shows 0, but I can see it in the app. How to get this data in HA?
Volatile Organic Compounds Index, Temperature and Humidity show data

Hi @ro8inmorgan! Sorry for the late reply here. This is interesting. I actually have two 475 devices. AQI is working for both of them on my installation. Here's some screenshots for context; you can see that Home Assistant shows raw values on its chart, and the MyDyson app applies some kind of smoothing. There also seems to be a difference in resolution, but I don't know how much we can do about that right now. So there's not a perfect 1:1 relationship, but otherwise they basically appear to be showing the same information.

There is a new tool I released yesterday (not well-documented yet, that's on my to-do list for today) called opendyson. If you're willing to help debug this, you can use it to get the values directly from your fan.
You can run opendyson devices to list your devices, find the serial number for the specific device you want to pull information from. Then run opendyson listen YOUR-SERIAL-NUMBER and it will start printing information from your device to the screen. Here's an example below.
$ opendyson devices
Use China region for account? (Default is no) [y/n]: n
Email Address<EMAIL_ADDRESS>Code from confirmation email: 123456
Password:
Available devices:
- basedevice:
    name: Dyson Fan
    serial: NM7-US-XXXXXXXX
    model: TP02
    type: "475"
    variant: ""
    productCategory: ec
    connectionCategory: wifiOnly
  mqtt:
    password: REDACTED
    username: NM7-US-XXXXXXXX
    root_topic: "475"
    address: <IP_ADDRESS>
  iot:
    endpoint: REDACTED
    client_id: REDACTED
    custom_authorizer_name: REDACTED
    token_key: REDACTED
    token_signature: REDACTED
    token_value: REDACTED
  firmware:
    version: 21.04.03
    auto_update_enabled: false
    new_version_available: false

This is sensitive information that can be used to remotely control your Dyson devices. Please take caution before sharing it with anyone you don't trust.

$ opendyson listen NM7-US-XXXXXXXX
Subscribing to 475/NM7-US-XXXXXXXX/status/current
Subscribing to 475/NM7-US-XXXXXXXX/status/fault
Subscribing to 475/NM7-US-XXXXXXXX/command
Command:  {"msg": "REQUEST-PRODUCT-ENVIRONMENT-CURRENT-SENSOR-DATA", "time": "2024-07-08T16:32:03Z"}
Status:   {"msg":"ENVIRONMENTAL-CURRENT-SENSOR-DATA","time":"2024-07-08T16:32:03.000Z","data":{"tact":"2970","hact":"0052","pact":"0000","vact":"0000","sltm":"OFF"}}
Command:  {"msg": "REQUEST-PRODUCT-ENVIRONMENT-CURRENT-SENSOR-DATA", "time": "2024-07-08T16:32:33Z"}
Status:   {"msg":"ENVIRONMENTAL-CURRENT-SENSOR-DATA","time":"2024-07-08T16:32:33.000Z","data":{"tact":"2970","hact":"0052","pact":"0000","vact":"0000","sltm":"OFF"}}

If you're able to get this to work, please share two things:

The value of your device's firmware version field (maybe there's a firmware-specific bug to be aware of)
The the output of opendyson listen after letting it run for a while. We can review the values to see if there's something to be worried about.

There's some more conversation going on int #140 which makes me think that I'm actually using a different sensor value and assuming it's AQI. More to come...


EVEREST-496 Multi namespace support

CHANGE DESCRIPTION
Problem:
EVEREST-496
That's a small PoC for cluster-wide operators that stores backup storage (the same applies for monitoring configs) in the percona-everest and replicates secrets across namespaces that it manages.
Pros:

BE needs to manage only one BackupStorage or MonitoringConfig with the referenced secret in only one namespace
Operator handles the state of the secret and updates it across all namespaces where it was created

Cons:

Increased blast radius. When (not if, but when) we will release a broken version of the operator DBaaS features will be broken for all database clusters across all namespaces. Having it in the namespace mode locks it only for the one namespace and this approach is recommended by Percona. Read more https://www.percona.com/blog/percona-operators-deployment-explained-delving-into-cluster-wide-vs-namespace-scoped/
Bloated service account permissions to run everest operator in the cluster-wide mode. Instead of having one SA per namespace with the least privileges. If percona-everest namespace is compromised, the attacker can get access to all namespaces that manage everest-operator
Additional load to the QA team because they need to test two different modes of everest operator and this is an additional step for their workflow
The configuration becomes more fragile because CLI needs to set env var for percona-everest namespace for two components: BE and operator
During the update of a secret and when the operator fails to reconcile it in any namespace the end user will stay unnotified without any messaging from the everest side
There is no separation of concerns for the sensitive data because everything is stored in the one namespace yet I believe we need to store it in different namespaces to follow security best practices

Yet we have an additional request for the cluster-wide operator to use admission webhooks to move validation logic from the BE side to the operator, however, the scope of change is huge because

Would be best to implement multi-namespace mode for the operator without additional logic, ensure that everything works as expected
Ensure that everest operator can work with the different versions of the upstream operators
Implement reconcile loops for monitoring configs, and backup storages
Implement admission webhoooks or any other stuff

CHECKLIST
Jira

[ ] Is the Jira ticket created and referenced properly?

Tests

[ ] Is an Integration test/test case added for the new feature/change?
[ ] Are unit tests added where appropriate?

I argue that we don't need the BackupStorage controller at all. We already have an index and watcher configured in the DBC controller that runs the reconciliation loop every time a secret referenced by a BS triggers an event.
Therefore, we can use this same mechanism to create or update the end secret without needing to keep track of any namespace. In a sense we can think of this secret as being linked to a specific DBC than to the generic BS.

Moreover, we already use this approach for PG because the secret format needs to be different than the one specified in the BS which is the same for PXC/PSMDB. See here and here

Well, this was my first approach to solving the issue. This works fine for the backupStorages or monitoringConfigs in the single namespace scenario.
Since the idea is to create backupstorages or monitoring configs in the default namespace (percona-everest) the existence of the objects is only in the default namespace. However, databasecluster controller replicates secrets across namespaces (since they are namespaced) there's no way (at least I know) to bind that secret with the backupStorage or monitoringConfig. Since the logic for backup storage and monitoring config is the same I'll describe the flow based on backup storage
Let's take a look at the backup storage In the default namespace. To ensure that the secret will be deleted we can use ownerreferences here and we don't quite need a controller here. The backend or some other controller can create it for you yet, once the backupstorage is deleted, the secret will be deleted as well.
Since secrets are namespaced to enable the multi namespace support in the cluster-wide mode we need to replicate them to the targetNamespace during the reconciliation of database clusters(because this is the only place when we need to ensure that the secret exists). We can't use ownerreferences here because they are not designed for that and we need to come up with a way to store the information where the secret was created. Here are the labels to link the secret in the different namespace with the existing backup storage.
After testing this using indexers and watchers, when the user tries to delete the secret from a different namespace the reconciliation loop does not start because there's no event generated/passed to the operator after the deletion and it ends in the inconsistent state.
Hence, we need to have an additional controller to ensure that after backup storage deletion, all secrets across all namespaces will be created and here we have finalizers as an additional handle to block the deletion. We need to delete all secrets across all namespaces except the default one (because we use owner references here and the deletion might block here because of cross-linking between entities)
Since the backupstorage controller is namespaced (because we create backup storages only in the default namespace) we need to have a way to watch for secrets and run reconciliation of the backup storage entity on the secret change. For the default secret in the default namespace we have Owns for that and this works fine. For all other namespaces, we need to listen to secrets and run a reconcile loop only for labeled secrets.
I hope that it explains the solution after a couple of days of trying to implement as simply as I can.


Update transparent-data-encryption-byok-azure-sql.md

changed the description, minor wording changes

#1


Team 11 Review: Wording of NFRT-UH2

@samm82
Name: Team 11 Review
About: Wording of NFRT-UH2

Summary: The expected/actual output of this test case is not clear. How does convincing the participants that the main features are explained on github solve this requirement? The participants need to make that decision for themselves and let you know what they think, rather than you convincing them, as convincing others is easy if you only show the completed parts and not everything else.
Deadline: April 1st, 2024
Estimated Work Hours: 20 minutes

There is a word explanation -- user manual in the repo, we just need to let the participants know the existence of that documentation.


list.contains

Let's create a new method, which will basically return TRUE if list.index-of x is not -1. Let's call it contains.

@levBagryansky Please, help us here


Added query to Domain#get_endpoints

Hey @icheishvili !
Thanks for opening the pull request!
Can you update the test spec to at least include one example validating that if the query params are passed to the get_endpoints they are indeed appended to the url.
Thanks!!


[iOS RPC] Test PR

There are no doc strings at all. I guess some description of API methods and purpose of classes is required.

I also suggest to extract changes of "python/tvm/rpc/proxy.py" into separate PR and provide additional test on "proxy->tracker" communication. Is it possible?


[stable/mariadb] Update to the recommended pvc patterns.

This is a split-off of PR #408 to just contain the chart mariadb.
If there's any commonality in changes nessary between this PR and the others that are being submitted at once, please mention them in #408.
Some things to note:

This initial PR will not be updating the Chart.yaml's version string, as I feel it should be done manually per-pr once each chart's otherwise acceptable.
An automated script created the splits and the PRs, on a per-folder basis under stable, after copying the relevent files from a backup of my local copy of #408

@k8s-bot ok to test


How to quantize a model not in  AutoModelForCausalLM list?

We are trying to quantize our own pretrained model which haven't been added to transformers model list.
As far as I know, I just have to change the model loading process like substituting all the AutoModelForCausalLM to xxForCausalLM in llmcompressor, especially path like 'llmcompressor/transformers'.
However, the compression process 'looked' normal, but our model size (76GB) was not changed.

Can you share the code you used?
We are working on improving our integration with transformers to avoid the need for SparseAutoModelForCausalLM - which currently implements some utilities associated with saving and loading models in compressed format.
So to use a regular transformers model for now, we need to use some of these saving utilities directly.

see https://github.com/vllm-project/llm-compressor/pull/832 for the ongoing work on this

Thank you for your reply.
We are currently using llmcompressor version-0.2.0.
I will take a look at this PR #832

Hi @IEI-mjx
You you'll need to use the wrap_hf_model_class to wrap the model class which you'd like to use. Note that this API may change in the future.
Example:
from transformers import MllamaForConditionalGeneration

from llmcompressor.modifiers.quantization import QuantizationModifier
from llmcompressor.transformers import oneshot, wrap_hf_model_class

MODEL_ID = "meta-llama/Llama-3.2-11B-Vision-Instruct"

model_class = wrap_hf_model_class(MllamaForConditionalGeneration)
model = model_class.from_pretrained(MODEL_ID, device_map="auto", torch_dtype="auto")

If you're still have issues, let me know the model and class you're using and I'd be happy to take a deeper look

Hi @IEI-mjx
You you'll need to use the wrap_hf_model_class to wrap the model class which you'd like to use. Note that this API may change in the future.
Example:
from transformers import MllamaForConditionalGeneration

from llmcompressor.modifiers.quantization import QuantizationModifier
from llmcompressor.transformers import oneshot, wrap_hf_model_class

MODEL_ID = "meta-llama/Llama-3.2-11B-Vision-Instruct"

model_class = wrap_hf_model_class(MllamaForConditionalGeneration)
model = model_class.from_pretrained(MODEL_ID, device_map="auto", torch_dtype="auto")

If you're still have issues, let me know the model and class you're using and I'd be happy to take a deeper look

Thank you so much! I resolved the issue. In my state dict file, the weight matrices in the MoE and attention layers were concatenated, which made direct compression impossible. By chunking these weight matrices, the problem was resolved.
By the way, if I want to compress my original model, where the weight shape in the MoE layer is [num_experts, 2 * ffn_hidden_size, hidden_size], which part of the LLMCompressor backend should I modify?


Add navbar title

In this Project I;

Downloaded the free image for the app logo.
Created empty navigation (this will be filled in in separate tasks).

Hi @blessing-michael
Excellent work! The navbar is correctly displaying. Now you can merge it 🍀.


Apply a setting to remove the bottom spacing half from H4–H6 headings

Currently there is this setting: $apply-heading-margins in Core -> Base -> Headings but there should be another one e.g. $apply-smaller-margin-for-lowest-headings to remove the bottom spacing half: @extend %bottom-spacing-half; from the h4–h6 headings in case you want to use the base bottom spacing instead: @extend %bottom-spacing; because you cannot override this setting using @extend %bottom-spacing; in your project layer e.g.
@include headings(4, 6, true) {
  @extend %bottom-spacing;
}

Fixed in #169 PR.


Update Changelog

:speaking_head: Foreword
Thank for taking the time to fill this bug report fully. Without it we may not be able to fix the bug, and the issue may be closed without resolution.
:ghost: Brief Description
Update all CHANGELOGs to follow standard defined at https://keepachangelog.com/
Issue sprouted from sous-chefs/meta/issues/101. If not applicable then issue should be closed.

The change log format has been updated.


fix css of wikidata complete plugin

I have made changes in CSS, deployed and tested for https://www.wikidata.org/wiki/Q10889416
earlier

now

Thanks :) I have reduced the spacing between the boxes now the width is in sync with the already present statement boxes.


Opening file by key when larger than 9

When the list files is longer than nine files, it is impossible to select files assigned a number greater than 9. Trying to type 10 will open file 1.

Hmm, this shouldn't happen anymore. An issue like that was fixed many months ago. Not updated in a long time?
Maybe you have 'timeout' set and 'timeoutlen' set to a small value?

Indeed, I have timeoutlen set to 50.

Then there's nothing I can do about that. (Since 'timeoutlen' is a global value, I can't just set it for the Startify buffer but would have to pay attention to all kinds of corner cases where someone leaves the buffer and reset the option.)

Or did you try to disable delays when pressing Esc when using tmux and the like? In that case, try :set ttimeout ttimeoutlen=50 instead.

That worked. Thanks!


Add Chop Chop Stop plugin

This plugin will hide the overhead messages from the various tool special attacks.

fyi you should be able to use the Chat Filter plugin to accomplish this

I plan on adding the option to hide the animations too.


fix: sidecarContainers should be an array, not a dict

What was changed

Very simple change: I changed the datatype of sidecarContainers to [] (from {}).
Why?

When running Tanka, we've been getting this warning:
coalesce.go:220: warning: cannot overwrite table with non table for temporal.server.sidecarContainers (map[])
It was rendering the YAML fine, but when CI runs people kept thinking there was an actual issue.
Checklist

Closes

How was this tested:

Any docs updates needed?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for your submission. This fixed has been merged, unfortunately I wasn't able to get it to merge via the PR for some reason.

Thanks for your submission. This fixed has been merged, unfortunately I wasn't able to get it to merge via the PR for some reason.

that's ok with me, as long as it gets fixed. it's not like this was a super complicated PR :D


Fatal error: Identifier is expected  (958)

Package version: 2.2.0
Affected node versions: 8.1.4
My grunt-csso task fails with the error Fatal error: Identifier is expected  (958).
package.json
gruntfile.js
grunt-csso and grunt-cli are installed locally.
I've taken these steps in my project.
rm -rf node_modules
npm i -D grunt-cli
npm i -D grunt-csso
npm i for the other packages
grunt
Running "csso:build" (csso) task
Fatal error: Identifier is expected  (958)

Looks like a problem with either your css, or your gruntfile.
Can you run other tasks ?
Can you also run grunt --stack and give me the stack trace ?
Thanks!

Other tasks run successfully, and the error appears when the csso task starts. Excluding csso task results in all tasks completing successfully.
The --stack flag does not help in this instance as I get the same fatal error.
grunt --stack
Running "clean:build" (clean) task
>> 4 paths cleaned.

Running "copy:main" (copy) task
Copied 85 files

Running "sass:build" (sass) task

Running "postcss:dist" (postcss) task
>> 2 processed stylesheets created.
>> 2 sourcemaps created.

Running "concat:build" (concat) task

Running "imagemin:build" (imagemin) task
Minified 14 images (saved 4.83 kB)

Running "csso:build" (csso) task
Fatal error: Identifier is expected  (965)

I simplified my CSSO grunt task as much as possible, but it continues to fail with the same fatal error
csso: {
	build: {
		files: {
			'build/css/style.min.css': 'build/css/style.css'
		}
	}
}

Thanks for your help :)

I am sad to say this, but it looks like you css is invalid. https://github.com/csstree/csstree/blob/1a750f9f52a0397dc64fae07d7a358fad30d46be/lib/syntax/node/AttributeSelector.js#L37
That error message is at multiple places in the css parser https://github.com/csstree/csstree/search?p=1&q='Identifier+is+expected'&type=&utf8=✓
I think we need to update the dependencies...

Thanks for the reply @nitriques . I'll try and locate CSS which is not being parsed.

No problem. I'll keep this issue open to remind me of updating the deps. Wanna share the 'build/css/style.min.css' file ?

@andrewfleming do you still have issues with this ?

Yes, I'm still seeing this issue.
A build/css/style.min.css file is not generated, so I'm not able to supply.

Can you share the source, i.e. build/css/style.css ?

[Uploading csso-issue-31.zip…](Example files)
Attached is the package.json, gemfile, gruntfile and sass files which should allow you to replicate the issue.

Can you just share the build/css/style.css file? I do not have ruby nor sass on my machine.

Here's a link to a gist with the CSS output https://gist.github.com/andrewfleming/e2fd3134c0d2cef3a9a765a7e34e4963

There are a couple of problems...

https://gist.github.com/andrewfleming/e2fd3134c0d2cef3a9a765a7e34e4963#file-csso-debugging-L1079 (missing a 'd')
https://gist.github.com/andrewfleming/e2fd3134c0d2cef3a9a765a7e34e4963#file-csso-debugging-L1188 keyframes animations can't be defined in a media query
https://gist.github.com/andrewfleming/e2fd3134c0d2cef3a9a765a7e34e4963#file-csso-debugging-L1266 mixin call problems ?

I would suggest to make sure it's valid using https://jigsaw.w3.org/css-validator/validator

Here is where the error comes from : https://github.com/csstree/csstree/search?utf8=✓&q=RightParenthesis&type=


[WIP] Add typed end-points for bulk, search, index APIs

Signed-off-by: Suraj Singh<EMAIL_ADDRESS>Description
As a follow up of https://github.com/opensearch-project/OpenSearch/pull/3505; add typed end-points for bulk, search, index APIs. This change simply consumes type param (if any) without passing it to corresponding request object.
Issues Resolved
https://github.com/opensearch-project/OpenSearch/pull/3505
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

start gradle check


Add dilate option and MultiNodeBatchNormalization to Conv2DActiv and Conv2DBNActiv

#388 became a too large PR, then I split it into some small PRs.
First, Conv2DActiv and Conv2DBNActive should be able to take dilate option to use DilatedConvolution2D instead of Convolution2D.
Next, Conv2DBNActive should be able to use chainermn.links.MultiNodeBatchNormalization to use batch normalization layers correctly with multiple GPUs.
This PR introduces these two features.

I am very sorry for late review.
Could you please resolve the conflict with master branch?

@yuyu2172 Thanks for the review. I fixed all the points commented in review.

Thank you. Please fix tests.

ChainerMN seems to be not installed correctly.
It is raising an error error: option --no-nccl not recognized.

Why do you install ChainerMN from source? Can't we install it by modifying chainercv/environment.yml?

Travis is failing because environment file is incorrect.
Perhaps, pip should be used inside the env file to install mn.

@mitmul
You need - before pip.
The env file below worked.
name: chainercv
channels:
- !!python/unicode
  'menpo'
- !!python/unicode
  'mpi4py'
- !!python/unicode
  'defaults'
dependencies:
  - Cython
  - opencv3=3.2.0
  - matplotlib
  - numpy
  - Pillow
  - openmpi
  - pip:
    - chainermn==1.2.0

Thanks. I updated it.

Tests are failing when dilate == 2.
I think you forgot to modify test_conv_2d_activ.py. It is fine for test_conv_2d_bn_activ.py.

@yuyu2172 Sorry, I updated the test too.

All tests passed.

I checked the test log and it seems that ChainerMN is not installed properly.
The log says that mpi4py fails to get installed.
Could you fix this?
  _configtest.c:2:17: fatal error: mpi.h: No such file or directory
   #include <mpi.h>
                   ^
  compilation terminated.
  failure.
  removing: _configtest.c _configtest.o
  error: Cannot compile MPI programs. Check your configuration!!!

  ----------------------------------------
  Failed building wheel for mpi4py
  Running setup.py clean for mpi4py
  Running setup.py bdist_wheel for pycparser ... - \ done
  Stored in directory: /home/travis/.cache/pip/wheels/95/14/9a/5e7b9024459d2a6600aaa64e0ba485325aff7a9ac7489db1b6
  Running setup.py bdist_wheel for filelock ... - done
  Stored in directory: /home/travis/.cache/pip/wheels/5f/5e/8a/9f1eb481ffbfff95d5f550570c1dbeff3c1785c8383c12c62b
Successfully built chainermn chainer pycparser filelock
Failed to build mpi4py

As a consequence, the tests related to ChainerMN are skipped.
https://travis-ci.org/chainer/chainercv/jobs/354200398#L1077

I see. Thanks for catching it. I'll fix that.

@yuyu2172 Fixed the environment.yml to install mpi4py from conda. I think it fixed the installation of mpi4py.


Out of memory error

PGSync version: 2.1.9
Postgres version: 12
Elasticsearch version: 7.16.1
Redis version: latest
Python version: 3.7
Problem Description:
When running a sync with a 6GB database, I get the following error:
pgsync_1         | (Background on this error at: https://sqlalche.me/e/14/e3q8)
pgsync_1         | Traceback (most recent call last):
pgsync_1         |   File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/base.py", line 1815, in _execute_context
pgsync_1         |     result = context._setup_result_proxy()
pgsync_1         |   File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/default.py", line 1414, in _setup_result_proxy
pgsync_1         |     self.cursor, self.execution_options
pgsync_1         |   File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/cursor.py", line 1030, in __init__
pgsync_1         |     self._rowbuffer = collections.deque(dbapi_cursor.fetchmany(1))
pgsync_1         | psycopg2.errors.ProgramLimitExceeded: out of memory
pgsync_1         | DETAIL:  Cannot enlarge string buffer containing<PHONE_NUMBER> bytes by 6633 more bytes.
pgsync_1         |
pgsync_1         |
pgsync_1         | The above exception was the direct cause of the following exception:
pgsync_1         |
pgsync_1         | Traceback (most recent call last):
pgsync_1         |   File "/usr/local/lib/python3.7/site-packages/pgsync/sync.py", line 875, in sync
pgsync_1         |     self.es.bulk(self.index, docs)
pgsync_1         |   File "/usr/local/lib/python3.7/site-packages/pgsync/elastichelper.py", line 133, in bulk
pgsync_1         |     raise_on_error=raise_on_error,
pgsync_1         |   File "/usr/local/lib/python3.7/site-packages/elasticsearch/helpers/actions.py", line 484, in parallel_bulk
pgsync_1         |     actions, chunk_size, max_chunk_bytes, client.transport.serializer
pgsync_1         |   File "/usr/local/lib/python3.7/multiprocessing/pool.py", line 748, in next
pgsync_1         |     raise value
pgsync_1         |   File "/usr/local/lib/python3.7/multiprocessing/pool.py", line 121, in worker
pgsync_1         |     result = (True, func(*args, **kwds))
pgsync_1         |   File "/usr/local/lib/python3.7/multiprocessing/pool.py", line 140, in _helper_reraises_exception
pgsync_1         |     raise ex
pgsync_1         |   File "/usr/local/lib/python3.7/multiprocessing/pool.py", line 292, in _guarded_task_generation
pgsync_1         |     for i, x in enumerate(iterable):
pgsync_1         |   File "/usr/local/lib/python3.7/site-packages/elasticsearch/helpers/actions.py", line 155, in _chunk_actions
pgsync_1         |     for action, data in actions:
pgsync_1         |   File "/usr/local/lib/python3.7/site-packages/pgsync/sync.py", line 831, in _sync
pgsync_1         |     self.fetchmany(node._subquery)
pgsync_1         |   File "/usr/local/lib/python3.7/site-packages/pgsync/base.py", line 882, in fetchmany
pgsync_1         |     statement.select()
pgsync_1         |   File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/base.py", line 1286, in execute
pgsync_1         |     return meth(self, multiparams, params, _EMPTY_EXECUTION_OPTS)
pgsync_1         |   File "/usr/local/lib/python3.7/site-packages/sqlalchemy/sql/elements.py", line 326, in _execute_on_connection
pgsync_1         |     self, multiparams, params, execution_options
pgsync_1         |   File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/base.py", line 1488, in _execute_clauseelement
pgsync_1         |     cache_hit=cache_hit,
pgsync_1         |   File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/base.py", line 1843, in _execute_context
pgsync_1         |     e, statement, parameters, cursor, context
pgsync_1         |   File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/base.py", line 2024, in _handle_dbapi_exceptionpgsync_1         |     sqlalchemy_exception, with_traceback=exc_info[2], from_=e
pgsync_1         |   File "/usr/local/lib/python3.7/site-packages/sqlalchemy/util/compat.py", line 207, in raise_
pgsync_1         |     raise exception
pgsync_1         |   File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/base.py", line 1815, in _execute_context
pgsync_1         |     result = context._setup_result_proxy()
pgsync_1         |   File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/default.py", line 1414, in _setup_result_proxy
pgsync_1         |     self.cursor, self.execution_options
pgsync_1         |   File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/cursor.py", line 1030, in __init__
pgsync_1         |     self._rowbuffer = collections.deque(dbapi_cursor.fetchmany(1))
pgsync_1         | sqlalchemy.exc.OperationalError: (psycopg2.errors.ProgramLimitExceeded) out of memory
pgsync_1         | DETAIL:  Cannot enlarge string buffer containing<PHONE_NUMBER> bytes by 6633 more bytes.

{
  "database": "my-db",
  "index": "index1",
  "mapping": {
    "Attributes": {
      "type": "nested"
    }
  },
  "nodes": {
    "table": "table1",
    "schema": "public",
    "columns": [
      "Id",
      "Name"
    ],
    "children": [
      {
        "table": "Attributes",
        "columns": [
          "Id",
          "Value"
        ],
        "relationship": {
          "variant": "object",
          "type": "one_to_many"
        },
        "children": [
          {
            "table": "AttributeTypes",
            "columns": [
              "Id",
              "Name"
            ],
            "relationship": {
              "variant": "object",
              "type": "one_to_one"
            }
          }
        ]
      }
    ]
  }
}

Thanks

Does reducing the value of QUERY_CHUNK_SIZE have any effect ?
The default is 10000

QUERY_CHUNK_SIZE has no effect whatever the value (100, 1000, ...).

Can you check the value of work_mem on the Postgres database.
show work_mem;
Also can you try increasing this value

work_mem has the default value (4MB).

Increasing the value of work_mem has no effect (tested with 64MB, 128MB, 512MB)
The table Attributes has millions of records and AttributeTypes thousands.

this looks like a client error.
does the host running pgsync have sufficient memory to run?


fix #809

Hi, thanks for contributing! Could you please:

Add tests in the appropriate file (for this, I think test/declaration.ls)
Run make and add the lib directory to the commit

Please make these (and any future) changes by amending the existing commit and force pushing, not by adding new commits.
Thank you again!

Hi, I followed you suggestions, think things get done.


timestamp formatting is broken

In our discussion it's been reported that the timestamp converion is not working on both iOS and Android client.
Using the example from here, it outputs as

Our next meeting is scheduled for time:2020-05-28T13:30:30:00+05

instead of what's expected

Our next meeting is scheduled for Thu, May 28 2020, 1:00 AM.

I see a similar thing in the iOS app v27.154 on iOS 13.6.1.
It looks like the app is stripping the time tag, but not doing any time zone conversion.
(Note that the app is entirely capable of converting times - Zulip message times are in my local time zone. But the time tag is not.)
Can someone label this issue as a Rust community request?
It's causing us some issues planning meeting times.

Hey , this does seems to work fine for me in the debug mode . However , while viewing messages in stock android app (The one downloaded from play store) the timestamp seems to be broken . (Maybe there hasn't been a new update)
Also I have noticed that the date-picker isn't rendering after typing <time in the compose box . Confirm @chrisbobbe

Is there TestFlight for zulip? I can check whether the formatting works in iOS debug release.

This feature was #4162. We implemented it in #4175, which was first released in v27.155. So that's why at the time of the discussion above, it was present in the main/master branch but not in the current release.

Also I have noticed that the date-picker isn't rendering after typing <time in the compose box

This part is #5079, which remains open.


Default value in form format

I know that it is possible to have default values in the JSON Schema, however, that is not always sufficient:

When you "inherit" parts of schemas($ref) into another, you sometimes want to add or change defaults, especially when there are multiple choices.
In the UI, there are certainly cases where the defaults are more dynamic.

I am thinking that perhaps this pushes it beyond "good to have" and into "commonly usable".
Or should this be better handled in some other way? Defaults is a little tricky when it comes to where they belong.

I think we need to go even further, when I change field group based on a condition I need to define if it resets to a default for the condition. I think it needs to be a part of a rule definition.

Ok, then. I hear you about the rules.
But a set of data is a more complex result of a rule than a true/false value.
Becomes more "script" than rule then.

Well the rule would be like a bunch of switches determining what the result was, it could be a simple value or an object with schema definition to merge into parent. I think it can behave as script without being script as we need it to work in all languages and be super easy to implement and understand.

@Anthropic I think this would be commonly usable.

@iseessel it is something I want to add, just takes time I don't have much of.

@Anthropic No worries -- I'll see if I can make a PR for it -- but that would be doubtful as well.

@iseessel I am actively working with the other members of json-schema on a ui-schema to better define behaviours but no one ever seems to have enough time, including myself. I'm trying to get work to give me some time but no luck yet.

Here it is a little workaround for this:
function mapDefaults(model, formObj) {
    if (!model) {
        model = {};
    }

    if (angular.isArray(formObj)) {
        angular.forEach(formObj, function(item) {
            model = mapDefaults(model, item);
        });
    } else {
        if (formObj.items) {
            model = mapDefaults(model, formObj.items);
        }

        if (formObj.tabs) {
            model =  mapDefaults(model, formObj.tabs);
        }

        if (formObj.key && !angular.isUndefined(formObj.default)) {
            model[formObj.key] = formObj.default;
        }
    }

    return model;
}

var yourModel = mapDefaults({}, yourForm);


fix: lint pod fail

This PR should fix https://github.com/bucketeer-io/ios-client-sdk/actions/runs/6117473016
Changes

[x] Update GitHub Action PR's flow to check the pod lint
[x] Fix missing check for tvOS13
[x] Fix tvOS example could not build

@cre8ivejp please help me to take a look


Lowered Eldritch End node

Need verification doesnt impact hdin or light sorc.

Should be good to go now. No conflict with hdin or light sorc.

What's this for? @D2RLegit

With latest eld change blizz sorc teleports to far north of where eld is dead and will miss some drops during pickit. This fixed that issue.


[release-v3.28] Auto pick #8922: set MTU on bpfin/out.cali to match host

Cherry pick of #8922 on release-v3.28.
#8922: set MTU on bpfin/out.cali to match host
Original PR Body below
Set the MTU to match the smallest MTU of the host devices as per the current autodetection. That makes sure that if large MTU is used, the extra device does not create a bottleneck with a small MTU. Also when MTU changes, on host devices, it get adjusted automatically.  If an overlay is used, the special device MTU is adjusted to the size of the overlay.
Fixes https://github.com/projectcalico/calico/issues/8868
Description

Related issues/PRs

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

ebpf: set bpfin/out.cali MTU to the smallest of all host ifaces including overlay. That means if jumbo frames are used, this device also uses them.

Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one docs-* label.

docs-pr-required: This change requires a change to the documentation that has not been completed yet.
docs-completed: This change has all necessary documentation completed.
docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

release-note-required: This PR has user-facing changes. Most PRs should have this label.
release-note-not-required: This PR has no user-facing changes.

Other optional labels:

cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

unrelated faiures fixed elsewhere


Add rocky and nar packages

I've added two packages that could be useful for the community. Cheers
https://github.com/h2non/rocky
https://github.com/h2non/nar

Let's see what @sindresorhus thinks but I'd rather see those modules mature a little before adding them to the list.
Please read the contribution guidelines before submitting a PR:

Make an individual pull request for each suggestion.

Use the following format: [package](link) - Description.

Don't mention Node.js in the description as it's implied.

Start the description with a capital and end with a full stop/period.

Now I'm following the guidelines strictly. Sorry for that.
Regarding to the package maturity, nar has more than 1 year and it could be stable. It has been downloaded more than ~10K times. rocky is relatively young, that's true, however I believe that this list should provide potential useful and genuine packages for the community, not just in the sense of consuming packages in a single way, also assisting and inviting the community to improve them if they worth to.

rocky looks interested and definitely worth including, but I'll echo @arthurvr's sentiment that it needs some time to mature before I want to recommend it. Try submitting it again in a month.
Happy to add nar now though :)

@sindresorhus Sounds very reasonable.
There's the PR update with rocky removed. Thanks

What about now?

What about now?

There's still the removal of one of those lines included.

Oh, I see, from the HTTP section :S


[$1000] mweb - Clicking browser/system back button takes user to the wrong page in 2FA page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open ND on mWeb
Go to settings > security > two factor authentication
Copy the code and click next
Go offline
Click on the back button on top left corner twice to take you to security page
Go online
Click on two factor authentication
Click on system/browser back button

Expected Result:
App should take user back to the security page
Actual Result:
App takes user to the step two "two factor authentication"
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[x] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.30-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/5fb8f51a-9b5e-4b3d-afa6-8d942f149fef
https://github.com/Expensify/App/assets/93399543/c0d9b38f-0371-4649-82d2-522525ccf491
Expensify/Expensify Issue URL:
Issue reported by:  @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687522558210329
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~010bb7da3c3eeb9e97
Upwork Job ID:<PHONE_NUMBER>341146624
Last Price Increase: 2023-06-27

I was able to reproduce the bug both by going offline and without going offline. I'm not sure that step is necessary here.

Hmmm @WoLewicki I tried to see the code but in terms of navigation everything seems to be working as expected goBack  is called as expected and navigate called right as well. From my point of view it might be a border scenario of React Navigation and how it handles window.history.
PS: Third time I try to check navigation issue, I might have to desist the topic 😂

I see there were few issues with react-navigation and browser's behaviour. have few doubts and need some discussion any help?

Does this 2FA flow use react-navigation navigation and changes in the URL? Or is it the same as Request Money flow was before? If so, it probably is the same issue as https://github.com/Expensify/App/issues/21218, but if not, we would have to dig deeper since probably there is some other bug causing it.
Can we also confirm it only happens on iOS web? Isn't it the same on web with browser back button @kbecciv ?

Hey @WoLewicki  I can confirm it happens in web as well. This now is not like Request Money in this flow Navigation.navigate is indeed used. I can confirm it is not the same issue here there is no custom navigation.

Waiting for proposal.

I can't re-produce it again. Maybe fixed?!


Add Types for configuration

As a developer, it would make integration easier by creating types that represent the Vyos configuration types. This would add simplicity of integration and type safety.
I would think it best to add one at a time the different resources as structs initially. Then, eventually creating a common interface for the structs to implement (CRUD or something similar) that could translate from something common to the proper vyos way.
An example would be something like:
type VPN struct {
  IPSec IPsec
...
}

func (v *VPN) Create() {
  op := "set"
  path :=  ["vpn"]
...
}

Each subtype would implement the path returning up which could then be joined so that you dont have to create crazy
logic to understand the path.
I have talked about writing code back before, sorry for the absence, there were some health issues. I'm back and happy to start contributing if you're still maintaining.

@jtcarnes no worries at all, hope everything is okay. Health comes first!
I'm all for this proposal, this sounds super useful. I'm thinking we can layer more fine-grained services on top of the base ConfigService, kind of like what @ammmze did with ContainerImageService, but for individual config objects. We could probably reuse the ConfigService under the hood.
In the mean time, I'll reorganize some things so it's easier to add new services.


Implement sl-date-picker functionality natively, removing Bootstrap-Datepicker dependency

Evaluate current functionality and determine if any modifications are desired
Consider leveraging sl-calendar component
Create/modify tests
Update http://softlayer.github.io/sl-ember-components/#/browsers
Update http://softlayer.github.io/sl-ember-components/#/demos/sl-date-picker

Addressed by #1458


License

Hi, this looks really interesting.
The license is prohibitive for a lot of folks.
Would you consider making it MIT or Apache 2.0?

I'm not very familiar with license, I will update a proper license later.


Blank Map Display

Just installed the latest awips-cave.msi for windows. CAVE opens fine and data technically loads as I can sample it. But nothing appears. Main map display is black and 4 display panes are also black. Deleted caveData and rebooted several times.

It appears as though it's an OpenGL issue. Running my laptop through a docking station to monitors. When monitors are directly connected to the laptop version 4.4 of OpenGL is running, when going through the docking station OpenGL1.1 is running. Any way to work around this with this software package? Have reached out to DisplayLink as well. Thanks.

Was able to work around by unplugging from my docking station, loading cave, and plugging back into the docking station.


Sync status tracking

In order to put some information into rosetta about node's sync status, we temporarily (as workaround) added to the /network/status response, specifically into current_block_identifier.index, the height of the latest synced block.
Expect also in this case:
current_block_identifier.hash  =<PHONE_NUMBER>000000000000000000000000000000
current_block_timestamp = 0
Example response when node is syncing:
{"current_block_identifier":{"index":6838,"hash":"0000000000000000000000000000000000000000"},"current_block_timestamp":0,"genesis_block_identifier":{"index":0,"hash":"0171a0e402201c1fb0c2e62d1857e523ea79898051c91e4b042c2ed96c4995c5002789570a210000000000000000"},"peers":[{"peer_id":"12D3KooWHCtoCvWMFodJQsZWCtA1XqxQvtumLWqe1FGwU7PyhVD7"},,...

Hi @qiwu7

* 1. Use the new `syncing info` field in the API interface to report the status of the message sync process (while keeping current_block_identifer.index == genesis_block_identifer.index == 0)

This new field syncing info is already available on the rosetta-sdk ?

Yes. it's available now with the new release. See PR here  ,and the new field in SDK here

Great! the release has not been made yet, right?

It's available with release 1.4.1
https://www.rosetta-api.org/docs/NetworkApi.html#response-2

ok! I'll make the update.

SyncStatus added on  #13


⚠ Jerry Savelle Ministries International Australia has degraded performance

In d2a4584, Jerry Savelle Ministries International Australia (https://jsmiaustralia.org) experienced degraded performance:

HTTP code: 500
Response time: 6620 ms

Resolved: Jerry Savelle Ministries International Australia performance has improved in 31af8c1 after .


displaying features without coordinates

We now have some features in Chado that don't have sequence coordinates (https://github.com/pombase/pombase-chado/issues/110). The original use case was to put promoters in annotation extensions, even if the promoter sequence/site isn't known precisely. As far as I know, that's still the only way we've used them.
We never did get around to thinking about how to display those extensions on pombase pages, so I'm now opening this ticket for it. Right now, nothing is displayed (https://github.com/pombase/curation/issues/2145), which is suboptimal.
Curators (@Antonialock @ValWood) to discuss and decide how they should look, and then @kimrutherford  to implement.

I've made a quick fix so it at least shows something while you decide how they should look.

we may not be able to improve on that ;)

yep that will do!


How to use PostgreSQL transaction in vapor

I want to save a lot of data at once ,but I don't how to use postgresql transaction,Who can give an example.

Closing in favor of vapor/vapor#1113.


scanning doesnt work

scanner doesnt scan equipped weapons and artifacts
tried restarting the app but doesn't help

Hello. Can you sand us screenshot app, and write your Windows version

Windows 11 Home 21H2

Do you have error in the error log at the bottom of the app?
You can try to deactivate the checkbox "Equip Weapon", try to scan and after that activate checkbox and try to scan again.

sry for a late replt buy ok ill try that asap

Hi there you must select one or more scan items from the left side of the application to begin a scan. But thanks for highlighting this for me lol


haste-compiler-<IP_ADDRESS> doesn't compile with GHC 7.8.4

Citing from http://hydra.cryp.to/build/599496/log/raw:
src/Data/JSTarget/PP.hs:87:22:
    No instance for (IsString Builder) arising from the literal ‘"  "’
    In the ‘indentStr’ field of a record
    In the expression:
      def
        {nameComments = True, useIndentation = True, indentStr = "  ",
         useNewlines = True, useSpaces = True}
    In an equation for ‘debugPPOpts’:
        debugPPOpts
          = def
              {nameComments = True, useIndentation = True, indentStr = "  ",
               useNewlines = True, useSpaces = True}

This should be fixed with <IP_ADDRESS>. I gave up trying to juggle those different library versions and just added a dependency on bytestring >= 0.10.4. Can you confirm that it is indeed fixed?

Yes, the new version compiles fine: http://hydra.cryp.to/job/nixpkgs/haskell-updates/haskellngPackages.haste-compiler.x86_64-linux.


Cmd+Ctrl+Space shortcut doesn't work on OS X

If you press ⌘⌃Space (Cmd+Ctrl+Space) on OS X, you should get the "Special Characters" popup. However, the shortcut doesn't work, but going through the Edit menu does.

I can confirm this is still a problem in May 2016. As emoticons picks up and get more and more important on phones, also desktop should support them just as easily when the OS support it (as OS X does with Cmd+Ctrl+Space).

Confirming, this is still an issue.

Please try the latest version: https://github.com/aluxian/Messenger-for-Desktop/releases


Validation Code tag cleanup sdk python

1907184
No experience in this repo - it's public repo. We can follow up later.

Docs Build status updates of commit b0f6ff2:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit ac1cef0:
:warning: Validation status: warnings
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 69f434f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-services/legacy/servicebus.md
:bulb:Suggestion
View (azure-python-previous)
Details

docs-ref-services/preview/servicebus.md
:bulb:Suggestion
View (azure-python-preview)
Details

docs-ref-services/legacy/servicebus.md

Line 19, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/python/api/overview/azure/servicebus/client?view=azure-python' will be broken in isolated environments. Replace with a relative link.
Line 19, Column 3: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/python/api/overview/azure/servicebus/client?view=azure-python
Line 36, Column 9: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/service-bus-messaging/service-bus-create-namespace-portal' will be broken in isolated environments. Replace with a relative link.
Line 162, Column 107: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/rest/api/servicebus/peek-lock-message-non-destructive-read' will be broken in isolated environments. Replace with a relative link.
Line 273, Column 66: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/service-bus-messaging/service-bus-migrate-acs-sas' will be broken in isolated environments. Replace with a relative link.
Line 380, Column 70: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/rest/api/servicebus/message-headers-and-properties' will be broken in isolated environments. Replace with a relative link.
Line 417, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/service-bus-messaging' will be broken in isolated environments. Replace with a relative link.

docs-ref-services/preview/servicebus.md

Line 19, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/python/api/overview/azure/servicebus/client?view=azure-python' will be broken in isolated environments. Replace with a relative link.
Line 19, Column 3: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/python/api/overview/azure/servicebus/client?view=azure-python
Line 36, Column 9: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/service-bus-messaging/service-bus-create-namespace-portal' will be broken in isolated environments. Replace with a relative link.
Line 162, Column 107: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/rest/api/servicebus/peek-lock-message-non-destructive-read' will be broken in isolated environments. Replace with a relative link.
Line 273, Column 66: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/service-bus-messaging/service-bus-migrate-acs-sas' will be broken in isolated environments. Replace with a relative link.
Line 380, Column 70: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/rest/api/servicebus/message-headers-and-properties' will be broken in isolated environments. Replace with a relative link.
Line 417, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/service-bus-messaging' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@dbradish-microsoft And one more that is ready for review -

@TimShererWithAquent , please take out of draft mode and sign off.  Thank you.

#sign-off

@barbkess - Is there a procedure for getting PRs merged in this repo? - Thanks

@herohua @barbkess
Is there a particular process we need to follow to get PRs in this repo merged? I'm seeing both of you listed (in different places) as content/repo owners. If my information is incorrect, do you know who we should reach out to?
Thanks!

We closed the other PR for this repo - MicrosoftDocs/azure-docs-sdk-python/pull/1514


Need to document the configurations for show "ActualAuthFailureReason"

My suggestion

When the account is locked due to fail attempts, UI shows the "Login failed! Please check your username and password and try again" message even the actual error message is account locked.

We need to add some configurations as mentioned in https://github.com/wso2/product-is/issues/13195#issuecomment-1111722031 to show the actual auth failure reason.

Suggest to document those information

Related issues
https://github.com/wso2/product-is/issues/13195

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


How do I make changes to the OpenCR code?

ISSUE TEMPLATE ver. 0.4.0

Which TurtleBot3 platform do you use?

[x] Burger
[ ] Waffle
[ ] Waffle Pi

Which ROS is working with TurtleBot3?

[ ] ROS 1 Kinetic Kame
[ ] ROS 1 Melodic Morenia
[x] ROS 1 Noetic Ninjemys
[ ] ROS 2 Dashing Diademata
[ ] ROS 2 Eloquent Elusor
[ ] ROS 2 Foxy Fitzroy
[ ] etc (Please specify your ROS Version here)

Which SBC(Single Board Computer) is working on TurtleBot3?

[ ] Intel Joule 570x
[ ] Raspberry Pi 3B+
[x] Raspberry Pi 4
[ ] etc (Please specify your SBC here)

Which OS you installed on SBC?

[ ] Raspbian distributed by ROBOTIS
[ ] Ubuntu MATE (16.04/18.04/20.04)
[x] Ubuntu preinstalled server (18.04/20.04)
[ ] etc (Please specify your OS here)

Which OS you installed on Remote PC?

[ ] Ubuntu 16.04 LTS (Xenial Xerus)
[ ] Ubuntu 18.04 LTS (Bionic Beaver)
[x] Ubuntu 20.04 LTS (Focal Fossa)
[ ] Windows 10
[ ] MAC OS X (Specify version)
[ ] etc (Please specify your OS here)

Please describe the issue in detail.

I am trying to get rid of the low voltage warning buzzer. I realized that the odometry doesn't work after this.
I followed these instructions to find where I need to deactivate the alarm:
https://answers.ros.org/question/296145/turtlebot3-low-battery-beeping/?comment=387904#post-id-387904
But I don't know the actual steps to reupload the opencr packages? The manual simply says
How to modify ROS library code
You can modify ROS library in below paths.
Your/Arduino/Board/Package/Directory/OpenCR/hardware/OpenCR/Version/libraries/turtlebot3
Your/Arduino/Board/Package/Directory/OpenCR/hardware/OpenCR/Version/libraries/turtlebot3_ros_lib
If you want to modify it in the sketch folder, move the above two folders to the “skechbook/libraries” folder.
And I've found that path, but I can't open the .cpp in the Arduino IDE.
How do I flash these changes to the OpenCR?

Hi @royito55. Thank you for your questions.
I think you can find your library folder path in Arduino > Preferences.

In addition, if you refer to the link, detailed explanations from library addition to upload are provided.
Thank you

Hi, thank you for answering.
I don't need to know where my library folder path is, I've already found it.
My question is, once I know where to change the code, how do I reupload these .cpp files into the OpenCR?

To clarify. I have installed the OpenCR in my Arduino IDE. Now, I want to modify that library to deactivate the low voltage alarm, and upload the changes to the physical OpenCR. How can I do this?

Apologies for the delayed response. We have assembled a TF team to address TurtleBot3 issues and are actively working on resolutions. This issue will be closed due to prolonged inactivity.  if the issue persists, feel free to reopen it.


fix the nav section dashboard container

looks like the issue is caused by: https://github.com/microsoft/azuredatastudio/commit/9bcd7cdd80db62f187061b1f61a7eae10d1555a7
with this change, setting the options will cause detecting changes, the fix is to make sure the variables are not undefined.
This PR fixes #10593

Coverage decreased (-0.1%) to 34.783% when pulling b260e9d6632b0ac5e0f48df11c8c709a59de9c9b on alanren/fix-nav-tab into e7f65f45f22ad513b3aaa98fdba37c0d3d9ea83d on master.

Ok - so the issue is that detectChanges is being called before the tabs are set up?

@Charles-Gagnon , that seems true to me. I can only find 2 places in the code base to set the options as Angular input in html templates: agent and navSectionContainer, for agent, the tabs are static contents, that's why it worked for agent, but navSectionContainer is initializing tabs using the ngFor, by the time we set the options, the tabs is not yet initialized.


agent: upgrading deps to 1.29

It's that time again, where we upgrade our kubernetes clusters from v1.28 => v1.29 (with the eventual goal of being at 1.31). Since the version of the neon deps have to be within 1 version of the kubernetes version, I'm upgrading the matching dependencies.
See epic

Broadly LGTM, thanks! Any idea why there's so many removed dependencies in go.sum?

LOTS of duplication. I don't know if that's normal, but it references 39 versions of go?

My guess it that nobody ran go mod tidy before? Sounds strange, but it could explain it. I think go.sum just keeps growing if you don't run go mod tidy, keeping old versions and what not.

A few more things, sorry:

If you plan to cut a release from this branch before merging to main, could you rebase this PR onto the previous release so that we don't accidentally get changes we're not expecting?
This PR basically affects all components, right? Could you remove "agent:" from the PR title to reflect that?
Could you add a description to this PR? e.g., linking to a relevant discussion, issue, etc.

Other than those and the rogue dependency that @kszafran highlighted, seems good to me.

If you plan to cut a release from this branch before merging to main

I don't think I need to, I assume one 1-3 are resolved we can merge this? Or do we need to stick to 1.28 deps for awhile?


Added python module structure to working proxy

Most of the Python test runners look for tests in files called test_<something>.py, so it's a good idea to use that form instead of <something>_tests.py.

Looking really nice so far!

:+1:


Don't push built images by default and bump Ubuntu to 22.04 for analysis image

Fixes #333 and #334

Great work!


Splittermond: Fake Buttons -> Action buttons

I replaced the input/span fake buttons with action buttons. Therefore there is a huge loss of unnecessary CSS that I removed

I replaced a workaround from the early days of the sheet that handles the deletion of masteries with a shorter and more precise version

I also implemented that the overview of the most important values above the sheet is getting updated automatically

Some coding optimization here and there

Action buttons are great! I hope you enjoy them.


The bundle should not hardcode the name of the DB connection

In the bundle, the name default is hardcoded in several places using the connection.
But there is no guarantee that a connection named default will exist (or that it is the default one). DoctrineBundle does not give such guarantee (default is just the name used by the short syntax).

why not #137  is merged? cough cough, "any chance of having #137 in?"
:older_man: learning to ask :+1:


feat(markdown): add render command (fixes #75612)

This adds a command which renders the provided document, or the active
editor if one is available. Following the pattern of some of the preview
commands, it returned undefined if there's no document provided and
no active text editor. Otherwise, seems to work...
const html = await vscode.commands.executeCommand<string>('markdown.render');

A way to render arbitrary strings in addition to documents may be useful at
some point in the future. However, I didn't implement that here as that'd
require some refactoring of the markdown engine. If we're interested though
I could certainly give that a shot.
Fixes #75612

Yes I'd prefer that this api take a string (and an optional configuration object) instead of a document object. That leaves it entirely up to the caller to provide what is rendered
This will make the change a bit more involved so let me know if you have any question about this

Cool, no problem. I'll give it a shot. I think taking a document as an option (string | SkinnyTextDocument) would be beneficial though so that the engine can resolve the appropriate configuration and paths for consumers who want an entire document/file rendered for them.

Considering it more, I'm wondering whether the configuration object is something we'd want to expose. I think the main value add of this functionality is to render a document (or string) with the workspace settings such that it matches the preview, requested in the initial issue. Exposing the options turns this into more of a generic markdown renderer, which imo is not necessarily functionality we want the core editor to provide. It also couples the command API to MarkdownIt; if we wanted to ever change markdown rendering systems, the options might not match up.

Thanks! Will be making some minor changes to api but I'll note these on the original issue

It also couples the command API to MarkdownIt; if we wanted to ever change markdown rendering systems, the options might not match up.

While I agree philosophically, changing the markdown renderer would break every single extension that extends markdown because they all work by chaining a markdown-it extension.
You're already wedded to markdown-it.


Qualify modules under base

 Issue by Lysxia
Saturday May 30, 2020 at 20:28 GMT
Originally opened as https://github.com/antalsz/hs-to-coq/issues/158

Right now the Coq code is compiled with -R base/ "", which causes warnings because these modules have the same names as those under base-thy/.

 Comment by nomeata
Tuesday Jun 02, 2020 at 08:49 GMT

That was a design choice back then (and we learned to live with the warning). Maybe not very Coq’ish, so of course can be changed


Add additional docs for working with kafka in docker

I'm new to Kafka and I had a hard time understanding how to interact with the cluster that I had setup in docker-compose running on my mac. The way the CLI tools are packaged with Kafka was not intuitive to me.
I found kafka-shell when I was looking for something to make connecting and managing my local (docker) cluster a bit easier; I think it's fantastic. It would be great for my use case if you could include some documentation on what a good config might look like for working with kafka in docker for development. I think this is probably a fairly common usage.
For instance:
I found that prefixing the command with a docker exec as descried in the CONFIGURATION.md didn't quite work because the image that I'm using does not have the Kafka bin directory exported to the PATH - is there a specific image I should use for these shell scripts? I'm using wurstmeister/kafka

Hi @blankenshipz,
I haven't used this docker image, so this is interesting. Based on that docker image alone, I don't know if you could use kafka-shell in its current state to run commands via the docker image. It does look like the files are on the path, but they end in .sh which kafka-shell currently does not support. For example, docker run -it wurstmeister/kafka kafka-topics.sh works.
My docker example is based on the Confluent docker images (confluentinc/cp-kafka), which do have the files on the path. A simple way to utilize their docker images can be found here (with ZooKeeper as well):
https://github.com/simplesteph/kafka-stack-docker-compose/blob/master/zk-single-kafka-single.yml
If you do that, then it will work properly. If you'd prefer to use the wurstmeister/kafka image, you could:

Extend that Dockerfile to make it work
Run another daemon container (see my confluent-tools repository as an example)
I could extend kafka-shell with some additional configurations to add in .sh

Let me know if those options work for you. I'll probably add in an additional configuration for the .sh extension this weekend.

Hi @blankenshipz, have you been able to work around this issue? Anything else you need help with?

Hi @devshawn; I haven't had a chance to try it yet but switching to the image you're using should work - I'll reopen this issue if It doesn't.
Thanks!

Just wanted to mention that I also stumbled here trying to use this tool with a kafka/zookeeper deployment into docker kubernetes (using cp-kafka). I get the same error for most commands, for example: sh: kafka-topics: command not found.
I am essentially using the example you posted above, but with docker stack deploy --orchestrator kubernetes

@solarmosaic-kflorence - thanks for the report.
I'd be happy to assist you, but I'd need to know a bit more about your setup and how your config is set up. Feel free to open a new issue 😄. I haven't used docker stack before but I've used this tool with the kubectl prefix to run commands on running k8s containers.

hey @devshawn -- here is an example you can use:
kafka-stack.yaml:
version: '3.3'
services:
  # https://hub.docker.com/r/bitnami/zookeeper
  zookeeper1:
    # Try to keep in sync with MSK
    # echo status | nc <zookeeper server> 2181
    image: bitnami/zookeeper:3.4.13
    hostname: zookeeper1
    ports:
      - "2181:2181"
    environment:
      ALLOW_ANONYMOUS_LOGIN: "yes"
      #ZOO_SERVERS: server.1=zookeeper1:2888:3888
    volumes:
      - zookeeper1-data:/bitnami/zookeeper

  # https://hub.docker.com/r/bitnami/kafka
  kafka1:
    # Try to keep in sync with MSK
    image: bitnami/kafka:2.2.1
    hostname: kafka1
    ports:
      - "9092:9092"
    environment:
      ALLOW_ANONYMOUS_LOGIN: "yes"
      ALLOW_PLAINTEXT_LISTENER: "yes"
      KAFKA_CFG_ZOOKEEPER_CONNECT: "zookeeper1:2181"
    volumes:
      - kafka1-data:/bitnami/kafka

deploy with docker stack deploy --orchestrator kubernetes -c kafka-stack.yaml kafka-stack
I can now add the following to my ~/.kafka-shell/config: command_prefix: kubectl exec svc/kafka1 --
But when I try to execute commands, I get:
> kafka-topics --list
OCI runtime exec failed: exec failed: container_linux.go:346: starting container process caused "exec: \"kafka-topics\": executable file not found in $PATH": unknown
command terminated with exit code 126

Looks like it is for the same reason, commands are exposed in these docker images with .sh extensions.

FWIW it looks like the .sh commands are defacto: https://kafka.apache.org/quickstart

That's super helpful, thanks @solarmosaic-kflorence!
I'll add a config for using .sh commands and push a release tomorrow. :)
Hope that'll help!

@devshawn since we are slightly off-topic on this ticket, I have created #18 to track. It would probably be useful to add documentation for this use-case at the same time as well.


Migrate translations to the Minetest localization format

We should migrate the translations to the Minetest localization format, so that we can benefit from client-side translations.
If anyone has spare time, feel free to open a pull request :slightly_smiling_face:

I believe this issue can be closed. I think it has been fixed.

Indeed, this was implemented by https://github.com/minetest-mods/moreblocks/pull/186.


GroupBy not working as expected in 2.26.0

Hi Guys
I have installed bedtools 2.26.0 and groupby is not working as expected... I tried the same exact command on an earlier version and it did the right thing
consider a file test.txt with the following tab-delimited data:
5S_rRNA 106
5S_rRNA 111
5S_rRNA 115
5S_rRNA 116
5S_rRNA 118
5S_rRNA 118
5S_rRNA 274
5S_rRNA 76
5S_rRNA,RNA5SP423       1338
7SK     111
7SK     188
7SK     194
7SK     2774
7SK     290
7SK     300
7SK     321
7SK     356
7SK     377
7SK     382
7SK     74
bedtools-2.23.0/bin/groupBy -g 1 -c 2 -o sum -i test.txt
results in the expected output:
5S_rRNA 1034
5S_rRNA,RNA5SP423       1338
7SK     5367
bedtools-2.26.0/bin/groupBy -g 1 -c 2 -o sum -i test.txt
if done on the lastest version I get:
7739
which is the sum of all the 2nd column, but not grouped by the 1st column as I requested
Is this a known bug?

anyone?

Sorry, was travelling. This is fixed in master and will be in the next release (a few weeks out).

Apologies ... should have checked before... there had been other people reporting on this.
Many thanks

Sorry to reopen this ... but I downloaded te latest from the repo and this is this not fixed ... when you say it is fixed on master, what do you mean? in this not where you keep the master repo?!

I suspect your problem is that you are running the "groupby" shell script and the script you are running is still pointing to the bedtools executable for 2.26.0 (not what you compiled from github). Try running:
bin/bedtools groupby -g 1 -c 2 -o sum -i test.txt

From the directory in which you cloned and compiled bedtools from Github.  I just tried this and it works as expected. For this reason, I would recommend trying to transition your usage of bedtools to explicitly calling the bedtools executable with a subcommand.
Please reopen if this still does not work for you.


Change copy source from GitHub to Blob

Copy from GitHub recently started failing, perhaps due to service change

/azp run js - storage-blob - tests

I remember that copying from blobs within the same storage account will complete immediately,  and we might not want this behavior when testing poller.

Add @chradek @HarshaNalluru who may have more context on this test.

I remember that copying from blobs within the same storage account will complete immediately, and we might not want this behavior when testing poller.

I'm testing copying from a different account

Also appears to hang when using a second storage account in the same region.  Next testing a storage account in another region.

Actually it does appear to work on my dev machine when copying from another account in the same region.  I forgot to rebuild tests.

I think the cleanest solution here would be to:

Create a secondary test storage account, add secrets to keyvault, add env vars
Test creates blob in secondary test storage account then copies to primary test storage account

For now we are planning to use a simpler fix which just uses a different static URL.  @jeremymeng is working on that PR.


support setting debug log targets using the DEBUG environment variable

Add a simple mechanism to the logSetup function so that it parses the DEBUG environment variable and extract a list of targets to enable at debug level, or * to set the global log level.
Fixes #23

@mstemm @VladVega

Lol you lowered the branch percentage just like I did in #22.
lgtm.


Database secrets are currently deprecated

Greetings,
What can we do to deal with this when Google close the tap? Will this library be updated to use Firebase sdk? Its for a future proof project
https://i.stack.imgur.com/W9NpP.png
Thank you

Did you have checked these examples?
Or read the document?


fix: ssh url input

Description
Fixes issue by allowing - in subdomain/domain.
Fixes #15432
Type of change

Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

@IAmAnubhavSaini Can we update the place holder values as well? We can go with as @vuiets suggested here -
https://github.com/appsmithorg/appsmith/issues/15432#issuecomment-1195414955

/ok-to-test sha=bc277b82a7d421a841f54501261e9777a3773257

@AnaghHegde @vuiets I am not inclined to touch strings for git right now. It can be updated anyway without engineering efforts. Please create a merge request with appropriate changes to messages.ts and messages.test.ts.

/ok-to-test sha=7f16383

/ok-to-test sha=7f16383