Q 4.3

From the framework document:
Question text:
Rate the magnitude of impact of the cause(s) of decline on mangrove loss and degradation - High, Moderate, Low
Notes:
Only complete question if the answer to Q4.1 is ‘Yes’.
Users are asked to rate the magnitude of impact of the cause(s) of decline on mangrove loss and degradation identified in Q4.2. The term "magnitude" is used here in the sense of degree or size.
Interaction mockup (same mockup for 4.2 because they're related)
https://codepen.io/alanjleonard/pen/WNMGyKq

Description:
For each of the selected items in question 4.2, show the value next to a selected checkbox. If the user uncheckes the checkbox, the item is removed from this question. the question is removed regardless of the state of the radio buttons. Then the user can add it again from the previous question.
Under each item, show High, Moderate, and Low Magnitude radio buttons, and "Don't know' (because it's not required). Default to "Don't know".

I lumped this with 4.2 as they are tied together


Feature/add resources to invocations

It is not urgent but it would be better if we could define general purpose Sampler API and use count/time aware samplers in common, not just specific to metric


Initially collapsed SplitterPane has size 0 on first expand

Describe the bug
When I create a horizontal Splitter with 2 SplitterPanes, and set the right one to Collapsible="true" Collapsed="true" Size="300px", it will expand with size 0.
When I drag it to have a size, collapse end then expand it, the size it had on collapse is restored.
To Reproduce
Steps to reproduce the behavior:

Have a page with

<RadzenSplitter Orientation="Orientation.Horizontal">
    <RadzenSplitterPane Collapsible="false">
        Left pane
    </RadzenSplitterPane>

    <RadzenSplitterPane Collapsible="true" Collapsed="true" Size="300px">
        Right pane
    </RadzenSplitterPane>
</RadzenSplitter>

Expand the right pane
Pane expands with size 0 -> Error, should restore with 300px
Drag splitter to give right pane some size
Collapse right pane
Expand right pane
Right pane restores size as expected

Expected behavior
When the right pane is expanded the 1st time, it should have the configured Size of 300px.
Desktop (please complete the following information):

OS: Windows 11
Browser: Edge
Version: 4.31.5

The problem comes from the fact that the non collapsible pane do not have any size defined and will use 100%. You can avoid this by defining some size:
<RadzenSplitter Orientation="Orientation.Horizontal">
    <RadzenSplitterPane Collapsible="false" Size="300px">
        Left pane
    </RadzenSplitterPane>

    <RadzenSplitterPane Collapsible="true" Collapsed="true" Size="300px">
        Right pane
    </RadzenSplitterPane>
</RadzenSplitter>


Nested fields query fix

Description
fix nested fields query and filter issues as specified in the flowing issues
Issues Resolved

https://github.com/opensearch-project/opensearch-spark/issues/508
https://github.com/opensearch-project/opensearch-spark/issues/503

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

please also add the command description in the readme section at the last part of the page

https://productionresultssa0.blob.core.windows.net/actions-results/26dca0eb-8ee8-420f-97e1-25f5c82f33b1/workflow-job-run-4946c80c-120b-5c17-357b-710b252b57f9/logs/job/job-logs.txt?rsct=text%2Fplain&se=2024-08-16T21%3A52%3A54Z&sig=qplZc%2FddY1yOkmgbUtggycrJgfXwW%2Bxof9RZsidjaF4%3D&ske=2024-08-17T06%3A02%3A09Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2024-08-16T18%3A02%3A09Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2024-05-04&sp=r&spr=https&sr=b&st=2024-08-16T21%3A42%3A49Z&sv=2024-05-04
2024-08-16T20:48:45.5854397Z [info] *** 3 TESTS FAILED ***
2024-08-16T20:48:45.5864995Z [error] Failed tests:
2024-08-16T20:48:45.5866564Z [error] 	org.opensearch.flint.spark.ppl.FlintSparkPPLCorrelationITSuite
2024-08-16T20:48:45.5868249Z [error] 	org.opensearch.flint.spark.ppl.FlintSparkPPLNestedFieldsITSuite
2024-08-16T20:48:45.5869868Z [error] 	org.opensearch.flint.spark.ppl.FlintSparkPPLBasicITSuite


migrate to go mod

while building the source, I got the following error
*bolt.Tx has no field or method Root

I fixed that with the commit below, not sure if it's accurate but it works, and the other commit moves the project to go mod.

Hi, thanks for the PR! Unfortunately, this project isn't supported anymore. At least, this version (v2). I have some plans to work on a new version. You can track the progress here (v3 branch)


Collect changelog from migrations

@emilskra Let's split it into two tasks and put it under a milestone.
The whole task can become a milestone that contains two tasks: make changelog in some format such as json as the first task and put to swagger as a second task. WDYT?

It needs to be collected from the entire VersionBundle into some simple format such as JSON so that it can be transferred anywhere.
I believe that making it a method on the VersionBundle makes sense such as def changelog(self)


Add size labels to pull request

Pull Request
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#183  👈
#182
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JackPlowman and the rest of your teammates on  Graphite

Merge activity

Oct 27, 4:09 AM EDT: A user merged this pull request with Graphite.


Error with angular-cli and AoT

I get the following error when i try to build/serve my project using angular-cli beta 16 and ng2-tag-input module version 0.3.4 with the --aot option:
Error encountered resolving symbol values statically. Calling function 'require', function calls are not supported. Consider replacing the function or lambda with a reference to an exported function, resolving symbol TagInputModule in <PROJECT_PATH>/node_modules/ng2-tag-input/index.ts, resolving symbol <MODULE_NAME> in <MODULE_TS_FILE_PATH>, resolving symbol <MODULE_NAME> in <MODULE_TS_FILE_PATH>

Hi @FallenRiteMonk, can you try with the version 0.3.6? let me know :)

fixed the problem thanks!

I still cant test if it completely works due to some other problems i have, but i found this! maybe have a look at it:
<EMAIL_ADDRESS>

With the same circumstances, I get this error message:
Error: Unexpected value 'TagInputModule' imported by the module 'SharedModule'

Just updated to the new version of angular-cli (beta.20-4) in the hope to be finally able to use aot, but i get the exact same error:
Error: Unexpected value 'TagInputModule' imported by the module 'MODULE_NAME'

According to this thread the package would need to be compiled by ngc first in order to generate a required index.metadata.json file.

Hi,
the library should be working with AOT now. Please reopen if still an issue (and sorry for the huge delay, I just found some time as am on holidays)


Issue-#3567 : Fixed the described bugs

Fixes:

Changed some words to make it more meaningful.
( "Are you sure you want to delete your account? This action can't be rolled back.")

Converted lowercase into uppercase
( "Delete your Account" into "Delete Your Account")

@aryanvarma7272 I don't think 'rolled back' fits here ... rather just use reverted or reversed and remove the back.


Flaky gateway_reboot_test

Test: gateway_reboot_test FM: v0.2.1 CLI: current GW: current
CI failure: https://github.com/fedimint/fedimint/actions/runs/8714897075/job/23905886816
It looks like route_hints is returning different values causing flakiness in back-compat.

I think I found the root cause but not sure of a clean fix yet.
When we finalize devfed, we eagerly start multiple futures including polling for registered gateways and opening channels.
https://github.com/fedimint/fedimint/blob/e892eace5409269eca53db9dccd3f7216d4bbe30/devimint/src/devfed.rs#L264-L265
The last step of opening a channel updates the channel policy, which explains the diff observed for base_mast, proportional_millionths, and htlc_minimum_msat.
https://github.com/fedimint/fedimint/blob/47e80ea4413cb8910242f8d72b9c46c884df7433/devimint/src/external.rs#L648-L657
internal_client_gw_registered may finish before we've updated the channel policy, which causes the flake.
I've reproduced the flake locally and verified that there's no more flake if we simply don't update the channel policy. Still chewing on a more elegant solution.


Adopting resources created by helm hook doesn't work

We are deploying a pvc via a pre-install hook which is then used from within the main deployment and are currently having the problem that this pvc is not deleted after release deletion. To fix this issue, we are trying to deploy the same pvc without the hook annotations, while adding the adoption label and annotations to both pvcs as described in #7649. The installation still fails, with helm not adopting the pvc created during the hook.
$ helm install testenc .
Error: persistentvolumeclaims "testenc-madana-enclave" already exists

apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: {{ include "madana-enclave.fullname" . }}
  labels:
{{ include "madana-enclave.labels" . | indent 4 }}
    app.kubernetes.io/managed-by: Helm
  annotations:
    meta.helm.sh/release-name: {{ .Release.Name }}
    meta.helm.sh/release-namespace: {{ .Release.Namespace }}
    "helm.sh/hook": pre-install
    "helm.sh/hook-weight": "2"
spec:
  accessModes:
    {{- toYaml .Values.enclave.pvc.accessModes | nindent 4 }}
  resources:
    requests:
      storage: {{ .Values.enclave.pvc.storage }}

---

apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: {{ include "madana-enclave.fullname" . }}
  labels:
{{ include "madana-enclave.labels" . | indent 4 }}
    app.kubernetes.io/managed-by: Helm
  annotations:
    meta.helm.sh/release-name: {{ .Release.Name }}
    meta.helm.sh/release-namespace: {{ .Release.Namespace }}
spec:
  accessModes:
    {{- toYaml .Values.enclave.pvc.accessModes | nindent 4 }}
  resources:
    requests:
      storage: {{ .Values.enclave.pvc.storage }}

Output of helm version:
$ helm version
version.BuildInfo{Version:"v3.4.2", GitCommit:"23dd3af5e19a02d4f4baa5b2f242645a1a3af629", GitTreeState:"clean", GoVersion:"go1.14.13"}

I'm having the same issue - how can we get around this?


Some changes

Add my 2 LINE bots.
Add my 2 Discord bots.
Add discord.js in 'Open Source' section.

LGTM.
Thanks for your contribution🙂


ng add @angular/pwa doesn't create service worker script

From @phl3x0r on May 17, 2018 9:6

Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request

Area
- [ ] devkit
- [x] schematics

Versions

$ node --version
v8.9.0

$ npm --version
3.10.10

$ ng v
...
Angular CLI: 6.0.1
Node: 8.9.0
OS: win32 x64
Angular: 6.0.2
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router, service-worker

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.6.1
@angular-devkit/build-angular      0.6.1
@angular-devkit/build-ng-packagr   0.6.1
@angular-devkit/build-optimizer    0.6.1
@angular-devkit/core               0.6.1
@angular-devkit/schematics         0.6.1
@angular/cli                       6.0.1
@angular/pwa                       0.6.3
@ngtools/json-schema               1.1.0
@ngtools/webpack                   6.0.1
@schematics/angular                0.6.1
@schematics/update                 0.6.1
ng-packagr                         3.0.0-rc.5
rxjs                               6.1.0
typescript                         2.7.2
webpack                            4.6.0

Repro steps

create a new project, then run ng add @angular/pwa
serve the app in production mode.
The log given by the failure

Failed to register a ServiceWorker: A bad HTTP response code (404) was received when fetching the script.
Desired functionality

should work out of the box, without manually installing other packages or changing paths
Mention any other details that might be useful

Copied from original issue: angular/devkit#931

See https://github.com/angular/angular-cli/issues/12914


Add support for calling

When using messenger, incoming calls are not allowed to be accepted (it says the call must be accepted with safari)

wontfix


Customize listview in ng-admin

I would like to customize listview in ng-admin, and then I found the doc that describes the way to customize listview. But in the doc, there is not any tip or information about how to get data in the template of listview modified by myself. Finally, I have to use an ugly method to get data in the template of listview that showed below.

Is there any better way to get data?
Thx.

You can use entry.values.yourFieldName : (example of a template() for field) updating entry.values will update the data and if you submit the form, the data will be saved. You can use ::entry which is a copy of the entry given (I think). This can be use in list template() but it would be better to do it case by case (field by field), or modify all the template starting from the default html given in the source.

 0">

                {{ 'Name' | translate }}

                {{ attachedFile | translate }}

    {{ 'Empty' | translate }}

I cannot get data by ::entry and entry.values.
transportWay.listView().template(transportWayListTemplate)
I replaced the default template of listview by transportWayListTemplate.
In the transportWayListTemplate, I cannot load data from entry.values.

Did @hobywhan answer helped you out.
Starting from the existing listview default template may help

Hello,
As explained in the README, the GitHub issue tracker is for bugs and enhancement requests.
So I close this issue, but feel free to write a question on StackOverflow with the tag ng-admin.
Thanks for using ng-admin!


Draft Key Manager

A requested feature is to be able to configure keyboard shortcuts (existing or to add some to commands that don't have any by default). This is a proposed method to centralize keyboard shortcuts in a manager. This is a preliminary step to then add a configuration page. This pr is a draft, a proof of concept because it was too complex to explain without showing any code. It only implements a few example commands.
Technically,

The HotKey structure is a VirtualKey/VirtualKeyModifiers pair, it includes a specific ToString and parser (ex: F1, Ctrl+Shift+1, ...)
IKeyboardAction represents an action that can be assigned to hotkey. Each action has its own implementation.
(I)KeyboardManager manages the execution of actions and the assignment of actions to custom shortcuts. It is initialized with the list of actions.
All shortcuts are moved to MainPage, but KeyboardAccelerators are populated by the manager.
Menus can use the manager to display the shortcut in a tooltip or menu entry.
Modifying a shortcut applies without rebooting (but current code has no example where it is done).
The listview manages some shortcuts themselves. We had to capture the event to prevent it from triggering and call the manager to trigger the shortcut manually. You will have to do this for other actions.
We use KeyboardAccelerator to intercept only active shortcuts. It is no longer necessary to find the correct command according to the keys pressed, we have it directly according to the hotkey.

It will be necessary to manage all the commands before managing the storage and the modification of the shortcuts. The manager will have to be divided into 2 classes, one to manage user shortcuts and one to manage the updating of controls.
Validation
How did you test these changes?

[x] Built and ran the app
[ ] Tested the changes for accessibility

I think this is the opposite of what we're going for, you shared a UI concept a while back that I really liked, and I think we should be working towards that. Let's continue planning in the relevant issues before continuing with the PR. https://github.com/files-community/Files/issues/9559#issuecomment-1186572147

It will be necessary to store all the hotkeys (user and default) to prevent assigning the same shortcut twice.
It will also be necessary to be able to apply the hotkeys. Currently they are hard-coded in views and using binding does not work for KeyboarAccelerator (no update of a modified observable value). With the current code, when we modify a hotkey, we have to change in several places (the view and the code) and it differs according to the hotkey. Some shortcuts are also duplicated (ModernShellPage and ColumnShellPage).
This pr centralizes the management of hotkeys so that everything is done in one place. Actions have a label, a default value and a code that will be used for storage. It will be very easy then to add the interface containing the pickers.

@yaichenbaum @d2dyno1
I continued my analysis (thank you for your comments) and here are some food for thought.
Problems with the current implementation.

It is not possible to customize keyboard shortcuts, menus or buttons.
Actions are not centralized. Modifying a glyph requires modifying it everywhere (contextual menu, toolbar, ...)

The problems of this draft.

The execution is done in the action and the action is triggered globally. This forces the action to know all the context to know who to do (for example in which panel).
It forces to provide the context before the call because the call has no argument.
Displaying action data in controls is complex because controls do not have direct access to actions.

Proposed solution.

IAction describes an action without its behavior (code, label, description, hotkey, glyph, ...). Each action has its implementation.
The IActionViewModel interface (which has only one implementation) provides an action for the UI (label, command, icon, keyboardaccellerator, ...).
The IActionManager service contains all the ActionViewModel (one per property). The UI uses it to display the labels of buttons, menus, fill in keyboard shortcuts, ... No more repeating icons or labels.
This service has a method to trigger an action (by its name) and an event triggered at each action.
Components subscribe to the event and optionally perform the action (and stop the propagation).

With this system, we can keep the processing of actions closer to their location. This system can be implemented gradually.

The method proposed in my last post poses insurmountable problems. I advanced on the functionality by simplifying the code and using commands. I will update soon.

@cinqmilleans


6.0: [MoveOnlyAddressChecker] Fix empty deiniting struct representation.

Explanation: Fix MoveOnlyAddressChecker miscompile caused by not representing empty struct with deinit.
The checker represents each type as a bitfield.  An empty struct without a deinit gets a single bit--that bit corresponds to the whole struct.  That allows the checker to track uses of the whole struct as a use of some bit.
Previously, the checker only represented an empty struct with a deinit as a single bit too.  The single bit in this case corresponds to the deinit.  When the deinit is dropped via discard, there is still an empty struct whose lifetime needs representation in bits--it should have the same number of bits as an empty struct without a deinit--i.e. two.
Here, the problem is fixed by giving an empty struct with a deinit two bits.
Based on https://github.com/apple/swift/pull/73159
Scope: Affects noncopyable code.
Issue: rdar://126863003
Original PR: https://github.com/apple/swift/pull/73174
Risk: Low.
Testing: Added and updated unit tests.
Reviewer: @kavon

@swift-ci please test

How come everything is the same when I open it 1 by 1, everything is the
same
Pada Sel, 23 Apr 2024 01.03, nate-chandler @.***>
menulis:

Based on #73159 https://github.com/apple/swift/pull/73159
TODO: CCC
You can view, comment on, or merge this pull request online at:
https://github.com/apple/swift/pull/73178
Commit Summary

3a81548
https://github.com/apple/swift/pull/73178/commits/3a815482db98e1d450af01d7d5750113ec7002ba
[NoncopyablePartialConsumption] Promote to feature
b2afe0d
https://github.com/apple/swift/pull/73178/commits/b2afe0de06e65a6e4fbb90fefa5ec60520bc1d3f
[NoncopyablePartialConsumption] Ungate feature.
ce59be7
https://github.com/apple/swift/pull/73178/commits/ce59be7ebdb8e1793ceccd24a7eff8a5fd9917c8
[MoveOnlyAddressChecker] OK destroy(pai[onstack])
68b8322
https://github.com/apple/swift/pull/73178/commits/68b8322d9dd86a6a4328e576919e3f75997ab9a7
[MoveOnlyAddressChecker] Handle enum deinits.
8edd5eb
https://github.com/apple/swift/pull/73178/commits/8edd5eba336901cf5c9a1c16fca5d23da5621077
[SILCombine] Keep dead drop_deinits.
0315fcd
https://github.com/apple/swift/pull/73178/commits/0315fcdbaa6bfafa98f726cff28450b82a787533
[FSPL] Use autogen'd loc.
39b9616
https://github.com/apple/swift/pull/73178/commits/39b9616cb7d92936faf311e3e865995fa1911671
[SILCombine] Keep ued(deiniting).
874971c
https://github.com/apple/swift/pull/73178/commits/874971c40d2b20c9c52b2b906516c96798023dd9
[MoveOnlyAddressChecker] Complete lifetimes first.
65ab9eb
https://github.com/apple/swift/pull/73178/commits/65ab9eb5ca18dd36405577ecc0bf798f1a9f2127
[MoveOnlyAddressChecker] Fix empty struct repr.

File Changes
(56 files https://github.com/apple/swift/pull/73178/files)

M include/swift/Basic/Features.def
https://github.com/apple/swift/pull/73178/files#diff-c841232847d55b365ad2ed68c291545b5c27be2dd898e4db65a4f5d1703f0b19
(2)
M include/swift/SIL/FieldSensitivePrunedLiveness.h
https://github.com/apple/swift/pull/73178/files#diff-c320de0d5e765593dcf387b543f3dbefbea7caf1e2a8575ad88b96fa96e2283b
(5)
M lib/SIL/Utils/FieldSensitivePrunedLiveness.cpp
https://github.com/apple/swift/pull/73178/files#diff-eb5f0d376550ba4af53758deaf5152a22a1bfe3774c5627fff7d99d30e0aade9
(144)
M lib/SILGen/SILGenDestructor.cpp
https://github.com/apple/swift/pull/73178/files#diff-c607b617d48844b74b2a22b3a784536ff99ce7c76980211b89857a47536d81bf
(13)
M lib/SILGen/SILGenProlog.cpp
https://github.com/apple/swift/pull/73178/files#diff-4918a87d7c99e671cd5209c0edb8918daede44a388f2b812fee26b139764974f
(33)
M lib/SILOptimizer/Analysis/SimplifyInstruction.cpp
https://github.com/apple/swift/pull/73178/files#diff-6fb49942c7d3b800ddf095be8e2e72aa93940220892297e5c573b18ae150b237
(2)
M lib/SILOptimizer/Mandatory/MoveOnlyAddressCheckerTester.cpp
https://github.com/apple/swift/pull/73178/files#diff-9c8ec5474745801be2148dbcd9e1178e6aaead4739668d88d551b4137047cb8b
(3)
M lib/SILOptimizer/Mandatory/MoveOnlyAddressCheckerUtils.cpp
https://github.com/apple/swift/pull/73178/files#diff-d5fb12c0915bf7d4260558f5d46cf6a2a26cebe766c271bc2a859d454b6751b8
(46)
M lib/SILOptimizer/Mandatory/MoveOnlyAddressCheckerUtils.h
https://github.com/apple/swift/pull/73178/files#diff-f7850c13774aae317f0032e477577045e306deac86a52fea310612d8b572a9a2
(1)
M lib/SILOptimizer/Mandatory/MoveOnlyChecker.cpp
https://github.com/apple/swift/pull/73178/files#diff-f29efffee1ea53cfbcca574416df3b55f906c649ede151dfdbb77e988a8991ed
(1)
M lib/SILOptimizer/Mandatory/MoveOnlyDiagnostics.cpp
https://github.com/apple/swift/pull/73178/files#diff-bcf2355adc4faab67c734de6b946769d9e77f524d1695e01a82c6e8f9d3e2dce
(5)
M lib/SILOptimizer/Mandatory/MoveOnlyTypeUtils.h
https://github.com/apple/swift/pull/73178/files#diff-d5897f6bc3dc4de115070dbe498e34a0fe157c115d75c89d62ddcb530bfd5619
(9)
M lib/SILOptimizer/Utils/CanonicalizeInstruction.cpp
https://github.com/apple/swift/pull/73178/files#diff-62019e6aa86de11b07f8d506a061a9ed44a4db740c71bf8f755e28a6a1b1d0c2
(6)
M lib/Sema/MiscDiagnostics.cpp
https://github.com/apple/swift/pull/73178/files#diff-cb1dfa36aab299d0abafe04242dbebf8a555ad1a20041b47c1299f4687935f41
(8)
M test/Interpreter/move_expr_moveonly_partial_consumption.swift
https://github.com/apple/swift/pull/73178/files#diff-19f5d19866539c0e769fe1c58ebf366b9d01d303ccb6f0e3a1b92e1b8633fc35
(4)
M
test/Interpreter/move_expr_moveonly_partial_consumption_addr.swift
https://github.com/apple/swift/pull/73178/files#diff-83612cdf8f795675083159f3f074d024cf29225e6fae9a25f9447be4387b8620
(4)
M test/Interpreter/moveonly_address_maximize.swift
https://github.com/apple/swift/pull/73178/files#diff-537f7fee7f38a18673ddb69fcb3519defb596b0a03723588e6ca0943a74274a5
(8)
M test/Interpreter/moveonly_partial_consume_value.swift
https://github.com/apple/swift/pull/73178/files#diff-d71b39fe4596f26ec37b6dbe865d1d9c031b81d6a6d6edab246a47e6cf756fee
(4)
M test/Parse/move_expr.swift
https://github.com/apple/swift/pull/73178/files#diff-b71548f6be541f4b5cb1f49932fc2469add8a4e2411df2f0b1b99501019d6b9c
(6)
M test/SILGen/moveonly_consuming_switch.swift
https://github.com/apple/swift/pull/73178/files#diff-abea055be7b0dddcfb53c5123081c88d0d6df86389c4e790c49853cf560e8f21
(1)
M test/SILGen/moveonly_deinits.swift
https://github.com/apple/swift/pull/73178/files#diff-9fe66488983375855518ba040347474c176cb19413caee97ad718670b0f56adb
(56)
M test/SILGen/moveonly_library_evolution.swift
https://github.com/apple/swift/pull/73178/files#diff-4a50e5bac6cc873364e1c10c59b437438a2a563910357281f4b86cc6baac8046
(4)
M test/SILGen/moveonly_optional_operations_2.swift
https://github.com/apple/swift/pull/73178/files#diff-ce2dab0dc290611c5555303dea5d73f5f5b408d4ea83f65471fa09da743fb908
(2)
M test/SILGen/non_loadable_move_only.swift
https://github.com/apple/swift/pull/73178/files#diff-a967f94d5b5ea569fa983d3543e2ca9a353dc572b0c3027d06ac6b8185932a85
(12)
M test/SILOptimizer/moveonly_addresschecker.sil
https://github.com/apple/swift/pull/73178/files#diff-e35f5b4945872c153255c84c1b54dcbb739edb5345d1c7d2d381b2749490e868
(2)
M test/SILOptimizer/moveonly_addresschecker.swift
https://github.com/apple/swift/pull/73178/files#diff-bebe8f23c897066a0e311f1a950a8b26aa56ee64d01e38eed3f2b707a7056867
(4)
M
test/SILOptimizer/moveonly_addresschecker_destructure_through_deinit_diagnostics.swift
https://github.com/apple/swift/pull/73178/files#diff-da9f70b9897d3e0925cb1d1f9c60382f02d3994cd8f3dafc9651b9f014a8c3bb
(4)
M test/SILOptimizer/moveonly_addresschecker_diagnostics.sil
https://github.com/apple/swift/pull/73178/files#diff-c1b53823e25b128b4703b7c8224eeecef3f6ed3bc5f35c267aaed2be0ac2b876
(8)
M test/SILOptimizer/moveonly_addresschecker_diagnostics.swift
https://github.com/apple/swift/pull/73178/files#diff-21765b1408844bd862bc611188c43c77320b44b1d63d13a7c022772178a69a57
(4)
M
test/SILOptimizer/moveonly_addresschecker_diagnostics_library_evolution.swift
https://github.com/apple/swift/pull/73178/files#diff-b24b1df0f0974485708def5f2838057449b6ab4ebd207a35cc138b5052afdf7b
(42)
M
test/SILOptimizer/moveonly_addresschecker_diagnostics_partial_consume_ufi.swift
https://github.com/apple/swift/pull/73178/files#diff-e00243e4e15d3eaaa6c30dfe22a9b79748f9b76208e5cd9ac991c2daa31ac06f
(2)
M
test/SILOptimizer/moveonly_addresschecker_diagnostics_resilient.swift
https://github.com/apple/swift/pull/73178/files#diff-b825c6d4d3756ec32e01dc4c4dfc2e835be00fd8436d4383d58126fe860e0291
(2)
M
test/SILOptimizer/moveonly_addresschecker_diagnostics_without_partial_reinit.swift
https://github.com/apple/swift/pull/73178/files#diff-54b291b10a2a847d04382105825726a87a5bb62853da141365c0aaf0d9ff7e3a
(4)
M test/SILOptimizer/moveonly_addresschecker_maximize.sil
https://github.com/apple/swift/pull/73178/files#diff-0bb48e3ba9d54c6723efc2f243aeaf98231268348b3ff156eb7f1ffb3d01cb3f
(2)
M test/SILOptimizer/moveonly_addresschecker_unmaximized.sil
https://github.com/apple/swift/pull/73178/files#diff-e8eea7200944c56379aab5eb1a647ba5a5b2d517450a3855c2e52c2ed103f860
(34)
M
test/SILOptimizer/moveonly_addressonly_subscript_diagnostics.swift
https://github.com/apple/swift/pull/73178/files#diff-4f54b55d882d8b47ff4160ec44e82a4f7ba01935b7f001d51cd85df0858c731e
(4)
M
test/SILOptimizer/moveonly_borrowing_switch_mode_with_partial_consume.swift
https://github.com/apple/swift/pull/73178/files#diff-d74883dd995e040658e50e8a277ef88c9dde490cbcb92766ecbce1f302cbacab
(2)
M test/SILOptimizer/moveonly_borrowing_switch_yield.swift
https://github.com/apple/swift/pull/73178/files#diff-141fa3abba92f318200e64dc8c11bf034004d92b7d6b63e1bc2da43625ddba03
(2)
M test/SILOptimizer/moveonly_consuming_switch.swift
https://github.com/apple/swift/pull/73178/files#diff-23f81d4d06f1fa4117e79840e039479948e0da042e60659ff13d330b276e2e0a
(2)
M test/SILOptimizer/moveonly_consuming_switch_2.swift
https://github.com/apple/swift/pull/73178/files#diff-daabcafab38cb0a2c6d64fcf588463af541af13a739d14d5308ba1e5c08ce45e
(2)
M test/SILOptimizer/moveonly_deinits.swift
https://github.com/apple/swift/pull/73178/files#diff-6b213cf1c8e943e4b26697a1e792b3c6ca01b566e50463effea8b56f3d17d78c
(9)
M test/SILOptimizer/moveonly_discard.swift
https://github.com/apple/swift/pull/73178/files#diff-5ed9ea1a5cb22e90873a519c65bf95cf3f74ae9b7f64c4e6c7fab72bcbaa992f
(7)
M test/SILOptimizer/moveonly_generics_basic.swift
https://github.com/apple/swift/pull/73178/files#diff-17fc56a2e51f33f3d427f614eae090e8d11d42eb5a34534a4ebb0e3a35b5c951
(2)
M test/SILOptimizer/moveonly_generics_complex.swift
https://github.com/apple/swift/pull/73178/files#diff-7412e358b33be5a4ac10802b30c5c913e48482e02d4f19d7fcbb0ba7dee81f83
(1)
M test/SILOptimizer/moveonly_loadable_subscript_diagnostics.swift
https://github.com/apple/swift/pull/73178/files#diff-cc55e67ea4e38efb60c25e8e968ccc79d54c67942e9cc126dc7c4f7b8a0f8606
(2)
M test/SILOptimizer/moveonly_objectchecker_diagnostics.swift
https://github.com/apple/swift/pull/73178/files#diff-d22a33749245177cbdaaa2f3966e7e2b21e66ad2694ff39f866cf75ab01a321f
(2)
D test/SILOptimizer/moveonly_partial_consumption.swift
https://github.com/apple/swift/pull/73178/files#diff-cc04185dd4856473cd955ef9f1ee85e67081e34abe9693be26421ec5c6240b97
(1071)
M test/SILOptimizer/moveonly_partial_consumption_deinit.swift
https://github.com/apple/swift/pull/73178/files#diff-36c77164569b1f26b6c2d35e44d280188e10e2d14e958d87b92cb2fa952474c4
(1)
M test/SILOptimizer/moveonly_self_captures.swift
https://github.com/apple/swift/pull/73178/files#diff-165a3ec542c69d4d3a8ea377ce679a25db03101b2dbfcc33827ed4eea83650fc
(8)
M
test/SILOptimizer/moveonly_trivial_addresschecker_diagnostics.swift
https://github.com/apple/swift/pull/73178/files#diff-b390f11b2172d4c39cc654447f8aa0c1f6f7e0e5f6344c126bb5105f75a24b06
(4)
M
test/SILOptimizer/moveonly_trivial_objectchecker_diagnostics.swift
https://github.com/apple/swift/pull/73178/files#diff-680e5d4ad9953465446f83a333797d8577f63012cc859fbe328968f8cc5d75f6
(4)
M
test/SILOptimizer/test/SILOptimizer/moveonly_addresschecker_diagnostics_partial_consume.swift
https://github.com/apple/swift/pull/73178/files#diff-a3dacb710778bb8951bb687a7ddac5583318876c3065b1312d908e00ceba45ed
(4)
M test/Sema/move_expr.swift
https://github.com/apple/swift/pull/73178/files#diff-4a3e64f630ca666ada9d6c6ead4e651e28ef2a5720675dc34c53d02b860b5b18
(10)
M test/Sema/move_expr_moveonly_partial_consumption.swift
https://github.com/apple/swift/pull/73178/files#diff-e2db554935a34aed3bd222cb6e7a52b889beb64eb83d1ada117ab2b143a54d76
(1)
M
validation-test/IRGen/moveonly_partial_consumption_linked_list.swift
https://github.com/apple/swift/pull/73178/files#diff-d2a3025a14472d6bb4aef1dc376e0a3f48603c302be0b727269521e334b3e1fa
(1)
M
validation-test/SILOptimizer/moveonly_partial_consumption_linked_list.swift
https://github.com/apple/swift/pull/73178/files#diff-f0eab6e0351e417ad68a786027b710cb907b1bebe6b1d3909649abdf41a0ad99
(1)

Patch Links:

https://github.com/apple/swift/pull/73178.patch
https://github.com/apple/swift/pull/73178.diff

—
Reply to this email directly, view it on GitHub
https://github.com/apple/swift/pull/73178, or unsubscribe
https://github.com/notifications/unsubscribe-auth/BH2MAXC6LM7MAZRAEUC4J23Y6U7G3AVCNFSM6AAAAABGTFG33GVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI2TOMBUGIZDONI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

@swift-ci please test


Use a consistent term: kwok and kwokctl

What type of PR is this?
/kind documentation
What this PR does / why we need it:
Try to use a consistent expression about kwok and kwokctl:

If a product name, use KWOK same as the logo
If a component, use kwok and kwokctl (both in lower case)
If a code snippet or UI is nearby, use kwok and kwokctl to describe (This may need to discuss further)

Does this PR introduce a user-facing change?
NONE

Fixes #340

/approve
/lgtm


Draft: update to extensions csharp 0.12.11

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: ngruelaneo:x: gruelYou have signed the CLA already but the status is still pending? Let us recheck it.


Use parent environment to allow variable substitution

I'm experimenting to support EnvFile with [BashSupport Pro}(https://www.bashsupport.com).
I noticed that the variable substitution isn't working as it should.
Currently EnvFile only provides the variables configured directly in the run configuration to the var env providers.
Now, if a variable substitution references a variable, which is inherited from the parent environment, then it has an empty value. That's happening because eneralCommandLine.getEnvironment() is not including the variables from the parent environment.
The SDK's process setup adds the parent environment variables to the new process, if the setting for this is enabled: https://github.com/JetBrains/intellij-community/blob/8e89a51b18059a34081c84439c6c19483f64ad10/platform/platform-util-io/src/com/intellij/execution/configurations/GeneralCommandLine.java#L469
EnvFile must follow the same logic to provide the same set of variables to the patched command line.
I successfully tested this with Python, the other modified providers follow the same logic.
I don't know much about EnvFile, but hope that this is helpful.

Can I help with anything to get this merged?


Find the most complex InChI string

One problem that can arise, is that we end up with more than one, more or less equally valid InchI string for the same metabolite in a model. The currently proposed strategy is to keep the most complex one, as it will (hopefully) contain a the most information. Most complex means, keep the inchi with the most "/" and the longest one.

[ ]  Please write a function to get the most complex InChi string from a list of InChI strings.

Alternative approach - keep only the standard InchI strings + the longest from the standard Inchis (standard Inchis start with InChI=1S/)

Will be implemented in the next pull request. Code is already available.


Dangerous flush

Laravel Version: 5.8.29
PHP Version: 7.3.7
Database Driver & Version: Mariadb 10.4 Redis 5.0.5

Description:
Add a config option to disable Cache::flush(); and php artisan cache:clear
As the Cache:flush(); is very dangerous because it remove the redis DB and dont use the CACHE_PREFIX.
It is possible in phpRedisAdmin to delete a cache tree, so it should be the same in Laravel (even if it's ugly).
Just remove insecure Cache::flush() on some driver with a config option to enable it (it's safe with file driver, but not with redis driver), an application should not destroy date of another application, a simple warning on the documentation is not enought.
This method should be disabled by default.
Steps To Reproduce:
Use Cache::flush(), it destroy Redis data of all other applications... (redis driver)

As a rule of thumb, use different databases for different applications

As a rule of thumb, use different databases for different applications

No, Redis is not like a relational DB, you can't create a database without changing the config and restart, it's the same problem with memcached ...
the cache:clear have to take the cache prefix
A simple fix is something like this in the cache:clear command (I override the command):
             if($this->cache->getStore() instanceof RedisStore){
			/**
			 * @var \Redis $redis
			 */
			$redis=$this->cache()->getRedis();
			$application_keys=$redis->keys($this->cache()->getPrefix().'*');
			foreach ($application_keys as $key) {
				$redis->del($key);
			}
			$successful = true;
		}
		else{
			$successful = $this->cache()->flush();
		}

Redis comes with 16 Databases out of the box, that is what I'm talking about.
You fix will only work if a small number of keys are stored in Redis.

Redis comes with 16 Databases out of the box, that is what I'm talking about.
You fix will only work if a small number of keys are stored in Redis.

if you have 100 Laravel app on a server you have to change the config... There is a cache prefix, it should be used to clear cache

Well, be responsible and do not host 100 Laravel apps on the same server. Sorry if this may sound rude but we can not implement things only to suffice the requirements of a few.

It's clearly in the docs https://laravel.com/docs/5.8/cache#removing-items-from-the-cache

Flushing the cache does not respect the cache prefix and will remove all entries from the cache. Consider this carefully when clearing a cache which is shared by other applications.

I know it's there because I added it myself after I was bitten by this.
Past issue: https://github.com/laravel/framework/issues/5034
The problem is a technical one: not all cache drivers support by removing by prefix out of the box; Redis being one of them.
It is possible with a workaround in Redis: you can iterate over the keys and filter out for the ones you care and the act on them (I see you figured this in your PR). But this is an expensive operation in Redis and if you've a LOT of keys this can freeze your Redis server, etc. Maybe there is something in newer version of Redis I'm not aware of.
So, as of now, the docs are the only protection and it's good to look them up before you use a certain feature 🤷♀
If it's that important to you and you can live with the downsides, you have to use your own Redis driver (or maybe one exists already).

That's wrong you can select keys with a wilcard '$redis->keys('PREFIX:*')' with redis (phpredis), and not all keys, so you have to iterate, only on laravel keys, not all the db keys, you just should a config option to be able to use : destroying db, or clearing only laravel app cache (with select all laravel cache keys + iterate), it's very fast too, but I didn't tried it on more  than 1M keys.
@jmarcher it's just an exemple and it's stupid to stay that, you dont buy servers to fix a bug... , an application cache shouldn't break another application, it's not a requirement of a few...
Just need a config to choose, it there is a cache_prefix, and Cache:flush() doest respect this by default, it's a bug and should be fixed if possible,the doc is OK, but many developper doesn't remember that, for redis it's possible and it's fast (many slow if more than 1M laravel keys...), for memcached it's possible too but you have to iterate over all keys.
I will try to make another driver it's you dont want to fix this bug.

I'm sorry if I triggered you but do you understand that this is not a bug? You can use the different databases in a Redis server.
And after all, clearing the cache should not break your application it is only a cache after all.

Please use the recommended way of a separate Redis connection for your database and caches.

This is not a bug, but it's too easy to be misused.
Our team is bitten twice in 3 months. We thought it will just clear the local artisan file cache created by artisan optimize.


Deprecation Warning: Mime::XLSX to Mime[:xlsx]

When building xlsx, I am receiving this message:
DEPRECATION WARNING: Accessing mime types via constants is deprecated. Please change 'Mime::XLSX' to 'Mime[:xlsx]'
Should the gem be updated to this new syntax?
I am using rails 5.0.1, and ruby 2.2.5

Thanks @Hugosirq. I'll get to that in the next release. Do you happen to know when it will be removed?

@Hugosirq I fixed it everywhere but in one spot. Didn't get picked up in my testing I guess. And, on further research, the "new" syntax has been around forever. So I don't need to detect the rails version. I should look more closely next time. Thanks again for the heads up.

Original Rails pull request: https://github.com/rails/rails/pull/21869

5.1 has removed access through constants.

@Hugosirq Which axlsx_rails version are you using?

Hmmm, looking at my gem file list, it appears:
axlsx (2.1.0.pre, 2.0.1)
axlsx_rails (0.5.1, 0.3.0)
Now, looking at my .lock, for some reason bundler installed(or it is using) 0.3.0 .
ASAP I will try forcing with 0.5.0 version and see if it works.

That would explain the deprecation. I'm glad to get rid of the conditionals in the code, however. And I'm now setting up automated testing for 5.1.


chore(dropdown): with autoClose 'outsideClick' closing when clicking inside element

Hi,
i'm working on an implementation of the Dropdown and I'm having some trouble with the autoClose property. I set the autoClose to 'outsideClick' but the dropdown is toggled when I click inside the element as well. Here is what I have:
index.html:

	<button type="button" class="btn btn-default" dropdownToggle>
		 {{data?.reference}}

    </button>

		<edit-details [details]="dataDetails" (detailsApplied)="updateDetails($event)">Details</edit-details>

The template of the edit-details component has the following html:

    <form role="form">

                <input-text [(value)]="details.name" (input)="valueChanged('name', $event)"></input-text>
                ... some more inputs

    </form>

After some debugging I found that in the closeDropdown function in dropdown.service.ts, the this.openScope.menuEl is undefined. I think that the public set dropDownMenu in dropdown.directive.ts is never called, thus the this.menuEl is never set.
Any ideas on this are very welcome. Thanks!

It seems the reason is that the menu is never set for the dropdown. This causes the test whether the clicked element is inside the menu to always be false.

Additionally, the inclusion test only tests for equality instead of doing a proper "contains" check like the original bootstrap code.


Bushy tree join ordering

Is your feature request related to a problem? Please describe.
Implement bushy tree join ordering to minimize the height of the join tree based on the RFC https://github.com/risingwavelabs/rfcs/pull/23.
Describe the solution you'd like
No response
Describe alternatives you've considered
No response
Additional context
No response

I suppose it will be optional by turning on/off session variables, and thus will not be in conflict with query hints(in the future) for join ordering?

I suppose it will be optional by turning on/off session variables, and thus will not be in conflict with query hints(in the future) for join ordering?

Yes.

Will we support it in batch query?

Will we support it in batch query?

This optimization can work for batch as well, but it might result in more memory consumption for the distributed batch queries.

Testing: https://github.com/risingwavelabs/risingwave/issues/8173

Add a bench. https://www.notion.so/risingwave-labs/Join-Ordering-Bench-fe6478688e0348249c1f12dcbd599a30

https://github.com/risingwavelabs/risingwave/pull/9394


Pagination plugin doesn't calculate the active page correctly

Depending on the number of items and the number visible per page of the carousel, the pagination plugin fires active.jcarouselpagination event on the wrong page.
STR:

Load this test case: http://plnkr.co/edit/ED8nil3oBnl7iBUbdqtg?p=preview
Click the "next" link twice to move to the last page of the carousel
Click the "prev" link to move back one page
Observe that the first pagination circle is denoted as active, even though you're on page 2.

This bug occurs because the logic to determine the current page uses the targeted list item in the carousel as if you were progressing forwards through the carousel, not backwards. At step 3 which you click prev, the 4th item in the carousel becomes the target, which happens to be on page 1 when the carousel first loads but due to the odd number of items in the carousel, it is not on page 1 when moving backwards.

In the example you posted above on Plunker, you do not have both plugins working together. I am trying to do so but I am having issues. I have set up https://jsfiddle.net/carlosvillademor/sgwLp0tu/10/ I am doing click on the pagination links when using the prev or next links, but trying to set control links in a way that would handle the active/inactive transitions. Is that possible? If you play up with the example on my jsfiddle, you can see that the inactive or active events on the control link don't work properly. Could you shed some light into what is wrong on my setup? Thanks in advance.

I've updated the jsfiddle: https://jsfiddle.net/sgwLp0tu/11/
The only difference is, that i configured the prev-control with target: '-=1' so it really acts like a prev-control.

I see, the default for that is '+=1' so it was acting as the next instead. Cool! Thanks. I was assuming that I didn't need the target as the method was doing the move, but yes, that was a wrong assumption. Thanks Jan.

I mistakenly deleted the jsfiddle you corrected. Here is a final version working, https://jsfiddle.net/carlosvillademor/p4cLk90t/, in case is of use for anybody.


Implement FRAM buffer for measurements

FRAM will buffer the serialized data before it gets transmitted.

Merged 1/5/2024


Implement auto update

As far as I can tell, no auto update mechanism is installed for MacVim. There seem to be preparations for Sparkle but it looks like it's deactivated somehow.

According to Björn's e-mail:

Any plans to have a sparkle feed for the snapshot releases, or do we
need to update manually?

Automatic updates slow me down so I'm only supporting it with the stable build.

Since we're moving from snapshot to snapshot, my guess it will be low priority for now.

It needs extra cost. If you really want to update automatically, you can use this. The update information is Japanese, but it is totally based on this MacVim snapshot.

Extra cost?
Why close this issue? Isn't this something you'd like to see implemented, and even if you don't want to spend much time on it, couldn't this be contributed by someone else?
Please reopen this this issue and add any important information for anyone wanting to work on this. Thanks.

there are plenty of issues already, but almost no one sends pull request, except a few cases. no one wanting to work on this, I guess.

Hey, cool, thanks for adding auto update despite your previous comment! I'll try it out in the next days.

@jonashaag You can try it out now. I've deployed snapshot-93.

Seems to work. Awesome! Thanks!


Added missing Vector3 methods

In older versions, important methods for working with vectors were omitted.
https://wiki.rage.mp/index.php?title=Server-side_functions#Vector3

Thanks


Add Homebrew formula

add formula for doltgresql
like for dolt:
https://github.com/Homebrew/homebrew-core/blob/master/Formula/d/dolt.rb

I don't think we want to add this to Homebrew just yet, considering it is still extremely early in development, and perhaps being in Homebrew may lead users to think it's further along in development than it actually is (they won't see the README for instance), however I'll let @timsehn weigh in with his thoughts here.

Let's add it. No reason to wait for later stability to get this moving. I can submit a PR.

we shipped the formula, it can be installed via brew install doltgres


Free Hand Highlight and Drawing -  Red Colour Option Disappears

Describe the bug in current situation
When a user selects to free hand highlight or draw (red by default), and selects another colour besides red, it selects this colour. However, after changing the colour, the user is unable to select red again. Users should be able to freely go through the four highlight or drawing colour options (red, blue, green, dark grey/black).
This may cause problems when multiples users are marking up the same request, and using colours to differentiate their work or actions.
Private Zenhub Image
Private Zenhub Image
Link bug to the User Story
Impact of this bug
Describe the impact, i.e. what the impact is, and number of users impacted.
Chance of Occurring (high/medium/low/very low)
Pre Conditions: which Env, any pre-requesites or assumptions to execute steps?
Test-Marshal
Steps to Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Actual/ observed behaviour/ results
Expected behaviour
A clear and concise description of what you expected to happen. Use the gherking language.
Screenshots/ Visual Reference/ Source
If applicable, add screenshots to help explain your problem. You an use screengrab.

will be resolved when #4898 completed. Closing.


[move-prover] Remove ":inline" attribute for three functions in prelude

Fixes #3529
Inlining these significantly complicates the SMT query and Z3 was struggling
on some problems.

@bors-libra r=junkil-park

:pushpin: Commit 33a9b23 has been approved by junkil-park

@bors-libra r+

:bulb: This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: #3602

:pushpin: Commit 33a9b23 has been approved by cbarrettfb

:hourglass: Testing commit 33a9b232ade32a112da5220a8a517d19e04d0550 with merge e5855387c2bfac34965feef833c4f8324301c0af...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: cbarrettfb
Pushing e5855387c2bfac34965feef833c4f8324301c0af to master...


topic rules

Describe the bug
Forum rules on the page typics.php no link no info

modal add for forum rules


Unhandled exception when login window is closed

I noticed that the demo solutions crash if I close the login window with the title bar close button. The exception message says:
"User canceled authentication. On an Android device, this could be due to the lack of capabilities, such as custom tabs, for the system browser. See https://aka.ms/msal-net-system-browsers for more information."
Please advice how to catch this exception? I already tried to subscribe to the MicrosoftGraphService.Instance.SignInFailed event but it doesn't fire in this situation.

Here is the stack trace for this exception. It's message is "authentication_canceled"
e.Exception.StackTrace

   at Microsoft.Identity.Client.Internal.Requests.InteractiveRequest.VerifyAuthorizationResult() in C:\Agents\Agent01\_work\27\s\src\Microsoft.Identity.Client\Internal\Requests\InteractiveRequest.cs:line 311
   at Microsoft.Identity.Client.Internal.Requests.InteractiveRequest.ExecuteAsync(CancellationToken cancellationToken) in C:\Agents\Agent01\_work\27\s\src\Microsoft.Identity.Client\Internal\Requests\InteractiveRequest.cs:line 116
   at Microsoft.Identity.Client.Internal.Requests.RequestBase.RunAsync(CancellationToken cancellationToken) in C:\Agents\Agent01\_work\27\s\src\Microsoft.Identity.Client\Internal\Requests\RequestBase.cs:line 154
   at Microsoft.Identity.Client.PublicClientApplication.AcquireTokenForLoginHintCommonAsync(Authority authority, IEnumerable`1 scopes, IEnumerable`1 extraScopesToConsent, String loginHint, UIBehavior behavior, String extraQueryParameters, UIParent parent, ApiIds apiId) in C:\Agents\Agent01\_work\27\s\src\Microsoft.Identity.Client\PublicClientApplication.cs:line 556
   at Microsoft.Identity.Client.PublicClientApplication.AcquireTokenAsync(IEnumerable`1 scopes, String loginHint, UIParent parent) in C:\Agents\Agent01\_work\27\s\src\Microsoft.Identity.Client\PublicClientApplication.cs:line 364
   at Microsoft.Toolkit.Services.MicrosoftGraph.MicrosoftGraphAuthenticationHelper.GetUserTokenV2Async(String appClientId, UIParent uiParent, String redirectUri, String loginHint)
   at Microsoft.Toolkit.Services.MicrosoftGraph.MicrosoftGraphAuthenticationHelper.GetUserTokenV2Async(String appClientId, String loginHint)
   at Microsoft.Toolkit.Services.MicrosoftGraph.MicrosoftGraphService.LoginAsync(String loginHint)
   at Microsoft.Toolkit.Services.MicrosoftGraph.MicrosoftGraphService.TryLoginAsync()
   at Microsoft.Toolkit.Uwp.UI.Controls.Graph.AadLogin.SignInAsync()
   at Microsoft.Toolkit.Uwp.UI.Controls.Graph.AadLogin.AadLogin_Clicked(Object sender, RoutedEventArgs e)
   at System.Threading.WinRTSynchronizationContextBase.Invoker.InvokeCore()

In the TryLoginAsync method of MicrosoftGraphService.cs this situation should be handled however. It's even in the remarks "Exceptions are not thrown but SignInFailed event is raised". What am I missing here?

What is the type of the exception? I notice the toolkit is only catching MsalServiceException, I'm betting this is not of that type.

It appears to be "Microsoft.Identity.Client.MsalClientException".

What can be done to fix this issue?

You can catch that exception and handle it. It might be worth filing an issue on the toolkit with this detail, they should probably catch that for you.

I created another issue to the WindowsCommunityToolkit project.
Meanwhile I tried to create my own button which calls the MicrosoftGraphService.Instance.TryLoginAsync() method in a similar manner as AadLogin control. However now I'm facing yet another issue as it causes System.NotImplementedException with message "See https://aka.ms/msal-net-3-breaking-changes".
ex.StackTrace    at Microsoft.Identity.Client.PublicClientApplication..ctor(String clientId, String authority)    at Microsoft.Identity.Client.PublicClientApplication..ctor(String clientId)    at Microsoft.Toolkit.Services.MicrosoftGraph.MicrosoftGraphAuthenticationHelper.GetUserTokenV2Async(String appClientId, UIParent uiParent, String redirectUri, String loginHint)    at Microsoft.Toolkit.Services.MicrosoftGraph.MicrosoftGraphAuthenticationHelper.GetUserTokenV2Async(String appClientId, String loginHint)    at Microsoft.Toolkit.Services.MicrosoftGraph.MicrosoftGraphService.LoginAsync(String loginHint)    at Microsoft.Toolkit.Services.MicrosoftGraph.MicrosoftGraphService.TryLoginAsync()    at SkyHighUI.UserControls.NavigationMenu.SignInAsync()
Can you please help what could cause this? I have tried to understand what happens under the hood in the AadLogin control and MicrosoftGraphService class but can't figure out why this happens with my custom button and not the AadLogin control.

Did you add the Microsoft.Identity.Client package to the project? I believe the toolkit installs a specific version (based on MSAL 2) and if you installed MSAL 3 or 4 they introduced a lot of breaking changes (methods in 2 that  no longer exist, etc.)

Yes, I have version 4.5.1 of Microsoft.Identity.Client installed. I suppose there's no newer version of the Microsoft Graph Connect Sample for UWP which uses a custom login button and doesn't rely on the AadLogin control?
I'm currently trying to upgrade it piece by piece by replacing the obsolete methods with the new ones but I don't know if this is going to help either.

This issue will be resolved by https://github.com/windows-toolkit/Graph-Controls/issues/22


Catch fitting exception

#305

Coverage increased (+0.02%) to 43.092% when pulling e08659eb45d89797b5d841324e14b92bcdedc6b9 on issue305 into f03e5a0ead4c0ff94d3c25bd7a4502948b1d22d0 on master.


Export confirmation codes, add labels to results

You asked whether there was anything that MechArg/OSA/JATOS could do, to make the monitoring of confirmation codes easier in the MTurk.
Maybe something that could be done is to be able to add labels (accepted/rejected/blocked, etc) to individual study results. Then, this label together with worker ID and study confirmation could be exported in a csv file for easier control.

Do you still think this is a good idea? I actually think we should wait for more feedback from the other users before implementing this.

I do think that it would be a good idea. But I already wrote a way around it in my matlab analysis so I don'T need it right now. Let's leave it as an option and wait until we get feedback, yes

I'm analyzing data again. This would definitely help. The question is, what if people store csv and not JSON as output data? Let's discuss any alternatives

Another alternative is: have (yet another) button, or export an additional file with suffix '_metadata', that contains the metadata of each one of the exported results in JSON format. I know it's suboptimal to export two files, but at least it gets rid of the problems that might arise if people are exporting their results in csv format.
I really need this. It's useful to keep track of whether the experiment was really finished (although if we look at the table behaviour we might not need this) and how long it took.

Has there been any update on this? I would like to provide performance dependent payoff in mturk and for this I would need to match the mturk worker id, which is available in Jatos, with with my results. I could match them based on the worker id which is present in both data sets, but I do not seem to be able to export the list of mturk worker ids. At least, I do not seem able to export the metadata.

I could add a button in JATOS result page that exports the result data together with the metadata. And here I could need some input from you as a user: I would use JSON format for the whole results (result data + metadata). So the whole exported file is an JSON array with each result an element in this array. Each result has all the meta data and a field 'resultData' which contains the result data using JSON encoding.
It would look similar to this:
[
{"resultId": 1, "startTime": 12345678, "workerId": 1, ... , "resultData": "all data in JSON encoding"},
{"resultId": 2, ...
]

Does this suits your needs?

Btw. JATOS doesn't save the MTurk worker ID for privacy reasons. But I could make them available to you via jatos.js / jatos.urlQueryParameters. From there one can do with them as pleased and even put them in the result data where they will be stored in JATOS database.

I use lab.js for programming my experiment and then export to JATOS, which makes the data available as a JSON. So what you suggest would probably work quite well.
However, only having the metadata in a separate JSON file (i.e., without resultData) would work as well as matching via resultID is also quite trivial. I do not think exporting two files would be such a hassle. However, if your initial suggestion is easier for you to implement, please do that. Either way is fine.
Finally, I read the statement on privacy and figured that is the reason it is not possible. However, allowing performance related payment is something I think quite a lot of users would want (I for sure would be super happy). So maybe it is a great way to allow this somewhat easier via the API. In the end, we users should be aware that we are ultimately responsible for ensuring the data of our participants are treated in an ethical manner and identifying information, such as the MTurk IDs, are not used in an inappropriate or illegal manner or even posted on the web.

Actually I do stay corrected: JATOS does save the MTurk worker ID. I
corrected the my prior answer. Like you said, it is up to the user to be
careful and not to misuse this information.
I'll try to implement these additional export metadata buttons in the next
release. How urgent is this feature for you?
On Wed, 18 Jul 2018 at 22:20 Henrik Singmann<EMAIL_ADDRESS>wrote:

I use lab.js https://lab.js.org/ for programming my experiment and then
export to JATOS, which makes the data available as a JSON. So what you
suggest would probably work quite well.
However, only having the metadata in a separate JSON file (i.e., without
resultData) would work as well as matching via resultID is also quite
trivial. I do not think exporting two files would be such a hassle.
However, if your initial suggestion is easier for you to implement, please
do that. Either way is fine.
Finally, I read the statement on privacy and figured that is the reason it
is not possible. However, allowing performance related payment is something
I think quite a lot of users would want (I for sure would be super happy).
So maybe it is a great way to allow this somewhat easier via the API. In
the end, we users should be aware that we are ultimately responsible for
ensuring the data of our participants are treated in an ethical manner and
identifying information, such as the MTurk IDs, are not used in an
inappropriate or illegal manner or even posted on the web.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/JATOS/JATOS/issues/40#issuecomment-406061346, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AH1eBg8324-G-X-sKi_1fynI0pbnF8G1ks5uH5iEgaJpZM4C9GoA
.

Thanks, that sound great. And this is not super urgent. I have a project planned where we want to use it, but the PhD student is still in the programming of the experiment stage.
And does your corrected statement mean that the mturk ID is already available via the API?

No the MTurk worker ID is not available via jatos.js yet. I'll add it in the next release.

There are other URL query parameters next to the MTurk workerId coming from MTurk:
assigmentId, hitId, turkSubmitTo. Do you think they could be of any use for a study? If not I would rather not add them to keep data as minimal as possible.

I do not think they would be of any use. From my perspective there is no need to add them. Looking forward to the next release!

Hej you two, just a quick note regarding a possible workaround -- lab.js also captures query parameters, so they should be available in the main data (all URL parameters should be in the column url). That being said, managing this information through JATOS seems like a better idea!

@FelixHenninger Unfortunately, the MTurkId is not part of the URL participants click on. I believe it is only part of the return URL (or something like that). At least, it is clearly not part of the data. I only get the subject ID assigned by JATOS. For example, the data of one participants begins with: [{"url":{"srid":"50"},"meta" ...

JATOS doesn't keep URL query parameters after the study is started. Instead
it puts them in jatos.urlQueryParameters, e.g. for MTurk worker ID it's
jatos.urlQueryParameters.workerId. And since lab.js runs after JATOS does
its thing it has no change of capturing MTurk parameters. Sorry.
On Sat, 21 Jul 2018 at 16:41 Henrik Singmann<EMAIL_ADDRESS>wrote:

@FelixHenninger https://github.com/FelixHenninger Unfortunately, the
MTurkId is not part of the URL participants click on. I believe it is
only part of the return URL (or something like that). At least, it is
clearly not part of the data. I only get the subject ID assigned by JATOS.
For example, the data of one participants begins with: [{"url":{"srid":"50"},"meta"
...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/JATOS/JATOS/issues/40#issuecomment-406800941, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AH1eBiLXncGuNJBJC7UHDSoL_9X9ccYXks5uIz2vgaJpZM4C9GoA
.

This issue is getting confusing - it spread out into multiple issues :/
Good news: MTurk worker ID is implemented: jatos.urlQueryParameters.workerId is part of next release
Question regarding result metadata: I would implement it like you suggested without the actual result data - just metadata. And then JSON is actually overkill. Since it's already in table format I'd prefer CSV format. Do you agree?

Yes, I agree. csv for tabular data is perfect.
And sorry for the confusion.


possible to contribute to the tool?

I've just seen the tool and looks interesting may also be relevant to me. Therefore the question whether one can contribute 😁

Just saw the CONTRIBUTING.md file. My mistake 😁


Declaring arrays doesn't work in shaders

Godot 3.0 alpha2
Windows 10 64 bits
nVidia 940M
I tried to write this in a shader:
	vec4 test[8];

However it didn't compile, the error is:
SCRIPT ERROR: (null): Expected ',' or ';' after variable
          At: :18

I thought such a construct was allowed in GLSL?

Not going to be supported in 3.0, possibly in 3.1 or above

Can I ask why though? I just came on a QA thread asking for array uniforms: https://godotengine.org/qa/27228/array-godot-shader
And according to https://github.com/Zylann/godot_heightmap_native_plugin/issues/22, the amount of textures you can sample in a shader is limited on some graphics cards (so using textures as array inputs has a higher cost than just supporting them).

duplicate of #10751


Add text changes

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Hi @Ashmita03, thank you for the PR! Unfortunately, your branch has some merge conflicts that are difficult to resolve. The painless way to fix this is to create a fresh PR.
So I'm going to close your PR now and looking forward to your new one. I'm so sorry for the inconvenience.


Decide on what's part of OceanParameterizations.jl and what should be in a script

I think I didn't organize the repo well since src/ includes stuff like https://github.com/CliMA/OceanParameterizations.jl/blob/master/src/ocean_convection.jl which now seems pretty specific to free convection so it shouldn't have been in src/.
Things like https://github.com/CliMA/OceanParameterizations.jl/blob/master/src/GaussianProcesses/GaussianProcesses.jl and https://github.com/CliMA/OceanParameterizations.jl/blob/master/src/differentiation_operators.jl are more generally useful so they might belong in src/.
Solving this issue would probably help a lot with #24.

Maybe what I should have done is create a FreeConvection module with my scripts so it's separate from OceanParameterizations.jl then move any generally useful bits/utils into OceanParameterizations.jl.


"get credentials" API improvements

https://github.com/jim-minter/rp/issues/11
It's not super clear that "kubeadminPassword" is the password for the "kubeadmin" user.  Possibly add a dummy kubeadminUsername field statically set to the value "kubeadmin".

Consider in the next round of API updates.


TinaCMS initializer types don't match return types

Description
The initializer accepts apis as an object, but returns api.[my-api].
Expected result
I expect it to match the same shape:
  const cms = new TinaCMS({
    api: {
      myAPI: client,
    },
    sidebar: true,
    enabled: false,
  });

  // grab the api with this:
  cms.api.myAPI

Actual result
  const cms = new TinaCMS({
    apis: {
      myAPI: client,
    },
    sidebar: true,
    enabled: false,
  });

  // this isn't intuitive
  cms.api.myAPI

@dwalkr I can tackle this, but which API do want to preserve? Possibly we should keep the functionality entact but throw a console warning against the deprecated one?

@dwalkr I can tackle this, but which API do want to preserve? Possibly we should keep the functionality entact but throw a console warning against the deprecated one?

My 2c is to use apis - we have plugins, events as plural, so that would seem most consistent.
fwiw, I did find a reference to cms.apis in the docs already, so that's one less thing to update later!