Navbar, Avatar, Menu, Switch

Adds several new components:

[ ] Navbar (WIP, custom, responsive and composable)
[ ] Avatar (Radix)
[ ] Menu (Dropdown Menu in Radix)
[ ] Switch (Radix)

Closes #26

Hey @AaronPlave, thanks for taking the time to add these components, these look great!
I spent a little time reviewing them in storybook and was wondering if the following items require an update:
Switch

The labelPosition values are rendering the opposite of what is chosen. In other words, when one chooses left, the label is on the right.

I see that the component's width is inherited the parent container; however, a flex width spacing is used between the label and the switch when labelPosition="right"; however, when the labelPosition="left", the label and switch are placed next to each other. My thought is that they should always be next to one another. Also, should their width be inherited from their parent container or should the switch's contents dictate their width?

Avatar

Perhaps the typography sizing should scale up when the large version is used? At the moment both avatar sizes use the same type size.

Switch

Good catch on label position - I'll fix that for Switch and Checkbox.
For the situation where text is left, toggle is right, the Stellar figma design specifies that the width be defined by the parent element. https://www.figma.com/file/a696svN2S7YNlZRYAkeLob/Stellar-Design-System?type=design&node-id=5441-7943&t=tLux7kDqdl3Ig71o-4. I think the idea behind this is to maintain a consistent positioning of the right-side toggle in a list of switches/checkboxes/radios. The stories for Switch and Checkbox present their components in a sort of unusual fashion, maybe it'd be useful to constrain the parent width in the stories to show intended use?

Hey @AaronPlave , regarding your comments:

maybe it'd be useful to constrain the parent width in the stories to show intended use?

I think this would be helpful.

One argument against larger text size here would be that large buttons in Stellar don't have larger text size. Guess it depends on where this large avatar will be used. Could alternatively just get rid of the large size until we have a spec?

Hmm, is there a design requirement to not scale the font on the larger buttons? I could imagine that the typography should scale when buttons do.  I'm good with hiding the large size until we have a spec or consensus on how components across the design system should behave when their size is increased or decreased.

Do we need a "logged out" navbar? eg. with a Log in button in place of the avatar menu?

Also... in mobile mode, does it make sense to show the account/login button + the hamburger?

@AaronPlave I pulled down your recent changes and reviewed them. Thanks for fixing the label placement issue for the Switch/Toggle component, looks good!
On the Navbar and Menu components, there appears to be an issue with the foreground color for the typography and icon? They show as light color which is very hard to discern. Apologies if you're already working on a resolution for this.

On the Navbar and Menu components, there appears to be an issue with the foreground color for the typography and icon? They show as light color which is very hard to discern. Apologies if you're already working on a resolution for this.

@anilnatha I think that might be part of a separate issue that'll need to be addressed in the stellar library itself. The "dark" CSS theme has background/text color specifications that are both light. Can you confirm if you're using the dark mode theme in your storybook preview? If so, do you mind switching to light mode and seeing if it's still too light?

On the Navbar and Menu components, there appears to be an issue with the foreground color for the typography and icon? They show as light color which is very hard to discern. Apologies if you're already working on a resolution for this.

@anilnatha I think that might be part of a separate issue that'll need to be addressed in the stellar library itself. The "dark" CSS theme has background/text color specifications that are both light. Can you confirm if you're using the dark mode theme in your storybook preview? If so, do you mind switching to light mode and seeing if it's still too light?

@duranb Thanks for the summary of what the issue may be. I was using the dark mode when viewing the changes and verified that the issue is specific to that as evidenced by these screenshots:
Dark Mode — menu icon not visible

Light Mode — menu icon is now visible

Dark theming isn't built out for react-stellar yet 😅 but we'll get there in a separate effort.

Right, I remember you mentioning that. So that last issue I reported can be pushed off. I need to be mindful of running this in light mode. My apologies.

@duranb Thanks for the summary of what the issue may be. I was using the dark mode when viewing the changes and verified that the issue is specific to that as evidenced by these screenshots:

@anilnatha Thank you for verifying!

Any other comments on this PR?

None from me.


Failing to init on Ubuntu with 0.3.2-hotfix

It seems like issue #237, tried the steps there but it didnt work
$ ksync init
==== Preflight checks ====
Cluster Config                              ✓
Cluster Connection                          ✓
Cluster Version                             ✓
Cluster Permissions                         ✓
==== Cluster Environment ====
Adding ksync to the cluster                 ✓
Waiting for pods to be healthy              ✓
==== Postflight checks ====
Cluster Service                             ✓
Service Health                              ✓
Service Version                             ✘
↳	There is a mismatch between the local version (0.3.2-hotfix) and the cluster ().
Run 'ksync init --upgrade' to fix.
FATA[0000]
Running ksync init --upgrade does not work nor does the clean and init (with image tag) commands
Originally posted by @Megalepozy in https://github.com/vapor-ware/ksync/issues/237#issuecomment-429760082

@Megalepozy Actually this is #162 . However the steps are documented further down in the #237 thread as you mentioned.
tl;dr ksync init --remote --image=vaporio/ksync:0.3.2-hotfix

@Megalepozy The problem is that remote DaemonSet is not pulling down the correct image (hence the lack of a version number). You're local client binary is correct, but you need to specify the remote version to use.

@timfallmk ahh kewl, thanks a lot for ur quick help and awesome project! :)


Login with Facebook does work with the browser but not with the app

Step 2: Describe your environment

Objective C or Swift: Swift
iOS version: 13.3
Firebase SDK version: 6.6.2
FirebaseUI version: 8.4.1
CocoaPods Version: 1.8.4

Step 3: Describe the problem:
When logging in with a Facebook account, it does only work if the Facebook app is not installed. Using the redirection from the browser works just fine. Only the app redirection is broken. Coming back from the Facebook app to our app just doesn't trigger anything.
Steps to reproduce:

Ensure that the Facebook app is installed on your device.
Open the browser and ensure that you're not logged in on Facebook.
Initiate the login process using Firebase UI.
The browser popups and shows the Facebook website.
You're getting asked whether you want to open this website in the Facebook app. Confirm.
Log in by using the Facebook app.

Observed Results:

The Facebook app opens your app again
But the browser / webview is still visible (asking you whether to proceed in the Facebook app) and hasn't changed
Closing the webview reveals the Firebase UI login screen
Closing the Firebase login screen does not show any logged-in user

Expected Results:

The Facebook app opens your app again
The webview is closed already (or does so automatically)
The Firebase UI login screen is closed already (or does so automatically)
Our app receives a valid login callback

Further notes
It's not a new setup. We've integrated Firebase UI into our app a while ago and tested this behavior at that time. Something may have changed in between (e.g. cause of a Firebase or a Facebook update). Originally, the Facebook app was completely ignored, even though it was installed and so the issue didn't appeared earlier.

Can you test login with just the Facebook SDK (without FirebaseUI)? We've seen some similar issues that ended up being issues in the Facebook SDK.

I had some problem. and solved it.
You check out that Xcode 11, Swift 5, iOS 13 has replaced "AppDelegate"'s
func application(_ app: UIApplication, open url: URL, options: [UIApplication.OpenURLOptionsKey : Any] = [:]) -> Bool
with "SceneDelegate"'s
func scene(_ scene: UIScene, openURLContexts URLContexts: Set<UIOpenURLContext>).
Here is the completed description:
import FBSDKLoginKit

func scene(_ scene: UIScene, openURLContexts URLContexts: Set<UIOpenURLContext>) {
        guard let url = URLContexts.first?.url else {return}
        ApplicationDelegate.shared.application(UIApplication.shared, open: url, sourceApplication: nil, annotation: [UIApplication.OpenURLOptionsKey.annotation])
}

There is a bug in the Google example
a) I do not use Scenes
b) the correct way to handle this is :
func application(             _ app: UIApplication,             open url: URL,             options: [UIApplication.OpenURLOptionsKey : Any] = [:]         ) -> Bool {         UIApplication.shared.applicationIconBadgeNumber = 0         guard let firebaseUI = FUIAuth.defaultAuthUI() else { return false }         let sourceApplication = options[UIApplication.OpenURLOptionsKey.sourceApplication] as? String         let handled = firebaseUI.handleOpen(url, sourceApplication: sourceApplication)         return handled     }
The sourceApplication param is optional in the FUIAuth

Same problem

Hi we came across this issue as well, are there any updates to this as this makes Facebook Login unworkable from firebase?


Added "Python Tricks: The Book" recommendation

Included a short summary of Python Tricks: A Buffet of Awesome Python Features, and relevant website and Amazon links for book recommendation.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thank you for opening this pull request.
Book recommendations are beyond the scope of the freeCodeCamp Guide, so we've decided to go ahead and remove these book recommendation articles.
I encourage you to review this book in the ratings category of the freeCodeCamp forum. Your recommendation will reach way more people there.
Thanks again recommending this book, and for contributing to the freeCodeCamp Guide.


Remove tokio dependencies

Lots of small changes for #2416 :

The RPC service now accepts an Arc<dyn futures::future::Executor<Box<dyn Future>>> instead of tokio::runtime::TaskExecutor, which makes it possible to not depend on tokio anymore.
The import queue now manually polls the worker if we fail to spawn a future.
The Service itself now works like the import queue: it must be polled, and polling attempts to spawn background tasks. If spawning a task fails, we poll it manually.
Removes the TaskExecutor and on_exit from TelemetryOnConnect. Grandpa now spawns telemetry futures on the main executor.
Biggest breaking change. Removes the executor parameter from various service constructors and components. You can use service.spawn_task instead of spawning a task using the executor.
import_blocks now returns a Future that performs the operation, instead of blocking.

I unfortunately couldn't add substrate-rpc to the CI wasm testing, because this line badly collides with the expectations of cargo web. For the initial WASM-browser prototype, I intended to remove the RPC endpoint anyway.
Small note: you can see that I added .expect("failed to spawn task") at several locations, and this panic is not proven. However, please note that before this PR we were using task_executor.spawn(), which as you can see here calls unwrap.
In other words, while we now have additional calls to expect(), the actual changes of panicking are the same as before, except that before they were hidden.

I've fixed the connectivity test not working by replacing shutdown_when_idle with shutdown_now.
Before this PR, the service would get dropped before the shutdown. After this PR, since the service has to be polled, we put it in an Arc and spawn it in a separate task.
Unfortunately, just like the network tests, the service test are deeply depending on the fact that we have background threads running, and I don't know how to fix that "properly" without rewriting the tests.


Opaque flowing water

I have the same issue.

yep, i thinks its cuz of sodium

yep, i thinks its cuz of sodium

Yeah, Sodium uses the alpha field for a color for lighting information. As a quick fix, biome-specific water opacity (and therefore the resource pack) will be disabled when using Sodium. These changes have been reflected in version 1.8.0!


fix: azure-CLI federated ID creation

Current code uses OBJECT-ID to create federated credentials. But this is not correct.
See: https://learn.microsoft.com/en-us/cli/azure/ad/app/federated-credential?view=azure-cli-latest
"Application's appId, identifierUri, or id (formerly known as objectId)."
Using the appId is successful, while using the OBJECT-ID (id), results in the error:
Resource 'OBJECT-ID' does not exist or one of its queried reference-property objects are not present.

@MoChilia

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Hi @fernandoroa, thanks for your contribution! But according to https://learn.microsoft.com/en-us/cli/azure/ad/app/federated-credential?view=azure-cli-latest, object-id is also valid. This change seems unnecessary.

Hi @fernandoroa, thanks for your contribution! But according to https://learn.microsoft.com/en-us/cli/azure/ad/app/federated-credential?view=azure-cli-latest, object-id is also valid. This change seems unnecessary.

Hi @MoChilia,
The cited link said "formerly objectId" which I agree is not a problem.
However, as I stated in the first comment:
"Using the appId is successful, while using the OBJECT-ID (id), results in the error:"
So, the procedure in the modified file, is incorrect, because in the procedure there is the App Id and also the Object Id, and the procedure says the user should use the object-id, which produces an error, and nowhere it says to use the correct id (appId) to have success.
So, that is why I think my proposed changes are not only valid, but necessary for the users to have success with the procedure described in the "modified" file.

Hi @fernandoroa, if a change is needed, we should specify that the id parameter can be the identifier URI, application ID, or object ID of the application.

Sorry, I must be missing something.
I don't understand why if I follow the procedure using the ObjectId (in the federated identity step), and it fails, the objectId must remain as is.
The changes proposed were the minimal I could think of, to avoid someone to get the same errors and confusion I got, for using the objectId were it produces errors
Thanks for your interest.
You can dismiss this PR.

Closing per https://github.com/MicrosoftDocs/azure-dev-docs/pull/1391#issuecomment-2140538670.


how can i download

go to https://github.com/SciCraft/mc-scanner/releases/tag/v0.1.0 and download the jar file


 There's really not too much to say here, you clearly understand the theory behind the calculations and feel comfortable with t-testing and you've created a function to automate your interpretations. Great job!
One thing you can start focusing on is following PEP8 standards for your code. https://www.python.org/dev/peps/pep-0008/
It's not that important, but it will make your code cleaner and easier to read, which is a great 'soft-skill' to have when you start job seeking or collaborating with other developers.

Nice work, only comment is that I think you could do some formatting for your notebook to make the print statements easier to read, or use markdown, but your code is solid, your implementation is efficient and clearly defines the relationship.
Really well done 👏

Excellent work cleaning up your missing values, making your data easily readable.
One thing you could try to make your life easier if you have lots of printing to do is using formatted print statements. https://docs.python.org/3/tutorial/inputoutput.html
Obviously not a big deal, just a note if you need to print lots of values.
Also I thought your bar charts where a great way to compare the extremity of your features. It really shows the relationship and is an easy reference. You can make your charts easier for yourself and others to compare with subplots. This example is obviously different than the data you're working with, but it might give you some ideas. https://matplotlib.org/gallery/lines_bars_and_markers/barchart.html#sphx-glr-gallery-lines-bars-and-markers-barchart-py
Lastly,
I totally agree that not having real feature names is a pain, unfortunately you'll be seeing this pattern a lot, with real world data and otherwise, and you'll see it almost always when working with vector data for machine learning, so the more familiar you can make it for yourself, the better.
Really great work!


Handle Requests through a Proxy

In .NET Core, to handle request through a proxy you must set a custom HttpRequestHandler and set the proxy property. One could check this here: [https://github.com/dotnet/corefx/issues/7037].
As it is encapsulated in the TMDbClient class, it is not possible to configure proxy manually. A way of doing this would be to check configuration. You could also receive an optional "settings" object in TMDbClient constructor or look into environment variables (like HTTP_PROXY).

I would go the constructor way then. So you can provide the implementation of whatever httpclient can use.
This should do it?
A pull request setting it up would be appreciated :)
Sent from my iPhone

On 13. sep. 2016, at 14.09, lersouza<EMAIL_ADDRESS>wrote:
In .NET Core, to handle request through a proxy you must set a custom HttpRequestHandler and set the proxy property.
As it is encapsulated in the TMDbClient class, it is not possible to configure proxy manually. A way of doing this would be to check configuration. Yu could also receive a options settings object in TMDbClient constructor or look into environtment variables.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

OK. Working on it.
I created the "issue-201-proxy-support" branch locally to work on this. Can it be created in this repo so I can push the code to it?

Normally you fork the project, create whatever branches you want.
Once done, you submit a pull request. :)
Mvh.
Michael
On Wed, Sep 14, 2016 at 6:57 PM, lersouza<EMAIL_ADDRESS>wrote:

OK. Working on it.
I created the "issue-201-proxy-support" branch locally to work on this.
Can it be created in this repo so I can push the code to it?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/LordMike/TMDbLib/issues/201#issuecomment-247080935,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA-sJ57E7ZV_lcslk8xEc9eU42tN9bT3ks5qqCdrgaJpZM4J7mOH
.

Great. Tks.

@lersouza thanks for the changes. I went through them and made a few minor edits (it also seemed like you never passed the WebProxy to the RestClient).
https://www.nuget.org/packages/TMDbLib/1.0.3-alpha
Ver. 1.0.3-alpha includes your changes, and I was able to use my local Fiddler as a proxy with your code. :)


526 mybabb get ogimage tag to work

Putting in the LoremPicsum url again to test.  I figure it will work compared to the previous test,  for some reason an external image works. but not one that is being retrieved from within the web site itself. test to see results now..  if so then we know what is happening but just need to figure out why.   netlify automatically tries to insert the https://www.climatetechhandbook.com/img/social-cover.png   that is not recognized and is not even entered.

nope,  still inserts the social image png that is not recognized,   will look into that now.


Fixed dev img above the footer on mobile view

Description
Closes #242
Screenshots

[x] I have tested my changes to ensure they work as expected
[ ] I have included documentation for any new features or changes
[x] I have formatted my code according to the project's style guidelines
[ ] I have written tests for any new features or changes
[x] I have run the project's test suite and verified that all tests pass
[ ] I have updated the README and any other relevant documentation
[x] I have checked for any spelling or grammatical errors

@media only screen and (max-width: 768px) {
  .dev-img-parent-class {
    height: 40vh;
  }

  .dev-img-class {
    width: 80%;
    height: auto;
    max-width: 300px;
    top: 40%;
    left: 50%;
    transform: translate(-35%, 0%);
  }
}

how to write this in tailwind?

ok, I'm merging it now. I will look into it later.

I am looking into it. If I change them I will open a PR. @priyankarpal

I am looking into it. If I change them I will open a PR. @priyankarpal

ok cool


Option to force 2D texture resource for all 1D luts

Hi,
OCIO's GPU processor will automatically switch the texture resource type from a 2D texture to a 1D texture with sufficiently small 1D LUTs (i.e. going from 4096x2 to 2048x1). (As illustrated by the issue @remia discovered with our integration.) The OpenGL sample does implement this, but I'd unfortunately missed this behavior entirely.
Fixing this remains problematic however. Unreal does not support 1D textures, and for reference neither does Unity nor OpenGL ES / WebGL. (I believe any sampling performance difference is non-existent, making them superfluous?)
As such, having an option to disable their use and always default to 2d textures would be essential. As Remi suggested, something like a setAllowTexture1D exposed on the GpuShaderCreator or the GpuShaderDesc class would work.
(Happy to work on a PR if this feature request gets approved.)

Thank you for exploring this problem @num3ric, we would certainly welcome your help in addressing it!


make topbar sticky when using composer on mobile

Fixes Issue #113 (https://github.com/wearenewpublic/psi-product/issues/113)
Applies the absolute styling to the TopBar only for mobile on the composer screen. If we don't use these conditions, then we have to solve the problem of the content sliding underneath the topbar everywhere across the app.
I showed Tori this video of the change and she approved:
https://drive.google.com/file/d/1S4dHqcV3tnRIjLikoluFA7S5bTlqwtBi/view?usp=sharing
Question-- it looks like props currently being passed into TopBar from FullScreen are not actually used by TopBar:
title={title} index={index} params={params} subtitle={structure.name}
So I deleted these-- just confirming this is fine?

We are abandoning this one, right?
I'm going to close this, but feel free to re-open.


Octavia check is missing required role in the openstack

To fix it:
openstack role add --user-domain service_domain --user nagios --project-domain service_domain --project services load-balancer_global_observer

Imported from Launchpad using lp2gh.

date created: 2023-09-01T14:43:54Z

owner: mastier1

assignee: None

duplicate of: #137

the launchpad url

(by mastier1)
This is a duplicate of https://bugs.launchpad.net/charm-openstack-service-checks/+bug/1962782


Is possible to use a 3D lidar with a 2D lidar to get more accuracy?

Hello, I am trying to use a 3D Velodyne VLP-16 wirth a 2D lidar (mounted in vertical position) in  order to get more accuracy on the z axis.
Actually I have manage to use Cartographer only with an IMU and the above 3D lidar, but sometimes the Z axis get a wrong value (with a big error). I think the problem is that I have few features detected from the 3D lidar, so I think that use a distance sensor (with message converted from Range to LaserScan data) or maybe directly a laserscan like the LDS-01(https://github.com/ROBOTIS-GIT/hls_lfcd_lds_driver#hlds-hls-lfcd-lds-lds-01).
When I try to use both sensors I get the following error:
[ WARN] [1639070542.328478953]: W1209 18:22:22.000000 13627 sensor_bridge.cc:211] Ignored subdivision of a LaserScan message from sensor scan because previous subdivision time<PHONE_NUMBER>37557396 is not before current subdivision time<PHONE_NUMBER>37281184

This is my lua:
include "map_builder.lua"
include "trajectory_builder.lua"

options = {
  map_builder = MAP_BUILDER,
  trajectory_builder = TRAJECTORY_BUILDER,
  map_frame = "local_origin",
  tracking_frame = "vectornav",
  published_frame = "base_link", --base_link
  odom_frame = "odom",
  provide_odom_frame = true,
  publish_frame_projected_to_2d = false,
  use_pose_extrapolator = true,
  use_odometry = false,
  use_nav_sat = false,
  use_landmarks = false,
  num_laser_scans = 1,
  num_multi_echo_laser_scans = 0,
  num_subdivisions_per_laser_scan = 1,
  num_point_clouds = 1,
  lookup_transform_timeout_sec = 0.2,
  submap_publish_period_sec = 0.3,
  pose_publish_period_sec = 5e-3,
  trajectory_publish_period_sec = 30e-3,
  rangefinder_sampling_ratio = 1.,
  odometry_sampling_ratio = 1.,
  fixed_frame_pose_sampling_ratio = 1.,
  imu_sampling_ratio = 1.,
  landmarks_sampling_ratio = 1.,
  publish_tracked_pose= true,
}

TRAJECTORY_BUILDER_3D.num_accumulated_range_data = 1
TRAJECTORY_BUILDER_3D.pose_extrapolator.use_imu_based=true
--aggiunti per utilizzare il terabee
--TRAJECTORY_BUILDER_3D.use_online_correlative_scan_matching=true
--TRAJECTORY_BUILDER_3D.real_time_correlative_scan_matcher.linear_search_window=0.15

MAP_BUILDER.use_trajectory_builder_3d = true
MAP_BUILDER.num_background_threads = 10

POSE_GRAPH.optimization_problem.huber_scale = 5e2
POSE_GRAPH.optimize_every_n_nodes = 0 --320 --0 disabilita il loop closure
POSE_GRAPH.constraint_builder.sampling_ratio = 0.03
POSE_GRAPH.optimization_problem.ceres_solver_options.max_num_iterations = 10
POSE_GRAPH.constraint_builder.min_score = 0.62
POSE_GRAPH.constraint_builder.global_localization_min_score = 0.66
--POSE_GRAPH.optimization_problem.log_solver_summary = true

I have already try to synchronize the two output topics with the ros filters, like reported in this code:
import rospy

import message_filters
from sensor_msgs.msg import LaserScan, PointCloud2

last_laserscan=LaserScan()
last_pointcloud=PointCloud2()

def talker(last_laserscan, last_pointcloud):
 # Publishers
 laserscan_pub = rospy.Publisher("laserscan_sync", LaserScan, queue_size=1)
 velodyne_pub = rospy.Publisher("velodyne_points_sync", PointCloud2, queue_size=1)
 last_laserscan.header.stamp=rospy.Time.now()
 last_pointcloud.header.stamp=rospy.Time.now()
 laserscan_pub.publish(last_laserscan)
 velodyne_pub.publish(last_pointcloud)

if __name__ == "__main__":
   rospy.init_node("synchronizer", anonymous=True)
   laserscan_sub=LaserScan()
   velodyne_sub=PointCloud2()
   # Subscribers
   laserscan_sub = message_filters.Subscriber('scan', LaserScan)
   velodyne_sub = message_filters.Subscriber('velodyne_points', PointCloud2)
   ts = message_filters.ApproximateTimeSynchronizer([laserscan_sub,velodyne_sub], 1,0.1)
   #ts=message_filters.TimeSynchronizer([laserscan_sub,velodyne_sub], 2)
   ts.registerCallback(talker)
   #rate.sleep()
   rospy.spin()

The velodyne output is the /velodyne_points topic and have a frequency of 10Hz, the laserscan output is /scan and have 20Hz of frequency.
Can someone give me some advice? Thanks in advance.

Can you provide bag and urdf files?

For the moment I stop that route, now I am trying to tuning better the slam, in order to reduce the Z error when it spin.


Define formal primitives specification

The JSON primitives files can be fairly large and complicated and susceptible to misspecification. Implement a formal specification for the JSON files using json schema

define the specification in JSON schema (I suggest using the jsonschema package from PyPI)

implement a validator to validate a JSON primitive file:
  from mlprimitives.validation import validate
  primitive = load_primitive_from_json()  # or similar
  primitive = validate(primitive)

I agree on using a json schema for this.
However, this should not be here but rather on MLBlocks.
Then, optionally, if we consider that MLPrimitives needs to add anything to it, it should extend the one from MLBlocks to add its own things.
Note that the primitive specification is mostly explained already in the MLBlocks documentation, even though it is not defined in a truly formal way.
Regarding the validation function, I totally agree on creating it, but also on the MLBlocks side.
Until this is done, the approach that we followed for a basic validation was creating an MLPipeline instance that uses the primitive, but this clearly is not good enough.

Suppose someone were to make a pull request to MLPrimitives to add a new primitive. Would it make sense that MLPrimitives needs to rely on an external library to decide if the primitive is valid? I think it makes sense to define the specification for primitives in MLPrimitives.
Certainly the existing documentation and validation works for our purposes so far but a jsonschema would formalize this and make our lives easier.

(Correction: I meant the jsonmodels package on PyPI: https://jsonmodels.readthedocs.io/en/latest/)

@csala Bumping this. Has our thinking changed on the presence of a formal specification? I still suggest adding a json schema specification for ml primitives within the mlprimitives repo. Even the specification is sufficient; a validator is not strictly needed, though would be useful.

@micahjsmith this is pending to be discussed in the future, after some other changes get in first.


nz-time-picker组件中 ngModel 类型明明是Date却出现警告信息

Reproduction link
https://stackblitz.com/edit/angular-x1ty2w-qecpnp?file=src/app/app.component.ts
Steps to reproduce
控制台警告
[NG-ZORRO]: Non-Date type is not recommended for time-picker, use "Date" type
What is expected?
无警告
What is actually happening?
有警告

Environment
Info

ng-zorro-antd
9.0.2

Browser
Chrome(x64) 81.0.4044.113

checkTimeUpdate:Date;的类型明明是Date，但是还是显示警告信息

@wenqi73 undefined | null 应该是被允许的默认值


Request: Make reloadData synchronous

Looks like this line makes reloadData an async operation. From my reading, it looks like there's no way to make a synchronous reloadData call.
It's also not clear why we're doing a dispatch_async there, since we are already asserting main thread within the function.
Questions:

Is there a way to make a sync reloadData call.
Do we need to do a dispatch_async there?

hey @dhavalcue 😄
the reason for this is that there could be batch updates in-progress. (or other calls to reloadData from elsewhere). this design serves 2 main goals: (1) coalesce all updates, (2) make update calls reentrant
cc @rnystrom in case i've got this wrong

as far as synchronously calling reloadData, you should be able to simply call this on the collectionView (although this is discouraged for the reasons above because of how IGListKit tracks state)
cc @rnystrom again 😄

@jessesquires: Thank you! The context helps!
I did not understand your workaround. Do we call reloadData from the view controller directly? How do we update IGListKit's state?

@jessesquires is spot on. This is a performance optimization. We collect multiple calls for batch updates and reload within run loop turns (really just dispatch_async).
You def could just call [UICollectionView reloadData] but if your data sources have changed, nothing will actually happen. Calling [IGListAdapter performUpdatesAnimated:completion:] (with animated:NO) should suffice. Just use the completion block if there's something you need to do afterwards.
Curious, is there a reason you want it to be sync?

Thanks @rnystrom!
We want to hold view controller transition until the content is ready so that the transition looks smooth (instead of a subtle flash that will happen when reload completes).
The workaround I have at this time is to initialize the view controller, listAdapter.reload, wait on completion and then present the view controller. The workaround works great, the code is a little messy, however I can live with that.
Thanks for your quick responses @rnystrom, @jessesquires! 😄

Doesn't -[IGListAdapter reloadDataWithCompletion:] happen immediately?
https://instagram.github.io/IGListKit/Classes/IGListAdapter.html#/c:objc(cs)IGListAdapter(im)reloadDataWithCompletion:

Not if I use IGListAdapterUpdater. Because of this.

Can't you add a DispatchGroup semaphore to make this call synchronous in this case?


[nginx-ingress-controller] Fix duplicated real_ip_header

fixes #1316

I thought we were doing some static checking of the config before reload (and not reloading if the config was invalid)? if that's not the case, can you please file a follow up bug. LGTM.

If reload returns an error nginx continues using the previous version

ah so this won't cause downtime right? just a broken feature

exactly. This is an issue when you start with an error in nginx.conf not in a reload

hmm, we can probably work around that too by persisting the last known good template in a volume of configmap, reading on boot up, and only overwriting it on success reload. But a better first step would be an e2e for the nginx controller :)


Add block rewards to trace_block response

Describe the feature
the trace_block endpoint should return the block rewards:
ref https://github.com/paradigmxyz/reth/issues/3427#issuecomment-1609902468
TODO

update rpc-types
add block rewards

Additional context
No response

Here is some examples(via OpenEthereum/Parity):

block only

$ curl -XPOST <IP_ADDRESS>:6545 -H 'content-type: application/json' -d '{"jsonrpc":"2.0","id":1,"method":"trace_block","params":["0xB459"]}' | jq

{
  "jsonrpc": "2.0",
  "result": [
    {
      "action": {
        "callType": "call",
        "from": "0xbd08e0cddec097db7901ea819a3d1fd9de8951a2",
        "gas": "0x0",
        "input": "0x",
        "to": "0x5c12a8e43faf884521c2454f39560e6c265a68c8",
        "value": "0x1142b0090b6460000"
      },
      "blockHash": "0x5793f91c9fa8f824d8ed77fc1687dddcf334da81c68be65a782a36463b6f7998",
      "blockNumber": 46169,
      "result": {
        "gasUsed": "0x0",
        "output": "0x"
      },
      "subtraces": 0,
      "traceAddress": [],
      "transactionHash": "0x19f1df2c7ee6b464720ad28e903aeda1a5ad8780afc22f0b960827bd4fcf656d",
      "transactionPosition": 0,
      "type": "call"
    },
    {
      "action": {
        "author": "0xe9a411144a689aa2137b0efe7b6273491e636d8c",
        "rewardType": "block",
        "value": "0x4563918244f40000"
      },
      "blockHash": "0x5793f91c9fa8f824d8ed77fc1687dddcf334da81c68be65a782a36463b6f7998",
      "blockNumber": 46169,
      "result": null,
      "subtraces": 0,
      "traceAddress": [],
      "transactionHash": null,
      "transactionPosition": null,
      "type": "reward"
    }
  ],
  "id": 1
}

block + uncle rewards

$ curl -XPOST <IP_ADDRESS>:6545 -H 'content-type: application/json' -d '{"jsonrpc":"2.0","id":1,"method":"trace_block","params":["0x3"]}' | jq

{
  "jsonrpc": "2.0",
  "result": [
    {
      "action": {
        "author": "0x5088d623ba0fcf0131e0897a91734a4d83596aa0",
        "rewardType": "block",
        "value": "0x478eae0e571ba000"
      },
      "blockHash": "0x3d6122660cc824376f11ee842f83addc3525e2dd6756b9bcf0affa6aa88cf741",
      "blockNumber": 3,
      "result": null,
      "subtraces": 0,
      "traceAddress": [],
      "transactionHash": null,
      "transactionPosition": null,
      "type": "reward"
    },
    {
      "action": {
        "author": "0xc8ebccc5f5689fa8659d83713341e5ad19349448",
        "rewardType": "uncle",
        "value": "0x340aad21b3b70000"
      },
      "blockHash": "0x3d6122660cc824376f11ee842f83addc3525e2dd6756b9bcf0affa6aa88cf741",
      "blockNumber": 3,
      "result": null,
      "subtraces": 0,
      "traceAddress": [],
      "transactionHash": null,
      "transactionPosition": null,
      "type": "reward"
    }
  ],
  "id": 1
}

thanks, I must have missed them when porting the types


Add LayZSpa to HomeAssistant no climate entity

Bestway device
Home Assistant 2023.8.2 Supervisor 2024.04.0 Operating System 10.4 Kezelőfelület 20230802.0 - latest
LayZSpa Helsinki
Describe the bug
After i added my Helsinki to Home Assistant, no climate entity.
Logs
Ez a hiba egy egyéni integrációból lett származtatva.
Logger: homeassistant.loader
Source: custom_components/bestway/climate.py:25
Integration: Bestway (documentation, issues)
First occurred: 15:04:52 (2 occurrences)
Last logged: 15:22:44
Unexpected exception importing platform custom_components.bestway.climate
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/loader.py", line 833, in get_platform
cache[full_name] = self._import_platform(platform_name)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/loader.py", line 850, in _import_platform
return importlib.import_module(f"{self.pkg_path}.{platform_name}")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "", line 1204, in _gcd_import
File "", line 1176, in _find_and_load
File "", line 1147, in _find_and_load_unlocked
File "", line 690, in _load_unlocked
File "", line 940, in exec_module
File "", line 241, in _call_with_frames_removed
File "/config/custom_components/bestway/climate.py", line 25, in
| ClimateEntityFeature.TURN_OFF
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/enum.py", line 783, in getattr
raise AttributeError(name) from None
AttributeError: TURN_OFF

The integration is not tested or supported on old Home Assistant versions, which seems to be the problem here. I suggest upgrading to the latest, but you can also try old versions of the integration as an alternative.


[CARBONDATA-4339]Fix NullPointerException in load overwrite on partition table

Why is this PR needed?
After delete segment and clean files with force option true, the load overwrite operation throws nullpointer exception. This is because when clean files with force is done, except the 0th segment and last segment remaining marked for delete will be moved to tablestatus.history file irrespective of the status of the 0th and last segment. During overwrite load, the overwritten partition will be dropped. Since all the segments are physically deleted with clean files, and load model's load metadata details list contains 0th segment which is marked for delete also leading to failure.
What changes were proposed in this PR?
When the valid segments are collected, filter using the segment's status to avoid the failure.
Does this PR introduce any user interface change?

No

Is any new testcase added?

Yes

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/6346/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/4603/

Build Success with Spark 3.1, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_3.1/734/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/4609/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/4612/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/6356/

Build Success with Spark 3.1, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_3.1/743/

LGTM

retest this please

Build Failed  with Spark 3.1, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_3.1/746/

retest this please

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/6360/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/4616/

Random failure in Spark 2.3 build. Merging this PR


Enable access to core functionality through interface

To facilitate testing of the frontend independently from the core, it was necessary to mock the core functionalities. However, these functionalities were provided by package-level functions, which are not easily mockable. Therefore, I have introduced an interface to declare these functionalities. Although it is unlikely that other implementations besides the mock will be needed, this approach allows for flexibility. Additionally, it enables the possibility of having multiple cores with different storage types, as no more package-level global variables are used.

Codecov Report
Attention: Patch coverage is 46.15385% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 38.59%. Comparing base (9b4dc11) to head (c8eef6f).

Files
Patch %
Lines

endpoint/endpoint.go
0.00%
8 Missing :warning:

core/core.go
75.00%
1 Missing and 3 partials :warning:

todolist.go
0.00%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
- Coverage   39.28%   38.59%   -0.69%
==========================================
  Files           4        4
  Lines         168      171       +3
==========================================
  Hits           66       66
- Misses         96       99       +3
  Partials        6        6

Flag
Coverage Δ

go-1.22
38.59% <46.15%> (-0.69%)
:arrow_down:

macos-latest
?

ubuntu-latest
38.59% <46.15%> (-0.69%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


monero-gui: fixup of 7a498ab

Motivation for this change
Was a bit too eager to merged due to the critical bugfix.
The INSTALL_PATH has been fixed upstream and this was causing
the binary to be under $out/bin/bin/.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Backported to 20.09 in d7562d48b520b4ee40989e66834a1f89f01951d4


Refactor index id for composite primary keys

@kiaking @ozum I started working on #261, here is what I'd like to implement:

[x] index key in store should be stringified array of values
[x] $id should return array of values
[x] find / findIn should support array(s) of values as argument
[x] delete should support array(s) of values as argument
[ ] whereId / whereIdIn should support array(s) of values as argument

Feel free to suggest other items that should be refactored regarding this issue !

@lucasbiguet Hi! I hate to push you, sorry, but do you have any update on this?

Hey @kiaking I did not have much time to work on this lately sorry about that !
I tried to implement a common function to generate the stringified composite key but was not pleased with the results. I had trouble finding where to put that common function that needs to be called from Model and BelongsToMany, it just feels weird. Maybe the logic for generating a primary key and a pivot key are not necessarily the same anyway and they should be kept separate.
I'll try to take some time next week to continue this PR, I'll focus on fixing find / findIn to support array as an argument so that we have at least a working prototype of this feature that can be merged

@lucasbiguet Thanks for the reply! I'll be waiting then 👍

Maybe the logic for generating a primary key and a pivot key are not necessarily the same anyway and they should be kept separate.

Maybe yeah. I think it's that critical, so I would say you could leave it as is.

@kiaking I finally had the time to implement find / findIn functions support for composite primary key :tada:
I'm waiting for your review

@lucasbiguet YEAH! Wonderful! It looks pretty good to me! Thank you so much for this!

I also think this feature need to be mentioned in the documentation, what's your policy on that? should I add a PR to the doc repo as well ?

It would be great if you can add them in this PR, though I could do that after merging the PR as well. What would you say?

@kiaking nice, thank for your review !
I found out that delete did not support composite primary key, it was a trivial implementation so I threw it in this PR as well: we can now do User.delete([1, 2]) :metal:
I also found out that whereId and whereIdIn don't support it. The implementation does not seem as simple and I won't have time to work on it this week, so maybe we should merge this PR and open an issue for whereId / whereIdIn to be dealt with later. Or maybe if this is unnecessary complexity they should not support it and the documentation should encourage the developers to use a simple where instead. What do you think ?
Anyways, I also updated the documentation for find / findIn and delete, so if you decide that whereId / whereIdIn support for composite keys is not a priority, this PR is ready to merge !

I found out that delete did not support composite primary key, it was a trivial implementation so I threw it in this PR as well: we can now do User.delete([1, 2]) 🤘

Uhhhh nice!!!

I also found out that whereId and whereIdIn don't support it as well. The implementation does not seem as simple though and I won't have time to work on it this week, so maybe we should merge this PR and open an issue for whereId / whereIdIn to be dealt with later. Or maybe if this is unnecessary complexity they should not support it and the documentation should encourage the developers to use a simple where instead. What do you think ?

I agree. We should deal with them later. Let's merge this baby! Thank you so much for your hard work!!! Super awesome. I'll merge this soon and make a new release 👍

I have a little question on this, with updating to the latest version, i have issues, because my entity ids are strings like '$uid2' and they aren't increments from 1, 2, 3 but they increase by 3. So I have $uid2, $uid5, $uid8... Did i miss something important? And is there a way to get the numbers back?

@lucasbiguet Is there any chance that the whereIdIn method will also support composite keys?


3.1.0 has strange behavior with Away Mode

Since upgrading to 3.1.0, whenever I use HomeKit to set my Daikin to "Away" mode (either manually or via automation), when I turn "Away" mode back off, it automatically turns the Daikin Schedule mode to "On". This occurs whether or not I'm using the Switch to enable the Schedule toggle.
This is not desired behavior. This behavior doesn't exist if you enable and then disable Away mode using the Daikin app or directly on the thermostat. It also does not occur on version 3.0.0, this is definitely related to 3.1.0.

Ahh, yes, you're right. 3.1 attempts to resume the schedule automatically only if one is defined. But it looks like I need to revisit how it detects an existing schedule. Looking closer at it, I think the Daikin data would always indicate a schedule existed, even if you've never adjusted it yourself.
I'll see what I can do. If nothing else, I'll add another setting to auto-enable the schedule when returning from Away and default it to off to return to the previous behavior.

Thanks for the quick response. The Daikin always has a schedule, you cannot delete the last schedule entry. So “On” and “Off” are really important as you cannot have no schedule.
By default, Daikin does not “resume” schedules after coming off Away. If a schedule is already on, it’ll resume, but if Schedule is off, it simply just turns Away off.
Thanks for looking into it. I down rev’d to 3.0.0 which works fine as I don’t use schedules but heavily rely on Away.
Cheers!
Sent from my iPhone
On Oct 29, 2022, at 20:20, jeffschubert @.***> wrote:

Ahh, yes, you're right. 3.1 attempts to resume the schedule automatically only if one is defined. But it looks like I need to revisit how it detects an existing schedule. Looking closer at it, I think the Daikin data would always indicate a schedule existed, even if you've never adjusted it yourself.
I'll see what I can do. If nothing else, I'll add another setting to auto-enable the schedule when returning from Away and default it to off to return to the previous behavior.
—
Reply to this email directly, view it on GitHubhttps://github.com/jeffschubert/homebridge-daikin-oneplus/issues/27#issuecomment-1296050886, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQIXHRPFXIAL6JPAOY4G2PTWFXEONANCNFSM6AAAAAARRRLA4I.
You are receiving this because you authored the thread.Message ID: @.***>

Thanks again for bringing this to my attention. I've published 3.1.1 which adds a new setting to optionally enable the schedule after returning from away. It reverts the default behavior to pre-3.1.0 and doesn't enable the schedule in that case unless the setting is also enabled.

Thanks for the quick turn around. I just put 3.1.1 in and it works fine. I see the switch, but I’m not using it. Thanks for the quick work!
Cheers,
Brian
On Oct 29, 2022, at 21:19, jeffschubert @.***> wrote:
Thanks again for bringing this to my attention. I've published 3.1.1 which adds a new setting to optionally enable the schedule after returning from away. It reverts the default behavior to pre-3.1.0 and doesn't enable the schedule in that case unless the setting is also enabled.
—
Reply to this email directly, view it on GitHubhttps://github.com/jeffschubert/homebridge-daikin-oneplus/issues/27#issuecomment-1296068141, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQIXHRN6JK6QTFABUKBL5YLWFXLLPANCNFSM6AAAAAARRRLA4I.
You are receiving this because you authored the thread.Message ID: @.***>


Only globalization-invariant mode is supported in the WorkerService

An attempt to get CultureInfo with System.Globalization.CultureInfo.GetCultureInfo(String name)
throws exception "Only the invariant culture is supported in globalization-invariant mode" in the WorkerService (net 6.0)

The issue is fixed by changing
module.onRuntimeInitialized = () => MONO.mono_wasm_setenv('DOTNET_SYSTEM_GLOBALIZATION_INVARIANT', '1');
with the
module.onRuntimeInitialized = () => {
MONO.mono_wasm_setenv('DOTNET_SYSTEM_GLOBALIZATION_INVARIANT', '1');
MONO.mono_wasm_setenv('DOTNET_SYSTEM_GLOBALIZATION_PREDEFINED_CULTURES_ONLY', '0');
};
in the blazorWorker.js.
What's the reason of using hard-coded DOTNET_SYSTEM_GLOBALIZATION_INVARIANT = 1 in this place?
See also, Culture creation and case mapping in globalization-invariant mode at the MS docs

Hello! Thank you for your feedback.

What's the reason of using hard-coded DOTNET_SYSTEM_GLOBALIZATION_INVARIANT = 1 in this place?

The fact that it's hardcoded was overlooked when migrating these lines from the net6.0 Mono Platform:
https://github.com/dotnet/aspnetcore/blob/d9521accdbe8d463544337c3e9069e5ee9596a69/src/Components/Web.JS/src/Platform/Mono/MonoPlatform.ts#L288-L290
I started out replicating the resourceLoader but it turned out to be very complicated so I kind of dropped it but this line remained. So I agree, this is a problem, the line isn't really supposed to e there.
Your suggestion is that I add DOTNET_SYSTEM_GLOBALIZATION_PREDEFINED_CULTURES_ONLY=false, OK so that's an option I guess. But if I choose between adding code and removing, I sure would go for removal of the line
https://github.com/Tewr/BlazorWorker/blob/fa076087a3c5880429c7fb28aab7db15eba69709/src/BlazorWorker/BlazorWorker.js#L95-L96
What do you think?

I absolutely agree, it’s better if there are no specific reasons for using it. I will check in my project too and provide the feedback

Unfortunately, it's not worked without DOTNET_SYSTEM_GLOBALIZATION_INVARIANT = 1 in my case,
error at the initialization.

I have decided to parametrize the environment variables, so it can work for you with a config similar to the one you provided. As I'm hesitant to provide a non-standard value for the DOTNET_SYSTEM_GLOBALIZATION_PREDEFINED_CULTURES_ONLY value.


 Fixes issue #1505.

Please refer to the issue #1505 for more information about the root cause and proposed solution.
Testing Done:
OK: 46 passed
--- PASS: Test (1830.20s)
PASS
ok  	github.com/vmware/docker-volume-vsphere/tests/e2e	1830.211s

I'm holding on this PR because of the CI failure: https://ci.vmware.run/vmware/docker-volume-vsphere/1220
In CI there are two different setups. The same test (TestFailoverAcrossSwarmNodes) passed during 1st run, but failed during 2nd run.
Need to discuss with @shuklanirdesh82 to figure out the difference between those 2 CI setups.

@shaominchen No, that's not correct. This test fails on both the setups - sometimes on 6.0 and other times on 6.5 as well.
Failed run on 6.5 esx build: https://ci.vmware.run/vmware/docker-volume-vsphere/1224

@ashahi1 So far the test passed 100% in my local run on ESX 6.5, and failed 100% on CI ESX 6.0. To debug this issue, I'd suggest to use ESX 6.0 and enable TRACE logging. That will help us to figure out the root cause more easily.

@shaominchen I ran locally with 6.0 and test passed. And since test failed on CI even with 6.5 build, so test failure has nothing to do with esx version. Looks like we need to revisit the test steps here.
Failed CI run with 6.5 esx build: https://ci.vmware.run/vmware/docker-volume-vsphere/1224

@ashahi1 As you have analyzed, it may not be related to esx versions. So please go ahead to debug the issue further. You'll need to enable TRACE logging to make debugging easier.

While trying to debug this issues as to why this test only fails on CI, we managed to found bug #1621.
After Govindan fixed that bug in PR #1626, last three runs on CI are green.


[multistage] Add Support for Not-In Operator

At present the following query doesn't work:
SELECT
  teamID
FROM
  baseballStats
WHERE
  teamID NOT IN (
    SELECT
      teamID
    FROM
      baseballStats
    WHERE
      hits > 10
  )

This gets converted to a left-join which is correct. However there a couple of issues:

The FilterOperand doesn't recognize the "IS NOT TRUE" function.
Projection for the table-scan is not pushed down, so the join ends up pulling in data for all the columns.

re: 2, it also hits a bug where the mailbox send operator receives a block which has 1 less column (teamID0 column) than expected.
This query can also benefit from colocated joins.
cc: @walterddr

CC @agavra for the 1 less column - i believe this has to do with how the current pinot-broker reducers expects vs. how calcite expects. thus pinot-server instance response operator returns something not compatible.


Macros for matching regex

It would be great if we could do stuff like:
handle_message ~r/^!(?<cmd>[^\w]+)/, matches, sender, chat do
  %{"cmd" => command} = matches
  reply(chat, "Cool #{command} command, #{sender}")
end

i don't think i will do this


shallow doesn't work properly with redux connect(store)

related to this issue https://github.com/reactjs/redux/issues/1534, https://github.com/airbnb/enzyme/issues/183
Not sure is this correct place to post, but i encounter a bug when using enzyme with redux
Could not find "store" in either the context or props .... Either wrap the root component in a <Provider>, or explicitly pass "store"
Here is my test
describe("(Component) CoreLayout", () => {
  let _wrapper, _props

  beforeEach(() => {
    _props = {
      children: <anchor/>
    }
    _wrapper = shallow(<CoreLayout {..._props}/>, { context: { store } })
  })

  it('Should render Header', () => {
    console.log(_wrapper.html());
    expect(_wrapper.find('Header')).to.have.length(1)
  })

  it('Should render Footer', () => {
    expect(_wrapper.find('Footer')).to.have.length(1)
  })
})

Header.js
export class Header extends Component {
  static contextTypes = {
    router: PropTypes.object
  }
  render() {
    const { currentUser } = this.props;

    return (
      <div>
        {currentUser.fullName}
      </div>
    )
  }
}

function mapStateToProps(state) {
  return {
    currentUser: state.currentUser
  }
}

I also created my example repo
https://github.com/MQuy/redux-store-enzyme

I am using redux-mock-store for my unit tests.
import configureStore from 'redux-mock-store';
const mockStore = configureStore();
const dispatch = sinon.spy();

const wrapper = shallow(
    <Test dispatch={dispatch} store={mockStore({ runtime: {} })}
      testData={fakeTestData}
    />
  );

Does this work for you?

@5punk I use redux-mock-store, too 😄

Not sure it's correct or not, but I think it's related to our problem
https://github.com/facebook/react/blob/master/src/test/ReactTestUtils.js#L434
The context is passed to that function but, it doesn't work

This issue is really painful as we need to use react-addons for testing in mentioned scenario when child component is connected. In my opinion Unit Test should not pass store via context - we just to test component as a atomic unit.

#472

You can also use dive(). Thus _wrapper.dive().find('Footer')

What we want to test is the actual component itself, so you need to export that and import as
{myComponent} on yourComponent.test

@Zzamanta yes, .dive() lets you do that without having to export/import the inner component.

@ljharb, managed to my connected, HOC'd component to test like so:
            <Provider store={store}>
                <SignIn {...props} />
            </Provider>
    ).dive({ context: { store } }).dive();```

But componentDidMount() is not triggered. Using **mount** does trigger componentDidMount() though. Any idea why?

Do you have disableLifecycleMethods set anywhere, like perhaps in your configure call?

Do you have disableLifecycleMethods set anywhere, like perhaps in your configure call?

No. It seems I didn't dive deep enough.  was wrapping , which was wrapped by my own HOC, which was wrapped by connect.
I found that componendDidMount was in fact triggered when I used
wrapper = shallow(
            <Provider store={store}><SignIn {...props} /></Provider>
).dive({ context: { store } }).dive()**.dive()**;

that's an extra .dive() at the end. I think mount will actually be a better choice as it it properly re-rendering when props are updated in componentDidMount during the test. Thanks @ljharb!

What we want to test is the actual component itself, so you need to export that and import as
{myComponent} on yourComponent.test

This was the easiest solution! Thanks


Space around zones for custom FancyZones templates

Disabling the "space around zones" setting does not work for custom templates. Even when editing the "Selected layout" with Space around zone disabled, the duplicated template has it enabled again.

After switching to a default template, and then back to the custom layout I see the space was removed in the custom layout too.

I'm also experiencing this issue. I followed the steps that @rzippo mentioned and able to correct the problem. This definitely seems like unintentional and undesired behavior. Is there any plan to work on this in the near future?

I seem to be having the opposite problem as everyone else... I've made a new Custom template but I can't figure out how to apply space around the zones without manually resizing each new zone. Should the "show space around zones" option apply to new custom templates?
v0.18.1

Adding reference https://github.com/microsoft/PowerToys/issues/1032

Tracked in https://github.com/microsoft/PowerToys/issues/6611

This have been fixed.


Allow building client with custom reqwest::ClientBuilder

I would like to be able to configure the underlying Reqwest instance, which is not possible in the current setup.
This PR adds the new_client_with_reqwest function to allow passing in a reqwest::ClientBuilder instance which has been customised.

@JamesGuthrie Ho, this PR is clean and nicely done. Let me think more if no downside, but looks very good.

@jeremychone Thanks! The only reservation I have is that it might make sense to use a builder instead of multiple different functions.

@JamesGuthrie Merged it. Since this library revolves around Reqwest and Reqwest has its own builder, I think it's fine.


Support for multiple paths in git_commit action

Fixes #660 :+1:

This looks good, thanks for your contribution :+1:


allow-unsafe doesn't properly work with included files

Environment Versions

Ubuntu 18.04
Python version: Python 3.7.5
pip version:  20.1
pip-tools version: 5.1.1

Steps to replicate

Create two test files:

# test.in
-c bar.lock
pylint~=2.4

# bar.lock
click==7.1.2
pip-tools==5.1.1
six==1.14.0
pip==20.1
setuptools==46.1.3

run pip-compile test.in --no-annotate --no-header --allow-unsafe

Expected result
Output should contain all of the locked requirements from bar.lock.
Actual result
Output does not contain requirements from bar.lock
If the contents of bar.lock are inserted into test.in - or even if it's just pip-tools, pip and setuptools w/o their transitive dependencies, --allow-unsafe works properly.

Hello @leos,
Thanks for the issue! It not related to --allow-unsafe options. I'm afraid this is how pip-tools (and pip by the way) works with constraint files. Let me explain. Suppose you have the following constraint file:
# constraints.txt
six==1.10.0
pytz==2019.3

and requirements.in file:
-c constraints.txt
six
click

The result of pip-compile --no-header would be:
six==1.10.0
click==7.1.2

What's happened:

six resolved to 1.10.0 version because it was constrained in constraints.txt, despite on the latest version is 1.14.0.
click resolved to the latest version 7.1.2 since there is no constraints for it.
pytz didn't get into the output since it's a constraint, not a direct dependency.

pip-tools doesn't compile constraints from constraint files to the output, but respects given versions for direct dependencies.
Also, you might find useful this section where described the main use-case with constraint files.

Ah, got it, thanks for the explanation and the prompt response.
That makes total sense. I treated constraints as an include and that's not correct.

Happy to help. Don't hesitate to reach out if you have any other issues. Thanks!


Data races

There's a few data races on the request object in proxy.go, going to tackle removing those and refactoring that file. Assign to me please @jacobheath
nati:~/golang/src/github.com/nccgroup/tracy/proxy$ go test -race -timeout 30s github.com/nccgroup/tracy/proxy -run ^TestFullProxy$
==================
WARNING: DATA RACE
Write at 0x00c4204f4790 by goroutine 83:
  github.com/nccgroup/tracy/proxy.handleConnection()
      /Users/nati/golang/src/github.com/nccgroup/tracy/proxy/proxy.go:157 +0x1447

Previous read at 0x00c4204f4790 by goroutine 20:
  github.com/nccgroup/tracy/proxy.handleConnection.func1()
      /Users/nati/golang/src/github.com/nccgroup/tracy/proxy/proxy.go:122 +0x53

Goroutine 83 (running) created at:
  github.com/nccgroup/tracy/proxy.(*Proxy).Accept()
      /Users/nati/golang/src/github.com/nccgroup/tracy/proxy/proxy.go:35 +0x128

Goroutine 20 (running) created at:
  github.com/nccgroup/tracy/proxy.handleConnection()
      /Users/nati/golang/src/github.com/nccgroup/tracy/proxy/proxy.go:121 +0x13ea
==================
--- FAIL: TestFullProxy (0.00s)
	testing.go:730: race detected during execution of test
FAIL
FAIL	github.com/nccgroup/tracy/proxy	0.087s

nati:~/golang/src/github.com/nccgroup/tracy$ git checkout nati/waitgroup-and-mutexes
Switched to branch 'nati/waitgroup-and-mutexes'
nati:~/golang/src/github.com/nccgroup/tracy$ /usr/local/go/bin/go test -race -benchmem -run=^$ github.com/nccgroup/tracy/proxy -bench ^BenchmarkFullProxy$
goos: darwin
goarch: amd64
pkg: github.com/nccgroup/tracy/proxy
BenchmarkFullProxy-4<PHONE_NUMBER> ns/op          481362 B/op       5700 allocs/op
PASS
ok      github.com/nccgroup/tracy/proxy 4.880s

🎉

Little slower with the locking but once I do some memory optimizations it'll be good.

This seems to be fixed now:
% go test -race -timeout 30s github.com/nccgroup/tracy/proxy -run ^TestFullProxy$
ok  	github.com/nccgroup/tracy/proxy	2.034s


Allow decisions on synonyms

EditorialDecisions have a subject id + name and are currently considered to be referring to Taxon.id only. There are many decisions though that have to be applied to synonyms as well.
Options to consider:

link all decisions to the name, not taxon. Some names are used for both a taxon and a synonym or for multiple pro parte synonyms, so that does not seem to be an ideal solution to allow for fine grained decisions.
manage special decisions just for synonyms similar in structure as for taxa
similar to above but extend decisions with a isSynonym flag
collapse synonyms and taxa into a good old NameUsage just like in ChecklistBank with a single unique id. That simplifies a lot of SQL, especially for populating ElasticSearch where we expose NameUsages anyways

Not that the ID on a Synonym currently is not required and many sources do not provide that.
In order to link to them we will need to create artificial keys and make synonym.id mandatory

See also https://github.com/Sp2000/coldp/issues/2 for a related discussion on ColDP

we are collapsing synonyms and taxa into usages, see #332


Fix #262 -- autolaunch the simulator.

I wish we used xcrun simctl boot instead of looking for the binary directly. Seems more resilient to weird Xcode installs

You would also not have to wait an arbitrary amount of time for the device to boot

This looks good, but probably coudl go another round.  regardless lgtm.

@chinmaygarde: I was looking through the simctl docs and it wasn't immediately obvious to me that there was a set of simctl commands that would reliably give the user something sensible as Apple releases new simulators.  Did you have a particular plan in mind?  (xcrun simctl boot requires you to specify a particular simulator.)
Also, launching a particular simulator causes that simulator to be launched again the next time by default, so if we choose a preferred simulator, that may violate the principle of least surprise.  I agree though that if their default simulator is not one that Sky is compatible with (e.g., they have been testing very old versions of iOS), then the experience may be confusing.  Possibly we could launch the default simulator and then verify that it didn't launch a simulator that is incompatible with Sky?


an example to generate a gif of the spawn zone automatically

using https://github.com/puppeteer/puppeteer
https://threejs.org/examples/#webgl_worker_offscreencanvas
https://github.com/mrdoob/three.js/blob/19beb8ecc83b8f52de1e00dcfca59fc2ce55078f/test/e2e/puppeteer.js

const puppeteer = require('puppeteer');

(async () => {
  const browser = await puppeteer.launch();
  const page = await browser.newPage();
  await page.goto('https://3000-e12d77a9-83d7-4acd-9b41-67e26a4ded5c.ws-eu01.gitpod.io/');
  await new Promise(resolve => setTimeout(resolve, 60000))
  await page.screenshot({path: 'example.png'});

  await browser.close();
})();

Produces

best way to auto zoom is probably to directly communicate with prismarine-viewer stuff

yeah the page can setup the camera easely. We can even compute the best camera position to fit the whole world.

let's call this done
screencast would be even better but I looked and there's nothing easy


add e2e test for ingress gateway cert

So right now we tell users to set an ingressbackend.Source, such as "foo.bar.cluster.local", however with the new TrustDomain code, service Identities no longer have the trust domain in it, so we append it when building the Envoy configs. There was a bug where this was getting appended to the ingressbackend.Source, which already has it, and where the ingressGateway certificate would not get that trust domain appended. There's 3 options to fix this:

Don't append the trust domain to either ingressbackend.Source, nor ingressgateway certificate SAN.
Append the trust domain to both. This is counter intuitive and "feels wrong", in that the given cert will have a different SAN than the user specified.
Do option 2, but change the field names to indicate that it is a SAN prefix that is being supplied.

This PR chooses option #1, but I'm open to alternatives.
This also adds additional E2E tests which should catch this issue, and other potential gateway cert issues

Codecov Report

Merging #4883 (460a4f1) into main (aa1abf1) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4883      +/-   ##
==========================================
- Coverage   68.71%   68.70%   -0.01%
==========================================
  Files         220      220
  Lines       15907    15914       +7
==========================================
+ Hits        10930    10934       +4
- Misses       4925     4928       +3
  Partials       52       52

Flag
Coverage Δ

unittests
68.70% <ø> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/messaging/workqueue.go
89.28% <0.00%> (-10.72%)
:arrow_down:

pkg/certificate/fake_manager.go
68.18% <0.00%> (+0.48%)
:arrow_up:

cmd/osm-bootstrap/osm-bootstrap.go
46.25% <0.00%> (+0.53%)
:arrow_up:

cmd/osm-controller/osm-controller.go
16.46% <0.00%> (+1.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa1abf1...460a4f1. Read the comment docs.

Could I request adding a test or two that actually installs Contour? We could've caught #4898 earlier if we had one

Could I request adding a test or two that actually installs Contour? We could've caught #4898 earlier if we had one

Let's get the fix in for that first, as I'd rather not block this PR on that

Is the expectation that the user will just add the trust domain when specifying the SAN?


Python package should use dashes in name

Python packaging naming conventions require dashes instead of underscores in package names. So while the Slack documentation asks the user to install slack_api, that's not the actual package name on PyPI or in pip or elsewhere in the Python packaging systems. This can lead to confusion. Please change the name of the package from slack_api to slack-api to avoid this confusion going forward.

Hi @kislyuk, thanks for sharing the suggestion to improve our documentation!
The slack_sdk package supports both slack_sdk and slack-sdk on PyPI and in requirements.txt. The default PyPI install instructions also suggest the standard slack-sdk convention.
I think it's a fair suggestion to update our documentation to use the slack-sdk naming convention. But first, I'd like to learn whether there was a reason why the slack_sdk usage in our documentation.

Happy Friday @kislyuk!
I took some time to learn about the history of the naming convention decision and wanted to share it with you.
The original proposal was to use slacksdk or slack-sdk. We opened the discussion across the team and included the company-wide Python community channel. The agreement was that slack-sdk is more readable than slacksdk. For some context, slacksdk paid homage to the original slackclient package.
The concern was that it would be confusing to install slack-sdk and import slack_sdk.
Since pip handles underscores _ and hypens - transparently, the suggestion was to use slack_sdk. This would still allow experienced Python developers to intuitively install slack-sdk with muscle memory. It would also allow the install and import statements to match, which can avoid some RPM build nightmares that developers shared.
Overall, the general feeling was that everyone preferred - and it's also preferred by the PEP-8 and PyPI. However, choosing the _ would still allow for the - install experience while keeping the import/documentation more consistent.
Hope that helps a little bit! I think everyone would still be interested in hearing your thoughts. One day in the future, we'll have to make this decision all over again 😅

Thanks for following up on this @mwbrooks. I don't think this issue is resolved since the package still does not follow Python package naming conventions. Here is the relevant excerpt from PEP 8, the original Python style guide (https://www.python.org/dev/peps/pep-0008/):

Modules should have short, all-lowercase names. Underscores can be used in the module name if it improves readability. Python packages should also have short, all-lowercase names, although the use of underscores is discouraged.

And to address this point:

The concern was that it would be confusing to install slack-sdk and import slack_sdk.

This is an unfounded concern, since Python packages in general follow this convention and Python developers are used to it. It's the presence of the underscore in the slack SDK package name that is surprising and confusing, not the other way around.

@kislyuk Thanks for writing in. I personally share your view, but as the result of the internal discussion when this project started, we (the Slack team) decided to go with underscore because it technically works in both way (= slack-sdk and slack_sdk). Thus, we are not planning to change this at least in the short term. Thanks again for sharing your thoughts here.


Insertion of nodes by more 2 threads breaks config tree

See application 'kernel.cpp'. If the number of threads is increased weird stuff happens.

The race condition was in the for loop counter. Now we have two counters to avoid concurrency.


[WIP] refactor: read rawdata from json file instead of js import

Refactored rawData input to read from a JSON file instead of a .JS file import. This is an important stepping stone in reducing load on the system based on targeted game modules to import.
Requires testing via a push to the Github Page, to prove end-to-end.

Results: end-to-end proven
Analysis: perhaps it would be helpful to reduce the load of the system by only calling for the rawdata.json struct once per necessary game. Should the json file be split into components for each individual game? Let's try it.

Results:

[x] JSON files split into component files for each game
[x] dynamic load successful

GTM


exposed_ports not available in v1.4.3 despite it being in the docs

When using the following BUILD file
load("@container_structure_test//:defs.bzl", "container_structure_test")
load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library")
load("@rules_oci//oci:defs.bzl", "oci_image", "oci_tarball")
load("@rules_pkg//:pkg.bzl", "pkg_tar")

go_library(
    name = "api-server_lib",
    srcs = [
        "main.go",
        "wire_gen.go",
    ],
    importpath = "github.com/ride-app/driver-service/cmd/api-server",
    visibility = ["//visibility:private"],
    deps = [
        "//api/ride/driver/v1alpha1/v1alpha1connect",
        "//config",
        "//internal/api-handlers",
        "//internal/api-handlers/interceptors",
        "//internal/utils/logger",
        "//pkg/repositories/driver",
        "//pkg/repositories/vehicle",
        "//pkg/repositories/wallet",
        "//third-party",
        "@com_connectrpc_connect//:connect",
        "@org_golang_x_net//http2",
        "@org_golang_x_net//http2/h2c",
    ],
)

go_binary(
    name = "api-server",
    embed = [":api-server_lib"],
    visibility = ["//visibility:public"],
)

pkg_tar(
    name = "tar_layer",
    srcs = [":api-server"],
)

oci_image(
    name = "image",
    base = "@distroless",
    entrypoint = ["/api-server"],
    tars = [":tar_layer"],
    exposed_ports = ["50051"],
)

oci_tarball(
    name = "container",
    image = ":image",
    repo_tags = ["api-server:latest"],
)

container_structure_test(
    name = "container_structure_test",
    configs = ["container_structure_test.yaml"],
    image = ":image",
)

it throws the following error
bazel run //cmd/api-server:container_structure_test                                                               ✹ ✭
ERROR: /Users/debkanchan/Code/ride/backend/driver-service/cmd/api-server/BUILD.bazel:41:10: //cmd/api-server:image: no such attribute 'exposed_ports' in 'oci_image' rule
WARNING: Target pattern parsing failed.
ERROR: Skipping '//cmd/api-server:container_structure_test': Error evaluating '//cmd/api-server:container_structure_test': error loading package 'cmd/api-server': Package 'cmd/api-server' contains errors
ERROR: Error evaluating '//cmd/api-server:container_structure_test': error loading package 'cmd/api-server': Package 'cmd/api-server' contains errors
INFO: Elapsed time: 0.345s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

Docs are generated at head so if you wanna see the docs for for a specific release please checkout the repo at the tag for the release.
Closing this as there’s no action needed.

@thesayyn Is there a timeline when the feature will drop?


*: move TestRestartOperator to e2eslow/disruptive_test.go

As part of https://github.com/coreos/etcd-operator/pull/1139
First commit from https://github.com/coreos/etcd-operator/pull/1149

lgtm


"n" argument Inserted in press function

You can define how many time the function press will simulate key stroke ("n" times). 1 (one) is the "n" default value.

Changed the name of the keyword argument, but accepted. Thanks!


 The test scripts
    are hosted under script/test_in_openshift. The directory structure,
    as follows:

✔ /tmp/kompose [:24e53f2|…6]
08:28 $ git branch
* (HEAD detached at anush/openshift_up_down_test)
  master
✔ /tmp/kompose [:24e53f2|…6]
08:28 $

kompose generates wrong buildconfig for openshift in git repo that is detached
$ kompose convert -f examples/buildconfig/docker-compose.yml --provider openshift --stdout | grep git
INFO Buildconfig using https://github.com/kubernetes-incubator/kompose/.git::HEAD as source.
      git:
        uri: https://github.com/kubernetes-incubator/kompose/.git

It fails because the git url is wrong https://github.com/kubernetes-incubator/kompose/.git

..
On Apr 20, 2017 2:08 PM, "Suraj Deshmukh"<EMAIL_ADDRESS>wrote:

It fails because the git url is wrong https://github.com/kubernetes-
incubator/kompose/.git
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-incubator/kompose/issues/561#issuecomment-295635482,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AS5iy7FO7SUE6KEF5zjmt_W9KWx2xnrgks5rxxl5gaJpZM4NCtLw
.

@surajssd Picking this up.

even if https://github.com/kubernetes-incubator/kompose/pull/577 is merged this issue still remains

/remove-lifecycle rotten


⚠ Bofrost.lu has degraded performance

In 746b149, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1077 ms

Resolved: Bofrost.lu performance has improved in b4f9f6b.


Databases widget improvement

use table to show more information of the database: name, size, status, last backup date
context menu contribution for the items
Full page experience

[ ] 1. extend the ListDatabasesRequest related interfaces in azdata.d.ts in ADS repo

[ ] 2. update the dataprotocol-client repo to handle the extended ListDatabaseRequest and response properly - depends on step NO.1

[ ] 3. update SqlToolsService to implement extended ListDatabasesRequest handler
implement full size

[ ] 4. widget container, so that the databases widget can show without the title and border.

[ ] 5. update ADS repo to implement the UI changes. depends on all steps above


Fix in-app gallery resetting to the first image on orientation change

Changing the orientation in the in-app gallery currently causes the entire gallery activity to reset
This pull request would help resolve the issue described at #370

Activity is recreated after almost all configuration changes, not just after rotation. Proper solution for this is to use a ViewModel or to save activity state in onSaveInstanceState().
The proposed solution doesn't work in my testing even for orientation changes, not clear why.

Special handling of lastCapturedItem should be skipped when lastViewedMediaPosition is not 0, otherwise lastCapturedItem will be loaded unnecessarily before item at lastViewedMediaPosition.

Special handling of lastCapturedItem should be skipped when lastViewedMediaPosition is not 0, otherwise decoding of item at lastViewedMediaPosition will be delayed until decoding of lastCapturedItem is complete.

Yes, loading the first item would be un-necessary in this case. Thanks a lot for reviewing this PR!

Item position is not guaranteed to be stable after the item list is re-fetched, missed that initially. A stable item identifier should be saved in onSaveInstanceState, not its position.


New type of card(?) for overview and landing pages

Which package is this issue related to?
ffe-cards and ffe-cards-react, I suppose
Describe your issue (screenshots welcome!)
We have a new type of card (or whatever it is to be named) which is already in use on banking overview beta, and is soon to come to various banking landing pages.
I suppose insurance will use this as well, but I don't know.
There are two types of cards.
The bigger and badder one:

The leaner and meaner one:

I suppose the latter could be viewed as a condensed version of the first, but they clearly have distinct uses. Condensing here is not something that would be done for smaller size screens or anything. They should both be responsive in each their way.
Is this going to be categorized as a card?
If so, what should the card name be?
If not, what is it really?
While these "cards" are still a design WIP, they're already implemented in one place, and will surely be implemented in many more. I say surely, because this is now a well processed idea from the overview team (I believe).
Thus it makes sense to add them here, so we can all work together on making the best solution, rather than implementing many different versions before we try to merge them all together.

Are they going to be used around grids and is (e.g.) the text then going to be expected to line up with other grid column content? Same question for the lean one re the condensed grid.
To me this feels like it's not really much more than a border-shadow around a box, especially if we could use the grid for laying out the internal parts of it (in which case it is tempting to just suggest adding support for border-shadow on grid-cols).
If it can't be implemented with grid-elements I'd suggest making the implementation as flexible as possible, maybe just a border around a box with an icon on the left and whatever the consumer wants to put there on the right.

For now my idea is to put these as components inside grid columns.
I'm not sure how specific or flexible we want these to be.
I think this is something we should have design involved in.
I've been working on some code, and so far it's not as flexible as you describe it. This is because I believe there are certain design limitations/requirements to these cards that needs to be taken into account.
The component is very similar to the ProductCard. This is because we need to control the content a bit, due to said design considerations.
However, I've tried to keep the css simple. So far it's 89 lines, which is ways better than our ffe-link-card which is 237 lines (not counting comments).
I'll put up a PR tomorrow, so you can see for yourself.
I'm excited to see if we can find a better way to make this styling and component more flexible without allowing too much stray from the intended design.

Hmm about using the grid. The grid is using padding to create space, but we want space between the cards, so simply adding box shadow to the grid won't work.

For the record, and in hindsight, I think putting ffe-cards in as a FFE component was a mistake. After receiving different specs from different designers here over the last 4-5 years it's fairly clear to me that they are treating those cards as just a border they can put stuff into and I usually end up implementing it by just literally sticking a border around a div and calling it a day.
That's why I am wary about adding more product cards :) I've no doubt the implementation can be done simple, I'm just not sure how easy it's going to be to re-use later. If we are going to add it then I think at least we should have design on board with some clearly defined rules about what can go into these boxes and how it should look. That's my opinion on it anyway.

I totally see your points here. A general purpose card for putting all sorts of things into definately needs to be made very simple and general purpose to keep it manageable here. The cards we have today has failed on this point.
I do, however, have the impression these new cards are supposed to have a specific design, with less freedom for each team.
If this is the case, I think it's an advantage to make them less general purpose here, to help ensure they look the same for everyone, with minimal effort from each team.
If it's not the case, and these cards should allow for major differences between teams, my current implementation would not work. Or like you say, maybe it shouldn't be in the design system at all.
I'll get a PR up today, so we can have a look and share some thoughts on the implementation.


cmd/vet: shadow false positive variable/type declaration in package block

What version of Go are you using (go version)?
go version go1.7.3 darwin/amd64
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/meomap/testlinter"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/6f/tq_z_9xs71vg9wlv5yg8g_lm0000gn/T/go-build230941075=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
What did you do?
I run go tool vet --shadow on top repository of 3 packages, each has a main.go file:
// `a/main.go`
package main

var foo error

func main() {
}

// `b/main.go`
package main

import (
        "errors"
        "fmt"
)

func main() {
        foo := errors.New("meomeo")
        fmt.Println(foo)
}

// `c/main.go`
package main

import "errors"

type foo error

func newFoo(msg string) foo {
        return foo(errors.New(msg))
}

func main() {
}

vet command
$ go tool vet --shadow a/main.go b/main.go c/main.go

What did you expect to see?
no vet error, same output as
$ go tool vet --shadow .

What did you see instead?
b/main.go:9: declaration of "foo" shadows declaration at a/main.go:3

but when I run same vet on a/main.go and b/main.go only, no vet error
$ go tool vet --shadow a/main.go b/main.go

or change order of arguments input, no vet error
$ go tool vet --shadow c/main.go b/main.go a/main.go

Note that go help packages says:
As a special case, if the package list is a list of .go files from a
single directory, the command is applied to a single synthesized
package made up of exactly those files, ignoring any build constraints
in those files and ignoring any other files in the directory.

This behaviour is still confusing and perhaps a bug, but I would also say that you are not using the tool properly by specifying go files from different packages. That merges them into a single package. Have you tried ./...?

I just realised that it says from a single directory. I wonder if that means that it treats all the files as if they were from the same directory, or if it does a separate run for each different directory. I'm betting on the former.

There is no expectation that any of the go tools will work properly when presented with a single directory containing multiple packages.

@mvdan actually go vet can run with . only. Anyway thanks for sharing that package usage note

@meomap like any other go foo tool, go vet ./... works just fine here. Make sure your GOPATH is properly set up and you're in it.


Files disappear when scrolling on left sidebar sometimes

VSCode Version: 1.14.0
OS Version: 10.12.5
Steps to Reproduce:
No very sure how this happens. It happens frequently but not every time when I (more frequently after open a directory and) scroll up or down, like in the gif.

Reproduces without extensions: Yes

@lijunray is this reproducible? Is there any output in the developer console?
@joaomoreno looks like a tree bug!

Wow. I was pretty sure this was fixed. There must be another issue.

@bpasero @joaomoreno Sorry I don't know how to reproduce this. Like I said, it happened most frequently(not every time but almost) when I opened a directory on Explore. This has been happening since several days ago. Yesterday I restarted VSCode for the first time in a long term and it didn't happen again. But I'm pretty sure it also happened before last time I restarted(or update) VSCode. It may has something to do with the time I've been using it?

Could this be #32510?

@joaomoreno Yes, I guess my problem is the same as #32510, most likely, though I don't remember how to reproduce my problem, but I reproduced this one and found it has exactly the same behavior as mine.

Duplicate of #32510


how soon 👀

Thank you for your interest in our work. The code has been released. Please take a look. Hope our code is helpful for you.


Use JNI instead of shell on android.

Using shell and calling am start ... isn't allowed on newer android versions as far as i can tell. I think JNI should be used to start the activity instead.

Thanks @VZout for your first contribution here. While I check this, can you point me to any link that mentions am start not being allowed anymore?

Getting the error java.lang.SecurityException: Permission Denial: package=com.android.shell does not belong to uid=10242 and I don't see how I can let Shell belong to my package 🙂 So I assume something changed on newer (non root) android versions that denies this.

My apologies for a very delayed review of this. Thankfully, this PR pushed me to finally have an integration test for android, which is now included. This will go out in the next release of the crate, which I've time boxed to a max of a week from now, after I've had a chance to make the Android tests run on Github Runners.


Mapping from one existing object to another and Mapster is returning generated and unwanted values

I am performing a tech stack spike for our service infrastructure. We're taking a look at our mapping right now, which is currently AutoMapper. Pretty standard situation.
The benchmark comparisons and high level syntax comparisons are promising. However, the documentation for this library is presenting strong arguments against making the switch. I have to recommend that you populate the your public members with documentation so the IDE can tell devs what it is that they're looking at. And it would compliment the existing documentation on this site to probably reduce your support requests significantly.
For example, I suspect that the answer to my question will lie in TypeAdapterConfigSettings class, but when I look at its members to see what options I have, there is no elaboration. Placing your cursor over each public member and hitting "/" three times as a matter of due diligence goes a long way toward adoptability.
Here's what I'm dealing with.
public class UserAccount : ShardableDocument
{
    public string? Email { get; set; }
    public string? GivenName { get; set; }
    public string? FamilyName { get; set; }
    public DateTime Created { get; set; }
    public DateTime Modified { get; set; }
}

The ShardableDocument base class has an Id field.
I want to be able to update users with my CRUD operations, so we have this request type
public class UpdateUser
{
    public string? Id { get; set; }
    public string? Email { get; set; }
    public string? GivenName { get; set; }
    public string? FamilyName { get; set; }
}

This is what I'm passing to my ServiceMapper
var config = new TypeAdapterConfig();
        config.ForType<UpdateUser, UserAccount>()
            .Map(dest => dest.Modified, src => DateTime.UtcNow)
            .IgnoreNullValues(true);

And in my User processor, there's a line that looks like this.
_mapper.Map(updateUser, userAccount);
It is mapping the updateUser request from the client to the userAccount that was found by a database get by ID call.
Intuitively, I would expect that any properties of the same name would copy from the source object to the destination object unless the source object does not have that member, or the member is null. IN WHICH CASE, the destination would be left alone. Created would not be overwritten, it already had a date. Id would not be overwritten, it already had an Id. Or, at least in this case, it would receive the one from updateUser which has a matching Id.
It is not being left alone. Created is being set to DateTime.UtcNow and Id is being set to a random GUID. Is this behavior intended?
Edit: For additional info, if I change the mapping to this
var config = new TypeAdapterConfig();
        config.ForType<UpdateUser, UserAccount>()
            .Map(dest => dest.Email, source => source.Email)
            .Map(dest => dest.FamilyName, source => source.FamilyName)
            .Map(dest => dest.GivenName, source => source.GivenName)
            .Map(dest => dest.Modified, src => DateTime.UtcNow)
            .Ignore(dest => dest.Created)
            .Ignore(dest => dest.Id!)
            .IgnoreNullValues(true);

I get the expected result. So I know that my TypeAdapterConfig is being referenced correctly. I suppose that I just do not see why I have to manually map and ignore this way. Seems to be favoring the sort of logic you would have in generating an object when we are, in fact, not intending to generate a new object.

This was most likely due to a false positive identification of your class as a record.
These classes look exactly as you described in the example
UserAccount, ShardableDocument?
They have only one public constructor without parameters, public UserAccount(), public ShardableDocument()?
After the fix It works like this. Did you expect this behavior?

        /// <summary>
        /// https://github.com/MapsterMapper/Mapster/issues/427
        /// </summary>
        [TestMethod]
        public void UpdateNullable()
        {
            var _source = new UserAccount("123"<EMAIL_ADDRESS>new DateTime(2023, 9, 24));
            var _update = new UpdateUser
            {
                Id = "123",
            };
            var configDate = new TypeAdapterConfig();

            configDate.ForType<UpdateUser, UserAccount>()
                .Map(dest => dest.Modified, src => new DateTime(2025, 9, 24))
                .IgnoreNullValues(true);

            _update.Adapt(_source, configDate);

            var _sourceEmailUpdate = new UserAccount("123"<EMAIL_ADDRESS>new DateTime(2023, 9, 24));
            var _updateEmail = new UpdateUser
            {
                Email =<EMAIL_ADDRESS>            };

            var config = new TypeAdapterConfig();
            config.ForType<UpdateUser, UserAccount>()
                .IgnoreNullValues(true);

            var _resultEmail = _updateEmail.Adapt(_sourceEmailUpdate, config);

            _source.Id.ShouldBe("123");
            _source.Created.ShouldBe(new DateTime(2023, 9, 24));
            _source.Modified.ShouldBe(new DateTime(2025, 9, 24));
            _source.Email.ShouldBe("123@gmail.com");
            _sourceEmailUpdate.Id.ShouldBe("123");
            _sourceEmailUpdate.Created.ShouldBe(new DateTime(2023, 9, 24));
            _sourceEmailUpdate.Modified.ShouldBe(null);
            _sourceEmailUpdate.Email.ShouldBe("245@gmail.com");

        }


useSanctumClient() does not show typescript warnings

Hi, I would like to use client from const client = useSanctumClient() instead of $fetch. The problem is that I am not getting the typescript warnings like I am used to with $fetch. Is this a bug, or can I turn it on somehow? I use visual studio code.
const client = useSanctumClient();

const { data } = await useAsyncData('itemData', () =>
  client(`/item/${id}/data`)
);

Hey @alexandrmucha, what kind of warnings do you expect from this code?
I don't think it is a bug since useSanctumClient returns an instance of $fetch.create(). You can see more details here - Docs.

@alexandrmucha the composable function useSanctumClient returns an instance of $Fetch, which is constructed as fetch.create() inside of the plugin. However, I see that $fetch function is also defined as $Fetch type here - unjs/ofetch but later Nuxt adds customisation on top of it to make this composable exported automatically and to be used in useFetch, useAsyncData, etc.
So, the reason of the difference in your case is client(`/product/${productId}`) returns any as response, while $fetch(`/product/${productId}`) returns unknown. If you want to enable the same warnings, you can use either object or unknown as a type of repsonse
<template>

Product name: {{ data.name }}

Product ID: {{ data.id }}

</template>