Chart tooltip labels

Add labels when showing multiple values in chart tooltips.
Fixes https://github.com/project-koku/koku-ui/issues/657
OCP cost card:

OCP memory card:

OCP on AWS cost card:

OCP historical charts:

Codecov Report

Merging #724 into master will decrease coverage by 0.47%.
The diff coverage is 34.17%.

@@            Coverage Diff             @@
##           master     #724      +/-   ##
==========================================
- Coverage   77.43%   76.95%   -0.48%
==========================================
  Files         224      224
  Lines        3558     3585      +27
  Branches      598      614      +16
==========================================
+ Hits         2755     2759       +4
- Misses        722      741      +19
- Partials       81       85       +4

Impacted Files
Coverage Δ

src/components/charts/trendChart/trendChart.tsx
72.04% <ø> (ø)
:arrow_up:

...rc/components/charts/costChart/costChart.styles.ts
100% <ø> (ø)
:arrow_up:

src/store/ocpDashboard/ocpDashboardWidgets.ts
100% <ø> (ø)
:arrow_up:

...arts/historicalTrendChart/historicalTrendChart.tsx
73.8% <ø> (ø)
:arrow_up:

src/store/ocpDashboard/ocpDashboardCommon.ts
95.65% <ø> (ø)
:arrow_up:

src/pages/ocpDashboard/ocpDashboardWidget.tsx
74.21% <ø> (ø)
:arrow_up:

...store/ocpOnAwsDashboard/ocpOnAwsDashboardCommon.ts
95.65% <ø> (ø)
:arrow_up:

...tore/ocpOnAwsDashboard/ocpOnAwsDashboardWidgets.ts
100% <ø> (ø)
:arrow_up:

src/utils/formatValue.ts
78.57% <100%> (+1.9%)
:arrow_up:

...ages/ocpOnAwsDashboard/ocpOnAwsDashboardWidget.tsx
74.04% <100%> (+0.19%)
:arrow_up:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acc5e67...6805787. Read the comment docs.


InvestorMap - April 2019 release

Checklist for April 2019 release:

[ ] update to latest terriajs, if possible with story https://github.com/TerriaJS/terriajs/pull/3228)- story not available in Apr release

[x] https://github.com/TerriaJS/InvestorMap/issues/247

[x] https://github.com/TerriaJS/InvestorMap/issues/239 - https://github.com/TerriaJS/InvestorMap/pull/253

[x] https://github.com/TerriaJS/InvestorMap/issues/240 - https://github.com/TerriaJS/InvestorMap/pull/253

[x] https://github.com/TerriaJS/InvestorMap/issues/244

[ ] https://github.com/TerriaJS/InvestorMap/issues/252 - moved to next sprint, May release

release done

we might need to re-release because GA services for mining commodities are testing services and they are currently down (since 3rd of May); if the end points change again, we have to build another release


Markers mess when there is more than one map on back - forward.

Minimal demo

Codepen

Current behavior

When there is more than one map and load the first map then go back and load the second one in the second map has markers from the first one.

Expected/desired behavior

Should load only the markers of the open map

This is happening because the map instance is shared between two maps to prevent memory leak.
Please make it sure that two map ids are different to have different map instances

Thanks,
I double check and ids are different.
First map is with id map_0 and the second with map_1
Is it way to force map destroy?
I try to remove the data on scope destroy but without success.
function onDestoy() {
	vm.map = null;
	vm.markers= null;
	vm.markerClusterer = null;
}

$scope.$on("$destroy", onDestoy);

If they are normal marker by html, the markers on map will be destroyed automatically, but yours are marker cluster which is not by HTML
Setting variable does not delete markers on map, thus, you need to remove marker instance directly by setting map to null and deleting it
I know It's not convenient :)
I wish Google map does not have a memory leak, so that we don't have to do this
Besides when it comes to marker clustered, which is not supported by Google officially, it's hard to control those on SPA
The easiest way I can think of is to refresh the page when you need to show a different marker clusterer

On Aug 27, 2016, at 10:07 AM, Deyan Vatsov<EMAIL_ADDRESS>wrote:
Thanks,
I double check and ids are different.
First map is with id map_0 and the second with map_1
Is it way to force map destroy?
I try to remove the data on scope destroy but without success.
function onDestoy() {
vm.map = null;
vm.markers= null;
vm.markerClusterer = null;
}
$scope.$on("$destroy", onDestoy);
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks a lot.
I've added in scope destroy
document.getElementById(vm.mapId).remove();
And it's work.
Now still the issue #670
Do you know workaround in order to remove $timeout between set custom marker data and set clusterer?

I was struggling with a similar issue with MarkerClusterer.  Thank you very much @Vatsov you saved my Saturday night!


New Release (02-19-2024)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e7b7e2b) 99.62% compared to head (a0225e6) 99.40%.
 Consider uploading reports for the commit 37cb8bf to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #821      +/-   ##
==========================================
- Coverage   99.62%   99.40%   -0.23%
==========================================
  Files         110      110
  Lines        2396     2511     +115
  Branches      344      390      +46
==========================================
+ Hits         2387     2496     +109
- Misses          9       13       +4
- Partials        0        2       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:tada: This PR is included in version 1.6.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


reduce the visual noise in the payment step

we show reservation id with spaces and we tell the user to use reservation_id with underscore in the memo hash (not as the value for the memo hash), the explanation needs to be provided there
in currency we show (asset/issuer) can be confusing to the reader either remove the issuer or show some info indicating its usage

verified


Doesn't work with ZenMode

I'm using this distraction-free plugin: https://github.com/folke/zen-mode.nvim
If I try to open goto-preview while ZenMode is activated - I don't see a popup window, but my cursor is constrained within some invisible border, in other words it seems the window exists, but it's completely transparent. If a type :bd my cursor gets back to normal.

@chuwy I pushed a change just now that should help at least with the initial preview, the behaviour is still not 100% but I think it might be outside of the scope of this plugin to fix. Try it out, hope it's at least better now.


Add CheckpointIO classes to split checkpoints

🚀 Feature
Create new CheckpointIO classes that allow:

Splitting a checkpoint by keys, enabling #5339
Splitting a checkpoint by size, relaxing the memory and storage constraints

Motivation
See existing discussions in https://github.com/huggingface/transformers/issues/13548 for why these are interesting features to end-users.
Pitch
Trainer(plugins=CheckpointKeySplitterIO()) or Trainer(plugins=CheckpointSizeSplitterIO(max_size="10GB"))
Alternatives
Have users create and maintain these solutions. The Trainer should allow it.

If you enjoy Lightning, check out our other projects! ⚡

Metrics: Machine learning metrics for distributed, scalable PyTorch applications.

Lite: enables pure PyTorch users to scale their existing code on any kind of device while retaining full control over their own loops and optimization logic.

Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, fine-tuning, and solving problems with deep learning.

Bolts: Pretrained SOTA Deep Learning models, callbacks, and more for research and production with PyTorch Lightning and PyTorch.

Lightning Transformers: Flexible interface for high-performance research using SOTA Transformers leveraging Pytorch Lightning, Transformers, and Hydra.

cc @borda @tchaton @justusschock @awaelchli @jjenniferdai @rohitgr7

Splitting a checkpoint by keys, enabling https://github.com/PyTorchLightning/pytorch-lightning/issues/5339

how does it enable this?
I think #5339 is related to the reloading of checkpoints.

If there's a checkpoint directory with a file called optimizer_states.ckpt, then we should allow the user to remove this file and have everything work as expected without reloading the optimizer state.
Maybe "enable" wasn't the right word but "supports"


2.1 Regression: Definite assignment with try..finally

TypeScript Version:  2.1.? / the one that comes with VS 2017 RC
Code
async function bug() {
    let response: Response;
    try {
        response = await fetch("www.google.com");
    }
    finally {
    }
    if (response.ok)  // <- error: Variable response is used before being assigned
        console.log("ok");
}

Expected behavior: was compiling (and working) fine in TS 2.0
Actual behavior: Error: response is used before being assigned.

Improvement ;)
async function bug() {
    let response;
    try {
        response = await fetch();
    }
    catch(err) {}
    finally {
    }
    if (response.ok)  // <- error: Variable response is used before being assigned
        console.log("ok");
}
bug()

Run this and you will get runtime error Cannot read property 'ok' of undefined(…)
Maybe error message could be ' Variable response is potentially used before being assigned'

looks like a duplicate of https://github.com/Microsoft/TypeScript/issues/12205

I didn't see that one, it looks like a dup indeed.


Cartesian how to use the update_line function?

there is a update_line function in the Cartesian class.
but i have not found any documentation about it -
i would expect to be able to draw some kind of linegraph with multiple points.
but looking at the code and testing that does not happen..
it seems that the first time the function is called it setups self.plot_line_point and adds the given point.
and after this it draws a line from this first point to the given point.
resulting in a star-like graph.
i tested and the only thing missing is a self.plot_line_point.append((local_x, local_y)) after the call to bitmaptools.draw_line(
my minimal testcode:
# SPDX-FileCopyrightText: 2021 Stefan Krüger
#
# SPDX-License-Identifier: MIT
#############################
"""
Simple Test for line-ploting with the Cartesian widget.
"""

import time
import board
import displayio
from adafruit_displayio_layout.widgets.cartesian import Cartesian

# create the display on the PyPortal or Clue or PyBadge (for example)
display = board.DISPLAY

# pybadge display:  160x128
# Create a Cartesian widget
# https://circuitpython.readthedocs.io/projects/displayio-layout/en/latest/api.html#module-adafruit_displayio_layout.widgets.cartesian
my_plane = Cartesian(
    x=30,  # x position for the plane
    y=2,  # y plane position
    width=128,  # display width
    height=105,  # display height
    xrange=(0, 90),
    yrange=(0, 90),
)

my_group = displayio.Group()
my_group.append(my_plane)
display.show(my_group)  # add high level Group to the display

positions = [
    (0, 0),
    (10, 10),
    (20, 50),
    (30, 60),
    (40, 40),
    (50, 80),
    (60, 20),
    (70, 60),
    (80, 30),
    (90, 90),
]

print("displayIO__layout_widget_cartesian_lineplot.py")
for x, y in positions:
    my_plane.update_line(x, y)
    time.sleep(1)

while True:
    pass

@FoamyGuy  @kattni should i submit a pull request for this?

@s-light Yes that would be awesome if you want to submit PR for that. Thank you!


Demo dependencies missing - ImportError: cannot import name gpu_normals

I am trying to run ./experiments/scripts/demo.sh 0
I have installed following till now:-

pip install opencv-contrib-python==<IP_ADDRESS>
conda install scipy
sudo apt-get install python3-setuptools
pip install cython
pip install -U pip setuptools
pip install transforms3d

I am currently stuck with ImportError: cannot import name gpu_normals. Please could you suggest which library this is?
Ofcourse, would help others if you add these dependencies to readme with versions as well.

Did you go into
cd $ROOT/lib
and run
python setup.py build_ext --inplace
before running the demo ? If not, it should import gpu_normals.
see https://github.com/yuxng/PoseCNN/issues/15

Got it working. @TotoLulu94 : Thanks. This step should be added to README.md.
For users: after above commands, I have executed following
sudo apt-get install libeigen3-dev
python setup.py build_ext --inplace
conda install -c auto easydict
I am still facing error after this but thats due to Tensorflow and cuda9.2 conflict. But hopefully should run after this. Will update if any further issue.

I did that, but after that now I am getting this:
fatal error: Eigen/Eigen: No such file or directory

@Abdul-Mukit  Have you read the Post from saurabheights?
Fatal error: Eigen/Eigen: No such file or directory
You should be able to fix this error with the following code:
sudo apt-get install libeigen3-dev
Perhaps this more detailed installation application will help you.
https://github.com/Kaju-Bubanja/PoseCNN/tree/docu_updated
But there is a typo: Eigen 3.3.5 ! not Eigen 3.3.9

I did that, but after that now I am getting this:
fatal error: Eigen/Eigen: No such file or directory

check if your eigen path same as the code author written in lib/setup.py


Automated cherry pick of #3948: Fix pkill failure in e2e test

Cherry pick of #3948 on release-1.5.
#3948: Fix pkill failure in e2e test
For details on the cherry pick process, see the cherry pick requests page.

/test-all

/test-all

Codecov Report

Merging #3960 (d2d849b) into release-1.5 (33e165b) will decrease coverage by 17.42%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           release-1.5    #3960       +/-   ##
================================================
- Coverage        58.89%   41.47%   -17.43%
================================================
  Files              333      200      -133
  Lines            28561    24186     -4375
================================================
- Hits             16821    10030     -6791
- Misses            9874    13122     +3248
+ Partials          1866     1034      -832

Flag
Coverage Δ

kind-e2e-tests
?

unit-tests
41.47% <ø> (-0.03%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.


Migrate to safer API that consumes ReactElement template directly.

Additionally, validate against common CSS vulnerabilities, including
a closing style tag, javascript expressions, and -moz-binding.
Adds as dependencies:

Google Caja for sanitizing and escaping
Clean CSS for minification
ReactDOM for renderToStaticMarkup

Update examples

Fixes #38 and #39

LGTM


deprecate / remove DOWNLOAD_CODES

for me its ok now, though @rieder we sort of decided to always assume DOWNLOAD_CODES=1 ??

yes - we need to implement that (by removing DOWNLOAD_CODES references?).
Originally posted by @rieder in https://github.com/amusecode/amuse/issues/805#issuecomment-985880309

I think we should just remove it, it has no real purpose anymore.

We should make sure that downloadable codes have a 'download' target in Makefile (which downloads the code), that is used only if the source directory is not yet present.
We don't want the download to happen every time the code is built.
Also 'distclean' should remove the source directory.

(this may already be the case but we should check it)

agree

todo, (1) remove DOWNLOAD_CODES (always assume ==1) and check (2) download is not done if corresponding src is available, (3) clean leaves download in placand , distclean removes it. for the following codes:

[ ] bonsai2
[ ] flash
[ ] krome
[ ] mesa_r15140
[ ] mesa_r2208
[ ] mocassin
[ ] mpiamrvac
[ ] rebound
[ ] tupan
[ ] vader

bonsai2 makefile looks iffy, needs testing


Add processors to handle file/dir ownership

Yes, that's a good idea to provide an additional arguments field.  I'll fix that up.

I'm calling this work 'done' for this effort.  Merging.


Add support for message header

In Homer we can have a header message before all the services, something like this:
message:
  url: "http://<IP_ADDRESS>:8099/endpoint/"
  style: "is-danger"
  title: "Service status"
  content: "Waiting for results from statping..."

This is very useful to integrate various services on the dashboard, my example is to show the uptime status of all the services in the dashboard.
It is the only Homer-like feature that bender is missing, and I hope you would consider adding it.

Hi @kotnik
Sure, I can look at adding this, looks pretty straightforward


liquid-if truth/falsy class name attributes

Would be nice to have these.
{{#liquid-if isLoading class='loading' truthyClass='still-loading' falsyClass='not-loading'}}
{{/liquid-if}}

This would help with animating absolute positioned elements.

I don't think we want specialized properties, we should just make sure the general-purpose htmlbars stuff works. Some of the syntax is still being improved, but you can already do this:
{{#liquid-if isLoading class=(if isLoading "loading still-loading" "loading not-loading")}}
{{/liquid-if}}

What do you mean by "help with animating absolute positioned elements?". Because if you mean you want to use different animations depending on this class, it's easier to just write the transition rules to match toValue(true) vs toValue(false).

@ef4 that's a good solution. Thanks.
The liquid-if element overlaps other elements while they load (a map), and once they load the liquid-if element needs to be resized/zindexed so the map below can be accessed.


unable to use crossplane with localstack

apiVersion: aws.upbound.io/v1beta1
kind: ProviderConfig
metadata:
name: default
spec:
endpoint:
hostnameImmutable: true

url:

  type: Static

  static: http://<IP_ADDRESS>:31566

credentials:
source: Secret

secretRef:

  namespace: crossplane-system

  name: aws-secret

  key: creds

Warning  CannotConnectToProvider          2m26s (x15 over 2m38s)  managed/s3.aws.upbound.io/v1beta1, kind=bucket  (combined from similar events): cannot get terraform setup: cannot get the caller identity: GetCallerIdentity query failed: GetCallerIdentity query failed: operation error STS: GetCallerIdentity, https response error StatusCode: 403, RequestID: f0849dda-504f-4f42-999b-ab7aab249dde, api error InvalidClientTokenId: The security token included in the request is invalid.

What happened?

How can we reproduce it?

What environment did it happen in?
Crossplane version:

please open an issue in upbound/provider-aws checkout https://github.com/upbound/provider-aws/pull/447 because this here is community-provider-aws and localstack is working with https://github.com/haarchri/provider-aws-issue-1017/blob/main/providerconfig.yaml


+treemacs/toggle error: treemacs-persp not installed

What did you expect to happen?
SPC o p (+treemacs/toggle) should open treemacs.
What actually happened?
Cannot open load file: No such file or directory, treemacs-persp

Additional details:
treemacs-persp not coming up in describe-package
output of doom/describe-package treemacs-persp:
   Package: treemacs-persp
     Source:

```
Debugger entered--Lisp error: (file-missing "Cannot open load file" "No such file or directory" "treemacs-persp")
  require(treemacs-persp nil nil)
  (closure (t) nil (require (quote treemacs-persp) nil nil))()
  eval-after-load-helper("/home/dylanjw/.emacs.d/.local/straight/build/treemacs/treemacs.elc")
  run-hook-with-args(eval-after-load-helper "/home/dylanjw/.emacs.d/.local/straight/build/treemacs/treemacs.elc")
  do-after-load-evaluation("/home/dylanjw/.emacs.d/.local/straight/build/treemacs/treemacs.elc")
  #((autoload "treemacs" ("/home/dylanjw/.emacs.d/.local/autoloads.pkg.elc" . 573920) t nil) treemacs nil)
  apply(# ((autoload "treemacs" ("/home/dylanjw/.emacs.d/.local/autoloads.pkg.elc" . 573920) t nil) treemacs))
  autoload-do-load((autoload "treemacs" ("/home/dylanjw/.emacs.d/.local/autoloads.pkg.elc" . 573920) t nil) treemacs)
  command-execute(treemacs record)
  counsel-M-x-action("treemacs")
  ivy-call()
  ivy-read("M-x " ("toggle-debug-on-error" "version" "view-echo-area-messages" "doom/describe-package" "use-package-lint" "package-install" "persp-mode" "shell" "mu4e" "tramp-version" "eww" "=mu4e" "forge-pull" "describe-function" "eval-buffer" "describe-mode" "flycheck-mode" "describe-package" "yas-describe-tables" "list-packages" "flycheck-verify-setup" "doom/toggle-debug-mode" "eww-mode" "org-mode" "browse-web" "winner-mode" "describe-key" "isearch-exit" "shell-command" "debug-on-entry" "flycheck-compile" "rustic-cargo-new" "cancel-debug-on-entry" "rustic-flycheck-setup" "+python/open-ipython-repl" "pdb" "doom/info" "magit-init" "pyenv-mode" "sort-lines" "eval-region" "semantic-mode" "package-delete" "pyenv-mode-set" "javascript-mode" "doom/help-search" "info-emacs-manual" "evil-window-vsplit" "enable-paredit-mode" "eshell-kill-process" ...) :predicate #f(compiled-function (x) #) :require-match t :history counsel-M-x-history :action counsel-M-x-action :keymap (keymap (67108908 . counsel--info-lookup-symbol) (67108910 . counsel-find-symbol)) :initial-input nil :caller counsel-M-x)
  counsel-M-x()
  funcall-interactively(counsel-M-x)
  call-interactively(counsel-M-x nil nil)
  command-execute(counsel-M-x)
  read-from-minibuffer("M-x " nil (keymap (keymap (67108908 . counsel--info-lookup-symbol) (67108910 . counsel-find-symbol)) keymap (12 . ivy-alt-done) (67108896 . ivy-call-and-recenter) (33554443 . scroll-down-command) (33554442 . scroll-up-command) (11 . previous-line) (26 closure (t) nil (interactive) (condition-case nil (progn (call-interactively (function undo))) (error nil))) (23 . doom/delete-backward-word) (21 . evil-delete-back-to-indentation) (1 . move-beginning-of-line) (escape . abort-recursive-edit) (36 . ivy-magic-read-file-env) (3 keymap (5 . +ivy/woccur) (19 . ivy-rotate-sort) (1 . ivy-toggle-ignore) (15 . ivy-occur)) (67108903 . ivy-avy) (33554464 . ivy-restrict-to-matches) (15 . ivy-dispatching-done) (22 . yank) (prior . ivy-scroll-down-command) (next . ivy-scroll-up-command) (7 . minibuffer-keyboard-quit) (right . ivy-forward-char) (32 . self-insert-command) (18 . evil-paste-from-register) (19 . counsel-minibuffer-history) (remap keymap (doom/delete-backward-word . ivy-backward-kill-word) (describe-mode . ivy-help) (kill-ring-save . ivy-kill-ring-save) (kill-whole-line . ivy-kill-whole-line) (kill-line . ivy-kill-line) (scroll-down-command . ivy-scroll-down-command) (scroll-up-command . ivy-scroll-up-command) (end-of-buffer . ivy-end-of-buffer) (beginning-of-buffer . ivy-beginning-of-buffer) (kill-word . ivy-kill-word) (forward-char . ivy-forward-char) (delete-char . ivy-delete-char) (backward-kill-word . ivy-backward-kill-word) (backward-delete-char-untabify . ivy-backward-delete-char) (delete-backward-char . ivy-backward-delete-char) (previous-line . ivy-previous-line) (next-line . ivy-next-line)) (9 . ivy-partial-or-done) (10 . next-line) (27 keymap (1 . ivy-read-action) (15 . ivy-dispatching-call) (111 . hydra-ivy/body) (25 . ivy-insert-current-full) (105 . ivy-insert-current) (106 . ivy-yank-word) (114 . ivy-toggle-regexp-quote) (97 . ivy-toggle-marks) (16 . ivy-previous-line-and-call) (14 . ivy-next-line-and-call) (118 . ivy-scroll-down-command) (112 . ivy-previous-history-element) (110 . ivy-next-history-element) (10 . ivy-immediate-done) (13 . ivy-call)) (mouse-3 . ivy-mouse-dispatching-done) (mouse-1 . ivy-mouse-done) (down-mouse-1 . ignore) (13 . ivy-done)) nil counsel-M-x-history)
  ivy-read("M-x " ("version" "view-echo-area-messages" "doom/describe-package" "use-package-lint" "package-install" "persp-mode" "evil-window-vsplit" "shell" "mu4e" "toggle-debug-on-error" "tramp-version" "eww" "=mu4e" "forge-pull" "describe-function" "eval-buffer" "describe-mode" "flycheck-mode" "describe-package" "yas-describe-tables" "list-packages" "flycheck-verify-setup" "doom/toggle-debug-mode" "eww-mode" "org-mode" "browse-web" "winner-mode" "describe-key" "isearch-exit" "shell-command" "debug-on-entry" "flycheck-compile" "rustic-cargo-new" "cancel-debug-on-entry" "rustic-flycheck-setup" "+python/open-ipython-repl" "pdb" "doom/info" "magit-init" "pyenv-mode" "sort-lines" "eval-region" "semantic-mode" "package-delete" "pyenv-mode-set" "javascript-mode" "doom/help-search" "info-emacs-manual" "enable-paredit-mode" "eshell-kill-process" ...) :predicate #f(compiled-function (x) #) :require-match t :history counsel-M-x-history :action counsel-M-x-action :keymap (keymap (67108908 . counsel--info-lookup-symbol) (67108910 . counsel-find-symbol)) :initial-input nil :caller counsel-M-x)
  counsel-M-x()
  funcall-interactively(counsel-M-x)
  call-interactively(counsel-M-x nil nil)
  command-execute(counsel-M-x)
```

System information:

```
emacs   version    26.3
        features   XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS GLIB NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD LCMS2
        build      Aug 29, 2019
        buildopts  (--prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --with-x-toolkit=gtk3 --with-xft --with-modules 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fno-plt' CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now)
        windowsys  x
        daemonp    server-running
doom    version    2.0.9
        build      HEAD -> develop, origin/develop, origin/HEAD 2c536cf94 2020-01-23 17:20:58 -0500
        dir        ~/.doom.d/
system  type       gnu/linux
        config     x86_64-pc-linux-gnu
        shell      /usr/bin/zsh
        uname      Linux 5.4.13-3-MANJARO #1 SMP PREEMPT Mon Jan 20 18:17:25 UTC 2020 x86_64
        path       (~/.cargo/bin ~/.pyenv/plugins/pyenv-virtualenv/shims ~/.pyenv/shims ~/.cargo/bin ~/.local/bin /usr/local/bin /usr/local/sbin /usr/bin /opt/intel/mediasdk/bin /usr/lib/jvm/default/bin /usr/bin/site_perl /usr/bin/vendor_perl /usr/bin/core_perl /var/lib/snapd/snap/bin ~/.antigen/bundles/robbyrussell/oh-my-zsh/lib ~/.antigen/bundles/robbyrussell/oh-my-zsh/plugins/git ~/.antigen/bundles/robbyrussell/oh-my-zsh/plugins/pyenv ~/.antigen/bundles/robbyrussell/oh-my-zsh/plugins/rust ~/.antigen/bundles/zsh-users/zsh-syntax-highlighting ~/.pyenv/bin /usr/lib/emacs/26.3/x86_64-pc-linux-gnu/)
config  envfile    envvar-file
        elc-files  0
        modules    (:completion company ivy :ui doom doom-dashboard doom-quit hl-todo modeline nav-flash ophints (popup +all +defaults) treemacs vc-gutter vi-tilde-fringe window-select workspaces :editor (evil +everywhere) file-templates fold multiple-cursors rotate-text snippets word-wrap :emacs dired electric ibuffer vc :checkers syntax :tools (eval +overlay) (lookup +docsets) lsp magit pdf :lang assembly (cc +lsp) common-lisp data emacs-lisp latex ledger markdown (org +dragndrop +hugo +ipython +pandoc +present) (python +lsp +pyenv) (rust +lsp) sh :email (mu4e +gmail) :config (default +bindings +smartparens))
        packages   (tramp counsel-tramp (ob-rust :pin "6a82587598cd097e9642be916243c31f1231b24a") flycheck-rust flycheck-inline paredit edebug treemacs-projectile (treemacs-persp :pin "d539f7bfa0cf97383a3e15688d904c14d4d94aa9"))
        elpa       (tramp swiper ivy counsel-tramp counsel)
```

Odd. You shouldn't ever have to use package.el to get a package to work. I suspect the straight build cache was corrupted somehow. Your best bet may be to enter the following in the command line:
cd ~/.emacs.d
rm -rf .local/straight
git pull
doom sync

I still get this error after deleting the build caches:
Package error: (error Could not find package treemacs-persp in recipe repositories: (org-elpa melpa gnu-elpa-mirror emacsmirror-mirror))

Try running doom update, instead. Perhaps your local recipe repos (melpa) are outdated.

That did it.  Thank you!

Great! I'll look into updating the recipes separately from the rest of the packages. Thanks for letting me know!

I'm seeing this issue as well when trying to update doom, the update fails and I'm kind of stuck.
doom -d update
- Debug mode on

WARNING (:tools flycheck) module was moved to (:checkers syntax)
DOOM Initializing package.el
DOOM Initializing straight.el
x There was an unexpected error:
  Type: error
  Message:
    error
  Data:
    "Could not find package treemacs-persp in recipe repositories: (org-elpa melpa gnu-elpa-mirror emacsmirror-mirror)"

Run the command again with the -d (or --debug) switch to enable debug
mode and (hopefully) generate a backtrace from this error:

  doom -d update

If you file a bug report, please include it!

@hlissner I'm having this error and when I try to update doom:
doom -d update
- Debug mode on

DOOM Initializing package.el
DOOM Initializing straight.el
> Updating recipe repos...
  > Updating recipes for melpa...nil
  > Updating recipes for gnu-elpa-mirror...nil
  > Updating recipes for emacsmirror-mirror...nil
> Updating packages (this may take a while)...
  > (1/225) Fetching melpa...nil
  > (2/225) Fetching gnu-elpa-mirror...nil
  > (3/225) Fetching emacsmirror-mirror...nil
  - (4/225) straight is up-to-date...nil
  - (5/225) use-package is up-to-date...nil
  - (6/225) bind-key is up-to-date...nil
  - (7/225) auto-minor-mode is up-to-date...nil
  - (8/225) gcmh is up-to-date...nil
  - (9/225) all-the-icons is up-to-date...nil
  - (10/225) hide-mode-line is up-to-date...nil
  - (11/225) highlight-numbers is up-to-date...nil
  - (12/225) rainbow-delimiters is up-to-date...nil
  - (13/225) restart-emacs is up-to-date...nil
  - (14/225) better-jumper is up-to-date...nil
  - (15/225) dtrt-indent is up-to-date...nil
  - (16/225) helpful is up-to-date...nil
  - (17/225) ns-auto-titlebar is up-to-date...nil
  - (18/225) pcre2el is up-to-date...nil
  - (19/225) smartparens is up-to-date...nil
  - (20/225) ws-butler is up-to-date...nil
  - (21/225) clipetty is up-to-date...nil
  - (22/225) projectile is up-to-date...nil
  - (23/225) general is up-to-date...nil
  - (24/225) which-key is up-to-date...nil
  - (25/225) ranger is up-to-date...nil
  - (26/225) flyspell-lazy is up-to-date...nil
  - (27/225) company is up-to-date...nil
  - (28/225) company-dict is up-to-date...nil
  - (29/225) company-prescient is up-to-date...nil
  - (30/225) company-box is up-to-date...nil
  - (31/225) swiper is up-to-date...nil
  - (32/225) ivy is up-to-date...nil
  - (33/225) ivy-hydra is up-to-date...nil
  - (34/225) counsel is up-to-date...nil
  - (35/225) amx is up-to-date...nil
  - (36/225) counsel-projectile is up-to-date...nil
  - (37/225) ivy-rich is up-to-date...nil
  - (38/225) wgrep is up-to-date...nil
  - (39/225) flx is up-to-date...nil
  - (40/225) all-the-icons-ivy is up-to-date...nil
  - (41/225) doom-themes is up-to-date...nil
  - (42/225) solaire-mode is up-to-date...nil
  - (43/225) hl-todo is up-to-date...nil
  - (44/225) doom-modeline is up-to-date...nil
  - (45/225) anzu is up-to-date...nil
  - (46/225) evil-anzu is up-to-date...nil
  - (47/225) nav-flash is up-to-date...nil
  - (48/225) evil-goggles is up-to-date...nil
x There was an unexpected error:
  Type: doom-package-error
  Message:
    Error with packages
  Data:
    "treemacs"
    (error "Failed to run \"git\"; see buffer *straight-process*")
  Straight output:
    fatal: ambiguous argument 'HEAD': unknown revision or path not in the working tree.
    Use '--' to separate paths from revisions, like this:
    'git <command> [<revision>...] -- [<file>...]'
    HEAD

Run the command again with the -d (or --debug) switch to enable debug
mode and (hopefully) generate a backtrace from this error:

  doom -d update

If you file a bug report, please include it!

@ivangalbans Sounds like you may be on an old version of Doom, before it updated your local recipe repos. Try updating manually, just this once:
cd ~/.emacs.d
git pull
doom sync -up

@hlissner I have tried tried but it gave me the same error. I 've fixed it by removing .emacs.d and cloning again.
Thank you!


Polygon colliders load as Rect shapes

When I have a tileset with Polygon colliders, they are still loading as Rect shapes. Example tileset at https://github.com/Aposhian/bevy-sandbox/blob/tilemap-refactor/assets/grass_walls.tsx

I think the issue is that the object templates are not being loaded properly, and so it silently defaults to dummy Rect objects. I would advocate that that be not a silent failure to a different shape type.

On which version is this? (current / 0.10.2 does not have template support.)

This was on 0.10.2 (without template support). I still don't like the silent failure, but maybe the point is moot with template support being added in the next version.

It's not really a "feature", but rather done for compatibility with the TMX format. <object> doesn't need to contain a shape and so it defaults to a rectangle: https://doc.mapeditor.org/en/stable/reference/tmx-map-format/#object
I do agree that with the template attribute set this makes things a bit confusing, and perhaps we should've chosen to throw an error (or log a warning?) if the template parameter was set as there was no support for it. Changing this now to return an error could break loading for some users though, so I think it's better we just wait until the 0.11 release.

I still don't like the silent failure, but maybe the point is moot with template support being added in the next version.

Yeah, I think at this point it's not really worth it making a new release that errors out on templates. 0.11 should be almost done (it's mainly still depending on the final solution for #37 - ggez integrates nicely now, but @aleokdev was still looking into integrating with Bevy).


TAS: API to support rank-based ordering for custom CRDs

What would you like to be added:
API which allows to use custom PodIndex labels for custom CRD jobs, without the incentive to use labels
reserved for kubernetes in the in-house Jobs.
Why is this needed:

the current PodIndex labels lookup only work for "known" jobs with built-in integrations: here
this will not work for in-house Jobs, unless the developers use the labels from other projects (like kubernetes.io/job-completion-index), which creates an unhealthy incentive in the long run
This is part of the graduation plan for stable:  https://github.com/kubernetes-sigs/kueue/tree/main/keps/2724-topology-aware-scheduling#stable.

Completion requirements:

[ ] KEP update
[ ] API change
[ ] Docs update

The proposal is to extend the workload PodSetTopologyRequest API with the following fields:
// PodIndexLabel indicates the name of the label indexing the pods.
// For example, in the context of
// - kubernetes job this is: kubernetes.io/job-completion-index
// - JobSet: kubernetes.io/job-completion-index (inherited from Job)
// - Kubeflow: training.kubeflow.org/replica-index
PodIndexLabel *string

// SubGroupIndexLabel indicates the name of the label indexing the instances of replicated Jobs (groups)
// within a PodSet. For example, in the context of JobSet this is jobset.sigs.k8s.io/job-index.
SubGroupIndexLabel *string

// SubGroupIndexLabel indicates the count of replicated Jobs (groups) within a PodSet.
// For example, in the context of JobSet this value is read from jobset.sigs.k8s.io/replicatedjob-replicas.
SubGroupCount *int32

The values could be then set when implementing the PodSets() function in the GenericJob interface via the
PodSetTopologyRequest helper function like here.
Then, the API could be read from TopologyUngater, instead of the lookups.

cc @PBundyra @tenzen-y @mwielgus @mwysokin


Unable to login - Codeforces javascript redirect issue

Recently codeforces updated there web service to redirect through javascript to destination page. Because of this, the GET returns the page that redirects (not the final landing page) hence, the command line prompts Unable to find csrf.
This is what it returns:
<html>
 <head></head>
 <body>
  Redirecting... Please, wait.
  <script type="text/javascript" src="/aes.min.js"></script>
  <script>function toNumbers(d){var e=[];d.replace(/(..)/g,function(d){e.push(parseInt(d,16))});return e}function toHex(){for(var d=[],d=1==arguments.length&&arguments[0].constructor==Array?arguments[0]:arguments,e="",f=0;f<d.length;f++)e+=(16>d[f]?"0":"")+d[f].toString(16);return e.toLowerCase()}var a=toNumbers("e9ee4b03c1d0822987185d27bca23378"),b=toNumbers("188fafdbe0f87ef0fc2810d5b3e34705"),c=toNumbers("ff42be26c8159cd50f366324c648d42c");document.cookie="RCPC="+toHex(slowAES.decrypt(c,2,a,b))+"; expires=Thu, 31-Dec-37 23:55:55 GMT; path=/";document.location.href="https://codeforces.com/enter?f0a28=1";</script>
 </body>
</html>

Can you please update the tool to handle this ?
Thanks

I managed somehow to overcome the redirect issue, but then, https://github.com/xalanq/cf-tool/blob/master/client/login.go#L78-L87 this block of params isn't accepted anymore. It throws 403 error (i.e. Request recognized but not authorized).
Looks like someone will have re-research (if that's a term) the whole login process again

I managed somehow to overcome the redirect issue, but then, https://github.com/xalanq/cf-tool/blob/master/client/login.go#L78-L87 this block of params isn't accepted anymore. It throws 403 error (i.e. Request recognized but not authorized).
Looks like someone will have re-research (if that's a term) the whole login process again

Please tell me how you solved the redirect problem. I developed this kind of software, too. I can use this method to pass the verification and try to figure out the apis of 'login'.

I used selenium web driver with headless argument (which opens browser in background) and then tried to login using those params.

I am facing the same issue. Did anyone resolve this? Can you please tell me what to do?

I am facing the same issue. Did anyone resolve this? Can you please tell me what to do?

The solution is to decrypt the codes in the redirect page and get the right key. You can search for them in some forks of this project.

I am facing the same issue. Did anyone resolve this? Can you please tell me what to do?

The solution is to decrypt the codes in the redirect page and get the right key. You can search for the algorithm in some forks of this project.

Can you help me by providing the procedure to decrypt and fix it? Sorry if this sounds novice.


EDI files from SAGE COALA starting by DOC

Hello,
I have some EDI files (.ped generated by SAGE COALA) that start by DOC, example :
DOC+01=serveur\grpx\dossiers\xxxxx+02=9215001+03=04/07/2024+04=FD2401+05=24+06=DGFiP+07=EDITDFC+08=32489+09=xxxxxxxxxxxxx+10=xxxxxxx+11=XXXXXX PATRIMOINE+12=xxxxxxxxxxx++14=FR1111111111+15=mickael+16=isrn+17=01/01/2023+18=31/12/2023+19=240315+++++24=103200+25=JDC+26=contact@example.com+27=++29=++++++35={55D57981-DA87-426D-911E-464844992C9C}'UNA:+,? 'UNB+UNOL:...

I get the error : An interchange must start with UNB or UNA and UNB
Is it possible to take care about this kind of file ?

I will submit a PR


fe-homework-12

Metric
Value

alert_status
:white_check_mark: OK

bugs
1

code_smells
1

reliability_rating
B (at least 1 Minor Bug)Note: A being best, E being worst

security_rating
A (0 Vulnerabilities)Note: A being best, E being worst

vulnerabilities
0


Last match, result, and rewards from events missing

Describe the bug
Win-loss records and rewards for draft events are not showing up correctly on my events page and daily summary.
To Reproduce
Steps to reproduce the behavior:

Go to my events page at https://mtgarena.pro/events/#discomethod.
The results for two drafts on August 7 are both 6:2, even though both events were played to completion. No rewards are listed for either event.
Likewise, on the daily summary for my feed, the win-loss records for the two draft decks I played are incorrect.

Expected behavior
The Gruul deck ended 6:3 without receiving the bonus pack prize, and the Temur deck ended 7:2. The records are still incorrect after performing manual resync.
Screenshots

Additional context
Seems like the last match I played for each of these events couldn't be parsed, which could explain why the rewards and result of the final game are what's missing.

Thank you! We will investigate your issue! Do you have this issue during the 8th of August too?

@Aquaman88 Yes, in fact I've played a few more drafts since and they seem to be fully correct (on daily feed and events page).

Thank you for myour information. Unfortunately, the information about matches sometimes can be missed. There are a lot of reasons of this phenomenon but the main reason of it situation can be a lot of synchronous processes. We can't debug all of them, but we are still trying to find the solution. We cannot guarantee any terms of fixing, so we have to deal with some missing matches.


Don't Merge! PR real time test for source branch full build

Docs Build status updates of commit 486bbfa:
:clock10: Pending: waiting for processors (25 builds ahead of you)
:warning: Docs Build is busy, currently there are 25 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 486bbfa:
:clock10: Full build: the average full build time is 5 min(s) 52 sec(s), this is based on the last 30 build(s) for this repository.

Docs Build status updates of commit 486bbfa:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Make rawQuery timeout handling more thread-safe

Previously an elapsed duration was saved on the Client object and was updated multiple times on each call to rawQuery. This could lead to a race condition when calling whois.Whois(...) in parallel, where one thread halfway through the function has a non-zero elapsed duration and another thread entering the function sets it to 0. This removes the elapsed field on the Client object and uses a local variable instead, which avoids the aforementioned issue.

Hello @ugexe
Thanks for your works!


Feature/yaml policy triggers

This PR adds the support for Policy Trigger Definitions for TOSCA YAML

[ ] Ensure that you followed our toolchain guide. Especially, we require a single commit
[x] Ensure that the commit message is a good commit message
[x] Ensure to use auto format in all files
[x] Ensure that you appear in NOTICE at Copyright Holders
[x] Tests created for changes
[ ] Documentation updated (if needed)
[ ] Screenshots added (for UI changes)

Filed commit af2e739996da351b24d395ec16da9077e93597c6 as CQ 23782.


Can the directory misc be deleted?

The directory misc/ seems to only contain one notebook, whose name _OLD.ipynb suggests that it is outdated. Can we remove this notebook and the directory misc/?

@NoraLoose That's my notebook for generating figures in the manuscript. It's OLD as the filename indicates. I made several updates to include more figures during the revision period.
tldr: safe to delete the file and the directory!

🧹 🧼 loving this cleanup!

Great, thanks @sungdukyu!


Name codeobj deterministically using the name of the function...

…so that the same codeobj generated during function declaration can be used later in TraceCall (line_profiler depends on this behavior).
(Based on b56135154f546eec34d88342dc1698cf1803492e updated for latest upstream)
Using this patch, the following directives to 'cython':
--directive profile=true
--directive linetrace=true
--directive binding=true

and the following compile-time define for gcc (or your favorite compiler):
-DCYTHON_TRACE=1

are sufficient to enable line-based profiling in a Cythonized module using kernprof/line_profiler.

This breaks a test because the name is not properly built in Nodes.py. I guess it should use self.entry.name there, not trace_name.
Did you check if there are any unused/leftover code objects after your change? Overwriting the code object reference in Nodes.py seems a bit, erm, direct. Can't say right now if that's the right thing to do.

OK, thanks, I removed that assignment to frame_code.  It may have been necessary at some point, but not anymore.  Now the only change is in the names for _codeobj variables, which are no longer opaque numbers.

I thought about this some more and it's not the right way to do this. I've created a branch (https://github.com/cython/cython/tree/fixed_code_objects) that tries to implement this differently.
Please write up some tests to make sure it works as you want it. Preferably some that work without any external dependencies, and also one that integrates with line_profiler if available. See for example the test coverage_cmd.srctree for this (contains multiple files in one, separated by ### filename ###) and the dependency checks in runtests.py (look for EXT_DEP_MODULES).
I'll close this pull request. Please open a new one once you got it working.

Great, thanks. I won't be able to get to this until some time next week but I will definitely take a look.
-syam


Fix OnDisconnect failing to updateChildren

These changes started as a way to fix an issue reported by @nbransby here
The reason for it was (I suspect) caused by a bug in Firebase Database OnDisconnect, where Javascript would update children with a Kotlin map rather than a Json object, which caused the wrong data to be sent and broke verification rules. Fixing this proved quite trivial.
However, it pointed to a design flaw in the SDK as a whole. Often an Any object is passed to set/update methods, while some constraints should apply. This is mostly cases such as create Document, where the value being written should be encoded as a Map of String and Any? (or in Javascripts case as Json). Often casting was done on the platform side (e.g. as Map<String, Any?> on JVM) which is problematic because A) generics get lost in casting, and B) now we have platform level exceptions for data that should be validated in common so a common exception can be thrown/handled. Furthermore, we have a lot of methods where a generically typed value can be provided, which is then encoded and force cast to not-null. Since null will always encode to null this is also incorrect.
Therefore, besides the straightforward fix I have made the following changes:

Introduced an EncodedObject that is passed to internal API methods that only accept encoded data in the form of Map<String, Any?> (or the platform equivalent thereof)
For generic methods that internally have their data encoded to an EncodedObject, the constraint has been changed from <T> to <T : Any> so that no null values can be provided.
Restructured naming of Firebase internal classes a bit so that it is easier to access the platform native implementation
On Firestore introduced the following methods: DocumentSnapshot.contains(fieldPath: FieldPath): Boolean, DocumentSnapshot.get(fieldPath: FieldPath, serverTimestampBehavior: ServerTimestampBehavior, buildSettings: DecodeSettings.Builder.() -> Unit): T and moved Query methods into the class itself (which is no longer expect actuals but uses the same NativeWrapper pattern as used elsewhere)
On Database added FirebaseDatabase.goOnline() and FirebaseDatabase.goOffline() (there where required to actually test OnDisconnect.
Database tests now point to the default database, because I couldnt get test with rules to work otherwise.

Are you proposing EncodedObject becomes part of the public API? Is that a good thing for API consumers?

I would've made it private, but it's in the common module used by firestore/database so it has to be a public class unfortunately. But I forgot to make the constructors private. I'll do that so it's at least inaccessible

Also added some extra documentation that explicitly recommends not to use it directly.

Can you mark it PublishedApi?

That doesn't do anything here. Published api is to make internal methods and classes accessible to inline functions. But 'encodeAsObject' returns an EncodedObject, which is then used in say Firebase-database. Since that is a different module, it is public.
But I would argue the same issue pops up with all the encode methods. They are in the public api, but they shouldn't be used manually either. Sending a value that was encoded using 'encode' to Firestore will lead to double encoding, which would crash. But since those modules need to use it, it needs to be a public method.
What I think would help (but is probably out of scope here) is splitting up the 'firebase-common' module into 'firebase-common' and 'firebase-common-internal', with the latter only ever imported using implement rather than api and not advertised as existing. This will make it fairly clear that it is not for external use.

Btw, what I can (and probably will) do is make EncodedObject an expect interface so it's internals are better guarded. Still I would suggest considering explicit '.internal' packages

@nbransby I made an additional PR that would split up Firebase common into two modules. This may actually be nice since currently the firestore methods allow passing EncodeSettings.Builder, which would require users to import firebase-common.
With this implementation, the firebase-common module can be an API and the firebase-common-internal is imported using implements. I think it solves a lot of "is this public facing or not" issues
https://github.com/splendo/firebase-kotlin-sdk/pull/70

@nbransby I made an additional PR that would split up Firebase common into two modules. This may actually be nice since currently the firestore methods allow passing EncodeSettings.Builder, which would require users to import firebase-common.
With this implementation, the firebase-common module can be an API and the firebase-common-internal is imported using implements. I think it solves a lot of "is this public facing or not" issues
splendo#70

this definitely makes the most sense

Merge it into this one then?

Yep

Done :)
Simplified EncodedData a bit as well, it is now a sealed interface on the internal module, so its fairly well protected from users implementing it

Disabled the new DB test on Android due to a bug in the firebase-android-sdk: https://github.com/firebase/firebase-android-sdk/issues/5870

would it make sense to split each commonMain file into two, having separate files for the public and internal apis would make it easier to maintain (the firebase-firestore/src/commonMain/kotlin/dev/gitlive/firebase/firestore/firestore.kt file is particularly huge)

Sure but can you review/merge #450 first, otherwise I have to track a bunch of merge conflicts

Alternatively, I would suggest splitting up the components themselves (e.g. a file for DocumentReference, Query, etc) into different files which makes actually finding what you need easier

Tracked master and moved all FIrestore internal classes to a .internal package. The same should probably be done for other modules, but since their files are smaller, its less of an issue to I left it as is for now. I'd still suggest splitting up the firestore file into multiple files, but I also left that out to keep this reviewable

what about https://github.com/GitLiveApp/firebase-kotlin-sdk/pull/450#issuecomment-2062064233 ?

It's not impossible, still thinking about doing it right for JS. The trick is gonna be having an expect interface WithNative<T>. With on platform sides default implementations for android ios etc. Then just a matter of implementing the interface everywhere you need it. Tricky thing right now is JS, since its native classes are often exposed as interfaces and so you need an additional wrapper class there. If I can figure out a proper way so that WithNative exposes the interface rather than the wrapping class, it should be good.
Also, Im not sure how K2 handles it.
Ill try and implement it asap. You can decide whether you want to wait for that or just merge this first. Ill probably make a separate branch regardless to keep reviewing straightforward

Small update on it: I tried getting it to work, but its difficult for Javascript. Basically I can't do it without either exposing the wrapper class though the js value, or by making it an extended method still. I tried using delegation, which compiles, but will crash at runtime.

See https://github.com/splendo/firebase-kotlin-sdk/pull/71

See splendo#71

By boilerplate do you mean the single line per platform:
val SomePulbicApi.js get() = ...
?

Also to make sure that all the import dev.gitlive.firebase.*.android can be replaced by a single import. And to get the pattern of having a native value standardized. It would've been more useful if I had been able to figure out the JS thing, but since I couldnt this is it. If you feel its overkill, the accessors already in this PR would basically do the same.

I think what's already in the PR is fine but we need to change them to extensions everywhere so we won't need to make another breaking change in the future

@Daeda88 merged this and made a start on changing them to extensions everywhere: https://github.com/GitLiveApp/firebase-kotlin-sdk/pull/504
During this I noticed a number of your Native... classes are not internal due to the typealiases in android, can you think of another way round this? move into an internal package perhaps? Otherwise the Native... classes  will leak into the public API

Well typealias she's are inherently public I think. On the other pr I moved all of the Native Wrapper classes into an internal package though

Which PR?

I meant this one https://github.com/splendo/firebase-kotlin-sdk/pull/71


Fix typo

Codecov Report

Merging #106 (0d3376e) into main (8ce2611) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #106   +/-   ##
=======================================
  Coverage   56.99%   56.99%
=======================================
  Files          30       30
  Lines        1493     1493
=======================================
  Hits          851      851
  Misses        406      406
  Partials      236      236

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ce2611...0d3376e. Read the comment docs.


Station events

Adds 2 basic events: (Power) GridCheck and RadiationStorm (based on the goonstation version) to start with.
The system itself to choose events is based on tgstation's implementation.
This also adds the event command that can be run to force specific events.
There's still some other TODO items for these to be complete, to my knowledge:

There's no worldspace DrawCircle method (though the radstorm could look a lot nicer with a shader).
The PlayGlobal power_off / power_on audio seems to cut out halfway-through. It might be because the gravity generator sound is also playing at the same time?
(I think this is a known issue) lights still emit light until you get closer.

I'm not 100% happy with how the client-side overlay works for the radiationstorm at the moment as it seems wasteful so suggestions are appreciated.

The PlayGlobal power_off / power_on audio seems to cut out halfway-through. It might be because the gravity generator sound is also playing at the same time?
#259


Extend current integration tests to include apm-server and elasticsearch

Run apm-server and elastichsearch containers in travis
Check the data stored in elasticsearch

@jahtalab will bring this proposal to the agents meeting.


Improve interoperability between dart and javascript

It is still a problem to expose an dart api to javascript.. This shortcoming still reduces the usability of dart drastically.

Yeah, JS interop could be a lot better. The good news is: we're working on it! I filed https://github.com/dart-lang/sdk/issues/35084 to track that. I'll merge this issue into that one, but feel free to follow it for updates.


Create Longest_Substring_Without_Repeating_Characters.cpp

Added a new solution file Longest_Substring_Without_Repeating_Characters.cpp, which implements a C++ program to find the length of the longest substring without repeating characters in a given string. This program uses a sliding window approach along with a hash map to store the last seen index of each character, allowing for efficient tracking of unique substrings.
The code takes user input for the string and outputs the maximum length of any substring without duplicate characters. Comments and an example are included for clarity.

Thank you for the updated code! I’ve applied all the suggested changes and pushed the updates. Please review and let me know if further adjustments are needed.


Fix shape label object obb verticies

closes #1128

PR Checklist

[X] :no_entry_sign: Makes breaking changes
[X] :no_entry_sign: Makes design changes
[X] :no_entry_sign: Adds the License notice to new files.
[X] :no_entry_sign: Adds Python wrapping.
[X] :no_entry_sign: Adds tests and baseline comparison (quantitative).
[X] :no_entry_sign: Adds test data.
[X] :no_entry_sign: Adds Examples to ITKExamples
[X] :no_entry_sign: Adds Documentation.

Refer to the ITK Software Guide for
further development details if necessary.

@dzenanz @hjmjohnson CI came back clean please review.

nit-pick ... The test should have been the first patch, demonstrating failure, and then the fix after that.

Yes, I use to suggest that with Gerrit where the CI would run on each commit in the change set so the CI would demonstrate both the failure and the fix. With the current CI, it only runs the on the whole PR so it no longer can "demonstrates" the failure and the fix. I still like to have the fix and the test update separate so that if the patch needs to be back ported it is a little easer.

:)..  I happen to be lecturing on Red/Green refactoring today.
https://dzone.com/articles/pattern-of-the-month-red-green-refactor

The failing test on ITK.MacOS.Python: itkPyBufferMemoryLeakTest is not related.


Godot 3.1 beta freezes when adding Image

Godot 3.1 beta 2 freezes when adding Image box (generator - image).
Material maker 0.6, Master branch, windows 10 64

@me2beats Can you still reproduce this on the current master branch (or export_plugin branch, which is more recent)?

@RodZill4 This issue can probably be closed now.

it seems to work now.
sorry, I didn't watch this project for a while,
so many new features added, just wow)


Test Smell: it is not a good practice to use the loop in the test

Hi!
We notice that you use the loop structure in your test cases.
For example, testInvalidChar() in NoiseCharactersTest.java

However, using the loop in test cases is not a good test practice.
We analyzed the relevant Stack Overflow posts and summarized four potential negatives it brings:

Loops make the test case more complex.
In most cases, a loop can be replaced with a data-driven test that is more readable.
Loops break the assert-for-one-thing thumb rule. I don't mean a single assert statement.
When a test fails, knowing the reason is more complicated.

Solution:
To avoid using the loop in the test, JUnit provides an annotation (i.e., @ParameteredTest), which can enable a test case to run multiple times with different parameters.
Therefore, the code can be refactored as:
@Test
@ParameteredTest
@@ValueSource(invalidPatterns = {"", "1", "ABC", "\u21", "#x0001-#x0000"
, "#x0001 - #x - #x0000", "#x0000 #x0022"})
public void testInvalidChar(String i) {
assertThrows(IllegalArgumentException.class, () -> {
myFilter.add(i);
});
}

This could probably be replaced with a parameterized test, and a PR implementing that would be accepted.


Large amount is seen on transaction feed for sometime when user is redirected to homepage after sending the invite link to another user

Frequency: 100%
Repro on build version: Android Internal Build V1.22.x , iOS Testflight Build V:1.22.x
Repro on devices: OnePlus 7T(11.0), iPhone12(15), Redmi note 8(9.0), iPhone 12(15), Redmi note 8(10.0)
Tested Account: +33757130733 / Recovery Phrase
Pre-condition:

User must have installed application and completed onboarding process
User must be on send contacts page

Repro Steps:

Select a contact which does not have any account associated to Valora application
Enter a valid amount and click on review button
On send page "Send & invite" button will be seen ,
Click on send and invite button and share the link to another user
It redirects to homepage, observe the invite transaction on recent section

Current Behavior: Large amount is seen after user is redirected to homepage post sending the link
Expected Behavior:  Amount should be seen same as entered while sending the invite link
Investigation:
-Eg : If user sends 0.01 as invite amount then after redirecting to homepage it appears as "10000000.00" and after confirming the amount is seen as "0.01"
Impact:

Bad experience as it would confuse user as user has sent very small amount while sending the invite link

Attachment: large_amount.mp4

Hey, we have verified this issue using Android internal build and iOS test flight build V:1.22.2 & observed that issue is fixed now.
User able to see exact invited amount in Recent feed
Verified on Devices:  OnePlus 7T(11.0), iPhone12(15), Redmi note 8(9.0), iPhone SE (14.6), Redmi note 8(10.0)


number of digits in %L

A timestamp created by Python datetime.datetime.today().isoformat() outputs 2017-11-21T08:34:28.150206. When reading this in from file and parsing it with d3.utcParse("%Y-%m-%dT%H:%M:%S.%L"), I get an error since the fractional seconds part has six instead of three digits. Without knowing what the ISO standard really specifies there, it were nice if %L could either be more lenient and accept any number of consecutive digits, or the number of digits could be specified. This would save the effort of having to truncate/reformat the string before parsing it and would allow direct export/import of ISO datetime data.

You can use %f to parse microseconds. This feature was added in d3-time-format 2.1.0 (d3 4.12.0).

Also, if you don’t mind relying on relatively recent browsers, you can use d3.isoParse to parse these strings instead (or simply use the Date constructor). You will need to add the trailing Z for UTC.
d3.isoParse("2017-11-21T08:34:28.150206Z") // Tue Nov 21 2017 03:34:28 GMT-0500 (EST)
new Date("2017-11-21T08:34:28.150206Z") // Tue Nov 21 2017 03:34:28 GMT-0500 (EST)


Debate: Should we replace the Logo's PNG based on the new SVG?

https://github.com/bitcartcc/bitcart-media/blob/master/logo.png
For a new PNG to make sure that the issues of the older logo are gone.

Yes, we should use svg's everywhere instead


Despite missing variable file test is executed

By mistake I provided a variable file that could not be found under this path:
--variablefile "./variables/testvariables.py"
But the test is executed - and PASSED.
How this?

Hello Holger,
"--variablefile" is a mechanism of robot framework core. We can modify the robot core or  raise this concern to robot framework community.
Thank you,
Son

Hi both,
as discussed today I want to start raising pull-requests for the RobotFramework Community.
This would be a nice issue for this.
I shift the ticket to RobotFramework issues.
@milanac030988 : This would be a nice first issue where we try to contribute.
Thank you,
Thomas


Enable line annotation using two scales

Changes:

position: 'start', 'end' or 'center'
alternative xScaleID, yScaleID, xMin, yMin, xMax, yMax options for line annotation
label hit testing by rotating the point (similar to datalabels plugin)
simpler label position adjustment by calculating the parameter t for pointInLine

Filename
Size
Change

dist/chartjs-plugin-annotation.esm.js
6.07 kB
-505 B (-8%)
✅

dist/chartjs-plugin-annotation.js
6.18 kB
-506 B (-8%)
✅

dist/chartjs-plugin-annotation.min.js
4.17 kB
-447 B (-10%)
👏

@stockiNail take a look, this touches few of the contributions you've made.

Filename
Size
Change

dist/chartjs-plugin-annotation.esm.js
6.07 kB
-505 B (-8%)
✅

dist/chartjs-plugin-annotation.js
6.18 kB
-506 B (-8%)
✅

dist/chartjs-plugin-annotation.min.js
4.17 kB
-447 B (-10%)
👏

@stockiNail take a look, this touches few of the contributions you've made.

@kurkle thank you very much!
I'm gonna have a look tomorrow.

@kurkle thank you very much!
I'm gonna have a look tomorrow.

@kurkle first feedback:
When the label is rotated an close to boundaries of chart area, the label is cut.,
This was an issue #271 that was solved re-positioning the label.

I'm still testing, more feedbacks in next hours

@kurkle first feedback:
When the label is rotated an close to boundaries of chart area, the label is cut.,
This was an issue #271 that was solved re-positioning the label.

I'm still testing, more feedbacks in next hours

Thanks @stockiNail, I failed to consider that situation. Current code does move that label down so it fits the chart area. But that can get you only so far:

same with this pr: (note the text direction, that might be the next feedback :))

In this case, removing the clipping would give a good result, but it does not help if there is no room outside the chart area.
I'm wondering if it would be better to consider this when setting the scale ranges?

Thanks @stockiNail, I failed to consider that situation. Current code does move that label down so it fits the chart area. But that can get you only so far:

same with this pr: (note the text direction, that might be the next feedback :))

In this case, removing the clipping would give a good result, but it does not help if there is no room outside the chart area.
I'm wondering if it would be better to consider this when setting the scale ranges?

same with this pr: (note the text direction, that might be the next feedback :))

I have already done :D. See my previous note in the review close to the code.

same with this pr: (note the text direction, that might be the next feedback :))

I have already done :D. See my previous note in the review close to the code.

In this case, removing the clipping would give a good result, but it does not help if there is no room outside the chart area.
I'm wondering if it would be better to consider this when setting the scale ranges?

Pr #282 solved this issue recalculating the label position in order to stay inside the chart area.
I know that it's not so simple (that's why I added chart reference into element in that PR).
Removing the cliparea could be configurable in order to address the issue #258 as well, something like that:
label: {
	clipEnabled: false, // <-- defaults to true
	position: 'start',
	rotation: -45,
	backgroundColor: 'red',
	content: 'This is a long test label',
	enabled: true
},

In this way you can delegate the user to have enough space for the label.
To change the scales limits (as is done now for the values) could be a solution but this could change the chart going to a picture that probably you don't like with additional space in chart area that you want to avoid.
Honestly, I don't like also the current implementation which is changing the min/max of scales when the values are out of scale, therefore we can maintain as is.
If this will be the solution, we must calculate the rotation and then the necessary space for the label before the element drawing is invoked, I guess.

In this case, removing the clipping would give a good result, but it does not help if there is no room outside the chart area.
I'm wondering if it would be better to consider this when setting the scale ranges?

Pr #282 solved this issue recalculating the label position in order to stay inside the chart area.
I know that it's not so simple (that's why I added chart reference into element in that PR).
Removing the cliparea could be configurable in order to address the issue #258 as well, something like that:
label: {
	clipEnabled: false, // <-- defaults to true
	position: 'start',
	rotation: -45,
	backgroundColor: 'red',
	content: 'This is a long test label',
	enabled: true
},

In this way you can delegate the user to have enough space for the label.
To change the scales limits (as is done now for the values) could be a solution but this could change the chart going to a picture that probably you don't like with additional space in chart area that you want to avoid.
Honestly, I don't like also the current implementation which is changing the min/max of scales when the values are out of scale, therefore we can maintain as is.
If this will be the solution, we must calculate the rotation and then the necessary space for the label before the element drawing is invoked, I guess.

Other feedback (not so important). All samples are still using the previous position option values (left, right, top and bottom).
If it can help, I can submit a PR to your branch, if you don't have time to do it.

Other feedback (not so important). All samples are still using the previous position option values (left, right, top and bottom).
If it can help, I can submit a PR to your branch, if you don't have time to do it.

Other feedback (not so important). All samples are still using the previous position option values (left, right, top and bottom).
If it can help, I can submit a PR to your branch, if you don't have time to do it.

Found only one sample using that. And it turs out it does not work correctly with this PR:
pr: (start)

master: (top)

Other feedback (not so important). All samples are still using the previous position option values (left, right, top and bottom).
If it can help, I can submit a PR to your branch, if you don't have time to do it.

Found only one sample using that. And it turs out it does not work correctly with this PR:
pr: (start)

master: (top)

@kurkle It seems that return Math.max(x, y) (in calculateTAdjust method) is wrong because is returning the maximun value instead it should return x (if line is horizontal) and y (if line is vertical)

@kurkle It seems that return Math.max(x, y) (in calculateTAdjust method) is wrong because is returning the maximun value instead it should return x (if line is horizontal) and y (if line is vertical)

Not sure if it could be correct but the return could be
return w > h ? x : y;
if width of line if greater than height means that the line is horizontal

Not sure if it could be correct but the return could be
return w > h ? x : y;
if width of line if greater than height means that the line is horizontal

Last commit solves it like this (test label with long text is positon: 'end':

Last commit solves it like this (test label with long text is positon: 'end':

The commit "Fix calculateTAdjust" doesn't fix the issue.

The commit "Fix calculateTAdjust" doesn't fix the issue.

Ok, another try.
Adjust the label position in 2 phases, first along the line, up to 25% from the desired end, then with slightly modified current method.

Ok, another try.
Adjust the label position in 2 phases, first along the line, up to 25% from the desired end, then with slightly modified current method.

Filename
Size
Change

dist/chartjs-plugin-annotation.esm.js
6.61 kB
+35 B (+1%)

dist/chartjs-plugin-annotation.js
6.73 kB
+41 B (+1%)

dist/chartjs-plugin-annotation.min.js
4.48 kB
-142 B (-3%)

Filename
Size
Change

dist/chartjs-plugin-annotation.esm.js
6.61 kB
+35 B (+1%)

dist/chartjs-plugin-annotation.js
6.73 kB
+41 B (+1%)

dist/chartjs-plugin-annotation.min.js
4.48 kB
-142 B (-3%)

@etimberg in my opinion, yes. You don't have errors because if the position is not start or end it will use center, without any issue.
Nevertheless who is using now left, right, top or bottom will have the label in the center, therefore I think it should be considered a breaking change.
Am I wrong?

@etimberg in my opinion, yes. You don't have errors because if the position is not start or end it will use center, without any issue.
Nevertheless who is using now left, right, top or bottom will have the label in the center, therefore I think it should be considered a breaking change.
Am I wrong?

@etimberg thats the reason I labeled this breaking.

@etimberg thats the reason I labeled this breaking.

@kurkle apologize for delay of my feedback but I had other stuff to do it.
But finally I had time to test it and it sounds working correctly!
Thank you very much!

@kurkle apologize for delay of my feedback but I had other stuff to do it.
But finally I had time to test it and it sounds working correctly!
Thank you very much!


[Desktop][Mobile] Create Post - cannot set visibility to DAY

env: staging
Steps:

Login
Go to Feed and add a new post
Select visibility DAY:

Save your post
Open Feed screen and scroll down to your post
Click View more and then edit
Visibility is displayed as Month:

Definitely a frontend issue during post creation (not edit) only:

I'll give this one a shot.

There's a lot of prop drilling going on here. Some of the passed props going into the onChange handlers are undefined. Have we committed to using useReducer or Context? The state handling could use a refactor here.

Hi @kylejvh haha no. State handling is an open discussion - I'll send some links in Slack if you'd like to contribute to discussion. For this issue, now, I guess get it working in line with mostly with the current approach around creating a post. Refactoring state handling plus general guidelines in approach is something we definitely need however.


OKD 4.7.0 Install fails on OpenStack with self-signed certificate

Describe the bug
openshift-install create cluster fails with the below reason
 ./openshift-install --log-level debug create cluster --dir='os-config'

DEBUG Still waiting for the Kubernetes API: Get "https://api.testos.example.com:6443/version?timeout=32s": dial tcp <IP_ADDRESS>:6443: connect: no route to host

I see 3 master nodes and a bootstrap node are created on the OpenStack
On the bootstrap node, I see the error below
[ 2799.651039] ignition[561]: GET https://<IP_ADDRESS>:13292//v2/images/f1b24dc8-dd3f-4f1f-8c9e-79552f541524/file: attempt #563
[ 2799.655185] ignition[561]: GET error: Get "https://<IP_ADDRESS>:13292//v2/images/f1b24dc8-dd3f-4f1f-8c9e-79552f541524/file": x509: certificate signed by unknown authority
M[K[[0;1;31m*[0m[0;31m*    [0m] A start job is running for Ignition (fetch) (46min 36s / no limit)
M[K[[0m[0;31m*     [0m] A start job is running for Ignition (fetch) (46min 37s / no limit)
M[K[[0;1;31m*[0m[0;31m*    [0m] A start job is running for Ignition (fetch) (46min 37s / no limit)
M[K[[0;31m*[0;1;31m*[0m[0;31m*   [0m] A start job is running for Ignition (fetch) (46min 38s / no limit)
M[K[ [0;31m*[0;1;31m*[0m[0;31m*  [0m] A start job is running for Ignition (fetch) (46min 38s / no limit)
M[K[  [0;31m*[0;1;31m*[0m[0;31m* [0m] A start job is running for Ignition (fetch) (46min 39s / no limit)
M[K[   [0;31m*[0;1;31m*[0m[0;31m*[0m] A start job is running for Ignition (fetch) (46min 39s / no limit)
M[K[    [0;31m*[0;1;31m*[0m] A start job is running for Ignition (fetch) (46min 40s / no limit)
M[K[     [0;31m*[0m] A start job is running for Ignition (fetch) (46min 40s / no limit)
M[K[    [0;31m*[0;1;31m*[0m] A start job is running for Ignition (fetch) (46min 41s / no limit)
[ 2804.653617] ignition[561]: GET https://<IP_ADDRESS>:13292//v2/images/f1b24dc8-dd3f-4f1f-8c9e-79552f541524/file: attempt #564
[ 2804.657767] ignition[561]: GET error: Get "https://<IP_ADDRESS>:13292//v2/images/f1b24dc8-dd3f-4f1f-8c9e-79552f541524/file": x509: certificate signed by unknown authority
M[K[   [0;31m*[0;1;31m*[0m[0;31m*[0m] A start job is running for Ignition (fetch) (46min 41s / no limit)

On the master nodes, I see it is trying to connect internal api vip(api-port ip address)
[ 2946.627582] ignition[562]: GET error: Get "https://<IP_ADDRESS>:22623/config/master": dial tcp <IP_ADDRESS>:22623: connect: no route to host
M[K[    [0;31m*[0;1;31m*[0m] A start job is running for Ignition (fetch) (49min 4s / no limit)

Version
# ./openshift-install version
./openshift-install 4.7.0-0.okd-2021-07-03-190901
built from commit af0c206a845eaa0d17efe4f1952d248406cdfdfe
release image quay.io/openshift/okd@sha256:66857f330c4b6199ce319c9b5b5ff3bd7ff3d4c75113cd3d33302216312d345f

How reproducible

Always(100%) reproducible
Log bundle
I have even added cacert to /etc/pki/ca-trust/source/anchors/ and executed update-ca-trust extract and also updated path in clouds.yaml as mentioned  in the doc https://docs.okd.io/latest/installing/installing_openstack/installing-openstack-installer-custom.html#installation-osp-describing-cloud-parameters_installing-openstack-installer-custom
After adding cacert to the installer node, install-config step is successful(before adding cert to the node, this step was always failing)
clouds:
  openstack:
    region_name: regionOne
    auth:
      auth_url: https://XXX.net:13000/v3
      project_name: XXXXX
      project_id: XXXX
      user_domain_name: Default
      project_domain_name: Default
      username: XXXXX
      password: XXXX
      cacert: "/etc/pki/ca-trust/source/anchors/ca.pem"

install-config.yaml
apiVersion: v1
baseDomain: example.com
compute:
- architecture: amd64
  hyperthreading: Enabled
  name: worker
  platform: {}
  replicas: 3
controlPlane:
  architecture: amd64
  hyperthreading: Enabled
  name: master
  platform: {}
  replicas: 3
metadata:
  creationTimestamp: null
  name: testos
networking:
  clusterNetwork:
  - cidr: <IP_ADDRESS>/14
    hostPrefix: 23
  machineNetwork:
  - cidr: <IP_ADDRESS>/16
  networkType: OVNKubernetes
  serviceNetwork:
  - <IP_ADDRESS>/16
platform:
  openstack:
    apiFloatingIP: <IP_ADDRESS>
    apiVIP: <IP_ADDRESS>
    cloud: openstack
    defaultMachinePlatform:
      type: m1.xlarge
    externalDNS: null
    externalNetwork: VN0065_FLOAT_111
    ingressVIP: <IP_ADDRESS>
proxy:
  httpProxy: <httpproxy>
  httpsProxy: <httpsproxy>
  noProxy: <noproxy>
publish: External
pullSecret: XXXXX
sshKey: XXXXXX

/cc @nrchakradhar

sorry, my mistake. 'cacert:' should be in the same level of auth.
I will close the issue now. if the issue reoccurs even after correcting it with the same issue, then I will reopen it.


python3.pkgs.hypothesis: build offline documentation

I wanted to build documentation for one package, but rabbit hole was
quite deep. Summary of commits:

python3.pkgs.hypothesis: build offline documentation
python3.pkgs.sphinx-codeautolink: init at 0.12.1
python3.pkgs.sphinx-hoverxref: init at 1.3.0
python3.pkgs.sphinx-jquery: init at 3.0.0
python3.pkgs.sphinx-notfound-page: init at 0.8.3
python3.pkgs.sphinx-prompt: init at 1.5.0
python3.pkgs.sphinx-tabs: init at 3.4.1
python3.pkgs.sphinx-version-warning: init at unstable-2019-08-10

Description of changes
Add sphinxHook into python3.pkgs.hypothesis derivation and package
new dependencies as necessary.
Things done

Built on platform(s)

[x] x86_64-linux

[x] Tested basic functionality of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Maintainer ping of packages involved: @SuperSandro2000

@happysalada Can you please take a look at this?

Thank you !


Sort nodes conditions before being compared

Problem:
The rancher nodes are always getting updated becuase the conditions
of them is always different from the nodes' in user cluster. It is
because the condition lists of them are compared without sortting.
Solution:
Sort the condition list for both kinds of node before comparing
them.
Related issue: https://github.com/rancher/rancher/issues/18759

LGTM


introduce notebook cleaning and linting scripts with an example

This partially resolves #409 .

two scripts for cleaning and linting notebooks are introduced
Makefile is modified accordingly
scripts are used on tutorial_i only for now. To pass lint, all imports are moved to the top of the file, and two function names are modified. Other changes are the result of auto-formatting.
nbqa is added to dependencies.

What is not covered in this PR:

implementing this for other notebooks
introducing a corresponding workflow
reason: we need to make sure we agree about these methods first

Once we are on the same page about this, I will add the workflow and work on other notebooks one by one, to cover the same notebooks as the ones tested in test_notebooks. This will most likely require manual revisions to notebooks and re-running them completely, so I prefer to do these in separate small PRs.

This looks good to me. One thing we might want to consider is just having make format and make lint run both regular code and notebook versions of the shell scripts rather than adding a new make command specific to notebooks.
@eb8680 , any thoughts?

To pass lint, all imports are moved to the top of the file, and two function names are modified. Other changes are the result of auto-formatting.

I haven't used nbqa before. Just so I understand, what part of the imports wasn't fixed by autoformatting? Does this mean running nbqa isort --check <filename> can still fail even if you run nbqa isort <filename> first?

Relatedly, I resolved this in the collab repo by adding autoflake --remove-all-unused-imports --in-place ... to the cleaning script. I assume we do not want to remove unused imports in modules as, for example, this is a bit annoying for modules that are WIP, but perhaps could be useful for notebook cleaning, as notebooks will be only added to the list once assumed done?

Yes, I think it would be a mistake to have make clean automatically remove unused imports. My preference is that we automate things that developers will almost never care about, like import orders or trailing whitespace, but avoid being too heavy handed beyond that.
Anyway, who would you like to review this @rfl-urbaniak ? I always find it confusing when there are two reviewers listed.

Sorry for being confusing. I wanted @eb8680 to approve the general strategy, as this is what would  be applied across all notebooks in the repo, and @SamWitty to approve the resulting changes to the notebook,

Sorry for being confusing. I wanted @eb8680 to approve the general strategy, as this is what would be applied across all notebooks in the repo, and @SamWitty to approve the resulting changes to the notebook,

Ok, thanks for clarifying. The changes to the notebook have my stamp of approval. @eb8680 , ball's in your court to review the broader PR.


Cannot pack OSERDES + OBUFDS together

As in the title. This happens when there is no connection between OSERDES.TQ and T input of the IOB. The connection in the fabric is hard wired so there shouldn't be any routing related issues. Probably an additional pack pattern is needed.

Solved in https://github.com/SymbiFlow/symbiflow-arch-defs/pull/1502


Huge increase of "high risk requests" out of nowhere

What version of React Native? 0.73.4
What version of React Native WebView? 13.7.0
What version of the library? 1.3.0
iOS/Android version?
Did the problem happen after updating React Native? no
Are you using the library for the first time? no

I have been using this library for years without issue.
Then out of nowhere starting November 15th approximately, the "high risk requests" went from a usual 0.5% to litterally 75%!!
which blocks almost everyone from signing up in my app.
What could explain this issue?
any help would be super appreciated

My company app is facing same spike issue starting on 16th November sgt. But we are using react-native-webview. I am now searching around and found this github issue and wanted to share my issue too.

What version of React Native? 0.73.4
What version of React Native WebView?  0.74.6
recapatcha version? v3

I am wondering are there any google forum post that reported this issue.

What version of React Native? 0.73.4
What version of React Native WebView?  0.74.6
recapatcha version? v3

ok so upgrading recaptcha won't fix the issue;
you're on the same RN version as me
your webview version is probably wrong though, are you using "react-native-webview" as well?
as for google forum post, didn't find any yet, but first one who finds anything shares it here alright?

 "react-native-webview": "11.26.1",
the version is incorrect? how so? 😮

ya i am using  "react-native-webview": "11.26.1",. I corrected the comment.

Hello guys, thank you for the feedback.
I'm currently not working on a project that uses reCAPTCHA, so I'm unsure about the blocks. However, I will provide any updates if I have them.
In the past, the blocks I encountered were related to multiple devices solving captchas using the same internet connection (Wi-Fi), which led Google to add the IP address to a sort of "blacklist."
Just for the record reCAPTCHA v2 and v3 are completely different products.

thank you for your input @douglasjunior
but in my case, it's thousands of users everyday from every parts of the world that faces the issue.
I have like 5000 daily new subscription that goes through this captcha, and 50% of them are failing because of a score too low.
so that can't be the IP blacklist issue, when they email asking for help they are indeed genuine users

+1. I have been using this package for approximately 1.5 years and updated react-native-webview to version 13.12.1 three months ago. However, this issue started occurring about a week ago. Our company operates white-labeled food ordering applications, and this problem is significantly impacting user sign-ins across multiple merchants.
A workaround or solution would be greatly appreciated as this is causing disruptions for many users.

According to the latest reports on this issue, the problem started without anything being changed in the lib or webview.
This makes me think that some changes on Google's side increased the rejection rate.
Therefore, I don't see anything we can do in relation to the lib to solve this.

You're right @douglasjunior , in that case does any of you know which Google's service / contact we should reach out to to let them know about it?
if we all contact them for the same it might make them realize something legit is going on

Encountering this issue on our end too. I was thinking in a normal website, the reCAPTCHA script is added as soon as the page is loaded and reCAPTCHA may already start gathering information about the device / user.
When used in react native inside a web view however, we load the reCAPTCHA script just in that moment (few seconds max) we're generating the token.
I was thinking if there's a way for us to move the reCAPTCHA script on screen load and perhaps keeping it there without generating a token and then just call the grecaptcha.execute() function later on when user submits the button may improve our stats?
We haven't tried it yet and would love some input on this.


POST http://api.ocr.space/parse/image 403 (Forbidden)

Hello when I launche the bot there is this error
POST http://api.ocr.space/parse/image 403 (Forbidden)

Have you signed up at ocr.space for a free account? You must do that and use the API key they give you in the code.
Sent from my iPhone

On Jul 6, 2017, at 10:08 AM, buxxypooh<EMAIL_ADDRESS>wrote:
Hello when I launche the bot there is this error
POST http://api.ocr.space/parse/image 403 (Forbidden)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I'm 99% sure this is the issue.  If this doesn't resolve your issue though, please re-open this issue and let me know.


White screen after iOS swipe to go back from a PDF

[x] I have read the Getting Started section
[x] I have already searched for the same problem

Environment

Technology
Version

Flutter version
3.16.8

Plugin version
6.0.0

Android version

iOS version
17.2

macOS version
14.2.1

Xcode version
15.2

Google Chrome version

Device information:
iPhone SE 2 gen but all iPhone got the issue.
Description
Expected behavior:
I should be able to go back by swipe current PDF page.
Current behavior:
User swipe the PDF page and wait a bit, then the webview is reloaded and a white page replace it. If user put the app in background and resume it, the white screen disappear. WEIRD.
I think the 'window' created automatically by InAppWebview when detecting a PDF is maintained in foreground despite the fact that it is not alive, putting the app in background and then in foreground seems to refresh it.
Steps to reproduce

On iOS :

Run the code bellow
Scroll down the page to see "Technical Documents"
Expand "Technical Documents"
Expand "Product Documents"
Click on the download icons
See the PDF
Swipe to go back (from left to right)
PDF is no longer visible
Wait a bit
White screen is displayed

Note that on Android : nothing happen when user click on the icon because it trigger the onDownloadStartRequest.
@override
  Widget build(BuildContext context) {
    return Scaffold(
      body: SafeArea(
        child: InAppWebView(
          initialUrlRequest: URLRequest(
            url: WebUri(
                "https://www.denmans.co.uk/den/root-category/Solar-PV/Panels/Trina/Trina-415W-Vertex-S-Full-Black-Solar-Panel/p/2501523239"),
          ),
          initialSettings: InAppWebViewSettings(
            allowsBackForwardNavigationGestures: true,
            isInspectable: true,
            javaScriptEnabled: true,
          ),
        ),
      ),
    );
  }

Images
https://github.com/pichillilorenzo/flutter_inappwebview/assets/37028599/1f0fe8c6-6afa-4e48-aa94-9123679851c3
Stacktrace/Logcat
Nothing in logs.

you can try allowsBackForwardNavigationGestures: true -> false

I need to react when navigation occurs to decide based on parameters. I can't dynamically change the WebView settings as far I know (changing didn't work, WebView needs to be recreated)


Add field for descriptions in target

This also updates the listTargets command to output the description received from the service
@conniey
Fixes #287.

LGTM :+1:


image links are broken for dashboarding/aws-supporting-services readme.md

see: https://github.com/Dynatrace/snippets/tree/master/product/dashboarding/aws-supporting-services
all images embedded into the readme are broken.

fixed with: https://github.com/Dynatrace/snippets/pull/23


laradock folder empties when I switch git branches

I'm working on a pre-existing Laravel project hosted on github and I've set up my development environment with laradock. I cloned the laradock repo on my project root using
git submodule add https://github.com/LaraDock/laradock.git
When I switch to a different git branch however the laradock folder is emptied. I run
git submodule add https://github.com/LaraDock/laradock.git again and get the message:
A git directory for 'laradock' is found locally with remote(s):
  origin    https://github.com/LaraDock/laradock.git
If you want to reuse this local git directory instead of cloning again from
  https://github.com/LaraDock/laradock.git
use the '--force' option. If the local git directory is not the correct repo
or you are unsure what this means choose another name with the '--name' option.

So I run with the --force option and it returns. But surely I shouldn't have to do this every time I change branches?
Thanks

I deleted everything and started again.  I think this may have occurred because I had added laradock/ and .gitmodules to .gitignore.


Bugfix Issue #190 - Fixed seeds only within combinatorial batch

Fix for Issue #190 - it seems to be working for me, but probably not the cleanest solution.

Merged, thank you.


Bipartite network click behavior

closes #923
TODOs

[x] Add click handling
[x] Implement selectedNodes logic
[x] Implement activeNode logic
[ ] Style "NodeActions" menu

Notes
I opted to kick the proverbial DRY can down the road:

Rules about node selection (at most one per partition) are implemented directly in BipartiteNetwork, rather then in the visualization.
NodeActions are implemented directly in BipartiteNetwork, rather then generalized in NodeWithLabel.

It's not entirely clear how this should all be generalized and abstracted. For example, we might want our own Graph component that encapsulates the logic and styling related to node click actions. If we know it will be useful in the foreseeable future, then I can abstract this more.

Here is a screenshot of the latest:

Some questions I have:

Is the styling of the menu too subtle? Eg, should the background be something other than white?
Should the edges of selected nodes be highlighted?

Here is a screenshot of the latest:

Some questions I have:

Is the styling of the menu too subtle? Eg, should the background be something other than white?
Should the edges of selected nodes be highlighted?

Hello! This is looking awesome!
I've only done a quick look so far but can be back later today to go more in depth. At least I can respond to your questions!

For example, we might want our own Graph component that encapsulates the logic and styling related to node click actions. If we know it will be useful in the foreseeable future, then I can abstract this more.

I can say a bit about the nearish term future (2024). I expect there will be one more network viz that is a much prettier version of what is shown in the Plots/Network stories. We'll end up with some clicking something-or-other on the nodes, likely at least a linking out function like we have here in the bipartite network. That's expected during the summer probably. So if you're having fun, feel free to abstract, if you need to move on, don't worry about it :)

Is the styling of the menu too subtle?

Probably a little too subtle, but I like where it's going. I think this is worth a post in the styling group channel

Should the edges of selected nodes be highlighted?

Yes please! We think the best way to do this is actually by graying out any edges that is not coming out of a selected node. Something like

More soon! But hope this at least answers some questions!

Very helpful, thanks!
Regarding the click menu, I was thinking I should use the same styling as SingleSelect:

It's going to take some refactoring, to be able to use the "SingleSelectMenu" (naming is hard), without the button. I'm hoping that styling will be adequate in the context of the network.

Nice that's a good idea. Can menu items have icons in the SingleSelectMenu?

Can menu items have icons in the SingleSelectMenu?

Yes: https://github.com/VEuPathDB/web-monorepo/blob/a856efcc07dc1d006eee0fe10cd19e232b807fab/packages/libs/coreui/src/components/inputs/SingleSelect.tsx#L9

This branch is now in shape for a demo. The code is a bit of a mess, and I will clean things up if this is approved.
Particularly, I would like to:

[ ] Move the actions dropdown to be a part of NodeWithLabel
[ ] Render the "gene list" option as a link, rather than a button
[ ] Clean up styling/css

Here is a screencast showcasing the latest:
Screencast from 2024-03-29 08-27-36.webm

Another screenshot showcasing the changes on plasmo (note the target site (qa.hostdb) at the end of the video is down).
Screencast from 2024-03-29 08-34-30.webm

some comments they might be premature.. ignore if so..
1- would be nice to have some indication that you should mouseover the node to get some options..
2- the popup could say at top "(click to select)" ?
3- selecting the node: i would have expected to stay when clicking a second node.. (if this is for scatterplot), maybe we plan to enable ctrl-click

Particularly, I would like to:

[ ] Move the actions dropdown to be a part of NodeWithLabel
[ ] Render the "gene list" option as a link, rather than a button
[ ] DRY up node actions for wgcna datasets
[ ] Clean up styling/css

Given that we are still in "design" mode for interactivity, I am not going to spend time cleaning things up. I don't think it's worth the effort, since much of this might be replaced by a different UI.

I added a banner about interactivity:

I'm open to suggestions.

Just to follow up on my comment about the edges, it's possible it may be as "simple" as sorting the links so that the ones coming from the highlighted nodes are at the bottom. One could add the sort to the construction of linksWithCoordinates and even modify the gray color in that array as well. Food for thought

One thing i want to play with is if we can get the highlighted node's edges to render on top of all the others. Not crucial for this PR since it's adding so much value already, but something we should figure out

I thought about this, too. I think we have to reorder the links such that the highlighted ones are at the end of the array.

One thing i want to play with is if we can get the highlighted node's edges to render on top of all the others. Not crucial for this PR since it's adding so much value already, but something we should figure out

I thought about this, too. I think we have to reorder the links such that the highlighted ones are at the end of the array.

I went ahead and did this.


Open Source Release

The README states:

The project will be open-sourced in the near future.

Git blame indicates this was written four years ago.
Are there still plans to open source qlik-cli?
My use-case is that I want to understand how the qlik app unbuild command works.

I see you removed the promise to open source the CLI in this commit: dece399067b11cad6bf443fedc4fe8735ca0478d, which is disappointing.
When I opened this issue, I was hoping that access to the CLI source code would help me to better understand how to use the REST API to export Qlik apps as JSON. This would allow me to achieve similar functionality within a custom Python script. (We were trying to find a way to backup apps as JSON to git.)
I assume it uses something like the following to get the load script:

https://qlik.dev/apis/rest/apps/#get-v1-apps-appId-scripts-id

However, it would be nice to see exactly what the CLI uses, and how it converts the rest of the app to JSON.

Hi @daviewales, the qlik app unbuild command uses the JSON-RPC API (QIX) for exporting the different assets in an app to JSON. Unfortunately I don't think you can achieve the same using only the REST API today.
It is possible for you to see exactly what is being sent/received over the websocket if you add the --traffic flag to the unbuild command.

Yep, as @wennmo says, we don't have other ways of extracting via REST components other than the whole binary, and the app script at the moment.
We do have roadmap in this area and I'm hoping we can start to offer app object definitions over REST in 2025, and perhaps a helper function to support unbuilds irrespective of platform.

Thanks. That's helpful.


Add support for PS5 etaHEN direct install

Since etaHEN 1.7b direct package installation similar to RPI on PS4 is possible.
https://github.com/Gkiokan/ps4-remote-pkg-sender has added the possibility to send to PS4 fpkg to PS5 etaHEN.
Could you consider adding support for etaHEN into PS4RPS?

This would be awesome!