Error kube-scheduler image registry url

when exec kubectl apply -f config/kube-scheduler.yaml cmd，can't pull image。
and docker pull registry-vpc.cn-shanghai.aliyuncs.com/acs/kube-scheduler-amd64:v1.11.2
report:
^[[OError response from daemon: Get https://registry-vpc.cn-shanghai.aliyuncs.com/v2/: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)

modify registry addr，can access
docker pull docker pull registry.cn-hangzhou.aliyuncs.com/acs/kube-scheduler-amd64:v1.11.2

Yeah, it's a bug. If you have time, please PR to fix it. If not, I can fix this by myself.


Fix graphiql react issue with setting tabs title

A small regex fix with additional tests to address #2949.
Additionally, I visually tested this out by modifying renderExample.js to pass in default tabs.
Asking for review from @thomasheyenbrock (touched this code most recently) and @n1ru4l (originator).

@jonathanawesome did we not want a changeset for this bugfix?


Readme changes-Admin required etc.

I discovered that github-changelog-generator must be installed as an administrator on Windows 10 or it won't work. It also must be run as an administrator. I also found the path has to be updated, so I have directions for that.
With that, I started a troubleshooting page. If you don't want such a page, let me know.

Thanks for documenting!

A Troubleshooting document is a great addition :hearts: :yellow_heart: :green_heart: :blue_heart: :purple_heart:
A Troubleshooting document could have named sections
Several sections of text from the README could be evicted into sections of the Troubleshooting document
The current text refers to situations which Windows Ruby users in general have to deal with, not with project-specific things. That Troubleshooting document could include hyperlinks to existing Windows + Ruby documentation of these issues. E.g. StackOverflow threads, blogs, random Digital Ocean documentation pages

Hope this helps!

I think it's ready to merge for now. Let me know if I missed anything.

Hi @aredshaw ! Thanks for this :)
Can you please:

Rebase your PR on the latest master
Squash the commits in a single one

Thanks!

For the Windows platform you should mention for troubleshooting.

Temp folder must be created as tmp for github-changelog-logger cache and log files root drive/partition like C:\
tmp must exist on the same drive or partition that github_changelog_generator -u github_username -p github_project is executed on.

Closing, stale

@aredshaw  Feel free to reopen the issue if you still want to contribute.
@ferrarimarco I'm also wondering to move this things to wiki, and create new FAQ section
So we can migrate it there just in case (as well ass collect there most common questions). I believe it will simplify supporting the project.

I'm not a big fan of GitHub wikis, because they disperse the content :(


Reuse ssh-keys for non-critical-infra

Creates the infra key list and migrates hetzner-01 to run with it.
The wrong keys were deployed for me, so I had to access the host using the keypair I use for GitHub.
Fetching keys from GitHub is not great for key hygiene and did in fact cause a hash mismatch on Julien's keys.
@JulienMalka Please set up keys in ./ssh-keys.nix, deploying all 14 keys from GitHub feels wrong.

You're right, it's better this way


Can't run it on Tor Network

Hello, I have installed this script successfully, But when It comes to run out side of localhost,  the website opens properly, but it shows "disconnected" status.
How can i fix it?

Have you tried enabling the port 3001 in your firewall?
Maybe you have to forward the port 3001 in your router settings?


recent_view: Catch errors in trying to get message from id.

This helps keep the app working and avoids functionalities like insert messages from breaking when we don't the message id cached which ideally we should have.

Merged, thanks @amanagr!


How to share Fonts used in flutter with Native Code

I have a build a flutter plugin and I want to use the font used in the app to be applied within my plugin
Is there a way to achieve this

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact descriptions what happens, logs and the output of 'flutter doctor -v'  please.
All system setups can be slightly different so it's always better to open new issues and reference related issues.

op is talking about this plugin
https://github.com/PonnamKarthik/FlutterToast
he wants to pass font as a style to fluttre.jar I suppose.


[CI] Cancel builds on subsequent pushes

If a branch or a pull requests receives successive pushes in a short duration of time, Jenkins may be running multiple builds. Only the latest build should be carried out and the others cancelled, to conserve CI resources.

I just trying pushing two commits in a row, and the fix is working. The previous build was cancelled with message
Superseded by xgboost/PR-6011#4

I also enabled the equivalent setting in AppVeyor as well. The feature is called "Rolling Builds".


Fixes #31: ESLint JSON schema contribution should work on .eslintrc.json

kasvtv:feature/hideAutoFixedIssues

0.10.11-fixes

@Sebastianokunkelo I am closing this PR since it looks outdated to me. Please ping if I am missing something.


Files with boolean DICT fields incompatible with other tools

I have written files using schema as follows

type ParquetStats struct {
	PresetID   int32 `parquet:"preset_id,dict"`
	ID         int32 `parquet:"id,dict"`
	TotalScore int32 `parquet:"total_score,dict"`
	TotalCount int32 `parquet:"total_count,dict"`
	IsCharc    bool  `parquet:"is_charc,dict"`
}

now other tools for reading parquet files complain
parquet-tools (Python): OSError: Not yet implemented: Dictionary encoding not implemented for boolean type.
tabiew (Rust): parquet: Not yet supported: Decoding Boolean "RleDictionary"-encoded required parquet pages not yet supported
duckdb (C++) goes even further (almost insulting :rofl: ): Invalid Error: Dicts for booleans make no sense

Hello @dolzenko, thanks for reporting.
I believe the issue is that the Go struct instructed parquet-go to create a dictionary because it has the dict tag on the field. Is the ask that parquet-go should refuse to create those files because most libraries don't support it?


Create a New README.md file for Improved Contributions Guidelines.

The README.md file is just normal , You can Improve it by add website preview and contributions guidelines to it.

Hey Kanishk, if we add steps for contribution to the contribution guidelines section , will it be appropriate??

@Mr-Sunglasses I want to contribute to this. Could you assign this to me.

@GJS2162  - https://readme.so/ use this site for creating README.md
We want README.md like this https://github.com/SatyamX64/space_empires

Hey Kanishk, if we add steps for contribution to the contribution guidelines section , will it be appropriate??

So @Ujjwal-soni98 We want to make it beginner friendly So for now we are adding everything in README.md

@GJS2162 I have accepted your PR for the contributions in README.md.
It is good that you can add the website preview in it.

great work @GJS2162 , ✌🏻


[RTC-230] Net condition simulation POC

POC: right now, the test doesn't check anything.
Current issues:

The container images are massive -- server: 500MB, browser: 2GB
Several hacks here and there -- lots of room for improvement
Needs a test scenario, perhaps a more sophisticated and realistic one than simply "50% chance to drop each packet" (other options: here)
Needs to be integrated with CircleCI

Resources for future reference:

Running multiple netem commands
Playwright on Alpine
Playwright browsers manual installation -- note that this installs different versions of browsers than required by Stampede
Playwright deps (?), see also this issue
Playwright container Dockerfile -- again, different browser versions

@Rados13 Well, depends on how you look at it 😄... It's unfortunate, but we'd need another synchronisation point to know when to stop/kill the netem command. This is what the script comment was referring to:
# The netem command will return an error when a container is stopped before the packet loss duration
# is up. This means we either need to kill it (and know when to do that), or ignore the error

It's possible that this issue could be resolved with running the netem cmd as a job, but I fear that it would make the script even more convoluted and confusing.
Alternatively, we could simply 2>/dev/null the command, but that could possibly obscure other issues, should they occur.
I sincerely hope a better solution can be found once we rewrite the test controller in Elixir...


Write example DAG using Panglia dataset to support Astronomer's official docs

Context
@jwitz has been writing the official Astronomer documentation at:
https://github.com/astronomer/docs/pull/477/files
And he asked us to write a transform example using the Panglia dataset.
Acceptance criteria

Create an example DAG which has transform and uses the Panglia dataset
Share it with @jwitz in the Github thread

This is done.


Can nativeaot be supported

Can nativeaot be supported

Maybe; try cloning source and removing this property from Webserver.cs: https://github.com/jchristn/HttpServerLite/blob/cb5476ea7aa107bd4d65b75a580dbc315cd9af7e/src/HttpServerLite/Webserver.cs#L143

https://learn.microsoft.com/en-us/dotnet/core/deploying/native-aot/

Hi @williamlzw please see my response to the issue of the same name you filed on Watson Webserver.  Seems like it could work, however, routing would not, and there may be other incompatibilities that would need to be addressed.


Problem with navbar

Hello, I have included a navbar on my page (Still in progress) but it doesn't open the menu on mobile phones or small screens. Here the link to my page (It's a private server so maybe it isn't available all the time): http://estoesunaprueba.ddns.net/
Thanks for help!

Seems to work for me.

Due to lack of response, this is being closed.


doc: fix various typos

This is so awesome 🤩 Thanks a bunch for all these fixes @StevePorter92! I've added in some more of the same ones from other parts of the docs 👍🏻
We do our best to use American English spelling, so unfortunately I had to roll back the 'u's in behaviour and flavoured 😔This also lead me to find a bunch more of the British English version that had slipped through in past additions, so thanks for that! 🙌🏻

No worries at all! Glad to help 😄


Fix inlining failures when using bazel

Some of the inline statements do not appear in the compiler output when the go compiler is invoked through bazel.
This code change makes gcassert inspect the object files directly to check if a function call that must always be inlined was ever not inlined (when using bazel).

@yuzefovich @jordanlewis please take a look

Can you say a bit more about this? Does it mean that direct go invocation produces lines like was inlined for some functions whereas bazel invocation doesn't?

Exactly, for some function calls we do not get inlining call to ... in the compiler output even though the call is inlined according to the object code (which ofcourse is the most trusted way to check if a call is inlined).

Oops, just realized that a couple of comments that I had in response to your previous comments are now removed because I marked them as "resolved" (I'm not used to using the github review modal :/). (Trying to reproduce those.)

I like your change for the error / warning when no non-inlined function were found, thanks!
I'm satisfied with the warning / error in terms of change to the compiler output when Go is upgraded. Including a step in the runbook sounds good to me, but I'll defer to you whether it's worth doing so.

I wrapped a few long lines and addressed the other nits. I will add the new runbook step in cockroachdb/cockroach#103471. Thanks for the quick review!

Will defer to Yahor for the review, please keep in mind that this tool should remain usable outside of Bazel as well.


Build and release through GitHub workflows

Applying this PR will change the build and release process. It drops Travis in favour of GitHub workflows. It follows the process as described on https://github.com/sbt/sbt-ci-release. Previously it would make a release on every commit, now it will only release when a new version tag is consciously pushed to the repository.
This does require @mefellows setting up four "secrets" in the repo for releasing on Sonatype, which he is hopefully willing to do. :)
Also refactored and modernized the build a bit.

This does require @mefellows setting up four "secrets" in the repo for releasing on Sonatype, which he is hopefully willing to do. :)

Absolutely! Moving to GH actions makes a lot of sense, we did a similar thing for the repos at pact-foundation.
This is done (but also, I've likely messed something up, so let me know if things aren't right):

It's not working yet, if the secrets are set up correctly then maybe the public key is not submitted yet to a key server? This is described here: https://github.com/sbt/sbt-ci-release#gpg.

Ah, sorry. I'll have to look at it. The public key should be there, because the current process uses them (I think).
I tried a key lookup at ubuntu but it wasn't there, despite my old notes showing I uploaded to the 5 servers in the guide.


Finish the implementation of the update mechanism.

Implement PVBUMP, UPIEND and UPIEC rules
Set the update proposal time to live to ppUpdateImplicit.
Use named field puns in the interface more consistently.
Add an environment to Cardano.Chain.Update.Validation.Registration
Use explicit exports in the update modules.

Closes #189.

bors r+


Added c_api & tests

Description
Added MAP data type to c_api
Added tests to MAP data type
Fixes # (issue)
https://github.com/kuzudb/kuzu/issues/4148
Contributor agreement

[ ] I have read and agree to the Contributor Agreement.

The test cases are not enough. You should also add value tests to make sure that a dict returned as query result can actually be used in C API (i.e., you can read from it).

Also, I do not think the implmentation is correct. Reading from MAP should be done with NestedVal. Please refer to https://github.com/kuzudb/kuzu/blob/fae65c679902ea73721784378e64b13421ff237a/tools/python_api/src_cpp/py_query_result.cpp#L280-L289

Also, I do not think the implmentation is correct. Reading from MAP should be done with NestedVal. Please refer to
https://github.com/kuzudb/kuzu/blob/fae65c679902ea73721784378e64b13421ff237a/tools/python_api/src_cpp/py_query_result.cpp#L280-L289

I think that it is already done with NestedVal inside of the called function kuzu_value_get_list_element. The added test seems to be working fine aswell. Please let me know if its OK.

Also, I do not think the implmentation is correct. Reading from MAP should be done with NestedVal. Please refer to
https://github.com/kuzudb/kuzu/blob/fae65c679902ea73721784378e64b13421ff237a/tools/python_api/src_cpp/py_query_result.cpp#L280-L289

I think that it is already done with NestedVal inside of the called function kuzu_value_get_list_element. The added test seems to be working fine aswell. Please let me know if its OK.

I don't think you called kuzu_value_get_map_field_name in the test case. My expected behavior is that kuzu_value_get_map_field_name returns audience1 and kuzu_value_get_map_field_value returns a value of 33. The user SHOULD NOT need to call another kuzu_value_get_struct_field_name or kuzu_value_get_struct_field_value to read the key or value from the map.


ignore IML files again

IML Files are not crossplatform safe and should be excluded per Jetbrains. From a support request that I had with them. I've also had issues with paths in these file being OS Specific (meaning the windows path is different from the OS X and Linux). IML files are not currently intended to be committed.

Please vote for this issue in our tracker: https://youtrack.jetbrains.com/issue/IDEA-150283
In IDEA 2016.3 version there has been related fixes to this problem: https://youtrack.jetbrains.com/issue/IDEA-161632 You could try if it works better for you using the latest version from https://confluence.jetbrains.com/display/IDEADEV/IDEA+2016.3+EAP
Also, please note that if you are using Maven to manage project structure and dependencies it is not required to version module .iml file because they are regenerated by IDEA when you synchronize project settings with Maven by re-importing the Maven project.

Also from that conversation is  suggestion allowing easier reimport

Why can't the system just say "iml files missing, detected maven project, reimport?"

We have created an enhancement for this, please vote for this request in our tracker: https://youtrack.jetbrains.com/issue/IDEA-164299 . Thank you for your feedback.

@xenoterracide - Got this resolved on gitignore.io - https://www.gitignore.io/api/intellij%2Biml

@xenoterracide thanks for the context, but their official documentation currently has this in the first section:

Here is what you need to share:

All the .iml module files that can be located in different module directories (applies to IntelliJ IDEA)

You may consider not to share the following:

.iml files for the Gradle or Maven based projects, since these files will be generated on import

Until it's clear which .iml files can be ignored, and if there's a folder format that we can specify to cover both of these cases, or if the documentation gets updated, I'm reluctant to add a * rule for this.

Closing this out due to inactivity


You must enter a number to go through the menu

Sorry but im not sure how i can do this, i type 7 or 1 or 3 and press enter, it is not working

Can you tell me :

What version of the plugin do you use
What version of Spigot do you use ?
What other plugins do you use on your server ?

1.4.2
I am using the latest craftbukkit-1.10.2-R0.1-SNAPSHOT-latest
Casino slots, CS-CoreLib ,EssentialsX , EssentialsXSpawm, Grief Protection, MobCash, Orebfuscator, Permission Ex, ProtocolLib,RankPrefix,titlewelcomemessage,Vault, worldedit

I'm currently running some tests right now. Can you try to update the version of the plugin to 1.5.0 ?
https://www.spigotmc.org/resources/command-signs.10512/

Hmm, seems weird. I download the 1.5.0 but when i go in and type in /commandsign version, it still display 1.4.2.

Perhaps my mistake... I often forget to change the version in the command...

Okay,
I've tried all of your plugins one by one with Craftbukkit 1.10.2,
it seems it comes from CS-CoreLib / RankPrefix (I'd say RankPrefix but I can't be sure as it depends from CS-CoreLib)

Noted and thanks for the effort


Name supplied when creating a master is ignored

I specified a name at the CLI prompt, but it looks like a name was auto-generated and used instead.

Yes, the hostname is auto generated, the name you give during creation will be used in the cli's configuration as the master name.
The same thing happens with all providers, but maybe it should be changed at some point.

When I list masters, the auto-generated name is printed.

Closed by #34


Colors in console

Hi, thank you for this library.

How easy would it be to add colors to distinguish messages in the console?

hi David.  You could easily add a ColorConsoleAppender by extending AbstractAppender and overriding the write method with colorization.  There is an example of this (kind of) in the examples folder.  Just look for json-appender.js and follow that pattern.


feat(#367): Fix PHI Printing in 'spring-fat' Integration Test

In this PR I fix the problem with PHI printing errors in 'spring-fat' integration test.
Since most of the bugs went from jeo-maven-plugin, we can just update it to fix all the bugs in PHI printing here.
Closes: #367

PR-Codex overview
The focus of this PR is to update the jeo-maven-plugin version from 0.5.1 to 0.5.3 in multiple modules.
Detailed summary

Updated jeo-maven-plugin version from 0.5.1 to 0.5.3 in various pom.xml files.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@rultor merge

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here

@volodya-lombrozo Great work on your contribution! 🌟 You've earned +5 points: +25 base, adjusted for review (-15), comments (-5), and code volume (-10), with a +10 bonus. Your dedication is appreciated! Keep the momentum going. Your current balance: +231. Looking forward to your next submission!


Query: Use discriminator type to create the discriminator constant values

Resolves #7359
Whenever we make comparison of discriminator using EF.Property the property expression is generated to be null-able type. If the value is non-nullable type (like int) then it throws exception due to strong typing of Expression.Equal. Fix is to create the constant for value of type of the property expression to avoid mis-match.
It surfaces in materializer for shadow properties. For CLR property the is operator in predicate would throw exception.

:shipit:


Add NDT7 Speedtests

We should add the ndt7 tests.
ndt7-client requires go >= 1.12; Ubuntu 18.04 is 1.10 by default,
so check available versions.
Then per go instructions here, download install.
wget https://golang.org/dl/go1.16.3.linux-arm64.tar.gz
tar -C /usr/local -xzf go1.16.3.linux-arm64.tar.gz

Then install the ndt7-client per these instructions
git clone https://github.com/m-lab/ndt7-client-go.git
export GO111MODULE=on
cd ndt7-client-go/
go get ./cmd/ndt7-client

In my bashrc, I put
export GOPATH=~/.bin/go/
export PATH=$PATH:/usr/local/go/bin:~/.bin/go/bin

Then the test is just
ndt7-client -format json -quiet

The output is json, so this should be "trivial" to add in the python .
I don't have time to do this for a week or so, since I'm not as confident with the build system.  @ggmartins, if you could incorporate the ndt7-client, I'm happy to add the python.

I can take that one. Same scheduling as speedtest, just a different time? we want the tcp retransmission parsed as well, right?

Yes, definitely grab the TCP.  I actually just tested ndt7 on tigerteam, and that is actually working OK despite the kernel vesion.  We should just use their infrastructure, I think.


Fix deprecation warning in field.py

Using collections.Iterable instead of collections.abc.Iterable was raising the following warning:
DeprecationWarning: Using or importing the ABCs from 'collections' instead of from
'collections.abc' is deprecated, and in 3.8 it will stop working

I'm assuming this will fail on Python 2, but there is #664


Update typing after Vue3 migration due TS version bump

Description
To ease the migration, every TS component that required major efforts has been excluded by the check.
Reintegrate typechecking by correcting all the issues.
Example commit: https://github.com/rancher/dashboard/pull/9171/commits/09a3e9a898d4b984e1e86dc6dc089f31179db8f3

[x] #11977

All the @ts-nocheck have been removed, can't find other related PR/issues.


CRC32 for Power PC and Unit Testcase and Functional test fixes

Changelog category (leave one):

New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Added new CRC functions for POWER
Fixes WeakHash32 Unit testcase failure on Power
Fixes ngram FT testcase failure (01016_simhash_minhash.sql , 00951_ngram_search, 00909_ngram_distance )

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

[root@ch-power-build ClickHouse]# ./tests/clickhouse-test 00951_ngram_search
Using queries from '/root/Clibmouse/ClickHouse/tests/queries' directory
Using clickhouse-client as client program (expecting split build)
Connecting to ClickHouse server... OK

Running 1 stateless tests (MainProcess).

00951_ngram_search:                                                     [ OK ]

1 tests passed. 0 tests skipped. 5.55 s elapsed (MainProcess).
Won't run stateful tests because test data wasn't loaded.
All tests have finished.
[root@ch-power-build ClickHouse]# ./tests/clickhouse-test 00951_ngram_^C
[root@ch-power-build ClickHouse]# ./tests/clickhouse-test 00909_ngram_distance
Using queries from '/root/Clibmouse/ClickHouse/tests/queries' directory
Using clickhouse-client as client program (expecting split build)
Connecting to ClickHouse server... OK

Running 1 stateless tests (MainProcess).

00909_ngram_distance:                                                   [ OK ]

1 tests passed. 0 tests skipped. 5.30 s elapsed (MainProcess).
Won't run stateful tests because test data wasn't loaded.
All tests have finished.

[root@ch-power-build ClickHouse]# ./tests/clickhouse-test 01016_simhash_minhash.sql
Using queries from '/root/Clibmouse/ClickHouse/tests/queries' directory
Using clickhouse-client as client program (expecting split build)
Connecting to ClickHouse server... OK

Running 1 stateless tests (MainProcess).

01016_simhash_minhash:                                                  [ OK ]

1 tests passed. 0 tests skipped. 8.10 s elapsed (MainProcess).
Won't run stateful tests because test data wasn't loaded.
All tests have finished.

[root@ch-power-build src]# ./unit_tests_dbms --gtest_filter=*Hash*
Note: Google Test filter = *Hash*
[==========] Running 47 tests from 5 test suites.
[----------] Global test environment set-up.
[----------] 27 tests from WeakHash32
[ RUN      ] WeakHash32.ColumnVectorU8
[       OK ] WeakHash32.ColumnVectorU8 (5 ms)
[ RUN      ] WeakHash32.ColumnVectorI8
[       OK ] WeakHash32.ColumnVectorI8 (4 ms)
[ RUN      ] WeakHash32.ColumnVectorU16
[       OK ] WeakHash32.ColumnVectorU16 (1029 ms)
[ RUN      ] WeakHash32.ColumnVectorI16
[       OK ] WeakHash32.ColumnVectorI16 (1032 ms)
[ RUN      ] WeakHash32.ColumnVectorU32
[       OK ] WeakHash32.ColumnVectorU32 (1021 ms)
[ RUN      ] WeakHash32.ColumnVectorI32
[       OK ] WeakHash32.ColumnVectorI32 (1023 ms)
[ RUN      ] WeakHash32.ColumnVectorU64
[       OK ] WeakHash32.ColumnVectorU64 (1011 ms)
[ RUN      ] WeakHash32.ColumnVectorI64
[       OK ] WeakHash32.ColumnVectorI64 (1013 ms)
[ RUN      ] WeakHash32.ColumnVectorU128
[       OK ] WeakHash32.ColumnVectorU128 (1120 ms)
[ RUN      ] WeakHash32.ColumnVectorI128
[       OK ] WeakHash32.ColumnVectorI128 (1181 ms)
[ RUN      ] WeakHash32.ColumnDecimal32
[       OK ] WeakHash32.ColumnDecimal32 (1040 ms)
[ RUN      ] WeakHash32.ColumnDecimal64
[       OK ] WeakHash32.ColumnDecimal64 (1015 ms)
[ RUN      ] WeakHash32.ColumnDecimal128
[       OK ] WeakHash32.ColumnDecimal128 (1179 ms)
[ RUN      ] WeakHash32.ColumnString1
[       OK ] WeakHash32.ColumnString1 (1067 ms)
[ RUN      ] WeakHash32.ColumnString2
[       OK ] WeakHash32.ColumnString2 (22281 ms)
[ RUN      ] WeakHash32.ColumnString3
[       OK ] WeakHash32.ColumnString3 (22322 ms)
[ RUN      ] WeakHash32.ColumnFixedString

[       OK ] WeakHash32.ColumnFixedString (43554 ms)
[ RUN      ] WeakHash32.ColumnArray

[       OK ] WeakHash32.ColumnArray (297806 ms)
[ RUN      ] WeakHash32.ColumnArray2
[       OK ] WeakHash32.ColumnArray2 (21731 ms)
[ RUN      ] WeakHash32.ColumnArrayArray
[       OK ] WeakHash32.ColumnArrayArray (25177 ms)
[ RUN      ] WeakHash32.ColumnConst
[       OK ] WeakHash32.ColumnConst (0 ms)
[ RUN      ] WeakHash32.ColumnLowcardinality
[       OK ] WeakHash32.ColumnLowcardinality (5565 ms)
[ RUN      ] WeakHash32.ColumnNullable
[       OK ] WeakHash32.ColumnNullable (939 ms)
[ RUN      ] WeakHash32.ColumnTupleUInt64UInt64
[       OK ] WeakHash32.ColumnTupleUInt64UInt64 (2178 ms)
[ RUN      ] WeakHash32.ColumnTupleUInt64String
[       OK ] WeakHash32.ColumnTupleUInt64String (44734 ms)
[ RUN      ] WeakHash32.ColumnTupleUInt64FixedString
[       OK ] WeakHash32.ColumnTupleUInt64FixedString (86372 ms)
[ RUN      ] WeakHash32.ColumnTupleUInt64Array
[       OK ] WeakHash32.ColumnTupleUInt64Array (595275 ms)
[----------] 27 tests from WeakHash32 (1180677 ms total)


Reduce vuln and changed docker images

⚠⚠⚠ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:

[x] I have read and understand the pull request rules.

Description
Fixes some vulnerabilities (by snyk), changed golang docker image to "bookworm", and changed debian based docker image to "bookworm-slim".
Type of change
Please delete any options that are not relevant.

Other

Checklist

[x] My code follows the style guidelines of this project
[ ] I ran ESLint and other linters for modified files
[x] I have performed a self-review of my own code and tested it
[x] I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
[x] My changes generates no new warnings
[ ] My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)
Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

Please refer to the SECURITY before making Pull Requests for Vulnerabilities.

The safer method will be using NCU https://www.npmjs.com/package/npm-check-updates
And update only PATCH:
ncu --target patch -u
And maybe MINOR, but this requires reading changelogs and tests:
ncu --target MINOR -u

The safer method will be

@Saibamen
What do you mean by safer in this context? Am I missing something?

If you want to update a lot of packages, the first step is to install the latest patch release, and then minor releases.
See semantic versioning: https://semver.org/

the first step is ..

Disagree:
The first step is to read the changelog for every update you do.
I have seen package authors ship bugfixes which ended up being breaking in patch releases.

I am going to close this PR for now. We can reopen if the points noted in https://github.com/louislam/uptime-kuma/pull/4590#pullrequestreview-1941490972 are resolved.


chore: shortcut instances for IntermediateField over an IntermediateField

Removes manual letI/haveI that appear in four proofs of #9041

!bench

!bench


Minor refactoring to the MaxAwareStack

Refactoring to the MaxAwareStack - use diamond operator to simplify instantiation and use isEmpty to check whether the stack has elements.

can we merge this PR?

Thanks @nashid 😃
Sorry about the delay, been flooded with email.


Doesn't look like TTL is honored

I have created an announcement with a TTL of 60 (seconds).  The announcement started showing, but it continued to show even after the 60 seconds expired.  I marked the announcement as dismiss-able, but never dismissed it.

I'm afraid John never fully implemented this feature...

Until it is added, I suggest hiding the field that allows user to enter TTL and just default it to 0.  This is to avoid confusion.

Easier to implement it than to hide the field ;-)
Let me know if it doesn't work


Audio plays on phone while casting to TV

When casting from OnePlus to chromecast, audio plays from Chromecast and mobile simultaneously
OnePlus 5 with Android 10

Need to test on a real oneplus device. Not reproducable on samsung


Spacing is too much between bottom navigation bar icons

Hi @lukepighetti , I am facing one issue in this dependency. I used your package for bottom navigation bar but spacing between icons are too much. How can I reduce it? I used margin and itemPadding properties respectively. But can't get desire result.
So please help me out in this. Please provide solution regarding my issue.

@idamsel
You can do it like described in this answer:
https://github.com/lukepighetti/salomon_bottom_bar/issues/9
margin: EdgeInsets.fromLTRB( MediaQuery.of(context).size.width > 700 ? MediaQuery.of(context).size.width / 3 : 40, 5, MediaQuery.of(context).size.width > 700 ? MediaQuery.of(context).size.width / 3 : 40, 10),
Just play a bit with the values / dividers.
@Ahmadre
If you use salomon_bottom_bar on desktop and just have, let's say three icons, it is too far stretched.
But with the mediaquery workaround you can adjust this. Maybe there could be an option to contain the items in a sized or flexible container?

@Ahmadre Please fine below screenshots.
Selected Home
Selected Search
When I select "Favorite" , "Search" or "Profile" then I saw there is too much space between other icons. So may I get better solution for reduce extra space between icons ? I used itemPadding and margin too but I can't get my desire output
Please look into it and help me out...!


Update pdf.js

Changes and Improvements:

Grouped Imports by Category: Grouped similar imports together for better readability and maintainability.
Consolidated Imports from Same Path: Combined imports from the same module path into a single line to reduce redundancy and make the import section cleaner.
Conditional Logic Clarity: Improved clarity in the conditional logic that checks for PDFJSDev and its testing environment.

Sorry, but we cannot accept this since it fails both linting and testing; these sort of changes are unfortunately not correct.


proposal: crypto/tls: support AEGIS (for TLS 1.3)

Proposal Details
Resurrecting #58724 in a new proposal.
Voting for publication of AEGIS as an RFC closes December 12: https://mailarchive.ietf.org/arch/msg/cfrg/0T3m_Pageq7PIukaiG3Nxx4ENCM/
Dear CFRG participants,

This message is starting a 3-week RGLC on
draft-irtf-cfrg-aegis-aead-13 ("The AEGIS Family of Authenticated
Encryption Algorithms") that will end on December 12th 2024. If you've read
the document and think that it is ready (or not ready) for publication as
an RFC, please send a message in reply to this email or directly
to CFRG chairs ([cfrg-chairs@ietf.org](mailto:cfrg-chairs@ietf.org)) If you have detailed comments, these
would also be very helpful at this point.

We've got a review of the draft from Scott Fluhrer (on behalf of the Crypto
Review Panel):
https://mailarchive.ietf.org/arch/msg/cfrg/ikGi2zb6CmWyQIVhuo8QR_GrOsA/
The comments were addressed in version -13 of the draft.

Thank you,
Stanislav, for CFRG chairs

cc @jedisct1

Related Issues

proposal: crypto/tls: Support AEGIS (for TLS 1.3) #58724 (closed)

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

It still seems early.
Is there any real world software that supports this today?

CC @golang/security

I'm happy to send a CL with https://github.com/ericlagergren/aegis, obviously being updated from 00 to 13.

What is the advantage of AEGIS over AES-GCM in TLS 1.3, considering that nonce reuse is not a concern in TLS 1.3?

Performance.
It would be good to have AEGIS in x/crypto, and Eric's Go implementation is an excellent starting point.
But regadring to crypto/tls, and although some TLS implementations already support AEGIS-based cipher suites, it may bit a bit premature. The document about usage of AEGIS in TLS 1.3 is distinct from the CFRG one, and hasn't been proposed to the TLS WG yet -- it will be after the document on the construction itself has at least reached the IESG review step.


Update README.md

Create an array and fix typo on line 95, and remove trailing whitespace in README.md

We should also update this line since light theme has been added recently
https://github.com/navarasu/onedark.nvim/blob/49d668d5d7482c8e05584478570b14e93e13631b/README.md?plain=1#L81

@navarasu we should add light theme screenshot in README

We should also update this line since light theme has been added recently
https://github.com/navarasu/onedark.nvim/blob/49d668d5d7482c8e05584478570b14e93e13631b/README.md?plain=1#L81

I have updated this line, but for obvious reasons, will not be able to add the light theme screenshot

@navarasu we should add light theme screenshot in README

Yes. I need to. I have few correction on light theme and also adding one more light variant. I will update screenshot along with that


Pyasn1 no longer accepts bytearray in any decoder

Since 0.50.0, decoding serialized ASN1 from a bytearray is no longer possible.
This looks like it is introduced with asSeekableStream().
def asSeekableStream(substrate):
    """Convert object to seekable byte-stream.

    Parameters
    ----------
    substrate: :py:class:`bytes` or :py:class:`io.IOBase` or :py:class:`univ.OctetString`

    Returns
    -------
    : :py:class:`io.IOBase`

    Raises
    ------
    : :py:class:`~pyasn1.error.PyAsn1Error`
        If the supplied substrate cannot be converted to a seekable stream.
    """
    if isinstance(substrate, io.BytesIO):
        return substrate

    elif isinstance(substrate, bytes):
        return io.BytesIO(substrate)

    elif isinstance(substrate, univ.OctetString):
        return io.BytesIO(substrate.asOctets())

    try:
        # Special case: impossible to set attributes on `file` built-in
        # XXX: broken, BufferedReader expects a "readable" attribute.
        if _PY2 and isinstance(substrate, file):
            return io.BufferedReader(substrate)

        elif substrate.seekable():  # Will fail for most invalid types
            return substrate

        else:
            return CachingStreamWrapper(substrate)

    except AttributeError:
        raise error.UnsupportedSubstrateError(
            "Cannot convert " + substrate.__class__.__name__ +
            " to a seekable bit stream.")

@arambelo Could you please specify the test case/reproducing steps?
I see no test case failures regarding the issue.

Here is a concrete example:
$ ipython                                                                                23-04-20 13:48:54
Python 3.9.13 (v3.9.13:6de2ca5339, May 17 2022, 11:37:23)
Type 'copyright', 'credits' or 'license' for more information
IPython 8.9.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: from pyasn1.codec.der import decoder

In [2]: from pyasn1.type import univ

In [3]: oid_der_encoded = bytearray.fromhex('06082A8648CE3D040302')

In [4]: decoded, remainder = decoder.decode(oid_der_encoded, univ.ObjectIdentifier())
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
File ~/Library/Python/3.9/lib/python/site-packages/pyasn1/codec/streaming.py:116, in asSeekableStream(substrate)
    114     return io.BufferedReader(substrate)
--> 116 elif substrate.seekable():  # Will fail for most invalid types
    117     return substrate

AttributeError: 'bytearray' object has no attribute 'seekable'

During handling of the above exception, another exception occurred:

UnsupportedSubstrateError                 Traceback (most recent call last)
Cell In[4], line 1
----> 1 decoded, remainder = decoder.decode(oid_der_encoded, univ.ObjectIdentifier())

File ~/Library/Python/3.9/lib/python/site-packages/pyasn1/codec/ber/decoder.py:1998, in Decoder.__call__(cls, substrate, asn1Spec, **options)
   1939 @classmethod
   1940 def __call__(cls, substrate, asn1Spec=None, **options):
   1941     """Turns BER/CER/DER octet stream into an ASN.1 object.
   1942
   1943     Takes BER/CER/DER octet-stream in form of :py:class:`bytes` (Python 3)
   (...)
   1996
   1997     """
-> 1998     substrate = asSeekableStream(substrate)
   2000     streamingDecoder = cls.STREAMING_DECODER(
   2001         substrate, asn1Spec, **options)
   2003     for asn1Object in streamingDecoder:

File ~/Library/Python/3.9/lib/python/site-packages/pyasn1/codec/streaming.py:123, in asSeekableStream(substrate)
    120         return CachingStreamWrapper(substrate)
    122 except AttributeError:
--> 123     raise error.UnsupportedSubstrateError(
    124         "Cannot convert " + substrate.__class__.__name__ +
    125         " to a seekable bit stream.")

UnsupportedSubstrateError: Cannot convert bytearray to a seekable bit stream.

The same example works fine in Pyasn1 <= 0.4.8:
$ ipython                                                                                23-04-20 13:51:37
Python 3.9.13 (v3.9.13:6de2ca5339, May 17 2022, 11:37:23)
Type 'copyright', 'credits' or 'license' for more information
IPython 8.9.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: from pyasn1.type import univ

In [2]: from pyasn1.codec.der import decoder

In [3]: oid_der_encoded = bytearray.fromhex('06082A8648CE3D040302')

In [4]: decoded, remainder = decoder.decode(oid_der_encoded, univ.ObjectIdentifier())

In [5]: decoded
Out[5]: <ObjectIdentifier value object, tagSet <TagSet object, tags 0:0:6>, payload [1.2.840.10<IP_ADDRESS>]>

In [6]: import pyasn1

In [7]: pyasn1.__version__
Out[7]: '0.4.8'

We have the same issues. The entire pysnmp-related deployments are failing right now. I believe everyone using pysnmp is affected by this release.
Please clarify, can you reconsider changes in the 0.5.0 release to preserve backward compatibility?

@arambelo will it be possible for your project to use bytes instead? (which is a supported way now)
The BER decoder was refactored at this point - https://github.com/pyasn1/pyasn1/commit/93e11a2dfded950827ba3393b5a4562270a766da - I don't have enough capacity now to work on any improvements on top of that. But we welcome patches from the community. :)

@arambelo will it be possible for your project to use bytes instead? (which is a supported way now) The BER decoder was refactored at this point - 93e11a2 - I don't have enough capacity now to work on any improvements on top of that. But we welcome patches from the community. :)

I did as much as I could in my libraries, but I cannot force this change upon my clients.
As it seem that I am far from being the only one hitting this issue, I can only recommend the change suggested in https://github.com/pyasn1/pyasn1/pull/33

We got a new release that fixes the issue presumably. Please, check it and reopen the issue if you are still affected.

Just to update here that PySNMP ecosystem only relies bytes and does not require any change proposed in this issue or related pull requests.


[EventRequest] Page 7018 "Purchase Price List", New Event OnUpdateSourceType

The local procedure UpdateSourceType sets values depending on the "Source Group" of the record. The "Source Group" is an extensible Enum, but the procedure gives us no possibility to react to an extended enum value. We would need a new event OnUpdateSourceType and a new publisher within the procedure to allow for extending the case-operation:
local procedure UpdateSourceType()
begin
    case Rec."Source Group" of
        Rec."Source Group"::Vendor:
            begin
                IsJobGroup := false;
                SourceType := "Purchase Price Source Type".FromInteger(Rec."Source Type".AsInteger());
                DefaultSourceType := Rec."Source Type"::"All Vendors";
            end;
        Rec."Source Group"::Job:
            begin
                IsJobGroup := true;
                JobSourceType := "Job Price Source Type".FromInteger(Rec."Source Type".AsInteger());
                DefaultSourceType := Rec."Source Type"::"All Jobs";
            end;
        // New Publisher
        else
            OnUpdateSourceType(Rec, SourceType, DefaultSourceType, IsJobGroup);
    end;
end;

// New Integration Event
[IntegrationEvent(false, false)]
local procedure OnUpdateSourceType(PriceListHdr: Record "Price List Header" ; var SourceType: Enum "Purchase Price Source Type"; var DefaultSourceType: Enum "Price Source Type"; var IsJobGroup: Boolean)
begin
end;

IntegrationEvent: OnUpdateSourceType
Parameters:
PriceListHdr: Record "Price List Header" (by value)
SourceType: Enum: "Purchase Price Source Type" (by reference)
DefaultSourceType: Enum "Price Source Type" (by reference)
IsJobGroup: Boolean (by reference)
Publisher: Place as new else-statement at the end of he case-operation in local procedure OnUpdateSourceType

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Page Infinite redirect

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

This has been corrected and resolved. Thanks,


Check for invalid literals as ouput of parsers

The current Turtle file is valid according to the grammar:
[] <tag:> "foo"@abcde .

However, abcde is not a valid BCP47 language tag, so the produced graph is not valid according to the RDF abstract syntax.
Currently, Sophia blindly trusts the output of the parsers, creating the corresponding language rag with LanguageTag::new_unchecked, which results in a value violating the contract of its type.
The output of parsers should therefore be checked, at least for the language tags.

False alarm...  abcde is in fact a valid BCP47 tag, my mistake.
On the contrary, abcdefghi is an invalid tag, and is correctly rejected by all Sophia parsers.
"foo"^^rdf:langString may still be an issue, though, pending the decisions of the RDF 1.2 WG.


Strategy for recording tax form signatures

Part of https://github.com/opencollective/opencollective/issues/7216
With the tax forms collection moving to our own system, we should look into the best practices for recording online signatures.

Do we need to collect and store the associated IP?
Do we need additional KYC?
Should we sign the PDF with something auto-generated from the name, with a canvas that lets the user draw its signature or upload a file? Does it matter?

Resources

Related Hackernews conversation
https://www.docusign.com/products/electronic-signature/legality/united-states
https://www.docusign.com/learn/esign-act-ueta
https://www.adobe.com/content/dam/dx-dc/en/pdfs/adobe-sign-us-guide-e-signatures-wp-ue.pdf
https://www.irs.gov/instructions/iw9
https://www.irs.gov/newsroom/details-on-using-e-signatures-for-certain-forms

After reading through some resources (see above), here's my understanding.
The ESIGN act
The ESIGN act is the law that allows electronic signatures to be legally binding in the US. This law does not require a specific technology to be used (aka. DocuSign), but it does require that the signature is:

Immutable: The documents must be generated in a way that can't be tempered. I assume that by uploading the PDF to S3, the "Last Modification Date" can serve as a certification since it can't be edited.
Identifiable: The signer must be identifiable. The level of identification is not clearly defined, it goes from the basics of requiring a password/2fa to more advanced methods like using a government-issued ID. The level of verification to apply depends on what the agencies (i.e., the IRS) we're dealing with require and the level of trust we want to have. It is important to note that the service we've been using so far, Dropbox Forms, does not do any identity verification; it only verifies the email.
Auditable: though the law doesn't specify what needs to be recorded, most of the services for electronic signatures provide an audit trail where, at each step, they log some metadata: timestamps, IP address, browser/device...etc

The IRS
Some government agencies still require a third-party service like DocuSign to act as a neutral 3rd party. The IRS is not one of them. The IRS allows you to use your own system as long as it respects the ESIGN Act along with some rules about how the signature should be done:

Electronic Submission of Forms W-9
Requesters may establish a system for payees and payees' agents to submit Forms W-9 electronically, including by fax. A requester is anyone required to file an information return. A payee is anyone required to provide a taxpayer identification number (TIN) to the requester.
Payee's agent.
A payee's agent can be an investment advisor (corporation, partnership, or individual) or an introducing broker. An investment advisor must be registered with the Securities and Exchange Commission (SEC) under the Investment Advisers Act of 1940. The introducing broker is a broker-dealer that is regulated by the SEC and the National Association of Securities Dealers, Inc., and that is not a payer. Except for a broker who acts as a payee's agent for "readily tradable instruments," the advisor or broker must show in writing to the payer that the payee authorized the advisor or broker to transmit the Form W-9 to the payer.
Electronic system.
Generally, the electronic system must:

Ensure the information received is the information sent, and document all occasions of user access that result in the submission;
Make reasonably certain that the person accessing the system and submitting the form is the person identified on Form W-9, the investment advisor, or the introducing broker;
Provide the same information as the paper Form W-9;
Be able to supply a hard copy of the electronic Form W-9 if the Internal Revenue Service requests it; and
Require as the final entry in the submission an electronic signature by the payee whose name is on Form W-9 that authenticates and verifies the submission. The electronic signature must be under penalties of perjury and the perjury statement must contain the language of the paper Form W-9.

On top of that, the IRS define some general rules about electronic signatures:

The IRS will accept a wide range of electronic signatures. An electronic signature is a way to get approval on electronic documents. It can be in many forms and created by many technologies. Acceptable electronic signature methods include:

A typed name typed on a signature block
A scanned or digitized image of a handwritten signature that's attached to an electronic record
A handwritten signature input onto an electronic signature pad
A handwritten signature, mark or command input on a display screen with a stylus device
A signature created by a third-party software

The IRS doesn't specify what technology a taxpayer must use to capture an electronic signature. The IRS will accept images of signatures (scanned or photographed) including common file types supported by Microsoft 365 such as tiff, jpg, jpeg, pdf, Microsoft Office suite or Zip.

Conclusion
In the context of W9/W8 forms, it looks like nothing is preventing us from collecting the signature ourselves as long as we respect the rules about identifiability, immutability, and auditability mentioned above. We should especially ensure that:

The language used on the form matches the document. This should be the case if we replicate the Dropbox Form template we already have.
We record some metadata when signing the form: browser/os, IP address, and any uniquely identifiable information.
We ensure the user is identified (if set up, a 2FA confirmation would be nice).
We add an input that clearly mention that it's a signature. This input can be any text field where you type your name, a canvas to draw your signature, or an image upload field.
We add a policy to our S3 bucket that prevents existing files from being edited.

In the future, we may have to look into 3rd party solutions if we ever start collecting legal documents for different agencies, especially in Europe, where some government agencies require more complex regulations (Regulation 2014/910/EU, eIDAS, PADES, CADES, XADES) that would be difficult to implement and maintain internally.

For Auditability, it would be interesting to record the payment information we have in the audit log (name, address)
We may want to have stricter enforcement between the name on the tax form and the payee's name
We do not want to store real users' signatures as they're sensitive info, so we'll go with an auto-generate solution
We need to make sure that the user has control over the auto-generated signature before submitting

These specifications have been implemented in https://github.com/opencollective/opencollective-frontend/pull/9906 + https://github.com/opencollective/opencollective-api/pull/9988.


Update mypy syntax from python 3.9 to 3.10

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.78%. Comparing base (59c217c) to head (7bcd170).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
- Coverage   98.78%   98.78%   -0.01%
==========================================
  Files          45       45
  Lines        1893     1892       -1
==========================================
- Hits         1870     1869       -1
  Misses         23       23

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update connectors-create-api-servicebus.md

@ecfan
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Hi @harry6561, thank you for making this doc contribution. All Microsoft employees must make doc updates in the internal, private repo, so that our publishing system can apply the validation process. Please follow the instructions that I provided in the email thread where we discussed this update. Thank you!

Hi @harry6561, as previously mentioned, all Microsoft employees must make doc updates in the internal, private repo, so that our publishing system can apply the validation process. Please follow the instructions that I provided in the email thread where we discussed this update. Thank you!
I'm closing this PR now.
#please-close


White Screen of Death

This seems to happen when first attempting a CMIP6 search
Everything goes white.  Guess that the backend feeds something the json parser can't handle and causes the crash.
Maybe this has some good info.  I captured it in case you are blocked by Medium
https://medium.com/wix-engineering/white-screen-of-death-how-to-handle-errors-in-react-native-4d57ac82b6d8

@sturoscy-personal You once found a solution to this issue with search, was that fix committed to a branch somewhere?  if so, great to merge in our latest changes or rebase.   We can reproduce this:

Change the hostname in the SEARCH_URL setting to esgf-fedtest.llnl.gov
restart the containers (the setting must load on the backend)
Select "all (except CMIP6)" and hit the button
you should see the WSOD and a javascript error in the console.

Also CMIP6 search produces the WSOD as shown on esgf-dev1 (configured with esgf-fedtest).


Triple Rest Openapi Support

What is the purpose of the change?
Add OpenAPI support for Triple REST protocol, enabling automatic OpenAPI documentation generation
for dubbo services. The implementation includes:

Dynamic OpenAPI spec generation from service metadata
Support for JSON/YAML formats
Configurable schema naming strategy
Document caching and merging
Group/Version/Tag filtering
Customizable documentation through annotations

How to testing
Automatically generates OpenAPI documentation for all Dubbo services with zero configuration:

Access Swagger UI:
http://host:port/dubbo/openapi

Access OpenAPI Spec:
http://host:port/dubbo/openapi/api-docs

Supported formats:

JSON (default): /dubbo/openapi/api-docs
YAML: /dubbo/openapi/api-docs.yaml

Optional filters:

Group: /dubbo/openapi/api-docs/{group}
Version: /dubbo/openapi/api-docs?version=1.0.0
Tags: /dubbo/openapi/api-docs?tag=user,order

Example
Start dubbo-demo/dubbo-demo-spring-boot/dubbo-demo-spring-boot-servlet
then access:
http://localhost:8082/dubbo/openapi

Show case

Codecov Report
Attention: Patch coverage is 1.38702% with 5119 lines in your changes missing coverage. Please review.

Project coverage is 29.22%. Comparing base (3c43c82) to head (45a3c3e).

Files with missing lines
Patch %
Lines

...java/org/apache/dubbo/metadata/OpenAPIRequest.java
0.00%
555 Missing :warning:

...pc/protocol/tri/rest/openapi/DefinitionMerger.java
0.00%
375 Missing :warning:

.../protocol/tri/rest/openapi/DefinitionResolver.java
0.00%
240 Missing :warning:

...bo/rpc/protocol/tri/rest/openapi/model/Schema.java
0.00%
240 Missing :warning:

...pc/protocol/tri/rest/openapi/DefinitionFilter.java
0.00%
231 Missing :warning:

...c/main/java/org/apache/dubbo/metadata/OpenAPI.java
0.00%
195 Missing :warning:

...port/swagger/JavadocOpenAPIDefinitionResolver.java
0.00%
167 Missing :warning:

...he/dubbo/rpc/protocol/tri/rest/openapi/Helper.java
0.00%
165 Missing :warning:

.../rpc/protocol/tri/rest/openapi/SchemaResolver.java
0.00%
154 Missing :warning:

...otocol/tri/rest/openapi/DefaultOpenAPIService.java
0.00%
143 Missing :warning:

... and 140 more

:exclamation:  There is a different number of reports uploaded between BASE (3c43c82) and HEAD (45a3c3e). Click for more details.
HEAD has 2 uploads less than BASE

Flag
BASE (3c43c82)
HEAD (45a3c3e)

unit-tests
1
0

integration-tests
1
0

Additional details and impacted files
@@              Coverage Diff              @@
##                3.3   #14924       +/-   ##
=============================================
- Coverage     64.34%   29.22%   -35.12%
+ Complexity    10782     8880     -1902
=============================================
  Files          1819     1882       +63
  Lines         80959    85978     +5019
  Branches      12039    12875      +836
=============================================
- Hits          52094    25129    -26965
- Misses        23477    56872    +33395
+ Partials       5388     3977     -1411

Flag
Coverage Δ

integration-tests
?

samples-tests
29.22% <1.38%> (-1.80%)
:arrow_down:

unit-tests
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


BTE 598 error on Workflow D.2 query

https://arax.ncats.io/?source=ARS&id=9938906a-6f8e-4886-b454-66f5372c81ae

{
  "callback": "http://localhost:8000/ars/api/messages/00859ff3-2d96-4e2c-8fc3-81b3bc54b368",
  "message": {
    "query_graph": {
      "edges": {
        "e00": {
          "object": "n01",
          "subject": "n00"
        },
        "e01": {
          "object": "n02",
          "subject": "n01"
        }
      },
      "nodes": {
        "n00": {
          "categories": [
            "biolink:ChemicalSubstance"
          ],
          "ids": [
            "DRUGBANK:DB00215",
            "DRUGBANK:DB01175",
            "DRUGBANK:DB00472",
            "DRUGBANK:DB00176",
            "DRUGBANK:DB00715",
            "DRUGBANK:DB01104"
          ]
        },
        "n01": {
          "categories": [
            "biolink:Gene"
          ]
        },
        "n02": {
          "categories": [
            "biolink:Disease"
          ],
          "ids": [
            "DOID:114"
          ]
        }
      }
    }
  },
  "validation_result": {
    "message": "",
    "size": "1 kB",
    "status": "PASS",
    "version": "1.1.1"
  }
}```

Andrew will link up to an existing issue in BTE

Standard two-hop explain query. BTE planned fix tracked in biothings/BioThings_Explorer_TRAPI#112

@andrewsu request for update

https://arax.ncats.io/?source=ARS&id=e5b3b658-0056-4c9f-998e-1c9298ef3464

@andrewsu the dependent case is closed. As of this morning, there is still a 598 error for BTE.

BTE is now returning results as expected: https://arax.ncats.io/?r=dc5ab60f-7817-4c29-97d8-5e6948a1013c


The soundjs play failed when the source url is a RESTFUL api

Issue Details

Version used

Latest SoundJS 1.0.2
https://cdnjs.cloudflare.com/ajax/libs/SoundJS/1.0.2/soundjs.min.js
Whats happening:
When playing a sound from a RESTFUL api, the instanse's playstate is null (sometimes it's failed)
Demo here:
https://codepen.io/d925529/pen/gjomKd

This is mostly likely caused by the file path for your sound containing a query string (specifically "?"). This isn't incorrect, but PreloadJS/SoundJS doesn't accept it as a valid file path.
Info for solving this:
The PATH_PATTERN for PreloadJS is
/^(?:(\w+:)\/{2}(\w+(?:\.\w+)*\/?))?([\/.]*?(?:[^?]+)?\/)?((?:[^\/?]+)\.(\w+))(?:\?(\S+)?)?$/

A saved RegExr pattern is here: https://regexr.com/3t6d0
Just accepting the query string may cause issues with other parts of PreloadJS/SoundJS, so it will need to be tested thoroughly.

I run into a similar problem, but the regexr link above takes me to the default page on regexr.
Does happened something with this since 2018 ?

Nothing has changed in the library (see discussion here)
The RegExr pattern can be found here: https://regexr.com/343kr - not sure why the old one no longer works.

Thank you, that regex patter doesn't work for me either, but removing the ? exclusion from the original pattern did the job.
Will we see something about this consortium on createjs.com ? or here ? the slack link is not valid anymore.


meta: add nightly mobile builds action

Adds a GitHub action to build our mobile app with Expo every night at midnight. Hard-codes the "preview" and "all" options into the EAS build command. Only runs if we see changes to develop since the last run.

I'm confused about how the Check for changes in develop step is working. Will that not always compare the latest commit against itself?

@latter-bolden Check now—if that git command returns anything other than 0, "changes" sets to 1, which should let the rest of the steps fire.


Add ability to filter based on language

Twitch supports filtering results based on language and I'd love to see this added to Stitch. There are a lot of categories that are almost unbrowsable without it. For example GTA V has a lot of non-english streamers so you need to visually sort them out based on their stream title, which can be hit or miss.

Do you have any examples of where Twitch does this? Or are you just talking about tags?

Previously this was a stand alone feature but it seems like they just absorbed it into tags.

Thats what I've noticed as well.
It seems a bit more complicated too since they switch tags from a pre-defined list to free-form and user-chosen. i.e. a lot of streamers aren't adding language tag so if we filter by it we'd likely miss a lot of streams.
For anyone reading this i'm open to suggestions on how best to handle this.

I noticed a "Language" drop down in a category today and peeked at the GQL request when I selected English and it looks like this is separate from the tags system.


Can't play audio buffer returned from @google-cloud/text-to-speech

Google Cloud Text to Speech returns a response.audioContent which logs to console as:
<Buffer ff f3 44 c4 00 12 6a d5 44 01 41 10 01 c6 37 00 20 8c 6c 80 04 05 fe 84 6a 9c ef f3 9f 39 f2 10 9f e4 24 8d bf fc e7 79 cf 21 09 c9 53 9e 42 49 53 ba ... 4846 more bytes>

Running this:
let playback = play(response.audioContent);
playback.play();

Errors out with:
Error: Argument should be an audio buffer

Am I doing something wrong?

Try converting Buffer to AudioBuffer via https://github.com/audiojs/audio-buffer-from


NewUtxoView never returns an error

Merge activity

Apr 11, 8:07 PM EDT: @lazynina started a stack merge that includes this pull request via Graphite.


MaskedTextChangedListener implementation bug

Came across an issue with mask format. When a textChangedListener is installed on a text edit it uses number example to make a mask. Problem is that number example is just on of the possible variants of the input so using it for the mask restricts from another valid input of different format.
Example:
Indonesian mobile number + 62 812 111-222-33 which is perfectly valid, it's number pattern in the google lib is 8[1-35-9]\d{7,10}.
It's impossible to input the whole number because textChangedListener uses short variant of mask +[00] [000]-[000]-[000] so it allows only + 62 812 111-222.
The workaround is using a widest possible mask format i guess.

Hi @derkicker do you have any suggestion to cover that case? As far as I know lilphonenumber provides just 1 sample number for the given country code.

Hi @ibrahimsn98! I'd suggest using possibleLengths block from resources:

So we could get max value from mobile.possibleLength_ and compose a mask of that length


Set-Location \  behaviour inconsistent between operating systems

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
In #18308 we found that running cd\ will do different things depending on the operating system.
Steps:

Navigate to any directory above your drive's root level. >  Set-Location Drive:/LizardPhotos/Skinks
Run Set-Location \ or cd\
You should now be at your drive's root on windows, or your filesystem root on Linux & Mac.

Expected behavior
Windows, Mac, and Linux set location as the root of the current drive on`cd\`

Actual behavior
Windows sets location to the root of the current drive.
Mac and Linux sets location to the filesystem root.

Error details
N/A

Environment data
Name                           Value
----                           -----
PSVersion                      7.3.0-preview.9
PSEdition                      Core
GitCommitId                    7.3.0-preview.9
OS                             Microsoft Wind…
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0…
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visuals

@iSazonov New Issue created.

By default Unix haven't a drive and it is ok cd\ to move to a root of current volume. But what if user uses a drive on Unix? Should we follow Windows behavior and move to a root of current drive?
cd Temp:\
New-Item test -ItemType Directory
cd test
cd\

_I'd prefer consistency on all platforms._Otherwise, why do we need the drives if the cmdlets ignore them?

Windows, Mac, and Linux set location as the root of the current drive oncd\

On Linux partitions mounted to the root:
 $ lsblk
NAME   MAJ:MIN RM   SIZE RO TYPE MOUNTPOINTS
sda      8:0    0 111.8G  0 disk
└─sda1   8:1    0 111.8G  0 part /
sdb      8:16   0 465.8G  0 disk
└─sdb2   8:18   0 465.8G  0 part /data

if you on Windows mount (or create junction) partition to the folder (not by letter) the result will be the same.

@237dmitry The issue is about drives.

The issue is about drives.

OK, I misunderstood the difference between "drives" and "PSDrives"

To be correct no difference between psdrive and fs drive should be in PowerShell behavior.

While consistency across platforms is generally desirable, I fear that's not an option here:
On Unix, if you make / refer to the root of a drive (which on Unix is by definition only ever a PS drive), you won't be able to change to the actual file-system root whenever the current location is drive-based.
Pragmatically speaking:

Interactively, typing, say, Set-Location Temp:/ isn't too much of a hardship.
Programmatically, you can use the following (which would obviously be too cumbersome interactively):

Set-Location ($PWD.Path -replace '(?<=[\\/]).*')

Programmatically, you can use the following to switch to the root of the current drive, on all platforms (which would obviously be too cumbersome interactively):

Set-Location ($PWD.Path -replace '(?<=[\\/]).*')

Since some of us already redefine CD to be something other than an alias for set location, that could be incorporated into a CD function.
/  is defined as a PS Drive on linux to ensure that cd / does in PowerShell what it does in other unix/linux shells
What happens in all shells on the same OS is consistent rather than making pwsh on linux "windows like" and annoying linux oriented folks.

The WG has reviewed this and believe this to be ByDesign. There are fundamental differences between a singly rooted filesystem and a drive based filesystem that should not be consistent as we feel that would cause more confusion rather than reduce it.


Onboarding All-In-One-Health

Onboarding All-In-One-Health from California.
Acceptance Criteria:

All-In-One-Health is configured as a CSV Sender in ReportStream.
All-In-One-Health is a one-off Sender configuration.  There will be one schema under /schemas/non-standard/

Assignees & Labels
rhood23699 - Rick Hood   /  sender-automation

PUSH to prod on 9/28/21


Support multiple application_name in can i deploy action.

Support multiple application_name in can i deploy action.
We have multiple application in the same repo and we want to centralize only one can i deploy.

Hey,
Happy to accept a PR otherwise you can use the full fat cli tool as part of an action and do this today
https://github.com/pactflow/actions#actions

I find this very cool, I would like to get it supported int he create-tag action as well please :)

how would people want the interface to look for this, as you provide arguments after the provider name.
how would one know which arguments are for which provider?
https://github.com/pact-foundation/pact_broker-client?tab=readme-ov-file#can-i-deploy

I find this very cool, I would like to get it supported int he create-tag action as well please :)

that command create-version-tag doesn't support multiple app names.
https://github.com/pact-foundation/pact_broker-client?tab=readme-ov-file#create-version-tag
would you want it calling multiple times with the same args, for say a comma separated list of application names?


Advertising Interval

nRF Connect is showing my ggk server as having a 1281ms adv. interval. Is there some way of increasing the speed of the advertising interval? Most other devices are around 40ms.
Looks like there is a hcitool command that may be applicable.

You can also write to these values in sysfs:
/sys/kernel/debug/bluetooth/hci0/adv_min_interval /sys/kernel/debug/bluetooth/hci0/adv_max_interval
The values should be in milliseconds. Works fine for me (BlueZ 5.48).


Now redeliver method exists above race condition:

consumer reconnects to the broker with the epoch (1)
client consumer invokes redeliver command with epoch (2) and find the consumer doesn't connect, so ignore this redeliver command
the result is broker send message with epoch(1), client will filter these message

Motivation
fix this issue
Modifications

client sends redeliver command don't check the consumer state only check the cnx to see whether been set to the client
broker consumer future complete, then process the redeliver command, if complete exception don't need to handle, because conusmer will reconnect with the epoch

Verifying this change
add test for it
Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:
https://github.com/congbobo184/pulsar/pull/16

closing and reopening to trigger CI

DEFAULT_CONSUMER_EPOCH as seem as CONSUMER_EPOCH.get(this), we need to solves the reconnect and redeliver race condition. Using DEFAULT_CONSUMER_EPOCH seems to make the problem more complicated

Ok, I can now see that the synchronized block is there to prevent the race in increasing the epoch. I hope that we'd have a proper test for the race by injecting a delay to have a real race.
There's also another issue with the permits. increaseAvailablePermits should only be called if writing of the redeliverUnacknowledgedMessages command succeeds. That should be done in the promise callback of writeAndFlush to ensure that permits aren't increased in the case where the connection is not available.

DEFAULT_CONSUMER_EPOCH as seem as CONSUMER_EPOCH.get(this), we need to solves the reconnect and redeliver race condition. Using DEFAULT_CONSUMER_EPOCH seems to make the problem more complicated

Ok, I can now see that the synchronized block is there to prevent the race in increasing the epoch. I hope that we'd have a proper test for the race by injecting a delay to have a real race in the test.

Could you please find a similar test? I'm not very good at writing it.

There's also another issue with the permits. increaseAvailablePermits should only be called if writing of the redeliverUnacknowledgedMessages command succeeds. That should be done in the promise callback of writeAndFlush to ensure that permits aren't increased in the case where the connection is not available.

yes, you are right. but this is a another problem, I think this pr don't need to handle this situation

There's also another issue with the permits. increaseAvailablePermits should only be called if writing of the redeliverUnacknowledgedMessages command succeeds. That should be done in the promise callback of writeAndFlush to ensure that permits aren't increased in the case where the connection is not available.

yes, you are right. but this is a another problem, I think this pr don't need to handle this situation

I agree that it's partially a different problem. However since this PR changes the behavior around it, I think that it would make sense to address the permit issue in this PR. Solving the issue will require a few lines of code.

Ok, I can now see that the synchronized block is there to prevent the race in increasing the epoch. I hope that we'd have a proper test for the race by injecting a delay to have a real race in the test.

Could you please find a similar test for me? I'm not very good at writing it.

I don't have a good example in mind. It might require a broader effort in introducing good ways to test race conditions in the client code. Optimally, the implementation would contain injection points for adding such delays.

There's also another issue with the permits. increaseAvailablePermits should only be called if writing of the redeliverUnacknowledgedMessages command succeeds. That should be done in the promise callback of writeAndFlush to ensure that permits aren't increased in the case where the connection is not available.

yes, you are right. but this is a another problem, I think this pr don't need to handle this situation

I agree that it's partially a different problem. However since this PR changes the behavior around it, I think that it would make sense to address the permit issue in this PR. Solving the issue will require a few lines of code.

again I see the code, "increaseAvailablePermits" is only relevant to "incomingMessages", no need to care about redeliverCommand success or failure.


Thanks , it is working

HI , it is working fine now i am searching for same type of thing for linkedin but could not find any solution  . can you help me ?

@ashjha No sorry, not aware of any libraries for LinkedIn. I just do declare var to use libraries with no typings/wrappers.


Canadian UPS Shipping

Hi guys! I can't seem to get Canadian addresses with postal codes to work. Please let me know if I'm missing something. Also, I need to get rates for Canada to US. US to US works great though. Any help would be great - Much appreciated!
            var packages = new List<Package>();
            foreach (var item in dovm.OrderItems.ToList())
                foreach (var box in item.Boxes)
                    packages.Add(new Package(box.Length, box.Width, box.Height, box.Weight, item.Price));

            var origin = new Address("", "", "V3S8E5", "CA");
            var destination = new Address("", "", "T8E2C7", "CA"); // US Address

            var rateManager = new RateManager();

            rateManager.AddProvider(new UPSProvider(upsLicenseNumber, upsUserId, upsPassword));
            Shipment shipment = rateManager.GetRates(origin, destination, packages);

I just tried this in the same app with my account login and your addresses and it worked.

Are you sure packages.Count() > 0?
Does your UPS account have access to the Canadian rates (I'm not sure you can get an account without access to those rates, but something to consider).

Kyle


Move to nanobind

Not super excited with how import_arrays() is added currently -- it seems like it's supposed to be part of a very short main() but we don't really have that in this case. Expecting I'll need to make additional changes here.
Vector of KLL might have some very slight performance regressions. I tried changing the get_index code back to std::vector and that didn't actually help. My current guess is that the more generic nanobind matrix data model has an additional cost. Whether we think there's enough other benefit to justify this will be the key deciding factor.

Created a simple, non-exhaustive test script. It uses python iteration to update since we expect that vectorized updates handled in c++ will be much closer in performance/.
Script:
import datasketches as ds
import numpy as np
import timeit

num_repeats = 100
n = 2 ** 20 # num updates

# default k in all cases since the test is of the interface

# cpc
def cpc_test():
  cpc = ds.cpc_sketch()
  for i in range(0, n):
    cpc.update(i)
  cpc.get_estimate()

  b = cpc.serialize()
  ds.cpc_sketch.deserialize(b)

# theta
def theta_test():
  sk = ds.update_theta_sketch()
  for i in range(0, n):
    sk.update(i)
  sk.get_estimate()

  b = sk.compact().serialize()
  ds.compact_theta_sketch.deserialize(b)

# tuple
def tuple_test():
  sk = ds.update_tuple_sketch(ds.AccumulatorPolicy())
  for i in range(0, n):
    sk.update(i, i * i)
  sk.get_estimate()

  b = sk.compact().serialize(ds.PyLongsSerDe())
  ds.compact_tuple_sketch.deserialize(b, ds.PyLongsSerDe())

# kll
def kll_test():
  kll = ds.kll_ints_sketch()
  for i in range(0, n):
    kll.update(i)
  kll.get_quantile(0.5)
  kll.get_rank(int(n / 2))

  b = kll.serialize()
  ds.kll_items_sketch.deserialize(b, ds.PyIntsSerDe())

# ebpps
def ebpps_test():
  ebpps = ds.ebpps_sketch(100)
  for i in range(0, n):
    ebpps.update(i)
  result = list(ebpps)

  b = ebpps.serialize(ds.PyIntsSerDe())
  ds.ebpps_sketch.deserialize(b, ds.PyIntsSerDe())

# density
def density_test():
  dim = 3
  sk = ds.density_sketch(k=50, dim=dim, kernel=ds.GaussianKernel())
  for i in range(0, int(n / 256)):
    sk.update(np.random.randn(dim))

  b = sk.serialize()
  ds.density_sketch.deserialize(b, ds.GaussianKernel())

elapsed = timeit.timeit(lambda: cpc_test(), number = num_repeats)
print(f'CPC: {elapsed:.4f}')

elapsed = timeit.timeit(lambda: theta_test(), number = num_repeats)
print(f'Theta: {elapsed:.4f}')

elapsed = timeit.timeit(lambda: tuple_test(), number = num_repeats)
print(f'Tuple: {elapsed:.4f}')

elapsed = timeit.timeit(lambda: kll_test(), number = num_repeats)
print(f'KLL: {elapsed:.4f}')

elapsed = timeit.timeit(lambda: ebpps_test(), number = num_repeats)
print(f'EBPPS: {elapsed:.4f}')

elapsed = timeit.timeit(lambda: density_test(), number = num_repeats)
print(f'Density: {elapsed:.4f}')

Pybind11 results:
CPC: 13.3239
Theta: 13.5307
Tuple: 21.6532
KLL: 15.2251
EBPPS: 21.6534
Density: 67.9749

Nanobind results:
CPC: 4.0155
Theta: 3.5051
Tuple: 7.3076
KLL: 4.5196
EBPPS: 15.3917
Density: 64.4 [rerun in isolation after changes]

Just to make sure I understand this correctly: the timings reported above significantly better than those initially reported for nanobind? If we thought the performance was mixed before and this was a blocker to switching, these results refute that and suggest that performance is improved using nanobind, so we should switch.

@c-dickens I addressed the 50% degradation in density, and after trying a bunch of stuff in vector_of_kll it's, well, still a small drop in performance. But certainly for our classic sketches it's a win.
As noted, this is doing all the iteration in python, which we know is slow, but it seems to indicate that nanobind's python<->C++ interface really does provide less overhead for non-matrix/vector types.

@jmalkin : I stumbled across this randomly. Can you see if the NOMINSIZE flag (see the bottom of https://nanobind.readthedocs.io/en/latest/building.html for an explanation) fixes your perf. regression?

@wjakob That did provide a benefit for most sketches in my limited testing (namely, rerun the above script).
I didn't try undoing the changes to use a numpy array constructor directly for one class (density_sketch) but part of the issue there is that the underlying C++ class wants to store vectors in std::vector as opposed to a more python-friendly type. We'll look at making that type a template parameter in the future.
Now I just need to revisit the object ownership details since I'm running into exactly the circular C++/Python dependency link described in the docs -- which isn't reported when running our unit tests!


folly: 2<IP_ADDRESS> -> 2<IP_ADDRESS>

Motivation for this change
This is necessary to build recent versions of Fizz, which I have a Nix build for and am ready to submit when this is merged.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Closing due to https://github.com/NixOS/nixpkgs/commit/4f621ca1d4ebf7d596119de11c1010e87aafece1


Use CUDA-aware MPI in DistributedTree constructor

Cleanup of #174. In the past couple years we had several developments that make this easy to implement. So might as well finish it.
I decided to not force push in #174, so that we can compare the PRs.

We would need the check if and only if we are attempting to build an unmanaged view on the root node bounding volume since the empty BVH does not have any node.

In #174, I have never seen a significant difference in performance (mainly because I was always looking at problems where we were actually doing a BVH search after construction). In my experience, the performance using CUDA-aware MPI is also only better if we send a lot of data. Do we have a test case where we know that this is beneficial?

No, I don't expect it to be beneficial. But I think it's useful for comparison with non Cuda-aware version.


DraggableScrollableSheet: Null check operator used on a null value

Sorry but I don't have any steps to reproduce. All I have is this crash report in Firebase :(
Non-fatal Exception: FlutterError
0  ???                            0x0 _DraggableScrollableSheetScrollPosition.goBallistic._tick + 707 (draggable_scrollable_sheet.dart:707)
1  ???                            0x0 AnimationLocalListenersMixin.notifyListeners + 155 (listener_helpers.dart:155)
2  ???                            0x0 AnimationController._tick + 830 (animation_controller.dart:830)
3  ???                            0x0 Ticker._tick + 238 (ticker.dart:238)
4  ???                            0x0 SchedulerBinding._invokeFrameCallback + 1145 (binding.dart:1145)
5  ???                            0x0 SchedulerBinding.handleBeginFrame.<fn> + 1058 (binding.dart:1058)
6  ???                            0x0 _LinkedHashMapMixin.forEach (dart:collection)
7  ???                            0x0 SchedulerBinding.handleBeginFrame + 1056 (binding.dart:1056)
8  ???                            0x0 SchedulerBinding._handleBeginFrame + 975 (binding.dart:975)

Right now it's only happening on iOS, but on the other hand, we have a lot more iOS users than Android users.
I found another bug ticket related to this: https://github.com/flutter/flutter/issues/89214
The goBallistic method creates an AnimationController named ballisticController and adds the _tick method to it as a listener.
In the _tick method is this line of code:
extent.addPixelDelta(delta, context.notificationContext!);

I guess the bang operator context.notificationContext! is the problem.
But I also noticed that the ballisticController isn't disposed when the owner object is disposed.
So the question is: Do we need to dispose the ballisticController when the owner is disposed?

flutter doctor -v
[✓] Flutter (Channel stable, 2.8.1, on macOS 11.6.1 20G224 darwin-x64, locale de-DE)
    • Flutter version 2.8.1 at /Users/ralphbergmann/development/sdks/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 77d935af4d (3 weeks ago), 2021-12-16 08:37:33 -0800
    • Engine revision 890a5fca2e
    • Dart version 2.15.1

Oh, I missed the _ballisticCancelCallback, so disposing is probably not the problem.

Although it looks similar / related to https://github.com/flutter/flutter/issues/89214, I tried to replicate the same on latest stable but didn't get the said exception.
@RalphBergmannKMB Is there a way for you to provide a pattern that leads to this exception ? Maybe you can try along the lines of the code sample mentioned in linked issue and see if you can try to replicate ?


I have added classes in navbar.html file

I have Added classes in the navbar.html for the navbar . herewith I have added  the image for the improved Navbar

Tell me Changes if required , Thank You!!
[x] Solved an issue/task
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:
Issue Number: #966

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out my other projects. Just click here to find more. These projects contain real issues that you can help resolve. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


Add event error handler

A simplified alternative to #330. As discussed with @danielcompton in that other PR, this is a less invasive and easier to explain/document way to handle exceptions.
Adds a global error handler via reg-event-error-handler that gets called when an exception pops up from the interceptor chain call. The handler is called with an ExceptionInfo that contains keys #{:direction :exception :interceptor}. Handler is expected to do side-effectfs: send the error information to an errors service, dispatch an event to do that or to add the error information to the db, etc.
Original issue: #231

I'd be happy to add more documentation and examples if there's interest in this change. I'll leave some pointers here:

docs/FAQs/CatchingEventExceptions.md
probably here docs/Debugging-Event-Handlers.md
maybe mention this feature in the README

Thanks. This is looking pretty good.  I've got some requests for name changes, which will follow soon, but nothing at all significant.
Docs wise, could you add something to the following please:

docs/API.md
Changes.md

Hey I've taken a look at this and pushed a commit to add more context to the error. I'm happy with the concept and implementation, the only thing I'm really thinking about is whether we can capture the original stack trace of the error pointing to the registered handler. Currently it is still pointing to re-frame's internals.

whether we can capture the original stack trace of the error pointing to the registered handler. Currently it is still pointing to re-frame's internals.

What do you think about (.-stack (ex-cause e))? It should give the original stacktrace. Wrapping the exception adds an indirection layer but there's a way to get the original stack trace. I think it's reasonable, it's a tradeoff. And it provides a way to report the original exception with the full stack trace to an error service for example. If this way looks good to you, perhaps we could mention it in the docs (I still have to add some doc changes)

I haven't been needing this change as of late, and at the same time it seems it didn't catch much interest, so I'll close the PR, while keeping the branch in my fork in case anyone wants to use it.
@danielcompton thanks again for taking the time to review and discuss it.

Hey sorry we haven't been able to merge this, I still think it's a useful change, we just haven't had any time budget to review it. I'd like to keep it open, as I think this could be useful for others too, we've just got other internal stuff we need to take care of first. Sorry for the wait!

We might need this feature, is this going to be merged eventually? Or should we give up on it?

This PR needs someone who has time to resolve

merge conflicts with master due to the age of the PR
any outstanding issues from existing comments (not new issues, in the interests of closure); e.g. (.-stack (ex-cause e)) to get the original stacktrace.

I don't have that time at the moment.
If someone else could do the above and update this PR or open a new PR based on these changes I will merge it.
@qleguennec

Merged e91e5b57