Memory leak when running project

Describe the bug
When running Ionide on my main work solution, it works fine up until I run the project(s). When I do, Ionide will continue to work but will continually use up more and more RAM until I'm forced to kill the service - just now, it was sitting on 18 gigs of ram & slowing my machine to a crawl. I can consistently recreate this - or, more accurately, every time I run the projects, I get a memory leak.
I'm the only person on my team with this issue at all, and it only happens for one solution. However, this is a pretty big solution - 32 individual projects. I haven't had this issue across any other solutions, just this one. It might be worth noting that it appears that Ionide uses up a fair amount of memory even when running fine - without the issue currently happening, it's sitting on 2.8 gigs of RAM.
Steps to reproduce

Open up my main work solution on my laptop
Launch it from the terminal via tye
Watch ram usage skyrocket

Machine info

OS: Mac 12.2.1, has happened for a few versions
.NET SDK version: Has happened for a few versions now, currently happens on 5.0.404
Ionide version: Has happened for a few versions now, currently happens on 7.0.0

Additional context
We use tye for running our containers & orchestrating our services, but I'm able to get a memory leak when running the services "normally".
Let me know what I can provide to debug this. I took a memory dump, but it's 11 gigs and I can't open it on my OS (so I don't even know if it's working).

I can even get this to happen without any processes running, which is interesting & uncommon.

Same issue here. But the project I am working on is very small. Just an Azure function and a Pulumi project. This seems to be triggered just by editing code and/or displaying intellisense. The point where it got in the way of getting any development done was when working on some nested CEs (Pulumi.FSharp.AzureNative).
I downgraded to v6 which does not behave as badly (CPU/memory consumption is still an issue but nowhere near as bad).

Windows 10
.NET SDK 6.0.302
Libraries used in the projects:

Azure.Identity
Azure.ResourceManager
Azure.ResourceManager.Resources
Azure.Security.KeyVault.Secrets
Farmer
FsToolkit.ErrorHandling
Pulumi
Pulumi.AzureNative
Pulumi.FSharp
Pulumi.FSharp.AzureNative
Pulumi.FSharp.Core

Same issue here.
Machine: MBP ARM64

Same issue here.
Machine: Mac mini (M1, 2020) ARM64

I'm getting a spike in the CPU usage on Air M1 8GB when I open up
https://github.com/wallymathieu/auctions-site
I'm using .net version 6.0.302

It's fine when I'm using Rider or Visual Studio for Mac though.

Same as @wallymathieu on my M1, after opening a file dotnet CPU's usage skyrockets and stays until I kill VSCode:

Not sure if there's a way to report any performance logs, if so I can attach them since it happens continously.

Switching back to v 6.x solved the problem for me imho

Am 09.08.2022 um 01:46 schrieb Fran González @.***>:

Same as @wallymathieu on my M1, after opening a file dotnet CPU's usage skyrockets and stays until I kill VSCode:
Not sure if there's a way to report any performance logs, if so I can attach them since it happens continously.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.

same here. Switching back to 6.0.6 solves it.

Confirming high CPU usage on M1 Max with ionide 7.0.0. (all performance cores and fans to the max, melting aluminum :) ). Tried to let it for an hour hoping it will do it's work and calm down but didn't happen. Reverted to 6.0.6 and working again in quiet :)

This is probably due to a lot of rework that we are doing during checking. @Krzysztof-Cieslak has a draft PR to correct some of that that we are working through.

Can confirm this issue in v7.0.0 ( In v7.1.0 I was mostly impacted by #1769 ):

Windows 10
.NET SDK 6.0.303

Rollback to 6.0.6 seems to resolve issues.
Workaround is a manual restart of extension host in VSCode. But this pops up frequently enough that it's probably best to roll-back. Is there an easy way to trigger a restart of the Ionide extension only?

@kevingentile there is not. This was solved in 7.1.0, and #1769 should be resolved in the next version, so really all I can advise you to do is hold tight.

It's still not working on 7.1 for macos

Can you try with the AdaptiveLSPServer?

M1, Ionide v7.4.2, .net 7.0.200. CPU is stable. I've tried both with FSharp: Enable Adaptive Lsp Server enabled and not. For the project auctions-site it seems like the CPU issue is fixed.

.net is around 1.6 GB after maybe 30 minutes.

FWIW I think 1.6GB of memory usage on 64-bit out-of-proc for a project using FSharpPlus isn't too out of the ordinary.

It's now 1.8.

You may want to use some type of memory dump to analyze what is taking up memory. When I did it for my giant work project, it takes quite a bit of memory but it's almost entirely inside FSharp.Compiler.Service which we don't have much control over (please let me know if there's better memory controls).
Additionally try setting  DOTNET_GCConserveMemory=9 environment variable before starting vscode as I've noticed this will help the GC be more aggressive at cleaning up Large Object Heap allocations in FSharp.Compiler.Service.

I mean, there might be some memory leak. For my part the biggest issue is solved (that you couldn't use it at all due to high CPU).

Ok I've done a lot of memory performance tuning over the months.

If you're on macOS, ARM processor, and dotnet 6, you're out of luck. This is an issue in the runtime and there's not much we can do.
If you have a type provider, there was some bug in how we were using FCS https://github.com/dotnet/fsharp/issues/15014 but that seems resolved with one of the later versions.
For bigger projects there are some recommended settings.  The conserve memory configuration lets the runtime compact more often and even compacts the Large Object Heap which is often a cause of issues because of large source files
I also recently implemented https://github.com/fsharp/FsAutoComplete/pull/1123 which you can add the switch --source-text-factory=RoslynSourceText to enable. This should have less Large Object Heap hits.
We do use the Server GC by default which is pretty aggressive at allocating memory.  If it still seems like an issue you can play with certain environment variables like Heap count so you don't have as many heaps but still get some benefits of Server GC.  Otherwise you can turn it off and use workstation but know that will come with some significant performance hits since FCS and by proxy FSAC are garbage collector intensive. I recently added the ability to change these settings directly rather than through some environment variables.
Lastly using dotnet-dump then using PerfView or DotMemory.  The analysis can be quite a rabbit hole but you should be able to get some indication of what's eating up memory.


Move general information for a Thing

Move the meta information for a Thing from an app to maybe some form of dropdown.

Any meta information that an owner would need or find useful can be moved to the page described in #89.


refactor(es6) upgrade ModuleNotFoundError to ES6 class

What kind of change does this PR introduce?
refactor, ES5 => ES6
Did you add tests for your changes?
All existing tests pass
If relevant, link to documentation update:
N/A
Summary
upgrade ModuleNotFoundError to es6
Does this PR introduce a breaking change?
N/A
Other information

Thanks


Add new api functions to peek at network data.

New functions:
mbedtls_net_recv4 (mbedtls_net_recv + flags argument)
mbedtls_ssl_read4 (mbedtls_ssl_read + flags argument)
The functions accept a flag argument that optionally specifies extended behavior.
Supported flag arguments:
MBEDTLS_NET_MSG_PEEK - Read data from a (net/ssl context) without removing the data from the socket buffer (MSG_PEEK functionality)
This resolves #551

By sending in a PR, we'll need a signed CLA before we can continue to work with this issue.
So to accept your current contributions or any future contributions we will need a Contributor’s Licence Agreement (CLA) signed or authorised by yourself. You can find an agreement to sign here, which can be signed and returned to us, or you could create an mbed account and accept a slightly different agreement here with a click through if this is a personal contribution.

I have accepted CLA and with a mbed account.

Hi @CorvinM, could you please confirm your mbed account username, so I can cross-reference the CLA acceptance with your github account?
Thanks

Hi @CorvinM,
Could you confirm that this is your account? I know it looks obvious, but I'm required to confirm before I can accept the contribution, as I need to relate the mbed account to the github one.
Thanks for your understanding.

@sbutcher-arm Sorry for the delay, yes this is my mbed account.

Any update about it?

Pasting comment from #551
@CorvinM thanks for raising the issue #551 and making this PR. I would like to understand the motivation behind this change. MSG_PEEK is generally used to receive a header carrying length indicator from the TCP stream and do required buffer allocations. Is this the use case you intend to solve?
There are other ways to handle this scenario within the application code rather than adding this change in the library.


Peer to peer code review.

I would suggest you use relative units while defining your width. This makes your page more responsive.

Nice CSS code structuring. I like the flow and code arrangement.

Good work so far. The workflow of your project is incredible. Creativity in your personalized design is good, keep it up.


[BugFix] show_data rest api support cloudnative table (#29473)

(cherry picked from commit 5df983ccd3ea03e1b0bc98588bc2c596df755132)
Fixes #issue
What type of PR is this:

[X] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[X] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[X] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

manual backport #29473 to branch-3.0

[FE PR Coverage Check]
:heart_eyes: pass : 7 / 8 (87.50%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/http/rest/ShowDataAction.java
7
8
87.50%
[72]


Support KiCAD 8.0

Here's what needs to be done to support KiCAD 8:

[X] GetSheetfile and GetSheetname (Thanks @OfficialDyray)
[X] Update FP_TEXT to PCB_FIELD (Thanks @OfficialDyray)
[ ] nets.AppendNet in find_or_set_net

I can't figure out how to add a net to the API, or even if I need to bother at all. I'll  run some experiments and then decide, but if you know something about this let me know.

I feel like adding Nets to the PCB shouldn't be necessary. Won't all the Nets we need exist from importing the schematic footprints? Also- Thanks you for taking the time to write this plugin, I have found it very useful.

I think its used to associate traces with nets. I've no idea if KiCAD will infer the nets automatically, or something else.

Under kicad 6.0
nets.AppendNet() appears to add a new net to the board/NETINFO_LIST:
>> import pcbnew
>> board = pcbnew.GetBoard()
>> nets = board.GetNetInfo()
>> newNet = pcbnew.NETINFO_ITEM(board)
>> newNet.SetNetname("test");

>> board.GetNetCount()
1

>> nets.AppendNet(newNet)
>> board.GetNetCount()
2

Under kicad 8.0
I'm not sure how to add a net to the NETINFO_LIST or even if its possible in 8.0.
One option is to just return the Default (Unassigned) net so that Kicad can figure out how to deal with it: board.GetNetsByNetcode()[0]
or
nets.NetsByNetcode()[0]

I'll take a look at this soon, sorry about the delay. Thanks for figuring this out!

We could just return the  net: board.FindNet(0)

That works great! Thanks for figuring this out, I'll merge this to master now.


Fix issue where cards did not align correctly on learn page

This PR closes issue #25
Description:

The cards on the learn page were not aligned correctly;

Before:

After:

Nice work @inovux
Keep contributing 🚀


issues.get is not a function

I'm seeing this error when trying to get one issue
issues.get(issueNumber, function (err, issue) {
       ^
TypeError: issues.get is not a function
  at getIssue (hearForGithubIssues.js:12:9)
  at Object.<anonymous> (hearForGithubIssues.js:67:10)

Code:
const github = new Github({
token: token,
    auth: 'oauth'
})
const issues = github.getIssues(userName, repoName)
issues.get(issueNumber, (err, issue) => {
   if(err){
       error(err)
        return
   }
   callback(issue)
})

Not sure what's causing this, investigating.

I'm using ES6 to write the code so i'm importing the code like this
import github from ' github-api'

I found the issue.. https://github.com/michael/github/blob/v0.11.2/src/github.js#L947 Is happening in the npm version (v0.11.2)  ...

Looks like that functionality is as-yet unreleased.

@msdark v1.0.0 has been released, please re-open if this is not fixed.


chore: update numaflow-go to v0.7.0-rc2

Run go mod tidy?

since we use local references they dont show up in go.sum + script automatically runs go mod tidy


url parameter removed when cleanUrls: true

when the config cleanUrls is set to true (by default)
and the requested URL is a file name with an extension
and has some parameter in it ex:
/index_2.html?foo&bar=1

the server rewrite the url to
/index_2

and remove the extension AND the url parameters
those URL on the other hand works as intended :
/index_2?foo&bar=1
/?foo&bar=1

/folderName?foo&bar=1

/folderName/?foo&bar=1

question :
is it as intended ?
If the response is "yes, you should set cleanUrls to false" then the README should be mentioning those cases
but I think the cleanUrls setting should set urls like :
/index.html?foo&bar=1
to
/?foo&bar=1

it would be more useful

shameless self-promotion alert:this feature is fixed in my @warren-bank/serve fork of serve


Cythonize WindowedValue class.

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[ ] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[ ] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[ ] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

Superseded by https://github.com/apache/incubator-beam/pull/691


Release 3.3.0

This release will close #87 after shipping.

[x] Implement function
[x] Testing
[x] Add a document
[x] Bump version
[x] Release to PyPI

Shipped.
https://pypi.org/project/pip-licenses/3.3.0/

Shipped.
https://pypi.org/project/pip-licenses/3.3.0/


compatibility of openff-2.1.0 and Amber 99SB-disp ff

Hi,
I would like to simulate a disordered protein in complex with a small molecule. I have already obtained the OpenFF-2.1.0 parameters for the small molecule for Gromacs. I noticed that the recommended Amber force field for proteins in combination with the OpenFF-2.1.0 for the ligand is AMBER ff99sb-ILDN*, but this one is not optimized for disordered proteins. Therefore, I would like to know if I can use the OpenFF-2.1.0 parameters for the small molecule in combination with the Amber 99SB-disp force field, which is suitable for simulating disordered proteins.
Thank you

Hi @8marmar8,
I think the Parsley and Sage force fields are in principle compatible with most AMBER protein force fields - Both FF lines were trained mostly to QM targets using comparable levels of theory. We haven't done any validation/testing of Sage with AMBER 99-disp but I don't think it's an unreasonable combination.

I noticed that the recommended Amber force field for proteins in combination with the OpenFF-2.1.0 for the ligand is AMBER ff99sb-ILDN*

I'm curious where you saw this recommendation - generally we put together examples using AMBER ff14SB because it's the most recent one that we could port into the SMIRNOFF format (ff19 had some technical incompatibilities at the time). Someone may have good reasons for suggesting a Sage/ff99 pairing but I'm unaware of that argument - I'd expect newer AMBER FF lines to have improved accuracy (though in the case of specific domains like disordered proteins something like 99-disp makes sense).

I'd comment that there's been very little research (if any?) on what "compatibility" means with respect to protein and small molecule force fields, and I think we have carefully avoided making any firm recommendations for exactly that reason. Some of the AMBER devs have said something informally to us along the lines of "compatibility is overrated" but I think this is pretty much an area of unexplored science. Personally I'd be comfortable using OpenFF with typical AMBER family protein force fields for now, but that's up to you and I believe unexplored.

Thank you @j-wags and @davidlmobley for your quick response.
Regarding the suggestion of using the AMBER ff99sb-ILDN* force field, I found this recommendation in a recent article: [https://doi.org/10.1021/acs.jctc.3c00039]. However, I also previously read your suggestion to use the AMBER ff14SB force field.
Regarding my uncertainty about whether to use the Amber 99SB-disp force field, it's precisely because I'm working with an intrinsically disordered protein and I need to analyze its behavior in complex with a molecule. Therefore, I require an accurate force field for the protein as well. I haven't come across any recommendations for using AMBER ff14SB with intrinsically disordered proteins.

Ahh, there must have been a technical reason at the time for using ff99. Thanks for asking a great question - FF compatibility is tricky and others would probably find this discussion useful. I'm going to move this issue to our "Discussions" repo for discoverability.


CMSPLT-24 : Fix display of tooltips on jsp

Add missing jquery.ui.tooltip js and css : see http://fluidproject.org/releases/1.4/demos/inlineEdit/rich/html/inlineEdit.html

Hey @auxepaul, it looks like some merge conflicts have cropped up, could you resolve them?

Hey @auxepaul, thanks for the pull request!
Unfortunately are merge conflicts that have cropped up that are blocking these changes from being merged.
I'm going to close this PR, feel free to re-open it if you have time to resolve the merge conflicts.


Test cordova-livereload-plugin with Windows 10

This is to make sure that livereload works well on Windows 10.

Windows 10 support will not be worked on for now.


Home page

please check the chnages i made to the readMe file and feel free to adjust.

Make sure to delete both foodpage and drinkpage files from your HomePage branch, because if we approve your pull request, it's going to override both our files. Your branch should only have your homePage HTML and the CSS and JS files for your homePage and not have the files in the other two branches.

i deleted the duplicated files . not sure how i got them there .


feat: added theme data

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Manual Testing
[ ] Test B

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

update: inayos ko na

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add locale and guild_locale properties to interactions.

Summary
The API is already providing those values.
ref:
https://github.com/discord/discord-api-docs/pull/4265

Checklist

[x] If code changes were made then they have been tested

[x] I have updated the documentation to reflect the changes
[x] I have formatted the code properly by running black .

[ ] This PR fixes an issue
[x] This PR adds something new (e.g. new method or parameters)
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)

If guild_locale always exists in guilds, it should be added to GuildCommandInteraction as well, with the Optional stripped


"istioctl wait" support for XDS Events

istioctl wait
Thought experiment.  Suppose fortio client runs in canary control plane and echo server runs in default/master control plane.
User applies a DestinationRule and waits for it.
The optimum wait is for the control canary control plane only.
User applies an AuthenticationPolicy and waits for it
The optimum wait is for the default/master control plane only
It is fine to wait for all control planes, but it is expensive to find them all!
Need design for correct behavior without --revision [mitch?]
Need implementation of correct behavior [mitch?  ed?]

@costinm committed to delivering a proof of concept design for how this would work on 5/18.  I am waiting for his proof of concept before moving forward, as it is not clear to me how this is supposed to work.

@therealmitchconnors Should we retarget this for 1.8?


lineEndings

for consistency it would be good to have a file level check for line endings, such as:
lineEndings: 'LF'
Valid values would be:  LF / CRLF
The severity level would be WARNING
The check would be simple:

if LF then there would be no instances of CR
if CRLF there would be no standalone instances of CR or LF

If the value is missing, null or undefined then the check would be switched off (no default applied).

Closing as this is now a feature

re-opening (it's not documented)


Coverage in GH Action

Ref #170

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@1a1aec9). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #226   +/-   ##
=========================================
  Coverage          ?   33.89%
=========================================
  Files             ?       24
  Lines             ?    10746
  Branches          ?        0
=========================================
  Hits              ?     3642
  Misses            ?     6738
  Partials          ?      366

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a1aec9...51ae188. Read the comment docs.

:exclamation: No coverage uploaded for pull request base

This should be resolved once the PR merges and the CI uploads report from master


Adding Footer to the website

Please, go through these steps before you submit a PR.

[x] My Pod Leader knows I'm working on this Pull Request
[x] I've explained what the Pull Request is adding.
[x] I've explained why this is important.

I have added the footer with details according to assignment given, also i have updated the Read-me of the project to help Linux users on how to install Ruby and Bundler

Wells -

Like the footer design and placement
Love the logo! ❤ Really good use of MLH Brand Colours.

Improves -

Accessibility - The grey colour on the blue background of the footer gives an accessibility rating on 2.87
This can be improved by changing the font colour to something near to white like #f8fafc or #fafafa

Similarly, the font colours of pod name "Javascript Jaguars" which is dark blue on orange background can be changed to white or similar to white because it is clashing with the background.

Please have a look and update the code, fantastic work otherwise! @Pheogrammer

I have updated the footer, used color #c9c9c9 because it is a little not lighter than the headings

Had to close this one because of the conflicts, but created another one here https://github.com/MLH-Fellowship/prep-portfolio-23.MAR.PREP.2/pull/32


Bug Report: Issue with "Load Ideas" for Domains Containing Hyphens

Docker Version 2.0.6
Description:
In the "Ideas" section (domain/ideas/), the "Load Ideas" functionality does not work correctly for domains containing hyphens.
For domains like xyz.com, the page loads ideas as expected.
For domains with hyphens (e.g., x-y-z.com), the page does not function correctly.

Reproduction Steps:
Navigate to domain/ideas/ for a domain with hyphens (e.g., x-y-z.com).
Observe that the page fails to load ideas.

Observed Behavior:
The application incorrectly attempts to call the API with the following endpoint:
https://xyz.com/api/ideas?domain=x_y_z-com
Expected Behavior:
The correct API endpoint should be:
https://xyz.com/api/ideas?domain=x-y-z.com
When the API is manually accessed with the correct endpoint, it works as expected, confirming the API itself is functioning correctly. However, the page within the domain/ideas/ section does not load ideas for hyphenated domains.
Additional Information:
Despite this issue, the application saves the correct file in the Data folder:
IDEAS_x.y.z.com.json
This indicates the file handling is correct, but the logic for generating API requests on the page needs to be fixed for domains containing hyphens.

i have this Error: Error Loading Keyword Ideas
After i updated on the new version

@ingeniumdesign Please check the log of your docker instance and if there's an error message, share it here.

After Docker Restart, it works now.


Created network interfaces aren't in get_interfaces on Windows

I like that this has more features and details than the network-interface crate, but it has problems on Windows.
[package]
name = "testbin"
version = "0.1.0"
edition = "2021"
publish = false

[dependencies]
netdev = "0.30"
network-interface = "2.0"
tun2 = { version = "3" }

use tun2::{configure, create};

fn main() {
    let device = create(configure().tun_name("utun42").up()).unwrap();

    for ni in
        <network_interface::NetworkInterface as network_interface::NetworkInterfaceConfig>::show()
            .unwrap()
    {
        dbg!(ni.name);
    }
    for ni in netdev::get_interfaces() {
        dbg!(ni.name);
        dbg!(ni.friendly_name);
    }

    drop(device);
}

Running on Linux with cargo b && sudo ./target/debug/testbin gives exactly what I expect,
[src/main.rs:10:9] ni.name = "eth0"
[src/main.rs:10:9] ni.name = "utun42"
[src/main.rs:10:9] ni.name = "lo"
[src/main.rs:13:9] ni.name = "lo"
[src/main.rs:14:9] ni.friendly_name = None
[src/main.rs:13:9] ni.name = "eth0"
[src/main.rs:14:9] ni.friendly_name = None
[src/main.rs:13:9] ni.name = "utun42"
[src/main.rs:14:9] ni.friendly_name = None

But on Windows (cargo r, copy the DLL from https://github.com/tun2proxy/wintun-bindings/tree/master/wintun/bin/amd64 into the /target/debug folder and run cargo r in a privileged shell), I get
[src/main.rs:10:9] ni.name = "utun42"
[src/main.rs:10:9] ni.name = "Ethernet 2"
...
[src/main.rs:13:9] ni.name = "{E5A5F923-716B-487F-B647-0523E95CE909}"
[src/main.rs:14:9] ni.friendly_name = Some(
    "Ethernet 2",
)
...

Besides being inconsistent with the name and friendly_name (it should preferably set friendly_name to the same as name if it doesn't exest, so that I don't have to configure around it), it doesn't show "utun42" on windows.

Also, is it possible to look up an interface by ID (I am currently only looking up by name for workaround reasons) instead of needing to iterate through an array?


Added openuniversiteit.be

After ou.nl (Its Dutch counterpart) has already been added openuniversiteit.be should be added too.

emailaddress for Belgian students look like
<EMAIL_ADDRESS>


Error acquiring lock: daemonsets.apps "kured" is forbidden: User "system:serviceaccount:kube-system:kured" cannot update resource "daemonsets" in API group "apps" in the namespace "kube-system""

On the last version from master (4beddb5338)
Here si my logs
 time="2019-11-21T10:55:37Z" level=info msg="Kubernetes Reboot Daemon: master-4beddb5"
time="2019-11-21T10:55:37Z" level=info msg="Node ID: aks-nodepool1-25168911-0"
time="2019-11-21T10:55:37Z" level=info msg="Lock Annotation: kube-system/kured:weave.works/kured-node-lock"
time="2019-11-21T10:55:37Z" level=info msg="Reboot Sentinel: /var/run/reboot-required every 1m0s"
time="2019-11-21T10:55:37Z" level=info msg="Blocking Pod Selectors: []"
time="2019-11-21T10:55:37Z" level=info msg="Reboot on: SunMonTueWedThuFriSat between 00:00 and 23:59 UTC"
time="2019-11-21T10:56:18Z" level=info msg="Reboot required"
time="2019-11-21T10:56:18Z" level=fatal msg="Error acquiring lock: daemonsets.apps \"kured\" is forbidden: User \"system:serviceaccount:kube-system:kured\" cannot update resource \"daemonsets\" in API group \"apps\" in the namespace \"kube-system\""

My rbac config:
apiVersion: rbac.authorization.k8s.io/v1
      kind: ClusterRole
      metadata:
        name: kured
      rules:
      # Allow kured to read spec.unschedulable
      # Allow kubectl to drain/uncordon
        - apiGroups: [""]
          resources: ["nodes"]
          verbs:     ["get", "patch"]
        - apiGroups: [""]
          resources: ["pods"]
          verbs:     ["list","delete","get"]
        - apiGroups: ["extensions"]
          resources: ["daemonsets"]
          verbs:     ["get"]
        - apiGroups: [""]
          resources: ["pods/eviction"]
          verbs:     ["create"]
        - apiGroups: ["apps"]
          resources: ["daemonsets"]
          verbs:     ["get", "list", "patch", "delete", "put"]

The log was explicite, just replaced put by "update" and it works.
Thanks for your work.


Improve AppBarButton sub item chevron visuals and cusomizability.

Add OverflowGlyph, OverflowFontSize, and OverflowMargin resources to allow for customizations of the glyph in both places seperately.
Expose the chevron margin as a resource to enable cusomtization.
Apply chevron foreground color in pointer VSM.

/azp run


BUG: Ens lookup does not work with testnet

Environment information

ape and plugin versions:

Installed Plugins:
vyper       0.5.0
ens         0.5.1
alchemy     0.5.0
solidity    0.5.1
polygon     0.5.0a1
$ ape --version

0.5.2

$ ape plugins list
# ...copy and paste result of above command here...

Python Version: Python 3.8.10
OS: Linux

What went wrong?
ape console --network ethereum:goerli:alchemy

In [1]: from ape.types import AddressType
In [2]: convert("snackoverflow.eth", AddressType)
WARNING: Unable to connect to mainnet provider to perform ENS lookup. Try changing your default mainnet provider.

How can it be fixed?
We should default lookup in mainnet and return the address in the console

Solution:
Right, you connect to goerli in the console but when it resolves the name, it uses mainnet and that is fine so long as you tell it the provider for mainnet somewhere in the config
--Jules
ethereum:
  mainnet:
    default_provider: alchemy

It uses your default mainnet, as you pointed out! And since then, Ape tries to find better URLs using evmchains when you havent set one, so more chance of success


Add social media and feedback section in blog page

@RituKumari98 Could you please assign this issue to me under the GSSOC'24 label?

I would like to contribute for this project. Please assign this task to me under GSSoC'24 with required labels.
@RituKumari98

i would like to work on this issue. please assign me this.


[Feature Request]: Adding in female announcer and ending sequences.

Describe the feature you'd like to see added
Have noticed that the PC version seems to be missing the female voice announcer say the model name of the car you select on the car select screen and also the name of the music track selected. Also the ending video 'skits' that accompany the ending credits when you complete any course in the standard Outrun modes (each course has a different video 'skit') appear to be missing??. These are present in the Outrun Online Arcade that was released on the Xbox 360 and PS3 and I believe Outrun 2 Coast 2 coast on the PS2 and Xbox do you have plans to add these in a future update?

Are you playing with a non-English language? Because the OR2SP announcer is heard only with English language.
See issue #14.

Hi, first of all great work on this mod....I love it!!!!.
I had to check, yeah its defo in English Lang....or though I couldn't see an option to change the lang. Here's a video showing the issue.....
https://youtu.be/ce6N2hNXcLo
Thanks

Hi, first of all great work on this mod....I love it!!!!.
I had to check, yeah its defo in English Lang....or though I couldn't see an option to change the lang. Here's a video showing the issue.....
https://youtu.be/ECAtFF_PC08
Thanks

... oh. Now i understand. What you're asking for simply does not exist in Coast 2 Coast mode.

Yeah, also the "skits" you mentioned are the endings to Heart Attack in 2SP.

The announcer is only there in the "Outrun2SP" mode on the menu, the C2C menus are silent

Yeah, also the "skits" you mentioned are the endings to Heart Attack in 2SP.

Nah there defo in the single player standard outrun mode

The announcer is only there when you switch to "Outrun2SP" mode from the menu, the C2C menus themselves are silent.

Ah yes you are correct. Thank you for highlighting that 👍🏻


Properly typehint components with JSX dot notation

How do I properly typehint a component so I can render both <Component /> and <Component.Variant />
I tried something like this:
type Props = {
    x: number
}

declare class _Component {
    static Variant: Variant,
}

const Component = (props: Props) => {
    return (<span>{x}</span>)
}

Component.Variant = ComponentVariant //imported from another module, a stateless functional component

const ComponentClass = Class<_Component> = (Component: any)

export default ComponentClass;

The above doesn't give me any errors in the Component file, which is good. But when I try to render I get stuff like this:
_Component [1] is incompatible with React.Component [2].
     357│               <Component
     358│                 x={14}
     360│               />

     /private/tmp/flow/flowlib_34952a0/react.js
 [2]  26│ declare class React$Component<Props, State = void> {

     src/components/Component/index.js
 [1] 269│ const ComponentClass = Class<_Component> = (Component: any)

Cannot create Component.Variant element because prototype [1] is not a React component.

     204│             <Component.Variant
     205│               x={14}
     206|               y={15}
     207│             />

     src/components/Component/index.js
 [1] 248│   static Variant: Variant,

Like this?

I don't understand why are you trying to type a function as a class.

Wow, must have done something wrong. It works indeed like that. Got the crazy class solution from another github issue. Thanks!


[CONTRACTS] nullifier_registry contract functions

Description
In contracts/src/contracts/nullifier_registry add the following functions to the nullifier_registry.cairo contract:

[ ] add_nullifier
[ ] add_write_permissions
[ ] remove_write_permissions
[ ] get_writers

These require storage items: mappings for nullifiers and writers. Span for writers.
Emit an event for each function that makes changes to the storage.
Add tests for expected storage changes and getter functions.
For reference see the Solidity implementation of zkp2p.
Acceptance criteria
The contract builds. It emits the corresponding event for each function. Tests pass.

Yes

Hi @lana-shanghai .


node session update

lora-app-server: 0.9.1
in the node interface，i change the ADR value and submit it.
then lora-app-server update the node-seesion into postgres, but it don't save node-session to loraserver.

but if i delete or activate node. the lora-app-server can push node-session to loraserver, and loraserver change it in redis server.
so my question is that is this specially designed for any purpose i don't konw?

That is intentional, please see the note on top 😉

Please note that changes made below (when updating a node) only have effect after (re)activating the node (either ABP or OTAA).


skidded from doenerium

this is js sad

bro r u serious 💀💀
doenerium is 4355 line my stealer 1347 line how is possible, js is a very wide language i sug u open ur eyes

how to use . please help me


Improve API consistency for solid summation

These are conceptually the same but only the first works
A = Sphere(1)
A + A # ok
A + A + A # ok

A = Sphere(1).solid()
A + A # ok
A + A + A # does not work

ValueError: Only shapes with the same dimension can be added

Fixed


vendoring: now controller-gen should not be required

Since we now run go install to get the controller-gen dependency,
referencing it in the go modules is no longer required.
Signed-off-by: Miguel Duarte Barroso<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 40.548%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
444

Relevant Lines:
1095

💛  - Coveralls


Update smoketests to match SGO changes

Update the smoke tests to account for the changes in https://github.com/infrawatch/smart-gateway-operator/pull/41
Changes in https://github.com/infrawatch/smart-gateway-operator/pull/41 needs to merge before this one.

 Create STF upgrade process

I made similar changes in the stable release tree. Forgot I had this open. Only difference is I missed adding the echo separation lines. :man_shrugging:


Feat xdsroute parse

What is the purpose of the change
相关 issue #10581, 解析路由规则参考了 https://github.com/grpc/grpc-java 部分代码.

[x] XdsRoute 监听 RDS 获取路由规则，完成 uri、head 匹配功能，监听 EDS 获取 endpoint 数据，完成对实例 subsets 的适配；
[x] 支持集群权重配置

Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

I will be looking into this feature.

still working on it


Sign in, Sign out not working

rails: 5.1.4
ruby: 2.4.0
devise: 4.3.0
devise_auth_token: 0.1.42
I'm using Postman to do the tests.
Following the instructions and I can put the things to work. But unfortunately, not so properly.
When the sign in is done, I can receive the user informations, but no header with the client and the access-token was returned to me.
So I then tried to use the sign out. I inspected the token and the client that I should use and set it in the postman test. But this validation fails:
::BCrypt::Password.new(token_hash) == token
It will not fail if I change to ::BCrypt::Password.new(token_hash).to_s == token.
How can we solve this?

Are you getting the value for token from the db? Because that won't work. We don't store tokens in plain-text for the same reason that passwords shouldn't be stored in plain text. See here for more info on how bcrypt-ruby works.

we also just upgraded to devise 4.3 and suddenly no longer receive the auth headers after sign-in

headers also missing, recently upgraded to devise 4.3.0 which seemed to break things...
rails: 4.2.10
ruby: 2.4.0
devise: 4.3.0
devise_auth_token: 0.1.42

@johnnagro @Danilo-Araujo-Silva I did find some devise v4.3 issues when testing the other day. Can you try running against master and see if that resolves the issue? We're about to cut a release and I'd like to make sure it's working with the latest devise

@lynndylanhurley we will try that right now

set_user_by_token is called when current_user is called during sign-in, probably to serialize the resource (user) object. set_user_by_token nils out @resource - we have a lead as to why, will update shortly...

@lynndylanhurley our issue seems to relate to our use of single table inheritance and the class check, as outlined in the PR we just submitted...
@Danilo-Araujo-Silva are you also using single table inheritance on your main resource object?

Seems that the @Danilo-Araujo-Silva issue is different, please reply what @lynndylanhurley asked the first time, otherwise we're closing this in 7 days.

Hi guys, I think, at least for my use case, we can close this issue. I don't know if it solved at all. But I found a way to use the devise itself but I not working with rails right now too, so probably I will can not test it soon.


Support for external deps

Following the discussion from https://github.com/babel/website/issues/1302.
It would be great to allow externals for both Browserify and Rollup. What do you think @Rich-Harris?
PS: i'm working on it

Imagine I want to dedupe babel-types (babel-plugin-ivi-jsx is requiring it):
<script type="text/javascript" src="http://localhost:9000/babel-types"></script>
<script type="text/javascript" src="http://localhost:9000/babel-plugin-ivi-jsx"></script>

When I declare babel-types as an external dependency, browserify fails at runtime with Cannot find module 'babel-types'. In the page babel-types is a available as window.babelTypes. I don't know how to tell browserify to use it.
Maybe we could generate a fake package called babel-types somehow which just contains a alias statement: module.exports = window.babelTypes but sounds hacky and fragile.
Do you have an idea?

What about allowing externals to be passed as querystring parameters? For example /babel-plugin-ivi-jsx?externals[babel-types]=babelTypes could do the equivalent of doing this in a Webpack config:
externals: {
  'babel-types': 'BabelTypes',
}

Yeah, configuration is only possible through query parameters (because of the CDN).
I planned something like this: /babel-plugin-ivi-jsx?externals=babel-types,babel-core.
I don't get how browserify is working with externals, they are not passed as arguments as with Rollup. Maybe @Rich-Harris could help us here.

This seems like a good. Afraid I have no idea how to make it work with Browserify! 😬

Our project is using browserify, you may want to take a look at the gulpfile. My two cents...

We need this for the Babel REPL. Since Browserify is only used as a fallback, I think it's fine to support externals only when you bundle with Rollup (and your module supports it).

Well now we have a PR https://github.com/Rich-Harris/packd/pull/37 but I don't get it, it can't work. If someone has the time to look at it :pray:


Using only InputsPlugin and EnumsPlugin generates to much code

Problem
The code-generation produces to much output if you're only interested in generating input types and enums.
The result isn't syntactically wrong, but not quite beautiful pydantic code.
Note: I overwrote the input-type base to generate code, that doesn't require turms installed in the final environment.
Setup
Project layout
| - graphql.config.yaml
|
| - graphql
|   | - schema.graphql
|
| - generated
|   | - types.py

graphql.config.yaml
projects:
  default:
    schema: /graphql/**/*.graphql
    documents: graphql/**.graphql
    extensions:
      turms:
        out_dir: /generated
        generated_name: types.py
        plugins:
          - type: turms.plugins.enums.EnumsPlugin
          - type: turms.plugins.inputs.InputsPlugin
            inputtype_bases:
              - "pydantic.BaseModel"
        processors:
          - type: turms.processor.black.BlackProcessor

schema.graphql
type Query {
    hello(orderBy: HelloWorldOrder! = ASC, filter: HelloWorldFilter,
        first: Int, last: Int, before: String, after: String): [World!]!
}

enum HelloWorldOrder {
    ASC
    DESC
}

input HelloWorldFilter {
    search: String!
}

type World {
    message: String!
}

types.py
from turms.types.object import GraphQLObject              # <-- not required
from turms.types.object import GraphQLObject              # <-- duplicate
from pydantic.fields import Field                         # <-- not required
from typing import Optional, List, Dict, Union, Literal   # Dict, Union and Literal not required
from enum import Enum
from pydantic import BaseModel

class HelloWorldOrder(str, Enum):
    None                                   # <-- Unused statement
    ASC = "ASC"
    DESC = "DESC"

class HelloWorldFilter(BaseModel):
    None                                   # <-- Unused statement
    ids: Optional[List[str]]

Expected Output
types.py
from typing import Optional, List
from enum import Enum
from pydantic import BaseModel

class HelloWorldOrder(str, Enum):
    ASC = "ASC"
    DESC = "DESC"

class HelloWorldFilter(BaseModel):
    ids: Optional[List[str]]

It seems, that None in
class XXX:
    None

is the result of a missing description in the GraphQL-Schema.

Both topline imports result from the default-config values object_bases and interface_bases.
https://github.com/jhnnsrs/turms/blob/b96ede2da6e21609489f60b84404fb7661321726/turms/config.py#L5-L12
There should be a check, if those imports are required.
Circumvention is possible by setting those values to an empty list in the graphql.config.yaml.

It seems, that None in
class XXX:
    None

is the result of a missing description in the GraphQL-Schema.
Corresponding code should be line 126:
https://github.com/jhnnsrs/turms/blob/b96ede2da6e21609489f60b84404fb7661321726/turms/plugins/inputs.py#L120-L127
Possible fix:
fields = []
if type.description:
# or
if type.description is not None:
    fields.append(ast.Expr(value=ast.Constant(value=type.description)))

Should be fixed in in latest push to master !

Both topline imports result from the default-config values object_bases and interface_bases.
https://github.com/jhnnsrs/turms/blob/b96ede2da6e21609489f60b84404fb7661321726/turms/config.py#L5-L12
There should be a check, if those imports are required.
Circumvention is possible by setting those values to an empty list in the graphql.config.yaml.

Good point on the too many imports! I think that is something that needs to be changed on the plugin level, so that every plugin can dynamically add imports to the tree, also some sort of global "exports" of types might be a good idea to support multi file output (like a global registry for on module / file basis for the whole schema). Any suggestions on that? :) Thanks for trying things out!

If those ast.AST nodes are hashable, you might just use a Set instead of a List when collecting the generated Imports, especially here:
https://github.com/jhnnsrs/turms/blob/b4bac8bafc1245f833a1c10c144b52fe5d0c8e6d/turms/run.py#L138
Then change += to |= which should avoid duplicates.

Or simply add IsortProcessor like you did with Black 😄

Or simply add IsortProcessor like you did with Black 😄

Like to cheat but that would be cheating too much for such a young project :D we could still add it for the sorting part, but i think we should handle that internally as well.

Against duplicates
If those ast.AST nodes are hashable, you might just use a Set instead of a List when collecting the generated Imports, especially here:
https://github.com/jhnnsrs/turms/blob/b4bac8bafc1245f833a1c10c144b52fe5d0c8e6d/turms/run.py#L138
Then change += to |= which should avoid duplicates.
Against too many imports
The current generate_imports methods create the maximum of theoretically possible imports. We could add an additional step, that parses the generated body for required imports before returning. This would be sth. like creating a boolean mask over all imports.
As an alternative you could push imports to a Set acting as your plugins registry, everytime a type that needs to be imported is used. E.g. self.imports.add(<node>)

Very good points! I think a registry for each plugin and a "module" level plugin keeping track of eternal imports and cross references of types/fragments between the plugins is a must (right now i have some ugly globals for this anyways). I also feel that might help with "multi" file idea e.g. one like enums.py, inputs.py, .. anything on the wishlist for that? ;) i think i will also follow a bit more github etiquette and push no longer to master :D

For the wishlist, I'd be fine with a single file for all types, since it's generated code anyways and every IDE should have proper search functions to get you where you want.
I'd warn you - by painful personal experience - that splitting graphql-models into multiple python files, can send you straight into the circular imports hell 😉

Newest push to master should now fix this issue:
We have a global registry for imports, which generates the import only if it has been added by any plugin, also isort processor is now available ;) Happy to hear feedback on that :)

your wish is my command :D

Closing due to nice work of yours 🚀


Adding an option to suppress missing mock warnings.

This is useful if you're testing large components that make queries or mutations that you're not interested in the response as part of the test. Reduces console spam at the risk of missing wanted warnings.
Open to any suggestions!

@martdavidson Thanks, I'll release 2.0.0 with this added in the next 24 hours.

@martdavidson Released 2.0.0 just now.

Got it! Thanks :)


Fixed issue with BADA performance in descent

Fixed an issue with the BADA performance model in descent where the model did not manage to match the vertical rate. It is now possible to descent with as little power as idle.
As far as I understood, one of the issues was that the member bs.traf.actwp.vs was set correctly in the method Autopilot.ComputeVNAV() and then (incorrectly) overwritten in Autopilot.update(). Additionally, the BADA model did not always correctly compute the thrust at negative vertical rates.
NOTE: the changes should be reviewed. I'm quite sure they are correct, but a second pair of eyes wouldn't hurt.

Hi @rmonstein, thanks for the PR. It has a couple of issues, however, and indeed the autopilot and perfbada suggestions need to be reviewed. You should also first update to the current version of the bluesky master, because right now your PR tries to undo a bugfix commit in autopilot.py. Also this PR includes wrong changes in perfbase and the notebook example. I commented on these in PR #341. @ProfHoekstra, can you have a look at the suggestion about a possible erroneous overwrite of data in autopilot.update? @junzis, can you see if the proposed change in perfbada makes sense?

Good find. The update function of the autopilot was at some point scheduled at a different frequency than update_fms, that's why it was done at two locations. This change in scheduling however has caused a lot of problems (liek aircraft returning at the end of the route to the last waypoint), so it has been reverted and both update as well as update_fms are called synchronously. This makes this second call indeed unnecessary. I'll fix it. Thanks!

@rmonstein, it seems that the merging with main branch overwrote some of your code in the first commit. Would you please make a new PR based on the most recent main branch of BlueSky?

Thank you all. I will create a new PR based on the current version of the master soon and will duplicate the changes I made.

Closing this PR in favour of #342.


[FEATURE] Add a dashboard for client to manage his data

Dashboard
Yes  the dashboard is for  the client to manage his data
and all that data that is relevant to the client as supplied by the api

ok


scipy == 1.4.1 fails to build on osx

Can we bump this version to >=1.7 in requirements (?) I tried a few different things here -- like installing into a fresh conda environment. For whatever reason, this old version of scipy fails to build -- but the newest version is okay.

Closed by #120.


Initial Implementation of FluentList and FluentListSection

Platforms Impacted

[X] iOS
[ ] visionOS
[ ] macOS

Description of changes
This is an initial version of FluentList and FluentListSection, wrappers around SwiftUI.List and SwiftUI.Section that apply the appropriate fluent style. The intention is that that these views can be used with FluentUI.ListItem to create a completely fluentized list or menu in SwiftUI.
Binary change
(how is our binary size impacted -- see https://github.com/microsoft/fluentui-apple/wiki/Size-Comparison)
Verification
Changes have been validated in the 2 ListItem demo controllers.

Visual Verification

Before
After

Screenshot or description before this change
Screenshot or description with this change

Pull request checklist
This PR has considered:

[ ] Light and Dark appearances
[X] iOS supported versions (all major versions greater than or equal current target deployment version)
[ ] VoiceOver and Keyboard Accessibility
[ ] Internationalization and Right to Left layouts
[ ] Different resolutions (1x, 2x, 3x)
[ ] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
[ ] iPad Pointer interaction
[X] SwiftUI consumption (validation or new demo scenarios needed)
[ ] Objective-C exposure (provide it only if needed)

Microsoft Reviewers: Open in CodeFlow

neither have anything Fluent specific attached to them yet right (fluent theme/color is still added externally)? we're just creating the wrappers here


977 | Squares of a Sorted Array| Python

Title - 977. Squares of a Sorted Array
What will change - Solution of problem 977 in python
Type of Issue -
Please add/delete options that are not relevant.

[x] Adding New Code
[ ] Improving Code
[ ] Improving Documentation
[ ] Bug Fix

Programming Language
Please add/delete options that are not relevant.

[x] Python
[ ] C++
[ ] Java
[ ] SQL

Self Check

Ask for issue assignment and wait to get assigned to it before making Pull Request.
Add your file in the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Discord server ✉ - https://discord.gg/CXksGdn
Happy Coding,

Please assign me

[x]  Assigned to @wpedrak

Please assign to me also


Why doesn't "sdk  list --installed" doesn't work in Ubuntu 19.04? And why its not mentioned in "sdk --help" section?

Usage questions should be asked on Slack (as is clearly stipulated in our contributor guidelines, you know the stuff you deleted before you opened this issue?).


Use Saxon-HE 12

Description
Change Saxon dependency to Saxon-HE 12.2.
Motivation and Context
Update dependency to latest stable Saxon.
Saxon release notes

This PR works in linux, but there is a strange mapref issue in Windows. Given a map referencing a submap:
<!-- map.ditamap -->
<?xml version="1.0" encoding="utf-8"?>
<?xml-model href="urn:oasis:names:tc:dita:rng:map.rng" schematypens="http://relaxng.org/ns/structure/1.0"?>
<map>
  <title>My Map</title>
  <mapref href="submap.ditamap"/>
</map>

<!-- submap.ditamap -->
<?xml version="1.0" encoding="utf-8"?>
<?xml-model href="urn:oasis:names:tc:dita:rng:map.rng" schematypens="http://relaxng.org/ns/structure/1.0"?>
<map/>

mapref fails in Windows as follows:
mapref:
   [mapref] Processing file:/C:/test_saxon/temp-SAXON/submap.ditamap
   [mapref] Processing file:/C:/test_saxon/temp-SAXON/map.ditamap
Error: Failed to run pipeline: Failed to replace temporary file C:\test_saxon\temp-SAXON\submap.ditamap.temp: Unable to delete file: C:\test_saxon\temp-SAXON\submap.ditamap

Maybe the newer Saxon is somehow leaving a lingering lock on the file?
This occurs only with the updated-Saxon distribution running in Windows. A development distribution running in Windows completes as expected.

The Windows mapref file lock issue still occurs with the updated branch.

I get the same problems when attempting to delete files on Windows. For example:
  [image-metadata] Failed to read image metadata: Failed to replace file:/C:/Users/RADU_C~1/AppData/Local/Temp/temp20230508122140090/concepts/glossarySepal.dita: Unable to delete file: C:\Users\RADU_C~1\AppData\Local\Temp\temp20230508122140090\concepts\glossarySepal.dita

If I set "store-type=memory" param the publishing works.

@chrispy-snps @raducoravu I pushed commit that may or may not have effect on this. Could you retry on Windows.

@jelovirt this still fails for me, as @chrispy-snps  says it starts failing in the maplink stage. As seen below the topic-fragment stage works and it probably calls the same API.
    topic-fragment:
    [topic-fragment] Processing file:/C:/Users/RADU_C~1/AppData/Local/Temp/temp20230508192807272/tasks/pruning.dita
    [topic-fragment] Processing file:/C:/Users/RADU_C~1/AppData/Local/Temp/temp20230508192807272/topics/care.dita
    [topic-fragment] Processing file:/C:/Users/RADU_C~1/AppData/Local/Temp/temp20230508192807272/tasks/gardenPreparation.dita
    [topic-fragment] Processing file:/C:/Users/RADU_C~1/AppData/Local/Temp/temp20230508192807272/topics/introduction.dita

    chunk-check:

    chunk:
        [chunk] Processing file:/C:/Users/RADU_C~1/AppData/Local/Temp/temp20230508192807272/flowers.ditamap
       [chunk2] Processing file:/C:/Users/RADU_C~1/AppData/Local/Temp/temp20230508192807272/flowers.ditamap

    move-meta-entries:
    [move-meta] Processing file:/C:/Users/RADU_C~1/AppData/Local/Temp/temp20230508192807272/flowers.ditamap
    [move-meta] Loading stylesheet C:\Users\radu_coravu\Downloads\dita-ot-feature-saxon-11\src\main\plugins\org.dita.base\xsl\preprocess\mappull.xsl
    [move-meta] Processing file:/C:/Users/RADU_C~1/AppData/Local/Temp/temp20230508192807272/flowers.ditamap

    maplink-check:

    maplink:
      [maplink] Processing file:/C:/Users/RADU_C~1/AppData/Local/Temp/temp20230508192807272/topics/care.dita
      [maplink] Failed to insert links: Failed to replace file:/C:/Users/RADU_C~1/AppData/Local/Temp/temp20230508192807272/topics/care.dita: Unable to delete file: C:\Users\RADU_C~1\AppData\Local\Temp\temp20230508192807272\topics\care.dita
      [maplink] Processing file:/C:/Users/RADU_C~1/AppData/Local/Temp/temp20230508192807272/tasks/pruning.dita
      [maplink] Failed to insert links: Failed to replace file:/C:/Users/RADU_C~1/AppData/Local/Temp/temp20230508192807272/tasks/pruning.dita: Unable to delete file: C:\Users\RADU_C~1\AppData\Local\Temp\temp20230508192807272\tasks\pruning.dita
      [maplink] Processing file:/C:/Users/RADU_C~1/AppData/Local/Temp/temp20230508192807272/tasks/gardenPreparation.dita
      [maplink] Failed to insert links: Failed to replace file:/C:/Users/RADU_C~1/AppData/Local/Temp/temp20230508192807272/tasks/gardenPreparation.dita: Unable to delete file: C:\Users\RADU_C~1\AppData\Local\Temp\temp20230508192807272\tasks\gardenPreparation.dita

If for example I comment out the "move-meta-entries" target, the processing no longer reports the error in the  "maplink" stage but instead reports it in the [topicpull] stage which comes after it.
It looks like some kind of cache Saxon (maybe that cache of document() functions) which somehow also keeps an input stream opened to each cached resource.

@raducoravu @chrispy-snps I made some additional changes to close resources. Could you pull the changes and test again?

With the latest changes (0beae8a501c76da9640e31c499e35acff412d615), I get the failure in mapref:
Error: Failed to run pipeline: Failed to replace temporary file C:\test_saxon\temp-SAXON\using_help\keys.ditamap.temp: Unable to delete file: C:\test_saxon\temp-SAXON\using_help\keys.ditamap

@chrispy-snps That seems to be a different test source than what you had earlier. I assume the same problem persists with map.ditamap and submap.ditamap example files?

@jelovirt - sorry for the confusion. Yes, it still happens in the tiny testcase too.
I see you force-pushed the branch. Let me know if you want me to rebuild and retest.

I can still reproduce the problem with the latest changes, this time during the topicpull stage:
flowers.zip
Sometimes if I remove for example two more topics from the DITA Map I can no longer reproduce the problem. Probably depends on how the garbage collector finalizes and closes dangling file input streams which are no longer referenced.

@raducoravu - on your side, does it occur with the two-file testcase from this post?

I overwrote the URL file url handler protocol in the JVM and found where file input streams are created which are not closed afterwards:
at org.xmlresolver.Resolver.openConnection(Resolver.java:327)

at org.xmlresolver.Resolver.resolve(Resolver.java:128)

at org.dita.dost.util.DelegatingURIResolver.resolve(DelegatingURIResolver.java:32)

at net.sf.saxon.lib.ResourceResolverWrappingURIResolver.resolve(ResourceResolverWrappingURIResolver.java:58)

	at net.sf.saxon.lib.ResourceRequest.resolve(ResourceRequest.java:131)

at net.sf.saxon.functions.DocumentFn.resolveURI(DocumentFn.java:414)

at net.sf.saxon.functions.DocumentFn.makeDoc(DocumentFn.java:249)

at net.sf.saxon.functions.DocumentFn$DocumentMappingFunction.mapItem(DocumentFn.java:159)

@jelovirt in org.dita.dost.util.DelegatingURIResolver.resolve(String, String) you need to break the for loop after the first resolution, otherwise you get a resolved stream source with an opened input stream and you ignore it, returning the second resolved stream source.

@jelovirt in org.dita.dost.util.DelegatingURIResolver.resolve(String, String) you need to break the for loop after the first resolution, otherwise you get a resolved stream source with an opened input stream and you ignore it, returning the second resolved stream source.

@jelovirt in org.dita.dost.util.DelegatingURIResolver.resolve(String, String) you need to break the for loop after the first resolution, otherwise you get a resolved stream source with an opened input stream and you ignore it, returning the second resolved stream source.

@raducoravu the for-loop in DelegatingURIResolver should explicitly not be broken out of, because it's not what it's doing. But, you're right, it needs to check that the resource is closed.
DelegatingURIResolver  is a chain of resolvers, like a reducer function. Maybe it should be renamed to ReducingURIResovelver. The problem is that the actual resolvers return streams, when this class would only like to get the system URIs of the resolved resources. Maybe it needs to be redesigned.

Maybe DelegatingURIResolver could be replaced by passing the catalog resolver to store, and if the catalog resolver needs to be overridden with a resolver from Ant, some sort of wrapper to Store could handle that 🤔

@jelovirt looking at what the DelegatingURIResolver does, maybe you just need to iterate the other way through the list of resolvers as you seem to prefer the last resolver which returns any significant value anyway.
Should I also try to add an issue on the Saxonica issues list about adding an extra resolver feature to disable the creation of input streams in the returned source?

@raducoravu That will not work. The idea is that I can first use catalog resolver to resolve magic URIs etc. that are mapped to real results, and then use the Store to get e.g. in-memory resources. The Store will then default to normal resolvers. I'm refactoring the whole code so that we no longer need the DelegatingURIResolver.

@raducoravu Looked at the code and it actually can be simplified to reversing the order and short circuiting the resolver result. Are you able to test now again? Ping @chrispy-snps

@jelovirt - this updated PR looks great. On multiple testcases (small and large), the log files and HTML5 output directories match identically between develop and this PR.

@jelovirt the changes make sense for me. They also work well for me.


Parent is not a consistent with other searches

Enzyme 3
The last test here throws an error
    describe.only('enzyme test', () => {
      const onClick = jest.fn();
      const wrapper = mount(

            click me

      );

      it('child should fire onClick', () => {
        wrapper.find('.child-elem').simulate('click');
        expect(onClick).toHaveBeenCalledTimes(1);
      });

      it('parents should fire onClick', () => {
        wrapper.find('.child-elem').parents('.parent-elem').simulate('click');
        expect(onClick).toHaveBeenCalledTimes(2);
      });

      it('closest should fire onClick', () => {
        wrapper.find('.child-elem').closest('.parent-elem').simulate('click');
        expect(onClick).toHaveBeenCalledTimes(3);
      });

      it('parent should fire onClick', () => {
        wrapper.find('.child-elem').parent().simulate('click');
        expect(onClick).toHaveBeenCalledTimes(4);
      });
    })

TypeError: Cannot read property 'tagName' of null

      at node_modules/react-dom/lib/ReactTestUtils.js:325:35
      at Object.simulateEvent (node_modules/enzyme-adapter-react-15/build/ReactFifteenAdapter.js:199:15)
      at ReactWrapper.<anonymous> (node_modules/enzyme/build/ReactWrapper.js:868:29)
      at ReactWrapper.single (node_modules/enzyme/build/ReactWrapper.js:1534:25)
      at ReactWrapper.simulate (node_modules/enzyme/build/ReactWrapper.js:867:14)

@eddiemonge does this also occur with shallow?

not sure. shouldnt be hard to figure out though. should also probably be a test for both for this case

@eddiemonge would you be willing to submit a PR that has failing test cases? (or even better, a fix?)

I've added your tests from the OP to master: https://github.com/airbnb/enzyme/commit/1b4a9e0da22941506ba0ae41e7d2ba34396641ba
Since they pass, I'm going to close this - happy to reopen it if there's further issues.


Visualize object names💡

We want to make it clear what object we are looking at at all times. Today, e.g. GeologyInterval is not mentioned anywhere in the UI, but available for listing in content window. For those cases, we would like to list the WITSML object as shown here:

In the example above, we would only like to list them where the object is not already listed, so e.g. the blue "MudLog", above "GeologyInterval" is not nessesary, as we already see that "Logging" is a MudLog object bases on the drilldown-function. However, the "2731" is not intuitively a "GeologyInterval" object, so there we would like to have it. Well/wellbore will not be nessesary either, as anyone working with WITSML data will (should) have that information already.
This means that this feature will only be in effect in instances where you need to drill down as deep as e.g. "GeologyInterval". Tubulars is another example of such an object, where "TubularComponent" would be the equivalent of "GeologyInterval". wbGeometries also has an underobject called "wbGeometrySection" which would need the same treatment.
We believe those 3 is a good start (if any other objects are obvious, feel free to add those).

We'd also need to add the support of "drilling down" into the mudlog object, tubular object & wbGeometries, so that they would be listed in the tree-structure, which are not the case today.

Let us know if there are any questions!

Unassigning you from this as it has been stale for a while. Feel free to re-assign if you are still up for it.

consult with Asbjørn and Elias


OR operator (|) treated like UNION (&) of two types

TypeScript error in /home/thakker/Documents/GitHub/crqcentral/src/Models/helpers.ts(34,64):
Property 'then' does not exist on type 'Promise<GraphQLResult> | Observable<object>'.
  Property 'then' does not exist on type 'Observable<object>'.  TS2339

I've started receiving errors like these too often starting around TypeScript 3.5. They make me feel like pulling my hair out even though I'm already going bald at a young age. Please think about other developers like me in your design decisions before bloating the language even further. I still have fond memories of Typescript 2. Even TypeScript 3.2 was pretty good and then it just kept going downhill from there. It feels like going from Windows XP to Windows Vista.
In the above error, a Promise is clearly listed as a potential return type. Why is TypeScript focusing on the other return type and not inferring that it is a Promise that is being returned based on the syntax of the calling function?

I'm not even sure of the root of the criticism is here - this behavior has been around since TypeScript 1.4 (almost 5 years ago)
The | operator does create a union type, and because the type-checker doesn't know whether you have a Promise or an Observable, it can't be sure whether it's safe to call `then.

Could you post an example of code that worked in earlier versions but not in the latest ? Accessing then on Promise<GraphQLResult> | Observable<object> would never have worked. A union type can be either of the constituents, so you can't access methods that are not common. Consider this simple example:
let o = Math.random() > 0.5 ? 0 : "" // number | string
o.toString() // ok is on both
o.toExponential() // not ok what if o is string this would be a runtime error
o.toUpperCase()// not ok what if o isnumber  this would be a runtime error

But then what's an appropriate or operator that actually allows you to compose types?

&, the intersection type operator.

FYI, I am not the only one in this camp because the above library that created declared the typings giving the error is by AWS. The naming conventions of mixed types and union types are just really confusing.

I first encountering intersection and union types it is easy to be confused about why they are named this way (I know I was). You have to think of types in terms of describing sets of instances.
A union type (|) is the set of instances that belong to either constituent in the union (so for string | number  an instances is in the set described by the union if it is either in the set described by number or the set described by string).
The question is having such a type what can we SAFELY do with it? The answer is we can safely access only common members (member which we know to be present regardless of the union constituent an instance actually belongs to). This is where the confusion usually comes in, since the safe members are the intersection of members from the constituent types. But the name union type, refers to the set described by the type not what members we can access.
Same reasoning applies to intersection types (&). The set described by an intersection type is the set of instances that belong simultaneously to both constituents of an intersection (So { a: number } & { b: string } represents a type where an instance is at the same type an instance of { a: number } and an instance of { b: string }). SInce the instance is an instance of both of the constituents types at the same type, we can safely access members of either constituents resulting in a union of members, but again the name is not related to members we can access but to the set operation described by the type.

https://stackoverflow.com/questions/38855908/naming-of-typescripts-union-and-intersection-types

Didn't mean to reopen. Anyway here's a picture

The picture looks confusing because it's not clear what exactly are being operated on and how the operations are defined.
If Pic 2 is true, then it seems like doing set operations, and object properties are being operated on.
If we define four sets in pic 1 in the following way:
Blue_Things = {Things | color = 'blue'}
Red_Things = {Things | color = 'red'}
Big_Things = {Things | size = 'big'}
Small_Things = {Things | size = 'small'}

Then pic 2 is reasonable if we do set intersection:
intersect(Blue_Things, Small_Things)
= intersect({Things | color = 'blue'}, {Things | size = 'small'})
= {Things | color = 'blue' and size = 'small'}
= Small_Blue_Things

But the result of pic 3 is not empty if we do set union:
union(Blue_Things, Red_Things)
= union({Things | color = 'blue'}, {Things | color = 'red'})
= {Things | color = 'blue' or color = 'red'}
!= empty

Or maybe the question just cannot be easily explained to people who don't know type theory?

After a while of struggling I think finally understand it.
The confusion was because Naming in TypeScript conflicts with in Set Theory (most people who know math know set theory, that's why the naming in TS confusing to many people)

Union Operator | in TS is actually doing XOR / Either Or, and the result properties are equivalent to Set Intersection on type properties
Intersection Operator & in TS just equivalent to doing Set Union on type properties.

An even longer example:
Definitions
Let item a value of arbitrary type.
Let Type_A = {foo: number, bar: int}, Type_B = {bar: int, baz: string}

the Intersection Type Type_A & Type_B:
Defining item of Type_A & Type_B means item is the combination of Type_A and Type_B, which is actually {foo: number, bar: int, baz: string}. Then it is safe to allow item.foo, item.bar, and item.baz.
Hence, we have
Type_A & Type_B = {foo: number, bar: int, baz: string}

the Union Type Type_A | Type_B:
Defining item of Type_A | Type_B means item is either Type_A or Type_B. Then it is unsafe to allow item.foo, because that's an error if the actual item is of Type_B. Similarly, accessing item.baz is also unsafe.
Hence, we have
Type_A | Type_B = {bar: int}

The names are not backwards. Read the StackOverflow link, or a book on type theory.


Provide valuegardener.seed.name for controller registration helm charts.

How to categorize this PR?

/area control-plane
/kind enhancement
What this PR does / why we need it:
The value gardener.seed.identity is deprecated, as "identity" implies global uniqueness. Instead it is recommended to use the value gardener.seed.clusterIdentity. For the dns-shoot-service we would prefer to continue with using the seed name as part of the the DNSOwner id, as it has contains the gardener.garden.clusterIdentity to make it unique.
With introducing gardener.seed.name, we can still use the seed name for better readability.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Related to #2851
Release note:

provide value `gardener.seed.name` for controller registration helm charts.

/invite @rfranzke

/test pull-gardener-integration

/test pull-gardener-e2e-kind-upgrade

/test pull-gardener-integration


Greenkeeper/husky 1.0.1

closes #28

Pull Request Test Coverage Report for Build 516

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 486:
0.0%

Covered Lines:
273

Relevant Lines:
273

💛  - Coveralls

:tada: This PR is included in version 3.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


/user/{id} shouldn't be sequential

Describe the bug
Whenever a user is created they are assigned a UID of last UID +1. I.e, Admin user is user 1, the next user created is 2, the next 3 and so on and so forth.
This means that you can query the database and build an entire replica of every user (including profile pictures) by simply visiting url.com/bookstack/user/1, url.com/bookstack/user/2 and so forth. There isn't any email addresses or login details exposed, but I would suggest this isn't particularly good practice exposing so much data in this way.
Expected behavior
Each user should be provided a non-sequential UID, a random generated number of reasonable length.

Thanks for raising @maggie0002,
I agree, I can see that potentially being a probably in non-private instances. Will mark for next feature release.

Extra thought: This would also apply to search filters.

Now added into master to be part of the next feature release.
I've used a unique slug version of the user's name, since that keeps it non-sequential, contextual and uses information that will be known when clicking through on that link (Does not expose anything new).
It does mean that link could possibly break old references on user name change but I imagine it's relatively uncommon that a BookStack profile will be linked to in an important manner.
Thanks again for raising @maggie0002

The same with pages nums!
It would be greate each page has a long random number.
Then, it would be possible share page by it's link without permission issues


Do not save YAML default configuration files if the parent directory already exists

Fixes https://github.com/EnvyWare/BetterDexRewards/issues/47

This does not fix anything, or do anything


updated - now home page is not broken

Closes
Closes #1026

Description

Screenshots

Note to reviewers

Checklist:

[X ] I have linked the PR to the correct issue.
[ X] I have read the Contribution Guidelines
[X ] I have built and tested the changes, and they do not break or show any errors.

@vaibhavi-d18 HAVE A LOOK !!!!!!!!!!!
and a level label too.


Add oEmbed plugin

add plugin for http://noembed.com or compatible oembed API.
Should also work with http://iframely.com or any similar api which accepts url as a param and returns a response with an html property

In practice, I'm actually less than happy with this. The amount of markup it inserts int he editor is cumbersome. I think im finding that its easier to simply insert a link with some attribute, and deal with the actual embed on display: eg. http://sprunge.us/dgBh?javascript and https://github.com/nfl/jquery-oembed-all

Your code is it stable? Can I test it? Or do you want modify it before merge? I don't understand :/

The code is stable. Feel free to test it and tell me what you think.


Ignoring backend-only options - add a force_exclude_options plugin option

Right now (v2.0.0-alpha.27) service and message options from .proto files are always generated for ServiceType.
It would be nice to have the ability to ignore all (or blacklist some) options for browser clients if they are used only on the backend.
These options just increase the final bundle size without ever being used or in the worst case can leak some backend implementation details, that shouldn't be visible on the frontend to everyone.
The official protoc plugin for JS is not including options in the generated files, and I think that this is a reasonable default behaviour.

The official JS plugin still doesn't support the JSON representation either, as far as I know. Not sure if we should focus on that for a reference.
It is already possible to exclude options from the generated code with a blacklist using a file option:
option (ts.exclude_options) = "*.private.*";

Is this an option (hah) for you?
There is no plugin option for the blacklist because I don't want to add value options, only flags. A force_exclude_options flag would fit well within the existing plugin options...

force_exclude_options plugin flag sounds good.
Blacklist suggestion was just a compromise in case it was to difficult to implement exclusion of all options.

Added in https://github.com/timostamm/protobuf-ts/commit/ab9d65e0f66f6957efb9d8c96f71c526b5c698b8

"force_exclude_all_options"
By default, custom options are included in the metadata and can be blacklisted
with our option (ts.exclude_options). Set this option if you are certain you do not want
to include any options at all.

Released in v2.0.4-alpha.0 in the next channel.

Released in v2.0.4.


Scrolling to the center onInit

Hi,
first off all I want to say thank you for sharing this great piece of software.
It was exactly what I was looking for to replace the old non responsive thumbnail scroller I am actually using in my JoomGallery gallery (you can see a demo of the old thumbnail scroller here on the demo page of JoomGallery).
One thing I couldn't do like it is done in the old software, is the following:
By using
      <script>
        (function($){
          $(window).load(function(){
            $("#motioncontainer").mThumbnailScroller({
              axis:"x",
              type:"hover-precise",
              callbacks:{
                onInit:function(){
                  $("#motioncontainer").mThumbnailScroller("scrollTo", "#jg_mini_akt");
                }
              },
            });
          });
        })(jQuery);
      </script>

I scroll to a certain thumbnail onInit and I would like to have it positioned centered in the container (as far as it is possible). At the moment it is positioned as far as possible to the left.

Sorry, I missed to look at your demo at http://manos.malihu.gr/repository/jquery-thumbnail-scroller/demo/examples/scrollTo_demo.html, so I could help myself.


goto_location() unsupported error

Hello everyone!
I developed a script that was tested in a SITL environment. Everything was working as expected but when I tried to test it in a real drone I receive the UNSUPPORTED error on the goto_location.
I'am using it just to change the drone altitude. So firstly I get the current drone position and use it on the first two parameters. For the altitude make some simple math, and for the yaw I use 'float(nan)':
await drone.action.goto_location(current_pos['latitude'], current_pos['longitude'], (current_pos['abs_altitude'] - (current_pos['altitude'] - altitude)), float('nan'))
This instruction returns the error before mentioned. So I tried to pass direct values casted to the especified type, and still the same error... No errors are shown on QGC console. And again, in a simulation environment it works as excpected.
What can cause his behaviour? Thanks in advance! 🙂

Ok, is this PX4 or ArduPilot?

PX4, using the latest stable firmware version

When you try SITL, I assume that's not latest stable/v1.14?
My guess is you land right here:
https://github.com/PX4/PX4-Autopilot/blob/release/1.14/src/modules/commander/Commander.cpp#L703-L704
It wants two things:

mode switch set, which we have, see https://github.com/mavlink/MAVSDK/blob/main/src/mavsdk/plugins/action/action_impl.cpp#L459.
no unsupported bits set, which we don't do.

That leaves me confused.


Cannot instantiate the Lut3DParams.Cube

When I tried to use the method Lut3D.apply3dLut , I found I cannot instantiate a Lut3DParams.Cube
Anyway, I admit this is a very good tool.
But, please make improvement.

Good catch, thanks for your contribution!

Similar thing for LutParams.RGBALut(rLut, gLut, bLut, aLut) too. Cannot instantiate it.

@rishabhMaltare also true. I will setup my Android environment to fix and release a new version with the fixes soon after I come back from holidays. Feel free to open a PR about it if you feel like it :)


Transformer extensions

Minor features and cleanups needed to properly run transformer models:

Support quantization in ONNX graph
Support tensors with >2 dimensions in ONNX graph
Clean up the bar plot function
Fix CACTI bugs

I have manually resolved the conflicts and merged this into master.

After this PR, the ZigZag version should be upgraded such that Stream can use this update


[PDI-18498] Transformation executor error passing transformation name…

… with path in parameter
Linux compatibility for #7360

:white_check_mark: Build finished in 45m 57s
Build command:
mvn clean verify -B -e -Daudit -amd -pl engine,ui

:ok_hand: All tests passed!
Tests run: 3657, Failures: 0, Skipped: 7    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 44m 21s
Build command:
mvn clean verify -B -e -Daudit -amd -pl engine,ui

:ok_hand: All tests passed!
Tests run: 3657, Failures: 0, Skipped: 7    Test Results

:information_source:  This is an automatic message


Update library name to "CSV Data Source for Spark"

Calling the library "Spark CSV" might confuse users about the source of the library, while doesn't conform to ASF trademark policy. This PR renames it to "CSV Data Source for Spark".

Current coverage is 85.88%

Merging #263 into master will decrease coverage by -0.19% as of d538009

@@            master    #263   diff @@
======================================
  Files           12      12
  Stmts          517     517
  Branches       149     149
  Methods          0       0
======================================
- Hit            445     444     -1
  Partial          0       0
- Missed          72      73     +1

Review entire Coverage Diff as of d538009

Powered by Codecov. Updated on successful CI builds.

Thanks.


snap "juju-helpers" is not available on stable

Following the readme:
sudo snap install juju-helpers --classic
results in:
error: snap "juju-helpers" is not available on stable but is available to install on the following
       channels:

       edge       snap install --edge juju-helpers

       Please be mindful pre-release channels may include features not completely tested or
       implemented. Get more information with 'snap info juju-helpers'.

I've updated the snap and pushed to the stable branch, so that command should now work


build_args: support numeric and boolean values

Currently, build_args requires values to be set as characters. Using numeric/boolean values results in empty values in the final build call.

A bit confused about this one. Plugins get all settings via env var from the server. As env vars are untyped/strings I don't see how this could be a plugin issue :thinking:

Correct. Only "OTHER: "199" works.

Ok will give it a test but I have the feeling this is a server issue.


trigger no triggers

First off, thanks for writing this wrapper class. I love it.
Secondly, super small problem.
If you look at your: AutopilotManager->addContactToJourney($name, $contactId) method, you'll see your apiPost call uses: triggers.
According to the API docs, it's trigger.
https://autopilot.docs.apiary.io/#reference/api-methods/trigger-journey/add-a-contact-to-a-journey?console=1
Needless to say it fails on triggers.
Cheers!

Looks like this was fixed in 0.1.2, but Packagist only has versions up to 0.1.1. Maybe @antoinedekalee can trigger a Packagist update?

Hi,
Sorry for the inconvinience !
We have taken over the repository from the previous owner and since then we have issue to update the version available on packagist.
I will contact the packagist support to see what  is going on.
For the moment, I would suggest either solutions :

Install the dev-master version of the library (we do not make a lot of modifications)
Add the repository explicitely in your repositories section in your composer.json file.

        {
            "type": "vcs",
            "url": "https://github.com/dekalee/php-autopilothq"
        }

Hope those workarounds will work for the moment.
I will tell you when the update is working again.
Cheers!

Thanks -- I did temporarily switch to using dev-master. I just try to avoid it where possible, so your following up with Packagist is greatly appreciated. I believe there is some way to manually trigger an update within Packagist. It's also possible that Packagist integration broke when you took over the repository.

I received an answer from packagist : I have to remove the version tag from the composer.json file.
The version tag will skip the build in packagist if it is different from the git tag.
I have created a new tag (0.1.5) with the modification. You can start using it now !

Thanks Nicolas!
On Thu, May 31, 2018 at 9:22 AM, Nicolas Thal<EMAIL_ADDRESS>wrote:

I received an answer from packagist : I have to remove the version tag
from the composer.json file.
The version tag will skip the build in packagist if it is different from
the git tag.
I have created a new tag (0.1.5) with the modification. You can start
using it now !
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dekalee/php-autopilothq/issues/15#issuecomment-393528008,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZK34ouIRBW3e2k0-wHiGO7UftIMaKgXks5t3-6MgaJpZM4UGP_C
.

--
Alen Bubich
Co-Founder & Software Guy, CityBlast Inc.
Direct:<PHONE_NUMBER> <1.888.712.7888>
Site: cityblast.com http://www.cityblast.com/
Email:
<EMAIL_ADDRESS><EMAIL_ADDRESS>*Important Message *This message, including any attachments,
is intended only for the use of the individual(s) to which it is addressed
and may contain information that is privileged/confidential.  Any other
distribution, copying or disclosure is strictly prohibited. If you are not
the intended recipient or have received this message in error, please
notify us immediately by reply e-mail and permanently delete this message
including any attachments, without reading it or making a copy. Thank you.


[mypy] missing library stubs or py.typed marker

plz support py.typed
Thanks

@thaiducdung255 I just released version 0.3.3 containing this file.
Thanks for the hint!


Bump to 1.0

Why is this not marked stable yet?
Anything I can do to help? ^^
Now you get scary labels like seen here.

I will bump tonight (Swedish time, in about 8 hours), feel free to remind me if I miss it :)

I'm fairly positive you missed it 😉

Sorry about that, fixed it now 👌
Thanks for the reminder 🎉


Fixed issue in HLS plugin (live stream)

Fixed issue when shows only a playlist with 3 video fragments

Please make pull from origin master and resolve conflicts.


Buggy range

0.0 to 2*Math.PI by 0.2

Gives error
Uncaught java.lang.IllegalArgumentException: More than Int.MaxValue
No such problem with native Scala 2.11.7
(0.0 to 2 by 0.1).map(_*Math.PI)

works fine
Looks like the non integer end value is making it unhappy
0.0 to Math.PI

gives same error

0.0 to 2*3.1415 by 1.0

in scala 2.11
NumericRange(0.0, 1.0, 2.0, 3.0, 4.0, 5.0, 6.0)
in scala.js
NumericRange(0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13,...)

See: https://issues.scala-lang.org/browse/SI-8620, in short, floating point ranges are strongly discouraged in Scala since they tend to blow up numerically.

Works fine for me in Scala 2.11. Its in scala-js that it goes super mental.

Hmm, yes, I'm fairly sure it should definitely terminate!

@nicolasstucki Could you investigate this?

The problem is in the length of the range. I will investigate why this is returning a wrong result.

In every case tested so far, the source of this bug is #1979.


publicKeyMultibase doesn't appear to be showing in the did document resolver

Hmm did:web:aviary.pub seems to be down right now, so I can't try it myself. Could you share the full DID document?
Normally, "publicKeyMultibase" should be supported by the UI, see here: https://github.com/decentralized-identity/universal-resolver-frontend/blob/main/src/components/result/VerificationMethod.jsx#L15

Yes, apologies that domain is my ngrok tunnel domain so I need my local setup booted. Here is the full document
{
  "@context": [
    "https://www.w3.org/ns/did/v1",
    "https://w3id.org/security/suites/jws-2020/v1"
  ],
  "controller": "did:web:aviary.pub",
  "id": "did:web:aviary.pub",
  "keyAgreement": [
    "did:web:aviary.pub#1"
  ],
  "service": [
    {
      "accept": [
        "didcomm/v2"
      ],
      "id": "#didcomm",
      "serviceEndpoint": "https://aviary.pub/didcomm",
      "type": "DIDCommMessaging"
    }
  ],
  "verificationMethod": [
    {
      "controller": "did:web:aviary.pub",
      "id": "did:web:aviary.pub#0",
      "publicKeyMultibase": "z8FRmkyRH9xAsLCk51yXN2Qy6uq4eN4iAesa3v3Hv889v",
      "type": "Ed25519VerificationKey2020"
    },
    {
      "controller": "did:web:aviary.pub",
      "id": "did:web:aviary.pub#1",
      "publicKeyMultibase": "z7bNjXnt3EXhpy7UdzZUANa2CsBFpzKGFXsgvkBd9iHGo",
      "type": "X25519KeyAgreementKey2020"
    }
  ]
}

Ok, I think I've determined this is a json-ld problem after looking at it on the playground. I guess I need a context for those suite types. Searching for them now..

hmm added "https://www.w3id.org/security/suites/x25519-2020/v1" as a context but that doesn't seem to resolve the issue

@brianorwhatever I think this has been fixed now in https://github.com/decentralized-identity/universal-resolver-frontend/commit/1a17332f532949db32b69da44eaff9854266bb09.
The latest version is already deployed at https://dev.uniresolver.io/. Could you check, and if you agree, close the issue?

Looks great, thanks for the fix @peacekeeper !


Version 1 release TODOs

This is what I have left to do before this is ready for general use:

[ ] Font Locking

[X] Implement rules
[ ] Fix performance lock-up

[ ] Indentation
[ ] Prompt for user to auto install unison grammar if not found

[ ] Download and compile for user
[ ] OR Download precompiled binaries

[ ] List on melpa

Open PR, e.g. https://github.com/melpa/melpa/pull/8545

[ ] imenu support
[ ] Add unison-ts-mode to eglot, lsp-mode
eglot e.g. https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62449
lsp-mode e.g. https://github.com/emacs-lsp/lsp-mode/pull/4002

This issue is for me to keep track of what needs to be done, not for gathering feedback. Anyone should feel free to open a separate issue if they have a question, bug, request, etc.

Just one thing I think broke most of the useful highlighting is that unique and structural now is optional. So types are now not all highlighted

Just one thing I think broke most of the useful highlighting is that unique and structural now is optional. So types are now not all highlighted

Thanks for the report! This would be an issue with the treesitter grammar we depend on. If structural or unique are missing, then the related type_signature token we look for will not be issued in the first place. But I see this has been fixed fairly recently: https://github.com/kylegoetz/tree-sitter-unison/commit/fb9585d775a0f415b874328037a7b0710493bbaf, so I'll update the install instructions with the newer version

Thank you for looking at this! I believe I was mistaken when mentioning things broke. It seems on Emacs 30 that most of my highlighting is borked anyway, I'll have to do some digging to see what went wrong.

so I'll update the grammar branch with the newer version and that'll fix it

I believe having a seperate repo now is not necessary, as the parser.c and scanner.c are now included in the main branch of kylegoetz/tree-sitter-unison.
Thank you for your time! :D


Configuring a GitHub Action workflow for publishing to pub.dev

cc @paulkastel
Now each time a new tag is pushed, the CD will automatically release new version to pub