Jest tests exist, but suite not set up properly

I see that Jest dependencies are included, and that there are several jest unit tests included for app, core, and cli, but for the love of me I can't seem to configure them to work properly in the monorepo. After some research I tried setting up a babel.config file like this but to no avail. Any pointers on how this could be fixed?
Expected Behavior

Jest test suites should run to completion.
Current Behavior

Jests suites fail at the first "import" statement, or at html tags.

 FAIL  packages/core/src/layout/InfoCard/InfoCard.test.js
  ● Test suite failed to run

    Jest encountered an unexpected token

    This usually means that you are trying to import a file which Jest cannot parse, e.g. it's not plain JavaScript.

    By default, if Jest sees a Babel config, it will use that to transform your files, ignoring "node_modules".

    Here's what you can do:
     • To have some of your "node_modules" files transformed, you can specify a custom "transformIgnorePatterns" in your conf$
g.
     • If you need a custom transformation specify a "transform" option in your config.
     • If you simply want to mock your non-JS modules (e.g. binary assets) you can stub them out with the "moduleNameMapper" $
onfig option.

    You'll find more details and examples of these config options in the docs:
    https://jestjs.io/docs/en/configuration.html

Details:

    SyntaxError: /home/balanza/Documents/Projects/backstage/packages/core/src/layout/InfoCard/InfoCard.test.js: Unexpected to$
en (32:42)

      30 | describe('<InfoCard />', () => {
      31 |   it('renders without exploding', () => {
    > 32 |     const rendered = render(wrapInTestApp(<InfoCard {...minProps} />));
         |                                           ^
      33 |     expect(rendered.getByText('Some title')).toBeInTheDocument();
      34 |   });
      35 |

      at Parser.raise (node_modules/@babel/parser/src/parser/location.js:44:63)
      at Parser.unexpected (node_modules/@babel/parser/src/parser/util.js:150:16)
      at Parser.parseExprAtom (node_modules/@babel/parser/src/parser/expression.js:1130:20)
      at Parser.parseExprSubscripts (node_modules/@babel/parser/src/parser/expression.js:540:23)
      at Parser.parseMaybeUnary (node_modules/@babel/parser/src/parser/expression.js:520:21)
      at Parser.parseExprOps (node_modules/@babel/parser/src/parser/expression.js:309:23)
      at Parser.parseMaybeConditional (node_modules/@babel/parser/src/parser/expression.js:261:23)
      at Parser.parseMaybeAssign (node_modules/@babel/parser/src/parser/expression.js:209:21)
      at Parser.parseExprListItem (node_modules/@babel/parser/src/parser/expression.js:2085:18)
      at Parser.parseCallExpressionArguments (node_modules/@babel/parser/src/parser/expression.js:824:14)

FAIL  plugins/home-page/src/plugin.test.ts
  ● Test suite failed to run

    Jest encountered an unexpected token

    This usually means that you are trying to import a file which Jest cannot parse, e.g. it's not plain JavaScript.

    By default, if Jest sees a Babel config, it will use that to transform your files, ignoring "node_modules".

    Here's what you can do:
     • To have some of your "node_modules" files transformed, you can specify a custom "transformIgnorePatterns" in your conf$
g.
     • If you need a custom transformation specify a "transform" option in your config.
     • If you simply want to mock your non-JS modules (e.g. binary assets) you can stub them out with the "moduleNameMapper" $
onfig option.

    You'll find more details and examples of these config options in the docs:
    https://jestjs.io/docs/en/configuration.html

Details:

    /home/balanza/Documents/Projects/backstage/plugins/home-page/src/plugin.test.ts:16
    import plugin from './plugin';
    ^^^^^^

    SyntaxError: Cannot use import statement outside a module

      at Runtime.createScriptFromCode (node_modules/@jest/core/node_modules/jest-runtime/build/index.js:1059:14)

Possible Solution

Add proper jest and babel configuration.
Steps to Reproduce (for bugs)

1.yarn jest
Your Environment

NodeJS Version: v12.16.1
Operating System and Version: Linux Mint 19.3 Cinnamon
Yarn Version: 1.21.1
Jest Version: 25.1.0

Assuming yarn jest is a typo? Actual command is yarn test.
I can't reproduce this though, and the tests are run just fine in CI, which should be similar to your environment.
Are the error messages you posted the ones you're getting on a clean checkout of master, or after adding a babel config?

Nevermind :grin:, just realized that web-scripts test takes care of the Jest tests as well. Silly me :grimacing:


usm: kafka: Reduce event count in error code handling

What does this PR do?
Only queue events when we actually needed to, i.e. when the error code
for the next batch of records differs from the ones we've seen thus far.
Otherwise there is a large increase in the number of events for the
normal use case of no errors.
Motivation
https://datadoghq.atlassian.net/browse/USMON-1093

Additional Notes
See ticket for links to load test results.

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Show tooltip for every data point, but skip xAxis labels?

Is it possible to show tooltips for every data point, but be able to skip the xAxis labels?
I do the following
  xAxis : [{
    type : "category",
    axisLabel:{
      interval:0
   }
 }]

But my xAxis labels overlap each other. But if I set the interval to "5", then I lose my tooltips for some data points.

What is your chart’s type? line? bar?
You can try to let the tooltip’s trigger to be ‘axis’ like this
tooltip: {
  trigger: ‘axis
}

hi @kener
My tooltip trigger setting is already set to "axis".
My chart type is "line".
The issue is that
axisLabel: {
  interval:0
}

makes my chart looks like below image

But if I set the the interval to a higher number, tooltip doesn't work for every point.

check this http://echarts.baidu.com/doc/example/line6.html
and maybe you can give me your options

Awesome. Thank you very much.
I realised it was my mistake. I had a duplicate "tooltip" settings.
So I had
tooltip: {
  trigger:"axis"
}

and then down the further line, I had
tooltip: {
  show:true
  axisPointer:
    type:"none"
}

Thank you for all your help.


Support masks in audio metrics

🚀 Feature
It would be great if ScaleInvariantSignalDistortionRatio and  ScaleInvariantSignalNoiseRatio allowed an extra argument mask when computing a metric on a batch of audio frames which have been zero-padded to fit the batch. Allowing to pass a mask would only compute the metric on valid audio frames across the batch.
Alternatives
In the TorchAudio tutorial they have manually computed the metrics to account for this.
Would be call if torchmetrics did this.

Thank you for your suggestion.
You can manually mask the predictions before giving them to the metric functions. Putting this need to the metric function would introduce some unnecessary complexity. ^_^


Remove useless constants in commands

After https://github.com/symfony/symfony-demo/commit/5180bdcce3bac08e59ba9b5d34fbd7c2b007f7e3

Good catch, thanks @yceruto.


Introduce root model object into model viewer trees

When viewing the source and target models in the bottom panes, the root node is not displayed. Though it is described textually in the tab name, it would be good to show this node explicitly to the user so they have a better handle on where the listed model objects in the tree are coming from.

Here's the PR for this work - https://github.com/fabric8io/data-mapper/pull/121

pushed


Shorthand async function interpreted as beginning of function paren.

Hi!
Not quite sure if the issue I've described below is a 'bug' in the standard parser, or if shorthand functions are not supported at all.
Let's have a look at the following code snippet.
const bar = async () => { return true }
const foo = bar

(async () => {
  // do something async directly without creating a named function.
  await foo
})()

As you can see, foo is set to bar and after that, we invoke a directly executed async function. Now let's run standard on the snippet.
$ standard test.js
test.js:2:13: Unexpected space between function name and paren.
test.js:4:1: Unexpected newline between function and ( of function call.

We see that standard interprets the shorthand function and assignment of foo = bar as an invalid formatted function.
After running standard --fix, the shorthand function is pasted directly after the assignment of foo.
const bar = async () => { return true }
const foo = bar(async () => {
  // do something async directly without creating a named function.
  await foo
})()

My question is; is this wanted behaviour?

The code that you get after running standard --fix is the same as will be run before. I think that you want to write:
const bar = async () => { return true }
const foo = bar

;(async () => {
  // do something async directly without creating a named function.
  await foo
})()

Thanks @LinusU, I noticed that I was missing a semicolon in my shorthand function.
Is it possible for StandardJS to recognise and correctly fix this mistake?

I think it's quite hard since the code you originally wrote still is valid javascript, and it would be weird if standard --fix impacted the output of the script...

Yea, it's sounds almost impossible.
But still
test.js:2:13: Unexpected space between function name and paren.

sounds strange for me and like a bug in ESLint parser. @lesander is it fixed when use semicolon?
But yea as @LinusU said, the --fix is totally correct, that's one of the "special" cases where you must add semi-colon.

I think that "Unexpected space between function name and paren." is correct, since there are whitespace between bar and (. To be precise, there are two newlines between them...

I believe this is working as intended.


Enable event types by sending message templates to Seq

Hi!
I just checked out the Seq sink and found it's sending the formatted message rather than the original template to Seq, which means it misses out on event type support.
It doesn't look like it would be too hard to modify - should I have a shot at getting a PR together?

@nblumhardt you are most welcome )


[chore] Update typedoc theme

What needs to be done
Currently the theme is the default theme. It might be cool to use a new theme.
Additional context
Checkout:
https://www.npmjs.com/package/typedoc-github-wiki-theme

Crap, the github-wiki theme spits out markdown files to be compatible with github's wiki feature. Which I don't want to use. Going to look for an alternative.

Closing, as I couldn't find any theme worth using. The github theme would of matched with the concept the project is just in github, but since it only integrates with the wiki feature this won't be used.


[BUG] Weird coloring middle of words [rich 10.16.1]

Describe the bug
Weird coloring:
➔ python -c 'from rich.console import Console; Console().print("<local:14863:<Movie:14863:Das-Experiment>>")'
<local:14863:<Movie:14863:Das-Experiment>>

why does it start-stop middle of the word?
how to disable that?

$ python -c 'from rich.console import Console; Console().print("[magenta]<local:14863:<Movie:14863:Das-Experiment>>")'

Seems it's ipv6 pattern:

https://github.com/willmcgugan/rich/blob/b72e002a000ba5d9a58f61b9a8fcb7fec38b7ebe/rich/highlighter.py#L89

commenting out that line makes text appear normalish:

To disable completely can use highlight=False:

https://rich.readthedocs.io/en/latest/highlighting.html

Can remove the specific one by implementing own highlighter class:

https://rich.readthedocs.io/en/latest/highlighting.html#custom-highlighters

Sounds like you figured it out! Ok to close?

@willmcgugan I figured out the cause, there's no fix.

the ipv6 pattern is too greedy, should be removed or improved

how was the problem solved? i don't see any related commits or merge requests

how was the problem solved? i don't see any related commits or merge requests

You solved your own problem and said there was no fix. If you want to improve the ipv6 regex, a PR would be welcome.

You solved your own problem and said there was no fix. If you want to improve the ipv6 regex, a PR would be welcome.


Road to global functions

Hullo. This is the start of what should hopefully be a way to use a global function library in all extension modules. This is still a work in progress.

Closing in favor of #33


Could you share the way of convert MobileNet-ssd to IR?

Could you share the way of convert MobileNet-ssd to IR?
I convert Mobilenet-ssd v2 to IR, but got lots of error. Here is my approach:
python3 .\mo_tf.py `
--input_model E:\ssdlite_mobilenet_v2\frozen_inference_graph.pb `
--model_name ssd_mobilenet_v2 `
--output_dir E:\ssdlite_mobilenet_v2\ `
--data_type FP16 `
--batch 1 `
--tensorflow_object_detection_api_pipeline_config E:\ssdlite_mobilenet_v2\pipeline.config `
--tensorflow_use_custom_operations_config .\extensions\front\tf\ssd_v2_support.json

There are many errors when I use this converted IR model.

If you are genuinely asking for support, you should write down error messages and environmental information in detail.
Follow the issue template.

Sorry about that. Thanks for your time and patience.
my system:

device: Raspberry Pi3B+
CPU architecture: armv7l
NCS stick: NCS v1
OS: Raspbian 9.8
python_ver: 3.5.3
tensorflow_ver: 1.12.0

I using Tensorflow detection model zoo's ssdlite_mobilenet_v2_coco provided by Tensorflow official. Then convert it to IR model.
python ./mo_tf.py \
--input_model ~/ssdlite_mobilenet_v2/frozen_inference_graph.pb \
--model_name ssd_mobilenet_v2 \
--output_dir ~/ssdlite_mobilenet_v2 \
--batch 1 \
--reverse_input_channels \
--tensorflow_object_detection_api_pipeline_config ~/ssdlite_mobilenet_v2/pipeline.config \
--tensorflow_use_custom_operations_config ~/extensions/front/tf/ssd_v2_support.json

But when I using your code SingleStickSSDwithUSBCamera_OpenVINO_NCS2.py to test model if it works,
, I never got any detections. I found the out of cv2.dnn is always zero except first element is -1.
I follow this issue MobileNet-SSD + RPi + NCS2, but I have no idea about original model's info, so tried different data_type, none of them work. I don't know where to find the normalization's param of COCO training set, but I'm working on it.
Could you help me figure it out? Is the way to convert the model incorrect?

I use this param of normalization, it works fine: mean=128, std=1.0.

Here is my summary:

pre-trained model provide by tensorflow: Object Detection Models Zoo
If the model above doesn't specify the normalization's param, then cv2.dnn.blobFromImage shouldn't pass in scalefactor and mean.
I test ssdlite_mobilenet_v2_coco, there is no need to reverse_input_channels when convert model to IR. And cv2.dnn.blobFromImage shouldn't set swapRB=False.

Thank you for providing very useful information.
It will be a very good help for other engineers.

My pleasure.


Exceptions not captured in Google Cloud Function

Hello,
I am trying to capture erros happening in GCPs Google Cloud Functions with Sentry. I initialize sentry as shown in the documentation for cloud function, but exceptions never appear in the dashboard. Running the below function locally successfully sents the logs to Sentry. Also when I explicitly capture the error and use capture_exception the exception is sent to Sentry successfully from GCPs cloud function.
I also tried moving the sentry_sdk.init inside the function, but that also didnt help. Im using version 1.0.0, but also tried with earlier versions. The cloud function is triggered with GCPs pub/sub.
Thanks!
from google.cloud import bigquery
import redis
import numpy as np
import json
import os
import sentry_sdk
from sentry_sdk.integrations.gcp import GcpIntegration
from sentry_sdk import capture_exception

sentry_sdk.init(
    dsn="working-dsn-key",
    integrations=[GcpIntegration(timeout_warning=True)],
    traces_sample_rate=1.0,  # adjust the sample rate in production as needed
)

def update_table(response, metadata):
    # This will give an error, but it wont be logged, only running locally.
    response['blabla']

    # This will give an error and successfully sent to sentry from cloud function
    # try:
    #     response['blabla']
    # except Exception as e:
    #     # Alternatively the argument can be omitted
    #     capture_exception(e)

    return {'finished': 200}

Same here, no exception captured on Pub/Sub triggered Cloud Functions.

Cloud Functions Runtime: Python 3.8
sentry_sdk: 1.1.0

I've looked a bit deeper this problem, and I found two things:

The integration is only compatible with Python 3.7 runtime. There is a subtle warning, but I think this should be mentioned more clearly in the documentation. If you use another runtime (like Python 3.8 or 3.9), it does nothing more than standard Sentry configuration.
When enabling Sentry debug mode, I clearly see errors being catched and added to the worker queue. However, my guess is that when an error is thrown, Google abruptly kills the function ; not giving chance for the queue to be processed before exit. Therefore, errors are not reported to Sentry.

I ended up writing a decorator that manually catches exceptions, reports them to Sentry and forces the queue to flush. This way, the errors are reported:
def sentry(func):
    @functools.wraps(func)
    def wrapper(*args, **kwargs):
        try:
            func(*args, **kwargs)
        except Exception as e:
            sentry_sdk.capture_exception(e)
            sentry_sdk.flush()
            raise e

    return wrapper

@sentry
def pubsub_cloud_function(event, context):
    raise Exception("Error!")


Add option to disable colour logging

Done in https://github.com/Bubba/haskell-lsp-test/commit/f0d93bbe47d55ab650909e0487c65c1048f1bb9a


Rename Diana - navarro - el perdon. to Diana -navarro - el perdon.

Diana navarro el perdon  Where you can find amazing great content that will make you happy always

Why:
Closes [issue link]

What's being changed:

Check off the following:

[x] I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
[x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[x] This pull request impacts the contribution experience

[x] I have added the 'writer impact' label
[x] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")https://youtu.be/a3t__jwfEUI

Where you can find amazing great content that will make you happy always

@m-star5 Diana navarro el perdon


Improve UI

[ ] Add Pagination if multiple entries found.
[ ] Improve the Layout of Boxes.

I want to resolve this issue.

Once done raise separate PR for both.


Tests not discovered

Dev15 Update 3
Works for C# projects, but not Python.
Note: This isn't the low impact install.

Same thing for me after installing the June 17 Dev release. Previously it was working fine.

Seems to be fine now, was probably a bad assembly reference that's since been fixed.


fossor sprit

fossor sprit, mount repos comes with the energy turret sprites
can't you just use the same sprites for outlines and fulls and also draw the regions with mixcol instead of using masks btw?

yes, this mod is still worked in migration to v137, and also refactoring codes too. i really need to clean them up as soon as possible

https://github.com/Sharlottes/sharustry/commit/32fe4f982d393d010e3679f929d268579e6228c4
cleaned

god that's a lot of deleted files
starting on the next one because I have time


[WIP] Add training part of PSPNet

I pretrained PSP's feature extractor with ImageNet.
top 1 error: 0.21452
code I used
https://github.com/yuyu2172/chainercv/tree/resnet-train-dev/examples/classification
weights
https://drive.google.com/file/d/184hZjmsT7XUmGqrd6lS9HMSbGhE_1Xog/view?usp=sharing

Bugs I found

The head convolutions did not use MNBN (instead they were using BN).
I was using weight decay on BN. https://github.com/chainer/chainercv/blob/master/examples/classification/train_imagenet_multi.py#L137

Cityscapes: mIoU 0.7391


[FE] Fix published files

The built files were incorrectly being ignored, this resolves it.
Fixes #4482

Thank you so much for helping out with this!


Branding

To use GraphQL to manage local state seems like an awesome idea!
How about give this project it's own name and logo instead of apollo-link-state?

Let's reopen if it makes sense to discuss


chore(deps): bump vertx from 3.8.5 to 3.9.6

closes gravitee-io/issues#5239

Must wait for the vertx 3.9.6 update at gravitee-parent level.


stat returns size 0 for /sys/class/net//address

stat syscall returns wrong size for /sys/class/net//address files
max@DESKTOP-NKSVSMH:~$ stat /sys/class/net/eth0/address
  File: '/sys/class/net/eth0/address'
  Size: 0               Blocks: 0          IO Block: 4096   regular empty file
Device: 6h/6d   Inode: 34          Links: 1
Access: (0444/-r--r--r--)  Uid: (    0/    root)   Gid: (    0/    root)
Access: 2017-04-14 22:00:30.102866800 +0300
Modify: 2017-04-14 22:00:30.102866800 +0300
Change: 2017-04-14 22:00:30.102866800 +0300
 Birth: -
max@DESKTOP-NKSVSMH:~$ cat /sys/class/net/eth0/address
00:ff:26:dd:2a:9a
max@DESKTOP-NKSVSMH:~$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 16.04.2 LTS
Release:        16.04
Codename:       xenial

strace output: https://gist.github.com/Fukkei/d06c593f354a284d83c3fc68248dc794
Microsoft Windows [Version 10.0.15063]

Thanks for reporting this. Is this breaking anything or just something you noticed?

Hi, thanks for responce. We have code that reads interfaces list, it requests file size to allocate proper buffer size. Not a big deal to fix that, but the behavior itself is quite unexpected

Better in WSL2. Oddly, Real Linux reports a file size 0 across all of /proc (with a few exceptions) but 4096 on /sys. Guess the subtle /sys difference on WSL1 never took down anything particularly visible, given the quiet.


getTasks with filter with emoji doesn't return correct result

Bug description
I have a label containing unicode emoji like 📌 and try to use it in filter. It works in Todoist UI but doesn't work when used from API and returns an empty result.
Expected behaviour
I expect the behavior of getting task with a filter to be consistent between Todoist UI and the api.
Is reproducible
Yes
To reproduce
Have at least one task with label "📌".
api.getTasks({ filter: '@📌', lang: 'en' })

Version information:

Package version: 3.0.1, 2.1.2

Additional information
it might be related to #250 issue but I decided to open a new one just in case.
I'm trying to workaroud this somehow getting the unicode number for this emoji and use it like \ud83d but it doesn't have any visible effect.
Can you suggest something I could do to workaround this on my side?

@dmitry-yudakov It's a related but not the same issue, so thank you for opening it. Again, I have forwarded it to our backend team so they can fix the root cause of this and will report back on any developments 👍

This will depend on how your users are using the app / SDK. One option might be to query by label directly:
api.getTasks({ label: '📌' })

Unfortunately it has to be done using Todoist filters. I can only detect the emoji characters and alter the content of the filter string.
I tried replacing the emoji in the filter with different representations of its Unicode code so that @📌 would be @U+1F4CC or @\ud83d\udccc, tried escaping it with @\📌 as well but nothing helps.

@dmitry-yudakov our team is still working on a solution. In the meantime they suggested you could try replacing emoji with wildcards, but this doesn't work when there's no text to the label (e.g. emoji-only):
@📌pinned -> @*pinned could work 👍

Hi @henningmu, does the backend team have any progress on this?

A fix is in progress, but since it's related to encoding it's a bit tougher to resolve. I'll keep you posted about any progress here 🙌

@dmitry-yudakov thank you for your patience, I'm happy to report that this is now fixed ✅

@henningmu Great, thanks! I can confirm it working 👍


test bump

FOR CONTRIBUTOR:

[ ] - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
[ ] - License permits unrestricted use (educational + commercial)
[ ] - This PR adds a new tool or tool collection
[ ] - This PR updates an existing tool or tool collection
[ ] - This PR does something else (explain below)

Attention: deployment skipped!
https://github.com/bernt-matthias/tools-iuc/actions/runs/3969212358


fivetran_connector doesn't support timeouts

Describe the bug
I can't run some connectors using run_setup_tests because the test takes more than 10 minutes to test.
To Reproduce
Just create a regular connector that takes more than 10 minutes to test.
Expected behavior
I should be able to set a timeout to the resource to allow a bigger time slot for the resource.
https://developer.hashicorp.com/terraform/language/resources/syntax#operation-timeouts
Logs & Output
Not relevant

Fixed in v1.0.0
Added custom timeouts for connector create/update operations


feat: add optional authorization header for Ollama to support Open WebUI

Features

added optional authorization header for Ollama

Feature Docs
Open WebUI lets users create personal API-keys and forwards authenticated requests to Ollama. Unfortunately no content type was declared on the response.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.59%. Comparing base (ab846f6) to head (fa7e3ae).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1465   +/-   ##
=======================================
  Coverage   62.59%   62.59%
=======================================
  Files         287      287
  Lines       17589    17591    +2
=======================================
+ Hits        11009    11011    +2
  Misses       6580     6580

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lgtm


MaskedInputField doesn't support double characters

Basic information

Tiller version:
1.7.2
Module:
@tiller-ds/formik-elements

Bug description
Our masked field needs to have constant number at the beginning and at the end of the value for example 1____5.
But when trying to add second number that is the same value as first one (1) it won't enter it.

Steps to reproduce
<MaskedInputField
mask={["1", /\d/, /\d/, /\d/, /\d/, /\d/, "5"]}
name="number"
/>
this is the input field we used and here that bug occurs when trying to write 1111115.

We currently believe that the problem lies within the external library being used, specifically text-mask. We have attempted to address the issue using their add-ons; however, a similar bug has already been reported here: https://github.com/text-mask/text-mask/issues/1010. Additionally, we tried implementing a new library - https://www.npmjs.com/package/react-imask. However, we would need to extend the API. We'll have to dedicate additional time to this issue.


Call a variable amount of function

Hi !
First of all thanks for the great library, it's really useful and clear !
I have a problem with the LiquidLine::call_function method. How it works from what I understand from the source code is that it checks if the amount of function given as parameters is valid. If it is, it calls the function, else it does nothing.
My problems lies in the fact that some line have multiple function in my menu. For example some just have a gotoOtherMenu function but some have a goto to change the screen + an other function.
My buttonsCheck function look like this :
void buttonsCheck(Pushbutton& up, Pushbutton& down, Pushbutton& OK, LiquidMenu& menu)
{
	if(up.getSingleDebouncedPress())
	{
		menu.switch_focus(false); //Go up
	}
	else if(down.getSingleDebouncedPress())
	{
		menu.switch_focus(true); //Go down
	}
	else if(OK.getSingleDebouncedPress())
	{
		menu.call_function(1);//Won't work on line with 2 functions
		//menu.call_function(2);//Won't work on line with 1 functions
	}
}

The only workaround that I have found is to have all Line object have the same amount of function attached with x amount of empty function attached.
Thanks in advance,
Anthony

Nevermind I was not understing how it works properly, i'll just do this :
else if(OK.getSingleDebouncedPress())
	{
		for (i = 0; i<=MAX_FUNCTIONS;i++)
		{
			menu.call_function(i);
		}
	}

Sorry for creating an issue, have a great day
Anthony


Fix a NPE bug.

To address a potential NullPointerException (NPE), this fix handles cases where the flowSummary() method returns an empty result.
The code now explicitly checks for an empty result from flowSummary(). If an empty result is detected, an empty SensorFlowSummary object is created and returned instead.

Can you add a test for this?

I added a test.
Also fixed an issue I ran into with the watering reports. It looks like Hydrawise does not strictly honor the start time and end time provided to the call. Hence we need to filter out events that happen before and after the provided time range. I updated the tests to cover this case as well.

Please split this into two PRs.


Configure Server.UI as startup project

Didn't raise a ticket for this one, as it was a very minor issue.
The solution will now open with the web application as the default startup project.


How to type Element in component signature when ...attributes applied to other component

I have a simple component ComponentA with component-a.hbs template:
<div
  ...attributes
>
  {{yield}}
</div>

and component-a.ts:
import Component from '@glimmer/component';

interface ComponentASignature {
  Element: HTMLDivElement;
  Blocks: {
    default: [];
  };
}

export default class ComponentA extends Component<ComponentASignature> {}

declare module '@glint/environment-ember-loose/registry' {
  export default interface Registry {
    ComponentA: typeof ComponentA;
  }
}

and a second template-only component ComponentB with component-b.hbs:
<div>
  <ComponentA
    ...attributes
  >
    {{yield}}
  </ComponentA>
</div>

and component-b.ts:
import templateOnlyComponent from '@ember/component/template-only';
import ComponentA from 'component-a';

export interface ComponentBSignature {
  Element: typeof ComponentA;
  Blocks: {
    default: [];
  };
}

const ComponentB = templateOnlyComponent<ComponentBSignature>();

export default ComponentB;

declare module '@glint/environment-ember-loose/registry' {
  export default interface Registry {
    ComponentB: typeof ComponentB;
  }
}

I tried different approaches to  type the Element of the signature of ComponentB but I am stuck with glint/ts complaining that Argument of type 'ComponentA' is not assignable to parameter of type 'Element'.
Is there a proper way to type the Element of the signature of ComponentB or is passing ...attributes to other/child components not supported (yet)?

@dagroe You should type Element in Component B to also be HTMLDivElement since that's the element type where ...attributes will ultimately be applied (even though that ultimately occurs inside Component A).

I am clearing out notifications and came back across 5his and wanted to note the other good move here: First, export the ComponentASignature from its module so it can be imported elsewhere. Then import it in the other module and then reference its Element type directly:

import templateOnlyComponent from '@ember/component/template-only';
import { ComponentASignature } from 'component-a';

export interface ComponentBSignature {
  Element: ComponentASignature['Element'];
  Blocks: {
    default: [];
  };
}

const ComponentB = templateOnlyComponent<ComponentBSignature>();

export default ComponentB;

declare module '@glint/environment-ember-loose/registry' {
  export default interface Registry {
    ComponentB: typeof ComponentB;
  }
}

This will keep the contract in sync over time: if ComponentA switches to using HTMLFormElement or removes it to forbid using ...attributes, or any other such change, ComponentB will always have the same value.


PageIsExplore must be PageIsExploreRepositories

https://github.com/gogits/gogs/commit/e43341f4c562800017a040926857aa9cad6e3f60#commitcomment-13195559

Thanks your PR!
But the template is correct, the problem is missing this value in the router, have pushed fixed on it.

The router was using PageIsExploreRepositories instead of PageIsExplore. So it could be fixed by changing it on the template or changing it on the router.
Not sure why you need two flags (PageIsExplore and PageIsExploreRepositories) to identify that page. So if you fix it by adding PageIsExplore to the router it looks like then the line https://github.com/gogits/gogs/blob/develop/routers/home.go#L54 is not needed anymore.

Not sure why you need two flags (PageIsExplore and PageIsExploreRepositories) to identify that page

There are two navbars, top and left...

There are two navbars, top and left...
Not sure if that makes a difference. If that function is executed as it is coded now both flags PageIsExplore and PageIsExploreRepositories are set to true. I can understand why you can't use only one.

I can't understand why you can't use only one flag.

What if you have explore users feature now? What do you do?

What if you have explore users feature now? What do you do?
Then it is an option to be able to identify in the future the exact subsection of that Explore section. But as for now it doesn't exists because there is only one section. If I understand correctly. It is OK.

But as for now it doesn't exists because there is only one section

This is not a acceptable statement for features we already know to be added.

This is not a acceptable statement for features we already know to be added.

It is a totally acceptable statement because it just explains what's going on. :)
As already said in previous reply. It is OK.
I understand the logic now. And I agree about the need of both flags.

Thanks for your understanding!


Test enhancement

Changed log

Test the available PHP versions in Travis CI build.
Use the class-based to be compatible with the latest PHPUnit version.
Set the multiple PHPUnit versions for the different PHP versions.

Coverage remained the same at 100.0% when pulling 6eab54da71b24e7801f4d1f469a8779d6a338eb8 on peter279k:test_enhancement into 11fbd09e58fac7a5c6f2e7924ec39cdfe69ec70c on QuickenLoans:master.

Coverage remained the same at 100.0% when pulling 6eab54da71b24e7801f4d1f469a8779d6a338eb8 on peter279k:test_enhancement into 11fbd09e58fac7a5c6f2e7924ec39cdfe69ec70c on QuickenLoans:master.

Coverage remained the same at 100.0% when pulling 6eab54da71b24e7801f4d1f469a8779d6a338eb8 on peter279k:test_enhancement into 11fbd09e58fac7a5c6f2e7924ec39cdfe69ec70c on QuickenLoans:master.


why not make the CI fail?

Could it have an option for we make the ci fail instead of just add the label?

Yup that's definitely possible. We can add a parameter alwaysPassCI just in case people don't want tests failing only because of the title format. Would you like to take it up?

I have no idea how it works. However, shows that it would be an if in https://github.com/thehanimo/pr-title-checker/blob/master/dist/index.js#L221 which should exit with 1. Also, we would need a new release after that.

Ideally, you'd only want to make changes to https://github.com/thehanimo/pr-title-checker/blob/master/index.js. The dist folder is generated by the prepare script. We can probably have alwaysPassCI added as a key in the CHECKS object. Then, we can add a parameter to the addLabel function which takes in alwaysPassCI and run core.setFailed("Fail CI test") just after core.info("Adding...").

Hey @camilamacedo86! I just released a new version (v1.1) which addresses this issue. Hope it helps you manage pull requests more efficiently!
Thank you so much!


Ensure that the initial update is complete before sending further updates

I think this pull request might no longer be relevant?


VICPOLWEB-437: Remove left-right padding of card title, for consisten…

…cy to other component and cross browser support.

JIRA issue: https://jira.ogilvy.com.au/browse/VICPOLWEB-437
Changed

Update css for card masonry. Remove left-right padding of card title, for consistency to other component and cross browser support.

Screenshots

Hi @tim-yao ,
Would you please look at this PR ?
I want to update the css for Card Masonry component, which is not merged yet to master.
Thank you,


Regression: parsl fails on small slurm clusters without slurm accounting

Describe the bug
Although larger systems will consistently have slurm accounting, not all small clusters do (it's useful, but not required). #3422 introduced a change to retrieve the job information from the slurm accounting rather than from the scheduler. This breaks parsl on those clusters.
To Reproduce
On any cluster without slurm accounting, call sacct from a shell. It will fail
Expected behavior
From reading through #3422, I understand using sacct reduces load on the scheduler, which is likely beneficial, especially on larger systems. However, it unexpected breaks systems which previously worked. Although we don't want to add a big support burden, a fairly straightforward fix could be to conditionally try sacct and then fall back to the previous behavior based on squeue.
If sacct will be a requirement going forward, this would be useful to discuss and understand. Thanks!
Environment
A cluster without slurm accounting available
Distributed Environment
N/A
cc: @fjonasALICE

looks reasonable to try both. tagging @tylern4 who has more understanding of things than me.

Right I think that makes sense to still support squeue for systems without the accounting database. I wonder if this should be a one time test in the __init__ function and then have two _status functions, the original one called _status_squeue and the new one _status_sacct so the condition only has to be checked once.
It might be good for @raymondEhlers to give the outputs from a system without accounting as well but checking on a local install of slurm without accounting enabled it seems sacct gives return code of 1.
$ sacct; echo $?
Slurm accounting storage is disabled
1

So we should be able to do something like this:
# in the SlurmProvider.__init__
cmd = "sacct"
retcode, stdout, stderr = self.execute_wait(cmd)
if retcode == 0:
    self._status = self._status_sacct
else:
    self._status = self._status_squeue

If that sounds reasonable I'm happy to implement it.

@tylern4 sounds reasonable

(please add lots of DEBUG level logging around this decision point)

Thanks for all of the quick responses and actions!
I can confirm the return value of sacct on our small cluster without accounting:
rehlers@pc059 ~ $ sacct; echo $?
Slurm accounting storage is disabled
1

fast fix - @raymondEhlers can you test PR #3591 in your environment to check it fixes your problem?


Review panel for Hedman/Hamilton spokes data delivery

Sent out emails to Amy Simon and Jeff Cuzzi on 18th Oct.

Eventually settled on reviewers:  Daniel Sega and Maryame El Moutamid.  Also send to Richard Chen.  Also remember that @rfrenchseti wants to look at this data set.

Have sent emails to Maryame, Daniel, Richard and Rob.

Matt sent an email last night providing a DOI for his paper:  https://doi.org/10.3847/PSJ/ad9583

I've responded to Richard's email (where he was asking if it was too late), saying that's fine and requesting review by early in the new year.
Daniel has already submitted his review.

Richard provided review (16/12/24) via email


Feat/lesq 1011/auth terms and conditions [LESQ-1011]

Description
Music year: 1989

adds terms and conditions on the sign in/up pages
removes terms and conditions from onboarding page
fixes a bug where manual school input name wasn't being sent to hubspot

How to test

Go to https://deploy-preview-2716--oak-web-application.netlify.thenational.academy/sign-up
Click on Already have an account? Sign in
You should see the terms and conditions links below the sign in/up component
Go to  https://deploy-preview-2716--oak-web-application.netlify.thenational.academy/onboarding
You should see no terms and conditions on these pages

Screenshots
How it should now look:

Checklist

[ ] Ts and cs are on the sign up and sign in pages
[ ] The ts and cs match the designs
[ ] the links go to the correct pages
[ ] the links open in a new tab
[ ] the aria label indicates the links open in a new tab
[ ] the onboarding pages do not contain ts and cs
[ ] when submitting a manual school input, the school is captured in hubspot

:tada: This PR is included in version 1.528.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add Observation to Observe request response

A subclass of ValueResponse is used to get the
Observation created during an Observe request.
Signed-off-by: Pierre-Henri Trivier<EMAIL_ADDRESS>

LGTM

I'm in a situation where I want to :

send an Observe request to a client, using something like :

leshanServer.send(client, new ObserveRequest(9), onSuccess, onError);

immediately, when receiving the Response, add a listener to the given observation :

ResponseCallback<ValueResponse> onSuccess = new ResponseCallback<ValueResponse>() {
	@Override
	public void onResponse(ValueResponse response) {
		ObserveResponse observeResponse = (ObserveResponse) response;
		ObservationRegistryListener listener = ...
		observeResponse.getObservation().addListener(listener);
	}
}

In general, this is not possible because :

the Observation is not normally attached to a vanilla ValueResponse.
the ObservationRegistry does not provide a way to find the exact Observation that was created as as response to the Observe request

Set<Observation> observations = leshanServer.getObservationRegistry().getObservations(client);
for (Observation observation : observations) {
    // Many observations might have been created for this client
    observation.getClient();
    // Many observations might have been created on the same path
    observation.getPath();
}

As far as documentation go, I should definitely clarify that ObserveResponse is mostly here to provide access to the Observation in responses.
Hoping this clarifies things.

It does, thanks @phtrivier :-)
@jvermillard, will you commit this PR?

@jvermillard I cleaned up the doc, feel free to merge.


What witness is required for pool registration certificates?

Pool registration certificates contain the following information
struct PoolParams {
    operator: PoolKeyHash,
    vrf_keyhash: VRFKeyHash,
    pledge: Coin,
    cost: Coin,
    margin: UnitInterval,
    reward_account: RewardAddress,
    pool_owners: AddrKeyHashes,
    relays: Relays,
    pool_metadata: Option<PoolMetadata>,
}

I want to know which witnesses are required for a transaction that contains a pool registration certificate. However, the spec has two contradictory statements on this:

The witsVKeyNeeded says that we need the VKey of the pool_owners keys

cwitness says the transaction contains only the witness of the operator (same thing is mentioned for pool retirement)

I assume (1) is correct and (2) is wrong?

It's perhaps a little confusing but it is not contradictory.
Note that witsVKeyNeeded takes both:

the certWitsNeeded which for pool registrations is the pool operator; and
the union of the key hashes from all the poolOwners in all the pool registration certs

So it's handled in two parts, the cwitness returns the "primary" witness keyhash, and then for the special case of pool registrations we also take all the pool owners (and for update proposals there's another special rule using propWits).
So the overall answer both from the design spec, and here from the formal spec is that you need witnesses from the pool operator and all the pool owners.


SUP-1751 bk build rebuild implementation

This PR implements the command bk build rebuild <number> <pipeline> -w, calling the rebuild a build api  from the specified build number of a pipeline and returns the url of the newly created build.
The -w flag is also implemented together with this PR where a browser is opened for the created build.

Thanks for the feedback @mcncl. I will create linear tickets for those 👍

This looks good. Perhaps something we can consider in the future is accepting a single arg which is the URL of the build being retried; at the moment it needs to be bk build rebuild 5 org/pipeline which feels long?
Maybe we can look in to bk build rebuild https://buildkite.com/org/pipeline/builds/5
I'd maybe also consider creating an alias so bk rebuild maps to bk build rebuild.

@mcncl, I just realised that bk build rebuild https://buildkite.com/org/pipeline/builds/5 might no longer be needed once we have implement bk build to resolve to a default pipeline. When this happens the command will now be bk build rebuild 5 or bk rebuild 5 (https://linear.app/buildkite/issue/SUP-1814/bk-rebuild-alias-to-bk-build-rebuild)


Unable to upload to Scaleway S3

Pre-requisites

[X] I have double-checked my configuration
[X] I can confirm the issues exists when I tested with :latest
[ ] I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?
I'm having an issue when trying to upload files to Scaleway S3 using the SDK. The following error is occurring:
Non-transient error: Part number must be an integer between 1 and 1000, inclusive

I found a discussion on the rclone forum which suggests that setting the chunk size might be a possible fix:
https://forum.rclone.org/t/error-on-s3-scaleway-with-large-file/23006 . Is it somehow possible with argo workflows ?
Version
v3.4.7
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
any workflow

Logs from the workflow controller
kubectl logs -n argo deploy/workflow-controller | grep ${workflow}

Logs from in your workflow's wait container
kubectl logs -n argo -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded

Currently, the  wait containter uses the default chunk size. Do you like to enhance it to make it configurable?

Can you point me where is it ? If its in Python I could probably take a look there. Not sure how complicated this would be. Probably would need to be configurable on artifact repository level ?

Here the starting point
https://github.com/argoproj/argo-workflows/blob/1617db0f32366bc58cd7f00a044b7e1a58fb830e/workflow/executor/executor.go#L307


Doesn't add bracket for python function or method

Description
https://github.com/windwp/nvim-autopairs/pull/404 make some special action for python file.
However, it still did not work. I believe that is because the rules in here is empty.
Mapping  bug
1.If you report a bug about indent. Please remember that plugin doesn't do anything about indent.
It just trigger the indent of your vim config so if you have wrong indent config then it will do wrong indent.
You can check by select a block of code and press ==
2. provide result of command :verbose imap <cr>.
Steps to reproduce
I believe it is easy enough to reproduce. Just use pyright as lsp and complete a funtion for example os.path.join, the wanted bracket will not show up.
Minimal config

Didn't setup properly. Work after setup.


enums with a shared value get serialized to same string in Swagger

C# supports having multiple enums refer to each other (cause they're the same value), but looks like this isn't handled well when generating swagger

even though it's allowed in .net, it doesn't seem to be allowed by the swagger spec:

that's most likely why the swagger ui doesn't display the dropdown correctly.

ah fair stuff


Why are there 18 human keypoints in this code

There are 17 human keypoints in coco data and  18 in this code.
what is the reason for this?
Thanks for your help!

Hi! Neck is added for a better grouping keypoints into persons instances. You can check more details in the readme.

Thank you


How to sort ase xyz file according to ascending order of energies

How to sort ase xyz file in ascending order of energies

Very thankful to you in advance

This is a general python question, no specific to extxyz or libAtoms.
More or less:
python -c 'import ase.iohttp://ase.io; ase.iohttp://ase.io.write("outfile.xyzhttp://outfile.xyz", sorted(ase.iohttp://ase.io.read("infile.xyzhttp://infile.xyz", ":"), key=lambda at: at.infohttp://at.info["energy"]))'
(assuming the energy is in the info key "energy")

Thanks Noam. I tried to edit out the bogus links above, but it seems email replies don't support Markdown. Here's a copy-pastable version
python -c 'import ase.io; ase.io.write("outfile.xyz", sorted(ase.io.read("infile.xyz", ":"), key=lambda at: at.info["energy"]))'

Thanks for your help. I am very thankful to you.
Can you tell me one think more please:
How to add values to all the energies .
in simple words , i want to add 200 to all energies values...can u help


Enable intentional output logging for omicron (stop using piped console streams)

Closing - had a better idea


GAE Deployed Pubsub OAuth2 Error: oauth2/token: not an App Engine context

This might be related to https://github.com/GoogleCloudPlatform/gcloud-golang/issues/215
Am trying out the service account oauth2 code @mcgreevy shared in the above issue.
jsonKey, err := ioutil.ReadFile(*confPath)
    if err != nil {
        log.Fatal(err)
    }

    conf, err := google.JWTConfigFromJSON(jsonKey, pubsub.ScopePubSub, pubsub.ScopeCloudPlatform)
    if err != nil {
        log.Fatal(err)
    }
    ctx := context.Background()
    ts := conf.TokenSource(ctx)
    c, err := pubsub.NewClient(ctx, projectId, cloud.WithTokenSource(ts))
    if err != nil {
        log.Fatal("new client:", err)
    }

I could call the pubsub APIs locally without using GAE devappserver; however, when running local GAE devappserver or deployed to GAE, I got the following error when making pubsub calls:
oauth2: cannot fetch token: Post https://accounts.google.com/o/oauth2/token: not an App Engine context
I could not figure out what's not right. I'm using Go Appengine SDK 1.9.35. Please help.
Thanks in advance.

you're getting that error, i believe, because you're calling context.Background() instead of appengine.NewContext()

Yes, that'll cause it. Use appengine.NewContext(r) to get a valid context.


[Bug]: Laravel app ENV variables concatenation issue

Description
We are experiencing an issue with concatenating environment variables when deploying a new Laravel app.
Minimal Reproduction (if possible, example repository)

Create a new Laravel app laravel new my-app
Add this app to a new Coolify project (using Github App/Private Repo)
In the Project > Configuration > General > Environment Variables set all required variables(including PAPERTRAIL_URL and PAPERTRAIL_PORT)
Deploy the Laravel application

Exception or Error
The healtcheck fails and the logs throw the error:
[laravel:warn] Your app configuration references the PAPERTRAIL_URL') . ':' . env('PAPERTRAIL_PORT environment variable, but it is not set.
Version
306

Did you found the solution for this? i tried to commend out the configuration files that use thoose env variables, but that didnt help.

[laravel:warn] Your app configuration references the DB_CACHE_CONNECTION environment variable, but it is not set.
hi, i had the same related issues while deploying my laravel 11 project, did you know how to solve this? thank you


Storage docs are (too) hard to find

I went to http://strimzi.io/docs/master/ looking for docs on the storage. There's nothing in the ToC. I guessed and went to http://strimzi.io/docs/master/#kafka_config_map_details and although the bullet list there does give kafka-storage it says to see the related section (no link direct to it, so I don't know where it is, before or after where I am in the doc?) I guessed again and a few pages down is the section for the config, but the section title renders smaller than the body text.
We need to make it easier to find this sort of thing:

Should the ToC go deeper?
We should link direct to the section.
We need to ensure that lower level section headings are more noticeable than body text.

Should the ToC go deeper?

This should be fairly trivial. Just a change of the config in docu.adoc.

We should link direct to the section.

Where would you link to it from?

We need to ensure that lower level section headings are more noticeable than body text.

For this you will need to play with the CSS styles of the website. Or we would need to choose some other style for the documentation and not frame it into the website design.

@scholzj The link is added in your PR (https://github.com/strimzi/strimzi/pull/394). Can be this closed?

Well, @tombentley had some other comments as well ... about the styling and the ToC depth. I think that I increased the ToC depth as part of the branding PR. In master, storage is now in the ToC.
So the styling is the only point left. The Storage title is still in a font with half the size. I suggested to stop embeding the docu because the styled asciidoc output is more readable. But @ppatierno didn't like that. Up to @tombentley what he things whether this should be closed or not.

I have enlarged H5 font in another PR (strimzi.github.io repository).

@tombentley please have a look at it (when you have time) ... I think it can be closed.

I'm closing this issue since no feedback has been received for more than 10 days. Feel free to reopen it if you still feel like something is missing.


Allow slowmode & nsfw in Stage Channels

Pull Request Etiquette

[x] I have checked the PRs for upcoming features/bug fixes.
[x] I have read the contributing guidelines.

Changes

[x] Internal code
[ ] Library interface (affecting end-user code)
[ ] Documentation
[ ] Other: _____

Closes Issue: https://github.com/discord-jda/JDA/issues/2537
Description
So, with the following piece of code jda throws an error:
public static void main(String[] args) {
    Guild guild =...;
    guild.createStageChannel("name").setNSFW(true).setSlowmode(100).queue();
    guild.createVoiceChannel("name").setNSFW(true).setSlowmode(100).queue();
}

Which should not happen, because discord supports NSFW & Text in Stage channels.

Related: https://github.com/discord-jda/JDA/issues/2537

hello, can you maybe correct this here in this pull too?

For Forum Channels there doesnt exist "messageTimeout" (got from getDefaultThreadSlowmode()) and "tagRequired"

See what I posted in Discord discussion, both methods exist

Could you do the same changes for ChannelManager

sure, will do


Update styling on About/Contact page

Failed to mention this issue in my pull request last week. But... might be all set. My local dev environment is still busted, so I couldn't test fully, but tested the html external to the project, should be working.


misleading build steps in readme

Hi there,
Just reading the instructions and I had a bit of trouble.
https://github.com/JaffSoft/swagger-style-validator#to-build
I could not get gradlew assemble to generate the mentioned jar file, and then execute the run commands.
Here are the steps I used to get it working. Perhaps the readme could be updated?
Following the Readme, no jar produced:
$ chmod +x gradlew
$ ./gradlew assemble

:modules/lib:compileJava
:modules/lib:processResources NO-SOURCE
:modules/lib:classes
:modules/lib:jar
:modules/cli:compileJava
:modules/cli:processResources NO-SOURCE
:modules/cli:classes
:modules/cli:jar
:modules/cli:assemble
:modules/lib:assemble

BUILD SUCCESSFUL

Jar produced in the following manner:
To Build
gradle build
gradle fatJar

To Run
java -jar modules/cli/build/libs/swagger-style-validator-cli-1.0.jar -s specs/petstore.yaml -o specs/options.json

Hi @ajohanssonwalder !
Thanks for the report. You are right, the README.md could use a little bit of love. I've done the whole project in approximately a week in my spare time and didn't have to come back to fix small stuff.
I'm seeing a pull request from you, will check that today! Thanks you very much for your interest in my little project :)

Fixed by PR: https://github.com/JaffSoft/swagger-style-validator/pull/2


KJFK increase realism [Proposal]

Hello to everyone again,
I've been thinking about improving the realism of the airport KJFK creating specific files of airlines apra fly there, the system would be similar to that utilized in SBGR and SBGL, create airlines with "na-" before his name, and those having only aircraft using to make routes to the US and Canada. I thought I'd use this table (wikipedia) to create companies from the most real way possible.

Airlines
Destinations
Terminal

Aer Lingus
Dublin
5

Aer Lingus
operated by ASL Airlines Ireland
Shannon
Seasonal: Dublin
5

Aeroflot
Moscow–Sheremetyevo
1

Aerolineas Argentinas
Buenos Aires–Ezeiza
7

Aeroméxico
Cancún, Mexico City
1

Aeroméxico Connect
Monterrey
1

Air Berlin
Berlin–Tegel, Düsseldorf
8

Air Canada Express
Toronto–Pearson
7

Air China
Beijing–Capital
1

Air Europa
Madrid
4

Air France
Paris–Charles de Gaulle
1

Air India
Delhi, Mumbai
4

Alaska Airlines
Seattle/Tacoma[112]
8

Alitalia
Milan–Malpensa, Rome–Fiumicino
1

All Nippon Airways
Tokyo–Narita
7

American Airlines
Antigua, Austin, Baltimore, Barcelona, Bermuda, Boston, Birmingham (UK), Buenos Aires–Ezeiza, Cancún, Caracas (resumes December 17, 2015),[113] Charlotte, Chicago–O'Hare, Dallas/Fort Worth, Las Vegas, London-Heathrow, Los Angeles, Madrid, Manchester (UK), Miami, Milan–Malpensa, Orlando, Paris–Charles de Gaulle, Phoenix, Port-au-Prince, Rio de Janeiro–Galeão, St. Thomas, San Diego, San Francisco, San Juan, São Paulo–Guarulhos, Seattle/Tacoma, Washington–National, Zürich
Seasonal: Dublin, Eagle/Vail, Edinburgh, Punta Cana, Rome–Fiumicino, San José (CR), St. Kitts, St. Maarten
Charter: Havana
8

American Eagle
Baltimore, Cincinnati, Cleveland, Columbus (OH), Indianapolis, Montréal–Trudeau, Nashville, Norfolk, Pittsburgh, Raleigh/Durham, Toronto–Pearson, Washington–National
8

Arik Air
Lagos
4

Asiana Airlines
Seoul–Incheon
4

Austrian Airlines
Vienna
1

Avianca
Bogotá, Cali, Cartagena, Medellín–JMC, Pereira
4

Avianca Costa Rica
San Salvador
4

Avianca El Salvador
San Pedro Sula, San Salvador
4

Azerbaijan Airlines
Baku
1

British Airways
London–City, London–Heathrow
7

Brussels Airlines
Brussels
1

Caribbean Airlines
Georgetown-Cheddi Jagan, Grenada, Kingston–Norman Manley, Montego Bay, Port of Spain, Tobago
4

Cathay Pacific
Hong Kong, Vancouver
7

Cayman Airways
Grand Cayman
1

China Airlines
Taipei–Taoyuan
4

China Eastern Airlines
Shanghai–Pudong
1

China Southern Airlines
Guangzhou
4

Copa Airlines
Panama City
4

Delta Air Lines
Accra, Amsterdam, Aruba, Barbados, Barcelona, Bermuda, Bogotá, Brussels, Dakar, Dublin, Edinburgh (resumes May 26, 2016),[114] Frankfurt, Guatemala City, London–Heathrow, Los Angeles, Madrid, Manchester (UK), Mexico City, Milan–Malpensa, Montego Bay, Nassau, Nice, Paris–Charles de Gaulle, Portland (OR), Punta Cana, Rome–Fiumicino, San Francisco, Santiago de los Caballeros, Santo Domingo–Las Américas, São Paulo–Guarulhos, St. Lucia-Hewanorra, St. Maarten, St. Thomas, Tel Aviv–Ben Gurion, Tokyo–Narita, Zürich
Seasonal: Athens, Copenhagen, Grand Cayman, Grenada, Istanbul–Atatürk, Kingston–Norman Manley, Liberia (CR), Málaga, Montréal-Trudeau, Moscow-Sheremetyevo, Pisa, Prague, Providenciales, Puerto Vallarta, Quebec City, Reykjavík–Keflavík, San José del Cabo, Shannon, Stockholm–Arlanda, Vancouver, Venice
4

Delta Air Lines
Atlanta, Austin, Boston, Buffalo, Chicago-O'Hare, Charleston (SC), Cincinnati, Denver, Detroit, Fort Lauderdale, Las Vegas, Jacksonville (FL), Miami, Minneapolis/St. Paul, New Orleans, Orlando, Phoenix, Pittsburgh, Raleigh/Durham (begins January 5, 2016),[115] Salt Lake City, San Antonio, San Diego, San Juan, Seattle/Tacoma, Tampa, Washington-National, West Palm Beach
Seasonal: Fort Myers, Honolulu, Jackson Hole, Sarasota
2

Delta Connection
Baltimore, Boston, Buffalo, Chicago–O'Hare, Cincinnati, Cleveland, Columbus (OH), Dallas/Fort Worth, Detroit, Halifax, Indianapolis, Jacksonville (FL), Minneapolis/St. Paul, Montréal-Trudeau, Philadelphia, Pittsburgh, Quebec City, Raleigh/Durham, Richmond, Rochester (NY), Savannah, Syracuse, Toronto–Pearson, Washington–Dulles, Washington-National
Seasonal: Martha's Vineyard, Nantucket, Sarasota
2, 4

Dynamic Airways
Georgetown-Cheddi Jagan, Caracas (begins November 14, 2015)
1

EgyptAir
Cairo
4

El Al
Tel Aviv–Ben Gurion
4

Emirates
Dubai–International, Milan–Malpensa
4

Etihad Airways
Abu Dhabi
4

EVA Air
Taipei–Taoyuan
1

Finnair
Helsinki
8

Fly Jamaica Airways
Georgetown-Cheddi Jagan, Kingston
1

Hawaiian Airlines
Honolulu
5

Iberia
Madrid
7

Icelandair
Reykjavík–Keflavík
7

Interjet
Mexico City
1

Japan Airlines
Tokyo–Narita
1

JetBlue
Aguadilla, Albuquerque, Antigua (begins November 5, 2015),[116] Aruba, Austin, Barbados, Bermuda, Boston, Buffalo, Burbank, Burlington (VT), Cancún, Cartagena, Charleston (SC), Charlotte, Chicago–O'Hare, Daytona Beach (begins January 7, 2016),[117] Denver, Fort Lauderdale, Fort Myers, Grand Cayman, Grenada, Houston–Hobby, Jacksonville (FL), Kingston–Norman Manley, La Romana, Las Vegas, Liberia (CR), Long Beach, Los Angeles, Montego Bay, Nassau, New Orleans, Oakland, Orlando, Phoenix, Ponce, Port-au-Prince, Port of Spain, Portland (ME), Portland (OR), Providenciales, Puerto Plata, Punta Cana, Raleigh/Durham, Reno/Tahoe, Rochester (NY), Sacramento, St. Lucia–Hewanorra, St. Maarten, Salt Lake City, Samaná, San Diego, San Francisco, San Jose (CA), San Juan, Santiago de los Caballeros, Santo Domingo–Las Américas, Sarasota, Savannah, Seattle/Tacoma, Syracuse, Tampa, Washington–Dulles, West Palm Beach
Seasonal: Curaçao, Hyannis,[118] Martha's Vineyard, Nantucket, Palm Springs (begins January 14, 2016)[119]
Charter: Havana[120]
5

KLM
Amsterdam
4

Korean Air
Seoul–Incheon
1

Kuwait Airways
Kuwait, London–Heathrow
4

LAN Airlines
Lima, Santiago de Chile
8

LAN Ecuador
Guayaquil
8

LAN Perú
Lima
8

LOT Polish Airlines
Warsaw–Chopin
1

Lufthansa
Frankfurt, Munich
1

Meridiana
Seasonal: Naples, Palermo[121]
1

Norwegian Air Shuttle
Seasonal: Fort-de-France (begins December 3, 2015),[122] Pointe-à-Pitre (begins December 4, 2015)[122]
1

Norwegian Air Shuttle
operated by Norwegian Long Haul
Copenhagen, London–Gatwick, Oslo–Gardermoen,[123] Stockholm–Arlanda[123]
Seasonal: Bergen
1

OpenSkies
Paris–Orly
7

Pakistan International Airlines
Lahore1, Karachi1
4

Philippine Airlines
Manila, Vancouver[124]
1

Qantas
Sydney2
7

Qatar Airways
Doha
8

Royal Air Maroc
Casablanca
1

Royal Jordanian
Amman–Queen Alia
8

Saudia
Jeddah, Riyadh
1

Singapore Airlines
Frankfurt, Singapore
4

South African Airways
Johannesburg–O.R. Tambo
4

Sun Country Airlines
Minneapolis/St. Paul
Charter: Havana[125]
4

Swiss International Air Lines
Geneva, Zürich
4

TAM Airlines
Rio de Janeiro–Galeão, São Paulo–Guarulhos, Toronto–Pearson
8

TAME
Quito[126]
1

Thomas Cook Airlines
Manchester (UK)[127]
4

Transaero
Moscow–Vnukovo[128]
4

Turkish Airlines
Istanbul–Atatürk
1

Ukraine International Airlines
Kiev-Boryspil[129]
7

United Airlines
Los Angeles, San Francisco (both end October 25, 2015)[66]
7

US Airways
operated by American Airlines3
Charlotte, Phoenix
8

Uzbekistan Airways
Riga, Tashkent
4

Virgin America
Fort Lauderdale (begins November 2, 2015), Las Vegas, Los Angeles, San Francisco
Seasonal: Palm Springs
4

Virgin Atlantic
London–Heathrow
4

Volaris
Guadalajara[130]
4

WestJet
Seasonal: Calgary
4

XL Airways France
Paris–Charles de Gaulle
4

I opened this topic because I do not know if there is the intention of the need to improve this issue, or do you think it just acresentaria weight to the game against the benefit?
Sorry about my english, I'm using Google translator.

My main concern is the weight of adding additional airlines in this manner.  The current load times for the game are getting long and every single .json which is added increases load by a significant amount.
There is also significant duplication if we continue this route of creating new airlines to represent a different fleet mix.
The solution I've been considering is to allow individual airlines to specify different fleets for different route types.  Think for example at SBGR instead of having 'sa-ual have 'ual/longhaul' then at KMSP it would be 'ual/shorthaul' and KSFO would just be 'ual' where it uses all fleets or the default fleet.
I haven't done any specific research, but I suspect having longhaul and shorthaul fleets would cover 90% of the existing issues and another couple of fleet types (shortfield?) could cover everything else off well enough.

@MaicomMR, when (if?) #292 is merged you should be able to update JFK without the drawbacks of copying airlines in the previous manner.  I would love to see JFK with a more realistic aircraft mix as you have proposed.

Airlines can now be added with ease, and no negative impacts on performance or load times. Closing.


Unable to add dependency to project.

I followed the steps for Installation but getting an error. Maybe I am doing something wrong, can you please guide regarding this?
Project Gradle File -

App Gradle File with Gradle sync error -

Can you explain why I am facing this issue?

Hello,
you need to replace x.y.z with the version you want to use. The latest is 1.0.0.
So this line: implementation 'com.unsplash.pickerandroid:photopicker:x.y.z'
Becomes: implementation 'com.unsplash.pickerandroid:photopicker:1.0.0'

Thanks for replying back. Can you also add a link in the readme so that we can find out the latest versions of the library? Also, you can close this. Thanks once again.

on top of the readme there is the version


Trying to install a minimal helloworld app ask me for special permissions

As far as I now, every permission that is needed should be declared in the Android Manifest. However, I have compiled a minimal project without any special feature (https://github.com/czak/minimal-android-project/) and still the installation manager ask me for access to the sdcard and calls info.  Does this binary add extra info to the app? pls help.

$ gcl https://github.com/czak/minimal-android-project/
Cloning into 'minimal-android-project'...
remote: Counting objects: 72, done.
remote: Total 72 (delta 0), reused 0 (delta 0), pack-reused 72
Unpacking objects: 100% (72/72), done.
$ cd minimal-android-project/
$ l
total 28
drwx------  4 u0_a93 u0_a93 4096 Sep  2 12:04 .
drwx------ 11 u0_a93 u0_a93 4096 Sep  2 12:04 ..
drwx------  7 u0_a93 u0_a93 4096 Sep  2 12:04 .git
-rw-------  1 u0_a93 u0_a93   14 Sep  2 12:04 .gitignore
-rw-------  1 u0_a93 u0_a93 1773 Sep  2 12:04 README.md
-rw-------  1 u0_a93 u0_a93  251 Sep  2 12:04 build.gradle
drwx------  3 u0_a93 u0_a93 4096 Sep  2 12:04 src
$ buildAll.sh
aapt begun
.
.
.
at com.android.dx.command.Main.main(Main.java:94)
1 error; aborting

How did you get https://github.com/czak/minimal-android-project/ to build on device in Termux @AlbertoMata ?

I just modified the buildOne.sh script. Since I don't have a sdcard, I remove the /sdcard/Download/ prefix and left the directory builtAPKs in the local enviroment. Also, I removed the "src" argument of the "find" comand, so the '*.java' files can be found without problems. It looks like this:
#!/data/data/com.termux/files/usr/bin/sh -e
now=`date +%Y%m%d%s`
if [ ! -d "./bin" ]; then
mkdir ./bin
fi
if [ ! -d "./assets" ]; then
mkdir ./assets
fi
if [ ! -d "./res" ]; then
mkdir ./res
fi
if [ ! -d "builtAPKs" ]; then
mkdir builtAPKs
fi
echo "aapt begun"
aapt package -v -f \
             -M ./AndroidManifest.xml \
             -I $PREFIX/share/java/android.jar \
             -J src \
             -S res \
             -m

echo "ecj begun"
ecj -d ./obj -classpath $HOME/../usr/share/java/android.jar \
	     -sourcepath ./app/src $(find -type f -name "*.java")

echo "dx begun"
dx --dex --verbose --output=./bin/classes.dex ./obj

echo "Make the apk"

aapt package -v -f \
             -M ./AndroidManifest.xml \
             -S ./res \
	     -A ./assets \
             -F bin/step2.apk

echo "Add the classes.dex to the apk"
cd bin
aapt add -f step2.apk classes.dex

echo "Sign step2.apk"
apksigner ../step2-debug.key step2.apk ../step2.apk

cd ..
echo "And make it accessible to the outside world"
chmod 644 step2.apk

echo "Our Step2 app is ready to go"
cp step2.apk builtAPKs/step2$now.apk
echo "Copied to /sdcard/Download/builtAPKs/step2$now.apk"
echo "You can install step2$now.apk from /sdcard/Download/builtAPKs/"
sleep 1

Before being executed, the buildOne.sh script should be placed in the same directory as the AndroidManifest.xml. Run it; you'll end up with a mess of files and directories, but the apk file can be found in the ./builtAPKs directory (the build.gradle file is just ignored by the script.). Copy this apk file to your /storage/emulated/0/Download/ directory and tap on it.
The application works, but I don't know why request those permissions if they are not declared in the AndroidManifest.xml. Thanks for the answers.

@AlbertoMata It is really pleasing to see you building APKs in Termux on device.  I just checked ./scripts/build/buildHelloWorlds.sh and noted that two of three of these APKs also ask for permissions, which as you well note are not necessary for a hello World app.

I found the answer in StackOverflow.
Those permissions (READ_PHONE_STATE and WRITE_EXTERNAL_STORAGE) are implicitly granted for applications that use a version of the API <= 3 (android 1.6). Also, if the attribute minSdkVersion is not specified is set by default to "1". Everything is oficially documented here:
https://developer.android.com/guide/topics/manifest/uses-sdk-element.html
https://developer.android.com/reference/android/Manifest.permission.html#WRITE_EXTERNAL_STORAGE
https://developer.android.com/reference/android/Manifest.permission.html#READ_PHONE_STATE
Adding the following line to the android manifest solves the problem (of course, you can set the attributes to any value that you require):
<uses-sdk android:minSdkVersion="4" android:targetSdkVersion="4" />
I'm still curious, how the appt tool was ported to Termux?


Built and running so smooth on Mojave, With minor issues

First thanks for making this, i really like the idea of augmenting vim without changing it or the way it functions. I managed to build Neovide on Mojave (Because the build at releases is Catalina only) and it works very nicely however it doesn't quit cleanly. For instance if i qa it just freezes, and if i quit it with CMD+Q on mac it crashes with, it seems like something is accessed after the window is closed causing this
libc++abi.dylib: terminating with uncaught exception of type std::__1::system_error: mutex lock failed: Invalid argument

Another issue is that pasting something with ctrl+v doesn't work, idk if it's supposed to work but it's quite annoying
On the suggestion side, things like popups/tabs in vim aren't quite ideal, can you implement custom renderers for them? so that popups are rendered with some styling, tabs can render file icons etc

Duplicate of #221

Duplicate of #113

@j4qfrost thanks for pointing these out, imma close this then


Example app crashing

Hi everyone,
Just started using maplibre rn with success in my own app. Unfortunately i can't run the Example app on both Android real device and Android Emulator
Followed the instruction, yarn install in the example files. Tried to purge and reset cache. All happen correctly from yarn, the dependencies are installed, Metro server start i don't see any build error in the terminal. But when i try to run on Android device, the app crash once build done and android diplay just an aler maplibreRNExample stopped due to bug...
Tried on device Galaxy A05 Android 14 One UI 6.0
and virtuel device under android studio Pixel 6 Android 14 UpsideDownCake Api 34
Java : Jdk17 Android SDK 34.
Any idea from where it come?
Th!

@Pacificdev0,  Is this an Expo App or an React Native app? Either way, please try 10.0.0.alpha.4.
If you are still seeing a crash, and it is an React Native app,  my guess is you are using React-Native > 70.  ReactNativeFlipper.initializeFlipper is no longer required in ReactNative >70. Calling initializeFlipper crashes the app on Launch.  This PR resolved the issue in the example.
Just remove this line here.


Java: No surfacing of errors

Sample does not catch errors in API calls and surface them to the users (collapsed or otherwise).

This software is deprecated. Developers who wish to develop with SOAP should generate their own stubs using the wdsl. Thank you.


react-docgen-typescript support?

Trying to auto generate controls for stories. I have used react-docgen-typescript on other Storybook builds but was getting error mentioning it isn't supported.
=> Failed to build the preview
Error: Rspack didn't support the hooks `react-docgen-typescript`' required

Adding my main.tsx file below

.storybook/main.ts

import type { StorybookConfig } from "storybook-react-rsbuild";

const config: StorybookConfig = {
	stories: ["../src/**/*.mdx", "../src/**/*.stories.@(js|jsx|mjs|ts|tsx)"],
	addons: [
		"@storybook/addon-onboarding",
		"@storybook/addon-links",
		"@storybook/addon-essentials",
		"@chromatic-com/storybook",
		"@storybook/addon-interactions",
		"@storybook/addon-a11y",
	],
	framework: {
		name: "storybook-react-rsbuild",
		options: {},
	},
	docs: {},
	typescript: {
		reactDocgen: "react-docgen-typescript",
		reactDocgenTypescriptOptions: {
			shouldExtractLiteralValuesFromEnum: true,
			propFilter: (prop) =>
				prop.parent ? !/node_modules/.test(prop.parent.fileName) : true,
		},
		check: true,
	},
};

export default config;

Yes, it's a known unsupported feature for now and listed in the README. It will be supported when Rspack support dynamically register template by dependencyTemplates.


Add multipart/form-data JSON part support

Add GIF mimetype support
Add FormPart to allow serialization of individual parts with custom headers
Change Encoder to take a list of serializers
Change the order to ensure that file parts are last

@sdcoffey Can you please take another pass? Thanks.


[WIP]Fix sbref dupe

There were two images with different titles but the same image in reports for ds054.
Need to confirm these changes don't mess with ds005 in any way.

There are no sbrefs in ds005. Did you mean ds054?

The change in the config.json potentially effects how/when mean epi registration is displayed, which is used by ds005.


[SPARK-45283][CORE][TESTS] Make StatusTrackerSuite less fragile

Why are the changes needed?
It's discovered from Github Actions that StatusTrackerSuite can run into random failures, as shown by the following error message.  The proposed fix is to update the unit test to remove the nondeterministic behavior.
The fix has been made to the master branch in https://github.com/apache/spark/pull/43194.  This PR is meant to patch branch-3.5 only.
    [info] StatusTrackerSuite:
    [info] - basic status API usage (99 milliseconds)
    [info] - getJobIdsForGroup() (56 milliseconds)
    [info] - getJobIdsForGroup() with takeAsync() (48 milliseconds)
    [info] - getJobIdsForGroup() with takeAsync() across multiple partitions (58 milliseconds)
    [info] - getJobIdsForTag() *** FAILED *** (10 seconds, 77 milliseconds)
    [info] The code passed to eventually never returned normally.
           Attempted 651 times over 10.005059944000001 seconds.
           Last failure message: Set(3, 2, 1) was not equal to Set(1, 2). (StatusTrackerSuite.scala:148)

Full trace can be found here.
Does this PR introduce any user-facing change?
No
How was this patch tested?
build/mvn package -DskipTests -pl core
build/mvn -Dtest=none -DwildcardSuites=org.apache.spark.StatusTrackerSuite test

Was this patch authored or co-authored using generative AI tooling?
No

@LuciferYang
Per your request, I'm creating this PR.  Please merge it to branch-3.5 at your convenience.

CEP support in Spark Streaming

Merged into branch-3.5 to fix the flaky test. Thanks @xiongbo-sjtu


When removing last element of input data, Pager is blank

@State var notifications = [
  "You have run out of steam in your engine, buddy!",
  "Your dragon is feeling healthy",
  "This is a long, long tale of magic and heroes. So sit down and listen carefully."
]

var body: some View {
  VStack(spacing: 16) {
    if notifications.count > 0 {
      Pager(data: Array(0..<notifications.count), id: \.self) { index in
        self.bannerView(self.notifications[index])
          .onTapGesture {
            self.notifications.remove(at: index)
          }
      }
        .itemSpacing(8)
        .itemAspectRatio(0.9)

    }
  }
}

If I click on second message, everything works fine. If I click on 1st message, everything works fine. If I click one by one from first message to last, everything works as expected. But if I scroll to the last element and click on it, the whole Pager view becomes blank.
Working as expected:

Not working as expected:

Hi @NeverwinterMoon ,
It seems SwiftUI recreates Pager but keeps its old state, therefore page was out of bounds. Can you try using version 1.3.1-beta.1? Should be fixed there.
If you need me to release this beta on Cocoapods, please let me know.
Thanks

I tested it a bit and it works great, will try it more throughly today! CocoaPods release would certainly be great. Thanks a lot!

Hi @NeverwinterMoon ,
I can release the beta in Cocoapods if you're using it to help you test it. I'll wait a bit to bump the version in case something else arises.
Thanks a lot

Well, I can use it though CocoaPods like this without a release anyway pod 'SwiftUIPager', :git => 'https://github.com/fermoya/SwiftUIPager.git', :branch => 'fix/pager-swiping', so I guess the actual beta release is not that crucial.
I've first tested everything in a playground project and it looked fine, now I carried over to testing this in my actual project and having no issues whatsoever except for the scrolling one mentioned at #18. That one is a real bummer, considering that the pager frame occupies plenty of screen that is also vertically scrollable. But I will close this ticket, as the original problem seems to be completely resolved. And thanks a lot, great work!


proposal: specify and enforce package paths to be all lowercase

Hi,
Because the current specifications do not limit or prevent people to name their packages in any way, situations like https://github.com/sirupsen/logrus/issues/553 happen when a project can be imported via github.com/sirupsen/logrus or via github.com/Sirupsen/logrus. There are many other instances of organization names or project names that have these issues, for example Netflix with https://github.com/netflix/chaosmonkey instead of the correct https://github.com/Netflix/chaosmonkey
Granted this is as much of a @github issue as is a Go tooling issue but it's quicker to fix Go than to break the Internet by getting Github to change their matching algorithm.
However I believe that specifying that packages should always be lowercase and if they are not they are converted automatically by the tooling that creates / downloads them from third party systems.
To make this as backwards compatible change, this could start be softly applied, e.g. go get and other tooling will always perform the lowercase transformation when downloading packages locally but the Go compiler or other existing tool is not changed until Go 2.0. Tools such as go vet or golint could meanwhile start to flag this as an issue so that people can gradually fix this.
What do you think?

I think you want package import paths, not package names - in the example, the package name is logrus and the path is github.com/sirupsen/logrus.
I'm not sure if I'm behind this proposal, as this would (eventually) force certain users like @shurcooL to update all of their import paths. He also uses uppercase in some projects like https://github.com/shurcooL/Go-Package-Store.
I realise that you proposed a soft version of this for Go1, but I'm still not convinced this is worth the trouble in Go1. Also note that go vet will be integrated with go test soon, so you would likely end up breaking people's package tests.

I think you want package import paths, not package names

As far as I can understand from the specifications, there is no concept of import path, just package. Also I always think of github.com/dlsniper/demo as the package named demo that is contained by the package dlsniper that is contained by the package github.com. But yes, I would like both the path on the storage medium after the $GOPATH/ to be lowercased as well as the package itself.

My bad - I keep forgetting that interpreting package names as paths is not an explicit part of the spec. Ignore the first sentence of my comment above.

Also I always think of github.com/dlsniper/demo as the package named demo that is contained by the package dlsniper that is contained by the package github.com.

Packages have no parent/child/contains relationship. The import path above refers to a package named often, but not necessarily 'demo'.

I've changed the proposal topic to say "package paths" rather than "package names", since that seems to be what you are discussing.  go get works on package paths, not package names.
I don't think we can reasonably restrict package paths to be all lowercase.  That simply doesn't make sense on systems like Windows that routinely use uppercase letters (and spaces) in directory names.

From what I understand, only a very small number of Go packages in the wild have problems with import path case inconsistency, is that right? What do you think of taking the approach of directly fixing those specific Go packages that are broken? The import path comment is specifically helpful for clarifying (and enforcing) the exact import path of a package, and broken packages can use make use of it.
That seems like it'd be less overall work/changes required to resolve the problem, and doesn't cause unnecessary changes in many packages that are not broken.
As @mvdan mentioned, my GitHub username happens to have a capital letter in it. I have over 197 Go packages with a capital letter in the import path, and all of them work without issues. I would be open to the possibility of changing them if were needed, but it doesn't seem to be needed.
If the Go documentation doesn't make it very clear that import paths are case sensitive, perhaps that can be improved. (I think it does, but I haven't checked recently.)

My bad - I keep forgetting that interpreting package names as paths is not an explicit part of the spec. Ignore the first sentence of my comment above.

Both "package name" and "import path" are an explicit part of the spec, see https://golang.org/ref/spec#PackageName and https://golang.org/ref/spec#Import_declarations. There's no interpreting of the import path, but an import path as a concept is well defined. It's a string literal. There are some restrictions on its contents:

The interpretation of the ImportPath is implementation-dependent but it is typically a substring of the full file name of the compiled package and may be relative to a repository of installed packages.
Implementation restriction: A compiler may restrict ImportPaths to non-empty strings using only characters belonging to Unicode's L, M, N, P, and S general categories (the Graphic characters without spaces) and may also exclude the characters !"#$%&'()*,:;<=>?[]^`{|} and the Unicode replacement character U+FFFD.

Because the current specifications do not limit or prevent people to name their packages in any way

This statement is untrue, there are multiple restrictions on the import paths:

Implementation restriction: A compiler may restrict ImportPaths to non-empty strings using only characters belonging to Unicode's L, M, N, P, and S general categories (the Graphic characters without spaces) and may also exclude the characters !"#$%&'()*,:;<=>?[]^`{|} and the Unicode replacement character U+FFFD.

See also #20210, it's a related proposal about considering additional restrictions on the import path.

Isn't that pretty much exactly the problem that canonical import paths were added to address? It seems like it would be much easier to migrate to enforcing canonical paths than to enforcing lower-case paths.

I also have capital letters in my GitHub username, and on my computers and servers, I created the go path and directories with all lowercase directory names. Currently, this works fine. If we were to implement this change, wouldn't I need to again go get or clone these repositories again with the proper casing?

If the repo has a go.mod file, we already verify that the casing of the import path matches the declared module path. This should resolve on its own as package owners add go.mod files.


Lora implementation in finetuning and evaluation

Hi @caroteu,
I'll close this PR in favor of arranging the experiments in the discussed repo from now on. Feel free to reopen if you think there are some crucial changes to be added via this PR.


Allow revoking OAuth login

It should be possible to revoke the ability to log into an account via an OAuth identity provider in the case where the user no longer trusts that provider.

@taralx can you point to other products with similar features?
In terms of related things we do support: An organization can always disable an identity provider entirely, and if a user doesn't have an account with an identity provider with a validated email address, it won't be possible to authenticate with that identity provider for that user.


minimagick outputter

Would you be interested in minimagick outputter? I'd like to use this project with minimagick instead of rmagick. I'd like to implement this if you're interested in adding it to the project.

Yes, PR welcome.


Private functions shouldn't be promoted to be used

While I'm hunting for some weird CI issues in astroquery, I've run into this in pyregion. IMO we shouldn'y promote usage of private functions in the getting started page, if this needs to be in the API then expose it properly in the API docs, etc.
>>> import pyregion._region_filter as filter

@leejjoon - Brigitta is referring to this example that you added 9 years ago:
https://github.com/astropy/pyregion/commit/807acbd9a94cd72f31e2213698ad5885c7aadb36#diff-34754436d3d51c72ac3cfcec1be6f3ecR181
>>> import pyregion._region_filter as filter
>>> myfilter = filter.Circle(0, 0, 10) & filter.Box(15, 0, 10, 10)
>>> myfilter.inside1(0, 0)
0
>>> myfilter.inside1(10, 0)
1
>>> myfilter.inside([0, 10], [0, 0])
array([False,  True], dtype=bool)

The Circle and Box aren't listed in the public API docs, and my suggestion would be to simply delete that example.
The alternative is to properly expose that part of pyregion, and to spend time documenting it, which IMO doesn't make much sense given that by now there's  http://astropy-regions.readthedocs.io/ which
is build on Astropy, has region classes and mask creating implemented.
@leejjoon - Thoughts?

Yes, it seems that it is best to just delete those examples.


Adding chips triggers form submit

Steps to reproduce
Add an md-chips component inside a form with a submit handler
Which browser?
Google Chrome 55.0.2883.87
What is expected?
Form should not submit when adding chips.
What is actually happening?
Chip is added and triggers form submit.
Reproduction Link
https://codepen.io/dEradicated/pen/VPWeQy

I will fix that soon. Sorry about that.

This issue seems still happen on version 1.0.0-beta-10.2.

KIndly fix this issue. I just love VueMaterial but this issue is making things worse.


compatible Vuetify 2.3

@eolant merge?

while not merged you can use @jaredhan418 fix like this:
yarn add https://github.com/jaredhan418/vuetify-toast-snackbar.git#master
And replace dist/index.js by src/index.js in node_modules/vuetify-toast-snackbar/package.json

@faouzzz what do you mean with the replacing? when would i have to do that? and why?

@eolant any update on this PR?


WIP: feature(snapshots): experiment with replacing Walden by DVC

Experimental replacement of Walden by DVC demonstrated on Maddison GDP dataset.
dvc is essentially git for large data that supports similar set of commands.
Comparison with Walden:

dvc push is pretty much the same as walden.add_to_catalog
walden has special objects Dataset and Catalog that impose structure and rules on the files, dvc does not use that (is that a pro or con?)
walden compares md5 of local files and index in git, dvc compares it against S3
TBD

We might not use this in the short term, but since we're revisiting data architecture and playing with git-lfs, I'd keep it open for some more time.

I think the data should be inside data/snapshot instead of being next to the data step code.

Good idea, fixed that. Class Snapshot(...) now accepts namespace/version/filename.ext instead of full path.

There are a few instances of "Walden" in the code that should be removed.

I'm gonna clean it up after we go all in on Snapshots.

For cases where the data is fetched for example from an API, it would be convenient if there was a method to ingest a dataframe directly (which would create a file in the right place), instead of having to have additional code in the ingest script to create a local file.

That'd be cool. I'll rewrite your function add_to_catalog to work with snapshots.

@pabloarosado I've also added add_snapshot helper function and tested it on aviation safety network. I hope this clarifies how can it work with dataframes.


Typescript Perf Degradation: Freeverb + JCReverb

In the typescript branch, it appears that just by creating multiple JCReverb or Freeverb instances, even if they aren't connected to anything, will create pretty significant performance issues.
The issue is more pronounced with Freeverb and the issue doesn't appear with @next.
Example

I've revamped one of the main components of these two nodes which is the FeedbackCombFilter which is probably the cause of this performance issue. The rewrite is entirely using the AudioWorkletNode which produces much better results which are more "correct" than using the feedback delay which caused some discontinuities in the output. The issue is that now it requires much more processing for these nodes which use a lot of AudioWorkletNodes like these two reverbs.
I'm thinking of just deprecating these nodes and recommending users just use Reverb and/or adding a notice in the docs which explains that users should expect poor performance with these nodes. That is until i figure out how to optimize the performance of the AudioWorkletNode (and maybe iron out a few bugs in Chrome and FF's implementations).
The specific issue that you mention of poor performance even when nothing is connected is because the rendering callback is always returning true in the rendering callback, which means that it's always processing even when there are no connections. I think there might be a bug in Chrome which causes it to be silent until i add that in there. i haven't had time to investigate further which is why i'm just returning true in all cases for now.

Thanks for the thorough explanation on this. The fix for https://github.com/Tonejs/Tone.js/issues/569 should unblock me from using Reverb instead of either of these nodes.
I think adding notes in the release/docs about the performance differences would be helpful for sure.
However, as I was reading Paul's notes on Reverb performance, he specifically mentions that ConvolverNode's are more CPU intensive.
I think it would be nice to be able to allow the user to choose between a more correct or more performant node.
If given the choice, and due to how complexity of the audiograph I'm working on, I would opt-for performance over correctness.
Would you consider winding back and keeping one of the "less correct" nodes around? I know maintaining the old implementation moving forward may be pain, but just throwing my 2 cents in.

should I close this?


Bump dhcp library, fix Windows compilation

Fix https://github.com/containers/gvisor-tap-vsock/issues/26

/approve

/lgtm

/lgtm


about SBR pretrained model

Hey,
I used your pretrained model for SBR model, and results are impressive, though I have one question regarding that. Did you train the model only on 300W dataset, meaning it doesnt include 300VW as well?
If so, if we could train it with 300W and 300VW combined, should we expect a significant increase in accuracy?
Regards, Kadir

Thanks for your interest and question. "Training on 300W and unlabeled 300VW" should improve the accuracy on 300VW compared to "Training on 300W only". It might not improve the accuracy on 300W. Since our SBR focuses on the temporal consistency, it will help the detector to be stable on video but might not help it to be accurate.

Hey,
Thanks for the very fast reply. I don't use 300W or 300VW for benchmarking, but solely for training purposes. What I mean by 'increase in accuracy' is actually in real-time cases, e.g, test videos and USB cameras.
And by the way, what do you mean by unlabeled 300VW? Isn't the 300VW dataset labeled the same way as 300W, but instead of pictures, labeled in each frame?
Thanks in advance.

In the real-time cases, the detector might not have accuracy gain, due to the distribution change between the training and test videos.
"unlabeled 300VW" means train SBR with 300VW video data without using its facial keypoint labels.

I closed the issue, but since your answers are really improving my knowledge, I wanted to ask a couple more questions on the topic.
If we are using 300VW dataset without its annotations, can't we use just any video dataset instead of 300VW?
How about we extract the frames of 300VW, add them to 300W as individual pictures (maybe 1/5 of frames), use their annotations to create bounding box mat files, thus expanding our annotated dataset, and then use another unlabeled video dataset (like youtube dataset) for improving SBR?
Also could we add Menpo face landmark dataset to increase our dataset, assuming we created it's mat files and got it to same format as 300W?

Thanks for your interest.
1, Yes, we can use any video dataset. We use 300VW just because they are popular.
2, Yes, it is good idea.
3, Yes, you can. You do not need to create mat file, you just need to create the list file as 300W or 300VW (https://github.com/D-X-Y/landmark-detection/blob/master/SBR/scripts/sbr_example.sh#L3).


how to insert any image  as question

I want to add an image while the script asks question, is it possible ?

Sorry, this is not possible at the moment, but I will consider adding this to future updates.


create a Option to set ReconnectBufSize

it's annoying to set this now as no Option helper exist

Closed with PR #340