Failing integration test: Add and delete client RedirectUri values

Not sure if this is a bug or I'm doing it wrong, but I've created an integration test for a scenario I believe should work with creating and deleting client RedirectUris values. This should be a failing test.
If you want to merge this in later for any reason I can rebase, I'm aware this isn't mergeable in its current form.

Hi @kendaleiv, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

I just switched the tests over to xUnit today -- I think you missed my commit by like an hour.

No worries -- it's an easy switch, if you want to pull this in for any reason.

Why the hell not -- more tests are a good thing :)

Oh and I've seen you code -- so I pretty much trust any test you'd write for me!

Well, this one is currently failing, and is the reason for the PR.
Failing for me, anyhow...

Let me know if you'd like it rewritten with xunit before you look into it, if it makes things considerably easier.

@kendaleiv, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;

So yea, go ahead and port them over (er, really just grab latest on dev and move them over). Once you've done that, then it'll be more clear to me what's what.

Closing, see #53.


Error building

Building latest code, I got this error:
Severity	Code	Description	Project	File	Line	Suppression State	Details
Error	LNK1104	cannot open file 'spirv-cross-cored.lib'	Standalone	C:\Users\Manu\Downloads\octave-main\octave-main\Standalone\LINK	1
How can I fix it?

I believe this error will happen if you don't have "Shader Toolchain Debug Symbols = 64-bit" selected during the VulkanSDK installation process. I have updated the README to include this requirement. If you don't care about building a debug build, you can also compile the editor/game in Release mode without needing the vulkan debug libraries.


Update validity check for experiment names to be case sensitive

The sixpack-py client allows for experiment names to be uppercased, but
the javascript and ruby clients enforce lowecase experiment names only.
This PR updates the client code to match the javascript and ruby
implementations.

Add another regex for experiment name and use that for validation
Add tests

seems right to me.


"flow : auth-code" : : Getting Refresh Token on each authorization

I used react-OAuth in react and I successfully get "code" but each time I get code, after generating tokens in the backend I get a refresh token. In Ideal conditions, we should get a Refresh token once, when we give consent for the first time. I am using googleapis in the nodejs app. And the same is also mentioned there.
Thank you.
Please mention if am missing out on something.

It's handled by google, each login will have new code which exchanged for new tokens
https://developers.google.com/identity/protocols/oauth2/web-server#exchange-authorization-code

@asit-behera
Just out of the curiosity do you need access token from you backend to access any of the google services?
The same question for the frontend part, are you using access token on a frontend to request any of the APIs?

@ievgennaida
I am storing the refresh token in my persistent storage.
and am fetching all data from from google in backend only.
My frontend is only responsible to send me the code after authrozation.


Need to type Ctrl-V twice (macOS)

On macOS, I need to type Ctrl-V (bound to edit:insert-raw) twice to get the desired effect. If I wish to insert a literal Ctrl-V, I need to type it four times.
I only have to run edit:insert-raw once in the minibuffer, however.

This also happens on FreeBSD but not my Linux VMs. On WSL (windows subsystem for linux) it has a different bug. Typing one [ctrl-v] starts raw mode but it doesn't actually emit the raw char. For example, [ctrl-v][ctrl-v] results in a literal V being inserted.

The bug is due to how the termios iexten flag affects input on Linux versus BSD. On Linux it is ignored if canonical mode is disabled. On BSD it still affects some input if iexten is true and canonical is false.


Continuous integration tracking issue

Setting up Github actions to check PRs, commits on main, and automate releases would be super nice. I worry it may not be worth the effort, but it should at least be considered.

[ ] Lint, typecheck, and build every commit and PR

[x] #25
[ ] #51

[ ] Integrate Nuxt testing with CI
[ ] Build nightly release artifacts
[ ] Automate building release artifact

Closing for now. I had some issues getting EdgeDB installed in a CI environment. Specifically, generating queries requires access to the initialized and migrated database. Query generation is a postinstall step, so you can't really skip it. I may revisit this in the future if I think the project needs it.


rename javax.activation properties to jakarta.activation

As per JakartaEE9ReleasePlanFAQ properties javax.activation.addreverse should be changed to jakarta.activation.addreverse + javax.activation.debug to jakarta.activation.debug.

I believe this has been done already. New properties are handled here and here. Or do you insist on completely removing handling of old 'javax' props? I don't believe handling old props for some time is going to hurt anyone...

Just noticed this Issue... There is no requirement to stop recognizing and processing the old javax properties.  I know of other impls that plan to support both javax and jakarta properties (as an aid with migrating).

@lukasj @kwsutter I agree (supporting both javax.* + jakarta.* properties is more compatible) and will close this issue.
Should we update other SPEC API projects that only check for jakarta.* properties?


feat: make 'kcl mod run' support ModSpec

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[ ] N
[x] Y

re https://github.com/kcl-lang/kpm/issues/289

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[x] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[ ] Unit test
[x] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[ ] Other

Pull Request Test Coverage Report for Build<PHONE_NUMBER>8
Details

18 of 30 (60.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+1.0%) to 15.591%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/options/run.go
18
30
60.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/options/run.go
1
29.73%

Totals

Change from base Build<PHONE_NUMBER>7:
1.0%

Covered Lines:
99

Relevant Lines:
635

💛  - Coveralls


announceText not seen

Expected Behavior
I've seen in code the use of announceText to likely display on screen that the data is sorted by a given column. But I do not see that text in usage. I am in fact looking for a way to let the user know more clearly that data is sorted by so and so column.

That text is meant for screen readers


Bump manageiq-smartstate gem to 0.2.8

In order to pick up https://github.com/ManageIQ/manageiq-smartstate/pull/52
bump the manageiq-smartstate gem in the Gemfile to 0.2.8
Describe the rationale and use case for this pull request.  Provide any background, examples, and images that provide further information to accurately describe what it is that you are adding to the repo.  Add subsections as necessary to organize and feel free to link and reference other PRs as necessary, but also include them in the links section below as a quick reference.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1519555
@roliveri @hsong-rh please review and merge.
Links [Optional]

https://bugzilla.redhat.com/show_bug.cgi?id=1519555
https://github.com/ManageIQ/manageiq-smartstate/pull/52

Steps for Testing/QA
THis is a particularly difficult fix to test.  We happen to have one instance of this issue showing up in a customer location and we were able to test it onsite but it would be difficult to do so programatically.

@miq-bot add_label fine/yes

@miq-bot add_label gaprindashvili/yes

Gaprindashvili backport details:
$ git log -1
commit cfe010112fef84cf481ae44760a6cc1db0e46186
Author: Richard Oliveri<EMAIL_ADDRESS>Date:   Fri Feb 9 17:47:33 2018 -0500

    Merge pull request #16985 from jerryk55/bump_smartstate_to_0.2.8

    Bump manageiq-smartstate gem to 0.2.8
    (cherry picked from commit d4a91f5434110a5be2c2cbdddce40349626e6bf1)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552782


Styles block not updating as we move our cursor

Bug Report 🐛

(Package: Markdown Editor)
The styles block that shows the current styling (H1, H2, Normal Text, etc.) does not get updated with the move of our cursor. It only updates when we start writing inside that block. This is not the case in editors like google docs. They update the styling bar as the cursor moves. This might get very annoying when we try to find the styling of a block and just clicking on the block does not do anything. Then we need to write to find out what the styling is.
Expected Behavior

The styling box should change according to the block of text that our cursor is on top of.

Current Behavior

The styling box does not change according to the block of text that our cursor is on. It waits for us to write inside of the block to update.

Possible Solution

Steps to Reproduce

Go to the markdown editor.
Monitor the style box as you move the cursor around the text of different kinds of styles.
The style box would not update as you move around different kinds of blocks

Context (Environment)

Desktop

OS: Windows 10
Browser: Chrome
Version 88.0.4324.182 (Official Build) (64-bit)

Detailed Description

Possible Implementation

@Michael-Grover I would like to work on this issue.

@Michael-Grover I have almost fixed the problem by calculating the result(current block) in the onChange function. The style block does not respond to Heading 4, Heading 5, and Heading 6 as they are already not listed in the dropdown menu. Are those text styles going to get dropped in the future?

I think there's a reason for having h4-h6 but I'm not sure. @DianaLease or @irmerk do you remember? I think we have h4-h6 because markdown usually has those header styles, and if people import markdown text that includes h4-h6, we don't want the document to break.

I don't recall the reason for omitting H4-H6. My best guess is it was purely design based. But we're based off the CommonMark spec, which does support H1-H6. Is there any limitation in markdown-transform @dselman or @jeromesimeon?

My reasoning for omitting H4-H6 in the dropddown is because the size difference between the six different headers and one paragraph style would be practically indistinguishable from each other unless the H1 was comically large (which it used to be). By having fewer header styles, we can be sure that they are each visually distinct from each other
I would be interested in a lawyer's opinion about how many levels of headings they would need in a contract. I can't think of any contracts I've seen with six different heading styles. It's my understanding that usually the formatting of contracts is very minimal, and hierarchy of information is shown with nested lists of sections and subsections rather than different sizes of headings.

My thought would be that would be up to the individual lawyer using the editor, and that person can choose to use H5 or not based on the styling. If we are based on the CommonMark spec, we should support the CommonMark spec.

Jira uses six heading styles, and they choose to make H4-H6 smaller than the paragraph text, which seems kind of weird to me. I'm not sure how many contract authors will want headings that are smaller than the paragraph text. However I think I prefer their approach versus making all of the headings styles a size between H1 and paragraph, meaning that they will be very similar in size and visually indistinguishable. Maybe we should discuss in the next AP Tech WG call to get opinions from engineers and lawyers?

@Michael-Grover could you create a separate issue for the H1-H6 topic?
@d-e-v-esh I think you can continue on with what currently exists (H1-H3) and get a solution that will work with whatever comes from the H1-H6 Issue.


abolished chromatin binding at centromere central core

PMID:26744419

abolished chromatin binding at centromere central core FYPO:0006106
edit file: b99030e70d97daf5cf3f2093146f25c37c7b4d78
release: 767683a7bde6608b96c79e82ea54e5ebb1cefb23


Cron job /cron/group_sync is causing NotImplementedError

I don't understand this part. The cron job /cron/group_sync is turned on but the actually method is not implemented, which causes NotImplementedError.
I think if it's not implemented yet, it' better to turn off the cron job.
Because, for now, it is has errors log every 60 minutes in the App Engine.

Valid.  Thanks for the report!
https://github.com/google/cauliflowervest/commit/251874e1a517d67a56d9b5a809fde60a4109bab0


Issues found in final OMOP files

Hi, thanks for fixing previous issues in such a prompt time! I also found the other issues.

Duplicated rows in person table.
There are several duplicate rows for some specific person_id. Some rows have different records in year_of_birth column.
Here's the example of running only "MIMIC-III" Dataset.

One concept_id 3711521 couldn't been found in concept table
This concept was used in observation table. I presume it is body weight (group).

"unit_source" column in measurement table is not defined in OMOP CDM. It should be named as "unit_source_value"

"time" column in measurement table is not defined in OMOP CDM. It should be named as "measurement_time"

Thanks for looking into this!

Thanks for this, I will be checking all of it soon !

Regarding your last point:
According to https://ohdsi.github.io/CommonDataModel/cdm53.html#MEASUREMENT measurement_time is deprecated and measurement_datetime will be required in v6.
These two columns are given in the current measurement table.
Because the admission dates are not specified in some of the ICU datasets, I set a reference date (2023-01-01 00:00) for the ICU admission. measurement_datetimes prior to that date mean "before admission". Because these dates are artificially added to fit the OMOP requirements, I choose to keep the "seconds since admission" time column which is here for convenience. I'm keeping this additional time column for now, but feel free to drop it you need to fit more stricly to OMOP standards.

Thanks for pointing out this! So I think I will omit the time column for now and only use measurement_datetimes since they essentially contain the same information.


invite Chlerry to write a blog about his charitable project

@Chlerry is a student at the University of Nebraska - Lincoln and trying to use wechaty to do a charitable project, it may provide service for Food Industry sponsor.
I think this is an interesting project so I'd like to invite him to write a blog about his project, and he promises he will write a blog after his project is passed after this week.
Waiting for your blog!
Thanks @Chlerry

ping @Chlerry ：）

Sorry for the late reply. We have dissolved our development team due to insufficient fund and human resource.
However, I do think that WeChaty provides developers with a great opportunity to build WeChat management and promotion tools. In the early stage of our original project, we aimed to create a non-profit community for Chinese International student at the University of Nebraska. In the past three years, a member of our team has built up a blog using WebPress, where new coming Chinese could find helpful information about the university town and living skills in North America. Although at the beginning of the blog's release, there was a significant amount of visit, students still preferred asking questions directly in the WeChat group later on.
Then I started to consider integrating the blog with WeChat so students can get some valuable answers immediately in a WeChat group, without waiting for someone to answer. In the early phase of our development, everything was very smooth because WeChat offered all the programming interfaces we need, such as automatic responding, keywords detecting, and group administration. In addition, the project is well documented, and the project maintainers are very active.
Moreover, we saw a great opportunity to co-operate with local Chinese restaurants, in order to exchange for some funds. In a specific case, a restaurant delivers lunch meals to the university campus every day with pre-ordering in WeChat. Our tools built on WeChaty can help the restaurant save some potential labor cost. Unfortunately, the restaurants were not interested in this cooperation because they decide to stick in their old ways of business.

Hi, @Chlerry
Thanks for the reply, could you like to share your thoughts on our blog. Here is the step to post a blog:

Fork this repo
Create your blog branch (git checkout -b your-blog)
Write your blog in markdown
Add your blog to _post folder
Add related image to download folder
Commit your changes (git commit -am 'added a blog')
Push to the branch
Create new Pull Request
Done!~

Thanks!

I'm going to close this issue because it had delayed too long.
Please let me know by leaving a reply if you want to write it and I would like to reopen it for you.

@Chlerry There has already a very good start of your blog article, and it will become a great blog post after you refine it and send a pull request!

Kindly ping @Chlerry ,
and Happy New Year 2021!

Kindly ping @Chlerry ,
and Happy New Year 2021!


feat: DLQ as an optional parameter to ApplicationSqsSnsTopicSubscriptionProps

goal

passing DLQ as an optional parameter to ApplicationSqsSnsTopicSubscriptionProps

why?

to create DLQ outside this construct and pass them in. then in the consuming application, can set the inline access policy for both the sqs and corresponding dlq for sns subscriptions

implementation decision

if dlq is passed, use it as dlq for sns
if dlq is not passed, create one.

:tada: This PR is included in version 4.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


wip: build(meson): implementing compile_library

Still a lot of stuff to do.
https://github.com/marzer/tomlplusplus/issues/140#issuecomment-1025954587

Do you want me to offer feedback as you work on the draft, or just wait until you mark it as ready?

Feedback is always welcome, and now should be almost ready (I only need to define TOML_API)

Changes so far:

Added two meson.build files, one used when using toml++ as an header-only lib, one when using it as a compiled library. This is just for readability, because otherwise the main meson.build file would've got too large
Renamed the CMake config files used by meson by appending .meson before .in, since the cmake/ dir contains files shared by the two build systems, with similar names, and it is now easier to recognize who uses what
created a toml.cpp file in a lib directory that is used to compile the implementation of the library
Improved the tomlplusplusConfig.cmake.meson.in file to handle the compiled library

Now failing due to a warning related to type attributes being in the wrong place

Something else that occurs to me; is this also adding support for compiling as static library?

Yep

Now there are only two main issues to fix. The first one is the use of TOML_API in some templated classes, that GCC warns about:
https://github.com/marzer/tomlplusplus/blob/7b6101289fc210ae9c9fb50fb90dc963e1aeb770/include/toml%2B%2B/impl/value_extern.inl#L11-L24
GCC says: "type attributes ignored after type is already defined"
The other one is related to a message sent by ci_single_header_check.py
Potentially missing #undefs:
	#undef TOML_SHARED_LIB
	#undef TOML_SHARED_LIB_BUILDING

Inspecting generate_single_header.py, I see that only "macros that are meant to stay public" should still be defined after the build.
TOML_SHARED_LIB is public; do I have to add it to that ignore_list?
TOML_SHARED_LIB_BUILDING is instead "private", but I would say that it less than private; it has to be defined only while building the shared library, and should never be set by the source files as they have no way of knowing if they are in the middle of the compilation of a shared library or not (kinda like _WIN32, it gets automatically defined based on the compiling environment). How should I handle it? Removing its definition from preprocessor.h would solve the issue, but it seems that you have different preferences so I don't know what should I do :)

Yeah, for our purposes they're both 'public' w.r.t. that script. I'm happy for them to go in the ignore list.

It being set by a global header in the library itself is totally fine in the 'default' case. It's essentially an undocumented config option. I don't mind if it leaks.
...having said that, you also make a reasonable point. Maybe TOML_SHARED_LIB_BUILDING should use #ifdef after all. I would still like TOML_SHARED_LIB to remain a boolean, though, as that better indicates the intent - "are you being used as a shared lib?" "yes/no"

I mean, for this simple case I believe that an #ifdef is just enough and doesn't complicate things, and doesn't expose a macro defined only because shared libraries work in an extraordinarily strange way on Windows... It's not only an implementation detail, it is an implementation detail of a particular platform/process that has little to do with this library in particular, and has no meaning outside of the compilation phase.

Please remove TOML_EXTERN_TEMPLATES here. It was never necessary for the test+example applications before, so it shouldn't be now.

I don't really understand what that define does... But now something is necessary to tell GCC to ignore the TOML_API macro when applied to extern variables. The issue was there before this PR, but TOML_API wasn't defined to anything when using GCC so nothing triggered it. If users were to define TOML_API themselves when using GCC they would've encountered the same issue (the one I described in https://github.com/marzer/tomlplusplus/pull/142#issuecomment-1029141355)

We still have one issue left with symbol visibility: when linking against the compiled libraries, a symbol is missing. Here's the output of LLD:
ld.lld: error: undefined symbol: vtable for toml::v3::table
>>> referenced by main.cpp
>>>               CMakeFiles/linkami.dir/main.cpp.o:(toml::v3::table::table())
>>> referenced by main.cpp
>>>               CMakeFiles/linkami.dir/main.cpp.o:(toml::v3::table::~table())
>>> the vtable symbol may be undefined because the class is missing its key function (see https://lld.llvm.org/missingkeyfunction)

ld.lld: error: undefined symbol: vtable for toml::v3::node
>>> referenced by main.cpp
>>>               CMakeFiles/linkami.dir/main.cpp.o:(toml::v3::node::node())
>>> the vtable symbol may be undefined because the class is missing its key function (see https://lld.llvm.org/missingkeyfunction)
clang: error: linker command failed with exit code 1 (use -v to see invocation)

And the one from gold:
CMakeFiles/linkami.dir/main.cpp.o:main.cpp:function toml::v3::node::node(): error: undefined reference to 'vtable for toml::v3::node'
/usr/bin/ld.gold: the vtable symbol may be undefined because the class is missing its key function
CMakeFiles/linkami.dir/main.cpp.o:main.cpp:function toml::v3::table::table(): error: undefined reference to 'vtable for toml::v3::table'
/usr/bin/ld.gold: the vtable symbol may be undefined because the class is missing its key function
CMakeFiles/linkami.dir/main.cpp.o:main.cpp:function toml::v3::table::~table(): error: undefined reference to 'vtable for toml::v3::table'
/usr/bin/ld.gold: the vtable symbol may be undefined because the class is missing its key function
collect2: error: ld returned 1 exit status

Linking issues do not occur when setting the gnu_symbol_visibility to default (i.e. everything public), so this is almost surely because TOML_API is missing somewhere

I think just unconditionally outlining the destructor is the 'standard' way to fix this, but I'm no longer at a PC to test. Happy to investigate tomorrow.

Ok, I'll give it a shot myself. Have a good night!

Fyi: circle ci didn't run your new job because you didn't add it to the workflow bit at the bottom of the scripr

Relevant docs: https://circleci.com/docs/2.0/workflows/

Sorry @Tachi107 I'm not going to get a chance to help with the linker thing today after all, won't be able to until Sunday or Monday at the earliest.

Don't worry, take all the time you need

@Tachi107 Had a chance to look at it just now. Turns out that yes, outlining some additional member functions did fix some of the linker issues, but another problem was the API annotations themselves needed to be a bit more granular than a one-size-fits-all macro. I've replaced TOML_API with TOML_EXPORTED_CLASS and TOML_EXPORTED_FUNCTION (the old one will still work if the two new ones aren't defined so existing users shouldn't be impacted).
Also needed to make some changes to the examples because they used a few inline library config options that caused linker failures with the compiled lib version, but that was pretty simple.
You can take it from here ^_^

Awesome! I'll check that everything works a bit more before marking the PR as ready

Ah, I probably should have removed the temp CI machinery you'd set up for github actions while I was there; looks like it's failing because it doesn't have locales initialized. CircleCI seems happy with the new compiled lib now though.

Also, apologies, my API annotation changes make your PR look absolutely enormous now lmao

I'll remove it later, as I also want to check that everything works on Windows (and I don't a pc with that OS here)

You know what though, if github actions turns out to be alright I would consider migrating to it.

I've been using GH Actions for a while and I can say that they are fine. Their default images are extremely bloated and can cause issues like conflicting libraries/dependencies, but you can always run your jobs in clean containers and they work really well

When only building the DLL on Windows everything is fine, but when also building the tests it seems that Meson's "symbolextractor" fails... Are you able to reproduce this on your machine?

When only building the DLL on Windows everything is fine, but when also building the tests it seems that Meson's "symbolextractor" fails... Are you able to reproduce this on your machine?

Can't test it at the moment, but happy to give it a try later/tomorrow

Alright I've had some time to test it locally on my windows machine, and indeed using the compile_library option in meson was giving me all sorts of grief. Should be fixed now. The problem was two-fold:

my new granular export settings weren't granular enough, and MSVC wasn't exporting the vtables properly
the test script is basically a hard-coded compiler matrix, which you would normally do at the CI level, but since the lib has until now been exclusively header-only it was easy enough to just do it in meson. Meant the test code itself was written with this in mind. After some tweaks to the tests meson.build and simplifying some of the C++ test headers it compiled and ran OK

Also I realized that many of the options being put into devel_args (and thus not being passed onto the lib compilation were already covered by meson project-level options (e.g. pedantic) or were otherwise necessary to avoid overly-pendantic warnings and are otherwise harmless, so i've moved most of them back into a shared universal_args that is used by all the 'devel' projects and the lib. Same goes for the top-level overrides array, which is now being correctly passed through to the lib.

Hmmn, I note now that the windows job is still failing on the CI, but it's using clang, and hasn't really emitted any meaningful diagnostic output. I have no idea to debug that, though if a CI step is going to test windows, it should probably do so using MSVC, which is what I tested it locally with (and what most windows users will be using).

Alright I've had some time to test it locally on my windows machine, and indeed using the compile_library option in meson was giving me all sorts of grief. Should be fixed now. The problem was two-fold:

my new granular export settings weren't granular enough, and MSVC wasn't exporting the vtables properly

the test script is basically a hard-coded compiler matrix, which you would normally do at the CI level, but since the lib has until now been exclusively header-only it was easy enough to just do it in meson. Meant the test code itself was written with this in mind. After some tweaks to the tests meson.build and simplifying some of the C++ test headers it compiled and ran OK

Nice :)

Also I realized that many of the options being put into devel_args (and thus not being passed onto the lib compilation) were already covered by meson project-level options (e.g. pedantic) or otherwise harmless (disabled warnings etc.), so i've moved most of them back into a shared universal_args that is used by all the 'devel' projects and the lib. Same goes for the top-level overrides array, which is now being correctly passed through to the lib.

See my previous comment (https://github.com/marzer/tomlplusplus/pull/142#discussion_r800189394), but I'd also like to give my personal opinion here. Playing around with flags is nice when developing stuff, but I've found out that when you are compiling a binary that has to be shipped onto user's machines it is best to leave things as close as the defaults as possible. Because some flags are maybe not so well tested, or because you can never know what flags will be applied downstream (for example, Debian passes a lot of hardening flags to the compiler) and conflicts may arise.

Hmmn, I note now that the windows job is still failing on the github actions CI, but it's using clang, and hasn't really emitted any meaningful diagnostic output. I have no idea how to debug that, though if a CI step is going to test windows, it should probably do so using MSVC, which is what I tested it locally with (and what most windows users will be using). I don't think explicitly supporting building as a DLL using clang on windows is a worthy venture.

See, that's the bloat I was talking about...  I could look into using a container also for the Windows job.

(not to say I don't want people to use that specific combo, but that it is more niche and not really worth the support burden)

I'm not sure how niche it is really, as Clang outputs really performant code compared to MSVC. Chrome is compiled with Clang on Windows, for example.

Edit: Same goes for cygwin, really. If someone hates themselves enough to still be using that dumpster-fire when WSL is right there, then the header-only version should suffice smiling_face_with_tear

Yeah I don't see why you would want to use that over WSL

See my previous comment (https://github.com/marzer/tomlplusplus/pull/142#discussion_r800189394), but I'd also like to give my personal opinion here. Playing around with flags is nice when developing stuff, but I've found out that when you are compiling a binary that has to be shipped onto user's machines it is best to leave things as close as the defaults as possible.

Well yes, I get that. I never intended to pass that stuff on to users. I want the extra 'devel' flags etc. to be available to me when building the lib, but not on by default (instead of just unconditionally compiling the lib with default flags and completely ignoring my preferences, which is what you were doing). I have a few options for development/testing purposes in meson_options.txt, so the compiled version of the lib should respect them just as the tests etc. do already.

I'm not sure how niche it is really, as Clang outputs really performant code compared to MSVC. Chrome is compiled with Clang on Windows, for example.

That is a poor example because that is in fact a very niche build configuration. Google-tech is notoriously 'NIH' when it comes to their toolchain. It's not at all representative of the general case. Besides, I have zero personal desire to offer support for that use-case if/when it breaks - unless you're gonna stick around as maintainer and debugger for it basically forever, it's not useful to lock-in now. As said, people with those needs can use the library in header-only mode (which, in terms of build flexibility, is strictly superior to anything we'll ever do here in this PR).

I never intended to pass that stuff on to users. I want the extra 'devel' flags etc. to be available to me when testing the compiled version of the lib, but not on by default (instead of just unconditionally compiling the lib with default flags and completely ignoring my preferences, which is what you were doing, and what I attempted to correct). I have a few options for development/testing purposes in meson_options.txt, so the compiled version of the lib should respect them just as the tests etc. do already.

Ok, we could:

Add an option to enable those flags
Only pass those flags to the compiled library without making them public (giving this a try right now)

That is a poor example because that is in fact a very niche, very highly-specialized build configuration. Google-tech is notoriously 'NIH' when it comes to their toolchain. It's not at all representative of the general case.

Yeah that's a bad example, and I have no doubts that MSVC is more popular thanks to its historical integration with Visual Studio. But I seem to remember that the LLVM toolchain has been integrated in Visual Studio as well, and that helps with adoption; at least I used it when I was on Windows.
In the end I honestly don't care about it, I was mostly interested in this PR because I wanted to package this great library for Debian as there are not many high-quality alternatives there, but I'm really curious to know why it fails, so I'll open a Windows VM and test stuff there :)
One last thing. I'll have an important exam in a few days, so I'll probably stop working on this until the end of next week. Sorry!

Why are only 12 tests ran when compile_library is true?

Because this:

the test script is basically a hard-coded compiler matrix, which you would normally do at the CI level, but since the lib has until now been exclusively header-only it was easy enough to just do it in meson. Meant the test code itself was written with this in mind. After some tweaks to the tests meson.build and simplifying some of the C++ test headers it compiled and ran OK

For the compiled library it turns off the permutations based on -fast-math, -std=c++XX, etc., and just uses the 'default' so the tests/examples match the compiled lib
Have a look inside tests/meson.build if you want to see where this happens. There's a few nested loops to handle the different permutations.

Investigated a bit during a break, and I found out that the Clang Windows build fails because of LTO. I guess Windows' link.exe can't handle Clang's LTO format

When only building the DLL on Windows everything is fine, but when also building the tests it seems that Meson's "symbolextractor" fails... Are you able to reproduce this on your machine?

This is a pip bug: https://github.com/mesonbuild/meson/issues/9955
Ultimately the fault of https://github.com/pypa/pip/issues/10875
Downgrade pip and meson will have a valid sys.stderr again.

Thanks, I had no idea what was going on :)

i'm loosing all hope
but maybe something now works
or maybe not

something is working

good old CI lmao

The only thing worse than fighting with CI is fighting with production systems because you didn't have CI...

@marzer, I managed to get the Windows container CI working :D
It's a mess, and I don't know it using it is really worth it compared to the bloated GitHub Actions images, but it is there if you want

I think this is almost ready. If you're ok with the changes I could edit the commit history and keep only a few meaningful commits (like "depreate TOML_API", "add compile_library option", "switch to GitHub Actions", etc).
Normally I would squash everything in one single commit, but since this PR is so huge I believe that having four or five different commits in the master branch would be better.

Yeah, sure, that sounds like a good idea.

@marzer mostly done (I'm pinging you just in case you're not subscribed to this thread).
I only need to move the generate_dox and deploy_dox jobs to GitHub Actions, but I don't fully understand how they work, or better, what they do.
If what they need to do is to build the html files and deploy them to GitHub Pages then I could add a job similar to the one I added in pistacheio/pistache/.github/workflows/pistache.io.yaml

I've also updated the badge in the Readme to point to the GitHub CI job, and now I really think that this is complete. When merging, be careful not to squash the commits :)

Thanks for all your work on this!


Carbon component react has List view component ? Is there any support for ListView ?

Summary
Relevant information

Hi Asudoh,
Please find the screenshot for your reference.

I need to add List view in react component.

The closest seems <RadioTile> or <StructuredList>. If you have more detailed use case (e.g. what kind of feature in what application), our designers may provide a better suggestion. Hope it helps!

I am using TileGroup with RadioTitle component. Now my demo sample like this.

I have below warning message and how to resolve this.

Please refer my code for your reference.

I want if we click the item the modal window will be open. That window contains list item details.
Please share your suggestion on this.
Thanks in advance.

The console warning seems the same one as #1300. As shown in your screenshot of code, you can use onChange() to detect click (new selection) on the tile item. Hope it helps!

Hi @saguaaru! Going to close this for now since it seems like this is a support question at this point. Feel free to reach out in our #carbon-react channel on Slack, or if we have an issue feel free to comment here and we can re-open 😄 Cheers!


1.17.0 broke compatibility with ruby <2.7

Subject of the issue
The addition of the activesupport dependency in 1.17.0 (https://github.com/ruby-git/ruby-git/pull/645) broke us (via danger v8.4.*):
ERROR:  Error installing danger:
	The last version of activesupport (>= 4.0.0) to support your Ruby & RubyGems was <IP_ADDRESS>. Try installing it with `gem install activesupport -v <IP_ADDRESS>` and then running the current command again
	activesupport requires Ruby version >= 2.7.0. The current ruby version is <IP_ADDRESS>.

This is probably desirable in a sense (see https://github.com/ruby-git/ruby-git/issues/550), but it seems like it would merit a major version bump?
Your environment

version of ruby: 2.6

Steps to reproduce
Try to install danger v8.6 using Ruby 2.6, which has a runtime dependency on git ~> 1.7.
Expected behaviour
Success
Actual behaviour
Failure

I will revert the change which brought in ActiveSupport and tag it for the next major release which will also upgrade the minimum dependencies for Ruby and git. In the meantime, can you pin yourself to 1.16.0?

In the meantime, can you pin yourself to 1.16.0?

We actually just upgraded to ruby 2.7, was not a big deal for our use case (running Danger in CI). Just thought I would flag the semver implications since the breakage was unexpected (and could potentially affect others in more serious ways).

Fixed in v1.7.1
The Ruby dependency change was inadvertent, but something I plan on doing very soon anyway.
FWIW, since Ruby MRI 2.7.x will not receive updates after March 30th, 2023, I was planning on bumping the dependency of this gem to 3.0.x. I am curious on your thoughts of that.

FWIW, since Ruby MRI 2.7.x will not receive updates after March 30th, 2023, I was planning on bumping the dependency of this gem to 3.0.x. I am curious on your thoughts of that.

We only rely on this gem via Danger, so I think that wouldn't be an issue for us (a quick try with ruby 3.0 or 3.2 seems to cause no issues).


Debug with standard trigger does not run

Debug with standard trigger does not run

No bug found,. sorry


ExperimentalMarkdownSyntaxTextSplitter missing in init

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
In the __init__ file in langchain_text_splitters, the ExperimentalMarkdownSyntaxTextSplitter should be added like so:
from langchain_text_splitters.markdown import (
    ExperimentalMarkdownSyntaxTextSplitter,
    HeaderType,
    LineType,
    MarkdownHeaderTextSplitter,
    MarkdownTextSplitter,
)

Error Message and Stack Trace (if applicable)
from langchain_text_splitters import ExperimentalMarkdownSyntaxTextSplitter
ImportError: cannot import name 'ExperimentalMarkdownSyntaxTextSplitter' from 'langchain_text_splitters'
Description
I'm trying to import ExperimentalMarkdownSyntaxTextSplitter
System Info
langchain==0.2.16
langchain-community==0.2.16
langchain-core==0.2.38
langchain-openai==0.1.23
langchain-text-splitters==0.2.4
langchainhub==0.1.21
I'm on Linux, Debian
python version 3.11

try to fix it in #26703


WIP: Vtol cleanup

This is some cleanup work, especially for the tiltrotor code. Changes include:

removed the process_mc_data() and process_fw_data() calls. We already have the update_mc_state() function calls so we do not need the former ones.

the method of how to change the max pwm for the firefly6 rear engines was messy and the function names were not good. I tried to structure it a bit more and gave some better function names.

there is now one function call to fill_actuator_outputs. The different modes are treated inside the function

general comments cleanup

@SimonWilks @AndreasAntener Changes to the standard vtol code are minimal but still we should test it.

@LorenzMeier @SimonWilks @AndreasAntener
If we all agree on the general structure of the vtol code (after we had our talk) I would like to bench test and flight test the FireFly6 with this code. The changes to the standard code are minimal, so I don't expect too much drama there.

I must have been drunk :-)

@LorenzMeier @SimonWilks @AndreasAntener FYI: This is bench tested with the FireFly6. Simon will bench test with the pusher VTOL later. I also have a team which will test this for the tailsitter this week.

@tumbili @LorenzMeier bench tests on the Fun Cub Quad VTOL completed without issue.

@LorenzMeier @SimonWilks @AndreasAntener We flight tested this today with the FireFly.
We were able to do very nice and reliable transitions with no user interaction. There are minor things I will still look to improve but this is already very good.

If this now represents 1:1 what you've flown then please go ahead and merge.


Line edits to 05.3

I also note a few broken links but am not sure what the correct URLs would be:
http://hdle.handle.net/11134/120002:246
http://hhc2.hplct.org/boyd_hinds_pdf.pdf
http://hhc2.hplct.org/boyd_hinds.html

Thanks for spotting broken links. One was my typo, and the others were created when Hartford History Center switched to a new archival repository platform.


Minor GUI issues on mobile

Summary:
Minor GUI issues on mobile
Environment
Platform: Android
Operating System: Android 10
Browser:

Page:
http://anojs.com/our-team
Description
Text overlapping and the ability to scroll to the right
Steps to reproduce

Go to http://anojs.com/our-team on a mobile device
Scroll to the right

Expected result
The page stays static and doesn't allow for scrolling in any direction except for up and down
Text doesn't overlap
Actual result
The page allows for scrolling left and right
Text overlapping
Screenshot

seems fine on my end

Reproducible on iPhone 11 + Google Chrome


This is a test PR

@jrogoiyo : Thanks for your contribution! The author, @MikeRayMSFT, has been notified to review your proposed change.

Hi @JoeRogoiyoMSFT , thank you for participating and contributing :) Closing this PR as it was part of a lab exercise. Thanks again!


[WIP] Feature/4 socks5 proxy

This PR creates a reverse proxy using socks5 as the transport layer. It replaces the host to make sure that the destination loadbalancer / ingress works correctly.
It's WIP missing unit and integration tests.

Yes.  This is more a proxy thing. It's using the roundTripper
https://golang.org/pkg/net/http/httputil/
Here is the piece:
// The transport used to perform proxy requests.
// If nil, http.DefaultTransport is used.
Transport http https://golang.org/pkg/net/http/.RoundTripper
https://golang.org/pkg/net/http/#RoundTripper
On Mon, Feb 22, 2021, 17:53 pfracarolli<EMAIL_ADDRESS>wrote:

@pfracarolli commented on this pull request.
In cmd/main.go
https://github.com/ciandt/juggler/pull/5#discussion_r580582458:

@@ -0,0 +1,29 @@
+package main

+import (

"flag"

"com.ciandt.juggler/internal"
+)

+func main() {
+

var outbound = flag.String("outbound", "localhost:5000", "Outbound destination server")

It's mandatory to add a transport layer when proxying the TCP/UDP. If you
don't do that the net package is going to add a default transport.
You mean you cannot create "raw" socket connections in Go? You need to
actually specify a layer 5 protocol or it will default to something?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ciandt/juggler/pull/5#discussion_r580582458, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACEPPIL7HCOWKHP2MWUZHMDTAK74NANCNFSM4X7QDYHA
.


Error when using other 3D data

hi humanpose1
Thank you a lot for your update.
It's running with your data but when I try to run with my 3D point loud data and use your model :MS_SVCONV_2cm_X2_3head_3dm.pt
I have some problems like that:
INFO - 2021-06-15 11:01:11,212 - model_checkpoint - Loading checkpoint from models/MS_SVCONV_2cm_X2_3head_3dm.pt
INFO - 2021-06-15 11:01:11,566 - modelfactory - The config will be used to build the model
INFO - 2021-06-15 11:01:11,750 - model_checkpoint - Available weights : ['latest', 'loss', 'hit_ratio', 'feat_match_ratio', 'trans_error', 'rot_error', 'rre', 'rte', 'sr_err']
INFO - 2021-06-15 11:01:11,751 - model_checkpoint - Model loaded from MS_SVCONV_2cm_X2_3head_3dm.pt:latest
invalid syntax (, line 1)
[Open3D WARNING] Read PCD failed: unable to open file: Dt/4sm.pcd0;m

RuntimeError                              Traceback (most recent call last)
 in ()
21 model = PretainedRegistry.from_file(pcd_model[choice_model], mock_property={})
22
---> 23 data_s = pcd_DAchoice_model
24 data_t = pcd_DAchoice_model
25
3 frames
/usr/local/lib/python3.7/dist-packages/torch_geometric/transforms/compose.py in call(self, data)
12     def call(self, data):
13         for t in self.transforms:
---> 14             data = t(data)
15         return data
16
/usr/local/lib/python3.7/dist-packages/torch_points3d/core/data_transform/grid_transform.py in call(self, data)
133             data = [self._process(d) for d in data]
134         else:
--> 135             data = self._process(data)
136         return data
137
/usr/local/lib/python3.7/dist-packages/torch_points3d/core/data_transform/grid_transform.py in _process(self, data)
119             cluster = grid_cluster(coords, torch.tensor([1, 1, 1]))
120         else:
--> 121             cluster = voxel_grid(coords, data.batch, 1)
122         cluster, unique_pos_indices = consecutive_cluster(cluster)
123
/usr/local/lib/python3.7/dist-packages/torch_geometric/nn/pool/voxel_grid.py in voxel_grid(pos, batch, size, start, end)
53         end = torch.tensor(end, dtype=pos.dtype, device=pos.device)
54
---> 55     return grid_cluster(pos, size, start, end)
RuntimeError: The following operation failed in the TorchScript interpreter.
Traceback of TorchScript (most recent call last):
File "/usr/local/lib/python3.7/dist-packages/torch_cluster/grid.py", line 32, in grid_cluster
cluster = grid_cluster(pos, size)
"""
return torch.ops.torch_cluster.grid(pos, size, start, end)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~ <--- HERE
RuntimeError: cannot reshape tensor of 0 elements into shape [0, -1] because the unspecified dimension size -1 can be any value and is ambiguous.
Could you have some suggests ? Thank you so much

The problem comes from the GridSampling3D transform. It means that probably the shape of the tensor (contained in the attribute pos of your object data) is not correct.
The code should look like this:
pos = read_point_cloud(...) #pos is of shape N x 3
data = Data(pos=xpos batch=torch.zeros(len(xyz)).long
data = transform(data)
model.set_input(data, "cuda")
output = model.forward()

please can you check the size of pos in your case ?

Hi. Thank you for your help..
I have solved this problem with my data (  blue one is a simulation and  yellow one  is a real point cloud ).

But both of them are too big (4 million points) so google colab could not enough RAM to run in  registration part  with error WARNING WARNING:root:kernel b48211a4-a3e6-44f4-8082-89f69da39d21 restarted.
So I think I will try with other smaller data or use local computer.
Again, thank you so much for your support

Thanks for testing my code !


Tabulate issues

I've attached a .pdf with some issues I've encountered while using .tabulate()
Tabulate issues.pdf

I've just submitted a pull request that fixes the ordering of the outcomes when normalize=True. I think that everything else is working as intended:

Python doesn't allow you to include unnamed arguments after a named argument to a function.
For the xy_pairs example, the outcomes are actually tuples, i.e., [(0,0), (0,1), (1,0), (1,1)], not lists. Although tuples behave like lists in many ways, they have the benefit of being hashable, which allows them to be put into Python dicts.


Delete https://beta.huc.knaw.nl

Turns out there is actually a lot of useful information here in terms of publication lists, tools, repositories..


use onnx model to inference

I can provide the onnx model. Have you planned to support onnx models with yolov3 currently?
it's original model is yolov3.weights, using python API convert it to yolov3-608.onnx,then convert onnx to yolo-608.trt. Yolov3.weights is downloaded from darknet official website.
https://drive.google.com/drive/folders/1fRcxY5YgEQ8DUmS1tEdDKxL45SsKkvFh?usp=sharing

As I know, recently in TensorRT 6.0 the nvidia official has already provided a sample that running the onnx-yolov3 model. But  it seems written in python?

thank you for your reply . i have solved my problem

@JensenHJS in this repo they use a YOLO last layer (not the three convolution output layers). Were you able to get that into your onnx model?

onnx doesn't support yolo layer. the output of trt file go through yolo layer，it is the final output.


Override Console Logging

This would effectively resolve #34.

Note: The warnings produced by Node during build or some other call to console.log before AppExpress takes over will still show the warning mentioned in the issue.

Tested against an RC version, works fine!

A version bump would be good too!

Live on NPM. Can be merged!


Gtag logs events in Console, but nothing gets fired in Network

Hi. Using this module, events get fired and logged but zero calls in Network. Am I doing something wrong ?
   // Method
    google() {
      this.$gtag("config", "UA-XXXXXXX", {
        user_id: this.userAnalyticsID,
      });

      this.$gtag("event", "your_event", {
        event_category: "welcome_video",
        event_label: "[play icon]",
      });
    },

// Nuxt Config
  "google-gtag": {
    id: "UA-XXXXXXX"
    config: {
      anonymize_ip: true,
      send_page_view: true,
      linker: {
        domains: ["baseUrl"],
      },
    },
    debug: true,
    disableAutoPageTrack: false,
  },

These are logs after I fired events

You are probably on localhost respectively on your dev environment via npm run dev?
This module does not track in dev mode by default. You need to explicitly set the debug option, see per default..
In dev mode the module falls back to console logging, as seen in your screenshot above.


No documentation about accessing Refs using the functional components

ES7 is picking up numbers and people are moving to functional components none of the less but there is no proper reference material to them

Thanks for the feedback!
Could you explain where you expected to find material for refs on function components and what should be explained for function components specifically?

Thanks for the feedback!
Could you explain where you expected to find material for refs on function components and what should be explained for function components specifically?

I went on to this link: https://reactjs.org/docs/refs-and-the-dom.html
I expected it to have a mention of the fact that to use refs in functional component, you need to do it by using the UseRef hook and also have the boilerplate code to do the same

I went on to this link: https://reactjs.org/docs/refs-and-the-dom.html
I expected it to have a mention of the fact that to use refs in functional component, you need to do it by using the UseRef hook and also have the boilerplate code to do the same

If possible, can I contribute to resolving the issue. I am a novice developer and this contribution would mean a lot :)

If possible, can I contribute to resolving the issue. I am a novice developer and this contribution would mean a lot :)

I went on to this link: reactjs.org/docs/refs-and-the-dom.html
I expected it to have a mention of the fact that to use refs in functional component, you need to do it by using the UseRef hook and also have the boilerplate code to do the same

Is this not what https://reactjs.org/docs/refs-and-the-dom.html#refs-and-function-components does?
If you're saying it should come before class components then this'll be most likely fixed with https://github.com/reactjs/reactjs.org/issues/3308

I went on to this link: reactjs.org/docs/refs-and-the-dom.html
I expected it to have a mention of the fact that to use refs in functional component, you need to do it by using the UseRef hook and also have the boilerplate code to do the same

Is this not what https://reactjs.org/docs/refs-and-the-dom.html#refs-and-function-components does?
If you're saying it should come before class components then this'll be most likely fixed with https://github.com/reactjs/reactjs.org/issues/3308

I meant it to be in the way it has been given in this reference : https://medium.com/javascript-in-plain-english/react-refs-both-class-and-functional-components-76b7bce487b8

I meant it to be in the way it has been given in this reference : https://medium.com/javascript-in-plain-english/react-refs-both-class-and-functional-components-76b7bce487b8


Remove autotune mode tests from PR checks

Autotune mode tests fail as the code hasn't been updated in a long time and needs a lot of changes for it to be fixed. We need to disable the PR checks until this can be fixed

Closing this issue, as the PR https://github.com/kruize/autotune/pull/1357 is merged.


Revival batch_matmul for backward compatibility

This PR provides compatibility about batch_matmul.
batch_matmul removed by #2426. But, we can provides it easily.

I think this behaves differently from old batch_matmul. The old batch_matmul supports 3D x 2D and 2D x 3D but the new matmul doesn't.

@okuta have restored old unit tests (rewriting them with testing.parameterize). It seems we did not we have unit tests for 2D x 3D and 3D x 2D cases.

It seems we didn't have tests for 3D x 2D and 2D x 3D, but batch_matmul actually supported them as documented. You can confirm it in https://github.com/chainer/chainer/issues/1765.
The tests in this PR are for numpy_like_matmul, not for batch_matmul. batch_matmul had tests for batch vector x vector (inner or outer) product: https://github.com/chainer/chainer/blob/895ebb785f9ab89e54acb5bff77f1c0324b4dceb/tests/chainer_tests/functions_tests/math_tests/test_matmul.py#L206-L233

Thank you for your information.
I fixed test and implementation.

I fixed.

LGTM

LGTM


Changes in Java and F#-Versions of a kata cannot be republished

Changes in Java and F#-Versions of a kata cannot be republished
Always timeout. C#, C++ and JavaScript without any problems.

now it works.... but republishing java leads often to a timeout


A new version on crates.io

Dear maintainers,
Thank you for creating this awesome crate, it really is a pleasure to work with.
But there is one thing that would working with this crate even more pleasant, and that is releasing a new version on crates.io
Currently some features like the random implementation are not released yet due to this, and that is unfortunate, since it means that your awesome new work is only usable by setting the git link or downloading it.
So can you please release a new version on crates.io?
If I can help with this in any means (testing the examples on my 767ZI board, or submit a PR), please let me know.
Martijn

Hey @dutchmartin, thanks for opening this issue. Looks like I don't have the power to make new releases. @mvertescher, can you take care of this?

By the way, a few of the other HALs have added their stm32-rs org team to the crates.io owners, so that anyone on the team can publish to crates.io -- there's also an stm32f7 team (with just @hannobraun and @mvertescher), so potentially that could be added to make this easier in the future: cargo owner --add github:stm32-rs:stm32f7.

Awesome, that sounds great @adamgreig. I've updated the owners with the github:stm32-rs:stm32f7 team so @hannobraun can deploy in the future.
Yeah, it's been a while since the last release. I've just pushed v0.3.0 to crates.io.
Feel free to open any additional issues for bugs you may find @dutchmartin, that'd be very helpful :)

Thank you for your very quick response!


feat: A new FunctionRunner Processor to give a much simplified UX

New UX:
A much simplified UI
User only need to implement the FunctionRunner interface Run method.

Add an interface FunctionRunner and a  new ResourceListProcessor runnerProcessor. AsMain can accept the struct type implementing FunctionRunner.
the functionConfig value (either custom KRM resource or ConfigMap) are parsed by the new processor runnerProcessor. So users don't need to manually parse (e.g. As) functionConfig or default ConfigMap. This is from the best practice in existing function set-namespace, set-annotations, set-labels that configMap is mainly used when users only need one to one string mapping config.
Add a Context to let users easily add Result wherever they need to, and terminate the evaluation earlier.
Update doc.go and add e2e example to show the new UX. See example/example_runner_processor (TODO, use .expected/diff.patch format)

The set-labels code is as simple as
var _ fn.FunctionRunner = &SetLabels{}

type SetLabels struct {
	Labels map[string]string `json:"labels,omitempty"`
}

func (r *SetLabels) Run(ctx *fn.Context, _ *fn.KubeObject, items []*fn.KubeObject) {
	for _, o := range items {
		for k, newLabel := range r.Labels {
			o.SetLabel(k, newLabel)
		}
		ctx.ResultInfo(fmt.Sprintf("update %v labels %v", o.ShortString(), r.Labels), o)
	}
}

func main() {
	fn.AsMain(&SetLabels{})
}

SDK cleanup:

merge SubObject to KubeObject since they share most of the methods. merge unittests subobject_test.go to kubeobject_test.go
Change some SDK errors to private, because they are all handled inside the SDK.
have more cleanup, will do in follow up PRs.

This looks pretty good to me.
Few suggestions about naming :)

name the interface as Runner, so it will read as fn.Runner and it is consistent with Runner to implement Run() method.
Avoid using verb form when naming struct SetLabels, instead use noun: Labeler

so the code will read as follows:

var _ fn.Runner = &Labeler{}

type Labeler struct {
   Labels map[string]string{}
}

func (l *Labeler) Run(..............) {

}

This looks pretty good to me.
Few suggestions about naming :)

name the interface as Runner, so it will read as fn.Runner and it is consistent with Runner to implement Run() method.
Avoid using verb form when naming struct SetLabels, instead use noun: Labeler

so the code will read as follows:
var _ fn.Runner = &Labeler{}

type Labeler struct {
   Labels map[string]string{}
}

func (l *Labeler) Run(..............) {

}

Renamed FunctionRunner to Runner.
I may have to keep the SetLabel name as it is, because this name needs to be aligned with the FunctionConfig Kind
For example set-labels should have the input ResourceList as
apiVersion: config.kubernetes.io/v1
kind: ResourceList
functionConfig:
  functionConfig:
  apiVersion: fn.kpt.dev/v1alpha1
  kind: SetLabels
  metadata:
    name: setlabel-fn-config


conmon-rs always opens a namespace, even if it won't be used

after https://github.com/containers/conmon-rs/pull/1064, conmon-rs always opens a namespace, even if the pod needs a container level namespace. This isn't a behavior problem, but does needlessly add extra mounts and will cause there to be more open files then needed.

@haircommander would it make sense to extend the CLI/Cap'n Proto interface in the same way we have in pinns, for example:
conmonrs pause --ipc  # Unshare to a new IPC namespace
conmonrs pause --ipc=host # Unshare to the host IPC namespace
conmonrs pause # Skip unsharing the IPC namespace

also having a target for posterity would be useful (where we just bind mount a path of a namespace)

I started working on this but didn't finish. I will try to finish next week


Not Compatible with Jamf Connect

Since this uses the authdatabase and macOS only supports one authdatabase at a time this wouldn't work with Jamf Connect.

Sorry that’s not correct. The authorization database can have as many mechanisms as required. Whether jamf connect’s installer does silly things or not I can’t say, but the installer for this project modifies the database in a sane way.

@grahamgilbert I'm happy to say I was wrong. I tested this workflow with a Jamf Connect enabled device and worked like a charm. Thanks for the good work on this.


[syntax parser] Fix another assertion hit related to invalid composition type

Found by the stress tester.

@swift-ci smoke test and merge

This causes a regression on Windows!   Seems that the compiler is crashing on Windows :-(.

I seriously doubt that these changes introduced the crash. Could you file a JIRA with details of the crash ?

I seriously doubt that these changes introduced the crash. Could you file a JIRA with details of the crash ?

To clarify, if we revert this and the crash goes away, all we'll have accomplished is hide the underlying crash. We might as well XFAIL it for Windows in such a case.


Span and trace ids missing when an exception is thrown

We have a logging service that accepts logs in JSON format. When a mandatory field is missing in the JSON, it throws an exception lacking any trace or span id. See below, where some of the items have been obfuscated to protect IP.
2017-07-21 14:33:50.119 DEBUG [log,,,] 46977 --- [nio-9000-exec-3] o.s.c.sleuth.instrument.web.TraceFilter  : Received a request to uri [/log/service] that should not be sampled [true]
2017-07-21 14:33:50.119 DEBUG [log,,,] 46977 --- [nio-9000-exec-3] o.s.c.sleuth.instrument.web.TraceFilter  : Found a parent span [Trace: 0e3a123c649bec91, Span: e404f98fb3fd1b78, Parent: 0e3a123c649bec91, exportable:false] in the request
2017-07-21 14:33:50.120 DEBUG [log,0e3a123c649bec91,e404f98fb3fd1b78,false] 46977 --- [nio-9000-exec-3] o.s.c.sleuth.instrument.web.TraceFilter  : Parent span is [Trace: 0e3a123c649bec91, Span: e404f98fb3fd1b78, Parent: 0e3a123c649bec91, exportable:false]
2017-07-21 14:33:50.122 DEBUG [log,0e3a123c649bec91,e404f98fb3fd1b78,false] 46977 --- [nio-9000-exec-3] o.s.c.s.i.web.TraceHandlerInterceptor    : Handling span [Trace: 0e3a123c649bec91, Span: e404f98fb3fd1b78, Parent: 0e3a123c649bec91, exportable:false]
2017-07-21 14:33:50.122 DEBUG [log,0e3a123c649bec91,e404f98fb3fd1b78,false] 46977 --- [nio-9000-exec-3] o.s.c.s.i.web.TraceHandlerInterceptor    : Adding a method tag with value [persistLogs] to a span [Trace: 0e3a123c649bec91, Span: e404f98fb3fd1b78, Parent: 0e3a123c649bec91, exportable:false]
2017-07-21 14:33:50.122 DEBUG [log,0e3a123c649bec91,e404f98fb3fd1b78,false] 46977 --- [nio-9000-exec-3] o.s.c.s.i.web.TraceHandlerInterceptor    : Adding a class tag with value [LogResource] to a span [Trace: 0e3a123c649bec91, Span: e404f98fb3fd1b78, Parent: 0e3a123c649bec91, exportable:false]
2017-07-21 14:33:50.123 DEBUG [log,0e3a123c649bec91,e404f98fb3fd1b78,false] 46977 --- [nio-9000-exec-3] com.mycompany.logging.LogService  : Creating log entry: LogItem(...).
2017-07-21 14:33:50.127 DEBUG [log,0e3a123c649bec91,e404f98fb3fd1b78,false] 46977 --- [nio-9000-exec-3] o.s.c.s.i.web.TraceHandlerInterceptor    : Adding an error tag [Mandatory field may not be null] to span [Trace: 0e3a123c649bec91, Span: e404f98fb3fd1b78, Parent: 0e3a123c649bec91, exportable:false]
2017-07-21 14:33:50.129 DEBUG [log,0e3a123c649bec91,e404f98fb3fd1b78,false] 46977 --- [nio-9000-exec-3] o.s.c.sleuth.instrument.web.TraceFilter  : Trying to send the parent span [Trace: 0e3a123c649bec91, Span: e404f98fb3fd1b78, Parent: 0e3a123c649bec91, exportable:false] to Zipkin
2017-07-21 14:33:50.129 DEBUG [log,0e3a123c649bec91,e404f98fb3fd1b78,false] 46977 --- [nio-9000-exec-3] o.s.c.sleuth.instrument.web.TraceFilter  : Closing the span [Trace: 0e3a123c649bec91, Span: e404f98fb3fd1b78, Parent: 0e3a123c649bec91, exportable:false] since the response was successful
2017-07-21 14:33:50.132 ERROR [log,,,] 46977 --- [nio-9000-exec-3] o.a.c.c.C.[.[.[/].[dispatcherServlet]    : Servlet.service() for servlet [dispatcherServlet] in context with path [] threw exception [Request processing failed; nested exception is java.lang.IllegalArgumentException: Mandatory field may not be null] with root cause
java.lang.IllegalArgumentException: Mandatory field may not be null
	at org.apache.commons.lang.Validate.notNull(Validate.java:192)
        // elided
2017-07-21 14:33:50.138 DEBUG [log,0e3a123c649bec91,e404f98fb3fd1b78,false] 46977 --- [nio-9000-exec-3] o.s.c.sleuth.instrument.web.TraceFilter  : There has already been a span in the request [Trace: 0e3a123c649bec91, Span: e404f98fb3fd1b78, Parent: 0e3a123c649bec91, exportable:false]
2017-07-21 14:33:50.139 DEBUG [log,0e3a123c649bec91,e404f98fb3fd1b78,false] 46977 --- [nio-9000-exec-3] o.s.c.sleuth.instrument.web.TraceFilter  : Received a request to uri [/error] that should not be sampled [true]
2017-07-21 14:33:50.139 DEBUG [log,0e3a123c649bec91,e404f98fb3fd1b78,false] 46977 --- [nio-9000-exec-3] o.s.c.sleuth.instrument.web.TraceFilter  : The span [Trace: 0e3a123c649bec91, Span: e404f98fb3fd1b78, Parent: 0e3a123c649bec91, exportable:false] was already detached once and we're processing an error
2017-07-21 14:33:50.141 DEBUG [log,0e3a123c649bec91,e404f98fb3fd1b78,false] 46977 --- [nio-9000-exec-3] o.s.c.s.i.web.TraceHandlerInterceptor    : Handling span [Trace: 0e3a123c649bec91, Span: e404f98fb3fd1b78, Parent: 0e3a123c649bec91, exportable:false]
2017-07-21 14:33:50.141 DEBUG [log,0e3a123c649bec91,e404f98fb3fd1b78,false] 46977 --- [nio-9000-exec-3] o.s.c.s.i.web.TraceHandlerInterceptor    : Adding a method tag with value [error] to a span [Trace: 0e3a123c649bec91, Span: e404f98fb3fd1b78, Parent: 0e3a123c649bec91, exportable:false]
2017-07-21 14:33:50.141 DEBUG [log,0e3a123c649bec91,e404f98fb3fd1b78,false] 46977 --- [nio-9000-exec-3] o.s.c.s.i.web.TraceHandlerInterceptor    : Adding a class tag with value [BasicErrorController] to a span [Trace: 0e3a123c649bec91, Span: e404f98fb3fd1b78, Parent: 0e3a123c649bec91, exportable:false]
2017-07-21 14:33:50.167 DEBUG [log,0e3a123c649bec91,e404f98fb3fd1b78,false] 46977 --- [nio-9000-exec-3] o.s.c.s.i.web.TraceHandlerInterceptor    : Skipping closing of a span for error controller processing

The log statement that's of concern is this:
2017-07-21 14:33:50.132 ERROR [log,,,] 46977 --- [nio-9000-exec-3] o.a.c.c.C.[.[.[/].[dispatcherServlet]    : Servlet.service() for servlet [dispatcherServlet] in context with path [] threw exception [Request processing failed; nested exception is java.lang.IllegalArgumentException

What is this class o.a.c.c.C.[.[.[/] ? Did you make a mistake when you copied that line?

@marcingrzejszczak No, that's just the package name abbreviated as per the logback config. Not sure about the / in the name, but I don't think I changed anything there. Will double check and update this comment if it turns out to be my mistake.

Any luck? :)

No luck, I checked, but the logs were gone. We don't retain them long for test environments.

Is there an option for you to try to create a sample? It will be difficult to help you without something tangible. I have no idea what that class is, how it's called etc. :/

I'll try.

Any progress on this @asarkar ? :)

Sorry, I've been pulled into other things and didn't get time to look into this. I'll close this ticket, and create another one if and when I've more information.

I had the same issue. When you create a custom ExceptionHandler, the trace and span ids are added correctly. Example Exception Handler:
@ControllerAdvice
public class ControllerExceptionHandler {

  @ResponseStatus(value = HttpStatus.INTERNAL_SERVER_ERROR)
  @ExceptionHandler(Exception.class)
  @ResponseBody
  public String handleInternalError(Exception e) {
    return "Internal Server Error";
  }

}

@thombergs Did you find out the root cause of the problem and how does @ControllerAdvice solve it?

ControllerAdvice is a spring component so Sleuth is fully operational there. Without this for example internal Tomcat classes handle errors and currently we don't hook in into those

@marcingrzejszczak the tracename set within the scopedscan is missing when handling exception in ControllerAdvice
@ExceptionHandler(Exception.class) 	public ResponseEntity<Object> handleOtherException(Exception exception, WebRequest request) { 		LOGGER.error("Handling unexpected exception ",exception); 		ApplicationResponsePayload payload = applicationExceptionHelperService 				.createResponsePayload(AppConstants.UNEXPECTED_ERROR_CODE, AppConstants.UNEXPECTED_ERROR_MESSAGE); 		LOGGER.info("Response payload {}", payload.toString()); 		return new ResponseEntity<Object>(payload, HttpStatus.OK); 	}
Log :
2020-06-09 16:45:32.111  INFO [-, traceId: be914bdb84997d8d, traceName: , spanId: be914bdb84997d8d, spanName: ] 10228 --- [nio-8080-exec-1] c.f.f.w.v.e.ApplicationExceptionHelperService   : Creating response payload for errorCode 500 with errorMessage UNEXPECTED ERROR
2020-06-09 16:45:32.111  INFO [-, traceId: be914bdb84997d8d, traceName: , spanId: be914bdb84997d8d, spanName: ] 10228 --- [nio-8080-exec-1] c.f.f.w.v.e.ApplicationGlobalExceptionHandler   : Response payload ApplicationResponsePayload(timestamp=Tue Jun 09 16:45:32 EDT 2020, statusCode=200, status=SUCCESS, errorCode=500, errorMessage=UNEXPECTED ERROR)

@arulrajsuri can you create a small project that replicates this issue?

@marcingrzejszczak I created a sample project https://github.com/arulrajsuri/SleuthTraceIssue/tree/master/TraceIssue

@marcingrzejszczak Can you please let me know when this issue will get triaged and fixed

Once it's fixed you'll get an automated update on this issue.

Thanks @marcingrzejszczak

@arulrajsuri you've finished the span here
@RequestMapping(method = RequestMethod.GET, path = "/getdata")
	public String getData() {
		ScopedSpan span = tracingInitUtil.initiateTracing("Trace-App");
		try {
			LOGGER.info("Get data executed in ApplicationController");
			return applicationService.getServiceData();
		} finally {
			span.finish(); // <-- You've finished the span here
		}
	}

So it has no access to any extra data in the controller advice. Remove finish and you'll see that it works fine.
Try wrapping the span in scope like this
@ControllerAdvice
public class ApplicationExceptionHandler extends ResponseEntityExceptionHandler {

	private static final Logger LOGGER = LoggerFactory.getLogger(ApplicationExceptionHandler.class);

	private final Tracer tracer;

	public ApplicationExceptionHandler(Tracer tracer) {
		this.tracer = tracer;
	}

	@ExceptionHandler(Exception.class)
	public ResponseEntity<Object> handleOtherException(Exception exception, WebRequest request) {
		try (Tracer.SpanInScope ws = tracer.withSpanInScope(tracer.currentSpan())) {
			LOGGER.error("Unexpected exception happended");
			return new ResponseEntity<Object>("Unexpected Exception", HttpStatus.OK);
		}
	}
}

Then I get the following logs
2020-07-29 16:20:14.653  INFO [-, traceId: e2515905c17917cf, traceName: Trace-App, spanId: d72f338c9aa5c4ca, spanName: ] 260415 --- [nio-8080-exec-1] com.tracing.issue.ApplicationController  : Get data executed in ApplicationController
2020-07-29 16:20:14.653  INFO [-, traceId: e2515905c17917cf, traceName: Trace-App, spanId: d72f338c9aa5c4ca, spanName: ] 260415 --- [nio-8080-exec-1] com.tracing.issue.ApplicationService     : Get service data executed in ApplicationService
2020-07-29 16:20:14.656 ERROR [-, traceId: e2515905c17917cf, traceName: Trace-App, spanId: e2515905c17917cf, spanName: ] 260415 --- [nio-8080-exec-1] c.t.issue.ApplicationExceptionHandler    : Unexpected exception happended
2020-07-29 16:20:14.668  WARN [-, traceId: e2515905c17917cf, traceName: , spanId: e2515905c17917cf, spanName: ] 260415 --- [nio-8080-exec-1] .m.m.a.ExceptionHandlerExceptionResolver : Resolved [java.lang.NullPointerException]


Define Citizen Labs projects

Draft project governance policy.
https://docs.google.com/document/d/1T5XhNmwdYvoqPLsxI8JUa19B4QVkqsksiCq1l15S_Mg/edit?usp=sharing

Added a couple comments/questions to this doc.


Use tobytes() instead of tostring()

Fixes #418

I think I had a previous username on the CLA. It should be updated to supersonicclay now. Can you re-run the CLA check?

Hey folks! This bug means that your nice sample packages can't be used with Python 3.9. Can we do something to get this fix merged?


Add ability to auto-load a default parent scene when running inside unity editor

We need to get away from using ProjectContext as much as possible and a good way to do that is to use parent scene contracts.  However, this can be a bit tedious sometimes when running scenes for testing purposes in unity editor because you have to manually set up the multiple scenes before hitting play.  What would be great instead is to have an optional field on SceneContext that directly references a default parent scene to use for this case.  This would only work when inside unity editor though, since this logic would have to occur before playmode starts, but would still be quite useful.  This could also be recursive and so could load the default parent of the default parent etc.

Fixed on develop branch


datetime prebuilt does not recognize "less than 24 hours".

If I ask a question like  "____________ in the LAST 24 hours"  datetime entity works correctly.  However, asking "______ for less than 24 hours."

@Dillagent, we've added this case to the list to be supported in the near future.
Thanks for the feedback.

This and similar durations should be supported as durations with modifier.


recipe for v0.9999999

I am interested in getting an updated tensorflow 1.2 recipe (see https://github.com/conda-forge/tensorflow-feedstock/issues/35). Unfortunately, there is a new feature of tensorboard that make tensorflow now require an older build of html5lib.
I am not sure how to open a PR onto a non-existent branch, so I opened this against master, but if a maintainer could create a v0.9999999 branch, I could close this PR and open it against that branch.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@minrk @jakirkham either of you able to review? This package is 1 of 2 packages holding up the tensorflow 1.2 recipe

@hajapy unless you are planning on maintaining the older version it is fine to "overwrite" master with the old one and then update it back to the latest version once the packages are in the channel.
I will merge this to get you going but after that you need to decided if you want this in a branch or if you just want to update master back to the latest.

@ocefpaf Thanks, I think we will not need to support the old version as long as we have the packages in the channel, so we can do what you suggest and get master back up to the latest version.


Update documentation of kaibel model

This pull request contains changes to the documentation of the ´kaibel_prop.py´ file.

Please sort the conflict with the merged PRs from @ZedongPeng before we revise this

Does #47 supersede this? SHould we merge this beforehand?

Does #47 supersede this? SHould we merge this beforehand?

Requested changes resolved in branch #47, can you merge branch #27, @bernalde?


[WIP] MV3 Collector Branch - Do Not Merge

This is the Collector PR for MV3 Work
Closes: #666

FYI, with the latest companion beta release, I tested going to https://ipfs.io/ipns/en.wikipedia-on-ipfs.org/wiki/, and it stayed on the page without refresh. When I reloaded, it's indefinitely loading and not redirecting the the companion set gateway:

https://explore.ipld.io/#/explore/QmSnuWmxptJZdLJpKRarxBMS2Ju2oANVrgbr2xWbie9b2D also results in an infinite spinner. (and doesn't without companion enabled)
If I disable companion when the infinite spinner is spinning, it takes me to ipns://explore.ipld.io/#/explore/QmSnuWmxptJZdLJpKRarxBMS2Ju2oANVrgbr2xWbie9b2D and shows an error:

could not get block QmYqLv4mWA8JN55F7qdBMcdcrz9Dwyc7z5xVhGgb6h1vCW: promise channel was closed

@whizzzkid

Share the output of: chrome.declarativeNetRequest.getDynamicRules() (copy-paste that here)

it's empty:
await chrome.declarativeNetRequest.getDynamicRules()
[]

FYI that http://explore-ipld-io.ipns.localhost:48084/#/ which shows ipns://explore.ipld.io/#/explore/QmdmQXB2mzChmMeKY47C43LxUdg1NDJ5MWcKMKxDu7RgQm in the browser, does load when I wait long enough.
http://en-wikipedia--on--ipfs-org.ipns.localhost:48084/wiki/Wikipedia also loads, showing ipns://en.wikipedia-on-ipfs.org/wiki/ in the browser.
await chrome.declarativeNetRequest.getDynamicRules() still returns an empty array though
After loading a few pages and waiting a bit.. I am able to get some dynamic rules:
[
  {
    "action": {
      "redirect": {
        "regexSubstitution": "http://localhost:8080/ipns/en.wikipedia-on-ipfs.org\\1"
      },
      "type": "redirect"
    },
    "condition": {
      "excludedInitiatorDomains": [],
      "regexFilter": "^http\\:\\/\\/en-wikipedia--on--ipfs-org\\.ipns\\.localhost\\:48084((?:[^\\.]|$).*)$",
      "resourceTypes": [
        "csp_report",
        "font",
        "image",
        "main_frame",
        "media",
        "object",
        "other",
        "ping",
        "script",
        "stylesheet",
        "sub_frame",
        "webbundle",
        "websocket",
        "webtransport",
        "xmlhttprequest"
      ]
    },
    "id": 27402,
    "priority": 1
  },
  {
    "action": {
      "redirect": {
        "regexSubstitution": "http://localhost:8080\\1"
      },
      "type": "redirect"
    },
    "condition": {
      "excludedInitiatorDomains": [],
      "regexFilter": "^http\\:\\/\\/127\\.0\\.0\\.1\\:8080(.*)$",
      "resourceTypes": [
        "csp_report",
        "font",
        "image",
        "main_frame",
        "media",
        "object",
        "other",
        "ping",
        "script",
        "stylesheet",
        "sub_frame",
        "webbundle",
        "websocket",
        "webtransport",
        "xmlhttprequest"
      ]
    },
    "id": 21038,
    "priority": 1
  },
  {
    "action": {
      "redirect": {
        "regexSubstitution": "http://localhost:8080\\1"
      },
      "type": "redirect"
    },
    "condition": {
      "excludedInitiatorDomains": [],
      "regexFilter": "^http\\:\\/\\/\\[\\:\\:1\\]\\:8080(.*)$",
      "resourceTypes": [
        "csp_report",
        "font",
        "image",
        "main_frame",
        "media",
        "object",
        "other",
        "ping",
        "script",
        "stylesheet",
        "sub_frame",
        "webbundle",
        "websocket",
        "webtransport",
        "xmlhttprequest"
      ]
    },
    "id": 10116,
    "priority": 1
  }
]

FYI: turning the node off does not turn off redirects.
Example:  https://starbase.gw3.io/ipfs/QmawceGscqN4o8Y8Fv26UUmB454kn2bnkXV5tEQYc4jBd6 redirected me to http://e580f2bcfc4276d5.gw3.io/ipfs/QmawceGscqN4o8Y8Fv26UUmB454kn2bnkXV5tEQYc4jBd6?sargs=H4sIAAAJbogA%2F6pWKlCyyivNydFRyoAxEpWsoquVspWslBKL0nXz8lNSlXSUypSslJwdXYM9vYrdLBw9QvMT80ITjUqKfSKcc319Awwy%2FSMKfS3KkyPNXSNDIjzzMkM9y5RqdRDmlOZlVkDNMTSzMLY0MrUwMlGqja0FDADpVtIcgwAAAA%3D%3D&ssig=APidkWklmXsEYaiSP5iTdxnwdnp1zerguGM6veRAv6j3NILaCMm%2BlFKgueQbTF99pG6ihtquyosQtb4u4grzCA%3D%3D, and when I refreshed, I was redirected to http://bafybeif3ie6d3yf2orkshi6xahlmwqudxst6db7mefkw6rcwanxwsksqou.ipfs.localhost:8080/?sargs=H4sIAAAJbogA%2F6pWKlCyyivNydFRyoAxEpWsoquVspWslBKL0nXz8lNSlXSUypSslJwdXYM9vYrdLBw9QvMT80ITjUqKfSKcc319Awwy%2FSMKfS3KkyPNXSNDIjzzMkM9y5RqdRDmlOZlVkDNMTSzMLY0MrUwMlGqja0FDADpVtIcgwAAAA%3D%3D&ssig=APidkWklmXsEYaiSP5iTdxnwdnp1zerguGM6veRAv6j3NILaCMm%2BlFKgueQbTF99pG6ihtquyosQtb4u4grzCA%3D%3D.
I disabled companion, and it was still redirecting me. Dynamic rules:
[
  {
    "action": {
      "redirect": {
        "regexSubstitution": "http://localhost:8080\\1"
      },
      "type": "redirect"
    },
    "condition": {
      "excludedInitiatorDomains": [],
      "regexFilter": "^https?\\:\\/\\/starbase\\.gw3\\.io((?:[^\\.]|$).*)$",
      "resourceTypes": [
        "csp_report",
        "font",
        "image",
        "main_frame",
        "media",
        "object",
        "other",
        "ping",
        "script",
        "stylesheet",
        "sub_frame",
        "webbundle",
        "websocket",
        "webtransport",
        "xmlhttprequest"
      ]
    },
    "id": 19877,
    "priority": 1
  },
  {
    "action": {
      "redirect": {
        "regexSubstitution": "http://localhost:8080\\1"
      },
      "type": "redirect"
    },
    "condition": {
      "excludedInitiatorDomains": [],
      "regexFilter": "^http\\:\\/\\/e580f2bcfc4276d5\\.gw3\\.io((?:[^\\.]|$).*)$",
      "resourceTypes": [
        "csp_report",
        "font",
        "image",
        "main_frame",
        "media",
        "object",
        "other",
        "ping",
        "script",
        "stylesheet",
        "sub_frame",
        "webbundle",
        "websocket",
        "webtransport",
        "xmlhttprequest"
      ]
    },
    "id": 6047,
    "priority": 1
  }
]

Folks, support me. https://github.com/protobufjs/protobuf.js/pull/1941


[Help Text] Type-o in Help Text for Private Event checkbox

The word display is missing the "L".

Included in beta release <IP_ADDRESS>


Spelling improved from initial README

Nice work. I'm going to close this PR so other's can complete the assignment


Roll engine 38a646e14cc2..9d4b80a60cb5 (13 commits)

https://github.com/flutter/engine/compare/38a646e14cc2...9d4b80a60cb5
git log 38a646e14cc2..9d4b80a60cb5 --no-merges --oneline
9d4b80a60 Roll src/third_party/skia 17282da3aa94..5767fc042834 (8 commits) (flutter/engine#6348)
ef98dcb11 Add support for counter timeline traces from the engine. (flutter/engine#6315)
a961e96d1 Roll buildroot to pick up updated vs toolchain. (flutter/engine#6346)
d6bb59978 Fixed IsolateNameServer documentation (flutter/engine#6344)
0c854ac01 Roll src/third_party/skia bdf1431686c2..17282da3aa94 (4 commits) (flutter/engine#6345)
e394ea1dd Roll src/third_party/skia c05302bc84da..bdf1431686c2 (1 commits) (flutter/engine#6343)
bcdfc2312 Roll src/third_party/skia 5457141b011e..c05302bc84da (1 commits) (flutter/engine#6342)
a861f37f7 Pass on the new unsafe-package-serialization option (flutter/engine#6331)
5e77a1e46 Roll src/third_party/skia bd03b54cb98d..5457141b011e (1 commits) (flutter/engine#6340)
6332db875 Roll src/third_party/skia f18c297cfb74..bd03b54cb98d (1 commits) (flutter/engine#6338)
a08bc52e8 Roll src/third_party/skia 7ffa40cedbc4..f18c297cfb74 (6 commits) (flutter/engine#6336)
8247ce26b Implement restore functions on Android and iOS (flutter/engine#6322)
2ead5c06c Roll src/third_party/skia 4ef464cd3c2e..7ffa40cedbc4 (10 commits) (flutter/engine#6334)
This roll should succeed according to the previous auto-roll.

LGTM and makes sense, but if you land this @a-siva will have to update his https://github.com/flutter/flutter/pull/22336.

@aam : https://github.com/flutter/flutter/pull/22336 won't be able to land unless it includes the following fix https://github.com/flutter/engine/pull/6361 for the tool_tests-windows.

@aam : #22336 won't be able to land unless it includes the following fix flutter/engine#6361 for the tool_tests-windows.

Cool, thanks for making a fix!


update model after loading URDF

There is a case that I want to add a payload to a quadruped robot. The payload is dynamically loaded
to body link(random mass/com/inertia).Before that, I import a model by loading URDF.
Now I have two choice:

update body link mass/com/inertia (treat body and payload as one link)
add a new link(fixed-joint) to body's child

but i don't find related API to achieve them.

if I choice 2. add a new link(fixed-joint) to body's child, the new joint/link should can be deleted.

You can use appendBodyToJoint in the Model API

You can use appendBodyToJoint in the Model API

thanks for your reply! If I use appendBodyToJoint, the payload body should be deleted for update the payload body inertia.
in other words, the body should be add-delete-add... cycle like this to update payload body inertia(the payload mass/position maybe changed).

for example, when the robot is running, add a backpack to the body, and then remove it.

We should add the feature to remove inertia from a given joint inertia.
In the meantime, you can mimic this effect by saving the inertia of a given joint const pinocchio::Inertia saved_inertia = model.inertias[joint_id] and using the method appendBodyToJoint. When you want to remove its effect, you need to restore the saved value as model.inertias[joint_id] = saved_inertia. Is it fine?

@hxrkpib I will close the issue and transfer it as Q&A in the discussions.


zencash wallet error

I reinstalled the wallet because i was getting that code 1 error but now i get another one. It is 99% synced and this appears

This problem is unusual (never seen this particular error message before). It could indicate some sort of socket communication issue between the zend.exe and zen-cli.exe executables that the GUI runs. Before any measures are taken to investigate, it is a good idea to backup the wallet and make sure you are using the latest version: https://zencash.atlassian.net/wiki/spaces/ZEN/pages/7176693/ZENCashWallet+Swing+Wallet+-+Backup+and+Upgrade
The wallet.dat file must never be lost! It may be copied manually when the GUI wallet/zend are not running. The wallet.dat needs to be backed up regularly (not just once - say after every few outgoing transactions) and it MUST also be backed up after creating a new Z address.
So after backups are secured the problem may be investigated by examining the logs of the GUI:
Windows:  %LOCALAPPDATA%/ZENCashSwingWalletUI/ZENCashGUIWallet_xxxx_xx_debug.log
and of the ZEN core/node (zend.exe):
Windows:  %APPDATA%/Zen/debug.log

The message "[warn] ... Only one usage of each socket address (protocol/network address/port) is normally permitted" is reported by zen-cli.exe as it gets called by the GUI. However this message is unexpected and prevents the GUI from working properly. The message indicates that the system is somehow short of network resources/sockets. Is it possible that there are other applications on the system that use the network intensively (e.g. servers/torrent clients etc)? If there are other such apps it may be a good idea to try restartng the system and running the wallet only... to see if the issue will occur again.
One article that contains ideas on solving similar problems is: https://support.socketlabs.com/index.php/Knowledgebase/Article/View/61

This is how I recovered my wallet on Windows 10 :

Have a backup of your private keys (Wallet -> Export private keys...) or your %APPDATA%\zen\wallet.dat file (if you can't open the Swing Wallet for some reason)
Uninstall/Delete the existing Swing Wallet and the %APPDATA%\zen directory
Download, extract and run the latest release

Don't replace anything, let it start the synchronization with a brand new and empty wallet

With the private keys simply use the Wallet -> Import private keys... menu and import your private keys
With the %APPDATA%\zen\wallet.dat file there can be version-related issues so you have to extract your private keys from the file :

Go to https://myzenwallet.io/
Settings (cog) -> Load wallet.dat -> Close (cross)
Select wallet.dat file
Export -> Download Private Keys
Now in the Swing Wallet use the Wallet -> Import private keys... menu and import your private keys

You will see all your funds when the Swing Wallet will be fully synchronized

Can this issue be closed ?

@zennermac should be able to close this one.


Message 1px too high

It kinda sticks out one pixel.

Yep, good eyes! Already reported here: https://github.com/atom/notifications/issues/57 so closing this to keep things organized.

Actually, this seems to be an issue with the One theme only. I'll move it back to here.

I believe I applied a fix in isotope, but the problem is in the default styles.

Fixed in the notification package: https://github.com/atom/notifications/commit/e52aa2dfb4ffc5dde30278cf077694378db5770b


Llama 3.1 8b not generating answers since past few days

What is the issue?
The llama 3.1 8b model was generating answers in my RAG app until a few days back. Now it says i cannot help with that even when i use a simple system prompt - you are a helpful assistant , use the context provided to you to answer the user questions.
The 70b model seems to work fine, I also noticed the 8b model was updated recently.
OS
Linux
GPU
Nvidia
CPU
No response
Ollama version
No response

Server logs will help in debugging.

Same here. I'll make a separate issue with test case

Here is the old template, works with RAG
TEMPLATE """{{ if .Messages }}
{{- if or .System .Tools }}<|start_header_id|>system<|end_header_id|>
{{- if .System }}

{{ .System }}
{{- end }}
{{- if .Tools }}

You are a helpful assistant with tool calling capabilities. When you receive a tool call response, use the output to format an answer to the orginal use question.
{{- end }}
{{- end }}<|eot_id|>
{{- range $i, $_ := .Messages }}
{{- $last := eq (len (slice $.Messages $i)) 1 }}
{{- if eq .Role "user" }}<|start_header_id|>user<|end_header_id|>
{{- if and $.Tools $last }}

Given the following functions, please respond with a JSON for a function call with its proper arguments that best answers the given prompt.

Respond in the format {"name": function name, "parameters": dictionary of argument name and its value}. Do not use variables.

{{ $.Tools }}
{{- end }}

{{ .Content }}<|eot_id|>{{ if $last }}<|start_header_id|>assistant<|end_header_id|>

{{ end }}
{{- else if eq .Role "assistant" }}<|start_header_id|>assistant<|end_header_id|>
{{- if .ToolCalls }}

{{- range .ToolCalls }}{"name": "{{ .Function.Name }}", "parameters": {{ .Function.Arguments }}}{{ end }}
{{- else }}

{{ .Content }}{{ if not $last }}<|eot_id|>{{ end }}
{{- end }}
{{- else if eq .Role "tool" }}<|start_header_id|>ipython<|end_header_id|>

{{ .Content }}<|eot_id|>{{ if $last }}<|start_header_id|>assistant<|end_header_id|>

{{ end }}
{{- end }}
{{- end }}
{{- else }}
{{- if .System }}<|start_header_id|>system<|end_header_id|>

{{ .System }}<|eot_id|>{{ end }}{{ if .Prompt }}<|start_header_id|>user<|end_header_id|>

{{ .Prompt }}<|eot_id|>{{ end }}<|start_header_id|>assistant<|end_header_id|>

{{ end }}{{ .Response }}{{ if .Response }}<|eot_id|>{{ end }}"""
PARAMETER stop <|start_header_id|>
PARAMETER stop <|end_header_id|>
PARAMETER stop <|eot_id|>

Hi folks, what size of a prompt are you providing? Would it be possible to provide an example prompt that reproduces this? Thanks so much, and sorry this happened.

Example prompt: you are a helpful assistant, you have to answer user’s questions using the context provided to you and nothing else.
I have removed the nothing else part and tried as well.
I thought maybe i am providing too much context and reduced it but it is just equivalent to 1-2 pages of a pdf, well under the 128k context limit.

The response seems to be consistent - I can’t assist with that request. I suggest reaching out to

I set the num_ctx option to high based on the solution you provided on another issue and can see answer generation now.
was the default num_ctx changed recently? If so how can I find out what the recent change was ?
Thanks for providing the solution @jmorganca , really appreciate it.

I had the same problem yesterday on my RAG system, which led me to think that I shouldn't have updated to the latest version of ollama.

I see frequent crashes for ollama (pulled 9 days ago) in general. The webui sometimes reports server error 500. Most of the time it just appears stuck. I don't have a log of the error.


Discord push to talk support?

Can be add the push to talk feature for discord when ferdi is in the background?

I'm actually completely unable to use discord voice as it says I'm using "an old" version of chrome (I have the latest version installed of Ferdi)


More Polish translation.

Coverage remained the same at 99.742% when pulling ee5cd43556cefcce25dafe7ae9715de4e3959593 on konrados:patch-1 into b67f59ddd7ae8247684283d4a095cfa15f4353e5 on craue:master.

Thank you, @konrados.

refs ##220


Device returning 401 Unauthorized for mobile format

Hey,
We're using devise and jQuery mobile, and we've set our navigational_formats to include :mobile, but when we try to sign in, it returns 401 Unauthorized, and doesn't log in.
It seems that its not picking up the navigational_formats. Anyone know if this is a valid bug/issue?

I am running into the same issue. @ryanza did you ever fix it?


Storyboard render error

Main.storyboard: error: IB Designables: Failed to render and update auto layout status for ViewController (aHa-t8-Jc5): dlopen(TagListView.framework, 1): no suitable image found.  Did find:
	TagListView.framework: required code signature missing for 'TagListView.framework'

I get this error after putting TagListView in a TableViewCell in my storyboard. Because of it the whole storyboard gets blank. Any fix?

I found temporary solution, go to Identity and Type of any view controller that causes problem and uncheck Use Trait Variations. Also uncheck Editor -> Automatically Refresh Views, than clean whole project and build.

same issue, temporary solution not good enough
any other solution ? it seems we should remove this library from our projects 🚔

finally i found the reason 😄
it's not problem of xcode or this library
it's just the problem of cocoapods version 1.5 ! damn it!
just uninstall cocoapods and instal version 1.3.1 and update pods resolve the problem
hope to help some one

Same issues, solutions above not works.
I found this : https://stackoverflow.com/a/49022780/7869148
Can you try ?


when does Zip emit Error?

RxJS version:
Rxjs 5
Code to reproduce:

        var error =Rx.Observable.throw('Oop!');
        var age$ = Rx.Observable.concat(Rx.Observable.of(21,22,23),error);
        var sex$ = Rx.Observable.of("male","male","female","female");
        var name$ = Rx.Observable.of("jack","john","james","lucy");
        var example = Rx.Observable.zip(age$,sex$,name$,(age,sex,name)=>{ return {age,sex,name} });

        example.subscribe({
            next: (value) => { console.log(value); },
            error: (err) => { console.log('Error: ' + err); },
            complete: () => { console.log('complete'); }
        });

Expected behavior:
expected output is:
{age:21,sex:"male",name:"jack"}
{age:22,sex:"male",name:"john"}
{age:23,sex:"female",name:"james"}
Error:Oop!

Actual behavior:
just one line,with out any output value.
Error:Oop!

Additional information:
none
Does anyone know:when does the Zip operator emit error

I had put this question in stackoverflow and got answer:
zip synchronously receives all of the observable's values and the concatenated error. It then emits its own error and is done.

this can explain the results of my demo,but i still think the implement of zip is weird.
I also check the spec doc and it does't mention when should zip emit error.

i still think the implement of zip is weird.

: would you elaborate more detail why it's weird? above snippet's behavior is not cause of behavior of zip, cause of you supplied synchronous observable as sources of operator. In RxJS 5, synchronous observable supposed to emit immediatly unless you're scheduling otherwise. For asynchronous observable sources, zip explains it via test cases.
https://github.com/ReactiveX/rxjs/blob/da96b6af6472947b8428b5a341d5c6acef0960df/spec/operators/zip-spec.ts#L534-L556

@kwonoj Thanks for pointing out the key.


Improvement for k8s.io/docs/tasks/configure-pod-container/quality-service-pod/

This page is very good in explaining how to influence the qos class of a pod. Some information is missing, though:

What is the qosClass good for? What exactly means Burstable, Guaranteed and BestEffort? The "big picture" is missing.
Can I override the qosClass determined by looking at the resource requests and limits? Can I explicitly set the qosClass to (lets say) Guaranteed and set a low memory request and a higher memory limit?

/language en
Page: https://kubernetes.io/docs/tasks/configure-pod-container/quality-service-pod/

Hi @harridu,

What is the qosClass good for? What exactly means Burstable, Guaranteed and BestEffort? The "big picture" is missing.

For this You can refer Glossary entry Qos Class and Pod Quality of Service Classes.

/language en

Ah, I see. Thank you very much