Focusing hidden activity bar shows empty space only

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: Version: 1.84.0 (Universal)
OS Version: macOS 13.3.1 (a)

Steps to Reproduce:

Set activity bar position to hidden
Open command palette and activate View: Focus activity bar

/assign @sandy081

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


Unable to download archived Facebook Live video

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.03.10. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[ x] I've verified and I assure that I'm running youtube-dl 2018.03.10

Before submitting an issue make sure you have:

[ x] At least skimmed through the README, most notably the FAQ and BUGS sections
[ x] Searched the bugtracker for similar issues including closed ones
[ x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[ x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
youtube-dl --username **** --password **** -F "https://www.facebook.com/FOXSportsChampionsLeague/videos/1782104488494402/" --verbose
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--username', 'PRIVATE', '--password', 'PRIVATE', '-F', 'https://www.facebook.com/FOXSportsChampionsLeague/videos/1782104488494402/', '--verbose']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.03.10
[debug] Python version 3.6.2 (CPython) - Darwin-17.4.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 3.4.1, ffprobe 3.4.1, rtmpdump 2.4
[debug] Proxy map: {}
[facebook] Downloading login page
[facebook] Logging in
[facebook]<PHONE_NUMBER>494402: Downloading webpage
[facebook]<PHONE_NUMBER>494402: Downloading webpage
ERROR: Cannot parse data; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/youtube_dl/YoutubeDL.py", line 785, in extract_info
    ie_result = ie.extract(url)
  File "/usr/local/lib/python3.6/site-packages/youtube_dl/extractor/common.py", line 440, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/lib/python3.6/site-packages/youtube_dl/extractor/facebook.py", line 422, in _real_extract
    video_id, fatal_if_no_video=True)
  File "/usr/local/lib/python3.6/site-packages/youtube_dl/extractor/facebook.py", line 337, in _extract_from_url
    raise ExtractorError('Cannot parse data')
youtube_dl.utils.ExtractorError: Cannot parse data; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
...
<end of log>

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://www.youtube.com/watch?v=BaW_jenozKc
Single video: https://youtu.be/BaW_jenozKc
Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc

Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.

I was able to successfully download the previous Facebook Live stream of the first leg a few weeks ago here, although now I am getting the same error. I do have full credentials to view in the browser (and it appears I am able to log in successfully).

Same problem here with older version and 2018.03.14.
Other videos of that closed facebook group already worked with provided login
some time ago.
The videos are working in browser but youtube-dl fails. Update did not help.
I tried one video that I already downloaded before - it's also not working anymore.
Thanks a lot

Same problem here with latest version 2018.03.14 - unable to download videos that require login.
However if no login is provided to youtube_dl videos that do not require login are downloading without issues.
The problem is only somewhere after the login, as the same videos that are downloading without login fail to download when credentials are added to the youtube_dl command.
Here is the example of video that works without credentials:
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'-F', u'https://www.facebook.com/SkylineWebcams/videos/1823658634322275/', u'--cookie', u'/mnt/upload/youtubedl_cookies.txt']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.03.14
[debug] Python version 2.7.13 (CPython) - Linux-4.9.0-6-amd64-x86_64-with-debian-9.2
[debug] exe versions: ffmpeg 3.2.4, ffprobe 3.2.4
[debug] Proxy map: {}
[facebook]<PHONE_NUMBER>322275: Downloading webpage
[facebook]<PHONE_NUMBER>322275: Downloading webpage
ERROR: Cannot parse data; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 785, in extract_info
    ie_result = ie.extract(url)
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 440, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/facebook.py", line 422, in _real_extract
    video_id, fatal_if_no_video=True)
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/facebook.py", line 337, in _extract_from_url
    raise ExtractorError('Cannot parse data')
ExtractorError: Cannot parse data; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

And the same without credentials:
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'-F', u'https://www.facebook.com/SkylineWebcams/videos/1823658634322275/']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.03.14
[debug] Python version 2.7.13 (CPython) - Linux-4.9.0-6-amd64-x86_64-with-debian-9.2
[debug] exe versions: ffmpeg 3.2.4, ffprobe 3.2.4
[debug] Proxy map: {}
[facebook]<PHONE_NUMBER>322275: Downloading webpage
[info] Available formats for<PHONE_NUMBER>322275:
format code  extension  resolution note
dash_sd_src  mpd        unknown
dash_hd_src  mpd        unknown    (best)

Still not fixed in 2018.03.20. I can paste my output if you want but it looks pretty similar to dbogatev's above.


move AWS code to Factory

@drewandersonnz the PR check seems to be failing, could you please check?

I have removed the Service Quotas section of this PR to focus on the Factory itself.
Intention is to get the factory merged then move on with the Service Quotas code.
I want to keep PRs as small and focused as possible.

/lgtm
/approve


Add missing details for get bindings context

Summary
Context was missing MattermostSiteURL and BotAccessToken when asking for bindings.
Ticket Link
None

Codecov Report

Merging #59 (5de74c0) into master (75c76ba) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
- Coverage   21.86%   21.79%   -0.08%
==========================================
  Files          19       19
  Lines         599      601       +2
==========================================
  Hits          131      131
- Misses        462      464       +2
  Partials        6        6

Impacted Files
Coverage Δ

server/api/impl/proxy/bindings.go
22.91% <0.00%> (-0.49%)
:arrow_down:

server/http/restapi/bindings.go
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75c76ba...5de74c0. Read the comment docs.


Add AArch64 feature detection support for OpenBSD

As an aside, would it be worth having AArch32 feature detection on OpenBSD as well?


Fix local device discovery and serialization on id clashes

Type of change:

[x] Bug fix (non-breaking change which fixes an issue)

Have a feeling this might fix [TBBAS-2044], hence I'm also building the simulator and will report back. The code LGTM.

Didn't help the bug.


How can we cater the website to non tech people for adding exercise

Background
At present, the steps involved to add new exercise is not user friendly. Need to have a GitHub account. Need to fork the repository. Propose the changes. One has to do code review before pushing. It may be a bit intriguing for a non tech user who has not been used to GitHub.
Approach to fix this

How about we create a new page where we take the relevant inputs from a user.
--> The user can be anonymous. But, I fear there may be some one who wants just to spam.
or
--> Create a small login system. Can use google auth2 for the same. To verify a user for contributing.

To review the content:
--> One way can be to use GitHub APIs in the backend to raise a pull request for the user once he send for approval.
--> Another way can be to have is to use a separate admin page. Where we could see the contents. Once approved. It can get automatically merged into the database.

My thoughts to bring in this is. May be we could expand the website for having diet which Gym folks use (home made diet tips), Gym plans, Diet plans, etc. If we want more people to contribute. There should be an easy way.
Others please let your thoughts here and also if it is relevant problem. It's not small feature. Will require some effort introduce these.

Definitely a great idea to make our website more user-friendly, especially to non tech users! Developing a compact login system and a content review mechanism is way beyond what I can currently do but I can contribute by creating a nutrition-focused page next to the existing Docs and Guide sections. Let's see if anyone else has any feedback they want to share

Background At present, the steps involved to add new exercise is not user friendly. Need to have a GitHub account. Need to fork the repository. Propose the changes. One has to do code review before pushing. It may be a bit intriguing for a non tech user who has not been used to GitHub.
Approach to fix this

How about we create a new page where we take the relevant inputs from a user.
--> The user can be anonymous. But, I fear there may be some one who wants just to spam.
or
--> Create a small login system. Can use google auth2 for the same. To verify a user for contributing.
To review the content:
--> One way can be to use GitHub APIs in the backend to raise a pull request for the user once he send for approval.
--> Another way can be to have is to use a separate admin page. Where we could see the contents. Once approved. It can get automatically merged into the database.

My thoughts to bring in this is. May be we could expand the website for having diet which Gym folks use (home made diet tips), Gym plans, Diet plans, etc. If we want more people to contribute. There should be an easy way.
Others please let your thoughts here and also if it is relevant problem. It's not small feature. Will require some effort introduce these.

Wow, sounds very interesting, we should do this.
Firstly we can go for the first point and slowly we can go for advanced features as you mentioned it will take effort but worth doing.

Hello:)
I will be able to do that, but we will need a database (I suggest firbase) to store it in, since the json file can not be edited. I can work on that, and sync all the data, to a database that I will create it.

Hello:) I will be able to do that, but we will need a database (I suggest firbase) to store it in, since the json file can not be edited. I can work on that, and sync all the data, to a database that I will create it.

If you don't feel comfortable using firebase, we can try sending the data to an email, for example yours, using a service, and then you can add it. but it requires your email, and you will have to actively check your email

@gabrysia694

Hello:) I will be able to do that, but we will need a database (I suggest firbase) to store it in, since the json file can not be edited. I can work on that, and sync all the data, to a database that I will create it.

If you don't feel comfortable using firebase, we can try sending the data to an email, for example yours, using a service, and then you can add it. but it requires your email, and you will have to actively check your email

Setting up a database sounds like a better solution, I hardly ever check email. If you're willing to work on that, it's all yours!

Hello:) I will be able to do that, but we will need a database (I suggest firbase) to store it in, since the json file can not be edited. I can work on that, and sync all the data, to a database that I will create it.

If you don't feel comfortable using firebase, we can try sending the data to an email, for example yours, using a service, and then you can add it. but it requires your email, and you will have to actively check your email

Setting up a database sounds like a better solution, I hardly ever check email. If you're willing to work on that, it's all yours!

Thanks:)
I will be delighted to work on it, please assign me as soon as possible


rstudio-server

Your repo works perfectly for rstudio (desktop). But rstudio-server isn't on there, I think?

That's right. I just pushed a commit that should add it. We should find out it it worked in the next six hours or so.

It worked like a charm! :)


BackendEstimator and BackendSampler raise an error with a bare Aer or BasicAer simulator

Environment

Qiskit Terra version: main
Python version: Python 3.9.15
Operating system: macOS 12.6.1

What is happening?
BackendEstimator and BackendSampler raise a following error with a bare Aer or BasicAer simulator without backend information.
AttributeError: Attribute max_experiments is not defined

How can we reproduce the issue?
from qiskit import BasicAer, Aer, QuantumCircuit
from qiskit.primitives import BackendEstimator
from qiskit.quantum_info import Pauli

qc = QuantumCircuit(1)
op = Pauli('Z')

backend = BasicAer.get_backend('qasm_simulator')
# backend = Aer.get_backend('aer_simulator')]:
est = BackendEstimator(backend=backend)
_ = est.run([qc], [op]).result()

Traceback (most recent call last):
  File "/Users/ima/envs/dev39/lib/python3.9/site-packages/qiskit/providers/models/backendconfiguration.py", line 384, in __getattr__
    return self._data[name]
KeyError: 'max_experiments'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/Users/ima/tasks/2_2022/qiskit/terra/tmp/backend_estimator.py", line 11, in <module>
    _ = est.run([qc], [op]).result()
  File "/Users/ima/envs/dev39/lib/python3.9/site-packages/qiskit/primitives/primitive_job.py", line 50, in result
    return self._future.result()
  File<EMAIL_ADDRESS>line 439, in result
    return self.__get_result()
  File<EMAIL_ADDRESS>line 391, in __get_result
    raise self._exception
  File<EMAIL_ADDRESS>line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/Users/ima/envs/dev39/lib/python3.9/site-packages/qiskit/primitives/backend_estimator.py", line 254, in _call
    result, metadata = _run_circuits(bound_circuits, self._backend, **run_options)
  File "/Users/ima/envs/dev39/lib/python3.9/site-packages/qiskit/primitives/backend_estimator.py", line 59, in _run_circuits
    max_circuits = backend.configuration().max_experiments
  File "/Users/ima/envs/dev39/lib/python3.9/site-packages/qiskit/providers/models/backendconfiguration.py", line 386, in __getattr__
    raise AttributeError(f"Attribute {name} is not defined") from ex
AttributeError: Attribute max_experiments is not defined

from qiskit import BasicAer, Aer, QuantumCircuit
from qiskit.primitives import BackendSampler

qc = QuantumCircuit(1, 1)

backend = BasicAer.get_backend('qasm_simulator')
# backend = Aer.get_backend('aer_simulator')]:
est = BackendSampler(backend=backend)
_ = est.run([qc]).result()

Traceback (most recent call last):
  File "/Users/ima/envs/dev39/lib/python3.9/site-packages/qiskit/providers/models/backendconfiguration.py", line 384, in __getattr__
    return self._data[name]
KeyError: 'max_experiments'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/Users/ima/tasks/2_2022/qiskit/terra/tmp/backend_sampler.py", line 9, in <module>
    _ = est.run([qc]).result()
  File "/Users/ima/envs/dev39/lib/python3.9/site-packages/qiskit/primitives/primitive_job.py", line 50, in result
    return self._future.result()
  File<EMAIL_ADDRESS>line 439, in result
    return self.__get_result()
  File<EMAIL_ADDRESS>line 391, in __get_result
    raise self._exception
  File<EMAIL_ADDRESS>line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/Users/ima/envs/dev39/lib/python3.9/site-packages/qiskit/primitives/backend_sampler.py", line 155, in _call
    result, _metadata = _run_circuits(bound_circuits, self._backend, **run_options)
  File "/Users/ima/envs/dev39/lib/python3.9/site-packages/qiskit/primitives/backend_estimator.py", line 59, in _run_circuits
    max_circuits = backend.configuration().max_experiments
  File "/Users/ima/envs/dev39/lib/python3.9/site-packages/qiskit/providers/models/backendconfiguration.py", line 386, in __getattr__
    raise AttributeError(f"Attribute {name} is not defined") from ex
AttributeError: Attribute max_experiments is not defined

What should happen?
No error
Any suggestions?
Need to check whether max_experiments is available for a backend.

#9069 fixes this issue


bug: fix vite base URL

Resolves #26
Description
Issue: #26

[x] Adds base to vite.config.js to correctly resolve deployed assets to the path

Notes
https://vitejs.dev/guide/static-deploy.html

Thanks for digging into this @HudsonGraeme! 🙇


Do not include empty lines or comment lines in the patterns extracted from .tesselignore (matchs fstream-ignore semantics).

cc @johnnyman727 this is pretty straight forward

yep, looks good to me!


Doppler color

Refactored some code. Added doppler coloring.

Looks good to me. I tested the pipeline to generate output and then merged it with lidar. It worked as expected.

Looks good to me. I tested the pipeline to generate output and then merged it with lidar. It worked as expected.


LDAP SSO: Change how AMP passes the username and filter to the LDAP server.

Feature Request
Feature Information:
TL;DR: Allow users to customize how the filter and the username is passed to the backend LDAP server.
So, revisiting LDAP authentication, I managed to come up with solutions to overcome some of the problems I was encountering before. I'm now able to use my SAMBA AD-DC controller because I should be able to force AMP to use a TLS connection through the helpful use of Stunnel4. And repeating some of the steps using LDAPSearch in the help forums has shown that - unless Novell uses some ass backwards methods vs LDAPSearch - that I should able to set this up without a hitch. One slight problem. This is the code for LDAP login as referenced from here ( https://discourse.cubecoders.com/t/amp-ldap-integration-non-functional-linux/4204/3 ):
using var de = new DirectoryEntry("LDAP://" + domain, username, password, AuthenticationTypes.Encryption);
using var directorySearcher = new DirectorySearcher(de);

directorySearcher.Filter = $"(&(objectClass=user)(sAMAccountName={username}))";
directorySearcher.PropertiesToLoad.Add("SAMAccountName");
directorySearcher.PropertiesToLoad.Add("memberOf");
SearchResult searchResult = directorySearcher.FindOne();

Translated to LDAPSearch...
ldapsearch -H LDAP://domain -D username -w password "(&(objectClass=user)(sAMAccountName=username))" SAMAccountName memberOf

Which, on the surface, looks okay. However, for those using SAMBA AD-DC, this happens instead:
root@alder:/home/Administrator# ldapsearch -H ldaps://localhost:636 -D hsf -W "(&(objectClass=user)(sAMAccountName=hsf))" SAMAccountName memberOf
Enter LDAP Password:
ldap_bind: Invalid credentials (49)
	additional info: 80090308: LdapErr: DSID-0C0903A9, comment: AcceptSecurityContext error, data 52e, v1db1

For reference, what I tried is the following:

Username "username" and Filter "username" -> No login.
Username "domain\username" and Filter "username" -> Login successfully, returned 1 result.
Same as 3, but with the Filter being the same as username -> Login successfully, but ldap_search returns bad filter.
It's the same if you specified the domain like this: username@domain, only the filter error doesn't come up.

Okay, enough rambling, what should be added?
Two parameters:
Login.LDAPUserDomain -> The domain name to prefix/suffix to the user
Login.LDAPPre2000k -> If True, "LDAPUserDomain\user", else "user@LDAPUserDomain".
Note that the parameters above should not affect what is passed to the filter. So for example:
Let's say the server is hosted at localhost.
If LDAPUserDomain is set to "example.com", LDAPPre2000k is to false, the username is "johndoe", and the password is "123546", the resulting search (in LDAPSearch format) should be:
ldapsearch -H LDAP://localhost -D<EMAIL_ADDRESS>-w 123546 "(&(objectClass=user)(sAMAccountName=johndoe))" SAMAccountName memberOf

That seems a little too much. Any other ideas?
Just the one.
Login.LDAPStripDomainFromFilter -> If the user passes in a username in the format of "domain\username" or "username@domain", the domain (alongside the "@" and "\") should be stripped from what is passed into the filter.
Might be more complex to code in, but it will be more ubiquitous to end users.
I confirm:

[x] that I have searched for an existing feature request matching the description.

I've implemented this in the development build, so you've now got the following settings:
        public bool UseLDAPLogins = false;
        public string LDAPAuthDomain = "";
        public string LDAPGroupPrefix = "AMP_";
        public string LDAPUserDomain = "";
        public bool LDAPADPre2000 = false;
        public bool LDAPStripDomainFromFilter = false;

Still unable to get this working. Tested with stock AD

Still unable to get this working. Tested with stock AD

Depending on how Microsoft has configured it stock, you may have to use stunnel4 to force AMP to talk securely to the LDAP server's TLS setup. Also, see issue #912 for a short term mitigation. And stay off dev branch for now until otherwise told.


[FancyZones] Validate zone rect before adding it into layout

Summary of the Pull Request
Validate zone rectangle before adding it into zone layout. If single zone rect is invalid, declare zone layout as invalid.
PR Checklist

[X] Applies to #2003
[X] CLA signed. If not, go over here and sign the CLA

Info on Pull Request
Extend MakeZone function to return nullptr if zone rectangle is invalid. Update unit tests to check implemented behavior.
Validation Steps Performed
All unit tests passed.

Good job! Unit tests passed except one that is failing on the current master.


configurable responsiveness

responsiveness can now be specified in doppio options, either as:

a number
a function that returns a number

The number is interpreted as a duration in milliseconds after which the thread should yield.
Closes #404

If #408 gets merged, I will refresh this PR so that the tests run again.

Looks good to me. Once you refresh the PR, I'll merge this in.

PR updated and checks passed!

Thanks again!


Fix for #670, inter project dependencies without matching package id

Fix for https://github.com/fsprojects/Paket/issues/670
Use the project name (without extension) to uniquely identify projects when determining inter project dependencies.
For this I added a new property on the ProjectFile for getting the project name without extension, so I've also used this in a couple of other places from some previous work I did.

thank you!

Thanks. Does it do what you want now?

Indeed it does, project references with corresponding paket.templates files are included as dependencies

Awesome :).


Create 0000-01-02-traderdiary.md

created a branch, created a file and made a commit, and opened a pull request

Changes completed. Merging back to main.

Completed changes, merging back to main.


Repeated words in the explanation

The word the file looks repeated in the paragraph

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f994acd9-1221-5d1a-8954-cb7c04bff4eb
Version Independent ID: c7c31bd5-d20d-5239-2057-85209511f45f
Content: Extend your Bot Framework Composer bot with code (C#, Node.js)
Content Source: composer-docs/concept-extend-with-code.md
Service: bot-composer
GitHub Login: @clearab
Microsoft Alias: anclear

Thanks for pointing out this typo, a fix will go live shortly.


PlayMode

Songbird version: 0.4.3
Rust version (rustc -V): 1.81.0
Twilight version: 0.15.4
Description:
In version 0.4.3 (PlayMode::End == PlayMode::Stop) returns true, whereas in version 0.3.2 it returns false.
Is there a new way to determinate whether a track has ended naturally or was stopped manually?
Steps to reproduce:
assert_eq!(PlayMode::End, PlayMode::Stop);

Thanks a lot!


"next export" for production build

does "next export" have a special flag for an optimized deployable build. I noticed that the app.js contains messages for 'react-hot-loader' which is typically used in the development environment.

AFAIK next export is still under review https://github.com/zeit/next.js/pull/1576

Closing this as next export hasn't landed yet.


Add job_tags and max_execution_time to options

Summary
Details and comments
Fixes #473

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 63.849%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
3105

Relevant Lines:
4863

💛  - Coveralls

closing in favor of #565


Discussion: should the repo be transferred into the haskell github org?

What benefits does it bring? More "official" status of project?

From my side, this doesn’t really matter. haskell-lsp very much feels like a community project already (thanks for being a great maintainer @alanz!) and I don’t think moving it around helps in any way.

One of the problems of the haskell org is that admins are usually not around, and activating things like new CI systems takes a long time.

It seems the consensus was not move it so i think we can close it (we can reopen if someone brings new arguments)


Question about default firewall rules

Hi
The rules defined in 02-networking - data/firewall-rules/dev/rules.yaml opens <IP_ADDRESS>/0 with targets composer-worker and dataflow.
Is it a good idea to have this as a default?
Good to have an example, but maybe not this open example?
Security Command Center give high alerts on anything that is open like this.
Just wondering
Thanks for the good work

This is the file in question: https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/blob/master/fast/stages/02-networking-peering/data/firewall-rules/dev/rules.yaml

All networking have this example:
https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/blob/master/fast/stages/02-networking-vpn/data/firewall-rules/dev/rules.yaml
https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/blob/master/fast/stages/02-networking-nva/data/firewall-rules/dev/rules.yaml

Thanks for flagging this. I agree. We can set a tag on both source and target.
Writing a PR.


⚠ Bofrost.at has degraded performance

In 08956d8, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1660 ms

Resolved: Bofrost.at performance has improved in f30d954 after 7 minutes.


PRIV "Catalog KPI Object" is not available on Datasphere

Issue description

Privelege "Catalog KPI Object" is not available when creating a Custom role on Datasphere.
Feedback Type (Optional)
None
Page Title on SAP Help Portal (prefilled)
Privileges and Permissions
Page URL on SAP Help Portal (prefilled)
https://help.sap.com/docs/SAP_DATASPHERE/9f804b8efa8043539289f42f372c4862/d7350c6823a14733a7a5727bad8371aa.html

Also, Privelege  "Catalog KPI Template " is not available when creating a custom role on Datasphere

Dear SAP Datasphere User
thank you for your feedback. We are working on the issue and will provide an answer soon
Best regards
Cindy for the UA team

Dear SAP Datasphere User
We've done some tests and we were able to include the following privileges in a custom role: "Catalog KPI Object" and "Catalog KPI Template". Could you please tell us more about the steps you've followed?
Thanks in advance.
Best regards
Cindy for the UA team

Hello team,
Jahr Silke from SAP has informed me that there was a bug which has been recently fixed.
The issue can be closed.
Thanks
Anu
From: CindyVenet @.>
Sent: Tuesday, March 26, 2024 9:49 PM
To: SAP-docs/sap-datasphere @.>
Cc: Karimbil, Anupama (623) @.>; Mention @.>
Subject: Re: [SAP-docs/sap-datasphere] PRIV "Catalog KPI Object" is not available on Datasphere (Issue #39)
[EXTERNAL E-MAIL]
Dear SAP Datasphere User
We've done some tests and we were able to include the following privileges in a custom role: "Catalog KPI Object" and "Catalog KPI Template". Could you please tell us more about the steps you've followed?
Thanks in advance.
Best regards
Cindy for the UA team
—
Reply to this email directly, view it on GitHubhttps://github.com/SAP-docs/sap-datasphere/issues/39#issuecomment-2020877213, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BG7UGKIY62SJSQKU2T2IXKDY2GGWLAVCNFSM6AAAAABEX2GL22VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRQHA3TOMRRGM.
You are receiving this because you were mentioned.Message ID: @.***>
If you are not the addressee, please inform us immediately that you have received this e-mail by mistake, and delete it. We thank you for your support.


Limit bandwidth for reading from ufs

Is your feature request related to a problem? Please describe.
When the bandwidth is limited, we need to consider limiting the bandwidth of alluxio to cache data from ufs. Thereby ensuring that multiple services share bandwidth.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Urgency
Explain why the feature is important
Additional context
Add any other context or screenshots about the feature request here.

Thank you for the feedback. @Jackson-Wang-7 please help to review the pr.


Refactor "default syncs" to live at the Git Source level (not the auto-import level)

Moving forward, Git Sources are going to be where settings and actions for "groups" of repos live.
As such, we've decided that "default syncs" should become a setting/property of a Git Source and no longer the individual setting of repo auto imports.

We reviewed and we're actually going to keep "default syncs" at the auto-import level


Issue 549 - format!-like macros formating

Format format!,format_args!, panic!, print!, println! calls as described in https://github.com/rust-lang-nursery/rustfmt/issues/549

Self tests still are failing. I thin it's better to reformat whole repository after someone reviews the code.

Rather than white-listing macros, I think it would be better to try and identify any macro that looks function-like and starts with a string literal as a candidate for this formatting. Does that seem reasonable?

About white listing.
If we try to guess, then we can end up with randomish formatting.
If we will try to determine macro based on the fact that first argument is static string, then this
some_macro!("arg1", "arg2", "arg3");

will result in
some_macro!("arg1",
            "arg2", "arg3");

which, in my opinion, is pretty strange.
And also if author refactors it a bit, we will have
let a1 = "arg1";
some_macro!(a1,
            "arg2",
            "arg3");

In my opinion, this kind of behaviour is not very obvious to user, and also it would be hard to describe if someone wanted to document it (as a project's code style, for example).
If we try to detect char sequences like {} or {:?} - it will make things even less obvious.
Summing up: I think that white list is the best option. The only way to make it more flexible, as I see it, is to make white list configurable.

hmm, good point on the whitelisting...
I think I like the configurable whitelist option, where it should be included as one of the config options. By default, it can be the std ones. This means we don't need an option for this specifically. However, it will be a bit more work, sorry


Inconsistent rendering results

When I use Qt, I meet

Sometimes the rendered result is the lower part of the picture.
I guess there is something that affects the calculation of the spacing.

That seems the context state was changed incorrectly, I'll fix it soon.

Modify setPointSizeF in Font_qt to setPixelSize, or add QApplication::setAttribute(Qt::AA_EnableHighDpiScaling) in qt_main.cpp;


refactor(es6): benchmark directory

What kind of change does this PR introduce?
Refactor

Did you add tests for your changes?

If relevant, link to documentation update:

Summary
Couple of files were not in-line with the others

Does this PR introduce a breaking change?

Other information
Next branch doesnt have these refactored as well so i targeted master

Thanks


script js doesn't load all scripts

I have an array of scripts that load together (order is insignificant) and script js fails to load them.
For example test4 and test 7 don't load, making the app not to bootstrap at all.
This happens at random times in chrome and every time i open an incognito window and try the url
   $script.ready('dependencies', function () {

    console.info("loaded dependencies");

    $script([
            'Libs/test1',
            'Libs/test2',
            'Libs/test3',
            'Libs/test4',
            'Libs/test5',
            'Libs/test6',
            'Libs/Subfolder/test7'
    ], function () {

        console.info("bootstraping app");
        angular.bootstrap(document, ['nlgApp']);
    });

I believe that script.js doesn't handle error callbacks because they're not supported in older browsers (LTE IE8). Here's the relevant code:
https://github.com/ded/script.js/blob/master/src/script.js#L65-L77
In case it helps, I wrote a script.js-compatible library that handles error callbacks but it only works in modern browsers (IE9+):
https://github.com/muicss/loadjs

I only need from IE10+ so it will be optimal!
Thanks i'll try it :)

I have the same error, @Duskfall loadjs works for your case ?

@Duskfall have you tried $script.order already? See: https://github.com/ded/script.js/blob/master/src/script.js#L86

I have moved away from scriptjs long ago, now using SystemJS module loading system to get ready for ES2016 with Typescript.

Ah, i didn't noticed the date of this issue :') that figures


v0.21.2

Description
Version bump
Testing

Additional notes

Checklist
I have read through the contributing guidelines and ensured that

[x] I have added a descriptive title for this pull request.
[x] I have followed the convention and standards, and my code is checked for style and correctness.
[x] I have added test cases, and unit tests pass with 100% code coverage.
[x] I have updated the documentation and code docstrings.

Checklist (for reviewer)

[x] I have added label (breaking / enhancement / bug / documentation) to this pull request, if applicable.
[x] I will ensure this change is captured in the CHANGELOG.md file.

https://github.com/kayjan/bigtree/issues/303


SafeArea Problem

Hi,
Thank you for this package.
Since SafeArea is used in the resulting model, it looks bad in my application.
Is it possible to remove SafeArea or make it optional?

Hi, you could use UIBlock as widget to overcome this problem as it doesn't use the default block modal. I have just updated the package in respect to this and now you can customize or totally disable the safe area.

It was enough for me.
Now we can customize it as we want, it just got better.
Thank you.


[Spatial selection] Show no-drop cursor only on map

If the selected source for the spatial selection isn't available, the cursor will change from default|pointer to no-drop.
If the cursor is e.g. on the overview map or toc, the cursor is still no-drop.

We want to show the no-drop cursor only on the map, not on all other UI elements.

Resolved by #333


HDDS-5660. Separate container caches for Open and Closed containers.

What changes were proposed in this pull request?
It has been seen in deployments that with large number of containers on datanodes. we have seen cache misses on the rocksDB cache.
This patch proposes
a) to have separate caches for open and closed container
b) rocksDB containers in open container cache are never evicted.
c) Open containers are moved from open to close container cache it they are closed/quasi closed.
d) Closed container are cached in LRU fashion as they are cached right now
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5660
How was this patch tested?
Added a new unit test

/pending

/ready

@mukul1987 testZReadKeyWithUnhealthyContainerReplica (in TestOzoneRpcClient  and TestOzoneRpcClientWithRatis) seems to be failing consistently.

/pending


Infinite scrolling example seems to be broken in codesandbox

The example works fine for a few moments but after 5 minutes when you scroll again the app throws the error in sandbox.
Steps to reproduce: Open the link in codesanbox. This is the link present in the mono repo. After it opens, wait for around 5 minutes and scroll down or up for a while.
Error message screenshot :

mono-repo link: https://github.com/remix-run/examples/tree/main/infinite-scrolling
@MichaelDeBoey

I just tried this, and after 10 minutes, getting back to the codesandbox tab, the whole tab was white, then all the UI came back and was on the homepage of the app, not the route I was on.
I don't think this is related to this example, but rather how codesandbox manage its resources..
Did this example cause you trouble locally ?


Updated French translations to reflect feedback

I translated "you/your" as "vous/votre" instead of "tu/ton". It's more formal and less familiar.
The French translation now seems to me to be pretty good.

Thanks again @thibaultmalfoy 🙂 This will be out in an upcoming Ghost release 🕺🏻


Fixed the selection of a date in another month than the initial one

When I navigate through months, I was not able to select a date in this chosen month.
Now, I can select the dates in this month.
As usual in the demo, the dates which are "disabled" cannot be selected.

Hi, is there any reason wy you closed this PR ?

Oops - sorry!
I thought I'd merged it....
Thanks for flagging that up, and apologies!

No problem and thanks for merging it!


Aspect Ratio support.

Is your feature request related to a problem? Please describe.
No.
Describe the solution you'd like
ImageCapture use case with Aspect Ratio support.
Describe alternatives you've considered
Most photo applications needs to control the aspect ratio of the generated image. The default available ones for the ImageCapture use case are RATIO_4_3 and RATIO_16_9.
Are you willing to provide a PR?
Yes.

Any progress on this?

Hey @lectricas, yes! It's already implemented in version 0.2.0, you can check out in this pull request
Here's an example:
CameraPreview(
  // ...
  imageCaptureTargetSize = remember { ImageTargetSize(AspectRatio.RATIO_16_9) }, // or AspectRatio.RATIO_4_3
)


[Visualization Workspace]: when switching tab position settings are not updated accordingly

-open 2 views in workspace visualization => visualization = heart and  visualization 1 = torso
-switch visualization tab with visualization 1 tab  => visualization becomes  torso and  visualization 1 becomes heart
->View settings and Layer settings will not switch => we will now have visualization = torso but with View and Layer settings from heart and vice versa

Now on https://github.com/medInria/medInria-public/issues/517, closing


How to use TensorRT for Speech Synthesis?

I have trained models of Tacotron-2 and Wavenet using the config files provided in example_configs/text2speech/.. folder. I want to reduce the inference time. Can i use TensorRT in Wavenet model for Inference?If so how to do it

You can use two flags:  'use_trt': True,  see  more flags here
model.py

@borisgin  thank you very much. is it enough to set the flag only at model.py? or i have to change in the config files present in example_configs/text2speech/.. folder.

You should set flag in the config file, not in model.py.
On Thu, Jul 11, 2019 at 3:08 PM ajaysg<EMAIL_ADDRESS>wrote:

@borisgin https://github.com/borisgin thank you very much. is it enough
to set the flag only at model.py? or i have to change in the config files
present in example_configs/text2speech/.. folder.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NVIDIA/OpenSeq2Seq/issues/474?email_source=notifications&email_token=ABZRNKJOLVSPPPCTS2KZNE3P64PEVA5CNFSM4IAW56G2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZWPXUY#issuecomment-510458835,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABZRNKOOBKWMJ2UYADCNIXTP64PEVANCNFSM4IAW56GQ
.

@borisgin thank you for your prompt response. I have used wavenet_float.py
for training. I could not find 'use_trt' flag in that.


Release update

Codecov Report

Merging #12 (f10a4e5) into master (890e747) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   95.81%   95.71%   -0.10%
==========================================
  Files          47       47
  Lines        2342     2288      -54
  Branches      170      170
==========================================
- Hits         2244     2190      -54
  Misses         74       74
  Partials       24       24

Impacted Files
Coverage Δ

two_factor/templatetags/two_factor.py
76.92% <0.00%> (-2.39%)
:arrow_down:

two_factor/views/core.py
95.53% <0.00%> (-0.04%)
:arrow_down:

tests/models.py
98.38% <0.00%> (-0.03%)
:arrow_down:

tests/test_admin.py
100.00% <0.00%> (ø)

tests/test_utils.py
100.00% <0.00%> (ø)

two_factor/forms.py
100.00% <0.00%> (ø)

tests/test_yubikey.py
100.00% <0.00%> (ø)

tests/test_gateways.py
100.00% <0.00%> (ø)

tests/test_views_login.py
100.00% <0.00%> (ø)

tests/test_views_phone.py
100.00% <0.00%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 890e747...f10a4e5. Read the comment docs.


Layout static props

Cascading get static props

Tested on devices

[ ] Desktop 💻
[ ] Mobile 📱

Tests

[ ] All tests are running ✔
[ ] Test are updated 🧪
[ ] Code Review 👩💻
[ ] QA 👌

⏲ Time spent on CR:
⏲ Time spent on QA:

Still trying to figure out some rerendering issue that arose due to layouts being implemented at page instead of _app


Objects with oneOf members not appearing in SwaggerUI

Hello,
Using NSwag.AspNetCore 13.3.0, given an API controller that takes in the following model:
public class Person
{
    public string FirstName { get; set; }

    public string LastName { get; set; }

    public Car Car { get; set; }
}

public class Car
{
    public string Make { get; set; }

    public string Model { get; set; }

    public int Year { get; set; }
}

the following OpenAPI schema is generated:
{
  "Person": {
    "type": "object",
    "additionalProperties": false,
    "properties": {
      "firstName": {
        "type": "string",
        "nullable": true
      },
      "lastName": {
        "type": "string",
        "nullable": true
      },
      "car": {
         "nullable": true,
         "oneOf": [
          {
            "$ref": "#/components/schemas/Car"
          }
        ]
      }
    }
  },
  "Car": {
    "type": "object",
    "additionalProperties": false,
    "properties": {
      "make": {
        "type": "string",
        "nullable": true
      },
      "model": {
        "type": "string",
        "nullable": true
      },
      "year": {
        "type": "integer",
        "format": "int32"
      }
    }
  }
}

Unfortunately, the SwaggerUI doesn't correctly render the 'Car' property in the example:

It exists within the schema definition in the SwaggerUI though:

Is this correct behaviour? Is there maybe a configuration property for this?

I have had the same issue. What throws me off as well is that it shows it as "oneOf"

Would I be able to get an update on this issue?

I am also seeing this with classes that implement List<T>. Changing the type directly to List<T> or IEnumerable<T> solves the problem.

Set AllowReferencesWithProperties to false
See https://github.com/RicoSuter/NSwag/issues/2986#issuecomment-700624325


Problems with wagtail 1.1

Copy no longer works. Might be related to https://github.com/thelabnyc/wagtail_blog/issues/8
I'm clueless on this issue. 'tags' is an invalid keyword argument for this function

i have same problem
Django Version:	1.8.5
Exception Type:	TypeError
Exception Value:
'tags' is an invalid keyword argument for this function
Exception Location:	/home/hosting_maximmb/projects/wag-iq/env/lib/python3.4/site-packages/django/db/models/base.py in init, line 480
Python Executable:	/home/hosting_maximmb/projects/wag-iq/env/bin/python
Python Version:	3.4.2

Fixed upstream in wagtail 1.2


Power State After Power Failure test

@filipleple please do not resolve the threads yourselves, because I lose the track what has been addressed and what not. Also if you force-push the commits and always point to a single commit, it defeats the purpose of linking it ( I still have to scroll and look for the line where the change has been introduced)... At least please link the line number

Replaced by: https://github.com/Dasharo/open-source-firmware-validation/pull/83


Authenticate with a Bearer Token instead of embedding the token in the payload

https://api.slack.com/web#authentication
Use HTTP header Authorization. Slack document seems to be saying we should use the header in every API call.

I have programmed a solution for this. https://github.com/mikkoi/p5-WebService-Slack-WebApi/tree/add-method-oauthv2access-bearer-token
It is based on the PR https://github.com/mihyaeru21/p5-WebService-Slack-WebApi/pull/48
Let's clear that first. If we make changes to it, I will merge those changes to this.

https://github.com/mihyaeru21/p5-WebService-Slack-WebApi/pull/49


sp-api: Set correct where bound in the generated code

The where bound for the create_metadata function wasn't correct. This pr fixes this by using the where bound declared at the type declaration augmented with the manual where bound.
Closes: https://github.com/paritytech/substrate/issues/14250

bot merge

@bkchr could you cherry-pick this commit into polkadot-v0.9.42 and polkadot-v0.9.43 branch?

@koushiro done.

@bkchr also polkadot-v0.9.42 branch, please

@bkchr I'm using polkadot-v0.9.42 branch, could you update it, please

Done, sorry I had forgotten to push the branch :see_no_evil:


sr replaced by '^2'

On tex files, whenever I write sr in insert mode, it gets replaced by ^2
Disabling this plugin fixes the issue, so I'm concluding it is the responsable

On tex files, whenever I write sr in insert mode, it gets replaced by ^2

Thank you for reporting. Understand. I have disabled auto-triggerring for a couple of snippets. Now to get the square, one needs to type sr + tab to get ^2.


Adding support for specifying list of commands in before/after commands

It is backwards compatible, so you can still do this:
before_run:
  - cmd1
  - cmd2
before_each: cmd3
run:
  golang: go test ./...

thanks for the pr @aheuermann


stream resume syntax change

- What I did
- How I did it
- How to verify it
- Description for the changelog

closing this PR since new PR is raised to trunk


[mask rom] Address Pseudocode Issues

CI Results:

Public (Passing): https://dev.azure.com/lowrisc/opentitan/_build/results?buildId=18308&view=results
Private (Passing): https://dev.azure.com/lowrisc/opentitan-private/_build/results?buildId=18307&view=results


use dash not bash for portability

Use #!/bin/sh in configure script, since bash is not universal.
For example Alpine Linux only has dash aka /bin/sh by default.
Also the zlib configure script itself is using /bin/sh as shebang.
Also use "$@" instead of $* so that you could in principle pass
args that contain whitespace. For example
try ${CC} '-DMY_DEFINE="a b c"' $test.c

now invokes the compiler with '-DMY_DEFINE="a b c"
literally instead of '-DMY_DEFINE="a' 'b' 'c'.

Should probably use shellcheck and checkbashisms to enforce POSIX-only shell before this is merged so the script doesn't break.

Shellcheck is part of the CI.
Checkbashisms is not AFAIK.

checkbashisms exits without output, assuming that means it's fine.
shellcheck didn't catch all issues, like $((...) | ...) being parsed differently; it needs a white space like $( (...) | ...)


Mals 1

please attach screenshots

update the images in readme please

added

update the images in readme please

added


Event click open few card in browser

Hi I using Electron: 5.0.8
node-notifier 5.4.3
when the notification appears for example 3 times and the user clicks on it, then 3 tabs in the browser will open:
const url = 'https://www.google.com/'
notifier.on('click', (notifierObject, options) => {
    console.log("click!");
    require('electron').shell.openExternal(url);
});

console.log will also return "click!" 3 times.

Hi @major697! I noticed you commented on a couple other issues related to this, and it sounds like you've possibly gotten it taken care of. If your project happens to be open source I'd love to see what your electron setup looks like since we don't currently have any examples/setup for testing through that.

I called removeAllListeners() on notifier before calling it again. It worked for me.

@pjebs Can you show me your code. I want see how you used removeAllListeners().

I actually reverted back to the standard notification that is part of electron.
See my comments here: https://github.com/electron/electron/issues/21610#issuecomment-569857509

Or maybe it was something like this:???
const url = 'https://www.google.com/'
notifier.removeAllListeners([])
notifier.on('click', (notifierObject, options) => {
    console.log("click!");
    require('electron').shell.openExternal(url);
});
const url = 'https://www.google.com/'
notifier.on('click', (notifierObject, options) => {
    console.log("click!");
    require('electron').shell.openExternal(url);
});

@pjebs it seems like the answer works. Thank you ;)


Add ability to manually override CodeFlare kfdef resource requirements

Original ask:
We will want to update the deployment artifacts such that users can specify resource requirements within the kfdef itself.

Hopefully this is something that's supported in the current CRDs...

Hi @anishasthana , I'm still messing with the kfdefs, mainly breaking things so far.  Looks to me like mcad resources are coming from here  and aren't set to anything, so resources are an empty set for MCAD, currently.
My original idea was to just edit the kfdef CR to update the resources or image tag, but looks like kubeflow utilizes kustomize to generate it from a combination of a tarball from the manifest combined with possible params.env/params.yaml overlays.  So now I'm thinking why we need to keep a complex set of params overlays rather than just updating it in the deployment source in lines 37 and 28.  Maybe we could have branches at various sizes small/med/large and the kfdef points to the correct codeflare-operator branch to generate the needed resource sizes?
Another option is to maybe figure out where the codeflare operator is storing the running image/resources and update them at the source, but I haven't figured out where they're stored... so when I manually update the CodeFlare deployments they revert back pretty quickly unless I turn off the Codeflare Operator.

The rationale behind this is allowing users to easily update the deployment from within the OpenShift Console. Directly editing the deployment source would require users to create a fork of the manifests and updating it.

Alex mentioned that the direction of ODH going forward is to not use the kfdef.
Tried testing with ODH 2.0.0 and it looks, so these kfdef changes are unnecessary.
With the 2.0.0 release, you can change resources like this:
kubectl edit mcads mcad

or
kubectl edit instascales instascale

And then add this under the spec section:
  controllerResources:
    limits:
      cpu: "1"
      memory: 1G
    requests:
      cpu: "1"
      memory: 1G


YodaStyleFixer - Clarify configuration parameters

@SpacePossum Great job on this fixer. However, the configuration description is unclear...
yoda_style [@Symfony]

Write conditions in Yoda style or not based on configuration.

Configuration options:

equal (bool, null): change equal (==, !=) statements; defaults to true
identical (bool, null): change identical (===, !==) statements; defaults to true
less_and_greater (bool, null): change less and greater than (<, <=, >, >=) statements; defaults to null

They all say: "Change X (if true) or not (if false)". That's not right and doesn't document the actual (great) possibilities of this fixer. It actually does:
true = Force to yoda style.
false = Force to non-yoda style.
null = Do nothing (ignore these statements).
This pull request tries to clarify the values. I hope the new descriptions are okay @keradus. I did not see any other fixers document params in this way. Because no other multi-option fixers used values in this weird way. ;-) It would have been better if the values had been a string: 'yoda' or 'non-yoda' or 'ignore'. But since it has been released as 2.6, that can't be changed now without breaking backwards compatibility with 2.x of PHP-CS-Fixer. So improving the docs to explain true/false/null is the best we can do.

Did you modify the REAME.rst by hand or regenerate it? as now the tests fail..
Beside that; I've no strong opinion on the copy used to describe the config, so I let the community deside ;)
(yet I still think using true/false/null as value was a good call over some magic string value, but that is part of the PR description but not a proposed change :) )

@SpacePossum Ohhh, I did it by hand. I didn't know you had an auto-generator (I see it now in contributing.md). I'll update the pull request in a moment!

@SpacePossum I've auto-generated the README now and made sure that the FixerDefinition matches it completely.
And sure, true/false/null is okay (and even if we wanted to, we can't change it now without breaking backwards-compatibility anyway...). We just need to document those 3 values, which is what I'm trying to do. Let's see what you guys think of this new update now!

:+1: if test are green :)

Thank you @SteveJobzniak.

@keradus Thank you too! :)


fix: 2412 process env not defined

Bumps mosaic to latest version to fix issue with process.env not being defined.

Approved but looks like there's some node version problem


Add LICENSE info to the README.md file

NOTE: Please read the CONTRIBUTING.md guidelines before submitting your patch,
and ensure you followed them all:
https://github.com/Kong/docs.konghq.com/blob/master/CONTRIBUTING.md
Summary

Adds LICENSE info to the README.md file

Full changelog

Adds LICENSE info to the README.md file

Issues resolved
Fix #974

Checklist:

[x] Commit message & atomicity checked
[x] Documentation
[x] Spellchecked my updates
[x] Ready to be merged

@thibaultcha Can you please review it?


unzip file

Aim

What is the objective of the Script

Unzipping a file
Details

What the features will your script have

this python script will be having zipfile module that will help in unzipping filles

@avinashkranjan can I work on this?

Go Ahead @Sloth-Panda


Perf Tests: Use in memory storage for scheduler

Description

Issue reference

Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

/ok-to-perf

/ok-to-perf

/ok-to-perf

/ok-to-perf-actor_reminder

/ok-to-perf actor_reminder

/ok-to-perf actor_reminder

/ok-to-perf actor_reminder

/ok-to-perf actor_reminder

/ok-to-perf actor_reminder

/ok-to-perf actor_reminder

/ok-to-perf actor_reminder

/ok-to-perf actor_reminder

/ok-to-perf

/ok-to-perf actor_reminder

/ok-to-perf actor_reminder

/ok-to-perf actor_reminder

/ok-to-perf actor_reminder

/ok-to-perf actor_reminder

/ok-to-perf actor_reminder

/ok-to-perf actor_reminder

/ok-to-perf actor_reminder


Problem with OpenSSL and Dsniff

Hello,
I guess I need a lower OpenSSL Version, so I downgraded it from 3.0.8 to 1.1.1.
After installing dsniff it is again version 3.0.8. Obviously the dsniff installation does a automatically openssl update.
Has anybody an idea?

PS: The result after establishing rdp connection looks like that:
╚══════╝╚══════╝   ╚═╝   ╚═╝  ╚═╝
[] Linux OS detected, using iptables as the netfilter interpreter
[] Spoofing arp replies...
[] Turning on IP forwarding...
[] Set iptables rules for SYN packets...
[] Waiting for a SYN packet to the original destination...
[+] Got it! Original destination is <IP_ADDRESS>
[] Clone the x509 certificate of the original destination...
[] Adjust iptables rules for all packets...
[] Run RDP proxy...
Listening for new connection


Firmware Update: Implementation of LWM2M mechanism considering device process triggering

I'm submitting a ...

[ ] bug report
[ ] feature request
[ ] support request

Do you want to request a feature or report a bug?

What is the current behavior?

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

What is the expected behavior?

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

Version: 0.2.x
Environment: [kubernetes, docker-compose, standalone]
Operating system: [Ubuntu 16.04, Fedora 28, Ubuntu on VirtualBox (Windows 10), etc.]

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)

Tested in official environment.

Tested in official environment.


Add sort_ja3 directive

This helps against the TLS extension order randomization by Chrome.
Opened again because the previous PR contained out of scope changes

Tested against Chrome 117 aa56c057ad164ec4fdcb7a5a283be9fc stays consistent


fix(license): remove scss auto-license in /docs

Our github pages were looking funky:

vs, what it should look like

SCSS files used in jekyll have to start with a front matter comment and can't start with a header license.  This excludes scss files in the docs directory from having the license header added automatically and fixes the existing comment to move beneath the front matter comment.
Similar to https://github.com/UW-Madison-DoIT/uw-frame/pull/527
{Substantive content goes here. Summarize the changeset and why the changeset.}

Contributor License Agreement adherence:

[x] This Contribution is under the terms of Individual Contributor License Agreements (and also Corporate Contributor License Agreements to the extent applicable) appearing in the Apereo CLA roster.

The CI failure is being caused by linting errors in this changeset: https://github.com/UW-Madison-DoIT/angularjs-portal/pull/692


chore: reuse gallery in windows vhd build

What type of PR is this?
/kind improvement

What this PR does / why we need it:
reuse gallery in windows vhd build.
Which issue(s) this PR fixes:

Fixes #
Requirements:

[x] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.266%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2355

Relevant Lines:
2971

💛  - Coveralls


[ZMQ] Bundle up necessary components or binary dependencies

To make things easier on users, we need to find a way to bundle up zmq (or improve things upstream).
If we bundle binaries though, we'll quickly be out of date (or so I assume), because Atom is constantly updating which also means updates to node necessitating updates to nan and zmq. If we force the development headers to be vendorized, that's a different story.
There's also the case of seeing what the Atom team thinks, including asking about zmq being part of Atom or electron directly.

Getting zmq being bundled into Atom would be the best outcome for us, but I don't know how many other Atom packages use it and if that would be a good move for Atom as a whole.
Why do you say that node updates would break our binaries? I don't know enough about it to see what components would break.

As V8 changes, function signatures changes, structs change, etc. To adapt to this, nan abstracts above these changes for you. https://github.com/JustinTulloss/zeromq.node uses this for instance. My assumption here is that if we create a build, it's a build for that specific version of node on that architecture since we don't want to rebuild with nan again.

Getting zmq being bundled into Atom would be the best outcome for us, but I don't know how many other Atom packages use it and if that would be a good move for Atom as a whole.

I think Hydrogen could easily change this. :smile: Yeah, it's a bit of a stretch for the moment.


Added ASCII loader

Added ASCII loader (see #19). Added user-defined dispersion unit to Data (spectrum object).

This is tested to work with basic and IPAC ASCII formats for the "generic" test data for the sprint.


Add Identity Update Builder

tl;dr

Adds IdentityUpdateBuilder and SignatureRequest structs, used to create batched Identity Updates

Design decisions
There were a few constraints on the design that made this a tricky one to implement.

These are batch signatures. An IdentityUpdate may contain several actions, each requiring one or two signatures. But each of those signatures are against a signature text derived from the entire batch. So, we need to gather an outline of all the updates before we can start collecting signatures.
Passing signers over the FFI barrier has proven complicated in the past. Some signers are synchronous, some are asynchronous. The caller doesn't necessarily have all the signers available every time they use libxmtp, so they may have to prompt the user before they can get a signature. The most versatile solution is to have a "signature request" that goes over the FFI barrier to platform SDKs, and have the SDKs return the serialized bytes.

Usage
        let account_address = "0x1234".to_string();
        let nonce = 0;
        let inbox_id = generate_inbox_id(&account_address, &nonce);

        let mut signature_request = IdentityUpdateBuilder::new(inbox_id)
            .create_inbox(account_address.into(), nonce)
            .add_association("0x5678".to_string().into(), account_address.into())
            .to_signature_request();

        for missing_signature in signature_request.missing_signatures() {
            signature_request.add_signature(somehow_get_signature_maybe_this_happens_over_ffi()).expect("should succeed")?;
        }

        let identity_update = signature_request.build_identity_update()?;

Merge activity

Apr 8, 12:10 PM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

Oof, didn't realize it was auto-merge @neekolas


Webinterface: PHP Extensions count not updated after extension enabling/disabling.

When you enable or disable a PHP extension in Configuration >> PHP Extensions, the (x of y loaded) text does not get updated. You need to refresh the page to see the change take effect.
....which also reveals another minor issue: upon page refresh, the selected tab is not "remembered" - you are always taken to the help tab and need to re-select the PHP Extensions tab.

Confirmed. It's an ajax issue.

[ ] ajax response needs to include the extension counter as part of the response (json) and update the dom
[ ] remember tab on page refresh

...opened separate issue for the page refresh thing.

Implemented.


Respect ancestor onTap event.

Removal of the GestureDetector with an empty onTap event allows for ancestor onTap events to fire instead of them being "ignored."

I attempted to write this unit test, but I couldn't get it to fail as I wanted to because I'd always have a CircularProgressIndicator instead of the CustomPaint.  If someone has ideas on how to fix it, awesome, but it can otherwise be ignored.
simple_sheet_music_test.txt

Thank you for your contribution! We will temporarily remove the GestureDetector, but we plan to add a feature that triggers a callback when tapping on musical symbols. When we bring the GestureDetector back, we will ensure it accommodates the situation you pointed out. We appreciate your continued support!

closes #25


Add example/documentation for using IK solution with MocoStateTrackingGoal

Main issues are changing column labels and converting to radians.

This was a repeated issue during the March 2020 workshop.

Having some feedback/output on what's being done behind the scenes could also help.
For instance, the radians issue was found because of the tracke_states.sto file. While the input had inDegrees=yes, the output file had inDegrees=no even though all the values were the same.

I'm not sure what is meant by the output file. Was that the MocoSolution STO file?

Oops, output file = tracked_states.sto file. That's a typo.

Oh! That's generated by MocoTrack during preprocessing. I forgot. That's a useful clue. This is a high-priority issue.
I do not understand where the issue is, given that here is where process() is invoked:
https://github.com/opensim-org/opensim-moco/blob/c8335c878548b137f9eeb159bdc3c647d1a96060/Moco/Moco/MocoTrack.cpp#L150-L151
and this is where the angle conversion happens in process():
https://github.com/opensim-org/opensim-moco/blob/c8335c878548b137f9eeb159bdc3c647d1a96060/Moco/Moco/Common/TableProcessor.h#L103-L106

@psbiomech have you used IK solutions as the state tracking reference in Moco?

@carmichaelong it might be helpful to have a set of files that reproduce the problem. It probably warrants it's own GitHub issue; if you have some time to reproduce and create the issue that would be helpful.

Definitely. Will plan on trying to get a minimal example for C++ this week.


Iterations & Pre/Postfixes

I've implemented a iteration count which the user can configure, this will set how many the times the hash is rehashed. I've also implemented --prefix and --postfix arguments so that the user can add salts before or after the word.
Kind regards

I've forgot to mention I've also fixed some bugs. The most important one is that previously the newline is still a part of the word that is hashed, e.g '123456\n' instead of '123456'.


Error on the final step to ASDW

Content: Tutorial: Perform ETL operations using Azure Databricks
Content Source: articles/azure-databricks/databricks-extract-load-sql-data-warehouse.md
Service: azure-databricks
I am having an issue similar to the one posted in
https://github.com/MicrosoftDocs/azure-docs/issues/12263
however, I am using "@" in
val tempDir = "wasbs://" + blobContainer + "@" + blobStorage +"/tempDirs"
and I am using mynewserver-20190119 for the server name, so that the variable sql
sqlDwUrl contains "mynewserver-20190119.database.windows.net" versus "mynewserver-20190119.database.windows.net.database.windows.net".
In the last step, I tried experimenting using
.format("jdbc") with no luck.
I also replaced sqlDwUrlSmall with sqlDwUrl in the option for "url".
renamedColumnsDf.write
.format("com.databricks.spark.sqldw")
/* .option("url", sqlDwUrlSmall) /
/ .format("jdbc") /
.option("url", sqlDwUrl)
.option("dbtable", "SampleTable")
/ .option("dbtable", "schema.tablename")
.option("user", "username")
.option("password", "password") */
.option("forward_spark_azure_storage_credentials","True")
.option("tempdir", tempDir)
.mode("overwrite")
.save()
When I substituted sqlDwUrlSmall with sqlDwUrl for the url option, and I get a different message.

com.databricks.spark.sqldw.SqlDWSideException: SQL DW failed to execute the JDBC query produced by the connector.
I reviewed the driver log (see attached), but I am not sure what I am looking for here.

I do have one question about the tempDir in the Storage Account Blob. The folder does not exist. Is it dynamically created; if not, do I need to create this folder and if so, how do I create folder in the container for the Blob?
Suggestions?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d863ab39-0b6a-eb81-9dde-5eb25b46cc33
Version Independent ID: 655abadf-5f9e-a65b-0109-c5166f956c4d
Content: Tutorial: Perform ETL operations using Azure Databricks
Content Source: articles/azure-databricks/databricks-extract-load-sql-data-warehouse.md
Service: azure-databricks
GitHub Login: @mamccrea
Microsoft Alias: mamccrea

@scubajon We will now proceed to close this thread. If there are further questions regarding this matter, please comment and we will gladly continue the discussion.

Hello everyone, I am using pyspark and I am having this same issue.
I have tried all you guys said above, but I am still strugling.
The difference in my code is that, It only fails when executed from inside a foreach.
When I execute the code outside a foreach it goes well.
The code below works:
body = 'A|B|C|D\n"False"|"253435564"|"14"|"2019-06-25 04:56:21.713"\n"True"|"253435564"|"13"|"2019-06-25 04:56:21.713"\n'
tableLocation = "tables"
table = "myTable"
schema = "dbo"

spark = SparkSession.builder.appName("CSV converter").getOrCreate()
spark.conf.set("fs.azure.account.key.dedbri.blob.core.windows.net",  "xxxxx")

csvData = spark.sparkContext.parallelize(body.split('\n'))

df = spark.read \
.option("header", True) \
.option("delimiter","|") \
.option("quote", "\"") \
.option("nullValue", "\\N") \
.option("inferShema", "true") \
.option("mergeSchema", "true") \
.csv(csvData)

df.write \
.format("com.databricks.spark.sqldw") \
.option("url", "jdbc:sqlserver://MyServer.database.windows.net:1433;database=MyDatabase;user=xxx;password=xxx;encrypt=true;trustServerCertificate=false;hostNameInCertificate=*.database.windows.net;loginTimeout=90;") \
.option("forwardSparkAzureStorageCredentials", "true") \
.option("dbTable", schema + "." + table) \
.option("tempDir"<EMAIL_ADDRESS>+ tableLocation) \
.mode("append")\
.save()

However it fails when I put this same come inside a foreach.
The code below fails:
def ProcessThis(row):
   "Same code above"

myDataFrame.select("x", "y").rdd.foreach(ProcessThis)

Doesn't matter if I am in streaming or batch environment. Both fails.

I have the same issue, when I arrived to final stage to let Databricks write in SQL DW by using  the commands below
spark.conf.set("spark.sql.parquet.writeLegacyFormat","true")
renamedColumn.write
.format("com.databricks.spark.sqldw")
.option("url", sqlDwUrlSmall)
.option("dbtable", "VehicleDetails")
.option( "forward_spark_azure_storage_credentials","True")
.option("tempdir", tempDir)
.mode("overwrite")
.save()
command-3332965607924468:4: error: not found: value sqlDwUrlSmall
.option("url", sqlDwUrlSmall)
^
Please, anyone can guide to resolve this issue.


task_parameters should be explicit about what parameters it has rather than magically copying everything from args

see: https://github.com/NervanaSystems/coach/blob/horizontal_scaling/rl_coach/coach.py#L340
task_parameters.__dict__ = add_items_to_dict(task_parameters.__dict__, args.__dict__) is unnecessarily obscure. It means that there are properties of task parameters which are not enumerated in the class, and it is difficult to search for where they are getting set.
Would it be possible to remove this line, and replace it with explicit named values like is already used for parameters like seed and use_cpu?

The initial motivation was to have all the command line arguments (that are enumerated in the argparse object) available through the task parameters.
I agree that this is not the best way to do this. A better thing to do, in my opinion, was to add a sub-name that will be accessible through task_parameters.command_line_parameters or something similar, which will include all these parameters.
It is also possible to explicitly define all the named values as you suggested. Although I think it would be error prone, since any new command line argument that will be added will need to be defined both through argparse and through the named value.
With this said, both options sound better than the current approach.

Fixed with release 0.11.0.


Meta Language fix static call import

Fixes issue with imports of classes which are used for static methods calls #3183

Thanks! This should make life easier ;)

I get it, this simply collects all classes ever touched (instantiated or static calls) in the dependencies. Thanks!


Copier update: backup.env overwritten

Describe the bug
After copier update, pre-existing aws credentials and backup passphrase are overwritten in .docker/backup.env.
Credentials defaults to null and are deleted from the env file. Passphrase changes to "example-backup-passphrase".
Because .docker/ is gitignored, this changes may go unnoticed.
To Reproduce
Steps to reproduce the behavior:

Use copier update to add my aws credentials and backup passphrase
Use copier update to update the project when there are changes in this template
Skip copier questions about backup credentials and passphrase

Expected behavior: Docs state that default values will be those you answered last time. If I don't want to change credentials and passphrase then when I press enter I expect them not to change.

The fix would be simple:

Add .docker/* to _skip_if_exists in copier.yml.
Add a test asserting that this works fine.

PRs welcome.


Add /api/ prefix to routes

Closes #181 - options discussed further in the ticket

all routes are now prefixed with /api/

for resource-based routes, a RootResource was added and should be used as the parent for all routes
for string-based routes, routes are updated

moved routing wire-up into its own function to keep the main class reasonable

should probably make RouteDependencies or something instead of passing Dependencies in the future

@nomisRev do you mind if I convert /api/tags to use resources in this PR?

Hey @organize,
PR looks great! 🙌 Feel free to update /api/tags, and then it's ready to merge 🥳


Customize font submenu dropdown

Hi @JiHong88 ,
I am trying to add a check icon on the font, font size submenu dropdown whenever user selection is active.
please find the screenshot for reference:

is there any possible way to do that in suneditor?
Thank you

@gopal1996 You can add it in the following way:
.sun-editor .se-submenu.se-list-font-size .se-list-inner .se-list-basic li button.active:after {
 content: ""
}

Find out how to put a checkmark.

Appreciate your help. Added the checkmark by following the above way :)


Archive failed when build

Issue Description
Signing /Users/hexs/Library/Developer/Xcode/DerivedData/Wi-Fi_Disk-aohjxusastpudjdgayvtwnqqwjbv/Build/Intermediates/ArchiveIntermediates/Aigo\ iStorage/InstallationBuildProductsLocation/Applications/aigo\ Disk.app
** ARCHIVE FAILED **
And this is detailed error log
Validate /Users/hexs/Library/Developer/Xcode/DerivedData/Wi-Fi_Disk-aohjxusastpudjdgayvtwnqqwjbv/Build/Intermediates/ArchiveIntermediates/Aigo\ iStorage/InstallationBuildProductsLocation/Applications/aigo\ Disk.app
cd /Users/hexs/Desktop/workspace/Shell_Test_Project/Wi-Fi_Disk_Optim
export PATH="/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/usr/bin:/Applications/Xcode.app/Contents/Developer/usr/bin:/Users/hexs/.rvm/gems/ruby-2.3.0/bin:/Users/hexs/.rvm/gems/ruby-2.3.0@global/bin:/Users/hexs/.rvm/rubies/ruby-2.3.0/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Users/hexs/.rvm/bin"
export PRODUCT_TYPE=com.apple.product-type.application
builtin-validationUtility /Users/hexs/Library/Developer/Xcode/DerivedData/Wi-Fi_Disk-aohjxusastpudjdgayvtwnqqwjbv/Build/Intermediates/ArchiveIntermediates/Aigo\ iStorage/InstallationBuildProductsLocation/Applications/aigo\ Disk.app -validate-for-store
Environment
+-------------+-------------------------+
|           Build environment           |
+-------------+-------------------------+
| xcode_path  | /Applications/Xcode.app |
| gym_version | 2.5.0                   |
| sdk         | iPhoneOS9.3.sdk         |
+-------------+-------------------------+
Thank you.

But I can use Product-> Achieve to compile * .xcarchive, is the need for other settings?

And I can not use this command to compile.
xcodebuild archive -scheme "Aigo iStorage" -configuration Release -archivePath build/Aigo_iStorage
the error log is the same, Thank you very much！

Did you recently perform any osx or xcode updates?

No, xcode version is 7.3.1 and mac os version is 10.12.1, Is the need to update it?

Well, being on an old version has its own limits, but I was asking because I ran into archive failures after updating recently. You're way behind my environment though, so it's probably not related.
Could you previously archive without issues?
I am guessing there's a path or permissions issue.  What happens if you run xcodebuild without an output path? (Or making it relative)

If I do not use the archivePath, the same problem, but if I create a new project, it's ok, I do not know where my project is configured incorrectly.
Can you help me?
Thank you very much!

Thanks for raising the issue @keroushe! It looks to me like there is an issue with the project that is causing xcodebuild to fail. Would you mind sharing the output from xcode-select -p? That might help to shed some light on the issue.
If the output from that command shows you a path to a newer version of Xcode, its possible that while your project builds inside of Xcode 7.3.1, the xcodebuild command is set up to use a newer version. If this is the case, you can run sudo xcode-select -s /Applications/<path to your Xcode 7.3.1>.app
I am going to close this issue for now as it appears that it is related to your project rather than fastlane itself, but please feel free to continue conversation here and we will try to help out as much as we can! 😄 🐙


Fix exclude dogtag barters toggle

Also fixes some paths in the build script that caused errors when running on Windows.

.deploy

.unlock production

.deploy


diagnostic: make using outdated dev tools fatal

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you successfully run brew tests with your changes locally?

A smarter form of https://github.com/Homebrew/brew/commit/559cea7fa9d7f9f2557f2523092687dec45c5316. Travis users can't force Travis to update 10.11 to Xcode 8, so this was murdering builds left, right & centre.
Fixes https://github.com/Homebrew/brew/issues/1096 whilst still retaining the point of the original commit. Also offers developers an opt-out so if we need to test something on 10.11 with Xcode 7.x we can, etc.

Seems fine. I wonder(ed) if we wanted to enforce only certain versions of Xcode/CLT in this that we know to be problematic e.g. Xcode 7 on Sierra.

Thanks for the merge! Do you want a PR with further tweaks here or are you happy?

Think it's fine as-is. We can iterate if people 😭

Cool 👍

My apologies if I misunderstand the nature of this commit.  This comment is about the user-friendliness of the commit, not the motivation or the implementation.
I think we should provide clear instructions how a user who is temporarily stuck with a newly-obsolete Xcode can get out of jail.
I'm thinking of cases where an Xcode bump comes out but a user hasn't had the chance to download it yet:  either because she's on a slow connection, or even just because Xcode is an enormous download and takes a while even on broadband, or because she needs to perform careful backups and such before installing a potentially disruptive Xcode bump.
I don't like the idea that such a user---who intends to update to the latest version very soon---would be (or believe herself to be) frozen out of using homebrew until then.  There may even be a critical update to something that she needs to brew right away, but can't because she is still waiting until she can install the latest Xcode.
I think we can keep old Xcodes being fatal so long as (a) the commit that kills a given Xcode is always  tagged, and (b) in the fatality warning message we either provide clear and visible instructions on how she can use git to revert to the brew tag immediately prior to the one that killed her Xcode, or inform her that setting HOMEBREW_DEVELOPER will get her out of jail, or both.

I don't like the idea that such a user---who intends to update to the latest version very soon---would be (or believe herself to be) frozen out of using homebrew until then. There may even be a critical update to something that she needs to brew right away, but can't because she is still waiting until she can install the latest Xcode.

I think so long as we wait until a bit after a major release it's reasonable for us to force this through. Xcode 7 on Sierra, for example, is known to be extremely broken. Perhaps we could restrict to more finely grained situations like that but I don't really ever want to allow people to install (even if they really have to) in that situation.

As this currently stands Xcode 7 on El Capitan is also fatal, which could be controvertial.

There may even be a critical update to something that she needs to brew right away, but can't because she is still waiting until she can install the latest Xcode.

If we've already moved over to the new Xcode we can't make any guarantees the old Xcode will work, and indeed, as homebrew/core has punchily shown over the last few days a lot of the time it won't, and because we've just upgraded ourselves there's very little we can do to help you debug in that situation.
I'm open to further tweaking, but I think fairly clearly we need to be harder on this sort of thing than we were.

I'd say nagging is better than failing out right on less problematic combinations (Xcode 7 on El Capitan). You don't really need to latest everything to pour bottles, for instance.

I guess I'm wary that going forwards the conditional could get a little more wild, for example right now:
if MacOS.version == :sierra && MacOS::Xcode.installed? && MacOS::Xcode.version < "8.0"

Is semi-doable, but come a year's time that might become something like:
if MacOS.version == :sierra && MacOS::Xcode.installed? && MacOS::Xcode.version < "8.0" || MacOS.version == :cupertino && MacOS::Xcode.installed? && MacOS::Xcode.version < "9.0"

etc, that's kind of getting out of hand.

But the bug reports...

It feels like the Right Solution may be just to have a minimum Xcode version set somewhere per-OS. Make it data in a hash rather than a conditional. We store the latest but we could also store a minimum; we warn if not latest and fail if not minimum. Should be easy to write and enforce.

As this currently stands Xcode 7 on El Capitan is also fatal, which could be controversial.

This is exactly the sort of case I had in mind.  (Plus, AFAICT right now, Xcode 8 on ElCap is more likely to cause a problem than Xcode 7 on ElCap.)

If we've already moved over to the new Xcode we can't make any guarantees the old Xcode will work, and indeed, as homebrew/core has punchily shown over the last few days a lot of the time it won't,

We can't make any guarantees, but: probably it will still work.  Especially if the user reverts to the tag prior to the killing of the Xcode.

I think fairly clearly we need to be harder on this sort of thing than we were.

Agreed :smile:, I just think we need to offer users a way out if they're in a jam at the moment.

We store the latest but we could also store a minimum; we warn if not latest and fail if not minimum. Should be easy to write and enforce.

I like this idea.
Separate from whatever the plan is, I think it's a good idea to make sure that Xcode-killing commits are tagged (or that the commit just prior to the killer is tagged).

@chdiza If you want it done ASAP, you may want to work up a Pull Request. Otherwise improving this is on my list, but not right at the top.


Jest coverage percentage skewed

Do you want to request a feature or report a bug? BUG
What is the current behavior?
when running jest --coverage my statement percentage is 68.37% but running jest --coverage --no-cache returns 73.39% every time
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal repository on GitHub that we can npm install and npm test.
run jest --coverage note the statement percentage then run ``jest --coverage --no-cache` and observe the percentage raises
What is the expected behavior?
percentage should be consistant between the two or at least once cache is cleared the run without the --no-cache flag should match the uncached version
Run Jest again with --debug and provide the full configuration it prints. Please mention your node and npm version and operating system.
Cached run
 ~/Sites/When I Work/wheniwork-js   master ●✚  jest --coverage --debug
jest version = 17.0.3
test framework = jasmine2
config = {
  "modulePaths": [
    "app"
  ],
  "coverageDirectory": "/Users/clarktomlinson/Sites/When I Work/wheniwork-js/reports/coverage",
  "collectCoverageFrom": [
    "app/**/*.js",
    "!app/tests/**",
    "!app/shared/vendor/**"
  ],
  "coverageReporters": [
    "json",
    "lcov",
    "text-summary"
  ],
  "setupFiles": [
    "/Users/clarktomlinson/Sites/When I Work/wheniwork-js/node_modules/babel-polyfill/lib/index.js",
    "/Users/clarktomlinson/Sites/When I Work/wheniwork-js/scripts/test.js"
  ],
  "moduleNameMapper": [
    [
      "^.+\\.(jpg|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga)$",
      "/Users/clarktomlinson/Sites/When I Work/wheniwork-js/__mocks__/fileMock.js"
    ],
    [
      "^.+\\.(css|scss)$",
      "/Users/clarktomlinson/Sites/When I Work/wheniwork-js/__mocks__/styleMock.js"
    ]
  ],
  "rootDir": "/Users/clarktomlinson/Sites/When I Work/wheniwork-js",
  "name": "-Users-clarktomlinson-Sites-When-I-Work-wheniwork-js",
  "testRunner": "/Users/clarktomlinson/Sites/When I Work/wheniwork-js/node_modules/jest-jasmine2/build/index.js",
  "transform": [
    [
      "^.+\\.jsx?$",
      "/Users/clarktomlinson/Sites/When I Work/wheniwork-js/node_modules/babel-jest/build/index.js"
    ]
  ],
  "usesBabelJest": true,
  "automock": false,
  "bail": false,
  "browser": false,
  "cacheDirectory": "/var/folders/_4/xcdmgc7d03515l5_c6bj86p80000gn/T/jest",
  "coveragePathIgnorePatterns": [
    "/node_modules/"
  ],
  "expand": false,
  "globals": {},
  "haste": {
    "providesModuleNodeModules": []
  },
  "mocksPattern": "__mocks__",
  "moduleDirectories": [
    "node_modules"
  ],
  "moduleFileExtensions": [
    "js",
    "json",
    "jsx",
    "node"
  ],
  "modulePathIgnorePatterns": [],
  "noStackTrace": false,
  "notify": false,
  "preset": null,
  "resetMocks": false,
  "resetModules": false,
  "snapshotSerializers": [],
  "testEnvironment": "jest-environment-jsdom",
  "testPathDirs": [
    "/Users/clarktomlinson/Sites/When I Work/wheniwork-js"
  ],
  "testPathIgnorePatterns": [
    "/node_modules/"
  ],
  "testRegex": "(/__tests__/.*|\\.(test|spec))\\.jsx?$",
  "testURL": "about:blank",
  "timers": "real",
  "transformIgnorePatterns": [
    "/node_modules/"
  ],
  "useStderr": false,
  "verbose": null,
  "watch": false,
  "collectCoverage": true,
  "cache": true,
  "watchman": true
}

Uncached run
 ~/Sites/When I Work/wheniwork-js   master ●✚  jest --coverage --debug --no-cache
jest version = 17.0.3
test framework = jasmine2
config = {
  "modulePaths": [
    "app"
  ],
  "coverageDirectory": "/Users/clarktomlinson/Sites/When I Work/wheniwork-js/reports/coverage",
  "collectCoverageFrom": [
    "app/**/*.js",
    "!app/tests/**",
    "!app/shared/vendor/**"
  ],
  "coverageReporters": [
    "json",
    "lcov",
    "text-summary"
  ],
  "setupFiles": [
    "/Users/clarktomlinson/Sites/When I Work/wheniwork-js/node_modules/babel-polyfill/lib/index.js",
    "/Users/clarktomlinson/Sites/When I Work/wheniwork-js/scripts/test.js"
  ],
  "moduleNameMapper": [
    [
      "^.+\\.(jpg|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga)$",
      "/Users/clarktomlinson/Sites/When I Work/wheniwork-js/__mocks__/fileMock.js"
    ],
    [
      "^.+\\.(css|scss)$",
      "/Users/clarktomlinson/Sites/When I Work/wheniwork-js/__mocks__/styleMock.js"
    ]
  ],
  "rootDir": "/Users/clarktomlinson/Sites/When I Work/wheniwork-js",
  "name": "-Users-clarktomlinson-Sites-When-I-Work-wheniwork-js",
  "testRunner": "/Users/clarktomlinson/Sites/When I Work/wheniwork-js/node_modules/jest-jasmine2/build/index.js",
  "transform": [
    [
      "^.+\\.jsx?$",
      "/Users/clarktomlinson/Sites/When I Work/wheniwork-js/node_modules/babel-jest/build/index.js"
    ]
  ],
  "usesBabelJest": true,
  "automock": false,
  "bail": false,
  "browser": false,
  "cacheDirectory": "/var/folders/_4/xcdmgc7d03515l5_c6bj86p80000gn/T/jest",
  "coveragePathIgnorePatterns": [
    "/node_modules/"
  ],
  "expand": false,
  "globals": {},
  "haste": {
    "providesModuleNodeModules": []
  },
  "mocksPattern": "__mocks__",
  "moduleDirectories": [
    "node_modules"
  ],
  "moduleFileExtensions": [
    "js",
    "json",
    "jsx",
    "node"
  ],
  "modulePathIgnorePatterns": [],
  "noStackTrace": false,
  "notify": false,
  "preset": null,
  "resetMocks": false,
  "resetModules": false,
  "snapshotSerializers": [],
  "testEnvironment": "jest-environment-jsdom",
  "testPathDirs": [
    "/Users/clarktomlinson/Sites/When I Work/wheniwork-js"
  ],
  "testPathIgnorePatterns": [
    "/node_modules/"
  ],
  "testRegex": "(/__tests__/.*|\\.(test|spec))\\.jsx?$",
  "testURL": "about:blank",
  "timers": "real",
  "transformIgnorePatterns": [
    "/node_modules/"
  ],
  "useStderr": false,
  "verbose": null,
  "watch": false,
  "collectCoverage": true,
  "cache": false,
  "watchman": true
}

Hey @th3fallen, thanks for your input. Can you provide a test case or simple repo with the bug? Tried several times but I can't seem to replicate this.
Thanks!

@thymikee I'm not sure of how to reproduce without sharing our code but I'll attempt to get something for you today

Thank you, much appreciated!

@thymikee actually i appears this issue is resolved in a later version of jest because now i cant reproduce it. Easy enough. thanks for the help non the less.


Invert the shadow calibration

The original calibration seems wrong.

The original calibration seems wrong.

LG, curious, how come the arm seems to operate correctly before?

The original calibration seems wrong.

LG, curious, how come the arm seems to operate correctly before?

I am curious about this too. Might need another pair of eyes. Let's verify tomorrow.

Btw this was verified last week.


Mavlink receiver: fix attitude sp logic

Port https://github.com/PX4/Firmware/pull/1920 to mavlink receiver

@thomasgubler Any chance looking into this?


Remove cleanup from 'run-tests' script

Closes #56

@rultor please merge

@rultor please merge

@extsoft OK, I'll try to merge now. You can check the progress of the merge here

@rultor please merge

@extsoft Done! FYI, the full log is here (took me 2min)


Fixed Issue #164 incorrect text in search bar

Can one of the admins verify this patch?

Jenkins, add to whitelist.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/mango-prb/161/
Test FAILed.

@dorislee0309 can you rebase on the master branch and resubmit the PR? We made some changes to fix the failed build


Add Validator Onboarding

Create a section for Platform and list the process of onboarding a validator:

in each assets/blockchain/<chain> /validators/list.json, add a name, id, description, and website`.
in each assets/blockchain/<chain>/validators/assets/<validator_address> add a 256x256 pixel logo.png file.

Added here https://github.com/trustwallet/developer/commit/3e806d267fe5c85997b9e1df73aa33f2346fc8c9#diff-09afa21939ecb9da5c08955b02f008d5R35


Potential bug : just uploaded POIs sometimes disappear -> Duplicated "close" POI

Though the "duplicate POIs" bug #102 is reproductible, I've seen various time this one, yet I don't know how to reproduce.
(1) Load data
(2) Add some POIs (so with (N))
(3) Upload these POIs. So far so good. No Problem.
(4) When OSM Go "refreshs" the map immediately after the upload the POIs just uploaded disappear. (The correct behavior is just removing the (N). In this case no crash, nothing special. The only problem is that the POIs are not shown anymore on the map.
I've seen this a couple of time so I mentions it here for the sake of the record. BTW to see the points again I had to clear data AND restart the app.
The end result ? The user could be confused or forgot that so he or she create again the POIs where there are. This could ultimately lead to close POIs, but not identical POIs (by contrast to #102).
I don't know if this bug is reproductible yet. A symptoma of this bug would be users that create POIs almost at the same place (since they don't see what they have already created just before).
Vive OSM Go :-)

Hi @escribis, am I correct ?

You send new POI
OsmGo "refresh" the current view
Your new POI are not displayed 😢

Maybe, the "refresh" is too fast? So the new POI are not "committed" in OSM.org then when OsmGo "refresh", the new POI are "not yet" sent by OSM API?
If so, may be we can:

delay the "refresh"
or refresh in a loop until OsmGo received the newly created POI 👎
or may be implement a mechanism to ask the API if the new changeset is committed and then refresh

I don't know yet how OsmGo is working. So @DoFabien will probably have better ideas than me...

Bonjour
I've mangage to reproduce this bug (in fact I intended to create a scenario for #102 but instead of finishing with a crash and dupicated POIs it finish with POI that are sent but no more on the screen.

(1) Loaded a lot of data. -> Crash at 31000
(2) Crash at 46000
(3) Reached 60000, enough for the test
(4) Created some lampost and uploaded them at (abour 60 as far I remember, not sure)
(5) Upload. About 15mn of slow count down. I expected a crash and #102 but nothing :-)
(6) When the map is then display some lamposts are not there. See below .

(7) reloading data -> nothing happen. Lamposts are hidden
(8) checking id. Lamposts are there. See below lamposts with red lines.

ISSUE As the user does not realize that the POIs has gone and it is likely that she/he will created them again. This results in "duplicated close  POIs".
(9) Restarting the application. As far as I remember it crashed once.
(10) Restarting the application. Now the lampost are there. See below.

NOTE: I don't know if all POIs disappear or just some of them.