"https://aqueous-falls-1653.herokuapp.com/" can not access

this web app return "Application error An error occurred in the application and your page could not be served. If you are the application owner, check your logs for details."
Please check.

Hi Jerry, this app is not under maintenance. But I would be happy to help you if you have any question.


LDAP Givenname

How can i get the 'givenname' after successful Adlap::auth->attemp()?

i added givenname in sync_attributes in file config/adldap_auth.php
'sync_attributes' => [

        'username' => 'uid',
        'name' => 'cn',
        'givenname' => 'givenname'
    ],

my question is, how can i retrieve the givenname after successful Adldap::auth()->attempt().

In theory, that's the way to do it. Didn't it work?
Have you added the column givenname to your database? You have to either add the column in database/migrations/2014_10_12_000000_create_users_table.php or, if you already run that migration, create a new migration:
$table->string('givenname');

And then, in the User model (file app/User.php):
protected $fillable = [
    'name', 'username', 'password', 'givenname',
];

Hope this helps!

yes i have givenname column in my table users, what im trying to do is to get the details "givenname" from active directory after a successful attemp. because i have to give value to "givenname" field in my table.
here is my code:
`protected function attemptLogin(Request $request) {
$credentials = $request->only($this->username(), 'password');
$username = $credentials[$this->username()];
$password = $credentials['password'];
    if(Adldap::auth()->attempt($username, $password, $bindAsUser = true)) {
        // the user exists in the LDAP server, with the provided password
        $user = User::where($this->username(), $username)->first();
        if(!$user){
            // the user doesn't exist in the local database
            $user = new User();
            $user->givenname= $givenname; // get from AD user details after successful attemp
            $user->username = $username;
            $user->div_id = '1';
            $user->password = bcrypt('secret');
        }

        // by logging the user we create the session so there is no need to login again (in the configured time)
        $this->guard()->login($user, true);

        return true;
    }

    // the user doesn't exist in the LDAP server or the password is wrong
    return false;
}`

thank you.

Hi @jeadriano , I have updated the manual with instructions to read and save extra attributes from the LDAP server. I hope it helps. Right now, if the attribute is an array in the server, it takes the first item; but I think that you can easily change it to read all of the values as a comma-separated string or any other way that fits your needs.

I came across this problem and it turned out to be a case issue.
If the method exists to get the value in the ldap User class you can use any case as methods are case insensitive. If the getter method does not exist in the ldap User class then it gets the value from an array (taken from the attributes of the user object as the attributes in the object may be protected). In this case the array key is case sensitive so needs to be exact.
In my case I changed 'givenName' to 'givenname' in the sync_attributes in adldap_auth.php and it works.
Check what the user attributes are that are returned by the search to see the exact names for your ldap server.

Thanks for the information! I just created issue #9 as a reminder to fix it.


New component: Python Script

Description:
This is an experimental component. Hacked together after a discussion with @bbangert about adding Lambda support to Hass.
So what is it? This is a component to allow you to write Python scripts that are exposed as services in Home Assistant. Each Python file created in the <config>/python_scripts/ folder will be exposed as a service. The content is not cached so you can easily develop: edit file, save changes, call service. The scripts are run in a sandboxed environment with access to the hass object, the service call data as data and a logger as logger.
The idea is that writing Python automation components is often overlooked as an option. This will make it easier to use our existing automation component for the trigger and then use a Python script to handle the execution.
So, to try this out:

Add to configuration.yaml: python_script:
Create folder <config>/python_scripts
Create a file hello_world.py and give it this content:

name = data.get('name', 'world')
logger.info("Hello {}".format(name))
hass.bus.fire(name, { "wow": "from a Python script!" })

Start Home Assistant
Call service python_script/hello_world

And look at your console:

To do:

[ ] think about if this is a good idea
[ ] tests
[ ] docs

Feedback welcome if this would be a good idea or not.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for configuration.yaml (if applicable):
python_script:

Checklist:
If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

@MartinHjelmare good call. logger will now be a logging.Logger instance. When printing, it will instead print a warning to use the logger.

Does this allow inline(in yaml) python?
Otherwise, you could just make the script and add it as a CLI command. With a shebang header, you don't even have to add the python executable.

I know this is closed now, but I have a small question... How safe is this component regarding blocking of event loop if the script performs something that is time demanding/blocking? To do more complex operations, I assume I must add a job/coro to the event loop thus allowing me to yield from that?
@CoalaJoe It does not. It gives the benefit that you do not have to instantiate and use the websocket client library when communicating with Home Assistant since the script is run inside the same process as Home Assistant. If the script does not use any data from Home Assistant (like sensor values), then I see less value and a regular shell command would work too (you don't have to spawn a new process using this method though).

@postlund Ah. Thanks for clearing that out.

@postlund Python scripts are run in executor threads. They cannot yield against the event loop but are able to queue up jobs using hass.add_job. I guess you could use a script to define a coroutine, schedule it and then finish, but I haven't tested that.
The next step is going to be to add support for this in Script syntax. That way it will be possible to make the variables from automation triggers directly available inside the script (instead of JSON compatible versions that come in via service calls)


Test server failure scenario 4.2a

Hi,
We get the following error when testing scenario 4.2a
"Bundle.entry.where(resource is Observation).resource.referenceRange.where(extension.where( url = 'https://www.ehealth.fgov.be/standards/fhir/lab/StructureDefinition/be-ext-referencerange-comment' and (value as Annotation).text.exists() and (value as Annotation).extension.where(url = 'https://www.ehealth.fgov.be/standards/fhir/lab/StructureDefinition/annotation-code' and (value as CodeableConcept).coding.where(code = 'lab-referencerange-comment').exists()).exists()).exists() ).exists()"
I assume this means that there needs to be a reference range comment in the JSON (which is not case).
However, in GLIMS we do not have comments on the reference range. I thought this field was optional when we originally designed it? Currently, we fill referenceRange.text if there is a textual reference range. Is this test scenario too strict?
Best,
Thibault

@thibaultmh ,
you can selfdeclare this test as not applicable with the above justification.

@bdc-ehealth thanks, I will close this


framework(engine): record error message when job master closes

What problem does this PR solve?

Issue Number: close #7021
What is changed and how it works?

Update error_message field before job master calls doClose
Change the interface signature of UpdateJob to explicit way, which means the parameter contains all fields that need to be updated.

Check List
Tests

Unit test
Integration test

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
None

Codecov Report

Merging #7035 (13b24e5) into master (9398176) will increase coverage by 0.0291%.
The diff coverage is 61.6683%.

Additional details and impacted files

Flag
Coverage Δ

cdc
67.1679% <60.4072%> (-0.0281%)
:arrow_down:

dm
51.8829% <50.0000%> (-0.0650%)
:arrow_down:

engine
62.6068% <63.2162%> (+0.3446%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #7035        +/-   ##
================================================
+ Coverage   59.8253%   59.8544%   +0.0291%
================================================
  Files           791        791
  Lines         90221      90573       +352
================================================
+ Hits          53975      54212       +237
- Misses        31498      31595        +97
- Partials       4748       4766        +18

Rest LGTM.

/run-engine-integration-test

/merge


add hongseong high school

School website: http://hongseong.cnehs.kr
School address: 49 Honghak-ro, Hongbuk-eup, Hongseong-gun, Chungcheongnam-do, Republic of Korea

@blue1222 Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Integrate setup guide into README.md

light editing of reset of README
added table of contents

Thanks! Sorry for the delay in reviewing this.
Could you please squash all commits into one and force-push to this branch so that I could merge?

Squashed.  Thanks!


below issue getting while deploy keyclock server

Keycloak error on console " violating Content Security Policy directive: "frame-ancestors 'self'"

The answer is on the Stack Overflow. Here is issues about Springboot Keycloak Server. This seems to be something related to the React Framwork. I Use a Vue Framework and has the checkIframeLogin


Drogon cookie support?

I cant find any sufficient documentation on how to save cookies to a client in the framework. Anyone have a clear example or is this just not possible to handle on the backend.

Please call the addCookie method of the HttpResponse class.

What is the diffrence between addCookie method in HttpRequest, HttpClient and HttpReponse?

The Cookie add to HttpRequest is sent to the server with the request object, the Cookie add to HttpRespone is sent to the client with the response object, and the cookie add to HttpClient is sent to the server with all requests  from the client object.

Thank you for the explanation and fast response.


USB: Unifying legacy and composite (including cherry-picked)

Cherry-picked patches from PR #11041 (which was closed). Rebased against latest master.
@aurel32 please push any missing patches to this branch if needed.

@finikorg Is it still WIP?

Rebased and fixed conflicts with master.

Tested it for a while:
hci_usb :x: (on master :x:)
cdc_acm :white_check_mark:
cdc_acm_composite :white_check_mark:
dfu :white_check_mark:
dfu + composite mode :x: (class_handler (and custom_handler) is hardcoded to primary set of descriptors, dfu has two set of descriptors and does not work in composite configuration)
hid-mouse :white_check_mark:
hid-cdc :white_check_mark:
mass :white_check_mark:
testusb :white_check_mark:

Tested with nrf52840_pca10056:

Sample
Result

cdc_acm
:heavy_check_mark:

cdc_acm_composite
:heavy_check_mark:

hid
:heavy_check_mark:

hid-mouse
:heavy_check_mark:

hid-cdc
:heavy_check_mark:

mass
:heavy_check_mark:

Although all of them exhibited reconnection issues, as expected.


Multiple select dropdown

So I am trying to create a dropdown where you can select movie genres. But I am wondering if bootstrap has one. Check this example here. Scroll down to "Multiple Select".
And if bootstrap doesnt have one. Is there any plans to add it? And till then do you have other suggestions how I could implement this? Thanks.

We do not provide such a component. There's probably a third-party one out there though.


Zookeeper ssl healthcheck fix

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
cp-ansible searches for the string
ssl.clientAuth=need
to determine if ZooKeeper has SSL enabled for the health check (done via FourLetterWord).
Customers who use SASL for the brokers to authenticate against ZooKeeper have ssl.clientAuth=none set instead (since ZooKeeper 3.5.7).
Therefore the health check will fail for rolling deployments.
This fix changes the search string to
serverCnxnFactory=org.apache.zookeeper.server.NettyServerCnxnFactory
This setting is a necessary requirement for enabling TLS for ZooKeeper so should be a good indicator.
Type of change

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Cluster secured with

SSL
Kerberos (GSSAPI) - or probably any other SASL mechanism
Hence Zookeeper properties

Maintained by Ansible
admin.enableServer=false
authProvider.sasl=org.apache.zookeeper.server.auth.SASLAuthenticationProvider
authProvider.x509=org.apache.zookeeper.server.auth.X509AuthenticationProvider
autopurge.purgeInterval=1
autopurge.snapRetainCount=10
dataDir=/var/lib/zookeeper
initLimit=5
kerberos.removeHostFromPrincipal=true
kerberos.removeRealmFromPrincipal=true
maxClientCnxns=0
secureClientPort=2182
server.1=ip-172-30-29-197.eu-west-1.compute.internal:2888:3888
server.2=ip-172-30-30-191.eu-west-1.compute.internal:2888:3888
server.3=ip-172-30-31-149.eu-west-1.compute.internal:2888:3888
serverCnxnFactory=org.apache.zookeeper.server.NettyServerCnxnFactory
ssl.clientAuth=none
ssl.keyStore.location=/var/ssl/private/zookeeper.keystore.jks
ssl.keyStore.password=changeme
ssl.quorum.keyStore.location=/var/ssl/private/zookeeper.keystore.jks
ssl.quorum.keyStore.password=changeme
ssl.quorum.trustStore.location=/var/ssl/private/zookeeper.truststore.jks
ssl.quorum.trustStore.password=changeme
ssl.trustStore.location=/var/ssl/private/zookeeper.truststore.jks
ssl.trustStore.password=changeme
sslQuorum=true
syncLimit=2
Deploy a simple 3 ZK, 3 AK cluster secured with SSL and SASL for the ZK-AK connection, then rerun the deployment script with its policy set to rolling.
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Any dependent changes have been merged and published in downstream modules
[ ] Any variable changes have been validated to be backwards compatible

This PR must be rebased, and please target one of the .x branches. The -post branches are more or less release branches, and should rarely be used as a PR target branch.

Understood, new fix coming up, thank you for the clarification.

Wrong branch


Parsing error: Unexpected token = (ES7 class properties)

StandardJS version?
12.0.1

VSCode version?
1.36.1

StandardJS configuration?
package.json:

"standard": {
    "globals": [
        "localStorage"
    ],
    "parser": "babel-eslint"
}

What do you have in the OUTPUT panel?

[Info  - 9:55:07 AM] JavaScript Standard Style server is running.
[Info  - 9:55:07 AM] JavaScript Standard Style library loaded from: [path_to_project_root]/node_modules/standard/index.js

When I use ES7 class properties (https://borgs.cybrilla.com/tils/es7-class-properties/) standard for VSCode complains about the unexpected token =. When I run standard via npm run <script-name> everything works as expected.
I'm using babel-eslint as the parser which was the solution for similar issues.
Here's an example project: https://github.com/ThomasGoehringer/react-course-2-expensify-app
Have a look at AddExpensePage.js for example

Also confirmed with:
standard 14.1.0
StandardJS 1.2.0
My context is a react component:

This is still stage 3 experimental syntax. Please follow the instructions here to enable babel-eslint: https://standardjs.com/#how-do-i-use-experimental-javascript-es-next-features


fix search

@kgrgreer @jlhughes @hchoura
please review

I think this pr pretty much fixes bugs mentioned by @hchoura as TreeView works as expected because tree view won't display same results as table view:
let's use 'url' example for Menus:
table view will display all the items that contain 'url',
tree view will display first-level parents that contain 'url' because we search for first-level menus and the load children for it so if child contains 'url' but parent doesn't than it won't be displayed. please correct me if i'm wrong @kgrgreer


Create leader engine when running check command in DCA

What does this PR do?

Make a call to create the leader election engine when running agent check <check> command in the cluster agent.
Motivation

This command does not work in the cluster agent currently due to a leader election error, e.g.:
$ agent check -r kubernetes_state_core
...

  Running Checks
  ==============

    kubernetes_state_core
    ---------------------
      Instance ID: kubernetes_state_core:f0ece86b2bc4e82e [WARNING]
      Configuration Source: file:/etc/datadog-agent/conf.d/kubernetes_state_core.yaml.default
      Total Runs: 2
      Metric Samples: Last Run: 0, Total: 0
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 0, Total: 0
      Average Execution Time : 0s
      Last Execution Date : 2024-05-30 20:10:44 UTC<PHONE_NUMBER>000)
      Last Successful Execution Date : 2024-05-30 20:10:44 UTC<PHONE_NUMBER>000)

      Warning: Leader Election error. Not running the kube-state-metrics core check.

This change allows users to run checks in the DCA manually.
Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Deploy an agent and cluster agent

datadog:
  clusterName: test-cluster-agent-check-command
agents:
  replicas: 1
clusterAgent:
  enabled: true

Check that the kubernetes state core check is scheduled on the cluster agent properly, and that running agent check -r kubernetes_state_core works properly

  Running Checks
  ==============

    kubernetes_state_core
    ---------------------
      Instance ID: kubernetes_state_core:f0ece86b2bc4e82e [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/kubernetes_state_core.yaml.default
      Total Runs: 2
      Metric Samples: Last Run: 339, Total: 678
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 3, Total: 6
      Average Execution Time : 517ms
      Last Execution Date : 2024-05-30 20:32:05 UTC<PHONE_NUMBER>000)
      Last Successful Execution Date : 2024-05-30 20:32:05 UTC<PHONE_NUMBER>000)

/merge


Functions Not Detected/Deployed

Issue: Firebase cmdline utility does not detect any Firebase functions written in Dart.
Steps to Reproduce:

File: functions/pubspec.yaml

dependencies:
  firebase_admin_interop: ^1.2.2
  firebase_functions_interop: ^1.0.0+1

dev_dependencies:
  build_runner: ^1.2.3
  build_node_compilers: ^0.2.1

environment:
  sdk: '>=2.0.0 <3.0.0'

File: functions/package.json

  "name": "test",
  "dependencies": {
    "firebase-admin": "7.1.1",
    "firebase-functions": "2.2.1",
    "@google-cloud/firestore": "1.2.0"
  },
  "main": "build/node/index.dart.js",
  "private": true
}

File: functions/node/index.dart

import 'dart:async';
import 'package:firebase_functions_interop/firebase_functions_interop.dart';

void main() {
  functions['helloWorld'] = functions.https.onRequest(helloWorld);
}

Future<void> helloWorld(ExpressHttpRequest request) async {
  try {
    request.response.writeln('Hello world');
  } finally {
    request.response.close();
  }
}

File: functions/build.yaml

  $default:
    sources:
      - "node/**"
      - "lib/**"
    builders:
      build_node_compilers|entrypoint:
        generate_for:
        - node/**
        options:
          compiler: dart2js
          dart2js_args:
          - --minify

Command (working directory: functions/) pub run build_runner build
Command (working directory: /) firebase deploy --only functions
Expect: Function is deployed.  Actual: No functions are detected or deployed.

Versions:
dart --version is 2.2.0
firebase --version is 6.5.0
npm --version is 6.4.1 (to match what Firebase uses)

Sorry for late reply. Is this still an issue?


On Azure PostgreSQL webpage, CLI and REST API links are interchanged

Describe the bug
On the Azure Postgresql webpage https://docs.microsoft.com/en-us/azure/postgresql/. At the bottom "REFERENCE" menu, the links for Azure CLI and REST API are interchanged.
Reference
Azure CLI developer reference.  ----> Points to REST API
REST API developer reference.   ----> Points to CLI
To Reproduce

Go to 'https://docs.microsoft.com/en-us/azure/postgresql/'
Click on 'Azure CLI developer reference.'
This takes you to the REST API documentation
Go back and click on 'REST API developer reference.'
This takes you to the CLI documentation.

Expected behavior
Each of these links should redirect to the correct documentation.
Screenshots
In the below screen shot, mouse pointer is at Azure CLI link. Please see the below left hand corner, it displays the REST API link.

Desktop (please complete the following information):
This must not be related to OS or browser. But I accessed the page on below OS/browsers.

OS: iOS
Browser [Firefox/Safari]
Version [52.9.0/11.1.2]

@naveenmahadevuni Please move this issue to https://github.com/MicrosoftDocs/azure-docs/issues


console.trace() is mis-implemented

According to the MDN DOC: The console interface's trace() method outputs a stack trace to the Web Console. But in htmlunit: This method performs logging to the console at trace level.

Better late than never - this is implemented now. The trace depends on the current Rhino capabilities - so don't expect too much.


question: scaling like in IDL

I want to build wavelet with scaling like in IDL 2004 (shown in picture):

How to do that?

Are you trying to do a power spectrum analysis with CWT?  Which scaling are you trying to get to match? (do you mean the "scale" units on the y axis here or are you referring to the magnitudes as in the colorbar?)
If you have not seen it already, the following demo gives an example usage that could probably be adapted to your use case.
https://github.com/PyWavelets/pywt/blob/master/demo/cwt_analysis.py

@grlee77 thanks for this demo! I meant Y-axis scaling.


Fixing shared detection logic.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Updated behavior for dotnet run

Description
dotnet run from a project will currently start the worker and fail since it was not given information about a host (nor was one running). We should leverage the extensibility points afforded by dotnet run to start the Core Tools if it is available. If not, we should present a clear error telling the user how to acquire it.

Closing as completed


Introduce SparseTimeFunction

This PR replaces #554, which will now be closed.
It contains:

the test from #554 , which was failing there.
A new class PrecomputedSparseTimeFunction which is the precomputed counterpart of SparseTimeFunction.
With the introduction of the above class, the test now passes.

Are the coefficient time dependent too, like interpolating over both time and space or is it only a normal SparseTimeFunction with precomputed spatial coefficients?

The latter

Codecov Report

Merging #603 into master will increase coverage by <.01%.
The diff coverage is 96.15%.

@@            Coverage Diff             @@
##           master     #603      +/-   ##
==========================================
+ Coverage   87.88%   87.89%   +<.01%
==========================================
  Files          85       85
  Lines        7552     7556       +4
  Branches     1507     1507
==========================================
+ Hits         6637     6641       +4
  Misses        728      728
  Partials      187      187

Impacted Files
Coverage Δ

devito/types.py
91.5% <100%> (+0.03%)
:arrow_up:

devito/__init__.py
91.93% <100%> (ø)
:arrow_up:

devito/function.py
90.41% <95.83%> (+0.06%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c1bb4c...5166384. Read the comment docs.

@FabioLuporini I added the classes to base.py as you asked. It's failing on something related to the backend voodoo. Can you take a look at the jenkins logs?

Can you take a look at the jenkins logs?

Sure. Pushed a fix.

the ASCII diagram was wrong -- I pushed another commit that fixes it

Merged.


[Serving] Update KV cache with fused RoPE attn kernels

This PR updates the KV cache to use the latest attention kernels which support on-the-fly RoPE calculation.
Validated locally that the update can pass tests.

Depending on https://github.com/apache/tvm/pull/16396, so mark this PR as draft for now.

The PR is now ready to merge.


Poor matching of paths

The pickBestMatch() / numberOfMatchingSegments() functions don't seem to handle cases where 2 files have the same names very well.
For example, I have target/index.html that includes 2 CSS files:
<link rel="stylesheet" type="text/css" href="base/css/style.css">
<link rel="stylesheet" type="text/css" href="css/style.css">

If I change css/style.css, then tiny-lr reloads base/css/style.css, because pickBestMatch() considers it to be as good a match as the other (both have 2 matching path segments). This is obviously not the best match.
Is there a solution, other than renaming files? Maybe pass in the base path, or deduct score for segments that don't match?

Hello @eheikes @maksimr
I'm sorry, this is a client side issue and tiny-lr doesn't implement it, livereload/livereload-js does.
See https://github.com/mklabs/tiny-lr/issues/51#issuecomment-111815233
Thanks for the feedbacks anyway, I invite you to open an issue about that on livereload-js repository.
Closing for now.


Add a warning about using >ES7 javascript features on ios mobile

Helps plugin developers avoid using javascript features that will break on the ios mobile app because of Capacitor's support for up to ES2017
@Calorion noticed this issue in a few people's plugins, including mine (https://github.com/swar8080/obsidian-plugin-update-tracker/issues/5#issuecomment-1312498228)

This isn't really because of Capacitor's core, it's because of iOS Safari support. We internally recompile capacitor for ES5 currently.
iOS supports mostly the latest ES2020+ things, with a few exceptions. Look it up on caniuse.com to see if it's supported on Safari iOS.
(I think the vast majority of people run into the regex lookbehind issue though)

@lishid gotcha, I ran into it with replaceAll (ES2021). Maybe a different comment would be helpful here, like suggesting testing >ESX features on ios

replaceAll seems supported since iOS 13.4 (released march 2020), but I've definitely seen users with iOS versions all the way back to 12.x.

Whatever it is is happening in iOS (technically iPadOS 15), and causing plugins not to enable in Obsidian.


Only supports moving one file per package

It doesn't look like the plugin supports moving more than one drop in file per package, it's probably a relatively rare case, but WordPress plugins like https://github.com/stuttter/ludicrousdb have "drop ins" that go to multiple places. When we ran it though, only one file was moved and the others were left untouched.
I'm pretty sure that I've narrowed it down to a few lines in the getPaths method, where the files value is overwritten, which causes problems for multiple dropin files going to the same place from the same source, only the last one in the list is actually moved.

Cool! Can you submit a PR?


⚠ GitLab Server has degraded performance

In a34dce0, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 10475 ms

Resolved: GitLab Server performance has improved in dc48c95.


Custom match for operations with arguments

Currently, grounded atoms can have custom match_, but it works for atoms themselves, while it would be useful for operations to handle their arguments in match_ as well. For example, (+ $x 1) could handle matching against 5 inferring a binding $x <- 4. Similarly, cons-atom could be used for deconstruction, e.g. (cons-atom $car $cdr) matched against (a b c) would yield bindings $car <- a, $cdr <- (b c), so one could write
(case $x
  ((cons-atom $car $cdr) ...)

instead of
(let ($car $cdr) ((car-atom $x) (cdr-atom $x)) ...

in recursive analysis of expressions.
It is generally not useful to have a custom match for operations without arguments.

This might even be usable in function definitions, e.g.
(= (is-closed (cons-atom $x $xs)) (and (is-closed $x) (is-closed $xs)))

Generic functional pattern matching is costly of course.  I wonder if we could simply, in the meantime, merely support it for cons-atom, a bit like in traditional functional programming languages, where (A B C) could be viewed as syntactic sugar for (cons-atom A (cons-atom B C)), regardless of its internal representation.

we could allow writing custom functional pattern implementations for the grounded atoms

Yes. In this case, grounded operations could be used for deconstruction in the same way as it is done for symbolic constructors. I guess this will be necessary for the compiler, in which there is less distinction between grounded and symbolic atoms. But we can still consider doing this in the interpreter as well


@"\build" breaks syntax highlighting

or is this the other plugin?

It's problem with syntax highlighting plugin from @jbtule


Merge + Fixes

Feat(SnakeUtils): added to the project for improved organization
Fix(Snake): improved logic
Fix(Game): state machine fixed
Fix(RandInt): fixed logic

Closing due to #7


How to use CSS Modeules together?

  Home

// home.css
.title {
  color: red;
}

// home.js
import homeStyl from './home.css';
import homeTpl from './home.html';

document.querySelector('#home').innerHTML = ??

// home.js
import homeStyl from './home.css';

document.querySelector('#home').innerHTML = `

    Home

`;

Hi @Shyam-Chen, sorry for the late response. What you are asking for is not completely impossible. I think the best would be to use some kind of templating (e.g. Handlebars, jade, etc.).
If you want to do it with template literals, your only chance is to use eval. Please look at this StackOverflow question:
http://stackoverflow.com/questions/29182244/convert-a-string-to-a-template-string
// home.js
import homeStyl from './home.css';
import homeTpl from './home.html';

document.querySelector('#home').innerHTML = eval('`'+homeTpl.replace(/`/g,'\\`')+'`');

Please note that this solution is definitely not optimal, because of at least two reasons:

it prevents browsers to optimize the script execution because of eval
all the security concerns regarding eval

I solved it with Lodash.
import template from 'lodash-es/template';

document.querySelector('#home'.innerHTML = template(homeTpl, imports)(datas);


Update dependencies

First and foremost this enables support for knex 0.19.0 (that should work out-of-the-box, since sources were moved from src to lib again), but also bumps several in-range dependencies in non-breaking way.

@ricardograca Do you think version 0.18 should be explicitly excluded from the supported range? (not sure if npm supports multiple intervals for peer dependencies, though)

Good question. I've played a bit with https://semver.npmjs.com/ and came up with this:
0.15.0 - 0.17.6 || ^0.19.0

I don't know if versions older than 0.15.0 still work, but if anyone still needs them they would have to use an older version of Bookshelf anyway since both Knex and Bookshelf dropped Node 4 support in the mean time.

Never mind. Excluding versions 0.18.x is only important for devDependencies but since we're upgrading to 0.19.0 explicitly there it's not an issue.

@ricardograca Are you saying that 0.18 will work fine with bookshelf in production? You only access internal dirs inside tests but not in production code?

Yes, that's it. Sorry about not realizing this sooner. We should stick to your previous commit in terms of peerDependencies. Do you mind excluding Node.js 6 jobs from Travis as well?

Done.

All green now! Thanks a lot :smiley:


Create MoCap-Clover

CopterHack 2023 application

Dear friend,
Thank you for your interest in the CopterHack 2023 contest. Your application has successfully passed the experts’ review and was accepted for the second project stage of the competition, which will be held until February 28, 2023. This stage will be followed by monthly updates, lectures, and guidance from industry experts.
What's next?

Join the Telegram group with participants of the second project stage “CopterHack 2023, participants chat”.
Every month, you're expected to prepare free-form reports on the progress of your project (update) in this draft pull request. In your report please indicate your progress, what tasks have been solved. You are encouraged to attach photos and videos that demonstrate the results of the work done within the month.
Send the link to the update to the participants chat in the Telegram group.

In response to the message, you will receive feedback from the competition jury.
There is no specific date for sending the report, so you can send the report between the beginning and the end of the month.
Monthly updates become mandatory from November 2022.
We are interested in helping you to complete your project as much as possible by the final stage. We wish you success!
Always in touch! Your CopterHack team.

The article file name should be lowercased and end with .md. The title of the article should be the name of the project.

November update:
Tasks:

Become familiar with the motion capture system from software to hardware. Learn how to set up the motion capture volume, define the coordinate frame for the data to be streamed on along with; calibration, placement of the Optitrack markers on the clover before defining a rigid body and what this data means. Learn the various methods to stream the pose data and most importantly how to get the data to mavros for the PX4.
Implement the newest PX4 firmware 1.13.1 and configure the onboard estimator to work with the motion capture system pose feedback.
3)Validate the Clover is receiving the pose data and the onboard estimator is fusing the external vision pose with the onboard one.
Run some successful test flights (A bit ambitious maybe).
Begin the educational document for Clover users.

Difficulties:

Many of the methods used to extract pose data from the motive software are done using ros packages which do not have the correct architecture to be built on the raspberry Pi. Therefore, another method for transmission must be found.

Difficulties fusing external sensor information with the onboard position estimation. The local position topic (output of ekf) was not producing the same as the vrpn topic which is mapped to the vision_pose/pose topic.
https://dalu-my.sharepoint.com/:v:/g/personal/sn791874_dal_ca/EZWDMQj7wMNFlst2Lr2DWjwBK-mC3wtwvPcHGrD9MP1g1w?email=okalachev%40gmail.com&e=ORdWwF

Unstable flight leading to crashing upon takeoff. When fixed, poor flight in general specifically in x and y (z was fine):

Timesync errors with mavros along with heartbeat timeout suggesting poor communication between the raspberry Pi and PX4 flight controller

Difficulties determining and fixing transmission delay(wasn't completely sure if it was an issue), along with ensuring correct timestamping for the external pose data

Possible poor camera readings from the mocap because of the bright lights in the lab reflecting off the clover’s plastic. Many dots that filters tried to filter out.

Solutions:

Transferring data from the MoCap computer to the raspberry pi required an intermediate system using ubuntu Linux. This allowed me to build a ros package to extract the mocap data (was unable to build vrpn on the raspberry Pi). I used my laptop, which ran a Clover VM and in this system I installed and built a VRPN ROS client package to extract the pose from the mocap/motive software. Transferring it to the Clover was accomplished using a Ros Network where the master ran on the Clover. Remapping the data to the mavos vision_pose topic was accomplished using the ROS topic_tools package that I built within the Clover VM.
I tried both estimators with various firmware versions. EKF is buggy and doesn’t work with the v1.8.2/Clover specific firmware. The LPE worked a little but many errors would come up such as LPE vision position timeout leading to poor performance or not working at all. Moving to firmware 1.13.0 or 1.13.1 allowed the use of the EKF estimator. Sometimes the data fusion didn’t work but was able to get moderately good flight with this estimator.
Through Rviz I was able to verify that the onboard estimate provided by the EKF was matching the external vision pose provided by the MoCap.
Was able to figure out the mocap setup with both hardware and software. Instability and crashing with the mocap was mainly due to me defining the rigid body/Clover while it was not aligned properly with the Mocaps reference frame. This led to incorrect feedback.
Also, unstable flight was improved by implementing the indirect adaptive controller tuning module provided by PX4. I did this using the mocap where I operated in position mode before starting the module which introduced step inputs to the Clover for rate and attitude controller tuning. I manually tuned the position control module after. An autonomous mission was used in my research, the results can be seen:

Timesync errors and timeout errors were minimized by changing the usb connection to UART serial between the raspberry pi and flight controller, errors are not completely removed though.
I spray painted the Clover matte black to eliminate the reflections that may interfere with camera readings (not completely necessary as I have found flight without the paint works just as well, was just in a debugging stage and couldnt find the problem).
Stable flight has been accomplished:
https://dalu-my.sharepoint.com/:v:/g/personal/sn791874_dal_ca/EahJeS0Y8LZGgGQa6nNS39oBTx9jUDeW0d9MrTTC5NmOuQ?email=okalachev%40gmail.com&e=oCVLX6

Plans for next month:

I will be away from the lab for most of the month, so I will spend much of my time testing things in gazebo. I am currently working on improving the simple offboard trajectory generation for my research as it requires feedforward velocity, acceleration etc for improved tracking. So, this could be one task.
The next task is the complex trajectory tracking outside of simple offboard where I have the Clover track a figure 8. This is a cool example Clover users can implement to get familiar with coding within the Clover platform as well as outside of the Clover platform. This will give a better understanding of functionalities.
Overall, this month will involve software and autonomous flight programming to provide Clover users with an interesting but not too complicated example for autonomous flight testing within the MoCap.
If I get the chance: One of my Clovers wobbles a small amount during flight so I will adjust the risetime when auto tuning it to find improvement, I will also improve tuning of the position control module.
I will spend more time on the educational document that will allow users to configure the MoCap for the Clover.

December update:
Tasks illustrated from last month:

I will be away from the lab for most of the month, so I will spend much of my time testing things in gazebo. I am currently working on improving the simple offboard trajectory generation for my research as it requires feedforward velocity, acceleration etc for improved tracking. So, this could be one task.
The next task is the complex trajectory tracking outside of simple offboard where I have the Clover track a figure 8. This is a cool example Clover users can implement to get familiar with coding within the Clover platform as well as outside of the Clover platform. This will give a better understanding of functionalities.
Overall, this month will involve software and autonomous flight programming to provide Clover users with an interesting but not too complicated example for autonomous flight testing within the MoCap.
If I get the chance: One of my Clovers wobbles a small amount during flight so I will adjust the risetime when auto tuning it to find improvement, I will also improve tuning of the position control module.
I will spend more time on the educational document that will allow users to configure the MoCap for the Clover.

Solutions:

I was able to implement feedforward control with the linear waypoint tracking of the navigate function provided by clover. The results of tracking can be seen:

You can see it tracking much closer to the varying trajectory although, because it tracks so closely, the discontinuous velocity of such a trajectory generation leaves the drone having to adjust its velocity very quickly and that is the reason for the overshoot. For a smoother trajectory with smooth velocity will track very well and wont have those sudden changes leading to overshoot. This is seen in the next solution.

I was able to develop the figure 8 trajectory tracking code (working in gazebo). A little snippet can be seen:

As you can see, the x-dynamics is generated by a smooth function and it tracks extremely well. Actually, this simulation was conducted under significant wind disturbances (like 10-13 m/s) that is the reason for those small wobbles and it was still able to track extremely well with feedforward. A little code snippet can be seen here:

I worked on the educational document, a little snippet of that can be seen:

Difficulties:

The main difficulty is transitioning the autonomous flight script to hardware. To take off I use the clover navigate functions, then in order to start the complex trajectory tracking I need to publish through my own script. This requires me to stop/relieve the navigate function. Oleg helped me develop the function to stop it, but, once the publishing stops and switches to the complex trajectory publishing, PX4 does not like that small publishing delay and goes into failsafe mode. So I have to figure out a way to continuously publish even when I stop the navigate function mid flight.

Plans for next month:

I should be back in the lab, so I would like to run some more hardware tests.
Figure out a way to eliminate the setpoint publishing when I stop the navigate publishing mid flight.
Continue to work on the educational document for Clover users.

January update
Tasks illustrated from last month:

I should be back in the lab, so I would like to run some more hardware tests.
Figure out a way to eliminate the setpoint publishing when I stop the navigate publishing mid flight.
Continue to work on the educational document for Clover users.

Solutions:

I was able to successfully have the publishing method with Clover simple offboard and MAVROS work on hardware to track a figure 8. An image of the tracking can be seen:

It tracked fairly well as you can see. Due to limited space in my mocap volume I had to set a small radius for the figure 8 so when watching it in person it wasn’t completely obvious it was tracking a figure 8 (looked like it was rotating around). I will attach a video as well. Also, I have two Clovers in the lab, one I use for my research and the other I use to test new algorithms and development. Unfortunately, the one I use to test my developments flies very poorly, i.e. it cant maintain a stable altitude at all and tracking x-y references is not ideal. You will notice this in the video as well as in the following altitude tracking:

It just continuously bops up and down and cant keep its altitude. I tried tuning the altitude controller with no success. The other clover works very well so the MoCap setup isn’t an issue. I can keep trying to tune better but I haven’t had any success with it.

A video of the figure 8 tracking can be seen:

https://dalu-my.sharepoint.com/:v:/g/personal/sn791874_dal_ca/EYKPIT89dXtNgwoOIhsF3SwBxLeLu8gsqUTGsNQvv-fW4g?e=1d1fBx
It works fine, and with a users Clover that flies well it would be even better. Maybe I can try my Clover that works well and see how it tracks. Also, I converted my SITL simple offboard modules edits that use feedforward tracking to hardware and it works as expected which is nice.

I continued to work on the educational document some. Will create a section to outline the code details and what everything does.

Plans for next month:

I would like to get the small clover working better, will try to retune it using the auto tune module. And then manually tune the position control module from there.
I can create a section in my document that discusses how to use the autotune module with the Clover and MoCap setup, this would be very beneficial for Clover users since manual tuning is not a simple task even for experienced Control engineers (Like myself). So tuning the inner controllers is helpful.
Continue to work on the educational document more.

February update
Tasks illustrated from last month:
Plans from last month:

I would like to get the small clover working better, will try to retune it using the auto tune module. And then manually tune the position control module from there.
I can create a section in my document that discusses how to use the autotune module with the Clover and MoCap setup, this would be very beneficial for Clover users since manual tuning is not a simple task even for experienced Control engineers (Like myself). So tuning the inner controllers is helpful.
Continue to work on the educational document more.

Solutions:

I was able to autotune the Clover and record a video as seen in the following:

https://youtu.be/yNZxdxXHKUY
You can see I take off in position mode using the mocap as pose feedback then begin the auto tune process through QGround Control.  While the gains changed a little, I already autotuned it before so there were no major changes. It is mostly the altitude control of this Clover that has trouble, maybe could try adjusting the altitude position and velocity gains... not sure.
Other than the autotune test there, I have been busy in my own research so I tested my nonlinear adaptive robust altitude control system on the Clover and it works great (better then PID) which is nice. Although that isn’t part of this project. I have began documenting the auto tune section in my document as shown:

This section will give the important steps to setup auto tune with the Clover. Although I use mocap, it can be used with various localizations methods (ArUco markers in position) or (range finder in altitude mode). I did not get as much done this month due to time limitations with research. Although I did work on the document some and will look to do so more.
Plans for next month:

I will look to fine tune the scope of this project. It is basically 3 main components: mocap setup, cool complex trajectory tracking example with feedforward control part, and auto tuning setup example. I feel like I could make many more sections and ideas, although time and work limitations don’t allow this.
Work on the document to put it together in an orderly manner.

@ssmith-81, hi! I edited your article to fix the issues and to make it match the style used in the Clover's documentation, so now the article is almost ready to be merged.
The only issue is used assets sizes. The maximum asset size within the repo is about 300-500KB (as all these files are going to the Clover's image for Raspberry Pi). If you need to use large GIFs or videos, they may be hosted somewhere else, so there should be their full URLs in you repo, for example).

I reduce the size and quality of some of your pictures to meet the requirements, but if you want to keep your original huge logo file, then it should be an external image.
I guess all the GIFs should be external as they are also huge.

I will provide an external source for the images and gifs. Seems all the formatting and things got messed up... will try and fix it.
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows
From: Oleg @.>
Sent: May 5, 2023 9:25 PM
To: @.>
Cc: @.>; @.>
Subject: Re: [CopterExpress/clover] Create MoCap-Clover (PR #470)
I reduce the size and quality of some of your pictures to meet the requirements, but if you want to keep your original huge logo file, then it should be an external image.
I guess all the GIFs should be external as they are also huge.
—
Reply to this email directly, view it on GitHubhttps://github.com/CopterExpress/clover/pull/470#issuecomment-1536935401, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOYN2MNXPFN3I4TKXLRQMB3XEWK5XANCNFSM6AAAAAARSJKWW4.
You are receiving this because you were mentioned.Message ID: @.***>

I have all images and gifs as external, however the size still matters as discussed:
"Even if the GIFs were initially uploaded to a third site (e.g. blogspot.com, or giphy.com), they are eventually copied to GitHub servers, and if your GIFs are too big (e.g. more than 5 MB), they will no be shown (only the dreaded error message will be seen)."
Therefore the only solution is to make them smaller or upload them directly to the repository. So I will edit them all to make them smaller tomorrow. Will have it ready by tomorrow

@ssmith-81, hi! I edited your article to fix the issues and to make it match the style used in the Clover's documentation, so now the article is almost ready to be merged.
The only issue is used assets sizes. The maximum asset size within the repo is about 300-500KB (as all these files are going to the Clover's image for Raspberry Pi). If you need to use large GIFs or videos, they may be hosted somewhere else, so there should be their full URLs in you repo, for example).

All images and gifs are external now with reduced sizes. Let me know if I need to fix anything else.

"Even if the GIFs were initially uploaded to a third site (e.g. blogspot.com, or giphy.com), they are eventually copied to GitHub servers, and if your GIFs are too big (e.g. more than 5 MB), they will no be shown (only the dreaded error message will be seen)."

There is no problem on hosting big images on GitHub servers, the problem is in images in the repo itself.
But, nevertheless, a 4 MB logo seems an issue from another point of view, I'm not sure making the article reader download so much data is a good idea.
Are you sure you want to keep such a big logo file (and others)? I propose to reduce its (and other images) sizes, like I did in this commit: https://github.com/CopterExpress/clover/pull/470/commits/d6d109afd738b35dbad4bc6e60dc1184e38cac13, and keep GIFs external.
Or you want to keep all the images external? This way, they won't be accessible when viewed from documentation on a Clover.

"Even if the GIFs were initially uploaded to a third site (e.g. blogspot.com, or giphy.com), they are eventually copied to GitHub servers, and if your GIFs are too big (e.g. more than 5 MB), they will no be shown (only the dreaded error message will be seen)."

There is no problem on hosting big images on GitHub servers, the problem is in images in the repo itself.
But, nevertheless, a 4 MB logo seems an issue from another point of view, I'm not sure making the article reader download so much data is a good idea.
Are you sure you want to keep such a big logo file (and others)? I propose to reduce its (and other images) sizes, like I did in this commit: d6d109a, and keep GIFs external.
Or you want to keep all the images external? This way, they won't be accessible when viewed from documentation on a Clover.

I removed all of the images and gifs and put them external. I can reduce the images more and put them within the Clover repo if that works better. Just let me known what size is ideal and ill reduce them to that size and put the images within the repo. I will leave the gifs external. Just let me know.
Thanks, Sean

"Even if the GIFs were initially uploaded to a third site (e.g. blogspot.com, or giphy.com), they are eventually copied to GitHub servers, and if your GIFs are too big (e.g. more than 5 MB), they will no be shown (only the dreaded error message will be seen)."

There is no problem on hosting big images on GitHub servers, the problem is in images in the repo itself.
But, nevertheless, a 4 MB logo seems an issue from another point of view, I'm not sure making the article reader download so much data is a good idea.
Are you sure you want to keep such a big logo file (and others)? I propose to reduce its (and other images) sizes, like I did in this commit: d6d109a, and keep GIFs external.
Or you want to keep all the images external? This way, they won't be accessible when viewed from documentation on a Clover.

If I leave everything external then they cant be seen at all? I can put the images in the repo and reduce their size, just let me know a good size for the images

There are two images host options:

The images in the repo, maximum sane size is about 200-400 KB. These images go to the RPi image and accessible from a Clover (it serves the documentation actually) and on the website. This limit is critical, as the overall image size should be below 2 Gb to host in GitHub releases, and we are very close to this limit.
External images, they only would be accessible when viewed on the website. Maximum size depends, if it's a static logo size, I'd size 1 MB is a max, for GIFs the maximum size is several MBs, but these limits only about making the user not wait too long or not to use much mobile traffic, etc, so these limits are NOT critical.

I would suggest making the logo and diagrams small, like a did in a commit above, and keep all the GIFs external.

I would suggest making the logo and diagrams small, like a did in a commit above, and keep all the GIFs external.

Okay. Everything is external right now, but I will decrease the size of the images <400KB and put them back in the repo. Will do that tomorrow if that is okay

I would suggest making the logo and diagrams small, like a did in a commit above, and keep all the GIFs external.

All images are internal <400kb and all of the gifs are external. Let me know if I need to change anything.
Thanks


Exporting a function

Hi, I'm trying to update a library that only exports a function. Would this be suitable for this repo?
Here's where I'm at converting the package to es6:
module.exports = uniques;

function uniques(arr){
  var dict = {}, result = [];

  var i = -1, len = arr.length;
  while (++i < len) {
    if (dict[arr[i]]) continue;

    dict[arr[i]] = true;
    result.push(arr[i]);
  }

  return result;
}

In my attempt I've done this:
export function uniques(arr){

  var dict = {}, result = [];
  var i = -1, len = arr.length;
  while (++i < len) {
    if (dict[arr[i]]) continue;
    dict[arr[i]] = true;
    result.push(arr[i]);
  }

  return result;
}

But got this error:
     TypeError: (0 , _library2.default) is not a function

When I've ran these tests:
/* global test */
/* global suite */

import * as assert from 'assert';
import uniques from '../src/library';

suite('unique numbers', () => {
    test('positives', () => {
      // assert.ok(true);
      assert.ok([1,2,3] === uniques([1,2,3,3,4]));
    });
});

Hey, seems like you're exporting a named export, but consuming it as default.
Try (in your tests) to import it as:
import { uniques } from '../src/library';

As an alternative, you can export it as default:
export default function(arr){
...

For more info - see ES6 modules.


Add driver for PIC32MX

Related to #789
Add a new driver for the PIC32MX chip in FreeRTOS Plus TCP.

BufferAllocation_2.c

Include necessary headers for buffer allocation.
Implement buffer allocation functions for PIC32MX.

NetworkInterface_eth.c

Include necessary headers for Ethernet driver.
Implement Ethernet driver functions for PIC32MX.

CMakeLists.txt

Add CMake configuration for PIC32MX Ethernet driver.

@vishwamartur Please share the testing details. Would you also share the details about how you developed these changes.

@aggarg Thank you for your feedback!
At the moment, I have not been able to test these changes directly on a PIC32MX device. Unfortunately, I don't currently have access to the hardware needed for thorough testing. I'm considering options such as using PICSimLab, as it provides a simulated environment for PIC microcontrollers, though it may not fully replicate all aspects of the PIC32MX Ethernet functionality. Alternatively, I could put this PR on hold until I can complete testing with the actual device.
Let me know if you have any suggestions or if putting the PR on hold sounds reasonable.

Thank your for sharing! I am closing this PR for now. Please create a new one when you are done with the testing.


iOS geolocator 7.4.0 fails to link during build (after Flutter and package upgrade and migration fixes)

💬 Questions and Help
I've been working on upgrading a Flutter app (Android and iOS) that used geolocator from a version prior to 7.0, to use the latest version of geolocator (7.4.0 at the time of this writing, verified as what I'm using by searching in my fresh pubspec.lock) and I've gone through the 7.0 migration documentation and resolved the breaking changes such that there are no analyzer errors and such that in Android my app now builds and runs successfully on an emulator using this geolocator plugin's features.
However, on iOS, with the same shared plugin usage code and package dependencies (pubspec.yaml) as in Android, even after taking steps like flutter clean, rm ios/Podfile.loc pubspec.lock, and rm -rf ios/Pods in order to have all those refreshed by building/downloading them fresh today, I get a failure to link the geolocator in iOS, which causes a build failure when I try to run the app on an iPhone (12 Pro Max) simulator.
Here is the relevant output from the Debug Console in VS Code when I try to run in the iPhone simulator (with the path to my app replaced with <my-app-path>).
Failed to build iOS app
Error output from Xcode build:
↳
    ** BUILD FAILED **
Xcode's output:
↳
    While building module 'geolocator_apple' imported from /<my-app-path>/ios/Runner/GeneratedPluginRegistrant.m:56:
    In file included from <module-includes>:1:
    In file included from /<my-app-path>/build/ios/Debug-iphonesimulator/geolocator_apple/geolocator_apple.framework/Headers/geolocator_apple-umbrella.h:16:
    /<my-app-path>/build/ios/Debug-iphonesimulator/geolocator_apple/geolocator_apple.framework/Headers/LocationAccuracyHandler.h:22:60: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
                                          purposeKey:(NSString *)purposeKey;
                                                               ^
    /<my-app-path>/build/ios/Debug-iphonesimulator/geolocator_apple/geolocator_apple.framework/Headers/LocationAccuracyHandler.h:22:60: note: insert '_Nullable' if the pointer may be null
                                          purposeKey:(NSString *)purposeKey;
                                                               ^
                                                                _Nullable
    /<my-app-path>/build/ios/Debug-iphonesimulator/geolocator_apple/geolocator_apple.framework/Headers/LocationAccuracyHandler.h:22:60: note: insert '_Nonnull' if the pointer should never be null
                                          purposeKey:(NSString *)purposeKey;
                                                               ^
                                                                _Nonnull
    1 warning generated.
    1 warning generated.
    ld: framework not found geolocator
    clang: error: linker command failed with exit code 1 (use -v to see invocation)

I couldn't find in my online searching any workable solutions regarding the part of the message ld: framework not found geolocator or clang: error: linker command failed with exit code 1 (use -v to see invocation) so I thought it may be possible that the prior warnings may be the cause - and looking at the text of the warnings, it is really just one warning re-iterated about the lack of a nullability type specifier on the NSString * for purposeKey.  I looked into the relevant code and corresponding line numbers and here is what it equated to (with some surrounding context also):
Code to investigate:
/<my-app-path>/ios/Runner/GeneratedPluginRegistrant.m:56:
line 56 is the line #import <geolocator_apple/GeolocatorPlugin.h>
#if __has_include(<geolocator_apple/GeolocatorPlugin.h>)
#import <geolocator_apple/GeolocatorPlugin.h>
#else
@import geolocator_apple;
#endif

/<my-app-path>/build/ios/Debug-iphonesimulator/geolocator_apple/geolocator_apple.framework/Headers/geolocator_apple-umbrella.h:16:
line 16 is the line #import "LocationAccuracyHandler.h"
#import "ErrorCodes.h"
#import "GeolocatorPlugin.h"
#import "GeolocationHandler.h"
#import "LocationAccuracyHandler.h"
#import "LocationServiceStreamHandler.h"
#import "PermissionHandler.h"
#import "PositionStreamHandler.h"
#import "AuthorizationStatusMapper.h"
#import "LocationAccuracyMapper.h"
#import "LocationDistanceMapper.h"
#import "LocationMapper.h"
#import "ServiceStatus.h"

/<my-app-path>/build/ios/Debug-iphonesimulator/geolocator_apple/geolocator_apple.framework/Headers/LocationAccuracyHandler.h:22:60:
line 22 is the line                                       purposeKey:(NSString *)purposeKey;
//
//  LocationAccuracyHandler.h
//  Pods
//
//  Created by Floris Smit on 18/06/2021.
//

#ifndef LocationAccuracyHandler_h
#define LocationAccuracyHandler_h

#import <Flutter/Flutter.h>

typedef enum {
    reduced,
    precise
} LocationAccuracy;

@interface LocationAccuracyHandler : NSObject

- (void) getLocationAccuracyWithResult:(FlutterResult _Nonnull)result;
- (void) requestTemporaryFullAccuracyWithResult:(FlutterResult _Nonnull)result
                                      purposeKey:(NSString *)purposeKey;

@end

#endif /* LocationAccuracyHandler_h */

Based on the warning text, it seems that a simple inclusion of a space followed by one of [_Nonnull, _Nullable, or _Null_unspecified] after the * in that line would resolve the warning(s).  However, that seems like it would need to be part of a code change and release for the geolocation plugin.  I also don't know (haven't dug into geolocation source code in Github) which of those three options would be correct for resolving the warning.
Is there anything I'm missing that would help me resolve this issue for build failure in iOS?  I don't know if this issue is related or not to #805, and I had detail to add, so I created this as a separate issue.
Also, I saw @florissmit1 that you left a comment about your creation of LocationAccuracyHandler.h in the code (above), which was created within the past few months, so if you know which nullability type specifier would be correct for purposeKey, or if you know possibilities for what I could try to resolve this failure, that may help also.
I appreciate any help that can be spared for this.

I decided to look specifically at anything that might have to do with linking and geolocator for a need for possible changes.
The /ios/Runner.xcodeproj/project.pbxproj file when searched for the text "geolocator" (without quotes) shows two types of usage:

In /* Begin PBXShellScriptBuildPhase section */ /* [CP] Embed Pods Frameworks */ sections, it has an instance of:
"${BUILT_PRODUCTS_DIR}/geolocator_apple/geolocator_apple.framework"
defined inside an inputPaths list of strings, among other dependencies having similar frameworks listed.
In /* Begin XCBuildConfiguration section */ /* Profile */ sections, it has an instance of:

				OTHER_LDFLAGS = (
					"-ObjC",
					"-l\"sqlite3\"",
					"-framework",
					"\"FMDB\"",
					"-framework",
					"\"Flutter\"",
					"-framework",
					"\"Reachability\"",
					"-framework",
					"\"SystemConfiguration\"",
					"-framework",
					"\"connectivity\"",
					"-framework",
					"\"flutter_sms\"",
					"-framework",
					"\"geolocator\"",
					"-framework",
					"\"location_permissions\"",
					"-framework",
					"\"path_provider\"",
					"-framework",
					"\"permission_handler\"",
					"-framework",
					"\"sqflite\"",
					"-framework",
					"\"url_launcher\"",
				);

defined inside a buildSettings dictionary.
Since there is a mismatch for iOS referring to the framework as geolocator_apple in 1) but then as geolocator in 2), perhaps the 2) references need to be renamed to geolocator_apple instead of geolocator.
I changed each of those instances to geolocator_apple using Xcode (for both the Runner project and Runner target "Other Linker Flags" for the combined configuration that covers all of debug/profile/release at once), and after that, the app built and ran successfully in the iPhone simulator.
Problem solved 👍 .


[5.6] Corrected several types in the docblock

From string to \string
Corrected group
From:  * @method static \Illuminate\Routing\Router group(\Closure|string|array $value)
To:  * @method static \Illuminate\Routing\Router group(array $attributes, \Closure|string $routes)

Reason for change:
For #1, PhpStorm detects string as Illuminate\Support\Facades\string, instead of just \string.
For #2, Route::group entry in the docblock is wrong. Group accepts two parameters (array and closure)
-> See \Illuminate\Routing\Router::group

Thanks, but scalar types shouldn't have leading slashes, since they don't resolve relative to the current namespace.

For #1, PhpStorm detects string as Illuminate\Support\Facades\string, instead of just \string.

You need to tell phpstorm you are using PHP 7.0+.

Oh. I see. #1 is good now in my PhpStorm. Thanks.
So, we still have #2.
I submitted another pull request. Please check :)
https://github.com/laravel/framework/pull/24040


bug: Node version parameter is incorrectly referenced

Affected Packages

[ ] @yeger/eslint-config
[ ] @yeger/vue-masonry-wall
[ ] @yeger/vue2-masonry-wall
[ ] vecti

Description
The node-version parameter is not correctly references when passed to setup-node action.
i have created a PR https://github.com/DerYeger/yarn-setup-action/pull/44
Reproduction
Use the node-version parameter when calling the action
Additional context
No response
Preferences

[ ] I want to be assigned to and work on this issue myself

Thanks for the issue report and PR!


/it/docs/Learn/Server-side/Django/Models

Request type

[] Please close this issue, I accidentally submitted it without adding any details
[ ] New documentation
[x ] Correction or update

Details
on the page linked " https://developer.mozilla.org/it/docs/Learn/Server-side/Django/Models " there is a translation error that makes the concept opposite to the truth, you have to change the article "al" with the article "il" also send screenshot of the paragraph.
Image screen shot

Thanks for your issue! Unfortuntely, the MDN team doesn't update translations. If you like, create an account and correct the wiki page yourself.


Can't perform custom error handling using OpenIdConnect OnAuthenticationFailed event

I couldn’t figure out how to get the OnAuthenticationFailed event to work how I wanted it to.  My goal was to catch any exceptions that occurred during the auth pipeline & redirect to my own custom error page with information about the exception – the code is here: https://github.com/Azure-Samples/active-directory-dotnet-webapp-openidconnect-aspnetcore/blob/master/WebApp-OpenIDConnect-DotNet/Startup.cs#L78-83
When I call HandleResponse() in this event, the OIDC handler still tries to succeed the authentication flow, and subsequently throws an exception when it discovers the auth ticket is null (because some exception occurred during token validation).  It succeeds because of the call on this line: https://github.com/aspnet/Security/blob/dev/src/Microsoft.AspNetCore.Authentication.OpenIdConnect/OpenIdConnectHandler.cs#L637
I believe if the OnAuthenticationFailed event is invoked, the auth flow should not succeed.

HandleResponse isn't working in OnAuthenticationFailed. Use OnRemoteFailure instead. I don't think we need OnAuthenticationFailed anymore, it seems redundant with OnRemoteFailure.

FYI: JwtBearer has a similar issue with OnAuthenticationFailed and I don't see an easy workaround there.

@HaoK

Yeah we should just remove the OIDC specific OnAuthenticationFailed since we have OnRemoteFailure now...

We should add the newer/better event to the JWT flavor as well.

OnAuthenticationFailed was meant to indicate that we couldn't authenticate the user. I don't think OnRemoteFailure has the same semantic. This is also a change from Katana.

The other event does not apply to JWTBearer, it's from the base class for the redirecting middleware.

OnRemoteFailure has the same parameters and conditions and executes immediately after OnAuthenticationFailed. The only difference is the name.

Since this was not removed for RTM, we'll have to keep it and see if there's some way to fix it.

OnAuthenticationFailed makes sense for OIDC, but maybe not for JwtBearer as the webapi call is not technically about Authentication but Authorization.


fix(modelSelectField): missing overflow scrollbar when there isn't space to show entire list

Fixes #6097 Chat model selector not showing all options
Check out https://www.youtube.com/watch?v=4LYRRSzbh_Q for the before and after effects of this fix
both in vscode and in storybook
Test plan
Start storybook and notice that enterprise option is not visible before this fix
http://localhost:6007/?path=/story/cody-chat--empty
here's before:

and after:

Changelog
fix(modelSelectField): missing overflow scrollbar when there isn't space to show entire list

@ichim-david happy holidays to you too! Thank you for your help and contributions over the year 😃


Update to 2.4 version ?

Hello,
Is it possible to update to 2.4 version please ?

Updated. Thanks for the reminder.


Honda: Cruise Fault when OP drives below car's stock lower cruise speed limit

Describe the bug
Odyssey stock lower speed limit is 22mph.  The following is for an Odyssey without a Comma Pedal.
Expected behavior: when OP is engaged and drives the car below this limit, an info splash tells the user that they are below the limit while OP continues to be able to brake and steer.  Once OP tries to send an acceleration command, OP is disengaged entirely.  OP can be re-engaged once speed is above 25mph.
Current behavior: as soon as car drives below the lower limit while OP is engaged, a Cruise Fault warning comes up forcing the car to be restarted in order to continue using OP.  This also causes dash warnings to be set off, Collision Mitigation and possibly another, until the car is restarted.
The current behavior started after installing 0.8.13
What hardware does this issue affect?
comma two
Which car does this affect?
Honda Odyssey 2020
Provide a route where the issue occurs
0a96f86fcfe35964|2022-02-22--07-40-51
openpilot version
0.8.13 release2
Additional info
No response

#23828 has been merged into master and should fix this. Can you test and confirm this fixes your issue? Uninstall openpilot and reinstall with the URL installer.comma.ai/commaai/master-ci.

@gricha01 can you test the master branch and confirm the issue is fixed for you? Uninstall openpilot and reinstall with the URL installer.comma.ai/commaai/master-ci.

yes that fixed it. i put it in numerous situations and it handled each one perfectly. no faults, no notices, no alarms and came to a complete stop. thanks.

Confirmed this fixed the issue on my Odyssey


[docs] Apply small fixes

[x] I have followed (at least) the PR section of the contributing guide.

Added two points to mantain patterns - related-projects/text-fields.md

Added code tag to false - alert.md

Removed Extra double quotes? color.md

Removed Extra comma at code - theming.md

Removed Extra symbol - multiply - spacing.md

Removed section - interoperability.md
Older commits redesign the page, but now the link is broken.

@jaironalves Thanks


add more examples to query parameters

Address https://github.com/zalando/restful-api-guidelines/issues/770 by adding examples of simple query use cases and examples of filters (query parameters)

Wow! Thanks.

@ktsypkina great improvement. Can you please apply a 80 character line length limit to your changes?

👍

👍

:+1:


gopass won't accept any input

Summary
When I run gopass init or the initial gopass and try to answer questions, the input is not accepted/seen.
Steps To Reproduce
Run gopass
The question pops up: It seems you are new to gopass. Do you want to run the onboarding wizard? [Y/n/q]:
Expected behavior
Hitting y pops up the next question
What happens instead:
The y shows up on screen but nothing else happens:
It seems you are new to gopass. Do you want to run the onboarding wizard? [Y/n/q]: y
When I hit RET I see:
It seems you are new to gopass. Do you want to run the onboarding wizard? [Y/n/q]: y^M
When I hit CTR c I see:
With GOPASS_DEBUG=true gopass I get:
[DEBUG] Trying to load config from /home/bart/.config/gopass/config.yml
[DEBUG] Trying to load config from /home/bart/.gopass.yml
[DEBUG] config.Load(): Config[Root:StoreConfig[AskForMore:false,AutoClip:true,AutoImport:true,AutoSync:true,ClipTimeout:45,Concurrency:1,EditRecipients:false,NoColor:false,NoConfirm:false,NoPager:false,Notifications:true,Path:gpgcli-gitcli-fs+file:///home/bart/.password-store,SafeContent:false,UseSymbols:false],Mounts()]
[DEBUG] store/root/init.go:18 initializing store and possible sub-stores
[DEBUG] store/sub/store.go:43 sub.New - URL: gpgcli-gitcli-fs+file:///home/bart/.password-store
[DEBUG] store/sub/store.go:57 sub.New - Using storage backend from ctx: fs
[DEBUG] backend/storage/fs/loader.go:23 Using Storage Backend: fs(v0.1.0,path:/home/bart/.password-store)
[DEBUG] store/sub/store.go:66 sub.New - Using RCS backend from ctx: gitcli
[DEBUG] store/sub/rcs.go:17 Failed to initialized RCS backend: git repo does not exist
[DEBUG] store/sub/store.go:75 sub.New - Using Crypto backend from ctx: gpgcli
[DEBUG] backend/crypto/gpg/cli/loader.go:23 Using Crypto Backend: gpgcli
[DEBUG] store/sub/store.go:81 sub.New - initialized - storage: fs (0xc00023e2f0) - rcs: noop (0x12fdbb0) - crypto: gpg (0xc00024c480)
[DEBUG] store/root/init.go:116 Root Store initialized with URL gpgcli-gitcli-fs+file:///home/bart/.password-store
[DEBUG] backend/storage/fs/store.go:91 fs.Exists(.gpg-id) - /home/bart/.password-store/.gpg-id
[DEBUG] action/init.go:35 Store needs to be initialized
It seems you are new to gopass. Do you want to run the onboarding wizard? [Y/n/q]: y^M^C

Environment

OS: NixOS
OS version: Linux thinknix 4.19.80 #1-NixOS SMP Thu Oct 17 20:45:44 UTC 2019 x86_64 GNU/Linux
gopass Version:
Output of gopass version:
It seems you are new to gopass. Do you want to run the onboarding wizard? [Y/n/q]:
Output of gopass -v:
gopass 1.8.6-git+HEAD go1.13.1 linux amd64
Installation method: nix package manager:  nix-env -iA nixos.gopass

Afterwards I had another program misbehaving in the same way.
Opening a new terminal fixed the issue.
Sorry for the noise.


Window Resize causing rendering issues

Windows Terminal version (or Windows build number)
1.7.1033.0
Other Software
No response
Steps to reproduce
I know that this problem has been opened before, and its a duplicate, I am not able to solve the problem, I tried some of the solutions, someone said in another post that changing the historySize from 90000 to 9000, but in this version its already on 9000, I have enabled redraw entire screen option.
To reproduce this problem, I resize the window, and the text goes mayhem, all glitched, this sometimes happens also when I split the powershell in to two (Alt Shift +).
https://user-images.githubusercontent.com/42265793/116483622-7bc5fb80-a898-11eb-85f7-347a4369074d.mp4

Expected Behavior
Text should not be glitched after resizing.
Actual Behavior
https://user-images.githubusercontent.com/42265793/116483622-7bc5fb80-a898-11eb-85f7-347a4369074d.mp4

Every time this happens I have to restart the terminal and its been happening ever since I started using windows terminal when its released.

Woah, that's way more batty than anything I've seen in the related issues before. Could you share your vim config? That seems like something that's playing into how bad the state of the buffer gets

Hi @zadjii-msft , I dont really think that vim has something to do with this, because this glitch happens without even vim running, in the video I provided I just ran vim as an example of what would happen while doing basic tasks, but I will still provide you with what you are asking for. It is vim 8 for windows not WSL, I will post the vimrc.

The vimrc isn't that important if that's not critical to the repro. If you've got a specific set of steps that'll repro the glitch, that'll work too. I just need something that I can build a test around 😝

Welp, all what I do is that I literally just resize the window with my mouse, after some time of using the terminal, the glitches happen (sometimes the glitch does not occur until resizing the window more than once), this does not happen at all if the window is not resized. Also this glitch does not always happen, after some search I started to think that the problem is from my end (maybe GPU rendering problem.. idk), but I still would like to know your thoughts.


Fix/circuit error fixing

Pull request checklist
Please check if your PR fulfills the following requirements:

[X] Tests for the changes have been added (for bug fixes / features)
[X] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[X] Build (yarn build) was run locally in root directory and any changes were pushed
[X] Lint (yarn lint:fix) was run locally in root directory and any changes were pushed

Pull request type
Please check the type of change your PR introduces:

[X] Bugfix
[ ] Feature
[X] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?
What is the new behavior?
no, but changing some error variables in preventDoubleAction.circom and modifying variable commit_secret into identity_secret to make the variable consistency in hasher.circom/StateTreeLeaf().

Does this introduce a breaking change?

[ ] Yes
[X] No

Other information

I thought i should send another PR to update the latest commit of signup.circom.
Thank you for the fix!

I think i should send another PR to update the latest commit of signup.circom.
Thank you for the fix!

oh, is there anything i should change? or you can directly use this branch to modify the changes

No, everything in signup is good.


Closing ERb tags

I wanted to customize the tool to autoclose my ERb HTML tags. Is there a way to make it do this?: as soon as I enter "<%" the tool closes it with " %>"  putting a space in between and leaving the cursor right behind the first "%" sign so I can add "=" if need be. I'm pretty sure this is an easy fix for an experienced programer, but I don't know how to do it.

If atom is adding %> after you type <% then it's another plugin that is doing it. This plugin only adds </...>  after <...> is entered.

He wants the functionality, does it exist anywhere? I also want to auto-close my ERB HTML tags.


2.02 - silent fail to load game, no crash/error

If Mod Settings is enabled, the game has a failure to launch. Moments after attempting to start, the game's exe file just abandons task manager and calls it quits without any visible-to-end-user error of any kind. Not even the new error message they added.
Not sure if any logs are recorded or where to look.

Can confirm, red4ext.log gets as far as loading mod_settings.dll and then cuts off abruptly.
red4ext.log

^ Does the same ^

same problem
(Waiting for a solution)

And i have this trouble...

But i install mod_settings-4885-0-2-0-for-1-63-hotfix-1-1687792671.zip and all work fine


Event tracking not working

Hi I followed the instruction in inserting Fathom.trackGoal('EventCode', 0); in my event handler
but after deploying into prod, Fathom was not able to showing any event captured for that eventCode.
I put the Fathom.trackGoal('EventCode', 0); just before my return statement in my async function.
export default async functions* myfunction({parameters}): mytypes {
......
Fathom.trackGoal('EventCode', 0);
return {values}

Any idea what could went wrong here?

Hmm couple ideas:

Are you calling load?
Is this function getting called right before a page navigation occurs? (It's possible there's a race condition where the call does not finish before the browser navigates)
Are you using the right code? (You'll want to use the "Event ID" from the Fathom interface, not the name of the event)

Going to close this ticket, but if these don't work it's probably worth reaching out to Fathom support!


[Bug] Sprite has alpha see though mesh

https://user-images.githubusercontent.com/52899605/140036054-fae2cbf9-d041-45ed-b8d6-54e05f508466.mp4

It not happend once reconvert assets.
Issue closed.


*_repository use ENV['proxy'] if defined

Describe the Enhancement:
*_repository do not use environment proxy definition.
Describe the Need:
I think it would be great if *_repository resoures use environment proxy definition if defined and not overrided
Current Alternative
apt_repository
key ENV['proxy'[
....
Can We Help You Implement This?:
I can do a PR if you think makes sense

@faltimiras I don't think this is actually the direction we want to head. Apt, Yum and other packing systems each have their own way of configuring proxy settings and users should configure those so that Chef Infra Client behaves in an expected way. Some users may want a proxy to be used with their repositories, but for many other users that would break the way their systems fetch packages.
In apt you can add this config to an apt.d config:
Acquire::http::Proxy "http://USERNAME:PASSWORD@SERVER:PORT";
Acquire::https::Proxy "https://USERNAME:PASSWORD@SERVER:PORT";

in yum you can add this to your yum.conf:
proxy=http://SERVER:PORT

@tas50 IMHO this is inconsistent becaues all resources "believes" on this setting and this ones no.
It is not common to use different proxies in the same machine, so I would say that makes sense to just set it once for all http communications. If for some reason you need another proxy, you can always override the proxy setting in the *_repository.
It think it won't break many things because I just proposed to change the default value when a general proxy is defined, If they changed to use they own proxy, nothing will happen because they are overrideing the proxy setting on the *_repository so the default value from ENV['proxy'] won't be used.
Thanks


finished project page "search by company" option is not working

finished project page "search by company" option is not working

already added issue 54


Create accordion for help menu

Create accordion for help menu
Implement accordion for help menu to improve readability, interface and avoid clustering.
Resolves #5
Co-Authored-By: Anwar Ramadi<EMAIL_ADDRESS>

indentations are one tab actually, but when you check indentations in GitHub it will appears as two spaces. I will move the accordion menus to col-left and fix it


[T2A3][T17-A2]Musa

Ready for review

@ghurabah93 I think you may have accidentally reverted the commit to reduce SLAP for the main method. However, I took a look at your "Reduce SLAP of method" commit and saw that you have done a good job. Make sure you name your commits properly. For example, "inline method processProgramArgs"


Update for issue 22

Contributes to # (#22)
What did you do?
Added code to hide logout button by default. If logged in then only the logout button will be displayed.
Why did you do it?
How have you tested it?
Yes
Were docs updated if needed?

[ ] No
[ ] Yes
[x] N/A

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new console logs
[x] Fixes entire issue
[ ] Partial fix for issue

pls review @upkarlidder @josiemundi


Contribution to "Privilege Escalation in Hibernate Validator"

Updates

Affected products

So it does. Looks like the 5 branch never made it to maven central, but many thanks for the fix @JesseEstum  👍


System.AccessViolationException

Not sure whether it is a React.NET or ClearScript issue. I'm trying to run my application in a docker container. At strartup it crashes with the System.AccessViolationException exception.
Unhandled Exception: System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
   at V8Context.Create(SharedPtr<V8Isolate>* , StdString* , Boolean , Boolean , Int32 )
   at Microsoft.ClearScript.V8.V8ContextProxyImpl..ctor(V8IsolateProxy gcIsolateProxy, String gcName, Boolean enableDebugging, Boolean disableGlobalMembers, Int32 debugPort)
   --- End of inner exception stack trace ---
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor)
   at System.Reflection.RuntimeConstructorInfo.Invoke(BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
   at System.RuntimeType.CreateInstanceImpl(BindingFlags bindingAttr, Binder binder, Object[] args, CultureInfo culture, Object[] activationAttributes, StackCrawlMark& stackMark)
   at System.Activator.CreateInstance(Type type, BindingFlags bindingAttr, Binder binder, Object[] args, CultureInfo culture, Object[] activationAttributes)
   at System.Activator.CreateInstance(Type type, Object[] args)
   at Microsoft.ClearScript.V8.V8Proxy.CreateImpl[T](Object[] args)
   at Microsoft.ClearScript.V8.V8ScriptEngine..ctor(V8Runtime runtime, String name, V8RuntimeConstraints constraints, V8ScriptEngineFlags flags, Int32 debugPort)
   at JavaScriptEngineSwitcher.V8.V8JsEngine..ctor(V8Settings settings)
   at JavaScriptEngineSwitcher.V8.V8JsEngineFactory.CreateEngine()
   at React.JavaScriptEngineFactory.GetFactory(JsEngineSwitcher jsEngineSwitcher, Boolean allowMsie)
   at React.JavaScriptEngineFactory..ctor(JsEngineSwitcher jsEngineSwitcher, IReactSiteConfiguration config, IFileSystem fileSystem)
   at lambda_method(Closure , Object[] )
   at React.TinyIoC.TinyIoCContainer.ConstructType(Type requestedType, Type implementationType, ConstructorInfo constructor, NamedParameterOverloads parameters, ResolveOptions options)
   at React.TinyIoC.TinyIoCContainer.SingletonFactory.GetObject(Type requestedType, TinyIoCContainer container, NamedParameterOverloads parameters, ResolveOptions options)
   at React.TinyIoC.TinyIoCContainer.ResolveInternal(TypeRegistration registration, NamedParameterOverloads parameters, ResolveOptions options)
   at React.TinyIoC.TinyIoCContainer.ConstructType(Type requestedType, Type implementationType, ConstructorInfo constructor, NamedParameterOverloads parameters, ResolveOptions options)
   at React.TinyIoC.TinyIoCContainer.CustomObjectLifetimeFactory.GetObject(Type requestedType, TinyIoCContainer container, NamedParameterOverloads parameters, ResolveOptions options)
   at React.TinyIoC.TinyIoCContainer.ResolveInternal(TypeRegistration registration, NamedParameterOverloads parameters, ResolveOptions options)
   at React.TinyIoC.TinyIoCContainer.Resolve[ResolveType]()
   at React.AspNet.HtmlHelperExtensions.get_Environment()
   at React.AspNet.HtmlHelperExtensions.React[T](IHtmlHelper htmlHelper, String componentName, T props, String htmlTag, String containerId, Boolean clientOnly, Boolean serverOnly, String containerClass)
   at AspNetCore._Views_Site_Menu_cshtml.<ExecuteAsync>d__33.MoveNext() in /Views/Site/Menu.cshtml:line 3
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start[TStateMachine](TStateMachine& stateMachine)
   at AspNetCore._Views_Site_Menu_cshtml.ExecuteAsync()

Without container it is runs fine.

Posted the issue to ClearScript https://clearscript.codeplex.com/workitem/120

Hello, Andrey!
What versions of the JavaScriptEngineSwitcher.V8, JavaScriptEngineSwitcher.V8.Native.win-x86 and JavaScriptEngineSwitcher.V8.Native.win-x64 packages do you use?

Hi Andrey!
Thanks for your help! Initially I tries with older version but it has the same issue. Now I'm using the latest version available 2.2.0.

Now I'm using the latest version available 2.2.0.

This error no longer occurs?

No, still have the same exception.
However, there is a theory it could be a memory limit issue. Someone suggested that V8 could crash if it could not allocate enough memory

Another possibility is that the V8 runtime is too constrained to complete startup. Are you using V8RuntimeConstraints to specify memory usage limits?
Also, could it be that Docker is imposing various limits on your application?
https://clearscript.codeplex.com/workitem/120

I'm going to check today if there are options in docker related to memory and will see if it fixes the issue.

Try to register the V8JsEngine manually.

Are you using V8RuntimeConstraints to specify memory usage limits?

I recommend you also read the “Registration of JS engines” and “JS Engine Switcher: V8” sections of the JavaScript Engine Switcher's documentation.
If you plan to use ASP.NET Core in your projects, then try the JavaScriptEngineSwitcher.ChakraCore.

I think we could close the issue. I did some testing today and it seems that it was a memory limit issue.


add a basic TravisCI setup

This would let you automate 'make test' checks, including when PRs are sent.
For an example, see https://travis-ci.org/austin987/openrc

I also went a bit further and made whitespace/style stuff fatal (if $FATAL_CHECKS is not empty). Would be simple to make it fail always, but I assumed there was a reason it didn't already.

So I tried adding @mrueg's changes, but looks like openrc doesn't build with musl-gcc:
musl-gcc -fPIC -DPIC  -I../includes -D_DEFAULT_SOURCE -D_POSIX_C_SOURCE=200809L  -O2 -g -std=c99 -Wall -Wextra -Wimplicit -Wshadow -Wformat=2 -Wmissing-prototypes -Wmissing-declarations -Wmissing-noreturn -Wmissing-format-attribute -Wnested-externs -Winline -Wwrite-strings -Wcast-align -Wcast-qual -Wpointer-arith -Wdeclaration-after-statement -Wsequence-point -Werror=implicit-function-declaration   -c libeinfo.c -o libeinfo.So
libeinfo.c: In function ‘colour_terminal’:
libeinfo.c:466:4: error: implicit declaration of function ‘strlcpy’ [-Werror=implicit-function-declaration]
    strlcpy(tmp, tgoto(bold, 0, 0), sizeof(tmp));
    ^
libeinfo.c:466:4: warning: nested extern declaration of ‘strlcpy’ [-Wnested-externs]
libeinfo.c:467:4: error: implicit declaration of function ‘strlcat’ [-Werror=implicit-function-declaration]
    strlcat(tmp, tgoto(_af, 0, c & 0x07), sizeof(tmp));
    ^
libeinfo.c:467:4: warning: nested extern declaration of ‘strlcat’ [-Wnested-externs]
libeinfo.c: In function ‘elogv’:
libeinfo.c:525:3: error: implicit declaration of function ‘vsyslog’ [-Werror=implicit-function-declaration]
   vsyslog(level, fmt, apc);
   ^

I've enabled gcc/clang, since those work. That passes:
https://travis-ci.org/austin987/openrc
@vapier @williamh is there anything else that's needed before this can go in?


CM.Disp.FormatTime is formatting time incorrectly

It simply not displaying years, though calculates it here in the code.
Dates in the stats as of now:

Bug can be reproduced with any file save where any of the dates is bigger than a year.

Date format after accepting my PR:

Date format after accepting my PR:


Circleci node version

Ref https://github.com/getodk/central/blob/master/service.dockerfile#L1
Should tests be run against the same version used in production?

Good catch, thanks!


Near perfect Creatures 2 performance, except for the Eye window

Firstly, I wanted to congratulate and thank you for providing a fix for Creatures 2! At long last, the prophecy has been fulfilled. Seriously, major kudos. It has been a long struggle getting this game to play nicely on modern Windows.
It runs so well with the fixes you posted, but there is one remaining issue, which is best described with a screenshot:

When not on top of the game window, it doesn't render at all:

It almost seems too much to hope for, but maybe there is just one more small tweak needed to get it redrawing correctly? Then this game could almost be considered 100% compatible!

The trouble here is that I am rendering everything to the main window.  So when another render window appears on top the contents of that window is also displayed to the main window.  Then when you move it outside the main window it can no longer render it.
The proper fix would be to render to the correct window.  That may take a bit of time because I am not completely sure how to tell what window it is rendering to.  However, let me look into a different way of fixing this.
BTW: I found the core issue with Creatures 2 and added the fix here and here.  Creatures 2 would use a rect for Blt that is 1 pixel too large and Windows would fail the Blt.  Then Creature 2 would see the error message and exit the game.  I just added code to detect this case and retry the Blt using a slightly smaller rect.

If you could read through the game's original rendersystem.cpp, display.cpp and ddraw.cpp, would that be helpful at all?
If so, is there any way to contact you privately?

Yes, having the game's source code may help here.  You can email me at elisha at novicemail.com.
Also, how do you get the Eye window to popup?

This issue should be fixed in the latest release:  https://github.com/elishacloud/dxwrapper/wiki/Creatures-2:-The-Albian-Years


Tensor Debug Missing

Watching your videos, I was hoping to be able to use the Tenser debug to view the sizes of my clip inputs. Do you have a new improved method for viewing those?

yeah I think it can be improved to add those as well

It looks like perhaps you had this class in your original version of essentials. Did it get removed later?

it's still there, it's called "tensor shape debug"