main.json is modified or outdated. Please regenerate the file to fix it.

Hi,
@shenglol
Have you seen this issue before with the brm validate?
Locally it works fine, but in pipeline context it will throw this out.

I have tried to add .gitattributes file with
* text=auto
*.bicep text eol=lf

Then clone repo again to trigger lf change.
Same issue occurs.
Running git ls-files --eol

Even when setting both bicep and json files to lf manually in VS Code has no improvements.
Do you have any idea how to handle such behavior?
Seems that #66 has been experiencing something similar.

Hi @bengeset96, can you check what version of Bicep CLI is installed on your machine?

@shenglol
Running Bicep CLI 0.5.6.

Should probably start reading documentation better..
Sorce had 0.4 installed. Upgraded now with 0.5.6.

And now

I was not aware that brm validate would check for

That is clever!
@shenglol
Thanks for responding so fast. Truly grateful.


Temporarily hide Profiles functionality from UI

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1389
Originally created by @DouweM on 2019-12-06 18:33:16

Without https://gitlab.com/meltano/meltano/issues/1331, the Profiles functionality introduced in https://gitlab.com/meltano/meltano/issues/764 is not likely to actually create value for our users since most data sources do not actually play well with data from multiple profiles ending up in the same analytics database, and there's no way for a user to know whether the extractor they're using is or isn't compatible.
We should hide the Profiles functionality from the interface until https://gitlab.com/meltano/meltano/issues/1331 is resolved, and documentation is in place (https://gitlab.com/meltano/meltano/issues/1353), so that users can consistently get to value instead of confusion / unusable mixed data.
If a profile has already been set up, we can continue to allow the user to edit it, but a totally new user should not know that Profiles exist yet.

View 10 previous comments from the original issue on GitLab


Fix OperationData.amount, add delegate fields

 Add delegate_address/alias fields to OperationData

 Add delegate_address/alias fields to OperationData

 Transaction amount None

 Transaction amount None


Add posts to project and add post view test

Closes #130.
Simply adds posts to projects, expands on post some and tests it.

Ready for review.

@JoshSmith the PR with the ModelHelper additions is in if you want to add with_number and for_project to that list

Could use a review on my latest commit.

I did some digging on using Repo.preload, vs just preload
It looks like just preload is actually us using the weird linq/lambda style query synthax, so it works just off of a model module. Repo.preload, on the other hand is a method on the Repo module, which expects a struct or list of structs as the first argument, so it has to be called after Repo.get*/Repo.all. From what I can tell in the documentation and various other places, Repo.preload is the preferred approach and more commonly used. We should fallback to preload if we need some sort of query interpolation.
I corrected the controller so tests pass now. I also modified the index method a bit to simplify the query and possibly shorten it, making it more performant.


Why is the adapter layer merged in gpt-neox-20b_peft?

In the gpt-neox-20b_peft example, step 1 is the SFT with lora, step 2 is the merging of the trained lora adapters' weights into the base model, and step 3 is loading the merged model for PPO training with lora. I am unclear on why the models are merged in step 2.
Is it necessary to merge the adapter layer, or can we simply load both the base model and lora weights in step 3 (gpt-neo-20b_sentiment_peft.py) instead of loading the merged model? The code to load both models in step 3 would look like this:
peft_model_id = "edbeeching/gpt-neo-125M-imdb-lora"
peft_config = PeftConfig.from_pretrained(peft_model_id)
model = AutoModelForCausalLM.from_pretrained(
    peft_config.base_model_name_or_path,
    ...
)
model = PeftModel.from_pretrained(model, peft_model_id)

I think the main reason is to save vRAM, and also an adapter lora model maybe is enough for a single task()

Hi @ohashi56225
Thanks for your question
Indeed it is needed to first merge the LORA layers inside the base model, as later on we train new adapters for the RLHF part. As you cannot have multiple adapters on the same model, you need to merge the adapters that were trained first, use this merged model as a standalone transformers model, and use the latest as a base model for the new LORA layers that you want to train
Does that makes things clearer? Let me know if this is still unclear

Hi @ohashi56225
Thanks a lot for following up!

If we initialize the weights of the new LoRA layers randomly, wouldn't we risk losing the ability to generate IMDB reviews learned in the SFT step, resulting in poor sentence generation at the beginning of the RLFH training loop?

In fact when we "merge" the LoRA layers directly to the base model, it means that we are transferring the knowledge that has been learned by the LoRA layers directly on the base model. Precisely, this also means that once you have merged the LoRA layers, you can push these new "merged" weights on the Hub (or locally) and directly load it and benefit from the SFT fine-tuned performance. An example can be found here: https://huggingface.co/edbeeching/gpt-neo-125M-imdb-lora-adapter-merged , as you can see it, there no more adapters anymore in this repository.

Wouldn't it make more sense to fine-tune the pre-trained LoRA layers directly, rather than adding a new LoRA layer for RLHF? This would also reduce the number of parameters in the model.

It is indeed possible, but the model will convergence quite slowly as the model needs to :
1- Adapt in the imdb domain
2- Learn to generate positive content
We have empirically find out that the "domain" gap is an important factor to consider, i.e. fine-tuning a model that is already prepared to generate movie reviews converges faster / easier than base models.
Let me know if anything else is unclead!

Thank you for your answer! However, I realized that my question may have been unclear, leading to an answer that didn't quite address my intended meaning.
First of all, is my understanding correct that the current implementation follows the steps shown in the image below? If so, my first question means that if the addition of new LoRA layers in step 3 is affecting the review generation ability of the merged model. Specifically, since the parameters of these LoRA layers are initialized randomly (which I believe corresponds to line 112 of gpt-neo-20b_sentiment_peft.py), they need to be trained from scratch during RL .

@ohashi56225  I had exactly the same questions as you. I also think your understanding of the 3steps procedure is correct. However, I think I understand why simply fine-tuning the adapter weights without merging them works less well. It is related to the KL divergence in the PPO training.
In fact, in https://github.com/lvwerra/trl/blob/b5cce0d13e95c8e21eb9d57177930253d9092a02/examples/sentiment/scripts/gpt-neox-20b_peft/gpt-neo-20b_sentiment_peft.py#L209, the ref_model=None. In this case, and since model is a PEFT_model, the ref_model simply becomes the PEFT_model with the adapters removed https://github.com/lvwerra/trl/blob/b5cce0d13e95c8e21eb9d57177930253d9092a02/trl/trainer/ppo_trainer.py#L559.
In our case, if there is no merging step, this corresponds to taking as the ref_model the gpt-neo-125m model without any adapters and thus not adapted to imdb. With the merging step, this amounts to taking as ref_model the gpt-neo-125M-imdb-lora-adapter-merged model with better quality ref_logprobs. A bug fix that should make the merging obsolete would be to explicitly choose the adapted ref_model rather than letting ref_model=None.
That's my current understanding from reading the code, but experimental validation is certainly desirable.

Hey @Sanster @alexrame
Thanks a lot for the nice diagram btw, I made a diagram based on your to explain the procedure

Actually when lora weights gets merged, the Lora layers 'disappear', and this is what I meant by yo can use the merged model as a standalone model !
Btw, this functionality will be supported soon on peft, check: https://github.com/huggingface/peft/pull/227

In our case, if there is no merging step, this corresponds to taking as the ref_model the gpt-neo-125m model without any adapters and thus not adapted to imdb. With the merging step, this amounts to taking as ref_model the gpt-neo-125M-imdb-lora-adapter-merged model with better quality ref_logprobs.

I think that this totally valid and this is my empirical understanding of things!

@younesbelkada @alexrame
I now have a complete understanding of how the LoRA layers are merged to create a standalone model, as well as the reasons behind this process. Thank you both for providing such a detailed explanation! And I agree that it works to  choose the adapted ref_model instead of leaving ref_model=None.
Therefore, I think it's appropriate to close this issue. Thank you once again!

Thanks for the nice explanations. So should we indicate the ref_model = gpt-neo-125M-imdb-lora-adapter-merged instead leave it to None?

If your base model is "gpt-neo-125M-imdb-lora-adapter-merged", then you can either set ref_model = gpt-neo-125M-imdb-lora-adapter-merged or None, they both are equivalent. yet, the None option is preferred because it's more efficient (you don't need to load the same model twice).
In contrast, if you have not applied the merge procedure, the ref model should be explicitly called.
ref_model = Loader.load_peft_model(ref_base_model, peft_name=ref_peft_name)


Add filter item tooltip

Changes

Rework popover in form label addon
Support form label addon in filter item title
[delete] branch

Changelog entry

New PopoverV2 component with improved positioning behaviour
[WARNING] Deprecate Popover, to be removed in the next major version

Additional information

Using Floating UI to handle repositioning

Encountered build issues as Rollup v2 couldn't handle the library's mjs format, upgraded Rollup to v3
Encountered unit test error, updating the moduleDirectories resolves it somehow

Instead of a HOC, use composition with PopoverTrigger. Can consider a render prop or hook instead if the composed trigger requires additional data

fixing some alignment issues with the tooltip icon

partially addresses https://github.com/LifeSG/react-design-system/issues/373


Measure gossip latencies on 4.1

Gossip latencies are over 2min long, + verification is too inefficient. Are these correlated? Note: see #6792

@deepthiskumar can you add the latency data you gathered when you have a chance?

@deepthiskumar can you add the latency data you gathered when you have a chance?


error: expected ';' after top level declarator

Considering the following header file:
#ifndef HEADER_D1_SRTP_H
#define HEADER_D1_SRTP_H

#ifdef  __cplusplus
extern "C" {
#endif

#define SRTP_AES128_CM_SHA1_80 0x0001
#define SRTP_AES128_CM_SHA1_32 0x0002
#define SRTP_AES128_F8_SHA1_80 0x0003
#define SRTP_AES128_F8_SHA1_32 0x0004
#define SRTP_NULL_SHA1_80      0x0005
#define SRTP_NULL_SHA1_32      0x0006

int SSL_CTX_set_tlsext_use_srtp(SSL_CTX *ctx, const char *profiles);
int SSL_set_tlsext_use_srtp(SSL *ctx, const char *profiles);

STACK_OF(SRTP_PROTECTION_PROFILE) *SSL_get_srtp_profiles(SSL *ssl);
SRTP_PROTECTION_PROFILE *SSL_get_selected_srtp_profile(SSL *s);

#ifdef  __cplusplus
}
#endif

#endif

CppSharp fails to parse this with:
C:\Dir\header.h(135,34): error: expected ';' after top level declarator
Line 135:
STACK_OF(SRTP_PROTECTION_PROFILE) *SSL_get_srtp_profiles(SSL *ssl);
This issue pops up quite a bit on the web in a CLang context. Any ideas on how to make CppSharp immune to such annoyances ?

Are you sure you include all dependencies in your configuration of C++#? For example, where are STACK_OF, SRTP_PROTECTION_PROFILE and SSL defined?

If this is the full header file you're passing to CppSharp, then as @ddobrev said it's missing a lot of definitions which is expected to fail.
CppSharp behaves just like a C++ compiler, if in doubt just try to pass the header through GCC or Clang.

@ddobrev, @tritao
That's the full header file, I just left out some 100+ lines of license text.
The full log for this particular header is:
Error parsing 'C:\headers\include\openssl\srtp.h'
C:\headers\include\openssl\srtp.h(132,33): error: unknown type name 'SSL_CTX'
C:\headers\include\openssl\srtp.h(133,29): error: unknown type name 'SSL'
C:\headers\include\openssl\srtp.h(135,1): error: unknown type name 'STACK_OF'
C:\headers\include\openssl\srtp.h(135,34): error: expected ';' after top level declarator
C:\headers\include\openssl\srtp.h(136,1): error: unknown type name 'SRTP_PROTECTION_PROFILE'
C:\headers\include\openssl\srtp.h(136,56): error: unknown type name 'SSL'

Errors 1-3 & 5-6 are expected, because srtp.h does not include the headers where those types are defined. To my mind however, error 4 is unexpected.
There are other header files missing includes and they fail like this:
Error parsing 'C:\headers\include\openssl\dtls1.h'
C:\headers\include\openssl\ossl_typ.h(86,9): warning: Warning, overriding WinCrypt defines
C:\headers\include\openssl\dtls1.h(114,2): error: unknown type name 'SSL_SESSION'
C:\headers\include\openssl\dtls1.h(175,2): error: unknown type name 'SSL3_BUFFER'
C:\headers\include\openssl\dtls1.h(176,2): error: unknown type name 'SSL3_RECORD'; did you mean 'USN_RECORD'?

Error parsing 'C:\headers\include\tls.h'
C:\headers\include\tls.h(187,1): error: unknown type name 'time_t'; did you mean 'size_t'?
C:\headers\include\tls.h(188,1): error: unknown type name 'time_t'; did you mean 'size_t'?
C:\headers\include\tls.h(201,1): error: unknown type name 'time_t'; did you mean 'size_t'?
C:\headers\include\tls.h(204,1): error: unknown type name 'time_t'; did you mean 'size_t'?
C:\headers\include\tls.h(205,1): error: unknown type name 'time_t'; did you mean 'size_t'?

Based on what I see in my logs and what information floats around on the web, the error: expected ';' after top level declarator does not appear to be related to unknown types.

@DevSidious as accurate as Clang is, you cannot be certain it can always behave precisely when types are missing because this can be interpreted in various ways. Ensure all macros are defined and if you then still get the error, we can talk more.

Unfortunately, if that is indeed the case, I'm afraid to say that is just badly written C code.
Are we talking about this header file in particular? https://github.com/openssl/openssl/blob/master/include/openssl/srtp.h
If so, it seems like your version is missing the # include <openssl/ssl.h> part, which one would guess defines those missing types.

@ddobrev I'm onto that.
@ddobrev @tritao
Would it be possible to configure CppSharp to search for types in the entire module.Headers collection even if a particular header file does not specifically include the source header for the type ? Now THAT would be something useful beyond belief.

@DevSidious I am afraid not. CppSharp does not "search", it simply parses the input headers. We don't want to, cannot and will not work with invalid input.

We already search for those "missing" types in the case of forward declarations (we call them incomplete types).
But in this case, what you're suggesting would be actually changing the C language (and the Clang compiler), which makes no sense in practice. What you want is for us to accept invalid C code and fix it after the fact.

@tritao
No, it's the srtp.h in the LibreSSL tarball: https://ftp.openbsd.org/pub/OpenBSD/LibreSSL/libressl-2.5.5.tar.gz . However, it does miss the # include <openssl/ssl.h> .

That usually means the header is not intended to be included directly, but by some other header file that includes it (and defines the other necessary stuff previously).
I took a quick look at the tarball, and if you look inside ssl.h, you can see it includes those headers (after defining all the necessary types, line 886):
#include <openssl/ssl2.h>
#include <openssl/ssl3.h>
#include <openssl/tls1.h>	/* This is mostly sslv3 with a few tweaks */
#include <openssl/dtls1.h>	/* Datagram TLS */
#include <openssl/ssl23.h>
#include <openssl/srtp.h>	/* Support for the use_srtp extension */

This means you should only be passing the ssl.h header to CppSharp, and nothing else.

@tritao @ddobrev , you guys must be my lucky charm or something. @tritao 's suggestions and a bit of fiddling with CppSharp's driver setup and I got myself a fresh juicy wrapper.
Thanks guys!


Request to join the community? :)

Hello! Would I be able to join this community? 😄  I am trying to make open source a much bigger part of my coding career!
Thanks in advance!

Of course @rperry99 , great to have you part of our community 🎉
I have sent the invitation to our organisation. After you accept, you will need to find your name in the list of people and make it public if you want it to appear on your GitHub profile for everyone to see, only you can change the visibility https://github.com/orgs/EddieJaoudeCommunity/people

Thanks @eddiejaoude !

Hey @rperry99, love the enthusiasm 😃 💯💯 ! Contributing to open source helps your career for sure, since you collaborate with tons of people.
Welcome to the community 🎉 and if you are interested in more of a front-end project, take a look at our community website repo. Any contribution is very welcome 👍 .


Vi Like Key Bindings [FEATURE]

It appears there is not a configuration option to use Vi like (h/j/k/l) key bindings for navigation.  Seeing as how this is targeted at terminal users, it seems odd that you are required to have to use arrow keys which many keys which many keyboards don't even have.

Hey!
Thank you for your request to add vi keybindings (or configurable keybindings). I myself use neovim for the development of wiki-tui and honestly, I don't know why this functionality isn't there yet.
I'm currently very busy but this shouldn't be that difficult to implement so maybe I can finish it during the weekend.  One question though about the bindings:
Should there also be a way to reconfigure the tab key? So that you can change the key for view navigation.


Helm-installed lakeFS with ingress is not resolving bucket virtual hosting for S3 Gateway

Hello, I'm having some trouble getting virtual hosting for the S3 Gateway to work with my lakeFS installation through Helm. To test this, I have tried using AWS CLI as shown below.
The following seems to work correctly:
$ aws s3 --endpoint-url https://s3.my.path.net ls repo
                           PRE main/

However, when I set virtual hosting (or when I use a 3rd party's, AppSmith's, S3 integration with bucket virtual hosting), there is no response (however, exit code is 0 unless I specify a branch which returns 1):
$ aws configure set default.s3.addressing_style virtual
$ aws s3 --endpoint-url https://s3.my.path.net ls repo # exit code of 0, no response
$ aws s3 --endpoint-url https://s3.my.path.net ls repo/main/ # exit code of 1, no response

Supplemental debug log from the above exit code of 1: (redacted)
My Helm values is below:
lakefsConfig: |
  blockstore:
    type: s3
  gateways:
    s3:
      domain_name: s3.my.path.net
ingress:
  enabled: true
  ingressClassName: "nginx"
  tls:
  - hosts:
    - my.path.net
    - s3.my.path.net
    - "*.s3.my.path.net"
    secretName: <secret tls>
  hosts:
    - host: my.path.net
      paths: ["/"]
    - host: s3.my.path.net
      paths: ["/"]
    - host: "*.s3.my.path.net"
      paths: ["/"]

extraEnvVarsSecret: <secret env>

Thank you, @eden-ohana & @johnnyaug for your preliminary help! Any additional help on getting this re-configured or otherwise working for bucket virtual hosting would be much appreciated!

Resolved with a re-deployment of both lakeFS and associated PostgreSQL db. Will re-open if I can reproduce the issue. Thank you @Jonathan-Rosenberg @iddoavn, Amit.


Add deployment blurb

Closes #12

Throw some details in the README.md about what each environment is and what each developer should look for as they push, open PRs, and merge


Package as Flatpak

Hi,
would you package Devify as Flatpak?

I haven't considered that. I'm still a newbie, so idk how much work I would need to do.

Not an expert but i think is not possible, flatpak apps are mostly read only and with the build script you can't replace /lib/udev/rules.d/99-devify.rules


Snapshots are rendered with an extra " causing all other quotes to be esaped

Describe the bug
Rendered snapshots have a double quote " added immediately after the first ` (or ' for inline snapshots, which feels wrong too?).
This occurs with no UI framework at all, as well as with Vue 3, using composition API and script setup. I haven't tested other frameworks but since it happens without an it probably happens with all of them.
This causes all snapshots to be escaped with \\ everywhere making them much harder to read and compare.
Reproduced here: https://stackblitz.com/edit/vitejs-vite-pdqfzn
Reproduction

Install vite npm create vite@latest
Add a test that will render snapshots:

import { test, it, describe, expect } from 'vitest';

describe('App', () => {
  it('should render the html inline', () => {
    expect(`<div class="test">Hello World</div>`).toMatchInlineSnapshot(
      '"
Hello World
"'
    );
  });

  it('should render the html in a snapshot file', () => {
    expect(`<div class="test">Hello World</div>`).toMatchSnapshot();
  });
});

=> snapshots are rended with \\ everywhere to escape quotes.
System Info
System:
    OS: Linux 5.4 Amazon Linux 2
    CPU: (16) x64 Intel(R) Xeon(R) CPU E5-2686 v4 @ 2.30GHz
    Memory: 18.33 GB / 62.79 GB
    Container: Yes
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 14.18.1 - ~/.nvm/versions/node/v14.18.1/bin/node
    npm: 6.14.15 - ~/.nvm/versions/node/v14.18.1/bin/npm
  Browsers:
    Firefox: support!
Mozilla Firefox 78.11.0esr
  npmPackages:
    @vitejs/plugin-vue: ^2.1.0 => 2.1.0
    vite: ^2.7.13 => 2.7.13
    vitest: ^0.5.3 => 0.5.3

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

I'm seeing this behavior too. It'd be great if the snapshots could contain as little code as possible. In my particular case, I often copy paste snapshots from code-reviews into something like https://play.tailwindcss.com/ for verification

I see jest has the same behaviour. So, these are correct snapshots by default.
Did you previously use any snapshot options to not put strings inside "?

I just used the vue-cli v5 to bootstrap an app with jest tests configured. This is what the snapshot looks like:
exports[`HelloWorld.vue renders props.msg when passed 1`] = `

new message

 For a guide and recipes on how to configure / customize this project,
 check out the vue-cli documentation.

Installed CLI Plugins

babel

unit-jest

Essential Links

Core Docs

Forum

Community Chat

Twitter

News

Ecosystem

vue-router

vuex

vue-devtools

vue-loader

awesome-vue

`;

I just used the vue-cli v5 to bootstrap an app with jest tests configured. This is what the snapshot looks like:
exports[`HelloWorld.vue renders props.msg when passed 1`] = `

new message

 For a guide and recipes on how to configure / customize this project,
 check out the vue-cli documentation.

Installed CLI Plugins

babel

unit-jest

Essential Links

Core Docs

Forum

Community Chat

Twitter

News

Ecosystem

vue-router

vuex

vue-devtools

vue-loader

awesome-vue

`;

Can you show what is passed to expect, when you call toMatchSnapshot?

Can you show what is passed to expect, when you call toMatchSnapshot?

nvm, I see vue-cli uses this serializer: https://www.npmjs.com/package/jest-serializer-vue
But I don't think we support serializers at the moment

But I don't think we support serializers at the moment

Right when I sent it, I found we have expect.addSnapshotSerializer. You can try passing jest-serializer-vue to it, but I guess we also need to expose it as an option for easier install

But I don't think we support serializers at the moment

Right when I sent it, I found we have expect.addSnapshotSerializer. You can try passing jest-serializer-vue to it, but I guess we also need to expose it as an option for easier install

Or I guess we can inline them, since we have ReactPlugin for serializer - why don't add Vue? Since we are so close to it. @antfu what do you think?

@sheremet-va, @LanFeusT23, I was just about to open the same exact issue here on GitHub.
I'm working on a project where we are migrating from Webpack+Jest to Vite+Vitest.
Everything has been almost seemless so far, except for snapshots.
Just like @LanFeusT23 mentioned, between Jest and Vitest there are two "major" differences in the snapshot file that gets generated.
1. In Vitest, the snapshots contain a lot of //'s
I have just put up two basic Stackblitz examples to compare between Jest and Vitest.
In Jest, the snapshots gets saved like the following:
`<div class="title">Hello World</div>`

(Check Stackblitz Demo)
While in Vitest, they're saved like this:
`"<div class=\\"title\\">Hello World</div>"`

(Check Stackblitz Demo)
There are two differences:

In Vitest, the whole HTML is wrapped around a double-quoted string;
Because of that, all double-quoted-strings are being escaped with //
(This is all what @LanFeusT23 have already pointed out)

2. In Vitest, the name of the module export for each snapshot is also different from Jest
When tests are nested within describe and it/test functions, Vitest separates them with a > . I think that's cool, but it'd be even better if that could be, somehow, optional.
The reason for this is when we are migrating from Jest to Vitest, when running the snapshots, due to the fact that the snapshots come out with a different name, the CLI will not directly compare the snapshots for a replacement - it will assume that it is a new one that is being created from scratch.
Any chance of having any config option to change this?

@jagoncalves14
1.
It's actually matched with Jest's default behavior. The quotes are added to distinguish strings and values. The behavior you see is is because the vue-cli presets include jest-serializer-vue which removes the quotes for HTML-like strings: https://github.com/eddyerburgh/jest-serializer-vue/blob/master/index.js
Like @sheremet-va mentioned, we do have expect.addSnapshotSerializer API that you might be able to pass the custom serializer to it. (tho I would doubt if the HTML check is sound enough)
2.
Currently, there is no way to configure it. Even tho Vitest is trying to make migration from Jest as easier as possible, they are still two different frameworks and we can't align everything with Jest. In this case, I would recommend removing the snapshot files and letting Vitest generate new ones so you can compare them with git's diff.

@antfu, thanks for the reply!
1.
You're totally right, I was missing the jest-serializer-vue and was able to add it using the expect.addSnapshotSerializer. I created my own serializer based on jest-serializer-vue one. Needed some extra replacements to remove any attributes that was bringing unique IDs.
For anyone that is interested and might find it useful, here is the code for that serializer:
// tests/vitest-serializer-vue.ts

import { ComponentPublicInstance } from 'vue'
import { VueWrapper } from '@vue/test-utils'
import beautify from 'pretty'

const isHtmlString = (received: string) => received && typeof received === 'string' && received[0] === '<'
const isVueWrapper = (received: VueWrapper<ComponentPublicInstance<any>>) =>
  received && typeof received === 'object' && typeof received['isVueInstance'] === 'function'
const removeServerRenderedText = (html: string) => html.replace(/ data-server-rendered="true"/, '')
const removeDataTestAttributes = (html: string) => html.replace(/ data-test="[-\w]+"/g, '')
const removeUniqueAttributes = (html: string) =>
  html
    .replace(/ data-server-rendered="true"/g, '')
    .replace(/ data-v-[-\w]+=""/g, '')
    .replace(/ data-test="[-\w]+"/g, '')
    .replace(/"el-tooltip-\d*"/g, '""')
    .replace(/"el-popper-\d*"/g, '""')
    .replace(/"el-popover-\d*"/g, '""')
    .replace(/"el-autocomplete-\d*"/g, '""')
    .replace(/"el-autocomplete-\d*\-item--\d*"/g, '""')
    .replace(/"el-collapse-head-\d*"/g, '""')
    .replace(/"el-collapse-content-\d*"/g, '""')
    .replace(/"dropdown-menu-\d*"/g, '""')
    .replace(/"line-chart-\w*(-\w*)*"/g, '""')
    .replace(/progress-circle-component__LinearGradient-\d*/g, '')
    .replace(/style=\"z-index: .*;\"/gi, '')
    .replace(/div-gpt-ad-\d*-\d*/g, '')

export default {
  test(received: any) {
    return isHtmlString(received) || isVueWrapper(received)
  },
  print(received: any) {
    let html = (isVueWrapper(received) ? received.html() : received) || ''
    html = removeServerRenderedText(html)
    html = removeDataTestAttributes(html)
    html = removeUniqueAttributes(html)

    return beautify(html, { indent_size: 2 })
  },
}

And on my setup file for Vitest's config, I added the following:
import vueSnapshotSerializer from 'test/vitest-serializer-vue'

// Add Snapshot Serializer
expect.addSnapshotSerializer(vueSnapshotSerializer)

2.
I just thought that it could be a feature that could possibly attract more people to make the change from Jest to Vitest.
On large applications/codebases, this could be something that can frighten people to do this change.
Although, at the same time, I completely understand that this would never be something on the top of the priorities right now 👌
Maybe something to think of for the future 😄
I'll be moving on with the migration by updating all the snapshots and compare them through git's diff, just like you suggested.
I appreciate all the help! Keep up the great work!

I'm not sure if this is safe to do in Vitest core, since frontend unit testing is not it's only goal. We will mention it in Migration Guide tho.


Async/await in Flask 2.0+ breaks due to decorator order

Name
Version

Flasgger
<IP_ADDRESS>

Flask
2.3.2

Python
3.9, 3.10

OS
macOS 13.3

I'm setting up a basic Flask project with an asynchronous route. I want to fetch information online using the selenium package, and this requires the Flask route to await for the task to finish.
I've been using @swag_from() decorators to document my code and make it easier to work with, here is an idea of what my code looked like:
@website_api.route('/get-data-from-page', methods=['POST'])
@swag_from('swagger/get-data-from-page.yml')
async def get_data_from_page():
    data = req.get_json()
    res = await common.get_data_from_page(data["url"])

    return json.dumps({ "data": res }), 201

For some reason, this kept throwing: TypeError: The view function did not return a valid response. The return type must be a string, dict, list, tuple with headers or status, Response instance, or WSGI callable, but it was a coroutine.
After a couple of hours of trying everything, re-installing Python and both libraries, I found the issue.
This causes the error:
@app.route(<route>)
@swag_from(<file>)
async def route():
    # ...

This doesn't:
@swag_from(<file>)
@app.route(<route>)
async def route():
    # ...

(Note the order of the decorators)
Now, this might not be a bug at all, it even might not have anything to do with flasgger and could be a problem is Flask directly. But the README of this project says to do it like so:
@app.route('/colors/<palette>/')
@swag_from(specs_dict)
def colors(palette):
    # ...

Maybe a switch between those two lines in the README and any documentation would be interesting?

Thank you @phil-chp , I have the same problem as you with Flasgger | <IP_ADDRESS> and I changed the order of the decorators and voila it works!!!!

Thanks @phil-cho, I was stuck on this trying to understand the problem of it not working with async. It kind of doesn't wait for the await from inside the function. Anyway, it solved it temporarily, thanks a lot!


Fix parse issue due to missing space

QTBUG-129592 : Parsing error due to missing space between key and value in annotations in QFace file.

Please also add a new unit-test for the problem as well

done


Introduce a Vezel.Novadrop.Interop library for in-memory client interaction

This library will provide type definitions and function bindings for many of the common classes used in TERA. A few obvious examples:

S1Context, S1CallbackHandler
S1DataDB, S1DataQuery, S1DataNode, S1DataAttribute
S1GameObject, S1Player, S1User
S1ConnectionManager, S1CommandQueue
S1ClientSocket, S1CryptSocket
Cipher, NullCipher, PikeCipher

The goal is for this library to enable a wide array of in-memory modding scenarios.
Note: Only the unpacked r387486 client will be supported out of the box, but the library should enable people to plug in their own addresses or search patterns (e.g. for r367239).

This library will be marked experimental initially, as the API is likely to evolve quite a bit over time.

Blocked on #90.


Maximum allowed event / packet size

> From a throttling perspective, an ingressed data packet that has a packet size of 32 KB is treated as 32 events, each 1 KB in size.
> The maximum allowed event size is 32 KB. Data packets larger than 32 KB are truncated.
I think you mean "maximum allowed packet size is 32 KB", since the maximum event size has been limited to 1 KB before.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 750c5eeb-be8d-a927-7c63-1fbce1e92cc0
Version Independent ID: 6e55272d-b6fa-64df-a7b8-243c28c111bb
Content: Plan your GA environment - Azure Time Series Insights
Content Source: articles/time-series-insights/time-series-insights-environment-planning.md
Service: time-series-insights
GitHub Login: @deepakpalled
Microsoft Alias: dpalled

Thanks for the feedback! We are currently investigating and will update you shortly.

Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

This doc change is under review
#please-close


[Feature Req.] using Musixmatch as lyric source

I'm wondering how eeveespotify did that, and can you try it?

eeveespotify need my Musixmatch user token instead of api key to enable the Musixmatch source

So, I thought you might do that

This is planned. but im not sure when i will be free to do it


[Docs] Add onboarding documentation to Wiki

Some things to include:

Required tutorials:

Android development with Android Studio
RxJava tutorial / videos
Basic dependency injection with Dagger 2
Git and Github tutorials
Reactive MVVM architecture
JUnit, Espresso

Optional intro tutorials:

Intro to Android databinding
Cloud Firestore
Room ORM
Maps API for Android

Links to other relevant Wiki docs

@scolsen FYI

Related #102


Passes config through

Something like that I would like to add.
Sandbox.jl
module Sandbox

"""
!!author( Michael Hatherly)
!!license( [MIT](https://github.com/MichaelHatherly/Lexicon.jl/blob/master/LICENSE.md))

Holds the parsed user query.

!!fields(

* `objects`: The objects that will be searched for in metadata.
* `modules`: Modules to be searched through for documentation.
* `index`:   1-based, for picking an individual entry to display out of a list.)

!!page(Lexicon.md/Exported/1)
"""
type Query
    objects :: Vector
    modules :: Set{Module}
    index   :: Int

    Query(objects, modname, index) = new(objects, Set([modname]), index)
    Query(objects, index)          = new(objects, documented(), index)
end

end

REPL

require("Sandbox.jl")

import Docile: Formats, Cache, Utilities
using Compat

function Formats.metamacro{name}(::Formats.MetaMacro{name}, body, mod, obj; conf::Utilities.AbstractConfig=EmptyConfig())
    Cache.getmeta(mod, obj)[name] = strip(body)
    haskey(conf.metadata, name)              ?
        string(conf.metadata[name][1], body) :
        string(ucfirst(string(name)), ": ", body)
end

type Config <: Utilities.AbstractConfig
    metadata         :: Dict{Symbol, @compat(Tuple{UTF8String, ASCIIString})}

    Config(; arg...) =  new(Dict(:author  => ("笔者:", "*"),
                                 :license => ("License:", "*"),
                                 :fields  => ("Fields:", "####")))
end

function mainrun(conf::Utilities.AbstractConfig)
    raw_ = Docile.Cache.getraw(Sandbox)
    for (obj, rawtext) in raw_
        parsed = Docile.Cache.getparsed(Sandbox, obj; conf=conf)
        println(parsed)
    end
end

conf = Config()
mainrun(conf)

OUTPUT:

笔者: Michael Hatherly
License: MIT
Holds the parsed user query.
Fields:

objects: The objects that will be searched for in metadata.
modules: Modules to be searched through for documentation.
index:   1-based, for picking an individual entry to display out of a list.

Page: Lexicon.md/Exported/1

A note I renamed my DocileExperimental to just Docile.

Will still improve it a bit.

Added one inline comment with a question?

Once the inline question is sloved and one can interact with it in both ways:
function extractmeta!(raw::IO, mod::Module, obj; conf::AbstractConfig=EmptyConfig())
end

function extractmeta!(raw::IO, mod::Module, obj)
end

I think it would be quite nice. Opens up a lot of options as well the option to include config settings. I hope you can consider something like that. should not really do much harm when the problem from above is solved.

There's already some places you can get stored "config" information from when inside a metamacro call: getpackage(::Module).metadata, getmodule(::Module).metadata, and getmeta(::Module, obj). findmeta will go searching through all of those for a metadata entry as well.
Have you got a use case where none of these would apply?
I think it would be better make it simpler to pass in additional metadata when constructing PackageData objects.

So instead of an extra config: do most of the thing with internal metadata associeted with an module?
If that is easily to add qute at the beginning that could work just as well.

internal metadata associeted with an module?

Yes, since the metadata can be specified by a package author it's for them to use as they want.

If that is easily to add qute at the beginning that could work just as well.

I'm thinking something like a .docile config file in the root directory that gets read in when building a PackageData object for the corresponding package. Could contain additional metamacro definitions and metadata fields. (Just some ideas, need to have a good think about it though.)


feat(buttons): allow toggling via spacebar when focused

Allow the spacebar to toggle the button state when focused

Resolves #4252.

Sounds good to me.


A vertical stripe goes over the whole Obsidian note

Thanks for your great plugin.
Sometimes I see a vertical blinking stripe over the whole Obsidian note. When I restart obsidian, the stripe goes away.

For me, the issue is not easily reproducable.
Do you have any idea, where it comes from?

Ha - today I found it in action ...

And sometimes, it is only a little rectangle.

Sorry for being late!
I think that this could caused by finding some focusable areas before the text area has been found.
I suppose that this problem is probably not so fatal. If you have moved the caret to some meaningful area, it might be shown correctly. Or, toggling React to editor-ish elements might make the situation better.
If it is just a little bit of an obstruction that shows up at the beginning, and can be quickly reverted, I would like to leave it as a specification. Is there any real harm done?


Expecting Error value wrapped in an Exit would not be equal using @effect/vitest

What version of Effect is running?
3.2.3
What steps can reproduce the bug?
import * as it from "@effect/vitest";
it.addEqualityTesters();

import { Schema } from "@effect/schema";
import { Exit } from "effect";

class SchemaTaggedError extends Schema.TaggedError<SchemaTaggedError>()(
  "SchemaTaggedError",
  {
    msg: Schema.String,
    other: Schema.String,
  }
) {}

it.it("test error", () => {
  it.expect(new SchemaTaggedError({ msg: "a", other: "other" })).toEqual(
    new SchemaTaggedError({ msg: "a", other: "other" })
  );
});

it.it("test exit with string value", () => {
  it.expect(Exit.fail("d")).toEqual(Exit.fail("d"));
});

//This pass, however error values are not the same
it.it("test exit with error value", () => {
  it.expect(
    Exit.fail(new SchemaTaggedError({ msg: "a", other: "other" }))
  ).toEqual(Exit.fail(new SchemaTaggedError({ msg: "b", other: "other" })));
});

What is the expected behavior?
The 3rd test should fail.
What do you see instead?
The 3rd test pass.
Additional information
I'm using latest version as follow:

vitest 1.6.0
@effect/vitest 0.5.3
effect 3.2.3

Even though something is deeply odd because the following correctly fails:
import * as it from "@effect/vitest"

import { Schema } from "@effect/schema"
import { Exit } from "effect"

class SchemaTaggedError extends Schema.TaggedError<SchemaTaggedError>()(
  "SchemaTaggedError",
  {
    msg: Schema.String
  }
) {
}

it.it("test exit with error value", () => {
  it.expect(new SchemaTaggedError({ msg: "a" }))
    .toEqual(new SchemaTaggedError({ msg: "b" }))
})

cc @sukovanej

Thanks @mikearnaldi to check it out this issue. Few month ago, I already reported an issue on vitest repo, and I was using a custom matcher that properly compare Error instances (by not only considering the msg property). Likewise, I asked this morning to the same thread https://github.com/vitest-dev/vitest/issues/5244

even adding a custom matcher for errors doesn't work, it looks like it is ignored...

even adding a custom matcher for errors doesn't work, it looks like it is ignored...

Yes. Also, there is a recent issue related to the cause prop on Error instances reported on https://github.com/vitest-dev/vitest/issues/5697 not sure it's related.


Made changes in Homepage UI

Get Started Button backgound changed to black at certain transparency
Text made bold
Page 3 Jumbotron made more opaque

Please generate a link so that i can see your changes! Refer this.

Hey @ManishMadan2882! Please follow these steps and generate the PR again.


I had to reboot to find Obsidian

Thanks for this plug-in. It promises to be very useful. I tried setting hotkeys to hide and reveal Obsidian. I was successful in hiding one of the vaults but I couldn't make it reappear.  I could open other vaults. I had to reboot to see it again. Is this intentional?

Hey @kmaustral! Thanks for the report 🙏
Just a couple questions:

Which platform are you on?
I am guessing that you tried the Show/Hide shortcut again, and it would never reveal itself?
When trying to show again, did you have multiple vaults open?

I'm not familiar with having multiple vaults configured: Does each vault have its own set of plugins? If so, was this configured on multiple vaults?
There is a deficiency on MacOS: If you use the "Hide" shortcut, you cannot (for example) ⌘-Tab back to the window, you need to use the "Show" shortcut or the "Show/Hide" shortcut.
Thanks!

I have the same problem.

Linux Mint 20.3 Cinnamon

I have several vaults. My main vault and the Obsidian help vault (working as manual and as a good testing ground to see it my issue relates to Obsidian or to one of many plugins and personal settings). Vaults have their own set of plugins and settings.

I had only my main vault open.
I installed the plugin, set the hotkey for "Show/Hide Obsidian" and pressed it.
Obsidian disappeared, but continuous pressing of the same hotkey did nothing. Yes, I checked other workspaces and both monitors (taskbar is also empty). Obsidian itself is in RAM memory.
Getting to the vault choice/opening interface. Other vaults are opening while choosing the main one does absolutely nothing.

In the end I had to go check my .git info (thanks God it was set up) and manually remove the hotkey and the plugin files.
I hope that this issue will be fixed, because I have really been thirsty for such a feature.

I case somebody is searching for a solution to hide/show Obsidian (or any other program, for that matter), there is a system-wide (Obsidian agnostic) solution: https://github.com/mjessome/obsidian-global-hotkeys/issues/6#issuecomment-2412484969


Development

To develop this project, the following was done:

build a a single-page application (SPA) built with React and Redux
retrieve data from  API and store it in the Redux store
filter retrieved data from the API using a Filter stateless component
create unique a route for every page within the SPA
deploy project using Netlify
No linter errors
Follow given designed
Make a video explaining project

The pull request was marked as invalid by @ademibowale, but I did not receive any feedback on what needs to be done to make it valid. Please, explain to me how to fix the Gitflow . 🙏🏼 Thank you

@eamador1 Once you start working on any project, initialize its main branch. You also need to create a development branch. Then you need to make your development branch the default branch.
After that, add changes in a feature branch(es). You will need to create a pull request to compare your feature branch with the development branch and submit the link to that pull request via your Dashboard. After you submit the link to your pull request, you will get a code review from one of our code reviewers.
You should not merge your pull requests to the main branch or development branch of your project without a code review that approves your changes.

@ademibowale  I created the main branch, the development branch and two feature branches. So I was not supposed to mer get the feature branches to the development branch? Was I suppose to make a feature branch and make a pull request to the development branch for you to check? Ok. What can I do to solve this? Start the project from scratch?

@eamador1 make your Dev branch your default branch and create a feature branch from the default branch commit your work in the feature branch and submit the pull request from the feature branch ,means your are to submit a new pull request for review

@ademibowale
I appreciate you. I understand what you are saying, and in fact I was doing it, but all my partners have done their projects the way I did it. The gitflow says the following:
The development branch is also a snapshot of your application , but rather than deploying to production, the development branch could be used at any moment for developing new features with multiple collaborators. Your teammates need a stable version of your project to start implementing changes, so maintaining a development branch will give them stable code to work from.
So, what you are saying is that development branch is not the stable branch from which we work, but rather we must have a feature branch as our stable branch.

@eamador1 yes correct


Search for config file in parent folder

When using stryker in a monorepo it's helpful to have a common stryker config in a parent folder which can be overwritten by configs in the sub packages if necessary.
├── package.json
├── packages
│   ├── pack1
│   │   ├── package.json
│   │   └── stryker.conf.json
│   ├── pack2
│   │   ├── package.json
│   │   └── stryker.conf.json
│   ├── pack3
│   │   ├── package.json
│   │   └── stryker.conf.json
├── stryker.parent.conf.js

However, if I don't want to overwrite it I still have to include an additional package config file which only includes the parent config like this:
module.exports = require('../../stryker.parent.conf')

It would be great if stryker does automatically look for config files in parent folders if no config can be found in the current working directory.

How would you expect this work exactly?
If you run stryker run inside parent/packages/child, look for stryker.conf inside the current dir. If not found, walk up until you find one. I understand that part.
What should happen if a stryker.conf file is found inside parent? For example, it specifies { "mutate}: ['src/**/*.ts'] }, should that globbing expression be done from parent? Or from the cwd? The same goes file discovery, sandbox directory location, etc.

Good question. I would have handled the paths relative to the cwd. So basically, it just works like explicitly specified config files are handled right now. Let's say we are currently running stryker run  ../../stryker.json  but with the new feature we can also just do stryker run and leave the paths in the config file unchanged.

I have to be honest, I don't know if this is expected behavior. When loading a project file from a directory, one might expect the files to be resolved from that directory.
This is what we had in mind with a "baseDir" or "projectRoot" configuration. We closed this issue later, because of time constraints, but I would still like a "baseDir" option: #650
In that case stryker run --baseDir . ../../stryker.json would work and after this change is merged this should work: stryker run --baseDir .. But this would not work stryker run (since that would resolve files from ../..).


Getting Crop Image Instead of Full Image

Hi,
I am trying to apply the cropping operation according to the coordinates which comes from cvapp_yolo8n_ob.cpp file. I have found where the cropping macros are defined. However, I did not understand how to combine the it together. Are there any suggestions that you can give me?
Thank you,

Hi @saricaBugrahan ,
You can use the hx_lib_image_copy_helium to crop image.
the input parameters are following.
/**
 * @brief Extract a region from a given image. using Helium optimize.
 *
 * @param[in] im input image address
 * @param[out] cropped Cropped image address
 * @param[in] input_w  the weight of input image
 * @param[in] input_h  the hight of input image
 * @param[in] input_c the channels of input image
 * @param[in] dx The x-coordinate, in logical units of the crop offset.
 * @param[in] dy The y-coordinate, in logical units of the crop offset.
 * @param[in] w The width of the crop.
 * @param[in] h The height of the crop.
 */
void hx_lib_image_copy_helium(uint8_t* im, uint8_t* cropped, int input_w, int input_h, int input_c, int dx, int dy, int w, int h);


Enhance completion of pattern-triggered snippets.

Right now completion inserts the trigger-string literally and expands, which doesn't really work for snippets that have a pattern as trigger as eg. "%d" doesn't match "%d".
This PR would expand an intermediary snippet so the user can edit the parts of the pattern that aren't just plain text ("head(%d)" -> head${0:%d}).
After jumping to the $0, the snippet would have to be expanded manually.
What do you think of this behaviour?

Yeah looks great. I'll merge it 10 minutes or so :) just need to get a coffee

Sweet, ty :)

It's done :D


[DOCS]: ModuleNotFoundError: No module named 'buildtest'

Documentation Link
https://buildtest.readthedocs.io/en/devel/contributing/regression_testing.html
Issue Description
Apparently the documentation is not showing the help message properly. This documentation page can be found in https://github.com/buildtesters/buildtest/blob/devel/docs/contributing/regression_testing.rst file. It leads me to believe the sys.path is not setup properly however it should be working considering we have this set in conf.py
https://github.com/buildtesters/buildtest/blob/a3feb8637e5a138095d4c5f1f7b6e77084ad4eaa/docs/conf.py#L19-L20
$ python $BUILDTEST_ROOT/buildtest/tools/unittests.py --help
Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/buildtest/checkouts/devel/buildtest/tools/unittests.py", line 8, in <module>
    from buildtest.defaults import (
ModuleNotFoundError: No module named 'buildtest'

This command should work but it is not. The expected output should be
(buildtest)  ~/Documents/github/buildtest/ [devel] python $BUILDTEST_ROOT/buildtest/tools/unittests.py --help
usage: unittest [-h] [-c] [-p PYTESTOPTS] [-s SOURCEFILES]

Run buildtest unit tests

optional arguments:
  -h, --help            show this help message and exit
  -c, --coverage        Enable coverage when running regression test
  -p PYTESTOPTS, --pytestopts PYTESTOPTS
                        Specify option to pytest
  -s SOURCEFILES, --sourcefiles SOURCEFILES
                        Specify path to file or directory when running
                        regression test

Post question in Slack

[X] I agree that I posted my question in slack before creating this issue

Is there an existing issue

[X] I confirm there is no existing issue for this issue

Why mine is working?
command: python $BUILDTEST_ROOT/buildtest/tools/unittests.py --help

yes i know it works for me too it doesn't work in the readthedocs build.
The only thing i can think of is add sys.path.insert to root of repo it is failing when importing the module but i dont get why it fails since the rest of docs is working.
 sys.path.insert(0, here)

The actual command is run with shell mode so it should understand $BUILDTEST_ROOT. This is documented in https://pythonhosted.org/sphinxcontrib-programoutput/#command-execution-and-shell-expansion

The rest of docs is working because they are code-block rather than command-output.


not concurrent connections during sync/pull

Expected behavior
All accounts and mailboxes are checked one-by-one (or at least how it looks like judging from the status in the main window) during Pull (push/idle works differently and it seems that notifications are generated concurrently)
Actual behavior
They should be checked at the same time
Steps to reproduce

open the app with multiple accounts/mailboxes
hit "sync"

Environment
K-9 Mail version:5.203
Android version:6.0.1
Account type (IMAP, POP3, WebDAV/Exchange): 3x IMAP

We currently have a push connection per folder, one polling connection and one sync connection I think.
We need to be careful regarding connection limits but I definitely think we could synchronise multiple accounts at the same time. There's existing discussion been had about making MessagingController more intelligent and this fits nicely with that.

Well, I've tried searching for relevant issues but failed to find such so I've created this one.
I'm aware about the limitations and restrictions of connection number so here is my use case:

when I'm on wifi I have synchronization ON and user IMAP IDLE for a couple of directories (and don't run into problem of to many connections);
when I leave wifi I have sync switched OFF (automatically) and only check mail when needed (pull in this case) so this shouldn't collide with the connection number limit on the server even if checking multiple folders at the same time.

I was about to open another "issue", but slightly different from this one.
I use k9mail to sync my gmail account, and i syncronize inbox folder and sent folder.
To spare some battery juice, it would be nice if k9 would be able to to do both pulls in a single shot.

@kokoko3k Change the 'Sync class' for the Sent folder.

They already are 1st class, both inbox and sent.
Still, k9 first pulls inbox, then pulls sent folder (in italian is "Posta inviata", here's the logcat output:
03-24 11:10:15.571 I/k9      ( 3180): Running command 'checkMail', seq = 22(backgroundpriority)
03-24 11:10:15.577 I/k9      ( 3180): Running command 'sendPendingMessages', seq = 23(backgroundpriority)
03-24 11:10:15.579 I/k9      ( 3180): Running command 'syncINBOX', seq = 24(backgroundpriority)
03-24 11:10:17.690 I/k9      ( 3180): Running command 'sync[Gmail]/Posta inviata', seq = 25(backgroundpriority)
03-24 11:10:18.358 I/k9      ( 3180): Running command 'clear notification flag for<EMAIL_ADDRESS>seq = 26(backgroundpriority)
03-24 11:10:18.373 I/k9      ( 3180): Running command 'finalize sync', seq = 27(backgroundpriority)
[..]
03-24 11:11:18.484 I/k9      ( 3180): Running command 'checkMail', seq = 28(backgroundpriority)
03-24 11:11:18.492 I/k9      ( 3180): Running command 'sendPendingMessages', seq = 29(backgroundpriority)
03-24 11:11:18.496 I/k9      ( 3180): Running command 'syncINBOX', seq = 30(backgroundpriority)
03-24 11:11:20.797 I/k9      ( 3180): Running command 'sync[Gmail]/Posta inviata', seq = 31(backgroundpriority)
03-24 11:11:21.736 I/k9      ( 3180): Running command 'clear notification flag for<EMAIL_ADDRESS>seq = 32(backgroundpriority)
03-24 11:11:21.751 I/k9      ( 3180): Running command 'finalize sync', seq = 33(backgroundpriority)
[..]
03-24 11:12:21.837 I/k9      ( 3180): Running command 'checkMail', seq = 34(backgroundpriority)
03-24 11:12:21.847 I/k9      ( 3180): Running command 'sendPendingMessages', seq = 35(backgroundpriority)
03-24 11:12:21.850 I/k9      ( 3180): Running command 'syncINBOX', seq = 36(backgroundpriority)
03-24 11:12:23.895 I/k9      ( 3180): Running command 'sync[Gmail]/Posta inviata', seq = 37(backgroundpriority)
03-24 11:12:24.653 I/k9      ( 3180): Running command 'clear notification flag for<EMAIL_ADDRESS>seq = 38(backgroundpriority)
03-24 11:12:24.694 I/k9      ( 3180): Running command 'finalize sync', seq = 39(backgroundpriority)

As you can see, "sent-box poll" (Posta inviata) comes after "inbox poll" has finished, i was talking about parallelizing, because sometimes the pull process  takes a lot of time to complete (for reasons i ignore, maybe is gmail itself).

Oh right yep, that's the function of this ticket.

This is more of an issue when one of several mailservers is very slow or in trouble and you have to wait until it times out before K9mail can get to the next one. That's exactly what I've been getting for years with two out of the six servers I poll manually.


Test contracts with spaces and quoting

@see https://github.com/sodadata/docs/issues/812
Test contracts that require database-specific quoting.  Like for case sensitive table and columns names.
Also column names with spaces should be tested.

SAS-3765


Files with a '#' character can't be opened when an error occurs ('Problems' menu)

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.62.0
OS Version: Windows 10
Extensions: Debugger (C# and C/C++ from Microsoft)

Steps to Reproduce:

Create a Workspace with a '#' in the path
Create a project (C# or C++) which contains an intentional error
Run the project, the "error" occurs (this is normal, we wanted it)
Open the 'Problems' menu, the file with the "error" can't be opened because the path is cut before the '#'

Example:
I create a project with C:\Code\C#\tools\main.cpp
#include <iostream>
int main()
{
	std::cout << "Hello world!" << std::endl;
	int foo = "bar";
	return 0;
}

Then I execute the project using VS Code (with tasks.json and launch.json) to get the "error" ("bar" can't be converted to int, legit)

What happens:
I got the "error", but the path is C:\Code\C and I can't open it because this file doesn't exist.

What I expected:
When I rename the folder C# to CS, the "error" opens C:\Code\CS\tools\main.cpp as expected.

I guess this also happens for '?' characters, but I can't test it on Windows.

#include
int main()
{
std::cout << "Hello world!" << std::endl;
int foo = "bar";
return 0;
}

This works just fine with TypeScript and other extension. It must be a case of double encoding/decoding with the C++ extension. Please forward this issue to them

/extCpp

Re-open, need to know where the problem definition comes from. @Jiogo18 Is that your own problem matcher or one from the extension?

Ok, so without the C++ extension, the task can't be executed (and I don't know how to link a local gcc with problemMatcher).
But in C# we don't need the extension to run the task, and the same thing happens :
{
"label": "build",
"command": "msbuild",
"problemMatcher": "$msCompile"
},

(created with dotnet new console)
using System;
namespace Calendar
{
	class Program
	{
		static void Main(string[] args)
		{
			Console.WriteLine("Hello world!");
			Console.WriteLine(this_is_a_non_defined_variable_to_do_an_error);
		}
	}
}

And the build has the full path:

Adding @alexr00 for the problem matcher specifics


FEA : Add Label component

Coverage remained the same at 100.0% when pulling a83261b199d024e58656d940a4585a4f4807c151 on fea-label-component into d04631d4947a7bd07eae301ed865492fe956d27e on develop-1.0.0.

Coverage remained the same at 100.0% when pulling e10c8849e3bbc2f0e3944640f76938c2639fd7ad on fea-label-component into d04631d4947a7bd07eae301ed865492fe956d27e on develop-1.0.0.


Nofitications and Apple Watch

I think I found the bug. When the phone is connected with the Apple Watch via Bluetooth, the notifications do not wake up the screen and do not give any sound. If the Apple Watch is connected only via wifi, works fine.
To Reproduce
Steps to reproduce the behavior:

Connect Apple Watch to the iPhone via Bluetooth
Keep you iPhone locked
Ask someone to send you a WhatsApp message or text message
The iPhone do not give any sound and the screen stay black

Device (please complete the following information):

iOS Version: 13.3
iOS Device: iPhone XR
unc0ver Version: 4.0.0, 4.0.1, 4.0.2 and 4.0.3

Place an "x" between the brackets if true:

[ ] this is a bug others will be able to reproduce
[ x] this issue is present with all tweaks uninstalled(except for default packages) or disabled
[x ] this issue is present after a rootfs restore
[x ] this issue is present on the latest version of unc0ver

Fixed


Add configcheck command

What does this PR do?
Add a configcheck command that helps investigating the current loaded/resolved configs for each config provider:

Additionnally with a -v option it can output debug info such as the warnings during resolve and the templates yet to be resolved:

The output of this commande (in debug mode) is added to the flare to a config-check.log file
Motivation
The autodiscovery is a piece of the agent where a lot of components could go wrong (template, ad identifiers, discovery...) and that's why we need a tool to give an idea of the current state of a running agent for development & debugging purposes

https://github.com/DataDog/datadog-agent/issues/1159

and thanks for the eyes @tmcarr, we'll fix it asap. Making troubleshooting easier is a high priority.

@hkaj static config errors added to the command output via https://github.com/DataDog/datadog-agent/pull/1189


Serverpod CMS UI

It would be really nice to have a simple CMS for serverpod.
Most cases when using an API is it quite useful for business to also have simple way to manage data in a CMS.
MVP:

[ ] CRUD actions would be really nice to start with.
[ ] Database relationship links

Future:

[ ] Custom CMS actions
[ ] Custom CMS UI
[ ] Option to create a new object when linking a relationship
[ ] ...

+1 to this , great inspiration can be found in 👉🏻 https://strapi.io/

I think this could be a cool project to add externally - there are quite a few firebase CMS solutions out there - maybe we can collect the minimum requirements here and the build it out as a community project?

That is indeed what I am planning to do as an alternative (because I need a CMS for a project). I was just not sure if this was something that was planned by serverpod itself.

I also think if serverpod organization is not planning to work on this feature in the near feature we can build it as a community project , otherwise I think it would be better if such a feature was properly integrated in the original project -served out of the box or as a plugin - as it is an essential feature for so many projects using serverpod.

Hi @SandPod  I am already working on something. And testing some things out. I will post my progress here in the coming weeks

Hi @SandPod I am already working on something. And testing some things out. I will post my progress here in the coming weeks

Cool, love to try it when it's ready.

I am finishing my UI library that will be the base of the CMS implementation I am doing.
https://example.impaktfull-ui.opensource.impaktfull.com/


Update mgov.njk

👷 Deploy Preview for fancy-puffpuff-df775f processing.

Name
Link

🔨 Latest commit
8ef49cdd332d8b3aaa44c088b1a96a9a82368448

🔍 Latest deploy log
https://app.netlify.com/sites/fancy-puffpuff-df775f/deploys/666dd298148c0e0008b5d030


[Test] Build WithKyuubiServerOnKuberntes

Why are the changes needed?

Refactor KyuubiOnKubernetesTestsSuite
Build WithKyuubiServerOnKuberntes like WithKyuubiServerOnYarn
How was this patch tested?

[x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

Codecov Report

Merging #2359 (bad6720) into master (9e48608) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2359      +/-   ##
============================================
- Coverage     62.68%   62.67%   -0.02%
  Complexity       69       69
============================================
  Files           357      357
  Lines         16915    16899      -16
  Branches       2276     2278       +2
============================================
- Hits          10603    10591      -12
+ Misses         5330     5324       -6
- Partials        982      984       +2

Impacted Files
Coverage Δ

...ubi/engine/trino/session/TrinoSessionManager.scala
66.66% <0.00%> (-9.53%)
:arrow_down:

...apache/kyuubi/engine/hive/HiveProcessBuilder.scala
84.61% <0.00%> (-6.30%)
:arrow_down:

.../engine/spark/session/SparkSQLSessionManager.scala
75.67% <0.00%> (-4.76%)
:arrow_down:

...yuubi/engine/hive/session/HiveSessionManager.scala
80.00% <0.00%> (-1.40%)
:arrow_down:

...n/scala/org/apache/kyuubi/KyuubiSQLException.scala
91.56% <0.00%> (-1.21%)
:arrow_down:

...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala
81.87% <0.00%> (-0.93%)
:arrow_down:

...ala/org/apache/kyuubi/session/SessionManager.scala
87.78% <0.00%> (+0.28%)
:arrow_up:

.../org/apache/kyuubi/operation/KyuubiOperation.scala
68.00% <0.00%> (+1.33%)
:arrow_up:

...rg/apache/kyuubi/engine/trino/TrinoStatement.scala
71.26% <0.00%> (+1.38%)
:arrow_up:

.../engine/flink/session/FlinkSQLSessionManager.scala
100.00% <0.00%> (+3.44%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e48608...bad6720. Read the comment docs.

Seems CI test fail, have nothing to do with kubernetes - it test.

thanks, merging to master


Orbot compatibility

I tried to use TetherFi with Orbot, but it seems not working:
https://github.com/guardianproject/orbot/releases/tag/17.1.0-BETA-3-tor.<IP_ADDRESS>
Is it a bug or something that can't be fixed?

Hello,
I have no idea what Orbot is or what it does.
Does TetherFi work without Orbot?
If it does: When Orbot is turned on, what stops working?

Starting TetherFi on the first phone
Connecting the second phone to the hostpot
The second phone is working on Internet
Starting Orbot and Tor on the first phone
The second phone stops working on internet

Or

Starting Orbot and Tor on the first phone
Starting TetherFi on the first phone
Connecting the second phone to the hostpot
The second phone isn't working on Internet

Sounds like Orbot is not compatible, probably similar to some VPNs that don't play nice.
I think this is out of my hands unfortunately


[WIP] navigateModalScreen fixes

Describe your changes
Screenshots [Optional]
Issue ticket number and link
Closes #663
Checklist before requesting a review

[ ] I have performed a self-review of my code
[ ] I have added tests
[ ] I have added a changeset pnpm changeset add
[ ] I have added example usage in the kitchen sink app

Superseded by #670


Can't send webhooks with attachments

Git commit reference
6cf7c038d4b37364bde1b654f4fbb65e0a44464f
Describe the bug
When i send a message with an attached file using execute_webhook, it only sends the message.
To Reproduce

create a message object
attach a file to it with add_file
run bot.execute_webhook with this message
The file doesn't show up

Expected behavior
The message and the file to be sent

thanks, added in 7841ab57aff30a349edcaabfe2d1f6b70d1743e8


⚠ Bofrost.de has degraded performance

In 4ba8590, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 885 ms

Resolved: Bofrost.de performance has improved in b935328 after 9 minutes.


Use UTF-8 as default encoding for Node#serialize

Node#serialize used to return UTF-8 if no encoding was given. However this got broken in commit 53f9b66ee6.
Since UTF-8 is the default in XML and HTML5 specs, it makes sense to use UTF-8 in serialize as well and enforce this in the tests.
Fixes #1659

LGTM. Merging. Thank you, @larskanis!


Assembly Strong Name

I would like to test the latest prerelease version available through nugget.org.
However, when I compile my solution I got the error:  Assembly generation failed -- Referenced assembly 'MahApps.Metro' does not have a strong name…
Is there something that I must do in order to compile my app with the prerelease versions?
Jac
PS: Thanks for this awesome library 

Uncheck    Properties>Signing>"Sign the assembly"

Just call me IDIOT !!!!
Thanks a lot for your help.

Jac


Adding network ad support

Extra code needs to be added to the top of the index.html file

@willeastcott Can you review when you get chance please?

Approved with a couple of comments.


File Explorer: Move Selection into New Folder

Description of the new feature / enhancement

Select several files in File Explorer
right click, select "Move n files to New Folder"
new folder is made, selected files are moved into it
the folder is selected and put into rename mode

Scenario when this would be used?
While managing files, such as when cleaning up your downloads folder
Supporting information
Mac OS Finder provides this out of the box.
this SendTo batch file
can provide a similar experience, but the Send To menu has been moved to the secondary context menu in Windows 11.

/dup #139


Support for code in the response message

Right now all response is seen in the form of code message. need to see the code in proper format

Markdown (issue #7) or the HTML support (PR #24) may solve it. Perhaps this issue can be closed in favor of it?


Doc Bug: Build Failure on UI goal w/ Maven 3.0.5

Summary
Build failure due to module not compatible with system Maven.  The documentation does not specify any version of Maven so I used the default.  Might want to make this clear in the docs, little to nothing on requirements.
Configuration

Ubuntu 14.04 Trusty Tahr (clean)
Java 1.8.0_171-b11

Steps

Install Oracle Java 1.8.0
Install Maven - apt-get install maven
cd /path/to/hygieia
mvn clean install package

Expected Results
As per instructions, expected it to not error: http://capitalone.github.io/Hygieia/setup.html
If a particular version of Java and/or Maven are required, then expected this would be documented in setup.
Actual Results
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:48.570s
[INFO] Finished at: Mon May 28 00:55:05 UTC 2018
[INFO] Final Memory: 121M/241M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:0.0.29:install-node-and-npm (install node and npm) on project UI: The plugin com.github.eirslett:frontend-maven-plugin:0.0.29 requires Maven version 3.1.0 -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginIncompatibleException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :UI

@darkn3rd The document has been updated with the Maven version. Refer #2250.


BUGFIX: Inject UriFactory

I think this injection is missing for the use in redirectToUriAndShutdown method.

totally right, thank you ❤


Propagate virtual swapchain image compression

When a VkImageCompressionControlEXT instance is found in the pNext chain of a VkSwapchainCreateInfoKHR instance at swapchain creation for a virtual swapchain, the same compression control should be used to create the images of virtual swapchain (the one not created by the WSI).
This is what this commit does.

CI gfxreconstruct build queued with queue ID 137720.

CI gfxreconstruct build # 3755 running.

CI gfxreconstruct build # 3755 failed.

CI gfxreconstruct build queued with queue ID 141004.

CI gfxreconstruct build # 3772 running.

CI gfxreconstruct build # 3772 passed.

CI gfxreconstruct build queued with queue ID 141623.

CI gfxreconstruct build # 3776 running.

CI gfxreconstruct build # 3776 failed.

CI gfxreconstruct build queued with queue ID 142232.

CI gfxreconstruct build # 3784 running.

CI gfxreconstruct build # 3784 passed.


SASS plugin includes

Version Info
Windows 11 (64 bit)
deno 1.23.2 (release, x86_64-pc-windows-msvc)
v8 <IP_ADDRESS>
typescript 4.7.2
lume v1.10.0
Description
The SASS docs Configuration chapter states:

includes: An array of directories to search for the @imported files. By default is _includes.

When I move .scss files outside the _includes directory, they get transformed to _site/whatever_dir/[file].css, even if I do not specify any sass.includes path.
I created the following project structure:
lume-root
 ┣ _includes
 ┃ ┗ sass
 ┃ ┃ ┣ index.scss
 ┃ ┃ ┗ _test.scss
 ┣ deno.json
 ┣ import_map.json
 ┗ _config.ts

// index.scss
@import "./test";

body {
  background-color: #000;
}

// _config.ts
import lume from "lume/mod.ts";
import sass from "lume/plugins/sass.ts";

const site = lume();

site.use(sass());

export default site;

When I run deno task serve, the .scss files are not getting transformed to .css.
In serve mode, if I make changes to the files they getting registered:
Changes detected:
- /_includes/sass/index.scss

I tried setting sass.includes with ./ and without ./ combinations as string and also as Array<string>, but nothing worked.

["./_includes/sass/"]
["./_includes/sass"]
["./_includes/"]
["./_includes"]

I created a different directory with an underscore _styles and moved the files in the directory, they not getting transformed. I also tried to specify the sass.includes.
So it seems, the plugins default is to search in every subdir of the rootdir, but not if the dir contains an underscore.
If you need I'll create an example for reproduction. Thanks for the great work!

The _includes folder contains files that can be included by other files but they aren't loaded and rendered if no other file include them. In your example, you have all scss files in the _includes folder but there isn't any other scss file outside this folder that import these files. Let's say you have this structure:
lume-root
 ┣ _includes
 ┃ ┗ sass
 ┃   ┗ component1.scss
 ┃   ┗ component2.scss
 ┣ deno.json
 ┣ import_map.json
 ┣ styles.scss
 ┗ _config.ts

And the styles.scss file (that it's ouside _includes so Lume will load it) import the other two files:
// styles.scss

@import "sass/component1.scss";
@import "sass/component2.scss";

This will output the _site/styles.css file with the content of the two imported files.

In your example, you have all scss files in the _includes folder but there isn't any other scss file outside this folder that import these files. Let's say you have this structure:

Okay, now I got it, If I set it up like this, it is working. Thanks for the explanation.
Closing.


Add change log link to program page and move it on IPTT reports

Issue
Change log should be easier to find
Acceptance criteria
Program page

[x] 1. In between the Indicator plan and GAIT link (when it exists) is a link called "Change log" <-- note sentence case along with the change log icon

Just FYI, here's a sneak preview of how I imagine the list looking after Satsuma

IPTTs (both types)

[x] 1. The Change log link appears just below the filter panel.

Housekeeping (where applicable)

[ ] Unit test/s written
[x] i18n strings included
[ ] Is accessible to people using screen readers

QA - PASSED

Link is now on bottom of IPPT filter - and the link successfully directs to the relevant change log

Link is now on the program page between Indicator plan and GAIT - and the link successfully directs to the relevant change log


Explicitly require Java 8 compatibility in the library

This is a copy of some bits in Jenkins Plugin Pom. It is a follow-up to the discussion with @jglick in https://github.com/kohsuke/access-modifier/pull/4

[x] Make Java requirement explicit in Maven Compiler. Stick to Java 6 for a while
[x] Enable enforcer for dependency checks

@reviewbybees

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@segrey would you be fine if I set Java 8 as a new requirement? It is fine for our projects, but I am not sure about yours

@oleg-nenashev Yes, it's OK for IntelliJ IDEs too.

Failed to execute goal org.codehaus.mojo:animal-sniffer-maven-plugin:1.15:check (check) on project winp: Execution check of goal org.codehaus.mojo:animal-sniffer-maven-plugin:1.15:check failed. NullPointerException

This is something I know how to fix. Will finalize it and merge

We probably need to be looking at Java 11 compatibility at this point (see this JEP PR)


Portal Collaboration

Benefit
UGRC will benefit immensely from a mechanism that allows us to collaborate on datasets with our authoritative stewards. For now, this mechanism is our Enterprise/Portal.
We made some progress in FY24 Q3, however, there are some pieces that still need to be worked out.
For this quarter, we need to get the data synching across the orgs. In other words, when one org makes an edit, the other org can see it. Currently, we are having an issue with this and Will from ESRI thinks it's a bug. WFRC has been a willing tester with us and they willing to continue working with us to get this resolved and working.
Acceptance Criteria

[x] Edited data is syncing across orgs (AGOL and Portal) and both agencies/orgs can see the edits
[x] distributed collaboration is working between WFRC and UGRC (trails data)
[x] distributed collaboration is working between MAG and UGRC (trails data)
[x] distributed collaboration is working between UDOT and UGRC (trails data)
[ ] distributed collaboration is working between Weber Dispatch and UGRC (common place data) (FY25 Q2)
[ ] test branch versioning (FY25 Q2)
[ ] continue with the governance doc

Notes
No response
Risks

[x] Issues with collaboration environment. Looking at firewall issue right now.

Issue Reference
refs #338

great progress made this quarter, many checkboxes checked! moving this along to Q2 as we have a few more items to setup/test.

Weber County does not have a working Portal yet but they are happy to host the layer on their SDE and create an app to edit the common place data layer for Dispatch and UGRC.


Include EtherSim in Readme

Didn't see a Contribute, apologies if you hate these.
I just spun up the demo, very nice, but ran into dependency error when trying embark simulator

@OR13 contributions are very much welcome. It hasn't occurred to me to put a Contribute section, I'll certainly include that for Embark 2.0 (coming soon!)


http client fails on latest editor

 Issue by ltackmann
Originally opened as dart-lang/sdk#8903

What steps will reproduce the problem?

import "package:http/http.dart" from http://pub.dartlang.org/packages/http into some code
Run the code

This fails with
Dart_VariableType: malformed type encountered: 'package:http/src/utils.dart': Error: line 173 pos 9: cannot resolve class name 'OutputStream' from '_OutputStreamConsumer@0x39959787'
  final OutputStream _outputStream;
http 0.4.0 (latest version on pub.dartlang.org) and Dart Editor version 0.4.0_r18915 with Dart SDK version <IP_ADDRESS>_r18915

 Comment by nex3

This was fixed by dart-lang/sdk@0a107333b796ebf59c93b8d4806a148989ba617a.
It's worth nothing that this should only be an issue at runtime if the code is also using mirrors, since the code that referred to OutputStream is never executed.

Added Fixed label.

 Comment by sethladd

cc @nex3.
cc @munificent.
Added Area-Pkg, Pkg-HTTP, Triaged labels.

 Comment by anders-sandholm

Removed Pkg-HTTP label.
Added Pkg-HttpServer label.


Mac: Consider placing lib, include symlinks in the root of the install folder instead of in sdk

Right now, the Mac app places symlinks for the lib and include folders in the sdk folder in the installation. This means that when using CMake, users must actually specify <install-dir>/sdk/, which is different than on Windows. I think we should consider placing these symlinks in the root of the install folder, especially since the APIExamples are now installed in the Documents folder.
Relatedly, we should no longer create symlinks for the APIExamples or Scripts folders.

Before resolving this issue, the path "/Applications/OpenSim 4.0/sdk" in the Dynamic Walker example must be updated.


Question: Pixiv?

So, after usign this amazing program for a bit, I found something annoying, I couldn't have it download from pixiv, it didn't recognise it, now ofcourse the japanese tags thing might be hard to do or whatever, but would it be possible to add a pixiv downloading feature?

It's been suggested, #917

Indeed, #917 is for adding gallery support, which is required for Pixiv.
Closing for duplication of #738.


Partition manager: File handling improvements

Split partition_manager.py into two files
Port hex file merging to be based on Partition Manager

See commit messages and other PRs for more info.
Depends on https://github.com/NordicPlayground/fw-nrfconnect-nrf/pull/768 and https://github.com/NordicPlayground/fw-nrfconnect-mcuboot/pull/36

cc @hakonfam @osaether @sigvartmh

Found the following issues, please fix and resubmit:
Codeowners issues
New files added that are not covered in CODEOWNERS:

scripts/partition_manager_files.py

Please add one or more entries in the CODEOWNERS file to cover those files

I was a bit quick posting this PR. I've redone quite a bit now, and added automatic creation of hex files for phony partition, as well as handling hex file merging directly in partition_manager.cmake

@hakonfam your comments should be addressed.

Just about ready to merge. Can you take a look @SebastianBoe?

Addressed review comments from @SebastianBoe on github.com/oyvindronningstad/fw-nrfconnect-zephyr/commit/463e6a6de9689173fbee9fe3c3789240d977a1c7


Lack of security controls on the main Kafka bus might raise some overrun attacks scenarios, or tampering opportunities for those who would like to subvert the integrity of the service.

Please look into Threat Model Summary Report, pages 13 and 14 for further information.

Will be tracked in CCX data pipeline repository.


How to run it on linux?

Prerequisites

[√ ] Did you read FAQ section?
[√] Did you test with the latest releases or commit ?

Description
I download  the latest "Source code.tar.gz" and run with command python PixivUtil2.py, then I was told "invalid syntax" like following picture

My OS is Ubuntu 18.04 and I think EXE (pixivutil20200726.zip)  can not be run on linux so I downloaded "Source code.tar.gz"
Did I download the correct file?

my Python3 version was 3.6.9 ,sorry.
I updated it and then ran successfully


Fix machine_batch

Fixes issue https://github.com/chef/chef-provisioning-aws/issues/533

looks like basically the same fix as the one in PR #532 , however you probably also want something like  https://github.com/chef/chef-provisioning-aws/pull/532/commits/3bdca320298a77862601eb044af5a4584fb15fa9 or else lists won't be correctly symbolized, causing weird failures in disk/network attachments

Closing in favor of #532


[Metal] Strange behaviour with uniforms split up over vertex and fragment shaders.

Hello,
I noticed something odd when looking at uniforms and metal.
So I have a resource layout:
ResourceLayouts = new ResourceLayout[]{_cameraResourceLayout,_materialResourceLayout,_lightResourceLayout}
Which results in the following uniform bindings in metal
Vertex
vertex PixelInput VS(VertexInput input[[stage_in]],constant ProjView &pj [[ buffer(1) ]],constant Light &l [[ buffer(3) ]])
Sure, light is last in the layout so it gets assigned to 3
Fragment
fragment float4 FS(PixelInput input[[stage_in]],constant Material &material [[buffer(1)]])
I was expecting 2 here, but ok, its the first element i the fragment stage.
However, changing the resource layout has no effect on the bindings (?)
ResourceLayouts = new ResourceLayout[] {_cameraResourceLayout,_lightResourceLayout,_materialResourceLayout}
Vertex Expected
vertex PixelInput VS(VertexInput input[[stage_in]],constant ProjView &pj [[ buffer(1) ]],constant Light &l [[ buffer(2) ]])
But it is still 3.
This is intended?

Could you post more code, like the definitions for these? _cameraResourceLayout,_materialResourceLayout,_lightResourceLayout

The whole scene is defined here
Resources
        /// Uniform 1 - Camera
        _cameraProjViewBuffer = _factory.CreateBuffer(new BufferDescription(128,BufferUsage.UniformBuffer | BufferUsage.Dynamic));

        var resourceLayoutElementDescription = new ResourceLayoutElementDescription("projView",ResourceKind.UniformBuffer,ShaderStages.Vertex);
        ResourceLayoutElementDescription[] resourceLayoutElementDescriptions = {resourceLayoutElementDescription};
        var resourceLayoutDescription = new ResourceLayoutDescription(resourceLayoutElementDescriptions);
        BindableResource[] bindableResources = new BindableResource[]{_cameraProjViewBuffer};

        _cameraResourceLayout = _factory.CreateResourceLayout(resourceLayoutDescription);
        var resourceSetDescription = new ResourceSetDescription(_cameraResourceLayout,bindableResources);

        _cameraResourceSet = _factory.CreateResourceSet(resourceSetDescription);

        // Uniform 2 - Material
        _materialBuffer = _factory.CreateBuffer(new BufferDescription(48,BufferUsage.UniformBuffer));

        var resourceLayoutElementDescriptionMaterial = new ResourceLayoutElementDescription("material",ResourceKind.UniformBuffer,ShaderStages.Fragment);
        ResourceLayoutElementDescription[] resourceLayoutElementDescriptionsMaterial = {resourceLayoutElementDescriptionMaterial};
        var resourceLayoutDescriptionMaterial = new ResourceLayoutDescription(resourceLayoutElementDescriptionsMaterial);
        BindableResource[] bindableResourcesMaterial = new BindableResource[]{_materialBuffer};

        _materialResourceLayout = _factory.CreateResourceLayout(resourceLayoutDescriptionMaterial);
        var resourceSetDescriptionMaterial = new ResourceSetDescription(_materialResourceLayout,bindableResourcesMaterial);

        _materialResourceSet = _factory.CreateResourceSet(resourceSetDescriptionMaterial);

        // Uniform 3 - Light
        _lightBuffer = _factory.CreateBuffer(new BufferDescription(16,BufferUsage.UniformBuffer));

        var resourceLayoutElementDescriptionLight = new ResourceLayoutElementDescription("light",ResourceKind.UniformBuffer,ShaderStages.Vertex);
        ResourceLayoutElementDescription[] resourceLayoutElementDescriptionsLight = {resourceLayoutElementDescriptionLight};
        var resourceLayoutDescriptionLight = new ResourceLayoutDescription(resourceLayoutElementDescriptionsLight);
        BindableResource[] bindableResourcesLight = new BindableResource[]{_lightBuffer};

        _lightResourceLayout = _factory.CreateResourceLayout(resourceLayoutDescriptionLight);
        var resourceSetDescriptionLight = new ResourceSetDescription(_lightResourceLayout,bindableResourcesLight);

       _lightResourceSet = _factory.CreateResourceSet(resourceSetDescriptionLight);

Hm, I wrote up a quick test and I'm not seeing the same thing. I'm seeing something that matches what you have listed under "Vertex Expected". Scanning through the code matches what I'm seeing as well. How are you determining that the wrong slot is getting used?

Going from:
ResourceLayouts = new ResourceLayout[]{_cameraResourceLayout,_materialResourceLayout,_lightResourceLayout}
to
ResourceLayouts = new ResourceLayout[] {_cameraResourceLayout,_lightResourceLayout,_materialResourceLayout}
should result in a changed buffer slot allocation or?

It should, yes.  Ok I knew I was missing something.
Thanks!
The headers are now
Vertex
vertex PixelInput VS(VertexInput input[[stage_in]],constant ProjView &pj [[ buffer(1) ]],constant Light &l [[ buffer(2) ]])
Fragment
fragment float4 FS(PixelInput input[[stage_in]],constant Material &material [[buffer(2)]])
On a similar note. Why is the buffer index in the fragment shader 2 and not either 1 or 3?

On a similar note. Why is the buffer index in the fragment shader 2 and not either 1 or 3?

Yeah, it's a bit quirky. The way these numbers are assigned is really simple, but it can lead to things that look confusing initially. This is what is done:

Loop through each ResourceLayout
Loop through each resource in the layout
When a buffer is encountered, increment "buffer index" and assign it to that buffer

This is done regardless of its stage flags
This buffer index is shared across stages

When binding a buffer to the vertex stage, add VertexBuffers.Count (the number of vertex input buffers used).
When binding a buffer to the fragment stage, don't add VertexBuffers.Count.

Number 5. is why the fragment buffer index seems like it is off-by-one.
In the future, I want to make this a little better, but it will be a breaking change that needs to be done carefuly. Most likely I will have a GraphicsDeviceOptions flag that influcences how a Pipeline assigns its indices. For Metal I would probably:

Puts vertex buffers at the END of the slot indices instead of the front. These aren't specified in the shader anyways, so it would be better if they were at the end, so that your "normal" buffers started at 0.
Assigns buffer/texture/sampler indices individually for each stage, starting at 0.

Makes sense. Makes things clearer.
Thanks.
I think it it would be worth copy-pasting these steps into:
https://mellinoe.github.io/veldrid-docs/articles/shaders.html
I initially looked there, but couldnt find anything.

Good idea, I will add more detailed info there that makes this clearer.


Pass criteria per request

Hi, i want to pass criteria from link with optinal $_GET string named '?displayIsDelete=1' or not exist display all projects
->createAdapter(FetchJoinORMAdapter::class, [
                'entity' => Project::class,
                'query' => function (QueryBuilder $builder) use ($request) {
                    $builder
                        ->select('project')
                        ->addSelect('references')
                        ->from(Project::class, 'project')
                        ->leftJoin( 'project.references', 'references')
                        ->orderBy('project.addedAt', 'DESC')
                    ;
                },
                'criteria' => [
                    function (QueryBuilder $builder) use ($request) {
                        $builder->andWhere($builder->expr()->eq('project.isActive', ':isActive'))->setParameter('isActive', (bool)$request->get('is_delete'));
                    },
                    new SearchCriteriaProvider()
                ]
            ])`

But the $request don't have my key, when datatable is load

This is essentially the same question as https://github.com/omines/datatables-bundle/issues/282


no response when on wrong network and then I cannot change network

Describe the bug
I am connected to e.g. Binance Smart Chain via Metamask when opening the page for the first time. When clicking Connect Wallet and choosing Metamask I get a turning wheel that just keeps going. When changing the network, the page tells me that I'm connected to Fortmatic (I never selected that) and there's no way to get out of this except for deleting local storage of the page.
To Reproduce

Connect new account in Metamask that isn't connected to the page yet
Change network to e.g. Binance Smart Chain
Click on Connect Wallet
You will see a turning wheel without any feedback why this is happening
Change network to main net
Now you will see that it chooses another choice but not Metamask and there's no way to get out here

Expected behavior
When being connected to a non-main net network, show "Wrong network, please connect to main net" in "Connect Wallet" button. When switching to main net, ensure that the choice of provider (e.g. Metamask) that I have made previously, persists.
Desktop (please complete the following information):

OS: Ubuntu and macOS
Browser: Brave
Version: 1.19.88

@SCBuergel I haven't been able to reproduce this issue.

macOS 11.1
Brave Version 1.18.75 Chromium: 87.0.4280.101 (Official Build) (x86_64 translated)
MetaMask 9.0.3

Are you using any older versions?

@SCBuergel I haven't been able to reproduce this issue.

macOS 11.1
Brave Version 1.18.75 Chromium: 87.0.4280.101 (Official Build) (x86_64 translated)
MetaMask 9.0.3

Are you using any older versions?


Fixes simple form with validation groups and buttons inside

Because of this line simple form with button and model with asserts with validation groups will not work.
$enabled_validation_groups will be empty array because form has button.
I fixed it but maybe it breaks BC with other bundles. Please check it

Hi @ikselll,
Thanks you for the PR but it seems that no test was provided/changed. Would it be possible to for you to add a test or to? I can update the tests but I would like to have a case provided that shows me why this is needed.
Thank you in advance!
Cheers,
Warnar


Fix wrong kill signal parsing

fixes #13665
https://github.com/docker/docker/blob/v1.7.0-rc1/api/server/server.go#L274 signal isn't in vars
old code https://github.com/docker/docker/blob/v1.6.2/api/server/server.go#L215
this resulted in alwasy passing 0 as signal and being interpreted by the daemon as SIGKILL
/cc @aanand
DEBU[0016] Calling POST /containers/create
INFO[0016] POST /v1.20/containers/create
DEBU[0016] Calling POST /containers/{name:.*}/start
INFO[0016] POST /v1.20/containers/9ace169f8625121a9d662b865f00d27a1b4f658d403d8a7ba74b425282f65506/start
DEBU[0016] Calling POST /containers/{name:.*}/kill
INFO[0016] POST /v1.20/containers/9ace169f8625121a9d662b865f00d27a1b4f658d403d8a7ba74b425282f65506/kill?signal=SIGWINCH
DEBU[0016] Sending 28 to 9ace169f8625121a9d662b865f00d27a1b4f658d403d8a7ba74b425282f65506
DEBU[0016] Calling GET /containers/{name:.*}/json
INFO[0016] GET /v1.20/containers/9ace169f8625121a9d662b865f00d27a1b4f658d403d8a7ba74b425282f65506/json

Signed-off-by: Antonio Murdaca<EMAIL_ADDRESS>

the fact that all of our tests pass w/o this fix means we need at least one new test  :-)

@duglin sure :P

nice catch..should this make 1.7? ping @jfrazelle
agree with @duglin on a test :)

@estesp pretty sure this will go in 1.7, I added the milestone but remove it if I'm wrong

Assigned Jess for cherry-pick once it's ready

@duglin @estesp PTAL

LGTM

LGTM

LGTM

cherry-picked!

:heart:


Freedoom support

How well is Freedoom supported? Note that I haven't tested, I'm just wondering.

Haven't tried, my focus has been on getting the originals running as well as possible. That said I'd be curious how it would work out. Feel free to give it a try and tell me what works and what doesn't and I'll be happy to fix stuff!

Just tried it, seems to work just fine!


Add files via upload

Included first 2 examples from https://dash.plotly.com/sharing-data-between-callbacks
Related issue: https://github.com/plotly/dash_matlab/issues/18

In 1st example,
my system wants python calls with pyargs arguments like this py.dash_core_components.Graph(pyargs('id','graph'))
could you please add to callback.callback1 this check:
if value is None: value=0
and maybe create some random table in matlab instead of using  global_df = readtable('...'); or reading .csv
Their 2nd example throws that error referring to another example with dash.callback_context:
https://dash.plotly.com/advanced-callbacks
i guess maybe fixing it isn't part of this example :)