[New Feature]: Manifest Verification Tiers

Description of the new feature/enhancement
I had an idea for an additional security layer that would be like a mid-way verification strategy compared to something like #100 . But it would also sort of build on that as I'll describe below. And to be clear, this would be in addition to the existing checks and procedures.
Idea (First Half):
For the first part of the feature, I'm basically imagining there be a database containing known-good properties about the publisher and/or their software products, which could be used to 'verify' a specific manifest to varying degrees. Then there could be a kind of flag or attribute that would indicate the manifest as "verified".
Idea (Second Half):
Then for the other part of the feature, there would be the added ability for a user to limit their WinGet CLI to only considering packages with a specific verification level. And I imagine this 'verification' tag would be an additional column in the WinGet CLI, but the user could also choose to filter and only show verified packages if desired.
More specifically, I'm imagining there be a database/ list of known public keys for publishers that sign their installers, as well as a list of associated known domains (or even specific URL paths) at which those companies host their installers.
Use Case:
I think the use case would be in situations where the publisher doesn't maintain their own WinGet packages. This way, users could know exactly to what level the packages they are installing were verified. Yes each package is checked by moderators, but at the same time I think users would appreciate knowing if a package has had a specific type of verification check, and exactly in what way.
Proposed technical implementation details (optional)
Implementation Ideas
As an example, the structure of a single publisher entry in the database might look something like this:
• Publisher: master/manifests/m/Mozilla
    ↳ Publisher Managed Package:
        ↳ False
    ↳ Known Signing Keys:
        ↳ [30 82 02 0a 02 82 02 01 00 c9 52 d8 96 ... ]
    ↳ Packages:
        ↳ Firefox
            ↳ Known Installer Host URLs:
                ↳ https://download-installer.cdn.mozilla.net/pub/firefox/releases/*
        ↳ Thunderbird
            ↳ Known Installer Host URLs:
                ↳ https://download-installer.cdn.mozilla.net/pub/thunderbird/releases/*

As part of the automatic scan for submitted PRs, the bot could run a check for:

A signature on the installer file itself (which I imagine already happens at some point of the dynamic analysis anyway), and if so, compare it to the known one.
If there is no signature or it's self-signed, compare it to the known URLs it should be hosted on for that package.

Then from there, I figure there are two options for how to approach classifying that individual manifest:

A single verified tag if either passes
Have separate tags for each test.

In the case where each test yields its own tag, then there would be the matter of deciding what passed tests would be required to consider it 'verified' by default:

Verified Signature
Verified URL
Both

The verification tiers might look something like this, from highest to lowest strictness:

Package managed by original publisher
Both Verified Signature and URL Required
Verified Signature Required
Either Verified URL or Verified Signature Required
Standard checks only (like currently), no additional verification required

Then if the user wanted to set their own level they considered 'verified', they could change it from whatever the default is. There could even be an option to let the user choose any combination of tags.

And of course, there could be a policy for what to do with unverified manifests. Perhaps for very popular software by big companies that one would expect to always sign their software, you could have a special requirement for a certain verification level for the manifest to be allowed into the repo at all, even if it would otherwise pass normal checks.  But for the rest of the repo in general, it would just be like it currently is with the existing checks on the submitted manifests, and on top of that software verification information would be added over time.

This sounds like a user-run version of the system described in #100.
First part - we could store the author data in a .author file (or .ISV or similar).

Independent Software Vendor (ISV) is a catch-all term to generally describe a developer or publisher.

Second part - possibly storing these keys in the .author or other file.

A SHA256 hash check is the current verification mechanism.
Additionally, packages are often signed by their publishers.
Could specify user permissions based on GitHub ID - OR based on signing the PR with the key in some way, possibly as a public comment.

Use case

One current mechanism for gating package submitters is through my Package Watcher's Auth.csv list. This is a tool that many moderators use to check packages when approving.
When the specified PackageIdentifier is processed for moderator approval, the Package Watcher displays a message indicating the Account as the approved uploader(s), and with the specified Strictness - must be the Account, or merely should be the account.
The current system allows some developers to control their package uploads, while encouraging community members to submit manifests for packages they use regularly. - Most of our manifests come from community members instead of directly from developers / ISVs. (I believe - I haven't checked the data.)
Feel free to request updates and additions.

Implementation

Parts of this (signature scanning) would have to be added into our back-end implementation.
Parts of this should be implemented in GitHub actions, and possibly part through our bot automation.
All URLs are currently verified, in that each one has been downloaded, installed, and viewed by a moderator, and the hash verified against the manifest.

Subsequent versions should be checked that they're coming from a similar URL. (I'm not sure that this check is being performed.)
URLs from popular download sites require are automatically flagged for manual review, to ensure packages aren't being rehosted.
Manifests which can't pass this test aren't accepted into our public manifests.
What additional verification steps should be performed?

Verification tiers might need to be shifted, merged, or split.

Verification tiers somewhat resemble security tiers, or maybe "risk" tiers. This implies giving e.g. corporate Security directors an easy mechanism to control software levels - maybe core servers are restricted to tier 1, most user PCs are tier 2 or 3, and developers might be tier 5. Or parents, restricting their PC to tier 1, to prevent their kids from installing anything too questionable.


the last printing of difference of chemical potential is wrong:

Describe the bug
the last printing of difference of chemical potential is wrong:
Si_GW.o88295:       New chemical potential, μ =  2.722719311714172e-01
Si_GW.o88295:Chemical potential difference Δμ =  2.722719311714172e-01
Si_GW.o88312:       New chemical potential, μ =  2.722719311714172e-01
Si_GW.o88312:Chemical potential difference Δμ =  2.722719311714172e-01
Si_GW.o88312:       New chemical potential, μ =  2.722644209861755e-01
Si_GW.o88312:Chemical potential difference Δμ =  7.510185241699219e-06
Si_GW.o88312:       New chemical potential, μ =  2.722569108009338e-01
Si_GW.o88312:Chemical potential difference Δμ =  7.510185241699219e-06
Si_GW.o88312:       New chemical potential, μ =  2.722494006156921e-01
Si_GW.o88312:Chemical potential difference Δμ =  7.510185241699219e-06
Si_GW.o88312:       New chemical potential, μ =  2.722419202327728e-01
Si_GW.o88312:Chemical potential difference Δμ =  7.480382919311523e-06
Si_GW.o88312:    Event 'Chemical potential search' took         2.025448      0.194926      1.796626 s.
Si_GW.o88312:       New chemical potential, μ =  2.722344398498535e-01
Si_GW.o88312:Chemical potential difference Δμ =  2.722344398498535e-01

can not reproduce

Is it about the band structure?
On Thu, May 9, 2024, 23:54 Sergei Iskakov @.***> wrote:

Closed #9 https://github.com/Green-Phys/green-mbpt/issues/9 as
completed.
—
Reply to this email directly, view it on GitHub
https://github.com/Green-Phys/green-mbpt/issues/9#event-12762074541, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AFIBJPPBXHIJQQEJMPWXWMLZBPPBLAVCNFSM6AAAAABF67PWTGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSG43DEMBXGQ2TIMI
.
You are receiving this because you authored the thread.Message ID:
@.***>


Error message upon starting PH

Description
Upon launching PH I get an error message box with following content:
---------------------------
Process Hacker [Z170A-M5\Emmi]+ (Administrator): ProcessHacker.exe - Bad Image
---------------------------
C:\Program Files (x86)\Overwolf\<IP_ADDRESS>\OWExplorer.dll

 is either not designed to run on Windows or it contains an error. Try installing the program again using the original installation media or contact your system administrator or the software vendor for support. Error status 0xc0000428.
---------------------------
OK
---------------------------

To Reproduce
Steps to reproduce the behavior:

Have Overwolf installed
Have Overwolf runnning, including the process OverwolfHelper64.exe with the arguments path=C:\Program Files (x86)\Overwolf\<IP_ADDRESS>\OWExplorerLauncher.dll pid=7684 (where 7684 is the parent Overwolf.exe process)
Open PH

Screenshots

Additional info
As soon as the error message pops up, the main window of Process Hacker stops responding. The error message window is not affected.
App versions

OS: Windows 10 20H2 (19042.746)
PH: 3.0.3813 (5ec361af)
Overwolf version: <IP_ADDRESS>

Disable "Enable mitigation policy" in options.
It causes confiricts with many shell extensions. (such as tortoisegit...)

Seems to work. I get a normal start of PH now.
On 11 Feb 2021, 03:25, at 03:25, a1lic<EMAIL_ADDRESS>wrote:

Disable "Enable mitigation policy" in options.
It causes confiricts with many shell extensions. (such as
tortoisegit...)
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/processhacker/processhacker/issues/795#issuecomment-777166674

I've enabled extra error dialogs to help KaKi87 diagnose a crash reported here: https://github.com/processhacker/processhacker/issues/792
Overwolf is injecting a DLL into PH which fails the Microsoft signed mitigation causing that error dialog... It normally silent fails but since all errors are enabled you'll see that dialog until I disable them again in the next week, maybe two.

Error dialogs caused by third party software are disabled again 👍


Come up with witty name

I vote for keeping Blog Poole :wine_glass: as our name.

bp.wtf ftw.

Registration attempt for bp.wtf denied :cry:
Issue reopened and now taking suggestions!

https://jekyll.pizza is just as good!


[Nvidia] Screen flickering on External Monitor

Hyprland Version
512a59731b2e579b66325d0e9ce770919eecd685
Bug or Regression?
Regression
Description
Nvidia GPU. Screen flickering and tearing on HDMI monitor. Last worked on commit 802ab58f8a129b42d61ec13898fd978e0920f7d8 (however, there is a big black cursor which is fixed in latest) . Bug is present with both 535 and 545 driver.
How to reproduce

Launch Hyprland
Open any application on HDMI connected monitor

Crash reports, logs, images, videos

Flickering with latest -

https://github.com/hyprwm/Hyprland/assets/72289243/ff076234-9a61-48c1-b3ad-df37bcba8b53

No flicker -

https://github.com/hyprwm/Hyprland/assets/72289243/39fa6752-b640-4bea-8700-955c2e23d770

hyprland config -
exec-once=/nix/store/m9bp68sxl8pi3gxhplfg8cgmld9c2lc0-dbus-1.14.10/bin/dbus-update-activation-environment --systemd DISPLAY WAYLAND_DISPLAY HYPRLAND_INSTANCE_SIGNATURE XDG_CU
RRENT_DESKTOP && systemctl --user start hyprland-session.target
plugin = /nix/store/byjhs3lkizhx25ylvyy4zbd7pnyr16lk-hy3-0.1/lib/libhy3.so
source = /nix/store/7ams43hxv5lxdwvccgxxdiv4rzm19lqq-impurity--home-hyprland-hyprland.conf

nix store config file -

#
# Please note not all available settings / options are set here.
# For a full list, see the wiki
#

# autogenerated = 1 # remove this line to remove the warning
# Variables
env = WLR_NO_HARDWARE_CURSORS,1
env = HYPRLAND_LOG_WLR,1
env = XCURSOR_SIZE,24
# env = XCURSOR_THEME,Catpuccin-Mocha-Maroon-Cursors
env = QT_QPA_PLATFORMTHEME,qt5ct
env = QT_WAYLAND_DISABLE_WINDOWDECORATION,1
env = _JAVA_AWT_WM_NONREPARENTING,1

# Nvidia Stuff
env = GBM_BACKEND,nvidia
env = MOZ_ENABLE_WAYLAND,1
env = LIBVA_DRIVER_NAME,nvidia
env = XDG_SESSION_TYPE,wayland
env = __GLX_VENDOR_LIBRARY_NAME,nvidia
# For crashes -
# cat /tmp/hypr/$(ls -t /tmp/hypr/ | head -n 1)/hyprland.log

$browser = librewolf
$terminal = kitty

# See https://wiki.hyprland.org/Configuring/Monitors/
monitor=eDP-1,highres,auto,1
monitor=HDMI-A-1,highres,auto,1
monitor=HDMI-A-1,transform,0
# See https://wiki.hyprland.org/Configuring/Keywords/ for more

# Execute your favorite apps at launch
exec-once = dex -a
exec-once = swww-daemon
exec-once = ~/.local/bin/wallpaper-changer ~/Pictures/Wallpapers/
exec-once = wl-paste --watch cliphist store
exec-once = playerctld daemon
exec-once = waybar
exec-once = wakapi -config ~/.config/wakapi/config.yml
exec-once = qbittorrent &
# Source a file (multi-file configs)
# source = ~/.config/hypr/myColors.conf

# For all categories, see https://wiki.hyprland.org/Configuring/Variables/
input {
    kb_layout = us
    kb_variant =
    kb_model =
    kb_options =
    kb_rules =

    follow_mouse = 1

    touchpad {
        natural_scroll = true
        disable_while_typing = true
    }

    sensitivity = 0 # -1.0 - 1.0, 0 means no modification.
}

general {
    # See https://wiki.hyprland.org/Configuring/Variables/ for more

    gaps_in = 1
    gaps_out = 5
    border_size = 3
    col.active_border = rgba(7dcfffff) rgba(bb9af7ff) 45deg
    col.inactive_border = rgba(595959aa)
    apply_sens_to_raw=0
    layout = hy3
}
plugin {
  hy3 {
  no_gaps_when_only = true
    autotile {
      enable = true
    }
  }
}
decoration {
    # See https://wiki.hyprland.org/Configuring/Variables/ for more

    rounding = 10
    drop_shadow = yes
    shadow_range = 4
    shadow_render_power = 3

    blur {
      enabled = yes
      size = 3
      passes = 2
      new_optimizations = true
    }
    col.shadow = rgba(1a1a1aee)

}

animations {
    enabled = yes

    # Some default animations, see https://wiki.hyprland.org/Configuring/Animations/ for more

    bezier = myBezier, 0.05, 0.9, 0.1, 1.05

    animation = windows, 1, 7, myBezier
    animation = windowsOut, 1, 7, default, popin 80%
    animation = border, 1, 10, default
    animation = fade, 1, 7, default
    animation = workspaces, 1, 6, default
}

dwindle {
    # See https://wiki.hyprland.org/Configuring/Dwindle-Layout/ for more
    pseudotile = true # master switch for pseudotiling. Enabling is bound to mainMod + P in the keybinds section below
    preserve_split = true # you probably want this
    no_gaps_when_only = true
}

master {
    # See https://wiki.hyprland.org/Configuring/Master-Layout/ for more
    new_is_master = true
    no_gaps_when_only = true
}

gestures {
    # See https://wiki.hyprland.org/Configuring/Variables/ for more
    workspace_swipe = true
}

# Example per-device config
# See https://wiki.hyprland.org/Configuring/Keywords/#executing for more
device:epic mouse V1 {
    sensitivity = -0.5
}

# Example windowrule v1
# windowrulev2 = float,class:^(kitty)$,title:^(kitty)$
# See https://wiki.hyprland.org/Configuring/Window-Rules/ for more

# See https://wiki.hyprland.org/Configuring/Keywords/ for more
$mainMod = SUPER

# Example binds, see https://wiki.hyprland.org/Configuring/Binds/ for more
bind = $mainMod, RETURN, exec, $terminal
bind = $mainMod, Q, killactive,
bind = $mainMod, M, exit,
bind = $mainMod, E, exec, dolphin
bind = $mainMod, SPACE, togglefloating,
bind = $mainMod, D, exec, anyrun
#bind = $mainMod SHIFT, E, exec, rofi -show emoji
#bind = $mainMod, C, exec, rofi -show calc
bind = $mainMod SHIFT, P, pseudo,
bind = $mainMod, H, hy3:movewindow, left
bind = $mainMod, J, hy3:movewindow, down
bind = $mainMod, K, hy3:movewindow, up
bind = $mainMod, L, hy3:movewindow, right
bind = $mainMod, F, exec, ~/.config/hypr/hy3-fullscreen.sh
# bind = $mainMod, F, fullscreen
bind = $mainMod, G, exec, ~/.config/hypr/gamemode.sh

# Move focus with mainMod + arrow keys
bind = $mainMod, left, movefocus, l
bind = $mainMod, right, movefocus, r
bind = $mainMod, up, movefocus, u
bind = $mainMod, down, movefocus, d

# Switch workspaces with mainMod + [0-9]
bind = $mainMod, 1, workspace, 1
bind = $mainMod, 2, workspace, 2
bind = $mainMod, 3, workspace, 3
bind = $mainMod, 4, workspace, 4
bind = $mainMod, 5, workspace, 5
bind = $mainMod, 6, workspace, 6
bind = $mainMod, 7, workspace, 7
bind = $mainMod, 8, workspace, 8
bind = $mainMod, 9, workspace, 9
bind = $mainMod, 0, workspace, 10
bind = $mainMod, F1, workspace, 11
bind = $mainMod, F2, workspace, 12
bind = $mainMod, F3, workspace, 13
bind = $mainMod, F4, workspace, 14
bind = $mainMod, F5, workspace, 15
bind = $mainMod, F6, workspace, 16
bind = $mainMod, F7, workspace, 17
bind = $mainMod, F8, workspace, 18
bind = $mainMod, F9, workspace, 19
bind = $mainMod, F10, workspace, 20

# Move active window to a workspace with mainMod + SHIFT + [0-9]
bind = $mainMod SHIFT, 1, movetoworkspace, 1
bind = $mainMod SHIFT, 2, movetoworkspace, 2
bind = $mainMod SHIFT, 3, movetoworkspace, 3
bind = $mainMod SHIFT, 4, movetoworkspace, 4
bind = $mainMod SHIFT, 5, movetoworkspace, 5
bind = $mainMod SHIFT, 6, movetoworkspace, 6
bind = $mainMod SHIFT, 7, movetoworkspace, 7
bind = $mainMod SHIFT, 8, movetoworkspace, 8
bind = $mainMod SHIFT, 9, movetoworkspace, 9
bind = $mainMod SHIFT, 0, movetoworkspace, 10

# bind = $mainMod+CONTROL, 1, hy3:focustab, index, 01
# bind = $mainMod+CONTROL, 2, hy3:focustab, index, 02
# bind = $mainMod+CONTROL, 3, hy3:focustab, index, 03
# bind = $mainMod+CONTROL, 4, hy3:focustab, index, 04
# bind = $mainMod+CONTROL, 5, hy3:focustab, index, 05
# bind = $mainMod+CONTROL, 6, hy3:focustab, index, 06
# bind = $mainMod+CONTROL, 7, hy3:focustab, index, 07
# bind = $mainMod+CONTROL, 8, hy3:focustab, index, 08
# bind = $mainMod+CONTROL, 9, hy3:focustab, index, 09
# bind = $mainMod+CONTROL, 0, hy3:focustab, index, 10

# Scroll through existing workspaces with mainMod + scroll
bind = $mainMod, mouse_down, workspace, e+1
bind = $mainMod, mouse_up, workspace, e-1

# Resizing window
bind=ALT,R,submap,resize

# will start a submap called "resize"
submap=resize

# sets repeatable binds for resizing the active window
binde=,right,resizeactive,10 0
binde=,left,resizeactive,-10 0
binde=,up,resizeactive,0 -10
binde=,down,resizeactive,0 10

# use reset to go back to the global submap
bind=,escape,submap,reset

# will reset the submap, meaning end the current one and return to the global one
submap=reset

# Move/resize windows with mainMod + LMB/RMB and dragging
bindm = $mainMod, mouse:272, movewindow
bindm = $mainMod, mouse:273, resizewindow

bind = $mainMod, x, exec, kill -USR1 $(pgrep "waybar")
bind = $mainMod SHIFT, S, exec, grimblast --notify copysave area

# Media Buttons
binde =, XF86AudioRaiseVolume, exec, ~/.local/bin/progress_notify.sh audio up
binde =, XF86AudioLowerVolume, exec, ~/.local/bin/progress_notify.sh audio down
bind =, XF86AudioMute, exec, ~/.local/bin/progress_notify.sh audio toggle
bind =, XF86AudioNext, exec, playerctl next
bind =, XF86AudioPrev, exec, playerctl previous
bind =, XF86AudioPlay, exec, playerctl play-pause
bind =, XF86AudioStop, exec, playerctl stop

# Screen Brightness
binde =, XF86MonBrightnessUp, exec, brightnessctl s 5%+ && ~/.local/bin/progress_notify.sh brightness
binde =, XF86MonBrightnessDown, exec, brightnessctl s 5%- && ~/.local/bin/progress_notify.sh brightness
# Swaps the active workspaces between two monitors
bind = $mainMod, Z, swapactiveworkspaces, HDMI-A-1 eDP-1

# Clipboard

bind = $mainMod, p, exec, cliphist list | anyrun --plugins libstdin.so --show-results-immediately true --max-entries 100  | cliphist decode | wl-copy

windowrule = animation easeInBounce,kitty # sets the animation style for kitty
windowrule = opacity 0.85 0.85, VencordDesktop # sets the opacity for VencordDesktop
windowrule = opacity 0.85 0.85,WebCord # sets the opacity for VencordDesktop

windowrule = opacity 0.90 0.80, Code # sets the opacity for Code

can we move to #3952 for a unified discussion place? let me know if disabling blur fixes it


Improve the way update's summaries are generated

We have several issues in the way updates summaries are generated (here):

If the update doesn't start with <p>, we return an empty string. This is going to be a problem when we'll introduce the new rich text editor because it uses a <div> to wrap the content.
We only take the first paragraph, which can be a very short string
Content is sanitized in the resolver, thus the function has a cost at each request

Proposed change

Add a summary column to the DB
In the migration, generate all summaries for existing updates
In the model, when saving html content, generate the summary
Use sanitize-html to remove everything we don't want (<br/>, <p/>...)

How should summaries be generated for the updates? Should it be similar to what was done in https://github.com/opencollective/opencollective-api/blob/88ff9e6ac3badcf3e9a07dbef4fe2531febcdbc0/server/graphql/v1/types.js#L848-L851

We're moving out of markdown for these descriptions.
I'd say we should mimic what was done for conversation, using the generateSummaryForHTML helper: https://github.com/opencollective/opencollective-api/blob/1d509a0a3e63ce239f1887166ebf049b110bea4d/server/models/Conversation.js#L45


Unable to log in using GitHub

What happened?
There is an issue where we are unable to log in via GitHub within the showcase app. This is leading to most of the GitHub plugins being unavailable.
What are the steps to reproduce this issue?

Navigate to the showcase app
Go to the catalog
Select backstage-showcase
Attempt to log in
See “User not found”

Browser affected
Put an x in the boxes that apply

[ ] All
[x] Chrome
[ ] Safari
[ ] Edge
[ ] Firefox

We only support the last 2 major versions.
Devices affected
Put an x in the boxes that apply

[ ] All
[x] Desktop
[ ] Tablet
[ ] Phone

Attach any related screenshots, if any.

Fixed by #129. Leaving open to see if we can still implement the original idea

Fixed by https://github.com/janus-idp/backstage-showcase/pull/129. Leaving open to see if we can still implement the original idea


Better error message for using super when not using an object method

Object.create({}, {
  foo: {
    get: function(){
      return super.foo;
    }
  }
})

errors with
repl: 'super' outside of function or class (4:13)
  2 |   foo: {
  3 |     get: function(){
> 4 |       return super.foo;
    |              ^
  5 |     }
  6 |   }
  7 | })

since it needs to be a get() {}
We should make a better error message for this?
cc @jasonkarns @kovensky

Would be better to say "method or class constructor", as only those have a [[HomeObject]] (and thus access to super).
Right now it is inside a function, it's just a "free-standing" closure that happens to be assigned to an object.
Worse, if it did try to just use the object where the closure is defined, its [[HomeObject]] would be the property descriptor itself 😄

Yeah "method or class constructor" sounds good to me?
https://github.com/babel/babylon/blob/01e984fd0f21bb284943a508d2acc7c458aab13e/src/parser/expression.js#L379-L392
Also interesting is allowSuperOutsideMethod - we should update the readme since it says TODO https://github.com/babel/babylon/blob/master/README.md#options - not sure why you would want that

allowSuperOutsideMethod would probably only make sense if super was dynamic and would work like Object.getPrototypeOf(Object.getPrototypeOf(this)).

No suggestions on the error message, but I'll say that from my perspective, I'm not sure that method or class constructor would have been any more illuminating than the current message. It's absolutely precise, but also not all that helpful to the majority of users. (if they're like me)
It would probably take more work (since the error message would need to be contextual) but if going for the most helpful message, one could print exactly what needs changed to make it valid. (At least for function expressions used within property descriptors.)

I can work on this issue. Seems to be good for first contribution.

@rajzshkr Go ahead!


Rename to --autify-connect

Since we're going to rename some terminologies,
--autify-connect is more suitable than --autify-connect-key.
We're going to just rename it and break backward compatibility
but it's fine since we've just released the previous version
and Autify Connect is an optional feature as of today.

Going to cherry-pick this commit to releases/0.6 for releasing patch update.

Released all new patch versions:
https://github.com/autifyhq/autify-cli/releases/tag/v0.6.1
https://github.com/autifyhq/actions-web-test-run/releases/tag/v1.3.2
https://github.com/autifyhq/autify-circleci-orb-web/releases/tag/v2.2.1


[BuildSystem] Add support for task-level build system tests.

This exposes a new internal API from the BuildSystem which lets clients
request the results for arbitrary BuildKeys, which in turn lets us unit test
specific tasks much more effectively, when combined with the previous work to
allow us to manually build up an in memory build description.

@swift-ci please smoke test


Removed JOB_OPTION_RESOURCES from torque

Will fix #628 when this PR and PR #631 is merged.

Codecov Report

Merging #632 into master will increase coverage by 0.17%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #632      +/-   ##
============================================
+ Coverage     84.27%   84.44%   +0.17%
- Complexity     1661     1664       +3
============================================
  Files           108      108
  Lines          4980     4977       -3
  Branches        747      746       -1
============================================
+ Hits           4197     4203       +6
+ Misses          550      544       -6
+ Partials        233      230       -3

Flag
Coverage Δ
Complexity Δ

#fixedclientenvironment
26.12% <0%> (+0.01%)
470 <0> (+1)
:arrow_up:

#integration
55.83% <100%> (+0.13%)
943 <0> (+3)
:arrow_up:

#livelocal
22.38% <0%> (+0.01%)
391 <0> (+1)
:arrow_up:

#unit
57.48% <100%> (+0.03%)
1262 <0> (ø)
:arrow_down:

Impacted Files
Coverage Δ
Complexity Δ

.../xenon/adaptors/schedulers/torque/TorqueUtils.java
84.88% <100%> (+2.86%)
21 <0> (ø)
:arrow_down:

...on/adaptors/schedulers/torque/TorqueScheduler.java
81.21% <0%> (+1.81%)
49% <0%> (+1%)
:arrow_up:

...ors/schedulers/gridengine/GridEngineScheduler.java
84.73% <0%> (+2.29%)
42% <0%> (+2%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a48ae7...c7d163f. Read the comment docs.


Holoclip broken after latest optimization

As of d8cdc76, holograms cannot be clipped via holoclip E2 functions. I narrowed down the problem to the following line:
https://github.com/wiremod/wire/blob/d8cdc76bcbc26706ab0edc4fd55ab7f4d3385b29/lua/entities/gmod_wire_expression2/core/hologram.lua#L186
Reverting this to what it used to be before d8cdc76 fixes the issue entirely.

Will take a look at this in a few hours

@TwistedTail I'm about to start fixing this issue now. If you would like to join my local server to test the fix, let me know on discord https://discord.gg/H8UKY3Y

Fixed


Seek not working on mobile website

Hi, I am using videogular for a mobile website. But if i try to seek to a later part in the video, without going to full screen it doesn't work. I have tried it on nexus 5 ( android 5.1.1 ) with default settings. However if i go to full screen then it works fine.

+1

Fixed thanks to @zanemcca


plugin-cloud-storage: Unable to load thumbnails || blocked by csp issue

When I try to use the use the plugin to fetch the image from an s3 bucket, I get blocked by csp error.
Node version:  14.17.2
payload version:  1.14.0
Here is my payload.config.ts:
const adapterToUse = s3Adapter({
  config: {
    region: process.env.S3_REGION,
    endpoint: process.env.S3_ENDPOINT,
    forcePathStyle: true,
    credentials: {
      accessKeyId: process.env.S3_ACCESS_KEY_ID,
      secretAccessKey: process.env.S3_SECRET_ACCESS_KEY,
    },
  },
  bucket: process.env.S3_BUCKET,
});

export default buildConfig({
.....

plugins: [
    cloudStorage({
      collections: {
        Media: {
          adapter: adapterToUse,
          disableLocalStorage: true,
        },
      },
    })],
....

My media collection :

const Media = {
  access: {
    create: () => true,
    read: () => true,
    update: () => true,
    delete: () => true,
  },
  slug: "media",
  fields: [
    {
      name: "url",
      type: "text",
      admin: {
        disabled: true,
      },
      hooks: {
        beforeChange: [() => undefined],
        afterRead: [
          ({ data: doc }) =>
            `https://example.com/media-images/${doc.filename}`,
        ],
      },
    },
  ],
  upload: {
    imageSizes: [
      {
        name: "thumbnail",
        width: 400,
        height: 300,
        position: "centre",
      },
    ],
    mimeTypes: ["image/*", "video/*"],
    adminThumbnail: ({ doc }) =>
      `https://example.com/media-images/${doc.filename}`,
  },
};

export default Media;

I get blocked by csp error.

Unfortunately, this is not enough information to go off of. Can you provide the exact error, console error, and/or stack trace?
This is likely just a configuration error. It can be re-opened if the above is provided.


Failed to build pre-rendered app with adapter-static.

Describe the bug
I've upgraded to the latest version of the sveltekit in my app and resolved all of the migrations etc.., but now I cannot build (and pre-render) it with adapter-static.
I thought that was my fault somewhere, but as you see, I created a repo with the original sveltekit demo app, and something wrong there either.
Reproduction
https://github.com/gyurielf/svelte-tel-input/tree/improvements-5
https://github.com/gyurielf/svelte-kit-prerender-test
Logs
My app
><EMAIL_ADDRESS>build
> vite build

vite v3.0.9 building for production...
transforming (127) node_modules/libphonenumber-js/es6/PhoneNumber.jsUse of eval is strongly discouraged, as it poses security risks and may cause issues with minification
✓ 154 modules transformed.
.svelte-kit/output/client/_app/immutable/assets/flags_responsive-c74f6f56.png          54.14 KiB
.svelte-kit/output/client/vite-manifest.json                                           2.66 KiB
.svelte-kit/output/client/_app/immutable/components/error.svelte-83315a3c.js           2.07 KiB / gzip: 0.95 KiB
.svelte-kit/output/client/_app/immutable/chunks/singletons-143dc615.js                 1.14 KiB / gzip: 0.68 KiB
.svelte-kit/output/client/_app/immutable/chunks/0-5f5f7276.js                          0.12 KiB / gzip: 0.12 KiB
.svelte-kit/output/client/_app/immutable/start-072d8835.js                             21.37 KiB / gzip: 8.11 KiB
.svelte-kit/output/client/_app/immutable/chunks/1-f8a8f728.js                          0.15 KiB / gzip: 0.13 KiB
.svelte-kit/output/client/_app/immutable/chunks/2-7faee835.js                          0.12 KiB / gzip: 0.12 KiB
.svelte-kit/output/client/_app/immutable/chunks/index-e253c662.js                      9.42 KiB / gzip: 3.87 KiB
.svelte-kit/output/client/_app/immutable/components/pages/_layout.svelte-fdd1bf86.js   38.96 KiB / gzip: 11.64 KiB
.svelte-kit/output/client/_app/immutable/assets/+layout-729d9ebf.css                   28.63 KiB / gzip: 6.06 KiB
.svelte-kit/output/client/_app/immutable/components/pages/_page.svelte-b0bf113d.js     141.19 KiB / gzip: 38.37 KiB
vite v3.0.9 building SSR bundle for production...
transforming (56) src/lib/types/enums/index.tsUse of eval is strongly discouraged, as it poses security risks and may cause issues with minification
✓ 60 modules transformed.
.svelte-kit/output/server/vite-manifest.json                  1.29 KiB
.svelte-kit/output/server/index.js                            60.60 KiB
.svelte-kit/output/server/entries/pages/_layout.svelte.js     34.99 KiB
.svelte-kit/output/server/entries/fallbacks/error.svelte.js   1.50 KiB
.svelte-kit/output/server/entries/pages/_page.svelte.js       23.40 KiB
.svelte-kit/output/server/chunks/index.js                     7.43 KiB
.svelte-kit/output/server/chunks/index2.js                    1.29 KiB
.svelte-kit/output/server/chunks/hooks.js                     0.10 KiB
ReferenceError: require is not defined in ES module scope, you can use import instead
This file is being treated as an ES module because it has a '.js' file extension and '/home/xyz/work/own/svelte-tel-input/package.json' contains "type": "module". To treat it as a CommonJS script, rename it to use the '.cjs' file extension.
    at eval (eval at 607 (file:///home/xyz/work/own/svelte-tel-input/.svelte-kit/output/server/entries/pages/_layout.svelte.js:76:85), <anonymous>:1:1)
    at Object.607 (file:///home/xyz/work/own/svelte-tel-input/.svelte-kit/output/server/entries/pages/_layout.svelte.js:76:85)
    at __webpack_require__ (file:///home/xyz/work/own/svelte-tel-input/.svelte-kit/output/server/entries/pages/_layout.svelte.js:458:37)
    at file:///home/xyz/work/own/svelte-tel-input/.svelte-kit/output/server/entries/pages/_layout.svelte.js:460:12
    at file:///home/xyz/work/own/svelte-tel-input/.svelte-kit/output/server/entries/pages/_layout.svelte.js:461:5
    at file:///home/xyz/work/own/svelte-tel-input/.svelte-kit/output/server/entries/pages/_layout.svelte.js:462:3
    at ModuleJob.run (node:internal/modules/esm/module_job:198:25)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:385:24)
    at async Module.component (file:///home/xyz/work/own/svelte-tel-input/.svelte-kit/output/server/nodes/0.js:4:39)
ReferenceError: require is not defined in ES module scope, you can use import instead
This file is being treated as an ES module because it has a '.js' file extension and '/home/xyz/work/own/svelte-tel-input/package.json' contains "type": "module". To treat it as a CommonJS script, rename it to use the '.cjs' file extension.
file:///home/xyz/work/own/svelte-tel-input/node_modules/@sveltejs/kit/src/core/prerender/prerender.js:48
                                throw new Error(format_error(details, config));
                                      ^

Error: 500 /
    at file:///home/xyz/work/own/svelte-tel-input/node_modules/@sveltejs/kit/src/core/prerender/prerender.js:48:11
    at save (file:///home/xyz/work/own/svelte-tel-input/node_modules/@sveltejs/kit/src/core/prerender/prerender.js:336:4)
    at visit (file:///home/xyz/work/own/svelte-tel-input/node_modules/@sveltejs/kit/src/core/prerender/prerender.js:223:3)
[vite-plugin-svelte-kit] Prerendering failed with code 1
error during build:
Error: Prerendering failed with code 1
    at ChildProcess.<anonymous> (file:///home/xyz/work/own/svelte-tel-input/node_modules/@sveltejs/kit/src/vite/index.js:417:14)
    at ChildProcess.emit (node:events:527:28)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:291:12)

Demo app
><EMAIL_ADDRESS>build
> vite build

vite v3.0.9 building for production...
✓ 52 modules transformed.
.svelte-kit/output/client/_app/immutable/assets/svelte-logo-87df40b8.svg                           1.85 KiB
.svelte-kit/output/client/_app/immutable/assets/fira-mono-cyrillic-ext-400-normal-3df7909e.woff2   15.40 KiB
.svelte-kit/output/client/_app/immutable/assets/fira-mono-cyrillic-400-normal-c7d433fd.woff2       8.89 KiB
.svelte-kit/output/client/_app/immutable/assets/fira-mono-greek-400-normal-a8be01ce.woff2          10.27 KiB
.svelte-kit/output/client/_app/immutable/assets/fira-mono-latin-400-normal-e43b3538.woff2          15.90 KiB
.svelte-kit/output/client/_app/immutable/assets/fira-mono-greek-ext-400-normal-9e2fe623.woff2      7.33 KiB
.svelte-kit/output/client/_app/immutable/assets/fira-mono-latin-ext-400-normal-6bfabd30.woff2      11.10 KiB
.svelte-kit/output/client/_app/immutable/assets/fira-mono-all-400-normal-1e3b098c.woff             75.55 KiB
.svelte-kit/output/client/vite-manifest.json                                                       7.60 KiB
.svelte-kit/output/client/_app/immutable/components/error.svelte-1aa22767.js                       1.54 KiB / gzip: 0.71 KiB
.svelte-kit/output/client/_app/immutable/components/pages/_layout.svelte-818ca664.js               4.50 KiB / gzip: 1.74 KiB
.svelte-kit/output/client/_app/immutable/components/pages/_page.svelte-60cbe889.js                 5.46 KiB / gzip: 2.42 KiB
.svelte-kit/output/client/_app/immutable/components/pages/about/_page.svelte-4c2aaaa2.js           2.46 KiB / gzip: 1.11 KiB
.svelte-kit/output/client/_app/immutable/modules/pages/_page.ts-e9fa0128.js                        0.07 KiB / gzip: 0.08 KiB
.svelte-kit/output/client/_app/immutable/start-be845c33.js                                         22.92 KiB / gzip: 8.72 KiB
.svelte-kit/output/client/_app/immutable/modules/pages/about/_page.ts-e8ab19e6.js                  0.11 KiB / gzip: 0.11 KiB
.svelte-kit/output/client/_app/immutable/chunks/singletons-e5e57fbd.js                             0.05 KiB / gzip: 0.07 KiB
.svelte-kit/output/client/_app/immutable/components/pages/todos/_page.svelte-a806b8ca.js           6.86 KiB / gzip: 2.88 KiB
.svelte-kit/output/client/_app/immutable/chunks/index-67daab9a.js                                  0.43 KiB / gzip: 0.31 KiB
.svelte-kit/output/client/_app/immutable/chunks/stores-87dd2ac2.js                                 0.53 KiB / gzip: 0.31 KiB
.svelte-kit/output/client/_app/immutable/chunks/_page-802cc2a3.js                                  0.14 KiB / gzip: 0.14 KiB
.svelte-kit/output/client/_app/immutable/chunks/_page-efb9c460.js                                  0.18 KiB / gzip: 0.16 KiB
.svelte-kit/output/client/_app/immutable/chunks/0-5939c936.js                                      0.15 KiB / gzip: 0.13 KiB
.svelte-kit/output/client/_app/immutable/chunks/1-3fa30a9b.js                                      0.14 KiB / gzip: 0.13 KiB
.svelte-kit/output/client/_app/immutable/chunks/index-98702734.js                                  11.48 KiB / gzip: 4.90 KiB
.svelte-kit/output/client/_app/immutable/chunks/2-e130a139.js                                      0.20 KiB / gzip: 0.15 KiB
.svelte-kit/output/client/_app/immutable/chunks/3-c898f07b.js                                      0.18 KiB / gzip: 0.15 KiB
.svelte-kit/output/client/_app/immutable/chunks/4-515ea953.js                                      0.18 KiB / gzip: 0.15 KiB
.svelte-kit/output/client/_app/immutable/assets/+page-8bad58d3.css                                 1.45 KiB / gzip: 0.52 KiB
.svelte-kit/output/client/_app/immutable/assets/+page-9682aba9.css                                 0.11 KiB / gzip: 0.10 KiB
.svelte-kit/output/client/_app/immutable/assets/+layout-c589ff87.css                               4.84 KiB / gzip: 1.54 KiB
.svelte-kit/output/client/_app/immutable/assets/+page-5c3529b5.css                                 3.70 KiB / gzip: 1.03 KiB
vite v3.0.9 building SSR bundle for production...
✓ 58 modules transformed.
.svelte-kit/output/server/vite-manifest.json                       3.05 KiB
.svelte-kit/output/server/index.js                                 59.23 KiB
.svelte-kit/output/server/entries/pages/_layout.svelte.js          4.09 KiB
.svelte-kit/output/server/entries/fallbacks/error.svelte.js        0.60 KiB
.svelte-kit/output/server/entries/pages/_page.svelte.js            7.10 KiB
.svelte-kit/output/server/entries/pages/_page.ts.js                0.05 KiB
.svelte-kit/output/server/entries/pages/about/_page.svelte.js      1.25 KiB
.svelte-kit/output/server/entries/pages/about/_page.ts.js          0.15 KiB
.svelte-kit/output/server/entries/pages/todos/_page.svelte.js      5.92 KiB
.svelte-kit/output/server/entries/pages/todos/_page.server.ts.js   1.22 KiB
.svelte-kit/output/server/chunks/index.js                          4.15 KiB
.svelte-kit/output/server/chunks/index2.js                         0.73 KiB
.svelte-kit/output/server/chunks/index3.js                         1.29 KiB
.svelte-kit/output/server/chunks/stores.js                         0.81 KiB
.svelte-kit/output/server/chunks/hooks.js                          0.49 KiB
Error: Cannot prerender pages that have endpoints with mutative methods
    at render_page (file:///home/xyz/work/own/prerender-test/.svelte-kit/output/server/index.js:1207:15)
    at async resolve (file:///home/xyz/work/own/prerender-test/.svelte-kit/output/server/index.js:1683:92)
    at async Object.handle (file:///home/xyz/work/own/prerender-test/.svelte-kit/output/server/chunks/hooks.js:5:20)
    at async respond (file:///home/xyz/work/own/prerender-test/.svelte-kit/output/server/index.js:1592:22)
    at async visit (file:///home/xyz/work/own/prerender-test/node_modules/@sveltejs/kit/src/core/prerender/prerender.js:214:20)
file:///home/xyz/work/own/prerender-test/node_modules/@sveltejs/kit/src/core/prerender/prerender.js:48
                                throw new Error(format_error(details, config));
                                      ^

Error: 500 /todos/ (linked from /todos)
    at file:///home/xyz/work/own/prerender-test/node_modules/@sveltejs/kit/src/core/prerender/prerender.js:48:11
    at save (file:///home/xyz/work/own/prerender-test/node_modules/@sveltejs/kit/src/core/prerender/prerender.js:336:4)
    at visit (file:///home/xyz/work/own/prerender-test/node_modules/@sveltejs/kit/src/core/prerender/prerender.js:223:3)
[vite-plugin-svelte-kit] Prerendering failed with code 1
error during build:
Error: Prerendering failed with code 1
    at ChildProcess.<anonymous> (file:///home/xyz/work/own/prerender-test/node_modules/@sveltejs/kit/src/vite/index.js:417:14)
    at ChildProcess.emit (node:events:527:28)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:291:12)

System Info
System:
    OS: Linux 5.15 Ubuntu 20.04.4 LTS (Focal Fossa)
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 10.42 GB / 15.48 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 16.16.0 - ~/.local/share/pnpm/node
    npm: 8.17.0 - ~/.local/share/pnpm/npm
  Browsers:
    Chrome: 104.0.5112.79
    Firefox: 103.0
  npmPackages:
    @sveltejs/adapter-static: ^1.0.0-next.39 => 1.0.0-next.39
    @sveltejs/kit: ^1.0.0-next.427 => 1.0.0-next.427
    svelte: ^3.49.0 => 3.49.0
    vite: ^3.0.9 => 3.0.9

Severity
blocking an upgrade
Additional Information
No response

As explained in the issue template form:

Reproductions must be short, self-contained and correct and must not contain files or code that aren't relevant to the issue — please do NOT just paste a link to your project.

For the sample app with adapter-static, the logs tell you what's wrong: there is a server-side endpoint, which cannot be prerendered (Error: Cannot prerender pages that have endpoints with mutative methods). For your actual project, something else is going on, presumably related to trying to treat CommonJS code as ESM code, possibly because Babel is transpiling it.

As explained in the issue template form:

Reproductions must be short, self-contained and correct and must not contain files or code that aren't relevant to the issue — please do NOT just paste a link to your project.

Right.
I've deleted my part, now it's just the original svelte-kit created app, with adapter-static.

For the sample app with adapter-static, the logs tell you what's wrong: there is a server-side endpoint, which cannot be prerendered (Error: Cannot prerender pages that have endpoints with mutative methods). For your actual project, something else is going on, presumably related to trying to treat CommonJS code as ESM code, possibly because Babel is transpiling it.

But it's works fine before. E.g. on: "@sveltejs/kit": "^1.0.0-next.411",

I'll do some debug to ensure, what's going on. Until that I close this.
Thanks for the notice about issue template. Next time I'll create that way.


Hotfix: roles modal for off-chain communities

:tada: This PR is included in version 1.28.10 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


License information

Added license to README as well as the complete license file and a NOTICE file as required by Apache to fulfil the license.
Important notice: I am not a lawyer!

This closes #9

Great, please squash it into a single commit.


[Snyk] Security upgrade victory from 34.3.12 to 35.0.0

Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

chapters/chapter-11/code/package.json

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

479/1000  Why? Has a fix available, CVSS 5.3
Regular Expression Denial of Service (ReDoS) SNYK-JS-D3COLOR-1076592
Yes
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Superceded


Exception when property unknown

Hi,
is there a way to disable\mitigate exception throwing when an unknown property comes in?
Thank you.

Hey  @pichillilorenzo ,
after a year, is there any chance to have a response?

The behavior can be controlled via deserialization options:
parser.defaultContext.features.deserialization.FAIL_ON_UNKNOWN_PROPERTIES = false;


Allow dashes in ddg subdomain regex

Reviewer: TBD
Description:
Adds support for DDG subdomains that include dashes in ATB accepted URL regex.

e.g https://dev-machine.duckduckgo.com

Steps to test this PR:

Build Chrome/FF dev build
Install extension
Visit a DDG subdomain that includes a dash (-)
[ ] Ensure the atb= param is appended to the URL

Automated tests:

[ ] Unit tests
[ ] Integration tests

Reviewer Checklist:

[ ] Ensure the PR solves the problem
[ ] Review every line of code
[ ] Ensure the PR does no harm by testing the changes thoroughly
[ ] Get help if you're uncomfortable with any of the above!
[ ] Determine if there are any quick wins that improve the implementation

PR Author Checklist:

[ ] Get advice or leverage existing code
[ ] Agree on technical approach with reviewer (if the changes are nuanced)
[ ] Ensure that there is a testing strategy (and documented non-automated tests)
[ ] Ensure there is a documented monitoring strategy (if necessary)
[ ] Consider systems implications

Oh wait, can you please add a test for this in https://github.com/duckduckgo/duckduckgo-privacy-extension/blob/develop/unit-test/background/atb.es6.js#L56 ?

Oh wait, can you please add a test for this in https://github.com/duckduckgo/duckduckgo-privacy-extension/blob/develop/unit-test/background/atb.es6.js#L56 ?

@kdzwinel this is now done 👍🏽

Seems like the test failures are unrelated?

Yeah, it was  a flaky test. Thanks Zaahir!


Local query and mutation cache

I'm wondering where the local operation cache is located, for both the Electron app and the express middleware.
I'm working with different projects that are all running on localhost:4000, and everytime I start a new project and I open the electron app, it gets seeded with tabs that contain queries and mutations that are invalid for my current project. Instead, I would like the queries saved per project, rather than per URL.
Also, is there a way to fully reset the query and mutation cache?

The cache is located in localStorage.
We fixed the playground to take the path of the project as the key for the state.
This should fix the described scenario!
Please reopen if you have more questions / it's not fixed for you.


Header UI changes and Social Sharing of the app

Issue Number
fixes #178 , #258

Describe the changes you've made
I added a design for social sharing of the app and also changed the UI of the header for all pages.
Checklist

[x] My code follows the code style of this project.
[] My change requires a change to the documentation.
[] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] The title of my pull request is a short description of the requested changes.

@Abhishek-kumar09 Please check it once....I accidently deleted the previous branch which caused PR to close.

Github, rebase


Looking at better logging in debug mode for snmp

Closes #705
Changes how debug level logging goes.

Removes 1 NR log which is confusing to the user.

Adds a log on each poll which looks like:

2024-04-29T22:26:23.125 ktranslate/ [Debug] KTranslate>bart (<IP_ADDRESS>) polling <IP_ADDRESS>.<IP_ADDRESS>.0 using github.com/gosnmp/gosnmp.(*GoSNMP).WalkAll-fm took 6.968ms. attempt 0 of 2.

Adds a log after each metric poll (of all the oids) which looks like:

2024-04-29T22:28:33.472 ktranslate/ [Debug] KTranslate>bart Metrics Poll: In 453.71575ms polled 14 mibs, 0 missing.

Thoughts?

Can we add a tag to the kentik.snmp.Uptime metric that shows the current logging level? Something like tags.container_logging?
I'm concerned about blowing out storage if debug is left enabled. These logs are contextually valuable, but if left running I can see a problem on the horizon.

How does this look:
"SysLogLevel": "Info",

There's a hack where things prefixed Sys only get added to Uptime. So this lets things happen with a min of fuss.


ORC-384 fix memory leak when loading non-ORC files

Change-Id: Ia32f687f12f66c26b807200f90dd7ddcc5f27f8d

+1 LGTM. I will check this in by end of today.


expression color formatting - ASC, DESC

Would be great for ASC & DESC to show in blue color in the expression editor.

Thanks for reporting. Adding these + the new financial DAX functions (and a few other missing functions and keywords)

Ah perfect, thanks!

Fixed in 2.11.6.


Create a report based on new accidents entered to the database - backend

Create a report triggerd on new accidents entered to the database, based on lowest severity requested by users.
For example, if users requested to get notified only about severe accidents, then if a light accident was entered to the database, no report will be created.
The report needs to be based on the postgis optimization - issue #257
The report also needs to show the history of accidents in the close area of the accident.
The report can be based on a radius from the accident's place - for example, show all the accidents in 2 km radius of the accident.
For now, it will be the same report for all relevant users subscribed to the report.
based on #520.

Waiting for #518

I am starting working on it, please assign this issue to me


[bug]: sweeper keeps trying to sweep invalid anchor output until locking up all on-chain funds on node

Background
LND trying to sweep invalid output, locking up all wallet funds.
Your environment

version of lnd: LND 0.15.4-beta
which operating system 18.04-Ubuntu
neutrino

Steps to reproduce
force close channel https://mempool.space/tx/c8b3d28d1273e6e4d6ea0de25b4c27bc89ca14718ce7c97a31b07da73a027185
Expected behaviour
If anchor transaction was swept already, it should be detected and lnd should stop trying to sweep it.
c8b3d28d1273e6e4d6ea0de25b4c27bc89ca14718ce7c97a31b07da73a027185:1 in the above tx.
Actual behaviour
Repeated sweeps are created that are invalid.  A different unused UTXO is selected each time but is not accepted into mempool since the output is already spent.  More and more transactions are created to try and sweep until no more UTXO are available.
Here is a screenshot of the situation in RTL:  None of those transactions exist in mempool.

Here are some of those raw tx from listchaintxs...
90eda27443517657c971d26a7cb099f9b7b1fc89bcc9ca6160b7e974b044e5d3 :<PHONE_NUMBER>01028571023aa77db0317ac9e78c7114ca89bc274c5be20dead6e4e673128dd2b3c80100000000000000002a770181af76a3dc17f2e071f2500c87c879ce7e2fe4d42e77b6dbde5cae78c0010000000000000000012f8b200000000000225120009be33bb1c1ff4de6ca3de20ba6f570c1dd72e5bf74484d3ad8649b4d9a509c0247304402200d65ae25fb7e781ced657c1af3258eca8bee2e939dab49808a0fa386766995c502204aa458d75242e33a492ff8f80004f2c6708fb4410fbde4a713f75e09a8d50ec501282103fbf21f752192b0022491a0478b5a4c94ff1534e7328fb9884e8e88675d29e6f8ac736460b26802483045022100b6adc1c1bbaa04387c1fcc5aba482ecb7815f39bba1e7fc7791b082bc800bab8022026e6c0f8e3aac9cec46d70c9620b1800c9eeb5d82f4ae530dce16c80187b57f00121032059e6a56281f5ebf3b7579b08ece1766cb531923182d53dbe4c15f3fbd1a1a6b7d50b00
482870fe60e65ef17d6d2ca8facef0dcc8e528c21c3ed932262347d463fca18e :<PHONE_NUMBER>01028571023aa77db0317ac9e78c7114ca89bc274c5be20dead6e4e673128dd2b3c8010000000000000000402a839bc36b61c6714c9bc076670ca0ebcb3d72d05c9237691483c128a6a7d4000000000000000000010ace020000000000225120ca2f32bfb44c79fda9efbb474076ed20f4824c0bf8317d06b4a65dc0b42eb2ad02483045022100e4f2feb3c0d274b0351a565cf460e477e61e7ae21400ffb52cb85ff8477709dd02205066f5e3578e2cc5a348f8e25926a5359d1f1aaa5cc6913331b064ff207d75d001282103fbf21f752192b0022491a0478b5a4c94ff1534e7328fb9884e8e88675d29e6f8ac736460b26801409be7cb57b719e235e1bb59fb04b4839e6264b70ab82064444b460497aea1c62415c2fcc2150ba5c70daf9eae3766b82764a12d1e3ca68c906d18edd0869c89f4b2d50b00
53085820a65121739be6ffb067aedbfff10ddf7f6883b61e4631b8dc2c5adfad:<PHONE_NUMBER>01028571023aa77db0317ac9e78c7114ca89bc274c5be20dead6e4e673128dd2b3c801000000000000000048fefaff6b8845d25a47275a3b1293c708d35d87a22663bb54b25f5f381eb00b0100000000000000000168ae1f00000000002251204e714f6ecc8ccaf307b1c47c51b61e50f85fb48db6e5d98a3eb5905c0e4641820247304402207c098b7ddc4d09b7f0f72265c630a6f24c86bd9f56d2f0821df7b937535bf49c022046bc5c11751d88336bcb5038a9b1f60e195c6024a77995242a62a0517c0c603401282103fbf21f752192b0022491a0478b5a4c94ff1534e7328fb9884e8e88675d29e6f8ac736460b2680140dd305a449aec63b772f08679501835f58efeeccbc2f85613848afb3b0e8f1ad60f81fb39958969feeea872e26e7d8f890b631a66e406999ae047c24c7b118cb3abd50b00
You can see each of these is trying to sweep that same outpoint.  Here is what it looks like in listchaintxs:
"previous_outpoints": [
                {
                    "outpoint": "c8b3d28d1273e6e4d6ea0de25b4c27bc89ca14718ce7c97a31b07da73a027185:1",
                    "is_our_output": false
                },
                {
                    "outpoint": "1e6f48e78bd44dd2374c470e6106ed31069d37455ff86a376cf99890d32886c2:0",
                    "is_our_output": true
                }
            ]

This seems to be related to https://github.com/lightningnetwork/lnd/pull/6274 but the issue exists in my node now, which already includes that merge.
maybe related to https://github.com/lightningnetwork/lnd/issues/6367 https://github.com/lightningnetwork/lnd/issues/6434
** I should note that I have already run  --reset-wallet-transactions and the issue persists.

Ok, but this is a real problem that makes the node unusable now.
I don't think the sweeper should be locking up the entire balance.  At minimum, a reserve should be left behind.  Not to mention that it makes it impossible to open new channels, and any UTXOs freed from closed channels are instantly locked up also.  It's a pretty crippling issue for me.

What is the block height in lncli getinfo? Is the node synced?

    "block_height": 775620,
    "block_hash": "000000000000000000058918f6d4a070443ef9f112eaabb858e15958f44814ca",
    "best_header_timestamp": "1675885337",
    "synced_to_chain": true,
    "synced_to_graph": true,

yes, that input is in all of those txs.
Here it is in the logs:
2023-02-07 23:55:21.964 [INF] SWPR: Creating sweep transaction 961c8bdb0d0c9af9e6aefe119512db92fc4c08bd6e78114f8ead85bab36298fe for 2 inputs (c8b3d28d1273e6e4d6ea0de25b4c27bc89ca14718ce7c97a31b07da73a027185:1 (CommitmentAnchor), c35d6ffc8c428ee391bbdfb726dd982502dfe88178c7d023e43e6a7ae3bc6b37:0 (WitnessKeyHash)) using 253 sat/kw, tx_weight=767, tx_fee=0.00000194 BTC, parents_count=0, parents_fee=0 BTC, parents_weight=0
2023-02-07 23:55:21.975 [INF] LNWL: Inserting unconfirmed transaction 961c8bdb0d0c9af9e6aefe119512db92fc4c08bd6e78114f8ead85bab36298fe

It is no longer in listchaintxs after running --reset-wallet-transactions.  I had to re-scan since all of my UTXOs were already locked, and after rescanning, they are again getting locked in sweeps.
It's almost like there is some kind of race condition causing the entire wallet balance to get frozen up.

Are they ALL locked? A CPFP spending form that tx bumping the fee (if possible) may unlock this situation.

Yes - that's what happens, all of my UTXOs get locked up.  I would have to send some more funds on-chain to wallet and try to beat the sweeper to do a CPFP.  I don't know if I can even pull it off.

What about your balance from the closed channel. Was it a force close? https://mempool.space/tx/c8b3d28d1273e6e4d6ea0de25b4c27bc89ca14718ce7c97a31b07da73a027185

Yes it was a force close.  that UTXO is still locked, although at this point it's only 25 more blocks to maturity.  At that point my guess is that it will create another sweep transaction that's going to get locked.  joy.

I wish there was a way that I could manually add a transaction into the wallet, since the 961c8bdb0d0c9af9e6aefe119512db92fc4c08bd6e78114f8ead85bab36298fe transaction is not visible to the wallet.  If I could do that, I would try to re-craft that transaction with same inputs but higher fee as it does have RBF.

I think I did something...  https://mempool.space/tx/56bf762416c7506b20a163927a85f5aedf981d94a3a6484454a33e28da0d1699
wallet bumpfee --sat_per_vbyte=15 --force c8b3d28d1273e6e4d6ea0de25b4c27bc89ca14718ce7c97a31b07da73a027185:1
"pending_sweeps": [
                {
                        "outpoint": "c8b3d28d1273e6e4d6ea0de25b4c27bc89ca14718ce7c97a31b07da73a027185:1",
                        "witness_type": "COMMITMENT_ANCHOR",
                        "amount_sat": 330,
                        "sat_per_vbyte": 15,
                        "broadcast_attempts": 6,
                        "next_broadcast_height": 775625,
                        "requested_sat_per_vbyte": 15,
                        "requested_conf_target": 0,
                        "force": true
                },

It just got confirmed, that should unlock the rest of your utxos

Yes!  It unlocked those UTXOs.  but there is another one now.  It seems that I somehow created a CPFP on one of the invalid txns, and it's now trying to sweep that.  Ugh.
        "pending_sweeps": [
                {
                        "outpoint": "d4a349044f3da93e9852b439a424dd1ab170ac71435703740b11396cd4945234:0",
                        "witness_type": "UNKNOWN_WITNESS",
                        "amount_sat": 2947918,
                        "sat_per_vbyte": 15,
                        "broadcast_attempts": 5,
                        "next_broadcast_height": 775636,
                        "requested_sat_per_vbyte": 15,
                        "requested_conf_target": 0,
                        "force": false
                }
        ]

This pending sweep generates Code: -25, Error: bad-txns-inputs-missingorspent  Because of course the input is invalid.

This was one of the tx that had as input the anchor right? d4a349044f3da93e9852b439a424dd1ab170ac71435703740b11396cd4945234
The sat per vbyte is also 15, did you bump more than one?

yes, it was.  and luckily the d65 transaction is only one input, so the sweeper isn't trying to use up my good UTXOs to try and get that one confirmed.
I need to figure out how to drop this tx from the wallet, but otherwise, it's more annoying than a real danger now.
The bug with sweeper still stands, however.  The entirety of my confirmed balance should not be consumed when in this state with numerous unconfirmed sweep transactions.  I'm hoping that this doesn't happen with the new 0.16 version, not sure how to verify this bug is there.  I could try and reproduce it, or at least watch for it after 0.16 is out.

@Horndev did you save the logs of your node? They could be useful to make sure that the root cause is fixed and this won't happen again.

Yes I have logs saved.  The d65 transaction is doing something funny now.  It keeps trying to sweep it, but adds more unconfirmed/invalid utxos into the wallet.  The wallet balance just keeps going up and up.  I'm rich!  (if only they were valid utxos).
I'll have to take node offline and re-scan at some point to get things back to reality.


Changing the page layout for single pages (e.g. chapter title pages)

Opening this as a feature request since I haven’t found a way to achieve something similar to LaTeX’s \thispagestyle, i.e. (programmatically) setting the page layout for single pages while having normal text flow (the next page has the regular layout again, whenever it begins). It seems that currently it is only possible to set a page layout together with the full contents of the affected page(s).
My concrete use case are chapter title pages with additional logos in the margins, which required me to set header-ascent. I could maybe hack around this with absolute positioning on a chapter headline, but this does not cover other uses like different page margins or background colours on single pages.
I’m not completely sure what the best solution here looks like as I’m not familiar with what typst’s internal architecture allows. I could imaging something like set page(thisionly: true) or a locate() which does not only return content. If approached more generally, i.e. allowing to set some properties of the page without forcing a page break, this could also make e.g. section-based running heads a lot easier to understand than the current way with locate().
My original discussion post with my experiments below:
Discussed in https://github.com/typst/typst/discussions/1082

Originally posted by fruchti May  3, 2023
I’m currently trying to modify the page style for every page with a chapter heading on it. This involves header and footer texts as well as different page margins from the rest. Basically, I’m looking for something more or less like \thispagestyle in LaTeX.
The first step, adding a page break before each chapter, is not an issue:
#show heading.where(level: 1): it => [
    #pagebreak(weak: true)
    #it
]

However, I haven’t found a way to set page() the way I want. Things I’ve tried so far:

Using show/set (e.g. #show heading.where(level: 1): set page(..title_page_options)) effects a page break immediately after the heading. I assume since the page style is only set for the heading’s block, typst begins a new page to assure that the next block has the old page style again. [Update: With 0.5, this doesn’t do anything anymore]
Defining a function (used instead of = Chapter Title) which includes a #set page has the same result.
I might be able to build a selector out of before() and after() which gets me pages with a chapter heading on them. With this, I could adjust the header/footer text like the example in the docs. Since locate() returns a content, I cannot use this to adjust the margins. I also cannot adjust all values at once, since I didn’t find a way to pass a dictionary through locate().
With #show page: p => locate(loc => p) I got no output at all any more, so I didn’t try any further based on that.
I tried using #set… if together with locate() by returning content from locate() which either has or hasn’t a specific field, depending on whether I am currently on a page with a chapter heading or not. However, even with#set page(..title_page_options) if locate(loc => box(width: 1pt)).has("width")

the condition never holds and the style doesn’t get applied (it looks like the locate() isn’t even evaluated actually).

Hi, the page break happen also in last version https://typst.app/project/rPZKNPwCPtiozZHCzDmDLO.
What do you mean with [Update: With 0.5, this doesn’t do anything anymore]?

Hi, I just ran into the same problem with chapter title pages (in my case I want to hide the page header on them) and found a workaround that might be useful for others running into this problem.
Instead of setting different page styles on the page, you can put some logic into the initial page style definition so that it differs between pages.
In my case, I used a context if in the header with a query to check if the page number of the next level 1 heading is the current page, in which case I leave heading empty.
If you want to change individual pages, you could probably extend this by using something like a metadata element on those pages and querying for its existence in the set page definition.
Here is a complete example:
#set page(
  header: context if (
    not query(heading.where(level: 1).after(here()))
      .map(h => h.location().page())
      .at(0, default: 0) == here().page()
  ) [Not a chapter page]
)


broke in multiple touch

Can you elaborate a little?

@clauderic yes 😸
When I use my finger touch move one item, at the same time, another finger touch move another item, the first item is fly 🍂

PR #73 should fix this as onTouchCancel can fire from too many touch points. As per MDN Docs: The touchcancel event is fired when a touch point has been disrupted in an implementation-specific manner (for example, too many touch points are created).

Just confirmed that this is still an issue. I'll try to take a look into how this could be solved

@clauderic, I confirmed this is an issue still and was wondering if you made it any further on fixing this. Thanks!

@clauderic Any update on this... I am also facing same problem.

I have a similar issue—on mobile only, using DragSortHandle, after initial touch on element it is affixed to the viewport, and subsequent touchmoves drag the document rather than the element (see below).

It's still a problem and probably it's a duplicate of this one -> https://github.com/clauderic/react-sortable-hoc/issues/440.

I'm also facing the same problem. On touch devices if i long press(long press is disabled) on row, its just freezes on top of the screen.

Facing exactly same issue with dragHandle.
Works fine in desktop view but in any mobile view it freezes the row on top and only page scrolls


Seeing duplicate revisions

We're seeing duplicate revisions in many of our items.  We may have found the issue, but it might take some time to get a PR reviewed.  If someone can repro and submit a fix, that would be awesome!
https://github.com/Netflix/security_monkey/blob/develop/security_monkey/datastore.py#L573 adds a new revision, but shouldn't because https://github.com/Netflix/security_monkey/blob/develop/security_monkey/datastore.py#L551-L557 handles revision updates (specifically revisions for ephemeral changes).

@cstewart87 - Was this addressed?

Hey @monkeysecurity!  I had to refresh, and after looking at the code, it looks like this may no longer be the case.  Well, the code has changed in recent releases, at least.
The original issues were here:

https://github.com/Netflix/security_monkey/blob/c666a012ec65a4ffcb878d148e2af33022c42afd/security_monkey/datastore.py#L573 (adds new revision, but shouldn't)
https://github.com/Netflix/security_monkey/blob/c666a012ec65a4ffcb878d148e2af33022c42afd/security_monkey/datastore.py#L551-L557 (handles revision updates for ephemeral changes)

I'm no longer on the project, but it might be worth reaching out to @kalpatel01 to see if he's still seeing this issue.


Broken Link(s)

Hello, the Custom Vision Training API and Custom Vision Prediction API links (under Reference) are broken.
https://go.microsoft.com/fwlink/?linkid=865446
https://go.microsoft.com/fwlink/?linkid=865445

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b059be5c-7d30-c412-bdd7-cbe76383ac24
Version Independent ID: 9df53112-e1e5-e555-eec1-512df3f0fa8d
Content: What is Azure Custom Vision?
Content Source: articles/cognitive-services/Custom-Vision-Service/home.md
Service: cognitive-services
GitHub Login: @anrothMSFT
Microsoft Alias: anroth

@anrothMSFT Hi, can you please take a look of this issue and update the document as necessary? Thanks a lot!

Thanks! Sorry for missing this while out for Christmas. These links have been fixed. Our docs team is evidently switching over to new API Reference docs, and evidently this broke links in process. So sorry.
From: YutongTie-MSFT<EMAIL_ADDRESS>Sent: Wednesday, December 26, 2018 11:09 AM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Anna Roth<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Broken Link(s) (#21184)
@anrothMSFThttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FanrothMSFT&data=02|01|anroth%40microsoft.com|2f704767e67e4354df2b08d66b659107|72f988bf86f141af91ab2d7cd011db47|1|0|636814481299061016&sdata=eACgGP7TwzfAuOcUVGYL9er2hr1jVAsisorARxBKPLI%3D&reserved=0 Hi, can you please take a look of this issue and update the document as necessary? Thanks a lot!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F21184%23issuecomment-450010731&data=02|01|anroth%40microsoft.com|2f704767e67e4354df2b08d66b659107|72f988bf86f141af91ab2d7cd011db47|1|0|636814481299071025&sdata=6u7xdp8OlDuLjDau0QQfKm%2FP917cl6QbfLS7UcBvTQg%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAfY-f6IBl7F7WuE7b8JnjSaEcVQkPOijks5u88lAgaJpZM4ZfZx_&data=02|01|anroth%40microsoft.com|2f704767e67e4354df2b08d66b659107|72f988bf86f141af91ab2d7cd011db47|1|0|636814481299071025&sdata=YYCMjecwmVHXDeVOGljNsgyKNp5Q2WFeqow4s1kBI8g%3D&reserved=0.


Clone could add .gitignore and .gitattributes

Having a top level .gitignore file and .gitattributes file is a best practice at this point and it seems to make sense that when creating a new git repository it would be handy if git-tfs included smart defaults for that.
Particularly, this can be important for text normalization (* text=auto in .gitattributes) and getting well-normalized output from the TFS import process.

In our use-case of a one-way migration from tfs/vsts to git, I wanted to add .gitattributes and .gitignore as the very first commit. Just like the --git-ignore= option, but with an extra file.
In order to do that, I hacked the remotes/tfs/default branch.
So instead of git-tfs clone we're doing:
git-tfs.exe init <tfs> <branch> <workdir>
cd <workdir>
copy ..\template\* .
git add -A
git commit -m "Add .gitignore and .gitattributes"

mkdir .git\refs\remotes\tfs
git rev-parse HEAD > .git\refs\remotes\tfs\default

git-tfs.exe pull

It seems to work fine. I hope this might help others.

There is the git ignore option. I think we could close the issue

While .gitignore is covered by a configuration setting, what about .gitattributes (which was also asked to be included)?
I, personally, would find it very useful to include a .gitattributes file when initing a Git repos for cloning to ensure that all commits - from the cloning itself to the later use by others - conform to the same attributes settings to avoid issues.

My understanding is that adding .gitattributes would not work because of limitations in the underlying C lib (libgit2).
Please see this: https://github.com/git-tfs/git-tfs/pull/1370
And this in particular: https://github.com/git-tfs/git-tfs/pull/1370#issuecomment-818197745
Any hope of seeing LFS support, either through .gitattributes or another hack maybe?  (like custom script that could be applied if commits contains specific filepaths or blobs > size) ?
Thanks.

@bgoshe I think I have actually figured out the missing piece for the limited .gitattributes support (line endings & diff settings) while I was delving into some ongoing problems I was having with an alternate approach to this missing functionality. (See #1495 for more details). I should be able to open a new PR completing the work I had started in #1370.

That would be sweet! Thank you for these investigations.

Any hope of seeing LFS support, either through .gitattributes or another hack maybe? (like custom script that could be applied if commits contains specific filepaths or blobs > size) ?

With a gist I found in another discussion about git-LFS, but in the libgit2sharp project, I was able to make git-TFS aware of git-LFS. It's working just normally, by respecting .gitattributes, since a clean/smudge content filter is registered to libgit2sharp on starting up git-lfs.
I'm now too facing the question, how to go about cloning from TFS for the first time, when there is no .gitattributes file checked in to TFS and one would like to clone directly LFS-filtered (knowing in advance that bad, binary files have been added to TFS for example by colleagues), it would need to work with an initial .gitattributes which could be provided optionally to the git tfs clone command, and would be checked in as the first commit.
Enabling Git-LFS "on the fly" would be the job of the filter (I'd add that functionality to it, also for the case that at some changeset being fetched from TFS, a .gitattributes file indicating LFS filtering is encountered, LFS should as well be autmatically enabled in the local repo "on the fly" from that commit on, as opposed to right from the very first one when such a file would be provided to the clone command, which is not supported as of now).
@bgoshe, if you're interested in LFS support in git-TFS, please try it out from my branch mentioned above. For now, LFS needs to be enabled and configured manually, as in normal git repos in which git tfs is not used.


 Last update a1c5f02...ddee4c8

LGTM

LGTM

Thanks it always bugs me. How about we make gofmt mandatory?

make lint on CI after we fix all the lint errors.

On Fri, Nov 11, 2016 at 09:23:22AM -0800, Lunny Xiao wrote:

make lint on CI after we fix all the lint errors.

Please expose a make dev-setup too, to install relevant
git hooks to ensure style upon commit :)


Iterate on MSL Investigations landing high-fidelity designs (draft 3)

💡 Description
Iterate on MSL landing page, coalesce that content with that of the cassini archive content (ATM and RMS)

https://www.figma.com/file/9y6Davo80c1cuKvPFfIcAu/Mockups?node-id=1168%3A51419

https://www.figma.com/file/9y6Davo80c1cuKvPFfIcAu/Mockups?node-id=29%3A7092

https://www.figma.com/file/9y6Davo80c1cuKvPFfIcAu/Mockups?node-id=29%3A7092

https://www.figma.com/file/9y6Davo80c1cuKvPFfIcAu/Mockups?node-id=1168%3A51419


add GetUnsignedLongLong() property getter

This would fix LuxCoreRender/BlendLuxCore#107.
Tested compilation and usage on Linux and Windows.
Created on extra branch with pull request because we are so short before release.
(I will delete the branch after it is merged to avoid clutter)

But you can just commit directly to the repository without all this pull/push thing. You should have the rights (?).

Yes I have the rights.
But I think it is more polite and as I said it's short before release, so if it turned out there was extra work needed it would be better to have it on a separate branch.
I'm probably overthinking things.


Expand doc comments (no code changes) with details of how command line config switches work

Expand doc comments (no code changes) with details of the command line switch formats supported, and how switchMappings works.

Hi @sgryphon, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

How do we trigger another build?  This change only modified doc comments, and there was no code change, yet build is failing:
info:   Discovered:  Microsoft.Extensions.Configuration.FunctionalTests
info:   Starting:    Microsoft.Extensions.Configuration.FunctionalTests
fail:     Microsoft.Extensions.Configuration.Test.ConfigurationTests.CreatingOptionalFileInNonExistentDirectoryWillReload [FAIL]
info:       Assert.Equal() Failure
info:       Expected: JsonValue1
info:       Actual:   (null)
info:       Stack Trace:
info:         /home/travis/build/aspnet/Configuration/test/Microsoft.Extensions.Configuration.FunctionalTests/ConfigurationTests.cs(612,0): at Microsoft.Extensions.Configuration.Test.ConfigurationTests.d__33.MoveNext()

You can ignore that failure, its being investigated

@sgryphon Thanks for submitting this PR and sorry for taking so long to get to it. These look like good changes to make, but we have recently consolidated the configuration code into the https://github.com/aspnet/Extensions repo. Unfortunately, it is not trivial to move PRs over to another repo.  Since this PR seems complete we would be happy to copy it over and commit it, but you will not show up as the author in git. Alternately, if you recreate the PR on the new repo we will merge it there and you will be shown as the author.

This has now been merged in the Extensions repo: https://github.com/aspnet/Extensions/pull/603


Support google-style docstrings for enhanced IntelliSense

I'm very enjoy the support of PEP484, and also the support of sphinx style.
But I'm using google's style of docstring which looks like this
def func(a,b):
    """
    Args:
        a (int): The first parameter.
        b (int): The second parameter.

    Returns:
        int : return a+b
    """
    return a+b

It seems like vscode can not read param's type from this docstring and give me correct suggestion just like in pycharm. And since vscode-python support sphinx style, it is possible to support google style. It would be very helpful since google style is more popular.

I'm not quite sure what you mean by our "sphinx style" support, but this is something Jedi would need to support. We also encourage people to use type hints as that's more widely supported by tools now and is a standard.


Replace glide

As the documentation mentions, using Glide for dependency management is not recommended anymore as dep is available for some time now.
I would propose moving to dep or even better to Go modules (previously known as vgo) which are available since 1.11 release.

I would like to add a subtask to this:

[ ]  fix versioning to meet dep standards by removing  -rc tagging practice which prevents dep from getting latest version.

@luluzhao Are you going to skip dep support and skip to Go modules directly?

Hello @emirb , after reading Go package management tools wiki, I found out Go111Module became the "official experiment" which was "dep tool" before. Thanks for pointing out this and we are definitely going to mark Go modules as priority to solve glide issue. Please stay in tuned.

The SDK now supports dep and go modules as of V1.0.0-rc.11.
Removing the -rc tag will be a separate task once the SDK is no longer in a release candidate stage.


clarify override parameter usage with objects.

This one line is all there is on sending an object in for parameters.

To override object type parameters, use stringified JSON objects. For example, -options ["option1"] -map {"key1": "value1" }

It would be great to know how one should be stringifying objects to get the syntax above. I went with the pipeline convertToJson function ${{ convertToJson(overrideparams) }} but that results in this (no quotes) :
{
   apim_instance: demo-apim-dev
}

It appears that the syntax in the documentation may not work as written either - at least this stackoverflow question is unanswered (there is an answer but it doesn't recognize that the original poster appears to be sending in what the documentation says but gets an error about it being a string instead of an object...
Additonally, if there is a way to use an object containing all of the override parameters as an overrideparameter, could it be document edit, or document that it isn't possible? For clarification, using the object json above, the parameter to override would be apim_instance, and that object json would contain all the other parameters the receiving bicep is expecting, including object type parameters...
Thanks!
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 440723cb-b52a-84d1-8b22-19d87be27488
Version Independent ID: 440723cb-b52a-84d1-8b22-19d87be27488
Content: AzureResourceGroupDeployment@2 - Azure resource group deployment v2 task
Content Source: task-reference/azure-resource-group-deployment-v2.md
Service: azure-devops-pipelines
Sub-service: azure-devops-pipelines-tasks
GitHub Login: @steved0x
Microsoft Alias: sdanie

@housten -- thank you for your clear feedback.  Please consider this resource:

Azure DevOps Services

@steved0x -- please look into this issue.

Thank you for your feedback. We are migrating this issue to our new documentation feedback system, and closing this issue.
As we phase out GitHub issues for this repository, we encourage you to propose changes using public PRs or submit feedback through our updated control at the top of the page. For more information on our feedback systems, see https://aka.ms/contentuserfeedback.


Optimizer tests should be able to specify the environment easily

Optimizer tests assume SPIR-V 1.1 universal right now. We should be able to specify the environment to use.

This is now possible. See https://github.com/KhronosGroup/SPIRV-Tools/blob/43b8886490eb6af81fc61e0ff071c51a922af864/test/opt/aggressive_dead_code_elim_test.cpp#L6651


Coinconfig bugfix

Description

Coinconfig is a dictionary, so we need to make sure the keys match the expected keys. Those got mixed up in a recent commit when we renamed lent to lend in the MaxToLent feature.

Fixes #150

TESTING STAGE

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have read CONTRIBUTING.md
[x] I fully understand Github Flow.
[x] My code adheres to the code style of this project.
[N/A] I have updated the documentation in /docs if I have changed the config, arguments, logic in how the bot works, or anything that understandably needs a documentation change.
[N/A] I have updated the config file accordingly if my change requires a new configuration setting or changes an existing one.
[N/A] I have tested the bot with no issues for 24 continuous hours. If issues were experienced, they have been patched and tested again.

Closes #150

Lgtm


Using Emoticons as Identifiers ಠ_ಠ

JavaScript allows for UTF8 variable names which allows use of some emoticons and some people even use emoji as identifiers in languages like C++ #39
Good : -
var ಠ_ಠ = 2022
Bad : -
var year = 2022

Why not emoji？(if possible:)
Good：-
var 🔗 = “https://github.com/trekhleb/state-of-the-art-shitcode”
Bad: -
var link = “https://github.com/trekhleb/state-of-the-art-shitcode”


user node pool name can be configured

PR Summary
User node pool name should be customisable
PR Checklist

[x] PR has a meaningful title
[x] Summarized changes
[x] This PR is ready to merge and is not Work in Progress
[x] Link to a filed issue:
[x] Screenshot of UI changes (if PR includes UI changes)

As described in issue https://github.com/Azure/AKS-Construction/issues/461, user node pool is made configurable

In case of only system node pools, the parameter is not set.
If no value provided by user, it defaults to npuser01, the original string that was used

Logic looks good.
I'll fire up a couple of tests then we can merge.  Great PR 😀

@Gordonby one thing I am was not sure of is whether the text input field should be required (with the red asterik).
It's required unless only system node pool exists. It's currently always required. What's your thoughts?

I actually think we can lean into the system pool a little more.
In the scenario of just a system pool being deployed;

We relabel the textbox to "Node Pool Name"
We allow the system pool to also be renamed

Thoughts?

@Gordonby suggestions absolutely make sense. I have implemented, tested and committed those.
I just want to highlight the commenting out of code block startling line 50 in clusterTab.js. This was clearing vmSKU without any changes in compute type


Return error from JSON writer rather than panic

Which issue does this PR close?
Closes #1157.
Rationale for this change
Not panic in JSON write, just throw up error
What changes are included in this PR?

Are there any user-facing changes?

Codecov Report

Merging #1205 (77d7977) into master (4218c74) will increase coverage by 0.09%.
The diff coverage is 59.61%.

@@            Coverage Diff             @@
##           master    #1205      +/-   ##
==========================================
+ Coverage   82.57%   82.67%   +0.09%
==========================================
  Files         173      175       +2
  Lines       50713    51568     +855
==========================================
+ Hits        41875    42632     +757
- Misses       8838     8936      +98

Impacted Files
Coverage Δ

arrow/src/json/writer.rs
92.14% <59.61%> (-0.49%)
:arrow_down:

parquet/src/util/test_common/file_util.rs
75.00% <0.00%> (-18.11%)
:arrow_down:

parquet/src/arrow/arrow_array_reader.rs
73.66% <0.00%> (-5.59%)
:arrow_down:

parquet/src/arrow/converter.rs
64.34% <0.00%> (-5.22%)
:arrow_down:

...rquet/src/arrow/record_reader/definition_levels.rs
88.50% <0.00%> (-1.83%)
:arrow_down:

parquet/src/column/reader.rs
68.80% <0.00%> (-1.09%)
:arrow_down:

parquet/src/file/serialized_reader.rs
94.37% <0.00%> (-0.60%)
:arrow_down:

arrow/src/datatypes/datatype.rs
66.38% <0.00%> (-0.43%)
:arrow_down:

arrow/src/array/array_binary.rs
93.13% <0.00%> (-0.42%)
:arrow_down:

parquet/src/arrow/arrow_writer.rs
97.97% <0.00%> (-0.10%)
:arrow_down:

... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4218c74...77d7977. Read the comment docs.


Adding deploy switch to run seed.

@ivan-c can you please review?  This is needed to react on commits to the site-persistence repos, as mentioned: https://www.pivotaltracker.com/n/projects/1225464/stories/133316477

A lovely workaround! This is much better than having one handler for all those repos.


How can I launch a program with admin right (Windows) ?

[x] I am on the latest Cerebro.app version
[x] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name: windows 10
Cerebro.app version: 0.3.2
Relevant information from devtools: N/A

Issue
There are some program I'd like to launch with admin right, how can I do that in windows?

We have no solution for this at the moment, could give more details about these apps


where is OpenCL-CTS-cl12_trunk for OpenCL 1.2？

There is no such branch. All branch are merged to one master branch. Please run master on your OpenCL 1.2 device

Yes, testing 1.x implementations is now done using the master branch. Closing.


fix(loader): when reloading, clear plugin properties cache

See #445
Some options and properties of plugin was not reloaded after :Lazy reload <plugin>, because the old version was preserved in cache.

Good catch, missed that. Thanks!


Vim does not restore terminal cursor correctly

I am using Vim 8.0.559 on macOS 10.12.4 and iTerm 2 version 3.0.15. If I clear the terminal screen and enter and immediately exit vim, the terminal cursor is scrolled to the bottom of the terminal window with a screen full of empty lines.
I have managed to trace this down to the following change in runtime/defaults.vim
" When the +eval feature is missing, the set command above will be skipped.
" Use a trick to reset compatible only when the +eval feature is missing.
if 1
  nnoremap : :"
endif
silent normal :set nocompatible
if 1
  nunmap :
endif

If I comment these lines out in runtime/defaults.vim, everything is back to normal and when vim exits, the terminal cursor is returned on the next line after vim invocation.
My Vim version info:
VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Apr 10 2017 08:58:49)
MacOS X (unix) version
Included patches: 1-559
Compiled by Mario Grgic
Huge version with MacVim GUI.  Features included (+) or not (-):
+acl             +cursorbind      +fullscreen      +modify_fname    +path_extra      +syntax          +viminfo
+arabic          +cursorshape     -gettext         +mouse           +perl            +tag_binary      +vreplace
+autocmd         +dialog_con_gui  -hangul_input    +mouseshape      +persistent_undo +tag_old_static  +wildignore
+balloon_eval    +diff            +iconv           +mouse_dec       +postscript      -tag_any_white   +wildmenu
+browse          +digraphs        +insert_expand   -mouse_gpm       +printer         -tcl             +windows
++builtin_terms  +dnd             +job             -mouse_jsbterm   +profile         +termguicolors   +writebackup
+byte_offset     -ebcdic          +jumplist        +mouse_netterm   +python/dyn      +terminfo        -X11
+channel         +emacs_tags      +keymap          +mouse_sgr       +python3/dyn     +termresponse    -xfontset
+cindent         +eval            +lambda          -mouse_sysmouse  +quickfix        +textobjects     +xim
+clientserver    +ex_extra        +langmap         +mouse_urxvt     +reltime         +timers          -xpm
+clipboard       +extra_search    +libcall         +mouse_xterm     +rightleft       +title           -xsmp
+cmdline_compl   +farsi           +linebreak       +multi_byte      +ruby            +toolbar         -xterm_clipboard
+cmdline_hist    +file_in_path    +lispindent      +multi_lang      +scrollbind      +transparency    -xterm_save
+cmdline_info    +find_in_path    +listcmds        -mzscheme        +signs           +user_commands
+comments        +float           +localmap        +netbeans_intg   +smartindent     +vertsplit
+conceal         +folding         -lua             +num64           +startuptime     +virtualedit
+cryptv          -footer          +menu            +odbeditor       +statusline      +visual
+cscope          +fork()          +mksession       +packages        -sun_workshop    +visualextra
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
  system gvimrc file: "$VIM/gvimrc"
    user gvimrc file: "$HOME/.gvimrc"
2nd user gvimrc file: "~/.vim/gvimrc"
       defaults file: "$VIMRUNTIME/defaults.vim"
    system menu file: "$VIMRUNTIME/menu.vim"
  fall-back for $VIM: "/Applications/MacVim.app/Contents/Resources/vim"
Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_MACVIM -Wall -Wno-unknown-pragmas -pipe  -DMACOS_X_UNIX  -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: gcc   -L. -L/usr/local/lib -L. -L/usr/local/lib  -L/usr/local/lib -o Vim -framework Cocoa -framework Carbon       -lm -lncurses  -liconv -framework Cocoa   -fstack-protector  -L/System/Library/Perl/5.18/darwin-thread-multi-2level/CORE -lperl    -framework Ruby

I cannot reproduce in neither putty nor gnome-terminal.
What does this output: :set term? t_ti? t_te?

This is what I got as output:
term=xterm-256color
t_ti=^[[?1049h
t_te=^[[?1049l

sorry, scratch that, I just could successfully reproduce this.

It's the :silent command modifier, that breaks it. I think it happens because internally, Vim goes to the last line and echoes the (commented out command).

How about the following hack:
diff --git a/runtime/defaults.vim b/runtime/defaults.vim
index f4d22bde4..83da2d9be 100644
--- a/runtime/defaults.vim
+++ b/runtime/defaults.vim
@@ -28,13 +28,9 @@ endif

 " When the +eval feature is missing, the set command above will be skipped.
 " Use a trick to reset compatible only when the +eval feature is missing.
-if 1
-  nnoremap : :"
-endif
-silent normal :set nocompatible
-if 1
-  nunmap :
-endif
+silent! while 0
+set nocompatible
+silent! endwhile

 " Allow backspacing over everything in insert mode.
 set backspace=indent,eol,start

This works for a huge and small build. However, this looks hacky, perhaps my previous mentioned solution is better suited?

The above patch works, however I can't comment if it is the best or most elegant way to set nocompatible if eval is not present.

Christian Brabandt wrote:

How about the following hack:
diff --git a/runtime/defaults.vim b/runtime/defaults.vim
index f4d22bde4..83da2d9be 100644
--- a/runtime/defaults.vim
+++ b/runtime/defaults.vim
@@ -28,13 +28,9 @@ endif

 " When the +eval feature is missing, the set command above will be skipped.
 " Use a trick to reset compatible only when the +eval feature is missing.
-if 1
-  nnoremap : :"
-endif
-silent normal :set nocompatible
-if 1
-  nunmap :
-endif
+silent! while 0
+set nocompatible
+silent! endwhile

 " Allow backspacing over everything in insert mode.
 set backspace=indent,eol,start

This works for a huge and small build. However, this looks hacky, perhaps my previous mentioned solution is better suited?

It appears to work.  I wonder if ignoring the error has any side effect.
Nothing comes to mind.
--
You were lucky to have a LAKE! There were a hundred and sixty of
us living in a small shoebox in the middle of the road.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Are :while and :endwhile just ignored in a small build? If so, isn't it enough to use :while 0?
while 0
set nocompatible
endwhile

This will throw an error on small and tiny builds, as they do not understand the :while|:endwhile commands. Therefore I silenced those errors with :silent!

I tried with v8.0.0525 small build on Cygwin, and neither :while nor :endwhile throws errors.
It seems that they are silently ignored.

Oh really? I see this:
Error detected while processing /home/chrisbra/local/share/vim/vim80/defaults.vim:
line   31:
E319: Sorry, the command is not available in this version: while 0
line   33:
E319: Sorry, the command is not available in this version: endwhile
Press ENTER or type command to continue

This is:
:version
VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Apr 10 2017 21:37:18)
Included patches: 1-559
Compiled by chrisbra@debian
Small version without GUI.  Features included (+) or not (-):
[...]

Hmm, E319 is set at here: https://github.com/vim/vim/blob/ea588154d00aec288e48b344b2685e46bea99cd6/src/ex_docmd.c#L4807
And ex_while is defined to ex_ni when '-eval': https://github.com/vim/vim/blob/ea588154d00aec288e48b344b2685e46bea99cd6/src/ex_docmd.c#L376
Then, someone set eap->skip to TRUE in my environment?

well, perhaps it would be a general good idea to set ea->skip=TRUE for non-eval builds, so that one can use:
while 0
" do something only in non-eval builds
endwhile

Christian Brabandt wrote:

well, perhaps it would be a general good idea to set ea->skip=TRUE for non-eval builds, so that one can use:
while 0
" do something only in non-eval builds
endwhile

This may lead to surprises if the user expects an error message in the
tiny version.  The script may do something weird without any hint why.
--
Not too long ago, cut and paste was done with scissors and glue...
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

alternatively use
if 0
" do something in tiny mode
endif

That would be symmetric to the current if 1 trick and that one is widely used already.
I don't even know if the if 1 trick, is currently documented.
BTW: I don't think anybody would rely or expect an error message in that case in the small or tiny builds (but the part between the while/endwhile would already be evaluated).

Christian Brabandt wrote:

alternatively use
if 0
" do something in tiny mode
endif

That would be symmetric to the current if 1 trick and that one is
widely used already.  I don't even know if the if 1 trick, is
currently documented.

This is documented:
From Vim version 4.5 until 5.0, every Ex command in
between the ":if" and ":endif" is ignored.  These two
commands were just to allow for future expansions in a
backward compatible way.  Nesting was allowed.  Note
that any ":else" or ":elseif" was ignored, the "else"
part was not executed either.

Also see :help no-eval-feature

BTW: I don't think anybody would rely or expect an error message in
that case in the small or tiny builds (but the part between the
while/endwhile would already be evaluated).

--
Apologies for taking up the bandwidth with the apology.  Anything else I
can apologise for ...... er no can't think of anything, sorry about that.
Andy Hunt (Member of British Olympic Apology Squad)
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///


Do we have a docker image versiond 1.9.6 and architecture is arm64

Do we have a docker image versiond 1.9.6 and architecture is arm64

triggered https://github.com/querycap/istio/actions/runs/1011065911
envoy need to compiling more that 1h30min.
I haven't use 1.9.x any more.
if next fixed version you need, please PR to release-1.9 to upgrade here only
https://github.com/querycap/istio/blob/release-1.9/build/istio/Dockerfile.version#L1

pushed