[v1.3.2][vai_c_caffe] Pinned glog=0.4.0 to avoid undefined symbol error.

As seen in #512, undefined symbols occur in vai_c_caffe if glog version 0.5.0 is installed. glog has been pinned to 0.4.0 to avoid this issue.
I'm not sure if this needs to be applied to the other conda environments, or other versions of vitis-ai. Help is requested to check this.

Thank you for your contribution!
The glog dependency was fixed in Vitis AI 1.4 onwards.


New entity Vote

Create a new entity called vote to store the necessary data for every single vote.

Solved and finished


image field  in acorn app for nested acorns and services always point to image id even when they are deployed from remote images from external registry. Remote Image entries are also not created.

Acorn version - acorn version v0.7.0-38-gdc95c02b+dc95c02b
Steps to reproduce the problem:

Deploy app using services from images hosted in external registry.

containers: {
  nginx: {
    image: "nginx"
    env: {
     "NAME"<EMAIL_ADDRESS>     "PASSWORD"<EMAIL_ADDRESS>}
}
}
services: {
     mysec: {
        image: "docker.io/sangeetha/myfirstservice:v0.0.1"
        }
}

After app deploys successfully, notice that the image in acorn app shows a imageId.
acorn apps
NAME                  IMAGE          HEALTHY   UP-TO-DATE   CREATED     ENDPOINTS   MESSAGE
mytestservice         a03c0062ae4b   1         1            9m45s ago               OK
mytestservice.mysec   2b590937796e   0         0            9m45s ago               OK

Expected Behavior:
Image should be docker.io/sangeetha/myfirstservice:v0.0.1 instead of id

Deploy nested acorn using images hosted in external registry.

acorns: {
    "my-acorn2": {
        image: "docker.io/sangeetha/myfirstacorn:v0.0.2"
    }
}

After app deploys successfully, notice that the image in acorn app shows a imageId.
acorn apps
NAME                  IMAGE          HEALTHY   UP-TO-DATE   CREATED     ENDPOINTS                                                                            MESSAGE
mynested              d420be4c96df   0         0            3m27s ago                                                                                OK
mynested.my-acorn2    a381c7951b3d   1         1            3m27s ago   http://myweb1-mynested-my-acorn2-e5efce26-88f3c3c5.local.oss-acorn.io => myweb1:80   OK

Expected Behavior:
Image should be docker.io/sangeetha/myfirstacorn:v0.0.2 instead of id
Note - In both the the above cases acorn images does not list the remote images entries.

Image should be docker.io/sangeetha/myfirstservice:v0.0.1 instead of id

@ibuildthecloud said "Because at build time the nested acorn name become as hash.  It's basically a UX bug that we never show the name again, but we do have that information."
That doesnt exactly mean that that field cannot be a digest.

So, I think the result of our discussion is that this is intended behavior, right @g-linville @sangee2004 ?

In this case , we still wanted UX to be fixed so that the image field for acorn apps returns the remote image ?

yes, we should fix the UX.  I suppose we can use this issue to track that.

I have updated the title of the bug to reflect the UX part of the issue which is what it actually described in the bug report as well.

Fixed, moving to QA.

Tested with acorn version v0.8.0-alpha7-98-gbb130866+bb130866
I still see image field in acorn app show image id instead of the remote image from external registry.

This is fixed on Dev now.

Tested on local clusters using acorn version - acorn version v0.8.0-alpha7-131-g4bf05b4d+4bf05b4d
Deployed nested acorn app with following Acornfile:
acorns: {
    "my-acorn1": {
        image: "ghcr.io/acorn-io/library/hello-world:latest"
    }
    "my-acorn2": {
        image: "docker.io/sangeetha/myfirstacorn:v#.#.#"
        autoUpgrade: true
        autoUpgradeInterval: "15s"
    }
   "my-acorn3": {
       image: "docker.io/sangeetha/myfirstacorn:v0.0.1"
   }
}

image field shows the images from external registry as expected for my-acorn1 and my-acorn3.
For my-acorn2 which is deployed with autoupgrade format , image shows the image with autoupgrade format instead of showing the actual image with which the app was deployed.
acorn apps
NAME                      IMAGE                                            DIGEST         HEALTHY   UP-TO-DATE   CREATED     ENDPOINTS                                                                                MESSAGE
mynestedacorn             5e25f036e64f                                     5e25f036e64f   0         0            4m25s ago                                                                                OK
mynestedacorn.my-acorn1   ghcr.io/acorn-io/library/hello-world:latest      693234be0d3d   1         1            4m25s ago   http://webapp-mynestedacorn-my-acorn1-7f8f0c42-0231e1fe.local.oss-acorn.io => webapp:80                  OK
mynestedacorn.my-acorn2   docker.io/sangeetha/myfirstacorn:v#.#.#          a79413cf182f   1         1            4m25s ago   http://myweb1-mynestedacorn-my-acorn2-453e996f-d3456055.local.oss-acorn.io => myweb1:80                  OK
mynestedacorn.my-acorn3   docker.io/sangeetha/myfirstacorn:v0.0.1          f4ddb1bac222   2         2            4m25s ago   http://myweb1-mynestedacorn-my-acorn3-ff33c584-90b00b56.local.oss-acorn.io => myweb1:80                  OK

Reopening to get this issue addressed.

Fix merged to main.

acorn version  - v0.8.0-alpha7-133-ge68fb042+e68fb042
Image field shows the exact image tag with which the app was deployed when deploying nested acorn apps in autoupgrade format.
When app is deployed with Acornfile mentioned in https://github.com/acorn-io/runtime/issues/1774#issuecomment-1643030444
mytestnew.my-acorn2   index.docker.io/sangeetha/myfirstacorn:v37.0.0   a79413cf182f   1         1            9s ago    http://myweb1-mytestnew-my-acorn2-777aa612-f54f17b7.local.oss-acorn.io => myweb1:80   OK


Vendor FindThreads.cmake from CMake 3.14-rc2.

In order to resolve linking issues that appear when running Fast-RTPS with ASan 1 due to the asan library providing the symbol whose absense is being used as a test for the need to link pthreads.
This CMake pull request 2 addresses the issue by using a different function as the heuristic and has been accepted upstream as part of the 3.14-rc2 release.
This commit drops the version of FindThreads.cmake from that release into the local CMake modules directory where it should take precedence over the system-provided one.
This file can be removed when the cmake_minimum_required version is 3.14 or newer as the system version should be sufficient.
It would be nice to modify this module to print a warning when it is no longer needed. I tried to find a means to check the minimum version rather than the current cmake version but didn't come up with a way to do so. Issuing a warning a warning on the current cmake version doesn't make sense because it would nag users on rolling systems to make a change incompatible with an older stable system.
Fixes eProsima/Fast-RTPS#430

Build status:

Linux
Mac
Windows

I'm super weirded out by the fact that the mac build passed. Although I suppose it must be because the specific block wasn't used.
The other references to CMAKE_CURRENT_LIST_DIR are
81:        set(_threads_src ${CMAKE_CURRENT_LIST_DIR}/CheckForPthreads.c)
84:        configure_file(${CMAKE_CURRENT_LIST_DIR}/CheckForPthreads.c "${_threads_src}" COPYONLY)

I didn't vendor that file and was able to build locally without it. But I haven't decided if it makes more sense to vendor them or not.

Build status:

Linux
Mac
Windows

I can confirm that this change is working well with the address sanitizer use case and there is no need to pass any pthread flag in the asan mixin now.

The other references to CMAKE_CURRENT_LIST_DIR are
81:        set(_threads_src ${CMAKE_CURRENT_LIST_DIR}/CheckForPthreads.c)
84:        configure_file(${CMAKE_CURRENT_LIST_DIR}/CheckForPthreads.c "${_threads_src}" COPYONLY)

I didn't vendor that file and was able to build locally without it. But I haven't decided if it makes more sense to vendor them or not.

As far as I understand, that piece of block is executed when failed to find pthread symbols in header files and the library libpthread. In this case it tries to check if the compiler has a -pthread flag. I don't know which systems or compilers need this, but I think it is better to vendor the file to avoid a future error.

I think it is better to vendor the file to avoid a future error.

Added in 7276aeb.

Build status:

Linux
Mac
Windows


fix(Geosuggest): Hide the suggest list when the result set is empty

This fixes a small design bug which was visible when removing focus from the search box while the result set was empty.

🏁


Postgis 2.4

http://postgis.net/2017/09/02/postgis-2.4.0beta1/
Would 3661, Mapbox vector tile output support via ST_AsMVT (Björn Harrtell / Carto) help in this project?

@skinkie I have been watching ST_AsMVT but leveraging it opens up several things to consider:

We would still need to support our current approach for PostGIS versions pre 2.4 so now we have two implementations to manage.
From what I can tell, ST_AsMVT returns an encoded tile rather than a layer. Tegola is designed to support multiple data providers so our MVTProvider interface expects back mvt.Layer types rather than mvt.Tile types. This allows tegola to mash up layers from various providers. If we used ST_AsMVT we would need to decode the response from PostGIS to extract the mvt.Layer before passing up the stack.
I think the feature tag approach ST_AsMVT has chosen will take some time to adopt with the rest of the ecosystem tooling.

Near term we don't have any plans on leveraging ST_AsMVT but we're going to keep watching it.


[$1000] [HOLD for payment 2023-03-01] Expensify app icon looks different

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

install the app
verify the logo

Expected Result:
There should be no white background
Actual Result:
Has white background
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native

Version Number:
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Galaxy S9

Nexus 5X

Expensify/Expensify Issue URL:
Issue reported by: @mdneyazahmad
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1673504229478519
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e365dc943aaf476b
Upwork Job ID:<PHONE_NUMBER>118538752
Last Price Increase: 2023-03-01

I can't reproduce. Tried on Galaxy S9. Discussing here.

I have a good idea of how to fix this, and can reproduce on my Pixel 2A.

Sounds good!

Next step here is to begin PR.

I believe next step here is to begin the fix, is that right @Julesssss ?

Hey, I've been OOO. Yep, I'll get this done soon.

Sounds good, no rush. Thanks for confirming!

Next step here is PR.

@Julesssss @rushatgabhane @joekaufmanexpensify this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

@Julesssss do you think you'll be able to start the PR here soon?

@Julesssss do you think you'll be able to start the PR here soon?

Yep. Honestly I don't think this is a true WhatsApp quality blocker, but I will pick this up imminently.

Got it, sounds good. Thanks!

Not overdue.

Next step is PR this week!

Same.

Requested the necessary assets here. Once this issue is complete I can create the Android icon correctly.

PR in review

@Julesssss, @rushatgabhane, @joekaufmanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Hm, this isn't overdue? PR is out on staging as of yesterday.

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.75-0 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/15177

If no regressions arise, payment will be issued on 2023-03-01. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

📣 @MelvinBot! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@rushatgabhane / @Julesssss] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@rushatgabhane / @Julesssss] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@rushatgabhane / @Julesssss] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@rushatgabhane] Propose regression test steps to ensure the same bug will not reach production again.
[ ] [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Not a regression, no test needed.

Closing as it's been deployed to production

I think, I am eligible for reporting bonus here. Thanks!

Oh yeah, thanks for reminding me 😬
@joekaufmanexpensify would you please pay out the reporting bonus. Thanks!

All set to issue payment here. Upwork job is closed, so temp adding external label to create new upwork job.

Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

Current assignee @rushatgabhane is eligible for the External assigner, not assigning anyone new.

Current assignee @Julesssss is eligible for the External assigner, not assigning anyone new.

Current assignee @rushatgabhane is eligible for the Internal assigner, not assigning anyone new.

Hm, that didn't create a new job in Upwork, so I manually created one!

@rushatgabhane offer sent for $1000!

@mdneyazahmad offer sent for $250!

@mdneyazahmad $250 paid and contract ended!

@rushatgabhane $1000 paid and contract ended!

Upwork job closed.

Bug is fixed, and payment sent. This is all set. Thanks everyone!


Explore using mentionbot to identify potential reviewers

This can be useful in identifying reviewers for PRs
https://github.com/facebook/mention-bot

Conclusion: Seems to be useful. Decided to adopt.


Fix import in chat-members typescript example

Since grammY 1.10.0, types are exported from the core package, and installing @grammyjs/types is no longer required.


docs: Add deployment section to readme

This PR adds a deployment section to reference developer information about docker and snap packaging.
The idea is to have a similar README section across all device/app service repos.
In addition, it bumps the docs version to 2.1.

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-mqtt-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:

[x] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
[x] I am not introducing a new dependency (add notes below if you are)
[ ] I have added unit tests for the new feature or bug fix (if not, why?)
[ ] I have fully tested (add details below) this the new feature or bug fix (if not, why?)
[ ] I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@lenny-intel @tonyespy @siggiskulason please review.


update react and add proptypes as dependency

since React 15.5 PropTypes has been moved into its own library.
https://reactjs.org/docs/typechecking-with-proptypes.html
I'm trying to use this plugin with React v.16.0 and it's incompatible.

I am also having this problem - it would be good to get a fix because it's a great idea.

I am planning to fix this as parte of v2. There is a branch where I am working on it.

@alexandraclaire @phoebeschmidt v2 is on!
Now it supports both react 15 and 16.
Thank you!


feat(minifier): terser drop_unused

https://github.com/terser/terser/blob/master/lib/compress/drop-unused.js

I have a working version here: https://github.com/Boshen/oxc/compare/drop-unused?expand=1
But I'm currently struggling with var hoisting right now


What is the evaluation code bug?

Hi,
I notice that you update the README and said there is an evaluation code bug. Could you plz give more information about this?

Hi, I have updated the evaluation code. The pascal_ids were not indexed correctly. The problem is fixed now. But, we made another little update in the evaluation protocol in our new paper. So, we will further update the evaluation part soon.

Well, that would be a problem. Then I suppose the performance would be reduced. Could you plz share the updated paper?Many thanks.

By the way, I also wonder how to evaluate the ALL metrics shown in Table 1 and Table 8?

It seems that `eval_obj365' is not used by the evaluation code. Would you please check this part? https://github.com/ksaito-ut/openworld_ldet/blob/0e5a991eb169779940ec24fd04ef3af6b9c14b5f/ldet/evaluation/coco_evaluation.py#L175


Fixing Kglab empty cell

Closes #261
Just erasing tutorial 3 last empty cell.

could you please resolve branch conflicts ? For notebooks, it should be better apply changes from master branch instead of trying merge.


steemtools.cf down?

When i call the steemtools.cf urls i get :
Account Suspended
This Account has been suspended.

Sorry,
I didn't renew the hosting.

no need to be sorry , anything is fine ! it was just an info


[POC] process raw dogstatsd samples directly in the aggregator

What does this PR do?

Send raw dogstatsd.MetricSamples to the aggregator

Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?

See RFC


Unable to unzip when Experimental unzip is checked

Describe the bug
I found I met some problem installing Xcode when Experimental unzip is checked, it will hang at unzip stage forever, I think I start to get this problem since 2 versions early.
But when I unchecked the Experimental unzip, everything works fine.
To Reproduce
It just happens in my Mac, and I didn't see any similar issue in this repo.
Expected behavior
Should unzip when Experimental unzip is checked.
Version

OS: 12.4 (21F79)
Xcodes: 1.6.0(14)

Hey @devlinlin
Sorry to hear about this. just tested on newest 1.6.0 and it seems to be working. The code for unxip is on https://github.com/saagarjha/unxip so if you can try and duplicate manually from the steps there and it still doesn't work, perhaps a bug on that repo. If it works there, let me know.
Thanks


Adding hf_key_prefix to the backbone

I have noticed that some model key names have a prefix that breaks model porting.
If one goes to distill-gpt2 they will find the prefix transformer. The simple prefix will break the model porting code.
In this PR I have made the hf_key_prefix a globab parameter which can be used to set the prefix while model loading.
An example would be
import keras_nlp

model = keras_nlp.models.GPT2CausalLM.from_preset(
    "hf://distilbert/distilgpt2",
    hf_key_prefix="transformer",
)

print(model.generate(["what is"], max_length=15))

model = keras_nlp.models.GPT2CausalLM.from_preset(
    "hf://Gustavosta/MagicPrompt-Stable-Diffusion",
    hf_key_prefix="transformer",
)

print(model.generate(["landscape of"], max_length=15))

This works too!

Wow, nice catch. Tested in local and it works perfectly fine.


Implement two new methods for unit testing of relevance

Specs and CTS tests
Go client base implementation

search().then(res => res.hits.findIndex(({ objectID }) => objectID === 'whatever')

Note that the response object has no functions now, so I don't think this belongs in the JS client

@Haroenv agree about the easy way of doing it, but since it's a change which was requested for all API clients, we will implement it nevertheless. Same in C# for the record, the syntax is really short to do that but again, we want to stay ISO between all our clients.
I'm closing this one as it's indeed something we will want to have once @nunomaduro will have typed the response, I understand it's not possible at the moment (I've opened the ticket too fast). Thanks for noticing.


Sortable always rejects dragged item.

The easiest way to see this issue visually, is to open sortable-simple example in Firefox. It looks like this:

Note the revert animation: element moves back to its initial position, which is quite annoying.
Deeper problem is that, it seems, there's no way to make sortable distinguish success drops vs. failed ones (e.g. when moved outside the list area).
I think it happens because we modify model as we drag item around, so we always end dropping item on itself, which causes drop rejection. Any suggestions on how to overcome this would be very helpful!
Thanks!

Note the revert animation: element moves back to its initial position, which is quite annoying.

There is actually special code to cancel the animation if the source node position has changed, but it is currently only enabled for Webkit. I'll take a look whether it's easy to apply the same fix for FF.

Deeper problem is that, it seems, there's no way to make sortable distinguish success drops vs. failed ones (e.g. when moved outside the list area).

You're right. The reason it happens is because, currently, we don't consider dropping item on itself a successful drop. This is a technical limitation and will be removed in the next version. In fact, you shouldn't see this behavior in Firefox in dnd-core branch (this is the next version).
The ETA for next version release is first week of May.

I'm closing the issue. It is fixed in v1.0.0-alpha which is available on NPM.
The final 1.0 release is coming in a week or so.


Fix infinite loop when calculating zoom level if tile_size * max_zoom < default

Fixes https://github.com/godotengine/godot/issues/86496

I made some modifications to the code as I noticed some potential issues, especially regarding zoom limits. Below, I describe the main ones:
Points of Divergence:

Consideration of Zoom Limits:

Changes in this PR: It does not explicitly consider the maximum and minimum zoom limits during the zoom adjustment loops.
My changes: Implement precise checks for the maximum and minimum zoom limits, avoiding infinite loops and ensuring that the zoom does not exceed these limits.

Zoom Adjustment Logic:

Changes in this PR: It uses loops to increase or decrease the zoom until reaching the desired tile size, without explicitly considering the zoom limits.
My changes: Considers whether the tile size multiplied by the maximum zoom is smaller than the desired size. It uses loops only when necessary, with checks for the zoom limits.

Handling Extreme Conditions:

Changes in this PR: It does not explicitly address scenarios where the original tile size multiplied by the maximum zoom is smaller than the desired size.
My changes: Specifically handles these extreme conditions, ensuring proper zoom adjustment even in situations where the initial tile size multiplied by the maximum zoom is smaller than the desired size.

My Code - I tested it locally and it worked without any apparent errors:
// Set the default zoom value.
int default_control_y_size = 200 * EDSCALE;

float target_tile_size = default_control_y_size / editor_zoom_widget->get_zoom();
Vector2 original_tile_size = tile_set->get_tile_size();
Vector2 current_tile_size = original_tile_size * editor_zoom_widget->get_zoom();

// Checks if the multiplication of the tile size by the maximum zoom is less than the default size
if (original_tile_size.y * editor_zoom_widget->get_max_zoom() < default_control_y_size) {
  // Adjusts the zoom to the maximum possible without exceeding the desired standard size
  float new_zoom = editor_zoom_widget->get_zoom() * (default_control_y_size / (original_tile_size.y * editor_zoom_widget->get_max_zoom()));
  if (new_zoom >= editor_zoom_widget->get_max_zoom()) {
  	editor_zoom_widget->set_zoom(editor_zoom_widget->get_max_zoom());
  } else {
  	editor_zoom_widget->set_zoom(new_zoom);
  }
} else {
  // Checks if the current tile size is smaller or larger than the desired size
  if (current_tile_size.y < target_tile_size) {
  	while (current_tile_size.y < target_tile_size && editor_zoom_widget->get_zoom() < editor_zoom_widget->get_max_zoom()) {
  		editor_zoom_widget->set_zoom(editor_zoom_widget->get_zoom() * 1.1);
  		current_tile_size = original_tile_size * editor_zoom_widget->get_zoom();
  	}
  } else if (current_tile_size.y > target_tile_size) {
  	while (current_tile_size.y > target_tile_size && editor_zoom_widget->get_zoom() > editor_zoom_widget->get_min_zoom()) {
  		editor_zoom_widget->set_zoom(editor_zoom_widget->get_zoom() * 0.9);
  		current_tile_size = original_tile_size * editor_zoom_widget->get_zoom();
  	}
  }
}

_zoom_changed();

I'm not sure if the issues I've highlighted are really important to emphasize, but I made that comment just in case and to check for problems.
This is my first time commenting on an open-source project, so I hope I haven't done anything strange or wrong. Have a great day!

@VetusScientia Thank you very much for your suggestion, invaluable.
I guess we can ask for some advice from @groud since he is the author of this code.
Also, feel free to take my pr and work based on it.

Alright, sorry for the late review, and thanks for the contribution.
While @VetusScientia's one is, like, more "correct", it would add a lot of LoC for limited gains IMO. I think the approach by @jsjtxietian is the simplest one. I think the current state of the PR is acceptable.

You did perfectly fine ! :)

Thank you very much, @ground! I'm still studying Godot's source code, meaning I'm still a noob :smile:

While @VetusScientia's one is, like, more "correct", it would add a lot of LoC for limited gains IMO.

But the current state of the PR is indeed simpler and works well. I hope to be able to contribute better in the future!
Have a great day!

Thanks!

Cherry-picked for 4.2.2.


parallel spawning of resources on cloud

Hey @alexandruanghel,
As per the current implementation, spawning of resources on any cloud platform is sequential where a resources is spawned and checked for the SSH service to be UP and only then next resource is spawned.
I understand it is a check before next resource is spawned but it makes the overall system slow in case there are around 100 nodes in a cluster. The time required to complete the spawning process is linear with the number of VMs.
Can we break that or have a separate mechanism where the list of the spawned instance is maintained and periodically SSH service is being checked? This way resources can be spawned in parallel.  Failures can be notified in the same way as they are today to the user.
Your comments on this?

Hi @abh23
I assume you're referring to AWS? This was done as per docs: https://docs.ansible.com/ansible/latest/modules/ec2_module.html#ec2-module
Setting wait doesn't wait for SSH to start so the scripts would fail if you try to install the cluster immediately after.
Other clouds do this better.
Then in all clouds, nodes built in the same host_group are built in parallel. So if you build 100 nodes under the hdp-workers host group, it will build them in parallel. This is provided by the ansible module for that cloud.

I'm sure it's possible to build host_groups in parallel but that might make the playbooks too complicated for a little gain in node build speed.
The main focus and goal on these playbooks is the cluster build, cloud nodes build is very rudimentary and as basic as possible to give a quick start, but I don't expect these to be used in production without changes. Many use anyway Terraform for nodes builds...


Troubleshooting: Provide concise troubleshooting guidelines

Problem
When encountering troubles with CrateDB database clusters, for example by observing any anomalies, there is no clear and complete information publicly available about the whole procedure to find out about potential root causes and whatnot.
Solution
With optional tool support, let's improve corresponding documentation on this matter. This patch makes a start on it, and invites you to contribute and collaborate. Feel free to add patches, or share any suggestions which come to mind as we go.
Preview
Before vs. after.
/cc @karynzv, @hlcianfagna, @hammerhead, @mkleen, @surister, @seut, @proddata, @simonprickett

More details within the SQL statements on the system-tables page had to be fixed. Thanks! 30c894d98033b9b18 now has all of them.


Basic support for IN and NOT IN Subqueries by rewriting them to SEMI / ANTI

Which issue does this PR close?

Partially #488.
Rationale for this change

Naive implementation of optimizer rule for replacing InSubquery with join, which allows to execute queries with IN (subquery) in case of proper WHERE condition.
What changes are included in this PR?

SubqueryFilterToJoin rule is able to replace Filter input in logical plan with Sem/AntiJoin in case InSubquery is a part of logical conjunction - this precondition allows to pushdown IN predicate before other predicates in Filter.
Cases when IN (subquery) cannot be pushed to Filters input due to its result being required for predicate evaluation, are handled by returning NotImplemented error for now.
Are there any user-facing changes?

Queries with IN (subquery) predicates start executing for described above filter combinations

Thanks for reviews! I hope I'll follow up with PR(s?) for currently unsupported cases soon.


Audit for immediate effect of settings

Ensure immediate effect for settings: cmakeCommunicationMode, generator and preferredGenerators.
More to be investigated and eventually fixed in a following commit.
Also reverted https://github.com/microsoft/vscode-cmake-tools/pull/1417 since we need to fix it in a different way.
Opened https://github.com/microsoft/vscode-cmake-tools/issues/1498 to track the alternative fix of the above PR.

There's something really weird with this branch.  It has all of the CMake GUI stuff in it.  Can you start over with a fresh branch off of develop and copy in your last commit?


Updates port constants based on r6 board.

I've made some assumptions about what the new port names will be. Hopefully they line up with what you're planning to do with the Arduino library.

All pins verified against the schematic, LGTM.


Project and testing systems

I want to move our main program to folder Project and tests to Project.Tests as in this repository

I have used this command to create test package: dotnet new xunit -o Program.Tests from this documentation

Well, if it'll work, then go ahead!


Usage with Metro Bundler on Expo v47 SDK Running Web Doesn’t Work as Expected or Lacks Documentation

Description
When using react-native-skia on web with the metro bundler (instead of the webpack). The following error arises: The package at "node_modules/canvaskit-wasm/bin/full/canvaskit.js" attempted to import the Node standard library module "path”.
There seems to be a note in the web setup documentation about adding resolves for fs and path. Maybe there could be an documentation step for using metro?
Version
0.1.157
Steps to reproduce

Clone: https://github.com/EvanBacon/expo-skia-demo.git
Set expo.web.bundler equal to metro in app.json
Run node copy-canvaskit-wasm.js public
Run: yarn && expo upgrade && yarn web

Snack, code example, screenshot, or link to a repository
https://github.com/EvanBacon/expo-skia-demo.git

If you look at these steps there are agnostic to webpack: https://shopify.github.io/react-native-skia/docs/getting-started/web#manual-webpack-installation
You need to:

Make sure that the web assembly file is available
That the fs and path module are polyfilled

How to achieve these steps will be depend of your build configuration.

If you look at these steps there are agnostic to webpack: https://shopify.github.io/react-native-skia/docs/getting-started/web#manual-webpack-installation
You need to:

Make sure that the web assembly file is available
That the fs and path module are polyfilled

How to achieve these steps will be depend of your build configuration.

Thanks appreciate the feedback.
That the fs and path module are polyfilled
This seems to be the biggest issue for me. I think that documentation around this would be super helpful if possible. It’s totally understandable if that out-of-scope as well, but that is where I’m running into the most trouble and where it’s not working with an unmodified expo metro bundler config where webpack does seem to work w/o any additional steps.

here are some modules used by webpack for polyfill: https://github.com/Richienb/node-polyfill-webpack-plugin/blob/main/package.json#L40
So maybe just the path polyfill is enough for you hopefully?

I ended up solving it by using the CDN to load Skia in custom load skia component that doesn’t import the react native web skia library directly.

I am not 100% sure what I did but it seems to work. I use expo and the default metro bundler.
install fs and path react-native replacements
$ yarn add react-native-level-fs
$ yarn add path-browserify

Instruct the builder to use these libraries for fs and path in package.json:
"dependencies": {
   ...
   "fs": "react-native-level-fs",
   "path": "path-browserify",
   "path-browserify": "^1.0.1", // this comes from the yarn add
   "react-native-level-fs": "^3.0.1", // this comes from the yarn add
   ...
}

I'm not sure what actually happens and how metro bundles things but it gets rid of error messages for me.

I am not 100% sure what I did but it seems to work. I use expo and the default metro bundler.
install fs and path react-native replacements
$ yarn add react-native-level-fs
$ yarn add path-browserify

Instruct the builder to use these libraries for fs and path in package.json:
"dependencies": {
   ...
   "fs": "react-native-level-fs",
   "path": "path-browserify",
   "path-browserify": "^1.0.1", // this comes from the yarn add
   "react-native-level-fs": "^3.0.1", // this comes from the yarn add
   ...
}

I'm not sure what actually happens and how metro bundles things but it gets rid of error messages for me.

Anyone have a example of using the expo/webpack-config createExpoWebpackConfig? Similar to what we have on Reanimated2?

fix: https://github.com/Shopify/react-native-skia/issues/1448#issuecomment-1537467040


SwiftUI Menu regression with iOS 15.4

Describe the bug
There was a regression in iOS 15.4 that causes SwiftUI Menu views to not be rendered in image snapshots. I'm not sure if this is due to a bug in SwiftUI, a bug in this library, or just something this library needs to be updated to handle.
To Reproduce
Run tests with this project in an iOS 15.2 Simulator (e.g. Xcode 13.2.1) and again with an iOS 15.4 Simulator (e.g. Xcode 13.3)
snapshot-testing-menu-issue.zip
This is all that's needed to see the issue:
let view = Menu(content: {}, label: { Text("My Menu") })
assertSnapshot(matching: view, as: .image(layout: .device(config: .iPhone8)))

Expected behavior
The snapshot should display the menu with iOS 15.4 as it did with iOS 15.2 and prior versions.
Screenshots

iOS 15.2
iOS 15.4

Environment

swift-snapshot-testing version: 1.9.0
Xcode: 13.2.1 / 13.3
Swift: 5.5 / 5.6
OS: iOS 15.4

Additional context
Found while updating CI to use Xcode 13.3 when testing my app Zen Tuner: https://github.com/jpsim/ZenTuner/pull/44
Menus render fine in the iOS Simulator, on iOS devices and in Xcode Previews. While the snapshot tests are running, I see the menu rendered correctly in the host app.

I am seeing the same behavior more generally across all SwiftUI snapshots in my app. We have tons of embedded UIHostingControllers that are giving us blank screenshots on 15.4 (will soon confirm that 15.0 works fine, but this is new behavior for us and that thesis seems likely).
func test_uiHostingController() {
  isRecording = true

  let controller = UIHostingController(rootView: VStack {
    Text("Hello, world")
      .foregroundColor(Color.white)
      .padding()
      .background(Color.green)
  })

  assertSnapshot(matching: controller, as: .image)
}

If we use a SwiftUI.View on its own, only the background color is rendered:
func test_view() {
  isRecording = true

  let view = VStack {
    Text("Hello, world")
      .foregroundColor(Color.white)
      .padding()
      .background(Color.green)
  }

  assertSnapshot(matching: view, as: .image)
}

Confirmed – snapshots are as-expected on iOS 15.

Just checked on today's release of iOS 15.5/Xcode 13.4  and we're still getting blank snapshots :/

This is @gonzalonunez test_uiHostingController on Xcode 14, iOS 16.0

And this is test_view, same setup:

OP's Menu code renders fine:

@loloop so now the only broken is "raw" SwiftUI views?


Issue #7659 foreach warning on adding gateway RELENG_2_3_4

Backport of PR #3764
Note: the code in master for 2.4 is different, so the fix was in gwlb.inc - in RELENG_2_3_4 the code is still in system_gateways_edit.php
Signed-off-by: Phil Davis<EMAIL_ADDRESS>

I've cherry-picked it to RELENG_2_3 as well, thanks


Don't modify the loader's Makefile

Support for windows has been added to the Makefile upstream.

bors r+


Cannot expand a complex type to more than 5K nodes

Describe the Bug
When parsing my schema, I get "[fatal] Current configuration of the parser doesn't allow the expansion of a content model for a complex type to contain more than 5,000 nodes."
Steps to Reproduce
Expected Behavior
I should be able to parse my schema by editing a flag to allow more than 5k nodes

Agreed that this should be possible, but who uses a complex type with 5000 nodes? :see_no_evil:

The European Commission's CBAM XSD definition for generated CBAM reports
Sadly not up to me :(


x/sys/unix: Getrlimit should support RLIMIT_NPROC (number of process limits)

Under Linux a process can be restricted to the number of threads and processes it can launch at any one time. When hitting the process limit, pthread_create will start failing with EAGAIN which causes the go runtime to abort (see bugs https://github.com/golang/go/issues/4056 and https://github.com/golang/go/issues/14835).
In https://github.com/golang/go/issues/4056 it is mentioned that a user should be managing the number of threads (see Comment 33 https://github.com/golang/go/issues/4056#issuecomment-66070031 from @dvyukov)

Users must limit number of threads in sys/cgo calls.

However, different systems can vary widely in the number of threads that you are allowed to create. It is very common on server systems to have a thread limit of 10k, while on desktop and embedded systems it could be as little as 512. Thus the user need to know about the number of threads/processes that an operating system will allow.
Linux provides the ability to read this information using the getrlimit syscall, calling with RLIMIT_NPROC (see http://man7.org/linux/man-pages/man2/getrlimit.2.html). The go runtime already provides access to getrlimit in the syscall.Getrlimit (see https://golang.org/pkg/syscall/#Getrlimit) but this module doesn't currently have the RLIMIT_NPROC resource constant (maybe because it isn't POSIX?).
From the getrlimit man page;

RLIMIT_MEMLOCK  and  RLIMIT_NPROC  derive  from  BSD and are not specified in POSIX.1-2001; they are present on the BSDs and Linux, but on few other implementations.

I believe this can probably be very easily fixed by changing the regex in mkerrors.sh like shown in this patch here -> https://go-review.googlesource.com/#/c/20751/1/src/syscall/mkerrors.sh

the syscall package is frozen, please add the missing
RLIMIT_* constants to x/sys/unix instead.
Note that it's very hard for the user to manage runtime
OS threads. Not only the user must limit concurrent cgo
calls, the user also must limit concurrent blocking syscalls
(file open/read/write, etc.)
Even it's possible for the user to carefully limit the
concurrency of sysclal/cgo in his/here own packages,
external packages might still pose a problem.


Use new style created timestamp (Resolve #188)

From new on inactive timestamp will be used for the created property.
The old style is still supported and will not be converted.

This leaves the existing created property untouched, or should I convert it to the new style as soon as the old style gets detected. This would have the advantage that we could remove the old code somewhere in the future (after one year or so?).
@doolio you could try this if you like

This looks good to me!
Three specific comments:

Perhaps you could add a comment to the relevant sections, explaining why we are supporting two different formats.
It might also be worthwhile to make the timestamp format a configurable variable, mostly because the new style contains localized words that might trip up some use cases.
It might be good to include both kinds of timestamps in the test, just to make sure we don't accidentally break people's existing data in the future.

But, these are details. Overall, this seems a worthwhile change.

@bastibe I have improved it, and fixed some other small bug etc.
Please review again, thanks.
Christian

By the way, do you know if there is a way to set up continuous integration with those?

Sure, I did it for rtags too (https://github.com/Andersbakken/rtags), where I'm also a maintainer. I'll add CI using travis or something the like. I need to do a little research how other emacs-lisp projects are doing it.

As for the rest of the changes, my only comment is on the two choices we get, 'ymd and 'inactive. I see why there are these two specific choices. However, they do beg the question why we are restricting them to these particular choices, as opposed to an arbitrary format string, and a translation layer similar to org-journal-dir-and-format->regex.

I'm with you, it doesn't feel clean and sane. I thought about the same implementation. But than we need to verify that it includes %Y, %m and %d, at least. I'll try to come up with another solution were only a defcustom of type string is required.

The thing is, for weekly, monthly and yearly journal files, we rely on an unique timestamp. From this timestamp, we create a date (Month Day Year), from that date we need to be able to reconstruct the created timestamp to find it again. So in theory, the user can use any time format placeholder which satisfy this requirement.

Merged into master, closing!


Add option to disable turbo for form or optin to forms.

In large application upgrading from turbolinks to turbo requires all
forms that use render to return validations errors needs to be
updated with status: :unprocessable_entity to as in #39 to.
This makes it hard to upgrade as you ether have to have a single PR that
upgrades all form (when you have over 400 forms is pretty risky) or
disable all forms which again can be risky if you miss one before
completing the upgrade.
There are other options but it would be great if you can could do this in
turbo and save hours of work.
To allow this I've added a formMode to the session so you can change
the behaviour of turbo and how it interacts with forms.
The mode is set via the Tubro.setFormMode option and can be set to one
of 3 options:

"on" all forms will be submitted with turbo, this is the default
"off" forms will not be submitted with turbo
"optin" forms by default will not be submitted with turbo unless the
form is annotated with data-turbo="true" attribute.

Adding these options will allow user of turbo to decide how forms should
work and make upgrading easier.

Seems to be no interest on this from the owners and as its behind now will close this off

I think this is actually solid. Missed on the first go around. Please do update and I'll merge 👍

@dhh that it all updated with main. Assuming it passes the CI test should be good to merge

Doh, forgot to run the linter check locally.  I'll get those fixed up just now

That should be it good for another CI run if someone can kick off a run.

I've opened https://github.com/hotwired/turbo/pull/658 to expand coverage to include <form> submissions that don't have submitter buttons (for example, typing enter into an <input type="text"> to submit).

Is this feature documented anywhere? Should it be? Google search for site:turbo.hotwired.dev setFormMode has no hits.
Lack of documentation makes it hard to discover, and hard to know what the intended correct behavior is.  People seem to find out about this feature either from this PR, or from various StackOverflow and blog posts, which may or may not contain current correct information.


Password Generator: Copied Alert

For now after clicking on copy button an alert box is showing like this:

Change this alert box to a tooltip.
Change the text of copy button to copied after clicking on it. Also change its color after clicking.
Also for now the copy button is interfering in the password so apply some padding between them.

Hello @urvashi-code1255 , I would like to work on this issue as a part of GSSOC'21.Could you please assign this to me ?

Sure got for it @ishani02


fix: set 'package.json.browser.crypto = false'

Fix for web bundlers

@jojobyte Does this need the globalThis change as well like DashPhrase and DashHd?

I think it should have it already per https://github.com/dashhive/DashKeys.js/commit/a45d0ead4c4bc11cfda7e0f76152792d7b425f1c


Set dialog "height"

Hi, so I noticed there's no "height" property but there is a "width" property, I don't see the harm in including a height property.
I want to set the height of the dialog to be 80% is there a way to do that? A simple hack perhaps?
Thanks

https://jsfiddle.net/ad3quksn/266/


[release-1.21] - Backport Fix storing bootstrap data with empty token string

Fix storing bootstrap data with empty token string

Signed-off-by: galal-hussein<EMAIL_ADDRESS>
delete node password secret after restoration

fixes to bootstrap key
vendor update
Signed-off-by: galal-hussein<EMAIL_ADDRESS>
fix comment

Signed-off-by: galal-hussein<EMAIL_ADDRESS>
fix typo

Signed-off-by: galal-hussein<EMAIL_ADDRESS>
more fixes

Signed-off-by: galal-hussein<EMAIL_ADDRESS>
fixes

Signed-off-by: galal-hussein<EMAIL_ADDRESS>
fixes

Signed-off-by: galal-hussein<EMAIL_ADDRESS>
typos

Signed-off-by: galal-hussein<EMAIL_ADDRESS>
Removing dynamic listener file after restoration

Signed-off-by: galal-hussein<EMAIL_ADDRESS>
go mod tidy

Signed-off-by: galal-hussein<EMAIL_ADDRESS>

Proposed Changes

Types of Changes

Verification

Linked Issues
https://github.com/rancherlabs/rancher-security/issues/831
Further Comments

Will need https://github.com/k3s-io/k3s/pull/3545 rolled in as well.

https://github.com/k3s-io/k3s/issues/3629 adding issue for backporting kine

https://github.com/k3s-io/k3s/issues/3632 - backport issue for empty node password file


Base run generating multiple snapshot images

When I do a base run to generate snapshots, each test is generating 2 snapshots:

base.png
base-big number.png

This creates a lot of churn in our repo because now instead of just having base.png be updated, we have a delete/create of the numbered image:

The number changes every time I run the command to generate base images. I am using the following command to do this:
./node_modules/.bin/cypress run --env type=base --config screenshotsFolder=cypress/snapshots/base,integrationFolder=src,testFiles=\"**/*visual.test.ts\"
Is there a way to run the "base" command and only generate the base.png file for each test?
Thanks!

I think this is the same problem as in #76 . However the PR #35 did not  change it. Up until now @eric-burel's solution in https://github.com/mjhea0/cypress-visual-regression/issues/76#issuecomment-849726637 seems to the only thing that works. It seem that only @mjhea0 can answer what these files with the big number are used for.

Thanks, that definintely looks like the same issue I am seeing. Because that issue is closed (and the solution didn't really solve it), I will leave this issue open. Or should the other one be reopened where it has more history to it?

I would leave yours open. Just meant to link the other issue as reference that this still exists and hasn't been resolved

at the moment I've fixed it (for now) this way for myself:
npm install del-cli
and added these commands in my package.json file
"scripts":
        "base": "npm run create:base && npm run clean:base",
        "create:base": "cypress run --env type=base --config screenshotsFolder=cypress/snapshots/base",
        "clean:base": "del ./cypress/snapshots/base/**/*-base-[0-9]*.png",
        "clean:base:dryrun": "del ./cypress/snapshots/base/**/*-base-[0-9]*.png --dry-run"

which in turn gives me the following situation: I run the npm run base command which generates new base images (including the ones with the timestamp in it) and when that command finishes it will remove all base images which have the timestamp in it

Without  any additional package:
"scripts": {
        "base": "./node_modules/.bin/cypress run --env type=base --config screenshotsFolder=cypress/snapshots/base",
        "postbase": "cd cypress/snapshots/base && rm -rf */*-base-*.png"
}

Should no longer be a problem


What is the prefered cmd to compile the scss?

I'm trying to make the Application layout settings in config/admin working for all documented values. I have some additions to resources/assets/open-admin/scss/skeleton.scss in the repo. What is the prefered cmd to compile the scss assets for testing and pull requests?

Perhaps this will be of use
Open is based on bootstrap5, if you are interested in changing these styles you could take a look at
/vendor/open-admin-org/open-admin/resources/assets/open-admin/scss
These are compiled with sass via composer. You can run "composer sass" inside /vendor/open-admin-org/open-admin to create a new version of the css. Be aware you need to push you news styles to public root as well. Y
ou can use:
php artisan vendor:publish --provider="OpenAdmin\Admin\AdminServiceProvider"
To make development more easy i created myself a symbolic link between my asset folder in vendor dir and the vendor/open-admin dir in the public root.


Failed to execute https://web-animations.github.io/web-animations-demos on Chrome 64.0.3282.186

Hi,
The demo fails on Chrome.
DOMException: Failed to execute 'createShadowRoot' on 'Element'

came here to report the same...


System.AccessViolationException when using Appender with arrays that contain null values

I'm so excited you have this for .NET :)
Title is self-explanatory, I think. Here is a minimal console app to reproduce:
using DuckDB.NET.Data;

using var conn = new DuckDBConnection("Data Source=file.db");
await conn.OpenAsync();

using var cmd = conn.CreateCommand();
cmd.CommandText = """
    CREATE OR REPLACE TABLE sample (
        id BIGINT PRIMARY KEY,
        name VARCHAR,
        sales DOUBLE[]
    )
    """;
await cmd.ExecuteNonQueryAsync();

using var appender = conn.CreateAppender("sample");
var row = appender.CreateRow();
row.AppendValue(123);
row.AppendValue("This is a sample");
// This line throws an exception
row.AppendValue<double?>([123, 456, null, 789]);
row.EndRow();

appender.Close();

This is the exception/stacktrace:
Fatal error. System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
   at System.Runtime.CompilerServices.CastHelpers.ChkCastAny(Void*, System.Object)
   at DuckDB.NET.Data.Internal.Writer.ListVectorDataWriter.AppendCollection(System.Collections.ICollection, Int32)
   at DuckDB.NET.Data.Internal.Writer.VectorDataWriterBase.AppendValue[[System.__Canon, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]](System.__Canon, Int32)
   at DuckDB.NET.Data.DuckDBAppenderRow.AppendValueInternal[[System.__Canon, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]](System.__Canon)
   at DuckDB.NET.Data.DuckDBAppenderRow.AppendValue[[System.Nullable`1[[System.Double, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]](System.Collections.Generic.IEnumerable`1<System.Nullable`1<Double>>)
   at Program+<<Main>$>d__0.MoveNext()
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[[System.__Canon, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]](System.__Canon ByRef)
   at Program.<Main>$(System.String[])
   at Program.<Main>(System.String[])

Using the command line, it accepts null:
v1.0.0 1f98600c2c
Enter ".help" for usage hints.
Connected to a transient in-memory database.
Use ".open FILENAME" to reopen on a persistent database.
D CREATE OR REPLACE TABLE sample (
┬╖     id BIGINT PRIMARY KEY,
┬╖     name VARCHAR,
┬╖     sales DOUBLE[]
┬╖ );
D INSERT INTO sample (id, name, sales) VALUES (123, 'Hello', [123, 456, NULL, 789]);
D SELECT * FROM sample;
┌───────┬─────────┬─────────────────────────────┐
│  id   │  name   │            sales            │
│ int64 │ varchar │          double[]           │
├───────┼─────────┼─────────────────────────────┤
│   123 │ Hello   │ [123.0, 456.0, NULL, 789.0] │
└───────┴─────────┴─────────────────────────────┘

Works fine for non-nullable...
row.AppendValue<double>([123, 456, 789]);

"System.AccessViolationException" em Módulo Desconhecido.
Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
Hi. I am also having this issue when running the application in my machine. When do you plan to publish this solution to nuget feed?

@kaiohenrique This specific issue is already fixed and available on NuGet in version 1.0.1.
Access violation error can be caused by different reasons, do you get this exception when writing List with nulls? Another cause of this error was reported on Discord a couple of days ago which is also fixed but not pushed to NuGet yet.

Access violation error can be caused by different reasons, do you get this exception when writing List with nulls
Huum, ah, no, we are not writing nulls to list I thought the issue would arise with any null writing attempt

I have downgraded to v0.10.3 and it is working

It looks like you are experiencing the same issue as reported on Discord. I'll publish a fix in a week or two.

@kaiohenrique You can also download preview version: https://github.com/Giorgi/DuckDB.NET/pkgs/nuget/DuckDB.NET.Data.Full


Idea: mabey pointing -f to a executable uses it to verify adresses

so what if would be lets say ./mkp224o -f filterProg would run basically filterProg "$DOMAIN" we could do more interesting things like checking the URL for anything in a filter at any point in the url, not just the start

another idea would be to spawn filterProg as a sub-process and just feed it information throught a ENV var (like what thread it is) and pass Urls through STDIN

anything else than shared memory based feeding would be too slow to be worth it imo, and at that point you'd need to use this thru specialized interface, and would end up losing some speed in the hot loop anyway due to cache area loss.
i think just modifying mkp224o would be simpler instead of doing that.


Update scala-collection-compat to 2.9.0

Updates org.scala-lang.modules:scala-collection-compat from 2.8.1 to 2.9.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-lang.modules", artifactId = "scala-collection-compat" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "org.scala-lang.modules", artifactId = "scala-collection-compat" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Codecov Report
Base: 89.60% // Head: 89.66% // Increases project coverage by +0.05% :tada:

Coverage data is based on head (e5b3dc5) compared to base (3cefba6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1095      +/-   ##
===========================================
+ Coverage    89.60%   89.66%   +0.05%
===========================================
  Files          119      124       +5
  Lines        10016    10050      +34
  Branches       695      695
===========================================
+ Hits          8975     9011      +36
+ Misses        1041     1039       -2

Impacted Files
Coverage Δ

.../main/scala/com/twitter/algebird/HyperLogLog.scala
89.87% <0.00%> (-0.43%)
:arrow_down:

.../scala/com/twitter/algebird/immutable/BitSet.scala
96.85% <0.00%> (-0.21%)
:arrow_down:

.../main/scala/com/twitter/algebird/BloomFilter.scala
94.37% <0.00%> (ø)

.../scala/com/twitter/algebird/MetricProperties.scala
100.00% <0.00%> (ø)

...-2.12-/com/twitter/algebird/immutable/compat.scala
80.00% <0.00%> (ø)

....12-/com/twitter/algebird/macros/MacroCompat.scala
60.00% <0.00%> (ø)

...main/scala-2.12-/com/twitter/algebird/compat.scala
83.33% <0.00%> (ø)

....12-/com/twitter/algebird/collections/compat.scala
100.00% <0.00%> (ø)

...src/main/scala/com/twitter/algebird/Interval.scala
82.53% <0.00%> (+6.34%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[tool_crash] FileSystemException: Cannot create link, OS Error: Função incorreta., errno = 1

Command
flutter pub add google_fonts

Steps to Reproduce

...
...
...

Logs
FileSystemException: Cannot create link, OS Error: Função incorreta.
, errno = 1
%230      _Link.throwIfError (dart:io/link.dart:263:7)
%231      _Link.createSync (dart:io/link.dart:184:5)
%232      ForwardingLink.createSync (package:file/src/forwarding/forwarding_link.dart:20:16)
%233      ForwardingLink.createSync (package:file/src/forwarding/forwarding_link.dart:20:16)
%234      _createPlatformPluginSymlinks (package:flutter_tools/src/flutter_plugins.dart:1029:12)
%235      createPluginSymlinks (package:flutter_tools/src/flutter_plugins.dart:964:5)
%236      refreshPluginsList (package:flutter_tools/src/flutter_plugins.dart:1055:5)
<asynchronous suspension>
%237      FlutterProject.ensureReadyForPlatformSpecificTooling (package:flutter_tools/src/project.dart:316:5)
<asynchronous suspension>
%238      PackagesInteractiveGetCommand.runCommand (package:flutter_tools/src/commands/packages.dart:357:5)
<asynchronous suspension>
%239      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1161:27)
<asynchronous suspension>
%2310     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
%2311     CommandRunner.runCommand (package:args/command_runner.dart:209:13)
<asynchronous suspension>
%2312     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:281:9)
<asynchronous suspension>
%2313     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
%2314     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:229:5)
<asynchronous suspension>
%2315     run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:62:9)

[✓] Flutter (Channel stable, 2.10.3, on Microsoft
    Windows [versÃ£o 10.0.19044.1586], locale
    pt-BR)
    • Flutter version 2.10.3 at D:\Flutter
    • Upstream repository
      https://github.com/flutter/flutter.git
    • Framework revision 7e9793dee1 (5 weeks
      ago), 2022-03-02 11:23:12 -0600
    • Engine revision bd539267b4
    • Dart version 2.16.1
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android
    devices (Android SDK version 31.0.0)
    • Android SDK at
      C:\Users\PC\AppData\Local\Android\sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: C:\Program
      Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment
      (build 11.0.11 9-b60-7590822)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program
      Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop for Windows
    (Ferramentas de Build do Visual Studio 2019
    16.11.10)
    • Visual Studio at C:\Program Files
      (x86)\Microsoft Visual
      Studio\2019\BuildTools
    • Ferramentas de Build do Visual Studio 2019
      version 16.11.32126.315
    • Windows 10 SDK version 10.0.19041.0

[✓] Android Studio (version 2021.1)
    • Android Studio at C:\Program
      Files\Android\Android Studio
    • Flutter plugin can be installed from:
      🔨
      https://plugins.jetbrains.com/plugin/9212-f
      lutter
    • Dart plugin can be installed from:
      🔨
      https://plugins.jetbrains.com/plugin/6351-d
      art
    • Java version OpenJDK Runtime Environment
      (build 11.0.11 9-b60-7590822)

[✓] VS Code (version 1.66.0)
    • VS Code at
      C:\Users\PC\AppData\Local\Programs\Microsof
      t VS Code
    • Flutter extension version 3.38.1

[✓] Connected device (4 available)
    • Android SDK built for x86 (mobile) •
      emulator-5556 • android-x86    • Android 10
      (API 29) (emulator)
    • Windows (desktop)                  •
      windows       • windows-x64    • Microsoft
      Windows [versÃ£o 10.0.19044.1586]
    • Chrome (web)                       • chrome
      • web-javascript • Google Chrome
      100.0.4896.75
    • Edge (web)                         • edge
      • web-javascript • Microsoft Edge
      99.0.1150.30

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

%23%23 Flutter Application Metadata
Type: app
Version: 1.0.0 1
Material: true
Android X: false
Module: false
Plugin: false
Android package: null
iOS bundle identifier: null
Creation channel: stable
Creation framework version: 77d935af4db863f6abd0b9c31c7e6df2a13de57b
%23%23%23 Plugins
cloud_firestore-3.1.10
cloud_firestore_web-2.6.10
firebase_analytics-9.1.2
firebase_analytics_web-0.4.0 8
firebase_auth-3.3.11
firebase_auth_web-3.3.9
firebase_core-1.13.1
firebase_core_web-1.6.1
flutter_native_splash-2.0.5
google_sign_in-5.2.4
google_sign_in_web-0.10.0 5
path_provider-2.0.9
path_provider_android-2.0.12
path_provider_ios-2.0.8
path_provider_linux-2.1.5
path_provider_macos-2.0.5
path_provider_windows-2.0.5
smart_auth-1.0.5

Closing this as duplicate of https://github.com/flutter/flutter/issues/66224


Make 'repository.archive.enabled' setting configurable

This change makes the repository archive setting configurable. In our use case keeping archive increases the disk usage without clear benefit.

@dp-daesung Please consider this PR

Hey @dp-daesung can you help me find the built helm archive with the above changes, I'm looking at:
https://helloworld.kurly.com/helm-nifi/dist/nifi-1.3.1.tgz
but it does not contain it, thanks!

You’re right. Unfortunately, this repo hasn’t been forked for long, so the CI configuration is not fully set up yet.
The original cetic repo was using CircleCI, but we are currently working to transition it to GitHub Actions.

@YordanPavlov Your contribution has been reflected in the 1.3.2 version chart. Thanks again.


license md

I have created the license under MIT
it solve issue number #7

@priyanshaggarwal001
level for this pr has been given in pr #19 as this pr is also a part or issue #7


Add DefaultKeyAlgorithm, DefaultKeySize, and DefaultKeyEncoding.

What this PR does / why we need it:
Some users have minimum requirements set by their clients or internal security teams to use a certain KeySize and KeyAlgorithm. It is best to set those values at a global level to limit the chances that Certificates are not accidentally created that do not meet those minimum requirements.
Which issue this PR fixes:
fixes #1452
Special notes for your reviewer:
Release note:

Add DefaultKeyAlgorithm, DefaultKeySize, and DefaultKeyEncoding via corresponding options --default-key-algorithm, --default-key-size, and --default-key-encoding.

/ok-to-test

@munnerz I think I am ready for another review.

/retest

/retest

/retest

/retest

@munnerz, hoping I can get a review for this so I don't have to keep rebasing.

I would rather us not add additional config surface to ingress-shim if it can be avoided, and it seems like being able to set this default universally instead of just for ingress-shim managed certificates would be best.
Would you mind reworking this PR again to work for Certificate resources more generally? (noting the above comments from the last review about not modifying the Certificate resources spec)

@munnerz, What are your thoughts on adding corresponding fields in the status instead of the spec?
This is helpful because if users leave off the Key* fields from the Certificate yaml they create, they will be able to see in the status what values the certificate gets automatically assigned. (Users may not know that admins set the default.)
This also makes the code changes less difficult as we don't need to pass the default values around as much.

Having the fields in the spec may be useful to reflect the 'actual' state of the key, however it won't allow users to specify these values themselves (and 'status' usually reflects the current state, and isn't typically used for specification of the resource).
I think we'll need to bite the bullet and make more changes throughout to handle this.
Alternatively, we're working on a mutating webhook soon which will allow us to do defaulting in a standard place/way, that will also mean we won't need to plumb default values into functions everywhere. It'd probably be easier to wait until we have that in place, which will make the implementation a lot simpler.

I intended for the fields to be in both spec and status.
In the case where they supply the values in spec, we would just copy them to status.
In the case where they aren't supplied, we would copy the default values to status.
In the case where they supply just the KeyAlgorithm, we would copy that value and set the KeySize to the default for the default of the KeyAlgorithm specified.
I feel like this may be important, even in the future, because when describing the resource the user should understand the actual state even if they spec has blank values.
If you don't like this then I will give up for now.

Any Update about this PR?

I was waiting for a response from @munnerz about my approach of having the keyAlgorithm, keySize and keyEncoding be in both the spec and the status before I did any further work. At this time I have basically implemented it with the code changes I made but need to clean some things up and get the tests working.

Can anyone identify where I can find the file certificate_request_test.go as far as I can tell it is the cause for my test failures and it doesn't seem to exist...
Executing tests from //pkg/controller/certificates:go_default_test
-----------------------------------------------------------------------------
--- FAIL: TestProcessCertificate (0.27s)
    certificate_request_test.go:75: error generating crypto bundle: error encoding private key: unknown key encoding:
--- FAIL: TestTemporaryCertificateEnabled (0.10s)
    certificate_request_test.go:75: error generating crypto bundle: error encoding private key: unknown key encoding:
--- FAIL: TestUpdateStatus (0.11s)
    certificate_request_test.go:75: error generating crypto bundle: error encoding private key: unknown key encoding:

@kyle-winkelman https://github.com/jetstack/cert-manager/blob/master/pkg/controller/certificates/certificate_request_test.go

@munnerz, The current state of my PR is to immediately update the Certificate.Status so the Status reflects the state we are trying to achieve after applying any defaults.
This means we set the Certificate.Status: KeyAlgorithm, KeySize, and KeyEncoding to the values in their spec or the configured defaults if the spec doesn't define them (the default values for the configured defaults are RSA, 2048, and PKCS1, respectively).
Special cases (as defined in the Custom Resource Definitions):

KeyAlgorithm set, KeySize unset - use the defined KeyAlgorithm and a KeySize of 2048 for "rsa" and 256 for "ecdsa"
KeyAlgorithm unset, KeySize set - use "rsa" as the KeyAlgorithm and the defined KeySize

I personally feel like this is better than using mutating webhooks because when describing a Certificate the Status section will show what the true value is even when the Spec doesn't. This is helpful for those that may not fully understand the use case where they set KeyAlgorithm or KeySize but not both. And those that don't know what the defaults are configured to when specifying neither KeyAlgorithm nor KeySize (admin may have set them).

I'm going to close this in favour of #2239 - I think we'd prefer to go down a route that can be replicated for other types of fields that users may want to set 😄


Startup icon scale issue

Describe the bug
The startup icon in the top right corner of the startup tab has its light dots unevenly centered. Indeed, the rightmost one is off by a single pixel.
Screenshots

I'm pretty sure this is a problem on Microsoft's end, they made the emoji font. Correct me if I'm wrong


How to add slot like header or footer?

Hi. Is that possible to add Header and Footer slot?
thanks

I think I just find header slot in source code

<template #header>

it exist

</template>


Can we get training logs ?

Can we get training logs  for all the models ?

I don't have the complete logs now, as some experiments are trained long ago and have been overlaid, and some are splitted due to cluster time constraints. I am happy to respond if you meet any problems in training.


Fix module 'posixpath' has no attribute 'expand'

I originally got the wrong function name for expanding user path.
https://docs.python.org/3/library/os.path.html#os.path.expanduser

Thanks for catching and fixing this @cmd-ntrf!
[W 2023-09-22 22:04:40.387 ServerApp] jupyter_server_proxy | extension failed loading with message: AttributeError("module 'posixpath' has no attribute 'expand'")
    Traceback (most recent call last):
      File "/srv/conda/envs/notebook/lib/python3.10/site-packages/jupyter_server/extension/manager.py", line 356, in load_extension
        extension.load_all_points(self.serverapp)
      File "/srv/conda/envs/notebook/lib/python3.10/site-packages/jupyter_server/extension/manager.py", line 228, in load_all_points
        return [self.load_point(point_name, serverapp) for point_name in self.extension_points]
      File "/srv/conda/envs/notebook/lib/python3.10/site-packages/jupyter_server/extension/manager.py", line 228, in <listcomp>
        return [self.load_point(point_name, serverapp) for point_name in self.extension_points]
      File "/srv/conda/envs/notebook/lib/python3.10/site-packages/jupyter_server/extension/manager.py", line 219, in load_point
        return point.load(serverapp)
      File "/srv/conda/envs/notebook/lib/python3.10/site-packages/jupyter_server/extension/manager.py", line 147, in load
        return loader(serverapp)
      File "/srv/conda/envs/notebook/lib/python3.10/site-packages/jupyter_server_proxy/__init__.py", line 47, in _load_jupyter_server_extension
        server_pr


:bug: :wrench: Kubernetes dashboard support for EKS 1.22

What does this PR do?

Support for EKS Cluster version 1.22
Fix for creating a namespace if its not kube-system

Motivation

More

[x] Yes, I have tested the PR using my local account setup  (Provide any test evidence report under Additional Notes)
[ ] Yes, I have added a new example under examples to support my PR
[ ] Yes, I have created another PR for add-ons under add-ons repo (if applicable)
[x] Yes, I have updated the docs for this feature
[x] Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators

[ ] E2E Test successfully complete before merge?

Additional Notes

#599 implemented the fix with some cleanup so closing this one.


Copy of Implement smoke test user flow for Submission History

Problem statement
Since Submission History Detail page relies on a reportId we need to create an e2e test that mimics a user flow when running our smoke test.
What you need to know
As an admin, select the ignore org and navigate to the Submissions page.
Acceptance criteria

[ ] The date filters return the specified data in the table.
[ ] Clicking on the ReportId will open the Submission History Details page
[ ] Test the details page contains the reportId that was clicked on.
[ ]  ???

To do

[ ] ...

Duplicate


Support target specific dependencies

At librsvg we have a dependency on pangoft2 and fontconfig, but not if you are building for Windows. I'd like to be able to express such a target-specific dependency using system_deps. Is that already possible, is such a feature planned?

This is currently not supported, no.
I'm open to adding specific API for this but I don't have any experience on any other platform than Linux so may need some help to design it.
I know about #[cfg(target_os = "linux")] for conditionally build blocks but I don't think that would do here. Is there any API we could use to fetch the platform info at runtime?

Sorry for ignoring you. The syntax looks useful, but I think it would help to also have the negation.
I will give the change a try on the weekend and get back to you.

Negation is now implemented, see https://github.com/gdesmott/system-deps/pull/34#issuecomment-800162607


Investigation of Factors Affecting Exam Answer Sheet Accuracy

This task involves designing a study to investigate various factors that influence the accuracy of marking on exam answer sheets. The primary objectives are to formulate multiple hypotheses and develop a detailed plan for testing these hypothese.

[x]  Hypothesis Formulation
[ ] Experimental Design

Related with: #82

Hypotheses were drawn up based on the analysis of the data collected - sheet 2 on file: https://1drv.ms/x/s!AuEhl1NqT0N7iGGp7t45b_zb87Af?e=BqXnwQ Once the hypotheses have been approved by the tutor, a detailed outline of the examination sheet will be drawn up.


SSE timeout

SSE never pings.

@marc-j is working on it...

Fixed in 5f1c78ee4e9046c0590b52cb8d252ee3751089b3

Looks like the problem is not solved after all...
Here are the steps to reproduce the problem (using the Python client) :

launch Python

connect client

create a corpus (createCorpus)

watch it (watchCorpus)

the server will indeed keep pinging forever

wait a few minutes (2 should be fine)

now exit Python (^C)

relaunch Python

connect the client

watch the same corpus

the server does not ping this new client  (though it does send events to it...)

It is an issue because, the connection might  be killed (by a proxy, for instance) if it is not active for a long time.
Any idea @marc-j ?
cc @clbarras

_.isUndefined(null) seems to return False. Use _.isNull(null) instead.


Snippet Element does not use specified codename

Brief bug description
When I add a content type with a snippet element, e.g,:
builder.snippetElement({
    codename: 'asnippet', // I've specified a codename here
    type: 'snippet',
    snippet: {
        codename: 'greatsnippet',
    },
    content_group: {
        codename: 'groupb',
    },
}),

it doesn't get added with the codename that I've specified, and instead generates its own codename based on the name of the Snippet Content Type that I've referenced from snippet.codename:
{
  "snippet": {
    "id": "9a9de080-ae97-464d-a552-abd07af97b6c"
  },
  "type": "snippet",
  "id": "32fdbdb5-93bb-4974-9d54-02170b066d2d",
  "codename": "my_great_snippet", // Note that codename has changed here
  "is_non_localizable": false,
  "content_group": {
    "id":"e490a5e0-2e43-432b-b52e-db2f1a4f8490"
  }
}

Repro steps

Add a snippet element to an existing content type:

await managementClient.modifyContentType().byTypeCodename(typeCodename).withData({
	op: 'addInto',
	path: '/elements',
	value: snippetElement, // As defined above
}).toPromise()

Fetch the whole content type

await this.managementClient.viewContentType().byTypeCodename(typeCodename).toPromise()

Observe that the codename fields of each do not match

Expected behavior
When I add an element with a given codename, the element should have that codename.
Test environment

Platform/OS: MacOS
Browser: N/A
Version: 3.0.1

Additional context
Add any other context about the problem here.
Screenshots
Add links to screenshots, if possible.

Hi @msrcodes,
Thank you for submitting the issue. The reason the codename is not set on snippet element is because it's not actually supported by API:

In the end, there is actually no "snippet" element as the snippet is replaced by the elements "in" that snippet and the "codename" in this case is just an identifier of the snippet that is embedded in the content type.
This SDK incorrectly listed the codename property which I have now removed and will not be available in next release.

Fab, thanks for looking into this @Enngage 🚀


Initializing Nhost project locally through CLI fails

Initializing a project locally failed with the message Failed to pull migrations from remote
Nhost CLI version: v0.8.1

Debug messages:

I get the same error 🙁

carlos@Carloss-MacBook-Air ~ % nhost init --remote -d
> Fetching user data
> Fetching saved auth credentials
✔ Selected: parladu  Default Workspace
> Created .nhost
> Created .nhost
> Created nhost
> Created nhost/migrations
> Created nhost/metadata
> Created nhost/seeds
> Created nhost/emails
> Created nhost/config.yaml
> Created .env.development
> Created .gitignore
> Created .nhost/nhost.yaml
> Generating app configuration
> Saving app configuration
> Cloning github.com/nhost/hasura-auth/email-templates to nhost/emails
> Writing .gitignore
> [path] Removing .nhost/nhost.yaml
> Saving app information in .nhost/nhost.yaml
> Initializing Hasura client
> [hasura] [v2.10.1] Fetching binary
> Downloading hasura cli from 'https://github.com/hasura/graphql-engine/releases/download/v2.10.1/cli-hasura-darwin-amd64'
> [darwin-arm64] Writing hasura binary
> Creating migration 'init'
> Fetching metadata
> Fetching schema list
> Clearing remote migration for source: default
> Clearing migration
>
> fork/exec parladu/.nhost/hasura: no such file or directory

carlos@Carloss-MacBook-Air ~ %

Could it be that nhost CLI is downloading cli-hasura-darwin-amd64 when it maybe should be cli-hasura-darwin-arm64 since Im on an M1 Mac?

Could it be that nhost CLI is downloading cli-hasura-darwin-amd64 when it maybe should be cli-hasura-darwin-arm64 since Im on an M1 Mac?

That will change in upcoming release. amd64 works well on Apple M1 if you have Rosetta installed. The error happens because of other problem - incorrect path to hasura cli, to be fixed soon

yep, parladu is the name of the project's folder


Bump SensioFrameworkExtraBundle to allow using PHP 8 attributes

@fabpot could you create a new tag please? Currently, new installations of the framework still install sensio/framework-extra-bundle version 5.


Use execvp instead of execv to allow OS.execute() to search through PATH.

Fix #12003.

Looks fine to me, but I'd like a Unix expert to have a look (@hpvb maybe?).


Helm chart availability

It seems to me that this operator assumes an installation via the openshift operator marketplace, would it be possible to have a vendor-independent deployment option like a helm chart? (or instructions on how to perform such deployment)
Thanks

OLM is an upstream component that can be deployed in any kubernetes environment. Please try the linked documentation to get it deployed.
Finally, the suggestion for a helm chart is an excellent one, and I definitely welcome contribution :)

In the meantime I've found this project: https://github.com/arttor/helmify which can generate an acceptable starting point for a helm chart, so I'm going to use this for the time being. Thanks!

Ok, it seems to have capabilities to integrate with the operator-sdk. I might give it a try later on.
I'd rather keep this issue open until we provide a helm chart. Thanks


Task Modification Runs new Tasks

Template
This is a template. While not all sections are necessary, depending on the size and complexity of the PR,
more information is better.
@ mention of reviewers
@ckcollab
A brief description of the purpose of the changes contained in this PR.
This PR creates and runs current submissions against new tasks added to a phase.
Issues this PR resolves
Resolves #518
A checklist for hand testing

[ ] Adding new task runs current submissions and adds scores to leaderboard (Need to refresh the page after site-worker finishes)
[ ] Removing and then adding task should add old scores back to leaderboard if they do not exist already

Misc. comments
Current Implementation only reruns submissions on new tasks. Current tasks will not be rerun.
Checklist

[x] Code review by me
[x] Hand tested by me
[x] I'm proud of my work
[ ] Code review by reviewer
[ ] Hand tested by reviewer
[ ] Ready to merge

Overall, great work! 😁


Fetch from internet first for service worker

This makes the page less likely to be in a broken state due to updated content.
Tested locally.

I suspect that issues #133 and #134 might be caused by this, so probably good to get it out ASAP.


Update Composer dependencies (2022-10-27-00-10)

Visual regression test passed!
View the visual regression test report


Extend permissible Inlet function argument/return types to include void and string

Summary

This PR is a feature
It does the following:

Adds void and std::string as options for return/argument types in input-filed-defined functions

With the addition of two new argument types the number of function signatures increases from 8 to 64.  No additional assembly is generated but this does have an impact on compile time - on my machine, it roughly doubles compilation time for the header.
One option to decrease this would be to use virtual functions, but we would lose the uniform get<T> syntax as virtual functions cannot be combined with templates.
We could also use a separate program to generate the "name" of the full template instantiation, and "paste" that into the user-facing header via cmake's configure_file or similar.
The snippet below is mostly portable between linux compilers:
abi::__cxa_demangle(typeid(BasicFunctionWrapper).name();

No additional assembly is generated but this does have an impact on compile time - on my machine, it roughly doubles compilation time for the header.

@joshessman-llnl -- could you please provide some (estimates of) quantitative numbers here?
E.g. compile time increasing from 2 to 4 seconds would be different from it increasing from 30 to 60 seconds.

No additional assembly is generated but this does have an impact on compile time - on my machine, it roughly doubles compilation time for the header.

@joshessman-llnl -- could you please provide some (estimates of) quantitative numbers here?
E.g. compile time increasing from 2 to 4 seconds would be different from it increasing from 30 to 60 seconds.

No additional assembly is generated but this does have an impact on compile time - on my machine, it roughly doubles compilation time for the header.

@joshessman-llnl -- could you please provide some (estimates of) quantitative numbers here?
E.g. compile time increasing from 2 to 4 seconds would be different from it increasing from 30 to 60 seconds.

On my machine the difference is roughly 0.7s -> 1.4s

No additional assembly is generated but this does have an impact on compile time - on my machine, it roughly doubles compilation time for the header.

@joshessman-llnl -- could you please provide some (estimates of) quantitative numbers here?
E.g. compile time increasing from 2 to 4 seconds would be different from it increasing from 30 to 60 seconds.

On my machine the difference is roughly 0.7s -> 1.4s

To improve performance I have switched to a lightweight TypeList type for storing parameter packs instead of std::tuple.  This approach avoids instantiating constructors, destructors, etc for all the instantiated tuple types and also allows for removal of the workaround required to store void in a std::tuple.

To improve performance I have switched to a lightweight TypeList type for storing parameter packs instead of std::tuple.  This approach avoids instantiating constructors, destructors, etc for all the instantiated tuple types and also allows for removal of the workaround required to store void in a std::tuple.

Looks great @joshessman-llnl ! could you update the new example that was merged just now w/ the new function types?
https://github.com/LLNL/axom/blob/e5131b35a5dd039f677defec5301a4037480956a/src/axom/inlet/examples/lua_library.cpp

Looks great @joshessman-llnl ! could you update the new example that was merged just now w/ the new function types?
https://github.com/LLNL/axom/blob/e5131b35a5dd039f677defec5301a4037480956a/src/axom/inlet/examples/lua_library.cpp


Proposal: "close" certain api interfaces for external implementation

As discussed in https://github.com/tetratelabs/wazero/pull/1332#issuecomment-1510010359, many of the interfaces in github.com/tetratelabs/wazero and github.com/tetratelabs/wazero/api are not meant to be externally implemented.
In strict terms, an interface can't be extended after it has been made public. Once made public, alternative implementations may be created, and adding a method to such an interface, means those implementations no longer compile, which breaks semver.
wazero 1.0 shipped with many such interfaces, which we may want to extend (e.g. #1332).
These are the paths available to us:

that ship has sailed: wazero 1.0 shipped, we simply can't extend these interfaces;
documentation: document now that certain interfaces are not meant to be implemented outside wazero;
this PR: "enforce" this, avoiding users implementing them by accident.

Option 1 is basically doing nothing. In the context of #1332 I can propose a different alternative, which will basically be a new api.Function2 (name not important) interface that wraps the CallWithStack method. Then users either type-assert this interface, or we create new builders returning this interface.
Options 2 and 3 require deciding which interfaces are only for internal implementation.
Option 2 is a documentation change to github.com/tetratelabs/wazero and github.com/tetratelabs/wazero/api, and to each such interface.
Option 3 is this PR, repeated for every such interface.
In the documentation of each of these interfaces, you'll see:
type Interface interface {
	PublicMethod() // public method
	// contains filtered or unexported methods
}

When you try to implement such an interface (create your own type and use it as if it implemented it), you get this error message:
cannot use &myCallEngine{…} (value of type *myCallEngine) as api.Function value in return statement: *myCallEngine does not implement api.Function (missing method private)

If you're doing it for mocking, which is the only way you'd do it for these wazero types, you can deliberately sidestep the check by embedding the interface, as I did for mockCallEngine:
type mockCallEngine struct {
	index         Index
	callFailIndex int
	api.Function
}

Below should have been added to all interfaces except those that require the users to implement them. What happened was we did this to the top-level ones and didn't go recursively down when we should have.
// # Notes
//
//   - This is an interface for decoupling, not third-party implementations. All implementations are in wazero.

We should not escalate this doc bug as a perpetual promise. The only way someone could even use api.Function would be to wrap, and that would be a hard job as they'd also have to wrap what it returns. I suspect there are max one or two people who could have done this and we can apologize to them individually for the doc bug. If this includes you, please accept my apology!
Knowing this, here's my 2p

I mentioned to someone I think about the missing docs, but I should have done them myself to make sure they landed in the last release. I'll do that now, so that it remain any longer.
I'm fine also adding the private thingy, but not as an alternative to docs. This should be in addition to docs.
Unlike api.GoModuleFunction, api.Function was not documented for implementation. Feel free to add the function you need, I think I mentioned this offline a while but if I hadn't apologies!

https://github.com/tetratelabs/wazero/pull/1397
Sorry, I should have done this immediately when it was brought up last, as it would have been in 1.0.3, then. I often leave work that is easy to do for others, as a way for folks to up stats etc. This is one of those things I should have done right away.

I thought it might be worth chiming in with some examples of how the interfaces can be useful as extension mechanisms. I'm guilty of abusing the documentation stating that they should not be implemented outside of wazero, but there's an interesting use case in wazergo I think https://github.com/stealthrocket/wazergo/blob/main/module.go#L211-L222
The wazergo.ModuleInstance[T] type implements api.Module so when accessing exported functions, the context needed to invoke methods of the host module can be injected automatically.
I'm calling it out for two reasons:

if the documented rules are not enforced, they will likely continue to be abused (by me probably, but it's unlikely that I will remain the only offender)
there may be useful extension opportunities using the interfaces defined in wazero, maybe a follow up could be to start a discussion around how/where it makes sense for wazero to allow applications to leverage interfaces for customization

When this PR gets merged it will break wazergo so I'll follow up with a fix in that repository to address.

You're for sure not the only one doing it, @achille-roussel. I have mockModule and mockMemory for testing.
The major difference is that (my) mocks don't ship downstream, so it's not an issue if my clients update wazero to a version newer than the one I used
OTOH, wazergo might get broken if users update wazero beyond the one declared in wazergo go.mod, which is an issue I don't really know to fix, except by saying wazero can't ever update these public interfaces.

wazergo is not in 1.0 and the README calls out that some breaking changes may be needed for things like "design flaws" so I think it's OK at this stage.

FWIW if there's a secret way to "use at your own risk" I think it is fair to try not to break vs intentionally break.
in any case, the break would be adding new methods, not removing or changing existing ones. So, this means we would only break those who are sneakily wrapping. OTOH this means those wrapping can never be non-experimental or we can decide a version that can't add either.
For example, we can say each even version (e.g. 2.0) is super LTS meaning no functions added either. I don't think we should do that on 1.0 though.

Funny or not, I'm fine with the name. Looking good!
Since there was some chatter on this, I think when ready a RATIONALE.md update is warranted. you can see some other notes about things we do that may be a bit strange in there. One note to put into this is that we are only adding these to "api" (as opposed to all non-internal interfaces) because "api" is most likely what users would expect to implement vs just consume.

About only doing it for api, I started out that way out of laziness, TBH.
It wasn't meant to be a decision, though it can be.
I also skipped api.Global (again out of laziness) because that one has non-struct implementations:
https://github.com/tetratelabs/wazero/blob/c82ad896f6019708f22ddd7826ff47319b7a1e54/internal/wasm/global.go#L45-L48

FWI I'm fine with this not being 100pct coverage. The main types will convey the intent well enough ™

OK. If folks think I should do another round for types in the main wazero package, please say so.

Well done, and I've already re-used your approach in another project ;) https://github.com/tetratelabs/car/blob/master/internal/internal.go#L19

ps I re-summarized the outcome in the commit message https://github.com/tetratelabs/wazero/commit/197facf7a93c4b3cae1af896660b506368201a3d


Torch.cuda.OutOfMemoryError: CUDA out of memory.

Hi, @weihaox, thanks for your open source, I'm very interested in your work! However, I ran into some trouble reproducing the issue now.
When I run inference.py on my NVIDIA RTX 4090 workstation, I get an error saying that I don't have enough memory of GPU. My question is, what is the minimum size of GPU memory needed to run the inference process properly?
The part where the error occurs:

Error: out of memory:

A100 is used in experiments. The pretrained Shikra-7B model, finetuned from Llama, requires around 28GB of GPU RAM to run the 7B model in full precision. The solutions of OOM could be either to load the model with torch_dtype=torch.float16 to use half the memory or to use the provided Colab demo with V100/A100. Other efficient inference tricks for running llama on a single GPU could also be helpful.


Will only open camera on mobile safari

I can only test this with iPhone 6 but it will only trigger opening the camera when I try to upload.
This issue in plupload, http://www.plupload.com/punbb/viewtopic.php?id=4245
suggests that it might be related to the multiple setting.
I've tried this both ways (multiple true and false) and it will still only open the camera.
This is a major issue for me with an otherwise excellent library.
Has anybody else come across this?

Any help on this? Confirmed same problem on ipad...
Could really do with some help on this!

Hey, @jeanleonino do you think you could help @justinboohan on this?
If not, I'd steer you towards ember-file-upload- that is being more actively maintained at the moment 👍

Thanks @tim-evans,
Actually I've just finished some testing with ember-file-upload. It looks like it'll work for me. Looks like it'll be quite straightforward to switch over too. So no need to fix this on my behalf.
Cheers,
Justin

Sweet, thanks a bunch 👍

What i did, i set the property onInitOfUploader='setupUploader' on the component, then i wrote the action:
setupUploader(pluploader){
    pluploader.bind('PostInit', () => {
        let $el = Ember.$(pluploader.settings.container).find("input[type=file]");
        if($el) $el.removeAttr('capture');
    });
}

this project uses version 1 of ember, so the code changes a little if using a newer version.


Compare to build of base.

Right now nixpkgs-review simply tells you about the build status at the selected commit. it would be great if it could compare this to the base state. For example "2 failing -> failing" is very different than "2 building -> failing".

https://github.com/SuperSandro2000/nixpkgs-review-checks implements that in a hacky way.


Children are passed without a component type.

There are some checks in FixedDataTable.react.js:657 that are looking for a type field that is not defined.  I tried to track down the problem, but can't figure out why React isn't giving these children types.
This causes ColumnGroup to fail.

Hi! Can you explain a little bit more about what you mean here?

It seems ComponentClass.type has been deprecated in React 0.13.  I was also forgetting to set a column group height.  I have it working now so I will close this.  Thank you


Small changes to accommodate feedbacks

Renamed Uri to Endpoint, per review
Removed custom PMA pointing constructor, per review

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Communication.CallingServer


possibility to sort the items in a check list in alphabetical order

Please ad an option for sorting the items in a check list in alphabetical order.
Great app. Thank you

I will add that in the next version, already planned on doing that. Anyways, thanks for using the app ^^