Rabbit mq model running

to test with rabbitmq, start a rabbitmq server on the default port and the rabbitmq based model runner should automatically connect as long as it's run on the same host computer
Dockerfile changes:
...
EXPOSE 8000

WORKDIR music-box-interactive
CMD sh start_servers.sh
...

Hello @jwoody02! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file interactive/dashboard/api.py:

Line 45:80: E501 line too long (110 > 79 characters)
Line 46:80: E501 line too long (84 > 79 characters)
Line 47:80: E501 line too long (123 > 79 characters)
Line 49:1: E302 expected 2 blank lines, found 1
Line 70:80: E501 line too long (85 > 79 characters)
Line 71:80: E501 line too long (82 > 79 characters)
Line 99:80: E501 line too long (85 > 79 characters)
Line 164:21: E128 continuation line under-indented for visual indent
Line 241:15: E128 continuation line under-indented for visual indent
Line 263:13: E128 continuation line under-indented for visual indent
Line 346:80: E501 line too long (83 > 79 characters)
Line 364:80: E501 line too long (86 > 79 characters)
Line 365:35: E231 missing whitespace after ','
Line 387:80: E501 line too long (82 > 79 characters)
Line 392:15: E128 continuation line under-indented for visual indent
Line 414:15: E128 continuation line under-indented for visual indent
Line 433:80: E501 line too long (83 > 79 characters)
Line 438:15: E128 continuation line under-indented for visual indent
Line 454:80: E501 line too long (84 > 79 characters)
Line 458:15: E128 continuation line under-indented for visual indent
Line 459:80: E501 line too long (80 > 79 characters)
Line 480:15: E128 continuation line under-indented for visual indent
Line 498:80: E501 line too long (81 > 79 characters)
Line 535:80: E501 line too long (81 > 79 characters)
Line 540:15: E128 continuation line under-indented for visual indent
Line 556:80: E501 line too long (82 > 79 characters)
Line 595:80: E501 line too long (84 > 79 characters)
Line 638:80: E501 line too long (80 > 79 characters)
Line 643:15: E128 continuation line under-indented for visual indent
Line 746:80: E501 line too long (109 > 79 characters)
Line 748:1: W293 blank line contains whitespace
Line 752:45: E261 at least two spaces before inline comment
Line 752:80: E501 line too long (98 > 79 characters)
Line 761:80: E501 line too long (101 > 79 characters)
Line 765:1: W293 blank line contains whitespace
Line 766:13: E303 too many blank lines (2)
Line 767:23: E128 continuation line under-indented for visual indent
Line 768:23: E128 continuation line under-indented for visual indent
Line 775:80: E501 line too long (80 > 79 characters)
Line 968:80: E501 line too long (80 > 79 characters)
Line 1032:80: E501 line too long (83 > 79 characters)
Line 1042:80: E501 line too long (83 > 79 characters)
Line 1049:5: E722 do not use bare 'except'
Line 1056:41: E261 at least two spaces before inline comment
Line 1056:80: E501 line too long (94 > 79 characters)
Line 1064:80: E501 line too long (97 > 79 characters)
Line 1077:80: E501 line too long (80 > 79 characters)
Line 1079:21: E128 continuation line under-indented for visual indent
Line 1080:21: E128 continuation line under-indented for visual indent
Line 1090:35: W292 no newline at end of file

In the file interactive/dashboard/flow_diagram.py:

Line 257:21: E117 over-indented (comment)
Line 280:17: E116 unexpected indentation (comment)

In the file interactive/dashboard/upload_handler.py:

Line 206:1: E302 expected 2 blank lines, found 1
Line 210:80: E501 line too long (116 > 79 characters)

In the file interactive/mechanism/reactions.py:

Line 103:80: E501 line too long (176 > 79 characters)
Line 103:100: E713 test for membership should be 'not in'
Line 107:1: W293 blank line contains whitespace

In the file interactive/model_driver/rabbit_mq_model_status_listener.py:

Line 10:37: E261 at least two spaces before inline comment
Line 10:80: E501 line too long (90 > 79 characters)
Line 13:80: E501 line too long (110 > 79 characters)
Line 14:80: E501 line too long (84 > 79 characters)
Line 15:80: E501 line too long (123 > 79 characters)
Line 19:1: E302 expected 2 blank lines, found 1
Line 20:80: E501 line too long (93 > 79 characters)
Line 26:80: E501 line too long (83 > 79 characters)
Line 27:80: E501 line too long (113 > 79 characters)
Line 28:80: E501 line too long (119 > 79 characters)
Line 30:80: E501 line too long (81 > 79 characters)
Line 40:80: E501 line too long (83 > 79 characters)
Line 47:5: E722 do not use bare 'except'

In the file interactive/model_driver/session_model_runner.py:

Line 26:37: E261 at least two spaces before inline comment
Line 26:80: E501 line too long (90 > 79 characters)
Line 35:1: E302 expected 2 blank lines, found 1
Line 40:80: E501 line too long (83 > 79 characters)
Line 47:5: E722 do not use bare 'except'
Line 50:1: E302 expected 2 blank lines, found 0
Line 58:80: E501 line too long (100 > 79 characters)
Line 60:1: E302 expected 2 blank lines, found 0
Line 263:6: E114 indentation is not a multiple of four (comment)
Line 265:72: W291 trailing whitespace
Line 268:52: W291 trailing whitespace
Line 269:39: W291 trailing whitespace
Line 276:80: E501 line too long (82 > 79 characters)
Line 276:83: W291 trailing whitespace
Line 281:1: W293 blank line contains whitespace
Line 285:5: E303 too many blank lines (2)
Line 286:5: E301 expected 1 blank line, found 0
Line 294:5: E301 expected 1 blank line, found 0
Line 336:80: E501 line too long (103 > 79 characters)
Line 337:80: E501 line too long (93 > 79 characters)
Line 355:80: E501 line too long (94 > 79 characters)
Line 356:80: E501 line too long (103 > 79 characters)
Line 357:80: E501 line too long (93 > 79 characters)
Line 359:1: W293 blank line contains whitespace
Line 445:1: W293 blank line contains whitespace
Line 445:1: W391 blank line at end of file

In the file interactive/plots/plot_setup.py:

Line 25:80: E501 line too long (80 > 79 characters)
Line 26:1: E302 expected 2 blank lines, found 0
Line 27:1: W293 blank line contains whitespace
Line 76:80: E501 line too long (82 > 79 characters)
Line 78:80: E501 line too long (90 > 79 characters)
Line 176:20: W292 no newline at end of file

In the file interactive/rabbit_mq_model_runner.py:

Line 13:37: E261 at least two spaces before inline comment
Line 13:80: E501 line too long (90 > 79 characters)
Line 16:80: E501 line too long (110 > 79 characters)
Line 17:80: E501 line too long (84 > 79 characters)
Line 18:80: E501 line too long (123 > 79 characters)
Line 22:1: E302 expected 2 blank lines, found 1
Line 24:80: E501 line too long (93 > 79 characters)
Line 33:80: E501 line too long (99 > 79 characters)
Line 45:80: E501 line too long (83 > 79 characters)
Line 52:5: E722 do not use bare 'except'

closing PR and moving to new one


Fix failing Travis build

Circus Train builds in Travis are currently failing with an error message like so:
"No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself."
for example https://travis-ci.org/HotelsDotCom/circus-train/builds/334657612
We need to investigate why this is happening. Note: we haven't ever had a successful build so perhaps we should first run a more limited version of the build and get this to succeed and then add more steps to try pinpoint where the failure is coming from.

Some observations:

All the tests appear to be failing in DynamicInputFormatTest - this is doing some funky stuff with files and  folders under "/tmp" and "/target" which may not be appropriate in the environment that Travis is running in.
Some tests appear to be picking up Logback somewhere on the classpath which in turn is suppressing the log output which means we might not be seeing errors that we should be.


Publish 8.4-20230915232128+0000

Publish 8.4-20230915232128+0000

@bot-gradle test and merge

I've triggered a build for you. Click here to see all failures if there's any.


Keep python and notebook automatically in sync

Feature: Notebook Editor, Interactive Window, Python Editor cells
Description
The notebook provides an option 'Convert and save to a Python script', which creates a representation of the notebook as a standard .py script using the 'percent format'. This does not only provide yet another way to interactively work with Python and rich output – the format is also a solution to the long-standing problem that the JSON-format of .ipynb files including embedded binary data (graphics) does not play well with source control systems.
Personally I prefer to work with the standard notebook editor interface, but because of the latter problem with source control I like to have a percent-formatted version in parallel.
My feature request: Have an option, either global, per-workspace, or per-notebook, that whenever an .ipynb file is saved, a percent-formatted version of it is created/updated in the background, too. This way the notebook proper can be used for interactive work, but the commits on the percent-formatted version can serve as a readable record of what was done, so if it is necessary to revert changes, it is clear which commit is the right one.
Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer, @joyceerhl

I would love to have this too. In fact, even having a scriptable means of converting from a "percent formatted" (PF) .py file back to a .ipynb would go a long way towards streamlining many of my team's workflows where we like to keep the PF versions for our automated tests and joint development via git but then export to .ipynb for our forward facing documentation pages.
Thanks for the amazing developer tools that you guys put out there, by the way!

I would love to have this too. In fact, even having a scriptable means of converting from a "percent formatted" (PF) .py file back to a .ipynb would go a long way towards streamlining many of my team's workflows where we like to keep the PF versions for our automated tests and joint development via git but then export to .ipynb for our forward facing documentation pages.
Thanks for the amazing developer tools that you guys put out there, by the way!

Any news on this issue ? That would really be a great addition to vscode !

Sorry but this is not currently on our backlog. We're working on publishing our backlog so that people can see our plans.
It's not that difficult though. You'd just have to watch save requests for the notebook documents (well in insiders anyway) and then run nbconvert every time a save occurred.

@rchiodo

It's not that difficult though. You'd just have to watch save requests for the notebook documents (well in insiders anyway) and then run nbconvert every time a save occurred.

Hi Rich, how can we watch save requests? I've tried several "run on save" extensions and none of them seem to work on ipynb files for some reason.

I believe you could listen to this event:
https://github.com/microsoft/vscode/blob/27b2434631bc9e253c30f3d55b837fea41a7c170/src/vs/vscode.proposed.d.ts#L1209
Then after the event fires, run nbconvert on the notebook.

@venaturum
I've created an extension that does this (open a Python file and execute as a notebook) today https://github.com/notebookPowerTools/vscode-jupytext
Currently only usable in VS Code Insiders.

@DonJayamanne, that looks great, thank!!
Slightly offtopic: I've been looking forward to native notebooks and all that is possible with them, but it still seems to be a way off to get into stable VSCode. On the other hand, I usually don't like to use unstable software for daily work. Is Insiders "unstable"?

k. Is Insiders "unstable"?

I wouldn't call it unstable. Its the latest build of VS Code and latest build of our extensions. These get updated daily. We have CI pipelines (tests) to ensure we don't ship breaking changes.
However once in a while things do break and we try to get them resolve ASAP (within the same day).

@venaturum
I've created an extension that does this (open a Python file and execute as a notebook) today https://github.com/notebookPowerTools/vscode-jupytext
Currently only usable in VS Code Insiders.

I was about to comment about my enjoyable experience with jupytext, as alternative or now I should said, meantime we have a solution in vscode. Nice!

@venaturum
I've created an extension that does this (open a Python file and execute as a notebook) today https://github.com/notebookPowerTools/vscode-jupytext
Currently only usable in VS Code Insiders.

Thanks @DonJayamanne , I've actually been wrestling with Jupytext for the last couple of days trying to achieve the setup my team is after.  Maybe you can advise me as to whether it's possible.  What we're aiming for is

A repository with a folder called scripts which contain py files in percent format
When we clone this repo we want to run a command from a terminal which creates corresponding ipynb files in a folder called notebooks
We then want to run a command which pairs the files in scripts folder to files in notebooks folder
Keep notebooks/py files synced through Insiders/Jupytext extension and git hooks

I have set formats = "notebooks///ipynb,scripts///py:percent" in jupytext.toml and tried executing all sorts of jupytext commands on the command line to achieve the above but haven't succeeded.

If you have questions related to the Juptext extension for VS Code, please file it against that repo.
The Jupyter extension doesn't support jupytext natively (concepts such as keeping the files in sync and the like are currently out of scope - not yet supported)

Duplicate of https://github.com/microsoft/vscode-jupyter/issues/1237
taking this as this falls into nb serialization, also similar to the jupytext notebook viewer (r markdown and myst files)

Hi @DonJayamanne , do we have any updates on this? is it solved, just not documented? thx

Please add the ability to syncing notebooks to py scripts.
Also I do not understand these two phrases used together especially since a lot of people expressed interest in this:

Sorry but this is not currently on our backlog

and

It's not that difficult though

Related on Stack Overflow: How to config automatic sync Jupyter notebook .ipynb and .py files in VSCode e.g. by using Jupytext

Just a note: there are (at least) two possible workflows one might want to support here:

Only a .py file ever exists, but the user can/must open it through the notebook interface. Outputs are discarded when the editor window is closed. Changes are saved to the .py file.
Both .py and .ipynb files exist. The .py file is opened as a normal python file, and the .ipynb file is opened as a notebook. When either one is saved, the command jupytext --sync is run to synchronize the two. This command does not modify the cell outputs, which live in the .ipynb file, but ensures that the code/markdown in the .py file always matches that in the .ipynb file. Only the .py file is checked in to version control; the outputs in the .ipynb are lost only when moving to a fresh clone.

Both modes of working have their merits, but the code required to support them is very different. Mode #2 requires nothing more than reliably running a sync every time either file is saved (though a few extra syncs wouldn't hurt anyone, for example on load). Mode #1 requires support from within the notebook machinery. I note that the extension by @DonJayanne supports (only) #1. Various schemes have been tried to run the sync on save, but for some reason it appears difficult to arrange for a command to be run after a notebook is saved. This could in principle be worked around by creating a watcher daemon that would simply run a sync any time either file was modified; as long as VSCode could be persuaded to keep this running it would automate the task.

I'd love #1 described in @td-anne. I want to use the standard notebook interface with jupytext files. I don't care about saving outputs!

I would like #2 as described above. I do want to keep the outputs for the future. Right now I solve it by running
jupytext --to py:percent file.ipynb

after running the notebook, but it'd be great to be automatic and always sync'd, as it happens with jupyter in the browser

Thanks for considering this!
Quick question re #1, I see that the interactive script mode (also on TDS, search for interactive scripts in that page), which has been around for a while, still works in VS Code. That means that I can execute a percent script step by step in VS Code. Isn't that close already to what you want? How different would a Jupyter mode be?
Personally I would be using mostly #2 i.e. keep the outputs on disk too.

How different would a Jupyter mode be?

Differnt enough that my users don't want to use it. Using Jupyter Notebook mode outputs appear directly below the cell that executed it. We don't need another window open and the output always shows up below the cell that generated it. It's also inline with the behavior of JupyterLab and it's jupytext extension.

Thanks for considering this!
Quick question re #1, I see that the interactive script mode (also on TDS, search for interactive scripts in that page), which has been around for a while, still works in VS Code. That means that I can execute a percent script step by step in VS Code. Isn't that close already to what you want? How different would a Jupyter mode be?
Personally I would be using mostly #2 i.e. keep the outputs on disk too.

I would be sticking to #2 as well. In fact I do manage a clumsy data-loss-prone version of it by manually running jupytext --sync when I remember to. Large or complex notebooks I end up foregoing VSCode's editing power and running things in actual JupyterLab, where this Just Works.
But the in-line rendered markdown, mathematics, and plots are a tremendous selling point for scientific users. Not to mention the rich display of certain outputs (sympy equations, pandas dataframes, generated markdown). With the notebook view, you can execute a notebook and have a literate-programming view of your results, in order, in place, associated with the code that generated them.
The interactive percent mode does have its place, and it can be less confusing than a notebook when you're running cells substantially out of order. But it is the notebook view that took over data science.

For us, what we need is #1, As @jabbera said ithe current state iss different enough to be not convenient to use.

For both options, .py files are explicitly mentioned (.py percent format). I'm not sure whether you implicitly also meant to support the other jupytext supported formats such as .md (markdown, myst markdown).

The interactive percent mode does have its place, and it can be less confusing than a notebook when you're running cells substantially out of order. But it is the notebook view that took over data science.
I agree. In the context of jupyterbook or Sphinx project, there will typically be a step that renders the output to something like Github pages, so the user sees the familiar notebook output (with some nice extra formatting and cross-referening) but you keep the output diff noise out of the repo. (just describing our use case for this feature, not trying to explain jupyterbook).

Personally, I've moved from Jupyter notebooks to Quarto documents. It's slightly less interactive, but Quarto documents are plain text files to begin with, and Quarto supports many additional Markdown features and many output formats (through Pandoc).

I did not move completely but now I am keeping my computations in Jupyter Notebooks and use the Quarto feature to embed what I need from the Jupyter Notebook and expose it into my qmd report. My next step is to try to move completely but I still have peers that are Notebook centric.

Sorry but this is not currently on our backlog. We're working on publishing our backlog so that people can see our plans.
It's not that difficult though. You'd just have to watch save requests for the notebook documents (well in insiders anyway) and then run nbconvert every time a save occurred.
If anybody wants to submit a PR we gladly accept them.

I would like to add an additional potential use case around supporting a workflow to securely use Copilot with VSCode in a notebook IDE when outputs may contain sensitive data.
When using VSCode as a notebook IDE with the Copilot extension there is a concern that given the nbformat containing data from outputs, sensitive data stored from the output of cells could be exposed. In sectors like healthcare we need guardrails to prevent that from happening if we want to use these tools. I asked about this in a support ticket and was advised:

I appreciate you bringing this our attention. I shared your questions to our Copilot engineering team. We went ahead and explored this further. We have concluded with and suggest that it is best to use content exclusions as we cannot guarantee that Copilot will not use data Jupyter notebook cells into its suggestions. For more information, read Configuring content exclusions for GitHub Copilot in the GitHub Docs.

I think one potential workflow is to sync a .py to .ipynb in a repo with the .ipynb subject to Copilot content exclusions and in the .gitignore. That would allow Copilot to be used on the .py percent format, while ensuring that when the .ipynb file is saved the data from the outputs stored in the json structure is protected. I added the jupytext sync command to the save keyboard binding as a task, which has lowered the friction, but it does introduce other off-target effects given keyboard bindings are universal (though the workarounds proposed here looks promising). I expect this feature request would greatly lower the friction to setup and use this kind of workflow.
I also want to acknowledge: thanks for considering this feature request and for all the contributors/developers do in the community!
TL;DR: I think VSCode support of this feature request would facilitate a secure/lower friction way to use Copilot with VSCode as a notebook IDE when outputs may contain sensitive data

Is there any update on this ?


Memory Consumption of Hot Chocolate

hello.
Today we did a small performance testing for HotChocolate in our simple project.
We generated around ~12mb of data.
My question: do you have any guesses how to improve current situation? because we have gap between Rest-like API and GraphQL Engine.
results:
DotTrace snapshot: https://www.dropbox.com/s/ojp9n8y2wb0dwyh/LineByLine.dtp?dl=0

p.s. do not worry about 42 sec, such results because we ran project under profiling.

We are working in this at the moment. The issue is how we build up the result. In our current experiments the memory consumptions is reduced by 90%.

You should retest end of the week with 10.4.0 rc.1

Hello,
Thanks we will try to do it on the next week, and I will provide feedback.

Hello @michaelstaib
Did you release 10.4.0-rc1 ?

No,
this is the pr to watch.
We also have decided to only fix this in version 11 since it has quite an impact.
https://github.com/ChilliCream/hotchocolate/pull/1451

P.S. PR #1451 also switches the result serialization from JSON.NET to System.Text.JSON.

Perfect, thanks for fast update!

I put this on the 11 backlog ... we will soon merge the pr after we have finished of version 10.4 so have a couple days more patience. This is high on our list.


Can't register

Hi. I've followed instructions to change mode to spa, done some migrations and just tested register. It isn't working. I'm getting 500 error in console. I've found there are bad(?) routes to register and login. Changed it to:
Route::post('login', 'Auth\LoginController@attemptLogin');     Route::post('register', 'Auth\RegisterController@register');
attemptLogin yet exists. Register looks like that:
`public function register(Request $request){
if(!Validator::make($request, [
'name' => 'required|max:255',
'email' => 'required|email|max:255|unique:users',
'password' => 'required|min:6|confirmed',
]))
return response([
'status' => 'error',
'msg' => 'Validation failed'
], 400);
    $user = new User;
    $user->email = $request->email;
    $user->name = $request->name;
    $user->password = bcrypt($request->password);
    $user->save();

    return response([
        'status' => 'success',
        'data' => $user
    ], 200);
}`

Another log(which means nothing to me):

Error: Request failed with status code 500
at FtD3.t.exports (vendor.7f943d49379b19889618.js:2)
at t.exports (vendor.7f943d49379b19889618.js:2)
at XMLHttpRequest.d.(anonymous function) (http://localhost:8000/_nuxt/vendor.7f943d49379b19889618.js:2:90914)

How to make register and login work?

Check the network tab or laravel.log for the full error


[WIP] hive proxy

What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?

@AngersZhuuuu could you describe what it does and how does it relate to thriftserver? Sorry, I don't have the context...

@AngersZhuuuu could you describe what it does and how does it relate to thriftserver? Sorry, I don't have the context...

I haven't written a design document yet.
Since in thrift server , if we want to do client user impersonation. we need to make all behavior 's user as client user, in this change I want to make each user one Hive client(build with user's auth)
Since if we call DDL like CREATE TABLE,
we will create table's file path in Hive Client Code, in hive code side, it will use client's login user auth to create table path.
So we can't use one Hive client by all user.
Since in thrift server, we each action has been proxied, we use proxied user to get each's Hive client to do Hive  metadata action.
And this part is also important for us to build hive metadata authentication in the future.
Since we need to check privileage by each user.

@juliuszsompolski
I have test in our kerberized env.
This way can work.
If you use user A to create table , table  path's owner will be A
If you use user B to create table , table  path's owner will be B
ensure storage based authentication

@liancheng could you take a look?

@xuanyuanking, you might be a better candidate for reviewing this one.
@AngersZhuuuu, could you please put a detailed PR description and references for this PR? Kerberos is in general super complicated. People may easily get confused in the future when digging/bisecting historical commits.

Hi @AngersZhuuuu could you add a description and remove [WIP] when it's ready for review?

@AngersZhuuuu, could you please put a detailed PR description and references for this PR? Kerberos is in general super complicated. People may easily get confused in the future when digging/bisecting historical commits.

yea，since I only make this for testing for future support thrift server impersonation.
So don't prepare more detail.
Now works on other part and will make a new pr have  hive proxy and DFS Auth proxy to make spark thrift server support impersonation .
With these basic work, Finally we can make spark thrift server support SQL std Authentication and Storage based authentication.
@juliuszsompolski
You know there a many basic work to do with this project.   I will make a new pr with have  hive proxy and DFS Auth proxy. May be this weekend, with detail info, design reason, limit etc....

@liancheng Thanks for pinging me, I'll keep watching this PR.


[VC]: Update Controller Runtime to 2.5

This fixes #714 and makes sure that new generated files are always created the same. Now when you run make generate instead of using go generate to generate the files this will use controller-gen to create the deepcopy funcs and when you call make manifests it will create the files in config/crds/.
Signed-off-by: Chris Hein<EMAIL_ADDRESS>

/assign @Fei-Guo

One caveat that people might run into using the newer version of controller-gen when you generate the files it will use the code comments to document the Fields, this while being great when you embed StatefulSet schemas into other CRDs it copies all of that data. This means if your cluster has CRDs from the original version when you apply this version kubectl sometimes fails because the last-applied-configurations annotation is larger that the 128kb limit. To resolve this you can use replaceorcreateinstead ofapply`.
I’d like to look into better ways of handling this in later versions of the ClusterVersion CRD, for example using referenced manifests through URLS or the local file system.

/assign @charleszheng44

I was trying go get<EMAIL_ADDRESS>but hit the following errors.
go: found sigs.k8s.io/controller-tools/cmd/controller-gen in sigs.k8s.io/controller-tools v0.3.0
sigs.k8s.io/controller-tools/pkg/crd/markers
/Users/f.guo/go/pkg/mod/sigs.k8s.io/controller-tools@v0.3.0/pkg/crd/markers/topology.go:137:8: schema.XMapType undefined (type *"k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1".JSONSchemaProps has no field or method XMapType)
/Users/f.guo/go/pkg/mod/sigs.k8s.io/controller-tools@v0.3.0/pkg/crd/markers/topology.go:152:8: schema.XMapType undefined (type *"k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1".JSONSchemaProps has no field or method XMapType)
Also, I didn't expect the crd file change from 16k to 1.5MB. Is there a way to shrink it? We seldom look at crd yaml for all the field explanations.

Ah, let me change up the Makefile then, we typically with newer version of controller-gen will use the makefile to create a tmpdir and install into that instead of doing it from within the project.
About the size, I can see if I can remove the field definitions. It’s mostly preparing for the OpenAPI v3 scheme client side validation and for allowing newer clusters to use kubectl explain clusterversions and kubectl explain virtualclusters.
Chatting with other people in the past they have reimplemented the go types that they needed instead of importing full types like we have in https://github.com/kubernetes-sigs/multi-tenancy/blob/master/incubator/virtualcluster/pkg/apis/tenancy/v1alpha1/clusterversion_types.go#L43-L46
It might make sense to change the external type here to [runtime.RawExtension](https://pkg.go.dev/k8s.io/apimachinery/pkg/runtime?tab=doc#RawExtension) or [runtime.Object](https://pkg.go.dev/k8s.io/apimachinery/pkg/runtime?tab=doc#Object) for both of these types and then handle the conversions internally.  At least not to break the current API. It might have made more sense to have these be more like StatefulSetTemplate and ServiceTemplate like you have with v1.PodTemplate, but that would have required understanding all the fields you wanted to expose upfront.

Oops, I also noticed I used 0.3.0 which is for the bleeding edge version of kubebuilder, the one that is currently stable and shipping with the latest kubebuilder is 2.5, I’m changed to that one and  modified the Makefile setup. @Fei-Guo can you check if this works for you?

Also WRT to the descriptions I’ve opened an issue with controller-tools and am researching the feasibility and interest so we can trim down the CRDs - https://github.com/kubernetes-sigs/controller-tools/issues/441

I try to create the crd using the new crd yaml and hit the following,
k create -f tenancy.x-k8s.io_virtualclusters.yaml
The CustomResourceDefinition "virtualclusters.tenancy.x-k8s.io" is invalid:
* spec.validation.openAPIV3Schema.properties[status].properties[versionHistory].items.properties[clusterVersion].properties[spec].properties[apiServer].properties[service].properties[spec].properties[ports].items.properties[protocol].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property
* spec.validation.openAPIV3Schema.properties[status].properties[versionHistory].items.properties[clusterVersion].properties[spec].properties[apiServer].properties[statefulset].properties[spec].properties[template].properties[spec].properties[initContainers].items.properties[ports].items.properties[protocol].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property
* spec.validation.openAPIV3Schema.properties[status].properties[versionHistory].items.properties[clusterVersion].properties[spec].properties[apiServer].properties[statefulset].properties[spec].properties[template].properties[spec].properties[containers].items.properties[ports].items.properties[protocol].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property
* spec.validation.openAPIV3Schema.properties[status].properties[versionHistory].items.properties[clusterVersion].properties[spec].properties[controllerManager].properties[statefulset].properties[spec].properties[template].properties[spec].properties[containers].items.properties[ports].items.properties[protocol].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property
* spec.validation.openAPIV3Schema.properties[status].properties[versionHistory].items.properties[clusterVersion].properties[spec].properties[controllerManager].properties[statefulset].properties[spec].properties[template].properties[spec].properties[initContainers].items.properties[ports].items.properties[protocol].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property
* spec.validation.openAPIV3Schema.properties[status].properties[versionHistory].items.properties[clusterVersion].properties[spec].properties[controllerManager].properties[service].properties[spec].properties[ports].items.properties[protocol].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property
* spec.validation.openAPIV3Schema.properties[status].properties[versionHistory].items.properties[clusterVersion].properties[spec].properties[etcd].properties[service].properties[spec].properties[ports].items.properties[protocol].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property
* spec.validation.openAPIV3Schema.properties[status].properties[versionHistory].items.properties[clusterVersion].properties[spec].properties[etcd].properties[statefulset].properties[spec].properties[template].properties[spec].properties[containers].items.properties[ports].items.properties[protocol].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property
* spec.validation.openAPIV3Schema.properties[status].properties[versionHistory].items.properties[clusterVersion].properties[spec].properties[etcd].properties[statefulset].properties[spec].properties[template].properties[spec].properties[initContainers].items.properties[ports].items.properties[protocol].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property

my minikube version
Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.3", GitCommit:"b3cbbae08ec52a7fc73d334838e18d17e8512749", GitTreeState:"clean", BuildDate:"2019-11-14T04:24:34Z", GoVersion:"go1.12.13", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.0", GitCommit:"9e991415386e4cf155a24b1da15becaa390438d8", GitTreeState:"clean", BuildDate:"2020-03-25T14:50:46Z", GoVersion:"go1.13.8", Compiler:"gc", Platform:"linux/amd64"}

I probably need to turn on the XEmbedded flag again, it appeared like I didn’t need but I must have been wrong.

Also you might want to update your kubectl client… you technically out of the +1 support version. https://kubernetes.io/docs/setup/release/version-skew-policy/#kubectl

Correction, your latest issues it’s actually because of the 1.18 version incompatibility with controller-tools - https://github.com/kubernetes-sigs/controller-tools/pull/440

This is problematic. It is even hard to workaround in 1.18. Adding default manually does not resolve the problem.
k create -f tenancy.x-k8s.io_virtualclusters.yaml
The CustomResourceDefinition "virtualclusters.tenancy.x-k8s.io" is invalid:
* spec.validation.openAPIV3Schema.properties[status].properties[versionHistory].items.properties[clusterVersion].properties[spec].properties[apiServer].properties[service].properties[spec].properties[ports].items.properties[protocol].default: Forbidden: must not be set

This is problematic. It is even hard to workaround in 1.18. Adding default manually does not resolve the problem.
k create -f tenancy.x-k8s.io_virtualclusters.yaml
The CustomResourceDefinition "virtualclusters.tenancy.x-k8s.io" is invalid:
* spec.validation.openAPIV3Schema.properties[status].properties[versionHistory].items.properties[clusterVersion].properties[spec].properties[apiServer].properties[service].properties[spec].properties[ports].items.properties[protocol].default: Forbidden: must not be set

Given it seems like controller-gen is broken with 1.18 we can hold this until https://github.com/kubernetes-sigs/controller-tools/pull/440  is fixed and I have a patch in to allow you to skip the descriptions - kubernetes-sigs/controller-tools#441. I didn’t realize that before I pushed up this code but it’s pretty crazy since we have ClusterVersion embedded in the Virtualcluster resource twice and each one is 1.6m it makes the virtualcluster 2.3m.
We should explore a different way for a those to be referenced. For example:

We could have a finalizer on the ClusterVersion and then we could start to treat these (and implement and admissioncontroller to validate) each ClusterVersion as an immutable resource and reject changes. Then in the virtualcluster resource we could use an field as a reference by name only and remove the embedded types.

We could change all Objects in other specs as runtime.RawExtension on the exported types then use apimachinery conversion to set the runtime.Object, we could have validations using an admission controller to make sure that the embedded services, statefulpods and the clusterversions are the proper types.

We could also leave this for now and discuss what a v1alpha2 could look like since you said you have production users.
wdyt?

/hold

We could have a finalizer on the ClusterVersion and then we could start to treat these (and implement and admissioncontroller to validate) each ClusterVersion as an immutable resource and reject changes. Then in the virtualcluster resource we could use an field as a reference by name only and remove the embedded types.

I think we should revisit the VirtualclusterStatus struct. We already have ClusterVersionName in the spec and I don't think it should be mutable. Our controller currently does not support changing the clusterversion. It seems that vc crd size problem is resolvable.

could you should me how to generate these two file incubator/virtualcluster/config/crds/tenancy.x-k8s.io_clusterversions.yaml ?

could you should me how to generate these two file incubator/virtualcluster/config/crds/tenancy.x-k8s.io_clusterversions.yaml ?

Yup, with the Makefile.
make manifests

https://github.com/kubernetes-sigs/multi-tenancy/pull/738/files#diff-d20693c5c6e86e34be5c15bb9ba38925R79

The clusterversionhistory field has been removed from VirtualClusterStatus with #741 . The VC crd size is reduced to 4.7KB with controller-gen 2.5

Wow, that’s fantastic. Let me update this and maybe we can push it through?

Wow, that’s fantastic. Let me update this and maybe we can push it through?

I still have concern about clusterversion crd size though. A 1.6MB yaml basically makes the crd not readable at all. The current crd yaml looks much more straightforward.

/unhold

@Fei-Guo I was able to remove all the descriptions on the specs reducing the size to 500kb for the entire spec for ClusterVersion, much more manageable and now kubectl apply -f works again.
This still has the issue with 1.18 specs, that is being tracked across https://github.com/kubernetes-sigs/controller-tools/pull/440 given that all controller-runtime 2.x projects are broken with this do you want to continue to wait on this?

I am ok with current controller runtime 2.x and I tend to agree that we can remove statefulset object is clusterversion to further reduce the crd size.

/lgtm
/approve


Update page for Atn() VBA function.

Note use as equivalent to Excel ATAN() function, and omit nonsense example. Sufficient keywords to match for those (like me) looking to use the eqivalent of the Excel ATAN() function from VBA.

Docs Build status updates of commit 0d176d0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Language/Reference/User-Interface-Help/atn-function.md
:bulb:Suggestion
View
Details

Language/Reference/User-Interface-Help/atn-function.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit d25a55d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Language/Reference/User-Interface-Help/atn-function.md
:bulb:Suggestion
View
Details

Language/Reference/User-Interface-Help/atn-function.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


List of supported disabledProfileSources in schema

Is there a list of disabledProfileSources anywhere? I couldn't find anything in the profiles.json schema.
Googling around I found three supported entries:
    "disabledProfileSources": [
      "Windows.Terminal.Azure",
      "Windows.Terminal.PowershellCore",
      "Windows.Terminal.Wsl",
    ]

But would like to hide cmd and Windows PowerShell.
Cheers 👍

cmd and Windows PowerShell aren't dynamic profiles and aren't subject to the dynamic profile system -- we could use better docs here, but for now it will suffice to switch them to hidden:true. That's actually why we left the hidden property in the user settings there: so it was more discoverable.


Update cosmwasm 0.8

This updates go-cosmwasm to the current master of cosmwasm and updates to contract_0.8.wasm. This now works to 90%. There is some error with the humanize_address callback that I need to track down and repair.
There are also a number of TODOs to get full working version, some of which may be in future PRs. This is tracked in https://github.com/CosmWasm/go-cosmwasm/blob/update-cosmwasm-0.8/TODO
Planned for this PR:

[x] Update all types in go (left: ApiError)
[ ] All tests pass with current mocks
[ ] Add StakingMsg to types
[ ] Implement remove for DB
[ ] Update to cbindgen 0.14

Planned for future PRs:

[ ] Add Querier callback to go code
[ ] Enable iterator feature flag and implement iterator callback

If someone could take a look at help figure out why humanize_address is failing, that would be super useful. I tried adding print statements, but nothing came out.

If someone could take a look at help figure out why humanize_address is failing, that would be super useful. I tried adding print statements, but nothing came out.

Looking at the error message, there must be an ApiError::ContractError

Expected nil, but got: &types.ApiError{Base64Err:(*types.SourceErr)(nil), ContractErr:(*types.MsgErr)(0xc000230d70)...

Maybe this new error case? https://github.com/CosmWasm/cosmwasm/commit/b82025a713537be2bffd725761eee2d0ba7ac250

I made PRs for follow-ups. I would like to merge this in to have a solid base, and we can keep making PRs (in parallel) to add features to get 0.8 feature complete.
If I forget some other feature, please add it to the list


IRIG-B decoding might fail for neg. values

most likely since we are reading straight into dc

a fix: use bash builtins for the math. read in the lines in the same way, but don't feed them straight to dc

from https://www.gnu.org/software/bc/manual/dc-1.05/html_mono/dc.html:
To enter a negative number, begin the number with _'. -' cannot be used for this, as it is a binary operator for subtraction instead.


created Composition and XRD for magento2 deploy in gcp with external …

…database, implemented gh action for build and push crossplane configuration packages under ghcr.io/web-seven/configuration-magento2-gcp repository

@ca7alindev Ready for review?

@ca7alindev Ready for review?
Yes


Autocomplete with named parameters

When there's a singleton record type as one of the parameters, autocomplete could fill in the field =  part of the parameter.
def contains(sub: {sub :: String}, s: String): Bool = ???

// user types
String.conta<tab>

// autocomplete fills in
String.contains(sub = |, |)

// where | are the fill-in points

I think this is too niche.


new function for B525

DeviceName B525s-23a
HardwareVersion WL1B520FM

SWITCH ETH to 4G

request = '<?xml version="1.0" encoding="UTF-8"?><request><connectionmode>5</connectionmode></request>'
response = router.api('cradle/basic-info', request)

SWITCH 4G to ETH

request = '<?xml version="1.0" encoding="UTF-8"?><request><connectionmode>0</connectionmode></request>'
response = router.api('cradle/basic-info', request)

Thanks @wep777, I've added this into the API.
router.ethernet.set_auto()
router.ethernet.set_lan_only()
router.ethernet.set_ppoe()
router.ethernet.set_dynamic()
etc...
I added support for all the settings I found, but haven't been able to test it all, as I'm only using 4G at the moment.
If you get a chance to test any of them let me know.

Thanks for this. I was looking high and low for a way to change ETH port 4 to LAN (default is WAN) and router.ethernet.set_lan_only() did the trick for me. Having said that, it wasn't clear to me initially as the comment in the example usage says #LTE mode - so uses 3G or 4G. Perhaps it is clearer to say #LTE mode - so uses 3G or 4G. This also converts port 4 into a LAN port.?

Thanks for this. I was looking high and low for a way to change ETH port 4 to LAN (default is WAN) and router.ethernet.set_lan_only() did the trick for me. Having said that, it wasn't clear to me initially as the comment in the example usage says #LTE mode - so uses 3G or 4G. Perhaps it is clearer to say #LTE mode - so uses 3G or 4G. This also converts port 4 into a LAN port.?


[IBCDPE-831] Updates to PEGS DAG

problem
A few parameters were missing in the params configuration, and manifest_path needed to be declared
solution
Updated accordingly and tested on a codespace instance
testing
PEGS challenge DAG is running successfully

On the Nextflow side, here's an example of successful/running executions

Leaving this in draft until stress test is over (April 19)

@jaymedina I realized while working on ORCA-300 that using the UUIDs this way won't work exactly as intended. In the Dynamic Challenge DAG, my hope was to have the manifest file and workflow run ID have matching UUIDs so that it is easy to tell which file goes with which run, but it turns out that the way Airflow executes the DAGs causes different UUIDs to be used in different tasks sometimes. I fixed this in the linked PR by making the UUID a parameter of the DAG run so that it is always the same across tasks. I'll be updating the Dynamic Challenge DAG, but I wanted to give you a heads-up while this PR is still open for PEGS.

Sounds good, thanks for the heads up @BWMac. Addressed in the latest commit.

Update: DAG is running successfully with the latest branch

Here is the latest workflow run that runs off the latest ver of this branch. It's a successful workflow run following the handling of profiles. Apparently that's supposed to be a list, even if it's just a single profile. I also added the tower profile to work with RUN_DOCKER and use appropriate resource amounts.
https://tower.sagebionetworks.org/orgs/Sage-Bionetworks/workspaces/pegs-challenge-project/watch/1andK1qSuuzkQH


Add a duplicate account

Checklist

[X] I have used the search function to see if someone else has already submitted the same bug report.
[X] I will describe the problem with as much detail as possible.

App version
6.313-SNAPSHOT
Where did you get the app from?
Other
Android version
8.1
Device model
emulator
Steps to reproduce

Login
Go to the drawer menu
Go to settings
Click on add account
Enter the account information of the same account that exists, and login again

Expected behavior
Show a warning that you are already logged in with this account. And don't allow re-login and duplicate account creation
Actual behavior
It is logged in without problems and two duplicate accounts are created.
Logs
No response

Especially for debugging purposes it's sometimes useful to add the same account twice.
I don't think a lot of people will add the same account twice on accident. So I don't see much value in adding a "warning" message.


Adding "in game situation " in description

Before sending your pull-request 💌 make sure :

[ ] The tests are up-to-date and your code is tested

I made a mistake with my commit


Only one circle is displayed in mobile

When I test my site on mobile using this plugin I only get one white circle. There is no grey to display the percentage and all the other circles is gone

Can you make a demo depicting this ? fiddle ?

Can you try it again with the new plugin that is now based on svg?!


Fix workload upgrade case and rename nodes to start with testauto

@soumyalj Can you review the changes?

LGTM


placeholder: pocket casts

reminder for self and progress of pocket casts PLEASE IGNORE unless it's been more than a month
it seems that it's a human manually pulling stuff
I got 'all raw data we have on you', in a txt file, what's essentially sectioned csv files.
Problem is, everything is identified with uuids, mailed back asking for subscription titles and urls to be included, or matched.
The import/export opml within the app provides these in xml, but there's no tie between an uid and an item in the opml file

Closed as stale. Though, they got bought by Automattic on 2021-07-19.
I've been moving off them, but I'm afraid the data has been already exchanged.


[ISSUE-#7007] Fix collection data(remote_host) at provider side in monitorFilter not right.

What is the purpose of the change
Fix-#7007

Codecov Report

Merging #7008 (4cc72ba) into master (a2a14dc) will decrease coverage by 0.29%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master    #7008      +/-   ##
============================================
- Coverage     59.13%   58.84%   -0.30%
+ Complexity      509      503       -6
============================================
  Files          1028     1028
  Lines         41519    41520       +1
  Branches       6037     6021      -16
============================================
- Hits          24554    24433     -121
- Misses        14197    14315     +118
- Partials       2768     2772       +4

Impacted Files
Coverage Δ
Complexity Δ

...rg/apache/dubbo/monitor/support/MonitorFilter.java
68.00% <66.66%> (+0.65%)
0.00 <0.00> (ø)

...rg/apache/dubbo/remoting/utils/PayloadDropper.java
0.00% <0.00%> (-46.16%)
0.00% <0.00%> (ø%)

...a/org/apache/dubbo/rpc/filter/AccessLogFilter.java
36.00% <0.00%> (-44.00%)
0.00% <0.00%> (ø%)

...va/org/apache/dubbo/rpc/support/AccessLogData.java
47.88% <0.00%> (-42.26%)
0.00% <0.00%> (ø%)

...org/apache/dubbo/registry/dubbo/DubboRegistry.java
43.13% <0.00%> (-13.73%)
9.00% <0.00%> (-1.00%)

...bo/config/event/listener/LoggingEventListener.java
50.00% <0.00%> (-12.50%)
0.00% <0.00%> (ø%)

...he/dubbo/common/threadpool/ThreadlessExecutor.java
52.17% <0.00%> (-10.87%)
0.00% <0.00%> (ø%)

...ava/org/apache/dubbo/config/DubboShutdownHook.java
63.82% <0.00%> (-10.64%)
0.00% <0.00%> (ø%)

...che/dubbo/remoting/transport/mina/MinaChannel.java
39.47% <0.00%> (-10.53%)
15.00% <0.00%> (-1.00%)

.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java
62.06% <0.00%> (-10.35%)
0.00% <0.00%> (ø%)

... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2a14dc...4cc72ba. Read the comment docs.

@htynkn


Upload KB focussing scripts

https://github.com/PaNOSC-ViNYL/wavefrontDB/blob/main/examples/EuXFEL_SASE1_SPB_KBfocus.ipynb


NiiVue 0.37.0 thinks it is 0.36.0

When including the<EMAIL_ADDRESS>file in html, the following console output is printed:
NIIVUE VERSION  0.36.0
Searching in the file niivue.umd.js also gives a lot of results of "0.36" while no result for the version "0.37".
The package.json file in<EMAIL_ADDRESS>correctly states:
"version": "0.37.0",

@korbinian90 Thanks for pointing this out. I will look into it and patch as necessary.


Reply with images

Feature request
Being able to display actual markdown would be cool, nice to have image links in the docs mdx files, and then ask gpt to try include markdown image links where appropriate.
I can get GPT to include the ![Alt text](URL or file path) images, but the response isn't actually displaying markdown.

Anyone have any luck with being able to do this ? I've tried getting the a,i to add the <img tag into it's replies, but it's still just text.
Is this something that's possible?

Hey @musashi-garami, agreed it would be great to support markdown in this project. In the mean time, feel free to check out how we do this in the Supabase docs/dashboard using ReactMarkdown:
https://github.com/supabase/supabase/blob/5d457bdc7567db9a73a02a3d10e984a641f6cc3d/packages/ui/src/components/Command/AiCommand.tsx#L418-L435

Ok that looks perfect! But I'm struggling to install react-markdown. I normally use NPM but I see this builds with PNPM and vercel is not building, I'm assuming due to incorrect pnpm-lock.yaml file ? But I'm not experienced with PNPM, I installed latest PNPM, I tried to PNPM install react-markdown but didn't work.. so I NPM install react-markdown, but with my limited understanding it appears the pnpm-lock.yaml is not adding react-markdown as a dependency (which is failing the vercel build)

Nevermind, looks like PNPM wasn't working in VS code terminal due to windows permissions, i ran in admin powershell and it installed properly.
Then another build error, was passing {completion} as a children prop to react-markdown (as their docs describe) but ESLint rules is not happy with that so passed {completion} between the react markdown tags


fix check/uncheck for radio button

I could not check a radio option with mink.
The problem came from the Driver.
So I propose this patch

According to documentation (see http://mink.behat.org/en/latest/guides/interacting-with-pages.html) you should be using selectOption method to check a radio button instead of check method, which is for checkboxes only. Also user can't uncheck the radio button once it's checked and there uncheck method doesn't work on radio buttons as well.

closing this as it is indeed an invlaid usage. Interacting with a radio group means selecting an option between the different input of the groups. You cannot check them individually (and you cannot uncheck them at all).
For your next contributions to drivers, the workflow when fixing a driver bug is to always start by adding a test in the Mink driver-testsuite reproducing it, to forbid regressions and to ensure that all drivers are consistent. Btw, adding a new feature at the driver level also start in the Mink repo (with the base driver change and the consistency tests)


Updates to monsoon notebook

I have updated the parameter file template to use new sample data and have added an additional example to the notebook. The regridding options have been hard-coded in the monsoon driver as regridTool="regrid2" and regridMethod="conserve".
Additionally, a "download complete" message has been added to Demo 0 to let users know that the download is finished.

@gleckler1 @lee1043 Here's a PR for the monsoon notebook changes (and I also threw in the Demo 0 download message)


Inconsistency in handling 'cancel' modals

Description
Some modals reset there state if canceled but most of the modals only close but persist any changes to the data.
To reproduce this

create Project

click 'New Column'

enter title

click 'cancel' in modal

click 'New Column' -> title is still there

the same is on like every other modal

edit column
Transfer Ownership
Delete Wiki Data
Delete This Repository
Deploy Keys  -> its not a modal
Add Secret
Manage SSH Keys -> its not a modal
Manage GPG Keys -> its not a modal

on other modals the state gets reset

Add Variable -> (still gets the 'stay on page' question)
Submit review -> don't reset, but without 'stay on page' question

On some modals (like modals to create something) its ok and maybe good to have, but on other modals like edit/delete it should reset the state
The problem is, that the form has data and always ask to 'stay on page' because of unsaved data
Gitea Version
1.21.5
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots

Git Version
No response
Operating System
Linux
How are you running Gitea?
I used the download, but it's also the same with own builds and on try.gitea.io
Database
MySQL/MariaDB

possible solutions are

maybe add type=reset to shared/modal_actions_confirm
web_src/js/features/common-global.js line 393 -> add form.reset()

dont work with markdown-editor

or maybe refactor modals completely, because there is also a inconsistency in the styles


doc: fix markup so text does not render as one sentence

Coverage remained the same at 100.0% when pulling 9ecd4947a0f0d9efac8bb6f190219e18c59239e0 on tshepang:better into 30fd98426b90576a8b5d5a43822309bb48896731 on softprops:master.

Coverage remained the same at 100.0% when pulling 9ecd4947a0f0d9efac8bb6f190219e18c59239e0 on tshepang:better into 30fd98426b90576a8b5d5a43822309bb48896731 on softprops:master.


[Update Request]: RustDesk v1.3.3

What type of update are you requesting?
A new version of an existing package
Current Package Identifier
RustDesk.RustDesk
Package Version
1.3.3
Please describe the changes you would like to see
RustDesk released a new version a couple days ago.
The download page is https://github.com/rustdesk/rustdesk/releases/tag/1.3.3

We've found some similar issues:
* [[Update Request]: RustDesk.RustDesk 1.2.1 #113571](https://github.com/microsoft/winget-pkgs/issues/113571) , similarity score: 92%

If any of the above are duplicates, please consider closing this issue out and adding additional context in the original issue.

Note: You can give me feedback by 👍 or 👎 this comment.

(Linked issue #113571 is outdated, had been solved by a later package update (prior to this one), and should probably be closed.)

https://github.com/microsoft/winget-pkgs/pull/194885


xrdp issue in centos 7

Hi all, I have installed xrdp from master branch in centos 7.3. I have also built X11rdp as is mentioned on the wiki page.
https://github.com/neutrinolabs/xrdp/wiki/Building-on-CentOS-(or-Red-Hat-based-distributions)
Now when I logon in the xrdp window from a Windows machine, I am getting the following error "Oh no, something went wrong. Please log out and try again". When I try again, I am getting a blank black screen. I have checked the xrdp and xrdp-sesman log files. I also checked xorg.0.log file.
Following is the xrdp.log file.
[20170131-15:29:49] [INFO ] A connection received from: <IP_ADDRESS> port 49183
[20170131-15:29:49] [DEBUG] Closed socket 12 (AF_INET <IP_ADDRESS>:3389)
[20170131-15:29:49] [DEBUG] Closed socket 11 (AF_INET <IP_ADDRESS>:3389)
[20170131-15:29:49] [INFO ] Using default X.509 certificate: /etc/xrdp/cert.pem
[20170131-15:29:49] [INFO ] Using default X.509 key file: /etc/xrdp/key.pem
[20170131-15:29:49] [DEBUG] Security layer: requested 3, selected 1
[20170131-15:30:04] [DEBUG] Closed socket 12 (AF_INET <IP_ADDRESS>:3389)
[20170131-15:30:04] [ERROR] Listening socket is in wrong state, terminating listener
[20170131-15:30:06] [INFO ] A connection received from: <IP_ADDRESS> port 49185
[20170131-15:30:06] [DEBUG] Closed socket 12 (AF_INET <IP_ADDRESS>:3389)
[20170131-15:30:06] [DEBUG] Closed socket 11 (AF_INET <IP_ADDRESS>:3389)
[20170131-15:30:06] [INFO ] Using default X.509 certificate: /etc/xrdp/cert.pem
[20170131-15:30:06] [INFO ] Using default X.509 key file: /etc/xrdp/key.pem
[20170131-15:30:06] [DEBUG] Security layer: requested 3, selected 1
[20170131-15:30:06] [DEBUG] xrdp_00004136_wm_login_mode_event_00000001
[20170131-15:30:06] [INFO ] Loading keymap file /etc/xrdp/km-00000409.ini
[20170131-15:30:06] [WARN ] local keymap file for 0x00000409 found and doesn't match built in keymap, using local keymap file
[20170131-15:30:14] [DEBUG] xrdp_wm_log_msg: connecting to sesman ip <IP_ADDRESS> port 3350
[20170131-15:30:15] [INFO ] xrdp_wm_log_msg: sesman connect ok
[20170131-15:30:15] [DEBUG] xrdp_wm_log_msg: sending login info to session manager, please wait...
[20170131-15:30:15] [DEBUG] return value from xrdp_mm_connect 0
[20170131-15:30:15] [INFO ] xrdp_wm_log_msg: login successful for display 11
[20170131-15:30:15] [DEBUG] xrdp_wm_log_msg: started connecting
[20170131-15:30:15] [INFO ] lib_mod_log_peer: xrdp_pid=16694 connected to X11rdp_pid=16168 X11rdp_uid=1000 X11rdp_gid=1000 client_ip=<IP_ADDRESS> client_port=49185
[20170131-15:30:15] [DEBUG] xrdp_wm_log_msg: connected ok
[20170131-15:30:15] [DEBUG] xrdp_mm_connect_chansrv: chansrv connect successful
[20170131-15:30:15] [DEBUG] Closed socket 18 (AF_INET <IP_ADDRESS>:42514)
[20170131-15:30:15] [INFO ] The following channel is allowed: rdpdr (0)
[20170131-15:30:15] [INFO ] The following channel is allowed: rdpsnd (1)
[20170131-15:30:15] [INFO ] The following channel is allowed: drdynvc (2)
[20170131-15:30:15] [INFO ] The following channel is allowed: cliprdr (3)
[20170131-15:30:15] [DEBUG] The allow channel list now initialized for this session

Corresponding xrdp-sesman.log file is:
[20170131-15:22:56] [INFO ] A connection received from <IP_ADDRESS> port 42512
[20170131-15:22:56] [INFO ] ++ created session (access granted): username cdtest, ip <IP_ADDRESS>:49182 - socket: 12
[20170131-15:22:56] [INFO ] starting X11rdp session...
[20170131-15:22:56] [DEBUG] Closed socket 9 (AF_INET <IP_ADDRESS>:5911)
[20170131-15:22:56] [DEBUG] Closed socket 9 (AF_INET <IP_ADDRESS>:6011)
[20170131-15:22:56] [DEBUG] Closed socket 9 (AF_INET <IP_ADDRESS>:6211)
[20170131-15:22:56] [DEBUG] Closed socket 7 (AF_INET <IP_ADDRESS>:3350)
[20170131-15:22:56] [DEBUG] Closed socket 8 (AF_INET <IP_ADDRESS>:3350)
[20170131-15:22:57] [INFO ] X11rdp :11 -auth .Xauthority -geometry 1280x960 -depth 16 -bs -nolisten tcp -uds
[20170131-15:22:57] [INFO ] starting xrdp-sessvc - xpid=16168 - wmpid=16167
[20170131-15:30:14] [INFO ] A connection received from <IP_ADDRESS> port 42514
[20170131-15:30:15] [INFO ] ++ reconnected session: username cdtest, display :11.0, session_pid 16166, ip <IP_ADDRESS>:49185 - socket: 12
[20170131-15:30:15] [DEBUG] Closed socket 8 (AF_INET <IP_ADDRESS>:3350)

The .xsession-errors file is also empty.
The output of X11rdp :1 command is
InitOutput:

X11rdp, an X server for xrdp
Version 0.9.1
Copyright (C) 2005-2015 Jay Sorg
See http://www.xrdp.org for information on xrdp.

My login is working fine with xrdp-Xvnc. But I am getting all the applications with that and it is asking for root password at login (though if you press cancel, the desktop gets loaded but I don't like it). Now, I had installed xrdp 0.8 on RHEL 6 and used X11rdp to login. The non-root users were not getting menu options like System Preferences and so on.. Basically I want a menu like that. Also sound redirection was working for me. So I want to know if the same can be achieved in CentOS 7 also.
Thanks
Shalabh Goel

Can it be that X11rdp is not in PATH of xrdp-sesman? If I build X11rdp into a local directory, I also create a wrapper script, call it X11rdp and copy it to /usr/bin or /usr/local/bin/. The script is run as the logged in user. It's also possible to redirect stdout and stderr to files, so I know if X11rdp reported any error.
#! /bin/sh
exec ~/x11rdp/bin/X11rdp "$@" >~/x11rdp.log 2>&1

Also check if /etc/xrdp/startwm.sh is reporting any errors. You can make a wrapper around it to see if it reported any errors.

No feedback for a long time, closing. Please let me know if you're back. I'll reopen the issue.


Add CI workflow to check if there has been a new release

A workflow that fails if there has been changed in the arm gcc releases page.
Probably the simplest method might be to check for the "last modified" response header.

Turns out the page with the gcc downloads does not provide the "last modified" response header, so had to resort to look for a match in a specific string that indicates the date of the latest release.
Implemented in 485c95886a121a3a2fd7136119d4f216949a681c.


Add a sound_from_memory function to load from []byte

Adds the ability to load a sound from a byte array. I'm using it in my case to load a sound from an embedded file.
Also adds a pause method for sounds.

Thanks!


Bug Fixes

Got it :)
Adding an event listener requires us to call $apply() inside the listener for ng-show to work. Would a recursive $timeout inside the update() function suffice?


[FEATURE]

Description
A roadmap for machine learning would be a great addition.
Screenshots
No response
Additional information
No response

What can I do to be of help?

Hey @Sunnyjoe101! Fork this repo and Create a separate folder for Machine Learning roadmap then add the steps with proper resources and make PR. That's it. Hope this clears your doubt.
Thankyou!

Hey @Shikharishere! Please change the title of the ISSUE from "description" to "ML roadmap". Because it leads to open an another Issue for the same purpose. So please change it.
Thankyou!

Duplicate issue


docs/DriverDelegate opposite meaning fix

I think meaning is opposite.

Hello! Thank you very much for your contribution and interest in helping improve the Quartz community.
After a period of dormancy, the Quartz project is back under steady maintenance by multiple volunteers, who are working to once again handle contributions such as yours.
We notice that your contribution was made without use of the DCO feature (the sign-off feature on commits via the -s option). Can you please update your PR with commits that use the -s option, agreeing to assign copyright ownership and other terms as described at the contributor agreement referenced here: https://github.com/quartz-scheduler/contributing/blob/main/CONTRIBUTING.md
You can easily add signoff to your previous commits by running (on your PR branch):
git commit --amend --signoff --no-edit
git push -f

Or (for multiple commits):
# change 5 to the number of commits
git rebase HEAD~5 --signoff
git push -f

@akomakom
I created NEW PR because of closed this PR.
https://github.com/quartz-scheduler/quartz/pull/755


Mssql support

I think the orm should include mssql as a supported database type by default instead of doing a custom database setup

there is some WIP here:
https://github.com/UTGuy/mikro-orm-mssql
Going forward I'd like to support it natively, although not a priority.

there is some WIP here:
https://github.com/UTGuy/mikro-orm-mssql
Going forward I'd like to support it natively, although not a priority.

I am actually starting out a new project in about two weeks later which is on mssql and wanted to use mikroorm instead of sequelize but I am not only the sole developer in the project so we are looking for sequelize alternative which supports mssql out of the box

Will try to spend few hours to check how much is actually done and what is the needed effort to support it.

@B4nan  any updates on this

@B4nan any updates

nope
https://blog.sindresorhus.com/issue-bumping-e3b9740e2a0

I must say SQL server has very weird limitations. First I hit the issue with composite FKs that are sometimes impossible to create in a lazy manner due to SQL server trying to be too smart/strict (it does not allow setting cascading). Now I see Cannot insert explicit value for identity column in table 'book_tag2' when IDENTITY_INSERT is set to OFF. 🤷
Why are people using this? :P Seriously, go with postgres people :P
Anyway, I have around 2/3 tests passing, disabled FKs in the schema generator for now, I know what to do to make it work (and it will also allow having FKs in sqlite at least for creating new tables). So still not there, still few days/weeks ahead of me.

yes, Sql server is too smartass .I came up with those problems when i migrated from pg to mssql

Is this is still in progress?  Originally I think it was listed as an issue worth exploring in v5 (https://github.com/mikro-orm/mikro-orm/issues/1623), but its not listed there anymore.  Thanks!

I believe B4nan worked on it in this MR https://github.com/mikro-orm/mikro-orm/pull/1375 guess you could have a look at it if you're interested?

There is no progress, I don't consider this as something important, I gave it a try several times, but as for someone who never used mssql, the way that driver behaves is too much out of space to understand it. The blocker is schema generation and diffing, namely complex composite PKs and FK constraints, as that works differently than the rest of SQL drivers.
As said, there is a WIP PR, feel free to give it a try yourself if it is important to you.
If there would be some company willing to sponsor the driver development, that would be a different story.

I just recently updated those drivers. While schema generation is out of the question the driver does function perfectly fine. I also added a Unicode type to handle nvarchar columns.

I cannot use Micro ORM because it does not support MS SQL

FYI we are quite close to bringing this live. Last missing piece of puzzle is the schema diffing .
With that said, it took a lot of time already for me as well as @UTGuy, so being close does not mean it will happen soon :]
Intereting idea with the bug bounty, it can definitely change the order of priorities. For me this was kind of a black hole for my spare time, so I usually favour issues I can deal with within hours and not weeks :D I think it would be fair to divide that somehow between me and @UTGuy once we finilize this.

About to start a rather large project that relies on a SQL Server DB.. would love to use Mikro ORM, is this driver still a ways out from being pulled in?

Any news about this?

most other orms use tedious package to work with mssql maybe that would help

Will be good to incapsulate tedious into mikro-orm. Is it possible?

After many obstacles, #1375 is near the finish line and will be part of v6.2.

@B4nan Great news, thanks. We are looking forward to testing it.


Unit Tests Fail and TWStoredKeyImportHDWallet Method Does Not Work on Xcode 14.3.1 for iOS in Release Configuration

Environment

TrustWalletCore version: 3.2.13
Xcode version: 14.3.1
Build configuration: Release

Problem Description
In the release build of my code, I encountered an issue where the TWStoredKeyImportHDWallet method did not function as expected. Additionally, when running the unit tests in the TrustWalletCore project for iOS using the latest version of Xcode (14.3.1), the tests fail in the release configuration. Notably, the tests pass successfully when using Xcode version 14.0.1.
Investigation
Upon investigation, I found that the issue seems to be related to the optimization level set for the trezor-crypto target in the release configuration. Specifically, if I set the GCC_OPTIMIZATION_LEVEL to 3 (-O3) instead of the default -Os, the tests begin to pass on Xcode 14.3.1, and the TWStoredKeyImportHDWallet method functions correctly.
Steps to Reproduce

Clone TrustWalletCore repository
Open the project in Xcode 14.3.1
Select the release configuration and set ENABLE_TESTABILITY = YES for the WalletCore target
Run the unit tests
Observe that the tests fail
Change GCC_OPTIMIZATION_LEVEL for the trezor-crypto target to 3 (-O3)
Run the tests again
Observe that the tests pass

Expected Behavior
The TWStoredKeyImportHDWallet method should function correctly, and the unit tests should pass in the release configuration on Xcode 14.3.1 without requiring changes to the optimization level.
Actual Behavior
The TWStoredKeyImportHDWallet method does not function correctly, and the unit tests fail on Xcode 14.3.1 in the release configuration unless the GCC_OPTIMIZATION_LEVEL for the trezor-crypto target is set to 3 (-O3).
Request
Please investigate the issue and provide a fix or guidance on the correct configuration. Thank you.

Hey thanks for the issue, not a big fan of compiling with -O3 for security reason on a cryptographic library, however if it's well supported by trezor, we may want to switch, @satoshiotomakan let's see if pulling upstream change from trezor crypto may solve the problem without change of compiling flag

@subbotkin could you please double check if the issue has gone?

@satoshiotomakan I checked with Xcode 15.0.0, the problem is gone (before the fix, the issue was reproducible with Xcode 15.0.0 too). Thank you!


Self-documenting & simplified config yaml

Configuration
Considerations:

Needs object and comment support (IMO yaml)
Make it very obvious what is enabled and disabled (explicit enabled: true, not a mix of env vars magically turning something on)
Self documenting: structured objects, descriptive names, helpful comments that explain the use case
Avoid reusing the same variable in multiple features
Defaults are visible
All features are laid out, no README.md digging

Example (this is rough, let's debate if we want to explore this fully):
# [Connection to the Bee node]

bee:
  api: http://localhost:1633
  debugApi: http://localhost:1635

# [Server settings]

server:
  port: 3000
  hostname: localhost
  authSecret:
  # debug | info | warn | error
  logLevel: info

# [Automatic stamp management]

# Periodically checks for valid stamps
#
# A stamp is considered valid, when it has enough TTL, capacity
# and its amount and depth parameters match with this config
#
# When none is found, purchases one automatically

stamp:
  global:
    checkFrequency: 60s
    maxCapacity: 90%
    minTtl: 1h
    maxCost: 1 BZZ
  hardcoded:
    enabled: false
    batchId:
  autobuy:
    enabled: false
    depth: 22
    amount: 20k
  autodilute:
    enabled: false
    capacityThreshold: 70%
    maxDepth: 30
  autotopup:
    enabled: false
    ttlThreshold: 4h
    amount: 100k

# [Miscellaneous features]

# Enables resolving CIDs in place of Swarm hashes
cid: true

# Enables resolving ENS domains in place of Swarm hashes
ens: true

# Check reachability of locally pinned content.
# Reuploads when cannot be reached over the network.
reuploadPeriod: 2h

# Adds 'x-bee-node' HTTP header to all responses, which
# exposes the hash of the Bee node overlay address.
# Useful for identifying individual Bee nodes in a cluster
# without exposing identity.
exposeHashedIdentity: false

# Removes swarm-pin HTTP header from requests, in order
# to avoid filling up disk space by public requests.
# Useful when running as a public gateway.
removePinHeader: true

Refactoring
Separate stamp management features. Currently auto-topup and auto-dilute both purchase stamps. In code, implement strategy pattern to clean up and separate concerns. I don't think mutually exclusive features should exist, nor should a feature do partially what the other feature does.
New features
Ceilings
Some situations should require user interaction, e.g. when a stamp grows in depth too much, or if an operation is too costly. E.g. the example config of stamp.global.maxCost: 1 BZZ
Selective or inclusive stamp management
Currently we only consider stamps valid if they match the configured amount and depth. IMO we should extend it to either allow all, or mark stamps with the label property, and manage those in all modes.
Units in config
e.g. 10s, 2m, 80%, 1BZZ
Test configuration
e.g. gateway-proxy -t (nginx) should validate and print in a human friendly way what the configuration is
Deploy configuration on first run

Have a default path for it
Can be specified by -c or --config for cloud deployment
Not mandatory, (re)created with defaults when it does not exist upon launching, so no setup required to "just start" the app

V2
# [Connection to the Bee node]

bee:
  api: http://localhost:1633
  debugApi: http://localhost:1635

# [Server settings]

server:
  port: 3000
  # Required for the bzz.link feature.
  # TODO: #1 Explain bzz.link feature
  # TODO: #2 Do we really need it? Can't we just rely on subdomains?
  hostname: localhost
  # Require authentication header for all requests.
  # This effectively makes the gateway private.
  #
  # May be left empty to disable authentication.
  authSecret: ''
  # Possible values: debug | info | warn | error
  logLevel: info

# [Stamp management]

# Periodically checks for valid stamps.
#
# A stamp is considered valid, when it has enough TTL, capacity
# and its amount and depth parameters match with this config.

stamp:
  # Run periodical automatic postage stamp management job this often.
  checkFrequency: 60s

  # Possible values: hardcoded | autobuy | autoextend
  # May be left empty to disable postage stamp management.
  mode: ''

  # [Hardcoded mode settings]

  hardcoded:
    # Always use this batch ID
    batchId: ''

  # [Autobuy mode settings]

  autobuy:
    # If there are no valid stamps, purchase one with the following amount and depth
    amount: 20k
    depth: 22
    # Trigger purchase when TTL is below this.
    ttlThreshold: 15m
    # Trigger purchase when usage is above this.
    usageThreshold: 70%

  # [Autoextend mode settings]

  autoextend:
    # If there are no stamps to extend, purchase one with the following amount and depth
    amount: 20k
    depth: 22
    # Enable diluting the postage stamp to increase its depth and therefor capacity
    extendCapacity: true
    # Enable topping up the postage stamp to increase its amount and therefor TTL
    extendTtl: true
    # Trigger topup when TTL is below this.
    ttlThreshold: 15m
    # Trigger dilution when usage is above this.
    usageThreshold: 70%

# [Content reupload]

# Periodically checks reachability of locally pinned content.
#
# Reuploads when cannot be reached over the network
# Uses the Bee stewardship API.
#
# May be used to ensure self-hosted content stays online.
#
# TODO: "self-hosted" is probably a wrong term here
contentReupload:
  enabled: false
  reuploadFrequency: 6h

# [Miscellaneous features]

# Enables resolving CIDs in place of Swarm hashes.
#
# e.g. http://bah5acgzaxtfhomziqdigaikb3cfnotehagiuzyprlr6w7uo7lhl3f6ngyq7a.localhost:3000
# will convert the CID to Swarm hash
cid: true

# Enables resolving ENS domains in place of Swarm hashes.
#
# e.g. http://swarm.localhost:3000 will find bzz:// content at swarm.eth
ens: true

# Adds 'x-bee-node' HTTP header to all responses, which
# exposes the hash of the Bee node overlay address.
#
# Useful for identifying individual Bee nodes in a cluster
# without exposing identity.
exposeHashedIdentity: false

# Removes swarm-pin HTTP header from requests, in order
# to avoid filling up disk space by public requests.
#
# Useful when running as a public gateway.
removePinHeader: true


routes not working

hi , I used your template and I replaced my db.json file, but I can't to go the routes of my json file like what your example does
for you its working when I visit this URL https://json-server-in.vercel.app/api/posts
but for me its like below: https://json-serverati.netlify.app/api/categoryList
I appreciate your help.

Hi @atiyehahmadi
Kindly share more details such as your db.json file content or your repository link.


Numpy 2.0 Support

It would be cool if tbparse works with Numpy 2.0.
Currently, this does not seem to be the case. However, it should be quite easy to change this. It might already be enough to use np.nan instead of np.NaN here.
Some more tests and minor fixes might be required though to ensure full compatibility.
In any case support for Numpy 2.0 would be highly appreciated as Numpy 2.0 will likely become the default in the future and will also be required by more and more third-party packages.

Thanks for the information! You're right that the simple change will do the trick.
I've pushed a fix, and the latest commit (currently require tb-nightly) should now support Numpy 2.0.
We'll need to wait for the tensorboard 2.17.1 patch release (source) before we can remove the tb-nightly dependency.

Fixed in v0.0.9 on PyPI.


Error unreadable: daterangepicker.

File to import not found or unreadable: daterangepicker.
Load paths:
CompassRails::SpriteImporter

Hi @Frank004 , does this still happening?


fix: Update ed25519-dalek to 2.0.0-pre.0 and resolve breaking changes

Description
This fixes a dependency conflict with zeroize that you will likely encounter in the future. Feel free to table this PR since this is a change to a cryptographic library until you need it/can vet, but we need it downstream because we are relying on sqlx 0.7.0-alpha.1 which provides a way for us to refresh the token provided to the connection pool for our AWS RDS IAM authentication usage.
The following dependency conflict will be encountered if you try to upgrade to sqlx 0.7.0-alpha.1. This stems from https://github.com/dalek-cryptography/curve25519-dalek/issues/362 which binds zeroize to <1.4 due to requiring rust 1.51+. Resolving this requires upgrading ed25519-dalek to 2.0.0-pre.0 which has these breaking changes: https://github.com/dalek-cryptography/ed25519-dalek#breaking-changes-in-200. We should be fine with the MSRV change to 1.60 as the image is currently using rust 1.67.
error: failed to select a version for `zeroize`.
    ... required by package `num-bigint-dig v0.8.2`
    ... which satisfies dependency `num-bigint = "^0.8.2"` of package `rsa v0.8.0`
    ... which satisfies dependency `rsa = "^0.8.0"` of package `sqlx-mysql v0.7.0-alpha.1 (https://github.com/launchbadge/sqlx.git?rev=c17c59fc4c13d5031f05b316ef8a8fb44875a822#c17c59fc)`
    ... which satisfies git dependency `sqlx-mysql` of package `sqlx v0.7.0-alpha.1 (https://github.com/launchbadge/sqlx.git?rev=c17c59fc4c13d5031f05b316ef8a8fb44875a822#c17c59fc)`
    ... which satisfies git dependency `sqlx` of package `echo-server v0.19.3 (/home/wcheng/dev/rust/echo-server)`
versions that meet the requirements `^1.5` are: 1.5.7, 1.5.6, 1.5.5, 1.5.4, 1.5.3

all possible versions conflict with previously selected packages.

  previously selected package `zeroize v1.3.0`
    ... which satisfies dependency `zeroize = ">=1, <1.4"` (locked to 1.3.0) of package `curve25519-dalek v3.2.1`
    ... which satisfies dependency `curve25519-dalek = "^3"` (locked to 3.2.1) of package `ed25519-dalek v1.0.1`
    ... which satisfies dependency `ed25519-dalek = "^1.0"` (locked to 1.0.1) of package `echo-server v0.19.3 (/home/wcheng/dev/rust/echo-server)`

failed to select a version for `zeroize` which could resolve this conflict

How Has This Been Tested?
Tests pass and this is currently running downstream in prod with no issues.
Due Diligence

[ ] Breaking change
[ ] Requires a documentation update
[ ] Requires a e2e/integration test update

Hey @welps, any chance you can bump this to the rc.2 and merge main in.
We migrated terraform state from S3 to Terraform Cloud so don't want state to be messed up after merge.


feature(config): improved error message for invalid angular-cli.json

Earlier invalid angular-cli.json yielded only "Error". Now it prints something like:
Parsing angular-cli.json failed. Please make sure your angular-cli.json is valid JSON. Error:
SyntaxError: Unexpected token s in JSON at position 2
Almost the same message is now also used for the other configuration files (schema and other).
This fixes #2536

#2536 is about npm issues so I don't think it'd help. It's a fine idea though, to improve these messages.

Oh I see, you wanted to say https://github.com/angular/angular-cli/issues/2526! I'll edit your comment.

Yeah, #2526 is the correct one. Sorry for inconvenience.

Seems so. I'll merge soon.


feat(frontend): remove alert banner usage

Motivation
Remove the usage of the temporary alert banner added in #2317.
Notes
This PR do not remove the component itself. Just in case we need it sometimes?

@peterpeterparker careful, it will be auto-removed by the weekly job if it is not used... I know you don't like it but maybe..?

<AlertBanner />

or just comment the entire code of the component and leave a <slot /> ?

The issue is resolved.


code polish

// Describe your PR here; eg. Fixes #issueNo

Make sure that:

[ ] You have read the contribution guidelines.
[ ] You submit test cases (unit or integration tests) that back your changes.
[ ] Your local test passed mvn clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #1316 (a968dfb) into master (902445b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1316   +/-   ##
=========================================
  Coverage     68.90%   68.90%
  Complexity     2048     2048
=========================================
  Files           380      380
  Lines          8153     8153
  Branches        827      827
=========================================
  Hits           5618     5618
  Misses         2123     2123
  Partials        412      412

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 902445b...a968dfb. Read the comment docs.


Polyfills overwrite the global namespace

The polyfills included in this library overwrites the global namespace. In particular it replaces the Promise object with a version that does not have the .finally() method. This breaks our app which expects this method.
Could you change the build setup so the bundled polyfills doesn't change the global namespace (perhaps by using @babel/plugin-transform-runtime)?

Actually, after some experimenting, I can see we get significant space savings if data-autocomplete2 is built without polyfilling (the polyfills seems to make up around half of the compiled module size).
What do you think about adding additional build outputs that does not include polyfills, like this: https://github.com/Jobindex/dawa-autocomplete2/commit/1eee54de2bed78d0a38116664f0a279d663d7c89.

It is definitely not the intention that the included polyfills overwrite the global Promise object. I'll take a look at this.

So I have looked further into this. It would seem that core-js overrides any existing Promise. I was not aware of that.
We currently use the preset-env babel plugin to polyfill anything not supported by IE11. However, this pollutes the global namespace.
Using transform-runtime instead together with core-js version 3 apparently rewrites the code to use imports instead of polluting the global namespace. That would be much better - however, it seems to me that it imports EVERYTHING, including stuff already supported by IE11, adding further unneccessary bloat to the code size. I cannot seem to find any plugins combining the functionality of preset-env and tranform-runtime.
I can definitely see why you would want a build without polyfills. This will be provided.

I published version 1.0.2. Files built without polyfills is in the /dist/js/unfilled folder, or via CDN:
http://cdn.aws.dk/assets/dawa-autocomplete2/1.0.2/unfilled/dawa-autocomplete2.min.js

Thank you for adding an unpolyfilled version. That solves our issue :+1:


/grading does not return adjustments

Expected:

Actual result:

I'll look into this tomorrow

@remo5000 The grade here is post-adjustment. Autograder/adjustment breakdown is available for GET /grading/submissionId. Is this behaviour okay?

Ah yes my bad. I'll look into it.

After #180 is merged, grade will be autograder-awarded grade and adjustment is staff adjustment


Weight access

Hi,
downloading the weights apparently is only possible after access is requested. I did so several days ago already. However, nobody seems to confirm. Is this repo still maintained or is anyone still checking the access requests? Otherwise, are there other ways to get the weights?

https://github.com/make2explore/Real-Time-Hand-Pose-Estimation-on-Jetson-Nano/blob/main/Pre-Trained Models/trt_pose_hand/resnet18_baseline_att_224x224_A_epoch_249.pth
You should be able to download it from here :)

Thanks @gulati-parth !

these aren't the same pth files that are listed in the installation directions, is there a way to get  the correct one?

Hi,
I'm trying to use this weights, and I get following output:
ile "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 2041, in load_state_dict
    raise RuntimeError('Error(s) in loading state_dict for {}:\n\t{}'.format(
RuntimeError: Error(s) in loading state_dict for Sequential:
	size mismatch for 1.cmap_conv.weight: copying a param with shape torch.Size([18, 256, 1, 1]) from checkpoint, the shape in current model is torch.Size([21, 256, 1, 1]).
	size mismatch for 1.cmap_conv.bias: copying a param with shape torch.Size([18]) from checkpoint, the shape in current model is torch.Size([21]).
	size mismatch for 1.paf_conv.weight: copying a param with shape torch.Size([42, 256, 1, 1]) from checkpoint, the shape in current model is torch.Size([40, 256, 1, 1]).
	size mismatch for 1.paf_conv.bias: copying a param with shape torch.Size([42]) from checkpoint, the shape in current model is torch.Size([40]).

So I suspect, those are not correct weights?

 could it be that the file was loaded in a different way, and the unpickling fails because of this?


Update Understanding-ROS2-Topics.rst

Introduce bw and find commands to understanding topics tutorial

@fujitatomoya could you please review the updated changes

@clalancette @ahcorde either of you can also take a look at this?

@mnhaqq github workflow is failing with https://github.com/ros2/ros2_documentation/actions/runs/11225480787/job/31204930999?pr=4803 , can you fix it?

@fujitatomoya I've fixed it

@clalancette requested changes have been made


Setting some standards

not too usefull, but nice to have

Thank you for your contribution @tamirfri ! You put some fantastic job there, and it's exciting to see that 🤩
That being said- it's pretty huge, and you're addressing multiple issues at once. As a general rule- unlike commits, PRs are usually addressing one issue (and commonly contain around 1+- commits).
I suggest we'll split it into the following:

go upgrade
gocritic linter
no prints without justifications
etc.

also, please rebase with the master branch. I fixed some issues related to the checks

Hi @tamirfri, did you have a chance to review my feedback?
I think you can relatively quickly take one from the good first issue list.
Specifically, #132 #118 which were your ideas :)


Literature References

Hi!
Not so much an issue as a suggestion: Adding references to the literature - and maybe arXiv links (??)
Best Regards

Clint

They're already there in the readme, not arxiv links but links to the original pubs


The plugin doesn't work with Notepad++ v 7.6.3

Recently I uninstalled Notepad++ 32bit that has MarkdownViewer++ and I installed Notepad++ x64 version, but the plugin MarkdownViewer does not work. I tried to install it from Plugins admin and manually by downloading it and adding MarkdownViewerPlusPlus.dll to plugins folder. In both cases, the plugin doesn't appear in the toolbar.

@ethren ,
Notepad++ v7.6.3 has a different plugin structure than v7.5.9 and earlier: each plugin gets its own subdirectory of the plugins folder.  Instead of putting it in directory\plugins\MarkdownViewerPlusPlus.dll, put it in directory\plugins\MarkdownViewerPlusPlus\MarkdownViewerPlusPlus.dll

@pryrt
Thank you very much, that solved it. I didn't know about that


Ensure .asType.toType is called in a safe manner

See https://github.com/47deg/iota/pull/24
I've followed up back asking on the scala/contributors gitter.

This is used in reflection API right? Because I was testing in macro API.

It's used in both! There are direct tests for the reflective helpers, and those same methods are used "transitively" by the macro methods, which are also tested.


Loading graph limited by single CPU core, parallelize?

Loading 16 million triples from a 3.6 GB N-Triples file takes 40 seconds with a LightGraph with a single CPU core maxed throughout on an Intel Core i9 12900k with 24 threads.
Is it possible to parallelize this somehow? Given that N-Triples files can be arbitrarily split, they could be partitioned into n blocks, which are then loaded in parallel.
Or the SPO wrapper could be initialized in parallel to the OPS wrapper when using a FastGraph.

Re. LightGraph, there is not much that can be parallelized from my point of view (I may be wrong). One thing that could be explored would be to not block on IO, but rather do the indexing during IO latency (e.g. using async code). As I understand @Tpt is working on a new parser infrastructure that would make this possible.
Re. FastGraph, yes, the creation of all indexes could indeed be parallelized.


fix: [CodeQL] SM01524 - Information exposure through a stack trace

Fixes # 4342
#minor
Description
This PR fixes the SM01524 alerts which were related to information exposure through a stack trace in microsoft/microsoft/botbuilder-js/botbuilder-js.
To fix it, we suppressed the alert by following the CodeQL documentation and adding the proper comment.
Specific Changes

Add the comment lgtm[js/stack-trace-exposure] to line 405 in microsoft/microsoft/botbuilder-js/botbuilder-js.

Testing

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage remained the same at 84.622%

Files with Coverage Reduction
New Missed Lines
%

libraries/botbuilder-lg/src/templateExtensions.ts
1
84.48%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
19935

Relevant Lines:
22322

💛  - Coveralls

/promoted 4362