Clean-up manual pip install

When  I manually install cmakedoc the installation appears to work, but I get some errors in the logs (vide infra). It would be good to fix/remove these errors from the logs.
ryan@babyruth:~/CMakePP/CMakeDoc$ python3 -m venv virt-env
ryan@babyruth:~/CMakePP/CMakeDoc$ source virt-env/bin/activate
(virt-env) ryan@babyruth:~/CMakePP/CMakeDoc$ pip3 install .
Processing /home/ryan/CMakePP/CMakeDoc
Collecting antlr4-python3-runtime (from CMakeDoc==1.0)
  Using cached https://files.pythonhosted.org/packages/56/02/789a0bddf9c9b31b14c3e79ec22b9656185a803dc31c15f006f9855ece0d/antlr4-python3-runtime-4.8.tar.gz
Building wheels for collected packages: CMakeDoc, antlr4-python3-runtime
  Running setup.py bdist_wheel for CMakeDoc ... error
  Complete output from command /home/ryan/CMakePP/CMakeDoc/virt-env/bin/python3 -u -c "import setuptools, tokenize;__file__='/tmp/pip-req-build-37yw35o7/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" bdist_wheel -d /tmp/pip-wheel-bnxgwait --python-tag cp37:
  usage: -c [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
     or: -c --help [cmd1 cmd2 ...]
     or: -c --help-commands
     or: -c cmd --help

  error: invalid command 'bdist_wheel'

  ----------------------------------------
  Failed building wheel for CMakeDoc
  Running setup.py clean for CMakeDoc
  Running setup.py bdist_wheel for antlr4-python3-runtime ... error
  Complete output from command /home/ryan/CMakePP/CMakeDoc/virt-env/bin/python3 -u -c "import setuptools, tokenize;__file__='/tmp/pip-install-seo90jl9/antlr4-python3-runtime/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" bdist_wheel -d /tmp/pip-wheel-dqaujyzw --python-tag cp37:
  usage: -c [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
     or: -c --help [cmd1 cmd2 ...]
     or: -c --help-commands
     or: -c cmd --help

  error: invalid command 'bdist_wheel'

  ----------------------------------------
  Failed building wheel for antlr4-python3-runtime
  Running setup.py clean for antlr4-python3-runtime
Failed to build CMakeDoc antlr4-python3-runtime
Installing collected packages: antlr4-python3-runtime, CMakeDoc
  Running setup.py install for antlr4-python3-runtime ... done
  Running setup.py install for CMakeDoc ... done
Successfully installed CMakeDoc-1.0 antlr4-python3-runtime-4.8

This is a common problem with pip manual install, the wheel package must be installed prior to manual installing a package, instructions will be updated shortly


[Brick] We need a widget that handles and displays data from futures

Thanks to https://github.com/feenkcom/pharo-futures we have future combinators and an asynchrous mechanism to get the result of a future. Now we need a way to integrate it safely in the UI so that the result of the future could be processsed in the UI process.

@syrel it looks like the examples referenced in the book weren't checked in.


Bump helm version, improve install, add chart target

Various helm-related quality-of-life fixes

/override pull-cert-manager-csi-driver-spiffe-verify
Obviously not related to the changes I've made


Polygon support

Closes #212
Based on the network you're connected to:

Etherscan URLs are properly generated
Native token name and symbol update appropriately
Toll and payment summary is shown when toll is non-zero (currently only on Polygon)

Features:

Send page now always defaults to the native token (mirrors Uniswap's behavior)
Send page now has smarter balance checks: if sending native token, ensure amount + toll <= wallet balance, if sending other tokens, check each separately

Style changes:

Adds logos to the network selector dropdown
Update ETH logo to match Uniswap's for consistency across apps (before we used a black diamond one instead of this purple circle one)

TODO:

Sometimes the payment link amounts are parsed but then the amount becomes undefined, and there's an error in the console. @radchukd I know you were recently looking at payment link code recently so let me know if you see what the issue is here
FAQ item on the toll/fee (this should be linked to in the Umbra Fee tooltip). @apbendi do you mind writing this one up?
Proper ENS resolution, which is a bit tedious since it will require some API changes to umbra-js, so that will come later (possibly in this PR depending on how fast it gets merged). Currently our umbra-js helper methods take a provider input and use that for everything (ENS lookup, CNS lookup, reading the chain, etc). But now they need to take two providers: one for mainnet (always mainnet, unless we're on Rinkeby, to facilitate dev/testing) and one for everything else

All of these TODOs can arguably be done in a separate PR, which is why this is not marked as draft

Hi, I have found what's causing the values to reset.
Basically, tokenOptions aren't empty, when the relayer is not loaded.
To fix:
Add if (!relayer.value) return []; before this line:
https://github.com/ScopeLift/umbra-protocol/blob/4290cc10bf7564baffebcf8b692c552881586c2e/frontend/src/store/wallet.ts#L356
And tokenOptions.value.length && to this line:
https://github.com/ScopeLift/umbra-protocol/blob/a535725c90241d5e77ab3116d6f07c8ec6ce54cb/frontend/src/pages/AccountSend.vue#L228

And tokenOptions.value.length && to this line:

Ah yep, this check seems sufficient to resolve it. Even if we don't have a valid relayer, we still want to support the native token so I don't think we want (or need?) that first change of if (!relayer.value) return [];

Converting this to draft until we get a Polygon subgraph deployed, since directly querying events is already no longer viable

Minor, but I wonder if we can think of a different icon to use for Rinkeby. I found it a bit weird/confusing to see two Ethereum icons. Have to noodle on options 🤔

Fixed in 90347e4 by stealing Uniswap's idea of only showing testnet options if you're already connected to them

There seem to be floating point precision issues with calculating totals after fee. This didn't happen with every value, so try different amounts to reproduce.

Fixed in dc34d0d

other fixes to come....

Pushed commit 838beed which adds subgraph and starts the work for #253

MATIC withdrawals seem to be using mainnet gas estimates.

Fix pushed in f760d97

Reverse resolution in the Receive table's "Sender" column still seems to be using Rinkeby when connected to Rinkeby, as in the screenshot below:

Fixed in e6d358e

Remaining items:

Warn if user is not on L1, and the address the ENS/CNS destination resolves to is a contract
Add FAQ item on the toll/fee, and link to it from the Umbra Fee tooltip on the Send page

Both of the above remaining items are done in the last commit, so I'd say this PR is ready for review and some thorough QA testing!


Update wording on emails

As per doc:

Email sent when a user forgets their password.
Email sent when a user invites another user to the platform.
Email sent to confirm a ticket request has been received.
Email sent to confirm a ticket has been approved by champion
Email sent to confirm a ticket has been cancelled
Email sent to parent when they are invited to become a parent of a ninja
In the case that there is a parent of a child who has already signed up and has a profile - the parent can invite that child to link up with their account
Email sent to user when they are asked to accept a badge
Email sent to champion when user leaves Dojo
Email sent to champion when user requests to join a Dojo

Technical spec
Doc is here https://docs.google.com/document/d/1OBw9mfUPhlbAsMOnwHL09WkaFnJtqF0f9Xz6VV7S2L0/edit
It needs to be compared with the templates in these two places
https://github.com/CoderDojo/cp-users-service/tree/master/email-templates
https://github.com/CoderDojo/cp-dojos-service/tree/master/email-templates
For further clarification ask me.

@tangentfairy doc permission needs to be changed. can't open the google doc link.

I will give access to whoever wants to assign themselves the issue

@tangentfairy requested access. will be updating email templates that doesn't require me to create a new ejs variable as i've no clue how to create one.

Email sent when a user forgets their password.[DONE]
Email sent when a user invites another user to the platform.
Email sent to confirm a ticket has been approved by champion
Email sent to confirm a ticket has been cancelled
Email sent to parent when they are invited to become a parent of a ninja
In the case that there is a parent of a child who has already signed up and has a profile - the parent can [DONE]
invite that child to link up with their account[DONE]
Email sent to user when they are asked to accept a badge[DONE]
Email sent to champion when user leaves Dojo[DONE]
Email sent to champion when user requests to join a Dojo[DONE]

@rosalanghammer To review

@Wardormeur We can close as a re-review has been done as features are built - I will do another full review of all in April with Community team. Are cp-users and cp-dojos the only places where email templates are stored?

They are stored together in crowdin, but imported/used (emails wise) by both dojos & users, yes.


fix: can't connect to spark thrift server

solve https://github.com/mwhitaker/dbt-action/issues/34

Thanks !! It is working well now.

Thank you for the pull request. I rebuilt the Docker image and uploaded it to the Docker hub.
Can you please let me know if your workflow now runs before I merge in the PR?

Thanks !! It is working well now.


AMBARI-24727 - Autoscaling based on metric alerts

What changes were proposed in this pull request?
Add simple Ambari Metrics client to ambari-commons which can be used from ambari alert python scripts to query metrics.
How was this patch tested?

Create a source based alert
Write a python script which pulls metrics using the client
Deploy Ambari and copy the alert script source to the stack code
On Ambari Alerts UI check the alert is running

Do the same steps when AMS

use https
has more than one collector in the cluster and stop/start different collectors

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/4147/
Test FAILed.
Test FAILured.

@kasakrisz : This is good contribution to common! Other services can reuse code.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/4156/
Test PASSed.


Bifrost integration with Moonbeam [xcBNC and GLMR]

Description
Bifrost integration with Moonbeam [xcBNC and GLMR].
We add interfaces in the config package to adapt to a new param-function set of the token and assetRegistry pallets
Checklist

[x] If this requires a documentation change, I have created a PR in moonbeam-docs repository.
[x] If this requires it, I have updated the Readme
[x] If necessary, I have updated the examples
[x] I have verified if I need to create/update unit tests
[x] I have verified if I need to create/update acceptance tests
[x] If necessary, I have run acceptance tests on this branch in CI

Please don't forget that we need a balance for acceptance tests or we should skip them.


Add option to disable/limit threads

We updated to a more recent version of the closure compiler and we're seeing it thrash our development machines. I believe this is happening because closure is using a ton of CPU, I'd like a way to limit the CPU usage by either disabling or limiting the number of threads used.

IIRC the compiler is essentially single-threaded. Can you provide more details about the thrashing you've seen? Which versions did you update from and to?

It's true - like any workhorse compiler, closure-compiler makes my macbook pro sounds like it is getting ready for a takeoff. But that's any compiler ...

@struys Compiler.java has a diableThreads() option but I'm not sure it will help.
@ChadKillingsworth I'd be more concerned if we are using a ton of memory.

@struys You can pass the flag --tracer_mode=TIMING_ONLY to the compiler to get some timing data for a compilation job, and then compare the old version to the recent version to see if anything jumps out.
Closing this issue since there is no actionable information here. If you find some slowdown for some specific pass, and you can give us instructions to reproduce, then we can look into it.

(I work with @struys)

Can you provide more details about the thrashing you've seen?

We're using plovr.
We see 22 concurrent plovr.jar processes, with 1013 threads totall (~44 each).

How much memory was the compiler using?

The processes are using ~150MB resident memory, each.
This leads to our build beeing oomkilled if even three are running concurrently, on a 60GB machine.

Which versions did you update from and to?

From: v20150729   To: v20151216
The TIMING_ONLY run didn't show anything notable.

The cause is the new Executors.newCachedThreadPool, on this line: https://github.com/google/closure-compiler/commit/83c99457c699c4fc63f02d0e8c21f7b7b7e5b30b#diff-4d24c1568736e3d7a134144ed11286aaR46

We plan to submit a patch for this and would like some guidance; how would you like to see this configured. The current thinking is to make the number of threads default to the number of CPU cores, and make this ratio tunable (something like --threads-per-cpu 2).

Interesting, 44 each sounds a a bit ridiculous. I thought that particular commit shouldn't cause more threads to be created. We were using Executors.newCachedThreadPool already.

Sounds like this is a plovr issue. As stated the compiler should only need using ones thread per compilation job.  Embedders are free to start as many parallel jobs are they wish / think they can handle.

I ran into a similar issue. In your case, Plovr must be starting and killing multiple compilation jobs (different Compiler instances), possibly sequentially.
Perhaps Plovr is interrupting the thread. That's what I'm trying. But Closure Compiler doesn't have a mechanism to cancel an ongoing compilation - it merely forgets the thread is running when interrupted. See CompilerExecutor.
I'm experimenting with Compiler.disableThreads() to work around this, but may consider a PR to properly interrupt compilation, some volatile boolean in Compiler which causes a commonly access method such as NodeTraversal.traverse to fail propagate some runtime exception, perhaps.

I think to interrupt, you may just be able to report an error to the compiler, then the compiler will stop before the next pass starts unless you are running in "ide mode":
https://github.com/google/closure-compiler/blob/8a468ed4abb4ececc5f24928aac2f8c354fea54e/src/com/google/javascript/jscomp/PhaseOptimizer.java#L218

Thanks. I need something more prompt, so I extended Compiler, overrode a bunch of public/protected methods, threw a RuntimeException and caught it higher up. Works well, but there'll be some fallout when I next update the compiler version probably. I think a PR for an API to interrupt compilation is probably to specific to my own uses, so unless you say otherwise I'll leave it at that.
Also see https://github.com/google/closure-compiler/issues/1822

Coming back to this as I'm investigating something similar internally at Google. So between v20150729 and v20151216 something did change: https://github.com/google/closure-compiler/commit/73eb61bbf8523c7196c2c973ef108232e5cc7262
I changed the CompilerExecutor from a static variable to an instance variable.  However, I don't think that should affect the total number of threads though. It's still unclear to me why tons of threads were created.
In an upcoming change I'm changing newCachedThreadPool to newSingleThreadExecutor anyway.


Can't accept Android SDK licenses in Azure pipeline

`trigger:

master

stages:

stage: AndroidStage
dependsOn: []
displayName: Android
jobs:

job: AndroidJob
displayName: Android
steps:

task: FlutterInstall@0
displayName: "Install Flutter SDK"
inputs:
mode: 'auto'
channel: 'stable'
version: 'latest'

task: FlutterCommand@0
displayName: "Run Flutter diagnostics"
inputs:
projectDirectory: '.'
arguments: 'doctor -v'

task: FlutterBuild@0
displayName: "Build application"
inputs:
target: 'aab'
projectDirectory: '$(Build.SourcesDirectory)'
extraArgs: '-t base_app/lib/main.dart'

`
Results in a build failure "To build this project, accept the SDK license agreements and install the missing components using the Android Studio SDK Manager."
It seems impossible to accept the SDK license agreements in the pipeline.

Hi, this is a pipeline bug in their vm. This shouldn't happen on the hosted VMs. Thankfully I never ran into this issue. I'll keep it open if someone from the community could help you.
You can open a bug on Microsoft Git repo https://github.com/microsoft/azure-pipelines-tasks
Also check this https://stackoverflow.com/questions/38096225/automatically-accept-all-sdk-licences

@CJSZ01 Is this solved?


Add support for the NO_COLOR environment variable

Please, add support for the NO_COLOR environment variable, if possible.

Sure, sounds reasonable.

This can be done by using another dependency for colored text instead of the current one.
owo-colors supports the env variable natively and has zero overhead printing colored text.
I can work on this issue if that's ok.

Is it possible, that this has not really been fixed? When I run NO_COLOR=1 hexyl <<< hi I still see colored output. Am I doing something wrong?  That is on hexyl version 0.13.1.

Strange. Doesn't work for me either. Re-opening for now.


Improve sorting by :definition with more than 10 attributes in the list

Fixes a bug described here: https://github.com/ElMassimo/oj_serializers/issues/24

I guess we might just merge this and then QA it in the context of https://github.com/starburstlabs/crm-web/pull/12156 🤔
We might try switching between the fork and the original gem to see the difference during testing.
@tblais1224 what do you think?


⚠ ClamAV has degraded performance

In a3e732f, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 93 ms

Resolved: ClamAV performance has improved in 405de43 after 12 minutes.


media queries

Looks to be working in https://github.com/ardc-fair-checklist/ssg/tree/5f73080258a3ead349a14c7077b68a055ab8f29e, closing


🐛 Include doesn't work for formatter

Environment information
I just want a way to run biome formatter on the files in the include array of biome.json
Reproduction here: https://github.com/anthonyhayesres/biome-format-bug
What happened?
One possible fix is to use biome format ./**/* but that gives spawn E2BIG on a large codebase, making it unusable for my use case. Perhaps we could exclude the path and biome would read only from the include array?
The use case is I want to slowly migrate a monorepo to use biome, so have the biome.json in the root of the project, but only format certain directories, having everything configured in the biome.json file (so, for example, biome IDE plugins would also work out-of-the-box)
Expected result
It should format the files in "includes", and only those files, in a way that gets around the spawn E2BIG issue
Code of Conduct

[X] I agree to follow Biome's Code of Conduct

This should be fixed in the last patch release (v1.5.1). Could anyone confirm that they no longer get errors?

:tada: thank you! I'll test it out today and let you know!

This is now fixed by the lastest reelases (1.5.2). Thanks for your help!


Invalid filtering due to using "RegExp.test()"

After banging my head for most of a day, I've stumbled upon an odd side-effect caused by using "RegExp.text() in select.ts:filter() (line ~515).  Seems RegExp keeps a back reference from the last test, which negates the next test!   Changing the code to use  .match() resolves this issue, at the theoretical expense of performance.
This can be verified / tested using the following plunker
Ng2 test() v match() test
References:

MDN text() - test() called multiple times on the same global regular expression instance will advance past the previous match
S/O (final answer)

components/select/select.ts:  Line 517
Was:       .filter(option => query.test(option.text) &&
To be:      .filter(option => option.text.match(query) &&

@kfbishop https://github.com/valor-software/ng2-select/pull/57/commits
there a lot of commits
from which I will not be able to generate changelog


Revert "OpenBSD support"

Reverts apple/swift-tools-support-core#228
This seems to have regressed the Windows build: https://dev.azure.com/compnerd/swift-build/_build/results?buildId=52599&view=logs&j=73ce2acc-4df7-56ec-1894-6d2e45aae46f&t=b5c3161b-bae5-527a-a0c5-e44be8cd66e3

CC: @3405691582

@swift-ci please test

I can fix forward if you'd like.

I think that #238 should actually fix it forward.


Use rust-xdg for cache creation

Pretty small PR that closes #10.
I believe this PR also fixes a bug you might not of noticed, where if a user changed $XDG_CACHE_HOME, tealdeer would still create the cache under ~/.cache. Correct me if I'm wrong though.
I've also gone through and removed the spaces like you said.

Coverage remained the same at 100.0% when pulling 5a133857322b2befea2bbdc0e28ab3109527e40b on SShrike:xdg-basedir into baa24c405a9530e89ac4f84630728edd3a7248ce on dbrgn:master.

Coverage remained the same at 100.0% when pulling 2f4500a113b9b2b568aa1570380b7f567f82f103 on SShrike:xdg-basedir into baa24c405a9530e89ac4f84630728edd3a7248ce on dbrgn:master.

Obligatory :tada:


Pinned post for Homepage Timeline

enhancement: Pinned post for Homepage Timeline.

This option should only be available to admins.


Cant send xrp

Im a user and when trying to type xrp send address symbols dont type . Pasting address does not work. When scanning QR code "ripple:" is automatically added to address and wont allow to delete, backspace nor cut out. If left as is invalid address is produced.

There should be no symbol in a ripple addresss.
Can you send the qrcode and tell us where you got it from so we can check the parsing?

Address:
rwfGzgd4bUStS9gA5xUhCmg1J86TMtmGMo?dt=51307465
On Dec 26, 2017 8:46 AM, amougel<EMAIL_ADDRESS>wrote:
There should be no symbol in a ripple addresss.
Can you send the qrcode and tell us where you got it from so we can check the parsing?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/LedgerHQ/ledger-wallet-ripple/issues/28#issuecomment-353964960, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AhPrjsDfFhGNvgd9se59A3eEdTjtUPESks5tEOqtgaJpZM4RMvmx.

rwfGzgd4bUStS9gA5xUhCmg1J86TMtmGMo?dt=51307465
Shapeshift

rwfGzgd4bUStS9gA5xUhCmg1J86TMtmGMo <-- this is the address you have to copy or type to the recipient field
51307465 <-- this is the destination tag that you can enter by selecting "advanced mode"
Thanks for the qrcode.

thanks


Include Solar Mass Constant

I often feel the requirement of solar mass constant in scipy.constant whenever I do Astronomical data analysis.
It would be really better if we have that constant too.
The value of Solar Mass is 1.9884099e+30 with an uncertainty of ±0.00007.

#12331
documentation build is failing due to this:
ImportError: cannot import name 'signature_from_ast' from partially initialized module 'sphinx.util.inspect' (most likely due to a circular import)

Feels like this is a better fit for astropy which it already includes the constant as astropy.constants.M_sun

I agree but it's not very efficient to import another library just for one constant.

Feels like this is a better fit for astropy (see astropy.constants) which it already includes the constant as astropy.constants.M_sun

I agree but it's not very efficient to import another library just for one constant.

A different question would be why stop here? Why not add all of the Astropy constants to SciPy?
A metric I've seen used in other Issues is "does this have value outside of a single domain" which I'm not sure this meets. That being said I'm new and not an owner.

#4943, #7451, #7132, #5404 are past similar discussions.  Since this is already in astropy, we have in past declined to add this.  I think we probably want to stick with that discussion.

@Bhavesh012 Sometimes I feel the same way, but SciPy does not intend to be a one-stop shop for everything. So I think that in this case, it is more appropriate to import from Astropy. Thanks for the suggestion.


Implement update attributes for objects

Ugh, the build failed due to #114 not being merged :-/

I'll rebase when that merges :)

I've replaced #114 with #122 that has been merged so you're good to go for rebasing this PR :shipit:

@baloo Sorry for the annoyance but could I bother you with squashing these two commits? :pray:  Maybe it's minor but it's good for git bisect if each commit works and passes the CI.
After that I'll make sure to merge it ASAP :)

Thanks for everything! 👋


Why not just use timestamp for initiated field in the DogeConnect: Payment Protocol

What do you think the pros and cons are between timestamps and ISO 8601 (international date standard)?


Adding memModel.score method

It would be nice to have methods to evaluate memModels.

This functionality will be hard to automate as memModels work in Python and SQL. Users can do it easily with the .predict or .predict_sql functions.


Fix: Added missing materialized view function and fix clustering key...

…nd fix cluster key order positions

+1


Run a linter in the CI

ATM no linters are set, anything will do for now. Code could be improved later

hi the linters are enabled for both pull and push in the ci , https://github.com/qustavo/sqlhooks/pull/49 please do review the PR when you have few mins.

thanks, let's continue the conversation on #49


Server side Accounts.createUser

This PR introduces the Accounts.createUser function, tests, and beginnings of the DBDriverInterface, and a variety of minor fixes.

Coverage decreased (-0.1%) to 89.868% when pulling dcae22cb5258d7bb6f721656b4ca60bb34526538 on create-user into 5d2086f1cf61d37de381a65171af2dbeea3cd8cf on devel.

Good to merge IMO.


Broken on Ansible 2.11.6 / Jinja2 3.0.3?

Hey,
I just cloned the master branch and discovered that the deployment of the hosts file failed:
I execute the role as the following:
# ansible-playbook playbook/hostsfile.yml -e "hosts_inventory_to_hosts=true"

The Error:
TASK [system_hosts : Edits the hosts file in /etc] ****************************************************************************************************************
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ansible.errors.AnsibleUndefinedVariable: 'dict object' has no attribute 'ipv4'
fatal: [host1.example.com]: FAILED! => {"changed": false, "msg": "AnsibleUndefinedVariable: 'dict object' has no attribute 'ipv4'"}
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ansible.errors.AnsibleUndefinedVariable: 'dict object' has no attribute 'ipv4'
fatal: [host2.example.com]: FAILED! => {"changed": false, "msg": "AnsibleUndefinedVariable: 'dict object' has no attribute 'ipv4'"}

The full traceback is:
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/ansible/template/__init__.py", line 1100, in do_template
    res = j2_concat(rf)
  File "<template>", line 108, in root
  File "/usr/local/lib/python3.6/site-packages/ansible/template/__init__.py", line 265, in wrapper
    ret = func(*args, **kwargs)
  File "/opt/ansible/collections/ansible_collections/ansible/netcommon/plugins/filter/ipaddr.py", line 560, in ipaddr
    elif not value or value is True:
  File "/usr/local/lib/python3.6/site-packages/jinja2/runtime.py", line 903, in _fail_with_undefined_error
    raise self._undefined_exception(self._undefined_message)
jinja2.exceptions.UndefinedError: 'dict object' has no attribute 'ipv4'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/ansible/plugins/action/template.py", line 146, in run
    resultant = templar.do_template(template_data, preserve_trailing_newlines=True, escape_backslashes=False)
  File "/usr/local/lib/python3.6/site-packages/ansible/template/__init__.py", line 1137, in do_template
    raise AnsibleUndefinedVariable(e)
ansible.errors.AnsibleUndefinedVariable: 'dict object' has no attribute 'ipv4'
fatal: [host1.example.com]: FAILED! => {
    "changed": false,
    "msg": "AnsibleUndefinedVariable: 'dict object' has no attribute 'ipv4'"
}

Removing cached facs or direktly trigger ansible.builtin.setup as pre_tasks changed nothing.
Proof that the dict object exists:
# ansible -m setup --tree facts/ GROUP
# cat facts/host1.example.com | jq . -C | grep '"ipv4"' -A 5
      "ipv4": {
        "address": "<IP_ADDRESS>",
        "broadcast": "<IP_ADDRESS>",
        "netmask": "<IP_ADDRESS>",
        "network": "<IP_ADDRESS>"
      },
--
      "ipv4": {
        "address": "<IP_ADDRESS>",
        "broadcast": "",
        "netmask": "<IP_ADDRESS>",
        "network": "<IP_ADDRESS>"
      },

# ansible --version
ansible [core 2.11.6]
  python version = 3.6.8 (default, Sep 12 2021, 04:40:35) [GCC 8.4.1 20200928 (Red Hat 8.4.1-1)]
  jinja version = 3.0.3
  libyaml = True

Can anyone reproduce this error?

Downgraded Jinja2  to ``jinja version = 2.11.0``` - changed nothing

I think my problem is related to different interface names

one hosts (engine) = eth0
the other (node) = enp1s0

In my case this are an oVirt node and oVirt engine.


Missing precise specification of method signatures and visibility

The method signatures should be clearly shown as bool ShouldSerialize«PropertyName»() and void Reset«PropertyName»(). It should be stated and shown that the members may be private (because the Designer will still see them).
For example, the members in https://github.com/binki/ShouldSerializeResetPropertyIde0051/blob/971f524e347c472da9157a6048c88335c82f5fe6/ShouldSerializeResetPropertyIde0051/UserControl1.cs are discovered by the designer properly.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e320c305-0aa7-0fd2-8c95-61c5409b00a9
Version Independent ID: 6c4a2a9e-182d-74fc-fe35-add388561217
Content: Defining Default Values with the ShouldSerialize and Reset Methods
Content Source: docs/framework/winforms/controls/defining-default-values-with-the-shouldserialize-and-reset-methods.md
Product: dotnet-framework
Technology: dotnet-winforms
GitHub Login: @dotnet-bot
Microsoft Alias: dotnetcontent

Thank you for opening this issue. I'll add it to the backlog. You can always submit the fix yourself by editing the original article. Click on the Content Source link at the bottom of your original comment. To learn how to edit, see the Editing files in a repository article from GitHub.
I agree there could be some clarifications there.
Thanks again!


puppeteer 'page.goto()' options

Tell us about your environment:

Puppeteer version: v1.9.0
Platform / OS version: Cent os
URLs (if applicable):
Node.js version: v8.9.3

What steps will reproduce the problem?
I'm testing puppeteer
Please include code that reproduces the issue.
const puppeteer = require('puppeteer');

(async () => {
	const browser = await puppeteer.launch({
		headless: true,
		ignoreHTTPSErrors: true,
		args: ['--no-sandbox'],
		userDataDir: `${__dirname}/profile-dir`
	});
	const page = await browser.newPage();

	var requests = ['http://www.example.com/', 'http://www.example.org/', 'https://www.google.com/'];

	for(var i = 0; i < requests.length; i++) {
		console.log(requests[i])
		await page.goto(requests[i], {
			waitUntil: 'load'
		});
	}

	await browser.close();
})();

I would like to measure the loading time of each url.
How can I get the total load time for each url? Is there an option to do this?
Thank you

maybe something like this will work 🤔
const puppeteer = require('puppeteer');

(async () => {
	const browser = await puppeteer.launch({
		headless: true,
		ignoreHTTPSErrors: true,
		args: ['--no-sandbox'],
		userDataDir: `${__dirname}/profile-dir`
	});
	const page = await browser.newPage();

	var requests = ['http://www.example.com/', 'http://www.example.org/', 'https://www.google.com/'];

	for(var i = 0; i < requests.length; i++) {
        console.time(requests[i])
		await page.goto(requests[i], {
			waitUntil: 'load'
        });
        console.timeEnd(requests[i])
	}

    await browser.close();
})();

http://www.example.com/: 180.522ms
http://www.example.org/: 195.430ms
https://www.google.com/: 2612.013ms

Perfect !! Thanks


Removed unnecessary @discardableResult

Stray @discardableResult annotations removed

While merging this, I might have accidentally pushed the merge back at your analysis-develop branch, instead of at the master branch. If it appears as a pull request, you can ignore it.


Signing PDF unsuccessful with error

I am getting the following error on signing PDF with cms (using example pdf-sign-cms.py)
File "/Users/user/projects/test/.venv/lib/python3.7/site-packages/endesive/pdf/cms.py", line 276, in makepdf
    info = document.xrefs[0].trailer['Info'].objid
KeyError: 'Info

The PDF is generated from Image. view
I am noob to PDF. Is the PDF invalid? (Adobe Acrobat Preflight check does not give any notice)
What can I do to make signing work? or how can I avoid this error or detect this and get meaning message?

Info / Root / Size are required by endesive to work properly, although some programs do not add this information to the created pdf file.
original.pdf is not valid, error(s) :
1.1 : Header Syntax error, Second line must begin with '%' followed by at least 4 bytes greater than 127
1.2.2 : Body Syntax error, Expected 'EOL' before the endstream keyword at offset 495556 but found '101'
1.2.2 : Body Syntax error, Expected 'EOL' before the endstream keyword at offset 1193201 but found '101'
1.2.2 : Body Syntax error, Expected 'EOL' before the endstream keyword at offset 1491454 but found '101'
1.2.2 : Body Syntax error, Expected 'EOL' before the endstream keyword at offset 1687727 but found '101'
1.4.1 : Trailer Syntax error, The trailer dictionary doesn't contain ID
2.4.3 : Invalid Color space, DestOutputProfile is missing
2.4.3 : Invalid Color space, DestOutputProfile is missing
2.4.3 : Invalid Color space, DestOutputProfile is missing
2.4.3 : Invalid Color space, DestOutputProfile is missing
7.1 : Error on MetaData, Missing Metadata Key in catalog
1.2.5 : Body Syntax error, Stream length is invalid [cObj=COSObject{4, 0}; defined length=43; buffer2=
endstrea]
1.2.5 : Body Syntax error, Stream length is invalid [cObj=COSObject{7, 0}; defined length=43; buffer2=
endstrea]
1.2.5 : Body Syntax error, Stream length is invalid [cObj=COSObject{10, 0}; defined length=43; buffer2=
endstrea]
1.2.5 : Body Syntax error, Stream length is invalid [cObj=COSObject{13, 0}; defined length=43; buffer2=
endstrea]

What program should I use to validate the PDF? Is there any resources you can recommend for me to read on Info / Root / Size?

In readme.rst are two links - online pdfvalidator and pdftoolbox from apache, and my small wrapper around pdftoolbox in examples folder

As the issue is not caused by endesive, I am closing it.


[Bug] [iOS] SnackBar Color Customization doesn't propagate on iOS

Description
SnackBar colors don't propagate on iOS, as it does on Android
Steps to Reproduce

Open XCT Sample Solution https://github.com/xamarin/XamarinCommunityToolkit
Run on both Android and iOS and note the difference:

Navigate to Views > SnackBar / Toast
Click on the 3rd button, "Show SnackBar"

Expected Behavior
Colors should propagate on iOS SnackBar.
Actual Behavior
Colors don't propagate on iOS SnackBar :(
Basic Information

Version with issue: most recent
IDE: VSMac
Platform Target Frameworks:

iOS:  14.2

Workaround
/
Reproduction imagery
Android (expected behavior):

iOS (buggy behavior):

Reproduction Link
https://github.com/xamarin/XamarinCommunityToolkit

Talked about this with Rachel and looked into it myself. It seems the background color is not hooked up on iOS. @VladislavAntonyuk ?

Please assign it to me. I will take a look


Add support for additional certificates in the generated pongo test image

At PayPal, we have corporate proxies for which IT pre-installs the self-signed certificates in all laptops and working stations.
pongo run fails due to this - with SSL: CERTIFICATE_VERIFY_FAILED - self signed certificate in chain.
To fix this, need to add ce-certificates to the RUN apt install line in the Dockerfile, copy the self-signed certificates to the image, run update-ca-certificates and add ENV REQUESTS_CA_BUNDLE=/etc/ssl/certs/ca-certificates.crt to the Dockerfile.
Need to add support to inject the certificates to the CLI - perhaps this should be in the kong base image even, I'll let the Kong team decide.

why would the REQUESTS_CA_BUNDLE env var be required? isn't that Python specific?

It is Python specific, from my experience each app might behave differently when it comes to certificates, and since Pongo is using httpie which is written in Python, it is required, as Python doesn't use the system certificates by default - it requires explicitly adding them. This can be done using the REQUESTS_CA_BUNDLE env var, or with the certifi module as mentioned in https://github.com/python/cpython/blob/e05a703848473b0365886dcc593cbddc46609f29/Mac/BuildScript/resources/ReadMe.rtf#L22-L34
Note - this might only be required for mac - see https://github.com/python/cpython/blob/e05a703848473b0365886dcc593cbddc46609f29/Mac/BuildScript/build-installer.py#L239-L246

yes, httpie would use it.

so could we add the certs to ./pongo/ca-certs/, and then adapt the dockerfile to copy them in and do the cert dance as described.

hmmm... maybe not. The ./.pongo/ folder is plugin specific, but the generated image is system wide.
So we'd need to add a system-pongo directory for config options.

As Pongo Dockerimage extends Kong - I assume the same will be needed in other images, in which case don't you think  adding the ca-certs in the kong base-image and propagating them as user supplied argument or some other means from every derived tool is better?

hmmm... maybe not. The ./.pongo/ folder is plugin specific, but the generated image is system wide.
So we'd need to add a system-pongo directory for config options.

Does that mean you will add the certificates into the pongo repository instead of letting users pass them as env vars / command line arguments?

But then it might be better to generate a custom Kong image (not a Pongo job), and pass that in as $KONG_IMAGE.
Though https://github.com/Kong/kong-pongo/issues/454 indicates that it might have issues...

But then it might be better to generate a custom Kong image (not a Pongo responsibility), and pass that in as $KONG_IMAGE.
Though #454 indicates that it might have issues...

Sounds legit. #454 would need to be addressed first though.

@tomereli have you considered using the PONGO_DOCKER_FILE environment variable? see pongo build --help.

@tomereli here's a different approach: https://github.com/Kong/kong-pongo/pull/509

httpie becomes optional
curl disables verification during the build

could this work for you?


Changes for reddit share

Added "reddit share". The most difficult part was adding the reddit icon to the font, so I added a readme.html in the fonts folder about how I made the font changes. If you would like the documentation in a different location/form, I'd be happy to accommodate.

Added LinkedIn, StumbleUpon and Email shares.


List of scikits broken

Just wanted to report that the automatic list of scikits at http://scikits.appspot.com/scikits , linked from https://svn.scipy.org/topical-software.html is currently broken, not resolving. Not sure of the status of svn.scipy.org, but in any case the page is still accessible and the list is useful information.

Thanks @rdgraham. @stefanv can we get rid of https://svn.scipy.org?

the page is still accessible and the list is useful information.

There is unfortunately a lot on that page that is outdated. It could use more maintenance. Maybe it should be changed to a plain README in a standalone repo so it's easier to update? A curated list has value, but it's not something I'd like to have on scipy.org anymore or have the SciPy maintainers be responsible for.

#382

Here is a partial list of addresses pointing to the old site:

https://svn.scipy.org
https://new.scipy.org/
https://test.scipy.org/
https://projects.scipy.org/


Aurora 0.17.0 Compatibility changes

Updated the thrift API to be compatible with Aurora 0.17.0 and updated the stubs that were generated.
Updated thrift API calls for those that changed since version 0.16.0 (only kill tasks api changed).

Once this is merged into the master, I'll tag a release V2.0.0 indicating that this is the first release fully compatible with Aurora 0.17.0.

As per our chat.. message params to killtasks  is in 0.18.0:
https://github.com/apache/aurora/blob/master/RELEASE-NOTES.md
lets wait for aurora 0.18.0 release


(programmatically added) destroyed hooks retain on new instances

Version
2.6.10
Reproduction link
https://jsfiddle.net/h86atdq4/
Steps to reproduce
Open linked jsfiddle, open console and click toggle.
What is expected?
That the logged destroyed hook count is always 0 similar to the other hooks
What is actually happening?
The destroyed hook count keeps incrementing as it seems to retain hooks from already destroyed components

Note: I didnt check if this also happens with destroyed hook defined on the component itself

I wouldn't consider it a bug.  If you need to programmatically add some lifecycle hook, you should do that in created hook using $on('hook:xxx) pattern. I do not know why but it is not properly documented so not everyone knows about it.  Example usage:
created() {
  this.$on('hook:mounted', () => {
    // do something when component is mounted
  })
}

And you don't have to worry about cleaning up the events added this way in beforeDestroy hook, Vue will handle it for you

Very interesting, did not know this indeed. I had also asked this on Vue-land discord but unfortunately to no avail.

You shouldn't write to this.$options. It is for reading only. If you want to attach hooks, you should do so using the public API this.$on() or this.$once().

Unfortunately a vue core team member told me on discord that hook: is not a public API thus its not officially supported and shouldnt be relied on. Hence why its not documented.
So still looking for the official way to programmatically add lifecycle hooks.

To clarify, writing to this.$options in a beforeCreate hook is a very common way to manipulate options and it's used by many many plugins, it's not read-only, at least, in beforeCreate as it can still have an impact

It's worth pointing out that the hook: syntax is documented appropriately under Handling Edge Cases: Programmatic Event Handlers.

It turns out (as found by @Remcoman with this jsfiddle https://jsfiddle.net/c61xL8ar/2/) that the memory leak occurs on any programmatically added lifecycle hook if the component you are adding them too already list those lifecycle hooks. Ie in the jsfiddle the AComponent already has a mounted hook, the BComponent already has a created hook. Both are being retained now.
@posva Does this mean its a bug or that we should use hook events anyway?

It turns out (as found by @Remcoman with this jsfiddle https://jsfiddle.net/c61xL8ar/2/) that the memory leak occurs on any programmatically added lifecycle hook if the component you are adding them to already list those lifecycle hooks. Ie in the updated jsfiddle the AComponent already has a mounted hook, the BComponent already has a created hook. Both are being retained now.
@posva Does this mean its a bug or that we should use hook events anyway?

Once again, that example is paving over an object on this.$options. Don't do that. It is a Vue internal property.

@sirlancelot Please read this comment https://github.com/vuejs/vue/issues/10458#issuecomment-528247551 and read this https://github.com/vuejs/vuejs.org/issues/2247
Although I appreciate your time responding to this issue, there is conflicting information here and therefore I am asking the Vue core-team what I should do.
As a library maintainer I am unable to use a feature when I was specifically told not to use it. Not unless a go-ahead has been given to do so anyway. You might not agree with this approach, but you should at least respect it as Im only trying to do my due diligence here.

Understandable. I was rather short in my previous post, and I apologize. I am going to guess that the "has workaround" was added in regards to using $on() & $once() with the hook: prefix.

Hello, is there any way to use this workahound ($once()) in Vue 3.x?


crafting grid item count display issue

Once per second, all of my items in storage show as having double their counts (via crafting gird and wireless grid).  This lasts about 1 or 2 render frames, and the rest of the time they're correct, resulting in an endless flicker.
So far, I haven't been able to induce item loss or duplication.
Removed external storage connections and rebuilt the controller, but no change.
Started only after upgrading to 0.8.7.

Looks like I missed an external storage connection to an RFTools modular storage.  Removed this, and the problem disappeared.
Interestingly, I was also losing items.  Attempted to craft compressed cobble that was in modular storage via the refined storage crafting grid using shift-click for stacks, and managed to convert 8k of cobble into only 4 stacks of compressed (2k worth).  Something is not right...

I don't think you are losing items, it's just a desync issue...

Why did you remove all your comments? Makes it kinda hard for me to debug...

The itemcount display issue is fixed. Were there any other problems you've been having or can I close this?


Add a version badge to the Readme that links the PyPi.

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
[x] I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferrably).
[x] I've written tests to cover the new code and functionality included in this PR.
[x] I've read, agree to, and signed the Contributor License Agreement (CLA).

PR Summary
Adds a version badge to the Readme making it easier to find the package on PyPi
Related Issues
No related issues
Test strategy
Manual verification: check the readme on my branch
It looks like this:

Coverage remained the same at 61.265% when pulling 8f97398b2c810f57651ceee5a1237e430a8ef064 on hockeybuggy:add-a-version-badge into 7dfa7f3fdacdd5f935611147830e03cb32b9ffb8 on slackhq:master.

I didn't check the first checkbox since their isn't a contributing guideline. I made an issue for that in #121
I also didn't check the first checkbox on the issue for the same reason.

Hey, Just following up on my PRs. Does anyone have any thoughts on this?

Looks reasonable to me. Thanks!


Update version to 1.0.23-3 on main

Update version to 1.0.23-3

🚀 [Deployed](https://github.com/Expensify/Expensify.cash
/actions/runs/765130740) 🚀 to
staging on Mon Apr 19 2021 at 22:41:56 GMT+0000 (Coordinated Universal Time)

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Best way to get RGBD?

|---------------------------------|------------------------------------------- |
| Camera Model                        | D435i                                                      |
| Firmware Version                    | <IP_ADDRESS>                                             |
| Operating System & Version  |   Raspbian Buster                                    |
| Kernel Version (Linux Only)    |                                                                |
| Platform                                  | Raspberry Pi                                           |
| SDK Version                            |  2.42.0                                                    |
| Language                                |  {C++                                                     |
| Segment			          |  AR                                                         |
Hello, I am working on a volumetric data transmission over the internet program for AR.
Until now I have been creating a pointcloud and compressing it into a Draco3D file before transmitting it, but this is too resource intensive and slow (a Raspberry pi4 hardly can produce 20 fps at lowest resolution).
My next idea to try is to instead of sending a pointcloud where each vertex is XYZRGB (total of 120b), to send RGBD (32b). This is also very convenient because RGBD can be sent using RGBA video protocols, which offer very good compression. (I will need to map a 32 bit float into a 8b char, but this is no problem since its a minimal loss of precision).
I would like to know what is the best way to get this data without unneeded operations, for example, is it needed to map a pointcloud to the color frame and then calculate the points, which is shown in most examples? This seems unnecessary as each point is XYZ, while I just need the depth and color of each pixel in the image.
I am aware the get_distance(int x, int y) method exists, but I have read in https://dev.intelrealsense.com/docs/rs-measure that calling this function thousands of times per second will not be performant, so that means there has to be a better way.
Any examples or tips would be appreciated.

Hi @Darustc4   There is a discussion in the link below that provides details of a range of resources for the kind of application that you have described.
https://github.com/IntelRealSense/librealsense/issues/6535
Alternatively, exporting a point cloud to a ply file with the instruction save_to_ply can provide a range of options for which elements of the cloud to include and exclude if you need to simplify it.
https://github.com/IntelRealSense/librealsense/issues/7564
https://intelrealsense.github.io/librealsense/doxygen/classrs2_1_1save__to__ply.html
It is also worth mentioning that some RealSense users have dealt with the problem of performing processing operations such as align and post-processing on a low-end developer board by transmitting the raw camera data to the host computer receiving the data and then performing the processing on the more powerful host computer.

Thanks for quick response. Looking into the resources you have linked I gather I can get the raw depth data using:
rs2::depth_frame dpt_frame = frame.as<rs2::depth_frame>();
const uint16_t *dpt_image = reinterpret_cast<const uint16_t*>(dpt_frame.get_data());

And also get the color in a very similar way but instead of unsigned 16 bit integers, you retrieve tuples of 3 unsigned 8 bit integers (RGB).
This is exactly what I needed but now a question appears: Is this depth distorted, or is it already ready to display? I am now skipping creating a pointcloud, mapping the color and calculating it's depth, and I am not sure if these steps correct some internal distortion of the camera or it is just a way to turn the more abstract 16b depth into <x,y,z> points. The code I no longer use is the following:
rs2::pointcloud pc;
pc.map_to(vid_frame);
rs2::points points = pc.calculate(dpt_frame);

If this code makes no important corrections to the depth, then I think everything is good to go.

To the best of my knowledge, the rs2::pointcloud pc process is just generating a 3D point cloud from the depth frame.
https://intelrealsense.github.io/librealsense/doxygen/classrs2_1_1pointcloud.html
The depth data would have undergone rectification inside the camera hardware at the point of capture before being sent along the USB cable to the computer / computing device.


Spike dependency tables for seedlot ETL Tool batch update

Identify and add dependent SEEDLOT tables to be included in the ETL tool mapping settings

https://apps.nrs.gov.bc.ca/int/confluence/display/FSADT2/Dataset+mappings

Duplicate of #1100

Where is this documented?

Hi @SLDonnelly , you can find the complete documentation here (including the Access requirement matrix table for ETL tool credential):
https://apps.nrs.gov.bc.ca/int/confluence/display/FSADT2/Dataset+mappings


Provide a way to start and reset activity def for scripting

@phact Can you elaborate on this a bit? Is it still useful?

Needs info.


cluster: return nullptr when tls shutdown for thread local cluster

Commit Message: cluster: return nullptr when tls shutdown for thread local cluster
Additional Description:
After the tls shutdown, ClusterManagerImpl::getThreadLocalCluster shouldn't access the tls anymore. Add check for tls shutdown and return nullptr when tls shutdown.
Risk Level: low
Testing: unittest added
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
Fixes #29054
Related to https://github.com/envoyproxy/envoy/issues/28395

wait for https://github.com/envoyproxy/envoy/pull/28824 happy on this

/retest

/wait

Fix in the IoUring side https://github.com/envoyproxy/envoy/pull/28824/commits/77f704527d571188bb20f5718d0736a43e59f07d


Made a bat for running tests

Important:
Please review, esspecially if you have a windows computer (i dont know who of you have windows, so I just added all of you for review)
Due to me not having a bat compiler (a windows computer), I have not been able to test the bat file. So before you write a comment, please check it thoroughly. Especially:

Can you start a docker container (using -start flag)
Can you restart an existing docker container (same command as 1. - meaning using the -start flag
Can you run the tests (-run flag)
Can you run a specific test class (writting -run <class_name>)

If you receive issues, please tell me (if they are not easy for you to fix) - if you can fix it and you have a bat compiler, please do. Ask if anything is unclear of how to use the script. See -help flag for help <3
If it does not work, and you can not fix it, we can fix it on a thursday on someones windows computer

@S1monG and @emil-ronkainen
Changes have now been made, according to given feedback. I would appreciate a double check once again

Would be great if anyone could check if it works as intended now, after the fix. Thanks in advance


Add Win and OS X build for nextpnr-generic

This PR adds Windows and OS X recipes for pnr/nextpnr/generic

merged to master


[Deque Analysis] DSpace Green buttons/badges have insufficient color contrast for white text

Deque Analysis Summary
Buttons/badges which use a DSpace-like green background have color contrast issues.  This appears in several locations:

MyDSpace page, "archived" status green badges: Element has insufficient color contrast of 1.69 (foreground color: #e8ebf3, background color: #92c642) Contrast must be 4.5 or more."

Deque issue ticket IDs: 470124

Edit Item page, Metadata tab, "Add" button (both normal and hover over)

Normal button: Element has insufficient color contrast of 2.02 (foreground color: #ffffff, background color: #92c642)
Hover over button: Button text color: #FFFFFF, Background color: #7AA832, Contrast ratio: 2.8:1
Deque issue ticket IDs: 470728, 471447

Edit Item page, Bitstreams tab, "Upload" button (both normal & hover over)

Normal button: Element has insufficient color contrast of 2.02 (foreground color: #ffffff, background color: #92c642)
Hover over button: Button text color: #FFFFFF, Background color: #7EAD34, Contrast ratio: 2.7:1
Deque issue ticket IDs: 470733, 471056

Recommended Fix
Two options.  Either make the green color darker.  Or, just change the text color to be dark instead of light (e.g. #363636 instead of #FFFFFF).  I selected that color based on https://dequeuniversity.com/rules/axe/4.1/color-contrast?application=axeAPI
I think I'd rather switch the text color (and keep the DSpace green) to dark grey/black.  However, I'd leave it up to the develop to change to green if it looks better.
While we are at it, we may want to match up the green color of the "hover over" for (2) and (3).  Changing both to a background of #7EAD34 seems reasonable (as that color works better with #363636 if we choose that for the text)
More Information / Tools

As necessary, see mentioned Issue IDs in our assessment results (requires login): https://axeauditor.dequecloud.com/test-run/0856438a-a19a-11eb-bc31-b7d5be387c86/issues
Consider using Deque's free Chrome plugin to check your work
Deque's color contrast tool: https://dequeuniversity.com/rules/axe/4.1/color-contrast?application=axeAPI

@tdonohue Could you assign me to this issue? My team and I have investigated the accessibility of the system recently, so I guess it will be great to have done this task until we are fresh after our initial analysis.

@tdonohue please assign my colleague @Dawnkai to this task. He is going to provide the PR for this issue. Also when it will be accepted, I kindly ask to give credits for this bug fix contribution to PCG Academia. Thanks


[skip-ci] TMT: Downstream-specific: install builddeps before test runs

TMT tries to run rpmbuild -bp before triggering tests and it fails if builddeps are not installed prior.
Ref: https://artifacts.dev.testing-farm.io/6c690b69-5ef6-45b8-975d-9fcc95ea078e/
This has been fixed in Fedora and should be propagated upstream.
PR Ref: https://src.fedoraproject.org/rpms/aardvark-dns/pull-request/35
Bodhi Ref: https://bodhi.fedoraproject.org/updates/FEDORA-2024-eca8e4f443

Including this commit in #491 . Closing ...


Notification - Messages do not arrive in the order to user B when sent it from user A

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Close the NewDot app.
Send messages in order from user A to user B

Expected Result:
Messages are arriving in the order to user B when sent it from user A
Actual Result:
Messages do not arrive in the order to user B when sent it from user A
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] iOS / native

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/212423044-1a348d61-23d8-4880-a046-c9f54be9d123.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0160b52a996929c6cd
Upwork Job ID:<PHONE_NUMBER>961016320
Last Price Increase: 2023-01-31

I do have the same notifications settings

To confirm, are you able to reproduce this using the steps in the OP @kbecciv ?

@MitchExpensify Checking again, update you shortly.

@MitchExpensify Able to reproduce this issue with device iPhone 8/14.2, build <IP_ADDRESS>
https://user-images.githubusercontent.com/93399543/215121677-6ac85c16-9753-491d-8173-1ff30d962426.MP4

Finally reproduced this, thanks for your patience:

Coming from the Bug Zero SO,  and seeing as this will require backend changes, I'm going to label this internal and demolition as a next step

Note: If this remains internal, it won't require any payment and I'll close the Upwork job accordingly. Will see if @mananjadhav agrees!

Yeah it is fine. I am assuming we won't have any App PR to be reviewed by C+? If that's the case we can close out the Upwork job.

Cool, thanks @mananjadhav
@mountiny I think I missed the eng label didn't I? Is that why you removed the demolition label (Just trying to get an internal engineer assigned)

@MitchExpensify oh yeah sorry we have deprecated a Demolition label per this Whats next post, so I have deleted it.
Can you add Engineering label?
also cc @Julesssss @arosiclair since this is related to notifications

I haven't been able to reproduce on Android yet. There's also an argument for holding this, as improving the threaded/communication notifications might resolve this.

Noting here that we have a similar issue https://github.com/Expensify/App/issues/13250 which is however not lnked ot notifications, but potentially the root cause might be the same. If we could confirm the root cause is same, this issue should be closed in favour of the one I have linked since that older and easier to reproduce

I haven't dug into it too closely, but I'd say there's probably no way to guarantee in-order delivery of each individual notification. But I agree with @mountiny we should probably make sure #13250 is resolved first before digging any further into this. Threaded notifications from https://github.com/Expensify/Expensify/issues/258537 may also improve the UX of this.

Thanks for the context, I think it would make sense to close this one out in favour of https://github.com/Expensify/App/issues/13250 and the threaded notifications and then we can come back to this in case we see this happening even with those aforementioned items fixed. Thanks!

Nice, yeah I agree with closing this 👍

Woooh great!


Support for Github Enterprise

I don't have a GitHub Enterprise account for development or testing.
PR will be welcome on this topic.

Seems like replacing the relevant URLs in the code solves nearly everything.
The only issue remaining is that the avatar does not show. The URL is right, but it does not work.
I am sorry to be unable to provide more info. But do you have any ideas what might cause the issue?

The image url comes from the avatar_url field of the profile object.
https://github.com/hackjutsu/Lepton/blob/master/app/containers/userPanel/index.js
  renderProfile () {
    let profile = this.props.userSession.profile
    if (!profile || this.props.userSession.activeStatus === 'INACTIVE') {
      return
    }

    return (
      <div>
        <Image className='profile-image-section' src={ profile.avatar_url } onClick={ this.handleProfileImageClicked.bind(this) } rounded/>
      </div>
    )
  }

The profile object comes from the initUserSession method from /app/index.js, which then calls getUserProfile() from /app/utilities/githubApi.

@tmr232 were you able to get it working with gh enterprise?

@johnwebbcole
I don't have an Enterprise account, so any help or PR would be appreciated.

@johnwebbcole Yes, it was done by replacing all the API URIs in the code.
To make something that supports both public & enterprise Github we need to add a configuration file or something similar.

https://github.com/hackjutsu/Lepton/commit/b2bebeda111d1911088007b77f97c732e0fe48ac


Setup a prow job for unit and integration tests

/kind feature
For better organization, also split the integration tests in a dedicated folder.

/assign

https://github.com/kubernetes/test-infra/pull/25336

is this done now?

yes
/close


Share store tests between browser and server

Right now they are copy-pasted, there's probably a better way.

Duplicate of #246


Uncaught Error: Cannot find module './minimap-quick-settings-view'

[Enter steps to reproduce below:]

Click on the gear icon in the top right corner of the minimap

Atom Version: 0.179.0
System: linux 3.13.0-45-generic
Thrown From: minimap package, v4.2.2
Stack Trace
Uncaught Error: Cannot find module './minimap-quick-settings-view'
At module.js:353

Error: Cannot find module './minimap-quick-settings-view'
  at Module._resolveFilename (module.js:351:15)
  at Function.Module._resolveFilename (/usr/share/atom/resources/app/src/module-cache.js:383:52)
  at Function.Module._load (module.js:293:25)
  at Module.require (module.js:380:17)
  at require (module.js:399:17)
  at HTMLDivElement.<anonymous> (/home/tobi/.atom/packages/minimap/lib/minimap-element.coffee:171:3)

Commands
     -2:16.6 pane:reopen-closed-item (atom-text-editor.editor)
     -1:59.6 core:save (atom-text-editor.editor)
     -1:51.9 pane:close (atom-text-editor.editor)
     -1:20.4 timecop:view (atom-workspace.workspace.scrollbars-visible-always.theme-solarized-light-syntax.theme-atom-light-ui)
     -0:53.9 application:new-file (ul.list-inline.tab-bar.inset-panel)
     -0:42.7 settings-view:check-for-package-updates (atom-workspace.workspace.scrollbars-visible-always.theme-solarized-light-syntax.theme-atom-light-ui)

Config
{
  "core": {
    "themes": [
      "atom-light-ui",
      "solarized-light-syntax"
    ],
    "autoHideMenuBar": true
  },
  "minimap": {}
}

Installed Packages
# User
minimap, v4.2.2

# Dev
No dev packages

I think you got that issue immediately after an update?
A restart should solve the issue. I believe Atom somehow fails to reload the new code after an update. This file was removed as part of an effort to get rid of all space-pen views and to replace them with custom elements and in that effort the file name was changed to match the Atom convention on that matter.

yup, sorry. after restart it works. thanks!


example doesn't work.

no matches for kind "Ingress" in version "networking.k8s.io/v1"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fd0e7d5a-37e9-07dc-f395-9cb5bb580e45
Version Independent ID: 7e4faf70-9724-7e7b-832b-1cd99a974920
Content: Create an ingress controller - Azure Kubernetes Service
Content Source: articles/aks/ingress-basic.md
Service: container-service
GitHub Login: @mlearned
Microsoft Alias: mlearned

Thanks for the feedback! We are currently investigating and will update you shortly.


feat(protocol-designer): remove secondary navbar

Overview
remove secondary navbar
close AUTH-662

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment
low

[ ] fix test error


Define static script as entry point for execution

use /start.sh as entry point and put the launch command there

is in /.dolmades/start.sh now, whereas /.dolmades is the metadata dir


vis

May I ask if you can provide visual code

Is there any relevant code that can generate relevant save files during prediction, including support sets, query sets, and prediction results in. ply or. npy format? I can easily visualize the prediction results through open3d or cloud compare in the future

So,how was Figure 5 visualized in your paper?


Add CI workflow to publish starknet-foundry packages to registry

See:

https://github.com/foundry-rs/starknet-foundry/pull/2461
https://github.com/foundry-rs/starknet-foundry/issues/2344

Blocked by https://github.com/software-mansion/scarb/pull/1605

Will be done by Foundry team


HOPSWORKS-290

Write crypto material password to a file in transient dir

Fix bug with project generic user trying to access hdfs

Add crypto material file as local resource for jobs launched from job ui. Small fix for YarnClientService regarding users

Get crypto material password from CertificateMaterializer instead of going to DB again

Add file with certificates password as LocalResource only when RPC TLS is disabled, otherwise it is injected by the NodeManager

Fix bug with crypto material password when RPC TLS is disabled

Materialize certificates passwd file for Zeppelin and Jupyter

Add double quotes for Jupyter conf

Change CertificateMaterializer#getUserMaterial to throw an exception instead of returning null in case of missing crypto material for a user

https://hopshadoop.atlassian.net/browse/HOPSWORKS-290

Looks ok.


Release SHA status information missing

This was fixed in the main capistrano git repo as part of this PR. But, with v0.0.8, it seems to produce
Branch master (at ) deployed as release<PHONE_NUMBER>3502 by XXX

release of 0.1.2
I just push master to rubygems.org


feat: Add customised env var and feature flags

This change adds 3 new features:

The ability to enable feature flags with the .Values.features key
The ability to add extra environment variables to the container env
The ability to completely override env variables (not recommended)

Closes #262

+1

Hi @jaitaiwan, thanks for the submission!  I'm currently reviewing your changes, which look great.
However, one thing that needs to be considered is disabling a feature gate.  In other words, right now your changes allow users to set certain feature gates to true, but it might also be necessary to set a feature flag to false.
Therefore, do you have any thoughts regarding a solution to allow users to both enable and disable feature gates?  Addressing that concern should pave the way for getting this PR merged.

I can make a change for that, I’ll add another commit!

Hey @andrewlecuyer I've gone ahead and updated the PR. Now the .Values.features allows you to specify either a slice of values to set to true or you can specify a map[string]string where the key is the feature name and the value is the value to be passed in to the flag. This should make it future proof if you go beyond the concept of a flag. I've put the examples in the values file but let me be explicit here.
The following values file:
features:
  - AutoGrow
  - AnotherFeature
  - YetAnotherFeature

Results in the following env var:
- name: PGO_FEATURE_GATES
  value: "AutoGrow=true,AnotherFeature=true,YetAnotherFeature=true"

So assuming we want say AnotherFeature to be false and even provide an arbitrary string to YetAnotherFeature we can then do:
features:
  AutoGrow: true
  AnotherFeature: false
  YetAnotherFeature: myarbitrarystring

Results in:
- name: PGO_FEATURE_GATES
  value: "AutoGrow=true,AnotherFeature=false,YetAnotherFeature=myarbitrarystring"

Hopefully this fits the bill?

Great work @jaitaiwan!  Anything else preventing merging this @andrewlecuyer?  I could really use this for our PGO installation as well.  We were really excited to use the new automatic per-user schema creation, but we had to manually patch the PGO deployment env with PGO_FEATURE_GATES="AutoCreateUserSchema=true" to make it work.  Obviously an easy enough workaround to get things working with the chart, but we try to manage everything in our cluster with ArgoCD/gitops so manual patching is a big no-no for us.  But then I found this PR and have just been working from this fork in the meantime.  Would love to get this merged to make it official if possible!  Cheers!

Thanks for the PR and the last update! I think we should move forward with supporting this approach:
features:
  AutoGrow: true
  AnotherFeature: false
  YetAnotherFeature: myarbitrarystring

Could you remove the support for the this style?
features:
  - AutoGrow
  - AnotherFeature
  - YetAnotherFeature

This change aligns with our upcoming feature gate, which will have its first feature set to
true by default. We want to encourage users to think in terms of setting values explicitly to true or false, rather than just listing features. Thanks for your understanding!

Okay! I've updated the branch with those requested changes.

Thanks for the contribution @jaitaiwan!


Store in Sqlite database

DBFlow Version:3.0.0-beta5
Issue Kind (Bug, Question, Feature):Bug
Description:
In documentation, to store list of object, I read this:
ProcessModelTransaction<TestModel1> processModelTransaction =         new ProcessModelTransaction.Builder<>(new ProcessModelTransaction.ProcessModel<TestModel1>() {             @Override             public void processModel(TestModel1 model) {                 processCalled.set(true);             }         }).processListener(new ProcessModelTransaction.OnModelProcessListener<TestModel1>() {             @Override             public void onModelProcessed(long current, long total, TestModel1 modifiedModel) {                 modelProcessedCount.incrementAndGet();             }         }).addAll(items).build(); Transaction transaction = database.beginTransactionAsync(processModelTransaction).build(); transaction.execute();
In my case I wante to store a list of country (countryList). When I past this code in my Editor,  new ProcessModelTransaction.Builder<> is not found and Transaction class is not found. How can I apply this code for my exemple.
Please.
ProcessModelTransaction<Country> processModelTransaction =         new ProcessModelTransaction.Builder<>(new ProcessModelTransaction.ProcessModel<Country>() {             @Override             public void processModel(Countrymodel) {                 processCalled.set(true);             }         }).addAll(countryList).build(); Transaction transaction = database.beginTransactionAsync(processModelTransaction).build(); transaction.execute();
Thanks

ah you're on beta5 nott beta6. Beta6 has significant changes in that sense. if you can upgrade do it, otherwise use:
TransactionManager.getInstance().addTransaction(new SaveModelListTransaction<>(models));

Thanks.
Please what is the Class of  database => database.beginTransactionAsync and what is can I put at  processCalled.set(true);


Feature Request: Specify order of sourcing R files

Feature Idea
I did not see a way to specify the sourcing order of R files. In R packages this works via the @include roxygen2 tag and subsequent update of collate directive in the DESCRIPTION file. It would be great if envsetup would have a similar way to do this.
Relevant Input
Say you have file a.R which for successful sourcing depends on code in b.R to be sourced beforehand. This arises e.g. in S4 class definitions or function factory calls.
Relevant Output
Currently this will fail. It would be great if there is a way to define that a.R depends on b.R and therefore b.R should be sourced first.
Reproducible Example/Pseudo Code
No response

@danielinteractive Thanks for the comment. We should be able to add a tag to each script for this, or we can add a place in the envsetup configuration file that would allow users to overwrite the default source order.

Thank you @nicholas-masel , maybe it would even be possible to use a similar pattern as in roxygen2 by having a look how they get from the @include tag usage to the collate list order. The advantage would be to minimize the workload for the user (only need to use such tag when needed)

@danielinteractive  Yep, I completely agree and this looks straightforward.  We'll update autos() to call roxygen:::generate_collate() to define the source order.
Here is a simple example:
#' @include inc2.R inc3.R
inc1 <- function(){
}

> roxygen2:::generate_collate("tests/testthat/ref/R")
[1] "inc3.R" "inc2.R" "inc1.R"


Error updating plugins

[x] I am on the latest Hyper.app version
[x] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name: Windows 8.1 x64, v6.3.9600
Hyper.app version: 1.0.0
Link of a Gist with the contents of your .hyper.js: LINK
Relevent information from devtools (CMD+SHIFT+I on Mac OS, CTRL+SHIFT+I elsewhere): N/A
The issue is reproducible in vanilla Hyper.app: Is Vanilla

Issue
I have an error at start, says that plugins cannot be updated, see log (and the log isn't where is pointing to, '~.hyper-plugins\npm-debug.log'. I can reproduce the bug not only restarting the app but going to menu, 'Plugins' -> 'Update All Now'.
In my particular case, I have a Windows 8.1 without administrator rights at work so I think that limitation is causing the problem.
And, of course, amazing app, it's superb!

I have the same issue. Everything is broken on all my Mac machines.

Same issue on Windows 10 with admin rights, I'll try to do some more digging.

Found the problem.
I was getting the error:
{ Error: Command failed: npm prune && npm install --production
bash: /s: No such file or directory

    at ChildProcess.exithandler (child_process.js:218:12)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at maybeClose (internal/child_process.js:877:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)

Looking into the install function, I noticed the path was correct, but the shell was interpreting it incorrectly. Commenting out the shell argument resolved the issue (line 243 currently). I had my shell set to bash.exe, but the default was also causing issues.
Not going to throw in a PR because i'm not sure how modifying the shell will effect other operating systems, but hopefully this comment helps.

@jonathandelgado I fixed the problem exactly like that but I wasnt sure how that was related so I didnt say anything. mine was set to fish

Yes, i'm using fish and am having this issue

I have searched the issues of this repo and believe that this is not a duplicate

Did you really? q.v. #312

Same issue here using fish

This looks like a duplicate of:
https://github.com/zeit/hyper/issues/312
https://github.com/zeit/hyper/issues/443

Closing in favor of #312

reinstall and delete profiles ( ~/.hyper.js  and   .hyper_plugins folder ).
it's work for me.
- windows 7
- hyper 2.0


Add filterSensitiveLog for Union types

Issue #, if available:
Follow up https://github.com/awslabs/smithy-typescript/pull/170
Description of changes:
This PR adds filterSensitiveLog for Union types
Testing done prior to code change on TypeScript playground
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Converted to draft as it's blocked on https://github.com/awslabs/smithy-typescript/issues/191


[BUG] org.opensearch.client.util.MissingRequiredPropertyException: Missing required property 'OpenSearchVersionInfo.distribution'

What is the bug?
Earlier today, I upgraded my AWS OpenSearch cluster from version 2.5 to 2.7, and now I'm seeing the following exception when fetching the cluster information on startup:
Caused by: org.opensearch.client.util.MissingRequiredPropertyException: Missing required property 'OpenSearchVersionInfo.distribution'
    at org.opensearch.client.util.ApiTypeHelper.requireNonNull(ApiTypeHelper.java:88) ~[opensearch-java-2.6.0.jar!/:na]
    at org.opensearch.client.opensearch._types.OpenSearchVersionInfo.<init>(OpenSearchVersionInfo.java:82) ~[opensearch-java-2.6.0.jar!/:na]
    at org.opensearch.client.opensearch._types.OpenSearchVersionInfo$Builder.build(OpenSearchVersionInfo.java:324) ~[opensearch-java-2.6.0.jar!/:na]
    at org.opensearch.client.opensearch._types.OpenSearchVersionInfo$Builder.build(OpenSearchVersionInfo.java:214) ~[opensearch-java-2.6.0.jar!/:na]
    at org.opensearch.client.json.ObjectBuilderDeserializer.deserialize(ObjectBuilderDeserializer.java:93) ~[opensearch-java-2.6.0.jar!/:na]
    at org.opensearch.client.json.DelegatingDeserializer$SameType.deserialize(DelegatingDeserializer.java:56) ~[opensearch-java-2.6.0.jar!/:na]
    at org.opensearch.client.json.ObjectDeserializer$FieldObjectDeserializer.deserialize(ObjectDeserializer.java:85) ~[opensearch-java-2.6.0.jar!/:na]
    at org.opensearch.client.json.ObjectDeserializer.deserialize(ObjectDeserializer.java:189) ~[opensearch-java-2.6.0.jar!/:na]
    at org.opensearch.client.json.ObjectDeserializer.deserialize(ObjectDeserializer.java:150) ~[opensearch-java-2.6.0.jar!/:na]
    at org.opensearch.client.json.JsonpDeserializer.deserialize(JsonpDeserializer.java:88) ~[opensearch-java-2.6.0.jar!/:na]
    at org.opensearch.client.json.ObjectBuilderDeserializer.deserialize(ObjectBuilderDeserializer.java:92) ~[opensearch-java-2.6.0.jar!/:na]
    at org.opensearch.client.json.DelegatingDeserializer$SameType.deserialize(DelegatingDeserializer.java:56) ~[opensearch-java-2.6.0.jar!/:na]
    at org.opensearch.client.transport.aws.AwsSdk2Transport.parseResponse(AwsSdk2Transport.java:522) ~[opensearch-java-2.6.0.jar!/:na]
    at org.opensearch.client.transport.aws.AwsSdk2Transport.executeSync(AwsSdk2Transport.java:393) ~[opensearch-java-2.6.0.jar!/:na]
    at org.opensearch.client.transport.aws.AwsSdk2Transport.performRequest(AwsSdk2Transport.java:191) ~[opensearch-java-2.6.0.jar!/:na]
    at org.opensearch.client.opensearch.OpenSearchClient.info(OpenSearchClient.java:860) ~[opensearch-java-2.6.0.jar!/:na]

How can one reproduce the bug?

Create an AWS OpenSearch domain running version 2.7 (the latest version AWS supports currently).
Create your OpenSearchClient:

var client = new OpenSearchClient(
    new AwsSdk2Transport(
        ApacheHttpClient.builder().build(),
        opensearchHost,
        "es",
        Region.US_WEST_2,
        AwsSdk2TransportOptions.builder().build()
    )
);

Attempt to fetch information on the cluster:

var clusterName = client.info().clusterName();

What is the expected behavior?
I wouldn't expect this to result in an exception, but rather print the cluster information even if the distribution is missing.
What is your host/environment?
AWS OpenSearch 2.7 (the latest version AWS supports currently)
Do you have any screenshots?
N/A
Do you have any additional context?
If the fix for this issue is as simple as refactoring the following line, I'd be happy to PR it:
this.distribution = ApiTypeHelper.requireNonNull(builder.distribution, this, "distribution");

For now, I'm going to avoid fetching the cluster information on startup as a temporary solution.

What version of the java client are you using?

Using version 2.6.0 of opensearch-java

@jhg023 @wbeckler  the distribution is a required property returned by the OpenSearch server, the issue looks to be AWS specific. The server/client API model is correct.

In that case, I can open a support ticket to AWS to investigate.

I created a 2.7 domain and I cannot reproduce this, I see distribution below. What do you see @jhg023?
$ awscurl --region=us-west-2 --service es https://search-dblock-test-opensearch-27-....us-west-2.es.amazonaws.com
{
  "name" : "fcecc570a4b1e0527475991424f81e8d",
  "cluster_name" : "013306242651:dblock-test-opensearch-27",
  "cluster_uuid" : "CDx1PKXnQnuym3oTrEPglA",
  "version" : {
    "distribution" : "opensearch",
    "number" : "2.7.0",
    "build_type" : "tar",
    "build_hash" : "unknown",
    "build_date" : "2023-06-28T07:07:20.444435752Z",
    "build_snapshot" : false,
    "lucene_version" : "9.5.0",
    "minimum_wire_compatibility_version" : "7.10.0",
    "minimum_index_compatibility_version" : "7.0.0"
  },
  "tagline" : "The OpenSearch Project: https://opensearch.org/"
}

Unless AWS OpenSearch comes with that compatibility enabled by default, I never explicitly enabled it. Here's what I see using the same awscurl command:
{
  "name" : "50101469e0d4fa***caca4915",
  "cluster_name" : "924108133664:***-prod",
  "cluster_uuid" : "***-OZnA",
  "version" : {
    "number" : "7.10.2",
    "build_type" : "tar",
    "build_hash" : "unknown",
    "build_date" : "2023-07-04T04:44:03.664641392Z",
    "build_snapshot" : false,
    "lucene_version" : "9.5.0",
    "minimum_wire_compatibility_version" : "7.10.0",
    "minimum_index_compatibility_version" : "7.0.0"
  },
  "tagline" : "The OpenSearch Project: https://opensearch.org/"
}

Seeing as how the number field in my response has a value of 7.10.2, I suspect there's some ES 7.10 compatibility happening here.

@jhg023 So yes, this is compatibility mode. When you create a new domain there's a checkbox to enable/disable it. If you don't need this, you can toggle it via API
$ awscurl --region=us-west-2 --service es https://search-dblock-test-opensearch-27-...us-west-2.es.amazonaws.com
{
  "name" : "fcecc570a4b1e0527475991424f81e8d",
  "cluster_name" : "013306242651:dblock-test-opensearch-27",
  "cluster_uuid" : "CDx1PKXnQnuym3oTrEPglA",
  "version" : {
    "distribution" : "opensearch",
    "number" : "2.7.0",
    "build_type" : "tar",
    "build_hash" : "unknown",
    "build_date" : "2023-06-28T07:07:20.444435752Z",
    "build_snapshot" : false,
    "lucene_version" : "9.5.0",
    "minimum_wire_compatibility_version" : "7.10.0",
    "minimum_index_compatibility_version" : "7.0.0"
  },
  "tagline" : "The OpenSearch Project: https://opensearch.org/"
}

$ awscurl -X PUT  --region=us-west-2 --service es https://search-dblock-test-opensearch-27-...us-west-2.es.amazonaws.com/_cluster/settings -d'{"persistent":{"compatibility.override_main_response_version" : true}}'
{"acknowledged":true,"persistent":{"compatibility":{"override_main_response_version":"true"}},"transient":{}}
osx ~/source/opensearch-project/project-tools/dblock-project-tools (main)$ awscurl --region=us-west-2 --service es https://search-dblock-test-opensearch-27-...us-west-2.es.amazonaws.com
{
  "name" : "fcecc570a4b1e0527475991424f81e8d",
  "cluster_name" : "013306242651:dblock-test-opensearch-27",
  "cluster_uuid" : "CDx1PKXnQnuym3oTrEPglA",
  "version" : {
    "number" : "7.10.2",
    "build_type" : "tar",
    "build_hash" : "unknown",
    "build_date" : "2023-06-28T07:07:20.444435752Z",
    "build_snapshot" : false,
    "lucene_version" : "9.5.0",
    "minimum_wire_compatibility_version" : "7.10.0",
    "minimum_index_compatibility_version" : "7.0.0"
  },
  "tagline" : "The OpenSearch Project: https://opensearch.org/"
}

Shall we close this?

Unless AWS OpenSearch comes with that compatibility enabled by default, I never explicitly enabled it.

@jhg023 It's not the default, but there is a check box to enable compatibility mode on an Amazon OpenSearch Service domain when creating it via the console UI.

Thanks for letting me know! I created this domain through CloudFormation, so I suspect I may have unintentionally enabled it there, or didn't explicit opt to disable it.

I don't get it. I thought the issue was that the server response was causing an exception. I don't think compatibility mode should cause an error.

I don't get it. I thought the issue was that the server response was causing an exception. I don't think compatibility mode should cause an error.

The compatibility mode (which if I am not mistaken phased out in 3.0.0) is only need when it is desired that OpenSearch cluster could be accessed by Elasticsearch clients (not OpenSearch clients).

@reta The compatibility.override_main_response_version setting was actually removed in https://github.com/opensearch-project/OpenSearch/pull/3031 for the 2.0 release. However, Amazon OpenSearch Service has forward-ported this setting to the 2.x versions.
@wbeckler The question is whether opensearch-java should be compatible with OpenSearch running in a compatibility mode intended to make it compatible with Elasticsearch clients.

@wbeckler The question is whether opensearch-java should be compatible with OpenSearch running in a compatibility mode intended to make it compatible with Elasticsearch clients.

I believe the answer is no, there's no claims of opensearch-java working with Elasticsearch 7.10.

Wouldn't it be better if the client could be cross compatible? Maybe with a
client compatibility mode flag as well?
On Tue, Aug 8, 2023, 11:06 AM Daniel (dB.) Doubrovkine <
@.***> wrote:

@wbeckler https://github.com/wbeckler The question is whether
opensearch-java should be compatible with OpenSearch running in a
compatibility mode intended to make it compatible with Elasticsearch
clients.
I believe the answer is no, there's no claims of opensearch-java working
with Elasticsearch 7.10.
—
Reply to this email directly, view it on GitHub
https://github.com/opensearch-project/opensearch-java/issues/573#issuecomment-1669801377,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA5PRLWHJSWMQXPIL2YOROTXUJIZHANCNFSM6AAAAAA2DJ723M
.
You are receiving this because you were mentioned.Message ID:
@.***>

Wouldn't it be better if the client could be cross compatible?

We definitely shouldn't to take this route, the compatibility was interim measure, at this point the functionality between ES and OS diverged significantly, each has own ecosystem.

Faced the same issue today and had to set compatibility.override_main_response_version to false.
PUT _cluster/settings
{
  "persistent": {
    "compatibility": {
      "override_main_response_version": false
    }
  }
}

This will add the property "distribution" : "opensearch" in the cluster info response.
If you are running a managed version of opensearch like on AWS, you need to contact AWS support to update this setting.


multiple small bugs fixed

Main bug: If there was any non-npz files in the given folder, multiple errors would arise. Solved by listing only npz files.


Could not install/find pod

I tried to install it via pod, but it does not work.

Sorry this pod is currently in develop.
Please wait for v0.1 release (coming soon!) and then try again.

v0.1.0 has been released.
You can now pod try CRToastSwift.
[Note]
This repository has been renamed to CRToastSwift_Old and a new CRToastSwift repository has been created for some reasons.
From now, the project will be developed on the new repository, and the old one will be deleted in near future.


Combining martech.js into utils.js to reduce scripts in critical path leading to interact call.

Merges martech.js contents into utlis.js to reduce the number of network calls needed to get to the /interact call.
Makes performance around 80(+-80)ms better.

Test URLs:

Before: https://main--milo--adobecom.hlx.page/?martech=off
After: https://marketingtech-combine-files--milo--adobecom.hlx.page/?martech=off

@chrischrischris , I'm completely creeping into your area, so please feel free to reject this purely based on that. :)
Also, if you have some other reason why you want to keep martech.js separate, by all means, reject this PR.
My main thought process was simply that while I was doing the last PR, I noticed that we still have to wait anywhere from 50ms to 500ms just for the martech.js file to load...It was only around 500 lines of code, so I figured why not just combine it with utils.js and save us some time in the critical path to the /interact or target call.
I also added a test to increase test coverage...
Let me know your thoughts and please feel free to be critical. :)
CC: @vgoodric

Hey @bbythewa in theory this is a great idea, however for the most use-cases - this will hurt performance.
We only load Martech "pre-LCP" when target is enabled where it is crucial to have Martech to render a page.
In all other cases, we can wait until the user sees the first LCP element which in turn is one of the most important and hardest to optimize LH & CWV metric.
So, the conclusion to move this into utils is the correct one, however we already optimized the loading path of Martech in order to be even more efficient for a wider variety of use-cases.

well @mokimo that great explanation of yours drills down the decision making point to:
do we want to optimize pages with target enabled or pages with target disabled. And i would tend to think this decision does not belong to us, but marketing, no?

Hey @bbythewa in theory this is a great idea, however for the most use-cases - this will hurt performance.
We only load Martech "pre-LCP" when target is enabled where it is crucial to have Martech to render a page.
In all other cases, we can wait until the user sees the first LCP element which in turn is one of the most important and hardest to optimize LH & CWV metric.
So, the conclusion to move this into utils is the correct one, however we already optimized the loading path of Martech in order to be even more efficient for a wider variety of use-cases.

Thanks for your explanation @mokimo.
My POV is that it would not hurt even the cases where we delay LCP, but would dramatically help with target use cases.  Here is my rationale:

Since we are already waiting to load martech after LCP when we don't use target regardless of whether the logic exists in another file or not, any non-target use cases wouldn't be impacted.
The only thing we are doing is adding a few extra bytes to utils.js...this in my view would not hurt LCP for non-target use cases.
The use case it does help is what you described here where we load martech pre-LCP...and in those cases it helps by reducing LCP by quite a bit (comparatively).

I may be wrong. Happy to chat more about it.

And i would tend to think this decision does not belong to us, but marketing, no?

Yeah, however it should be a mostly data driven decision IMO. I'd wonder on how much traffic goes to pages with target enabled vs no target. Even though @vivgoodrich argued that the most important pages do have it.
There are a couple more negative benefits to this though, on top of my mind:

The utils.js file is growing and will keep growing and removing is a lot harder than adding. There's a maintenance aspect to this
Separation of concerns, the martech code is currently nicely separated which makes changes easier as they are scoped to martech. Again maintenance

@bbythewa do we have any traffic data for milo with target pages vs no target? (If this is not public, feel free to share on #milo-dev or ping me on slack)

@chrischrischris ,
Last thoughts before I give up on this PR 😄 :

I may be wrong on the purpose of the code, but it still feels like there is a good portion of martech and personalization code/logic in utils.js (https://github.com/adobecom/milo/blob/stage/libs/utils/utils.js#L857-L1001), so martech/personalization/mep are already split across two files right now with half of the logic residing in both.  I personally like having that code in utils.js for the other reason of simply being easier to follow the logic of target/personalization/etc.  That's just personal preference.
I agree that it does add extra code to utils.js, but what is our threshold? In my mind, adding 250 lines isn't a lot, but "a lot" depends on who you ask. 😆  Like if I were to simplify the logic to say only an additional 100 lines, then would it be okay?

I only bring up those points in case they feel relevant and in case that makes a difference before we discard the PR...
Having said all of that, I love your idea of preloading martech.js somewhere!  I think that does accomplish the same goal from a performance standpoint.  I personally would prefer to not rely on consumers to load this themselves simply because it takes time and we end up having to talk to every consumer about it and convince them, but I will defer to you on best way to implement these kinds of things.

@bbythewa
Yes there is def a decent amount of martech code in utils, with most of it required to determine if when martech/mep should be loaded.  As it stands utils might already be too bloated, but it's a hard thing to tame.
I've been doing some testing with prefetching and for a test milo page have reduced LCP from 5.7s to 4.1s.  Only requires a change in headers.xlsx.  It would require consumers to update their excel files, but since there is no code change involved it can be done quickly (and reverted just as quickly).  It does require enabling it only on pages where target is running, but those are most of the high impact pages.
I filed https://jira.corp.adobe.com/browse/MWPW-154478 for bacom, but other consumers can use the exact same headers.

Awesome.  Thanks @chrischrischris . That's a huge improvement!  I'll close this PR for now in favor of the headers.xlsx change you are suggesting. 👍

I agree that it does add extra code to utils.js, but what is our threshold? In my mind, adding 250 lines isn't a lot, but "a lot" depends on who you ask. 😆 Like if I were to simplify the logic to say only an additional 100 lines, then would it be okay?

@bbythewa to give you some context and don't let this unanswered: we started to fight for every single line of code added to utils. In some cases it's unavoidable, but we gotten very protective of it

I know this PR is closed, but I wanted to mention a few things (PR mentioned below):

we're already working on improving on what Chris described: only keep logic in utils if it's needed to decide if we need more
we moved some of the MEP code out of utils and I have ideas of some more we things we can do
same PR has moved some MEP code out of martech and into personalization. So if we do pull in the martech code, there would be less to pull in

Now that martech.js is down to 250 lines (8kb), maybe we should consider pulling the remaining martech code into personalization.js.  So when martech impacts LCP, it will already be with the other MEP code and not require a separate download.  But if it's not needed for MEP, it's loaded post LCP.  Downside is a bunch of pages will download non needed MEP code.  Upside is that won't be until post LCP.
Thoughts?

I know this PR is closed, but I wanted to mention a few things (PR mentioned below):

we're already working on improving on what Chris described: only keep logic in utils if it's needed to decide if we need more
we moved some of the MEP code out of utils and I have ideas of some more we things we can do
same PR has moved some MEP code out of martech and into personalization. So if we do pull in the martech code, there would be less to pull in

Now that martech.js is down to 250 lines (8kb), maybe we should consider pulling the remaining martech code into personalization.js. So when martech impacts LCP, it will already be with the other MEP code and not require a separate download. But if it's not needed for MEP, it's loaded post LCP. Downside is a bunch of pages will download non needed MEP code. Upside is that won't be until post LCP.
Thoughts?

I'm all for combining files together and loading files in parallel as much as possible.  :) I also did notice that personalization.js and martech.js sometimes get loaded one after the other in sequence...combining them together would solve this for sure. :)


bumping js-slang

Pull Request Test Coverage Report for Build 4609

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 36.665%

Totals

Change from base Build 4607:
0.0%

Covered Lines:
2807

Relevant Lines:
6836

💛  - Coveralls


policies

this PR:

adds the text of our CoC, anti trust policy, and bylaws to the website as markdown/html
adds a plugin that auto generates a TOC from headers
adds links to the policies in the footer on every page

for reviewers:

is the text accurate? did the markdown translation have any unintended semantic effects?
are there any glaring formatting errors?

some known issues:

TOC has # appended to each link, not ideal but not worth removing the TOC for imo

screencaps:
anti-trust policy:

footer

bylaws

The footer links vanish on hover -

The footer links vanish on hover -

this should be fixed now, good catch

@ashleygwilliams the Bylaws TOC puts a "#" at the end of every item, which looks a bit odd. Is this intended?

@copiesofcopies it's from the plugin. i dont love it but i think the TOC's value outweighs the weirdness of the #. at some point i will poke and see if i can remove it but, this was the out of the box effect.

@copiesofcopies it's from the plugin. i dont love it but i think the TOC's value outweighs the weirdness of the #. at some point i will poke and see if i can remove it but, this was the out of the box effect.

I remember well how damnably difficult it can be to correct seemingly trivial formatting issues in Wordpress plugins and agree it's not worth going down the rabbit hole just to get this out!