AWS_Route Modules failing on newer AWS Provider versions.

Describe the bug
When running a terraform plan on the newest AWS provider, you will receive an "Error: ExactlyOne" output from terraform. Screenshot below.

To Reproduce
Steps to reproduce the behavior:
Example Code:

Set remove hard coded version from O'Leary Prod Infrastructure code
save and commit
run a terraform plan

Expected behavior
Expected behavior is for the code to work as it had before, producing no ExactlyOne error.
Problems
There is likely something wrong with the inputs we have selected for the module, or something of that sort.
Solution
Confirmation
Next Steps
Meet with CCoE during L10 and discuss as an issue.

Created the following pull request to resolve this.
https://github.com/thinkstack-co/terraform-modules/pull/37

The primary issue is that default = ""  was being utilized which matched v0.11 methods. Transitioning the aws_route module to default = null.
Some tweaks needed to be made to the network_interface_id variable to match. This has been tested on VPN peer routes. Need to test it on a route that points to the network_interface_id for a fortigate firewall

Tested a run with this in Liberty and ran into additional errors.
Example code for one of the modules:
module "route_199_186_96_0" {
source = "github.com/thinkstack-co/terraform-modules//modules/aws/route?ref=dev_aws_route_provider_v3.35.0"
network_interface_id   = module.aws_prod_fw.private_network_interface_id[0]
route_table_id         = module.vpc.private_route_table_ids
destination_cidr_block = "<IP_ADDRESS>/24"
}
Link to run

I see you found your problem, it looks all good yeah?

Maybe. I think in your PR to fix we need to either remove the arguments that are not expected, but what is weird is that they are valid arguments for the routes module in terraform documentation.
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/route
My thought is that maybe it wants only one and even having 'null' gives it a value and upsets terraform.

Review and tests show that this is corrected. Merging up.


No enabled makers for filetype javascript.jsx

I'm trying to eslint a file with the javascript.jsx filetype (from plugin https://github.com/mxw/vim-jsx/tree/master/ftdetect).
I have the following in init.vim file:
let g:neomake_verbose=3
autocmd! BufWritePost * Neomake

When saving my file the only output I get is the following:
Neomake: Nothing to make: no enabled makers

I'm not entirely sure why this happens as we can see that both JavaScript and JSX has default makers enabled.
I'm running NVIM 0.1.4.

Seems like a duplicate of #272

@alexlafroscia not exactly. I don't get any makers running, not even the JSX ones.

Oh, weird. Do you have a custom set of makers enabled, or just the default ones?

@alexlafroscia just the default ones, I've made no changes at all.

FYI: https://github.com/neomake/neomake/issues/493#issuecomment-231127780

@adamyonk thanks for that! :+1: However, there still is a bug I presume, the ´jsx´ makersare a superset of the ´javascript´ makers and even further, ´jsx´ have ´eslint´ as a default marker. So it should run by default.

I'll look closer at that later / on the weekend.
JFI: you can use 12verb w to see what functions are called and what they return.

@KevinSjoberg
Did you get it working?  See https://github.com/neomake/neomake/issues/572.


How to use setPlaylistPath ?

Thanks for great repository, How can I use setPlaylistPath method, I'm trying to prepend a default path before m3u8 file playlist.
Thanks,

Can't you do something like this?
FFMpeg::fromDisk('videos')
    ->open('your_video.mp4')
    ->exportForHLS()
    ->addFormat($someFormat)
    ->save('subfolder/adaptive_video.m3u8');

The final m3u8 file is address to adaptive_video.m3u8 files rather than relative download path. I'm calling the adaptive_video.m3u8 from another address and it cannot find the ts files.
when I add relative path as prefix to m3u8 files, the problem is fixed.
Example working file:
#EXTM3U
#EXT-X-STREAM-INF:BANDWIDTH=250000
download?file=/public/hello/720P_ (2)_mp4/online_250.m3u8
#EXT-X-STREAM-INF:BANDWIDTH=500000
download?file=/public/hello/720P_ (2)_mp4/online_500.m3u8

I understand the problem but it's out of the scope of this project. Maybe you should parse and adjust the generated playlist file or generate your own one?


Consider renaming state fields

Which components does the task require to be changed? (think hard pls)
snforge
Description
name -> type
https://github.com/foundry-rs/starknet-foundry/pull/1844#discussion_r1548379913

@THenry14 Can you please assign me this work?

@Jemiiah thanks for taking interest in this issue, but we are still not sure about its scope, so sadly I cannot assign this one at the moment :(


Remove typescript

Purpose (TL;DR) - mandatory
Remove generated Typescript definitions
Background (Problem in detail)  - optional
When adding JSDoc to our functions our main points were

Give us documentation, API docs
Give autocomplete and type suggestions in supporting IDEs

As an added bonus, we found that it was possible to generate
TypeScript definition files directly from the JSDoc definitions.
There were already community efforts at DefinitelyTyped for
both sinon and its sub-projects, like fake-timers, but as
external projects they suffered from being out-of-sync
with the projects they were supposed to describe. Our thoughs
were then that by generating these directly from the source
that we could in time catch up with the DT efforts and
be the main source of up-to-date .d.ts files.
Unfortunately, there were some aspects of our types that
were hard to describe statically using JSDoc, such as those
where TypeScript would utilize its typeof type operator.
That resulted in contributions that used the
fact that TSC ignored invalid type definitions to describe
types using those TypeScript features. The result was valid
d.ts files, but invalid JSDoc, meaning our two main points
were unmet. JSDoc simply is not powerful enough to generate
the types expected by the users of the DefinitelyTyped
types. So, in order to get back to what we mainly want, we
stop shipping TypeScript definitions and continue to let this be a
community maintained effort at DT (as it was). This should
result in less friction (as experienced in the last few
months), but will, of course, have the downside of always
lagging a bit behind.

I do not understand why we cannot write the source of this module in TS, which should make sure the source is nice to use in IDEs whether or not you use TS (which from what I gather is the purpose of jsdoc). When brought up the answer has been "no", but without any proper reasoning.
(please tell me where to discuss this privately if anywhere and delete this comment if you want)

@SimenB I think that's a fair question, and I do not mind this being an open discussion. There are discussions happening outside of GitHub (we have a Telegram group for the core Sinon maintainers) where we discussed this a bit. This is @mroderick's take on this:

I really don't care for TS. I do care about having good documentation. JSDoc can give us good API documentation (with a lot of work). If we can get more people interested in writing documentation by giving them type definitions: everyone wins

There's simply not that much love to be found for TypeScript in itself among the various maintainers. And although we have asked for people to step up to do the maintenance work (merging PRs, updating deps, debugging and verifying various issues on the issue tracker), years later it's still mainly me, Morgan and Max doing it across the various projects. So whether the maintainers like working with TypeScript or just plain think it's a step in the wrong direction for JS matters in that sense.
The start of this was basically that we just wanted better API docs than what we had. And while yes, there is (was?) a build step already, TypeScript brings a lot else into the mix that adds a bit to the mental overhead. Me personally think TS has a lot of cool things going for it and I ~enjoy~ find it useful in the larger codebase I work with on a daily basis, but struggling to find the right incantations to appease the compiler is not how I enjoy spending my weekends 😄 What I like about contributing to these projects is the low threshold to fix something. There's no build step needed, no source maps to think about, just pure ECMAScript that runs in the browser or Node unaltered. And I think that's fine quality in itself.
That being said, this project is a bit different, in that you are one of the core maintainers (in @sinonjs/lolex-core) and has an interest in getting good quality TypeScript definitions for the Jest project. So with regards to the previous thinking of "the ones doing the work should decide" what you think definitely matters. I'm not religiously opposed to adding type annotations, pretty sure Benji is neither (given the work he has done at Testim), and the work Morgan does in this project is mostly not related writing code, so with that in mind ... It would still be the odd man out, among our projects, though.

I'm happy to have a TS discussion in a separate issue. This PR is about fixing what could have been good, but turned out it wasn't.


update fill_parent to match_parent

fix incidents of deprecated fill_parent by changing to match_parent
https://devtopia.esri.com/runtime/java-android-sdk/issues/1433

Thanks @TADraeseke - looks good to merge.


fix: address javadoc publishing errors

Signed-off-by: Phil Adams<EMAIL_ADDRESS>

:tada: This PR is included in version 9.18.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


move Sot struct to higher level

@rultor release, tag is 0.0.1

@yegor256 Invalid release tag 0.0.1 specified. There is already a release 0.0.2 newer than the given release in this repository.

@rultor release, tag is 0.0.1

@yegor256 I'm sorry, I don't understand you :( Check this page and try again please

@rultor release, tag is 0.0.3

@rultor release, tag is 0.0.3

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.0.3

@yegor256 Done! FYI, the full log is here (took me 3min)


Idea: Active Hours

Hey, just a disclaimer: I have 0 coding knowledge and plan to use this to troll my brother who lives in hawaii
So, if were trying to control the computer, or open up something, or just move stuff on the monitor, Basically anything we cant do from the command line/file manager, and something we can do with the screen control. Essentially, the program should mark timestamps (relative minutes or hours) that the user is online, and the time stamps the user is offline. Or maybe if the user is offline for more than 4 hours it should mark it as sleeping or downtime? Then, at the time the user is most active, it sets that to Active Time.  So this would make it easier to make visual changes without using the command line or file manager without the user noticing.
^_^

if it doesnt detecs any mouse or keyboard input you can say it is on stanby

5 Months Later -

yeah ig that would make more sense. But i do think it would be helpful to see the sleep schedule of your victi- i mean your educational project test subect who 100% agreed to this infiltration.


React is listed as a dependency, not a peerDependency

We're looking to embed this in an existing app, but are blocked because we're ended up with multiple copies of React loaded. That's causing a number of obscure problems, most notably that the initial request for data isn't being sent out. I forked the repo to verify that moving React/ReactDOM to peerDependencies resolved the issue, which it does.
I considered opening a PR, but I wanted to discuss it first. It's a small technical change but I realize it has an outsized impact on documentation and getting the project up and running on its own.

I would be +1 for this change.
Not sure about the impact? It seems quite limited to me. We just need to yarn install react in addition to admin-on-rest, and add it to the dependencies of the demo. And it may even fix some issues we have (had?) with npm link.
Yet, as it would be a BC break, it would need a new version. Perhaps for the 2.0?

The problem is that admin-on-rest currently doesn't support the latest React version (see #802), so to have it work with another codebase, your codebase must specify exactly the same React version as admin-on-rest. In this case, being a dependency or a peerDependency doesn't matter.
Also, as @jpetitcolas said, this is a breaking change. We'll keep it in mind, but until we plan a major release, this is a no go.

I installed the exact version admin-on-rest was using and continued to get the warning about multiple copies of React being loaded. I'm not sure why npm wasn't able to dedupe it (which is what I was expecting), but I have not been able to resolve this without forking to add React as a peerDep

Maybe you have a .lock file? If so, remove it. Clearing the npm cache may help, too.


Fix links in adopt-tools-and-downloads.md

Closes https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/7992.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@SerdarSoysal PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


fix: now require('jetpack.paq') is function

fix: now require('jetpack.paq') is function

Right. Thanks!


changed selector

MAV was inconsistent with their styling which tripped up the html selector I was using leading to unparsed entries in the timetable's uppermost level (but no the more details view). Changed the selector to something that is hopefully less error-prone.

this resolves #51


chore(ci): appveyor fast_finish to false for consistency

as discussed in #5

Tests are quite slow with --serial. Maybe remove it once that problem is resolved?

Yeah sure, I can rename this and keep it open till that's resolved?

merged as 89b6b9ea56e6fbac4791a3583fc1c3d7f0d226ce


README

README
User Story
As a boot camp student
I want the prework notes to be structured on a webpage,
So that I can easily find and read the information.
Acceptance Criteria
GIVEN the prework project repository,
WHEN I view the README for the repository,
THEN I can see a professional README that provides information on the project and how to use it

Updated the README file and merged to main branch.


Asp.Net Core

I have a asp.net core with resources in an other project.
When i open the Resx Manager the first time, visual studio stop responding.
The next time i have open it, it worked.
Just want to let you know ;-)

Same thing happen when you translate, aply all and a resource for a language need to be created

Maybe that's due to the way how the solution enumerates all items.
In asp.net projects all files in the (sub)folders are considered as item of the project, which can be many and may take a long time to cache.
If VS stops responding, does it utilize processor and disk time, or is it idle?

@werddomain is this still reproducible?

I did not try to reproduce it. But vs stopped responding many time after i have posted this issue.
The cpu dont seem to be buzzy, sice other program work correctly and fluidly.
If it can help you, i use 3 project with .net standard and one asp.net core project.
Ressources are in 2 project.
when the error ocur, it has stoped in the middle of the operation. I can redo the task 1 or 2 time and i can be able to terminate the task.

I could not reproduce this. I added an asp.net core project to an existing solution, and it worked fine.
Can you post a solution where this is reproducible?

Closed as not reproducible, and no sample has been provided.


Update test pic.swift for different code gen

rdar://44843229

@swift-ci Please smoke test and merge

Force-merging to fix some Apple-internal bots.


RFC: Closeable Tracers

This proposal builds off of discussions primarily in the Java API surrounding the inclusion of a Close method in that library. The primary goal of adding this to the specification is to provide a clean decoupling of OpenTracing Tracers from their concrete implementations in a consistent way across platforms and languages.
See https://github.com/opentracing/opentracing-java/issues/250 for further recent discussion.

What happens to spans started or even finished after the tracer is closed is a good question. We have seen cases where async callbacks were executing and finishing spans even after the tracer was closed, so sometime the application does not have full control over that. Ie we were seeing crashes when the app was just shutting down.
There's a large number of possible states we need to consider.

The case of 'what happens if I try to start a span after closing a tracer' seems straightforward enough, the tracer should check to see if it's been closed. If it has been closed, an error occurs and the span is not created.
I don't really have a good idea about what happens to spans that are in-flight during the tracer being closed, however. Couple options -

Tracer closes immediately (no new spans started), waits some configurable amount of time for spans that have been started and not finished to complete.
Tracer closes immediately (no new spans started), any unfinished spans are dropped.
???

There's probably others I haven't thought of.

If it has been closed, an error occurs and the span is not created.

that's not possible - methods for creating a span are not allowed to fail. You can return a noop-equivalent of a span.

what happens to spans that are in-flight

I think the required guarantee is that spans that have been Finished() prior to tracer.close() call must be flushed. Spans created or finished after tracer.close() may or may not be flushed, but should not be throwing errors and messing up the application.

lgtm

@tedsuo, are you ok with deferring your question about if close should be synchronous so we can get this merged?

@austinlparker: yes, the RFC basically says that close is synchronous right now; I would just like that to be explicit. I doubt this is a contentious proposal.

Alright, I called that out specifically. Thanks!


Add GitHub Action to publish the package

This could possibly be the same action as #55.

Closed by #72


[BUG] qt.qpa.plugin: Could not load the Qt platform plugin "xcb"

Terms

[X] Checked the existing issues and discussions to see if my issue had not already been reported;
[X] Checked the [frequently qsked questions]](https://manim-slides.eertmans.be/latest/faq.html);
[X] Read the installation instructions;
[X] Created a virtual environment in which I can reproduce my bug;

Describe the issue
Hello,
I am unable to run manim-slides, thank you in advance for your help!
I am on Ubuntu 22.04.5 LTS and my python version is 3.10.12.
I created a python virtual enviornement in which I installed manim with
pip3 install manim, and it works fine.
Then, I installed manim-slides with
pip install manim-slides[pyside6].
When running an example with
manim example.py BasicExample, and then
manim-slides BasicExample, I get the following error
qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found.
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: minimalegl, wayland, vkkhrdisplay, vnc, offscreen, linuxfb, minimal, xcb, wayland-egl, eglfs.

Aborted

Command
manim-slides BasicExample
Issue Type
Installation issue
Python version
Python 3.10.12
Python environment
Error: File slides/checkhealth.json does not exist, check the scene name and make sure to use Slide as your scene base class

What is your platform?
Linux
Other platform
No response
Manim Slides Python code
from manim import *  # or: from manimlib import *
from manim_slides import Slide

class BasicExample(Slide):
    def construct(self):
        circle = Circle(radius=3, color=BLUE)
        dot = Dot()

        self.play(GrowFromCenter(circle))
        self.next_slide()  # Waits user to press continue to go to the next slide

        self.next_slide(loop=True)  # Start loop
        self.play(MoveAlongPath(dot, circle), run_time=2, rate_func=linear)
        self.next_slide()  # This will start a new non-looping slide

        self.play(dot.animate.move_to(ORIGIN))

Relevant log output
No response
Screenshots
No response
Additional information
No response
Recommended fix or suggestions
No response

Hi @Haetham96, thanks you for reporting this issue!
Are you using Wayland?
Also, can you try this if this fixes your problem? https://github.com/NVlabs/instant-ngp/discussions/300#discussioncomment-3985753

No I am not using Wayland.
I tried the proposed solution, still gives the same error.

Can try installing Manim Slides only (but with pyside6-full extra) from the main branch?

Could you check this thread to see if that can help? Also, run the application with QT_DEBUG_PLUGINS set to 1, e.g.:
QT_DEBUG_PLUGINS=1 manim-slides present BasicExample

It works !!
Fixed by installing 'libxcb-cursor0' from
http://archive.ubuntu.com/ubuntu/pool/universe/x/xcb-util-cursor/libxcb-cursor0_0.1.1-4ubuntu1_amd64.deb
Thank you very much !!

Happy it solved your issue :-)


Menu is still openable if alert is present

Short description of the problem:
If you open an alert and there is a menu on your page, you still can swipe to open/close it while the alert is present.
This is annoying if you have a menu that is disabled on a specific state (ie not logged in) and the user logged out with the menu opened, he won't be able to close it then.
What behavior are you expecting?
Disable the swipe event when an alert is present
Steps to reproduce:

Present an alert on a page with a menu (which has the  swipeEnabled config set to true)

See the plunkr
Which Ionic Version?  2 rc2
Platform: any

Nice catch! looks like it is a long standing issue, also affects "swipe to go back". Fortunately it is an easy fix.
Thanks!


Add clearInput flag to clearOptions()

Only clear user input when clearInput is true or undefined.
The undefined check is to make sure this change doesn't break any existing code.

@brianreavis: can you give a recommendation on each new search -- after selecting an item -- how to empty the cache of current results? As with those above, each new item added results in the previous results becoming invalid. I therefore want to start from scratch after the item add and rely on what my remote data source returns. Would it be updateOption() / removeOption() instead?
I appreciate removing self.clear() from clearOptions() is not the way to do this.
Thank you

Solved using:
var $selectize = $('.selectize').selectize({
    onItemAdd: function(){
        var options = $selectize.options;
        for(option in options){
            if($selectize.items.indexOf(option) == -1){
                $selectize.removeOption(option);
            }
        }
    }
});

$selectize = $selectize[0].selectize;


fix example

#83 removed extra "result" layer, which wasn't reflected in the example. Created and issue to add example to the CI as well: #107. This PR fixes the example script.

Can we get this test to run on CI as well?

Can we get this test to run on CI as well?
I created an issue for that: #107.


Requesting clarification in documentation

Thanks @ruffsl for this helpful extension! I am using this to speed up CI for feature branches and would like to seek some clarification to what is described in the README. (Also, much thanks to providing a nice readme instead of just a mostly empty file only containing the package name!)
Can you please explain the purpose of the --packages-select-cache-key? For example, where would I look to see what the default key is and why would I need to override it?
Also, the lock workflow is not intuitive to me. In the quick start example, why do I need to lock the workspace before the first colcon build and also after the minor source file changes? When colcon build --packages-skip-cache-valid is run, does it re-hash the package and compare to what is cached? Or does the hashing only happen when colcon lock is called? Also, it appears that lockfiles are also updated/created after the build and test verbs too (as described by the sentence "Upon successful task completion for a package job, as when evoking colcon verbs like build, test, etc, these lockfiles are updated for the evoked verb, thereby delineating the provenance of the job’s results"). To my understanding, the verb lock is a bit strong because it sounds like other actions would not be permitted to make changes to lockfiles, but that is not the case. To me, the verb is closer to hash or maybe update to manually trigger an update to the lock files.
I think that a more detailed explanation (maybe annotating the example) of what creates and or modifies which lock files and what checks against the lock files are performed would be helpful. Also, an example of using --packages-select-cache-key would be helpful.
Overall, I think that  understanding that there are some "automatic" updates to lock files depending on using verbs like build and test is an important concept that a new user may not be aware of based on the current example and explanation.

Hey @zflat , neat to hear your use of this extension to speed up CI. If you like to see a real world example using this extension, we've been using it rather heavily for the Nav2 project for over a year or so:

https://github.com/ros-planning/navigation2/pull/2343

Can you please explain the purpose of the --packages-select-cache-key? For example, where would I look to see what the default key is and why would I need to override it?

The purpose of the --packages-select-cache-key is to override the default cache key selected by the verb handler. For example, the verb handler for the "colcon list", it uses the same verb handler for "colcon cache", which defines what lockfiles are to be used for comparison or reference. When used with package selection, this can be helpful when listing what caches are still valid for other colcon verbs (e.g. not just for "colcon list").

https://github.com/ruffsl/colcon-cache/blob/0a23776c5d30e3e2611d64c828c500a5a9fdcca8/setup.cfg#L94
https://github.com/ruffsl/colcon-cache/blob/0a23776c5d30e3e2611d64c828c500a5a9fdcca8/colcon_cache/package_selection/valid.py#L56-L58
https://github.com/ruffsl/colcon-cache/blob/0a23776c5d30e3e2611d64c828c500a5a9fdcca8/colcon_cache/package_selection/valid.py#L82-L85

In Nav2 for example, we do this to list packages with invalidated caches for specifically the "colcon build" verb, so that we can determine the package builds that must be subsequently cleaned:
https://github.com/ros-planning/navigation2/blob/5547a20ae711417af90768d9d594a4524064e1ca/.circleci/config.yml#L163-L169

Also, the lock workflow is not intuitive to me.

The level of abstraction with caching results for colcon verbs, verbs that transitively depend on other verbs, makes this difficult to describe. The hashing of source files (or query to detected revision control) is only invoked with the "colcon cache lock" subverb. I suppose this could have been abbreviated to the root verb "colcon cache", but I suspected I may want to add more extension subverbs in the future, so I pushed that hashing funatilty into a "lock" subverb, as "colcon cache cache" seemed too peculiar.
The updating of lockfiles is currently simply a copy operation upon a successful task for the package, where the invoked colcon verb triggers an event handler that copies the lockfile from the verb it transitively depends upon. E.g. the build verb depends upon the cache verb, and the test verb depends upon the build verb. This pattern could be extended for any other verbs via more registered event handlers.

I think that a more detailed explanation (maybe annotating the example) of what creates and or modifies which lock files and what checks against the lock files are performed would be helpful.

I can add a "How does it work" section to the readme, but I'd first like to finish refactoring where the lockfiles are written and read from in the colcon workspace, as to store the lockfiles closer to the artifacts they claim to represent:

https://github.com/ruffsl/colcon-cache/pull/42

Thanks @ruffsl  for the explanation! The example of using a different --packages-select-cache-key makes it more clear to me now.
It is helpful to know that the build verb lock file is just copied from the cache verb. And I think that a "how it works" section would be very helpful.


Is this unsound?

These no-bounds-checking indexing operations on Storage: https://github.com/kvark/froggy/blob/master/src/lib.rs#L252-L269
I get that they're only so on release, but I'd expect the bounds checking to also happen on release by default (As is common in rust). Maybe a flag to disable it would make more sense

Sure looks unsound to me.  I think this was your example from Discord:
let mut storage = froggy::Storage::new();
let ptr1 = storage.create(1i32);
storage[&ptr1] = 2i32;
let mut storage2 = froggy::Storage::new();
storage2[&ptr1] = 2i32;

Yes, you are correct. We should keep the checks.


[Question] How to specify MessagePack settings using the management API

When using the management API - like
 var serviceManager = new ServiceManagerBuilder().WithOptions(o =>
                    {
                        o.ConnectionString = signalRConfiguration.ConnectionString;
                    })
                    .Build();

how can I tell it which MessagePack settings to use?
I understand that it automatically activates the MessagePack protocol, but I require specific configuration for MessagePack, how can I do that?
Thanks,
MR

Hi & thanks @wanlwanl ,
so, just to make sure I understand you correctly:
if I setup the serviceManager with
 var serviceManager = new ServiceManagerBuilder().WithOptions(o =>
                    {
                        o.ConnectionString = signalRConfiguration.ConnectionString;
                    })
                    .Build();

and then use it like this
await using var context =_serviceManager.CreateHubContextAsync(NotificationConstants.HubName);
await context.Clients.Group(groupName).SendCoreAsync(channel, arguments);

and on the client I add my messagepack settings into the .AddMessagePackProtocol() call, then it should just work?

I see, you not only need to add AddMessagePackProtocol, but also have custom options on it. We don't support it in Management SDK.

Is this something with any likelihood to change in the near future (let's define near as within the next 1-2months) or not?

alternatively, if, without doing any special configuration, with the default setup, I send a byte[], will this be sent over the wire in binary format (so the serialized size equals the length of the array) or will it be serialized to JSON (so the size would be many times the length of the array)?

No, we don't have a plan to change, since we also have a feature of upstream, when client send mesaage with special hub protocol, the signalr service cannot understand the special protocol. And we have no plan to support uploading it for now.
Thanks,
Wanpeng Li

From: ModernRonin @.>
Sent: Thursday, May 27, 2021 6:35:15 PM
To: Azure/azure-signalr @.>
Cc: Wanpeng Li @.>; Mention @.>
Subject: Re: [Azure/azure-signalr] [Question] How to specify MessagePack settings using the management API (#1284)
Is this something with any likelihood to change in the near future (let's define near as within the next 1-2months) or not?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-signalr%2Fissues%2F1284%23issuecomment-849525164&data=04|01|Wanpeng.Li%40microsoft.com|d14a222c29d540dcfc6208d920fb1e1d|72f988bf86f141af91ab2d7cd011db47|1|0|637577085191257489|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=LLLwiTuM6IimJ2vGYUEU%2BgfU8yuJMWDlu6UQJQdxxXo%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJDW7OLONIFT3KDUIURBVF3TPYN6HANCNFSM45P7O2ZQ&data=04|01|Wanpeng.Li%40microsoft.com|d14a222c29d540dcfc6208d920fb1e1d|72f988bf86f141af91ab2d7cd011db47|1|0|637577085191257489|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=yW5RqKjtIJxCJQcS5Twui0ZA%2F7yJ3fTrUAkoK97yPYU%3D&reserved=0.

Signalr service will only count outbound message (message that is go out of signalr service) for the protocol of client. So you can add message pack protocol to your client to avoid increasing billing (serialized to JSON for your client).

From: ModernRonin @.>
Sent: Thursday, May 27, 2021 6:42:13 PM
To: Azure/azure-signalr @.>
Cc: Wanpeng Li @.>; Mention @.>
Subject: Re: [Azure/azure-signalr] [Question] How to specify MessagePack settings using the management API (#1284)
alternatively, if, without doing any special configuration, with the default setup, I send a byte[], will this be sent over the wire in binary format (so the serialized size equals the length of the array) or will it be serialized to JSON (so the size would be many times the length of the array)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-signalr%2Fissues%2F1284%23issuecomment-849529132&data=04|01|Wanpeng.Li%40microsoft.com|2ce7d1f881b648686c3908d920fc1705|72f988bf86f141af91ab2d7cd011db47|1|0|637577089370606699|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=ktIQnrTs6RHVRz0%2FsCGUmuJ4SEetvxbnmrYsUdQqUbY%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJDW7OMWYFBRXLTQ5BUAVDDTPYOYLANCNFSM45P7O2ZQ&data=04|01|Wanpeng.Li%40microsoft.com|2ce7d1f881b648686c3908d920fc1705|72f988bf86f141af91ab2d7cd011db47|1|0|637577089370606699|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=b7smPVsoJ4JZaUYu8DV7FbuAyXD0znt%2F8zLg0ggIews%3D&reserved=0.

In default config, the management sdk calls rest api, which will serialize to json, but it will not impact the billing since it is inboind message.
But it can be slower. Suggest to use Persistent mode in WithOptions(...), it will create a websocket to signalr service to.communicate later, and use messagepack protocol inside, it is faster than the default one (transient mode) https://github.com/Azure/azure-signalr/blob/dev/docs/management-sdk-guide.md#transport-type
Thanks,
Wanpeng Li

From: Wanpeng Li @.>
Sent: Thursday, May 27, 2021 7:27:53 PM
To: Azure/azure-signalr @.>; Azure/azure-signalr @.>
Cc: Mention @.>
Subject: Re: [Azure/azure-signalr] [Question] How to specify MessagePack settings using the management API (#1284)
Signalr service will only count outbound message (message that is go out of signalr service) for the protocol of client. So you can add message pack protocol to your client to avoid increasing billing (serialized to JSON for your client).

From: ModernRonin @.>
Sent: Thursday, May 27, 2021 6:42:13 PM
To: Azure/azure-signalr @.>
Cc: Wanpeng Li @.>; Mention @.>
Subject: Re: [Azure/azure-signalr] [Question] How to specify MessagePack settings using the management API (#1284)
alternatively, if, without doing any special configuration, with the default setup, I send a byte[], will this be sent over the wire in binary format (so the serialized size equals the length of the array) or will it be serialized to JSON (so the size would be many times the length of the array)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-signalr%2Fissues%2F1284%23issuecomment-849529132&data=04|01|Wanpeng.Li%40microsoft.com|2ce7d1f881b648686c3908d920fc1705|72f988bf86f141af91ab2d7cd011db47|1|0|637577089370606699|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=ktIQnrTs6RHVRz0%2FsCGUmuJ4SEetvxbnmrYsUdQqUbY%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJDW7OMWYFBRXLTQ5BUAVDDTPYOYLANCNFSM45P7O2ZQ&data=04|01|Wanpeng.Li%40microsoft.com|2ce7d1f881b648686c3908d920fc1705|72f988bf86f141af91ab2d7cd011db47|1|0|637577089370606699|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=b7smPVsoJ4JZaUYu8DV7FbuAyXD0znt%2F8zLg0ggIews%3D&reserved=0.

thank you, Wanpeng Li, I will look into that!

Now MessagePack is also supported in the persistent mode and you could customize the MessagePack serialization options. Please note that this might break things if you also have SignalR Functions trigger to receive your client invocations because SignalR trigger uses default MessagePack serialization options. You could update your SDK to the latest version and follow the guide here .


Bugs while extracting issues from pull request/  pr-extract-issues code.

Hi
I found few below issues. could you please check and implement.
Note: I have used adding labels and remove labels at the same time.
Case 1:
if we use two bug/issue numbers in the pull request title/body, then its failing to remove the label on the second bug/issue number.
Case 2:
while using remove label, if label is not available in that issue/bug number then its failing.
Can we add if condition? if label is not available then can we ignore remove-label and add-label function should execute.
Case 3:
If I comment with issue/bug number in the pull request (Not body, pull requests comments), It is not working.
I think it is not implemented.
Could you please implement above scenarios and fix the bugs?

case 1: please provide how do you define?
case 2: can fix
case 3: will support

Thanks for quick response.
Case 1:
I defined in the pull request title like "issues #123 #456"
So, issue 123 is executing successfully, but it is failing to execute second one. Its getting error like "label does not exists"
Reproduce steps:

Create a two issues with the labels "L1" and "L2" (for example issue number #123 and #456)
Create a pull request with the title "Issues fixing #123 #456"
use the parameters
"issues-label (Add-lables) is "ready-for-testing"
"remove-label   is  "L1""
Then execute the GitHub action.

Hi
Any update on this?
And also, I found that like "if pull request merging with master branch, in that "commit" section getting pull request number also. in that case also it is failing.
I think, if label is does not exit then can we ignore?

I think, if label is does not exit then can we ignore?

yes

I guess, if we ignore that like "If label does not exit" then case 1 and case 2 will be resolve with that change.
only Case 3 need to be implement.

If label does not exit

has fixed.

about comment

I don't think it's necessary, if you are the auth or repository maintainer of this PR, you can just edit the PR without commenting.


Does not work, returns null values

Hello!
Your parser again stopped working.
Works only: App details
Do you plan to fix it?
➜  gp-download-info com.skype.raider | jq '.'
{ downloadSize: null,
  signature: null,
  downloadUrl: null,
  additionalFile: [],
  downloadAuthCookie: [],
  forwardLocked: null,
  refundTimeout: null,
  serverInitiated: null,
  postInstallRefundWindowMillis: null,
  immediateStartNeeded: null,
  patchData: null,
  encryptionParams: null,
  gzippedDownloadUrl: null,
  gzippedDownloadSize: null,
  splitDeliveryData: [],
  installLocation: null }

Thanks!

it works for me and I cannot reproduce this. what version of the library are you using? also check your ANDROID_ID (device) is checked in properly to google play services.

@dweinstein

what version of the library are you using

latest 4.3.1
I checked my ANDROID_ID, it gives empty values with it if I use the "gp-download-info, gp-download-meta, gp-get-sha1" method. And if you use the method "gp-details" then the data is given.
I checked on the ANDROID_ID of the second device, on it all the methods worked.
It turns out I got a ban? But after all on the phone everything is downloaded.
Any ideas?
p.s. If it's interesting to find out the reason, I can send data to the mail for input, as well as ANDROID_ID.

try setting DEBUG=gp:api

@dweinstein
➜  gp-download-meta com.skype.raider                                                                                ruby-2.4.0
TypeError: Cannot read property 'length' of null
    at unescape (/usr/local/lib/node_modules/google-play-cli/lib/app.js:5:30)
    at decodeDigest (/usr/local/lib/node_modules/google-play-cli/lib/app.js:9:21)
    at signatureToSha1 (/usr/local/lib/node_modules/google-play-cli/lib/app.js:13:10)
    at /usr/local/lib/node_modules/google-play-cli/lib/app.js:41:15
    at tryCatcher (/usr/local/lib/node_modules/gpapi/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/usr/local/lib/node_modules/gpapi/node_modules/bluebird/js/release/promise.js:512:31)
    at Promise._settlePromise (/usr/local/lib/node_modules/gpapi/node_modules/bluebird/js/release/promise.js:569:18)
    at Promise._settlePromise0 (/usr/local/lib/node_modules/gpapi/node_modules/bluebird/js/release/promise.js:614:10)
    at Promise._settlePromises (/usr/local/lib/node_modules/gpapi/node_modules/bluebird/js/release/promise.js:693:18)
    at Promise._fulfill (/usr/local/lib/node_modules/gpapi/node_modules/bluebird/js/release/promise.js:638:18)
    at Promise._resolveCallback (/usr/local/lib/node_modules/gpapi/node_modules/bluebird/js/release/promise.js:432:57)
    at Promise._settlePromiseFromHandler (/usr/local/lib/node_modules/gpapi/node_modules/bluebird/js/release/promise.js:524:17)
    at Promise._settlePromise (/usr/local/lib/node_modules/gpapi/node_modules/bluebird/js/release/promise.js:569:18)
    at Promise._settlePromise0 (/usr/local/lib/node_modules/gpapi/node_modules/bluebird/js/release/promise.js:614:10)
    at Promise._settlePromises (/usr/local/lib/node_modules/gpapi/node_modules/bluebird/js/release/promise.js:693:18)
    at Promise._fulfill (/usr/local/lib/node_modules/gpapi/node_modules/bluebird/js/release/promise.js:638:18)

@dweinstein
use example:
var api = require('gpapi').GooglePlayAPI({
    username: 'my mail',
    password: 'my pass',
    androidId: 'my id'
    // apiUserAgent: optional API agent override (see below)
    // downloadUserAgent: optional download agent override (see below)
});

api.downloadInfo("com.viber.voip").then(console.log);

Return error:
➜  DEBUG=gp:api                                                                                ruby-2.4.0
kota@iMac—Kota /usr/local/lib/node_modules/gpapi
➜  node test.js                                                                                ruby-2.4.0
Unhandled rejection Error
    at handleErr (/usr/local/lib/node_modules/gpapi/lib/api.js:247:31)
    at /usr/local/lib/node_modules/gpapi/lib/api.js:252:18
    at tryCatcher (/usr/local/lib/node_modules/gpapi/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/usr/local/lib/node_modules/gpapi/node_modules/bluebird/js/release/promise.js:509:35)
    at Promise._settlePromise (/usr/local/lib/node_modules/gpapi/node_modules/bluebird/js/release/promise.js:569:18)
    at Promise._settlePromise0 (/usr/local/lib/node_modules/gpapi/node_modules/bluebird/js/release/promise.js:614:10)
    at Promise._settlePromises (/usr/local/lib/node_modules/gpapi/node_modules/bluebird/js/release/promise.js:693:18)
    at Promise._fulfill (/usr/local/lib/node_modules/gpapi/node_modules/bluebird/js/release/promise.js:638:18)
    at PromiseArray._resolve (/usr/local/lib/node_modules/gpapi/node_modules/bluebird/js/release/promise_array.js:126:19)
    at PromiseArray._promiseFulfilled (/usr/local/lib/node_modules/gpapi/node_modules/bluebird/js/release/promise_array.js:144:14)
    at PromiseArray._iterate (/usr/local/lib/node_modules/gpapi/node_modules/bluebird/js/release/promise_array.js:114:31)
    at PromiseArray.init [as _init] (/usr/local/lib/node_modules/gpapi/node_modules/bluebird/js/release/promise_array.js:78:10)
    at Promise._settlePromise (/usr/local/lib/node_modules/gpapi/node_modules/bluebird/js/release/promise.js:566:21)
    at Promise._settlePromise0 (/usr/local/lib/node_modules/gpapi/node_modules/bluebird/js/release/promise.js:614:10)
    at Promise._settlePromises (/usr/local/lib/node_modules/gpapi/node_modules/bluebird/js/release/promise.js:693:18)
    at Promise._fulfill (/usr/local/lib/node_modules/gpapi/node_modules/bluebird/js/release/promise.js:638:18)

You ran with DEBUG= but you didn't run the gp-download-info command which is the one you said isn't working?

@dweinstein

You ran with DEBUG= but you didn't run the gp-download-info command which is the one you said isn't working?

The last log from gp-download-info  :)


[core] Update core-xml to support CDATA

Packages impacted by this PR

[core xml]

Issues associated with this PR
Describe the problem that is addressed by this PR
In order to get Azure Notification Hubs to work with Atom+XML, we need the following changes for core-xml:

Adds CDATA support for XML serialization using the cdataPropName.
Adds stop parser nodes via stopNodes so fields are not parsed such as XML or JSON fields.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
In order to support CDATA, we needed to add the ability to set the cdataPropName.  By default, this will be set to __cdata which does not affect any existing services using the parser.  Without doing this, the core-xml package our fields will not have CDATA and cannot be parsed by Notification Hubs.
const resource = {
  "BodyTemplate": { __cdata: "{Template for the body}" }
};
const stringify = stringifyXML(resource, { cdataPropName: "__cdata" });

This will result in the following:
<BodyTemplate><![CDATA[{Template for the body}]]></BodyTemplate>

There are also fields we do not wish to parse, such as a notification body that is put in an XML element, such as the following:
<NotificationBody><?xml version="1.0" encoding="utf-16"?><toast><visual><binding template="ToastText01"><text id="1">Hello from a .NET App!</text></binding></visual></toast></NotificationBody>

By default, the XML serializer will attempt to parse this field into its own complex object instead of keeping it as a string.  To stop this, we need to add support for stopNodes.
const result = await parseXML(xml, { includeRoot: true, stopNodes: ["NotificationBody"] });
console.log(NotificationDetails.NotificationBody);
//"<?xml version=\"1.0\" encoding=\"utf-16\"?><toast><visual><binding template=\"ToastText01\"><text id=\"1\">Hello from a .NET App!</text></binding></visual></toast>"

Are there test cases added in this PR? (If not, why?)
Yes, for both CDATA and StopNode support.
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[x] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[x] Added a changelog (if necessary)

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-core-xml

/azp run prepare-pipelines


Wrap pkg-config

Motivation for this change
Fix #86077
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

The LLVM test's dep's failure is unrelated, and the gcc one past locally.

Discussion regarding failure on staging https://github.com/NixOS/nixpkgs/issues/89170

Cross-compilation failure is now blocking staging-next https://github.com/NixOS/nixpkgs/pull/89388#issuecomment-639155770.


Use XDG for config directory default path, keep compatibility

As per subject.

Can you rebase via git pull --rebase origin master and git push --force?

Codecov Report

Merging #347 into master will decrease coverage by 0.22%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #347      +/-   ##
==========================================
- Coverage   75.67%   75.44%   -0.23%
==========================================
  Files           5        5
  Lines         777      782       +5
  Branches      226      227       +1
==========================================
+ Hits          588      590       +2
- Misses        136      137       +1
- Partials       53       55       +2

Impacted Files
Coverage Δ

tmuxp/cli.py
57.72% <100%> (+0.67%)
:arrow_up:

tmuxp/workspacebuilder.py
89.09% <0%> (-1.82%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2b8e94...f64ed5d. Read the comment docs.

I rebased on top of your master branch.


Add map/set support to isEqual

It'd be great if _.isEqual supported comparing maps and sets.

I'm working on this.

Any progress/update? (I'd love to assist, but don't want to make a redundant PR)

Here is my solution for Map objects: https://gist.github.com/BrokeRU/5ece2a775b4c3f576425d5fb30b09736

Special case of #2147.


Feature-request: c# support

Hi there!
I was hoping you could add C# support as well. Completion is taken care of by LSP (e.g. omnisharp and csharp-ls work great) so the only changes needed for great out-of-the-box experience is the commands (that currently don't work in *.cs files) and folding that could be handled by something like this:
au FileType cs set foldmethod=marker
au FileType cs set foldmarker={,}
au FileType cs set foldtext=substitute(getline(v:foldstart),'{.*','{...}',)
au FileType cs set foldlevelstart=2

I was thinking about making a separate plugin for C# users but it doesn't make much sense since I find myself experimenting with GD script examples all the time even though my project is written in C#.

I can't see how any of those fold settings are godot-specific.
And users who already have a C# ftplugin would be disrupted by installing a godot plugin -- they'd have to figure out how to turn it off. They might already be using foldmethod=indent or not want folding enabled by default. (Also vim's built-in cs filetype provides some folding for #regions which requires foldmethod=syntax.)
Making a separate C# plugin for brace folding would make a lot of sense. It would be unrelated to godot. Any users (Unity, Godot, etc) who want brace-driven folding could install it.

The main issue is those very useful commands don't work in cs buffers. Folding is a secondary thing I don't care much about.
As a side note, I solely mentioned folding because I had foldmethod=syntax in my $VIMRC and it didn't seem to do anything for cs files (but it might be due to my specific rc or some plugins so just ignore that part).
It's late at night and I'm answering on a mobile so I apologize for any mistakes.

Oh, I see, it's the run commands like :GodotRunCurrent that you're after. Maybe defining them could be pulled out into a command so users can invoke it from any ftplugin to setup godot commands (they're probably useful for C#, C++, python, etc).
To confirm they work properly in a C# project, do all four work correctly if you add this to your vimrc:
command! GodotRunCurrent call godot#run_current()
command! GodotRunLast call godot#run_last()
command! -nargs=? -complete=customlist,godot#scene_complete GodotRun call godot#run(<q-args>)
command! GodotRunFZF call godot#fzf_run_scene()


[Feature Request]: Labels/Taints for autoscaler_nodepools

Description
Since autoscaler respects labels and taints for scheduling pods, it would be great to be able to set labels and taints on the autoscaler node pools similar to the normal node pools. If that's already possible somehow, it would be great to document it since I couldn't find anything related to it.

Yep, it's possible! Will do ASAP, otherwise PR welcome, it needs to follow the same from as normal agents to propagate the values. So not a lot to be done, but it does need testing!

We are currently  already applying the default label / taints... maybe a set dedicated to the autoscaling nodes should be considered.
(see code here)

@ifeulner Yes, definitely, it's actually quite straightforward, just need to spend some time on it.

I'm trying to implement this feature but it does not seem that straightforward: the cluster autoscaler can only take one HCLOUD_CLOUD_INIT variable, which contains the taints and labels we want to set.
The solution I'm trying to implement is to split templates/autoscaler.yaml.tpl to make a dedicated template for the Deployment and template it with different names and labels (cluster-autoscaler-${autoscaler_pool_name}) to be able to give each autoscaler a different HCLOUD_CLOUD_INIT variable.
It means it will start one autoscaler deployment per autoscaled pool, which may not be desirable to everyone.
Should I continue this way or did I miss something that would make the configuration simpler? If I continue, be assured my pull request will contain some documentation update in order to warn users about this behavior.

I don't know of a simpler solution, and I would be impressed and happy if your plan is going to work!
-------- Oorspronkelijk bericht --------
Op 14 jun. 2023 16:36, schreef Sam D :

I'm trying to implement this feature but it does not seem that straightforward: the cluster autoscaler can only take one HCLOUD_CLOUD_INIT variable, which contains the taints and labels we want to set.
The solution I'm trying to implement is to split templates/autoscaler.yaml.tpl to make a dedicated template for the Deployment and template it with different names and labels (cluster-autoscaler-${autoscaler_pool_name}) to be able to give each autoscaler a different HCLOUD_CLOUD_INIT variable.
It means it will start one autoscaler deployment per autoscaled pool, which may not be desirable to everyone.
Should I continue this way or did I miss something that would make the configuration simpler? If I continue, be assured my pull request will contain some documentation update in order to warn users about this behavior.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

I started working on it today but I currently have an issue: the autoscaler does not trigger the scale up of the first node (even if I set min_nodes = 1).
I will continue to work on it next week.
If anyone want to try it, you can change the source of the kube-hetzner module in your kube.tf to:
source = "github.com/sambonbonne/terraform-hcloud-kube-hetzner?ref=feature%2F726-labels-and-taints-for-autoscaler-nodepools"

The source if readable on my fork, on a specific branch: github.com/sambonbonne/terraform-hcloud-kube-hetzner/tree/feature/726-labels-and-taints-for-autoscaler-nodepools.

I'm trying to implement this feature but it does not seem that straightforward: the cluster autoscaler can only take one HCLOUD_CLOUD_INIT variable, which contains the taints and labels we want to set.
The solution I'm trying to implement is to split templates/autoscaler.yaml.tpl to make a loop around the Deployment and template it with different names and labels (cluster-autoscaler-${autoscaler_pool_name}) to be able to give each autoscaler a different HCLOUD_CLOUD_INIT variable.
It means it will start one autoscaler deployment per autoscaled pool, which may not be desirable to everyone.

Having multiple autoscaler instances per cluster introduces at least more complexity... I think it is even not really supported.
Seems to be for me too much unknowns for a rare use case.

@ifeulner that's what I was thinking when implementing it, I wonder how it will work when someone will want to create multiple autoscaling nodes pools.
I can continue to work on it but I don't know if I will be able to test all the cases, I see at least:

creating one autoscaling nodes pool without labels and taints
creating multiple autoscaling nodes pools without labels and taints
create one autoscaling nodes pool with labels and taints
creating multiple autoscaling nodes pools with taints and labels

But your comment leads me to the critical question: if I make this contribution, will it be accepted upstream (in your repo)? If not, I'm not sure this is useful for me to continue. I do it because I have a client who needs an autoscaling nodes pool with taints and labels but if the feature is not implemented/accepted in terraform-hcloud-kube-hetzner, I won't work on it purposelessly.

@sambonbonne Thank you for picking this up. What would definitely be useful at this moment is a way to set custom global taints and labels for all nodepools, and what's needed is just mapping the value from two variables to here:
https://github.com/kube-hetzner/terraform-hcloud-kube-hetzner/blob/8b37fbed06e488ec218da14861bc3d68ff5d0a72/autoscaler-agents.tf#L69-L92
So it should be pretty straightforward. As for the per-nodepool ones, it seems hard if not impossible. However, up to you if you can demonstrate that it works properly. However, the above seems like a good middleground.

@mysticaltech yes that's what I was thinking, I think I can make it work per-nodepool but it means having one autoscaler Deployment per nodepool. @ifeulner seem to not like this solution (and I understand this adds some overhead).
So the main question is: if I implement a solution with one autoscaler per nodepool, may this solution be acceptable for you (by you, I mean the maintainers of this repository)?

@sambonbonne I just checked, and the Kubernetes autoscaler documentation advises to have a single autoscaler per Kubernetes cluster, especially when using cloud provider implementations. So in that case, it's not a feature we would want to support at this time.
That said, yes we can have globa autoscaler labels/taints that are customizable via variables.

I opened a pull request, I hope I did not forget anything: https://github.com/kube-hetzner/terraform-hcloud-kube-hetzner/pull/849

Released in v2.2.3! Awesome work @sambonbonne 🙏


Update client to use ESModules syntax

Problem
We recently shipped a fix to compatibility issues users were facing with our SDK when running in Edge runtimes.
While this seems to have fixed some problems for users running in Edge runtimes, another issue came to light while helping a community-forum poster: the way in which our Typescript files are transpiled (dictated by our tsconfig file) is in accordance with older Node versions, not more modern, popular Javascript syntax.
More info
Our tsconfig.json file dictated that our Typescript files get transpiled into es5 Javascript using the CommonJS module syntax. This is usually reserved for ensuring users can run packages using old versions of Node (e.g. <9).
Since we made the decision to no longer support versions of Node <18, having our tsconfig file transpile our Typescript in this older syntax doesn't make a whole lot of sense.
To bring our transpilation process up to date with newer versions of Node, it follows that we should update our "target" to "es2015" and our "module" to "ESNext".
There are many key differences between the two (explained in the article linked above), but the most important difference is that they use different syntax for loading and exporting Javascript modules.
How did this come to light?
There is a current, open issue on our community forum about using our SDK in an Edge runtime. While troubleshooting the Edge portion of this issue, it came to light that another problem this user was facing was related to how our Typescript files were being transpiled into Javascript.
When I looked into this user's stacktrace of the error, the highlighted lines were all lines that used the older, CommonJS module import syntax (require) instead of the newer ESModules import syntax (import).
Updating our tsconfig file to use ESModules instead of CommonJS will ensure our transpiles files use the more modern Javascript syntax, which should, in turn, allow users to embed our client within their modern Javascript apps (running in Edge or Node runtimes).
Solution
Update all compilation-related files to transpile Typescript files using ESModules syntax. I've ensured all unit and integration tests pass locally.
Notes

As part of the general upgrade from using CommonJS to ESModules syntax, we also had to upgrade the ways in which some tests run + upgrade the syntax used by our jest config files. Changes include:

ESModules import and export default syntax replacing old require and export.modules syntax in our jest.config....ts files for Node and Edge
Add "type": "module" to our package.json files in both our root dir and our compilation dir we use for CI testing (mandatory for running ESModules)
Add conditional stmts to our testing.yml file, in the compilation section, so that Node @types are specific to the different TS versions we test in the matrix.

Type of Change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Infrastructure change (CI configs, etc)
[ ] Non-code change (docs, etc)
[ ] None of the above: (explain here)

Test Plan
CI passes.

To see the specific tasks where the Asana app for GitHub is being used, see below:

https://app.asana.com/0/0/1208096908844885

Note: we are deprioritizing this work, as updating the client to work with ESM syntax is a larger project than we want to take on right now.


KeyError is raised instead of ArgumentError for updating map with pattern matching syntax

$ elixir -v
Elixir 1.0.5
$ erl -v
Erlang/OTP 18 [erts-7.0.3]

@jduan Could you take a look at this since this is introduced in https://github.com/seven1m/30-days-of-elixir/pull/19

Turns out it depends on Erlang version. https://github.com/elixir-lang/elixir/pull/3655#issuecomment-137085325
I'm gonna just close this pr.


Tutorial adding command

update NRIC

Codecov Report

Merging #11 (0205d74) into tutorial-adding-command (94141bb) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@                      Coverage Diff                      @@
##             tutorial-adding-command      #11      +/-   ##
=============================================================
- Coverage                      73.36%   73.31%   -0.06%
  Complexity                       433      433
=============================================================
  Files                             74       74
  Lines                           1333     1334       +1
  Branches                         140      140
=============================================================
  Hits                             978      978
- Misses                           316      317       +1
  Partials                          39       39

Impacted Files
Coverage Δ
Complexity Δ

src/main/java/seedu/address/model/person/Ic.java
70.00% <ø> (ø)
5.00 <0.00> (ø)

src/main/java/seedu/address/ui/PersonCard.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94141bb...0205d74. Read the comment docs.


Help us improve README.md

If you are a native english speaker and seek to help this project, you can always help by improving the README.md file.
Both the introduction text and the walkthrough section require some work.

Before improving this we need to make it work, see #22


Migrate to chartkick

I rule and have completed some work on Case Manager that's ready for review!
install chartkick and reproduce existing graphs
This pull request makes the following changes:

install chartkick
reformat JSON

(If there are changes to the views, please include a screenshot so we know what to look for!)
It relates to the following issue #s:

Fixes #1095

Codecov Report

Merging #1212 into master will increase coverage by 2.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1212      +/-   ##
==========================================
+ Coverage   93.21%   95.31%   +2.09%
==========================================
  Files          56       55       -1
  Lines        1224     1195      -29
==========================================
- Hits         1141     1139       -2
+ Misses         83       56      -27

Impacted Files
Coverage Δ

app/lib/reports/fulfillment.rb

app/controllers/reports_controller.rb
100% <0%> (+16.66%)
:arrow_up:

app/lib/reporting/patient.rb
100% <0%> (+33.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a12aacc...ad11bef. Read the comment docs.

I didn't get it to work. Sorry I should have mentioned it was a work in progress. The payload is still an issue. I wanted an opinion on whether the manipulation should be in the query or frontend.

No worries!
If the current output of the report method doesn't work with chartkick, probably we should change the reporting method, since those are intended to smoothly create a product that fits into whatever charting software we're using. There's a related ticket in #1201 to do more filtering in DB query side, since the current strategy of 'get em all and then mapreduce em' is tough at any scale besides small data, so we're going to have to do some wrenching in there anyway.
Do you have any interest in taking a whack at that? Happy to assign it out if not.

We're going with a somewhat different reporting model now per @SerenaYudon 's recent work in #659 so closing this for the time being. My fault for the lousy guidance here, sorry bud.


Master add sds get func and health check config

Issues associated with this PR
1、add RegisterSdsNativeClientFactory func
2、add logs for provider
3、add GetSdsClient func for sign feature
4、add InitialDelaySeconds config for healthChecker
5、add SetBindToPort for listener case of runtime start/stop bind port
6、add http dail healthchecker
Solutions
You should show your solutions about the issues in your PR, including the overall solutions, details and the changes. At this time, Chinese is allowed to describe these.
UT result
Unit Test is needed if the code is changed, your unit test should cover boundary cases, corner cases, and some exceptional cases. And you need to show the UT result.
Benchmark
If your code involves the processing of every request, you should give the Benchmark Result.
Code Style

Make sure Goimports has run
Show Golint result

PR拆分：
HTTP 健康检查相关的部分： #1942
SDS的诉求： #1945


[refactor](fe status) unify fe status code and remove cancel reason

Proposed changes
Currently, we could not get real cancel reason because the status is very mess. In this PR I do following:

add new method in status.java, like be code. user could use new status to create an error status with formatted error message.
using TStatusCode as cancel reason.
TStatusCode should be part of errorcodes in status.h, so that we could unify the error code in FE and BE.

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall

run buildall


[ENH] [BUG] Experimental

Trying to fix the numba closure issue, i.e. causing recompilation on every call.

Removing the single njit here, causes a runtime improve of 20-30x for me locally.
https://github.com/scikit-time/scikit-time/blob/c73f14422e38abbdb9f541145e461d272a10c312/sktime/distances/_distance.py#L1951

see this #141

Unfortunately, the distance factory is already part of the code in ElacstocEnsemble

This PR fixes the issue.
Before (Windows 3.9) :

After (Windows 3.9):

Elastic Ensemble is no longer in the list of slowest 10 methods.

Ill test EE classifier on the new distances branch and check the performance now though.

Hi @chrisholder , maybe this is a misconception :) The returned function is still numba-compiled. But the method to return the numba-compiled function is not. This is why it is not breaking anything and we do not have the closure problem any longer

I.e. callable(_x, _y) is still numba-compiled. But the method to return this callable is not any longer.

Sorry, i dont think I understand your code then.
What is this line doing:
global dist_callable

But this
dist_callable = distance_factory(x, y, metric="dtw")
This no longer would be a numba distance?

But this
dist_callable = distance_factory(x, y, metric="dtw")
This no longer would be a numba distance?

Were is or called like this?

Ill test EE classifier on the new distances branch and check the performance now though.

I am happy to go for your changes, once ready. In the mean time, we could go for this small change though, as it seems to work just fine?

So lets say I had
def example(x, y):
    # With this change this gives a python function
    dist = distance_factory(x, y, metric="dtw")

    @njit()
    def some_numba_function(ts1, ts2):
        return dist(ts1, ts2)

From my understanding (and sorry if im wrong!) the change would cause this to throw an error because you cant call a non numba function from inside a numba function.

Sure im happy for this to go in since there are changes coming soon for the distance module and this in the mean time will greatly improve development speed!

My opinion on it if you want speed (which I think we do) you just say give it a 2d array or it wont work and then you could delete this additional compilation:
@njit()
  def dist_callable(x: np.ndarray, y: np.ndarray):
      _x = _numba_to_timeseries(x)
      _y = _numba_to_timeseries(y)
      return callable(_x, _y)

and just return callable instead

sure! Totally agree. This was not adressed by this PR though, which only solves the numba compilation of the closure on every call as done in EE

So lets say I had
def example(x, y):
    # With this change this gives a python function
    dist = distance_factory(x, y, metric="dtw")

    @njit()
    def some_numba_function(ts1, ts2):
        return dist(ts1, ts2)

Thank you for approval. Will wait for merging to check this use case. I am interested in the result, too, bit do not have a PC right now :)
Would be great to hear from the results of EE in your branch, too.


onPress firing even though parent's display: 'none'

import { useEffect, useState } from 'react';
import { Pressable, Alert } from 'react-native';
import { Svg, Rect } from 'react-native-svg';

export default function App() {
	const [display, setDisplay] = useState('flex');

	useEffect(() => {
		setTimeout(() => setDisplay('none'), 1000);
	}, []);

	return (
		<Pressable onPress={() => Alert.alert('press')} style={{ display }}>
			<Svg width="100" height="100" viewBox="0 0 100 100">
				<Rect width="100" height="100" fill="black" />
			</Svg>
		</Pressable>
	);
}

Environment info
>npx react-native info
info Fetching system and libraries information...
System:
  OS: Windows 10 10.0.22621
  CPU: "(12) x64 AMD Ryzen 5 5600 6-Core Processor              "
  Memory: 17.01 GB / 31.91 GB
Binaries:
  Node:
    version: 20.2.0
    path: C:\Program Files\nodejs\node.EXE
  Yarn: Not Found
  npm:
    version: 9.7.2
    path: C:\Program Files\nodejs\npm.CMD
  Watchman: Not Found
SDKs:
  Android SDK: Not Found
  Windows SDK: Not Found
IDEs:
  Android Studio: Not Found
  Visual Studio:
    - 17.5.33424.131 (Visual Studio Community 2022)
Languages:
  Java:
    version: <IP_ADDRESS>
    path: C:\Program Files\Eclipse Adoptium\jdk-<IP_ADDRESS>-hotspot\bin\javac.EXE
  Ruby: Not Found
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.72.5
    wanted: 0.72.5
  react-native-windows: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: Not found
  newArchEnabled: Not found
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found

Library version: 13.13.0
https://github.com/software-mansion/react-native-svg/assets/36894700/c8d40e7e-1743-43b3-bc99-b0ef5aecb8d8

screen1

screen2

screen3 (the alert should be not popping up)

Related with: https://github.com/software-mansion/react-native-svg/issues/794

Workaround: https://github.com/software-mansion/react-native-svg/issues/794#issuecomment-427225419

Hi @szmarczak,
I think the issue is not valid anymore, however, if it is still not working for you, feel free to reopen the issue.
https://github.com/user-attachments/assets/df8d81ba-37ea-4841-972e-984e99cb2582


'Import private key' does nothing

I tried with 't' and 'zs', a wallet.dat from backup and a freshly generated one. I see nothing happening after I paste the info - no new addresses appear in the balances. So make sure to backup your wallet.dat. HD does work - I managed to generate the same new address as before and using --rescan to restore coins on it.

Did you try with the latest version 0.5.10? This might be a duplicate of #102
Basically, the import takes a long time, since it has to scan the entire blockchain, and the dialog wasn’t being shown at the start, giving the impression that nothing is happening. It was fixed in yesterday’s release.

Ah, ok, sorry. I was following a websockets version. When will you guys merge them? ))

Oh, right. I will merge websockets into main branch this week. We’ll have he public release of the android app this Friday, most likely.

Fantastic stuff! Could you also add an option to lauch zqw without graphic UI? I would love to run both zcashd and zec-qt-wallet on a headless linux server... And we need Address book to sync into the App )))

Closing this issue, we'll track the android address book on the android github


A question in test.py

Dear Jiang-HB:
I've been reviewing some portions of the code in test.py, and I've come across a section that raised a question in my mind, which I wanted to discuss with you.
In the following snippet from your code:
X, X_normal = data["src_pcd"].clone(), data["src_pcd_normal"].clone()
Y, Y_normal = data["model_pcd"].clone(), data["model_pcd_normal"].clone()
B = len(X)
H_t = torch.eye(4)[None].expand(B, -1, -1).to(opts.device)  # [B, 4, 4]

X_list = []
for t in range(opts.n_diff_steps, 1, -1):  # [T, T-1, ..., 1]
    X_t = (H_t[:, :3, :3] @ X.transpose(2, 1) + H_t[:, :3, [3]]).transpose(2, 1)  # [B, N, 3]

I noticed that within the for loop, you're using X as input for computation, rather than the previously computed X_T. From my understanding, this loop should be updating and utilizing the X_T computed from the previous iteration.
I'd like to confirm if the design intent of this code is correct, or if perhaps X should be initialized to the final X_T at the beginning of the loop. If possible, could you provide some insight into the purpose and design rationale behind this code snippet?
Thank you for your time and assistance. I look forward to hearing back from you.
Best regards,
cyxyz

Hi,
We indeed should feed previously computed X_t and M into the surrogate registration model for denoising  (see Eq.12, f_theta(X_t, M)). To this end, we compute X_t via transforming X with t-step denoising transformation H_t, that is X_t = T(X, H_t) = {R_t @ X_i + t_t} as demonstrated in sec. 3.2.2.
Best,
Haobo

Dear Haobo:
However, you know, I realized that during the initialization of H_t, the line H_t = torch.eye(4)[None].expand(B, -1, -1).to(opts.device) might cause the initial X_t to be X instead of the expected X_T.
Best,
cyxyz

Hi,Haobo
However, I realized that during the initialization of H_t, the line H_t = torch.eye(4)[None].expand(B, -1, -1).to(opts.device) might cause the initial X_t to be X instead of the expected X_T.
Best,
cyxyz

I want to know if there is a problem with my understanding. If you have time, could you help me solve it please?

Hi,
You can indeed randomly sample a rigid transformation, H_identity + random noise, as your initial transformation H_T like the common generative models (the random H_T can facilitate generating richer new data). However, the 3D registration task is inherently deterministic rather than generative. As such, we prefer to directly take the deterministic H_identity as our H_T. Table 2 in the paper also shows the performance comparison between the deterministic inference and the random inference.
Best regards,
Haobo

------------------ Original ------------------
From: @.>;
Date:  Sat, Apr 6, 2024 00:57 AM
To: @.>;
Cc: @.>; @.>;
Subject:  Re: [Jiang-HB/DiffusionReg] A question in test.py (Issue #6)

Hi,Haobo
However, I realized that during the initialization of H_t, the line H_t = torch.eye(4)[None].expand(B, -1, -1).to(opts.device) might cause the initial X_t to be X instead of the expected X_T.
Best,
cyxyz
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

Dear Jiang-HB,
I hope this message finds you well. I am writing to seek clarification regarding a particular set of operations performed in a code snippet. The snippet in question is as follows:
Rs_pred = H_0[:, :3, :3]
ts_pred = H_0[:, :3, 3]
Rs_pred = torch.inverse(Rs_pred)
ts_pred =  (- Rs_pred @ ts_pred[:, :, None])[:, :, 0]

Could you kindly provide some elucidation on the following points?
The rationale for computing the inverse of Rs_pred.
The significance of the subsequent matrix multiplication and slicing operations involving Rs_pred and ts_pred.
I am eager to gain a better understanding of these operations to facilitate my comprehension of the code's functionality. Any insights or explanations you could offer would be immensely helpful.
Thank you very much for your time and assistance. I look forward to your response.
Warm regards,
cyxyz

Hi,
Codes "Rs_pred = torch.inverse(Rs_pred) ts_pred =  (- Rs_pred @ ts_pred[:, :, None])[:, :, 0]" aims to convert the predicted rigid transformation (from the source to the model) into an inverse one (from the model to the source). The main reason for this operation is that the ground-truth rigid transformation is from the model to the source, and we need to keep the prediction and the label to be consistent for computing the precisions.
Best regards,
Haobo

Dear Jiang-HB,
I hope this email finds you well. I am writing to inquire about a particular aspect of denoising methodology that has been on my mind recently.
In the context of denoising, I have been considering the rationale behind choosing H_0H_t^{-1}H_t transformation. It appears to be a commonly employed approach, yet I find myself questioning why we don't opt for denoising at each step, utilizing the H_0 derived from the final denoising step, H_{t-1}, as the optimal transformation.
I believe that addressing this question will enhance my understanding of denoising processes and potentially offer insights into optimizing such techniques for various applications.
Your expertise in this field would be greatly appreciated, and I eagerly await your insights on this matter.
Thank you for your time and consideration.
Warm regards,
cyxyz

Hi,
You can pay attention on the lines between Eq. (10) and Eq.(11), where I have given detailed explains on this design. I hope these contents can facilitate your understanding.
Bests,
Haobo

Hi,
I understand why you're using H_0H_T^{-1} to solve for H_0, but I want to know why the H_0 obtained through H_{T-1} isn't the optimal transformation we seek in the end. It seems to me that in the process of adding noise, we gradually transform H_0 into the identity matrix H, so why isn't the denoising process achieved through H to obtain the final H_0 instead of solving for it throughout the process?
Bests,
cyxyz


Added nuget install script that excludes us from Strong Name verification

Apparently .NET straight up rejects delay signed assemblies even in full trust environments unless you exclude them manually using the Strong Name tool.
Todo:

[ ] Test this on windows (hfhf @moritzuehling)

[ ]  Test this on windows (hfhf @moritzuehling)

Did not work for me, is there a Travis run of this anywhere?

No, because this cannot be tested with Travis - Travis is linux-based, and the problem is windows-only.
If you want to resolve the problem manually run sn -Vu Path/To/DemoInfo.dll in the Visual Studio Command prompt.
After a restart of Visual Studio it should work. This is only a problem in the prerelease-package.


Error Executing HWI on Windows 11 with BitBox02

Hey, I did a fresh install of Sparrow 1.8.1 with admin rights.
I wanted to scan my HW but got the following error: Error Executing HWI
I couldnt find a solution online yet.
I get this error even if BitBox app is open and if I open the Sparrow Wallet with admin rights.
Below is the log file, seems that HWI is missing.
sparrow.txt

The error is actually Die angeforderte Adresse ist in diesem Kontext ung ltig. Unfortunately, HWI checks for simulators running on ports 2222, 21324, 11044, or 9999. In this case, it appears that port 21324 is responsible. Check if anything is running on that port.

The error is actually Die angeforderte Adresse ist in diesem Kontext ung ltig. Unfortunately, HWI checks for simulators running on ports 2222, 21324, 11044, or 9999. In this case, it appears that port 21324 is responsible. Check if anything is running on that port.

Nothing runs on this port.

The error is occurring on trying to make a UDP connection to <IP_ADDRESS>:21324. The error message, which I have translated as "The requested address is invalid in this context" seems to suggest that there is something here unsupported in your network stack. This could also be related to AV or firewall (although the error message doesn't suggest it).
You might want to try investigating this further with something like netcat: https://stackoverflow.com/questions/6336941/windows-bat-or-cmd-send-some-data-to-a-localhost-udp-port

I have found the problem... Even if I added the Sparrow wallet to split tunneling with MullvadVPN, this seems to have been the problem. As soon as I deactivate MullvadVPN, the search for the hardware wallet works.
So: switch off the VPN.


go fmt go file warning

Go:1.13
when go fmt the go file which including requirement to "github.com/go-xorm/core":
/usr/local/go/bin/go fmt /Users/neal/project/gshark/models/models.go #gosetup
go: github.com/go-xorm/core<EMAIL_ADDRESS>parsing go.mod:
	module declares its path as: xorm.io/core
	        but was required as: github.com/go-xorm/core

go.mod
	github.com/go-xorm/core v0.6.2
	github.com/go-xorm/xorm v0.7.1

xorm.io/core


Fix several search result bugs

This addresses several issues with /api/search and /search pages:

SuperAdmin mode was not respected by the metadata search/search API/search box. Now enabling superAdmin will show all results in DB that match.
The search omission message wasn't behaving properly at the end of the autoscroll. It would erroneously say it had omitted results on the final page even if it had not (i.e. with superAdmin fix above) due to an edge case bug. I fixed the bug in the code, but...
due to the change in permissions handling on service, the user will NO LONGER SEE OMITTED COUNTS. i.e. if you search "test" without permissions there might be 111 results in Db for superadmin but you'll see 0. we can discuss if this is controversial. fix applies to both search GUI pages.
fixed a dev line that snuck in from a previous PR that was restricting the search GUI to fetching results 2 at a time (!). this didn't affect API calls.

Any thoughts of what I can check?

Hmm, that is not working as intended, I expect to see 0 in the first case (or, 8 with them actually listed). This could mean elasticsearch finds resources that pass its ownership filter:
            permitted.foreach(ps => {
              builder.startObject().startObject("match").field("child_of", ps.stringify).endObject().endObject()
            })

            // Also include anything the user owns
            builder.startObject().startObject("match").field("creator", u.id.stringify).endObject().endObject()```

...but those resources are subsequently rejected by Clowder's MongoDB permission check:

```val filesList = if (superAdmin)
      files.get(response.results.filter(_.resourceType == 'file).map(_.id)).found
    else
      files.get(Permission.checkPermissions(user, Permission.ViewFile,
        response.results.filter(_.resourceType == 'file)).approved.map(_.id)).found```

This PR shouldn't require a reindex, although since you did one that counts out a few possibilities (elasticsearch having records for files that no longer exist, for example). Two things to check:

- What do you see with /api/search e.g. http://localhost:9000/api/search?query=test ?
- in api.Search search() around line 58 if you add a log:
```val response = plugin.search(query, resource_type, datasetid, collectionid, spaceid, folderid, field, tag, from_index, size, permitted, request.user)
        Logger.debug(response.results.toString) // ADD THIS
        val result = SearchUtils.prepareSearchResponse(response, source_url, request.user)
        Ok(toJson(result))```

...you should see the 8 IDs elasticsearch finds that you aren't seeing. can you view these in Clowder? anything unusual?

I have no meetings today (Thursday) so we can hop on a call to debug for 20 mins if you want too.

Had a call with @lmarini and we tracked this down to a discrepancy with space permissions vs. file permissions. Created an issue here: https://github.com/clowder-framework/clowder/issues/125 and removed total result count from search results, this  should avoid user confusion until better solution is possible.


Response size is limited by the Development/HttpClient AL Function Response Size setting

Please add to the documentation that the size of the response is limited by the Service Tier configuration setting Development / "HttpClient AL Function Response Size". Default is 15MB

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: eb27052e-5f74-353b-a5da-c32c0d14e417
Version Independent ID: 97d595ac-8dcb-76ac-4b82-52520f97ade5
Content: HttpResponseMessage Data Type - Business Central
Content Source: dev-itpro/developer/methods-auto/httpresponsemessage/httpresponsemessage-data-type.md
Service: dynamics365-business-central
GitHub Login: @solsen
Microsoft Alias: solsen

Thanks for the feedback, much appreciated! We will update this topic with the next refresh.


Fixing SequenceLoss Keras incompatibility

Fixing the incompatibility issue between the SequenceLoss and Keras built-in training loops by adding support for dense targets. For more information please refer to #375

@qlzh727 Can you take a quick look when you have time?


Reach system for the scroll wheel : )

Minepy txt.txt
I left a comment in your vid about the gravity-lerp problem.

Thank you! Will check this out, buddy!


500 Server Error after adding openid connect provider

Description
Instead of an informative error message i get an 500 Server Error.
Log:
.../providers_openid.go:42:CreateGothProvider() [W] [640291c5] Failed to create OpenID Connect Provider with name 'xxx' with url 'openid.xxx': Get "openid.xxx": unsupported protocol scheme ""
I think it would be possible to give this info in the Webinterface
The next 500 Server Error happens if the discovery URL returns HTML content.
Gitea Version
1.18.5
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
i use an release from Github on Uberspace
see this Guide for more info:
https://lab.uberspace.de/guide_gitea/
Database
MySQL

Could yuo check your URL in config? Maybe it should be "https://openid.xxx" but not "openid.xxx"

yes that is true. and i solved my problem but i would propose to make a more useful message than an 500 Server Error.

i think Gitea answers a lot of things with a 500 Server Error instead of an useful error message in cases in which it is possible to make an message, that describes the Problem, gives some useful information and could allow the user to change the input.

Agree to improve. There are a lot of 500 errors in Gitea, which is very unfriendly to end users.
It just needs time and manpower to clean them one by one .....

i have a same problem.
I set up an openid provider with keycloack. return {"error":"invalid_grant","error_description":"Code not valid"}
gitea logs:

2023/03/10 12:32:03 ...rs/web/auth/oauth.go:914:SignInOAuthCallback() [E] [640ab2c3] UserSignIn: oauth2: cannot fetch token: 400 Bad Request

Response: {"error":"invalid_grant","error_description":"Code not valid"}

2023/03/10 12:32:03 [640ab2c3] router: completed GET /user/oauth2/sso/callback?state=c5cf88da-769b-417b-a451-901244628e34&session_state=74ca5811-632b-4de3-a59a-0be4b8370212&code=c1af9b2c-657b-4569-9b1f-49e7c6e2d5c0.74ca5811-632b-4de3-a59a-0be4b8370212.f9fe9635-f7bd-408a-900a-0711fd0c5d2f for ...:0, 500 Internal Server Error in 451.5ms @ auth/oauth.go:877(auth.SignInOAuthCallback)

keycloak logs:

12:32:03,582 WARN  [org.keycloak.events] (default task-21) type=CODE_TO_TOKEN_ERROR, realmId=xhkj, clientId=gitea_fanle_work, userId=3d4b845d-f6f3-4559-8b64-9f9094ce9712, ipAddress=..., error=not_allowed, grant_type=authorization_code, code_id=74ca5811-632b-4de3-a59a-0be4b8370212, client_auth_method=client-secret

12:32:03,585 WARN  [org.keycloak.protocol.oidc.utils.OAuth2CodeParser] (default task-21) Code 'c1af9b2c-657b-4569-9b1f-49e7c6e2d5c0' already used for userSession '74ca5811-632b-4de3-a59a-0be4b8370212' and client 'f9fe9635-f7bd-408a-900a-0711fd0c5d2f'.

12:32:03,586 WARN  [org.keycloak.events] (default task-21) type=CODE_TO_TOKEN_ERROR, realmId=xhkj, clientId=gitea_fanle_work, userId=null, ipAddress=..., error=invalid_code, grant_type=authorization_code, code_id=74ca5811-632b-4de3-a59a-0be4b8370212, client_auth_method=client-secret


Feat/optimistic response

This adds optimistic response to ApolloHooksMutation and updates the Persons example to show how to correctly construct an optimistic response that apollo can understand.

looks good to me! after that comment we're good to merge

Released under v4.1.0


Feature Request: Simplify Public API

Hi, there is no option for a feature request or a question so I had to use the bug template but cleared everything inside, jfyi.
I was looking for a basic django admin autocomplete solution that supported django 4+ and stumbled upon this one and from the readme docs it looks fine but I was curious if you were planning on making the public api simpler.  I haven't started using this yet, just browsing but wanted to ask regardless.
@admin.register(Post)
class PostAdmin(DALFModelAdmin):
    list_filter = (
        ('author', DALFRelatedOnlyField),    # if author has a post!
        ('category', DALFRelatedFieldAjax),  # enable ajax completion for category field (FK)
        ('tags', DALFRelatedFieldAjax),      # enable ajax completion for tags field (M2M)
    )

This is fine but I'd prefer
@admin.register(Post)
class PostAdmin(DALFModelAdmin):
    # Perhaps an optional argument deciding if all relations should automatically be converted to autocomplete filters?
    # list_filters_are_autocomplete_list_filters = True  # should be default imo but I don't mind, I already have a base admin class
    list_filter = (
        'author',
        'category',
        'tags',
    )

I've checked the admin code and I think this is as simple as registering a Lookup to the ORM. Same concept apparently.
# some init file or some file that's imported during usage of this library

from django.db.models import OneToOneField, ForeignKey, ManyToManyField
from django.contrib.admin.filters import FieldListFilter

# functools.partial doesn't work because isinstance is a CPython function that doesn't take keyword arguments, *sigh*
type_checker = lambda klass: lambda item: isinstance(item, klass)

FieldListFilter.register(type_checker(OneToOneField), DALFRelatedOnlyField)
FieldListFilter.register(type_checker(ForeignKey), DALFRelatedFieldAjax)
FieldListFilter.register(type_checker(ManyToManyField), DALFRelatedFieldAjax)

# If you want to implement list_filters_are_autocomplete_list_filters the flag from the above example,
# I believe you should be able to wrap the second argument of FieldListFilter.register instead of just putting DALFRelatedOnlyField

# For the below function to work you need list_filters_are_autocomplete_list_filters=default_boolean set in the DALFModelAdmin

def decide_filter_class(filter_class):
    # Django doesn't provide any better way to hook into this place for us to decide on a filter class easier if we want to
    # tie it to a condition on the model_admin class
    def get_filter_class(field, request, lookup_params, model, model_admin, field_path):
        if model_admin.list_filters_are_autocomplete_list_filters:
            return filter_class
        for test, list_filter_class in FieldListFilter._field_list_filters:
            # If it equals and list_filters_are_autocomplete_list_filters we already returned above
            if test(field) and list_filter_class != filter_class:
                return list_filter_class(field, request, params, model, model_admin, field_path=field_path)
    return get_filter_class

FieldListFilter.register(type_checker(OneToOneField), decide_filter_class(DALFRelatedOnlyField))
FieldListFilter.register(type_checker(ForeignKey), decide_filter_class(DALFRelatedFieldAjax))
FieldListFilter.register(type_checker(ManyToManyField), decide_filter_class(DALFRelatedFieldAjax))

I'm not sure if I got the whole idea behind DALFRelatedFieldAjax vs DALFRelatedOnlyField at a first glance but ^ method should allow you to set the distinction I believe.
I haven't tested out the code at all but from the looks of django's source code and your code this seems like it should work.

well, that would be lovely if you implement it and make PR <3


pipeWith with composed piping function

Hi,
pipeWith is a great function. We can use it to pipe with Promise pipe(then) or with passing undefined like in the docs pipe(unless(isNil).
But if we want to do both and composing then and unless(isNil), we end up with:
pipeWith( (f,res) => pipe(then, unless(isNil))(f)(res) )
It would be better and more expressive to have:
pipeWith( pipe(then, unless(isNil)) )
In the pipeWith code, xf should be called twice with each argument instead of once and should be curried for retrocompatibility.

Please feel free to open a PR for this.

I will

In javascript the only way to check if a binary function is curried is to call the function with undefined as the second argument and check that it returns a function. So it means calling the function twice eventually (first with undefined and then with the correct argument) and dealing with potential exceptions.
You probably want to stay with the chosen definition of pipeWith. For people who want a more expressive version of pipeWith can define:
const pipeWithCurried = pipe(uncurryN(2), pipeWith)

... and since JS functions are proper values, that is actually not even a guarantee.  I guess you can tell that it's not curried if you call it with one parameter and get back something that's not a function, but... eww.


python312Packages.imap-tools: 1.6.0 -> 1.7.0

Description of changes
Diff: https://github.com/ikvk/imap_tools/compare/refs/tags/v1.6.0...v1.7.0
Changelog: https://github.com/ikvk/imap_tools/blob/v1.7.0/docs/release_notes.rst

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 326097 run on x86_64-linux 1

9 packages built:

paperless-ngx
python311Packages.deltachat
python311Packages.deltachat.dist
python311Packages.imap-tools
python311Packages.imap-tools.dist
python312Packages.deltachat
python312Packages.deltachat.dist
python312Packages.imap-tools
python312Packages.imap-tools.dist


Do closures really need to be marked as escaping?

There may be something I'm not seeing here, but it doesn't look like any of XCGLogger's closure parameters are ever actually stored. Would it be possible to tag them as nonescaping?
The problem with leaving them as escaping is that the compiler flags calls like
log.info("This object has \(children.count) children")

as suspect. You have to write out self.children.count to suppress the warning.

I've updated the master branch to use your suggestion here, and this will propagate to the 2.0 branch shortly. Thanks for the PR.

This is now in the updated Swift_2.0 branch. Thanks!