Interesting, thoughts for opal-phaser-examples?

Thanks for your beginning of the tutorial here.  We've been using Sinatra just to rough things out for opal-phaser, but I got to thinking maybe we should give volt a little more facetime with our efforts.  Admitting that I haven't had time to dig into volt yet, could you give a quick tip on how you might consider framing the examples that we're putting together within the volt framework?  Right now it's been pretty much just running a config.ru in each example folder so that as you're going through it, you just bundle exec rackup to get your context, but ultimately we're going to flesh this out much more so that it's on our own website and thus volt should serve us better in that regard.
At any rate, was hoping you could give some tips to perhaps use volt in a dirty way initially here or offer some advice on restructuring the current project to be more conducive for building it out with volt tying it together.

Honestly the framework is too young and I've not enough context to truly answer this question with any justice. If you can flesh our specific needs/goals I can help more.


Execute the Survey service under a dedicated non-root user account

Motivation and Context
The principle of using least privilege should be followed when executing code within containers. Specifically, not running as root.
IMPORTANT: Note that this change must be merged at the same time as the pull request to update the Kubernetes manifests for this change.
What has changed
The Dockerfile has been changed:

cURL should not be installed as it increases the attack surface of the container
Create a dedicated non-root user account for executing the Go code

How to test?
I tested this change by creating a differently tagged Docker image and deploying to my Kubernetes cluster. I verified that:

The pod started successfully
The Kubernetes readiness and liveness probes succeeded
There were no errors in the container logs
exec-ing into the container showed the Go process running as the expected non-root user account

Links
https://github.com/ONSdigital/census-rm-kubernetes/pull/29

Might be worth looking at proper multi-stage docker builds, especially here where the final container should pretty much only need to run the resultant binary.
see https://github.com/ONSdigital/go-party/blob/master/Dockerfile for similar (though not necessarily identical!) build

Do not merge - changes required if https://github.com/ONSdigital/census-rm-kubernetes/pull/4 is merged first.

Closing this PR as the service is soon to be retired and as a precaution against a vulnerability in Github


added package.json

Added package.json for the repository

Hmm this is a good idea. I'll upload it to NPM this afternoon.

Hey @izifortune you're pull request is going to be the guinea pig for a library I just wrote to handle PR's. I may have to close/open the PR a few times, sorry.

The npm package is registered at v1.0.8 - https://www.npmjs.com/package/matchmedia-ng
Thanks again for the PR

Thank you,
I'm try to switch to npm only dependencies and having this it's great.
On Sat, Feb 27, 2016, 6:09 PM Jason Kulatunga<EMAIL_ADDRESS>wrote:

The npm package is registered at v1.0.8 -
https://www.npmjs.com/package/matchmedia-ng
Thanks again for the PR
—
Reply to this email directly or view it on GitHub
https://github.com/AnalogJ/matchmedia-ng/pull/17#issuecomment-189696698.


Workflows - Add support for base models on GCS

Currently, training script can download base models from S3. We need to add support for GCS as well.

@savan77 is this complete?

@rushtehrani yes, let me close this.


Ocean Status Table - Experimenter configurable ordering

The experimenters should be able to configure the ordering of the fishers in the ocean status table.
Ordering options should include:

[ ] Static; current user on top
[ ] Static; current user in middle
[ ] Static; current user on bottom
[ ] Dynamic; descending by fish caught this season
[ ] Dynamic; descending by fish caught overall
[ ] Dynamic; descending by $ this season
[ ] Dynamic; descending by $ overall

Clarifying on "static", how about the following:

Static; current user on top
Static; current user on bottom
Dynamic; descending by fish caught this season
Dynamic; descending by fish caught overall
Dynamic; descending by $ this season
Dynamic; descending by $ overall

:+1: Looks good to me, I'll edit the first issue to keep the info at the top. I think I would also add a "Static; current user in middle"

Cool!


Add support for QuickLogic devices

This PR adds support for the following QuickLogic devices:

EOS-S3 (https://www.quicklogic.com/products/eos-s3/)
PolarPro 3E (https://www.quicklogic.com/products/fpga/fpgas-sram/#polarpro3e)

CC @mithro

By tradition, scripts are named by their manufacturer, so this would be synth_antmicro not synth_quicklogic.

By tradition, scripts are named by their manufacturer, so this would be synth_antmicro not synth_quicklogic.

those scripts control synthesis process for QuickLogic's chips, not Antmicro's. It's QuickLogic who manufactures the chips.

This also needs tests.

Adding black-boxes for multiplier cells is not enough for Yosys to use them; look at mul2dsp.v for a helper script to map to your cells.

@ZirconiumX thanks for the review, we'll add the tests and take a look on the multiplier cells.
BTW can you give me a hint how to debug the problem causing CI to fail? It fails only in GCC 4.8 run. I wasn't able to reproduce it locally. I used Ubuntu 16.04 docker image with GCC 4.8 in local tests. Any help here is appreciated.

I'm reasonably sure that whatever it is, it's not related to this PR.

I'm reasonably sure that whatever it is, it's not related to this PR.

indeed, doesn't seem to be related

@daveshah1 I think we've addressed all the issues. Could you re-review?

@daveshah1 I've addressed your comments and pushed fixes.

Sorry, I'm not the right person to review this. (Unless you wanted me to confirm that you've spelled "coarse" correctly this time?)
Do you have a SEDA support contract? If so, get in touch with your rep and we'll assign someone to work with you asap.

Hi @daveshah1, could you re-review this then?

Looks like all the issues in my most recent review are now resolved.

@daveshah1 Right, Waiting for the CI now

Looking fwd to this.
FWIW, I built this branch merged with master yesterday. Seems to work ok.

I don't have merge powers, so it's not up to me whether this PR lands or
not. I'm just giving feedback from experience.
On Tue, 23 Jun 2020 at 16:53, Karol Gugala<EMAIL_ADDRESS>wrote:

@kgugala commented on this pull request.
In techlibs/quicklogic/synth_quicklogic.cc
https://github.com/YosysHQ/yosys/pull/1816#discussion_r444329958:

       run("proc");

       if (flatten || help_mode)

           run("flatten", "(with '-flatten')");

   }

   if (check_label("coarse")) {

       run("tribuf -logic");

       run("deminout");

       run("opt");

       run("opt_clean");

       run("check");

       run("peepopt");

       run("opt_clean");

       run("check");

       run("techmap");

       run("abc -lut 1:4");

@ZirconiumX https://github.com/ZirconiumX can we land this PR and work
on further optimizations later?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/YosysHQ/yosys/pull/1816#discussion_r444329958, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AALPDWY6JYRAD6VQ7P37WVDRYDFWDANCNFSM4LUDAOWQ
.

One more general question: where can I find some proper documentation for these chips, and in particular the cell library?  The S3 TRM has a grand total of one page dedicated to the logic cell...

Okay, this PR has been sat here with no activity since July. Let's give it a bump, because while there's a lot of cleanup still necessary, it's better for everyone if we get this merged sooner rather than later.

Here's what I think needs to be done to make this mergeable:

The LUT permutation code needs to be removed, because you can just use a different input ordering.
Much of the FF techmap rules can be replaced with a dfflegalize call to Do The Right Thing.

It's probably best to just have a simple $_DLATCH_ rule, much like iCE40 has.

The FF mapping needs to be a separate step before the LUT mapping, rather than both performed simultaneously.
Please actually, properly fix the logic_cell_macro model
Use the existing common tests where available, instead of different copies.

Hey, is there any intention to get this merged upstream? (I know its been a while, but it would be cool to see this in the repo!) @kgugala


Update framework so that it can be used in Xcode 12

Currently when adding the framework to an Xcode 12 created project  it complains that the module ViewControllerPresentationSpy was compiled with Swift 5.2.4 and it cannot be imported by the Swift 5.3 compiler.
Would it be possible to have the framework updated so that it can be imported by the Swift 5.3 compiler?

Sorry I didn't notice your issue until now.
Should be fixed in https://github.com/jonreid/ViewControllerPresentationSpy/releases/tag/v5.1.0


Ember version rev

Ran ember init, cleaned up a bit. This branch is running with errors.

Errors:
The Broccoli Plugin: [SourceMapConcat: Concat: Vendor /assets/vendor.js] failed with:
Error: ENOENT: no such file or directory, open '/Users/potus/Code/wildland/ember-bootstrap-controls/tmp/source_map_concat-input_base_path-2HdEpwhm.tmp/undefined/bootstrap-datepicker/dist/js/bootstrap-datepicker.js'
    at Error (native)
    at Object.fs.openSync (fs.js:640:18)
    at Object.fs.readFileSync (fs.js:508:33)
    at SourceMap.addFile (/Users/potus/Code/wildland/ember-bootstrap-controls/node_modules/fast-sourcemap-concat/lib/source-map.js:75:31)
    at /Users/potus/Code/wildland/ember-bootstrap-controls/node_modules/broccoli-concat/concat.js:200:16
    at Array.forEach (native)
    at Concat.<anonymous> (/Users/potus/Code/wildland/ember-bootstrap-controls/node_modules/broccoli-concat/concat.js:198:24)
    at /Users/potus/Code/wildland/ember-bootstrap-controls/node_modules/fast-sourcemap-concat/lib/source-map.js:393:12
    at initializePromise (/Users/potus/Code/wildland/ember-bootstrap-controls/node_modules/rsvp/dist/rsvp.js:589:5)
    at new Promise (/Users/potus/Code/wildland/ember-bootstrap-controls/node_modules/rsvp/dist/rsvp.js:1077:31)

We want to start the new Labbee project on Ember 2.x. We have to rev quite a few libraries before Trailhead will run successfully on Ember 2.x.

Why are we using Ember 2.x on that project? The time that will add is very expensive.

Just need to define the cost to do this and where it is coming from.

Closing in favor of #83


[Issue #246] Added the result box, formatted with third party prettyjson

Took the results from the ajax request and displayed them in a popup result box
Formatted the message using suggested thirdparty application from https://github.com/warfares/pretty-json

@kishore-narendran and @zuozhiw can you review it?
@Jimmy-VVang Can you add some screentshots?

This PR is ready to merge.


Typos in arguments

While poking through this yesterday, I found a few typos in arguments for the various functions there. I think it's probably worthwhile to fix them up. I'll just use this issue to make a list of all the ones I notice, and then pull a PR to fix all of the naming at once so everything can be done consistently.

typo: link to source
guassian: https://github.com/GOMC-WSU/MoSDeF-dihedral-fit/blob/af1afef7efd6c639d2cf5400d0ecaac6edeadcc9/mosdef_dihedral_fit/utils/file_read_and_write.py#L296
I think there are 59 examples of this in file_read_write.py.


Hole Feature - Water fall through holes option

Some may want water on top of their holes, but some like me, may like their water to fall through the holes to create a water fall into the abyss. Well maybe not all the way through, but at least fade into the hole. At least an option for water to not float on top of the holes 🤔 😄

Maybe a waterfall mesh system inside of the water mesh generator that builds a different mesh, similar to how the water mesh is built in the painted water area, but follows the hole splatshape geometry to flow down in stead of horizontal? I had talked with @spimort about water zones and underwater screen shading at some point I think, but never really made a feature request since I feel like certain things are up to the developer using terrabrush to implement, but having more water effects like this might be good if enough are available.

Making a waterfall system for TerraBrush would be super cool!
But I think it would be hard to make it fit with all the game styles.
Let's say you want to have "splashes" where the water reaches the bottom. Maybe some games will have particles. Maybe some won't have splashes at all, etc.
Idk, maybe for now it would be easier if every project handles it the way they want?
It's still a good suggestion, and maybe we'll find a way to make it work for all projects, but it requires some thinking.


Linting

In this PR:

Setup .eslintrc.json file with airbnb style guide, babel-eslint parser (allows arrow functions in React classes), rule to allow js or jsx filenames for React components, set jest to true in env so it doesn't complain about jest methods
Tidy up config.js
Tidy up BE files inside /src - stuff to discuss: #93
Tidy up FE files inside /client - stuff to discuss: propTypes and static
Get rid of unnecessary for loop,  Closes #83
Closes #74

@jamiecoe when renaming files I would use git mv command otherwise git will read it as a whole file being deleted as well as a new file being created. Not overly important but it helps when looking at PRs.

Thanks @matthewdking! Will do next time 👍


[Enhancement/Suggestion] Support for Vulkan Mod?

@VulkanMod

Vulkanmod seems to work fine, feel free to re-open if you do find anything wrong with it however.


SFLOW-1: Configure default network instance

Need to configure the default network instance before using it.

Pull Request Functional Test Report for #2641 / f793387c373da67be0f3bddf679e5446c4072f31
Virtual Devices

Device
Test
Test Documentation
Job
Raw Log

Arista cEOS

SFLOW-1: sFlow Configuration and Sampling

Cisco 8000E

SFLOW-1: sFlow Configuration and Sampling

Cisco XRd

SFLOW-1: sFlow Configuration and Sampling

Juniper cPTX

SFLOW-1: sFlow Configuration and Sampling

Juniper ncPTX

SFLOW-1: sFlow Configuration and Sampling

Nokia SR Linux

SFLOW-1: sFlow Configuration and Sampling

Openconfig Lemming

SFLOW-1: sFlow Configuration and Sampling

Hardware Devices

Device
Test
Test Documentation
Raw Log

Arista 7808

SFLOW-1: sFlow Configuration and Sampling

Cisco 8808

SFLOW-1: sFlow Configuration and Sampling

Juniper PTX10008

SFLOW-1: sFlow Configuration and Sampling

Nokia 7250 IXR-10e

SFLOW-1: sFlow Configuration and Sampling

Help

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 52.141%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1668

Relevant Lines:
3199

💛  - Coveralls

/fptest all

/fptest virtual


Osx part2

Hi,
This is a PR where I post the remaining modifications I had to do in order to get babyloncpp to run under OSX.
Glsl version:

Last week I updated the ImGui OpenGL version from 2.x to 3.x. I tried setting the GLFW hints the
same as your settings but some scenes did not render as they should. Strangely, I did not get any > shader compilation error on the version number like you had. I did not try replacing all instances of > "#version 300 es" by "#version 330" in the shader sources. This should make a difference I
assume, and I will try this later this week. For now, I am still using GL 3.0 on my side.

I added babylon/shaders/shadersinclude/glsl_version_3.h  with the following content :

#ifndef __APPLE__
#define BABYLONCPP_GLSL_VERSION_3 "#version 300 es\n"
#else
#define BABYLONCPP_GLSL_VERSION_3 "#version 330\n"
#endif

And I used it as a replacement over the rest of the code. I had tried your suggestion to use _processShaderConversion  but it did not work. Beware, I am not expert with OpenGL, so there might be better alternatives. What I saw however is that it makes it possible to run the code under OSX.
Travis build
I also added an osx build for travis. I had to parallelize the build, since it was taking too much time.
Inspector

The inspector runs in a separate GLFW window. This was the easiest to implement and in that way I can exclude it from the build on untested platforms. I also render the GUI at 10 fps instead compared to the 60 fps of the scene. Getting the layout of that scene graph right kept me busy for some time, having the colored icons and selectable tree items is not really straightforward in ImGui.

Concerning the inspector, there is good news. It did not work under OSX last time, and now it works after your last modifications.

Since the release of Babylon.js 4.0 I am back to my old routine, meaning porting the code during Monday-Friday and bug fixing/improving feature support during my weekends.

One quick question: what is the motivation that drives you to work on this project? Are you using it as a part of you job, or is it mainly by passion?

I still cannot run it under a Window VM (it crashes the VM), and under Linux (with an error message that says "GLFW Error occured, Error id: 65543, Description: Requested OpenGL version 3.0, got version 2.1. Failed to create window". Do you have a hint on how to solve the issue under linux?

I also worked on a different subject. I do not know if you will be interested, but I tried to add a sample browser to the gui. The problem is that I had to add it to the inspector window, which is closed and reopened whenever a new sample is launched (which makes the usage a bit annoying). Anyway, here is a link to a demo : https://www.youtube.com/watch?v=rD1y6Jo9_KA&feature=youtu.be . If you are interested, I can submit a PR for this.
Regards

Hi Pascal,

This is a PR where I post the remaining modifications I had to do in order to get babyloncpp to run under OSX.

Thank you very much for this PR! I don't have a mac so your help is more than welcome and much appreciated for supporting this platform!

Glsl version:

Last week I updated the ImGui OpenGL version from 2.x to 3.x. I tried setting the GLFW hints the
same as your settings but some scenes did not render as they should. Strangely, I did not get any > shader compilation error on the version number like you had. I did not try replacing all instances of > "#version 300 es" by "#version 330" in the shader sources. This should make a difference I
assume, and I will try this later this week. For now, I am still using GL 3.0 on my side.

I added babylon/shaders/shadersinclude/glsl_version_3.h  with the following content :

#ifndef __APPLE__
#define BABYLONCPP_GLSL_VERSION_3 "#version 300 es\n"
#else
#define BABYLONCPP_GLSL_VERSION_3 "#version 330\n"
#endif

And I used it as a replacement over the rest of the code. I had tried your suggestion to use _processShaderConversion  but it did not work. Beware, I am not expert with OpenGL, so there might be better alternatives. What I saw however is that it makes it possible to run the code under OSX.

This looks ok to me. I tried on Linux with the same changes you did to support OSX, but wireframes are not rendering. For this reason, I will continue using version 300 es on my side. For preparing the shader store I have the script codegeneration/generate_shader_store.py, but changing this file would not really resolve the problem you had so the extra file you added is the best solution.

Travis build
I also added an osx build for travis. I had to parallelize the build, since it was taking too much time.
Inspector

Thanks again, this will help finding compilation issues on osx build. The build time is indeed high, there are a couple of key classes such as the Scene class that is used in a lot of other classes, and modification in those classes trigger a whole rebuild. Last year, I already did an effort to reduce the build time by using forward declarations where possible. The changes resulted in a decrease of the build time with 10min on my machine. If you see other options for optimization feel free to let me know.

The inspector runs in a separate GLFW window. This was the easiest to implement and in that way I can exclude it from the build on untested platforms. I also render the GUI at 10 fps instead compared to the 60 fps of the scene. Getting the layout of that scene graph right kept me busy for some time, having the colored icons and selectable tree items is not really straightforward in ImGui.

Concerning the inspector, there is good news. It did not work under OSX last time, and now it works after your last modifications.

Indeed, that is good news!

Since the release of Babylon.js 4.0 I am back to my old routine, meaning porting the code during Monday-Friday and bug fixing/improving feature support during my weekends.

One quick question: what is the motivation that drives you to work on this project? Are you using it as a part of you job, or is it mainly by passion?

I mainly started this project as a hobby project to keep up with latest C++ standards and to learn more about 3d graphics programming. Instead of reading books or watching online tutorial videos, I wanted to learn by try out things myself in a non-toy like project. The skills I learned by working on this project really helped in my daily job and also made it easier to find a new job.
What keeps me motivated is the constant visible progress. My rule is to make an improvement every day, this can take a short time (like 10min) or much longer, depending how much time I have. These daily improvements became routine. Having a scene, demonstrating a feature of this engine, properly rendering is actually very rewarding. Furthermore, the Babylon.js 4.0 demo videos are really impressive, and seem to be worth spending a part of my free time working towards.

I still cannot run it under a Window VM (it crashes the VM), and under Linux (with an error message that says "GLFW Error occured, Error id: 65543, Description: Requested OpenGL version 3.0, got version 2.1. Failed to create window". Do you have a hint on how to solve the issue under linux?

Regarding VMs, I don't have good experience with OpenGL support in those environments. Most of them only support OpenGL up to version 2.0 or do software emulation. Babylon.js supports WebGL 1.0 which is basically OpenGL ES 2.0. Maybe something you can try is lowering the OpenGL version in the OpenGL hints:
glfwWindowHint(GLFW_CONTEXT_VERSION_MAJOR, 2);
glfwWindowHint(GLFW_CONTEXT_VERSION_MINOR, 0);

I am developing on an Intel NUC 7th generation, these are not really expensive and even with the onboard GPU I am getting 60 fps for all examples scenes. In case you have an older machine that still runs Windows you might be better of than a VM for testing Windows support.

I also worked on a different subject. I do not know if you will be interested, but I tried to add a sample browser to the gui. The problem is that I had to add it to the inspector window, which is closed and reopened whenever a new sample is launched (which makes the usage a bit annoying). Anyway, here is a link to a demo : https://www.youtube.com/watch?v=rD1y6Jo9_KA&feature=youtu.be . If you are interested, I can submit a PR for this.

Yes, this looks very handy for loading scenes. Feel free to do a pull request,
For the moment the inspector is coupled to a scene, and launching a new scene results in reopening of the inspector window. There are a couple of options, we can make the SampleLauncher GUI based (meaning you can select an example scene from the GUI instead of command-line) and integrate the Inpector panels within this GUI once you load a scene. The sample launcher GUI can then stay open all the time, allowing to select another scenes.
For a time I worked on implementing an ImGUI GUI similar to the Lumix Engine:

I stopped the implementation because I got stuck on rendering a scene to an ImGUI window and could not make the rendering of ImGUI and the 3D scene working within the same GLFW window. Having one window where a scene can be loaded with the inspector panels in dockable windows and rendering the scene in an ImGUI window is something that really would improve the usability of this project. I looked into backing up the OpenGL state just before rendering ImGUI and restoring the state when the scene should be rendered, but this did not work as expected. An alternative solution is to render the scene to a texture and using this texture as an image in an ImGUI window. I did not try this last option yet. Now that we use the ImGUI OpenGL 3 version the issue might be less complex.
You seem to having a lot of experience with C++ and ImGUI (and probably also with 3D rendering). From your side, would there be interest in helping with implementing a GUI similar to the Lumix Engine? We can start small and start from an existing template project such as imgui_docking_minimal or another one. Move existing Inspector panels to the dockable windows and add the scene loading. At this moment there is no support yet for scene serialization, but I can look further into this. A Babylon.js editor clone is probably a step too far, but having a single window SampleLauncher and Inspector with scene loading is something that can be achieved in a matter of weeks. The only de-risking that needs to be done first is having the scene rendering in a (dockable) ImGUI window.

Regards

Best regards,
Sam

Hi,
Give me a few days, and I’ll study if it is feasible.
Regards


Update comp_pixel_versions.py

If you meant in code:
Chaldean Numerology
The numerical value of quarant in Chaldean Numerology is: 2
Pythagorean Numerology
The numerical value of quarant in Pythagorean Numerology is: 2
Then you may leave it as quarant, while:
Using the logic of by analogy reasoning, you have used before in the same file word of quadrant ⇒ quadrant again.
Geometrically, I understand quadrant/quarant means here the box(rectangular) of adjacent pixels.

Please don't bother with alternative versions folder.


chore(deps): update terraform aws to v4.54.0

This PR contains the following updates:

Package
Type
Update
Change

aws (source)
required_provider
minor
4.15.1 -> 4.54.0

Release Notes

hashicorp/terraform-provider-aws
v4.54.0
Compare Source
NOTES:

provider: Resolves provider crashes reporting Error: Plugin did not respond and fatal error: concurrent map writes with updated upstream package (terraform-plugin-log) (#29269)
resource/aws_networkmanager_core_network: The policy_document attribute is being deprecated in favor of the new aws_networkmanager_core_network_policy_attachment resource. (#29097)

FEATURES:

New Resource: aws_evidently_launch (#28752)
New Resource: aws_lightsail_bucket_access_key (#28699)
New Resource: aws_networkmanager_core_network_policy_attachment (#29097)

ENHANCEMENTS:

data-source/aws_cloudtrail_service_account: Add service account ID for ap-southeast-4 AWS Region (#29103)
data-source/aws_elb_hosted_zone_id: Add hosted zone ID for ap-southeast-4 AWS Region (#29103)
data-source/aws_lb_hosted_zone_id: Add hosted zone IDs for ap-southeast-4 AWS Region (#29103)
data-source/aws_s3_bucket: Add hosted zone ID for ap-south-2 AWS Region (#29103)
data-source/aws_s3_bucket: Add hosted zone ID for ap-southeast-4 AWS Region (#29103)
provider: Support ap-southeast-4 as a valid AWS region (#29329)
resource/aws_dynamodb_table: Add arn, stream_arn, and stream_label attributes to replica to obtain this information for replicas (#29269)
resource/aws_efs_mount_target: Add configurable timeouts for Create and Delete (#27991)
resource/aws_lambda_function: Add replace_security_groups_on_destroy and replacement_security_group_ids attributes (#29289)
resource/aws_networkfirewall_firewall: Add ip_address_type attribute to the subnet_mapping configuration block (#29010)
resource/aws_networkmanager_core_network: Add base_policy_region and create_base_policy arguments (#29097)

BUG FIXES:

data-source/aws_kms_key: Reinstate support for KMS multi-Region key ID or ARN values for the key_id argument (#29266)
resource/aws_cloudwatch_log_group: Fix IAM eventual consistency error when setting a retention policy (#29325)
resource/aws_dynamodb_table: Avoid recreating table replicas when enabling PITR on them (#29269)
resource/aws_ec2_client_vpn_endpoint: Change authentication_options from TypeList to TypeSet as order is not significant (#29294)
resource/aws_kms_grant: Retries until valid principal ARNs are returned instead of not updating state (#29245)
resource/aws_opsworks_permission: stack_id and user_arn are both Required and ForceNew (#27991)
resource/aws_prometheus_workspace: Create a logging configuration on resource update if none existed previously (#27472)
resource/aws_s3_bucket: Fix crash when logging is empty (#29243)
resource/aws_sns_topic: Fixes potential race condition when reading policy document. (#29226)
resource/aws_sns_topic_policy: Fixes potential race condition when reading policy document. (#29226)

v4.53.0
Compare Source
ENHANCEMENTS:

provider: Adds structured fields in logging (#29223)
provider: Masks authentication fields in HTTP header logging (#29223)

v4.52.0
Compare Source
NOTES:

resource/aws_dynamodb_table: In the past, in certain situations, kms_key_arn could be populated with the default DynamoDB key alias/aws/dynamodb. This was an error because it would then be sent back to AWS and should not be. (#29102)
resource/aws_dynamodb_table: In the past, in certain situations, server_side_encryption.0.kms_key_arn or replica.*.kms_key_arn could be populated with the default DynamoDB key alias/aws/dynamodb. This was an error because it would then be sent back to AWS and should not be. (#29102)
resource/aws_dynamodb_table: Updating replica.*.kms_key_arn or replica.*.point_in_time_recovery, when the replica's kms_key_arn is set, requires recreating the replica. (#29102)
resource/aws_dynamodb_table_replica: Updating kms_key_arn forces replacement of the replica now as required to re-encrypt the replica (#29102)

FEATURES:

New Data Source: aws_auditmanager_framework (#28989)
New Resource: aws_auditmanager_assessment_delegation (#29099)
New Resource: aws_auditmanager_framework_share (#29049)
New Resource: aws_auditmanager_organization_admin_account_registration (#29018)

ENHANCEMENTS:

resource/aws_wafv2_rule_group: Add oversize_handling argument to body block of the field_to_match block (#29082)

BUG FIXES:

resource/aws_api_gateway_integration: Prevent drift of connection_type attribute when aws_api_gateway_deployment triggers are used (#29016)
resource/aws_dynamodb_table: Fix perpetual diffs when using default AWS-managed keys (#29102)
resource/aws_dynamodb_table: Fix to allow updating of replica.*.kms_key_arn (#29102)
resource/aws_dynamodb_table: Fix to allow updating of replica.*.point_in_time_recovery when a replica has kms_key_arn set (#29102)
resource/aws_dynamodb_table: Fix unexpected state 'DISABLED' error when waiting for PITR to update (#29086)
resource/aws_dynamodb_table_replica: Fix to allow creation of the replica without errors when kms_key_arn is set (#29102)
resource/aws_dynamodb_table_replica: Fix to allow updating of kms_key_arn (#29102)
resource/aws_medialive_channel: Add missing rate_control_mode in acc_settings for audio_descriptions (#29051)
resource/aws_medialive_input: Fix eventual consistency error when updating (#29051)
resource/aws_vpc_ipam_pool_cidr_allocation: Added support for eventual consistency on read operations after create. (#29022)
resource/aws_wafv2_web_acl: Fix error when setting aws_managed_rules_bot_control_rule_set in manage_rule_group_config (#28810)

v4.51.0
Compare Source
NOTES:

resource/aws_ce_anomaly_subscription: Deprecate threshold argument in favour of threshold_expression (#28573)

FEATURES:

New Data Source: aws_auditmanager_control (#28967)
New Resource: aws_datasync_location_object_storage (#23154)
New Resource: aws_rds_export_task (#28831)
New Resource: aws_resourceexplorer2_view (#28841)

ENHANCEMENTS:

resource/aws_appmesh_gateway_route: Add port on the match attribute for routes (#27799)
resource/aws_appmesh_route: Add port on the weighted_target attribute (#27799)
resource/aws_appmesh_virtual_gateway: Add the functionality to be able specify multi listeners (#27799)
resource/aws_appmesh_virtual_node: Add the functionality to be able specify multi listeners (#27799)
resource/aws_appmesh_virtual_router: Add the functionality to be able specify multi listeners (#27799)
resource/aws_apprunner_service: Add source_configuration.code_repository.code_configuration.runtime_environment_secrets and source_configuration.image_repository.image_configuration.runtime_environment_secrets argument (#28871)
resource/aws_ce_anomaly_subscription: Add threshold_expression argument (#28573)
resource/aws_grafana_workspace: Add configuration argument (#28569)
resource/aws_imagbuilder_component: Add skip_destroy argument (#28905)
resource/aws_lambda_event_source_mapping: Add scaling_config argument (#28876)
resource/aws_lambda_function: Add configurable timeout for Update (#28963)
resource/aws_rum_app_monitor: Add custom_events argument (#28431)
resource/aws_servicecatalog_portfolio_share: Add share_principals argument (#28619)

BUG FIXES:

data-source/aws_eks_cluster: Add outpost_config.control_plane_placement attribute (#28924)
data-source/aws_identitystore_group: Restore use of ListGroups API when filter is specified (#28937)
data-source/aws_identitystore_user: Restore use of ListUsers API when filter is specified (#28937)
data-source/aws_lambda_function: Fix AccessDeniedException errors in AWS Regions where AWS Signer is not supported (#28963)
data-source/aws_lambda_function: Remove any qualifier from invoke_arn (#28963)
resource/aws_appstream_image_builder: Fix IAM eventual consistency error for optional role (#26677)
resource/aws_appstream_image_builder: Fix refresh error when domain_join_info and vpc_config are not empty (#26677)
resource/aws_elasticsearch_domain: Prevent persistent iops diff (#28901)
resource/aws_grafana_workspace: Fix updating vpc_configuration (#28569)
resource/aws_iam_server_certificate: Avoid errors on delete when no error occurred (#28968)
resource/aws_lambda_function: Don't persist invalid filename, s3_bucket, s3_key or s3_object_version values on resource Update (#28963)
resource/aws_lambda_function: Retry ResourceNotFoundException errors on resource Create (#28963)
resource/aws_lb_listener_certificate: Show errors in certain cases where they were previously only logged and resource was removed from state (#28968)
resource/aws_opensearch_domain: Omit throughput and iops for unsupported volume types (#28862)
resource/aws_sagemaker_app: Correctly list all apps so as not to lose track in an environment where there are many apps (#28561)

v4.50.0
Compare Source
FEATURES:

New Data Source: aws_lbs (#27161)
New Resource: aws_sesv2_configuration_set_event_destination (#27565)

ENHANCEMENTS:

data-source/aws_lb_target_group: Support querying by tags (#27261)
resource/aws_redshiftdata_statement: Add workgroup_name argument (#28751)
resource/aws_service_discovery_service: Add type argument (#28778)

BUG FIXES:

resource/aws_acmpca_policy: Improve refresh to avoid unnecessary diffs in policy (#28788)
resource/aws_api_gateway_rest_api: Improve refresh to avoid unnecessary diffs in policy (#28789)
resource/aws_api_gateway_rest_api_policy: Improve refresh to avoid unnecessary diffs in policy (#28789)
resource/aws_apprunner_service: observability_configuration_arn is optional (#28620)
resource/aws_apprunner_vpc_connector: Fix default_tags not handled correctly (#28736)
resource/aws_appstream_stack: Fix panic on user_settings update (#28766)
resource/aws_appstream_stack: Prevent unnecessary replacements on update (#28766)
resource/aws_backup_vault_policy: Improve refresh to avoid unnecessary diffs in policy (#28791)
resource/aws_cloudsearch_domain_service_access_policy: Improve refresh to avoid unnecessary diffs in access_policy (#28792)
resource/aws_cloudwatch_event_bus_policy: Improve refresh to avoid unnecessary diffs in policy (#28802)
resource/aws_codeartifact_domain_permissions_policy: Improve refresh to avoid unnecessary diffs in policy_document (#28794)
resource/aws_codeartifact_repository_permissions_policy: Improve refresh to avoid unnecessary diffs in policy_document (#28794)
resource/aws_codebuild_resource_policy: Improve refresh to avoid unnecessary diffs in policy (#28796)
resource/aws_dms_replication_subnet_group: Fix error ("Provider produced inconsistent result") when an error is encountered during creation (#28748)
resource/aws_dms_replication_task: Allow updates to aws_dms_replication_task even when migration_type and table_mappings have not changed (#28047)
resource/aws_dms_replication_task: Fix error with cdc_path when used with aws_dms_s3_endpoint (#28704)
resource/aws_dms_s3_endpoint: Fix error with cdc_path when used with aws_dms_replication_task (#28704)
resource/aws_ecr_registry_policy: Improve refresh to avoid unnecessary diffs in policy (#28799)
resource/aws_ecr_repository_policy: Improve refresh to avoid unnecessary diffs in policy (#28799)
resource/aws_ecrpublic_repository_policy: Improve refresh to avoid unnecessary diffs in policy (#28799)
resource/aws_efs_file_system_policy: Improve refresh to avoid unnecessary diffs in policy (#28800)
resource/aws_elasticsearch_domain: Improve refresh to avoid unnecessary diffs in access_policies (#28801)
resource/aws_elasticsearch_domain_policy: Improve refresh to avoid unnecessary diffs in access_policies (#28801)
resource/aws_glacier_vault: Improve refresh to avoid unnecessary diffs in access_policy (#28804)
resource/aws_glacier_vault_lock: Improve refresh to avoid unnecessary diffs in policy (#28804)
resource/aws_glue_resource_policy: Improve refresh to avoid unnecessary diffs in policy (#28807)
resource/aws_iam_group_policy: Fixed issue that could result in "inconsistent final plan" errors (#28868)
resource/aws_iam_group_policy: Improve refresh to avoid unnecessary diffs in policy (#28777)
resource/aws_iam_group_policy: Improve refresh to avoid unnecessary diffs in policy (#28836)
resource/aws_iam_policy: Improve refresh to avoid unnecessary diffs in policy (#28777)
resource/aws_iam_policy: Improve refresh to avoid unnecessary diffs in policy, tags (#28836)
resource/aws_iam_role: Fixed issue that could result in "inconsistent final plan" errors (#28868)
resource/aws_iam_role: Improve refresh to avoid unnecessary diffs in assume_role_policy and inline_policy policy (#28777)
resource/aws_iam_role: Improve refresh to avoid unnecessary diffs in inline_policy.*.policy, tags (#28836)
resource/aws_iam_role_policy: Fixed issue that could result in "inconsistent final plan" errors (#28868)
resource/aws_iam_role_policy: Improve refresh to avoid unnecessary diffs in policy (#28777)
resource/aws_iam_role_policy: Improve refresh to avoid unnecessary diffs in policy (#28836)
resource/aws_iam_user_policy: Fixed issue that could result in "inconsistent final plan" errors (#28868)
resource/aws_iam_user_policy: Improve refresh to avoid unnecessary diffs in policy (#28777)
resource/aws_iam_user_policy: Improve refresh to avoid unnecessary diffs in policy (#28836)
resource/aws_iot_policy: Improve refresh to avoid unnecessary diffs in policy (#28838)
resource/aws_kms_external_key: Improve refresh to avoid unnecessary diffs in policy (#28853)
resource/aws_kms_key: Improve refresh to avoid unnecessary diffs in policy (#28853)
resource/aws_lb_target_group: Change protocol_version to ForceNew (#17845)
resource/aws_lb_target_group: When creating a new target group, return an error if there is an existing target group with the same name. Use terraform import for existing target groups (#26977)
resource/aws_mq_configuration: Improve refresh to avoid unnecessary diffs in data (#28837)
resource/aws_s3_access_point: Improve refresh to avoid unnecessary diffs in policy (#28866)
resource/aws_s3_bucket: Improve refresh to avoid unnecessary diffs in policy (#28855)
resource/aws_s3_bucket_policy: Improve refresh to avoid unnecessary diffs in policy (#28855)
resource/aws_s3control_access_point_policy: Improve refresh to avoid unnecessary diffs in policy (#28866)
resource/aws_s3control_bucket_policy: Improve refresh to avoid unnecessary diffs in policy (#28866)
resource/aws_s3control_multi_region_access_point_policy: Improve refresh to avoid unnecessary diffs in details policy (#28866)
resource/aws_s3control_object_lambda_access_point_policy: Improve refresh to avoid unnecessary diffs in policy (#28866)
resource/aws_sagemaker_model_package_group_policy: Improve refresh to avoid unnecessary diffs in resource_policy (#28865)
resource/aws_schemas_registry_policy: Improve refresh to avoid unnecessary diffs in policy (#28864)
resource/aws_secretsmanager_secret: Improve refresh to avoid unnecessary diffs in policy (#28863)
resource/aws_secretsmanager_secret_policy: Improve refresh to avoid unnecessary diffs in policy (#28863)
resource/aws_ses_identity_policy: Improve refresh to avoid unnecessary diffs in policy (#28861)
resource/aws_sns_topic: Improve refresh to avoid unnecessary diffs in policy (#28860)
resource/aws_sns_topic_policy: Improve refresh to avoid unnecessary diffs in policy (#28860)
resource/aws_sqs_queue: Improve refresh to avoid unnecessary diffs in policy (#28840)
resource/aws_sqs_queue_policy: Improve refresh to avoid unnecessary diffs in policy (#28840)
resource/aws_transfer_access: Improve refresh to avoid unnecessary diffs in policy (#28859)
resource/aws_transfer_user: Improve refresh to avoid unnecessary diffs in policy (#28859)
resource/aws_vpc_endpoint: Improve refresh to avoid unnecessary diffs in policy (#28798)
resource/aws_vpc_endpoint_policy: Improve refresh to avoid unnecessary diffs in policy (#28798)

v4.49.0
Compare Source
NOTES:

resource/aws_dms_endpoint: For s3_settings cdc_min_file_size, AWS changed the multiplier to kilobytes instead of megabytes. In other words, prior to the change, a value of 32 represented 32 MiB. After the change, a value of 32 represents 32 KB. Change your configuration accordingly. (#28578)
resource/aws_fsx_ontap_storage_virtual_machine: The subtype attribute is no longer deprecated (#28567)

FEATURES:

New Data Source: aws_s3control_multi_region_access_point (#28373)
New Resource: aws_appsync_type (#28437)
New Resource: aws_auditmanager_assessment (#28643)
New Resource: aws_auditmanager_assessment_report (#28663)
New Resource: aws_ec2_instance_state (#28639)
New Resource: aws_lightsail_bucket (#28585)
New Resource: aws_ssoadmin_instance_access_control_attributes (#23317)

ENHANCEMENTS:

data-source/aws_autoscaling_group: Add desired_capacity_type attribute (#28658)
data-source/aws_kms_secrets: Add encryption_algorithm and key_id arguments in support of asymmetric keys (#21054)
resource/aws_appflow_connector_profile: Add support for connector_type CustomConnector. Add cluster_identifier, database_name, and data_api_role_arn attributes for redshift connection_profile_properties (#26766)
resource/aws_appsync_resolver: Add runtime and code arguments (#28436)
resource/aws_appsync_resolver: Add plan time validation for caching_config.ttl (#28436)
resource/aws_athena_workgroup: Add configuration.execution_role argument (#28420)
resource/aws_autoscaling_group: Add desired_capacity_type argument (#28658)
resource/aws_dms_endpoint: Change s3_settings cdc_min_file_size default to 32000 in order to align with AWS's change from megabytes to kilobytes for this setting (#28578)
resource/aws_ecs_service: Add alarms argument (#28521)
resource/aws_lightsail_instance: Add add_on configuration block. (#28602)
resource/aws_lightsail_instance_public_ports: Add cidr_list_aliases argument (#28376)
resource/aws_s3_access_point: Add bucket_account_id argument (#28564)
resource/aws_s3control_storage_lens_configuration: Add advanced_cost_optimization_metrics, advanced_data_protection_metrics, and detailed_status_code_metrics arguments to the storage_lens_configuration.account_level and storage_lens_configuration.account_level.bucket_level configuration blocks (#28564)
resource/aws_wafv2_rule_group: Add rule.action.captcha argument (#28435)
resource/aws_wafv2_web_acl: Add rule.action.challenge argument (#28305)
resource/aws_wafv2_web_acl: Add support for ManagedRuleGroupConfig (#28594)

BUG FIXES:

data-source/aws_cloudwatch_log_group: Restore use of ListTagsLogGroup API (#28492)
resource/aws_cloudwatch_log_group: Restore use of ListTagsLogGroup, TagLogGroup and UntagLogGroup APIs (#28492)
resource/aws_dms_endpoint: Add s3 setting ignore_header_rows and deprecate misspelled ignore_headers_row. (#28579)
resource/aws_elasticache_user_group_association: Retry on InvalidUserGroupState errors to handle concurrent updates (#28689)
resource/aws_lambda_function_url: Fix removal of cors configuration block (#28439)
resource/aws_lightsail_database: The availability_zone attribute is now optional/computed to support HA bundle_ids (#28590)
resource/aws_lightsail_disk_attachment: Resolves a panic when an attachment fails and attempts to display the error returned by AWS. (#28593)

v4.48.0
Compare Source
FEATURES:

New Resource: aws_dx_macsec_key_association (#26274)

ENHANCEMENTS:

resource/aws_dx_connection: Add encryption_mode and request_macsec arguments and macsec_capable and port_encryption_status attributes in support of MACsec (#26274)
resource/aws_dx_connection: Add skip_destroy argument (#26274)
resource/aws_eks_node_group: Add support for WINDOWS_CORE_2019_x86_64, WINDOWS_FULL_2019_x86_64, WINDOWS_CORE_2022_x86_64, and WINDOWS_FULL_2022_x86_64 ami_type values (#28445)
resource/aws_networkfirewall_rule_group: Add reference_sets configuration block (#28335)
resource/aws_networkmanager_vpc_attachment: Add options.appliance_mode_support argument (#28450)

BUG FIXES:

resource/aws_networkfirewall_rule_group: Change rule_group.rules_source.stateful_rule from TypeSet to TypeList to preserve rule order (#27102)

v4.47.0
Compare Source
FEATURES:

New Data Source: aws_cloudwatch_log_data_protection_policy_document (#28272)
New Data Source: aws_db_instances (#28303)
New Resource: aws_auditmanager_account_registration (#28314)
New Resource: aws_auditmanager_framework (#28257)
New Resource: aws_lambda_functions (#28254)
New Resource: aws_sagemaker_space (#28154)
New Resource: aws_ssoadmin_permissions_boundary_attachment (#28241)

ENHANCEMENTS:

data-source/aws_cloudwatch_log_group: Use resource tagging APIs that are not on a path to deprecation (#28359)
data-source/aws_eks_addon: Add configuration_values attribute (#28295)
resource/aws_appsync_function: Add runtime and code arguments (#28057)
resource/aws_appsync_function: Make request_mapping_template and response_mapping_template Optional (#28057)
resource/aws_cloudwatch_log_destination: Add tags argument and tags_all attribute to support resource tagging (#28359)
resource/aws_cloudwatch_log_group: Use resource tagging APIs that are not on a path to deprecation (#28359)
resource/aws_eks_addon: Add configuration_values argument (#28295)
resource/aws_grafana_workspace: Add vpc_configuration argument. (#28308)
resource/aws_networkmanager_core_network: Increase Create, Update, and Delete timeouts to 30 minutes (#28363)
resource/aws_sagemaker_app: Add space_name argument (#28154)
resource/aws_sagemaker_app: Make user_profile_name optional (#28154)
resource/aws_sagemaker_domain: Add default_space_settings and default_user_settings.jupyter_server_app_settings.code_repository arguments (#28154)
resource/aws_sagemaker_endpoint_configuration: Add shadow_production_variants, production_variants.container_startup_health_check_timeout_in_seconds, production_variants.core_dump_config, production_variants.model_data_download_timeout_in_seconds, and production_variants.volume_size_in_gb arguments (#28159)
resource/aws_sagemaker_user_profile: Add user_settings.jupyter_server_app_settings.code_repository argument (#28154)

BUG FIXES:

resource/aws_cloudwatch_metric_stream: Correctly update tags (#28310)
resource/aws_db_instance: Ensure that apply_immediately default value is applied (#25768)
resource/aws_ecs_service: Fix missing required field, UpdateServiceInput.ServiceConnectConfiguration.Enabled error when removing service_connect_configuration configuration block (#28338)
resource/aws_ecs_service: Fix service_connect_configuration.service.ingress_port_override being set to 0 (InvalidParameterException: IngressPortOverride cannot use ports <= 1024 error) when not configured (#28338)

v4.46.0
Compare Source
FEATURES:

New Data Source: aws_glue_catalog_table (#23256)
New Resource: aws_auditmanager_control (#27857)
New Resource: aws_networkmanager_core_network (#28155)
New Resource: aws_resourceexplorer2_index (#28144)
New Resource: aws_rum_metrics_destination (#28143)
New Resource: aws_vpc_network_performance_metric_subscription (#28150)

ENHANCEMENTS:

resource/aws_glue_crawler: Add catalog_target.dlq_event_queue_arn, catalog_target.event_queue_arn, catalog_target.connection_name, lake_formation_configuration, and jdbc_target.enable_additional_metadata arguments (#28156)
resource/aws_glue_crawler: Make delta_target.connection_name optional (#28156)
resource/aws_networkfirewall_firewall: Add encryption_configuration attribute (#28242)
resource/aws_networkfirewall_firewall_policy: Add encryption_configuration attribute (#28242)
resource/aws_networkfirewall_rule_group: Add encryption_configuration attribute (#28242)

BUG FIXES:

resource/aws_db_instance: Fix error modifying allocated_storage when storage_type is "gp3" (#28243)
resource/aws_dms_s3_endpoint: Fix disparate handling of endpoint attributes in different regions (#28220)
resource/aws_evidently_feature: Fix  description attribute to accept strings between 0 and 160 in length (#27948)
resource/aws_lb_target_group: Allow healthy_threshold and unhealthy_threshold to be set to different values for TCP health checks. (#28018)
resource/aws_lb_target_group: Allow interval to be updated for TCP health checks (#28018)
resource/aws_lb_target_group: Allow timeout to be set for TCP health checks (#28018)
resource/aws_lb_target_group: Don't force recreation on health_check attribute changes (#28018)
resource/aws_sns_topic_subscription: Fix unsupported FilterPolicyScope attribute error in the aws-cn partition (#28253)

v4.45.0
Compare Source
NOTES:

provider: With AWS's retirement of EC2-Classic the skip_get_ec2_platforms attribute has been deprecated and will be removed in a future version (#28084)
resource/aws_fsx_ontap_storage_virtual_machine: The subtype attribute has been deprecated and will be removed in a future version (#28127)

FEATURES:

New Resource: aws_dms_s3_endpoint (#28130)

ENHANCEMENTS:

data-source/aws_db_instance: Add storage_throughput attribute (#27670)
data-source/aws_eks_cluster: Add cluster_id attribute (#28112)
resource/aws_db_instance: Add storage_throughput argument (#27670)
resource/aws_db_instance: Add support for gp3 storage_type value (#27670)
resource/aws_db_instance: Change iops to Computed (#27670)
resource/aws_eks_cluster: Add cluster_id attribute and outpost_config.control_plane_placement argument (#28112)
resource/aws_redshiftserverless_workgroup: Wait on MODIFYING status on resource Delete (#28114)

BUG FIXES:

resource/aws_redshiftserverless_namespace: Fix updating admin_username and admin_user_password (#28125)

v4.44.0
Compare Source
NOTES:

resource/aws_fsx_ontap_storage_virtual_machine: The subtype attribute will always have the value "DEFAULT" (#28085)
resource/aws_wafv2_web_acl: excluded_rule on managed_rule_group_statement has been deprecated. All configurations using excluded_rule should be updated to use the new rule_action_override attribute instead (#27954)

ENHANCEMENTS:

resource/aws_api_gateway_deployment: Add import support (#28030)
resource/aws_kinesisanalyticsv2_application: Add support for FLINK-1_15 runtime_environment value (#28099)
resource/aws_lambda_function: Add snap_start attribute (#28097)
resource/aws_wafv2_web_acl: Support rule_action_override on managed_rule_group_statement (#27954)

BUG FIXES:

resource/aws_instance: Change iam_instance_profile to Computed as the value may be configured via a launch template (#27972)

v4.43.0
Compare Source
FEATURES:

New Resource: aws_neptune_global_cluster (#26133)

ENHANCEMENTS:

data-source/aws_ecs_cluster: Add service_connect_defaults attribute (#28052)
resource/aws_ce_cost_category: Allow configuration of effective_start value (#28055)
resource/aws_ecs_cluster: Add service_connect_defaults argument (#28052)
resource/aws_ecs_service: Add service_connect_configuration argument in support of ECS Service Connect (#28052)
resource/aws_glue_classifier: Add custom_datatypes and custom_datatype_configured arguments (#28048)
resource/aws_neptune_cluster: Add global_cluster_identifier argument (#26133)

v4.42.0
Compare Source
FEATURES:

New Data Source: aws_redshiftserverless_credentials (#28026)
New Resource: aws_cloudwatch_log_data_protection_policy (#28049)

ENHANCEMENTS:

data-source/aws_memorydb_cluster: Add data_tiering attribute (#28022)
resource/aws_db_instance: Add blue_green_update argument in support of RDS Blue/Green Deployments (#28046)
resource/aws_efs_file_system: Add support for AFTER_1_DAY lifecycle_policy.transition_to_ia argument (#28054)
resource/aws_efs_file_system: Add support for elastic throughput_mode argument (#28054)
resource/aws_emrserverless_application: Add architecture argument (#28027)
resource/aws_emrserverless_application: Mark maximum_capacity and maximum_capacity.disk as Computed, preventing spurious resource diffs (#28027)
resource/aws_memorydb_cluster: Add data_tiering attribute (#28022)
resource/aws_sns_topic_subscription: Add filter_policy_scope argument in support of SNS message filtering (#28004)

BUG FIXES:

resource/aws_lambda_function: Don't fail resource Create if AWS Signer service is not available in the configured Region (#28008)
resource/aws_memorydb_cluster: Allow more than one element in snapshot_arns (#28022)
resource/aws_sagemaker_user_profile: user_settings.jupyter_server_app_settings, user_settings.kernel_gateway_app_settings, and user_settings.tensor_board_app_settings are updateable (#28025)

v4.41.0
Compare Source
FEATURES:

New Data Source: aws_sqs_queues (#27890)
New Resource: aws_ivschat_logging_configuration (#27924)
New Resource: aws_ivschat_room (#27974)
New Resource: aws_rds_clusters (#27891)
New Resource: aws_redshiftserverless_resource_policy (#27920)
New Resource: aws_scheduler_schedule (#27975)

ENHANCEMENTS:

data-source/aws_cloudtrail_service_account: Add service account ID for ap-south-2 AWS Region (#27983)
data-source/aws_elasticache_cluster: Add cache_nodes.outpost_arn and preferred_outpost_arn attributes (#27934)
data-source/aws_elasticache_cluster: Add ip_discovery and network_type attributes (#27856)
data-source/aws_elb_hosted_zone_id: Add hosted zone ID for ap-south-2 AWS Region (#27983)
data-source/aws_lb_hosted_zone_id: Add hosted zone IDs for ap-south-2 AWS Region (#27983)
data-source/aws_rds_cluster: Add engine_mode attribute (#27892)
provider: Support ap-south-2 as a valid AWS Region (#27950)
resource/aws_amplify_app: Add support for WEB_COMPUTE platform value in support of Next.js web apps (#27925)
resource/aws_elasticache_cluster: Add ip_discovery and network_type arguments in support of IPv6 clusters (#27856)
resource/aws_elasticache_cluster: Add outpost_mode and preferred_outpost_arn arguments and cache_nodes.outpost_arn attribute. NOTE: Because we cannot easily test this functionality, it is best effort and we ask for community help in testing (#27934)
resource/aws_lambda_function: Add support for nodejs18.x runtime value (#27923)
resource/aws_lambda_layer_version: Add support for nodejs18.x compatible_runtimes value (#27923)
resource/aws_medialive_channel: Add start_channel attribute (#27882)
resource/aws_nat_gateway: Update private_ip attribute to be configurable (#27953)

BUG FIXES:

resource/aws_cloudcontrolapi_resource: Remove invalid regular expressions from CloudFormation resource schema (#27935)
resource/aws_dms_endpoint: Add ability to use AWS Secrets Manager with the sybase engine (#27949)
resource/aws_resourcegroups_group: Properly set configuration.parameters as optional (#27985)

v4.40.0
Compare Source
NOTES:

data-source/aws_identitystore_group: The filter argument has been deprecated. Use the alternate_identifier argumen

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


Add AssignCulture task back to CoreCLR build

CultureInfo.GetCultures isn't supported, so I just hard coded a small list. There are like 800 more, so this isn't great but it got it up and building quickly.

FYI the aspnet team ran into this as well (see https://github.com/dotnet/corefx/issues/1669) and ended up with CultureInfoList.cs.

Thanks! I'll use that instead.

@dsplaisted @ValMenn @rainersigwald Can one of you take a look at this please? Most of it is just copied from aspnet and replaced the old array + binary search method. I did modify it to use CultureInfo.GetCultures if it was available though.

LGTM

Based on the discussion in dotnet/corefx#1669, I'm not sure hard-coding the list of supported cultures is appropriate here.  It seems like perhaps what we should be doing instead to check if a culture string is valid is either to try creating a CultureInfo and seeing if that throws, or to check if it matches the language tag syntax defined in BCP 47 Section 2.1.

Ok. For non CoreCLR it stays a similar implementation (calls GetCultures to populate that cache). For CoreCLR it will new up the CultureInfo when asked to check if it's valid.

:shipit:


Update Learning Path “github-actions”

Automatically generated by Netlify CMS

Fixed author github id

Created a new issue add category based links to the categories in the home page #108 in GitHub


feat: update detail.js

update detail.js

This is very good! I think you can do more specifically in the last code; for example,
const result = results.find((item) => item.type === type) || { work: "Unknown", description: "No description available" };
This can ensure that if no matching result is found, a default object is returned to prevent errors. :)


Fail to indent with error "AttributeError: 'module' object has no attribute 'messages'"

Hi,
when i try run via command pallete, the following code is in the log and the code doesn't format.
Traceback (most recent call last):
File ".\sublime_plugin.py", line 362, in run_
File ".\indentxml.py", line 52, in run
File ".\indentxml.py", line 106, in indent
AttributeError: 'module' object has no attribute 'messages'
Seems like i'm encountering an error. Could you assist??

Please check the new version.


How to remove tiny author logo on every post thumbnail ?

You have two options:
You can find and remove the element m-article-card__author from the file /partials/loop.hbs: https://github.com/eddiesigner/liebling/blob/master/partials/loop.hbs#L15
Also find and remove the element m-featured-article__author from the file /index.hbs: https://github.com/eddiesigner/liebling/blob/master/index.hbs#L47
The other thing you can do is simply adding this css rule into the "Site Header Code Injection" section of your Ghost instance:
<style>
.m-article-card__author,
.m-featured-article__author {
  display: none !important;
}
</style>

Thank you !


Stuttering Audio iOS

Issue description
We are experiencing stuttering audio only on iOS devices
Environment
whatsmybrowser.org/b/NR8USVM
Steps to reproduce the issue

open https://stonegatefellowship.com/moretocome on iOS device
Play track and skip to another app
return to the screen
You should hear skipping, stuttering and sometimes pausing

What is expected?
It should play smoothly
Link to where issue can be reproduced
https://stonegatefellowship.com/moretocome
Additional details / screenshots

Hi @joeaylor I finally got a chance to check out the issue. Do you have good service on your iOS device when you are streaming? iOS doesn't allow preload so it could be due to bad service.
I've also seen a couple people have audio problems on newer versions of iOS but it's in every app. Do you know if the people streaming the audio have the issues isolated to the Amplitude JS web page?

I've seen this issue as well, connection is fine but audio stuttering in iOS is bad. I haven't tried reverting to pre-4.0 to see if it fixes it, but I may try it.

I've seen this issue as well, connection is fine but audio stuttering in iOS is bad. I haven't tried reverting to pre-4.0 to see if it fixes it, but I may try it.

I'm using pre-4.0 release and haven't heard any stuttering on iOS.

I switched to pre-4.0 and the stuttering is gone for me as well.

@dujoducom Since it works with v3 I think the issue has to do with some of the processing of the Web Audio API. If you wouldn't mind testing the dev branch: https://github.com/521dimensions/amplitudejs/tree/dev, I removed all Web Audio API processing unless it's explicitly implemented in the DOM. So if you don't have any waveforms or visualizers then it won't do any extra processing. Could you let me know how that works? I'll be doing a release of 4.2 after finalizing the docs. The dev branch is stable for code right now.

@danpastori That fixed it for us.
This resource is really amazing. Can't tell you guys how much we appreciate your work!

@joeaylor Thanks so much! I'm glad to hear it works well let me know if anything else comes up!

@danpastori Dev branch is working great for me too, thanks!

had the same issue, dev branch is working amazing! thank you :)

Similar issue, just downloaded dev branch and it appears to work for me.


feat: add CLI support

This patch allows FrankenPHP to execute CLI scripts. This is especially useful when using the static binary to run Composer, Symfony or Laravel commands.
Continuation of #4.

This command is now good enough to run Composer and scripts built with Symfony Console!


[FEATURE][BUG] Harvester CPI Error: failed to get node modifiers from cloud provider: failed to find kubelet node IP from cloud provider, requeuing

Describe the bug
Removed a node object from a downstream RKE2 cluster and re-joined the node with restarting rke2-agent.
Now we see this in the cloud provider logs:
I1128 15:16:08.586900       1 node_controller.go:390] Initializing node node17 with cloud provider
E1128 15:16:08.598477       1 node_controller.go:212] error syncing 'node17': failed to get node modifiers from cloud provider: failed to find kubelet node IP from cloud provider, requeuing
To Reproduce
Have a downstream RKE2 cluster on top of Harvester with 3 server and several agents and having harvester CPI/CSI deployed using Rancher
.
On one agent do a
rke2-killall.sh
On a master do a
kubectl delete node node17
And then on the agent do a
systemctl start rke2-agent
Now check the logs of the harvester cloud controler and see the above errors.
Expected behavior
Harvester CPI should not have these errors and remove the taint "node.cloudprovider.kubernetes.io/uninitialized=true:NoSchedule" from the node.
Environment

Harvester ISO version: 1.1.0
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): Baremetal

Some more information - our nodes have two IP addresses - one on eth0 and one on eth1 and we have specified node-ip: to the one that should be used a  "internal ip" for the node.
How can we see what exactly is going wrong when we get the above error?

One more thing - the default gateway is on eth1 where the node-ip is on eth0 - is this a potential problem with the harvester CPI?

The error message comes from https://github.com/kubernetes/cloud-provider/blob/f443498b5ec49e0c9e52935e0ff9fbbd37862340/controllers/node/node_controller.go#L492
@Martin-Weiss Could you provide the yaml of nodes?

Some more information - our nodes have two IP addresses - one on eth0 and one on eth1 and we have specified node-ip: to the one that should be used a "internal ip" for the node.

@Martin-Weiss  Are you assigning multiple ip networks here through network data ?
Currently, node driver cannot add multiple NIC to a guest cluster node.
Only network data is not enough, need node driver support first.
https://github.com/harvester/harvester/issues/2426
https://github.com/harvester/harvester/issues/2733

Our current way is to add the second NIC (eth1) manually via Harvester UI after the VM has been created. In this case the network_data will be taken also for eth1 as configured.

We should add a new feature to support multiple IPs in the Harvester cloud provider.

The whole multiple NICs solution is at https://github.com/harvester/harvester/issues/2426

Hi @Martin-Weiss, I would like to double confirm some details of the environment (to reproduce the bug):

Harvester cluster with 3+ nodes
RKE2 cluster (4 nodes+) with 2 NIC and both able to access harvester
Rejoin RKE2 agent node

Thanks.

Hi @Martin-Weiss, I would like to double confirm some details of the environment (to reproduce the bug):
1. Harvester cluster with 3+ nodes

2. RKE2 cluster (4 nodes+) with 2 NIC and both able to access harvester

3. Rejoin RKE2 agent node

Thanks.

@lanfon72 yes - this is more or less what we have done. Not sure what else you want to know?

thank you @Martin-Weiss.
Hi @yaocw2020, we don't have any environment to create 2 VLANs and both ports able to interact with RKE2 cluster, does the CPI Error (root cause) is not related to multi NICs? If so, I think we could verify this bug on 1 VLAN environment.
cc @guangbochen, @bk201

This issue is part of the multiple NICs solution https://github.com/harvester/harvester/issues/2426. Multiple VLAN environment is not required.

I think you need a router outside of the environment to route betweent the VLANs - but the root cause might be the difference of node-ip vs. ip for default gateway...

Move back to implement because the latest rancher v2.7-head still unable to create rke2 with 2 NICs.

remove dependency as we could still use another network data format to spawn RKE2.

Verified this bug has been fixed.
Test Information

Environment: baremetals DL360G9 3 nodes
Harvester Version: v1.1.2-rc1
ui-source Option: Auto
Rancher Version: v2.6-5d91d1afdd7d88da6c0530080b16a5ad6dae8d17-head (Docker Image ID: d645e74d343f)

Verify Steps:

Install Harvester with any nodes
Login to Dashboard
Create Image for VM creation
Create 2 VLANs, at least 1 is able to access Rancher
Import Harvester into Rancher
Create RKE2 cluster with 2 pools

first pool (servers) configured with 3 machines, 2 NICs and etcd/ControlPlane/Worker
second pool (agents) configured with 3 machines, 2 NICs and Worker
Network Data need to be configured in both pools[^1]

Login to one of VMs in second pool, execute sudo rke2-killall.sh
Login to one of VMs in first pool, execute commands as below:

sudo -s
export KUBECONFIG=/etc/rancher/rke2/rke2.yaml
/var/lib/rancher/rke2/bin/kubectl get nodes
/var/lib/rancher/rke2/bin/kubectl delete node "THE_AGENT_NODE_NAME_IN_STEP_7"

Login to the VM in step 7, execute sudo systemctl start rke2-agent
The agent node should join back successfully
No Error message displayed in harvester-cloud-provider (browsing from cluster -> explore -> Workload -> Deployments)

[^1]: https://docs.harvesterhci.io/v1.1/vm/create-vm#cloud-init , name in the configuration would be variety in different cloud image.


Investigate and finalize the architecture design

See the wiki page(access required): https://confluence.eng.vmware.com/display/HARBOR/Technical+Details

The investigation has been done, close this issue.


Update Autosuggest to remove lang code

What is the context of this PR?
This PR updates Mocha to v8.1.3 and Fuse to v6.4.1 and refactors the Autosuggest component to no longer use the language code. It will now accept data in an array format rather than a JSON object format.
How to review
Test that Autosuggest works as expected with new data format

Due to a bug in any version of fuse above 3.6.1 this is no longer possible


Update dependencies

There are few outdated dependencies

For example:
composer why-not monolog/monolog 3
spiral/framework 3.10.0 requires monolog/monolog (^2.2)


Metallurgic infuser automation

whoops, didn't mean to post it already, but I have a problem with metallurgic infusers. I have 10 metallurgic infusers in a row behind eachother and have input on the left of the row infusing material on the top and output on the right side. The input and output and infusing material are all connected to chests using Ultimate logistical transporters. The problem is when I input items it only gets to the first 2 metallurgic infusers, not the rest. I think it's weird because the infusing material is being put in the infusers and the products are being output to the chest. Is it a problem with the logistical transporters?

Yo. Last I remember, the pipes from a lot of mods use the shortest-path method including Nelson. This means that until the first one fills, none of the others will get anything.

Nelson=Mekanism* didn't notice it til post

there needs to be a metallurgic infusing factory

I agree.

Hey bulkje:  does your pack have project red in it? If so, you might be able to utilize that to accomplish this task. There is a downside to project red's automation however: each crafting pipe you use can only accommodate one crafting recipe per crafting card inserted into it. You can only use 4 cards Max per pipe.

Last I remember anyways. I'll login to my friend's server shortly and check.

And of course I forgot about the infusing material. That will still need logistical transports

the infusing material was never the problem, thanks for the suggestion!

I ended up using a logistical sorter and putting red robin on


Update broken keychain provider test

What does this PR do (include background context, if relevant)?
Fixes the broken keychain provider test, and hopefully makes it easier to manually run going forward
Changes made include:

Update Keychain test to be consistent with other test suites
Add convenience start / stop / test scripts to Keychain test
Move Keychain and K8s CRD tests to test/manual folder, since these tests are still manual
Update README / PR template instructions on running manual tests

What ticket does this PR close?
Connected to #527
Where should the reviewer start?
What is the status of the manual tests?
Have you run the following manual tests to verify existing functionality continues to function as expected?

[x] Manually tested K8s CRDs
[x] Manually tested Keychain provider
[x] Manually run the K8s demo
[ ] Manually run Kubernetes-Conjur demo with a local Secretless Broker image build of your branch
[ ] Manually run the full demo (optional)

If this feature does not have any/sufficent automated tests, have you created/updated a folder in test/manual that includes:

[x] An updated README with instructions on how to manually test this feature
[x] Utility start and stop scripts to spin up and tear down the test environments
[x] A test script to run some basic manual tests (optional; if does not exist, the README should have detailed instructions)

Links to open issues for related automated integration and unit tests
n/a
Links to open issues for related documentation (in READMEs, docs, etc)
n/a
Screenshots (if appropriate)
n/a

@jonahx responded to your comments; the keychain test is still passing.


feat: library_search using

Implement the library_search using X clause, which only returns results for which X appears as a subexpression.
The mathlib3 implementation is still cleverer, but would require full implementation of solveByElim with backtracking across multiple goals. I'll get there later.

bors merge


Ability to pass dependency when styles are being processed

Proposal
Allow dependencies to be set, so the styles being processed have access to things like global variables, class names, mixins etc.
Use Case
I’m using VuePress with PostCSS which uses postcss-loader. I want to avoid having to @import the same file in each of my components when using libraries like TailwindCSS. I've had the same use case with other frameworks. I can't find the documentation but I've heard this being known as a dependency inside a webpack loader.
Implementation

[ ] I'm open to work on this
[ ] I need help/mentorship
[x] I'm unable to work on this

@limitlessloop can you provide minimum reproducible test repo to ensure all logic will implement?

Yeah I'll try my best. I'll put one together now.

@evilebottnawi I've uploaded an example the best I can at https://github.com/limitlessloop/vuepress-postcss-example
VuePress has a config file /site/.vuepress/config.js where you can specify information for different loaders. I believe there are two ways to specify preprocessors, I've tried to show any documentation I know of that describes this in the readme of the repo. I'm using just the simpler method currently.
// config.js
module.exports = {
	postcss: {
		plugins: [
			require('postcss-import'),
			require('postcss-extend-rule')
		]
	}
}

There are two way to add dependencies:

postcss plugin should emit message https://github.com/webpack-contrib/postcss-loader/blob/master/src/index.js#L193:

result.messages.push({ type: 'dependency', file: '/path/to/file.ext' })

use this.webpack inside config (it is loader context) and pass this.webpack.addDependency as function to plugin

require('postcss-plugin')({ addDependecy: this.webpack.addDependency });

In both cases you need to do some work on plugin side
In both cases you need do some work on a plugin side.

We should document it


feat: space members add with lowercase

Issues
Lowercase addresses to check duplicates in space members.
Fixes https://github.com/snapshot-labs/snapshot/issues/3809
Changes

Added .toLowerCase() to address addressesArray/membersArray mapping.

How to test

Go to your space and try to add members with mixed case and the the same with lowercase.

Self-review checklist

[x] I have performed a full self-review of my changes
[x] I have tested my changes on a preview deployment
[ ] I have tested my changes on a custom domain
[ ] I have run end-to-end tests yarn cypress:test:e2e, and they have passed

I think what @ChaituVR meant was to use import { getAddress } from '@ethersproject/address'; to checksum the address

yeah i've seen it, but we can take a cheaper way just lowerCase them all. It will work for duplicates until we can add members with .eth ens.


[MB-13572] Evaluation report PDF generation spike

Jira ticket for this change
Now when you click download report, you get a PDF.
It's been a while since anybody touched PDF generation, so the goal of this spike was to figure out how it works.
specific things I was testing here:

we can generate a PDF using a template image
we can put text into the PDF wherever we want
we can ship send the generated PDF to the user's browser

I basically copied the code from ShipmentSummaryWorksheet with a few tweaks, and everything was fairly straightforward. No big surprises.
https://user-images.githubusercontent.com/2627844/188027283-ddd396b9-4bca-4ae9-baea-04f5f2f4a0d2.mov
Setup to Run Your Code

💻 You will need to use three separate terminals to test this locally.
Terminal 2
Start the UI locally.
make client_run

Terminal 3
Start the Go server locally.
make server_run

Additional steps
Verification Steps for Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.

Frontend

[ ] User facing changes have been reviewed by design.
[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] There are no new console errors in the browser devtools
[ ] There are no new console errors in the test output
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.

Backend

[ ] Code follows the guidelines for Logging
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys
[ ] Have been communicated to #g-database
[ ] Secure migrations have been tested following the instructions in our docs

Screenshots

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

Messages

:book:
:link: MB-13572

  Generated by :no_entry_sign: dangerJS against 9c541899e3444ff60ad723ad5d113cca3cc0125b

✅ Works as expected, PDF is generated with content related to the eval report.  Very helpful comments in this PR highlighting key aspects of PDF generation. Seems reasonable to me this could be extended to create a PDF containing all eval report info.
One thought comes to mind: The generated PDF will look quite a bit different than what is shown in the browser when viewing a report (layout/styles/fonts/etc). I don't necessarily think this is an issue (I am not familiar with the PDF designs). However, if styling and/or matching what is shown in browser is important, it may be worth revisiting this and trying out some front-end PDF generation packages in hopes of re-using existing frontend work for PDF generation.


Added error messages for scatterplot facet

Fixes #4890
Changes proposed in this pull request:

Added error messages to prevent users from attempting to do a scatter plot facet without the requisite columns.

Let me know if the wording of the error message is alright:
When column is not numeric:
"Scatterplot requires a numeric column (green values). The column $1 has less than 50% numeric data. If a column has numerical data but is stored as text (black color), then use Column->Edit Cells->Common Transforms->to Number to convert."

When column is numeric, but there are no other numeric columns to compare against:
"No other numeric columns, (columns with more than 50% numeric data (green values)), to compare with Column $1."

Looking at the code the test of whether a column is Numeric or not seems to be that more than half the values in the column are numeric. So two questions

Are we happy with this as our threshold for allowing scatterplots? (I don't have any strong feelings as I never use this functionality!)
And perhaps more importantly - should we be more explicit in the user feedback to state that this is the definition?

It is definitely not ideal to rely on such a threshold… I guess it would make sense to mention it in this error message indeed!

I updated the error messages to mention the threshold, and I noticed the scatterplot documentation doesn't mention what a numeric column is: (Ref: https://docs.openrefine.org/manual/facets#scatterplot-facet). Scatterplot seems to be the only feature which uses the concept of a numeric column.  Other features work on individual cells, like numeric facet.


feat(cli): add eslint-disable to generated output

Description
Really quick fix to save a few seconds typing an ignore entry
Additional Information

[x] I read the contributing docs (if this is your first contribution)

Your ENS/address:

It's probably best to add this file to your eslintignore rather than add this here since this isn't as explicit/clear.


[balsa] Ignore long trailers.

Ignore trailers with long key or value if
codec_settings_.enable_trailers_ is false.
This also causes trailers not to be validated if
codec_settings_.enable_trailers_ is false, which is different from http-parser behavior.
Tracking issue: #21245
Signed-off-by: Bence Béky<EMAIL_ADDRESS>Commit Message: [balsa] Ignore long trailers.
Additional Description: Ignore trailers with long key or value if codec_settings_.enable_trailers_ is false.
Risk Level: low
Testing: //test/common/http/http1:codec_impl_test
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

/assign @diannahu @birenroy

Dianna: Thank you for the review.
Kevin: PTAL
/assign @KBaichoo

Seems reasonable that we'd not validate trailers if they're not enabled. How does balsa end up cleaning up the buffer with invalid trailers?

BalsaFrame does not buffer the raw input, instead it copies headers (and trailers, if trailer_ is set) into BalsaHeaders objects, and calls BalsaVisitorInterface methods with absl::string_view arguments that point into the raw input.

Adding wait as discussed out of band for a test that has balsa trailers disabled but invalid trailers, we can recover and process a subsequent well formed request

Thank you.


Heap base shall be configurable.

On STM32, heap base is defined as:
#define HEAP_BASE      ((uintptr_t)&_ebss + IDLE_STACKSIZE)
This makes the assumption that the heap will always be after BSS & Idle Stack, which is not always possible.
On systems with multiple RAM regions, that are not contiguous, this is not going to work.
For example, I am using an STM32F427, that has:

64k @ 0x10000000
192k @ 0x20000000

This forces me to place everything in the 192k SRAM region (and thus lose the CCM), or place everything in CCM (64k), and not be able to take advantage of the full 192k RAM of the system.
Even worse, if I place BSS in 64k and select CONFIG_STM32_CCMEXCLUDE, the heap will still be located within CCM, and will extend till the end of the 192k RAM (of course with a "hole" in between).
I believe that we need a different way of defining the Heap.
Examples/ideas:

FreeRTOS heap_5 uses a table.
Linker script regions or symbols may be defined for the heap.
We may set HEAP_BASE (and size) in Kconfig.

@fjpanag has you tried CONFIG_MM_REGIONS? this option let you specify multiple discontinuous heap regions as needed.

Hi @xiaoxiang781216,
CONFIG_MM_REGIONS, allows you to configure multiple heaps, but this is not what I need. I only need one heap. The problem is that NuttX does not allow me to place the heap wherever I need. It just makes the assumption that it is just after BSS.
If I recall correctly the same goes for defining multiple heaps, with CONFIG_MM_REGIONS. It just places the two heaps at predetermined positions. If someone needs to modify this, they must make changes to the low-level drivers.
I believe that the memory map of the whole system shall be configurable, or at least governed by the board. The OS must not have hard-coded addresses, or make any assumptions about the end application.

No, you have choice in arm_addregion:

Call ?mm_initialize to create the multiple heaps
Call ?mm_addregion to add the multiple regions into one heap
Combine item 1 and 2 to get the multiple heaps with multiple regions
BTW, how to find the heap location is controlled by chip specific code, so you are free to change the implementation to take the different approach without breaking the code in sched.

Your proposition suggests modification to the arch files of (in my case) STM32.
I don't want to have per-project forks of NuttX just for defining the memory map. That is why I am looking for a proper solution, allowing project-level configuration of the memory map.
Checking in stm32_allocateheap.c:
/******************************************************************************
 * Name: up_allocate_heap
  ...
 *
 *   The following memory map is assumed for the flat build:
 *
 *     .data region.  Size determined at link time.
 *     .bss  region  Size determined at link time.
 *     IDLE thread stack.  Size determined by CONFIG_IDLETHREAD_STACKSIZE.
 *     Heap.  Extends to the end of SRAM.
 *
  ...
 *
 ******************************************************************************/

It assumes that the heap will always follow DATA -> BSS -> IDLE stack -> Heap.
In this function the heap definition is explicitly coupled to the IDLE stack:
  /* Return the heap settings */

  board_autoled_on(LED_HEAPALLOCATE);
  *heap_start = (FAR void *)g_idle_topstack;
  *heap_size  = SRAM1_END - g_idle_topstack;

Furthermore, in the same file, the function void arm_addregion(void), clearly uses a bunch of hard-coded values.
Also note that arm_addregion is only compiled for CONFIG_MM_REGIONS > 1. In my case there is only one heap.

mm_addregion is same as FreeRTOS heap_5 [uses a table] (https://www.freertos.org/FreeRTOS_Support_Forum_Archive/July_2017/freertos_Using_heap_5.c_d1dfe891j.html).
What's the final layout do you want for STM32F427? one heap two regions, or two heaps?

Hi @xiaoxiang781216,
I am not sure if I understand you correctly. Can you provide me with some details on how the heap is defined as a table?
BTW I am using NuttX 9.1.
I want to have one heap, in a single continuous section. I just don't want to have this heap adjacent to the BSS/IDLE stack. This heap needs to be located to a different memory bank, completely unrelated to any other memory regions.

Hi @xiaoxiang781216,
I am not sure if I understand you correctly. Can you provide me with some details on how the heap is defined as a table?
BTW I am using NuttX 9.1.
I want to have one heap, in a single continuous section. I just don't want to have this heap adjacent to the BSS/IDLE stack. This heap needs to be located to a different memory bank, completely unrelated to any other memory regions.

so you want the global data in one memory region and the malloc from another memory region? But how do you utilize the remain memory in the first region?

Yes, this is correct.
CCM is rather small (64kb) comparing to the second RAM region (192kb). Since this is a port of an already working firmware, I know that DATA + BSS will completely fill the CCM, and I want the heap to take advantage of the whole 192kb.
Regardless of my specific application:
CCM does not support DMA transfers. So one may want to exclude it from the heap, if they want to use DMA. BUT! The heap must always follow DATA/BSS which cases two problems:

If I select CCM for DATA/BSS, the memory manager will fail. It will try to use an invalid memory region.
The only way to fix the above, is to use the second region also for DATA & BSS. In this case CCM will not be able to be used, it will remain empty. And thus I won't be able to use the whole available RAM on my system.

Since g_idle_topstack equals to ((uintptr_t)&_ebss + IDLE_STACKSIZE) and _ebss is controlled by the board link script, you can adjust _ebss to ensure the memory between _ebess and the end of CCM is little bigger than IDLE_STACKSIZE(to cover the idle stack and mm_heap_s structure. And enable CONFIG_MM_REGIONS to let arm_addregion add the second RAM.

Or you can skip DMA or use bounce buffer if the memory inside CCM.

Maybe I will manage to make it work with one of the above suggestions.
But it looks more than a work-around to me, that an proper solution, as it is usually needed in such systems.
This is why I am insisting that the heap boundaries shall be defined in a different way, that does not depend on other (unrelated) memories, and is easily configurable.
Personally, I believe that the best case would be to define the heap in the linker script.

I would like to contribute on this, but I am not very confident at the moment to introduce such changes on my own.
If however someone can take the lead, I can spend some time helping out.

Yes, you can add a new Kconfig option to adjust how stm32 find the heap memory.


:robot: Make spac on release workers

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1745

cancelling workers since this only runs on releases


Rough sdl2 backend and painter

I needed egui to render and take input from SDL2, I did a rough implementation and would like to share it and this was the best way I could do that.
It's rough but might be a good starting point if someone would like to take it all the way.
The important stuff is here
I made two versions of the example a basic one and one that fixes this sdl2 resize "issue", it's over here
Related to https://github.com/emilk/egui/issues/820

Sorry, that was a mis-click. Can't put it back to draft unfortunately..

@tedsteen, convert to draft link located in Reviewers section on the right side:

See also:

https://github.com/ArjunNair/egui_sdl2_gl
https://github.com/ComLarsic/egui_sdl2_platform

See also:

https://github.com/ArjunNair/egui_sdl2_gl

https://github.com/ComLarsic/egui_sdl2_platform

They where a great inspiration! But i wanted the glow + input through sdl2 and figured that a combo like that would be suitable for this repo, also considering the linked issue/discussion.


Don't silently swallow this MSAL MFA error

My auth-related functionality wasn't working well, and I opened the console to see this error:

We should handle that, maybe just throwing up an alert(), as otherwise various actions just silently fail.

Hi,
I have the same error AADSTS50076. I cant remove the CAP. What would be the solution?
Best

figured out. I was loging in with a risky user


Need to factor per-node-per-network allocations into task allocation

Swarm allocates per-node IP addresses for each network when the network is ingress, when the network is overlay and the node is Windows and, more recently, when the network is overlay and the node is Linux.  Unfortunately, allocation occurs before node assignment.  The assumption here is that the task assignment will not require allocating any further resources which.  Swarmkit currently supports this by pre-allocating a per-network IP address for each node in the cluster.  This means that each overlay network in the cluster starts with N less IP addresses where N is the number of nodes in the cluster.  The more correct behavior would be to only allocate a per-node IP address when a task that is attached to said network gets assigned to the node.
This has been discussed in in the past several times and was deemed to be something that should be pushed out until the new allocator was finished.  However, with that time approaching it is now time to write this up as an issue.
One proposed solution to this was to swap the state progression in swarmkit such that node assignment occurs before allocation.  My understanding is that the theory of performing allocation-then-assignment was so that swarm could factor allocation information into the assignment decision, but that in practice it does not do so.  Performing node assignment first provides information to the allocator (the destination node) that it can then factor into its allocation process.  However, I am not clear on whether swapping the order might hamper our ability to, say, allocate tasks to nodes with available GPUs in the future.  (or maybe the GPU support problem is just another form of the one I'm highlighting here...)
In principle, node assignment is really just another kind of resource allocation for a task (i.e. allocating space and CPU cycles somewhere in the swarm).  So, the notion that one phase must come must before the other seems a bit arbitrary and wrong.  However, this is probably a case where theory and practice to not align.  Any solution that addresses the misbehavior mentioned above would be suitable.

cc @dperny @mark-church

Duplicate of #1477, actually. We've seen the need for this sort of thing for many moons.
https://github.com/docker/swarmkit/issues/1477

Wow!  That goes a way back.  ok...  Should I just update 1477 then re: the new use case?

I think so, yeah, actually. Let's bump that issue and close this one. Thanks for the write-up.


Update configs/config.json to include new modes

Short Description:
Fixes:

Add new modes to configs/config.js.example
Remove old mode from configs/config.js.example

Remove "mode": all,
Add "catch_pokemon" & "spin_forts" keys to the configs/config.json.example object.

Thanks, there's two files to be changed as this one merged:
https://github.com/PokemonGoF/PokemonGo-Bot/pull/1344/files

@solderzzc Thank you for letting me know, I'll keep that in mind next time I PR configs/*.json.example


Clarity

Add French pls

@marqed2 now pls I don't understand english

Add French pls

What about adding different languages ?

@marqed2 now pls I don't understand english

me neither

Add French pls

What about adding different languages ?

deviamos adicionar português

Added portuguese

Wait till the last minute once we have the list of prompts and responses completed and then y'all can translate it? (even if you don't speak the language?)

Yo añadiría español también

Das auf Deutsch übersetzen


Add Horizon Bright and Horizon Dark themes

Add theme inspired by Horizon Theme for VS Code https://github.com/jolaleye/horizon-theme-vscode.
Signed-off-by: Przemysław Lal<EMAIL_ADDRESS>

Thank you

Thank you