Selecting of default audio track on loading for MPD manifests

Have you read the Tutorials?
Yes
Have you read the FAQ and checked for duplicate open issues?
Yes
If the question is related to FairPlay, have you read the tutorial?

What version of Shaka Player are you using?
~4.3.4
What browser and OS are you using?
Chrome, Ubuntu 20.04
Please ask your question
I have multiple audio tracks in my player already implemented, but i was faced the problem that i need to select a default audio  track from the mpd manifest. I used getVariantTracks method from Shaka-player, but after investigation of our codebase i found that method which used there does not return any data from asset file, which related to the default audio track. I did not find any way how to get this data from the variant using your lib.
Maybe you can give me some advice how to get this option or how can i manage audio tracks in order to select the default one on player initialization?

Are you looking for the default audio track from the MDP manifest or are you trying to select a specific audio track at startup?
If it's the latter, you can use preferredAudioLanguage when configuring the player:
shaka.configure({preferredAudioLanguage: 'en'});

Preferred language and role should be your first try.  If that isn't detailed enough, you can use the player's streaming event to make track selections between manifest parsing and ABR selections.


Should check for nil on http response discard util method

Saw this and thought it a good idea to check
@patrickxb @maxtaco

I'll let @patrickxb take this, he's more familiar with the http library semantics!

LGTM.
(I think the place where the response is initially received from net/http should check the response for nil, but it looks like we don't do that everywhere before calling Discard... so this is a good safeguard).


Add interactions to writer's room

new feature idea:
When the server is in the writer's room:

throw a paper ball
drop in a physics simulated paper sheet

onto the "stage" to simulate incoming skits.

I think this should also include a table flip :D (only unlocked to the last person to finish a prompt)


Moon does not light up on Billie Environment

Describe the bug
While Chroma is installed, the moon does appear. The lighting from the moon still illuminates the water however the actual moon does not appear. This affects maps that don't use Chroma.
To Reproduce
Steps to reproduce the behavior:

Install Chroma
Play a map that utilises Billie environment, boost events, and the sun/moon.

Expected behavior
The moon should appear when the respective events are used.
Additional Context
This map demonstrates this behaviour at beat 19.
A video of how lighting is affected with and without Chroma.
This is the log _latest.log generated from the above video though I'm not sure this helps.

Closing as Chroma v2.5.13 no longer has this issue.


A data race between TreeIndex::insert and TreeIndex::remove

TreeIndex::insert may try to split an obsolete node.

Two problems mixed.

Remove race: confirmed removed key not removed
Scanner race: scanner misses certain keys when keys are being removed

Two problems mixed.

Remove race: confirmed removed key not removed
Scanner race: scanner misses certain keys when keys are being removed


Updates

(Image of updates on this PR)

[x] https://github.com/hzoo/github-contributor-extension/issues/4 Use mutation observers (https://github.com/octo-linker/injection)
[x] Cleanup
[x] Show on issues page as well
[x] Change UI to fit github better?
[x] https://github.com/hzoo/github-contributor-extension/issues/5 Rename to Contributor Stats on Github
[x] https://github.com/hzoo/github-contributor-extension/issues/3 oauth (no need to pass in token directly)
[ ] Tooltip to show when PRs were last updated (when to click update)

I'm not sure what the Update PRs link is for...

@kentcdodds Right, it's because I'm saving the results (# of PRs) somewhere and I needed a simple way to update cache (yeah it's not intuitive)

Ok now it shows you when the PR # was last updated for that user in that repo (on hover)


Linux kernel updates 2022-12-23

Description of changes
Updates all kernels to the latest version available. Still a draft until the tests have finished.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Just a remind, there's a known BTRFS bug in 6.1.1 which forced switch to readonly after a lot of disk writes. Though it's a false alarm and should cause no corruption on disk. It's somewhat not rare and there are a few people (around me) have encountered it.
<EMAIL_ADDRESS>There is already a patch but it seems not being merged yet.

Huh. /me stares at btrfs root partition

Just a remind, there's a known BTRFS bug in 6.1.1 which forced switch to readonly after a lot of disk writes.

:thinking: Oops, NVM. It seems only exists in 6.2 but not 6.1.1.


Add topic tags to pubspec.yaml

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Sorry, not able to sign CLAs. But I'd encourage you to add some topic tags!


Support aliases in dot visualization

In [1]: def f(*args): pass

In [2]: from dask.dot import dot_graph

In [3]: dot_graph({'x': 1, 'y': (f, 'x'), 'z': 'y'})
Writing graph to mydask.pdf

I also reverse the order of the arrows

Merging soon if no comment

I'm optimistic this will fix my dot graphs for xray :).
I like the switched arrow direction -- they follow the data flow now, which seems more intuitive to me

Indeed, it works now! Here's a beautiful image of resampling monthly files with 6 hourly data to a 15 day moving mean:

Whoa, awesome

I <3 dot


Add system type to the asset detail for textual summary

We added the physical storage family (the storage model) to the correct place.

Looks good you just have to add the relation has_many :physical_storage_details, :through => :physical_storages, :source => :asset_detail to your StorageManager class

This line already exist, line 35 in storage manager.

Okay your specs are failing for a different reason then.

Okay your specs are failing for a different reason then.

I will try to check it out.
this is the correct way to add this asset detail ?
I don't need to call this 'add_physical_storage_details' function inside the 'parser/storage_manager.rb' ?

@agrare ok I fix it and now it work as you suggested.
I didn't make the spec to pass,
try to debug it :

but specific in the refresher spec line 68, the 'physical_storage_details' isn't recognize properly :

Just need to fix the rubocop warning then LGTM

Just need to fix the rubocop warning then LGTM

Thanks a lot !

Just need to fix the rubocop warning then LGTM

@agrare thank you for your help! I does pass the specs.


Encoding cidv1 CID fails with  multihash length inconsistent

Hey @pldespaigne,
Thanks for maintaining this! Am I correct to assume that your library doesn't support V1 ?
> contentH = contentHash.fromIpfs("bafkreifuddi6sxhn5i35ubm4haia4jzzdivrqppnndnuin3jsgyc2np7om")
Uncaught:
Error: multihash length inconsistent: 0x8ec2edf59a1e02765b50fd95f351d269c847f3be07db370b28b0bef12a7a29dd5271e360349fdff1f8

I'm having the same issue, works OK with CID v0


Initial implementation of multiboot

Hi.
This patch set addresses issue #38 and implements multiboot. It is based on work done by @joshado in https://github.com/joshado/xhyve/tree/multiboot
The first patch is an as-is copy of the code from @joshado's repo (I hope he doesn't mind that I've added his Signed-off-by). The next patches address some coding style and do some refactoring.
The last patch implements some minimal support for ELF images.
Currently, only kernel image itself is loaded. Modules are not yet loaded and command line is not yet passed to the kernel.
With these patches applied I am able to successfully boot @joshado's multiboot test (not yet included in the pull request, as some test framework refactoring is required for this) and binaries from kvm-unit-tests package (https://git.kernel.org/cgit/virt/kvm/kvm-unit-tests.git).
Supporting kvm-unit-tests package was the original intent of this patch set. As I am planning to do some work on the performance of hyperkit (x2APIC, maybe KVM paravirt interface), this test suite will be of great help.

This patch set addresses issue #38 and implements multiboot.

Thanks! (@mato will be pleased I'm sure!)

The first patch is an as-is copy of the code from @joshado's repo (I hope he doesn't mind that I've added his Signed-off-by).

Unfortunately I think this is a problem.
As indicated in CONTRIBUTING.md adding an S-o-b indicates that one has read the Developers Certificate of Origin and is certifying the contribution against the clauses listed there. One therefore cannot in add an S-o-b for someone else without their express permission, so please don't do that.
Depending on the license which @joshado has indicated for his work you might feel you are able to add your own S-o-b under clause (b), but before adding your own S-o-b of you really should understand what it means, I recommend reading the DCO before deciding whether that is something you feel you can do for this particular contribution.
Even better of course would be for @joshado to agree to the DCO (commenting here with the appropriate S-o-b line text would suffice IMO). Thomas, would you be willing to do so?

Sure, this was all a bit of a WIP hack that I've not had the time to finish off - I'm pleased @pborzenkov is picking it up :D (mainly as I want to be able to boot SmartOS). I'm also happy to try and share the work getting this running if that is of interest?
I'm happy with the DCO and with the sign-off as added to the commit in this pull, is there anything else I need to do?

@joshado that's sufficient, thanks!

@joshado, supporting modules is the next thing I'm planning to add here. This should be enough to boot SmartOS. I'll use it as a test.

Brilliant, thanks @pborzenkov - is there anything I can help out with to get it running?

@joshado I'd really appreciate you testing the patches once they're ready.

Thanks, this looks much simpler than I had anticipated such a feature would be! Overall looks good, I made a couple of nits inline.
This is implementing the original multiboot rather than multiboot2 I think? Perhaps a comment with a link to the appropriate spec would be useful.

Yes, it implements original multiboot. But the implementation is not complete yet, as I haven't yet implemented modules support (should be relatively easy). So the code will be a bit more complex, but not much.

@ijc25 No. I'd like to implement modules/command line first, do some cleanup. I'll squash some commits probably. So please don't merge it yet.

@pborzenkov Hi! what's the current status on this ? (curious)

@AntonioMeireles Unfortunately, I didn't have enough free time lately to complete this feature. And I'm not sure I will be able to find the time to complete it in the nearest future.

@pborzenkov Have you pushed all of your changes? I might be able to find some time over the next week to have a look at this :)

@joshado Yes. This pull request contains everything I have at the moment.

Any updates on this?

@ijc25 @joshado I've finally found some free time to complete the pull request. It now supports kernel, modules (each with its own command line) and kernel command line. I've tested it on SmartOS image. It boots far past bootloader and crashes later because there is no BIOS. But the part that deals with multiboot runs without problems.

Thanks @pborzenkov! This LGTM. I'll give some time for @joshado and @rneugeba to have a look before merging though.

@avsm Fixed!

Hey, just as an update - I've been testing out this pull with SmartOS this morning and, after a bit of faff hacking together a quick VGA emulator and extending the keyboard controller a little, I've got illumos boot output, which suggests the image loading and VM state is in the right place.
Which is nice.
Now that I'm no longer headless, I can figure out where things are getting stuck, so I'm trying to get a booted SmartOS system, which will confirm the command line and module information is being loaded correctly. I'll follow up if I get anywhere :)
Oh, I also had to patch illumos not to try and call into the (nonexistent) BIOS functions on boot - I get the feeling from the code that these calls aren't entirely necessary, but I'll see what the best course of action with this is later on.

@joshado If you pass the following command line to bootloader: "-B smart
os=true,console=ttya,prom_debug=1,kbm_debug=1 -kvd" you will see that SmarOS both sees correct arguments and ensures that the modules are also correct (hash sum check passes).

I actually just did the same here (well just prom_debug here) and got this output:
Solaris prekernel set: /Users/thomas/platform/i86pc/kernel/amd64/unix -B smartos
=true,console=text,prom_debug
(uintptr_t)bi is 0xc18160
target_kernel_text is 0xfffffffffb800000
Entered init_mem_alloc()
(uintptr_t)mb_info is 0x117a50bc

Finding Modules
next_avail_addr is 0xc1a000
        module #0: '/Users/thomas/platform/i86pc/amd64/boot_archive' at 0xe04000
, end 0x117a4000
next_avail_addr is 0x117a5000
        module #1: '/Users/thomas/platform/i86pc/amd64/boot_archive.hash' at 0x1
17a4000, end 0x117a4029
bi->bi_modules is 0xc174e0
bi->bi_module_cnt is 0x2
module #0: name /Users/thomas/platform/i86pc/amd64/boot_archive type rootfs addr
 e04000 size 109a0000
checking expected hash [1e16e52d3b4a52edf9ef846ce8fd53a09c64333e]: OK
module #1: name /Users/thomas/platform/i86pc/amd64/boot_archive type hash addr 1
17a4000 size 29
module has no hash; skipping check```

So it looks like the hash on the boot archive checks out OK. I was seeing a `krtld` relocation error, but that was down to my own stupidity, as I was using a `unix` binary outside of the standard `platform` tree.

I suppose any issues I've got now are likely unrelated to the multiboot bits. I'm not sure why the `tty` output wasn't working for me earlier before I hacked the VGA stuff - but it is now. ¯\_(ツ)_/¯

LGTM :)


Fixed the cover attribute for lumi.curtain.acn002 when using firmware 1427

As discussed in https://github.com/zigpy/zha-device-handlers/issues/1181 the previous lumi.curtain.acn002 quirk only worked for firmware 1425. This PR focusses on both firmware 1425 and 1427 to make the cover attribute work. Also in the process made the analogOutput attribute work properly and made small tweaks.
Background:
The commands in 1427 always report success but no action is done. This PR catched the commands and writes to MultistateOutput and also AnalogOutput to make the curtains go up, down, stop or go to certain percentage.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

12 of 32 (37.5%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.09%) to 80.442%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

zhaquirks/xiaomi/aqara/roller_curtain_e1.py
12
32
37.5%

Totals

Change from base Build<PHONE_NUMBER>:
-0.09%

Covered Lines:
5170

Relevant Lines:
6427

💛  - Coveralls

@schwickster are we good to merge now?

@schwickster are we good to merge now?

@schwickster are we good to merge now?

Yes. All the people that tested it said it was working for them. So feel free to merge! Thanks again for all the help.

@schwickster are we good to merge now?

Yes. All the people that tested it said it was working for them. So feel free to merge! Thanks again for all the help.

any time. Thanks for making this work for our users!


Web Interface: Palette Swap doesn't show up on Linear Mode

Palette Swap only shows up in Open World mode. It disappears when selecting Linear. Other options do disappear, but I figured that is likely because those randomization options do not work well in Linear as compared to Open. Palette however is cosmetic, thus shouldn't be of any affect on which mode selected.

You'd think that, but the linear mode patch is kind of a mess due to the only SMRPG ROM editor available and it's the legacy mode that isn't being worked on any further.  In theory the palette changes should work with that patch as well but the sprite data is very sensitive to changes.  I'll test this on our beta branch while we're developing new features for the main open world mode, but if it causes problems this won't be added.

Ahhh, ok, I didn't realize linear mode was like that. You might consider having a note that shows up when selecting Linear that it isn't currently/no longer supported to prevent this confusion.

Fair enough, I'll try to make that more clear with the wording.

This appears to work okay in linear mode.  It will be included in the next release.


Make campaign signup more mobile friendly

This PR is a rider-portal focused set of changes that makes the campaign sign-up delivery list and campaign sign-up task list more mobile-friendly.
For the Rider Task List, I left the desktop design to continue using a table-based layout and chose to render an unordered list for mobile. This means that the markup shows up twice in the DOM and is hidden by Tailwind. Optionally, I could remove the table entirely on desktop to reduce repetition.
On the implementation side, this does some small refactoring to tidy up how the sign up for campaign button renders as there are lots of permutations based on the rider's state as well as the campaign state.
Please review the below video to see a basic overview.
Commits are fairly atomic and go into more detail as necessary.
https://github.com/bikebrigade/dispatch/assets/12987958/3d7a97a6-dd4b-4200-aa3e-14eed36f3c47

Looks good!
One question in the code and I found you can still unassign yourself from campaigns in the past

We discussed a seperate ticket to make sure there's a window in which you can't unassign yourself, but I think before that we should disable that button for campaigns in the past,

Fixed:
https://github.com/bikebrigade/dispatch/assets/12987958/647e490a-5377-4798-999d-8f11cdba0f27


Try ro port test_inductor_cummax_bool to Triton

Part of #2030

Done in https://github.com/triton-lang/triton/commit/9e508a410c623c2bdabbc55ac46d0332b7196fae


Building headers fails on arm chromebook

Please paste the output of the following command here: sudo edit-chroot -all

name: precise
encrypted: no
Entering /mnt/stateful_partition/crouton/chroots/precise...
crouton: version 1-20161129162558~master:5f2f11f9
release: precise
architecture: armhf
xmethod: xorg
targets: unity
host: version 8872.76.0 (Official Build) stable-channel daisy
kernel: Linux localhost 3.8.11 #1 SMP Sat Jan 7 00:03:49 PST 2017 armv7l armv7l armv7l GNU/Linux
freon: yes
Not unmounting /mnt/stateful_partition/crouton/chroots/precise as another instance is using it.
Please describe your issue:
I need to build the sheepnet.ko for BasiliskII on my Arm Chromebook, but I'm having trouble building the kernel headers.
I fallowed the guide https://github.com/dnschneid/crouton/wiki/Build-kernel-headers-and-install-Virtualbox-(x86), but when I issue the command:
make-kpkg --rootcmd fakeroot kernel_image kernel_headers
It bombs out with this error:
CC drivers/gpu/arm/midgard/platform/chromebook/mali_kbase_config_chromebook.o drivers/gpu/arm/midgard/platform/chromebook/mali_kbase_config_chromebook.c: In function ‘pm_callback_suspend’: drivers/gpu/arm/midgard/platform/chromebook/mali_kbase_config_chromebook.c:1724:32: error: ‘level’ may be used uninitialized in this function [-Werror=uninitialized] drivers/gpu/arm/midgard/platform/chromebook/mali_kbase_config_chromebook.c:1710:9: note: ‘level’ was declared here drivers/gpu/arm/midgard/platform/chromebook/mali_kbase_config_chromebook.c: In function ‘kbase_platform_cmu_pmu_control’: /home/jam/Downloads/kernel/arch/arm/include/asm/io.h:107:2: error: ‘g3d_status_reg’ may be used uninitialized in this function [-Werror=uninitialized] drivers/gpu/arm/midgard/platform/chromebook/mali_kbase_config_chromebook.c:608:8: note: ‘g3d_status_reg’ was declared here /home/jam/Downloads/kernel/arch/arm/include/asm/io.h:107:2: error: ‘g3d_status_reg’ may be used uninitialized in this function [-Werror=uninitialized] drivers/gpu/arm/midgard/platform/chromebook/mali_kbase_config_chromebook.c:641:8: note: ‘g3d_status_reg’ was declared here cc1: all warnings being treated as errors make[7]: *** [drivers/gpu/arm/midgard/platform/chromebook/mali_kbase_config_chromebook.o] Error 1 make[6]: *** [drivers/gpu/arm/midgard/platform/chromebook] Error 2 make[5]: *** [drivers/gpu/arm/midgard/platform] Error 2 make[4]: *** [drivers/gpu/arm/midgard] Error 2 make[3]: *** [drivers/gpu/arm] Error 2 make[2]: *** [drivers/gpu] Error 2 make[1]: *** [drivers] Error 2
Any idea how I can get around this error?
If known, describe the steps to reproduce the issue:

It seems disabling warning on errors will solve it for you.
It can be that it is set as a config option in chromeos/config/base.config when it is you should find CONFIG_ERROR_ON_WARNING=y and turn it into CONFIG_ERROR_ON_WARNING=n
It can also be that it is set in the Makefile with the -Werror flag.

Thanks for the reply divx, I gave that a try, but it still bombs out with the same error.
 CC      drivers/gpu/arm/midgard/platform/chromebook/mali_kbase_config_chromebook.o drivers/gpu/arm/midgard/platform/chromebook/mali_kbase_config_chromebook.c: In function ‘pm_callback_suspend’: drivers/gpu/arm/midgard/platform/chromebook/mali_kbase_config_chromebook.c:1724:32: error: ‘level’ may be used uninitialized in this function **[-Werror=uninitialized]** drivers/gpu/arm/midgard/platform/chromebook/mali_kbase_config_chromebook.c:1710:9: note: ‘level’ was declared here drivers/gpu/arm/midgard/platform/chromebook/mali_kbase_config_chromebook.c: In function ‘kbase_platform_cmu_pmu_control’: /home/jam/Downloads/kernel/arch/arm/include/asm/io.h:107:2: error: ‘g3d_status_reg’ may be used uninitialized in this function [-Werror=uninitialized] drivers/gpu/arm/midgard/platform/chromebook/mali_kbase_config_chromebook.c:608:8: note: ‘g3d_status_reg’ was declared here /home/jam/Downloads/kernel/arch/arm/include/asm/io.h:107:2: error: ‘g3d_status_reg’ may be used uninitialized in this function [-Werror=uninitialized] drivers/gpu/arm/midgard/platform/chromebook/mali_kbase_config_chromebook.c:641:8: note: ‘g3d_status_reg’ was declared here cc1: all warnings being treated as errors make[7]: *** [drivers/gpu/arm/midgard/platform/chromebook/mali_kbase_config_chromebook.o] Error 1 make[6]: *** [drivers/gpu/arm/midgard/platform/chromebook] Error 2 make[5]: *** [drivers/gpu/arm/midgard/platform] Error 2 make[4]: *** [drivers/gpu/arm/midgard] Error 2 make[3]: *** [drivers/gpu/arm] Error 2 make[2]: *** [drivers/gpu] Error 2 make[1]: *** [drivers] Error 2 make[1]: Leaving directory/home/jam/Downloads/kernel'
make: *** [debian/stamp/build/kernel] Error 2`
First I edited the chromeos/config/base.configchanging CONFIG_ERROR_ON_WARNING=y to CONFIG_ERROR_ON_WARNING=n, that didn't seem to do anything, so I edited the Makefile:
# SHELL used by kbuild
CONFIG_SHELL := $(shell if [ -x "$$BASH" ]; then echo $$BASH; \
	  else if [ -x /bin/bash ]; then echo /bin/bash; \
	  else echo sh; fi ; fi)

HOSTCC       = gcc
HOSTCXX      = g++
HOSTCFLAGS   = -Werror -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 -fomit-frame-pointer
HOSTCXXFLAGS = -O2 -Werror
'''

For some reason it still says  [-Werror=uninitialized]?

You shouldn't enable the Werror flag. See https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html
After you changed the base.config did you run
$ ./chromeos/scripts/prepareconfig chromeos-exynos5
$ make oldconfig

If you didn't run those commands again the config didn't get updated so you would still get that error.

Ok, thanks divx, running prepareconfig and make oldconfig again worked, and I can confirm that when I built my own header, it included many headers that weren't in your packaged headers.

@lyons88 Nice


fix(video-player): import image component within video-player component

Related Ticket(s)
Video Player Web Component not rendering video thumbnail #5615
Description
Video player needs the image import otherwise the video image overlay does not appear.
Changelog
Changed

add image component import

Just as an fyi @annawen1 @shixiedesign , I'm seeing some false positives around the async data for the video player, I'm going to add some skips for percy for those particular elements so we can avoid the false positives in the future.

PR created: https://github.com/carbon-design-system/carbon-for-ibm-dotcom/pull/5656


fix: update diagnostic highlights

Related: Did you originally want the generic Diagnostic[Error|Warning|etc.] to be italic and have a background color or was that meant for DiagnosticVirtual[…]? I think the majority of themes only give the latter a bg.

I think it looks good for now


When a person enters a public room for the first time, it looks like a DM for the first couple seconds then updates to the room name.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

I go into a public room created by someone else.
Note: only the first person to enter the room sees this.

Expected Result:
The report name reads: Bob, Daniel (first image)
Actual Result:
Then after a second or two it updates correctly (second image)
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @danielrvidal
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686336462273589
View all open jobs on GitHub

@jliexpensify you have to be the first person in the room. Did you have someone open a room and then you be the first person to enter the room?

Yes @danielrvidal - I used my Expensify account to create a new room, which I then accessed with my Expensicorp account.
Question though: did you use the URL to access the room, or did you search in the LHN? Because I wasn't able to search for the room in my LHN, so I used the URL, which updated the name instantly.

I used a URL but all good if you can't replicate. We changed a lot in the past few days so it might have resolved itself.


Suffer Song

Song Name
Suffer
Artist Name
Petit Biscuit (Ft: SKOTT)
Source
Youtube
Youtube Link
https://www.youtube.com/watch?v=mR8QYKnrSL8
Direct File Link
No response
Song ID
1
Start Offset [ms]
No response
Extra
No response

reject


[APIReview] Replace JsonSerializerOptions with ObjectSerializer

In Azure.Core.Experimental, there is an ObjectSerializer - consider using that instead of System.Text.Json

PoR to implement this for serialization / deserialization once the ObjectSerializer is in a GA release of Azure.Core.  On hold right now.

Will not fix due to move away from the Azure.Core library.


Highlight already selected item in the list

Is your feature request related to a problem?
We need to show the user the last selection in the pop-up list.
Describe the solution you'd like:
there should be a way to mark bold or highlight the previous selected item in the pop-up item list

Hi @nikgupta1231, sorry for the late response.
You can achieve this with the Custom Spinner Adapter.


typo: Double word "see"

@nschonni : Thanks for your contribution! The author, @MashaMSFT, has been notified to review your proposed change.

Hi @nschonni, thanks for your contribution! Thanks for noticing these typos :) #sign-off


feat(NiftiVolumeLoader): enable the nifti-volume-loader to read nifti file with datatype such as int32, float64, int8, uint16 and uint32. Because there is something wrong with function ‘createInt16SharedArray’ and ‘createUint16SharedArray’(window.crossOriginIsolated is false), Float32SharedArray is used for representing datatypes except for uint8.

Context
[Feature Request] #964

Changes & Results
Before: The nifti-volume-loader can not read nifti file with datatype such as int32, float64, int8, uint16 and uint32, so the cornerstone3D cannot render them.
After: The nifti-volume-loader can read nifti file with datatype such as int32, float64, int8, uint16 and uint32.

Testing
Use the nifti-volume-loader component to load nifti file with datatype such as int32, float64, int8, uint16 and uint32.

Checklist
PR

[x] My Pull Request title is descriptive, accurate and follows the
semantic-release format and guidelines.

Code

[x] My code has been well-documented (function documentation, inline comments,
etc.)

[x] I have run the yarn build:update-api to update the API documentation, and have
committed the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)

Public Documentation Updates

[x] The documentation page has been updated as necessary for any public API
additions or removals.

Tested Environment

[x] "OS:  Ubuntu 18.04, macOS 14.2.1
[x] "Node version:  v16.14.0
[x] "Browser: Chrome 120.0.6099.234

Can you please share the data to test this?

Can you please share the data to test this?

Of course, I've uploaded the data to http://<IP_ADDRESS>/nifti_data.zip

@SuperSuperKey Ok i"m much more free from now on
I can't download your data, can you please upload it somewhere else?

@SuperSuperKey Ok i"m much more free from now on I can't download your data, can you please upload it somewhere else?

Sure, I've uploaded the data to google drive (https://drive.google.com/file/d/1sLOBm3PGT2XOAWdPRdcyMLZ7tOB9fCcT/view?usp=drive_link).

Thank you for your PR. I believe this new PR offers better support, so I will close your PR in favor of it.
https://github.com/cornerstonejs/cornerstone3D/pull/1219


Worker not checking in

Describe the bug
In a multi workers setup a noticed a stale harvester. I rebooted it, and now it wont check in at the full node. Even after purging he wont list at the workers. IP connectivity ext is in order.
Expected behavior
At the harvester I get these logs:
Execution of job "update (trigger: interval[0:00:05], next run at: 2021-08-12 11:57:57 UTC)" skipped: maximum number of running instances reached (1)
Execution of job "update (trigger: interval[0:01:00], next run at: 2021-08-12 11:57:57 UTC)" skipped: maximum number of running instances reached (1)
Execution of job "update (trigger: interval[0:00:05], next run at: 2021-08-12 11:58:02 UTC)" skipped: maximum number of running instances reached (1)
[2021-08-12 11:58:05 +0000] [95] [INFO] Failed to load plots farming and send.
[2021-08-12 11:58:05 +0000] [95] [INFO] Traceback (most recent call last):
  File "/chia-blockchain/venv/lib/python3.9/site-packages/urllib3/connectionpool.py", line 699, in urlopen
    httplib_response = self._make_request(
  File "/chia-blockchain/venv/lib/python3.9/site-packages/urllib3/connectionpool.py", line 445, in _make_request
    six.raise_from(e, None)
  File "<string>", line 3, in raise_from
  File "/chia-blockchain/venv/lib/python3.9/site-packages/urllib3/connectionpool.py", line 440, in _make_request
    httplib_response = conn.getresponse()
  File "/usr/lib/python3.9/http/client.py", line 1345, in getresponse
    response.begin()
  File "/usr/lib/python3.9/http/client.py", line 307, in begin
    version, status, reason = self._read_status()
  File "/usr/lib/python3.9/http/client.py", line 276, in _read_status
    raise RemoteDisconnected("Remote end closed connection without"
http.client.RemoteDisconnected: Remote end closed connection without response

And at the full node/farmer I get these:
WARNING:apscheduler.scheduler:Execution of job "update (trigger: interval[0:00:05], next run at: 2021-08-12 11:54:54 UTC)" skipped: maximum number of running instances reached (1)
WARNING:apscheduler.scheduler:Execution of job "update (trigger: interval[0:00:05], next run at: 2021-08-12 11:54:59 UTC)" skipped: maximum number of running instances reached (1)
[2021-08-12 11:55:03 +0000] [2003] [CRITICAL] WORKER TIMEOUT (pid:49612)
[2021-08-12 11:55:03 +0000] [49612] [INFO] Worker exiting (pid: 49612)
Failed to convert to GiB: Unknown
Traceback (most recent call last):
  File "/machinaris/common/utils/converters.py", line 21, in str_to_gibs
    val,unit = str.split(' ')
ValueError: not enough values to unpack (expected 2, got 1)

[2021-08-12 11:55:03 +0000] [50900] [INFO] Booting worker with pid: 50900
WARNING:apscheduler.executors.default:Run time of job "collect (trigger: cron[minute='*/5'], next run at: 2021-08-12 12:00:00 UTC)" was missed by 0:00:03.609948
WARNING:apscheduler.executors.default:Run time of job "update (trigger: interval[0:01:00], next run at: 2021-08-12 11:56:19 UTC)" was missed by 0:00:02.352730
WARNING:apscheduler.scheduler:Execution of job "update (trigger: interval[0:00:05], next run at: 2021-08-12 11:55:09 UTC)" skipped: maximum number of running instances reached (1)
WARNING:apscheduler.scheduler:Execution of job "update (trigger: interval[0:00:05], next run at: 2021-08-12 11:55:14 UTC)" skipped: maximum number of running instances reached (1)

System setup:

OS: Ubuntu 20.04
Docker version number (output of docker info)
Machinaris branch: test
Machinaris version number:

Chia™ 1.2.1
Chiadog 0.6.0
Machinaris 0.5.1
Madmax 974d6e5
Plotman 0.5

Kind regards,
Bastiaan

I think there was a version incompatibility. All on 0.5.2 and no problems anymore.


Fixing Page Settings -> Location

This PR fixes the following error/warning that occurs with PHP 7.3 And 7.4 when "Consider warnings as errors" is set and the user goes to Page Settings and then clicks on Location:
Exception Occurred: /Applications/MAMP/htdocs/c855/concrete/views/panels/details/page/location.php:9 Undefined variable: sitemap (8)
We've initialized $sitemap to fix it.

yes, this fix looks good.

Fixed.
I'm gonna include these fixes in a new PR against develop branch.


Why babel-cli is a project dependency?

Just curious.

Just sloppiness :-) Thanks for reporting it! Fixed in 2.4.5.


MINOR: Fix now that kafka.apache.org resolves to 3 IP addresses

ClusterConnectStatesTest and ClientUtilsTest were failing because they expected kafka.apache.org to resolve to 2 IP addresses. This updates the tests so they reflect that DNS resolves to 3 addresses.

@abbccdda I agree that they are fragile. Could you give a little more detail about checking the patterns? I'm not sure if I follow.

Netty used a in-memory DNS server for such tests: https://github.com/netty/netty/blob/master/resolver-dns/src/test/java/io/netty/resolver/dns/TestDnsServer.java. I suppose that we could do something similar in AK as well.
What about merging this one and filing a JIRA to improve this in the future? All these flaky tests due to this are quite annoying so we could already fix them. What do you think?
It would be great if we could backport it to previous versions as well.

Agreed with @dajac's suggestion. Maybe for this change we could have the assertion as > 1 rather than equalling a specific value

I also like @dajac's suggestion. I've updated the PR so that the tests assert more than 1 address as @mumrah said.

Also created the issue https://issues.apache.org/jira/browse/KAFKA-10496

Thanks for the patch @jolshan!

Have we cherry picked this to older branches? It seems like they will be broken otherwise.

2.6 backport applied cleanly, kicked off a build here https://ci-builds.apache.org/job/Kafka/job/kafka-2.6-jdk8/15/
2.5 had a conflict, and one test fails for me locally. I'll look into it along with other branches this evening

How far back should we backport?

Checking the AK -> CCS merge Job branches, the 2.3 through 2.5 branch unit tests are failing on the tests that this fixes.

@mumrah I think 2.0 and higher would be a good target. We don't need separate PRs as long as the cherry pick is clean.


Improve handling of .kip file

As an argument to each command, defaulting to an env?

Hold a list of all kip files in a config file and add comands to add, remove and list the kip files


Split schema into declaration and updates

Comments from PTC R&D suggested that the core TIF schema should only describe the template and NOT any manipulation of the template, i.e. edit actions.
The current schema does include edit operations that are required when deploying deltas.
Question for the group: should we enact this?
The ramifications would be changes to the deployment process. This should be combined with the move to API deployment rather than CLI.

This will of course make the schema quite easy and maintainable, however it moves all the difficult operation like comparison etc. to the community.
The detection of e.g. a field rename is getting more and more complicated if not impossible, you´d just have two xml files that have a list of fields…how do you want to compare them????
Even in case a comparison is successfully done, we need a way to save the result or in this case the create and edit calls in some kind of format..just to be able to double check what was successful and what could not be done, so we´d need another xml format?!?!? Doesn´t seem to be a good idea..
I´d keep the format as is…then we have one xsd that can be used for both use cases..
-p
From: paul-bowden<EMAIL_ADDRESS>Sent: Mittwoch, 29. Juli 2015 16:11
To: PTC-ALM/TIF
Subject: [TIF] Split schema into declaration and updates (#13)
Comments from PTC R&D suggested that the core TIF schema should only describe the template and NOT any manipulation of the template, i.e. edit actions.
The current schema does include edit operations that are required when deploying deltas.
Question for the group: should we enact this?
The ramifications would be changes to the deployment process. This should be combined with the move to API deployment rather than CLI.
—
Reply to this email directly or view it on GitHubhttps://github.com/PTC-ALM/TIF/issues/13.


[💡FEATURE] : Adding a favicon

Is your feature request related to a problem? Please describe. 📝
A clear and concise description of what the problem is.
Describe the solution you'd like 🛠
Want to add a favicon to the website
Describe alternatives you've considered 🔄
A clear and concise description of any alternative solutions or features you've considered.
Additional context 💬
Add any other context or screenshots about the feature request here.

send me your email on discord.

send me your email on discord.

sure @Premkolte

@Premkolte is there any logo already designed that should be place as a favicon,
or I have to design it let me know .

you can design one and comment in issue #6

@Premkolte I have designed some logos have a look and let me know which suits best .

@Premkolte I have designed some logos have a look and let me know which suits best .

@Premkolte ?

@Meetjain1 I have mentioned it under logo issue


Display possible PropTypes.oneOf values

 Issue by kevinSuttle
Wednesday Jun 29, 2016 at 17:45 GMT
Originally opened as https://github.com/storybooks/react-storybook-addon-info/issues/35

import React from 'react';
require('./Headings.css');

const headingTypes = {
 page: <h1 />,
 modal: <h2 />,
 section: <h3 />,
 sub: <h4 />,
}

const Heading = ({ type, children }) => {
  const headingElement = headingTypes[type]
  return React.cloneElement(headingElement, {
    className: `${type}Heading`,
  }, ...children)
}

Heading.propTypes = {
  type: React.PropTypes.oneOf(Object.keys(headingTypes)).isRequired,
}

export default Heading;

Here's what I would expect to see, given the following story.
.addWithInfo(
    'simple usage (inline info)',
    `
      Section Heading API usage
    `,
    () => (<Heading type="section")}>Section Heading</Heading>),
    { inline: true },
  );

property
propType
default
oneOf
required

type
string
page
page modal section sub
true

 Comment by kevinSuttle
Wednesday Jun 29, 2016 at 17:49 GMT

Interesting.

 Comment by arunoda
Wednesday Jun 29, 2016 at 17:47 GMT

We'd like to do that. But, it's not possible to get this at runtime without hijacking PropTypes code.
That's why it's not there now.
@mnmtanish @roonyh May be we need to hijack PropTypes to get these.

Is someone looking into this? i'd love to see this working!
Now it seems kinda broken when using oneOf proptypes, because it simply shows a blank space

This should be working if you have react-docgen working. It supports oneOf among other things and lists the contents inside an array.

Hi, is this still outstanding? I have react-docgen working but oneOfstill displays -

I wonder if this is related to https://github.com/reactjs/react-docgen/issues/235
Just checked in our example app and it looks like the propType indeed doesn't work.

Noticing the same issue after attempting to upgade all my storybook packages to 3.3.3...
when setting a propType using oneOf alongside withInfo addon, I now see the following error with addon-info 3.3.3. I did not see this issue when using the deprecated API and 3.2.12
Alert.js:
import ClassNames from 'classnames';
import React from 'react';
import PropTypes from 'prop-types';
import { ALERT_TYPES, ALERT_TYPE_ERROR } from './constants';

const Alert = ({ children, className, onDismiss, type, ...props }) => {
  ...
};
Alert.propTypes = {
  /** additional alert classes */
  className: PropTypes.string,
  /** callback when alert is dismissed  */
  onDismiss: PropTypes.func,
  /** the type of alert  */
  type: PropTypes.oneOf(ALERT_TYPES).isRequired,
  /** children nodes  */
  children: PropTypes.node
};

constants.js:
export const ALERT_TYPE_DANGER = 'danger';
export const ALERT_TYPE_ERROR = 'error';
export const ALERT_TYPE_WARNING = 'warning';
export const ALERT_TYPE_SUCCESS = 'success';
export const ALERT_TYPE_INFO = 'info';

export const ALERT_TYPES = [
  ALERT_TYPE_DANGER,
  ALERT_TYPE_ERROR,
  ALERT_TYPE_WARNING,
  ALERT_TYPE_SUCCESS,
  ALERT_TYPE_INFO
];

Error:
index.js:16 TypeError: propType.value.map is not a function
    at OneOf (OneOf.js:20)
    at mountIndeterminateComponent (react-dom.development.js:8032)
    at beginWork (react-dom.development.js:8221)
    at performUnitOfWork (react-dom.development.js:10224)
    at workLoop (react-dom.development.js:10288)
    at HTMLUnknownElement.callCallback (react-dom.development.js:542)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:581)
    at invokeGuardedCallback (react-dom.development.js:438)
    at renderRoot (react-dom.development.js:10366)
    at performWorkOnRoot (react-dom.development.js:11014)

after debugging a bit...seems that OneOf definition here is accepting literals but not import'd types.

Should be fixed with https://github.com/storybooks/storybook/pull/2653

Released 3.3.14

The fix does not take into account all use cases of oneOf. In our case we have a select number of keys where share the same shape (specifically, this is a theme for styled components). I would prefer not to have to repeat the same shape.
The following still does not work:
 theme: t.shape({
    checkbox: t.objectOf(t.shape({
      [t.oneOf(CheckboxWrapped.checkboxTypes)]: t.shape({
        size: t.number,
        iconName: t.string,
        borderRadius: t.string,
        [t.oneOf(['checked', 'unchecked'])]: {
          background: t.string,
          borderColor: t.string,
          color: t.string,
        },
      }),
    })),
  }),


Make certain options animatable

Feature Proposal
It would be nice if the user could animate options such as axis tick paddings, label colors or sizes.
Feature Use Case
I am trying to animate the color/opacity and padding for the labels of a line chart  Preferably I'd like to have the option to stagger the animation for each label
There are now multiple ways this could be implemented.  The following gif shows what I mean by "staggered" and animating labels, although it's based on a different chart type. The labels on the bars and the ticks, are translated and their opacity is animated.

Possible Implementation
First I thought this could be implemented by allowing a call to the update function in the onProgress hook but it turns out this massively slows down rendering and also doesn't work properly and maybe the API would look messy then. So another option would be to extend the animation object to accept options that should be animated with their own duration, easing and delay. For options concerning iterable items such as labels there could be a stagger parameter or a delay array instead of a value where the entries could represent the delay of each respective item.
It could look like this
animation: {
  easing: 'easeInOutExpo',
  duration: 2000,
  //The following extends the regular animation object
  animateOptions: [{
    animationTarget: scales.yAxes[0].ticks.padding,
    value: [0, 10], // [start, stop]
    easing: 'easeInSine',
    delay: 50, // Delay in ms before animation starts
    staggered: true, // Whether animation should be staggered for the labels
    staggerDelay: 75 // Stagger delay in ms for each element
  },
  {
    animationTarget: scales.yAxes[0].ticks.fontColor,
    value: ['rgba(242, 141, 114, 0)', 'rgba(242, 141, 114, 1)'], // Anime.js can do that
    easing: 'easeOutQuad',
    delay: 50,
    staggered: true,
    staggerDelay: 75
  }]
},

Implemented in #6845


Weird display of Android sample: stream test

I are trying to use camera preview as an external texture. It works on most devices but on some other device, its displayed weird (check pics below). I have try to run the stream test and got the same result. Our solution is similar to the texture id one.

To Reproduce

Run the android stream test sample.

Expected behavior

Display normal

Screenshots
Vivo X7:

Vivo X9Plus L:

Oppo R9M:

Android device:

Device: Vivo X7 / Vivo X9Plus L / Oppo R9M / Meizu MX5
OS: Android 5.1.1 / Android 7.1.2 / Android 5.1 / Android 5.1
GPU: Adreno510 / Adreno510 /  Adreno510 / PowerVR G6200

Does our sample-hello-camera demo work on these devices?
We mostly test with Pixel 3 and Pixel 4, this might be a driver issue.

Does our sample-hello-camera demo work on these devices?
We mostly test with Pixel 3 and Pixel 4, this might be a driver issue.

sample-hello-camera is not working too.  But it is due to API compatibility problem.
07-21 13:49:25.212 29714-29714/com.google.android.filament.hellocamera E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.google.android.filament.hellocamera, PID: 29714
java.lang.NoSuchMethodError: No static method newInstance(IIIIJ)Landroid/media/ImageReader; in class Landroid/media/ImageReader; or its super classes (declaration of 'android.media.ImageReader' appears in /system/framework/framework.jar)
at com.google.android.filament.hellocam.CameraHelper.(CameraHelper.kt:56)
at com.google.android.filament.hellocam.MainActivity.onCreate(MainActivity.kt:97)
at android.app.Activity.performCreate(Activity.java:6251)
at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1112)
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2622)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2766)
at android.app.ActivityThread.access$1000(ActivityThread.java:197)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1611)
at android.os.Handler.dispatchMessage(Handler.java:111)
at android.os.Looper.loop(Looper.java:224)
at android.app.ActivityThread.main(ActivityThread.java:5958)
at java.lang.reflect.Method.invoke(Native Method)
at java.lang.reflect.Method.invoke(Method.java:372)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1113)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:879)

This sample app requires a newer version of Android. These problems look like they are specific to those devices and versions of android. I don’t think there’s anything we can do about it on our side unfortunately.

I understand the sample-hallo-camera request new Android API, but why sample-stream-test needs new API?
Our purpose is to bind camera preview to a given opengl oes texture id, then render this texture with Filament. We already successfully tested this solution with most devices which supported the hardware buffer. However, for those devices which API level under 26. We got black screen or mosaic like display.
I believe the way we can implement the camera preview is very similar to the sample-stream-test. That's why we decided to test the sample-stream-test with above devices.

not actionable / device specific


Delegate WireMockExtension.url(String) to WireMockServer

(Final unsolicited MR, I promise :heart: )
In migrating both my own projects and all project tests, I found that for programmatic use there's a frequent need to compose URLs to instances of WireMockExtension. Since WireMockExtension does not expose the underlying WireMockServer, one is then forced to compose URLs by calling baseUrl() and appending/formatting the suffix. For such a common use case I think there's value in creating a direct delegate method to do the same.
As seen in JUnitJupiterExtensionFailOnUnmatchedTest this simplifies the URL composition, and reduces the need for baseUrl(). I understand it's not desirable to have delegates to all methods in WireMockServer, but for such a common use case I think it's warranted to make the development experience easier.
If you feel any different no problem to close the MR; I figured it's easier to get across the point in an MR rather than starting a separate issue for the discussion first.

Thanks!


WithPerTenantOptions overload allowing dependency injection?

In order to use dependency injected services while configuring services, you'd normally inherit from IConfigureNamedOptions or IConfigureOptions and register a singleton like this:
services.AddSingleton<IConfigureOptions<CookieAuthenticationOptions>, MyConfiguration>();

Inside MyConfiguration I can have dependencies injected:
    class MyConfiguration : IConfigureOptions<CookieAuthenticationOptions>
    {
        private IDataProtectionProvider dp;

        public GatewaySessionConfiguration(IDataProtectionProvider dp)
        {
            this.dp = dp;
        }

        public void Configure(CookieAuthenticationOptions options)
        {
            options.TicketDataFormat = TicketDataFormat(dp.CreateProtector("on purpose"));
        }
    }

With the current WithPerTenantOptions<CookieAuthenticationOptions> I cannot achieve the same. The data protector is only instantiate later on in the pipeline and I cannot grab a reference to it in ConfigureServices.

Named options added to the latest release. Cheers.


removed https:// prefix from "QUOTE_FORMAT"

Upon trying to use this config file, rainbowstream threw the following error: "Your ~/.rainbow_config.json is messed up:

Invalid control character at: line 27 column 38 (char 406)". I simply removed the https:// prefix from the url and it worked.

Sorry for the late reply. https is need to make use of modern-style quotes. See details in https://github.com/DTVD/rainbowstream/pull/197.
I guess that if you update to latest version then the config error will gone.


Command is not available in PS session

After establishing connection to Office 365 Security & Compliance Center using Connect-IPPSSession -UserPrincipalName <my username> New-DlpEdmSchema command is not available in the list of imported commands.
Remove-DlpEdmSchema and Get-DlpEdmSchema are available but not New-DlpEdmSchema.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1d48d419-9647-b892-5b71-96fcce0325ae
Version Independent ID: cd7deb2b-2f68-14f2-aeeb-cde75fd21168
Content: New-DlpEdmSchema (exchange)
Content Source: exchange/exchange-ps/exchange/policy-and-compliance-dlp/New-DlpEdmSchema.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@officedocsbot assign @yogkumgit

Hi @adv0cem, thank you for your feedback.
I suggest that you open a support case as I can see that the cmdlet is available in my lab tenant:

@dariomws306  Thank you very much for the contribution and sharing this explanation. @ravick4u
Hope this comment is helpful for you. Considering the nature of the issue, as advised, please open a service ticket in your tenant and follow with them for the resolution.
We will be very happy if you can share the outcome or resolution with us if you see documentation update is required. We will certainly update this documentation with that valuable information. Thanks again, for taking out some time to open the issue. Appreciate and encourage you to do the same in future also


build: handle spaces in Xcode better (NFC)

Quote the path to the python interpreter.  Without this change, using a
path with a space in it will prevent CMake from configuring as the
python interpreter's path will be split.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

CC: @edymtt @shahmishal

@swift-ci please smoke test


About heatmap's feature's weight

My data is (lonlat,peoplecount), and the number of people range from 10 to 1000.
But the heatmap's feature's weight range from 0 to 1.
So I need to  normalize the number of people to  (0,1)?

So I need to normalize the number of people to (0,1)?

yes, you must set the weight property to a value from 0 to 1

I think this restriction is very inconvenient. Is it possible to cancel this limitation? Otherwise, we have to do the normalization by ourself.

Otherwise, we have to do the normalization by ourself.

Internal normalization doesn't really make sense. Say your heatmap data can go from 0 to 1000, but in your current data the max value is 100 - with internal normalization the weight for 100 will be 1.0, when if you normalize the data with your data limit the weight for 100 will be 0.1 - therefore the resulting heatmaps will be different.
Also adding a new point with value >100 will result in weight >1.0 therefore the weights for all of the points will need to be re-calculated which might not be what you want.
I guess that is the main reason why you have to normalize the weights.

Right, If you add the data at once and will not add anymore, then it's fine for auto normalization from OL. but if you need to add new data when heatmap exists, all the weight should be recalculated.


Added basic UI

Hi,
I have implemented the following project requirements. Kindly verify.
Project requirements

Watch the video with the UI example again (you have seen it while reading the Sneak Peek).

Your console app should behave in the same way as it is in the example.
Create a app.rb file that will serve as your console app entry-point. It should have methods that do the following:

List all books.
List all people.
Create a person (teacher or student, not a plain Person).
Create a book.
Create a rental.
List all rentals for a given person id.

In your main.rb define the entry point, this will be a method called main that is invoked at the end of your file. This method should do the following:

Present the user with a list of options to perform.
Lets users choose an option.
If needed, ask for parameters for the option.
Have a way to quit the app.

@BenMukebo Thank you for the code review. But I could not submit it now. Can you please help me? I am getting error message "Our systems run operations on Sundays, but since it is currently after program hours you cannot make progress towards your activities at this time. You will have full access to this page within the normal working hours of your scheduled program. Please check back at the start of your day."


Dynamic routes

Looked at some examples and pre defined routes like /about seems to work fine, but does this work for dynamic routes aswell like /:pageid. How should i set it up then?

Seems not working correctly, other page will fresh before dynamic route loads

can't seems to figure out how to use it with dynamic routes or with redux-persist successfully.

React-snapshot will crawl all links that it will found. You can create "site map" page, which will contain links to all pages.

@stereobooster That's a great idea! I recommend adding that tip to the documentation.

Closed in #81 thanks @aaronshaf


Do not subscribe already registered users to basket.

Coverage remained the same at 92.996% when pulling 3c7b86d049fa2422c6f8e7be162f927e6431a1b1 on akatsoulas:basket-raise-exc into cba5a23e2705ba4f59007d315ad9cee21efeff19 on mozilla:master.

Coverage increased (+0.0007%) to 92.996% when pulling daa8b1d5b9b3289a0613713035c588c3ebc3fa1c on akatsoulas:basket-raise-exc into cba5a23e2705ba4f59007d315ad9cee21efeff19 on mozilla:master.


How can I actively stop a conversation using code?

How can I actively stop the conversation using code? Which function can achieve this?

Could you elaborate on what you mean by "stop the conversation"? Thankyou.

The meaning is that I want to achieve the effect of clicking the stop button using code. How can I implement this? Is there a method for it? Thank you

Currently there is no programmatic way to toggle the Submit button, however if you want to, you can simply do this by finding the submit button element via a querySelector and toggling it via JavaScript that way.
Example:
// Get the Deep Chat element reference, there are many ways to do it but one is by getting it via an id
const chatElementRef = document.getElementById('chat-element');
const submit = chatElementRef.shadowRoot.querySelector('#input > div:nth-child(5) > div');
submit.click(); // then simply toggle the click

The html for attaching an id can be done as:
<deep-chat id="chat-element"></deep-chat>

To get the selector, inspect the elements using your browser and copy the selector by right clicking it, the following is an example in Chrome:

Let me know if this helps.
Thanks!


Fix: Wallet page does not update instantly when bank account is added or deleted

Details

https://github.com/Expensify/App/issues/29767
Fixed Issues

$ https://github.com/Expensify/App/issues/29767
PROPOSAL: https://github.com/Expensify/App/issues/29767#issuecomment-1766801187
Tests

Goto Settings -> Wallet
Add a new bank account or delete an existing one
Verify the list of bank accounts updated correctly

[X] Verify that no errors appear in the JS console

Offline tests

Goto Settings -> Wallet
Add a new bank account or delete an existing one
Verify the list of bank accounts updated correctly

QA Steps

Goto Settings -> Wallet
Add a new bank account or delete an existing one
Verify the list of bank accounts updated correctly

[X] Verify that no errors appear in the JS console

PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android / native
[X] Android / Chrome
[X] iOS / native
[X] iOS / Safari
[X] MacOS / Chrome / Safari
[X] MacOS / Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/14358475/d7ffb06b-827b-48e6-9846-5139c4c3798f

Mobile Web - Chrome
https://github.com/Expensify/App/assets/14358475/1f648916-e05f-41a8-93d1-92620ed0fded

Mobile Web - Safari
https://github.com/Expensify/App/assets/14358475/bff6e5b1-233b-43ac-be2c-0133e6a0cdd2

Desktop
https://github.com/Expensify/App/assets/14358475/b772b536-d3ce-4676-8e4c-998599a413f3

iOS
https://github.com/Expensify/App/assets/14358475/46836881-8df0-4bd5-a05d-7f93f3668d75

Android
https://github.com/Expensify/App/assets/14358475/b4e285b2-2634-4996-9503-d91a1a28a42c

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/108292595/3aa8a012-9eaf-431c-bd40-464cc46345b8

Android: mWeb Chrome
https://github.com/Expensify/App/assets/108292595/a861601b-e2dc-477e-9c5e-8d5df5eef7b3

iOS: Native
https://github.com/Expensify/App/assets/108292595/a861601b-e2dc-477e-9c5e-8d5df5eef7b3

iOS: mWeb Safari
https://github.com/Expensify/App/assets/108292595/3aa8a012-9eaf-431c-bd40-464cc46345b8

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/108292595/a861601b-e2dc-477e-9c5e-8d5df5eef7b3

MacOS: Desktop
https://github.com/Expensify/App/assets/108292595/3aa8a012-9eaf-431c-bd40-464cc46345b8

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.3.96-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.96-15 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.97-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


HTLM

#HTML
##User Story
As a boot camp student,
I want a Prework Study Guide website,
so that I can review all the information I learned throughout Prework.
##Acceptance Criteria
GIVEN a Prework Study Guide website
WHEN I visit the website in my browser
THEN I see four boxes titled HTML, CSS, Git, and JavaScript with associated notes listed

All acceptance criteria have been met.


DUPLO-17370 Unable to create duplocloud_aws_dynamodb_table_v2 resource.

Overview
Fixed creation issue for duplocloud_aws_dynamodb_table_v2 resource due to fixes related to dynamo table name
Summary of changes
This PR does the following:

Added fullname computed attribute to hold table name with duplo prefix
Fixed create and update context, setting resource Id as tenant-id/fullname

Testing performed

[ ] Using unit tests
[ ] Manually, on my local system
[ ✓] Manually, on a remote test system

Describe any breaking changes

...

Task linked: DUPLO-17370 TF: Unable to create duplocloud_aws_dynamodb_table_v2 resource.


www-data group suddenly exists where it didn't before

New builds of mine are failing because the python image now contains a group named www-data. Why was this added?

It's in alpine


Day names

Hi,
Is there a function to get the day names in Farsi like شنبه ?

Thanks for taking the time to report. Unfortunately no, because the original Date class has no functionality to formate dates, and so this library has no formatting capabilities.
The main purpose of this library is to replace the Date class and provide the same functionality, but it's welcome for PRs if you want add other functions for formatting.


opposite to stats.chi2.ppf

Mine is a question.
I am trying to find chi-square of two columns[categorical], hence therefore relativity between them. Also, after finding chi-sqaure value.. I want to use it as critical value and find the confidence level(just opposite what .chi2.ppf does)..! Can you tell me what is just opposite to stats.chi2.ppf(q = 0.95, df = 4)
Also, the crosstabs value are very large. Will it affect the results of chi-square value?
cross_tab=pd.crosstab(dataframe['Wdft_IsGamer'],dataframe['HasDetections'] , rownames=['a'], colnames=['b'])
chivalue,,df,=scs.chi2_contingency(cross_tab)
print(scs.chi2.cdf(chivalue, df))--> 1.0
--cross_tab--
b          0        1
a
0.0  3197504  2976639
1.0  1119559  1324330

By opposite do you mean inverse function? If so, the cumulative distribution function, orcdf is the inverse function of the ppf.  E.g.
In [3]: scipy.stats.chi2.ppf(0.95, df=4)
Out[3]: 9.487729036781154

In [4]: scipy.stats.chi2.cdf(9.487729036781154, df=4)
Out[4]: 0.95

I close this since there is no issue with the functionality. As Paul pointed out, most likely cdf is the method that is needed.
Note that there is also a chisquare test:
https://docs.scipy.org/doc/scipy/reference/generated/scipy.stats.chisquare.html#scipy.stats.chisquare

Sorry being late!
so just consider this case.
The crosstab I have
b          0        1
a
0.0  3197504  2976639
1.0  1119559  1324330
I intend to find chi-square statistic and hence the p-value.
The result of :
chivalue,p,df,ex=scs.chi2_contingency(ch_test)
print("{},{},{},{}".format(chivalue,p,df,ex))
is:
25028.258980134848,0.0,1,[[3092836.54342534 3081306.45657466]
[1224226.45657466 1219662.54342534]]
1.0
For furthur clarification:

import scipy.stats as scs
scs.distributions.chi2.sf(33818.38656256124,33818)
0.49838436837459354
scs.distributions.chi2.sf(33818.38656256124,3381)
0.0

My query is to seek out another method for finding probability (p-value) where the observed values are high as compared to degrees of freedom.!
:)


SyntaxError: invalid syntax

I'm trying a trival test to where the contig is the same as the ~160kb reference (attached). I am running v1.1 on OSX 10.15.4. This is what happens:
ragoo.py KP420442.fasta KP420442.fasta
Traceback (most recent call last):
  File "/usr/local/bin/ragoo.py", line 4, in <module>
    __import__('pkg_resources').run_script('RaGOO==1.1', 'ragoo.py')
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/pkg_resources/__init__.py", line 666, in run_script
    self.require(requires)[0].run_script(script_name, ns)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/pkg_resources/__init__.py", line 1460, in run_script
    exec(script_code, namespace, namespace)
  File "/Library/Python/2.7/site-packages/RaGOO-1.1-py2.7.egg/EGG-INFO/scripts/ragoo.py", line 11, in <module>

  File "build/bdist.macosx-10.15-x86_64/egg/ragoo_utilities/ContigAlignment.py", line 4, in <module>
  File "/Library/Python/2.7/site-packages/RaGOO-1.1-py2.7.egg/ragoo_utilities/utilities.py", line 30
    print(time.ctime() + ' --- ' + message, flush=True)

KP420442.fasta.gz

Hi there,
I apologize for the late reply. I have been busy submitting a paper, but soon I will download your data and see if I can reproduce the error.

I am unable to reproduce your error and RaGOO runs to completion on your test data. I think this is actually an installation issue. It looks like you have installed with python2.7. Please install with python3 and see if the problem persists.
Thanks

Yes, that was it. Thank you.


StatefulJob can't easily tar node data

The StatefulJob docs state this, and I'm attempting to use it for the same function.
Strangelove uses it to compress and upload snapshots of chain data.

I'm having a problem achieving this though. On the Provenance chain our nonpruned nodes contain about 1TB of data. Our PVCs are setup for 1.25TB and to grow when they are at 90% used. With about 25% space overhead, there's not enough space to compress the data and store the tar.gz on the same volume.
The two ways I could think that the StatefulJob could support this would be the following:

Allow configuration to specify additional PV/PVCs that are created/cleaned up
Allow setting additional snapshot PV size. Then the PV is restored from the snapshot, it is then edited to increase its size further based on this config

I can try tackling this if we settle on the solution.

We currently handle this by doing a streamed compress and upload so that storage is not necessary for the compressed file prior to upload.
For resumable uploads though, it would be great to have this feature so that the file is compressed once, and retries can be retried.
We could add an additional parameter that would allow creating the StatefulJobs PVC with something like twice the size so that additional room was available for these kinds of operations.


Clean up and improve performance of WAYF

This issue is imported from pivotal - Originaly created at Aug 9, 2016 by Alex Rothuis
Currently the WAYF consists of a single JavaScript file with a lot of logic. While keeping functionality the same, this logic can be simplified
and its operations can be optimized. When searching for institutions, 20,000 entries could be used for benchmarking.
Candidates for improvement:

Structure: Use separate files and functions/objects to improve maintainability
Algorithm: Apply the filter on an already filtered list instead of filtering the entire list each time (a search tree implementation comes to mind)
Rendering: Use a virtual DOM (or something comparable) to reduce the amount of rendering operations

I inserted ~90.000 idp's in EB's Doctrine database to force a Big WAYF. This resulted in unavailable service due to memory allocation problems. I suggest testing the Big WAYF with real DB data and make DB queries smarter using LIMIT? (Martin van Es - Dec 23, 2016)


Added commenting to referendum voting

Addresses issue #534

Comments don't work on oppose actions, will merge + fix.


Please draw a diagram for Active Directory (AD) (preview)

Please draw a diagram for Active Directory (AD) (preview). For example

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fba964be-3f77-d80c-f1a5-35bb1430bb8f
Version Independent ID: fe70b11e-10fe-5a8c-1fad-b22a83693503
Content: Enable Active Directory authentication over SMB for Azure Files
Content Source: articles/storage/files/storage-files-identity-auth-active-directory-enable.md
Service: storage
Sub-service: files
GitHub Login: @roygara
Microsoft Alias: rogarana

@eakarat1141 Thank you for your feedback, our team will further look into it and get back to you at the earliest.

@eakarat1141 Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document

Hello @eakarat1141 , would you clarify your request? The article already has a diagram in it. What are you looking for a diagram of?
Ex: Workflow diagram- https://docs.microsoft.com/en-us/azure/storage/files/storage-files-identity-auth-active-directory-enable#workflow-overview

@roygara I mean solution Architecture.  About this .To make it easier to understand how to use the azure service
https://docs.microsoft.com/bs-latn-ba/azure/architecture/reference-architectures/identity/adds-extend-domain.

@eakarat1141 Sorry for the delayed response, we have added a diagram here. We've also revamped the AD DS authentication documentation experience, which should clarify how things work substantially.
Accordingly, I'll close this out for now.
Thanks for the feedback and helping to improve our docs, we appreciate it! :)
#please-close


Master merge pathmap

I created a indy-1.9.x branch.
Then I merged the path-mapped branch to master here.
This looks a big pr but really not that big. You can ignore the ftests, pom files, new files, then there are just a few classes changed.
Please review this.
After merged, I will upgrade the version to 2.0-SNAPSHOT.

We can hold it for a while. I just updated the graphite prefix to align with the grafana env var pattern. I will start a perf test on devel-master again. I'd like to see the SRE graph before merge it. Maybe we can review the migration plan when Gang is back.


Feature request : include release builds in artifacts

This is to let more people who want to help with testing.
Correct me if I'm wrong, but currently Github actions produce an Orbiter build which is "Debug" Version.
So people who don't have Visual Studio installed can't run these artifacts as it requires some debug dlls (https://www.orbiter-forum.com/threads/skybolt-client-development.40057/page-5#post-599087).
Would it be possible to also include a "Release" version in the artifacts? Should be faster to run too.

I wasn't even aware that the artifacts were packing debug builds. The build script specifies configuration "RelWithDebInfo", but this is done on the build rather than the config step, which may be ignored by the Ninja generator.
For Ninja, the solution may be to add the flag
-DCMAKE_BUILD_TYPE=Release
on the config step.
Testing this will have to wait because I will be out of the loop for a few weeks. I'm just putting this comment here to remind myself.


Feature: Changed vulnerability categories to support MITRE ATT&CK

Description
kube-hunter was one of the first projects that offered a Pentesting solution for kubernetes.
This arose a lot of new problems as this field of "hacking" kubernetes was at it's really early stages, so we had room for innovative new ideas.
We decided then to categorize kube-hunter's innovative techniques with a simple category system:
InformationDisclosure
DenialOfService
RemoteCodeExec
IdentityTheft
PrivilegeEscalation
AccessRisk
UnauthenticatedAccess

Time passed and new tools and blogs were published around the kuberentes security world.
A new MITRE ATT&CK matrix  was published for kubernetes environments. which did a pretty good job of covering the techniques (mostly already implemented in kube-hunter) used while hacking a kubernetes environment.
We know a good category system when we see it, So we decided to move for that system.
Code changes

A bit of package architecture redesign of the core.types sub package
Created a new module core.types.categories which defines new categories implemented for this change
new class MITRECategory -> base class for all mitre categories
new class CVECategory -> All cve vulnerabilities are not part of the new category system. so they will inherit from this base class

For every part of the threat matrix, we have a python class.
Example
CAP_NET_RAW is enabled inside a pod.
The vulnerability object now looks like this:
class CapNetRawEnabled(Event, Vulnerability):
    def __init__(self):
        Vulnerability.__init__(
            self,
            KubernetesCluster,
            name="CAP_NET_RAW Enabled",
            category=ARPPoisoningTechnique,
        )

let's take a look at: ARPPoisoningTechnique
it inherits from LateralMovementCategory which inherits from MITRECategory
Because of the class method implemented inside MITRECategory we can now do something like this:
>> ARPPoisoningTechnique.get_name()
"Lateral Movement // ARP poisoning and IP spoofing"
>> # Automatically discovers the MITRE father category, and returns a full representation of the technique cube in the matrix

BEFORE
+--------+----------------------+----------------------+----------------------+----------------------+----------------------+
| ID     | LOCATION             | CATEGORY             | VULNERABILITY        | DESCRIPTION          | EVIDENCE             |
+--------+----------------------+----------------------+----------------------+----------------------+----------------------+
| KHV030 | Local to Pod (kube-  | Identity Theft       | Possible DNS Spoof   | A malicious pod      | kube-dns at:         |
|        | hunter-2krcf)        |                      |                      | running on the       | <IP_ADDRESS>           |
|        |                      |                      |                      | cluster could        |                      |
|        |                      |                      |                      | potentially run a    |                      |
|        |                      |                      |                      | DNS Spoof attack     |                      |
|        |                      |                      |                      |     and perform a    |                      |
|        |                      |                      |                      | MITM attack on       |                      |
|        |                      |                      |                      | applications running |                      |
|        |                      |                      |                      | in the cluster.      |                      |
+--------+----------------------+----------------------+----------------------+----------------------+----------------------+

AFTER
+--------+----------------------+----------------------+----------------------+----------------------+----------------------+
| ID     | LOCATION             | MITRE CATEGORY       | VULNERABILITY        | DESCRIPTION          | EVIDENCE             |
+--------+----------------------+----------------------+----------------------+----------------------+----------------------+
| KHV030 | Local to Pod (kube-  | Lateral Movement //  | Possible DNS Spoof   | A malicious pod      | kube-dns at:         |
|        | hunter-2krcf)        | CoreDNS poisoning    |                      | running on the       | <IP_ADDRESS>           |
|        |                      |                      |                      | cluster could        |                      |
|        |                      |                      |                      | potentially run a    |                      |
|        |                      |                      |                      | DNS Spoof attack     |                      |
|        |                      |                      |                      |     and perform a    |                      |
|        |                      |                      |                      | MITM attack on       |                      |
|        |                      |                      |                      | applications running |                      |
|        |                      |                      |                      | in the cluster.      |                      |
+--------+----------------------+----------------------+----------------------+----------------------+----------------------+

Contribution checklist

[x] I have read the Contributing Guidelines.
[ ] The commits refer to an active issue in the repository.
[x] I have added automated testing to cover this case.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[OAuth2Manager] Remove APIs for Implicit grant type

Removing APIs added for Implicit grant type suggested by security review.
Implicit grant type is not the recommended way to perform OAuth2.0. Authorization code grant type should be used.
A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.

/azp run

/azp run

/azp run

@dotMorten, FYI, This PR removes implicit request as mentioned in the  https://github.com/microsoft/WindowsAppSDK/issues/4904#issuecomment-2551194245
cc: @akanpatel2206

/azp run

/azp run


Hanging OPTIONS request in Safari

When using Safari 10 on OS X (not the newest version, I can get more details tomorrow), the OPTIONS request may/will get stuck (hang, load forever), when the return state is not 204, but 200.
See this question on Stackoverflow: https://stackoverflow.com/questions/40339485/cors-options-request-successful-but-hangs-in-safari
This bundle returns 200 OK for the preflight, as tested here: https://github.com/nelmio/NelmioCorsBundle/blob/master/Tests/CorsListenerTest.php#L72
We actually ran into an issue with this. I don't see a possibility to change the response status within configuration (or by not actually using an event listener to override an event listener).
RFC 7231 (https://tools.ietf.org/html/rfc7231#section-4.3.7) states that the response might contain data, but when not is required to have Content-Length: 0 header. As far as I know, Symfony will set the appropriate content length header when there is no body.
In my opinion, the preflight may answer 204, which is a valid response given the fact that is does only contain header, but no actual content.

I'm assuming this problem was fixed on the client so closing here. I'd rather not change from 200 to 204 as this may in itself cause other problems with shitty clients or break someone's expectation.


Added task name logging to user agent

Log the taskname into the user agent
Todo

[ ] Testing

/azp run


the hello-world example in the readme/curl-output is missing "render"

first user experience,
curl https://raw.githubusercontent.com/tidbyt/pixlet/main/examples/hello_world.star |   pixlet serve /dev/stdin
... is missing load("render.star", "render")
, causing an  error.

When I run the hello world command as instructed (also my first experience!) I get error loading applet: failed to load applet: /dev/stdin didn't export a main() function
This in the zsh shell. If I try bash I get curl: (23) Failed writing body
😞


S5 should be qualified or defined

          `S5` should be qualified or defined or something.

Originally posted by @steven-bellock in https://github.com/chipsalliance/Caliptra/pull/98#discussion_r1328101079

According to https://caliptraworkspace.slack.com/archives/C04R3H7GP9D/p1695053094043259?thread_ts=1695045411.363919&cid=C04R3H7GP9D it should be qualified with ACPI.

updated https://github.com/chipsalliance/Caliptra/pull/98/commits/5ccee2d015c72497f2123db731fee51ae8aa2c63


colorls dependency

Hello,
I've shamelessly ripped off jarvis and have been modifiying a bit for myself and one thing I've noticed that there is a dependency on colorls that doesn't appear in the installation scripts. The result is you can't use ls after setup until you install colorls.
I'm happy to send in a PR to do gem install colorls :)

Ah good catch! I recently "deprecated" the install script in a sense because it's painful to maintain it very rarely gets used. But I'm happy to update the docs to include the colorls installation command as a manual step. If you want to do a PR, that would be great! If not, I'll add it sometime this week. Thanks again!


Drawer jumps to top of screen after pulling down when drawer is in downDisplay position

Hi, thanks for the great work on this. The component does exactly what I was after. One thing I have noticed is that if the drawer is in the downDisplay position, and you pull down on it, it jumps to the top of the screen. When you then try and pull down again, the app crashes:

Did you manage to fix it?