Add Dark Mode button and change the 'Me' page accordingly

Users frequently find themselves in situations where they are using the app in very bright sunlight, or at night. Please add a Dark Mode button, and change the 'Me' page accordingly.
This is the screen when the user clicks their avatar on the home screen.
The screen should look like this - https://mongodb.invisionapp.com/share/PCYZ6ZW7FR8#/screens/433591779_Me
Dark mode is off by default, and has the light background; when Dark mode is toggled on, the dark theme should be applied.
Color key for light mode: https://mongodb.invisionapp.com/share/PCYZ6ZW7FR8#/screens/433591768_Color_Key_-Light_Mode
Color key for dark mode: https://mongodb.invisionapp.com/share/PCYZ6ZW7FR8#/screens/433591769_Color_Key-Dark_Mode
Component Color specs for light mode: https://mongodb.invisionapp.com/share/PCYZ6ZW7FR8#/screens/433591770_Component_Colors-Light_Mode
Component Color specs for dark mode: https://mongodb.invisionapp.com/share/PCYZ6ZW7FR8#/screens/433591771_Component_Colors-_Dark_Mode
Both dark and light modes should follow the color key and specs above (it is possible that the current light mode is not).
This profile setting should be stored on the device, not in the database.
Dark mode should work either when the switch is toggled on, or when the switch is off but the device itself is in dark mode.
Please make sure to TEST your build on a device or emulator to verify everything has changed - you can get a login and realm-app-id with easy instructions at https://wildaid.github.io/contribute/sandbox.html

I'd like to take this.

Hi @bladebunny - thanks for offering to work on this! I have assigned it to you.
Our product, engineering and design team have further discussed it and decided that the dark mode toggle should always override the OS state. When the toggle is off, the app is in light mode. When the toggle is on, the app is in dark mode.
(so, if the OS is in dark mode, and the app has the dark mode toggle off, the app is in light mode).

Also, I'm assuming that this should also update other views?  I'll add the colors if they aren't there already.  This change will have a pretty broad impact across views.  Will probably have to do it in chunks so as not to have a massive PR.  We can set the dark mode state in userdefaults -- and I'll add a settings wrapper - and the probably expose an Observable(s) for various settings changes that views/viewmodels want to subscribe to. Ordinarily this is something you could do once in a base UIViewController but I'll have to look into the best way to do this is SwiftUI so as to minimize the surface area of views needing to know about this.  Trying to avoid the amount of boilerplate/bookkeeping views need to do to add a new view.  May be unavoidable though. Just some thoughts...

Will probably make sense for me to create a series of PRs (colors, userdefults wrapper, view upadates, etc..) for the incremental work. If we can do that without closing the main issue.

If you want to make a series of PRs for the incremental work, that's totally OK, and I can make sure that it won't close the issue (or if it does close, I'll reopen it 👍).
 Just the ones for the "Me" page. In this way we can spread out the work of the dark mode project to multiple engineers, and it doesn't all fall on one person.

Just and FYI - for some reason I was not able to pick up the conflict in my last PR.  Re-added PR that is current and includes only Dark Mode work.  Suitable for closing once it passes review.


Document new dependencies on openssl & curl dev

This resolves #41 and #43.

Closed with bb585c11. I made minor edits to this PR to remove reference to the install location. The install path is set @ configure time (see --prefix)


Loot Tracker Filtering

The expanded view of the Loot Tracker has limited use because you can really only scroll so far. It becomes especially bad when you want to see a monsters loot in order when you killed other monsters in between.
I would like a function where, for example, I can type "Elite Clue" and only that item in the expanded view so I can see when the last time I received a master clue.

Duplicate of #10704


Added the 'spo page get' command solving #360

Added the 'spo page get' command solving #360

Coverage remained the same at 100.0% when pulling cb8d1c6e8aa9e499fdbe1792bd3ec66a03ea74ec on waldekmastykarz:spo-page-get into b367f207d74eebb1fdf974ff6c2b52e7d1a4343e on SharePoint:dev.

Merged manually


Elem

Challenge Waypoint: Use a CSS Class to Style an Element has an issue.
User Agent is: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.80 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
 Have attached the screenshot for details.

Is this a misclick? What is the problem here?

Attaching screenshot,hang on...

But there is a work around with ctrl+enter key press.

Hmm. Both the click and shortcut work for me. Can you try this other Waypoints?

Sure,i shall and try and get back in a while.

Nope,the issue persists.

Weird. Both are working for me.

You're Logged Out, See the SignIn button above

In that scenario,ctrl+enter should also be not working i suppose.

Oh..didn't notice that. but the Ctrl+Enter shouldnt work then.

Well, as pointed out by marhyorh,It did solve the problem, am able to click now,but then ctrl+enter should also not work.

Yeah, it will

Confirmed Issue.
Issue Reproduction:

Log out of the site
complete a waypoint and click "run tests"
Clicking the "Go to my next challenge" button does not work.
Doing ctrl+enter does work.

@BerkeleyTrue can you take a look at this one?

@SaintPeter There is already a PR. Waiting for @ltegman to make updates.


ETH RpcResponseException causes crash

See https://gitlab.com/nblockchain/geewallet/-/issues/150

Closed in gitlab.


Empty environment variables e.g. UV_FROZEN='' is treated as an error, not unset

Can you share why you'd expect an empty environment variable to be treated as unset? Why not just unset the variable properly?

(We have updated some variables to treat an empty value as unset, but I'd like to understand the use-case better)

TIL: if you hit enter while writing an issue title, it creates an empty issue.
I've now added more details.

(We have updated some variables to treat an empty value as unset, but I'd like to understand the use-case better)

https://github.com/pydantic/pydantic/pull/10815 - I want to unset UV_FROZEN in the test-plugin job, to avoid the errors.


Redwood JS IDE extension plugin conflict

I believe this may be an extension load order issue as presented in VS Code's repository feature request here:
Feature: Specifying the load order of extensions (reduce startup wait-time) #46846
It shows up in an issue that was incorrectly brought up in the Redwood repository issue tracking here:
VS Code Extension wont load in remote - ssh mode. #1478
It sure seems like this is likely an extension load order issue that shows itself in WSL. If nothing else it sure seems like a feature that would be helpful for all VS Code extension builders to aid in debugging.

Hi @BstevensG4G We are in between major changes and updates to the Extension. The current codebase is effectively going to be replaced, which is a great thing overall. It's still just a couple of months out.
We're paying attention to open Issues and will update accordingly. Thanks for your patience!


How to get public key After generating a wallet?

Hi, @amirhossein7. If you saved your data in KeystoreManager, try this
let privateKey = try! keystoreManager.UNSAFE_getPrivateKeyData(password: password, account: ethereumAddress)
let publicKey = Web3.Utils.privateToPublic(privateKey, compressed: false)!

thanks @BaldyAsh


Chef - Add unit tests for stateful_shell.py

Problem
There are no unit tests for stateful_shell.py
Change overview
Add unit tests for stateful_shell.py
Testing
python -m unittest

@cpagravel I believe unit tests failures are real:
...
FileNotFoundError: [Errno 2] No such file or directory: '/__w/connectedhomeip/connectedhomeip/examples/chef/.shell_output'
...

Traceback (most recent call last):
630
  File "/__w/connectedhomeip/connectedhomeip/out/../examples/chef/test_stateful_shell.py", line 33, in test_set_env_outside_shell
631
    self.assertEqual(resp, "1234")
632
AssertionError: 'test123' != '1234'
633
- test123
634
+ 1234

The output file path is somewhat suspicious - should shell create its own temporary folder for temporary files?

Those unit test failures are still happening, and breaking CI randomly on various PRs.  See https://github.com/project-chip/connectedhomeip/issues/19408


Question about Tensor operation.

In, Tensor::argmax and Tensor::normalization minimum possible value is set to 0.0;
Could someone confirm this is args cannot be negative?

:octocat: cibot: Thank you for posting issue #141. The person in charge will reply soon.

I think this is a bug as a tensor can be comprised of all negative values.

Yes. I agreed. need  to fix.


Two bugs in Linear Complexity Test

Hi,
I looked into your code as a way to write something similar.
First, thank you for sharing – your code helped me more than the official test suite.
Second, in the “Liner complexity” test, IMHO, there are two mistakes in your code:

t = c[:] does not create a copy in numpy, use t = c.copy()
int(max(-2.5, ticket) + 2.5) is not what you need. It should be int(max(-3.5, ticket) + 3.5)

Please check it out if you'd like.
Uri

I will look into it in the near future! Thanks!


Make a blurb around my philosophy to the todo list

Don’t put a date on it unless it needs to be done that day
Don’t put a time on it unless it’s an appointment you need to keep (like a workout or a meeting)


Helm chart for CodeGen on Xeon

Two services in total, the codegen service is depending on tgi. Current tgi supports CPU only, will add Gaudi support later. You'll need a HuggingFace token in values.yaml
hf_token: "yourowntokenfromhuggingface"
Use "helm install codegen codegen" to deploy.
Type of Change
feature
Description
Add CodeGen helm charts for Xeon
How has this PR been tested?

Modify the values.yaml hf_token with your huggingface API token
helm install codegen codegen
curl http://test-codegen/v1/code_generation -X POST -H "Content-Type: application/json" -d '{"prompt": "def print_hello_world():", "max_new_tokens": 128, "stream": true}'

Thank you for your PR. I tested as your describe, but I got error. I think /home/ubuntu/models should be configurable via value.yaml.
$ kubectl get pods
NAME                                                        READY   STATUS              RESTARTS     AGE
codegen-789f4f44bb-d2xj5                                    1/1     Running             0            2m13s
codegen-tgi-5b6cb66c4f-hwnhg                                0/1     ContainerCreating   0            2m13s

$ kubectl describe pod codegen-tgi-5b6cb66c4f-hwnhg
Name:             codegen-tgi-5b6cb66c4f-hwnhg
Namespace:        default
Priority:         0
Service Account:  default
Node:             b4969184c7f8.jf.intel.com/<IP_ADDRESS>
Start Time:       Wed, 15 May 2024 02:29:13 -0700
Labels:           app.kubernetes.io/instance=codegen
                  app.kubernetes.io/name=tgi
                  pod-template-hash=5b6cb66c4f
Annotations:      <none>
Status:           Pending
IP:
IPs:              <none>
Controlled By:    ReplicaSet/codegen-tgi-5b6cb66c4f
Containers:
  tgi:
    Container ID:
    Image:          ghcr.io/huggingface/text-generation-inference:1.4
    Image ID:
    Port:           80/TCP
    Host Port:      0/TCP
    State:          Waiting
      Reason:       ContainerCreating
    Ready:          False
    Restart Count:  0
    Environment:
      MODEL_ID:  m-a-p/OpenCodeInterpreter-DS-6.7B
      PORT:      80
    Mounts:
      /data from model-volume (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-hqb45 (ro)
Conditions:
  Type              Status
  Initialized       True
  Ready             False
  ContainersReady   False
  PodScheduled      True
Volumes:
  model-volume:
    Type:          HostPath (bare host directory volume)
    Path:          /home/ubuntu/models
    HostPathType:  Directory
  kube-api-access-hqb45:
    Type:                    Projected (a volume that contains injected data from multiple sources)
    TokenExpirationSeconds:  3607
    ConfigMapName:           kube-root-ca.crt
    ConfigMapOptional:       <nil>
    DownwardAPI:             true
QoS Class:                   BestEffort
Node-Selectors:              <none>
Tolerations:                 node.kubernetes.io/not-ready:NoExecute op=Exists for 300s
                             node.kubernetes.io/unreachable:NoExecute op=Exists for 300s
Events:
  Type     Reason       Age                  From               Message
  ----     ------       ----                 ----               -------
  Normal   Scheduled    2m19s                default-scheduler  Successfully assigned default/codegen-tgi-5b6cb66c4f-hwnhg to b4969184c7f8.jf.intel.com
  Warning  FailedMount  12s (x9 over 2m19s)  kubelet            MountVolume.SetUp failed for volume "model-volume" : hostPath type check failed: /home/ubuntu/models is not a directory

Thanks for the test, the failure is due to an non-exists directory on the testing host. The directory is supposed to put predownloaded/cached models.
I will add a readme file to put the config values there.

I've already tested the helm chart, apart from the questions raised by Daisy, all things run smoothly. There is one suggestion,  I think we should mention in the README that it may take several minutes for the tgi to download and warm up the model. Before sending the request via cURL, the user should first verify that the TGI service is ready.

Another suggestion is, maybe we can put tgi* services' charts to a separate place, like /helm-charts/GenAIComps/foo-bar

We'll do this after we have the official helm chart repo. If without repo, the helm dependency check will fail because there is no place to download.

Another suggestion is, maybe we can put tgi* services' charts to a separate place, like /helm-charts/GenAIComps/foo-bar

Added startupProbe and readinessProbe to handle this slow start issue. In the README.md, also mentioned that if there is no local cache, it will need time to download models.

I've already tested the helm chart, apart from the questions raised by Daisy, all things run smoothly. There is one suggestion, I think we should mention in the README that it may take several minutes for the tgi to download and warm up the model. Before sending the request via cURL, the user should first verify that the TGI service is ready.


Dev issue 541 slice bar

Also, please update the README to describe how to use the two new menu items for slice bar and viewing strand details.

The backbone angles should only be displayed in the side view when the slice bar is on. It's odd to display them otherwise, the slice bar is invisible, and it's not clear which offset the angles are referring to:

Also, please update the README to describe how to use the two new menu items for slice bar and viewing strand details.

Fixed in https://github.com/UC-Davis-molecular-computing/scadnano/pull/564/commits/4b9b4901da0ae31b70bb30c1a41cde6616014aa6.
Also removed backbone edit mode details from the README and mostly reused it for details on the slice bar


Beosound shape support?

This integration supports most B&O modern speakers, but I cannot find Beosund shape. Is it possible to extend the integration to also include that?

This integration supports all B&O devices that are on the Mozart platform. There are currently no plans to support other platforms.


Broken login for PPMI

@mohanadarafe reported that

there has been an update to the PPMI website which impacts the downloader
At start-up, once we accept the agreement, it refreshes the page which means the Login button does not work

Opening this issue to keep track of it.

Hi @mathdugre, yes, great idea.
I think @mohanadarafe fixed the login issue for now, do you confirm Mo?

Hi @mathdugre, yes, great idea.
I think @mohanadarafe fixed the login issue for now, do you confirm Mo?

Hi all,
I added a temporary fix to timeout the scrapper for 3 seconds which worked (I just checked again).

#30 should fix that.


Add checksums for files on GitHub

There should be checksums for every file in the Releases section on GitHub so users can verify the files they download as in the motton on the main page of Electron Cash:

Please, please, PLEASE... take the time to verify
the authenticity of these files before running them.
This protects you from hackers and malware!

I know there are signatures and checksums for files from the Download page of the website but the packages on the website and on GitHub differ as you can see in this issue: #579.
As suggested by yura-pakhuchiy (in the mentioned issue), it would be most convenient if checksums/sigs were available in the Releases page on GitHub rather than somewhere in the repository.

I think @yura-pakhuchiy was referring to https://electroncash.org, but it still applies to the releases page.


Premake: replaced buildoptions -std=c++11 with flags C++11

On Linux at least, usage of C++11 is not recognized when premake just uses buildoptions "", causing errors during make such as:
../../Box2D/Collision/Shapes/b2ChainShape.h:99:15: error: ‘nullptr’ was not declared in this scope
  m_vertices = nullptr;

The issue may be related to https://github.com/premake/premake-core/issues/770 for which the solution is to use cppdialect, only available starting premake 5 alpha 12 (currently WIP). For now, I suggest this fix, although redundant and not as elegant as filters.
I also mention the fix on Stack Overflow.

With alpha12 of premake, I got this:

** Warning: the flags value C++11 has been deprecated and will be removed.
Use cppdialect "C++11" instead
@/.../Box2D-repo/Box2D/premake5.lua(25)

Therefore, I will close this PR and make a new one for alpha12 using cppdialect (I could juste update the PR, but since I made the PR directly on master it may interfere with other changes I make on master, so I prefer using a dedicated branch).

OK, I realized a bug on premake5-alpha12 makes cppdialect fails on OSX (it writes std=C++11 instead of std=c++11). I will send them a PR, but until then, the flags solution works, even though deprecated. I reopen this PR so that, at least, we have a solution to nullptr and other bugs in the meantime.

PR to fix cppdialect on OSX on the way: https://github.com/premake/premake-core/pull/897

PR accepted. Will send another PR with cppdialect.


Custom inner mouth overlay doesn't save on female recipe

Replacing the default inner mouth overlay for a custom generated female recipe doesn't save.
New Inner mouth overlay is added to a female recipe and previous is removed (not during run time).
On loading the recipe during run-time  it switches back to the default inner mouth overlay.

This is actually by design. It pulls the overlay by name from the OverlayLibrary, so if you have multiple of the same name, it will find the old one first. To get past the error, you should remove the old one from the library, or give the new one a new name.


Fix doc directory during release-note copy.

The doc directory is just X.Y, not X.Y.Z.
Signed-off-by: Flynn<EMAIL_ADDRESS>

Merging to test this fix.


Implement Wallet-Based Authentication with Stellar Wallet Kit

Fixes #17
i) Integrated Stellar Wallet Kit for wallet connection
ii) Updated walletStore with wallet-based registration and login methods
iii) Simplified signup component with immediate dashboard redirect after wallet connection

Hello @ElliotFriend GM ser pls can you review my PR

Hello @ElliotFriend I made the changes according to changes requested during review and I added some other comments for easier understanding

@ElliotFriend I have added the new changes according to the previous review


GPII-2380: Update to "root safe dedupe" version of infusion...

See GPII-2380 for details.
As part of verifying this, I will convert this package to run tests in Windows using the Vagrant QI plugin.

This
now includes later work to remove express-handlebars.  See GPII-2153 for details.


Support for non-OpenAI models

Please consider this an umbrella issue (assuming you don't have one yet) for adding the flexibility to choose the model of the users choice.
This project is very interesting and encapsulates the hopes of GenAI for developers and non-developers alike.
But, much like many technological advances, folks are choosing what's right for their needs/desires. The answer is not always OpenAI.
I am most interested in native support for Anthropic and Ollama.

This looks encouraging (tool use is now in public beta) https://docs.anthropic.com/claude/docs/tool-use

Take a look at the documentation here: https://docs.gptscript.ai/alternative-model-providers
That documentation should help you use Ollama or Claude 3, but please note that many models are not as good at function calling as gpt-4-turbo, so you may run into issues.

Also, there is a branch of the anthropic-provider that uses the beta tool use stuff - https://github.com/gptscript-ai/anthropic-provider/tree/tool-beta

The tool use stuff for anthropic is not beta anymore, and has been merged into main. I'm going to close this issue now, since we do have support for the original ask (the ability to use with other models/providers aside from openai).

What is the official story for Amazon Bedrock support?  Bedrock has a new Converse API that supports function calling (tools) across models.  I see this one https://github.com/gptscript-ai/claude3-bedrock-provider any idea if it uses Converse's tools?


Multiple dialogs on same page with  role="alertdialog" breaks dialogs

When multiple dialogs are placed on the same page, and at least one of them has the  role="alertdialog" attribute, pressing the escape key causes one or both of the dialogs to not open properly.

Hello. Would you mind providing a reproducible example please? :)

If you modify the example file to this state, the issue is reproducible.

Which state?

I tried pushing up a branch with the modified example file to demonstrate, but I don't have permission to push a branch here. Here is the code I am testing with:
`<!doctype html>

A11y Dialog

A11y Dialog

Get the code on GitHub — <button class="link-like" data-a11y-dialog-show="my-accessible-dialog">Open the dialog window</button>

This page demonstrates how to make a dialog window as accessible as possible to assistive technology users. Dialog windows are especially problematic for screen reader users. Often times the user is able to “escape” the window and interact with other parts of the page when they should not be able to. This is partially due to the way screen reader software interacts with the browser.

To see this in action, you just need to <button class="link-like" data-a11y-dialog-show="my-accessible-dialog">open the dialog window</button>. Once it’s open, you should not be able to interact with other links on the main page like going to the main GitHub page. The focus is said to be “trapped” inside the dialog until the user explicitely decides to leave it.

On top of that, this implementation provides all the usual mandatory bits from a dialog window: correct usage or ARIA landmarks, absolute freedom in regard to the styling, closing when pressing ESC, closing when clicking the background overlay, closing when clicking the close button, a simple yet powerful DOM API, for 1.4Kb of JavaScript. Oh, and also it is fully tested using a headless browser to make sure it works as intended.

No more excuse now. Make your dialog windows accessible.

  <button class="link-like" data-a11y-dialog-show="my-accessible-dialogz">Open the second dialog window</button>.

    <dialog class="dialog-content" aria-labelledby="dialogTitle" aria-describedby="dialogDescription" role="alertdialog">
      <button data-a11y-dialog-hide class="dialog-close" aria-label="Close this dialog window">×</button>

Second modal

This is the second modal.

    </dialog>

    © 2016 Edenspiekermann

  <dialog class="dialog-content" aria-labelledby="dialogTitle" aria-describedby="dialogDescription">
    <button data-a11y-dialog-hide class="dialog-close" aria-label="Close this dialog window">×</button>

Subscribe to ESPI Newsletter

Fill in the ridiculously small form below to receive our ridiculously cool newsletter!

    <form action="http://edenspiekermann.us10.list-manage.com/subscribe/post?u=927d6a7cf437da88aac7a87ec&id=6823ab7bb8" method="post" target="_blank">
      Email (required)
      <input type="email" name="EMAIL" id="email"<EMAIL_ADDRESS>required>
      <button type="submit" name="button">Sign up</button>
    </form>
  </dialog>

`
If you open this code in a browser and then click on the new dialog link at the bottom, then use the escape key to close, the modal link for the second dialog won't reopen the dialog. I'm testing in Chrome.

Thank you! I will try to have a look soon. :)

Hello - just wanted to follow up on this as we're seeing this issue as well. Curious if you've been able to troubleshoot this @HugoGiraudel ? Thanks!

Thank you for the reproducible example, I can confirm that is an issue. I will be investigating. :)

Alright, so from my quick experiments:

It doesn’t seem to be about having multiple dialogs; it also happens with a single dialog.
It only seems to occur when using a native <dialog>  with role="alertdialog", because the browser still accepts ESC despite this role.

Quick workaround: use
 instead of <dialog> to let the script polyfill the behaviour properly. documentation on


Feature #190: Sidebar improvements

Closes #190
Description

Updates the sidebar to look like the designs

Looks like this now:

Travis automatic deployment:
https://pr347--safereact.review.gnosisdev.com

There seems to be a bug where Safelist entries get removed from the sidebar.
Steps to reproduce:

Create a Safe
Create a second safe
Open Sidebar and switch to first Safe
Refresh page
-> Only 1 Safe is now listed in the sidebar

That bug seems to be no-related with this pr, I tested it in another PR and seems to happen again, will open an issue for that

Travis automatic deployment:
https://pr347--safereact.review.gnosisdev.com


Support multi-insert

This patch adds support for statements like INSERT INTO table(a,b,c) VALUES (?,?,?), (?,?,?)

That is unnecessary

@jakesyl Hi, see an example https://github.com/ClickHouse/clickhouse-go/blob/master/examples/simple.go#L38

@kshvakov Appreciate the help. Is this faster than columnar?

No, but it’s more convenient

I created this benchmark for Altinity


⚠ Bofrost.be has degraded performance

In ea05efa, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1367 ms

Resolved: Bofrost.be performance has improved in 5c3346a.


[Bug] Minor - Home page/ UI-UX - visual discrepancy

Describe the bug
Home page - UX/UI discrepancy-   Headers - "Мисия", "Визия" и "Цели"
To Reproduce
Steps to reproduce the behavior:

Go to podkrepi.bg
Scroll down to Headers - "Мисия", "Визия" и "Цели"
Menu "Цели' - there are dashes in the text, while the text in other "Мисия" and "Визия" do not have dashes

Expected behavior
Equal UI text
Screenshots

Desktop (please complete the following information):

OS: Windows
Browser - Chrome
Version

Hello, @Polina1985!
The design of Homepage is going to be fully changed soon and this issue is not going to be present. Here is the new design: https://www.figma.com/file/MmvFKzUv6yE5U2wrOpWtwS/Podkrepi.bg?node-id=3904%3A13406
I suggest we don't spend time on it since this whole section will look different after implementing the new changes. Could you confirm this?


[BUG] Auth proxies does not work in proxy checker.

Describe the bug
When using proxies with Auth ( i.e. <IP_ADDRESS>:80:username:password ) in the proxy checker, all go to Not Working while the same proxies work in Runner.
Expected behavior
Expect Auth proxies to also work in proxy checker so they could be checked before using.
Version

Version 1.1.5#379

https://github.com/openbullet/openbullet/commit/107fbb1ce54f827c290159353c7e74fc61395e02
Please reopen if it doesn't work

Thanx, it works.


Reduce connect Docker image size to ~60 MB

Used to be around 300 MB

nice!

Dr. @vsimonian's Docker diet plan. It works. I lost Megabytes.


Update JGit to version 5.0 in Gradle 5.0

We're using 4.5 (the last version to support Java 7), but 5.0 is out now (need to verify what the minimum version supported is, but I think it's Java 8).

Didn't we want to ditch JGit and use the command line client due to dependency problems some time ago? Is that still something we want to do?

Marc is updating this in https://github.com/gradle/gradle/pull/6728, so we may get this for free.
@wolfs I think we're still better off sticking with JGit for now until we get real users/feedback.


qca-swiss-army-knife: fix ath11k/board-2.json generation

ath11k tools have slighly changed the format of the board-2.json by adding a nested board / regdb arrays. Fix the script that generates board-2.json to accomodate for those changes.

@adhudase fixes the issue from #619


Nodebots Hardware Shopping List

We need to get some kit for nodebots (#103).  Add comments, and we'll keep this list updated appropriately.
Espruino × 10

[ ] chassis - £10 (£100)
[ ] sensors, breadboards, etc - £13 (£130)

Arduino × 6

[x] arduino & sensor kits (at WO) - £0 (£0)
[ ] sumobot chassis?
[ ] servos?

Hi @benfoxall,
We want 15 Espruino kits, as we have access to 15 Espruinos from Gordon.
The chassis sets are the same for arduino/espruino, so the costs will be the same either way. The list doesn't need to be split by the board, it just needs to be 15 chassis and enough breadboards to make it all up.
We do want enough kits that each group can do the same thing - that way we can have a rough plan for the day for everyone to follow. Anyone wanting to hack on their own thing is more than welcome, but it's nice to have some structure for those who don't know what to start on (as was the case with everyone last year).

@spikeheap - Man, this is still confusing.  Seems a bit like we're going round in circles; I thought we's said yesterday that 3 per team would work, and about an hour ago you said the chassis were different.  Good that we've got this issue.
So, just to clarify:

Are we building sumobots?
It's £13 per sumobot for sensors etc?
Do we need an additional breadboard for each sumobot?
We've got access to 15 Espruinos from Gordon?

Hi @benfoxall, no the chassis are compatible with both, they just aren't the ones I'd specced and priced up. We could force people into groups of 3, which would probably work fine, but last year there were quite a few people working in pairs and a couple working individually. Finding sponsorship for £345 isn't much different to finding sponsorship for £230, so why would we not aim to provide enough for everyone to work roughly in pairs if they want to?

Sumobots look awesome, but they only really work if many teams complete them. My worry was that people can get left behind and it's a bit demoralising if you realise you're not going to make it in time. Also, sumobots is a competition, which can be intimidating for some first-time people to attend, so I was keen to not make it competitive (and sumobots might suck if it's not a comp unless we've got some creative ideas?).
The £13 was a rough guesstimate of sensors and bits, and it's probably a reasonable amount to put towards car/sumobot/whatever, though we can cut bits out of here if we're really struggling.
A breadboard per bot/team is a good starting point. Gordon was talking about knocking up a PCB which would mean we didn't need the breadboard for the espruinos, but we need to make sure we can source the car kits before going down that route. It might also be possible to knock up a PCB which acted as a chassis too, though we'd still need to buy the motors and it would need some up-front time spent soldering it all together (it's a shame we don't have a load of soldering irons).
Yes :)

@spikeheap I'd be up for some pre-event soldering if needed. (I've got 2 soldering irons)

@AverageMarcus me too :+1: :+1:. Soldering could be good fun for people on the day so we could get attendees to do it, but I wonder if there's already enough going on to make just plugging things together than programming them enough. I'm up for some pre-event soldering too, maybe we could spread the word on meetup/twitter for a smallish gathering to knock them all.

@spikeheap Sounds like the prefect excuse for another BBQ to me.

I'm now free to come to this again, happy to bring another soldering iron along.

This event happened. It was awesome. Thanks everyone!


feat: add provider_id JWT claim containing the originating provider of the session

JWTs issued by GoTrue will now contain a provider_id claim containing the ID of the provider that originated the session. Example IDs:

google for sessions issued via Sign in with Google
apple for sessions issued via Sign in with Apple
email for sessions issued based off of email (OTP, password, magic link)
phone for sessions issued based off of phone (SMS or password)
sso:4b7fd660-afa8-4035-84a3-865ed89470e9 for sessions issued off an SSO provider, the UUID being the sso_providers.id column

I feel like this might be confused with the provider_id claim used here which refers to the user's provider ID

Closing in favor of #837.


terminal vim-mode

hi thanks for the plugin, but I notice if I put this code I can scroll around my terminal neovim
tnoremap <expr> <Esc> (&filetype == "fzf") ? "<Esc>" : "<c-\><c-n>"
however if I remove it I can use my terminal vim-mode like https://github.com/softmoth/zsh-vim-mode,
but I also want that ability to scroll my terminal around,
I am think for using double Esc to do the above code.
I almost got it right with this code but some weird that I don't understand,
it shows execute:_ after the line
tnoremap <silent><Esc> <Esc>:<c-\><c-n>
I wish you could help, thankyou

Hi, this map is for exiting terminal mode in neovim. I believe that's why you are experiencing those things:

with the mapping, you exit terminal-mode and scroll the buffer like any other buffer
without the mapping you are scrolling the terminal like any other terminal outside vim

you can have both. I suggest to read the manual on termial-mode in neovim to know how it works
the mapping I suggested was to use this ability together with fzf, but if you just want the normal mapping, it would be something like:
tnoremap <Esc> <C-\><C-n>


Recover password - check if email is registered

Check if email is registered before sending email to recover password.

Will do it.


Go 1.8 or higher is needed to install, but README says 1.7.3 is ok

It'd be great if the project could be built with 1.7, as reported in the README, but instead upon running make install an error is raised saying you need Go 1.8+
Either fix the README or (better) the Makefile ?

You probably misread. The README says you need git 1.7.3 or newer and Go 1.8+.

Evidently misread, sorry for the noise.
It would be great if I could build the project it on a popular system
like Ubuntu 17.04 (or older), but this ticket is clearly invalid.

Well, installing a more recent version of Go is really simple (just unpack an archive, update your PATH, and you're good to go).

installing what the distribution gives you is simpler:
apt-get install golang-go

what you are saying requires

Find the download url
Decide where to unpack
Decide how to make your PATH changes stick

Lots of stress, for what benefit ? What is it that
a web API client needs that cannot be done in Go 1.6 ?

Lots of stress, for what benefit ? What is it that
a web API client needs that cannot be done in Go 1.6 ?

See commit 71fa8dad8faef67599a744df969375ada9694e2c for details.

Thanks @patheticpat. It's true that this project needs at least Go 1.8.


Replace monkey patching with dynamic class generation

The current behavior of pycromanager is that it represents java objects with the JavaObjectShadow class and then monkey patches each instance of JavaObjectShadow to match the signature of the java class.
The PR makes it so that rather than monkey patching, we generate a subclass of JavaObjectShadow which is named based on the original java class name, e.g.
>>>type(bridge.get_studio())
        pycromanager.core.org_micromanager_internal_MMStudio.

This will fix some confusing behavior, for example right now this statement: type(bridge.get_studio()) is type(bridge.get_core) will evaluate as True since they are both just instances of JavaObjectShadow. With this PR python will be able to recognize that CMMCore and MMStudio are distinct types.
A further benefit is that rather than parsing the java API of an class each time a new JavaShadowObject is created in Python, we only need to generate each shadow class once. This is handled by a new JavaObjectFactory class. This opens the door for an enhancement I propose where java API is only transmitted once for each class as part of a separate message than the serialized_object messages, in some cases this could greatly reduce socket traffic.

Great idea! Should JavaObjectFactory be _JavaObjectFactory since it is internal?

Good point, it's been renamed

The two lines above are marked as errors in in PyCharm when using python 3.6. However, after downloading 3.7 (but still using 3.6) the errors go away. It appears that __annotations__ was added to future in 3.7, which might explain this. Maybe it would be good to remove the annotations there since they aren't essential (I think)?

Should be OK for python 3.6 now. Do you have an idea of which versions you want to make sure this is compatible with?

Maybe >= 3.6? What do you think?

That seems reasonable.
I don't think that the regression to using exec is going to play nicely with this PR. I'll switch to 3.6 and see if I can solve the TaggedImage.pix issue.

Good to go


chore: Update issue template

With the introduction of docusaurus info I guess its the right time to make use of it via issue templates.

I appreciate the PR but as said in contributing guideline, please talk to us first before sending PR like this. For things like bug fix or documentation typo, straight PR is preferable.
I feel that things like issue template is better discussed first as feedback and its better to be done by the core team because we’ll be the one most likely triaging the issue.
Also, V1 doesnt have docusaurus info, and v2 is still in alpha release + not announced publicly yet.


Adding Contributions

@all-contributors
please add @Boda1515 for contribution

@all-contributors
please add @Boda1515 for data


Fix Earned Achievements Check

This fixes #3294. Now checking earnedAchievementMap to determine if the achievement was previously earned.

This seems to work–nice!


react-native-chart-kit breaks a fresh expo app

Hey, if I install this library, expo crashes. As soon as I remove it, it works again.
Here is the error:

[13:05:34] \node_modules\babel-plugin-module-resolver\lib\index.js:88
[13:05:34]       })[1];
[13:05:34]         ^
[13:05:34]
[13:05:34] TypeError: Cannot read property '1' of undefined
[13:05:34]     at Plugin.manipulateOptions (\node_modules\babel-plugin-module-resolver\lib\index.js:88:9)
[13:05:34]     at normalizeOptions (\node_modules\@babel\core\lib\transformation\normalize-opts.js:59:16)
[13:05:34]     at runSync (\node_modules\@babel\core\lib\transformation\index.js:44:86)
[13:05:34]     at transformSync (\node_modules\@babel\core\lib\transform.js:43:38)
[13:05:34]     at Object.transform (\node_modules\@babel\core\lib\transform.js:22:38)
[13:05:34]     at compile (\node_modules\@babel\register\lib\node.js:73:20)
[13:05:34]     at compileHook (\node_modules\@babel\register\lib\node.js:102:12)
[13:05:34]     at Module._compile (\node_modules\pirates\lib\index.js:77:29)
[13:05:34]     at Module._extensions..js (internal/modules/cjs/loader.js:689:10)
[13:05:34]     at Object.newLoader [as .js] (\node_modules\pirates\lib\index.js:88:7)
[13:05:34] Metro Bundler process exited with code 1
[13:05:34] Error: Metro Bundler process exited with code 1
    at ChildProcess.<anonymous> (C:\xdl@51.6.0\src\Project.js:1496:14)
    at Generator.next (<anonymous>)
    at step (User\AppData\Local\Yarn\Data\global\node_modules\xdl\build\Project.js:2099:191)
    at User\AppData\Local\Yarn\Data\global\node_modules\xdl\build\Project.js:2099:437
    at new Promise (User\AppData\Local\Yarn\Data\global\node_modules\core-js\modules\es6.promise.js:177:7)
    at ChildProcess.<anonymous> (User\AppData\Local\Yarn\Data\global\node_modules\xdl\build\Project.js:2099:99)
    at ChildProcess.packagerProcess.once (C:\xdl@51.6.0\src\Project.js:1494:5)
    at Object.onceWrapper (events.js:275:13)
    at ChildProcess.emit (events.js:182:13)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:225:12)

I noticed that the installed library is not transpiled.

me too.

+1

same here.....

and here..

and me as well

+1 me too

After I put  as sample into render() function. I't make my app crash after 5-10 seconds ( visible ok as example).
I'm using expo 32.0.0 and<EMAIL_ADDRESS>

try to use react-native-pure-chart

Tried all chart npms out there and none worked apart from react-native-pure-chart

+1

@charloh Victory charts works nicely and works on web+native.

npm install react-native-svg solved the issue for me


'GepettoVisualizer' object has no attribute 'viewer'

I continue my journey in pinocchio world
I could run the examples as described in example page of this repo.
But the ones with viewer give this error message :
command line : python -i gepetto-viewer.py
display
/home/fenaux/Documents/robot/examples/gepetto-viewer.py:26: UserWarning: Error while starting the viewer client. Check whether gepetto-viewer is properly started
viz.initViewer()
Error while loading the viewer model. It seems you should start gepetto-viewer
'GepettoVisualizer' object has no attribute 'viewer'
Traceback (most recent call last):
File "/home/fenaux/Documents/robot/examples/gepetto-viewer.py", line 33, in  viz.loadViewerModel("pinocchio")
File "/home/fenaux/anaconda3/lib/python3.9/site-packages/pinocchio/visualize/gepetto_visualizer.py", line 137, in loadViewerModel
gui = self.viewer.gui
AttributeError: 'GepettoVisualizer' object has no attribute 'viewer'
I installed gepetto with conda : conda install gepetto-viewer-corba -c conda-forge as witten here https://github.com/stack-of-tasks/pinocchio/tree/devel/examples
If I run
gepetto-gui directly in a console I obtain the window interface but I do not know how to load a model with it
while window's opening, this message appears 4 times in the console : libpng warning: iCCP: known incorrect sRGB profile
Thanks for your help

Could you use meshcat solution instead?

I installed it with
pip install meshcat
And error message are longer :(
python -i meshcat-viewer.py leads to
Traceback (most recent call last):
File "/home/fenaux/anaconda3/lib/python3.9/runpy.py", line 188, in _run_module_as_main
mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
File "/home/fenaux/anaconda3/lib/python3.9/runpy.py", line 111, in _get_module_details
import(pkg_name)
File "/home/fenaux/anaconda3/lib/python3.9/site-packages/meshcat/init.py", line 5, in
from . import visualizer
File "/home/fenaux/anaconda3/lib/python3.9/site-packages/meshcat/visualizer.py", line 7, in
from IPython.display import HTML
File "/home/fenaux/anaconda3/lib/python3.9/site-packages/IPython/init.py", line 56, in
from .terminal.embed import embed
File "/home/fenaux/anaconda3/lib/python3.9/site-packages/IPython/terminal/embed.py", line 16, in
from IPython.terminal.interactiveshell import TerminalInteractiveShell
File "/home/fenaux/anaconda3/lib/python3.9/site-packages/IPython/terminal/interactiveshell.py", line 35, in
from .debugger import TerminalPdb, Pdb
File "/home/fenaux/anaconda3/lib/python3.9/site-packages/IPython/terminal/debugger.py", line 6, in
from IPython.core.completer import IPCompleter
File "/home/fenaux/anaconda3/lib/python3.9/site-packages/IPython/core/completer.py", line 146, in
import jedi
File "/home/fenaux/anaconda3/lib/python3.9/site-packages/jedi/init.py", line 32, in
from jedi.api import Script, Interpreter, set_debug_function, preload_module
File "/home/fenaux/anaconda3/lib/python3.9/site-packages/jedi/api/init.py", line 13, in
import parso
File "/home/fenaux/anaconda3/lib/python3.9/site-packages/parso/init.py", line 42, in
from parso.grammar import Grammar, load_grammar
File "/home/fenaux/anaconda3/lib/python3.9/site-packages/parso/grammar.py", line 13, in
from parso.cache import parser_cache, load_module, try_to_save_module
File "/home/fenaux/anaconda3/lib/python3.9/site-packages/parso/cache.py", line 76, in
_default_cache_path = _get_default_cache_path()
File "/home/fenaux/anaconda3/lib/python3.9/site-packages/parso/cache.py", line 73, in get_default_cache_path
return dir.expanduser()
AttributeError: 'PosixPath' object has no attribute 'expanduser'
Traceback (most recent call last):
File "/home/fenaux/Documents/robot/examples/meshcat-viewer.py", line 33, in
viz.initViewer(open=True)
File "/home/fenaux/anaconda3/lib/python3.9/site-packages/pinocchio/visualize/meshcat_visualizer.py", line 99, in initViewer
self.viewer = meshcat.Visualizer() if viewer is None else viewer
File "/home/fenaux/anaconda3/lib/python3.9/site-packages/meshcat/visualizer.py", line 92, in init
self.window = ViewerWindow(zmq_url=zmq_url, start_server=(zmq_url is None), server_args=server_args)
File "/home/fenaux/anaconda3/lib/python3.9/site-packages/meshcat/visualizer.py", line 20, in init
self.server_proc, self.zmq_url, self.web_url = start_zmq_server_as_subprocess(
File "/home/fenaux/anaconda3/lib/python3.9/site-packages/meshcat/servers/zmqserver.py", line 70, in start_zmq_server_as_subprocess
raise RuntimeError("the meshcat server process exited prematurely with exit code " + str(server_proc.poll()))
RuntimeError: the meshcat server process exited prematurely with exit code 1

By the way, it seems that you have installed everything in the base env of conda, while you create a new one where you install stuff. Please see with your supervisor to get some tips.

Thanks for your prompt answers.
Yes everything is installed in base env of conda.
I am afraid I am my own supervisor ;)

I am afraid I am my own supervisor ;)

OK. Then just start from a fresh install, without mixing different package managers and use conda env for isolating your developments. This is the only help I can provide due to my limited bandwith.

Hello @fenaux, you should get a clean conda base environment first. There are two options:

completely uninstall anaconda and install it again (recommend).
Use the conda install --revision (check how to use)

Afterwards, from a clean base environment you should create a specific conda environment for Pinocchio (see Section “Managing environments”
https://conda.io/projects/conda/en/latest/user-guide/getting-started.html )
Now depending on what you want to do, inside the specific conda environment you do a conda install -c conda-forge pinocchio to get the master branch of Pinocchio installed.
If you want to use the Pinocchio-3x-preview branch with some new features, you can do conda install -c conda-forge pinocchio --only-deps , then you clone the repo , switch to the desired branch and built from source. In this Pinocchio environment you then install Meshcat using again conda. I hope it helps you.


Flake8 cleanup backport 3.0

Backport PRs #567 and #703 to fix flake8 code formatting warnings.
Is a Bugzilla entry required for simple things like this?  Tagging no-ref for now.

I don't think we are updating to python3 in the 3.0 branch. I am closing  it. Feel free to reopen if you need this to fix a bug.


Lilac peer

Lilac peer

Once the chain launches ill have everyone sign a message with a memo including their peerid. Then include the txhash in the addedPeer field please


Issue with a complex header

Hello,
I have such a header:

      Factors
      Estimated parameters

      Linear regression
      Quadratic regression

      A
      B
      C
      D
      E
      F
      G

When I export to xlsx, Excel has to make a repair, and here is the result:

while it should be:

In my case : when i set header with rowspan and colspan, the header look like this

My Expectation, the header look like this,

Any one can help?

In my case : when i set header with rowspan and colspan, the header look like this

My Expectation, the header look like this,

Any one can help?

I have investigation, and found :
If the header column set with text or value : text space number, the header exported to excel will be to formated with date.
Ex. SEMESTER 4

SEMESTER is text
4 is number

Is it a bug?
@clarketm @PeterDaveHello @janrop @tompetko @pierresh


Consider a Java Preprocessor, e.g. Stonecutter

We support many versions, all with very little code and very little variation between them.
Using a preprocessor like what Sodium, Distant Horizons or YACL use, e.g. Stonecutter
could help a lot with that.

https://github.com/manifold-systems/manifold
https://plugins.gradle.org/plugin/systems.manifold.manifold-gradle-plugin

Stonecutter has moved here now https://github.com/stonecutter-versioning/stonecutter


Update run-servers.sh

Use the -h command line arg instead of --host
Error was:
error: Found argument '--host' which wasn't expected, or isn't valid in this context

I think it's better we fix it by adding the long form of the argument host.

Closing, we swithced to --listen_addr

Awesome... sorry I couldn't reply earlier.. neck deep in work.
Thanks for the project though.


improved scaling strategies for 0-1 and 1-n

A burst of activity seems to trigger immediate scaling to the maximum number of replicas before the first replica even has a chance to absorb the load?.
Would it be possible to give the first replica a chance to do some work first before scaling beyond 1.  Actually, thinking about that some more, it probably make sense for each n+1 increment to kick in only once the previously added replica has started consuming events. This ties the scaling latency to the cold-start latency, but at least it avoids super-eager unwarranted over-provisioning.
Also on the way down, it would be nice to keep the last replica alive for longer to avoid cold-start delays.

see https://github.com/markfisher/s1p2017-faas-demo/issues/23

closing - much better since https://github.com/projectriff/function-controller/commit/ced03336fcd41178ce7c11ca561fd67eb0e65ea6


RCP callback does not produce valid HTTP 1.1 request

My servers kept rejecting the callback from the nano node. It turns out the problem is the first line of the callback request:
POST test HTTP/1.1
Some fiddling around in netcat showed that the request works with this as the first line (slash before test)
POST /test HTTP/1.1
I cannot really use the callback until this is fixed.

What value have you set in config.json for callback_target?


VSCode interactive window:  string variables with newline / space characters not shown correctly while inspecting [Jupyter: Variables]

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:  1.63.2
OS Version: Windows11 enterprise

Steps to Reproduce:

open a interactive window, and type a simple string with newlines/space characters:

str_with_newlines = "[   line1]\n[line2    ]\n[    line3    ]"

Expectation:
if we use [Jupyter:variables] tab to inspect the value of that variable, it should show the newlines/space characters present in the string
What is actually shown:

this is misleads the  user into thinking there are no newlines in the string. also note how spaces are not shown correctly
Couple of notes:

if we use debug to inspect the variable, it is shown with the spaces/newlines correctly:

So the issue seems to be with the  vscode interactive window's way of displaying value of variables

comparing with PyCharm IDE, it seems PyCharm also renders the variable correctly with proper rendering of newline/space character :

thanks for the bug, I am able to repro

this doesn't look right - it makes it seem like the first line is the complete value

It drives me nuts to show escaped newlines like this, because the string \\n\n would be rendered \n\n. But I can look at this next month.

hovering shows the same value, just '[   line1]'.
It would be nice to have some indication that the value shown is not complete, even just dropping the trailing' character, similar to when a variable is too long on a single line.

closing in favor of https://github.com/microsoft/vscode/issues/165445


Support for SSMS 2016

Hi everyone,
I tried following the instructions on the help page and replaced "11_config" with "13_config" but not luck. Has anyone else had any luck getting that to work?
I start SSMS but i never get asked to enter an API key.

It seems SSMS 2016 does not support plugins.

Does this plugin support for SSMS 17.x, version after SSMS2016?

Didn't have time to test it

when are we getting support for SSMS 2016/2017 ?
has anyone managed a work around? please confirm steps. Thank you

I found this forum suggesting a way to create extensions for ssms 2016 (and possibly 2017)
https://www.sqlservercentral.com/Forums/1802009/Developing-Extensions-for-SSMS-2016
I haven't tried it myself but probably a good place to start

Are there any plans for WakaTime to host an installable extension for this?

Just released a new version to support v2012+
Download and follow the instructions
https://github.com/gandarez/ssms-wakatime/releases/tag/v2.0.0

New version does not work, installs fine, doesnt log at all

@hubbardsw it has been tested under SSMS 2016 and there wasn't any error. Could you please share your ActivityLog.xml file?

It doesn't error for me but it doesn't seem to be recording anything on my wakatime dashboard

Unblocking the library solved this issue.

How do we unblock it. Mine still isn't showing up in the dashboard.
I also tried removing it and the config file from %USERPROFILE% and it didn't ask me for the api key.

How do we unblock it. Mine still isn't showing up in the dashboard.
I also tried removing it and the config file from %USERPROFILE% and reinstalling it and it didn't ask me for the api key.

Try this https://github.com/gandarez/ssms-wakatime/issues/1#issuecomment-206484919

That worked!


<EMAIL_ADDRESS>steps to get started

Hi, i'd like to use sigma.js in a project. Which are current steps to follows to go up with this.
Currently i installed it with
npm install sigma
I'm following this examples as a base to start. Are they ok to create working code?
Am i supposed to install all the packages used by the examples? For example graphology
As this are only dependencies i got installing sigma:
     "sigma": {
      "version": "2.0.0-alpha40",
      "resolved": "https://registry.npmjs.org/sigma/-/sigma-2.0.0-alpha40.tgz",
      "integrity": "sha512-E64G8UE/jNzzdUBJln9pjKiY7ZS2eRiRqcjwPgSIGXqDK+I7r9oHaNcYkTgttH2Re5e2b4FvJvoAJ3fTEASD0w==",
      "requires": {
        "@yomguithereal/helpers": "^1.0.0",
        "events": "^3.0.0",
        "graphology-metrics": "1.13.0",
        "graphology-utils": "^1.4.0"
      }
    }

Hello @Christian-Nja
Yes those examples are a good starting point. And yes you will need to install graphology as sigma v2 now uses it. You may also need to install some other graphology libraries depending on what you are trying to achieve (loading a gexf file for instance).

Great, thank you @Yomguithereal  for fast reply!

@Yomguithereal Sorry for the dumb question. But how do I import WebGLRenderer, using npm/webpack?
My src/index.js looks like this:
import Graph from "graphology";
import gexf from "graphology-gexf/browser";
// import WebGLRenderer from "src/renderers/webgl/index";
// import Sigma from 'sigma';

const graph = new Graph();

// const container = document.getElementById("container");
// const renderer = new WebGLRenderer(graph, container);
// window.renderer = renderer;
// window.camera = renderer.getCamera();

I have tried referencing the ../node_modules/sigma/src/renderers/webgl/index.ts directly from node_modules/, but I get an error due to the file being typescript. I think I should be using a webpacked version, but I don't know how to do so. I think I'm misunderstanding something obvious :)

@Yomguithereal Sorry for the dumb question. But how do I import WebGLRenderer, using npm/webpack?
My src/index.js looks like this:
import Graph from "graphology";
import gexf from "graphology-gexf/browser";
// import WebGLRenderer from "src/renderers/webgl/index";
// import Sigma from 'sigma';

const graph = new Graph();

// const container = document.getElementById("container");
// const renderer = new WebGLRenderer(graph, container);
// window.renderer = renderer;
// window.camera = renderer.getCamera();

I have tried referencing the ../node_modules/sigma/src/renderers/webgl/index.ts directly from node_modules/, but I get an error due to the file being typescript. I think I should be using a webpacked version, but I don't know how to do so. I think I'm misunderstanding something obvious :)

You should import the renderer likewise:
import {WebGLRenderer} from 'sigma';

You should import the renderer likewise:
import {WebGLRenderer} from 'sigma';

This is an example on codesandbox that should helps you : https://codesandbox.io/s/sigmajs-issue-xx-00nll


(Another different) TestLegacy flake

I saw this flake on main (Traces) and got very sad since it was in TestLegacy which should have been fixed.
But this flake appears to be distinct from the old one, even though part of the error message is the same:

The mismatch in files occurs in TestLegacyExportAbsolutePath and crucially is in internal/dagger/dagger.gen.go rather than in go.mod
Looking through the engine logs from that run, I can see that filesync cache refs are not being re-used between different client sessions, which was the important part of the root cause for the other flake
I could repro the previous flake locally by running TestLegacy in a loop for at most an hour (but usually closer to 20m). But I have been running that same loop on main for going on 3 hours now locally with it passing every time (takes about 45s per run).

The error this time looks like
	Error Trace:	/app/core/integration/legacy_test.go:62
	Error:      	Received unexpected error:
	            	input: container.from.withMountedFile.withWorkdir.withExec.withNewFile.withNewFile.withExec.stdout resolve: process "dagger --debug query" did not complete successfully: exit code: 1

	            	Stderr:
	            	Error: failed to serve module: input: module.withSource.initialize resolve: failed to initialize module: failed to call module "bare" to get functions: call constructor: process "go build -o /runtime ." did not complete successfully: exit code: 1

	            	Stderr:
	            	internal/dagger/dagger.gen.go:23:2: package dagger/test/internal/querybuilder is not in std (/usr/local/go/src/dagger/test/internal/querybuilder)
	            	internal/dagger/dagger.gen.go:24:2: package dagger/test/internal/telemetry is not in std (/usr/local/go/src/dagger/test/internal/telemetry)
	Test:       	TestLegacy/TestLegacyExportAbsolutePath

I spent a while pouring through the engine logs to find any clues, but everything checks out and looks expected from what I can see based on what we include there.
I don't have any strong hunches yet, but a couple things to note/investigate:

Not clear yet how often this happens, just saw it this one time. Can't repro locally so will just have to see what happens in CI
When running the test loop locally I checked the kernel logs at one point and saw that 10m earlier there was a single [211550.735848] overlayfs: lowerdir is in-use as upperdir/workdir of another mount, accessing files from both mounts will result in undefined behavior.

No idea what to make of this yet, could be completely unrelated. But there must be some rare bug somewhere between buildkit+dagger that causes invalid mounts to be created, which could plausibly explain a situation like this
I may go re-enable printing kernel logs in CI again since this is the exact type of situation where they could be extremely useful

Possible places things could be going wrong (completely hypothetical at this point)

Some deep bug in overlay mount setup (just based on that kernel log mentioned above)
File export somehow getting confused and routing files to the wrong client/session (but just some files, not sure how that could happen)

Hmmmm, maybe this isn't the same, but I do occasionally see this one too: https://dagger.cloud/dagger/traces/8e10dd9a4a2016f2a739f4831b47879d?span=90b732664b3eb8a9#90b732664b3eb8a9:L12
	Error Trace:	/app/core/integration/module_test.go:54
	            				/app/testctx/testctx.go:163

	Error:      	Received unexpected error:
	            	input: container.from.withMountedFile.withWorkdir.withExec.withExec.stdout resolve: process "dagger --debug query" did not complete successfully: exit code:

	            	Stderr:

	            	Error: failed to serve module: input: moduleSource.withContextDirectory.asModule resolve: failed to create module: select: failed to update codegen and runtime: failed to generate code: failed to get modified source directory for go module sdk codegen: select: process "codegen --output /src --module-context-path /src --module-name bare --introspection-json-path /schema.json" did not complete successfully: exit code: 1

	            	Stdout:
	            	generating go module: bare
	            	writing dagger.gen.go
	            	writing go.mod
	            	writing go.sum
	            	running post-command: go mod tidy
	            	needs another pass...

	            	Stderr:
	            	Error: generate code: template: module.go.tmpl:79:3: executing "_dagger.gen.go/module.go.tmpl" at <ModuleMainSrc>: error calling ModuleMainSrc: cannot find default codegen DaggerObject interface
	Test:       	TestModule/TestGoInit/from_scratch

I managed to repro this in CI with a sleep added so I could nsenter into the container and found what seems like it must be a bug in go's build caching?
fail to build due to an import not being found:
buildkitsandbox:/src# /usr/local/go/bin/go build -o /runtime .
internal/dagger/dagger.gen.go:23:2: package dagger/bare/internal/querybuilder is not in std (/usr/local/go/src/dagger/bare/internal/querybuilder)
internal/dagger/dagger.gen.go:24:2: package dagger/bare/internal/telemetry is not in std (/usr/local/go/src/dagger/bare/internal/telemetry)

But when looking at the file it's erroring on, the lines it's complaining about don't match the error at all:
buildkitsandbox:/src# head -n 100 internal/dagger/dagger.gen.go
// Code generated by dagger. DO NOT EDIT.

package dagger

import (
        "context"
        "encoding/json"
        "errors"
        "fmt"
        "net"
        "net/http"
        "os"
        "reflect"
        "strconv"
        "strings"

        "github.com/Khan/genqlient/graphql"
        "github.com/vektah/gqlparser/v2/gqlerror"
        "go.opentelemetry.io/otel"
        "go.opentelemetry.io/otel/propagation"
        "go.opentelemetry.io/otel/trace"

        "dagger/test/internal/querybuilder"
        "dagger/test/internal/telemetry"
)

Then, rm -rf the whole go build cache and now it magically builds again!!
buildkitsandbox:/src# rm -rf /root/.cache/go-build/*
buildkitsandbox:/src# /usr/local/go/bin/go build -o /runtime .

I don't really see how this could be anything but a bug in go.
It wouldn't shock me if it was something vaguely similar to the problem we had with filesync file comparisons that relied on comparing file size + timestamps rather than digesting all the contents: that would explain why go appears to be confusing test and bare

This is just speculation, but those sorts of heuristics are both relatively common and obviously have already bitten us in the past

Next steps:

[ ] repro again but this time tar up the whole build cache and /src dir so we can try to find a minimal repro for the go team to open an issue
[ ] think about what mitigations might be possible in the meantime

changing the cache mount to locked might be worth a try, though no guarantees it would fix and would hit performance for users
doing something like touching file timestamps that avoids the problem somehow (vague idea, needs more thought)

cc @jedevc you're gonna love this one 😄

Okay managed to repro in CI again, tar up the whole rootfs, upload to s3 to exfiltrate it out, and then turn into a docker image that reproduces the problem at eriksipsma/corrupt-cache:latest in dockerhub (it's an amd64 image only since that's what our CI is).
Build failure:
sipsma@dagger_dev:~$ docker run --rm -it eriksipsma/corrupt-cache:latest sh -c '/usr/local/go/bin/go build -C /src .'
go: downloading go.opentelemetry.io/otel v1.27.0
go: downloading go.opentelemetry.io/otel/sdk v1.27.0
go: downloading go.opentelemetry.io/otel/trace v1.27.0
go: downloading github.com/99designs/gqlgen v0.17.49
go: downloading golang.org/x/exp v0.0.0-20231110203233-9a3e6036ecaa
go: downloading github.com/Khan/genqlient v0.7.0
go: downloading golang.org/x/sync v0.7.0
go: downloading github.com/vektah/gqlparser/v2 v2.5.16
go: downloading go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc v0.0.0-20240518090000-14441aefdf88
go: downloading go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp v0.3.0
go: downloading go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.27.0
go: downloading go.opentelemetry.io/otel/log v0.3.0
go: downloading go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.27.0
go: downloading go.opentelemetry.io/otel/sdk/log v0.3.0
go: downloading go.opentelemetry.io/proto/otlp v1.3.1
go: downloading go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.27.0
go: downloading google.golang.org/grpc v1.64.0
go: downloading github.com/go-logr/logr v1.4.1
go: downloading go.opentelemetry.io/otel/metric v1.27.0
go: downloading golang.org/x/sys v0.21.0
go: downloading google.golang.org/protobuf v1.34.1
go: downloading google.golang.org/genproto/googleapis/rpc v0.0.0-20240515191416-fc5f0ca64291
go: downloading github.com/go-logr/stdr v1.2.2
go: downloading github.com/cenkalti/backoff/v4 v4.3.0
go: downloading github.com/grpc-ecosystem/grpc-gateway/v2 v2.20.0
go: downloading github.com/google/uuid v1.6.0
go: downloading github.com/sosodev/duration v1.3.1
go: downloading golang.org/x/net v0.26.0
go: downloading google.golang.org/genproto/googleapis/api v0.0.0-20240520151616-dc85e6b867a5
go: downloading golang.org/x/text v0.16.0
internal/dagger/dagger.gen.go:23:2: package dagger/test/internal/querybuilder is not in std (/usr/local/go/src/dagger/test/internal/querybuilder)
internal/dagger/dagger.gen.go:24:2: package dagger/test/internal/telemetry is not in std (/usr/local/go/src/dagger/test/internal/telemetry)

The errors do not correspond to the actual contents of the file:
sipsma@dagger_dev:~$ docker run --rm -it eriksipsma/corrupt-cache:latest head -n25 /src/internal/dagger/dagger.gen.go
// Code generated by dagger. DO NOT EDIT.

package dagger

import (
        "context"
        "encoding/json"
        "errors"
        "fmt"
        "net"
        "net/http"
        "os"
        "reflect"
        "strconv"
        "strings"

        "github.com/Khan/genqlient/graphql"
        "github.com/vektah/gqlparser/v2/gqlerror"
        "go.opentelemetry.io/otel"
        "go.opentelemetry.io/otel/propagation"
        "go.opentelemetry.io/otel/trace"

        "dagger/bare/internal/querybuilder"
        "dagger/bare/internal/telemetry"
)

Removing the go build cache first results in the errors going away and a successful build:
sipsma@dagger_dev:~$ docker run --rm -it eriksipsma/corrupt-cache:latest sh -c 'rm -rf /root/.cache/go-build && /usr/local/go/bin/go build -C /src .'
go: downloading go.opentelemetry.io/otel/sdk v1.27.0
go: downloading go.opentelemetry.io/otel/trace v1.27.0
go: downloading go.opentelemetry.io/otel v1.27.0
go: downloading github.com/99designs/gqlgen v0.17.49
go: downloading github.com/Khan/genqlient v0.7.0
go: downloading golang.org/x/exp v0.0.0-20231110203233-9a3e6036ecaa
go: downloading golang.org/x/sync v0.7.0
go: downloading github.com/vektah/gqlparser/v2 v2.5.16
go: downloading go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc v0.0.0-20240518090000-14441aefdf88
go: downloading go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp v0.3.0
go: downloading go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.27.0
go: downloading go.opentelemetry.io/otel/log v0.3.0
go: downloading go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.27.0
go: downloading go.opentelemetry.io/otel/sdk/log v0.3.0
go: downloading go.opentelemetry.io/proto/otlp v1.3.1
go: downloading go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.27.0
go: downloading google.golang.org/grpc v1.64.0
go: downloading github.com/go-logr/logr v1.4.1
go: downloading go.opentelemetry.io/otel/metric v1.27.0
go: downloading golang.org/x/sys v0.21.0
go: downloading google.golang.org/protobuf v1.34.1
go: downloading google.golang.org/genproto/googleapis/rpc v0.0.0-20240515191416-fc5f0ca64291
go: downloading github.com/google/uuid v1.6.0
go: downloading github.com/sosodev/duration v1.3.1
go: downloading github.com/go-logr/stdr v1.2.2
go: downloading github.com/cenkalti/backoff/v4 v4.3.0
go: downloading github.com/grpc-ecosystem/grpc-gateway/v2 v2.20.0
go: downloading golang.org/x/net v0.26.0
go: downloading google.golang.org/genproto/googleapis/api v0.0.0-20240520151616-dc85e6b867a5
go: downloading golang.org/x/text v0.16.0

If your docker host is not amd64, this often fails with qemu related segfaults but eventually passes, not relevant to the problem here

Gonna take that and open an issue on the Go repo now

Issue in go repo: https://github.com/golang/go/issues/69179

This one is not causing a flake anymore after https://github.com/dagger/dagger/pull/8470 was merged. However, it's worth leaving open since it's fixed by disabling the go mod index in our test suite, which is really just a bandaid. Will rename to indicate it's tracking the upstream fix in Go and remove the flake label for now. Can close the issue once that bandaid is no longer needed.

We got a report of users hitting this now. We haven't noticed any downsides to disabling goindex in our CI so it's worth considering making this the default setting now. Also worth a double check on performance impact while doing so, especially since we have more metrics to make an informed decision.


[Jazzy] JTC fails with - Caught exception in callback for transition 10

Describe the bug
Loading and activating a JTC fails with:
[ros2_control_node-19] [ERROR] [1732535679.279340867] [joint_trajectory_controller_top]: Caught exception in callback for transition 10
[ros2_control_node-19] [ERROR] [1732535679.279449259] [joint_trajectory_controller_top]: Original error: Resource temporarily unavailable
[ros2_control_node-19] [WARN] [1732535679.279520632] [joint_trajectory_controller_top]: Error occurred while doing error handling.
[ros2_control_node-19] [ERROR] [1732535679.279555908] [controller_manager]: After configuring, controller 'joint_trajectory_controller_top' is in state 'unconfigured' , expected inactive.

From my controllers.yaml
...
joint_trajectory_controller_top:
      type: joint_trajectory_controller/JointTrajectoryController
....

joint_trajectory_controller_top:
  ros__parameters:
    joints:
      - ur_top/shoulder_pan_joint
      - ur_top/shoulder_lift_joint
      - ur_top/elbow_joint
      - ur_top/wrist_1_joint
      - ur_top/wrist_2_joint
      - ur_top/wrist_3_joint
    command_interfaces:
      - position
    state_interfaces:
      - position
      - velocity
    state_publish_rate: 100.0
    action_monitor_rate: 20.0
    allow_partial_joints_goal: false
    constraints:
      stopped_velocity_tolerance: 0.1
      goal_time: 0.05
      ur_top/shoulder_pan_joint: { trajectory: 0.2, goal: 0.0015 }
      ur_top/shoulder_lift_joint: { trajectory: 0.2, goal: 0.0015 }
      ur_top/elbow_joint: { trajectory: 0.2, goal: 0.0015 }
      ur_top/wrist_1_joint: { trajectory: 0.2, goal: 0.0015 }
      ur_top/wrist_2_joint: { trajectory: 0.2, goal: 0.0015 }
      ur_top/wrist_3_joint: { trajectory: 0.2, goal: 0.0015 }

Everything was working mostly with a jazzy binary installation before updating it to the latest jazzy release with only this issue occurring from time to time: https://github.com/ros-controls/ros2_control/issues/1883
Environment (please complete the following information):

Version Jazzy, binary.  controller_manager  4.20.0, JTC 4.16.0
UR packages are built from source. Minor changes to the ScaledJTC. But this issue also occurs with the default JTC
Running in a docker container on a Ubuntu 24.04 host (networking host)
Running with mocked hardware

EDIT:
I did a bit of additional research. Looks like: Resource temporarily unavailable is usually issued by the operating system.
But even after reading quite a bit of code I have no clue why this error  should occur in the configure method of a controller.
I am running the system with mocked hardware at the moment.

I just did some more testing:

In random cases it works to load and activate a controller -> but loading the next controller won't
When trying to configure and activate a controller that has failed before the ros2_control_node crashes with:

[ros2_control_node-19] terminate called after throwing an instance of 'St9bad_alloc'
[ros2_control_node-19]   what():  std::bad_alloc
[ros2_control_node-19] terminate called recursively

I am one step further:
I can configure and activate a JTC now by disabling locked memory for the controller manager:
controller_manager:
  ros__parameters:
    update_rate: 500
    lock_memory: false

@saikishor I think you added the memlock - perhaps you have some insights ?

I am one step further:
I can configure and activate a JTC now by disabling locked memory for the controller manager:
controller_manager:
  ros__parameters:
    update_rate: 500
    lock_memory: false

@saikishor I think you added the memlock - perhaps you have some insights ?

Can you share the output of ulimit -a?

ulimit -a in my container:
real-time non-blocking time  (microseconds, -R) unlimited
core file size              (blocks, -c) 0
data seg size               (kbytes, -d) unlimited
scheduling priority                 (-e) 0
file size                   (blocks, -f) unlimited
pending signals                     (-i) 111518
max locked memory           (kbytes, -l) 3577496
max memory size             (kbytes, -m) unlimited
open files                          (-n) 1048576
pipe size                (512 bytes, -p) 8
POSIX message queues         (bytes, -q) 819200
real-time priority                  (-r) 99
stack size                  (kbytes, -s) 8192
cpu time                   (seconds, -t) unlimited
max user processes                  (-u) 111518
virtual memory              (kbytes, -v) unlimited
file locks                          (-x) unlimited

And on my host:
real-time non-blocking time  (microseconds, -R) unlimited
core file size              (blocks, -c) 0
data seg size               (kbytes, -d) unlimited
scheduling priority                 (-e) 0
file size                   (blocks, -f) unlimited
pending signals                     (-i) 111518
max locked memory           (kbytes, -l) 3577496
max memory size             (kbytes, -m) unlimited
open files                          (-n) 1024
pipe size                (512 bytes, -p) 8
POSIX message queues         (bytes, -q) 819200
real-time priority                  (-r) 99
stack size                  (kbytes, -s) 8192
cpu time                   (seconds, -t) unlimited
max user processes                  (-u) 111518
virtual memory              (kbytes, -v) unlimited
file locks                          (-x) unlimited

The max locked memory should be unlimited. You can set it on your system. You can check online the requirements and setup to have the lock memory

Ideally, the lock_memory is better set, if you configure your ros2_control_node as a privileged process

I also tried "--ulimit memlock=-1:-1" as argument for podman. This improved the situation so that loading some controllers works fine.

The max locked memory should be unlimited. You can set it on your system. You can check online the requirements and setup to have the lock memory

I will try that tomorrow and let you know.
Just as a comment from my side:
I have a default Ubuntu 24.04 installation. I am wondering if a default ubuntu installation doesn't play well with the default parameters of ros2control it might be a good idea to have lock_memory default to false. (Which is btw. also missing in the documentation so far - https://control.ros.org/rolling/doc/ros2_control/controller_manager/doc/userdoc.html)

You are right. It might make sense to have it false by default for this case. Can you test it tomorrow increasing the limit and see if this solves your issue?

@saikishor I increased my locked memory limit not to unlimited by 64GB and it seems to work fine now.
max locked memory           (kbytes, -l) 64000000
I also made sure that I removed the configuration entry from my controllers.yaml

@firesurfer do you mind reviewing the PR on the ros2_control side and approve it. If it looks good to you

Already at it.
What still puzzles me is the error I got there.

Original error: Resource temporarily unavailable

Which corresponds to: EAGAIN
From my understanding the only thing that could fail due to not enough locked memory is a some memory allocation:
But according to the documentation the only error flag set by malloc or calloc is: ENOMEM

Already at it.
What still puzzles me is the error I got there.

Original error: Resource temporarily unavailable

Which corresponds to: EAGAIN
From my understanding the only thing that could fail due to not enough locked memory is a some memory allocation: But according to the documentation the only error flag set by malloc or calloc is: ENOMEM

Yeah, that is weird.

I found the explanation:
https://stackoverflow.com/questions/34165276/malloc-setting-errno-to-eagain
Apparently EAGAIN comes from mmap which is apparently called in case malloc fails.

Thank you all. I met the same problem on a raspberry pi 5 8G RAM. add lock_memory: false to ros2_control.yaml under config folder did fix the problem.

Thank you all. I met the same problem on a raspberry pi 5 8G RAM. add lock_memory: false to ros2_control.yaml under config folder did fix the problem.

Hello @TonyInvent!
We have changed the logic in https://github.com/ros-controls/ros2_control/pull/1896, such that if the realtime system is properly setup, this parameter will be true, else it would be false. So, you won't be having to deal with it. Thanks for reporting that it solved your issue.


Some recent regressions disclosed by the Wolf:ET Oasis map

Here is how the map should look (viewpos 3033 2819 54 112 1) (example with commit 6ebf5057aa293f7f82676116c847096aaa74e3ac):

This is how it looks on my end on current master branch:

This seems related to global fog, if I disable the global fog of the map with r_noFog 1 I get that:

I also noticed that if I do glsl_restartwhile the oasis maps is running, I get this error:
]/glsl_restart
Warn: Link log:
error: unresolved reference to function `DeformVertex'

Warn: Unhandled exception (15ShaderException): Shaders failed to link

But unlike the global fog error, I don't know if this error si recent or not.

Here is a tutorial to fetch the Wolf:ET map an do some dpkdir for them:
wget 'https://raw.githubusercontent.com/illwieckz/pimi/master/pimi'
chmod +x pimi
./pimi -y -p -etl=. etmain

for m in battery fueldump goldrush oasis radar railgun
do
  mkdir -p "etmain/map-${m}_0.dpkdir"
  printf 'pak0\npak1\npak2\n' > "etmain/map-${m}_0.dpkdir/DEPS"
done

Once downloaded, one can load the Oasis map this way:
./daemon -pakpath "$(realpath etmain)" -set g_neverEnd on -set fs_legacyPaks on -set cg_navgenOnLoad off +devmap oasis

The global fog regression was introduced in db6bf45765ef3c47a2c174caf2673da9659ca409.

The bug disappears as soon as the sky is not visible (one can look at the floor to not have sky brushes on screen).


Switch base from alpine to debian

How to categorize this PR?

/area open-source
/kind cleanup
What this PR does / why we need it:
Switches the base image from alpine to debian bullseye, allows to combine go 1.16 with python 3.9 => image size increased from (already huge?) 1.7GB to 2.0GB, image build time decreased from ~350secs to ~50secs because pip packages no longer need to build their deps from source (because of musl vs. glibc).
Not sure if it would be a good idea though, hence just a draft.
cc @schrodit @vpnachev
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

I was about to propose to use apk add --no-cache and rm -rf /var/lib/apt/lists/* after apt-get install to reduce the image size, but running it locally the image is still 2.13 GiB

Not sure what is the state of this PR, having mind it is ~2 years old now, maybe we can close it?


Feature: experimental skinning

Skinning in secondary form.
I know this is ugly without using hooks. But as a starting and concept point, let's add these experimental feature:

[ ] Skinnable form behind the taskbar (main taskbar for the moment, multitaskbar later)
[x] Use BlurBehind from DWMApi to show a taskbar similar to original but smaller
[ ] Use LayeredWindows to draw a custom theme from PNG, maybe compatible with RocketLauncher background pictures.
[ ] optional Draw over Windows 10 taskbar using a hacky LayeredUpdate restoring icons from IAccessible data.

It has some glitches, and it seems to be more difficult to paint skin on secondary taskbars if they are on a different position i.e. top while the main is bottom.

It also have some glitches on centering resizing, since hooking needs to paint not only the taskbar but the icons background.
For the moment it will be used a hacky (ugly) form behind the taskbar, it has cons and pros.
But it looks nice, ain't it?

Hi Vhanla
would you release this feature in next build ?
Regards


WIP: Add a new sample - subgroups operations

Description
Please include a summary of the change, new sample or fixed issue. Please also include relevant motivation and context.
Please read the contribution guidelines
Fixes #
General Checklist:
Please ensure the following points are checked:

[ ] My code follows the coding style
[ ] I have reviewed file licenses
[ ] I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
[ ] I have commented any added functions (in line with Doxygen)
[ ] I have commented any code that could be hard to understand
[ ] My changes do not add any new compiler warnings
[ ] My changes do not add any new validation layer errors or warnings
[ ] I have used existing framework/helper functions where possible
[ ] My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions
[ ] My changes do not add any regressions
[ ] I have tested every sample to ensure everything runs correctly
[ ] This PR describes the scope and expected impact of the changes I am making

Sample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

[ ] I have tested the sample on at least one compliant Vulkan implementation
[ ] If the sample is vendor-specific, I have tagged it appropriately
[ ] I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
[ ] Any dependent assets have been merged and published in downstream modules
[ ] For new samples, I have added a paragraph with a summary to the appropriate chapter in the samples readme

That's a nice little sample!
Is it still work in progress, as the title says?
Would it be easy to extend that sample by adding a non-subgroups path for comparison?

Hi @asuessenbach,
Yes, I'm still working on this sample.  I'm currently implementing the FFT algorithm. Next week, I plan to push another commit/change with the vertex animation ready.
And as for the last question, I cannot answer you yet.

Any update on this? Having a subgroups sample would be very much appreciated :)

Any updates on this sample? Having a subgroup sample would be a great addition :)

Hi @SaschaWillems, I apologise for not updating for such a long time. Unfortunately the implementation of the sample is not yet finished. I still have some work left to do:

implement BRDF reflections,

fixing problems with pipeline barriers - on the Intel Iris Xe the sample runs stable, but on the RTX 2060 it crash after a few seconds,

adding a description to the README file.

No need to apologize. Your work is very much appreciated and I'm happy to hear that this sample is coming along :)

Any update on this?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: Krzysztof-Dmitruk-Mobica:white_check_mark: Patryk-Jastrzebski-Mobica:x: kdmitrukYou have signed the CLA already but the status is still pending? Let us recheck it.

Hi @Patryk-Jastrzebski-Mobica, we noticed there's an issue with the CLA on this one - looks like the test got confused with the login alias (kdmitruk).  Can you look into this?  Not quite sure what the fix is - perhaps sign the CLA again using the alias?  Thanks

Hi @marty-johnson59, I will to do something about it this week. I hope to find some time in the near future to finish the sample :).

Hi @Patryk-Jastrzebski-Mobica, quick reminder on this.  We briefly discussed this on the Samples call this week and there's definitely interest in seeing this sample released.  Let us know if/how we can help.  Thanks!

Hi @marty-johnson59, I am very sorry for such a long delay. I got back to work on this example this week. For now, I am pushing the fixes onto my own branch https://github.com/Mobica/Vulkan-Samples/tree/subgroups_operations_WIP3 . As soon as I have fixed the reflections on the model, I will immediately start to rebase this branch and deliver the code.

Awesome, thank you! (and NP on the delay - just following up and letting you know there is still strong interest in this sample :) )

Hi,
I have added the option to disable subgroups after by using shaders with subgroups disabled. After adding shaders without subgroups enabled something like this started to happen to the mesh? @marty-johnson59 or @SaschaWillems  do you have any idea where this problem is coming from? I'm not able to figure out myself if this is a problem with SPIR-V, the graphics driver or my implementation.
I need help with this issue.

I don't understand all those funny calculations there....
But if you clamp h0_k and h0_minus_k in fft_tilde_h0.comp to [-1000,1000], instead of [-4000,4000], the spikes get much less pronounced.
But there seems to be some problem near the center of the grid. Maybe you should change all those calculations a bit? Especially don't make it that much dependent on the position.

I don't know why, but this little patch makes the subgroups enabled case look correct again.
0001-Make-subgroups-enabled-work.patch

@cforfang : The sample is still work-in-progress

Understood, just to highlight already now in case incompatibility might come up as a problem later for example :)

Hi @Patryk-Jastrzebski-Mobica, just checking status on this one.  Is it still in flight?  Any help you need?  Thanks


Remove unnecessary spans from sicpjs

Description

Removed unnecessary spans.
Before:

After:

Will find some time to work on accessibility issues in the future.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[x] Code quality improvements

How to test

Checklist

[x] I have tested this code
[ ] I have updated the documentation

Pull Request Test Coverage Report for Build 967127718

7 of 7 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 30.107%

Totals

Change from base Build 966753988:
0.03%

Covered Lines:
3213

Relevant Lines:
9827

💛  - Coveralls


Add asm calls for refmvs

Add asm logic corresponding to refmvs.h in the original C project.

LGTM (did a quick skim).
Looks like there are some superfluous casts in there (e.g. as libc::c_int as libc::c_uint). IDK if you left those so we can do a sweep later of if it was accidental. No big deal.

@thedataking Extra casts have been cleaned up.


Search not providing correct results

Search is not looking at the full name of the application/driver to pull results.  When doing a search for weather the results do not display NOAA Weather Alerts.

Search filters out apps you already have installed. My gut is, since you wrote it, you have it installed! I just uninstalled it and searched and it shows up:

Any chance you were able to confirm this is working? I'd like to close it out but not before being sure.

I'm closing this out as I believe it is working correctly. If you experience the issue again, please let me know.


Neeraj Task 225-230: curation-corpus-base and conv_question Dataset

Added json files for the tasks along with adding my tasks to your list of tasks

@Maitreyapatel, wondering if you can help review this PR?

@PhaniRohithaKaza, wondering if you can help review these tasks?

@swarooprm any updates on the review?

Hello,
task 226-Category could be Answer Generation
task 228- Category could be Question Generation
task 229-Category could be Answer Generation
task 230-Category could be Answer Generation
Revise the summary in Readme file for task 226, 229 and 230.

@nrjvarshney, can you help review this PR?

"that makes sens" --> use something else

General Comments:

Verify the categories - It shouldn't be a sentence. Use the ones already used in the repo unless you are creating a completely novel task.
Try to write the task definition concisely.
Prefix is not required in the input/output

Task 225 -

Definition: "In this task, you need to generate an appropriate title for the given story"
Try to elaborate the explanations of positive examples.
Should the Task category be "Answer Generation"? Verify it

Task 226

Task category shouldn't be a sentence.
Definition: "In this task, select the most appropriate title of the passage out of the given two options."

Task 227:

Remove the prefix from the input.
This task is fact-based, even a human might not be able to answer such questions.

Task 228:

Task definition can be written in a single line.
prefix not required in the input
This task is also fact based.

Task 229 and 230:

Fact-based
cc @swarooprm , do we plan to keep such fact-based questions?

Hi @swarooprm if the tasks are acceptable, may I proceed with the other changes?

@PruthaGaherwar, I reviewed tasks 229 and 230, they are fine.
Task categories in both the tasks need to be changed.
Task 230's definition is same as 229 and need to be changed.
Please let us know once you do the changes (along with Neeraj's review).

@PruthaGaherwar, I reviewed tasks 229 and 230, they are fine. Task categories in both the tasks need to be changed. Task 230's definition is same as 229 and need to be changed.
Please let us know once you do the changes (along with Neeraj's review).
Last reminder to address reviewer comments @PruthaGaherwar.


CASMCMS-8952: Improve handling of no-op situations

CSM 1.6 PR for https://github.com/Cray-HPE/bos/pull/282

The comments from my other review apply to this one.

I've addressed them there and here. Please re-review when you have the chance. Thanks!


Cannot read property 'path' of null

If you are reporting a bug, please fill in below. Otherwise feel free to remove this template entirely.
Can you reproduce the problem with latest npm?
Many errors, especially related to "missing modules", are due to npm bugs.
If you're using Windows, follow these instructions to update npm.
If you're using OS X or Linux, run this to update npm:
npm install -g npm@latest

cd your_project_directory
rm -rf node_modules
npm install

Then try to reproduce the issue again.
Can you still reproduce it?
Description
What are you reporting?
Expected behavior
Tell us what you think should happen.
Actual behavior
Tell us what actually happens.
Environment
Run these commands in the project folder and fill in their results:

npm ls react-scripts (if you haven’t ejected):
node -v:
npm -v:

Then, specify:

Operating system:
Browser and version:

Reproducible Demo
Please take the time to create a new app that reproduces the issue.
Alternatively, you could copy your app that experiences the problem and start removing things until you’re left with the minimal reproducible demo.
(Accidentally, you might get to the root of your problem during that process.)
Push to GitHub and paste the link here.
By doing this, you're helping the Create React App contributors a big time!
Demonstrable issues gets fixed faster.

Sorry but you provided no information for us to help you.
Please file a new issue with the template filled. Thanks!


RFC: Auto populate mutation body

It would be handy if mutation bodies could be auto populated based on the set of currently watched queries. As inspired by Relay.
How do updates currently work?
type Query {
  todos: [Todo]
}

type Mutation {
  toggleTodo(id: ID!): Todo
  addTodo(text: String!): Todo
  deleteTodo(id: ID!): Todo
}

type Todo {
  id: ID
  text: String
  complete: Boolean
}

Given the schema above. We could request the todos using the following query.
query {
  todos {
	__typename
    id
    text
    complete
  }
}

Whilst a component is mounted with this associated query, it is identified as watched. This means any changes to fields or selections within it will trigger reactive UI updates whenever its data changes.

Mutations that affect it will also trigger updates so long as the entity can matched to one in the cache.
mutation($id: ID!) {
  toggleTodo(id: $id) {
	__typename
    id
    complete
  }
}

A mutation body should include any fields that may change as a result of the mutation. Ideally these fields at least match those that have already been requested. We can enforce this by spreading common fragments, however, this can become chaotic as the schema and application grow.
The following works quite well but can result in overfetching since not all requested fragments may be mounted but they are now deeply coupled to component fragments.
fragment Todo on Todo {
	__typename
    id
	text
    complete
}

query {
  todos {
    ...Todo
  }
}

mutation($id: ID!) {
  toggleTodo(id: $id) {
	...Todo
  }
}

Proposal
Instead of declaring the mutation body explicitly, we can infer the body from the currently watched queries. Using schema introspection we can infer that for the following watched query a Todo fragment exists.
# This query belongs to a currently mounted component
query {
  todos {
-	__typename
-    id
-	text
-   complete
}

fragment Todo on Todo {
+	__typename
+    id
+	text
+   complete
}

We can also infer that a mutation may require a Todo fragment, however we cannot infer where in its selection that may be. Using a directive we can be explicit about where we'd like to auto populate.
mutation($id: ID!) {
-  toggleTodo(id: $id) @populate
}

# Replaces the scalar with a selection set populated by the watched fragment
mutation($id: ID!) {
+  toggleTodo(id: $id) {
+	...Todo
+  }
}

As queries are mounted and unmounted the mutation body dynamically updates to accommodate the immediate requirements of the UI.
What do we need to do this?
Since this behaviour is additive to urql it would be best served as an opt-in exchange. We'll need access to the following in order to achieve the above.

Knowledge of currently watched queries via mount/teardown events.
Handling for the custom @populate directive. These need to be replace by selections at runtime.
Type info for the annotated selection set or field ideally via introspection since we'll reliably need the typename in all cases

As of today this has been merged into Graphcache ✨ https://github.com/FormidableLabs/urql-exchange-graphcache/pull/120


Fix podspec lint warning

I should have run the linter again - there was a typo in the podspec file (missing .git repository suffix).
If this is merged, you could create a new release by tagging the current code, and updating the podspec to use this new tag:
s.source = { :git => "https://github.com/mickeyl/LTSupportAutomotive.git", :tag => "1.0.0" }

Then you could upload the podspec to the CocoaPods repo, and everybody can use this released version in a podfile.
pod trunk push LTSupportAutomotive.podspec

Thanks for the patch. The current version of this code has been stable for a while now and is being used in a couple of projects. I think I'll cut a release 1.0.0 on weekend!

Awesome! I'll try it out in my project to see if there are any errors with the packaging left.