Error in shlink deployment

We use your chart to deploy shlink backend. I wanted to update the chart to latest version. But when I run helm upgrade I only get
Error: template: shlink-backend/templates/deployment.yaml:84:24: executing "shlink-backend/templates/deployment.yaml" at <include "postgresql.primary.fullname" .Subcharts.postgresql>: error calling include: template: no template "postgresql.primary.fullname" associated with template "gotpl"

What to do? I think you need to adjust the values in the templates because they changed in the postgres-chart? I think primary.fullname does not exist any longer and changed to primary.name.
Are you able to fix this in a short way?
Thanks in advance.

I think all the bitnami database charts have changed their naming scheme to primary.name.


How to reset validator object

I'm currently working on a mobile project and using jQuery validation plugin to do client-side validation.
I'm also using jQuery Mobile, with the single-page template (I have pages in separate files, but when changing pages
JQM reads the file and injects the new page content to the DOM).
In this project, Im forcing JQM to remove the previous page in order to have the DOM smaller.
// remove page to prevent caching
$('div').on('pageshow', function (event, ui) {
$(ui.prevPage).remove();
});
The first page is the login screen with a simple form for username and password. Everything goes well in the first shot:
The validation plugin complains if the submit button is pressed and some fields are empty.
If all fields are OK and submit is pressed, I make an ajax call to a web service, save data in the DB and the next page is displayed.
In the next screen, the validation plugin just does not work properly. It does not validate, and when the submit is pressed, the form is submitted even when the required input textboxes are empty and there are no errors in the console.
Is there something I'm missing? How could I "restart" the plugin? Maybe it still thinks the previous call didn't finish?
I'm debugging the non-minified plugin js file, and it looks like the problem is the initialization it does in the validate call.
In the first call, which completes successfully, the plugin creates a validator wich binds to the form, and it caches the validator.
In the second call, I'd need it to bind a new validator to the new form, and instead it is returning me the old validator (binded to the old form).
So, this plugin binds to a form when validate is called and keeps binded to it as long as the form is in the DOM.
Also it caches the validator, so subsequent calls to validate over the same form return the very same validator.
My question is, how I would be able to prevent validator object to be cached or how I would be able to reset this object on the second jquery mobile page?
Thanks in advance.

I am not sure, How i could follow up on this?

Sounds like #1392 could address your issue.


Fix for hidden dot-files in plugins/Networks/lang folder.

This fixes a really niche issue that could happen for servers where the files are stored on a network mounted share.
Scenario:
Server files are located on a NAS share
Separate machine with dockerized paper server (ie Crafty Controller)
The mounted share is bind mounted into the docker container

Sorry for waiting so long, it seems that my notification settings were incorrectly set.
The PR looks good, I'd go further and actually filter out if the file is really a lang file or not, but I can do that quickly.


Exact Match

Hi,
I am using flashtext for searching 694 bad words in some documents for tagging them if they contain bad language or not. But i need the exact match case because some words contain bad words in them but they are not bad words. How can I make the search for exact matches?

Hi @AlpUygur,
Just add the bad words to the Keyword Processor using the add_keyword parameter, and make sure the case_sensitive=True. I hope this solves your issue?
>>> from flashtext import KeywordProcessor
>>> keyword_processor = KeywordProcessor(case_sensitive=True)
>>> keyword_processor.add_keyword('Bad word 1')
>>> keyword_processor.add_keyword('Bad word 2')
>>> keywords_found = keyword_processor.extract_keywords('I have Bad word 1 and Bad word 2.')
>>> keywords_found
>>> # ['Bad word1', 'Bad word 2']
Kind Regards,
Nandan Thakur

Hello, Thanks for your answer but it didn't work on my case.

can you share some sample which fails ?

For example I am looking for "am" in text. It founds "am" when there is "cam" in the text.

This should never happen, can you pick that line and make a working example
and share that.
On Mon, May 11, 2020 at 12:20 AM Alp Uygur<EMAIL_ADDRESS>wrote:

For example I am looking for "am" in text. It founds "am" when there is
"cam" in the text.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/vi3k6i5/flashtext/issues/109#issuecomment-626371843,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXY3QQPIMFJ45LKAB7T7ILRQ3ZN7ANCNFSM4MSBE2VA
.

--
Vikash

@AlpUygur this does only happen when the "c" in "cam" for whatever reason is not part of the non_word_boundaries. Depending on the character script of your input text, this can happen.
import string
non_word_boundaries = set(string.digits + string.ascii_letters + '_')

Then check if that "c" is in non_word_boundaries.
If it is not, you have to manually add non_word_boundaries to your instance of KeywordProcessor via add_non_word_boundary().

This should never happen, can you pick that line and make a working example and share that.
…
On Mon, May 11, 2020 at 12:20 AM Alp Uygur @.***> wrote: For example I am looking for "am" in text. It founds "am" when there is "cam" in the text. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#109 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXY3QQPIMFJ45LKAB7T7ILRQ3ZN7ANCNFSM4MSBE2VA .
-- Vikash

`keyword_processor = KeywordProcessor()
keyword_processor.add_keyword_from_file(r"C:\Users\alpuy\Desktop\School\Bitirme\karaliste.txt", encoding="utf-8")
def isBad(text, keyword_processor):
keywords_found = keyword_processor.extract_keywords(text)
if len(keywords_found) > 0:
print(keywords_found)
return True
texts.txt
return False

with open(r"texts.txt",'r') as f:
text = f.read()
print(isBad(text,keyword_processor))

Output
['am']
True
`

texts.txt
Text file is here. I looked to the file and there is no "am" word in it but it still finds it. There are
"am" inside of some words.

Can’t be bothered. Re-read my last comment and read up on how flashtext treats word boundaries.

It did not change anything when I add non word boundary
@iwpnd

Just my luck then I guess. :P
keyword_processor = KeywordProcessor()
keyword_processor.add_keyword_from_file(r"badwords.txt", encoding="utf-8")
text = "akşamüzeri"
keyword_processor.extract_keywords(text)
>> ["am"]

changing non word boundaries
keyword_processor = KeywordProcessor()
keyword_processor.add_keyword_from_file(r"badwords.txt", encoding="utf-8")
keyword_processor.non_word_boundaries.update(["ş", "ü"])

text = "akşamüzeri"
keyword_processor.extract_keywords(text)
>> []

@AlpUygur probably uninstall flashtext and reinstall again?
I can't find a reason why it won't change anything with non-word boundaries.
Follow the steps mentioned by @iwpnd.
Thanks @iwpnd for the clear implementation :)
Kind Regards,
Nandan Thakur

@AlpUygur Just my luck then I guess. :P
keyword_processor = KeywordProcessor()
keyword_processor.add_keyword_from_file(r"badwords.txt", encoding="utf-8")
text = "akşamüzeri"
keyword_processor.extract_keywords(text)
>> ["am"]

changing non word boundaries
keyword_processor = KeywordProcessor()
keyword_processor.add_keyword_from_file(r"badwords.txt", encoding="utf-8")
keyword_processor.non_word_boundaries.update(["ş", "ü"])

text = "akşamüzeri"
keyword_processor.extract_keywords(text)
>> []

Thanks for implementation. It is very clear.
On the other hand, my solved my problem by changing encoding of the file i read to utf-8. Because of badwords are in utf-8 file must be read utf-8 bytes format. I did not see this difference for a long time sorry :)

Ok,
I found how to avoid this behavior using
keyword_processor.non_word_boundaries.update(["-", "/"])
Must have overlooked it in the doc!
Thanks anyways!


Error update count test

it seems the test was removed ,
could we use this branch instead?
Thanks

yeah, not sure what happened. can you make a PR that only re-adds the tests? Everything else should already be in master...


Use of undefined constant SSL_KEYS_PATH - assumed 'SSL_KEYS_PATH'

Some tests are failing with this error, for example BCJWSTest.php,  JWSTTest.php and SimpleJWS.php tests

Hi @PB314,
could you open an issue to reproduce it?
Best


feat: status bar revamp

Add CMS support for dynamic status bar updates
Revamp status bar design according to latest Figma
Fix multiple status bars layout
Add dark mode support

closes #1159

There are a couple of differencies between the build and the design:

[ ] Dark mode should have white background banners, and light mode should have dark background banners. This is to create more visual contrast between the UI elements and the banners
[ ] Links should be coloured
[ ] For the top banner, text should be centered on the page
[ ] There should be 3 types of banners: (i) Info or notice (blue or purple), /!\ Medium warning (orange), /!\ Severe warning (red)
[ ] There should be 2 hierarchies of banners: Primary (top of page) and secondary (on hero section). Probably important to make this distinction on the CMS as well.
Use primary + secondary when combining a Medium or Severe warning banner + an Info banner.
Medium or Severe warnings should always be on primary (top) position, and Info should be on secondary position.
If combining Medium + Severe warning, the most 'severe' one should be on primary (top) position
[ ] There is also an option shown for a double severe warning, but if this is too complicated to handle at a CMS level, let's just stack them on top of each other whenever there's a double severe, or any other combinations of 3 (i.e: severe + medium stacked on top, info on secondary position)

:tada: This PR is included in version 1.186.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


VSCode Bicep Extension does not install Bicep CLI

I have just tested this. Installing the VSCode Bicep Extension installs the Language Server which is for authoring bicep files, it does not install the Bicep CLI as stated in the table at the top.

@mumian

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@ross-p-smith - thank you for your contribution.
#sign-off


CLOUD-865 added event when can not deregester from ambari

@martonsereg

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1410/

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1411/

lgtm


Expect hangs with interactive command

Program hangs when I try to execute Expect with unexpected string
child, err := gexpect.Spawn("passwd test")
	if err != nil {
		log.Fatal(err)
	}
	err = child.Expect("YOU WILL NEVER FIND ME")
	if err != nil {
		log.Println("should print error", err)  // should print error, but it never execute
	}

I want to do this because there could be different results for one command. For example, ssh $hostname ls /tmp may output the directory information of tmp directly if the ssh public key has copied to the host, or  get the prompt for the password, I found it only works well with non-interactive command.

I found ExpectTimeout is a way to do this,  but it still hangs with child.Wait(), it seems I must use child.Close() to kill the process, here is the modified code:
child, err := gexpect.Spawn("passwd test")
if err != nil {
	log.Fatal(err)
}
err = child.ExpectTimeout("YOU WILL NEVER FIND ME", time.Second*1)
if err != nil {
	log.Println("should print error", err)
	child.Close()
}
	child.Wait()

Have a better way?


Change the twitter icon to X icon

It is better to change the twitter icon to its new X icon. Assign this issue to me as I would like to contribute in this project.

Hi @Kaniz-Fatma  thanks for pointing it out !! But we are not active on socials as of now and it's ok to have that logo here !! Please review the project thoroughly and try to create some value contribution !! Looking forward to your new issue


Advertise a custom IP Address on API Server

Problem
The role configures the API Server to advertise the IP address which resides on interface where the default route points to. This is automatically done by the ansible fact ansible_default_ipv4.
In some cases we would like to advertise a different IP address.
Solution
The proposed solution allows configuring the API Server address by setting the desired IP via a variable/fact.

Hi Federico, in which use case you want to do this differently?

The case in which the default network is not the right network for exposing the API Server.
I faced this problem when creating a lab environment using Vagrant + Virtualbox, which VMs have a default network set to a Host-only adapter. But I think this may be useful also for other setups of VMs in any hypervisor.
Note that this change doesn't change the advertise address of the API Server by default, but allow changing it.


Dependabot stopped making PRs

I have activated Dependabot for three projects. They each use Javascript and have dependencies in NPM.
For two of the projects, one public and one private, I'm getting pull requests regularly. It's working great.
For one private project, I haven't gotten a Dependabot pull request since January, despite the fact that it has the same dependencies as the other projects. I do get security warnings for the project. I can't find any configuration options for Dependabot that would account for the difference: so far as I can tell, Dependabot is either on or off.
Why would Dependabot stop creating PRs?
The public project is dieselpoint/groundlist.site. (Github people: if you have access to my private projects, the project not getting the PRs is dieselpoint/groundlist).

For two of the projects, one public and one private, I'm getting pull requests regularly. It's working great.
...
The public project is dieselpoint/groundlist.site. (Github people: if you have access to my private projects, the project not getting the PRs is dieselpoint/groundlist).

👋 @ccleve: The public project has a .github/depenabot.yml file. That file is necessary for enabling Dependabot. For the private project you mentioned (dieselpoint/groundlist), it appears that Dependabot is not enabled for the repository. Can you ensure that you have a valid .github/depenabot.yml file present in the repository?
If you already have a .github/dependabot.yml file present in the dieselpoint/groundlist repo, please let us know, and we'll re-open this issue.


Not possible to retrieve child validator from ChildValidatorAdaptor anymore

With e1a80fed, the public Validator property was removed from ChildValidatorAdaptor, and the only way of retrieving the underlying validator is now the protected GetValidator(context) method.
We rely on traversing child validators to dynamically generate client side validators, so this is a breaking change for us.
The work around is to use reflection to retrieve the child validator, but it should really have a public way of accessing the validator.

The child validator can now be instantiated lazily using a delegate, which is why the Validator property was removed. You can invoke this delegate to retrieve the validator instance using the GetValidator method- if you don't have a context available at this time then you can always supply a fake one with a null instance (assuming you're not relying on lazy instantiation of child validators):
var context = new ValidationContext(null);
adaptor.GetValidator(context);

Thanks for the quick reply!
My problem is that the GetValidator method is protected, and not accessible without reflection.
(A lesser issue is that the GetValidator actually takes a concrete PropertyValidatorContext instance, so currently I actually have to do this in order to get to the validator:
var getter = typeof (ChildValidatorAdaptor).GetMethod("GetValidator", BindingFlags.NonPublic | BindingFlags.Instance);
var nullContext = new PropertyValidatorContext(new ValidationContext(null), null, null);
var childValidator = getter.Invoke(validator, new object[] {nullContext}) as IValidator;

)

Yes...I meant I can modify it and make it public. Sorry if that wasn't clear

Yes, that would suffice for us! Great, thanks :)

Great, I'll try and get that done before the end of this week

Thanks for the fix! :) 7f71912a680ef3aa


Bump reqs

Mainly adapting to both older runez 4.*, and newer upcoming 5.0

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9630db9) 99.65% compared to head (f511273) 99.80%.
Report is 2 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   99.65%   99.80%   +0.14%
==========================================
  Files          12       12
  Lines        2018     2025       +7
==========================================
+ Hits         2011     2021      +10
+ Misses          7        4       -3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Helper to set multiple keys (props / attrs / event props) at the same time

Sometimes people want an easier way to set multiple props from the same signal, like this:
      svg.line(
          svg.x1 <-- signal.map(_.x1),
          svg.y1 <-- signal.map(_.y1),
          svg.x2 <-- signal.map(_.x2),
          svg.y2 <-- signal.map(_.y2),
      )

Currently the easiest way to abstract over this is something like:
def coordsFromRect(signal: Signal[Rect]) = List(
  svg.x1 <-- signal.map(_.x1),
  svg.y1 <-- signal.map(_.y1),
  svg.x2 <-- signal.map(_.x2),
  svg.y2 <-- signal.map(_.y2)
)
svg.line(
  coordsFromRect(signal)
)

But that only helps if you need to do this a lot for the same data type / props.

We could potentially have some convenience methods for this, for example something like this:
svg.line(
  multiKey(svg.x1, svg.y1, svg.x2, svg.y2) <-- signal.map(v => (v.x1, v.y1, v.x2, v.y2))
)

I feel like I've seen a multi-setter like this somewhere (Laminext perhaps?) but can't find it right now.
One complication is that such an API should support mixing different kinds of keys (attrs, props, style props). Style props accept V | String, not just V, unlike other types of props, so would need special handling.
Ideally we would design an API that keeps a localized "map" of keys and values (e.g. (svg.x1 -> v.x1, ...), instead of splitting them into two separate "parallel arrays" like in the syntax above, because that way it's too easy to accidentally send the value to the wrong prop.
At the same time, such a map-based API would need to prevent the changes in the list of properties to keep things simple and avoid dealing with issues similar to #89. So, we could do something like:
svg.line(
  multiKey(signal)(
    svg.x1 <-- _.x1,
    svg.y1 <-- _.y1,
    svg.x2 <-- _.x2,
    svg.y2 <-- _.y2
  )
)

And we would need N variations of that method for different arities. But at least it easily takes care of style props.
Not sure I like this exact syntax, but it does work technically, and I do want some arrows in it to indicate reactive bindings.
Lastly, I guess another approach is some kind of derivation, but I think I'd rather not have such magic in the core library, and I from my understanding, it wouldn't actually work very well in this case as the DOM props are relatively loosely typed.

Consider similar syntax for writing to multiple observers, e.g.
multiObserve(chosenFileSignal)(
  _._1 --> CompilePage.knownFileName,
  _._2 --> CompilePage.fileContents
)

Unlike other Observer.combine / contraObserve options, this does not need type ascriptions, which is nice.
Discussion on discord


Add assetsExt rpc definitions

Summary
Add free balance rpc definition for assetsExt
Checklist

[x] Add description

make a commit to help with the prettier issue @KarishmaBothara, but there are some failed tests

make a commit to help with the prettier issue @KarishmaBothara, but there are some failed tests

I will check


Resurrected CompactionDriverTest resolving TODO in PreDeleteTable

The TODO asked if the the delete marker in ZooKeeper was still being used / tested. It is still being used by the CompactionDriver. However, the CompactionDriverTest class was deleted at some point which tests it. I resurrected and fixed the test.

I resurrected and fixed the test.

When was this removed?

I resurrected and fixed the test.

When was this removed?

I'm not sure. I think it exists in main, so it must have been removed as part of development in elasticity for some reason.

CompactionDriverTest was removed in ff5148a8c65d6ffa036e82330fa42378fc5dd9af


ICFAR-267 XConf OSS build failure

updated google and angular match libraries

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


1.3: Remove the Codeowners file.

To do not trigger reviews from all teams in backpors,keep the CODEOWNERS
file only to Janitor teams.
Signed-off-by: Eloy Coto<EMAIL_ADDRESS>

This change is

test-me-please

test-missed-k8s

This can be merged; no tests should fail due to this change, though, so the failures should be analyzed.

Filed #6036 to track the build failure.

I thought we usually leave the api codeowners in place for commits like this, to ensure that if API changes are made unintentionally that we catch these before breaking a micro release?


added missing promise package

When I called the .parse() function the callback was never triggered, after further investigating the problem:
In parser.js:94:
Promise.all(requestPromises).then(function onFulfilled(results) {..
requestPromises is an empty array, as I only tried with css local file paths. But this should still trigger .then().
But with my setup this was not working, after overriding the default promise package, it works perfect.

Coverage increased (+0.005%) to 97.938% when pulling 305f131e58183eab508573a7ca01bc4679ffa589 on woutvdd:master into d3d392ad8222b140f944746e5f7b3f9afc4902cb on t32k:master.


Allow batch-mark-files-as-viewed "toggle all with alt-click" on checkbox form

Fixes #4155

@fregante it works can you give a it a better title?

@sindresorhus can you help me with a better title?

Does this work? The form doesn’t have a checked attribute

yes!

Ohh I see what it’s doing. The check happens on the form, but the returned selector is still the checkbox’

Untested

Tested working correctly


mantle: a general way of globally specifying channel or version

Since the docker 1.12 profile was removed in Edge, many kola tests started to fail to run, because of the missing docker 1.12 profile. Ideally we should be able to make a different set of profiles for each channel. Unfortunately the current Jenkins pipeline is not able to do that. It takes into account only flatcar-master branch.
For now we work around the specific issue by skipping tests for Edge. https://github.com/flatcar-linux/mantle/pull/61.
In the long run, however, in mantle, we should make a general way of globally specifying channel or version numbers, so that individual tests can selectively run based on the channel or versions.

Had a quick sync with @sayanchowdhury on this - a good way to achieve the objective would be to use separate mantle branches for Alpha, Beta, Stable and Edge, respectively.

That won't work because we only build mantle once and then it is used for various channels. I don't understand why I would need to recompile kola each time I want to run a test for a different version.

The tests in kola are already annotated with distros and platforms they run on. Why not make another annotation for the channel? The original idea here was to have this checked at runtime by looking at the contents of the image. But we can even simplify this and introduce a command line parameter for the channel and have the test filter handle this before the tests are run.

I guess it depends on the actual amount of differences between any given channel (e.g. Edge vs. Stable). Both approaches have pros and cons.
I agree that distinguishing at the test execution level has the benefit of implementing coverage for all channels in the same file / branch.
On the other hand, if we need to update tests to cover new features, using separate channels would enable us to transition updated tests through Alpha -> Beta -> Stable alongside the actual updated packages.

Besides the efforts to reorganize how Jenkins runs mantle, it is also error-prone when running kola manually if people need to be aware of rebuilding each time with the correct branch.

Here you can see how tests are annotated to run only on cl (Container Linux) and not on a certain platform: https://github.com/flatcar-linux/mantle/blob/flatcar-master/kola/tests/docker/torcx_docker_flag.go#L55 We could use the same scheme to define channels or even versions as requirements for a test.

I did not mean create separate branches rather create an argument --channel which would help us achieve the same.


Make requirement fulfiller work with copy/paste

That was fast :+1:

Thanks for the patch :o)

Thanks for the good work!


Having LOTS of issues

This is probably just on behalf that i lack a few brain cells but i keep getting an error in designer.
NOTE: when i build the program it does work as should, the skeet menu does pop up.

but like i mentioned, the designer is having a meltdown.

idk if im referencing the project right. i installed the pkg using the cmd. then i compiled the source and referenced the DLL. then after changing form1 to skeetForm (and putting using skeetui;) i just get this error.

idk if im referencing the project right. i installed the pkg using the cmd. then i compiled the source and referenced the DLL. then after changing form1 to skeetForm (and putting using skeetui;) i just get this error.


Tests with mock server, parsing from .pcap file

Add tests for mocking server
Add tests for parsing responses from .pcap file (path to the file must be specified in the PCAP_TEST_FILE_PATH environment variable)

You've accidentally pushed files from dist-newstyle directory.
You can add the following gitignore to your project root to avoid that in the future.
.gitignore
dist-newstyle/

Please don't push the .gitignore file itself though.

You've accidentally pushed files from dist-newstyle directory.
You can add the following gitignore to your project root to avoid that in the future.
.gitignore
dist-newstyle/

Please don't push the .gitignore file itself though.

Oh, my bad, i've just update


Back testing for old trades

Read trades from a discord channel and back test for reliability at a user level.

Hi Akarsh,
To clarify, what do you mean by back test for reliability?
Are you referring to pulling historical text signals from Discord and running them against a text parser?
I am not currently working on AutoTrader but would like to understand in case I start to extend it.
Thanks

Hi Ray,
You are rite, the intension was to test historical text signals. I also wanted to help you implementing spreads with the AutoTrader.
Thanks


JSON API for LARAVEL

What package do you use on Laravel for handling JSON API specs suported by sarala ?

@robsontenorio
package [WIP] https://github.com/sarala-io/laravel-companion
This might help you [Laravel + Vuejd Saral Demo App] (https://github.com/sarala-io/laravel-vuejs-demo)


Integrate Authorino with KServe (kserve/modelmesh)

/kind feature
Describe the solution you'd like
[A clear and concise description of what you want to happen.]
Integrate Authorino with KServe (kserve/modelmesh)
This ticket is for tracking purpose.

https://github.com/opendatahub-io/opendatahub-operator/issues/614
https://github.com/opendatahub-io/opendatahub-operator/issues/496
https://github.com/opendatahub-io/opendatahub-community/issues/97

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Migrated to:

https://issues.redhat.com/browse/RHOAIENG-1085
https://issues.redhat.com/browse/RHOAIENG-1086


Humanize last comment datetime

Don't forget to pip install -r requirements.txt.

Coverage increased (+0.04%) to 30.564% when pulling aa9e06085cb2e4e51f387c69a53e69876ba832de on calixteman:humanize_last_comment into f1c4ea1bdf3c0a6420adc8caa67b78f757cfa96a on mozilla:master.


Update to work with upcoming<EMAIL_ADDRESS>

With these changes I think we should move this library to 1.0 - ping @typerandom for thoughts?

@robertjd Yes, I think that we could do that.

All issues are merged. Closing issue.


Refactor STAREPandas, STAREMaster, and STAREMaster_py to rationalize products

@NiklasPhabian

STAREMaster_py - implement STAREPandas-like user-defined granule plugin


Implemented some improvements mentioned in #97

Summary of changes:

Changed the base class for formatter to TextOutputFormatter/TextInputFormatter
Moved the serialization logic to WriteResponseBodyAsync/ReadRequestBodyAsync
Changed input formatter to use async method
Added unit tests.

It's very helpful! I hope @neuecc will approve your PR soon.


refactor: Icons

As Windows menu now support icons, It’s the right time to start working on a refactor for all the icons required in tao.
The main objective is to align all icons (tray, menu, window)  to use our Icon struct for all platforms.
We need to think how we can align system tray icons linux (path and vector of bytes)

We also need to think how we can make the tauri life easier.
Moving tauri away from the JS api (icons) , will really help.
Did we need to make any changes inntao?

I forgot about this issue, but #328 took care of this


Error: SAVEPOINT trx2; - No mock handler found

When I'm using nested transactions I get the following error:
Error: SAVEPOINT trx2; - No mock handler found
I tried adding 'SAVEPOINT' to transactionCommands without success.

I need a simple reproduction code.

Here is a unit test with the error
  it('should support nested transactions', async () => {
    tracker.on.insert('table_name').responseOnce(1);
    tracker.on.delete('table_name').responseOnce(1);

    await db.transaction(async (trx) => {
      await db('table_name').insert({ name: faker.name.firstName() }).transacting(trx);
      await trx.transaction(async (innerTrx) => {
        await db('table_name').delete().where({ name: faker.name.firstName() }).transacting(innerTrx);
      });
    });

    expect(tracker.history.insert).toHaveLength(1);
    expect(tracker.history.delete).toHaveLength(1);
  });

I'm wondering if nested transactions are an anti-pattern and I need to change my code to not have them. I didn't know about the .transacting() method so I'm going to try to refactor my code to have a single transaction.

If knex allows it, it should work with mock-client as well.
I guess that it should be part of the transaction commands.

Added in v1.6.0, thank you for reporting this issue 🙏🏼


Adding Fritzing diagram to repo

Adding an example GreenPiThumb wiring and image to repo and referencing it in
the README.

Coverage remained the same at 80.1% when pulling 7d5e6c8bcd884d67270e722f9fe10ddfe32f8963 on mtlynch:fritzing-diagram into c0d072b03edace692049396a5d0b4939fdd3e044 on JeetShetty:master.

Coverage remained the same at 80.1% when pulling 72f3baefa2a5ef5e07d59c02f0b0fa8e43b80483 on mtlynch:fritzing-diagram into c0d072b03edace692049396a5d0b4939fdd3e044 on JeetShetty:master.


There should  be a common set of attributes for Event and EventSeries from different datasources

Event:

acronym ✓
lookupAcronym
eventId ✓
source ✓
title ✓
url ✓
year ✓
homepage
country
region
city
startDate
endDate
seriesId

EventSeries:

source
seriesId
acronym
lookupAcronym

ccUpdate --addLookupAcronym dblp
Starting adding lookup acronyms for dblp ...
Starting loading dblp computer science bibliography ...
Warning - using full /home/wf/.dblp/dblp.xml dataset ~9.1m records!
Warning - using full /home/wf/.dblp/dblp.xml dataset ~9.1m records!
loading dblp computer science bibliography took   7.9 s
adding lookup acronyms for dblpdblp: added lookupAcronym for 50248 events took  10.5 s


Provide a way to switch to different Myria instance

At the moment the Myria instance is hardcoded for a demo and there is no way to change it from the UI. It would be nice if there was an input element so that I can specify my custom Myria instance.

Addressed in #77

@dundalek Most definitely. We are currently working on a complete overhaul of how people get data into polestar and voyager. Stay tuned. In the meantime, I disabled loading from myria because of an issue with the popup. Please let me know if you need that feature.

Cool, new dataset loading sounds great. I can do without myria until it is ready.


MB-11321 - Add create service item move history event

Jira ticket for this change
Summary
This PR should add support for displaying approved standard service items in the move history.
Since these service items are created in the approved status when a shipment is approved, the move history event template should cover all service items created in the 'approveShipment' event.
Setup to Run Your Code

💻 You will need to use two separate terminals to test this locally.
Terminal 1
Start the UI locally.
make client_run

Terminal 2
Start the Go server locally.
make server_run

Additional steps

Access the office app as a TOO
Navigate to a move that is not yet approved (ex. locator 7MKYDR)
Approve the move with standard service items
Navigate to the move history page and verify that the standard service item approvals are displayed per the requirements in the story.

Verification Steps for Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.

Frontend

[ ] User facing changes have been reviewed by design.
[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] There are no new console errors in the browser devtools
[ ] There are no new console errors in the test output
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.

Screenshots

Messages

:book:
:link: MB-11321

  Generated by :no_entry_sign: dangerJS against a6264a98ee6520e9a8366ab341ba77d48e0d31f7


Auth is handled before the ratelimiter middleware

Describe the bug
Rate limiting (fail2ban) is usually used to prevent brute force auth attacks against a server. Wish offers both authentication and ratelimiting, but seems to call the auth handler first and then only calls the ratelimiter middleware if auth succeeds. Calling the rate limiter first produces the desired effect of preventing brute force auth attacks.
To Reproduce
s, err := wish.NewServer(
	wish.WithAddress(":2222"),
	wish.WithHostKeyPath(myHostKeyPath),
	wish.WithPasswordAuth(func(ctx ssh.Context, password string) bool {
		return password == "password"
	}),
	wish.WithMiddleware(
		ratelimiter.Middleware(ratelimiter.NewRateLimiter(1, 2, 1000)),
	),
)

In the above server, auth is always called - regardless of rate limits, and the ratelimiter Middleware is only called if auth succeeds (returns true).
Expected behavior
Rate limiting should happen before auth, perhaps via s.ConnCallback instead of middleware.

does the order matter? move middleware before WithPasswardAuth?

The order doesn't matter. The WithMiddleware writes to an array, but WithPasswordAuth (and the other auth methods) each write to a different struct variable inside the Server struct, which are processed before the Middleware.


Enhancement: Support decimals in [data-percentage] attribute

Is it possible to support decimals on the data percentage?  e.g  [51.4%]
There is no mention in the documentation ...

Hey @MaikelNait ,
thank you for your question/proposal.
Yes, it's possible, either as a data attribute as you fore-mentioned:

or as jQuery parameter:
$("#custom-color").percircle({
	percent: 64.5
});

However, I will leave the issue open for now, until I add a brief mention regarding decimal support on percentages.
Thank you!

Thanks a lot !   ☺
Miguel
From: Thodoris Bais<EMAIL_ADDRESS>Sent: Friday, August 19, 2016 4:55 PM
To: toubou91/percircle
Cc: Cubells Baeza, Miguel; Mention
Subject: Re: [toubou91/percircle] Enhancement: Support decimals in [data-percentage] attribute (#37)
Hey @MaikelNaithttps://github.com/MaikelNait ,
thank you for your question/proposal.
Yes, it's possible, either as a data attribute as you fore-mentioned:

or as jQuery parameter:
$("#custom-color").percircle({
percent: 64.5

});
However, I will leave the issue open for now, until I add a brief mention regarding decimal support on percentages.
Thank you!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/toubou91/percircle/issues/37#issuecomment-240964859, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AD0XKJTtg7duqKkHOzkKnzydn6CepNpkks5qhW9vgaJpZM4JoJ8a.


Fixing #1163 : Inconsistent Behaviour in http server : Big Integers are getting converted to float before storing thus losing their precision

Change description
When working with map[string]interface{} in Go, json.Marshal will automatically infer the data type for each element based on the interface{} type that we use.
However, in our case, json.Marshal is casting values incorrectly (e.g., casting integer values to float64), it may be due to Go’s internal handling of untyped constants and generic types within interface{}
To fix this, I've added an explicit check during unmarshalling of the JSON body in the request payload for int64 types.
I've also added a recursive unmarshalling to check for any such big integer values in nested JSON fields as well.
To ensure that json.Marshal preserves the original data types, I've enforced specific types in our map by using json.Number for numeric data types before marshaling again.
Lastly, instead of using a vanilla json.Unmarshal() at the end of the request map creation, the JSON decoder needs to be aware that it explicitly needs to use numbers, instead of using Go's default handling of the interface{} type.
Working
Request

Data set in DICE DB

Response from HTTP server

Hey @deydebaditya can we work onto closing this PR? Just a one linter change is required as discussed above and we are good to go! Thanks

Will work on it by tomorrow. Would need to change a bit if implementation
in the method body as well, since I’m serializing the json bytes back into
the map reference at the end. Like I said before, maps are reference types
as in the values to map keys are references definitely, but the actual map
object would still be passed by value in this method. Will make the
relevant changes.
On Tue, 12 Nov 2024 at 9:17 PM, Ashwin Kulkarni @.***>
wrote:

Hey @deydebaditya https://github.com/deydebaditya can we work onto
closing this PR? Just a one linter change is required as discussed above
and we are good to go! Thanks
—
Reply to this email directly, view it on GitHub
https://github.com/DiceDB/dice/pull/1227#issuecomment-2470887049, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACX7SWUKY425P3USK5XH33D2AIPHZAVCNFSM6AAAAABQ7TMNSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZQHA4DOMBUHE
.
You are receiving this because you were mentioned.Message ID:
@.***>


Stargate gRPC protos can not be used due to the missing dependency

As I already mentioned in the #1758, the Stargate .proto files from the grpc-proto project can not be used for code generation. I am hitting this already second time. The first time with the grpc perf tests and now with the Quarkus code-generation.
Step #5 - "build-java17": [INFO] --- quarkus-maven-plugin:2.8.0.Final:generate-code (default) @ sgv2-docsapi ---
Step #5 - "build-java17": google/rpc/status.proto: File not found.
Step #5 - "build-java17": query.proto:19:1: Import "google/rpc/status.proto" was not found or had errors.
Step #5 - "build-java17": query.proto:391:5: "google.rpc.Status" is not defined.
Step #5 - "build-java17": schema.proto:19:1: Import "query.proto" was not found or had errors.
Step #5 - "build-java17": schema.proto:59:12: "ColumnSpec" is not defined.
Step #5 - "build-java17": schema.proto:60:12: "ColumnSpec" is not defined.
Step #5 - "build-java17": schema.proto:61:12: "ColumnSpec" is not defined.
Step #5 - "build-java17": schema.proto:70:12: "ColumnSpec" is not defined.
Step #5 - "build-java17": schema.proto:71:12: "ColumnSpec" is not defined.
Step #5 - "build-java17": schema.proto:72:12: "ColumnSpec" is not defined.
Step #5 - "build-java17": schema.proto:73:12: "ColumnSpec" is not defined.
Step #5 - "build-java17": schema.proto:101:12: "TypeSpec.Udt" is not defined.
Step #5 - "build-java17": [INFO] ------------------------------------------------------------------------
Step #5 - "build-java17": [INFO] BUILD FAILURE
Step #5 - "build-java17": [INFO] ------------------------------------------------------------------------
Step #5 - "build-java17": [INFO] Total time:  15.538 s
Step #5 - "build-java17": [INFO] Finished at: 2022-04-13T09:39:11Z
Step #5 - "build-java17": [INFO] ------------------------------------------------------------------------
Step #5 - "build-java17": [ERROR] Failed to execute goal io.quarkus.platform:quarkus-maven-plugin:2.8.0.Final:generate-code (default) on project sgv2-docsapi: Quarkus code generation phase has failed: InvocationTargetException: Failed to generate Java classes from proto files: [/workspace/sgv2-docsapi/target/protoc-protos-from-dependencies

The reason is the missing google/rpc/status.proto: File not found file. Unfortunately this import is not implicit and those files are not available (only google/protobuf is). I am not sure how this compiles and how this even works, but I had to clone the api-common-protos repository and create a symbolic link locally to solve this like:
[10:49:34] ise:stargate <ise-1717-quarkus-bootstrap>$ ls -all grpc-proto/proto/
total 40
drwxrwxr-x 2 ise ise  4096 Apr  4 15:06 .
drwxrwxr-x 5 ise ise  4096 Apr  4 15:13 ..
-rw-rw-r-- 1 ise ise  1776 Apr  4 15:06 bridge.proto
lrwxrwxrwx 1 ise ise    57 Mar 23 10:50 google -> /home/ise/workspace/open-source/api-common-protos/google/
-rw-rw-r-- 1 ise ise 19319 Mar 28 11:16 query.proto
-rw-rw-r-- 1 ise ise  3984 Apr  4 15:06 schema.proto
-rw-rw-r-- 1 ise ise  1274 Mar 17 14:28 stargate.proto

However, this actually makes our protos not usable. The CI fails for me now on the Quarkus project. The only reason this "works" in other Stargate V2 projects is because the dependecy is not on the protos, but on the generated classes in the grpc-proto project. But this is not OK.
Furthremore, I check the the other grpc clients, as I was wandering how would this work there.. Well seems that all the clients are having their own copy of the proto files:

https://github.com/stargate/stargate-grpc-go-client/tree/main/proto
https://github.com/stargate/stargate-grpc-node-client/tree/main/proto

And those do not reference the google/rpc/status.proto at all. Seems that the version of the proto files in the clients is completely different from what's currently in Stargate. Which again feels wrong.
IMO this is a major issue and a major blocker for both us and users of the grpc protos.

I believe we can close this issue based on the availability of the techniques described in #1173.


[SDK] Get the preferred @encode string for MapKit types dynamically

On older OSs, CLLocationCoordinate2D was an anonymous struct with a typedef, which meant its Objective-C type encoding string was "{?=dd}" instead of "{CLLocationCoordinate2D=dd}". This incompatibility led to us rejecting casts from NSValues created with CLLocationCoordinate2Ds in Objective-C on older OSs because they didn't match the type encoding provided. Instead, we can try to create an NSValue the way the frameworks do, and see what its type encoding is. This is what SceneKit already does.
There's an extra wrinkle here because the convenience methods for encoding CLLocationCoordinate2Ds are actually added in MapKit rather than CoreLocation. That means that if someone's app just uses CoreLocation, we can't rely on those convenience methods to get the correct type encoding. In this case, the best thing we can do is just give up and use the static encoding.
This whole thing is indicative of a bigger problem, namely that NSValue normally doesn't try to validate types at all. However, Swift bridge casting really does want to distinguish, say, a CLLocationCoordinate2D from a CGPoint, and checking the NSValue encode string was a way to do that. But this shows that it's still not safe to assume that's consistent against everything in a process even if they're all using @encode on the real struct (or the Swift equivalent), because the different parts of the process may have been compiled against different SDKs.
This change does not attempt to solve that problem.
Finishes rdar://problem/44866579. Follow-up to #19634.

@swift-ci Please test

Build failed
Swift Test OS X Platform
Git Sha - 0f4b6999eb58f342720c0ce614b70a23e2f554f4

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - 0f4b6999eb58f342720c0ce614b70a23e2f554f4

Build failed
Swift Test OS X Platform
Git Sha - 0f4b6999eb58f342720c0ce614b70a23e2f554f4


Move repo from connorads to org

https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/transferring-a-repository
Orgs are free https://github.com/pricing
Might need to update some build stuff?

Nah it can stay for now 🤷♂


bot.moveTo problem.

This function working good? I try port moceTo from rattlesnake client. But both not working . : /

@l3mpik it works for about 80%.
just be carefull to add case ankathede = 0 // you cannot divide by 0
some snkaes (about 10%) seem to move Math.PI/2 wrong, don't get why this happens.

I thing some "bots" use packet G and other use g . Maybe this is problem. I don't have expirence with packets and websocket ( just little ) . Btw. Thanks for client. : )

@l3mpik ok, i will add G tomorrow. thanks for the note


Add Gradle Usage to README

added a gradle usage section to README w/ a link to a working example.

resolves #16

Coverage remained the same at 92.558% when pulling 4cdff4edbe65fb887b5223e73b29d8f2e0ec2a04 on paegun:pae/doc-gradle-usage into 2566c6b817414f13690504d2b75d7426d1f91d74 on astefanutti:master.

Coverage remained the same at 92.558% when pulling 9ae156ba54f82fb8949207f4dc65bf5e205ea908 on paegun:pae/doc-gradle-usage into 2566c6b817414f13690504d2b75d7426d1f91d74 on astefanutti:master.

I've just merge the PR. Thanks a lot!


Android SDK - Initializing Style for Marker returns always false

I use marker.setStylingFromString("{ style: 'points', color: 'white', size: [50px, 50px], order: 2000, collide: false }"); .. it returns always false, meaning the style was not accepted.
I tried a lot of different styling strings, it never got accepted. For the MapData I used a scene.yaml file to put in the wanted style, for a Marker this doesn't seem to be working? I am out of options here, maybe you know the problem.
Here are way more style strings, I tried all of them but with no luck:
        //String polygonStyle = "{ style: 'polygons', color: '#06a6d4', width: 5px, order: 2000 }";
        //String pointStyle = "{ style: 'points', color: 'white', size: [50px, 50px], order: 2000, collide: false }";
        //boolean ye = ownLocation.setStylingFromString("{ style: 'points', color: 'white', size: [50px, 50px], order: 2000, collide: false }");
        // ownLocation.setStylingFromString("{ style: 'points', color: 'white', size: [50px, 50px], order: 2000, collide: false }");
        //boolean ye = ownLocation.setStylingFromString("{ style: 'points', color: 'white', size: [[12, [40px,59px]]], collide: false, anchor: 'top', interactive: false }");
        //ownLocation.setStylingFromString("{ style: 'points', size: [27px, 27px], order: 2000, anchor: top, color: white }");
        //ownLocation.setStylingFromString("layers.touch.point.draw.icons");

RESULT:
Should return true and the markers should be visible. Why does it return false?
EXPECTED RESULT:
Always returns false and markers are not visible.
ENVIRONMENT:
0.10 version of tangram es

bump

The problem disappeared after I updated to 0.11.1!


rename FIPS exclude files for openjdk tests

We will support multiple FIPS versions. The existing FIPS exclude file for openjdk tests ProblemList-fips.txt will be renamed to ProblemList-FIPS140_2.txt in the extension repos. AQA repo logic will be updated as well.
https://github.com/ibmruntimes/openj9-openjdk-jdk8/blob/openj9/jdk/test/ProblemList-fips.txt
https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/openj9/test/jdk/ProblemList-fips.txt
https://github.com/ibmruntimes/openj9-openjdk-jdk17/blob/openj9/test/jdk/ProblemList-fips.txt
https://github.com/ibmruntimes/openj9-openjdk-jdk21/blob/openj9/test/jdk/ProblemList-fips.txt
https://github.com/ibmruntimes/openj9-openjdk-jdk/blob/openj9/test/jdk/ProblemList-fips.txt
https://github.com/adoptium/aqa-tests/blob/45537f254b642e0a6f5424c7bd378f711d845290/openjdk/openjdk.mk#L196C1-L198
ProblemList-FIPS140_3_OpenJcePlus.txt is just a place holder at the moment. It will be added to all extension repos.

FYI @annaibm all FIPS exclude file for openjdk tests ProblemList-fips.txt aew renamed to ProblemList-FIPS140_2.txt. Please rebase your PR.

Thanks @LongyuZhang . All PRs are delivered. Close this issue.


wip: normalized nft slice part 2

Description

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #
Risk

Testing

Engineering

Operations

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #4563

PR #4574

PR #4582

PR #4575

PR #4596

PR #4597   👈

This comment was auto-generated by Graphite.


(PUP-6686) Improve how Timespan parses and stringifies fractions of second (%L and %N)

This PR aims to improve how a Timespan parses fractions. Instead of just treating the parsed value as milliseconds or nanoseconds, it will consistently be treated as fractions of a second. This is more intuitive and also aligned with how the Ruby implementation of strptime() does this (internally used as parser for Timestamp).
The PR also fixes the default format so that it contains fractions to avoid loss of precision when converting to and from string. Brought together, those changes made the string output more compact (default format strips trailing zeroes) and hence, more suitable to use a the default representation than the hash.

CLA signed by all contributors.


Authentication for changing values

Is your feature request related to a problem? Please describe.
It's great to have the EVCC Dashboard available to everyone. However, it's possible for everyone to change the charging profiles and limits too.
Describe the solution you'd like
It'd be great to lock these features. Changing these values should only be possible when authenticated with the password provided.
Describe alternatives you've considered
Restrict access to the entire EVCC dashboard (with something like HTTP Basic Auth)

We already have the account system (admin password) in place. We could provide a user setting to require authentication for all endpoints. Right now, it's only required for accessing logs or changing configuration.
Can you be more specific on what you would like protected or not? Read-only mode? Should it be allowed for everyone to see charging situation and sessions/stats?

Thanks for the quick response. Yes, it'd be great to lock more functions behind the admin password.
Basically, a read-only mode would be great.
I'd love to see the configuration of  chargings protected. Like changing charging limits, the profiles (off/solar/fast), changing the wallbox settings (phases, current).

Ok, thanks for your clarification. Implementing this should not be too complicated. However, we've a lot of other topics right now.
For the meantime, the way to go would be to add basic auth via a reverse proxy.


Add Pytest support and first unit tests

Adds first unit tests to the Nucleus python client using Pytest. These tests can be used to test both the Python client and the actual Nucleus REST endpoints. This PR includes two basic tests to get things started. After we merge this, going forward changes to the Python API (or REST backend changes that affects the behavior of the Python API) should include unit tests.
To be able to run unit tests, you must export the NUCLEUS_PYTEST_API_KEY environment variable with a valid Nucleus API key. If you don't do this you will get an informative error message. I recommend that Nucleus engineers add export NUCLEUS_PYTEST_API_KEY=[your_api_key] to your .zshrc or .bashrc going forward.
To run all tests (after your API key env var is set), from the root of the repo run:
pytest
To run tests in just one file, e.g. test_datasets.py, from the root of the repo run:
pytest tests/test_datasets.py
To run only a single test, you append ::[test_function_name] to the end of the previous command, e.g.:
pytest tests/test_datasets.py::test_dataset_append
These tests make actual requests to our backend. Here and going forward, tests should be written in a way such that they "leave no trace" when they all run successfully. This can usually be accomplished with Pytest fixtures that define setup and teardown procedures. If you ever want to inspect intermediary state changes made by the tests in the Nucleus web UI, I recommend you add a breakpoint to the test you're working on (import pdb; pdb.set_trace()) sometime between setup and teardown, and visit your Nucleus dashboard to poke around. Doing this I already found one bug in the web UI: if you add a dataset item with the following metadata to a dataset, then click on that dataset in the UI, no results are shown despite the dataset having items:
metadata={
    'made_with_pytest': True,
    'example_int': 0,
    'example_str': 'hello',
    'example_float': 0.5,
    'example_dict': {
        'nested': True,
    },
    'example_list': ['hello', 0, False],
}

Need to add pytest to requirements.txt before merging. I am trying to do it automatically with pigar to ensure that still works after this PR, but running into this error when I run pigar on this branch. Any tips @srikanth-scale / @Nastia39?
(venv) ➜  nucleus-python-client git:(user/rkaplan/add-pytest) ✗ pigar
00:23:01 parse /Users/russell.kaplan/nucleus-python-client/venv/lib/python3.6/site-packages/six.py:719 failed: SyntaxError('invalid syntax', ('<unknown>', 1, 11, 'exec _code_ in _globs_, _locs_\n'))
00:23:02 parse /Users/russell.kaplan/nucleus-python-client/venv/lib/python3.6/site-packages/py/_builtin.py:130 failed: SyntaxError('invalid syntax', ('<unknown>', 4, 14, '    raise cls, val, tb\n'))
00:23:03 parse /Users/russell.kaplan/nucleus-python-client/venv/lib/python3.6/site-packages/gevent/_util_py2.py:16 failed: SyntaxError('invalid syntax', ('<unknown>', 1, 11, 'exec _code_ in _globs_, _locs_\n'))
00:23:04 parse /Users/russell.kaplan/nucleus-python-client/venv/lib/python3.6/site-packages/gevent/testing/six.py:31 failed: SyntaxError('invalid syntax', ('<unknown>', 1, 9, 'exec code in globs, locs\n'))
00:23:04 parse /Users/russell.kaplan/nucleus-python-client/venv/lib/python3.6/site-packages/pip/_vendor/six.py:699 failed: SyntaxError('invalid syntax', ('<unknown>', 1, 11, 'exec _code_ in _globs_, _locs_\n'))
00:23:05 parse /Users/russell.kaplan/nucleus-python-client/venv/lib/python3.6/site-packages/pip/_vendor/urllib3/packages/six.py:699 failed: SyntaxError('invalid syntax', ('<unknown>', 1, 11, 'exec _code_ in _globs_, _locs_\n'))
00:23:05 parse /Users/russell.kaplan/nucleus-python-client/venv/lib/python3.6/site-packages/jsonschema/_reflect.py:49 failed: SyntaxError('invalid syntax', ('<unknown>', 2, 34, '        raise exception.__class__, exception, traceback\n'))
00:23:06 parse /Users/russell.kaplan/nucleus-python-client/venv/lib/python3.6/site-packages/pluggy/callers.py:11 failed: SyntaxError('invalid syntax', ('<unknown>', 3, 14, '    raise cls, val, tb\n'))
00:23:06 parse /Users/russell.kaplan/nucleus-python-client/venv/lib/python3.6/site-packages/urllib3/packages/six.py:753 failed: SyntaxError('invalid syntax', ('<unknown>', 1, 11, 'exec _code_ in _globs_, _locs_\n'))
00:23:06 parse /Users/russell.kaplan/nucleus-python-client/venv/lib/python3.6/site-packages/setuptools/_vendor/six.py:699 failed: SyntaxError('invalid syntax', ('<unknown>', 1, 11, 'exec _code_ in _globs_, _locs_\n'))
00:23:06 parse /Users/russell.kaplan/nucleus-python-client/venv/lib/python3.6/site-packages/pkg_resources/_vendor/six.py:699 failed: SyntaxError('invalid syntax', ('<unknown>', 1, 11, 'exec _code_ in _globs_, _locs_\n'))
Traceback (most recent call last):
  File "/Users/russell.kaplan/.pyenv/versions/3.6.5/lib/python3.6/site-packages/pigar/core.py", line 406, in is_stdlib
    module_info = imp.find_module(name)
  File "/Users/russell.kaplan/.pyenv/versions/3.6.5/lib/python3.6/imp.py", line 297, in find_module
    raise ImportError(_ERR_MSG.format(name), name=name)
ImportError: No module named 'ctypes.wintypes'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/russell.kaplan/.pyenv/versions/3.6.5/bin/pigar", line 8, in <module>
    sys.exit(main())
  File "/Users/russell.kaplan/.pyenv/versions/3.6.5/lib/python3.6/site-packages/pigar/__main__.py", line 169, in main
    args.comparison_operator[0], args.ref_comments
  File "/Users/russell.kaplan/.pyenv/versions/3.6.5/lib/python3.6/site-packages/pigar/core.py", line 66, in generate
    self._package_root, self._ignores, self.installed_pkgs
  File "/Users/russell.kaplan/.pyenv/versions/3.6.5/lib/python3.6/site-packages/pigar/core.py", line 317, in parse_packages
    if is_stdlib(name) or is_stdlib(name.split('.')[0]):
  File "/Users/russell.kaplan/.pyenv/versions/3.6.5/lib/python3.6/site-packages/pigar/core.py", line 394, in _wrapper
    checked[name] = func(name)
  File "/Users/russell.kaplan/.pyenv/versions/3.6.5/lib/python3.6/site-packages/pigar/core.py", line 410, in is_stdlib
    importlib.import_module(name)
  File "/Users/russell.kaplan/.pyenv/versions/3.6.5/lib/python3.6/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 994, in _gcd_import
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/Users/russell.kaplan/.pyenv/versions/3.6.5/lib/python3.6/ctypes/wintypes.py", line 20, in <module>
    class VARIANT_BOOL(ctypes._SimpleCData):
ValueError: _type_ 'v' not supported


Generate random cache subdirectory for dataset job runner

Generate random cache subdirectory for dataset job runner.
This might fix the stale file handle error:
OSError: [Errno 116] Stale file handle

See: https://huggingface.co/datasets/tapaco/discussions/4

OK, as you prefer... :smile:


xADKDSKey: Create new DSC Resource: xADKDSKey

Renamed to proper naming standard and add most test cases
Finished test cases
Fixed styling issues and add README
updated readme

Pull Request (PR) description
Helps manage KDS Root keys in Active Directory
This Pull Request (PR) fixes the following issues
Closes https://github.com/PowerShell/xActiveDirectory/pull/165
Task list

[x] Added an entry under the Unreleased section of the change log in the README.md.
Entry should say what was changed, and how that affects users (if applicable).
[x] Resource documentation added/updated in README.md.
[x] Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help.
[x] Comment-based help added/updated.
[x] Localization strings added/updated in all localization files as appropriate.
[x] Examples appropriately added/updated.
[x] Unit tests added/updated. See DSC Resource Testing Guidelines.
[x] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[x] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

Codecov Report

Merging #256 into dev will increase coverage by <1%.
The diff coverage is 100%.

@@         Coverage Diff          @@
##            dev   #256    +/-   ##
====================================
+ Coverage    86%    87%   +<1%
====================================
  Files        19     20     +1
  Lines      1741   1842   +101
  Branches     11     11
====================================
+ Hits       1513   1614   +101
  Misses      217    217
  Partials     11     11

@johlju I think this is ready for initial review. I still haven't reviewed it myself or done one last integration test, but should be good enough for a first look.

Cleaned up the code quite a bit, made quite a few changes. It should be good for another review if you have with the exception of the test cases. I haven't really touched those too much, so you can skip over those for now. I may not be able to get back to this for a little bit.
Still need to:

[ ] Create additional test cases for new functions

[ ] Fix the localization messages

[ ] Update README with additional information

Merged the localization helper functions.

@kungfu71186 Impressive work on this one! It looks close to be ready for merge! 🙂

@kungfu71186 This looking good to me. You may fix additional stuff in another PR? I couldn't help you resolve the conflicts in this one, since we need to move the change log entry to the CHANGELOG.md. Can you resolve the conflicts in this one, and I will merge once the test passes again! 🙂

@johlju yeah, I'll take care of the conflicts. What else was outstanding?

Nothing outstanding. You had thoughts of improving the tests, but that can be another PR. If the tests passed now I will merge. :)

Oh yeah. That will be for MSA and this one. Now that I know you can do nested context. But yeah, as of now the tests are fine, probably not the cleanest though :)

Oh yeah. That will be for MSA and this one. Now that I know you can do nested context. But yeah, as of now the tests are fine, probably not the cleanest though :)

You did an awesome job on them! If the work, then its good enough. :små

Ah, sorry closed by mistake. Not sure what key combination I pressed to do that. :/


Multiple entries for same channel id

Hi, can you explain why I see two entries for each channel id? What is the difference between these?

You're using a mesh wireless router?  If so, that's why.

Ahh, okay, that is it. Thank you.


Enable device flow disabled test

Enable device flow existing test

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/2087544012

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/2087544012
Status: success


Web socket errors to Vivint API

Before upgrading to latest version, I restarted HA for an unrelated reason. Upon restart, HA was unresponsive for nearly 9-10 minutes. Once it was responsive again, the logs showed many errors trying to setup the initial connection to Vivint and updating Vivint sensors via the api. There was a 500 second timeout setting up the connection, which also locked up the rest of HA for that time period. I tried installing the latest version, deleted the current integration, restarted HA, and reinstalled the Vivint integration. Same result. I had to disable the integration completely for the time being.
Traceback for some of the socket errors:
Logger: homeassistant.components.sensor
Source: custom_components/vivint/init.py:167
Integration: Sensor (documentation, issues)
First occurred: 9:46:10 PM (2 occurrences)
Last logged: 9:50:32 PM
Error adding entities for domain sensor with platform vivint
Error while setting up vivint platform for sensor
Traceback (most recent call last):
File "/usr/local/lib/python3.8/site-packages/aiohttp/connector.py", line 969, in _wrap_create_connection
return await self._loop.create_connection(*args, **kwargs)  # type: ignore  # noqa
File "/usr/local/lib/python3.8/asyncio/base_events.py", line 1025, in create_connection
raise exceptions[0]
File "/usr/local/lib/python3.8/asyncio/base_events.py", line 1010, in create_connection
sock = await self._connect_sock(
File "/usr/local/lib/python3.8/asyncio/base_events.py", line 924, in _connect_sock
await self.sock_connect(sock, address)
File "/usr/local/lib/python3.8/asyncio/selector_events.py", line 496, in sock_connect
return await fut
File "/usr/local/lib/python3.8/asyncio/selector_events.py", line 528, in _sock_connect_cb
raise OSError(err, f'Connect call failed {address}')
TimeoutError: [Errno 110] Connect call failed ('<IP_ADDRESS>', 80)
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 317, in async_add_entities
await asyncio.gather(*tasks)
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 385, in _async_add_entity
device_info = entity.device_info
File "/config/custom_components/vivint/init.py", line 167, in device_info
"manufacturer": self.device.manufacturer,
File "/usr/local/lib/python3.8/site-packages/vivintpy/devices/init.py", line 86, in manufacturer
self.get_zwave_details()
File "/usr/local/lib/python3.8/site-packages/vivintpy/devices/init.py", line 134, in get_zwave_details
result = pool.submit(asyncio.run, self.get_zwave_details_async()).result()
File "/usr/local/lib/python3.8/concurrent/futures/_base.py", line 439, in result
return self.__get_result()
File "/usr/local/lib/python3.8/concurrent/futures/_base.py", line 388, in __get_result
raise self._exception
File "/usr/local/lib/python3.8/concurrent/futures/thread.py", line 57, in run
result = self.fn(*self.args, **self.kwargs)
File "/usr/local/lib/python3.8/asyncio/runners.py", line 44, in run
return loop.run_until_complete(main)
File "/usr/local/lib/python3.8/asyncio/base_events.py", line 616, in run_until_complete
return future.result()
File "/usr/local/lib/python3.8/site-packages/vivintpy/devices/init.py", line 141, in get_zwave_details_async
result = await self.vivintskyapi.get_zwave_details(
File "/usr/local/lib/python3.8/site-packages/vivintpy/vivintskyapi.py", line 401, in get_zwave_details
async with session.get(
File "/usr/local/lib/python3.8/site-packages/aiohttp/client.py", line 1117, in aenter
self._resp = await self._coro
File "/usr/local/lib/python3.8/site-packages/aiohttp/client.py", line 520, in _request
conn = await self._connector.connect(
File "/usr/local/lib/python3.8/site-packages/aiohttp/connector.py", line 535, in connect
proto = await self._create_connection(req, traces, timeout)
File "/usr/local/lib/python3.8/site-packages/aiohttp/connector.py", line 892, in _create_connection
_, proto = await self._create_direct_connection(req, traces, timeout)
File "/usr/local/lib/python3.8/site-packages/aiohttp/connector.py", line 1051, in _create_direct_connection
raise last_exc
File "/usr/local/lib/python3.8/site-packages/aiohttp/connector.py", line 1020, in _create_direct_connection
transp, proto = await self._wrap_create_connection(
File "/usr/local/lib/python3.8/site-packages/aiohttp/connector.py", line 975, in _wrap_create_connection
raise client_error(req.connection_key, exc) from exc
aiohttp.client_exceptions.ClientConnectorError: Cannot connect to host openzwave.net:80 ssl:default [Connect call failed ('<IP_ADDRESS>', 80)]

This should be fixed with 2021.3.1

I had previously attempted an update from a fresh install with the same result. What finally seemed to work was logging into my API user in the Vivint mobile app, then signing out of all devices. Once I did that, the integration started working again. My best guess according to the log messages is that a web socket connection was left open for that api user and the integration could not establish a new connection.
If this is the case, then I would still consider this an issue. If the web socket create attempt fails, then it should not attempt to update any of the Vivint devices. Each device update took 10 seconds to timeout, and it seems the attempts were in serial. That left HA unresponsive during that period.
Let me know if you need to see any other logs.

The logs you posted here all directly point to an issue with the way I was retrieving Z-Wave device details for such devices connected to the panel.

TimeoutError: [Errno 110] Connect call failed ('<IP_ADDRESS>', 80)

That's the IP address of the openzwave website I was using for device lookup. If you try to go to that address, or ping it even, you'll see that it is taking a long time or down altogether now.

File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 317, in async_add_entities
await asyncio.gather(*tasks)
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 385, in _async_add_entity
device_info = entity.device_info
File "/config/custom_components/vivint/init.py", line 167, in device_info
"manufacturer": self.device.manufacturer,
File "/usr/local/lib/python3.8/site-packages/vivintpy/devices/init.py", line 86, in manufacturer
self.get_zwave_details()

Here, again, you'll see it is when trying to save the device_info, which does a lookup for manufacturer, which, if Z-Wave, would try to get the information from openzwave and hang.
I knew it might be a potential problem in the future, and have been thinking of ways to get around it, but haven't done so yet. So for now, Z-wave devices will just show an unknown manufacturer and model until I get that updated.

Makes sense. Thanks for the explanation. I think there was still some web socket connection issue going on, but those logs have cleared after I signed out of all devices. If the issue pops up again, I'll make sure to enable more verbose logging and update this issue.

I'm gonna close this issue. But if you do see some websocket stuff, open up a new one so I can help track it there. Thanks, @mat1583!


Update chart pipeline to enable chart update flow with manual version increment

Description
Adjust the pipeline used in the chart repository to support he future chart update process:

The PR pipeline needs to ensure that a chart version is incremented on a chart update, the pipeline should otherwise fail.
Otherwise the PR pipeline should continue to check the quality of the chart by running helm unittests and helm lint as today
The main pipeline should not need to update/increment any version numbers, it needs to lint/test the chart and then push the chart to the repository with the defined version/appversion of the chart

This is complete


Azure Authentication - Configurable Resource ID

Hi,
It looks like for Azure MSI Authentication, Spring requests the JWT token from this URL: "http://<IP_ADDRESS>/metadata/identity/oauth2/token?resource=https://vault.hashicorp.com&api-version=2018-02-01". It seems that this is not configurable.
Would it be possible to make the Vault resource ID parameter configurable to something other than the value "https://vault.hashicorp.com"? This might be needed in the case of having multiple Vault resources as their IDs must be unique.

Good proposal. Do you want to submit a pull request?

Actually I guess the change needs to be made over in spring-vault instead. I'll open an issue over there instead.


webpack_require.e is undefined in webpackAsyncContext

Ionic version:  (check one with "x")
[ ] 1.x (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[ x] 3.x
I'm submitting a ...  (check one with "x")
[x ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:

I don't strictly know how to reproduce this but it's not behaving in a reproduceable way. I have an app that I just started implementing IonicPage. I have 3 page components that are now using the IonicPage decorator. I went to add a 4th page, and after including the new module in my app.module.ts, I started getting this error after navigating to any page after the app loads (i can be an unrelated page).

core.es5.js:1020 ERROR Error: Uncaught (in promise): TypeError: undefined is not a function
TypeError: undefined is not a function
at Array.map (native)
at webpackAsyncContext (http://localhost:8100/build/main.js:94664:34)
at loadAndCompile (http://localhost:8100/build/main.js:82492:36)
at NgModuleLoader.load (http://localhost:8100/build/main.js:82457:83)
at ModuleLoader.load (http://localhost:8100/build/main.js:61796:44)
at DeepLinker.getNavLinkComponent (http://localhost:8100/build/main.js:26002:39)
at DeepLinker.getComponentFromName (http://localhost:8100/build/main.js:25985:25)
at getComponent (http://localhost:8100/build/main.js:35246:23)
at convertToView (http://localhost:8100/build/main.js:35264:16)
at convertToViews (http://localhost:8100/build/main.js:35283:32)
at Array.map (native)
at webpackAsyncContext (http://localhost:8100/build/main.js:94664:34)
at loadAndCompile (http://localhost:8100/build/main.js:82492:36)
at NgModuleLoader.load (http://localhost:8100/build/main.js:82457:83)
at ModuleLoader.load (http://localhost:8100/build/main.js:61796:44)
at DeepLinker.getNavLinkComponent (http://localhost:8100/build/main.js:26002:39)
at DeepLinker.getComponentFromName (http://localhost:8100/build/main.js:25985:25)
at getComponent (http://localhost:8100/build/main.js:35246:23)
at convertToView (http://localhost:8100/build/main.js:35264:16)
at convertToViews (http://localhost:8100/build/main.js:35283:32)
at c (http://localhost:8100/build/polyfills.js:3:13535)
at Object.reject (http://localhost:8100/build/polyfills.js:3:12891)
at NavControllerBase._fireError (http://localhost:8100/build/main.js:49542:16)
at NavControllerBase._failed (http://localhost:8100/build/main.js:49530:14)
at http://localhost:8100/build/main.js:49585:59
at t.invoke (http://localhost:8100/build/polyfills.js:3:9283)
at Object.onInvoke (http://localhost:8100/build/main.js:4166:33)
at t.invoke (http://localhost:8100/build/polyfills.js:3:9223)
at r.run (http://localhost:8100/build/polyfills.js:3:4452)
at http://localhost:8100/build/polyfills.js:3:14076

I removed the import and the problem went away. I took a look at what __webpack_require__.e was and when it works it is ensureRequire and appears to be a part of the chunking process, and when it is not working, it is not defined.
I tore everything out of the module and the page until I was at the point where I only had a single ts file that exported-
export class X { }

import {X} from './pages/x/x.page.ts'
console.log(X);

And it was still broken. I removed the new directory entirely and now I'm getting the error with or without the new page/module.
I can't see any pattern here. If this sounds confusing and maybe not enough to go on- I know!
Why would ensureRequire not be set in main.js?
If the polyfills need to be updated, how do I do that?
Expected behavior:

Steps to reproduce:
I don't know!
Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
global packages:

    @ionic/cli-utils : 1.5.0
    Cordova CLI      : 7.0.1
    Ionic CLI        : 3.5.0

local packages:

    @ionic/app-scripts              : 1.3.12
    @ionic/cli-plugin-cordova       : 1.4.1
    @ionic/cli-plugin-ionic-angular : 1.3.2
    Cordova Platforms               : android 6.2.3 browser 4.1.0
    Ionic Framework                 : ionic-angular 3.4.2

System:

    Node       : v8.1.0
    OS         : Windows 10
    Xcode      : not installed
    ios-deploy : not installed
    ios-sim    : not installed
    npm        : 5.1.0

No idea why that was happening but upgraded to @ionic/app-scripts 2.0.2 (warning, read about the breaking change) and it went away.


more cleanup

abstract
See #40
See #100
fixes
fixes #40
fixes #100
checklist

[x] Make sure you read and understood the CONTRIBUTING.md.
[x] Make sure you applied sufficient labels, milestone and assignee.
[ ] Make sure all commits are squashed before merging.
[ ] Make sure there is sufficient documentation.
[ ] Make sure there are sufficient tests.
[ ] Make sure to delete the feature branch after merging.

Current coverage is 81.16%

Merging #104 into master will decrease coverage by -0.04% as of ef660b3

Powered by Codecov. Updated on successful CI builds.

LGTM


Human formatted Apex test report shouldn't display individual PASSING test methods

Some of our projects have upwards of 2000 test methods. When we run force:apex:test:run -w 50 -r human in our CI/CI scripts and there is a single failed test method, we see 1999 lines of "Pass" and we have to painfully try to hunt down the single test method with the Fail status.
In a prior version of the CLI, it would only report test failures which meant that for a 100% successful test run, it would only print the summary block with the outcome of the test run -- there's no need to print 2000 lines of noise in the log file telling me that each test method was successful
Something changed at some point within the past few months (basically at the point where passing -r human was required in order to see the detail of the test failures)
Solution 1 - silence test methods that Pass by default
Pros: This is the way it should be and the way just about every other test reporter I've ever seen in my life has worked.  Users that want all Passing test methods to be enumerated can use the --verbose existing command line argument to enable.
Cons: This will change existing behavior
Solution 2 - Add a command line argument (eg. --not-so-verbose) to silence Pass test methods from the output
Pros: Preserves existing behavior
Cons: Requires updating existing CI/CD scripts to pass this new flag. Also, documenting and naming the flag to make it somehow compatible with the --verbose documentation could be challenging.
Additional context
Also, it should be noted that in the Summary table, the "Pass rate" is a whole number (presumably using half-up rounding logic) which results in incongruous outcome:
=== Test Summary
NAME                 VALUE
───────────────────  ──────────────────────────
Outcome              Failed
Tests Ran            870
Pass Rate            100%
Fail Rate            0%
Skip Rate            0%
Test Run Id          7071F0000279qGm
Test Execution Time  280082 ms
Org Id               00D1F000000aI3mUAE
Username<EMAIL_ADDRESS>
Which is it? A failure or 100% pass? What actually happened is one test method failed but that still resulted in the "99.9%" getting rounded up to 100%
Version that I'm running
@oclif/plugin-autocomplete 0.3.0 (core)
@oclif/plugin-commands 1.3.0 (core)
@oclif/plugin-help 3.2.2 (core)
@oclif/plugin-not-found 1.2.4 (core)
@oclif/plugin-plugins 1.10.1 (core)
@oclif/plugin-update 1.4.0-3 (core)
@oclif/plugin-warn-if-update-available 1.7.0 (core)
@oclif/plugin-which 1.0.3 (core)
@salesforce/sfdx-plugin-lwc-test 0.1.7 (core)
@salesforce/sfdx-trust 3.6.0 (core)
alias 1.1.10 (core)
apex 0.2.8 (core)
auth 1.7.1 (core)
config 1.2.24 (core)
custom-metadata 1.0.12 (core)
data 0.6.1 (core)
etcopydata 0.6.4-Beta (beta)
generator 1.1.7 (core)
limits 1.2.1 (core)
org 1.7.0 (core)
salesforce-alm 52.3.1 (core)
schema 1.0.8 (core)
sfdx-cli 7.116.2 (core)
shane-sfdx-plugins 4.43.0
├─ @mshanemc/plugin-streaming 1.1.7
└─ @mshanemc/sfdx-sosl 1.1.0
source 1.0.12 (core)
telemetry 1.2.3 (core)
templates 52.1.0 (core)
user 1.4.0 (core)

@mshanemc  -- @k-capehart was so kind as to do the thing with PR#377 -- what is the process for getting this change considered?
It could be viewed as a breaking change .. but it's been repeated a million times over that human readable output should not be relied on to remain consistent .. so I think this would qualify as a permitted change.

@mshanemc -- @k-capehart was so kind as to do the thing with PR#377 -- what is the process for getting this change considered?
It could be viewed as a breaking change .. but it's been repeated a million times over that human readable output should not be relied on to remain consistent .. so I think this would qualify as a permitted change.

This particular change in the node library is not breaking because I've defaulted the verbose value to true.
However, if we do add a --verbose flag to the cli command then that would technically change behavior. However, I agree with you that it shouldn't be relied on to be consistent. Regardless, it might be worth opening a new issue in the CLI repository specifically for that part of the discussion, since it'll be a new PR and specific to that team. Its just dependent on this being merged first.
https://github.com/forcedotcom/cli/issues

@k-capehart and @daveespo - Improving Apex test results is something I'd like to get onto our near-term roadmap.
Some of the suggestions I've seen include adding a --concise flag to produce output similar to what this PR suggests.
While our stated policy is that we reserve the right to change human-readable output at any time, the importance of Apex test results in automation use cases makes me want to tread carefully.
All the suggestions to improve Apex test results that I've seen would result in significant changes to human-readable output, and would be best delivered with matching changes to JSON output.  So, if we're going to take a "breaking changes" hit, I'd like to solve as much as we can in the process.
To that end, I plan to start a GitHub discussion to consolidate existing feature requests and solicit new ideas.  The CLI team will turn that into a design proposal for final feedback. Then, we'll build the changes and put the new behavior behind an environment variable for a period of time while the old behavior is deprecated.
FYI: @mshanemc

@VivekMChawla Thanks for the reply. I appreciate the transparency as always. I'll keep an eye out for that discussion post and for ways to help so we can get this out sooner rather than later.

@daveespo Just updating you. This is just pending the following PR: https://github.com/salesforcecli/plugin-apex/pull/504
Once its approved then this should be good to go!

Linking to https://github.com/forcedotcom/cli/discussions/2872 for reference

Yep, I've been watching .. fingers-crossed on quick approval and merge ;-)

https://github.com/salesforcecli/plugin-apex/pull/553 was merged to main, which contains the commits from my PR. Should be good to go in the next week or two for the next release! 🚀

Hey @avesolovksyy , I completely agree. I would recommend opening an Issue in forcedotcom/cli to request this feature be added to project deploy start.

This issue has been fixed in release 2.56.7 (August 28, 2024).


Use pytest-env to set up API key

Fixes

Fixes #1382 by @AetherUnbound
Description

comment all variables beginning with AIRFLOW_VAR_API_KEY
install pytest-env
all variables beginning with AIRFLOW_VAR_API_KEY are placed in catalog/pytest.ini

Testing Instructions

Checklist

[X] My pull request has a descriptive title (not a vague title likeUpdate index.md).
[X] My pull request targets the default branch of the repository (main) or a parent feature branch.
[X] My commit messages follow best practices.
[X] My code follows the established code style of the repository.
[N/A] I added or updated tests for the changes I made (if applicable).
[N/A] I added or updated documentation (if applicable).
[ ] I tried running the project locally and verified that there are no visible errors.
[N/A] I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@AetherUnbound CI + CD / Run tests for the catalog (pull_request) is failing. I have been trying to edit the api_key variable name and no luck on pass the test for the catalog.

@ngken0995 thanks for taking this on! We don't use a Pipfile for the catalog because Airflow comes with its own constraints file which we use when building the Docker image.
Instead please add the pytest-env package (pinned to the latest version) in the requirements_dev.txt file:
https://github.com/WordPress/openverse/blob/d92c22a71efd4c45a1dc4ee98966a865627786db/catalog/requirements_dev.txt#L1-L12
I think the CI might be failing because the requirement is missing from that file and in the (currently unused) Pipfile instead!

Oh one other note, all of the API_KEY_* variables will need to be prefixed with AIRFLOW_VAR_* like they are in the .env file, otherwise Airflow won't recognize them as Variables (explanation of the environment variable piece is here).

Update: I confirmed that with the following changes, pytest-env behaves as expected 😄
diff --git a/catalog/pytest.ini b/catalog/pytest.ini
index 48029dcc4..96cafe324 100644
--- a/catalog/pytest.ini
+++ b/catalog/pytest.ini
@@ -41,14 +41,14 @@ filterwarnings=
 cache_dir=/home/airflow/.cache/pytest

 env =
-    API_KEY_BROOKLYN_MUSEUM=apikey
-    API_KEY_DATA_GOV=apikey
-    API_KEY_EUROPEANA=apikey
-    API_KEY_FLICKR=apikey
-    API_KEY_FREESOUND=apikey
-    API_KEY_JAMENDO=apikey
-    API_KEY_JUSTTAKEITFREE=apikey
-    API_KEY_NYPL=apikey
-    API_KEY_RAWPIXEL=apikey
-    API_KEY_THINGIVERSE=apikey
-    API_KEY_WALTERS_ART_MUSEUM=apikey
+    AIRFLOW_VAR_API_KEY_BROOKLYN_MUSEUM=apikey
+    AIRFLOW_VAR_API_KEY_DATA_GOV=apikey
+    AIRFLOW_VAR_API_KEY_EUROPEANA=apikey
+    AIRFLOW_VAR_API_KEY_FLICKR=apikey
+    AIRFLOW_VAR_API_KEY_FREESOUND=apikey
+    AIRFLOW_VAR_API_KEY_JAMENDO=apikey
+    AIRFLOW_VAR_API_KEY_JUSTTAKEITFREE=apikey
+    AIRFLOW_VAR_API_KEY_NYPL=apikey
+    AIRFLOW_VAR_API_KEY_RAWPIXEL=apikey
+    AIRFLOW_VAR_API_KEY_THINGIVERSE=apikey
+    AIRFLOW_VAR_API_KEY_WALTERS_ART_MUSEUM=apikey
diff --git a/catalog/requirements_dev.txt b/catalog/requirements_dev.txt
index d1e577fa5..00821c9c0 100644
--- a/catalog/requirements_dev.txt
+++ b/catalog/requirements_dev.txt
@@ -10,3 +10,4 @@ pytest-raises==0.11
 pytest-socket==0.6.0
 pytest-sugar==0.9.7
 pytest-xdist
+pytest-env


[Sugestion] Fluid Cows and AgriCraft

Could you by any chance implement Fluid Cows and AgriCraft integration? It would be nice to be able to see the type of cow and the traits of crops on the toolbar.

That's something for AgriCraft to do

Already requested https://github.com/AgriCraft/AgriCraft/issues/868


fix readme, new util

Yeah, you an see them in readme.

it's will be helpful when i added bound methods for User type, but how it's updating?, i mean in the future, for new telegram users.


main branch builds failing on check-downgrades step

When main branch builds run, they appear to fail on the check-downgrades step with error invalid reference: HEAD^.
Example here: https://build.dev.storj.io/blue/organizations/jenkins/gateway/detail/main/63/pipeline

I believe this was a misconfigured pipeline job. Specifically, shallow clone was enabled, but for 0 levels. Gateway-MT uses 2, so I copied that over and ran a new job which looks healthier: https://build.dev.storj.io/blue/organizations/jenkins/gateway/detail/main/64/pipeline/57/


Header files in implementations/c/lib directory

I have found header files on implementations/c/lib directory. These are at wrong location?
https://github.com/ockam-network/ockam/tree/develop/implementations/c/lib/channel
https://github.com/ockam-network/ockam/tree/develop/implementations/c/lib/memory
https://github.com/ockam-network/ockam/tree/develop/implementations/c/lib/random
https://github.com/ockam-network/ockam/tree/develop/implementations/c/lib/transport
https://github.com/ockam-network/ockam/tree/develop/implementations/c/lib/vault

Hi @ercanersoy, thank you for opening he issue .. no that is intentional.
Could you share a bit more about what you're trying to do? Are you trying to build the code, if so, then are you using cmake or something else?

I have not tried the code. Should the header files are at implementations/c/include directory?
https://github.com/ockam-network/ockam/tree/develop/implementations/c/include/ockam

the choice to keep headers within module folders is intentional, the recent updates to cmake build takes this further and moved the header from include/ockam into indivisual modules. This allows us to create modular dependencies.
I hope that answers your question, if not please reopen the issue.


Can view the name of plot id in collect earth online?

Plot ID is now shown in the collection page.  If this is not sufficient please add a new issue with more description.


There are 2 tutorials tooltips in the bottom of the page

Steps to reproduce

Login to Zafira
Open General dashboard
Open Test runs tab
Switch toggle on Sessions
Switch toggle on Tests

OR

Open General dashboard
Open Test runs tab
Open General dashboard

Actual behavior
There are 2 tutorials tooltips in the bottom of the page
Environment
ui v.1.360-SNAPSHOT | server v.1.537-SNAPSHOT | client v.1.0-SNAPSHOT
Attachments

fixed on UI from v. 1.377-SNAPSHOT

Verified in ui: 1.33-SNAPSHOT server: 1.565-SNAPSHOT client: 1.0-SNAPSHOT.


Database not found and other errors emitted when they shouldn't be

Environment details
OS: MacOS Sonomia 14.6.1
Node.js version: 20.9.0
npm version: 10.1.0
@google-cloud/spanner version: 7.14.0
Steps to reproduce
Note: I was somewhat reluctant to file this because I couldn't easily create a repro case.  But I think it's clear from looking at the code that this is broken.
In a process that will handle and complain about unprocessed errors (such as a Jest test), get a Spanner database object representing a database that does not exist (for example, to test for existence with .exist()).  Exit the process.  There will be an unprocessed error, which in the case of Jest, will cause your test run to fail.
There is an attempt in the session pool code to prevent this exact scenario:
https://github.com/googleapis/nodejs-spanner/blob/992baaa5e7c953938225a0d9f16bc2e5a5c0a6f8/src/session-pool.ts#L571
    this._fill().catch(err => {
      // Ignore `Database not found` error. This allows a user to call instance.database('db-name')
      // for a database that does not yet exist with SessionPoolOptions.min > 0.
      if (
        isDatabaseNotFoundError(err) ||
        isInstanceNotFoundError(err) ||
        isCreateSessionPermissionError(err) ||
        isDefaultCredentialsNotSetError(err) ||
        isProjectIdNotSetInEnvironmentError(err)
      ) {
        return;
      }
      this.emit('error', err);
    });

The problem is that _fill() doesn't throw exceptions, it emits them as errors.  So those errors are emitted as 'error' events by _fill() and the code in the this._fill().catch() is never hit.
It should be noted that there will be other session pool listeners attached, in particular any database objects will have a bound emitter that forwards these errors, so simply handling the errors as the exceptions are handled in open() won't work.  I'm having trouble following the logic and understanding the significant entanglement of the various objects involved, so there is no PR immediately obvious to me.  Hopefully the maintainers will be able to see that there was a clear intention to this code (well intentioned - I definitely don't need an error event for non-existence, often significantly after the fact, when using exist()) that is no longer being satisfied.
The only workaround I could find was to handle all events on all database objects (since they seem to be variously recycled and share the underlying session pool) and ignore the database not found errors (whether they were related to my original attempt to test for existence or not), which is not ideal.  The fact that this event will be sent to some future database object at an unpredictable time is also not ideal (for example, after creating a database, which then does exist).

Hi @BobDickinson, thanks for pointing it out. I have raised a PR to fix it.


Remove deprecated ActionList from SelectPanel and FilteredActionList.

Removed deprecated ActionList from SelectPanel and FilteredActionList components. These were done together as SelectPanel is tightly coupled to FilteredActionList. Updating them in isolation would cause type errors in the other.
Closes https://github.com/github/primer/issues/2465
Screenshots
Merge checklist

[X] Added/updated tests
[X] Added/updated documentation
[X] Changes are SSR compatible
[X] Tested in Chrome
[X] Tested in Firefox
[X] Tested in Safari
[X] Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@radglob just wanted to confirm, does this change include some of the downstream changes that we ran into with: https://github.com/primer/react/pull/3349 and FilteredActionList, specifically:

The id type being narrowed from number | string to string
The leadingVisual and trailingVisual types being changed from React.FC to JSX.Element and string, respectively
onSelectionChange type change
selected type change

Or does it not run into these problems with the removal of the deprecated ItemProps?

@joshblack Yeah, all of those changes are in here. Are those inadvertently breaking changes, or part of the reason that the original PR got reverted?

@radglob just wanted to confirm, does this change include some of the downstream changes that we ran into with: #3349 and FilteredActionList, specifically:

The id type being narrowed from number | string to string
The leadingVisual and trailingVisual types being changed from React.FC to JSX.Element and string, respectively
onSelectionChange type change
selected type change

Or does it not run into these problems with the removal of the deprecated ItemProps?

These should be good to go. Not narrowing the id type led to a few toString calls in order to handle the cases where numbers are used.
I don't see what you mean regarding onSelectionChange and selected. I don't see the former anywhere, and selected is always a boolean.


bug: failures with IP address retrieval for nginx-ingress IC for user display

Describe the bug
Recent change added in an error that results in the process finishing successfully, but exiting with an error due to not being able to pull the IP address due to the service name not being specified correctly. Service is kic-nginx-ingress but the code looks for kic_nginx_ingress.
To Reproduce
Steps to reproduce the behavior:

Deploy any infrastructure other than AWS.

Expected behavior
Should return the IP address.
Your environment
*n/a
Additional context

None

Closed by commit d00fd8b58be8452e7fbba4aefb56aad9557a4a87


Terminal tabs: inline actions not multi selection aware

Testing #122242
Select multiple items in the terminal tabs view.  However if I have a multi-selection and click on the inline action (trash can icon) only one terminal will get killed.
Across VS Code we always respect multi selection for inline actions (example: Git, Open Editors) so I suggest we also respect multi selection for inline actions in the tab terminal list.

I would not have expected that since the action is attached to a single item. If we do it elsewhere we can make the change though.

Fixed in https://github.com/microsoft/vscode/commit/b26b993dafa0dd3774ff1da0d61e363f1a744a77, closed the wrong issue

Works great now -> verified


[folding] [lua] Weird code folding with Lua

A minor observation about an otherwise great feature! Using the Insiders build, the following Lua code causes weird folding:
function someFunc()

    local longString = [[this is a long
string that spans multiple lines
and has some weird folding]]

    print longString
end

You'll notice that a + shows up on the same "function someFunc()" line and on the last line of the longString declaration. The first + folds up to the declaration line and the second + folds the rest of the function.

Code folding is currently based on indentation, this is blocked by language-aware folding https://github.com/Microsoft/vscode/issues/3422

duplicate of #3422