WIP: OpenSSL

Check that cross compilation works properly when using C libraries such as OpenSSL.
… I was going to do that, but it's simpler to static link, so I'll do that.

Codecov Report
Base: 33.33% // Head: 25.00% // Decreases project coverage by -8.33% :warning:

Coverage data is based on head (f1e4cd8) compared to base (3fdc635).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
- Coverage   33.33%   25.00%   -8.34%
==========================================
  Files           1        1
  Lines           3        4       +1
==========================================
  Hits            1        1
- Misses          2        3       +1

Flag
Coverage Δ

unittests
25.00% <0.00%> (-8.34%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/main.rs
25.00% <0.00%> (-8.34%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


test(client): add tests for operationName getter

:tada: This PR is included in version 2.1.1-beta.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 3.0.0-beta.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 3.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Separate controller from HTTP server

Move all of the command execution packages out of the HTTP server, and leave the HTTP as a very thin shell that just calls the controller. This should make it less unpleasant to test.

Done.


add just the read perf improvements from two ZJONSSON PRs

Problem
There are several PRs against the version we forked from, https://github.com/ZJONSSON/parquetjs
Solution
Comb through the PRs and merge what we need/want.   It turns out the read perf "improvements" don't actually work. Make the one small improvement that actually works.

These PRs actually break tests and don't do what they say they do.


BUG: Fix missing qwen 1.5 7b gguf

Fixes: https://github.com/xorbitsai/inference/issues/1021

Other size models support more quantizations too, we can add supports in this PR, including huggingface.


how many tags can be created?

Is there a limit in the number of git tags that can be created? I don't see that info in the doc.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 8c96e564-2fbb-0399-dfdd-fa9570710ae2
Version Independent ID: 413f688e-16bc-123f-5103-a0a0ea95b7e2
Content: Use Git tags - Azure Repos
Content Source: docs/repos/git/git-tags.md
Service: azure-devops-repos
Sub-service: azure-devops-repos-git
GitHub Login: @vijayma
Microsoft Alias: vijayma

@ilantom -- thank you for your question.  At least 500 tags can be created, and I don't think there's an upper limit.
I am closing this issue now.  You are welcome to @ mention me for any followup.  We hope to hear from you again.


17-18 Ideas Tab

When you click anything on the bar it changes to 16-17 ideas. Also probably should be updated to be 18-19 anyways.

Fixed. Thanks Dan!


clock could rewind on dashboard

The dashboard requests min clock update at certain intervals. During the interval, the clock advances at client clock's pace such that it looks going forward smoothly. This will lead to clock rewind when the application clock advances at a different pace. In extreme cases, what if the application clock pauses for some time ?

Currently the (display) clock will be synchronized every 10 seconds. And the update interval of appclock is configured as every 2 seconds.
Here are solutions:

Revert back to un-smooth mode.
Not synchronize at fixed rate but when appclock updates. If the appclock is slower than local time delta (now - lastNow), the display clock will be reminded and the UI will splash once as red.


Adding support for nested doc dirs

This has been successfully tested with our knowledge base and shows up on backstage with the corresponding subcomponents.
Should be backwards compatible with the existing, top dir, workflow, as no defaults have been changed, just made explicit

LGTM


Please update changelog for 1.0.2 and 1.1.0

It looks like the main changes are:
1.1.0:
https://github.com/gjaldon/ecto_enum/pull/53
Addition of MyEnum.valid_value?/1
1.0.2:
https://github.com/gjaldon/ecto_enum/commit/6c972b59a9f7115ee24744f0ce55391f7c3d6418
defenum/3 can accept remote function calls

Actually looks like valid_value?/1 is not in 1.1.0 and release notes can be found at https://github.com/gjaldon/ecto_enum/releases


[ENH] Chi-Squared Distribution #22

Reference Issues/PRs

Addresses #22 for chi-squared case
What does this implement/fix? Explain your changes.

Implements some methods for chi-squared distribution
Does your contribution introduce a new dependency? If yes, which one?
No

What should a reviewer concentrate their feedback on?

Current state of code, and what all capabilities need to be modified / made better (particularly, I am trying to implement energy and make ppf more native than a scipy wrapper)
Did you add any tests for the change?
Nope

Any other comments?

PR checklist

For all contributions

[ No] I've added myself to the list of contributors with any new badges I've earned :-)
How to: add yourself to the all-contributors file in the skpro root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release.
See here for full badge reference
[Yes ] The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.

Thanks for contributing!
-->

I do not understand what the build issue is, as it doesn't seem to show the files I modified, rather some other files

note sure, I've restarted the tests - let's see.

failures seem genuine - methods return unexpected values. Have you run check_estimator on the distribution?


Relax T-SQL heuristic

Description
This is part of a series of PRs for SQL, see #4884.
Relax T-SQL heuristic to avoid a lot of misclassifications of other SQL dialects as T-SQL.

Remove negative pattern for T-SQL whose only goal or effect is to
trick linguist tests. This pattern hides misclassifications in the test
samples that still happen in real world SQL.
Remove IF/ELSE, which is valid MySQL, Oracle, PL/pgSQL, etc.
Remove FETCH, which is valid SQL:2011, DB2, Oracle, etc.
Remove CURSOR, which is valid MySQL, Oracle, etc.
Remove DEALLOCATE, which is valid MySQL.
Remove CREATE PROCEDURE, valid in many databases.
Remove CHOOSE and IIF (too broad).
Change DECLARE (valid MySQL) to DECLARE\s+@
Change GO (too broad) to ^\s*GO\b
Change @@ (too broad) to @@[_A-Z]\w*\b

Checklist:

[x] I am fixing a misclassified language

[ ] I have included a new sample for the misclassified language:

There are many but without clear license:

https://github.com/TrustDB/TrustSQL/blob/e7e9c056b9f60d3bc3e0343390055a9a8854efe4/storage/spider/scripts/install_spider.sql
https://github.com/search?l=&o=desc&p=2&q=if+else++mysql+language%3ATSQL&s=indexed&type=Code

[x] I have included a change to the heuristics to distinguish my language from others using the same extension.

I am fine with the changes. It was pretty difficult for me to find unique aspects of T-SQL that differentiate it from other flavors, but ultimately I just wanted to add it as a language as it was missing and also a very common one.
I was also coming from knowledge of TSQL but not of many of the other flavors so I am glad someone like smola decided to take a look at this ;)

I can give an extreme example of how this (I believe) fixes something.
On the branch running on github's code classifier (which I believe to be "main"):
SELECT @@version;
... is identified, not as SQL, but as TSQL. Unless I'm mis-reading the regex in last bullet on the change, that's something that is currently wrong and this would fix.
I understand that @@version isn't in the ANSI standard, and was originally a Microsoft / Sybase thing...
... but I can also run the it on 5.7.28 MySQL Community Server (GPL) and get:
mysql> select @@version;
+-----------+
| @@version |
+-----------+
| 5.7.28    |
+-----------+
1 row in set (0.00 sec)

I'm afraid I don't have the knowledge of this repo's codebase to try to dive in and add that as a test... but it's at least source data for a simple bit of SQL that is currently mis-classified and this patch should fix.
If it would help, I can give more examples of things currently mis-classified as TSQL which were written for MySQL 5.7

@pchaigno  Added one sample of code targetting SQLite that uses ELSE, maybe other tokens here too. This one is currently marked as TSQL by linguist.
It is extracted from the jOOQ project (Apache 2 license): https://github.com/jOOQ/jOOQ/blob/88aa871b8ed998abd73606395e5acaf9efb0876e/jOOQ-examples/Sakila/sqlite-sakila-db/sqlite-sakila-schema.sql
But the file is actually authored by DB Software Laboratory and licensed under BSD, originally a work MySQL and licensed under New BSD. Anyway, I think all licenses from the original file to its latest form are acceptable here.
There are more interesting samples in the jOOQ project, such as SQL for DB2 identified as TSQL: https://github.com/jOOQ/jOOQ/search?l=tsql&p=1


Drop python 2 support

https://python3statement.org

I ask to matain this support if possible. Actually i work on 2.7 like many other people.

@ZanonEdoardo In my experience 2to3 + some minor manual fixes are usually enough.
I don't want to support this damn legacy, and the only way to make people drop it is to make them start using py3 themselves. And there are 2 complement ways to do that:

the carrot: make the libs they use compatible with py3, so they can use the better language without additional effort. I do it sending PR's, it's almost free for me since I use python 3 exclusively and I have to port the incompatible libs anyway.
the stick: make the libs they use incompatible with py2. Again completely free for me. I just write on python 3 and this makes my code incompatible with python 2.

The problems appear when I have to contribute to the repo which policy is to maintain py2 support...

Here's the pip installs for pdfminer.six from PyPI for September 2018:

Python
percent
downloads

3
86.29%
35,515

2
12.45%
5,125

null
1.26%
517

Total

41,157

I second this.

Ok, With this data you have all reason for remove py2 support.

Ok, With this data you have all reason for remove py2 support.

IMHO the problem is not popularity.  I mean if something is needed only by minority it doesn't mean that one needs to discard it only because of that. One needs more serious reasons, like "it is harmful" or "it doesn't allow us to use new features" or "I personally don't want to put a burden on myself".

Can someone point out how we can go about dropping python 2 entirely?

Can someone point out how we can go about dropping python 2 entirely?

announce the drop date
create a separate python 2 version by stripping all six and replacing them with built in stuff
create a PR merging that version into euske repo
start accepting PRs incompatible with python 2
remove all the six from the version from this repo

Hi everyone, that's me. I would love to hear from the community about interest in this. The short version is:

I ran everything through 2to3.
I ported the tests to my own test framework, iotest, which is hosted at github/gwk/pithy. The main reason for this is that it does complete output test/diff and so I was able to port the ad hoc tests in the makefiles. I need to work through installation/versioning issues to make this easy for anyone to run, but I am very committed to that project so just let me know what you run into.
I renamed the library to pdfminer3 so that people can install side-by-side. This seemed like the sensible thing to do given how many forks are floating around, but I'm open to discussion.
Similarly, I intend to rename the executables so that there are no installation conflicts with other forks of the library.

For technical comments, please open issues on https://github.com/gwk/pdfminer3. For high level community discussion about the sunsetting, I'm happy to continue the conversation here.

@KOLANICH There's no reason to expect the euske repo to merge the fork. It's been abandoned, and some Linux distributions have moved to packaging this repo.
I do think it would be ideal if someone who was committed to regular maintenance took over as maintainer or had commit rights or was granted commit rights on this repo. I don't want to make assumptions but IIRC @ganeshtata previously said they were not necessary interested in that role long term.

Just updating @hugovk's answer, according to pypi's API for this year up to today.

Python
percent
downloads

3
87,59%
635.744

2
11,75%
85.311

null
0,68%
4.920

Total
100%
725.975

Since Python 2 usage seems to be trending down, along with the fact that it is going into EOL next year, I see no reason to keep with the effort to support it anymore.

I think it's best to drop Python2 support simultaneously with the Python development team, i.e. January 2020.
It would be great if someone could already start by creating a PR that drops Python2 support.

Please see PR https://github.com/pdfminer/pdfminer.six/pull/301.

The original pdfminer (from euske) is now Python 3.6+. There is no Python 2 support and even no Python 3.6.
@jbarlow83 probably your statement is not correct now:

@KOLANICH There's no reason to expect the euske repo to merge the fork. It's been abandoned, and some Linux distributions have moved to packaging this repo.


fix testing workflow

Linting step with if condition wasn't working.

coveralls is also not reporting back


Bug 2110629: Set openshift.io/run-level to nil in openshift-controller-manager namespace

The run-level was removed in https://github.com/openshift/cluster-openshift-controller-manager-operator/commit/d12a6ff349028b2d484643f8bf22e1377a2d378a
But because how the cluster-version operator reconciles manifest labels,
dropping a label from the manifest does not remove it from the in-cluster resource
when old clusters are updated into the new manifest.
This commit uses the approach the cluster-version operator used to drop its run-level,
by setting the value to an empty string, which the run-level-consuming code treats identically to an unset label.
This avoids errors about:
...container has runAsNonRoot and image will run as root...

when updating to 4.11.
Signed-off-by: Lalatendu Mohanty<EMAIL_ADDRESS>

@LalatenduMohanty looks like we need to update https://github.com/openshift/cluster-openshift-controller-manager-operator/blob/master/bindata/v3.11.0/openshift-controller-manager/ns.yaml instead and then rebuild bindata.

/cherrypick 4.11

@LalatenduMohanty Needs make update-bindata and commit that

/test e2e-aws-operator


⚠ Bofrost.es has degraded performance

In 3aa0429, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1514 ms

Resolved: Bofrost.es performance has improved in 95e375a after 6 minutes.


clang-format380

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
[x] Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
[x] Does your submission pass brew audit --strict --online <formula> (after doing brew install <formula>)?
[x] Does your submission adhere to Versions "Acceptable Formulae" guidelines?

clang-format 3.8.0

Go for clang-format38 instead of 380.

Made the changes discussed. I added a comment to note the version as it was in homebrew-core, hope that is OK.

I can rebase before the merge if neccesary

@BrewTestBot test this please


Inline console reporter into BenchmarkReporter.display()

Since the ability to print to console is so nice, we change the console reporter to be available on every reporter descendant by adding it as the display() method on the base.
This means that a) the console reporter file can go, and b) tabulate has to be upgraded to an obligatory dependency (at least until we have a better tabular formatter in rich etc.).

Remove console reporter file, add tabulate to project requirements
Also updates the lock files, although not much should change because it was a dev dependency already.
Removes the console reporter from the registry, which is unused at this point, and might be ripe for removal until we add a CLI running facility.
Updates all the docs to use the base BenchmarkReporter() and its display() method.

fyi: I've also taken out the "merge records for batched writing" strategy because a) it was introduced in the first place to write multiple records to console, and b) it doesn't work too well for duckdb, indicating that the strategy is not refined enough.


IntegrateWithWolverine() generates errors using InvokeAsync<T>

See the example code below to reproduce the error. Adding the call to .IntegrateWithWolverine() to Marten will start generating errors like this. The response is still returned correctly. Just this error is floating the logs.
The error gets triggered, as await session.SaveChangesAsync(); gets called in the handler.

fail: Wolverine.Runtime.RemoteInvocation.FailureAcknowledgementHandler[0]
      Received failure acknowledgement on reply for message 018b1387-7fd8-4bb2-8440-40ece12c98a1 from service WolverineMediatorIssue with message 'No response was created for expected response 'System.Guid''

Not having added  .IntegrateWithWolverine() does not generate the error.
Example
using Marten;
using Wolverine;
using Wolverine.Marten;

var builder = WebApplication.CreateBuilder(args);

builder.Host.UseWolverine();

builder.Services.AddMarten(options =>
    {
        options.Connection("Server=localhost;Port=5432;Database=wolverine_issue;Username=postgres;password=postgres;Command Timeout=5;Pooling=true;Minimum Pool Size=1;Maximum Pool Size=20");
    })
    .UseLightweightSessions()
    //Adding this will start logging FailureAcknowledgementHandler errors
    .IntegrateWithWolverine();

var app = builder.Build();

app.MapPost("/", async (CreateItemCommand cmd, IMessageBus bus) => await bus.InvokeAsync<Guid>(cmd));

app.Run();

public class CreateItemCommand
{
    public string Name { get; set; }
}

public class ItemCreated
{
    public Guid Id { get; set; }
}

public class ItemDocument
{
    public Guid Id { get; set; }
    public string Name { get; set; }
}

public class ItemHandler
{
    public async Task<Guid> Handle(
        CreateItemCommand _,
        IDocumentSession session)
    {
        await Task.Delay(1000);

        session.Insert(new ItemDocument
        {
            Id = Guid.NewGuid(),
            Name = "Foo"
        });

        //Saving here, generates FailureAcknowledgementHandler error
        await session.SaveChangesAsync();

        return Guid.NewGuid();
    }
}

@devployment
Easy money with the repro steps. Thanks for taking the time to do that!


Missing some runbook contents

What happened?
Some runbook_url annotations in PromethuesRule is 404，such as https://github.com/prometheus-operator/kube-prometheus/blob/main/manifests/prometheus-prometheusRule.yaml#L258 .
https://runbooks.prometheus-operator.dev/runbooks/kubernetes/kubeclientcertificateexpiration
Did you expect to see some different?
All runbook_url should not be 404.

Feel free to contribute those runbooks in https://github.com/prometheus-operator/runbooks, we cannot do this alone. The 404 page even says so :)

We would like to have runbooks for all alerts shipped with kube-prometheus, but we sadly don't have time to write them all.

I am closing this as this is not a bug and we expect community to chime in and write runbooks.


Isomorphic Web Socket

Description
Moving from watershed to ws. Rework with an isomorphic Web Socket approach.
Specific Changes
Moving to ws which closely resembles W3C Web Socket API.
We are now on an isomorphic approach. The only difference between ws and Web Socket is:

ws.onmessage returns a Buffer (Uint8Array)
WebSocket.onmessage returns a Blob, which need to use FileReader.readAsArrayBuffer to convert it

We added a new createAsyncSequencer to resolve promise sequentially

Next steps
We are still on ISocket interface for now, almost ready to eliminate it, need some investigations:

Can connect() be eliminated? I.e. it will connect immediately when the object is constructed

Look at WebSocketClient.ts line 64 and 71

Testing

[x] Browser Web Socket tested
[ ] Node.js Web Socket tested

Closing since we wrote this differently.


Add bi-directional relationship

to link a parent and a child in both ways automatically.

implemented for v9


[Market Page] Replace dots on the chart with bars

After I switch to new market on UI, as you can see on the right from historical trades, we have many trades in every 2 hours. However on the left, if we aggregate date points with 2h, it should NOT be just one dash line on the chart. It should be a bar. The issue can be resolved by switching between different time intervals for aggregation. But it leaves a pretty bad user impression, especially for new users.

from @maximshen007

exactly, this issue has been existing for many months since we launched the mainnet. Thanks for cc me

This is resolved.


wpdl isn't working for a site that wp-json-scraper successfully scrapes

I was interested in seeing how this tool compares to wp-json-scraper, but while it worked for one of the sites I've used wp-json-scraper on, it didn't work on another.
The site it's not working on is https://powershellisfun.com/

Sidenote: In your README.md you can remove the bit about npm run scrape --  since npx is bundled with npm nowadays.

Hi!
For me it seems to be working correctly. I tried to scrape one of each supported data type with the following command:
npx wpdl --url https://powershellisfun.com --pages --posts --comments --media --tags --categories --users --limitItems 1

If it's still not working for you, could you please give me steps to reproduce the error and I can try to help you out!
The npm run scrape instruction is for running the script locally, not from npm. For example if someone wants to tinker with the code before runnig it. But I agree, npx nicer for local scripts too: npx . --url .... I'll update the docs, thanks!

Closed as stale.


Specify label in file for issue creation

I commonly create multiple (50-100) issues from a set of (local) markdown templates all of which might have a unique set of labels associated.  I currently use a bash loop to create all of these which may not be the most effective, but it works.  I think a nice feature when creating an issue from a file would be if there was a way to specify labels in the file instead of inline with the hub issue create command
(using <> for lack of a better way to specify)
# myfile.md
This is my title

infrastructure
bug

This is the description of my issue

This would be the same as performing
hub issue create -F "myfile.md"  -l infrastructure,bug

Interesting use case; thank you for describing.
This is a sort of feature that I don't see supporting in hub mostly because it's too specific and I don't think it would see wide use. But if you already use a bash script to create these issues in bulk, and hub is designed to be highly scriptable, then I suggest a script approach kind of like the following:
myfile.md:
This is my title

/label=infrastructure
/label=bug

This is the description of my issue

and the script itself:
extract_labels() {
  grep '^/label=' | cut -d= -f2 | tr $'\n' ','
}

clear_labels() {
  sed '/^\/label=/d'
}

for file in *.md; do
  clear_labels <"$file" | hub pull-request -F- -l "$(extract_labels <"$file")"
done

My rationale for this approach is: if you're already making a script, then you can handle some of these custom tasks through scripting rather than hub having to support them internally.
I'm going to close this issue, hoping that it solves your case. Let me know of further thoughts!


Update _getting-started-macos-android.md

Added missing shell configuration PATH for /tools; this was causing issues for me during setup.

Added missing shell configuration PATH for /tools; this was causing issues for me during setup.

I don't think adding /tools is necessary. Can you clarify which type of issues you were having @1NJ57C3 ?

Added missing shell configuration PATH for /tools; this was causing issues for me during setup.

I don't think adding /tools is necessary. Can you clarify which type of issues you were having @1NJ57C3 ?

@cortinico I was getting Error: spawn adb ENOENT before I added the path for /tools -- This was just the first thing on Google that resolved it for me.

This was just the first thing on Google that resolved it for me.

This link mentions to add /platform-tools and not /tools to the PATH (which we already have set up). I'm closing this as I don't believe this should be the general suggestion we provide to users.

This was just the first thing on Google that resolved it for me.

This link mentions to add /platform-tools and not /tools to the PATH (which we already have set up). I'm closing this as I don't believe this should be the general suggestion we provide to users.

@cortinico
Is the adjusted PATH referenced in the answer, (export PATH=${PATH}:$ANDROID_HOME/tools:$ANDROID_HOME/platform-tools) not adding a PATH for /tools in front of /platform-tools, in one-liner format?

Is the adjusted PATH referenced in the answer, (export PATH=${PATH}:$ANDROID_HOME/tools:$ANDROID_HOME/platform-tools) not adding a PATH for /tools in front of /platform-tools, in one-liner format?

You're right. Still I believe we should not be suggesting to add /tools and just stick to /platform-tools which is where adb is located.


Add Test runs to CI, don't run gh-pages from forks

Skipping the usual PR template, since this is just CI
Changes

Use matrix for builds, so that they can be done in parallel
Add test workflow, using nextest to run all tests in repo
Update formatting in all workflow files to follow yaml best practice
Skip documentation workflow when dispatched on a fork

It might be worth it, to lower check times, to run the CI in a container image with the deps already installed.
https://docs.github.com/en/actions/using-jobs/running-jobs-in-a-container

This is pretty old, and definitely outdated.

i'll see whether i can pick up the ideas of this pr at some point if that's fine ^^

Yeah for sure! I don't run Linux as my daily right now so I can't really contribute there, but I'd love to see it get in fs


Add-support-for-careplan-resource-type

@seanno added rendering support for the CarePlan resource showing fields Status, Intent, Activities, Category, & Period Start

Oops one more comment --- can you rebase this merge into the "develop" branch rather than "main" ? Patrick has asked that we push everything into the develop branch and publish to viewer.tcpdev.org, then do a separate pull into main for prod later. Thanks! ---S

Look great! Love having that new utility function too ... FHIR is such a pain to work with, having these really helps!

Thanks! hah it sure is quirky! :sweat_smile:


Added example of geojsonMerge.merge in README

I'd love to see an example in the README, but this doesn't look right. The example in the source https://github.com/mapbox/geojson-merge/blob/master/index.js#L15 shows it takes GeoJSON objects not filenames.


Is this right?

Hello
You wrote: "The script will display the loop count for each worker process in real-time".
This is what I'm seeing:

The image is static. Nothing moves.
In Task Manager, I can see this:

Is this right? Is it working?
Thank you for your script.

@karaloka yeah it works fine for me.

What exact nodejs version you are using? What exact OS and OS version you are using? Thanks for feedback!

Hi
I'm using Node v18.16.1 x64.
My OS:
Edition:	Windows 11 Home
Version:	22H2 (22621.1848)
Intel(R) Core(TM) i5-9600K CPU @ 3.70GHz
RAM: 32,0 GB
I ran and stopped the script several times. There are no error messages, but the data for the loop count never appears. The Task Manager shows that the script is consuming resources. Maybe it's just a display issue. Well, I'm not sure.
Thanks man.

Sorry, I didn't mean to close this session.

@karaloka
Install latest nodejs 20
then type npm update -g in command prompt
then navigate to project folder and type npm update and then node app.js. Tell me if issue is fixed. Try running command prompt as admin if nothing works too

Good job! :D @karaloka you are amazing!
I will fix this to be more responsive.

@karaloka i have implemented fix. Can you test it?

I have implemented new fix.


[17.11] Error on cluster spec name change.

Signed-off-by: Anshul Pundir<EMAIL_ADDRESS>(cherry picked from commit 0b078d10da563bd8c1d4f3a795a81a5d2dbf5232)
Signed-off-by: Eli Uriegas<EMAIL_ADDRESS>

clean cherry-pick?

also would be good to provide link to upstream PR the commit is taken from so the github ui shows the relation

@andrewhsu edited the original PR message

@seemethere When vendoring; be sure to add https://github.com/moby/moby/pull/35492 as well (there's an incorrect test in docker-py)


Compilation failed due to deleted function

In the bms_main.c file, there is a reference to a removed function on line 43, addPacketCallback. Replacing this call with addReceivedPacketCallback results in a successful compilation.
Compiling .pio/build/d1_mini_lite_clone/lib5c2/ESP8266WiFi/ESP8266WiFiSTA.cpp.o
src/bms_main.cpp: In function 'void bms_setup()':
src/bms_main.cpp:43:10: error: 'class BmsRelay' has no member named 'addPacketCallback'; did you mean 'PacketCallback'?
   43 |   relay->addPacketCallback([](BmsRelay*, Packet* packet) {
      |          ^~~~~~~~~~~~~~~~~
      |          PacketCallback
*** [.pio/build/d1_mini_lite_clone/src/bms_main.cpp.o] Error 1
====================================================================================== [FAILED] Took 62.79 seconds ======================================================================================

Environment         Status    Duration
------------------  --------  ------------
d1_mini_lite_clone  FAILED    00:01:02.787
================================================================================= 1 failed, 0 succeeded in 00:01:02.787 =================================================================================

My bad, just fixed. Thanks for reporting.


OIAA

adds a test page for OIAA
removes location requirement (now shows meetings without a specified location)
always busts cache (trouble getting updates from google otherwise)

not needed, now that online meeting list has been updated


custom robot.txt

Feature Request: Add option to disable robots.txt generation or customize rules
Description
Currently, the plugin automatically generates a robots.txt file without the possibility to disable this generation or customize specific rules. This can be problematic when users need to:

Use their own robots.txt file from the public directory
Add specific disallow rules for certain files or directories
Have more granular control over robots.txt content

Proposed Solution
Add one or both of these options to the plugin configuration:
generateRobotsTxt: bool,
or
robotsRules: [{
   userAgent: string;
  allow?: string[];
  disallow?: string[];
}, ...]

Hi @Cephaz
Thank you for your interest, if you need this feature, you can develop it and open a pull request. You can find some examples  here to help you.


Expander properties to all directions

Fixed Expander Border properties not applied to all directions
What does the pull request do?
Apply the Border properties of the Expanderto all directions like down at the direction "down"
What is the current behavior?
Border properties of the Expander are not applied to all directions like down at the direction "down"
What is the updated/expected behavior with this PR?
Border properties are applied for all directions
How was the solution implemented (if it's not obvious)?
Style adaption for Expander
Checklist

[ ] Added unit tests (if possible)?
[ ] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with user documentation

Breaking changes

Obsoletions / Deprecations

Fixed issues

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Fruchtzwerg94 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


IE11 does not support String.prototype.includes

#306 broke IE11 due to it's not supporting String.prototype.includes

It's wrong title. Not Array.prototype.includes in this case. String.prototype.includes is right.

It's wrong title. No Array.prototype.includes in this case. String.prototype.includes is right.

Sorry for the long waiting. Thanks for fixing this 👍

@timche anything I can do to get a v2.6.5 with this in it? Discovered this broke for one of my clients today running IE11 and I don't want to rollback to v2.6.3 and break things for IE10 users.

@vinnymac I'm sorry letting you wait. I've published v2.6.5.


override the logrotate.conf without su root syslog

Fixes https://github.com/phusion/baseimage-docker/issues/338
Briefly, the syslog user does not exist any more in ubuntu:16.04, the default configuration of logrotate still uses syslog as the group, we need to override the default behavior.

FYI, the group would be adm when su root syslog is removed.

I started making an updated fork of this project, containing Ubuntu 16.04 fixes, including this one. Have a look here:
https://github.com/hyperknot/baseimage16


chore: update go-tuf to upstream v0.3.0

Summary

Update go-tuf to upstream v0.3.0 which includes a security fix for rollback protection and the changes from
Asra's fork.
Ticket Link

Fixes
Release Note

Ugh, tests fail 😕

Could we merge this into v3-staging? the tuf bump was non-trivial there so that has fixes


Proposal discussion of a new implementation for tags

disclaimer: the same idea might have already been discussed or even done and my knowledge of the tag implementation in go-carbon might be outdated.
So while we started testing trie+dfa, we notice that on one of the cluster, the new index performs worse than trie+dfa (±100ms -> ±200ms). And in a discussion with @azhiltsov , he revealed to me a replica of the same cluster but with better organized metric names. Because it turns out that people in our company are trying to filter out metrics by some meta data that's contained in the metric path by globbing, which isn't very performant. In the new replica, metric names contains more information and could serve queries better.
for example:
system.servers_app_id_0001.cpu.idle
->
system.app_id.cpu.idle.servers_app_id_0001

The discussion triggered an idea of having dynamic tag support. The current implementation that I remembered in go-carbon is that it would applied tag names as part of the filename, which is not very ideal, because in this way tags are like metric paths, they can't be changed without data loss or sysadmin toil. So in my proposal, tags would be saved independently.
It would use the same line protocol, tags could be added, updated, removed by sending it in to go-caron along with the metrics and data and need to be continuously included.
And in early implementation, I would suggest uniq values shouldn't be included in tags, they should remain in metric paths.
Another key difference to python implementation is that a new globbing syntax:
system.servers*.cpu.idle@{app_id: foo, dc: bar}

And the tag functions in frontend (carbonapi) could still be supported, but discouraged.
New syntax is both good and bad, the good part is metric globbing and data manipulation functions remains separated. the bad part is frontend changes might be required.
P.S. This is not the first time that I propose an extension of globbing syntax: https://github.com/go-graphite/go-whisper/pull/5
P.S. There were some tag effort from @Civil and many others, but it didn't materialize.
Tagging people who I think might be helpful or interested in this issue, sorry for the noise and welcome more people that I missed to comment or dismiss this idea. :)
@azhiltsov @Civil @lomik @deniszh @dgryski

About the old effort on tags, I've actually have a sort-of-working version of go-carbon that was based on your old PR (and outcome of the hackaton from Early 2018) and it is even sort-of-working (I've tested that querying works, but I haven't extensively checked correctness of that): https://github.com/go-graphite/go-carbon
I haven't made it a PR because it still need more testing, especially around regex match operators. Plus it doesn't make a lot of sense to have only custom TagDB implementation, without supporting the whole range of upstream Tag DBs (even if they are worse in terms of performance), at least from my point of view.
Plus also please note that the Graphite tagging implementation actually have 2 modes:

Tags are in a path. It's straightforward.
Metric (with all tags appeneded) is hashed and only hash is stored on disk.

In both cases, index is separately updated by a POST HTTP request to /tagMultiSeries handle with all paths that should be added to the index.
Also the way how you query data actually makes it easier to modify the set of tags - with a proper query you will still have a solid line. The only drawback is that you will have a lot of different files on disk with few datapoints, but that could be less burden either with cwisper or if there'll be implementation of ceres. Also potentially it can be worked around by more API Handles that would allow to map different set of tags to same filename. But anyway, with the hashed metric names it would be hard to do globbing on a filesystem level, however it would be great to adapt trie+dfa index to do simple globbing on tag values (name becomes just one of the tags).
As about your proposal for syntax, if you'll decide to go that way, I'd suggest to consider Prometheus syntax, as it's known by other people and actually easy to convert to graphite one (I have a proof of concept carbonapi talking to Prometheus, which works just fine)

Plus it doesn't make a lot of sense to have only custom TagDB implementation, without supporting the whole range of upstream Tag DBs (even if they are worse in terms of performance), at least from my point of view.

It could made compatible with the python version, but the implementation would focus on keeping tags dynamic and for a better index implementation (even though I'm not sure how good could it be).

Tags are in a path. It's straightforward.
Metric (with all tags appeneded) is hashed and only hash is stored on disk.
In both cases, index is separately updated by a POST HTTP request to /tagMultiSeries handle with all paths that should be added to the index.

So yes, the strong point about this new implementation is that it changed neither filename nor metric path, because when tags are updated or removed, history data is lost in both the solutions mentioned.

So yes, the strong point about this new implementation is that it changed neither filename nor metric path, because when tags are updated or removed,

That sounds like a two parallel issues:

Make a graphite-web compatible tag implementation with all the handlers, etc (and then it could be extra point for go-carbon to be a replacement for upstream carbon)
Add another TagDB variant that will keep track of the tags.

The problem with having the same name is that the query logic will become more complex as you'll need to keep track of timestamp when the tag <-> metric mapping changed. As far as I remember, that was the main reason why during hackaton back in 2018 we went for new metric per each tag set.

The problem with having the same name is that the query logic will become more complex as you'll need to keep track of timestamp when the tag <-> metric mapping changed. As far as I remember, that was the main reason why during hackaton back in 2018 we went for new metric per each tag set.

This  is the python doc for tags:

When using a tagged naming scheme it is much easier to add or alter individual tags as needed. It is important however to be aware that changing the number of tags reported for a given metric or the value of a tag will create a new database file on disk, so tags should not be used for data that changes over the lifetime of a particular metric.

In the new design, this doesn't happen. When tags is added/changed/removed, no new metric files is generated, only tags related to the metric being updated.
I think this makes it much more flexible and users could add or remove tags without concern. As long metric path remains the same.

As usual, it's always about tradeoffs. Either you need to keep track on what changed when (I think this is what you are talking about now?), or live without history (carbonsearch approach) or have a new file whenever there are changes in the tags (as I've said, on a frontend you can create a query that will hide that fact from the end user - they will always get a single line, even if data is fetched from 10 different files).


Migrate Australia holidays to holiday groups and subdivision holidays methods

Proposed change

Migrate Australia holidays to holiday groups and subdivision holidays methods.
Type of change

[ ] New country/market holidays support (thank you!)
[ ] Supported country/market holidays update (calendar discrepancy fix, localization)
[x] Existing code/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency upgrade (version update)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[ ] New feature (new python-holidays functionality in general)

Checklist

[x] I've followed the contributing guidelines
[x] This PR is filed against beta branch of the repository
[x] This PR doesn't contain any merge conflicts and has clean commit history
[x] The code style looks good (make pre-commit)
[x] I've added tests to verify that the new code works and all tests pass locally (make test, make tox)
[x] The related documentation has been added/updated (check off the box for free if no updates is required)

Coverage: 99.923% (-0.01%) from 99.933% when pulling 621fe79b69817bc5b4f27fa1e957b96e065efe5b on KJhellico:ref-australia into 5de784a89637b01b4cfdd3e8d7cd23aeeb4723d3 on dr-prodigy:beta.


"Unexpected End of Scope at line X" error where it shouldn't be

Several of the files in the project I recently inherited are showing "unexpected end of scope at line X" errors where there doesn't appear to be an issue.  I've attached one of the offending files.  Any ideas?
rd_cont_orig.f90.txt

I've had the same issue with our codes but I always assumed it originated from preprocessor directives and/or the use of PETSc and Zoltan libraries.

@bcaddy Thanks for the report! At least for the file you attached, it looks like this is fixed in master (1bdae4e). You seem to be seeing the same bug as issue #128. Can you test out the current master and see if it fixes all the issues in your other files too? If not, I hope to release a patch with these fixes in the next few days.

@GNikit Preprocessor directives can certainly be complicated to handle correctly. However, I think the current preprocessor implementation should prevent "end of scope" errors at least. If you have cases where this isn't true I would be happy to take a look and see if I can improve the functionality.

@hansec How do I install the latest master?  I usually install with pip and pip's version is 1.10.1 which only appears to go to master (192a444)

@bcaddy I just pushed a patch that includes those fixes (1.10.2) so you should be able to just update normally. In the future if you want it is possible to use pip to install from a git repo.

That did it.  Thank!


location of 'must support' pointer

Section Number https://profiles.ihe.net/ITI/PDQm/index.html
Issue pointer to definition of 'Must Support on index page
Proposed Change
PDQm home page contains this:
Must Support`
PDQm uses Must Support in StructureDefinitions with the definition found in Appendix Z. This is equivalent to IHE use of R2.
Perhaps that should be moved to where the StructureDefinitions reside: https://profiles.ihe.net/ITI/PIXm/artifacts.html#structures-resource-profiles
Note, I have submitted the same issue for PIXm (https://github.com/IHE/ITI.PIXm/issues/84) and PDQm.  The resolution should be the same.
Priority:

Low: Typo or other minor classification that an editor can manage. Requires no group discussion.

we do not have any control over the artifacts page.

I asked around, there does not seem to be a precedent for where to publish your Must Support requirements. There is one proposal that has a section "Conformance Expectations" that brings in the definitions of SHALL/SHOULD/MAY, defines Must-Support, and possibly other things that we might see as similar. Others are putting this on a similar level as security considerations.
see us-core - https://build.fhir.org/ig/HL7/US-Core/conformance-expectations.html

I like it where we have it, on the front page.  I could see it as being more visible. It could be more inclusive of other things mentioned in Appendix Z. It could define SHALL/SHOULD/MAY and point at our General Intro Appendix E - https://profiles.ihe.net/GeneralIntro/ch-E.html

decided today

Change to "Conformance Expectations"
add sentence about shall/should/may and appendix E link
increase the header level for this (and download)

Sounds good to me

note, some discussion on zulip that a Conformance Expectations could be a standalone html. We will watch this ongoing discussion and may change to that.


Fix multi use feature

Improve formatting of warning message for saving links with multiple usage.
Add locale folder to build to include possibility of internalisation.
Include description of ANYLINK_ALLOW_MULTIPLE_USE in documentation.

Coverage decreased (-4.9%) to 92.837% when pulling 675b6f9f60863aa5919c07df2f9dd38ef6d4ab7b on fix-multi-use-feature into 5ea1a92e21e091ae93d44e375b39d18522b139ca on master.

Coverage decreased (-1.1%) to 96.571% when pulling 06f064575cafd4a8bd51fa131e5c18b4d5b52a38 on fix-multi-use-feature into 68e9718cad69b67dee04f3ae3d7b0de09e25f85b on master.


Allow passing and setting the Accept header for _req

Hi Alexander! Greetings, and thanks for this lib!
It looks like YT now requires this header or it defaults to XML. Our python app that uses dohq-youtrack broke because XML was being returned instead of the expected JSON.
It now accepts an additional param to force-set the accept header to application/json. So far, we only had issues with get_number_of_issues, so I pass the param there. When not set, it falls back to the default behavior (returning XML).
Please let me know if this is a suitable fix.
Cheers.

Hi Marcelo!
Thanks for your fix.
Please let me test it at least for today. I'll most likely accept this request.

Thanks! Is there anything else to do here before we merge?


suggestion - create a blackbox-data.txt or blackbox-data.json file in the keyring store

this popped into my head while revisiting an old project and wondering if blackbox v2 was out...
for now, this would simply contain a line like:
blackbox_version = 1

or
{"blackbox_version": 1}

this file could then be used by future versions to deal with any api changes or features that require the setup to be different.

That's a good idea.
I'd also like to have the list of filenames stored in something that doesn't break if there are newlines, etc.


No progress?

I use Windows 7 and Python 3.5 with TensorFlow 1.4.0 (there is no 1.4.1 for Windows).
When I run the code in training mode, the last two outputs are
"INFO:tensorflow:Starting queue runners." and
"parameter_count = 57190084".
The output file options.json was created, but there is no further progress/no displayed progress.
What is going wrong here?

In my experience, it takes a long time to start. Did you wait enough?

I waited more than 1 hour. I think this should be enough to see some display output.
Meanwhile I use the torch implementation of pix2pix.

@robertradar I encounter problem in a same way using not enough video ram memory on my on pix2pix fork. I changed my code to use 128*128 instead of 256 (there is several things to do), then it worked.


Add dbt/adapters/sqlite/__version__.py

Adding the file with a variable version set to the package version allows printing the adapter version along when dbt --version is invoked.
Current behavior:
$ dbt --version
installed version: 1.0.0
   latest version: 1.0.0

Up to date!

Plugins:

Expected behavior:
$ dbt --version
installed version: 1.0.0
   latest version: 1.0.0

Up to date!

Plugins:
  - sqlite: 0.2.2

Reference: https://docs.getdbt.com/docs/contributing/building-a-new-adapter#__version__py

Thank you for catching this! I've committed the change.
The docs for building a new adapter have been updated quite a bit since I last looked at them. I should review it again and see if there's anything else I should add, then I'll make a new release. Hopefully I'll get to it in the next few days.


Support for custom shaders in WebGL

I'm staring at this for some time now, but have no clue on how to begin in adding it to Crafty.
I would like to add custom shaders to components. It would be awesome if it somehow could follow the same way sprites work.
E.g.
  Crafty.shader('desaturize', 'void native code blabla...'); // I still need to learn how to do this, but there are samples around for the shaders I need

  Crafty.e('spriteName,desaturize').desaturize(0.3, 0.1, 0.4, 0.2); // desaturize, color to desaturize to

Why do I want shaders?
I'm working on a sidescroller that uses parallax scrolling (different layers moving at seperate speeds when the viewport moves). To create a depth effect, I want to images in the background to be desaturized towards the horizon color to create a depth effect. I could do this by changing the images used for the background layers, but this has drawbacks.
Advantages for using shaders for this are:

I can use the same images in the foreground and background, by simply scaling the image down and add a desaturation effect. This way I can also use this for entities flying from the background to the foreground and vise-versa
When I recolor the background (to simulate a sunrise) the background can be recolored dynamically.
Also for the foreground, I could use a sprite, make it darker and blur using shaders

simply said, I can make my game look a lot better, using minimal of sprites (e.g. loading time) and penalty (since the GPU does the calculations)
Is there something like this on the roadmap for Crafty? Any pointers on how I could start with this feature?

I think this would be a good approach, http://webglfundamentals.org/webgl/lessons/webgl-image-processing-continued.html
Maybe I can create something over the weekend to demo / comment on

I got a static coded desaturation effect working, next step is to get it dynamic and engine worthy, so that people can add their own custom image filters.
But progress none the less :-) (mostly in my own understanding of webGL and how it is structured within Crafty)

I got it working for images, but sadly I had to create a ImageWithEffects component as parallel implementation next to the Image component by duplicating its code.
There is no way to override passed shaders and attribute lists.
https://github.com/matthijsgroen/game-play/blob/master/app/scripts/components/shaders/ImageWithEffects.coffee
For sprites, it is even worse. It uses a global Crafty.sprite method that cannot be bypassed.
So my implementation is stuck for now :disappointed:
I could make a pull request to fix this, but I'm not sure what the best approach would be.
I tried to create a more generic image filter by using several frame buffers, but my lack of webGL knowledge and the complexity of all abstraction layers within the Crafty implementation made it really difficult.

@starwed I noticed you did the current WebGL implementation. Would there be a good way to load sprites with a different set of shaders and attributes? (they should have a different implementation of the draw as well to set these attributes) For Image I could make a parallel implementation, but it is not that easy for sprites it seems.
It looks like the first time that Crafty seems to be working against me in what I hope to achieve, and I would like that fixed :smile:

ShaderFrog has hundreds of shaders to choose from, and you can edit their sources to see how they work. Here's an example of a desaturation shader applied to an image: http://shaderfrog.com/app/view/116 . You can preview the shader on multiple object types, including a plane, which is probably most applicable for sprites.

@DelvarWorld The problem is not getting shader code, that is also not really hard to write. The problem is getting the shadercode in Crafty and applied to certain entities.

What could be a good start would be changing this:
https://github.com/craftyjs/Crafty/blob/78de88eff3d002f1d6a6475bb115621ab15a7060/src/graphics/webgl.js#L158
To accept an extra argument that has a callback that takes an entity.
Basically that callback executes this:
https://github.com/craftyjs/Crafty/blob/78de88eff3d002f1d6a6475bb115621ab15a7060/src/graphics/sprite.js#L243
This way the shader can have all sorts of attributes that can be provided. and will provide them itself given an entity.
next small step would be to have 3 types of default shaders: sprite, image, color
the step after that would be developers able to override these shaders
You still have 3 shaders, but at least they can be overridden.
Next step would be something per entity or entityclass, but thats a bigger step to take.
This would at least help me setup the shaders I want for what I want to accomplish for my game.
@starwed what do you think? Could I make a pull request for this? would that be merged?

@matthijsgroen
I'd generally be in favor of making it easier to provide custom shaders.   I did slightly adjust how they're setup in a PR for layers -- there might a way to make that technique more flexible in a way that would make your job easier.
(BTW, there actually is a wiki page explaining our WebGL implementation, not sure if you've seen that.)

Oh, and I haven't had a chance to look at your proposal in detail yet -- I'll try to find the time this weekend!   Definitely open a PR if you've got any work done.  (Don't wait til it's "finished", it'll be easier to take into account feedback earlier on. :) )

I will start on a pull request tomorrow. In the meantime, check out the current shaders I created!
http://matthijsgroen.github.io/game-play/dist/index.html
When it it possible on sprites I can change all scenery to sprites, and have enemies realistically moving between the background and foreground

Fixed by #1003


Validation: Added Missing Descriptions

Added missing metadata descriptions.

Docs Build status updates of commit 1a69b2f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/SDN/articles/echoeventcauses-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:bulb:Suggestion

Details

Skype/SDN/articles/endedproperties-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:bulb:Suggestion

Details

Skype/SDN/articles/devicerendernotfunctioningeventratio-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/devicerendernotfunctioningeventratio-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/dialog-listener-configuration-file-example.md
:white_check_mark:Succeeded

Skype/SDN/articles/doublebetween0and100-simpletype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/dscpinbound-element-qualityendpointtype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/dscpinbound-element-qualityendpointtype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/dscpoutbound-element-qualityendpointtype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/dscpoutbound-element-qualityendpointtype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/dynamiccapabilitypercent-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/echopercentmicin-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/echopercentsend-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/echopercentsend-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/echoreturn-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/echoreturn-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/elements-skype-for-business-sdn-interface-2-2-schema-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/elements-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/ended-element-messagetype-complextype-skype-for-business-sdn-interface-2-2-schema-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/ended-element-messagetype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/endedproperties-complextype-skype-for-business-sdn-interface-2-2-schema-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/endedtype-complextype-skype-for-business-sdn-interface-2-2-schema-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/endedtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/endpoint-element-byetype-complextype-skype-for-business-sdn-interface-2-2-schema-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/endpoint-element-byetype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

This comment lists only the first 25 files in the pull request.

Skype/SDN/articles/echoeventcauses-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md

Line 29, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 30, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 65, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 66, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 67, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

Skype/SDN/articles/endedproperties-complextype-skype-for-business-sdn-interface-2-2-schema-d.md

Line 28, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 29, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 62, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 63, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 64, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 2d97223:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/SDN/articles/devicerendernotfunctioningeventratio-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/devicerendernotfunctioningeventratio-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/dialog-listener-configuration-file-example.md
:white_check_mark:Succeeded

Skype/SDN/articles/doublebetween0and100-simpletype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/dscpinbound-element-qualityendpointtype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/dscpinbound-element-qualityendpointtype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/dscpoutbound-element-qualityendpointtype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/dscpoutbound-element-qualityendpointtype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/dynamiccapabilitypercent-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/echoeventcauses-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/echopercentmicin-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/echopercentsend-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/echopercentsend-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/echoreturn-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/echoreturn-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/elements-skype-for-business-sdn-interface-2-2-schema-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/elements-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/ended-element-messagetype-complextype-skype-for-business-sdn-interface-2-2-schema-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/ended-element-messagetype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/endedproperties-complextype-skype-for-business-sdn-interface-2-2-schema-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/endedproperties-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/endedtype-complextype-skype-for-business-sdn-interface-2-2-schema-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/endedtype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/endpoint-element-byetype-complextype-skype-for-business-sdn-interface-2-2-schema-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/endpoint-element-byetype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@lindalu-MSFT
The Content & Learning team is fixing build validation errors on docs.microsoft.com for the rest of H2. This will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. Please review within five business days and merge or comment in the PR with any changes you’d like to see. Thank you!


CLOUD-61260 missing drop from undo

@sodre90 @schfeca75

Refer to this link for build results (access rights to CI server needed):
http://ci.sequenceiq.com//job/cloudbreak-pull-request/2871/

Refer to this link for build results (access rights to CI server needed):
http://ci.sequenceiq.com//job/mock-integration-test/364/

lgtm


Tele 5 DL without error but not downloading video

[x] I'm reporting a broken site support
[x] I've verified that I'm running youtube-dl version 2021.04.26
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['https://www.tele5.de/kalkofes-welt/specials/kalkfreitag-2021/?ve_id=GsVXkG6o', '-v']
[debug] Encodings: locale cp65001, fs mbcs, out cp65001, pref cp65001
[debug] youtube-dl version 2021.04.26
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.19041
[debug] exe versions: ffmpeg 4.3.2-2021-02-27-full_build-www.gyan.dev, ffprobe 4.3.2-2021-02-27-full_build-www.gyan.dev
[debug] Proxy map: {}
[debug] Using fake IP <IP_ADDRESS> (DE) as X-Forwarded-For.
[Tele5] kalkfreitag-2021: Downloading webpage
[debug] Using fake IP <IP_ADDRESS> (DE) as X-Forwarded-For.
[JWPlatform] GsVXkG6o: Downloading JSON metadata
[debug] Default format spec: bestvideo+bestaudio/best
[debug] Invoking downloader on 'https://tele5nexx.akamaized.net/73df8480-4d7d-4a19-9dfe-9d302667870e/Kalkofes_Mattscheibe__Das_Lockdo.ism/manifest(format=m3u8-aapl)'
[download] Destination: Kalkofes Mattscheibe - Das Lockdownfest der Fröhlichkeit-GsVXkG6o.mp4
[download] 100% of 1.23KiB in 00:00
Description
Not the video but the manifest is downloaded and saved as an mp4 file.

Problem still persists with Version 2021.06.06

https://github.com/ytdl-org/youtube-dl/issues/30720


refactor: move cmd.go from pkg dir to cmd dir for yurttunnel

Ⅰ. Describe what this PR does
In order to improve the code readability of yurttunnel, move cmd.go of yurttunnel out of pkg dir, and refactor cmd.go into dir: options, config and start.go
Ⅱ. Does this pull request fix one issue?

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
make all
make release WHAT=cmd/yurt-tunnel-server
make release WHAT=cmd/yurt-tunnel-agent
and make sure yurt-tunnel-server/yurt-tunnel-agent can work in openyurt cluster.
Ⅴ. Special notes for reviews

/lgtm


Add BeforeFeature() and AfterFeature() methods

Hi, I would like to propose or ask for a new feature. It would be superb for me to be able to register functions which will be executed before or after each feature. I did some research and if I am not mistaken it seems that there is currently no possibility to implement this behaviour with Godog. The only mention is in #75 but here it seems just like a theoretical play with BeforeFeature().
I am working on Minishift project, which provisions a VM and thus is quite state dependent. It would be nice for me if I would be able to do a full clean up after each feature, not only after whole suite.
Is it possible to run functions before and after Features, or could be this implemented?

Hi, currently godog runs feature by feature even concurrently the unit is feature. It would support such a hook before and after feature and your state might be safe. But in the future there are plans to have concurrency level at single scenario, which would break the feature level isolation.
In terms of best practices, it makes sense to isolate everything to a single scenario, so it would not depend on previous scenario run or feature scope. If I would implement these (before and after feature) hooks now and later shift concurrency level to scenario, there may be BC breaks for many users and these hooks would not make any sense anymore.
So in general, this feature request depends on the question - whether it is better to have concurrency level at scenario and force users to isolate their state and context to scenario level, or leave the current behavior and add these (before and after feature) hooks.
In such cases as yours, in order to highly reduce the suite execution time, it totally makes sense to switch to feature level state isolation, even if it brings some risks in terms of state affecting other scenarios. And current implementation of concurrency at feature level, allows users to choose whether to isolate at feature or scenario level. But isolation at scenario in current implementation does not allow to run scenarios from separate features concurrently, which may actually be depending on feature level state and you would not be able to test that dependency breakage.
So I have to make and document a trade off here regarding this isolation level. But guess it is a better option to be more practical and allow users to choose whether to hold the state in feature context or not.
I'll think about it for some time and will add these hooks most likely.

@l3pp4rd Thank you for amazing insight into the current and planned situation around Godog.

But guess it is a better option to be more practical and allow users to choose whether to hold the state in feature context or not.

I think that having both options, if that is possible, would be best solution. I can imagine projects like Minishift which requires spinning up VM, or other kind of time consuming need before the actual product is "usable". And for these having features as basic units is question of saving time. Also this is practical when one wants to create a user story based test.
But I also understand that for some projects or their parts having scenario as basic unit is the thing. For UI testing I guess this could be just great.
Being able to isolate on both levels could make it harder to understand, but it is common if one adds versatility.
Looking forward how you will resolve this, thanks for great project.

Thanks, it is already resolved and hooks before and after feature were added, users can choose their level of isolation, whether it will be scenario or feature, by flushing and preparing state after one or another.

@l3pp4rd Looking forward to use it, thank you.


add getFirstContentfulPaint()

should behave similar to getFirstPaint() with the "first-contentful-paint" name instead of "first-paint"
See https://developer.mozilla.org/en-US/docs/Web/API/PerformancePaintTiming for docs

In surfnperf.js file whenever getFirstPaint function is called you want to lookup for first-contentful-paint rather first-paint(which is a current behaviour), right?

closed via #85


A flag to disable reverse mapping in number enums

🔍 Search Terms
"number" "enum" "Object.values"
✅ Viability Checklist

[X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[X] This wouldn't change the runtime behavior of existing JavaScript code
[X] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[X] This isn't a request to add a new utility type: https://github.com/microsoft/TypeScript/wiki/No-New-Utility-Types
[X] This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals

⭐ Suggestion
A simple configuration flag to disable explicitly reverse mapping for enums (https://github.com/microsoft/TypeScript/issues/30487)
enum Foobar {
  FOO,
  BAR,
}

console.log(Object.keys(Foobar)) // ["0", "1", "FOO", "BAR"]
console.log(Object.values(Foobar)) // ["FOO", "BAR", 0, 1]

While this is intended behavior, it can be found as unnatural behavior since string enums don't behave the same way. I don't mind the current behavior, but having a flag to align both number and string enums would make sense, at least to me.
📃 Motivating Example
enum Foobar {
  FOO,
  BAR,
}

function isFoobar(arg: any): arg is Foobar {
  return Object.values(Foobar).includes(arg)
}

console.log(isFoobar(Foobar.FOO)) // ok
console.log(isFoobar('FOO')) // should not pass, only 0 & 1 (as number) should be allowed

playground link
💻 Use Cases

What do you want to use this for?
writing typeguards in the same way for string and number enums

What shortcomings exist with current approaches?
there's a need for a filtering pass on enum set

What workarounds are you using in the meantime?

// inefficient but clean
function isFoobar(arg: any): arg is Foobar {
  return Object
    .values(Foobar)
    .filter((v: any) => !isNaN(v))
    .includes(arg)
}

// efficient but amazingly ugly
function cleanEnum(enumType: any) {
  Object.entries(enumType)
    .forEach(([k, v]: [any, any]) => {
      if (isNaN(v)) delete enumType[k]
    })
}

playground link
Other considerations
Maybe another approach would be to have a different way of writing enums so that they match instanceof but i can't think of anything which is not ugly and hacky.
Or since enums emit JS code, have their own .is() type guard function generated would be nice too.

Such a flag might be problematic; suppose a .d.ts file for some library contains
declare enum FooBar {
    Foo,
    Bar,
}

Now further suppose the library writer enabled noEnumReverseMappings when compiling this library, but the user of the library didn't.  The type checker would then allow reverse lookups on this enum, only for the app to crash because the entries don't actually exist at runtime...

it can be found as unnatural behavior since string enums don't behave the same way

For the record, the only reason string enums don't get reverse mappings is because they are vulnerable to collisions whereas numeric enums aren't.

i believe that's not really related to my proposal. i understand that enums are the only things emitting JS (in that sense you're right) but it's not my proposal which will solve the issue of mismatch of tsconfig between built lib and source.
for example, i wonder if - to some extend - a library with types compiled with noExplicitAny: false should be valid to be used in a project where noExplicitAny: true is set.

i understand that enums are the only things emitting JS (in that sense you're right) but it's not my proposal which will solve the issue of mismatch of tsconfig between built lib and source.

Right, but I'm pointing it out because the potential for such mismatch to be a runtime footgun is very likely to be cited as a reason for the TS devs to reject the proposal.

For the record, the only reason string enums don't get reverse mappings is because they are vulnerable to collisions whereas numeric enums aren't.

this i know, but there are valid reasons to use number has enums. from storing in db to magic calculations ; doesn't mean it should not be first class citizen

Essentially sounds like a duplicate of #44753 to me.

And a maintainer already noticed the above issue too: https://github.com/microsoft/TypeScript/issues/44753#issuecomment-869798237

If you don't want the reverse lookup, there's not much reason left to write a numeric enum.
const MyEnum = {
  x: 1,
  y: 2
} as const;
type MyEnum = (typeof MyEnum)[keyof typeof MyEnum];


Stuck at KeyableMap

Hello, my implementation of KeyableMap is my class will extend the keyable that they are storing. For example, Course extends KeyableMap Assessment.
However for the method put, we are instructed to return a KeyableMap and while returning a KeyableMap, the return type class is not the same as the class itself.

The above testcase says that I can't do that cause course.put(assessment) does not return a course but a KeyableMap
Assessment. Am i suppose to overwrite the put method in each of my classes to non KeyableMap?

Yes, for mine I override the put method in both my student and course classes

Yes, for mine I override the put method in both my student and course classes

Hi can you explain to me how you override? I tried overriding but it doesn't work. KeyableMap put return a KeyableMap but I don't store a KeyableMap in my ImmutableMap. I store the type that extends Keyable.

Above is what i am trying to do but it doesn't work.

My second line was Keyable newmap = super.put(a), and the return new Course second parameter was the dict of the newmap
It works using all the test cases in jshell, but ive yet to try the ones in codecrunch yet though

Hey thanks. I was so tunnel in that i didn't see the map of KeyableMap is the the type of map that the classes are storing


Update paper based on the review

Starting to update the paper (@gdmcbain FYI).

#423 Added a citation to the FEniCS book which I think is a rather good introduction to weak formulations and basis functions given that it's also a freely available reference.
#426 Added the governing equation of the second example to the caption. (Is this enough?)
#426 & #428 Changed the wording so that it implies the "over 30 examples" can be now found in the documentation.

#426 Added references to matplotlib and ParaView.

Tried addressing many of the comments in #426 by adding another paragraph to "Purpose and prior art".

Any comments or more ideas?


The 'group' parameter cannot be applied in the roles of the fit_predict function in TabularAutoML.

🐛 Bug

The 'group' parameter cannot be applied in the roles of the fit_predict function in TabularAutoML.
As a result of backtracking the code, I found that the 'group' item was not included in the CV split process.

To Reproduce
Steps to reproduce the behavior:

Run -> TabularAutoML().fit_predict(..., roles={'target': TARGET_NAME, 'group': GROUP_NAME})
"lightautoml > reader > utils.py > set_sklearn_folds()" <- Here, check if the 'group: Optional[np.ndarray]' variable has a value.

Expected behavior

The CV split method changes depending on the 'group' designation above.

Additional context

This was resolved by adding the following code to line 322 of "lightautoml > reader > base.py".
"kwargs["group"] = train_data.loc[:, roles["group"]]"

The issue was found in version "<IP_ADDRESS>" and is unknown for other versions.
I am always grateful for your open source contributions.
Thank you.
Checklist

[ ] bug description
[ ] steps to reproduce
[ ] expected behavior
[ ] code sample / screenshots

Hi @yuuniee,
Thanks for the detailed description of the problem with the models validation. We will for sure take a look into it.
Alex

Hi @yuuniee,
We checked correctness of CV split with the 'group' parameter. We tried several most popular task for it ['binary', 'multiclass', 'reg', 'multilevel'] and didn't find any issues with it.
what you tried to add "kwargs["group"] = train_data.loc[:, roles["group"]]" is implemented here: https://github.com/sb-ai-lab/LightAutoML/blob/b4ace0c63ebf72b08b9c4fb82450f529c2c55958/lightautoml/reader/base.py#L311
if you want to examine it yourself, you can check the attached .ipynb file, that shows the 'group' parameter effect.
Tutorial_1_basics_check_group_parameter.ipynb.zip
if it doesn't solve your problem, please provide additional information
Andrew


Fix launching DevTools with Flutter Web applications

Unlike the native resident runner, the web resident runner does not instantiate a vm service. Instead it passes around one instantiated by package:dwds here.
However, there are Flutter specific extension methods for getting the URIs. These extension methods only work when we are instantiating the vm service.
Since we don't control instantiation, simply update the expando caches to make the extension methods work. This closes https://github.com/flutter/flutter/issues/71933

The tests are failing with:
Invalid argument (Expandos are not allowed on strings, numbers, booleans or null): null
#0      Expando._checkType (dart:core-patch/expando_patch.dart:144:7)
#1      Expando.[]= (dart:core-patch/expando_patch.dart:42:5)
#2      setHttpAddress (package:flutter_tools/src/vmservice.dart:156:22)
#3      _ResidentWebRunner.attach (package:flutter_tools/src/isolated/resident_web_runner.dart:816:7)
<asynchronous suspension>

Because they're not really mocking out enough for there to be an instantiated vm service. For now, I would just add an early return to the setters if the provided VmService is null

The tests are failing with:
Invalid argument (Expandos are not allowed on strings, numbers, booleans or null): null
#0      Expando._checkType (dart:core-patch/expando_patch.dart:144:7)
#1      Expando.[]= (dart:core-patch/expando_patch.dart:42:5)
#2      setHttpAddress (package:flutter_tools/src/vmservice.dart:156:22)
#3      _ResidentWebRunner.attach (package:flutter_tools/src/isolated/resident_web_runner.dart:816:7)
<asynchronous suspension>

Because they're not really mocking out enough for there to be an instantiated vm service. For now, I would just add an early return to the setters if the provided VmService is null


Plugin System

Explanation of the changes, problem that they are intended to fix.
On this implementation, I create a base for plugin system.
For now, 3 hooks are available to use on plugins:

dizquetv:WEB:CustomCss
dizquetv:WEB:CustomJs
dizquetv:WEB:RegisterSettings

I create a plugin for example, this is a Dark Mode plugin. See the repository on here.
This plugin is listed on src/plugins/plugins.json, so it's can be installed using UI.
I'm working on a documentation, and it's are been building here.
After this PR, my next steps is to work into hooks to make possible creation of an Authentication Plugin, to make dizqueTV most secure and decouple cache from dizqueTV to create a plugin with this propose.
All Submissions:

[x] I have read the code of conduct.
[x] I am submitting to the correct base branch

New features

[x] I understand that the feature may not be accepted if it doesn't fit the upstream app's planned design direction. But that in this case I am encouraged to share this as an available modification other users can use if they want.

Good Morning.
I am really sorry that the next thing I will do is postpone  consideration of your PR for a later version. I am specially sorry that it took me so long to reply.
Although these last weekends have certainly been very busy/tired ones and I didn't have a lot of time I could use in dizqueTV, the truth is that I've been procrastinating on my upstream work for dizqueTV and last night I realized it's because making a decision on the plugin system PR is the next thing on my queue and I am not sure if I want this?
There's some reasoning for this.

dTV is still a very young project and I am not sure how much of the code is going to stay. It becomes a problem if I do a massive change and it breaks plugins. Communities have gotten really mad about the loss of plugins in the past.
I think I like the current style of customization. Letting users edit files like the CSS or images and then also having the abilities to do automation with the rest api. I think that for the short to middle term it is a better idea to improve things on this area instead of relying on plugins (and one benefit is that these automations don't have to stick to a specific programming language). I think by adding more sse endpoints we can allow some way to have the relevant hooks.
For ffmpeg maybe we can figure out a way to customize the filters/command line better?

That said, I am still undecided. I'll leave the PR open in case other people have different opinions about whether or not we need a plugin system and maybe in a later version the need for it becomes clearer.
As usual you are free to maintain a fork and if anyone finds need for plugins they may use it.

I close this PR because now I focus on https://github.com/ErsatzTV
Anyone is free to get this branch and continue the work. 👍🏻


Proof-of-Concept: Oracle connection via OpenShift

Describe the task
Acceptance Criteria

[x] Write a node script that connects to jdbc:// and try and connect to the oracle db with info they're already provided
[x] Test out the script with the VPN working on your local
[ ] Deploy Dockerfile of script to OpenShift to verify it can connect to Oracle via OpenShift

Additional context

OpenShift deploy would not need CI/CD or GitHub actions, just test as proof of concept.

@acoard-aot @nikhila-aot it is recommended to use java frameworks to connect to on-prem oracle and using other languages is discouraged as they involved manual work with certificates.
here are some sample repositories connecting to oracle over encrypted listeners on 1543. unsecured port 1521 is blocked from OpenShift.
https://github.com/bcgov/nr-forest-client/tree/main/backend (Sping Boot)
https://github.com/bcgov/nr-backend-starting-api (Sping Boot)
https://github.com/bcgov/nr-arch-templates/tree/main/apis/java/quarkus-legacy-oracle (Quarkus)
if the team still would like to use node.js which involves the manual exchange of certs with DBAs then you can follow the steps outlined here.
https://github.com/bcgov/nr-forest-client/wiki/Connect-to-oracle-db-from-openshift-for-Nodejs-Application

able to connect to the oracle db over VPN using node script from local machine

VPN has the 1521 port open, from OpenShift port 1543 is open and 1521 will not be opened.

VPN has the 1521 port open, from OpenShift port 1543 is open and 1521 will not be opened.

Sure Om, will keep the connections configurable

@nikhila-aot I believe I confused you, it is not just port 1543, connecting to oracle DB from openshift requires proxy accounts which are connected over tcps on 1543 port, also there are certificates which needs to be added for the DB connection on 1543. if going via Node.js , this is a manual process for each environment and the steps are outlined here (https://github.com/bcgov/nr-forest-client/wiki/Connect-to-oracle-db-from-openshift-for-Nodejs-Application)

@nikhila-aot I believe I confused you, it is not just port 1543, connecting to oracle DB from openshift requires proxy accounts which are connected over tcps on 1543 port, also there are certificates which needs to be added for the DB connection on 1543. if going via Node.js , this is a manual process for each environment and the steps are outlined here (https://github.com/bcgov/nr-forest-client/wiki/Connect-to-oracle-db-from-openshift-for-Nodejs-Application)

No @mishraomp , I get that. I went through this link as well. @acoard-aot  was planning to get in touch with you for the DBA contact. If not, I can connect with you on Monday


span tag escaped when switching from markdown to wysiwyg mode

Version
1.2.6
Test Environment
Chrome / Windows
Current Behavior
When switching from markdown mode to wysiwyg mode on the editor, any portion of a code block that is highlighted gets escaped.
For example, if our codeblock contains
here is code with a  highlighted word

Then when we switch from markdown to wysiwyg mode, the span tag that highlights the word is escaped so it is no longer shown to the user as highlighted.
Expected Behavior
Is there a way to modify the behavior of the tui-editor so that we can avoid having some span tags escaped when switching modes?

I created a repro for this issue here based off the most recent angular 6 new project template.
Just clone it and run command ng serve --open
You should notice that when in markdown mode, highlighting inside the code block is shown to the user in the markdown viewer. But when you switch to WYSIWYG mode, the highlighting disappears.
All help diagnosing and fixing this issue would be appreciated.

I now have a working demo of this issue here

Does anyone have any ideas regarding how to fix this?
I can see that this line of code is the cause for all of the code block content getting escaped.
There doesn't appear to be any way to change this behavior via settings. I can replace the wwCodeBlockManager class entirely but the control appears to just ignore the new class I inject.
I am hoping to get some advice on how I should solve this. Does anyone have any thoughts?

@akiander I'm sorry for late reply. I think this issue is bug. We try to fix this issue.

Amount of work : 3MD

@akiander The code you did point is cause of problem. This issue would be fixed in next release. Thank you!


EF Hierarchy, OfType

Hello,
How can I use OfType feature in the specification?

No. Specifications are intended to be very simple and built for a specific entity.
What is your use case?

For example
You have
User class
Customer : User
Employee : User
Then if you want to create GetUsersByTypeSpec(User userType) you cant use OfType

That would require creating the generic spec type by reflection, and we try to avoid it if there is no significant benefit.
In your case, you can simply have a base specification for User, and then have separate specific specs for Customer and Employee inheriting the base spec.

Thanks for help. I thinked like
GetUsersByTypeSpec where T : User

Yes, that's what I meant with the base class. For example, you may have this specification
public class UserSpec<T> : Specification<T> where T : User
{
    public UserSpec(int id)
    {
        Query.Where(x => x.Id == id);
    }
}

Then, either use that one directly, like var spec = new UserSpec<Customer>(1);. Or you may define a specific specification for Customer and Employee, and simplify the usage as var spec = new CustomerSpec(1);
public class CustomerSpec : UserSpec<Customer>
{
    public CustomerSpec(int id) : base(id)
    {
    }
}

Let me know if you're ok with these answers and whether we should close the issue.

Thank you for your help, you can close
public class UserSpec<T> : Specification<T>, ISingleResultSpecification<T> where T : User
{
    public UserSpec(Guid userId)
    {
        Query.Where(c => c.Id == userId);
    }
}

You can use the SingleResultSpecification<T> to simplify it a bit. It implements the interface.
public class UserSpec<T> : SingleResultSpecification<T> where T : User
{
    public UserSpec(Guid userId)
    {
        Query.Where(c => c.Id == userId);
    }
}


Add support for ai-code-translator

Project: https://github.com/mckaywrigley/ai-code-translator

I've created a pull request that'll help get out-of-the-box support for gpt-llama.cpp in https://github.com/mckaywrigley/ai-code-translator/pull/32
For now my fork (https://github.com/keldenl/ai-code-translator/tree/add-base-url) can be pulled instead to get this working for now

will write docs once the PR is in, but running OPENAI_API_HOST=http://localhost:443  npm run dev with my fork should do the job


Replacing enable_docker_bridge with a generic option called bootstrap_extra_args

Description
Replacing enable_docker_bridge with a generic option called bootstrap_extra_args
Fixes https://github.com/terraform-aws-modules/terraform-aws-eks/issues/310 https://github.com/terraform-aws-modules/terraform-aws-eks/issues/317
Checklist

[x] terraform fmt and terraform validate both work from the root and examples/eks_test_fixture directories (look in CI for an example)
[ ] Tests for the changes have been added and passing (for bug fixes/features)
[ ] Test results are pasted in this PR (in lieu of CI)
[x] I've added my change to CHANGELOG.md
[x] Any breaking changes are highlighted above

@RothAndrew OK good idea. I've highlighted it in the changelog in the same way it's been done previously

I was referring more to a section that says something like: "Use the bootstrap_extra_args variable to add other arguments such as the new --enable-docker-bridge flag, which is necessary to for functionality like docker-in-docker"

OK but where do we put that though? Not in the main readme as that is documentation for the module itself, not for random gotchas and issues.
We could create another file in /docs? Or perhaps we create a file /docs/known-issues.md where we could detail this and also all the subnet tagging issues people seem to have?

@RothAndrew I will merge this as I've tested it both with and without the docker bridge option and the nodes join the cluster.
If you feel there is some documentation about that issue that is missing then you can make a PR for that 🙂

@max-rocket-internet sorry, this got pushed off my radar.
There could definitely be a troubleshooting or FAQ doc, that's a good idea.
On a more troubling topic, this should have resulted in a major version bump, since it has a breaking change. Recommend immediately releasing a v2.3.2 tag with this change reverted and then releasing v3.0.0.
Without doing that, someone who had the version they are using as ~> 2.3.0, and using enable_docker_bridge will get hosed when their terraform init installs v2.3.1.

this should have resulted in a major version bump

I think you are right but it's a little late now. I don't want to delete a tag as that is just messy.

Without doing that, someone who had the version they are using as ~> 2.3.0, and using enable_docker_bridge will get hosed

Not exactly. The docker bridge option will stop working ONLY if they update their version of this module without checking what's changed AND if they don't look at what terraform is actually changing.