[bug]: suddenly cpu being used instead of gpu

Is there an existing issue for this?

[X] I have searched the existing issues

OS
Linux
GPU
cuda
VRAM
No response
What version did you experience this issue on?
3.0.1post3
What happened?
the latest time I tried to do image generation, it's using cpu.  All the previous times it correctly used gpu.  I don't think I changed anything between last run and current run but something must have changed or it would still work.
Screenshots
No response
Additional context
I tried the "fix a broken install" option and it still uses cpu; also tried the "change startup options" and it still uses cpu.  I don't know how to tell it "please stop using cpu".
Contact Details
No response

more context : I did a recursive grep on 'cpu' and found an always_use_cpu option in the main yaml, but, it's false, so that's not it

more context : I nuked the invokeai directory and installed from square one, still forces cpu

#4267

I'm seeing the same thing. Immediately after upgrading from 3.0.2 to 3.0.2post1, rendering's done using the CPU. The upgrade was done via Invoke's terminal-based UI. The "fix a broken install" option made no difference for me either. (Ubuntu 22.04.2 LTS here.)

Update: Ahem. Rebooting my PC seems to have solved the problem, at least for me. Doh!
draconicfae, sorry to ask, but have you tried rebooting?

Update: Ahem. Rebooting my PC seems to have solved the problem, at least for me. Doh! draconicfae, sorry to ask, but have you tried rebooting?

I've tried everything short of re-installing the linux distro itself.  I kinda suspect there's some sort of conflicting software somewhere, and that a full distro re-install would fix it, but it would be great if invokeai could tell me why it's forcing cpu so I'd know what conflicts I need to uninstall.

I have the same problem after upgrading from 3.0.2 to 3.0.2post1
YAML settings like so:
always_use_cpu: false
free_gpu_mem: true
max_cache_size: 16.0
max_vram_cache_size: 0
precision: auto
sequential_guidance: false
xformers_enabled: true
tiled_decode: true

AMD Ryzen 3600 with 32GB RAM and RTX 2070S.
I did notice that this problem only happens when trying to generate an image with an SDXL model, loading a SD 1.5 model and generating with that seems to use my GPU as expected with good performance as expected.

Some cpu-only troubleshooting things to try:

https://invoke-ai.github.io/InvokeAI/installation/030_INSTALL_CUDA_AND_ROCM/
https://invoke-ai.github.io/InvokeAI/installation/010_INSTALL_AUTOMATED/#invokeai-runs-extremely-slowly-on-linux-or-windows-systems

Some cpu-only troubleshooting things to try:
* https://invoke-ai.github.io/InvokeAI/installation/030_INSTALL_CUDA_AND_ROCM/

* https://invoke-ai.github.io/InvokeAI/installation/010_INSTALL_AUTOMATED/#invokeai-runs-extremely-slowly-on-linux-or-windows-systems (scroll down to “InvokeAI Runs Extremely Slowly” if this link doesn’t take you there)

Thanks, I saw your suggestion for these two approaches in response to another posted issue and gave it a try, didn't help unfortunately.  At some point it might be cool to extend invokeai to explicitly state why it chose cpu, to enable the user to be certain where the problem point is.  To fix it for myself I'll probably end up making a virtual machine with no responsibilities other than invokeai so that there's no chance that other AI installs will mess it up (which is probably what happened to me).

We've revamped how torch is installed and it is much harder to accidentally get CPU torch now. If you still have this issue on the latest release (v4.1.0), please comment on this issue.


Typescript usage problem

Thanks for your nice admin solution. I have used admin-bro in express.js before and it worked nicely, but recently I tried to use it in an express.js project with typescript and it gets the following error while compiling:
node_modules/admin-bro/types/src/frontend/components/app/filter.d.ts:2:37 - error TS7016: Could not find a declaration file for module 'react-router'. '/home/amin/tatami-projects/dadehbazi-backend/node_modules/react-router/index.js' implicitly has an 'any' type.  Try npm install @types/react-router if it exists or add a new declaration (.d.ts) file containing declare module 'react-router';  2 import { RouteComponentProps } from 'react-router';
Suggestion: including @types/... in "dependencies", not "devDependencies", might solve the problem for typescript projects using admin-bro

Hi,
I don't want to add types to dependencies because not everyone is using TypeScript.
In our TypeScript projects, we simply add these types by installing them in the apps which uses admin-bro.

This causes huge issues for us: Multiple conflicts of types, have to edit yarn.lock manually and looking at admin-bro lock file to try to match types.
Many libraries nowadays include typings in it and it works well.


Fix validation copy

As requested by @superroz.

There is a possibility this will break the functional tests, although they are mainly happy-path so maybe not. Worth a check before we pull this version into ant apps though.
:+1: for the change here.

Good call, I'll be sure to run them first.

I've run them locally and they seem happy (I think that's the problem, it's all happy-path in there).


write command documentation doesn't describe how it maps CSV to line-protocol

The documentation for the influx write command says that it can read CSV
data, but doesn't describe how it maps that data into line-protocol to upload.
How does it decide which field is the measurement name, for example?
The overall page could use more of a high level explanation of what the command does too,
even if it's just "The write command uploads the data specified in the --file flag value file
into InfluxDB".
Relevant URLs
https://docs.influxdata.com/influxdb/v2.0/reference/cli/influx/write/

@rogpeppe The bulk of those details are covered in https://docs.influxdata.com/influxdb/v2.0/write-data/developer-tools/csv/. I'll make sure to add that page as a related page on the influx write command doc.

One other thing, while I'm here: from looking at the code, it seems like you can pass multiple instances of the --file flag to get it to read multiple files, but that's not mentioned in the docs.
TBH, it would be more intuitive if it took files as arguments, but that would be a more significant change.

I'll add that as well. That is demonstrated here: https://docs.influxdata.com/influxdb/v2.0/write-data/developer-tools/csv/#use-files-to-inject-headers

Currently the docs are spread between three pages:
https://docs.influxdata.com/influxdb/v2.0/reference/cli/influx/write/
https://docs.influxdata.com/influxdb/v2.0/reference/syntax/annotated-csv/
https://docs.influxdata.com/influxdb/v2.0/write-data/developer-tools/csv/
It would perhaps be nice to consolidate a little. The last page seems like it could be more
of a tutorial, with the definitive reference split between cli/influx/write (the definitive reference
for the write command) and syntax/annotated-csv (the definitive reference for the
annotated CSV format).

@rogpeppe Thanks for the feedback. The documentation is split into two main doc types: task-based and reference. Looking at the left navigation menu, docs under the "Reference" section are definitive reference docs. Docs above that are task-based (how-to's).
Task-based

https://docs.influxdata.com/influxdb/v2.0/write-data/developer-tools/csv/

Reference

https://docs.influxdata.com/influxdb/v2.0/reference/cli/influx/write/
https://docs.influxdata.com/influxdb/v2.0/reference/syntax/annotated-csv/

Annotated CSV is not unique to writing data. It's the CSV format used by Flux as well, both for ingesting CSV data, but also raw query output. That's why it's structured as a standalone document.

I'd hope that the reference documentation would include a full reference description of the command, and that the task-based documentation could be used as an optional adjunct to that, for further discussion and illumination.
That doesn't appear to be the case here - the task-based doc contains information that's not available from the reference docs.

While the influx write command doesn't explicitly explain how annotated CSV is parsed into line-protocol, I did add multiple links to all of the associated reference documentation (line protocol, annotated CSV, and extended annotated CSV). Closing this issue for now.

Thanks for adding those links. The "extended CSV" one in particular is exactly what I was looking for.
Am I right in thinking that the CSV format must be extended CSV because otherwise the write
command won't know how to map the CSV into line-protocol format?
The write docs say:

Write data using line protocol, annotated CSV, or extended annotated CSV.

which seems to indicate that non-extended annotated CSV is acceptable, but from a quick experiment, it seems that it's not (I get a Failed to write data: line 5: no measurement column found error).
I'd suggest that the documentation be amended to say that only line-protocol or extended annotated CSV
are acceptable (or else indicate how to update non-extended annotated CSV if that's not the case).

@rogpeppe You can use regular annotated CSV, but it must have all the annotation rows and columns required to write to InfluxDB (_measurement, _field, and `_value). If you take the raw annotated CSV returned by a Flux query, you can write that back to InfluxDB.
I've added the following note to the influx write doc:

Required columns
To write data to InfluxDB, you must provide a measurement, field, and value for each row.
Annotated CSV
In annotated CSV, these are represented by the _measurement, _field, and
_value columns and their types are determined by CSV annotations.
To successfully write annotated CSV to InfluxDB, include all
annotation rows.
Extended annotated CSV
In extended annotated CSV, these columns and types are determined by
CSV annotations.

Thanks for that further explanation. I was still a little confused for a moment though, until I thought a bit harder about it.
Maybe an example of using the non-extended CSV as input might be good, as it's less documented than the extended CSV?

https://docs.influxdata.com/influxdb/cloud/reference/cli/influx/write/#write-annotated-csv-data-via-stdin


The fields created_by of PageUser, PageGroup and user/group of PagePermission can cause unwanted user/group deletion

Description
As all of these fields are defined as on_delete=models.CASCADE. That means, if I delete User A, that has previously created a PageUser B, the user B will be deleted as well. I never was really sure what these are anyway... see also #5517 .
Steps to reproduce
Create User A. Log in with A, create PageUser B. Delete User A. User B is gone as well.
Expected behaviour
User B should not be deleted. Instead, one could show (deleted User), and define the fields as on_delete=models.SET_NULL. Or remove the fields completly.
Actual behaviour
User B is gone/deleted.
Also, discovered that normal new Users that are created trigger the creation of a PageUser, if CMS_PERMISSION is true. This can cause confusion, and makes it almost impossible to delete useres on such a system.
Additional information (CMS/Python/Django versions)
for discussion since 2016 #5517
Do you want to help fix this issue?

[ ] Yes, I want to help fix this issue and I will join #workgroup-pr-review on Slack to confirm with the community that a PR is welcome.
[X] No, I only want to report the issue.

anyone? this is a candidate to shot onesels in the foot...

@benzkji this needs raising in a tech committee call I think.

yep, think so. removing created_by would be no big deal (or use on_delete=models.SET_NULL).

@benzkji i think the issue is that it was agreed no more migrations would go into v3 due to the impact that has on v4

Yes #5517 is a duplicate, and should probably be closed as such. As I added there removal is not even necessary, it would suffice to convert the PageUser to be connected to the AUTH_USER_MODEL by a one-to-one-field.
BTW: This issue is from 2015 originally and there were other ideas discussed in the previous tickets.

Any thoughts on this issue?  I'm getting another permutation of this when I try to upgrade Python.  On python 3.6/Django CMS 3.7 my tests all work fine.  But when I upgrade from there, I get a teardown error in my application's tests because my test cases create a User object (and a One to One custom model attached to it).  Deleting that test data through the teardown causes:
self = <django.db.backends.utils.CursorWrapper object at 0x7f3cd5920e50>
sql = 'SET CONSTRAINTS ALL IMMEDIATE', params = None
ignored_wrapper_args = (False, {'connection': <django.db.backends.postgresql.base.DatabaseWrapper object at 0x7f3cdc12dac0>, 'cursor': <django.db.backends.utils.CursorWrapper object at 0x7f3cd5920e50>})

    def _execute(self, sql, params, *ignored_wrapper_args):
        self.db.validate_no_broken_transaction()
        with self.db.wrap_database_errors:
            if params is None:
                # params default might be backend specific.
>               return self.cursor.execute(sql)
E               django.db.utils.IntegrityError: insert or update on table "cms_pageuser" violates foreign key constraint "cms_pageuser_created_by_id_8e9fbf83_fk_auth_user_id"
E               DETAIL:  Key (created_by_id)=(51) is not present in table "auth_user".

I don't work with PageUser nor do I have a custom "created_by" field.  It's just that something has shifted in the built in teardown of model objects to trigger this.
Any idea how I can workaround it?  And/or any plans to move to a OnetoOne relationship for PageUser... which I suspect would mitigate my issue to.
I'm blocked on upgrading either python or Django CMS without this.

@fsbraun this is something we need to address I think.

Hi everyone.
Today we stacked with the same issue when we tried to delete not needed user via dj.admin and we see that it takes to delete related models which we don't want to delete.
If you need any help, I would gladly help and fix that issue and keep DjangoCMS more reliable 😊

@DmytroLitvinov @fsbraun the issue here is the need for a migration. We had said we didn't want more v3 migrations because of the impact that then has on v4.
Hopefully it doesn't interfere.

Trying to upgrade from Django CMS 3.8 to 3.9 (and eventually 3.11) gives the exact same problem as what @bethlakshmi  is observing

For those looking for a quick work around the tests teardown, you can replace the cms.middleware.user.CurrentUserMiddleware with this:
class CurrentUserMiddleware(CurrentUserMiddleware):
    def __call__(self, request):
        if not settings.TEST:
            return super().__call__(request)
        response = self.get_response(request)
        return response

This will prevent CMS create the PageUser link after a new user is created and break the test teardown


RDKDEV-1023: Make plugin autostart configurable from recipe

Reason for change: Platform specific autostart configurations to be set in platform layers
Test Procedure: Build and verify.
Risks: Low

Internal ticket for tracking https://ccp.sys.comcast.net/browse/RDKCOM-4805


swaybg: fix cross-compilation by adding wayland-scanner

Motivation for this change
Ensure swaybg cross-compiles by adding a missing dependency.
Targeting staging because some changes this depends on are on staging (https://github.com/NixOS/nixpkgs/pull/123927). I could target master, but it wouldn't build, so that makes it harder to review. However, since this change is not too intrusive, we could target master anyway. It wouldn't build though, since gdk-pixbuf doesn't cross-compile yet on master.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 126913 at 4410856b run on x86_64-linux 1

5 packages built successfully:

sway
sway-contrib.grimshot
sway-unwrapped
swaybg
waybar


chore: migrate from black to ruff-formatter

We're currently processing your upload.  This comment will be updated when the results are available.


P20.0 CodeDrop

Sonar scan result

No issue found. Congratulations!

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-public-demos-gate-PR57
To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

Build succeeded (gate pipeline).

https://checklist.intgdc.com/job/compliance/job/gooddata-public-demos-merge-compliance-check/51/ : SUCCESS in 15s
https://checklist.intgdc.com/job/compliance/job/gooddata-public-demos-sonarqube-scan-zuul-gate/49/ : SUCCESS in 36s
https://checklist.intgdc.com/job/compliance/job/gooddata-public-demos-fossa-scanning-zuul/12/ : FAILURE in 5s (non-voting)


[Bug]: Loading a DocumentSummaryIndex from a remote WeaviateVectorStore

Bug Description
I've created a DocumentSummaryIndex over a WeaviateVectorStore as such:
documents = ...
client = ...
weaviate_class_name = ...
service_context= ...

vector_store = WeaviateVectorStore(weaviate_client=client, index_name=weaviate_class_name)
storage_context = StorageContext.from_defaults(vector_store=vector_store)
index = DocumentSummaryIndex.from_documents(
    documents,
    service_context=service_context,
    storage_context=storage_context,
)

and all is working fine (I can see document summaries, query the query engine, etc.). However, I cannot seem to subsequently load this index. When using VectorStoreIndex, all I had to do was index = VectorStoreIndex.from_vector_store(vector_store, service_context=service_context), but DocumentSummaryIndex has no such method. I've tried index = load_index_from_storage(storage_context=storage_context, service_context=service_context) but am met with llama_index/indices/loading.py:36 in load_index_from_storage: ValueError: No index in storage context, check if you specified the right persist_dir. Upon my own inspection, I see that storage_context.index_store.index_structs() is just an empty list. I also tried index = DocumentSummaryIndex(nodes=[], storage_context=storage_context, service_context=service_context), but none of my previously saved documents/nodes are present in the loaded index.
Is there something I need to be doing with DocumentSummaryIndex that I didn't have to do with VectorStoreIndex to persist the index to Weaviate? Or am I just loading it incorrectly, or does one of WeaviateVectorStore or DocumentSummaryIndex not support this?
Version
0.9.27
Steps to Reproduce
See above description
Relevant Logs/Tracbacks
No response

Did we solve this bug? https://github.com/run-llama/llama_index/issues/9850
Are you sure you have the latest version installed?

@logan-markewich That fix had to do with using the index for retrieval/querying. I have the latest version installed and retrieval/querying is working fine thanks to that fix. Separate from that, I'm struggling to load the index.

The only examples I can find in the docs for loading non-VectorStoreIndex indexes all use local storage/.persist().

whoops lol jumped to conclusions there.
Did you follow this set of steps? https://github.com/run-llama/llama_index/issues/9850#issuecomment-1878042256
Specially, this one is key when loading
doc_summary_index.storage_context.persist(persist_dir="./index")

from llama_index.indices.loading import load_index_from_storage
from llama_index import StorageContext

# rebuild storage context
storage_context = StorageContext.from_defaults(persist_dir="./index", vector_store=vector_store)
doc_summary_index = load_index_from_storage(storage_context)

Ah okay yes, that seems to work! Reading this page ("User can also configure alternative storage backends (e.g. MongoDB) that persist data by default. In this case, calling storage_context.persist() will do nothing."), together with the fact that I didn't need to call .persist() when using VectorStoreIndex, led me to believe that I wouldn't need to do so with DocumentSummaryIndex either. So who's really the one jumping to conclusions...

@logan-markewich Wait, just kidding; using doc_summary_index.storage_context.persist(persist_dir="./index") leads to the index being persisted locally (I now see an index directory on my local with all the *_store.json files) rather than remotely to Weaviate. Double-checked this with a unique persist_dir name to be sure that the local dir was indeed from this experiment. So even with a storage_context built on my remote WeaviateVectorStore, calling .persist() seems to write locally.

@wdeaderick the doc summary index needs to save the docstore and index store in order to function. It cannot save everything in weaviate.
If local storage isn't an option, there are a few integrations for remote docstores/index stores (redis, mongodb, firestore)

Ah. Yeah, local storage won't work in our case. Can you point me to any docs for those integrations?

@logan-markewich ^ In particular, if DynamoDB is an option

@logan-markewich sorry to bug you but could use a pointer here :)

@wdeaderick yea I think docs are little sparse, might need to use some IDE hints to help with the init
There's a dynamodb docstore here
https://github.com/run-llama/llama_index/blob/22b4c576685d44c9233eeddf1f5410bd93734a16/llama_index/storage/docstore/dynamodb_docstore.py#L8
Just have to instantiate it, attach it to the storage context StorageContext.from_defaults(docstore=docstore, vector_store) and you should be good to go I think

Amazing, thank you!

@logan-markewich The DynamoDBDocumentStore expects an already-created DDB table whose schema I can't find described anywhere. I've tried a couple different schemas but am hitting Type mismatch for key in self._kvstore.put(doc_id, metadata, collection=self._metadata_collection).  cc @Disiok, the author of https://github.com/run-llama/llama_index/blob/main/docs/examples/docstore/DynamoDBDocstoreDemo.ipynb, would be great if you could help me understand what this DDB table needs to look like.


syncing subset of a directory using leaf file prefix is needlessly super slow

I have a bucket with a million files that are spread well in terms of their key pattern.  (e.g., JF2SJAEC8HH466546.xml, 4S4BSANC7H3257612.xml, etc).  Often I want to fetch a subset to my local disk that I would describe in s3cmd by "s3://mybucket/dir1/4S4B", using a prefix match.  My understanding is that with s4cmd I instead pass "s4://mybucket/dir1/4S4B*" to the sync command, which is all fine to use the wildcard.
The problem is that it takes forever for s4cmd to figure out the set of files to copy.  Running with --debug, it looks to me like it's enumerating the whole dir and matching my pattern on the client.  Since I only want 100 out of a million files, this is a poorly performing approach for my case (that is, if my assumptions are right, I haven't read the code).
I would suggest the optimization where the source path up to the first wildcard should be used a prefix to the underlying AWS API, and the number of file names fetched would be be cut enormously.  Although s3cmd was a pig copying each file one by one, I believe it was smarter about this first enumeration step.
Also, congrats on a good looking tool, I have been wanting something with threading on the cmdline for a long time.

I'm also seeing this.  I love the threading, but the setup time on operations can be really expensive:
time s4cmd -c 8 get s3://mybucket/with/lots/of/files/somepattern*
real    7m5.128s
user    2m50.316s
sys    0m12.220s

time s3cmd get s3://mybucket/with/lots/of/files/somepattern*
real    0m9.812s
user    0m0.476s
sys    0m0.124s

Is it implemented this way because s4cmd supports some wildcard patterns that the AWS APIs do not?
Wildcard support: Wildcards, including multiple levels of wildcards, like in Unix shells, are handled. For example: s3://my-bucket/my-folder/20120512/*/*chunk00?1?```

If I can work out a nice way to use AWS API wildcards when possible, and do the client-side wildcards when needed, I'll submit a PR.


[question] for the zero intialization

In the code, why not use the zero initialization of from flax.linen.initializers import zeros but we tried to custom zero initialization?
https://github.com/jeffminlin/vmcnet/blob/master/vmcnet/models/weights.py#L30
why need the dtype there?

Looks like it's to have a consistent type signature so all the initializers can be used in a consistent way. If you look in jax.nn.initializers where we're currently pulling from, the signature of the zeros and ones initializers are different from the rest, so we wrap them to match.
I'm not sure about what you mentioned - flax.linen.initializers. If that has a zeros initializer that has the correct type signature, I see no reason we couldn't use that. But I also don't get what exactly the issue is with the current implementation?


Android New apps must target at least Android 10 (API level 29).

after i  changed targetSdkVersion:29 CameraService now working.

Normally latest version of RN targets SDK version required by Play Store, but required manual change once a project is created.

Please see https://github.com/facebook/react-native/blob/master/template/android/build.gradle


Unsign the multi-package XPIs that we had signed (bug 1205823)

Fixes bug 1205823

Looks about right, no tests but that's probably to be expected. Is there a dry-run mode that can be used to confirm it is unsigning what we want unsigned?
r+wc

Yeah, we never had tests for the unsign addons command, it was developed in a few hours to recover from a signing issue in production the very first time we bulk signed all the add-ons.
There's no dry-run mode, we used to test this on production to make sure it worked as expected. This command can be run several times on the same add-ons, it will only do something if needed (eg: if it's not signed, it won't try to unsign).


Website not updating

The past two Travis builds failed, so the website isn't getting updated, which means the link to the blog post from the svelte release notes is a broken link.

Yeah, the first one was because it had an out of date svelte in package.json, the second was... something to do with Now. Not sure. Have deployed manually
https://svelte.technology/blog/version-2


ZCL_ABAPGIT_REPO_ONLINE: Add getter and setter for branch

Related to #3040
We have to be able to get or set the current repo hash based on checked out commits: The user can choose a commit from a popup and then in the background the repo commit (mv_branch) is set to this selected commit hash. AG resets the repo based on the checked out commit hash after that.
@larshp I'll plan to rename mv_branch to mv_sha1. Is this ok with you or do you prefer another name (e. g. mv_commit) or a different approach?

hmm, guess it wont break anything
but looking at

there is logic to mv_branch, so don't think this is an easy fix, take care


Update redcat dependency

Codecov Report
Patch has no changes to coverable lines.
:loudspeaker: Thoughts on this report? Let us know!.


[Feature Request] Consider to print stringified Map/Set objects

What problem does this feature solve?
When I first started using Vue (a long time ago :) I've liked how simple it was and the ability to debug any object value by printing it in the template using {{ object }}. I've kept this reflex when prototyping because it is so handy and often times quicker than waiting for devtools to load.
Now that we can use reactive Map/Set objects, I recently played with vue-next and reactive Maps and realized this was not working like regular objects. I wish we could do the same kind of thing.
What does the proposed API look like?
when evaluating an object in the template, vue is stringifying the object behind the scenes.
Likewise we could have an 'universal' JSON stringify replacer that handles Map and Set objects.
for instance (snippet taken somewhere on stackoverflow):
JSON.stringify(map, function replacer (key, value) {
      const originalObject = this[key]
      if (originalObject instanceof Map) {
        return {
          dataType: 'Map',
          value: Array.from(originalObject.entries()) // or with spread: value: [...originalObject]
        }
      } else {
        return value
      }
    }, 2))

This way it could as well recursively walk through nested reactive Map/Set objects and update accordingly.
It would be a nice QoL improvement in my opinion, I dunno if it could add some overhead.
In any case I'm open to submit a PR if the idea is approved

This should a good first PR opportunity: https://github.com/vuejs/vue-next/blob/master/packages/shared/src/index.ts#L116


Add a replacement in cleanURL

This pull request is fixing an unimplemented special char case in URLs.

Hello @baptistejamin! Thank you for your PR that should fix this issue. I'd like to know where did you encountered that character?

I don't remember exactly as it happened back in June.
We format thousands of pages everyday and we log every issue we had. This patch fixed several things with URLs.

Okay, as far as I see the #439 is not the only case. Therefore this fix could make sense. Please update your branch and I'll merge the PR.


SW-5122 Add ability to style the Select component

Add select styling props since useStyles is deprecated and we need the ability to control the styling for the participant project dropdown

#510  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Update cowboy

Hi!
Sometimes I'm receiving this error:

[error] Ranch listener :http had connection process started with :cowboy_protocol:start_link/4 ...

Updating cowboy fixes the issue.

Thanks! I will merge soon and release a new version! Cheers!


[WIP][pwm, rtl] SV formatter trial

Try to run the sv formatter on PWM RTL codes
Some of the code arrangements are weird after running the sv formatter in pwm_chan.sv, I don't think the code format after running the formatter is optimal. What do you think?

Signed-off-by: Muqing Liu<EMAIL_ADDRESS>

@msfschaffner: I like this suggestion.

Thank you very much for your comments! @msfschaffner


usage with standalone setup

Hi,
Is it possible to use this module without a puppet server (running 'puppet apply' for example)?
Thanks for your help

No, using Puppetserver alongside PuppetDB is strictly required.


update deps

At long last, this brings up a bunch of our dependnecies, enabled by @katamartin 's amazing work here and here. Specifically, this brings us to next@12, react@17, and<EMAIL_ADDRESS>I've checked things pretty systematically, but definitely worth another set of eyes.

@katamartin good catch! Ok, let's merge this, and I'll throw a PR up on carbonplan.org now. By design, it's an incredibly minor aesthetic change, so I'm not too worried about it, but consistency is good.


Fixed a bug where plugin would be incorrectly deleted

Child plugins of TextPlugin can contain html markup in their str
representation, which wasn't handled properly by the regex in
plugin_tags_to_id_list

Coverage remained the same at 78.125% when pulling 8c337baebe23fc6386d6aafeee5d223442c25824 on vxsx:bugfix/markup-in-inline-child-plugins-str-representations into 57e59ca3cf34f535ce452679fabbb3d976c62304 on divio:master.

Coverage remained the same at 78.125% when pulling 8c337baebe23fc6386d6aafeee5d223442c25824 on vxsx:bugfix/markup-in-inline-child-plugins-str-representations into 57e59ca3cf34f535ce452679fabbb3d976c62304 on divio:master.


Write a TypeScript program to find power of a number by recursion

Description
Write a TypeScript program to find power of a number by recursion
Power of a number is calculated by multiplying the number by itself for the given number of times. For example, 2^3 = 2 * 2 * 2 = 8.
Power of a number can be calculated by recursion. The formula is:
x^n = x * x^{n-1}

Input  : 2 3
Output : 8

How to contribute

Save the solution in FindPowerOfANumberByRecursion.ts file
Add FindPowerOfANumberByRecursion.ts file in find-power-of-a-number-by-recursion folder

!assign


prometheus chart: fix identation on serviceMonitorSelector

Hello,
This one should fix broken yaml in case of using .Values.prometheusLabelValue in the prometheus helm chart

Please bump kube-Prometheus/charts.yaml

thanks @Serg1i


#86 Add notNull for Foldable

Thanks for the pull request!

If you care, my PR preferences are at https://github.com/ndmitchell/neil#contributions, but they're all guidelines, and I'm not too fussy - you don't have to read them.
Implementation of #86. There are no tests for that change as whole Data.Foldable.Extra is excluded from tests

Thanks! Would it be useful to have this in a release? Or more just doing so for completeness?

Thanks for merging! No need to release it right now :)


Cython extension issue, under Ubuntu only.

VSCode Version: Code 1.8.1 (ee428b0eead68bf0fb99ab5fdc4439be227b6281, 2016-12-19T14:41:20.664Z)
OS Version: Linux x64 4.4.0-57-generic
Extensions:

Extension
Author
Version

python
donjayamanne
0.5.5

Go
lukehoban
0.6.51

cpptools
ms-vscode
0.9.3

cython
tcwalther
0.1.0

Steps to Reproduce:

Open Visual Studio Code
Make sure the extension tcwalther.cython is installed and activated
Create a new Cython file (.pyx)
Insert some basic text that complies with Cython's syntax, eg: "int"

Expected output:
The text that complies with Cython's syntax should be highlighted
Actual output:
Under this environment(see system, VSC and extension details above), with tcwalther.cython extension activated (yes, seriously), the text is not highlighted.
Notes:
I've tried those steps in a Windows7 environment, and it works fine.

@lalvarezguillen this looks like an issue of the cython extension, please file the extension against this extension.


Any planning on UITableViewDelegates?

I loved this rx datasources implementation. It makes very simple and reusable to implemente uitableview based view controllers. Do you have any plans to implement similar rx abstractions for uitableview/uicollection view delegates ?

Hi @yuriferretti-luizalabs ,
I don't think we need something equivalent for delegates. They are much simpler.
You can just use rx_setDelegate to your VC to implement one or two of the needed methods. Usually there isn't anything you need to them for :)
Delegate extensions RxCocoa work with these data sources also, so if you use rx_modelSelected or rx_modelDeselected with these data sources, everything will work as expected.

I'm doing some cleanup.
I'm closing this one given kzaher answer. @yuriferretti-luizalabs feel free to open another issue if you feel the need.


Proposal: Enable branding config for Aspire Dashboard

Consider exposing a small set of properties via CSS that could enable 'branding' of the Aspire Dashboard a bit more.
An example of this is the HealthChecksUI, that comes with a default experience:

But with providing a branding CSS file can be customized:

Exposing a small set of branding UI properties via environment variables and or mapping a CSS file for the Dashboard would enable those who are desiring a branded experience (maybe using hosted container image) a simple way rather than rebuild the source itself with adjustments.
Example methods HealthChecksUI uses:

https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks/blob/master/doc/styles-branding.md
https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks/blob/master/doc/ui-docker.md#Custom-Branding

Recommended customizations:

Logo (and accompanying values -- e.g., title attribute)
Primary Accent color (assume maybe the dashbaord uses --var notations for variations already in Fluent)
Font Family

@leslierichardson95  - lets discuss details/timeframe etc.

@timheuer - With all due respect, NO. The dashboard is not intended as a component that others can take, rebrand and use in different places. We will have extensibility for adding more modules.
Once you have people adding their own CSS, the opportunity for conflicts, especially during ongoing development is not worth the risk.

Let’s not close things without a discussion and have PM participate (as noted from Kay).

@leslierichardson95 for thoughts

@leslierichardson95 for thoughts

I like this proposal on its own but I think this feature request is part of the larger extensibility story we still need to figure out.


Connexion 3.0.0a6's RelativeResolver seems to generate false positive error when loading a module

Description
When you try to load method from a module that has nothing to do with route resolving in a relative manner, RelativeResolver generates an error.
Expected behaviour
I can use a relatively imported module
Actual behaviour
connexion.exceptions.ResolverError: Cannot resolve operationId "backend.api.home.landingPage"! Import error was "No module named 'utils'"
(utils is the module I am trying to import, into the same file that contains landingPage endpoint)
Steps to reproduce
For both expected and actual consider this project structure:

app.py
backend

api

utils.py
home.py

and home.py has some endpoint called landingPage:
from flask import render_template
from utils import someUtil

def landingPage():
  b = someUtil()
  return render_template("index.html", data=b)

Access the landingPage endpoint via your API and it will generate the error shown in Actual behavior. someUtil isn't an endpoint and has nothing to do with the API or operationIds. Its just a helper function I am trying to import.
I can get around this issue by specifying absolute pathing for module imports. So, change from utils... to from backend.api.utils...
Additional info:
Python 3.10.11

Your import is not correct. It should either be absolute as you mention, or from .utils import someUtil if you want to use a relative import.


Flip y coordinates of texture data from stb_image

Resolves #869
This could use a careful eye - texture y-coordinates get confusing very quickly.

Reviewing this.

This looks good to me.


No autofocus in Firefox

Version
2.1.0
File / Feature
Autofocus
Expected behaviour
To focus the first input field when the popup opens.
Actual behaviour
There is no focus.

Other info
There is currently an open bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1324255
Suggested workaround is 100ms timeout:
setTimeout(() => {
  document.querySelector('body').focus();
}, 100);

It consistently didn't work on my windows device, it sometimes worked on linux.

Jeroen and I both can't reproduce the focus not working anymore. The workaround doesn't work in your case then as well, because we already implemented the abovementioned workaround.

It consistently didn't work on my windows device, it sometimes worked on linux.

You also can't reproduce this on windows ?

For a different plugin that contains the beforementioned workaround, I can consistently reproduce it not working for Firefox on Windows. Sounds like the workaround might not work for Windows.


Remove exit image

It would be better if the reader did not rely on any files except the css and js.

done


Adding an item to an ArrayField triggers form validation even if liveValidate is false

Pressing the Add button to add a new entry in an ArrayField force-triggers the validation of the whole form., even if we're not supposed to (eg. by default when the liveValidate option is set to false).
To reproduce, you need to first add an item, then delete it, then readd.

This seems to have been introduced by #195.

I was looking into this a little bit and had a question. What's the purpose of options.validate in Form.onChange()?
It seems like this bug is occurring because in the next line, mustValidate is being set to true even if liveValidate is false because options.validate is being set to true here. I'm tempted to just remove options.validate but I'm not sure what the implications of that would be since I don't fully understand what that value is used for.
Simply removing options.validate seems to provide the behavior we want based on some quick testing in my local playground and the only test that fails is this one, which seems to allow this bug to pass through testing.

PR submitted here #279. Feel free to play around with it and see if ended up breaking anything. It seems like my PR undoes all of #199, so I'm curious why the bug it was supposed to fix isn't showing up when testing with my PR.


Fix mango native proc crash

Overview
When soft limit is reached couch_proc_manager evicts idle processes by casting on them stop
message. Since mango_native_proc doesn't handle this message it results to its crash with
invalid_cast reason.
Testing recommendations
make eunit apps=mango or make eunit apps=mango suites=mango_native_proc for isolated test.
make mango-test for integration test.
Checklist

[x] Code is written and works correctly;
[x] Changes are covered by tests;
[ ] Documentation reflects the changes;

The fix lgtm. The garbage collection test is a little tricky, just want to understand it a bit better.

Hey @tonysun83 , was my explanation sufficient? Do you want me to change anything in the tests?

+1


Update qdrant.py

Fixes #1087

@rishabh-ti That's actually causing the issue, not solving it. Qdrant stores the document content with "page_content" key (check out https://github.com/hwchase17/langchain/blob/6322b6f657b8f630c72d6c321ece0e513b2ba35f/langchain/vectorstores/qdrant.py#L218). If you now read it from a different key, then you break the integration.
@hwchase17 Can we revert those changes? I want to verify the root cause and provide a fix, but that PR actually introduces the same bug like described in #1087


Working on Windows with same accuracy

Hi,
Is it possible to run the code on windows.?
Is it similar to the original faster rcnn in terms of accuracy ?
Did you do inference with this repo??

Yes, I writed and tested on windows.
But currently, the mAP on voc dataset is lower than original faster rcnn... 😭

Okay Fine.
Is the procedure holds same for both windows and ubuntu??

I am getting this error when running demo script in windows..
File "demo_faster_rcnn.py", line 59, in
bbox_mean=cfg.bbox_mean, bbox_std=cfg.bbox_std)
File "C:\Users\godavart\Desktop\gluon-faster-rcnn-master\rcnn\rcnn.py", line 37, in init
negative_iou_threshold=rpn_negative_threshold)
File "C:\Users\godavart\Desktop\gluon-faster-rcnn-master\rcnn\anchor.py", line 13, in init
self._base_anchors = self.params.get_constant('base_anchors', base_anchors)
AttributeError: 'ParameterDict' object has no attribute 'get_constant'

Could you provide your mxnet version? Seems it is caused of your mxnet is out of date.

Even i thought the same.
In windows it is 1.0.0..
How to upgrade this in windows using command line? any command for that

pip install --upgrade --pre mxnet-cuXX

XX is your cuda version, eg. mxnet-cu80 if you use cuda 8.0
Refer to https://pypi.org/project/mxnet/ for all aviliable packages.

I could able to run it on aws.
I will try on windows later..
I want it to work fine in aws now.. Later i will play with it in windows.

Which Pretrained model should i use to check the demo.?
Can You provide me the link?
I have used the one from here
But i am getting an error something like this .
raceback (most recent call last):
File "./demo_faster_rcnn.py", line 61, in
net.load_params(cfg.model_params.strip(), ctx=ctx)
File "/home/ubuntu/anaconda3/lib/python3.6/site-packages/mxnet/gluon/block.py", line 340, in load_params
filename, ctx, allow_missing, ignore_extra, self.prefix)
File "/home/ubuntu/anaconda3/lib/python3.6/site-packages/mxnet/gluon/parameter.py", line 769, in load
"with '%s'"%(restore_prefix, name, restore_prefix)
AssertionError: restore_prefix is 'fasterrcnn0_' but Parameters name 'vgg0_conv0_weight' does not start with 'fasterrcnn0_'
Help me out in this..

Pertained model parameters are not release d yet, since the mAP on VOC is lower than original at this config.

The model file you referred is the base model used to init vgg feature extract layers that will be downloaded automatically in the frist you trian.

I got it.. Thank You..
I am not using any pretrained model, instead i am randomizing the weights...


i cant render in pc

Describe your problem here. If you are modding, please try testing your problem in a clean version of the engine instead, this ensures the problem is actually caused by the engine itself. Also, if you're using an older version of JSE, please try the latest action build in the Actions tab or the latest release build. The issue has probably been fixed since that version. Oh yeah, and also be sure to check the pinned 'JS Engine: Known Issues' issue, to double check if your issue hasn't already been found!
whenever I open renderlol.bat at the end it says that ffmpeg it's not a file or batch or idk
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
same as the previous issue nope

I hope he helps me

on that ofc

I rendered on multiliosis

You're not using Classic Rendering Mode.

it didn't work

I putted ffmpeg on the js engine folder

I putted ffmpeg on the js engine folder

classic rendering mode puts images in a folder. you're likely using NEW rendering mode, which makes a video file out of the song you're rendering. check if that existx

I saw a typo but yes I checked (maybe)

you MAYBE checked??
alr, send me a screenshot of your gameRenders folder

sorry to send a photo I need to log in pc

and I can't log in PC:(

but I checked the files only (without photo)

but I can write it

on here lol

files: multiliosis readme.txt render lol.bat

multiliosis is a folder..

yea

I love this wonderful engine

how come you don't know how to send screenshot?? it's just pressing print screen and pasting by pressing ctrl + v

bro I CAN'T LOG IN PC

if you say that again I'll close this

something tells me you can't be on github

or the internet at all

@JordanSantiagoYT btw block them, so they can't keep coming here


b49 machswap2 reboots everytime on a10 and a11

i currently have a problem regarding machswap2 across the span of two different devices running two different versions of ios on two different chipsets. the devices and ios versions are as follows
iPad Pro 2nd Gen 12.9 inch on A11 running iOS 12.1.1
iPhone 8 Plus on A10 running iOS 12.0
voucherswap is what i use primarily and it works every single time other than the odd time where it doesnt. When i found out about machswap2, i upgraded from b46 on both devices to b49 and tried the exploit on both devices.
Every time i try to jailbreak with the ms2 exploit (with reload system daemons off mind you), it does not work and reboots every single time.

I have also been unable to ever get machswap2 to work on the iPhone 6+. It will fail after the joke posting on this block text and immediately reboot.
It works really well on my iPad 5 WiFi

MS2 only works on my iPhone X. For the iPads and iPhone 8 MS1 works, but still not as reliable as VS

@13XxM1CHA3lxX37 False.
Mach_swap2 supports all A9-A12X devices (ex: iPhone 6s, 7/7+, 8/8+, X, XS, XS Max, and XR). If your device isn't an A9-A12X device, I suggest using mach_swap, which only supports A7-A8 devices (ex: iPhone 5s and 6).  If the exploit crashes your device, just give the app about a minute before hitting jailbreak (once you are back at the homescreen) and the exploit should work.


General code clean-up and setting up the ability to use state vectors

Current implementation fails at line-of-sight generation from the orbit using Geo2rdr (see #14).
Cleans up a number of deprecated comments and file reads in preparation for chunked data access
Rearranges some utility functions to be compatible with using a state file and for grouping similar fcns
removes the .cpp version of Geo2rdr from the repo, as it changes with every build and isn't required because we specify cython as a RAiDER dependency (this could be fixed; see #13).

@jlmaurer do you want to wait to include the state-vector component too?


[Admin] (iPad) Refine sideload instructions

Docs Build status updates of commit b894c82:
:clock10: Pending: waiting for processors (13 builds ahead of you)
:warning: Docs Build is busy, currently there are 13 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit b894c82:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/testing/sideload-an-office-add-in-on-ipad-and-mac.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


On GLIBC, compile libgit2 with -D_FILE_OFFSET_BITS=64.

On GLIBC, compile libgit2 with -D_FILE_OFFSET_BITS=64. On 32-bit
architectures, this is needed for libgit2 to access files larger than 2 GiB.
While here, also use -D_TIME_BITS=64, which is needed on GLIBC on 32-bit
architectures for libgit2 to work correctly in in the year 2038 and beyond.

@sunfishcode To what extent does this change the public ABI of the libgit2 C library? If people are calling functions in libgit2-sys directly, will any of that code break?

libgit2 uses its own typedefs for file offsets and times in its public API, specifically to avoid being affected by this issue.

Ah, looking back on this, I see that it's not just about the public API. In that case, I don't know how to do this transition in a reasonable amount of effort.


What is the minimal php requirements?

Hi everyone, I'd like to know what the minimal php requeriments are because I'm developing a system for an old php version (5.2.0) using cacke php as a framework, so it's out of my hands to upgrate it.
Thanks in advance

I don’t think anything after PHP 5.2 is used. Maybe the wrapper interface has some PHP 5.3 elements, but you should be able to unwrap them pretty easily.
The library has been tested inside Linux kernel as well, so should have minimal dependencies.

On Apr 19, 2016, at 5:03 PM, Erik Villegas<EMAIL_ADDRESS>wrote:
Hi everyone, I'd like to know what the minimal php requeriments are because I'm developing a system for an old php version (5.2.0) using cacke php as a framework, so it's out of my hands to upgrate it.
Thanks in advance
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub https://github.com/OWASP/rbac/issues/81

Well, I'll check it. Thank you

With the release of php 7, it'd be nice to know whether it's upwards compatible as well.  Composer allows setting the required php versions in composer.json, e.g.
"require": {
"php": ">=5.6.0",

Thanks for the help


Use Django 1.9+ location for postgresql backend

It was renamed from django.db.backends.postgresql_psycopg2 to django.db.backends.postgresql in Django Ticket #25175 and there's an ongoing discussion about deprecating/removing the old name. Better to be future proof!

CC @jarshwah

PR would be accepted!

Done.

released!


Microsoft Purview Content Search

Proposed name of the new command
pucontentse
Description
Microsoft Purview Content Search
Category
Microsoft 365
Url
https://compliance.microsoft.com/contentsearchv2

Thanks @lisaawengler this has been added now.


Ignored special characters?

There are some characters which Meili seems to ignore inside the query.
Searching for Test.mp3 yields the same results as Test mp3, in both cases the phrase Test.mp3 isn't contained within the results at all.
So my question is, is there a way to prevent certain characters like . from being ignored/converted to whitespaces?
And could the docs list which characters are affected?
As an alternative, is there a way to specify an 'exact' search? I tried filters, but this will only match if the field's value is exactly the query. What I want is to return a hit if the exact query is contained anywhere inside the field.
Thanks in advance!

@LegendreM how will the new tokenizer help with this issue? I imagine it would have to treat the links as a different 'language' to avoid the usual tokenization approach? Will this be possible once the new tokenizer is live?


Fix a spelling problem in treasury doc

Not a spelling error.
https://en.wikipedia.org/wiki/If_and_only_if

@gavofyork thanks


Global text expander

Description of the new feature / enhancement
In our daily work, we often use the same blocks of text over and over again, whether in support, when creating documentation or emails.
We often have note pages from which we copy the information.
This is very cumbersome and doesn't make the work much faster. Instead of searching for the text in the notes, it would be much easier to give the text an abbreviation, which PowerToys would then replace with the actual text.
Scenario when this would be used?

Expanding mail snippets
Standard Servicedesk responses
sendings Documentation links by shortcut
generating code documentation header tool independent

I guess there are many more scenarios where this would be usefull
Supporting information

there are tools like textexpander, PhraseExpress oder AutoHotkey already doing it
Its a standard feature an MacOS

/dup #30292


Fix ERB Ruby v2.7 warnings.

In Ruby v2.7, you'll get the following warnings:
~/.gem/ruby/2.7.0/gems/commander-4.5.1/lib/commander/help_formatters/terminal.rb:15: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments.
~/.gem/ruby/2.7.0/gems/commander-4.5.1/lib/commander/help_formatters/terminal.rb:15: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead.

There might be more warnings for v2.7, but these are the only ones I get so far.

Looks good, thanks! Could you rebase and squash your two commits together?

Okay, I rebased it. I had to merge in some conflicts. Hopefully it's okay. Thanks.

Hmm, that doesn't look quite right.

After I rebased, it kept having conflicts, so I reverted it back to head, which then closed this pull request.
I reopened a new one at pull/93.


Error using BatchToken/consumeTokenData

MATLAB actions exit with
Error using BatchToken/consumeTokenData
  Current time (03-Jan-2023 14:04:49) for token from license 40847642 is NOT in
  the time range for this token (02-Jan-2022 09:17:07 to 03-Jan-2023 09:17:07)

  Error in BatchToken.enableTokenLicenses

See, for example,
https://github.com/zequipe/test_matlab/actions/runs/3830109751/jobs/6517573208
Thank you for taking a look.

@zaikunzhang Thanks for reporting this issue. We are working on it.

This issue should be resolved. Please feel free to reopen if you continue to experience it.

Thank you @mcafaro . It works.


Make conn.Close() wait till shutdown is complete.

This showed up with the improved logging: log messages for the Close frames of one
test were printed after another test had started.
Should be deadlock safe, since we don't call user callbacks in the mux or tx/rx goroutines.
Signed-off-by: Alan Conway<EMAIL_ADDRESS>

conn.errMu is supposed to be held by conn.mux until the connection is closed and all other goroutines have exited. It doesn't return until conn.close runs. conn.close closes conn.done and waits for conn.txDone and conn.rxDone.
conn.Close waits for conn.errMu via conn.getErr.
Perhaps conn.Close -> conn.getErr raced with conn.mux and acquired conn.errMu first. It's nicer to pair them up but for correctness it seems c.errMu.Lock() needs to happen before the mux goroutine is started.
https://github.com/vcabbage/amqp/blob/ae5d459847815b7b77422fc12f8351fa56f572a8/conn.go#L339-L342

I don't think you need the mutex at all (and I wouldn't lock/unlock a mutex in different functions)
All the error checks are already guarded by a <-done check, so if you just set the error before close(c.done) you can access safely using only the channels  Patch coming...

This version drops the mutex, fixes the out-of-order logging and passes go test -race.

I was only going to accept this because it should have been a small fix. While you may well be correct, I'm not accepting any refactors.


Support schema registry serializers for the reader

Problem description
The schema registry offers a way to get the serialization format of the data in the stream. Flink connector can take advantage of it. Note this is a part of #362 , we plan to do it step by step.
Problem location
FlinkPravegaReader and FlinkPravegaInputFormat
Suggestions for an improvement

With #443 , we plan to not support this feature in Flink 1.9 connector

With #443 , we plan to not support this feature in Flink 1.9 connector


Angular bind polymer throws exceptions with ng-if or ui-router

When I use the bind polymer directive on elements hidden with ng-if and for example indirectly via ui-router, I get the following exception:
 TypeError: Cannot read property 'match' of undefined
    at link (http://localhost:8080/bower_components/angular-bind-polymer/angular_bind_polymer.js:11:43)
    at Z (http://localhost:8080/bower_components/angular/angular.min.js:70:149)
    at A (http://localhost:8080/bower_components/angular/angular.min.js:59:203)
    at g (http://localhost:8080/bower_components/angular/angular.min.js:51:299)
    at A (http://localhost:8080/bower_components/angular/angular.min.js:59:147)
    at $get.c (http://localhost:8080/bower_components/angular/angular.min.js:66:333)
    at g (http://localhost:8080/bower_components/angular/angular.min.js:51:299)
    at http://localhost:8080/bower_components/angular/angular.min.js:50:415
    at $get.h (http://localhost:8080/bower_components/angular/angular.min.js:52:283)
    at l (http://localhost:8080/bower_components/angular/angular.min.js:56:293)

Seems the problem is gone when I remove an ng-disabled directive. Maybe this has something to do with priority?

That seems reasonable to me. Would it be possible to send a pull request with a test or a modified index.html that demonstrates the problem?

I've added a checkbox that is bound to the ngif on the container with the old example. After the first hide, the example is broken.
<!doctype html>

    <title>Smoke Test</title>
    <meta content="text/html; charset=UTF-8" http-equiv="content-type">

    <link rel="import" href="test/x-double.html">

Smoke Test: angular-bind-polymer

        <input type="checkbox" ng-model="abba">
        Hide the polymer element using ngIf. Currently

        in:

        <input type=text value="6" ng-model="in">

        out:

        <x-double bind-polymer in="{{in}}" out="{{doubled}}"></x-double>

Created a PR for how I resolved this issue


Private github repositories are not listed in Github repo selection step

This issue has been migrated from :
https://github.com/mike-goodwin/owasp-threat-dragon/issues/119
and was opened by @rav94 :
The repository was listed only after I changed the repository permissions to the public mode. Think this would be an important option to have because you are providing the Github credentials expecting to view your private repos as well. Plus people would be reluctant to put their threat model diagrams in public.

Definitely we can't make threat models publicly available, Threat Dragon needs to use a private repo.

Agreed @FrankArchitect that this is a limitation of TD, and should be changed as soon as we can. Dow you know what needs to be done with TD + github to provide this? Any suggestions welcome
The alternative is to use Threat Dragon desktop version on a locally cloned repo, and then commit+push back up to the private repo when required. I know this is not using the webapp, and is more awkward process, but it may help here.
The desktop release is at :
https://github.com/mike-goodwin/owasp-threat-dragon-desktop/releases/tag/v1.2

This has a comment from @hemedga https://github.com/mike-goodwin/owasp-threat-dragon/commit/305296d10fc1d310613f28503cc050ede802027b#commitcomment-40338515
"this commit was a good shot for threatdragon.org.
However, we are going to self-host it and we are going to use private repositories.
I suggest moving this to an environment variable i.e. process.env.GITHUB_REPO.
We're going to test it in our environment.:


Change Crypto.org to Cronos

As per the official re-branding.

Not a big deal, but I believe this is technically incorrect. Although we may want to shift from describing the originating chain (e.g., Cronos chain vs Crpyto.org Chain) to describing the name of the token (e.g., Crypto.com Coin vs Cronos), that should be done at a system-wide level, and not by changing the 'chain name'. In this case, this CRO (Cronos) is not coming from the Cronos chain--these are coming from Crypto.org chain, and thus may result in confusion.

Agreed with @JeremyParish69
The name currently is the chain from which the token is originating.  Currently we only support deposits from Crypto.org chain, not Cronos
Once we add a way to display the asset name as well (not just chain name), we can update this.


cascading worldgen lag

30.05 19:07:00 [Server] Server thread/WARN [FML]: Dynamic Trees loaded a new chunk [-22, -8] in dimension 0 (overworld) while populating chunk [-21, -9], causing cascading worldgen lag.
30.05 19:07:00 [Server] Server thread/WARN [FML]: Please report this to the mod's issue tracker. This log can be disabled in the Forge config.
What other info can I give?

I stamp these out as I encounter them.  Sadly this doesn't produce a crash and thus no crash log.  Without a crash log I can't tell where the error is. You can however tell me what kind of biome this occurred in.  That might help me to reproduce it.

Forest biome

Unfortunately this issue is non-productive


NPM package maintainers

@lorenzofox3 could I have the access to publish updates on npm please?
Otherwise feel free to publish 1.1.1.

you are now an official maintainer :)


Investigate whether it's okay for indicator number field to accept a variety of formats

Right now, the indicator number field is a text field. This allows for a wide range of numbering conventions. It can also result in some strange numbers like "-2" -- for example, if someone intended to write 2-2 and misses the first 2.
Before we impose restrictions, we need to investigate whether teams actually need that level of flexibility -- for example, to meet donor numbering conventions.

No longer needed, addressed in Satsuma. We auto-number indicators unless teams opt out, in which case we allow flexible numbering conventions.


Add bash characters using CSS rule - 1.6

Removes all $ characters from the beginning of preformatted lines and allows
them to render via CSS+javascript instead.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/2450/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/2470/
Test FAILed.


piperidine (CHEBI:18049)

Some literature refs:
PMID: 15412
PMID: 799462
PMID: 5300194
PMID: 5308835
PMID: 15017096
PMID: 25897321
http://doi.org/10.1007/BF01299681

all of the above PMID's have now been added except the DOI since at the moment we are unable to add DOI links. thanks


chore(main): release 0.1.0

:robot: I have created a release beep boop
0.1.0 (2024-12-06)
Features

added rename user , rename s3 flavor (#34) (ebfb456)
Authorization resources (#26) (3f88cda)
Better S3 placeholders (#35) (a023c9d)
embedded rust (#15) (d7e9010)
parse first and given names from name field in profile (c925d1e)
Use S3 logo for s3-compat storages (#33) (de27d7d)

Bug Fixes

deps: update dependency axios to v1.7.9 (#4) (9dcb6bb)
fixed gcs and az (#20) (b573918)
gcs key details and initial message on bootstrap (#32) (6aaff01)

Miscellaneous Chores

release 0.1.0 (3b9c636)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v0.1.0
:sunflower:


Can't log unicode characters

Attempting to log a unicode character gives error:

Message: '    (3, 2): ┃}'
Arguments: ()
--- Logging error ---
Traceback (most recent call last):
File "C:\Users\brend\AppData\Local\Programs\Python\Python312\Lib\logging_init_.py", line 1163, in emit
stream.write(msg + self.terminator)
File "C:\Users\brend\AppData\Local\Programs\Python\Python312\Lib\encodings\cp1252.py", line 19, in encode
return codecs.charmap_encode(input,self.errors,encoding_table)[0]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
UnicodeEncodeError: 'charmap' codec can't encode character '\u2503' in position 88: character maps to

This can be fixed by adding utf-8 encoding to the file handlers.  But unicode shouild be added as a unit test as well.

    # Rotating file handler for debug messages
    debug_file_handler = RotatingFileHandler(
        filename=f'Logs/Debug/{info.app_name}_debug.log',
        maxBytes=1000000,
        backupCount=100,
        encoding='utf-8')
    debug_file_handler.setLevel(logging.DEBUG)
    debug_file_handler.setFormatter(formatter)

    # Rotating file handler for info messages
    info_file_handler = RotatingFileHandler(
        filename=f'Logs/Info/{info.app_name}_info.log',
        maxBytes=1000000,
        backupCount=100,
        encoding='utf-8')
    info_file_handler.setLevel(logging.INFO)
    info_file_handler.setFormatter(formatter)


docs: split backends readmes

I am creating separate readmes for each backends and adding some stuff to our main readme :)
Also testing Paul new features with this PR

/approve

/label merge


Update copyright and license for open source cFS framework release 6.6.0a

Need to update/add copyright and license to Apache 2.0 for open source release of 6.6.0a.

Imported from trac issue 285.  Created by jhageman on 2019-04-29T16:57:07, last modified: 2019-06-24T11:34:42

Trac comment by jhageman on 2019-05-03 14:47:36:
See [changeset:c2b6958], in rc-6.6.0a

Trac comment by jhageman on 2019-06-24 11:34:33:
Tested as part of CS verification by Walt Moleski on mcp750 with VxWorks 6.9.

Trac comment by jhageman on 2019-05-08 13:42:12:
CCB 5/8/2019 - Code reviewed and approved


Do not Macmini 7,1 (Intel Iris 5100) to run engine tests

Please remove these from engine infra configs.
@ricardoamador @yusuf-goog  as infra oncall
These bots are failing engine related tests, and we're finding we have to implement a bunch of work arounds in the infra config to try to avoid using them. There are only a few.
https://chromium-swarm.appspot.com/botlist?c=id&c=task&c=os&c=status&d=asc&f=gpu%3A8086%3A0a2e&f=pool%3Aluci.flutter.staging&k=pool&s=id and https://chromium-swarm.appspot.com/botlist?c=id&c=task&c=os&c=status&d=asc&f=gpu%3A8086%3A0a2e&f=pool%3Aluci.flutter.try&k=pool&s=id are the lists. None of these bots should run engine tests at all. They are fine for framework tests.
@zanderso @chinmaygarde fyi

The execution of unit tests is deeply embedded in the builds. I believe people from engine with a better understanding of the builds is better equipped to make these changes in .ci.yaml or build configurations.
An alternative is to provide a list of builds that  should not use Macmini 7,1 so that infra can help with the change.

Note the way to work around this probably shouldn't be to specify mac_model=Macmini8,1 since that's forcing us to use  Intel Macmini8,1 instead of giving the flexibility to run on either those bots or arm Macmini9,1 bots, but not Macmini7,1.

I think what @dnfield means is that  Macmini 7,1 should not be used by engine CI (try, staging, prod) for anything. Our assumption is that there is a global infra setting or configuration that can accomplish that rather than going over every sub-build individually.

I think what @dnfield means is that Macmini 7,1 should not be used by engine CI (try, staging, prod) for anything. Our assumption is that there is a global infra setting or configuration that can accomplish that rather than going over every sub-build individually.

Definitely, I agree, would be good to remove them from the pool.  I meant that our workarounds like #41203 and #41159 locking to Macmini8,1 are preventing us from running those builds on either arm or Intel as capacity allows, and removing Macmini7,1 from the pool would solve that problem.

This can be achieved by adding a dimensions property here https://cs.opensource.google/flutter/engine/+/main:.ci.yaml;l=57. Dimensions are lists of values merged by or in the swarming service.
Please let us know if the functionality does not work out of the box.

@godofredoc I can't see any documentation for what you're suggesting in the docs linked at the top of the ci.yaml here: https://github.com/flutter/cocoon/blob/main/CI_YAML.md.
Can you please like to documentation for what you're describing, or an example of something similar being done in another configuration? If neither of those exist, I would suggest that this issue is correctly on the infra ticket queue, and we need help from the infra gardener in order to get this done.

@zanderso https://github.com/flutter/flutter/blob/master/.ci.yaml#L1452 that target uses dimensions.

@ricardoamador Thanks! I'm having trouble reconciling that example with what @godofredoc said above: "Dimensions are lists of values merged by or in the swarming service." In the example, dimensions appears to be a map, but @godofredoc said it is a list, so I'm still not sure how to accomplish what this issue is asking for.

Hmm, maybe he mistyped? They should be a map. You will need to specify the key and the value.

https://github.com/flutter/engine/pull/41219 <- ptal

I think you might need to unindent the dimensions. The dimensions do not go under properties.

Could we move these bots to a separate pool and then not include that pool in engine builds/tests?

The main problem with the configuration file updates is there are a lot of places that end up needing this, and some of those places don't allow comments, and no one seems to have a good way to make sure we're covering all of them short of watching for a new failure to pop up.

We can ask chromium to  remove them but we will be getting rid of ~10% of the try mac intel capacity. If we are ok with that we can follow up with a chromium bug but just to set expectation the queue time in try will increase considerably.

We can ask chromium to remove them but we will be getting rid of ~10% of the try mac intel capacity. If we are ok with that we can follow up with a chromium bug but just to set expectations, the queue time in try will increase considerably.

We don't need them to be removed completely, we just need to make sure they're not used for engine builds.


Don't print cargo version to stdout, breaking everything

bors r+
🤖

Just wanted to say: seeing this entry in the changelog gave me a good chuckle.
I think we've all had moments/days like that.
Thanks for all your work on Rust Analyzer! I really love how much more productive it makes me.


Remove dependency on IsGlyphFullWidth for IRM/DECSWL

This gets rid off the implicit dependency on IsGlyphFullWidth
for the IRM and DECSWL/DECDWL/DECDHL implementations.
Validation Steps Performed
In pwsh:

"`e[31mab`e[m`b`e[4h`e[32m$('*'*10)`e[m`e[4l"
prints a red "a", 10 green "*" and a red "b" ✅
"`e[31mab`e[m`b`e[4h`e[32m$('*'*1000)`e[m`e[4l"
prints a red "a" and a couple lines of green "*" ✅
"`e[31mf$('o'*70)`e[m`e#6`e#5"
the right half of the row is erased ✅

Amazing! I see a lot of tests moved to use Replace as well... which makes me think that we should have tests for Insert, right?

I fear you may have mistaken COOKED_READ_DATA for tests since it's so repetitive. Currently TextBuffer::Replace is mostly covered via integration tests via the VT unit and Host unit/feature test projects. The test coverage is pretty good I think. We also have IRM tests which cover the TextBuffer::Insert call but its coverage is not as good.
We do have a pretty good unit test coverage of ROW::ReplaceText though, which I think is the most important one. Both TextBuffer::Replace and TextBuffer::Insert are based on that function after all.

I fear you may have mistaken COOKED_READ_DATA for tests since it's so repetitive.

I sure did!


Fix the scaffolder validator for arrays when the item is a field in the object

Hey, I just made a Pull Request!
I found the issue on not triggered validation on the object field of the array field.
Example to reproduce is:

apiVersion: scaffolder.backstage.io/v1beta3
kind: Template
metadata:
  name: some-template
spec:
  owner: myteam
  type: other
  parameters:
    - title: Provide information about the service
      required:
        - project_description
      properties:
        project_description:
          title: Project description
          type: string
        catalogLinks:
          title: Links for your service
          description: '(Optional) Add links that are related to the service: documentation, dashboard, internal page, etc.'
          type: array
          items:
            type: object
            required:
              - url
              - title
              - icon
            properties:
              url:
                title: url
                description: url
                type: string
                ui:field: UrlExtension
              title:
                title: title
                description: title of your url
                type: string
              icon:
                title: icon
                type: string
                description: 'Icons are from: https://v4.mui.com/components/material-icons/'
                enum:
                  - description
                  - chat
                  - dashboard
                  - subject
                  - webasset
                  - whatshot
                default: description
    - title: Choose location of existing repository
      description: Provide the GitLab clone URL. Both SSH and https urls are fine.
      properties:
        repoUrl:
          title: Repository Location
          type: string
          ui:field: GitlabUrlPicker
          ui:options:
            requestUserCredentials:
              secretsKey: USER_OAUTH_TOKEN

  # here's the steps that are executed in series in the scaffolder backend
  steps:
    - id: fetch
      name: Template Docs Skeleton
      action: fetch:template
      input:
        url: ./skeleton
        values:
          name: ${{ parameters.name }}
          description: ${{ parameters.project_description }}
          destination: ${{ parameters.repoUrl | parseRepoUrl }}
          owner: ${{ parameters.owner }}

    - id: publish
      name: Publish
      action: publish:github
      input:
        allowedHosts: [ "github.com" ]
        description: This is ${{ parameters.name }}
        repoUrl: ${{ parameters.repoUrl }}

    - id: register
      name: Register
      action: catalog:register
      input:
        repoContentsUrl: ${{ steps.publish.output.repoContentsUrl }}
        catalogInfoPath: "/catalog-info.yaml"

  output:
    links:
      - title: Repository
        url: ${{ steps.publish.output.remoteUrl }}
      - title: Open in catalog
        icon: catalog
        entityRef: ${{ steps.register.output.entityRef }}

where UrlExtension can be something like
import React from 'react';
import {
  createScaffolderFieldExtension,
  FieldExtensionComponentProps,
} from '@backstage/plugin-scaffolder-react';
import { scaffolderPlugin } from '@backstage/plugin-scaffolder';
import { TextField } from '@material-ui/core';
import { FieldValidation } from '@rjsf/core';

type UrlItem = {
  icon: string;
  title: string;
  url: string;
};

/**
 * URL Picker
 */
export const UrlPicker = (props: FieldExtensionComponentProps<any>) => {
  const {
    onChange,
    required,
    schema: { title = 'Urltest' },
    rawErrors,
    formData,
    uiSchema: { 'ui:autofocus': autoFocus },
    idSchema,
    placeholder,
  } = props;

  return (
    <TextField
      id={idSchema?.$id}
      label={title}
      placeholder={placeholder}
      required={required}
      value={formData}
      onChange={({ target: { value } }) => onChange(value)}
      margin="normal"
      error={rawErrors?.length > 0 && !formData}
      inputProps={{ autoFocus }}
    />
  );
};

export const validation = (
  items: UrlItem[],
  fieldValidation: FieldValidation,
) => {
  const regex = /https:\/\/(\S+)/;
  const invalidUrls = items.reduce(
    (acc: string[], item: UrlItem) =>
      regex.test(item.url) ? acc : [...acc, item.url],
    [],
  );
  if (invalidUrls.length > 0) {
    fieldValidation.addError(
      `Url(s) [${invalidUrls}] are invalid. Urls must start with https://`,
    );
  }
};

export const UrlExtension = scaffolderPlugin.provide(
  createScaffolderFieldExtension({
    name: 'UrlExtension',
    component: UrlPicker,
    validation,
  }),
);

That how it looks, if to apply the validation on a url field, which is one of properties in the object field.

There is also a unit test to cover this case.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

@acierto does this happen with the scaffolder/next plugin too?

@acierto does this happen with the scaffolder/next plugin too?

@benjdlambert indeed, there is also fix required, included it to this PR too


Not compatible with chai 4?

Hi @JrSchild - thanks for maintaining this chai plugin. It's very useful and should be a mandatory consideration for any project doing stuff with json and chai.
I've recently upped chai to version 4, and when installing chai-json-schema npm warns The package<EMAIL_ADDRESS>does not satisfy its siblings' peerDependencies requirements! (see travis jobs 99.1 - 99.3 and the PR greenkeeper made to up chai).
On npm versions < 3 (those distributed with node 4 and 0.x) this breaks any build using chai-json-schema.
I've forked chai-json-schema, changed the chai peerDependencies range to >= 1.6.1 < 5, upped the chai dependency to 4.0.2 and ran the test suite => works OK.

Would you be willing to either make these changes or accept mine as a pull request?
In #26 I see there's some chores for this project that need doing. I'm willing to pick up some of these + the request @keithamus has for changing some build/ code quality tooling to chaijs guidelines. Would you be OK with that?

A PR would be welcome IMO, but you should get a consensus from the rest of the @chaijs/chai-json-schema team

Hi @sverweij, I'm okay with you going ahead to fix the dependency versions. Feel free to create a PR.
Regarding the other items in the TODO list in issue #26. They're not really high priority because everything works well enough. We won't be spending too much time on it. However, should you feel inclined to help out, then those items could certainly use some attention.

👍  see ☝


fix: pydantic issues with langchain chat prompt and allow additional …

…messages

Makes sense to expose additional variables, although agent_scratchpad is a LangChain internals.
Curious to see what's the langchain chat prompt they used, would be good to have it in the examples.


add scaffolding for executable python spec

the ethereum consensus specs are executable, such that the specs are testable, and test vectors can be generated for consensus clients to consume. the builder specs should be executable in a similar way.
the scope of this issue is to set up the basic scaffolding for executable builder specs.
for example:

script to parse the markdown files and generate python files with defined constants, containers, functions, etc
minimal test(s)
mechanism to execute the test(s) (e.g. Makefile)

cannot assign myself, but I'm working on this


Add Getting started notebook - Fixes 101

This is a Google Colab compatible notebook for getting started with caikit-nlp

Anyone reviewing- the 'files changed' tab just shows a json of a notebook, which isn't super-helpful. As a convenience, here's a link to the notebook rendered by github:
https://github.com/rawkintrevo/caikit-nlp/blob/101/examples/Caikit_Getting_Started.ipynb


Prepare deck to provide an update to Mathieu - Transitioned to One Page Update

Skeleton:

Agenda
Micro Procurement Refresh (1 pager outlining why we are doing this)
Progress since our last meeting (Engagement with CFOB/co-sponsorship/CFO nod, Credit Cards/Paypal, Solution Design, - RACI/Process, FPS engagement and CC custodians, Re-use of existing systems, Design Document, Lite Process, potential clients)
High Level run through of how it will work
Delivery Plan (IT Strategy will deliver service for 1 year ~ 10 engagements, List of major upcoming milestones, Q1 promotion, Q2 launch)
Challenges / Barriers (EA approval delays)
Next steps

Draft deck here:  https://sara-sabr.github.io/util-presentation/presentation.html?url=https://raw.githubusercontent.com/sara-sabr/ITStrategy/micro-procurement-status/presentations/en/Micro-procurement_Nov_status.md
December Status update one-pager here:  https://014gc.sharepoint.com/:w:/r/sites/GCDevEx/Shared Documents/Micro-acquisition pilot_status Dec 2020.docx?d=wbfec116bb2154917814585e2cbc7ecd4&csf=1&web=1&e=CnH0Ou (ESDC internal link)


3D Fungi

Only brown mushrooms so far. If anyone wants to pitch in, feel free. I'm really bad at textures.

I'm almost finished, so don't start working on textures.

Just added a bunch more packs:
GoldenSavanna
NoCherryLeavesParticles
PotterySherdToShard
QuieterAllays
QuieterCamels
QuieterIronGolems
QuieterSniffers
QuieterSnowGolems
QuieterTadpoles
QuieterWardens
QuieterThunder
QuieterExplosions
QuieterSculkShriekers
QuieterSculkSensors
QuieterConsumables
MangroveSwampPanorama
AllayElytra

jk I'll merge this


Make popup poll interval configurable

This PR:

Makes poll frequency for Popup hash monitoring configurable for MSAL Browser
Reduces default poll interval to 30ms in order to increase Popup interaction reliability
Updates configuration docs

Codecov Report

Merging #5276 (3f99287) into dev (fa71735) will decrease coverage by 0.32%.
The diff coverage is 100.00%.

Flag
Coverage Δ

*Carryforward flag

msal-angular
96.50% <ø> (ø)

msal-browser
86.94% <100.00%> (ø)

Carriedforward from 72fdd1f

msal-common
85.26% <ø> (ø)

Carriedforward from 72fdd1f

msal-core
82.84% <ø> (ø)

Carriedforward from 72fdd1f

msal-node
82.90% <ø> (ø)

Carriedforward from 72fdd1f

msal-node-extensions
76.03% <ø> (?)

Carriedforward from 72fdd1f

msal-react
94.50% <ø> (ø)

node-token-validation
88.88% <ø> (ø)

Carriedforward from 72fdd1f

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files
Coverage Δ

lib/msal-browser/src/utils/BrowserConstants.ts
100.00% <ø> (ø)

lib/msal-browser/src/config/Configuration.ts
95.23% <100.00%> (ø)

...msal-browser/src/interaction_client/PopupClient.ts
94.22% <100.00%> (ø)

...ser/src/interaction_client/SilentAuthCodeClient.ts
80.00% <100.00%> (ø)

...owser/src/interaction_client/SilentIframeClient.ts
96.49% <100.00%> (ø)

...l-browser/src/interaction_handler/SilentHandler.ts
87.30% <100.00%> (ø)

...extensions/src/persistence/LibSecretPersistence.ts
88.23% <0.00%> (ø)

...node-extensions/src/persistence/FilePersistence.ts
73.77% <0.00%> (ø)

...ions/msal-node-extensions/src/dpapi-addon/Dpapi.ts
100.00% <0.00%> (ø)

... and 12 more


[v1.17] Unable to use runAsNonRoot: true or specify custom user when deploying to Kubernetes

Bug Description
In #321, we switched from using gcr.io/distroless/base to gcr.io/distroless/base-debian10:nonroot for the best container. This has the unintended side effect of making the container somewhat fussy about which user it's allow to run as when deployed to k8s.
Example code (or command)
Example 1:
securityContext:
     runAsNonRoot: true

Example 2:
securityContext:
    runAsUser: 2
    fsGroup: 2

Stacktrace
Example 1:
Error: container has runAsNonRoot and image has non-numeric user (nonroot), cannot verify user is non-root

Example 2:
Error: failed to start container "myapp-sql": Error response from daemon: OCI runtime create failed: container_linux.go:345: starting container process caused "chdir to cwd (\"/home/nonroot\") set in config.json failed: permission denied": unknown

Workaround
The issue can be solved by manually specifying the numeric user_id:
securityContext:
  runAsNonRoot: true
  runAsUser: 65534
  runAsGroup: 65534

Potential Solutions
Solution 1
Revert to using gcr.io/distroless/base as the base image. We can provide a separate nonroot image for users to use for additional security.
Pros: This has the advantage the the user can whatever uid they prefer (note: unclear if this is necessary)
Cons: This provides a less secure option by default.
Solution 2
Specify the numeric uid instead of nonroot in the dockerfile.
Pros: This provides a more secure path by default.
Cons: Users won't be able to specify a user outside of nonroot or runAsUser: 655534

I'm seeing the same issue when trying to start v1.17 inside a Container-Optimized OS Compute Engine instance.  It runs fine on v1.16.
Running with the following command:
docker run -d -v /mnt/stateful_partition/cloudsql:/cloudsql gcr.io/cloudsql-docker/gce-proxy:1.17 /cloud_sql_proxy -dir=/cloudsql -instances=<instance_id> -ip_address_types=PRIVATE

gives the log output:
2020/05/13 11:58:25 current FDs rlimit set to 1048576, wanted limit is 8500. Nothing to do here.
2020/05/13 11:58:26 errors parsing config:
	mkdir /cloudsql/<instance_id>: permission denied

What is the workaround for docker on Container-Optimized OS?

@wwuck You need to make sure you've given non-root users permission to rw in /cloudsql:
chmod +rw /cloudsql

Thanks @kurtisvg.  I got it working with chmod a+rw /mnt/stateful_partition/cloudsql.  I also got it working with chown 65532:65532 /mnt/stateful_partition/cloudsql so I don't need to have that directory global RW.

Just a correction to the workaround: runAsUser: 65534 should be runAsUser: 65532. The error still happens with 65534. Please edit the bug description if possible so that users who come to this thread to grab the workaround get the working one straight away :)

Thanks - typo on my part, I've updated the original issue

Given no major objections or other information surfacing, I'm going go with option 2.


Epic games trying to open web pages in the middle of the game.

Certain Epic games installed with Steam-Buddy require your permission to link/connect with your Epic account.
They do that by trying to open a web page immediately after the game is started, which can cause the controller to eventually become unresponsive, or even crash the game. Also, after the game is stopped, the extra window opened is still present and not responsive, requiring a Steam/Gameros restart.
A workaround would be to:

Install with Steam-Buddy the Chromium browser from FlatHub (possibly also Firefox).
Start the game and after few seconds close it back.
You will see a web page opened on your Epic account, asking you to accept the agreement. The controller can't be used right now.
Toggle the compositor from the Steam-Buddy interface (upper right gear icon).
You can now use the controller to press "Accept". Once you do that, it will never bother you again.
Go back to the Steam-Buddy interface and restart Steam.

Example of games affected: Killing Floor 2, Remnant: From the Ashes.

This should be fixed in ChimeraOS 31. The web pages will open in the Steam browser in the background.


Fix SSA Graph from Kunai

The SSA algorithm is not correctly applied in those blocks that belongs to exception catcher blocks, check what error exists. Also in those cases where the IRPhi only receives one parameter, remove that IRPhi since it is not necessary.

Fixed with the last two commits (https://github.com/Fare9/KUNAI-static-analyzer/commit/5140e853af3bdf2a12f3e28008721f40b1f9ed08 and https://github.com/Fare9/KUNAI-static-analyzer/commit/d400d3e36e0691719cbca9f3f612931ab851a59f), now the catch blocks are always processed, and some useless phi nodes removed, in case the result of a phi node is not used after that, it can be removed through an optimization.

Fixed with the last two commits (https://github.com/Fare9/KUNAI-static-analyzer/commit/5140e853af3bdf2a12f3e28008721f40b1f9ed08 and https://github.com/Fare9/KUNAI-static-analyzer/commit/d400d3e36e0691719cbca9f3f612931ab851a59f), now the catch blocks are always processed, and some useless phi nodes removed, in case the result of a phi node is not used after that, it can be removed through an optimization.


ValueError: Duplicated timeseries in CollectorRegistry: {_last_received}

Hello there,
I just discovered your mqtt_exporter and I think I have found a problem. I am quite new to python and have not much programming knowledge yet. This is more like a documentation of what I have found yet.
Problem 1:
I only became the exporter to run, when using the requirements-frozen.txt. When I just used the requirements.txt i always got the exception  mentioned in the title and the exporter stopped.
Problem  2:
I noticed that the <name_as_configured>_last_received only changes if i restart the exporter, for one run the exported value just keeps constant..
Okay, so i changed logging to debug, and i really just get the messages for the _last_received only the first time after restart.
Some more digging and understanding later I boiled it down to this line:
https://github.com/fhemberger/mqtt_exporter/blob/master/mqtt_exporter.py#L352
I added another except to get more information:
    try:
        prometheus_metric_types[metric['type'].lower()](
            label_names, label_values, metric, name, value)
        logging.debug(
            f"_export_to_prometheus metric ({metric['type']}): {name}{labels} updated with value: {value}")
    except KeyError:
        logging.warning(
            f"Metric type: {metric['type']}, is not a valid metric type. Must be one of: {list(prometheus_metric_types.keys())}")
    except:
        logging.debug(f"something went wrong. {name} - {sys.exc_info()}")

And now in the logs i get:
021-06-04 22:59:22,218 DEBUG: something went wrong. mqtt_hum_last_received - (<class 'ValueError'>, ValueError("Duplicated timeseries in CollectorRegistry: {'mqtt_hum_last_received'}"), <traceback object at 0xffffb36dcc00>)

So.. its the same error message as in 1).. but now I have no idea how i should go on...
One assumption could be that in a newer version of the prometheus_client this error is not silent anymore and leads to termination... but as I said.. I have not really an idea what this error is about... nor how to fix it...
So now i am hooked, I will have a look at the prometheus_client tomorrow. If someone could point me in a direction please do so ;-D I am quite happy to have learned "enough" basics that i understand something.. i only can learn more on this journey xD

Sorry it took so long to get back to you, didn't get any notifications for this repo. 😠
I have to check what's going on here, I'm not a python expert either, just fixed a few issues with the original repository. I know that the _last_received metrics are buggy but wasn't able to fix them so far.

Sorry, I'm having trouble reproducing that issue with my local MQTT/exporter setup.
I updated the dependencies (including prometheus_client) and set the derived metrics to always be of type Gauge. Could you please check if the problem still occurs?

I had the same issue, but try/except this issue didn't work for me.
https://github.com/fhemberger/mqtt_exporter/pull/18 had fixed it.
The problem is that the state for derived metrics is not kept if you have wildcards in your topic. This pr is adding this to the runtime metrics object.


Update "bridge." section in CommonlyUsedTools

With today's release of bridge. v2.3.0 we have released rewrites and updates of our documentation; this PR modifies some of the links to bridge. and slightly changes the wording of its description on this page.

@Joelant05 Completely missed your PR, I think we should close this one in favor of #465 though


Rename hosts to nodes

Rename:
host -> node
hosts -> nodes
To keep things more generic.

I like host quite a bit better than node (i.e. it is the term I expect to use in this context). To me they cover the same set of referents (i.e. one is not more generic than the other).

So your definition of node is just any endpoint? So the distinction between node and host is that node would encompass API endpoints?
I guess I have a different definition of node (as I am not seeing in your analogy how the use of node would clarify the situation).
That being said...I don't care much one way or the other (so have at it, if you both want to change it).

From a pure terminology point of view I would look at it like this:
class Node:
    pass

class Host(Node):
    pass

In that sense I see node as a more generic object than host.

I didn’t mean that we should use both. Only that I view node as a broader more generic definition that host.

On 16 Apr 2018, at 20:22, Kirk Byers<EMAIL_ADDRESS>wrote:
I am concerned it will add confusion (without adding much value).
I would say we just pick one node or host and use it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Okay, no worries...totally misunderstood what you were saying there :-)
But now it makes sense.

What is a datapoint?
This seemed like a strange way of phrasing this sentence:
making the relevant data for that node (and its parents groups) available (which makes me worried I am not following how you intend things to be used).

A datapoint would be a fancy name for variables or properties. :)

Okay, makes sense...I was still thinking in terms of things (nodes/hosts) and not in terms of attributes.

Ok, even though I think we kind of agree Node is the correct term, after updating most of the code/examples/docs/etc everything becomes a bit confusing so I think I am going to close this ticket and maybe add some documentation (eventually) using examples where we use brigade outside the realm of "hosts automation".


[Enhancement] Support JSON  CQ Files and offset In-place Upgrade  to RocksDB

Which Issue(s) This PR Fixes
Fixes #8589
之前的讨论参考：https://github.com/apache/rocketmq/pull/8600
Refer to the previous discussion at: https://github.com/apache/rocketmq/pull/8600
Brief Description

How Did You Test This Change?

Codecov Report
Attention: Patch coverage is 24.63235% with 205 lines in your changes missing coverage. Please review.

Project coverage is 47.45%. Comparing base (ba8148f) to head (edb601f).

Files with missing lines
Patch %
Lines

...ocketmq/broker/processor/AdminBrokerProcessor.java
0.00%
61 Missing :warning:

...mand/queue/CheckRocksdbCqWriteProgressCommand.java
0.00%
38 Missing :warning:

...mq/broker/offset/RocksDBConsumerOffsetManager.java
52.94%
10 Missing and 6 partials :warning:

...org/apache/rocketmq/store/RocksDBMessageStore.java
0.00%
15 Missing :warning:

...org/apache/rocketmq/store/DefaultMessageStore.java
33.33%
11 Missing and 1 partial :warning:

...g/apache/rocketmq/client/impl/MQClientAPIImpl.java
0.00%
8 Missing :warning:

...ache/rocketmq/store/config/MessageStoreConfig.java
41.66%
7 Missing :warning:

.../subscription/RocksDBSubscriptionGroupManager.java
53.84%
4 Missing and 2 partials :warning:

...cketmq/broker/topic/RocksDBTopicConfigManager.java
50.00%
4 Missing and 2 partials :warning:

.../rocketmq/broker/offset/ConsumerOffsetManager.java
58.33%
3 Missing and 2 partials :warning:

... and 11 more

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8687      +/-   ##
=============================================
- Coverage      47.55%   47.45%   -0.11%
- Complexity     11546    11550       +4
=============================================
  Files           1277     1280       +3
  Lines          89449    89696     +247
  Branches       11504    11540      +36
=============================================
+ Hits           42535    42562      +27
- Misses         41706    41900     +194
- Partials        5208     5234      +26

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

1111


[ci/cd] Implement yamllint or similar tool

This FR is created as a follow up of https://github.com/newrelic/helm-charts/issues/407 and https://github.com/newrelic/helm-charts/issues/408
We noticed that the current linter is letting duplicate keys error passing, this is related to https://github.com/helm/helm/issues/5524.
I raised again the concern in https://github.com/helm/chart-testing/issues/344 they suggested to use yamllint that we can leverage in the meanwhile in our pipeline in order to avoid such errors to happen in the future
Thanks again to @DWSR for raising the concern!

chart-linter uses yamllint under the hood.
I did a test and duplicated a YAML value in the nri-bundle:
prometheus:
  enabled: false
  enabled: true

prometheus:
  enabled: true

And if failed:
Linting chart 'nri-bundle => (version: "4.3.3", path: "charts/nri-bundle")'
Validating /data/charts/nri-bundle/Chart.yaml...
Validation success! 👍
charts/nri-bundle/values.yaml
  8:3       error    duplication of key "enabled" in mapping  (key-duplicates)
  10:1      error    duplication of key "prometheus" in mapping  (key-duplicates)

Closing.


Rest client does not properly add headers from ClientHeadersFactory

This issue will be fixed whenever we update jersey dependency in Helidon, which contains fix for the following issue. Jersey #4715
It is not needed to be added to the Backlog project.

Jersey issue was fixed in version 2.34.
Helidon 4.x has jersey 3.1.5
Helidon 3.x has jersey 3.0.12
Helidon 2.x has jersey 2.41
Should this issue be closed?