[Question] Dealing with the Visual tree.

TD;DR
I am getting an exception when trying to move the content of one ContentPresenter to another ContentPresenter/
See the ContentPresenters:
https://github.com/Mabiavalon/DockNC/blob/master/src/Mabiavalon.DockNC/Themes/Controls.paml#L33
See where the FirstItem and SecondItem Properties are in Branch:
https://github.com/Mabiavalon/DockNC/blob/master/src/Mabiavalon.DockNC/Branch.cs#L19
See the code the exception is thrown at:
https://github.com/Mabiavalon/DockNC/blob/master/src/Mabiavalon.DockNC/DockControl.cs#L49
Exact line where the exception is thrown:
https://github.com/Mabiavalon/DockNC/blob/master/src/Mabiavalon.DockNC/DockControl.cs#L59
Seen an image:
https://files.gitter.im/danwalmsley/Ugb2/image.png
How do I get around this issue???
===========
In WPF if I were to remove a Button from the Content property of a ContentPresenter the Button's visual parent should be set to null. Effectively detaching it from the visual tree.
This does not happen for me in Avalonia.
I have a control called Branch.
This is the control:
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using Avalonia;
using Avalonia.Controls;
using Avalonia.Controls.Presenters;
using Avalonia.Controls.Primitives;
using Avalonia.Styling;

namespace Mabiavalon.DockNC
{
    public class Branch : TemplatedControl
    {
        public static readonly StyledProperty<Orientation> OrientationProperty =
            AvaloniaProperty.Register<Branch, Orientation>("Orientation");

        public static readonly StyledProperty<object> FirstItemProperty =
            AvaloniaProperty.Register<Branch, object>("FirstItem");

        public static readonly StyledProperty<object> SecondItemProperty =
            AvaloniaProperty.Register<Branch, object>("SecondItem");

        public static readonly StyledProperty<GridLength> FirstItemLengthProperty =
            AvaloniaProperty.Register<Branch, GridLength>("FirstItemLength", new GridLength(0.49999, GridUnitType.Star));

        public static readonly StyledProperty<GridLength> SecondItemLengthProperty =
            AvaloniaProperty.Register<Branch, GridLength>("SecondItemLength", new GridLength(0.50001, GridUnitType.Star));

        static Branch()
        {
            PseudoClass(OrientationProperty, o => o == Avalonia.Controls.Orientation.Vertical, ":vertical");
            PseudoClass(OrientationProperty, o => o == Avalonia.Controls.Orientation.Horizontal, ":horizontal");
        }

        public Orientation Orientation
        {
            get { return GetValue(OrientationProperty); }
            set { SetValue(OrientationProperty, value); }
        }

        public object FirstItem
        {
            get { return GetValue(FirstItemProperty); }
            set { SetValue(FirstItemProperty, value); }
        }

        public object SecondItem
        {
            get { return GetValue(SecondItemProperty); }
            set { SetValue(SecondItemProperty, value); }
        }

        public GridLength FirstItemLength
        {
            get { return GetValue(FirstItemLengthProperty); }
            set { SetValue(FirstItemLengthProperty, value); }
        }

        public GridLength SecondItemLength
        {
            get { return GetValue(SecondItemLengthProperty); }
            set { SetValue(SecondItemLengthProperty, value); }
        }

        public bool BranchFilled => FirstItem != null && SecondItem != null;

        public double GetFirstProportion()
        {
            return (1 / (FirstItemLength.Value + SecondItemLength.Value)) * FirstItemLength.Value;
        }

		protected override void OnTemplateApplied(TemplateAppliedEventArgs e)
		{
			base.OnTemplateApplied(e);

			FirstContentPresenter = e.NameScope.Find<ContentPresenter>("PART_FirstContentPresenter");
			SecondContentPresenter = e.NameScope.Find<ContentPresenter>("PART_SecondContentPresenter");
		}

		internal ContentPresenter FirstContentPresenter { get; private set; }
		internal ContentPresenter SecondContentPresenter { get; private set; }
    }
}

This is the template
<Styles xmlns="https://github.com/avaloniaui" xmlns:local="clr-namespace:Mabiavalon.DockNC;assembly=Mabiavalon.DockNC">
    <Style Selector="local|Branch:vertical">
        <Setter Property="Template">
            <ControlTemplate>
                <Border Background="{TemplateBinding Background}"
                        BorderBrush="{TemplateBinding BorderBrush}"
                        BorderThickness="{TemplateBinding BorderThickness}">
                   <Grid Name="grid">
                    <Grid.RowDefinitions>
                      <RowDefinition Height="{Binding #grid.TemplatedParent.FirstItemLength, Mode=TwoWay}"/>
                      <RowDefinition Height="Auto"/>
                      <RowDefinition Height="{Binding #grid.TemplatedParent.SecondItemLength, Mode=TwoWay}"/>
                     </Grid.RowDefinitions>
                     <ContentPresenter Name="PART_FirstContentPresenter" Content="{TemplateBinding FirstItem}"/>
                     <ContentPresenter Grid.Row="2" Name="PART_SecondContentPresenter" Content="{TemplateBinding SecondItem}"/>
                    </Grid>
                </Border>
            </ControlTemplate>
        </Setter>
    </Style>
  <Style Selector="local|Branch:horizontal">
    <Setter Property="Template">
      <ControlTemplate>
        <Border Background="{TemplateBinding Background}"
                BorderBrush="{TemplateBinding BorderBrush}"
                BorderThickness="{TemplateBinding BorderThickness}">
          <Grid Name="grid">
            <Grid.ColumnDefinitions>
              <ColumnDefinition Width="{Binding #grid.TemplatedParent.FirstItemLength, Mode=TwoWay}" />
              <ColumnDefinition Width="Auto"/>
              <ColumnDefinition Width="{Binding #grid.TemplatedParent.SecondItemLength, Mode=TwoWay}"/>
            </Grid.ColumnDefinitions>
            <ContentPresenter Name="PART_FirstContentPresenter" Content="{TemplateBinding FirstItem}"/>
            <ContentPresenter Grid.Column="2" Name="PART_SecondContentPresenter" Content="{TemplateBinding SecondItem}"/>
        </Grid>
        </Border>
      </ControlTemplate>
    </Setter>
  </Style>
</Styles>

There are two properties of type object.

FirstItem
SecondItem

In the template a ContentPresenter binds to FirstItem and SecondItem
So if I set a Button to FirstItem the Content Property of the FirstContentProperty in Branch Becomes the Button.
When I attempt to move the Button from FirstItem to SecondItem by creating a copy of the object in FirstItem and a then setting FirstItem to null and finally setting the object to SecondItem:
var content = branch.FirstItem;
branch.FirstItem = null;
branch.SecondItem = content;

Content of FirstItemContentPresenter should be null and the Button should no longer have a visual parent which should allow me to set it anywhere I'd like in the visual tree.
If we were to mimic WPF in some way this is where I got the inspiration for it:
http://stackoverflow.com/questions/1074922/is-there-a-way-to-move-controls-in-the-visual-tree-wpf
This does not happen, so after setting FirstItem to null, which in turn makes FirstContentPresenter's Content property null, the Button still retains the FirstContentPresenter as it's visual parent, therefor when setting content to SecondItem I receive an exception.
The Control already has a visual parent.
var content = branch.FirstItem;
branch.FirstItem = null;
branch.SecondItem = content; //Exception: The Control already has a visual parent.

I was told that I should be able to remove the button from the VisualChildren collection however, these are ContentPresenters it only has a Child property in which chase I do not have the ability to subscribe to changes to do anything.

Thanks for the detailed explanation @Seeker1437! I need to test it, but this sounds like a bug - removing a control from the ContentPresenter should indeed set its VisualParent to null.

I just did a test and VisualParent is indeed being set to null when you remove it from the ContentPresenter. However, this is only done after ContentPresenter.UpdateChild; usually from a measure. I think this may be your problem. We might have to change the behavior of ContentPresenter to update its child immediately as I agree this behavior would be confusing...

AH makes sense, what would you recommend I do for now to solve it? Just call UpdateChild?

Yeah, for now just called UpdateChild. I will change the behavior of ContentPresenter - I was never sure if the way we were doing it was the best way, and now I know it's not ;)

Thank you so much for your help, I can confirm this is corrected my particular issue. :D


what node/npm versions are we testing w for 2.22?

want to update my scripts

k  scripts are node 16.9
min npm 7.11

see https://endoflife.date/nodejs
In the docker images I will switch from v16 to v18 with upcoming release.
Considering the tests we could increase to 16/18/19 after the Jan release, if not, we should do this after the April release.

thanks
I think I will stick to 16 for this upcoming release


Add program for parallel matrix multiplication and performance comparison

Fixes #87

Good Job 👍
Don't forget to give a ⭐ & Happy coding!. 😊


Crash when tried to join a multiplayer server

Hello, as the title says i crash when i join a multiplayer server. Yes, i got the correct version of Minecraft and SeedcrackerX. I tried 1.19 fabric loader with SeedcrackerX version 2.13.
And it crash my game with this as the output:
crash_report.txt

Nvm i just needed to delete the config file created by the mod.

Which config did you delete? I seem to have the same problem.


[BEAM-3545] Fix race condition w/plan metrics.

The last change introduced a race condition when initializing a plan. There's a small, but still open window where the progress reporting goroutine might try to read the value while it's being written to. A mutex clears this up.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

R: @youngoli

It's more that Down shouldn't be called while Execute/Process is running. It's part of the contract for Units (see exec/unit.go) that they aren't required to be concurrency safe.
The metrics do mess up this formulation though, since they must be accessible outside of the plan execution. I did consider instead simply having the store created outside of the plan, which would mean the harness would need to handle the asynchronous storage/access for it (probably as part of one of the maps in harness).  That would probably save a lock. What do you think?
There are several more changes coming here for PCollection and PTransform metrics,  and while I don't like churn, I'll be following up in another PR anyway, so it can be cleaned up then.

That makes sense.
I do kinda like moving the metrics store outside of the plan and into the harness/direct runner. It doesn't seem like the plan actually needs the store, it's just being used as a container for the harness/direct runner to access and pass it to monitoring. But it's such a small difference that I have no objections to leaving it as-is. I was mainly concerned whether there was another race condition, not so much about style.


[docs] Improve styled-components integration

Fixes https://github.com/mui-org/material-ui/issues/28559

Updates the styled-engine installation section with clear steps when using npm
Updates the examples that use create-react-app with styled-components to use https://github.com/gsoft-inc/craco (see why https://github.com/mui-org/material-ui/issues/28559#issuecomment-927740598)

Looks good but haven't been able to test it yet (quite swamped with other tasks at work) :)

Looks good but haven't been able to test it yet (quite swamped with other tasks at work) :)

Thanks for looking into it. I've tested it myself, but will wait for a confirmation from at least one more person :)

Added suggestions to make the distinction between Alias and Resolution clearer.

Thanks, I don't know what I kept referring to them as aliases.

Added suggestions to make the distinction between Alias and Resolution clearer.

Thanks, I don't know what I kept referring to them as aliases.

Probably because Webpack calls them "aliases".


New ability to explore statistics of Sv

Overview
Echoshader needs the ability to plot statistics from the Sv data so that users can see where the peak and spread of the Sv values for multiple channels/frequencies.
Expected Results
Users can choose an editable box on an echogram in one panel, and then in another panel
have the histogram of Sv values contained within that window. Users can also check the
distribution of the Sv differences across frequency and the shape of the Sv distribution
summarized as skewness and kurtosis.
Related issues

#20
#42
#34
#43

Proposed idea
For plotting statistics from sonar data interactively in https://github.com/OSOceanAcoustics/echoshader/issues/20#issue-1168728349

Component 1 : DatetimeRangePicker.  Control the time span.

Component 2 : Select. Select specific frequency and colormap.

Component 3 : MultiSelect. Select multiple frequency values to show combined plots.

Component 4 : ArrayInput. Customize colormap input.

Component 5 : Toggle.
Toggle between layout mode and outlay mode (see in https://github.com/OSOceanAcoustics/echoshader/issues/20#issuecomment-1100275045).

Component 6 : TextEditor. Output hist information like skewness and kurtosis.

Editable box in Sv image: Four selection modes: Overwrite; Intersect; Union; Inverse

Prototype
made by balsamiq

Originally posted by @ldr426 in https://github.com/OSOceanAcoustics/echoshader/issues/34#issuecomment-1105633269

Actions
@ldr426 please create small issues on the various steps that you're going to do to make this happen so that we can track it here. Thank you. Let me know if you have any questions.

Until now, I still use hvPlot to plot xarray data, because it offer exact interface to input xarray directly.  Holoviews can also deal with xarray data, which needs some transformation, sometimes can be onerous. Holoviews are primarily based on bokeh, a low-level tool which is based on Javascript. But A low-level tool is highly configurable, with an expressive but relatively verbose command language that makes it possible to precisely control how it works.
For example, getting data in box select cannot be done by hvPlot, which should be processed in holoview or even bokeh.
hvPlot, Holoviews and boken's relationship is like below.

So in initial work, I have to read lots of documents to get familiar with these python viz libraries. So I can know which tool is the most suitable for a specific task. Here lists some most common python viz libraries. If only using high-level tools, some accurate and subtle work would never be done. So it maybe burdensome to learn libraries related to holoview.

I'll close this now since most of the capabilities required here already exist, and we'll focus on refactoring the package structure and improving/benchmarking the performance going forward.
Just added the "good reference" label so that we can check back here for info later.


[docs] Provide recipe for running Chrome and Firefox with Travis

Running example: https://travis-ci.org/AndreyBelym/testcafe-example-travis-local/builds/184244319
Requires https://github.com/DevExpress/testcafe/pull/1068
\cc @DevExpress/testcafe-docs

FPR

FPR

@AndreyBelym I'll take care about this PR. Enjoy your vacation =)

FPR


Use VACUUM when migrating from DB versions below 21

Motivation
We need to vacuum the DB after migrations, and with #6085 merged, we need to use VACUUM INTO based migration for recent DB schema updates
Description
Set DatabaseVacuumState to 21 in the mainnet config.
Test Plan
Verifying on a mainnet node

bors merge


npm install xstate  Cannot find module 'xstate'

{
  "name": "test-xstate",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "jest"
  },
  "author": "",
  "license": "ISC",
  "dependencies": {
    "xstate": "^1.0.2"
  },
  "devDependencies": {
    "jest": "^20.0.4"
  }
}

and running
var xstate = require('xstate');

describe('test', function () {
  it('install xstate', function () {
    expect(xstate).not.toBe(undefined);
  });
});

leads to Cannot find module 'xstate'

It looks like the package.json is pointing towards a file that doesn't exist in the npm package, 'library/index.js'
Maybe it should be pointing at 'dist/xstate.js' instead, as the below code seems to work?
var xstate = require('xstate/dist/xstate.js')


[Fix-13144][UI] Worked out the issue with failing to query workflow instances by the incorrect workflow status.

Purpose of the pull request
This PR will close #13144 .

Brief change log
This issue is not caused by backend api. The root cause is because there are a few differences of the workflow execution status between the frontend and backend. So I've just aligned the workflow execution status with those from the backend.

Verify this pull request
This change added tests and can be verified as follows:

Manually verified the change by testing locally.

The test result is as follows:

Codecov Report

Merging #13243 (026fca8) into dev (5fe25c9) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #13243      +/-   ##
============================================
- Coverage     39.43%   39.39%   -0.04%
+ Complexity     4319     4314       -5
============================================
  Files          1077     1077
  Lines         40820    40789      -31
  Branches       4680     4665      -15
============================================
- Hits          16096    16068      -28
- Misses        22929    22930       +1
+ Partials       1795     1791       -4

Impacted Files
Coverage Δ

...r/plugin/registry/zookeeper/ZookeeperRegistry.java
43.54% <0.00%> (-7.26%)
:arrow_down:

...erver/master/processor/queue/TaskEventService.java
75.00% <0.00%> (-5.36%)
:arrow_down:

...org/apache/dolphinscheduler/remote/utils/Host.java
42.55% <0.00%> (-2.13%)
:arrow_down:

...hinscheduler/plugin/alert/script/ScriptSender.java
70.58% <0.00%> (-1.64%)
:arrow_down:

...e/dolphinscheduler/remote/NettyRemotingClient.java
51.38% <0.00%> (-1.39%)
:arrow_down:

...r/plugin/task/sqoop/parameter/SqoopParameters.java
51.19% <0.00%> (-1.20%)
:arrow_down:

...cheduler/plugin/alert/dingtalk/DingTalkSender.java
34.13% <0.00%> (-0.78%)
:arrow_down:

...rver/master/runner/task/BlockingTaskProcessor.java
75.86% <0.00%> (-0.55%)
:arrow_down:

...inscheduler/plugin/registry/etcd/EtcdRegistry.java
50.69% <0.00%> (-0.35%)
:arrow_down:

.../dolphinscheduler/plugin/task/datax/DataxTask.java
36.62% <0.00%> (-0.26%)
:arrow_down:

... and 18 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Implement ManifestEvaluator to prune mainfest files.

See python implementation

I suppose this issue has been taken according to https://github.com/apache/iceberg-rust/pull/241#issuecomment-1987506207?

I suppose this issue has been taken according to #241 (comment)?

Not yet, there are some dependencies not implemented yet, I'll open issues and clarify their dependencies.

@liurenjie1024
Is it correct that we need to implement the ProjectionEvaluator beforehand in order to provide the partition_filters
and extend TableScan with row_filter: Predicate?
https://github.com/apache/iceberg-python/blob/4ed5a144ecad69878cf47292557b17df31ffe5a8/pyiceberg/table/__init__.py#L753-L763

@liurenjie1024 Is it correct that we need to implement the ProjectionEvaluator beforehand in order to provide the partition_filters and extend TableScan with row_filter: Predicate?
https://github.com/apache/iceberg-python/blob/4ed5a144ecad69878cf47292557b17df31ffe5a8/pyiceberg/table/__init__.py#L753-L763

Yes, and before that we need to implement project for transform.

I just browsed the issues, you've already listed the dependencies here:
linking this for ref:
https://github.com/apache/iceberg-rust/issues/153

Close by #322


Update "Try Swarm at scale" tutorial to use Interlock 1.0.0

Version 1.0.0 of Interlock just shipped. The Try Swarm at scale tutorial uses ehazlett/interlock:latest.
However, from the README.md

The latest tag (v0.3.3) is the legacy version. That is kept for legacy purposes. It is strongly recommended to use the latest release as legacy is no longer maintained.

The "Try Swarm at scale" example needs to be updated to use ehazlett/interlock:1.0.0

Yes please, keep these tutorials and doc up to date.
You guys are the source of truth after all.

@everett-toews Thanks for bringing up the issue. We will update the doc.

cc @mgoelzer, @ehazlett. Can you comment on what should change from v0.3.3 to v1.0.0?

@dongluochen The main change is that the new interlock:1.0.0 is now using config data /file instead of flag arguments. You also need to explicitly use "ehazlett/interlock:1.0.0" to pick up this new version. Check other changes here.
https://github.com/ehazlett/interlock/blob/master/docs/getting_started.md
The docker documentation mentions flags, which doesn't work anymore when using v 1.0.0
https://docs.docker.com/swarm/swarm_at_scale/04-deploy-app/#step-4-start-the-voting-application

As @gittycat said a config file is now required (you can optionally use a KV store).  One other large change is an external proxy container is now required.  For example, the official "nginx" or "haproxy" images from the Docker Hub.  This keeps interlock small and allows for custom proxy images.

Try Swarm at scale has been rewritten and use interlock 1.0.1. See deploy your infrastructure.


[Project Proposal]: Online simple DarwinCore data format standard checker

Project Description
The IOOS Marine Life Data Network recommends aligning data that observes a species at a location and time to the DarwinCore Standard. Currently, there are various tools and resources available to check if a package matches the DarwinCore standard:

https://www.gbif.org/tools/data-validator
https://github.com/iobis/obistools
https://github.com/cioos-siooc/pyobistools
https://gbif.es/en/software/darwin-test/

Most of these checkers have some prerequisite requirements of installing additional software or creating an account in a system. Something that could be useful to the IOOS DMAC community would be an online web checker for DarwinCore, similar to the IOOS Compliance Checker - https://compliance.ioos.us/index.html, that doesn't require a log in and checks for additional aquatic characteristics in a dataset.
The idea is that this could be a relatively simple checker for the community to use to ensure their workflows are aligning with the standard.
Expected Outcomes
An online checker that allows a user to:

Upload a data file (occurrence, extended measurementorfact, event, DNA derived data or other applicable extensions.) or a DarwinCoreArchive package
Checks for compliance with the DarwinCore standard. If DarwinCore Archive, checks compliance with that standard.

Adds additional checks for aquatic data (eg. on land? contains depth information? taxonomy aligns to WoRMS?)
If metadata (EML) is provided, checks against that standard.

Provides the response back as various outputs (pdf, html, json, etc.),
Provides a web enabled API, similar to the compliance-checker API
A compliant data file could be directly loaded to an IPT by an OBIS Node manager.

Skills required

Depending on the source package used; R, Python, or BASH
Experience with front end data file loading
Experience with API development

Expertise
Intermediate
Topic Lead(s)
No response
Relevant links
Resources:

https://www.gbif.org/darwin-core
https://dwc.tdwg.org/terms/
https://discourse.gbif.org/t/how-i-check-darwin-core-datasets/3833
https://ipt.gbif.org/manual/en/ipt/latest/dwca-guide
https://rs.gbif.org/extensions.html
https://manual.obis.org/darwin_core.html

Tools:

https://github.com/cioos-siooc/pyobistools
https://github.com/iobis/obistools
https://github.com/iobis/obis-qc
https://gbif.es/en/software/darwin-test/
https://www.gbif.org/tools/data-validator
https://www.datafix.com.au/darwin-core-checker/
https://rshiny.lifewatch.be/BioCheck/
https://github.com/EMODnet/EMODnetBiocheck

xref:

https://github.com/ioos/ioos-code-sprint/issues/7
https://github.com/ioos/bio_data_guide/issues/85


Consider relative to pwd installation root when looking for files in rn module via cocoapods

Summary
The :reactNativePath provided by use_native_modules! is the rn module path relative to the installation root (usually ./ios). However, when executing cocoapods from a dir thats not the installation root, packages that use the relative :reactNativePath variable in their path must also consider the relative to pwd installation root.
This fixes usage of cocoapods with the --project-directory flag like
bundle exec pod install --project-directory=ios

Changelog
[iOS] [Fixed] - Fix usage of cocoapods with --project-directory flag and new arch
Test Plan

Enable the new arch
Execute from the projects root dir

bundle exec pod install --project-directory=ios

It will fail with

[!] Invalid `Podfile` file: [codegen] Couldn't not find react-native-codegen..

Apply the patch
Execute from the projects root dir

bundle exec pod install --project-directory=ios

It will succeed

Ping @dmitryrykun as he has relevant context on this. He already looked into relative path support for new arch so might be able to support here.

Hi @cortinico , @dmitryrykun 👋, any idea why this was reverted?

Hi @danilobuerger , the PR itself is okay. I'm not sure what happened. I probably did something wrong during merge, and this PR landed in conjunction with other changes, that broke our internal CI. I'll investigate this tomorrow. Sorry for the confusion.

that broke our internal CI

That was the reason essentially. It was reverted by another engineer. We can safely re-apply it now: #33427


Update deps

This PR updates sparsity to work with latest pandas version 0.25.0 and latest Dask version 2.2.0. Be sure to have latest versions of filesystem packages installed too.

@kayibal it would be cool to have it fixed and merged. Are you going to work on this?


Tooltip position issue in Firefox

The tooltip has no position set, so it appear at the bottom of the chart in Firefox, see this screenshot:

By looking into the JS console when running the examples, I have this error:
ReferenceError: event is not defined                     app.js:29752:18

It comes from BaseChart.js line 57 and 58:
onMouseMove() {
    if (!this.showTooltips) {
        return;
    }

    const top = (event.pageY - 10); // line 57
    const left = (event.pageX + 10); // line 58
...

In short window.event doesn't exist in Firefox, the work around would be to use the d3.event instead.

Ha, well spotted, I should probably do a browser audit! :)

Fixed in v1.1.1 :tada:


[DATASOURCE]: Initial mongodb and redis integration

Shouldn't there be a class for Mongo that inherit from the Memory class? just like how shelfstorage inherit from memory in jaclang?


fix(directive): fix template definition for webpack

Apparently it expected a webpack object attribute as opposed to it being a value in an array. I saw from your code highlight that it was pushing everything into an array. Added an indexOf check instead.

Aaaaaahhh, right. That's the way we do it in generator-angular-fullstack. There's actually a hasFilter method for just this. Do you think you could use that method instead? hasFilter('webpack')


Add 'Retry' button to connection errors

Expected behavior
A Retry link with "File an Issue"
Actual behavior
Just File an issue.
Information about the Issue
I closed my laptop in the middle of a connection, then I didn't know what to do.

There is no resume - when you close your laptop the connection is cut and this will need to be re-tried with a proper connection.

That's what I meant, I had to quit and restart docker because there was nothing similar to "try again" on the screen.

Retry, as the title says, not "resume"

You don't have to quit and restart docker - You can simply click on the image again to create it.


Alignment Problems

Our lab is very excited about the prospects of much faster atlas registration. However, I've tried on the client-side and using the web platform to auto-align images but unfortunately the model performed quite poorly on my DAPI images. Even when providing section number information I get alignment like this (see images ) for all my images. Not one image aligned well. I am hoping there is a fix for this and that I am just doing something wrong. Please advise.
In addition, the QuickNII software may be buggy as well. The same image pops up or does not change when you change images, e.g. DeepSlice Alignment2.jpg and 3 should be two different images but the DAPI image remains the same when selecting another image from the series or just never shows up at all (DeepSlice Alignment4.jpg) despite restarting the application many times.
DeepSlice Alignment1

DeepSlice Alignment2

DeepSlice Alignment3

DeepSlice Alignment4

interesting, I should write a trouble shooting guide which goes through common problems people face. Here are the likeliest problems.

Try turning off use section numbers to see if one section is throwing out the series.
DeepSlice requires 8-bit images, check the bit-depth and convert them in image-J if they're anything else.
Try turning off the slower more accurate option, this usually improves things but once in a blue moon the two models conflict though I've only seen this once

As for QuickNII it can be slower with non 8-bit images or high-resolutions. Due to your problems with DeepSlice and QuickNII I'd guess you have non 8-bit images.
Let me know if anything suggested here helps!

You suggestion helped considerably with alignment and I discovered a discrepancy between the online and client-side versions production of image file paths.
Alignment improvement
Converting to 8-bit tiffs worked to resolve a sizable portion of the alignment issue as did converting to JPG downsampled by 50%:
Image1:

Image2

Image3

This already saves a considerable chunk of time for me in my current workflow during the step where I manually find the AP coordinates for use with WholeBrain which is awesome! However, as you can see in the images, the alignment of smaller structures is problematic (e.g. anterior commissure, lateral ventricles).
Aside from adjusting each one manually, what more can be done to ensure edge and internal structure alignment?
File path discrepancy causing issues with QuickNII
As I was testing different things, I noticed that the client-side-generated .xml files were the ones that did not show the images in QuickNII. If you look at the file path in the top of the window of image 4 below and compare it to the same in image 1 you will see it too.
Image4

The "ch1_DAPI" folder is listed twice in the path for the one generated on the client side. Consequently, the images dont get loaded into QuickNII for comparison to the atlas. I originally saved the output of the model to the parent folder ("Images") and tried saving it to the child folder with the images to no avail. The image file paths remained containing the duplicate folder. I can open a separate bug report for this if you'd like.

Im glad it works well for you! For your smaller structures you should save a json in QuickNII and use Visualign https://www.nitrc.org/projects/visualign/ to warp the section. However I have just realised that there is a problem with the DeepSlice output and VisuAlign compatibility. I'm working on this now and will comment here when solved.
Please open a new issue for the filepath discrepancy problem :)

I've updated DeepSlice web so the output will now be compatible with VisuAlign!
I recommend you start with DeepSlice, make small adjustments with QuickNII change the size and position of the alignment as you see fit. Then use Visualign for all your smaller regions and warping of the section.

Thanks for using DeepSlice :)


Can TRIPLET be used with vcpkg.json

Please create a discussion in https://github.com/microsoft/vcpkg/discussions/new instead.
$.dependencies[0] (a dependency): must be lowercase alphanumeric+hyphens, split with periods, and not reserved
I can fin'd a way to set TRIPLET in vcpkg.json, and I need to depend a static link static runtime(/MT) library, I may need to use dynamic/static libraries for different libraries, so I cannot set the environment variables uniformly. Is there any way to solve this problem?

you don't set/use the triplet in vcpkg.json. If you need specific combinations of VCPKG_LIBRARY_LINKAGE you have to define a custom triplet for it.

you don't set/use the triplet in vcpkg.json. If you need specific combinations of VCPKG_LIBRARY_LINKAGE you have to define a custom triplet for it.

I can't find the option to set TRIPLET for each dependency in the documentation, I want to implement the following idea, how should I write?
{   "name": "LoganCore",   "version-string": "0.1.0",   "dependencies": [     "openssl:x86-windows-static",     "zlib:x86-windows"   ] }

https://github.com/microsoft/vcpkg/blob/master/docs/users/triplets.md#per-port-customization

We hope your question was answered to your satisfaction; if it wasn't, you can reopen with more info.

This should be a feature request.
I know technically every repository should use a fork / submodule of vcpkg where adding a custom triplet is not a problem,
but I think adding triplet support to vcpkg.json sounds very logical.

@0blu it sounds logical if you target only one platform, configuration and build tools version.

Hi I agree with 0blu. I'm having vcpkg issues because the triplet for one of my packages is only available as -static on ubuntu whereas on windows it can be dynamic (which is defaulted on windows).
This means my current CI/CD scripts are busted if I depend on vcpkg,json to do the installation for me. We should really have this feature.

vcpkg has some ports which must be built with either static or dynamic linkage regardless of triplet.
And you can add per-port customization to your triplet file for ports which support both types.
In any case, there is a single triplet which defines your target universe.

@TheMaverickProgrammer Probably it is best to ask for help with what you want to achieve in a new discussion.

One of the disadvantages of using per port customization, is when you change the triplet file to customize one port, all other ports will recompile, this is why I don't find this feature very practical, I think it would be better, if one can specify the triplet per dependency in the vcpkg.json instead.

There is a way to avoid it. Simply include a file with the specialization but be aware it has implications.

There is a way to avoid it. Simply include a file with the specialization but be aware it has implications.

Avoiding is not a solution. And you even imply it has undesirable outcomes. Not good.

I haven't paid attention to this discussion for a long time. My initial thought is very simple:
foobar.exe requires two libraries, foo.lib and bar.dll.
foo.lib is a x86-windows-static-md static library,
bar.dll is an x86-windows dynamic library,
Both libraries are dynamic runtime (/MD)
What is finally provided to the user is foobar.exe and bar.dll, which is very common in traditional engineering projects.
The issue is:
If I specify the same TRIPLET, two dynamic libraries need to be provided under x86-windows, or both libraries will be used as static library dependencies under x86-windows-static-md.
Am I missing something, or is there a way I can achieve what I'm thinking above?

The easiest thing is simply modifying the port/port***.cmake file for specific libaray and adjust VCPKG_LIBRARY_LINKAGE to dynamic temporaly, like I did here for luajit in linux-x64. Now linux-x64 build liblujit.so by default. No need to inflict custom dynamic triplet https://github.com/yhyu13/vcpkg/blob/84bc6197cf22f9cdc777090d6715988f6aea16ed/ports/luajit/portfile.cmake#L21

A Simply modifying the port/port***.cmake file for specific libaray

Don't do that. It is not a customization point.
The triplet controls the linkage. And it is a valid customization point in particular for non-standard linkage. Take one of the two triplets as a base, and use per-port customization.
https://learn.microsoft.com/en-us/vcpkg/users/triplets#per-port-customization
Instead of

foo.lib is a x86-windows-static-md static library,
bar.dll is an x86-windows dynamic library,

this would better be presented as:
foo.lib is as static lib (/MD) in x86-windows-custom
bar.dll is as DLL (/MD) in x86-windows-custom


Create Custom Events for Application Insights

Custom events in Azure Application Insights are used to track and visualize custom scenarios or occurrences in the application that aren't automatically captured by Application Insights. They can be used to track business events or user interactions that are specific to your application.
Adding custom events can provide valuable insights into how users are interacting with your application, which features are being used the most, and where potential issues or bottlenecks might be occurring. They can help you understand user behavior, measure the effectiveness of features, and identify areas for improvement.
Some of the proposed Custom Events that need to be triggered for events such as:

Error thrown
GraphQL Request Recieved
REST Request Recieved
Start/Stop/Reload for DAB engine

Consider:

Additional config property required? if so, what would that look like
Is there "framework" code that can be added first so that adding more events later is straightforward? To keep the scope of this issue reasonable, we shouldn't attempt to add every single event mentioned in the original description. pick one and use it to illustrate what code changes will be needed.


8.1 RC1: Future of Idiomatic Gradle: includeBuild v. kotlin-dsl v. configureondemand

Context
I have a traditional project setup:

gradle/plugins is hosting convention plugins with kotlin-dsl applied.
pluginManagement { includeBuild("gradle/plugins") } in root settings.gradle.
org.gradle.configureondemand=true in root gradle.properties.

I can't even use configureondemand with gradlew -Dorg.gradle.unsafe.isolated-projects=true, even though in that case it's not incubating.
Repro

Clone https://github.com/TWiStErRob/net.twisterrob.colorfilters
Check out a34cf1f
Upgrade Gradle to 8.1-rc-1 in gradle/wrapper/gradle-wrapper.properties
gradlew in root directory

Current Behavior

Using the configuration on demand feature with the Kotlin DSL. This behavior has been deprecated. This will fail with an error in Gradle 9.0. See https://docs.gradle.org/8.1-rc-1/userguide/kotlin_dsl.html#kotdsl:limitations for more details.

Expected Behavior
Project "just works".
Workaround
None known, tried adding org.gradle.configureondemand=false to gradle/plugins/gradle.properties, but since it's included in the root project the gradle.properties from the upper level is in play.

Hi Róbert,
IIUC with 8.1 you get that deprecation warning when configure-on-demand is enabled. This is expected.
You can't enable configure-on-demand for only one build in a composite build tree, this option applies to the whole build invocation.

Yes, but I want to enable Configuration on demand for everything, it just happens to have an included build which has kotlin-dsl applied. So do we have to choose between "configuration on demand and project isolation with Groovy DSL", or "Kotlin DSL with no speedup"? Or to put it in another way: it is not supported and will never be considered to use configuration on demand with convention plugins (because src/main/kotlin/foo/bar/baz.gradle.kts requires kotlin-dsl)? (I thought moving from allprojects to convention plugins is the first step towards being able to use project isolation.)


Error reading in an Ed25519KeyIdentity from pem file after bumping agentJS from 0.15.3 to 1.1.1

Describe the bug
Previously, in a NodeJS enviroment calling Ed25519KeyIdentity.fromSecretKey() with a key generated from dfx worked.
After bumping agentJS from ^0.15.3 to ^1.1.1, I now receive the following error.
<path_to_my_project>/node_modules/@noble/curves/src/abstract/utils.ts:134
    throw new Error(`${title} expected ${expectedLength} bytes, got ${len}`);
          ^
Error: private key expected 32 bytes, got 64
    at ensureBytes (<path_to_my_project>/node_modules/@noble/curves/src/abstract/utils.ts:134:11)
    at getExtendedPublicKey (<path_to_my_project>node_modules/@noble/curves/src/abstract/edwards.ts:421:22)
    at Object.getPublicKey (<path_to_my_project>/node_modules/@noble/curves/src/abstract/edwards.ts:435:12)
    at Function.fromSecretKey (<path_to_my_project>/node_modules/@dfinity/identity/src/identity/ed25519.ts:160:31)
    at identityFromPemFile (<path_to_my_project>/scripts/utils.ts:12:29)
    ...

Where the code for forming the identity from the pem file looks like this:
// utils.ts
import { Ed25519KeyIdentity } from "@dfinity/identity";
import { readFileSync } from "fs-extra";
const pemFile = require("pem-file");

export function identityFromPemFile(pemFilePath: string): Ed25519KeyIdentity {
  const rawKey = readFileSync(pemFilePath).toString();
  const buf = pemFile.decode(rawKey);
  if (buf.length !== 85) {
    throw new Error(`expecting byte length 85 but got ${buf.length}`);
  }
  const secretKey = Buffer.concat([buf.slice(16, 48), buf.slice(53, 85)]);
  return Ed25519KeyIdentity.fromSecretKey(secretKey);
}

// Example usage
const identity = identityFromPemFile(<path_to_your_key);

I see that in the 0.20.0 Release Notes you have

this change replaces the package tweetnacl with @noble/curves for Ed25519 curve signatures and validation.

To Reproduce
Steps to reproduce the behavior:

Generate an Ed25519KeyIdentity with dfx (old version of dfx, not exactly sure which one 🤷 )
Set up a TypeScript NodeJS Project with agent-js 0.15.3 installed and the script from utils.ts above, with your identity file path subbed in
Run the script with ts-node, it should succeed
Bump agent-js to ^1.1.1, and run the script again. You should see the error message described above.

Expected behavior
Ed25519KeyIdentity.fromSecretKey() should not behave differently between 0.15.3 and agent-js >= 0.20.0
Desktop (please complete the following information):

OS: OSX
Node v18.12.1

@krpeacock
For anyone else that runs into this issue, this solution fixed the error for me.
https://forum.dfinity.org/t/using-dfinity-agent-in-node-js/6169/69


CONNECT to https doesn't sniff Host in TLS/SSL negotiation

I see CONNECT ip:443 going through, and the name of the host the request is destined to in the next few bytes.. however, the current implementation signs the mitm cert with the IP in the CONNECT line, and doesn't allow us to direct the traffic to the right place, according to host-based rules.
Would it be possible to sniff the first packet after the connect, and use that info to determine the real host we're talking about.. and put back the bytes in a buffer so that further processing can be done by the right libs (like TLS taking the lead from before our read).
Not sure it's really clear.. but does no one find awkward we only get IPs to filter on HTTPS connect ?

I think I see.. I'm using Android's adb parameter --http-proxy, and it would seem that it is done at the emulator level, so it can't know the host the application asked.. only the IP that resulted. Since it's not an application running on Android, and asking for a domain, I only get an already resolved domain name.
Firefox on my desktop, issues a CONNECT with a domain name.. giving me the freedom to do the DNS resolution, and to discriminate requests based on the domain.
It would be realllly cool to sniff the SNI field in the incoming TLS negotiation, and provide that as a separate condition perhaps.. and loop it back through the OnRequest() handlers.

I wanted to do that, but I saw no way of getting SNI info from the standard
library.
If you have an elegant way, I'll be happy to hear about it.
On Thu, Jan 29, 2015, 6:44 AM Alexandre Bourget<EMAIL_ADDRESS>wrote:

I think I see.. I'm using Android's adb parameter --http-proxy, and it
would seem that it is done at the emulator level, so it can't know the host
the application asked.. only the IP that resulted. Since it's not an
application running on Android, and asking for a domain, I only get an
already resolved domain name.
Firefox on my desktop, issues a CONNECT with a domain name.. giving me the
freedom to do the DNS resolution, and to discriminate requests based on the
domain.
It would be realllly cool to sniff the SNI field in the incoming TLS
negotiation, and provide that as a separate condition perhaps.. and loop it
back through the OnRequest() handlers.
—
Reply to this email directly or view it on GitHub
https://github.com/elazarl/goproxy/issues/86#issuecomment-71968653.

I found an [excellent SNI sniffing library] (github.com/inconshreveable/go-vhost) that I've used in github.com/mzimmerman/whitelistproxy -- I'm not sure how well it would fit into a generic goproxy implementation.  I even hacked support for non-SNI enabled clients by guessing they were visiting the site of the most recent DNS lookup (this assumes the goproxy server is also the DNS server)

It's probably a good idea to use it, although I really liked the idea
goproxy have no external deps.
I'll try to look into it in a few weeks.
On Thu Jan 29 2015 at 2:15:13 PM Matthew Zimmerman<EMAIL_ADDRESS>wrote:

I found an excellent SNI sniffing library
http://github.com/inconshreveable/go-vhost that I've used in
github.com/mzimmerman/whitelistproxy
https://github.com/mzimmerman/whitelistproxy/blob/master/transparent.go#L441
-- I'm not sure how well it would fit into a generic goproxy
implementation. I even hacked support for non-SNI enabled clients by
guessing they were visiting the site of the most recent DNS lookup (this
assumes the goproxy server is also the DNS server)
—
Reply to this email directly or view it on GitHub
https://github.com/elazarl/goproxy/issues/86#issuecomment-72014789.

yeah that whitelistproxy is exactly what I had in mind.  Where would we put that ?  Would we make a ReqCond to enable SNI only on IP-based CONNECTs, and otherwise go straight through with the provided host.. if we get an IP on CONNECT, then go through the whitelistproxy example, and re-feed the socket back to our https handlers ?
Maybe we could add a flag to ProxyHttpServer to allow disabling/enabling of such a feature?
For dependencies.. I don,t see a huge problem, it's always hard to break the mold.. but I really feel goproxy could replace many uses of Charles Proxy, mitmproxy and Fiddler .. in a more coder-friendly and performant way.
What do you think ?

@elazarl why no external deps?  1) possibility of api changes or breakage or disappearing? or 2) you want all the code to be directly under the control of this repo?
To fix 1 you can either use gopkg.in or fork the dependency or both, or pull your dependencies into a local sub folder.
To fix 2 you'd just have to re-implement SNI in goproxy :) (or some variation on the solution to 1 might work too)

Having zero external dependencies makes development and usage easier. For
example if someone wants to embed goproxy in his code - he needs no other
distribution.
But I already agreed SNI is a good idea, and it doesn't look like the
standard library would support it any time soon. I'll indeed add support
for it when I'll have time. Hopefully sooner than later.
On Fri, Mar 13, 2015 at 6:17 PM, John Weldon<EMAIL_ADDRESS>wrote:

@elazarl https://github.com/elazarl why no external deps? 1)
possibility of api changes or breakage or disappearing? or 2) you want all
the code to be directly under the control of this repo?
To fix 1 you can either use gopkg.in or fork the dependency or both, or
pull your dependencies into a local sub folder.
To fix 2 you'd just have to re-implement SNI in goproxy :) (or some
variation on the solution to 1 might work too)
—
Reply to this email directly or view it on GitHub
https://github.com/elazarl/goproxy/issues/86#issuecomment-79091156.

Thanks @elazarl

@elazarl if you can think of a neat way to wire it in, I'm willing to do the work.. do you have anything in mind ?

https://github.com/elazarl/goproxy/pull/97


Restructure

Several changes:

Restructured paths, moving test material to a Tests folder, Invoke-Parallel.ps1 to it's own folder
Modified AppVeyor.yml to abstract out Pester invocation and test with both PowerShell 2 and the native version
Added verbose output to testing of branches not named master
Fixed PS2 test failure that cropped up.  WarningVariable was not writing to a variable.  Moved Timeout behavior from Warning to Error (seems appropriate?  Presumably a timeout is a failure and indicative of an error state?)

Moved to psm1 and back to ps1 due to scope issues discussed in issue #16
Open to flipping things back, let me know if you have any concerns!
Cheers!

Pester tests succeed but an error is thrown in the process, addressing...


Readme.md file Updation

Hi,
I’ve been exploring the project and appreciate the work you’ve done so far. I’d like to propose an update to the README.md file to provide a more comprehensive overview of the website. Here are a few ideas I have in mind:

A detailed description of the website's current features and functionalities.
A clear vision for the final project and any future enhancements.
Embedded links for additional reference.

I believe these updates could enhance user understanding and engagement with the project. If you're open to it, I’d love to contribute.
I’m committed to continually improving the quality of our documentation.
Thank you!

I want to work on it. Can you please assign it to me?
And please add gssoc-ext label


Create New starter guide page

[x] Create page
[ ] Cover how to set up accounts etc
[ ] Include instructions on what repos we use and how to clone GitHub pages
[x] Fred approved page
[ ] James approved page
[ ] Naushin approved page
[ ] Claudia approved page
[ ] Share page with Exeter and invite feedback

Definition of done

[ ] Page completed
[ ] Team reviewed and approved page?

LGTM - thanks Claudia!


TensorFlow Lite in Play Services issue

**System information**

Android Device information (use adb shell getprop ro.build.fingerprint
if possible):
TensorFlow Lite in Play Services SDK version (found in build.gradle):
Google Play Services version
(Settings > Apps > Google Play Services > App details):

Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to or attach code demonstrating
the problem.
Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem.
If including tracebacks, please include the full traceback. Large logs and files
should be attached.

@Allan1974 Could you please make sure that the TensorFlow Lite modules are installed at the same time your application is installed or updated from the Play Store?
In order to expedite the trouble-shooting process here,Could you please fill the issue template,
Thank you!


lsp.log: copilot triggers a registerCapability handler for workspace/didChangeWorkspaceFolders despite dynamicRegistration set to false

[WARN][2023-07-02 15:17:07] ...lsp/handlers.lua:134	"The language server copilot triggers a registerCapability handler for workspace/didChangeWorkspaceFolders despite dynamicRegistration set to false. Report upstream, this warning is harmless"

I keep getting this warning in lsp.log.

Please report this to:

https://github.com/github/copilot.vim
https://github.com/orgs/community/discussions/categories/copilot

This plugin uses the offical lsp server. We can't change its behavior.

Done. https://github.com/orgs/community/discussions/60285

Most likely it's the node version, update the node version to 18 or above.


Fix merged pull request to parallelize listeners

Signed-off-by: ruxandraRosu<EMAIL_ADDRESS>

@mandy-chessell Hi Mandy, is this fixing PR #1240? Would you please have a look?


Sharing Data From Alternative Cloud Platforms (Google Drive, One Drive, ...)

Hi, I am unable to access the data from the link shared (). Will it be possible to share the data from alternative cloud platforms (Google Drive, One Drive, ...).
Thanks in advance.

One Drive: https://1drv.ms/f/s!AntJTMkziB1Aa0c0xrrjMtuljA8?e=WsPKsL

Thanks for sharing the dataset.
The quality of the satellite images does not look great. It is blurry and the labels does not align with the image.
Is this the same data used in the challenge?

Thanks for sharing the dataset.
The quality of the satellite images does not look great. It is blurry. In the case of labels, there seems to be multiple fields in some of the polygons.
Is this the same data used in the challenge?

Yes


Fixed path for Office 15 (Office 2013) Home/Business.

The "auto installer" puts Office 2013 in this path. As I'm unsure of the origin of the current path, I kept it for you to decide if it stays or not, as the path might differ ..

Please delete the whitespace from Program Files - this is a magic identifier. Now it'll probably not spew out the correct paths, if anything useful at all.


Improve exception message when renew lock or session idle timeout are negative

Fixes #39824

API change check
API changes are not detected in this pull request.


May I ask if you can provide code for visualization similar to GradCAM?

I have tried using the vis_cam.py tool provided by mmpretrain, but it seems that it cannot run properly due to version issues.

Sorry for the late reply. I am not familiar with the GradCAM. Maybe the easiest way is to migrate the APViT model codes to the mmpretrain projects folder to use the 2.0 tools.


[server] swap map for list fields when examining idealstate for disk cleanup

[server] swap map for list fields when examining idealstate for disk cleanup
It seems map fields get cleared but list gets left alone
Resolves #XXX
How was this PR tested?

Does this PR introduce any user-facing changes?

[ ] No. You can skip the rest of this section.
[ ] Yes. Make sure to explain your proposed changes and call out the behavior change.

Can we flesh out the commit message a bit further? Is this some Helix API behavior we're relying on? Why does it matter concretely for Venice? (I think I can guess why today, but I'm pretty sure I'll have forgotten by the time I read this commit message 6 months from now)

Maybe this should be a comment in the code too, such as describing why we're using listFields instead of mapFields.


Api key users

Add role and reference options to apiKey creation resource.
Ensure that no core options are overridden with custom options.
Do not warn authentication disabled for an api resource when one authentication method is available.

Pull Request Test Coverage Report for Build 35

2 of 10 (20.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 43.474%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/Service.js
2
3
66.67%

lib/cli.js
0
2
0.0%

lib/bases/server/api/Security.js
0
5
0.0%

Totals

Change from base Build 32:
-0.1%

Covered Lines:
677

Relevant Lines:
1434

💛  - Coveralls


[ISSUE #6145] modify Collections.sort usage

Make sure set the target branch to develop
What is the purpose of the change
close #6145
Brief changelog
modify Collections.sort usage
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Please fix the CI first. Thx.

I reexecuted it.

Error: /home/runner/work/rocketmq/rocketmq/remoting/src/main/java/org/apache/rocketmq/remoting/protocol/statictopic/TopicQueueMappingUtils.java:25:8: Unused import - java.util.Comparator. [UnusedImports] Error: /home/runner/work/rocketmq/rocketmq/remoting/src/main/java/org/apache/rocketmq/remoting/rpc/ClientMetadata.java:20:8: Unused import - java.util.Collections. [UnusedImports] Error: /home/runner/work/rocketmq/rocketmq/remoting/src/main/java/org/apache/rocketmq/remoting/rpc/ClientMetadata.java:21:8: Unused import - java.util.Comparator. [UnusedImports] Audit done.

okay, I'll handle that.


Accessibility improvements

This is to make all of the improvements identified in the Accessibility Testing Report for Explorer (see: https://docs.google.com/document/d/1RxdxDNf0UMLP-AsxudWY7PzeHwZV7ktwj8fNKkh9rF8/edit). These are:

[ ] Fix alt text for logo (note what GDS and accessibility specialists, such as WebAIM do)
[x] Ensure all images are visible when CSS is not available (and update embedded Font Awesome licence information)
[x] Ensure all images are displayed at a reasonable size when CSS is not available (some of the SVGs are huge)
[ ] Update page titles to reflect editorial standards (to be discussed with Content Designers)
[ ] Add sr-only span with "Current page" to pagination so that the current page can be more easily determined when CSS is not available
[ ] Address "Graphic" issue affecting NVDA users when interacting with image cards
[x] Make time period date presentation to screenreaders meaningful (they're currently read out as "One Thousand Four Hundred And Eighty Five One Thousand Seven Hundred and Fourteen"
[x] Fix issue with aria-live not firing for the sorting selector in NVDA
[ ] Ensure image alt text is below 100 characters (and update Functional and Technical specification to reflect this)

Hi @AshTNA - I've been looking at the logo issue and I think the current alt text is OK. I'm basing this on the approach used by:

WCAG who have the W3C logo alt text as alt="W3C"
WebAIM who have the logo alt text as alt="WebAIM - Web Accessibility In Mind"
Paciello Group have the logo alt text as alt="TPGi"

I'm therefore going to remove the related task from this PR, if that's OK.

Thanks @gtvj - sounds good.

I've realised the issue with titles is due to a Wagtail setting on development machines. In order for the site name to be displayed in the title it needs to be set (which it will be in production). Otherwise it's just the page name which is displayed.
You can see this in templates/base.html.
I'm therefore going to remove that task too.

I've just checked the technical and functional specification document and all references to alt text specify a maximum of 100 characters.

Hi @AshTNA - I think the one remaining issue might have been addressed by the restructuring of the cards I've done. Could you just check that's the case and, if so, mark the issue as done?

Thanks @gtvj - it sounds good on NVDA now. It looks like the SVGs still may not have the correct licenses, so I can go in and fix those.


calling haplotypes problem

Hi,
I am currently running nanopolish for calling the variants after I indexed my files. I am running the following command:
nanopolish variants -v -p 1 --genotype genotype_31 --fix-homopolymers -r barcode31.fastq -b ../minimap2_output_ax_sr/aln_31.sorted.bam --genome ../gene_references/cpmp_pf3d7_0104100.fasta
and it gives me an empty file (with the headers and all). First I trimmed the adapters from my raw fastq files, then I removed the barcodes, then I filtered low quality reads, and after that I aligned those reads against a reference gene (~800 bp) using minimap2 -ax -sr. After that I sorted and indexed my bam file, which I used as input for the nanopolish variants command previously described. Am I doing something wrong? I am working with haploid malaria genes, and I am basically trying to get the number of haplotypes per sample (each sample is a pool of haplotypes).
Thanks a lot for all the help and contribution you've done so far!
Daniel

Hi,
Can you paste the output printed to stderr by nanopolish? I don't think you should use -x sr for nanopore data, even for short amplicons.

Sure, here it's the output:
##fileformat=VCFv4.2
##nanopolish_window=Plasmodium:0-2375
##INFO=<ID=TotalReads,Number=1,Type=Integer,Description="The number of event-space reads used to call the variant">
##INFO=<ID=SupportFraction,Number=1,Type=Float,Description="The fraction of event-space reads that support the variant">
##INFO=<ID=BaseCalledReadsWithVariant,Number=1,Type=Integer,Description="The number of base-space reads that support the variant">
##INFO=<ID=BaseCalledFraction,Number=1,Type=Float,Description="The fraction of base-space reads that support the variant">
##INFO=<ID=AlleleCount,Number=1,Type=Integer,Description="The inferred number of copies of the allele">
##FORMAT=<ID=GT,Number=1,Type=String,Description="Genotype">
#CHROM	POS	ID	REF	ALT	QUAL	FILTER	INFO	FORMAT	sample
[post-run summary] total reads: 109, unparseable: 0, qc fail: 0, could not calibrate: 1, no alignment: 19, bad fast5: 0

Yes, I noticed that is more for paired end reads, rather to what I have. I'll run minimap2 again without that and try to see if I get something different with nanopolish variants
Thanks

Sorry, I just realized I mapped and aligned using minimap2 -x map-ont <ref.fasta> <sample.fastq> > output.sam, I did not use the previous command I mentioned (minimap2 -ax -sr)

The --genotype genotype_31 option asks nanopolish to genotype variants that are present in the genotype_31 VCF file. Is this what you want, or do you want the output to go to genotype_31?

I was hoping to call genotypes in the VCF file that I was expecting to get after running the nanopolish variants command. Am I using it wrong?

Yeah the --genotypes option is to provide an existing list of sites to call genotypes at. If you remove that option it should work as expected.

It did! It worked! Thanks a lot! So if I want to obtain the number of genotypes across my sample, how would I use the --genotype command?

You'd have to decide on a list of sites that you want to genotype, produce a VCF file with those sites, then pass it in with --genotypes. In regular variant calling mode it will produce genotypes too (at all detected variable sites). You can probably ignore the --genotypes option.

No problem.


Error Handling on API

API should check all data coming in from the request - if it fails at any point, return an automatic message that says something went wrong on the results page with a suggestion on what to try next.

Some error handling has been added - will close


Move ECS Config from ENV to AWS AppConfig

Description
As part of enabling OIDC auth (https://github.com/arkime/aws-aio/issues/75), we want to enable changes to capture/viewer configuration without requiring a CloudFormation Stack Update.  To accomplish this, we will use AWS AppConfig to distribute the configuration rather than baking it into the containers via ENV variables.  AppConfig will live in a sidecar container and present the configuration over a curl-able localhost port.  We'll pull the config on Container startup similar to how we currently pull the config from ENV.  The configuration that AppConfig pulls needs to live somewhere so we'll store it in AWS Parameter Store (which it tightly integrated with AppConfig).  There's no L2 CDK constructs for this so we'll have to use the L1's.
See: https://docs.aws.amazon.com/appconfig/latest/userguide/appconfig-integration-containers-agent.html
See: https://github.com/aws/aws-cdk/tree/main/packages/aws-cdk-lib/aws-appconfig
Acceptance Criteria

Changes to Capture/Viewer node configuration not longer require a CloudFormation Stack Update

Looking for some examples online for how to wire up the CDK side of this, it seems there's a number of folks who had success with relatively small amounts of CPU/Memory for the AppConfig Sidecar:
// Add AWS AppConfig container
this.service.taskDefinition.addContainer('AppConfigV2', {
    image: ecs.ContainerImage.fromRegistry('public.ecr.aws/aws-appconfig/aws-appconfig-agent:2.x'),
    cpu: 32,
    memoryReservationMiB: 256,
    essential: true,
    portMappings: [
        {
            containerPort: 2772,
            protocol: ecs.Protocol.TCP
        }
    ],
})

AWS AppConfig's docs are very unhelpful [1].  I'm having a hard time understanding precisely how new changes are rolled out and how that will interact with the standard Docker configure-on-boot-and-bounce-to-reconfigure paradigm [2].  It's unclear whether AppConfig works via a push or a pull mechanism.  I'd assume it would be a pull mechanism, but there's also a DeploymentStrategy construct which indicates a managed roll-out across your fleet [3].  How do you ensure a rollout of 20% of the fleet every 10 minutes unless you're doing a push?  But you don't register the AppConfig sidecar container with AWS AppConfig during setup [4]...
[1] https://docs.aws.amazon.com/appconfig/latest/userguide/what-is-appconfig.html
[2] https://docs.aws.amazon.com/appconfig/latest/userguide/appconfig-deploying.html
[3] https://docs.aws.amazon.com/appconfig/latest/userguide/appconfig-creating-deployment-strategy.html
[4] https://docs.aws.amazon.com/appconfig/latest/userguide/appconfig-integration-containers-agent.html

After looking through several implementations in CDK, the docs, AWS Blog Posts, and stack overflow threads (including one answered by a member of the service team [1]), I still don't know how this service works.  Do I have to do a Deployment?  If so, when?  How does it work?  And so on.
Fortunately - I've come to the conclusion that we don't actually need AWS AppConfig if we're willing to bounce our containers.  With App Config, we'd store our configuration in Parameter Store, undefined magic would occur, we'd bounce our containers, and they'd pull the new configuration.  We can just cut the magic out and save ourselves the pain/confusion.
Will update the task title/description accordingly.
[1] https://stackoverflow.com/questions/73689103/aws-appconfig-onboarding-doubts

Work steps:

Create Python code library to generate Capture and Viewer config files and upload to Param Store
Move S3_STORAGE_CLASS from Capture ENV variables to config file
Move VIEWER_PASS_ARN, VIEWER_PORT, VIEWER_USER from Viewer ENV variables to config file
Update Capture and Viewer startup scripts to pull files from Param Store and writes them to disk

Actually, VIEWER_PASS_ARN, VIEWER_PORT, VIEWER_USER aren't in the viewer config file, so I'll tackle those during the OIDC task (https://github.com/arkime/aws-aio/issues/77)

PR approved and merged; AC met.  Resolving.


Promote AWS Secrets Manager secret store component to Beta

Describe the feature

The AWS Secrets Manager secret store component requires certification tests to be moved from Alpha to Beta.
This will accelerate Secret Store building block adoption for AWS Dapr users.
Release Note

RELEASE NOTE:

/keepalive

We need these requirements to be met

Successful run: https://github.com/dapr/components-contrib/actions/runs/11617637325/job/32353321405?pr=3588


Poor Results

I ran the evaluation script as the following but got very poor results. The avatar is just flying with meaningless motions. Is there any extra parameters setting or anything I have missed?
bash scripts/eval.sh 20220829_194320 "walk"
https://user-images.githubusercontent.com/45808830/217264546-52f390ce-f5fb-4316-b63d-eb5cd25612ba.mp4

The result seems abnormal. How about sampling more results? Do all results have such behavior?

Here is one of my results generated with this scene.

Thanks a lot. I found that this was because I set the wrong Action-Specific Model path. When I fixed this error, the avatar's actions became normal.
By the way, when I test the 'sit' model, I generate 10 samples, but none of them sit in the right position. Is this normal?
https://user-images.githubusercontent.com/45808830/217422264-f5cc3619-74fb-401f-a930-e5dd7688f9bf.mp4

I think it is normal, it is very hard to generate physically plausible results. First, accurately grounding the target object in a 3D scene is really challenging. Second, fine-grained 3D geometry awareness has not been well studied. Both two challenges make it hard to align the motion with the target interacting object. Let alone we solving this problem with a cVAE-based generative model in an end-to-end manner. We hope that the community can pay more attention to this field and push it forward.

Thanks for your reply. When will the Action-Agnostic Model be released?
Is the Action-Specific Model just overfit on one specific action and ignores the input text? Because whatever the text is, the model will generate the same action.

We will release that soon.

I have released the code for action-agnostic model just now. I will close this issue. If you have any other questions, just open a new issue.


Implemented query filter

Implemented query filter

Hi @valdisiljuconoks, Could you check the PR?

Moved default values form library to "client app" -> so that users of the library will be able to control whether feature is enabled or not and set the page size.

@tibormohr got some compilation errors, fixed those.

Could you just drop LocalizationResourcesController.cs file (maybe something more you have pending check-in) - so I can complete the feature and release it.
Thx! 👍

Hi,
Sorry, it was my mistake it was not correctly attached the submodule.
I just created a PR for aspnet repo.
Thanks ahead
/TM


Unable to resolve suitable regular or attached property Mode on type Avalonia.Themes.Fluent.

Describe the bug
It does not build. I installed nuget "Avalonia.Themes.Fluent"
<FluentTheme Mode="Light"/>
Expected behavior
Very simple app, should be running. If I remove the xml line from App.axaml, the app will run having no background window or anything.
Desktop (please complete the following information):

OS: Windows 11

https://github.com/AvaloniaUI/Avalonia/wiki/Breaking-Changes#avaloniathemesfluent-and-simple

In 11.0 preview5 please remove Mode from FluentTheme.
 still works.
If you want to switch Light or Dark theme, use App.RequestedThemeMode instead.

Removing it doesn't draw anything.

FluentTheme shouldn't be removed.

FluentTheme shouldn't be removed. Only a Mode property.

Correct. The XML tag is the only thing I removed. Not the FluentTheme package.

You should still have <FluentTheme /> in your App.xaml, i.e. only remove Mode="..." part.

You should still have <FluentTheme /> in your App.xaml, i.e. only remove Mode="..." part.

Thank you @jp2masa ! That works. :D

Update docs
https://docs.avaloniaui.net/docs/next/tutorials/music-store-app/creating-a-modern-looking-window
Cause in docs it doesn't work

@kazeens thx for pointing that out. A hotfix PR is out. However, if you see such things in the docs (in the future), a PR to fix them is very welcome 😊.

@timunie I can't seem to see a PR anywhere fixing that issue (and the document still currently uses Mode="Dark" here).

@kazeens okay, the reason is it was changed on another page but not on the tutorial. I wasn't aware of this. Thx for pointing this out.


Doesn’t work with ARSCNView

The code works fine with SceneKit but it doesnt generate the glow in ARKit.
With my limited understanding of Metal I tried debugging. The mask pass works as it should but the blur passes doesn’t generate anything.

Hmm, we're using it with ARSCNView. Would you mind sharing your code?
Are you testing on device or simulator?

Adding the SCNTechnique
if let path = Bundle.main.path(forResource: "NodeTechnique", ofType: "plist") {         if let dict = NSDictionary(contentsOfFile: path) as? [String : AnyObject] {           let technique = SCNTechnique(dictionary:dict)           sceneView.technique = technique         } else {           print("cast error")         }       } else {         print("plist error")       }
Activating bitMask
objectNode.categoryBitMask = 2 objectNode.childNodes.forEach { $0.categoryBitMask = 2}

Found the culprit, but still trying to figure out the underlying reason. Removing the following line fixed the issue:
     sceneView.antialiasingMode = .multisampling4X
But this is not a viable solution for me. Do you have any idea about why antialiasing causes outline to fail?

That is odd, I'm seeing the same thing. I probably won't look into this but let us know if you figure anything out. Can you tell if the SCNTechnique is being used at all or just disabled with antialiasing on?

If I debug the GPU frame I see that passes are added and mask pass works. Blur passes don't receive the texture from mask pass.

I just tested this in iOS 11.4 and it does generate the glow in a ARSCNView


Added fuzz testing target: FIRFieldPath

Added a new fuzzing target to fuzz test creating FIRFieldPath objects.
Added a corpus and a dictionary for the new target.

What's the status of this PR? Please set assignee to indicate whose turn it is to respond next.

@wilhuff Sorry about that. Would you like to take a look at this PR, or are you okay with merging it as is?


 See https://github.com/mapbox/carmen/pull/795
Current status; mostly functional. Outstanding tasks;

[x] Could use a preliminary review
[x] Depends on rockdb update https://github.com/mapbox/carmen-cache/pull/136
[x] As currently written this would be a breaking API change. May be worth making it backwards compatible. Input is welcome here...
[x] Need to at slightly stricter validation of prefix match setup (must be 0,1,2)
[ ] Add CHANGELOG entry... oh gawd, there is no change log...
[ ] Regenerate Docs

Oh but also, looks like this branched from carmen-cache before #132 landed? So... might be a little messy getting all that resolved

@apendleton thanks for the feedback. My take aways:

[ ] Add some constants to the JS side to make the integer api business less funny. Use them in tests.
[ ] Validate that input is actually 0,1,2
[ ] Add a commend about prefix cache skipping
[ ] Remove the "Unsure comment"
[ ] Do the v. fun rebase.

Did the rebase, was kinda ugly. You can see the updated diff at https://github.com/mapbox/carmen-cache/compare/rock-on-n-on...word-boundary
As this depends on the rocksdb update I'll open a new PR from the rebased branch (and close this one) once that lands.

Prefering new PR https://github.com/mapbox/carmen-cache/pull/138


Team 2 projectiles

Description
Projectiles will no-longer intercept with one another, and dispose one another. This also includes code in projectile factory to spawn a shotgun projectile. Shooting four projectiles with spread. This version also changed projectiles to be spawned via game area service in the projectile factory instead of in the weapon component.
Fixes / Closes # (issue)
#249 - closes projectile layer interactions.
#118 - contributes to weapon shotgun effect.

[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ x] This change requires a documentation update

How Has This Been Tested?
ProjectileAttackComponentTest has two new unit tests which verify expected projectile disposal and verifies this disposal
is not present on projectile collisions.
Checklist:

[ x] My code follows the style guidelines of this project
[x ] I have performed a self-review of my code
[ x] I have commented my code, particularly in hard-to-understand areas
[x ] My changes generate no new warnings
[x ] I have added tests that prove my fix is effective or that my feature works
[x ] New and existing unit tests pass locally with my changes
[ x] Any dependent changes have been merged and published in downstream modules

Please resolve the merge conflict


Possible to add button push function/script while the pi is on?

At the moment if the button is held for 1second the pi shuts down, which is great. Love that, exactly what I need. I'd really like to add something that issues a PiWakeup/CEC wakeup command over HDMI if the button is pushed but not held while the pi is already on.
At the moment the Pi just goes to sleep and I'd like to wake it back up, rather than restarting it using the button. I could probably do this with a second button easily enough but would like to keep the hardware minimal and try to use the same button as on the On/Off Shim....

Is there a command-line command you can use for wakeup?
Right now the existing shutdown script doesn't have any good way to detect a momentary button press- it relies upon the button being held down for its very lazy polling to detect it at all.
It would be pretty easy to rewrite this in Python and support what you want, though.

@Gadgetoid,
The command line echo 'on 0' | cec-client -s would wake it up over HDMI CEC using the cec-utils
Maybe a 0.5-second press could wake up and a ~3-second press could shut down? Or something like that?
New to this but happy to explore Python! Where would I 'add' it to the existing code?

@Gadgetoid  hey - sorry for the confusion using two accounts, one is work one is home. forgot which I was logged into. so the pi isn't going to sleep it's a function of MagicMirror, my bad. I've found some modules for the mirror which will allow me to cleanshut down using a button, so I guess new question - is it possible to disable the shutdown part of the ON/OFF shim code and leave the startup part running?
I can shutdown and sleep using a magicmirror module, but not startutp.

You would need the poweroff part of this script- I believe- to switch the latch in ON/OFF shim - https://github.com/pimoroni/clean-shutdown/blob/master/daemon/lib/systemd/system-shutdown/gpio-poweroff
Without this your system will shut down, but power will never be cut so the switch to restore power does nothing.
Just a case of copying that file into the right directory on your Pi:
sudo cp ./daemon/lib/systemd/system-shutdown/gpio-poweroff /lib/systemd/system-shutdown/gpio-poweroff


[IO] Introduce String to Channel Conversion

Description:
We need a function that does the following,
//Usage 1
String content = "Ballerina";
IOUtils.getChannel(String content,String encoding) returns (io:CharacterChannel);
Once that channel is obtained a json channel could be created in the following manner,
//Usage 2
io:CharacterChannel channel;
io:JsonChannel jsonChannel = channel.createJsonChannel(channel);
json jsonContent = jsonChannel.readJson();

When can this be expected? We need string to json conversion only in
WebSockets even if it does not involve any channels :)

Resolved in the current master


Meet error with build:aot:prod when update typescript from 2.0.10 to 2.1.4

Note: for support questions, please use one of these channels: Chat: AngularClass.slack or Twitter: @AngularClass

I'm submitting a ...
[ ] bug report
[x] feature request
[ ] question about the decisions made in the repository

Do you want to request a feature or report a bug?

Feature

What is the current behavior?

When I update typescript from 2.0.10 to 2.1.4, and run "npm run build:aot:prod", I met the error, see the error log as below:

.tsModuleNotFoundError: Module not found: Error: Can't resolve '../compiled/src/
app/app.module.ngfactory' in 'E:\jsLib\angular2-webpack-starter-master\src'
at factoryCallback (E:\jsLib\angular2-webpack-starter-master\node_modules\we
bpack\lib\Compilation.js:234:38)
at E:\jsLib\angular2-webpack-starter-master\node_modules\webpack\lib\NormalM
oduleFactory.js:235:19
at onDoneResolving (E:\jsLib\angular2-webpack-starter-master\node_modules\we
bpack\lib\NormalModuleFactory.js:60:20)
at E:\jsLib\angular2-webpack-starter-master\node_modules\webpack\lib\NormalM
oduleFactory.js:127:20
at E:\jsLib\angular2-webpack-starter-master\node_modules\webpack\node_module
s\async\dist\async.js:3694:9
at E:\jsLib\angular2-webpack-starter-master\node_modules\webpack\node_module
s\async\dist\async.js:356:16
at iteratorCallback (E:\jsLib\angular2-webpack-starter-master\node_modules\w
ebpack\node_modules\async\dist\async.js:934:13)
at E:\jsLib\angular2-webpack-starter-master\node_modules\webpack\node_module
s\async\dist\async.js:840:16
at E:\jsLib\angular2-webpack-starter-master\node_modules\webpack\node_module
s\async\dist\async.js:3691:13
at apply (E:\jsLib\angular2-webpack-starter-master\node_modules\webpack\node
_modules\async\dist\async.js:21:25)
at E:\jsLib\angular2-webpack-starter-master\node_modules\webpack\node_module
s\async\dist\async.js:56:12
at E:\jsLib\angular2-webpack-starter-master\node_modules\webpack\lib\NormalM
oduleFactory.js:122:22
at onResolved (E:\jsLib\angular2-webpack-starter-master\node_modules\webpack
\node_modules\enhanced-resolve\lib\Resolver.js:70:11)
at loggingCallbackWrapper (E:\jsLib\angular2-webpack-starter-master\node_mod
ules\webpack\node_modules\enhanced-resolve\lib\createInnerCallback.js:31:19)
at afterInnerCallback (E:\jsLib\angular2-webpack-starter-master\node_modules
\webpack\node_modules\enhanced-resolve\lib\Resolver.js:138:10)
at loggingCallbackWrapper (E:\jsLib\angular2-webpack-starter-master\node_mod
ules\webpack\node_modules\enhanced-resolve\lib\createInnerCallback.js:31:19)
at Resolver.applyPluginsAsyncSeriesBailResult1 (E:\jsLib\angular2-webpack-st
arter-master\node_modules\tapable\lib\Tapable.js:145:46)
at innerCallback (E:\jsLib\angular2-webpack-starter-master\node_modules\webp
ack\node_modules\enhanced-resolve\lib\Resolver.js:125:19)
at loggingCallbackWrapper (E:\jsLib\angular2-webpack-starter-master\node_mod
ules\webpack\node_modules\enhanced-resolve\lib\createInnerCallback.js:31:19)
at E:\jsLib\angular2-webpack-starter-master\node_modules\tapable\lib\Tapable
.js:247:15
at E:\jsLib\angular2-webpack-starter-master\node_modules\webpack\node_module
s\enhanced-resolve\lib\UnsafeCachePlugin.js:39:4
at loggingCallbackWrapper (E:\jsLib\angular2-webpack-starter-master\node_mod
ules\webpack\node_modules\enhanced-resolve\lib\createInnerCallback.js:31:19)
at afterInnerCallback (E:\jsLib\angular2-webpack-starter-master\node_modules
\webpack\node_modules\enhanced-resolve\lib\Resolver.js:138:10)
at loggingCallbackWrapper (E:\jsLib\angular2-webpack-starter-master\node_mod
ules\webpack\node_modules\enhanced-resolve\lib\createInnerCallback.js:31:19)
at Resolver.applyPluginsAsyncSeriesBailResult1 (E:\jsLib\angular2-webpack-st
arter-master\node_modules\tapable\lib\Tapable.js:145:46)
at innerCallback (E:\jsLib\angular2-webpack-starter-master\node_modules\webp
ack\node_modules\enhanced-resolve\lib\Resolver.js:125:19)
at loggingCallbackWrapper (E:\jsLib\angular2-webpack-starter-master\node_mod
ules\webpack\node_modules\enhanced-resolve\lib\createInnerCallback.js:31:19)
at E:\jsLib\angular2-webpack-starter-master\node_modules\tapable\lib\Tapable
.js:247:15
at innerCallback (E:\jsLib\angular2-webpack-starter-master\node_modules\webp
ack\node_modules\enhanced-resolve\lib\Resolver.js:123:11)
at loggingCallbackWrapper (E:\jsLib\angular2-webpack-starter-master\node_mod
ules\webpack\node_modules\enhanced-resolve\lib\createInnerCallback.js:31:19)
resolve '../compiled/src/app/app.module.ngfactory' in 'E:\jsLib\angular2-webpack
-starter-master\src'
using description file: E:\jsLib\angular2-webpack-starter-master\package.json
(relative path: ./src)
Field 'browser' doesn't contain a valid alias configuration
after using description file: E:\jsLib\angular2-webpack-starter-master\package
.json (relative path: ./src)
using description file: E:\jsLib\angular2-webpack-starter-master\package.jso
n (relative path: ./compiled/src/app/app.module.ngfactory)
as directory
E:\jsLib\angular2-webpack-starter-master\compiled\src\app\app.module.ngf
actory doesn't exist
no extension
Field 'browser' doesn't contain a valid alias configuration
E:\jsLib\angular2-webpack-starter-master\compiled\src\app\app.module.ngf
actory doesn't exist
.ts
Field 'browser' doesn't contain a valid alias configuration
E:\jsLib\angular2-webpack-starter-master\compiled\src\app\app.module.ngf
actory.ts doesn't exist
.js
Field 'browser' doesn't contain a valid alias configuration
E:\jsLib\angular2-webpack-starter-master\compiled\src\app\app.module.ngf
actory.js doesn't exist
.json
Field 'browser' doesn't contain a valid alias configuration
E:\jsLib\angular2-webpack-starter-master\compiled\src\app\app.module.ngf
actory.json doesn't exist

It seems app.module.ngfactory.ts didn't been generated.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via
https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).

1st step: update typescript from 2.0.10 to 2.1.4;
2nd step: npm run build:aot:prod

What is the expected behavior?

The aot build success.

What is the motivation / use case for changing the behavior?

I want to use async/await, which is supported with typescript 2.1.4 when set the tsconfig's target to es5.
Although I can use babel + typescript to supported it, I still don't want to import other packages.

Please tell us about your environment:

Angular version: 2.0.0-beta.X
Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)

Angular doesn't support TypeScript 2.1.4 and won't until Angular 4.x


Update azure-csi-disk-storage-provision.md

Fixed the azure-pvc-disk.yaml file Format, as it was not working once you copy and paste it.

Fixed the azure-pvc-disk.yaml file Format, as it was not working once you copy and paste it.

#sign-off


Enable hipRTC as default

Issue with SRIOV should have been resolved and root cause has identifies to be not MIOpen.
We should re-enable hipRTC as default

@atamazov add as a reviewer if you have time. Any suggestions/recommendations are highly appreciated.

I think it is better to add link to the reverted PR (https://github.com/ROCmSoftwarePlatform/MIOpen/pull/1470) to the description for clarity.


Preload All Scripts

Should resolve #7.

thanks, but consider the createHtml is a help function, please add the preload scripts in project.ts
to keep code style, please use vscode default formater: always use ' for plain string and no ;  as line end

in fact all the preload-able scripts will pre-import in main.js(please check it in chrome) and main.js is preloaded, i am wonder maybe no preload scripts needed (should test it)

and preload script should be <link rel="modulepreload" src="..." /> since it's an esm script

in fact all the preload-able scripts will pre-import in main.js(please check it in chrome) and main.js is preloaded, i am wonder maybe no preload scripts needed (should test it)

@ije I think you are still going to need to preload those others scripts. Check this snip from the Google Lighthouse:

i see, thanks, do you have a spare time to check the project.ts(it's a bit large)? the preload scripts shoud be added in here not html.ts, or i will finish it later.

add preload scripts with createHtml function:
createHtml({
            ...
            scripts: [
                {src: '...', type: 'module', preload: true},
                ...
            ],
            ...
        })

I will take a look at it.

cool!

@ije I moved the changes to project.ts.

@shadowtime2000 i would create a function like:
function getPreloadScripts(baseUrl: string) {
    const scripts = [
        `-/deno.land/x/aleph/aleph.js`,
        `-/deno.land/x/aleph/context.js`,
        `-/deno.land/x/aleph/error.js`,
        `-/deno.land/x/aleph/events.js`,
        `-/deno.land/x/aleph/routing.js,`,
        `-/deno.land/x/aleph/util.js`
    ]
    return scripts.map(src => ({ src: `${baseUrl}${src}`, type: 'module', preload: true }))
}

then inject it to all the createHtml calls:
createHtml({
    ...
    scripts: [
        ...
        ...getPreloadScripts(baseUrl),
        ...
    ],
    ...
})

then i will marge this request, thanks

@ije Done.

LGTM; thanks


Admin Servlet - 3 Functions - User, Msg, and Conversations Counts

Major change:

AdminServlet provides the gathering of 6 data.
Admin.jsp mapping taken care of; should display properly.
AdminServletTest added.

Oh, the differences indeed vanish, awesome! I am losing tracks of my branches, I need to name them more creatively.

Hey @dhgarrette, I had a review regarding the order of the methods in AdminServlet - "init, set * store, doGet, doPost"; I changed the order of the methods but the review didn't go away. I tried to hide and delete the comment and it didn't seem to work either. Do you have any insights to what should I do to complete that review? Thank you so much!

Unit Test updated!

Also, I added some new classes for create fake data in an easy and readable way (and set you as the reviewer on the PR).  Feel free to use them if you'd like, but you're certainly not required to rewrite your tests if you want to submit this sooner :-).

Thank you so much Dan! I would like to rewrite some of the tests to make it better and keep it consistent with the other tests. I will make a separate PR for that.