SegFault on Windows + Libcurl when application finishes and there are available handles in the connection pool

For the next simple program:
int main(int argc, char** argv)
{
  curl_global_init(CURL_GLOBAL_ALL);

  // Code that uses Azure SDK

  curl_global_cleanup();
  return 0;
}

The Azure SDK will create libcurl connections and after using them, the connections are moved to the connection pool.
Those connections will be cleaned/destroyed by the Connection Manager if they are not used in some time.
However, if the application finishes and reach to a point where curl_global_cleanup() is called, all the libcurl resources are clean.
Then, when the connections from the pool are destroyed, they will try to clean/destroy the handler again producing a segmentation fault.

@RickWinter @JeffreyRichter @ahsonkhan
I am planning to fix this issue by using a try/catch for when the Connection Manager clean up the connections from the pool.  That way, if the   curl_global_cleanup() was called before, we might catch the exception and ignore.
Let me know what you think

@RickWinter @JeffreyRichter @ahsonkhan
I am planning to fix this issue by using a try/catch for when the Connection Manager clean up the connections from the pool.  That way, if the   curl_global_cleanup() was called before, we might catch the exception and ignore.
Let me know what you think

Catching a segfault exception isn't the right pattern.  I would expect when we release the libcurl connection it would notify libcurl that its been free'd.  How are we releasing the libcurl handle is a way that results in it being released twice?

Catching a segfault exception isn't the right pattern.  I would expect when we release the libcurl connection it would notify libcurl that its been free'd.  How are we releasing the libcurl handle is a way that results in it being released twice?

I agree with Rick here. We need a better lifetime mechanism to clean up the connections (maybe even something that is resilient to whenever curl_global_cleanup() is called).
I am curious, do we have to periodically cleanup the connection pool at all?

I agree with Rick here. We need a better lifetime mechanism to clean up the connections (maybe even something that is resilient to whenever curl_global_cleanup() is called).
I am curious, do we have to periodically cleanup the connection pool at all?

We could add a method to the TransportAdapter to cleanup and then customer code can call this method before calling curl_global_cleanup(). This enables this to work for ALL Transport Adapters for any HTTP stack. The customer can also call our function that returns the default Transport Adapter can call this method.

We could add a method to the TransportAdapter to cleanup and then customer code can call this method before calling curl_global_cleanup(). This enables this to work for ALL Transport Adapters for any HTTP stack. The customer can also call our function that returns the default Transport Adapter can call this method.

I would expect when we release the libcurl connection it would notify libcurl that its been free'd

I would expect the same :) .
The problem is that I create a libcurl handle,
then open a connection and start an http transfer.
Now, before closing that connection and/or cleaning its resources, the end-user might call global_cleanup which will close my connection and clean all related to libcurl. However, I still have my handle which is basically a ptr to an address.  There's no way for me to know that the global_cleanup was called and the address is no longer valid.
Another approach is to wrap the global_cleanup with some azure_global_cleanup() , but this is not a general solution because end-user can still call global-cleanup.

I am curious, do we have to periodically cleanup the connection pool at all?
Yes, it starts as soon as a connection is created and it ends if all connection from pool are removed

I would expect when we release the libcurl connection it would notify libcurl that its been free'd

I would expect the same :) .
The problem is that I create a libcurl handle,
then open a connection and start an http transfer.
Now, before closing that connection and/or cleaning its resources, the end-user might call global_cleanup which will close my connection and clean all related to libcurl. However, I still have my handle which is basically a ptr to an address.  There's no way for me to know that the global_cleanup was called and the address is no longer valid.
Another approach is to wrap the global_cleanup with some azure_global_cleanup() , but this is not a general solution because end-user can still call global-cleanup.

I am curious, do we have to periodically cleanup the connection pool at all?
Yes, it starts as soon as a connection is created and it ends if all connection from pool are removed

We could add a method to the TransportAdapter to cleanup....

This is basically a AzureSdkCleanUp() right?  We would say that if you don't call it, you might get errors?

We could add a method to the TransportAdapter to cleanup....

This is basically a AzureSdkCleanUp() right?  We would say that if you don't call it, you might get errors?

No, not really because an AzureSdk clean up is 1 per process and what I'm proposing is 1 per transport adapter which we may not know about
Jeffrey Richter (watch Architecting Distributed Cloud Apps)

From: Victor Vazquez<EMAIL_ADDRESS>Sent: Wednesday, January 27, 2021 3:48:34 PM
To: Azure/azure-sdk-for-cpp<EMAIL_ADDRESS>Cc: Jeffrey Richter<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Azure/azure-sdk-for-cpp] SegFault on Windows + Libcurl when application finishes and there are available handles in the connection pool (#1499)
We could add a method to the TransportAdapter to cleanup....
This is basically a AzureSdkCleanUp() right? We would say that if you don't call it, you might get errors?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-sdk-for-cpp%2Fissues%2F1499%23issuecomment-768654115&data=04|01||5cbc6572955a43ec76f108d8c31e0f7e|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637473881154419812|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=7CHEF6VJU%2B%2F2vayA4JOd6ARyTPLxvzpaZq8uOimpO8M%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAARLJP2RIJESAUPKKPMTMTLS4CQ5FANCNFSM4WWCY4PQ&data=04|01||5cbc6572955a43ec76f108d8c31e0f7e|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637473881154419812|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=QE%2FZctVYA6%2BqIBlCMNtmluIkD4RuAUmo7f1JM2ZSOno%3D&reserved=0.

No, not really because an AzureSdk clean up is 1 per process and what I'm proposing is 1 per transport adapter which we may not know about
Jeffrey Richter (watch Architecting Distributed Cloud Apps)

From: Victor Vazquez<EMAIL_ADDRESS>Sent: Wednesday, January 27, 2021 3:48:34 PM
To: Azure/azure-sdk-for-cpp<EMAIL_ADDRESS>Cc: Jeffrey Richter<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Azure/azure-sdk-for-cpp] SegFault on Windows + Libcurl when application finishes and there are available handles in the connection pool (#1499)
We could add a method to the TransportAdapter to cleanup....
This is basically a AzureSdkCleanUp() right? We would say that if you don't call it, you might get errors?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-sdk-for-cpp%2Fissues%2F1499%23issuecomment-768654115&data=04|01||5cbc6572955a43ec76f108d8c31e0f7e|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637473881154419812|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=7CHEF6VJU%2B%2F2vayA4JOd6ARyTPLxvzpaZq8uOimpO8M%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAARLJP2RIJESAUPKKPMTMTLS4CQ5FANCNFSM4WWCY4PQ&data=04|01||5cbc6572955a43ec76f108d8c31e0f7e|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637473881154419812|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=QE%2FZctVYA6%2BqIBlCMNtmluIkD4RuAUmo7f1JM2ZSOno%3D&reserved=0.

Talked to @JeffreyRichter  and agreed to create and expose a static function from the CurlTransport as Azure::Core::Http::CurlTransport::CleanUp() which would take care of manually cleaning the pool.
End user is expected to call this function before the global clean up.
Adding documentation about it in the PR

Talked to @JeffreyRichter  and agreed to create and expose a static function from the CurlTransport as Azure::Core::Http::CurlTransport::CleanUp() which would take care of manually cleaning the pool.
End user is expected to call this function before the global clean up.
Adding documentation about it in the PR

@JeffreyRichter @vhvb1989 If we are going to force folks to call "Shutdown" then lets make it a generic Azure::Shutdown() method.  We will need that method if we decide to support memory allocation hooks.

@JeffreyRichter @vhvb1989 If we are going to force folks to call "Shutdown" then lets make it a generic Azure::Shutdown() method.  We will need that method if we decide to support memory allocation hooks.

@JeffreyRichter @vhvb1989 If we are going to force folks to call "Shutdown" then lets make it a generic Azure::Shutdown() method. We will need that method if we decide to support memory allocation hooks.

Azure::Shutdown()  wouldn't have any sense when not using libcurl.  It might be just a placeholder of nothing until we add the memory allocation, and if that never happen, once that we add the method, we can't remove it. Hence, I am happier with having the Clean function as part of the CurlTransportAdapter only

@JeffreyRichter @vhvb1989 If we are going to force folks to call "Shutdown" then lets make it a generic Azure::Shutdown() method. We will need that method if we decide to support memory allocation hooks.

Azure::Shutdown()  wouldn't have any sense when not using libcurl.  It might be just a placeholder of nothing until we add the memory allocation, and if that never happen, once that we add the method, we can't remove it. Hence, I am happier with having the Clean function as part of the CurlTransportAdapter only


predict() with add_intercept=True fails when features are multi-column expression

Thanks for creating this awesome library! I found it very handy not having to go back and forth between numpy and polars world for fitting a simple model!
When I run something like the following, I get an error because the add_intercept=True creates multiple constant columns instead of a single constant column internally and therefore it fails.
import polars as pl
import polars.selectors as cs

df = pl.DataFrame({"y": [1, 2, 3, 4], "x1": [3, 4, 5, 6], "x2": [4, 5, 6, 7], "x3": [5, 6, 7, 8]})
df = df.with_columns(
    pl.col("y").least_squares.ols(
        cs.starts_with("x"),
        add_intercept=True,
        mode="coefficients",
    )
)
# This throws an error!
df = df.with_columns(
    pl.col("coefficients").least_squares.predict(
        cs.starts_with("x"),
        add_intercept=True,
    ).alias("y_pred")
)

panicked at src/expressions.rs:649:5:
assertion `left == right` failed: number of coefficients must match number of features!
  left: 4
 right: 6
---------------------------------------------------------------------------
ComputeError                              Traceback (most recent call last)
Cell In[55], line 12
      4 df = pl.DataFrame({"y": [1, 2, 3, 4], "x1": [3, 4, 5, 6], "x2": [4, 5, 6, 7], "x3": [5, 6, 7, 8]})
      5 df = df.with_columns(
      6     pl.col("y").least_squares.ols(
      7         cs.starts_with("x"),
   (...)
     10     )
     11 )
---> 12 df = df.with_columns(
     13     pl.col("coefficients").least_squares.predict(
     14         cs.starts_with("x"),
     15         add_intercept=True,
     16     ).alias("y_pred")
     17 )

File ~/Library/Caches/pypoetry/virtualenvs/kingston-gaisan-dhDkHfdI-py3.12/lib/python3.12/site-packages/polars/dataframe/frame.py:8791, in DataFrame.with_columns(self, *exprs, **named_exprs)
   8645 def with_columns(
   8646     self,
   8647     *exprs: IntoExpr | Iterable[IntoExpr],
   8648     **named_exprs: IntoExpr,
   8649 ) -> DataFrame:
   8650     """
   8651     Add columns to this DataFrame.
   8652
   (...)
   8789     └─────┴──────┴─────────────┘
   8790     """
-> 8791     return self.lazy().with_columns(*exprs, **named_exprs).collect(_eager=True)

File ~/Library/Caches/pypoetry/virtualenvs/kingston-gaisan-dhDkHfdI-py3.12/lib/python3.12/site-packages/polars/lazyframe/frame.py:1942, in LazyFrame.collect(self, type_coercion, predicate_pushdown, projection_pushdown, simplify_expression, slice_pushdown, comm_subplan_elim, comm_subexpr_elim, cluster_with_columns, no_optimization, streaming, background, _eager, **_kwargs)
   1939 # Only for testing purposes atm.
   1940 callback = _kwargs.get("post_opt_callback")
-> 1942 return wrap_df(ldf.collect(callback))

ComputeError: the plugin panicked

This is happens at the following line at https://github.com/azmyrajab/polars_ols/blob/a5e13a07545a41d2326e0957d2717e44f3343c38/polars_ols/least_squares.py#L482C1-L483C1
            features += (features[-1].fill_null(0.0).mul(0.0).add(1.0).alias("const"),)

I think the simplest fix would be to replace it with
            features += (pl.lit(1.0).alias("const"),)

but I am not sure if that's the right thing so I created this PR.

Thank you for documenting this and glad you are enjoying the library !
this sounds easy enough to fix in python (check if const already exists and ensure it’s not duplicated) - will try to do that when I get a moment. FYI the weird looking features[-1].fill_null(… was needed vs just a literal due to some issues with size broadcasting in rust side last I worked on this

Thank you for the reply! I am looking forward to it (though I am in no rush)!!

This should now be resolved - thanks for raising this !
your proposed fix went through w/o issues: https://github.com/azmyrajab/polars_ols/blob/main/polars_ols/least_squares.py#L482C26-L482C32

Thanks a lot for the update!!!


def => explicit types, fixes #205

Figured out tricky explicit type for IncrementalTaskInputs
Explicit types for J2objcNativeCompilation
Explicit types for iterators

TESTED=yes
Verified:
a) grep -R "def " . => only shows Style Guidelines
b) Explicit types for all “->” statements
c) Explicit types for all implicit "it" iterators

@advayDev1, @confile - I think these are the last changes needed for adding explicit types. The one thing I haven't been able to track down are these iterators for the Native Build:

@advayDev1, @confile - this should be the final commit for making all types explicit.
I've also created a "0.3 Release" Milestone. Please add relevant items to that.

I cannot add anything I am not a contributor.
Michael

Am 25.06.2015 um 04:34 schrieb Bruno Bowden<EMAIL_ADDRESS>@advayDev1, @confile - this should be the final commit for making all types explicit.
I've also created a "0.3 Release" Milestone. Please add relevant items to that.
—
Reply to this email directly or view it on GitHub.

LGTM with above comments

The String[]'s are ok? I don't think that they're meant to be List's.
On Thu, Jun 25, 2015 at 11:51 AM Advay Mengle<EMAIL_ADDRESS>wrote:

LGTM with above comments
—
Reply to this email directly or view it on GitHub
https://github.com/j2objc-contrib/j2objc-gradle/pull/232#issuecomment-115360685
.

@brunobowden - yes, totally fine:
http://docs.groovy-lang.org/docs/latest/html/documentation/#_array_initializers

@brunobowden - sorry, i should have been clearer before.  it was LGTM with (my) above comments.  I was not saying you need to do @confile 's.

I understood it that way
On Thu, Jun 25, 2015 at 11:59 AM Advay Mengle<EMAIL_ADDRESS>wrote:

@brunobowden https://github.com/brunobowden - sorry, i should have been
clearer before. it was LGTM with (my) above comments. I was not saying you
need to do @confile https://github.com/confile 's.
—
Reply to this email directly or view it on GitHub
https://github.com/j2objc-contrib/j2objc-gradle/pull/232#issuecomment-115362410
.

LGTM


Add textSize & typeface

Fixed this issues:
https://github.com/mmoamenn/LuckyWheel_Android/issues/17
https://github.com/mmoamenn/LuckyWheel_Android/issues/26
https://github.com/mmoamenn/LuckyWheel_Android/issues/23

Please merge this PR, it solve some bugs

Please merge this PR, it solve some bugs

I hope the maintainer will find some time to merge this up.

Hello @alirezaafkar, thank you for your contribution and sorry for being so late I will review you PR today evening 😊

Please sir we need to change TextSize and also distance between text and center of wheel if possible

@mmoamenn Can you please add a Function to set the Text Size?


fix issue #567

Fixes #567

[ ] npm run test succeeds.
[ ] npm run lint succeeds.
[ ] Appropriate changes to README are included in PR.

This PR being limited to correcting a trivial typo, I did not attempt to run test/lint/etc.

Sorry. I pushed the package.json change (related to issue 571) before creating a new branch. My bad.

LGTM!


Allow passing cert store to client

What

Allows passing configured cert_store to the websocket client.
Ensure underlying socket is closed when the SSLSocket is closed.

@DerekStride Thank you for your pull request. And sorry. I am very busy right now and it will be a little while before I can do a review. 💦

@DerekStride Your changes released as v0.6.0. Thank you and sorry for late. 😄
https://rubygems.org/gems/websocket-client-simple/versions/0.6.0


docs: add withVariable example and fix jumbled map content kdocs

#137  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


[WIP] etai

This PR has not been active for more than over a month. Closing. You can send a new PR if you get time to take another stab at this.


Netplugin whether to support multi etcd?

contiv version: 1.2.0
etcd version: 3.2.9
on netplugin node:

I stop etcd at <IP_ADDRESS>, but etcd of <IP_ADDRESS> and <IP_ADDRESS> is working.
The log of netplguin is :

https://github.com/contiv/netplugin/pull/1147

I already read  #1147, but my problem still exist. I also comparison the code of "netplugin-release-1.2" and #1147 "Files changed".
In  "/usr/bin/netplugin --mode kubernetes --netmode vlan --vlan-uplinks eth1 --fwdmode bridge --etcd-endpoints http://<IP_ADDRESS>:2379,http://<IP_ADDRESS>:2379,http://<IP_ADDRESS>:2379" ,
"--etcd-endpoints http://<IP_ADDRESS>:2379,http://<IP_ADDRESS>:2379,http://<IP_ADDRESS>:2379"
Is it correct of the writing method ?
Or "--etcd-endpoints http://<IP_ADDRESS>:2379,--etcd-endpoints http://<IP_ADDRESS>:2379,--etcd-endpoints http://<IP_ADDRESS>:2379" , Which is right?

First #1147 is not merge.You should merge it by your self.
Second, the args should like this
--etcd-endpoints http://<IP_ADDRESS>:2379,http://<IP_ADDRESS>:2379,http://<IP_ADDRESS>:2379
Third, the etcd's ports 2379 maybe https? Unfortunly the contiv just support http.
So your etcd should use 2380 or other ports?See your etcd config.

Thanks.


September 2019 Update mod fixes

I have expanded further what has been started by @scrubdaddytm here https://github.com/Azurency/CQUI_Community-Edition/pull/405 . I hope @scrubdaddytm won't mind that I have basically copied his solution rather than extending from his repo. I have figured out that I prefer to have my own copy of @Azurency repo and also it was way simpler to do.
It looks like it makes the mod work for me on my computer. Anyone cares top verify on theirs?
Here are the steps to manually install my changes on Windows:

run Civ 6 and from main menu got to Additional Content > Mods
make sure all the previous versions of CQUI Mod are removed (if you have installed via Steam make sure you unsubscribe there as well)
exit Civ 6 and make sure it is not running
got to your Documents\My Games\Sid Meier's Civilization VI\Mods folder
download the changes https://github.com/carlos-witek/CQUI_Community-Edition/archive/expansion2-summer-update.zip to that folder and unzip it (right click and press Extract All... and confirm the pop up which should create new folder CQUI_Community-Edition-expansion2-summer-update in your Documents\My Games\Sid Meier's Civilization VI\Mods)
run Civ 6 and from main menu got to Additional Content > Mods to manually enable the mod

works for me, great work mate, thanks

Seems like everything that's there is working. But a couple of things are not enabled -- namely better report screens. Oh and when you get enough GPPs to get a great person, the recruit and pass buttons are blocking the description of what they specifically do. Not a huge issue, but an annoyance nonetheless.

I didn't even notice the GPP button issue or the reports issue, neither really hurt gameplay. What I did notice is that so far anyway the lenses are all working fine which did impact my gameplay.

Had some wired issues in the Trading Screen. AI had a few of my cities in the AI-list, and I had all AI cities in my list. Could be a conflict with some other mod (not running Better Trading Screen)? If no one has seen it with CQUI, then it is in my end. And I can confirm conflict with "Z Unit Marks", but the rest of the 63-mod'ed-game are running with only CTD when quieting or re-loading a game.
I approve this version and it works for me.

you're a hero <3

Something I noticed recently is the map tacks seem to have reverted somehow with this fix. The standard set are all there but I seem to recall there was some kind of upgrade to them with some nice ones the added to the game that I don't see anymore. My memory is lousy but I swear that one of them was a nice barbarian camp icon that was red and not the crappy one that is the same color as your civ.

If you piece-meal carlos-witek's version with a couple of other mods, you basically get the full CQUI with just a few oddities. I mentioned the reports screens not showing up, for example. However, if you use both CQUI and seperate Better Reports Screen mod, it works just fine.

Minimap is broken

The minimap cqui popup settings does not seem to work for any settings. Anyone know how i can otherwise turn off yields always showing? Civ 6 keybindings apparently overwritten by mod settings. Thanks for all the hard work.

The yield setting is backwards in CQUI. I want them always on so I set it to off in CQUI.

I have the same problem @Gyrofalcon mentioned. In deal screen cities are usually incorectly named. Adding them to the trade shows the real names but it's not always possible: sometimes clicking just does nothing, even if the city hiding under the button should be tradeable (e.g. not capital).
Here an example:

Cities are completly dis-named. Most of them named after my capital - Qusqu. As you can see, clicking one one of them puts in the central list the right city. and by 'the right' I mean the one that should alphabetically be in that position in the ledt list. But, for example, adding any of the following two Qusqu's to the trade is not possible.
Other symptoms:
-list does not depend on which leader I'm trying to deal with
-changing city name does not impact list (even next turn), only loosing/aquiring cities
By the way: issue is present with only CQUI enabled (version from first post but was also present before).

I have this CQUI, Better Report Screens, and a couple of UI unrelated mods enabled and mine works almost perfectly ... strange.

The only thing broken for me is the citizens tab in the city panel.

It's interesting that it seems people are getting different things that are not working as intended.
I'm loving that my issue is a minor one :)

I've also got an issue with wrong city names in the deal screen, and the issue with Great People buttons.
Generally stuff I can live with...

Is this an update only or will it work alone? I got issues with buying units with gold as well as the deal screen. I was hoping it works when I install the main branch then overwrite with this one.

Is this an update only or will it work alone? I got issues with buying units with gold as well as the deal screen. I was hoping it works when I install the main branch then overwrite with this one.

Delete everything you have of old copies of CQUI. Both in SteamWorkshop folder and in Mods-folder, not just un-sub the mod on Steam. Then copy this version, found in OP in this tread, to the Mods-folder.

Will this be updated? There are still issues with the city names in the deal screen and tile yield icons not turning on or off. Thanks.

I'm using the version from this thread for my current game. In the Diplomacy Ribbon, (top of main screen), I'm only getting the 3 stats that CQUI has always had, not the 6 that the base game now includes.
In the standard game Interface Options page, I have "Show Yields in HUD Ribbon" set to "Always Show"
In the CQUI options, if I leave the "Show the Diplomacy Ribbon" option off, I get no yields,
if I turn it on, I just get the 3.
How can I get the full ribbon that the base game has?

This isn't that big of a deal but the mini map has stop working again, no idea why as I don't have any other mods that conflict with it.

Works very well, except for City States:

I see only one city state int he panel
I can't send any envoy

Works very well, except for City States:

I see only one city state int he panel
I can't send any envoy

Those features are working fine for me.
You might double check that you cleaned out old versions when you installed this one.

Most of this fix works great for me. I do have a couple of minor annoyances:

Every GP icon shows as Great Admiral
Notify messages are shown old style: large and in the middle of the screen

hey guys, is anyone willing to drive this to completion? it pains me that every time there is an update to the base game this awesome mod gets broken for many months. the base game UI is too painful to use IMO (death by a thousand mouse clicks).

I have the same problem @Gyrofalcon mentioned. In deal screen cities are usually incorectly named. Adding them to the trade shows the real names but it's not always possible: sometimes clicking just does nothing, even if the city hiding under the button should be tradeable (e.g. not capital).
Here an example:

Cities are completly dis-named. Most of them named after my capital - Qusqu. As you can see, clicking one one of them puts in the central list the right city. and by 'the right' I mean the one that should alphabetically be in that position in the left list. But, for example, adding any of the following two Qusqu's to the trade is not possible.
Other symptoms:
-list does not depend on which leader I'm trying to deal with
-changing city name does not impact list (even next turn), only loosing/aquiring cities
By the way: issue is present with only CQUI enabled (version from first post but was also present before).

I have this issue
Has there been a solution for this?

Does not work. Envoy Problem.

Hey Guys.
First of all thank you all for your participation. I'm glad to hear that it helped some people to enjoy the mod again. Sorry to hear that this does not solve all the problems - especially the big one with Diplomacy screen.
Here is few things that you all should have in mind:
1)
Without approval of the owner of the repo @Azurency this cannot be merged and made properly available. At the same time I do not have permission from him to distribute the code. So we are stuck until owner makes his move.

Frankly I have not enough skill/knowledge to make the big fixes. I have tried but I must admit that I do not understand the structure of the mode nor how it works. What I have done so far was just copy the fixes done before. If there are any more experience moders around here I would appreciate help.
Sorry Everyone that I have no better news.

The code has MIT license... just sayin'

Hey everyone -
I started with the changes from @carlos-witek and made additional fixes, which I will post in a new PR and see what I can do about creating a new repo in order to try and revive this project.
Once I post the new PR I will come back here and edit this comment with a link.


upgrade gem dependencies

Coverage remained the same at 100.0% when pulling 5b0c13939eb1824432bf0b9d22eb197d0fe63905 on upgrade-gems into 6229fb0dcd52811e1bbe1af20b1122da6882f7f8 on master.


Some about material question

Hello,I'm sorry to disturb you again. I'm really interested in your ray tracing project. Here's my problem: when I change your roughness or metal in HDRI environment.html ,  It doesn't seem to work .
您好，很抱歉再次打扰到您，我对你的光线追踪项目实在是太感兴趣了。当发现你的HDRI_Environment.html中粗糙度、金属似乎不起作用.

https://neil3d.github.io/assets/pdf/s2013_pbs_epic_notes_v2.pdf

@q750831855
Hello, apologies for my late reply.  Yes that code that you are using is sort of 'dead code' that was just lying around in the HDRI_Environment.js file.  Although I do use it briefly when loading in the model data, it never actually gets sent to the GPU.  The real data that gets sent to the GPU is linked with the GUI, which is Material type (either a 2,3, or 4 corresponding to metal, glass, or clear-coat plastic) and Material Color (which is three rgb floats, 0.0-1.0 range for each color channel).
I hadn't really set up this demo to be used with the roughness parameter - sorry for not clarifying that in the code comments somewhere.
I will try and add a roughness slider to the GUI panel, and then I will add a real roughness uniform that gets sent to the GPU so you can change and view the roughness results in real time.
Hope I have clarified why you were having the issue.  I'll let you know when I have something working.
-Erich

@q750831855
Hello again, I am happy to report that I have successfully added support for a roughness parameter on the HDRI_Environment demo!  Check it out:
HDRI_Demo
Thank you for bringing this issue to my attention.  Not only did I simply add a roughness slider to the demo, I fundamentally changed how the three.js path tracer handles different roughness settings so as to minimize those pesky fireflies (random bright pixels of when the a ray accidentally hits the sun, on top of a darker color material - very distracting).
So because you have inspired me to work on this feature, everyone benefits because I ended up having to improve the light transport for rough materials!
You should be able to learn how I added the roughness support in the matching .js and .glsl files for this HDRI demo.  In your code editor, just search for the word 'rough' throughout my updated source code and it should show all the stuff I added to make this work.  If you have any further questions, feel free to ask here on this issue.
Thanks again and enjoy!
-Erich

Hello @erichlof! Is it possible to use the model with all the textures from the BVH_Animated_Model demo in the HDRI Environment demo?

It would also be nice to have a demo where you can dynamically change the textures on the models and change their intensity in a certain range.

Hello @vinkovsky !
Sorry for the late reply. Yes it is possible to have the Damaged Helmet glTF model (with all of its PBR textures) placed in a scene with an HDR as the background and lighting.
Pretty soon, I might make a demo where you can load a couple of different glTF models with the GUI menu picker. Also, I would like the backgrounds to be able to change with another menu item picker, for maybe 5 different HDR background choices.
About the dynamic textures for models, now that is a little more tricky. It's not impossible (many professional rendering packages can dynamically change textures when you click on a part of the model with your mouse). But it would require a lot of supporting JS code, just for that one extra feature. Some type of material picking at the triangle level would need to happen, as well as a system to load in different textures on the fly, and then map them correctly to the model's UV coordinates.
Handling material and texture loading for 3D models is one of my weak areas of programming. I have mainly been focusing on how to correctly display and path trace the model and its different types of materials in the path tracing shader code, - after it has been already loaded. I have a pretty good grasp of the path tracing side of things, but not so much on the CPU JS loading and picking/replacing side of things for models and  swappable materials. Sorry, hope this makes sense.
But thanks for the suggestions- I'll see about that HDR with the Animated BVH glTF model demo you requested. 🙂


SQLite Fail on threading when recursive use of cursors

following #140
when 0.3.0 updated, SQLite objects created in a thread can only be used in that same thread issue had been done.
But similar problem still alive. I changed the test_unifac_sql_connection_check_threading_false test method like this:
  def test_recursive_use_of_cursors():
    import threading
    from thermo import unifac
    unifac.init_ddbst_UNIFAC_db()
    assert unifac.UNIFAC_DDBST_ASSIGNMENT_CURSOR is not None

    def worker(raised_exception: threading.Event):
        try:
            unifac.UNIFAC_group_assignment_DDBST('50-14-6', 'UNIFAC')
            # one more query
            unifac.UNIFAC_group_assignment_DDBST('50-14-6', 'UNIFAC')
        except Exception as e:
            print(f'Thread {threading.current_thread().name}: Error: {e}')
            raised_exception.set()

    raised = threading.Event()

    threads = []
    for i in range(2):  # one more threading
        t = threading.Thread(target=worker, args=(raised,), name=f'Thread-{i+1}')
        threads.append(t)
        t.start()

    for t in threads:
        t.join()

    assert not raised.is_set()

then the Recursive use of cursors not allowed issue raises up, which is likely because thermo using a global UNIFAC_DDBST_ASSIGNMENT_CURSOR . Wondering if one could change it to local, may avoid this kind of SQLite issue ever ever.

Hi SomaLily,
I can reproduce the issue. I understand the original fix didn't resolve root cause, which I didn't look into enough to understand in the first place.
I agree a fix is necessary.

Hi SomaLily,
I've written a fix for this issue by ensuring each thread has their own connection to any sqlite database. The performance overhead is very minimal. Thank you for the test case, I have added it to the test suite. The correction will be in the next thermo release.
Sincerely,
Caleb

Hi CalebBell,
I'm glad to hear that! It would be helpful! I love thermo!
Best regards,
Soma

Hello,
This fix landed in thermo 0.4.0 released today.
Sincerely,
Caleb


[OSM] Review streets clipping

It seems like we are being too aggressive on streets clipping in OSM:

Maybe if a point lays out of the bounding box we should find the intersection with it and generate a new "fake" segment instead of discarding it?
                  Bounding box limit
                    |
o-------------------x----------------o
     ^              |
New, fake segment

Duplicate of #148. Closing.


Update fabric-allow-list-urls.md

Fix a typo: 'PORT' to 'TCP'
Add a few more missing 'TCP' to align with the above content.

Thank you for contributing to Microsoft Fabric documentation
Fill out these items before submitting your pull request:
If you are working internally at Microsoft:
Provide a link to an Azure DevOps Boards work item that tracks this feature/update.

Who is your primary Skilling team contact? @mention them individually tag them and let them review the PR before signing off.

For internal Microsoft contributors, check off these quality control items as you go

[ ] 1. Check the Acrolinx report: Make sure your Acrolinx Total score is above 80 minimum (higher is better) and with no spelling issues. Acrolinx ensures we are providing consistent terminology and using an appropriate voice and tone, and helps with localization.

[ ] 2. Successful build with no warnings or suggestions: Review the build status to make sure all files are green (Succeeded).

[ ] 3. Preview the pages:: Click each Preview URL link to view the rendered HTML pages on the review.learn.microsoft.com site to check the formatting and alignment of the page. Scan the page for overall formatting, and look at the parts you edited in detail.

[ ] 4. Check the Table of Contents: If you are adding a new markdown file, make sure it is linked from the table of contents.

[ ] 5. #sign-off to request PR review and merge: Once the pull request is finalized and ready to be merged, indicate so by typing #sign-off in a new comment in the Pull Request. If you need to cancel that sign-off, type #hold-off instead. Signing off means the document can be published at any time. Note, this is a formatting and standards review, not a technical review.

Merge and publish

After you #sign-off, there is a separate PR Review team that will review the PR and describe any necessary feedback before merging.
The review team will use the comments section in the PR to provide feedback if changes are needed. Address any blocking issues and sign off again to request another review.
Once all feedback is resolved, you can #sign-off again. The PR Review team reviews and merges the pull request into the specified branch (usually the main branch or a release- branch).
From the main branch, the change is merged into the live branch several times a day to publish it to the public learn.microsoft.com site.

Hi @Max-Meng, confirming with PM, then will approve. Thanks!

@paulinbar
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Use raw_input rather than input.

This tweak lets you enter your email address without having to do a quoted literal.

Email or Phone<EMAIL_ADDRESS>Password:

Loading..
Using input() means you're actually calling eval() on whatever raw_input() returns. Which will blow up on the @ sign in an email address. I'm also not sure why you'd want to eval() a phone number.
Prior to this you'd need to do

Email or Phone<EMAIL_ADDRESS>
FWIW you're also mixing tabs and spaces in your indentation levels. It makes the code janky to read.

I did not face any problems with using input() and I did not have to enter my email address between quotes. Also, raw_input() does not exist in python 3.x. This script is built for python 3.x. (Although I could make it work for python 2.x after a few tweaks).

I blindly fixed this in #2 without checking for other PRs, sorry about that. Mine fixes for Python2 without breaking Python3 :)

This compatibility issue will be discussed in #2. Closing it here.


[Address Book] Persist addresses using 3Box

@lukasschor, @mikheevm... I've been trying to use/install the 3box-js SDK, but I'm constantly running into the error: Module not found: Can't resolve 'multicodec/src/name-table' in '/[...]/safe-react/node_modules/ipfs-bitswap/src/types/message'
There's an open issue around this: https://github.com/3box/3box-js/issues/687
Funny thing is that I tried with the boilerplate app is referenced in this blog post: https://medium.com/3box/building-a-distributed-appstore-with-3box-ef7345aab34e
Steps:

clone
npm i
npm run start
result: worked fine

Did the same, with yarn:

clone
yarn
yarn start
result:

./node_modules/ipfs-bitswap/src/types/message/index.js
Module not found: Can't resolve 'multicodec/src/name-table' in '/[...]/metamask-3box-boilerplate/node_modules/ipfs-bitswap/src/types/message'

So I tried using npm to run the safe-react project but I'm still getting the same error and new ones.
Steps:

remove deps: rm -rf node_modules
npm i
npm run start
result:

Failed to compile.

./node_modules/ipfs-bitswap/src/types/message/index.js
Module not found: Can't resolve 'multicodec/src/name-table' in '/[...]/safe-react/node_modules/ipfs-bitswap/src/types/message'

./config/polyfills.js
Module not found: Can't resolve 'promise/lib/es6-extensions.js' in '/[...]/safe-react/config'

./config/polyfills.js
Module not found: Can't resolve 'promise/lib/rejection-tracking' in '/[...]/safe-react/config'

@fernandomg from the issue it looks like you can use the older version, or wait for the fix to be released

Let's consider this done (as a technical prototype). I will create a new ticket for the proper  implementation.


Push data stream to Firebase using ArduinoJSON Library Object

Hello,
I am storing nested JSON array on my SD card. I am using ArduinoJSON library to serialize and deserialize my data. I am using JSON streaming method to deserialize the data from SD card. I have verified that all the code related to ArduinoJSON library works. I am not sure how to transfer the ArduinoJSON Stream object to FirebaseJSON object. Could you show me a quick example to do it. I will write down my pseudo code which will help you understand what I am trying to do.
Pseudo Code
file = SD.open("/testfilename.json",FILE_READ);
ReadBufferingStream bufferedReadFile{file, 64};
DynamicJsonDocument doc(24576);
deserializeJson(doc, bufferedReadFile);

FirebaseJson json;
json.set(bufferedReadFile);
Serial.printf("Push file... %s\n",  Firebase.RTDB.pushJSON(&fbdo, "/test/array", &json); ? "ok" : fbdo.errorReason().c_str());

bufferedReadFile.flush();
file.close();

Questions:

Do I need to deserialize the SD card JSON file or can I simply Stream it to Firebase. Is there any faster way to do it. If I create another buffer then I am afraid there might be memory leak
I am reading lots of data collected over hours from SD card and hence I have to parse the data and upload it in chunks. Could you recommend me a a way to send the data in a loop continuously. I can read the data from SD card and print it in my serial terminal in chunks but I am not sure if I can do the same using Firebase library.
Can you show me example on how to stream data to my Firebase server. I currently get compile error where I am trying to push data to the server

Here is the environment that I'm using:
Microconroller: ESP32
Core/runtime: ESP32core for Arduino v2.0.1
IDE: Arduino IDE 1.8.13
ArduinoJSON library 6.18.4
FirebaseJSON: 2.6.1
Firebase ESP32 Client: 3.12.6

FirebaseJson accepted string for deseialize or parsing e.g. Flash string, Arduino String, std::string, char array and string literal, by using setJsonData method or pass to the constructor.
https://github.com/mobizt/FirebaseJson/blob/64f0b975f65215fd4b0280510ee57c3112e1fbc4/examples/BasicUsage/Create/Create.ino#L27-L34
It also supports data from client and  stream (File and Serial).
In File.ino example, it reads the stream a  single char, one by one to determine the end of valid JSON , then parse from internal buffered data.
Other objects or classes from other libraries are not supported due to unknown interfaces.

I commented my ArduinoJSON deserialization and deserialized it using Firebase. I can print the content of my file to serial terminal but I don't know how to push the data to the Firebase server.
FirebaseJson json;
json.readFrom(file);
json.toString(Serial,true); //this will print to serial terminal
Serial.println();
Serial.printf("Push file... %s\n",  Firebase.RTDB.pushString(&fbdo, "/test/array", &json ); ? "ok" : fbdo.errorReason().c_str());

json is object not a string.
https://github.com/mobizt/Firebase-ESP32/tree/master/src#append-new-child-node-key-and-value-using-firebasejson-object-to-the-defined-database-path


[FEAT]: WebAPI for processing

Description of the feature/enhancement
A WebAPI where you can upload your (project) files, which are then being processed, would be nice. So you're independent of any tool or environment.
Additional Information
A queueing approach would be needed, because analyzing files can take quite some time.  Queue-Item-IDs should have uuids, so that no-one can look at the items from another person.

This is majorly out of scope for now, so I'll close this


styles for hearo banner in message page

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fixes #
Test URLs:

Original: https://www.sunstar.com/

Before: https://main--sunstar--hlxsites.hlx.live/

After: https://$branch--sunstar--hlxsites.hlx.live/

[ ] New Blocks introduced in this PR
If yes, please provide details below

Block Name
Documentation

For e.g. cards
doc-link

[ ] New variations introduced in this PR

Variation Name
Documentation

For e.g. cards (grid)
doc-link

closing PR as the required changes were pushed part of another PR https://github.com/hlxsites/sunstar/pull/279


Http clickthrough prevents puz gereration

The http version of the crossword now serves up a popup with class="xwd__modal--body xwd__start-modal" and a button to proceed with class="pz-moment__button". I believe those have to be acted upon before being able to access the puzzle information.
At the current moment, it appears that .puz generation of NYT is broken.

@deliciouslysmug Which version of nytxw_puz are you using?

The latest version looks good to me, can you verify if there are still issues running 1.06 ?

Wah! Version 1.06 didn't work on today's (Sunday) puzzle. It worked on this Friday's and Saturday's, last week's Sunday and the Sunday before.
Agh, what, is the NYT planting bombs in it?
"I can't remember being a baby and I put that down to it being boring."
-Karl Pilkington
On Thursday, March 24, 2022, 10:23:16 PM EDT, Q726kbXuN<EMAIL_ADDRESS>wrote:

The latest version looks good to me, can you verify if there are still issues running 1.06 ?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

@buszidog just git-fetch. Last night's c40e88e commit (untagged) fixes the issues with today's NYT.

GitHub/code dummy here(geez, I'm gonna be 75, have mercy!), how do I include/amend/drop this into nyt_puz v. 1.06?Thank you, thank you!
Loraine
"People moan about drugs being tested on animals. I sort of think it depends innit. If the drug's aspirin and the monkey's got a headache, is it right?"
-Karl Pilkington
On Sunday, March 27, 2022, 05:58:26 PM EDT, Ed Santiago<EMAIL_ADDRESS>wrote:

@buszidog just git-fetch. Last night's c40e88e commit (untagged) fixes the issues with today's NYT.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

@edsantiago That's hilarious.  The fix you're referencing was meant for an unrelated upcoming feature.  For once I'm ahead of the game.
@buszidog Try downloading the pre-release of 1.07 from here.  Let us know how it goes.

It worked!  Thank you, thank you!


Added descedents count assertion

Makes it easier to assert that wrapper has a exact amount of a certain descendant.

I've opened a new PR for this issue https://github.com/producthunt/chai-enzyme/pull/20
I went with @andreasklinger 's suggestion of adding a exactly chain.
expect(wrapper).to.have.descendants('.foo').with.length(5)

You might as well just use the following assertion:
expect(wrapper.find(foo)).to.have.length(4)


[bug] vision 2102-5 door/window sensor showing alarm type and event but no values

Version
Build/Run method

[x] Docker
[ ] PKG
[ ] Manually built (git clone - npm install - npm run build )

zwavejs2mqtt version: 1.1.1
zwavejs version: 6.2.0
Describe the bug
A Vision 2102-5 (labeled as monoprice) door/window sensor has 4 items in the notification section. All are CC 113.
Alarm Type, Alarm Level,  Home Security (property), and Door State. The two alarm events never show values, the other two appear to work fine.  When looking through the zwavejs logs I did not see any alarm events discovered. I'm not sure where these are coming from and I am happy to test any device config changes if needed.
To Reproduce
Steps to reproduce the behavior:

include device
wake up device a couple of times so inclusion completes
observe the notification section

Expected behavior
Either the alarm type and level values should populate or maybe they should not appear if there is some version backwards compatibility capability with Alarm v1 and Notification v14 (since alarm was renamed to notification)  .  Looking at the device manual https://usermanual.wiki/Vision-Automobile-Electronics-Co/ZD2102US5/html there is both Alarm v1 and Notification v4 CC support.
Additional context
In addition to the door state/home security events, I also see basic class reports of 0 or 255, I think this is a default behavior of the basic class but I do not see basic documented in the manual,  the basic 0/255 does match the Alarm level though.  However there is an interesting comment in the device configuration  https://github.com/zwave-js/node-zwave-js/blob/910155c88ffb2f8ab6ddce6adc2c0dbb57a135f6/packages/config/config/devices/0x0109/zd2102-5.json#L51
The included logs show an exclusion of the device has node04, and including it as node5.
zwavejs_1-vision-2102-5-exc_inc.log
zwavejs2mqtt-vision-2102-5-exc_inc.log
node_5.json.log.txt
Lastly, I though  I see mqtt stuff in the logs but I have that turned off and am only using zwavejs2mqtt for zwave management (using ws for HA)
Thank you!

If you are using ws server integration you shgould open the bug on hass repo not here

I am using WS, but my observations are the zwavejs2mqtt ui and with the zwavejs discovery.

@AlCalzone

I'm not sure why the empty values are displayed in zjs2m. At least I see no message in the log where a V1 value is received. Might have to do with how zjs2m decides what to display. Since the device claims it supports V1 alarms, we cannot be sure that it does not use them in some situation.

Ok, thanks guys -
so,
14:29:59.398 CNTRLR   [Node 005] [+] [Notification] supportsV1Alarm: true    [Endpoint 0] [internal]
Tells us the device says it supports Alarm V1 and therefor the alarm level and alarm type. This results in type/level showing up, even if the device never sends anything to them.
What about the note in the device config:
		"commandClasses": {
			"add": {
				"0x20": {
					// This device should send Notification Reports, but they seem to get lost often
					// Basic Set comes through
					"isSupported": true

Shouldn't the device already support basic by default?

It does, but zwave-js hides the Basic CC by default if there's a more specific actuating CC supported. That compat option forces it not to be hidden.

Appears the Vision Security ZG8101 has the same issue. At least the symptoms are the same. Values are populate in the Node view (notifications), but the values aren't shown in HA. The initial entities are hidden in HA, when I exclude/include.
Happy to provide more detail if below is insufficient.
265-2562-8202 (Node23).txt
zwavejs.log

@macf0x zwave-js translates the Basic Set into a Binary Sensor Report, so there's no need to expose it:
15:59:29.680 CNTRLR [Node 023] treating BasicCC Set as a report
2021-02-24 15:59:29.681 INFO ZWAVE: Node 23: value updated: 48-0-Any false => true

@AlCalzone Thanks for the prompt response.
The ZG8101 has 3 inputs. The tilt sensor (shown in HA), a reed switch and tamper. It these latter two that aren't exposed into HA.
I apologies if this isn't related.
These are the specific values and clearly zwavejs2mqtt receives the updates via BasicCC, but HA never gets the value.
15:59:22.447 CNTRLR [Node 023] treating BasicCC Set as a report
2021-02-24 15:59:22.450 INFO ZWAVE: Node 23: value updated: 48-0-Any false => true
2021-02-24 15:59:22.508 INFO ZWAVE: Node 23: value updated: 113-0-Home Security-Sensor status 2 => 2
2021-02-24 15:59:23.046 INFO ZWAVE: Node 23: value updated: 113-0-Home Security-unknown 254 => 254
2021-02-24 15:59:26.805 INFO ZWAVE: Node 23: value updated: 113-0-Home Security-unknown 254 => 254
15:59:28.977 CNTRLR [Node 023] treating BasicCC Set as a report
2021-02-24 15:59:28.979 INFO ZWAVE: Node 23: value updated: 48-0-Any true => false
2021-02-24 15:59:29.082 INFO ZWAVE: Node 23: value updated: 113-0-Home Security-Sensor status 2 => 2
15:59:29.680 CNTRLR [Node 023] treating BasicCC Set as a report
2021-02-24 15:59:29.681 INFO ZWAVE: Node 23: value updated: 48-0-Any false => true
2021-02-24 15:59:29.699 INFO ZWAVE: Node 23: value updated: 113-0-Home Security-Sensor status 2 => 2
2021-02-24 15:59:34.302 INFO ZWAVE: Node 23: value updated: 113-0-Home Security-Cover status 0 => 3
2021-02-24 15:59:36.698 INFO ZWAVE: Node 23: value updated: 113-0-Home Security-Cover status 3 => 3
HA device.txt
FWIW these were exposed in OZW prior to cutting over. ZWJS is a massive improvement over the OZW. So much easier to work with Zwave devices. I really appreciate the teams efforts in Zwave. Couple of the device that were problematic are now working sweet. ;)

zwavejs2mqtt receives the updates via BasicCC

No, it receives them via the Notification CC (113)

113-0-Home Security-Sensor status 2 => 2

means "intrusion"

Cover status 3 => 3

means "Tampering, product cover removed"
So as far as I can see, they are received correctly, but aren't correctly discovered by HA. I suggest you open an issue in the HomeAssistant repo, so they can track it down.

Thanks AlCalzone.

Where can one find the info such as Cover status (3) = Tamper?

That should be included in the metadata for the value ID. HA has access to that. zwavejs2mqtt should already display it on the UI (maybe not in the logs).

zwavejs_357.log
zwavejs2mqtt (1).log
It appears these values are still not recognised in the latest release.

What do you mean by "recognized"? Can you share screenshots or something?

Values are reported as unknown.

I think we discussed this already somewhere. The notification the device sends is actually using 0xfe ("unknown notification") as the notification event.

If this is by design, which seems weird choice by the manufacture, Perhaps I'll need to look at tracking the notifications in HA, rather than expecting values/states.

which seems weird choice by the manufacture

True, but trust me, there are far weirder choices manufacturers have made.


feat(network-scene-manager, network-spawn-manager): persist dontdestroyonload network objects

feat(network-scene-manager, network-spawn-manager): persist dontdestroyonload network objects
Resolves #789

This will cause some problems with multi scene support and some changes we did in the develop branch (we now technically support multiple network managers so having these registered statically won't work).
We currently already have quite a bit of changes going in the area of scene management so I'd suggest that if you want to contribute to this you first discuss your ideas with us by opening a feature issue or on our Discord.
I will close this for now.


feat(cli): add --local-d1

Closes https://github.com/prisma/team-orm/issues/1063

Deprecated by: https://github.com/prisma/prisma/pull/23662.


configure podman with crun and cgroupfs

historically due to https://bugzilla.redhat.com/show_bug.cgi?id=1972211
for remote execution we install crun and configure podman to use crun  as OCI container runtime

@TheRealHaoLiu should this be closed because the AWX PR was merged, and presumably it's already been shipped any released tags, so I don't see what this could be waiting on.


The fixed menu button needs to be clicked twice

The fixed menu options in the revamped UI needs to be clicked twice (if clicked directly on the SVG).
bug _t
@AbhayVAshokan _a

Dependent on https://github.com/bigbinary/neeto-ui/issues/1481


Automatically search upon typing

The search bar should be automatically focused when typing so you don't have to manually click on it to filter out files.

Hi, thanks for the Issue!
The feature is already planned in the following issue: https://github.com/fluxxcode/egui-file-dialog/issues/70
@crumblingstatue has already written an experimental implementation for this:
https://github.com/crumblingstatue/egui-file-dialog/commit/5f148ae57371cc6bd16fac8c7266950cce5161d6
But I don't know what the current status is.
There are also a few points about when we want to avoid the behavior:

When the user presses Ctrl or Shift so that we can implement Key bindings in the future
When the user is already in any input field

But I don't know what the current status is.

It was rebased against the latest dev branch yesterday.

When the user presses Ctrl or Shift so that we can implement Key bindings in the future

When the user is already in any input field

I can try and make it fit these requirements and clean things up and open a pull request

This is working well so far. But I think we should allow to automatically enter search while Shift is pressed.
Otherwise it doesn't work if the first letter is to be capitalized 🤔

Oops, i didn't realise that, fixed in https://github.com/crumblingstatue/egui-file-dialog/pull/1/commits/dffed3f6dbed0fc9d5cac026da5585b63e4ddd57.

This works really great now! Will merge the changes once @crumblingstatue creates a PR :)


Update readme with dependency list

Acceptance Criteria

All the project dependencies (runtime, test) are listed in the readme

This could be good candidate for Kehrwoche.


BUG: datetime64 series reduces to nan when empty instead of nat

I ran into some strange behavior with a series of dtype datetime64[ns] where I called max and got back a nan. I think the correct behavior here is to return nat. I looked through test_nanops but I am not sure where the correct place to put the test for this is.
The new behavior is:
In [1]: pd.Series(dtype='datetime64[ns]').max()
Out[1]: NaT

where the old behavior was:
In [1]: pd.Series(dtype='datetime64[ns]').max()
Out[1]: nan

can I add a test in test_nanops and/or test_series

also want to test for timedelta64/datetime64[ns, tz] too

Sure, I will update this tonight when I get home

pls also add a note in the 0.17.1 whatsnew bug section

ping @jreback

question for you. otherwise lgtm, pls squash to a single commit (I know different from other projects, just convention here)

Also I removed the workaround branch so hopefully the tests pass, otherwise we can put that branch back.

ok looks good. I'll be merging things on friday after releasing 0.17.0

Thank you very much

@llllllllll no thank you!

@jreback just rebased against master, good to merge?

we have lots of prs that are worked on at the same time
so when someone adds a note in whatsnew if they are all at the end
merging one requires everyone to rebase
but if the notes are inserted in a big list they are resolved by git
so we can merge many things w/o a rebase

Ah, that's a cool trick

minor comment, ping when green

tests are passing

thank you sir!


whole-archive-unrecognized

I can work this issue.
Describe the bug
In START_WHOLE_ARCHIVE and STOP_WHOLE_ARCHIVE, it is missing "-Wl," when compiling for vxworks.
I am using a sparc compiler and I get the following error:
Linking C executable core-plss_cws
cd  ..........    -g    CMakeFiles/core-plss_cws.dir/src/target_config.c.obj  -o core-plss_cws  --whole-archive ../cfe_core_default_plss_cws/libcfe_core_default_plss_cws.a ../psp/ut700-vxworks6.9/libpsp-ut700-vxworks6.9.a ../osal/libosal.a --no-whole-archive
sparc-wrs-vxworks-gcc: error: unrecognized command line option '--whole-archive'
sparc-wrs-vxworks-gcc: error: unrecognized command line option '--no-whole-archive'
To fix the error see below in code snips:
To Reproduce
Steps to reproduce the behavior for XEMU PLSS project:

Go to plss_cws_mission
source setvars.sh
mcrv
See error

Expected behavior
No error.  A clean build.
Code snips
I updated cafe/cmake/target/CMakeLists.txt
if ("${CMAKE_C_COMPILER_ID}" STREQUAL "GNU")
# The option pair for GNU gcc/ld tools
if("${CPU}" STREQUAL "SPARC")
set(START_WHOLE_ARCHIVE "-Wl,--whole-archive")
set(STOP_WHOLE_ARCHIVE  "-Wl,--no-whole-archive")
else()
set(START_WHOLE_ARCHIVE "--whole-archive")
set(STOP_WHOLE_ARCHIVE  "--no-whole-archive")
endif()
:
# the linker option prefix may or may not be needed, see below
set(COMPILER_LINKER_OPTION_PREFIX "-Wl,")
else()
# Other toolchain options may be added here
endif()
System observed on:

Hardware
OS: Centos 7
Versions:cFE <IP_ADDRESS>, OSAL <IP_ADDRESS>, PSP <IP_ADDRESS>, chksm 9194
VxWorks6.9

Additional context
Add any other context about the problem here.
Reporter Info
Jose Tovias CACI/LZT Technology

This is likely because whatever system you are using does not define CMAKE_EXE_EXPORTS_C_FLAG
See psp/cmake/Modules/Platforms/RTEMS.cmake for how this was done on that platform.
This has come up periodically -- the current approach of trying to use "whole-archive" option is toolchain specific and it would be nice if we could come up with a more platform-independent way of doing this.

Marking as duplicate with recommendation to follow RTEMS model until we come up with a better solution.

I tested using CMAKE_EXE_EXPORTS_C_FLAG, my load compiled without errors. Thanks..


bump cordova-plugin-inappbrowser to 1.1.1

Fixes #9

Wait on merging this - I'm seeing an error in XDK.  I'm not sure if it is caused by my testing or is legitimate.  Will provide an update ASAP.


split out loggers

Signed-off-by: Alex Jones<EMAIL_ADDRESS>

Looks good to me, just wondering if any log.Fatal calls should be through the service specific loggers? Although I assume they have been left out for a reason

Looks good to me, just wondering if any log.Fatal calls should be through the service specific loggers? Although I assume they have been left out for a reason If not it may be worth removing the logger from the HTTPService as it seems to be unused

I have intentionally avoided using fatals to call sys.exits in the program just yet, this was more a like-for-like drop in replacement.
We can now go back and refine behaviours.


Documentation is grossly misleading

The documentation of this plugin states that it's

useful to be able to control the _id messages are indexed into Elasticsearch with, so that you can insert duplicate messages (i.e. the same message multiple times without creating duplicates)

which is completely false. UUIDs are unique every time they're generated; that's their raison d'être. The UUID generation does not in any way take the event contents into account.

Fixed in #7


[Ready] Updated raise calls to UI.user_error! or UI.crash!

Oh yeah :rocket:
All fastlane exceptions (except for spaceship ones) are now triggered using UI.user_error! or UI.crash!
Old:

New:

Code I used
task :converter do
  path = "./**/*.rb"
  Dir[path].each do |current|
    next if current.include?("spaceship/")
    content = File.read(current)
    ["'", '"'].each do |esc|
      other = (esc == "'" ? '"' : "'")
      content.gsub!(/raise #{esc}([\w\^\(\)\#\.\[\]\,\-\{\}\|\:\>\<\=\/\:\`\?\.\s#{other}]*)#{esc}(\.red){0,1}/) do |line|
        error_message = Regexp.last_match[1]
        puts "error:"
        puts error_message
        puts "line:"
        puts line
        "UI.user_error!(\"#{error_message}\")"
      end

      # end.to raise_error "Error message here".red
      content.gsub!(/end.to raise_error(.*)\.red/) do |line|
        error_message = Regexp.last_match[1]
        line.gsub(".red", "")
      end
    end
    File.write(current, content)
    puts content
  end
end

This looks awesome. Left a few comments about places that might be better as .crash mostly because the error message didn't contain a enough information that a user could figure out what to change easily or how that code was getting called.

Thanks @asfalcone, I updated the PR :+1:

:+1: :rocket: :roller_coaster: !

Oh yeah!!! :rocket:


Fix indeces in coverage measurements in multiplication

Indeces now overlap between functions which causes issues when trying to measure coverage

Fixed in pull request #83


Adding version for .NET nanoFramework

Hey!
I'm with the Core Team of .NET nanoFramework.
.NET nanoFramework allows writing C# for resource constrained micro controllers.
We've recently had a request to add support for Sparkplug .
There is already a library for MQTT and we've recently added one for protobuf.
I was wondering if you would consider having a version compatible with .NET nanoFramework, or if we should follow our own path with our own Sparkplug library.
Happy to discuss details! 😃

Hi, I'm honestly not sure what needs to be done to support .Net nano framework but I would be willing to help (If you can guide me or give me hints). The library is not yet working completely as you can see in the issues, however and I wasn't able to do much here in the last months...

Hi @SeppPenner thanks for getting back on this!
Being .NET it means that most (if not all) code can (will?) be used. Apart from generics, which we don't have support for (yet).
The usual approach on similar situations is a mix of using shared projects, linked files and sprinkling compiler defs.
As we can't reference the full .NET nugets we have our own versions and a slightly different project system, so this requires specific projects to be added to an existing SLN file or, in case it's more convenient, a specific solution for the nanoFramework version.
(reading the above may sound a bit more complicated than what actually is 😉)
You can take a look at a similar use case: the AMQP.Net Lite library which is available for various .NET flavors, including nanoFramework.
Of course, I am more than willing to provide all the help you need and split work with you.


upgrade to crossbeam 0.2

Crossbeam 0.1.6 doesn't compile on recent nightly anymore, so it's more relevant than ever

In the case of mandel-rust it seems to work as a drop-in replacement (via .cargo/config)

Is this crate still active?

I'd like to see crossbeam updated too to get the crate building :)

I'm available to help out, @huonw


App appears to be broken on Resin OS 2.0.0+rev3 (prod)

I'm playing with this sample app on a Raspberry Pi 3 Model B, but it seems to be broken on Resin OS 2.0.0+rev3 (prod).
Here's my log output:
23.04.17 20:52:08 (+0100) Detected virtualization 'other'.
23.04.17 20:52:08 (+0100) Detected architecture 'arm'.
23.04.17 20:52:08 (+0100) Set hostname to <3c7a719>.
23.04.17 20:52:12 (+0100) Testing bluetooth on RPI3. Make sure you have a bluetooth device enabled and visible.
23.04.17 20:52:12 (+0100) Attaching hci0...
23.04.17 20:52:12 (+0100) bcm43xx_init
23.04.17 20:52:12 (+0100) Failed to read local name, command failure
23.04.17 20:52:12 (+0100) Can't initialize device: Success
23.04.17 20:52:12 (+0100) First try failed. Let's try another time.
23.04.17 20:52:12 (+0100) bcm43xx_init
23.04.17 20:52:42 (+0100) Initialization timed out.
23.04.17 20:52:42 (+0100) Bring hci0 up...
23.04.17 20:52:42 (+0100) Can't get device info: No such device
23.04.17 20:52:42 (+0100) Scan for devices...
23.04.17 20:52:42 (+0100) Device is not available: No such device
23.04.17 20:52:42 (+0100) Test finished. App configured to not exit. Restart the app if you want to retest.
23.04.17 20:52:42 (+0100) TEST FAILED

After a number of app restarts (and system restarts), I was able to get this:
23.04.17 21:24:23 (+0100) Detected virtualization 'other'.
23.04.17 21:24:23 (+0100) Detected architecture 'arm'.
23.04.17 21:24:23 (+0100) Set hostname to <3c7a719>.
23.04.17 21:24:27 (+0100) Testing bluetooth on RPI3. Make sure you have a bluetooth device enabled and visible.
23.04.17 21:24:27 (+0100) Attaching hci0...
23.04.17 21:24:27 (+0100) bcm43xx_init
23.04.17 21:24:57 (+0100) Initialization timed out.
23.04.17 21:24:57 (+0100) First try failed. Let's try another time.
23.04.17 21:24:57 (+0100) bcm43xx_init
23.04.17 21:24:57 (+0100) Flash firmware /lib/firmware/brcm/BCM43430A1.hcd
23.04.17 21:25:02 (+0100) Set Controller UART speed to 921600 bit/s
23.04.17 21:25:02 (+0100) Device setup complete
23.04.17 21:25:02 (+0100) Bring hci0 up...
23.04.17 21:25:02 (+0100) Scan for devices...
23.04.17 21:25:12 (+0100) Test finished. App configured to not exit. Restart the app if you want to retest.
23.04.17 21:25:12 (+0100) TEST FAILED

Hi @vpetersson ,
Are you testing with this exact, unchanged app? Do you have a decent power supply?
I have just pushed the app 5 times in a row and it worked first time, every time, for me.

Are you testing with this exact, unchanged app?

I tried a few times and I eventually got it to working. It just seems sporadic. I guess we can close it out if you cannot reproduce it.
I don't use the repo per se, but same Dockerfile.tmpl as well as the bash script.

Do you have a decent power supply?

Yup. Powerful Ankar PSU that drives a few RasPis in my lab setup.


Chang font-family style in pdf.js

Attach (recommended) or Link to PDF file here:
Configuration:

Web browser and its version:
Operating system and its version:
PDF.js version:
Is a browser extension:

Steps to reproduce the problem:
here's what i get inside span tag:
Thirty (30) calendar days after written notice of termination to ORGANIZATION
i want to remove  font-family: serif; from style
how can i be able to remove iy from pdf.js or from any other place!?
Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):

here's what i get inside span tag:
Thirty (30) calendar days after written notice of termination to ORGANIZATION
i want to remove font-family: serif; from style

First of all, this is the invisible overlay used to enable text-selection/copying and searching. Hence it's not related to the display of the document, and thus modifying it like you suggest doesn't really make sense.
Furthermore, as mentioned at the top of the README the PDF.js library is a viewer and not a general PDF editor library.


Cards not flipping correctly on iOS

cards are showing back face, tested on iPhone 11 Pro:

try -webkit-backface-visibility


Remove dead links

Both the website and the screenshot link are dead, so it would be a good idea to remove them.

The whole project is dead lol


add teams CLI command

add dummy teams CLI command.
Commands exposed-
Create, List, Details and Delete of team backups
Does this PR need a docs update or release note?

[ ] :no_entry: No

Type of change

[ ] :sunflower: Feature

Issue(s)

https://github.com/alcionai/corso/issues/3837

Test Plan

[ ] :muscle: Manual
[ ] :zap: Unit test

Need help here- just want to create a mock/dummy command here. Because its the skeleton of all the commands. Implementation is still pending.

We normally add the cli last, after all the implementation is complete.  Nothing wrong with adding it first, but all commands and flags specific to teams should be marked hidden and annotated as pre-release versions (there should be helper funcs for this).

Need help here- just want to create a mock/dummy command here. Because its the skeleton of all the commands. Implementation is still pending.

I'm unclear on what you need help with here.  Are you trying to create mock/stub commands for testing?  Or are you trying to call the current live implementation of commands stubs, and asking if you've done it correctly?

Need help here- just want to create a mock/dummy command here. Because its the skeleton of all the commands. Implementation is still pending.

I'm unclear on what you need help with here. Are you trying to create mock/stub commands for testing? Or are you trying to call the current live implementation of commands stubs, and asking if you've done it correctly?

I had some confusion. But clear now.

@neha-Gupta1 I brought this PR back in line with main here.  On a separate branch so I didn't clobber your work.


Social links are fixed

Fixes Issue🛠
Closes #373
Description👨💻
Social links are added.
Type of change📄

[x] Bug fix (Instagram, twitter and facebook links are added)

How this has been tested✅
Tested on my local system.
Checklist✅

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added demonstration in the form of GIF/video file
[x] I am an Open Source Contributor

Screenshots/GIF📷
https://github.com/Rakesh9100/Beautiify/assets/148339919/214e85b2-9fa3-4a68-8292-72762bff7957

Merged!! Congrats on getting your PR merged to this repo under JWOC 🎉🎉 @prakharsingh-74


Create ISO from existing image files with error: file name must be at most 30 characters

Create ISO from existing image files with error: file name must be at most 30 characters
All files' name are transftered to Uppercase

The print is
panic: unable to calculate size of directory for spforbmc\spschema: could not calculate child *** entry size **: could not convert dirEntry to bytes: invalid filename ****: file name must be at most 30 characters, not including the separator '.'

OK, thank you! @deitch
The error code of at most 30 characters is here:

And the code to make iso is from example, the output iso filename is in Uppercase, and the origin name is in lower:
create-iso-from-folder
bootable_iso.go

I continue to be confused. I don't know what you actually are trying to do. You linked to 2 separate examples. Are you running on of them? Which one, and how? Ans are you seeing an error, or asking about the 30-character limit here?

@deitch i was seeing the error, and the code is combine the two example:
package main

import (
	"fmt"
	"io"
	"log"
	"os"
	"path/filepath"

	diskfs "github.com/diskfs/go-diskfs"
	"github.com/diskfs/go-diskfs/disk"
	"github.com/diskfs/go-diskfs/filesystem"
	"github.com/diskfs/go-diskfs/filesystem/iso9660"
)

func check(err error) {
	if err != nil {
		log.Panic(err)
	}
}

func FolderSize(path string) (int64, error) {
	var size int64
	err := filepath.Walk(path, func(_ string, info os.FileInfo, err error) error {
		if err != nil {
			return err
		}
		if !info.IsDir() {
			size += info.Size()
		}
		return err
	})
	return size, err
}

func CreateIsoFromFolder(srcFolder string, outputFileName string) {
	// We need to know the size of the folder before we can create a disk image
	// TODO: Are we able to create a disk image with a dynamic size?
	folderSize, err := FolderSize(srcFolder)
	check(err)

	// TODO: Explain why we need to set the logical block size and which values should be used
	// var LogicalBlocksize diskfs.SectorSize = 2048
	var LogicalBlocksize diskfs.SectorSize = 4096

	// Create the disk image
	// TODO: Explain why we need to use Raw here
	mydisk, err := diskfs.Create(outputFileName, folderSize, diskfs.Raw, LogicalBlocksize)
	check(err)

	// Create the ISO filesystem on the disk image
	fspec := disk.FilesystemSpec{
		Partition:   0,
		FSType:      filesystem.TypeISO9660,
		VolumeLabel: "label",
	}
	fs, err := mydisk.CreateFilesystem(fspec)
	check(err)

	// Walk the source folder to copy all files and folders to the ISO filesystem
	err = filepath.Walk(srcFolder, func(path string, info os.FileInfo, err error) error {
		check(err)

		relPath, err := filepath.Rel(srcFolder, path)
		check(err)

		// If the current path is a folder, create the folder in the ISO filesystem
		if info.IsDir() {
			// Create the directory in the ISO file
			err = fs.Mkdir(relPath)
			check(err)
			return nil
		}

		// If the current path is a file, copy the file to the ISO filesystem
		if !info.IsDir() {
			// Open the file in the ISO file for writing
			rw, err := fs.OpenFile(relPath, os.O_CREATE|os.O_RDWR)
			check(err)

			// Open the source file for reading
			in, errorOpeningFile := os.Open(path)
			if errorOpeningFile != nil {
				return errorOpeningFile
			}
			defer in.Close()

			// Copy the contents of the source file to the ISO file
			_, err = io.Copy(rw, in)
			check(err)
		}

		return nil
	})
	check(err)

	iso, ok := fs.(*iso9660.FileSystem)
	if !ok {
		check(fmt.Errorf("not an iso9660 filesystem"))
	}

	options := iso9660.FinalizeOptions{
		VolumeIdentifier: "my-volume",
		RockRidge: true,
		DeepDirectories: true,
		ElTorito: &iso9660.ElTorito{
			BootCatalog: "isolinux/boot.cat",
			Entries: []*iso9660.ElToritoEntry{
				{
					Platform:  iso9660.BIOS,
					Emulation: iso9660.NoEmulation,
					BootFile:  "isolinux/isolinux.bin",
					BootTable: true,
					LoadSize:  4,
				},
				{
					Platform:  iso9660.EFI,
					Emulation: iso9660.NoEmulation,
					BootFile:  "images/efiboot.img",
				},
			},
		},
	}

	err = iso.Finalize(options)
	check(err)
}

func main() {
	CreateIsoFromFolder("./dist", "./iso/test.iso")
}

That is quite helpful, thanks.
What is in dist/? I see the screen capture, but what are the sources?

The files in dist
dist
├── EFI
│   ├── BOOT
│   │   ├── BOOTX64.EFI
│   │   ├── fonts
│   │   │   └── unicode.pf2
│   │   ├── grub.cfg
│   │   ├── grub.cfg.usb
│   │   ├── grubx64.efi
│   │   └── mmx64.efi
├── LiveOS
│   └── squashfs.img
├── Project
│   ├── app
│   │   ├── at-spi2-atk-2.34.2-1.eulerosv2r10.x86_64.rpm
│   │   ├── at-spi2-core-2.36.0-1.h1.eulerosv2r10.x86_64.rpm  # file length > 30
...
├── images
│   ├── efiboot.img
│   └── pxeboot
│       ├── initrd.img
│       └── vmlinuz
├── isolinux
│   ├── boot.cat
│   ├── boot.msg
│   ├── grub.conf
│   ├── initrd.img
│   ├── isolinux.bin
│   ├── isolinux.cfg
│   ├── ldlinux.c32
│   ├── libcom32.c32
│   ├── libutil.c32
│   ├── syslinux.cfg
│   ├── vesamenu.c32
│   └── vmlinuz

Are you saying the content doesn't matter, just having a file - any file - with a filename > 30 chars?

That isn't too surprising; iso9660 only supports filenames up to 30 characters (in levels 2 and 3; level 1 was only old DOS-style 8.3). Rock Ridge adds support for more POSIX-style filenames, up to 255 chars.

@deitch 👍


Bot receives multiple messages

I am building a chat bot using Swift and Xcode 8. The Slack client delegate function:
func received(_ message: Message, client: SlackClient){}
seems to be called multiple times. The bot builds answer based on incoming message, therefore the message from bot also gets printed more than once.

Apologies for the late reply - I'd recommend upgrading to the 4.0.0 release. If you're still seeing issues after upgrading, please follow up here or open another issue.
Peter


Separate endpoints per URL in the UI

Is your feature request related to a problem? Please describe
APIv2 supports endpoints as separate entities for separate protocol+host+port+query+fragment combinations. However, when I add them in the UI, they are grouped on a per-host basis, and certain things (like tagging and deletion) only work on per-host instead of per-endpoint basis.
Describe the solution you'd like
I'd like all endpoints to be displayed as fully-qualified URLs in the UI, with ability to edit (e.g. set tags/attributes) and delete endpoints separately from each other.
Describe alternatives you've considered
The only alternative/workaround that works now is Endpoints APIv2 (either programmatic or via Swagger UI), but that's less convenient from the UI usability standpoint.
Additional context
We're using the latest defectdojo/defectdojo-django Docker image.

@dinvlad take a look at the big PR on endpoints. some features in it will cover your need I think https://github.com/DefectDojo/django-DefectDojo/pull/4188


Added raccoon

I didn't know if I should put Unlicense or Public Domain in the License section, feel free to change it. Also I was surprised there wasn't any public domain fantasy consoles already, what's up with that?
Thanks for maintaining this list!

You really ought to license it as CC0 as some countries don't allow you to simply place your work into the public domain.

I'm already licensing it as Unlicense, would there really be any benefits switching to CC0?

Unlicense occupies a gray area, and may be illegal/non-binding in some jurisdictions. CC0, is more comprehensive, and ensures that your software is as free as possible in jurisdictions that, say, have no concept of public domain.

Thanks for adding it!
Would you prefer to switch it to CC0 or other license before merging or leave it as is?

Leave it as it is for now, I'm grateful for the license suggestion but I'll have to reflect on that before making the change :)
I'll be sure to do another pull request if any info changes, if that's alright with you.

Anytime you wish.


Cannot read property 'hasAttribute' of undefined

Dear contributers,
I got this issues when lauching my app on browser today. Please help me to take a look into this . Thanks!

@ngocongcan It would be helpful if you can show us your code.
And I can already tell you, that you want to access a value which is not defined or known.

Hello! While we greatly appreciate you opening an issue with us I am going to close this issue and ask that you open a new one that has the issue template filled out, please. Thanks for using Ionic!

I have the solution:
Do like this
<ion-slides *ngIf="slideData && slideData.length" autoplay="5000" class="slideroption" pager="true"   loop="true" speed="300">
	  <ion-slide   *ngFor="let slide of slideData">
                <img src="{{slide.imag}}" />
          </ion-slide>
	</ion-slides>


remove redundant comma

Hey, Juho. How are you?

Hey, thanks for the poke.
I think the Babel configuration could benefit from refactoring. If I understood right, Babel allows you to write it in JavaScript now. Doing that would likely simplify it a lot (good PR to make).

@bebraw yeah, I've just added some babel plugin and had to write it in each env option although it says that it should be merged with non-env rules ¯_(ツ)_/¯


Adjusting the focus: less data, more R

Is it worth it to move the focus to R and programming, and less on data? That would include removing slides on tidy data, and removing this element from the course description.
Pro: we already have so much material to work through, and understanding data is not the primary aim of the workshop.
Con: if not now then when! Also, our central theme is data, and understanding what makes data workable is an important part of this...

Considering:

Discussing tidy data (long v wide) only once instead of twice;
Generating a module with questions that would work as stand-alone and can be used in the R cafe as well.


Change expect timeout

Hi!
In my project  I have expect that exceeds 5 seconds, how can i change the playwright settings with cucumber.
(I already changed the setDefaultTimeout)
Thank you :)

if it is only a single expect - you can put it in the relevant step. I am not sure the global timeout for PW can be changed.

Yes, there are many expect.
On playwright you can change the expect timeout like this:
expect:{
timeout: 3000
}
but I don't know how to import it to this project, since the configuration is different

I guess this should work: https://playwright.dev/docs/next/test-assertions#expectconfigure

I want to do the same (setting a global expect timeout).
In a test run by the Cucumber runner the timeout I pass to expect.configure is ignored (the default of 5000ms is used). It works as expected in a test run by the Playwright runner. ☹

https://playwright.dev/docs/next/test-assertions#expectconfigure

Hi, I have the same issue, when do you change it? I change in cucumber.mjs file not sure it works or not

timeouts are defined in playwright test runner which is not used in this repo (only PW library). File an issue on the PW repo to expose the action global timeouts in the library, and then it will be available.


Alwasy returning 404 from the server is a bug

What this does
Merged this change because I thought it fixed API status code issues and believed that Cypress failing was a fluke.
I was wrong.
Undoing the change.
How to test
Add user steps to achieve desired functionality for this feature.

Step 1 is to undo the change.
Future improvements can be handled in a separate PR.


Adding CosmosDB Trigger Template

This PR is part of the series started to add support for the Cosmos DB Trigger.

Webjobs Extension: https://github.com/Azure/azure-webjobs-sdk-extensions/pull/244
Script Host support: https://github.com/Azure/azure-webjobs-sdk-script/pull/1677

@ealsur,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot


[server] Do not insert records into transient record cache while the …

…drainer queue is full
This is a tactical fix.  This change prevents the transient record from growing if the memory budget for the drainer queue is close to full or exhausted.

Summary, imperative, start upper case, don't end with a period

Resolves #XXX
How was this PR tested?

Does this PR introduce any user-facing changes?

[x] No. You can skip the rest of this section.
[ ] Yes. Make sure to explain your proposed changes and call out the behavior change.

This method won't actually solve our problem.  We'll need to do a more in depth fix.


chore: follow the unused variable naming convention

We should follow the underscore naming convention for unused variables to avoid editor prompts.

CC @sxzz


InkWell  not borderRadius

Describe the bug
InkWell does not publicly disclose Borderradius, and onInkTap cannot customize shapes

The Ink component is also missing


Top-Nav items poke through when sidebar is expanded

Expected experience: Top Nav items are pushed to the left or hidden when sidebar is expanded

Ignore the left side of this screenshot please.
On the right side of the screenshot you can see that the "Google apps" button shows through the sidebar panel when it should not. Should be as simple as setting the element to display:none when the sidebar is clicked I believe

I'm not getting the google apps overlay issue, but the red "+" circle (new email) is overlaying the sidebar for me, too

The left hand nav issue where the nav items overlay over the mail items is happening for me too. It's related to the browser width, happens for me at a width of 1650px.
Is this what this issue is about? Or should I open a new issue for that?


khoj: 0.3.0 -> 0.11.1

Description of changes
Should be merged after #249553.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

If I rebase on nixpkgs, I got error: Package ‘python3.10-tensorflow-2.11.1’ in /home/bbigras/nixpkgs/pkgs/development/python-modules/tensorflow/default.nix:446 is marked as insecure, refusing to evaluate.. This might be recent.

Yes, seems like we have to wait for https://github.com/NixOS/nixpkgs/issues/250245.


Fix "tilde" spelling

I had done a complete search but just realized it was set to a specific directory. Oops. Thanks for noticing.


Asides at the bottom of a doc gets clipped and adds a scrollbar within a scroll area

Clipping is not great!

The challenge here is knowing when an aside is rendered near the end of the viewport and adjust. This has to happen after rendering is done, which is pretty annoying in Elm.
A good option would be to render asides in docs wrapped in a WebComponent that adjusts for this kind of thing. We could use the same WebComponent for tooltip adjustments.


OCPBUGS-44473: Add openshift to the groups of system:hosted-cluster-config

What this PR does / why we need it:
The managed-cluster-validating-webhooks that are deployed to rosa clusters are preventing the HCCO from updating certain resources including ingress.config.openshift.io. This is because they have a list of privileged users and groups that are allowed. We recently changed the user for the HCCO to system:hosted-cluster-config which is not considered a privileged user.
This commit adds "system:serviceaccounts:openshift" as an organization to the certificate of the system:hosted-cluster-config user. Kubernetes considers any organizations specified in the certificate subject as the groups to which the subject belongs, effectively making
system:hosted-cluster-config a member of the system:serviceaccounts:openshift group, which is one of the accepted privileged groups in the webhook.
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #OCPBUGS-44473
Checklist

[x] Subject and description added to both, commit and PR.
[x] Relevant issues have been referenced.
[ ] This change includes docs.


Pydantic V2 Support

Hi everyone,
Currently, this project doesn't work with pydantic v2. It is possible that a compatible version can be released as Fastapi did. Any plans?
Thanks

I added the support in a fork if you are not using ormar db, you can use it: https://github.com/furkan-guvenc/fastapi-crudrouter


OS create_snapshot posts optional keywords only when needed

OS create_snapshot_volume does not post optional keywords if they are None
Description
On never OpenStacks, posting None for name or description will return a 400 Bad Request.
Status

done, ready for review

Checklist (tick everything that applies)

[x] Code linting (required, can be done after the PR checks)
[x] Documentation
[x] Tests
[x] ICLA (required for bigger changes)

👍


fix(license): Updating license file

:tada: This PR is included in version 1.0.3 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


[Draft] Fixed hover effects

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs:

Before: https://main--world-bank--aemsites.hlx.live/ext/en/home
After: https://refactoring--world-bank--aemsites.hlx.live/ext/en/home

@mkbansal1 Noticed one bug in the header close button, the close x mark is not visible when in active state.

@thomsebastin Merging it for now. Will fix these two in next PR


Remove propagation formats

See #16

DataDog propagation format is not removed for now because the tests rely on some form of trace context propagation.

Thx! Do you mean functionality that will be brought back via OpenTelemetry SDK, or something that we will need to bring back in the agent code itself?

I think you're right that this functionality will be implemented in the SDK, so carry on.


Added azure-messaging-nspkg

Added azure-messaging-nspkg (like the title suggests :))

/evaluate check-enforcer

/azp run prepare-pipelines


[INLONG-5223][Manager] Add heartbeat Mechanism for Inlong component cluster

Prepare a Pull Request
(Change the title refer to the following example)

Title Example: [INLONG-XYZ][Component] Title of the pull request

(The following XYZ should be replaced by the actual GitHub Issue number)

Fixes #5222

Motivation
1 Add heartbeat manager interface in Inlong common;
2 Add heartbeat manager in Agent;
3 Add heartbeat manager in Dataproxy;
4 Optimize heartbeat mechanism in Manager, use Caffeine cache to manipulate evict node;
5 Add inlong cluster Api in Manager Client;
6 Add cluster tag in Agent Environment;
7 Add cluster status and node status enums;
8 Add clusterTag in FileCollectorTask;
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)

[ ] This change is a trivial rework/code cleanup without any test coverage.

[ ] This change is already covered by existing tests, such as:
(please describe tests)

[ ] This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@kipshi Please, update your title becuse the PR for multiple modules.


ERROR Could not query API :(TypeError) '>' not supported between instances of 'NoneType' and 'int'

channel : : rfm
ERROR - api_import.py:229 | Could not query API :(TypeError) '>' not supported between instances of 'NoneType' and 'int'

fixed #98


"module" entry points to web bundle

What happened?
I'm bundling my node.js code with webpack for serverless.
With bundled @octokit/webhooks-methods, my code doesn't run and throws an error: Exception: ReferenceError: crypto is not defined.
What did you expect to happen?
Code generated by webpack to run.
What the problem might be
@octokit/webhooks-methods defines these entries in package.json:
  "main": "dist-node/index.js",
  "module": "dist-web/index.js",
  "source": "dist-src/index.js",
  "types": "dist-types/index.d.ts",

Webpack favours module (see https://github.com/webpack/webpack/issues/5756 ) because it helps with e.g. better tree shaking, but the module entry here points to the dist-web/index.js file which doesn't include crypto and buffer imports.
IMO the module entry should be renamed to browser.

I am also running into this issue.
I just manually changed the module key in the package.json file to browser before packing up my serverless code as a test, and my code all worked as expected.
After changing browser back to the incorrect module see package.json standard and webpack docs...
I added a rule to the module key in my webpack configuration that specifies the correct mainField
{
  test: /node_modules\/@octokit\/webhooks(-methods)?/,
  resolve: {
    mainFields: ['main']
  }
}

I suspect if this bug is ever completed, this may have to change, but for now... this is working for me in case anyone else finds this thread.

Unfortunately this isn't a problem we can fix ourselves. This would be a problem with the build system, which is not maintained anymore.
This will get fixed once we switch to using pure ESM + seperate types

We are starting to migrate away from Pika, and towards using esbuild to generate the different bundles, and tsc to generate the types.
We will be able to get this addressed in a new major version

#159 Should help get this sorted out
In the meantime, you can always load the package from a CDN:
import { sign, verify } from "https://esm.sh/<EMAIL_ADDRESS>


Merge Support Page Additions Into Main CSS Repository For Publishing

I've gone and filled out the support page of the CSS website with content. The "we're working with the department" message is still there to reflect the fact that CSS is waiting for advice from them.
It is organised into three headings: who is the page for, what problems people might have, and what services are available to students. They try to be relevant to CS students, but I aimed to get as much information on the page as possible.
On a technical note - the list of support services would be much better administered as a YAML dynamic thing like the jobs listing. I didn't trust myself to do that though, so I just wrote the content for the sake of getting it out there and available for people to use. Also, I hope I added the additional style rules in the right place? Also also, I have done nothing to the main branch, so after the merge it would still need publishing.
Keen to hear what people think! :-)

Thanks for the PR; content looks good to me!
Give me a day or so to bring the styling a tad more inline with the rest and add you to the contributors.
Cheers!

Thanks for the PR; content looks good to me!
Give me a day or so to bring the styling a tad more inline with the rest and add you to the contributors.
Cheers!

No problem, glad I can help!
Yeah I definitely went for content above style haha, thanks for clearing it up!

No problem, glad I can help!
Yeah I definitely went for content above style haha, thanks for clearing it up!

Has there been any movement on this? I know Alexis is working with the department, but it'd be nice to have something up people can use. Even if it is ugly!

The support page was put on hold for a bit as we were hoping to get content from the department. We recently decided to proceed with this, though, so I'll merge it today!

Merged and integrated!


Update size-label.yml

:white_check_mark: Build GuiStracini.SDKBuilder 3.0.237 completed (commit https://github.com/guibranco/GuiStracini.SDKBuilder/commit/75eee9ac43 by @guibranco)


perf(decorator) : add key and descriptor to inject

For inject into functions not Class constructor

Thanks!


"service account deis/deis-registry was not found"

Running gcr off-cluster -- getting this on the registry rs: Error creating: pods "deis-registry-3280823271-" is forbidden: service account deis/deis-registry was not found, retry after the service account is created

Seems like the pod is still being created. Can you post your config? According to the chart, the registry is installed only when the storage_location parameter is set to on-cluster.
pinging @kmala for visibility on this issue

In future tickets, would you mind placing helm-related issues in deis/charts? That would be helpful triaging these issues. Thanks! :)

ping @tmc

closing due to inactivity. in the future, if you could please post your config as well as perform some general troubleshooting with kubectl, it would really help us try to nail down the issue quicker. Thanks!


Overlay windows forms on top of games (Help Request)

Hello, i am trying to do a windows forms overlay, so basicly i have a transparent form with some labels in it, and i want this form to be overlayed on the top left corner of a game (Fullscreen). Is there anyway i can do that using this library? Thanks

no