Inquiry about Dataset Composition

Thank you very much for sharing your excellent algorithm and research paper. However, I have a question that I would like to inquire about during the learning process, so I am leaving an issue.
Regarding Taskonomy tiny, it is composed of 35 scenes for the train and validation split. While analyzing the omnidata_tools/dataset/starter_dataset/component_datasets/taskonomy/init.py file of the library during the download using omnidownloader, I noticed that woodbine is excluded from the train split, as indicated by the line: "forbidden_buildings = ['mosquito', 'tansboro', 'tomkins', 'darnestown', 'brinnon', 'rough', 'woodbine'] # We do not have the rgb data for tomkins, darnestown, brinnon". I also confirmed that woodbine is indeed excluded during the actual download.
Therefore, I believe that only 34 scenes were used in the training of the model. I wanted to inquire if this is indeed the case and if there might be a slight discrepancy in reproducing the research described in the paper.
Thank you very much.
Sincerely,
Jiho Choi

I've had the same problem as you. To solve this, 'woodbine' data was downloaded directly through wget. See the link below.
https://datasets.epfl.ch/taskonomy/links.txt

@ijihoon98 could be please be elloborate with this:
About the building info what exactly are we using? when i downloaded the tiny dataset i can see the taskonomy folder consisting of

but in the building train list I cant find the name of ackermanville.

you said that downloading the woodbine will solve that, but I which woodbine file were you talking about?

I tried to download the RGB file of woodbine and replaced the RGB folder of tiny dataset still getting this error:
python main.py --stage 0 --task_fold 1
C:\Users\rajar\AppData\Local\Programs\Python\Python311\Lib\site-packages\torch\amp\autocast_mode.py:204: UserWarning: User provided device_type of 'cuda', but CUDA is not available. Disabling
warnings.warn('User provided device_type of 'cuda', but CUDA is not available. Disabling')
Load ckpt from model/pretrained_checkpoints\beit_base_patch16_224_pt22k.pth
Load state_dict by model_key = model
Expand the shared relative position embedding to each transformer block.
Traceback (most recent call last):
File "D:\OneDrive - Deakin University\Desktop\visual_token_matching\main.py", line 75, in
run(config)
File "D:\OneDrive - Deakin University\Desktop\visual_token_matching\main.py", line 25, in run
model, ckpt_path = load_model(config, verbose=IS_RANK_ZERO)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\OneDrive - Deakin University\Desktop\visual_token_matching\train\train_utils.py", line 228, in load_model
model = LightningTrainWrapper(config, verbose=verbose)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\OneDrive - Deakin University\Desktop\visual_token_matching\train\trainer.py", line 37, in init
self.support_data = self.load_support_data()
^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\OneDrive - Deakin University\Desktop\visual_token_matching\train\trainer.py", line 52, in load_support_data
support_data = generate_support_data(self.config, data_path=data_path, verbose=self.verbose)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\OneDrive - Deakin University\Desktop\visual_token_matching\dataset\dataloader_factory.py", line 218, in generate_support_data
dset = TaskonomySegmentationDataset(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\OneDrive - Deakin University\Desktop\visual_token_matching\dataset\taskonomy.py", line 550, in init
self.class_idxs = [class_idx for class_idx in class_idxs if self.img_paths[class_idx].split('')[0] in buildings]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\OneDrive - Deakin University\Desktop\visual_token_matching\dataset\taskonomy.py", line 550, in
self.class_idxs = [class_idx for class_idx in class_idxs if self.img_paths[class_idx].split('')[0] in buildings]
~~~~~~~~~~~~~~^^^^^^^^^^^

@rajayarli Please change the code line <self.class_idxs = [class_idx for class_idx in class_idxs if self.img_paths[class_idx].split('')[0] in buildings] >
to <self.class_idxs = [class_idx for class_idx in class_idxs if class_idx<len(self.img_paths) and self.img_paths[class_idx].split('')[0] in buildings]>

@rajayarli Please change the code line <self.class_idxs = [class_idx for class_idx in class_idxs if self.img_paths[class_idx].split('')[0] in buildings] > to <self.class_idxs = [class_idx for class_idx in class_idxs if class_idx<len(self.img_paths) and self.img_paths[class_idx].split('')[0] in buildings]>

done that getting this error:
PS D:\OneDrive - Deakin University\Desktop\visual_token_matching> python main.py --stage 0 --task_fold 1
C:\Users\rajar\AppData\Local\Programs\Python\Python311\Lib\site-packages\torch\amp\autocast_mode.py:204: UserWarning: User provided device_type of 'cuda', but CUDA is not available. Disabling
warnings.warn('User provided device_type of 'cuda', but CUDA is not available. Disabling')
Load ckpt from model/pretrained_checkpoints\beit_base_patch16_224_pt22k.pth
Load state_dict by model_key = model
Expand the shared relative position embedding to each transformer block.
Traceback (most recent call last):
File "D:\OneDrive - Deakin University\Desktop\visual_token_matching\main.py", line 75, in
run(config)
File "D:\OneDrive - Deakin University\Desktop\visual_token_matching\main.py", line 25, in run
model, ckpt_path = load_model(config, verbose=IS_RANK_ZERO)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\OneDrive - Deakin University\Desktop\visual_token_matching\train\train_utils.py", line 228, in load_model
model = LightningTrainWrapper(config, verbose=verbose)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\OneDrive - Deakin University\Desktop\visual_token_matching\train\trainer.py", line 37, in init
self.support_data = self.load_support_data()
^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\OneDrive - Deakin University\Desktop\visual_token_matching\train\trainer.py", line 52, in load_support_data
support_data = generate_support_data(self.config, data_path=data_path, verbose=self.verbose)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\OneDrive - Deakin University\Desktop\visual_token_matching\dataset\dataloader_factory.py", line 227, in generate_support_data
X, Y, M = batch
^^^^^
UnboundLocalError: cannot access local variable 'batch' where it is not associated with a value


Memory improvements (The return)

Before  :

When we add a layer, the image added is casted into the type of the layer 0 for VR visualization. Memory is therefore allocated, even when VR is not activated. This can be troublesome with 600x600x200 images for example (CTscan) and paint segmentation. You can easily reach 1 Go with no effort.
The vtkImageAppendComponents  is used to append the different layers into a single vtkImageData which is then setted as an input in the VolumeMapper. The VR visualization of this data can be extremely painful when we have more than 1 layer. We noticed that it is quite slow even when the visibility of all layers except the layer 0 is set to off.

Now:

We keep in mind which layers need to be casted, and we cast them only when the VR mode is activated.
We have changed the code so that when the visilibility of a layer is set to off, its data is not given to the vtkImageAppendComponents to be appended. This enables us to improve interactions, and to be able to have normal VR on a single layer if all the other are Off (visibility) .

Remaining issues :

After deleting a layer, no memory seems to be deallocated.
In a simple case, like for example using paint on an image, a new layer is added, if the user wants to go to VR mode to visualize its layer 0, this will lead to memory allocated for its layer 1 which he probably doesnt want to see in VR, and his/her computer getting slow because of multiple layers being ON (visibility). A possible solution would be to set to Off (visibility) all layers excepts the layer 0 when going to VR. The user can still activate them back, if he wants to visualize them. What do you think ??

Some notes, i tested this old PR, adapted to the current medInria3.4.x branch which have been heavily changed in the way data are displayed in a view.
My test branch https://github.com/medInria/medInria-public/compare/medInria3.4.x...mathildemerle:HakimRAM?expand=1
I didn't see noticeable memory gain between 3.4 and these changes: opening a data, closing a data, opening again, switching to 3D orientation (MSR), switching to VR, closing the data and closing the app.
Perhaps there is a change in the way data are shown in VR, but for now i did not find a difference with medInria3.4.x for the user.


Better JsonNumber coverage (and related fixes)

This PR includes @jeremyrsmith's change from #400 adding JsonNumbers created from BiggerDecimal to the Arbitrary instance for JsonNumber.
This change causes some Jackson and Scala.js tests to fail, but for known reasons, so this PR includes updates for the circe-jackson and circe-scalajs tests to take the new Arbitrary[JsonNumber] into account.

Current coverage is 81.90% (diff: 100%)

No coverage report found for master at ec5923c.

Powered by Codecov. Last update ec5923c...03d9203


Show toolbar only when keyboard is opened. How?

Hello!
I want to show the toolbar only when keyboard is opened. Otherwise, I want to hide it. Is it possible?

Thank you!

This is more of a user's code and not a library code question, but this is a start. It's still not perfect, you'll see a small hiccup when returning from a custom keyboard to the regular one, but I'll leave that to you.

@M-i-k-e-l
Thank you, it works!
I was able to easily solve also the hiccup.


URL Cleanup

This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener).
HTTP URLs that Could Not Be Fixed
These URLs were unable to be fixed. Please review them to see if they can be manually resolved.

http://cvsweb.netbsd.org/bsdweb.cgi/~checkout~/src/sys/kern/syscalls.master (200) could not be migrated:
(https result ConnectTimeoutException).

Fixed URLs
Fixed Success
These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended.

http://cvsweb.openbsd.org/cgi-bin/cvsweb/~checkout~/src/sys/kern/syscalls.master migrated to:
https://cvsweb.openbsd.org/cgi-bin/cvsweb/~checkout~/src/sys/kern/syscalls.master (https result 200).
http://gitweb.dragonflybsd.org/dragonfly.git/blob_plain/HEAD:/sys/kern/syscalls.master migrated to:
https://gitweb.dragonflybsd.org/dragonfly.git/blob_plain/HEAD:/sys/kern/syscalls.master (https result 200).
http://svn.freebsd.org/base/stable/10/sys/kern/syscalls.master migrated to:
https://svn.freebsd.org/base/stable/10/sys/kern/syscalls.master (https result 200).

This changes a URL that is in a script from a vendored dependency. We do not use this script.


Fix #95 viminfo custom location

Hey, sorry for the late response; I was busy with travel and work these past couple of weeks.


Python: Attach using Process Id no longer prompting for process

Environment data

VS Code version: Latest, I just reinstalled
Extension version (available under the Extensions sidebar): 2020.10.332292344
OS and version: Windows 10 64bit 1909 (upgraded to 20H2, same issue)
Python version (& distribution if applicable, e.g. Anaconda): 3.6
Type of virtual environment used (N/A | venv | virtualenv | conda | ...):N/A
Relevant/affected Python packages and their versions: XXX
Relevant/affected Python-related VS Code extensions and their versions: XXX
Value of the python.languageServer setting: XXX

[NOTE: If you suspect that your issue is related to the Microsoft Python Language Server (python.languageServer: 'Microsoft'), please download our new language server Pylance from the VS Code marketplace to see if that fixes your issue]
Expected behaviour
Able to attach to ProcessID
launch.json:
{
// Use IntelliSense to learn about possible attributes.
// Hover to view descriptions of existing attributes.
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
"version": "0.2.0",
"configurations": [
{
"name": "Python: Attach using Process Id",
"type": "python",
"request": "attach",
"processId": "${command:pickProcess}"
}
]
}
Actual behaviour
Never get prompted to pick process.  If I put the actual processID in the string it catches thebreakpoint.
Steps to reproduce:
enter the above then run the debugger
Logs
Nothing that seems relevant

I'm seeing the same thing on a Mac setup. Details:
MacOS Catalina 10.15.7 (19H15)
VS Code Version 1.51.0
Python 3.8.1 64-bit

Seeing this issue with several dev machines.
Windows 10 64bit, v. 2004
VS Code version 1.51.0
Python 3.8.3 64-bit (Conda)

I'm facing the same issue for:

VSCode Version: 1.51.0
OS Version: Windows_NT x64 10.0.19041

We are able to reproduce this. Looks like Quick Pick show API provided by VS Code is broken in the 1.51 release. If the Quick Pick has a button for some reason we need to call  show on it twice for it to work in 1.51.
/cc @karrtikr who investigated this issue.

Upstream VSCode issue being tracked here: https://github.com/microsoft/vscode/issues/110432
As a workaround, please use VSCode version <=1.50

Will be fixed in the next release.


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_104h697nc0/clone/recipe/meta.yaml:14: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_104h697nc0/clone/recipe/meta.yaml:21: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_104h697nc0/clone/recipe/meta.yaml:39: missing_dev_url: The recipe is missing a dev_url
ERROR: /tmp/abs_104h697nc0/clone/recipe/meta.yaml:39: missing_documentation: The recipe is missing a doc_url or doc_source_url
WARNING: /tmp/abs_104h697nc0/clone/recipe/meta.yaml:39: missing_description: The recipe is missing a description
ERROR: /tmp/abs_104h697nc0/clone/recipe/meta.yaml:39: missing_license_family: The recipe is missing the about/license_family key.
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_5b4q7cmq0f/clone/recipe/meta.yaml:14: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_5b4q7cmq0f/clone/recipe/meta.yaml:21: missing_wheel: For pypi packages, wheel should be present in the host section
WARNING: /tmp/abs_5b4q7cmq0f/clone/recipe/meta.yaml:39: missing_description: The recipe is missing a description
ERROR: /tmp/abs_5b4q7cmq0f/clone/recipe/meta.yaml:39: missing_dev_url: The recipe is missing a dev_url
ERROR: /tmp/abs_5b4q7cmq0f/clone/recipe/meta.yaml:39: missing_license_family: The recipe is missing the about/license_family key.
ERROR: /tmp/abs_5b4q7cmq0f/clone/recipe/meta.yaml:39: missing_documentation: The recipe is missing a doc_url or doc_source_url
Errors were found


fix(types): export all types and interfaces

This has changes that relied on the breaking change from 10.2. It will need to be fixed up to remove those changes.

This PR is outdated and should either be closed, re-architected or rebased against v3 beta. Thanks!


[export] Add a LoweringParameters.for_export boolean context for exporting

This boolean context field is set only when we are lowering for exporting. It can be used, e.g., to adapt the lowering rules for the export case.

The way this is implemented, export is more opt-out rather than opt-in, which seems dangerous to me? We can start this way, but do we have plans to flip the logic somehow?

I do not think that I understand the concern. Currently, we require the user to use the export API for anything that needs to have compatibility. But as long as the user uses export(), rather than lower(), there is no other thing they need to do to opt into the compatibility. I plan to document this in the lower() API, in case some user is tempted to archive that directly.
Are suggesting that for_export should be True by default and only set it to False in jit?

My concern was that if a primitive lowering ignores this flag, then it will not do anything special for export, even if its lowering is not guaranteed to be stable. This can be a problem, unless we keep a separate allowlist of primitives in export()

I am assuming that Jax developers would be aware of
go/jax-export-compatibility where we explain what needs to happen.
What I am thinking of is to set up a OSS test with the already released
version of jaxlib to check that the new lowering still works.
On Thu, Jun 6, 2024, 10:12 Adam Paszke @.***> wrote:

My concern was that if a primitive lowering ignores this flag, then it
will not do anything special for export, even if its lowering is not
guaranteed to be stable. This can be a problem, unless we keep a separate
allowlist of primitives in export()
—
Reply to this email directly, view it on GitHub
https://github.com/google/jax/pull/21655#issuecomment-2151794689, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AA5V6J3MOPXSF5JLKWK3MPTZGARYDAVCNFSM6AAAAABIZ66WW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJRG44TINRYHE
.
You are receiving this because you were assigned.Message ID:
@.***>


Get error when first click rating and key press input?

You can see the video for more on this error
https://streamable.com/lvijt
or
https://drive.google.com/open?id=1_oBwZmvdRjFceOkiDCZ8NgBJV16RTNBz
I integrated it with TextField of Material-UI
Please fix it, Thank you so much!

Thank you so much, I see and I tried it successfully. Thanks for your reply 😉


Upload v0.1.1 to pypi?

I note there was a version bump to v0.1.1 back in March, however the latest version on PyPi is still 0.1.0 - would it be possible to get 0.1.1 released and uploaded?

Thanks for reporting. Addressed in the linked merged PRs: https://pypi.org/project/PyTumblr/


Docker Image Next steps

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/499
Originally created by @valexieva on 2019-03-18 23:24:34

Problem to solve
(Summarize the problem we are trying to solve in the form of we need to do [A], so that [B] can [C])
Currently, we push all changes during releases to Docker. We also have documentation and a simple e2e test. This issue relates to future requirements that we foresee to maintain installs and adoption. The docker image is an extension of the PiPy package.
Target audience
(For whom are we doing this? Include a persona)

The full stack engineer setting up Meltano for their data team

Further details
(Include use cases, benefits, and/or goals)

[x] to increase discovery on docker hub, we could polish the image page from marketing perspective: https://hub.docker.com/r/meltano/meltano - @bencodezen  - https://gitlab.com/meltano/meltano/issues/568
we should continue to monitor size of the image
[ ] testing infrastructure would continue to require attention as we add more features - currently the e2e test only focuses on carbon intensity - @mbergeron to write a proposal for full test
[ ] as we add more functionality such as orchestration, we should think about organization and the topology of different services that Meltano will offer - @mbergeron to write a proposal

Proposal
(How are we going to solve the problem? Try to include the user journey)

ensure that whenever we are releasing or designing features, we have docker in mind and think of Meltano as an external service.

What does success look like, and how can we measure that?
(Define both the success metrics and acceptance criteria. Note that success metrics indicate the desired business outcomes, while acceptance criteria indicate when the solution is working correctly. If there is no way to measure success, link to an issue that will implement a way to measure this)

AC - ensure e2e docker tests are updated and running after each feature/ bug

Regression test
(Ensure the feature doesn't cause any regressions)

[ ] Write adequate test cases and submit test results
[ ] Test results should be reviewed by a person from the team

Links / references
https://docs.google.com/document/d/1OG2HzICuj0v2C1itznPoW4mI5KtroSDKSmDIPxet0OE/edit#heading=h.wtfp7g1r16nq
Please note that this was taken from GitLab, to be changed accordingly

View 9 previous comments from the original issue on GitLab


[FEAT] Minos recipe for static compiling

Is your feature request related to a problem?
Similar to the Windows PORTABLE version, it will be desirable to have a full Linux STATIC version.
Proposed solution:
I suggest to provide a recipe to compile TSDuck for the Ninos-static project (https://github.com/minos-org/minos-static) and make it available in his static-get repository (http://s.minos.io/). Then we will very easy to get it: static-get tsduck and run it in any Linux machine without compiling it.
Alternatives:
The current release method includes pre-compiled packages for several platforms. And this is nice. However, a full static version will be useful. Mainly to run it for testing on servers and/or containers.
Additional information:
I think the effort to provide a full static recipe for TSDuck will be easy for the author. And if hi maintains it, then it will be more easy to have new releases of TSduck supported. Please note that I'm not affiliated with this Minos project, but I have recently discovered it and find it interesting.

Building a static version of TSDuck has always been possible using make static. I haven't tried it for a while. I hope nothing was broken in the meantime. Please let us now if it still works.
I wasn't aware of that minos project. I tried to understand the rationale behind that and I can't help considering it as rather mistaken...
Building a static TSDuck on Linux is probably the worst idea on Earth. The only context into which this could be justified is a very small and specialized embedded system using a tuned version of tsp and nothing else. Any other use seems pretty silly for many reasons, including:

Only basic IP networking is possible, using bare IP addresses: no host names, no DNS, no HTTP, no HLS, no SRT, no RIST, just the Internet of the late 70's.
No smartcard support, no Dektec support and more generally no support for any feature which is available in shared library form only.
TSDuck is made of several tools. Each of them is very small, they all use the huge libtsduck.so shared library. With static linking, you get many huge executables. Not a very clever result.
All plugins must be statically linked inside tsp or tsswitch. They can no longer be shared libraries.
There could be no "standard static release" of TSDuck, only specialized builds for specialized needs. Simply because static linking disables many features.

This is really stepping back in history. I do not want to invest in that. Using make static and making sure it still works is the most I can accept about static linking. If anyone wants to contribute somehow to a "minos recipe" for TSDuck based on make static, fair enough, but I do not want to be involved in that.
Please note that more modern OS such as macOS have completely removed the capability of static build because it created more problems than it solved. Static linking is a remain of the past, nothing else.

Hi @lelegard ,
Ok, don't worry. However, please continue with your support of the make static.
In any case, without the idea of opening any out-of-the-scope discussion, let me to add one personal comment: Static linking support is a must-have for containers, distributed computing and IoT. From my point of view the current MacOS can't be used as an example of any server side modern operative system.
Regards.

Static linking support is a must-have for containers, distributed computing and IoT.

I can just repeat what I wrote: this is OK for a very small specialised embedded system (IoT) but definitely not on a server-side container because many TSDuck features are unavailable with static linking.


Task/test expansion

Codecov Report

Merging #7 (fb5d674) into main (93cdd75) will increase coverage by 38.87%.
The diff coverage is 80.30%.

@@             Coverage Diff             @@
##             main       #7       +/-   ##
===========================================
+ Coverage   23.22%   62.09%   +38.87%
===========================================
  Files          13       13
  Lines         577      591       +14
===========================================
+ Hits          134      367      +233
+ Misses        423      202      -221
- Partials       20       22        +2

Impacted Files
Coverage Δ

internal/datatype/datatypes.go
97.50% <ø> (ø)

internal/dbms/postgres/reverser.go
0.00% <0.00%> (ø)

internal/migration/dialect.go
0.00% <ø> (ø)

internal/schema/schema_validate.go
11.68% <0.00%> (-0.65%)
:arrow_down:

internal/dbms/mysql/migrator.go
66.08% <95.65%> (+66.08%)
:arrow_up:

internal/dbms/mysql/reverser.go
100.00% <100.00%> (+100.00%)
:arrow_up:

internal/dbms/base/dialect.go
100.00% <0.00%> (+73.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93cdd75...fb5d674. Read the comment docs.


bug in coordination of  GUI statement -> actants  ->props  interface and JSON data?

In the statement with id "3226c626-bbec-4b61-a108-9d6974921530", the GUI interface for the second actant props looks like this

See the second property "same content", the value slot is empty there.
But in the json data there is uuid of object which otherwise does not exists.  See the image and look for value object of the second prop object, there is object with entityId uuid "d6e9dc12-52fd-4841-a9ff-e94ac0178a26".  This  value object does not exist.

Some possible bug in deleting the json values with wild GUI operations?

Thanks, @tomaham. This will probably be hard to replicate.
In the statement with Stephanus Iohaninus, I see the prop values filled in properly.
I am trying to replicate this bug but we probably will need more e2e tests to cover all possible cases that may result in this situation

Sure, feel free to close this.


Not clear if swashbuckle supports namespace versioning

My routes are defined as per [MSDN blogs' namespace routing]:(http://blogs.msdn.com/b/webdev/archive/2013/03/08/using-namespaces-to-version-web-apis.aspx):
config.Routes.MapHttpRoute("DefaultApi", "api/{namespace}/{controller}/{id}", new { id = RouteParameter.Optional } );

When I go to /swagger/ui/index, I can see my endpoints, but they are not separated by version. And if I go to use the test form, namespace is a parameter. The parameter doesn't work... When I try it, it sends a request to /api/v1/v1.Test2, which obviously results in a 404.
When I enable API versioning, which is what I really want to do, Swagger UI no longer shows my endpoints. Instead, I only see a version at the top of the page.
.EnableSwagger(c => c.MultipleApiVersions(
    ResolveVersionSupportByRouteConstraint,
    vc =>
    {
        vc.Version("v1", "v1 - Initial Release");
        vc.Version("v2", "v2 - Future release");
    }))

How do I get it to work with custom routes?
This is what I see in the browser:

There's a stackoverflow question in which multiple people are interested.
I see a class AppendVersionToBasePath in the repository and a unit test It_handles_additional_route_parameters, but it's still not clear.

This is a dup of #317 and #303. You should read through both of them.
In summary, there is a flaw in the above implementation of "namespace routing" as it breaks the WebApi metadata layer - ApiExplorer and hence Swashbuckle


pom.xml:378-383: Finish the upgrade to qulice 0.17.5 by...

The puzzle 837-e35739d6 from #837 has to be resolved:
https://github.com/yegor256/takes/blob/c8f3ef2740506815b9c6398f50fb968462ee17d4/pom.xml#L378-L383
The puzzle was created by Victor Noël on 01-Dec-18.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@paulodamaso/z please, pay attention to this issue

Job #881 is now in scope, role is DEV

@0crat refuse

@0crat refuse (here)

@victornoel The user @victornoel/z resigned from #881, please stop working. Reason for job resignation: Order was cancelled

Tasks refusal is discouraged, see §6: -15 point(s) just awarded to @victornoel/z

The job #881 assigned to @krzyk/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

@0crat waiting for review of PR #883

@0crat waiting for review of PR #883  (here)

@krzyk The impediment for #881 was registered successfully by @krzyk/z

The puzzle 837-e35739d6 has disappeared from the source code, that's why I closed this issue.

@ypshenychka/z please review this job completed by @krzyk/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

The job #881 is now out of scope

@0crat quality good


Delivery Service Active Flag Rework

In accordance with the blueprint from #4654, this changes the active property of Delivery Services from a simple boolean to a three state system, where the three states are:

ACTIVE - The DS is routed and cache servers will generate configuration for it. The equivalent of true today.
PRIMED - The DS is not routed, but cache servers will still generate configuration for it. The equivalent of false today.
INACTIVE - The DS is not routed and cache servers will not generate configuration for it. Has no equivalent today.

Additionally, because I was making a new DS model already anyway since that's a breaking change, I made some things that are never allowed to be null or undefined into non-reference values (e.g. XMLID is a string not a *string etc.) and made lastUpdated format in RFC3339 in JSON responses.
The new model now totally drops LongDesc1 and LongDesc2, which were deprecated in the now-itself-deprecated APIv3 and unavailable for direct use in APIv4 - as an interesting consequence of this and how DSRs are stored internally, it is no longer possible to make a DSR that will set a DS's longDesc1 and/or longDesc2 to anything but null even using APIv3. They are shown as null in responses, but are otherwise totally ignored by Traffic Ops. DS longDesc1 and longDesc2 fields can still be manipulated directly and viewed as normal in APIv3.
I also made some changes to the testing utilities, because they weren't registering themselves as helpers so it was difficult to find actual failures.
Fixes #3746
This PR includes documentation, TO changes, and database migrations, but does not actually make the new state work in t3c, nor does it update Traffic Portal with the ability to deal with it. These efforts are left to a later date.

Which Traffic Control components are affected by this PR?

Documentation
Traffic Ops Client (Go)
Traffic Ops

What is the best way to verify this PR?
I've updated the tests, and really there's only one new DS permutation, which has a test case added, so there's not really a whole lot more to do than just run the tests. You can replicate them by using APIv5 to manipulate DSes and DSRs if you like, just make sure everything looks okay.
If this is a bugfix, which Traffic Control versions contained the bug?

7.x
6.x

PR submission checklist

[x] This PR has tests
[x] This PR has documentation
[x] This PR has a CHANGELOG.md entry
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

Tested the API tests locally, all work (v3/v4/v5) fine. Yet to test DS DSRs creation with API v5 curl cmds.

This PR depends on #7156

I need to change the migration file names because new migrations have been added since this PR opened. I'm in a meeting atm, I'll do it this afternoon.

Tested and reviewed the following:

Able to create DS with 3 states (Active, Primed, Inactive) using APIv5
Able to create DS with 2 states (as expected) (Active=true, Primed=false) using APIv3, APIv4, APIv4.1
See the timestamp format update in APIv5 ONLY
Could create DS and DSR with longDesc1 and longDesc2 in the JSON payload with all 3 API versions
#7094 didn't seem like it was fixed. I am able to change the routingName even when the value is set to cdn
GET receives the right DS structure (3.0 and 4.0 doesn't show regional field but 4.1 and 5.0 shows it)
Update to testing utilities makes sense to implement.
Variable name changes are tested in all three versions of API tests
DB migration files need timestamp change.
Remaining to test the following API: /cdns/{{CDN Name}}/configs/monitoring, /cdns/{{CDN Name}}/snapshot/new, /deliveryservices/{{ID}}/safe, /servers/{{ID}}/deliveryservices, /snapshot, /users/{{ID}}/deliveryservice

It looks like I accidentally removed regional from the docs when I rebased them after it was added, so I'll fix that and the migration timestamps. Other than that:

4. Could create DS and DSR with longDesc1 and longDesc2 in the JSON payload with all 3 API versions. Per the description in the PR, I shouldn't be able to do so.

I think maybe I should clarify. You should be able to create a DS and DSR with any extra fields specified that you want. You could set "foo": "bar" and it shouldn't break anything. But it just shouldn't be stored. The same thing should happen with longDesc1 and longDesc2 in APIv5. Requests containing those should succeed, but no matter what you set them to, they should be null when you GET it in APIv3. Also, because DSRs are always stored at the latest API version, you should be able to create a DSR that sets a DS's longDesc1/longDesc2 to anything you want, but even if you do that in APIv3 it should be null when you GET it afterward.
Also, the legacy structures for DSes use the omitempty directive in the json portion of their struct tags for those fields, so when longDesc1/longDesc2 is/are NULL in the database, it/they are omitted from the response, so in that case it looks the same as if I had removed them from that version too (but I didn't I swear). Basically those will always be missing from DSRs in APIv3 but that's the same as if you used that version to set them explicitly to null before these changes.
That said, it looks like DSRs are always showing APIv5 representations in responses to POST requests on this branch - which doesn't fail tests because I guess the APIv3 client doesn't decode/return the response to those requests. Which I can't add because it'd be a breaking change, so I'll just need to fix and test manually, since a test for that can't really be written easily.

5. [Routing Name can be changed to default #7094](https://github.com/apache/trafficcontrol/issues/7094) didn't seem like it was fixed. I am able to change the routingName even when the value is set to cdn

That issue doesn't really exist. I think when I checked for it on master I forgot to generate SSL Keys for the delivery service first. I'll close that.

11. `/users/{{ID}}/deliveryservices` cannot curl this API with any versions

This endpoint existed in API versions 1 and 2, which existed when that blueprint was written but no longer do. So it's fine to be unreachable, since it would've been before anyway.

Today, if I give longDesc1 and longDesc2 in 4.0 this is the error I see:
curl -k -X POST -H "Content-Type: application/json" --cookie "mojolicious=eyJhdXRoX2RhdGEiOiJhZG1pbiIsImV4cGlyZXMiOjE2Njc1OTc4MjIsImJ5IjoidHJhZmZpY2NvbnRyb2wtZ28tdG9jb29raWUifQ--f85d59e0865cbcf9bac01d3fc42b5e12e7c8f8bf" --data @ds_v4.json "https://localhost:8443/api/4.0/deliveryservices" {"alerts":[{"text":"the longDesc1 and longDesc2 fields are no longer supported in API 4.0 onwards","level":"error"
So, why is the same strategy not followed for 4.0 and 5.0 in this PR?

All comments have been resolved.

LGTM, ready for a merge.

Done.


Add Algorithmia; closes #438

Signed-off-by: Dan Kohn<EMAIL_ADDRESS>@gagejustins  I modified to use an SVG version of your logo (the PNG you did doesn't look right). I also changed the link to be to your serverless page.
Please LGTM and I'll merge.

Deploy preview for landscape failed.
Built with commit fdee154c6ff6f040e25f78cd23b358b712305e23
https://app.netlify.com/sites/landscape/deploys/5ab180caa6188f324ec3163d

LGTM! Thanks a ton Dan


[doc] org-cards

Isn't docs/assets/hub/org-card.png too large? (1.6MB)

Oops yeah you're probably right. I shouldn't have rushed... 🙈

sorry i rushed this and merged, still interested in a quick review though

Thanks for adding this! Two suggestions:

Would it be better if we showed an image of a more complete org card - like Amazon's - to showcase what you can do in the org card (i.e., have links to a video, blog, and docs)?
I think maybe we should also mention that you need to know some HTML to style the org card so users know what to expect ahead of time.

Otherwise, it looks great! I love the button on the top right of the org card that links to the docs 👍

my hunch is that most users are just going to write some markdown text and not really bother with complicated HTML, wdyt @osanseviero? (that's why I added a simpler example as the first example)
But yeah you're right we can add a sentence or paragraph about being able to write HTML inside the .md file, do you want to open a PR?

(Note that Amazon's card does not really play the video, it just redirects to YT.)
re: used image. I think as-is is fine. Note we link to the more complex org cards right below, so it's up to the users if they want to investigate more complex org cards.
I agree some additional info on writing HTML would be useful!


Test result format

How and where should the results from the tests be defined?

Where should it pretty print? Inside the test-container or in the js?
What's the output format?

Design goals:

Easy to understand the output without any other framework, as raw output from the test itself (i.e. docker run ..)
Easy for someone to read the test to browse through the different test results to understand what the test does.
Easy to convert to human-understandable language including localisations.

Format for the codes: Maybe easier to just have a string constant instead. "OK": {... }, "DNSSEC_ERROR": {...} ?

We should try to implement these and see how it feels. Probably the rest of the details will reveal themselves when we write the messages.

Oops 😅
A problem with markdown strings is that, as in the example above, we not only need basic formatting but also loops. A table of DNS-servers and their response/status is going to be tricky and would require some sort of string interpolation.
Last night I thought about using JSX for constructing the responses, pseudo example:
<Result score="pass">
  {t('https.sv.title)}
  <Description>

{...}

  </Description>
</Result>

Not too complicated. WDYT?

(It was just a joke about how regular text is valid markdown ;)
Maybe if we allow the tests to return a template with strings that we then replace with the text? Perhaps that what your meant with interpolation.

(Damnit :D)
So we agreed on passing a finished markdown strings from the test. I'll have an example of that in #19.
What the docker container should return we don't need to specify, since this is passed from the worker.
I'll keep it simple and skip groupings for now.


Django 3.2 support

With Django 3.2 being out for a few months, support for it would be nice.
I have updated the necessary pieces to support it, and run the tests (minus the tests for Python3.4, I am going to spin up a VM this weekend to run those tests). I would be glad to create a pull request once I have run the 3.4 tests.

@stephenlutes Great! Very welcome.

I was unable to get a working test environment set up for Python 3.4, but everything from 3.5 on passes the tests. I created the pull request, #8. Given that Python 3. 4 has reached end of life, is support for it still needed?

I was unable to get a working test environment set up for Python 3.4, but everything from 3.5 on passes the tests. I created the pull request, #8. Given that Python 3. 4 has reached end of life, is support for it still needed?

No. We can skip python 3.4.

Then pull request #8 successfully adds support for Django 3.2 and Python 3.9.

I released version 1.2 now, which includes support for Django 3.2.
Thank you for your help


What's the --code-base option used for

Hi,
I've been wondering what the --code-base option in the pipenv install command does. Does it mean to install a project that is local on that machine?
Sorry if this is documented, I wasn't able to find it in my searching.
Thanks.

As the documentation indicates, if --code is turned on, pipenv will discover dependencies from import statements in the codebase.
Feel free to send a PR to improve the hint.

Great, Thanks @frostming.
Yeah, I did read that part of the documentation but I didn't quite put that together. My guess of what it might be used for was quite far off :) Maybe just because I've not come across other package managers with that feature before.
Would something like "auto-detect and install packages found in the code base's import statements" read OK? Unless that's is too clumsy of a sentence.

Closed via #3532


Fix code scanning alert #5: Unsigned difference expression compared to zero

Fixes https://github.com/apache/tsfile/security/code-scanning/5
Suggested fixes powered by Copilot Autofix. Review carefully before merging.

Codecov Report
Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.67%. Comparing base (1686cff) to head (f9ff4d8).

Files with missing lines
Patch %
Lines

cpp/src/reader/bloom_filter.cc
0.00%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #249   +/-   ##
========================================
  Coverage    61.67%   61.67%
========================================
  Files          491      491
  Lines        32248    32248
  Branches      4226     4226
========================================
  Hits         19889    19889
  Misses       11912    11912
  Partials       447      447

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


(Feature) automatically define compiler optimization flag from related sumodule

Closes #1124

Pull Request Test Coverage Report for Build 3045

0 of 25 (0.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.1%) to 19.801%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/components/stepFour/utils.js
0
25
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/components/stepFour/utils.js
1
0.0%

Totals

Change from base Build 3043:
-0.1%

Covered Lines:
884

Relevant Lines:
3827

💛  - Coveralls

Black Duck Security Report
Merging #1128 into 2.0 will not change security risk.
Added Components
Clean:       10
Click here to see full report


Refactor for NIST distribution: cloudmesh-analytics

Gregor will soon create a new repo called
cloudmesh-analytics
Once your code has proven to work and you have created more functionality the code will be moved there.

I created the directory and moved the code there.
We need to make sure the structure fits to the NIST code. Essentially what i did is move the project code in this directory. However your previous code did not have a command to start and stop the servers so i added this. This may have some impact on the packageing of the code. I also added a setup template.

next please develop the
cms analyticts server start / stop methods
Make sure that you ster the server in the right directory otherwise it will not work.
Also we may have to move the analytics.py into
cloudmesh/analytics/init.py
to avoid a name clash with the command template

The cloudmesh-analytics looks like a cloudmesh bundle. I am wondering if I have developed the commands for cloudmesh-analytics, how the 'cms' command find the command of the analytics so  I can use the command like 'cms analytics'.  It seems like the commands of analytics should be bound to the cms in some way.

hundrest of lines do this automatically for you.
all you hae to do is go to the dir and do pip intsall -e .  (the dot is important)
once we have it developed i will upload it tp pypi and it will be installed from there.
as developer you naturally need pip install -e .

I successfully made it. Yanting Wan is working on setting cloud instance. I will go ahead to develop the commands. Thanks.


[Jenkins Backend Plugin] EntityJobRunsTable not working

Plugin Name
jenkins-plugin-backend
📜 Description
The EntityJobRunsTable seems to not work anymore, as the this route:
/v1/entity/:namespace/:kind/:name/job/:jobFullName
is receiving "undefined" as jobFullName. The result is that the list of builds is empty.
👍 Expected behavior
List all builds for a project
👎 Actual Behavior with Screenshots
An empty list is shown

👟 Reproduction steps
Just use the plugin with the EntityJobRunsTable widget.
📃 Provide the context for the Bug.
This parameter is always passed as undefined

A workaround can be achieved by setting the jobFullName from jenkinsInfo, but is indeed a workaround, as the /v1/entity/:namespace/:kind/:name/job/:jobFullName with jobFullName non-properly set is te culprit of this bug.
(Working) Workaround:

👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
No, but I'm happy to collaborate on a PR with someone else

Ok i figured out how to use the plugin correctly.... my bad
Anyway it would be nice to use the EntityJobRunsTable as a landing page


Trouble using HardwareSerial with ESP32 (not a bug, need advice)

Hi
I am trying to use the library in an APRS project. This is on ESP32 hardware hence libraries are implemented for ESP32 not std Arduino boards.
I am having a hardtime passing the HardwareSerial object to the FuGPS constructor, this is not working since it is not a stream although is derived from one.
Definitions;
`HardwareSerial gpsSerial(1);
FuGPS fuGPS(gpsSerial);
`
Some of the errors I've getting are
"C:\Users\T520\Documents\Arduino\libraries\FuGPS_Library\src\FuGPS.cpp: In member function 'void FuGPS::sendCommand(const char*)':
C:\Users\T520\Documents\Arduino\libraries\FuGPS_Library\src\FuGPS.cpp:57:28: error: passing 'const Stream' as 'this' argument discards qualifiers [-fpermissive]
 _stream.println(command);"

and
"C:\Users\T520\Documents\Arduino\libraries\FuGPS_Library\src\FuGPS.cpp: In member function 'bool FuGPS::read()':
C:\Users\T520\Documents\Arduino\libraries\FuGPS_Library\src\FuGPS.cpp:122:27: error: passing 'const Stream' as 'this' argument discards qualifiers [-fpermissive]
 if (_stream.available())"

This is not a bug (I assume), but I note that in the examples it is recommended to use HardwareSerial hence my motivation to keep trying.
From your source it seems you are expecting a Stream object to be passed in the constructor, how can I do this and use a HardwareSerial lib?

Hi.
But ESP32 is compatible with Arduino.
HardwareSerial implement Stream:
https://github.com/espressif/arduino-esp32/blob/master/cores/esp32/HardwareSerial.h

Hi @fu-hsi
There was some corruption in my Arduino installation, and after this was resolved the issue has gone away.


CoulombCounter not working

The CoulombCounter seems not to work, because the Read32bit-Function only reads 2 instead of 4 bytes:
uint32_t AXP192::Read32bit( uint8_t Addr )
{
	uint32_t ReData = 0;
	Wire1.beginTransmission(0x34);
	Wire1.write(Addr);
	Wire1.endTransmission();
	Wire1.requestFrom(0x34, 4);          //2 replaced by 4 --> works fine
	for( int i = 0 ; i < 4 ; i++ )
	{
		ReData <<= 8;
		ReData |= Wire1.read();
	}
	return ReData;
}

Thank you for your help, we have solved this problem, you can update the local library to try


Data Fetching on the Server

Thanks so much for this really interesting project!
I was wondering whether there is any way built into Iles that allows fetching data on the server at build time to be used in components? Similar to Nuxt's asyncData?

Hi Michael!
Currently there's no built-in way, but there are several ways to achieve it.
In îles you can use await in script setup or in getStaticPaths.
See:

https://github.com/ElMassimo/iles/discussions/46
https://github.com/ElMassimo/iles/discussions/41

I'll keep this open as a reminder to automatically inject $fetch with ohmyfetch if it's used.
In the meantime you could ponyfill fetch or use ohmyfetch directly.
If you need caching, check this example using a caching utility, which ensures the request is made only once across rendered pages. Something like this might be built-in in the future, as useFetch and useAsyncData.

This is all very helpful, thanks @ElMassimo !


Add a note about size of files in support-api

The disk comparison check between assets slave & master can fail if
large reports have been compiled against zendesk. This adds a note to
this effect.

Can files found in this way be deleted or do they back in use reports?

@deanwilson I have no idea. I think that they're only temporary but would need confirmation from someone who understands zendesk, and I don't know who that might be

@paulheron - any thoughts?

Those reports aren't for ZenDesk, they're reports of anonymous feedback in Feedback Explorer (the What were you doing?, What went wrong? boxes on all GOV.UK pages). We could put them in S3 under a short lifecycle policy as an alternative in the future.

The way it works is someone requests an export which is generated in the background. The job emails them when the report is ready and links to the generated CSV. We'd need to make a call on how long to retain them. Maybe a month? Once we've decided on that we could create a cron job to automate it, rather than documenting.

@boffbowsh Unless we set the cronjob to run very regularly and all files are stored on S3 it wont fix the underlying problem which is that a large generated csv (>1GB) will exceed the threshold for difference between master & slave disk usage.

Also a good point. In that case is it worth adding a note to just run an rsync manually to fix the problem?

Bump @SamLR

@tuzz  @boffbowsh I'm not sure re-running the sync job is really necessary, it's tricky and the data is (as far as I'm aware) all derived so it's not vital that it's kept. I guess it depends on how bad we think it is to recommend that people ack an alert?

Does anyone object to what's already been written being merged in? it can then be expanded upon as people get more time.

Bump @boffbowsh / @SamLR

@deanwilson fine by me


Remove support for nested objects/arrays in ng-class

189461f9bf6fda18ddbd16c42f2e959cf939c3da caused an issue with nested literal objects/arrays in ng-class (#15905), essentially because it allowed the expression inputs (a watch optimization) to be used properly in the case of literals with interceptorFns.
Instead of reverting 189461f9bf6fda18ddbd16c42f2e959cf939c3da, or changing ng-class to use deep watch, or declaring its interceptor as $stateful - I'd like to drop nested object/array support from ng-class. This will align ng-class with the Angular version, should improve performance, should simplify the ng-class code a bit.
This would be a breaking change in 1.7.
Any strong objections? Strong use cases for nested objects/arrays in ng-class?

Putting a side the specific way that this should be resolved, there are a few points that should be covered:

Even when nested arrays/objects are no longer supported, simple objects/arrays are supported

189461f9bf6fda18ddbd16c42f2e959cf939c3da caused
ng-class="[root.obj1, root.obj2]"
and
$scope.root.styles2 = [root.obj1, root.obj2];
ng-class="root.styles2"
to behave differently. This discrepancy must be avoided

Even if nested arrays/objects are not supported, then, if someone creates a stateless filter that expose the nested object/array as a single object then ng-class="[root.obj1, root.obj2] | mergeThings" must work (in some sense, this point at the previous one can be considered the same)

There should be a clear migration path, this may include the specific example from the bug and how this should be represented, e.g the non so obvious ng-class="{[CLASS_STYLE_1]: root.obj1[CLASS_STYLE_1], [CLASS_STYLE_2]: root.obj2[CLASS_STYLE_2]}"

Angular 1.6.4 may not be representative of what this issue is trying to accomplish, but changing the example in my initial comment from
ng-class="{'has-error': (testForm.testInput | showErrors)}"

to
ng-class="(testForm.testInput | showErrors) && 'has-error'"

http://plnkr.co/edit/1kWniq?p=preview
or to
ng-class="{'has-error': (testForm.testInput | showErrors) && true}"

http://plnkr.co/edit/4Qx1SN?p=preview
makes it work. I'm guessing these changes turn my object into a string/boolean expression and ng-class doesn't have to handle the nested object directly any more. Idk... Will these continue to work with the changes you are proposing?
This seems a little hacky and harder to read. It would be nice for this to continue working with the object syntax like it did before to keep my code consistent but I understand the importance of dropping this for performance and cleaning up the code. I feel like I'm still trying to get around these proposed nested object restrictions. My use case may not be widely used/needed.
Idk if you guys have any better suggestions. Maybe this is just a bad practice and I should be going about it a different way. Writing a directive to work for both showing/hiding a class and showing/hiding an error message didn't seem as nice as just using ng-class and ng-if with a filter. But I suppose writing a show-error-class directive and a show-error-message directive and passing the model in wouldn't be horrible. I think I'd end up with the same number of watches though...

@OzzieOrca I think all 3 of those examples should still be supported. But you're correct that the first one is broken in 1.6 because testInput is only shallow watched and it never changes, since it's an object it should pass it to the filter each digest even if it hasn't changed.

The main issue that prompted this (#15905) has been fixed by b5118ac6a9e0a327b31094b3fdcdc0432b23ad2f + b12a0b7652f4161375fd9a535d2832dd1f09817a in v1.6.x and master.
I still think this would cleanup ng-class, make it more like Angular(2+) etc. but I don't think it will happen just for those reasons. Closing this...


Previous work has diapered Pro 50 sub scriber

Describe the bug
All of my previous work in the chat history has dissapeared, this has taken considerable time and tokens to build.
Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-6bsqif
Steps to reproduce
Go to your chat.
There is no previous chat from my latest project
Expected behavior
chat history with my project is available to click
Screen Recording / Screenshot
No response
Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 129
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 50534078,
  "usedJSHeapSize": 49094438,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = johnthreedie
Chat ID = 26a77fc93162

Additional context
No response

@johnthreedie your work should be stored here: StackBlitz.com > Collections tab > Bolt Collection. If not, please email<EMAIL_ADDRESS>as this would be a serious bug that we would work with you to look into ASAP!
If your projects ARE there, then you can reference #39 for more info on Chat Persistence in general, and coming improvements.

Thank you, This resolved the issue.


Build Failed TypeError: Cannot set properties of undefined (setting '__definition')

info  - Need to disable some ESLint rules? Learn more here: https://nextjs.org/docs/basic-features/eslint#disabling-rules
✓ Linting and checking validity of types
✓ Collecting page data
Generating static pages (0/15)  [    ] ⚠ Entire page /404 deopted into client-side rendering. https://nextjs.org/docs/messages/deopted-into-client-rendering /404
⚠ Entire page /account/profile deopted into client-side rendering. https://nextjs.org/docs/messages/deopted-into-client-rendering /account/profile
⚠ Entire page /account/login deopted into client-side rendering. https://nextjs.org/docs/messages/deopted-into-client-rendering /account/login
⚠ Entire page /account deopted into client-side rendering. https://nextjs.org/docs/messages/deopted-into-client-rendering /account
⚠ Entire page /account/addresses deopted into client-side rendering. https://nextjs.org/docs/messages/deopted-into-client-rendering /account/addresses
⚠ Entire page /account/orders deopted into client-side rendering. https://nextjs.org/docs/messages/deopted-into-client-rendering /account/orders
⚠ Entire page /checkout deopted into client-side rendering. https://nextjs.org/docs/messages/deopted-into-client-rendering /checkout
Generating static pages (7/15)  [=   ]
⚠ Entire page /store deopted into client-side rendering. https://nextjs.org/docs/messages/deopted-into-client-rendering /store
Could not resolve module: ProductModuleService. Error: Loaders for module ProductModuleService failed: No database clientUrl provided. Please provide the clientUrl through the [MODULE]_POSTGRES_URL, MEDUSA_POSTGRES_URL or POSTGRES_URL environment variable or the options object in the initialize function.
Error occurred prerendering page "/api/categories". Read more: https://nextjs.org/docs/messages/prerender-error
TypeError: Cannot set properties of undefined (setting '_definition')
at MedusaModule.bootstrap (/Users/nio/lifease/trash/capilus/capilus/node_modules/.pnpm/@medusajs+modules-sdk@1.12.1_graphql@16.8.1/node_modules/@medusajs/modules-sdk/dist/medusa-module.js:124:44)
at async initialize (/Users/nio/lifease/trash/capilus/capilus/node_modules/.pnpm/@medusajs+product@0.2.1_graphql@16.8.1_pg@8.11.0/node_modules/@medusajs/product/dist/initialize/index.js:8:20)
at async GET (/Users/nio/lifease/trash/capilus/capilus/.next/server/app/api/categories/route.js:1:833)
at async /Users/nio/lifease/trash/capilus/capilus/node_modules/.pnpm/next@13.5.6@babel+core@7.23.2_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/compiled/next-server/app-route.runtime.prod.js:14:39709
⚠ Entire page /cart deopted into client-side rendering. https://nextjs.org/docs/messages/deopted-into-client-rendering /cart
Could not resolve module: ProductModuleService. Error: Loaders for module ProductModuleService failed: No database clientUrl provided. Please provide the clientUrl through the [MODULE]_POSTGRES_URL, MEDUSA_POSTGRES_URL or POSTGRES_URL environment variable or the options object in the initialize function.
Error occurred prerendering page "/api/collections". Read more: https://nextjs.org/docs/messages/prerender-error
TypeError: Cannot set properties of undefined (setting '_definition')
at MedusaModule.bootstrap (/Users/nio/lifease/trash/capilus/capilus/node_modules/.pnpm/@medusajs+modules-sdk@1.12.1_graphql@16.8.1/node_modules/@medusajs/modules-sdk/dist/medusa-module.js:124:44)
at async initialize (/Users/nio/lifease/trash/capilus/capilus/node_modules/.pnpm/@medusajs+product@0.2.1_graphql@16.8.1_pg@8.11.0/node_modules/@medusajs/product/dist/initialize/index.js:8:20)
at async GET (/Users/nio/lifease/trash/capilus/capilus/.next/server/app/api/collections/route.js:1:833)
at async /Users/nio/lifease/trash/capilus/capilus/node_modules/.pnpm/next@13.5.6@babel+core@7.23.2_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/compiled/next-server/app-route.runtime.prod.js:14:39709
✓ Generating static pages (15/15)

thanks it worked


Use millisecond as the unit of timeout

Fixing https://github.com/databricks/databricks-sql-go/issues/7
In the current implementation, the timeout parameter is converted using strconv.Atoi that can only parse max value of int32, while the unit is nanosec, which means the biggest timeout can only be ~2 seconds.
This PR changes the timeout unit to be millisecond and updates the README accordingly.

Thanks!


_execute api for mcorr POC

Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #843 (47fd933) into main (970517e) will decrease coverage by 3.96%.
The diff coverage is 5.40%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##               main     #843      +/-   ##
============================================
- Coverage     84.80%   80.85%   -3.96%
  Complexity     1632     1632
============================================
  Files           135      138       +3
  Lines          6082     6392     +310
  Branches        596      636      +40
============================================
+ Hits           5158     5168      +10
- Misses          666      961     +295
- Partials        258      263       +5

Flag
Coverage Δ

ml-commons
80.85% <5.40%> (-3.96%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


How to specify the path of kernel

Hi All,
I have installed Mathematica in Windows and wolframclient is installed in WSL, Windows Subsystem for Linux.
When I run WolframLanguage Session, the interpreter isn't able to locate the kernel path.
    "Cannot locate a kernel automatically. Please provide an explicit kernel path."
wolframclient.exception.WolframKernelException: Cannot locate a kernel automatically. Please provide an explicit kernel path.

The documentation available here shows how to set the path.
For instance, on linux
 session = WolframLanguageSession('/usr/local/Wolfram/Desktop/11.3/Executables/WolframKernel')
Since I haven't installed Mathematica in WSL, I am not sure how to specify the path.
Any suggestions will be really helpful

This is a kind reminder

I don't think this question deserve a GitHub ticket. It's rather a question for Mathematica StackExchange, possibly a WSL question.


Use of interface{} instead of a struct that's already defined

// transform interface to ChatCompletionRequest
func (rb *RequestBuilder) SetBodyFromStruct(data interface{}) *RequestBuilder {
	body, err := json.Marshal(data)
	if err != nil {
		panic(fmt.Sprintf("failed to marshal body: %v", err)) // Using panic for debugging; replace in future with proper error handling.
	}
	rb.body = body
	return rb
}

Stupid me referenced this issue instead of #4 please don't mind my comments.

Both CreateChatCompletionStream and ChatCompletionStream use the common SetBodyFromStruct function. Since both types are checked previously with their respect request builders and then are only passed to this function, we can not worry about it for now.
Might need to come back to this in the future if needed!


Guava still presents in project. Please use scope=test for tests but not compile.

This is the list of pom.xml which directly specify guava dependency.
dropwizard-util
dropwizard-jackson
dropwizard-lifecycle
dropwizard-jdbi3
dropwizard-bom
This is the list of modules where Java sources use guava transitively from modules in the previous list.
dropwizard-jdbi
dropwizard-jersey
dropwizard-validation
What happens if we use dropwizard-testing as a dependency in our project POM and we exclude the guava dependency from it? The dropwizard still needs to have guava on classpath?

closing as following the discussion on google discussion.


Removing embedded clock attribute from logical termination point

Inside logical-termination-point , we have a list of clock (it is getting instantiated and not referred to any other instance)
list embedded-clock {
      key "local-id";
      uses clock;
      description
        "none";
    }

On 5G-xhaul call 15th of December 2021, we discussed to change the type of the “embedded-clock” attribute to a leafref pointing to the clock-collection in sync-model as below.
leaf-list embedded-clock {
      type leafref {
        path “/core-model:control-construct/sync-model:clock-collection/sync-model:clock/core-model:local-id";
        require-instance false;
      }
      description
        "none";
    }

But , the reference to a technology specific module from core-model requires an import of that referred model.Also this will cause a circular dependency.
So we came up with the following plan,

Pruning “embedded-clock” attribute from “logical-termination-point” in “core-model”
Including the attribute “embedded-clock” to the “sync-model” and augmenting that attribute to the “logical-termination-point” in “core-model”
This “embedded-clock” attribute in sync-model will refer to the path “/core-model:control-construct/sync-model:clock-collection/sync-model:clock/core-model:local-id"

After removing the attribute “embedded-clock” from logical-termination-point , its impacting the referred path of the following attributes, (in the “grouping clock”)

encompassed-clock
phase-aligned-clock

Earlier the path of these attributes referred to the "embedded-clock" in LTP.
But after pruning the "embedded-clock" , these attributes refer to the path “/core-model:clock/core-model:local-id".
We have to further discuss to handle this situation.

Note : In core-model , clock is not used elsewhere apart from embedded-clock.

2 Options

remove both attributes
remove both attributes from CoreModel and add back by SyncModel using leaf-ref to “/core-model:control-construct/sync-model:clock-collection/sync-model:clock/core-model:local-id"

AI offline with Alex from TEF about the usage of such attributes - Parthiba, Alex, Martin

Based on the offline discussion with Alexander , Martin and Alex , proposing the following change to core-model-1-4.

embedded-clock attribute from logical-termination-point will be removed from core-model. This attribute will be included to sync-model and augmented to the /core-model:control-construct/core-model:logical-termination-point. Please refer issue#7 in sync-model for further implementation details.
encompassed-clock , phase-aligned-clock attributes in "grouping clock" will be removed from core-model. These attributes will be included to sync-model and augmented to the /core-model:control-construct/sync-model:clock-collection/sync-model:clock . Please refer issue#8 in sync-model for further implementation details.

Informal decision made during the 5G-xhaul call on 26th of January 2022:
The following changes are dealt with as bug-fixes:

embedded-clock attribute in logical-termination-point will be removed from core-model. Then, this attribute will be included to sync-model yang model and gets augmented to the /core-model:control-construct/core-model:logical-termination-point. Please refer issue#7 in sync-model for further implementation details.
encompassed-clock , phase-aligned-clock attributes in "grouping clock" will be removed from core-model. These attributes will be then included to sync-model yang model and gets augmented to the /core-model:control-construct/sync-model:clock-collection/sync-model:clock . Please refer issue#8 in sync-model for further implementation details.

These changes will be provided in the next YANG and group members are asked to comment on the published YANG.


Improvement Update Parser for IPv4/v6 data types

Proposed changes

Transforming from parsing std:: string to parsing char * to accelerate the parsing of ipv4/v6 data types.


How to run a specific Defects4J bug?

How can I set cerberus to run on a specific Defects4J bug?
If I set the --bug-id option to Chart-1, Chart1 or even Chart/1 it does not find any bug with that identifier.
On the other hand, if I set --bug-id to 1, it runs on all bugs with bid==1 (i.e., Chart-1, Cli-1, Csv-1, etc)
cerberus repair --tool=sequencer --benchmark=defects4j --bug-id Chart-1 # does not find any bug
cerberus repair --tool=sequencer --benchmark=defects4j --bug-id 1 # runs on all bugs with bid==1

Hi, this is a fault on the side of the metadata provided. You are using the command correctly

Hi @andre15silva,
thanks for reporting the issue, it seems there are two bugs
one in the meta-data of the benchmark configuration and the other in Cerberus filtering mechanism
@Marti2203 is it possible to update the meta-data or do we need to handle it in the driver?

It is possible to update the meta-data fle.

Hi, just updated the benchmark repo we use and dev is fixed


[BUG] Category Cards Mouse Drag Not Working

Description
One cannot Use Mouse to drag category cards carousel
Screenshots
No response
Any additional information?
No response
What browser are you seeing the problem on?
No response
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I have read the discussion tab thoroughly and got the project idea
[X] I am willing to work on this issue (optional)
[X] I am a GSSoC'23 contributor

@rohansx Please assign this issue to me under GSSoC 23

@rohansx have created a PR #371 Please review it


⚠ Bofrost.es has degraded performance

In dbecafe, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1528 ms

Resolved: Bofrost.es performance has improved in 1fa1522 after 6 minutes.


fix(esl-utils): utility DeviceDetector updated to recognize iOS13

:tada: This PR is included in version 3.0.0-beta.2 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


7.0.0 update has new UI style

you need to spend quite a time for sure for this new UI Update along with Dispatch Mission

Dispatch Mission will be added later. Fixing current UI elements is a goal for now. It's just a tedious work because some elements just have changed position for no reason at all (thx NetMarble).

First iteration done in https://github.com/tmarenko/mff_auto/commit/ad29c5a71f33db799d2e4e5bb5b7137ec73d1195
Still have 47 UI elements that has rare occurrence and need to test.

Thank you for making changes so quickly.

So far the main issue I've seen is that the actual scanning of skill buttons doesn't seem to be happening.
For instance, it will go into legendary battles as it should, but then your character will sit there and do nothing. The logs won't show it picking up the skills, and therefore never moves to pressing them.
If you queue all 5 stages for example, if you manually press the skills to win the battle, it WILL however move onto the next stage correctly though.
The second thing I've found is that even with full energy and 100 boost, when you attempt a giant boss raid, it will get to the main screen where it shows the rewards and allows you to enter, but will then throw up "INFO - No more stages for Giant Boss Raid."

So far the main issue I've seen is that the actual scanning of skill buttons doesn't seem to be happening.
For instance, it will go into legendary battles as it should, but then your character will sit there and do nothing. The logs won't show it picking up the skills, and therefore never moves to pressing them.
If you queue all 5 stages for example, if you manually press the skills to win the battle, it WILL however move onto the next stage correctly though.
The second thing I've found is that even with full energy and 100 boost, when you attempt a giant boss raid, it will get to the main screen where it shows the rewards and allows you to enter, but will then throw up "INFO - No more stages for Giant Boss Raid."

What's your emulator screen resolution and in-game graphics setting?

Emulator is 1920x1080 and HIGH as well. I haven't changed anything since it was working prior to the new patches (for the game and the bot obviously). I can attempt a reinstall, as this is with an update via the updater.

Try to found settings\ui\battle.json file and open it with any text editor.
Find records for SKILL_1_LABEL, SKILL_2_LABEL ... SKILL_6_LABEL and try to change image_threshold parameter for them. For example if image_threshold value is 150 then try to set 140 or 160, 130 and 170, etc..
Then restart bot and try to play a battle.
For GBR that would be GBR_MENU_LABEL and GBR_QUICK_START in settings\ui\giant_boss_raid.json file.
If some image_threshold values worked for you let me know.

Odd. I'll try some now, but SKILL_6 is the only one showing anything close to that, 170. Whereas the rest are sitting at 0.7.

SKILL_6_LABEL not SKILL_6
Here:
https://github.com/tmarenko/mff_auto/blob/master/settings/ui/battle.json#L565-L643
https://github.com/tmarenko/mff_auto/blob/master/settings/ui/battle.json#L328-L342

Sorry, should have said SKILL_6_LABEL. That was what I was referring to.

I haven't found a threshold that works as of yet - I'll try some more tomorrow.

Try to create tesseract folder inside logs folder. Bot will write images of UI elements into this folder.
That will help to understand what bot sees from the screen:

Another way around is to run this script:
import lib.logger as logging
from lib.video_capture import NoxCapture
from lib.players.nox_player import NoxWindow
from lib.game.missions.legendary_battle import LegendaryBattle
from lib.game.missions.giant_boss_raid import GiantBossRaid
from lib.game.game import Game

logger = logging.get_logger(__name__)
logging.create_file_handler()

if __name__ == '__main__':

    nox = NoxWindow("NoxPlayer")
    with NoxCapture(nox) as nox_capture:
        try:
            game = Game(nox)
            LegendaryBattle(game).do_missions()
            GiantBossRaid(game).do_missions(times=1, max_rewards=True)
        except KeyboardInterrupt as err:
            exit()

That script will run Legendary Battle and then GBR and the script will capture video into .mp4 file in logs folder (similar to https://youtu.be/QcgZcAwBL-I )

World Boss Invasion Issue
=> Stuck at battle over, f.y.i chest receive notification is closed by bot
2021-04-23 21:26:20,182 - battle_bot - INFO - Battle is over 2021-04-23 21:26:22,782 - world_boss_invasion - DEBUG - Any chest after boss fight wasn't acquired.
Alliance Battle
=> can't start it
2021-04-23 21:24:37,563 - game - DEBUG - Stage: TIMELINE BATTLE; stages: 10/10 2021-04-23 21:24:48,113 - alliance_battles - WARNING - Alliance Battles: can't get in battles lobby. 2021-04-23 21:24:50,225 - missions - DEBUG - After mission notifications was closed: False 202
Also LB is working fine for me
2021-04-23 21:32:00,824 - battle_bot - DEBUG - Casting 3 skill. 2021-04-23 21:32:01,579 - battle_bot - DEBUG - Successfully casted 3 skill. 2021-04-23 21:32:02,927 - battle_bot - DEBUG - Casting 2 skill. 2021-04-23 21:32:04,570 - battle_bot - DEBUG - Successfully casted 2 skill. 2021-04-23 21:32:07,839 - battle_bot - INFO - Battle is over 2021-04-23 21:32:07,840 - missions - DEBUG - Clicking REPEAT button with UI Element: LB_REPEAT_BUTTON. 2021-04-23 21:32:09,660 - missions - DEBUG - After mission notifications was closed: False

Just to be sure, can you check if all .json files in settings/ui have same content as in https://github.com/tmarenko/mff_auto/tree/master/settings/ui
It's very odd because WBI and AB are working fine for me and have stable UI recognition.
Maybe updater failed to change these files, I'm not sure.
If files are the same then:
For Alliance Battle try to change image_threshold for AB_NORMAL_READY_BUTTON to 150 or 120.
For World Boss Invastion try to change image_threshold for INVASION_HOME_BUTTON to 0.5 or even 0.4 .

Ok, it doesn't even seem to scan the skill labels yet. They're not appearing at all in the tesseract log. I'll have a search through in terms of the GBR to see where it's failing.

Ok so here is another script for you:
import lib.logger as logging
from lib.players.nox_player import NoxWindow
from lib.game.game import Game

logger = logging.get_logger(__name__)
logging.create_file_handler()

if __name__ == '__main__':

    nox = NoxWindow("NoxPlayer")
    game = Game(nox)
    from PIL import Image, ImageDraw
    image = nox.get_screen_image()
    image = Image.fromarray(image)
    draw = ImageDraw.Draw(image)
    for skill_index in range(1, 7):
        rect = game.ui[f'SKILL_{skill_index}_LABEL'].rect
        box = (rect.global_rect[0] * nox.width, rect.global_rect[1] * nox.height,
               rect.global_rect[2] * nox.width, rect.global_rect[3] * nox.height)
        draw.rectangle(xy=box, outline="#00ff00", width=4)
        print(f"Value from SKILL {skill_index}: {nox.get_screen_text(game.ui[f'SKILL_{skill_index}_LABEL'])}")
    rect = game.ui['MELEE_BUTTON'].button
    box = (rect.global_rect[0] * nox.width, rect.global_rect[1] * nox.height,
           rect.global_rect[2] * nox.width, rect.global_rect[3] * nox.height)
    draw.rectangle(xy=box, outline="#00ff00", width=4)
    for tr in range(1, 11):
        threshold = tr / 10.0
        game.ui['MELEE_BUTTON'].threshold = threshold
        print(f"Melee button is on screen: {nox.is_image_on_screen(game.ui['MELEE_BUTTON'])} "
              f"with threshold={threshold}")
    image.show()

Open any battle with your character (skill preview f.e.) and run it.
You should see screenshot similar to this:

and log file should containt some info like this:
Value from SKILL 1: 1
Value from SKILL 2: 2
Value from SKILL 3: 3
Value from SKILL 4: 4
Value from SKILL 5: 5
Value from SKILL 6: 6
Melee button is on screen: True with threshold=0.1
Melee button is on screen: True with threshold=0.2
Melee button is on screen: True with threshold=0.3
Melee button is on screen: True with threshold=0.4
Melee button is on screen: True with threshold=0.5
Melee button is on screen: True with threshold=0.6
Melee button is on screen: True with threshold=0.7
Melee button is on screen: True with threshold=0.8
Melee button is on screen: True with threshold=0.9
Melee button is on screen: False with threshold=1.0

Didn't log, but I added a pause to check it.
Value from SKILL 1: 1
Value from SKILL 2: 2
Value from SKILL 3: 3
Value from SKILL 4: 4
Value from SKILL 5: 5
Value from SKILL 6: 6
Melee button is on screen: True with threshold=0.1
Melee button is on screen: True with threshold=0.2
Melee button is on screen: True with threshold=0.3
Melee button is on screen: True with threshold=0.4
Melee button is on screen: True with threshold=0.5
Melee button is on screen: True with threshold=0.6
Melee button is on screen: True with threshold=0.7
Melee button is on screen: False with threshold=0.8
Melee button is on screen: False with threshold=0.9
Melee button is on screen: False with threshold=1.0

Melee button is on screen: True with threshold=0.7
Melee button is on screen: False with threshold=0.8
Melee button is on screen: False with threshold=0.9

Doesn't look like 1080p to me. But it's not a big deal, I'll change threshold for 0.7

Second iteration done in https://github.com/tmarenko/mff_auto/commit/1a1f174f8e80a7f7b6466e0731819cc94f20e41d
Still had 28 UI elements to test (some of them should appear weekly or may be even were removed).
Threshold values should be more flexible now for low resolution.

I've always had mine nox set on mobile phone - and it was fine previously.
I've updated it to tablet, which obviously changes the two h and w figures around for proper FHD.
Would there have been changes to anything that stopped it working on mobile phone mode vs tablet mode in between the updates?

I've always had mine nox set on mobile phone - and it was fine previously.
I've updated it to tablet, which obviously changes the two h and w figures around for proper FHD.

Would there have been changes to anything that stopped it working on mobile phone mode vs tablet mode in between the updates?

Sorry, I'm not sure if I understood correctly. Are you talking about this settings?

Are you saying that bot was working fine in mobile phone mode? And now it only works in tablet mode?

Yes, that exactly.
I am getting some errors, but I was able to successfully run alliance battles, and danger room. GBR seems to work as well.

I've tried this mobile phone mode and saw no difference (yeah H and W are swapped but when you run MFF app emulator changes orientation to 1920x1080 so it works basically the same).
I believe tablet mode is a default mode when you install NoxPlayer, any reason why you changed to mobile mode?

I've had it as mobile phone mode mainly because of a previous bot, but also because it took up less screen space really.

Well, I'm not really sure but I didn't notice any difference between mobile and tablet modes.

it took up less screen space really.

Usually I'm making NoxPlayer fullscreen and doing Alt+Tab into another window/application. Bot doesn't need to NoxPlayer be actually on screen in order to get image/send clicks. As long as NoxPlayer is not fully minimazed bot can "see" trough other windows.
Making NoxPlayer's actual window lesser size results into similar problems when you set up less then 720p resolution.

I have started doing that, and it does seem to help.
One message I have seen the bot recently get stuck on is when you have the maximum number of items (say crystals), but you're still farming for something else in that mission. The bot currently doesn't pick up the error message for that, so it gets stuck. I'll get a picture for you tomorrow.

I'll get a picture for you tomorrow.

Fullscreen screnshot of game with this notification would help, thank you. ITEM_MAX_LIMIT_NOTIFICATION is still in "untested" category because I've never encountered it after 7.0.0 update yet.

Added in https://github.com/tmarenko/mff_auto/commit/c2c7aa2e39e7b6fa89567a49d336afe9b652ee28

UI elements that still haven't been tested:
KICKED_FROM_THE_SYSTEM - rare notification in World Boss Invasion, couldn't get it.
INVASION_FAILED - end of battle situation when you fail in World Boss Invasion. Almost impossible to get because gamemode is so easy nowadays.
RANK_UP_NOTIFICATION_1 - ranking character notification at the end of the mission. Looks like game isn't showing it anymore, at least not in usual mission (got similar in Story mode).
INVENTORY_FULL - should be same.
GBR_FAILURE_DAMAGE_LIST - same situation as with INVASION_FAILED
MAIN_MENU_AD_3 - probably was removed.
MAINTENANCE_NOTICE - need to wait for the next game's update.
BIOMETRICS_NOTIFICATION - no plans for paying again for this.
X_GENE_NOTIFICATION - same.
TL_LEAGUE_NOTIFICATION - probably was removed.
WB_CLOSE_OFFER_AD - probably was removed.
WB_CLOSE_OFFER_AD_OK - probably was removed.
Overall, migration to 7.0.0 UI is done.


contract settlement tests

after a contract has entered settlement and a settlement price has been queried, users should be able to call MarketCollateralPool.closeAndSettle()  which should close out any remaining open positions and return any remaining collateral to their accounts.
A call to MarketCollateralPool.closeAndSettle()  prior to expiration should fail, and have no affect.

tests should include

attempting to trade post settlement should fail
cancelling an order post settlement should fail
contract creator should be able to reclaim any ether balance remaining in contract that was provided to fund gas costs of queries
MarketCollateralPool.closeAndSettle() should resolve all open posisions correclty allowing caller to withdraw correct amount of collateral based on remaining open position at settlement time and the settlement price

tricky part will be to deploy a contract, have trades occur so users have open positions and then have it enter into settlement to allow these tests to be ran correctly.

Hey @pelsasser, I'd love to take a look at this.

@TheLucasMoore great - thanks for the interest in the project!

I've got the test suite running locally and am working on covering all those points 🤓 👍

@TheLucasMoore Do you currently have some work done, perhaps you can push that, so someone else can continue from where you stopped or else I'll take a look at this later in the day.

Hi @perfectmak , perhaps you could also have a look at https://github.com/MarketProject/MarketProtocol/issues/15 ?
I cannot get the coverage to work for some reason. Is it working for you?
Only with the coverage enabled it makes sense to develop/design more test cases.

@perfectmak Nothing to push besides the initial test of settleAndClose() failing unless MKT_CONTRACT.isSettled(); Go ahead and work on it and I'd be interested in helping you out if you need some more eyes on something.

@TheLucasMoore could you claim the issue on https://gitcoin.co/funding/details?url=https://github.com/MarketProject/MarketProtocol/issues/9 ? i just dont want others to improperly assume this issue is open :P

@TheLucasMoore hows it going?  no pressure; just checking in

@perfectmak are you still interested in this?  please comment and let @pelsasser know what your implementation plan is


[system] Support for prefers-color-scheme with no flashes

Is there a way to support prefers-color-scheme in the future? I guess, it would be possible for every project to make a custom implementation to support it, but maybe it could be a good idea to add support for it by default.
The CSS media feature lets you use a media query to adapt your styling to the light or dark theme requested by the system. If the user's browser is using dark theme, the application could adapt to it and use dark theme as well, instead of showing any eye-hurting white.
It can also be seen on the documentation:

macOS 11.6, w/ System Preferences > General > Appearance > Dark
Chrome 93.0.4577.82
Visit https://mui.com
Page initially loads in light theme, but switches to dark
Further navigation stays in dark
Issue can be repeated by doing a force page reload

Expected that the page wouldn't switch appearance mode/flash. Figured it was best to describe this FYI issue here?
Benchamark

https://github.com/pacocoursey/next-themes
https://github.com/gregberge/xstyled/blob/main/packages/core/src/colorModes.tsx
https://www.joshwcomeau.com/react/dark-mode/

Related

https://www.notion.so/mui-org/CSS-Variables-7bb67216f58f425fb1fc565c2246bfe2
#27651

We currently use this media query in our docs to switch to a dark theme on the client. Since we prerender them we always deliver the version with the light theme that gets hydrated with the preferred color scheme causing a flash of outdated styles if a dark theme is preferred.
As far as I know the only solution would be to use the CSS media query in our core components which would use the colors in the dark theme. This would add a lot of styles to the core for a query that isn't supported by most of our supported platforms or even some operating systems.
I think it's better to write a custom theme that adds the query to all the necessary classes concerning color (which is probably a lot). I guess this is one of those instances where CSS variables would be the best solution (if they can read media queries).

Notice the introduction of new section in the documentation: https://master--material-ui.netlify.com/customization/palette/#user-preference
import React from 'react';
import useMediaQuery from '@material-ui/core/useMediaQuery';
import { ThemeProvider } from '@material-ui/core/styles';

function App() {
  const prefersDarkMode = useMediaQuery('(prefers-color-scheme: dark)');

  const theme = React.useMemo(
    () =>
      createMuiTheme({
        palette: {
          type: prefersDarkMode ? 'dark' : 'light',
        },
      }),
    [prefersDarkMode],
  );

  return (
    <ThemeProvider theme={theme}>
      <Routes />
    </ThemeProvider>
  );
}

This topic is close to the discussion we have in #16367.

We have the odd situation where useMediaQuery always fails during the first render, causing an incorrect flash of unstyled content in some cases.  The following ugly workaround works, because it should not be the case that both media queries fail.
   const prefersDarkMode = useMediaQuery('(prefers-color-scheme: dark)')
   const theme = useTheme(prefersDarkMode)

   // Refuse to render until media queries align
   const prefersLightMode = useMediaQuery('(prefers-color-scheme: light)')
   if (prefersDarkMode !== !prefersLightMode) return null

The first render both fail, so it refuses to render anything, then it soon corrects and renders a logically consistent result (only one of prefers light or prefers dark) and we get no incorrectly styled flash.

@elyobo It's equivalent to the usage of the NoSsr component, right?

I have no idea, haven't looked at any of the SSR stuff because we're not doing SSR, the issue is happening for us client side.  First render both are false, then very soon after it renders in a sane way (can't prefer both light and dark).

Super interesting, thanks for sharing, I think that we should run the update on the layout effect.

While looking at the code to understand what you were suggesting, I noticed this
  const {
    defaultMatches = false,
    matchMedia = supportMatchMedia ? window.matchMedia : null,
    noSsr = false,
    ssrMatchMedia = null,
  } = {
    ...props,
    ...options,
  };

  const [match, setMatch] = React.useState(() => {
    if (noSsr && supportMatchMedia) {
      return matchMedia(query).matches;
    }
    if (ssrMatchMedia) {
      return ssrMatchMedia(query).matches;
    }

    // Once the component is mounted, we rely on the
    // event listeners to return the correct matches value.
    return defaultMatches;
  });

Our problem can be solved by passing in noSsr: true to useMediaQuery (doesn't seem to be documented), because we're not using SSR, and without passing through that flag the default is defaultMatches (which itself defaults to false).  This matches what we're seeing (everything is false at first).
Perhaps the PR needed is a documentation one?

causing an incorrect flash of unstyled content in some cases

@elyobo I had this problem in mind, I would expect useLayoutEffect to solve the problem. If you have a reproduction, it would help to investigate.

@oliviertassinari our problem is that unless you pass noSsr it uses the defaultMatches value as the initial value of the state.  useLayoutEffect might help, but it's not necessary for us if we can just get the match to work correctly on the first run instead, and you'd still be causing an unnecessary render I think (it would still generate the theme twice, just that the second one would happen earlier than currently, right?).

@elyobo Ok, so we might not be able to do anything about it, noSsr seems to be the way.

Ok if I make a PR to extend the docs for some of those options?
On Sat, 21 Dec 2019, 08:41 Olivier Tassinari<EMAIL_ADDRESS>wrote:

@elyobo https://github.com/elyobo Ok, so we might not be able to do
anything about it, noSsr seems to be the way.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mui-org/material-ui/issues/15588?email_source=notifications&email_token=AADDR7QBMJ5J7FAXPF4YQYLQZU3Y5A5CNFSM4HKZBV6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHOH3GI#issuecomment-568098201,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADDR7RHJPOR3RGHGSP4OELQZU3Y5ANCNFSM4HKZBV6A
.

Sure, it would help

Hey! I just faced this issue and I had come across this blog post. The approach suggested here seems to be to use CSS Custom Properties along with script to detect whether the user has a color preference on initial load.
Theme-UI seems to do this and also provides a useColorMode hook that allows a user to toggle all the color modes which remembers preference using local storage.  Material-UI could take a similar approach?
I would not mind working on this if you guys think it is a valid approach. It would be my first open source issue though so any help would be appreciated!😅

@HiranmayaGundu have you tried using theme-ui with material-ui?  I've been trying to find examples but haven't found one.

@bugzpodder No I have not tried that out, and I'm not entirely sure that is possible? Material-UI uses it's own theme specification. You could simply use createMuiTheme() to make a custom theme

I'm using Next.js and I've wrapped my <App> component with the <ThemeProvider>, which should be preserving the theme between pages, but I'm still noticing a flash of light -> dark between pages.
Am I or Next.js screwing something up, or is there still not a concrete solution to this flash of unthemed changes?

@pizzafox The flash comes from the reliance on JavaScript to detect the media query. To solve the flash, there are a couple of options:

Duplicate the generated CSS one for light and another one for dark, prefixed with the media query
Hide the screen until the rendering of the JavaScript media query
Store the preferred mode of the user into a cookie, dynamically serve this request.
Move all the colors that are impacted by the dark/light mode into CSS variables, toggle the variables at the root with a media query. Used by StackOverflow.

@oliviertassinari Is it possible to allow strings like var(--color-red) in the MUI Theme? That would allow me to use CSS variables just for the palette.

@HiranmayaGundu We have a running discussion about it in #12827.

We can do something like:
const colorScheme = window.matchMedia('(prefers-color-scheme: dark)').matches ? 'dark' : 'light'; // checking if the media query is true const theme = createMuiTheme({   palette: {     type: colorScheme,   } }
to achieve dark theme based on browser/system settings.

@elyobo, this is very interesting. I have a similar case to yours, did you find that there was an overlap of CSS style sheets on your elements ?

@elyobo, this is very interesting. I have a similar case to yours, did you find that there was an overlap of CSS style sheets on your elements ?

I don't recall sorry @fosteman; the noSsr solution solved everything for us, as we weren't doing server side rendering, and it seems like it's probably the right approach for anyone that isn't doing server side rendering.
We set the noSsr option when we create the theme (as documented at the bottom of the section here) so that it's the default for all media queries.

I don't recall sorry @fosteman; the noSsr solution solved everything for us, as we weren't doing server side rendering, and it seems like it's probably the right approach for anyone that isn't doing server side rendering.
We set the noSsr option when we create the theme (as documented at the bottom of the section here) so that it's the default for all media queries.

Thanks for the noSsr solution.
This still seems a weird behavior and at first, I thought it didn't work at all. The query gives first false, then true but it didn't render the page with dark mode (idk why). It now works, but I assume that it should work by default noSSr true and if you are using SSR you could enable it as for SPA it's a significant overhead (renders twice, or in my case idk did it actually😅). But I guess someone smarter decided it to be the other way around (no sarcasm).

Thanks for the noSsr solution.
This still seems a weird behavior and at first, I thought it didn't work at all. The query gives first false, then true but it didn't render the page with dark mode (idk why). It now works, but I assume that it should work by default noSSr true and if you are using SSR you could enable it as for SPA it's a significant overhead (renders twice, or in my case idk did it actually😅). But I guess someone smarter decided it to be the other way around (no sarcasm).

What about Sec-CH-Prefers-Color-Scheme client hint header? https://web.dev/user-preference-media-features-headers/ ?

@TheBit Developers can already implement a solution relying on Sec-CH-Prefers-Color-Scheme but it forces to have a server handling each request, or to have a smart cache that can use it. The goal of this issue I believe is to remove this constraint.

I believe that we can close this issue with the experimental API CssVarsProvider.

instead of showing any eye-hurting white.

@siriwatknp We could close, unless we consider it done once all the pages of https://mui.com/ no longer flash like the homepage https://twitter.com/MUI_hq/status/1582390058099015685

instead of showing any eye-hurting white.

@siriwatknp We could close this issue, it sounds like the root of the pain point is solved, proof: https://twitter.com/MUI_hq/status/1582390058099015685.
If we close, I think that we should create a new migration issue to have all the pages of https://mui.com/ no longer flash like the homepage, e.g. the docs pages.

Yep, sounds good. We can get some help from the community to migrate the rest of the pages.

The new issue in question: #34880.


[Request for external] codeunit 1280 "Map Currency Exchange Rate" - AssignValue

Can you remove "local" from procedure AssignValue in codeunit 1280 "Map Currency Exchange Rate".

This is TryFunction and it should be local. See here https://docs.microsoft.com/en-us/dynamics365/business-central/dev-itpro/developer/methods/devenv-tryfunction-attribute

This is TryFunction and it should be local. See here https://docs.microsoft.com/en-us/dynamics365/business-central/dev-itpro/developer/methods/devenv-tryfunction-attribute


[WIP][SPARK-22148][CORE] TaskSetManager.abortIfCompletelyBlacklisted should not abort when all current executors are blacklisted but dynamic allocation is enabled

What changes were proposed in this pull request?
I've been working on this issue, and I would like to get your feedback on the following approach. The idea is that instead of failing in TaskSetManager.abortIfCompletelyBlacklisted, when a task cannot be scheduled in any executor but dynamic allocation is enabled, we will register this task with ExecutorAllocationManager. Then ExecutorAllocationManager will request additional executors for these "unscheduleable tasks" by increasing the value returned in ExecutorAllocationManager.maxNumExecutorsNeeded. This way we are counting these tasks twice, but this makes sense because the current executors don't have any slot for these tasks, so we actually want to get new executors that are able to run these tasks. To avoid a deadlock due to tasks being unscheduleable forever, we store the timestamp when a task was registered as unscheduleable, and in ExecutorAllocationManager.schedule we abort the application if there is some task that has been unscheduleable for a configurable age threshold. This way we give an opportunity to dynamic allocation to get more executors that are able to run the tasks, but we don't make the application wait forever.
How was this patch tested?
This is WIP for discussion, unit tests will be provided later on

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?