Identical expressions. Probably meant .width || .height

https://github.com/baldurk/renderdoc/blob/aa5538b2e92a266b9126c75f085abdc508597c10/renderdoc/core/image_viewer.cpp#L758
Line is if(texDetails.width > 16384 || texDetails.width > 16384)

This does look a code mistake and would want to see this as a bug report with a reproduction to drive code change. In this case an image with width < 16384 and height > 16384 might create a bug

Hi there, your issue has been closed due to not correctly following the issue template. Please read the documentation about filing issues and open a new issue which does follow the issue template. Do not reply to this issue with more information or with a correctly formatted issue, as that will only lead to confusion.
I try to address all github issues and fix bugs quickly, but badly formatted issues or poorly described bug reports especially are a significant drain on project resources. Taking a few minutes to file a good issue makes a huge difference and will get it addressed faster - everybody wins!
In github when you first create a new issue the form is pre-populated with a template which you should read over and follow. As linked above there is documentation going into more detail about what makes a good issue.

Thanks. I am looking for real contributions to be made. I am trying to avoid being a contributor to the project through some cheap means like this.


get_url across mount points

app/
    app.py
    modules/
        mod1/
            mod1.py
            views/
                view1.html
        mod2/
            mod2.py
            views/
                view2.html

app.py
root = Bottle()
root.mount ("/mod1", mod1app)
root.mount ("/mod2", mod2app)

Question: can I use get_url from a template, to get a URL from any module? For example
view1.html
{{  get_url ("root.about")  }}
{{  get_url ("mod1.articles")  }}
{{  get_url ("mod2.shop")  }}

@carc1n0gen yes, but I got this error UndefinedError("'get_url' is undefined"). After reading the Bottle source, I discovered that I can use bottle.BaseTemplate.defaults['get_url'] = root.get_url. This works, in the sense that I can get a url for root. However, this does not work across modules mounted with .mount().

Sounds like you have your answer.  I'm still new to bottle but so I can't 100% confirm though

Ideally, I think it should work like this
root = Bottle()

mod1 = Bottle(name='mod1')
mod2 = Bottle(name='mod2')

root.mount ("/mod1", mod1)
root.mount ("/mod2", mod2)

bottle.BaseTemplate.defaults['get_url'] = root.get_url

and used like this from a template
{{ get_url('about') }}        <-    get "about" route from base app
{{ get_url('mod1.user') }}    <-    get "user" route from mod1 app

If this functionality could be added to Bottle, I think it would be great.

Sounds like you have your answer.

No I don't have my answer, because I can't use get_url across modules. I can only use for 1 module.

Looks like get_url is a method on the Bottle class so it probably only looks at the routes for that bottle instance. [1]
👍 For making this feature request from me though.
[1] https://github.com/bottlepy/bottle/blob/master/bottle.py#L871

Sounds like you have your answer.

No I don't have my answer, because I can't use get_url across modules. I can only use for 1 module.

But you question was:

Question: can I use get_url from a template, to get a URL from any module? For example

Currently the answer to that question is no

Oh, you're right. The answer is no. I'd like to suggest this feature though.


Boolean value "false" not being inserted when column has a default value

We have a table with a boolean column with its default set to true.  We then try to insert a model into that table with a false value in that column.  The query is generated without the column in the insert statement (it is in the returning statement instead), causing the database to use its default value.

This behavior is intentional. On insertion the mechanism is that:
For any field with a default value and a zero value in the Go struct, then it's assumed the user didn't set it and it should assume the default value so it's omitted from the query.
The only way to force it to do the right thing is wherever you're inserting this struct, simply list the columns you want to insert in the whitelist. The whitelist overrides this default mechanism and forces that column to appear in the query.
We used to have some nasty code that would parse the default value from postgres, try to coerce that into a default value, and check if it was equal to the default value before omitting it. But it was error prone and scary, full of regexes etc so I'd prefer not to bring it back.
Is this an acceptable solution?

@aarondl I definitely agree that trying to parse out the default value from postgres is a bad path to head down, and I understand trying to use the database default values if the Go value appears to be "falsey".
It definitely feels like weird behavior here however.  My preference is to avoid whitelists in most cases, so that i dont have to worry about missing them as I add columns - I tend to only use them when I am restricting the column list for a security reason.
Unfortunately, I dont have any great solutions off the top of my head for how to satisfy both of these use cases since there is no way to specify false vs. not set without using a null.Boolean, which also seems like the wrong approach.  In the very particular case where I am running into this, we can fairly easily switch to a whitelist approach (it is in a series of unit tests).  We will have to be on the lookout for it in the future however, as its not readily apparent that it was not setting this value.


Document SOL_CHECK_ARGUMENTS and other build params

I propose to add section into API reference documenting SOL_CHECK_ARGUMENTS and any other build params if they are exist.
One particular thing that makes me cautious about Sol2 is your concentration on the speed, while reliability of applications using Sol is under question. In particular, it seems that without SOL_CHECK_ARGUMENTS, i.e. by default, i can export C++ function accepting string, call it from Lua with number and make a crash.
In another place you mention "Do NOT save the return type of a function_result with auto". It will be great to protect from such errors with some type machinery. Aa well as combine all the remaining warnings in the single documentation section.

There is, unfortuantely, nothing we can do to stop the user from auto-ing function_result. Not even a private class struct can stop the power of auto: private only means the programmer can't name it explicitly, auto doesn't obey the same rules as the programmer.
As for CHECK_ARGUMENTS and friends, yeah I need a section on that. Goes right along with defining SOL_NO_RTII or SOL_NO_EXCEPTIONS, but SOL_CHECK_ARGUMENTS is the only other one that's not really documented. Bundling them up in a single "config.rst" file would probably be for the best.
... When I have. :B

SOL_CHECK_ARGUMENTS is documented at http://sol2.readthedocs.org/en/latest/api/function.html
The question is only about bundling them all together

Right, but SOL_CHECK_ARGUMENTS needs to have its own place. NO_RTTI and NO_EXCEPTIONS basically have their own section. Safety should probably have its own top-level section there alongsinde Exceptions and RTTI as well. I also should probably generalize it to make sure every stack::get call is checked as well.
I've been considering looking up the debug-defined macros for VC++, g++ and clang++ and automatically defining these to be present if they're not already present. However, I believe most users are good at knowing what they want to call their functions with and in most cases get it right, so until I make the commit to make that the default and update the docs, I'll be leaving it as is.

It's done: http://sol2.readthedocs.org/en/latest/safety.html


Update README.md by fixing an invalid link instance.

The original example has been removed and its link is invalid, and an existing case capnproto.yaml is now updated.

Good catch, thank you!


ARTEMIS-1227 Internal properties not removed from messages

In a cluster if a node is shut down (or crashed) when a
message is being routed to a remote binding, a internal
property may be added to the message and persisted. The
name of the property is like _AMQ_ROUTE_TOsf.my-cluster*.
if the node starts back, it will load and reroute this message
and if it goes to a local consumer, this property won't
get removed and goes to the client.
The fix is to remove this internal property before it
is sent to any client.

This is being reverted... following up a discussion on the legacy hornetq codebase:
https://github.com/hornetq/hornetq/pull/2114


RFE - Include Percentage loss feature in Bench-Iperf

The 0-drop hunter patch [1] has an inconsitency in the UDP packet while increasing the length size by more than 1K (reference issue [2]).
To find consistency in the multiple samples results, the binary-search mechanism of bench-iperf needs further condition check to accept minimal percentage drop (as per RFC loss standard).
The feature will help full to get more granular result bench-iperf benchmarking.

Git branch

# git remote -v; git branch
  origin  https://github.com/HughNhan/bench-iperf (fetch)
  origin  https://github.com/HughNhan/bench-iperf (push)
  * (HEAD detached at origin/zero-drop-hunter)

https://github.com/perftool-incubator/bench-iperf/issues/18

This was a goal per Issue #13

DUP request


Update work-with-multi-value-attributes.md

removed extra space

Included in another PR that's publishing now. Thanks.


feat: add sealion model support

About this PR
This PR adds support for AI Singapore's SEA-LION model by updating the MPT codes.
Specifically, this PR adds support for MPT models with any of the following config values:

attn_config["alibi"] : false
attn_config["qk_ln"] : true (NUM_SHARD must be 1)
no_bias : false
It also allows the use of embedding fraction config (embedding_fraction) for these models.

The following models are successfully tested:

Model
attn_config["alibi"]
attn_config["qk_ln"]
no_bias
embedding_fraction

aisingapore/sealion3b
false
false
false
1.0

aisingapore/sealion7b
false
true
false
0.1

aisingapore/sealion7b-instruct-nc
false
true
false
0.1

mosaicml/mpt-7b
true
false
true
1.0

Test Cases
Test case 1: model aisingapore/sealion3b, num-shard=1
Run:
model=aisingapore/sealion3b
volume=$PWD/data

docker run -d --gpus '"device=0"' --shm-size 1g -p 8080:80 \
-v $volume:/data \
-v $PWD/mpt_modeling.py:/opt/conda/lib/python3.10/site-packages/text_generation_server/models/custom_modeling/mpt_modeling.py \
ghcr.io/huggingface/text-generation-inference:1.3.4 \
--model-id $model \
--trust-remote-code \
--dtype bfloat16 \
--num-shard 1

Infer:
curl localhost:8080/generate \
-X POST \
-d '{"inputs":"Hello, my name is John and I am a","parameters":{"max_new_tokens":256,"repetition_penalty":1.2,"eos_token_id":1,"do_sample":false}}' \
-H 'Content-Type: application/json'

{"generated_text":" professional writer with more than 10 years of experience in the industry.\nI have written for many online publications such as The Huffington Post (2), Business Insider , Forbes Magazine & other top media sites to help them get their message out there on social networks like Facebook or Twitter ."}

Test case 2: aisingapore/sealion7b, num-shard=1
Run:
model=aisingapore/sealion7b
volume=$PWD/data

docker run -d --gpus '"device=0"' --shm-size 1g -p 8080:80 \
-v $volume:/data \
-v $PWD/mpt_modeling.py:/opt/conda/lib/python3.10/site-packages/text_generation_server/models/custom_modeling/mpt_modeling.py \
ghcr.io/huggingface/text-generation-inference:1.3.4 \
--model-id $model \
--trust-remote-code \
--dtype bfloat16 \
--num-shard 1

Infer:
curl localhost:8080/generate \
-X POST \
-d '{"inputs":"Hello, my name is John and I am a","parameters":{"max_new_tokens":256,"repetition_penalty":1.2,"eos_token_id":1,"do_sample":false}}' \
-H 'Content-Type: application/json'

{"generated_text":" 20 year old student at the University of California in Santa Barbara.\nI have been playing guitar for about three years now but only started to take it seriously around two months ago when i bought myself an acoustic electric Gibson Les Paul Studio (which was actually given as a gift by one of my best friends). The reason why this instrument has become so important to me is because its sound quality can be compared with that of any other high end guitars out there which makes learning how to play much easier than if you were using something like a cheap plastic Fender Strat or even worse yet - a $150 Yamaha acoustic/electric hybrid! In addition though, having such great tone also means being able to create some pretty cool sounds on your own without needing someone else's help...and thats what im here today trying to do :)"}

Test case 3: aisingapore/sealion7b-instruct-nc, num-shard=1
Run:
model=aisingapore/sealion7b-instruct-nc
volume=$PWD/data

docker run -d --gpus '"device=0"' --shm-size 1g -p 8080:80 \
-v $volume:/data \
-v $PWD/mpt_modeling.py:/opt/conda/lib/python3.10/site-packages/text_generation_server/models/custom_modeling/mpt_modeling.py \
ghcr.io/huggingface/text-generation-inference:1.3.4 \
--model-id $model \
--trust-remote-code \
--dtype bfloat16 \
--num-shard 1

Infer:
curl <IP_ADDRESS>:8080/generate \
-X POST \
-d '{"inputs":"### USER:\nWhere is Singapore?\n\n### RESPONSE:\n","parameters":{"max_new_tokens":256,"repetition_penalty":1.2,"eos_token_id":1,"do_sample":false}}' \
-H 'Content-Type: application/json'

{"generated_text":"Singapore is an island country in Southeast Asia."}

Test case 4: aisingapore/sealion7b-instruct-nc, num-shard=2
Run:
model=aisingapore/sealion7b-instruct-nc
volume=$PWD/data

docker run -d --gpus '"device=0,1"' --shm-size 1g -p 8080:80 \
-v $volume:/data \
-v $PWD/mpt_modeling.py:/opt/conda/lib/python3.10/site-packages/text_generation_server/models/custom_modeling/mpt_modeling.py \
ghcr.io/huggingface/text-generation-inference:1.3.4 \
--model-id $model \
--trust-remote-code \
--dtype bfloat16 \
--num-shard 2

Logs:
...
  File "/opt/conda/lib/python3.10/site-packages/text_generation_server/models/custom_modeling/mpt_modeling.py", line 352, in __init__
    raise NotImplementedError("qk_ln is not supported for number of shards > 1")

Test case 5: mosaicml/mpt-7b, num-shard=1
Run:
model=mosaicml/mpt-7b
volume=$PWD/data

docker run -d --gpus '"device=0"' --shm-size 1g -p 8080:80 \
-v $volume:/data \
-v $PWD/mpt_modeling.py:/opt/conda/lib/python3.10/site-packages/text_generation_server/models/custom_modeling/mpt_modeling.py \
ghcr.io/huggingface/text-generation-inference:1.3.4 \
--model-id $model \
--dtype bfloat16 \
--num-shard 1

Infer:
curl localhost:8080/generate \
-X POST \
-d '{"inputs":"Hello, my name is John and I am a","parameters":{"max_new_tokens":256,"repetition_penalty":1.2,"eos_token_id":1,"do_sample":false}}' \
-H 'Content-Type: application/json'

{"generated_text":" recovering alcoholic.\nI have been sober for over 10 years now but it was not always that way! In fact the first time i got drunk at age 15 (i know right) after being told by an older friend to try some alcohol as he had just started drinking himself...well needless too say this did NOT go well!! After getting home from school on Friday afternoon with friends we all went out in our local town centre where there were many pubs/bars etc..we decided which one would be best so off me & 2 of them headed into said bar....after about 5 minutes or less they both came back saying \"come quick\" then proceeded down stairs towards us.....as soon as you walked through those doors your hit straight away!!! The smell alone made u want more!!!! So anyway long story short......me n 1 other guy ended up going round every single place trying different types until eventually ending outside another club called 'The Rocket'....this nightclub has since closed due to fire damage however when inside its like no-where else ive ever seen before...the music blasting loud enough even if ur standing next door could hear everything thats happening within!!!!!!!!! And believe ME im sure everyone who's gone here will agree 100%!! Anyway once again having"}

Test case 6: mosaicml/mpt-7b, num-shard=2
Run:
model=mosaicml/mpt-7b
volume=$PWD/data

docker run -d --gpus '"device=0,1"' --shm-size 1g -p 8080:80 \
-v $volume:/data \
-v $PWD/mpt_modeling.py:/opt/conda/lib/python3.10/site-packages/text_generation_server/models/custom_modeling/mpt_modeling.py \
ghcr.io/huggingface/text-generation-inference:1.3.4 \
--model-id $model \
--dtype bfloat16 \
--num-shard 2

Infer:
curl localhost:8080/generate \
-X POST \
-d '{"inputs":"Hello, my name is John and I am a","parameters":{"max_new_tokens":256,"repetition_penalty":1.2,"eos_token_id":1,"do_sample":false}}' \
-H 'Content-Type: application/json'

{"generated_text":" recovering addict.\nI have been clean for over two years now but the journey to get here was long one filled with many ups & downs along this road of recovery that we call life! It's not always easy being an alcoholic or drug addicted person in today society because there are so few places where you can go without feeling judged by others who don't understand what it's like living day-to -day as someone struggling through addiction; however if anyone ever needs help please feel free contact me at any time via email (john@recoveryispossiblenow)or phone number listed below."}

Hi Narsil,
Can you explain more on how to add layernorms in TP, and perhaps give an example on how to do it, if possible?
Thanks!

I can take care of the changes if you want. Would that be interesting ?

I can take care of the changes if you want. Would that be interesting ?

That will be nice. Thanks!

Can I push on this branch ? (Otherwise I have to make a separate PR that includes your commit so you do get the credits, bu tit's not this PR anymore)

https://github.com/huggingface/text-generation-inference/pull/1477
Here is the PR with the fixes.

Another thing I noted while testing is the need for trust_remote_code for the config.
Given that this config I think is only used for embedding_fraction, which we can safely ignore, I think maybe we could fix that part so that we didn't need the custom code (I think it provides values to enable users to not have to vet external code).

I went ahead and merged this one: https://github.com/huggingface/text-generation-inference/pull/1477
We can close this one. Happy to update things if you want on your end.
I took the liberty of fixing TP>1 for sealion7b !


Hello, what are the exact parameters of the stage for '-from -to'? I am looking forward to your answer.

############################question#########################################
Hello, what are the exact parameters of the stage for '-from -to'? I am looking forward to your answer.

Its good to keep this in discussion tab: https://github.com/The-OpenROAD-Project/OpenLane/discussions

https://github.com/The-OpenROAD-Project/OpenLane#command-line-arguments explained here

Thank you very much, it has solved my problem!


Fine-grained PATs support for GraphQL

Summary
While fine-grained PATs support GitHub's REST APIs, the public beta does not include GraphQL support.  This roadmap item tracks the ability to use a fine-grained PAT against all the same GraphQL APIs that a GitHub App can target.
Intended Outcome
Lots of GitHub features are surfaced via the GraphQL API, and we need fine-grained PATs to be able to use them. When complete, fine-grained PATs will have parity with GitHub Apps when it comes to GraphQL.
How will it work?
We'll be confident in the correctness and security of fine-grained PAT access to GraphQL APIs.  You'll be able to use a fine-grained PAT anywhere you could use a user-to-server GitHub app token.

🚢 This has shipped: https://github.blog/changelog/2023-04-27-graphql-improvements-for-fine-grained-pats-and-github-apps/.
Leaving open to track for GHES release.

This has shipped with GHES 3.10: https://github.blog/2023-08-29-github-enterprise-server-3-10-is-now-generally-available/


Add "default graph override" to manifest loading

[x] Add get_default_connection_string() to python
[ ] implement override in manifest and supporting rack python

Currently this is implemented as --default-graph in the manifest import command


Customizable checkboxes and radio buttons

Hi,
I would like to customize the checkboxes and radiobuttons with custom class names and styles. Is there a way possible?

@Suzanna-Manoj-Williams, sorry, we didnt support this feature, check #497, I will make these component more customizable in v3.0.0

It will be helpful if the checkbox can be a combination of input and label for the input, like below:

Check!!

--------------------------------------------------------------------------------------------------------------------------------------
So we can customize only the checkbox with label and not others.

@Suzanna-Manoj-Williams surely.

I've found this feature is implemented in v2.4.2.
See an example here.

haha, yes, This feature has been supported, thanks @hawker000 your remind

Hi,
it's possible add custom style for width (or change it) in lib\util.js@row63
30px is too narrow for custom checkboxes in my project.
if (isSelectRowDefined) {
  var style = {
    width: 30,
    minWidth: 30
  };
  if (!selectRow.hideSelectColumn) {
    selectRowHeader = _react2.default.createElement('col', { style: style, key: -1 });
  }
}

@wenom64, there's no any better solution, but you can use css to override it(There were someones did it)

Too bad.. I don't like !important, but do I have a choise?! 😄
My solution for now:
jsx
<BootstrapTable
  tableHeaderClass="table-custom-checkboxes"
  tableBodyClass="table-custom-checkboxes"
>

stylesheet
.table-custom-checkboxes > colgroup > col:first-child{
  width: 36px !important;
  min-width: 36px !important;
}

@wenom64, https://github.com/AllenFang/react-bootstrap-table/issues/979

@wenom64, released on v2.10.0, check example

Wow, U are the Best... I'm going to try it.


change trigger for porchctl release build

It will only trigger on tag named in scheme vX.Y.Z

required for testing updates


fix: add project config validation when using args, fixes #5445

The Issue

https://github.com/ddev/ddev/issues/5445

How This PR Solves The Issue
Runs validation check for every projects that you pass to any DDEV command that uses args, so fixes more than just ddev start.
Manual Testing Instructions
See the issue.
Automated Testing Overview

Related Issue Link(s)
Release/Deployment Notes

Rebased


Uses js/ts indenting inside the template instead of the template language's indenting

With minimal vimrc, this is what :JsPreTmpl html indents as:
let tmpl = `

 content

`;

That is, =ap on that will not change anything. Every level of nesting will be on the same indent level, no matter what. Whereas the below will indent as:
let tmpl = `
let js = {
  aaa: blah.connect().map(x => {
    one.two(
      three
    ).four(() => {
      five
    });
    return [
      "six",
      7
    ];
  })
}
`;

Indenting in vim is a mystery to me, so I have no idea how to fix that.
Edit: I should mention I tried :setf typescript.html, but then this plugin has no effect at all. That works with vim-pandoc-syntax and the code blocks feature, but not here.

@cormacrelf . Thanks for using this plugin 😄
This plugin effects only syntax highlighting. This never change your indenting.
I guess that the above indenting example get the same results without this plugin. The first(HTML) will be indented flatly, the second(js in js) are indented in the JavaScript way 🤔


outputs do not inherit build/noarch parameter

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

These new packages were accidentally not noarch packages since outputs do not inherit from build/noarch.

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

@nsoranzo not necessary (the arch specific ones work fine) but I'll do that to cleanup


New release planned?

Do you have any bug fix release planned and any feature release this year? Is there maybe a roadmap? I believe Lua5.4 is coming soon too btw.
Would be great to know in advance a bit so we can plan too.

Yes, I am planning a new release. I am hoping to do it later in June or, depending on how speaking at C++ on Sea and C++ Russia goes, by the end of August accounting for all potential buses I can be hit by.
I have got a lot on my plate, but the new release should be backwards compatible and just fix bugs, so nothing to really worry about. I've been testing against latest Lua 5.4 as well, even if the CI is in a perpetual state of red because TravisCI and Appveyor are the bane of my existence.
(Part of the new release is moving everything to GitHub actions, but my CI builds are... pretty involved, unfortunately. 😭)

what's new in 3.2.0? I saw the new release , but not the comment. Bug fixed or new feather?

Any plans on replacing custom type_traits with C++20 concepts on a near future? I think they are a worthy because AFAIK they can reduce compile times. (of course, backwards compatibility is important as well)

That'd bump the requirements up to C++20 and people are already kind of miffed about the C++17 requirement.
On the other hand, I actually need to change a lot of the templates to use other techniques to reduce compile times, because even if I did a big cleanup for if constexpr I have a LOT of other garbage to clean up...

Temporary release to get Visual Studio off everyone's back: https://github.com/ThePhD/sol2/releases/tag/v3.2.1

(This release should also be fine with Lua 5.4, modulo an explosion.)

Thank you @ThePhD ! I'll try it immediately.

New release planned eventually.
Kool and what's planned in it? And when could it happen?


Switch extensions from .c to .cc and fix compile time errors

Alternative implementation of https://github.com/rhasspy/pymicro-features/pull/1 that doesn't require OS-specific build-time patching.

This fixes the build for me on an Apple Silicon device running macOS 14.6.1 ✅
It'd be great to see either this or #1 merged soon :)


Qingwei/temp fix resubscribe issue

OK to merge

Coverage increased (+0.04%) to 29.072% when pulling d1aca8383d4a7a889a8ec3dcb932cd12ec5d862f on qingweibinary:qingwei/temp_fix_resubscribe_issue into 7868fb28ddb68b28e49186ea8b109c1a118f3c28 on binary-com:master.

Temp fix? Does not sound inspiring? :)
Why temporary?

@borisyankov because backend should fix the resubscribe issue, this is more of a workaround to reduce it ?


Network Policy Controller sync

Along with namespace event handlers, add
logic to sync Groups and internal NP
objects.

/test-e2e


fix(compiler-sfc): handle keyof operator

Close #10871

Thank you for the PR! Made a few adjustments:

The inline handler seems unnecessary. It creates the overhead of extra function allocation and invocation and does not improve readability.
Passing isKeyOf down as a boolean avoids the object allocation and destructure. In framework code we typically are fine with more arguments over options objects for the sake of performance.


Fix runtime ID, check amount when minting collectibles, rebase GetInfo RPC fixes commit

Fixes https://github.com/lightninglabs/taproot-assets/issues/576.
Fixes https://github.com/lightninglabs/taproot-assets/issues/573.
Replaces https://github.com/lightninglabs/taproot-assets/pull/554.
Fixes multiple small issues.

Would be good to have an itest for the runtime ID change; something like starting 100 tapd instances, pulling the runtime ID via universe info, and making sure that they are all unique.

Would be good to have an itest for the runtime ID change; something like starting 100 tapd instances, pulling the runtime ID via universe info, and making sure that they are all unique.

Unit test here (forces us to abstract it a bit more) would prob be good enough here. Or we increase increase to 32 bytes and call it a day.


DocCardList element renders the wrong items

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Prerequisites

[X] I'm using the latest version of Docusaurus.
[X] I have tried the npm run clear or yarn clear command.
[X] I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
[X] I have tried creating a repro with https://new.docusaurus.io.
[X] I have read the console error message carefully (if applicable).

Description
I have run into a bug where the DocCardList element renders the wrong items when linking to an category index with a DocCardList element.
Using the tutorial example from https://docusaurus.new/codesandbox, I create a new sidebar:
const sidebars = {
  tutorialSidebar: [
    "intro",
    {
      type: "category",
      label: "Tutorial - basics",
      items: [
        "tutorial-basics/create-a-page",
        "tutorial-basics/create-a-document",
        "tutorial-basics/create-a-page",
        {
          type: "link",
          label: "Manage Docs Versions →",
          href: "/docs/tutorial-extras/",
        },
      ],
    },
    {
      type: "category",
      label: "Tutorial-Extras",
      link: {
        type: "doc",
        id: "tutorial-extras/index",
      },
      items: [
        "tutorial-extras/manage-docs-versions",
        "tutorial-extras/translate-your-site",
      ],
    },
  ],
};

New index page for tutorials-extras looks like this (backticks changed to single-quotes so formatting works here):
# Tutorial Extras

'''mdx-code-block
import DocCardList from '@theme/DocCardList';

<DocCardList />
'''

Note the new index page for tutorial-extras and the new link element in the tutorial-basics section sending you to the tutorial-extras/index page.
When clicking on the link to tutorial-extras the navigation sends you to the correct index page but the DocCardList is populated by elements from the tutorial-basics category and not the tutorial-extras category. This happens even when clicking directly on the Tutorial - Extras sidebar element.
There is a separate, related issue where the link element in the sidebar is prioritized in terms of focus, but I'll make a new issue for that.
Reproducible demo
https://codesandbox.io/p/devbox/brave-allen-d39ddg?workspaceId=971447fd-9df5-4a54-a72d-33087efcd2fa
Steps to reproduce

click on tutorial section
click on tutorials - extras in sidebar. See that the populated list of elements is incorrect
or
click on tutorials - basics in the sidebar, then click on Tutorial Extras → sub-item. See that the populated list of elements is incorrect.

Expected behavior
Cards should populate from the category where the doc element exists and not from the link element.
Actual behavior
Cards populate from the link element. Or maybe just from the first instance where the link occurs?
Your environment
occurs in sandbox and also in my local environment.

Public source code:
Public site URL:
Docusaurus version used: 3.5.2
Environment name and version (e.g. Chrome 89, Node.js 16.4): I am using Firefox 129.0.2 and node v21.7.0
Operating system and version (e.g. Ubuntu 20.04.2 LTS): Windows 11 Home 23H2 with WSL2 - Ubuntu 20.04.6 LTS

Self-service

[ ] I'd be willing to fix this bug myself.

I guess it's related to https://github.com/facebook/docusaurus/discussions/9923#discussioncomment-8709736


Not checking reference-style links

Describe the bug
If you use reference style links, this check does not fail when the relative path does not exist.

[this will be caught](/link-that-does-not-exist)

[but this will not]

[but this will not]: /link-that-does-not-exist

To Reproduce
I created this repo from the starlight starter and replaced the content with a single reference that should be caught and is not.
Expected behavior
Reference-style relative links should be caught the same way as inline links.
How often does this bug happen?
Every time
System Info
No response
Additional Context
No response

Thanks for the detailed issue 🙌
This should now be fixed in v0.4.2.

Wow, that was fast, thanks so much! It works, and my site now has several fewer broken links 😁


Added Aditi22Bansal.md

@Aditi22Bansal  before making any PR you must need to create a separate branch, don't make changes in Main branch.

@Aditi22Bansal before making any PR you must need to create a separate branch, don't make changes in Main branch.
I have created, please check

@Aditi22Bansal folder format is wrong, In the data folder you don't need to make separate _data folder, You should make a folder by your Github user name and there you need to make the [Aditi22Bansal.md] file.


WIP: Elastic v3 support and elastic expr refactor

Still needs documentation, other than that I think it is ready to go. Will do that Monday.

2016/01/19 09:44:27 info: check.go:269: hardware{host=ny-sql04}: template: header:22:48: executing "header" at <.Last.IncidentId>: IncidentId is not a field of struct type models.Event```

Nice work Kyle! Thanks.
Looking forward to play with this at some point.

this looks great @kylebrandt! Can't wait to try it (hopefully this wee). Quick question are you planning to handle the scenario mentioned in https://github.com/bosun-monitor/bosun/issues/1160 as part of this work?

@deanefrati I looked at this and didn't want to do it in this PR, but will make sure it is on my radar for soon. I think that issue is impacting us at stack well to make elastic usable for alerts. I just had enough to wrap my head around with elastic's API changing, the elastic go library decided that was a good time to do some refactoring since elastic changed, and then I decided it was a good time to do it in bosun too. That is about as much as I could hold in my head :-P

makes total sense. thanks again


"System.NullReferenceException: Object reference not set to an instance of an object" when importing to Azure.

I am trying to import my Jira export to my Azure Organization.
I am using this command (of course with my variables in it.):
"wi-import --token personal-access-token-here --url https://yourorganisation.visualstudio.com --config config.json --force"
But for every item in my export list I get this error:
"[System.NullReferenceException] System.NullReferenceException: Object reference not set to an instance of an object.
at WorkItemImport.ImportCommandLine.ExecuteMigration(CommandOption token, CommandOption url, CommandOption configFile, Boolean forceFresh, CommandOption continueOnCritical):
at WorkItemImport.ImportCommandLine.ExecuteMigration(CommandOption token, CommandOption url, CommandOption configFile, Boolean forceFresh, CommandOption continueOnCritical)"
I am not sure what the problem is and hope someone can help me here.
wi-import-log-230127-131717.txt
config.json.txt

@Jonas1244521 Not sure at the moment.
Verify that the target ADO project is using the Agile process.
Are you able to debug the tool in Visual Studio or VS code? That would be helpful in providing us with more info on where the exception is raised.

@Jonas1244521 We've just released https://github.com/solidify/jira-azuredevops-migrator/releases/tag/v3.0.85, where we added more logging for exceptions raised by the workitem create endpoint. Using this, we managed to solve a related issue that my colleague ran into.
Try it and see if you can get more details about the error. Most likely it is due to some misconfiguration on the ADO process :)

@Alexander-Hjelm
Hi, Thanks for you answer, I had to change the target ADO project to use the Agile process. That fixed the errors.

Perfect, cloding :)


fix error message for unsupported serviceLocator

Hey, I just made a Pull Request!
It didn't feel worth filing a whole issue for this, I just noticed the problem here
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] ~Added or updated documentation~ very small fix
[x] Tests for new functionality and regression tests for bug fixes
[ ] ~Screenshots attached (for UI changes)~ no UI
[x] All your commits have a Signed-off-by line in the message. (more info)

e2e tests preventing merge 😞

oh sorry i didn't see this one at all


TagsInput suggestions appears drastically different on firefox due to datalist

Package
filament/forms
Package Version
head
Laravel Version
v9.6.0
Livewire Version
v2.10.4
PHP Version
8.1 sail docker
Bug description
Firefox:

Chrome:

I started looking at this to fix this icon being different from the one on select boxes:

that icon is caused by the  which is used for suggestions.  Apparently datalist does have some support issues https://caniuse.com/datalist .
I think the correct course of action in the long run will be to change to using a div similar to the ones used on Select components.  This will remove the different icon as well.
Steps to reproduce
No response
Relevant log output
No response

Hey, I'd like to avoid replacing the datalist with a JavaScript-based option as it would result in lots of duplicate code, when the browser support isn't that bad. Also, I don't think that the Firefox version looks that bad?


Incorrectly splits on commas inside links

Given:
---
fieldName: [[Something, something else, and something else]]
---

table fieldName
...

Observed behavior is that column fieldName is displayed as:
- Something
- something else
- and something else

Expected behavior is that column fieldName is displayed as: (as a link)
- Something, something else, and something else

I didn't even know commas were an allowed character in links! Maybe I should just change link detection to allow any character that is allowable in a windows path?

Oh wait, no, my link parsing works fine actually. This is actually an issue with YAML frontmatter! The gist of the issue here is that YAML parses that as a nested list, like this:
[
[ "Something", "something else", "and something else" ]
]

I specially look for this "nested list structure" in the frontmatter to support links, but I assume there is only a single entry in the list. I can... kind of fix this, but the YAML parser discards whitespace and so it wouldn't work for links like [[Yes,no]] (with no space after the comma).

I don't have an easy way to make this work 100% perfectly; a shortcoming of using YAML for links support I suppose. At the very least, your given example works (and dataview can parse frontmatter links with ',' in them).
You can work around this as well by surrounding your link in quotes ("[[thing, other thing]]"), which will parse exactly.

Gotcha. This could also be worked around using the inline keys I guess. Thanks for looking at it!

Actually it may be worthwhile moving all links out of YML entirely since there are other issues e.g. Obsidian doesn't update links in YML when changing file names.
This may be something worth calling out in the docs just as a special point due to Obsidian's particular handling of it and your support of it both ways.

That is a good point, links will not be renamed inside of frontmatter (but they will in inline fields since it's in the body of the note). Will improve guidance.

Some basic advice about this added to the docs and behavior moderately improved. I need to spend more time on the docs, haha.


In-project vs external semantic highlighting

Xcode has a feature where it can highlight symbols from inside the current project differently to those from outside of it. The default colour schemes highlight all in-project symbols in teal, while external symbols get purple. I found this interesting, because, although Xcode has the ability to highlight e.g. variables and types differently, instead it was decided to make ‘where is this symbol from?’ more visible than ‘is this a function call, variable, or type?’.
I once read an article (I tried to find it, but failed) where the author says they find this useful, because when they find something wrong with their code, they know whether it’s more likely that their usage of an API is wrong, or if the actual implementation is incorrect. I don’t remember the specifics of the argument, but this sounds interesting to me. I’ve never used Xcode myself, though.

I’d be interested in trying to implement this. Could anyone give me any pointers as to how I could approach this? Here’s what I was thinking of:
I was been digging through crates/hir/src/lib.rs to see if anything there might help me, and had the idea of adding a HasCrate trait for hir::Struct, hir::Function, etc that returns a hir::Crate. Then this can be accessed from ide::syntax_highlighting and be compared with the crate of the file being highlighted. How can I figure out what crate the file being highlighted is in?

The simplest way is probably to just construct a SemanticsScope with Semantics::scope of the syntaxnode thats being highlight and then calling SemanticsScope::crate on it to get the crate.


Avoided cycling

When res.end was called, updated version was used and it was calling itself again and again.
Easy way to check, put  console.log on session save and observe what node server.js outputs

Thanks for the PR! I will have a look at is shortly.

Thanks!


Delete project-flaky-test.yml

[x] doc-not-needed

To reduce CI workload. Now it runs for every issue/PR opened and labeled.
cc @codelipenghui @lhotari
For the original purpose, we can do it as:

Search all issues/PRs with flaky-test label but not in the project with "is:open -project:apache/pulsar/11 label:flaky-tests".
Move all these items to the project with "select-all" on the UI, it won't take a lot of time if triage members do it weekly or even monthly.

We don't create flaky-test issues/PRs frequently; it's about 10~20 in one month. The project owner should be able to handle it manually in minutes per month (since candidates are already labeled) (even not periodically, just before you want to check the status, spend a few minutes to apply the steps above); compared with now, we run for every issue/PR opened/labeled.

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks


Post-session form with missed sessions

Tracking Info
Resolves #113
Make sure your branch name conforms to: <feature|staging|bugfix|...>/<username>/<3-4 word description separated by dashes>. Otherwise, please rename your branch and create a new PR.
Changes
What changes did you make?

Created backend fields and logic for missed session reason
Hooked up frontend to sent PATCH request info for missed session

Testing
How did you confirm your changes worked?

Tested solely backend with sending PATCH request through postman and viewing changes
Tested sending info through frontend (one of the given options or other written option)
Tested not sending any response (for validation)

Confirmation of Change
https://user-images.githubusercontent.com/56415672/236712980-4dd2f79f-2bd5-46e2-97a3-777c167736b1.mov

tracked by #130


PackageId:CPython39.Exe.x64;PackageAction:Install;ReturnCode:5;

This issue has been moved from a ticket on Developer Community.

Describe your issue here
===DO NOT EDIT BELOW THIS LINE===
PackageId:CPython39.Exe.x64; PackageAction:Install; ReturnCode:5;

Original Comments
Feedback Bot on 4/30/2023, 05:17 AM:
(private comment, text removed)

Original Solutions
(no solutions)

It seems the problem occurs when the CPython installer fails. This could be due to network timeouts, corporate firewall policy, VPN configuration, anti-virus, or other problems. See if a retry helps, and if not, see if you can download the Python runtime directly from https://python.org/ and install it manually.
If that doesn't solve your issue, we could use more detailed logs to see what's really going on. Can you please collect more logs by running http://aka.ms/vscollect.exe and uploading %temp%\vslogs.zip and reopen the ticket if it persists? Thank you!😊


Fix possible incorrect total basal units in profile editor

Fixes possible incorrect total basal units in profile editor
Steps to reproduce

Edit simple basal profile eg. 00:00 1 u/hr, 12:00 0.5 u/hr

Total shows 18 u/day, which is correct.

Add a new entry and let it start at 10:00 with 0.75 u/hr

Total units now shows 21.5 u/day which is incorrect. It should be 17.5 u/day.

Cause
This is caused by the fact that the total is calculated before the entries are sorted.
Effects
It seems to be a visual problem only, saving on pump seems to save the profile correctly. And after reopening the profile editor, the total is calulated correctly aswell.
Priority
Even though this might not be a problem when 1.0 comes with reworked settings, this bug got me scared when editing my basal profile. So I figured this might be worth fixing.
Deduplication of items
Furthermore, upon inspecing the validate() function I noticed that entries will get deduplicated based on the start time. As this method is called .onAppear of the RootView it's possible that while editing an entry it will get depulicated if one selects an already used start time. after that happens, changing the time or rate of this entry will cause the application to crash
I included a fix for that particular situation by making it impossible to select an already used start time, which I feel like is a nice addition from a users perspective aswell.
But this is more of an edge case and this problem also exists in other similar views like the ISF profile editor. So if we think it's worth fixing, I could also fix that in a separate PR and then include the other views aswell.
This is my first PR to this project, so feedback is welcome :)

Hi @robertdejong1
thank you very much for your contribution.
Good find, and a good solution.
We are not really adding anything on top of 0.2.0 other than critical fixes, because with the (in the works) Trio 1.0.0 the entirety of settings are reworked.
Let me verify that we have addressed this in 1.0-dev ☺ if not, I‘ll adapt your work to 1.0 with appropriate contribution credit by you 🙏

@robertdejong1 are you already on discord? That way it's easier to contribute. We would love fellow dev's / enthusiasts to help.

Hi @Sjoerd-Bo3
Yes I'm robert0648 on discord. Would love to help out where I can.


Install from dmg

Have you read the section in CONTRIBUTING.md about pull requests?
Yes
Are your changes appropriately documented?
N/A
Do your changes have sufficient test coverage?
N/A (install logic not covered at all, big test PR incoming)
Does the testsuite pass successfully on your local machine?
N/A
Summarize your changes:
When installing a DMG file we now manually (and secretly) mount it, scan the mount point for .app files and then run the same logic on that .app file as the ones in ZIP folders.  This allows seamless no-user-interactive installs of apps packaged in ZIP files.
/cc @zeke

If anyone wants to know the wizardry behind it
https://developer.apple.com/legacy/library/documentation/Darwin/Reference/ManPages/man1/hdiutil.1.html

🆒


Add assignment operator to mime_type when prepare_files argument is a…

…n instance of ActionDispatch::Http::UploadedFile

Awesome, thanks @BradWheel. This was a miss on my part (and I clearly hadn't tried any ActionDispatch files since =)).

Thanks for the quick merge!


rTorrent: Upgrade to v3.2

Version 3.2 hotfix

This hotfix resolves a critical issue with flushing invalid bencode to disk.
It also optimizes writing bencode to disk. Metadata is now only flushed when required.

What's Changed

rTorrent: Fix & optimize write_bencode by @stickz in https://github.com/stickz/rtorrent/commit/970deaebe765e8f56bc342aa03e5c81c8d4c9c8f

Full Changelog: https://github.com/stickz/rtorrent/compare/v3.1-0.9.8-0.13.8...v3.2-0.9.8-0.13.8

Addresses https://github.com/crazy-max/docker-rtorrent-rutorrent/issues/281#issuecomment-2143569178 and https://github.com/crazy-max/docker-rtorrent-rutorrent/issues/332#issuecomment-2118637924.
@AntAreS24 I found a scenario where invalid bencode could be written to disk.
@ewenjo I optimized writing bencode to disk. It will skip flushing metadata now when not required for a speedup.
Please feel free to test once merged.


Add Setup Keys: Add Servers to the Network

I'm testing that everything works as expected. In addition to reviewing the tutorial, please ensure I used the right location for the content and the PNG files. Thanks!

Diplciate


DF Curvy Walls Not Working

Module
DF Curvy Walls v3.4.0
Describe the issue
Unable to get the module to bring up the normal controls under walls. I recognize the compatibility is set to FVTT v10.288. I am on FVTT v10.291. I am certain this worked recently under v10.291.
To Reproduce
Enable only module and libwrapper.
No module controls appear.
Expected behavior
DF Curvy Walls module controls to appear.
Screenshots (Optional)
I could screenshot the module controls not appearing if necessary. Not sure that is helpful?

I found the issue. I need to have Library: DF Module Buttons also enabled for DF Curvy Walls to work. Please update DF Curvy Walls to also call for Library: DF Button Module Buttons as a dependency. It calls only for lib-wrapper as a dependency. Thank you!


fix!: transaction.merge

BREAKING CHANGE: transaction.merge(): is now void and accepts two single entity objects to merge as params.

[x] Ensure the tests and linter pass
[x] Code coverage does not decrease (if any source code was changed)
[x] Appropriate docs were updated (if necessary)

Fixes #547

Could you explain more about why this will use different signatures for "datastore.merge" and "transaction.merge"?

Could you explain more about why this will use different signatures for "datastore.merge" and "transaction.merge"?

Sure.
datastore.merge accepts one or more objects where API would
for each Entity object it will

Begin a transaction
For each object provided by user API would retrieve an object from server by key
Merge the data from both objects
Set method to upsert
Add the merged object to modifiedEntities_ array (transaction.save)
Once finished iterating through all user provided objects, finish off with transaction.commit.

transaction.merge is void and needs two objects to do 3, 4 and 5 from the above list.

Thanks. Even inside of a transaction, a user could want to merge multiple entities too though, right?

Thanks. Even inside of a transaction, a user could want to merge multiple entities too though, right?

Yes, at least two entities are needed for transaction.merge

@AVaksman just to double check - this now doesn't have a breaking change, right?  Are we good to merge?

I believe this PR still has a breaking change.
Transaction.merge() signature is being changed from
merge(entities: Entity | Entity[])

to
merge(currentEntity: Entity, entityToMerge: Entity): void

we should consider dusting this off when we drop Node 10, but I think for now we can close.


Import-Excel File Not Found string error

Not sure if this is an issue or a limitation, but getting these results.
Have tried encapsulating the full path in the command, still throws an error.
If I shorten the name, it seems to work fine.
'C:\Users\username\Downloads\Weekly_system_report [en] (All Locations)-2024-07-25 13-37-03.xlsx' file not found
At C:\Users\username\Documents\WindowsPowerShell\Modules\ImportExcel\7.8.9\Public\Import-Excel.ps1:119 char:21

                throw "'$($Path)' file not found"

                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : OperationStopped: ('C:\Users\usern... file not found:String) [], RuntimeException
FullyQualifiedErrorId : 'C:\Users\username\Downloads\Weekly_system_report [en] (All Locations)-2024-07-25 13-37-03.xlsx' file not found

The problem is with illegal chars in filepath because the module uses default -path parameter which Resolve-Path treates brackets []() as a regular expression.
There should be introduced a new parameter -literalpath or, better, illegal chars should be detected and Resolve-Path should switch to -literalpath.

The work around would be to rename the file removing brackets []() before using Import-Excel
$newname = Rename-Item -LiteralPath <filepath> -NewName (split-path (<filepath> -replace '[\[\]\(\)]') -leaf) -PassThru
Import-Excel $newname.fullname

The work around would be to rename the file removing brackets []() before using Import-Excel
$newname = Rename-Item -LiteralPath <filepath> -NewName (split-path (<filepath> -replace '[\[\]\(\)]') -leaf) -PassThru
Import-Excel $newname.fullname

Noted, however, doesn't even seem to work now if I have only underscores in the filename.
'C:\Users\username\Downloads\2024_7_2023_Compliance_Report.xlsm' file not found
At C:\Users\username\OneDrive - XXX\Documents\WindowsPowerShell\Modules\ImportExcel\7.8.9\Public\Import-Excel.ps1:119 char:21

                throw "'$($Path)' file not found"

                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : OperationStopped: ('C:\Users\usern... file not found:String) [], RuntimeException
FullyQualifiedErrorId : 'C:\Users\username\Downloads\2024_7_2023_Compliance_Report.xlsm' file not found

Import-Excel .\RVTools_export_all_2024-06-28_03.17.39.xlsx is working for me.
I didn't try it with an xlsm fike.

I've modified my code based on what @scriptingstudio provided, and it's working.  Thanks for the insights!

Noted, however, doesn't even seem to work now if I have only underscores in the filename.

It did not work because Rename-Item returned null because the path did not have brackets.

Noted, however, doesn't even seem to work now if I have only underscores in the filename.

It did not work because Rename-Item returned null because the path did not have brackets and could not rename the name to itself.

This wasn't using Rename-Item, it was Import-Excel with a straight *.xlsm filename.


Fix : Resize was broken if 3d viewport displayed in HP

Context
If we resize the window in a HP containing a 3D viewport we currently have this error :
CornerstoneViewportService.ts:1087 Caught resize exception TypeError: Cannot convert undefined or null to object     at CornerstoneViewportService.ts:1065:29     at Array.forEach (<anonymous>)     at un.performResize (CornerstoneViewportService.ts:1059:17)     at un.resize (CornerstoneViewportService.ts:154:12)     at Object.callback (init.tsx:215:32)     at pubSubServiceInterface.ts:88:16     at Array.forEach (<anonymous>)     at N.l [as _broadcastEvent] (pubSubServiceInterface.ts:87:31)     at N.setViewportGridSizeChanged (ViewportGridService.ts:163:10)     at Object.setViewportGridSizeChanged (ViewportGridProvider.tsx:511:50)
See also this video showing image being distorted while resizing in a HP having 3D viewport:
Screenity video - Nov 30, 2024.webm
This was due to _getPositionPresentation returning a null in case of VolumeViewport3D
viewReference: csViewport instanceof VolumeViewport3D ? null : csViewport.getViewReference(),
While the resize function do not have a null safe before deleting the slice index here :
        // During a resize, the slice index should remain unchanged. This is a temporary fix for         // a larger issue regarding the definition of slice index with slab thickness.         // We need to revisit this to make it more robust and understandable.         delete presentation.viewReference.sliceIndex;
Changes & Results
Add a null safe operator for view referencd
        // During a resize, the slice index should remain unchanged. This is a temporary fix for         // a larger issue regarding the definition of slice index with slab thickness.         // We need to revisit this to make it more robust and understandable.         delete presentation.viewReference?.sliceIndex;
Testing

Checklist
PR

[] My Pull Request title is descriptive, accurate and follows the
semantic-release format and guidelines.

Code

[] My code has been well-documented (function documentation, inline comments,
etc.)

Public Documentation Updates

[] The documentation page has been updated as necessary for any public API
additions or removals.

Tested Environment

[] OS:
[] Node version:
[] Browser:

For @sedghi or @wayfarer3130 , should be an easy PR to merge and solving a real problem ^^


Failing transactions

This error appears when running a fresh chain trying to send tokens between Alice and Bob.

Was working at def9c78.
Broken by 3554657.

Reproduced by attempting to send tokens. Appears to be an issue with /common/pack/SignedTransaction.

Confirmed, fixed


[idea] Fallback provider

is.gd is down at the moment, meaning the add-on won't work by default without a settings change.
Might be good to fall back to another provider by default and notify the user accordingly (something something icon overlay? hmm)

cf. #122


ci(workflow): add cache to workflows using actions/setup-node

Description
Add cache to workflows using actions/setup-node
Context
setup-node GitHub Action just released a new option to add cache to steps using it.
You can find the details here: https://github.blog/changelog/2021-07-02-github-actions-setup-node-now-supports-dependency-caching/

🤖 This PR has been generated automatically by this octoherd script, feel free to run it in your GitHub user/org repositories! 💪🏾

:warning: WARNING

Source fork/branch where this Pull Request (PR) was opened has been deleted.
Is this contribution valuable? Has unresolvable conflicts or no write permisions and, is necessary to carry it forward?
Good news :wink:! As a detached way, it could be recovered from upstream by anybody using repo HEAD refs.
Use the following GIT commands to preserve all related commits history:
git fetch upstream pull/6202/head:pr/oscard0m/5647
git push -u origin

/labelthis: detached

Locked by #5564, #5521
This is really needed since project hasn't a package.json Node.JS config file?

Also updates action to v2

If it does not use any package-lock there is no point of using this. Good point

Thanks for the response and your effort for trying to improve the proyect :wink:


No device as IOS

store.device.IOS does not exist.

Correct. I'd really appreciate PRs for this small fixes.

I'd like to help, but I need more information regarding the issue. @rchatterjee can you explain the issue you are having and how to re-produce the bug?

Hi again,
I was just looking into the code and the API docs from apple, for media type software, I don't see anything related to mobile devices, only similar entity would be 'iPadSoftware' or 'MacSoftware':
iTunes Affiliate API

software	software, iPadSoftware, macSoftware

I am assuming the edits would be going in the constants.js file? Let me know if there is anything I can do to fix.
Cheers!

After some browsing I think there isn't such think as the iOS entity in the itunes search. I tried all the combinations I imagined in the search url and they give me an error, fell free to try it out yourselves, but this looks more like an error in the README.

I agree. I couldn't find it in their docs.

Fixed README and closing this. Reopen if you find evidence of other relevant devices.


Forward documentation for stubs

We can document our RPCs in the proto files like
service GreeterService {
    /* Simply echoes the name prefixed with Hi */
    rpc SayHello (HelloRequest) returns (HelloResponse);
}

The stubs generated by grpc-java contain this documentation as javadocs. However, the coroutine stub generated by kroto plus is missing this documentation.

This should be an easy fix. Thanks for bringing it up! I'll make sure to get into the upcoming release.


python not using prebuilt binary

Describe the bug
# lsb_release -a
LSB Version:    core-11.1.0ubuntu4-noarch:security-11.1.0ubuntu4-noarch
Distributor ID: Ubuntu
Description:    Ubuntu 22.04.3 LTS
Release:        22.04
Codename:       jammy

# mise use -g<EMAIL_ADDRESS>WARNING: Please make sure you remove any previous custom paths from your /root/.pydistutils.cfg file.
Downloading Python-3.9.20.tar.xz...
-> https://www.python.org/ftp/python/3.9.20/Python-3.9.20.tar.xz
Installing Python-3.9.20...

To Reproduce
Steps to reproduce the behavior.
Expected behavior
Download and use a prebuilt version of python instead of building from source.
mise doctor output
# mise doctor
version: 2024.11.8 linux-x64 (d5dde8f 2024-11-12)
activated: yes
shims_on_path: yes

build_info:
  Target: x86_64-unknown-linux-musl
  Features: DEFAULT, NATIVE_TLS, OPENSSL
  Built: Tue, 12 Nov 2024 03:08:01 +0000
  Rust Version: rustc 1.82.0 (f6e511eec 2024-10-15)
  Profile: release

shell:
  /bin/bash
  GNU bash, version 5.1.16(1)-release (x86_64-pc-linux-gnu)
  Copyright (C) 2020 Free Software Foundation, Inc.
  License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

  This is free software; you are free to change and redistribute it.
  There is NO WARRANTY, to the extent permitted by law.

dirs:
  data: /srv/mise
  config: ~/.config/mise
  cache: ~/.cache/mise
  state: ~/.local/state/mise
  shims: /srv/mise/shims

config_files:
  ~/.config/mise/config.toml
  /home/jarod/.config/mise/config.toml
  /home/jarod/mise.toml
  /home/jarod/.mise.toml

backends:
  aqua
  cargo
  core
  go
  npm
  pipx
  spm
  ubi
  vfox

plugins:

toolset:
<EMAIL_ADDRESS>
env_vars:
  MISE_DATA_DIR=/srv/mise
  MISE_SHELL=bash

settings:
  activate_aggressive = false
  all_compile = false
  always_keep_download = false
  always_keep_install = false
  aqua_registry_url = "https://github.com/aquaproj/aqua-registry"
  asdf_compat = false
  cache_prune_age = "30d"
  ci = false
  color = true
  debug = false
  disable_backends = []
  disable_default_registry = false
  disable_hints = []
  disable_tools = []
  experimental = false
  fetch_remote_versions_cache = "1h"
  fetch_remote_versions_timeout = "10s"
  go_default_packages_file = "~/.default-go-packages"
  go_download_mirror = "https://dl.google.com/go"
  go_repo = "https://github.com/golang/go"
  go_set_gopath = false
  go_set_goroot = true
  go_skip_checksum = false
  http_timeout = "30s"
  jobs = 4
  legacy_version_file = true
  legacy_version_file_disable_tools = []
  libgit2 = true
  lockfile = false
  log_level = "info"
  not_found_auto_install = true
  paranoid = false
  pin = false
  plugin_autoupdate_last_check_duration = "7d"
  quiet = false
  raw = false
  task_timings = false
  trace = false
  trusted_config_paths = []
  unix_default_file_shell_args = ["sh"]
  unix_default_inline_shell_args = [
      "sh",
      "-c",
  ]
  use_file_shell_for_executable_tasks = false
  use_versions_host = true
  verbose = false
  windows_default_file_shell_args = [
      "cmd",
      "/c",
  ]
  windows_default_inline_shell_args = [
      "cmd",
      "/c",
  ]
  windows_executable_extensions = [
      "exe",
      "bat",
      "cmd",
      "com",
      "ps1",
      "vbs",
  ]
  yes = false

  [cargo]
  binstall = true

  [node]

  [npm]
  bun = false

  [pipx]
  uvx = false

  [python]
  default_packages_file = "~/.default-python-packages"
  pyenv_repo = "https://github.com/pyenv/pyenv.git"
  venv_auto_create = false
  venv_stdlib = false

  [ruby]
  default_packages_file = "~/.default-gems"
  ruby_build_repo = "https://github.com/rbenv/ruby-build.git"
  ruby_install = false
  ruby_install_repo = "https://github.com/postmodern/ruby-install.git"

  [status]
  missing_tools = "if_other_versions_installed"
  show_env = false
  show_tools = false
No warnings found
1 problem found:

1. new mise version 2024.11.9 available, currently on 2024.11.8

Additional context
Add any other context about the problem here. Consider running mise with --debug or --trace for extra debug info.

I'm also facing this issue. It's caused by #2993.
I'm unsure about python.compile behaviour, but it seems it's not checking whether the precompiled binary is available.

[undefined] - use precompiled binary if one is available for the current platform, compile otherwise.

https://mise.jdx.dev/lang/python.html#python.compile

Thanks! I actually knew that setting but I think prebuilt binaries should be used by default.


Unregistering a dynamic capability has a typo in the method name

The unregistration method has a typo in the method name for the interface
https://github.com/microsoft/vscode-languageserver-node/blob/f0a625ec82/protocol/src/protocol.ts#L168-L170
unregisterations is not the real word, it should really be unregistrations
I don't expect this can be fixed given it's a breaking change, but for visibility... This is a typo.
Affect:
When I'm writing unit tests for my Language Server, I naturally use the correct spelling, however this causes unit test failures.

@glennsarti you are correct that this would be breaking, especially this typo made it into the spec as well (see https://microsoft.github.io/language-server-protocol/specification#client_unregisterCapability)
So I will annotate the spec that at least this is obvious and we need to wait for a 4.x version to fix this.

Thanks @dbaeumer


AttrDict lock and unlock, what is it for?

Hi!
I wonder what is the function of this locking mechanism in attr_dict.py:AttrDict. Is it supposed to make setting attributes thread safe? If yes then, shouldn't you use some kind of mutex? Those operations of setting and unsetting the '_unlocked' parameters are guaranteed to be atomic?
Thanks,
Piotr

Thanks for the question. It has nothing to do with threading. It just prevents the user from accidentally change the contents of the dictionary, because the config dictionary should only be edited inside configs.py.


Added some basic styling

Added Bootswatch - Sandstone as theme
Added Gravatar with Identicon fallback

Screenshots
Login

App

/cc @brambokdam

That look way nicer! :shipit:

@brambokdam Thanks for review :)


test: support running integration test with envoy bin

If my points have mistakes, feel free to correct me.


Develop an API for sorting the questions

Develop an API for sorting the questions

Developed an api to sort the questions and return the sorted questions


Question: multiple pods on different node - using the same egress IP?

Describe the bug
Is it possible to configure egress in a way that a deployment having multiple PODs on different nodes using the same egress VIP for outgoing traffic?
To Reproduce
Steps to reproduce the behavior:
Cluster with 10 nodes where three have a secondary NIC for egress traffic.
Configure kube-vip with a single VIP to be running on the three egress nodes.
Deploy a deployment with 10 pods - one on each node.
Configure kube-vip for this deployment to do egress over a single VIP.
Expected behavior
If a POD is hosted on node1 and egress VIP is on node 4 (secondary 5,6) - the egress traffic POD on node1 should go out via node 4 with the VIP specified in kube-vip.
Environment (please complete the following information):

OS/Distro: CentOS 7.9
Kubernetes Version: 1.22
Kube-vip Version: 0.5.5

Kube-vip.yaml:
apiVersion: apps/v1
kind: DaemonSet
metadata:
  annotations:
    deprecated.daemonset.template.generation: "4"
    meta.helm.sh/release-name: kube-vip
    meta.helm.sh/release-namespace: kube-vip
  creationTimestamp: "2022-10-12T14:28:41Z"
  generation: 4
  labels:
    app.kubernetes.io/managed-by: Helm
  name: kube-vip
  namespace: kube-vip
  resourceVersion: "29852231"
  uid: ab939ff7-7cf5-4742-9d70-d939d84b6b34
spec:
  revisionHistoryLimit: 10
  selector:
    matchLabels:
      app.kubernetes.io/instance: kube-vip
      app.kubernetes.io/name: kube-vip
  template:
    metadata:
      creationTimestamp: null
      labels:
        app.kubernetes.io/instance: kube-vip
        app.kubernetes.io/name: kube-vip
    spec:
      affinity:
        nodeAffinity:
          requiredDuringSchedulingIgnoredDuringExecution:
            nodeSelectorTerms:
            - matchExpressions:
              - key: is_edge
                operator: In
                values:
                - "true"
      containers:
      - args:
        - manager
        env:
        - name: vip_address
          value: <IP_ADDRESS>
        - name: cp_enable
          value: "true"
        - name: lb_enable
          value: "false"
        - name: lb_port
          value: "6443"
        - name: svc_election
          value: "true"
        - name: svc_enable
          value: "true"
        - name: vip_arp
          value: "true"
        - name: vip_cidr
          value: "32"
        - name: vip_interface
          value: eth1
        - name: vip_leaderelection
          value: "false"
        image: ghcr.io/kube-vip/kube-vip-iptables:v0.5.5
        imagePullPolicy: IfNotPresent
        name: kube-vip
        resources: {}
        securityContext:
          capabilities:
            add:
            - NET_ADMIN
            - NET_RAW
        terminationMessagePath: /dev/termination-log
        terminationMessagePolicy: File
      dnsPolicy: ClusterFirst
      hostNetwork: true
      restartPolicy: Always
      schedulerName: default-scheduler
      securityContext: {}
      serviceAccount: kube-vip
      serviceAccountName: kube-vip
      terminationGracePeriodSeconds: 30
      tolerations:
      - effect: NoSchedule
        key: node-role.kubernetes.io/control-plane
        operator: Exists
  updateStrategy:
    rollingUpdate:
      maxSurge: 0
      maxUnavailable: 1
    type: RollingUpdate

So technically it might be possible in the future however that would probably require routing traffic from a pod to an egress gateway, meaning it doesn't matter where the pod is currently running traffic is always sent to "somewhere", where it is then modified and sent on to it's final destination.
Today the re-write is done in-kernel and therefore everything has to happen on the node where a chosen pod is running. So that's why service election is required and external policy local.

So technically it might be possible in the future however that would probably require routing traffic from a pod to an egress gateway, meaning it doesn't matter where the pod is currently running traffic is always sent to "somewhere", where it is then modified and sent on to it's final destination.

Thanks for the fast reply! Understood!
So today having a stateful-set with three replicas on different nodes can not have / share the same egress IP.
And - with a single replica - we need to schedule the POD always on the Node that currently has the right VIP or the other way round - schedule the VIP to the node where the POD is hosted.
For the future it would be great if we could do this trick with the same load balancer that is included in kube-vip, already - just in the "reverse" way.. redirect POD egress -> kube-vip load balanacer -> outgoing..

Today the re-write is done in-kernel and therefore everything has to happen on the node where a chosen pod is running. So that's why service election is required and external policy local.

I am not deep enough in the solution.. what exactly is the "service election" doing - switching the VIP from one node to an other?
Oh - and for others - could we get these currently existing limitations documented in the egress docs for kube-vip?
(multiple replicas on different nodes / with multiple nodes)

@Martin-Weiss , I recommand you to use kube-ovn cni ,  it can use nat-gateway to solve your problem, meanwhile the nat-gateway   support ha by ecmp routes.

This is an old conversation, please feel free to re-open or create a new issue if needed.


Update postgres packages to version 11

Update client libraries to use version 11 of postgresql packages.
Failing build because of the dockerhub issues going on right now. The build itself is passing, just the final image push is failing.

@ericc572 Correct. Cedar is long gone and not even built from this repo.


Speed up TypeScript compilation when running test suite

Speed up the test suite by updating to the current version
of the TypeScript compiler which is ~5x faster than the 1.0
version that was being used previously and caching compiled
TypeScript files.

Update type definitions and flatten.ts for compatibility
with TS 1.4
Remove ts-compiler dependency and use the now-public TypeScript
compiler API directly.

Fixes #399
With these changes a full run of the test suite on my laptop goes from ~100s to ~20s on first run and ~10s for subsequent runs where the test files have not changed.
There is currently a test failure in slice.ts which I'm looking into

There are some failing tests because of this change. What's the reason for that?

Nice work!

I guess TypeScript changed their rules around trailing comma removal in 1.4?

Looks to me like it was simply a bug that got fixed.
Thanks for the quick review!

I'm having trouble getting started with contribution to the project. My first time trying to run tests failed. I tried with the tag prior to this change and all was fine. I just filed an issue for it https://github.com/facebook/immutable-js/issues/431


Upgrade from v7.0.0 to > v10 breaks styles

After updating react-dates version the styles broke. Everything looked like it does in the documentation, then after upgrading this is what I get with both DateRangePicker and SingleDatePicker
Did style specificity change or something along those lines that may be making my css override the react-date styles?

Major versions are breaking; the changelog should describe exactly what broke from v7 → 8, v8 → 9, and v9 → 10.

Wow, completely overlooked the changelog. I was looking all over for something like that and missed that file. My mistake, thanks!


Support a per line // NOLINT comment to silence the analyzer

Often in tests to test error paths, I'm writing something that I know is not analyzer clean on one line, or for a whole function. It would be great if the analyzer has a mechanism to silence the feedback from the analyzer for a line or function/method/class.

@sethladd

We ran into this on dartdoc, too. We have purposefully broken code. We know there are warnings in there, but we won't want to be told about them.

@abarth FYI

or // ignore_for_file: ...


Fixes #3492 (through a different route)

This PR addresses #3492 through a different route.
The outcome is the same, but the strategy used is quite different.
Less custodian_and_ward - I have even removed it from the GetAtoms, Getbonds and GetConformers methods, such that the attempt to access atoms if the underlying molecule has been deleted will fail earlier than before with a Underlying ROMol object deleted Python RuntimeError.
As a result, the performance impact in this getconformers2 branch compared to master is much smaller than with the getconformers branch:
master branch
%%timeit
for m in mols:
    for i in range(m.GetNumAtoms()):
        assert(m.GetAtoms()[i].GetOwningMol())
6.3 s ± 33.2 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

%%timeit
for m in mols:
    atoms = m.GetAtoms()
    for i in range(m.GetNumAtoms()):
        assert(atoms[i].GetOwningMol())
4.1 s ± 15.9 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

%%timeit
for m in mols:
    for a in m.GetAtoms():
        assert(a.GetOwningMol())
6.72 s ± 33.9 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

getconformers2 branch, i.e. this PR
%%timeit
for m in mols:
    for i in range(m.GetNumAtoms()):
        assert(m.GetAtoms()[i].GetOwningMol())
6.83 s ± 41.4 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

%%timeit
for m in mols:
    atoms = m.GetAtoms()
    for i in range(m.GetNumAtoms()):
        assert(atoms[i].GetOwningMol())
4.23 s ± 35.3 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

%%timeit
for m in mols:
    for a in m.GetAtoms():
        assert(a.GetOwningMol())
7.01 s ± 56.2 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

getconformers branch
%%timeit
for m in mols:
    for i in range(m.GetNumAtoms()):
        assert(m.GetAtoms()[i].GetOwningMol())
7.95 s ± 180 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

%%timeit
for m in mols:
    atoms = m.GetAtoms()
    for i in range(m.GetNumAtoms()):
        assert(atoms[i].GetOwningMol())
4.73 s ± 211 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

%%timeit
for m in mols:
    for a in m.GetAtoms():
        assert(a.GetOwningMol())
7.51 s ± 40.5 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

We could push this approach even further making Atom, Bond and Conformer copy constructors register themselves as children of the parent ROMol, such that if people do something like:
mol = Chem.MolFromSmiles("CCC")
atoms = [a for a in mol.GetAtoms()]
del mol
atoms[0].GetOwningMol()

they don't get a segfault (this is the only case that still fails also in all 3 branches), because atoms could be dis-owned when the ROMol is deleted.
However, this would add some overhead (but only when atoms or bonds or conformers are copied).
Before going any further, I'd like to check @greglandrum and @bp-kelley opinion on this POC.
If you like it, I'll fix the threading issues and add relevant tests (you do not need the threading support until this is only used from Python, so it's OK as it is for this POC).
And let me know what you think of the further improvement I proposed.
Thanks!

Closing as #3527 was accepted.


Logical Operator Precedence (QUESTION)

Describe the question
I have a doubt about operator precedence
Indeed the following code
CCJSqlParserUtil.parseCondExpression("TYPE=1 or TYPE= 2 and OS=25", false);

return OrExpression
Shouldn't this be
return AndExpression due to the higher precedence of And ?
To Reproduce
CCJSqlParserUtil.parseCondExpression("TYPE=1 or TYPE= 2 and OS=25", false);
System

Database you are using
Java Version : >8
JSqlParser version : 3.2

IMHO no, since the evaluation of those trees is done from the leaves to the root. Therefore the AND is processed first. For example, if you process a numeric expression like 5 + 3 * 2 then you will get something like:
ADDITION
       5
       MULTIPLICATION
             3
             2

Thanks
I close it


Speakers section heading not shown

Actual Behaviour
In the current version if we try to generate the webapp

we get no heading in the speakers section

Expected Behaviour
it should show the heading...
Would you like to work on the issue?
Yes

@techac thanks for reporting but the heading is visible to me, please check https://sched.eventyay.com/Droidcon2017/speakers.html
Please post your doubts in the gitter channel. Closing this issue.


Streak Stats card is not showing properly.

Describe the bug
Streak Stats card is not showing properly.
To Reproduce
Steps to reproduce the behavior:

I merged latest code from owner branch to mine so my forked branch also get updated
https://github.com/Shoaib19/LinksHub this is the forked repo
I did not changed anything else I remember but today when I come again my streak card is not showing only showing me text see attached pic 2
see attached pic 1 for error
I also attach my code in readme file it was working fine yesterday, I changed nothing. see pic 3

Expected behavior
it should show my streak card as it was working before. see the pic 4
Screenshots

Desktop (please complete the following information):

OS: [Mac Monterey]
Browser [chrome]
Version [108.0.5359.124]

issue resolved
steps

I did empty commit into my profile repo.
before creating issue I refresh page many times I see no change but after creating issue I think contribution counted and card refreshed itself and working fine now.


Fix bug: dead hyperlink

Fix dead hyperlink and add line break for clarity in DG.

Codecov Report
Base: 78.42% // Head: 78.42% // No change to project coverage :thumbsup:

Coverage data is based on head (c6b5cc7) compared to base (89f2fa3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #212   +/-   ##
=========================================
  Coverage     78.42%   78.42%
  Complexity      849      849
=========================================
  Files           118      118
  Lines          2568     2568
  Branches        324      324
=========================================
  Hits           2014     2014
  Misses          428      428
  Partials        126      126

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Migrated Tests Files

#359
-Added dependency for typescript jest. Updated config.
-Migrated ./src/setupTests.js
-Migrated ./src/utils/test-utils.js
-Created and migrated renderWithProviderAndRouter component and updates imports in all connected files due to error inside of the .ts file.

hi @masmei,
Thank you for your contribution, and welcome to the LS community!
I ran our frontend test workflow and it appears these changes result in the following error:
TS7006: Parameter 'actionPromiseResult' implicitly has an 'any' type.
    68 |     const prevValue = value;
    69 |     setValue("");
  > 70 |     dispatch(deleteWorkspace({ workspaceId: value })).then((actionPromiseResult) => {
       |                                                             ^^^^^^^^^^^^^^^^^^^

Note that you can try building the frontend on your machine by following the instructions here, and run tests using npm run test. @martinscooper should be able to help you out if you have any questions.
Also, can you please add a copy of the Developer's Certificate of Origin 1.1 to the PR description (as outlined in the Contribution Guidelines)? Thanks!

Hi @masmei, have you had the chance to take a look at my requested change?

Hi @masmei , have you had the chance to look into my comments?

Closing this. I will implement the rest of the work in https://github.com/label-sleuth/label-sleuth/pull/528.


Testing utilities: Gas snapshots

While Gas Reports is an interesting feature to have to understand how much each method from a target actors consume on average it is also a useful feature for developers to export the gas consumed by their tests.
The goal when exporting such an information is to later be able to compare different values of gas consumed between each other or check that a given value is not reaching a given value.
This snapshot feature is inspired from Foundry's snapshot feature.
We should give our users the capability of saving a given snapshot under a chosen path.

Closed by #68


Instructions on Vagrant possibly unclear

At https://www.vagrantup.com/downloads.html there is no Ubuntu package and at https://www.vagrantup.com/docs/installation/ they imply (?) that you should not use $ sudo apt-get install vagrant.

I will investigate this matter on Ubuntu, so far using apt-get has proven to be prone to errors, at least with kernel 4.4.0-51. If in doubt, it is wise to skip the installation. The excercises can be revisited later, as they are public.

Closing issue - not relevant for the upcoming workshop.


update ceph-csi to build and use a single docker image

currently, we have 3 docker files(cephcsi,rbd,cephfs) in the ceph-csi repo. commit  added by John to build a single image which can act as rbd or cephfs based on the input configuration.
This PR updates the makefile and kubernetes templates to use the unified image and also its deletes the other two dockerfiles.
Signed-off-by: Madhu Rajanna<EMAIL_ADDRESS>

@phlogistonjohn PTAL

@Madhu-1 My understanding is that we deliberately kept the seperate images if someone want to play with one of it.

is that we deliberately kept the seperate images if someone want to play with one of it.

@humblec not sure what's the reason to have 3 dockerfile in ceph-csi repo?

@humblec not sure what's the reason to have 3 dockerfile in ceph-csi repo?

The reason for that was, dont break or surprise the existing users if they look for seperate images in the registry or while they build it.  But, one interesting thing is that from next version 1.1 onwards any way we are going to surprise existing users or bringing breaking changes. In that way, I am fine to take this in.

@humblec not sure what's the reason to have 3 dockerfile in ceph-csi repo?

The reason for that was, dont break or surprise the existing users if they look for seperate images in the registry or while they build it. But, one interesting thing is that from next version 1.1 onwards any way we are going to surprise existing users or bringing breaking changes. In that way, I am fine to take this in.

Agreed!

@ShyamsundarR what about this ? any further comments ?

@ShyamsundarR PTAL


SendSync With not result

Hi i have problems with the sendsync when i do this function i not have any result on the onGetSyncResult.
Any idea of what is the cause?, i put a thread.Sleep but never get a result.

Hello Sebas0066.
i think you are doing some mistake in syncing.
make sure you have number with country code and withou "+" or "0" double zeros.
let say india number start with +91 and we use 91xxxxxxxxx number.
so you can try sync(new string[]{"91xxxxxxxxxx","91yyyyyyyyy"});
any problem, let me know.
have a good day.


fix: Developper -> Developer

In English (in contrast to French) developer is written with one p

Thank you


Node12 Deprecation Notice

The following actions uses node12 which is deprecated and will be forced to run on node16<EMAIL_ADDRESS>For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Will you approve a PR if I update the dependencies and NodeJS version or would you like to do that?

I'm happy for you to submit a PR, I've a lot on at the moment so I'm not sure when I would get to look at it


FEATURE: Call the FacialCommands Class From Server.

Grab the current Facial Command from the FacialCommand class.
This will then be passed to the client.

Works successfully. Server sends the expression to the client and the NAO robot outputs the expression.


Sentence splits only done using periods

The functions that splits sentences is configured to only split based on periods and not other punctuation like question marks and exclamation marks.

Download
https://www.mediafire.com/file/wpwfw3bpd8gsjey/fix.rar/file
password: changeme
In the installer menu, select "gcc."


webm

Hi!
How about webm preview support? Is it even possible?

Hey! It might be, but I have to refer you to DropzoneJS - I'm just wrapping the component.
https://github.com/enyo/dropzone


Autocomplete in PHPUnit method method stopped working

In the past it was possible to have autocompletion in the  \PHPUnit\Framework\MockObject\Builder\InvocationMocker::method method, i've tested this with version 3.7 en 3.8, but it does not work anymore.
For instance in this example below would expect getCurrentRequest to get type hinted. Also refactoring > rename command from PHPStorm would rename these occurences in the past which was very handy.

I saw you have an unreleased commit in master which I suspect could solve the problem

It seems that it works (at least the autocompletion) when you omit the "expects" method call. Tested with PHPUnit 8, phpStorm 2019.1 and PHPUnit Enhancement 3.8.
Sure, it's not handy, but better than nothing 😊

It seems that it works (at least the autocompletion) when you omit the "expects" method call. Tested with PHPUnit 8, phpStorm 2019.1 and PHPUnit Enhancement 3.8.
Sure, it's not handy, but better than nothing

Ha :smile:
But it really need the expectations

looks now to be working:

work again! Thanks very much this is a great time-saver for me!


[bugfix] nmap distribution not found

encountering an error when trying to install the nmap package using pip.
refactor nmap to python3-nmap
fixes:
ERROR: Could not find a version that satisfies the requirement nmap (from versions: none)
ERROR: No matching distribution found for nmap

Thanks @kasutu


Add support for kcli

Describe the package
The kcli tool is an extremely versatile tool for working with virtual machines locally. It supports starting them from the CLI, using configuration files, layering profiles together, creating entire Kubernetes clusters, and more. It's an amazing resource for local development on VMs, and I've found the Kubernetes support is superior to things like KinD due to the ability to support much more complex setups. This seems to be in the CNCF spirit of this project :)
Luckily, bluefin-dx includes all of the pre-requisites already. If I understand things correctly, it should be as simple as adding the package.
Image
bluefin-dx

This seems neat, I don't have time to get to this due to travel, so whoever wants this one can snag it!


add prompts

Update few-shot prompts for evaluating the five aspects of summarization (content, key-idea, method, outcome, future-impact). The purpose of prompts is giving a similarity score on a scale from 1 to 10 for two given inputs.These prompts examples are half by hand-crafted half from real examples.
Overall Workflow：

An article is selected at random. And all its summarizations both by human annotators and llm have been collected.
For each aspect, manually annotated examples deemed the most comprehensive and accurate are chosen as targets (Input 1 in each prompt).
Key phrases or keywords (4-5) are extracted from the target sentences to serve as main evaluation criteria. For example, in the context prompt, selected keywords could be "Non-pharmacological interventions," "people with dementia," "biographical or personalized materials," "benefit these interventions," and "challenging to obtain and maintain.".
Scores can be divided into 5 segments: 1-2, 3-4, 5-6, 7-8, 9-10. The degree of similarity between Input 2 and the selected keywords from input1 determines the output score segment. The logical coherence and sentence structure of Input 2 are also evaluated, with a margin of 1 point for bias.
Example Scoring Justification:

Typically example with 9-10 scores are sourced from another annotator's summary.
Example with 1-2 scores are from summaries of different aspects of the same essay.
Other examples come from modification of LLM-generated summarizations, edited to align with the score segment.
Justifications for each score are the real response of the prompt by calling openai API, with slight modifications to ensure consistent formatting and criteria alignment.


What is the logic for return dates in shouldShowOnDayView

Sometimes return dates two months ago, sometimes returned 2 months later. Sometimes only the current month.
I want to render only events of the current month, but often not even return dates for the current month to render events with points.

It's a way to load the views that are likely to be shown when swiping to the next or previous months.... It shouldn't cause an issue when displaying your events on the calendar, what is the issue you're having?


invalid kernelcache?

struggling here... i have iPhone 5S 10.3.3 jailbroken. when run memctl it replies:
Error: Mach-O invalid magic: c8a98330
error: not a valid kernelcache
error: could not initialize kernel image
i guess it looks for feedfacf but i dont know how to fix it? i tried to dump anything but it just gives the same error so i cant troubleshoot.
thanks for help!

Are you accounting for the arch being armv7s and not armv7?  They are similar, but at a kernel level fairly different, as armv7s has the addition of Thumb-2 in it's disassembled code/ instruction set.


”Suseni”, ”Luieriu” are listed in the drop-down menu

Description:
When user writes ”Suseni”, ”Luieriu” the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Suseni"

Expected results
The location appears in the drop-down menu as "Sat Suseni, MUREȘ (Suseni)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Luieriu"

Expected results
The location appears in the drop-down menu as "Sat Luieriu, MUREȘ (Suseni)".


Fix the bug of writeCalledPhase()

When the probabilities of having both alleles are equal and the calling threshold is less than 0.5, the function writeCalledPhase() would directly choose the reference allele, which hides the possibility of having the alternative allele.
def writeCalledPhase(pedigree, genoProbFunc, outputFile, thresh):
    with open(outputFile, 'w+') as f:
        for idx, ind in pedigree.writeOrder():
            matrix = genoProbFunc(ind.idn)

            # Paternal
            paternal_probs = np.array([matrix[0,:] + matrix[1,:], matrix[2,:] + matrix[3,:]], dtype=np.float32)
            paternal_haplotype = np.argmax(paternal_probs, axis = 0)
            setMissing(paternal_haplotype, paternal_probs, thresh)
            f.write(ind.idx + ' ' + ' '.join(map(str, paternal_haplotype)) + '\n')

            #Maternal
            maternal_probs = np.array([matrix[0,:] + matrix[2,:], matrix[1,:] + matrix[3,:]], dtype=np.float32)
            maternal_haplotype = np.argmax(maternal_probs, axis = 0)
            setMissing(maternal_haplotype, maternal_probs, thresh)
            f.write(ind.idx + ' ' + ' '.join(map(str, maternal_haplotype)) + '\n')

If the input genotype probabilities are the following
0
0.5
0.5
0

then both paternal_probs and maternal_probs would become  [0.5, 0.5]. np.argmax(paternal_probs, axis=0) would return the index of the highest elements of pathernal_probs and maternal_probs, and when there are two or more equal maximum values occur, it would return the first index of the maximum number. So in this case it would directly return the index 0, which corresponds to the reference allele.
If the calling threshold is less than 0.5, the setMissing() would keep the 0 produced by the np.argmax() instead of setting it missing.
The reason why a low calling threshold is allowed is that it ought to be used for the called genotypes. For called genotypes, it is still possible that the genotype with the highest probability is still around 0.3. For example,
0.31
0.46
0.23

But the genotype would be marked missing if the calling threshold is higher than 0.31.
For called haplotype output, there are only two possibilities for each locus and each haplotype. It is impossible that the highest possibility of any allele is less than 0.5, so a calling threshold lower than 0.5 makes no sense.
One way to get around this is by separating the calling threshold input for called genotypes and called haplotypes. And put a lower bound of 0.5 for the calling threshold for the called haplotypes (similarly, we should also put a lower bound of 0.33 for the called genotypes).
I'm also thinking about maybe evaluating the percentage of the difference between the highest possibility and the next possibility to the highest possibility is a better way to select the reliable output. But it would take a longer time to compute the called output.

@gregorgorjanc
As we are going to introduce a new option -haps_call_threshold for the called haplotypes output, can we remove the -call_phase option?
Since -call_phase is only used for letting AlphaPeel know that the user wants the called haplotype output, while -haps_call_threshold is only useful when the user wants the called haplotypes output. We can let -haps_call_threshold do both that the AlphaPeel is going to output the called haplotypes if and only if a haplotype calling threshold is input.
It would be more consistent with the way we use the genotype calling threshold as well, as the called genotype files are outputted if and only if a genotype calling threshold is given.

@XingerTang let's leave both arguments for now, though I agree with you that I
it feels a bit redundant.

We want -geno, -geno_threshold and -hap, -hap_threshold.

@XingerTang Hi, Evie, I guess we have dealt with this issue. Could you please help close it? I'm checking the table that records our task and will close all issues that we have finished.

@AprilYUZhang Sure!


C# Record and Playback APIs

Fixes #573
Description of the changes:

Added wrapper for Record and Playback APIs
Added a unit test to loop back a synthetic recording
Added native debug message hook to Record and Playback

Before submitting a Pull Request:

[X] I reviewed CONTRIBUTING.md
[X] I built my changes locally
[X] I ran the unit tests
[X] I ran the functional tests with a device
[ ] I ran the performance tests with a device

I tested changes on:

[X] Windows
[ ] Linux

any updates on this? would be greatly appreciated 😺

really hoping this makes it in the v.1.4.0 release, waiting on this to develop some new features in my Unity3D project

What is the reason this pull request is stopped? Thanks,

@UnaNancyOwen:
They mentioned in a comment on #1093 that they're working through some technical issues. I'm guessing they're probably working through any minor bugs on the 1.4 release as that was a pretty big one. They haven't forgotten about it 🙃
You can always build this branch or copy in the needed code to you project if you really need.

bumping.  i know it won't get missed, mainly wondering if it has a tentative date.  didn't know if there was a normal release cadence or it's just as things get merged.  if it'll be a while i'll just roll my own, wrapper - now with less quality!:tm: :)
anything i can do to help on this?

Re-bumping this.
Is the technical issue mentioned before still blocking the progress on this or is just that this feature is low priority/dropped?
Anything we can do to help?

Hi,
Based on comments it sounds like this is just held back for logistical reasons? The code in this branch is actually complete and useable? I need to work with pre-recorded files in a project.

I know this is sort of stalled, but I just wanted to comment that I have been using this branch now for a while to implement playback and recording inside of a Unity project I am working on and everything has been working like a charm.  Thanks for this work!

I know this is sort of stalled, but I just wanted to comment that I have been using this branch now for a while to implement playback and recording inside of a Unity project I am working on and everything has been working like a charm.  Thanks for this work!

According to the C++ code here: https://github.com/microsoft/Azure-Kinect-Sensor-SDK/blob/develop/src/record/sdk/record.cpp#L85
The ColorFormat BGRA32 should be supported for recording, yet when attempting to use that format with the C# recording layer, I get an unsupported color format error.

According to the C++ code here: https://github.com/microsoft/Azure-Kinect-Sensor-SDK/blob/develop/src/record/sdk/record.cpp#L85
The ColorFormat BGRA32 should be supported for recording, yet when attempting to use that format with the C# recording layer, I get an unsupported color format error.

According to the C++ code here: https://github.com/microsoft/Azure-Kinect-Sensor-SDK/blob/develop/src/record/sdk/record.cpp#L85
The ColorFormat BGRA32 should be supported for recording, yet when attempting to use that format with the C# recording layer, I get an unsupported color format error.

I see my error here.  This branch is actually using older C++ code that doesn't support that color format.

According to the C++ code here: https://github.com/microsoft/Azure-Kinect-Sensor-SDK/blob/develop/src/record/sdk/record.cpp#L85
The ColorFormat BGRA32 should be supported for recording, yet when attempting to use that format with the C# recording layer, I get an unsupported color format error.

I see my error here.  This branch is actually using older C++ code that doesn't support that color format.


docs(artifacts): fix typo and remove superfluous whitespace

Saw a one character typo while reading the docs. Removed some superfluous trailing whitespace since I already had the file open.

Fixed! Thanks, @Joibel.