Updating the database.

Hey, I see the current database is outdated.
Is there some kind of script or utility that pulls all the newest version vulnerabilities, plugins, etc?

Hey, unfortunately there's no script/utility for updating those information.
You can always use '--wpvulndb' option in order to use data from https://wpvulndb.com/.
Thanks.


Support for early stopping in ChainerMN

Chainer has 'EarlyStoppingTrigger' to support early stopping.
It is not able to be used when ChainerMN is used.
But, the support for it in ChainerMN may be difficult, because the additional communications are required for it.
Does anyone have any idea to solve this problem?

@kuenishi 's idea:
Instead of communicating every iteration, mpi workers communicate every 10 iterations and every 100 iterations to judge

With #7302, I could realize early stopping in ChainerMN using the code like:
trigger = training.triggers.EarlyStoppingTrigger(monitor='main/loss-ave', max_trigger=(args.epoch, 'epoch'))
trainer = training.Trainer(updater, trigger, out=args.out)
trainer.extend(chainermn.extensions.observation_aggregator(comm, 'main/loss', 'main/loss-ave'))

Although I think this is simple enough, it may be better to add a function to do this all at once.

MultiNodeEarlyStoppingTrigger was implemented in #7302 along with ObservationAggregator.


Add black point compensation

I'm not sure if this is needed/necessary. If the answer is yes, it should be done in tone-mapping, just like what bt.2390 did.
Follow https://www.color.org/WP40-Black_Point_Compensation_2010-07-27.pdf

bpc is already included in bt2390, so remove bt1886 trick here.
toe of dynamic make image too dark, remove it.
L_black of bt1886 and inverse been changed to 1 / 1000.

matrices is for bt2020, add it after tone-mapping. as above bt2390 doesn't need this.
glsl-shader=~~/shaders/hdr-toys/utils/clip_both.glsl
glsl-shader=~~/shaders/hdr-toys/transfer-function/pq_inv.glsl
glsl-shader=~~/shaders/hdr-toys/tone-mapping/dynamic.glsl
+ glsl-shader=~~/shaders/hdr-toys/utils/black_point_compensation.glsl
glsl-shader=~~/shaders/hdr-toys/gamut-mapping/bottosson.glsl
glsl-shader=~~/shaders/hdr-toys/transfer-function/bt1886.glsl

Note:
Update README, if this been merged.

dynamic now include black_point_compensation, no need for an independent one.


Can't detect interfaces

It seems the program scan on the wrong place on Arch Linux I got this error
IOError: [Errno 2] No such file or directory: '/etc/network/interfaces'
It should rather check in /sys/class/net for arch linux

I need to setup Arch Linux VM and figure out what causes the error. Do you have any solution for now?

The error is mainly cause by the fact that if /etc/network/interfaces does not exist the script crashes as it tries to create a device or add a device to /etc/network/interfaces which does not exist on archlinux. It would be nice if this was more OS agnostic.

How can we fix this for now?

Honestly I've no idea.

centos -->/etc/sysconfig/network


parse commitmeta extension

Description
Parsing and adding .commitmeta extension to redirect switch
FIXES:
Type of change
What is it?

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Tests update
[ ] Refactor

I think this will break it for *.sig files :)

signature.sig is caught with the config using redirects on the client side, but new PR coming...


initial information architecture and nav

"I'm a citizen seeing this on twitter and I want to know what the site is about before I lose ttention"
"I'm a citizen with a possible stash of PPE and just want to know what to do next"
"I'm a healthcare provider/organizer and need to update info"

Either code or wireframes would be useful.

I'm not too stressed about CTA below the fold - above the fold is pretty compelling image rich content. Right now it's in the order of an argument (problem, evidence, call to action, what to find, where to take it).
One possibility, move the "We need to help the helpers, right now. We need to find the masks." above the embedded tweets. But I think this would be less compelling. Maybe they could be along side? But that wouldn't work for mobile. Hmm.

obsolete.


Add support for inline image

Details
This PR adds support for inline images inserted with the following syntax: ![alt text](http://example.com).
Related Issues

https://github.com/Expensify/App/issues/39275
Manual Tests

Linked PRs

It seems like there's some problem with the following input:


incomplete UserJourney Tag in HelloWorld Tutorial for Azure AD B2C Custom Polivies

The "UserJourney" related part in the step by step tutorial is missing the "OrchestrationSteps". Also there is a weird reference to
a "userjourneys.md". Looks like the markdown has been messed up around this area

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 5d463042-e1ac-f28f-1e69-8eaec579baa7
Version Independent ID: 6f444337-6ad2-5fd3-9560-cd712aad6bd2
Content: Write your first Azure AD B2C custom policy - Hello World! - Azure AD B2C
Content Source: articles/active-directory-b2c/custom-policies-series-hello-world.md
Service: active-directory
Sub-service: b2c
GitHub Login: @kengaderdus
Microsoft Alias: kengaderdus

@d-lopes
Thanks for your feedback! We will investigate and update as appropriate.

@kengaderdus
Can you please check and add your comments on this doc update request as applicable.

@d-lopes
I'm going to assign this to the document author so they can take a look at it accordingly

@d-lopes
Thanks for your feedback and patience. I hope you're referring to this article. We've checked, but we don't find anything incomplete, or we don't understand your question.


Feature Request: fish shell support

The goal of this project seems to be in alignment with so much of fish shell's mission - in particular. In fact, the name and intent similarity immediately made me look to see if there was already a fisher plugin implementation of butterfish.
User Story
As an avid fan of fish shell, I would like to use butterfish, so that I can benefit from an even more friendly interactive shell.

Hi @bakks ! What would we need to support adding fish? I'm happy to start taking a look.

👋 hello! I haven't had time to look at integrating fish and I'm not super familiar so it's hard to say what is necessary, but I'm happy to give you the outlines if you want to take a look. Happy to give feedback and work with a PR! Some things that might help:

Butterfish shell intercepts the io between the terminal and shell, for example if you press enter, that keypress will first go to butterfish, which might take action based on internal state, like if you've been typing an LLM prompt it will send that. So if there are differences between fish and other shells in that layer then changes will need to be made, but you'll have to experiment.
There a bit of shell-specific logic here. It's setting the shell prompt with the fish emoji and adding some special characters that butterfish uses later on to figure out when a shell prompt is printed, so it's important.

Anyway, have at it!

I attempted to make it work with fish. Here's my current fork:
https://github.com/tfriedel/butterfish/tree/fish
I'm not completely happy with it.
One issue is, it lags a lot more than regular fish in neovim. I.e. if I scroll in neovim I can watch the screen being rendered in chunks.
Another is, the detection of capitalized prompts sometimes doesn't work. There is some piece of code in butterfish that checks the number of subprocesses to check if it should intercept and it assumes if more than the shell is running it shouldn't.
However I use atuin with fish which adds better history. And atuin runs after each command.
I added a workaround for this by copying atuin to atuin2 and I use atuin2 for adding to the history but the original atuin for interactive browsing of the history.
Atuin2 is then whitelisted, like other shell commands.
This is an ugly workaround and even with it, the problem of not detecting some capitalized prompts still appears.


Trim all command arguments

Typescript scares me, I hope I didn't do anything bad

Looks good to me.


Breaks with next-pwa

Hey there! I'm trying to setup next-images along with next-pwa, but for some reason whenever I try to put these two plugins together, the next-pwa breaks due to next-images.
I'm using next-compose-plugins to put then together, but I really have no idea why this is happening.
My implementation
const withImageLoader = require('./webpack/image-loader');
const withCSS = require('@zeit/next-css');
const withPWA = require('next-pwa');
const withImages = require('next-images');

const withPlugins = require('next-compose-plugins');

// ... there is some code here

const { getBasePath } = require('./utils/path');

const assetPrefix = getBasePath();

// Plugins loader
const cssLoader = withCSS(withImageLoader({ env: exportEnvs }));

const imagesLoader = withImages({
  assetPrefix,
});

const pwaLoader = withPWA({
  target: 'serverless',
  poweredByHeader: false,
  assetPrefix,

  pwa: {
    dest: 'public',
    subdomainPrefix: assetPrefix,
    sourcemap: false,
  },
});

// Next configuration
const nextConfig = {
  assetPrefix,
  publicRuntimeConfig: {
    basePath: assetPrefix,
  },
};

module.exports = withPlugins([
  [cssLoader],
  [pwaLoader],
  [imagesLoader],
  nextConfig,
]);

Well, actually I managed to resolve it. It was a configuration I was doing wrong, but now it's working fine :D

@LucasMallmann Great! To be honest, I'm really busy these days and any help is welcome. But I'm happy that your problem is resolved :)

Well, actually I managed to resolve it. It was a configuration I was doing wrong, but now it's working fine :D

Do you mind sharing your working config? Thanks!

@arefaslani no problem! Thanks for the attention :D

@agustif sure, no problem!
const withImageLoader = require('./webpack/image-loader');
const withCSS = require('@zeit/next-css');
const withPWA = require('next-pwa');
const withImages = require('next-images');

const envs = require('dotenv').config();

const withPlugins = require('next-compose-plugins');

const { getBasePath } = require('./utils/path');
const generateManifestFile = require('./factories/manifest');

// Generate the manifest.json
generateManifestFile()
  .then(() => console.log('\n> [Manifest] manifest.json generated succesfully'))
  .catch((err) =>
    console.error(
      '> Error: There was an error generating the manifest.json file',
      err.message
    )
  );

const exportEnvs = {};

Object.keys(envs.parsed).forEach((key) => {
  if (key === 'NODE_ENV') {
    return;
  }

  exportEnvs[key] = envs.parsed[key];
});

const assetPrefix = getBasePath();

// Next configuration
const nextConfig = {
  assetPrefix,
  publicRuntimeConfig: {
    basePath: assetPrefix,
  },
  env: exportEnvs,
};

module.exports = withPlugins([
  [withCSS],
  [
    withImages,
    {
      assetPrefix,
    },
  ],
  [
    withPWA,
    {
      target: 'serverless',
      poweredByHeader: false,
      assetPrefix,

      pwa: {
        dest: 'public',
        subdomainPrefix: assetPrefix,
        sourcemap: false,
      },
    },
  ],
  nextConfig,
]);

The problem was that I'm using next-compose-plugins, but I guess I was not writing the configs right, so that's why it was causing me trouble!


[Feature]: Add bluetooth support to ledger live desktop

Library name
No response
Describe your feature request
Hello, please add bluetooth support to ledger live desktop, would be very helpfull and much appreciated.
thanks

Hey @stevenknieven,
We do not accept feature requests regarding our Ledger Live apps on Github. With that said, adding bluetooth on desktop is definitely on our roadmap.

@elbywan i see, it's good to know it's on the roadmap, thanks for your response.


Search spaces crash

Added a test case which tests adding and removing text while searchSpaces = true.
Implemented a potential fix for the crash that happens in this case.
Merging this can also close #102.

@szweier Please merge this pull request as this issue is causing crashes.


Segmentation fault with BMFtools collpase

Hi Daniel,
@dnbh @BrettKennedy
I am trying to process few samples that were run with dual index chemistry. We trimmed the UMI (3bp on each read) and spacer (2bp) from the reads and also created a new fastq file containing the 6 bp UMI (3bp from each read) so that we can process them as secondary index workflow. However, when I process them with the secondary index workflow, I am getting segmentation fault.
The command I am using to run is:
$bmftools collapse secondary -i $barcodeFastq -o FASTQBMF_tmp -t 5 -s 2 -m 0 -p 24 -f FASTQBMF $firstFastq $secondFastq 2> Logs/02A_BMFtools_Consensus.txt
I changed the salting to 2 (from 4), and tried changing all parameters but nothing worked. Can you please help me fix this issue.
Thanks.
Ashini

I'd be happy to look into this. Can you provide a sample set of files of the first 1000 reads from each file?

Sure, I can send it to you. Can you please tell me the email address you would like me to send it?
Thanks,
Ashini

<EMAIL_ADDRESS>Can you please provide which commit tag or release are you using?
On Thu, May 11, 2017 at 11:17 PM abolia<EMAIL_ADDRESS>wrote:

Sure, I can send it to you. Can you please tell me the email address you
would like me to send it?
Thanks,
Ashini
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ARUP-NGS/BMFtools/issues/98#issuecomment-300973330,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGHaVblDqqUCsj8LZvl5dY9nC5W_uNswks5r488zgaJpZM4NYqyi
.

--
Sent from my Tricorder v2.0.

Hey Daniel,
I sent you the files on your email. I am using the latest BMFtools version 1.1
Thanks,
Ashini

Thank you!
I found the problem. BMFtools assumed that reads will have comments, while yours don't.
The issue is directly fixed in https://github.com/ARUP-NGS/BMFtools/pull/99/commits/0ab1e7c2b2bb0382bfe9ea4faa858b8097f8cc31, though it's lumped in with a variety of small, mostly stylistic changes for this pull request.

Thats great. Thanks Daniel. Will it be okay to pull from your branch dnbh:master meanwhile the pull request is evaluated and accepted by Brett.
Thanks,
Ashini

That should be just fine. Thanks!

Hey Daniel,
I ran BMFtools and its runs without any issues. However, my fastq sizes are pretty small after BMFtools collapse (original 1.2 GB, after collapsing: 330MB).
I have a 6bp UMI, so I played with different -s and -t parameters, but nothing seem to solve the issue. Do you have any recommendations for the parameter setting?
Thanks,
Ashini

What do the collapsed reads look like? Your diversity depends on capture
size, the actual diversity of your barcode, and the file size will vary on
whether or not you are emitting gzipped reads.
What does bmftools famstats say?
If they have a lot of 0 quality scores or Ns, then that suggests that there
may be a problem with reads being considered to have originated from the
same founding template molecule. If not, it might simply reflect your
diversity.

Yes, they are both gzipped files,
Before collapsing, number of reads: 64752432
The collapsed reads when I used salting of 6 is: 5673296 and
And salting of 2: 2520240.
I was using salting of 4 for UMI of size 8 earlier. For UMI of 6 barcodes, I decided to go with salting of 6. Does this make sense or am I missing something?
Number of reads in the collapsed bam: 3056264
The reason I am surprised is because never seen mean family size of 11 before with secondary index chemistry. I think its something to do with salting parameter I am choosing, and I just wanted to check what is a good value of “s”to be used here.
BMFtools famstats:
#Number passing filters: 1418170
#Number failing filters: 12668
#Count for FP failed reads, still included in total counts: 100243
#Number failing FM filters: 0
#Number failing MQ filters: 0
#Number failing flag filters (secondary, supplementary): 12668
#Summed FM (total founding reads): 16187502
#Summed FM (total founding reads), (FM > 1): 15806492
#Summed RV (total reverse-complemented reads): 0
#Summed RV (total reverse-complemented reads), (FM > 1): 0
#RV fraction for all read families: 0.000000
#RV fraction for real read families: 0.000000
#Mean Family Size (all) 11.414359
#Mean Family Size (real)        15.240167
#Family size    Number of families
1       381010
2       122648
3       129077
4       123519
5       100913
6       73409
7       49831
8       33001
9       22621
10      16400

That doesn't look so crazy. I've seen family sizes of that size, though not often at only 16 million founding reads.
I don't have pysam installed (sorry), but I think something like this could get you some information:
import pysam
import sys
from collections import Counter
from itertools import chain

if __name__ == "__main__":
    cfi = chain.from_iterable
    print("Tag distribution for PV: %s" % str(Counter(cfi(bam.opt("PV") for bam in pysam.AlignmentFile(sys.argv[1])))))
    print("Fraction agreed distribution: %s" % str(Counter(cfi(bam.opt("FA") * 1. / bam.opt("FM") for bam in pysam.AlignmentFile(sys.argv[1])))))

use as python script.py file.bam.
If it's collapsing reads that don't belong together, you'll have an inordinate amount of 0s in PV and a distribution of FA/FM which is closer to 0.

You might have to wrap bam.opt("FA") in np.array().

Thats great. I will look into it. Thank you so much.
Ashini

You're welcome.
If it looks bad from that output (e.g., all close to 0), I might even still
have access to CHPC, and, if so, I could try to see what might be the
problem.
Sent from my Tricorder v2.0.

Hi Daniel,
I ran the script you gave and neither do I see 0s in PV and nor a distribution of FA/FM closer to 0 (I am also attaching the output). My total read count is lesser than 100 million, so I think I should be good with a slating of 6.
Thank you so much for your help on this. I guess I am good on this.
out.txt

@BrettKennedy Do you think this can be closed?

@dnbh Since I'm no longer at ARUP, I do not have the permissions to do so.  I think @mjmonroe may be able to do that for you.

@abolia - can this also be closed?

Yes.


Fix correlationId gRPC metadata key

Duplicate of this change: https://github.com/Cerebellum-Network/cere-ddc-sdk-js/pull/258


Request

Minetweaker support for the Bloomery.

Add Recipies
Remove Recipies

I know it's been awhile, any news?


Remove FreeBSD 11 from CI

FreeBSD 11 is EOL and packages for it are no longer provided, which causes the CI job to fail.
cc @asomers

@Amanieu: no appropriate reviewer found, use r? to override

Blocked on https://github.com/rust-lang/homu/pull/169

@bors r+

:pushpin: Commit b38ca804cbb7515839fe3cb43276a5e106f0dda5 has been approved by Amanieu

:hourglass: Testing commit b38ca804cbb7515839fe3cb43276a5e106f0dda5 with merge 5ac08840c2552155c0f7f443c06663e9ffcd2874...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: Amanieu
Pushing 5ac08840c2552155c0f7f443c06663e9ffcd2874 to master...


add simpspector events

and move logger write calls in a subscriber

@simpspector/owners ready :)

Haven't checked the code completely yet, but why are you injecting the logger into every single event instead of only once in the subscriber?

The logger isn't a service or dependency. It is a context value.
If you call the handler multiple times (what we do), you have different log files for each commit.
So also different logger instances with different targets.
References:
https://github.com/simpspector/simpspector/blob/master/src/SimpleThings/AppBundle/CommitHandler.php#L62
https://github.com/simpspector/simpspector/blob/master/src/SimpleThings/AppBundle/Logger/LoggerFactory.php
The same situation we have in analyser:
https://github.com/simpspector/analyser/blob/master/src/Event/Subscriber/LoggerSubscriber.php

OK, I see the problem, but still: this leaves logger logic in the classes emitting the events. Seems not quite right. You might emit an event at the start of every commit, signaling a necessary file change to the subscriber.
Maybe we can talk about this later today in person.

As discussed earlier, my main problem is with naming, since I associated "Logger" very strongly with application logging. In this case, we are talking about, for lack of a better word, "console output".
So :+1: but we should find a better name for what we are doing here (separate issue in simpspector/analyser).

@tolry can you create an issue? :wink:

will do

What about "report"?

Sounds good -  I will link the new issue to this one, so we can discuss and brainstorm there.

I only had two minor comments (mainly to demonstrate, that I've read the code :-p).
+1 for merge.


Exclude window from alt + Tab keyboard shortcut

Description of the new feature / enhancement
adding support to mark window as excluded of alt + Tab keyboard shortcut
Scenario when this would be used?
On browsing between windows with alt + Tab keyboard shortcut
Supporting information
No response

I think this should be the enhancement of Windows 10/11 (The operating system), not for PT, a utility.
Please file this at the Feedback Hub

you can orphan it via Keyboard manager.

@crutkas
The option you present here is to disable the feature as is.
My idea is to select specific window to exclude.

Can you explain more why? /needinfo

When working with multiple windows and there is unusable opened window in background (music player for example).
And you don't want him to live in alt + tab shortcut

I don't know if this request pertains to the same thing I'm looking for, which is to set specific apps to be excluded from Alt-Space (PowerToys Run default activation shortcut). Trying to use the following tip by @crutkas tip ...

you can orphan it via Keyboard manager.

... I thought this approach would work, but it doesn't::

I'd very much like to use Alt-Space globally, but just not in certain apps such as Autodesk Maya. I hope this will be possible to change at some point up the road.

can you add this feature at least for always on top window?
exclude always on top window from alt+ Tab function

so reading this, what worries me about doing this type of behavior about excluding certain windows is you're making certain windows not keyboard accessible. this could really unintentionally impact certain user groups or lets say your mouse battery runs out.

Here is my usecae.
3 Monitor setup at work. The one to the right is vertical and has teams, obisidan and outlook.
These windows are set to "Show on all virtual Desktops" hence accessible at all times.
While coding I essentially only want to alt+tab my editor, the browser and what else is on the main window for the current workspace.
Sometimes however I focus outlook or teams to reply to a message which completely screws me over the next time I alt+tab (back in outlook instead of the browser for example)
@crutkas argument is very valid though.
Would it be possible to flag windows as "not important" so they always stay at back of the alt+tab switcher?
If you really need to, you can still access them with akeyboard but they stay out of your way for the most part.

There's this AutoHotkey script that can exclude windows from Alt+Tab:
https://www.reddit.com/r/software/comments/s6jcaz/comment/ht5ta3q/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button

There's this AutoHotkey script that can exclude windows from Alt+Tab: https://www.reddit.com/r/software/comments/s6jcaz/comment/ht5ta3q/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button

Just tried this script, it works very well for some windows, but doesn't for others.... (whatsapp, toggl)


Allow dropping Deny rule on web storage account in upload_static_web.sh

Description
As a TRE Administrator
I want to be able to open up the web storage account when I execute the build-and-deploy-ui target
So that I can perform automated deployments of the UI in Azure DevOps pipelines
The letsencrypt.sh script in the repo contains a conditional path for removing the Deny rule on a storage account which (as noted in the script) was added to enable the script to be used in AzDO pipelines targeting deployments to the same region as the pipeline runner. See https://github.com/microsoft/AzureTRE/blob/main/templates/core/terraform/scripts/letsencrypt.sh#L11-L27
A similar approach in upload_static_web.sh would unblock the UI deployment via AzDO.
Acceptance criteria

[ ] There is a way to run make build-and-deploy-ui that temporarily drops the Deny rule to enable UI content upload

@stuartleeks in https://github.com/microsoft/AzureTRE/pull/2554 there was a consensus to simplify and drop all limitations (=allow all IPs), upload and then return the "deny" default action to block public access.
I believe that should be enough and this issue can be closed. Do you agree?

Yup, that works!


Unit as part of value in target entities

Describe the bug
Target entities have a number of cost attributes and they all have a "p" in their value :
overall_average_cost: 18.8265p
overall_min_cost: 17.997p
overall_max_cost: 19.5825p
current_average_cost: null
current_min_cost: null
current_max_cost: null
next_average_cost: 18.826500000000003p
next_min_cost: 17.997p
next_max_cost: 19.5825p

(the null ones do as well)
the current day rate entity doesn't :
current_day_min_rate: 2.4255
current_day_max_rate: 37.6635
current_day_average_rate: 19.366108695652173

Reproduction steps
create a target entity
Expected behaviour
the cost values should be a float not a string.
Tariff Code
No response
Integration Version
8.4.4
Home Assistant Version
2023.10.3
Fresh Install?
Not specified
Home Assistant Logs
N/A

Also while you are looking at that, would it be "better" to have those attributes in GBP rather than pence for consistency with the sensor unit of measure ?

Hi and thanks for raising this issue. The denomination was present to make it clear what the value represents. The inconsistency between some of the attributes was mainly due to OE reporting in pence and HA wanting data reported in pounds and pence. I was trying to avoid transforming the data reported by OE to reduce errors, but this has lead to a less than ideal experience for users.
I had a few inconsistency reports, which I've consolidated into https://github.com/BottlecapDave/HomeAssistant-OctopusEnergy/issues/481 as they will all result in a breaking change and it makes it easier for me to track them all. Therefore I will be closing this issue and you should watch that issue for updates.


Add dialect as a module dependency rather than a string (Running Join Monster in React Native)

Context:
I'm currently running Join Monster on React Native! This means that I can use Relay or Apollo Client, offline, on an embedded sqlite database, sans server. Here's a shot of it working:

In order to get this to work, I only had to do things!

Shim Nodejs modules
Hard code the dialect in the join-monster source code

The first is something I think I can just deal with, and wasn't so bad. The latter is problematic because I don't want to maintain my own fork of this awesome package.
Problem
The reason why I had to hardcode the dialect is because React Native can't dynamically require modules: https://github.com/facebook/react-native/issues/6391.
I ended up hard coding sqlite as the dialact on this line: https://github.com/stems/join-monster/blob/master/src/stringifiers/dispatcher.js#L13
See my atrocity below:
import sqlite from './dialects/sqlite3'

export default async function stringifySqlAST(topNode, context, options) {
  validateSqlAST(topNode)
  const dialect = sqlite
  // recursively figure out all the selections, joins, and where conditions that we need
  let { selections, tables, wheres, orders } = await _stringifySqlAST(
    null, topNode, [],
    context, [], [],
    [], [], options.batchScope,
    dialect
  )

Proposal
Instead of having a string option for the dialect, we make it an actual imported dialect instance:
import joinMonster from 'join-monster'
import {pg} from 'join-monster/dialects'

const options = { dialectModule: pg}
 joinMonster(resolveInfo, context, sql => dbCall(sql, knex, context), options)

This would also let people write custom dialects or tweak them, without having to modify Join Monster itself. If the maintainers like the proposal, I'd be happy to attempt a PR.

I thought that you'd probably prefer that, so I chose dialectModule instead of dialect for the option name in my example. I'm not in love with that option name, but it's the best I can think of right now. @acarl005, let me know if you have a preference there, otherwise I'll start with dialectModule.

That name is clear enough. Sound good to me.

I started with the contribution guide: https://github.com/stems/join-monster/blob/master/CONTRIBUTING.md and am running npm run db-build. I got errors about not having a MySQL connection string. I provided that but then the test1 database was missing. I created the database, and now I'm getting ERROR 1067 (42000) at line 2: Invalid default value for 'created_at'. I haven't edited any code yet. Am I starting off on the wrong foot here?

Thats odd. What version of MySQL are you using?

5.7.19-log

This works:
mysql> CREATE TABLE accounts (
    ->   id INT AUTO_INCREMENT PRIMARY KEY,
    ->   email_address VARCHAR(150),
    ->   first_name VARCHAR(255),
    ->   last_name VARCHAR(255),
    ->   num_legs INT DEFAULT 2,
    ->   created_at DATETIME DEFAULT CURRENT_TIMESTAMP
    -> );

I think it has to do with the precision of DATETIME(3) not working with the default timestamp?

I removed all those and ran it, and a lot of my tests are passing, but now I'm getting this:
connection to { client: 'mysql', connection: 'mysql://root:@localhost/test2' }

  1 failed

  filtered pagination at the root
  /Users/admin/playground/join-monster/test/pagination/offset-paging.js:402

   401:   const { data, errors } = await run(query)
   402:   t.is(errors, undefined)
   403:   t.deepEqual(data, {

  Difference:

  - [
  -   GraphQLError { … },
  - ]
  + undefined

  Test.<anonymous> (test/pagination/offset-paging.js:402:5)
  step (test/pagination/offset-paging.js:19:191)

Here is the error:
[ { Error: ER_PARSE_ERROR: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '() AS `$total`
    FROM (SELECT * FROM `accounts`) `users`
    WHERE TRUE
    ORDER BY' at line 7
      at Query.Sequence._packetToError (/Users/admin/playground/join-monster/node_modules/mysql/lib/protocol/sequences/Sequence.js:52:14)
      at Query.ErrorPacket (/Users/admin/playground/join-monster/node_modules/mysql/lib/protocol/sequences/Query.js:77:18)
      at Protocol._parsePacket (/Users/admin/playground/join-monster/node_modules/mysql/lib/protocol/Protocol.js:280:23)
      at Parser.write (/Users/admin/playground/join-monster/node_modules/mysql/lib/protocol/Parser.js:76:12)
      at Protocol.write (/Users/admin/playground/join-monster/node_modules/mysql/lib/protocol/Protocol.js:39:16)
      at Socket.<anonymous> (/Users/admin/playground/join-monster/node_modules/mysql/lib/Connection.js:103:28)
      at emitOne (events.js:115:13)
      at Socket.emit (events.js:210:7)
      at addChunk (_stream_readable.js:252:12)
      at readableAddChunk (_stream_readable.js:239:11)
      at Socket.Readable.push (_stream_readable.js:197:10)
      at TCP.onread (net.js:589:20)
      at Protocol._enqueue (/Users/admin/playground/join-monster/node_modules/mysql/lib/protocol/Protocol.js:141:48)
      at Connection.query (/Users/admin/playground/join-monster/node_modules/mysql/lib/Connection.js:208:25)
      at /Users/admin/playground/join-monster/node_modules/knex/lib/dialects/mysql/index.js:152:18
  From previous event:
      at Client_MySQL._query (/Users/admin/playground/join-monster/node_modules/knex/lib/dialects/mysql/index.js:146:12)
      at Client_MySQL.query (/Users/admin/playground/join-monster/node_modules/knex/lib/client.js:197:17)
      at Runner.<anonymous> (/Users/admin/playground/join-monster/node_modules/knex/lib/runner.js:146:36)
  From previous event:
      at /Users/admin/playground/join-monster/node_modules/knex/lib/runner.js:65:21
      at runCallback (timers.js:781:20)
      at tryOnImmediate (timers.js:743:5)
      at processImmediate [as _immediateCallback] (timers.js:714:5)
  From previous event:
      at Runner.run (/Users/admin/playground/join-monster/node_modules/knex/lib/runner.js:51:31)
      at Raw.Target.then (/Users/admin/playground/join-monster/node_modules/knex/lib/interface.js:35:43)
      at dbCall (/Users/admin/playground/join-monster/test-api/data/fetch.js:6:24)
      at /Users/admin/playground/join-monster/test-api/schema-paginated/QueryRoot.js:78:69
      at handleUserDbCall (/Users/admin/playground/join-monster/src/util.js:152:18)
      at /Users/admin/playground/join-monster/src/index.js:89:20
      at Generator.next (<anonymous>)
      at step (/Users/admin/playground/join-monster/src/index.js:197:191)
      at /Users/admin/playground/join-monster/src/index.js:197:361
      at <anonymous>
      at process._tickCallback (internal/process/next_tick.js:188:7)
    message: 'SELECT\n  `users`.`id` AS `id`,\n  `users`.`$total` AS `$total`,\n  `users`.`email_address` AS `email`,\n  `users`.`first_name` AS `first_name`,\n  `users`.`last_name` AS `last_name`\nFROM (\n  SELECT `users`.*, count(*) OVER () AS `$total`\n  FROM (SELECT * FROM `accounts`) `users`\n  WHERE TRUE\n  ORDER BY `users`.`id` ASC\n  LIMIT<PHONE_NUMBER>3709551615 OFFSET 0\n) `users`\nORDER BY `users`.`id` ASC - ER_PARSE_ERROR: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near \'() AS `$total`\n  FROM (SELECT * FROM `accounts`) `users`\n  WHERE TRUE\n  ORDER BY\' at line 7',
    locations: [ [Object] ],
    path: [ 'users' ] } ]

Looks like mysql doesn't support COUNT(*) OVER()

I think i figured it out here: options.dialect = PAGINATE ? 'mariadb' : 'mysql'. I'm supposed to use Mariadb. I'll try that. If I had the time, I might try and get this documented, or better yet, a script to run all the tests in docker.

Ok, acarl005.  Thanks for your help and patience! Here is my latest problem:
  21 passed
connection to { client: 'mysql', connection: 'mysql://root:@localhost/test2' }

  9 passed
  1 failed

  should handle pagination in a nested field
  /Users/admin/playground/join-monster/test/pagination/keyset-paging.js:206

   205:   const posts = data.user.posts
   206:   t.deepEqual(posts.pageInfo, {
   207:     hasNextPage: false,

  Difference:

    {
  -   endCursor: 'eyJjcmVhdGVkX2F0IjoiMjAxNS0xMS0xNVQwODoyNjoxMS4wMDBaIiwiaWQiOjMwfQ==',
  +   endCursor: 'eyJjcmVhdGVkX2F0IjoiMjAxNS0xMS0xNVQwODoyNjoxMS4zMzFaIiwiaWQiOjMwfQ==',
      hasNextPage: false,
      hasPreviousPage: false,
  -   startCursor: 'eyJjcmVhdGVkX2F0IjoiMjAxNi0wNC0xN1QxODo0OToxNS4wMDBaIiwiaWQiOjJ9',
  +   startCursor: 'eyJjcmVhdGVkX2F0IjoiMjAxNi0wNC0xN1QxODo0OToxNS45NDJaIiwiaWQiOjJ9',
    }

  Test.<anonymous> (test/pagination/keyset-paging.js:206:5)
  step (test/pagination/keyset-paging.js:26:191)

@acarl005, thanks for your patience. I'm on mariadb now and both problems were solved. It did skip some tests, but said "Passed" at the end. Were the skipped tests the oracle ones? Should I be concerned? Also, I am getting some linting errors on lines being too long (this is all before I write any code). Should I be concerned about those either?

The skipped tests are for a known bug that isn't yet fixed, so don't worry about that. The line length is simply a warning, so it will not fail a build. Those are fine. It's just a refactoring chore.

Cool. I'm cranking on the meat now. Thanks so much for your help!

@acarl005, I've finally got all of the tests passing with the new change. Here's my first go at a PR: https://github.com/stems/join-monster/pull/176

@acarl005 It looks like the travis builds are failing: ERROR 1044 (42000) at line 1: Access denied for user 'travis'@'%' to database 'test1', any idea of what I can do to fix that? I had to create the databases locally?

Yeah recently the builds started failing because of that access error. I haven't figured out why yet. Couldn't find any mentions of Travis changing the default username for MariaDB. I'll need to look into it.

It's weird, MariaDb doesn't mention a username: https://docs.travis-ci.com/user/database-setup/#MariaDB. MyDQL does: https://docs.travis-ci.com/user/database-setup/#MySQL. I wonder if root would work?

I loged a ticket with support a few hours ago....no word yet. I just realized I can try root. I'm going to attempt.

It looks like root works!! But I'm getting failures that I wasn't getting on localhost. I'm gonna try and sleuth that down now.

@acarl005 It looks like all my travis MySQL test are failing (in all versions of NodeJS). They're running just fine locally, is there anyway to get the graphql errors coming out? Have you any advice on how to move forward? https://travis-ci.org/stems/join-monster/jobs/259959323

@acarl005 I cheated and outputted the test failure on Travis. https://travis-ci.org/stems/join-monster/jobs/260001701. I get { Error: ER_NO_SUCH_TABLE: Table 'test1.accounts' doesn't exist. It looks like  npm run db-build isn't creating those tables? Or is creating the wrong ones? There is no output for that command so it's hard to tell what's up.  Do the tests work on normal branches right now? Is there a (upper/lower) case issue?
I'm not very confident playing around in Travis/with the build stuff. I hope that this is helpful and that I'm not being a pain.

Hm. It looks like npm run db-build actually failed. You can expand the output by clicking the little arrow on the left-hand side of the commands. It seems to have failed with the same error you had earlier.
ERROR 1067 (42000) at line 2: Invalid default value for 'created_at'

I think this error is specific to MySQL. It shouldn't even be connecting to MySQL. My intention was to run the tests on Travis against MariaDB instead of MySQL. Maybe the tests are running against MySQL. It's kind of hard to tell which database its actually connected to since the URIs for both begin with mysql://*. It looks like both mysql and mariadb are installed in the image. Maybe Travis changed some stuff recently and the builds are installing MySQL even though the test suite doesn't require it. That would explain all the recent build failures... Perhaps theres a way to tell it not to install MySQL so we can be certain that its running the tests against MariaDB.

https://stackoverflow.com/questions/45453969/mariadb-clashing-with-mysql-on-travis-ci

Great observation. I've confirmed it. On travis I get:
0.05s$ mysql -u root -e 'SHOW VARIABLES LIKE "%version%";'
+-------------------------+-------------------------+
| Variable_name           | Value                   |
+-------------------------+-------------------------+
| innodb_version          | 5.6.33                  |
| protocol_version        | 10                      |
| slave_type_conversions  |                         |
| version                 | 5.6.33-0ubuntu<IP_ADDRESS> |
| version_comment         | (Ubuntu)                |
| version_compile_machine | x86_64                  |
| version_compile_os      | debian-linux-gnu        |
+-------------------------+-------------------------+

On localhost I get:
$ mysql -u root -e 'SHOW VARIABLES LIKE "%version%";'
+-------------------------+-----------------------------+
| Variable_name           | Value                       |
+-------------------------+-----------------------------+
| innodb_version          | 5.7.18                      |
| protocol_version        | 10                          |
| slave_type_conversions  |                             |
| version                 | 10.2.7-MariaDB              |
| version_comment         | Homebrew                    |
| version_compile_machine | x86_64                      |
| version_compile_os      | osx10.12                    |
| version_malloc_library  | system                      |
| version_ssl_library     | OpenSSL 1.0.2l  25 May 2017 |
| wsrep_patch_version     | wsrep_25.19                 |
+-------------------------+-----------------------------+

It looks like the install for MariaDB client failed?
The following packages have unmet dependencies:
 libmariadbclient-dev : Depends: libmariadbclient18 (= 5.5.56-1ubuntu<IP_ADDRESS>)
E: Unable to correct problems, you have held broken packages.

It looks like the last successful test passed was in precise, but travis upgraded us to trusty, as seen under Build system information. I've locked .travis.yml to precise and it passed! Seems like trusty is the source of all of our ills. Is that ok, to pass on precise for now? It seems like Travis support for MariaDB on trusty is no good.

Here's the PR link again, with the tests passing. When you have time, @acarl005, let me know if you want me to change anything. It ended up being a bigger change than I expected. I'm actually super new to GraphQL, Travis, and not a NodeJS developer by trade, so I'm not very confident that what I have will fit perfectly without any adjustments, but it is passing the tests!!!

Thanks for all your help! I'll get this into master before the end of the week.

Cool, let me know if you need help with anything.

Included in version 2.0.4> Thanks for your contribution!

Thank you!


Implemented commit characters

Please let me know if anything needs changed and I'll take care of it as soon as possible.
Thanks!

Codecov Report

Merging #162 (ab50be6) into dev (2aeba14) will increase coverage by 0.24%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##              dev     #162      +/-   ##
==========================================
+ Coverage   54.85%   55.09%   +0.24%
==========================================
  Files          54       54
  Lines        2463     2474      +11
  Branches      516      515       -1
==========================================
+ Hits         1351     1363      +12
+ Misses        951      950       -1
  Partials      161      161

Impacted Files
Coverage Δ

client/src/Backend/spItemsRepository.ts
42.16% <ø> (+0.25%)
:arrow_up:

client/src/Providers/spCompletionProvider.ts
20.00% <ø> (ø)

client/src/Backend/spItems.ts
56.49% <92.30%> (+1.71%)
:arrow_up:

client/src/Misc/parseSMAPI.ts
36.66% <0.00%> (ø)

client/src/Commands/createTask.ts
20.93% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aeba14...ab50be6. Read the comment docs.

Looks good, thanks!


Neither fragments from external files nor inline responses are generated

I have this spec (given below). When running openapi-generator on it, I get 3 classes: Foo, Bar and Baz. Fabrikt only gives me Bar. I've derived this from a bigger example and the issue seems to be that only models included via #/components/schemas are processed.
openapi: 3.0.3
info:
    title: title
    description: description
    version: 1.0.0
paths:
    /foo:
        get:
            responses:
                "200":
                    description: ok
                    content:
                        application/json:
                            schema:
                                type: object
                                title: Foo
                                properties:
                                    fifo:
                                        type: string
                                required:
                                    - fifo
    /bar:
        get:
            responses:
                "200":
                    description: ok
                    content:
                        application/json:
                            schema:
                                $ref: '#/components/schemas/Bar'
    /baz:
        get:
            responses:
                "200":
                    description: ok
                    content:
                        application/json:
                            schema:
                                $ref: ./Baz.yaml
components:
    schemas:
        Bar:
            type: object
            properties:
                baz:
                    type: string

Baz.yaml, for completness sake:
properties:
    baz:
        type: string

For the fragment, you'd have to define something like this in baz.yaml:
schema:
  $ref: ./Baz.yaml#/components/schemas/Baz

components:
  schemas:
    Baz:
      type: string

For the inlined schemas, this is a known limitation. We don't support generating inline schemas from request or response bodies. https://github.com/cjbooms/fabrikt/issues/20
For now, just extract them to the component schema section like you did with Bar and it will work. I'll add a note to the README about this

A ./Baz.yaml#/components/schemas/Baz is a "Relative Documents With Embedded Schema", our spec however uses "Relative Schema Document" (that's how I think they call them in the specification), so $ref: ./Baz.yaml should work, too (though it directly contains the object without being nested under /components/schemas first).
We wouldn't miss inline schemas, but our spec is full of these relative schema documents because they are very convenient.


Build(deps-dev): Bump eslint-plugin-import from 2.25.3 to 2.25.4 (#2290)

Pull request opened by the merge tool on behalf of #2290

Merged in cdc89716bfed1f0f99f6bcf9b2481193ed67cd11


Modify code to use a generic underline json value

Today the code assumes the underline json structure is serde_json::Value. We have a situation where this is not the case and we need to work with a custom structure. We still want to use this library with our structure. I was wondering if you will accept a PR that changes the code to work with any value that implement a defined trait, this way it can be use with serde_json::Value but with other structures as well. If you agree we can use this issue to define the details and I will be happy to contribute the PR.

I have a question. What do you mean by custom struct?

I mean that the json structure (in memory) is not a serde_json::Value. Instead, we use our own structure (specifically in our use-case it's even C implemented). Imagine for example that you want some extra metadata per node in the json structure, you can not use serde_json::Value but it is easy to create your own struct and just implement Serialize and Deserialize to be able to use it with serde_json for serialization and deserialization. But now I also want to be able to perform a jsonpath query on this struct and this is why I open this issue :).
I imagine we can define a trait such that each object that wants to be jsonpath "compatible" will need to implement this trait (for sure the implementation for serde_json::Value will come built-in). The trait can define functions like IterValues for array iteration or IterItems for object iteration, it will define a function to get the type of the json object and for sure get primitive values (strings, number, boolean, ...).
For existing users, the API will stay exactly the same, but it will open a door for more users to be able to use this library.
WDYT?

I didn't understand exactly. Can I understand as below?
let v = struct TestStruct { ... }
let result = jsonpath::select(&v, "$.name").unwrap()

Yes, exactly.

That's a good idea. Thanks in advance for the PR. 👍

Maybe this trait could be useful to add (and retrieve) other metadata to the json node structure, such as the reference to the parent node the to key string of the node. For instance I submitted a PR (#84) that implements the parent operator by the mean of a HashMap to relate each node to its parent. Of course adding such reference to a more generic Node struct would be much more clean and efficient. Similarly, to implement the key operator (issue #69), one could add the key string reference to each node.
What to you think?


Extended metrics with config

This addon enhances the statsd metrics available for monitoring the karapace server. We have now included the following additional metrics:
connections_active
request_size_avg
request_size_max
response_size_avg
response_size_max

The aiohttp library does not provide native support for metrics. Therefore, we will make an effort to gather the required data by collecting statistics from the request handler, aiohttp logs, and various other sections of the karapace code.
We have plans to enhance the metrics support in this module by adding additional metrics.
I am currently working on expanding the functionality of karapace metrics, which is already in existence. My objective is to incorporate metrics that are similar to what can be found in competitor products. To achieve this, I am utilizing the calculation methods employed by concurrent projects. These projects utilize the org.apache.kafka.common.metrics Java library, which includes classes for calculating metrics such as Avg, Max, Min, and more. However, I haven't been able to find a Python library that offers similar functionality. Therefore, the metrics library I propose is a straightforward Python implementation based on the methods used in the aforementioned Java library.
Karapace competitors use sampled metrics and perform calculations for avg, min,  max on the application side in order to facilitate Pull-based statistics services. This particular model is commonly utilized in platforms like Prometheus, and it is also the preferred choice for our client. However, at present, karapace only supports StatsD. Nevertheless, I anticipate that customers who actively rely on Pull-based statistics will likely require support for such services, and therefore, integrating them into our metrics class would be necessary to meet their needs.

@tvainika could You review current version of PR?


Compatibility issue: Does it work on Mac M1?

Hi @ruggi,
Thank you for creating this amazing tool! I was wondering if it is compatible with Mac M1. I encountered an error as below while typing "cal" in alfred:

Hi @ruggi,
Thank you for creating this amazing tool! I was wondering if it is compatible with Mac M1. I encountered an error as below while typing "cal" in alfred:

@heroc0111, @Budaa, @T0rukMakt0, @wolfkarl, @svenko99, @timmb, @volleysolutions, @Avivbens, @NouamaneTazi, @Budaa
I've created a pr fix this waiting for @ruggi to review and publish new release. In the mean time you can check out the fixed release from my fork!

Hi @ruggi,

Thank you for creating this amazing tool! I was wondering if it is compatible with Mac M1. I encountered an error as below while typing "cal" in alfred:

@heroc0111, @Budaa, @T0rukMakt0, @wolfkarl, @svenko99, @timmb, @volleysolutions, @Avivbens, @NouamaneTazi, @Budaa
I've created a pr fix this waiting for @ruggi to review and publish new release. In the mean time you can check out the fixed release from my fork!

Thanks a lot 🙏
Can you put a link to the PR?

Hi @ruggi,

Thank you for creating this amazing tool! I was wondering if it is compatible with Mac M1. I encountered an error as below while typing "cal" in alfred:

@heroc0111, @Budaa, @T0rukMakt0, @wolfkarl, @svenko99, @timmb, @volleysolutions, @Avivbens, @NouamaneTazi, @Budaa
I've created a pr fix this waiting for @ruggi to review and publish new release. In the mean time you can check out the fixed release from my fork!

Thanks a lot 🙏
Can you put a link to the PR?

It's here


Specify namespace for ECP resource

This needs to be reviewed by someone from the release team.

/lgtm

/retest

/lgtm


Add detection of configuration based on SRV records (RFC6186)

If "XML Discovery" yields no connection settings, query SRV records
on the domain portion of the email address. This will help increase
the likelihood of being able to set up accounts with only the email and
password.

[x] Automated tests

NB: I attempted to merge the code that @daquexian had worked on but it
has drifted so far behind master that the amount of effort to merge that
in would be very large.
References:
https://github.com/k9mail/k-9/issues/865
https://github.com/k9mail/k-9/issues/2530

I'm going to contribute some automated tests and fix the issues mentioned over the weekend but I thought it would be nice to get it out into the open to get eyes on it.

Thanks for working on this :+1:
Actually using this method to discover server settings comes with the same problems as mentioned here: https://github.com/k9mail/k-9/pull/3879#pullrequestreview-208014585
Sadly, I didn't actually create an issue outlining a plan to tackle this. I'll try to do this today.
For now I think it would be best to limit this pull request to the ConnectionSettingsDiscovery implementation. I'll add some comments in a bit.

@cketti I won't reply individually to the comments as I'm generally in agreement with you with most of them, especially around "graceful failure".
Thanks for your comments :)

@cketti Would there be an issue in me using JUnit-QuickCheck to write property-based tests?

@cketti Would there be an issue in me using JUnit-QuickCheck to write property-based tests?

Without concrete example I currently don't see how it could be useful. Just go for it and I'll have a look at the result?

How can we determine the security setting for the SMTP server? There is no differentiation like IMAP/IMAPS in RFC6186. Should we assume STARTTLS? Or possibly attempt SSL/TLS depending on port number?

_submissions._tcp was added by RFC 8314, section 5.1

_submissions._tcp was added by RFC 8314, section 5.1
Perfect! Thank you :+1:

Apologies for the unclear git history. I should have rebased against upstream/master before pushing to avoid the Git merge non-sense.

Thanks :+1: I manually cleaned up the Git history dfe2698453d1b3c7f85abf43dac2f7fd281be1cb and merged the changes just now.

@livmackintosh: Do you want to continue working on this? Unfortunately, the plan outlined in #4721 is quite a lot of work. But if I know someone is willing to work on it, I'd be happy to break it down into more manageable tasks.

@cketti Most definitely; I would love to see this over the line - it's crucial to getting K9 up 2020+ standards. I can probably work with https://github.com/k9mail/k-9/issues/4721 but equally, if you wish to break it down that's cool too.

Awesome. I created issue #4759 with a description of what I think is a reasonable next step.

Really cool! Do we check the validity of the SRV record with DNSSEC?

@monperrus: Not yet, but the code isn't used yet. The plan is to trust host names under the email domain and records signed via DNSSEC.


Uncaught NotFoundError: File not found

Describe the bug
Error while getting started having just install the beta, and
To Reproduce
Steps to reproduce the behavior:

Start Beaker 1.0 Beta, for the first time,
Wait for initialization to complete, and then press 'Get Started'
Choose a picture, and enter display name. Then press 'Next'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Desktop (please complete the following information):

OS: macOS 10.15.4
Browser Beaker
Version 1.0 Beta

Additional context
I had the previous version of Beaker install, if that makes any difference...

Oof bummer. Discussing via IRC now.

Okay fixed this, turns out it was an issue created by @paul90 using an earlier build of the new release


feat(challenges): Added feedback for non-front-facing glitch url

Pre-Submission Checklist

[x] Your pull request targets the staging branch of freeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[x] Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #16660
Description
From personal experience and the creators of #16660 and #16707, the users are putting a direct Glitch URL (https://glitch.com/edit/#!/crimson-swim) into the solution input, when they should instead be giving the front-facing URL (https://crimson-swim.glitch.me)
This PR includes a few changes to help the user differentiate these two types of Glitch URLs.
If need be, I'd be glad to add more instructions in text or add more SolutionInput component tests.

Hmm looks like this needs to be re-visited. @jkao1 thanks a lot for the PR, but we would want to see if a more generic approach is possible.

@raisedadead @Bouncey Understood. An alternative for Glitch feedback is we add text to the Solution Input by checking its value. For example, if the solution value matches the unwanted version of the Glitch URL, Glitch-specific feedback would be appended to the current error message ("Make sure you provide a proper URL").
This would require no extra props; it would only be a simple regex check.

I utilized React Bootstrap's warning validation state in the solution input's form group. If an invalid Glitch URL is provided, a warning on the Glitch URL will show.

To address this problem, I changed warning to glitch-warning. Since React Bootstrap can only read three validation states (success, error, and warning), I added the following logic to determine the actual validation state within the form:
<FormGroup
  validationState={
    (validationState && validationState.includes('warning')) ?
      'warning' :
      validationState
  }
  ...

Later, feedback is given based on the presence of glitch-warning in the validation state, not the previous logic.
...
{
  validationState === 'glitch-warning' && <HelpBlock> ... </HelpBlock>
}

Thanks @jkao1 👍

@jkao1 Thanks for fixing this!


Facing issue while creating release android build

Inconsistent JVM-target compatibility detected for tasks 'compileReleaseJavaWithJavac' (17) and 'compileReleaseKotlin' (21)

Could you please provide me with
Kotlin version & gradle version?

@kishangohel waiting for your response.

gradle-8.9-all
Kotlin version "1.9.22"
@Mo0Khaled


hosts-file.net decomissioned

Hi @FadeMind
A few I had to make a new issue as I could not comment on #34 anymore. I get issue "Repository owner locked and limited conversation to collaborators yesterday"
hosts-file.net has been decomissioned, so there will be no overwriting after update from this URL. So, you can safely remove pornhubpremium.com without fear of overwriting, as it is a false positive

https://github.com/FadeMind/hosts.extras/commit/459408a4a64002a016276aa273ba91495f4d182e


Request Entity Too Large

Recently started getting the follow error, without any explicit change to Raven or Sentry configuration.  Google results are unrevealing.  Is there something known that can cause this?
Any proper ways of logging more fully the original AttributeError, which caused the Sentry error, besides disabling Sentry?
INFO:werkzeug:<IP_ADDRESS> - - [29/Apr/2015 01:02:51] "POST / HTTP/1.1" 500 -
ERROR:sentry.errors:Unable to reach Sentry log server: HTTP Error 413: Request Entity Too Large (url: https://app.getsentry.com/api/39671/store/, body: b'\r\n<title>413 Request Entity Too Large</title>\r\n\r\n
413 Request Entity Too Large
\r\n
nginx\r\n\r\n\r\n')
Traceback (most recent call last):
  File "/usr/local/lib/python3.4/site-packages/raven/transport/threaded.py", line 159, in send_sync
    super(ThreadedHTTPTransport, self).send(data, headers)
  File "/usr/local/lib/python3.4/site-packages/raven/transport/http.py", line 49, in send
    ca_certs=self.ca_certs,
  File "/usr/local/lib/python3.4/site-packages/raven/utils/http.py", line 62, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/local/lib/python3.4/urllib/request.py", line 461, in open
    response = meth(req, response)
  File "/usr/local/lib/python3.4/urllib/request.py", line 571, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/local/lib/python3.4/urllib/request.py", line 499, in error
    return self._call_chain(*args)
  File "/usr/local/lib/python3.4/urllib/request.py", line 433, in _call_chain
    result = func(*args)
  File "/usr/local/lib/python3.4/urllib/request.py", line 579, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 413: Request Entity Too Large
ERROR:sentry.errors:Failed to submit message: "AttributeError: 'dict' object has no attribute 'encode'"

Is this getsentry.com or are you hosting it yourself?

Getsentry.com
On Tuesday, April 28, 2015, David Cramer<EMAIL_ADDRESS>wrote:

Is this getsentry.com or are you hosting it yourself?
—
Reply to this email directly or view it on GitHub
https://github.com/getsentry/raven-python/issues/604#issuecomment-97283489
.

This would mean the packet is very large. I think we should do something on our end around logging, but it's a little complicated. We definitely should log a reasonable version of the message (beyond just what we give you here). Unfortunately without changes to the client I don't have a great answer.

Hm, ok. What composes the packet? I am working with a number large files,
perhaps one is getting itself attached to the error report somehow, and we
definetly wouldn't want or need that.
Happy to test out or make changes as advised.
On Tuesday, April 28, 2015, David Cramer<EMAIL_ADDRESS>wrote:

This would mean the packet is very large. I think we should do
something on our end around logging, but it's a little complicated. We
definitely should log a reasonable version of the message (beyond just what
we give you here). Unfortunately without changes to the client I don't have
a great answer.
—
Reply to this email directly or view it on GitHub
https://github.com/getsentry/raven-python/issues/604#issuecomment-97326958
.

Closing this out as it was (potentially) resolved elsewhere

nice, thank you

It was? I'm still experiencing 413 responses from getsentry.com when POSTing a 5.3MB payload.
Perhaps you could log something in Sentry when this happens so one knows an error occurred. Took some digging in syslogs to find the error.

@jmagnusson do you see this in the 5.6 release?

Yup, still. Sentry responded with an error: HTTP Error 413: Request Entity Too Large (url: https://app.getsentry.com/api/.../store/)

So this is still an issue, although thanks to your help earlier/elsewhere, it is being logged sufficiently locally.
A believe a couple actions should be taken:

Upon receiving a too large entity, the server should log a proxy exception, alerting the user that an event happened which was un-capturable.  This would prevent silent doom.
An API should be devised to all the automatic or selective truncation of large strings when errors are thrown.  E.g., if I have an attribute error on a dictionary with a large string key, in many cases I don't have any need to know the contents of that key, beyond perhaps the first 100 chars to indicate its further contents.

Seeing this as well from the error dump of a complex elasticsearch query.

It still hasn't been resolved?

Just got hit by this issue (not related to the python lib though). What's the maximum body size allowed by sentry?

Most of the time this is due to the configuration of the server. If this is getsentry.com the request limit is extremely high and there's no way you should be hitting it. If you are, then it likely means that the client side variable trimming isn't working correctly, or has been re-configured to send data that is too large.

This is getsentry.com and the issue is that the metadata I've submitted is simply too large and not due to an error in trimming (it exceeds 1Mb). @pehrlich mentioned that the sentry server could log an exception whenever a request that contains a large body is discarded, but that would require processing the whole message to find out the id which would defeat the original protection in place - unless, of course, the id can be obtained in another way (query parameter?) while still discarding an offending body.
The second @pehrlich's suggestion is inline we something that I wanted to suggest too - let the client preemptively calculate the body size and remove certain information (e.g. all metadata?) so that at least the most relevant pieces still won't go unnoticed.

Any news here? We are still getting this error 413 with getsentry.com.

We were having the same problem on self-hosted sentry. Of course, the problem was in request size limit in Nginx.

We are experiencing this issue with raven==5.36.0, using raven.transport.http.HTTPTransport, on sentry.io.

Still getting request entity too large:
2017-10-06 04:02:45,810|sentry.errors|ERROR|Sentry responded with an error: HTTP Error 413: Request Entity Too Large (url: https://sentry.io/api/<id>/store/) (base.py:682)

Any chance this could get prioritized? I'm missing exceptions from some of our most important endpoints because of it.

I think we will need to do some better pruning for the breadcrumbs which I assume are triggering this in the case mentioned above.

@mitsuhiko Any hints as to when this might be fixed?

I'm going to take a look at this.

I am also experiencing this issue. The excessive size in my case is certainly coming from the breadcrumbs

@mitsuhiko any update on status? 😄

@philpep i looked at this a few days back but we do not record an excessive amounts of crumbs by default. Any ideas what could be logged in your case?

(that would be sql queries etc. Just want to get an idea where to trim here)

I am running into the same issue on a React/Redux app:
Content-Length:183107
Is 183kb considred too large?

@fcoury The limit seems to be 100kb https://docs.sentry.io/learn/quotas/#attributes-limits
@mitsuhiko mistag 😉  Currently investigating, should have more info later today or tomorrow.

Having a request that is around 111KB dropped by sentry.io/api. That limit seems a little low - we simply log all of our redux actions and send them as breadcrumbs.

This issue almost 3 years old now. Will it ever be fixed?
I've always loved Sentry and felt confident in that it will notify us of any exceptions that occur in production, but this issue scuffs that feeling a bit.

@jmagnusson it should be very rare you'd see this, and might be more commonly happening with on-premise installs since max size is configurable. If you're seeing it on sentry.io let us know and we can probably just duct tape packet size in the mean time.

@dcramer We're using your hosted solution

@dcramer I'm using sentry.io and I'm getting it too.

@jmagnusson @peterbe are you still experiencing this?

are you still experiencing this?

As of 8 days ago I was. See my previous comment.
I can provide you more details but in private in case I do something silly that reveals too much.

I meant as in right now. We made changes yesterday which should have reduced the impact.

@dcramer Yes, but because I don't know how to corner this, here's what I did:
(Note: I'm doing this on a side-project so attention is restricted)
I injected some print in site-packages/raven/utils/http.py towards the end:
-   return opener.open(url, data, timeout)
+   try:
+        return opener.open(url, data, timeout)
+   except Exception:
+        print("EXCEPTION!!!!", url, url.get_full_url(), data[:1000])
+        raise

Then I hawkishly watch my uwsgi log file and I get this:
EXCEPTION!!!! <urllib.request.Request object at 0x7fd9103efb38> https://sentry.io/api/196160/store/ b'x\x9c\xec\xbdiw\xe2H\xb20\xfcW\xd4\xf5~p\xd5)\x97\xd9\xb7\xea;\xb7\x0f\x8b0xe\xf3\x82\xa7\xe6\xf4MP"\xc9\x08\t$
Sentry responded with an error: HTTP Error 413: Request Entity Too Large (url: https://sentry.io/api/196160/store/)
Traceback (most recent call last):
  File "/var/lib/django/songsearch/venv/lib/python3.5/site-packages/raven/transport/threaded.py", line 165, in send_sync
    super(ThreadedHTTPTransport, self).send(url, data, headers)
  File "/var/lib/django/songsearch/venv/lib/python3.5/site-packages/raven/transport/http.py", line 43, in send
    ca_certs=self.ca_certs,
  File "/var/lib/django/songsearch/venv/lib/python3.5/site-packages/raven/utils/http.py", line 67, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/lib/python3.5/urllib/request.py", line 472, in open
    response = meth(req, response)
  File "/usr/lib/python3.5/urllib/request.py", line 582, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python3.5/urllib/request.py", line 510, in error
    return self._call_chain(*args)
  File "/usr/lib/python3.5/urllib/request.py", line 444, in _call_chain
    result = func(*args)
  File "/usr/lib/python3.5/urllib/request.py", line 590, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 413: Request Entity Too Large
['OSError: write error']

@peterbe any chance you could try to capture data to a file and email that to david at sentry.io?

Aside, you can sign with PGP key if you're concerned: https://sentry.io/security/

@dcramer I don't think it needs to be signed up I've written a little hack now to generate these data files. I'll email you one if I get another exception. At the time of writing I haven't had one happen in a while.

The problem in this specific example is breadcrumbs are not truncating log messages. In this case theres an elasticsearch logger (not sure if yours or the official library), and an unbelievably large debug message which seems to be the full payload being inserted.

Stock Django 1.11 with no fancy logging specifically for elasticsearch_dsl. I appreciate that sometimes Elasticsearch barfs but there should still be an error sent to Sentry. I do use this little snippet for calling elasticsearch_dsl:
from elasticsearch.exceptions import (
    ConnectionTimeout,
    ConnectionError,
    TransportError,
    NotFoundError,
)

_es_operational_exceptions = (
    ConnectionTimeout,
    ConnectionError,
    TransportError,
)

def es_retry(callable, *args, **kwargs):
    sleep_time = kwargs.pop('_sleep_time', 1)
    attempts = kwargs.pop('_attempts', 10)
    verbose = kwargs.pop('_verbose', False)
    try:
        return callable(*args, **kwargs)
    except _es_operational_exceptions as exception:
        if attempts:
            attempts -= 1
            if verbose:
                print("ES Retrying ({} {}) {}".format(
                    attempts,
                    sleep_time,
                    exception
                ))
            time.sleep(sleep_time)
        else:
            raise

I don't see those ES Retrying  prints in the uwsgi logs.

@peterbe sorry I should have been clear that i was intending to fix it, but the behavior is poor in general.

any chance of deploying a new version of raven which includes the fix? This issue has been a real pain for a long time for us and we really want to try this fix.

@d-dorazio will be out by tomorrow.

I am still experiencing this issue even after updating to version 6.10.0.

I am having this error working with next.js and "@sentry/react": version 5.20.1 with the default configuration of React

Anyone having this issue, who thinks it might come down to breadcrumbs, you can set the maxBreadcrumbs init setting (default and max value: 100) to reduce the number of breadcrumbs conveyed.
https://github.com/getsentry/sentry-javascript/blob/7c142839036e77161a6f707196762eb718b723cc/packages/types/src/options.ts#L70-L74
Note the code comment is incorrect about the default being 30:
https://github.com/getsentry/sentry-javascript/blob/bd6028a9f0cfb00c79e46fd5b99ef2b442474bac/packages/hub/src/hub.ts#L38-L48

For reference, @davidpaley apparently solved his problem here: https://github.com/getsentry/sentry-javascript/issues/2798


Fix tag and manufacturer selection

fixes #96 #40
obsoletes #165

Manufacturers are working now :tada:


Regression in TS1.8 beta - refreshes all *.map files in VS 2015 too often

Hi,
I've installed the downloadable TS 1.8 beta on top of VS 2015 update 1 plus the servicing update (KB3110221) from January 2016.  Just trying to give all the facts  :)
I use VSTS in TFS mode for source control.  I have hundreds of TypeScript files in my ASP.Net *.csproj project.  The Javascript and map output files are also a part of the project and I use Mads Kristensen's file nesting plugin to nest the generated Javascript and map files beneath each TypeScript file so things are not too messy.  There's no grunt or gulp task runner - I just rely on TypeScript to generate new files when I save and when I build.
I have ReSharper 10 installed but have always had its TypeScript support disabled.
I do not have a tsconfig.json file.
Since installing TS 1.8 beta I've found that I can accidentally trigger, usually by mistyping and having intellisense try to be invoked on something that couldn't work, the TypeScript compiler to touch every single *.map file (and sometimes every *.js file) in my project.  It's very frustrating.  The files are identical except for the very last character in the map file (it looks like it's part of a hash maybe?).
I then visit the "TypeScript Build" page in my csproj's properties window and untick "Generate source maps" since they're causing me plenty of grief and I don't use them anyway.  However I save and close that window, reopen it and the tickbox is ticked again.  So I can't even disable them.
I can turn on some additional logs or something in VS if it would help.  It's a little sporadic as to when it will regenerate all the maps but I feel that it's often when I'm triggering some intellisense to appear.
I might roll back to 1.7 if I can't get the source maps generation disabled (I'm off to manually edit the csproj).

I managed to get source map generation disabled by editing the csproj by hand.  So far so good :)

it sounds to me that you have Compiler on Save enabled. every time you save a file, the compiler will regenerate your outputs. if this is something you do not want, you can disable it form your project properties, Typescript Build, then check off "Compile on Save".

Thanks @mhegazy - I have that enabled, but have always had that enabled since using TypeScript 9.x.  This "touch every single map file" behaviour is new in 1.8 beta (as far as I can tell) and the touch is very minor - only the last couple characters in the really long single-line map file change.  And it's every single map file in the project at once rather than just the map file of the TypeScript file I'm editing.
Disabling map file generation has at least stopped the problem for the moment.  I'm getting a new dev on the team shortly and I'd like for him to be able to use map files in the browser if that's his preference.  I'll enable it again later today or tomorrow and see if the problem resumes.

The only part of the system that writes to files is compile-on-save. if you have that disabled, i do not think this is the TypeScript language service that is doing this. can you share a project that exhibits the symptoms? i can not get it to repro locally.

@IanYates do you still see an issue here with TS 1.8.4?

closing for now. please reopen if it is still an issue.


Help Required: Unable to validate LocalDateTime (YYYY-MM-DDTHH:mm:ss) for payload in POST endpoint

I am trying to create a POST endpoint which accepts payload shape:
{

  "2022-03-17T10:30:00" :  [
    {
      "pId": "some-str-01",
      "val": "abc"
    }
  ],

  "2022-03-17T20:30" :  [
    { "pId": "some-str-02",  "val": "abc" },
    { "pId": "some-str-03",  "val": 123 },
    { "pId": "some-str-04",  "val": 123.12 },
    { "pId": "some-str-05",  "val":  false },
    { "pId": "some-str-06",  "val": {} },
    { "pId": "some-str-07",  "val": [] },
  ],

}

Which is an object of LocalDateTime as keys and List of Objects as values.
What I have tried:
{
      "endpoint": "/v1/category/{category_id}/history",
      "method": "POST",
      "extra_config": {
        "github.com/devopsfaith/krakend-ratelimit/juju/router": {
          "maxRate": 20,
          "clientMaxRate": 10,
          "strategy": "ip"
        },
        "validation/json-schema": {
          "type": "object",
          "propertyNames": {
            "type": "string",
            "format": "date-time"
          },
          "additionalProperties": {
            "type": "array",
            "items": {
              "type": "object",
              "properties": {
                "pId": { "type": "string" },
                "val": { "type": ["number", "boolean", "string", "array", "object"] }
              },
              "required": ["pId", "val"]
            }
          }
        }
      },
      "backend": [
        {
          "url_pattern": "/v1/category/{category_id}/history",
          "method": "POST",
          "host": [
            "{{ env "PRODUCT_API_HOST"}}"
          ],
          "extra_config": {
            "backend/http": {
              "return_error_details": "backend_product_api"
            }
          }
        }
      ]
 }

The validation/json-schema works fine for the ISO DateTime format with Zone offsets (OffsetDateTime format in Java).
For example: 2022-03-17T10:30:00+11:00 or 2022-03-16T23:30:00Z
Can someone help me how can I apply a validation for DateTime (LocalDateTime format in Java). As json-schema only supports formats:

datetime  (which is OffsetDateTime  YYYY-MM-DDTHH:mm:ssZ or YYYY-MM-DDTHH:mm:ss+HH:mm or YYYY-MM-DDTHH:mm:ss-HH:mm)
date (which is LoalDate  YYYY-MM-DD)
time (which is localtime HH:mm:ss)
duration (which is duration in days.)

What I am trying now is:
Use of regular expression pattern for LocalDateTime like:
"propertyNames": {
            "type": "string",
            "pattern": "regex-to-validate-localdatetime-is-valid"
 }

But this is gross, as the pattern is huge when I include year range (1900-2999) with leap year and month with 30 and 31 days validation.
Can someone shed some light in doing this in a better way.

Hi @bh4r4th ,
You would probably get better answers on the JSON schema repository. The question is not related to KrakenD itself, but to the usage of json schema.

I reached out to the json-schema admin on slack. They're very responsive and mentioned that as ISO isn't an open standard they didn't feel it was OK to reference its use.
In this particular scenario, I used a regex pattern to match the propertyNames which vaguely matches the format as LocalDateTime. If the timestamp is an invalid one, then my Kotlin (Java) API should handle it and return an error response.
In KrakenD, I am doing a pass through for error response. This should solve my above mentioned problem :)


Update bosh create-release docs

This commit updates the docs for the bosh create-release command so that they do not imply that the PATH positional parameter is an option to create a tgz, but instead it is an option for creating releases from release yml files.
@klakin-pivotal also worked on.

Looks good thanks!


Workaround for the problem with uvm_sequncer

It adds a workaround for the problem with uvm_sequncer: https://github.com/verilator/verilator/issues/4497. The 2nd parameter is optional and is equal to the 1st by default. Verilator doesn't handle it correctly, so always 2 parameters should be provided.

It is how these parameters are defined:
https://github.com/antmicro/uvm-verilator/blob/eb0cef0c4154386381196ec0142ed876bfc2ed1b/src/seq/uvm_sequencer.svh#L34
If you pass a value only to the first one, the 2nd should have the same value assigned. But it doesn't work yet in Verilator, so always values for both parameters should be passed.


Add awaiting merge tag in hackedu/hack-camp

It seems like it would be good to have an awaiting merge tag in hackedu/hack-camp. Less issues labeled as blocking = more win.
@hackedu/hack-camp Thoughts?

If there aren't any cons to this brought up by EOD I'll add the label tonight.

:+1:

Added an awaiting merge label to hacked/hack-camp
https://github.com/hackedu/hack-camp/labels

Cool with me.
On Mon, Aug 10, 2015 at 11:48 PM, Max Wofford<EMAIL_ADDRESS>wrote:

Added an awaiting merge label to hacked/hack-camp
https://github.com/hackedu/hack-camp/labels
—
Reply to this email directly or view it on GitHub
https://github.com/hackedu/meta/issues/98#issuecomment-129729510.

--
Zach Latta
hackEDU |<EMAIL_ADDRESS>