registration: replace string_id with realm id

This PR aims to solve the issue https://github.com/zulip/zulip/issues/14810
I have made the change in lib/users.py and replaced realm.string_id with realm.id in get_accounts_for_email function.
I have also fixed the corresponding tests.
Discussion: https://chat.zulip.org/#narrow/stream/2-general/topic/Use.20realm_id.20as.20value.20of.20the.20option.20in.20source.20realm.20selector/near/1062060

@edith007 Thanks for working on this!  I feel like there's more here to be fixed, possible?  Is there a front-end piece that needs to change in unison with this?  Or perhaps another backend endpoint?
@hackerkid Maybe you can provide a little more context in the issue if I'm correct here that there are more things to change.

@edith007 Thanks for working on this. You also need to update the HTML select input in the account creation page which allows user to copy their settings and preferences from an existing account in another realm. The select at the moment sends the subdomain instead of realm_id. So you need to update the registration form(HTML and JS if any) as well as the backed to make use of realm_id instead of backend.
To test this create a new realm with<EMAIL_ADDRESS>It will ask whether to copy the preferences from zulip realm in the final stage of realm creation.

Hi @hackerkid  @showell
I have made further changes so that both the front-end and back-end communicate using the realm_id instead of string_id in the case user specifies the source realm.
The backend is still receiving on value when none of the realm is chosen from the selector...
@timabbott has mentioned here that we want it to be something like None ...
I tried using the following approach to do so but I dont think this is working and might not even be the solution... What I am trying to do is replace on with None in register.html
here is a code snippet:

any help will be appreaciated!!

I have made some changes and I think I figured out a way of not using on keyword when not selecting any realm. I have replaced that with None.

@edith007 Can you take care of the failing tests.

@edith007 Thanks for working on this. The changes look good to me.

Hi @showell!
This PR is ready for review.

@edith007 thanks for working on this!  And sorry for the slow review -- this PR arrived soon after a baby joined my family :).
A few comments:

Can you explain what the story is with the "on" value for source_realm_id at the end of the branch?  I would have hoped we'd end up in a world where that field was always an integer.  I have a theory that this is somehow a type and we meant "no" originally?  In any case, I think adding a new commit (potentially a new first commit, or a new last commit) to change this to "" as the encoding for "don't import" makes sense to have this code read clearly.
For the commit message titles, I'd have spelled it more like "registration: Encode source realm as an integer." for the first one, and "registration: Rename source_realm field to source_realm_id.", or maybe just squashed them and used that first title.  An important role for commit message titles is signaling what part of the project something is in, and account "registration" is a lot better hint that "source realm selector", which requires the reader to know that we have such a selector in the registration flow.

Otherwise this looks great!

@edith007 it looks like you've updated this PR -- please always post a comment (detailing how you address the feedback) when you're ready for a next review, even if you also post something in Zulip.  When a maintainer looks at an issue thread where the last comment is feedback, it's unclear whether you've addressed the feedback or just rebased the commits (for example) without addressing it.

@timabbott ! thanks a lot for the review!!
For the case where we don't want to select any realm to import settings; I had tried to replace the "on" keyword with None.. and have also played around the idea of not passing the source_realm field when we dont want to import settings from a realm, but those didn't work out...
I have made the change you suggested, replaced the "on" keyword with "" and everything is working normally...
can you please review it again!

I just did that and the issue is there... thanks a lot for pointing it out @hackerkid!!
I am on it :)

@hackerkid @timabbott I have taken care of the failing issue and had written test for it... The problem was that the value of source_realm_id in form.data was an int and we were comparing it with a string and hence the value was not preserved... I have typecasted that to an int and have written a test for this case as well!
this PR is ready for another round of review!

After making the suggested changes i tested the following things:

make a organization "ORG-1" using<EMAIL_ADDRESS>change some Display Settings and Notifications in settings page.
make another org. using same<EMAIL_ADDRESS>and import the settings from "ORG-1" in "ORG-2"
all the changes that i made in "ORG-1" was imported in "ORG-2".

@edith007 can you fix the CI errors?

@edith007 can you fix the CI errors?

working on it!

@timabbott fixed the CI errors... can you please take a look?

@timabbott can you take a look when time permits.
Thanks :)


kfV, KfBP, overshooting, better crash logging and auto update.

No major issues to be found but can we credit shane

No major issues to be found but can we credit shane


unable to run install.sh [ubuntu 19.04]

while trying to run install.sh, errors pump up for some reason finally ends up manually install dependencies in that .sh file
env:
Ubuntu 19.04
python 3.6
error:
+ [[  == linux-gnu ]]
install.sh: 24: install.sh: [[: not found
+ [[  == darwin* ]]
install.sh: 30: install.sh: [[: not found
+ echo The OS '' is not supported (Only Linux and MacOS is).  Feel free to contribute the install for a new OS.
The OS '' is not supported (Only Linux and MacOS is).  Feel free to contribute the install for a new OS.
+ exit 1

Hmm, that is odd. We have tested it on Ubuntu 19.04 and I just tested it again from a fresh checkout and it works fine.
I guess try running the commands in that script manually?
sudo apt-get update
sudo apt-get install git virtualenv cmake python3 python3-dev python3-pip python3-setuptools python3-wheel
git clone -b 'v2.2.4' --single-branch --depth 1 https://github.com/pybind/pybind11.git
git clone -b 'develop' --single-branch --depth 1 https://github.com/jblespiau/dds.git  open_spiel/games/bridge/double_dummy_solver
git clone -b 'master' --single-branch --depth 1 https://github.com/abseil/abseil-cpp.git open_spiel/abseil-cpp

Can you also tell me what the output of the following commands are?
which \[
which test

yup @lanctot, I ended up these commands manually, and then works...

Ok, great but I'm still trying to figure out what the issue is/was in case others experience this.
Seem like coreutils is installed correctly, so can you try a few more commands for me? (But are you sure that second one is not /usr/bin/test?)
ls -l /usr/bin/\[
ls -l /user/bin/test

of course
$ ls -l /usr/bin/\[
> -rwxr-xr-x 1 root root 51384 Jan 18 2018 '/usr/bin/\['
$ ls -l /user/bin/test
> -rwxr-xr-x 1 root root 47288 Jan 18 2018 '/usr/bin/test'

Hmm, ok I have no idea what could be the problem then. My guess is that the install.sh file got corrupted somehow. Glad it worked with the manual commands. Thanks!


tab "exec" on statistics (collectd) - not shown and not working since new trunk version

on latest trunk it does not shown the tab "exec" on collectd
https://<IP_ADDRESS>/cgi-bin/luci/admin/statistics/graph
if i try the link manualyl:
link: https://<IP_ADDRESS>/cgi-bin/luci/admin/statistics/graph/exec
gives the error:
/usr/lib/lua/luci/dispatcher.lua:393: Access Violation
The page at 'admin/statistics/graph/exec/' has no parent node so the access to this location has been denied.
This is a software bug, please report this message at https://github.com/openwrt/luci/issues
stack traceback:
[C]: in function 'assert'
/usr/lib/lua/luci/dispatcher.lua:393: in function 'dispatch'
/usr/lib/lua/luci/dispatcher.lua:144: in function </usr/lib/lua/luci/dispatcher.lua:143>
any ideas whats wrong ?

ok, i checked now , which file is the wrong one ...
i overwrote the file: luci_statistics.lua
and then it was working again. so, there is the error anyhow ...
see /usr/lib/lua/luci/controller/luci_statistics
and attached the good(old) and the new(bad) ..
pls can you fix that anyhow ?
if wanted, i can add both files ...
luci_statistics.lua.zip

One possible reason:
@feckert added new label definitions for most plugins with cd1e8cc6b94e in March, but apparently exec was not among the 27 plugins done at that time.   (Looking at the plugin list in staitistics, at least email and exec are missing from that commit.( But I haven't looked if labels for those are really needed.)
You might test if adding a similar label definition file for exec as for thee others would help.

To get some value from system which could not get collected by a native collectd plugin, we normally use the exec plugin.
With my change could you still configure the exec plugin?
If you have written a definition file for your exec plugin and put the into the directory applications/luci-app-statistics/luasrc/statistics/rrdtool/definitions you also have to add the item callback so it could be shown on the tab selection page.

are you having an example for it ? sorry, but i don'T know what i should add more ...
the exec.lua demo file is included on the exec mod what i installed - i guess it is the same principle ...
or maybe the manpages are not up2date ?
what is here missing ?
my exec.lua file is looking like that:
/usr/lib/lua/luci/statistics/rrdtool/definitions/exec.lua
`
module("luci.statistics.rrdtool.definitions.exec", package.seeall)
function rrdargs(graph, plugin, plugin_instance)
if "gsminfo" == plugin_instance then
return {
title = "%H: GSM Signal",
vlabel = "dBI",
number_format = "%5.1lf",
y_min = "0",
-- y_max = "100",
-- alt_autoscale_max = true,
autoscale_max = true,
-- noarea = false,
-- overlay = true,
data = {
types = { "gsm_signal" },
sources = { gsm_signal = { "RSSI", "MODE", "RSRP", "RSCP", "RSRQ", "SINR", "ECIO" }
-- sources = { gsm_signal = { "RSSI", "MODE", "RSRP", "RSCP", "RSRQ", "SINR", "ECIO" }
},
options = {
gsm_signal__MODE = { color = "ff0000", title = "Mode(4G=40 / 3G=30 / 2G=20)", overlay = true, noarea = false },  -- red
gsm_signal__RSSI = { color = "00bb00", title = "RSSI", overlay = true, noarea = false }, -- green
gsm_signal__RSRP = { color = "00ffff", title = "RSRP", overlay = true, noarea = true },  -- cyan
gsm_signal__RSCP = { color = "0000ff", title = "RSCP", overlay = true, noarea = true },  -- blue
gsm_signal__RSRQ = { color = "ff00ff", title = "RSRQ", overlay = true, noarea = true },  -- violet
gsm_signal__SINR = { color = "dd9900", title = "SINR", overlay = true, noarea = true },  -- orange
gsm_signal__ECIO = { color = "000000", title = "ECIO", overlay = true, noarea = true }   -- black
}
}
}
end
if "speedcheck" == plugin_instance then
    return {
        title = "%H: Download Speedcheck (SQM)",
        vlabel = "kbit/sec",
        number_format = "%5.3lf",
        -- y_min = "0",
        -- y_max = "1",
        -- alt_autoscale_max = true,
        autoscale_max = true,
        -- noarea = false,
        -- overlay = true,
        data = {
            types = { "SQM_speed" },
            sources = { SQM_speed = { "DOWNLOAD_SQM", "DOWNLOAD_REAL", "UPLOAD_SQM", "UPLOAD_REAL" }
            },
            options = {
                SQM_speed__DOWNLOAD_SQM = { color = "00dd00", title = "Download Speed (SQM)", overlay = true, noarea = false, total = false }, -- green
                SQM_speed__DOWNLOAD_REAL = { color = "00ffff", title = "Download Speed (REAL)", overlay = true, noarea = true, total = false }, -- cyan
                SQM_speed__UPLOAD_SQM = { color = "bb0000", title = "Upload Speed (SQM)", overlay = true, noarea = false, total = false, flip = true }, -- red
                SQM_speed__UPLOAD_REAL = { color = "dd9900", title = "Upload Speed (REAL)", overlay = true, noarea = true, total = false, flip = true } -- orange
            }
        }
    }
end

if "internet" == plugin_instance then
return {
title = "%H: Internet Speed (speedtest.net)",
vlabel = "Mbit/sec",
number_format = "%5.3lf",
-- y_min = "0",
-- y_max = "1",
-- alt_autoscale_max = true,
autoscale_max = true,
-- noarea = false,
-- overlay = true,
data = {
types = { "speedtest" },
sources = { speedtest = { "DOWNLOAD", "UPLOAD", "PING" }
},
options = {
speedtest__DOWNLOAD = { color = "00dd00", title = "Download", overlay = true, noarea = false, total = false }, -- green
speedtest__UPLOAD = { color = "ff0000", title = "Upload", overlay = true, noarea = false, total = false, flip  = true },  -- red
speedtest__PING = { color = "0000ff", title = "Ping (sec)", overlay = true, noarea = true, total = false }  -- blue
}
}
}
end
if "ifaceuptime" == plugin_instance then
    return {
        title = "%H: Interfaces(VPN) Uptime Information",
        vlabel = "sec",
        number_format = "%5.1lf",
        -- y_min = "0",
        -- y_max = "100",
        -- alt_autoscale_max = true,
        -- autoscale_max = true,
        -- noarea = false,
        -- overlay = true,
        data = {
            types = { "if_uptime" },
            sources = { if_uptime = { "MODEM", "MODEM_MW", "WAN", "WAN_MW", "VPNROUT03", "VPNROUT03_MW", "VPNROUT04", "VPNROUT04_MW", "VPNROUT05", "VPNROUT05_MW" }
            },
            options = {
              if_uptime__MODEM = { color = "00dd00", title = "Uptime MODEM", overlay = true, noarea = false },                           -- #2 green
              if_uptime__MODEM_MW = { color = "009900", title = "Online MODEM", overlay = true, noarea = true },           -- #2 green
              if_uptime__WAN = { color = "007000", title = "Uptime WAN", overlay = true, noarea = true },                                -- #1 dark green
              if_uptime__WAN_MW = { color = "003000", title = "Online WAN", overlay = true, noarea = true },               -- #1 dark green
              if_uptime__VPNROUT03 = { color = "00ffff", title = "Uptime VPN_ROUT03", overlay = true, noarea = true },                   -- #5 cyan
              if_uptime__VPNROUT03_MW = { color = "00bbbb", title = "Online VPN_ROUT03", overlay = true, noarea = true },  -- #5 cyan
              if_uptime__VPNROUT04 = { color = "ff00ff", title = "Uptime VPN_ROUT04", overlay = true, noarea = true },                   -- #6 pink
              if_uptime__VPNROUT04_MW = { color = "bb00bb", title = "Online VPN_ROUT04", overlay = true, noarea = true },  -- #6 pink
              if_uptime__VPNROUT05 = { color = "990099", title = "Uptime VPN_ROUT05", overlay = true, noarea = true },                   -- #7 violet
              if_uptime__VPNROUT05_MW = { color = "550055", title = "Online VPN_ROUT05", overlay = true, noarea = true }  -- #7 violet
            }
        }
    }
end

end
`

i guess we can close that ticket: (ort maybe you want to insert a demo package ?.
if wanted i can help to add such kind of ....
i had to add only the return through the translate stuff ...
/usr/lib/lua/luci/statistics/rrdtool/definitions/exec.lua

module("luci.statistics.rrdtool.definitions.exec", package.seeall)

+function item()
+	return luci.i18n.translate("Exec")
+end
+
function rrdargs(graph, plugin, plugin_instance)
    -- For $HOSTNAME/exec-foo-bar/temperature_baz-quux.rrd, plugin will be
    -- "exec" and plugin_instance will be "foo-bar".  I guess graph will be
    -- "baz-quux"?  We may also be ignoring a fourth argument, dtype.
    if "gsminfo" == plugin_instance then

+function item()

return luci.i18n.translate("Exec")

You could add your individual translation. For example GSM info.

+end


Unwanted selector combination and reordering

cssmin is combining selectors with the same property set, but in doing so, reorders them in an unwanted way that breaks the CSS ordering.
Example:
.header-section + .photo-background.header-collection {
    margin-top: 0; }

.block {
    margin: 2em 1.5%; }
@media screen and (min-width: 972px) {
    .block {
        margin: 3em 2%; } }

.block-list {
    margin-top: 0; }

...is minified to...
.block-list, .header-section + .photo-background.header-collection {
    margin-top: 0; }

.block {
    margin: 2em 1.5%; }
@media screen and (min-width: 972px) {
    .block {
        margin: 3em 2%; } }

(Spacing added to minified version.)
As you can see, the selector combination breaks the CSS ordering, and .block.block-list takes the wrong margin-top. Is there some way to avoid this selector combination? Or at least make it less aggressive?

Those 2 versions are equivalent. What's the issue exactly?
You don't have any selector for .block.block-list in that example.

@timaikens which version of cssmin thus clean-css do you use (npm ls clean-css can be handy)? I cannot replicate this behavior in latest 3.4 or anywhere in 4.0.x.

@jakubpawlowicz
<EMAIL_ADDRESS><EMAIL_ADDRESS>
Thanks for looking!

Reinstalling grunt-contrib-cssmin will bring clean-css to 3.4.24 which works just fine. Sorry for trouble!

Ahh, just out of date, I suppose 😞. Will update and see if it's fixed. Thank you!

@timaikens any updates or should I close the ticket?

@jakubpawlowicz  Ah, go ahead and close the ticket - waiting to get on the same page with the whole team, and made a little band-aid fix in the meantime. Thanks so much for your help!

👍


[admin] Fixed auto-complete relations #75

Fortunately from Django 2.0 auto-complete is already intergrated.
The relations to subnets were displayed as selects.
When database becomes too populated loading all subnets becomes slow.
Hence the need to implement auto-complete fields instead of selects.
Fixes #75

sorry for the delay had some issues in getting started

Pull Request Test Coverage Report for Build 270

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 251:
0.0%

Covered Lines:
477

Relevant Lines:
477

💛  - Coveralls

Oh oh sorry i will correct that thanks
On Tue, Feb 19, 2019, 18:21 Ajay Tripathi<EMAIL_ADDRESS>wrote:

@atb00ker approved this pull request.
Hello, looks good, thanks 👍
(P.S: You might want to check that local settings for git, the commit is
not made by your name rather "root")
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/openwisp/django-ipam/pull/77#pullrequestreview-205345857,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Aax0WMqAsGnYvtz6Fck4YcLR7OECgcigks5vPDKKgaJpZM4a_BzR
.

@pacicap do you want to still correct the email in your commit so you can appear in the list of contributors?

Yes @nemesisdesign I will like to correct it.

Correcting that Wright away

@nemesisdesign i just corrected my commit name. sorry for the delay.


Comments are not indented properly in switch case statement

Expected:
switch (node.kind) {
	case SyntaxKind.ClassDeclaration: return SyntaxKind.ClassKeyword;
		if ((<MethodDeclaration>node).asteriskToken) {
			return SyntaxKind.AsteriskToken;
		}
		// fall-through

	case SyntaxKind.PropertyDeclaration:
}

Actual:
switch (node.kind) {
	case SyntaxKind.ClassDeclaration: return SyntaxKind.ClassKeyword;
		if ((<MethodDeclaration>node).asteriskToken) {
			return SyntaxKind.AsteriskToken;
		}
	// fall-through

	case SyntaxKind.PropertyDeclaration:
}

Copying the note from the original PR that raised this issue:

technically it is a leading comment for case clause, not a trailing comment for a block. Current behavior is preferable for cases like the one below. Here I definitely don't want comments for cases to be aligned with statements in previous case clause.

switch(a) {
    // handling Value.A
    case Values.A:
         break;
    // handling Value.B
    case Values.B:
         break;
    // handling Value.C
    case Values.C:
         break;
}

Then it shouldn't be a bug. Though the case statements feel kind of like a block, and in blocks the last comments preceding the closing bracket are indented the same way as other elements in the  block.

The problem is it is hard to know the intent,  i.e. commenting the next case label, or the last line in the block. the simple solution, either way you park it, will break one group of comments.

Wait why is it a leading comment for the block? It's not immediately above the case clause


🐛 [firebase cloud messaging] Push notification not working in android

I have implemented fcm cloud messaging and I receive notification in foreground and background which invokes method onMessage and onResume but the problem persists when the app is closed or terminated, no push receiving to the device in android at that moment, iOS app works correctly.
Tried several methods like changing  notification structure coming from server side, including click_action, sending without notification message etc.  but no change. Can anybody provide me a solution for this.

Hi @imJithin777
Could you please provide your flutter doctor -v and flutter pub deps -- --style=compact?
Does the official example not work for you?
Thank you

Actually the issue of the notification not received when app terminated or closed is from android version 8.1 (Oreo) to downwards, for 9 to higher it works finely

Could you please provide the missing information?

Please correctly fill out the issue template, without this, we can not help you properly.
Locking and closing this issue. Feel free to raise another issue that correctly follows the issue template with more details
Thank you


你好，当运行ipython notebook DSS-tutorial.ipynb时报错AttributeError: 'numpy.ndarray' object has no attribute 'mask'，将问有类似的问题出现吗

No idea about your case. Sorry about it. Maybe you can update your numpy to a latest version but not sure whether works

OK, Thx


feat(sdk): Support for the OAuth Discoverable Client ID Scheme

Support for the OAuth Discoverable Client ID Scheme described in https://mattrglobal.github.io/draft-looker-oauth-client-id-scheme/draft-looker-oauth-client-id-scheme.html.
Added documentation for how to use this scheme with Wallet-SDK.
Updated documentation for the other methods of getting/providing a client ID.
Eliminated some code duplication by doing some refactoring.

Codecov Report
Patch coverage: 96.96% and project coverage change: +0.10% :tada:

Comparison is base (fe4a68a) 89.69% compared to head (3790453) 89.79%.

:exclamation: Current head 3790453 differs from pull request most recent head 5741113. Consider uploading reports for the commit 5741113 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #530      +/-   ##
==========================================
+ Coverage   89.69%   89.79%   +0.10%
==========================================
  Files          97       98       +1
  Lines        3745     3745
==========================================
+ Hits         3359     3363       +4
+ Misses        257      255       -2
+ Partials      129      127       -2

Files Changed
Coverage Δ

cmd/wallet-sdk-gomobile/openid4ci/interaction.go
95.91% <95.91%> (ø)

...k-gomobile/openid4ci/createauthorizationurlopts.go
72.72% <100.00%> (+10.22%)
:arrow_up:

...k-gomobile/openid4ci/issuerinitiatedinteraction.go
88.17% <100.00%> (-2.34%)
:arrow_down:

...k-gomobile/openid4ci/walletinitiatedinteraction.go
75.40% <100.00%> (+0.74%)
:arrow_up:

pkg/openid4ci/createauthorizationurlopts.go
80.00% <100.00%> (+5.00%)
:arrow_up:

pkg/openid4ci/interaction.go
86.99% <100.00%> (+0.12%)
:arrow_up:

pkg/openid4ci/issuerinitiatedinteraction.go
91.79% <100.00%> (ø)

pkg/openid4ci/walletinitiatedinteraction.go
72.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Large bundle size with webpack v4

I may be missing something, but the only way I was able to get the bundle size own in v4 was to import the components like this: import Pane from 'evergreen-ui/esm/layers';.
Also, why is @blueprintjs a dependency, I am not using it at all in the components I am importing and it is still a part of my bundle.

Unfortunately this doesn't do anything about evergreen-ui/esm/icon/Icon.js. It still contains all of @blueprintjs/icons
I had to edit the Icon.js file and do the same thing to reduce the bundle.

Originally posted by @epitaphmike in https://github.com/segmentio/evergreen/issues/311#issuecomment-442190755

@epitaphmike Can you paste the Webpack output for a build when importing the components the "normal" way and also the output when using the esm modules? I trust the Webpack output more than the VS Code Import Cost extension.
As far as the @blueprint dependencies, you can see here that this project uses the Blueprint icons.

For the icons, we may need to fork @blueprint because it doesn't seem like they are investing in tree-shaking support any time soon.
As for the rest of evergreen, it should be tree-shakable. @dericgw is right – the webpack output will be the best way to diagnose your bundle size issues.

Cross posting from #311:
I don't think the VS Code Import Cost plugin does tree shaking, it just traces all the files imported from the file you imported. To see the real tree shaken size you should use the webpack-bundle-analyzer.
As for the icons size issue, I'm currently working on tree shaking support for the icons. In Evergreen v5 you'll import individual icons directly instead of referencing them via a string, which will allow Webpack remove almost all of the icons (since less than 5% of them are used internally).
For example, this:
import { Icon } from 'evergreen-ui'
<Icon icon="cross" />

Will become this:
import { CrossIcon } from 'evergreen-ui'
<CrossIcon />

@Rowno Attached is a screenshot of the evergreen-ui bundle from the webpack-bundle-analyzer
I am using evergreen in 3 files with the following imports.
import { Popover, Pane, Switch, Text, Button, Select } from 'evergreen-ui';
import { Pane, Dialog, Text } from 'evergreen-ui';
import { toaster } from 'evergreen-ui';

This is the bundle with individual imports
eg.
import Popover from 'evergreen-ui/esm/popover';
import Pane from 'evergreen-ui/esm/layers';
import Switch from 'evergreen-ui/esm/switch';
import Text from 'evergreen-ui/esm/typography';
import Button from 'evergreen-ui/esm/buttons';
import Select from 'evergreen-ui/esm/select';

I'm created this reduced test case that proves that Webpack's tree shaking works on Evergreen. I would make sure that you're using Webpack 4 and that it's running in production mode. Obviously the icons still need to be made tree shakable though.
https://github.com/Rowno/evergreen-tree-shaking

evergreen-tree-shaking.zip

@Rowno I appreciate your assistance on this and your repo. Unless something is not configured properly on my end I am not understanding why my builds aren't the same as yours. I'll chip away at this a bit more and post my results. Thanks again for your help.

I noticed that Webpack doesn't tree shake in development mode if that helps.

I have found the issue. I forked the repo and added React to make this a more real life example.
This is the fork with the master branch just adding babel-preset-react
https://github.com/epitaphmike/evergreen-tree-shaking/tree/master
presets: ['react']
This is the fork with the with-preset-env branch adding babel-preset-react and babel-preset-env
https://github.com/epitaphmike/evergreen-tree-shaking/tree/with-preset-env
presets: ['env', 'react']
When adding the babel-preset-env, it seems tree shaking no longer works.
After doing some more digging, if I add {modules: false} to the env preset, all is back to normal.
https://github.com/epitaphmike/evergreen-tree-shaking/tree/with-preset-env-modules-false
presets: [['env', { modules: false }], 'react']

I am at a total loss..... But from the looks of it, it is not an evergreen-ui issue. Thanks for the help

I almost gave up.....
But for anyone who comes across this in the future,
Make sure you don't have a .babelrc file overwriting your webpack config.
The .babelrc file had no { modules: false }
{
  "presets": ["env", "react"],

  "plugins": ["transform-class-properties", "transform-object-rest-spread"]
}

😢 definitely huge haha, I like Feather's icons better anyway personally, leaving them out would be nice

I've been using icongr.am to test icons first, then once I like what I have chosen, I convert them into icon components. It has kept my bundle size down tremendously.

Hm, yeah I think the right away to handle this would be to extract the icons from the package. We can provide some defaults that are used internally by evergreen components (which we would probably allow you to swap out with your own).
If we could get tree-shaking though... that would largely solve the problem.

would be nice if it were light enough to use for marketing sites as well as apps, could be a pain to strip all the css-in-js colors/typography and port them back into vanilla CSS, but might be a non-goal for Evergreen I imagine?

I started working on making the blueprint icons tree shakable in this branch, but haven't gotten around to finishing it: https://github.com/segmentio/evergreen/tree/icon-code-splitting


[BUG] nexa run bark-small:fp16 fails with ValueError: Failed to load model from file: /Users/user/.cache/nexa/hub/official/bark-small/fp16.gguf

Issue Description
I am trying to run TTS, but getting ValueError: Failed to load model from file: /Users/user/.cache/nexa/hub/official/bark-small/fp16.gguf when I run.
Steps to Reproduce
~/repo nexa run bark-small:fp16

Downloading bark-small/fp16.gguf...
fp16.gguf: 100%|███████████████████████████████████████████████████████████████████████████████████████████████████| 804M/804M [00:19<00:00, 43.8MB/s]
Successfully downloaded bark-small/fp16.gguf to /Users/user/.cache/nexa/hub/official/bark-small/fp16.gguf
Successfully pulled model bark-small:fp16 to /Users/user/.cache/nexa/hub/official/bark-small/fp16.gguf, run_type: NLP
Error loading GGUF models, please refer to our docs to install nexaai package: https://docs.nexaai.com/getting-started/installation
Traceback (most recent call last):
  File "nexa/gguf/nexa_inference_text.py", line 100, in _load_model
  File "nexa/gguf/llama/llama.py", line 364, in __init__
  File "nexa/gguf/llama/_internals_transformers.py", line 55, in __init__
ValueError: Failed to load model from file: /Users/user/.cache/nexa/hub/official/bark-small/fp16.gguf

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "nexa/cli/entry.py", line 27, in run_ggml_inference
  File "nexa/gguf/nexa_inference_text.py", line 72, in __init__
  File "nexa/utils.py", line 155, in wrapper
  File "nexa/gguf/nexa_inference_text.py", line 110, in _load_model
  File "nexa/gguf/llama/llama.py", line 364, in __init__
  File "nexa/gguf/llama/_internals_transformers.py", line 55, in __init__
ValueError: Failed to load model from file: /Users/user/.cache/nexa/hub/official/bark-small/fp16.gguf

I can see it though when I look at the list:
~/repo nexa list
+-----------------------------------+------+-----------------+------------------------------------------------------------------------------------+
| Model Name                        | Type | Run Type        | Location                                                                           |
+-----------------------------------+------+-----------------+------------------------------------------------------------------------------------+
| FLUX.1-schnell:flux1-schnell-q4_0 | gguf | Computer Vision | /Users/user/.cache/nexa/hub/official/FLUX.1-schnell/flux1-schnell-q4_0.gguf |
| FLUX.1-schnell:t5xxl-q4_0         | gguf | Computer Vision | /Users/user/.cache/nexa/hub/official/FLUX.1-schnell/t5xxl-q4_0.gguf         |
| FLUX.1-schnell:ae-fp16            | gguf | Computer Vision | /Users/user/.cache/nexa/hub/official/FLUX.1-schnell/ae-fp16.gguf            |
| FLUX.1-schnell:clip_l-fp16        | gguf | Computer Vision | /Users/user/.cache/nexa/hub/official/FLUX.1-schnell/clip_l-fp16.gguf        |
| bark-small:fp16                   | gguf | NLP             | /Users/user/.cache/nexa/hub/official/bark-small/fp16.gguf                   |
+-----------------------------------+------+-----------------+------------------------------------------------------------------------------------+

OS
MacOS 14.4.1
Python Version
N/A
Nexa SDK Version
<IP_ADDRESS>
GPU (if using one)
Apple M2

pip uninstall nexaai
CMAKE_ARGS="-DGGML_METAL=ON -DSD_METAL=ON" pip install nexaai==<IP_ADDRESS> --prefer-binary --index-url https://github.nexa.ai/whl/metal --extra-index-url https://pypi.org/simple --no-cache-dir


cw1155-base, cw1155-metadata-onchain, cw1155-royalties

This PR adds a basic implementation of ERC-1155 Multi Token Standard, along with the following extensions:

On-Chain Metadata
On-Chain Royalties (based off CW-2981-Royalties)

ref:

ERC-1155
ERC-1155 API

testing this out asap - thanks for the contribution. Any statement regarding the current state and issues of this implementation possible? Thanks

testing this out asap - thanks for the contribution. Any statement regarding the current state and issues of this implementation possible? Thanks

@elix1er apologies for delay, just updated PR with details on the current state. No known issues yet, but will be testing this out more this week and update accordingly.


System.IO.DirectoryNotFoundException: 找不到本机库目录: c:\windows\system32\inetsrv\viewfacecore\win\x64

I use viewfaceCore in asp.net application and it works on local But
when I Published My app and  uploaded it to server and it gave this error .
System.IO.DirectoryNotFoundException: 找不到本机库目录: c:\windows\system32\inetsrv\viewfacecore\win\x64
I go to this path
c:\windows\system32\inetsrv\viewfacecore\win\x64
and copy files there .
But it does not solve .
My photo Attach .

fixed


chore: update ui before the release

Looks good to me. It is pointing to the latest commit done yesterday afternoon. Thanks for the update


Error when BOSH_RELEASES_DIR doesn't exist

Previously filed bug asking BOSH_RELEASES_DIR environment variable to be
required instead of silently using ~/workspace. Requiring the
environment variable might be a bit heavy handed from a UX standpoint,
how about we error if the BOSH_RELEASES_DIR doesn't exist? This
preserves same behavior when user clones to ~/workspace, but exits 1 if
the directory doesn't exist, e.g. in a concourse pipeline.

Hey @SocalNick
We're actually going to move that stub from diego-release into cf-release, and always merge it in for the BOSH-Lite case, and just get rid of all this BOSH_RELEASES_DIR silliness.
See: https://www.pivotaltracker.com/story/show/108282040
Closing this PR in lieu of that work.


Added share app functionality(issue #336) and created settings section(issue #340)

Description
For #336,
I've added the share application functionality, using which the use would be able to share the application to various platforms, including the social media applications, mail services, copying, and so on. This is done using the regular share intent.

For #340,
I've implemented the settings section in the application, which can be accessed from the bottom navigation menu. Apart from that, I've also added the basic settings features in the settings section.

Fixes #336 Fixes #340
Have you read the Contributing Guidelines on Pull Requests?

[x] Yes
[ ] No

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[x] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

@avinashkranjan I've completed the implementation for the two projects issues: #336 and #340. Please review this PR. Thank you!


adapting to live stream using LFLiveKit

your project is the best I can find for implementing CVPixelBuffer and FPV extensions. I'm trying to use LFLiveKit to pass the CVPixelBuffer along to an RTMP destination. In your code, where would be the right place to pass the CVPixelBuffer frames to? I'm attempting this:
func videoProcessFrame(_ frame: UnsafeMutablePointer<VideoFrameYUV>!) {
//        let resolution = CGSize(width: CGFloat(frame.pointee.width), height: CGFloat(frame.pointee.height))

        if frame.pointee.cv_pixelbuffer_fastupload != nil {
            //  cv_pixelbuffer_fastupload to CVPixelBuffer
            let cvBuf = unsafeBitCast(frame.pointee.cv_pixelbuffer_fastupload, to: CVPixelBuffer.self)
            pixelBuffer = cvBuf
            print("pushed video1")

        } else {
            // create CVPixelBuffer by your own, createPixelBuffer() is an extension function for VideoFrameYUV
            pixelBuffer = createPixelBuffer(fromFrame: frame.pointee)
            guard let cvBuf = pixelBuffer else { return }
            print("pushed video2")
        }
        session?.pushVideo(pixelBuffer)
    }

The stream technically starts as I'm getting an error on my server, but I don't know if I'm calling pushVideo in the right spot to continuously push the CVPixelBuffer frames along.

@sgallo0692  It looks good to me🤔  . Can you post the error you got from your server ?

not so much an error now - actually have the streaming working as I dropped LFLiveKit and used the built in DJIRTMPMuxer class, but I'm getting heavy intermittent distortion of the video. I'm going to try testing some changes to videoFeed + videoProcessFrame functionality but not sure if you've seen this:


Community builds need cloc installed on behemoths

via, like, you know, sudo apt-get install cloc or whatever
@adriaanm can you either do this, or help me do it myself? I don't know how to ssh to the behemoths anymore. I'll need to know eventually, you can judge whether you'd rather walk me through it now, or just do the installation and we'll come back to the setup/training/documentation when fewer things are exploding

Done:  for i in jenkins-worker-behemoth-{1,2,3}; do ssh $i sudo apt-get install -y cloc; done

thanks! (and also, I can ssh to both master and the behemoths now)


Adding static Objects to the Reach Task

Hey, i am trying to modify the Reach tasks by adding random static objects as Obstacles. Are there any tips of how to add those? #

You can try taking a look at insertion of objects inside drl_grasping/envs/randomizers/manipulation.py (e.g. randomize_object_models() or randomize_object_primitives()). I don't fully remember the state of code at version 1.1.0, so it might not be super modular... but you will see.
The list of currently available models (including objects) is inside drl_grasping/envs/models directory. You can add custom ones if you need (by using any of the current models as a template), or just use drl_grasping/envs/models/random_object.py with a specific dataset of SDF models (from Fuel or local Fuel cache).
If you add objects, visual observations should be usable straight away (colour and depth image obs). If you want to utilise state-based observations (vanilla Reach task), then you probably want to add these obstacles into the observation space somehow (here and here). I should note that I have not experimented a lot with the Reach task, as I only used it for quick sanity tests during the early development. It was much simpler to solve this task (get decent results) compared to the Grasp task though (quite simple to solve since actions are in Cartesian space).

Thanks for your tips. :)


Catch crash. Invalid read of size 8

Hi
When I have two test_cases with same name and description, a crash appears. Test cases:
TEST_CASE ("A", "[obd parsing]")
{
}

TEST_CASE ("A", "[obd parsing]")
{
}

valgrind output:
==14080== Invalid read of size 8
==14080==    at 0x4ECB3A9: std::ostream::sentry::sentry(std::ostream&) (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.19)
==14080==    by 0x4ECBA68: std::basic_ostream<char, std::char_traits<char> >& std::__ostream_insert<char, std::char_traits<char> >(std::basic_ostream<char, std::char_traits<char> >&, char const*, long) (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.19)
==14080==    by 0x4ECBE57: std::basic_ostream<char, std::char_traits<char> >& std::operator<< <std::char_traits<char> >(std::basic_ostream<char, std::char_traits<char> >&, char) (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.19)
==14080==    by 0x46D725: Catch::(anonymous namespace)::PosixColourImpl::setColour(char const*) (catch.hpp:6375)
==14080==    by 0x46D51C: Catch::(anonymous namespace)::PosixColourImpl::use(Catch::Colour::Code) (catch.hpp:6353)
==14080==    by 0x46D8B8: Catch::Colour::use(Catch::Colour::Code) (catch.hpp:6409)
==14080==    by 0x46D7F9: Catch::Colour::Colour(Catch::Colour::Code) (catch.hpp:6401)
==14080==    by 0x485C61: Catch::TestRegistry::registerTest(Catch::TestCase const&) (catch.hpp:5755)
==14080==    by 0x46CE1E: Catch::(anonymous namespace)::RegistryHub::registerTest(Catch::TestCase const&) (catch.hpp:5994)
==14080==    by 0x46CB8D: Catch::AutoReg::registerTestCase(Catch::ITestCase*, char const*, Catch::NameAndDesc const&, Catch::SourceLineInfo const&) (catch.hpp:5860)
==14080==    by 0x46CA44: Catch::AutoReg::AutoReg(void (*)(), Catch::SourceLineInfo const&, Catch::NameAndDesc const&) (catch.hpp:5845)
==14080==    by 0x46C3EF: __static_initialization_and_destruction_0(int, int) (obdHiLevelTest.cc:27)
==14080==  Address 0xffffffffffffffe8 is not stack'd, malloc'd or (recently) free'd
==14080==
==14080==
==14080== Process terminating with default action of signal 11 (SIGSEGV)
==14080==  Access not within mapped region at address 0xFFFFFFFFFFFFFFE8
==14080==    at 0x4ECB3A9: std::ostream::sentry::sentry(std::ostream&) (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.19)
==14080==    by 0x4ECBA68: std::basic_ostream<char, std::char_traits<char> >& std::__ostream_insert<char, std::char_traits<char> >(std::basic_ostream<char, std::char_traits<char> >&, char const*, long) (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.19)
==14080==    by 0x4ECBE57: std::basic_ostream<char, std::char_traits<char> >& std::operator<< <std::char_traits<char> >(std::basic_ostream<char, std::char_traits<char> >&, char) (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.19)
==14080==    by 0x46D725: Catch::(anonymous namespace)::PosixColourImpl::setColour(char const*) (catch.hpp:6375)
==14080==    by 0x46D51C: Catch::(anonymous namespace)::PosixColourImpl::use(Catch::Colour::Code) (catch.hpp:6353)
==14080==    by 0x46D8B8: Catch::Colour::use(Catch::Colour::Code) (catch.hpp:6409)
==14080==    by 0x46D7F9: Catch::Colour::Colour(Catch::Colour::Code) (catch.hpp:6401)
==14080==    by 0x485C61: Catch::TestRegistry::registerTest(Catch::TestCase const&) (catch.hpp:5755)
==14080==    by 0x46CE1E: Catch::(anonymous namespace)::RegistryHub::registerTest(Catch::TestCase const&) (catch.hpp:5994)
==14080==    by 0x46CB8D: Catch::AutoReg::registerTestCase(Catch::ITestCase*, char const*, Catch::NameAndDesc const&, Catch::SourceLineInfo const&) (catch.hpp:5860)
==14080==    by 0x46CA44: Catch::AutoReg::AutoReg(void (*)(), Catch::SourceLineInfo const&, Catch::NameAndDesc const&) (catch.hpp:5845)
==14080==    by 0x46C3EF: __static_initialization_and_destruction_0(int, int) (obdHiLevelTest.cc:27)
==14080==  If you believe this happened as a result of a stack
==14080==  overflow in your program's main thread (unlikely but
==14080==  possible), you can try to increase the size of the
==14080==  main thread stack using the --main-stacksize= flag.
==14080==  The main thread stack size used in this run was 8388608.

If I only change one of TEST_CASE name like so:
TEST_CASE ("A", "[obd parsing]")
{
}

TEST_CASE ("B", "[obd parsing]")
{
}

then everything is back to normal.
My config:

CATCH v1.1 build 14 (develop branch)
Generated: 2015-03-04 18:32:24.627737
gcc (Ubuntu 4.8.4-2ubuntu1~14.04) 4.8.4

Oh, and the relevant fact is that I have 2 files :+1:

first.cc : it has #define CATCH_CONFIG_MAIN
second.cc : no CATCH_CONFIG_MAIN

If I duplicate test_cases in first.cc, an error is raised (already defined). But if I do this in second.cc, the bug arises.
Regs

Eek! Thanks for reporting this.
My best guess (as I can't repro) is that GCC 4.8.4 doesn't guarantee that cout and cerr are initialised before other static objects (which AutoReg, near the bottom of that call stack is). Apparently it was intended to be guaranteed by the standard, but was non-normative in C++03. It should be guaranteed in C++11 - but none of that tells us what GCC does.
Could you try this. Add the following member variable:
std::ios_base::Init m_ostreamInit;
to the TestRegistry class. That should force initialisation of cout/cerr if not already. If that fixes it for you I'll add something like that into the code base.

Yay! Super cool. It works. Now I have standard message like :
error: TEST_CASE( "PID 10 MAF" ) already defined.
First seen at
/home/liwaszkiewicz/workspace/others/gpa-firmware/test/obdHiLevelTest.cc:103
Redefined at
/home/liwaszkiewicz/workspace/others/gpa-firmware/test/obdHiLevelTest.cc:127
Thanks!
On Thu, Jul 9, 2015 at 9:21 AM, Phil Nash<EMAIL_ADDRESS>wrote:

Eek! Thanks for reporting this.
My best guess (as I can't repro) is that GCC 4.8.4 doesn't guarantee that
cout and cerr are initialised before other static objects (which AutoReg,
near the bottom of that call stack is). Apparently it was intended to be
guaranteed by the standard, but was non-normative in C++03. It should
be guaranteed in C++11 - but none of that tells us what GCC does.
Could you try this. Add the following member variable:
std::ios_base::Init m_ostreamInit;
to the TestRegistry class. That should force initialisation of cout/cerr
if not already. If that fixes it for you I'll add something like that into
the code base.
—
Reply to this email directly or view it on GitHub
https://github.com/philsquared/Catch/issues/461#issuecomment-119854236.

This is now in (develop and master)


Test using bitwise operations on arbitrary width integers

I guess this is a bad test, although none of the expressions involve negative numbers: examples/checker_tests/good/constant_folding.p4

Why is this a bad test? It seems to me like the spec allows this?

"8.9.3. Illegal arithmetic expressions" says something like 32w5 & 3 is okay but 5 & 3 isn't okay.


React Field Slider example config update to fit latest SPFx version

Q
A

Bug fix?
yes

New feature?
no

New sample?
no

Related issues?
no

What's in this Pull Request?
package.json has been updated to fit latest SPFx version. Update is related to this issue

@AJIXuMuK,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

thx Alex, appreciated. Just to confirm also tomorrow - you have the demo spot in the monthly call for this and for the dialog usage in web part, like discussed in the past. Will push out monthly release notes earlier Tuesday.

Hi Vesa,
Thanks, yes, I'll be on the call. Just to correct - the second sample is side panel usage, not dialog.

Indeed - multi-tasking... :-)


some page content is not rendered when  tags are used inconsistently

What version of Hugo are you using (hugo version)?

$ hugo version
Hugo Static Site Generator v0.59.0-1DD0C69C linux/amd64 BuildDate: 2019-10-21T09:39:47Z

Does this issue reproduce with the latest release?
Yes
The issue
If the following conditions are true:

the page has extension .md
there are <p> tags without end tags (valid html according to the spec)
there is a <!--more--> tag anywhere after the unclosed <p> tags
there is a <p> tag with an end tag anywhere after the <!--more--> tag

The last <p> tag without an end tag and all subsequent content is ignored until the content after the <p> tag with an end </p> tag.
If the <!--more--> tag or end </p> tag are removed the page renders as expected with all content.
The following is possibly related I came across it whilst trying to debug the above situation.
If the following conditions are true:

the page has extension .html
there is a <!--more--> tag anywhere in the page

Content before the <!--more--> tag is not rendered, but all content afterwards is.
If .Content is expected to only contain the content after <!--more--> then the behaviour between .md and .html is inconsistent. I can't find anything in the documentation that indicates this behaviour is expected. I would have expected to find documentation about this behaviour at either https://gohugo.io/variables/page/#page-variables and https://gohugo.io/content-management/summaries/#manual-summary-splitting
The above was an issue with the site I'm working on (migrating historical content from several decades), but I've been able to reproduce both situations with a brand new hugo site and the blank theme (https://themes.gohugo.io/blank/). I've verified layouts/_default/single.html in the blank theme contains {{ .Content }} without any conditions or manipulation.

there are  tags without end tags (valid html according to the spec)

That's a stupid part of the spec and why I liked XHTML better than HTML. Always close your tags that can close, and you won't have problems.

Markdown parsers do a lot of assumptions with <p> when you give it content. Using a closing </p> will prevent it from being confused.


Reduce usage of time.After

Should fix #7697.
Although I think #7643 probably fixed the actual culprit already... from the benchmark I added, you'd have to be adding amazing number of timers to the system to actually cause any problems.

Although I think #7643 probably fixed the actual culprit already...
It seems that it did :)

LGTM - thanks!


Check if plugin path if is already added

https://github.com/xenanetworks/open-automation-core/blob/1c94fe1f89e968648a73fad400e4c5bef0d939c6/xoa_core/controller.py#L48
register_lib should check if it is already added the path to avoid loading module multiple times.

Apply fix for v1 and v2


[stable/airflow] Timezone

I'm using airflow on Azure AKS and there is no option to change the timezone globally rather than using airflow utils to set the DAG Timezone?

This is not related to the airflow chart.


"Salcia" is listed in the drop-down menu

The commune is  listed in the drop-down menu alongside its corresponding county, according to the law
Preconditions : the website (https://peviitor-ro.github.io/ui.orase/) is up and runing. After every step delete the text you typed from the search bar.

Step 1
Write in the search bar "Salcia"
Expected results
The location appears in the drop-down menu as "Comuna Salcia, PRAHOVA"


reversible reactions finished

Sorry I forgot to add the file. Just added.

But it still failed the tests...

I didn't change the test file.....But you should be able to see the result when you run crude_interface.
Or do you mean David has offered some file to check if the computation is correct?

I mean did you run pytest before making this pull request?

Actually no.... I didn't change the test file to adapt to the code after the change.....


[BUG][Mobile] Side swipe on home page and category page

Describe the bug
It is possible to side swipe on home page and category page
How to reproduce
Steps to reproduce the behavior:

Go to the home page
Swipe from righnt to the left
Go to any category page
Swipe from right to the left

Expected behavior
There should not be possibility to side swipe the page. All components should be visible without horizontal swiping.
Actual behavior
It is possible to side swipe the page. Not all components are visible without  horizontal swiping e.g. 'cart' icon in bottom menu
Screenshots

Devices (please complete the following information):
All mobile devices

@akrajna can you confirm that it's still exist? :)

@Michal-Dziedzinski the bug does not exist anymore :-)


setup.py: require update_checker >=0.11

update_checker-0.12 was released in July, which should also be supported

Thanks.


Comparison viewer colour gamma grid on match weight

Type of PR

[x] BUG
[ ] FEAT
[ ] MAINT
[ ] DOC

Is your Pull Request linked to an existing Issue or Pull Request?

Fixes #1437.
Give a brief description for the solution you have provided

The gamma-value grid in comparison viewer is now coloured according to the match weight associated with the corresponding gamma level, with the match weight also in the tooltip. The colour scale is similar to that of the comparison vector histogram, but a couple of small differences:

this is on match-weight scale, rather than probability, so colours do not 'line up' directly. I think that it is still fairly intuitive though, and don't believe that this should lead to any serious confusion
the midpoint is a grey, rather than yellow, as that seemed to make more sense as a 'neutral' in this context (i.e. not much evidence for/against) than yellow did

I like the proposed idea of alternate + more accessible colour schemes, but decided that was probably best to do as a wider change uniformly across our vis, so have left that to a separate issue (#1469) for a future PR.
Example:

PR Checklist

[ ] Added documentation for changes
[ ] Added feature to example notebooks at tutorial in splink_demos (if appropriate)
[ ] Added tests (if appropriate)
[x] Made changes based off the latest version of Splink
[ ] Run the linter

I like this. I wonder if the red-grey-green colour scale should be adopted more widely for match weight? I think it's the right option here, but would be good if other charts were consistent with it.

@RossKen have believe I have updated all the comparison viewer dashboards in the docs, but do let me know if there's any 've missed

@ADBond have tinkered slightly and this is now good to go 😊


Fixed JENKINS-27602

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests


How to interpret the stop_words result

I am not sure how to interpret the results from the bellow test case:
import numpy as np
import unittest
from unittest.mock import patch
from io import StringIO

from names_matcher.algorithm import NamesMatcher

class TestCreateIdentityMatcher(unittest.TestCase):

    def test_compare_two_lists_blacklisted(self):

        names_1 = [["vmarkovtsev"], ["Long, Waren", "warenlg"]]
        names_2 = [["Warren"], ["VMarkovtsev"], ["Eiso Kant"]]

        assignments = NamesMatcher(["vmarkovtsev"])(names_1,
                                     names_2)

        self.assertEqual(-1, assignments[0][0])
        self.assertEqual(1, assignments[1][0])

The comments sau "Ignore parsed name parts that start with any string from this list"
Why is the index is -1 and the confidence 1?
Thanks,
Dimitar

This comment should resolve the issue: https://github.com/athenianco/names-matcher/blob/master/names_matcher/algorithm.py#L147


you have a way to send via c #

you have a way to send via c #?

This is a possible solution which I have used in the past https://github.com/Redth/PushSharp


Issues with enum pages in API reference

Looking at the API reference page for the BindingFlags enum, I have noticed two issues:

The list of fields is at the very bottom of the page, after examples and remarks. This might make sense for classes, but I think it's not appropriate for enums, where the list of fields and their meaning is usually the first thing I'm looking for. I think that for enums, the list of fields should be at the top of the page, right after the definition section.
Each field has its own page, which is linked from the TOC, but not from the body of the article itself. This page seems to duplicate the information in the fields section of the type. I don't think those pages should exist.

I agree with you @svick. I've opened an internal issue to track this.

/cc @dend @DuncanmaMSFT


fix: Backwards-compatibility changes for ESv6.x in the (new) es_search_proxy

Signed-off-by: Ozan Dogrultan<EMAIL_ADDRESS>
Summary of Changes
These changes make the (new) es_search_proxy backwards-compatible with ES v6.x or earlier and gracefully handles the api response
Tests
N/A
Documentation
N/A
CheckList
Make sure you have checked all steps below to ensure a timely review.

[x] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[x] PR includes a summary of changes.
[x] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[x] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain docstrings that explain what it does

this change is not enough to make Amundsen compatible with ES6 and I am not sure if we should aim for that


Add configuration to skip the creation of .resx files without entries

Hi!
We would like the possibility to skip the creation of empty resx files when importing from excel.
Our concrete use case is, that we are using country variant cultures and only a few of our resources actually need a country variant localization. Therefore, during the import there are a lot of empty .resx files added, which are going to stay empty and only clutter the solution or need to be removed manually.
Our use case could be fixed by an additional configuration entry in the "File Creation" category, with something like: "Do not create empty resource files.".
As we need this feature, we are going to implement this in a fork anways and provide the change in a pull request during the coming week. Are there any concerns/ideas you want to add?

I think during excel import this should be the default behavior, I wonder if we really need this to be configurable?

I think this is a bug and does not need any configuration - it should just verify accessibility of cultures that are not empty. See http://resxresourcemanager.codeplex.com/SourceControl/changeset/37674; will be synchronized with github soon.

Thanks for the quick response and the quick fix!
Do you have an estimate when this fix will be released?

probably next weekend.


Make DNS names case-insensitive

This PR is the fix for the https://github.com/istio/istio/issues/5527

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: greghanson
Assign the PR to them by writing /assign @greghanson in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @Nino-K. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@Nino-K would have been nice to find a spot where we can use an uppercase name to make sure that this doesn't regress.

@Nino-K: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
0e7c507ece0a56f6a5481182be83e29dab6b09df
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
0e7c507ece0a56f6a5481182be83e29dab6b09df
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
0e7c507ece0a56f6a5481182be83e29dab6b09df
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
0e7c507ece0a56f6a5481182be83e29dab6b09df
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
0e7c507ece0a56f6a5481182be83e29dab6b09df
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
0e7c507ece0a56f6a5481182be83e29dab6b09df
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
0e7c507ece0a56f6a5481182be83e29dab6b09df
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
0e7c507ece0a56f6a5481182be83e29dab6b09df
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
02f74461ccc4e381806fde12ce131e2e75f04b6b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
0e7c507ece0a56f6a5481182be83e29dab6b09df
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
02f74461ccc4e381806fde12ce131e2e75f04b6b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
02f74461ccc4e381806fde12ce131e2e75f04b6b
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
02f74461ccc4e381806fde12ce131e2e75f04b6b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
02f74461ccc4e381806fde12ce131e2e75f04b6b
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
02f74461ccc4e381806fde12ce131e2e75f04b6b
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
02f74461ccc4e381806fde12ce131e2e75f04b6b
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
02f74461ccc4e381806fde12ce131e2e75f04b6b
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
02f74461ccc4e381806fde12ce131e2e75f04b6b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
02f74461ccc4e381806fde12ce131e2e75f04b6b
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
02f74461ccc4e381806fde12ce131e2e75f04b6b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
02f74461ccc4e381806fde12ce131e2e75f04b6b
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
02f74461ccc4e381806fde12ce131e2e75f04b6b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
02f74461ccc4e381806fde12ce131e2e75f04b6b
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
02f74461ccc4e381806fde12ce131e2e75f04b6b
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Make Armeria Retrofit subscriber not buffer response

Current implementation will buffer all data and call callback when complete.
So it's not suitable for downloading large files.
This PR will make subscriber requests data one by one from response.　And
because SourceBuffer#read and Subscriber#onNext are using same thread, we need to
using CommonPools to run SourceBuffer#read for avoiding deadlock.

@kojilin Hmm? What's going on?

Too many edge case, let me add more test and complete the original code


[1.12.2] Block Spawn spawns the player inside of the block

Describe the bug
The player is always spawned inside the block instead of on top of it, meaning that they get pushed away or sit inside of it
To Reproduce
Steps to reproduce the behavior:
Use block spawn in the cfg
Expected behavior
Spawn on top of the block
Environment
Game Version: 1.12.2
Modpack: Trepidation

fixed in 1.5.5 (my first PR to a mod yayy!)


Report issue fails with HTTP 401

Behaviour
After running the "Python: Report Issue..." command and filling everything out, the "Create on GitHub" button appears to do nothing.
The extension is making a request using Authorization: Bearer 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 and gets a HTTP 401 "Bad credentials" response from the GitHub API.
Steps to reproduce:

Follow https://github.com/microsoft/vscode-python/wiki/Reporting-a-bug#the-extension-loads or https://github.com/microsoft/vscode-python/wiki/Reporting-a-bug#the-extension-wont-even-start
Press "Create on GitHub"
Toggle Developer Tools and check the console logs and network requests

Diagnostic data
No relevant output for Python in the Output panel


Add support for the Actinius Icarus board (nRF9160)

With this PR we are adding support for the Icarus board (www.actinius.com/icarus) which is based on the nRF9160.

Could you please rebase the PR on latest master, @alextsam ?

@ioannisg done, thank you.
@galak we're still using the old the old GPIO API, but I see that there is work already done in branch. Should I do something about that?


Issue when running with Node V18.12.1

Hello,
I am currently running the 1.1.0 version of this project from the root. When using Node V16, it runs fine. But when attempting to run with V18, the Flex UI spins up but does not load any of the features.
It specifically spits out this error:
[HPM] Error occurred while trying to proxy request /plugins/plugin-flex-ts-template-v2.js from localhost:3000 to http://localhost:3000 (ECONNREFUSED) (https://nodejs.org/api/errors.html#errors_common_system_errors)

When running:
npm run start

I am prepping to do the upgrade of all of the functions to Node V18 and want to test out their functionality locally before attempting to deploy. If you all also have any insight in to how to set the version for the functions to 18, it would be appreciate. The option is locked inside of the Twilio Function UI for this service.

Hi @blakecodes! Please make sure that when upgrading to Node 18 that you are using the latest Twilio CLI as well as the latest Flex CLI and Serverless CLI plugins. These all had several issues on Node 18 that have been somewhat recently fixed.


feat: advanced search

Allow searching personal manpage contents with ripgrep
Use $PMAN_SEARCH

Just implemented as a pass-through to ripgrep for now


Creating a LeaderboardQuery instance gives a compilation error

@adityatMS,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Updating resets setting preferences

The last 2 times I have updated, my setting preferences for the plugin have automatically reset. I wasn't experiencing this issue until recently (within the last month).

Yes, that was intentional. But should only happen once. It checks for a particular key in your localStorage, if it isn't set it will reset the theme's settings and then set it to avoid settings being reset again.
This should've happened once when updating from 0.8.0 to 1.0.0

Okay, makes sense I guess. I apologize if it was intentional. I just updated to 1.0.5 and it reset again. How do I set that key to keep it from resetting?

open a DevTools console and type: localStorage.setItem('atom-material-ui:configOk', true);
BTW, 1.0.x was unpublished and 0.8.0 is the latest version once more. If you wish to downgrade just reinstall the theme:
apm uninstall atom-material-ui
apm install atom-material-ui

However, if you wish to continue using 1.0.x, clone this repository and link it with APM.
apm uninstall atom-material-ui
git clone git@github.com:silvestreh/atom-material-ui.git
cd atom-material-ui
apm link
apm install

Thanks!

I typed it in the console and it returned ³undefined². Does that sound
right?
--
Ryan Altvater
Designer & Developer
www.ryanaltvater.com http://www.ryanaltvater.com
From:  Silvestre Herrera<EMAIL_ADDRESS>Reply-To:  silvestreh/atom-material-ui
<reply+001465d36a69689526b94deec894a3403be1cb09e614ac0d92cf000000011279d1949
<EMAIL_ADDRESS>Date:  Friday, December 4, 2015 at 5:11 PM
To:  silvestreh/atom-material-ui<EMAIL_ADDRESS>Cc:  Ryan Altvater<EMAIL_ADDRESS>Subject:  Re: [atom-material-ui] Updating resets setting preferences (#146)
localStorage.setItem('atom-material-ui:configOk', true);

@ryanaltvater yes, that is fine :smile: Do your settings still get reset?

I haven't tested it, but did notice that my copy of the plugin went back to the older version which I like. If I notice any issues in the future, I will re-comment and report back here. Thanks a lot! :+1:

Awesome. :)


Request::loadCookies not loading cookies

Hi,
I'm having a strange issue on a test server that "just broke" some time ago, everything's fine on other environments, so it should be a configuration/server issue.
Basically, the problem is that CSRF validation does not work, because Yii2 does not seem to be able to retrieve the _csrf cookie. No errors, warnings or anything, just the cookies are not loaded.
I've traced it to yii\web\Request::loadCookies. The cookies are present in $_COOKIE:
array(2) {
  ["PHPSESSID"]=>
  string(26) "mgpl2kfhu20i7lhqr9gkmkpqb5"
  ["_csrf"]=>
  string(104) "bcaf5fc8563a9bb83294d5db31e7103b32082d51b48727a95301d1f9c1986caes:32:"pDHU7yR7dMArTtn8g99-nAZqq9ychtQH";"
}

but at the end of the method, $cookies array is empty.  It seems that the Yii::$app->getSecurity()->validateData($value, $this->cookieValidationKey) check returns false and so the cookies don't get set. I have cookieValidationKey set and haven't customized anything related to cookies. Also, validateData returns false with the same input on other servers, so I'm guessing the data already in $_COOKIE is corrupt somehow.
How should I begin to debug something like this or are there any "probable causes" for this kind of behavior?
Test code:
$value = Yii::$app->getSecurity()->validateData('bcaf5fc8563a9bb83294d5db31e7103b32082d51b48727a95301d1f9c1986caes:32:"pDHU7yR7dMArTtn8g99-nAZqq9ychtQH";', 'jQWhJIOXCiBp_R7M1GW2w_gzDt6myphG');
var_dump($value); // returns false

Thanks!

I have the same problem. I´m using advanced template. And loadCsrfToken returns an empty value, so each time the page is reloaded the _csrf is new. But if i define a custom csrfParam it works well. Also keeps creating a cookie with name _csrf, so i have both, and no one of them changes after reload.

This sounds like a conflict with backend and fronted part of the advanced app, which has been solved by introducing different cookie names in the default config: https://github.com/yiisoft/yii2-app-advanced/commit/ec1148c4f62e12098a3eb650f8e66fe6c23a6323 https://github.com/yiisoft/yii2-app-advanced/commit/bb35a7543aa5b718b01d6cd576d78da9e4193249
closing this issue unless there is a way to reproduce it. Please provide further info or even a failing unit test if you know how to reproduce it.


uncomment all the configurable lines

So that setting a setting in the default attributes it will be picked up and used.

@parabuzzle should I keep this issue open?

any updates from this pull request?


site-ph0 and site-ph1 generation

Hi,
Could you add automatic generation on site-ph0.yaml and site-ph1.yaml alongside the site.yaml?
These will be generated with the respective lines in kustomization.yaml:
site-ph0.yaml:
transformers:

sas-bases/overlays/scaling/zero-scale/phase-0-transformer.yaml

site-ph1.yaml:
transformers:

sas-bases/overlays/scaling/zero-scale/phase-0-transformer.yaml
sas-bases/overlays/scaling/zero-scale/phase-1-transformer.yaml

This will be very useful for scaling the environment up and down without needing to regenerate them manually each time you update SAS.

@Vladislaff can you provide information on the site-ph files? There is no mention of these in the documentation for the deployment of SAS Viya 4. Thanks.

I guess the request can be to build a start_all.sh and stop_all.sh to gracefully start and stop all services in viya4
certainly a must have.

In 2021.1.1 cronjobs sas-start-all and sas-stop-all were added. No need for this anymore.


blink1-tool: 2.2.0 -> 2.3.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/blink1/versions.
meta.description for blink1-tool is: "Command line client for the blink(1) notification light"
meta.homepage for blink1-tool is: "https://blink1.thingm.com/"
meta.changelog for blink1-tool is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.3.0 with grep in /nix/store/xw3kqgpl72q98pxv2d8qcxrpil4zn2xd-blink1-2.3.0
found 2.3.0 in filename of file in /nix/store/xw3kqgpl72q98pxv2d8qcxrpil4zn2xd-blink1-2.3.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
blink1-tool

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/xw3kqgpl72q98pxv2d8qcxrpil4zn2xd-blink1-2.3.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A blink1-tool https://github.com/r-ryantm/nixpkgs/archive/e064ef50e49ddb96bdaa89aed917a4a722a614f5.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/xw3kqgpl72q98pxv2d8qcxrpil4zn2xd-blink1-2.3.0
ls -la /nix/store/xw3kqgpl72q98pxv2d8qcxrpil4zn2xd-blink1-2.3.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

blink1-tool

Maintainer pings
cc @cransom for testing.

It builds and works properly under linux. I have failures under darwin that would be nice to fix (it doesn't build under the old version either). If not, I'll restrict the build to linux only.

I fixed build failures (or rather, non-existence) under macos and incorporated the version bump into those fixes over in https://github.com/NixOS/nixpkgs/pull/184895 . I think this can be closed in favor of the other PR.

Thank you @cransom!


linux/common-config: more tweaks, some repeated tweaks

Description of changes
Follow-up #298103 and #296867.
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I think this also closes #155533.

It does.

@K900 Did this introduce NixOS's first support for SimpleDRM? Because that is the current suspect of https://github.com/NixOS/nixpkgs/issues/266804, but it couldn't be if it didn't exist months ago.

Yes


Improve messages in shader function validation

Closes #18225

Ah, forgot to do the same for the built-in functions

Meh, I think parsing built-ins for better messaging are too difficult for the parser (cuz they have overloads with different amounts of arguments).

@akien-mga should caller function contains parameter list like: "Invalid arguments for "test(int a, int b)" ... or left it like "Invalid arguments for "test()" ?

This cannot be cherry-picked in the current form cuz TYPE_STRUCT is not been implemented in 3.2

Thanks!


Update backup instructions

I did some manual backup and restore testing (mostly with Velero on GKE) and added a few more notes to the backup doc.
The fact that the Certificates for Ingress lose the correct owner reference during a restore and cert-manager cannot recreate it, seems problematic from backup and restore perspective, as there is no straightforward way to exclude the Ingress Certificates only from a Velero backup.
I added a recommendation to not restore CertificateRequests.
I don't think that restoring them would necessarily cause failures as such, but with the new identity fields it seems like we should not restore them since the restorer's identity is likely going to be different than creator's and it might just cause confusion.
Also cert-manager cannot recreate their status after a restore correctly, so they end up having Ready condition set to False, which I think would also be confusing for users.
In all cases I could think of there should be no need to restore completed CertificateRequests, but perhaps there are some edge cases where they are needed?
Some issues related to cert-manager backup and restore:

#2318
#2112
#234
#397
#3612

Some of the issues above refer to the currently documented backup strategy via kubectl get.. kubectl apply- I have not looked into that much as a part of this PR.
I have not yet properly tested restoring from an etcd snapshot which I was planning- that might be a separate PR.
Fixes #479
/kind cleanup

Thanks for the review @wallrj - I've added updated the PR. Thanks for looking at the sentences, I did feel like they were rambling a bit, so was hoping someone could suggest some improvements.


Push notifications handling guide

We need to provide some resources for devs around push notification handling. We also need to expose methods for actually taking in the push notifications when they are received by the notification extension.
Topics
Welcome topics have the format:
`/xmtp/mls/1/w-${hexEncode(installationId)}/proto`

Group message topics have the format:
`/xmtp/mls/1/g-${hexEncode(groupId)}/proto`

Clients should listen to these topics and then decode the payloads.
Payload types

Welcome messages are protobuf messages encoded with mlsv1.WelcomeMessage
Group messages are protobuf messages encoded with mlsv1.GroupMessage

What to do with messages

Once payloads have been decoded from the push notification callers can pass them to process_streamed_welcome_message and process_streamed_group_message in our SDKs (these functions are not exposed outside of Rust).

### Tasks
- [x] Expose FFI interface for processing welcome and group messages to libxmtp
- [x] Add ability for callers to pass in Welcome messages to iOS SDK for processing
- [x] Add ability for callers to pass in Group messages to iOS SDK for processing
- [x] Add ability for callers to pass in Welcome messages to Android SDK for processing
- [x] Add ability for callers to pass in Group messages to Android SDK for processing
- [x] Add ability in RN

Would be nice to have a example running in RN for this but going to push this down in priority in favor of the HMAC work for now. PR started here: https://github.com/xmtp/xmtp-react-native/pull/347


Define support ticket urgency levels and practices for how to deal with them

Context
An important part of the support process is understanding how "urgent" the ticket is. For example - some tickets are general requests that we can finish in a few weeks, others are immediate fires that we need to fix ASAP. Having a system to categorize these tickets will help us make better decisions about our operational time, and reduce stress levels associated with not knowing whether we need to drop everything to fix something.
Proposal
We should define:

a few levels of "urgency" for our support tickets
criteria for how to categorize tickets into these levels
processes that we follow to resolve different kinds of levels

As a result of this, we may need to do further development work to improve our support practices, such as setting up a PagerDuty-like system, but we'll understand that better once we write out the high-level structure.
Implementation guide
See the parent issue for a lot of references to support processes with urgency levels:

https://github.com/2i2c-org/infrastructure/issues/1068

I think an important first step is to define an incident, in an objective way that's independent of how Urgent the user thinks something is a problem. An incident is when one of the following is true:

Users can't log-in to the hub
Users can't start a server
(For dask-gateway) Users can't start dask workers

I think when any of these are true, we should 'declare an incident'. https://sre.google/workbook/incident-response/ has some good ideas on what to do when that happens, inspired by actual fire incidents in the literal wild.

Taking a page out of https://sre.google/workbook/incident-response/#putting-best-practices-into-practice, so here's a very specific but first-draft process recommendation for an incident management workflow.
When a ticket comes in, we perform the following test:

Is it a report about users not being able to log in?
Is it a report about users not being able to start their server?
(For dask-gateway) is it a report about dask-servers not working?

If any of these criteria are met, the support steward declares an incident, by doing the following:

Opening an issue in this repo, using https://github.com/2i2c-org/infrastructure/issues/new?assignees=&labels=type%3A+Hub+Incident%2Csupport&template=3_incident-report.md&title=[Incident]+{{+TITLE+}} (we will refine this too)

Assign an Incident commander for this particular incident. I like the definition in https://response.pagerduty.com/before/different_roles/, which says they:
a. Commands and coordinates the incident response, delegating roles as needed. By default, the IC assumes all roles that have not been delegated yet.
b. Communicates effectively.
c. Stays in control of the incident response.
d. Works with other responders to resolve the incident.
The expectation should be that this is  different person than the support steward, to reduce the load on the support steward and recognize they are not responsible for resolving all outages. We should define a process for figuring out who gets to be incident commander separate from this, but this comment just needs to acknowlege that this is a separate role from what the support steward is doing.

Respond to the support ticket by acknowledging the incident, tagging in the incident commander.

The incident commander is responsible for investigating the issue, pulling in people if necessary, and keeping the customer informed via the support ticket. They can also tag out when it is no longer working hours for them - we should engineer process that makes this viable.
How does this sound as a start? I can make this into a PR and we can iterate.

https://response.pagerduty.com/before/different_roles/ is also a good read.

Couple more vague thoughts:

It should deeply respect working hours rules, so we don't expect people to be 'up all night' (or outside their working hours, whatever it is). Tagging someone else in to this role is to be expected, so the process should be built around this being a role than a person.
Incidents should be rare - we should have an appropriate post-mortem process to try fix these up. If we are spending too much time on this, we could use error budget techniques (https://sre.google/sre-book/embracing-risk/) to deal with reducing that time.

The expectation should be that this is different person than the support steward, to reduce the load on the support steward and recognize they are not responsible for resolving all outages. We should define a process for figuring out who gets to be incident commander separate from this, but this comment just needs to acknowlege that this is a separate role from what the support steward is doing.

So, we are thinking about having 2 people in support AND one incident commander from the rest of the team?
Or one (1) of the support folks (2) assume the incident commander role?

I think this is closed by https://github.com/2i2c-org/team-compass/pull/422

I think there are some additional pieces on this merged PR: https://github.com/2i2c-org/docs/pull/143/
@choldgraf, do you want to keep this open for something else?

Let's say that https://github.com/2i2c-org/team-compass/pull/422 closes this one, and we can continue iterating in new / more focused issues from there?


Add TLS passthrough and SANs info to TLS doc

Add TLS passthrough and SANs info to the TLS documentation to address common user questions.

@andrew-coleman @tock-ibm Still seeing back-to-back failures in gateway_bft_test.go if you can check it out...


compliance lease allowed for creation of lease with expiration in the past

{
    "count": 1,
    "next": null,
    "previous": null,
    "results": [{
        "uuid": "f2ef7299-e8d3-4548-a0a6-66a3cd9ed4a0",
        "resource_type": "server",
        "owner": 2,
        "name": "nova 2",
        "description": "past dated test",
        "resource_id": "7253a3bb-bc24-4dc6-83b9-860cad786071",
        "expiration": "2016-03-06T23:00:00Z",  // march 6th
        "status": "active",
        "created": "2016-03-09T23:04:52.379815Z",
        "updated": "2016-03-09T23:04:52.379828Z"
    }]
}

opened against wrong project.  there is a ticket that covers this on the compliance project already.


Semaphore support

Hi,  I was trying out your library but as mentioned it does not support semaphores.
Do you think this would be hard to do ? Otherwise I might consider adding it.. Did not have a look at the source code though.

Hi spetsnaz84,
I think it would be relatively easy to treat semaphores similar to how I treat mutexes currently.  The main difference is that semaphores can be released from threads other than the thread that acquired them, without causing undefined behavior.  Otherwise, they are just the same as recursive mutexes.
best,
Colin


[FEATURE] Get caller instance object of event Raisers

Is your feature request related to a problem? Please describe.
When debugging only the stacktrace is available - from which you can get no info on which instance of the type raised an event.
Describe the solution you'd like
I assume (from limited research) it's impossible to get the instance of the caller, but I would really like to be able to click a button in the event stacktrace debugger to highlight the instance object that made the raise. Like when you click the log message in the console to get pointed to the context.
Describe alternatives you've considered
Making my own AtomAction that I forcefully put on every gameobject that Raises any event, just to log a console message with the context to the GameObject.

We can't do it via reflection (there is no way to find the calling object).
So only way would be to change the API for the AtomEvent.cs  Raise method to accept a sender as an argument.
this needs to be passed through to the StackTraceEntry  into a new member field "_sender".
In the StackTraceEditor as additional callback action the object can be pinged.

Since it most likely will be a breaking change, this would need to wait for the next major release though. Alternatively we could overload the Raise method.

Wouldn't this break the ability to raise events on unity events in the inspector? (Can't render more than one method parameter)?

An alternative would be to use the new Dependency viewer to find all used references of an Atom as a starting point for debugging issues;

However, the package is still experimental and just renaming an Atom breaks the dependency tree, forcing a rebuild, which then doesn't always captures all references within scenes. And even if this worked, I still wouldn't know on a per call basis which object instance Raised the event.

Alrighty, this seems to be the solution I'm going for for now;
public UnityEvent RaiseAtomEvent;

public void RaiseAtom()
{
    if (RaiseAtomEvent.GetPersistentEventCount() == 0)
    {
        Debug.LogError("No Atom assigned to be raised", this);
        return;
    }

    var targetObject = RaiseAtomEvent.GetPersistentTarget(0);

    if (targetObject is not AtomEventBase atomObject)
    {
        Debug.LogError("Only AtomEvents are allowed to be raised by RaiseAtomEvent!", this);
        return;
    }

    string atomType = atomObject.GetType().ToString().Split(".").Last();

    Debug.Log("[ATOM] Raising " + atomType + " : " + atomObject.name + " on " + gameObject, gameObject);

    if (Application.isPlaying)
        RaiseAtomEvent.Invoke();
}

Along with;
public static void RaiseWithDebug<T>(this AtomEvent<T> atomObject, T value, Object context)
{
    string atomType = atomObject.GetType().ToString().Split(".").Last();

    Debug.Log("[ATOM] Raising " + atomType + " : " + atomObject.name + " on " + context.name, context);

    if (Application.isPlaying)
        atomObject.Raise(value);
}

And then just forcing the practice of never calling Raise() directly on an Atom.
Sucks, but works.

Wouldn't this break the ability to raise AtomEvents (with parameters) from unity events in the inspector?

just pass null, or the atom itself.

Wouldn't this break the ability to raise AtomEvents (with parameters) from unity events in the inspector?

just pass null, or the atom itself.

Yes that's my point. You can't raise an atom with a value AND pass the caller using UnityEvents in the inspector. Which is one lf the main selling points of the whole architecture.

Which is one lf the main selling points of the whole architecture.

I would fight that statement any day!

You can't raise an atom with a value AND pass the caller using UnityEvents in the inspector

Why wouldn't that work? It's a custom Inspector like any other. so if the Raise method is modified to receive a second parameter the inspector will be modified obviously too.
E.g. here:
https://github.com/unity-atoms/unity-atoms/blob/master/Packages/Core/Editor/Editors/Events/AtomEventEditor.cs#L28
just adding either null or atomEvent as a second parameter.

Please note that everything I wrote is meant as notes for a future Pull Request, not as a solution you could just implement in on the consumer end of the library. (I thought that was clear, since the issue has the label enhancement)

Why wouldn't that work? It's a custom Inspector like any other. so if the Raise method is modified to receive a second parameter the inspector will be modified obviously too.

Unity Events arent custom Inspectors.
Take a button as an example. Add a listener to that in the inspector with a reference to your atomEvent and call Raise() om that.
UnityEvents c

Sry for close - fat phone thumbs...
opens git issue requesting a feature to revert "close with comment" entries

You can use Unity Events.

See https://docs.unity3d.com/ScriptReference/Events.UnityEvent_2.html
the arguments must be passed from code, though.

If you insinst on the inspector functionality, you can use something like https://openupm.com/packages/com.solidalloy.extevents/

A part of unity atoms - and the scriptable object architecture as outlined by Ryan Hipple - is to NOT rely on UnityEvent, that's the whole point of AtomEvents. ( For reference this part of the talk: https://youtu.be/raQ3iHhE_Kk?t=1764 )
So why not just create a
[System.Serializable]
public struct StringEventWithArgs{
    public StringEventReference unityAtomsEvent;
    public string argument;
}

then you can modify the argument in the inspector as you wanted and you don't need to go through the UnityEvent to invoke a UnityAtomsEvent.

Wow we are going in circles.
He in the video you linked litterally goes on to call the gameevent scriptable object from a unityevent like I've explained all along;

@35:50
And you litterally just linked an alternative to my previous post (a replacement package to UnityEvent

What about something like this

public class UnityEventDebug<T>: UnityEvent<T> {

    #if UNITY_EDITOR

    Object _parent = null;

    public void SetParent(Object parent) {
        _parent = parent;
    }

    new void Invoke(T value) {

        for (int i = 0; i < GetPersistentEventCount(); i++) {
            string name = GetPersistentMethodName(i);
            Object target = GetPersistentTarget(i);
            if (typeof(UnityAtoms.IRaisable<T>).IsAssignableFrom(target.GetType())) {
                // call but with parent;
            } else {
                // call normally
            }
        }
    }
    #else
    public SetParent(Object parent) {}
    #endif
}

What about something like this
public class UnityEventDebug<T>: UnityEvent<T> {

    #if UNITY_EDITOR

    Object _parent = null;

    public void SetParent(Object parent) {
        _parent = parent;
    }

    new void Invoke(T value) {

        for (int i = 0; i < GetPersistentEventCount(); i++) {
            string name = GetPersistentMethodName(i);
            Object target = GetPersistentTarget(i);
            if (typeof(UnityAtoms.IRaisable<T>).IsAssignableFrom(target.GetType()) && name == "RaiseFnName") {
                // call but with parent;
            } else {
                // call normally
            }
        }
    }
    #else
    public SetParent(Object parent) {}
    #endif
}

Appreciate the thought, but again, this wouldn't work with Unity's built-in components, unless I'm unaware of a way to inject this new type into components like the default button.
Maybe some way similar to how https://github.com/handzlikchris/Unity.TransformChangesDebugger.API works, but I have no idea how that works.

You could try assembly patching, but it's a pile of worm I think few people would get into.

Yea, seems like Harmony is the way he did it. Guess I would have to patch every unityevent.


Add moc operation log

As part of telemetry enhancement https://msazure.visualstudio.com/msk8s/_workitems/edit/23541342
Adding logs to record create/update/delete requests from caph to moc.

Thanks!!! I appreciate you starting on this.
Do you have an example of what the telemetry data would look like?
And a sample query?

Thanks!!! I appreciate you starting on this. Do you have an example of what the telemetry data would look like? And a sample query?

We haven't upload to kusto yet, chendi will work on that later.


Safer uniq ptr

Demo of using https://github.com/duckdb/duckdb/pull/6950
(IF that happens to be merged, last commit can be dropped and this can be finalized)

I completely understand what this PR is doing now, and it's great 👍
To summarize:
safe_unique_ptr will deprecate (remove) duckdb::make_unique, by removing the use of duckdb::make_unique we can make incremental changes that make sure there is a small amount of steps we can take to go from one working state to the next

Thanks @Tishj!
I put here a basic diagram / explanation : https://github.com/duckdb/duckdb/pull/6950#issuecomment-1493948484 for whoever passes next over this.
Will update to actual PR when ready.


has error info in devtools when contentScript import '.index.css'

and i not found 「Devtools Pane」in chrome devtools

Would you like to update the source code to the main branch and try again?

Would you like to update the source code to the main branch and try again?

thanks, and how to use react in this contentScript.js? I could build vendor.js by using webpack, and config this to manifest.json's "content_page" filed. So how to do this by vite？

if i use import React from 'react' in contentScript.js directly，that has error info in devtools

fine, i solved this problem

@all-contributors please add @JunyWuuuu91 for code

@all-contributors please add @JunyWuuuu91 for code