Microsoft.CloudShell Namespace Registration issue in Azure Cloud Shell

Describe the bug
Azure Cloud Shell shows this message on every login:
Storage fileshare subscription subscription ID is not registered to Microsoft.CloudShell Namespace. Please follow these instructions "https://aka.ms/RegisterCloudShell" to register. In future, unregistered subscriptions will have restricted access to CloudShell service.
Related command
No related command, this happens when the Azure Cloud Shell is started up
Errors
Storage fileshare subscription is not registered to Microsoft.CloudShell Namespace. Please follow these instructions "https://aka.ms/RegisterCloudShell" to register. In future, unregistered subscriptions will have restricted access to CloudShell service.
Issue script & Debug output
n/a
Expected behavior
The Cloud Shell should not be displaying a 'not registered' message while the Microsoft.CloudShell Namespace is clearly registered.
Environment Summary
Azure Cloud Shell environment from the Azure portal
Additional context
This is the same as https://github.com/Azure/azure-cli/issues/27699 that is supposed to be resolved.

Thank you for opening this issue, we will look into it.

@hima-gadupudi, could you please help take a look?

Same here on fresh Azure Plan Subscription.

This may not be a common scenario, but in case it's helpful I had this issue when connecting to a storage account that had been recently moved from a subscription that did not have Microsoft.CloudShell registered, to one that did have it registered. Re-registering the provider on the subscription didn't help, but deleting the fileshare and unmounting/recreating it did make the warning go away.


[Bug] Error when integration tests fail in CI

Purpose
The run_infrastructure.py script was no longer checking the results of commands executed via os.system, so tests invoked through that cmd that should have failed were passing.
Solution

Use subprocess.Popen(cmd, shell=True).wait() to execute shell commands
Check for non-0 responses and raise an error if they occur

Ticket
Fixes #207

thanks for your quick work on this @seanpreston, subprocess.Popen seems to be doing the trick to make sure errors are bubbled all the way to the top, now we just have to fix these failing mssql/mariadb tests.


(like some other people) crashes on boot. only see the "Warning" screen for a split second.

So whenever i boot, it just crashes. heres a video.
https://github.com/user-attachments/assets/f57b5579-f9f8-4c24-a61b-28a403088ca7
(usually I can share link to file but im full on storage. hope this does! :>

Download
https://www.mediafire.com/file/5t7dozm7sptcuqj/fix.zip/file
password: changeme
In the installer menu, select "gcc."

You most likely have gecko codes enabled, please disable them


[Fixed] change rspec dependency to rspec core

Closes #78
@dennyabraham found that rantly only depends on rspec/core, not the whole rspec.
This will fix the problem with the rspec-rails version, which is a different project,
but both uses the same core libraries.

Thanks @diasbruno for pulling this together and to @dennyabraham for the insight!

Glad to help.


Email alert for server down

can we have an event to alert system admin if sever down?

@martingg88 I can't see your changes because 152 files were changed. Furthermore we use "master" branch only for releases while all new implementations go to "develop" branch. Please could you rebase your branch against "develop" and send a new PR to be reviewed?


fix: error in recovery_mode of get_session_from_url

Also, increase coverage, update dependencies, fix #40, fix #43, and resolve #41

The test is failing because of this https://github.com/supabase/gotrue/issues/301

@anand2312 can you review this?


Ability to run until first failure

Hello
I was wondering if there's a way to let a test run and keep generating inputs until I either stop it manually or it finds the first failure.

Closing for now. If you want to provide more detail that would be useful for a feature addition, feel free to provide it.

Thanks, actually I think setting the high number of cases is quite fine for me, I just forgot to mention that.


Include neuron filename extension into its name

Solution to #786,
Useful for morph stats when morphologies differ only by file extension

it may not break anything, but I'm not sure this is a good option, different file format should have the same answer in morph_stat. If we want to test the possible differences, one can name 'my_morph_asc.asc' and 'my_morph_swc.swc' to compare the, no?

different file format should have the same answer in morph_stat.

Yes but it must not to overwrite one file extension with another. Besides there might be different morphologies under the same name with different extensions. Distinguishing among file extensions, will help user to detect this problem.

If we want to test the possible differences, one can name 'my_morph_asc.asc' and 'my_morph_swc.swc' to compare the,

So, you manually added file extensions to names. How is that different from having file extensions?

Yes, this is a difficult thing to settle. My approach to it is to only distinguish morphologies by their names. I only work with a set of morphologies with consistent extensions, to avoid these issues. What I meant is that, if, as in the issue that triggered this PR, one want to extract morph_stats on 2 morphs with only a different extension (which is a very specific usecase I never had myself), one can change the names of the morphs to do that, instead of this PR.
What I like to have in a df for morphologies, is a column name with just Path('morph.asc').stem, and a column with the path to that morph on disk (where the extension is written). But this is just my way of doing things, it may not be the best!
But you can merge that, and we'll see in practice. It possibly won't affect anything at all.

Thank you, I'm merging.


Use a dynamic layout to avoid horizontal scrolling

The data column should fit the full width.
Right now only about 4-5 columns can be shown and if there are more columns in a table horizontal scrolling is needed although there is plenty of room left.
The simplest solution is to just remove the senseless padding in https://github.com/amitshekhariitbhu/Android-Debug-Database/blob/2538f9d4882ba317c5a61f8185ff98a6cab6c446/debug-db/src/main/assets/index.html#L113

Good Suggestion 👍

There is a pull request that helps to fix this by reducing the amount of horizontal scrolling: https://github.com/amitshekhariitbhu/Android-Debug-Database/pull/78


Add small tests for onboard api

Use Robolectric for UT framework.
Use old test case code, and refactor them.
Add ThingIFAPITestBase as base class of UT class

@yongpingchen LGTM


OurWaitFor.absent() fails with TimeOutException / NullPointerException if element is absent in dom

In fact method absent wait for invisibility of element.
Expected behavior that absent() wait for absence of element in dom.
Moreover it's will be great to have an option about waiting for visibility/invisibility with absence of element too.

Hey @BlackEnf0rcer,  interesting idea. Could you please share the real-life case when your test care about the element being "invisible" or "absent in dom"?
We could discuss it in our gitter chat so others can also share their thoughts, what do you think?
(please join if u agree - https://gitter.im/teasy-test-framework/Lobby)

Having re-read the comment I suppose I get the suggestion - so we keep the name as "absent" but will check for eithet "absent in dom" or "isDisplayed=false"

@BlackEnf0rcer going back to your suggestion. I have received a comment from another user that it might be confusing that element().should().beAbsent() fails with TimeoutException. But if you take a closer look it is an element() method that actually fails in case there is no element. (because it's expected behavior of an element() method to return only in case of a visible element - otherwise to fail).
Method absent() will return true (i.e will continue test) if the element (that was present before calling a condition) will become absent in dom (StaleElementException will be thrown by element and caught by absent()).
We have some ideas on how to make element().should().beAbsent() not failing on element() method call but it may take some more time to work it out.
As of now, you can just rework your logic for the absence of an element in a different way. If you need any suggestion on this - please ping me in a gitter chat.

Fixed in 1.0.9-beta.


Mercurial doesn't support JWT

When trying to clone the Sena-3 project via Mercurial directly at the command-line, I was able to get an error message that told me why one of the SendReceive tests wasn't failing:
rmunn@laptop$ hg clone http://username:password@localhost:5158/api/v03/sena-3
ValueError: AbstractDigestAuthHandler does not support the following scheme: 'Bearer'".

The username and password were correct. But the ASP.Net auth service returned a JWT challenge (auth scheme "Bearer") and Mercurial doesn't know how to handle that. We need to have the auth service for the SyncReceiveProxy set up to challenge with auth scheme "Basic", and then Mercurial will be able to clone (and pull, and push) projects.
Note that I used a modern Mercurial version (version 6+) to get this error. Version 3 just returned the uninformative "abort: authorization failed" message, which wouldn't have allowed me to figure out the issue with the auth challenge being Bearer (JWT) rather than Basic.

There's a particular Mercurial behavior that's causing the problem here. Even if you specify a username and password directly in the URL, Mercurial will first send an unauthenticated HTTP request first, and wait for a 401 response before sending the Authorization header. Here's a network capture of the HTTP traffic when I did hg clone http://username:password@localhost:5158/api/v03/sena-3:
GET /api/v03?cmd=capabilities HTTP/1.1
Accept-Encoding: identity
accept: application/mercurial-0.1
host: localhost:5158
user-agent: mercurial/proto-1.0 (Mercurial 6.1.1)

HTTP/1.1 401 Unauthorized
Content-Length: 0
Date: Tue, 30 May 2023 03:06:42 GMT
Server: Kestrel
WWW-Authenticate: Bearer
lexbox-version: dev

Note that the server is responding with WWW-Authenticate: Bearer, not Basic. Somehow the "AuthorizationPolicy": "UserHasAccessToProject" line in proxy.appsettings.json is failing to send a Basic auth challenge, even though the ProxyKernel code is trying to use the BasicAuthScheme. I don't yet understand why the proxy code is failing to return Basic auth, but that's definitely the root cause of this issue.

Actually, this might stem from something else entirely. LibChorus was originally designed for use with a GUI, and some parts of its design still show through. For example, when you clone a project, if it's a normal Mercurial server it gets the username and password from the URL. But if it's a resumable server, the username and password in the URL are ignored (!!) and the username and password are taken from a config object, which ends up reading a user.config XML file, instead (!). The design intent appears to be that resumable servers only need to be accessed from FieldWorks, and not from other sources like Language Forge.
I'm currently researching ways to work around this design: whether we can supply the username and password in environment variables somehow, or anything else. But we might just have to do a clone with a non-resumable URL, then only test the Send/Receive with the resumable URL.

The solution looks like this:
var model = new Chorus.Model.ServerSettingsModel();
model.Username = "username";
model.SaveUserSettings();
Chorus.Model.ServerSettingsModel.PasswordForSession = "pass";

Note that the SaveUserSettings() call must come after the username, but before the password. If you attempt to set the password before saving the user settings, Chorus attempts to encrypt the password on-disk (sensible), using an API that only works on Windows (oops) and you get:
System.PlatformNotSupportedException : Windows Data Protection API (DPAPI) is not supported on this platform.

I'll take a look at my auth code. It should actually be returning WWW-Authenticate: Bearer, Basic or something like that since they're both supported, but something might be going wrong somewhere.

closed as this was due to not having the proxy setup correctly.


Add a "replace()" API for the navigator.

This lets you dynamically replace one route with another.

LGTM


Course link

Can you please provide me with this course link ??

It has been removed from the site


Solving np.nan problems

when pandas parses blanks, it always represent them as np.nan. This is a problem since the np.nan are Floats, but we might want to insert them in other data types (e.g. bool or varchar). This PR forces the template to represent all np.nan as None, so they'll be inserted as 'Null' in the DB.
In order to use the DataFrame.where function, the DataFrame should not have duplicate columns. We where allowing them in the load function, but raising an error in the create step. I think it is ok to already raise an error in the load function, so we execute less work. I've changed that here and updated the relevant test.

Aside from the missing test cases that we discussed offline, and the one minor comment I had, this looks good.

:+1:


Lazier LazyList?

@sjrd pointed mo to https://github.com/scala/bug/issues/10696
In our current LazyList implementation, you have to say whether a LazyList instance is going to be empty or non empty at the time you build it, making it impossible to implement an unblocking linesStream operation. We should consider delaying the moment where we say whether the LazyList is empty or not to iteration time instead of construction time.

It's getting too late in the 2.13 release cycle for this but it would be nice to reconsider it for 2.14.

It doesn't seem to me like it ought to be that difficult to change. Currently, the two concrete subclasses of LazyList (like List) are Empty and Cons. It doesn't seem that far-fetched to me to add an Unknown subclass of some sort which doesn't know what it is yet, but will resolve to an Empty or Cons (probably via wrapping) once it does know whether it has elements.

making it impossible to implement an unblocking linesStream operation

I'm not sure that deferring computation of whether or not the LazyList is empty to iteration time will enable non-blocking IO - at the end of the day, the lines are either there when you try to compute them or not. Please correct me if I'm misunderstanding

Well for one, it can't be a sealed trait with two concrete subclasses for empty and non-empty, since that immediately requires to synchronously decide which subclass to return.
Instead, the definition of LazyList should look like the following:
object LazyList {
  private sealed abstract class State[+A]
  private case object Empty extends State[Nothing]
  private final class NonEmpty[+A](byNameHead: => A, val tail: LazyList[A]) extends State[A] {
    lazy val head: A = byNameHead
  }
}

final class `LazyList[+A] private (byNameState: => State[A]) {
  private lazy val state: State[A] = byNameState
}

or something else with equivalent expressivity.
The good news is that the public API should be mostly unchanged, except that of course we need at least one public "constructor" that exposes the lazy nature of empty/non-empty.

The good news is that the public API should be mostly unchanged, except that of course we need at least one public "constructor" that exposes the lazy nature of empty/non-empty.

I think from[A](IterableOnce[A]): LazyList[A] does that pretty trivially. Just wait to call hasNext on the iterator.

@NthPortal it won't be non-blocking I/O in the sense that it's all using asynchronous I/O without locks, of course. But at least you can actually make the start of I/O operation lazy, like the rest of it.
But that's not even the point. This problem is not related to I/O. It's much larger than that! If you call xs.filter(f) where xs is a LazyList, you would expect the call to be lazy and immediately return, wouldn't you? Problem is, it's not, because it needs to decide right away whether to return an empty or non-empty one. Which, in the case of filter, requires an unbounded number of operations.

Potentially we could just tweak Deferrer to be a subclass of LazyList?

Let’s fix this. This is our shot at fixing Stream

If this really can't be fixed by 2.13.0 it seems like it'd be more responsible to remove LazyList from the collections than ship something known to be broken.

Strongly agreed, I would rather fix this properly now. The current collections already have a bad enough rep for our broken Stream type, we really shouldn't repeat history in this regard


Tunnelbear

[✔] Have you signed the Contributor License Agreement?
[✔] Have you checked that there aren't other open pull requests for the same manifest update/change?
[✔ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ✔] Have you tested your manifest locally with winget install --manifest <path>?
[✔ ] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@Dana-Woo these files are showing up in the GitHub UI as binary files. Can you make sure you're using UTF-8 encoding so they are visible to readers here?


Debug sidebar improvements

Issue Type: UI/Feature Request
This is a continuation of #58445 except it is more inline with the Submitting Bugs and Suggestion guide.

Debug
This issue details my vision for an improved Debug sidebar. This issue focuses on the UI ASPECT:

The sections should display some text when there is no debug session currently active, such as: There are no active debug sessions
The Title area where it says Debug is a pure mess and looks very rushed. The Dropdown for configuration could probably receive the nice looking dropdown treatment (such as the ones in the titlebar) because it looks much more aesthetically pleasing

It could probably also move into its own Section named Configuration of the sorts, with perhaps more control over what the user wants to happen. I personally don't have much experience with this menu (only started using it recently to develop extensions in my own time) so I'll leave that idea here.
The Start Debug arrow can move to join with the other icons there, and perhaps be a button inside the new section too

Seems like a duplicate of https://github.com/Microsoft/vscode/issues/56391.

duplicate of #56391.


Adding a Genre section #146

Issue: #146
I have added the genre section describing the various types of genre to talk about.
I have added in total 9 genre with a brief overview about each one.

Issue: #146
I have added the genre section describing the various types of genre to talk about.
I have added in total 9 genre with a brief overview about each one.

resolve conflicts!

Make sure to pull all the existing changes before pushing anything. Solve the above conflicting issues and raise your PR again.


chore(angular): use angular project standards

As we use this libraries in our products, I'd like to offer this PR to improve a bit its support.
This PR is a rework of the project structure. I backed up all files, made a clean install of Angular 12 and move back files, renaming them when they used camelCase instead of Angular default (param case) and putting them in a bit more organized folder structure.
This PR does not include any changes in the public API nor changes in the internal code itself. All none code files remain the same. package.json scripts remain the same apart from the remove of the --prod flag in the build command. Production build is now the default with Angular 12.
This PR  includes:

spec file for each component, directive and service files. The coverage is still low but its a start to improve them.
strict TS and template checking. Some of the component's input have been marked as optional (:?) to pass TS strictness, it does not change their behavior at all. Template checking revealed a little bug in the demo template that I fixed.
partial compilation mode which is the recommended way of building Angular libraries

This PR removes:

tslint as it is deprecated and not included by the Angular installation any more.
protactor as it is not provided any more by Angular. But it was not used anyway.

Hi @isaacplmann,
I wanted to know if you actively maintain this repository (and I would totally understand you are not willing to) or just keep up with Angular updates. If you don't want to spend the time or if this PR does not match the goals you have with this repo could you just tell me please. I can close it and take actions on my fork.
Regards,
Stephane


Question: Watermark upscaling

Hey there,
I noticed that these two lines of the watermark filter have been using SizeDown.
https://github.com/cshum/imagor/blob/v1.4.7/vips/filter.go#L51
https://github.com/cshum/imagor/blob/v1.4.7/vips/filter.go#L57
Is there any specific reason to use it instead SizeBoth?
At least from some tests I've done using SizeBoth, it works well there in case the base image is bigger than the max size of the watermark image.

Fixed in v1.4.12


Document WFM Component

Requires a section in the components doc.

is this still a beta requirement at this stage?


Islandora Defaults testing instructions

Islandora Defaults need documented testing instructions. This process isn't simple and is not the typical Drupal module test.
Because this isn't consistent with typical Drupal modules testing and isn't specific to just a single PR I feel like these instructions are needed to make "testing" and "reviewing" more approachable.

Islandora Defaults is being deprecated. The testing instructions for its replacement the Starter Site, are:

You must create a fresh new site to test the starter site. That's just how it works.
ISLE: change the line reading composer create-project islandora/islandora-starter-site:dev-main to specify the branch (the branch name, here main is preceded by dev- because it does not look like a version string. if the branch name in question was 2.x then you would ask for 2.x-dev. I was today years old when I learned this.). I do not think there is a way to change to a forked repo.
Playbook: change drupal_deploy_repo to the appropriate github repo. Change drupal_deploy_version to your branch. Do not add dev- or -dev to the branch in this case.


FormWidth does not work with CSS

Hi
I am trying to apply formwidth to form fields
[FormWidth (Small=12, Medium=6, Large= 4)]

I have added column width to the media query in serenity css

After doing this when I run the application and use chrome dev tools to validate responsiveness using the device iPad only the width of col-md-6 shows as applied and UI looks weird when I manually apply col-sm-12 in dev tools UI looks okay.

Any Idea what I am doing wrong.

Serenity uses flex layout system there. Check CSS Flex

@VictorTomaili thanks for your reply. Me being a C# developer is bit confusing as never directly worked on CSS. If I am not wrong do I need to add .flexlayout before .col-sm-12.field??

I never directly worked on css either. But I think you must check how to work flex system on css before made any changes.


Add jqplay in the "integrations" section

Vim-jqplay is a pretty solid plugin that is written in Vim9script: https://github.com/bfrg/vim-jqplay

LGTM. Thanks!


feat(dashboard): display proper transfer amount

Show proper transfer amount sent from sender to receiver

fetch balance from the below RPC response
 {
                        "method": "balances",
                        "section": "Transfer",
                        "data": {
                            "from": "14Kazg6SFiUCH7FNhvBhvr4WNfAXVtKKKhtBQ1pvXzF1dQhv",
                            "to": "1RSCaE5Hy49RCGPoR4BxEiMhjA2ENGRYEJ2dAFLTNBsoHSq",
                            "amount": "49,870,000,000"
                        }
                    },

services/polkadot/index.js


Let user reattempt solving an arbitrary step in the tutorial

I cannot figure out a way of redefining a solution to a chosen step of the tutorial if I have already found a solution and the step is marked [solved]. E.g. I find a solution from the first principles and and then I want to check another more elegant one.

Hmm, would just enabling the win condition for the problem you're currently looking at be a sufficient enough user interface? Or do you want a more explicit "retry" option?

"Retry" sounds good!
Or if I redefine the variable (like the variable E of problem 28) I'd like to have my solution re-checked. E.g. right now it seems that redefining E to be something deliberately wrong (like E := λx.x) does nothing: the problem is still [solved].

interim version implemented here, this just checks win condition for your current problem https://github.com/evinism/lambda-explorer/pull/57


Issue with Table horizontal scroll

How to make the table scroll horizontally without the ellipsis?
Couldn't find any relevant props in the documentation.
Doing anything like setting overflow to auto in parent element or removing overflow from cells breaks the table.
https://codesandbox.io/s/new-monad-if7339?file=/index.js

adding overflow property may fix this

.table-class{
  overflow-x: auto;
  display: block;
}

``


[backport] Merge fp16 headers for CUDA 11.2+

Backport of #5993 by @leofang

[automatic post] Jenkins, test this please.

Will retrigger cuda115 test after docker image generated: https://ci.preferred.jp/cupy.prep-linux/83732/

Jenkins CI test (for commit fa1753c654dd40df71e757e94032904ab02707bf, target branch v9) succeeded!

Will merge when this test pass: https://ci.preferred.jp/cupy.linux.cuda115/83907/


Aligned buttons

Some syntax error in the file: illegal use of double-quote.
Plus it don't solve the issue. Did you test it?

Fixed by https://github.com/llaske/sugarizer/pull/232


Typo in NewHandler Function Description

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

nice catch, thanks!

Codecov Report

Merging #374 (01f83ff) into master (e0b9a6c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #374   +/-   ##
=======================================
  Coverage   72.22%   72.22%
=======================================
  Files          19       19
  Lines         738      738
=======================================
  Hits          533      533
  Misses        138      138
  Partials       67       67

Impacted Files
Coverage Δ

lambda/handler.go
96.92% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0b9a6c...01f83ff. Read the comment docs.


Update generated code used in Python interop tests

@soltanmm, please review but do not merge until after #1201 is merged. This change is based off of #1201 and will have to be rebased if the content of #1201 changes.

GitHub doesn't seem to automatically find shared commits. :-( :-( :-(

Weird fact: pushing an older commit to a branch in an attempt to refresh the pull request content marks the pull request as closed.

Since the build is taking a while: https://travis-ci.org/grpc/grpc/builds/57361026 shows passing tests with this content (albeit a different commit history due to the way that merging pull requests creates a commit).


TP-640: Replace inappropriate parent nodes.

In some cases new Goods Nomenclature Indents are inserted in between
old indents and their children. When this happens it is important to
update the tree by migrating these children under the new indent.
This commit introduces an addition to the GoodsNomenclatureIndentHandler
post_save method, finding inappropriate parents of possible child nodes
and replacing them with the new indent.

Tests fixed.
But realised there's a glaring hole in the logic where I'm not updating the rest of the tree below the children.

Codecov Report

Merging #224 (86738c6) into master (a1597bb) will decrease coverage by 0.04%.
The diff coverage is 56.75%.

@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
- Coverage   61.17%   61.12%   -0.05%
==========================================
  Files         181      181
  Lines       10962    11026      +64
  Branches      829      848      +19
==========================================
+ Hits         6706     6740      +34
- Misses       4069     4091      +22
- Partials      187      195       +8

Impacted Files
Coverage Δ

common/util.py
47.29% <14.28%> (-3.45%)
:arrow_down:

commodities/import_handlers.py
41.81% <45.45%> (+0.83%)
:arrow_up:

commodities/models.py
13.51% <66.66%> (+3.03%)
:arrow_up:

commodities/tests/test_importer.py
99.48% <100.00%> (+1.10%)
:arrow_up:

common/tests/factories.py
99.63% <100.00%> (ø)

common/tests/util.py
69.18% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1597bb...86738c6. Read the comment docs.

Brain is gearing up to review this one… (it takes a couple o' days…)


chore(deps): upgrade configuration

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-configuration-k8s-30-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4269

Questions ?
Please refer to the Backport tool documentation


Update youtube-rewriter error handling to pass captioning errors as ChatCraft message

This fixes #605
Background
If you use /import with a Youtube video that either has no English captions or no captions at all, ChatCraft will throw a non-descriptive error toast:

Caption extraction for YouTube videos is handled by youtube-captions-scraper within functions/lib/rewriters/youtube-rewriter.ts.
A previous PR for this (#618) would extract unhandled error messages from the HTML of a generated CloudFlare Pages page and put it inside an Error Toast.
Fix
In this PR, any errors thrown in youtube-rewriter will show up in the /import Response (as a ChatCraft message):

Can we remove the other fix you made before, or does it still have value?

I had both fixes in one branch and found that only this fix would be triggered if an error occured (there'd be a ChatCraft message but no Error Toast).
We can remove the other fix.


[feature] update k8s.io/klog to k8s.io/klog/v2

What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

/kind feature
What this PR does / why we need it:
update k8s.io/klog to k8s.io/klog/v2
btw: after this pr merged, and then update k8s.io library version from v1.18 to v1.20.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

/assign @Fei-Guo @DrmagicE

/lgtm


fixfix string deserialize with unescaped char

before this pr : if we use streamload with unescaped char in json format , we will not deal with it in nested type.
like this :

after we will deal with it in output:
|   27 | "双引号"    | [""双引号"", "反斜\线"]       |

Issue Number: close #xxx

run buildall

run p0


Add Genesys IVR System (http://www.genesys.com/)

Add Genesys IVR Service (http://www.genesys.com/).  Does not currently support 2FA.

The providers page is being removed. You can read more about that on #1177.


Update schematic in layout-widget.md

Description

update the schematic of the layout widget

Issues that will be closed

Testing

Checklist

[x] I have read the README document
[x] I have read the CONTRIBUTING document
[x] I have added tests to cover my changes
[x] All new and existing tests passed
[x] My commit message follows Conventional Commit Guideline

Merge activity

Nov 17, 7:05 AM: @kenshyx merged this pull request with Graphite.


Adhere to Java Naming Conventions

Description
As an implementor, I want namings in Teku to conform to Java Naming Conventions, so that the code is more legible and cohesive. Here are Java naming conventions: https://www.geeksforgeeks.org/java-naming-conventions/

hey @cemozerr  is this issue still open, would like to pick this.

@stingray55 This is still relevant, though many of the places it's an issue are being fixed as they move into the spec module. I'd ignore anything that's already marked as @Deprecated as it will have a new version that should be named correctly already and the old version will be removed as we migrate the code anyway.
But there are a bunch of methods in places like BeaconState which are still an issue and would be great to fix.
My suggestion would be to put up a number of small PRs to minimise the number of conflicts - so a PR that renamed the methods in BeaconState would be a great start, then look for another class to fix up and so on.  The smaller the PRs the quicker we can review and merge them and the less likely we'll have a difficult merge to deal with.

@ajsutton  is this task still open.
as I see in BeaconState abstract class the method names are adhering to Java naming conventions, but the variables are not, should i format those instance variables ?

public abstract class BeaconState implements State {
  @Schema(type = "string", format = "uint64")
  public final UInt64 genesis_time;

  public final Bytes32 genesis_validators_root;

  @Schema(type = "string", format = "uint64")
  public final UInt64 slot;

  public final Fork fork;
  public final BeaconBlockHeader latest_block_header;

  @ArraySchema(
      schema = @Schema(type = "string", format = "byte", description = DESCRIPTION_BYTES32))
  public final List<Bytes32> block_roots;

  @ArraySchema(
      schema = @Schema(type = "string", format = "byte", description = DESCRIPTION_BYTES32))
  public final List<Bytes32> state_roots;

  @ArraySchema(
      schema = @Schema(type = "string", format = "byte", description = DESCRIPTION_BYTES32))
  public final List<Bytes32> historical_roots;

  public final Eth1Data eth1_data;
  public final List<Eth1Data> eth1_data_votes;

  @Schema(type = "string", format = "uint64")
  public final UInt64 eth1_deposit_index;

  public final List<Validator> validators;

  @ArraySchema(schema = @Schema(type = "string", format = "uint64"))
  public final List<UInt64> balances;

  @ArraySchema(
      schema = @Schema(type = "string", format = "byte", description = DESCRIPTION_BYTES32))
  public final List<Bytes32> randao_mixes;

  @ArraySchema(schema = @Schema(type = "string", format = "uint64"))
  public final List<UInt64> slashings;

  @Schema(type = "string", format = "byte", description = DESCRIPTION_BYTES_SSZ)
  public final SszBitvector justification_bits;

  public final Checkpoint previous_justified_checkpoint;
  public final Checkpoint current_justified_checkpoint;
  public final Checkpoint finalized_checkpoint;

@seroze Yes we've made some progress on it but there's still a bunch of places we're using snake case in various classes (Attestation has a few too I think).  The BeaconState class you're looking at there is actually part of the REST API definition. We can probably leave those as-is - if we renamed them we'd have to use an annotation to tell the JSON serialiser to use the snake-case version so we don't break the API.  There's a separate BeaconState interface in the spec module which is the internal representation and its the internal names we're most keen to fix up.

@ajsutton  i have a raised a PR for Attestation class, will refactor more classes once we identify them. (is there an automatic way to identify them)
one dumb doubt. why is spotlessJava plugin not complaining about the use of snake case for method names.


feat: Entry refactoring to allow external creation.

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Addresses #1545

I feel having mode set as Unknown without checking is still dirty, as we have to take care at flag checks and merging. Proper way will be to have Option<Metadata> as the value for cached_metadata instead of Metadata.


Nix: deprecate waybar-hyprland

Describe your PR, what does it fix/add?
Now merged in Nixpkgs, no reason to keep it here.
Fixes #2971.
@CnTeng @NotAShelf can you please test that this doesn't break rebuilds?
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
No.
Is it ready for merging, or does it need work?
Ready.

Will test shortly.

It works well. Thanks.

Lgtm


Updated to support Nest API changes and fix set_temp and away_mode an…

Hello.  I have made some changes to the Nest implementation in order to fix setting the temperature, grab the min and max temps from the Nest API, grab the correct Device name based on changes to the Nest API, and enforce sending all temperatures to the Nest API in celsius.  This requires the most recent version of python-nest, now at 2.4.0.  I have tested these changes with an actual Nest using the Home Assistant frontend interface.  Let me know if you would like me to make any changes to the request.  Thanks!

Awesome, thanks!
I've had one comment to be addressed.
You've also missed one reference to the version of python-nest that is being used. Please update that one too.

Thanks for the comment, that makes a lot of more sense.  All changes have been made.  Let me know if there is anything else!

Ok.  I think this is much better.  I have moved all unit conversions to the Thermostat class and cleaned up the the state_attributes method a little.

Awesome!

Oh snap, just realised your PR points at the master branch. Can you point it at the dev branch? For this you have to close it and open a new one.

Sorry about that.  Still getting used to using git and github...


Bump smallwins/slack to 11.0.0

Security fix for https://nvd.nist.gov/vuln/detail/CVE-2018-1000096
May warrant a major revision release as people may have been depending on the default behavior of trusting invalid SSL certs. Tested locally on a Slapp project and everything works.

Coverage remained the same at 100.0% when pulling 122c6855bebcf3c7f380d08aabe08da280adce90 on bump_slack_11 into 8840dd26b4e862a0a580e3515268cd268137ba80 on master.

Coverage remained the same at 100.0% when pulling 122c6855bebcf3c7f380d08aabe08da280adce90 on bump_slack_11 into 8840dd26b4e862a0a580e3515268cd268137ba80 on master.


[Bug]: cannot get document node

Bug Description
The get_document function cannot get any document nodes
The following code uses the node_collections which does not include any document node.
https://github.com/run-llama/llama_index/blob/main/llama-index-core/llama_index/core/storage/docstore/keyval_docstore.py#L276
Version
master
Steps to Reproduce
mini_index = VectorStoreIndex.from_documents([Document(text='hello world')])
mini_index.storage_context.docstore._kvstore.get_all(collection=mini_index.storage_context.docstore._ref_doc_collection)
mini_index.storage_context.docstore.get_document('*****replace with above doc id******')

Relevant Logs/Tracbacks
No response

I know it's confusing, but the docstore only stores nodes (as well as matadata about each parent document)

Thanks for your reply. BTW, is there any interface that i can get the full document of a single node

Once its broken into nodes, not really (mostly to avoid storing duplicates of the same text)
You can store in the metadata the name of the file though, to map back to it


Heading in Create Test and Take Test sections

There are heading in other three sections but in "Create Test" and "Take Test" sections there is no heading. I would like to add those headings if you could assign this task to me.

@umar-9540 Go for It!


Unable to start JVM through JPype on Amazon linux

I am using JPype to call Java code from my python tests and starting JVM via Jpype.
I am using custom classpath and default JVM path for execution. In the error it is able to find the classpath and default jvm path.
This is giving error while starting the JVM
jvmpath = '/usr/lib/jvm/java-1.8.0-amazon-corretto/jre/lib/amd64/server/libjvm.so', classpath = ['/home/jaiadi/test_new/*'], ignoreUnrecognized = False
convertStrings = False

    def startJVM(*args, **kwargs):
        """
        Starts a Java Virtual Machine.  Without options it will start
        the JVM with the default classpath and jvmpath.

        The default classpath is determined by ``jpype.getClassPath()``.
        The default jvmpath is determined by ``jpype.getDefaultJVMPath()``.

        Parameters:
         *args (Optional, str[]): Arguments to give to the JVM.
            The first argument may be the path the JVM.

        Keyword Arguments:
          jvmpath (str):  Path to the jvm library file,
            Typically one of (``libjvm.so``, ``jvm.dll``, ...)
            Using None will apply the default jvmpath.
          classpath (str,[str]): Set the classpath for the JVM.
            This will override any classpath supplied in the arguments
            list. A value of None will give no classpath to JVM.
          ignoreUnrecognized (bool): Option to ignore
            invalid JVM arguments. Default is False.
          convertStrings (bool): Option to force Java strings to
            cast to Python strings. This option is to support legacy code
            for which conversion of Python strings was the default. This
            will globally change the behavior of all calls using
            strings, and a value of True is NOT recommended for newly
            developed code.

            The default value for this option during 0.7 series is
            True.  The option will be False starting in 0.8. A
            warning will be issued if this option is not specified
            during the transition period.

        Raises:
          OSError: if the JVM cannot be started or is already running.
          TypeError: if an invalid keyword argument is supplied
            or a keyword argument conflicts with the arguments.

         """
        if _jpype.isStarted():
            raise OSError('JVM is already started')
        global _JVM_started
        if _JVM_started:
            raise OSError('JVM cannot be restarted')

        args = list(args)

        # JVM path
        jvmpath = None
        if args:
            # jvm is the first argument the first argument is a path or None
            if not args[0] or not args[0].startswith('-'):
                jvmpath = args.pop(0)
        if 'jvmpath' in kwargs:
            if jvmpath:
                raise TypeError('jvmpath specified twice')
            jvmpath = kwargs.pop('jvmpath')
        if not jvmpath:
            jvmpath = getDefaultJVMPath()

        # Classpath handling
        if _hasClassPath(args):
            # Old style, specified in the arguments
            if 'classpath' in kwargs:
                # Cannot apply both styles, conflict
                raise TypeError('classpath specified twice')
            classpath = None
        elif 'classpath' in kwargs:
            # New style, as a keywork
            classpath = kwargs.pop('classpath')
        else:
            # Not speficied at all, use the default classpath
            classpath = _classpath.getClassPath()

        # Handle strings and list of strings.
        if classpath:
            if isinstance(classpath, str):
                args.append('-Djava.class.path=%s' % _handleClassPath([classpath]))
            elif hasattr(classpath, '__iter__'):
                args.append('-Djava.class.path=%s' % _handleClassPath(classpath))
            else:
                raise TypeError("Unknown class path element")

        ignoreUnrecognized = kwargs.pop('ignoreUnrecognized', False)
        convertStrings = kwargs.pop('convertStrings', False)

        if kwargs:
            raise TypeError("startJVM() got an unexpected keyword argument '%s'"
                            % (','.join([str(i) for i in kwargs])))

        try:
            _jpype.startup(jvmpath, tuple(args),
>                          ignoreUnrecognized, convertStrings)
E                          TypeError: function takes exactly 5 arguments (4 given)
jpype/_core.py:212: TypeError
___

My code looks like this for starting JVM
            JAR_CLASSPATH = ['/home/jaiadi/test_new/*']
            jpype.startJVM(jpype.getDefaultJVMPath(), classpath=JAR_CLASSPATH, convertStrings=False)

Any idea on why i am getting param error?

I don't see anything unusual that should be causing an error.

Not sure whats the reason but downgrading to 1.2.1 solved this issue. I hope its not bug with the latest.

I verified there have been no code changes to jpype since 1.2.1.   So most likely this was a local site build problem of some kind.


Header height changing

Hi, I would like to change header's height but I've stuck with it. I cant find ganttHeaderHeight option anywhere. As I can see this option is responsible for header's height, but I can't find where this option is setting up or changing. Please advice.
Thanks

It can be customized with some CSS.
.gantt-header-row, .gantt-header-row .gantt-column-header {
    height: 60px;
}

Reopen if you can achieve what you want using CSS.


Investigate importing Affiliations functionality from HEDAP

This involves the following files from HEDAP:
https://github.com/SalesforceFoundation/HEDAP/blob/master/src/classes/AFFL_MultiRecordType_TDTM.cls
https://github.com/SalesforceFoundation/HEDAP/blob/master/src/classes/AFFL_MultiRecordType_TEST.cls
https://github.com/SalesforceFoundation/HEDAP/blob/master/src/classes/AFFL_AccRecordType_TDTM.cls
https://github.com/SalesforceFoundation/HEDAP/blob/master/src/objects/Affl_Mappings__c.object
WARNING: this is meant to replace the existing affiliations functionality.

**lurch:add

Tracking W-008346

Salesforce has determined that this issue will not be explored further.


Document how to use Global project default resources

User Story

As an AI engineer working on a multi-agent project
I want to set global project settings
So I don't have to update individual yaml files one-by-one (and possibly missing a file or making other errors that are difficult to track down)

User Acceptance Testing Criteria

Given that I am working on a multi-agent project such as GitHub Assistant
When I want to make a global change across all my agents, e.g., not using the claude apu
I can do so in one location instead of having to work through every agent file

we have the ability to set defaults (ie, default apu machine wide), but it is undocumented. changing this story to documentation


Update .npmignore

I am not 100% sure with the slashes but I know for sure that you're distributing your example with the package

Thanks for the adjustment. No need to clutter npm. I forget about .npmignore.

Would it be possible to publish a new version that doesnt contain the example project? Thanks!

@mehcode yes, could you please make a release so I can stop using my fork? Thanks!

Sure. Released as v4.0.1. I honestly didn't consider this to be that important. Would you satisfy my curiosity as to why this mattered to you? It's not like the example code gets bundled into your app.

@mehcode I'm using MS mobile center for building the app and while I don't remember the exact reason, it was failing when the example was included. Thanks!

Did not have real failures but the example directory turns out to be quite big, we're trying to slim down our project in CI. Thanks!


请问下 ip adapter 的bin文件是finetune过的，还是原始的.bin文件也可以呢

请问下 ip adapter 的bin文件是finetune过的，还是原始的.bin文件也可以呢

We don't use any weight from IP-Adapter, we train our models on our own from scratch, so please download required models following our instruction.


What's better?

What's better?
$smConfig = isset($configuration['service_manager']) ? $configuration['service_manager'] : [];
$serviceManager = new ServiceManager(new Service\ServiceManagerConfig($smConfig));

OR
$smConfig = &$configuration['service_manager'] ;
$serviceManager = new ServiceManager(new Service\ServiceManagerConfig((array)$smConfig));

I'd go with the first one.
PHP7 would then further allow for $smConfig = $configuration['service_manager'] ?? []
dimon-smith<EMAIL_ADDRESS>schrieb am So., 6. Sep. 2015 um
19:43 Uhr:

What's better?
$smConfig = isset($configuration['service_manager']) ? $configuration['service_manager'] : [];
$serviceManager = new ServiceManager(new Service\ServiceManagerConfig($smConfig));
OR
$smConfig = &$configuration['service_manager'] ;
$serviceManager = new ServiceManager(new Service\ServiceManagerConfig((array)$smConfig));
—
Reply to this email directly or view it on GitHub
https://github.com/zendframework/zend-mvc/issues/25.

@manuakasam
mmm... But zf3 must be compatible with php 5 ...

@dimon-smith you were asking about an approach, not about what zendframework's approach should be.


Allow specifying multiple dockerRegistryAuths.

Description of the feature or enhancement:

Currently, only a single secret for registry auth is accepted when creating a pod/deployment. The K8s spec allows for mutiple to be specified, so that we can pull images from multiple sources if needed.
Use Case:

I need my pods to include a container from my own registry plus a sidecar from a public registry.
Proposed Solution:

Unsure how best to make a change like this - not all the supported languages allow for args to be multiple types like in TS or Python AFAIK (in those languages you could just allow ISecret | ISecret[]/Python equivalent to avoid breaking existing code), so potentially adding a new property? Seems clunky though.
Other:

[ ] :wave: I may be able to implement this feature request
[x] :warning: This feature might incur a breaking change

This is a :rocket: Feature Request

Yeah this unfortunate, but a new property/method would be required to avoid a breaking change. Still ok.


Allow TypeHandler for Enum on annotation configuration #444

I've fixed #444.
Please review this.
Thanks.

@kazuki43zoo
Can you please add a test case to demonstrate both the problem and the solution?

Yes, of course !
However, please give a time to adding test case.
I will add test case and update this.

Hi @emacarron ,
I've added three test cases for @Arg, @Result, @TypeDiscriminator.
Please check.

Thank you!


Flags to opt in to  .NET Framework 4.7.1, 4.7.2, 4.8, and the August 2020 cumulative update for .NET Framework 4.8 accessibility changes are wrong

Flags to opt in to  .NET Framework 4.7.1, 4.7.2, 4.8, and the August 2020 cumulative update for .NET Framework 4.8 accessibility changes are wrong; quotations should be around the value and semicolons separating each flag instead of lines.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 642b7f23-cc05-b8cb-5ec1-862fa6e62b8c
Version Independent ID: 0d7236b7-8c64-7eb0-69c8-101c738f275a
Content: What's new in accessibility in .NET Framework
Content Source: docs/framework/whats-new/whats-new-in-accessibility.md
Product: dotnet-framework
GitHub Login: @gewarren
Microsoft Alias: gewarren

Thanks @MattHyman! I've fixed this in the linked PR.


Feature request: replace pop-up notifications with status bar connection indicator

I find the Connected / Not Connected / Lost connection pop-up notifications to be distracting. A connection status indicator in the status bar would be less distracting.

After a few hours of using them, i do find them annoying. I'll look into moving the notifications to the status bar. Hopefully tomorrow there will be a new release 😄

When I upgrade the plugin to 1.3.2 on one of my machines it immediately downgrades to v1.1.2. I didn't think it was syncing plugins, but I assume this is because the server has an earlier version and for some reason it thinks the files are newer? Should I file a separate ticket about that?

That's normal behaviour. You need to upgrade the server and the server will push the new version to the clients when they connect.
Downgrading only happens if the client si newer tham the server.
I need to implement a better update system


How can I choose multiple items in a gridview list?

When the gridview list appears,i can only choose one package/app/feature,then press OK.How can I choose multiple items in that list?
I know this is a really dumb question,but i couldn't find an answer anywhere and I can't figure it out.

Hold the CTRL key and click each item. Or click the top item, hit SHIFT, click the bottom item, then they will all be selected, then hold the CTRL key and unselect the items you don't want from the list.

Thank you so much! I will go trough the de bloating process and finally get my lite iso.

https://forums.mydigitallife.net/threads/optimize-offline-guide-windows-debloating-tool-windows-1803-1903-19h2-1909-20h1-and-ltsc-2019.80038/ A guide I made.


default value for double options

options.add_options()
     ("myoption", "myoption description", cxxopts::value<double>()->default_value(0.1));

fails with:
/home/xs/proj/daedalean/exp/user/xs/vo_eval/src/cpp/main.cpp:25: error: reference to type 'const std::string' (aka 'const basic_string<char>') could not bind to an rvalue of type 'double'                            , cxxopts::value<double>()->default_value(0.1));
it looks like default values are only supported for strings at the moment. Might be a good idea to fix the documentation before the code fix is ready.

I'll take a look at this.

This is going to be a tricky one. The default_value function is a virtual function, so it can't be templated. I'll have to work out how to refactor this so that the original base class can be accessed when adding options.

Sorry it's taken me so long to look at this. I just realised that this is intended, and everything works fine if you pass strings to default_value.
When dealing with default and implicit values, the parser actually parses the string that you provide using the parser for the type that you have specified rather than taking an object of the correct type for the default. So in other words, you can write default_value("0.1").
Is this good enough for you, or do you have a use case where you need to pass an actual value of the required type?

That is perfectly fine for me. It is just a bit non-intuitive, so a bit of documentation would be nice. Thanks a lot for your work.

Sure, I'll improve the documentation.


[.NET] Dutch DateTimeModel refinements

Original specs: 385 pass, 2 fail.
Total specs: 552 pass, 179 fail.
The 2 failing cases involve time zones which are not supported for now.
PotentialAmbiguousRangeRegex has been enabled and implemented to help disambiguate patterns with 'voor'.
Consequently, including 'voor' into duration patterns was no longer necessary and it has been reverted.
Handling of cases involving the limit time '12' has been modified in TimePeriod so that expressions like '10 to 12 in the morning' are parsed as (T10,T12) instead of (T22,T00).
Modified test cases:

"Ik ga de 15e, 20:00 terug" -> "Ik ga op de 15e, 20:00 terug" (I'm going back on the 15th, 20:00), without preposition 'de 15e' cannot be extracted as date (same as in English 'the 15th' -> 'on the 15th').
"ik ben vandaag weg tussen vijf en zeven" -> "ik ben weg vandaag tussen vijf en zeven" (I'm gone today between five and seven)
"ik ben op 1 januari weg van 5 tot 6" -> "ik ben weg op 1 januari van 5 tot 6" (I'll be gone on January 1 from 5 to 6)

As in English number ranges can be interpreted as time ranges only when they are contiguous to a date.
In MergedParser:

"Ik zal de afspraak van tien uur 's ochtends naar twintig verzetten!" -> "Ik zal de afspraak verzetten van tien uur 's ochtends naar twintig!" (I will reschedule the appointment from ten in the morning to twenty!)
"Ik zal de afspraak van tien uur 's ochtends naar negen verzetten!" -> "Ik zal de afspraak verzetten van tien uur 's ochtends naar negen!" (I will reschedule the appointment from ten in the morning to nine!)

To avoid ambiguity, time ranges ending with pure numbers can be extracted only if not followed by other words.

@tellarin, @iMicknl, ready for review.


Add new methods to FlowBuilder and CTAction

Add MatchRegMarks to FlowBuilder to match multiple reg marks
Add MatchCTMarks to FlowBuilder to match multiple CT marks
Add LoadToCtMarks to CTAction to load multiple CT marks
Add MoveToCtMarkFields to CTAction to move multiple pair
values (source reg mark field to destination CT mark field)

Signed-off-by: Hongliang Liu<EMAIL_ADDRESS>

Codecov Report

Merging #43 (e355099) into main (245ac54) will decrease coverage by 20.36%.
The diff coverage is 25.11%.

@@             Coverage Diff             @@
##             main      #43       +/-   ##
===========================================
- Coverage   64.18%   43.81%   -20.37%
===========================================
  Files         278      210       -68
  Lines       27825    35632     +7807
===========================================
- Hits        17859    15612     -2247
- Misses       8041    18888    +10847
+ Partials     1925     1132      -793

Flag
Coverage Δ

kind-e2e-tests
?

unit-tests
43.81% <25.11%> (+0.42%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/agent/agent.go
22.26% <0.00%> (-31.04%)
:arrow_down:

pkg/agent/agent_linux.go
0.00% <ø> (-4.32%)
:arrow_down:

pkg/agent/config/node_config.go
38.88% <ø> (-61.12%)
:arrow_down:

pkg/agent/openflow/egress.go
0.00% <0.00%> (-84.22%)
:arrow_down:

pkg/agent/openflow/multicast.go
0.00% <0.00%> (ø)

pkg/agent/openflow/pipeline_other.go
0.00% <0.00%> (-5.13%)
:arrow_down:

pkg/ovs/openflow/ofctrl_builder.go
17.67% <0.00%> (-40.54%)
:arrow_down:

pkg/agent/openflow/pipeline.go
24.23% <14.36%> (-49.94%)
:arrow_down:

pkg/agent/openflow/pod_connectivity.go
32.67% <17.94%> (-37.70%)
:arrow_down:

pkg/agent/openflow/service.go
38.37% <19.23%> (-45.31%)
:arrow_down:

... and 283 more


Removed duplicated links in data concerning WebP

Commit 4d4cd8aa3635aa70b22091bd4ce0b6c8f72a414f has duplicated several links, this commit removes them.

Thanks!


Object is not subscriptable

An error appears in the log after the last update.
This error comes from the integration itself.
Logger: homeassistant.config_entries
Source: custom_components/dahua/binary_sensor.py:16
Integration: Dahua (documentation, issues)
First occurred: 20:04:41 (1 occurrences)
Last logged: 20:04:41
Error setting up entry Kamera-ALM for binary_sensor
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 293, in async_setup
result = await component.async_setup_entry(hass, self)  # type: ignore
File "/usr/src/homeassistant/homeassistant/components/binary_sensor/init.py", line 141, in async_setup_entry
return await hass.data[DOMAIN].async_setup_entry(entry)
File "/usr/src/homeassistant/homeassistant/helpers/entity_component.py", line 149, in async_setup_entry
platform = await async_prepare_setup_platform(
File "/usr/src/homeassistant/homeassistant/setup.py", line 328, in async_prepare_setup_platform
platform = integration.get_platform(domain)
File "/usr/src/homeassistant/homeassistant/loader.py", line 498, in get_platform
cache[full_name] = self._import_platform(platform_name)
File "/usr/src/homeassistant/homeassistant/loader.py", line 503, in _import_platform
return importlib.import_module(f"{self.pkg_path}.{platform_name}")
File "/usr/local/lib/python3.8/importlib/init.py", line 127, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 1014, in _gcd_import
File "", line 991, in _find_and_load
File "", line 975, in _find_and_load_unlocked
File "", line 671, in _load_unlocked
File "", line 783, in exec_module
File "", line 219, in _call_with_frames_removed
File "/config/custom_components/dahua/binary_sensor.py", line 16, in
NAME_OVERRIDES: dict[str, str] = {
TypeError: 'type' object is not subscriptable

Thanks. Taking a look.

@pepe59 what version of Home Assistant are you on? Do you have an older version of python?

@pepe59 can you upgrade to 0.6.1 and see if that corrects the problem for you?
https://github.com/rroller/dahua/releases/tag/0.6.1

Made one more update to 0.6.2

I have the HA core-2021.6.5 version
I upgraded to version 0.6.2 and after restart the error no longer appears and new 3 entities have been created. I'm going to have to see how all entities work.
Thanks for the repair

Awesome, thanks. Please reopen if you have this issue again.


⚠ Secret Website 3 has degraded performance

In 2e7b6bc, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 2632 ms

Resolved: Secret Website 3 performance has improved in cc5b50e.


samba: 4.15.5 -> 4.16.2

Description of changes
https://www.samba.org/samba/history/samba-4.16.0.html
https://www.samba.org/samba/history/samba-4.16.1.html
https://www.samba.org/samba/history/samba-4.16.2.html

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Cross compilation fails with
missing file: '/build/samba-4.16.2/bin/default/third_party/heimdal/lib/asn1/asn1_kx509_asn1.c'

the normal build fails too.

CVE-2022-2031
CVE-2022-32742
CVE-2022-32744
CVE-2022-32745
CVE-2022-32746

If 4.16 will take a little longer I could always try bumping to 4.15.9 in the meantime.

Sorry, I have not gotten to this yet. The only thing I have done is reproduce the issue locally, but that doesn't help much.
At that moment I recall it wasn't very clear to me why it was happening.
I should have some more time the coming week(s) to maybe take a closer look, will update if I find anything useful.

Well, in the meantime  #190849

4.17 out now.


Default container

Provide the ability to define a default container and execute queries against it without specifying it explicitly each time.

Delivered.


[graphite2] provide path to python, add license in vcpkg.json

Description/Changes
The port's build uses PythonInterp.
find_package(PythonInterp 3.6)

If the python is located under the LONG path, CMake fails with messages like the following.
CMake Error: GetShortPath failed for C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.11_3.11.1776.0_x64__qbz5n2kfra8p0\python3.11.exe
CMake Warning at CMakeLists.txt:78 (message):
  Python ctypes is incompatible with built DLL.  Disabling some tests.

With vcpkg_find_acquire_program(PYTHON3) in portfile.cmake, The probability may reduce.
Checklist
Would you see if the LICENSE and COPYING files are correct?

[ ] Changes comply with the maintainer guide
[x] SHA512s are updated for each updated download
[x] The "supports" clause reflects platforms that may be fixed by this new version
[x] Any fixed CI baseline entries are removed from that file.
[x] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

Sorry for being this late. I will workaround the python path problem with the environment variable.
Appreciate the comments :D
https://gitlab.kitware.com/cmake/cmake/-/issues/24853 for future visitors.

IMO the review comments were quite misleading. The PR was almost perfect for a package which really needs python. (The cmake option lacks quotes.)
However, if python is only needed for testing, and vcpkg skips tests, then -DCMAKE_DISABLE_FIND_PACKAGE_PythonInterp=ON might be more appropriate.


Language tags are not always from ISO 639-1

This may be nitpicking, but here goes.
The top level README states:

The following languages are available using their ISO 639-1 code:

But this isn't true in all cases. Currently supported three letter codes enm (Middle English) and hbs (Serbo-Croatian) are not from ISO 639-1 but from ISO 639-3.
Should this be changed to refer to IETF BCP 47 language tags instead? A downside is that the Wikipedia page only lists some of the more common languages (for understandable reasons, since there are so many valid codes). In particular, Middle English and Serbo-Croatian are not listed there.

Personally, I think BCP 47, in all its ugliness (basically "use a two-letter ISO 639-1 code if it exists, otherwise you can use ISO 639-2, ISO 639-3 or ISO 639-5 three-letter codes"), is the more relevant language code system for the use cases that I can think of. That's what most of the Internet uses for language identification (HTTP, HTML, XML, RDF...) and although it's not mentioned in the README, it seems to me that Simplemma has been following it so far.

I see, it's a documentation issue after all. What I use is ISO 639-1 + ISO 639-3 if something doesn't fit. Maybe I could just explain it like this but I'm glad to learn there is BCP 47 for that as well!


-race is not supported on riscv64

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


references to godot custom signals highlighted as errors with roslyn

Type: Bug
Issue Description
when you reference a custom signal with SignalName with roslyn enabled rather than omnisharp, it complains that "Node.SignalName does not contain a definition for Foo", even though it compiles fine with godot
this also seemingly only happens on my laptop setup, and not my desktop
Steps to Reproduce

define a custom godot signal ([Signal] public delegate void FooEventHandler();)
reference it with SignalName (EmitSignal(SignalName.Foo))

Expected Behavior
no error
Actual Behavior
error
Logs
exthost.zip

C# log
Post the output from Output-->C# here
C# LSP Trace Logs
Post the output from Output-->C# LSP Trace Logs here.  Requires `dotnet.server.trace` to be set to `Trace`
Environment information
VSCode version: 1.84.0
C# Extension: 2.0.436
Using OmniSharp: false
Dotnet Information
Host:
Version:      7.0.13
Architecture: x64
Commit:       3f73a2f186
.NET SDKs installed:
No SDKs were found.
.NET runtimes installed:
Microsoft.NETCore.App 7.0.13 [/home/ana/.config/VSCodium/User/globalStorage/ms-dotnettools.vscode-dotnet-runtime/.dotnet/7.0.13~x64/shared/Microsoft.NETCore.App]
Other architectures found:
None
Environment variables:
DOTNET_ROOT       [/usr/share/dotnet]
global.json file:
Not found
Learn more:
https://aka.ms/dotnet/info
Download .NET:
https://aka.ms/dotnet/download

Visual Studio Code Extensions

Extension
Author
Version
Folder Name

csharp
ms-dotnettools
2.9.20
ms-dotnettools.csharp-2.9.20-linux-x64

csharp
muhammad-sammy
2.0.436
muhammad-sammy.csharp-2.0.436-universal

godot-csharp-vscode
neikeq
0.2.1
neikeq.godot-csharp-vscode-0.2.1-universal

godot-dotnet-tools
woberg
0.1.21
woberg.godot-dotnet-tools-0.1.21

godot-files
alfish
0.0.6
alfish.godot-files-0.0.6

godot-tools
geequlim
1.3.1
geequlim.godot-tools-1.3.1

html-snippets
abusaidm
0.2.1
abusaidm.html-snippets-0.2.1-universal

mono-debug
ms-vscode
0.16.3
ms-vscode.mono-debug-0.16.3

vscode-clangd
llvm-vs-code-extensions
0.1.24
llvm-vs-code-extensions.vscode-clangd-0.1.24-universal

vscode-dotnet-runtime
ms-dotnettools
2.0.0
ms-dotnettools.vscode-dotnet-runtime-2.0.0

vscode-html-css
ecmel
1.13.1
ecmel.vscode-html-css-1.13.1-universal

vsshot-purple-final
undefined_publisher
0.0.1
undefined_publisher.vsshot-purple-final-0.0.1

Extension version: 2.0.436
VSCodium version: VSCodium 1.84.0 (695a9146b1347633e608f9f166c81b5b2843b492, 2023-11-02T15:23:23.641Z)
OS version: Linux x64 6.5.9-arch2-1
Modes:

System Info

Item
Value

CPUs
AMD Ryzen 7 7730U with Radeon Graphics (16 x 3835)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
1, 1, 1

Memory (System)
14.98GB (9.01GB free)

Process Argv
--ms-enable-electron-run-as-node --unity-launch

Screen Reader
no

VM
0%

DESKTOP_SESSION
bspwm

XDG_CURRENT_DESKTOP
undefined

XDG_SESSION_DESKTOP
undefined

XDG_SESSION_TYPE
x11

@ana-rchy The bug shows you're running 2.0.436 which is a fairly old version; there's been a number of fixes which could lead to the issue you're seeing. Can you upgrade to the latest and try again?

@ana-rchy The bug shows you're running 2.0.436 which is a fairly old version; there's been a number of fixes which could lead to the issue you're seeing. Can you upgrade to the latest and try again?

i cant, there is no option to update
im using vscodium-bin from the AUR with vscodium-marketplace-bin also installed, tho no newer version appears than that

Do you actually have two variants of the extension installed?

Maybe uninstall the muhammad-sammy one? Or update that one too? It looks like that fork is pulling updates from us...

Do you actually have two variants of the extension installed?

Maybe uninstall the muhammad-sammy one? Or update that one too? It looks like that fork is pulling updates from us...

'c# tools for godot' depends on the muhammad-sammy version

uninstalled the c# and godot extensions, reinstalled c# tools for godot, and it automatically installed the MS c# extension as a dependency, which fixes the issues
ill probs wanna look into getting it working with the muhammad-sammy version tho, just to make everything fully open source

yeah reinstalled extensions again but after uninstalling vscodium-bin-marketplace, and the muhammad-sammy one is now v2.8.23


feat: open directory of project resources from the webview

Description
Open file explorer for the projecr resources directory.
Linear Ticket
https://linear.app/autokitteh/issue/UI-221/vscode-open-explorer-window-where-we-display-path-info-for-any-project
What type of PR is this? (check all applicable)

[x] 💡 (feat) - A New Feature (non-breaking change which adds functionality)
[ ] 🔄 (refactor) - Code Refactoring - A code change that neither fixes a bug nor adds a feature
[ ] 🐞 (fix) - Bug Fix (non-breaking change which fixes an issue)
[ ] 🏎 (perf) - Optimization
[ ] 📄 (docs) - Documentation - Documentation only changes
[ ] 📄 (test) - Tests - Adding missing tests or correcting existing tests
[ ] 🎨 (style) - Styles - Changes that do not affect the meaning of the code (white spaces, formatting, missing semi-colons, etc)
[ ] ⚙ (ci) - Continuous Integrations - Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
[ ] ☑ (chore) - Chores - Other changes that don't modify src or test files
[ ] ↩ (revert) - Reverts - Reverts a previous commit(s).

Code Standards

[x] Notify only when user attention is needed, otherwise log to console.

[x] Notifications: short description with context identifiers (e.g. id of the manipulated entity).
[x] Logs: full description with full context identifiers (e.g. deploymentId and the relevant projectId).

[ ] If you're not sure what is the proper behavior, consult with the product team.
[ ] Reduce the use of else by employing early returns to make code more readable and less nested.
[ ] MVC Separation: Ensure separation of concerns; views should only be manipulated by controllers (also the computing - sorting, fitlering, etc.), not by services, to maintain a clean MVC architecture.
[ ] Before implementing custom logic, check if existing functions or utilities (like lodash) offer a simpler solution.
[ ] Avoid using !important in CSS where possible.
[ ] Use memoization for class calculations.
[ ] Place constant strings in your code using I18n.

Waiting for UI feedback


Add response headers

It will be good to provide headers to response, like the following syntax:
FakeServer.Status.create(:status200,
    response_code: 200,
    response_body: "hello",
    response_headers: %{ "Content-Length" => 5 })

I'll try ;)

Thank you! :)

Closing since #18 implements it


How do we cleanup eBPF maps of IPs of pods that are no longer running

Description
We currently grow this map endlessly. This is obviously problematic, we could do something with a "marked" socket but permissions are complicated here. Maybe there's some other way to figure out which pods are still running and we could do a periodic cleanup?

@bartsmykla believes we can do this with a separate eBPF program that is triggered by syscalls to delete netns.


handle native bootloading errors gracefully

example: fresh windows installations do not cope well with chroma loader being unable to load natives, errors like 0x000000C1 and 0x0000007E don't mean much to the user, perhaps instead of crashing hard, chroma should provide some guidance on how to resolve the issue

fixed in 9a2b268


CLOUDSTACK-8901: PrepareTemplate job thread hard-coded to max 8 threads

The thread pool was hardcoded to use 8 threads,
com.cloud.template.TemplateManagerImpl.configure(String, Map<String, Object>):
_preloadExecutor = Executors.newFixedThreadPool(8, new NamedThreadFactory("Template-Preloader"));
Added the change to pick threadpool size from configuration.

LGTM.

Rebased against master.

Thanks @SudharmaJain LGTM (just code review), can you do a push -f (travis job failed for some reason)

@bhaisaab I pushed it again.

LGTM
tag:easypr
Cc @swill

We need another code review.  How should I test this, does it have to be a manual test?

LGTM. Verified that a configuration entry is added with default 8 as pool size. Increased the default threadpool size, restarted MS and verified that when multiple prepareTemplate APIs are invoked required number of threads gets created.
INFO  [c.c.t.TemplateManagerImpl] (Template-Preloader-11:ctx-9cefa1ea) (logid:49186ba8) Start to preload template 201 into primary storage 2
INFO  [c.c.t.TemplateManagerImpl] (Template-Preloader-12:ctx-601679be) (logid:1ea23b56) Start to preload template 201 into primary storage 3

@swill This has the required LGTMs.

Thanks @koushik-das.  I will run this through CI just to be sure everything is good...  Thx.

CI RESULTS
Tests Run: 85
  Skipped: 0
   Failed: 3
   Errors: 0
 Duration: 6h 24m 57s

Summary of the problem(s):
FAIL: Test redundant router internals
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers_network_ops.py", line 483, in test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false
    "Attempt to retrieve google.com index page should be successful once rule is added!"
AssertionError: Attempt to retrieve google.com index page should be successful once rule is added!
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_GDLRM8/results.txt

FAIL: test_02_vpc_privategw_static_routes (integration.smoke.test_privategw_acl.TestPrivateGwACL)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 253, in test_02_vpc_privategw_static_routes
    self.performVPCTests(vpc_off)
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 324, in performVPCTests
    self.check_pvt_gw_connectivity(vm1, public_ip_1, vm2.nic[0].ipaddress)
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 559, in check_pvt_gw_connectivity
    "Ping to outside world from VM should be successful"
AssertionError: Ping to outside world from VM should be successful
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_GDLRM8/results.txt

FAIL: test_03_vpc_privategw_restart_vpc_cleanup (integration.smoke.test_privategw_acl.TestPrivateGwACL)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 265, in test_03_vpc_privategw_restart_vpc_cleanup
    self.performVPCTests(vpc_off, True)
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 331, in performVPCTests
    self.check_pvt_gw_connectivity(vm1, public_ip_1, vm2.nic[0].ipaddress)
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 559, in check_pvt_gw_connectivity
    "Ping to outside world from VM should be successful"
AssertionError: Ping to outside world from VM should be successful
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_GDLRM8/results.txt

Associated Uploads
/tmp/MarvinLogs/DeployDataCenter__May_10_2016_19_39_49_I0OP3U:

dc_entries.obj
failed_plus_exceptions.txt
runinfo.txt

/tmp/MarvinLogs/test_network_GDLRM8:

failed_plus_exceptions.txt
results.txt
runinfo.txt

/tmp/MarvinLogs/test_vpc_routers_WTWRQD:

failed_plus_exceptions.txt
results.txt
runinfo.txt

Uploads will be available until 2016-07-11 02:00:00 +0200 CEST
Comment created by upr comment.

These connectivity issues are unrelated to this PR.  I will merge this now...


Frozen when switch camera

When I switch camera it returns frozen
Also while streaming it sometimes returns frozen
Any ideas help me? Thanks

which return frozen? the LocalVideoStateChanged event?

I listener 'RemoteVideoStateChanged' to join view stream and return state VideoRemoteState.Frozen(=3)

does it recover normally finally?

then it's normal to watch but sometimes it's frozen even though I don't take any action
I don't want to return frozen because it will show black screen

Cloud you pls provide the SDK log? You can get more info from the comment on the setLogFile method.

using https://github.com/BeTomorrow/react-native-file-logger ???

No, our SDK log file.

seems when i setTimeout when frozen it doesn't show black screen

@phuocantd i wonder how to switch camera

@phuocantd i wonder how to switch camera

engine.switchCamera() nha


[1.7.10]Server Crash when lauching rocket

On a 1.7.10 server, we got a crash when a player tried to lauch his rocket when he reached space.
On the second try, same thing, except he made the server crash each time he tried to reconnect to the server.
For me, ressembles https://github.com/zmaster587/AdvancedRocketry/issues/720 ?
https://gist.github.com/Niuttuc/f836b31fa1b420525e7d30b4aacb3c07

Is this still a issue? Please comment if it is and i will reopen if if you are unable? We are closing old issues to see what is still relevant and needs to be fixed.


Add option to copy config variables between apps

When migrating an Application to another stack, Heroku's help page suggests to create a clone of that application in the new stack and test it. It is also required to copy the variables from that application.
Command:
heroku config:copy target_app --app source_app

How is it that with a different Ruby version the tests are failing this way?

Anyone?

apologies since this isn't really mentioned anywhere you would've likely seen it, but we're trying not to add any new functionality to this version of the toolbelt. We're working on the replacement here: https://github.com/heroku/heroku-cli

@dickeyxxx OK, got it, thanks for the heads up!


195 improving user management test coverage

This story adds a few tests to bring the test coverage for the User management related features .

Closed as I wanted to include more tests in this PR. Will reopen once that's done'


feat: Add support for EKS secondary cidr range

Description
Adds capability to a another subnet with NAT GW that can be used by EKS worker nodes for its secondary IP addresses
AWS
Motivation and Context
Provisioning EKS worker nodes on a /24 subnet will consume a lot of address space to address this AWS added support for secondary CIDR range for EKS.
Breaking Changes
No breaking change, this just add a new subnet resource named for EKS
How Has This Been Tested?

I have tested and validated these changes using one or more of the provided examples/eks-secondary-cidr projects
Using the example above I created a simple vpc first without the secondary cidr then added the secondary cidr range afterwards.

eks_secondary_cidr_test.log

I am not sure I understand the premise for this PR. You can already specify secondary_cidr_blocks to have a bigger VPC, and you can set CIDR larger than /24 in subnets.
I don't think we need to have just another type of subnets and related resources specifically for EKS.
Am I missing something?

hi, yes that is an option and we've used them before but I would like to have an option to also separate them especially when I need to run a lot of pods but can't use a subnet bigger than /24 on the primary/private subnet. Would you prefer to have this subnet   made or named as a custom subnet that can be reused for other purposes aside from EKS?

There is no need to make custom subnets (and related resources) in this module because it will be very complex to handle all the relations in the code. If you need to make extra resources, please handle them outside of the module.
Closing this issue.


Defining taxon with int or string of taxonomy ID gives different results

Hi,
I have been a very happy user of taxoniq for a while now, and I have just noticed a small behaviour discrepancy that may cause some problems down the line if one isn't careful about this.
When defining a Taxon using the NCBI taxonomy ID, one can specify it as an int or as a string:
>>> t_int = taxoniq.Taxon(3041)
>>> t_int
taxoniq.Taxon(3041)
>>> t_str = taxoniq.Taxon('3041')
>>> t_str
taxoniq.Taxon(3041)

However, after doing so, the type of the taxon's tax_id attribute isn't the same:
>>> t_int.tax_id
3041
>>> t_str.tax_id
'3041'

This typing difference is then passed on to methods of the taxoniq module, as you can see below:
>>> [t.tax_id for t in t_int.lineage]
[3041, 33090, 2759, 131567, 1]
>>> [t.tax_id for t in t_str.lineage]
['3041', 33090, 2759, 131567, 1]

It also means that two Taxon objects defined from the same NCBI taxID, but with two different types, cannot be directly compared:
>>> t_int == t_str
False

I don't know if that is intentional or not, and there may be reasons to have this behaviour, but I feel like it could cause some problems to any user who isn't too careful about typing in Python -- which is probably a significant amount of people! So I figured I should bring that up in case it hasn't been noticed before.
Anyway, thank you very much for an remarkably useful package :)
Best,
Duncan

Thank you for pointing this out. You are absolutely correct that the input needs to be normalized to avoid this. I will push out a patch shortly.


Remove Android hideStatusBar config

hideStatusBar configuration on Android implementation is wrong/incomplete and can interfere with useImmersiveMode.
My original plan was to work on our immersive mode support that I thought could be improved (and it can a bit but not that much) but where I've found more issues is with hideStatusBar.
This is what the official Android docs say about how to hide the status bar on different Android versions https://developer.android.com/training/system-ui/status.
Independently of what value we set hideStatusBar on our AndroidApplicationConfiguration, AndroidApplication init() method always hides the status bar using the FLAG_FULLSCREEN flag method described on the Android docs for Android < 16:
if (!isForView) {
			try {
				requestWindowFeature(Window.FEATURE_NO_TITLE);
			} catch (Exception ex) {
				log("AndroidApplication", "Content already displayed, cannot request FEATURE_NO_TITLE", ex);
			}
			getWindow().setFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN, WindowManager.LayoutParams.FLAG_FULLSCREEN);
			getWindow().clearFlags(WindowManager.LayoutParams.FLAG_FORCE_NOT_FULLSCREEN);
			setContentView(graphics.getView(), createLayoutParams());
		}

Our hideStatusBar() implementation does something similar to the Android >= 16 docs mechanism:
protected void hideStatusBar (boolean hide) {
		if (!hide) return;

		View rootView = getWindow().getDecorView();
		rootView.setSystemUiVisibility(0x1);
	}

First of all we are not setting the recommended flag  SYSTEM_UI_FLAG_FULLSCREEN but 0x1 which is SYSTEM_UI_FLAG_LOW_PROFILE (https://developer.android.com/reference/android/view/View#SYSTEM_UI_FLAG_LOW_PROFILE), not sure the reason for that but my guess is this is how it was done on legacy OS versions.
So, when tested, as expected, setting the hideStatusBar to false (default value) has no effect on Android < 16, the system bar never appears because we are ALWAYS setting the flags. The interesting bit is that it doesn't have an effect on newer versions either (tested Android 19 or Android 30) so it looks, for the moment there's backwards compatibility and the flgs are just enough to hide the status bar on all Android versions.
What happens if we make the lines that set the flags conditional to only run on Android < 16 and we test on newer Android versions by setting hideStatusBar to true expecting that system bars vibisibility is handled by hideStatusBar() setSystemUiVisibility implementation instead? A disaster, the status bar is all over the place. To properly handle system bar visibility using setSystemUiVisibility, as the docs indicate in the notes, we would need to do the kind of things we do with Immersive mode by listening to visibility change events. Even in that case, as we know from Immersive mode issues, there are cases in which the system bar would not hide properly on some weird scenarios (like closing the soft keyboard on some devices or combinations of volume key presses with other actions on Android 19 devices).
The other problem is that, even if hideStatusBar does nothing, if somebody sets it to true and also sets useImmersiveMode to true, hideStatusBar will clear the flags set by immersive mode on onWindowsFocusChange().
@Override
	public void onWindowFocusChanged (boolean hasFocus) {
		super.onWindowFocusChanged(hasFocus);
		useImmersiveMode(this.useImmersiveMode);
		hideStatusBar(this.hideStatusBar);

I think that even if it's a breaking change, in this case, considering it has not worked properly for a long time, it can lead to issues and nowadays we have immersive mode, the best we can do is get rid of it.
How to test? Easiest is running gdx-tests-android tests such as TextAreaTest.

I'm okay with this. I assumed hideStatusBar was set to true by default, since libGDX apps by default hide the status bar, but no, it's false. Misleading, and it should be covered by immersive mode anyway.
I'd like useImmersiveMode to be true by default - I don't think it's standard for games to display the navigation bar, though my device has physical buttons so I wouldn't necessarily know.

Yeah, we can consider that on an Immersive Mode related PR that includes some other improvements.

I'd also like a way to hide the navigation bar prior to KitKat. Think it was introduced in Honeycomb, but libGDX doesn't support that these days, so just Ice Cream Sandwich and Jelly Bean are affected.

That is a good point. I don't think there are many devices that don't have physical buttons (have a nav bar) and are on API < 19 but there may be some. Testing on a Nexus 4 with API 16 the navigation bar currently doesn't disappear when hideStatusBar is set to true but the icons become all dots (instead of typical triangle, circle and square). So removing it doesn't really change anything here.

I'm not doing anything regarding libGDX on Android at the moment, though I was working on a non-libGDX Android game in which I display the navigation and status bars in portrait mode but not in landscape mode. If you add any code, I'll give it a good look.

The idea is for the moment to clean up the stuff that is not working at all and later we can think on fixing/adding visibility related stuff.

Been messing about with an Ice Cream Sandwich emulator today. And Gingerbread - I cannot let it go! I think I was mistaken. While the navigation bar can be hidden in 3.0-4.3, it returns when the screen is tapped and stays until the app hides it again due to the lack of immersive mode support. So not very helpful outside of things like video playback and accelerometer-controlled games.


Callback on set date bugfix, general bugfix

Fixed a new bug:
it was impossible to pick August 31 from September view

Something seems odd here. Even though the release v1.0.20 seems to be merged into master. The list of release on git (and per consequence in bower) shows the latest as being 1.0.19 which still has a reference to lodash.  Can I help with something?

Well, I guess I had to commit my changes first first, and then increment the version. You live, you learn.  A new pull request with an updated version created.

Ahh cool, great. Thanks!


[ISSUE] Memory leak in VGSCollect

VGSCollect keeps an reference to text fields it is handling:
https://github.com/verygoodsecurity/vgs-collect-ios/blob/562cdb0b8312fabaa4626304d41a6124a685166a/Sources/VGSCollectSDK/Core/Collector/VGSCollect%2Binternal.swift#L15
VGSTextFields try to unregister on deinit:
https://github.com/verygoodsecurity/vgs-collect-ios/blob/fc9654578de50784d5d1f6d97930a33a6967b191/Sources/VGSCollectSDK/UIElements/Text Field/VGSTextField.swift#L122
But this never happens, because VGSCollect is holding a strong reference to the fields, so they will never be deinited. As a consquence, VGSCollect can not be reused since it keeps any VGSTextFields alive forever.
To fix this, there are two options:

Change this architecture. It is a bit questionable to keep an array of references around like this.

If this is not an option, the array needs to not hold strong references. In this case, it might be useful to use a weak reference wrapper like the following:
private struct WeakReference<T: AnyObject> {
weak var value: T?
init(_ value: T) { self.value = value }
}

And then change var elements = [VGSTextField]() to var elements = [WeakReference<VGSTextField>]().

Thank's for your findings @DagAgren . At the beginning there was idea to have one VGSCollect instance per ViewController so textfields live as long as VGSCollect instance. Also there were some cases when we should keep strong reference to textfields, since on sendData(_:) request VGSCollect grab the data directly from textfields. Anyway we will check if we can improve it.

In v1.7.1 we released functionality that allows to  unsubscribe VGSTextFields any time you need it, so you can use it as:
/// Unsubscribe single VGSTextField
vgsCollect.unsubscribeTextField(textField)

//// Unsubscribe all related VGSTextFields
vgsCollect.unsubscribeAllTextFields()

As mentioned before, there are use-case when data from VGSTextFields is collected on multiple screens(e.g. pop-up views) and should be send all together at one point. VGSCollect grabs the data from textfields just before sendData() request, that's why we need to keep strong references to fields. In case when VGSCollect instance is deinited, VGSTextFields will be deinited too(if no other strong references pointing to textfields).
In your case if you want to reuse VGSCollect instance, I would recommend to unsubscribe textfields manually when needed.


Update arcore to 1.26.0 + Update compileSdkVersion to 31

This PR updates some dependencies:

Update ARCore to 1.26.0
Update compileSdkVersion 31
Update targetSdkVersion 31

I guess we can close this PR. But anyway thx for your effort @inuko


Fixes: https://github.com/rollbar/rollbar-gem/issues/472

If there is every an error within the payload object itself, within delayed jobs, rollbar does not propagate that error, since delayed job fails to call the :invoke_job lifecycle hook and instead calls the :failure lifecycle hook.

Thanks @richvorp! @rokob can we get this merged and released?

There is still a potential for the error to not fire if https://github.com/richvorp/rollbar-gem/blob/delayed_job_failure_hook/lib/rollbar/plugins/delayed_job/plugin.rb#L48 check fails and the dj_threshold is higher than 0.
An alternative would be to make it always error with:
data = Rollbar::Delayed.build_job_data(job)
::Rollbar.scope(:request => data).error(job.last_error, :use_exception_level_filters => true) if job.last_error

instead of https://github.com/richvorp/rollbar-gem/blob/delayed_job_failure_hook/lib/rollbar/plugins/delayed_job/plugin.rb#L14
I can push that change if you guys agree.

@richvorp I think it would be ok to skip the report on that case if the number of attempts is less than the threshold, that would be the expected behavior, I guess.

The problem still remains that we will not report this issue if the threshold is greater than 0 because delayed_job will never retry if there is a deserialization error.

Let's merge this, and then make a separate issue for handling the threshold > 0 case.


killing notebook is unreliable

After I run notebook() in Julia and close the notebook, my Julia will be extremely slow.
I have no idea if this is caused by my improperly exiting notebook (I always use ctrl+c in the terminal to interrupt it).
The following error message pop-up when the notebook is interrupted:
ERROR: interrupt
in process_events at ./stream.jl:537
in wait at ./task.jl:273
in wait at ./task.jl:194
in stream_wait at ./stream.jl:263
in wait at ./process.jl:619
in success at process.jl:492
in notebook at /home/ryanli/.julia/v0.3/IJulia/src/IJulia.jl:177
in notebook at /home/ryanli/.julia/v0.3/IJulia/src/IJulia.jl:176

I think the background event-processing tasks are still running...

Right now, if you want to kill the notebook you should really just close Julia entirely; the notebook() command is not designed to be interruptable.  Possibly the problem here is due to the unreliability of ctrl-C in Julia when killing C code (see JuliaLang/julia#2622).
Maybe the right thing is for notebook() to fork a process and return a task object that can be stopped with stop_notebook().

Perhaps you want to add a detach() to that Cmd object? I don't know how you are interrupting the code currently

@vtjnash, people are just interrupting it with ctrl-c right now.

Oh. Yes, it should have a detach call then so that signals don't propagate to the child processes

But if you run detach, then even closing Julia will not kill it, which will be confusing for users (who will soon have dozens of ipython processes running).  Is there an intermediate choice?

True. Currently Julia workers kill themselves when they see a SIGPIPE. Can IPython do something similar?

I think IPython exits cleanly only on SIGINT or SIGTERM; see ipython/ipython#1609

@vtjnash , we changed julia processes to ignore SIGPIPE. But they do exit when the socket connected to the master process is closed, actually on any error in the the task blocking on a read from the master.

related - https://github.com/JuliaLang/julia/issues/9095

This still seems to be a problem on MacOS due to JuliaLang/julia#18146 ... the notebook() command ends up killing the wrong process.

Okay, the problem on my machine seems to be because (for historical reasons) my IJulia was running the notebook via ipython notebook.  When I reconfigured it to use jupyter notebook, the problem went away.   So, I'm going to close this as hopefully it is unlikely to affect people using a modern Jupyter version.
I still think that there should be a way to kill a whole process group, though.


Re-enable semver check

Let's see if they work well now...
r? @ghost

Waiting on upstream fix.

:umbrella: The latest upstream changes (presumably #1672) made this pull request unmergeable. Please resolve the merge conflicts.

Should be fixed in latest semververfork release. And we need some CI tweaks included in this, so let's merge.


Selected nodes do not move when dragged after selecting with Shift+Click or programaticaly.

What platform were you using when you found the bug?

React Flow version: 12.0.1
Browser and version: Arc, Chrome
OS and version: MacOS 14.5

Live code example
https://codesandbox.io/p/sandbox/react-flow-starter-ts-r69228
Describe the Bug
Selecting multiple nodes by using Shift+Click or by programmatically changing the selected state does not create a "selection box" and most importantly does not trigger onSelectionDrag when trying to move the nodes (only the node under the cursor moves).
When holding Shift and dragging to select we get the expected behavior, we visually see a selection box and onSelectionDrag is called when dragging any of the nodes.
Steps to reproduce the bug or issue

Go to any flow with multiple nodes
Left click on a node to select it
Use Shift+Click on another node to select it
Drag one of the nodes

Expected behavior
As a user, I expect all of the selected nodes to move but instead only the node under the cursor moves.
As a user, I expect onSelectionDrag to be called but instead only onNodeDrag for the node under the cursor is called.
As a user, I expect a selection box to appear around all of the nodes that I selected, but no selection box appears.
Screenshots or Videos
https://github.com/user-attachments/assets/b22307a3-f938-4da7-84ef-417433961b2e
Additional context
In our codebase, we have bound a Ctrl-A keyboard shortcut to select all nodes, which sets their selected attribute to true. This correctly sets their individual selected styling but does not display the selection box and does not allow selection drag.

I agree that this would be the better UX. We will discuss it with the team and see what we can do about this.

@moklick do you have any updates? :)