The sfml_common.build arrangement will stop working in build2 0.15.0

The sfml_common.build file is sourced from root.build of various libraries. This will stop working without extra arrangements once 0.15.0 is released. For background and what those extra arrangements would be, see: https://build2.org/stage/bpkg/doc/build2-package-manager-manual.xhtml#package-skeleton
Also I noticed that this file referenced config.sfml.platform which is not defined anywhere and seems to be some left-over from previous attempts.

Thanks, working on it :+1:

I listed the additional sourced build files in the manifest file using the build-file keyword. Since I wanted to specify multiple files, I just used the keyword twice (similar to the depends keyword). Is there anyway that I can check if the buildfiles are correctly recognized by build2?

Is there any way how I can check if the buildfiles are correctly recognized by build2?

Just submit it to CI (stage for now) -- we force loading of each submitted package as a skeleton. You can even verify this by intentionally breaking something (e.g., comment out one build-file), submit, and see what happens.

Seems to be working in this regard, thanks :+1:


RangeError: Adding different instances of a keyed plugin (plugin$)

Describe the bug
after upgrading from 3.1.10 to 3.2.0 I have this error in my console and the editor doesn't work.
RangeError: Adding different instances of a keyed plugin (plugin$)
Desktop (please complete the following information):

OS: macOS
Browser Safari
Version 15.5

Upgrade
yarn upgrade @toast-ui/editor --latest
yarn upgrade v1.22.19
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
[4/5] 🔗  Linking dependencies...
...some unrelated warnings...
[5/5] 🔨  Rebuilding all packages...
success Saved lockfile.
success Saved 6 new dependencies.
info Direct dependencies
└─<EMAIL_ADDRESS>info All dependencies
├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>└─<EMAIL_ADDRESS>✨  Done in 2.74s.

Additional context
        const editor = new Editor({
            el: document.querySelector(`#${markdownEditorId}`),
            height: editor_height+'px',
            initialEditType: 'markdown',
            toolbarItems: [
                ['heading', 'bold', 'italic'],
                ['ul', 'ol', 'indent', 'outdent'],
                ['link']
            ],
            initialValue: this.value,
            hideModeSwitch: true,
            previewStyle: 'tab',
            autofocus: false,
            usageStatistics: false,
            events: {
                blur: function () {
                    document.querySelector(`#${textareaId}`).value = editor.getMarkdown();
                }
            }
        });

@craigh
In my tests of a install of the Editor package, the problem you mentioned did not occur. Does the same problem occur even if I delete the package and reinstall it?

sorry to bother you. I can't reproduce it.


Error 500 on competitions with keys

When trying to reach a competition with key e.g.
https://www.codabench.org/competitions/787/?secret_key=f21e43be-c0a4-4fa3-862e-f3ac58915257
we get an error 500 if we are not already logged in.
It should ask us for logging in and redirect to the right page.

On my side I get a 404 error using this URL

Fixed by #845 anyway


Convert imports using .less extension to .scss

I dunno why I never seem to see notifications on Github. In any case, thanks so much @bitfyre!


/lp crash

Description

I get kicked from the server when I type /lp, /luckperms etc.
Reproduction steps

Type /lp or /luckperms in chat then hit space

Expected behaviour

User will get kicked
Environment details

Server type/version: Paper 1.16.4 with BungeeCord
LuckPerms version: Latest, just tried changing it to the lastest version

https://prnt.sc/10cdvbm
Any other relevant details

This happened for the first time after adding the server to a BungeeCord Network.

Insatlling ViaVersion and ViaBackwards seems to have fixed the issue?
Running mc on 1.16.4 client and server on 1.16.5

It would be useful if you could either provide the crash log from your client, or be more specific about what version of LuckPerms you are using. "Latest" could refer to various versions depending on where you download from.

It would be useful if you could either provide the crash log from your client, or be more specific about what version of LuckPerms you are using. "Latest" could refer to various versions depending on where you download from.

Found out it was another plugin causing it.


Added support for Samsung Monitors that support the SmartThings API

Some Samsung monitors act as regular Samsung TVs, like the Samsung G7. This adds support for these monitor types so they appear in the available TV list when adding a new device in HomeAssistant in the integration prompt.

I'm not sure if the DEVICE_TYPE_NAMES value for the Samsung Smart Monitors is the same for all monitors. This is just the value I got from my Samsung G7 I just bought.


[Feature request] Zip file with password

Hi,
Codeunit 425 "Data Compression" does not have implemented functionality to create zip file with password.
Zip file with password could be used to send personal information reports, password adds additional personal information security, when sending via email.

For the new features please submit a product suggestion on https://aka.ms/bcideas

For the new features please submit a product suggestion on https://aka.ms/bcideas


US975143: release prep

https://internal.almoctane.com/ui/entity-navigation?p=131002/6001&entityType=work_item&id=975143

A developer build has not yet been created for this branch. Click here to go ahead and create the build...

CI Build Link:
https://sou-jenkins2.swinfra.net/job/FileAnalysisSuite/job/FileAnalysisSuite~adaptersdk-schema~US975143~CI


fix: check if reserve is configured

Checklist

[x] I have read the coding guide.
[ ] My change requires a documentation update, and I have done it.
[ ] I have added tests to cover my changes.
[ ] I have filled out the description and linked the related issues.

Description
Check if reserve is configured before attempting to put chunk
Related Issue (Optional)
#4829

this is not a real solution, i think. we need to first understand why the reserve is nil. Chances are this is a light node and it was unable to find a peer to push the chunk to so it tried storing it. In that case, we need to plug that hole, where a light node should not try to store a chunk in the above scenario. but this is one theory. we need to ask the issue creator the config options he was running with before hastily jumping onto a solution.

I also got this from this failed beekeeper test
[pod/bootnode-0-0/bee] "time"="2024-10-21 06:07:39.750144" "level"="debug" "logger"="node/pusher" "v"=1 "msg"="chunk stays here, i'm the closest node" "chunk_address"="d43711cd5b3436c09ef09cb4e554eba026719af857220febc41f1db9fa311602"
[pod/bootnode-0-0/bee] panic: runtime error: invalid memory address or nil pointer dereference
[pod/bootnode-0-0/bee] [signal SIGSEGV: segmentation violation code=0x1 addr=0x50 pc=0xf33756]
[pod/bootnode-0-0/bee]
[pod/bootnode-0-0/bee] goroutine 2528 [running]:
[pod/bootnode-0-0/bee] github.com/ethersphere/bee/v2/pkg/storer/internal/reserve.(*Reserve).Put(0x0, {0x1a55ca0, 0xc0043c9470}, {0x1a64ba0, 0xc004684870})
[pod/bootnode-0-0/bee] 	github.com/ethersphere/bee/v2/pkg/storer/internal/reserve/reserve.go:104 +0x76
[pod/bootnode-0-0/bee] github.com/ethersphere/bee/v2/pkg/storer.(*DB).ReservePutter.func1({0x1a55ca0?, 0xc0043c9470?}, {0x1a64ba0, 0xc004684870})
[pod/bootnode-0-0/bee] 	github.com/ethersphere/bee/v2/pkg/storer/reserve.go:300 +0x53
[pod/bootnode-0-0/bee] github.com/ethersphere/bee/v2/pkg/storage.PutterFunc.Put(0x4ed33c?, {0x1a55ca0?, 0xc0043c9470?}, {0x1a64ba0?, 0xc004684870?})
[pod/bootnode-0-0/bee] 	github.com/ethersphere/bee/v2/pkg/storage/chunkstore.go:56 +0x37
[pod/bootnode-0-0/bee] github.com/ethersphere/bee/v2/pkg/storer.putterWithMetrics.Put({{0x1a486c0, 0xc003b07470}, {{0xc0008c74d0}, {0xc0008c7560}, {0x1a641a8, 0xc0008ec340}, {0x1a641a8, 0xc0008ec3c0}, {0x1a5bf18, 0xc0008f8240}, ...}, ...}, ...)
[pod/bootnode-0-0/bee] 	github.com/ethersphere/bee/v2/pkg/storer/metrics.go:181 +0xb4
[pod/bootnode-0-0/bee] github.com/ethersphere/bee/v2/pkg/pusher.(*Service).pushDirect(0xc0008e84e0, {0x1a55ca0, 0xc0043c9470}, {0x1a64008, 0xc00137c730}, 0xc0043c9440)
[pod/bootnode-0-0/bee] 	github.com/ethersphere/bee/v2/pkg/pusher/pusher.go:321 +0x372
[pod/bootnode-0-0/bee] github.com/ethersphere/bee/v2/pkg/pusher.(*Service).chunksWorker.func2(0xc0043c9440)
[pod/bootnode-0-0/bee] 	github.com/ethersphere/bee/v2/pkg/pusher/pusher.go:161 +0x1f4
[pod/bootnode-0-0/bee] created by github.com/ethersphere/bee/v2/pkg/pusher.(*Service).chunksWorker in goroutine 300
[pod/bootnode-0-0/bee] 	github.com/ethersphere/bee/v2/pkg/pusher/pusher.go:230 +0x619

Config

full node mode: true
bootnode-mode: true

The reverse is not configured because
https://github.com/ethersphere/bee/blob/0e42d83eecfbeaa764ee8004ea402b78b8293147/pkg/node/node.go#L730
But the pushsync only uses o.fullNodeMode
https://github.com/ethersphere/bee/blob/0e42d83eecfbeaa764ee8004ea402b78b8293147/pkg/node/node.go#L953
https://github.com/ethersphere/bee/blob/0e42d83eecfbeaa764ee8004ea402b78b8293147/pkg/pushsync/pushsync.go#L401-L406
So initializing pushsync consistently with o.FullNodeMode && !o.BootnodeMode should fix it

does that mean that an upload was attempted from a bootnode?

does that mean that an upload was attempted from a bootnode?

yes. See https://github.com/ethersphere/bee/actions/runs/11434065514/job/31807011143
msg="soc: submitting soc chunk xx to node bootnode-0"

Please can you confirm that the reserve is not used in earlier places?

I don't see any other place. The stack trace indicates that the receiver is nil.
(*Reserve).Put(0x0,....)


[camel-main] Groovy support causes CI failure

Fix of https://github.com/apache/camel-quarkus/issues/1746 probably caused failures on CI.
I'm attaching a log from the CI execution, where details can be seen.
groovy-group-10-test-failure.txt

@essobedo FYI ^^^

@essobedo I can confirm, that CAMEL-19220 fixes the issue. Thanks!


Hardlink create do not support  relative path

example:
when i am in ~\documents\testpath1
this command New-Item -Path testfile1 -Type HardLink -Value ..\testpath2\testfile2 will report with error
file tree is like this
+---testpath1
|   +---testfile1
+---testpath2
|   +---testfile2

@1349422030 did you resolve the issue? I experienced this as well on PowerShell 7.0.3, trying to create a hardlink with relative path did not work outside of the directory that PowerShell was installed to.

No, I didn't.
My temporary resolve is to use resolve-path command to transfer relative path to obsolute path
-------- 原始邮件 --------
发件人： Michael Li<EMAIL_ADDRESS>日期： 2020年9月26日周六 清晨6:17
收件人： PowerShell/PowerShell<EMAIL_ADDRESS>抄送：<PHONE_NUMBER><EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>主 题： Re: [PowerShell/PowerShell] Hardlink create do not support relative path (#12922)
@1349422030https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F1349422030&data=02|01||042a87ec20e247e304c508d861a0ba36|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637366690225830769&sdata=CuTjsg7jMuCicl1BIGOwc0tgLj49aOBAM2AWYpFmpGQ%3D&reserved=0 did you resolve the issue? I experienced this as well on PowerShell 7.0.3, trying to create a hardlink with relative path did not work outside of the directory that PowerShell was installed to.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShell%2Fissues%2F12922%23issuecomment-699182917&data=02|01||042a87ec20e247e304c508d861a0ba36|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637366690225840765&sdata=Kop2O60JT0Io4yr54Bl6%2BlQBVtHcVoU3lXkpwG19pFg%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAIM653OZI2NKSYRQNWD7S7TSHUJF3ANCNFSM4NZAW5HQ&data=02|01||042a87ec20e247e304c508d861a0ba36|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637366690225840765&sdata=gH5LIIRC0CMl%2FT8pLIzAPecdPNqoKmkLmHhwaE5p0F4%3D&reserved=0.

Right, I tested as well that finding and using the absolute path works.
I think you should still reopen this issue so that the PowerShell team can be made aware of it and make a fix 😃


Eorror

when i run the code：python main.py --config configs/text.yaml prompt="a photo of an icecream" save_path=icecream

Hi there,
I also faced this issue.
Did you solved it?
Could you pls share me?
Thanks in many <3


Try to output messages without adding to the message history

When messages are echoed to show what went wrong at the cursor, those messages are added to the message history. We should try and output the messages without adding to the message history.

After some investigation, nothing can be done about this. If you don't want messages to appear in your history, you'll have to disable the messages with let g:ale_echo_cursor = 0.
You can echo messages with :echo, but then you cannot truncate long messages with shortmess. If you echo messages that ought to be truncated, they will flash on the screen and then disappear almost immediately. Then you can't see the full message in the history.

How about this:
" Notice the double quotes
let msg = "augroup init.vim\n
\     au!\n
\     au ColorScheme * call core#colors()\n
\     au FileType * set syntax=ON\n
\     au FilterWritePre * if &diff | set syntax=OFF | endif\n
\     au VimLeavePre * call core#tabdo('cclose')\n
\     au VimLeavePre * call core#tabdo('lclose')\n
\     au CmdwinEnter * map <silent> <buffer> <C-G> <C-C><C-C>\n
\ augroup END"

let cmdheight_save = &cmdheight
let &cmdheight = len(split(msg, '\n'))
echo msg

" Later on, on CursorMoved
let &cmdheight = cmdheight_save

The cmdheight dance is to prevent the Press ENTER... prompt.

Nah, that looks too complicated. That will probably slow things down quite a bit.


Fix policy compatibility for well-known deployments such as kube-dns and etcd-operator

Make Cilium aware of kube-dns and the etcd-operator used for managed Kubernetes
instead of requiring the user to assign fixed identities. This guarantees that
existing label based kube-dns network policies continue working even in this
new deployment mode. Previously, kube-dns would change its security relevant
labels to reserved:kube-dns
Fixes: #5529
Fixes: #5791

This change is

test-me-please

@tgraf tests are passing :tada:

test-me-please

test-missed-k8s

@tgraf tests failed in the upgrade, check my reply in https://github.com/cilium/cilium/pull/5844#discussion_r223854384 to see if it fixes.
21:11:32 cmd: kubectl exec -n kube-system cilium-86mdw -- cilium endpoint list
21:11:32 Exitcode: 0
21:11:32 Stdout:
21:11:32  	 ENDPOINT   POLICY (ingress)   POLICY (egress)   IDENTITY   LABELS (source:key[=value])                          IPv6                   IPv4          STATUS
21:11:32 	            ENFORCEMENT        ENFORCEMENT
21:11:32 	 15679      Disabled           Disabled          4          reserved:health                                      f00d::a0a:100:0:3d3f   <IP_ADDRESS>    ready
21:11:32 	 42607      Disabled           Disabled          5          k8s:io.cilium.k8s.policy.serviceaccount=kube-dns     f00d::a0a:100:0:a66f   <IP_ADDRESS>    restoring
21:11:32 	                                                            k8s:io.kubernetes.pod.namespace=kube-system
21:11:32 	                                                            k8s:k8s-app=kube-dns
21:11:32 	 55017      Disabled           Disabled          5          k8s:io.cilium.k8s.policy.serviceaccount=microscope   f00d::a0a:100:0:d6e9   <IP_ADDRESS>   restoring
21:11:32 	                                                            k8s:io.kubernetes.pod.namespace=kube-system
21:11:32 	                                                            k8s:k8s-app=microscope

Where's the cluster identity label?
It seems that

test-me-please

test-missed-k8s

@aanm Unfortunately, the upgrade is not that simple. 1.2 will need the fixed-identity label annotations.

@aanm Unfortunately, the upgrade is not that simple. 1.2 will need the fixed-identity label annotations.

It doesn't hurt to re add them in kube-dns

We need to revert those changes, the fixed identity annotation needs to stay in the descriptors.

That breaks well-known identities as the labels need to match exactly. We could ignore the fixed-identity labels when selecting well-known identities but that is potentially very confusing as we should allow a user to assign a fixed identity at all times. It would also break upgrades for existing fixed identity users.
I think we will have to annotate the pod labels on the fly before downgrading and then removing the labels again as we go back.

test-me-please

@aanm I have included your patches.

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

Minor nit, It'll be great if this PR could enable the following test:
Validate toEntities World
Validate toEntities Cluster
So, can be sure that all is ok in the future.

test-me-please

test-me-please

there's something wrong with jenkins
/home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:383
etcd-operator is not ready after timeout on cilium v1.2
Expected
    <*errors.errorString | 0xc42040aa30>: {
        s: "Timeout reached: timed out waiting for pods with filter -l name=etcd-operator to be ready",
    }
to be nil
/home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/k8sT/Updates.go:155

$ sed '155q;d' test/k8sT/Updates.go
                ExpectWithOffset(1, microscopeErr).To(BeNil(), "Microscope cannot be started")

test-me-please

The problem is this:
STEP: Waiting etcd-operator is ready
time="2018-10-13T10:20:11Z" level=debug msg="running command: kubectl -n kube-system get pods -l name=etcd-operator -o json"
cmd: "kubectl -n kube-system get pods -l name=etcd-operator -o json" exitCode: 0 duration: 110.891453ms stdout:
{
    "apiVersion": "v1",
    "items": [],
    "kind": "List",
    "metadata": {
        "resourceVersion": "",
        "selfLink": ""
    }
}

Which would make sense given this PR changes the label of the etcd-operator but I can't find the code which actually checks the readiness.

I'm creating a new PR. Jenkins is clearly not running the latest code of this branch.

Superseded by #5881


Onivim2 won't launch on MacOS via the Dock

I have installed
Version: 0.5.1-nightly
Date: 2020-11-01T04:43:58.038Z
Commit: 28e55c7a
And when I click Onivim2 in the Dock, it bounces for a couple of minutes and eventually stops, right clicking on the icon says "Application not responding" and I have to force quit.
Since I added Onivim2 to the system path from the previous 0.5.0 version, I am able to run oni2 from the terminal and then the window opens as expected and I am able to use the program.
I am on macOS Version 10.15.7 (19H2)

Thanks for reporting the issue, @dane-harnett !

Since I added Onivim2 to the system path from the previous 0.5.0 version, I am able to run oni2 from the terminal and then the window opens as expected and I am able to use the program.

Glad you have this workaround.
I suspect this is a regression from this PR: https://github.com/onivim/oni2/pull/2634 - it sounds like the shell process we are running is hanging when we try and query for the environment. I need to revisit to see a more robust approach.
I wasn't able to reproduce, though - just curious, do you have any customizations to your terminal shell?

I am using iTerm2 and oh-my-zsh

I also have an ssh-agent add command in my .zshrc which requires a passphrase

Ah i removed the following from my .zshrc and Onivim2 launches as expected!
ssh-agent | source /dev/stdin
ssh-add ~/.ssh/id_rsa

Oh, thanks @dane-harnett - that's very helpful! That explains why I couldn't reproduce :+1:
Cool, we should certainly be more robust in that case - definitely shouldn't hang for scripts like that

This should be fixed now with #2670 - stdin is now closed when we try and spin up a terminal to inspect the environment, so shouldn't hang anymore


Add lint for a link reference without a corresponding link definition (or vice versa)

Often (especially when refactoring) links using the definition/reference style will get broken. It would be useful for markdownlint to catch this.
Two examples are:
Link Ref without Def
See [Docs][] for more info.

<!-- Should have a link definition below like:
[docs]: https://example.com
-->

Link Def without Ref
See [New Docs][] for more info.

<!-- None of the link definitions match the link reference above. -->
[docs]: https://example.com

Yes, agreed with this completely. A friend and I were working on a small standalone Markdown linter for writing purposes and this was actually our first feature! So strange that it's not in there.

@jasonsnell, I think I listen to your podcasts sometimes. :) Yes, there is a set of link-based rules in the queue I just haven't got to yet.

I usually use https://www.npmjs.com/package/markdown-link-check since when you start to link check outside of the same document, you need to have a concept of a layout and replacements

Just tried markdown-link-check with the snippets from above:
echo 'See [Docs][] for more info.

<!-- Should have a link definition below like:
[docs]: https://example.com
-->' > ref_without_def.md
docker run -v ${PWD}:/tmp:ro --rm -i ghcr.io/tcort/markdown-link-check:stable /tmp/ref_without_def.md

echo 'See [New Docs][] for more info.

<!-- None of the link definitions match the link reference above. -->
[docs]: https://example.com' > def_without_ref.md
docker run -v ${PWD}:/tmp:ro --rm -i ghcr.io/tcort/markdown-link-check:stable /tmp/def_without_ref.md

Output:
FILE: /tmp/ref_without_def.md
  No hyperlinks found!

  0 links checked.

FILE: /tmp/def_without_ref.md
  No hyperlinks found!

  0 links checked.

so doesn't actually seem like it catches this case, possibly because it considers having extra refs/defs to be an okay thing to do (whereas for me it's nearly always copy-pasta, or someone forgetting how the defs/refs actually work.

Right, I missread this, but it looks like a duplicate of https://github.com/DavidAnson/markdownlint/issues/144

Agree, I'll probably try to add this for the next (not pending) release.

Here is the remark-lint version of this rule https://github.com/remarkjs/remark-lint/tree/main/packages/remark-lint-no-undefined-references to see if they have any edge case code that might be needed

FWIW, speaking as a professional writer who writes exclusively in markdown, forgetting a link reference either way happens way more than you'd think!

On Dec 24, 2021, at 3:15 AM, Gibson Fahnestock @.***> wrote:

Just tried markdown-link-check with the snippets from above:
echo 'See [Docs][] for more info.
' > ref_without_def.md
docker run -v ${PWD}:/tmp:ro --rm -i ghcr.io/tcort/markdown-link-check:stable /tmp/ref_without_def.md
echo 'See [New Docs][] for more info.

[docs]: https://example.com' > def_without_ref.md
docker run -v ${PWD}:/tmp:ro --rm -i ghcr.io/tcort/markdown-link-check:stable /tmp/def_without_ref.md
Output:
FILE: /tmp/ref_without_def.md
No hyperlinks found!
0 links checked.
FILE: /tmp/def_without_ref.md
No hyperlinks found!
0 links checked.
so doesn't actually seem like it catches this case, possibly because it considers having extra refs/defs to be an okay thing to do (whereas for me it's nearly always copy-pasta, or someone forgetting how the defs/refs actually work.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.

Right, I missread this, but it looks like a duplicate of #144

Ahh, good point, failed to find that in the issue search.

Two new rules will be available in the next release of the library:

https://github.com/DavidAnson/markdownlint/blob/next/doc/Rules.md#md052
https://github.com/DavidAnson/markdownlint/blob/next/doc/Rules.md#md053

They will report errors for:

Link and image references missing a label
Link/image reference definitions that are unused
Link/image reference definitions that are duplicated

The latter two scenarios can be automatically fixed by the library (by deleting the unneeded reference definition).
/cc @jasonsnell

@jasonsnell Hopefully the idea of a Markdown linter does not offend him too much.

He's working on a little one of his own for person writing use, much less comprehensive than this one. I think he likes the idea! But I don't want to speak for him.

@DavidAnson could there be an option for MD052 to force checking in shortcut link syntax? It could default to false, but in my case markdownlint was missing a reference-type link with an undefined target because of this, and I'd like to set up a check to avoid that in the future.
Happy to open a separate issue if that's preferred.

@waldyrious See #845

@DavidAnson thanks for the pointer. I read the discussion and code in the PR and maybe I'm missing something, but it seems to be about enforcing the inline-vs-reference link style, rather than enforcing that, for reference-style links, the shortcut type may not be used.
Additionally, there seem to be different notions of what a shortcut-type reference link means. In the relevant commit from that PR, it seems to be [foo][], whereas in Rules.md (across the entire file, but especially in the MD052 section) it seems to be understood as just [foo]. For clarity, I am interested in an option to make MD0052 process the latter the same way it processes the former.

Per the specification at https://spec.commonmark.org/0.30/#links:

There are three kinds of reference links: full, collapsed, and shortcut.

I try to be accurate when referring to this, but may have made a mistake somewhere in the documentation.
You are right that the issue I linked to focuses more on in line styles. You may be asking for a similar rule for the different kinds of reference link.

Please open a new issue for a new rule to specify which types of reference links to allow. Thank you!

Ah, I see. So the [foo][] syntax is called "collapsed", not "shortcut". That's good to know, thanks!
I'll open a new issue.

Btw, responding more directly to the suggestion of

a new rule to specify which types of reference links to allow

I do agree it might be a good addition to the upcoming MD054/link-style rule to have an option to specify whether reference links should use shortcut, collapsed or full syntax. Such an option would not be my preferred resolution for the issue I had with shortcut-style reference links (which is why I made a slightly different request in #915), but I'm happy to open a separate issue for the option to customize MD054/link-style once #845 is merged. Does that sound OK?

I'd suggest proposing a new reference link style rule as a different rule because MD054 already feels tricky enough.


Replace last scalameter bench with jmh

My motivation was more to shed a dependency than performance tuning, but as long as we're here:
[info] Benchmark                 (size)  Mode  Cnt    Score     Error  Units
[info] HttpHeadersBench.add           2  avgt    3    0.277 ±   0.927  us/op
[info] HttpHeadersBench.add           4  avgt    3    0.810 ±   0.852  us/op
[info] HttpHeadersBench.add           8  avgt    3    2.862 ±   0.707  us/op
[info] HttpHeadersBench.add          16  avgt    3    8.511 ±   4.421  us/op
[info] HttpHeadersBench.add          32  avgt    3   33.616 ±  10.187  us/op
[info] HttpHeadersBench.add          64  avgt    3  137.177 ± 107.559  us/op
[info] HttpHeadersBench.apply         2  avgt    3    0.061 ±   0.050  us/op
[info] HttpHeadersBench.apply         4  avgt    3    0.085 ±   0.025  us/op
[info] HttpHeadersBench.apply         8  avgt    3    0.143 ±   0.121  us/op
[info] HttpHeadersBench.apply        16  avgt    3    0.274 ±   0.893  us/op
[info] HttpHeadersBench.apply        32  avgt    3    0.526 ±   2.076  us/op
[info] HttpHeadersBench.apply        64  avgt    3    1.029 ±   4.048  us/op
[info] HttpHeadersBench.replace       2  avgt    3    0.193 ±   0.083  us/op
[info] HttpHeadersBench.replace       4  avgt    3    0.332 ±   0.106  us/op
[info] HttpHeadersBench.replace       8  avgt    3    0.667 ±   0.206  us/op
[info] HttpHeadersBench.replace      16  avgt    3    1.093 ±   0.100  us/op
[info] HttpHeadersBench.replace      32  avgt    3    2.299 ±   1.406  us/op
[info] HttpHeadersBench.replace      64  avgt    3    4.288 ±   3.832  us/op

:+1: This looks good to me. Travis failure looks to be caused by mima https://github.com/typesafehub/migration-manager/issues/112; looks like its not a 2.11.x specific issue.


Provide a way to silence the warning about max_early_data

The warning about early data is printed even if early data is disabled, and there is no way to silence the warning.

[approve ci]

[approve ci]

Cherry-picked to v10.0.x


User feedback

The map has been highly useful to quickly add missing turn restrictions from Mapillary. There is significant time saved by avoiding the use of JOSM. Requests:

A method to add a marker to the map indicating the location has been reviewed - added, redundant, false positive
Navigation controls to reorient the map if rotated
Integration of mapillary-js for interactive photo browsing

cc @kepta


OAuth token refresh error

When a token expires and tries to get refreshed Superset throws errors until the user logs out and back in:

2023-07-06 15:26:23 2023-07-06 19:26:23,404:ERROR:superset.views.base:invalid_grant:
2023-07-06 15:26:23 Traceback (most recent call last):
2023-07-06 15:26:23   File "/usr/local/lib/python3.8/site-packages/flask/app.py", line 1516, in full_dispatch_request
2023-07-06 15:26:23     rv = self.dispatch_request()
2023-07-06 15:26:23   File "/usr/local/lib/python3.8/site-packages/flask/app.py", line 1502, in dispatch_request
2023-07-06 15:26:23     return self.ensure_sync(self.view_functions[rule.endpoint])(**req.view_args)
2023-07-06 15:26:23   File "/usr/local/lib/python3.8/site-packages/flask_appbuilder/security/decorators.py", line 89, in wraps
2023-07-06 15:26:23     return f(self, *args, **kwargs)
2023-07-06 15:26:23   File "/app/superset/views/base_api.py", line 113, in wraps
2023-07-06 15:26:23     raise ex
2023-07-06 15:26:23   File "/app/superset/views/base_api.py", line 110, in wraps
2023-07-06 15:26:23     duration, response = time_function(f, self, *args, **kwargs)
2023-07-06 15:26:23   File "/app/superset/utils/core.py", line 1524, in time_function
2023-07-06 15:26:23     response = func(*args, **kwargs)
2023-07-06 15:26:23   File "/app/superset/utils/log.py", line 245, in wrapper
2023-07-06 15:26:23     value = f(*args, **kwargs)
2023-07-06 15:26:23   File "/app/superset/charts/data/api.py", line 244, in data
2023-07-06 15:26:23     return self._get_data_response(
2023-07-06 15:26:23   File "/app/superset/charts/data/api.py", line 390, in _get_data_response
2023-07-06 15:26:23     result = command.run(force_cached=force_cached)
2023-07-06 15:26:23   File "/app/superset/charts/data/commands/get_data_command.py", line 43, in run
2023-07-06 15:26:23     payload = self._query_context.get_payload(
2023-07-06 15:26:23   File "/app/superset/common/query_context.py", line 100, in get_payload
2023-07-06 15:26:23     return self._processor.get_payload(cache_query_context, force_cached)
2023-07-06 15:26:23   File "/app/superset/common/query_context_processor.py", line 386, in get_payload
2023-07-06 15:26:23     query_results = [
2023-07-06 15:26:23   File "/app/superset/common/query_context_processor.py", line 387, in <listcomp>
2023-07-06 15:26:23     get_query_results(
2023-07-06 15:26:23   File "/app/superset/common/query_actions.py", line 200, in get_query_results
2023-07-06 15:26:23     return result_func(query_context, query_obj, force_cached)
2023-07-06 15:26:23   File "/app/superset/common/query_actions.py", line 104, in _get_full
2023-07-06 15:26:23     payload = query_context.get_df_payload(query_obj, force_cached=force_cached)
2023-07-06 15:26:23   File "/app/superset/common/query_context.py", line 121, in get_df_payload
2023-07-06 15:26:23     return self._processor.get_df_payload(query_obj, force_cached)
2023-07-06 15:26:23   File "/app/superset/common/query_context_processor.py", line 100, in get_df_payload
2023-07-06 15:26:23     cache_key = self.query_cache_key(query_obj)
2023-07-06 15:26:23   File "/app/superset/common/query_context_processor.py", line 163, in query_cache_key
2023-07-06 15:26:23     extra_cache_keys = datasource.get_extra_cache_keys(query_obj.to_dict())
2023-07-06 15:26:23   File "/app/superset/connectors/sqla/models.py", line 2092, in get_extra_cache_keys
2023-07-06 15:26:23     sqla_query = self.get_sqla_query(**query_obj)
2023-07-06 15:26:23   File "/app/superset/connectors/sqla/models.py", line 1630, in get_sqla_query
2023-07-06 15:26:23     where_clause_and += self.get_sqla_row_level_filters(template_processor)
2023-07-06 15:26:23   File "/app/superset/connectors/sqla/models.py", line 1190, in get_sqla_row_level_filters
2023-07-06 15:26:23     f"({template_processor.process_template(filter_.clause)})"
2023-07-06 15:26:23   File "/app/superset/jinja_context.py", line 474, in process_template
2023-07-06 15:26:23     return template.render(context)
2023-07-06 15:26:23   File "/usr/local/lib/python3.8/site-packages/jinja2/environment.py", line 1291, in render
2023-07-06 15:26:23     self.environment.handle_exception()
2023-07-06 15:26:23   File "/usr/local/lib/python3.8/site-packages/jinja2/environment.py", line 925, in handle_exception
2023-07-06 15:26:23     raise rewrite_traceback_stack(source=source)
2023-07-06 15:26:23   File "<template>", line 1, in top-level template code
2023-07-06 15:26:23   File "/usr/local/lib/python3.8/site-packages/jinja2/sandbox.py", line 393, in call
2023-07-06 15:26:23     return __context.call(__obj, *args, **kwargs)
2023-07-06 15:26:23   File "/app/pythonpath/openedx_jinja_filters.py", line 32, in can_view_courses
2023-07-06 15:26:23     courses = security_manager.get_courses(username)
2023-07-06 15:26:23   File "/app/superset/utils/memoized.py", line 50, in __call__
2023-07-06 15:26:23     value = self.func(*args, **kwargs)
2023-07-06 15:26:23   File "/app/pythonpath/openedx_sso_security_manager.py", line 130, in get_courses
2023-07-06 15:26:23     response = oauth_remote.get(url, token=token).json()
2023-07-06 15:26:23   File "/usr/local/lib/python3.8/site-packages/authlib/integrations/base_client/sync_app.py", line 29, in get
2023-07-06 15:26:23     return self.request('GET', url, **kwargs)
2023-07-06 15:26:23   File "/usr/local/lib/python3.8/site-packages/authlib/integrations/base_client/sync_app.py", line 289, in request
2023-07-06 15:26:23     return self._send_token_request(session, method, url, token, kwargs)
2023-07-06 15:26:23   File "/usr/local/lib/python3.8/site-packages/authlib/integrations/base_client/sync_app.py", line 89, in _send_token_request
2023-07-06 15:26:23     return session.request(method, url, **kwargs)
2023-07-06 15:26:23   File "/usr/local/lib/python3.8/site-packages/authlib/integrations/requests_client/oauth2_session.py", line 109, in request
2023-07-06 15:26:23     return super(OAuth2Session, self).request(
2023-07-06 15:26:23   File "/usr/local/lib/python3.8/site-packages/requests/sessions.py", line 528, in request
2023-07-06 15:26:23     prep = self.prepare_request(req)
2023-07-06 15:26:23   File "/usr/local/lib/python3.8/site-packages/requests/sessions.py", line 456, in prepare_request
2023-07-06 15:26:23     p.prepare(
2023-07-06 15:26:23   File "/usr/local/lib/python3.8/site-packages/requests/models.py", line 320, in prepare
2023-07-06 15:26:23     self.prepare_auth(auth, url)
2023-07-06 15:26:23   File "/usr/local/lib/python3.8/site-packages/requests/models.py", line 556, in prepare_auth
2023-07-06 15:26:23     r = auth(self)
2023-07-06 15:26:23   File "/usr/local/lib/python3.8/site-packages/authlib/integrations/requests_client/oauth2_session.py", line 24, in __call__
2023-07-06 15:26:23     self.ensure_active_token()
2023-07-06 15:26:23   File "/usr/local/lib/python3.8/site-packages/authlib/integrations/requests_client/oauth2_session.py", line 20, in ensure_active_token
2023-07-06 15:26:23     if self.client and not self.client.ensure_active_token(self.token):
2023-07-06 15:26:23   File "/usr/local/lib/python3.8/site-packages/authlib/oauth2/client.py", line 262, in ensure_active_token
2023-07-06 15:26:23     self.refresh_token(url, refresh_token=refresh_token)
2023-07-06 15:26:23   File "/usr/local/lib/python3.8/site-packages/authlib/oauth2/client.py", line 252, in refresh_token
2023-07-06 15:26:23     return self._refresh_token(
2023-07-06 15:26:23   File "/usr/local/lib/python3.8/site-packages/authlib/oauth2/client.py", line 373, in _refresh_token
2023-07-06 15:26:23     token = self.parse_response_token(resp)
2023-07-06 15:26:23   File "/usr/local/lib/python3.8/site-packages/authlib/oauth2/client.py", line 340, in parse_response_token
2023-07-06 15:26:23     raise self.oauth_error_class(
2023-07-06 15:26:23 authlib.integrations.base_client.errors.OAuthError: invalid_grant:

Store the token, expires-in, and refresh-token in the session
Refresh token when needed


Maps: Universal web application with campus navigation

Summary
An idea is it create a public website (which can also behave like Telegram Mini App) that will show the Innopolis campus map to help people find rooms, locations.

The beta version is published: https://t.me/one_zero_eight/109


Invoke-TwitterRequest - Add option for progress bar for paged requests

The command Invoke-TwitterRequest will automatically paginate API v1.1 cursor and API v2 pagination_token and next_token (specifically for Search-Tweet) based paging requests.

As a user of BluebirdPS,
I would like to be made aware of progress during long running, paged requests,
so that I know the command is still executing.

Create an implementation value that uses Write-Progress.
Possible criteria for this functionality:

After the first paginated call
After n number of calls
After n number of seconds since the first paginated call

A Twitter poll has been created requesting input for this.

I think the progress bar should track page it's on vs total page if that info is available from the Twitter API. Would probably be the most useful progress bar that can be given then

Unfortunately, I don't believe there is a mechanism to determine the total number of pages a result set may contain.
Great suggestion, though! And thanks for the feedback!

Results of the poll:
Id           :<PHONE_NUMBER>925144579
Options      : {1) 1st page:3, 2) nth page:2, 3) n seconds after 1st page:3}
TotalVotes   : 8
Duration     : 2880
EndDateTime  : 6/16/2021 9:42:49 AM
VotingStatus : Closed

I was definitely hoping for more votes, or a significant winner. Based on the 8 votes the poll received, it appears there's not a strong opinion on the criteria.
I'll add Write-Progress at the beginning of the paging loop.


nvalidArgumentError (see above for traceback): Tried to read from index 32 but array size is: 32

Parsing GraphDef...
Parsing RunMetadata...
Parsing OpLog...
Preparing Views...
Traceback (most recent call last):
File "/usr/lib64/python2.7/runpy.py", line 162, in _run_module_as_main
"main", fname, loader, pkg_name)
File "/usr/lib64/python2.7/runpy.py", line 72, in _run_code
exec code in run_globals
File "/disk1/mouna/code/seq2seq/bin/train.py", line 251, in
tf.app.run()
File "/usr/lib/python2.7/site-packages/tensorflow/python/platform/app.py", line 44, in run
_sys.exit(main(_sys.argv[:1] + flags_passthrough))
File "/disk1/mouna/code/seq2seq/bin/train.py", line 246, in main
schedule=FLAGS.schedule)
File "/usr/lib/python2.7/site-packages/tensorflow/contrib/learn/python/learn/learn_runner.py", line 106, in run
return task()
File "/usr/lib/python2.7/site-packages/tensorflow/contrib/learn/python/learn/experiment.py", line 459, in train_and_evaluate
self.train(delay_secs=0)
File "/usr/lib/python2.7/site-packages/tensorflow/contrib/learn/python/learn/experiment.py", line 281, in train
monitors=self._train_monitors + extra_hooks)
File "/usr/lib/python2.7/site-packages/tensorflow/python/util/deprecation.py", line 280, in new_func
return func(*args, **kwargs)
File "/usr/lib/python2.7/site-packages/tensorflow/contrib/learn/python/learn/estimators/estimator.py", line 426, in fit
loss = self._train_model(input_fn=input_fn, hooks=hooks)
File "/usr/lib/python2.7/site-packages/tensorflow/contrib/learn/python/learn/estimators/estimator.py", line 984, in _train_model
_, loss = mon_sess.run([model_fn_ops.train_op, model_fn_ops.loss])
File "/usr/lib/python2.7/site-packages/tensorflow/python/training/monitored_session.py", line 462, in run
run_metadata=run_metadata)
File "/usr/lib/python2.7/site-packages/tensorflow/python/training/monitored_session.py", line 786, in run
run_metadata=run_metadata)
File "/usr/lib/python2.7/site-packages/tensorflow/python/training/monitored_session.py", line 744, in run
return self._sess.run(*args, **kwargs)
File "/usr/lib/python2.7/site-packages/tensorflow/python/training/monitored_session.py", line 899, in run
run_metadata=run_metadata))
File "/usr/lib/python2.7/site-packages/tensorflow/contrib/learn/python/learn/monitors.py", line 1157, in after_run
induce_stop = m.step_end(self._last_step, result)
File "/usr/lib/python2.7/site-packages/tensorflow/contrib/learn/python/learn/monitors.py", line 356, in step_end
return self.every_n_step_end(step, output)
File "/usr/lib/python2.7/site-packages/tensorflow/contrib/learn/python/learn/monitors.py", line 657, in every_n_step_end
steps=self.eval_steps, metrics=self.metrics, name=self.name)
File "/usr/lib/python2.7/site-packages/tensorflow/python/util/deprecation.py", line 280, in new_func
return func(*args, **kwargs)
File "/usr/lib/python2.7/site-packages/tensorflow/contrib/learn/python/learn/estimators/estimator.py", line 514, in evaluate
log_progress=log_progress)
File "/usr/lib/python2.7/site-packages/tensorflow/contrib/learn/python/learn/estimators/estimator.py", line 836, in _evaluate_model
hooks=hooks)
File "/usr/lib/python2.7/site-packages/tensorflow/contrib/training/python/training/evaluation.py", line 430, in evaluate_once
session.run(eval_ops, feed_dict)
File "/usr/lib/python2.7/site-packages/tensorflow/python/training/monitored_session.py", line 462, in run
run_metadata=run_metadata)
File "/usr/lib/python2.7/site-packages/tensorflow/python/training/monitored_session.py", line 786, in run
run_metadata=run_metadata)
File "/usr/lib/python2.7/site-packages/tensorflow/python/training/monitored_session.py", line 744, in run
return self._sess.run(*args, **kwargs)
File "/usr/lib/python2.7/site-packages/tensorflow/python/training/monitored_session.py", line 891, in run
run_metadata=run_metadata)
File "/usr/lib/python2.7/site-packages/tensorflow/python/training/monitored_session.py", line 744, in run
return self._sess.run(*args, **kwargs)
File "/usr/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 767, in run
run_metadata_ptr)
File "/usr/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 965, in _run
feed_dict_string, options, run_metadata)
File "/usr/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 1015, in _do_run
target_list, options, run_metadata)
File "/usr/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 1035, in _do_call
raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.InvalidArgumentError: Tried to read from index 32 but array size is: 32
[[Node: model/att_seq2seq/decode/attention_decoder_1/decoder/while/CustomHelperNextInputs/TrainingHelperNextInputs/cond/TensorArrayReadV3 = TensorArrayReadV3[_class=["loc:@model/att_seq2seq/decode/TrainingHelper/TensorArray"], dtype=DT_FLOAT, _device="/job:localhost/replica:0/task:0/cpu:0"](model/att_seq2seq/decode/attention_decoder_1/decoder/while/CustomHelperNextInputs/TrainingHelperNextInputs/cond/TensorArrayReadV3/Switch, model/att_seq2seq/decode/attention_decoder_1/decoder/while/CustomHelperNextInputs/TrainingHelperNextInputs/cond/TensorArrayReadV3/Switch_1/_463, model/att_seq2seq/decode/attention_decoder_1/decoder/while/CustomHelperNextInputs/TrainingHelperNextInputs/cond/TensorArrayReadV3/Switch_2)]]
Caused by op u'model/att_seq2seq/decode/attention_decoder_1/decoder/while/CustomHelperNextInputs/TrainingHelperNextInputs/cond/TensorArrayReadV3', defined at:
File "/usr/lib64/python2.7/runpy.py", line 162, in _run_module_as_main
"main", fname, loader, pkg_name)
File "/usr/lib64/python2.7/runpy.py", line 72, in _run_code
exec code in run_globals
File "/disk1/mouna/code/seq2seq/bin/train.py", line 251, in
tf.app.run()
File "/usr/lib/python2.7/site-packages/tensorflow/python/platform/app.py", line 44, in run
_sys.exit(main(_sys.argv[:1] + flags_passthrough))
File "/disk1/mouna/code/seq2seq/bin/train.py", line 246, in main
schedule=FLAGS.schedule)
File "/usr/lib/python2.7/site-packages/tensorflow/contrib/learn/python/learn/learn_runner.py", line 106, in run
return task()
File "/usr/lib/python2.7/site-packages/tensorflow/contrib/learn/python/learn/experiment.py", line 459, in train_and_evaluate
self.train(delay_secs=0)
File "/usr/lib/python2.7/site-packages/tensorflow/contrib/learn/python/learn/experiment.py", line 281, in train
monitors=self._train_monitors + extra_hooks)
File "/usr/lib/python2.7/site-packages/tensorflow/python/util/deprecation.py", line 280, in new_func
return func(*args, **kwargs)
File "/usr/lib/python2.7/site-packages/tensorflow/contrib/learn/python/learn/estimators/estimator.py", line 426, in fit
loss = self._train_model(input_fn=input_fn, hooks=hooks)
File "/usr/lib/python2.7/site-packages/tensorflow/contrib/learn/python/learn/estimators/estimator.py", line 984, in _train_model
_, loss = mon_sess.run([model_fn_ops.train_op, model_fn_ops.loss])
File "/usr/lib/python2.7/site-packages/tensorflow/python/training/monitored_session.py", line 462, in run
run_metadata=run_metadata)
File "/usr/lib/python2.7/site-packages/tensorflow/python/training/monitored_session.py", line 786, in run
run_metadata=run_metadata)
File "/usr/lib/python2.7/site-packages/tensorflow/python/training/monitored_session.py", line 744, in run
return self._sess.run(*args, **kwargs)
File "/usr/lib/python2.7/site-packages/tensorflow/python/training/monitored_session.py", line 899, in run
run_metadata=run_metadata))
File "/usr/lib/python2.7/site-packages/tensorflow/contrib/learn/python/learn/monitors.py", line 1157, in after_run
induce_stop = m.step_end(self._last_step, result)
File "/usr/lib/python2.7/site-packages/tensorflow/contrib/learn/python/learn/monitors.py", line 356, in step_end
return self.every_n_step_end(step, output)
File "/usr/lib/python2.7/site-packages/tensorflow/contrib/learn/python/learn/monitors.py", line 657, in every_n_step_end
steps=self.eval_steps, metrics=self.metrics, name=self.name)
File "/usr/lib/python2.7/site-packages/tensorflow/python/util/deprecation.py", line 280, in new_func
return func(*args, **kwargs)
File "/usr/lib/python2.7/site-packages/tensorflow/contrib/learn/python/learn/estimators/estimator.py", line 514, in evaluate
log_progress=log_progress)
File "/usr/lib/python2.7/site-packages/tensorflow/contrib/learn/python/learn/estimators/estimator.py", line 810, in _evaluate_model
eval_ops = self._get_eval_ops(features, labels, metrics)
File "/usr/lib/python2.7/site-packages/tensorflow/contrib/learn/python/learn/estimators/estimator.py", line 1190, in _get_eval_ops
features, labels, model_fn_lib.ModeKeys.EVAL)
File "/usr/lib/python2.7/site-packages/tensorflow/contrib/learn/python/learn/estimators/estimator.py", line 1133, in _call_model_fn
model_fn_results = self._model_fn(features, labels, **kwargs)
File "/disk1/mouna/code/seq2seq/bin/train.py", line 164, in model_fn
return model(features, labels, params)
File "seq2seq/models/model_base.py", line 111, in call
return self._build(features, labels, params)
File "seq2seq/models/seq2seq_model.py", line 263, in _build
decoder_output, _, = self.decode(encoder_output, features, labels)
File "seq2seq/graph_utils.py", line 38, in func_wrapper
return templated_func(*args, **kwargs)
File "/usr/lib/python2.7/site-packages/tensorflow/python/ops/template.py", line 276, in call
return self._call_func(args, kwargs, check_for_new_variables=False)
File "/usr/lib/python2.7/site-packages/tensorflow/python/ops/template.py", line 216, in _call_func
result = self._func(*args, **kwargs)
File "seq2seq/models/basic_seq2seq.py", line 124, in decode
labels)
File "seq2seq/models/basic_seq2seq.py", line 87, in _decode_train
return decoder(decoder_initial_state, helper_train)
File "seq2seq/graph_module.py", line 57, in call
return self._template(*args, **kwargs)
File "/usr/lib/python2.7/site-packages/tensorflow/python/ops/template.py", line 267, in call
return self._call_func(args, kwargs, check_for_new_variables=False)
File "/usr/lib/python2.7/site-packages/tensorflow/python/ops/template.py", line 216, in _call_func
result = self._func(*args, **kwargs)
File "seq2seq/decoders/rnn_decoder.py", line 110, in _build
maximum_iterations=maximum_iterations)
File "seq2seq/contrib/seq2seq/decoder.py", line 282, in dynamic_decode
swap_memory=swap_memory)
File "/usr/lib/python2.7/site-packages/tensorflow/python/ops/control_flow_ops.py", line 2605, in while_loop
result = context.BuildLoop(cond, body, loop_vars, shape_invariants)
File "/usr/lib/python2.7/site-packages/tensorflow/python/ops/control_flow_ops.py", line 2438, in BuildLoop
pred, body, original_loop_vars, loop_vars, shape_invariants)
File "/usr/lib/python2.7/site-packages/tensorflow/python/ops/control_flow_ops.py", line 2388, in BuildLoop
body_result = body(*packed_vars_for_body)
File "seq2seq/contrib/seq2seq/decoder.py", line 242, in body
decoder_finished) = decoder.step(time, inputs, state)
File "seq2seq/decoders/attention_decoder.py", line 186, in step
time=time, outputs=outputs, state=cell_state, sample_ids=sample_ids)
File "seq2seq/contrib/seq2seq/helper.py", line 125, in next_inputs
time=time, outputs=outputs, state=state, sample_ids=sample_ids)
File "seq2seq/decoders/attention_decoder.py", line 154, in att_next_inputs
name=name)
File "seq2seq/contrib/seq2seq/helper.py", line 204, in next_inputs
lambda: nest.map_structure(read_from_ta, self._input_tas))
File "/usr/lib/python2.7/site-packages/tensorflow/python/ops/control_flow_ops.py", line 1745, in cond
_, res_f = context_f.BuildCondBranch(fn2)
File "/usr/lib/python2.7/site-packages/tensorflow/python/ops/control_flow_ops.py", line 1639, in BuildCondBranch
r = fn()
File "seq2seq/contrib/seq2seq/helper.py", line 204, in
lambda: nest.map_structure(read_from_ta, self._input_tas))
File "/usr/lib/python2.7/site-packages/tensorflow/python/util/nest.py", line 302, in map_structure
structure[0], [func(*x) for x in entries])
File "seq2seq/contrib/seq2seq/helper.py", line 200, in read_from_ta
return inp.read(next_time)
File "/usr/lib/python2.7/site-packages/tensorflow/python/ops/tensor_array_ops.py", line 250, in read
name=name)
File "/usr/lib/python2.7/site-packages/tensorflow/python/ops/gen_data_flow_ops.py", line 2421, in _tensor_array_read_v3
name=name)
File "/usr/lib/python2.7/site-packages/tensorflow/python/framework/op_def_library.py", line 763, in apply_op
op_def=op_def)
File "/usr/lib/python2.7/site-packages/tensorflow/python/framework/ops.py", line 2327, in create_op
original_op=self._default_original_op, op_def=op_def)
File "/usr/lib/python2.7/site-packages/tensorflow/python/framework/ops.py", line 1226, in init
self._traceback = _extract_stack()
InvalidArgumentError (see above for traceback): Tried to read from index 32 but array size is: 32
[[Node: model/att_seq2seq/decode/attention_decoder_1/decoder/while/CustomHelperNextInputs/TrainingHelperNextInputs/cond/TensorArrayReadV3 = TensorArrayReadV3[_class=["loc:@model/att_seq2seq/decode/TrainingHelper/TensorArray"], dtype=DT_FLOAT, _device="/job:localhost/replica:0/task:0/cpu:0"](model/att_seq2seq/decode/attention_decoder_1/decoder/while/CustomHelperNextInputs/TrainingHelperNextInputs/cond/TensorArrayReadV3/Switch, model/att_seq2seq/decode/attention_decoder_1/decoder/while/CustomHelperNextInputs/TrainingHelperNextInputs/cond/TensorArrayReadV3/Switch_1/_463, model/att_seq2seq/decode/attention_decoder_1/decoder/while/CustomHelperNextInputs/TrainingHelperNextInputs/cond/TensorArrayReadV3/Switch_2)]]

I am not sure. I have seen errors like this happen when using the same GPU in multiple processes. Make sure that you don't have any other python/tensorflow processes running (including notebooks)>

Thanks for reply my #98 issue. But, actually, I don't have any other processes running. But I run only on one GPU, and encounter this problem at evaluation. Is there any conflict between training and validation?

I checked the log. It seems when doing validation, a new process is started and trying to use the same GPU and then failed in this error.  It's just my guess. I'm still not quite familiar with the code.

It's normal that validation loads the model graph again, and it shouldn't be an issue. Otherwise there is no difference between validation and training, except for the data. It's difficult for me to debug this without having a way to reproduce the error..

Ok, I see. Thank you! But I think this error must be related to GPU, I didn't encounter the problem on CPU. I cannot figure out what's wrong here now. So, I decide to train model only without validation and save more checkpoints to validate later.

What GPU do you have?

01:00.0 VGA compatible controller: NVIDIA Corporation GP104 [GeForce GTX 1070] (rev a1)
This GPU works well before, and if I drop the validation and only train, it also works well. So, maybe there are some configs that I ignore or set wrong...

I met the same error...

I have also encountered the same error.

It seems that I might have managed to solve the issue by switching to the latest development version of Tensorflow (compiled from source from the master branch). At least now I'm getting a different error. See #102. I am not yet sure if now #102 doesn't just make it crash earlier. I will report back if that's the case.

Thanks for reporting, I do believe all of these issues are caused by the same problem, so I will close them and create a new issue to handle these: https://github.com/google/seq2seq/issues/103


Error failed to load pkl model - missing model error

/kind bug
What steps did you take and what happened:
[root@machine-003 kubeflow]# k logs inf-sample-predictor-default-00001-deployment-76c766d6f7-rjnp8  -n kubeflow kserve-container
/usr/local/lib/python3.7/site-packages/ray/autoscaler/_private/cli_logger.py:61: FutureWarning: Not all Ray CLI dependencies were found. In Ray 1.4+, the Ray CLI, autoscaler, and dashboard will only be usable via pip install 'ray[default]'. Please update your install command.
"update your install command.", FutureWarning)
[I 211213 04:25:33 storage:52] Copying contents of /mnt/models to local
[E 211213 04:25:33 main:37] fail to load model inf-sample from dir /mnt/models. exception type <class 'RuntimeError'>, exception msg: Missing Model File.
[I 211213 04:25:33 kfserver:120] Setting asyncio max_workers as 5
[I 211213 04:25:33 kfserver:127] Listening on port 8080
[I 211213 04:25:33 kfserver:129] Will fork 1 workers
[root@machine-003 kubeflow]# cat mnist-pvc.yaml
apiVersion: "serving.kserve.io/v1beta1"
kind: "InferenceService"
metadata:
name: "inf-sample"
namespace: "kubeflow"
spec:
predictor:
sklearn:
storageUri: pvc://test-4stg6-data-volume/models/inf-sample
the model was saved in the pvc as -
filename = f'/mnt/models/inf-sample'
pickle.dump(model, open(filename, 'wb'))
The model exists as seen here -
k exec -it inf-sample-predictor-default-00001-deployment-76c766d6f7-rjnp8  -n kubeflow sh
ls /mnt/models/inf-sample
/mnt/models/inf-sample
What did you expect to happen:
No missing model error
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Environment:
Knative Version: v0.22.0
KFServing Version: 0.6
Kubeflow version: 1.6
Kfdef:[k8s_istio/istio_dex/gcp_basic_auth/gcp_iap/aws/aws_cognito/ibm]
Minikube version: None. Using kubernetes,
Kubernetes version: (use kubectl version): 1.20.5
OS (e.g. from /etc/os-release):
CentOS Linux release 7.9.2009 (Core)
NAME="CentOS Linux"
VERSION="7 (Core)"
ID="centos"
ID_LIKE="rhel fedora"
VERSION_ID="7"

@pshegde May I know how did you copy the model to PV? Please refer the PV storage example provided in the documentation. Thanks!

Closing this issue as there is no activity for a long time


Measure of incompleteness and general overview

This project is awesome! I'm interested in how broken/practical it is.

I don't need anything crazy like multithreading or sockets, and even the canvas is overkill for my purposes. Security, keeping up with LLVM master, and performance are also completely irrelevant to me. I have an extensive background in C++, JS web-dev, and Node.js, but absolutely 0 experience with LLVM itself.

Thanks for your interest! I'm not sure why these headers would fail in particular, other than that I built on top of a relatively new toolchain (wasi-sdk from about a year ago), which also may have had missing pieces. I also implemented features as I needed them for the demo, so there are likely to be holes there too.
To really productionize this code, I think it would be necessary to take some of the hacks to LLVM I did here and figure out the best way to upstream them. This may be tricky to do, since the WASI platform is still unstable. This is important for keeping up with LLVM master (which you state as a non-goal), but also increases the likelihood that things work.
The next step would be to use a better WASI polyfill for the web; as mentioned above, the one I implemented works, but uses an older version of the WASI API, and is incomplete.

Thanks @binji that helps a lot, I'll take a look at those hacks and building it with the lastest wasi sdk. What I'll be doing will probably be pretty hacky/incomplete for my purposes as well, but hopefully it'll build on what is already here.

Considering that this ended up in the state it was presented on CppCon, do you know about any projects that are taking this further? I'm interested in this type of setup exactly for educational purposes, since the initial setup is the main barrier for teaching C++ (and offline work on a mobile device, tablet or a chromebook is near impossible).

Yeah, I'm sorry I haven't had more time to put into this. It really would be great if someone could take this further! I'd be happy to help with code reviews or suggestions.


Interact in 6.0.0 does not clear the output before rendering a new pandas plot

I'm using @interact with pandas to plot and when I change a value another chart is added below the previous one. Reverting to 5.2.2 fixes the issue.
I'm running Jupyter 4.3.0 and ipython 5.3.0.

This works for me. Does it work for you?
import matplotlib.pyplot as plt
import pandas as pd
import numpy as np
from ipywidgets import interact

@interact(n=(1000,2000))
def f(n):
    ts = pd.Series(np.random.randn(n), index=pd.date_range('1/1/2000', periods=n))
    ts = ts.cumsum()
    ts.plot()
    plt.show()

Are you using %matplotlib inline? That doesn't work with interact anymore, due to the way it draws the plots.

Looking into it more led to opening this issue: https://github.com/ipython/ipython/issues/10376.
Basically, if you're using the %matplotlib inline backend, you can either not use it and call the plt.show() method explicitly, or you can import the flush_figures method and do something like:
import matplotlib.pyplot as plt
import pandas as pd
import numpy as np
from ipywidgets import interact
from ipykernel.pylab.backend_inline import flush_figures

%matplotlib inline

@interact(n=(1000,2000))
def f(n):
    ts = pd.Series(np.random.randn(n), index=pd.date_range('1/1/2000', periods=n))
    ts = ts.cumsum()
    ts.plot()
    flush_figures()

We're working on seeing if there is a better way...

Thanks, yes that works! Sorry for not sharing more details earlier. I've been using %matplotlib inline out of habit to display plots inline, but is there a better option perhaps?

Actually, it seems that it's way simpler than I posted above. You can use %matplotlib inline, you just need to explicitly show the figure inside the function. You don't need to use the flush_figures method:
import matplotlib.pyplot as plt
import pandas as pd
import numpy as np
from ipywidgets import interact

%matplotlib inline

@interact(n=(1000,2000))
def f(n):
    ts = pd.Series(np.random.randn(n), index=pd.date_range('1/1/2000', periods=n))
    ts = ts.cumsum()
    ts.plot()
    plt.show()

Closing as resolved, but I'm happy to carry on the conversation if you have any other questions.

In ipython/ipython#10376 and #1457, we thought it might be worth it to do the flush_figure workaround in interact from ipython/ipython#10376.  I'm reopening this issue to track us implementing the workaround.


Only close on successful open

This resolves #10593

[approve ci clang-format]

[approve ci]

[approve ci]

[approve ci clang-format]

[approve ci]


Can't create view-less routes

Reproduce

Create a project bud create project
bud new controller anything (create new route without any views)
bud run will give an error:

# bud-app/bud/.app/web
bud/.app/web/web.go:6:2: imported and not used: "bud-app/bud/.app/controller"
| exit status 2

But when I create a project, before step 2, if I add a route with a view bud new controller hello index, there will be no error.

Hah, I hadn't considered the empty case. In general, I find this API confusing. What do you think about: https://github.com/livebud/bud/discussions/143#discussioncomment-2994918?


Refactor project so the compiled assets are ignored

Going forward we'll ignore the compiled assets so they can be generated by build tools. This will be beneficial in a number of ways:

📃 We no longer need to track giant minified files
↩ When we have merge conflicts they will only occur in the source files. This makes merging much more intuitive
⏱ We no longer need to run the build task before deploying changes
📖 Pull requests are more legible
🙈 Less pressure to ensure teammates run the same dependencies and aren't changing minified files that are too difficult to parse.

This is being addressed in #40


[Fix] Lumen version detection

Lumen does return version as string like "Lumen (9.1.5) (Laravel Components ^9.21)", this PR will get the correct version from the string in turn fixing the checkVersion method in turn enabling the Fix for Illuminate 9 from https://github.com/barryvdh/laravel-debugbar/commit/b96f9820aaf1ff9afe945207883149e1c7afb298

Wrong base, reopened at https://github.com/barryvdh/laravel-debugbar/pull/1391/


Callback Checkpointing never called

Discussed in https://github.com/Lightning-AI/lightning/discussions/13800

Originally posted by Anon-catnt July 22, 2022
I am trying to save my Callback state along with my model at the end of each epoch.
I tried reimplementing the example here.
I put print statement/breakpoint at the state_dict and load_state_dict method, and they are never called during my training. And the Counter state is not recovered.
I tried to use checkpointing both with a callback ModelCheckpoint in the callback list of the trainer and with enable_checkpointing set to True (with or without the ModelCheckpoint) without it working.
For reference, other states are well loaded (for example the right epoch, the model weights etc).
Here is a minimum working example:

First train a model from scratch and save it
put loading = True
Rerun the script, in the training_step the value self.current_epoch et self.cpt are recovered but not the state of the Callback Counter.

import pytorch_lightning as pl
import torch
from pytorch_lightning import Callback, Trainer
from pytorch_lightning.callbacks import ModelCheckpoint
from torch.nn import Parameter
from torch.optim import Adam
from torch.utils.data import Dataset, DataLoader

class Dummy_dataset(Dataset):
	def __init__(self, length):
		self.length = length

	def __len__(self):
		return self.length

	def __getitem__(self, item):
		return 1

class Dummy_Model(pl.LightningModule):
	def __init__(self):
		super(Dummy_Model, self).__init__()
		self.cpt = Parameter(torch.tensor(0.), requires_grad=False)

	def configure_optimizers(self):
		return Adam([
			{'params': self.cpt},
		])

	def forward(self, data):
		return data

	def training_step(self, data, batch_idx):
		self.cpt += batch_idx
		print(f'\n{self.current_epoch=} {self.cpt=}')
		return None

	def validation_step(self, data, batch_idx):
			pass

	def test_step(self, data, batch_idx):
		pass

class Counter(Callback):
	def __init__(self):
		self.state = {"epochs": 0, "batches": 0}

	def on_train_epoch_end(self, *args, **kwargs):
		self.state['epochs'] += 1
		print(self.state)

	def on_train_batch_end(self, *args, **kwargs):
		self.state['batches'] += 1

	def load_state_dict(self, state_dict):
		print('load_state_dict')
		self.state.update(state_dict)

	def state_dict(self):
		print('state_dict')
		return self.state.copy()

train_dataloader = DataLoader(Dummy_dataset(length=10), batch_size=2)
valid_dataloader = DataLoader(Dummy_dataset(length=10), batch_size=2)

model = Dummy_Model()
checkpoint_callback = ModelCheckpoint(
	dirpath='./',
	monitor=None,
	verbose=True,
	save_last=True,
	every_n_epochs=1,
)
loading = False
trainer = Trainer(
	max_epochs=300 if loading else 50,
	callbacks=[Counter(), checkpoint_callback],
	enable_checkpointing=True,
)
trainer.fit(
	model=model,
	train_dataloader=train_dataloader,
	val_dataloaders=valid_dataloader,
	ckpt_path='last.ckpt' if loading else None,
)
```</div>

Your training_step returns None, hence no parameter updates and thus no parameter change. Lightning only saves a checkpoint if the parameters change. Try again by returning a loss with gradient.

Closing, and continuing discussion in the original thread.


NextJS/antd/Less: Module parse failed: Unexpected character '@' (1:0)

Hey good people, I installed the version "^0.3.0"
But I am getting this error when trying to build:

next.config.js
const withAntdLess = require("next-plugin-antd-less");

const withPWA = require("next-pwa");
const runtimeCaching = require("next-pwa/cache");
const withPlugins = require("next-compose-plugins");
const optimizedImages = require("next-optimized-images");

const isProduction = process.env.NODE_ENV === "production";

module.exports = withPWA({
  pwa: {
    disable: !isProduction,
    dest: "public",
    register: true,
    runtimeCaching,
  },
});

module.exports = withAntdLess({
  lessVarsFilePath: "./theme/less/theme.less",
  webpack(config) {
    config.module.rules.push({
      test: /\.(png|jpg|jpeg|gif|svg|eot|ttf|woff|woff2)$/,
      use: {
        loader: "url-loader",
      },
    });

    return config;
  },
});

module.exports = withPlugins([optimizedImages]);

.babelrc
{
  "env": {
    "development": {
      "presets": ["next/babel"]
    },
    "production": {
      "presets": ["next/babel"]
    },
    "test": {
      "presets": [
        [
          "next/babel",
          {
            "preset-env": {
              "modules": "commonjs"
            }
          }
        ]
      ],
      "plugins": ["istanbul"]
    }
  },
  "plugins": [
    "react-optimized-image/plugin",
    [
      "import",
      {
        "libraryName": "antd",
        "style": true
      }
    ]
  ]
}

https://github.com/SolidZORO/next-plugin-antd-less/issues/22

Do you have any idea on why I'm getting this error?

try yarn install --force？
look missing less or  less-loader?

I solved the problem. I think it's better to show the solution for anyone who uses next-compose-plugins
You should export all plugins alongside their config all inside the withPlugins() function as follow:
module.exports = withPlugins([
  [optimizedImages],
  [
    withPWA,
    {
      pwa: {
        disable: !isProduction,
        dest: "public",
        register: true,
        runtimeCaching,
      },
    },
  ],
  [
    withAntdLess,
    {
      lessVarsFilePath: "./theme/less/theme.less",
    },
  ],
]);


fix: [CDS-75383]: support for execute on delegate option for docker connector

Describe your changes
Comment Triggers

PR Check triggers

Build: trigger build
Sub Category Field Check: trigger subcategoryfieldcheck

trigger build

trigger build

trigger build


How to generate sentid's for another dataset?

I am trying to train this model using the CUB data set for birds. Therefore I need to create a JSON file like dataset_coco.json for COCO, but for CUB. How would I generate the sentid's for another data set?

@hughkf
Have you succeed in  creating a JSON file like dataset_coco.json?


visualstudio2017: install the exact VS version as the package version

Currently, the VS product packages simply invoke the VS setup bootstrapper, which always installs the newest released VS version.
In order to make installations deterministic, the packages should somehow instruct the bootstrapper to install a specific VS version. This can probably be done by embedding the channel manifest in the package.

Not sure if we can legally embed and distribute the manifests in the package.

An alternative (to embedding the manifest) idea will be tracked here: #82


Slang

Is there a method you would prefer for individuals to add slang to parts of speech library?
Would you allow for this/ how would I go about doing it?
i.e do contractions like 'sup?' get reduced to a verb or a noun?

There's functionality to support handling special cases in arbitrary, user-defined ways. But, I haven't wired this up properly yet.
The tokenizer reads a data file that looks like this: https://github.com/honnibal/spaCy/blob/master/lang_data/en/specials.json
The key form maps to a list of tokens. You can specify the form, lemma, POS tag etc for each token.
So, you can do any sort of non-concatenative morphology you want. You can do:
"sup": [{"F": "what"}, {"F": "is"}, {"F": "up"}]
If you want.
But, as I said, this isn't set up in a nice way yet. You can find the specials.json file spaCy is currently loading under the spacy/en/data file, which is probably installed into your virtualenv. You can find the directory with "python -e import spacy.en; print spacy.en.file".

That is very helpful. Thanks for your reply will be sure to mention you and your help in the paper! Keep up the awesome work!


CXF-8227: Failure to comply with JAX-RS spec with ContainerRequestContext and WriterInterceptorContext

For some reasons, the implementation branched off into request / message property holders. If the request was available in the message context, all properties were mapped to request attributes, otherwise to message properties container. In order to preserve the compatibility, the fix still supports request attributes however at the same time populates message properties container.

Thanks a lot for the review, @andymc12 !

This has fixed setting the attribute in ContainerRequestFilter.filter and reading it from WriterInterceptor.aroundWriteTo but still seems to lack attributes defined in a HttpServletRequest.
The work-around seems to be to inject the servlet request itself and reading from there directly:
@Context
private HttpServletRequest servletRequest;

… but since the servlet request exists (after all, it was injected correctly) I think also WriterInterceptorContext.getParameter should access to it as stated in the JavaDoc: In a Servlet container, on the server side, the properties are backed by the ServletRequest and contain all the attributes available in the ServletRequest..

This has fixed setting the attribute in ContainerRequestFilter.filter and reading it from WriterInterceptor.aroundWriteTo but still seems to lack attributes defined in a HttpServletRequest.

Correct, the fix was focused on JAR-RS part, not the HttpServletRequest, but WriterInterceptorContext may need a special treatment probably, thank you @lapo-luchini

@lapo-luchini I was looking into the way WriterInterceptorContext.getProperty works and it should provider access to servlet attributes (since it uses the same PropertyHolderFactory as ContainerRequestContext does ). Could you please provider a reproducer for the issue? Thank you.


Room model

Here is the specification for a room model. For context on what the functionality will be here, we will have a listing of the rooms available to RCOS. The small group model will have a reference to the different rooms (where each small group is located).

Room

name (string)
location (string)
capacity (number)
wheelchair_accessible (boolean)

The role of this issue is to create the needed database model so that Mongo will know what properties a 'Room' document should have (basically, just the 4 properties we have above).
The model for posts may be a good reference (found in server/api/post/post.model.js).

Resolved by #777


Adding Message Metadata Support to Bolt JS

Summary
The PR introduces support for Message Metadata events within the Bolt framework. This should be paired together with https://github.com/slackapi/node-slack-sdk/pull/1504 as the "MessageMetadata" is defined within.
Support for MessageMetadataPostedEvent, MessageMetadataUpdated and MessageMetadataDeletedEvent are introduced within this PR.
Requirements (place an x in each [ ])

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.

Regarding Issue https://github.com/slackapi/bolt-js/issues/1507

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

As the CI build failure shows, this pull request requires a new version release of @slack/types. Let me convert this PR to draft mode for now.

I'm assuming we would wait for this milestone before consider merging this PR, right?

@dannyhostetler Thanks for checking the milestone. Since other tasks that were listed there need more time, I've moved them to other milestones. We will release a new package version shortly.

types v2.6.0 is now available https://github.com/slackapi/node-slack-sdk/releases/tag/%40slack%2Ftypes%402.6.0

Can you fix the test failure detected by GitHub Actions jobs?
TSError: ⨯ Unable to compile TypeScript:
Error: src/types/events/message-events.spec.ts(230,11): error TS2322: Type '{ type: "message_metadata_deleted"; channel_id: string; event_ts: string; previous_metadata: { event_type: string; event_payload: { key: string; }; }; app_id: string; bot_id: string; user_id: string; team_id: string; message_ts: string; }' is not assignable to type 'MessageMetadataEvent'.
  Property 'deleted_ts' is missing in type '{ type: "message_metadata_deleted"; channel_id: string; event_ts: string; previous_metadata: { event_type: string; event_payload: { key: string; }; }; app_id: string; bot_id: string; user_id: string; team_id: string; message_ts: string; }' but required in type 'MessageMetadataDeletedEvent'.

@filmaj

Question: do we need to take these metadata events into account in the event / middleware processing chain in bolt? In particular, the conversation ID extraction logic. This method has different logic to pull out the conversation ID based on the kind of event being received. Do we need to add some more logic to take into account the message metadata event structure here?

No, I don't think so. The conversation ID is supposed to be used only by https://slack.dev/bolt-js/concepts#conversation-store and the convo store feature is associated with message-type events. If a developer intentionally use metadata events only, I am sure that the developer does not expect convo store to work with convo store well.
Also, in reality, I think that the convo store is not used a lot. The feature was added to provide an alternative for hubot's brain: https://slack.dev/bolt-js/tutorial/hubot-migration#migrating-the-brain-to-the-conversation-store There is no downside to keep the feature so far but, in future major versions, we may consider deprecating the feature or split the feature from the core module.

@filmaj

Suggestion: what about adding a very simple example to the examples/ directory that includes showing an app listening to metadata events as well as using these types? I think that would be helpful to a lot of people, as well as for us the maintainers, whom have to quickly reproduce different scenarios for how people build apps. I always use the examples a lot to help with triaging new incoming issues.

Fantastic suggestion, and thanks for the feedback! Agreed, I myself am always referring to these examples. I'm working on mocking up a simple example RE: Message Metadata events and I'll get it pushed within the next day or so.

Ah, thanks for educating me on that @seratch !

Hey @dannyhostetler ! One thing I noticed trying to get the example running by linking up the bolt-js root repo first is I get this error:
➜ npm link
npm ERR! code 2
npm ERR! path /Users/fmaj/src/bolt-js
npm ERR! command failed
npm ERR! command sh -c npm run build
npm ERR! ><EMAIL_ADDRESS>build
npm ERR! > tsc
npm ERR!
npm ERR! src/types/events/message-events.ts(1,48): error TS2305: Module '"@slack/types"' has no exported member 'MessageMetadata'.

I think that's because @slack/types didn't introduce support for MessageMetadata until v2.6.0. So I think we need to bump the @slack/types in package.json to be at least 2.6.0.
Odd that the CI didn't pick this up... I guess because the semver specifier for @slack/types in package.json is ^2.4.0, and CI installs a fresh copy of the types, so it gets the latest version just fine. But I guess on my system I had an earlier version installed locally and thus the error.

Hey @dannyhostetler ! One thing I noticed trying to get the example running by linking up the bolt-js root repo first is I get this error:
➜ npm link
npm ERR! code 2
npm ERR! path /Users/fmaj/src/bolt-js
npm ERR! command failed
npm ERR! command sh -c npm run build
npm ERR! ><EMAIL_ADDRESS>build
npm ERR! > tsc
npm ERR!
npm ERR! src/types/events/message-events.ts(1,48): error TS2305: Module '"@slack/types"' has no exported member 'MessageMetadata'.

I think that's because @slack/types didn't introduce support for MessageMetadata until v2.6.0. So I think we need to bump the @slack/types in package.json to be at least 2.6.0.
Odd that the CI didn't pick this up... I guess because the semver specifier for @slack/types in package.json is ^2.4.0, and CI installs a fresh copy of the types, so it gets the latest version just fine. But I guess on my system I had an earlier version installed locally and thus the error.

@filmaj Think this should be good now. For what ever reason I explicitly removed that from the package.json because @slack\types is a dependency package of bolt and didn't think it was needed. Anywho, give it a try again and see if this works for you.

@dannyhostetler Oh, I meant in the top-level package.json in this repo!

OK, got the package building! However, I can't seem to trigger the message_metadata_posted event in the app 🤔 I added the /post slash command to my app definition on api.slack.com/apps, as well as subscribed the app to the message_metadata_posted event. The /post works, and the bot answers "Message Metadata Posting", but can't seem to get the "Message Metadata Posted" event to trigger...
I'll try to dig in more tomorrow to see what's going on.

@filmaj I'm willing to bet it's because you're missing metadata_subscriptions in your manifest.
"event_subscriptions": {           "bot_events": [               "message_metadata_deleted",               "message_metadata_posted",               "message_metadata_updated"           ],           "metadata_subscriptions": [               {                   "app_id": "[your app id]",                   "event_type": "my_event"               }           ]       },

You would have won that bet @dannyhostetler !
Last request for this PR: can we add a basic README.md to the example directory that details the setup instructions for this app? Maybe as simple as "create an app on api.slack.com/apps from scratch, note down the App ID, open up the manifest editor on api.slack.com/apps/, paste in the contents of app-manifest.json), update the reference to your App ID in there, save it. Install to a workspace. Export the your app and bot tokens as env vars. Run the app with node app.js'. Just something along the lines of the examples/oauth/README.md, maybe?

@filmaj Yeah, the metadata subscription is a bit tricky (and I don't personally like how you have to specify the app id, I think should it be able to dynamically determine 🤷). No biggie, I should have actually added one earlier (probably just being lazy). I'm traveling over the next day or day, so I'll get this pushed sometime this week.

Yes I agree with you re: entering the App ID, seems like us-at-Slack should be able to infer that 🤨 I'll raise that internally to see if that can be improved.
And thank you for following up on all my requests 🙏 really appreciate your collaboration on this 🙇

@filmaj Actually just went ahead and did this now. Added a basic README, hope this looks good


feat: adds opensearchservice

Description of your changes
Adds open search service
Fixes #1228
I have:

[x] Read and followed Crossplane's [contribution process].
[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
Create/Delete have been tested successfully in us-west-2 using examples/opensearchservice/domain.yaml

Can you Check DCO Signing ? ;)

cc @mvkrishna86 @sendmars - looks like all of you are interested in this, if you can, please coordinate. I think we have two PRs now.

@jcooklin can you Check for merge conflicts?

@haarchri ✅


Upcoming release to remove qs dependency?

I saw that in the latest commit (f0c4a21a139) the dependency on qs was changed to support older versions of node.
Will this be tagged and released as a version of robohydra?  (Pretty please with sugar on top?)
Thanks.

I kind of wanted to wait until I had the proxy support in place, but that might take a while, so here you go!


Enable librdkafka error logging for a producer.

cc @ottomata

Coverage decreased (-0.5%) to 88.194% when pulling 3d6f68d897348926b1a358b0f439bad633a1f2c2 on Pchelolo:producer_logging into b635a446e9d794fed88e72f8b362ede759b95393 on wikimedia:master.

Done


Corrected variable names for windChillInF

Please send your pull requests the develop branch.
Don't forget to add the change to CHANGELOG.md.

Note: Sometimes the development moves very fast. It is highly
recommended that you update your branch of develop before creating a
pull request to send us your changes. This makes everyone's lives
easier (including yours) and helps us out on the development team.
Thanks!

Does the pull request solve a related issue?
If so, can you reference the issue?
What does the pull request accomplish? Use a list if needed.
If it includes major visual changes please add screenshots.

Warnings

:warning:

Please include an updated CHANGELOG.md file.This way we can keep track of all the contributions.

  Generated by :no_entry_sign: dangerJS

Nevermind, looks like the latest dev branch has the variable names corrected already.  Also, I probably shoudn't have been trying to push open pull requests on Master.  :)


providing logo

there is no logo on top-left beside UMatter so i can add logo there and give it functioning to home button

@MonalikaPatnaik  if you please assign me i can start working on it

Heyy @Abhiramjampani..you opened so many issues..You can add navbar to the forgot password page...
Are u willing to work on this??

Heyy @Abhiramjampani..you opened so many issues..You can add navbar to the forgot password page... Are u willing to work on this??

yes i am

Okay great then add navbar in Forgot Password page!

Hey is it done?? Pls submit your PR within one day otherwise will assign it to someone else!


Laravel Scout 4.0 support?

Current Laravel Scout is locked to version 3.0 in the composer.json, any plans to support 4.0?

Can this be updated to support more current versions of Scout? IMO this package would really bring a lot to the table for the laravel datatables package as it would open up it's use to large datasets that make MySQL/Eloquent a non-starter.


Replace non-ASCII character in source file

Builds with old compilers might be broken by this.

There was also a typo :D

There was also a typo :D

[g] if you want to be pretentious, it does work better to do it correctly, yeah :wink:

Can somebody approve this?

This pull request is ready to merge

Merged.


feat: stmt support sql custom mask handle

在 finish 记录日志时，可以自定义 sql 掩码处理，防止日志泄密

@kevwan

The processing here only performs mask processing on the audit log of sqlx. It may be better if logx supports the mask capability at the framework layer. We plan to support this feature in the near future.

ok


Feature/fix messagebar

this PR closes #466 #386 #465

please resolve the conflict

I'm closing this PR because of the unrelated commits in it


Runtime API for JS&TS using the multi-language tabbed code block component

Work-in-progress multi-language code block component ( #27 ) to address various issues around Runtime API, maintenance and API documentation quality.
Currently all code lives on the atmo/runnable-api/introduction.md page as a proof of concept, and it will need to be moved out to its own component. Similarly the configuration object for language support stability ( #32 ) will need to move to its own config JSON. Language stability now has its own page to be referenced from everywhere in the Reactr component.
Outstanding work (may or may not be tackled as part of this PR):

Implement the badging behavior for language stability
Figure out whether we want to reveal the badges everywhere? (is it too annoying?)
Add status badges to the tabs (or not?) as icons, emojis or through differentiation of colors
Implement loading snippets from external files
Allow wrapping code blocks in <div>-s to allow adding extra content to some of the tabs

The latest changes document the remaining Runtime API imports for JavaScript and TypeScript.
I have included various clarifications in the other docs as I transformed the files to use the <MultiLanguageCodeBlock>, and this my newfound familiarity with Reactr's API code will significantly reduce the time I expect it will take to add the docs for the remaining languages (Grain, Tiny Go).
I have filed a variety of follow-up issues on Reactr for bugs, missing implementations and other inconsistencies:

Request API: https://github.com/suborbital/reactr#213
Response API: https://github.com/suborbital/reactr#215
GraphQL API: https://github.com/suborbital/reactr#221 & https://github.com/suborbital/reactr#222
Static Files API: https://github.com/suborbital/reactr#223

I rebased this on the recent GH Actions changes which means previews of this PR now deploy under:
https://suborbital.github.io/docs/language-component/atmo/runnable-api/introduction

I noticed that on certain pageloads, there is no language selected by default, even if I've selected a language on a different page:

Clicking on Rust brings up the content correctly, but it is a bit confusing at first.
I can't seem to reliably repro it.

Let's change JS/TS to beta instead of preview

I noticed that on certain pageloads, there is no language selected by default, even if I've selected a language on a different page

Yeah so the reason for this is that if you selected a language somewhere it "syncs" across the fields, but if that language is not available another tab is not selected automatically.
There is a "default tab" option but I haven't been able to figure out how to make it work just yet, can file a followup though because I agree that until we have 100% coverage for all languages this can be a bit jarring.


Unable to add VMs to Custom cluster through Rancher manager UI

Environmental Info:
RKE2 Version: 2.7.10

Node(s) CPU architecture, OS, and Version:

OS: RHEL8
Cluster Configuration:

Adding a master node to cluster from Rancher UI.
Describe the bug:

I tried creating a Custom cluster from RANCHER UI, But it was trying to get certificates and not adding the nodes to Clusterl.
This is the Provisioning log:

[INFO ] waiting for at least one control plane, etcd, and worker node to be registered
[INFO ] configuring bootstrap node(s) custom-e5c60a8be15c: waiting for agent to check in and apply initial plan
[INFO ] configuring bootstrap node(s) custom-e5c60a8be15c: waiting for probes: calico, etcd, kube-apiserver, kube-controller-manager, kube-scheduler, kubelet
[INFO ] configuring bootstrap node(s) custom-e5c60a8be15c: waiting for probes: calico, etcd, kube-apiserver, kube-controller-manager, kube-scheduler
[INFO ] configuring bootstrap node(s) custom-e5c60a8be15c: waiting for probes: calico, etcd, kube-apiserver, kube-controller-manager, kube-scheduler, kubelet
[INFO ] configuring bootstrap node(s) custom-e5c60a8be15c: waiting for probes: calico, etcd, kube-apiserver, kube-controller-manager, kube-scheduler
[INFO ] configuring bootstrap node(s) custom-e5c60a8be15c: waiting for probes: calico, etcd, kube-apiserver, kube-controller-manager, kube-scheduler, kubelet
[INFO ] configuring bootstrap node(s) custom-e5c60a8be15c: waiting for probes: calico, etcd, kube-apiserver, kube-controller-manager, kube-scheduler
[INFO ] configuring bootstrap node(s) custom-e5c60a8be15c: waiting for probes: calico, etcd, kube-apiserver, kube-controller-manager, kube-scheduler, kubelet

rancher-system-agent.service log
ST 2006\": cannot parse \"\" as \"Mon\""
May 08 10:20:45 k8screate-test rancher-system-agent[31525]: time="2024-05-08T10:20:45Z" level=error msg="error loading CA cert for probe (kube-controller-manager) /var/lib/rancher/rke2/server/tls/kube-controller-manager/kube-controller-manager.crt: open /var/lib/rancher/rke2/server/tls/kube-controller-manager/kube-controller-manager.crt: no such file or directory"
May 08 10:20:45 k8screate-test rancher-system-agent[31525]: time="2024-05-08T10:20:45Z" level=error msg="error while appending ca cert to pool for probe kube-controller-manager"
May 08 10:20:45 k8screate-test rancher-system-agent[31525]: time="2024-05-08T10:20:45Z" level=error msg="error loading CA cert for probe (kube-scheduler) /var/lib/rancher/rke2/server/tls/kube-scheduler/kube-scheduler.crt: open /var/lib/rancher/rke2/server/tls/kube-scheduler/kube-scheduler.crt: no such file or directory"
May 08 10:20:45 k8screate-testrancher-system-agent[31525]: time="2024-05-08T10:20:45Z" level=error msg="error while appending ca cert to pool for probe kube-scheduler"
May 08 10:20:50 k8screate-test rancher-system-agent[31525]: time="2024-05-08T10:20:50Z" level=error msg="error encountered during parsing of last run time: parsing time \"\" as \"Mon Jan _2 15:04:05 MST 2006\": cannot parse \"\" as \"Mon\""
May 08 10:20:50 k8screate-test rancher-system-agent[31525]: time="2024-05-08T10:20:50Z" level=error msg="error loading CA cert for probe (kube-controller-manager) /var/lib/rancher/rke2/server/tls/kube-controller-manager/kube-controller-manager.crt: open /var/lib/rancher/rke2/server/tls/kube-controller-manager/kube-controller-manager.crt: no such file or directory"
May 08 10:20:50 k8screate-test rancher-system-agent[31525]: time="2024-05-08T10:20:50Z" level=error msg="error while appending ca cert to pool for probe kube-controller-manager"
May 08 10:20:50 k8screate-test rancher-system-agent[31525]: time="2024-05-08T10:20:50Z" level=error msg="error loading CA cert for probe (kube-scheduler) /var/lib/rancher/rke2/server/tls/kube-scheduler/kube-scheduler.crt: open /var/lib/rancher/rke2/server/tls/kube-scheduler/kube-scheduler.crt: no such file or directory"
May 08 10:20:50 k8screate-test rancher-system-agent[31525]: time="2024-05-08T10:20:50Z" level=error msg="error while appending ca cert to pool for probe kube-scheduler"

/etc/rancher/rke2/config.yaml.d/50-rancher.yaml file
{
  "agent-token": "kxxxxxxxxxxxslcdmqxqn6ngv2lq68f6hrspx",
  "cni": "calico",
  "disable-kube-proxy": false,
  "etcd-expose-metrics": false,
  "etcd-snapshot-retention": 5,
  "etcd-snapshot-schedule-cron": "0 */5 * * *",
  "kube-controller-manager-arg": [
    "cert-dir=/var/lib/rancher/rke2/server/tls/kube-controller-manager",
    "secure-port=10257"
  ],
  "kube-controller-manager-extra-mount": [
    "/var/lib/rancher/rke2/server/tls/kube-controller-manager:/var/lib/rancher/rke2/server/tls/kube-controller-manager"
  ],
  "kube-scheduler-arg": [
    "cert-dir=/var/lib/rancher/rke2/server/tls/kube-scheduler",
    "secure-port=10259"
  ],
  "kube-scheduler-extra-mount": [
    "/var/lib/rancher/rke2/server/tls/kube-scheduler:/var/lib/rancher/rke2/server/tls/kube-scheduler"
  ],
  "node-label": [
    "cattle.io/os=linux",
    "rke.cattle.io/machine=0c6d73fc-7358-4983-9d0d-a44d9bbe3a34"
  ],
  "private-registry": "/etc/rancher/rke2/registries.yaml",
  "protect-kernel-defaults": true,
  "system-default-registry": "docker.registry-private.com",
  "token": "huiokjnbnjkoijhgyui8ujhnjklkm"
}

Found certs in
ls /var/lib/rancher/rke2/server/tls/
client-admin.crt       client-ca.key		  client-kube-apiserver.key	    client-rke2-cloud-controller.key  client-supervisor.crt  request-header-ca.key  service.key
client-admin.key       client-ca.nochain.crt	  client-kube-proxy.crt		    client-rke2-controller.crt	      client-supervisor.key  server-ca.crt	    serving-kube-apiserver.crt
client-auth-proxy.crt  client-controller.crt	  client-kube-proxy.key		    client-rke2-controller.key	      dynamic-cert.json      server-ca.key	    serving-kube-apiserver.key
client-auth-proxy.key  client-controller.key	  client-kubelet.key		    client-scheduler.crt	      etcd		     server-ca.nochain.crt  serving-kubelet.key
client-ca.crt	       client-kube-apiserver.crt  client-rke2-cloud-controller.crt  client-scheduler.key	      request-header-ca.crt  service.current.key    temporary-certs

Steps To Reproduce:

Reinstalling the cluster from rancher UI.

Installed RKE2:

Expected behavior:

Actual behavior:

Additional context / logs:

Hi @brandond
Where can I check for the updates on this issue ?
Thank you !!


Enhanced credit card inline validation / formatting

The following are the validation/formatting rules used by PayPal for its Credit Card input fields. We could bake this into ENGrid along with a Luhn Algorithm to verify a card number's validity.
https://pastebin.com/raw/nTPQ1uXY

Replaced by #41


Window corner rescale cursor has wrong orientation

Describe the bug
When I place the cursor in any corner of a window that can be resized, it points in the wrong direction.

Expected behavior
(edited the code a bit)

Desktop (please complete the following information):

OS: Manjaro Linux KDE

Does anyone know if this is an issue on other OSs or desktop environments as well?

Can't reproduce on my mac.
Does this happen if you check out this repo and run cargo run? If so it is probably a bug in winit.
If you are using some third-party egui integration, the bug is probably there.

Closed in favor of https://github.com/rust-windowing/winit/issues/1912


Idea- acknowlegment of an alert

I've been wondering if it's easy to implement an acknowlegment system so a tech working on a triggered alert can "pause" alert notification for the time he fix the issue.
We can already disable one or more checks, but i was thinking about something a little bit more easier.
Any clues maybe ?

Yes it would be nice to "acknowledge" an alert for a couple of reasons:

If a CRITICAL alert occurs, triggering a phone call, and the primary
responder isn't available for any reason, it would be great to work down
the list of potential responders until someone confirms that they can pick
it up.
Silence additional notifications (as you suggest)

One thing I'd want to watch out for however is that it continues to be
obvious that an alarm is still going off - perhaps this can be accomplished
by continuing to send alerts but them being at WARNING level or some other
level...

Like notification interval we maybe can have a acknowlegment interval which would silence alerts, some square to tick on to enabled the acknowlegment system but would re enable alerts alert when the acknowlegment interval is met, this way we can easily implement sla

+1

here is what we are working on:
if service.STATUS != PASSING then a acknowldegment button will appear next to the failed service in cabot.pushing it will "pause" notification for this service.
a celery tasks will check for how long the alert has been acknowledged, if time between acknowledgment and 'now' is greater than X
then it will trigger another notification and remove the acknowledgment status.
as we are by now, the task doesn't seem to be hard to build, but we will have to update django db model and change a bit the service status page.

Can't the check for acknowledgement just be part of the alerting logic?

@dbuxton I'm not sure to understand :-( would you please explain a bit what you are thinking about?

can we just add a DateTimeField alert_acknowledged_at to the Service model, and as part of the alerting logic (which already checks whether an alert has been sent in the recent past) do something like
if (timezone.now() - service.alert_acknowledged_at).total_seconds() < ACKNOWLEDGEMENT_SILENCE_DURATION * 60:
    # skip alerting

I'd also suggest having an alert_acknowledged_by attribute so that we know who is supposed to be taking care of the alert.
Alternatively we could put in a new AlertAcknowledgement model - that would be more powerful in the long run and would give an audit trail, which could be useful.
Does that make sense?

Nice!! Indeed I'll what I can achieve ;-) I'll keep in touch asap

Hi @xinity - because I thought this was a neat idea I had a stab at it - changes have landed in https://github.com/arachnys/cabot/commit/45449861503fdfc3a8dee04180803a3c057c505a
It basically just pauses alerts for a configurable amount of time (20 mins by default) and gives the service page a toggle so you can pause/resume alerts for that service.

Let me know what you think. It's best (though not necessary) to update plugins to support less intrusive notifications (that essentially say "x is working on it") via the send_alert_update method on the plugin - currently https://github.com/bonniejools/cabot-alert-hipchat/commit/5985c5cb55ef0f40df743807726b2411746f7dc8 does at version 1.7.0. (You will have to make sure that is the version being installed...)

I'll take a closer this weekend, nice job by the way