MOOSE Input Incorrect Parse of Multi-line String

Issue Description
What did you expect to see happen?
In my MOOSE input file I have a multi-line string:
type = ParsedFunction
function = 'rT := temperature / 1000.0;
            cp_f := 52.1743 + 87.951 * rT - 82.2411 * pow(rT, 2) + 31.542 * pow(rT, 3) - 2.6334 * pow(rT, 4) - 0.7139 * pow(rT, -2);
            cp_rho_fuel := 1.0e-6 * rho_fuel / M_fuel * cp_f;
            cp_rho_graphite := 1e-9 * rho_graphite / (11.07 * pow(temperature, -1.644) + 0.0003688 * pow(temperature, 0.02191));
            rho_UO2 * cp_rho_fuel + (1 - rho_UO2) * cp_rho_graphite'

It treats each line as if it was not part of the string. This could be a problem if someone was changing a matrix of values using Raven.
What did you see instead?
The new input spawned by Raven had: (the first line had the problem in #792 )
function = 'rT :
type = ParsedFunction
cp_f : = 52.1743 + 87.951 * rT - 82.2411 * pow(rT, 2) + 31.542 * pow(rT, 3) - 2.6334 * pow(rT, 4) - 0.7139 * pow(rT, -2);
cp_rho_fuel : = 1.0e-6 * rho_fuel / M_fuel * cp_f;
cp_rho_graphite : = 1e-9 * rho_graphite / (11.07 * pow(temperature, -1.644) + 0.0003688 * pow(temperature, 0.02191));
rho_UO2 * cp_rho_fuel + (1 - rho_UO2) * cp_rho_graphite'

It doesn't preserve the order (which is important for a multi-line string) and some other lines in the block can end up between the lines that were part of the string.
Do you have a suggested fix for the development team?
Not really, I suggest to check for an open ' and then end at the next '. I did find a work around: I could put the multi-line string on one line and it works (with the fix in #793 ). So perhaps taking a multi-line string and converting it to a single line string, first could work.
Please attach the input file(s) that generate this error.  The simpler the input, the faster we can find the issue.

For Change Control Board: Issue Review
This review should occur before any development is performed as a response to this issue.

[x] 1. Is it tagged with a type: defect or improvement?
[x] 2. Is it tagged with a priority: critical, normal or minor?
[x] 3. If it will impact requirements or requirements tests, is it tagged with requirements?
[x] 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
[x] 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure
This review should occur when the issue is imminently going to be closed.

[x] 1. If the issue is a defect, is the defect fixed?
[x] 2. If the issue is a defect, is the defect tested for in the regression test system?  (If not explain why not.)
[x] 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
[x] 4. If the issue is a defect, does it impact the latest stable branch? If yes, is there any issue tagged with stable (create if needed)?
[x] 5. If the issue is being closed without a merge request, has an explanation of why it is being closed been provided?

Closure checklist passed.
An email should be sent.
Closure approved via PR  #1204


Improve CI and makefile

Codecov Report

Merging #7 (547c5d6) into master (c502d8d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #7   +/-   ##
=======================================
  Coverage   39.06%   39.06%
=======================================
  Files           6        6
  Lines         256      256
  Branches       39       39
=======================================
  Hits          100      100
  Misses        150      150
  Partials        6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c502d8d...547c5d6. Read the comment docs.


Windows dockerfile: Changes to support git 2.10.1

Signed-off-by: John Howard<EMAIL_ADDRESS>Updates Dockerfile.windows to use the latest version of git for Windows. Post circa 2.7.2, the git installer changed, so to install unattended, it's necessary to employ some workarounds, the same as how the chocolatey installer does.
@thaJeztah @vdemeester @friism

The official golang Dockerfile installs Git 2.9.2 without writing to the registry. This seems to work with Git 2.10.1 as well.

It's to get the unix tools to the front of the path without having to set it manually


GPU program caching

Currently GPU programs are stored a GLSL or HLSL and then converted to necessary bytecode at runtime. This has become a problem since the renderer has grown with a variety of shader permutations - it takes a while to compile and evaluate everything (reflecting shader code seems to take the bulk of the time). Additionally on Windows, this requires the redistribution of d3dcompiler_47.dll, which feels hacky.
A better approach would be to compile the shaders when they are first imported, then share the bytecode and reflection data. This is possible for DirectX as it by default outputs in an intermediate bytecode format. For Vulkan something similar can be done by caching SPIR-V. For OpenGL this isn't possible unless we use SPIR-V extensions - it remains to be seen how widely are they supported.
However OpenGL can cache binary shaders, but they are not machine independant and cannot be distributed. So a separate shader caching mechanism could be introduced, that generates the required cache on first run (or during an install step) and then just reads them on following runs.

Added caching for DirectX bytecode and SPIR-V: 560b0c36907ea5f1a89304d98013da26ddbdbd81
Remaining tasks
[ ] Do not automatically trigger compilation on GpuProgram deserialization. Instead trigger compilation when requested. This should help with the compilation overhead further, as compilation can be deferred until actually needed, instead of compiling all shader variations at load time, whether used or not.
[ ] A a method that can warm up the shader cache. This is necessary when a shader is imported with one render backend (e.g. DirectX), but later loaded with another (e.g. Vulkan). The method should use the current render backend to generate the cache values for later use.
[ ] (Optional) Add a separate caching mechanism for OpenGL, which has no bytecode format that can be cached in a machine independent way. Perhaps not worth the time invested considering modern OpenGL is able to use SPIR-V.
[ ] (Optional) Clean up GpuProgram by removing compile status and compile messages, and instead make those byproducts of some compile step. Also perhaps remove GpuProgram source code text - it should not be required after initial compilation (but could be helpful for debug purposes).

Added delayed shader compilation: eb65bf33b6f768506f71ade3eb1e93e7d5aa3cb4
Shaders will no longer be compiled on load, meaning compilation can be skipped for any shader variations that are never used (most of them). Together with bytecode caching this results in a significant speed-up in engine start-up times.

Shader bytecode warmup added: b0d7c58cdc60cf9ba69d7952fd7ea65f90e4dfbc.
OpenGL caching has been moved to the longterm, as I don't think it is essential for now, see #61.


restored skipped tests

Pull Request Test Coverage Report for Build 898405128

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 90.628%

Totals

Change from base Build 898384289:
0.3%

Covered Lines:
1112

Relevant Lines:
1227

💛  - Coveralls


[FLOC-3457] Merge 1.7.2 docs into master

Flocker 1.7.2 contains back-ported changes from docs in master. These need to be re-merged into master to make the 1.7.2 release PR only contain changes to release notes.
Please check that this branch does no work when merged into master.
git merge remerge-docs-FLOC-3457 runs OK, but changes no files.
You can also check that the changes are only to the docs directory.

I'm seeing a whole bunch of diffs, so doesn't really seem like this does no work.

Are you merging into an up-to-date master?  The PR contains changes but they are copies of existing changes, so the result of a merge on the command line should be no files changed.

The problem is that git diff shows the patch to be applied, even if merging would eliminate the changes.  To see the real changes to master, use the following commands:
git checkout master
git merge --no-commit remerge-docs-FLOC-3457
git diff --cached

The final command will show no differences to be committed. (cleanup using git merge --abort).
(Try these commands with a different branch, and you will see that git diff --cached displays the actual changes to master.)

Confirmed, merge produces no text changes in master.  Please proceed.  Thanks.


Replace Manganese-55 flow in Polyol ether, for rigid foam polyurethane production, at plant

If this flow gets replaced in the FEDEFL (see https://github.com/USEPA/fedelemflowlist/issues/211), this single exchange will need to be revised with the new flow.

There is no kbq conversion for this flow so recommend just dropping this exchange (emission to water)

So I'll delete that exchange and the flow?

yes, it doesn't really make sense and we don't have a kbq to kg conversion for it.


Added DTOs and code style check

Do I understend correctly that files common.py, lessons.py, user.py are necessary for validation?

yes, DTOs are data transfer objects. Similar to serializers in Django. They define the objects which BE accepts from FE, validates they are of correct types and validate the values. Also they describe what BE returns. So when we add routers - we'll use them there to describe what BE expects to get for each endpoint and what sends back. Also it's easier to operate with those objects in Python code, than just with dictionaries


3D Grid Scans: Document co-ordinate systems

When doing 3D grid scans it is very easy to get confused over what co-ordinate systems are being used and how the fast grid scan code works.
Acceptance Criteria

There is a document that describes how this co-ordinate system works, with diagrams

closing for #42


Missed ec2:DescribeSecurityGroupRules

Describe the bug
Running pike against some of our terraform I noticed the IAM permission ec2:DescribeSecurityGroupRules was missing.
To Reproduce
I expect this is because we are using the aws_security_group_rule resource instead of inline security group rules.
Expected behavior
Expected ec2:DescribeSecurityGroupRules in pike output

indeed, thanks for taking the time to log it. Resolved in v0.3.17


Fix 27 Spelling errors

Why:

Supports #23188
A follow-up to #23189, as I was asked to create new PRs for any one-off spelling errors I found there.

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

[x] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

I didn't realize that the graphql files were off limits for docs. I'll modify the markdown file sonly.

👋 Hey again @SeanKilleen! Thanks for submitting this PR and updating it for the md files. We appreciate it!
I'll get this triaged for review :zap:


Please add more examples or use cases

Hey,
I found grovedb extremely useful however I have troubles to tell if it fits certain use cases, for instance now I'm trying to spike a data model to index whole Bitcoin into where I could use secondary indexes and SumTrees, just to spare some disk space and to have address balances automatically summed. Think of it as decentralized blockchain explorer.
I have a few concerns :

often I see that I would need tx_id to be both SumItem and a Reference at the same time
performance ... that the distribution of transactional data might not be a good fit for grovedb
references here does not make much sense as we just persist small hashes
I am not sure if Trees can be used as an alternative to composite keys as we know from Cassandra to avoid data duplication. Ie. if we can have billions of tx_id trees that each contain items or references.

Would you please give me some hints and suggestions as to this model? Overall I have a feeling that groveDB excels only in use cases when we store some "bigger" objects that we can reference by secondary indexes.
https://docs.google.com/document/d/1dql0MTMeu1-3PE_1CtSCc9mtHCi4PD8jhOZ7Ta_sTVQ/edit?usp=sharing

Sorry for not responding sooner, I hadn't seen your message. And we are releasing Dash Platform this month so I won't be able to go into great detail here.
GroveDB is extremely useful for provable data, where you can put data in the database and then have a merkle-ized proof of any data that you wish to query.
Indeed the sum tree usage here can be quite interesting as you can always verify that there is no inflationary issue.
As for performance, I wouldn't worry too much, in tests grovedb has been extremely fast. It's not going to be as fast as some tailored solutions, but I wouldn't worry all that much unless you are seeing a problem. Under the hood it uses rocksdb, and unless you are using proofs it uses an abstraction to not have to use the merkle trees and instead query directly to the underlying rocksdb. Now rocksdb isn't the most performant for reads, but I still wouldn't worry unless you are actually seeing issues.
The point of references is that they point to other data, so that if that data were to change it would still be pointing to it. Currently references are not bidirectional, so you need to manually know all your references and update them when you update data. While this seems like a very weird way to use them it's actually for performance. They were built for use cases of Dash Platform (which is why we built this database).
In your use case of non modifiable data they would be useful if the data you are pointing to is large, otherwise I would not use them as it takes more seeks to the database.
I am not exactly sure how composite keys work in cassandra, but in grovedb you can query and combine tree paths to get your data, hence getting secondary index type functionality.


Module to track button presses in GA

This module is intended as an easy way to track individual button/link
clicks as events in Google Analytics. Groups of buttons may end up
redirecting to the same place, meaning they’re not trackable via URLs
in GA. This will use the sendBeacon functionality to fire off an event
once the button has been clicked and during navigation.
The module should be added to the container of the buttons, where the
GA action can be changed from the default of button-pressed using the
data-track-action attribute. The label defaults to the link/button
text, but can be overridden with data-track-label.
/cc @fofr
Not sure where best to document the behaviour of this module and the available options?

Comments addressed and rebased


Pulling Streamgages from Nearby Sites

I'm trying to reference in discharge data near several sites where we collect discrete samples.  However, there are no discrete samples at the discharge site.  When I try to plot the discharge with the discrete samples, the hydrograph doesn't show up.  Is there a way to fix this?

If there are no discrete samples then discharge will not be pulled in because the Q values are only those stored in the discrete water-quality samples database, not continuous data.
On my to-do list is to bring in the continuous data, but currently that is on hold


Updiagonalstrike rendering issue in CommonHTML

There seems to be a minor issue with the placement of the updiagonalstrike in some complex fractions using CommonHTML (the display is accurate using the HTML+CSS renderer).  See this rendered equation for an example:

The AsciiMath generating this is
(1*(x+2)+1/cancel((x+2))*cancel((x+2)))/(x/cancel((x+2))*cancel((x+2))-3*(x+2))
If it would be helpful to paste in the generated MathML as well, let me know.
This was generated by MathJax 2.7.5 loaded via CDN.

Thanks!

In testsuite:
MathMLToDisplay/Presentation/GeneralLayout/menclose/issue2088.html


User Snippets not showing up in quickSuggestions

VSCode Version: Code 1.8.1 (ee428b0eead68bf0fb99ab5fdc4439be227b6281, 2016-12-19T14:49:23.350Z)
OS Version: Windows_NT ia32 10.0.14393
Extensions:

Extension
Author
Version

html-snippets
abusaidm
0.0.18

vscode-color
anseki
0.2.2

asp
ilich8086
0.0.1

htmltagwrap
bradgashler
0.0.3

vscode-html-css
ecmel
0.0.33

vscode-npm-script
eg2
0.1.8

vs-code-xml-format
fabianlauer
0.1.4

beautify
HookyQR
0.7.3

classic-asp
ilich8086
0.0.2

vscode-todo
MattiasPernhult
0.8.0

vscode-icons
robertohuertasm
7.1.2

Spell
seanmcbreen
0.9.1

JavaScriptSnippets
xabikos
1.2.0

html-css-class-completion
Zignd
1.0.3

Is anyone else having issues with user defined Snippets?
I am coding in basic HTML and I have the below HTML Snippets defined:
"Tech Option": {
        "prefix": "techoption",
        "body": [
            "<%=strTechOut%>"
        ],
        "description": "Tech Option"
    },
    "Tech All": {
        "prefix": "techall",
        "body": [
            "<option value=\"%\">All</option>",
            "<%=strTechOut%>"
        ],
        "description": "Tech All"
    },
    "Center": {
        "prefix": "centerthis",
        "body": [
            "<Center>",
            "   ${Data}",
            "</Center>"
        ],
        "description": "Places a center tag with caller to enter data in code"
    },
    "myOption": {
        "prefix": "myoption",
        "body": [
            "<option value=${Value}>${Text}</option>"
        ],
        "description": "Places an option tag with callers to enter data in code"
    },
    "mySelect": {
        "prefix": "mySelect",
        "body": [
            "<select id=${id} name=${name} size=\"1\">",
            "   <option value=${Value}>${Text}</option>",
            "</select>"
        ],
        "description": "Places a select tag with option block including callers in code"
    },
    "myNoWrap": {
        "prefix": "myNoWrap",
        "body": [
            " "
        ],
        "description": "Places a no wrap tag in code"
    },
    "Validation": {
        "prefix": "Validation",
        "body": [
            "validation=${Validation}"
        ],
        "description": "Enters a validation script into code."
    },
    "MyInput": {
        "prefix": "MyInput",
        "body": [
            "<input type=${Type} name=${Name} id=${Name} value=${Value}>"
        ],
        "description": "Enters a full input tag into code."
    },
    "MyDocument":{
        "prefix": "MyDocument",
        "body": [
            "document.getElementById(${ID})"
        ],
        "description": "Enters document java tag into code"
    }

When I type MySel or MyIn, the autoCompletions used to show my defined Snippets and allow me to select it.  Now, my Snippets aren't even showing up. I would attach an image to this but I also just noticed that when VSCode has the focus of my mouse, my PrintScreen button doesn't work so I can't capture the auto suggestions that are appearing in the list.

@BrandonRice sounds frustrating, thanks for reaching out! Unfortunately I can't seem to reproduce the issue. Just to be absolutely, positively sure we're doing the same thing - you have additional braces around the code block you provided, correct? (otherwise it's not valid json)
Assuming everything is a-okay on that front, a couple additional Qs:

Does this happen for just html snippets, or all snippet types?
Does it happen in all *.html files or only some of them?

Yes, I have extra braces around the code I sent in.
It's only happening on this one specific html file.  I tested it on 5 additional html files and the snippets work fine.  I reopen the file I'm working on updating and the snippets do not work.  Could it be an issue with the code prior to the snippets being called that is causing an error and forcing he snippets to not be triggered?

@BrandonRice Interesting. Does it work if you try changing the name of the html file? How about if you move it around? Any additional detail you could provide around what's special about this file would be awesome.

@BrandonRice Please check the developer console for errors and/or share both files as they are with me. Thanks

I'm guessing I must have had some issue with my code because I took the
time to rewrite the page and it works now.  Thank you for your time.
Thank you,
Brandon Rice
Web/Db Application Developer
Office:<PHONE_NUMBER>
On Tue, Jan 31, 2017 at 2:45 AM, Johannes Rieken<EMAIL_ADDRESS>wrote:

@BrandonRice https://github.com/BrandonRice Please check the developer
console for errors and/or share both files as they are with me. Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/19244#issuecomment-276306444,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGKdixofye8xvDTx9t5-EwF3obfD96pgks5rXvS-gaJpZM4Lsmcb
.

Ok. Thanks to getting back. Closing for now, please comment if you still see this


add "tracker" package to dependency

Also add EJSON package to dependency

I also wondered why I got errors with EJSON all the time. Please add ejson and tracker to dependencies


Ability to preload specific route

till date router package provides ability to prefetch all the routes at once. this enhancement will add ability to prefetch at route level

implemented ability to preload specific routes.
PS: if preloadAllRoutes flag is supplied, then all routes will be preloaded irrespective of specificity. so do not set the flag or set this flag as false to preload specific routes


Mention that nbcache is used by nbviewer

which wasn't clear. This looked like an inactive repo, but it's only inactive because it Just Works™.
Closes #1

Thanks Min!


Add full support for running on front page

Including top, new, gilded, controversial, hot, and ads.

Fixes #40


chore(deps): update dependency geerlingguy.docker to v6 (dev)

This PR contains the following updates:

Package
Type
Update
Change

geerlingguy.docker
role
major
5.2.1 -> 6.0.4

Release Notes

geerlingguy/ansible-role-docker
v6.0.4
Compare Source
v6.0.3
Compare Source
v6.0.2
Compare Source
v6.0.1
Compare Source
v6.0.0
Compare Source

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Renovate Ignore Notification
As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 6.x releases. However, if you upgrade to 6.x manually then Renovate will reenable minor and patch updates automatically.
If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.


Update Actions Secrets

The DISCORD_WEBHOOK_URL secret needs to be updated for the nightly build notifications, and a new secret with name DOCKERHUB_TOKEN_TLCPACKSTAGING needs to be created to allow the nightly builds to push to the tlcpackstaging dockerhub account.

i see DISCORD_WEBHOOK_URL already there, added DOCKERHUB_TOKEN_TLCPACKSTAGING

also updated DISCORD_WEBHOOK_URL, which was previously set to staging.


refactor(system-users) change config for system-user

Purpose
Secure setup of system users by default
Approach
system user name on a configuration variable. A default fallback value might be set.
system user password on a configuration variable. NO default fallback value should be set.
Changes checklist

system-user:
username: ${SYSTEM_USER_NAME:some-system-user-name}
password: ${SYSTEM_USER_PASSWORD}

Learning
https://issues.folio.org/browse/MODELINKS-135

Hi @TsaghikKhachatryan, please follow the conventional commit message format: https://wiki.folio.org/display/FOLIJET/Conventional+Commit+Initiative
It's okay for such issues to not have a body, but a footer is required, you have to specify the issue number in the commit message.
I will reject your PRs if commits will not be in the format.
If you need any assistance with this topic please ask.

brench name is incorrect


Switch e2e matmul tool to using explicit transfer operations instead of mapping.

iree-e2e-matmul-test.cc currently requires that all buffers are mappable into host memory in its routines to read, write, and compare memory. This worked on the local CPU path because all memory was local but in the recently added GPU path it was relying on the compiler and CUDA HAL using concurrently accessible shared memory. This was always sketchy but would work so long as the CUDA device had the CU_DEVICE_ATTRIBUTE_CONCURRENT_MANAGED_ACCESS cap - not all do (mine doesn't). Managed memory - especially concurrently accessible managed memory - is a big performance foot-gun and I'm working to remove our use of it - we originally had to support it because all of the tools mapped memory but now they've been updated and the matmul test is the last remaining user requiring it.
Instead of mapping the buffers for read/write/compare the tool should use one of the iree_hal_device_transfer_* methods:
https://github.com/google/iree/blob/c1d6af3f2b73de00e004a7d47df98ee23d8d9705/iree/hal/device.h#L211-L278
These allow for easy synchronous host<->device/device<->device transfers that are fine to use in tooling like this.
For initial buffer population the most efficient/easiest approach is to use iree_hal_buffer_view_generate_buffer:
https://github.com/google/iree/blob/77d32366715396797cc673653fe23d7ddabb899b/iree/hal/buffer_view_util.h#L71-L99
This will avoid extra allocations/copies if mapping is possible and otherwise setup the staging memory and perform the transfer as needed.
Basically, iree-e2e-matmul-test should not assume that any iree_hal_buffer_map_* methods will work. If a real application concerned with performance it could conditionally check to see if the buffer can be mapped and then take that path, but given that the operations are not performance sensitive and the sizes being copied are so small it'll be simpler to just use the utility methods.

If the IREE API allowed to write test that had a portability problem, it probably also allows for end-users' code to have portability problems. Maybe enabling non-universally-supported IREE_HAL_BUFFER_USAGE_ bits should be guarded by some explicit enabling mechanism. Maybe that could be connected to runtime device detection in some way.


Feature: include TypeScript definitions

Hi,
At the moment is not possible to cleanly integration this angular module with typescript, since there are not types available for it. (for example at:  https://github.com/DefinitelyTyped/DefinitelyTyped)
There is an easy way to do it, if only including the definitions directly as part of the package.
For example moment.js includes them
https://github.com/moment/moment/blob/develop/moment.d.ts
So something like:
dist/iso-3166-country-codes-angular.d.ts
Thanks.
PS: If you like, I can create them and make a pull request.

@igorlino Thanks for the issue, I'd love the PR if you could. I'm mostly integrating patches and releasing the software now :)

At least the service is covered, and would already give nice code autocompletion for the country 🥇

if, you like the change, would you be so kind to make a new minor release, so that I can consume it? thanks

Merged, I'll try to release soon. Ping me if you don't see progress, I might forget about it unwillingly :)


loss function

hello,
how do you define the loss function in training?
i didn't find this part.

This is not part of this repository. See https://github.com/joonson/syncnet_trainer


Provide a rich SQL editor as part of Caravel

Rough features:

Workspaces
Object browser (tables, views, columns, ...)
Tab
Rich text editor
Query templating
Query history
Async (create table as) processing

WIP PR:
https://github.com/airbnb/caravel/pull/514

@mistercrunch, let's break down the rough features of the Caravel SQL Editor into separate issues.

Rich text editor (folding, auto-complete, etc.) - the only feature left and it has it's on FR.


AWS: Make SSH public keys DRY

Currently we ask the user to provide a list of SSH public keys for both the controllers and the workers. Since it is likely that in most situations users would want to use the same key for both machine types, we should ask for one value and use it for both controllers and workers.
For the sake of flexibility, we could allow a per-worker-pool value while using the "global" set of keys by default.

@johananl For AWS, the ability to have a different set of ssh_keys for AWS needs changes  in the terraform code in assets/lokomotive-kubernetes
The user can still provide one value and use it in both places.
variable ssh_keys {}

cluster {
  ...
  ssh_keys = var.ssh_keys
  worker_pool "p1" {
  ...
  ssh_keys = var.ssh_keys
  }
}

For AWS, the ability to have a different set of ssh_keys for AWS needs changes in the terraform code in assets/lokomotive-kubernetes

Right. Are you saying this is a problem?

Providing same set of keys for the workers and controllers is what most users would want as well. So by default that should be our behaviour. Keys provided once should be used in other places. Right now this place could be most likely the controller section of the cluster.

We don't have a controller section under cluster though... But yes, your idea is what I had in mind: take a "global" set of keys and allow per-worker-pool overrides.

Seems similar to #578 and #356

So do we close this in favour of the others?

I'm not sure, all 3 issues seems similar to me and I cannot distill the specific difference between them from the top of my head :smile:

They all touch the same issue but are phrased differently AFAICT. Let's close this one (#358), rephrase the title of #578 to be clearer and add the content of #356 to #578 (applying the solution to both AWS and Packet).


HandleRequirementAsync is not called in AuthorizationHandler when resource is null

I have the following in the Startup.cs
services.AddAuthorization(options =>
{
    options.AddPolicy("EditPolicy", policy =>
        policy.Requirements.Add(new SameAuthorRequirement()));
});

services.AddSingleton<IAuthorizationHandler, DocumentAuthorizationHandler>();

and the following handler and requirement classes
using System.Threading.Tasks;
using Microsoft.AspNetCore.Authorization;
using ResourceAuthSample.Models;

namespace ResourceAuthSample
{
    public class DocumentAuthorizationHandler :
    AuthorizationHandler<SameAuthorRequirement, Document>
    {
        protected override Task HandleRequirementAsync(
            AuthorizationHandlerContext context,
            SameAuthorRequirement requirement,
            Document resource)
        {
            if (context.User.Identity?.Name == resource.Author)
            {
                context.Succeed(requirement);
            }

            return Task.CompletedTask;
        }
    }

    public class SameAuthorRequirement : IAuthorizationRequirement { }
}

then in my controller I have the following action
public async Task<IActionResult> Privacy()
{
    var document = new Document { Author = "Stuart" };

    // Setting the document to null ensures that the HandleRequirementAsync() is not called.
    // document = null;

    var authorizationResult = await _authorizationService.AuthorizeAsync(User, document, "EditPolicy");

    return View();
}

I was expecting that even if the resource (document) was null then the HandleRequirementAsync() method would still be called - in the event that you might want to base the success/failure on whether the resource is null.
But given this check (in AuthorizationHandler.cs)
https://github.com/aspnet/Security/blob/beaa2b443d46ef8adaf5c2a89eb475e1893037c2/src/Microsoft.AspNetCore.Authorization/AuthorizationHandler.cs#L51
will return false the method won't be called.
Looking at the IAuthorizationService, it states that "Resource is an optional parameter and may be null. Please ensure that you check it is not null before acting upon it." This seems to suggest that the resource might be null when checking in the handler, or have I misinterpreted that comment?
Microsoft.AspNetCore.App version is: 2.1.1.
dotnet --info output is:
.NET Core SDK (reflecting any global.json):
 Version:   2.1.401
 Commit:    91b1c13032

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.17134
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\2.1.401\

Host (useful for support):
  Version: 2.1.3
  Commit:  124038c13e

.NET Core SDKs installed:
  2.1.202 [C:\Program Files\dotnet\sdk]
  2.1.302 [C:\Program Files\dotnet\sdk]
  2.1.400 [C:\Program Files\dotnet\sdk]
  2.1.401 [C:\Program Files\dotnet\sdk]

.NET Core runtimes installed:
  Microsoft.AspNetCore.All 2.1.2 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.3 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.App 2.1.2 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.3 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 2.0.9 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.2 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.3 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]

To install additional .NET Core runtimes or SDKs:
  https://aka.ms/dotnet-download

Thanks,
Stuart.

@HaoK did this change in 2.1?

@HaoK / @Tratcher / @blowdart - any idea on this? Should this move to the Security repo?

I don't, which is why I tagged Hao. And yea, probably should be moved.

See this related issue for more details https://github.com/aspnet/Security/issues/1103


python311Packages.imap-tools: 1.4.0 -> 1.5.0

Description of changes
Diff: https://github.com/ikvk/imap_tools/compare/refs/tags/v1.4.0...v1.5.0
Changelog: https://github.com/ikvk/imap_tools/blob/v1.5.0/docs/release_notes.rst

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 270293 run on x86_64-linux 1

11 packages built:

deltachat-cursed
deltachat-cursed.dist
paperless-ngx
python310Packages.deltachat
python310Packages.deltachat.dist
python310Packages.imap-tools
python310Packages.imap-tools.dist
python311Packages.deltachat
python311Packages.deltachat.dist
python311Packages.imap-tools
python311Packages.imap-tools.dist


[Error] Expecting state 'Element'.. Encountered 'Text'  with name '', namespace ''.

I am unable to login after the PoE update. No changes have been made to my Procurement settings. The following is the output of my debug log;
[12-12-2015 10:41] System.Runtime.Serialization.SerializationException: Expecting state 'Element'.. Encountered 'Text'  with name '', namespace ''.
at ReadArrayOfRootObjectFromJson(XmlReaderDelegator , XmlObjectSerializerReadContextComplexJson , XmlDictionaryString , XmlDictionaryString , CollectionDataContract )
at System.Runtime.Serialization.Json.JsonCollectionDataContract.ReadJsonValueCore(XmlReaderDelegator jsonReader, XmlObjectSerializerReadContextComplexJson context)
at System.Runtime.Serialization.Json.JsonDataContract.ReadJsonValue(XmlReaderDelegator jsonReader, XmlObjectSerializerReadContextComplexJson context)
at System.Runtime.Serialization.XmlObjectSerializerReadContext.InternalDeserialize(XmlReaderDelegator reader, String name, String ns, Type declaredType, DataContract& dataContract)
at System.Runtime.Serialization.XmlObjectSerializerReadContext.InternalDeserialize(XmlReaderDelegator xmlReader, Type declaredType, DataContract dataContract, String name, String ns)
at System.Runtime.Serialization.Json.DataContractJsonSerializer.InternalReadObject(XmlReaderDelegator xmlReader, Boolean verifyObjectName)
at System.Runtime.Serialization.XmlObjectSerializer.ReadObjectHandleExceptions(XmlReaderDelegator reader, Boolean verifyObjectName, DataContractResolver dataContractResolver)
at System.Runtime.Serialization.Json.DataContractJsonSerializer.ReadObject(XmlDictionaryReader reader)
at POEApi.Model.POEModel.GetCharacters()
at Procurement.ViewModel.LoginWindowViewModel.<>c__DisplayClass2.b__1()
at System.Threading.Tasks.Task.Execute()

GGG have changed the API, I'll release an update asap to fix this.

Thanks, standing by.

Now running an unmodified Procurement 1.9.7. I have attempted logging in with Session ID. Login now fails returning a different error message;
Procurement 1.9.7 Initialized.
Authenticating shankapotimusrex                                                  [OK]
Loading characters...                                                                     [OK]
Loading Standard Stash Tab 1...
[Error] Downloading stash for Standard, details logged to DebugInfo.log, please open a ticket at     https://github.com/Stickymaddness/Procurement/issues
The following is the output of my debug log (My problem now appears to be identical to issue #322);
[14-12-2015 9:51] System.Runtime.Serialization.SerializationException: Expecting state 'Element'.. Encountered 'Text'  with name '', namespace ''.
at System.Runtime.Serialization.XmlObjectSerializerReadContext.HandleMemberNotFound(XmlReaderDelegator xmlReader, ExtensionDataObject extensionData, Int32 memberIndex)
at System.Runtime.Serialization.Json.XmlObjectSerializerReadContextComplexJson.GetJsonMemberIndex(XmlReaderDelegator xmlReader, XmlDictionaryString[] memberNames, Int32 memberIndex, ExtensionDataObject extensionData)
at ReadRootObjectFromJson(XmlReaderDelegator , XmlObjectSerializerReadContextComplexJson , XmlDictionaryString , XmlDictionaryString[] )
at System.Runtime.Serialization.Json.JsonClassDataContract.ReadJsonValueCore(XmlReaderDelegator jsonReader, XmlObjectSerializerReadContextComplexJson context)
at System.Runtime.Serialization.Json.JsonDataContract.ReadJsonValue(XmlReaderDelegator jsonReader, XmlObjectSerializerReadContextComplexJson context)
at System.Runtime.Serialization.XmlObjectSerializerReadContext.InternalDeserialize(XmlReaderDelegator reader, String name, String ns, Type declaredType, DataContract& dataContract)
at System.Runtime.Serialization.XmlObjectSerializerReadContext.InternalDeserialize(XmlReaderDelegator xmlReader, Type declaredType, DataContract dataContract, String name, String ns)
at System.Runtime.Serialization.Json.DataContractJsonSerializer.InternalReadObject(XmlReaderDelegator xmlReader, Boolean verifyObjectName)
at System.Runtime.Serialization.XmlObjectSerializer.ReadObjectHandleExceptions(XmlReaderDelegator reader, Boolean verifyObjectName, DataContractResolver dataContractResolver)
at System.Runtime.Serialization.Json.DataContractJsonSerializer.ReadObject(XmlDictionaryReader reader)
at POEApi.Model.POEModel.GetStash(Int32 index, String league, String accountName, Boolean forceRefresh)
[14-12-2015 9:51] JSON Serialization Failed: base64 bytes:
[14-12-2015 9:51] ZmFsc2U=
[14-12-2015 9:51] END
[14-12-2015 9:51] Error downloading stash for Standard, exception details: System.Exception: Downloading stash, details logged to DebugInfo.log, please open a ticket at https://github.com/Stickymaddness/Procurement/issues
at POEApi.Model.POEModel.logNullStash(Stream stream, String errorPrefix)
at POEApi.Model.POEModel.GetStash(Int32 index, String league, String accountName, Boolean forceRefresh)
at POEApi.Model.POEModel.GetStash(String league, String accountName)
[14-12-2015 9:51] System.Exception: Downloading stash for Standard, details logged to DebugInfo.log, please open a ticket at https://github.com/Stickymaddness/Procurement/issues
at POEApi.Model.POEModel.GetStash(String league, String accountName)
at Procurement.ViewModel.LoginWindowViewModel.LoadStashItems(Character character)
at Procurement.ViewModel.LoginWindowViewModel.d__6.MoveNext()
at System.Collections.Generic.List1..ctor(IEnumerable1 collection)
at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
at Procurement.ViewModel.LoginWindowViewModel.<>c__DisplayClass2.b__1()
at System.Threading.Tasks.Task.Execute()

Please try logging out of the forum, logging back in and then trying to login with the new sessionID, some users have reported that this fixed the issue.

My issue is resolved. I can't say if renewing the sessionID was useful or not....I discovered a typo in my account name. Matching my Procurement account name to my misspelled PoE account name finally allowed me to login...so uh, user error.
Thanks for your time & the API update.

Glad it's sorted, at least you've confirmed for me that incorrect account name can cause the issue.


fix use noOfReplicas as configured when settings index alias

1. Why is this change necessary?
Because you have a parameter %elasticsearch.index.config% which contains the settings that you want to have for your elasticsearch indices. This settings are used on index creation.
But when the indexing process is finished and the aliases are created, the setting number_of_replicas was hardcoded to 3 instead of using the previous settings.
2. What does this change do, exactly?
Respect the parameter containing the replicas setting.
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-9893
Please use this issue to track the state of your pull request.

Hey @hhoechtl
thank you for your contribution!
Your PR is now merged.


Move 'serve' back to dependencies for openshift

Signed-off-by: Patrick Uiterwijk<EMAIL_ADDRESS>

Note that I agreed with @beverloo to merge this after the AnimeNL con.

It does not look like it adds something to our production builds, so you can merge it now as well.


[makefile]: Changed PWD -> CURDIR. PWD omitted backslashes on the win…

…dows machine
Hope this does not mess up with other OS.

Let us know what else is required to fix the Windows build.

Thats the only thing necessary to build the default nutty firmware. The changes are only necessary, if the repo folder is not located at a top level directory.

Hmm is there a problem with it on mac. thougth yesterday it did pass-

Closing this, @dagar has fixed Windows on master since. Thanks!


VSCode Extension - Getting started - Download Sample App - Unsupported response type

The sample app setup does not set the response type to 'code' and thus throws an exception upon redirecting back.
Sample: ASP.NET Core

Hi @bolt-io Acknowledging this.

Hello @bolt-io, for ASP.NET it's a requirement to select ID tokens (under implicit grants and hybrid flows) for the app requesting tokens. Something that our VS Code extension doesn't do by default while registering the app on Azure. To unblock you (quick fix), please go to Azure click the app and select ID tokens in the Redirect URIs section. I will give this feedback to my team, to deliberate whether we can auto-select ID tokens on app registration for web apps (as a long-term solution).

Hi @emakuba, thanks for your response.
We know there's a whole plethora of security concerns with implicit grant, can the development team not just use the auth code flow with PKCE instead? It is supported with the packages the sample uses.
It's not very good for Microsoft samples to be using outdated auth flows that are out of scope for the next OAuth 2.1 iteration

Thanks @bolt-io for your suggestion, I will share it with my team for consideration.

@bolt-io I notified the sample team maintaining the ASP.NET core sample, they are working on a fix to support a more secure grant type (as a long-term solution). We made a transient fix to enable id token endpoint when downloading this sample, so users are now able to successfully sign-in after downloading the app.


Use Integer.MAX_VALUE instead for better readability

Hrm, I guess it's "better" ... though, I part of me thinks it's almost a bit of a coincidence that the the max size of a LOB of SQL Server is the same as the largest value of the type int in Java. Obviously it's not a complete coincidence, however.

Thanks


Update awesome_vendors.yml

Added Clickeys.nl as a vendor

Hmm something is not right with the ci. I'll check it out shortly.

Fixed! thank you!


[Feature Request] Add mob loot drops

I realize it's not within the purview of "gathering" per se, but it would be super helpful for levelling crafting classes that rely heavily on mob drops like ALC and LTW for functionality like what's available for gathering at the moment (being searchable, ability to teleport to closest aetheryte, mark location on map).

No.


New rule: space-around-prop-equals

I couldn't find a rule like this in the plugin or issues, but do tell me if it already exists.
This is a simple rule that would disallow/enforce spaces around the = in properties in jsx.
Values
"never":
// Error
<Component foo = {bar} />
<Component foo ={bar} />
<Component foo= {bar} />

// Allowed
<Component foo={bar} />

"always":
// Error
<Component foo={bar} />
<Component foo ={bar} />
<Component foo= {bar} />

// Allowed
<Component foo = {bar} />

Optionally, this rule could also have "before" or "after" values, which only allow a space before or after the equals sign (though that does seem very ugly to me).

Found it.


Track is missing introduction

The track page is showing the "TODO" text underneath the track title because no introduction has been added.

Thanks! ✨


Debugpy shouldn't depend on gdb on aarch64-darwin

Steps To Reproduce
Steps to reproduce the behavior:

On aarch64-darwin try opening nix-shell with such shell.nix

let
  wikiPackages = p: with p; [
    jupyter
    p.callPackage ./debugpy.nix
  ];
  wikiPython = pkgs.python3.withPackages wikiPackages;
in wikiPython.env

Build log
error: Package ‘gdb-12.1’ in /nix/store/xjnqi1lisxfwc48i91k1pl5sibmlp7lw-nixpkgs/nixpkgs/pkgs/development/tools/misc/gdb/default.nix:138 is not supported on ‘aarch64-darwin’, refusing to evaluate.

       a) To temporarily allow packages that are unsupported for this system, you can use an environment variable
          for a single invocation of the nix tools.

            $ export NIXPKGS_ALLOW_UNSUPPORTED_SYSTEM=1

        Note: For `nix shell`, `nix build`, `nix develop` or any other Nix 2.4+
        (Flake) command, `--impure` must be passed in order to read this
        environment variable.

       b) For `nixos-rebuild` you can set
         { nixpkgs.config.allowUnsupportedSystem = true; }
       in configuration.nix to override this.

       c) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
         { allowUnsupportedSystem = true; }
       to ~/.config/nixpkgs/config.nix.
(use '--show-trace' to show detailed location information)

Additional context
Removing gdb fixes the problem, but it definitely should be mainstreamed and given it's own subpackage or smth
Notify maintainers
@kira-bruneau
Metadata
 - system: `"aarch64-darwin"`
 - host os: `Darwin 22.2.0, macOS 13.1`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.12.0`
 - channels(root): `"nixpkgs"`
 - channels(weethet): `"darwin"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`

gdb is necessary for attaching to an already running process, but we can just gate this support by a flag and default it to false for aarch64-darwin!

Fixed in https://github.com/NixOS/nixpkgs/pull/216750 (since debugpy supports lldb as well).


Add Chess.app

Project URL
https://opensource.apple.com/source/Chess/Chess-410.4.1/
Category
Games
Description
Added the default Chess.app app that comes with macOS.
Why it should be included to Awesome macOS open source applications  (optional)
Because it's cool that Apple open sourced this, and it's still included with macOS. Most people don't know that it's open source.
Checklist

[x] Edit applications.json instead of README.md.
[x] Only one project/change is in this pull request
[x] Screenshots(s) added if any (Couldn't find any from Apple, got one from wikipedia)
[x] Has a commit from less than 2 years ago (The version from 11.0.1 is different from 11.5)
[ ] Has a clear README in English - not really, but there's a help book in Chess.app and it's included with every version of macOS.

@LinusS1 Thank you! 👍


Add support for image filters (nearest neighbor vs linear) to image rendering

The ImageViewer is a very useful way to let users pan and zoom an image. Because the ImageViewer supports zooming far in on an image, we have to consider how the image is rendered when highly zoomed-in. The default is bilinear interpolation, which is fine for many use cases. But when doing something like viewing pixel art (such as in iced's pokedex example), nearest neighbor might be preferred. This pull requests adds support for setting an Image or an ImageViewer to nearest neighbor rendering mode,
New files in this PR:

image_filter.rs in the iced_native crate, with the following contents:

The new enum ImageFilter, with NearestNeighbor and Linear variants
The new struct FilterOptions struct, with mag_filter and min_filter members

Changes to existing files in this PR:
Several files were changed to weave the new FilterOptions struct down into iced_wgpu's image renderer. Rather than hardcoding a texture sampler with nearest/nearest, the renderer now lazily constructs and caches samplers using a HashMap, based on which filters have been selected.
Finally, the Image and ImageViewer user-facing types were edited to add builder-pattern methods that specify the min and mag filter.
Before this gets merged, this will have to be ported to any other renderers - my goal with submitting this now is to gauge interest before doing the work of adding all this to another renderer. Let me know what you think and I can get started on the other one.

I think a simple Scaling enum with 2 variants (Smooth and Crisp) should be enough.
Smooth would be the current bilinear filtering strategy, while Crisp would use nearest neighbor.
Let's do that in a different PR!


Upgrade eslint v2.x -> v3.x

I've run into errors like the following, and they appear to be due to using an outdated version of eslint
/path/to/project/node_modules/eslint-to-editorconfig/node_modules/eslint/lib/config/config-file.js:402
            throw e;
            ^

Error: /path/to/project/node_modules/eslint-config-airbnb-base/rules/es6.js:
	Configuration for rule "arrow-parens" is invalid:
	Value "as-needed,[object Object]" has more items than allowed.

Referenced from: airbnb-base
Referenced from: /path/to/project/.eslintrc

Current version of eslint is 4.18.2 🙁

Hey there!
I released eslint-to-editorconfig v2.0.0 and deprecated old versions.
New version supports eslint>=2.0.0 and works as intended. Check README if you want to give it a shot.
P.S. I was total noob and I almost had no idea what I was doing in old versions 😔


Missing text in extensions menu

When checking the extensions menu section for SuccessStory, it looks like it can't find the correct variable to output text
This is on Playnite 9 and using the most recent version of the plugin

This has been fixed with 2.2 release, closing this


Local file is working on chromium based browsers but not on google chrome itself

i recently tried the extension on thorium browser which is open source , and the extension works fine for redirecting the local file
**Here is the sample screenshot to show that its working **

If the engine is fine there should be a way for it to work with chrome as well i think this happened after new chrome update . i hope this can help devs and if some one else is looking into it to fix this thanks

Local file access no longer works in Chromium or Brave

Enable "Allow access to file URLs" on extension details

Woohoo!  Really appreciate this, did't realize how central this is to my workflow and I just sent you a donation.
Because it took me a few minutes to find the setting, its in:
menu -> extentsions -> manage extenstions: new tab redirect DETAILS button then the "Allow access to file URLs"

Thanks for answering, folks. As part of #218 which required updating the extension to use manifest v3 (they don't allow publishing with v2 anyone) and new changes to chrome, this is an unfortunate side effect.


i18n typings (autocomplete in editor)

Is your feature request related to a problem?
Currently we need to know the possible i18n strings when we use i18n within our components.
With typing the editor would suggest possible options. This helps avoiding using wrong translation-strings.
Describe the solution you'd like
When typing i.e. t('translation.welcome.') we should see auto-completion suggestions (i.e. title & `nav).
This seems to be the way:
https://react.i18next.com/latest/typescript
Are you working on this?
No

Was solved with #1699


fixed panic in doc.values() - fixed concurrency bugs in range

doc.values() which was intended to iterate over the values in a list was calling range (for maps) and panicking.  There were no tests for doc.values() so this slipped through.  I've added tests and created a new query list_range.rs (possible range.rs should be renamed to map_range.rs).   While copying the code I found a bug in in Range.  When values were concurrent it would pick the first in the op range and not the last (but got it right when going in reverse).   I added breaking tests and then got them to pass.  I noticed the double ended iterator tracks a last_key and a last_key_back.  I have a feeling it would not behave correctly if we reversed a reverse in the middle an iteration (tests needeed) and also noticed that range iterates over all the elements - not making any effort to jump to the start of the range - or exiting when reaching the end of the range.  Seems needlessly slow.
Also seems like we should either merge range and values into a range_values( .., Range<Prop>) function or name them map_range_values() and list_range_values().
Also the range_at and list_range_at will not produce correct results if iterating over counters and increments.   I have some ideas on how to clean up the query code to address these issues (inspired by @jeffa5's iterator work).  Coming soon... but this fixes a serious bug so I wanted to get it in...

Thanks, this solves my issue! Closes #353

@orionz I ran into an issue with this. The following test fails:
#[test]
fn insert_at_index() {
    let mut doc = AutoCommit::new();

    let list = &doc.put_object(ROOT, "list", ObjType::List).unwrap();
    doc.insert(list, 0, 0).unwrap();
    doc.insert(list, 0, 1).unwrap();

    assert_eq!(doc.length(list), 2);
    assert_eq!(doc.keys(list).count(), 2);
    assert_eq!(doc.values(list).count(), 2); // it's just 1!
}


Crash cause by LWJGL: Unsupported JNI version

Issue details
When I RUN my LWJGL app in IDEA, it works well, but an warning was outputted by LWJGL:
[ThreadLocalUtil] Unsupported JNI version detected, this may result in a crash. Please inform LWJGL developers.
Then, if I DEBUG my app in IDEA, the JVM crashed.
Reproduction steps
Reproduction steps see Issue details.
I am using JDK 20, so I think it should be an issue related to the incompatibility between the Java version and the LWJGL version.
If I degrade my JDK to 18, the crash will not occur any more.
Version of libGDX
libGDX 1.11.0
Stacktrace
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  EXCEPTION_ACCESS_VIOLATION (0xc0000005) at pc=0x0000000000000000, pid=15672, tid=5648
#
# JRE version: Java(TM) SE Runtime Environment (20.0.1+9) (build 20.0.1+9-29)
# Java VM: Java HotSpot(TM) 64-Bit Server VM (20.0.1+9-29, mixed mode, sharing, tiered, compressed oops, compressed class ptrs, g1 gc, windows-amd64)
# Problematic frame:
# C  [jdwp.dll+0x1611f]
#
# No core dump will be written. Minidumps are not enabled by default on client versions of Windows
#

Please select the affected platforms

[ ] Android
[ ] iOS
[ ] HTML/GWT
[x] Windows
[ ] Linux
[ ] macOS

I think that is a lwjgl3 issue, not a libGDX one.
Also I do think, this has been resolved on lwjgl3 side with lwjgl3 3.3.2. You can either upgrade manually or you could try the latest libGDX snapshot, 1.11.1-SNPASHOT, that depend on the newest lwjgl3 version, if you really need java 20 features/API's.

Just rolled back Java version from 20 to 17 and debug works fine. Thanks


'pwhois' is not recognized as an internal or external command

windows7
Environment Variables have add scripts
'pwhois' is not recognized as an internal or external command

Unfortunately, I don't use Windows, and I have no idea what it entails to make Python scripts runnable on Windows (and can't test it either), or whether it's even possible at all.
Perhaps somebody else could chime in on this?


[BREAKING] Remove StandardMaterial.ambientTint

Marked as breaking as it has a potential to change the brightness of the scene. The workaround is to set the tint to WHITE.

remove the ambientTint property, and make it behave as always true
change the default value from grey to white, to make it a noop when multiplied by the scene ambient

This one potentially has the biggest chance to affect scenes (compared to diffuseTint and emissiveTint).
Tested projects with this code:
editor.assets.list().filter((a) => {
    return a.get('type') === 'material'
        && a.get('data.ambientTint') === false
        && (a.get('data.ambient.0') !== 1 || a.get('data.ambient.1') !== 1 || a.get('data.ambient.2') !== 1);
}).length;

In our existing projects, it will affect 70-100% of materials.

Yep, same as with the other tints, we'll process the project as they switch to V2 of the engine, and if the ambientTint was false, we'll set the ambient color to 1,1,1. So that should solve majority of Editor projects.


this should be litematica not carpet

Well found, thanks!

Well I originally added the carpet parent to litematica-printer upstream, so I am partly to blame....

No worries. I tried to merge your Pull request and somehow i managed to do it in 2 commits instead of one.

If you merge with a merge commit (equivalent to git merge) you get a merge commit. If you rebase-merge, (similar to git rebase) you dont get a merge commit but all PR commits are individually there. If you squash-merge (equivalent to git merge --squash) all commits in the PR are merged into one commit.
For this PR, since there is only one commit, rebase-merging and squash-merging does the same thing, and would both work if you want to avoid a merge commit.

Ow thanks a lot!


Add operations_access_level flag to projects

@svanharmelen I've got another PR for you :)
This flag was added in the most recent release of GitLab

Looks good, but I think we should then also add the field to the create and edit structs. Right?

Looks good, but I think we should then also add the field to the create and edit structs. Right?

Looks good, but I think we should then also add the field to the create and edit structs. Right?

Yes, good call. Added that as well

Looks good, but I think we should then also add the field to the create and edit structs. Right?

Yes, good call. Added that as well


Ability to multiple image attachment columns and embeds

I wondering if we can have something similar to Airlift's--attachment-columns.
We can have multiple --image-column.
CSV2Notion Neo will embed the image to each Notion pages based on the order.

Done!


Width and height incorrect on IOS when orientation changes.

I believe #24 introduced a bug. I'm testing against Simulated iPhone X.
Below are widths and heights returned from _currentWidth and _currentHeight methods, respectively.
Portrait:
widths: [375, 375, 375]
heights: [635, 635, 812]
Landscape:
widths: [724, 724, 375]
heights: [375, 325, 812]
Going by the logic in _currentWidth and _currentHeight, the smallest value will always be used returned regardless of orientation. E.g. width will always be 375 and height will always be 325.
My meta viewport content looks like:
<meta name="viewport" content="width=device-width, initial-scale=1">

@robert-j-webb In your fix, what meta viewport content are you using?

Reference info: https://stackoverflow.com/questions/1649086/detect-rotation-of-android-phone-in-the-browser-with-javascript/6603537#6603537
The SO above leaves me questioning the reliability of window.screen.width.

@rwwagner90 @runspired @robert-j-webb any thoughts on this?
I vaguely remember @runspired saying that matchMedia was too aggressive, but wondering if we can leverage its implementation to fix the issue without being as aggressive...?

@GCheung55 I don't know much about this, off the top of my head. I'm open to proposed solutions.

I propose to remove the addition of window.screen.width and window.screen.height because those never change on orientation change - they represent the device's screen width and height in portrait mode.

@GCheung55 I am totally open to whatever solution works for you. Would you mind opening a PR?


[REQ] Custom Installation Path

Acknowledgement of preliminary instructions

[X] I have read and acknowledged the preliminary instructions.

What idea do you have?
So, what I want to do is to be able to change the installation path of roblox. For example, since there is a way of using reshade now (with NVIDIA gpu's), you need the RobloxBetaPlayer name to be changed to eurotrucks2 (im assuming its just changing the name to a game that is compatible with NVIDIA's filter feature) but, every time I do this with the bloxstrap installation it just installs a new roblox and ignores my last one

-Example of it just ignoring the renamed roblox

This is already planned, but the new update won't be out for a while. What you can do in the meantime is disable automatic updates, and install this test build that I made which just tested this functionality out. https://github.com/pizzaboxer/bloxstrap/suites/17761020689/artifacts/1017388973

This is already planned, but the new update won't be out for a while. What you can do in the meantime is disable automatic updates, and install this test build that I made which just tested this functionality out. https://github.com/pizzaboxer/bloxstrap/suites/17761020689/artifacts/1017388973

Hello, the link for the test build doesnt work anymore

Works fine for me? You need to be logged into GitHub to access it.

oh nevermind your right thank you

This is already planned, but the new update won't be out for a while. What you can do in the meantime is disable automatic updates, and install this test build that I made which just tested this functionality out. https://github.com/pizzaboxer/bloxstrap/suites/17761020689/artifacts/1017388973

the link doesnt work anymore, i have login allready

This is already planned, but the new update won't be out for a while. What you can do in the meantime is disable automatic updates, and install this test build that I made which just tested this functionality out. https://github.com/pizzaboxer/bloxstrap/suites/17761020689/artifacts/1017388973

the link doesnt work anymore, i have login allready

This is an old issue the link has expired.

the link doesnt work anymore, i have login allready

Oh, right.
Actually, I'll create a 2.5.4 variant in a moment, since I might as well, and it'll just take a few minutes.

https://github.com/pizzaboxer/bloxstrap/actions/runs/7854168779/artifacts/1235392896
You'll still need to disable automatic updates when using this.
Mirror is available at https://files.pizzaboxer.xyz/bloxstrap-debug/release/version-2.5.4-nvidia.zip.

How do i use this version to make sure that "eurotrucks2.exe" (renamed roblox) can be used?
Do I have to uninstall Bloxstrap and re-install it in order to receive the prompt to change the executable being run?
If that is the case, will there eventually be a change so that you can change the executable without the need to uninstall Bloxstrap?

How do i use this version to make sure that "eurotrucks2.exe" (renamed roblox) can be used?
Do I have to uninstall Bloxstrap and re-install it in order to receive the prompt to change the executable being run?
If that is the case, will there eventually be a change so that you can change the executable without the need to uninstall Bloxstrap?

How does have any relationship with custom install paths??

Do I have to uninstall Bloxstrap and re-install it in order to receive the prompt to change the executable being run?

...No, just run the thing.

i swapped the bloxstrap exe on my install with this one, it installs the game as eurotrucks2, but when i run it via bloxstrap, nvidia doesn't recognize the game as supported, unless i run the game manually from its exe

but when i run it via bloxstrap, nvidia doesn't recognize the game as supported

Try disabling all the integrations given in the Bloxstrap Menu.

Hey, I finally did it and achieved the Nvidia Filters for Roblox, but now it seems like the FPS unlocker feature of Bloxstrap don't seem to work (while other work well).
Is there a way to fix this so you have both filters and unlimited FPS together ?

Are you using https://bloxshade.com?

yeah


[RFC] URI usabilty

Currently usage is ugly like:
uri = URI.new("http://example.org/foo")
client = HTTP::Client.new(uri.host.not_nil!, uri.port || 80)
client.get(uri.path || "/")

HTTP::Server.new(8080) do |request|
  if request.path.not_nil!.starts_with? "/hello"
    # ...
  else
    # ...
  end
end

path
Currently URI#path returns nil to indicate the absence of a path. RFC 3986 Section 3.3 states:

A path consists of a sequence of path segments separated by a slash
("/") character.  A path is always defined for a URI, though the
defined path may be empty (zero length).  Use of the slash character
to indicate hierarchy is only required when a URI will be used as the
context for relative references.  For example, the URI
<EMAIL_ADDRESS>has a path of<EMAIL_ADDRESS>whereas
the URI foo://info.example.com?fred has an empty path.

Following this by returning the empty string for path would make usage in contexts where there's a path guaranteed easier. For the client example above however, with uri = URI.new("http://example.org") it would break (GET HTTP/1.1 is invalid). However HTTP::Client could rewrite "" to "/", curl does this too.
port
We could hardcode common ports matching the protocol. However there might be unknown protocols and thus it would remain nilable, on top of the inconsistency of sometimes returning the implicit port value. The latter inconsistency could be reduced to a minimum by parsing /etc/services though, perhaps even at compile time so the runtime cost is kept low.
foo, foo? accessors
Most usages will probably remove the nilables with runtime raising not_nil! calls, in particular for cases where there's no sensible default value, like host. Should we make this more convenient by turning all of these into getter!s?

For the client part here are two less uglier options:
# 1.
client = HTTP::Client.new "example.org"
client.get "/foo"

# 2.
HTTP::Client.get "http://example.org/foo"

The thing is, if the URI is hardcoded then for the reader it's obvious that some things aren't nil, and so the not_nil! checks become redundant. Remove that hardcoded string and then it's worth stopping and thinking a few seconds the case where some properties might be nil.
For request.path I'd make Request#path be "/" when the underlying uri's path is nil. I wouldn't change URI#path to an empty string for the nil case. For example OAuth::Signature has to use "/" for the nil case. Maybe we can use "/" then, but I don't know if that brings another problem.
For the port, I don't know. We could make port raise on nil and provide port?, and have a hardcoded list of scheme -> default port (or even better: register that at runtime or compile time). I wouldn't use /etc/services because then a program's behaviour changes depending on the contents of that file, so programs become non-portable between different machines (the same is true for any run macro, but run macros usually use files located in the same project).

@asterite

Maybe we can use "/" then, but I don't know if that brings another problem.

Pretty much every scenario and framework where path is return as empty string, it is immediately changed to "/" to properly workout routing and format the response.
However, URI is also used for non-hierarchical URI's (like mailto) where path being returned as "/" might be a problem.

@jhass Should we make Request#path return "/" if it's nil or empty then? We can do bits of this issue and relate the commits.

I guess that would be fine with me. I'd still also make HTTP::Client handle "" as "/" though.

Perhaps it's better to opt for the "correct way" and handle it specifically when needed (OAuth etc.)?
When working with urls, when using 3rd party mods, I've grown used to use "ensure_slash" and "de_slash" depending on the case because of inconsistencies. Well.

Closing in favor of #4954


feat: eip7691 fraction update

Missed that BLOB_BASE_FEE_UPDATE_FRACTION_ELECTRA  got an update in this EIP. h/t @klkvr

Tests are failing cause of obsolete tests for the Prague fork.


Could NOT find Boost (missing: unit_test_framework) (found version "1.71.0")

I need to use boost unit_test_framework, and what I am doing to find boost and the required libs is:
find_package(Boost REQUIRED COMPONENTS unit_test_framework)
target_link_libraries (Boost_Tests_run Boost::unit_test_framework)
I get this error: Could NOT find Boost (missing: unit_test_framework) (found version "1.71.0")
Note: I have built the boost libs!
What can I do to fix it?

@glenfe Thanks for transferring the issue here!
@Amjad95 I believe you found a resolution of this in https://github.com/boostorg/test/issues/240, I am closing the issue. Feel free to reopen if needed.


MI300: run_high_level_pipeline: Invalid MLIR created

Error observed in TIMM torch benchmark model: eca_halonext26ts
Full message:
terminate called after throwing an instance of 'migraphx::version_2_10_0::exception'
  what():  /workspace/tm_benchmarks/AMDMIGraphX/src/targets/gpu/mlir.cpp:729: run_high_level_pipeline: Invalid MLIR created: Error: !migraphx.shaped type can't be laid out in memory when the stride 144 at index 1 does not evenly divide the previous stride 96
Error: failed to legalize operation 'func.func' that was explicitly marked illegal
Note: see current operation:
"func.func"() <{function_type = (!migraphx.shaped<128x128x8x8xf16, 8192x64x8x1>, !migraphx.shaped<128x640x1x1x12x12xf16, 92160x144x96x8x12x1>) -> !migraphx.shaped<1024x1x64x144xf16, 9216x9216x144x1>, sym_name = "mlir_reshape_transpose_reshape_transpose_reshape_transpose_slice_transpose_dot"}> ({
^bb0(%arg0: !migraphx.shaped<128x128x8x8xf16, 8192x64x8x1>, %arg1: !migraphx.shaped<128x640x1x1x12x12xf16, 92160x144x96x8x12x1>):
  %0 = "migraphx.mlir.as.logical.shape"(%arg0) : (!migraphx.shaped<128x128x8x8xf16, 8192x64x8x1>) -> tensor<128x128x8x8xf16>
  %1 = "migraphx.mlir.as.logical.shape"(%arg1) : (!migraphx.shaped<128x640x1x1x12x12xf16, 92160x144x96x8x12x1>) -> tensor<128x640x1x1x12x12xf16>
  %2 = "tosa.reshape"(%0) <{new_shape = array<i64: 1024, 16, 1, 8, 1, 8>}> : (tensor<128x128x8x8xf16>) -> tensor<1024x16x1x8x1x8xf16>
  %3 = "tosa.const"() <{value = dense<[0, 1, 3, 5, 2, 4]> : tensor<6xi64>}> : () -> tensor<6xi64>
  %4 = "tosa.transpose"(%2, %3) : (tensor<1024x16x1x8x1x8xf16>, tensor<6xi64>) -> tensor<1024x16x8x8x1x1xf16>
  %5 = "tosa.reshape"(%4) <{new_shape = array<i64: 1024, 16, 64, 1>}> : (tensor<1024x16x8x8x1x1xf16>) -> tensor<1024x16x64x1xf16>
  %6 = "tosa.const"() <{value = dense<[0, 3, 2, 1]> : tensor<4xi64>}> : () -> tensor<4xi64>
  %7 = "tosa.transpose"(%5, %6) : (tensor<1024x16x64x1xf16>, tensor<4xi64>) -> tensor<1024x1x64x16xf16>
  %8 = "tosa.reshape"(%1) <{new_shape = array<i64: 1024, 80, 1, 144>}> : (tensor<128x640x1x1x12x12xf16>) -> tensor<1024x80x1x144xf16>
  %9 = "tosa.const"() <{value = dense<[0, 2, 3, 1]> : tensor<4xi64>}> : () -> tensor<4xi64>
  %10 = "tosa.transpose"(%8, %9) : (tensor<1024x80x1x144xf16>, tensor<4xi64>) -> tensor<1024x1x144x80xf16>
  %11 = "tosa.slice"(%10) <{size = array<i64: 1024, 1, 144, 16>, start = array<i64: 0, 0, 0, 0>}> : (tensor<1024x1x144x80xf16>) -> tensor<1024x1x144x16xf16>
  %12 = "tosa.const"() <{value = dense<[0, 1, 3, 2]> : tensor<4xi64>}> : () -> tensor<4xi64>
  %13 = "tosa.transpose"(%11, %12) : (tensor<1024x1x144x16xf16>, tensor<4xi64>) -> tensor<1024x1x16x144xf16>
  %14 = "tosa.reshape"(%7) <{new_shape = array<i64: 1024, 64, 16>}> : (tensor<1024x1x64x16xf16>) -> tensor<1024x64x16xf16>
  %15 = "tosa.reshape"(%13) <{new_shape = array<i64: 1024, 16, 144>}> : (tensor<1024x1x16x144xf16>) -> tensor<1024x16x144xf16>
  %16 = "tosa.matmul"(%14, %15) : (tensor<1024x64x16xf16>, tensor<1024x16x144xf16>) -> tensor<1024x64x144xf16>
  %17 = "tosa.reshape"(%16) <{new_shape = array<i64: 1024, 1, 64, 144>}> : (tensor<1024x64x144xf16>) -> tensor<1024x1x64x144xf16>
  %18 = "migraphx.mlir.as.underlying.shape"(%17) : (tensor<1024x1x64x144xf16>) -> !migraphx.shaped<1024x1x64x144xf16, 9216x9216x144x1>
  "func.return"(%18) : (!migraphx.shaped<1024x1x64x144xf16, 9216x9216x144x1>) -> ()
}) {arch = "gfx942:sramecc+:xnack-", enable_splitk_for_tuning = true, kernel = "mixr", num_cu = 304 : i64} : () -> ()

Aborted (core dumped)

To Repro:
migraphx-driver compile /mnt/nas_share/migraphx/models/torch_benchmarks/eca_halonext26ts/eca_halonext26ts.mxr

This seems to have its root in an MIGraphX-only bug in the pad operator.  The following test case in test_ref fails:

TEST_CASE(pad_test)
{
    migraphx::program p;
    auto* mm = p.get_main_module();
    migraphx::shape s{migraphx::shape::float_type, {8192, 8, 23}};
    std::vector<float> ones(s.elements(), 1.0f);
    auto l0 = mm->add_literal(migraphx::literal{s, ones});

    mm->add_instruction(migraphx::make_op("pad", {{"pads", {0, 0, 0, 0, 0, 1}}}), l0);
    p.compile(migraphx::make_target("ref"));
    auto result = p.eval({}).back();
    std::vector<float> results_vector(16);
    result.visit([&](auto output) { results_vector.assign(output.begin(), output.end()); });
    std::vector<float> gold{0, 0, 0, 0, 0, 1, 2, 0, 0, 3, 4, 0, 0, 0, 0, 0};
    EXPECT(migraphx::verify::verify_rms_range(results_vector, gold));
}

It fails with the following message:
terminate called after throwing an instance of 'migraphx::version_1::exception'
  what():  /workspace/pt2_benchmarks/AMDMIGraphX/src/include/migraphx/operation.hpp:366: compute_op: Not computable: pad
Aborted (core dumped)

Above replication code is non-operative:  that error happened on server hyd-7c-ZT09-02 and doesn't replicate elsewhere.  It seems to be independent of this issue.

Note to self:  the following reduced pass list in target::get_passes() AMDMIGraphX/src/targets/gpu/target.cpp replicates the fail.   All 3 of these passes must be present to create the error:
return
    {
        enable_pass(mlir_enabled(), fuse_mlir{&ctx}),
        lowering{&ctx, options.offload_copy},
        compile_ops{&ctx, options.exhaustive_tune},
    };

Note to self:  adding the following  tostruct softmax_compiler : compiler:69
        if(axis < 0)
            axis += inputs.front().ndim();

solves one bug, but failures continue when we revert to the full pass list (see above)

I haven't verified that this fix will also work on an MI300--will get on that now.


Feature request: Handle UTF-8 mode

Motivation
Rust works with strings in UTF-8, so supporting it would make &str work natively(?) as long as a null terminator is added.
https://docs.microsoft.com/en-us/windows/apps/design/globalizing/use-utf8-code-page
Drawbacks
It's only supported on Windows 10, and as far as i understand it requires extra steps in order to activate it,
so it can't just be a "feature" i believe, at least not in how it all works atm.
Rationale and alternatives
It would go hand in hand with string in Rust,
the alternatives are either &[u8] which is somewhat easy to work with, but limited to ANSI,
the other is &[u16] which is not that easy to work with and requires helper methods etc to be friendly.
Additional context
No response

Note: Unfortunately this requires both the app and the OS to opt-in, making this effectively unreliable and unavailable (from a targeting user machines standpoint).

Note that if you specify the alloc feature, you can pass &str (UTF-8) values to Windows APIs with PWSTR parameters and it will perform the conversion for you.

Yeah really unfortunate that it's opt in, but thought i might as well bring it up to see what the great minds had to say haha:P
And true, it will behave mostly "rust"ly with alloc, thanks.


Effect g:enable_spelunker_vim_on_readonly option for nomodifiable

Besides readonly, shouldn't it consider nomodifiable setting?
Some plugins may set only nomodifiable without readonly for no-modification-expected buffers
(e.g. fugitive G log window).

Add &filetype ==# 'qf' check, too.
With quickfix list manage plugins such as vim-qfedit,
quickfix list and location list may be &modifiable.


Azure DevOps Server 2019 docs imply step targets are available

Multiple pages (below and here) indicate that step targets are available in Azure DevOps Server 2019.
This appears to not be the case. The YAML pipeline editor in Azure DevOps Server 2019 does not recognize the target property of a task and according to the Features Timeline step targeting and command isolation is scheduled for Future. It is not possible to queue a YAML pipeline with tasks that have a target property:
Could not queue the build because there were validation errors or warnings.
/infra/azure-pipelines.yaml (Line: 20, Col: 5): Unexpected value 'target'

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7458d5b2-1bb7-7d87-7ce6-2b0c430b0155
Version Independent ID: edf5bbd3-a3f0-5426-e985-31290f8afd05
Content: YAML schema - Azure Pipelines
Content Source: docs/pipelines/yaml-schema.md
Product: devops
Technology: devops-cicd
GitHub Login: @steved0x
Microsoft Alias: sdanie

Step targets shipped with Azure DevOps 2020. Good catch!

@steved0x it would be great to have the docs updated as soon as possible as this has also caught out me and my customer 👎


Update config-cheat-sheet.en-us.md

Fixing a sentence in the config cheat sheet doc.

Codecov Report

Merging #7046 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7046      +/-   ##
==========================================
+ Coverage   41.44%   41.45%   +0.01%
==========================================
  Files         442      442
  Lines       59597    59597
==========================================
+ Hits        24700    24707       +7
+ Misses      31668    31660       -8
- Partials     3229     3230       +1

Impacted Files
Coverage Δ

routers/repo/view.go
43.03% <0%> (+1.01%)
:arrow_up:

modules/log/colors_router.go
87.5% <0%> (+4.16%)
:arrow_up:

models/unit.go
67.56% <0%> (+5.4%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a722ae...0bed328. Read the comment docs.


Create divyansh-gupta.md

Notes for Reviewers
This PR fixes #
Signed commits

[ ] Yes, I signed my commits.

🚀 Preview for commit d82af342f845e37d7445287511784c5d5fb84129 at: https://66fe9b25f506649fac1b87aa--meshery-docs-preview.netlify.app

🚀 @divyansh351


Track "Account migration"

This is a request to add a new row (called Device migration) to the spreadsheet that tracks whether or not a user can migrate their account between devices by exporting a backup of their account data (including private keys and message history) and then import that backup into a new install on a distinct device.
Problem
For a cryptographic communication system, it's critical that users authenticate their contacts to ensure that they're sending messages to the correct person (not someone pretending to be them).
If, however, a user changes devices and doesn't migrate their private keys -- then prior authentication checks are lost.
Solution
To fix this issue, many apps (eg Threema) have the ability for users to make a backup of their account's private keys -- so that users can migrate their account from an old device to a new device, without all their contacts loosing their out-of-band authentication verification.
Some other apps (eg Signal) store private keys in the TPM and intentionally make it impossible to make a backup of an account's private keys -- so that users cannot migrate their accounts from an old device to a new device.
A new row (called Active migration) should display if an app allows users to export a backup of their account's private keys (and, optionally, their message history) so that they can migrate their account between devices without breaking prior out-of-band authentication checks by their contacts.

This is a good suggestion and something we missed when coming up with the criteria.
I really appreciate the detailed issue and effort you put in. I'll work on implementing it, and the site should be updated in a few hours.


No easy way to turn off SI certification check

Right now most the the objects in antidote are CRDTs that don't need to abort in the presence of concurrent updates.  For these objects there should be no SI certification check as it will just cause unnecessary aborts and wasted CPU cycles.
Currently the only way to turn on or off the certification check it to comment it out in the code.  Some branches have it commented out and some do not.  Maybe there is a better way to do this?  For example only do certification check depending on the object?  We will have to precisely define what kind of consistency we want to guarantee though.

+1, we need this.
On Wed, Jun 10, 2015 at 10:23 AM, tcrain<EMAIL_ADDRESS>wrote:

Right now most the the objects in antidote are CRDTs that don't need to
abort in the presence of concurrent updates. For these objects there should
be no SI certification check as it will just cause unnecessary aborts and
wasted CPU cycles.
Currently the only way to turn on or off the certification check it to
comment it out in the code. Some branches have it commented out and some do
not. Maybe there is a better way to do this? For example only do
certification check depending on the object? We will have to precisely
define what kind of consistency we want to guarantee though.
—
Reply to this email directly or view it on GitHub
https://github.com/SyncFree/antidote/issues/131.

Following the mumble discussion today, the next step for this is to come up with a specification for how and when the certification check should be used.  Implementing the decided specification will also solve issue 130 ( https://github.com/SyncFree/antidote/issues/130 ).
Some initial thoughts for the specification:

The certification check should be disabled by default as we are targeting CRDTs and causality.
Choosing whether to certify or not could be done based on object type (for example the bounded counter would have it enabled, while the other CRDTs would not).
Another possibility would be to give the programmer the ability to enable or disable it in application code.  This might be per object, per transaction, per workload.

The begin_transaction construct contains a parameter "red/blue".  Blue has no certification check.  Furthermore, per CRDT type, operations are classified as red or blue (possibly depending on parameters).   A blue transaction may not contain any red operations.
					Marc

Le 30 juin 2015 à 17h44, tcrain<EMAIL_ADDRESS>a écrit :
Following the mumble discussion today, the next step for this is to come up with a specification for how and when the certification check should be used. Implementing the decided specification will also solve issue 130 ( #130 https://github.com/SyncFree/antidote/issues/130 ).
Some initial thoughts for the specification:
The certification check should be disabled by default as we are targeting CRDTs and causality.
Choosing whether to certify or not could be done based on object type (for example the bounded counter would have it enabled, while the other CRDTs would not).
Another possibility would be to give the programmer the ability to enable or disable it in application code. This might be per object, per transaction, per workload.
—
Reply to this email directly or view it on GitHub https://github.com/SyncFree/antidote/issues/131#issuecomment-117233886.

I agree - ideally you would want to be able to specify that a transaction
should have SI check or not, but then you would like to be able to say that
the check is only done for some objects (those where you have executed one
operation that requires strong consistency).
Having said that, all this flexibility might not be that easy to code and
some compromise may be needed - e.g. whenever a strong object (e.g. bounded
counter) is used, SI check is done (independently of the executed
operation).
On Tue, Jun 30, 2015 at 4:49 PM, marc-shapiro<EMAIL_ADDRESS>wrote:

The begin_transaction construct contains a parameter "red/blue". Blue has
no certification check. Furthermore, per CRDT type, operations are
classified as red or blue (possibly depending on parameters). A blue
transaction may not contain any red operations.
Marc

Le 30 juin 2015 à 17h44, tcrain<EMAIL_ADDRESS>a écrit :
Following the mumble discussion today, the next step for this is to come
up with a specification for how and when the certification check should be
used. Implementing the decided specification will also solve issue 130 (
#130 https://github.com/SyncFree/antidote/issues/130 ).
Some initial thoughts for the specification:
The certification check should be disabled by default as we are
targeting CRDTs and causality.
Choosing whether to certify or not could be done based on object type
(for example the bounded counter would have it enabled, while the other
CRDTs would not).
Another possibility would be to give the programmer the ability to
enable or disable it in application code. This might be per object, per
transaction, per workload.
—
Reply to this email directly or view it on GitHub <
https://github.com/SyncFree/antidote/issues/131#issuecomment-117233886>.

—
Reply to this email directly or view it on GitHub
https://github.com/SyncFree/antidote/issues/131#issuecomment-117235290.

In addition, if you offer so much flexibility, then the programming model becomes very complex.
The semantics of transactions with respect to their isolation would become non-composable, I guess.
Is this really what we want?
For example, you have the SI check for an object enabled in one txn but not in another.
What does this mean?
Programmers are having lots of trouble understanding SI - they seem to prefer either strong (i.e. serializable) or kind of no guarantees.
Annette

On 30.06.2015, at 18:01, preguica<EMAIL_ADDRESS>wrote:
I agree - ideally you would want to be able to specify that a transaction
should have SI check or not, but then you would like to be able to say that
the check is only done for some objects (those where you have executed one
operation that requires strong consistency).
Having said that, all this flexibility might not be that easy to code and
some compromise may be needed - e.g. whenever a strong object (e.g. bounded
counter) is used, SI check is done (independently of the executed
operation).
On Tue, Jun 30, 2015 at 4:49 PM, marc-shapiro<EMAIL_ADDRESS>wrote:

The begin_transaction construct contains a parameter "red/blue". Blue has
no certification check. Furthermore, per CRDT type, operations are
classified as red or blue (possibly depending on parameters). A blue
transaction may not contain any red operations.
Marc

Le 30 juin 2015 à 17h44, tcrain<EMAIL_ADDRESS>a écrit :
Following the mumble discussion today, the next step for this is to come
up with a specification for how and when the certification check should be
used. Implementing the decided specification will also solve issue 130 (
#130 https://github.com/SyncFree/antidote/issues/130 ).
Some initial thoughts for the specification:
The certification check should be disabled by default as we are
targeting CRDTs and causality.
Choosing whether to certify or not could be done based on object type
(for example the bounded counter would have it enabled, while the other
CRDTs would not).
Another possibility would be to give the programmer the ability to
enable or disable it in application code. This might be per object, per
transaction, per workload.
—
Reply to this email directly or view it on GitHub <
https://github.com/SyncFree/antidote/issues/131#issuecomment-117233886>.

—
Reply to this email directly or view it on GitHub
https://github.com/SyncFree/antidote/issues/131#issuecomment-117235290.

—
Reply to this email directly or view it on GitHub https://github.com/SyncFree/antidote/issues/131#issuecomment-117238581.

Le 30 juin 2015 à 18h33, Annette Bieniusa<EMAIL_ADDRESS>a écrit :
For example, you have the SI check for an object enabled in one txn but not in another.

That would not be possible with the API I propose: methods are classified as red or blue, and a red operation requires a red transaction.
					Marc


Problem adding leaflet map object with dynamically appended div

Hello.
I'm facing many problems with dynamically appenden div's which using for leaflet map
for example
$(document).body.append("

");

var map2;

  var cartodbUrl = 'https://cartodb-basemaps-{s}.global.ssl.fastly.net/dark_all/{z}/{x}/{y}{r}.png',
      cartodb = L.tileLayer(cartodbUrl, {
        maxZoom: 7
      }),
      map2= new L.Map("map2", {
        center: new L.LatLng(51.505, -0.04),
        zoom: 7
      }),
      drawnItems = L.featureGroup().addTo(map2);

    L.control.layers({
      "osm": L.tileLayer('http://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png', {
        attribution: 'osm'
      }),
      'cartodb': cartodb.addTo(map2),
      "google": L.tileLayer('http://www.google.cn/maps/vt?lyrs=s@189&gl=cn&x={x}&y={y}&z={z}', {
        attribution: 'google'
      })
    }, {
      'drawlayer': drawnItems
    }, {
      position: 'bottomleft',
      collapsed: true
    }).addTo(map2);

    map2.on('click', onMapClick2);

Tehere is no problem to seeing map on screen. New map seems good. But when i need to access map2 object im getting undefined error.
I have no problem with non dynamically created divs. I can see those divs as map object on console.
for example (dynamically appended div)
**function onMapClick2(e) {
console.log(map2);    // map2 is undefined... Why? i defined it and created a map pobject before.
}**

hello. I didn't see you answer because i was working on a jsfiddle sample
http://jsfiddle.net/h50k1gmn/
Can you check this sample please.
-- click create new map button
--  click on a map
and press f12 and lokk to console.
you can see map2 is not map object. because i created it programmatically.

sorry i edited my answer. i wrote wrong jsfiddle link.

@spider58 there are multiple map instances in the fiddle, but your issue seems to describe the issue related to dynamically created div for single map.
Looks like you've mixed up two issues together.

@cherniavskii hi.
I want to define map events such as mouseclick, mouseover etc. one time and use them for all map objects.
So, i  have 2 or more map instance thats depends on clients choice. I must append new div for leaflet map object and convert them to a map object when client needs new map.
do you have a solution for this issue? because we cannot acces map features because of divs cannot being map object. Working good on screen, we can see map but as i said we cannot access map features
thanks inadvance

Please ask questions on gis.stackexchange.com or stackoverflow.
If you believe it's a Leaflet bug - feel free to submit an issue with good description and example which reproduces the issue.
Regarding fiddle you've provided - not a Leaflet bug.
You've written onMapClick function to always add marker to first map (.addTo(map)).

@cherniavskii problem is not adding marker to map. problem is map2 object is not map object

map2 is reference to DOM node with the same id (that's how DOM works). Try to name variables with names other than container id - and the issue will gone.
But again, that's not specific to Leaflet, it's how JavaScript works.

@cherniavskii
http://jsfiddle.net/h50k1gmn/3/
can you check updated link please. i changes variable name from map2 to mapxx . at this time im getting "mapxx is not defined" error on console. console.log(mapxx);
Thanks inadvance

@cherniavskii
i want to add a marker to map which i clicked with mouse. how can i do that.

@cherniavskii
i found problem, codes must be in a function and variables must defined outside ot this function.
worked fiddle here
http://jsfiddle.net/h50k1gmn/4/
thanks


Package request: tui-logger

Project description
Logger with smart widget for the tui and ratatui crate

Metadata

homepage URL: https://github.com/gin66/tui-logger
source URL: https://github.com/gin66/tui-logger
license: mit,
platforms: unix, linux, darwin

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

Isn't this a Rust library?

yes, built with rust, though an executable, not a lib

No, it is a lib. There are no binaries available; you cannot install it with cargo install.

To add on top of that, there is no src/main.rs nor any [[bin]] entries in the Cargo.toml. There are example executables, but this is fundamentally just a library and you can use those just fine with Cargo natively without Nix.


RequestFailedException includes error information #3398

Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.

[ ] C++ Guidelines
[X] Doxygen docs
[X] Unit tests
[X] No unwanted commits/changes
[X] Descriptive title/description

[X] PR is single purpose
[ ] Related issue listed

[X] Comments in source
[X] No typos
[ ] Update changelog
[X] Not work-in-progress
[X] External references or docs updated
[X] Self review of PR done
[X] Any breaking changes?

Fixes #3398

Also, consider adding a changelog entry to mention that the FailedRequestException what() is now enhanced to provide more information from the http response

Related: https://github.com/Azure/azure-sdk-for-cpp/pull/3193#issuecomment-1009289192
See Jeff's comment and review if this change won't go against the guidelines mentioned in there


So many errors!

I'd really like to get this example running to help me with my own project, but as the README says it's become outdated and now there's a litany of errors. As a newcomer I'm not familiar with the old outdated API so I can't fix this easily myself.

I would love to keep this up to date, but unfortunately I'm too busy with other more pressing things right now, so this likely won't be updated anytime soon.
In the meantime, I'll happily accept pull requests and if you ask nicely on https://gitter.im/snowkit/public I'm sure the fine folks there will be able to help you sort things out.


Execution starts from the beginning on changing kernel

I installed nb_conda_kernels in the base environment using
conda install nb_conda_kernels
I created the configuration file for jupyter
Running 'jupyter kernelspec list' returned this output:
[ListKernelSpecs] WARNING | Config option `kernel_spec_manager_class` not recognized by `ListKernelSpecs`.
Available kernels:
  conda-env-delight-py          /home/raya/.local/share/jupyter/kernels/conda-env-delight-py
  conda-env-pymc_env-py         /home/raya/.local/share/jupyter/kernels/conda-env-pymc_env-py
  conda-env-pystan_env-py       /home/raya/.local/share/jupyter/kernels/conda-env-pystan_env-py
  conda-env-python_3_gpss-py    /home/raya/.local/share/jupyter/kernels/conda-env-python_3_gpss-py
  conda-root-py                 /home/raya/.local/share/jupyter/kernels/conda-root-py
  python3                       /home/raya/anaconda3/share/jupyter/kernels/python3

I hope the installation is fine as in my Jupyter Notebook, under the tab 'kernel -- Change Kernel', all the kernels can be seen.
But every time I change kernel in the notebook, execution starts from the beginning.
For example, I started a notebook, changed to the 'delight' kernel, and imported delight in the first cell. Then if I want to import pymc in the next cell, on changing the kernel to pymc_env, the notebook restarts.
What could have possibly gone wrong here?

A kernel is the reflection of a Python environment. They are isolated from each other (as expected for environment). So a notebook document is meant to be executed within the same kernel.
To take an analogy with a Python script, you can run
(env1) $ python my_script.py

or
(env2) $ python my_script.py

But it is impossible to run my_script.py, partially with env1 and env2.

Ok, thanks, I got the point!


gvc: do not keep test files if they contain legal words

This file hasn't been removed in opencontainers/image-spec just because it contained a license prefix:
vendor/github.com/go-openapi/spec/license_test.go

Check for _test.go before actually saying it's a legal file.
Signed-off-by: Antonio Murdaca<EMAIL_ADDRESS>

@runcom LGTM. Thanks!