Type refinement information is "lost" within callbacks that are known to be executed immediately

Consider the following fragment (http://tryflow.org/#b86b73b2deee7f1be526f6c32c227ab2):
var arr: ?Array<number> = [];
if (arr) {
  arr.sort(); // ok
  [1,2,3].forEach(num => arr.push(num)); // Flow error: arr can be null
}

Within the if block Flow knows that arr cannot be null. However when it comes to executing the callback within forEach, that information is no longer known.
Of course, for arbitrary callback-accepting functions this is a right thing to do -- however Array's iterators are not arbitrary: they are executed immediately and synchronously. Given their ubiquity, it would be nice if Flow knew about Array's map, filter, forEach, etc. and propagated any type information into the callbacks accepted by these functions.

If you use const, Flow will keep the refinement even in the callback. We still don't have a way to annotate a callback as immediately invoked, so leaving this open.

Seems like another instance of this error:
    coversAll(vv: ?string | ?VVector): boolean {
        if (!vv) {
          return true;
        }
        if (!(vv instanceof VVector)) {
            vv = new VVector(vv);
        }
        var keys = Object.keys(vv.map)
        var map = this.map;
        return keys.every(function(key){
            return map.hasOwnProperty(key) && map[key] > vv.map[key];
        });
    }

fails with:
src/VVector.js:104
104:             return map.hasOwnProperty(key) && map[key] > vv.map[key];
                                                                 ^^^ property `map`. Property cannot be accessed on possibly null value
104:             return map.hasOwnProperty(key) && map[key] > vv.map[key];
                                                              ^^ null

src/VVector.js:104
104:             return map.hasOwnProperty(key) && map[key] > vv.map[key];
                                                                 ^^^ property `map`. Property cannot be accessed on possibly undefined value
104:             return map.hasOwnProperty(key) && map[key] > vv.map[key];
                                                              ^^ undefined

src/VVector.js:104
104:             return map.hasOwnProperty(key) && map[key] > vv.map[key];
                                                                 ^^^ property `map`. Property not found in
104:             return map.hasOwnProperty(key) && map[key] > vv.map[key];
                                                              ^^ String

This doesn't require annotating callbacks as immediately executing, does it?

Flow is doing the right thing here. What if:
arr.sort = () => {
  arr = null;
};

In this case you could not push to null. As @samwgoldman recommended, you need to make arr const and this error can’t happen 😊
@andreypopp your case is similar since arguments are not constant by default. If you’d like we have a setting that makes Flow assume that all arguments are constant. experimental.const_params .


Add collection details to collections api

It adds collection details getter to collections api.
With API:
collections.getDetails({ ... })
With hook:
useCollectionDetails({ ... })

Task linked: SALEOR-135 Get collection details


FunctionID should be an enum

FunctionID.java (in package com.smartdevicelink.protocol.enums) should be defined as an enum instead of a class.

Merged.


ROX-22818: Move automation-flavor image version to a Chart annotation

This will make it easier to update the image versions consistently.
Note for reviewers:

Some workflows have fields with "{{workflow.parameters...}}". The double quotes are necessary to avoid interpretation of the {{ as objects and subsequent YAML parsing errors. I switched to single quotes ', because helm expects double quotes for its templating engine, "{{...}}" becomes '{{ "{{" }}...{{ "}}"}}'. Where unnecessary, I removed doubles quotes, e.g. "--argument={{ ... }}" does not need the double quotes, because it is interpreted as a string. enjoy the review :'(
All flavors were smoke tested in the latest version, see #1208 for details. There is https://github.com/stackrox/automation-flavors/pull/216 pending with two fixes.

Agreement in team sync: @tommartensen does a manual smoke test for all flavors before merging this PR.

static should be renamed now right?

eventually maybe.


Add new redbus: time to sleep

Associated Issue: #121
Summary of Changes

Added new rebus with:

symbols: ['🕐', '+', '2', '+', 'zzz']
words: ['time', 'to', 'sleep']
hints: ['when you are about to go to bed']

Pull Request Test Coverage Report for Build 919

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.143%

Totals

Change from base Build 514:
0.0%

Covered Lines:
158

Relevant Lines:
180

💛  - Coveralls


Add pdfioArrayRemove and pdfioDictClear APIs

PDFio does not support the dictionary key removal or iteration directly. I have been working around this using the pdfioDictSetNull function, could we add an another function to support dictionary key removal directly

Proposed APIs:
void pdfioArrayRemove(pdfio_array_t *array, size_t n);
void pdfioDictClear(pdfio_dict_t *dict, const char *key);

to fix your trouble check this solution click
maybe this will solve your problem.

Micheal, I want to try to solve this issue, to solve it, I have a doubt on how to approach this solution.
I have no idea of how I can do the pdfioArrayRemove,
but for the pdfioDictClear, I am thinking of making a new PDF file, then going through all the objects, and when the object of the Dict comes, I iterate through the keys of dictionary, and the key which we want to remove, I would skip that key.
is this solution good, or is there any different way I should do it?

@uddhavphatak These functions would only manipulate the array or dictionary in memory, so re-loading the PDF isn’t the approach to take.

[master afac835] Add pdfioDictGetKey and pdfioDictGetNumPairs APIs (Issue #63)


Can't get telnet to D-LINK DPN-100 Rev C1

I have purchased D-LINK DPN-100 Rev C1 and I am trying to use it on a Turris Omnia with OpenWrt 23.05.2 but I cannot connect via telnet.
I have configured the eth2 interface in the range <IP_ADDRESS>/24:
config interface 'ont'
	option device 'eth2'
	option proto 'static'
	option ipaddr '<IP_ADDRESS>'
	option netmask '<IP_ADDRESS>'

The interface is up and running:
# ifconfig eth2
eth2      Link encap:Ethernet  HWaddr XX:XX:XX:XX:XX:XX
          inet addr:<IP_ADDRESS>  Bcast:<IP_ADDRESS>  Mask:<IP_ADDRESS>
          inet6 addr: fe80::da58:d7ff:fe00:60c1/64 Scope:Link
          UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
          RX packets:21 errors:0 dropped:0 overruns:0 frame:0
          TX packets:1021 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:1024
          RX bytes:1374 (1.3 KiB)  TX bytes:276760 (270.2 KiB)
          Interrupt:48

Ping to <IP_ADDRESS> responds correctly:
# ping -c 3 <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>): 56 data bytes
64 bytes from <IP_ADDRESS>: seq=0 ttl=64 time=0.586 ms
64 bytes from <IP_ADDRESS>: seq=1 ttl=64 time=0.465 ms
64 bytes from <IP_ADDRESS>: seq=2 ttl=64 time=0.448 ms

--- <IP_ADDRESS> ping statistics ---
3 packets transmitted, 3 packets received, 0% packet loss
round-trip min/avg/max = 0.448/0.499/0.586 ms

But I cannot connect via telnet:
# nc <IP_ADDRESS> 23
nc: can't connect to remote host (<IP_ADDRESS>): Connection refused

Am I forgetting something?
Can you give me some help @stich86, @simonebortolin, @nanomad, @Andreag00

Shit!
Thanks @stich86. Any recommendation for an ONT with open access to be able to "change the PLOAM (if possible in hexadecimal format)?

You can buy ODI or LEOX stick, both can enter PLOAM on hex without problem on latest firmware :)

Oops, all ODI or LEOX with SFP format have SC/UPC optics, I would need SC/APC...

Just get a converter or a cable that is UPC/APC :)

I like the ODI DFP-34X-2C2 but I can't find it at a decent price (more than 100€), it's only cheaper on Alibaba where I have never bought and may end up needing to pay import fees (I bought the D-LINK DPN-100 Rev C1 for 7€ used, from Italy).
Any opinions about the Technicolor AFM0003? I can buy it for 19.90€ used, from Italy. Do you know if it have telnet closed in any version of firmware? It seems that it is possible to connect to it using UART, I don't know if I can find more information on how to do it (The HSGMII doesn't seem to work, but I'm not sure if I need it. My Internet connection is 500Mb and I receive 3 VLANs).
Thanks again @stich86.

yes AFM0003 from TIM or FWB has telnet\ssh enabled, do no get ILD version that has everything closed

I already have the Technicolor AFM0003 and I can connect via telnet (without username or password) perfectly.

Ummmh ok. This is a good problem.

The echo -ne "" trick doesn't work with all hexadecimal PLOAMs, fails with those with \x00 (NULL) in the middle like mine.
For example using this PLOAM f1230000045678900000 when checked with diag gpon get password-hex has been transformed into f1230456789000000000.
I will close this topic, but if anyone has any ideas or knows of any firmware for Realtek RTL9601CI that accepts PLOAM in hexadecimal format, let me know (I can try to replace omci_app en el rootfs).

No sorry, only odi...


Geocoding address to coordinates are incorrect.

Expected behavior
To be given correct long/lat for given address.
Actual behavior
The long/lat given is up to 500m off (15 mins walking time).
Steps to reproduce
I've noticed this issue in Vietnam. Addresses that I geocoded in the U.S. were geocoded perfectly. However, when doing viet addresses they are way off. The odd part is, when entering any of these addresses in google maps, the correct location is given. However, when entering them into the geocoder, ive noticed theyre off by about 300-500m which is a lot in a dense city.
Try geocoding one of these addresses. You'll notice the location is incorrect. Compare with the correct location in maps.
"150 Phạm Văn Bạch, phường 15, Quận Tân Bình, Thành Phố, Hồ Chí Minh, VN"
"150 Phạm Văn Bạch,Thành Phố, Hồ Chí Minh, VN"
"150 Phạm Văn Bạch,Hồ Chí Minh, VN"
Environment info

Geocoder version: 1.6.3
Ruby version: 2.7.x
Rails version: N/A. Using Sinatra 2.0.8.
Database (if applicable): sqlite3
Lookup (if applicable):

The Geocoder gem provides access to more than 40 geocoding APIs ("lookups"). The APIs convert addresses to lat/lon coordinates. If you're getting coordinates, Geocoder is working. If those coordinates aren't what you're looking for, you might want to try a different API. Each lookup will perform differently in different parts of the world.


Update Gradle multi-module project example.

Showcase compatibility of Gradle 5 preview feature around improved Maven BOM dependency constraints.
Verify that the latest Gradle Arquillian adapter changes are working as expected.

Please merge this after the base PR on Thorntail has been merged: https://github.com/thorntail/thorntail/pull/1152


Multiplexing clients

Hi,
I was able to run server and client side of snmpfwd and now want to realize the final configuration.
It should be one central server and two clients on two hosts. Two clients are connected to two identical applications with the same oids. Now I want to map the same OIDs at the hosts to different OIDs at the server. This way it would be possible to query the server for different OIDs and get the response from the right host.
I got the idea of trunks so far, but not sure how to get the mapping between the trunks and OIDs going.

Good progress so far!
However it seems the scenario you have in mind would need some tweaking. I just checked the code - neither per-OID matching nor request OID rewriting is currently implemented. But it can be done and it would be a good feature!
Meanwhile, can you use something other than request OID as a routing condition?

I'm glad I was able to describe my scenario in a meaningful way and that you found the use case interesting.
I could use two server instances on different ports on same host and have each instance talk to one client only but that would be an ugly workaround. This is what I could think of at the moment.

You do not need to server instances for that. Instead you can have a single server listening on two distinct ports (or NICs), then routing incoming requests based on the transport endpoint ID that received this query.
The other way would be to use different SNMP community or SNMPv3 context names.
Either way you'd end up with one server instance talking to a pair of clients.
But you are right - routing based on PDU context and rewriting it on the fly would be way more usable!

Routing based on snmp community or cotext name would be the good interim solution. Thank you for the idea!
In the final configuration I want to have two servers on different hosts under the same dns name for failover reasons. I did not look in to it in details yet but I assume it should be possible for clients to talk to multiple servers.

It is indeed possible to connect many clients to many servers via trunks and vice versa.

Great, I will start with community or context solution first and will migrate to OID routing once it will become available. Thank you.

One more thing - is it possible for client to run some shell/perl/python script based on requested OID and return the stdout from script as OID value? Something like in nagios nrpe?


virtualbox: change --virtualbox-boot2docker-url to --virtualbox-iso

This changes --virtualbox-boot2docker-url to --virtualbox-iso.
Closes #1147.
For example:
docker-machine create -d virtualbox \
    --virtualbox-iso https://github.com/rancherio/os/releases/download/v0.3.1-rc2/machine-rancheros.iso \
    test-rancher

It's a good start, but it also needs to be updated for the hyperv, vmwarefusion, vmwarevsphere drivers.

Mmm, also, all of those have struct parameters which are called some variant of d.Boot2DockerURL which needs to be updated as well.

I purposely didn't update them because I'm not sure they are all supported.  I guess it would be up to the provisioners to make sure to support the various bits.  I originally just did this for vbox as that was what the issue was for and didn't want to make sweeping changes across the drivers.  Perhaps we should just back out until we really know what this all touches.


Looks good

I am looking at miniPHP to possibly use for a small site, You documented very well.

Thanks. But, this is not really an issue :)


Can you provide a Javadoc parsing for service classes? Some shared development JAR packages are also expected to generate development documentation through Smart-Doc.

Summary(关于这个pr的描述)
For example, when developing a toolkit, we hope to automatically generate the toolkit development documentation through a doc tool. The complete documentation is generated by parsing the comments on the implementation classes. The difference from the current controller parsing is that it does not involve URLs.
比如开发个工具包，希望通过doc工具自动形成工具包开发文档。通过对实现类的注释解析完整的文档。和目前controller解析的区别只在于有无url。

@musarona 你可以参考使用这个：https://github.com/apideploy-team/apideploy-jakarta-client

I have the same hope. develop a new template like dubbo seems difficult.
我也希望有相同的功能。开发一个类似 dubbo 的 template 似乎不是很容易。

@tuichenchuxin Support can be added in the future. If you are interested, you are also welcome to participate in the community co-building. The implementation idea can refer to #795.

@tuichenchuxin 也没有那么复杂，有兴趣可以一起探讨下

@shalousun @jingxiang Thank you very much for your reply. I am very happy to participate in the co-construction of this idea.


Changes to Ship detection notebook

Proposed changes
Checklist (replace [ ] with [x] to check off)

[X] Remove any unused Python packages from Load packages
[X] Remove any unused/empty code cells
[X] Remove any guidance cells (e.g. General advice)
[X] Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended)
[X] Include relevant tags in the first notebook cell and re-use tags if possible
[X] Ensure appropriate colour schemes  have been used to maximise accessibility for vision impairment. Test your images or learn more with Coblis or TPGI
[X] Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated

Closes issues (optional)

Closes Issue #000

Great work @mpho-sadiki , everything is working.


TypeError when running inference

My training code looks like the following:
model_subcategories = SetFitModel.from_pretrained("all-minilm-l6-v2")

trainer_subcategories = SetFitTrainer(
    model=model_subcategories,
    train_dataset=ds_train_sub,
    eval_dataset=ds_test_sub,
    loss_class=CosineSimilarityLoss,
    batch_size=8,
    column_mapping={"processed text": "text", "subcategory": "label"},
    num_iterations=20,
    num_epochs=1
)

trainer_subcategories.train()
model_subcategories.to("cpu")
model_subcategories.save_pretrained('SetFitModel')

However, when I open the trained model and try to run inference using the following code:
from setfit import SetFitModel

model = SetFitModel('SetFitModel')
model(['Text Example'])

I run into the following error:
TypeError: encode() takes at most 2 arguments (3 given)

Hello!
This encode method is called here:
https://github.com/huggingface/setfit/blob/b503c0b80b1fce800380e8e9092ab0ad14ae8889/src/setfit/modeling.py#L430-L434
with the three arguments. model_body is a SentenceTransformer instance from UKPLab's sentence-transformer library:
https://github.com/UKPLab/sentence-transformers/blob/master/sentence_transformers/SentenceTransformer.py#L111
I suspect that perhaps you're using an outdated version of that package. Could you check pip show sentence_transformers. I'm successfully using 2.2.1 myself.

Tom Aarsen

When using the version 2.2.1 of sentence-transformers the error still persists.

What version of SetFit are you using? I'll try to chase this down when I have some more time.

Right now I am using the 0.6.0 version

I still get this error with setfit 0.7.0 and sentence_transformers 2.2.2.

Replacing
model = SetFitModel('SetFitModel')
with
model = SetFitModel.from_pretrained('SetFitModel')
fixed this for me.

Ohh, that's exactly it. Well spotted @MattiL.


Polygon2D (with multiple parts) fails to mask with Clip Children when Inverted on

Tested versions
Reproducible in: 4.3-dev5, 4.2.1-stable, 4.1.3-stable
System information
Godot v4.2.2.rc3 - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2070 SUPER (NVIDIA; <IP_ADDRESS>52) - Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 Threads)
Issue description
When using a Polygon2D of multiple parts (using the Polygons array to define them via their point indices), it will correctly mask its children when Clip Children is set to Clip Only. However if you Invert the polygon, the masking fails to give the expected 'opposite' result. It doesn't matter if the boxes are created clockwise or anticlockwise.
I hope this is a legal and valid method of doing this.. I'm using this video as a guide... https://www.youtube.com/watch?v=NvJuW7ruuN0

Steps to reproduce
We need to make a Polygon2D whose points define two separate boxes and use the Polygons array to define them via their indexes 0-3 for one and 4-7 for the other.

In a new scene, add a Polygon2D and create a box with 4 points.
In the inspector for the polygon, manually add 4 more points with Add Element for a total of 8. Drag these new points to form a second box to the side (see picture).
In the Inspector, under the Data/Polygons section, increase the array Size to 2.
For each array, change the type from null to PackedInt32Array.
Under the first PackedIn32Array, add 4 elements and insert values 0 to 3
Under the second PackedIn32Array, add 4 elements and insert values 4 to 7
Drag the gogot icon.svg into the viewport and overlap the edges of both boxes of the polygon.
Make the icon a child of the Polygon2D and set the polygon's Clip Children to Clip Only.
This shows the masking working correctly.
If you now set the polygon's Invert flag to ON, it fails. It does not give the expected result of clipping out the opposite parts of the sprite.

Minimal reproduction project (MRP)
PolygonInvertedClippingBug.zip

It looks like the polygons property is outright ignored and it treats it as if it was one big polygon.

I tested it a bit, and it seems that Clip Children has nothing to do with the bug, it occurs without it also:

As mentioned above, it seems that as of yet there simply isn't implementation for combination of clip children and polygons.


Game crashes when opening the settings

Game crashes when opening the settings ingame with mc1.21.1-1.8.0-beta.4+fabric
crash-2024-09-21_10.28.57-client.txt
latest.log

https://github.com/FlashyReese/reeses-sodium-options/issues/109#issuecomment-2361457957


Update nvidia legacy 340 to work with 4.9 and 4.10 kernels

Motivation for this change
nvidiaLegacy340 was at .101, latest is .102. There are also two patches (from Arch) needed to build and load properly on 4.9 and 4.10 kernels, respectively.
Summary:

Old version (340.101) did not build against kernels higher than 4.4 or failed to modprobe
New version (unpatched) successfully built against 4.9 but failed to modprobe
New version (unpatched) failed to build against 4.10
New version when patched built against both 4.9 and 4.10 kernels, and loaded successfully in both cases. It also works for 4.4 kernels.

Things done

[X] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] Linux

[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

Pinging @vcunat as maintainer.

Pinging @vcunat for review

Thanks!  I'm sorry it's taken me so long.


GitHub profile not updating stats automatically when I put a GitHub username that it entered before

This GitHub Readme Stats needs to be updated automatically like every day, because when I put my GitHub username for the first time, it will get the stats for my users, but when I put my GitHub username that I've entered before, it doesn't update the stats.

@lulunac27a Hi! Thank you for the interest on my github-stats 🙂
Currently, the api caches the result for 3hours https://github.com/hyochan/github-stats/blob/12eda2fab55acd51e5a244adb5aff82d5548a9a0/server/services/githubService.ts#L592-L601
Therefore, it seems like your question is already qualified 🤔

My GitHub stats generated from this repository are not updated at all.

instead of

My GitHub stats generated from this repository are not updated at all.  instead of

I might have to look into github api then 🤔
Thanks for reporting!

My GitHub stats have still not been updated for more than 3 weeks, it's should been updated right now

@lulunac27a I think https://github.com/hyochan/github-stats/commit/afb8b8c741dfc2819f354a65223446ddd663d684 will fix this issue! Let's see how it goes.

It looks like the issue is related https://github.com/vercel/next.js/issues/47273
I've updated nextjs version and let's see if this is working.

The stats.dooboo.io homepage updated properly, but the stats.dooboo.io/en/stats link after entering my GitHub username from stats.dooboo.io homepage then click Find out more, it still doesn't update my detailed stats.

@lulunac27a Could you try once again? The site has just published like 5 minutes ago 😅.

The stats.dooboo.io/en/stats link is updated, so it's now working properly.

@lulunac27a Congrats!

How to update my GitHub stats from stats.dooboo.io every day?

How to update my GitHub stats from stats.dooboo.io every day? Because the stats are not updating for few days now and need to be updated.

It will be updated automatically if you put generated stats to you github readme like below.

I put this in my Gitub README Profile but it's not updating for like a week now.

@lulunac27a Thanks for reporting this again! I've just fixed the logical error and it will work after the deployment!
I am really sorry for the inconvenience 😓

Thank you for fixing this problem. So my stats are now updating every day.


Use Factory instead of ReceiverFactory when package contains receiver

Codecov Report

Merging #120 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #120   +/-   ##
=======================================
  Coverage   69.78%   69.78%
=======================================
  Files         101      101
  Lines        6391     6391
=======================================
  Hits         4460     4460
  Misses       1696     1696
  Partials      235      235

Impacted Files
Coverage Δ

receiver/vmmetricsreceiver/factory.go
81.81% <ø> (ø)
:arrow_up:

cmd/occollector/app/builder/receivers_builder.go
85.18% <100%> (ø)
:arrow_up:

receiver/prometheusreceiver/factory.go
77.5% <100%> (ø)
:arrow_up:

configv2/configv2.go
98.64% <100%> (ø)
:arrow_up:

receiver/factory.go
100% <100%> (ø)
:arrow_up:

receiver/jaegerreceiver/factory.go
100% <100%> (ø)
:arrow_up:

configv2/example_factories.go
55.33% <100%> (ø)
:arrow_up:

receiver/opencensusreceiver/factory.go
82.35% <100%> (ø)
:arrow_up:

receiver/zipkinreceiver/factory.go
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c68f19...4bb669d. Read the comment docs.

Already sent for exporters https://github.com/open-telemetry/opentelemetry-service/pull/123 :). I need to submit first https://github.com/open-telemetry/opentelemetry-service/pull/119 before I will do for processor.

@bogdandrutu are you planning to set a record for PRs done in one day? :-)

This is how I work when I don't have meetings :))) Luckly for the community I have a lot of meetings :))))

This is how I work when I don't have meetings :))) Luckly for the community I have a lot of meetings :))))

I need to try to save the community and schedule a few meetings with you for the next week :-)


Passing a gzipfile into pycapnp for io doesn't work because gzipfile.fileno does not reference uncompressed data

Frequently capnp message files would be gzip compressed in order to achieve much smaller files. For example, I happen to be working with capnproto log files that are ~200MB/minute gzipped and ~800MB/minute uncompressed.
As it happens, the gzipfile implementation in both python 2 and 3 exposes the fileno method in a weird abstraction breaking way. fileno for a gzipfile is actually the fd for the underlying still compressed file. Thus when pycapnp is given a gzipfile it ends up attempting to read gzipped data as if it is plain capnp data and dying with a fairly mysterious error.
For example something like this:
import capnp, gzip
fi = gzip.open("log/logs-2015_08_13-00_42_00.log.gz")
schema = capnp.load("capnp/message.capnp")
g = schema.Message.read_multiple(fi)
for message in g:
  pass

results in an error of:
capnp.lib.capnp.KjException: src/capnp/serialize.c++:159: failed: expected segmentCount < 512; Message has too many segments.
Whereas doing this works fine:
import capnp, os
fi = os.popen("cat log/logs-2015_08_13-00_42_00.log.gz | gzip -d")
schema = capnp.load("capnp/message.capnp")
g = schema.Message.read_multiple(fi)
for message in g:
  pass

Any thoughts on a fitting way to alter the library to allow use of gzipfiles? And some way to make the error less confusing?

As you observed, pycapnp duck types based on a fileno method. We should probably instead filter to known working classes instead, but it makes me a bit sad.
To answer your question, reading actually occurs in the C++ libcapnp and then pycapnp just wraps everything that comes out. We'd probably have to duck type python objects that have a read method and wrap them in a MessageReader implementation similar to InputStreamMessageReader (see https://github.com/sandstorm-io/capnproto/blob/master/c%2B%2B/src/capnp/serialize.h for how this looks). I don't have a lot of time to work on this, but I'm happy to accept a PR :)
Alternatively, your method of calling out to gzip isn't that bad, and is probably going to be faster than the aforementioned method anyways.


Set BAT_INDEX as uint16 in example code

This just cost me around 30 minutes because I couldn't figure out why the example code wasn't working, I always got this:
ERRO[0000] message at index 0: expected *uint16 got int : value does not match data type

And then even when I tried to pass a *uint16 as requested, I got
ERRO[0000] message at index 0: expected *uint16 got *uint16 : value does not match data type

so maybe the error message could use some improvements as well.
But most important is to set the value as uint16 and the example will work.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.83%. Comparing base (5494bd8) to head (dbfc5e8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   47.83%   47.83%
=======================================
  Files          28       28
  Lines        1315     1315
=======================================
  Hits          629      629
  Misses        652      652
  Partials       34       34

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thanks for your contribution, I know, the errors are very generic... but thats because the code is very generic and I didn't had the time to implement the proper error handling in a more user friendly way.


Update rocksdb to 6.1.2, adds optional zstd feature

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: BradBarnich sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Packages: Call wc -l once at the end, instead of multiple times.

Description
When I was trying to implement package manager names I took a closer look at the packages function and noticed that we were calling wc -l to count the packages once per package manager.
I started messing around with the function and came up with a way to call wc -l only once. We add each list of packages to an array, count the array using wc -l and then do some math to fix inaccuracy caused by array elements joining due to missing newlines.
This should be way faster than the current method since we no longer pipe to an external program on a per package manager basis, we just call it once at the end.
Features

Only call wc -l once.

TODO

[ ] Implement this for the other Package sections.

Testing
I don't have any systems with more than one package manager installed so I faked it on my machine to test locally. I'd still like someone to test this on a real machine before I merge this to master.

Works on my end :+1:


occamy: PCIE config regbus not connected

pcie_cfg is left unconnected. It should be connected to the peripheral crossbar.

Fixed in #348.


fix(auth): Make uid mandatory for UserImportRecord

In the type signature for the equivalent of UserImportRecord's multiFactor.enrolledFactors, the uid is an optional field, however in the implementation it is mandatory. I am not certain if it should be mandatory or not, but I think it should be mandatory.
To account for this, originally I added an extra interface in the hierarchy of UpdateRequest and CreateRequest that will mandate the uid is provided, because otherwise the type-checker would raise a warning as UpdateMultiFactorInfoRequest cannot be extended by CreateMultiFactorInfoRequest.
However I realized that instead a better approach might be to simply bring the SecondFactor interface to the typing so that the other hierarchy doesn't change.
Summary of observation:
Source

UserImportRecord expects SecondFactor[] for property multiFactor: https://github.com/firebase/firebase-admin-node/blob/b5909906bd4b73630f2a6311ac06b9e65be2d621/src/auth/user-import-builder.ts#L52-L73
SecondFactor (UID not optional): https://github.com/firebase/firebase-admin-node/blob/bed1e5ec6c3e515b037b993cdbbeb1f5b585f56a/src/auth/user-import-builder.ts#L42-L48

Typing

UserImportRecord expects MultiFactorUpdateSettings: https://github.com/firebase/firebase-admin-node/blob/bed1e5ec6c3e515b037b993cdbbeb1f5b585f56a/src/auth.d.ts#L828
MultiFactorUpdateSettings yields UpdateMultiFactorInfoRequest:  https://github.com/firebase/firebase-admin-node/blob/bed1e5ec6c3e515b037b993cdbbeb1f5b585f56a/src/auth.d.ts#L255-L262
UpdateMultiFactorInfoRequest (UID as optional):
https://github.com/firebase/firebase-admin-node/blob/bed1e5ec6c3e515b037b993cdbbeb1f5b585f56a/src/auth.d.ts#L269-L275

Other SDKs

It appears that in the Java SDK the UID is mandatory: link

Actually, a disadvantage of this approach is that it's more of a breaking change than adding the hierarchy, since now it introduces a new interface to those types. Thoughts would be appreciated (or if there's a better approach or if it's better to not change it at all/there is no issue).

Yes, this is a potentially breaking change, but it might be the right fix in the long run. I think our options are:

Wait to make this change until the next major release (we should create a bug to track this).
Make the uid required if it's actually required in all the possible flows (this may not be the case, and if so this is not really an option for us).

Some background on this. I intentionally didn't want to create multiple interfaces for this.
Different endpoints use this as optional, not needed or required.

When retrieving a user with a second factor, uid will always be there
When listing users with a second factor, uid will always be there
When creating a user with a second factor via createUser, uid is not needed and the Auth server will always provision one.
When updating an existing user second factors, uid is optional. If not provided, Auth server will provision one.
When importing users with second factors in bulk (usually from another system), uid is optional. If not provided, Auth server will provision one.

Thanks @bojeil-google. So it looks like the public API surface (d.ts) files are correct. It's just the SecondFactor type in the implementation is used in use cases where the uid is optional too (a reasonable implementation choice).
@MathBunny I feel like we can live with the current implementation. If it has any impact on your ongoing refactoring work, let's have a separate conversation about how to get around it.

Sounds good, thank you for the explanation!


unable to build ava

Describe the bug
I did pull the latest today - 05-31/2020 from git clone https://github.com/ava-labs/gecko.git

issue1 - initially I did build on ununtu 20.04 the build exits with something like missing 'miliseconds'

issue2 - I did switch to ubuntu 18.04; and did pull from git; the build can not start - script  exits with:

Downloading dependencies...
go: unknown subcommand "mod"
Run 'go help' for usage.

issue3 - I did remove the ubuntu18.04 go install, did download current - go1.14.3.linux-amd64.tar.gz
after starting - build.sh    I get -

Downloading dependencies...
<EMAIL_ADDRESS>verifying module: checksum mismatch
downloaded: h1:qhgkrZru95jFP9NbVPknJvc9vgkMXhOEzkOASKdc0oQ=
sum.golang.org: h1:i7c6Za/IlgBvnGxYpfD7L3TGuaS+v6oGcgq+J9/ecEA=
SECURITY ERROR
This download does NOT match the one reported by the checksum server.
The bits may have been replaced on the origin server, or an attacker may
have intercepted the download attempt.
To Reproduce
pull - git clone https://github.com/ava-labs/gecko.git
and build on ubuntu 18.04 and 20.04
Expected behavior
build successfully
Screenshots
...
Operating System
ubuntu 20.04 , ubuntu 18.04
Additional context
...
By submitting this issue I agree to the Terms and Conditions of the Developer Accelerator Program.

@nlpvan-paul I'm pretty sure you're not running Go >= 1.13
Can you do go version to check? Thanks

Currently I use the latest go - go1.14.3.linux-amd64.tar.gz
The message is the same when I build on wither ubuntu 18.04 or ubunty 20.04
Did you actually try building the 05.31 release?
On Wednesday, June 3, 2020, 6:20:41 AM PDT, danlaine<EMAIL_ADDRESS>wrote:

@nlpvan-paul I'm pretty sure you're not running Go >= 1.13
Can you do go version to check? Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Hi @nlpvan-paul are you still having this issue?

Hi Daniel,I did give up trying to build the 05.31 release ava with source and am using the gecko binaries.If you did release anything newer - let me know .Paul.
On Tuesday, June 9, 2020, 9:11:33 AM PDT, danlaine<EMAIL_ADDRESS>wrote:

Hi @nlpvan-paul are you still having this issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

@nlpvan-paul
Latest release is 0.5.4
Hopefully it gives a smoother experience. Let me know how it goes.

Closing this for now. Let me know if you're still having this issue.

Hi,
I did switch to other projects. I just did download 0.5.7 release and will find time to test. If issues still present I will report it.Paul.
On Wednesday, June 24, 2020, 12:37:36 PM PDT, danlaine<EMAIL_ADDRESS>wrote:

Closed #197.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.


Selection of the ideal Lavalink node according to the location of the Discord server

It is quite likely that there will be some errors in the code. I wrote this code in JavaScript and then transcribed it into TypeScript, a language I don't quite understand.
The principle is that I added the "region" option to the node options, which can be either a string or a array of strings.
Furthermore, the Player now also has the "region" option, which is the region of the Discord server (string).
If the user specifies the Node he wants to use when creating the Player, that one is selected (as before).
If the user has provided the "region" option, the corresponding Nodes are selected.

If none is found, null is returned
If one matching Node is found, it will return
If more than one matching Nodes are found, the best one will be selected according to the statistics of the given Node.

If no Node is returned or the "region" option is not provided, the best one is selected according to the statistics of that Node (as before)

Has this code been tested?

yeah, I tested it - but in JavaScript => idk if I rewrote it to TypeScript correctly

The thing you gotta realise is, Erela is our baby, hehe. We'd prefer it to be without bugs, and your codebase and amount of changes are almost too big to get a grasp of in one sitting. When we ask if your code has been tested, you respond with "only before, when I wrote it in a language I understand." What do we do with this? I suppose @acollierr17 & myself are forced to do quite some testing with this to avoid bugs if possible.

Has this code been tested?

yeah, I tested it - but in JavaScript => idk if I rewrote it to TypeScript correctly

The thing you gotta realise is, Erela is our baby, hehe. We'd prefer it to be without bugs, and your codebase and amount of changes are almost too big to get a grasp of in one sitting. When we ask if your code has been tested, you respond with "only before, when I wrote it in a language I understand." What do we do with this? I suppose @acollierr17 & myself are forced to do quite some testing with this to avoid bugs if possible.

I've already dealt with someone from you from Discord that I don't know much about TS. That man told me that someone would help me with the transport from JS to TS. I tried to make the code correct. Respectively, the code should be functional, I'm just not sure about the types of variables in the return and input methods.
there were a lot of commits, since I already made one pull request. Unfortunately, I was unable to reset changes to the repository. So that's the reason for so many commits


can we extract the SRTP keys and send it to another library?

We are using the OpenWebRTC libraries with another library which can take care of media. How could we make use of the OpenWebRTC to hande the DTLS handshakes, and provide the SRTP key to the media library, where the media would be handled. Also, we need to know how we would block the media handling in openwebrtc. I like to implement an interface library which can talk with openwebrtc and the exiting library. The interface library will be similar to the test_client application. In the test_client prespective, can we extract the SRTP keys and send it to another library?

@Rugvip knows best about SRTP handling.

It sounds like a quite low-level integration, so you'll probably be better of just using the DTLS elements in OpenWebRTC directly. They're available in gst-plugins-bad.
And it's not possible to export the SRTP keys in OpenWebRTC, not without some ugly workaround.

Thank you for the response.
I am not clear on this.
"probably be better of just using the DTLS elements in OpenWebRTC directly"
Could you explain a bit more detail?

OpenWebRTC is built on top of GStreamer http://gstreamer.freedesktop.org/
The architecture of GStreamer lets you put together pipelines consisting of elements that process media as well as generic data. The DTLS elements used in OpenWebRTC are found in the dtls plugin inside gst-plugins-bad, and those could be used directly in your application.

Thank you. As per your reply, the DTLS functionality can be accessed from the application itself. Whether we can get the DTLS key in the application?
We would like to know about the SRTP handling also. How to give the SRTP control to another module. Do you have suggestion on this?
We would like to know whether this is possible with openwebrtc?


Deal with 'third-party' tagging

We have a tool that comes by and adds additional tags or updates tags on objects like RDS and S3 buckets. Terraform will typically remove those tags and this gets flagged as a policy violation by this tool.
In other terraform things I've added a lifecycle ignore_changes for tags in order to avoid removing the additional tags. This has a side-effect of making it so that TF essentially does not manage the tags after the first run. Meaning if you change or add a tag in TF, it won't get applied (it doesn't register as a diff).
@pradeepbhadani @rpoluri do you see an issue if I add ignore_changes for the affected resource types?
I do have a potential workaround, but it's a lot of work and I didnt' start on it yet (basically call some API to fetch the 'correct' tags before I run terraform, then incorporate those tags dynamically into the TF run).
Just want to gauge your thoughts on this before I implement either approach here...

I think we can add "ignore_changes" and make it configurable through variable, so that it is not on by default, but you can turn it on.

According to this https://github.com/hashicorp/terraform/issues/3116 lifecycle block can't contain interpolations. I'm not sure if we can configure it.

In that case, I prefer to use external script to capture tags, other way will make it difficult for everyone else to maintain tags.

Yes, I tend to agree, I guess I have to do some other approach.

Does this works?
lifecycle {
    ignore_changes = [
      "tags.#",
      "tags.%"
    ]
  }

It might... but I think I read in some TF github issue that approaches like that were not considered to be a feature, but just a quirk in the implementation. I'll try to find the reference later...


[Style]:Add icon on Navbar for buttons

What's the style idea?
We need to improve:
Icons for each button can be added alongside with the text on the Navbar to make it look more appealing

Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[X] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

Proceed @Ishita928


Create unzip command

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Congrats @condor-webdev on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝


[FEATURE] Longhorn api error response refactor

Is your feature request related to a problem? Please describe (👍 if you like this request)
Longhorn API server should handle different error with different error code and have the same payload structure for any error users hit.
Describe the solution you'd like
Currently the error is written to response in go-rancher lib which is not controlled by Longhorn.
Thus we cannot defined the error response structure
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
https://github.com/longhorn/longhorn/issues/6266

ref: https://github.com/longhorn/longhorn/issues/8026, https://github.com/longhorn/longhorn/issues/6407


new feature for #404 add resource tree function

What is the purpose of the pull request
add resource tree function
1.It supported directory mode,The resoruce files in diffrent directorys can has the same resource name.
2.It not support resource version.
Brief change log
add resource tree function

add resource filter and visitor in package org.apache.dolphinscheduler.api.dto.resources
add pid、is_directory and full_name in t_ds_resources
add abstract method setMainJarName in AbstractYarnTask

Verify this pull request
This change added tests and can be verified as follows:
add the unit test

added ResourceFilterTest
update ResourceMapperTest
update ResourcesServiceTest

the detail can also see https://github.com/apache/incubator-dolphinscheduler/issues/404

Codecov Report

Merging #2323 into dev will not change coverage by %.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev    #2323   +/-   ##
=========================================
  Coverage     30.75%   30.75%
  Complexity     1742     1742
=========================================
  Files           342      342
  Lines         18094    18094
  Branches       2266     2266
=========================================
  Hits           5564     5564
  Misses        11956    11956
  Partials        574      574

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eab38d3...eab38d3. Read the comment docs.


Edge Case Bug Causing Crash A Random Percentage Of The Time

Godot version
3.4.4.stable.mono
System information
EndeavourOS Linux
Issue description
The issue is that loading a map from another thread in my game caused a crash roughly 60% of the time. It didn't happen exactly 60% - sometimes it'd crash 1 in 10 tries, sometimes 6 in 7 tries.
Steps to reproduce
This is a weird one to explain but I can try to assist devs wherever possible. Here's my best understanding. I used this for threading logic:
private Thread _threadAddMap = new Thread();

...
public void LoadFirstLevel(Player player)
{
   if (!_threadAddMap.IsActive())
    {
      ...
      _threadAddMap.Start(this, "LoadMapOnThread", FirstMapPath);
      ...
    }
}

...
private PackedScene LoadMapOnThread(string mapPath)
{
    var map = ResourceLoader.Load<PackedScene>(mapPath);
    CallDeferred("FinishLoadingMap");
    return map;
}

...
private void FinishLoadingMap()
{
    var mapScene = (PackedScene)(_threadAddMap.WaitToFinish());
    Map map = (Map)mapScene.Instance();
    AddChild(map);
}

So what exactly is the crash? Well, according to Mono, the crash
Found class KatamariBall for script res://Src/Scenes/Enemy/KatamariBall.cs
Loading resource: res://Assets/Tileset/Enemies/BALLV2.png
Loading resource: res://Src/Scenes/Particles/Particles2D.tscn
Loading resource: res://Assets/Audio/breaking.wav
malloc(): invalid size (unsorted)
=================================================================
Native Crash Reporting
=================================================================
Got a SIGABRT while executing native code. This usually indicates
a fatal error in the mono runtime or one of the native libraries
used by your application.
=================================================================
=================================================================
Native stacktrace:
=================================================================
0xf2662d - ~/godot/Godot_v3.4.4-stable_mono_x11_64/Godot_v3.4.4-stable_mono_x11.64 :
0xf269b9 - ~/godot/Godot_v3.4.4-stable_mono_x11_64/Godot_v3.4.4-stable_mono_x11.64 :
0xf1918f - ~/godot/Godot_v3.4.4-stable_mono_x11_64/Godot_v3.4.4-stable_mono_x11.64 :
0xf25c34 - ~/godot/Godot_v3.4.4-stable_mono_x11_64/Godot_v3.4.4-stable_mono_x11.64 :
0x7fba44e3e8e0 - /usr/lib/libc.so.6 :
0x7fba44e8e36c - /usr/lib/libc.so.6 :
0x7fba44e3e838 - /usr/lib/libc.so.6 : raise
0x7fba44e28535 - /usr/lib/libc.so.6 : abort
0x7fba44e8245e - /usr/lib/libc.so.6 :
0x7fba44e980cc - /usr/lib/libc.so.6 :
0x7fba44e9b2e4 - /usr/lib/libc.so.6 :
0x7fba44e9bdaa - /usr/lib/libc.so.6 :
0x7fba44e9cbe7 - /usr/lib/libc.so.6 : realloc
0x3848f5e - ~/godot/Godot_v3.4.4-stable_mono_x11_64/Godot_v3.4.4-stable_mono_x11.64 : _ZN6Memory14realloc_staticEPvmb
0x13674be - ~/godot/Godot_v3.4.4-stable_mono_x11_64/Godot_v3.4.4-stable_mono_x11.64 :
0x37c65c6 - ~/godot/Godot_v3.4.4-stable_mono_x11_64/Godot_v3.4.4-stable_mono_x11.64 : _ZN6StringpLERKS_
0x37c74c4 - ~/godot/Godot_v3.4.4-stable_mono_x11_64/Godot_v3.4.4-stable_mono_x11.64 : _ZNK6StringplERKS_
0x3738bc1 - ~/godot/Godot_v3.4.4-stable_mono_x11_64/Godot_v3.4.4-stable_mono_x11.64 : _ZN5Image6createEiibNS_6FormatERK10PoolVectorIhE
0x3738e68 - ~/godot/Godot_v3.4.4-stable_mono_x11_64/Godot_v3.4.4-stable_mono_x11.64 : _ZN5ImageC2EiibNS_6FormatERK10PoolVectorIhE
0x30fac2a - ~/godot/Godot_v3.4.4-stable_mono_x11_64/Godot_v3.4.4-stable_mono_x11.64 : _ZN15GradientTexture7_updateEv
0x11f6269 - ~/godot/Godot_v3.4.4-stable_mono_x11_64/Godot_v3.4.4-stable_mono_x11.64 :
0x376e2d9 - ~/godot/Godot_v3.4.4-stable_mono_x11_64/Godot_v3.4.4-stable_mono_x11.64 : _ZN6Object4callERK10StringNamePPK7VariantiRNS3_9CallErrorE
0x376a18b - ~/godot/Godot_v3.4.4-stable_mono_x11_64/Godot_v3.4.4-stable_mono_x11.64 : _ZN12MessageQueue14_call_functionEP6ObjectRK10StringNamePK7Variantib
0x3784850 - ~/godot/Godot_v3.4.4-stable_mono_x11_64/Godot_v3.4.4-stable_mono_x11.64 : _ZN12MessageQueue5flushEv
0x2956e40 - ~/godot/Godot_v3.4.4-stable_mono_x11_64/Godot_v3.4.4-stable_mono_x11.64 : _ZN9SceneTree9iterationEf
0x118ce81 - ~/godot/Godot_v3.4.4-stable_mono_x11_64/Godot_v3.4.4-stable_mono_x11.64 : _ZN4Main9iterationEv
0x1191c71 - ~/godot/Godot_v3.4.4-stable_mono_x11_64/Godot_v3.4.4-stable_mono_x11.64 : _ZN6OS_X113runEv
0xe48f9e - ~/godot/Godot_v3.4.4-stable_mono_x11_64/Godot_v3.4.4-stable_mono_x11.64 : main
0x7fba44e29290 - /usr/lib/libc.so.6 :
0x7fba44e2934a - /usr/lib/libc.so.6 : __libc_start_main
0xe4dace - ~/godot/Godot_v3.4.4-stable_mono_x11_64/Godot_v3.4.4-stable_mono_x11.64 :

It was weird to debug. And only found it with a Godot user in the Discord. They deduced that removing the particle effect fixed the bug. After awhile, I found that it was because my cat hit my mouse a few months back and changed the gradient's colour ramp's width to 3101. When I changed it back, everything worked as expected. I tried to create a test project for this exact purpose and could not replicate it. So it very likely is a very specific issue down to the specific size of my scene. Or something. I'll try to assist however I can but this is one of those weird edge cases that I wanted to at least bring up and mention. So; in this random edge case example, loading a node with a particle effect that has a gradient with its color ramp's width changed, on another thread, when the scene is a specific size(?) it will crash. Sometimes. Randomly. With 0 indication directing the bug.
Minimal reproduction project
No response

Can you send your project, all of it?

@stephen-soul Can you still reproduce this issue in 3.5.3 or greater? If so, please provide a minimal reproduction project to make this easier to troubleshoot.

Closing due to lack of response, if you provide the requested information this can be reopened


Use iexfinance module for data retrieval

What is the name of the source?
The iexfinance module
How would this data be used in the project
Would be a replacement for stock score data and used in Auto DCF
Would this data be used to provide a new feature or improve data quality on already existing features?
Would simplify how data is currently collected.
Additional context
Not sure if this would be sensitive to API changes, but it seems like even if it was, my current implementation would be as well.

For now, this will run as is and focus on scoring rather than reworking data collection


Add nexclipper: Simple web UI for container monitoring

https://github.com/TheNexCloud/NexClipper
NexClipper is the simple and easy container monitoring tool which to collects statistics, status, process, network, environment, volume, and log.

Thanks.
I will regenerate the pull request.


Lots of missing data in Haunted Mines Replay

No talents, no stats.
Haunted Mines (4).zip

It looks like this parsed successfully
Talents may not be shown if they are selected by the AI while a player is disconnected
It looks like everyone has most of their talents, and their end game stats

Found the problem, my branch wasn't up to date with yours.  It was probably commit f2976c012d2619d3fbb2f7a45d79c9a3d59e2c92 that fixed it.


download: golang.org/dl/ is not available on safari

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
Tried 1.8.3 and other version too.  Finally success on Chrome.
What operating system and processor architecture are you using (go env)?
MAC
What did you do?
Just download the pkg.
What did you expect to see?
Fix the link so someone wanna to learn Go as a backup choice  will not give up.

I just downloaded it using Safari. It works fine for me.
How doesn't it work for you? What do you see?
Which version of macOS and which of Safari?

Thank you.
Sorry for the late response.
My env: macOs Sierra 10.12.5 (16F73)  ;   Safari  10.1.1 (12603.2.4);
I tried it in China.
When I click the link,  download won't act auto.

Sorry, we try our best to keep Go available in China but its accessibility can vary daily due to the GFW. I can't advise you how to bust through your firewall.

Thx for your time.


Wallet tab page scanning problem

Use https://app.dodoex.io to generate a QR code, and then open the scan in the wallet tab, it will automatically jump to the browser tab but will not open https://app.dodoex.io

Scanning the QR code in a browser tab will open https://app.dodoex.io

Thanks @xiaohan445336816 we'll check it out.

@JamesSmartCell
Scanning the URL QR code will call the following methods of HomeActivity
public void onBrowserWithURL(String url)
{
showPage(DAPP_BROWSER);
getFragment(DAPP_BROWSER).onItemClick(url);
}
But you removed the onItemClick method of DappBrowserFragment in version 3.61


Got error when opening atest-desktop on Windows #444

What type of PR is this?

Which issue(s) this PR fixes:

Fixes #

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.段伟杰 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

You can squash all commits into one. Or, all commits should have the correct email.


Update CocoaPods and Fastlane

Codecov Report

Merging #41 into master will increase coverage by 2.59%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   95.16%   97.75%   +2.59%
==========================================
  Files           6        6
  Lines         186      178       -8
  Branches       12        0      -12
==========================================
- Hits          177      174       -3
+ Misses          9        4       -5

Impacted Files
Coverage Δ

HCImage+BPG/Internal/CG/DataProvider.cpp
100% <0%> (ø)
:arrow_up:

HCImage+BPG/Internal/CG/Image.cpp
100% <0%> (ø)
:arrow_up:

Tests/Tests.swift
100% <0%> (ø)
:arrow_up:

HCImage+BPG/Internal/BGP/Context.cpp
100% <0%> (ø)
:arrow_up:

HCImage+BPG/Internal/CG/ColorSpace.cpp
100% <0%> (ø)
:arrow_up:

HCImage+BPG/HCImage+BPG.mm
96.72% <0%> (+3.69%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12fc0ad...83b6468. Read the comment docs.


Prometheus push gateway support

Let's consider adding support for prometheus pushgateway (prom client docs).

What are our expected use cases for push gateway?
https://prometheus.io/docs/practices/pushing/
The document here describes a little about when push gateway is recommended (which is, most of the time, not).
So I think that before this issue is addressed, we need to understand under which circumstances such a plugin will be used so that we can know how to handle the lifecycle management-related topics.
For reference, here's a paragraph from the document explaining some of the fundamental differences between a normal service using Prometheus (with normal pull behavior) to using Pushgateway:

(*) The Pushgateway never forgets series pushed to it and will expose them to Prometheus forever unless those series are manually deleted via the Pushgateway's API.

The latter point(*) is especially relevant when multiple instances of a job differentiate their metrics in the Pushgateway via an instance label or similar. Metrics for an instance will then remain in the Pushgateway even if the originating instance is renamed or removed. This is because the lifecycle of the Pushgateway as a metrics cache is fundamentally separate from the lifecycle of the processes that push metrics to it. Contrast this to Prometheus's usual pull-style monitoring: when an instance disappears (intentional or not), its metrics will automatically disappear along with it. When using the Pushgateway, this is not the case, and you would now have to delete any stale metrics manually or automate this lifecycle synchronization yourself.

In general, we want to have the ability to use Monitored WITH Prometheus on the web, mobile apps, and lambdas. (Like we did with StatsD).

@korengal I figured. However, contrary to push gateway, StatsD does not have lifecycle, you fire-and-forget your metrics and don't have to think about it.
As stated above, when working with Push Gateway, you have to consider the lifecycle, since it affects how you (metrics sender) interact with it (the gateway).
I think that the next step towards implementation is mapping each of our desired use cases (web, mobile, lambdas) to understand how each would interact with the gateway.
For example, web and mobile sessions are partitioned by userId or deviceId (as an example) and can be short-lived or long-lived, and you need to make sure that old metrics are discarded over time.
Lambdas (and cronjobs and friends) are different, since their lifecycle is different, they come and go, and no session is related to a different one (in terms of metrics grouping), so it requires different behavior when working with the push gateway.
Once we map those out, we can understand how to implement this, what will be the configurations exposed by the plugin (and what will be it's scope in the first place), and so on.

For any case where pull style collection is possible, it should be preferred (e.g. standard web servers).
For Lambdas and Cronjobs as @gioragutt mentioned, the executions are unrelated and shouldn't require any lifecycle management if the metrics are reported without ephemeral information such as machine or instance label.
For anything with a session id or some uniquely identifying label, some lifecycle management would need to be implemented on the push gateway

For AWS lambdas, maybe a cloudWatch plugin will solve the issue


Jonathan's fixes

@JonathanWfels's changes + created a backup of the old file just in case. (a backup is always stored in the git history though, but still.)

A few corrections I noticed and that we discussed in slack. Double checked the attestation PDF's and sure that this is correct.


Download symbols does not work

       "type": "al",
        "request": "publish",
        "name": "ExtName",
        "server": "https://4d60XXX961",
        "serverInstance": "NAV",
        "tenant": "default",
        "authentication": "UserPassword"

Error: An error occurred while sending the request.
The underlying connection was closed: Could not establish trust relationship for the SSL/TLS secure channel.
The remote certificate is invalid according to the validation procedure.

If you are using SSL, you need to install the SSL certificate (which you can download from the containers files area) in the trusted certificate authorities on the host machine.
or you can use -e UseSSL=N in your Docker run command and then use http in the launch.json server name

Thx, solved


The proper way to get & set quill contents data

Blot formatter plugin do not write styles in to quill content data.
Reproduction steps:

create quill instance with plugin

var quill = new Quill('#quill', {
            modules: {
                blotFormatter: {},
            },
        });

create event handler on blur

quill.on('selection-change', (range, oldRange, source) => {
        if (range === null && oldRange !== null) {
            console.log(quill.getContents())
      }
});

add any image to quill and resize it .
de focus quill to trigger selection-change event

Actual result:
Quill returns blob without image atributes
Expected result:
Resizing should update quill model state and be available through function getContents()

Sorry for the late response.
It'd make sense for it to work this way, or have a documented way to get at this information. I'll take a look next week.

@akupiec - can you try with the latest (v1.0.4) and let me know if this works as you'd expect?
You should now be seeing selection-change events with attributes properly filled out for the image containing the delta. This should also work for text-change events as well.

@nmonterroso thank you for new version I will check it till end of the week, and then I will let you known.

Closing since over a month with no comment

I'm facing the same issue


Inquiry on tutorials to Use plugins for ROS 2 Humble

This inquiry is a continuation from (here) [https://github.com/osrf/vrx/issues/595]. Will there be a tutorial on how to apply the bouyancy and thruster plugins for custom Unmanned Sea Vehicle Models?

Please, see the "Maritime" section of the Gazebo tutorials. We've covered many topics there.
https://gazebosim.org/api/sim/8/tutorials.html


Convert benchmark run to use pipe

This fixes a bug where Process returned (and closed the "out" channel) before
it was finished populating the channel. The pipe library enables us to buffer
the verdicts and count them to ensure we provide the anticipated number to the
output channel.

The previous impl actually is sound so long as ProcessOne completes its output by the time it returns. Abandoning


[HOLD WEB#34303][Refactor] SetNameValuePair

HOLD on https://github.com/Expensify/Web-Expensify/pull/34303
Details

Changes to NVP calls on App to use specific methods.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/211821
Tests

[x] Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[x] MacOS / Chrome
[ ] MacOS / Desktop

[x] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] Any functional components have the displayName property
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose and it is

[x] If a new CSS style is added I verified that:

[x] A similar style doesn’t already exist
[x] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

PR Reviewer Checklist

[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

QA Steps

Open your network tab in developer tools before running the tests

SetPreferredEmojiSkinTone

Access any chat you prefer
Click on Emoji
Click on Change default skin tone
Select a tone that is different that the current one
Check if a request was made to /api?command=UpdatePreferredEmojiSkinTone
Sign off and then Sign in again
Verify that skin tone is the same previously selected

SetFrequentlyUsedEmojis

Access any chat you prefer
Click on Emoji
Verify the current set of frequently used emoji and click on one that is not on that list
Check if a request was made to /api?command=UpdateFrequentlyUsedEmojis
Verify that your current list of frequently used was updated with the emoji you just used
Sign off and then Sign in again
Check if list is still the same.

SetChatPriorityMode

Access Settings > Preferences
Change “Priority Mode”
Verify that a request was made to /api?command=UpdateChatPriorityMode
Verify that your chat list exhibition mode was changed
Sign off and then Sign in again
Access Settings > Preferences
Verify that Priority Mode was the one you selected before

AddPaypalMeAddress

Access Settings > Payments
Click on “Add Payment method”
Select Paypal.me
Add a handle e.g. “danielsilva”
Verify that a request was made to /api?command=AddPaypalMeAddress
Verify that the PayPal address is now listed as a payment method
Sign off and then Sign in again
Access Settings > Payments
Verify that PayPal is still listed

DeletePaypalMeAddress

Access Settings > Payments
Click on your PayPal option and then “Delete” and “Delete” again
Verify that a request was made to /api?command=DeletePaypalMeAddress
Verify that the PayPal address is not listed as a payment method
Sign off and then Sign in again
Access Settings > Payments
Verify that PayPal is not listed

[ ] Verify that no errors appear in the JS console

Screenshots

Web
https://user-images.githubusercontent.com/5818999/178586419-5e223ab3-3016-4c6d-b1e2-9d9dacc93f6c.mov

It looks good to me, apart from a few questions, but I do feel to confident in my knowledge of the API refactor without asking for someone with more knowledge to give it a review as well.
Not sure if @puneetlath  is ok with being that person.

ok, considering the name structure (my bad), I think we need to do those changes in Web-E to set those to the right naming convention before changing just the JS methods here. @marcaaron should I do that and put this on HOLD again?

Yes, I think that would be best! Otherwise we will have an App version that is trying to use API commands that have been removed. Just easier to update in Web-E then do it here after.

Changes were addressed, PR created for Web-E. This is now on HOLD until web-e is deployed.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @marcaaron in version: 1.1.86-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @yuwenmemon in version: 1.1.86-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Fixture returning parent element

Given

Some bold text

I'd expect region.html() to return Some bold text as per your documentation:

The output of the html method for fixtures does not include the surrounding element, for example if a Fixture is created using a H1 element the HTML output will not contain the H1 element only its content. For non-block elements such as images the entire IMG element is returned.

Except right now it outputs the full HTML string:

Some bold text

For me, I don't even want any HTML inside the fixture, so my workaround thus far is this:
  var editor = ContentTools.EditorApp.get();
  editor.init('[data-editable], [data-fixture]', 'data-name');

  editor.addEventListener('saved', function (ev) {
    var payload = {}, regions;
    Object.keys(regions = editor.regions()).forEach(name => {
      payload[name] = (regions[name].type() == 'Fixture') ? regions[name].domElement().innerText : regions[name].html()
    })
   //...
  });

But it is inconsistent with your docs, so I was just curious what is wrong. Docs or api

Hi @ollym - the docs need updating (good spot), this has changed in recent releases to cater for more complex fixture types, see the following CT and CE releases for details:

https://github.com/GetmeUK/ContentTools/releases/tag/1.5.0
https://github.com/GetmeUK/ContentEdit/releases/tag/1.3.0

I'll update the docs too :+1:

Documentation has now been updated to reflect the change in release 1.3.0