Page Compare - java.lang.OutOfMemoryError

Required Information

[x] AEM Version: 6.4
[x] ACS AEM Commons Version: 4.3.4
[ ] Reproducible on Latest? The code has not changed, so I am sure that the issue still exists.

Expected Behavior
Using the Page compare function with the resource /content/dam returns a comparison or an error message. Link:
http://<host>:<port>/apps/acs-commons/content/page-compare.html?path=/content/dam&a=latest&b=latest

Actual Behavior
I got the following entry in the logfile:
java.lang.Exception: Wrapping Throwable: java.lang.OutOfMemoryError: Java heap space

Steps to Reproduce
Call:
http://<host>:<port>/apps/acs-commons/content/page-compare.html?path=/content/dam&a=latest&b=latest

Details:
I think there is an issue with the page compare function. Even though it is called "Page Compare" the "Select path" widget, allows you to select any resource in the aem, that the user can read. If you select for example:
http://<host>:<port>/apps/acs-commons/content/page-compare.html?path=/content/dam&a=latest&b=latest

you may end up with this:
GET /apps/acs-commons/content/page-compare.html HTTP/1.1] org.apache.sling.engine.impl.SlingRequestProcessorImpl service: Uncaught SlingException
 java.lang.Exception: Wrapping Throwable: java.lang.OutOfMemoryError: Java heap space

As long as you select a page, the constructor of the PageCompareDataImpl class  changes the resource to the child jcr:content and for the comparison only the underlying subtree is relevant :
PageCompareDataImpl(Resource resource, String versionName) throws RepositoryException {
    this.resource = resource.isResourceType(NameConstants.NT_PAGE) ? resource.getChild(NameConstants.NN_CONTENT) : resource;
    this.versionName = versionName;

    initialize();
}

If you select a resource, which is not a page, then you dump the complete subtree and create a html page from it. This happens because the populate method in the PageCompareDataImpl is recursive and has no limit:
    private void populate(Resource resource, String basePath, int depth) throws RepositoryException {
        ValueMap map = resource.getValueMap();
        List<String> keys = new ArrayList<String>(map.keySet());
        Collections.sort(keys);
        for (String key : keys) {
            Property property = resource.adaptTo(Node.class).getProperty(key);
            lines.add(new PageCompareDataLineImpl(property, basePath, depth + 1));
        }
        Iterator<Resource> iter = resource.getChildren().iterator();
        while (iter.hasNext()) {
            Resource child = iter.next();
            lines.add(new PageCompareDataLineImpl(child, basePath, depth + 1));
            populate(child, basePath, depth + 1);
        }
    }

There are several ways to fix the issue:

Allow only pages to be selected. This is not a bad idea for a function which is called Page Compare. On the other hand it might be comfortable to be able compare any kind of resource. Perhaps a list of allowed resource types in an osgi configuration would be an alternative, which can be checked by he constructor of the class PageCompareDataImpl.

Limit the depth in the populate function. This is a simple solution, but finding a reasonable depth might be not that easy.

Limit the lines in the populate function. This is a simple solution.

I would opt for option 1. Everything else would be a more general "compare subtree" functionality, and I don't see a good usecase for it yet. Especially one which requires to traverse huge subtrees.


feat: Add functionality to export doc strings on struct fields and enum variants

This is an "extension" of #187 and tries to also export doc strings not only on "full types" but also on the fields/variants of structs/enums.
Example
#[derive(TS)]
#[ts(export_to = "tests-out/docs/")]
struct A {
    /// Doc of field
    ///
    /// Testing
    name: String,
}

is exported as
export interface A {
    /**
     * Doc of field
     *
     * Testing
     */
    name: string,
}

Comments
JSDocs are only shows when starting in a new line

This of course interferes with the "format" feature and because of the requirement to start in a new line, all tests I guess.
JSDocs are not applicable to unions (enums)
See https://github.com/microsoft/tsdoc/issues/164
This might depend on whether the enum is tagged internally/externally, etc.

Hey @timephy! It seems this PR contains duplicates of the commits in #187. I think it would be a good idea to sync your main branch to this repo's and then create a new branch to avoid this issue

Notes:

Generated TS now creates types instead of interfaces

export interface A {
    /**
     * Doc of field
     *
     * Testing
     */
    name: string,
}

Should be

export type A = {
    /**
     * Doc of field
     *
     * Testing
     */
    name: string,
}

JSDocs are only shows when starting in a new line
This of course interferes with the "format" feature and because of the requirement to start in a new line, all tests I guess.

Great observation! This likely means that in case the format feature is off we will have to avoid generating field docs, as they will not be rendered

JSDocs are not applicable to unions (enums)
This might depend on whether the enum is tagged internally/externally, etc.

Sadly there is no reasonable way to document enum variants, regardless of tagging, we should keep this to struct fields (which, on the bright side, will affect fields inside an enum's struct variant)


deps: remove grpc test dep since it's now in shared-deps

grpc-iam-v1 added in shared-deps v0.6.0

It is used for testing.


Add drupal install arguments configuration option

Would be useful to allow additional arguments to be passed to the drush site-install command.
In my case I'd like to install the commerce kickstart distribution without the demo store.

Does this work fine if you have no extra arguments in the list?

I'll manually test it in a bit to verify.

Earlier it bailed out if the variable was undefined, now it's fine both if it's undefined or [].

@geerlingguy any changes you'd like for this pull request to get accepted?

Updated according to your suggestions. I can do a final manual site-install test tomorrow though.


CVS .ignore definitions are recursive

If I put *.txt in module root folder .ignore file all .txt files are shown as ignored in subdirectories too, when changing one of those files the correctly appear in the "Local Changes" tab.

@Riekr Thank you for this report.
That happens because you had tracked already all the *.txt files and added this exclusion at the end.
If you'll create new foo.txt within your project, it will not be added to the repository.
With the newest v1.7 release there will be an option to untrack newly ignored files (it will perform git rm --cached filename.txt action).

Sorry,
i've not been clear I think.
Given the structure:
\foo\bar.txt (shown as ignored but taken into account in local changes tab)
|.cvsignore
|ignore1.txt (really ignored)
|ignore2.txt (really ignored)

where .cvsignore contains *.txt all .txt files gets respesented as ignored even bar.txt which is in a subfolder, only ignore?.txt are really ignored as they never appear as modified in the local chages tab.
It's most a cosmetic issue happening with CVS, i've not tried with other version controls.

I can confirm this issue is still present in 1.7.3

Can I ask you to check if this issue is still present in v2.1.1?

sorry, we stopped using cvs since last May


Remove tint on search drawable

Task/Issue URL: https://app.asana.com/0/0/1203634853584226/f
Description
Simple PR removing defined tint on the search icon

Add lint rule to https://app.asana.com/0/1174433894299346/1203672185579007

Changing assignee to @malmstein since he approved already


RN-485 Stopped returning null post ID arrays when not logged in

This is to remind me to update mattermost-redux after the other PR is merged
Redux PR: https://github.com/mattermost/mattermost-redux/pull/310
Ticket Link
https://mattermost.atlassian.net/browse/RN-485

@enahum I just created the dummy PR to make sure that I remembered to update the yarn.lock. Probably didn't need to mark it for Dev Review until after the redux


[Minor] JEI says MonsterBall breaks after releasing mob, it does not.

MC 1.12.2 and Cyclic 1.9.6
Both single player and server
Monster balls do not get destroyed upon release the mob (tried with both pigs, endermen, and abyssalcraft mobs, contrary to what is said on the description in JEI. Just wanted to give a heads up if you wanted to correct the JEI entry or add in a way so that the MonsterBall deletes itself.

Yeah i changed it to make it reuseable but forgot to update docs. Thanks for noticing

Fixed in latest https://minecraft.curseforge.com/projects/cyclic/files/2494016


[audio] Properly implement WhisperTokenizer

Description
Fixes #3080

Codecov Report
Attention: Patch coverage is 0% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 72.13%. Comparing base (ae00167) to head (94368ba).
Report is 10 commits behind head on master.

Files
Patch %
Lines

...ava/ai/djl/audio/translator/WhisperTranslator.java
0.00%
21 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3086      +/-   ##
============================================
- Coverage     72.28%   72.13%   -0.16%
  Complexity     7302     7302
============================================
  Files           722      722
  Lines         32593    32640      +47
  Branches       3410     3425      +15
============================================
- Hits          23561    23545      -16
- Misses         7407     7466      +59
- Partials       1625     1629       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Should we mention the most popular remark presets somewhere?

Link to most popular presets on NPM?
https://www.npmjs.com/search?q=remark-preset
Maybe include this in docs?

Yeah sure! Want to set this up? I’d say under “List of Plugins”, add a “List of Presets”?

I’d say only add stuff that’s recently maintained though!

Done


Bug: When in validation use required_with

PHP Version
8.2
CodeIgniter4 Version
4.3.6
CodeIgniter4 Installation Method
Composer (using codeigniter4/appstarter)
Which operating systems have you tested for this bug?
Windows
Which server did you use?
apache
Database
mysql 8
What happened?
When use form validation with required_with, and required field is empty next validation in this rules execute anyway.
In "start" rules i have own validation "validRange", it should execute when field "mode" is not empty, but validRange execution any time.
 'mode' => [
            'label'	=> ' ',
            'rules' => 'permit_empty',
        ],

'start' => [
            'label'	=> ' ',
            'rules' => 'required_with[mode]|validRange[18,23]'
        ],

Steps to Reproduce
Create any Rules with required_with
Expected Output
IMHO if "mode" field is empty, "start" empty should be skipped i any validations
Anything else?
No response

required_with
The field is required when any of the other
fields is not empty() in the data.
https://codeigniter4.github.io/CodeIgniter4/libraries/validation.html#rules-for-general-use


[windows] keyboard show without textfield in tablet mode

Tap textfield to show keyboard.
Push to next page.
Textfield still show.

Please help me to fix this problem, thanks.
https://user-images.githubusercontent.com/45662066/160526793-1abf7007-5822-4b9d-9090-6f5cb17ee1c8.mp4

Hi @TungWang, Thanks for filing the issue.
There is a similar issue describing this case https://github.com/flutter/flutter/issues/99050, Please follow up there for further updates, Closing this issue as a duplicate. If you disagree feel free to write in the comments and we will reopen it.
Thank you.


FriendlyEats Quickstart: Add Firestore Emulator and Skeleton for later emulators

This P.R. adds the required firebase.json and environments.ts files to run the firebase local emulators with the angular rewrite of the FriendlyEats app. Additionally, this PR also introduces some "starter data" (imported from the newly created /exported-firestore directory). The version of the app with the emulators can be run with this command:
firebase --project demo-friendly-eats emulators:exec --import ./exported-firestore --export-on-exit=./exported-firestore 'ng serve'

Are the metadata JSONs necessary? What purpose do they serve..?

Are the metadata JSONs necessary? What purpose do they serve?

Great question!
The metadata JSONs were auto-generated by the storage/firestore emulators when I ran the emulators with the --export-on-exit flag. They should be necessary, since I want to package the quickstart with an initial set of data that the emulators can import before serving the app. With them, I know that (when run with emulators enabled) firestore will immediately be initialized with a set of restaurants / reviews instead of needing to generate them while the app is running.

Looks great, perhaps we should add instructions to import metadata into emulators, as that is not in any other quickstart!

Gotcha, I'll adjust the README to include the command you need to import data when you run the quickstart.


Array type conversions break method dispatch

Suppose I want to expose a join(arr, sep) function that joins an array of any types of elements by coercing them to strings and joining them with a separator.
This is currently not possible with expr because of the way array types are converted.
If my Go code looks like this:
func Join(arr []interface{}, string sep) string {
	b := strings.Builder{}
	for i, e := range arr {
		if i > 0 {
			b.WriteString(sep)
		}
		b.WriteString(myToString(e))

	}
	return b.String()
}

This call will work: join([1, "two"], " ")
And these will fail (because arr is of type []int and []string respectively): join([1, 2], " "), and join(["one", "two"], " ").
Not sure how to go about this... I could maybe patch the AST, but it could also be added as a compiler opt?

Join(arr interface{}, string sep) string

Thanks for the suggestion :+1:


Is this extension now unsupported?

I hate these sorts of issues because it makes me feel like folks poking around for free work, but I have to ask: Is this extension still supported by Stoplight/SmartBear?
I ask because I wrote the original code for it, got contacted by Stoplight so they could take over (trying to deprecate my extension and redirect to this one was quite the effort), and now... it's very stale, from dependencies to features/fixes. All the people I worked with on that (@philsturgeon, @P0lip, etc.)... don't appear to work at Stoplight anymore. (Or maybe they do? I can't tell, but quick research says maybe not.) The only person I see committing is @mnaumanali94 and that was basically just a quick release and readme update nearly a year and a half ago.
I'm curious if the path to getting things updated is to fork and re-release my own version of the extension.

Hi @tillig
Yes, we do want to keep this extension supported and improve it into the future. Apologies on the slow response to this issue. We’re getting things back in order across some of the various Spectral and related repositories (recently releasing new core rulesets for Arazzo into Spectral etc.) and will continue in that vein.
We welcome your valuable contribution on this project. @mnaumanali94 and I will be in touch to see how we can move it forward.


Feature to specify namespace in helmDefaults.

Currently in helm3 we can have helm charts releases namespace specific so to be able to specify all the helm-charts namespace at once we can have namespace variable in helmDefaults .So that user don't have to specify it in each and every release in helmfile.yaml.

Hi....when we are expecting this feature?

I think, it will be very good feature to have.


Fixed issue

Pull Request Type
What kind of change does this PR introduce?
[X] Solved an issue/task
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:
What is the current behavior?

Issue Number: [Insert Issue Number (if applicable)] #1379
What is the new behavior?

I have create an XML representation for the Bookstore as your task requested
Other information

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out my other projects. Just click here to find more. These projects contain real issues that you can help resolve. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


Test Runner output is blank

OS Version: macOS Big Sur 11.2.3

Steps to Reproduce:

Use the vscode test runner
Run some failed tests
🐛 The test output is blank for the failed tests, but the output channel has output

Does this issue occur when all extensions are disabled?: Yes/No

What is the output in the output channel?

x OpenerService delegate to commandsService, command:someid
AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
123 !== '123'
at Context.<anonymous> (file:///Users/lramos15/upstream/vscode/out/vs/editor/test/browser/services/openerService.test.js:68:20)

Test process exited with code 1


Fix some things for extract component

Extract component had some odd behavior around MarkupTextLiteralSyntax selection.
Previously it would not allow a user to have a text literal as the start or end of the selection, it would always try to get the parent block. That works as intended for most cases where a user is highlighting inside a tag and the tag shouldn't be split. However, if the text is top level in the document it won't have a parent tag and thus would not have been considered a valid selection. This allows for that scenario.
There was also an issue if the selection was following a tag with a sibling text literal. If the selection ended after the brace but the text literal was not empty the selection would fail. For example:
[|
Hello
|]

Welcome to your new app

In the above the end of the selection is in the MarkupTextLiteralSyntax when it should be on the h1 node. A check for if the position was at the beginning of a text literal and it has a previous sibling was added to account for this.

@davidwengier I tried to add more comments, clean up the logic, and added a few more test for cases. Enough has changed it's probably worth a re-review


Suggestion for level_8 Description

The sentence is grammatically correct, but it's a little confusing and I would like to suggest a change
Thank you!

I have just changed the Readability of the sentence!
I am not sure why Travis is failing for this PR

Thanks! <3


CM2022 changes with float timestamps

This is intended to supersede #82.  Changes are currently in progress, but it may be helpful to discuss as the changes are propagated through the code.

Updated for float timestamps for now. Ran most of the recipes in the Makefile. Please take a look @mcolomermolla
DtsCalculator and EvalMap aren't updated much (and DtsCalculator taken out of the module for now), because a certain amount of rewriting is needed.

I made a first review after going through it. However, I did not see the new changes in the branch dwb-cm22-floats in this or a separate PR. Are you just waiting to first merge this one?

Inclined to merge soon.  May need to rename the histogram value/gen/renderer objects later.
EvalMap will need updating, or, more accurately, debugging needs to continue to EvalMap.  Probably remove gen.NeutrinoArrivalTime as well, now that we have some better implementations.


Give a rough preview of TeX content

This is a stripped-down early version, for the beta, of:

#46

Specifically, when we encounter TeX content (this Zulip feature: https://zulip.com/help/latex ), we'll want to show some usable approximation of it, pending the implementation of #46 with the full styling. This probably means showing the original TeX source — which conveniently is embedded inside the HTML — with perhaps some styling to indicate that it's TeX/LaTeX.
Handling these means parsing them in lib/model/content.dart, and then displaying them appropriately in lib/widgets/content.dart. In parsing, we should ignore all the parts of the HTML we won't yet be using — when we later pursue #46, we'll add parsing for those guided by our needs then.
This issue can also be seen as a special case of:

#194

A person who uses Zulip in a math-oriented community tried the beta and reported this unimplemented feature here:
https://chat.zulip.org/#narrow/stream/48-mobile/topic/TeX.20in.20Flutter.20app/near/1710610
This stripped-down version will be straightforward to implement, so I've gone ahead and bumped its milestone. (I'm more hesitant to prioritize the full implementation #46, because that will be a more substantial amount of work.) The one nontrivial question is how to style it.


Add kube-vip charts

Towards https://github.com/giantswarm/giantswarm/issues/26409
Will be consumed like this https://github.com/giantswarm/cluster-vsphere/pull/47/files#diff-dc03b8333bb6ea74c07f339ba318d823a627f7897f32e83ff0ec35a1473e183bR50
Testing

[x] fresh install works
[x] upgrade from previous version works

Checklist

[x] Update changelog in CHANGELOG.md.
[x] Make sure values.yaml and values.schema.json are valid.

Images are available in docker.io and quay.io. This PR can be merged if there is no objection.


Implement dbStats for SQLite

Description
Closes #3259.

It does not cover collStats, that will be in another PR.
Readiness checklist

[ ] I added/updated unit tests (and they pass).
[x] I added/updated integration/compatibility tests (and they pass).
[x] I added/updated comments and checked rendering.
[ ] I made spot refactorings.
[ ] I updated user documentation.
[ ] I ran task all, and it passed.
[x] I ensured that PR title is good enough for the changelog.
[ ] (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
[ ] I marked all done items in this checklist.

Response of implementation
test> db.runCommand({dbStats: 1})                                                                                [26/510]
{
  db: 'test',
  collections: Long("0"),
  views: 0,
  objects: Long("0"),
  dataSize: Long("0"),
  storageSize: Long("0"),
  indexes: Long("0"),
  indexSize: Long("0"),
  totalSize: Long("0"),
  scaleFactor: 1,
  ok: 1
}
test> db.coll.insertMany([{_id: 1}, {_id: 2}])
{ acknowledged: true, insertedIds: { '0': 1, '1': 2 } }
test> db.runCommand({dbStats: 1})
{
  db: 'test',
  collections: Long("1"),
  views: 0,
  objects: Long("2"),
  avgObjSize: Long("2048"),
  dataSize: Long("4096"),
  storageSize: Long("4096"),
  indexes: Long("1"),
  indexSize: Long("4096"),
  totalSize: Long("32768"),
  scaleFactor: 1,
  ok: 1
}

Example of dbstat and sqlite_schema table contents, with empty collection new-collection and 2 documents collection coll.
sqlite> select name, pgsize, ncell from dbstat;
sqlite_schema|4096|8
_ferretdb_collections|4096|2
sqlite_autoindex__ferretdb_collections_1|4096|2
sqlite_autoindex__ferretdb_collections_2|4096|2
new-collection_82bca3b8|4096|0
new-collection_82bca3b8_id|4096|0
sqlite_stat1|4096|2
coll_f244e9a7|4096|2
coll_f244e9a7_id|4096|2

sqlite> select type, name, tbl_name from sqlite_schema;
table|_ferretdb_collections|_ferretdb_collections
index|sqlite_autoindex__ferretdb_collections_1|_ferretdb_collections
index|sqlite_autoindex__ferretdb_collections_2|_ferretdb_collections
table|new-collection_82bca3b8|new-collection_82bca3b8
index|new-collection_82bca3b8_id|new-collection_82bca3b8
table|sqlite_stat1|sqlite_stat1
table|coll_f244e9a7|coll_f244e9a7
index|coll_f244e9a7_id|coll_f244e9a7


Fix conversion of Integer to fixedints

The current implementations of as_i64, as_i32, as_u64, and as_u32 are
all flawed (as well as the der validation of integers) when it comes to
handing particularities around negative integers. Of note is specifically
the following:

DER Validation doesn't properly enforce 8.3.2.b of x.690 for negative
numbers. For example, 0xff 0xff should fail, but will not as the code
currently only checks for whether the first 9 bytes are 0, not
whether they are also 1.
as_i32 / as_i64 could incorrectly interpret a positive integer as a
negative one. Ex: 0x00 0xff 0xff 0xff 0xff will be interpreted as -1
instead of IntegerTooLarge (first bit is not set, so output will be filled
with 0x00, 0x00 gets stripped off by remove_zeros, all bytes get
overwritten by 0xff, thus an i64 taking in the buffer with
from_be_bytes will be -1).
remove_zeros relies on TRO which is usually fine but suboptimial

This change will also make conversion more restrictive when 8.3.2
doesn't hold (even in BER cases) - if excess bytes are supplied, as_*
may report IntegerTooLarge even if the Integer could be represented as a
smaller integer (ex. 0x00 0x00 0x00 0x00 0x01 is accepted today for
as_u32 but will now return IntegerTooLarge). This wouldn't be a
regression in DER as such an encoding would (should?) fail validation,
only for BER.
This commit also makes other changes as well - there is generally less
branching, especially in the signed integer case (relying on shr for
extending the twos compliment bits).

Hi,
Thanks for your contribution!
First of all sorry for the long delay in the reply. This crate was under heavy refactoring to merge/use parsing code from the new asn-rs crate. This is where the parsing code will be moved, and ultimately der-parser will only be a frontend (optional) to asn1-rs.
So, this PR cannot be merged anymore, since the integers are not parsed here anymore. However, I tried to merge and/or verify things during the process.
The relevant code in asn1-rs is in the following section:

https://github.com/rusticata/asn1-rs/blob/master/src/asn1_types/integer.rs#L424-L440 for the DER verifications
https://github.com/rusticata/asn1-rs/blob/master/src/asn1_types/integer.rs#L10-L40 for trimming leading bytes (only for BER)

Could you check that this code implements the same checks as in your code?


Add Text-To-Speech functionality by creating TtsService

This PR has the following modifications:
• Added a new service to Stacked Services called TtsService, aka Text-To-Speech Service.
• Modified example app to show how the TtsService works by creating a new screen.
• Upgraded minSdkVersion to 21.
All those things are under one commit since they are related and would not make sense to make each one as a separate commit.

Are there any problems?

I haven't looked at the code. I just finished the video, been busy with it today for the past 12 hours. I'll get back to open source code reviews tomorrow morning at 4:30 and I'll look at this too.

Okay that’s great to hear 👂

@YazeedAlKhalaf this is not a fundamental service. It's not something that will be required by any basic mobile application so I can't add this dependency into the project is no one will be using this. This can be a separate package that you can maintain called stacked_tts and I'll feature it on the repo under the third party packages

Ah okay I got you 😉.

I will be making upgrades to the dialog service. There will be a choice for the dev to either use default material and Cupertino or the giffy_dialog.
😍

Okay I will be also making the package 📦 and make a new pull request 👌👌🥳

@YazeedAlKhalaf that would be awesome. How far are you with the Material and Cupertino changes, I was going to work on that this week.

I am at the beginning but I have a question, do I start a new pull request or just push the code to my fork?

I will close this pull request and open a new one once I am done with the dialog service thing

I have implemented the Cupertino and material dialogs, still the Giffy dialog 👏🥳

@YazeedAlKhalaf awesome. Just make sure those PR's are separate. Reviewing a big PR will take a lot of time from my side so I'll most likely split it over a week or two.

okay 👍
No worries. I deleted the old fork and started a new one just for this 👌
I will be make the PR now!

@FilledStacks I have sent you some idea Whatsapp, I hope you can see it over there.
Now I have been done with the dialog service in terms of Material and Cupertino. The giffy dialog needs some more time and might not be easy to implement but I will try 👍
Will make the PR right now 😁😊🎉


M3-5679: Querify database credentials reset

Description
What does this PR do?
How to test
What are the steps to reproduce the issue or verify the changes?
How do I run relevant unit tests?

@codyfinn Try this out and let me know what you think.


Failed to Build App

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I have read the Contribution Guidelines

Issue Description
I am trying out fastlane for the first time,
Steps I followed:

Registered a new apple developer account
Created a fresh sample app in Xcode
Installed and initiated fastlane
Initiated match

Now I am trying to make a build of the app and upload to AppStore, but its failing with the error "Error building the application"
How can I fix this issue ?
Complete output when running fastlane, including the stack trace and command used
MacBook-Pro:xxxxappxxxx macuser$ fastlane buildapp
[15:01:32]: -------------------------------------------------
[15:01:32]: --- Step: Verifying required fastlane version ---
[15:01:32]: -------------------------------------------------
[15:01:32]: fastlane version valid
[15:01:32]: ------------------------------
[15:01:32]: --- Step: default_platform ---
[15:01:32]: ------------------------------
[15:01:32]: Driving the lane 'ios buildapp' 🚀
[15:01:32]: -------------------
[15:01:32]: --- Step: match ---
[15:01:32]: -------------------

+-----------------------+-----------------------------------------------------------------+
|                                 Summary for match 0.6.1                                 |
+-----------------------+-----------------------------------------------------------------+
| type                  | appstore                                                        |
| git_url               |<EMAIL_ADDRESS>|
| git_branch            | master                                                          |
| app_identifier        | com.xxxxxxx.xxxxappxxxx                                    |
| username              |<EMAIL_ADDRESS>                                           |
| keychain_name         | login.keychain                                                  |
| readonly              | false                                                           |
| team_id               | YEN9A7S5UB                                                      |
| verbose               | false                                                           |
| force                 | false                                                           |
| shallow_clone         | false                                                           |
| force_for_new_devices | false                                                           |
| skip_docs             | false                                                           |
+-----------------------+-----------------------------------------------------------------+

[15:01:32]: Cloning remote git repo...
[15:01:37]: 🔓  Successfully decrypted certificates repo
[15:01:37]: Verifying that the certificate and profile are still valid on the Dev Portal...
[15:01:43]: Installing certificate...
[15:01:45]: Installing provisioning profile...

+----------------------+--------------------------------------------+
|                  Installed Provisioning Profile                   |
+----------------------+--------------------------------------------+
| App Identifier       | com.xxxxxxx.xxxxappxxxx               |
| Type                 | appstore                                   |
| UUID                 | c56e0138-6913-457e-86ee-c02531bcf301       |
| Environment Variable | sigh_com.xxxxxxx.xxxxappxxxx_appstore |
+----------------------+--------------------------------------------+

[15:01:46]: All required keys, certificates and provisioning profiles are installed 🙌
[15:01:46]: 🔒  Successfully encrypted certificates repo
[15:01:46]: Setting Provisioning Profile type to 'app-store'
[15:01:46]: -----------------
[15:01:46]: --- Step: gym ---
[15:01:46]: -----------------
[15:01:46]: Installing provisioning profile...
[15:01:47]: xcrun xcodebuild -list -project ./xxxxappxxxx.xcodeproj

+---------------------------+----------------------------------------------------------------------+
|                                      Summary for gym 1.6.3                                       |
+---------------------------+----------------------------------------------------------------------+
| scheme                    | xxxxappxxxx                                                      |
| export_method             | app-store                                                            |
| project                   | ./xxxxappxxxx.xcodeproj                                          |
| provisioning_profile_path | /Users/macuser/Documents/dev/fastline/test2/xxxxappxxxx/A... |
| destination               | generic/platform=iOS                                                 |
| output_name               | xxxxappxxxx                                                      |
| clean                     | false                                                                |
| output_directory          | .                                                                    |
| silent                    | false                                                                |
| use_legacy_build_api      | false                                                                |
| buildlog_path             | ~/Library/Logs/gym                                                   |
+---------------------------+----------------------------------------------------------------------+

[15:01:48]: $ set -o pipefail && xcodebuild -scheme xxxxappxxxx -project ./xxxxappxxxx.xcodeproj -destination 'generic/platform=iOS' -archivePath '/Users/macuser/Library/Developer/Xcode/Archives/2016-06-11/xxxxappxxxx 2016-06-11 15.01.48.xcarchive' archive | tee /Users/macuser/Library/Logs/gym/xxxxappxxxx-xxxxappxxxx.log | xcpretty
[15:01:49]: ▸ Building xxxxappxxxx/xxxxappxxxx [Release]
[15:01:49]: ▸ Check Dependencies
[15:01:50]: ▸ Compiling SecondViewController.swift
[15:01:51]: ▸ Compiling AppDelegate.swift
[15:01:51]: ▸ Compiling FirstViewController.swift
[15:01:51]: ▸ Compiling SecondViewController.swift
[15:01:51]: ▸ Compiling AppDelegate.swift
[15:01:51]: ▸ Compiling FirstViewController.swift
[15:01:51]: ▸ Linking xxxxappxxxx
[15:01:51]: ▸ Linking xxxxappxxxx
[15:01:51]: ▸ Compiling LaunchScreen.storyboard
[15:01:53]: ▸ Compiling Main.storyboard
[15:01:53]: ▸ Processing Info.plist
[15:01:53]: ▸ Generating 'xxxxappxxxx.app.dSYM'
[15:01:54]: ▸ Touching xxxxappxxxx.app
[15:01:58]: ▸ Signing /Users/macuser/Library/Developer/Xcode/DerivedData/xxxxappxxxx-epcgkiavcyvacwdofmwoyjaobgkz/Build/Intermediates/ArchiveIntermediates/xxxxappxxxx/InstallationBuildProductsLocation/Applications/xxxxappxxxx.app
[15:01:59]: ▸ Touching xxxxappxxxx.app.dSYM
[15:01:59]: ▸ Archive Succeeded
xattr: No such file: /Users/macuser/Library/Developer/Xcode/Archives/2016-06-11/xxxxappxxxx 2016-06-11 15.01.48.xcarchive
[15:01:59]: The generated archive is invalid, this can have various reasons:
[15:01:59]: Usually it's caused by the `Skip Install` option in Xcode, set it to `NO`
[15:01:59]: For more information visit https://developer.apple.com/library/ios/technotes/tn2215/_index.html
[15:01:59]: Also, make sure to have a valid code signing identity and provisioning profile installed
[15:01:59]: Follow this guide to setup code signing https://github.com/fastlane/fastlane/blob/master/fastlane/docs/CodeSigning.md
[15:01:59]: If your intention was only to export an ipa be sure to provide a valid archive at the archive path.
[15:01:59]: Variable Dump:
[15:01:59]: {:DEFAULT_PLATFORM=>:ios, :PLATFORM_NAME=>:ios, :LANE_NAME=>"ios buildapp", :SIGH_PROFILE_TYPE=>"app-store"}
[15:01:59]: Archive invalid

+------+-------------------------------------+-------------+
|                     fastlane summary                     |
+------+-------------------------------------+-------------+
| Step | Action                              | Time (in s) |
+------+-------------------------------------+-------------+
| 1    | Verifying required fastlane version | 0           |
| 2    | default_platform                    | 0           |
| 3    | match                               | 14          |
| 4    | gym                                 | 12          |
+------+-------------------------------------+-------------+

[15:01:59]: fastlane finished with errors

[!] Archive invalid
MacBook-Pro:xxxxappxxxx macuser$ sudo fastlane buildapp
Password:
[15:02:21]: -------------------------------------------------
[15:02:21]: --- Step: Verifying required fastlane version ---
[15:02:21]: -------------------------------------------------
[15:02:21]: fastlane version valid
[15:02:21]: ------------------------------
[15:02:21]: --- Step: default_platform ---
[15:02:21]: ------------------------------
[15:02:21]: Driving the lane 'ios buildapp' 🚀
[15:02:21]: -------------------
[15:02:21]: --- Step: match ---
[15:02:21]: -------------------

+-----------------------+-----------------------------------------------------------------+
|                                 Summary for match 0.6.1                                 |
+-----------------------+-----------------------------------------------------------------+
| type                  | appstore                                                        |
| git_url               |<EMAIL_ADDRESS>|
| git_branch            | master                                                          |
| app_identifier        | com.xxxxxxx.xxxxappxxxx                                    |
| username              |<EMAIL_ADDRESS>                                           |
| keychain_name         | login.keychain                                                  |
| readonly              | false                                                           |
| team_id               | YEN9A7S5UB                                                      |
| verbose               | false                                                           |
| force                 | false                                                           |
| shallow_clone         | false                                                           |
| force_for_new_devices | false                                                           |
| skip_docs             | false                                                           |
+-----------------------+-----------------------------------------------------------------+

[15:02:22]: Cloning remote git repo...
[15:02:27]: 🔓  Successfully decrypted certificates repo
[15:02:27]: Verifying that the certificate and profile are still valid on the Dev Portal...
[15:02:32]: Installing certificate...
[15:02:34]: Installing provisioning profile...

+----------------------+--------------------------------------------+
|                  Installed Provisioning Profile                   |
+----------------------+--------------------------------------------+
| App Identifier       | com.xxxxxxx.xxxxappxxxx               |
| Type                 | appstore                                   |
| UUID                 | c56e0138-6913-457e-86ee-c02531bcf301       |
| Environment Variable | sigh_com.xxxxxxx.xxxxappxxxx_appstore |
+----------------------+--------------------------------------------+

[15:02:35]: All required keys, certificates and provisioning profiles are installed 🙌
[15:02:35]: 🔒  Successfully encrypted certificates repo
[15:02:35]: Setting Provisioning Profile type to 'app-store'
[15:02:35]: -----------------
[15:02:35]: --- Step: gym ---
[15:02:35]: -----------------
[15:02:35]: Installing provisioning profile...
[15:02:35]: xcrun xcodebuild -list -project ./xxxxappxxxx.xcodeproj

+---------------------------+----------------------------------------------------------------------+
|                                      Summary for gym 1.6.3                                       |
+---------------------------+----------------------------------------------------------------------+
| scheme                    | xxxxappxxxx                                                      |
| export_method             | app-store                                                            |
| project                   | ./xxxxappxxxx.xcodeproj                                          |
| provisioning_profile_path | /Users/macuser/Documents/dev/fastline/test2/xxxxappxxxx/A... |
| destination               | generic/platform=iOS                                                 |
| output_name               | xxxxappxxxx                                                      |
| clean                     | false                                                                |
| output_directory          | .                                                                    |
| silent                    | false                                                                |
| use_legacy_build_api      | false                                                                |
| buildlog_path             | ~/Library/Logs/gym                                                   |
+---------------------------+----------------------------------------------------------------------+

[15:02:37]: $ set -o pipefail && xcodebuild -scheme xxxxappxxxx -project ./xxxxappxxxx.xcodeproj -destination 'generic/platform=iOS' -archivePath '/Users/macuser/Library/Developer/Xcode/Archives/2016-06-11/xxxxappxxxx 2016-06-11 15.02.37.xcarchive' archive | tee /Users/macuser/Library/Logs/gym/xxxxappxxxx-xxxxappxxxx.log | xcpretty
[15:02:38]: ▸ Building xxxxappxxxx/xxxxappxxxx [Release]
[15:02:38]: ▸ Check Dependencies
[15:02:38]: ▸ ❌  Code Sign error: No matching provisioning profile found: Your build settings specify a provisioning profile with the UUID “c56e0138-6913-457e-86ee-c02531bcf301”, however, no such provisioning profile was found.
[15:02:38]: ▸ ** ARCHIVE FAILED **
[15:02:38]: ▸ The following build commands failed:
[15:02:38]: ▸ Check dependencies
[15:02:38]: ▸ (1 failure)
▸ Building xxxxappxxxx/xxxxappxxxx [Release]
▸ Check Dependencies

❌  Code Sign error: No matching provisioning profile found: Your build settings specify a provisioning profile with the UUID “c56e0138-6913-457e-86ee-c02531bcf301”, however, no such provisioning profile was found.

** ARCHIVE FAILED **

The following build commands failed:
Check dependencies
(1 failure)
[15:02:38]: Exit status: 65
[15:02:38]: Invalid code signing settings
[15:02:38]: Your project defines a provisioning profile which doesn't exist on your local machine
[15:02:38]: You can use sigh (https://github.com/fastlane/fastlane/tree/master/sigh) to download and install the provisioning profile
[15:02:38]: Follow this guide: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/CodeSigning.md
[15:02:38]: Variable Dump:
[15:02:38]: {:DEFAULT_PLATFORM=>:ios, :PLATFORM_NAME=>:ios, :LANE_NAME=>"ios buildapp", :SIGH_PROFILE_TYPE=>"app-store"}
[15:02:38]: Error building the application - see the log above

+------+-------------------------------------+-------------+
|                     fastlane summary                     |
+------+-------------------------------------+-------------+
| Step | Action                              | Time (in s) |
+------+-------------------------------------+-------------+
| 1    | Verifying required fastlane version | 0           |
| 2    | default_platform                    | 0           |
| 3    | match                               | 13          |
| 4    | gym                                 | 2           |
+------+-------------------------------------+-------------+

[15:02:38]: fastlane finished with errors

[!] Error building the application - see the log above
MacBook-Pro:xxxxappxxxx macuser$

Configuration Files
Fastfile:
fastlane_version "1.95.0"
default_platform :ios

platform :ios do

  lane :buildapp do
    match(type: "appstore")
    gym(scheme: "xxxxxxx") # Build your app - more options available
  end

end

Matchfile:
git_url "xxxxxx"
type "development" # The default type, can be: appstore, adhoc or development

Skip Install Option

Environment
fastlane version (run fastlane -v): fastlane 1.95.0
Do you use bundler to execute fastlane (i.e. bundle exec fastlane)? No
Do you use a Ruby environment manager (e.g. chruby, rbenv, rvm)? No

Worked after setting the active path manually in Gymfile
# For more information about this configuration visit
# https://github.com/fastlane/gym#gymfile

output_directory "./build"    # store the ipa in this folder
archive_path "/Users/macuser/Documents/TestApp/fastlane/Archive/myapp"

Is this the right way to do this? Is it necessary to set archive_path?

Hi @arv1989 Looks good to me. In some configs you might need to set the archive path. Thanks for letting us know! 👍


Update Paul's pgp key signature

Is this key downloadable from a keyserver?  Is it signed in some traceable way?  I can't find it on the few I look at.

I uploaded it to one yesterday.

It exists on some keyservers....

It exists on some keyservers....

Let's hope it propagates...

It exists on some keyservers....

Let's hope it propagates...

Ah, it has!  Now I'm finding it on keys.openpgp.org

For verifiability, may I suggest you sign the new key with the old key?

I don't have the old key.  I created it by mistake and deleted it almost immediately.

I suppose @levitte is OK with it being urgent for the release.

Repo is currently frozen so its not there yet - but this will be in today's release in master and 3.0.


Support ssl_ciphers with Chinese SM2, SM3, SM4, ZUC and etc. in HTTP3

Why you need it?

How it could be?

Other related information

非常非常希望能支持国密套件即RFC8998，希望tengine+xquic+tongsuo能打造能支持国密quic的软件栈。


Added NIST CSF

per https://blogs.msdn.microsoft.com/azuregov/2017/05/23/azure-blueprint-illustrates-the-clear-path-to-meet-the-cybersecurity-executive-order/

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@CHDAFNI-MSFT : Thanks for your contribution to the Azure documentation! The author, @jomolesk, has been notified to review your proposed change.

#sign-off


punic search Async failed

punic search Async
Traceback (most recent call last):
  File "/usr/local/bin/punic", line 11, in <module>
    load_entry_point('punic==0.2.1', 'console_scripts', 'punic')()
  File "/usr/local/lib/python2.7/site-packages/punic/punic_cli.py", line 369, in main
    punic_cli()
  File "/usr/local/lib/python2.7/site-packages/click/core.py", line 716, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python2.7/site-packages/click/core.py", line 696, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python2.7/site-packages/click/core.py", line 1060, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python2.7/site-packages/click/core.py", line 889, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python2.7/site-packages/click/core.py", line 534, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python2.7/site-packages/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/usr/local/lib/python2.7/site-packages/punic/punic_cli.py", line 365, in search
    github_search(punic, name, cartfile_append=append, language=language)
  File "/usr/local/lib/python2.7/site-packages/punic/search.py", line 29, in github_search
    repositories = GitHub().search(name, language = language)
  File "/usr/local/lib/python2.7/site-packages/punic/github.py", line 43, in search
    r = requests.get('https://api.github.com/search/repositories?q={}&sort=stars'.format(q), auth = self.auth, headers = headers)
  File "/usr/local/lib/python2.7/site-packages/memoize.py", line 11, in _property
    setattr(self, attribute, fn(self))
  File "/usr/local/lib/python2.7/site-packages/punic/github.py", line 36, in auth
    github_user = unicode(subprocess.check_output(shlex.split('git config --get github.user')).strip(), 'utf-8')
  File "/usr/local/Cellar/python/2.7.12/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 574, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
subprocess.CalledProcessError: Command '['git', 'config', '--get', 'github.user']' returned non-zero exit status 1

Fixed on develop. I don't want to push new version with just this change quite yet - so if you need to use it use:
pip install -U git+https://github.com/schwa/punic.git@develop
Thanks


getCell().value; can be either 'string' or 'object'

There doesn't appear to be uniformity when trying to read the text value of a cell. I get either a string or object, meaning I have to check the type of each cell's value first and act accordingly.
Row: 125
*[CHI - 032] The team member recognizes all loyalty programme members with a warm comment of appreciation (e.g.: "Thank you for your loyalty / trust").

Typeof: string

{ richText:
   [ { text: '*[CHI - 032] O membro da equipe cumprimenta todos os associados do programa de fidelidade com um comentário caloroso (por exemplo:' },
     { font: [Object],
       text: ' "Obrigado por sua fidelidade/confiança.").' } ] }

Typeof: object

(node:2350) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): TypeError: worksheet.getRow(...).getCell(...).value.replace is not a function

console.log(worksheet.getRow(row).getCell(1).value);
console.log(`Typeof: ${typeof worksheet.getRow(row).getCell(1).value)});
let original = worksheet.getRow(row).getCell(1).value.replace(/\r/g, '').trim();

console.log(worksheet.getRow(row).getCell(1).value);
console.log(`Typeof: ${typeof worksheet.getRow(row).getCell(1).value)});
let translation = worksheet.getRow(row).getCell(column).value.replace(/\r/g, '').trim();

Use `getCell(1).text" instead?

The value property is intended to return something most useful for the type of value stored in the cell. For text it will be string, for numbers it will be JavaScript numbers, dates are the JS Date, etc. For more complicated value types (e.g. hypertexts, rich strings, error values, etc) the only sensible representation is an object.
As Rycochet said, if you only ever want the text value, you can access the .text property and the cell will try to return the most sensible text representation.

Ok, thank you for clearing that up. I didn't see it in the readme anywhere.


Support Keras.

@marwage @andrei3131 Could you test this PR in your project? I have tested this using the new keras_mnist example and it seems to work well.

@lgarithm Does this look good to you?

I get the following error when running the example
Traceback (most recent call last):
File "examples/keras_mnist.py", line 102, in
validation_data=(x_test, y_test))
File "/Users/marcel/Studies/UROP/KungFu/kungfu-venv/lib/python3.7/site-packages/keras/engine/training.py", line 1239, in fit
validation_freq=validation_freq)
File "/Users/marcel/Studies/UROP/KungFu/kungfu-venv/lib/python3.7/site-packages/keras/engine/training_arrays.py", line 210, in fit_loop
verbose=0)
File "/Users/marcel/Studies/UROP/KungFu/kungfu-venv/lib/python3.7/site-packages/keras/engine/training_arrays.py", line 407, in test_loop
callbacks._call_begin_hook('test')
File "/Users/marcel/Studies/UROP/KungFu/kungfu-venv/lib/python3.7/site-packages/keras/callbacks/callbacks.py", line 105, in _call_begin_hook
self.on_test_begin()
File "/Users/marcel/Studies/UROP/KungFu/kungfu-venv/lib/python3.7/site-packages/keras/callbacks/callbacks.py", line 239, in on_test_begin
callback.on_test_begin(logs)
AttributeError: 'BroadcastGlobalVariablesCallback' object has no attribute 'on_test_begin'

We need a BroadcastGlobalVariablesCallback(keras.callbacks.Callback)


[CLOSED] Add support for Host candidates

 Issue by GoogleCodeExporter
Monday Jul 13, 2015 at 21:30 GMT
Originally opened as https://github.com/bgrozev/ice4j/issues/2

Add support for local candidates

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 12 Jan 2010 at 2:06

 Comment by GoogleCodeExporter
Monday Jul 13, 2015 at 21:30 GMT

Original comment by<EMAIL_ADDRESS>on 12 Jan 2010 at 2:06

Added labels: Type-Task

 Comment by GoogleCodeExporter
Monday Jul 13, 2015 at 21:30 GMT

Original comment by<EMAIL_ADDRESS>on 17 Mar 2010 at 12:54

Changed title: Add support for Host candidates

 Comment by GoogleCodeExporter
Monday Jul 13, 2015 at 21:30 GMT

Original comment by<EMAIL_ADDRESS>on 17 Mar 2010 at 12:54

Changed state: Fixed


Add Bonjour extension

Description

A new extension to list services available over Bonjour
Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

considering renaming this mDNS

ok, I've added a 3 second timeout and allowed it to continue listening


Alert when sites are stuck building (build timeout)

We recently had a situation where:

Course author published a site to draft.
Concourse was stuck indefinitely. It was stuck discovering inputs, specifically "Waiting for suitable version" of webpack-json". Manually running fly check-resource on the offending pipeline/resource managed to get the thing unstuck.
Course author alerted us.

Effectively, the site silently failed to publish and the Studio UI was stuck in "Pending". (Concourse did not consider itself failing, but it was never going to succeed.)
We should raise an alert in this scenario so that the failure is not silent.

One idea: Studio triggers the build, and site builds are fast, so Studio could issue an alert if the site fails to build within X minutes.


RED-67784 adding debug mode

@mendybr please fix the 3 eslint issues, also how can we sync it with the IDE checks?


Disable saving nn.Module with save_hyperparameters()

What does this PR do?

Addresses: https://github.com/PyTorchLightning/pytorch-lightning/issues/11834#issuecomment-1034752642
nn.Modules are not hparams and when someone uses LM as systems, they might forget to ignore the arguments and they will be saved inside hparams thus will increase the size of the checkpoint.
Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

[ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃
cc @borda

It's probably ok to do this, but we should stop here. There are many other parameter type that may ore may not be desired to serialize, however we can't do the guess work for everything.
Note: If we go with this PR, there is no way for the user to force what is being ignored here. I hesitate to accept here, because normally we shouldn't make such assumptions for the user (the framework should not be limiting them).

It's probably ok to do this, but we should stop here. There are many other parameter type that may or may not be desired to serialize, however we can't do the guess work for everything.
Note: If we go with this PR, there is no way for the user to force what is being ignored here. I hesitate to accept here, because normally we shouldn't make such assumptions for the user (the framework should not be limiting them).

I agree, my idea here was to avoid only nn.Modules because that's already been captured when we save state_dict inside the checkpoint. Other different types of arguments will not be captured automatically.
I was running t5-small, and it got stuck due to this, with no errors at all, so it was hard to figure out what went wrong here until I did some debugging with @krshrimali .
We can mention this inside docstrings if required.

I'm also hesitant about this.

I was running t5-small, and it got stuck due to this, with no errors at all, so it was hard to figure out what went wrong here until I did some debugging with @krshrimali .

What if we focus instead on notifying the user about the associated problems? We can suggest excluding the keys with save_hyperaprameters

I'm also hesitant about this.

I was running t5-small, and it got stuck due to this, with no errors at all, so it was hard to figure out what went wrong here until I did some debugging with @krshrimali .

What if we focus instead on notifying the user about the associated problems? We can suggest excluding the keys with save_hyperaprameters

well, that's a good suggestion. works for me since it will happen during init. If everyone agrees on this, I'll update the PR :)


Update to material3 and added dynamic color personalization feature

Guidelines
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce?

[x] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Preparing a pull request for review
Ensure your change is properly formatted by running:
$ ./gradlew spotlessApply

Please correct any failures before requesting a review.

@skydoves requesting a review


Marks append vec test utils as DCOU

Problem
AppendVec's test_utils module can be called by non-tests.
Summary of Changes
Mark it as DCOU.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.8%. Comparing base (9ba0d6f) to head (40a5d01).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #820   +/-   ##
=======================================
  Coverage    81.8%    81.8%
=======================================
  Files         851      851
  Lines      231556   231556
=======================================
+ Hits       189449   189505   +56
+ Misses      42107    42051   -56


Fix DateTime ticks discrepancy from full .NET

Description

Fix implementation of _ticksAtOrigin.

Motivation and Context

Our DateTime tick values was different from the .NET implementation.
Bump version to 1.2.5-preview.

How Has This Been Tested?

Screenshots
Types of changes

[ ] Improvement (non-breaking change that improves a feature, code or algorithm)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Signed-off-by: José Simões<EMAIL_ADDRESS>

SonarCloud Quality gate failing because of lack of tests. Accepting.


add OPT_HTTPAUTH flags and new OPT_SSLVERSION flags

The patch allows talking to Intel vPro / AMT using go-curl. AMT requires HTTP digest auth and uses aged TLSv1, which can (and must) be explicitly specified in more recent versions of curl. Tested on macOS Sierra (which hasn't curl 7.52.0 yet but 7.49.1 -- thus I still left TLSv1_3 commented out...).
Thanks a lot for go-curl!

Hmm. Sorry for the broken travis-ci build... but it's using Ubuntu Precise (12.04 LTS), which will be EOL'ed April next year. Even Debian jessie/stable has curl 7.38... Should I come back next year? ;-)

👍  Thanks for your work.
Take a look at compat.h
And also misc/compatgen.py
Waiting for your fix! :)

Update:
the compatgen.py needs an up-to-date curl repo, and all version tags.
it run through all supported versions and generate a compat.h for missing definition.


Directions on how to use the tool

I just read your article in Opensource.com (great article) but I did not see any usage directions.

Let me know if that isn't clear enough for you. Happy to help!


resizeNearest2x on android crash

when image size is 224x224, the resizeNearest2x on android is fine,
but when image size is 512x512, it is wrong.
what is wrong?
update:
it is crash in conv_op_impl.h "RunOnDeviceWithOrderNCHW()" , the last line "f(&col_buffer_)"
what does the "f" function do, where is the function code?

I come to here because I'm also experiencing a similar crashing issue on this function. The function f is a lambda function inside RunOnDeviceWithOrderNCHW.


Steam API Key

Hi,
I read others same issues, but any help me.
My system:
Ubuntu: Ubuntu 14.04.3;
Apache: Apache/2.4.7;
PHP: PHP 5.6.14-1+deb.sury.org~trusty+1 (cli);
cURL: Enabled;
IPS: <IP_ADDRESS> (100045);
and i use CloudFire.
My error is: login_handler_steam rejected the details provided. Please check the details you provided have been entered correctly and try again.

@marcelotk15 available? http://steamcommunity.com/id/madman32395

@Lavoaster Ran the IPB4 System Check, user meets requirements 100%, cURL is enabled and meets/exceeds required for IPS as well.  ; user also uses CloudFlare, had him enter steamAPI ip addresses into outbound firewall from valve as troubleshoot. No Change.

Really i don't know what is wrong. I put manually infos in database (steam API and steamid). Nothing... don't sync, won't login.
Thanks for support in steam @madman32395!

once a fix is found for this one might be possible fix for #35

Now is working.
I formated my VPS and install packages (php. apache and etc) with Zpanel scrip https://github.com/zpanel/installers


pipenv sync needs to be called twice to install all VCS dependencies

Issue description
I have a project that uses few dependencies that I install from a private Gitlab instance.
Project A requires Library X in its setup.py and mentions it solely by name.
Project B requires Project A.
The Pipfile of Project B contains and editable VCS dependency to Project A and Library X. When running pipenv sync for the first time, the installation fails because Pipenv tries to resolve the dependencies from setup.py using pypi. After I execute pipenv sync the second time, everything is installed as expected.
This problem does not occur, when I run pipenv sync --sequential
Expected result
VCS dependencies get resolved and installed.
Actual result
Not all VCS dependencies get resolved and installed.
Excerpt from pipenv sync --verbose:
Collecting library-x (from project-a)
  1 location(s) to search for versions of library-x:
  * https://pypi.org/simple/library-x/
  Getting page https://pypi.org/simple/library-x/
  Looking up "https://pypi.org/simple/library-x/" in the cache
  Request header has "max_age" as 0, cache bypassed
  Starting new HTTPS connection (1): pypi.org:443
  https://pypi.org:443 "GET /simple/library-x/ HTTP/1.1" 404 13
  Status code 404 not in (200, 203, 300, 301)
  Could not fetch URL https://pypi.org/simple/library-x/: 404 Client Error: Not Found for url: https://pypi.org/simple/library-x/ - skipping
Cleaning up...
Removed build tracker '/tmp/pip-req-tracker-u9fp4m0k'
Exception information:
Traceback (most recent call last):
  File "/home/username/.local/share/virtualenvs/project-b-DmiURb3f/lib/python3.7/site-packages/pip/_internal/cli/base_command.py", line 143, in main
    status = self.run(options, args)
  File "/home/username/.local/share/virtualenvs/project-b-DmiURb3f/lib/python3.7/site-packages/pip/_internal/commands/install.py", line 318, in run
    resolver.resolve(requirement_set)
  File "/home/username/.local/share/virtualenvs/project-b-DmiURb3f/lib/python3.7/site-packages/pip/_internal/resolve.py", line 102, in resolve
    self._resolve_one(requirement_set, req)
  File "/home/username/.local/share/virtualenvs/project-b-DmiURb3f/lib/python3.7/site-packages/pip/_internal/resolve.py", line 256, in _resolve_one
    abstract_dist = self._get_abstract_dist_for(req_to_install)
  File "/home/username/.local/share/virtualenvs/project-b-DmiURb3f/lib/python3.7/site-packages/pip/_internal/resolve.py", line 209, in _get_abstract_dist_for
    self.require_hashes
  File "/home/username/.local/share/virtualenvs/project-b-DmiURb3f/lib/python3.7/site-packages/pip/_internal/operations/prepare.py", line 218, in prepare_linked_requirement
    req.populate_link(finder, upgrade_allowed, require_hashes)
  File "/home/username/.local/share/virtualenvs/project-b-DmiURb3f/lib/python3.7/site-packages/pip/_internal/req/req_install.py", line 164, in populate_link
    self.link = finder.find_requirement(self, upgrade)
  File "/home/username/.local/share/virtualenvs/project-b-DmiURb3f/lib/python3.7/site-packages/pip/_internal/index.py", line 621, in find_requirement
    'No matching distribution found for %s' % req
pip._internal.exceptions.DistributionNotFound: No matching distribution found for library-x (from project-a)

Steps to replicate
$ pipenv --rm
$ pipenv sync
$ pipenv sync

Sorry in advance for not pasting my Pipfile and the output of pipenv --support. Both contain quite a lot of auth-tokens that I don't want to share and I am affraid to accidentally miss when redacting the output.
I might be able to recreate the problem with a few minimal github-repositories tomorrow.

So far, I had no luck in reproducing the problem from scratch :/. Will try again later.

I actually nailed this one down...
during the first pass at installation, pip attempts to build a wheel for this package before ultimately deleting the source.
the source gets deleted before it gets installed.
oops.

Thanks for investigating :)

I believe this is resolved as of #3298 -- closing for now, feel free to try that out and let me know if you have any issues
I will be cutting a release this week with the update, thanks for your patience!

I installed 54a73d1c9f72a27d16d33c40396df57f383303fe, ran pipenv sync and no errors occurred. Seems to be working fine. Thank you :)


Handled the deprecated secant_latitudes keyword in cartopy.

:+1: ... just needs the copyright period adjusting

I think @marqh is interested in this one...

:+1: Awesome, thanks @pelson

Merged to master with aa6e233.


Variant updates

Initial rewrite of Variant class and related classes according to variants WG specification: variants spec
Further discussion required with variants WG on how to integrate VEP results, currently modelled in variantConsequence.yaml

@markquintontulloch  - what if we had a typing slot we could use to disambiguate between "curated" and "source" instead of dual slots for each?  I can definitely see the benefit of being explicit (e.g. the interface might need to pull the source in right next to the curation and in my suggestion, the code would have to aggregate two "rows" rather than one). I worry a bit abstractly about duplication of 'columns'.
Also, this is a fairly new addition to linkml, but I think we could make use of: 1) anyOf conventions to further validate/restrict the attributes available for each variant type, and 2) instead/in addition regex's rules to constrain.  Let me pull together that doc - edits to this comment forthcoming.

@sierra-moxon - Thanks for the comments.  Yes, the idea of a typing slot had occurred to me.  However, I was unsure about how to deal with those VariantLocation slots that aren't duplicated for curated/source (i.e. evidence_code and hgvs).
The use of anyOf and regex rules are things I was unaware of in LinkML - they sound promising :)
Also, from the failing build I see that there is a clash between the evidence_code slots in my updated variation.yaml and orthology.yaml - the former has a range of an ECOTerm object, the latter an enum that is currently undefined.   Can we change the latter to also point to an ECOTerm object?


Keystore: Store files with permission 600 on unix

Fixes: https://github.com/paritytech/substrate/issues/9886

bot merge


Workers do not shut down when plugin unloads

What happened?
When you disable the plugin, it should shut down its workers, but it does not.  Re-enabling the plugin adds more workers, which also do not shut down when the plugin is disabled again.
DQL
No response
JS
No response
Dataview Version
0.4.21
Obsidian Version
0.13.19
OS
Windows

Looks like there are also dangling event listeners which need to be cleaned up. Good catch.

I've submitted a PR (#761) to handle it by making the relevant classes Components and addChild()ing them all the way up to the plugin.  I've also mostly finished another PR to make refreshing vastly more efficient (debounced event instead of intervals, no refreshing of invisible sidebar notes, interval can change on the fly, etc.) but I'd like to get these changes merged first because downstream of that PR I want to make the importer more efficient using 0.13's new change events (which include the text of the file (so there's no need to re-read it from disk) and the parsed metadata (which is guaranteed to match the text)).
(It also occurs to me, just now, that the importer's current "debouncing" algorithm ignores later changes to a file, when what it actually needs to do is ignore earlier changes in favor of later ones.  But I can tackle that as part of the importer efficiency cleanup.)

@pjeby 's fix merged and will show up in 0.4.22.


Autorest Regen Preview to 3.0.0-alpha.20230614.14 by Dapeng Zhang from refs/pull/3470/merge

Triggered from https://github.com/Azure/autorest.csharp/pull/3470

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Data.AppConfiguration


Migrate tests of cargo-init to snapbox

What does this PR try to resolve?
A attempt of migrating tests of cargo-init to snapbox.
How should we test and review this PR?
To review this PR, you may compare the old and the new version one by one. Files not listed in <test-name>.out are not asserted, so make sure we don't miss any essential file to check.
Some redundant tests are covered by other tests or renamed.

gitignore_appended_not_replaced -> merged into git_ignore_exists_no_conflicting_entries
gitignore_added_newline_in_existing -> merged into git_ignore_exists_no_conflicting_entries
gitignore_no_newline_in_new -> merged into simple_git
terminating_newline_in_existing_git_ignore -> merged into simple_git_ignore_exists
terminating_newline_in_new_git_ignore -> merged into simple_git
terminating_newline_in_new_mercurial_ignore -> merged into simple_hg
terminating_newline_in_existing_mercurial_ignore -> merged into simple_hg_ignore_exists
mercurial_added_newline_in_existing -> merged into simple_hg_ignore_exists
mercurial_no_newline_in_new -> merged into simple_hg
cargo_lock_gitignored_if_lib1 -> merged into simple_git
cargo_lock_gitignored_if_lib2 -> renamed to inferred_lib_with_git
cargo_lock_not_gitignored_if_bin2 -> renamed to inferred_bin_with_git
cargo_lock_not_gitignored_if_bin1 -> renamed to explicit_bin_with_git

Additional information
I won't say the process of the migration was pleasant, but overall it results to a higher coverage of output file changes. Here are steps I performed to migrate a test case:

Run the old test and observe its output layout. Recommend using a separate worktree to preserve the temporary test output files.
Read the test code to arrange its input fixture at <test-name>.in.
Copy the old output layout or hand-pick the output layout you need. You don't need to fill contents of those files. snapbox will do it for you.
Run SNAPSHOTS=overwrite cargo test --test testsuite <your-test-filter> to assert and generate snapshots.
Compare the old layout and the new layout to see if anything missing.

Something observations when dealing with the migration:

snapbox hasn't yet support unordered assertion.
snapbox cannot assert inexistence of a file (And probably never?).
No performance hit so far (measured with hyperfine).

r? @ehuss
(rust-highfive has picked a reviewer for you, use r? to override)

Overall, I'm feeling very wary of making changes like this. I'm finding that this adds over 500 lines of code, and nearly 200 files, and adds quite a bit a complexity for not a substantial amount of benefit. Can we take a step back and evaluate what the strategy here is?  I don't think we should be bulk updating tests unless there is in balance a benefit. The init tests for example have almost no output, and I don't feel like they benefit much from placing the output in separate files.  I would also like to see snapbox mature more before migrating more tests.
If the primary concern is being able to update the output of a test, would an alternative be to just have a tool to update the strings within the test file automatically?

@bors r+
Once this is merged, plan to make improvements

https://github.com/rust-lang/cargo/issues/10626
https://github.com/rust-lang/cargo/issues/10627

And document when to use filesystem snapshots vs in-code: https://github.com/rust-lang/cargo/issues/10628

:pushpin: Commit 20c0c581f8fdfd15a2ba49d26aa302b42430c365 has been approved by epage

:hourglass: Testing commit 20c0c581f8fdfd15a2ba49d26aa302b42430c365 with merge ad05cec893ca5d2445614272259b1801c473e1f5...

:sunny: Test successful - checks-actions
Approved by: epage
Pushing ad05cec893ca5d2445614272259b1801c473e1f5 to master...


Addressing missing typings file in npm, Reduce npm module size

Description

Updated .npmignore to exclude src and other unnecessary files
Change typings file name in package.json
Remove map generation by tsc

Before
npm notice === Tarball Details ===
npm notice name:          react-native-material-kit
npm notice version:       0.5.1
npm notice filename:      react-native-material-kit-0.5.1.tgz
npm notice package size:  118.7 kB
npm notice unpacked size: 342.9 kB
npm notice total files:   92

After
npm notice === Tarball Details ===
npm notice name:          react-native-material-kit
npm notice version:       0.5.1
npm notice filename:      react-native-material-kit-0.5.1.tgz
npm notice package size:  95.2 kB
npm notice unpacked size: 235.4 kB
npm notice total files:   79

lmk if you want map files retained


[OpenCV] update to 4.4

Library name: OpenCV
New version number: 4.4.0

cc @cenit feel free to update OCV to 4.4 : )

@JackBoosY https://github.com/microsoft/vcpkg/pull/14118
Sorry for being almost absent. Too much work recently and got overwhelmed by deadlines.
Before #14118 i still hope #12785 can be finished and merged, so that in future we have automatic checks for OpenCV and its many features in CI!


Optional to set global cost model and provide default

Currently a network constant fallback is used when there's a deployment doesn't have cost models.
Update
Allow a global instance of cost model and variables so that one can use indexer-cli to update indexer-based fallback. Indexer agent will take note of deployments with missing cost models and log.
There's also a temporarily defined file basic.agora in the indexer-agent package and a function to setting it to global entry automatically. (might be extra, since we just need indexer to set model global [file] if it doesn't already exist

Resolves #85 & #271


selfhost/typechecker: Make one step to GenericType

Implement the logic of GenericResolveType in GenericType directly - instead of going
through GenericResolveType - until the GenericResolveType TypeId cross dependency
with the parser module is resolved.

Hello!
One or more of the commit messages in this PR do not match the Jakt code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

Please wrap commit messages at 72 characters, not 50 (or whatever this is) :)

Please wrap commit messages at 72 characters, not 50 (or whatever this is) :)

Done, didn't try to wrap at 50, the words just wouldn't want to align for 70 :D
I also rebased and fixed an issue due to API changes after my initial PR.


Improved performance of AVSurface (added AVHash class)

Newer, faster version, see #209 and #205

Awesome, that is much faster indeed :-)
I think the maxRadius for AvHash needs to take the probeRadius into account. At least the surface looks wrong for larger probe radii.
4v5a looks good on my desktop machine, see below for a scaleFactor of 2.0

I need a new machine.
Yeah, I'd noticed some weirdness at high probe sizes. The maxRadius parameter is already calculated using the extended atomic radius max(rAtom + rProbe) but it needs to be a bit more I guess - perhaps max(rAtom + rProbe) + (ng/scaleFactor).
Unfortunately I'm travelling for the next two weeks without a laptop (a frightening proposition) but will put it on the to-do list for when I'm back.

I'll have a look at it, thanks.

Unfortunately I'm travelling for the next two weeks without a laptop (a frightening proposition) ...

Have fun!


Null-aware method invocation results in: unexpected token "."

Dart SDK 1.12.2
Running in Dartium
...
  Map encode() {
    return {
      "user": user,
      "type": type,
      "createdDate": createdDate.toString(),
      "updatedDate": updatedDate.toString(),
      "url": url,
      "siteUrl": siteUrl,
      "lastCrawledDate": lastCrawledDate?.toString()
    };
  }
...

Error:
Uncaught 'package:woven/src/shared/model/feed.dart': error: line 24 pos 42: unexpected token '.'
      "lastCrawledDate": lastCrawledDate?.toString()

Works fine here https://dartpad.dartlang.org/0bd773c3c2176cb5fa91

@zoechi indeed, seems to work for me in DartPad too with a simple test.
https://dartpad.dartlang.org/d496f173c18651fa4888
But Dartium throws an error. Have you tried there?

same issue here (also Dart 1.12.2 - using WebStorm 11)
obj?.sendMessage(message);
running using Dartium:
error: line 53 pos 21: unexpected token '.'
obj?.sendMessage(message);

Seems fine in 1.15.


Bottom nav try instead of the side hamburger menu

I've added the bottom navigation which is now handled within the app.tsx file. Adding new entries is pretty easy to do, I've added comments within the file for readability. The main thing to note is that new pages must be added within this file so that they are within the scope of possible navigation routes.

Also I believe I updated a few packages so you might need to wipe out your node modules and reinstall them


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-yml-archive-non-versioning-archive/pull/440 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-yml-archive-non-versioning-archive.git

Docs Build status updates of commit e331eda:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/TOC.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-3.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-3.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


[Storage] Fix #22236: az storage entity insert: Fix --if-exists fail not working

Related command

az storage entity insert
Description

Fix #22236
Testing Guide

First of all insert an entity
az storage entity insert -e PartitionKey=AAA RowKey=BBB Content=test -t $table_name --account-name $account_name

Then insert the same entity with --if-exists fail
az storage entity insert -e PartitionKey=AAA RowKey=BBB Content=test --if-exists fail -t $table_name --account-name $account_name

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Storage


Partially implements sys_lseek, refactors ioctl commands

It should probably be a proc macro. By the way you can see the result with cargo expand fs::ioctl.


Mixer C++ client

Write mixer C++ client.
This client is used by istio proxy to interface with mixer.
example:
https://github.com/cloudendpoints/service-control-client-cxx

Work being done in mixerclient repo


fix: support member exp after template and tagged template

fixes: #259

Thank you for the contribution, @anpete ! I have no complaints and I'm happy to see tests, with a straight-forward PR, and a proper commit message. I'll merge this as is and it should be released shortly! 🥳


Ensure terminal is not shown or activated if hideFromUser is set to true

For #11122
This fix is for the hidden terminals created by the extension
We should be checking this.options?.hideFromUser before calling Terminal.show.
Also, added a check for options.hideFromUser inside the implementation alongside where we check the value of setting python.terminal.activateEnvironment just to be sure.

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[x] Title summarizes what is changing.
[x] Has a news entry file (remember to thank yourself!).
[ ] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[x] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
[ ] The wiki is updated with any design decisions/details.

Codecov Report

Merging #13117 into master will decrease coverage by 0.02%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master   #13117      +/-   ##
==========================================
- Coverage   59.79%   59.76%   -0.03%
==========================================
  Files         671      671
  Lines       36688    36689       +1
  Branches     5158     5159       +1
==========================================
- Hits        21936    21928       -8
+ Misses      13673    13665       -8
- Partials     1079     1096      +17

Impacted Files
Coverage Δ

src/client/common/terminal/activator/index.ts
80.95% <0.00%> (-4.77%)
:arrow_down:

src/client/common/terminal/service.ts
90.16% <100.00%> (+1.83%)
:arrow_up:

src/client/common/utils/platform.ts
64.70% <0.00%> (-11.77%)
:arrow_down:

src/client/datascience/crossProcessLock.ts
79.41% <0.00%> (-11.77%)
:arrow_down:

src/client/linters/pydocstyle.ts
86.66% <0.00%> (-2.23%)
:arrow_down:

src/client/datascience/debugLocationTracker.ts
76.56% <0.00%> (-1.57%)
:arrow_down:

src/client/common/process/proc.ts
14.49% <0.00%> (-0.73%)
:arrow_down:

src/client/logging/levels.ts
61.11% <0.00%> (ø)

src/client/logging/logger.ts
62.74% <0.00%> (ø)

src/client/logging/formatters.ts
53.57% <0.00%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f41b3d...8ede4da. Read the comment docs.

@int19h Maybe the notification got skipped, but waiting for your review on this one

Sorry, looks like I messed up the notification settings for the repo.