Refactor executable examples into top-level directory

A major part of improving our docs is to add various examples. The way many libraries structure their examples is in a top-level examples directory (see bokeh, and matplotlib). These examples then usually get built into a gallery (see bokeh, matplotlib, and cartopy).
Adding an examples directory also encourages adding examples when new features are added. I'd even suggest that in future new features should be accompanied by small example notebooks or scripts. We are going to be splitting out the different plotting backends but I'd still strongly argue examples for officially supported backends should live on the core repo, where they are all in one place.
We've also had various definitions of examples in the past, what I think it should mean in this context is small self-contained notebooks with at most one or two examples, which are focused on the code, not on telling a story or explaining deeper concepts. That contrasts with quickstart guides, tutorials and the "examples" that are linked to from holoviews.org/Examples, which are really case studies. My suggestion for the different types of notebooks:

Tutorials - Long, detailed notebooks explaining particular concepts in detail, living in doc/Tutorials. New tutorials should be added to holoviews-contrib and can move to the main repo once polished.
Quickstart guides - Shorter notebooks getting the user started on using a particular feature without providing extensive background. Again should start out in holoviews-contrib but once we have a few I'd suggest creating a User Guide (see bokeh) that provides a quick introduction to holoviews.
Examples - These are what this issue is about, they are short and self-contained and generally should just go straight into the main repo since they don't need detailed explanation.
Case studies - These are what's currently on holoviews.org/Examples, and basically show how to apply holoviews to a particular domain or problem. I believe these should all live in holoviews-contrib providing a wide-ranging collection of user examples. Keeping them all in one place this way will encourage us to test and update them for each release.

If we agree on these different formats and where they live we should settle the structure of the examples, my suggestion is that each example should be implemented for all backends that support the features used in the example. Then each example links to the equivalent versions for other backends. Each example should contain the following information:

Table with links to the example implemented using other backends using unicode tickmarks to show supported and unsupported backends
List of requirements, e.g. if the data uses bokeh sample data lists that as a requirement
A link to the original source of the example if any
(Optional) A list of tags to make the examples more searchable

We also want to structure the examples into sensible subfolders. Here's some subfolders I can currently imagine:

apps - bokeh apps and in future maybe matplotlib webagg based apps
elements - All the supported elements split out into individual notebooks
plotting - Basic examples showing off specific plotting features
streams - Various examples using regular streams and linked streams

I'd even suggest that in future new features should be accompanied by small example notebooks or scripts.

I agree this is a good idea.

We are going to be splitting out the different plotting backends but I'd still strongly argue examples for officially supported backends should live on the core repo, where they are all in one place.

Yes, though I would argue that things like bokeh server support would then live with in the bokeh backend repo.

I'd suggest creating a User Guide (see bokeh) that provides a quick introduction to holoviews...

I also agree with this.
All your suggestions seems sensible. I do disagree with this one though:

apps - bokeh apps and in future maybe matplotlib webagg based apps

Until we actually have another backend that does support apps, I wouldn't include this in the examples but with the backend. Of course, if we do find ourselves with apps using different backends, we could unify them again.

Until we actually have another backend that does support apps, I wouldn't include this in the examples but with the backend. Of course, if we do find ourselves with apps using different backends, we could unify them again.

I don't really get that argument, to me fragmentation of examples across multiple repos where most users will never discover them is a far bigger concern than having an extra folder that at least to begin with is focused entirely on one backend.

I get that point but I would like the core examples to be backend agnostic - i.e work across all backends. I'm happy to be convinced otherwise, but I would hold off on apps examples for now.

I get that point but I would like the core examples to be backend agnostic - i.e work across all backends. I'm happy to be convinced otherwise, but I would hold off on apps examples for now.

There will be plenty of examples in the plotting folder that won't work across backends. Not every backend will support every feature, which is exactly what makes holoviews so powerful, it lets you leverage the unique features of different plotting backends without being locked in.

Ok, in that case I don't mind having examples that aren't cross backend, but can at least prioritize the examples that are cross backend first?

Ok, in that case I don't mind having examples that aren't cross backend, but can at least prioritize the examples that are cross backend first?

Yes, definitely, wherever possible an example should be supported at least by two backends. Usually that's mpl and bokeh, but for 3d examples it'll be mpl and plotly.

It's not my business - but since this discussion is public - I dare to be ignored...
I'm sure you are aware of this site: http://www.datavizcatalogue.com/
It's the best example of gallery in terms of showcase.
It also a great idea to group examples by categories. So when you click on radial-charts you get a fast intro for all possible backends and links to all (!) known examples using this one.
P.S. Keeping in mind notebook JSON I believe process of creation such gallery can be automated and even separated into separate package for other users of holoviews to organize their in-house examples into gallery...

@thoth291 Don't worry feedback is always welcome!
I do believe I had seen datavizcatalogue.com before but had forgotten about it. It is a very slick website and does seem to be well organized. This is something I believe I'll be discussing with @jbednar and @philippjfr later so thanks for the link!

After a long meeting with Philipp, we've come up with the following plan on how to structure user-runnable examples:
holoviews
 |_ examples      # *Everything* must be Python2/3 compatible
  |_ index.py
  |_ Index.rst    # Generated by index.py everything in examples
  |_ README.rst   # Info on template and how to contribute

  |_ tutorials    # Website: same structure as now
    |_ ...        # Cross backend tutorials
    |_ bokeh
    |_ Linked_Streams.ipynb

  |_ elements      # Website: Elements gallery page, PNGs on S3 assets.holoviews.org
    |_ bokeh
    |_ matplotlib

  |_ demos         # Website: 'Gallery' page, subsection 'demos'. PNGs on S3 as well.
    |_ ...         # Few cross-backend demos
    |_ matplotlib
    |_ bokeh

                   # Feature-focused examples (e.g plotting hooks)
 |_ features       # Website: Linked to from the future release page(s). Also a subsection of 'Gallery'.
   |_ ...
   |_ matplotlib
   |_ bokeh

                   # Website: potential 'Quickstarts' page, PNGs on S3
  |_ quickstart    # Concrete mini-tutorials with an end-goal
    |_ ...
    |_ bokeh
    |_ matplotlib

  |_ streams       # Website: 'Gallery', subsection 'streams' # Ideally live, definite .gif (.gifv, press play)
    |- ...         # Cross backend examples
    |_ bokeh       # Linked streams
    |_ matplotlib  # 3D example
    |_ paramnb

  |_ apps          # Website: 'Gallery', subsection 'apps'. # Ideally live, definite .gif (.gifv, press play)
    |_ bokeh
    |_ matplotlib  # flask app based on webagg

                   # Website: Nothing planned (potentially in the Gallery)

  |_ scripts       # Pure Python
    |_ ...         # Cross backend examples
    |_ bokeh
    |_ matplotlib

  # Website: Replaces current Examples page
  |_ topics
    |_ general           # Fractals
    |_ simulation        # Game of Life, Boids, Hipster model
    |_ cartographic      # Geoviews
    |_ machine_learning
    |_ neuroscience     (e.g Imagen)

  # Topics get subdirectories as they get populated (min. 2 examples needed)
  # These topics will be curated so *just* the notebooks we are happy to keep supporting.

  |_ user-guide  # Future work. The .rst will be in doc/user-guide

Note that this involves moving our current tutorials out of doc/Tutorials. There should be no .rst files in examples except  README.rst and Index.rst (for GitHub rendering, not sphinx).
The plan for holoviews-contrib is to mirror structure above. Users can contribute there and we move material over to this repo for content that is good and that we want to maintain.
We also agreed that all examples should have a table at the top (excluding tutorials) with this structure:
Metadata for everything in examples (except tutorials)

title:          My example
dependencies:   bokeh, datashader
references: [original model](...) [code inspiration](...) [paper](...)   # Crediting material
topics:         machine-learning   # Need to decide if we want to keep this field
backends:       [matplotlib](...) [matplotlib-nbagg](...) [bokeh](...) [bokeh-server](...)

Note that the backends list includes the renderer modes and all backends should be listed, including circular links to the same page. E.g examples/demos/bokeh would be expected to have a single entry for 'bokeh' that just links back to that page.
Lots of work to be done!

Why are README.rst and Index.rst rst, if they are only for Github?  Why not .md?
How will holoviews.contrib handle outdated examples?  Seems like it will need to store the hv version they were created for, so that they are runnable by some version even if not the current one.
Will examples/index.py be able to read a category tag (potentially mutiple ones, for a hierarchy?) stored with each example, so that they can be grouped automatically?  That way we can have some structure without requiring a master list.
I can't tell what you mean for the structure of the "tutorials" directory, from the items in the skeleton above.
Do we really need demos, features, and quickstarts to be separate categories?  Seems unwieldy.
"# Website: Nothing planned" -- not sure what that's referring to.  Seems like everything needs a website or it doesn't exist.
If you list "dependencies:   bokeh, datashader" I think it should be in the form of something that can be automated, e.g. a couple of items that can be added to a master environment.yml that is then sufficient to run the examples.  Maybe environment.yml isn't needed, depending on what gets installed already with hv.
What about GeoViews?  Can those examples be part of this same structure, but with a "geoviews" dependency?

No strong preference for rst over md, it's just what we've been using elsewhere including the main README.rst, CHANGELOG.rst and everywhere on the website.

Will examples/index.py be able to read a category tag (potentially mutiple ones, for a hierarchy?) stored with each example, so that they can be grouped automatically? That way we can have some structure without requiring a master list.

 Otherwise I'd be happy to add it to break the Gallery down into smaller sections and potentially create something like the visualization catalogue suggested above.

Do we really need demos, features, and quickstarts to be separate categories? Seems unwieldy.

Either that or consistent tagging, I do think quickstarts should probably be separate from the other two though.

"# Website: Nothing planned" -- not sure what that's referring to. Seems like everything needs a website or it doesn't exist.

That's for script examples, suppose those could get built somehow and included on the website.

If you list "dependencies: bokeh, datashader" I think it should be in the form of something that can be automated, e.g. a couple of items that can be added to a master environment.yml that is then sufficient to run the examples. Maybe environment.yml isn't needed, depending on what gets installed already with hv.

Not sure what you're suggesting, do you mean that they should also include version numbers or something? Or do you want to generate an environment.yml that covers all the example dependencies somehow?

What about GeoViews? Can those examples be part of this same structure, but with a "geoviews" dependency?

Those should probably go in the topics/cartographic directory

do you mean that they should also include version numbers or something? Or do you want to generate an environment.yml that covers all the example dependencies somehow?

It doesn't have to be generated, just generatable, i.e. a user (or a computer) should be able to start with a reference environment.yml, extract the list of extra dependencies for this example, run a conda command (or patch the end of the .yml file) to get those dependencies, and run the example.  If that's automated then so much the better!  If they are automated and continuously tested then they don't need version numbers, since we'll know when things break and we can see the version numbers in the logs for the last working one.  If it's not automated it probably needs version numbers.

topics/cartographic

Sounds reasonable.

@jbednar What you proposed sounds desirable but I'm not sure what could support that at a technical level right now.

If you don't support that, how will you get all the various examples to run, with dependencies that may conflict?  Just have one master environment file that covers all, and reject any example that doesn't fit that?

That is the only suggestion that I think would work, at least initially. Testing is a whole new can of worms!

All examples included in the main repo should be kept up to date and should work with the most recent versions of the libraries they depend on. So there should be no conflicts.

If that's the policy for maintenance, that should be fine. But for users, it would be far nicer if they could have a minimal, not a maximal, environment.yml, plus a few that are very specific to this particular example. Eventually the hv examples could cover all Python libraries ever. :-)

I don't think we are proposing adding any dependencies to what is installed. As far as I'm concerned we only need to expand what is installed on travis when it comes to testing.
Users will be able to consult each example to see any additional dependencies and install them as required. These example dependencies shouldn't be forced on users in any way!

Note that each example will list any additional dependencies explicitly and we how a large number of examples have no special dependencies. I.e they may need the matplotlib or bokeh backend, but that should be about it.

Sure, sounds good.  I'm just suggesting that when we list such extra dependencies, we do them in a machine-automatable way even if we don't actually automate that at present.

Part of the plan is a script to extract the titles from the metadata tables and generate an index. It could also collect all the specified dependencies and list them too.

Sounds like a good idea to me.  I'm bringing this up now because we're facing similar issues for datashader, which has some examples with very heavy dependencies that do not play nice with each other.

Part of this should happen in time for 1.7.1 even if everything isn't added. We'll reassign this issue to 1.8 as soon as 1.7.1 is out.

@jbednar @philippjfr
I've renamed this issue as it now contains the overall documentation plan we came up with for HoloViews.
Note that I also edited the suggested directory structure of examples/ above to reflect the proposed structure below (I decided to remove the proposed 'quickstarts' as the notebooks I have can move to  topics/simulation)
Documentation sections
The following list has the corresponding priority (both in terms of priority as a task and general importance) marked by (*1), (*2) etc.
Gallery
|_ Element (priority)  (*1)
|_ Linked Streams
|_ Demos
Getting Started  (*2)
These docs are about HoloViews, starting from zero, quickly introducing the core terms and concepts with a focus on how everything fits together.  Should be succinct with the goal that a person could reasonably get through all 5 sections in 2/3 hours without feeling overloaded. Will continually link to the user guide for comprehensive detail:
There will be 5 core sections with one optional section:

Elements + Composition + Containers, introducing Dimensions
Backends Options and Magics  (%output/%opts)
Dataset + methods (links off the user guide)
DynamicMap (introducing Streams, mentioning dynamic operations)
Operations (introducing dynamic operations)
(Optional): Design principles (short version of rich display)

User Guide
A set of polished notebooks about various holoviews features (can be core or side-features) that go into as much detail as possible to discuss particular aspects of HoloViews at length. Each notebook is more granular and focused than in 'Getting Started' and these notebooks will be mostly adapted from our existing tutorials. Core user guides should always recommend people read 'Getting Started' first, linking to the appropriate section.
Core User Guides (*3)
These will be linked prominently from the 'Getting Started' sections. These will mirror the 'Getting Started' topics but there will be more core user guide pages than 'Getting started sections' (more granular). These will also like to the supplementary user guide pages.

Dimensions
Composition (i.e overlays and layouts)
Nesting data  (replacing Composing data, hierarchy of structure, traversal, map)
Containers (casting, faceting, .overlay, .layout)
Gridded data
Columnar data
HoloMaps
Operations
Options
Magics
DynamicMap
Streams

Supplementary User Guides  (*4/*5)
Detailed information of features that aren't considered core.

Plotting with Matplotlib
Plotting with Bokeh
Plotting with Plotly
Linked Streams
Dynamic Pipelines
Exporting
Bokeh apps
Deployment
Dashboards
Continuous Coordinates
Renderer and plots (user-centric)

Tutorials (*4/*5)
Longer, extended examples of working with some dataset i.e this is data centric documentation using HoloViews as a tool. Will recommend that users have read the 'Getting Started' guide first and will link to the User Guide to ensure readers pick up the relevant HoloViews concepts.

Working with image data    (numpy)
Working with columnar data (pandas)
Working with gridded data  (numpy, xarray, iris)
Working with large data    (datashader)

Topics (*6)
Domain specific tutorials. Just like Tutorials in that they are about a task that the user wants to perform, using HoloViews.

Working with geographic data
Working with network data
Working with simulations

Note that we now plan to remove the existing tutorials entirely, but when we do, we should
have a page (either in an issue or PR) with a list of links pointing into the git history with the final
version of the notebook before it was deleted.
It is a big plan but at least we also have a clear set of priorities and a framework to fit everything in!

I forgot to include the glossary so I made an edit above. It should be fairly easy to add

Core User Guides

These look good, but if the titles in the user guide mention HV types, I think those should be in parentheses -- they should be titled using the underlying concepts, not about HoloMap or DynamicMap as objects.  E.g. maybe "High-dimensional data as animations or sliders (HoloMaps)" or "Dynamically generating HoloViews objects as needed (DynamicMaps)".  It's a user guide, not a reference guide.

Sure, though those suggestions are also a tad long! ;-p

True -- hopefully we can come up with something simpler and more direct.

Discovered that there were a PLOTCON conference done recently and this talk made me think of some things what I'm doing with the plots: https://www.youtube.com/watch?v=_KEl-Spdaz0
Coming back to my recent post in this thread - I think it's definitely right thing to keep some learning sections in the documentation in spirit of Plotting Pitfalls by @jbednar , datavizcalogue sections of when to use charts or the rules Elijah is talking about in his post.
The first thing what made me confident in datashader and holoviews - that I had perfect feeling that you guys deeply understand what you are doing - and it's not just yet another plotting library - it's a conceptually new way of dealing with data and abstracting from data layout in favor of data annotations to do appropriate and reproducible data manipulating and plotting.
Please don't forget about documentation of that kind: teaching scientists what is the right way to tell story of their data using holoviews - and pointing to what can go wrong without it - is crucial part of your commitment in this project for people like me.
Thank you very much for your hard work!
P.S. How come you were not presenting at PLOTCON?

We can't be everywhere! :-)  We'll be talking about HoloViews, Datashader, and Bokeh at SciPy in Austin, JupyterCon in NYC, and FOSS4G in Boston, two of which are in-depth tutorials.
Yes, we're working on better overview/howto guides.  We'll soon be making a new site that covers multiple projects (HoloViews, Bokeh, and Datashader at least) that shows how everything fits together to solve real problems.  Stay tuned!

Summary from our meeting today:

Getting started guide is agnostic to background (starting with python and numpy knowledge)
User guide might have sections for users to "unlearn" matplotlib/bokeh, imperative plotting
Add Getting Started section 0 for core concepts

Getting started guide

Section 0: Core concepts

Section 1: Elements/Composition/Spaces

Two simple element examples (pandas timeseries and numpy image & point forward to Section 3)
Show basic composition
Show HoloMap (bring in concept of Dimensions)
Redim HoloMap/Element dimensions

Section 2: Separation of content/presentation: Backends/Options

Start with a bokeh plot, customize it
Switch to matplotlib and then explain that you need to set new options (starting with bokeh)
Present magics as convenient way of setting options

Section 3: Dataset

Different types of accepted formats (pandas, numpy, xarray...)
Explain indexing (select, slice, index)
Explain faceting (.overlay, .grid, .layout)
Explain other methods

Section 4: DynamicMap

Section 5: Operations

Section 6: Design Principles

This afternoon we also discussed our current plan for the user guide, here's what we're doing with existing tutorials:
Keep as tutorials

Showcase
Introduction (Rewrite or delete later)
Exploring Data

Ready to move to user guide now and adapt later

Sampling data
Columnar Data (top section as user guide, bottom as "Working with Columnar Data" tutorial)
DynamicMap
Options
Exporting
Continuous Coordinates
Composing Data
Bokeh Backend (rename to "Plotting with bokeh" and make mpl equivalent)
Streams
Linked Streams

Examples/Gallery

Containers: Split into individual gallery notebooks

It has been a ton of work but now this plan has been implemented. Very happy to close this one!


Zookeeper logging endpoint is not set correctly

Rancher versions: 2.0 master 1/03
Steps to Reproduce:

Try to create a logging target for Kafka
Choose zookeeper endpoint type.
Configure the endpoint and Save.
Results:
The UI shows the error:

Validation failed in API: one of the target must set

@moelsayed Hi, this part used to have bug, the fix just merge several minutes ago. The latest one should fixed. thank you

https://github.com/rancher/rancher/issues/11818

Confirmed fix with master 453bc7731.


fix: exclude all node_modules files

Currently, our file picker component chokes when too many eligible files are passed to it.
Typically, from what we've seen, flat data repos tend not to have too many files in them. But, say, if you co-locate a Next.js app in your repository (either at the root, or nested in a directory), we want to make sure we exclude all of the files in node_modules to prevent the aforementioned choking.

at some point, we should look into why it chokes on too many files (are we rendering all of them?!), but this is good for now!


Added 4 new Logos for Alphavio

What is the change?
Added 4 logo choices for Alphavio organization
Related issue?
issue: #15
Checklist:
Before you create this PR, confirm all the requirements listed below by checking the checkboxes [x]:

[x] Have you followed the Contribution Guidelines while contributing.
[x] Have you checked there aren't other open Pull Requests for the same update/change?
[x] Have you made corresponding changes to the documentation?
[x] Your submission doesn't break any existing feature.
[x] Have you tested the code before submission?

Screenshots or Video:

@all-contributors please add @karunkarthik-git for design

@all-contributors please add @karunkarthik-git for design

@all-contributors please add @anubhab1710  for design

@all-contributors please add @anubhab1710  for design

@all-contributors please add @anubhab1710  for design

@all-contributors please add @anubhab1710  for design

@all-contributors please add @anubhab1710 for design

@all-contributors please add @anubhab1710 for design


Python 3.5 support

Would you be open to making bitcoinx compatible with Python 3.5?
Right now, bitsv uses bitcoinx and that holds us to a 3.6 requirement. Unfortunately, Debian 9 and others only ship with Python 3.5. If 3.6 doesn't have any deal-breaker features, it'd be nice to support 3.5.
Thank you!

No, there are good reasons 3.5 is not admitted.  New syntax and crucial bug fixes.

I understand, thanks for getting back to me. Can you explain what the bug fixes are or give me an idea so I'm aware?

Sorry I was getting this package confused with aiorpcX where there were many networking bugs in 3.5 (and 3.6 to a lesser extent).
At present the main thing then is the f-strings.  I may be persuadable they could be done away with, though I develop myself with Python3.7 and all my other packages use them so that is a bit painful for me.
I wouldn't want to maintain 3.5 support for long.  Why don't you try running the testsuite on 3.5 and find out what needs changing?

Gotcha, thank you! I see at least 45 f-strings. Converting those takes a little while, I imagine it might be faster to make an f() wrapper and then to a search/replace.
I'll first have to clear that up before seeing if anything else is broken but will be busy for at least part of the day today.

Closing, nothing seems to be happening


the four reward metrics

I wonder how the four reward metrics rewards/real, rewards/generated, rewards/accuracies and rewards/margins change during training? Can you show some pictures about them for reimplement？

An example from iter3. Behavior may vary in different settings. The connection of these metrics to the final evaluation is not obvious.


Update photon base images

This commit update the base photon image from vmware/photon:1.0 to
photon:1.0, per suggestion by photon team.

Pull Request Test Coverage Report for Build 7698

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 64.699%

Totals

Change from base Build 7697:
0.02%

Covered Lines:
11805

Relevant Lines:
18246

💛  - Coveralls


Content of element cut off by script tag at the time the created callback is fired

If you have an element that uses the current innerHTML of an element:
document.registerElement('my-element', {
  prototype: Object.create(window.HTMLElement.prototype, {
    createdCallback: {
      value: function () {
        console.log(this.innerHTML);
      }
    }
  })
});

And the content of that element contains a

</my-element>

The console.log() from the component will only log:

And will not include any content after the first script tag. This only happens when the usage of innerHTML happens synchronously. If you registered the component after the element was put on the page, or use innerHTML asynchronously, then this does not happen.
Test case:
<!doctype html>

    <my-element>

    </my-element>

Trying to reproduce this in something like JSBin won't work even if you paste it in to the HTML tab and don't use the JavaScript tab. I think they still munge the HTML so that scripts are executed on DOMContentLoaded. It must be a normal HTML document.
I think this is because when the first script tag is encountered it blocks the rest of the content from executing. Using defer or async don't yield any results. I wonder if this is a bug in Chrome.

Logged on the Chromium and V8 bug trackers.

https://code.google.com/p/chromium/issues/detail?id=502872
https://code.google.com/p/v8/issues/detail?id=4204

From the responses I got, this is intended behaviour because:

When the base element queue (list of elements that need to be processed) becomes non-empty, a microtask is queued to process them.
When the closing tag to the script element is encountered, it causes the microtask to execute, which causes the custom element's lifecycle to be invoked from that exact point. Everything after it doesn't get processed until that microtask is finished.

This is translated from what I have read and the response on the Chromium issue. Our take-away from this should be that you cannot rely on the content inside a custom element to be complete by the time the created lifecycle callback is invoked. This shouldn't be a problem for most use-cases, but if you're templating engine uses the initial innerHTML from the element, it may not be complete and cause improper rendering. Currently, I've no solution for this other than to defer template rendering until you can be sure the html has been rendered (setTimeout()). This does not affect core Skate.


Sitemap generation

The generated sitemap contains an entry for a /home page, which doesn't exist, and doesn't contain an entry for the homepage.


Corrected package version in bower.json

There is a PR to remove that property: https://github.com/chinchang/hint.css/pull/89. It is deprecated. That PR cannot be merged, so may be you can remove it?


Add JsonParseAgent

It parses a JSON string and emits the data in a new event

Coverage increased (+0.03%) to 90.753% when pulling 8e9a20982c36ca0f9f2e0b3490bdbe25e953f5c0 on kreuzwerker:feature/json-parse into c834314043da4d5279d0d0268abcd162bd69a59b on cantino:master.

Nice :)

Coverage increased (+0.03%) to 90.753% when pulling e2981b0ded4bf6a68b8b8a5abb8631b94d54c092 on kreuzwerker:feature/json-parse into c834314043da4d5279d0d0268abcd162bd69a59b on cantino:master.

Thanks for the review!


Smaller readme grammatical improvement suggestions

Hello mengzhuo!
I came across your project and thought it would be worth to polish some wording / spelling on the readme.
What do you think?
btw, adding a basic gitignore would be great!

Thanks!


More cleanup in client_channel code.

This slightly simplifies the pick logic.

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

[microbenchmarks] No significant performance differences

Corrupt JSON data (indicates timeout or crash):
    bm_fullstack_trickle.BM_PumpStreamServerToClient_Trickle_2M_32k.opt.new: 1

[trickle] No significant performance differences

[trickle] No significant performance differences

[microbenchmarks] Performance differences noted:
Benchmark                                                              cpu_time    real_time
---------------------------------------------------------------------  ----------  -----------
BM_PumpStreamClientToServer<InProcess>/256k                            +23%        +22%
BM_PumpStreamClientToServer<InProcess>/32k                             +9%         +9%
BM_PumpStreamClientToServer<InProcess>/4k                              +4%         +4%
BM_PumpStreamClientToServer<InProcessCHTTP2>/32k                                   +4%
BM_PumpStreamServerToClient<InProcess>/256k                            +6%         +7%
BM_PumpStreamServerToClient<InProcessCHTTP2>/32k                                   +4%
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/0/256k           +8%         +8%
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/256k/0           +13%        +14%
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/256k/256k        +6%         +6%
BM_UnaryPingPong<InProcessCHTTP2, NoOpMutator, NoOpMutator>/0/256k     +9%         +10%
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/0/256k        +11%        +11%
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/256k/0        +8%         +7%
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/32k/32k       +6%         +6%
BM_UnaryPingPong<MinInProcessCHTTP2, NoOpMutator, NoOpMutator>/256k/0  +4%         +4%
BM_UnaryPingPong<MinTCP, NoOpMutator, NoOpMutator>/256k/256k           +4%         +5%

I suspect those bm_diff numbers are spurious.  I'm going to trigger a re-run to see if they recur.

[microbenchmarks] No significant performance differences

Known issues: #11737 #11676 #11745 #12490


os/Stat: FileInfo indicates that Solaris doors are regular files

What version of Go are you using (go version)?

$ go version
go version go1.18 solaris/amd64

Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/user/.cache/go-build"
GOENV="/home/user/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="solaris"
GOINSECURE=""
GOMODCACHE="/home/user/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="solaris"
GOPATH="/home/user/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/opt/pkg/go118"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/opt/pkg/go118/pkg/tool/solaris_amd64"
GOVCS=""
GOVERSION="go1.18"
GCCGO="/usr/bin/gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build1940893624=/tmp/go-build -gno-record-gcc-switches"

What did you do?

As discovered using restic, os.FileInfo claims that Solaris Doors are regular files.  This is due to missing cases in the switch statement in os/stat_solaris.go.
What did you expect to see?
Unclear. there's no Door type in os/types.go.  It could be ModeIrregular?
What did you see instead?
0, regular file

This works for me, exposing the OS-specific file types (doors and event ports) as irregular as proof of concept.
--- ./src/syscall/types_solaris.go.orig 2022-04-09 18:49:38.421104607 -0700
+++ ./src/syscall/types_solaris.go      2022-04-09 18:49:57.891586964 -0700
@@ -116,6 +116,8 @@
        S_IFREG  = C.S_IFREG
        S_IFLNK  = C.S_IFLNK
        S_IFSOCK = C.S_IFSOCK
+       S_IFDOOR = C.S_IFDOOR
+       S_IFPORT = C.S_IFPORT
        S_ISUID  = C.S_ISUID
        S_ISGID  = C.S_ISGID
        S_ISVTX  = C.S_ISVTX
--- ./src/os/stat_solaris.go.orig       2022-04-09 18:51:51.166963104 -0700
+++ ./src/os/stat_solaris.go    2022-04-09 19:16:53.382479381 -0700
@@ -29,6 +29,12 @@
                // nothing to do
        case syscall.S_IFSOCK:
                fs.mode |= ModeSocket
+       case syscall.S_IFDOOR:
+               fs.mode |= ModeIrregular
+       case syscall.S_IFPORT:
+               fs.mode |= ModeIrregular
+       default:
+               fs.mode |= ModeIrregular
        }
        if fs.sys.Mode&syscall.S_ISGID != 0 {
                fs.mode |= ModeSetgid

--- ./src/syscall/ztypes_solaris_amd64.go.orig  2022-04-09 20:09:29.648930686 -0700
+++ ./src/syscall/ztypes_solaris_amd64.go       2022-04-09 20:09:53.654355235 -0700
@@ -73,6 +73,8 @@
        S_IFREG  = 0x8000
        S_IFLNK  = 0xa000
        S_IFSOCK = 0xc000
+       S_IFDOOR = 0xd000
+       S_IFPORT = 0xe000
        S_ISUID  = 0x800
        S_ISGID  = 0x400
        S_ISVTX  = 0x200


Ruby: Displaying SourceCode does not work reliable

Problem: Ruby class name and file name are not necessarily identical.
Possible solution A: Are their general rules or at least conventions for the relation between class and file name?
Possible solution B: write file name to metadata.json
B is more complex but also more general since it would work for all programming languages

Deprecated, since we no longer use famix as input source. Once there is a C# or .NET plugin for jQAssistant available, we will support it again.


fix: cog: checkout with fetch-depth: 0

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a6450f6) 83.56% compared to head (a5f2f4c) 85.75%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   83.56%   85.75%   +2.19%
==========================================
  Files           3        3
  Lines         365      365
==========================================
+ Hits          305      313       +8
+ Misses         46       37       -9
- Partials       14       15       +1

see 2 files with indirect coverage changes


Reorganized changing commit message docs

Why:
Fixes Issue #158 as suggested by the author

What's being changed:
The file was reorganized following the content plan on issue #158

Check off the following:

[x] All of the tests are passing.
[x] I have reviewed my changes in staging.
[x] For content changes, I have reviewed the localization checklist
[x] For content changes, I have reviewed the Content style guide for GitHub Docs.

If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! :sparkles:

@all-contributors please add Ruth-ikegah for content

If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨

Thanks!! Done!

@all-contributors please add @Ruth-ikegah  for Documentation

@all-contributors please add @Ruth-ikegah for docs

Hi @janiceilene I initially made a mistake with adding my name as a contributor. When I noticed, I made a new comment, so two PRs were made by all-contributors. And I just noticed the first one which was a mistake was merged(not my GitHub account). And the second one which is the correct was not. It's still open as a PR though. Please how do I resolve this

Oh no! I'm so sorry @Ruth-ikegah I didn't realize I merged the wrong one 💛 I'll work on getting this fixed up.

Oh no! I'm so sorry @Ruth-ikegah I didn't realize I merged the wrong one 💛 I'll work on getting this fixed up.

It's fine. Thanks so much!


Fix plugin not working if module has a lot of dependencies

In my project I have ~1000 gradle projects. I use focus to ease editing module with integration tests. It does not depend on all module, but it still have ~700 dependencies. I receive the following error:
A large stacktrace
...
Caused by: java.io.IOException: Failed to process the entry '_BuildScript_.class' from '~/.gradle/caches/8.7/groovy-dsl/9d7e202a95c600b4e91905ecc929318a-48a2fdac-7ee7-43b0-b7c7-bba0a26b072f/classes/dsl'
	at org.gradle.internal.classpath.transforms.BaseClasspathElementTransform.visitEntry(BaseClasspathElementTransform.java:93)
	at org.gradle.internal.classpath.transforms.BaseClasspathElementTransform.lambda$visitEntries$1(BaseClasspathElementTransform.java:78)
	at org.gradle.internal.classpath.ClasspathWalker.visitFile(ClasspathWalker.java:82)
	at org.gradle.internal.classpath.ClasspathWalker.visitDir(ClasspathWalker.java:74)
	at org.gradle.internal.classpath.ClasspathWalker.visitDirectoryContents(ClasspathWalker.java:62)
	at org.gradle.internal.classpath.ClasspathWalker.visit(ClasspathWalker.java:57)
	at org.gradle.internal.classpath.transforms.BaseClasspathElementTransform.visitEntries(BaseClasspathElementTransform.java:77)
	at org.gradle.internal.classpath.transforms.BaseClasspathElementTransform.lambda$transform$0(BaseClasspathElementTransform.java:68)
	at org.gradle.internal.classpath.InPlaceClasspathBuilder.buildJar(InPlaceClasspathBuilder.java:52)
	at org.gradle.internal.classpath.InPlaceClasspathBuilder.jar(InPlaceClasspathBuilder.java:42)
	... 254 more
Caused by: org.objectweb.asm.MethodTooLargeException: Method too large: _BuildScript_.run ()Ljava/lang/Object;
	at org.objectweb.asm.MethodWriter.computeMethodInfoSize(MethodWriter.java:2088)
	at org.objectweb.asm.ClassWriter.toByteArray(ClassWriter.java:512)
	at org.gradle.internal.classpath.transforms.BaseClasspathElementTransform.processClassFile(BaseClasspathElementTransform.java:111)
	at org.gradle.internal.classpath.transforms.BaseClasspathElementTransform.visitEntry(BaseClasspathElementTransform.java:86)
	... 263 more

This is caused by focus behavior: it generates a huge buildscript (~1400 lines). Java can't process methods such big.
To fix this I made focus generate a CSV with list of modules that needs to be included and a small single-loop buildscript that parses that CSV.
Also I added configuration cache support for createFocusSetings task.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Looks like this just needs the apiDump task run to update the API. The updates look fine to me (they're just adds), and I can do it tomorrow during work if you don't get to it first.

Hi, @rharter,
Could you please release a version of the plugin with this fix? I'm using the build of this plugin from maven-local, and it's a bit frustrating.

Done, as 0.7.0.


Terminal cursor ability to set transparency

Description
As you can see from the default image on the terminal where the cursor is, you cannot see the letter underneath, even if you change the color.
It would be useful to be able to set transparency.

Version information
Aurora Editor: 1.0 (20230915.2006)
Commit: 38620af465c62bd496aa333090247146b1107fa4
MacOS: 13.5.2 (22G91)
Xcode: 14.3.1 (14E300c)

Hello, mind if I work on this issue?

Hello, mind if I work on this issue?

Thanks for working on this issue, I assigned this to you.

Hi, you are more than welcome. I just have the idea that you might have to clone the terminal package.


Add additional date formats

From runtime output: Please use either YYYY-MM-DD, YYYY-MM, or YYYY format.
I'm from the US and was trying to use MM-DD-YYYY.
Perhaps consider allowing two digit years?  It'll be a while before Y3k.

Thank you for opening an issue. I don't think we need to add new date formats because the dates in the YAML file are meant to be pure date data in ISO 8601 format. They are not printed in PDF in that format anyway. They are converted into normal English strings (or into any language, by updating locale_catalog field in the YAML file).
Allowing two digits would be a problem because people still use the 1980s and 1990s in their CVs.


Add dashboard context option integration

Will fix merge conflicts soon...
Description

For monitor name, add 6 random numbers long appended to end
Refreshing channels when opening dropdown (disabled isLoading due to bug)
Surface errors to top
Rework use of CreateMonitor (improved some existing functionality that will help with a "loading" state for the create button)
Remove ids from Trigger and Notification names, now we just number them 1,2,3,4,5... (and keep adding a digit until it is unique)
Popup for actions configure should only keep values if "Update" is clicked...added a Cancel button

Notes

Could not reproduce "if delete the single notification, you cant setup another without closing the flyout again"
Waiting on AD integration branch to properly configure Alerting flyout for when coming from AD

Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@lezzago @amsiglan please review when you have a chance, thank you.


Watch bookmarks to beta

Ref: https://github.com/kubernetes/website/pull/15530#issue-301067619
/assign @lavalamp @deads2k

/lgtm

/lgtm

@kbhawkey @liggitt - PTAL

/lgtm

/approve

/cc @simplytunde

@wojtek-t 👋 Please rebase this PR in order to continue. Looks like it's headed in the right direction, so anyone can /lgtm after rebase.
/approve

/hold

Rebased.
/hold cancel
PTAL

/milestone 1.16

@wojtek-t Thanks for rebasing. Sorry, I missed that this is for 1.16; I'll leave approval for @simplytunde.
/approve cancel
/lgtm

/approve cancel
[APPROVALNOTIFIER] This PR is APPROVED

/shrug

/approve cancel
[APPROVALNOTIFIER] This PR is APPROVED

/shrug
@kubernetes/sig-testing-pr-reviews 👋 Did I miss something with removing /approve?

 I'm removing them with magic admin powers.

/hold

/approve

/approve cancel

/approve

@zacharysarah - can we hold cancel now?

@wojtek-t Because this PR is part of the 1.16 release cycle, it's up to the docs release lead (@simplytunde) as to when it merges.
That said, it LGTM.

/hold cancel


feat: add ETag attribute filter

:tada: This PR is included in version 0.12.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


windows 2012 support

hey, recently i tried testing this code on window server 12 with some changes. Like i added CPFT_EDIT_TEXT to get username and CPFT_PASSWORD_TEXT to get the password. This works fine on windows 11, 16 and 19 but on windows 2012 the CPFT_EDIT_TEXT isn't shown at all. any idea what am i missing here?  Below is a snapshot from my WindowsCredentialProviderTile file
public List<_CREDENTIAL_PROVIDER_FIELD_DESCRIPTOR> CredentialProviderFieldDescriptorList = new List<_CREDENTIAL_PROVIDER_FIELD_DESCRIPTOR> {
            new _CREDENTIAL_PROVIDER_FIELD_DESCRIPTOR
            {
                cpft = _CREDENTIAL_PROVIDER_FIELD_TYPE.CPFT_SMALL_TEXT,
                dwFieldID = 1,
                pszLabel = "Hello World",
            },
            new _CREDENTIAL_PROVIDER_FIELD_DESCRIPTOR
            {
                cpft = _CREDENTIAL_PROVIDER_FIELD_TYPE.CPFT_EDIT_TEXT,
                dwFieldID = 2,
                pszLabel = "Username",
            },
            new _CREDENTIAL_PROVIDER_FIELD_DESCRIPTOR
            {
                cpft = _CREDENTIAL_PROVIDER_FIELD_TYPE.CPFT_PASSWORD_TEXT,
                dwFieldID = 3,
                pszLabel = "Password",
            },
            new _CREDENTIAL_PROVIDER_FIELD_DESCRIPTOR
            {
                cpft = _CREDENTIAL_PROVIDER_FIELD_TYPE.CPFT_SUBMIT_BUTTON,
                dwFieldID = 4,
                pszLabel = "Login",
            }
        };

Hey @nikhilty,
Is that the only field that is not shown?
Maybe you should try rebuilding the project, it might be an update problem.

i did try. it does work on windows 2016, 2019 and 2011 but on 2012 it doesn't show up at all

Just to clarify, is it only the text input field that is not visible? The rest of the elements are there?

yeah its only the CPFT_EDIT_TEXT field which isn't visible on 2012. rest are fine

That could be the COM bindings for that specific windows version. I cannot find any documentation for it, so it is very hard to find out.
I would check the COM definitions in the SDK for your version.

ok so i figured it out. On windows 2012 it isn't allowed to switch users on lock screen so adding an editable USERNAME field wasn't being allowed although i am able to add a CPFT_SMALL_TEXT or CPFT_LARGE_TEXT USERNAME field.
Closing this ticket.

Hey @phaetto , one more issue i'm seeing with windows 2012 r1 standard server is that the ICredentialProvider::GetFieldDescriptorAt method isn't getting called at logon which is causing a blank logon screen with fields not getting populated. All other methods under ICredentialProvider are getting called.
The same plugin is working fine with windows 2012 r1 and r2 datacenter servers as well as 2012 r2 standard server.

Sorry, I don't have the testing environment to check this out, I hope someone else can help

i was able to do this. thanks


Support for single-quote bracket notation for params

This change adds single-quote bracket notation to the work done in #4215. This is consistent with how referencing is done elsewhere in K8s in the downwards api.
The original patch used the name subscript notation to describe this however the standard name for this approach is bracket notation and updates the doc accordingly.
This is based on TEP: tektoncd/community#503 -- which also needs to be aligned with the two bracket notation approaches in the implementation.
Changes
This change adds single-quote bracket param matching to the params and param results analagous with the double-quote bracket param matching. It also adds similar test cases and updates the doc with the single-quote syntax.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[x] Docs included if any changes are user facing
[x] Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes
Params and result can now be referenced with bracket notation using both single and double quotes in addition to dot notation. For example, the following are equivalent:  $(param.myparam), $(param['myparam']), and $(param["myparam"]). Bracket notation has the additional benefit of allowing users to work with parameter names containing conflicting characters like "." (e.g. $(param['my.param']) or $(param["my.param"]).

/kind feature

thanks @skaegi for implementing this feature, I have left a comment to add one unit test and will be great if you can update the proposal with the bracket notation:
Proposal has:
  steps:
    - image: $(params[dev.mattmoor.foo])

Correct it to use bracket notation with double quotes:
  steps:
    - image: $(params["dev.mattmoor.foo"])

And bracket notation with single quotes:
  steps:
    - image: $(params['dev.mattmoor.foo'])

/approve

Putting on a brief hold to collect feedback from the other maintainers, have added to the agenda in the next API WG.
thanks @skaegi for your patience 🙏
/hold

/test pull-tekton-pipeline-alpha-integration-tests

thanks @skaegi for updating the proposal with the correct syntax. Based on the discussion in the API WG (10/04), I am cancelling the hold 🙏
/hold cancel

thanks @vdemeester for approving, changing my approval to lgtm 🙏
/lgtm

thanks @skaegi
/lgtm


[NoQA] fix: handle push-notifications permission granting failure

Details
Subsequent fix for https://github.com/Expensify/App/pull/41789
If we grant permission where android.permission.POST_NOTIFICATIONS is not available - it will throw an exception (exception will be present on all Android < 13 devices) and it will interrupt test execution.
In https://github.com/Expensify/App/actions/runs/9009450323/job/24754627531 we were running an e2e on Android 12:

05-08 16:21:13.656 29647 29647 D nativeloader: Configuring clns-shared-4 for other apk /system/app/KeyChain/KeyChain.apk. target_sdk_version=32, uses_libraries=,

Fixed Issues

$
PROPOSAL: N/A
Tests

[ ] Run e2e test on Android < 13

Offline tests
Not needed.
QA Steps
N/A
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.74-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.74-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Update HOscillator.java

Fixes minor bug. If HOscillator().range appeared before HOscillator().target (as per below), then min3 and max3 would not be properly set when using H.SCALE on a HDrawable 3D. Proposed change means that method chaining for HOscillator should work, even when range appears before target.
//EXAMPLE - new HOscillator().range(0.75, 1.75).target(d).property(H.SCALE).currentStep(1).speed(1.6).freq(2.3);

Thanks @DonoG.  We'll take a look and get it merged up.


Sending a .wav file through FormData using MultipartFile adds headers which corrupt the file

Package
dio
Version
5.1.1
Output of flutter doctor -v
[✓] Flutter (Channel stable, 3.10.1, on macOS 13.2.1 22D68 darwin-arm64, locale en-AE)
    • Flutter version 3.10.1 on channel stable at /Users/hussainsurti/Development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision d3d8effc68 (5 weeks ago), 2023-05-16 17:59:05 -0700
    • Engine revision b4fb11214d
    • Dart version 3.0.1
    • DevTools version 2.23.1

[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
    • Android SDK at /Users/hussainsurti/Library/Android/sdk
    • Platform android-33, build-tools 32.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E300c
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)

[✓] VS Code (version 1.79.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.66.0

[✓] Connected device (3 available)
    • hPhone (mobile)        • 00008030-001125183EEA802E            • ios            • iOS 16.5 20F66
    • iPhone 14 Pro (mobile) • 34885522-5A35-4C29-99EA-05A95C814673 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-4
      (simulator)
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 114.0.5735.133

[✓] Network resources
    • All expected network resources are available.

Dart Version
3.0.1
Steps to Reproduce
Try to upload a .wav file through Dio corrupts the .wav file. I am trying to upload a .wav file to AWS using a pre-signed url. No matter what I do, there are headers added to the file, which results in corruption of the file. If you open the file in a text editor, and remove those headers, the file is then recovered.
The headers that are added look like this:
----dio-boundary-3691860624
content-disposition: form-data; name="file"; filename="83c5e69b-cd7a-484f-b0ad-e5d4d1d11789.wav"
content-type: audio/wav

The same issue also occurs when uploading files through the http package as well. In that case, the headers look like:
--dart-http-boundary-HDW3BKXn44Z.u7Wsu8FE6jNjoxcuwx0HxKEk7Pf.SUz-xL5J9kX
content-type: audio/wav
content-disposition: form-data; name=""; filename="1a3465fa-e66f-4e03-a225-0aac45da2e4f.wav"

I understand that this is done for a reason, however, I do not see a way to disable it.
The following is the relevant parts of the code that is running
final multiFile = await MultipartFile.fromFile(
        wavFile.path,
        filename: fileName,
        contentType: MediaType('audio', 'wav'),
      );

      FormData formData = FormData();
      formData.files.add(MapEntry('file', multiFile));

      final resp = await Dio().put(
        uploadUrl,
        options: Options(
          headers: {
            'Content-Type': 'multipart/form-data',
          },
        ),
        data: formData,
      );

This will successfully deliver the file to the server. But, as I mentioned above, the file is corrupted due to the addition of the headers.
Expected Result
Using MultipartFile does not corrupt .wav files
Actual Result
Using MultipartFile corrupts .wav files

Please check here for a (maybe temporary) solution to the bug.


Update WC 7.2.1 quantity input.php

Quite sorry, didn't have time to get around to reviewing it yet 😅

Don't worry, this was just a string. Maybe it's better not to disturb you on each minor change ;-) Happy new year, hope you are fine.


Actv atlas

Pull request for all the work done for crating visualizations with lucid

Also, please remove the *.pyc files.
I think they should be generated dynamically
by the user.

Added new module that contains the DLA cnn model definition. Still need to work on 'visualizations.py'

I added documentation for visualizations.py, this file isn't really important (it created the initial 3D optimizations)


[TASK] Resource exhaustion testing to verify volume resilience

What's the task? Please describe
We need to do some resource exhaustion testing to see if Longhorn volumes still work well with the parent workloads, then it's better to understand how Longhorn reacts to this kind of negative situation to ensure volume resilience.

Resource:

Node (compute, involuntary on/off)
Disk (storage space, disk broken)
The network connection between workload, engine, replica (1-n failures) during ongoing operations (ex: rebuilding, etc)

Conditions:

A data-intensive application using longhorn volumes

Describe the items of the task (DoD, definition of done) you'd like

[ ] TBD

Additional context
Add any other context or screenshots about the task request here.

Closing by tracking via QA's negative testing. cc @longhorn/qa


side chain RPC issue

if putting side chain RPC url its showing invalid responce

same issue with goerli RPC(https://rpc.goerli.mudit.blog) also

Could you try to reproduce this against the Infura goerli endpoint? This behaviour suggests that the RPC endpoint is returning an empty response, which is against the ethereum JSON-RPC spec.

We should double-check on our side, because the endpoints do seem to be valid:
$ curl https://rpc.goerli.mudit.blog/ -H "content-type: application/json" --data '{"jsonrpc":"2.0","method":"eth_getBlockByNumber","params":["latest", true],"id":1}'
{"jsonrpc":"2.0","id":1,"result":{"difficulty":"0x1","extraData":"0x0000000000000000000000000000000000000000000000000000000000000000ea6dbcb72bfe9b62c2b79213afae80415cd29f4f7ae7799e89e85b13f9ce46797d0fb9a9bf5ea1e70b30b3cbab8a1673926a1b4974c6eeed870d7ce20afd0de100","gasLimit":"0x7a1200","gasUsed":"0x31e349","hash":"0x04b67f1277680c372d41209dab066d5f6f0a96e933e47d19bf1af4bcae660f50","logsBloom":"0x00000040000008000000000000000000000000000000000000000000000000000000000000400000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000002000000000000000000000000000000000000000000000000000000000024000000000000000000000004000000000000000000000000000000000000000000000000000000008020000000800000000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000","miner":"0x0000000000000000000000000000000000000000","mixHash":"0x0000000000000000000000000000000000000000000000000000000000000000","nonce":"0x0000000000000000","number":"0xdcbeb","parentHash":"0x092de0e86446ffbc0e4e685d113a3fbffb926c6955704395599a926f02e33970","receiptsRoot":"0xaaa263289d91692fc0e68dba64425730762b06a4ec25977319c711a922698892","sha3Uncles":"0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347","size":"0x330","stateRoot":"0xebd7feb0d483e60c06c5f1b402061fb6c98e25c64fa5fc0f6d3538f2dab0527f","timestamp":"0x5d231707","totalDifficulty":"0x15244a","transactions":[{"blockHash":"0x04b67f1277680c372d41209dab066d5f6f0a96e933e47d19bf1af4bcae660f50","blockNumber":"0xdcbeb","from":"0x4f6ba656faf84666b07025ed3c4cbd99ea7cb67e","gas":"0x416add","gasPrice":"0x3b9aca00","hash":"0x7dfea1de5c1f07605a6cb932dab9d2bbe5541fbf57f278260cb228ffa344f949","input":"0xcc2799c7000000000000000000000000ba99a0e3e1b08fe880acdbe978434b61e4258a94ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff","nonce":"0x0","to":"0xd92c6e085e7245c3d478bf64d16974ab6a6c2a56","transactionIndex":"0x0","value":"0x0","v":"0x1c","r":"0xeb54620cdfc07eb26ead470d41dcc3080eafe90d174323ebf4e33fb4466333bc","s":"0x5512bc42ba487526cec9cf17d56d9cf01144ea5a507d17114176e1460d9d117e"}],"transactionsRoot":"0x9913cd5174f23aec80f5a46a8106fcddfa8d43bb2e39d7b2b1f4c4d41a0ccffb","uncles":[]}}

They do require the content-type header to be set to application/json though, otherwise they won't return a valid result. Maybe that's the culprit:
$ curl https://rpc.goerli.mudit.blog/ --data '{"jsonrpc":"2.0","method":"eth_getBlockByNumber","params":["latest", true],"id":1}'
invalid content type, only application/json is supported

It looks like rust-web3 does add that header to requests https://github.com/tomusdrw/rust-web3/blame/master/src/transports/http.rs#L159.

@Jannis @leodasvacas
did you get any solution?

@vishpari What Ethereum node are you using for those endpoints?

@vishpari I didn't mean the URL, I meant what software powers that endpoint? geth, parity, something else? I'm asking because the endpoint's JSON-RPC API seems to be incompatible with that of geth and parity. If we want to investigate it would help to be able to know more about the Ethereum implementation used in this case.

we are using parity.

What's the Parity version? And is there a proxy sitting in front of the node that could alter requests/responses?

version Parity-Ethereum/v2.4.5-stable-76d4064-20190408/x86_64-linux-gnu/rustc1.33.0
and using Nginx as reverse proxy form 443 to 8545

@Jannis @leodasvacas
i am waiting hearing from you soon.


HTMLRewriter does not have info about Content nor ContentOptions types

Which Cloudflare product does this pertain to?
<IP_ADDRESS>
Existing documentation URL(s)
https://developers.cloudflare.com/workers/runtime-apis/html-rewriter#methods
Section that requires update
https://developers.cloudflare.com/workers/runtime-apis/html-rewriter#methods
What needs to change?
Neither Content nor ContentOptions have information about what is the shape of those objects.
How should it change?
Both Content and ContentOptions should have pages that describe their structure.
Additional information
No response

Can you share what you're looking for beyond what is described here?

hello @irvinebroque
it would be nice to have them linked as it is done, for example for Response on https://developers.cloudflare.com/workers/runtime-apis/fetch-event/#supported-fetchevent-properties page. Maybe just linking to https://developers.cloudflare.com/workers/runtime-apis/html-rewriter#global-types would be fine?
Neither Content nor ContentOptions are searchable with search in the top search bar.


news52: fix rpc setwalletflag

Git grepping returns no instance of "setwalletflags" in Bitcoin Core.
According to git blame, the setwalletflag RPC was added in https://github.com/bitcoin/bitcoin/commit/f904723e0d5883309cb0dd14b826bc45c5e776fb and named as such from the start.

ACK

ACK.  Thanks!


Allow editing up to OPEN bounties

A special edit UUID will be generated every time the edit button is hit. This special key can be inserted into bounty db and verified from the front end using the same key passed in the url.

#57 completes this


[FLINK-8807] Fix ZookeeperCompleted checkpoint store can get stuck in infinite loop

Before, CompletedCheckpoint did not have proper equals()/hashCode(),
which meant that the fixpoint condition in
ZooKeeperCompletedCheckpointStore would never hold if at least on
checkpoint became unreadable.
We now compare the interesting fields of the checkpoints manually and
extended the test to properly create new CompletedCheckpoints. Before,
we were reusing the same CompletedCheckpoint instances, meaning that
Objects.equals()/hashCode() would make the test succeed.

@StephanEwen I'll add a test once we agree on how the comparison should be done.

Thanks for the comments! I'll incorporate them and merge.


regarding the setting of the hyperparameter "ada_kimg"

Hello, thank you for your excellent work. Regarding your code, there is one point that I am not clear about, what does the parameter "ada_kimg" represent?
if update_diffusion:  # batch_idx % ada_interval == 0     adjust = np.sign(sign(Discriminator(real_images)) - ada_target) * C  # C = (batch_size * ada_interval) / (ada_kimg * 1000)     diffusion.p = (diffusion.p + adjust).clip(min=0., max=1.)     diffusion.update_T()

It is a parameter to control the speed of adjusting the diffusion.p. If ada_kimg is large, diffusion.p will increase and decrease slowly. ada_kimg could also be seen as how many images need to be seen to let diffusion.p = 1 in the fastest increasing.

Sure, thank you. May I know what values have you set for this parameter in your experiment? I would greatly appreciate it if you could provide me with an answer.

Sure, thank you. May I know what values have you set for this parameter in your experiment? I would greatly appreciate it if you could provide me with an answer.

Sure, thank you. May I know what values have you set for this parameter in your experiment? I would greatly appreciate it if you could provide me with an answer.

We use 100 and this is the default value in the code.

fine, hava a good day!

We use 100 and this is the default value in the code.

fine, have a good day!


DEP: remove local_search_options of dual_annealing

Reference issue

Closes #15807
What does this implement/fix?

Remove the deprecated local_search_options keyword from dual_annealing. Also removed the test which checked if an appropriate DeprecationWarning was raised when used.
Additional information

Thanks @jyuv. I made a note on the issue to merge this PR when we're ready for 1.10.0 development.

@rgommers this can now be reopened


docs: add code of conduct checkbox to issue templates

Codecov Report

Merging #22 (b6a8f83) into main (2319ae9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage   82.07%   82.07%
=======================================
  Files           4        4
  Lines         212      212
=======================================
  Hits          174      174
  Misses         27       27
  Partials       11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2319ae9...b6a8f83. Read the comment docs.


[BEAM-11571] Support Conversion to GenericRecords in Convert.to transform

R: @TheNeuralBit
CC: @reuvenlax

Merged manually to fix a minor conflict on CHANGES.md

Merged manually to fix a minor conflict on CHANGES.md


How to get an expirable URL

I'm trying to generate and share a file-url which expires in a few seconds (let's say 60). Till the time the url is valid, even an anonymous/non-logged in user should be able to access the file data.
So this helper does just that - {{url auth=60}}
However, how do I check in the allow/deny download function to check if the token is valid and is not expired yet?
FileObjects.deny({
 download: function(userId, fileObj){
  // ----- What to check for?
  // userId can be null since even anonymous users can download this file while it is valid
  return false;
 }
});

Any pointers would help.
Thanks

Although I don't know how that would work (using deny), I'd like to share another way to achieve this.
I'm using a dedicated page/route with iron router and a separate download permit collection for file downloading (fsFile collection always denies downloading).
When generating the download link, create a new download permit/token in the dedicated collection and set its expiration date. In the download route, validate the download permit/token and then initiate the downloading by:

open readstream from the requested file,
open writestream to the response (in the route)
pipe the readstream to the writestream.

Hope this helps.


Exclude the sigstore_rs library when building on s390x

Exclude the sigstore_rs library when building on s390x and do not support cosign image signing on s390x.
Fixes: confidential-containers#80
Signed-off-by: Matthew Arnold<EMAIL_ADDRESS>

Hi Hendrick @hbrueckner . Could you check this PR for excluding the sigstore-rs crate and cosign image signing when building on s390x.

Hi @mattarnoatibm @Xynnn007 , it is possible to build different signature schemes as features and kata-agent can use platform specific dependeicies: https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#platform-specific-dependencies or enable workaround in image-rs to build default features depends on different hardware: https://stackoverflow.com/questions/67373380/can-i-set-cargo-projects-default-features-depending-on-the-platform

Hi @arronwy . Thanks for your feedback.
I've got the cosign signing building conditionally as a feature. On s390x architecture machine the following commands run successfully:
cargo build --no-default-features --features overlay_feature,ocicrypt-rs,attestation_agent/default,ocicrypt-rs/default
cargo test --no-default-features --features overlay_feature,ocicrypt-rs,attestation_agent/default,ocicrypt-rs/default

On amd64 architecture machine build and test with default features using
cargo build
cargo test

works.

lgtm, thanks for the PR. :wink:

Hi, thanks for the PR.  For Cosign is a separate mod and I prefer to add
#[cfg(feature = "cosign")]

to all the cosign related imports and sentences, s.t.

pub mod cosign; in src/signature/mechanism/mod.rs
Cosign(CosignParameters), in src/signature/policy/policy_requirement.rs
PolicyReqType::Cosign(inner) => inner.allows_image(image, auth).await, in src/signature/policy/policy_requirement.rs
PolicyReqType::Cosign(scheme) => Some(scheme as &dyn SignScheme), in src/signature/policy/policy_requirement.rs

In this way we can avoid unnecessary conditional test code in cosign/mod.rs and it seems more clean.
As for the simple_signing.rs, I'm going to make a new PR to define the counter part in image-rs. Then we can directly avoid add more definitions of SimpleSigning Payload.

Hi, please rebase the newest commit and feel free to add
#[cfg(feature = "cosign")]

to
impl From<sigstore_rs::simple_signing::SimpleSigning> for SigPayload {

Hi, thanks for the PR. For Cosign is a separate mod and I prefer to add
#[cfg(feature = "cosign")]

to all the cosign related imports and sentences, s.t.
* `pub mod cosign;` in `src/signature/mechanism/mod.rs`

* `Cosign(CosignParameters),` in `src/signature/policy/policy_requirement.rs`

* `PolicyReqType::Cosign(inner) => inner.allows_image(image, auth).await,` in `src/signature/policy/policy_requirement.rs`

* `PolicyReqType::Cosign(scheme) => Some(scheme as &dyn SignScheme),` in `src/signature/policy/policy_requirement.rs`

In this way we can avoid unnecessary conditional test code in cosign/mod.rs and it seems more clean.
As for the simple_signing.rs, I've made a new PR #83 to define the counterpart in image-rs. Then we can directly avoid add more definitions of SimpleSigning Payload.

Hi @Xynnn007 , thanks for your feedback.
I've conditionally included all cosign related modules and imports in mechanism/mod.rs, payload/simple_signing.rs and policy/policy_requirement.rs.

I've currently got a work in progress for making the tests/signature_verification.rs tests work when the Cosign(CosignParameters) is removed from the PolicyReqType enum in policy_requirements.rs on s390x.

Hi @Xynnn007 ,
I refactored my PR to remove all Cosign structures from the image-rs code if we're building image-rs without the cosign feature.
This did have a side effect that I needed to make some changes in the test module to make the tests in signature_verification.rs test do the right thing for the test data in the case where image-rs is built without cosign support.  Because if image-rs is built without cosign a policy with any policies that use sigstoreSigned will trigger the parse error, even when the image being pulled is not signed using cosign.
If that change is not good for the testing module could we revert this PR to commit 6758fe3 and return the error for image-rs being built without support for cosign?

Thanks @Xynnn007 for all you help and time reviewing this PR.


Add MSSQL Support to Antares

Hi Antares Team,
Firstly, I want to extend my gratitude for the incredible work you all have put into developing Antares.
I would like to request support for Microsoft SQL Server (MSSQL) in Antares. While I'm not a fan of MSSQL, there are times when I have to use it, and SQL Server Management Studio (SSMS) is quite a pain to work with.
Thank you for considering this request :smile:
Best regards,
Adrien

Hi @IGLOU-EU,
MSSQL implementation is planned and will probably be next on the list (or DuckDB).
I've been thinking about implementing it for quite some time but wanted to prioritize open source database support.
Currently I still have some UI-side features I want to implement and later I think I will aim for a new DB.
Thank you for your appreciation!

Hi @Fabio286 ,
Great to hear that is planned! :partying_face:
I agree, supporting widely-used open-source databases was definitely the right priority.
Looking forward to the updates!
Thanks.

@Fabio286 I would also like to express my gratitude for the amazing work you did on this app! Really a top-notch db app.
And would also like to know if you will maybe have some time in the near future to implement Microsoft SQL Server (MSSQL) in Antares?


[Bug/漏洞] 世界崩解之镐锤形态崩溃

Checks / 检查

[X] I confirm that I have searched for existing issues / pull requests before reporting to avoid duplicate reporting./我确认在报告之前我已经搜索了现有的问题或者拉取请求，以避免重复报告。
[X] I confirm that I followed the Docs and read the Changelog, but this problem still exists./我确认我按照文档配置并阅读了Changelog，但这个问题仍然存在。
[X] I confirm that I noted that if I don't follow the instructions, the issue may be closed directly./我确认我已经检查，如果我不按照说明进行操作，该问题可能会被直接关闭。

Java Version / Java版本
17.0.8
Minecraft Version / Minecraft版本
1.20.1
Avaritia-Reforge Version / Avaritia-Reforge版本
1.3.4
Description / 描述
稿子切换锤形态挖地就会崩溃
To Reproduce / 重现
我感觉应该是生成物质球有问题
Log / 日志
crash-2024-01-05_17.24.47-client.txt
Config / 配置
#Avaritia Base Config
[general]
#Does the super mode of endless tools retain stone and soil
"Is Stone" = false
#Whether to merge matter cluster
"Is Merge Matter Cluster" = false
#Range damage value of the right key of Infinity sword
#Range: 100 ~ 100000
"Sword Range Damage" = 10000
#Infinity sword right click attack range
#Range: 8 ~ 64
"Sword Attack Range" = 32
#Does the right key range attack of endless sword attack neutral creatures
"Is Sword Damage" = true
#Infinity bow scattering light arrow damage
#Range: 100 ~ 100000
"Sub Arrow Damage" = 10000
#Chain number of endless axe cutting trees
#Range: 16 ~ 128
"Axe Chain Count" = 64
#Food effect time scaling factor
#Range: 0.1 ~ 5.0
"Food Time" = 1.0
#The range of Infinity PickAxe can break
#Range: 2 ~ 32
"PickAxe Break Range" = 8
#The range of Infinity Shovel can break
#Range: 2 ~ 32
"Shovel Break Range" = 8
#The product tick of NeutronCollector
#Range: > 1200
"Neutron Collector Product Tick" = 3600
#Singularity default time required
#Range: > 0
"Singularity Time Required" = 240

fixed


NullReferenceException when trying to update weapons data.

Describe the bug
An Unhandled Exception (System.NullReferenceException) pops up when trying to update weapons data. This error occurs on both v0.5.1 and v0.5.0. Telling the application to continue (ignoring the error) results in it basically freezing.
To Reproduce
In a fresh unpacked instance:

Start the Akasha Scanner
Go to Weapon Scanner
Try to update the (at the time outdated) weapons data.
The error popup (see in Screenshots) appears shortly afterwards.

Expected behavior
When trying to update the weapons data the download should just complete after some time
and the application continues to run normally afterwards.
Screenshots
The error popup:

Additional context
The entire Exception Text:
************** Exception Text **************
System.NullReferenceException: Object reference not set to an instance of an object.
   at AkashaScanner.Core.DataCollections.Repositories.WeaponsHoYoWikiRepository.Load() in C:\Users\ghfel\Documents\GitHub\AkashaScanner\AkashaScanner\Core\DataCollections\Repositories\WeaponsHoYoWikiRepository.cs:line 31
   at AkashaScanner.Core.DataCollections.BaseCollection`1.LoadRemote() in C:\Users\ghfel\Documents\GitHub\AkashaScanner\AkashaScanner\Core\DataCollections\BaseCollection.cs:line 72
   at AkashaScanner.Ui.Partials.DataUpdate.OnUpdate() in C:\Users\ghfel\Documents\GitHub\AkashaScanner\AkashaScanner\Ui\Partials\DataUpdate.razor:line 66
   at Microsoft.AspNetCore.Components.ComponentBase.CallStateHasChangedOnAsyncCompletion(Task task)
   at Microsoft.AspNetCore.Components.RenderTree.Renderer.GetErrorHandledTask(Task taskToHandle, ComponentState owningComponentState)
   at Microsoft.AspNetCore.Components.WebView.IpcSender.<>c__DisplayClass9_0.<NotifyUnhandledException>b__1()
   at Microsoft.AspNetCore.Components.WebView.WindowsForms.WindowsFormsDispatcher.InvokeAsync(Action workItem)
   at Microsoft.AspNetCore.Components.WebView.WindowsForms.WindowsFormsDispatcher.<>c.<.cctor>b__8_0(Exception exception)

Will take a look on it today

The problem is due to Mountain-Bracing Bolt not being able to parse atm due invalid response from the wiki

@Zapdos333 if find any other bug let me know


Parse PrimitiveLogicalType::Unknown as Arrow Null DataType

This PR adds logic to parse any Parquet fields with Unknown LogicalType as the Arrow Null DataType.

Also, no unit tests on this yet but would love pointers on how to best test this change.
Should I add a new column in the files generated by parquet_integration/write_parquet.py?


Add map reset button

Add a new button to reset the map, this should go next to the existing RESET ALL button

I suppose a question is whether we need a new button, or if we just extend the existing button functionality to include a map reset (start x, start y, start zoom)

For now, I've added a few lines to reset the map. This also gets triggered when one clicks the "RESET ALL" button.
This could be easily be factored out into a new button. But part of my hesitation is that there's not a lot of room here for a second button, and the words "RESET ALL" seem like they should apply equally to the map.
One note, we reset to map defaults defined in seattle.json not the map extent and zoom that comes from the initial URL params. That seems to me like the most obvious reset, but there may be other opinions on that

Change text to "RESET MAP", instead of "RESET ALL"


Document outdated

Hi,
The document is from 2019 and states it supports only
Confluence: 5.0 to 5.10
Confluence: 6.0.1 to 6.15.9
Confluence: 7.0.1 to 7.9.3
However we are already working with Confluence 7.10.0, does this indicate that the method as explained on this page should not work for us?
As per Alassian (https://confluence.atlassian.com/confkb/how-to-connect-confluence-data-center-with-azure-saml-sso-996705898.html) it should work for all Confluence 6.1+.
Thanks
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a45acbc6-caae-be6c-939e-55451831d03e
Version Independent ID: 0d88f4ee-2ac5-1ad4-245b-b8c0752a7303
Content: Tutorial: Azure Active Directory single sign-on (SSO) integration with Confluence SAML SSO by Microsoft
Content Source: articles/active-directory/saas-apps/confluencemicrosoft-tutorial.md
Service: active-directory
Sub-service: saas-app-tutorial
GitHub Login: @jeevansd
Microsoft Alias: jeedes

@mbrans-plieger
Thanks for your feedback! We will investigate and update as appropriate.

@jeevansd Could you please help get this reviewed.

@mbrans-plieger This same plugin will work for Confluence 7.10 I will get the document updated for the new version numbers.

@v-rant for tracking.

#please-close


US-34: Implement Application

US-34:
As a developer I want to connect App module to other MVC modules as a group to make the game run.
Tasks:

[x] Application creates view
[x] Application creates controller
[x] Application creates map / world in model
[x] Application creates a player
[x] Connect controller to application
[x] Connect controller to player movement
[x] Create game loop in application
[x] #94

Acceptance Criteria:

[ ] The user can move the player ship with the keyboard
[ ] The ship texture moves on the screen from the keyboard

Adding the prototype i showed you this friday to this branch and merging


i want to install erlang 17.5 where can i find the formula

reference to this link
someone could help?

Please file a PR; we don't do formula requests, Thanks.


functions NODE_ENV === production

Ok, so here's a bit of an issue that I think will confuse a lot of people: netlify dev actually runs as if everything's in production (NODE_ENV=production), BUT it runs your develop script rather than your start script.
This is problematic because I expect to be able to run everything in development (like NODE_ENV=development) because the script is called dev and it runs my develop script. So it's confusing that my functions would run with NODE_ENV=production.
Does that make sense? I think this could probably be resolved if netlify dev just basically replaced netlify-lambda and ran the netlify-lambda serve script for me. What would be best is if netlify dev could find the script in my package.json that runs netlify-lambda serve and just run that, because my scripts looks like this:
"functions:build": "netlify-lambda build netlify/functions",
"functions:dev": "dotenv -e ./netlify/.env netlify-lambda serve netlify/functions",

If netlify dev just found the script that runs netlify-lambda serve and ran that, then I think this issue would be resolved as would netlify/netlify-dev-plugin#61 and netlify/netlify-dev-plugin#60.

When I running netlify dev, process.env.NODE_ENV is always undefined. I would expect netlify dev to set it to 'development'. I would also expect other Netlify build environment variables to get set such as CONTEXT.

Hi! I wanted to share a couple of updates on the items mentioned in this issue.

I would expect netlify dev to set it to 'development'. I would also expect other Netlify build environment variables to get set such as CONTEXT.

@tysonmatanich This should be available in the latest version of CLI.

Even with the following,
[build.environment]
  NODE_ENV="development"

@jonathan-mothership variables declared in build.environment are now picked up by netlify dev.

As for making NODE_ENV=development by default, it's something we're looking into and we'll update this issue as soon as there's any progress there.
Thanks all!

Hi! I wanted to share a couple of updates on the items mentioned in this issue.

I would expect netlify dev to set it to 'development'. I would also expect other Netlify build environment variables to get set such as CONTEXT.

@tysonmatanich This should be available in the latest version of CLI.

Even with the following,
[build.environment]
  NODE_ENV="development"

@jonathan-mothership variables declared in build.environment are now picked up by netlify dev.

As for making NODE_ENV=development by default, it's something we're looking into and we'll update this issue as soon as there's any progress there.
Thanks all!

Adding more context to clear up confusion.

netlify-lambda uses Webpack under the hood. Webpack inlines environments variables so netlify dev cannot override them. As a workaround you can use a custom Webpack config:

const webpack = require('webpack');

module.exports = {
  plugins: [
    new webpack.DefinePlugin({
      // mirror Netlify Dev envs
      ...process.env,
      // force NODE_ENV to 'development'
      NODE_ENV: 'development',
    }),
  ],
};

The current default for NODE_ENV is undefined for both netlify dev and our production environment, so I'm inclined to keep it that way.

I'll keep this issue open for a bit to allow more feedback.

I'll keep this issue open for a bit to allow more feedback

Closing the issue. We're still open for feedback so please comment if you feel this is something we should change.

I added a custom env var to come over this issue on Environment variables sections so i called it: NEXT_PUBLIC_NETLIFY_NODE_ENV and added different values depending on deploy context


Offer three different cache presets

Three preprocessor-controlled cache presets for unlimited, time-priority and space-priority setups

Done in #13


Now encode relative paths as URIs (Escape space as %20, etc)

This allows the tool to work as normal when there is a space in the relative path of the file to be linked.

@calebmeyer


WebViewJavascriptBridge  of 6.0.0 version , it can't  response for  iOS.

I found that the WebViewJavascriptBridge of  6.0.0 version can't respond for iOS.I try other version ，and the 5.0.8  version  can't respond for iOS also .

I also met this question,can you help me? thx!

@VolientDuan
You can use the 5.2.0 version for the time being, it can be used normally.

I'm sorry I can't help you solve this problem
------------------ 原始邮件 ------------------
发件人<EMAIL_ADDRESS>发送时间: 2017年1月10日(星期二) 下午4:05
收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS>主题: Re: [marcuswestin/WebViewJavascriptBridge] WebViewJavascriptBridge of6.0.0 version , it can't response for iOS. (#259)
@VolientDuan
You can use the 5.2.0 version for the time being, it can be used normally.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

ok!thx

This should be fixed in v6.0.1 (and 6.0.2) which makes v6 back-compatible with v5


Replacing pg-format package

Hi, I ran into vite compile errors when using your package. The errors originated in pg-format package. That repo appears to be unmaintained and probably not depending on that package is a better idea.
You're only using it one place.
https://github.com/dynajoe/tinypg/blob/cbc755d8abcb153e1a8dee4f0a67e074479657b6/src/tiny.ts#L523
Maybe let's change this call to the one natively offered?
e.g. SELECT format('INSERT INTO %I VALUES(%L)', 'locations', 'C:\Program Files');
I think this change would drop support for named arguments but I think that's better than the current unusable state.

A fork such as github.com/ScaleLeap/pg-format could maintain current functionality and receive these updates. It does fix this issue too.


File not found error on windows

errorLog.txt

me too

Thanks for your comments. The source still contains some unmaintained references to civetweb.c. I am currently in the process of cleaning them up.


Cursor appears below prompt in PyCharm Python Console

Hi there. Thanks for the great plugin. I'm pretty late to the Gruvbox party, but it's quickly becoming my favorite theme – especially with the addition of multiple variants to choose from.
I've noticed some surprising behavior when using Pycharm's Python Console with the plugin enabled: the cursor does not appear next to the IPython prompt, but two lines below the point where the prompt ends. None of the other theme plugins that I've tested (default and third-party) cause this behavior, which leads me to assume that we're dealing with a bug here.
Interestingly, an identical issue has been open at caleb/gruvbox-idea#20 since late 2018. It hasn't received any response there.

It really needs to be fixed.
I think the problem is that the prompt sign is missing. There's is no way for me to tell if my code is done or not.
I have gone back to default because of this. Hope this gets resolved.

It should be fixed with #33.


How to override "There is currently a pending copy operation."

Using the command line tool, I will occasionally receive an error: "The remote server returned an error: (409) Conflict. There is currently a pending copy operation." Is there a way to override the current copy operation or force the current copy operation to succeed instead of it failing? There shouldn't be any other pending copy operations taking place, but I am receiving this error anyways.
This occurs when copying an azure storage blob container to another azure storage blob container.
I have /NC:"number-of-concurrent-operations" set to 1 and there shouldn't be any miscellaneous copy operations interfering.
Using AzCopy v<IP_ADDRESS> since I need Table support.

Hi @japicket ,
AzCopy doesn't support to force to copy to destination with a pending operation.
For the issue you met, did you use the resuming feature in AzCopy?   I may be able to find some clue on our server side log.
Thanks
Emma

Closing since V8 is no longer being actively maintained. Please give V10 a try here, it's been GA for a bit of time now. Please don't hesitate if you encounter any issue.


Style: Back button on single post page

What's the suggested design idea?
Currently there is not back button for user to go back to feed page. A back button help them to continue browsing to the feed.

[!TIP]
Contributor can refer the /user/userId or /user/bookmark pages

Add screenshots

Record

[X] I agree to follow this project's Code of Conduct
[X] I want to work on this issue

assign me this issue

Hi @jaymehta002, assigned to you


[FEAT]: docs/howto: Add "HOWTO Configure a Static IP Address on Linux"

Should also mention Netplan and how is used in Ubuntu

alv67 approved these changes 1 hour ago

Thanks @alv67 but before merging I would like that someone

Should also mention Netplan and how is used in Ubuntu


fix(metadataCardContent): Provider covers text after decrementing value

Description
It has been observed in Storybook on the metadataCardContent Component, that when a provider count is increased to max 9 value and then decreased to a single provider, the effects are still masked over the text.
References

Testing

Go to metadataCardContent
Change number of visible providers to 9
When number of visible providers is 9 Detail text should be masked
Change number of visible providers to 1
When number of visible providers is 1 Detail text should not be masked.

Automation

Checklist

[X] all commented code has been removed
[X] any new console issues have been resolved
[X] code linter and formatter has been run
[X] test coverage meets repo requirements
[X] PR name matches the expected semantic-commit syntax

Test Execution Passed.

Test Execution Passed.

Test Execution Passed.

Test Execution Passed.

Test Execution Passed.

:tada: This PR is included in version @lightningjs/ui-components-v2.22.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[feat] Auto-update from Github releases.

Describe the problem
We're publishing all our builds to Github releases, so it would be great if the auto updater supported pulling updates through the Github api directly, without the need of a server component. electron-builder supports this out of the box and it's been incredibly useful.
Describe the solution you'd like
Here is how electron builder does it: https://github.com/electron-userland/electron-builder/blob/master/packages/electron-updater/src/providers/GitHubProvider.ts
Here the basic outline:

Get the latest release
Get the list of attached release assets
Look for a config file with a specific name. (i.e. update.json), which contains versions and urls to all download files. E.g.:

{
    "version": "1.0.0",
    "windows": {
        "url": "[url to windows update file]",
        "checksum": "[checksum of windows update file]"
    },
    "macos": {...},
    "linux": {...}
}

Check if the provided version is newer than the current version.
If version is newer, download appropriate update file for given platform.
Check checksum
Install update

Alternatives considered
No response
Additional context
No response

We already support this, with and without a server. Check https://tauri.studio/en/docs/usage/guides/updater#update-file-json-format

That's embarrassing... I guess next time I should read the docs more carefully. Thanks for the quick response!