Validate the parent-child relationship before provisioning child service instance

Currently, there is no method validating the parent-child relationship, so users may misuse it. For example, the user creates a azure-mysql-5-7-dbms instance and gives it an alias dbms, and then tries to creates a  azure-postgresql-9-6-database instance with parentAlias set to dbms, which is definitely a incorrect behavior, but the broker doesn't prevent this. Should we validate the parent-child relationship before provisioning child service instance?

I think this is a good issue to improve the parent-child mechanism in OSBA. To validate the relationship, first we need to extend parent in catalog from a service to a set of services, as MS SQL database instance has two legal parents now. Second, I think child service ID is redundant and removable. It is only used here: https://github.com/Azure/open-service-broker-azure/blob/master/pkg/service/schema.go#L545. We can just replace it with a bool flag to identify a parent.

When thinking about the implementation of this, I find one blocker for this, see code here: when can't find instance with parentAlias in store, we wait for it appears in store. As this function is invoked in async task checkParentStatus, so we can't make sure the parent instance exists in the store until task checkParentStatus succeeded, which makes us can only get the parent instance from the store
and validate it by adding an additional async task. But ideally, the validation should be done in http handler(pkg/api/provision.go) and return error message to user if the validation fails.
Considering every instance will be written to store in very early provisioning( after preProvision is executed), can we directly check it in the http handler and return 400 Bad Request when we can't find the parent instance in the store? If so, we can then validate the parent-child relationship in the http handler much easier.

I've commented on the PR you've opened, but I'll summarize here as well. When we're dealing with Kuberentes, it's possible that these requests may come in out of band. The logic you describe above was introduced for that scenario.
One of the things we wanted to add originally was the ability for these to "time out" if a parent hadn't been provisioned in a certain amount of time.  that might help with the misuse, but we'll break a valid use case for K8s if we change the validation as you're proposing.

Agree with @jeremyrickard.
Should start by implementing the timeout so that on provision, a child doesn't wait indefinitely for its parent to exist and upon deprovisioning, a parent shouldn't wait indefinitely for its children to be deprovisioned. There should already be an open issue for this.
It definitely is a good idea to do some additional validation, but it simply cannot be done synchronously when the provision request is submitted because, as @jeremyrickard has noted, if a parent and child are both in a Helm chart (or other Kubernetes manifests) there's no guarantee at all that the parent is provisioned before the child, so there's no choice except for child provisioning requests to be accepted and deferred until the parent exists...
What you can do (if we aren't already) is do this validation after parent provisioning is resolved and as child provisioning commences. (Honestly, we might be doing this already.)

So is it the right place to validate parent here: https://github.com/Azure/open-service-broker-azure/blob/master/pkg/broker/check_parent_status.go#L41?

@zhongyi-zhang somewhere around line 64 after you are done waiting for the parent.


Omniverse UI text fields update on every input instead of just entered change

When entering data into a field, the update is propagated on every keystroke instead of just when the user is done typing or hits enter. These partial updates cause annoying things like assets moving around as you enter a translation, or errors for invalid URLs/filepaths while you are typing them. There doesn't seem to be a way to prevent this natively in OV yet, but @weegeekps suggested a custom "debounce" that fires off a real update once the frequency of partial updates has slowed.

After looking at this with @weegeekps there doesn't seem to be a way we can solve this without OV adding a feature to handle it for us.


Broken links from k8s.io/docs/concepts/cluster-administration/flow-control/ to API references

This is a Bug Report

Problem:
I tried to follow the links to the API Reference pages for FlowSchema and PriorityLevelConfiguration and I got to the right web page but not the right place in the web page.  The URL's segment identifier is missing a bit of stuff at the end.
Proposed Solution:
Fix the URLs.
Page to Update:
https://kubernetes.io/docs/concepts/cluster-administration/flow-control/

/help-wanted

/good first issue

/good-first-issue
/language en

I will work on this.

Updated line 167(PriorityLevelConfigurations) &170(FlowSchemas) for correct api reference. #20077

@Heena-PyCloud : thanks!


Class/Homework: Fill expansion panels for class and homework with useful information for teachers and students

Idea for homework panel as a student:
Display his/her position of submission, i.e. display a line that says:
You were ##3 to submit this homework
And if he/she is the first one, we could additionally display a cake icon
--> This would be some sort of "gamification" :)

We can discuss about the icon and/or the text, but the functionality is implemented and working :)

@ge98hod I just commited two first ideas for the homework and class expansion panels of the teacher. :)


Integrate search frontend + backend

General tasks

[ ] Add the text box 'Date' field to the search landing and figure out where it will sit on the results pages (similar to the one on Discovery https://discovery.nationalarchives.gov.uk/ Between YYYY and YYYY)

Catalogue results frontend tasks

[ ] Add JavaScript for show/hiding filters and buckets on mobile
[ ] Figure out the HTML syntax and styling of error messages

Potential backend tasks

[ ]  The header menu elements will need aria-current=true if the page is a child of that menu item. This then displays it as selected via the CSS. It's currently hard coded so that the search menu item is always selected.
[ ] If you’re not on  a search page, add a data-id='search-nav-link to the header menu search link, so that our JavaScript component can render global search by replacing that link.
[ ] Add an aria-current=true to the corresponding search tab depending wether you’re on Featured results, catalogue results, or website results
[ ] There is a description  paragraph for each results page. For example: This page displays search results for records that are held at The National Archives, Kew. with a shorter one for mobiles Results for records held at The National Archives, Kew. These will need to change based on the search tab and search bucket.
[ ] Fix the "Records from The National Archives" bucket which is currently a duplicate of "Online records from The National Archives"
[ ] The bucket links will also need an aria-current=true if it is the selected one. The bucket <li> elements will need a  data-current=true or data-current=false depending on if it is selected, for a JavaScript enhancement on mobile.
[x] The sort by options will need to moved to a Django form, I've added a placeholder for now.
[ ] The grid view/list view icons (next to the "Sort by" component) will need URLs, and a python variable to determine wether the grid results or list result card HTML is rendered.
[ ] The “Show online records only” checkbox was missing in the filters so I’ve added a placeholder. I’m aware that this is a duplication of the “Online records from The National Archives” bucket, we will need to figure out from UX if this is staying
[ ] The filters were missing the “Date” (century) checkboxes, so I’ve added a placeholder
[ ] There needs to be a way for the labels inside a DynamicMultipleChoiceField to have a custom CSS class. This might be a bit complex but it would provide the benefit of the labels appearing clickable cursor wise, some small spacing adjustments, and helping us to be able to customise label css in the future.
[ ] No separate collection/topic filter pages are created at the moment. I’m aware that this is because only 10 collections are appearing for an asterisk search currently. However discovery displays around 100 collections for the same search so I'm assuming this will need to be created. I'm aware this is a bit of a complex backend task as the whole search state will need to be persisted via a query string.
[x] Missing the record opening date filter, so I’ve added a placeholder.
[ ] The held by will need to be hidden if we’re on the TNA records only search
[ ]
Result records will need a boolean to determine if they’re downloadable
[ ] Result records will need a 150x150 thumbnail if it’s downloadable
[ ] Result records will need the URL, catalogue reference, description, held by, and date available
[ ] The export results URL will need to work eventually
[ ]
Selected filters will need to show just above the results, with the links to remove the filters working
[ ] The search_results_hero.html <h2> will need to be populated with the current search type (Catalogue/Featured/Website results)

We're going to merge this PR to prevent merge conflicts down the line. The tasks above still need completion.

Thanks Ash!
As discussed, merging in to make merging a little smoother and for visibilty


Is this GEM compatible with Workplace bots for Messenger ? Please Help !!

Hi,
I am using this Ruby client code for FB messenger since months
One of my customer asked me to develop a bot on Workplace by Facebook.
Is it still possible to use this GEM ? Is is compatible with Workplace bots for Messenger ?
Here below the code error i got when i try to run my usual bot code ?
Thank you

Hello, @anthonyhamou  I am not familiar with the Workplace API. But by seeing the error, I am can say that this bot is not compatible with Workplace. There seems to be a difference in the request parameter of normal bot and Workplace bot request.

Yep, that seems about right. I've not put any effort into Workplace for this gem, because I haven't needed it, but your contributions are welcome if you do! :slightly_smiling_face:


support mobile NeRF

https://mobile-nerf.github.io/

Thanks for your suggestion, we are working on supporting Mobile-NeRF.

Thanks for your suggestion, we are working on supporting Mobile-NeRF.

Is it possible to use instant-ngp result in Mobile-NeRF

Thanks for your suggestion, we are working on supporting Mobile-NeRF.

Is there any progress on this?
I also want to make some contribution for the feature.

Thanks for your suggestion, we are working on supporting Mobile-NeRF.

Is there any progress on this? I also want to make some contribution for the feature.
We haven't finished the adaptation of mobile-NeRF yet. If you are interested, contributions are very welcome!

Thanks for your suggestion, we are working on supporting Mobile-NeRF.

Is there any progress on this? I also want to make some contribution for the feature.
We haven't finished the adaptation of mobile-NeRF yet. If you are interested, contributions are very welcome!

sure, which branch or PR should I take a look?


Use genders database populated from ansible groups

Switch the pdsh module to using the genders database instead of /etc/machines or /etc/dsh/GROUPNAME, and populate the genders database /etc/genders from the ansible groups.
This gives us easy ssh access to any ansible group via "pdsh -g groupname", and all nodes with "pdsh -a".
A few potential problems:

This is a change in behavior. Previously we populated /etc/machines with the ansible group pxe_bootable_nodes, and "pdsh -a" targeted only these nodes. Now "pdsh -a" will target ALL nodes. I think this is acceptable, provided we (I?) send an email to the fgci-tech list mentioning this.

The name of the role is a bit poor now that it no longer generates/uses /etc/machines.

Travis fails because it tries to cat /etc/machines - change that to /etc/genders and it should pass.
This sounds like a great update.
1.) This change leaves /etc/machines file lying around - could that cause problems? At least some confusion I think.. It's not possible with the template module to set state=absent :/
2.) I see three options: fork/create a new role (pdsh-genders?), rename the role (this could cause problems - like that the ansible-galaxy install roles command fails and then nothing works..) and finally do nothing.
3.) After this one can also remove my commented out attempt to do this without templating from the task file too.

As for renaming the role, yeah that sounds dangerous, I'd vote for a fork with a new name or doing nothing (no particular preference either way)

Looks better, thanks. If we do nothing I'd like add an option of using the old style /etc/machines.
ansible-role-pdsh-config would be a better name.

Well, personally I'm not much of a fan of endless options. I renamed my fork to ansible-role-genders, merged the genders branch to master there, and tagged v1.1.0. I'll follow-up with a patch to fgci-ansible/requirements.yml.

Agh, I hadn't pulled all the tags, so v1.1.0 already existed. Pushed v1.2.0 instead.

Closing this PR, see https://github.com/jabl/ansible-role-pdsh-genders/ if you want to use genders instead of machines.


Fixed #26001 - Handled '__exact' type in ModelAdmin.search_fields for integer

ticket : https://code.djangoproject.com/ticket/26001
reference

@sarahboyce have a look

can you squash this down to a single commit?

I can definitely squash the commits but when I attempt to rebase/reset, I see several other commits authored by different contributors, probably due to merging main into this branch.
If everything looks good, you can go with squash and merge.


[Feature]: speed up discovery, just discover selected tables

Feature scope
Taps (catalog, state, stream maps, etc.)
Description
I'm not sure if this is a capability of the SDK for database taps or not.
We were finding that the Discovery of Tables running in an ephemeral container deployment where you always have to discover not satisfactory when you have a large number of tables in the source system. On a particular database, this was taking 2-5 minutes due to the slowness of the Oracle Data Dictionary and the large number of tables.
We decided that we would add a feature to just discover selected tables i.e., tables set in the config or in the MELTANO __SELECT environment variable. If that config item was set, then the discovery was limited to just the selected tables. With that in place discover went from 2-5 minutes to a few seconds.
This was the particular change that we placed in pipelinewise-tap-oracle to support this feature.
https://github.com/s7clarke10/pipelinewise-tap-oracle/commit/d348c4e5f8d0ecac53e2cdb57585760df7fe230a
https://github.com/s7clarke10/pipelinewise-tap-oracle/commit/d545a7d37083bb505b91037e686fea32209c5dbd
Just sharing this idea as I believe it is a helpful feature.

+1 Ran into slow discovery with Snowflake too, which would benefit from this feature.

Duplicate of https://github.com/meltano/sdk/issues/1234


[1.14] GEODE-9758/GEODE-9980: Backport serial filter improvements to support/1.14

Backport #7217 (https://github.com/apache/geode/commit/7978abf34707d11da45cff0b7cb7445f18d21438) and #7299 (https://github.com/apache/geode/commit/ce57e9fd2b8b644cadc469209e12e4fbd281e0d9) to support/1.14.

I'm going to use "Rebase and merge" to maintain separate commits. I combined them into one PR just to minimize the number of PRs.

Thanks for choosing rebase-and-merge, that makes it way easier to keep track of the Jira's that need their fixed version updated


Defining blocks for column actions and inline add/edit buttons

defining blocks for column actions and inline add/edit buttons
these blocks can be overwritten and custom render can be used (change order, grouping of buttons, etc.)

@Spilky Could you rebase the branch and resolve conflicts, please?


Help me

Hello.
I can't make NLog work in my test project (winform).
Here is the config file:
<nlog xmlns="http://www.nlog-project.org/schemas/NLog.xsd"
      xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
      autoReload="true"
      internalLogLevel="Trace"
      internalLogFile="E:\travaille\Share\Server\WebStock\Log\log.txt">
  <targets>
    <target name="logfile" xsi:type="File" fileName="E:\travaille\Share\Server\WebStock\Log\logfile.txt"/>
   <rules>
        <logger name="*" minlevel="Info" writeTo="logfile" />
    </rules>
  </targets>
</nlog>

Code in C#
private static Logger logger = LogManager.GetCurrentClassLogger();
private void button1_Click(object sender, EventArgs e)
{
logger.Log(LogLevel.Info, "test me");
}
Result>
I do get  internal log file (log.txt), but i can't get logfile.txt
Sorry to create a issue, but i can't find the problem by myself:-(
Best regards
Zhiwei LIU

Please post the internal log :)

I find finally.
balise rules should be outside of targets.
I was stupide.


more synonyms & xrefs from EC for tRNA & rRNA pseudouridine synthases…

…, #15632

Yes, that is what I'm thinking we should do to clarify. In the meantime, maybe you should merge this so it doesn't get too far out of sync, and then if it needs to be changed it can be done after the Editors call?

Sounds like a good idea to merge sooner rather than later, so I'll go ahead and change the synonym that I thought maybe should also be EXACT to be that instead of NARROW, and then merge. If we decide as a group we shouldn't have multiple narrow xrefs, I'll take them out.


Prewiew action fail wit to many redirect

Description

run<EMAIL_ADDRESS>end with following error:
Traceback (most recent call last):
  File "napari-hub/backend/get_preview.py", line 17, in <module>
    get_plugin_preview(repo_pth, dest_pth, args.local, args.branch)
  File "/home/runner/work/PartSeg/PartSeg/napari-hub/backend/preview/preview.py", line 74, in get_plugin_preview
    get_pypi_date_meta(meta)
  File "/home/runner/work/PartSeg/PartSeg/napari-hub/backend/preview/preview.py", line 243, in get_pypi_date_meta
    pypi_info = get_plugin_pypi_metadata(name, version=None)
  File "/home/runner/work/PartSeg/PartSeg/napari-hub/backend/utils/pypi.py", line 57, in get_plugin_pypi_metadata
    response = requests.get(url)
  File "/opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/site-packages/requests/api.py", line 73, in get
    return request("get", url, params=params, **kwargs)
  File "/opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/site-packages/requests/api.py", line 59, in request
    return session.request(method=method, url=url, **kwargs)
  File "/opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/site-packages/requests/sessions.py", line 587, in request
    resp = self.send(prep, **send_kwargs)
  File "/opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/site-packages/requests/sessions.py", line 723, in send
    history = [resp for resp in gen]
  File "/opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/site-packages/requests/sessions.py", line 723, in <listcomp>
    history = [resp for resp in gen]
  File "/opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/site-packages/requests/sessions.py", line 191, in resolve_redirects
    raise TooManyRedirects(
requests.exceptions.TooManyRedirects: Exceeded 30 redirects.

Steps/Code to Reproduce

https://github.com/4DNucleome/PartSeg/runs/6829608548?check_suite_focus=true#step:3:630
Expected Results

working GitHub action
Actual Results

thanks @Czaki
any ideas @DragaDoncila ?

@Czaki I've struggled to reproduce this locally, even after thousands of calls to preview page build. Can you advise whether you're seeing this frequently on your PRs or if it's sporadic? It may be an issue with using requests in a GitHub Action but if it's very sporadic we may struggle to reproduce it.

I see 3 in last runs (and some solved by restart) https://github.com/4DNucleome/PartSeg/actions/workflows/plugin_preview.yml
Maybe some catch of error and retry after a few seconds?

@Czaki thanks for that added context. Yeah if you're seeing that frequently I think we should catch and retry, if we can't figure out how to stop it from happening.


Export to PDF

Just opening an issue about this feature. Do you know how to convert a WebkitView to PDF? I wasn't able to find how to achieve that.
Seems that we could use get_snapshot() (http://www.valadoc.org/#!api=webkit2gtk-4.0/WebKit.WebView.get_snapshot), but the pdf would be an image, not text.
Another approach would be to use the print function in WebkitView and automatically select the right printer (Print to file).
Any other ideas?

I was thinking of implementing the Gtk.PrintOperation for the html doc and use pango to render the html.
something similar to footnote
http://bazaar.launchpad.net/~elementary-apps/footnote/footnote/view/head:/src/Widgets/CustomPrint.vala

Seems a good idea :-)
I can make a PR with that if you want, or do you prefer doing that yourself?

I'm working on it

See #16

Fixed in #16 :-)


cve_check: Improve getting CVE status by cip-kernel-sec

Purpose of pull request
Get patched and unpatched CVE status by cip-kernel-sec to be able to get CVE information that is not taken from NVD database. Because if CPE is not set to NVD database, poky based CVE search feature cannot get CVE information from its database.
Note 1: Number of rejected CVEs are increased because following reasons.

cip-kernel-sec tracks REJECTED cves
CVE was not handled by cve-check feature because CPE was not set when cve was published

Note 2: Number of unpatched CVEs are decreased the reasons are

NVD database doesn't contain upper limit version. e.g. CVE-2023-6535
NVD database contains upper limit version but not contains upper limit version for 6.1 kernel. e.g. CVE-2024-36891

Test
How to test
Run cve_check.py for PR version and bookworm branch versions.
cve_check.py \
--image emlinux-image-base \
--output-format text,json

Test result
#!/usr/bin/env python3

import sys
import os.path
import pprint

def line_value(line):
    return line.split(":")[1].strip()

def parse_cvefile(cvefile):
    cves = {}

    with open(cvefile) as f:
        lines = f.readlines()
        cve = None
        cvssv3 = None
        status = None

        i = 0
        while True:
            if i >= len(lines):
                break
            line = lines[i]

            if line.startswith("CVE:"):
                cve = line_value(line)
            elif line.startswith("CVSS v3 BASE SCORE:"):
                cvssv3 = line_value(line)
            elif line.startswith("CVE STATUS:"):
                status = line_value(line)
            elif line.startswith("MORE INFORMATION:"):
                if not cve is None:
                    if not cve in cves:
                        cves[cve] = {
                            "CVE": cve,
                            "CVSSv3": cvssv3,
                            "STATUS": status,
                        }
                        cve = None
                        cvssv3 = None
                        status = None
                    else:
                        print(f"CVE {cve} is duplicated")
                        exit(1)

            i += 1

    return cves

def cve_summary(cves):
    patched = 0
    unpatched = 0
    rejected = 0
    unkown = 0

    for k in cves:
        status = cves[k]["STATUS"]
        if status == "Patched":
            patched += 1
        elif status == "Unpatched":
            unpatched += 1
        elif status == "Rejected":
            rejected += 1
        else:
            unkown += 1

    return patched, unpatched, rejected, unkown

def get_unpatched_cves(cves):
    ret = []

    for k in cves:
        if cves[k]["STATUS"] == "Unpatched":
            ret.append(k)

    return sorted(ret)

def main(cvefile_old, cvefile_new):
    old_cves = parse_cvefile(cvefile_old)
    new_cves = parse_cvefile(cvefile_new)

    old_patched, old_unpatched, old_rejected, old_unknown = cve_summary(old_cves)
    new_patched, new_unpatched, new_rejected, new_unknown = cve_summary(new_cves)

    print(f"{cvefile_old} cve-check result:")
    print(f"  Total CVEs: {len(old_cves)}")
    print(f"  patched: {old_patched}")
    print(f"  unpatched: {old_unpatched}")
    print(f"  rejected: {old_rejected}")
    print(f"  unknown status: {old_unknown}")
    print(f"{cvefile_new} cve-check result:")
    print(f"  Total CVEs: {len(new_cves)}")
    print(f"  patched: {new_patched}")
    print(f"  unpatched: {new_unpatched}")
    print(f"  rejected: {new_rejected}")
    print(f"  unknown status: {new_unknown}")

if __name__ == "__main__":
    if not len(sys.argv) == 3:
        print(f"Usage: {sys.argv[0]} <file> <file>")
        exit(1)

    main(sys.argv[1], sys.argv[2])

Run above script to check number of CVEs.
$ ./eml3-parse_cve_log.py linux-cip.bookworm linux-cip.new
linux-cip.bookworm cve-check result:
  Total CVEs: 3897
  patched: 3512
  unpatched: 375
  rejected: 10
  unknown status: 0
linux-cip.new cve-check result:
  Total CVEs: 6080
  patched: 5674
  unpatched: 287
  rejected: 119
  unknown status: 0

Thanks!


Fix arrow display on desktop web

Changes

Remove arrow button at opening section
The UI is broken after placing the getting started section to the opening:

Nowadays it is not that possible to display everything above the flow for desktop screen, some users will have to scroll the page in order to see the part of the content below. Therefore to me it makes sense to remove the arrow button.
Slightly decrease the size of logo and spacing

Checklist

[x] Read the contribution guide and accept the
code of conduct
[x] Readme (updated or not needed)
[x] Tests (added, updated or not needed)

Thanks for the improvement! LGTM


[Future] Java 17 missing

Is this request specific to one implementation of Sponge?
No
Sponge Version
all versions
What are you requesting?
Can you update to Java 17 please?

what exactly do you want "updated"?

I want use sponge or mixin with Java 17

with the minimal information you have given, this seems more like a support request. Come to our discord, or ask on our forums (both linked from the README) for further assistance.


fix readme typo

Thanks for submitting a PR! Please read these instructions carefully:

[X] Explain the motivation for making this change.
[ ] Provide a test plan demonstrating that the code is solid.
[X] Match the code formatting of the rest of the codebase.
[X] Target the main branch, NOT a "stable" branch.

Motivation (required)
Fix a typo in README.md
Test Plan (required)
N/A

:tada: This PR is included in version 5.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


How to make pipeline stage like 1/2/3/4 invisible？

HElP!
How to make pipeline stage in the red box invisible？ I mean all these 1234 stages.
I tried to add extra  RETIRE Instructions but was there any other way?'
thank you.

I am not sure how you want to display the pipeline.
If you want to retire the instructions there, you can use the "R" command.
If you want to end the stages there, you can use the "E" command.
https://github.com/shioyadan/Konata/blob/master/docs/kanata-log-format.md
If you can explain a little more, I might be able to help.

Thank you for your reply.
I want to to analyze the debug log by Kanata, which is similar to gem5 pipeline log.
Now I have to add extra R commands after each Stage, I want to let each Stage immediately (=after a cycle) retire.
I mean is there a way to do it without extra R command.
つまり、いちいちリタイアせずにすべての1や２のようなセルが見えるようにしたいです。
難しければ何もしなくても構わないです。

Thank you for your explanation. I probably understood your request. At this moment, there is no other way than to explicitly output the R command to retire an instruction.
It is technically possible to automatically close an instruction that has not been retired, but it could greatly increase the load of parsing. This is because it is impossible to know whether it has not yet been retired or it should be closed automatically, without reaching the end of a log.
I suppose that the reason for your request is that you do not want to complicate the structure by outputting R after waiting for one cycle (I assume some sort of buffer is needed). Is this right?
If this is right, I am considering adding a feature to output a command in the future after N cycles. With this feature, R can be output immediately just after the start of the last stage.

Thank you for your reply.
I tried to change the algorithm to achieve this effect, so I don't need to bother you to modify the program~
thank you.

By the way, do you use Konata for your own hardware design or simulator development?
If so, would you tell me about your design?
I am interested in how you and other people are using it.

My colleague use Konata to analyze Gem5 pipeline, and our project is to use Gem5 to simulate a chip (Kunpeng) that we developed ourselves.
My part is unified-bus, I use Konata to analyze the request pipeline for debug.

Thanks for sharing information about your project!
I am very happy that Konata is being used in the development of real products.
I hope Konata is useful in your development.

Konata is certainly useful, one of my colleagues who used to work for AMD for over 10 years is also using Konata!

That's great!
Conversely, a researcher in my lab moved to AMD a while ago, and I believe he is also using Konata.
Anyway, If you have any feature requests or find any bugs, please feel free to post them here again.
(As mentioned in another issue, it would be nice to have some kind of note-taking feature in Konata, but it has not been implemented yet.


Illegal character(pipe | ) in two schema names (twilio_api_v2010.yaml)

Schema name contain pipe( | ) character, which is not allowed.
API spec version 1.4.0 - twilio_api_v2010.yaml
line 868 - api.v2010.account.call.call_notification|instance:
line 2289 - api.v2010.account.notification|instance:
 api.v2010.account.call.call_notification|instance:
      properties:
        account_sid:
          maxLength: 34
          minLength: 34

api.v2010.account.notification|instance:
      properties:
        account_sid:
          maxLength: 34
          minLength: 34

@balucha
Thanks for brining this issue to our attention. This issue will be fixed with this PR.


Is there a way to issue flushdb from system command line?

Hi,
Is there a way to issue flushdb command from system command line or anyway that I could issue it from my program? It would be very helpful to cleanup the database during our auto unit test.
Thank you very much.

Use this command:
printf "7\nflushdb\n\n4\nping\n\n" | nc <IP_ADDRESS> 8888 -i 1

I tried it in my bash console, but I got this:
→ printf "7\nflushdb\n\n4\nping\n\n" | nc <IP_ADDRESS> 8888 -i 1
12
client_error
24
Unknown Command: flushdb

2
ok

Please upgrade your ssdb-server.

Hi, the script printf "7\nflushdb\n\n4\nping\n\n" | nc <IP_ADDRESS> 8888 -i 1 works fine earlier but seems it's not working with SSDB 1.9.4. Is there anything changed?


SwiftUI is now out of Beta 🎉

Linked Issue:

Checklist:

[x] Did you sign the Contributor License Agreement?
[x] Is the linter reporting 0 errors?
[x] Did you comply with our styleguide?
[x] Is there adequate test coverage for your new code?
[x] Does the CI pipeline pass?
[x] Did you update the documentation?
[x] Did you update the sample app?
[x] Do we need to increment the minor/major version?
[x] Have you done everything you can to make sure that errors that can occur are compile-time errors, and if they have to be runtime do you have adequate tests and documentation around those runtime errors? For more details.

Codecov Report

Merging #128 (603c90a) into main (e5150d4) will decrease coverage by 2.93%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
- Coverage   94.31%   91.38%   -2.94%
==========================================
  Files          77       81       +4
  Lines        1883     2101     +218
==========================================
+ Hits         1776     1920     +144
- Misses        107      181      +74

Impacted Files
Coverage Δ

...ftUI/Extensions/AnyWorkflowElementExtensions.swift
100.00% <ø> (ø)

...SwiftCurrent_SwiftUI/Views/NavigationWrapper.swift
100.00% <ø> (ø)

.../SwiftCurrent_SwiftUI/Views/WorkflowLauncher.swift
100.00% <ø> (ø)

...rent_UIKit/SwiftUIInterop/HostedWorkflowItem.swift
90.00% <ø> (ø)

...I/Extensions/SwiftUIFlowPersistenceAdditions.swift
33.33% <33.33%> (ø)

...tUIExample/SwiftUIExample/TestViews/TestView.swift
54.47% <54.47%> (ø)

...le/SwiftUIExample/TestViews/TestEnumerations.swift
86.84% <86.84%> (ø)

...ftUIExample/SwiftUIExample/SwiftUIExampleApp.swift
100.00% <100.00%> (ø)

Sources/SwiftCurrent/Models/Workflow.swift
100.00% <100.00%> (ø)

Sources/SwiftCurrent/Models/_WorkflowItem.swift
100.00% <100.00%> (ø)

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5f5c4a...603c90a. Read the comment docs.


Background images and Avatars on some actors not importing correctly

All the scenes I import are showing blank backgrounds despite the fact that the background image seems to be set to the right file. If I go into each scene and click on the background image, and select it again and hit save, it works. They are just initially blank. The same thing happens for some (but not all) avatar pictures for imported actors.

I encountered this as well. At least in my case the issue was that the image file pointed to what looked like the right place, but when I tried to browse to the folder, the image did not exist in that location. The world that it got installed to was called "undefined." Once I changed the path to the correct place, everything worked fine

Hello I encountered the same issue here and solve by manually moving the undefined/adventure directory to my world directory
Foundry version Foundryvtt 0.8.7
PF2 game system <IP_ADDRESS>21
Adventure-import-export : 0.6.0


Update documentation to mention new supported python versions

The docs say it supports 3.3, but it seems to build and run fine on 3.7 here on Fedora 30/31. So, could we update the docs and setup.py please to say so?

Sure, we should update the test matrix to ensure compatibility with newer versions (and perhaps drop some older ones).

Fixed by bd70754.


testing avx failure.

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.41%. Comparing base (20a76bf) to head (1d0344e).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #504   +/-   ##
=======================================
  Coverage   95.41%   95.41%
=======================================
  Files          58       58
  Lines        8903     8905    +2
  Branches     8903     8905    +2
=======================================
+ Hits         8495     8497    +2
  Misses        359      359
  Partials       49       49

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Long-touching navigation view item would cause the pressed backplate to stay

Describe the bug
Long touching navigation view item would cause the pressed backplate to stay. Only reproducible with touch. Cannot reproduce with right click.
Steps to reproduce the bug

Launch Xaml Control Gallery
Long touch any item until context menu shows up
Dismiss the menu.
Observe the backplate of the item pressed in (2) remained visible.

Expected behavior
The backplate disappear after user had lifted his finger from the navigation view item at (3).
Screenshots
https://user-images.githubusercontent.com/16918354/159270069-6114b012-22f6-481e-b019-5607d3ec1d4d.mp4
NuGet package version
No response
Windows app type

[X] UWP
[ ] Win32

Device form factor
Desktop
Windows version
Windows Insider Build (22579.1)
Additional context
XCG version is <IP_ADDRESS>. WinUI version is 2.8.0-prerelease.220118001 (The combo box in the bug report template doesn't have this release yet)

@chingucoding assigning to you. Thanks for taking a look!


Change License to Reflect Proper Authors

Hello, I am interested in leveraging the great work you folks have done here. However, the current MIT License appears to just be a copy of the one used for the AngularJS project and thus doesn't reflect that the copyright holders are the authors of the associated paper "Qiuqiang Kong, Yin Cao, Turab Iqbal, Yuxuan Wang, Wenwu Wang, Mark D. Plumbley". Updating this to would be greatly appreciated!

Hi seanytak, thanks for letting me know! The LICENSE.MIT has been updated!


Support ansible_private_key_file as well

Hi there, we received a report on https://github.com/ansible/molecule/issues/2069 about Molecule failing to make an SSH connection and after a quick glance over in https://github.com/ansible/molecule/issues/2069#issuecomment-496456638, I think I have a patch.
The short of it is, Ansible advertises that you can use both "ansible_ssh_private_key_file" and "ansible_private_key_file" for specifying SSH connection options and Molecule happens to use the "ansible_private_key_file" by default. The new Ansible runner implementation here in Testinfra (from what I can tell) does not pick this up.
Didn't dig too deeply on this but hopefully this goes in the right direction ...

CI failure appears to be unrelated.

Looks reasonable to handle both, Merged, thanks!

Thank you very much. I must now obligatorily beg you for a new release :)

Sure, It's in 3.0.5 ;)

<3


Must use Light theme.

It'd be good to note in the ReadMe that Firefox should be running the Light theme in order to match the preview. Using the Default theme produces unexpected results. Using the Dark theme however, it still looks amazing.
I also want too say this is fantastic! Thank you.

That's a good suggestion! I'm in the middle of a big overhaul which should improve compatibility with default/light/dark themes (and hopefully any other themes too). Most of the code base is being changed in some way so it might take a few more days. Thanks for the kind words :)

Resolved in 1ab209982a245ef8dca4bd7a2e15261c18daacf9.


Insertion Sort Visualiser

I would like to add a project which visualizes the insertion sort.

Please assign me this issue @ridsuteri @991rajat @Vishal-raj-1


Reactjs.org won't load due to lifecycle error

Hi,
I'm trying to access reactjs.org, but the page won't load because there's a lifecycle error for docsearch.
react-dom.production.min.js:187
ReferenceError: docsearch is not defined
    at t.componentDidMount (index.js:31)
    at commitLifeCycles (react-dom.production.min.js:169)
    at n (react-dom.production.min.js:180)
    at u (react-dom.production.min.js:183)
    at c (react-dom.production.min.js:184)
    at h (react-dom.production.min.js:188)
    at m (react-dom.production.min.js:187)
    at Object.updateContainer (react-dom.production.min.js:248)
    at react-dom.production.min.js:254
    at Object.unbatchedUpdates (react-dom.production.min.js:190)

Do you, by chance, have some sort of ad blocker (or other extension) that might be preventing docsearch from loading? I'm unable to reproduce the behavior you described when loading reactjs.org.

I suppose that's possible. You are correct, though. I can see the site fine on my work machine. Not sure why my home machine was having trouble. The page content would appear briefly (flashing in) before displaying a completely blank page. I'll have to check it again at home and see what else is up.
Thanks.

Thanks! Please let me know.
Also you may be interested in issues like #9 which should hopefully improve the UX for the worst case (total failure due to some kind of error).

This error:

ReferenceError: docsearch is not defined

was related to Fair Adblocker in the past.

I've also seen reports of that ^
We recently made some improvements in the UX when ad blockers prevent Babel from loading. (Now we still show the code samples, but instead of the compiled+running code we show an error message about ad blocker whitelists.)
I'm not sure what the UX fix for this is but we should at least handle it gracefully once #9 is resolved.


sonic-mgmt: wait for arp stuck on second test case

Wait for arp stuck on second test case
I find that snappi test cases always fail on second wait_for_arp run.
Besides that, snappi testcases can pass as expected.
Example snappi test case: snappi/pfc/test_pfc_pause_lossless_with_snappi.py

Not able to reproduce the issue in our setup, asked for a debugging session with Microsoft

During the debugging session, issue is seen only with one api_server and with other api_server the script run was fine. Asked Jianquan Ye to restart the api_server and check issue still persists.


CLOUDSTACK-8987 call s3xen/swiftxen plugins with their name

It's called s3xen, not s3xenserver. While investigating, I found the same issue for swiftxen.
Regresion from a8212d9ef458dd7ac64b021e6fa33fcf64b3cce0 where things were massively renamed, without proper verification.
Error seen:
2015-10-22 21:42:30,372 WARN  [c.c.h.x.r.CitrixResourceBase] (DirectAgent-261:ctx-862ebceb) callHostPlugin failed for cmd: s3 with args maxErrorRetry: 10, secretKey: +XGy4yPPbAH9AijYxFTr1yVCCiVQuSfXWWj1Invs,
connectionTtl: null, iSCSIFlag: false, maxSingleUploadSizeInBytes:<PHONE_NUMBER>, bucket: mccx-nl2, endPoint: s3.storage.acc.schubergphilis.com, filename: /var/run/sr-mount/9414f970-0afd-42db-972f-aa4743293430/2
cf0c24b-a596-4039-b50a-7ce87da4f273.vhd, accessKey: 16efbc4e870f24338141, socketTimeout: null, https: false, connectionTimeout: 300000, operation: put, key: snapshots/2/10/2cf0c24b-a596-4039-b50a-7ce87da4f273
.vhd, useTCPKeepAlive: null,  due to Task failed! Task record:                 uuid: 4be8a515-1e2a-59de-6301-029fb0326651
           nameLabel: Async.host.call_plugin
     nameDescription:
   allowedOperations: []
   currentOperations: {}
             created: Thu Oct 22 21:42:44 CEST 2015
            finished: Thu Oct 22 21:42:44 CEST 2015
              status: failure
          residentOn: com.xensource.xenapi.Host@9c7aad90
            progress: 1.0
                type: <none/>
              result:
           errorInfo: [XENAPI_MISSING_PLUGIN, s3xenserver]
         otherConfig: {}
           subtaskOf: com.xensource.xenapi.Task@aaf13f6f
            subtasks: []
Task failed! Task record:                 uuid: 4be8a515-1e2a-59de-6301-029fb0326651
           nameLabel: Async.host.call_plugin
     nameDescription:
   allowedOperations: []
   currentOperations: {}
             created: Thu Oct 22 21:42:44 CEST 2015
            finished: Thu Oct 22 21:42:44 CEST 2015
              status: failure
          residentOn: com.xensource.xenapi.Host@9c7aad90
            progress: 1.0
                type: <none/>
              result:
           errorInfo: [XENAPI_MISSING_PLUGIN, s3xenserver]
         otherConfig: {}
           subtaskOf: com.xensource.xenapi.Task@aaf13f6f
            subtasks: []

Here we see the correct name:
scripts/vm/hypervisor/xenserver/s3xen:lib.setup_logging("/var/log/cloud/s3xen.log")
scripts/vm/hypervisor/xenserver/xenserver56/patch:s3xen=..,0755,/etc/xapi.d/plugins
scripts/vm/hypervisor/xenserver/xenserver56fp1/patch:s3xen=..,0755,/etc/xapi.d/plugins
scripts/vm/hypervisor/xenserver/xenserver60/patch:s3xen=..,0755,/etc/xapi.d/plugins
scripts/vm/hypervisor/xenserver/xenserver62/patch:s3xen=..,0755,/etc/xapi.d/plugins
scripts/vm/hypervisor/xenserver/xenserver65/patch:s3xen=..,0755,/etc/xapi.d/plugins

And:
scripts/vm/hypervisor/xenserver/xenserver56/patch:swiftxen=..,0755,/etc/xapi.d/plugins
scripts/vm/hypervisor/xenserver/xenserver56fp1/patch:swiftxen=..,0755,/etc/xapi.d/plugins
scripts/vm/hypervisor/xenserver/xenserver60/patch:swiftxen=..,0755,/etc/xapi.d/plugins
scripts/vm/hypervisor/xenserver/xenserver62/patch:swiftxen=..,0755,/etc/xapi.d/plugins
scripts/vm/hypervisor/xenserver/xenserver65/patch:swiftxen=..,0755,/etc/xapi.d/plugins

These plugins are pushed to the hypervisor.
Finally, s3xen logrotate wasn't setup properly as the logfile was missing .log.
Build succeeds:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 6:27.763s
[INFO] Finished at: Fri Oct 23 09:08:14 GMT 2015
[INFO] Final Memory: 92M/415M
[INFO] ------------------------------------------------------------------------
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building Apache CloudStack Developer Mode 4.6.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------

After this, S3 works as expected on XenServer. Couldn't test swift but it's the same issue. Pinging @pdion891 to have look at swift.

Verified this is also broken in 4.5 btw.

Based on code review, LGTM :+1:
I haven't spun up a cluster to run integration tests...

@borisroman Thanks, will ask @wilderrodrigues to run some integration tests.

@remibergsma @wilderrodrigues  Thanks!

@remibergsma  @borisroman  - I'm starting tests now.

Code look good to me, no rocket science involved.
I will test it with XenServer 6.5, but I might need help figuring out how to get it covered.
Cheers,
Wilder

Since a8212d9 changed names from "xen" to "xenserver", shouldn't the change be to rename the files s3xen to s3xenserver and swiftxen to swiftxenserver in scripts/vm/hypervisor/xenserver/?

Ping @runseb.
Is there a handle/userid for Tim Mackey?

Good point, @koushik-das.
@remibergsma: do you agree on that one as well?

@koushik-das One of the goals of a8212d9ef458dd7ac64b021e6fa33fcf64b3cce0 was to ensure that we have clarity in which hypervisor we support since Xen != XenServer.  Reverting based on name IMO might be the simple solution, but could ultimately cause additional confusion as we don't currently have a pure Xen hypervisor implementation.
@wilderrodrigues @remibergsma, I didn't have s3 or swift storage to test with at the time of my changes. Would not the better solution be to rename the plugin s3xenserver and swiftxenserver?

I will test if renaming the plugin works (and make sure there are no links to its name).

New PR #982


cue.Value.Attribute only handles FieldAttr

A bit of an inconsistency with the cue.Value.Attribute(s) API

Attribute only processes FieldAttr
Attributes takes an arg to specify

I was trying to lookup an attr by key, but found none because it is a DeclAttr

@verdverm - please can you provide an example of what you were trying to do here, but couldn't?

@myitcv I've updated the description with the reproducer I forgot to add

I think the issue title is clear, and it is true that Value.Attribute() only returns field attributes and not struct attributes.
But I don't understand the example/reproducer and the issue description, and the example doesn't call the Attribute method for a value with a struct attribute. In the example, the root value has no attributes. I guess the root can't really have field attributes. It can have struct attributes, but in the example it does not. So to me this explains why the first call to Attributes returns the empty list. I think some confusion may be because the Value.Attribute(key) method always returns an attribute and never an error even if there is no attribute for the key, so val.Attribute("whatever") will always succeed. So the calls to val.Attribute("field") val.Attribute("decl") in the example are for a value (root) that does not have any attributes "field" and "decl" (the method still returns non nil *Attribute, and these print as "@field()" and "@decl()"). The second level, the value under "a" has these attributes, so the second call to Attributes() returns these. The example never calls Attribute() on this value under "a".
Amending the example input to actually have some data in the attributes makes it a bit easier to see what's going on:
var input = `
a: {
        @decl(foo)
        val: _
} @field(bar)
`

Gives the output:
a: {
        val: _
}
d: @decl()
f: @field()
len: 0
len: 2
A[0]: @field(bar)
A[1]: @decl(foo)

The first two attribute lookups are not on a. And top-level doesn't have attributes, so I don't see how this is wrong. Anyway, some upcoming attribute changes might help if you are nonetheless seeing issues.


deprecate meshery/homebrew-tap

Signed-off-by: Nishant Mittal<EMAIL_ADDRESS>Description
This PR fixes https://github.com/meshery/meshery/issues/5921
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

@nishantwrp you had a good call out on today's Meshery Dev call regarding future semver compatibility consideration. If there isn't an open issue on this, please do open one to track the item.

@leecalcote done, https://github.com/meshery/meshery/issues/6480.


Update populatedb with checkout with custom prices

Extend populate db with checkout with custom prices.

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-6089 Custom prices when adding items to checkout

Task linked: SALEOR-6192 Update populatedb


[Performance Reporter] Update the webtool to also accept the new workbook tab names

As of version 08152022,

Project Data is now Project Information
Participant Data is now Performance Information

These were changed as the old names were causing misunderstandings with partners as we demo'd.
The DOCX file created with these new names comes out as corrupted.
I've updated the Version tab to 1.1

20220815_ARPA_Annual_Performance_Report_Workbook.xlsx


Blog post image file placement

Since Obsidian and Astro how different ways to load images and I don't want to update my Obsidian vault to match Astro style, investigate ways to automatically place blog post images inside the public/images directory.
One possible idea is inspired by Rach Smith's Automating the process for moving notes from my Obsidian vault to my Astro site.

After further investigation, I've found that Astro supports placing images in the same folder as the markdown file we're trying to turn into webpage. More specifically, Astro supports using images in content collections.
General workflow now looks like this:

You create a folder called 03 for example.
Inside that folder you write your blog post and place all the images used in the blog post in that very same folder.
You reference each picture using relative links, for example: ./picture.png.
After you're finished you simply copy the whole folder (with the post and images) and paste it into src/content/blog folder inside the repository.


Update schedule.csv

Added a slot for the benchmark presentation to the schedule which is displayed on the website.

done


RSA Signature with Azure Key cannot be verified by .NET 4.8, but working with .NET 6

Hello,
Our architecture is like that :

Web Application .NET 6 (License generator)
.NET Standard dll (Licensing generator)
Web Application ASP.NET MVC 4.7.2 (Distributed application)
.NET Standard dll (Licensing validator)

So we have a solution that contains all work to manage Licensing. We generate two nuget package for the two dlls, then we add package to both applications.
The .NET 6 Web Application references both dll generator and validator
Our ASP.NET MVC 4.7.2 distributed application references only the dll validator
The byte[] license generated by .NET 6 is signed with Azure Key Vault key 4096 bits:
CryptographyClient.SignData(SignatureAlgorithm.PS512...
The dll validator make this operation :
           using (var rsa = RSA.Create())             {                 rsa.FromXmlString(LicensePublicKeyXml);                 return rsa.VerifyData(license.ToBytes(), license.Signature, HashAlgorithmName.SHA512, RSASignaturePadding.Pss);             }
This code is working well if I use a console application .NET 6, but not with a console application .NET Framework 4.7.2 or 4.8 :
System.Security.Cryptography.CryptographicException: 'Specified padding mode is not valid for this algorithm.'
For both console applications I use the same license byte[]
Can anyone can explain why it is not working in .NET 4.7.2 or 4.8 ?
Thank you !

RSA.Create() on .NET Framework will use RSACryptoServiceProvider as the underlying implementation which doesn't support this mode: https://stackoverflow.com/questions/45696437/net-rsa-sign-data-error-with-pss-padding
It looks like if you pass a key size e.g. RSA.Create(4096) then .NET Framework will use RsaCng underneath which supports that mode.

Thank you for your answer akoeplinger !
RSA.Create(4096) is not a valid construction in .NET Standard.
But, I change implementation to use RSACng and now it is working well.
Thank you again !


Apply pad four to yyyy

Fix issue #39.

pls someone merge this...

@kmdtmyk  Thanks so much for creating this PR.
Sorry this never got merged.
Because of merge conflicts I am closing this PR.
But I have made these changes again in a new PR #139.
FYI: @rekhubs


Pagination Misalignment &  Responsiveness

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
User search pagination misalignment & it was not responsive
Steps To Reproduce
click on search
select users
scroll down to the pagination
Expected Behavior
fix alignment & responsiveness
Screenshots

Device Information [optional]
- OS:Windows
- Browser: firefox
- version:119.0.1

Additional context
No response
Are you working on this issue?
Yes

Hi @Malavi1 , I believe #4234 addresses this issue .

Yeah @shauryag2002  I overlooked IG!
So, While fixing the issue consider centring the pagination in the laptop screen size meanwhile it also fixes.

Hey, I would like to work on this issue, pls assign this issue @Malavi1


Separate download site for istioctl

Describe the feature request
Just like kubectl has, it would be great to have a simple curl to get the istioctl binar]y and not have to dig thru the installation files to get it.
For example, kubectl has this type of curl:
curl -o /usr/local/bin/kubectl --create-dirs --retry 5 -LO https://storage.googleapis.com/kubernetes-release/release/v${kubectl_version}/bin/linux/amd64/kubectl \
 && chmod +x /usr/local/bin/kubectl

which is very handy to use in Jobs and Dockerfiles....
Describe alternatives you've considered
Additional context

@linsun cc

Would be great to have it homebrewed on Mac ;-)

@kramvan1 good point!
@ibm-jason can you look into this to see if we can host istioctl for 1.1 somewhere in our GitHub?
pre daily release: https://gcsweb.istio.io/gcs/istio-prerelease/daily-build/release-1.1-20190203-09-16/
released binary:   e.g.
https://github.com/istio/istio/releases/download/1.1.0-snapshot.5/istio-1.1.0-snapshot.5-linux.tar.gz

@linsun Yes, I'll have a look. 👍

@linsun here is something that we could try:
Using the RAW URL link to the file as it is hosted on GitHub, we can create subfolders to host the binary files right inside the repository itself. For example, https://raw.githubusercontent.com/istio/istio/master/istioctl/OWNERS is the download link to retrieve the OWNERS file from istio/istio. If we create a releases/ subfolder in the istio/istioctl directory, and give Istio users the RAW URL link to the file, the binary could be accessed via curl.
Let me know if this approach is feasible, and I can prepare a PR for it.

@ibm-jason are you proposing to check in the binary to github?  If so, I would prefer not to do it.  It should be created as part of the release archive process imho but serve it as an individual item for downloading.

Apparently we do have istioctl homebrew (currently v1.0.5).
Contributed by @murarisumit

Thank you @ymesika!
@ibm-jason could you ensure the istioctl homebrew is properly doced in istio.io?

@linsun great idea, and yes, I'll make sure that it is properly documented.

/assign @ibm-jason

@ymesika: GitHub didn't allow me to assign the following users: ibm-jason.
Note that only istio members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @ibm-jason

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ibm-jason ^^^
It's time to become an Istio member..

@ymesika Perhaps you are right! :-)

@ibm-jason @linsun @ymesika I see this ISTIOCTL_URL floating around git hub, and it's also in the
https://github.com/istio/istio/blob/master/tests/e2e_istio_preinstalled.sh (which I'm trying to make work)
curl https://storage.googleapis.com/istio-artifacts/pilot/$TAG/artifacts/istioctl/istioctl-osx -o istioctl
and similar for istioctl-linux and istioctl-win.exe
So, it appears to already be there.    I don't know what other TAGs are out there besides latest.  would this be good enough for this issue, just doc how to use this URL

@linsun Circling back around on this issue. At this point, we're just finding a place to document how to separately download istioctl, including the brew install process?

Right - is there a reliable URL we can use to download the istioctl binary for any release? If so, let's create a istio.io issue to doc it, and close this one

There isn't as far as i know as part of the release.  Can we do something simply like what is being discussed in https://github.com/istio/istio/pull/11710#issuecomment-479108038 where we append an option in our download istio script to download istioctl only?
We need 1 single cmd to download this thing regardless of platform.

@linsun, @rvennam
I talked with @utka about the following approach:

We can use the curl command to download istioctl separately, but it requires knowing the commit SHA for the release that you want to download:
curl https://storage.googleapis.com/istio-artifacts/pilot/$TAG/artifacts/istioctl/istioctl-osx -o istioctl

$TAG in this case references a commit SHA, and from a UX perspective, having to know what SHA you need to download the version you want isn't user friendly.

Came up with the idea of using the same mechanism that publishes the artifacts to also publish a version where $TAG can be equal to the release version.  For example:

https://storage.googleapis.com/istio-artifacts/0961ac4a24d7bb0cd85612099a347e3b2d616946/artifacts/istioctl/istioctl-osx
This URL will give us the version of istioctl that was pushed when 0961ac4 was the HEAD commit (I'm guessing). What I'm proposing is the following:
https://storage.googleapis.com/istio-artifacts/1.1.2/artifacts/istioctl/istioctl-osx

We found where this is happening in the Makefile:

https://github.com/istio/istio/blob/fd96ebf6b28b707b825edbc60f992b1c720e3b60/Makefile#L613
We have the option of adding a new make target or adding a step in the gcs.push.istioctl-all: istioctl-all target that (in addition to the commit SHA version) pushes a version that simply has the release number in it.
I'll go with whichever approach is best, but @utka agrees that this could work.

Thanks @ibm-jason !  can we please not expose platform for users?  I'd rather we handle it automatically, like curl -L https://git.io/getLatestIstio does.
Can we have something like curl -L https://git.io/getLatestIstioctl to allow users to download istioctl, with the ability to optionally specify the version, e.g. ISTIO_VERSION=1.1.2?

@linsun Yes, it makes sense not to directly expose the commit SHAs and platform to the user for this solution.
To answer your question, I think we can follow the same pattern as the /getLatestIstio URL. IIUC, /getLatestistio basically points to https://github.com/istio/istio/blob/master/release/downloadIstioCandidate.sh, which takes care of figuring out the platform and the appropriate version to download. I still think what we've proposed above is a good addition, we simply wrap it around a download script like the downloadIstioCandidate.sh script to somewhat obfuscate the logic.

SG thanks @ibm-jason !

Think this is mostly done however we need cmd and script to download istioctl, and update doc as needed.  Re-assign to @irisdingbj to pick it up from @ibm-jason.

Done #16922


Update datashape.rst

Link to latest version of datashape docs. Old link was to docs for version 0.2 of datashape.

Thanks!


[BUG] Conversion above 100%

When picking Physical to Lightning on a Wild Strike build the 50% Physical converted to Lightning is treated like added damage, instead of squishing the 150% conversion down to 100% so the build should have 33% Lightning and 67% of whatever element procced.

This is an interesting case; the behaviour you're seeing may actually be intended, or could reflect a bug in the game, or it could be a bug in PoB...
As you are aware, conversions over 100% normally get scaled down; you may also be aware that skill conversions (such as that from Wild Strike or Physical to Lightning) always have priority over global conversions (from passives and items).
But what happens if the skill conversions themselves exceed 100%? Well, in theory they should be scaled down to 100%; however, and I don't know if this is intended or not, they currently do not get scaled at all! You can verify this in-game if you have a character that has no elemental damage bonuses, using Molten Strike and a level 1 Physical to Lightning; with just the Molten Strike you'll see 60% of the physical as fire, and when you add PtoL you get 60% as fire and 60% as lightning (50% converted, 10% added).
Nevertheless, PoB's behaviour might not be correct for Wild Strike, due to another issue with the game. Some skills incorrectly use global conversion instead of skill conversion; Burning Arrow and Frost Blades are two examples. But Wild Strike's conversion isn't in the game data (as far as I can tell), so I don't know whether it uses the correct type. Once the patch arrives I can test that though, since the conversion went up to 100%.

I've checked now, and Wild Strike uses global conversion; so I'll fix that in the next update.


Deep links process as a separate module/standalone CLI?

Short description of the problem:
I'm currently trying to integrate ionic with angular-cli, as  I find the ionic CLI lacking on many points.
One of the limitations I have discovered is that the @ionicPages decorator rely on a specific ionic CLI postprocessing script that can be found here, to generate the deep links.
What behavior are you expecting?
Would you consider extracting the deep links scripts in a separate package so it can be integrated with other build systems? A standalone CLI would be even better to allow us to perform this task using only npm scripts.
At least, it could be nice to have some documentation on what it does, so if you don't have the time to extract the code I can try to implement it.
Thanks for considering this.
EDIT: As a bonus, I'm just wondering: why using a build step for this instead of implementing the deep link generation directly in the @ionicPages annotation?

Hello, thanks for using Ionic. At this time because deeplinks and @ionicPages are so tied into our cli we do not plan on splitting it out anytime soon. Also, at this time we do not currently provide official support for using the Angular cli to build Ionic apps.


Change find method to dispatch

Change find method to dispatch because find is deprecated.

$page->find() is not deprecated, it's used quite a bit

In the method header @deprecated it's called, i see from this, so sorry.


Action Add users to workspace: Cannot add multiple users to a new workspace

Hi,
Unfortunately I cannot add multiple users as an Admin to a new created workspace. One user is fine, but when I try to add multiple it doesn't work.
The image below shows the configuration of the PowerBI task.

According the additional information a comma ',' should separate the emails. Is that right?
The error message in the log says that a user is not found. However if I place that user in the first position it is found.

Hi BobJMW,
I had the same problem and I fix this with delete the space after every comma.
There should not be a single space between email

@AmandineYborra: thanks for your help. Will try to get this out of the extension. @BobJMW do you maybe have the log for me to see what is going wrong.

@maikvandergaag please find the log files attached. Hopefully they help you solving the issue
ReleaseLog.zip

@BobJMW:
Could you remove the space, and if it does not work add the system.debug variable with the value true to the pipeline and send met a screenshot of the configuration and the log.


:candy:  Removing duplicate files and using hooks/build to get tag

I saw that we currently have multiple folders with same content except a change in tag name. It might get harder to manage/change all these files with more nodejs versions to be supported in future.
I did some research and found that hooks can be utilized to eliminate such scenarios.
I have tested this in below project with same code
https://github.com/prashanthmadi/appservice-nodejs
Dockerhub build with multiple tags using above Github project https://hub.docker.com/r/prashanthmadi/appservice-nodejs/
Let me know if it requires more changes.

With the existing approach, i'm using sed to replace tag as dockerhub uses 15.03 and doesn't support using image_tag in FROM directly.
using image_tag in FROM would be supported from >15.05

Any update on this ?

Replaced by templates https://github.com/Azure-App-Service/node-template and https://github.com/patricklee2/appsvcbuild


Multipart support

Closes #4
Closes #143
Closes #160

Nice, thanks for finishing it.

I see the multipart is marked to "TODO" in Documentation, when would this commit will be released?


remove_remote_layer_ongoing: duplicate l1 handling

With the new Layer implementation there is a problem that the Layer knows it's metadata, so replacement needs to be restored a bit, otherwise the old layer would never accept the new file as being downloaded.
Additionally noticed that as I want to remove layer_removal_cs and upload waiting then overwritten duplicate layer can get overwritten again by on-demand download:

compact_level0_phase1: overwrites out the duplicates
someone else on-demand downloads a now overwritten layer, overwriting the overwritten with old version
schedule uploads for the supposedly new Layer, but we no longer have it

The solution is to ensure all overlapping L1s are resident before we attempt at creating any layers. The search is currently O(n) for no reason, and probably wrong as well.

First commit should had been pushed to the branch already.

Now looking at the duplicate_layers test even though I approved it I don't really understand why does it work like that, or only work like that. I think I'll need to add another, but still, there's no need to wait for compaction to run on timer, it could be manually executed after the pgbench -i -s1...

Both of the alternatives suffer from the fact that the renamed file has a Layer. Because they have a Layer, it can have DownloadedLayer and within that OnceCell<LayerKind> which holds a VirtualFile which can be opened or closed.
We cannot make OnceCell<LayerKind> a Mutex<OnceCell<LayerKind>> which would allow us to use take() because then the borrow-trick with DeltaEntry would not work anymore, and the asyncification of the read path relies on that or would at least require rework. Original trick of DeltaEntry containing an Arc<_> wouldn't work either, unless we had a ... third Arc'd step for this? Seems excessive, and it would still be an Arc, so we cannot have a &mut.
(Supporting mutable immutable files is tricky.)
Feasible ways of handling renaming of the "overridden file" before renaming the new layers into place:

evicting and waiting for it (probably fine) then either

block downloads and initializing, or poison
switch that file to using an alternative path

fake-evicting (renaming to an alternative path) and waiting

this would be crash safe because we still have the replaced layer in index_part.json until we schedule the overPUT and level0 deletes

Feels like even evict_and_wait + poison would probably be fine, because at least we are not giving out wrong responses but some queries, but it's hard to say that it's okay for this query to fail. Not that these problems would ever happen.
fake-evict_and_wait (rename, toggle bit "alternative path suffix") is the safest. After that, the file could manage the renamed path normally, BUT they can never schedule a deletion.
As far as implementation goes, I think they are similarly difficult. Both need to happen with a dropguard so they get undo in case we run into a failpoint later. With poisoning this feels very weird. It would be "poisoned" for a short while ... Does not make any sense.

Most likely abandoning this effort in favor of just making the duplicate L1 disappear via #5086.


Regenerate assets and update snapshots

WHY
#183 's changes are missed...

Codecov Report

Merging #184 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #184   +/-   ##
=======================================
  Coverage   61.57%   61.57%
=======================================
  Files          39       39
  Lines        1395     1395
=======================================
  Hits          859      859
  Misses        476      476
  Partials       60       60

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 936d555...cffd7dd. Read the comment docs.


Remove misleading note about dotnet 1.0.1

I found the note regarding the dotnet CLI version misleading. I initially had compile errors due to an unrelated issue and spent a good chunk of time trying to ensure the dotnet cli 1.0.0 was installed. On a clean VM, after start-psbootstrap running dotnet produces:
PS C:\dev\powershell> dotnet

Microsoft .NET Core Shared Framework Host

  Version  : 1.0.1
  Build    : cee57bf6c981237d80aa1631cfe83cb9ba329f12

So I thought this may have been my issue but it actually was not and once I worked out my real issue, this version worked fine.

Please resolve all merge conflicts.  For more information see GitHowTo - 30. Resolving Conflicts

sure @TravisEz13. I am closing here and recreated in #2030 since I had to whack my original forked repo.

@mwrock  Thanks


Volume Mounts in Script Step

Is this a BUG REPORT or FEATURE REQUEST?:
Bug Report ? I don't know
What happened:
Pod "tefde-vajont-test-argo-2763208270" is invalid: spec.containers[0].volumeMounts[0].name: Not found: "volumeName"

What you expected to happen: The volume is mounted correctly in my container
How to reproduce it (as minimally and precisely as possible):
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  name: argo
  namespace: namespace
  generateName: k6-workflow
spec:
  serviceAccountName: argo
  entrypoint: k6test
  volumes:
  - name: volumeName
    secret:
      secretName: secret
  templates:
  - name: k6test
    steps:
    - - name: step1
        template: step1
  - name: step1
    script:
      volumeMounts:
      - name: volumeName
        mountPath: /path/something
      image: image/something
      command: [bash]
      source: |
           something

Environment:

Argo version: 2.1.0

Kubernetes version : 1.8.10

Might be a bug with volumes + script templates. Will take a look.

Here is a workaround:
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: input-artifact-raw-
spec:
  entrypoint: raw-contents
  templates:
  - name: raw-contents
    inputs:
      artifacts:
      - name: myfile
        path: /tmp/file
        raw:
          data: |
            this is
            the raw file
            contents
    container:
      image: python:3.7
      command: [sh, -c]
      args: ["python /tmp/file > /tmp/output"]
  outputs:
    parameters:
    - name: my-output
      valueFrom:
          path: /tmp/output

Hi, I'm seeing exactly the same issue - was this bug fixed?


Reduce load statement usage

At the validator class all useless and duplicate statements get remove to reduce the amount of statements the VM need to take after compile. In a while loop when you add 1 to the same variable it will always load that variable but its enough to load it one time, keep in mind that it should detect if there is another variable loaded after that, then u cant reduce the load or it will break the logic

Hello,
I would like try to work on this issue, but beforehand question (for clarification) :
Given that in the Validator class ( Slirik/Compiler/src/core/Validator.java ) a queue is used to hold the statements passed to it then keeping the order must be important - please confirm if otherwise.
With that being given, I think it might be possible to create our own class (maybe UniqueQueue ) that only holds unique values and use an instance of that object in the validator class, not sure if you are strict about using only built in java classes but this could help - say in the future you want xyz behavior to be added.
Thanks for the feedback

keeping the order must be important

As long as the logic stay same the order can be changed by a bit

With that being given, I think it might be possible to create our own class (maybe UniqueQueue ) that only holds unique values and use an instance of that object in the validator class, not sure if you are strict about using only built in java classes but this could help - say in the future you want xyz behavior to be added.

You can use any method you want as long its readable and not take way to much time to complete the compilation


HTTP_X_FORWARDED_PROTO is not always set

We cannot assume HTTP_X_FORWARDED_PROTO is set by default. Also add an
isset check before using it.
Signed-off-by: BlackEagle<EMAIL_ADDRESS>

:+1:


Support Hiera lookup() in plans outside of apply blocks

This is a duplication of a closed issue on the old ticket management:
https://tickets.puppetlabs.com/browse/BOLT-836
Feature Request
It would be handy to support the hiera lookup() function within a plan.
Open Question
What goes into the hierarchy for a plan? Without facter how are those values set?
Usecases
Lookup different values to use the same plan in different environments or contexts
As a plan author i need to store data about how to execute the plan that may be environment or deployment specific. These settings would be looked up from the "perspective" of the bolt controller node. Example: may need different API keys, credentials, etc to use for API calls. Example 2: may be deploying in a different manner based on a setting in a config that is easy to switch.
Use hiera to lookup task parameters for different targets
As a plan author i need to perform actions differently depending on certain facts and/or attributes of a node. These facts may be gather by the facts task. From these facts/attributes i then need to lookup() data to determine how the action should be run.  These facts would be looked up from the "perspective" of specific targets. Example: I'm deploying a software pacakge against a variety of hosts, some may be 32-bit some 64-bit. I need to deploy different versions of software to the 32-bit systems. I would run a 'facts' task to determine architecture, then choose which software package to copy and install. The data hierarchy would be used to uniquely specify which software package to utilize.
Learning from spike

currently just exposing hiera allows backends to work without interpolation as long as all interpolation is based on $facts and $trusted. The fact that those are set during plan execution feels wrong and may be a bug.
We probably need the ability for users to specify a separate hiearchy for the plan level so we don't limit interpolation options.
There is value in exposing backends so that hiera-eyaml can be used but this problem may be solved by supporting eyaml in inventory.

h1 Questions for commentors

What levels of heirarchy would you use at the plan level?
Would there be any fact like interpolations in the hierarchy? What values would be used.
Do you expect values from plan level data to be automatically set anywhere with data bindings like classes in manifests.

And a copied comment from Henrik Lindberg:
Some thoughts about implementation...
One thing to consider here is that switching "perpective" (bolt controller, each node) using a single hiera instance will lead to its cache being evicted on each switch. This would potentially be quite bad for performance if many such switches are required as a bolt run progresses. Imagine looping over a set of nodes and in each iteration some plan specific, and some node specific value needs to be obtained.
From a UX perspective everything could be hidden unless it should be possible to lookup node specific values in a plan. For that, it must be possible to use a different perspective. This could be another function for example (lookup_for_node()), or a method on a node/target.
When designing the "perpectives", a big question is if it should be possible to override a node perspective in the plan perspective. If not, it may be possible to have one hiera/lookup-context per node in memory if performance is bad using switching of the set of values used to determine the paths in the hierarchy. Maybe it is possible to make hiera switch between named (i.e. "perspective specific") caches in an effective way.
It seems like a design with one hierarchy for the plan perspective, and one for all node specific perspectives would be best, and if override of node perspective is needed in plan perspective, then that can be done manually in the plan's logic.

Without interpolations I'm not sure there is much value in exposing hiera instead of just loading data from a specific source or accepting it as a plan parameter(to allow users to inject their own sources). The new resolve_reference method should allow you to load encrypted values directly in the plan without trying to fit them into inventory.
We explicitly removed $facts from the scope of a plan and I don't think supporting hierarchies based on the facts of the controller is particularly useful.
How would you like to set values for interpolation in the plan hierarchy?

I use Bolt in conjunction with Puppet's control-repo - meaning, a lot of my options are stored in hiera.
I have a plan, with multiple tasks, that need access to an internal API, with a username and password, that is already stored in heira.
I want heira to be the single source of truth--e.g. I don't want to specify it any other place, since it would leave maintenance overhead, that should not be there.
In my plan, I basically want to have this:
plan base::patch (
  TargetSpec $nodes,
  String     $api_username = lookup('profile::monitoring::api_username', String, 'first', 'admin'),
  String     $api_password = lookup('profile::monitoring::api_password', String, 'first', 'wrong_password'),
) {
  [...]
}

I'm looking for similar functionality but from within the inventory.yaml file so usernames/passwords for targets can extracted from hiera data in the control repo before a plan even starts.

+1

I wanted to look up a password stored in a hiera .eyaml file, and had to resort to this monstrosity:
$puppet_master = puppetdb_query(
  'resources[certname] { type = "Class" and title = "Puppet_enterprise::Profile::Master" }'
).map |$r| {
  $r['certname']
}
$val = run_command("/opt/puppetlabs/bin/puppet lookup ${key}", $puppet_master).first.value['stdout']

This work - specifically https://tickets.puppetlabs.com/browse/PUP-10397 - causes this simple usage of the Puppet::Pal package to fail
Puppet::Pal.in_tmp_environment("test", :modulepath => ["/tmp/puppet/modules"], :facts => facts) do |env|
  env.with_script_compiler do |compiler|
    compiler.evaluate_string("notice $facts")
  end
end

The Pal documentation has no hints of this happening :
https://github.com/puppetlabs/puppet/blob/464591cfe58dd18a874590dd8e973f8ba6fbc555/lib/puppet/pal/pal_impl.rb#L201-L210
This seems to violate semver rules.


Disable flaky model test in CUDA build

tf_inception_v1 is failing randomly on GPU builds (on both agents). This is preventing PRs from being merged. Disabling the model test for now, pending investigation later.
From build history - PRs #916 #924 #806 #716 all exhibited this

Please create a task to track this so that we don't forget to re-enable this test. Thx!

Please create a task to track this so that we don't forget to re-enable this test. Thx!

Done.


chore: update development dependencies

:tada: This PR is included in version 1.4.10 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Add support for customizing font fallback

This adds support for specifying more than one font family using a
syntax that is similar to CSS' font-family property.
The implementation is straight-forward and is effectively
just a wrapper around IDWriteFontFallbackBuilder.
Closes #2664
PR Checklist

Font fallback

Write "「猫」"
Use "Consolas" and remember the shape of the glyphs
Use "Consolas, MS Gothic" and check that it changed ✅

Settings UI autocompletion

It completes ✅
It filters ✅
It recognizes commas and starts a new name ✅

All invalid font names are listed in the warning message ✅

This doesn't seem to work?
I'm configuring it as follows:
 "profiles":
    {
        "defaults":
        {
            "colorScheme": "One Half Dark",
            "experimental.retroTerminalEffect": false,
            "font":
            {
                "face": "Comic Code Ligatures, FiraCode Nerd Font Mono",
                "features": {
                    "liga": 1
                },
                "size": 10.0,
                "weight": "light"
            },

            "opacity": 80,
            "useAcrylic": true
        },

and get the following error:

It's in Windows Terminal Preview right now (version 1.21). You can find it in the app store, or here: https://github.com/microsoft/terminal/releases/tag/v1.21.1772.0

Ah I thought I was going crazy, but makes sense. Thanks a lot! Works like a charm as well!!


talk: update MessageHero, multi-DM meta to use sigils

Right now the multi-party dm defaults to having the first letter of whatever the group is named. You can also set an image, but that requires s3. I think defaulting to something that uses the sigils of the members, or making it easy to set a few built in images (emojis?) for the group would be good. iOS does something like this.

This isn't a perfect solve for visibility's sake, but we can consider "stacking" 16px avatars in a diagonal pattern in the sidebar row, such that they fit in the existing boundary of the 24px sidebar icon/avatar area:

The latter of these examples shows a possible participant count we can consider implementing for Group DMs larger than 3 people.

To Zack's latter point, we've also played with the idea of setting Group DM avatars/representations to the "Text" Icon Box type, so that we get an appearance along these lines:

In this case, because the group is named "Heaven's Gang", the group shows up as an H. The background color of the avatar could be set randomly from a limited set of Indigo colors, or default to Black. Emoji are implicitly supported here:


Change name and visibility for Dial widget and DialPainter

To be able to use internal widget and painter without dialog wrapper

Thanks for your contribution! Can you please run flutter format . and push the changes.

@juliansteenbakker Thanks for the feedback. I fetched upstream and make changes again


[hotfix][docs] Fix Scala example for MiniCluster test

What is the purpose of the change
The current Scala example for the MiniCluster test fails to run because:

numberSlotsPerTaskManager is incorrectly set to 1, which causes the test to hang
Scala complains about the Int type since the example functions expect a Long

LGTM, Thank you for the fix!


iOS: SKPayment create() is protected -> Constructor made public

Hey,
it seems like starting with RoboVM 1.8, the SKPayment class has changed. SKPayment.create() is made protected, which I think is why PurchaseManageriOSApple produces a NoSuchMethodError exception when running the purchase() method:
java.lang.NoSuchMethodError: org.robovm.apple.storekit.SKPayment.create(Lorg/robovm/apple/storekit/SKProduct;)Lorg/robovm/apple/storekit/SKPayment; 	at com.badlogic.gdx.pay.ios.apple.PurchaseManageriOSApple.purchase(PurchaseManageriOSApple.java) 	at com.badlogic.gdx.pay.PurchaseSystem.purchase(PurchaseSystem.java)
I'd say we are required to call the constructor for SKPayment instead.
EDIT: OK, I see now that this is already fixed in 0.6.0-SNAPSHOT. Sorry, and thanks for making this project! :)

alex-dorokhov provided the fixes just yesterday :-D

no-no, that was xoppa :)

My bad: although it seems it was both xoppa & you! Thanks to both you guys :-D

Hello. I have this problem also. Can i download new version gdx-pay with use of gradle?  Last version (0.5.0) in the Maven Central updated 13-Aug-2015.

As it is written in description here: https://github.com/libgdx/gdx-pay, snapshot versions are available via sonatype.
So, add this repository in gradle script:
repositories {
    maven { url "https://oss.sonatype.org/content/repositories/snapshots/" }
}

and then use gdx-pay 0.6.0-SNAPSHOT

Thank you. It works


Realize polymorphic has() method to check if certain tab exist.

For inital version checking the tab by url pattern or id will be sufficient.

Resolved.


Add SkipCache to the Go-side ManifestEntry

Description

Fixes WB-NNNNN
Fixes #NNNN

What does the PR do? Include a concise description of the PR contents.

[ ] I updated CHANGELOG.md, or it's not applicable

Testing
How was this PR tested?

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#7366  👈
#7364
#7363
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @moredatarequired and the rest of your teammates on  Graphite


Add Services Environment Labels

Description
The service discovery with environment labels is now supported by Liqo
New mock classes and two new interfaces are been added to make tests work
How Has This Been Tested?

[x] Locally on kind
[x] With google microservice application, that is still working correctly

Pull Request Test Coverage Report for Build 333376723

75 of 150 (50.0%)  changed or added relevant lines in 7 files are covered.
32 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-1.5%) to 46.309%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/virtualKubelet/apiReflection/controller/controller.go
0
3
0.0%

internal/node/pod.go
5
9
55.56%

pkg/virtualKubelet/apiReflection/controller/outgoingReflectorsController.go
0
6
0.0%

pkg/virtualKubelet/apiReflection/controller/test/mockController.go
3
10
30.0%

pkg/virtualKubelet/namespacesMapping/test/mockNamespaceMapper.go
9
16
56.25%

internal/node/env.go
47
67
70.15%

pkg/virtualKubelet/namespacesMapping/test/mockNamespaceMapperController.go
11
39
28.21%

Files with Coverage Reduction
New Missed Lines
%

internal/node/env.go
32
74.76%

Totals

Change from base Build 331092517:
-1.5%

Covered Lines:
6368

Relevant Lines:
13751

💛  - Coveralls

/rebase

/rebase


Dev/update

Thanks for the PR! Can you change the title/add a description of what this PR does? Also can you squash this into a single commit so it will be easier to rebase?


Add parameter to set user uuid in jenkins::credentials define

This addresses #226 - It's largely influenced by the Opscode jenkins module, which has this functionality - https://github.com/opscode-cookbooks/jenkins/blob/master/libraries/credentials.rb

@rtyler - Any progress on testing this? :) Please let me know if more tests are required

@rtyler @madAndroid that would be very useful! hope it gets merged soon!

The last CI run failed for this PR and it needs to be rebased on the current master due to changes introduced by #285.

Cool, no worries - I'll rebase and sort out any conflicts

Rebased, and tests fixed :) ( https://travis-ci.org/jenkinsci/puppet-jenkins/builds/63873665 )

:+1: This looks good to me!
CI didn't run; travis has been acting strange the last few days.  I've had to force push some of my own branches in order to get it trigger.

Odd, I did see the run on travis after I pushed the latest changes up .. results are here, AFAICT ->  https://travis-ci.org/jenkinsci/puppet-jenkins/builds/63873665

An example of the use case where you may want to set the UUID during credential creation: JJB's SCM plugin allows you to set credential-id field, which allows you to have a predefined UUID for easy rebuild of envs

Is there anything more I can do to have this request merged? ( @jhoblitt / @rtyler )

This looks pretty good to me.  Mentioning the new param in the README might not hurt. (eg., https://github.com/jenkinsci/puppet-jenkins#credentials)
One thing of note is that this does change the order of params to create_or_update_credential -- I'm not sure if that's ever been considered a public API, @rtyler ?

@rtyler - anything more I need to do to have this merged? I've added tests, would you like me to expand upon those?

Hi, is there anything further than can be done to have this merged? Do you need me to justify the reason for the addition, and perhaps explain and describe our use case?
@jhoblitt - in response to your query: the ordering of args in create_or_update_credential is taken directly from the credentials-plugin source: https://github.com/jenkinsci/credentials-plugin/blob/master/src/main/java/com/cloudbees/plugins/credentials/impl/UsernamePasswordCredentialsImpl.java#L56-L64
ie:
    /**
     * Constructor.
     *
     * @param scope       the credentials scope
     * @param id          the ID or {@code null} to generate a new one.
     * @param description the description.
     * @param username    the username.
     * @param password    the password.
     */

I've rebased against the latest HEAD of master, and fixed tests that changed as a result of another merge.

@madAndroid nope, thanks for the bump and the good contribution :)

Awesome, thanks! :-)
On 9 Aug 2015 5:58 pm, "R. Tyler Croy"<EMAIL_ADDRESS>wrote:

@madAndroid https://github.com/madAndroid nope, thanks for the bump and
the good contribution :)
—
Reply to this email directly or view it on GitHub
https://github.com/jenkinsci/puppet-jenkins/pull/227#issuecomment-129204220
.


Shelly can't run command with a relative path anymore

Using cmd or run with a relative path doesn't work anymore (it used to some version ago).
E.g.
shelly (cmd "./foo")

Thanks for opening the bug. Not sure what changed to mess this up. I uploaded version <IP_ADDRESS>

The new version doesn't seem to fix the problem. I still got an exception when trying to run a command with a relative path:
*Main Shelly> shelly $ cmd "./foo"
*** Exception:
Ran commands:
./foo
which ./foo

Exception: user error (shelly did not find ./foo in the PATH: ...)

*Main Shelly> shelly $ canonicalize "./foo" >>= cmd
Hello World
"Hello World\n"

It seems to be system dependent as it works on OS X (10.8.5) but not on fedora (22). (And since I didn't get the problem before, I suspect it worked on fedora 20 as well.)
I don't quite understand what is causing this but I found a subtle difference that might be relevant: when I try to run a command that does not exist, the error message is slightly different:
OS X
Shelly> shelly $ verbosely $ cmd "./fooo"
./fooo
*** Exception:
Ran commands:
echo './fooo'
./fooo
which ./fooo

Exception: error running: ./fooo
exit status: 127. exit code 127 usually means the command does not exist (in the PATH)
stderr:

Fedora
Shelly> shelly $ verbosely $ cmd "./fooo"
./fooo
*** Exception:
Ran commands:
echo './fooo'
./fooo
which ./fooo

Exception: user error (shelly did not find ./fooo in the PATH: /home/gregoire/tmp/.cabal-sandbox/bin:/home/gregoire/.cabal/bin:/usr/local/bin:/usr/local/sbin:/usr/lib64/qt-3.3/bin:/usr/bin:/usr/sbin:/bin:/sbin:/home/gregoire/bin:/home/gregoire/.local/bin)

I don't think this should behave different on different OSs. Are you using the latest version of shelly on Fedora?
:set -package shelly-<IP_ADDRESS>

Yes:
Prelude Shelly> :set -package shelly-<IP_ADDRESS>
package flags have changed, resetting and loading new packages...
Prelude Shelly> import Shelly
Prelude Shelly> shelly $ cmd "./fooo"
*** Exception:
Ran commands:
./fooo
which ./fooo

Exception: user error (shelly did not find ./fooo in the PATH:


Request handler returns jsonrpc field as null

2017-02-13 17:24:39   TRACE tcp  Sent response: {"jsonrpc":null,"result":true,"id":1}

That field supposed to be 2.0 for json-rpc 2.0 and ommited for json-rpc 1.0 (or at least be 1.0)

https://github.com/serde-rs/serde-rs.github.io/blob/master/src/attr-skip-serializing.md

yeah sure i will make a pr shortly, currently reproducing with a test


Mail submission agent support?

Description of the feature
Mail submission agent support.
Beneftits of feature
Easy integration of SMTP transaction server.
Additional context
There are no environmental variables for SMTP mail submission (only StartTLS, no SMTP user/password), so it looks like mail submission is not supported.

Hi, I write the following to /app/config/discourse.conf
## SMTP
smtp_address = ${SMTP_HOST}
smtp_port = ${SMTP_PORT}
smtp_domain = ${SMTP_DOMAIN}
smtp_user_name = ${SMTP_USER}
smtp_password = ${SMTP_PASS}
smtp_authentication = ${SMTP_AUTHENTICATION,,}
smtp_enable_start_tls = ${SMTP_START_TLS,,}
smtp_openssl_verify_mode = ${SMTP_TLS_VERIFY,,}
smtp_force_tls = ${SMTP_TLS_FORCE,,}
smtp_open_timeout = 5
smtp_read_timeout = 5

Mail should work?

Sure, that's it. Thank you.


Added blog

As requested at #29

Blogging functionality added to the jabref website with the url http://www.jabref.org/blog.
Newest blog post gets automatically displayed in the end of the news section.
Blog uses same design as http://www.jabref.org and http://www.jabref.org/faq/ and is generally inspired by the faq website in terms of its structure.

New blogs should be added in the _blog folder with a leading number in their name. This way they will automatically appear in the right order on the blog website (newest on the top) and the one with the highest leading number gets featured in the news section.

Can you provide some screenshots?
Thanks!

Screenshots:

and

I am commenting on minor things and trying out minor things, too. Thus, I'll merge it and fix the layout directly.

I'm missing a link on the main page to the blog .

The news has it. Should we also put it on the header? Should we really display the latest blog post on the main page?

Maybe we should replace the news entries by blog entries?

Personally, I would remove the news section from the main page and only link the blog.

I integrated it. You have to click the blog URL for yourself: The links on the top of the site are not working anymore. I'm trying to fix the next days.


FYI: Simplified offline web dev using fetch & localForage

I recently created offlineFetch to simplify offline mode in a hybrid web/mobile app using localForage & window.fetch - it might be useful to your community:
// window.fetch options with additional `offline` property
var options = {

    // typical fetch property
    method: 'GET',

    // new offline property with optional config
    offline: {
        storage: 'localForage',     // use localForage (defaults to sessionStorage)
        timeout: 750,               // request timeout in milliseconds, defaults 730ms
        expires: 1000,              // expires in milliseconds, defaults 1000ms (set to -1 to check for updates with every request)
        debug: true,                // console log request info to help with debugging
        renew: false,               // if true, request is fetched regardless of expire state. Response is and added to cache

        // timeouts are not retried as they risk cause the browser to hang
        retries: 3,                 // number of times to retry the request before considering it failed, default 3 (timeouts are not retried)
        retryDelay: 1000,           // number of milliseconds to wait between each retry

        // used to generate per request cache keys (defaults to URL + METHOD hash if not provided)
        cacheKeyGenerator: function(url, opts, hash) {
            return 'myapp:' + url;
        }
    }
};

offlineFetch('http://www.orcascan.com/', options).then(function(data){
    // data contains response...
});

Sounds great, thanks for sharing!
I'm not sure whether this is the ideal place to post that, maybe the wiki is more appropriate.