YARN-11103. SLS cleanup after previously merged SLS refactor jiras

Description of PR
How was this patch tested?
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  5s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  1s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
37m 43s

trunk passed

+1 :green_heart:
compile
0m 28s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
0m 25s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 22s

trunk passed

+1 :green_heart:
mvnsite
0m 30s

trunk passed

+1 :green_heart:
javadoc
0m 28s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 25s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

-1 :x:
spotbugs
0m 50s
/branch-spotbugs-hadoop-tools_hadoop-sls-warnings.html
hadoop-tools/hadoop-sls in trunk has 2 extant spotbugs warnings.

+1 :green_heart:
shadedclient
25m  8s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 21s

the patch passed

+1 :green_heart:
compile
0m 21s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
0m 21s

the patch passed

+1 :green_heart:
compile
0m 19s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 19s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
0m 13s
/results-checkstyle-hadoop-tools_hadoop-sls.txt
hadoop-tools/hadoop-sls: The patch generated 14 new + 23 unchanged - 24 fixed = 37 total (was 47)

+1 :green_heart:
mvnsite
0m 21s

the patch passed

+1 :green_heart:
javadoc
0m 19s

hadoop-tools_hadoop-sls-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 generated 0 new + 19 unchanged - 6 fixed = 19 total (was 25)

+1 :green_heart:
javadoc
0m 17s

hadoop-tools_hadoop-sls-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 0 new + 19 unchanged - 6 fixed = 19 total (was 25)

-1 :x:
spotbugs
0m 53s
/new-spotbugs-hadoop-tools_hadoop-sls.html
hadoop-tools/hadoop-sls generated 1 new + 1 unchanged - 1 fixed = 2 total (was 2)

+1 :green_heart:
shadedclient
23m 47s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
12m  4s

hadoop-sls in the patch passed.

+1 :green_heart:
asflicense
0m 30s

The patch does not generate ASF License warnings.

108m 14s

Reason
Tests

SpotBugs
module:hadoop-tools/hadoop-sls

Write to static field org.apache.hadoop.yarn.sls.AMRunner.remainingApps from instance method org.apache.hadoop.yarn.sls.AMRunner.startAM()  At AMRunner.java:from instance method org.apache.hadoop.yarn.sls.AMRunner.startAM()  At AMRunner.java:[line 117]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4119/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4119

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 8ad2c5275e18 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 981827bbd38e481e26d37c4aebba051f8f7ea377

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4119/1/testReport/

Max. process+thread count
522 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4119/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 21s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
37m 46s

trunk passed

+1 :green_heart:
compile
0m 30s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
0m 24s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 21s

trunk passed

+1 :green_heart:
mvnsite
0m 29s

trunk passed

+1 :green_heart:
javadoc
0m 29s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 23s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

-1 :x:
spotbugs
0m 49s
/branch-spotbugs-hadoop-tools_hadoop-sls-warnings.html
hadoop-tools/hadoop-sls in trunk has 2 extant spotbugs warnings.

+1 :green_heart:
shadedclient
23m 47s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 20s

the patch passed

+1 :green_heart:
compile
0m 24s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
0m 24s

the patch passed

+1 :green_heart:
compile
0m 20s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 20s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
0m 15s
/results-checkstyle-hadoop-tools_hadoop-sls.txt
hadoop-tools/hadoop-sls: The patch generated 13 new + 53 unchanged - 29 fixed = 66 total (was 82)

+1 :green_heart:
mvnsite
0m 22s

the patch passed

+1 :green_heart:
javadoc
0m 21s

hadoop-tools_hadoop-sls-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 generated 0 new + 19 unchanged - 6 fixed = 19 total (was 25)

+1 :green_heart:
javadoc
0m 17s

hadoop-tools_hadoop-sls-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 0 new + 19 unchanged - 6 fixed = 19 total (was 25)

-1 :x:
spotbugs
0m 56s
/new-spotbugs-hadoop-tools_hadoop-sls.html
hadoop-tools/hadoop-sls generated 1 new + 1 unchanged - 1 fixed = 2 total (was 2)

+1 :green_heart:
shadedclient
23m 30s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
12m  3s

hadoop-sls in the patch passed.

+1 :green_heart:
asflicense
0m 29s

The patch does not generate ASF License warnings.

106m 59s

Reason
Tests

SpotBugs
module:hadoop-tools/hadoop-sls

Write to static field org.apache.hadoop.yarn.sls.AMRunner.remainingApps from instance method org.apache.hadoop.yarn.sls.AMRunner.startAM()  At AMRunner.java:from instance method org.apache.hadoop.yarn.sls.AMRunner.startAM()  At AMRunner.java:[line 116]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4119/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4119

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 81a7671907b1 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f4382e448deee7e74269d510e850a492cf97498a

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4119/2/testReport/

Max. process+thread count
593 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4119/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  4s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
38m  2s

trunk passed

+1 :green_heart:
compile
0m 35s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
0m 39s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 33s

trunk passed

+1 :green_heart:
mvnsite
0m 46s

trunk passed

+1 :green_heart:
javadoc
0m 44s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 38s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

-1 :x:
spotbugs
1m  8s
/branch-spotbugs-hadoop-tools_hadoop-sls-warnings.html
hadoop-tools/hadoop-sls in trunk has 3 extant spotbugs warnings.

+1 :green_heart:
shadedclient
25m 13s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 22s

the patch passed

+1 :green_heart:
compile
0m 22s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
0m 21s

the patch passed

+1 :green_heart:
compile
0m 18s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 18s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
0m 13s
/results-checkstyle-hadoop-tools_hadoop-sls.txt
hadoop-tools/hadoop-sls: The patch generated 13 new + 59 unchanged - 24 fixed = 72 total (was 83)

+1 :green_heart:
mvnsite
0m 20s

the patch passed

+1 :green_heart:
javadoc
0m 19s

hadoop-tools_hadoop-sls-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 generated 0 new + 20 unchanged - 6 fixed = 20 total (was 26)

+1 :green_heart:
javadoc
0m 17s

hadoop-tools_hadoop-sls-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 0 new + 20 unchanged - 6 fixed = 20 total (was 26)

-1 :x:
spotbugs
0m 54s
/new-spotbugs-hadoop-tools_hadoop-sls.html
hadoop-tools/hadoop-sls generated 1 new + 2 unchanged - 1 fixed = 3 total (was 3)

+1 :green_heart:
shadedclient
25m 25s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
12m 16s

hadoop-sls in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

111m 58s

Reason
Tests

SpotBugs
module:hadoop-tools/hadoop-sls

Write to static field org.apache.hadoop.yarn.sls.AMRunner.remainingApps from instance method org.apache.hadoop.yarn.sls.AMRunner.startAM()  At AMRunner.java:from instance method org.apache.hadoop.yarn.sls.AMRunner.startAM()  At AMRunner.java:[line 115]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4119/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4119

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 0999cbd810d1 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 66493fa55a3961f057106ef92cac3abc3e6c4a9c

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4119/3/testReport/

Max. process+thread count
523 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4119/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@9uapaw
Thanks for your comment. This is an independent change and the spotbugs warning was in place before this patch, so I suggest to commit this first then I will fix the spotbugs in the other one.
Thanks

Thanks @szilard-nemeth for the PR, since a different PR exists for the spotbugs issue I committed this one to trunk. Fixed the indentation checkstyle issues before merging.


Support datetime2 cast and rounding in datetime2 TRY_CONVERT

Description
Currently try_convert to datetime2 cannot handle certain cases. This commit changes the implementation to use cast, and also extends the datetime2 implementation to cover try_cast. It reverts the changes of the previous commit to rely on cast rather than the datetime_to_string function
Task: Babel-3614
Check List

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Let's change the PR title to something like "Support datetime2 cast and rounding in datetime2 TRY_CONVERT". You can mention in the description that you reverted the previous commit Also does this cover BABEL-3646?

Let's change the PR title to something like "Support datetime2 cast and rounding in datetime2 TRY_CONVERT". You can mention in the description that you reverted the previous commit Also does this cover BABEL-3646?

This commit does not cover babel-3646 because that involves more datatypes than just datetime2. This commit just fixes the datetime2 issues but also enables support for try_cast datetime2


Add support for different login providers for datalayer access

As we move to support more datalayers, and also datalayers that are configured with different security mechanisms, we need a new API to allow to add login providers.
Today there is a single login provider that supports jwt (Auth0 compatible) Bearer tokens. It also only supports a single configuration via ENV variables.
This issue suggests that we expand the internal provider map with configurations loaded through a new api.
To support full cli access the following should be implemented:

POST /login/providers -> create a new provider
POST /login/provider/:providerName -> update an existing provider
GET /login/providers -> Lists all providers
GET /login/provider/:providerName -> returns details for a provider
DELETE /login/provider/:providerName -> deletes a provider with no jobs using it

As a start I would suggest to add 2 types of providers:

Jwt -> This is basically what we have to day and requires compatibility with Auth0
Basic -> User/Password combination

Since these contains secrets, we need to support reading from env or from a secrets store (ssm is the only supported one at the moment), but we should also allow plain text. A GET request to show a provider should then return the scrambled values if text.
An example on how to configure this is:
{
    "password": {
        "type": "text",
        "value": "super-secret"
    }
}

An example on a (plain) provider could then end up looking like this:
{
    "name":"my-plain-login",
    "type": "basic",
    "user": {
        "type": "text",
        "value"<EMAIL_ADDRESS>    },
    "password": {
        "type": "text",
        "value": "super-secret"
    }
}

In a job, the name "my-plain-login" can be referenced, and the http client will be decorated with the correct login mechanism.
When the type is env or ssm, the value needs to be loaded from the target location, and kept in memory while the server is
running.

done.


Tz-aware timestamps

What's needed?
Information about the timezone of the timestamp.
Proposed solution
Either docs that state the timestamps are always UTC or return tz-aware timestamps to the user.
Use cases
No response
Alternatives and workarounds
No response
Additional context
No response

return tz-aware timestamps to the user.

Voting for this.
Maybe this can be done in one PR together with this https://github.com/frequenz-floss/frequenz-api-weather/issues/111


Question about futures that do not use the waker

One thing that has consistently confused me about futures is this quote from the docs:
https://doc.rust-lang.org/std/future/trait.Future.html

Once a future has finished, clients should not poll it again.
When a future is not ready yet, poll returns Poll::Pending and stores a clone of the Waker copied from the current Context. This Waker is then woken once the future can make progress. For example, a future waiting for a socket to become readable would call .clone() on the Waker and store it. When a signal arrives elsewhere indicating that the socket is readable, Waker::wake is called and the socket future's task is awoken. Once a task has been woken up, it should attempt to poll the future again, which may or may not produce a final value.
Note that on multiple calls to poll, only the Waker from the Context passed to the most recent call should be scheduled to receive a wakeup.

To me, its clear why a PROPER future implementation should use the waker to unblock the executor (some combinators like Map don't do this, but they usually contain futures that do use the waker), but its also clear that there is nothing really stopping someone from writing a naive future that just does cpu bound work.
To test this I made https://github.com/guswynn/smol-test-block, which implements a future that yields some amount of times, then yields Ready() after that many times, and NEVER interacts with the _cx, to see if the the executor would be blocked.
> cargo run 10
   Compiling smol_test v0.1.0 (/Users/azw/ruststuff/smol_test)
    Finished dev [unoptimized + debuginfo] target(s) in 0.87s
     Running `target/debug/smol_test 10`
Current countdown: 9
Current countdown: 8
<hang>

I originally thought I'd have to countdown 200 times (as I believe that thats the number of poll's the 2 executors run on a loop, but in fact, it seemed to get stuck after only 2 poll's
It feels bad that what seems like an innocent future implementation, can hang an executor. Is something wrong with my code here? Am I totally off base thinking that futures that don't use the waker should work? To me its weird in rust for a constraint like this to not be statically enforced.
For posterity, the tokio-test branch of that repo tries the same thing, but tokio seemed to have similar behavior:
> cargo run 10000
   Compiling smol_test v0.1.0 (/Users/azw/ruststuff/smol_test)
    Finished dev [unoptimized + debuginfo] target(s) in 0.78s
     Running `target/debug/smol_test 10000`
Current countdown: 9999
<hang>

It's impossible to force Future implementations to call the waker; you can't tell the difference between a computation that takes a long time to complete and one that will never complete, like yours. Not using the waker is indistinguishable from using the waker 1000 years in the future. That's why the executor hangs.

@Koxiaet

you can't tell the difference between a computation that takes a long time to complete and one that will never complete, like yours. Not using the waker is indistinguishable from using the waker 1000 years in the future.

This makes a lot of sense! Thanks for the response!
I guess though, I still think there may be value in having some (relatively long) timeout, after which the executor un-hangs. This would not affect perf as the timeout would be longer than normal wakeups in normal workflows, but would unblock pathological case like this.
One argument against this is that offering this papers over the pathological problems that shouldn't be written in the first place

The Future contract does specify that the Waker must be called, so your code is invalid indeed, as per the paragraph you quoted.
If you need to yield, as you say, you should use something like https://github.com/stjepang/smol/issues/43, and do something like that:
async fn foo() {
    bar();
    yield_now().await;
    baz();
}

Hand-written futures are usually something you don't need to do, nor want as it's quite hard to call the waker as it has to be -- either way, if you really have to write a future, the thing you must remember when writing Futures is that if you return Poll::Pending, then you must call the Waker at some point.
As for adding implicit timeouts… adding timeouts on each pending would probably slow down quite a lot the code, because it needs to record and keep track of all the implicit timeouts. And given the Future contract requires futures to call the waker, there's little point in doing so :)

@Ekleog thanks for linking that issue! ill look into yield_now()!

cc #43

Closing in favor of #43


[WIP] feat: Implement CRI image verification plugin system

This PR implements https://github.com/containerd/containerd/issues/6691. If a TTRPC image verifier plugin is configured, the CRI will make a call to that plugin to decide whether an image should be pulled.
Signed-off-by: Ethan Lowman<EMAIL_ADDRESS>

Rebased on main to fix the merge conflict and fixed (at least some of) the CI failures.

@dmcgowan I'm looking into updating this PR now that the new transfer service is merged, but I noticed that the CRI was unchanged by https://github.com/containerd/containerd/pull/7320. Does this mean that the CRI is not yet using the Transfer service, or am I missing something?

@dmcgowan I'm looking into updating this PR now that the new transfer service is merged, but I noticed that the CRI was unchanged by #7320. Does this mean that the CRI is not yet using the Transfer service, or am I missing something?

@ethan-lowman-dd Looking at the Todo list in this issue, https://github.com/containerd/containerd/issues/7592, it looks like CRI has not been updated to utilize the transfer service yet. It looks like it might have a chance of getting done for the 1.7 release though.

I talked with @dmcgowan about this a few weeks ago, and it sounded like implementing the image verification features as a proxy plugin would align better with the long-term architecture plans for containerd. Implementing it in the CRI means the feature is unavailable for other clients, like nerdctl. I haven't gotten the time to implement the proxy plugin approach yet. I will probably do it in a new draft PR since I think the relative simplicity of the CRI approach is a useful reference to not have lost in git history, even if though it probably won't be merged.

@ethan-lowman-dd If there is anything I can do to assist, I'd be happy to help.

Closing in favor of https://github.com/containerd/containerd/pull/8493


🔥 Sidebar Navigations

New Feature - Sidebar Navigation
A sidebar navigation has been added to mumble projects.
Desktop

Mobile

@Mr-spShuvo There is a bug in the login page

Yaaaaass this is nice!

@MidouWebDev It's not a issue with this PR.
May be create an Another issue mentioning with the Display Resolution.

Yaaaaass this is nice! Good merge unless you want another reviewer

@divanov11  wants to have a look before I'm merging this.
Let's just wait for his approval.

@Mr-spShuvo
If you check the mumble website now, you will notice that we don't have the problem i mentionned !

Alright I checked. No Issues on my end. Also,
I did not touch any styles on LoginSignup.css.
May be it on your device only things.
Can you share your device resolution and browser info?
@MidouWebDev

Alright I checked. No Issues on my end. Also,
I did not touch any styles on LoginSignup.css.
May be it on your device only things.
Can you share your device resolution and browser info?
@MidouWebDev

@Mr-spShuvo i am on Google Chrome, Laptop 15.6" Display


JS Palindrome Checker Preview Displays White Screen

Describe the Issue
JavaScript Algorithms and Data Structures > Build a Palindrome Checker Project
2/13/2024, the preview window displayed the expected content and styles.
2/14/2024, the preview only shows a white screen.
Other projects and past challenges in the same curriculum display normally.
Editing the code in any of the text boxes does not refresh or update the preview. The console does get updated.

Affected Page
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/build-a-palindrome-checker-project/build-a-palindrome-checker
Your code
HTML

  <title>Palindrome Checker</title>
  <link rel="stylesheet" href="./styles.css">

Palindrome Checker

Enter a word, phrase, or string of numbers here to check if it's a palindrome!

A palindrome is a word or phrase that can be read the same way forwards and backwards, ignoring punctuation, case, and spacing.

  <form>
  <input id="text-input"></input>
  <button id="check-btn">Check</button>
  </form>

CSS
body {
  color: white;
  background-color: #222;
  margin: 30px;
  text-align: center;
}

input {
  width: 80%;
  margin: 10px;
  padding: 10px;
}

button {
  border-radius:50px;
  padding: 10px 60px;
  margin: 0 auto;
  display: block;
  background-color: #0cf;
}

form {
  padding: 10px;
  border-radius: 6px;
  background-color: #444;
}

JS
//define variables
const textInput = document.getElementById("text-input");
const checkButton = document.getElementById("check-btn");
const result = document.getElementById("result");

const cleanString = (textInput.value) => {
  return input.replace(/[^a-zA-Z0-9]/g, "").toLowerCase();
}

///[^a-zA-Z0-9]/g regex to clean

/*
- If it has something:
-Take textInput and remove punctuation, case, and spacing
- define as cleanedInput
- get the length of cleanedInput
- find the middle
-- the middle is the length/2
- See if the first half forward is the same as the second half reverse
- need to define firstHalf and secondHalf
- if they are, say it's a palindrome
- if unequal, say not a palindrome
*/

const checkIfPal = () => { //Palindrome checker function

}

//Click button. If blank, error. If not, run script.
checkButton.addEventListener("click", () => {
  if (textInput.value.length <= 0) {
  alert('Please input a value');
  } else {
    checkIfPal();
  }
});

Expected behavior
Expected a preview of the content and styles in the Preview window pane. Screenshot from Codepen below
Screenshots

System

Device: Mac Studio 2022
OS: macOS Sonoma 14.2.1
Browser: Chrome
Version: Version 121.0.6167.160 (Official Build) (arm64)

Additional context
No response

Thank you for reporting this issue.
I'm not sure why syntax error is not displayed in console, but cleanString function has incorrectly defined parameter.
Instead of asking for help here, please click the "Get Help" button on the challenge on freeCodeCamp and choose the "Ask for help" option, which will help you create a question in the right part of the forum. Volunteers on the forum usually respond to questions within a few hours and can help determine if there is an issue with your code or the challenge's tests.
If the forum members determine there is nothing wrong with your code, you can request this issue to be reopened.
Thank you and happy coding.

Sorry, was the assumption that I was asking for code help?
I'm not concerned about my code, that is still in creation and I'm looking
forward to doing the challenge, it's just that I can't because the display
pane is white.
Ignore the code, ignore the console, I supplied it because it was requested
in the support ticket form, but the bug that I have is irrelevant to my
actual skill but more so the fact that the preview does not work.
On Wed, Feb 14, 2024, 9:36 PM Krzysztof G. @.***> wrote:

Thank you for reporting this issue.
I'm not sure why syntax error is not displayed in console, but cleanString
function has incorrectly defined parameter.
Instead of asking for help here, please click the "Get Help" button on
the challenge on freeCodeCamp and choose the "Ask for help" option,
which will help you create a question in the right part of the forum.
Volunteers on the forum usually respond to questions within a few hours and
can help determine if there is an issue with your code or the challenge's
tests.
If the forum members determine there is nothing wrong with your code, you
can request this issue to be reopened.
Thank you and happy coding.
—
Reply to this email directly, view it on GitHub
https://github.com/freeCodeCamp/freeCodeCamp/issues/53727#issuecomment-1945402781,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUWHL37KRAOIC3BWMCWIAELYTWNF7AVCNFSM6AAAAABDJEKYRKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBVGQYDENZYGE
.
You are receiving this because you authored the thread.Message ID:
@.***>


Use import type for importing type

Proposed changes
This change won't give error when importsNotUsedAsValues is set to error in tsconfig.json and won't break existing code
Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[x] I have read the CONTRIBUTING doc
[ ] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] I have added necessary documentation (if appropriate)

Thanks 👍


Create many events - count not working

Describe the bug
It seems that count parameter not working for http://<host>/auth/realms/master/dataset/create-events?count=<count>.
Regardless of whether it is set to 10 or other small amount, couple of thousands LOGIN events created.
Version
17.0.0
Expected behavior
Should be called exact amount of events as set in count parameter.
Actual behavior
count parameter is not respected.
How to Reproduce?
Try to call 10 events in example.
Anything else?
No response

@pedroigor / @emikolajczak - I see a PR has been merged for this issue, still this issue is open.
I wonder if this issue can be closed/has been resolved. Thanks!


alerts fail when text contains unicode characters

attempting to use a filter on a field containing a unicode/non-ASCII character will cause the following exception in case of an alert:
ERROR:root:Traceback (most recent call last):
File "/usr/lib/python2.6/site-packages/elastalert-0.0.57-py2.6.egg/elastalert/elastalert.py", line 826, in alert
return self.send_alert(matches, rule, alert_time=None)
File "/usr/lib/python2.6/site-packages/elastalert-0.0.57-py2.6.egg/elastalert/elastalert.py", line 887, in send_alert
alerter.alert(matches)
File "/usr/lib/python2.6/site-packages/elastalert-0.0.57-py2.6.egg/elastalert/alerts.py", line 166, in alert
logging.info(str(BasicMatchString(self.rule, match)))
File "/usr/lib/python2.6/site-packages/elastalert-0.0.57-py2.6.egg/elastalert/alerts.py", line 84, in str
self._add_match_items()
File "/usr/lib/python2.6/site-packages/elastalert-0.0.57-py2.6.egg/elastalert/alerts.py", line 62, in _add_match_items
value_str = str(value)
UnicodeEncodeError: 'ascii' codec can't encode character u'\ufeff' in position 0: ordinal not in range(128)
after replacing the str() call with a unicode() call, the following exception occurs:
ERROR:root:Traceback (most recent call last):
File "/usr/lib/python2.6/site-packages/elastalert-0.0.57-py2.6.egg/elastalert/elastalert.py", line 826, in alert
return self.send_alert(matches, rule, alert_time=None)
File "/usr/lib/python2.6/site-packages/elastalert-0.0.57-py2.6.egg/elastalert/elastalert.py", line 887, in send_alert
alerter.alert(matches)
File "/usr/lib/python2.6/site-packages/elastalert-0.0.57-py2.6.egg/elastalert/alerts.py", line 166, in alert
logging.info(str(BasicMatchString(self.rule, match)))
UnicodeEncodeError: 'ascii' codec can't encode character u'\ufeff' in position 268: ordinal not in range(128)
after replacing the str() call with a unicode() call, the alert appears to work.

Will this be handled in any coming releases?

I just merged a change which fixes this particular bug, and several more related to unicode. It's in master branch. I'll make a release with it soon.

is it in V0.0.73?

This should be fixed. If you encounter another similar error, please post a stack trace.

@Qmando  it is still "UnicodeEncodeError ascii" there.  it can't send Chinese characters by email...

Can you post the stack trace?

@Qmando  sorry that i made a mistake~  and do you know how to make "\n\r" or "" work in email alert?

If you want newlines, you have to use YAML block syntax
alert_text: |
  Foo bar baz
  This will be on a new line
  blah blah

Whether this technically includes "\r" I think depends on your operating system.

@tanxiaolong 您好，麻烦问下您的问题解决了么？我也遇到同样的问题。


[Feature Request] Enhance Release Information Display: Move Location & Distinguish Release Types

Issue Description

https://all.devstats.cncf.io/d/53/projects-health-table?orgId=1

Currently, release information is displayed at the bottom of the project page. It would be helpful to move this information to the top of the page and distinguish between different types of releases (major, minor, and patch) following the format major.minor.patch. This change can clarify the project's status, especially in maintenance mode (i.e., minor releases have stayed the same in the past few years).
Proposed Solution

Move the release information section from the bottom of the project page to the top, making it more visible to users.
Distinguish between different release types (major, minor, and patch) to give users a clearer understanding of the project's status.

Benefits

Enhanced visibility of release information.
Allows users to identify when a project is in "maintenance mode."
Improves the overall user experience when browsing the project page.

Hey, @onlydole I will try it. Let me send a pull request. Thank you, for writing it easy and beginner friendly!

Hi!
Should we transfer this issue to cncf/devstats?
/cc @lukaszgryglicki


Add a new class "Scaling" under processing.

Prepare a new class under the processing module.
Prepare the functions with a proper idea and also add appropriate comments.
Add a function "run" inside the "Scaling" which will go through every feature, e.g. link.
Add the function under the class Preprocessing.

Follow contributing guidelines on README.md

I would like to suggest that we can scale the data directly by using Sklearn.preprocessing
scaler=MinMaxScaler()
x_train=scaler.fit_transform(x_train)
x_val=scaler.transform(x_val)
by adding these lines to the training.py file we can easily scale the data without needing to parse through each feature through a for loop which would be more time consuming and also can be a reason for many bugs.
we can also put conditions if the model is for regression and also ask user which scailing function they want and apply those to the x_train and x_val
If you agree to this idea then please assign this Issue to me.

@Tihsrah , it is not better to use minmaxscaling for continuous data , so in some cases it it better to just scale down or scale up.
So basically the function should be flexible for every single data column.
If you have a flexible idea about it, please drop the ide, if it shows calrity, I'll assign you.

@Tihsrah, I would suggest you be flexible while making the class as I stated early.


The latest version of Tailwind styles are not working, and hot reloading is not effective.

Problem
The latest version of Tailwind styles are not working, and hot reloading is not effective.
Steps To Reproduce
Steps to reproduce the behavior:

Modifying content or styles shows hot reload information in the console, but the UI does not respond.  The UI only updates after pressing the 'R' key to recompile.

Setting the font color to red using Tailwind CSS is not working, and an error message is visible in the console.

Expected behavior
I hope that basic features like hot reload during development and Tailwind CSS work properly.
Environment:

Dioxus version:  0.6.0-alpha.2
Rust version:    rustc 1.81.0
OS info:         win11
App platform:    desktop

Temporary workaround for tailwind:
Download tailwind.js file from https://cdn.tailwindcss.com and put it in your assets folder, then use the following to load it:
let cfg = dioxus::desktop::Config::new()
    .with_custom_head(r#"<script src="/assets/tailwind.js"></script>"#.to_string());

You need to have a separate tailwind process running as Dioxus doesn't run it for you when you do dx serve
npx tailwindcss -i ./src/input.css -o ./assets/tailwind.css --watch

I'm also experiencing the issue on 0.6.0-alpha.2 where hot reloading is not effective on any platform.
I see DEV: Hotreloaded <file> in the dev logs but there are no changes.

let cfg = dioxus::web::Config::new()
.with_custom_head(r#""#.to_string());
when i try to do this for web, i get an error. Also noticed when i was running tailwind watch in 0.5 version everything was working perfectly. But i need to access the canvas elements and jumped to 0.6 version and my tailwind just stopped working

@RusticCraftsman
This was the code I used:
fn make_config() -> dioxus::desktop::Config {
    let cfg = dioxus::desktop::Config::new();
    #[cfg(not(debug_assertions))]
    let cfg = cfg.with_disable_context_menu(true);
    #[cfg(not(debug_assertions))]
    let cfg = cfg.with_menu(None);
    cfg.with_custom_head(r#"<script src="/assets/tailwind.js"></script>"#.to_string())
        .with_window(make_window())
}

fn make_window() -> WindowBuilder {
    WindowBuilder::new()
        .with_maximized(true)
        .with_resizable(true)
        .with_always_on_top(false)
}

fn main() {
    // Init logger
    dioxus_logger::init(Level::ERROR).expect("failed to init logger");
    info!("starting app");

    LaunchBuilder::desktop().with_cfg(make_config()).launch(App);

    launch(App);
}

In dioxus 0.6, tailwind should be included in a document::Stylesheet component as described in the guide:
use dioxus::prelude::*;

#[component]
fn app() -> Element {
    rsx! {
        // The Stylesheet component inserts a style link into the head of the document
        document::Stylesheet {
            // Urls are relative to your Cargo.toml file
            href: asset!("/assets/tailwind.css")
        }
    }
}

If you still cannot load the asset after including it with the asset! macro, make sure the version of the Dioxus CLI and dioxus you installed are matching. If you are using 0.6, you need to install the 0.6 CLI (previous releases and 0.6-alpha releases are compatible)

To me it seems like the template being distributed for tailwindcss is not correct, based on how my template was generated and the current templates repo: https://github.com/DioxusLabs/dioxus-template/blob/fb0a78ee345ff4a33f2ca0ec29bddbbbe458d301/Bare-Bones/src/main.rs#L27

The template uses document::Link { rel: "stylesheet", href: ... } which is what the stylesheet component renders under the hood. I tested the bare bones template on macos with the chrome browser and it seems to render correctly (after running the tailwind CLI).

@ealmloff , Do you recon the template should be changed to include this? if so, i could quickly open a pr as a fix

I think both versions should work the same, but it would be a bit better to include use the stylesheet component in the template as well so it is consistent with the tailwind guide


Run without debugging (Ctrl+F5)

Describe the bug
Run without debugging (Ctrl+F5) It doesn't work for me in AutoLISP.
To Reproduce
When trying to Run without debugging, the application still runs.
Desktop (please complete the following information):

OS: Window
Version 10

Additional context
This is a mistake?
Or am I doing something wrong?

Yes, I have noticed that too.

Hi Chapalee,
do you mean that with Ctrl+F5, it's still actually debugging the LSP file?

Exactly, the debugging begins and it shouldn't be like that.
He should connect to autocad but not debug.

Thanks a lot for logging this issue. I totally agree with you.

More on this. If I have a breakpoint in my code "Run without debugging" will stop anyway at the breakpoint, just as if I was using plain F5.
I suppose the idea was that it should run without stopping at the breakpoint. Or no?

More on this. If I have a breakpoint in my code "Run without debugging" will stop anyway at the breakpoint, just as if I was using plain F5.
I suppose the idea was that it should run without stopping at the breakpoint. Or no?

Yes I agree with you. It should just connect to ACAD and load the LSP file.

Still a bug in 2024.

Still a bug in 2024.

Thanks for your reminder.
BTW, I think this menu item is for the launch mode (i.e. to start a new Autocad instance to run/debug the active lisp file). So in addition to support 'Launch Without Debugging' for the launch mode, it would be better to disable the 'Launch Without Debugging' entry in the attach use case.

it would be better to also make it impossible to choose the 'attach' mode in the 'Run Without Debugging' use case.
Are you suggesting something I need to do or just a placeholder for a :ToDo?

Are you suggesting something I need to do or just a placeholder for a :ToDo?

Yeah just adding a :ToDo item for this issue. Let me update my comment.

Still a bug in AutoCAD 2025


Remove usage of ModelVector.size()

Fixes #7

My Solver only produces a single Model, so for optimization purposes, I had to create a SingleList<T> class, which is basically T + operator[]. It might be a rather common scenario. Does it make sense to put it somewhere in the lib?

Looks good to me, thank you very much!


Suspend MediaSourceEngine operations if video element is not in the DOM

We have a use case on Tizen 2017 TV's where we remove the video element from the DOM in order to play some ads in another element. We have made a change to MediaSourceEngine to defer all operations (i.e. calls to enqueueOperation_) until the video element is back in the DOM. If we don't remove the video element from the DOM, or if we don't suspend calls to enqueueOperation_, we get 3016 VIDEO_ERROR.
Would Shaka be willing to accept such a change upstream? I believe this could be achieved cleanly by using a MutationObserver and watching the whole document. Performance would need to be investigated, and likely you would want the behaviour to be configurable behind a flag.
As an alternative, perhaps you could allow the client to set a callback which returns a Promise that resolves when enqueueOperation_ can proceed. Then the client can deal with the MutationObserver.
2018 model Tizen TV's apparently have the same issue. We also have both 2017 and 2018 model LG WebOS TV's; I will check if it affects those platforms.
Thanks. Please let me know where this falls in terms of reasonableness.

Personally, I think the client-controlled option sounds better. That would allow for the client to just toggle it on or off at the same time as they modify the DOM, and not worry about the performance of a MutationObserver at all.
@joeyparrish, thoughts?

That's an even better idea. A simple synchronous call that allows the client to tell Shaka whether it should do MediaSource work or not.

Is anyone interested in seeing this supported?


RuntimeError: You must compile your model before training/testing

When trying to run 02-experimentation, I receive the error: You must compile your model before training/testing.

I have updated the TFX version to 1.2.0 and the issue is now resolved


Django requesting static assets without the static url path

In my djanog app, Django server is requesting assets from
http://localhost:5173/js/apps/home.ts instead of http://localhost:5173/static/js/apps/home.ts even though my STATIC_URL is set correctly. Are there any settings or steps I am missing?
Here is my django settings.
# STATIC
# ------------------------------------------------------------------------------
# https://docs.djangoproject.com/en/dev/ref/settings/#static-root
STATIC_ROOT = str(BASE_DIR / "staticfiles")
# https://docs.djangoproject.com/en/dev/ref/settings/#static-url
STATIC_URL = "/static/"
# https://docs.djangoproject.com/en/dev/ref/contrib/staticfiles/#std:setting-STATICFILES_DIRS
STATICFILES_DIRS = [
    str(APPS_DIR / "static"),
    str(APPS_DIR / "static" / "vite_assets_dist")
]
# https://docs.djangoproject.com/en/dev/ref/contrib/staticfiles/#staticfiles-finders
STATICFILES_FINDERS = [
    "django.contrib.staticfiles.finders.FileSystemFinder",
    "django.contrib.staticfiles.finders.AppDirectoriesFinder",
]

DJANGO_VITE = {
    "default": {
        "dev_mode": True
    }
}

You are in dev mode, Django does not serve files in dev mode this is the Vite internal server who does it as he will provide you hot-reloading.
I think your missing to specify your STATIC_URL as the base of Vite server, check this https://github.com/MrBin99/django-vite#vitejs

Figured out the issue. The problem is this
{% vite_asset '/js/apps/home.js' %}

I have a / in front of js which was making it an absolute path. After I removed it the django server started requesting file
http://localhost:5173/static/js/apps/home.ts


transformer-attributify-jsx is not working with react + nextjs ( postcss )

UnoCSS version
v0.55.7
Describe the bug
transformer-attributify-jsx is not working with react + nextjs ( postcss )
error message :

Reproduction
<div bg-red> abc </div>

add this in any component of nextjs project that uses postcsss for unocss
minimal project repo : https://github.com/siduck/test_next_unocss
System Info
No response
Validations

[X] Read the Contributing Guidelines.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

postcss only handles css, Consider using @unocss/webpack?

hi @Dunqing i had tried using webpack but it had the same issue :(
also seems like webpack has some issue with unocss, https://github.com/unocss/unocss/issues/419

Yes, the postcss doesn't support transformer-attributify-jsx


add ingress/router nodeType to pilot_cli

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: quanjielin
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: vadimeisenbergibm
Assign the PR to them by writing /assign @vadimeisenbergibm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

@quanjielin: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
91dc22c3d863d17a607465eacbcfea6e3a8603a7
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Close this PR as https://github.com/istio/istio/pull/5531 took the change, thanks @diemtvu.


mvcc,auth,lease: expose binary encode utils for external tooling

Previously, one had to manually copy and paste unexported binary encoded object (e.g. mvcc.revision). Now exposing them for external tools (e.g. etcd-dump-db, package snapshot).

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@f42d9a8). Click here to learn what that means.
The diff coverage is 82.6%.

@@            Coverage Diff            @@
##             master    #9675   +/-   ##
=========================================
  Coverage          ?   68.94%
=========================================
  Files             ?      375
  Lines             ?    35036
  Branches          ?        0
=========================================
  Hits              ?    24157
  Misses            ?     9102
  Partials          ?     1777

Impacted Files
Coverage Δ

snapshot/util.go
100% <ø> (ø)

mvcc/kvstore.go
86.78% <100%> (ø)

lease/lessor.go
86.4% <100%> (ø)

auth/store.go
49.66% <100%> (ø)

snapshot/v3_snapshot.go
64.75% <100%> (ø)

mvcc/index.go
91.36% <100%> (ø)

mvcc/watchable_store.go
82.74% <100%> (ø)

mvcc/util.go
72.72% <100%> (ø)

lease/util.go
50% <50%> (ø)

mvcc/revision.go
71.87% <67.85%> (ø)

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f42d9a8...ee2bb8b. Read the comment docs.


Feature Request: Databricks SQL Support

Describe the Feature
Support for Databricks.
Databricks SQL Language reference: https://docs.databricks.com/en/sql/language-manual/index.html
Why do you want this feature?
Improve the user experience when editing Databricks SQL files.

Just FYI. I'm open to pull requests, but I'm unlikely to implement this by myself.

Completely understand. I'll work on this and submit a PR when possible.


13B Fine-tuning GPU requirements

How many A100 GPUs (40GB) required to tune 13B model ( full parameter )? I want to train llama2 for new language, so lora is not the best option

@generalsvr as per my experiments 13B with 8xA100 80 GB reserved memory was 48 GB per GPU, with bs=4, so my estimation is we should be able to run it with 16x A100 40 GB (2 nodes) for a reasonable batch size.

Based on my experience, A100 40G4 and 240G of CPU RAM are the minimum requirements for fine-tuning the model finetune13b when using fsdp offload and flash attention. A more reasonable choice would be A100 40G8, in which case you won't need to use offload.

we have added the support through our integration with HF that can be set from here, and in effect from here.


Use the latest msodbcsql.h from ODBC 13.1

Coverage increased (+23.4%) to 75.235% when pulling 9e8b88a51f1cff07a501655b16f4343ff2222307 on yitam:msodbc into 45d87b7a96cb049e0cedb9e6302428a2ad1050a4 on Microsoft:dev.

Decided not to adopt msodbcsql.h as is.


Separate core, kernel and third party objects.

Add a second optimization level in the Makefile to enable different
levels between kernels and the rest of the TFLM code. This results in a
smaller binary with minimal performance impact compared with using a
single optimization level.
Allows the use of implicit patterns to compile all sources, choosing
different flags for core, kernel and third party sources.
The following measurements are taken using the hexagon toolchain +
hexagon-size and hexagon-sim.
For the keyword benchmark using -O2:
text    data     bss     dec
58140   37639   46612  142391
Cycles: 1700364
For the keyword benchmark using -O2 for kernels and -Oz for framework:
text    data     bss     dec
52796   37623   46612  137031
Cycles: 1759664

closing in favor of https://github.com/tensorflow/tflite-micro/pull/168


Creates bash script for autoformatting

Purpose:
Creates an autoformat.sh script, just like there's an autoformat.bat script. Note that the bash script doesn't pause until the user presses a key, as I don't know why that was there in the first place.
New Functionality:
Linux and Mac users can now use an autoformat script.
We could consider creating a ps1 script as well, but I don't know if that's necessary or not. Although PowerShell is cross-platform now.

This is a good idea - thanks for the PR!

Note that the bash script doesn't pause until the user presses a key, as I don't know why that was there in the first place.

Double-clicking the .bat file opens it in a console window. Without the pause it closes when it finishes so you can't see if changes were made. Seeing that the formatter did something may indicate a git commit (or reset) is required. I cringe to type this, but I suspect most .bat files on Windows are executed by double-clicking them rather than executing them from a terminal 😅
The .sh file doesn't need a pause because it was probably called from a terminal and the results won't disappear when it finishes running.

We could consider creating a ps1 script as well, but I don't know if that's necessary or not. Although PowerShell is cross-platform now.

While a ps1 script could do everything, I think the .bat and .sh extensions make it more obvious to developers that the autoformat scripts are supported on their platforms.


please

please

@gharm555 Thank you for your patience while waiting for a review and processing your request. Pull request merged. Please start applying for JetBrains educational subscription at https://www.jetbrains.com/shop/eform/students in an hour, to allow the changes to propagate through JetBrains systems.


language model unavailable

Copilot Chat Extension Version:
VS Code Version:
OS Version:
Logs:

Steps to Reproduce:
1.ask a question in copilot chat
2.

sign in to github fails

I don't see anyway to sign out from github in copilot extension


[BUG] Formatting of the Top Title is lost

Describe the bug
On the dev branch, If I write a Title and a text with formatting like 033[1m something \033[0m
The text formatting stay as it should be.
But the Title one loose its formatting.
To Reproduce
func main() {
        Box := box.New(box.Config{Px: 2, Py: 1, Type: "Single", Color: "Cyan", TitlePos: "Top"})
	Box.Print("\033[1mBroken\033[0m, sorry", "Btw \033[1mNot Broken\033[0m, very nice")
}

As you see Broken is not anymore Bold as it should be.
The output string is :
"\x1b[36m┌ Broken, sorry ──────────────┐\x1b[0m\n\x1b[36m│\x1b[0m"

When it should be :
"\x1b[36m┌ \x1b[1mBroken\x1b[0m\x1b[36m, sorry ──────────────┐\x1b[0m"

You have to somehow split by the reset tag \x1b[0m and add the color \x1b[36m after again.

Now I will take a look at this. Thanks

I am not able to figure out how I am gonna support Bold and Color ANSI Codes together because whenever I try to make an exception either the former or latter don't work correctly. Can you help how should I handle this?

I have an idea. I will try later.

I have found a way BUT, is it what you want to do, because it will allow developers to also change the color of the title (I mean they will be more free to change the color of the title by them self).
Once I have time I do a PR to show to you.

Fixed in https://github.com/Delta456/box-cli-maker/pull/22/commits/03e0487c5551b683d19d6cba3d02ddec804205ab


[BUILD] Add deduction guide for Interval

This avoids ctad-maybe-unsupported warning.

I remembered someone deleted it...weird

OK, I've read the previous commit message. Let's just bring it back.


Adds font weight options for form controls and custom select

This PR fixes #27327 by adding variables to change the font weight on form controls.
@MartijnCuppens am I missing something on custom forms?

Maybe we can also add something for .custom-file-label? If someone changes the font weight for inputs, I assume they also want this change to happen to custom file inputs?

Thanks a lot @MartijnCuppens!
I don't see the need to add a variable to change the font weight for the custom-file-label since that label will inherit the font weight of the body, while the input wouldn't. Am I wrong?

Ok done, thanks a lot @MartijnCuppens , as always you are awesome.


Remove rec keyword

fixes #36. It was harder than I thought because it required to traverse the AST looking for recursive callings taking shadowing into account.

This program doesn't parse Err(Unbound("foo"))
fn foo(x: Int): Int do
    if true do
        fn foo(x: Int) do
            x + 1
        end
        foo(x)
    else
        foo(x)
    end
end

foo

This program doesn't type check Err(Unbound("foo"))
Edit: switching the if arms it does...?
fn foo(x: Int): Int do
    if true do
        fn foo(x: Int) do
            x + 1
        end
        foo(x)
    else
        foo(x)
    end
end

foo

Oh wow, of course. I'm not taking conditionals into account at all! I'll fix it and add this as a test.

Heh I had to rebase because of the new changes but now it is ready. I'll wait for CI just in case

Heh I had to rebase because of the new changes but now it is ready. I'll wait for CI just in case


Extract exception classes to optuna.exceptions module.

Currently, 5 out of 9 classes defined in the optuna.structs module are exceptions. This PR introduces optuna.exceptions to manage the exception classes separately.
Although it changes more than 30 files, most of the changes just replace the module names.
Opinion Wanted
optuna.structs.TrialPruned is preserved for backward compatibility, but the other exceptions (i.e, OptunaError, CLIUsageError, StorageInternalError and DuplicatedStudyError) are not. This is partly because TrialPruned is usually raised in user programs, and partly because the other exceptions are mainly raised inside Optuna. If you have ideas to maintain all exceptions in optuna.structs, please let me know.

Just a question but would there be concerns placing TrialPruned under optuna.TrialPruned? I just though that it might make user code cleaner, but not sure it's worth it.

optuna.TrialPruned

@hvy
Thank you for your suggestion. That makes sense.
It also highlights TrialPruned that is usually used by users unlike the other exceptions. But it may be controversial, so let us discuss in another PR.

That sounds sound to me. 👍


allow gojira shell to accept --env bindings

[jmiller@euclid Kong]$ export ONE=one
[jmiller@euclid Kong]$ gojira shell --env ONE=$ONE --env TWO=two --env THREE=three -t master
[102a4363f069 kong]# echo "$ONE $TWO $THREE"
one two three
[102a4363f069 kong]# exit

Signed-off-by: Jeremy J. Miller<EMAIL_ADDRESS>

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

thanks @jeremymv2 !!
🚀


OSD-11907 Adding supporting service to support VPC endpoint service

Adding supporting service to support VPC endpoint service, still todo: resource cleanup, unit tests

Codecov Report

Merging #25 (b5f60e0) into main (2fff6f9) will decrease coverage by 1.47%.
The diff coverage is 0.00%.

:exclamation: Current head b5f60e0 differs from pull request most recent head 602385f. Consider uploading reports for the commit 602385f to get more accurate results

@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
- Coverage   39.50%   38.02%   -1.48%
==========================================
  Files          17       17
  Lines         772      802      +30
==========================================
  Hits          305      305
- Misses        435      465      +30
  Partials       32       32

Impacted Files
Coverage Δ

api/v1alpha1/vpcendpoint_types.go
100.00% <ø> (ø)

controllers/vpcendpoint/helpers.go
32.96% <0.00%> (-16.22%)
:arrow_down:

/lgtm
/approve


Newest version doesn't work

With the update 2022.6.2, I can't run my python files in terminal, the output keeps saying dumb stuff like  "No pyproject.toml file found", but i installed it like 5 mins ago. Downgrading the extension made it work, but please fix this! I use Windows 10 Education, 64-bit.

Thanks for the bug report, but unfortunately, we need some more information from you in order to triage this issue appropriately. Please follow instructions here to create a new bug with all the critical details we need for diagnosis.
@MegaDrive88 Please provide logs form Output > Python panel. Also, repro steps, if you can share your project where it fails and any details on where the "No pyproject.toml file found" is coming from helps. Please also share your settings as well. Please refrain from using feature-request when filing bugs.


Responses for encoded query param

Hello, Karl, I'm facing this issue: my team developed a feature that consists of an integration between a REST API to another REST API, however, this last one has a GET endpoint that receives a XML as query param.
Debugging our application, we find out that the Python library sends the request with the query param encoded, so I put the query value on Castlemock also encoded, but I'm always getting Internal Server Error, like it has no response, when, indeed, it was set to have.

Also, if I decode the URL, I get a valid XML, as you can see below:

I created a github repo to be used as volume (in case you want to use Docker) with the application I created on Castlemock. Here's the link: https://github.com/wedla/encodedQueryParam
Hope you can help me with this! I appreciatte since now all the help you can give me, and I wish a great weekend ;-)

Hi @wedla!
Great to hear from you again and thank you for raising this issue.
I looked into the issue and it seems that the query parameters gets decoded by default, which makes it a little bit problematic when doing pattern matching. The use case by sending XML might be uncommon. However, the scenario where you want to handle the parameters as encoded value seems like a valid use case.
I have added support so that you can specify that you want the parameter to be handled as an encoded value when creating query parameters. This should allow you to match with encoded parameters.
I will include this in the next release and hopefully be able to release a new version by the end of the day.
Cheers!

Dear @karldahlgren, I don't have enough words to thank you for all your support. Thank you very much for this, you're an amazing human being.
I wish all the best for you and your family.
I'm gonna close the issue since it is completed :) I tested it and it is ok.
Have a great week! Cheers!


Threads stops before storing messages

Threads are stopping before MessageIOService can store messages to local db.

Bug fix is merged with v2/main


⚠ ClamAV has degraded performance

In d055672, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 80 ms

Resolved: ClamAV performance has improved in 417b25d.


Add optimizer arguments for tuning ftol and xtol

Add optimizer arguments for 3 algos to tune stopping tolerances given by relative function improvement and step size.

@htwei17 Thank you for your contribution and for taking the time to submit this pull request.
After careful consideration with @nomuramasahir0, we have decided not to merge the changes at this time.
While we understand the utility of your proposed feature, our primary goal is to maintain the simplicity of the codebase in order to cater to the largest possible user base. So if you need to change the ftol and minstep parameters, please update them after object creation as follows:
cma = CMA(...)
cma._tolfun = ftol
cma._tolx = 1e-12 * min_step

Again, we appreciate your understanding and effort, and look forward to seeing future contributions.


mismatched quotes and parens

@elaineo there is another PR for this #117

thanks, didn't see it and wanted to get something I could use quickly.


make error

make
g++ -g -Wall -Wextra -std=c++14 -D__STDC_CONSTANT_MACROS -D__STDINT_MACROS -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE=1 -O3 -static -c kmer-counter.cpp -o kmer-counter.o
In file included from kmer-counter.cpp:1:0:
kmer-counter.hpp: In static member function ‘static int kmer_counter::KmerCounter::mkpath(const char*, mode_t)’:
kmer-counter.hpp:203:23: error: ‘runtime_error’ is not a member of ‘std’
throw std::runtime_error(msg_buf);
^
In file included from kmer-counter.hpp:30:0,
from kmer-counter.cpp:1:
hash_map.hpp: In instantiation of ‘emilib::HashMap<KeyT, ValueT, HashT, CompT>& emilib::HashMap<KeyT, ValueT, HashT, CompT>::operator=(const emilib::HashMap<KeyT, ValueT, HashT, CompT>&) [with KeyT = std::basic_string; ValueT = int; HashT = std::hash<std::basic_string >; CompT = emilib::HashMapEqualTo<std::basic_string >]’:
kmer-counter.hpp:216:93:   required from here
hash_map.hpp:196:32: error: ‘cbegin’ was not declared in this scope
insert(cbegin(other), cend(other));
^
hash_map.hpp:196:45: error: ‘cend’ was not declared in this scope
insert(cbegin(other), cend(other));
^
hash_map.hpp: In instantiation of ‘emilib::HashMap<KeyT, ValueT, HashT, CompT>::HashMap(const emilib::HashMap<KeyT, ValueT, HashT, CompT>&) [with KeyT = std::basic_string; ValueT = int; HashT = std::hash<std::basic_string >; CompT = emilib::HashMapEqualTo<std::basic_string >]’:
kmer-counter.cpp:64:31:   required from here
hash_map.hpp:184:32: error: ‘cbegin’ was not declared in this scope
insert(cbegin(other), cend(other));
^
hash_map.hpp:184:45: error: ‘cend’ was not declared in this scope
insert(cbegin(other), cend(other));
^
make: *** [kmer-counter] Error 1

I was not able to reproduce this error under Mac OS X 10.15.3 (Apple clang version 11.0.3 (clang-1<IP_ADDRESS>)) or Ubuntu 18.04.4 (GNU gcc 7.5.0, glibc 2.27).
However, the error messages suggest some adjustment to import statements, which I have applied in commit 9471498.
Please feel free to try this patch and let me know if it helps. If not, if you can please let me know what kind of environment you're running this under, that would help with troubleshooting.

I'm seeing these errors in Cygwin 2.0.4 (gcc 4.9.3).

I am not seeing these errors in Cygwin 3.1.4 (gcc 9.3.0).
Because the error messages with the older version of Cygwin were identical, I'm assuming that you're using Cygwin and so I'd recommend upgrading it and the development kit to the latest versions available to you.

https://cygwin.com/install.html
https://preshing.com/20141108/how-to-install-the-latest-gcc-on-windows

I'm going to close this up. Feel free to follow up if your environment is different.


python311Packages.jsonargparse: 4.27.3 -> 4.27.4

Diff: https://github.com/omni-us/jsonargparse/compare/refs/tags/v4.27.3...v4.27.4
Changelog: https://github.com/omni-us/jsonargparse/blob/4.27.4/CHANGELOG.rst
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 285873 run on x86_64-linux 1

4 packages built:

python311Packages.jsonargparse
python311Packages.jsonargparse.dist
python312Packages.jsonargparse
python312Packages.jsonargparse.dist


Fix another batch of unexpected errors in tests

This is just assorted low-hanging fruit.

Pushed to master.


[Bug] Avoid OOM (Out of Memory) for Playground-gravitino

Add Gravitino jvm mem options to prevent the Gravitino Server process from being killed by the kernel's OOM killer.
gravitino.env.sh.template
# export GRAVITINO_MEM         # Gravitino jvm mem options Default -Xms1024m -Xmx1024m -XX:MaxMetaspaceSize=512m

docker-compose.yaml
  gravitino:
    image: datastrato/gravitino:0.5.1
    deploy:
      resources:
        limits:
          cpus: "0.5"
          memory: 500m

[四 8月 22 10:12:09 2024] [1439660]     0 1439660  1702258   135715  1871872     3968             0 java
[四 8月 22 10:12:09 2024] oom-kill:constraint=CONSTRAINT_MEMCG,nodemask=(null),cpuset=docker-xxxxxxx.scope,mems_allowed=0,oom_memcg=/system.slice/docker-xxxxxxx.scope,task_memcg=/system.slice/docker-xxxxxxx.scope,task=java,pid=1439660,uid=0
[四 8月 22 10:12:09 2024] Memory cgroup out of memory: Killed process 1439660 (java) total-vm:6809032kB, anon-rss:504204kB, file-rss:38656kB, shmem-rss:0kB, UID:0 pgtables:1828kB oom_score_adj:0

Hello Junbo, several questions:

In which case you will get the OOM error?
I see you add a "gravitino.env.sh" file, but didn't see where it will be called. Will it be executed automatically?
I see you increase the docker memory from 500m to 1G, is that mandatory? Can we just keep the origin value?

Thanks for your PR!

In which case you will get the OOM error?

Use gravitino-playground default config and refresh the gravitino homepage several times.
Gravitino server default memory is 1g and docker container memory is 500m.

I see you add a "gravitino.env.sh" file, but didn't see where it will be called. Will it be executed automatically?

Yes, copy it to the conf directory and it will be executed automatically.

I see you increase the docker memory from 500m to 1G, is that mandatory? Can we just keep the origin value?

Not.The docker memory is 500m, and we set the Gravitino server to 384m?
export GRAVITINO_MEM=-Xms384m -Xmx384m -XX:MaxMetaspaceSize=128m

Thanks.

In which case you will get the OOM error?

Use gravitino-playground default config and refresh the gravitino homepage several times, I couldn't reproduce this time.
I will close this pr.

In which case you will get the OOM error?

Use gravitino-playground default config and refresh the gravitino homepage several times, I couldn't reproduce this time. I will close this pr.

Thank you for the PR; I will test it to see whether I can reproduce it.


bug fixes for max net metering benefit, multi-period and multi-tier demand charges

Fixed

Increased the big-M bound on maximum net metering benefit to prevent artificially low export benefits
Fixed a bug in which tier limits did not load correctly when the number of tiers vary by period in the inputs

addresses https://github.com/NREL/REopt.jl/issues/386

Checked and confirmed that these fixes address previous issues in results from these posts:
high_wholesale.json
high_energy_rate_max.json

@zolanaj Done reviewing with just two remaining comments!

Tagging issue https://github.com/NREL/REopt.jl/issues/297 ads this may be addressed now?
Also added issue https://github.com/NREL/REopt.jl/issues/297 for future bigM improvement.

Tagging issue #297 ads this may be addressed now?
Also added issue #297 for future bigM improvement.

Regarding #297 , documenting that currently the below (a) results in tier_limits: [100.0, 1.0e8] and (b) results in tier_limits: [1.0e8, 1.0e8]
(a)
"demandratestructure": [
                [
                    {
                        "max":<PHONE_NUMBER>00000000000000000000000000000,
                        "rate": 15
                    }
                ],
                [
                    {
                        "max": 100,
                        "rate": 25
                    },
                    {
                        "max":<PHONE_NUMBER>00000000000000000000000000000,
                        "rate": 35
                    }
                ]
            ],

(b)
[
                    {
                        "max": 100,
                        "rate": 25
                    },
                    {
                        "max":<PHONE_NUMBER>00000000000000000000000000000,
                        "rate": 35
                    }
                ],
                [
                    {
                        "max":<PHONE_NUMBER>00000000000000000000000000000,
                        "rate": 15
                    }
                ]

@adfarth Ready for you to check again!  There are more tests in the new set and the limits are now indexed on month (or ratchet).

@zolanaj Adding one more thing that we can definitely punt to another PR unless you think it makes sense to address here:
It looks like the ["ElectricUtility"]["interconnection_limit_kw"] is currently not getting applied to wholesale techs (only to net metering techs). I confirmed this by (looking at the constraints and) running a scenario with a wholesale rate and an interconnection limit. REopt sizes over the interconnection limit but still receives WHL compensation for exports.

It looks like the ["ElectricUtility"]["interconnection_limit_kw"] is currently not getting applied to wholesale techs (only to net metering techs). I confirmed this by (looking at the constraints and) running a scenario with a wholesale rate and an interconnection limit. REopt sizes over the interconnection limit but still receives WHL compensation for exports.

Great catch!  I'm adding an issue here: https://github.com/NREL/REopt.jl/issues/416

@zolanaj Approving with just a few comments requesting updates to help text and a few questions to help me understand the changes. Thanks for making these improvements and fixes!

Thanks for the thorough review @adfarth! after making some edits in response to this last round I will merge once tests are confirmed to pass.


Copying HTML table to spreadsheet software loses top left cell

Right now, if you copy the HTML table representation of a DataFrame to Google Sheets or Open office Calc, you lose the top left empty cell (and the top left cell gets the first column name, which is incorrect).
Inserting an   into that cell prevents this from happening. Would a PR be accepted which did this?
One way of achieving this is to set BLANK_VALUE to  . In Google documents then, the pasted cell is present but empty. In open office, the resulting cell has a single space in it (which seems OK).
I don't know what the wider implications of setting BLANK_VALUE are - I just want to set the upper left portion of the table so that the heading is correctly aligned when I copy the table. So maybe there is a better way?

Maybe it's also possible to achieve the desired effect by modifying the CSS on the .blank class?


Remove non-ASCII symbols in Sensor.hpp

Fixes #806

I'm not sure, there may be other non-ASCII symbols here...

You should also reencode the file as UTF-8 without BOM.

latin-1 is a superset of ASCII. Removing the special characters turns this into ASCII.
UTF-8 is a superset of ASCII. So you could say this file is already in "UTF-8 without BOM". I confirmed this by git clone -b patch-1 https://github.com/BlaXpirit/SFML: my text editor shows it as UTF-8.

Can you re-encode SensorImpl.mm as UTF-8 as well and HIDInputManager.mm (unless @mantognini says one shouldn't)?

I found the following non-ASCII source files:

examples/cocoa/NSString+stdstring.mm: UTF-8
position 2111: ©
src/SFML/Window/OSX/HIDInputManager.mm: UTF-8
position 31411: §
src/SFML/Window/OSX/SFApplication.m: UTF-8
position 3417: ⌘
src/SFML/Window/OSX/WindowImplCocoa.hpp: UTF-8
position 3414: ⌘
src/SFML/Window/OSX/SFWindow.h: UTF-8
position 2732: ’
src/SFML/Window/OSX/SFWindow.m: UTF-8
position 2223: ’
src/SFML/Window/iOS/SensorImpl.mm  latin-1
position 4003: ²

Out of all these I think only the last one needs changing.

OS X related files should already be utf-8 but if it's not the case they could be fixed of course.

For me HIDInputManager.mm seems to not be encoded as UTF-8, but maybe that's just me?

@BlaXpirit Can you check again the HIDInputManager.mm?
Otherwise, this PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

So I checked it for the third time. My text editor (Kate) shows HIDInputManager.mm as UTF-8.
chardetect shows it as TIS-620. So I tried to open that file as TIS-620 and encode as UTF-8, which only changed "§" into "ยง", leading me to think that:

It is not TIS-620
It is UTF-8
The only non-ASCII symbol in it is "§"

If § is causing trouble, it could be substituted by section sign (see Unicode U+00A7) in the comment on line 780

I think we should avoid non-ASCII characters whenever possible.

I think we should avoid non-ASCII characters whenever possible.

:+1:
There really isn't any reason why we should have to use non-ASCII characters in source code. This is C++, and not Java :stuck_out_tongue:.

© → (C)
§ → see next section
⌘ → Command Key
’ → '
’ → '
² → ^2

:+1:

I've replaced a lot of these characters. Now I can be sure I haven't missed anything:
export LC_ALL=C
find . -type f -print0 |
while IFS= read -r -d '' file; do
    grep --with-filename --line-number -P '[^ -~\r\n\t]' "$file" |
    grep --invert-match -P '/\.git/' |
    grep --invert-match '/extlibs/' |  # There is a ton of special characters in freetype
    grep --invert-match '^Binary file'
done

src/ is all done.
But I'm not sure how many commits this should be and what to do with these remaining things:

examples/cocoa/NSString+stdstring.mm:56: // work for characters like é or à.
examples/cocoa/resources/Cocoa-Info.plist:28: <string>Copyright © [...]</string>
examples/cocoa/MainMenu.xib:93: <string key="NSTitle">Preferences…</string>
examples/cocoa/MainMenu.xib:214: <string key="NSTitle">Open…</string>
examples/cocoa/MainMenu.xib:278: <string key="NSTitle">Save As…</string>
examples/cocoa/MainMenu.xib:316: <string key="NSTitle">Print…</string>
examples/cocoa/MainMenu.xib:448: <string key="NSTitle">Find…</string>
examples/cocoa/MainMenu.xib:1232: <string key="NSTitle">Customize Toolbar…</string>
doc/footer.html:5: Copyright © Laurent Gomila  ::
cmake/Macros.cmake:84: # [...] user’s frameworks/application bundle
readme.txt:15: Lukas Dürrenberger<EMAIL_ADDRESS>tools/xcode/templates/SFML/SFML CLT.xctemplate/main.cpp:11: // [...]"Edit Scheme…"[...]
CMakeLists.txt:230: # [...] user’s frameworks/application bundle

Regarding OS X related stuff, it should be alright like that. Two things: xib should not be manually edited -- I don't know how it can break things... --, secondly Xcode is "clever" and will substitute when you type some sequence of characters ((c), ..., etc.) with their unicode equivalent. So I guess we don't have to fear those too much on that OS.
Regarding the © in footer.html, it could probably be replaced by ©.
The ’ in Macros.cmake and CMakeLists.txt can be changed to ', of course.

@BlaXpirit Can you update the PR according to @mantognini's comment:

Regarding the © in footer.html, it could probably be replaced by ©.

The ’ in Macros.cmake and CMakeLists.txt can be changed to ', of course.

Feel free to squash the commits, other than that, this PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

:+1:


confused

very CONFUSED about what the advantage it is!
I lose the ability to combined thread!

优势就是灵活方便，整合过后更方便操作


$pull with $in fails in mock

I've tried the following:
db.collection.update({}, {'$pull': {'arr': {'$in': ['a1']}}})
This for a collection with documents in the form:
{         "b": 0,         "arr": [             "a1",             "a2"         ]     }
It's suppoed to the delete the 'a1' list item, but when using the mock I get:
pymongo.errors.OperationFailure: unknown top level operator: $in

Thanks for reporting. Actually the bug is not only for $in but any operator used in the condition. I'll create a fix.


[AMBARI-24522] Cannot connect to MIT KDC admin server when port is specified in kerberos-env/admin_server_host

What changes were proposed in this pull request?
Cannot connect to MIT KDC admin server when port is specified in kerberos-env/admin_server_host.  The following error is seen when validating the KDC admin credentials:
kinit: Server not found in Kerberos database while getting initial credentials

The reason for this is due to how the credentials are created for accessing the MIT KDC administration server.
kinit -c <path> -S kadmin/<kerberos-env/admin_server_host>  <principal>

If a port was added to the {{kerberos-env/admin_server_host}} value then the server principal will be generated like kadmin/kdc.example.com:4749 rather than kadmin/kdc.example.com. Therefore the server principal is not found.
How was this patch tested?
Manually tested.
Added new unit tests, all unit tests passed.
mvn clean test package  -DthreadCount=2  -pl ambari-server
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 29:45 min
[INFO] Finished at: 2018-08-21T18:38:15-04:00
[INFO] Final Memory: 103M/1464M
[INFO] ------------------------------------------------------------------------

Please review Ambari Contributing Guide before opening a pull request.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3702/
Test FAILed.
Test FAILured.


fatal error: caffe/proto/caffe.pb.h: No such file or directory

When I ran make all --jobs=4 I got:
In file included from ./include/caffe/util/device_alternate.hpp:40:0,
                 from ./include/caffe/common.hpp:19,
                 from ./include/caffe/blob.hpp:8,
                 from ./include/caffe/net.hpp:10,
                 from src/caffe/solver.cpp:7:
./include/caffe/util/cudnn.hpp:8:34: fatal error: caffe/proto/caffe.pb.h: No such file or directory
 #include "caffe/proto/caffe.pb.h"
                                  ^
compilation terminated.

I solved this by running:
$ protoc src/caffe/proto/caffe.proto --cpp_out=.
$ mkdir include/caffe/proto
$ mv src/caffe/proto/caffe.pb.h include/caffe/proto

Should those steps be in the Makefile?

Were you following the install instructions in the DIGITS README, or the default Caffe instructions? I've never run into that issue before (though a little googling shows that other people have). That step is definitely not necessary for everyone, so I'm not going to add it to the install instructions. Do you have any clues as to why you ran into this problem and I (and most others) didn't?

Not sure and when I built (nvidia fork of) caffe on another box, I did not observe.
Could there be some race with the parallel build?

Could there be some race with the parallel build?

I'm not sure what you mean. Were you building the multi-GPU branch of caffe? That's not going to work with DIGITS (yet).

No, the normal fork with standard build instructions. I was just spitballing if the make has some issue in when is runs protoc.

According to @moconnor725, this is a problem with the parallel build path in caffe. Try it without the --jobs=4 flag and see if you still get the error.

Also solved my problem, thank you!
@cancan101

I solved it by inputting the commands:
$ make clean
$ make all -j8

@yhlleo I try your method and it works. It is beacause the first time i try to bulid caffe, i dont use 'sudo', and so I get this error. Then I add 'sudo' in front of the command. But I still get the error, beacause the wrong building is still in the caffe folder. So I need to 'make clean' before 'sudo make all'.

@seashell9  Your answer helped me as well. I didn't include sudo and I got the error. I am not sure why. make all -j8 is also better than make -j8. Thanks.


How to change user password in this approach properly?

Hi!
As I think we need add user api with addition method like this:
rg.Put("/users/password/update", r.updatePassword)
then get user Id from token and then implement the methods for user in service, dao and model layers?
Is it correct in this approach?
But how to change the password of any user by an administrator??
Implement another new method like:
rg.Put("/users/<id>/password/update", r.updatePassword)?
Or I prefer to use only CRUD for this?

What you described is fine. Basically you rely on JWT to authenticate/identify the calling user.
Then you use the user ID to perform authorization check if you want to implement changing password by an admin. Using two separate endpoints makes sense to me.


Export Request/Response types from generated client?

👋  Loving the client generation feature! Is there currently a way to make it so that the generated Request and Response types are exported from the generated client? It'd be helpful for Typescript projects to be able to import those types into various places. For example, if I need to pass the response from a parent component into a child component in a React project, I'd want to access the response type so that I can add it to the Props in the child component.
generated client:
// currently, Request/Response types are not exported
type GetMeResponse = { }

parent component:
// using tanstack query in the parent component:
const { status, data, error, refetch } = useQuery({
    queryKey: ['me'],
    queryFn: () => apiClient.provide('get', '/v1/user/me', {})
  });

return <ChildComponent data={data} />

child component:
type Props = { data: GetMeResponse }
export default function ChildComponent(props: Props) {
   // child component code
}

Oops! This should probably go in the Discussion section. I'll move it over.

Also, I just realized that you can use the Response type :D ignore me!


added progress bar to the four problem pages

feat: Progress Bar
Summary
added four progress bar images to the "assets" folder and placed them at the bottom of each problem page in accordance with the figma design.
Closes #42

made changes to Progress1.tsx, Progress2.tsx, Progress3.tsx, Progress4.tsx to add the progress bar image to each page.
made changes to global.scss, Problem3.scss, and Problem4.scss to adjust the CSS and styling of the progress bar (make them centre align)

Test Plan
tested them on localhost:3000 with adjusting the size of my browser.

Note: make last progress image have dark grey lines for continuity


chore: update ziglyph url

ziglyph has been moved to Codeberg.org
https://github.com/jecolon/ziglyph

When you accept this PR, create a new release (like 0.8.1)!!
I really like this lib! Thanks

@ryoppippi I'll look at this sometime later this week. Thank you for bringing this to my attention!

I really like this lib! Thanks

Thanks! Glad it is helpful for you!

Just a heads up, the 11.0.1 tarball you referenced here is incompatible with the old ziglyph API. I'm going to close this an implement it myself because there are some breaking changes. Thanks for bringing this to my attention!

And btw, I'm going to do some thorough testing over the next day, and then I will release a 0.9.0 version of zf!

Great! Thanks!!!!


Update setup.sh

Update so that will run properly no matter where the command is run from. Prevent problem when setup.sh is run from a directory other than where setup.sh is located.

Not correct


Webpack keeps compiling

Do you want to request a feature or report a bug?
Report a bug
What is the current behavior?
My bundle gets compiled several times.
If the current behavior is a bug, please provide the steps to reproduce.
I'm creating a webpack boilerplate for my personal projects, you can check it on this repo on the cleanup branch https://github.com/alejandronanez/webpack-boilerplate/tree/cleanup

npm start
Add a few lines to src/styles/app.scss - a few empty new lines will do the trick
CTRL + C to stop the process
npm start again
You should start seeing the bundle compiles on a loop for a while, and then it will stop

Here's a GIF with what is happening:

What is the expected behavior?
The looping should not occur.
If this is a feature request, what is motivation or use case for changing the behavior?
Please mention other relevant information such as the browser version, Node.js version, webpack version and Operating System.
node: 8.1.3 && LTS
npm: 5.1.0
OSX: 10.12.5
webpack version: 3.1.0 && 2.6.1

@alejandronanez  The latest version of GitBash on windows 10 happened same as this to me with the  webpack v2xx & v3xx so i went back to GitBash version v2.13.0-64-bit because the ctrl+c is not terminating the nodejs and keep running compiling in the background but the window's terminal does the terminate. no idea that the issue is related with this or not.Thanks

I managed to get the behavior exactly once on iTerm. It's random like that to me and I have no clue what could be causing it.

Probably this is a duplicate of that one:
https://github.com/webpack/watchpack/issues/25

I had this exact issue and had to opt out a ton of stuff manually from watchpack.
{
  watchOptions: {ignored: [...lotsOfDirectories]}
}

This wasn't happening in the past and it's a really aggravating thing to have to hack like this.

I am having this exact issue in<EMAIL_ADDRESS>Similar to @bfricka wasn't happening in the past.

a workaround here

Should work with webpack@latest. Feel free to report new issue with reproducible repo.


Pull from upstream

I need changes from there

@Blewin I've tested the updated Juniper_dev branch in the other app. Nothing breaks. All you need to do is delete the installed dependency and run npm i one more time to get this update.

@ZheyangSong Thank you very much! works perfectly


[Suggestion/Improvement] Compatibility with Mekanism

Hey!
I really love EMI, but I'm forced to go back to JEI since EMI does not support some mods like Mekanism.
Maybe adding support for it is a possibility?

Oh, I'm sorry for not reading correctly!
I thought it was incompatible with JEI

Abbie is correct, the compat exists. If it did not, JEI and EMI do not add support for mods, it goes the other way around. Regardless, this issue is resolved.


Adding bash completion and helper scripts

This patch adds some bash helper scripts.

docker-machine.bash - command completion for docker-machine
docker-machine-prompt.bash - function for putting the active machine
name in PS1
docker-machine-wrapper.bash - function wrapper adding an eval
command that runs eval $(docker-machine env whatever) in the
current shell.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "completion" git@github.com:leedm777/machine.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Thank you!
/cc @albers

+1 for docker-machine eval <env>!

I'll add my +1 as well....

I wonder if the helper scripts (prompt, eval) should be in the "completions" directory or moved somewhere else inside "contrib"; I can imagine some people wanting the completions installed, but not those helpers

@thaJeztah I debated that. The prompt function is harmless if you don't put it in your PS1. The eval wrapper can be disabled by setting DOCKER_MACHINE_WRAPPED to false prior to sourcing the script. That feels "good enough" to me, but I would not object strongly to reorganizing.
The advantage of keeping them together is that if someone wants completion, they probably want the other shell stuff as well. Similarly, if they disable completion then the probably don't want the other shell bloat.
FWIW, Git put its prompt script in its completion directory, which made me feel better about doing it this way.

@nathanleclaire wdyt?

Also, #1309 was attempted before. Anything to merge from there?

@leedm777 thanks, I'm not a maintainer in this repository, and no strong opinion, apart from trying to keep consistency between the various docker repositories. Just thought I'd mention it.
Thanks so much though, for creating this!

I'm interested (and thanks for putting this together @leedm777 !), need a chance to review a bit more thoroughly, but two things stand out as needing improvement:

I'd prefer docker-machine use to docker-machine eval
It needs documentation, however, I'm not sure the right place (Installation?) so I'm open to suggestions there.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "completion" git@github.com:leedm777/machine.git somewhere
$ cd somewhere
$ git rebase -i HEAD~3
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

@nathanleclaire I've added docs, and changed eval to use. Any further thoughts?

Putting docker-machine status in PS1 is going to make the terminal pretty slow, so I'm hesitant to recommend it directly.

@thaJeztah Thanks for pointing me to this, and sorry for the delay.
I'm not familiar with docker-machine because I could not get it working in several previous attempts. I'll go for it next weekend.
@leedm777 Thanks for your work. On first sight it looks very impressive!

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "completion" git@github.com:leedm777/machine.git somewhere
$ cd somewhere
$ git rebase -i HEAD~4
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

@albers thanks for looking; I am happy already with you just giving it a quick look to see if there are possible issues or inconsistencies with the other projects :+1:

@moxiegirl Is that better :-)

@leedm777 thank you. Very glad to help your really helpful contribution!  LGTM

OK looks pretty good, I have a few docs nits, and just one more suggestion for the UX:  If you type docker-machine use by itself, it should spit back the help text just like docker-machine use --help does.

I think I've addressed all the feedback. This history was getting ugly, so I rebased on master and squashed to a single commit.
Thanks to everyone for all the feedback!

Great work @leedm777 !

LGTM

OK, so there won' be any more need for my feedback.

Sorry for that @albers, I wasn't aware @nathanleclaire was gonna merge before you had the chance to give feedback :blush:


Query next task time

I would like to be able to output something like "Processed data succesfully. Will process again at _____." Could the scheduler support querying when the next task is scheduled for?

This gets awkward because we don't know when the next execution will begin until the current execution has ended, so we can't just cheekily sneak this functionality into an existing task.

I've found that robfig's cron package has suited my needs for this, as they make the simpler assumption that all tasks are scheduled based on rate, not delay.


Minor perf improvements in BasePathStrategy and  RemoteAuthenticationCallbackStrategy

This PR will reduce (some) allocations in RemoteAuthenticationCallbackStrategy and BasePathStrategy.
RemoteAuthenticationCallbackStrategy
Instead of ToLowerInvariant() ==  comparison, use string.Equals(a,b,StringComparison.OrdinalIgnoreCase)
BasePathStrategy
Stop splitting the path segments after 2 entries have been found, this optimizes for paths with lots of segments.

:tada: This PR is included in version 6.11.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


GPT2 Cosine Similarity & Collections Search

Use the transformer GPT2 model to get embeddings for labels and get cosine similarity of search terms. Once the model is functional, will attempt to compute embeddings for a collections search on PDS data.

@AmandaMichelleR tokenizing through HuggingFace transformer; converting into Tensors, then into embeddings, then cosine similarities into embeddings in XML labels. Doing best! 🎉

Closed, what can be fixed has been fixed for the short term needs.