HBASE-22978 : Online slow response log

Jira: https://issues.apache.org/jira/browse/HBASE-22978

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

:blue_heart:
reexec
0m 35s
Docker mode activated.

_ Prechecks _

:green_heart:
dupname
0m  1s
No case conflicting files found.

:blue_heart:
prototool
0m  0s
prototool was not available.

:green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

:green_heart:
@author
0m  0s
The patch does not contain any @author tags.

:green_heart:
test4tests
0m  0s
The patch appears to include 4 new or modified test files.

_ master Compile Tests _

:blue_heart:
mvndep
0m 37s
Maven dependency ordering for branch

:green_heart:
mvninstall
5m 17s
master passed

:green_heart:
compile
2m 59s
master passed

:green_heart:
checkstyle
2m 43s
master passed

:blue_heart:
refguide
5m 36s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

:green_heart:
shadedjars
4m 38s
branch has no errors when building our shaded downstream artifacts.

:green_heart:
javadoc
5m  8s
master passed

:blue_heart:
spotbugs
1m 19s
Used deprecated FindBugs config; considering switching to SpotBugs.

:green_heart:
findbugs
23m  1s
master passed

_ Patch Compile Tests _

:blue_heart:
mvndep
0m 16s
Maven dependency ordering for patch

:green_heart:
mvninstall
4m 57s
the patch passed

:green_heart:
compile
3m  2s
the patch passed

:green_heart:
cc
3m  2s
the patch passed

:green_heart:
javac
3m  2s
the patch passed

:green_heart:
checkstyle
2m 35s
root: The patch generated 0 new + 488 unchanged - 1 fixed = 488 total (was 489)

:broken_heart:
rubocop
0m 18s
The patch generated 19 new + 490 unchanged - 0 fixed = 509 total (was 490)

:green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

:green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

:blue_heart:
refguide
5m 29s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

:green_heart:
shadedjars
4m 35s
patch has no errors when building our shaded downstream artifacts.

:green_heart:
hadoopcheck
15m 38s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

:green_heart:
hbaseprotoc
8m 28s
the patch passed

:green_heart:
javadoc
5m 10s
the patch passed

:green_heart:
findbugs
24m  8s
the patch passed

_ Other Tests _

:broken_heart:
unit
174m 51s
root in the patch failed.

:green_heart:
asflicense
3m 53s
The patch does not generate ASF License warnings.

311m 58s

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestAsyncTableGetMultiThreaded

Subsystem
Report/Notes

Docker
Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/754

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop

uname
Linux f6598088ebf9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-754/out/precommit/personality/provided.sh

git revision
master / 42d535a57a

Default Java
1.8.0_181

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/2/artifact/out/branch-site/book.html

rubocop
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/2/artifact/out/diff-patch-rubocop.txt

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/2/artifact/out/patch-site/book.html

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/2/artifact/out/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/2/testReport/

Max. process+thread count
4632 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift hbase-shell . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/2/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.75.1

Powered by
Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

Requesting your reviews @apurtell @busbey

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

:blue_heart:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

:green_heart:
dupname
0m  1s
No case conflicting files found.

:blue_heart:
prototool
0m  0s
prototool was not available.

:green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

:green_heart:
@author
0m  0s
The patch does not contain any @author tags.

:green_heart:
test4tests
0m  0s
The patch appears to include 4 new or modified test files.

_ master Compile Tests _

:blue_heart:
mvndep
0m 37s
Maven dependency ordering for branch

:green_heart:
mvninstall
5m 17s
master passed

:green_heart:
compile
3m  0s
master passed

:green_heart:
checkstyle
2m 42s
master passed

:blue_heart:
refguide
5m 29s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

:green_heart:
shadedjars
4m 36s
branch has no errors when building our shaded downstream artifacts.

:green_heart:
javadoc
5m  1s
master passed

:blue_heart:
spotbugs
1m 21s
Used deprecated FindBugs config; considering switching to SpotBugs.

:green_heart:
findbugs
23m 15s
master passed

_ Patch Compile Tests _

:blue_heart:
mvndep
0m 15s
Maven dependency ordering for patch

:green_heart:
mvninstall
4m 58s
the patch passed

:green_heart:
compile
3m  7s
the patch passed

:green_heart:
cc
3m  7s
the patch passed

:green_heart:
javac
3m  7s
the patch passed

:green_heart:
checkstyle
2m 47s
root: The patch generated 0 new + 488 unchanged - 1 fixed = 488 total (was 489)

:broken_heart:
rubocop
0m 18s
The patch generated 19 new + 490 unchanged - 0 fixed = 509 total (was 490)

:green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

:green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

:blue_heart:
refguide
5m 50s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

:green_heart:
shadedjars
4m 44s
patch has no errors when building our shaded downstream artifacts.

:green_heart:
hadoopcheck
15m 44s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

:green_heart:
hbaseprotoc
8m 35s
the patch passed

:green_heart:
javadoc
5m  9s
the patch passed

:green_heart:
findbugs
24m 11s
the patch passed

_ Other Tests _

:broken_heart:
unit
212m 22s
root in the patch failed.

:green_heart:
asflicense
4m 16s
The patch does not generate ASF License warnings.

350m 53s

Reason
Tests

Failed junit tests
hadoop.hbase.replication.TestVerifyReplication

Subsystem
Report/Notes

Docker
Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/754

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop

uname
Linux 4a215c6d161b 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-754/out/precommit/personality/provided.sh

git revision
master / 3ccfd50bd9

Default Java
1.8.0_181

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/3/artifact/out/branch-site/book.html

rubocop
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/3/artifact/out/diff-patch-rubocop.txt

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/3/artifact/out/patch-site/book.html

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/3/artifact/out/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/3/testReport/

Max. process+thread count
5542 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift hbase-shell . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/3/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.76.0

Powered by
Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 4 new or modified test files.

_ master Compile Tests _

+0 :ok:
mvndep
0m 35s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 14s
master passed

+1 :green_heart:
compile
3m  3s
master passed

+1 :green_heart:
checkstyle
2m 45s
master passed

+0 :ok:
refguide
5m 28s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
4m 33s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
4m 59s
master passed

+0 :ok:
spotbugs
1m 20s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
22m 48s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  0s
the patch passed

+1 :green_heart:
compile
3m  2s
the patch passed

+1 :green_heart:
cc
3m  2s
the patch passed

+1 :green_heart:
javac
3m  2s
the patch passed

+1 :green_heart:
checkstyle
2m 38s
root: The patch generated 0 new + 464 unchanged - 1 fixed = 464 total (was 465)

-1 :x:
rubocop
0m 17s
The patch generated 19 new + 490 unchanged - 0 fixed = 509 total (was 490)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+0 :ok:
refguide
5m 22s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
4m 33s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
15m 40s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
hbaseprotoc
8m 23s
the patch passed

+1 :green_heart:
javadoc
5m 13s
the patch passed

+1 :green_heart:
findbugs
24m 17s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
249m 28s
root in the patch passed.

+1 :green_heart:
asflicense
4m 47s
The patch does not generate ASF License warnings.

386m 56s

Subsystem
Report/Notes

Docker
Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/754

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop

uname
Linux 3e5c2ad61456 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-754/out/precommit/personality/provided.sh

git revision
master / 34661050c8

Default Java
1.8.0_181

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/4/artifact/out/branch-site/book.html

rubocop
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/4/artifact/out/diff-patch-rubocop.txt

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/4/artifact/out/patch-site/book.html

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/4/testReport/

Max. process+thread count
5441 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift hbase-shell . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/4/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.76.0

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Please review @apurtell @busbey @guangxuCheng

Please review @anoopsjohn @saintstack

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m  1s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 4 new or modified test files.

_ master Compile Tests _

+0 :ok:
mvndep
0m 35s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 14s
master passed

+1 :green_heart:
compile
2m 59s
master passed

+1 :green_heart:
checkstyle
2m 40s
master passed

+0 :ok:
refguide
5m 29s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
4m 35s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
5m  6s
master passed

+0 :ok:
spotbugs
1m 20s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
23m  0s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 56s
the patch passed

+1 :green_heart:
compile
3m  2s
the patch passed

+1 :green_heart:
cc
3m  2s
the patch passed

+1 :green_heart:
javac
3m  2s
the patch passed

+1 :green_heart:
checkstyle
2m 44s
root: The patch generated 0 new + 450 unchanged - 1 fixed = 450 total (was 451)

-1 :x:
rubocop
0m 18s
The patch generated 19 new + 490 unchanged - 0 fixed = 509 total (was 490)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+0 :ok:
refguide
5m 29s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
4m 36s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
15m 44s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
hbaseprotoc
8m 23s
the patch passed

+1 :green_heart:
javadoc
5m  8s
the patch passed

+1 :green_heart:
findbugs
24m  2s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
243m  7s
root in the patch passed.

+1 :green_heart:
asflicense
4m 49s
The patch does not generate ASF License warnings.

382m  7s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/754

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop

uname
Linux c7335fdf852d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-754/out/precommit/personality/provided.sh

git revision
master / dbbba7932c

Default Java
1.8.0_181

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/1/artifact/out/branch-site/book.html

rubocop
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/1/artifact/out/diff-patch-rubocop.txt

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/1/artifact/out/patch-site/book.html

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/1/testReport/

Max. process+thread count
5492 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift hbase-shell . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.76.0

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@guangxuCheng Could you please review?

Please review @ramkrish86

Please review @xcangCRM

those rubocop warnings are still need to be fixed. @virajjasani  thanks

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  1s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 4 new or modified test files.

_ master Compile Tests _

+0 :ok:
mvndep
0m 35s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 11s
master passed

+1 :green_heart:
compile
2m 57s
master passed

+1 :green_heart:
checkstyle
2m 41s
master passed

+0 :ok:
refguide
5m 29s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
4m 35s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
5m  6s
master passed

+0 :ok:
spotbugs
1m 21s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
23m 21s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 58s
the patch passed

+1 :green_heart:
compile
3m  4s
the patch passed

+1 :green_heart:
cc
3m  4s
the patch passed

+1 :green_heart:
javac
3m  4s
the patch passed

+1 :green_heart:
checkstyle
2m 41s
root: The patch generated 0 new + 446 unchanged - 1 fixed = 446 total (was 447)

+1 :green_heart:
rubocop
0m  9s
There were no new rubocop issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+0 :ok:
refguide
5m 33s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
4m 31s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
15m 38s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
hbaseprotoc
8m 27s
the patch passed

+1 :green_heart:
javadoc
5m 12s
the patch passed

+1 :green_heart:
findbugs
24m 37s
the patch passed

_ Other Tests _

-1 :x:
unit
177m 57s
root in the patch failed.

+1 :green_heart:
asflicense
3m 49s
The patch does not generate ASF License warnings.

315m 18s

Reason
Tests

Failed junit tests
hadoop.hbase.master.assignment.TestOpenRegionProcedureHang

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/754

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop

uname
Linux aef92e215afd 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-754/out/precommit/personality/provided.sh

git revision
master / 17e180e4ee

Default Java
1.8.0_181

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/2/artifact/out/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/2/artifact/out/patch-site/book.html

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/2/artifact/out/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/2/testReport/

Max. process+thread count
4997 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift hbase-shell . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/2/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.77.0

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@saintstack I will start creating necessary sub-tasks to this. For now, having ring buffer might be a good addition to 2.3.0 release for debugging slow RPC calls.
Please review

Please review @ndimiduk

Since the detailed info is going through this ring buffer subsystem, why do we continue to log at all? Why not replace the logging with a metric?

Ring Buffer is not a replacement of slow logs that we write to file, it's just a complete representation of slow logs, whereas in log files we might have trimmed logs. We also have plan to write all slowlogs to HDFS (optionally) and provide HDFS file path to user optionally, at that time we can think of removing logging in log files. However, I am not sure about metric. Which metric are you suggesting to expose? You mean slow logs with some parameters?

I'm suggesting we do away with file logging and instead expose the presence of slow activity as a (new?) metric.
By the time this patch lands, we'll have the logged information in two places, neither of which, on their own, allow an operator to easily see how prevalent the problem is. I'm suggesting that we could instead provide a metric that says "this region server is experiencing N slow request per time interval T", as well as providing detailed incident fidelity via this new mechanism.

Since the detailed info is going through this ring buffer subsystem, why do we continue to log at all? Why not replace the logging with a metric?

Ring Buffer is not a replacement of slow logs that we write to file, it's just a complete representation of slow logs, whereas in log files we might have trimmed logs. We also have plan to write all slowlogs to HDFS (optionally) and provide HDFS file path to user optionally, at that time we can think of removing logging in log files. However, I am not sure about metric. Which metric are you suggesting to expose? You mean slow logs with some parameters?

I'm suggesting we do away with file logging and instead expose the presence of slow activity as a (new?) metric.
By the time this patch lands, we'll have the logged information in two places, neither of which, on their own, allow an operator to easily see how prevalent the problem is. I'm suggesting that we could instead provide a metric that says "this region server is experiencing N slow request per time interval T", as well as providing detailed incident fidelity via this new mechanism.

Thanks @ndimiduk
Would you be fine with exposing metric as a sub task?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 41s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  1s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 6 new or modified test files.

_ master Compile Tests _

+0 :ok:
mvndep
0m 38s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 53s
master passed

+1 :green_heart:
compile
3m 28s
master passed

+1 :green_heart:
checkstyle
2m 40s
master passed

+0 :ok:
refguide
6m  1s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
5m 46s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
6m  0s
master passed

+0 :ok:
spotbugs
1m 28s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
24m 59s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 19s
the patch passed

+1 :green_heart:
compile
3m  7s
the patch passed

+1 :green_heart:
cc
3m  7s
the patch passed

+1 :green_heart:
javac
3m  7s
the patch passed

-1 :x:
checkstyle
2m 22s
root: The patch generated 1 new + 448 unchanged - 2 fixed = 449 total (was 450)

+1 :green_heart:
rubocop
0m 10s
There were no new rubocop issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+0 :ok:
refguide
5m  1s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
4m 46s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
16m 58s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
hbaseprotoc
8m 54s
the patch passed

+1 :green_heart:
javadoc
5m 28s
the patch passed

+1 :green_heart:
findbugs
26m 54s
the patch passed

_ Other Tests _

-1 :x:
unit
67m  1s
root in the patch failed.

+1 :green_heart:
asflicense
2m 50s
The patch does not generate ASF License warnings.

213m 59s

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestMobRestoreSnapshotFromClientAfterSplittingRegions

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/754

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop

uname
Linux 671e23b0a005 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-754/out/precommit/personality/provided.sh

git revision
master / 12f98bc50e

Default Java
1.8.0_181

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/10/artifact/out/branch-site/book.html

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/10/artifact/out/diff-checkstyle-root.txt

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/10/artifact/out/patch-site/book.html

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/10/artifact/out/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/10/testReport/

Max. process+thread count
7407 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift hbase-shell . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/10/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.79.0

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 6 new or modified test files.

_ master Compile Tests _

+0 :ok:
mvndep
0m 37s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 12s
master passed

+1 :green_heart:
compile
3m  0s
master passed

+1 :green_heart:
checkstyle
2m 24s
master passed

+0 :ok:
refguide
4m 49s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
4m 37s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
5m  7s
master passed

+0 :ok:
spotbugs
1m 20s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
23m 34s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  0s
the patch passed

+1 :green_heart:
compile
3m  1s
the patch passed

+1 :green_heart:
cc
3m  1s
the patch passed

+1 :green_heart:
javac
3m  1s
the patch passed

+1 :green_heart:
checkstyle
2m 22s
root: The patch generated 0 new + 448 unchanged - 2 fixed = 448 total (was 450)

+1 :green_heart:
rubocop
0m  9s
There were no new rubocop issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+0 :ok:
refguide
4m 45s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
4m 39s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
16m  1s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
hbaseprotoc
8m 20s
the patch passed

+1 :green_heart:
javadoc
5m 13s
the patch passed

+1 :green_heart:
findbugs
24m 59s
the patch passed

_ Other Tests _

-1 :x:
unit
68m 14s
root in the patch failed.

+1 :green_heart:
asflicense
3m 47s
The patch does not generate ASF License warnings.

204m 46s

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestAsyncTableGetMultiThreaded

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/754

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop

uname
Linux b15bffec8f8b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-754/out/precommit/personality/provided.sh

git revision
master / 12f98bc50e

Default Java
1.8.0_181

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/11/artifact/out/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/11/artifact/out/patch-site/book.html

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/11/artifact/out/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/11/testReport/

Max. process+thread count
7240 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift hbase-shell . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/11/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.79.0

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

2. IMHO if we are going to achieve significant resource utilization with TTL of ring buffer entries, we can have a sub-task to this Jira, but do we really need it? I feel it's fine to let them stay in the buffer. Anyways size of the buffer and whether to even use ring buffer is up-to user. However, if required, I am fine with a sub-task.

It is a fixed size of memory, and a relatively small amount, so I guess it's not a big deal. I just thought it would be good to free memory when we can. I see why this would be a bit of a hassle -- you'd need a cleaner chore and the Disruptor API is probably not designed for ad-hoc removal. I guess just omit it for now.

I think you misunderstood me here...
"With the patch we would run at RS entrance only and for any slow running query it will go to this ring buffer running at RS. Just that this patch doesn't include storing slow logs in HDFS, which is also a good idea and probably up for a subtask given the priority is storing slow logs in ring buffer first. Storing them in HDFS would be just an option as part of another Jira(sub-task)."
What I was saying is that your ringbuffer only keeps dfsclient ops. I was wondering if we could put actual requests into a system like this. If they are taking a long time, we could inspect the ringbuffer to see which type of queries are taking a while. It would be coarser grained than the dfs accesses only. Was just wondering if you think we could do this in a follow-on based on work h ere.

You sure about that @saintstack ? My read here is that we're logging the HBase client RPCs, sitting at the "front door" in so much as it's being done in RpcServer#call. I don't see HDFS client ops involved here.

Thanks for addressing all my concerns so far @virajjasani . I've tried to resolve all the inline discussions. Here's a summary of what I think remains outstanding.

log large responses (follow-on task)?

don’t assume “tooLarge” and “tooSlow” are mutually exclusive.

replicate log entries into a file on HDFS or a new system table (follow-on task)?
expose slow/large responses as a metric (follow-on task)?
do we need to ship with thrift api parity?
push filter and limit logic into the server, so all clients have the same experience

I think this requires adding a TooSlowRequest protobuf message with filter and limit parameters
Maybe then SlowLogPayload is renamed to SlowLogRecord or something like that

need separation of concerns between SlowLog.toString and formatting of output in the shell
avoid adding to the surface area of HConstants
proper interrupt handling within SlowLogEventHandler
update configuration adoc to reference the feature adoc
test cleanup

avoid sleeping for fixed time units, instead use waitFor
maybe combine some methods containing repeated logic, introduce a helper method or two

Thanks for addressing all my concerns so far @virajjasani . I've tried to resolve all the inline discussions. Here's a summary of what I think remains outstanding.

log large responses (follow-on task)?

don’t assume “tooLarge” and “tooSlow” are mutually exclusive.

replicate log entries into a file on HDFS or a new system table (follow-on task)?

expose slow/large responses as a metric (follow-on task)?

do we need to ship with thrift api parity?

push filter and limit logic into the server, so all clients have the same experience

I think this requires adding a TooSlowRequest protobuf message with filter and limit parameters
Maybe then SlowLogPayload is renamed to SlowLogRecord or something like that

need separation of concerns between SlowLog.toString and formatting of output in the shell

avoid adding to the surface area of HConstants

proper interrupt handling within SlowLogEventHandler

update configuration adoc to reference the feature adoc

test cleanup

avoid sleeping for fixed time units, instead use waitFor
maybe combine some methods containing repeated logic, introduce a helper method or two

Thanks @ndimiduk for all your review. I have tried to cover these points in my recent commit except for need separation of concerns between SlowLog.toString and formatting of output in the shell. The reason being shell is not able to use Gson as efficiently as keeping Gson.toJson() in toString of SlowLogRecord because we have some serialization filters (neither does shell have any good pretty print library that works with our POJO - AFAIK). shell or any client would receive List<SlowLogRecord> as output of Admin.getSlowLogResponses(). In a way, keeping Gson.toJson() within toString() would ensure all clients can print output in pretty print format. Do you think this is good to maintain uniform print format across all clients?
I have covered other points provided by you, please review.
Thanks

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 6 new or modified test files.

_ master Compile Tests _

+0 :ok:
mvndep
0m 38s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 13s
master passed

+1 :green_heart:
compile
3m  2s
master passed

+1 :green_heart:
checkstyle
2m 24s
master passed

+0 :ok:
refguide
4m 54s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
4m 40s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
5m 10s
master passed

+0 :ok:
spotbugs
1m 23s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
23m 31s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  0s
the patch passed

+1 :green_heart:
compile
3m  3s
the patch passed

+1 :green_heart:
cc
3m  3s
the patch passed

+1 :green_heart:
javac
3m  3s
the patch passed

-1 :x:
checkstyle
2m 25s
root: The patch generated 3 new + 448 unchanged - 2 fixed = 451 total (was 450)

+1 :green_heart:
rubocop
0m  9s
There were no new rubocop issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+0 :ok:
refguide
4m 46s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
4m 39s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
15m 51s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
hbaseprotoc
8m 28s
the patch passed

+1 :green_heart:
javadoc
5m 18s
the patch passed

+1 :green_heart:
findbugs
24m 30s
the patch passed

_ Other Tests _

-1 :x:
unit
73m 34s
root in the patch failed.

+1 :green_heart:
asflicense
3m 47s
The patch does not generate ASF License warnings.

210m  6s

Reason
Tests

Unreaped Processes
root:4

Subsystem
Report/Notes

Docker
Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/12/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/754

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop

uname
Linux 78043d41d52c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-754/out/precommit/personality/provided.sh

git revision
master / 488c2b2483

Default Java
1.8.0_181

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/12/artifact/out/branch-site/book.html

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/12/artifact/out/diff-checkstyle-root.txt

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/12/artifact/out/patch-site/book.html

Unreaped Processes Log
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/12/artifact/out/patch-unit-root-reaper.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/12/artifact/out/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/12/testReport/

Max. process+thread count
8923 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift hbase-shell . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/12/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.79.0

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

I have tried to cover these points in my recent commit except for need separation of concerns between SlowLog.toString and formatting of output in the shell. The reason being shell is not able to use Gson as efficiently as keeping Gson.toJson() in toString of SlowLogRecord because we have some serialization filters (neither does shell have any good pretty print library that works with our POJO - AFAIK). shell or any client would receive List<SlowLogRecord> as output of Admin.getSlowLogResponses(). In a way, keeping Gson.toJson() within toString() would ensure all clients can print output in pretty print format. Do you think this is good to maintain uniform print format across all clients?

No, I do not thing it's good to maintain uniform print format across all client. Anything that is providing display functionality for an object will need control over how the content is formatted.
I maintain that pretty-printed json does not belong in the object's toString method. The abundantly common use-case for toString is the logging infrastructure, which has different requirements from the shell's user interface. Please just use the Apache Commons Lang ToStringBuilder (I prefer it's SHORT_PREFIX_STYLE) for that purpose.
If you would like the object to control it's own formatting as a convenience to a variety of clients (something I find dubious but why not), I have no problem with putting this concern behind a separate method in SlowLogRecord, such as toFormattedJson. My main objection to this approach is that this introduces a dependency into SlowLogRecord, what is otherwise a simple POJO, onto an unrelated provider of json representation.
Also, you may not have noticed that the shell has it's own class for handling display, called Formatter, under hbase-shell/src/main/ruby/shell/formatter.rb. I haven't used it myself, but it seems purpose-built to handle the use-case you have.

No, I do not thing it's good to maintain uniform print format across all client. Anything that is providing display functionality for an object will need control over how the content is formatted.
I maintain that pretty-printed json does not belong in the object's toString method. The abundantly common use-case for toString is the logging infrastructure, which has different requirements from the shell's user interface. Please just use the Apache Commons Lang ToStringBuilder (I prefer it's SHORT_PREFIX_STYLE) for that purpose.
If you would like the object to control it's own formatting as a convenience to a variety of clients (something I find dubious but why not), I have no problem with putting this concern behind a separate method in SlowLogRecord, such as toFormattedJson. My main objection to this approach is that this introduces a dependency into SlowLogRecord, what is otherwise a simple POJO, onto an unrelated provider of json representation.
Also, you may not have noticed that the shell has it's own class for handling display, called Formatter, under hbase-shell/src/main/ruby/shell/formatter.rb. I haven't used it myself, but it seems purpose-built to handle the use-case you have.

Thanks @ndimiduk
I agree with your comment and updated the PR with recent commit.
I have addressed all your concerns so far. Please review.
Thank you

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 6 new or modified test files.

_ master Compile Tests _

+0 :ok:
mvndep
0m 37s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 10s
master passed

+1 :green_heart:
compile
3m  6s
master passed

+1 :green_heart:
checkstyle
2m 24s
master passed

+0 :ok:
refguide
4m 48s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
4m 41s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
5m 10s
master passed

+0 :ok:
spotbugs
1m 20s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
23m  8s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  5s
the patch passed

+1 :green_heart:
compile
3m  9s
the patch passed

+1 :green_heart:
cc
3m  9s
the patch passed

+1 :green_heart:
javac
3m  9s
the patch passed

+1 :green_heart:
checkstyle
2m 19s
root: The patch generated 0 new + 448 unchanged - 2 fixed = 448 total (was 450)

+1 :green_heart:
rubocop
0m  9s
There were no new rubocop issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+0 :ok:
refguide
4m 41s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
4m 42s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
16m  0s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
hbaseprotoc
8m 36s
the patch passed

+1 :green_heart:
javadoc
5m 18s
the patch passed

+1 :green_heart:
findbugs
24m 42s
the patch passed

_ Other Tests _

-1 :x:
unit
70m 20s
root in the patch failed.

+1 :green_heart:
asflicense
4m  2s
The patch does not generate ASF License warnings.

207m 11s

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestAsyncTableGetMultiThreaded

hadoop.hbase.client.TestFromClientSide

hadoop.hbase.replication.TestNamespaceReplicationWithBulkLoadedData

hadoop.hbase.replication.TestNamespaceReplication

Subsystem
Report/Notes

Docker
Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/13/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/754

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop

uname
Linux 4c78be5576a0 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-754/out/precommit/personality/provided.sh

git revision
master / 5f61df4792

Default Java
1.8.0_181

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/13/artifact/out/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/13/artifact/out/patch-site/book.html

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/13/artifact/out/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/13/testReport/

Max. process+thread count
9807 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift hbase-shell . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/13/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.79.0

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Failed tests in recent build are passing locally, not relevant to the PR changes

Using thread-safe wrapper over EvictingQueue makes life simpler, however it does not have any perf improvement because earlier I was using lock to write data in array in thread safe manner. However, using it has good advantages over not losing any writes specifically if manual locks time out or get InterruptedException, and of course less manual code to maintain. Thanks @bharathv for the suggestion.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 6 new or modified test files.

_ master Compile Tests _

+0 :ok:
mvndep
0m 37s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 10s
master passed

+1 :green_heart:
compile
3m  7s
master passed

+1 :green_heart:
checkstyle
2m 25s
master passed

+0 :ok:
refguide
4m 50s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
4m 38s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
5m  7s
master passed

+0 :ok:
spotbugs
1m 23s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
23m 25s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  5s
the patch passed

+1 :green_heart:
compile
3m  4s
the patch passed

+1 :green_heart:
cc
3m  4s
the patch passed

+1 :green_heart:
javac
3m  4s
the patch passed

+1 :green_heart:
checkstyle
2m 23s
root: The patch generated 0 new + 448 unchanged - 2 fixed = 448 total (was 450)

+1 :green_heart:
rubocop
0m  9s
There were no new rubocop issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+0 :ok:
refguide
4m 40s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
4m 41s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
15m 52s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
hbaseprotoc
8m 29s
the patch passed

+1 :green_heart:
javadoc
5m 17s
the patch passed

+1 :green_heart:
findbugs
24m 39s
the patch passed

_ Other Tests _

-1 :x:
unit
99m  7s
root in the patch failed.

+1 :green_heart:
asflicense
4m  8s
The patch does not generate ASF License warnings.

235m 56s

Subsystem
Report/Notes

Docker
Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/14/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/754

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop

uname
Linux eb6c9ef5e8be 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-754/out/precommit/personality/provided.sh

git revision
master / 0e96638898

Default Java
1.8.0_181

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/14/artifact/out/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/14/artifact/out/patch-site/book.html

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/14/artifact/out/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/14/testReport/

Max. process+thread count
8828 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift hbase-shell . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/14/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.79.0

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@ndimiduk if you have time today, please review

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 6 new or modified test files.

_ master Compile Tests _

+0 :ok:
mvndep
0m 39s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 23s
master passed

+1 :green_heart:
compile
3m  7s
master passed

+1 :green_heart:
checkstyle
2m 24s
master passed

+0 :ok:
refguide
4m 45s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
4m 35s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
5m  9s
master passed

+0 :ok:
spotbugs
1m 23s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
23m 30s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  1s
the patch passed

+1 :green_heart:
compile
3m  4s
the patch passed

+1 :green_heart:
cc
3m  4s
the patch passed

+1 :green_heart:
javac
3m  4s
the patch passed

+1 :green_heart:
checkstyle
2m 21s
root: The patch generated 0 new + 448 unchanged - 2 fixed = 448 total (was 450)

+1 :green_heart:
rubocop
0m  9s
There were no new rubocop issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+0 :ok:
refguide
4m 43s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
4m 44s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
16m  6s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
hbaseprotoc
8m 31s
the patch passed

+1 :green_heart:
javadoc
5m 14s
the patch passed

+1 :green_heart:
findbugs
24m 45s
the patch passed

_ Other Tests _

-1 :x:
unit
70m 57s
root in the patch failed.

+1 :green_heart:
asflicense
4m  6s
The patch does not generate ASF License warnings.

208m 18s

Reason
Tests

Failed junit tests
hadoop.hbase.replication.TestSyncReplicationStandBy

hadoop.hbase.replication.TestNamespaceReplicationWithBulkLoadedData

hadoop.hbase.replication.TestNamespaceReplication

Subsystem
Report/Notes

Docker
Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/15/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/754

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop

uname
Linux 29d1791f43b5 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-754/out/precommit/personality/provided.sh

git revision
master / e11dbf36a5

Default Java
1.8.0_181

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/15/artifact/out/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/15/artifact/out/patch-site/book.html

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/15/artifact/out/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/15/testReport/

Max. process+thread count
9679 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift hbase-shell . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/15/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.79.0

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 6 new or modified test files.

_ master Compile Tests _

+0 :ok:
mvndep
0m 37s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 18s
master passed

+1 :green_heart:
compile
3m  4s
master passed

+1 :green_heart:
checkstyle
2m 22s
master passed

+0 :ok:
refguide
4m 52s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
4m 43s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
5m 11s
master passed

+0 :ok:
spotbugs
1m 21s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
23m 36s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  3s
the patch passed

+1 :green_heart:
compile
3m  6s
the patch passed

+1 :green_heart:
cc
3m  6s
the patch passed

+1 :green_heart:
javac
3m  6s
the patch passed

+1 :green_heart:
checkstyle
2m 21s
root: The patch generated 0 new + 433 unchanged - 1 fixed = 433 total (was 434)

+1 :green_heart:
rubocop
0m 10s
There were no new rubocop issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+0 :ok:
refguide
4m 40s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
4m 43s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
15m 55s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
hbaseprotoc
8m 29s
the patch passed

+1 :green_heart:
javadoc
5m 19s
the patch passed

+1 :green_heart:
findbugs
24m 43s
the patch passed

_ Other Tests _

-1 :x:
unit
70m 12s
root in the patch failed.

+1 :green_heart:
asflicense
3m 49s
The patch does not generate ASF License warnings.

207m  5s

Reason
Tests

Failed junit tests
hadoop.hbase.replication.TestNamespaceReplication

hadoop.hbase.regionserver.slowlog.TestSlowLogRecorder

Subsystem
Report/Notes

Docker
Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/16/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/754

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop

uname
Linux 9bab66cbd704 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-754/out/precommit/personality/provided.sh

git revision
master / fe0d49bc52

Default Java
1.8.0_181

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/16/artifact/out/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/16/artifact/out/patch-site/book.html

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/16/artifact/out/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/16/testReport/

Max. process+thread count
9719 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift hbase-shell . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/16/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.80.0

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 6 new or modified test files.

_ master Compile Tests _

+0 :ok:
mvndep
0m 37s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 13s
master passed

+1 :green_heart:
compile
3m  9s
master passed

+1 :green_heart:
checkstyle
2m 24s
master passed

+0 :ok:
refguide
4m 47s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
4m 43s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
5m 11s
master passed

+0 :ok:
spotbugs
1m 21s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
23m 28s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  1s
the patch passed

+1 :green_heart:
compile
3m  5s
the patch passed

+1 :green_heart:
cc
3m  5s
the patch passed

+1 :green_heart:
javac
3m  5s
the patch passed

+1 :green_heart:
checkstyle
2m 25s
root: The patch generated 0 new + 433 unchanged - 1 fixed = 433 total (was 434)

+1 :green_heart:
rubocop
0m  9s
There were no new rubocop issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+0 :ok:
refguide
4m 47s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
4m 43s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
16m  0s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
hbaseprotoc
8m 52s
the patch passed

+1 :green_heart:
javadoc
5m 12s
the patch passed

+1 :green_heart:
findbugs
26m 42s
the patch passed

_ Other Tests _

-1 :x:
unit
75m 43s
root in the patch failed.

+1 :green_heart:
asflicense
3m 20s
The patch does not generate ASF License warnings.

214m 39s

Reason
Tests

Failed junit tests
hadoop.hbase.replication.TestReplicationDisableInactivePeer

hadoop.hbase.replication.TestReplicationStatusSourceStartedTargetStoppedNoOps

hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpointNoMaster

hadoop.hbase.replication.TestReplicationDroppedTables

Subsystem
Report/Notes

Docker
Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/17/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/754

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop

uname
Linux b9b499e89b98 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-754/out/precommit/personality/provided.sh

git revision
master / fe0d49bc52

Default Java
1.8.0_181

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/17/artifact/out/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/17/artifact/out/patch-site/book.html

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/17/artifact/out/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/17/testReport/

Max. process+thread count
8179 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift hbase-shell . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/17/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.80.0

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  1s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 6 new or modified test files.

_ master Compile Tests _

+0 :ok:
mvndep
0m 38s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 14s
master passed

+1 :green_heart:
compile
3m 10s
master passed

+1 :green_heart:
checkstyle
2m 27s
master passed

+0 :ok:
refguide
5m  2s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
4m 49s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
5m 26s
master passed

+0 :ok:
spotbugs
1m 20s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
25m  6s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 59s
the patch passed

+1 :green_heart:
compile
3m  1s
the patch passed

+1 :green_heart:
cc
3m  1s
the patch passed

+1 :green_heart:
javac
3m  1s
the patch passed

-1 :x:
checkstyle
2m 22s
root: The patch generated 1 new + 433 unchanged - 1 fixed = 434 total (was 434)

+1 :green_heart:
rubocop
0m 10s
There were no new rubocop issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+0 :ok:
refguide
4m 46s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
4m 44s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
16m  9s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
hbaseprotoc
8m 30s
the patch passed

+1 :green_heart:
javadoc
5m 21s
the patch passed

+1 :green_heart:
findbugs
24m 38s
the patch passed

_ Other Tests _

-1 :x:
unit
71m 17s
root in the patch failed.

+1 :green_heart:
asflicense
3m 47s
The patch does not generate ASF License warnings.

210m 33s

Reason
Tests

Failed junit tests
hadoop.hbase.replication.TestNamespaceReplication

hadoop.hbase.replication.TestSyncReplicationMoreLogsInLocalCopyToRemote

hadoop.hbase.replication.TestReplicationKillMasterRS

hadoop.hbase.replication.multiwal.TestReplicationKillMasterRSCompressedWithMultipleAsyncWAL

hadoop.hbase.replication.TestReplicationStatus

Subsystem
Report/Notes

Docker
Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/18/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/754

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop

uname
Linux 8c4408194eee 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-754/out/precommit/personality/provided.sh

git revision
master / fe0d49bc52

Default Java
1.8.0_181

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/18/artifact/out/branch-site/book.html

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/18/artifact/out/diff-checkstyle-root.txt

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/18/artifact/out/patch-site/book.html

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/18/artifact/out/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/18/testReport/

Max. process+thread count
9839 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift hbase-shell . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/18/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.80.0

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  3s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  1s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 6 new or modified test files.

_ master Compile Tests _

+0 :ok:
mvndep
0m 36s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 48s
master passed

+1 :green_heart:
compile
3m 25s
master passed

+1 :green_heart:
checkstyle
2m 40s
master passed

+0 :ok:
refguide
5m 29s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
5m  7s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
5m  9s
master passed

+0 :ok:
spotbugs
1m 27s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
25m 42s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 33s
the patch passed

+1 :green_heart:
compile
3m 23s
the patch passed

+1 :green_heart:
cc
3m 23s
the patch passed

+1 :green_heart:
javac
3m 23s
the patch passed

-1 :x:
checkstyle
2m 38s
root: The patch generated 6 new + 433 unchanged - 1 fixed = 439 total (was 434)

+1 :green_heart:
rubocop
0m 10s
There were no new rubocop issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+0 :ok:
refguide
5m 26s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
5m  5s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
17m 45s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
hbaseprotoc
9m 19s
the patch passed

+1 :green_heart:
javadoc
5m 33s
the patch passed

+1 :green_heart:
findbugs
29m 36s
the patch passed

_ Other Tests _

-1 :x:
unit
133m 18s
root in the patch failed.

+1 :green_heart:
asflicense
2m 39s
The patch does not generate ASF License warnings.

284m 20s

Reason
Tests

Failed junit tests
hadoop.hbase.snapshot.TestExportSnapshotV1NoCluster

hadoop.hbase.snapshot.TestExportSnapshotV2NoCluster

Subsystem
Report/Notes

Docker
Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/19/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/754

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop

uname
Linux 25ad47dfb155 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-754/out/precommit/personality/provided.sh

git revision
master / 400b7ce954

Default Java
1.8.0_181

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/19/artifact/out/branch-site/book.html

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/19/artifact/out/diff-checkstyle-root.txt

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/19/artifact/out/patch-site/book.html

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/19/artifact/out/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/19/testReport/

Max. process+thread count
5984 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift hbase-shell . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/19/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.79.0

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

I think the patch looks in a decent shape after the refactor.. There are some minor comments I posted...
Also, few things you mentioned you'd do in follow-on tasks..

too-large responses
metrics support
thrift-api equivalent

Please track them as sub-tasks so that we don't lose track of them...

No worries, I am full aware of all follow up tasks and going to create JIRAs right after merging this.
Thanks

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 6 new or modified test files.

_ master Compile Tests _

+0 :ok:
mvndep
0m 38s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 16s
master passed

+1 :green_heart:
compile
3m  5s
master passed

+1 :green_heart:
checkstyle
2m 26s
master passed

+0 :ok:
refguide
4m 55s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
4m 41s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
5m 11s
master passed

+0 :ok:
spotbugs
1m 21s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
23m 25s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 58s
the patch passed

+1 :green_heart:
compile
3m  6s
the patch passed

+1 :green_heart:
cc
3m  6s
the patch passed

+1 :green_heart:
javac
3m  6s
the patch passed

+1 :green_heart:
checkstyle
2m 24s
root: The patch generated 0 new + 433 unchanged - 1 fixed = 433 total (was 434)

+1 :green_heart:
rubocop
0m 10s
There were no new rubocop issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+0 :ok:
refguide
4m 47s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
4m 41s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
15m 55s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
hbaseprotoc
8m 25s
the patch passed

+1 :green_heart:
javadoc
5m 17s
the patch passed

+1 :green_heart:
findbugs
24m 53s
the patch passed

_ Other Tests _

-1 :x:
unit
73m  5s
root in the patch failed.

+1 :green_heart:
asflicense
3m 50s
The patch does not generate ASF License warnings.

209m 59s

Reason
Tests

Failed junit tests
hadoop.hbase.replication.TestNamespaceReplicationWithBulkLoadedData

hadoop.hbase.replication.TestReplicationStatusAfterLagging

hadoop.hbase.replication.TestReplicationDisableInactivePeer

hadoop.hbase.replication.TestRemoveFromSerialReplicationPeer

hadoop.hbase.replication.TestSyncReplicationMoreLogsInLocalCopyToRemote

Subsystem
Report/Notes

Docker
Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/20/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/754

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop

uname
Linux d7f88826477c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-754/out/precommit/personality/provided.sh

git revision
master / 400b7ce954

Default Java
1.8.0_181

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/20/artifact/out/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/20/artifact/out/patch-site/book.html

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/20/artifact/out/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/20/testReport/

Max. process+thread count
9767 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift hbase-shell . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/20/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.80.0

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 6 new or modified test files.

_ master Compile Tests _

+0 :ok:
mvndep
0m 44s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 23s
master passed

+1 :green_heart:
compile
3m 26s
master passed

+1 :green_heart:
checkstyle
2m 29s
master passed

+0 :ok:
refguide
5m 22s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
4m 40s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
5m 13s
master passed

+0 :ok:
spotbugs
1m 23s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
24m 44s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  4s
the patch passed

+1 :green_heart:
compile
3m 27s
the patch passed

+1 :green_heart:
cc
3m 27s
the patch passed

+1 :green_heart:
javac
3m 27s
the patch passed

+1 :green_heart:
checkstyle
2m 24s
root: The patch generated 0 new + 433 unchanged - 1 fixed = 433 total (was 434)

+1 :green_heart:
rubocop
0m 10s
There were no new rubocop issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+0 :ok:
refguide
4m 51s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
5m  4s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
16m 48s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
hbaseprotoc
8m 33s
the patch passed

+1 :green_heart:
javadoc
5m 33s
the patch passed

+1 :green_heart:
findbugs
27m 29s
the patch passed

_ Other Tests _

-1 :x:
unit
75m 14s
root in the patch failed.

+1 :green_heart:
asflicense
3m 15s
The patch does not generate ASF License warnings.

219m  5s

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestScannerTimeout

Subsystem
Report/Notes

Docker
Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/21/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/754

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop

uname
Linux f92b50200325 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-754/out/precommit/personality/provided.sh

git revision
master / 400b7ce954

Default Java
1.8.0_181

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/21/artifact/out/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/21/artifact/out/patch-site/book.html

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/21/artifact/out/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/21/testReport/

Max. process+thread count
8732 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift hbase-shell . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/21/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.80.0

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 6 new or modified test files.

_ master Compile Tests _

+0 :ok:
mvndep
0m 38s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 16s
master passed

+1 :green_heart:
compile
3m  5s
master passed

+1 :green_heart:
checkstyle
2m 21s
master passed

+0 :ok:
refguide
4m 55s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
4m 40s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
5m  9s
master passed

+0 :ok:
spotbugs
1m 23s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
23m 43s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 59s
the patch passed

+1 :green_heart:
compile
3m  9s
the patch passed

+1 :green_heart:
cc
3m  9s
the patch passed

+1 :green_heart:
javac
3m  9s
the patch passed

+1 :green_heart:
checkstyle
2m 21s
root: The patch generated 0 new + 407 unchanged - 1 fixed = 407 total (was 408)

+1 :green_heart:
rubocop
0m  9s
There were no new rubocop issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+0 :ok:
refguide
4m 51s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
shadedjars
4m 43s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
15m 59s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
hbaseprotoc
8m 30s
the patch passed

+1 :green_heart:
javadoc
5m 17s
the patch passed

+1 :green_heart:
findbugs
24m 58s
the patch passed

_ Other Tests _

-1 :x:
unit
115m  6s
root in the patch failed.

+1 :green_heart:
asflicense
3m 53s
The patch does not generate ASF License warnings.

252m 28s

Reason
Tests

Failed junit tests
hadoop.hbase.backup.TestFullBackupSetRestoreSet

hadoop.hbase.backup.TestRestoreBoundaryTests

hadoop.hbase.backup.TestIncrementalBackupWithFailures

hadoop.hbase.backup.TestFullBackup

hadoop.hbase.backup.TestBackupStatusProgress

hadoop.hbase.backup.TestRepairAfterFailedDelete

hadoop.hbase.backup.TestBackupMerge

hadoop.hbase.backup.TestFullRestore

hadoop.hbase.backup.TestIncrementalBackupWithBulkLoad

hadoop.hbase.backup.TestIncrementalBackup

hadoop.hbase.backup.TestBackupDeleteWithFailures

hadoop.hbase.backup.TestIncrementalBackupDeleteTable

Subsystem
Report/Notes

Docker
Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/22/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/754

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop

uname
Linux b3ca6ea4459a 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-754/out/precommit/personality/provided.sh

git revision
master / 3c3aae9a2f

Default Java
1.8.0_181

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/22/artifact/out/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/22/artifact/out/patch-site/book.html

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/22/artifact/out/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/22/testReport/

Max. process+thread count
9849 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift hbase-shell . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/22/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.80.0

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Structural Refactoring - .NET 6.0 & SqlServer

Summary
Why do you need to create DbContext and models for each EF Provider? They're just providers, the project abstraction shouldn't know anything about a provider. So I removed all the provider-specified codes and merged them into a single abstraction layer.
As I can see, migrations are managed by the library. Between EF Providers, the only different thing is migrations. Only migrations are separated in the ideal scenario. You can see, provider specified projects have only migrations but now any of EF providers can be used via generating migrations

What brings that structure?
That structure has a couple of benefits like I presented below.
Database Independency
Firstly, database dependency is completely removed. That means developers can use any database as they wish with EntityFramework. They need to manage their own migrations for database providers which we don't provide migrations.

New usage of a database that ironhook support (PostgreSql).
If we provide migrations, it can be defined via calling UseIronHook{databasename}Migrations() method.

            services.AddIronHook(options =>
            {
                options.UseNpgsql(
                Configuration.GetConnectionString("Default"),
                opts => opts.UseIronHookNpgsqlMigrations());
            });

I just replaced UseIronHook() method with MigrateIronHook() method since it doesn't add a middleware, it just performs a migration operation.
app.MigrateIronHook();

New usage of Non-supported databases

options.UseMySql(Configuration.GetConnectionString("Default"));

Migrations aren't provided by IronHook, but MigrateIronHook can still be used, it'll create a database from the current state of DbContext with https://github.com/FowApps/IronHook/pull/45/files#diff-48af72c016bfcfaede0f855ae54a6f1b88fceeb48b7977aea5bb3bc412f376edR41-R48
app.MigrateIronHook();

Managing own migrations by developers is highly recommended for unsupported databases but it's not mandatory

Multi-Targeting
Now, the project can support both framework versions at the same time. Projects are targeting .NET 5 and .NET6 right now.
In the future, .Net 5 support can be dropped partially.
Common DbContext
I just have removed DB provider-specific DbContexes since there is no difference with CoreDbContext. Using single DbContext is much more maintainable.

Closes #40
Closes #44

Hi @codeclimate, all of problems you found are auto-generated files (migrations) 😅

Thanks for the contribution, @enisn  we are reviewing it as a team.

Update codeclimate.yml file on root and exclude SqlServer migration files. @enisn

Since dotnet6 support has been added, there should be a sample project for dotnet6 in the sample folder. @enisn

Codeclimate treats files with the same name as duplications. For this reason, we must make the names of the IronHookCoreDbContextFactory classes provider dependent.
for example;
IronHookPostgreSqlCoreDbContextFactory instead of IronHookCoreDbContextFactory
we can use
@enisn

Any updates?

Any updates?

Not for now. Tests continue. PR can be merged on weekdays. @enisn

I can't update the wiki section, Can you update documentation also?

I updated wiki documentation. Thanks @enisn. Developing with you is so much fun. 🎉🎉🎉🎉

@all-contributors please add @enisn for infrastructure, tests and code


customised properties in list view?

Hi,
Is it possible to make this happen?
class MyAdmin(ModelView):
    column_list = ['field1', 'my_admin_method', 'field3', '']

    def my_admin_method(self, obj):
        return 'obj id is %s' % obj.id

so that flask-admin will display three fields in list view template, with calculated results from my_admin_method ?
We can do this in Django, it's pretty convenient to make internal model field values into more human readable representations in list view

Check out the hybrid property example: https://github.com/flask-admin/flask-admin/blob/master/examples/sqla-hybrid_property/app.py#L32-L34

@pawl Thanks. it works. we can also use  column_formatters


Design basic architecture for method selection

Thinking of having a methodselector class that acts like an intervention & is therefore easy to switch between

Implemented on the https://github.com/fpsim/fpsim/tree/methodtime/fpsim branch


RMC-rustc interface: Existing proof tool interfaces to rustc

Summarize API for

Cranelift (#55)
Prusti (#56)
Crux-mir (#53)

in collaboration with their authors.

Closing this issue since we now have a good idea about this topic and have a plan in progress to properly interface with rustc (see #719 to see what steps have been taken to improve it until now).


docs/querying: improve wording

This commit improves the wording of the subquery examples and makes
them more consistent with other examples.
Signed-off-by: Lucas Servén Marín<EMAIL_ADDRESS>

Thanks!


Not generating a randomized file

I plug in a 1.00 file of skyward sword, and it only generates a spoiler log, not an actual randomized file.

The randomizer generates a file called SOUE01.wbfs, look for that in the output folder you specified. Also make sure to have dry-run unchecked, cause that setting does indeed only generate a spoiler log


Rework release preparation tasks

This is a follow-up to https://github.com/voxpupuli/modulesync_config/pull/788
Voxpupuli contributors used to update a module version and rake changelog before opening a PR for preparing a new release.  Some modules now have a REFERENCE.md file that also needs to be updated (by running rake reference), and forgetting to do so will remain unnoticed until rake release complain that the file is not up-to-date (so after the release PR was reviewed and merged).
This PR move the changelog and reference tasks from each module's Rakefile (under modulesync control), to the voxpupuli-release gem, rename them to release:porcelain:changelog and release:porcelain:reference to leave room for new changelog and reference tasks indicating they are new deprecated, and recommand running the new release:prepare task that runs them.
This is indented to help maintainers smoothly update their workflow and provide a framework where additional tasks can be added if need be.

Puppet 6 bundle Ruby 2.5, do you think it's time to remove Ruby 2.4 from CI?

Do we also need to update the readme for these changes?

Puppet 6 bundle Ruby 2.5, do you think it's time to remove Ruby 2.4 from CI?

I think by now that's fine. All our other tooling has dropped 2.4.

only our puppet-lint plugins test on 2.4. mostly because I didn't want to do a major release.

Did you test it in any module?
I run the release:prepare task against the bacula module which is almost ready for a new release.  No PR for now, just ensured the expected things happen.

@ekohl I know you're quite busy at the moment. Could you please take a look in the next few weeks when you've some spare time? If you like we could also go on with it and implement possible enhancements in the future.

@alexjfisher, @ekohl I think this is ready for merging, but I would love some feedback on the open discussions if you have some time.  Thanks!

Sorry for the string of reviews. I tend to find more things as time passes. I think this is now pretty close to being merged and we can solve these later if you want.

Yeah, lots of moving parts!  I addressed the last issues you raised and marked them as resolved, for the 2 last one I think we can left the code as it is for now.
Thank you for your reviews!


Set offset for the query end time to -11 minutes

When running the PromQL Compliance test, we can sometimes observe the queries with negative offset failing. The reason for this is that by default query end time is now() - 2m. And we have queries with negative offsets of -5m and -10m. That, generally, means that we are querying into the future for 3m for the first query (with offset -5), and 8m for the second query (with offset -10). When running the compliance test, sometimes a race condition can be observed with data ingestion where one storage still hasn't ingested the same sample that the other system already has ingested. As a result, queries with negative offsets into the future can fail since the resulting time series will have additional samples at the end (the one that the other storage system still hasn't ingested at that point of time). This issue is raised in #94.
This PR offsets the query end time to -11m (previously it was -2m). This will ensure that even for the query with offset -10 we don't query into the future and thus we avoid the ingestion race condition problem.

Thanks for the comment! That makes sense. I have pushed the change with -12m.


QUESTION: Is there a way to throttle github stat collection?

Syncs for large repos triggers the GitHub abuse mechanism:
time="2015-10-19T23:10:24Z" level=info msg="retrieved 3500 items for elasticsearch (elastic:elasticsearch) (page 35)"
time="2015-10-19T23:10:25Z" level=error msg="fail to retrieve pull request information for 3475: GET https://api.github.com/repos/elastic/elasticsearch/pulls/3475: 403 You have triggered an abuse detection mechanism.  Please wait a few minutes before you try again. []"
time="2015-10-19T23:10:25Z" level=error msg="fail to retrieve pull request information for 3485: GET https://api.github.com/repos/elastic/elasticsearch/pulls/3485: 403 You have triggered an abuse detection mechanism.    Please wait a few minutes before you try again. []"
panic: close of closed channel

Hi! Indeed I've had the problem, and so far I've been working around it with the --sleep parameter, but I agree it's less than ideal. I'm thinking maybe of allowing to set an array of GitHub API tokens to round robin on in configuration (because besides throttling, API limits is an issue for giant repositories).
If you have any idea I'm interested ;-) Thanks!

I'm working on a Node-based project, that solves the problem by adding all requests to a queue that is gated based on configurable timer.  https://github.com/christo4ferris/gitstats


Windows Server 2016 forest functional level features

when i config ad with dsc, how can i set the forest functional level features to windows server 2008 R2?

i have done it

@leegh123 Can you describe what changes you did to the schema.mof?

in the schema.mof file i add two lines
[Write, Description("set domain mode")] String DomainMode;
[Write, Description("Set Forest Mode")] String ForestMode;

@leegh123 Thanks for the information! Let's keep this issue open and I labeled it as an enhancement. Would you be interested in sending in a PR with this change?
I think we should use a [ValidateSet()] with the appropriate values the user can choose.

Hi @johlju , I had the same problem at a customer of mine, extended the resource and quickly forgot about submitting the changes... Since there is no reaction from @leegh123 , I will go ahead and submit a pull request ~tomorrow after I have added some tests for the added functionality if that's ok.

@nyanhp Sounds great. Please send a PR.

Do we have a timeline when to expect this feature to be available as a part of master branch?

@sakhatri nest community call is set for the 18th so approximately a week after that there will be new releases for resource modules in DSC Resource Kit.


mapboxgl.util is not longer accessible in the latest release

As per title, wanted to give a heads up that if upgrading to 0.34.0 of Mapbox, mapboxgl.util is not longer accessible in the latest release as per https://github.com/mapbox/mapbox-gl-js/issues/4393
Not an expert with Mapbox nor the directive, so im not sure yet what this implies in terms of finding the issue. Give wanted to give a heads up :)

Hi @mm-ns!
I will update the documentation for new CustomControls.

Hi @mm-ns!
I updated the examples page and wiki for mapboxgl.util deprecation.
Thank you!