[Bug]: Database will not recover due to refusing to create the primary instance while the latest generated serial is not zero

Is there an existing issue already for this bug?

[X] I have searched for an existing issue, and could not find anything. I believe this is a new bug.

I have read the troubleshooting guide

[X] I have read the troubleshooting guide and I think this is a new bug.

I am running a supported version of CloudNativePG

[X] I have read the troubleshooting guide and I think this is a new bug.

Contact Details
No response
Version
1.22.1
What version of Kubernetes are you using?
1.28
What is your Kubernetes environment?
Self-managed: k3s
How did you install the operator?
Helm
What happened?
I'm not exactly sure, as I haven't been looking at it for a while and when I came back to it, it had failed. I have auto-updates for minor postgres updates enabled.
Cluster resource
apiVersion: postgresql.cnpg.io/v1
kind: Cluster
metadata:
  creationTimestamp: "2024-01-12T19:25:48Z"
  generation: 3
  labels:
    app.kubernetes.io/instance: cloudnative-pg-cluster-vector
    app.kubernetes.io/name: cloudnative-pg-cluster-vector
    app.kubernetes.io/part-of: cloudnative-pg
    kustomize.toolkit.fluxcd.io/name: postgres16-vector
    kustomize.toolkit.fluxcd.io/namespace: flux-system
  name: cluster16-vector
  namespace: databases
  resourceVersion: "56850766"
  uid: 6aa03d38-9f01-47d9-bbe8-9b0eacf00703
spec:
  affinity:
    enablePodAntiAffinity: true
    nodeSelector:
      kubernetes.io/arch: amd64
    podAntiAffinityType: required
    topologyKey: kubernetes.io/hostname
  backup:
    barmanObjectStore:
      data:
        compression: bzip2
      destinationPath: s3://cnpg-main/
      endpointURL: https://s3.skym.fi
      s3Credentials:
        accessKeyId:
          key: aws-access-key-id
          name: cloudnative-pg-secret
        secretAccessKey:
          key: aws-secret-access-key
          name: cloudnative-pg-secret
      serverName: postgres-vector-v3
      wal:
        compression: bzip2
        maxParallel: 4
    retentionPolicy: 30d
    target: prefer-standby
  bootstrap:
    initdb:
      database: app
      encoding: UTF8
      localeCType: C
      localeCollate: C
      owner: app
  enableSuperuserAccess: true
  failoverDelay: 0
  imageName: ghcr.io/bo0tzz/cnpgvecto.rs:16.1-v0.1.11
  instances: 2
  logLevel: info
  maxSyncReplicas: 0
  minSyncReplicas: 0
  monitoring:
    customQueriesConfigMap:
    - key: queries
      name: cnpg-default-monitoring
    disableDefaultQueries: false
    enablePodMonitor: true
    podMonitorMetricRelabelings:
    - action: replace
      sourceLabels:
      - cluster
      targetLabel: cnpg_cluster
    - action: labeldrop
      regex: cluster
  postgresGID: 26
  postgresUID: 26
  postgresql:
    parameters:
      archive_mode: "on"
      archive_timeout: 5min
      dynamic_shared_memory_type: posix
      log_destination: csvlog
      log_directory: /controller/log
      log_filename: postgres
      log_rotation_age: "0"
      log_rotation_size: "0"
      log_truncate_on_rotation: "false"
      logging_collector: "on"
      max_connections: "600"
      max_parallel_workers: "32"
      max_replication_slots: "32"
      max_worker_processes: "32"
      shared_buffers: 512MB
      shared_memory_type: mmap
      shared_preload_libraries: ""
      ssl_max_protocol_version: TLSv1.3
      ssl_min_protocol_version: TLSv1.3
      wal_keep_size: 512MB
      wal_receiver_timeout: 5s
      wal_sender_timeout: 5s
    shared_preload_libraries:
    - vectors.so
    syncReplicaElectionConstraint:
      enabled: false
  primaryUpdateMethod: restart
  primaryUpdateStrategy: unsupervised
  replicationSlots:
    highAvailability:
      enabled: true
      slotPrefix: _cnpg_
    updateInterval: 30
  resources:
    limits:
      memory: 2Gi
    requests:
      memory: 1Gi
  smartShutdownTimeout: 180
  startDelay: 3600
  stopDelay: 1800
  storage:
    resizeInUseVolumes: true
    size: 15Gi
    storageClass: ceph-block
  superuserSecret:
    name: cloudnative-pg-secret
  switchoverDelay: 3600
status:
  certificates:
    clientCASecret: cluster16-vector-ca
    expirations:
      cluster16-vector-ca: 2024-04-11 19:20:48 +0000 UTC
      cluster16-vector-replication: 2024-04-11 19:20:48 +0000 UTC
      cluster16-vector-server: 2024-04-11 19:20:48 +0000 UTC
    replicationTLSSecret: cluster16-vector-replication
    serverAltDNSNames:
    - cluster16-vector-rw
    - cluster16-vector-rw.databases
    - cluster16-vector-rw.databases.svc
    - cluster16-vector-r
    - cluster16-vector-r.databases
    - cluster16-vector-r.databases.svc
    - cluster16-vector-ro
    - cluster16-vector-ro.databases
    - cluster16-vector-ro.databases.svc
    serverCASecret: cluster16-vector-ca
    serverTLSSecret: cluster16-vector-server
  cloudNativePGCommitHash: c7be872e
  cloudNativePGOperatorHash: 262d86af058f59462fdccaec51231a1afd888153413f63224f60e458fcd335be
  conditions:
  - lastTransitionTime: "2024-02-05T20:54:29Z"
    message: Cluster Is Not Ready
    reason: ClusterIsNotReady
    status: "False"
    type: Ready
  - lastTransitionTime: "2024-02-07T03:22:01Z"
    message: Continuous archiving is working
    reason: ContinuousArchivingSuccess
    status: "True"
    type: ContinuousArchiving
  - lastTransitionTime: "2024-02-09T00:02:19Z"
    message: Backup was successful
    reason: LastBackupSucceeded
    status: "True"
    type: LastBackupSucceeded
  configMapResourceVersion:
    metrics:
      cnpg-default-monitoring: "56848192"
  currentPrimary: cluster16-vector-2
  currentPrimaryTimestamp: "2024-02-05T20:55:24.457332Z"
  firstRecoverabilityPoint: "2024-01-12T19:35:31Z"
  firstRecoverabilityPointByMethod:
    barmanObjectStore: "2024-01-12T19:35:31Z"
  lastSuccessfulBackup: "2024-02-09T00:02:13Z"
  lastSuccessfulBackupByMethod:
    barmanObjectStore: "2024-02-09T00:02:13Z"
  latestGeneratedNode: 4
  managedRolesStatus: {}
  phase: Waiting for the instances to become active
  phaseReason: Some instances are not yet active. Please wait.
  poolerIntegrations:
    pgBouncerIntegration: {}
  readService: cluster16-vector-r
  secretsResourceVersion:
    applicationSecretVersion: "56848599"
    clientCaSecretVersion: "20975045"
    replicationSecretVersion: "20975047"
    serverCaSecretVersion: "20975045"
    serverSecretVersion: "20975046"
    superuserSecretVersion: "33681"
  targetPrimary: cluster16-vector-2
  targetPrimaryTimestamp: "2024-02-05T20:55:04.222508Z"
  timelineID: 2
  topology:
    successfullyExtracted: true
  writeService: cluster16-vector-rw

Relevant log output
{"level":"info","ts":"2024-02-12T11:06:31Z","msg":"refusing to create the primary instance while the latest generated serial is not zero","controller":"cluster","controllerGroup":"postgresql.cnpg.io","controllerKind":"Cluster","Cluster":{"name":"cluster16-vector","namespace":"databases"},"namespace":"databases","name":"cluster16-vector","reconcileID":"a55acaf4-ce1b-4407-85de-b808d3444694","uuid":"c6da66c8-c996-11ee-bde0-de698429f95d","latestGeneratedNode":4}
{"level":"info","ts":"2024-02-12T11:06:32Z","msg":"Couldn't find target pod, will retry in 30 seconds","controller":"backup","controllerGroup":"postgresql.cnpg.io","controllerKind":"Backup","Backup":{"name":"daily-backup-20240212000000","namespace":"databases"},"namespace":"databases","name":"daily-backup-20240212000000","reconcileID":"18277980-ef7b-4b5d-87de-14429e082fa9","uuid":"c779b5b1-c996-11ee-bde0-de698429f95d","target":"cluster16-vector-2"}
{"level":"info","ts":"2024-02-12T11:06:32Z","msg":"refusing to create the primary instance while the latest generated serial is not zero","controller":"cluster","controllerGroup":"postgresql.cnpg.io","controllerKind":"Cluster","Cluster":{"name":"cluster16-vector","namespace":"databases"},"namespace":"databases","name":"cluster16-vector","reconcileID":"d652ed72-1e47-4145-988c-6d9f8439eb8c","uuid":"c77ddc77-c996-11ee-bde0-de698429f95d","latestGeneratedNode":4}

Code of Conduct

[X] I agree to follow this project's Code of Conduct

from the provided cluster spec, all PVCs are deleted, however the operator does not delete PVC when rolling updating, may you give more logs before {"level":"info","ts":"2024-02-12T11:06:31Z","msg":"refusing to create the primary instance while the latest generated serial is not zero","controller":"cluster","controllerGroup":"postgresql.cnpg.io","controllerKind":"Cluster","Cluster":{"name":"cluster16-vector","namespace":"databases"},"namespace":"databases","name":"cluster16-vector","reconcileID":"a55acaf4-ce1b-4407-85de-b808d3444694","uuid":"c6da66c8-c996-11ee-bde0-de698429f95d","latestGeneratedNode":4}

from the provided cluster spec, all PVCs are deleted, however the operator does not delete PVC when rolling updating, may you give more logs before {"level":"info","ts":"2024-02-12T11:06:31Z","msg":"refusing to create the primary instance while the latest generated serial is not zero","controller":"cluster","controllerGroup":"postgresql.cnpg.io","controllerKind":"Cluster","Cluster":{"name":"cluster16-vector","namespace":"databases"},"namespace":"databases","name":"cluster16-vector","reconcileID":"a55acaf4-ce1b-4407-85de-b808d3444694","uuid":"c6da66c8-c996-11ee-bde0-de698429f95d","latestGeneratedNode":4}

It was just over an over the same message which is why I did not include more logs. I have since de-provisioned the cluster in question. I deleted the PVC's to get it to re-initialize it but failed.

We're seeing the same issue

I'm seeing this issue as well

Same issue here.

I can only imagine reaching this state if something other than the CNPG operator changes the .state of the Cluster. If someone ends up in this state, it would be helpful to know whether the Cluster resource is managed by any IaC tool, such as flux.
It would be useful to have a report using the report plugin command that includes also the manifests of all the relevant resources managed by the Cluster object.

Hello @mnencia ! For me it was a Flux managed cluster, and it was unable to connect to the remote bucket for hours.
I've been able to always have a successful recovery since then, probably because my connection works right away (or close to). If it happens again I'll use the report command. All of my cluster definition information is https://github.com/no1here0003/Talos-cluster/tree/main/kubernetes/apps/database/cloudnative-pg/cluster and has remained largely unchanged (except I'd since recovered a few times, so I'm at v4 now).
Knowing about the report command is great, I've had my cluster "stuck" failing over, now I know how to gather information to help troubleshoot and resolve these.
Hopefully one of the other commenters have better information than myself.

Same issue here 😢


Remove uses of bazel info in scripts and tests

Summary: The uses of bazel info to find built binaries were
inaccurate in some places. Additionally calling out to bazel
in a test causes issues when running under qemu. This cleans up
bazel info calls in non-test helpers and updates the tests
to not invoke bazel and expect the relevant args to always be
supplied.
Relevant Issues: N/A
Type of change: /kind cleanup
Test Plan: All the updated scripts and tests should continue to work.

@pixie-io-buildbot test this please.


Support for xClaims

Plugin Version:
3.6.13
Request:
Respect option for the xClaims mod:
https://www.spigotmc.org/resources/1-8-1-21-xclaim-better-chunk-claiming-for-smps.102843/
How/Why:
The xClaims mod has more downloads then any individual mod currently supported- it is very widely used and it would be very nice to make betterRTP be even better for more servers :) ❤
Additional Context:
Currently there are several mods that can be configured in the Respect section of the config, however, xClaims is not one of them :)

Looks like there is a simple API to work with 👍


keyd doesn't activate

I've installed keyd from this tutorial: https://copr.fedorainfracloud.org/coprs/fmonteghetti/keyd/ and it doesn't work. I am using Fedora 40.
renan@fedora:~$ sudo systemctl status keyd
× keyd.service - key remapping daemon
     Loaded: loaded (/usr/local/lib/systemd/system/keyd.service; enabled; preset: disabled)
    Drop-In: /usr/lib/systemd/system/service.d
             └─10-timeout-abort.conf
     Active: failed (Result: exit-code) since Mon 2024-08-19 09:39:26 -03; 46s ago
   Duration: 975us
    Process: 6821 ExecStart=/usr/local/bin/keyd (code=exited, status=203/EXEC)
   Main PID: 6821 (code=exited, status=203/EXEC)
        CPU: 891us

ago 19 09:39:26 fedora systemd[1]: Started keyd.service - key remapping daemon.
ago 19 09:39:26 fedora systemd[1]: keyd.service: Main process exited, code=exited, status=203/EXEC
ago 19 09:39:26 fedora systemd[1]: keyd.service: Failed with result 'exit-code'.

renan@fedora:~$ keyd --monitor
failed to open /dev/input/event0
failed to open /dev/input/event1
failed to open /dev/input/event2
failed to open /dev/input/event3
failed to open /dev/input/event5
failed to open /dev/input/event4
failed to open /dev/input/event6
failed to open /dev/input/event7
failed to open /dev/input/event8
failed to open /dev/input/event9
failed to open /dev/input/event10
failed to open /dev/input/event11
failed to open /dev/input/event12
failed to open /dev/input/event13
failed to open /dev/input/event14
failed to open /dev/input/event15
failed to open /dev/input/event16

Thanks for your feedback. I haven't used Fedora in a while, so perhaps my keyd.spec should be modified to handle newer versions. The keyd github repo points to an alternative COPR: https://copr.fedorainfracloud.org/coprs/alternateved/keyd/
Can you try this one and see if it works for you?


[RS-1225] - Fine-tuning WAF docs based on testing.

Product Version(s):
Calico Enterprise 3.18 & next, Calico Cloud 18.0.0 & next
Issue:
RS-1225
Link to docs preview:

SME review:

[ ] An SME has approved this change.

DOCS review:

[ ] A member of the docs team has approved this change.

Additional information:

Merge checklist:

[ ] Deploy preview inspected wherever changes were made
[ ] Build completed successfully
[ ] Test have passed

LGTM. Ready for merge?

LGTM. Ready for merge?

Yes please!


Add new node property 'OtherNames'

With value of a JSON dictionary - to represent names of things in different scopes.

May best be folded into 'Labels' field. Investigating.

Added LocalName to Labels field in #37


Added an options attribute for specifying sort, limit and whether to show/omit forks

I've added an options attribute to allow the user to customise their list. This is demonstrated in the README and should be pretty self-explanatory.

Looks good — thanks for contributing.

Thanks for the widget!
On Sat 30 May 2015 at 14:56, George MacKerron<EMAIL_ADDRESS>wrote:

Looks good — thanks for contributing.
—
Reply to this email directly or view it on GitHub
https://github.com/jawj/github-widget/pull/3#issuecomment-107038159.


Godot 4.0 RC1 ImageTexture.CreateFromImage does not render transparent pixels in PNG

Godot version
4.0.rc1.mono
System information
macOS Ventura 13.1, M1, Vulkan 1.2.231
Issue description
Textures created from ImageTexture.CreateFromImage (C#) render transparent pixels as magenta, but are rendered as transparent when the texture is set in the editor.
Texture loaded from c# onto a TextureRect node:

Same texture opened in editor:

texture is loaded correctly in a Godot script using load
texture does not load at all in C# script using GD.Load<ImageTexture>

Steps to reproduce
load and set an ImageTexture in c# script for a TextureRect from a png with an alpha channel and transparent pixels:
Image img = Image.LoadFromFile("res://foo.png");
ImageTexture tex = ImageTexture.CreateFromImage(img);
this.Texture = tex;

Minimal reproduction project
N/A

Pretty sure it's a problem with that specific texture not C#.

In this case, the magenta is due to the texture, however I believe the behaviour is still not as expected. The magenta pixels being rendered all have an alpha value of 0, but whereas in Godot 3.x they were not being rendered, there's some kind of blending happening when the texture is created as described in the issue

Please attach the textures to make it easier to test.

here's an example texture

In the texture provided, I do not see any magenta with alpha set to 0, so I can't even imagine where the magenta comes from.

Well, can't reproduce.

thanks for testing. closing for now since it doesn't seem reproducible


[Question] - Build wasm runtime with specific flags/features

I would like to build wasmtime with specific flags (for example for perf support). Where would I make modifications to manipulate how  wasmtime is built?

@yanavlasov thanks!
@kyessenov @PiotrSikora .. Any pointers here. Searching around the codebase and not being nearly familiar enough with how Bazel works it is not clear to me what steps it takes to build a very specific wasmtime (in contrast to say wamr for example where it looks like I could make modifications in bazel/foreign_cc/Build to change that build). Any pointers would be appreciated.

Thanks @daixiang0 . I saw this file and at first thought this was the place, but I could not see what were obvious build steps here and I also didn't see any means for modifying the Wasmtime build flags through this file. I see now from @PiotrSikora comment that I needed to consider that the build parameters (cargo file) were outside of this project, but that that project in question was indeed listed as a deps here.
So the process would be to modify the repository_locations.bzl under this project and have it point to my forked proxy-wasm-cpp-host that has the modifications to the Cargo file that in turn modifies the building of Wasmtime. Ok .. thanks!!

Hi @daixiang0 and @PiotrSikora, an update here:
Wasmtime has the ability to support profiling jitted code using VTune or perf.
In order to do this you need to (1) build in the support using a feature flag at build time and (2) then at runtime you have to pass another flag to actually turn on the profiling.
I modified the envoy-private/bazel/external/wasmtime.BUILD file to hopefully support the building of wasmtime with the vtune feature flag like so:
rust_library(
name = "rust_c_api",
srcs = glob(["crates/c-api/src/**/*.rs"]),
crate_root = "crates/c-api/src/lib.rs",
crate_type = "staticlib",
crate_features = ["vtune"],
edition = "2018",
proc_macro_deps = [
"@proxy_wasm_cpp_host//bazel/cargo:wasmtime_c_api_macros",
],
deps = [
":helpers_lib",
"@proxy_wasm_cpp_host//bazel/cargo:anyhow",
"@proxy_wasm_cpp_host//bazel/cargo:env_logger",
"@proxy_wasm_cpp_host//bazel/cargo:once_cell",
"@proxy_wasm_cpp_host//bazel/cargo:wasmtime",
],
)
But it is not clear to me where to supply the flag during instantiation wasmtime.  Do you have any pointers? Thanks.

@jlb6740 you need to make this changes in Proxy-Wasm C++ Host repo (see my previous comment).

@PiotrSikora now do we support adding runtime flag with WASM like below:
wasmtime --vtune <my_wasm_file>

@PiotrSikora now do we support adding runtime flag with WASM like below:
wasmtime --vtune <my_wasm_file>

We don't support that... I'm not familiar VTune, but wouldn't that require Envoy to be at least aware of it?


chore(typings): remove ptor from gulp types

after investigation, variables in the namespace cannot be assigned a value

types will require import of the classes and then setting the value from global
import {Browser} from 'protractor';
var browser: Browser = global['browser'];

Here's a sample typescript file for the proposed change.
https://github.com/cnishina/protractor-typings/blob/master/src/spec.ts


add reverse string exercise

I cleaned it up. Assert is not necessary since running the test will fail anyway if it's not implemented properly 😉

I enabled the linter earlier today, so it runs on both the exercise and solution 😁

note to self... again: do not edit on web
would be good to somehow get this into an abapGit repo. maybe a separate repo that an action could transfer to here


Unable to retrieve job status: Usage: grep

Short Description of the issue

Environment

Operating System:
Other related components versions:

Steps to reproduce

Logs, stacktrace, or other symptoms

output

Summary of proposed changes

time="2023-09-19T12:08:06+02:00" level=info msg="           3881504       cpu test-pod ciangott  R 1-01:29:53      1 cn0114\n"
time="2023-09-19T12:08:06+02:00" level=error msg="Unable to retrieve job status: Usage: grep [OPTION]... PATTERNS [FILE]...\nTry 'grep --help' for more information.\n"

will be checked later


License name in package.json is not a valid SPDX license name

From npm install:
npm WARN package.json<EMAIL_ADDRESS>license should be a valid SPDX license expression

And indeed, BSD is not in the list at https://spdx.org/licenses/

We seem to want BSD-3-Clause-Clear -- https://spdx.org/licenses/BSD-3-Clause-Clear.html#licenseText

It looks like npm doesn't understand BSD-3-Clause-Clear so I went with BSD-3-Clause instead.

Ready for review.

:+1:


Add back housekeeping updates

Per https://github.com/rackt/react-router/pull/2492#issuecomment-155583252, separate from the question of ES5 v ES6, this had some actual config updates like not adding coverage instrumentation to standard testing runs that I think we want for now.

Please don't merge yet. I'll put my comments inline.

Actually, looking at this a bit more, what's the downside of this setup?
The logic for the Karma configuration isn't actually split between the two files - as you can see, karma.conf.js is just a shell out to the actual ES6 file: https://github.com/rackt/react-router/blob/v1.0.0/karma.conf.js
Unlike e.g. the webpack config, the Karma config actually has non-trivial logic - there are separate branches for handling the coverage v. non-coverage case, as well as the two cases when using BrowserStack.
We clearly want some code style guidelines here (and checks to avoid more obvious things like undefined or unused variables). Why not just use the same one as the rest of the repo? The stub Karma config isn't going to confuse anybody who's seen Babel before.

The downside is that there are two files for configuring karma, which we don't need. Please narrow down this PR to only include the coverage fixes.

There are not two files for configuring Karma. The entirety of karma.conf.js is the re-export:
require('babel-core/register')
module.exports = require('./karma.conf.babel.js')

If there were configuration in both places, then I would be just as concerned as you.
Part of the reason I made this update across both repos was actually in preparation of splitting out the common parts - we currently have e.g. the BrowserStack configuration copy/pasted across the repos, which seems extremely suboptimal for maintenance.
Likewise for the webpack configs, which have drifted apart from each other in things like how they apply Babel (and in the plugins used).
To me, one of the major benefits of code as config in the same language used is absolutely the consistency benefits offered.
Especially for the Karma config which has (and needs to have) non-trivial logic, it makes a lot of sense to me to use the same code quality tools we already have to at least do a first-level check of sanity.
For something like a webpack config standing in isolation, this might not be worth it, but do you agree that the cost of a stub two-line re-export is not the same as that of actually splitting the code? And additionally that we probably should factor out common config elements like the BrowserStack setup anyway?

I'll re-do these PRs for now, but I do think we should make those changes to the config files - I put a fair amount of effort into looking through the configs line-by-line and e.g. matching things back up to new karma init templates, and I think for maintainability we ought to factor large chunks of those configs into a separate config package anyway.

do you agree that the cost of a stub two-line re-export is not the same as that of actually splitting the code? And additionally that we probably should factor out common config elements like the BrowserStack setup anyway?

No, I don't agree. I don't think that any of this needs optimizing, and I actually think it can be harmful to refactor this kind of thing out into common packages elsewhere. If we did that, then I'd have to open yet another file, probably in a separate repo entirely, just to know how the tests are running.

That's a good point. I think my 2 main concerns here were

Drift in the configs that should be the same slowly getting out of sync, which I think has already happened a bit between React Router and history
Managing multiple different separate configs for webpack, where you wanted linked configs for generating docs v. generating the actual code (this is useful if you embed examples on the page, since it ensures that you're using compatible setups everywhere)

The former is something I'm okay with just manually managing. The latter isn't an issue yet, although if e.g. we do make a full-fledged docs site, it's something worth thinking about - even within a single repo, we have duplication between e.g. the webpack config used for Karma and the webpack config used for the UMD builds.
Anyway I'll re-PR this as a minimal config changeset.

Updated.

You're still doing way too much in this PR. Just add back the coverage fixes. Don't refactor karma.conf.

Does this decrease legibility? I already had things set up this way. I think it's a bit of an improvement to separate out the BrowserStack stuff - makes it a lot easier to tell what the "actual" Karma configuration is.

I understand this PR is doing a lot - the original one was more clear because things were broken out into commits. The alternative would have been separate PRs for things like "only build Travis against master", "drop unused Firefox Karma launcher", &c., which on balance would have just added noise - a single PR for these build config updates seemed like the best way to structure it.

All right, what do we need to move this forward? Do you just want the Karma config to line up to the old one?
We're having people on Discord complain about how they can't debug in Karma right now because the code is mangled with the coverage instrumentation, so I'd like to move this forward for the benefit of other potential contributors.

Do you just want the Karma config to line up to the old one?

Yep. To quote myself earlier:

Please narrow down this PR to only include the coverage fixes.

Closing and splitting up this PR.


Zero-length files don't trigger path

Describe the bug
I have a set of tests that I run to make sure certain patterns cause gitleaks
to fail (status 1) or succed (status 0). One of the tests relied on touch shadow and
it was reliably detected by v7 and a path rule.
In updating to 8, this behavior has changed and touch shadow does not
result in a detected secret. A path rule is only
triggered if the file is not zero-length.
Arguably, this isn't a bug, since a 0-length file isn't a leak, but it is
a change from prior behavior, and kind of tripped me up.
Worth fixing?
To Reproduce
(I can complete this if @zricethezav agrees it's a bug)
Expected behavior
(ditto)
Screenshots
Basic Info (please complete the following information):

OS:
Gitleaks Version:

Additional context
Add any other context about the problem here.
cc @zricethezav

@pburkholder
0-length files are explicitly skipped here. As for whether this is a bug or not... I don't really have a strong opinion on it either way since this is mostly a rare edge case. If you, or someone in the community feel like contributing a patch, I'm happy to review it. Otherwise, I'll give this another month or so then close out the issue.

As stated, closing the issue


Export Document Version Property

The purpose of this PR is to export the Version attribute on the document to be used for synchronized lock checking in OC.
Issue associated with the OrchardCore repository was not found,

@MikeAlhayek  Please approve the workflow check

What's the issue that you are trying to resolve?

What's the issue that you are trying to resolve?

The Version field in the exported database is used to do a sync lock check, e.g. there is now a sync lock in Yessql but not in OC
I want to reuse this field and logic for implementing sync locks in OC to ensure that data submitted by a user is not overwritten by another user

The Version field in the exported database is used to do a sync lock check, e.g. there is now a sync lock in Yessql but not in OC
I want to reuse this field and logic for implementing sync locks in OC to ensure that data submitted by a user is not overwritten by another user

I am confused because it was added in YesSQL for OC and we do use it in OC already, example:
https://github.com/OrchardCMS/OrchardCore/blob/53ce9d79fa09b7e0bbce147e0a4e5ecf90984633/src/OrchardCore/OrchardCore.OpenId.Core/YesSql/Stores/OpenIdTokenStore.cs#L551-L563

Yes, I understand, but I'm talking about a situation where a user is updating content from a page.
For example, if two people open a page at the same time, and user A opens it first, and B opens it later, and then B submits it, and B submits it after that, then B's submission should be overwritten.

This is exactly the scenario that is covered in my example. By default the second user overwrites the changes from the first user. With the flag on SaveAsync then it will be detected and the second user gets an exception.

It's called optimistic concurrency.

This is exactly the scenario that is covered in my example. By default the second user overwrites the changes from the first user. With the flag on SaveAsync then it will be detected and the second user gets an exception.

However, although we currently have ContentItemVersionId it is not continuous.
if we submit from a web page, we encounter the following scenario

the first user opens the edit page, and the version number is 1
the second user opens the edit page and submits it, the version number is 2
the third user opens the page, gets version 2, modifies it and submits it, and the version number is 3.
the first user finally submits, checking for version expiration.

This example is not very appropriate. Can't think of a suitable example for a while 🤣


Isssues with specific Svelte syntax

Issue I
<div style="line-height: {1}" />

Issue II
{#if $page.url.pathname.includes("/test")}
  <slot/>
{:else}
  <Background />
  <Header />
  <main>
    <slot />
  </main>
  <Footer />
{   /if}

For Issue 1, that problem was caught by CSS formatter, not markup_fmt, but I don't think there're anything can do in CSS formatter since it's not valid CSS. However, it's also hard to do something to just "let CSS formatter allow this syntax".


Release/new main release

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Implement Metadata Policy across providers

MetadataPolicy allows providers to fetch metadata information from the secret objects, instead of the secret contents. Currently, only Azure Key Vault supports it. This needs to be implemented for the following providers:

[x] #1873
[x] #1874
[x] #1875
[x] #1876
[x] #1877

this one can be closed! 🥳


Add more SurPath Hub team

We need to redesign the Team section and add other core members

We need to redesign the Team section and add other core members

Do you want the other members to be on the same page?

Yep, only core members are on the same page. I'll gather their GitHub first.

Administrator - https://github.com/Ryjin210
Operations Manager - https://github.com/huenique
Moderator  - https://github.com/chraem

Ohk so I only need to add these 3 people right?

Yes ✨

I've added their names & position, if you could send links of linkedin & other accounts, I'll add that too and the photo as well

Their GitHub and Twitter are enough.
@Ryjin210
@huenique
@chraem

share your twitter links or linkedin

https://twitter.com/Ryjinx210

here is my linkedin account as well
https://www.linkedin.com/in/mark-ryan-jancorda-6916a6204/

Chraem Twitter: https://twitter.com/chraem2

You can start working on this issue now, they can make their own PR later to add their social links. But please don't forget their GitHub profile link.


How to make the dashboard accessible from the Internet?

How to make the dashboard accessible from the Internet? I tried the parameters, but no success. Can this dashboard be accessed from the Internet?
https://github.com/dfuse-io/dfuse-eosio/blob/515bb82773ff05e5f13c74914b0ef71197b795bd/cmd/dfuseeos/cli/dashboard.go#L19

Foremost, we do not recommend exposing the dashboard to the internet.
There is no option like eosq to change which endpoint the webapp reaches. To expose it to the internet, a rebuild is required of the dashboard client React application with the REACT_APP_DASHBOARD_GRPC_WEB_URL set to the public URL to reach.
It's essentially following the build from source steps but setting REACT_APP_DASHBOARD_GRPC_WEB_URL=https://... before calling the yarn build command used to build the dashboard.

Foremost, we do not recommend exposing the dashboard to the internet.
There is no option like eosq to change which endpoint the webapp reaches. To expose it to the internet, a rebuild is required of the dashboard client React application with the REACT_APP_DASHBOARD_GRPC_WEB_URL set to the public URL to reach.
It's essentially following the build from source steps but setting REACT_APP_DASHBOARD_GRPC_WEB_URL=https://... before calling the yarn build command used to build the dashboard.

If possible, it is recommended to support parameterization. Because the default is the local address, there is no UI interface for the server version of the server. I will compile a copy of it first according to the answer you gave.

If possible, it is recommended to support parameterization. Because the default is the local address, there is no UI interface for the server version of the server. I will compile a copy of it first according to the answer you gave.

I modified the dlauncher\dashboard\client\src\.env REACT_APP_DASHBOARD_GRPC_WEB_URL in this file to my external network address, but the program still accesses the local address

I modified the dlauncher\dashboard\client\src\.env REACT_APP_DASHBOARD_GRPC_WEB_URL in this file to my external network address, but the program still accesses the local address

I'm not sure why this .env file exists in fact, it's probably a leftover from previous version.
I used REACT_APP_DASHBOARD_GRPC_WEB_URL="https://mytest-eosio.com" yarn build and I can validate that the URL is changed in the static built files.


[Doc-enhancement] Blank tab screen troubleshooting step

Hi Team,
Blank tab screen will display in following scenario as well:
If the given tab URL is redirecting to login screen, then blank tab will display because Login pages don't render in iFrames, as a safeguard against clickjacking. Your authentication logic needs to use a method other than redirect.
So, please add note in following troubleshooting step:
https://learn.microsoft.com/en-us/microsoftteams/platform/resources/troubleshoot#blank-tab-screen

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: fb80c6db-320c-52b6-f8c4-fad9d146cb24
Version Independent ID: 37248d85-8023-dd61-e77b-d8571b8d792e
Content: Troubleshoot your app - Teams
Content Source: msteams-platform/resources/troubleshoot.md
Service: msteams
GitHub Login: @surbhigupta
Microsoft Alias: lajanuar

We will check on it and redirect to doc team accordingly.

@surbhigupta12 -Could you please help us to update the document?
Please add the note in below document-
Note -If the given tab URL is redirecting to login screen, then blank tab will display because Login pages don't render in iFrames, as a safeguard against clickjacking. Your authentication logic needs to use a method other than redirect.
Document-https://learn.microsoft.com/en-us/microsoftteams/platform/resources/troubleshoot#blank-tab-screen


[Central] Game maker UI not responsive to small screens

Issue:
The game maker pages are not formatting correctly on small devices.
Resolution:
Rewrite styling to provide responsive formatting for small devices.
Example:

Writing this here because I currently cannot get my dev environment working
In order to do this properly to account for a responsive design, the breakpoint sizes for each screen size should be different. Currently, each Grid item has its breakpoint as solely the xs property, meaning it is a universal breakpoint for all screen sizes. To change this adding in the properties for medium and large screens with different numbers would help solve a majority of the issues. Some padding and width resizing would need to be changed, as well as changing certain properties to be percentage or viewport-height or viewport-width would ensure this reworking of the page would totally responsive.


Testing travis

Description

GitHub Issues

Coverage decreased (-0.1%) to 73.899% when pulling 65c5e8570c14d2403b840360380e0d42c1bfa05e on tripliks:testing-travis into 7359acec488976e3ce143a766c092bff252dd25f on Miserlou:master.


allow nulls, relax id checks

Realized that it's not really the config loading's responsibility to be harsh on validation of IDs since it's not the place where things are created, but rather referencing things elsewhere. We just want to catch insane inputs, and then the logic that calls this function can deal with saying "No extension found with the id WRONG_ID".
Also trying to handle the syntaxes
- entity.card.about:
- entity.card.about

equally - i bet this is gonna be pretty common to happen, and we should just be graceful about it rather than exploding and refusing to start the system entirely

Yep the drawback is that we now technically allow that syntax, and there's nothing we can do to distinguish between them. I think it's probably best to be forgiving here; should be pretty unlikely that people explicitly write that.


Add bundle plugin list command

This command would list all the commands for installed plugins. A potential format for the output might be similar to bundle plugin help
$ bundle plugin list
Installed Plugins
  foo   # Find all gems whose name contains the word 'foo'
  bar   # Print the word 'bar' 16 times
  baz   # Make modem noises and draw an ANSI picture of a cactus

This would require CLI command, of course, as well as extending the plugin API to require that a "description" string be set (with a maximum length?) This could be enforced via lib/bundler/plugin.rb#validate_plugin!

I am interested in working on this issue. But I am not able to understand plugin system. I don't find documentation and examples. If there is any related links available let me know.

There are 2 kinds of plugins. One, the "old" way, is to simply have an executable in your $PATH that is named bundler-<command>. The "new" way is to use the Bundler::Plugin::API, which requires users to "register" the plugin by using the bundle plugin install <command> technique. An example of a working "new" style plugin can be found at http://github.com/kerrizor/bundler-dependency_graph
Bundler stores information about installed plugins in ~/.bundle/plugins and I was thinking we could "easily" extend the Plugin::API DSL to allow plugins to declare their description (similar to how we declare the command here: https://github.com/kerrizor/bundler-dependency_graph/blob/master/lib/bundler/dependency_graph/graph_builder.rb#L4

Thanks @kerrizor .

Output must be list of commands (not the plugin name) ,right ?

My instinct says yes, a list of commands is more useful. 3 options:

bundle plugin list shows plugins, bundle plugin commands shows the commands
show a list of commands as sublists of plugins, something like:

$ bundle plugin list
Installed Plugins
  foo
  ---
    foo   # Find all gems whose name contains the word 'foo'

  bar
  ---
    bar   # Print the word 'bar' 16 times
    baz   # Make modem noises and draw an ANSI picture of a cactus

list plugins "inline" so more like this

$ bundle plugin list
Installed Plugins
  foo   (foo)   # Find all gems whose name contains the word 'foo'
  bar   (bar)   # Print the word 'bar' 16 times
  baz   (bar)   # Make modem noises and draw an ANSI picture of a cactus

What do you think?

BTW, whatever we pick, it is super low stakes, since a change will have little impact on users. :)

It looks like there's a plugin list command on master: https://github.com/bundler/bundler/blob/master/lib/bundler/plugin.rb#L52-L68 which came from https://github.com/bundler/bundler/pull/6120 but it doesn't appear in any of the released versions

Closed by https://github.com/bundler/bundler/pull/6120. Will be released with bundler 2.1.0.


Rewrite homepage to particular page

Hello , Is there a way to use the docs module as the Index page and blog module as a Blog page , like in Docusaurus.

You can customize the homepage to be a landing page, and write any content you want.
// content/_index.md
---
layout: landing
# full_width: true
---

Use Markdown and shortcodes to generate any content.

Example
Source code

https://docker.hugomods.com/
https://github.com/hugomods/site/blob/main/docker/content/_index.md

https://images.hugomods.com/
https://github.com/hugomods/site/blob/main/images/content/_index.md

https://echarts.hugomods.com/
https://github.com/hugomods/site/blob/main/echarts/content/_index.md

...

thanks for the help but what if i dont want to include the landing page and use a docs page as a index.

Not sure if this what you want, specify the type as docs on homepage.
// content/_index.md
---
type: docs
---

I meant like,  assume that i have a doc page named "page1" and i want set that page as the index page.

Hmm, are you meant to reuse the content and layout (left sidebar, right sidebar and so on) as same as the "page1_" on homepage? If so, I don't have good idea.

Yes that is what I wanted to do .

I see, I have an idea now, but naming is difficult, what should we naming this functionality?

Anything you want .

Available since github.com/hugomods/base v0.6.0, check out the hugomods/base#43 to learn how to use it.

Yep


Updated Create * Channel Polymorphic VIs to meet the design guidelines

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?
For each of the Create * Channel (the 3 polymorphic VIs) the following actions were performed if necessary:

Arranged Front Panel with Ctrl+Space,Ctrl+F
Arranged Block Diagram with Ctrl+Space,Ctrl+F
Changed control/indicator label to lower case letters
Added description to the VIs (Description contains parts from the original documentation)

Why should this Pull Request be merged?
The current version of the VI does not meet the design guidelines.
What testing has been done?
N/A

"channel name" input should be required for all nodes.

Create Data Channel - Array - Comparison.vi - "Array" in settings typedef should be renamed to "Elements" to be more consistent with the other nodes.

Create Data Channel - Array - Type Cast.vi -> The order inside the typedef should be the one from the HLD doc:

Create Data Channel - Single Channel - Type Cast.vi -> The order should be as below, for consistency with the array node one.

For all four "Create Data Channel - Array" the "Add Array Data Channel.vi" needs to be updated as it is currently outputting the wrong channel values (it's outputting an array of parent refs and not of the actual channels).

The "Channel Refnums" needs to be change to an element and have the name "array refnum"
And the "Channel Refs" needs to be given out to the "Create Data Channel - Array" node.
Finally, the "Create Data Channel - Array" for all the four options (Enum, Format, TypeCast, Comparison) should have also the "array refnum" output along with the "channel refnums".

"channel name" input should be required for all nodes.

Fixed.

Create Data Channel - Array - Comparison.vi - "Array" in settings typedef should be renamed to "Elements" to be more consistent with the other nodes.

Fixed.

Array Type Cast Settings.ctl -> The order inside the typedef should be the one from the HLD doc:

Then all the Array Type Cast Create VIs (Data, MetaData & Global MetaData) should be saved with the new updated typedef.

Fixed.

Single Channel Type Cast Settings.ctl -> The order should be as in the picture below, for consistency with the array type cast ctl.

Then all the Single Channel Type Cast Create VIs (Data, MetaData & Global MetaData) should be saved with the new updated typedef.

Fixed.

For all four "Create Data Channel - Array" the "Add Array Data Channel.vi" needs to be updated as it is currently outputting the wrong channel values (it's outputting an array of parent refs and not of the actual channels).

The "Channel Refnums" needs to be change to an element and have the name "array refnum"
And the "Channel Refs" needs to be given out to the "Create Data Channel - Array" node.
Finally, the "Create Data Channel - Array" for all the four options (Enum, Format, TypeCast, Comparison) should have also the "array refnum" output along with the "channel refnums".

Fixed


Adding surgical consult text in CDA example

This was approved on Oct 8, 2020. Thank you @brettmarquard for noticing that I never opened up the pull request!

This was based on my original sample drafted in June and modified by Brett per Task Force discussion in October. here is a link to the sample in that repo for comparison purposes: https://github.com/jddamore/HL7-Task-Force-Examples/blob/master/C-CDAR2.1/UNSTRUCTURED_DOCUMENT_Surgical_Consult_text_plain/UNSTRUCTURED_DOCUMENT_Surgical_Consult_text_plain.xml


Added support for result object.

Added support for result property from xAPI Spec. It's an optional property that represents a measured outcome related to the Statement in which it is included.

Assumed you were mistaken as the Result object is so common, but every implementation I can find tacks it on after the fact.  Surprised this wasn't in already, thanks!

Uglify didn't know how to handle the default argument value syntax of result=null, so that was changed to just be the typical JS version (actor, verb, object, result) where arguments default to undefined by default.
Updated the minified build also.

Thank you. That was fast. :dancer:


[vi] Request to be added as reviewer

Hello,
I want to add myself to the reviewer list for the Vietnamese translations. Besides, I will also participate in the translation. Please consider this pull request from me.
Ps: How I can access this spreadsheet is used for tracking the progress of Vietnamese translation?
I realize that the contributors have been active since October 2019, are they still active?
Kindly regards,
Duy-Thanh Doan

Great. Thank you!

How I can access this spreadsheet is used for tracking the progress of Vietnamese translation?
I realize that the contributors have been active since October 2019, are they still active?

Good question. I can view it but do not have edit access. If this is useful, I can create a new doc. It's not very big—I've copied/pasted in its entirety here:
Notebook | Status | People in charge | Note |   |   |   |
-- | -- | -- | -- | -- | -- | -- | --
site/vi/tutorials/keras/classification.ipynb | Outdated |   | See commit 9e61a5f6aa0652ed2a9acb7f188e1d97c6f228e9 for change |   |   |   |
site/vi/tutorials/quickstart/advanced.ipynb | Outdated |   | See commit 9e61a5f6aa0652ed2a9acb7f188e1d97c6f228e9 for change |   |   |   |
site/vi/tutorials/quickstart/beginner.ipynb | Outdated |   | See commit 9e61a5f6aa0652ed2a9acb7f188e1d97c6f228e9 for change |   |   |   |
  |   |   | See https://youtu.be/5ECD8J3dvDQ?t=830 |   |   |   |

I have created a new file here to update this translation. After PR # 82 is merged, I will update the content for it and attach this link to the README file.
I have also shared the right to edit this file with you via email @google.com (I found it on Github on your commmit on the project) in case you need to add editing acess for one person.
Following the update from the old spreadsheet (outdated content), I will also be reviewing previous merged content.


Use SID for administrators group

Non-English Windows renames "Administrators" group, so SID should be used instead.
New-LocalAdmin.ps1
Add-LocalGroupMember -SID 'S-1-5-32-544' -Member $userName

@Rockavina Rockavina yes good idea, i use the same solution. And if you wish to use the local Administrator useraccount you need to activate him:
if ((Get-LocalUser -Name $userName).Enabled)
{
Enable-LocalUser -Name $userName
}

@Rockavina thanks for contributing! This issue has been resolved in #2


simply just saving a character is now impossible

Describe your bug here. If you are modding, try testing your bug in a clean version of the engine instead. Also, if you're using an older version of JSE, please try the latest version/action build. Also, be sure to check the pinned 'JS Engine: Known Issues' issue, to check if your issue hasn't already been found!
if I click more than 3 to 5 times then the window will start to crash along with the game
Command Prompt/Terminal/Crash logs (if existing)
p
Have you identified any steps to reproduce the bug? If so, please describe them below in as much detail as possible. Use images if possible.
simply saving a character and clicking random folders 5 times
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
i
If you use 1.12.0 or earlier, did you have Optimized Chart Loading turned on?
None
Did you check for any similar issues to what you're reporting? Check, then come back here. If there is a similar issue, then do not report the issue, otherwise it will be marked as a duplicate.
Yes

this also happens when I press only 1 folder too

I know the reason now
the game doesn't respond while you're saving something so the game thinks the folder is a part of the game so that stops responding

close it as complete

ok
this is happening to me as well now, open it back with a new label on this issue

i think this started happening since the noteskin crash was fixed

@moxie-coder


Semantics of block parameter's type restriction output type

This is a continuation of the discussions from https://github.com/crystal-lang/crystal/pull/10467#discussion_r586425638 and https://forum.crystal-lang.org/t/difference-between-underscore-and-empty-as-block-return-value/2998 and the problems faced with #10905.
Currently, there are two special values for the output type of a block parameter:

-> Nil or -> (empty output type is equivalent to Nil)
-> _ (underscore)

Both effectively act as wildcards accepting any output type.
For a captured block parameter, Nil casts the output type to Nil, whereas _ passes through the actual return type. These semantics are well defined, make sense and there don't appear to be any issues. So I won't focus on captured block parameter types in this issue.
For a yielding block, the actual type is always passed through.
There should technically be no difference between the two, but there are subtle, unintended ones (see https://forum.crystal-lang.org/t/difference-between-underscore-and-empty-as-block-return-value/2998 and #10928) The compiler's behaviour causes that underscore output type can involuntarily break code. As of now, underscore output type is essentially broken. One should always use Nil for yielding block parameters as a workaround (#10928 and #10929 apply that to stdlib).
There's really no need to have both, Nil and _ output types with the same semantics.
For simplicity, there should only be one or the other if they mean the same.
Alternatively, we could port the nil-casting semantics of Nil output type to yielding blocks. Not sure if that's much useful by itself, but it would help improve the expressiveness of yielding type restrictions.

I prefer the consistency of nil-casting semantics for Nil, although this might break some code.

With non-captured blocks the return type is really not important, because there's no need to create a Proc for them. So, if a return type is omitted from a non-captured block, I chose to consider it as "I don't care about the return type". I don't think there's a use case where you'd want a non-captured block to have the Nil type.
For now we can fix the underscore issue (already fixed here: https://github.com/crystal-lang/crystal/pull/10933 ). But I see no good reason to further change the semantic for non-captured blocks.

Also nil-casting semantics is sometimes wrong for captured blocks. See https://github.com/crystal-lang/crystal/issues/10911

Actually, I guess we could try (for 1.2) to have nil-casting semantics for non-captured blocks, if there's no explicit return type, but I'm afraid that's going to be a big breaking change.

The benefit of different output type semantics is expressing intent. For example, Enumerable#each(& : T ->) shows that it really doesn't care about the output type. It is simply ignored.
On the other hand, Array#sort_by(& : T -> _) shows that the value is actually used but the exact type doesn't matter. It's essentially shorthand for using a free variable.

I fear this is going to be a big breaking change as well.

Do you think there will be significant amount of code relying of the current behavior? As a user I would rely on the mentioned intention.

I really don't know. But we should just try it 🤷

It should be fairly unproblematic to change the semantics of -> Nil to introduce an explicit nil cast.
If that breaks code, the output type restriction is just wrong.
With ->  this is more difficult because it has no explicit output type. The omitted output type implicitly works like -> _. Breaking that experience is more serious and I don't think we can reasonably accept such a change. So ->  should continue to work without nil-casting (equivalent to -> _) for the time being.
We can consider deprecating omitted output type, removing it in 2.0 and/or maybe re-adding it again with same semantics of -> Nil (as a short cut). That should be subject to more consideration.


How to get the user's wechat account（微信号）？

I try to get use wexin() method, but got null. Is there a way to get a wechat account?
.on('message', async message => {
  console.log(`RECV: ${message}`)
  const wx_user = message.from()
  console.log(wx_user.weixin()) => null
})

You can not get wexin id for a contact if you are using the Web API(like PuppetPuppeteer, or PuppetWechat4u).
You can get wexin id if you use stronger Puppets, like PuppetPadchat.
Learn more at: #1296

I will try it. Thank you for your answer.

Could you please close this issue?

@3014zhangshuo  你获取到微信号了么？PuppetPadchat 这个是不是在 0.15的版本才有支持？


Leverage slider shows infinity

If you click on the slider when leverage is at one - it shows -infinity.

What version were you on?


Drop stack support for GHC 8.2.2

Due to the incoming merge of #1126, and transitively https://github.com/mpickering/haskell-ide-engine/pull/26, we will depend on cabal-plan-<IP_ADDRESS>.
The package cabal-plan-<IP_ADDRESS> requires a cabal-version of 2.2 or higher.
Stack lts-11.18 ships its own version of cabal-install which is version <IP_ADDRESS> and its Cabal version is <IP_ADDRESS>
Thus, I think we have to drop stack support for GHC 8.2.2.
This is a duplicate of #1087.

Closed by #1430


unable to see the domains

Even though I'm the only user, and admin. Also, End of last year, I was able to access the domains in pDNS, and now, I can't. I've eliminated the only problem - the backend - and it's not pDNS itself. I could've missed something, but I doubt it right now.

I have observed the same behavior when I encountered this issue @ #893
Can you verify if you get the same error messages?

I think domains on the dashboard page are loaded from the PDNS API each time you refresh the page. Check the url and key settings, and try to see in pdns if there are api request incoming.
It can be the pdns admin source address not allowed to access pdns api as well.


Change master branch version to 0.0.6

Need to increase the version after release.

Coverage increased (+0.04%) to 65.248% when pulling bcd9ddf844d37ed506426a9f0392517b999b1bef on cathay4t:new_version into 77f32a1da38f1f1ab0dd1dbb8d492bc2711bf90d on nmstate:master.

Coverage increased (+0.04%) to 65.248% when pulling bcd9ddf844d37ed506426a9f0392517b999b1bef on cathay4t:new_version into 77f32a1da38f1f1ab0dd1dbb8d492bc2711bf90d on nmstate:master.

Coverage increased (+0.04%) to 65.248% when pulling bcd9ddf844d37ed506426a9f0392517b999b1bef on cathay4t:new_version into 77f32a1da38f1f1ab0dd1dbb8d492bc2711bf90d on nmstate:master.

ci test please


cmd/go/internal/work/security.go: invalid flag in #cgo darwin LDFLAGS: -Wl,-rpath -Wl,@loader_path

Go version
go version go1.23.3 darwin/amd64
Output of go env in your module/workspace:
GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/Users/pedro/Library/Caches/go-build'
GOENV='/Users/pedro/Library/Application Support/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='darwin'
GOINSECURE=''
GOMODCACHE='/Users/pedro/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='darwin'
GOPATH='/Users/pedro/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/Users/pedro/sdk/go1.23.3'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/Users/pedro/sdk/go1.23.3/pkg/tool/darwin_amd64'
GOVCS=''
GOVERSION='go1.23.3'
GODEBUG=''
GOTELEMETRY='local'
GOTELEMETRYDIR='/Users/pedro/Library/Application Support/go/telemetry'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='clang'
CXX='clang++'
CGO_ENABLED='1'
GOMOD='/Users/pedro/Documents/git/sapsigner/impl/emu/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/_3/sh8y1_5d07q_5xhk9k8mncs80000gn/T/go-build4238436678=/tmp/go-build -gno-record-gcc-switches -fno-common'

What did you do?
Run go build main.go in macOS with the following program.

main.go

package main

// #cgo darwin LDFLAGS: -Wl,-rpath,@loader_path
import "C"

func main() {}

What did you see happen?
% go build -v main.go
command-line-arguments
command-line-arguments: invalid flag in #cgo LDFLAGS: -Wl,-rpath,@loader_path

What did you expect to see?
% go build -v main.go
command-line-arguments

Following the guidance on https://golang.org/s/invalidflag, I request that -Wl,-rpath,@ executable_path and -Wl,-rpath,@loader_path, possibly suffixed with some path, be whitelisted.
These are directives used on macOS to allow a dynamic library search path that is relative to the executable or library. See https://forums.developer.apple.com/forums/thread/736728.

I see that there is already a rule for rpath defined here: https://github.com/golang/go/blob/4f0561f9d354233787de7aa9eff8119a2d4cd5c6/src/cmd/go/internal/work/security.go#L212C6-L212C42. But it explicitly excludes values for rpath that start with @.
I guess that's because on Linux @ can be used to read from files. The solution for this is simple enough: if and only if we are on Darwin, allow values for rpath starting with @.

Duplicate of #40559

Related Issues

cmd/go: go tool rejects #cgo LDFLAGS<EMAIL_ADDRESS>#40559
go tool compile #55111 (closed)
go build #52634 (closed)
cmd/go: allow invalid flag in #cgo LDFLAGS: CoreFoundation #43152 (closed)
affected/package: cgo #63206 (closed)
Test #67906 (closed)
go env #52280 (closed)
Documentation #35490 (closed)
cmd/go: Inconsistent with input #48044 (closed)
go #49423 (closed)

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)


After reviews of the three hal ADC prototypes, this is what I think i…

Thanks for all the help everyone.  I do like this implementation the best.
Some special things to note about the HAL:

For ADC, I made the hal_device_s not constant.  This allows drivers to wrap this with state.  My implementations take up 1 or 2 words per device depending on whether the have state.
There is still a system ID and mcu ID.  I made special include files for them.  We can't do the simple thnk that MBED does since they use PINs and we wanted to support external devices in our HAL
Unlike the other drivers though, all the glue for the device factory lives in one function in the BSP.
Although the systemID are not necessarily iterable, in an application you can place their pointers in an array and iterate them nicely.
The MCU Device IDs can be specified differently for each MCU and need not be simple numbers (could be pins for the MBED hal for example)

No architecture besides native has bsp_sysid.h present in this pull request, so nothing except native targets would build after merging this in. Could you add stubs for all BSPs so that those platforms would still be buildable?


Required Scopes Not Shown in Swagger UI

In API Manager 2.6, the required scope that was needed to call a method was shown in the API Console:

Affected version: APIM-2.6.0

We found a way to achieve this use case by enabling the showExtensions property of the swagger UI.
This displays all the vendor extensions added per resource.
But we will have to rethink this and implement a better version in the next release, similar to the way we have displayed scope information in Swagger 2.x.


fix verify stage for helmfile when use oci as chart

https://github.com/helmfile/helmfile/issues/1659
move verify to the helm pull stage.
todos:

add unittests
add e2e tests

@mumoshu WDYT now? I update the verify logic in upgrage stage.


Run dist-upgrade in base setup

Run dist-upgrade in base setup so we make sure security and other stable
updates are installed.
Signed-off-by: Ben Kochie<EMAIL_ADDRESS>

I'm not sure this is a good idea. It might blow up the image size significantly. The base image needs to be updated (which it should). Was there a specific reason for this?

I'm not a fan of dist-upgrade in docker images, but the base image is the official one which is pulled during the circleci build. It should be updated, but looks like it's not enough.

There isn't normally a big difference, but even right now, there is one security update that the dist-upgrade pulls in.
Get:2 http://security.debian.org stable/updates/main amd64 perl-base amd64 5.24.1-3+deb9u3 [1344 kB]

I would like to make sure that we pull in all stable patches since we're building against debian:stable now.


Do not show "Python file" as one of the debug configuration options if people don't have a Python file open

Right now if you click on the "Run and Debug" button from the Debug View and there's no file open and you click on "Python", we display a list of config options for the user. But if they click on "Python File", because there's no file open it will fail:

It'd be nice if we could not display this option (especially cause we memorize the users choice for the rest of the session, until they reload the window).

@luabud Can I take this issue?

Thanks, I was able to reproduce this issue. Does this issue need a PR to remove this pop-up or suggestions as to what would be a better approach?

@bshahrok This is a needs proposal so the intent is here to come up with what the expected behavior should be.

I have two suggestions that might help improve the user experience when working on an editor:

If there is no open file in the editor, the options in the "Run" and "Debug" drop-down menus at the top that require an open file - such as "Python: File," "Python: Current File," or "Node.js: Current File" - should be disabled to avoid confusion. To provide more clarity, a message can be displayed when the user hovers over these disabled options, indicating that no current file was found.

Another way to enhance the user experience would be to improve the message displayed on the pop-up. Instead of just saying "variable ${file} cannot be resolved..." it can be rephrased to provide more information, such as "It seems that there is no file open to test. Please make sure that you have opened the desired file in the editor before attempting to test it. In case you want to test a default file without opening it, you can modify the ${file} variable in the launch.json file.".
In this case, it might make more sense that the default button in the pop-up would be the "Cancel" button rather than "Open 'launch.json'".


Add example for selecting from view with parameters

@renejeglinsky : this is the example on using a view with parameters that we talked about yesterday.
I added a TODO where we could link to respective sections of the runtime docu where they show how to do a select on a view with parameters in the runtimes - although I don't know whether such examples do exist
@agoerler @johannes-vogel : do you have docu/examples showing how to select from a view w/ params in the runtimes that we could link here? This was explicitly asked for in a cap issue.

@renejeglinsky : this is the example on using a view with parameters that we talked about yesterday. I added a TODO where we could link to respective sections of the runtime docu where they show how to do a select on a view with parameters in the runtimes - although I don't know whether such examples do exist
@agoerler @johannes-vogel : do you have docu/examples showing how to select from a view w/ params in the runtimes that we could link here? This was explicitly asked for in a cap issue.

We do not have a sample as we do not have a proper API for that. As of now, it's basically a CQN snippet you need to provide SELECT.from({ id: 'ViewWithParams', args: { p1: {val: 1}, p2: {val:2} }).

I think I added everything so that you can do another review please.

Can everyone do another review please?

@johannes-vogel Is this fine for you?


Fix examples/demotrace

Use otelsvc with proper configuration to run as an agent and as a collector.
Temporarily disable zipkin and jaeger exporters since they are not yet
implemented.
Add logging exporter so that we can see that the demo works.

Codecov Report

Merging #134 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #134   +/-   ##
=======================================
  Coverage   69.78%   69.78%
=======================================
  Files         101      101
  Lines        6391     6391
=======================================
  Hits         4460     4460
  Misses       1696     1696
  Partials      235      235

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d659119...7d7fa83. Read the comment docs.

@flands @bogdandrutu @songy23 I need one more review, please.


Evaluate Montserrat as a better alternative to Proxima Nova

http://www.google.com/fonts/specimen/Montserrat

monserrat is not even close to proxima nova.  yeah it has similar looking glyphs, but there is much more than that that makes proxima nova a great font.

actually its very close, and the best alternative available


CASMNET-1539 - Update dns_records.py API call to use the correct API gateway.

Summary and Scope
Update the dns_records.py script to use the NMN API gateway URL so the API call doesn't fail.
Issues and Related PRs

Resolves CASMNET-1539 and CAST-29864

Testing
Tested on:

wasp

Test description:
Risks and Mitigations
Pull Request Checklist

[ ] Version number(s) incremented, if applicable
[ ] Copyrights updated
[ ] License file intact
[X] Target branch correct
[ ] CHANGELOG.md updated
[ ] Testing is appropriate and complete, if applicable
[ ] HPC Product Announcement prepared, if applicable

See #806


WIP: remove deprecated annotation

After https://github.com/cashapp/misk/pull/1724 has been merged, this PR can be done as a followup step.

No longer relevant


re-enable dropped ssz test generators

Some test were skipped to the missing mode part:{mode.to_name()}

i ran the new tests against my ssz implementation and they all seem to pass (and not cause any issues).
bc of the way randomness works in the test generator, it does modify two existing tests and removes the handful of previous  "collapsed" tests but i don't see an immediate issue with this.
i'll go ahead and merge


COSINE Game Forum OBB IaaS

How does COSINE Game Forum OBB run as IaaS in Game Jolt?

How does COSINE Game Forum OBB run as IaaS in Game Jolt Twine prebuilt engine?  Because Twine has some parts to it in Electron and Rust in terms of IaaS!


fix: add new_email to generateLink options

What kind of change does this PR introduce?

Fixes #428

closing in view of recent bump to v2


Pass config-resolved hostname to ssh client

The ~/.ssh/config file was getting parsed properly but the information about
the hostname wasn't passed to the ssh client.
Fixes #299

Tests have run OK, silly Travis.


Improve the SEO of the Website in the Google search results.

Description
Improve the SEO of the site: www.codeincommunity.tech and add relevant descriptions, keywords to make it ranked in the search results.
Screenshots
No response

Hello, I am a GSSOC 22 participant. I do not know much about SEO optimization but I am interested to learn and work on this issue. Can you assign it to me?

@Adhetya Go for it!


adding ContainerService eventgrid event schema

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[x] Other, please clarify: Adding a dataplane for AKS type to EventGrid

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
July 16th
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
This is Eventgris swagger.
functionality works without publishing the swagger as this is dataplane types. Depends on Eventgrid.
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

Unsure, eventgrid team would know better if that is needed
  - [ ] SDK of .NET (need service team to ensure code readiness)
  - [ ] SDK of Python
  - [ ] SDK of Java
  - [ ] SDK of Js
  - [ ] SDK of Go
  - [ ] PowerShell
  - [ ] CLI
  - [ ] Terraform
  - [x] No, no need to refresh for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
[ ] Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
Adding a new service

[x] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

readme.md in the specifications/eventgrid/data-plane folder states :
To build the SDK for EventGrid, simply Install AutoRest and in this folder, run:

autorest

This fails with
ERROR: Semantic violation: Discriminator must be a required property. (components > schemas > MediaJobOutput)
  discriminator: { propertyName<EMAIL_ADDRESS>}
    - file:///workspaces/azure-rest-api-specs/specification/eventgrid/data-plane/Microsoft.Media/stable/2018-01-01/MediaServices.json:280:3
  Error: Semantic validation failed. There was some errors

/azp run


phantomjs installation failing

Trying to install meanjs; all is almost ok but at the end installation fails due to failing installation of phantomjs.
Here is a piece of error log it outputs:
npm ERR<EMAIL_ADDRESS>install: 'node install.js'
npm ERR  Exit status code 1
npm ERR
npm ERR  Failed at the<EMAIL_ADDRESS>install script.
npm ERR This is most likely a problem with phantomjs package,
npm ERR not with npm itself.
npm ERR Tell the author that this fails on your system:
npm ERR node install.js
npm ERR There is likely addidional logging output above.
npm ERR System Windows_NT 6.1.7601
npm ERR command "D:\servers\node\\node.exe" "D:\servers\node\node_modules\npm\bin\npm-cli.js" "install"
I am on windows 7 with node v0.10.31 installed.. Please help urgently.

This might give you the answer, which implies that temp directory is located on different device

Please use StackOverflow or another forum for answers that aren't specific to MEAN.JS.


Integration with nomad

Request
We are currently using nomad as our orchestrator. If we could seamlessly use mirrord with a nomad 'backend'.
with something like:
$ mirrord exec node app.js --task-group-name my-group # --task-group-name instead of --pod-name

Our use case
Why is it important for us
For simplicity sake, we chose nomad over k8s. We can see how mirrord is useful to our workflow.
How we would use it
We want to basically use it as much transparently as possible (compared to the k8s usage).
Alternatives
After few searches, I did not find any.
Implementation
The nomad integration seems feasible to me.
I'm not yet familiar with the project, but, If I am able to, I would definitely give some of my time to build the feature with maintainers.

Thanks for the suggestion. I believe that at the moment we can't provide resources from our core team to own this as a task, but if anyone wants to implement it, we'll happily provide support and guidance in implementing it.
P.S - not knowing Nomad ecosystem, but I'd assume it's not much of an effort. The changes that would need to be done:

Add new target "nomad/taskgroup/"
Use nomad API to spawn a container in the same namespaces as the target / add logic to the agent to use a nomad container specified and enter to it from the node context, adding the ability to run agent on node using Nomad API
Tests

Hey @aviramha, thank you for responding so quickly.
I will give the codebase a good read and try to make something out of your guidance.
Thank you again,
Alexandre

You're welcome! Let me know if you want to work on this and if you need further guidance, we can jump on a chat/call :)

Hello again @aviramha,
I'm currently working on this as a side project.
I'm more in an exploration phase than in a real implementation right now.
But, my though is, that the k8s' api is deeply integrated in the layer crate. I may need to make the pod_api module generic over the any kind of "api", or, create a job_api module.
Thank you,
Alexandre

Hello again @aviramha,
I'm currently working on this as a side project. I'm more in an exploration phase than in a real implementation right now. But, my though is, that the k8s' api is deeply integrated in the layer crate. I may need to make the pod_api module generic over the any kind of "api", or, create a job_api module.
Thank you,
Alexandre

That's great to know!
That sounds right.
A suggestion - you can "remove" pod_api and just replace it with nomad logic, send a PR and we'll adjust it in a generic way. The major hiccup from our side is not having nomad experience, but creating the abstraction would be fairly simple once we understand how the Nomad implementation can look like.

Hello @aviramha,
I found out that nomad doesn't have the port-forwarding feature built-in (yet ...). Which leads to sketchy workarounds where nomad nodes required the socat utility installed.
What do you think about that, is it an acceptable requirement ?
Do you have any idea on how to make this clean without the port-forwarding feature ?
Thank you again,
Alexandre

We can skip the socat and just use the stdin/out as means for communications with the agent directly.

Hello again @aviramha,
I managed to start the mirrord-agent container alongside the target task.
Now, I'm looking for a way to proxy my local tcp stream to the container without the port forwarding. And I'm not sure how to do it without socat.
You mentioned the fact that I would be able to just use stdin/out to communicate with the agent, I'm not sure how.
I understand that the mirrord-agent waits for a TCP connection on a specific port.
I also understand that I can proxy TCP stream through stdin and stdout of a nomad alloc exec (== kubectl exec) command.
What I don't understand is what am I supposed to run as the command of my nomad alloc exec (if not socat) in order to forward my TCP stream to the listener of mirrord.
Do you have any hint ?
Thank you

Great progress!
You can use socat, but if you prefer not to you need to change the mirrord agent to read the traffic from stdin and write output to stdout, while disabling logs (so you won't have interference).
https://docs.rs/async-std/latest/async_std/io/fn.stdout.html
you can use this and need to wrap the Codec with it instead of the tcp socket.

Ok !
That was something that I had in mind.
Implementation seems interesting, I will take a look.


Test some missing cases

Thanks, still not familiar with all CI aspects, but enjoying the help and learning a lot.

Codecov Report

Merging #9 (627959b) into main (ffa65b0) will increase coverage by 3.35%.
The diff coverage is n/a.

:exclamation: Current head 627959b differs from pull request most recent head ed6faa0. Consider uploading reports for the commit ed6faa0 to get more accurate results

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   78.77%   82.12%   +3.35%
==========================================
  Files           3        3
  Lines         179      179
==========================================
+ Hits          141      147       +6
+ Misses         38       32       -6

Impacted Files
Coverage Δ

src/units.jl
82.05% <0.00%> (+2.56%)
:arrow_up:

src/operators.jl
100.00% <0.00%> (+8.77%)
:arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


NewerVersionAvailable gradle lint preventing compilation

Found while updating https://github.com/flutter/samples/tree/main/add_to_app/android_view but appears to be a more general issue possibly related to bumping compileSdkVersion to 35.
  /Users/reidbaker/.pub-cache/hosted/pub.dev/url_launcher_android-6.3.3/android/build.gradle:71: Error: A newer version of org.mockito:mockito-core than 5.1.1 is available: 5.12.0 [NewerVersionAvailable]
      testImplementation 'org.mockito:mockito-core:5.1.1'
                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  /Users/reidbaker/.pub-cache/hosted/pub.dev/url_launcher_android-6.3.3/android/build.gradle:73: Error: A newer version of org.robolectric:robolectric than 4.10.3 is available: 4.13 [NewerVersionAvailable]
      testImplementation 'org.robolectric:robolectric:4.10.3'
                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

     Explanation for issues of type "NewerVersionAvailable":
     This detector checks with a central repository to see if there are newer
     versions available for the dependencies used by this project. This is
     similar to the GradleDependency check, which checks for newer versions
     available in the Android SDK tools and libraries, but this works with any
     MavenCentral dependency, and connects to the library every time, which
     makes it more flexible but also much slower.

  2 errors, 0 warnings

https://googlesamples.github.io/android-custom-lint-rules/checks/NewerVersionAvailable.md.html

Of the mechanisms listed in the linked documentation non appear to work. Specifically:

adding //noinspection NewerVersionAvailable to build.gradle file in pubcache
adding lint.xml file at the root of .pub-cache nor in the package version directory (aka url_launcher_android-6.3.3)
Setting lintOptions in the app build.gradle file
passing --ignore to lint

I was able to get the app to build with ./gradlew build -x lint but that skips all linting which feels like a bad practice.
More commentary on that option here. https://stackoverflow.com/questions/21143556/avoid-lint-when-gradle-execute-check
I believe the documentation linked above is possibly for a different lint check.

https://cs.android.com/android-studio/platform/tools/base/+/mirror-goog-studio-main:lint/libs/lint-checks/src/main/java/com/android/tools/lint/checks/GradleDetector.kt

libs/lint-checks/src/main/java/com/android/tools/lint/checks/GradleDetector.kt

Plugins can fix this by adding  disable  'NewerVersionAvailable' ... to lintOptions.
It appears we are doing this to ourselves by setting checkAllWarnings true, warningsAsErrors true and not excluding NewerVersionAvailable.

Of the mechanisms listed in the linked documentation non appear to work. Specifically:

adding //noinspection NewerVersionAvailable to build.gradle file in pubcache
adding lint.xml file at the root of .pub-cache nor in the package version directory (aka url_launcher_android-6.3.3)
Setting lintOptions in the app build.gradle file
passing --ignore to lint

I was able to get the app to build with ./gradlew build -x lint but that skips all linting which feels like a bad practice. More commentary on that option here. https://stackoverflow.com/questions/21143556/avoid-lint-when-gradle-execute-check
I believe the documentation linked above is possibly for a different lint check.

This comment might be incorrect because of issues I had pulling in the wrong url_launcher code.


JAVA-18133 Upgrade drools module to JDK 11

Migration drools module to jdk 11

test again please

test again

test this please


Fix dangling footstep bug, a couple misc bugs

Fixes the issue where duplicate footsteps weren't getting deleted
when the player and all its related points should've been removed
from the map. Also fixes unrelated NPE and CME bugs.

Hey man is this footstepd thing live yet? Just checking in to see if there is a next version with more features..
 One wont use it, he doesnt like to be located lol

Still waiting on approval from the Runelite team...once they do that, this will be live. It's really dope.
Your friend should enable ghost mode ;)

@ReinierAarnink1996 We're waiting on the Runelite team to approve the rollout of v2.0 to plugin-hub: https://github.com/runelite/plugin-hub/pull/2314
Perhaps you can comment to +1 it, but I'm not sure if that would affect how fast they'll get to it, as they seem to review these sort of PRs in batches.


Trying out quarto

Purpose/implementation Section
What changes are being implemented in this Pull Request?
Trying to set up some quarto things and playing around with it.

I'm trying to get quarto to accept our css file (see the _quarto.yml fiel where this is specified) and so far it gives this error:
ERROR: Theme file compilation failed:

Error: Undefined variable.
    ╷
963 │ $navbar-bg: $primary !default;
    │             ^^^^^^^^
    ╵

It will only compile if I use an automatic theme (which means it doesn't use our style.css)

@carriewright11 Here's where we left off with quarto.

the render actions are expecting bookdown files... would need to fix that

There are some nice features... I wonder how many of them can be achieved in bookdown - edit this page, make an issue for example... made some nice icons in the footer. It is harder to do custom css than I anticipated, got it to work for our div boxes but overall most seems to need to be coded in the _quarto.yml file - could make a config or something for the template if we go in that direction maybe if that is possible.


Make "libc" overridable (like a normal library)

This is part of my roadmap for cross compilation. I've talked with @ericson2314 about this, and I think it solves some of the issues we have had with Musl. Here are the things to be done:

[ ] Implement "crossOverlays" that use the cross stdenv without actually using a cross compiler (#48803). Packages overriden in crossOverlays take effect in the /target packages/ only.
[ ] Add a "libc" attr that goes to the libc being used. (glibc on Linux, libSystem on macOS)
[ ] Have pkgsMusl just use crossOverlays. This will hopefully avoid some of the awkwardness around https://github.com/NixOS/nixpkgs/commit/01dfe3f56019b0c330bc2e46da90146698844330. The implementation should be pretty straightforward. Just something like this:

{
  pkgsMusl = nixpkgsFun {
    inherit overlays config;
    crossOverlays = [
      (self: super: { libc = super.musl; })
    ];
  };
}

/cc @dtzWill

Neat! We will likely still want a way to check which libc is being used-- while we should avoid this where possible it's still needed in a number of places.  I'm not picky how this is addressed, perhaps a passthru on libc or something?

Isn't just a dup of https://github.com/NixOS/nixpkgs/issues/26004 ? :D Feel free to amend that issue's OP.

Oops forgot about that! I guess the added thing now is it could make things easier with musl and the cross vs. local distinction.


Issue #14

Sorry about bothering you with a PR again.
Later that day I was again looking at it and realized that my "fix" won't work the way I was thinking.
The problem was that template tags can't use key property but the inner components have to.
To prevent duplicate keys I gave all inner components an specific identifier beyond i.
Sorry about the extra work you had to do.

@Shaegi don't feel sorry, it's my fault that I did not tested before merge xd