Keep the most recently used log filters in the user history

This PR replaces the log filter text field with a combo box and an MRU list of log filters, similar to the MRU list of paths / URIs used when adding a new data source.

Hi @Arkanosis and thanks for taking on this long overdue feature - I always meant to implement it, but got distracted by something or other at some point, and never took the time to properly do it.
I've tried your implementation and it is promising, altough not without issues.
The main one is that of the persistance of the Most Recently Used list accross different worksheets; at the moment, a new MRU list is instanciated per worksheet but they all share the same backend for persistance, i.e. per user on the local machine.
This causes cached search terms from one worksheet to "leak" into other worksheets but inconsistently, depending on the order in which worksheets were created.
This also causes inconsistant storage of the terms into the persistant store, as the multiple lists that share it are not synchronized.
Before fixing it we need to specifiy  the desired behaviour. Off the top of my head, we could have:

All worksheets share a single MRU list, persisted across sessions via the user settings: to do that, simply make the list a member of UserHistory and reuse this single list for all worksheets. Search terms will still be shared across worksheet, but in a consitent way.

Each worksheet have its own private MRU, so that terms are not shared. In this case, we could  persist their content as part of UserHistory by generating a unique key for each. I'm not sure it's a great idea though, as user profile will end up being cluttering with history from never used again workspace. Then we might want to:
a. Not persits suggestions across sessions at all i.e. just use an MRU without a backend; all suggestions will be per worksheet, but will be lost when the  workspace it closed. I don't remember if I've implemented a volatile MRU list yet or not.
b. Persists suggestions as part of the worksheet itself, so that they are serialized as part of the workspace. This means that suggestions will be shared with other potentials users of that workspace, though. I can't really think of a case where this might be a real issue (and in fact could be useful most of the time), but or course that's something to be aware of.
These are my initial thoughts on how to implement this feature; I'm looking foward to hear yours.

Also, while we're at it, it would probably make sense to have as-you-type suggest list as well as a drop down list, since it is the behaviour that most users would expect from a search bar, I guess.

PS: As I've checked out your branch to review and test it, it is a more straight forward for me to keep track of it if you don't force push.
I'll do a squash and merge at the end anyway, to have a single, nice, clean commit.

Hi @fthevenet, thanks for the review!
The benefit of the feature for me is the ability to reuse filters from one workspace to another as much as within a single workspace. Therefore, of the behaviors you list, my preference goes to the first one: a single MRU list shared across all worksheets and persisted across sessions via the user history.
That being said, I also get the appeal of storing / sharing filters together with workspaces — not to add isolation between worksheets, but between workspaces, as well as to allow sharing with other users of the same workspaces. I'd rather see this as an explicit bookmarking than as an MRU list, though. Actually, my initial intention was to implement some kind of filter bookmarks in the user preferences, but I went for the MRU list as an equally useful and easier to implement feature.
The best behavior I can think of would be to have three lists instead of one:

the list of MRU filters, which is implicitly stored in the user history and never shared (requires no effort to use, but can contain garbage and lose filters after some time);
the list of user favorite filters, which is explicitly stored in the user preferences and never shared (requires some effort to use, but guarantees both the cleanliness and the durability of the filters);
the list of workspace filters, which is explicitly stored in the workspace and shared with it (same effort and same benefits + isolation with other workspaces and sharing with other users).
The three lists would be displayed in the same combo box (can we have sections with this widget in JavaFX?), kind of like how awesome bars of web browsers display the history, the bookmarks and the search suggestions at the same time.

I think these lists could be added in this order, though. The MRU is the easiest to implement; the user and workspace favorites requires some additional work.
Also, +1 for the autocomplete; this goes hand in hand with awesome bars :)

OK, sounds good to me!
As hinted earlier, this should also be the easiest to implement/least amount of extra work: simply declare and initialize your suggestion list in UserHistory (see logFilesHistory or mostRecentWorkspaces) and call it on the singleton from the controller.
I don't believe there's any reason to be concerned with concurrency issues here, so this should be straight forward.
I like the idea of having a way to separately and explicitly bookmark terms, though I'm not entirely sure about distinguishing user local bookmarks from workspace bookmarks, as I fear it might be difficult to quickly grasp the distinction in between the two and just end up being confusing.
At any rate I suggest you create a follow up issue to track and discuss this enhancement further and that we keep this PR focused on your original idea since it is now well defined.
With regard to the auto-completion, I suggest you have a look at the implementation in DataAdapterDialog, if you haven't already.

There is now a single ObservableList shared between comboboxes on all worksheets and all autocompletion bindings.
I still see two issues with the current implementation:

for some reason, selecting an entry from the combobox opens the autocompletion popup; I haven't been able to understand why (if you know about some way to log UI events…);
I'd love to add new MRU entries to the top of the combobox entries, but it seems that JavaFX keeps track of the currently selected entry by position, which as far I as can tell makes it impossible — I therefore add new entries to the bottom, but I'm less pleased by the behavior.

It appears the troubles with the ordering of the suggestions stem from the fact that you're battling with 2 separate lists; the MRU itself (which already behave exactly like you want) and the ObservableList that is used as a backend for the ComboBox control.
This can be fixed easily by making the the combobox as dumb as possible and overwriting its own list with the content of the MRU right before displaying it.
You can see an example of that in this commit https://github.com/binjr/binjr/commit/8444f5c51bbf550fe668d657ddd6f2d178baa5c8.
With that said, this now means that the ComboBox control is probably too "smart" a control for what we're doing, and a dumb drop down list (e.g. non "observable" or anything) would serve us well here. This added to the fact that I don't like the position of the "down arrow"  button relative to the other buttons in the bar, means that we should probably replace that with a simple button (that we can place wherever we choose) and a ContextMenu directly populated with the content of the MRU on showing.

On the topic of the autocomplete, it turns out the control I pointed out is pretty finicky  - and getting it to work exactly as we want, a bit of pain because, it comes with its own display popup.
So I'm of a mind that we'd be better off replacing it altogether with a custom implementation, especially if we want to support bookmarks later down the line: we certainly don't want to managed a third dropdown list for that...
Therefore I now think we forget it for the time being and we address it alongside the "bookmark" feature we discussed previously.

I wondered about implementing the ObservableList interface directly in the MRU, but your approach is simpler and I'm not sure being observable would be any better anyway (or work at all).
So I have merged your last commit and removed autocomplete for now, and I'm quite happy with the current behavior.
I let you decide if the PR is worth merging and I'll create follow-up issues for the other topics discussed above.
Thanks!

I wondered about implementing the ObservableList interface directly in the MRU

I thought about it but the MRU is based around a stack rather than a randomly accessible list (as it helps enforce the "most recent" semantics) so it cannot be done  without breaking things.


debian repo info

Added steps to install from repo I've created. Will be updated
in the same timeframe as the ppa and aur packages.

Hello there @shaggytwodope, thank you for stepping up to make drive available for Debian, and also thanks for the PR.
LGTM but could you please squash the commits into one then we'll be Gucci to go.

Squashed mate.

Thank you @shaggytwodope 🙏🏾 Merging it in.


Unable to build the DebugViewConsole project out of the box

I am unable to build the DebugViewConsole project out of the box. The issue is a missing file - 'docopt.h'.
See attached image.

I've searched the downloaded source base, but the file was not included in the ZIP.
I am building using Visual Studio 2022 (v143) & ISO C++17 Standard (/std:c++17).
Love your work.
Cheers

how are you building?
that file is here: https://github.com/CobaltFusion/DebugViewPP/blob/develop/application/Libraries/docopt.cpp/docopt.h

closed due to positive re-test and no further reaction


Fix csr_matrix._get_intXslice for step < 0 case

Blocked by #3948.

Jenkins, test this please

Jenkins CI test (for commit 60f92f2fd436d3faf5596dcb729e2cbecc4ccd18, target branch master) failed with status FAILURE.

Jenkins, test this please

Jenkins CI test (for commit 60f92f2fd436d3faf5596dcb729e2cbecc4ccd18, target branch master) failed with status FAILURE.

Rebased.

Jenkins, test this please

Jenkins CI test (for commit 4d4a6f6ca411d221a6cee9ce9bc5cad95e133991, target branch master) failed with status FAILURE.

Reproduced the test failure locally with SciPy 1.4.1.

Segfault?

Segfault?

@emcastillo #3955 will resolve these test failures.

Jenkins, test this please

Jenkins CI test (for commit 4d4a6f6ca411d221a6cee9ce9bc5cad95e133991, target branch master) succeeded!


⚠ Bofrost.at has degraded performance

In 310fdc4, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1837 ms

Resolved: Bofrost.at performance has improved in 84c3895 after 15 minutes.


Add exportable comment check to golangci-lint

Determine why the .golangci.yml configuration does not error when exported functions and types do not have comments, such as NewHTTPService. Add comments to all exported API.

Hi @prestonvasquez, I had the same issue with my project and I found that these exported rules are disabled by default. I've created PoC here: https://github.com/alpstable/gidari/pull/367.
https://github.com/golangci/golangci-lint/blob/master/pkg/config/issues.go#L80-L103
Check this comment https://github.com/golangci/golangci-lint/issues/2439#issuecomment-1002912465.
Same issues:

https://github.com/golangci/golangci-lint/issues/2827
https://github.com/golangci/golangci-lint/issues/2439
https://github.com/golangci/golangci-lint/issues/456#issuecomment-986701412


fix life time compile error in rust 1.65

Description
This function can not be compiled on 1.65.Here is the error:
error[E0106]: missing lifetime specifier
  --> quickwit-storage/src/local_file_storage.rs:90:69
   |
90 | fn delete_all_dirs<'a>(root: &'a Path, path: &'a Path) -> BoxFuture<'_, std::io::Result<()>> {
   |                              --------        --------               ^^ expected named lifetime parameter
   |
   = help: this function's return type contains a borrowed value with an elided lifetime, but the lifetime cannot be derived from the arguments
help: consider using the `'a` lifetime
   |
90 | fn delete_all_dirs<'a>(root: &'a Path, path: &'a Path) -> BoxFuture<'a, std::io::Result<()>> {
   |                                                                     ~~

For more information about this error, try `rustc --explain E0106`.
error: could not compile `quickwit-storage` due to previous error

By the way, I am curious about why the boxed future are used here, why not just use async fn?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.liyixin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @Liyixin95, thank you for this fix. The future is boxed because the function is recursive.

Hello @Liyixin95 . Can you electronically sign the CLA using the CLA Assistant interface? This is a requirement for us to accept the PR. See the CLA Assistant box above.

Hello @Liyixin95 . Can you electronically sign the CLA using the CLA Assistant interface? This is a requirement for us to accept the PR. See the CLA Assistant box above.

I have signed the CLA before but using a wrong email. Now it's fixed.

Thank you @Liyixin95 !


HBASE-25774 TestSyncReplicationStandbyKillRS#testStandbyKillRegionSer…

…ver is flaky
Wait for the restarter thread to finish before checking the state
Add more detailed logs

@sunhelly This just a start for fixing the flakt UT. PTAL.
Thanks.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 27s
Docker mode activated.

Hi,@Apache9 ,I got it, thanks. HAHA...


Crystal backpack crash

Hello
I have encountered a recurring bug with the crystal backpack. It crashes when i try to add more than 122 stacks to the backpack
crash-2024-08-06_14.49.18-client.txt

Thought I fixed this but I guess not. Are you on version 2.0.0? I will look into this later today.

yep, mod version 2.0.0. neoforge version 21.0.146

Fixed in 2.0.1. Thank you for the report, let me know if you come across any other issues or have any suggestions!


Allow disabling ssl verification on schema introspection

What this PR does
Introduces a flag for disabling SSL verification when using the introspect-schema command:
no_ssl: set this to disable SSL verification. The default value is false, so if the flag is not passed, SSL verification will be enabled.
Why
My team recently decided to use graphql_client_cli for introspecting our GraphQL services but quickly realized that there was no way to do this on a host where https is enabled, hence this flag.
Sample Usage:
$ graphql-client introspect-schema https:/localhost:8080/graphql --no-ssl --header 'Authorization: Basic a5WcefsppefwfeX2pB25Z3JhtleQ='

@tomhoule please could you help take a look at this PR? As far as I can tell, the wasm test failure doesn't seem to be due to these changes.

It's an additional feature to maintain if we want to switch client, but I think it's fine. I'm trying to minimize the scope as much as possible, since as you noticed, I don't have lots of free time for non-work projects at the moment. Thanks for the PR :)

Thanks @tomhoule 🙂


Boilerplate documents from Community Specification

Include the documents that should not be changed from the Community Specification found at https://github.com/CommunitySpecification/Community_Specification
Signed-off-by: Christian Foyer<EMAIL_ADDRESS>

I'm not sure why the DCO check is failing, given there is a sign off in each commit

Let's push it in another branch as we postpone it.


[FEATURE] Implement functionality for Blogs

Is your feature request related to a problem? Please describe.
The blog feature is to be implemented on the website. The entire idea is as follows:-
Every now and then, there will be campaigns running on the website revolving around some theme. Now the alumni will have a feature to write blogs on the website. The alumni will have a choice to dedicate the blog to the campaign running at that time on the website or not. After the blog is published, people can read them and also leave comments.
Describe the solution you'd like!
Now, you are required to implement the models, views, and URLs for the feature. For your ease, the models for the blogs are already implemented in the feature/blog branch in the upstream repository. Feel free to reuse those. Accordingly, views are to be defined for CRUD operation of blogs, filtering of blogs, CRUD operation of campaigns, and CRUD operation of replies.
Describe alternatives you've considered
Feel free to suggest!
Developer Help
Reuse models in feature/blog branch that will give you to better understanding of the data structure of blogs. Also, for reference, could see events and job_postings!

@SamakshAgarwal1112 i would like to work on this issue. i would create the necessary html file to be used  in the templates section. in Views.py i would create the view module to successfully render the html file there and display a formatted output. Also in Urls.py i will define a custom URL so that i can effectively redirect a website to it. Finally i would run python manage.py make migrations. i would adhere to the feature/blog for any help with the schema.

@rohansen856 Your PR in Busify is under review right now and changes have been requested. First, get it completely approved before asking for another issue.

@SamakshAgarwal1112 I would like work on this issue

@LunarShadow152004 Go ahead. You only need to work on the views and URLs for now. We'll see about the HTML templates later.

@LunarShadow152004 What's the issue status?

@SamakshAgarwal1112  I have completed  CRUD operation of blogs and CRUD operation of campaigns


EntryPoint.cpp needs a scopeguard

tests/unittests/EntryPoint.cpp::30
// TODO: move to a scopeguard when we have one in our codebase
The initialize and uninitialize should be done in a scopeguard. This would also reduce the size of the ifdef introduced in https://github.com/Microsoft/WinObjC/pull/634

Not super duper important. Won't fix.


Implement the Path Tool

Create a system for dealing with points.
The visualization part of that involves an Overlays system, but we can ignore visualizing the points for the moment.
De conflicting clicks when multiple points are very close together (using Blender's method of picking the one based on distance from the mouse to the edge connected to that point, so you move your mouse closer to one side or the other of the path edge to prioritize one point or the other)
Points are extracted from all layers but not occluded by the fill of other layers (that's a complexity of behavior we can address later.)

Related: https://github.com/GraphiteEditor/Graphite/issues/99

Mainly this requires a system for bezier paths and dealing with points. We might want to wait until our node system can convert basic shape nodes into bezier paths. Or we can do this earlier (destructively) without the full node sytem.

More or less blocked on the transform API (#251).

For the record: this is also being worked on by @emcat. (Please commit the code so we can continue working on it shortly if you don't have time immediately, by the way. Thanks!)


Added buildEvent input to customise when the plugin runs

Fixes #9
Also adds prettier config, I hope this is ok. If not, please let me know I will remove it or change it to your preferred settings. Your repo after all :)

thanks! LGTM

I'll test and publish a new version soon.


[OpenAI-Assistants] Assistants SDK support for Azure OpenAI v2024-07-01-preview service release

closes #41195
WIP

API change check
APIView has identified API level changes in this PR and created following API reviews.
com.azure:azure-ai-openai-assistants


Run travis tests on real redshift database

Can't currently justify the cost of a redshift database just to run travis tests.

Is this possible via Travis? Wouldn't you really need an EC2 test pipeline?

I'd just create a public redshift database and keep the password encrypted in my .travis.yml

:moneybag:

This is happening. I've stood up a basic single-node cluster at redshift-sqlalchemy-test.cforsfjmjsja.us-west-2.redshift.amazonaws.com:5439 and created klukas, graingert, and travis accounts both for IAM users and for Redshift users.
The IAM accounts all have the "AmazonRedshiftFullAccess" policy attached, so should be able to shutdown and launch the cluster as needed.
The Redshift users are members of a testers group, which has CREATE access on the public and test schemas.
@graingert: Do you have a GPG key I could use to encrypt creds? Let me know if you have other thoughts about how to transmit. Would you be willing to give me Travis access, assuming that's necessary for uploading creds there?
Should we wait on implementing this until https://github.com/zzzeek/sqlalchemy/pull/196 gets sorted? I don't know what the thoughts are right now on updating @binarydud's version. Perhaps there would be benefit to moving this to a redshift_sqlalchemy org?

@jklukas you can just use the travis encrypt instructions at http://docs.travis-ci.com/user/encryption-keys/

I never have to know the password :D

https://api.travis-ci.org/graingert/redshift_sqlalchemy/key

Some example for pytest fixtures:
# -*- encoding:utf-8 -*-
from __future__ import absolute_import, division, unicode_literals

import copy
import contextlib
import itertools
import uuid

from alembic import command, config
import pytest

from somewhere import db
from somewhere import configuration

def database_name_generator():
    template = 'testdb_{uuid}_{count}'
    db_uuid = unicode(uuid.uuid1()).replace('-', '')
    for i in itertools.count():
        yield template.format(
            uuid=db_uuid,
            count=i,
        )

database_name = database_name_generator().next

class DatabaseTool(object):
    """
    Abstracts the creation and destruction of migrated databases.
    """
    def __init__(self):
        self.engine = self.engine_definition.engine()

    @contextlib.contextmanager
    def _database(self):
        db_name = database_name()
        with self.engine.connect() as conn:
            conn.execute('COMMIT')  # Can't create databases in a transaction
            conn.execute('CREATE DATABASE {db_name}'.format(db_name=db_name))

        dburl = copy.deepcopy(self.engine.url)
        dburl.database = db_name

        try:
            yield db.EngineDefinition(
                db_connect_url=dburl,
                connect_args=self.engine_definition.connect_args,
                poolclass=self.engine_definition.poolclass,
            )
        finally:
            with self.engine.connect() as conn:
                conn.execute('COMMIT')  # Can't drop databases in a transaction
                conn.execute('DROP DATABASE {db_name}'.format(db_name=db_name))

    @contextlib.contextmanager
    def migrated_database(self):
        """
        Test fixture for testing real commits/rollbacks.

        Creates and migrates a fresh database for every test.
        """
        with self._database() as engine_definition:
            engine = engine_definition.engine()
            try:
                self.migrate(engine)
                yield {
                    'definition': engine_definition,
                    'engine': engine,
                }
            finally:
                engine.dispose()

    def migrate(self, engine):
        alembic_cfg = config.Config()
        alembic_cfg.set_main_option(
            'script_location',
            self.migration_script_location,
        )
        with engine.begin() as connection:
            alembic_cfg.attributes['connection'] = connection
            command.upgrade(alembic_cfg, 'head')

class RedshiftDatabaseTool(DatabaseTool):
    migration_script_location = 'datascience.alembic:redshift'
    engine_definition = db.EngineDefinition.from_config(
        configuration.config['redshift_testing'],
        'redshift+psycopg2',
    )

redshift_database_tool = RedshiftDatabaseTool()

@pytest.yield_fixture(scope='function')
def _redshift_engine_and_definition():
    with redshift_database_tool.migrated_database() as database:
        yield database

@pytest.fixture(scope='function')
def redshift_engine(_redshift_engine_and_definition):
    """
    A redshift engine for a freshly migrated database.
    """
    return _redshift_engine_and_definition['engine']

@pytest.fixture(scope='function')
def redshift_engine_definition(_redshift_engine_and_definition):
    """
    A redshift engine definition for a freshly migrated database.
    """
    return _redshift_engine_and_definition['definition']

@pytest.yield_fixture(scope='session')
def _session_scoped_redshift_engine():
    """
    Private fixture to maintain a db for the entire test session.
    """
    with redshift_database_tool.migrated_database() as egs:
        yield egs['engine']

@pytest.yield_fixture(scope='function')
def redshift_session(_session_scoped_redshift_engine):
    """
    A redshift session that rolls back all operations.

    The engine and db is maintained for the entire test session for efficiency.
    """
    conn = _session_scoped_redshift_engine.connect()
    tx = conn.begin()
    session = db.RedshiftSession(bind=conn)
    try:
        yield session
    finally:
        session.close()
        tx.rollback()
        conn.close()

https://github.com/sqlalchemy-redshift

To be able to work in parallel travis will also need create/drop privileges

My plan for the lifetime of the cluster is a single schema with a single table with a single column.
Pseudo code:

idem-potently boot redshift cluster
test_sess = uuid.uuid4()
"INSERT INTO test_sessions (test_session,)
VALUES (:uuid)".params(uuid=test_sess)
run tests
"DELETE FROM test_sessions WHERE uuid=:uuid".params(uuid=test_sess)
if not "EXISTS SELECT * FROM test_sessions":

Shutdown cluster.

Is @binarydud cool with the idea of transferring ownership to https://github.com/sqlalchemy-redshift?

@graingert: It looks like you have a good handle on the structure we should be using for running tests against the real Redshift environment, but I'm not quite sure how to take your example code and actually run tests from it. Would you be willing to start a branch that sets up the fixture and gives an example test using the database? I can incorporate that back in and build test for #17 on it.

I added a .travis.yml clause that puts a relevant PGPASSWORD to the environment to go along with the travis Redshift user: https://github.com/graingert/redshift_sqlalchemy/commit/3da0832096543957c16df9d788217466f08edafc

Can do, if you want to have a stab at it in the meantime if you can't wait
for me you can have a look at https://pytest.org/latest/fixture.html for
how to use my example code
On 20 Aug 2015 19:50, "Jeff Klukas"<EMAIL_ADDRESS>wrote:

@graingert https://github.com/graingert: It looks like you have a good
handle on the structure we should be using for running tests against the
real Redshift environment, but I'm not quite sure how to take your example
code and actually run tests from it. Would you be willing to start a branch
that sets up the fixture and gives an example test using the database? I
can incorporate that back in and build test for #17
https://github.com/graingert/redshift_sqlalchemy/pull/17 on it.
—
Reply to this email directly or view it on GitHub
https://github.com/graingert/redshift_sqlalchemy/issues/9#issuecomment-133116801
.

Fixed in https://github.com/graingert/redshift_sqlalchemy/pull/19


cordova serve command does nothing

cordova serve command does nothing, not even a error message.. I already added a browser platform, am I forgetting something :confused: ?

Please use cordova run [platform] -- --lr command instead.
OR
cordova build [platform] then cordova run [platform].
Take note that the -- --lr will make the webpack automatically inject corresponding platform cordova.js


Screen blank - selective

Description of the new feature / enhancement
Currently, the only options are PC screen only or second screen only.
It's useful to be able to select one or more screens selectively when more than one external monitor is attached.
Scenario when this would be used?
when more than one external monitor is attached
Supporting information
No response

/dup #1052


Edited readme file

These changes in the readme aim to make the instructions where to run which command to build bindings and apps more clear.

Hi @blackplane, we haven't heard back from you for awhile - can we close this PR, or did you want to discuss any changes?

Hi @blackplane, we haven't heard back from you for awhile - can we close this PR, or did you want to discuss any changes?

Closing the PR as there is no activity.


Migrate FSTQueryTests to C++ / remove FSTQuery

This is the last PR in the chain that fully migrates FSTQuery to C++ Query.

Note the diffbase on #3484. Once that lands I'll retarget this one.


Can‘t find this file "apa_plasmid_data.pickle"

Hello,
I want to learn and run your code, but I can't find the data you use, such like
"apa_plasmid_data.pickle", can you tell me where I can find it？Thank you very much.

Hi,
Sorry for the late reply. .pickle files are not the best to share since they are OS-dependent, so I re-saved the processed data as a .csv file (readable with python package pandas) and a .mat file (readable with scipy.io.loadmat). I have uploaded the data to the google drive and you can find it at the following link: https://drive.google.com/file/d/1NMqA0-xohZ1b2cduENLU8W-idi0KOHQi/view?usp=sharing
Please let me know if you run into any other issues.
Best,
Johannes

@johli It is a great honor for you to reply to me, I see. thank you very much！


add error log on SSO check failure

While trying to debug my problems described in #5330 I found that the failing check was the problem. This adds some error log to inform the user about the failure, otherwise there is no indication that the check has not passed.

@hvraven while this will appear in the logs, it won't be visible to the front-end user. This is a good starting point, thought.

Yes, I am aware. This is only targeted at the admin. Right now the admin doesn't receive any information either. There are for sure better solution than this, but it's simple :-)

I included a fix for the problem described in #5330. I did however not check it on any other providers than the microsoft graph provider.


Don’t restrict edition of build.gradle.kts

It would be great to allow commits to be pushed on version branch of the commit only edits the build.gradle.kts to update version.
Have to check if this is possible

After some research done, this would require some fancy CI. This is overkill so we're gonna forget this idea.


Update openjpeg build (bug 1896577)

It just contains fixes for:

bug 1896577
https://github.com/mozilla/pdf.js.openjpeg/issues/1

/botio test

The _scriptDir (pre patch) / _scriptName (post patch) variable is used to populate the scriptDirectory variable, which is not used anywhere (at least no references to it other than assignment). document.currentScript is already used inside the code to populate scriptDirectory, before unconditionally replacing it with the value of _scriptDir.
@calixteman Why did you introduce _scriptName instead of deleting the use of _scriptDir?

The _scriptDir (pre patch) / _scriptName (post patch) variable is used to populate the scriptDirectory variable, which is not used anywhere (at least no references to it other than assignment). document.currentScript is already used inside the code to populate scriptDirectory, before unconditionally replacing it with the value of _scriptDir.
@calixteman Why did you introduce _scriptName instead of deleting the use of _scriptDir?

Unfortunately, almost all the js in this file is generated by emscripten.
The only js I added is:

https://github.com/mozilla/pdf.js.openjpeg/blob/main/src/myjs.js
https://github.com/mozilla/pdf.js.openjpeg/blob/main/src/mypre.js

So it's a bug in emscripten.

Thank you for improving this!


Paramiko.ssh_exception.SSHException: Error Reading SSH Protocol Banner.

Can anyone help.?
I keep getting Error: Paramiko.ssh_exception.SSHException: Error Reading SSH Protocol Banner.
when i try to disable the SSH on cisco switch. the SSHException is not working..
cisco version: Cisco IOS Software, C2960X Software (C2960X-UNIVERSALK9-M), Version 15.2(2)E6, R
netmiko
VERSION
4.1.2
paramiko
VERSION
2.12.0
my python file script:
from netmiko import ConnectHandler
from netmiko.exceptions import NetMikoTimeoutException
from paramiko.ssh_exception import SSHException
from paramiko.ssh_exception import AuthenticationException
IP_LIST = open('15_devices.txt')
for IP in IP_LIST:
print ('\n'+ IP.strip() + '  \n' )
RTR = {
'ip':   IP,
'username': 'cisco',
'password': 'cisco123',
'device_type': 'cisco_ios',
'secret': 'cisco123',
}
try:
    net_connect = ConnectHandler(**RTR)
except NetMikoTimeoutException:
    print ('Device not reachable.')
    continue
except AuthenticationException:
    print ('Authentication Failure.')
    continue
except SSHException:
    print ('Make sure SSH is enabled in device.')
    continue

output = net_connect.send_command('show ip int brief')
print(output)

I think you might have posted this in the wrong issue queue. Can you double-check where you intended to post this?


Feature Request: Image upload

Editor lacks of image uploading function, it's an essential feature in rich editing.
Wish this will be shown in the demo example.
Thanks.

Image uploading is a tight integration process between the back-end and a front-end. This library (as well as TipTap) are front-end only libraries. They do not know how to upload to a server and that process can be as diverse as it gets.
Best that can be done by a front-end library is image insertion from a URL and then styling that with different styles and crops.
You can enable <img> elements by adding the Image extension and then have it in the :extensions="[Image]" prop. Then you need to create a block/inline tool to suit your back-end needs that can upload to your server and finally you can use the resulting url to insert the image into the editor:
  editor
    .chain()
    .focus()
    .setImage({
      src: url,
      alt: alt || undefined,
      title: title || undefined,
    })
    .run();

Having said all that - my latest project's server is on Directus, and my front-end is on Nuxt, so I can add an file upload input that is scoped to certain file types, then handle the upload when the user picks a file and the server gives me a file object:
<script setup lang="ts">
const props = defineProps<{
  editor: Editor;
}>();

const input = ref<HTMLInputElement | null>(null);

const assetsBase = "https://api.myserver/assets";

const handleFiles = async () => {
  const { files } = input.value || {};
  const [first] = files || [];
  if (first) {
    const data = new FormData();
    data.append("file", first, first.name);
    const result = await useDirectus<DirectusFiles>(uploadFiles(data));
    const { id, title } = result;
    const url = `${assetsBase}/${id}`;
    props.editor.chain().focus().setImage({ src: url, alt: title || undefined, title: title || undefined }).run();
  }
};
</script>

<template>
  <!-- other stuff like show preview of previous upload and wrap the input below, since it is visually hidden -->
  <input
    ref="input"
    accept=".jpg,.jpeg"
    type="file"
    class="absolute inset-0 z-[2] w-full cursor-pointer appearance-none border-none opacity-0 focus:outline-none"
    @change="handleFiles"
  />
  <!-- other stuff like upload button, upload progress, errors, deletion -->
</template>

As you can see - my process is most probably super specific to my and cannot be applied for everyone.

I guess the demo can show use of an Image but simply asking for a URL.

@fasthold Alternatively you can use an upload image extension like this one: https://github.com/carlosvaldesweb/tiptap-extension-upload-image

Agree with both of you! Like @avioli says it is project specific, but we should show a couple of examples in the demo – perhaps the tiptap extension linked to plus a custom solution using a Vue component that uses something like FilePond as I think this will demonstrate how easy it is to do something custom.

@johnpuddephatt That's a very good idea, although I've used FilePond in a couple of projects and I'm not sure it will work great within a contenteditable area, but I'll be happy to be proven wrong!

What about the image files encode immediately as base64 img src. This can fix the upload problem. And it's serverless. ?

@eguvenc It is an option, but base64 is inherently making binary files take larger space, because they are limited to a smaller sub-set of characters.
From StackOverflow:

Base64 encodes each set of three bytes into four bytes. In addition the output is padded to always be a multiple of four.
This means that the size of the base-64 representation of a string of size n is:
ceil(n / 3) * 4
So, for a 16kB array, the base-64 representation will be ceil(16*1024/3)*4 = 21848 bytes long ~= 21.8kB.
A rough approximation would be that the size of the data is increased to 4/3 of the original.

So a 1 MB file would become 1.3 MB, 5 MB => 6.67 MB, 10 MB => 13.3 MB
The file will be embedded into the resulting HTML, or JSON. It really depends what you want to achieve.


Update dependency com.ibm.icu:icu4j to v64

This PR contains the following updates:

Package
Update
Change
References

com.ibm.icu:icu4j
major
51.2 -> 64.1
homepage, source

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

PR has been edited
:construction_worker: This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

PR has been edited
:construction_worker: This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.


Add metrics and better reporting for geocoding issues

Right now the user seems to receive always a generic error message, regardless of what happens in geocoder. Also we do not store appropriate info to see different error causes in Kibana.
I suggest to add an error_code field and populate it accordingly.

There has been no activity on this issue for more several months. We are closing it. If you think this still needs to be addressed please open a new issue.


FeatureFormView - Initial attachments implementation

Apollo 408
Mock API Plugin: AttachmentsPlugin.zip

Closing - as discussed the FeatureFormAttachments branch is further along now and incorporates some of these changes


Integrate in the osm.org UI

This thing is great!! This should be part of the UI on openstreetmap.org!
Kudos to the devs.

Thanks (on behalf of the maintainers & creators)! Feel free to suggest that on openstreetmap-website, where decisions about the website are made.


close #87, make member fallible

Closes #87
This also drops the any.rs Bool trait and PhantomData in favor of const generics.

Looks good. Nice use of const generics! I'll pull in the README change from main and merge.


Support Sequence[PystacItem] as an argument to stackstac.stack() method

The stack method currently supports numerous forms of data for the items parameter:
def stack(
    items: Union[ItemCollectionIsh, ItemIsh],
...

ItemSequence = Sequence[ItemDict]

ItemIsh = Union[SatstacItem, PystacItem, ItemDict]
ItemCollectionIsh = Union[
    SatstacItemCollection, PystacCatalog, PystacItemCollection, ItemSequence
]

However, one thing it doesn't support is a Sequence[PystacItem]. This would allow clean integration with pystac-client:
stack = stackstac.stack(list(Client(...).search().items()))

(also the get_all_items() method in the docs is now deprecated in favor of the items() iterator)
This change would also require a change to:
def items_to_plain(items: Union[ItemCollectionIsh, ItemIsh]) -> ItemSequence:

to handle the case where the Sequence is either a dict representing an item or a pystac.Item.

🎉


docs: update README.md

Javacsript -> Javascript

@eltociear Could you resolve the conflict in the readme?

Wait, I just realized that typo was already fixed so there are 0 changes in this PR if I am not mistaken.

Ok then I ll close this PR. Thanks though 🙏


WebSocket close with status code 1006

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.94.2
OS Version: Windows_NT x64 10.0.22631

At the beggining of this week, i was working perfectly with vscode, but with no cause, the VSCode stopped to coonect with my WSL server. Others tools like VSCodium works, just VSCode dont connect and throw the error WebSocket close with status code 1006. Anyone is passing through this?
Steps to reproduce:

open wsl
type code .

Logs:
INFO Invoking resolveAuthority(wsl)...
INFO [LocalProcess0][resolveAuthority(wsl,1)][0ms] obtaining proxy...   workbench.desktop.main.js:624
INFO [LocalProcess0][resolveAuthority(wsl,1)][0ms] invoking...   workbench.desktop.main.js:624
INFO [LocalProcess0][resolveAuthority(wsl,1)][1003ms] waiting...   workbench.desktop.main.js:624
INFO [LocalProcess0][resolveAuthority(wsl,1)][2038ms] waiting...  workbench.desktop.main.js:624
INFO [LocalProcess0][resolveAuthority(wsl,1)][2299ms] returned WebSocket(<IP_ADDRESS>:54159)   workbench.desktop.main.js:624
INFO resolveAuthority(wsl) returned 'WebSocket(<IP_ADDRESS>:54159)' after 2300 workbench.desktop.main.js:624
INFO Creating a socket (renderer-Management-0ba9a81c-52aa-4933-a1b0-ea4865902390)... workbench.desktop.main.js:624
INFO Creating a socket (renderer-ExtensionHost-25c9d341-d7fd-4a71-9df8-f5129556ac9f)... workbench.desktop.main.js:656
WebSocket connection to 'ws://<IP_ADDRESS>:54159/stable-695af097c7bd098fbf017ce3ac85e09bbc5dda06?reconnectionToken=0ba9a81c-52aa-4933-a1b0-ea4865902390&reconnection=false&skipWebSocketFrames=false' failed: b @ workbench.desktop.main.js:656
INFO Creating a socket (renderer-Management-0ba9a81c-52aa-4933-a1b0-ea4865902390) returned an error after 420 ms.
workbench.desktop.main.js:624
ERR CodeExpectedError: WebSocket close with status code 1006  at WebSocket.<anonymous> (workbench.desktop.main.js:656:3111)

Can you add the WSL log as well? Command WSL: Show Log...

Closing due to lack of additional information


Incomplete bottom sheet appears in landscape mode

Summary:
Incomplete bottom sheet appears on clicking more option tab in landscape mode, and It is also not scrollable.
Steps to reproduce:
Switch to landscape mode, then open more option tab in bottom navigation bar
What did you expect the app to do, and what did you see instead?
Bottom sheet appeared should be scrollable till the bottom.
Device and Android version:
Device: Pixel 3 emulator, Android 10
Commons app version:
3.0.0-debug
Branch: Master, Build Variant: betaDebug.
Screen-shots:

Would you like to work on the issue?
Yes

@Pratham2305 Feel free to work on this issue

@Pratham2305 Feel free to work on this issue


fix: tootips bug

Description of PR

Fixing a React bug that prevented tooltips from showing up. Issue #145
What component(s) does this PR affect?

[ ] Back-End (Node.js, Next.js)
[x] Front-End (React.js)
[ ] Theming (CSS, React theme)
[ ] Build System
[ ] Docs

Does the PR require changes on other components? If yes, please mark the components:

[ ] Back-End (Node.js, Next.js)
[ ] Front-End (React.js)
[ ] Theming (CSS, React theme)
[ ] Build System
[ ] Docs

Related Issue

Resolves #
Solution

Type

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Docs update
[ ] None of the above

Checklist:

[ ] I have read the contributing guide and my code conforms to the guidelines.
[ ] This change requires a change in the documentation.
[ ] I have updated the documentation accordingly.

)`>>>)>

This was simple :) Did you check it with an instance? If yes, approving. Thanks Alex!

Yes I tested locally!


aspnetcore-runtime-2.2 shows in index but seems to be missing from repo

Problem encountered on https://dotnet.microsoft.com/download/linux-package-manager/runtime-aspnetcore-2.2.8
Operating System:
Centos 7
Provide details about the problem you are experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.
aspnetcore-runtime-2.2.8 seems to be missing from the repo. yum search aspnet returns aspnetcore-runtime-2.2.x86_64 : Microsoft ASP.NET Core 2.2.8 Shared Framework but
yum install aspnetcore-runtime-2.2 returns aspnetcore-runtime-2.2.8-rh.rh FAILED https://packages.microsoft.com/rhel/7/prod/aspnetcore-runtime-2.2.8-rh.rhel.7-x64.rpm: [Errno 14] HTTPS Error 404 - Not Found

dup? https://github.com/dotnet/core/issues/3863

Yeah looks like I didn't search thoroughly enough. My bad, I'll close the issue as a dup.


Don't see edit sessions in desktop

Testing #156211

Store an edit session in vscode.dev for a GH repo
Open desktop Insiders
Use GH Repositories extension to open same remote GH repo
Edit Sessions view is empty - since I'm logged into GH in both web and desktop, I anticipated seeing my 3 edit sessions from vscode.dev here:

Duplicate of https://github.com/microsoft/vscode/issues/156235. If you run the 'Focus on All Sessions View' command, do your edit sessions show up?
In tomorrow's insiders that view container should only appear in the sidebar after you explicitly run the command to Show Edit Sessions.

If you run the 'Focus on All Sessions View' command, do your edit sessions show up?

These are the only edit session commands I see in desktop today:

I see more options in vscode.dev than desktop - should I be seeing more of these options in desktop?

Ah, I had to select the ... menu in the Edit Session view, and choose to "Show all sessions." Now I can see the session from vscode.dev.
I would've expected to see all my edit sessions by default.

@bamurtaugh that shouldn't happen, the 'Edit sessions' view container should be hidden unless the 'All sessions' view is also showing. Do you recall how you got the edit sessions container to show up without the sessions 😅?

I believe these were my steps:

Make an edit and store a session in vscode.dev
Open same repo via GH Repositories in desktop VS Code
Make an edit and store a session in desktop
Storing in desktop prompts me to log into GH
Once logged in and the session is stored, run command to Show Edit Sessions
Confused because Edit Session view is empty
I manually select ... menu in Edit Session view to Show all sessions, and then I can see my sessions (I guess the web ones were hidden by default in desktop)

:+1: tracking as https://github.com/microsoft/vscode/issues/156338

Confused because Edit Session view is empty
I manually select ... menu in Edit Session view to Show all sessions, and then I can see my sessions (I guess the web ones were hidden by default in desktop)

I couldn't repro this yesterda on desktop, but just repro-ed this with a clean user data dir, this is a bug with the Show Edit Sessions action. It should focus the view, not the container.

This bug has been fixed in the latest release of VS Code Insiders!
@bamurtaugh, you can help us out by commenting /verified if things are now working as expected.
If things still don't seem right, please ensure you're on version 1259bfe0090ac90afbf5d53335c43761de6bb19f of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.
Happy Coding!

@joyceerhl I'm trying to test this again, but I don't see any edit session commands:

Am I missing something?

/verified


Use zig for more flexible build configuration

Use zig for more easily building against different targets and GLIBC versions.

@akrousset Switched the build to use Zig. Eliminates the need to use custom images for building and allows us to configure the GLIBC version to build against without having to change hosts.

😮


BugFix: Visuals from Applications available in Dashboards

Description
[Describe what this change achieves]
Allowed saved visuals from applications to be viewable from the logs home screen and for them to be added to dashboards.
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@TackAdam This is not a bug. This decision was made by the team to keep application analytics as a single entity. For the Users, App Analytics doesn't have its objects overlapping with Events and Obs. Dashboards.
Do we have an issue where users are asking to this? or Did we discuss with the UX team for this behavior?

The existing cypress testing runs test with the impression that they will be viewable, and such fails. This led me to believe it was a bug, I can remove the cypress testing that acts under that assumption if we'd like to keep it as is.

The cypress tests expects that App Analytics remains separate form the other plugin components:
https://github.com/opensearch-project/dashboards-observability/blob/main/.cypress/integration/7_app_analytics.spec.js#L452-L517


Performance improvement for the connection phase

Improved performance of the VerifyPoupardStern by verifying  x values in parallel rather than sequentially.

@osagga  can you quick check

Make sense. I just wait @osagga go to be sure. But this seems perfect to me.


Added Varsha to OWNERS file

Issue link

What changes have been made

Verification steps

Checks

[ ] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[ ] Manual tests
[x] Testing is not required for this change

/approve


manual window resize event is changing the active slide

Hi there,
i am using this plugin for quiet sometimes now. loving this.
recently facing an issues which i am unable to resolve.
in my page, during some button click action i needed to trigger window resize event in an specific way,
that is, window.dispatchEvent(new Event('resize'));
but after this line has been executed every time, the slider active slide changes to index 0 (first slide). it does not trigger onSlideChangeEnd event, but just change the active slide to first slide.
this isn't normal. let me know how i can resolve it.
Thanks in advance.

Would be good to see JSFiddle with the issue


Duplicate parents after load_node, crashes chromium

I have a JSTree instance, using AJAX to load data.
I perform a data upload via another AJAX call, which completes, then I want to reload the node that I put the data in to refresh it. So then I perform a load_node on the parent node that the new nodes are to be created in, to refresh it, it creates invalid data in the _data structure.
I call $('#studyDataDiv').jstree("load_node", "/root");
There are duplicate parents, self parents, see screenshot

/root is its own parent

all children have duplicate /root in their parent list

Thank you for an amazing tool.

This means something is wrong with your data - there should be no duplicates. Keep in mind the ajax response should only include THE CHILDREN of the specified node, not the node itself.

Yeah I found the problem in my code. My bad. Thanks.


OpenPulse-specific syntax present in OpenQASM 3.0 contexts

Summary
There are some places in our documentation where OpenPulse-specific constructs are used outside of cal and defcal blocks.  We either need to:

change these examples to put those parts inside cal blocks
update the text of the spec to allow calibration-grammar constructs to be present in additional situations.

This is so in the future, if a new defcalgrammar is developed outside of the OpenQASM 3 effort directly, we're better defining where its additional grammar constructs are actually valid.  I think it's most likely that the examples probably just want putting inside cal blocks, for the most part.
Details
On the OpenPulse pages of the specification, there are some cases where OpenPulse types are used outside of cal or defcal blocks.  For example, one of the Capture Instruction examples says:
// Use a boxcar function to generate IQ data from raw waveform
extern boxcar(waveform input) -> complex[float[64]];
// Use a linear discriminator to generate bits from IQ data
extern discriminate(complex[float[64]] iq) -> bit;

cal {
    // Define the ports
    extern port m0;
    extern port cap0;
}

// ... and so on ...

The first extern uses the waveform type as an input, which isn't a valid type in OpenQASM 3 (it's in OpenPulse).  I suspect the extern functions just want moving into the cal block - this is how the calibrations in practice section presents such examples.
The page on general pulse grammars also has wildcard physical qubits matched as $<identifier> (e.g. $q instead of q).  That seems a bit inconsistent to me (why not use q? The $ usually represents a specific hardware qubit, but that's not the case here - it's a stand-in for any qubit.), but not really an issue.

The consensus from the TSC meeting on 2022-06-17 was that the extern function definitions I mentioned here ought to be within cal blocks.  There is tentative agreement to change the wildcard identifier in defcal statements from $<identifier> to simply <identifier> on the basis of consistency with the rest of the language.
I will make two separate PRs:

add the cal statement to the ANTLR reference parser (and update defcal statements to correctly tokenise the unknown grammars, since they coincide)
change the text of the spec to drop the initial $ from wildcard identifiers (but not general hardware qubits)

The spec-change PR is not pre-approved - there was originally a reason for including the $, but either people's minds have changed a bit since then, or people couldn't fully remember the original reason.  The review of that PR will be another chance for people to argue in favour of the leading $.


Docker in Docker Build Fails

Summary of Problem

What are you trying to do?
Build a docker image of my application from a CI environment (Bitbucket Pipelines).

What happens?
Whether I run npm install directly or run npm install serialport --build-from-source, I get the same error output:

npm ERR! code E404
npm ERR! 404 Not Found: event-stream@https://registry.npmjs.org/event-stream/-/event-stream-3.3.6.tgz

What should have happened?
The package should have installed.

Versions, Operating System and Hardware

SerialPort@? 6.2.2
Node.js v?8.9.3
Windows? Linux? Mac? Linux (docker:dind)

Thanks for the feedback. I've just upgraded to 7.1.0 and got exactly the same error.

Sorry my bad. I have a  a real problem building with serialport in Docker in Docker but this wasn't it. I'll close this and report the problem in a new issue.


fix: define initial position of image overlay based on story layout

Issue: #26
Now the addon should take the layout parameter into account when displaying the image overlay. It's very tricky to get the correct position when the layout is 'centered', given that the addon is running outside of the context of the story iframe, so I think for now it's already great that it will work for the most used layouts, which are 'padded' and 'fullscreen'.

Long time no see @mertkahyaoglu, thanks for checking my contributions! I hope all is well!


Repair tests

Tests have been broken and development has continued. This repairs the
broken tests and removes tests are needed anymore.


New version: Guru3D.RTSS version 7.3.6

Pull request has been created with komac v2.1.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Installation failed with exit code -1978335141
2024-03-26 14:16:18.469 [CLI ] Unable to locate nested installer at: C:\Users\VALIDA~1\AppData\Local\Temp\WinGet\Guru3D.RTSS.7.3.6\extracted\Guru3D-RTSSSetup735.exe

(Automated response - build 875.)


Update Search-MailboxAuditLog.md

Removed External from LogonTypes param description per Issue #6358.

Docs Build status updates of commit e347a6a:
:clock10: Full build: the average full build time is 17 min(s) 37 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit e347a6a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Search-MailboxAuditLog.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


[BREAKING] Add ECS user namespace

Changes
Added a user namespace from ECS. We in security using almost all fields for security detection rules. But this namespace might be useful for other events as well to define the user of the event
Merge requirement checklist

[x] CONTRIBUTING.md guidelines followed.
[x] Change log entry added, according to the guidelines in When to add a changelog entry.

If your PR does not need a change log, start the PR title with [chore]

[ ] schema-next.yaml updated with changes to existing conventions.

Addition about enduser namespace.
I'm wondering where term enduser came from and should we update it to more generic user?
For example in security we also operate with user, real user, saved user, effective user etc. All these users are having the same fields because they are represented using nested namespaces.
Also I have checked existing fields for the enduser:

id, has double meaning, it can represent both id and username. I propose to split it into id and name as in this PR
role -> change to the array of roles to align with ECS but also because one user could have multiple roles assigned.
scope, stays the same, there is no conflicts with ECS fields

please let me know about your thoughts.

As discussed during semconv meetings I am deprecating existing enduser namespace in favour of user namespace
@lmolkova @jsuereth about sensitive tagging:
We do have sensitive tags but we don't use them in the registry. I think we should define and use them directly in registry. I can't think of a use case where the same field might be used as sensitive in one place and not sensitive in another place. WDYT?

The url https://docs.datastax.com/en/cassandra-oss/3.0/cassandra/dml/dmlConfigConsistency.html seems to working. Not sure why check is failing

We do have sensitive tags but we don't use them in the registry. I think we should define and use them directly in registry. I can't think of a use case where the same field might be used as sensitive in one place and not sensitive in another place. WDYT?

I think marking them only in the registry certainly makes sense, otherwise, you need to mark them in a combination of. I can't imagine scenarios where the context is important for the sensitivity.

@alexvanboxel could you re-check your review? thanks


alf configuration

Hey all,
Sorry bit of a complete newb here, so this might be common knowledge but when configuring the main apple firewall my system has a com.apple.alf.pllist in the /usr/libexec/ApplicationFirewall folder. It does some interesting things like permanently allow netbios, etc. Was wondering if someone with more experience can take a look at this, and let us know if this is known/approrpiate or something that should be configured in addition to the wonderful guide already posted.
Thanks again for all of your guys' time and effort.

Not sure about this. Resolving.


Build: Upgrade gRPC version.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@2a17c84). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2001   +/-   ##
=========================================
  Coverage          ?   83.31%
  Complexity        ?     2250
=========================================
  Files             ?      318
  Lines             ?    10505
  Branches          ?     1047
=========================================
  Hits              ?     8752
  Misses            ?     1415
  Partials          ?      338

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a17c84...43d4f5a. Read the comment docs.


Crash when printing into stdout inside of nif load callback

When you print something into stdout inside erlang nif initialization callback
https://erlang.org/doc/man/erl_nif.html#initialization
int (*load)(ErlNifEnv* caller_env, void** priv_data, ERL_NIF_TERM load_info)
ElixirLs in VScode will hang without any timeout on formatting or pretty much any other action.

There will be no output in ElixirLs logs after MIX_TARGET:
However in VScode console there will be a lot of those messages

Workaround
Use stderr instead of stdout.
In the case of rust it will be eprintln! instead of println!.
Minimal reproduction
https://github.com/kaaboaye/elixir-ls-stdout-when-nif-load-bug-reproduction/blob/main/native/demo/src/lib.rs
https://github.com/kaaboaye/elixir-ls-stdout-when-nif-load-bug-reproduction/blob/main/lib/plskillme.ex
Environment

Elixir & Erlang versions (elixir --version):  Any I think, but tested on Elixir 1.12 OTP 24
Operating system:  Arch on x86_64 and MacOs on AARM
Editor or IDE name (e.g. Emacs/VSCode):  VSCode
Editor Plugin/LSP Client name: ElixirLS

That's expected as elixir-ls uses stdio for communication with the client. Language Server Protocol (https://microsoft.github.io/language-server-protocol/specifications/specification-current/#implementationConsiderations) states that pipes or sockets can be also used but none of this is currently supported nor planned though a PR would be welcome. For now please ensure that your NIFs do not write to stdout nor read from stdin.

Sure I fully understand the wontfix however it could be a good idea to add this case to the troubleshooting section.

it could be a good idea to add this case to the troubleshooting section.

Sure. A PR would be welcome


Subscribe to your maintainer feed!

Repology has added support for tracking each maintainer of each KISS package. This allows you to subscribe to a feed and be notified of when your packages need updating.
Steps:

Go to: https://repology.org/maintainers/
Find your profile via your set Git email.
Subscribe via HTML or RSS.

Closing this and keeping it pinned to the top.


ardusat sdk is not available for download??

trying to download sdk to use in arduino. video said to download but it is not a choice

It should be under the "Code" button, and then "Download Zip":


While trying to run MatrixFactorization with default arguments there is this exception:

Exception TypeError: TypeError("'NoneType' object is not callable",) in <bound method _NonClosingTextIOWrapper.__del__ of <_io.TextIOWrapper encoding='UTF-8'>> ignored

Why ? any ideas?..

Is your data numpy array or something else?

Feel free to reopen if you have this issue again.


Setting datadog agent permissions to log file not working

Describe what happened:
  ----------
    - Type: file
      Path: /home/ubuntu/Projects/livestream/nohup.out
      Status: Error: cannot read file /home/ubuntu/Projects/livestream/nohup.out: stat /home/ubuntu/Projects/livestream/nohup.out: permission denied
      BytesRead: 0
      Average Latency (ms): 0
      24h Average Latency (ms): 0
      Peak Latency (ms): 0
      24h Peak Latency (ms): 0

Describe what you expected:
I expect that after I confirm permissions with getfacl, datadog agent can read the log file:
# file: Projects/livestream/
# owner: ubuntu
# group: ubuntu
user::rwx
user:dd-agent:r-x
group::rwx
group:dd-agent:r-x
mask::rwx
other::rwx

ubuntu@ip-172-31-38-150:~$ getfacl Projects/livestream/nohup.out
# file: Projects/livestream/nohup.out
# owner: ubuntu
# group: ubuntu
user::rwx
user:dd-agent:r-x
group::---
group:dd-agent:r-x
mask::rwx
other::rwx

sudo systemctl restart datadog-agent
sudo datadog-agent status

Steps to reproduce the issue:
Go through this guide https://docs.datadoghq.com/logs/guide/setting-file-permissions-for-rotating-logs/
Additional environment details (Operating System, Cloud provider, etc):
AWS Linux

I ran into this issue as well, some concrete info about my situation:

The EC2 instances are AWS EMR v6.8.0

I'm configuring log file reading for the following:
/mnt/var/log/bootstrap-actions/master.log
/mnt/var/log/bootstrap-actions/1/controller
/mnt/var/log/bootstrap-actions/1/stderr
/mnt/var/log/bootstrap-actions/1/stdout

All those log files are owned by the hadoop user and group

No amount of sudo chmod -R o+rx /mnt/var/log/bootstrap-actions or sudo chown -R dd-agent:dd-agent /mnt/var/log/bootstrap-actions/* fixed my issue. Instead, https://stackoverflow.com/a/72410946 solved my issue with sudo usermod -aG hadoop dd-agent.


is render_partial working ?

salut !
I'm playing a little with this repo, after I spent too much time parsing htmx headers so I like the HTMXDetails class a lot now,
However, I started the example but it seems like instead of rendering html, render_partial is rendering a string of that html ...
see the screenshot for a better description
is there anything I'm doing incorrectly ?

well I see how to fix it in the examples but I'm not sure it's the correct way, one could add safe to tell jinja2 to escape the created html
https://github.com/florimondmanca/asgi-htmx/blob/f25e1545869bd599b69cfd0fbb049bcf4825a2d3/examples/templates/home.html#L12
could become:
{{ render_partial('partials/clickme.html', request=request) | safe }}
there might be a better way ?

ok there is: https://github.com/florimondmanca/asgi-htmx/pull/9

subsequent question: should render_partial be part of the library ?

Hello, and thanks! I think adding markupafe is correct since that’s what Jinja-partials does too: https://github.com/mikeckennedy/jinja_partials/blob/main/jinja_partials/init.py (and we can expect our own templates to be « safe »)

should render_partial be part of the library ?

Not sure? I think people can use jinja-partials. Although I’m curious how most people currently do in practice?
(Initially I copied the code over and adapted it because it was easier to add a Quart utility that way, and I think it’s okay for things to stay this way?)

Hmm, so based on https://github.com/PyHAT-stack/awesome-python-htmx  there’s also https://github.com/sponsfreixes/jinja2-fragments
It’s slightly different because it provides a render_block utility instead of render_partial, leveraging the {% block %} which seems to be the preferred, more abstracted way now (in fact reflecting non-htmx solutions such as Turbo Frames).
It says it supports “Flask, FastAPI, Quart”, but actually the “FastAPI” module is pure Starlette. So it’s pretty much misbranded… IMO it should be a Starlette module presented as “works with any Starlette-based framework, such as FastAPI”, which incidentally unlocks much more framework compatibility. Maybe I’ll open a discussion there about this.
Anywah, maybe we could rework the example code to use that since it has all the integrations we need for tests. Just a note.


Best method to filter by boolean value

I am looking for a simple method, to filter records by an boolean value. According to the documentation, the filter value can be either
?(undefined|number|string|Date|Array|IDBKeyRange|Object<string, (number|string|Date|Array|IDBKeyRange)>|function(*, (number|string|Date|Array)): boolean)=} filter

See https://github.com/jurca/indexed-db.es6/blob/master/es6/object-store/query-engine.js
Example usage:

// The filter
const bestFriendFilter = {
  buddy: true
}

// The query
database.getObjectStore('batmans_friends')
               .query(bestFriendFilter, null)
               .then((records) => {
  // Expected result
  console.log(records); // [{id: 2, name: "Robin", driverLicense: false, buddy: true}]
});

DataError: Data provided to an operation does not meet requirements.

However, the above example does not work, but I was able to run the filter by using a function like this:
function(record) {
  return record.buddy === true;
}

@jurca What is the recommended way, to run query filters?

Hello,
you filter object does not match the Object<string, (number|string|Date|Array|IDBKeyRange)> type. The problem with using booleans in filter is that boolean is not a valid IndexedDB key type - this is a limitation imposed by the IndexedDB itself.
There are multiple ways to work around this limitation:

store the boolean flag as a number, a 1 for true and 0 for false
use a filter function, for example: record => record.buddy

The first one should have a better performance (if you create an index on the buddy field), the latter lets you to keep your boolean values.
I hope this helps :).

Thanks mate


Memory required with model medium and large

I'm downloaded model Medium and Large at https://ggml.ggerganov.com/
After run:
whisper_init_from_file: loading model from 'ggml-model-whisper-medium.bin'
whisper_model_load: loading model
whisper_model_load: n_vocab       = 51865
whisper_model_load: n_audio_ctx   = 1500
whisper_model_load: n_audio_state = 1024
whisper_model_load: n_audio_head  = 16
whisper_model_load: n_audio_layer = 24
whisper_model_load: n_text_ctx    = 448
whisper_model_load: n_text_state  = 1024
whisper_model_load: n_text_head   = 16
whisper_model_load: n_text_layer  = 24
whisper_model_load: n_mels        = 80
whisper_model_load: f16           = 2
whisper_model_load: type          = 4
whisper_model_load: mem required  = 1720.00 MB (+   43.00 MB per decoder)
whisper_model_load: adding 1608 extra tokens
whisper_model_load: model ctx     = 1462.35 MB

The memory requirements should be the same as whisper.cpp (Whisper.net is just calling that under the hood).
Ofc, there will be some extra mem used by dotnet runtime (GC and everything), but that shouldn't be signifiant in this case.
You can find the requirements here: https://github.com/ggerganov/whisper.cpp#memory-usage


prebuilt onnxruntime with direct ml?

Can you please share onnxruntime wheel with direct ml for python 3.6?

I don't think we have that pre-built today.

I can wait a month :)

https://github.com/BenjaminWegener/server/blob/master/onnxruntime_directml-1.8.2-cp36-cp36m-win_amd64.whl

@BenjaminWegener can you please build it for python 3.7 ?

@BenjaminWegener can you please build it for python 3.7 ?

i'll try

did it work?
pip install https://github.com/BenjaminWegener/server/blob/master/onnxruntime_directml-1.8.2-cp37-cp37m-win_amd64.whl?raw=true

yes

the speed is the same on cuda build, unbelievable

@wchao1115 is it possible to release official pypi onnnxruntime-directml ?

@iperov : The ORT DML package will be released as part of ORT 1.9 (another 2 or 3 weeks).


Add backwards compatible support for middy v2

Middy v2 removed the next function in favour of simply invoking the next middleware once the current one completes (see the upgrade guide). This PR adds backwards compatible support for the new version by invoking the callback only if it is set.
I've also refactored the tests to use Jest async support and added a test for backwards compatibility.
Let me know what you think @chrisandrews7.

Thanks @chrisandrews7, I've added the assertions

Thanks @chrisandrews7. Would you be able to push a new version to NPM?

Of course. Just sorting some CI issues.

Released https://www.npmjs.com/package/middy-env/v/2.0.0


Fixing bugs and performance in ci

Remove 🌲 as it takes 11 seconds ⚰
Remove webpack dev server
Side navigation active state in react
Update dependencies

This needs patches for the components with updated package-lock.json files.


Added talks from November.

@pablolvillar can you remove the .DS_Store files and include on your .gitignore global?
https://robots.thoughtbot.com/global-gitignore
https://github.com/github/gitignore/blob/master/Global/OSX.gitignore


feature request: custom length byte grouping

can you please allow custom byte groupings? not everything is three or a power of two.

What number are you wanting to use? Just thinking it might be easier to add more manual entries to that menu than to support any number (also not sure if the code would behave oddly with a non power of two).

Did some testing and it seems to work fine with arbitrary numbers, so I added this in.


Fix broken link

Removed the redundant # in link to the Related text section.

@msimecek : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Support for host inventory data on Host.Get call

Sorry, it looks like I completely destroyed host.cs and the csproj file, which isn't true. Basically just added a HostInventory.cs class which holds the properties present when requesting the inventory with the Host service. Then added a 'inventory' property into Host.cs.

Thank you for your collaboration, I just will do some modifications that probably will be interesting for you too, but I really appreciate your pull request


Update Heroic Games Launcher and dependencies

Description of changes
Update Heroic to 2.9.1, and its dependencies gogdl and legendary (@equirosa) to their latest stable versions.  Also added Nile for Heroic's Amazon Games support.
This version upstream moved to a non-free Electron fork for DRM support to go along with the new support for web applications.  This has been patched out to allow us to continue using mainline Electron from nixpkgs.
If anyone wants to take on packaging the ECS fork, then we can add an option to build the heroic package with and without DRM support (e.g. heroic and heroic-unfree).
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 246288 run on x86_64-linux 1

8 packages built:

gogdl
gogdl.dist
heroic
heroic-unwrapped
legendary-gl
legendary-gl.dist
rare
rare.dist

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2534

Been running this for a bit with a somewhat hacky patch to make Steam shortcuts work and a very hacky patch to disable Discord RPC (because it creates messy directories in $HOME for complicated reasons). I think we should definitely include the shortcuts patch and then this should be good to merge.

@K900 For the Discord RPC patch, why is just disabling the setting in Heroic insufficient?
For the Steam shortcuts patch, what is the problem that fixes?  I'm not familiar with that functionality, so I'm not sure what's going on there.

The Steam shortcuts patch makes the Steam shortcuts point at the heroic wrapper as the executable instead of the Electron binary, which is 1) in the store and may disappear and 2) the wrong thing to run anyway.
The Discord RPC patch is an ugly workaround for xdg-mime freaking out when launched in steam-session. I'm not entirely sure why disabling it in Heroic doesn't seem to make it not trigger.

(I'm not proposing to merge the Discord patch, btw, I just think the shortcuts one is good)

Patch to fix Steam shortcuts from @K900 applied.

Result of nixpkgs-review pr 246288 run on x86_64-linux 1

10 packages built:

gogdl
gogdl.dist
heroic
heroic-unwrapped
legendary-gl
legendary-gl.dist
nile
nile.dist
rare
rare.dist

10 packages
Wait why is rare being built? Isnt that just an alternative to heroic?

Because legendary, which both rare and heroic depend on, also got updated.


HDDS-9039. Added a test to verify that no compaction log entry is added to compactionLogTable and DAG when tarball creation is in progress.

What changes were proposed in this pull request?
There are two major changes in this PR.

Added a new test to validate that no new compaction log entry is added to compactionLogTable and DAG while tarball creation is in progress.
Made waitForTarballCreation synchronized function so that wait and notify threads are on a same object's monitor.

What is the link to the Apache JIRA
HDDS-9039
How was this patch tested?
Ran newly added test locally and fork branch.

Closing it in favor of https://github.com/apache/ozone/pull/6552


Add SamLikesCode

Wanted to share my website too! The UI is quite different to most of the other websites, but I think it should count 😄

Hi @Goggwell love your website, very interesting minimal design and I really dig the colors of the alternative themes!
I will add it to the list, thanks again for contributing and good luck for the development.

Thank you!


Add URL channels to Adsense & link Google Analytics Account

Suggestion to add URL channels to our adsense account, for page specific tracking, and also to link our Google Analytics account with adsense, for same reasons.
Currently, we can see how each individual ad unit is performing, but not by a clear breakdown of page.
This would be particularly useful for Issue #511 so we can compare a pages' performance against another's, and make appropriate changes when one is underperforming.
Economic 4, Urgency 3, Strategy 7, Cost 9: P=23

Have added new channels to track different pages in FC2.  Google Analytics still to be linked, after some discussion.

@smrr723 anyupdate on this?

Slight issue with this.  I didn't realise we had a separate analytics account for each of our websites.  Adsense only allows you to link one account at a time - and at the moment our FreeBMD analytics account is linked to our FreeCEN adsense account, which makes no sense.
I'll have to firstly unlink the BMD account, which I seem to have permissions to do.  What I don't have permission to do is to complete the setup via Analytics (Select FreeCEN2 > Admin > Property Column > Adsense Linking).  @richpomfret are you able to either increase my permissions in Analytics or complete this step https://support.google.com/adsense/answer/6084409?hl=en&utm_id=ad&visit_id=636765796332926564-3324492529&rd=1

Hi @smrr723 I am not sure what you mean by 'linked'.  Each site has its own code, and is separately managed through one institutional dashboard.  I've added permissions to FreeCEN (1) for you.

Hi Pat - by 'link' i mean the ability to link the Adsense account of a website to its equivalent Analytics account (as mentioned in this story title), which will give us increased insights.
And thanks - that seems to have worked for FC1 but it's the FC2 one I need at the moment.
P.S. At the moment we also seem to have FC1 & FC2 websites bundled together in one Adsense account, but separated into two accounts in Analytics. We will have to change that in the future if we also want insights for FC1, i.e. by either creating a separate adsense account for FC1, or having both FC sites under one Analytics property.

Thanks for the explanation.  I have given you permissions on the FC2 analytics account.

Thanks, Pat.  That's Analytics & Adsense for FreeCEN1 & 2 linked, as of last week.  Hopefully, it'll give us some useful revenue insights over time.


Create Sprite for Ablaze Status Indicator

Please see CONTRIBUTING.md first.

Have a PR open for this: https://github.com/doficia/project-cordon-sprites/pull/84


The object is created with the old class name, but the instanceof check is performed with the renamed class name

Describe the bug
We have a FlexGridPdfConverter class in our library (Wijmo). When we use the draw() method to draw the FlexGrid into a PdfDocument it produces an error in the constole: “Uncaught ** Assertion failed in Wijmo: Invalid argument: "value". Error”.
The error is caused because of failure of following check: “e instanceof PdfPen”
The reason is that the “e” variable contains the instance of “PdfPen” instead of “PdfPen2”.
You may observe the same in the images below:

Please note that I tried to run the exact code in an esbuild setup, and the issue does not occur. In esbuild setup also, the names are modifed by appending the suitable number in front of classes.

Reproduction
https://stackblitz.com/edit/vitejs-vite-msmvhy?file=index.html
Steps to reproduce
Steps to replicate the issue:
1       Extract the sample:  instanceof check issue.zip
2.	Run “npm i -f” and “npm run dev” to install the dependencies and run the sample.
3.	Click on the “Export” button.
4.	Observe the error in the console: “Uncaught ** Assertion failed in Wijmo: Invalid argument: "value". Error”
5.	Click on the second link displayed in the error message.

Place a breakpoint at the location and format the code.
Refresh the page, open developer tools and click again on “Export” button.
Format the code if required and press “F8” to pass the breakpoint this time.
Observe that the next time the flow hit the breakpoint, “e” contains an instance of “PdfPen” instead of “PdfPen2”.

Verifying that the issue does not occur in simple esbuild setup:

Extract the sample: esbuild-purejs.zip

Run “npm i -f” to install the dependencies and open the sample either using “live server extension” or by running “npx http-server -o” command from terminal.

Click on the “Export” button.

Observe that the FlexGrid can be exported successfully.

System Info
Output of “npx envinfo --system --npmPackages '{vite,@vitejs/*,rollup}' --binaries –browsers”
  System:
    OS: Windows 11 10.0.22621
    CPU: (16) x64 12th Gen Intel(R) Core(TM) i7-1270P
    Memory: 3.11 GB / 15.69 GB
  Binaries:
    Node: 18.18.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.22 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 10.3.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.22621.2283.0), Chromium (127.0.2651.105)
    Internet Explorer: 11.0.22621.1
  npmPackages:
    vite: ^5.4.1 => 5.4.3

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

From a quick look, it looks like deps optimization is confused with "self import" used by wijmo packages.
For example, @mescius/wijmo.pdf has this line https://unpkg.com/browse/<EMAIL_ADDRESS>import*as selfModule<EMAIL_ADDRESS>
which is optimized (pre-bundled) to<EMAIL_ADDRESS>like this:
import * as selfModule from "/node_modules/@mescius/wijmo.pdf/es5-esm.js?v=e22d289e";

The potential workaround is to exclude these packages from optimization since they are mostly bundled already. A following config makes your "export" button work in the reproduction:
https://stackblitz.com/edit/vitejs-vite-wzsyr5?file=vite.config.ts
import { defineConfig } from 'vite';

export default defineConfig({
  optimizeDeps: {
    exclude: [
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>    ],
  },
});

Thank you for looking into this issue.

The suggested workaround of “excluding the packages from optimization” does resolve the issue however, I think we cannot yet provide a glob or wildcard for the whole library itself. Adding individual modules in the “exclude” list is required. For example, using something like below still optimizes the files: exclude: [ '@mescius /**/' ]
However, I am not sure if using “self-import” is the cause of the reported issue. I have prepared a small library without using “self import” that have the following structure: @customlibrary/
├─ wijmo.grid.pdf/
│ ├─ index.js
│ ├─ package.json
├─ wijmo.grid/
│ ├─ index.js
│ ├─ package.json
The issue can be replicated with this library also.
The target language version of the “index.js” file is “ES5” and the module is “ES2015”.
Here is an offline vite example that uses a ‘@customlibrary’ for replicating the issue.
Steps to reproduce the issue:

Extract both the zips “Vite_Sample_customlibrary.zip” and<EMAIL_ADDRESS>@customlibrary.zip
Vite_Sample_customlibrary.zip

Install the dependencies using “npm i" for the sample (Vite_Sample_customlibrary.zip).

After installing the dependencies, please place the extracted library “@customlibrary” in “node_modules” of the sample.

Run the sample using “npm run dev”.

Observe the console. Observations: The second instance check is failed. Expectations: The second instance check should also be passed.

Could you please investigate this issue and let us know the root cause of the issue?
Shared files description:

“Vite_Sample_customlibrary.zip”: Sample created using “npm create vite@latest”.

<EMAIL_ADDRESS>Simple library that is to be placed in the node_modules of the sample to replicate the issue.

<EMAIL_ADDRESS>Code files before changing the target to “ES5”.
@customlibrary-raw.zip

@duttabhishek6891 Hey, thanks for repro. Indeed, this is likely a bug on Vite side for pre-bundling and "self import" doesn't seem to be relevant to the issue.
It took a while to track down, but it looks like dual package is happening due to package name having a suffix .pdf. Here is my repro to show the difference between test-dep1 and test-dep1.pdf https://stackblitz.com/github/hi-ogawa/reproductions/tree/main/vite-18036-prebundle-dual-package?file=main.js


Start Sketch frozen if selecting face from a revolve

Description
When I select the top face of this lug and use start sketch, the start sketch gets frozen. I think it's something along the lines of it understands that I want to sketch on the face, but doesn't know where to put the KCL since this geometry was created through a function call.
Recording
https://github.com/user-attachments/assets/56a67d64-3449-4c23-8fae-1407a58fc762
Version
v0.24.12
KCL
// Lug
// lugs are essential components used to create secure connections, whether for electrical purposes, like terminating wires or grounding, or for mechanical purposes, such as providing mounting points or reinforcing structural joints.

// Define the plane the lug lives on
const customPlane = {

}

// Define constants
const lugHeadLength = 0.25
const lugDiameter = 0.5
const lugLength = 2

fn lug = (origin, length, diameter, plane) => {
  const lugSketch = startSketchOn(plane)
    |> startProfileAt([origin[0] + lugDiameter/2, origin[1]], %)
    |> angledLineOfYLength({
      angle: 60,
      length: lugHeadLength,
    }, %)
    |> xLineTo(0+.001, %)
    |> yLineTo(0, %)
    |> close(%)
    |> revolve({
      axis: "Y",
    }, %)

  return lugSketch
}

lug([0, 0], 10, .5, "XY")

I realized that this isn't with functions, it's the revolve that it doesn't understand.

I provided a fix here nadro/3492/start-sketch-freezing-from-revolve which is a one line change to support revolve as extrude within the ArtifactGraph. This is a hack for now.
@Irev-Dev Should we be supporting Revolve's as RevolveArtifact and RevolveArtifactRich? If we do not want to separate them we may want a more generalize term to identify these operations. Ben said extrude, revolve, and sweep are all similar and will use the response of solid3d_get_extrusion_face_info to build the artifact graph.
I found a bug with Josh's function code with revolve + sketch on face. I'll be making a new github issue to identify this.

Generalising this sounds good, i.e. having one artifact type that covers both. I've just asked about naming in the engine, it's best to match up with naming where possible.
I think we should try generalise and if later have to break it up, so be it, but doubt that will be the case. Lets say the name ends up being "bar", we can just add a subtype which describes the specific type, but I think all of the rest of the properties hold up, hence why the hack works, which means it's not a hack it's the fix just with some renaming yeah?
interface BarArtifact {
  type: 'bar'
  subType: 'extrusion' | 'revolve'
  pathId: string
  surfaceIds: Array<string>
  edgeIds: Array<string>
  codeRef: CommonCommandProperties
}

Had that comment ☝  sitting there for hours without hitting the button 🤦
The response I got back from Mike was that sweep is the most general term so we could go with SweepArtifact but I don't like the idea that sweep is the generalisation and a specific operation.
Two alternatives that I think are okay are prism and contour (profile might work but we already use that in relation to sketches)
I think contour is probably the best, what do you think?
/** Countour is our general term that covers Extrudes, Revolves and Sweeps */
interface ContourArtifact {
  type: 'contour'
  subType: 'extrusion' | 'revolve' | 'sweep'
  // ...

Thanks for the clarification. I agree that it is a naming problem.
Do you think that we will ever have contour lines in the software?
I like SweepArtifact, I know it is a general and specific term but I think it can be reasoned about with the curve it makes.
Extrude is a shorthand for a linear sweep? Revolve is a shorthand for arc sweep?
Out of prism, contour, profile, and sweep, I'd rather name it to the closet thing and then change my mental model of a sweep. I think the collision of sweep being the general and specific term is the specific's term fault.  We shorthand this operation instead of making them pick sweep, pick the curve (a linear curve) then do the operation.
# My suggestion
interface SweepArtifact {
  type: 'sweep',
  subType: 'extrusion' | 'revolve' | 'sweep'
}

# Ehh???
interface SweepArtifact {
  type: 'sweep',
  subType: 'linear' | 'arc' | 'any'
}

Cool, happy with sweep too :)
🧹


IRGen: Use indirect relative func-ptr for harvard archs

Harvard architectures like WebAssembly cannot make direct relative function pointer because the referent function and the metadata are in different address spaces and the relative offset between them is not representable.
So we need to force such relative function pointers to always be indirect for those archs.
This change shouldn't affect other than WebAssembly, and Runtime changes will come in another PR
See also: https://forums.swift.org/t/wasm-support/16087/39

@swift-ci Please test

preset=buildbot_incremental_linux_crosscompile_wasm
@swift-ci please test with preset Linux Platform

@swift-ci please test macOS platform

From our forum discussion, we are going to use absolute pointer unconditionally https://github.com/apple/swift/pull/42094


fixed issue #25 which crash when using node

update dependency ws version to 1.1.1,  previous ws version doesn't work with node 6.2.0 and above

Thanks for the catch!


sway doesn't set the secondary monitor properly

I have a laptop and a external monitor. The resolution of the laptop's monitor (LVDS) and the external one (HDMI) is 1366x768 and 1920x1080 respectively. And thus I cofigure the outputs in the config file with the following two lines:
output LVDS-1 resolution 1366x768 position 0,0
output HDMI-A-1 resolution 1920x1080 position 1366,0

However, when I start sway, the external monitor doesn't display properly, the screenshot (captured by swaygrap) is shown below. The output is blur and the title of the window isn't correctly rendered. It is noticeable that the size of the screenshot is 1280x720 but not 1920x1080.

But when I run swaymsg -t get_outputs, I get the output as below:
[
   {
     "id": 1,
     "name": "LVDS-1",
     "rect": {
       "x": 0,
       "y": 0,
       "width": 1366,
       "height": 768
     },
     "visible": true,
     "focused": false,
     "active": true,
     "primary": false,
     "layout": "output",
     "type": "output",
     "current_workspace": "1",
     "scale": 1
   },
   {
     "id": 3,
     "name": "HDMI-A-1",
     "rect": {
       "x": 1366,
       "y": 0,
       "width": 1920,
       "height": 1080
     },
     "visible": true,
     "focused": false,
     "active": true,
     "primary": false,
     "layout": "output",
     "type": "output",
     "current_workspace": "2",
     "scale": 1
   }
 ]

I think sway renders the output as 1280x720 but not 1920x1080.
Interestingly, when I switch to an Xserver running on tty1 (my sway is running on tty2), which has the proper resolution settings (1366x768 and 1920x1080), and then switch back to sway, the output of the external monitor becomes good as the following screenshot shows!

As is seen in the screenshot, the everything is clear and works well. It is noticeable that the size of the screenshot is 1920x1080. And I run swaymsg -t get_outputs, the output keeps the same as above.
Later, I switch to tty3, which runs nothing except a getty shell, and then switch back to sway, the resolution of the external monitor is set to 1280x720, and the swaymsg -t get_outputs gives
[
   {
     "id": 1,
     "name": "LVDS-1",
     "rect": {
       "x": 0,
       "y": 0,
       "width": 1366,
       "height": 768
     },
     "visible": true,
     "focused": false,
     "active": true,
     "primary": false,
     "layout": "output",
     "type": "output",
     "current_workspace": "1",
     "scale": 1
   },
   {
     "id": 3,
     "name": "HDMI-A-1",
     "rect": {
       "x": 1366,
       "y": 0,
       "width": 1280,
       "height": 720
     },
     "visible": true,
     "focused": false,
     "active": true,
     "primary": false,
     "layout": "output",
     "type": "output",
     "current_workspace": "2",
     "scale": 1
   }
 ]

And the screenshot is shown below:

I am using Arch Linux with the sway version 0.12.2. I am pleasure to provide more details if you need :-)
Thanks!
Here is my full config file:
~$ cat ~/.config/sway/config |grep -v '^\s*[#]'
set $mod Mod4
set $left d
set $down h
set $up t
set $right n
set $term xfce4-terminal
set $menu dmenu_run

output * bg /usr/share/sway/Sway_Wallpaper_Blue_1920x1080.png fill
output LVDS-1 resolution 1366x768 position 0,0
output HDMI-A-1 resolution 1920x1080 position 1366,0

    input "2:7:SynPS/2_Synaptics_TouchPad" {
    	accel_profile flat
    	dwt enabled
    	tap enabled
    	click_method clickfinger
    	scroll_method edge
    	natural_scroll enabled
    	middle_emulation enabled
    	pointer_accel [100,100]
    }

    bindsym $mod+Return exec $term

    bindsym $mod+c kill

    bindsym $mod+F2 exec $menu -b

    floating_modifier $mod normal

    bindsym $mod+Shift+r reload

    bindsym $mod+Shift+q exit
    bindsym $mod+$left focus left
    bindsym $mod+$down focus down
    bindsym $mod+$up focus up
    bindsym $mod+$right focus right
    bindsym $mod+Left focus left
    bindsym $mod+Down focus down
    bindsym $mod+Up focus up
    bindsym $mod+Right focus right

    bindsym $mod+Shift+$left move left
    bindsym $mod+Shift+$down move down
    bindsym $mod+Shift+$up move up
    bindsym $mod+Shift+$right move right
    bindsym $mod+Shift+Left move left
    bindsym $mod+Shift+Down move down
    bindsym $mod+Shift+Up move up
    bindsym $mod+Shift+Right move right
    bindsym $mod+1 workspace 1
    bindsym $mod+2 workspace 2
    bindsym $mod+3 workspace 3
    bindsym $mod+4 workspace 4
    bindsym $mod+5 workspace 5
    bindsym $mod+6 workspace 6
    bindsym $mod+7 workspace 7
    bindsym $mod+8 workspace 8
    bindsym $mod+9 workspace 9
    bindsym $mod+0 workspace 10
    bindsym $mod+Shift+1 move container to workspace 1
    bindsym $mod+Shift+2 move container to workspace 2
    bindsym $mod+Shift+3 move container to workspace 3
    bindsym $mod+Shift+4 move container to workspace 4
    bindsym $mod+Shift+5 move container to workspace 5
    bindsym $mod+Shift+6 move container to workspace 6
    bindsym $mod+Shift+7 move container to workspace 7
    bindsym $mod+Shift+8 move container to workspace 8
    bindsym $mod+Shift+9 move container to workspace 9
    bindsym $mod+Shift+0 move container to workspace 10
    bindsym $mod+o splith
    bindsym $mod+v splitv

    bindsym $mod+s layout stacking
    bindsym $mod+w layout tabbed
    bindsym $mod+e layout toggle split

    bindsym $mod+f fullscreen

    bindsym $mod+Shift+space floating toggle

    bindsym $mod+space focus mode_toggle

    bindsym $mod+a focus parent

    bindsym $mod+Shift+minus move scratchpad

    bindsym $mod+minus scratchpad show
mode "resize" {
    bindsym $left resize shrink width 10 px or 10 ppt
    bindsym $down resize grow height 10 px or 10 ppt
    bindsym $up resize shrink height 10 px or 10 ppt
    bindsym $right resize grow width 10 px or 10 ppt

    bindsym Left resize shrink width 10 px or 10 ppt
    bindsym Down resize grow height 10 px or 10 ppt
    bindsym Up resize shrink height 10 px or 10 ppt
    bindsym Right resize grow width 10 px or 10 ppt

    bindsym Return mode "default"
    bindsym Escape mode "default"
}
bindsym $mod+r mode "resize"

bar {
    position top
    colors {
        statusline #ffffff
        background #323232
        inactive_workspace #32323200 #32323200 #5c5c5c
    }
}

include /etc/sway/config.d/*

Can we have a debug log, please?

I did a research and the full log can be found here.
In L461, the mode 1280x720 is chosen by wlc, but sway set it to 1920x1080 in L467.
In L773, I switched to Xserver in tty1 and then switched back, and this time wlc chose the proper mode in L830.

wlc doesn't support modesetting. Specifying a resolution will use the
display's preferred mode and scale the buffer to meet it.

Do you mean that we cannot specify a resolution to wlc, and wlc will automatically choose the display's preferred mode?

Correct.