[3.x] Incorrect order in SceneTreeDock's context menu.

Godot version
3.6.beta3
System information
Win11
Issue description
Seems Access as Unique Name is remade from 4.0, but it's not in the correct position.
3.6.beta3:

3.5.x:

Steps to reproduce
Right click nodes in SceneTreeDock.
Minimal reproduction project
N/A

Introduced in #66227 . @Mickeon

I could've sworn this was reported already but attempting to find it lead me to nothing.
The accidental irony is that this is exactly how https://github.com/godotengine/godot-proposals/issues/7631 proposed it should be.

Looks like #81469 kind of fixes this (by removing the double separator).
There is no longer a line underneath the menu item (compared to 3.5), but at least it doesn't look objectionable now I guess. :grin:


Restore Standard Building + Converted to TBB (+ more benchmarking changes)

This PR is on top of PR #64 . I have restored the standard building (removed in #64), and converted it to TBB so that it can run with all the new benchmarks (+ soon to be Dan's multiple events in flight).
I also made a number of additional changes to the benchmarks.  This includes renaming the logs and arguments passed to the benchmarking scripts to make it more explicit.  The added benefit is now benchmark plots should appear grouped together when viewed on the web (as the names of the .png files explicitly states what is being measured).
The full benchmarks are here: https://kmcdermo.web.cern.ch/kmcdermo/restored/
Notice that as expected, the standard building returns the same physics results, but slower and less performant as clone engine.  The scaling is rather smooth on SNB.
As for KNC, the benchmarks are a bit jumpy for all tests, but again, this is expected as there is limited work and not enough events to reach a steady state (as all tests do 10k tracks per event, and the time is now the average time over all events -- technically the average time over all events excluding the first).

I reviewed this last time as 64 ... so if it's only better than before I'm all for merging :)

Ha!  Well, I certainly think it is better than 64, but I will let you and Dan decide.


Fixed travis build for osx

Codecov Report

Merging #448 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #448   +/-   ##
=======================================
  Coverage   86.05%   86.05%
=======================================
  Files          56       56
  Lines        4432     4432
  Branches      482      482
=======================================
  Hits         3814     3814
  Misses        465      465
  Partials      153      153

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c11bd16...3db38ab. Read the comment docs.


Lets follow a mobile-first design approach

One of the key reasons for redesigning SWD was so that it could provide a pleasant mobile experience.
We should design components with the mobile layout in mind first. This is simpler to achieve and scaling to desktop screens becomes more intuitive, rather than trying to fit desktop designs into mobile screen estate.

Should we consider Progressive Web Apps? I like to use them very much. Mobile app won't be needed.

Yes, this is the next step after we're done with a mobile UI and a working prototype.


CHALLENGE across ALL WHITELISTED BOINC projects at the same time

 Issue by Erkan-Yilmaz
Friday Jan 20, 2017 at 18:49 GMT
Originally opened as https://github.com/Erkan-Yilmaz/Gridcoin-tasks/issues/7

Currently, we've in a challenge only 1 BOINC project:

at the moment team Gridcoin is in 4 challenges at the same time

But, it is also possible to make a competition over all whitelisted BOINC projects (ca. 30):

can't overlap, must have e.g. 1 per week
not possible with boincstats

mentioned in hangout 1: 1:14:15

 Comment by grctest
Saturday Jan 21, 2017 at 20:50 GMT

Formulaboinc does cover this to a certain degree, but having challenges longer than a week would require a new challenge website.

All whitelisted projects are getting one week challenges (subsequent weeks) going forward.


jb date input style

remove calendar icon -> add arrow icon
text align center
text color
set placeholder-> year/month/day
just border bottom
label without :

text align done

other feature like placeholder is not possible with current calendar and need deep refactor


Since node 10, it is mandatory to pass a callback on fs.writefile()

Since node 10, it is mandatory to pass a callback on fs.writefile()
This was not the case on line 294 of the index.js file, so it was throwing the following error :
Callback must be a function. Received 'utf8'
I added an empty callback function to correct the problem. It works now.
Feel free to let me know if I made any mystake. Thank you for ,your work, and have a nice day.

This is reported in #70 #71 #72. Node 8 is not supported. Node 10 is the oldest LTS now.

Fixed this with writeFileSync() -> https://github.com/nystudio107/generator-craftplugin/commit/3d22216593d84ec809c6087115d5b5eeeb40312e


Python interpreter is lost every time I restart vscode

Type: Bug
I recently switched to python 3.11 and built a new virtual environment, reinstalling everything I previously ran in a 3.9 venv. Everything works except that VSCode does not find the interpreter until I manually drill down to the python3.11 file every time. I have attempted to set the default interpreter in several places but when I shut down and come back I have to reset my interpreter again. I can't tell if it is a bug or simply that I don't understand where or how to tell it to find the correct python, but I have not had to do this running VScode and python 3.6-3.9 for the last 4+ years in this same environment on the same remote servers. The only other major variable is that I added several linters to the best of my understanding based on our company documentation. I am not sure if that can impact it, but I included it in case it can. Here are examples of the error messages I see in the console output when I start up VSCode and it can't find the python interpreter.
2024-08-14 14:53:42.592 [warning] Identifier for virt-virtualenv failed to identify /home/jh/nauto/venv-311/bin/python3.11 [Error: ENOENT: no such file or directory, scandir '/home/jh/nauto/venv-311/bin'] {
errno: -2,
code: 'ENOENT',
syscall: 'scandir',
path: '/home/jh/nauto/venv-311/bin'
}
2024-08-14 14:53:42.594 [warning] Failed to check if /home/jh/nauto/venv-311/bin/python3.11 is an executable [Error: ENOENT: no such file or directory, lstat '/home/jh/nauto/venv-311/bin/python3.11'] {
errno: -2,
code: 'ENOENT',
syscall: 'lstat',
path: '/home/jh/nauto/venv-311/bin/python3.11'
}
2024-08-14 14:53:42.594 [warning] Identifier for virt-virtualenv failed to identify /home/jh/nauto/venv-311/bin/python3.11 [Error: ENOENT: no such file or directory, scandir '/home/jh/nauto/venv-311/bin'] {
errno: -2,
code: 'ENOENT',
syscall: 'scandir',
path: '/home/jh/nauto/venv-311/bin'
}
VS Code version: Code 1.92.1 (eaa41d57266683296de7d118f574d0c2652e1fc4, 2024-08-07T20:16:39.455Z)
OS version: Windows_NT x64 10.0.22621
Modes:
Remote OS version: Linux x64 4.18.0-553.8.1.el8_10.x86_64

System Info

Item
Value

CPUs
12th Gen Intel(R) Core(TM) i7-12800H (20 x 2803)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabledwebnn: disabled_off

Load (avg)
undefined

Memory (System)
31.69GB (14.78GB free)

Process Argv

Screen Reader
no

VM
0%

Item
Value

Remote
SSH:<server_name>

OS
Linux x64 4.18.0-553.8.1.el8_10.x86_64

CPUs
Intel(R) Xeon(R) Gold 6248R CPU @ 3.00GHz (12 x 0)

Memory (System)
23.26GB (8.71GB free)

VM
100%

Extensions (13)

Extension
Author (truncated)
Version

vsc-python-indent
Kev
1.18.0

debugpy
ms-
2024.10.0

python
ms-
2024.12.3

vscode-pylance
ms-
2024.8.1

jupyter
ms-
2024.7.0

jupyter-keymap
ms-
1.1.2

jupyter-renderers
ms-
1.0.19

vscode-jupyter-cell-tags
ms-
0.1.9

vscode-jupyter-slideshow
ms-
0.1.6

remote-ssh
ms-
0.113.1

remote-ssh-edit
ms-
0.86.0

remote-explorer
ms-
0.4.3

jinja
who
0.0.8

are you still running into this?

No, I ended up spending time going through settings methodically and I figured out that it didn't seem to like using the full name of the python file with the version, so I used the symlink "python" instead.  I was generally incorrectly setting the path. I have not had issues since setting the remote server and workspace default interpreter paths. Thank you for checking in, I had forgotten this was posted.


Add "Project" column in data browser

Users wanted to see which specimens were from the same project within the file browser.  Add a column with this information to the browser table.

Moved to https://app.zenhub.com/workspace/o/humancellatlas/data-browser/issues/271.


Implement assembly io advice ops

I updated the io tests to do exact error checking and then added some additional validation to check the exact op tokens being passed to the parser functions. Let me know if you don't think that belongs here (maybe it's overkill).

Let me know if you want the push and loadw inside parse_adv pulled out into their own helper functions

One question about the new parse_int_param - on revisiting it, u32 seemed to make more sense, since I guessed most cases with larger values they will be parsed as elements, but maybe there will be other cases where the param could be large?

One question about the new parse_int_param - on revisiting it, u32 seemed to make more sense, since I guessed most cases with larger values they will be parsed as elements, but maybe there will be other cases where the param could be large?

I think u32 is plenty. In most cases, such parameters are probably going to be way smaller (probably enough to fit into a single byte - but let's keep u32).


Rewrite/rename import_reg management command

In the process, drop workarounds for Python 2.6 (we support 2.7, 3.4+), remove
unnecessary code, and add tests.
Builds on #64

Coverage increased (+9.5%) to 92.955% when pulling 99c963b4a9859fdd3f75f86563e7424266bdfe8b on cmc333333:rewrite-import into e19380d141c73f86e88c8fd8d7d6c586d090a963 on eregs:master.

Coverage increased (+9.5%) to 92.955% when pulling 014e4813ab46d6c8eacf1be9240c233d614906e5 on cmc333333:rewrite-import into e19380d141c73f86e88c8fd8d7d6c586d090a963 on eregs:master.

Thanks for taking care of this, @cmc333333.  I'd suggest also updating the project's README.md to update usage of the command.

@gregoryfoster thanks! I think the latest commit does that, but maybe I missed something?

@cmc333333, my mistake!  I missed that file in a scan of the changed files on the pull request.  Confirmed locally by looking directly at the file.

Whoot, whoot, thanks for reading it over!

Coverage increased (+0.009%) to 92.955% when pulling 6384a89850dabe4297595d2c5e1dc2c7dcf062fd on cmc333333:rewrite-import into de7e36f086d9f3343c15a79d4c8822537a417851 on eregs:master.


Unable to configure seedr.cc

It gets timeout and says "An error occurred. Please try again"

Seems like it worked after sometime


[Bug] Creation of Satsdice not possible

Example from two different lnbitses v0.10.9 with Satsdice v0.1.0

This has been fixed!

yeah its from september :P youre welcome :P


Add CloudFormation template

This PR adds some notes about the server deployment and the CloudFormation template.
No testing needed. This PR is to store the template already used to deploy our 1Password Connect Server but here are some background resources on the 1Password integration that we are using to manage application secrets:

https://developer.1password.com/docs/connect
https://developer.1password.com/docs/connect/aws-ecs-fargate/
https://docs.aws.amazon.com/AmazonECS/latest/developerguide/AWS_Fargate.html

Going to merge this before I forget that it is here again. 😅 Thanks for the reviews!


V0.11.2.x fix has collateral inputs

HasCollateralInputs should check only for at least 1 collateral (not 2, otherwise we can hit endless loop)

Good find


simplify String.split

This is an import of what I made before I realized this already existed.
Was there some subtle reason for String.split.go to exist?

String.split.go was just an auxiliary, your solution is much simpler.
Can you update the cases to be in a new line? For example:
// Line 8
| true =>
   case using:
   | nil => List.cons<String>(String.cons(xs.head, String.nil), String.split(xs.tail, using));
   | cons => List.cons<String>("", String.split(String.drop(String.length(using), xs), using));
 ;

Also, the ; goes bellow the | that it "closes" when we have a multi-line. We need a document explaining these conventions.
Also, I didn't know about the use of The for tests, really cool!

I think we can also improve the using parameter. What do you think about "separator", "sep" or "match"?

I think it can be simplified a little bit still, probably inspired on List.chunks_of, but looks great. Merging.


Improve serialize() by preallocating the buffer

Supersede #1027
In comparison to #1027, this is more straightforward, safer, and ready. On the cons maybe could be a little less performant in some cases.
Many more overrides are possible (like for BlockHeader, Script, TxOut, and smaller objects frequently used by downstream libs as key/value objects) but kept for a subsequent MR.
Benchmarks show great improvement for small objects without sacrificing big objects performance

*_serialize_alloc is comparable to serialize on master
*_serialize is this branch
*_serialize_prealloc is considering known the size beforehand

test blockdata::block::benches::bench_block_serialize                      ... bench:     600,484 ns/iter (+/- 5,266)
test blockdata::block::benches::bench_block_serialize_alloc                ... bench:     618,795 ns/iter (+/- 4,810)
test blockdata::block::benches::bench_block_serialize_logic                ... bench:     145,143 ns/iter (+/- 985)
test blockdata::block::benches::bench_block_serialize_prealloc             ... bench:     615,802 ns/iter (+/- 7,502)
test blockdata::transaction::benches::bench_transaction_serialize          ... bench:         258 ns/iter (+/- 21)
test blockdata::transaction::benches::bench_transaction_serialize_alloc    ... bench:         521 ns/iter (+/- 18)
test blockdata::transaction::benches::bench_transaction_serialize_logic    ... bench:          19 ns/iter (+/- 0)
test blockdata::transaction::benches::bench_transaction_serialize_prealloc ... bench:          77 ns/iter (+/- 3)
test serialized_len::bench::bench_block_serialized_len                     ... bench:     141,516 ns/iter (+/- 4,184)
test serialized_len::bench::bench_block_serialized_len_early_stop          ... bench:         606 ns/iter (+/- 52)
test serialized_len::bench::bench_out_point_serialize                      ... bench:          35 ns/iter (+/- 0)
test serialized_len::bench::bench_out_point_serialize                      ... bench:          57 ns/iter (+/- 2)  # before impl custom serialized_len*()
test serialized_len::bench::bench_out_point_serialize_alloc                ... bench:         121 ns/iter (+/- 1)
test serialized_len::bench::bench_transaction_serialize_len                ... bench:         248 ns/iter (+/- 14)
test serialized_len::bench::bench_transaction_serialized_len               ... bench:          17 ns/iter (+/- 2)

I noticed there is https://doc.rust-lang.org/std/io/struct.Sink.html I will update using it instead of EmptyWrite

At minimum this needs to also override the blanket impls for all references to delegate the newly added methods.

Could you expand on this?

We have impl<'a, T: Encodable> Encodable for &'a T and similarly for &mut T, Rc<T> Arc<T> (strangely, not for Box<T>)
They currently only forward one method. They need to forward all methods otherwise the default implementations will be used potentially trashing performance.

Hey @RCasatta the new serialize_len file is going to be parsed by the formater but we do not currently run rustfmt on CI (there is an open PR). Can you please run cargo +nighly fmt if you are pushing another version of this PR so as not to introduce formatting issues. Thanks.

We have impl<'a, T: Encodable> Encodable for &'a T and similarly for &mut T, Rc Arc (strangely, not for Box)

They currently only forward one method. They need to forward all methods otherwise the default implementations will be used potentially trashing performance.

I added a commit https://github.com/rust-bitcoin/rust-bitcoin/commit/f993a75e71c7d9f155ee0222212274e01e0b1366 to implement this that I followed removed because it gives an strange stack overflow error in test_witness test
I think I have addressed remaining feedbacks

I see now that I can't call NonZeroUsize::new in const context in 1.41.1, I think I am going to change STATIC_SERIALIZED_LEN to just usize, treating 0 as the absence of value...

Changed with STATIC_SERIALIZED_LEN as usize.
Open questions:

Should I rename serialized_len_early_stop to reserve_suggestion?
https://github.com/rust-bitcoin/rust-bitcoin/pull/1224#issuecomment-1234219662

I'm not convinced this is a best way to approach it. It seems to me that:

Such performance optimizations mostly matter in real production&mainnet environments where it it useful to rely on statistics and heuristics from the real blockchain data. eg. we know that a typical block is smaller than 2MB, so why don't we just allocate 2MB for every block upfront, and be done. Using a nice round (2^n) value will make it also easier for the memory allocator to work with, as they are usually based on some bucketing of evenly aligned pieces.
It is totally fine to over-allocate upfront in a lot of places, as that's what resizing of Vec would do anyway, and the data will be usually deallocated shortly afterwards anyway and trying to be overly-precise in these estimation is kind of pointless.

We could just add const RECOMMENDED_SERIALIZATION_PREALLOC_LEN: usize; and that's it. Then set it to either a known constant value (when we actually do know), or some kind of 90th percentile value rounded up to the nearest power of 2 (so the memory allocators are happy).

AFAIU the serialization would be the fastest if the buffer was always preallocated to something like 4MiB, as it would never require any reallocation. So this is all multi-value optimization problem where the benchmarking should measure both:

memory wasted: memory allocated (ideally as seen by memory allocator itself, not just Vec::capacity) - the actual serialization size
time spent serializing

Then we would have to draw these two values as points on the plane, make then into a curve, and then chart multiple curves each for different methods of coming up with the exactly preallocation buffers.
Seems like a lot of work though, so some educated but simple approach might be a good start.

The embedded folks will probably not be happy about over-allocating. Even if you're right about blocks it seems variability is much higher for transactions.

The embedded folks will probably not be happy about over-allocating. Even if you're right about blocks it seems variability is much higher for transactions.

We need to remember that any Vec over-allocates at all times up to 100% (by doubling the size every time). Let's say a typical smth is usually 33 bytes. That means it will end up in 64B-capacity buffer most of the time. If we pre-allocate it to 48B as we know it's a 99th percentile of a typical size of smth, most of the time we will end up with a smaller over-allocation. (I ignore the fact that chances are the underlying allocator might use up a whole 64B chunk anyway), so it's still a win on all accounts: resizes and overallocation waste.
People in embedded will probably work on one or a handful transactions at the time, and they might need to do something special anyway, like serialize into chunks straight to IO, or pack things into one allocation with some index, etc. They can always pre-allocate thing themselves.

Even if you're right about blocks it seems variability is much higher for transactions.

That's OK. https://bitcoinvisuals.com/chain-tx-size suggests that 256 would be a great default where around 50% of txes would not need any re-allocation, and when necessary a single doubling would serve another 40%.

At the core my disagreement comes to this: the change seems to be motivated by performance, but for some reasons all the approaches considered are trying to be needlessly exact/precise at the expense of what they are trying to achieve, like over-allocating is somehow terribly expensive, while it really isn't.
If for whatever reason simple associated constant per-type is not good enough, it could be combined with a function that be default returns a per-type constant, but for types like Tx, uses some other estimation approach like inputs.len() * typical_size_of_input + outputs.len() * typical_size_of_output + typical_size_of_other fields().

I don't really agree with the feedback received (apart from https://github.com/rust-bitcoin/rust-bitcoin/pull/1224#discussion_r961200283).
I don't like overshooting size more than now. I thought, maybe wrongly, this was the general view after some comments from @apoelstra of taking embedded really seriously.
The focus of this is not on improving on serializing Blocks (or big transactions) where the reallocations don't percentually impact on perfomance, but improve on smaller objects that could be serialized many times in downstream code, example without impacting big objects.
In the example serializing Script will not be optimal with RECOMMENDED_SERIALIZATION_PREALLOC_LEN (either wasting memory or requiring reallocations) while it is with default implementation in this branch.

In the example serializing Script will not be optimal with RECOMMENDED_SERIALIZATION_PREALLOC_LEN (either wasting memory or requiring reallocations) while it is with default implementation in this branch.

fn main() {
    let v1: Vec<u8> = Vec::with_capacity(17);
    let v2: Vec<u8> = Vec::with_capacity(17);
    let v3: Vec<u8> = Vec::with_capacity(17);

    println!("{:?}", v1.as_ptr());
    println!("{:?}", v2.as_ptr());
    println!("{:?}", v3.as_ptr());
}

result:
0x558c9a9ac9d0
0x558c9a9ac9f0
0x558c9a9aca10

playground link
Even if we do use perfectly accurate capacities, at the basic level of allocator there will be some over-allocation anyway.
BTW. If you tweak allocation sizes, it seems like this particular allocator adds 8 bytes of fixed overhead to every allocation and rounds up to 2^n, so possibly aiming at sizes  (2^n - 8) might be generally better. But details are implementation defined, so :shrug:.

I thought, maybe wrongly, this was the general view after some comments from @apoelstra of taking embedded really seriously.

Unless embedded system uses some kind of simple bump allocator that never deallocates, it will typically be using simple power-of-2-sized-bins-based allocation scheme.
For machines with seriously constrained memory capacity, that for some reason need to store a lot of these small allocation, it would be best to serialize into one bigger Vec, prefixed by length and use indices to point to the correct data, IMO.
And they will often be code-memory constrained, so that's another counter-reason to keep the logic as simple as possible.
I don't know. Maybe I'm missing something, or just wrong somewhere. I just say what I think.
The general idea of preallocating the buffer to something is definitely beneficial.

BTW. If you tweak allocation sizes, it seems like this particular allocator adds 8 bytes of fixed overhead to every allocation and rounds up to 2^n, so possibly aiming at sizes (2^n - 8) might be generally better.

Just occurred to me: does Rust stdlib does anything like that? Are the capacities always 2^n, which makes a lot of default collection resizes fall into the next larger bin than if they used something slightly smaller than 2 when resizing?

But details are implementation defined

Interestingly with_capacity doc says: "This method is allowed to allocate for more elements than capacity." I remember reading somewhere that allocator could make more capacity available, so that's how it was supposed to be optimized. Sadly it looks like the default one doesn't support it (maybe jemalloc does?)

Oh, interestingly the doc contradicts itself

I was wrong about wasted space. For bigger objects (> 64) the allocator will use some kind of skip lists etc. not to waste too much space.


index out of range exception

Hi
I'm running some code in a wrapper script based on the code found in the demo and example scripts here in this repository. ProteusAI is imported in my python virtual environment. Zero shot works fine but when I try to run the best candidate variants with esm_fold, I get the following error.
top_i.esm_fold(dest=dest)

.venv/lib/python3.8/site-packages/proteusAI/Protein/protein.py", line 464, in esm_fold
chain = self.chains[0]
IndexError: list index out of range
Looking at the protein.py script in the esm_fold function.
if chain is None:
      chain = self.chains[0]

self.chains is always an empty list at this point, hence the index out of range.
I'm not sure whether this is a bug or  I'm doing something wrong.
Thanks for your help

Hi Christoph,
thanks for pointing out the bug! The folding functionality needed some more attention, but it is fixed now in the current release (v0.0.7), together with some more demos!
I hope it works for you, if not, please reach out.
Cheers


compilation problem due to LXDG::findAvailableAppsForMime

On a scratch machine (opebsd-current), I cannot compile Lumina due to an LD error on LXDG::findAvailableAppsForMime.
AS workaround I do a make install; make; make install and it works.

This is expected. Anytime you rebuild from source I highly recommend that you always rebuild/reinstall the Lumina library first. Very often new functions are added to the library at the same time that new features are enabled in the desktop/utilities - so you always want to make sure that all your compilations are performed with the most current version of the library available.

I think we are not on the same line.
I'm talking about a fresh compile process following the readme and you are talking about a rebuild.

Was this a fresh checkout of the source on a system without Lumina, or did you have an older version of libLumina on the system? I still see an occasional issue where the linker uses the current version of the library on the system (the older version) instead of the newly compiled version of the library in the source tree. Usually just running "make install" on the entire project instead of "make" and then "make install" seperately will ensure that each of the pieces of Lumina gets built/installed in the proper order (library first). Otherwise you can build/install the library separately beforehand (cd libLumina; make; sudo make install) and that will have the same effect.

If you cannot reproduce it, it's maybe an error on my side. I'll do it later and note carefuly what I do.


Prevent workspace menu from dismissing when clicking on add work email

Details

While clicking on the add work email address option under the workspace menu in the new dot it dismisses the workspace menu and we do not want that to happen.
Please have a look at the issue it has a video showing the unexpected behaviour.
Fixed Issues

$ https://github.com/Expensify/App/issues/9013
Tests

To test this you first need to generate(generator:account) a new account using a public mail service provider like Gmail.
Once you have created a verified account create a new workspace under this account by logging into new dot.
Now to this workspace let's add a VBA(verified bank account)  by following the instruction to add OPEN state bank account from this SO in New Dot (Profiles -> workspace -> issue cards -> add bank account).
Once the VBA is added when we go to the same option to issue cards we can see an option to add work email address, clicking this will not dismiss the workspace menu like before.

[ ] Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[ ] I added steps for Staging and/or Production testing in the QA steps section
[ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I included screenshots or videos for tests on all platforms
[ ] I ran the tests on all platforms & verified they passed on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I followed proper code patterns (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I followed the guidelines as stated in the Review Guidelines
[ ] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose and it is

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

PR Reviewer Checklist

[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

QA Steps

[ ] Verify that no errors appear in the JS console

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@techievivek is this still a work in progress?

@luacmartins No but I am not able to test this. But the fix is to only remove the part which dismisses the sidebar.

Updated the test section thanks for the help.

Thanks for updating the test! Can we go through the rest of the checklist and add videos for all platforms?

Sure I will add them today. Thanks

@luacmartins I have updated the video placement and have added videos for all platforms except(Mobile web) not sure how would I access localhost:8080 on my emulator. Any pointers on how to test this out? Thanks

I think this SO might help

@luacmartins Thanks that worked like charm, just updated the video for mWeb as well.

@techievivek Cool! thanks for the updated videos! A few more small comments:

Please make sure to go through the PR checklist and check any applicable checkboxes.
I noticed that while we have Test steps, we didn't add any QA steps. This is important because that's what Applause (our outsourced QA team), or an internal QAer will use to test the PR. The QA steps are steps that you can take in staging or production to test the PR (so that means no terminal commands, db access, etc). In this PR's case, I think the steps are the same (except for the account generator commands), but we should at least mention that under QA steps.
I see that you added the InternalQA label, but I think that this can be tested by Applause. At least in the past, they were able to test this flow. So I think we should remove that.

Sorry about all the back and forth, but it seems like a good learning opportunity for how our QA process works 😄

@luacmartins Not an issue Carlos, I appreciate the time and effort you are taking to guide me through this it would definitely help me be a better contributor and will make things easy for others involved as well. I have updated the PR and QA. I have some small queries related to QAs which I always struggle with

So the QA team tests the changes only in staging and production?
How do we determine if the particular PR is testable by the QA team? Do they have access to Internal SO? Like in this one I thought about how would they have access to SO and the credentials used to open VBA.

Thanks for all the learnings so far. 🙌

Tests were passing...

Thanks, @luacmartins for all the help and guidance, learnt a lot.

🚀 Deployed to staging by @luacmartins in version: 1.1.66-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @chiragsalian in version: 1.1.66-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


fixed_container::reflection vs boost::reflection

should we make fixed_containers::reflection be based on boost::reflection. boost's version requires aggregate types, whereas fixed_container's version requires constexpr default constructible. or do we not want fixed containers to depend on boost?

I haven't tested pfr reflection extensively yet, but it is possible we could remove reflection altogether from fixed_containers in favor of pfr.


Breaks scaffolding and farmland blocks

Describe the bug
When the plugin is enabled:

Scaffolding blocks don't collapse when the first block is broken
Farmland blocks don't turn back to dirt blocks when being jumped on

Expected behavior

These should all work

Screen recording
If applicable, add screenshots to help explain your problem.
https://cdn.discordapp.com/attachments/289587909051416579/1191876440682135632/Export-1704235705934.mp4
Versions (please complete the following information):

Minecraft: [e.g. 1.16.4] 1.20.4
Plugin [e.g. 1.0] Latest version

Hi, sorry for the really late response, got involved with a lot of stuff privately. Anyway the issue has now been solved thanks to the TRUEC0DER Pull Request, you can get the latest version for 1.20.4 from Modrinth here: https://modrinth.com/plugin/better-snowier-snow/version/1.4-1.20.4


SyntaxError in Input Field When Entering Only an Opening Brace { in SAP UI5

OpenUI5 version: (Please specify the version you are using, e.g., "1.108.0")
Browser/version (+device/version):

Google Chrome  (Version 114.0.5735.199)
Mozilla Firefox (Version 115.0.2)
(Include any other browsers you’ve tested, with version numbers and whether the issue occurred)

Any other tested browsers/devices (OK/FAIL):

Microsoft Edge (FAIL)
Safari on iOS (OK)
(List others as applicable)

URL (minimal example if possible):
Provide a link to a minimal example that reproduces the issue, if possible. If not possible, mention that.
User/password (if required and possible - do not post any confidential information here):
Mention if a user/password is required to access the example, or state "N/A".

Steps to reproduce the problem:

Navigate to the page where the input field is present.
Enter only an opening brace { in the input field.
Click the "Save" or "Accept" button to submit the input.

What is the expected result?
The application should handle the input gracefully without throwing any errors. It could either:

Notify the user of the invalid input.
Escape the braces properly to avoid syntax issues.

What happens instead?
A SyntaxError is thrown with the following message:
SyntaxError: no closing braces found in '{' after pos:0 (at BindingParser-dbg.js:409:10)

Any other information? (attach screenshot if possible)
Include any additional context that might help, such as:

Screenshots showing the error message.
Any relevant logs.
The simplified version of the code you shared:const hbox = new sap.m.HBox({
    items: [
        new sap.m.Title({
            text: "{/title}"
        }).addStyleClass('BILP-KPI-title sapUxAPObjectPageSectionTitle'),
        new sap.m.Input({
            editable: true,
            placeholder: "{i18n>tileTabName}",
            value: "{/kpiTitle}"
        }),
    ]
});

This should give the SAP UI5 community a clear and detailed understanding of the issue, making it easier for them to provide help.
https://community.sap.com/t5/technology-q-a/syntaxerror-no-closing-braces-found-in-after-pos-0-at-bindingparser-dbg-js/qaq-p/13747432

Could you please share the callstack of the error?

Possibly related issues: https://github.com/SAP/openui5/issues?q=is%3Aissue+curly+escapeSettingsValue

Kindly please go through screenshot

Steps to reproduce:

https://jsbin.com/zodukup/edit?html,js,console,output which runs with 1.120
Enter { in the input field.

The following line in AnchorBar#_createSelectItem puts the given value directly without ManagedObject.escapeSettingsValue:
https://github.com/SAP/openui5/blob/61f051661546ab5489b5c844873bef508f36938d/src/sap.uxap/src/sap/uxap/AnchorBar.js#L306
From escapeSettingsValue:

Should be used when property values are initialized with static string values which could contain binding characters (curly braces)

Same issues in:
https://github.com/SAP/openui5/blob/61f051661546ab5489b5c844873bef508f36938d/src/sap.uxap/src/sap/uxap/ObjectPageLayoutABHelper.js#L108-L111
https://github.com/SAP/openui5/blob/61f051661546ab5489b5c844873bef508f36938d/src/sap.uxap/src/sap/uxap/ObjectPageLayoutABHelper.js#L122
https://github.com/SAP/openui5/blob/61f051661546ab5489b5c844873bef508f36938d/src/sap.uxap/src/sap/uxap/ObjectPageLayoutABHelper.js#L70

Hello @dhruday ,
Thank you for sharing this finding. I've created an internal incident DINC0240213. The status of the issue will be updated here in GitHub.

Hello @boghyon,
Thank you for the thorough analysis you've provided on this ticket—your efforts are greatly appreciated!
@dhruday, you can apply the fix starting with OpenUI5 version 1.128.
Best regards,
Konstantin Gogov

Thanks for the quick fix @kgogov. I think the anchorBarButtonColor should be also fixed in:
https://github.com/SAP/openui5/blob/adfed6aa7478fc5e16fa39e21f09e2538a536502/src/sap.uxap/src/sap/uxap/ObjectPageLayoutABHelper.js#L109-L112
The problem is: as soon as the wrong value containing { is stored in the server, and the app generates the anchor bar based on the stored value, the app cannot be started anymore due to the error.

Hello @boghyon,
Thank you for pointing out the additional issue with the anchorBarButtonColor.
I’ve addressed the problem and created a follow-up commit to resolve it.
Best regards,
Konstantin Gogov


Fix Celery Instrumentation for Workers

Overview

Celery apps run with worker optimizations would overwrite instrumentation wrappers.
This has been corrected by instrumenting the setup and reset methods to always ensure our wrapper is always applied, is never duplicated, and is always the top wrapper for BaseTask.call
Add new tests file for wrapper unit tests with new test for worker optimizations.

Codecov Report
Attention: Patch coverage is 67.74194% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 79.87%. Comparing base (a447772) to head (6de577d).

Files
Patch %
Lines

newrelic/hooks/application_celery.py
66.66%
4 Missing and 6 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1133      +/-   ##
==========================================
- Coverage   81.75%   79.87%   -1.88%
==========================================
  Files         192      192
  Lines       21301    21322      +21
  Branches     3706     3711       +5
==========================================
- Hits        17415    17032     -383
- Misses       2812     3229     +417
+ Partials     1074     1061      -13

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


malformed workflow template: quantities must match the regular expression for resources.requests.storage

Pre-requisites

[X] I have double-checked my configuration
[X] I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
[X] I have searched existing issues and could not find a match for this bug
[ ] I'd like to contribute the fix myself (see contributing guide)

What happened? What did you expect to happen?
argo workflow version： https://github.com/argoproj/argo-workflows/blob/main/manifests/quick-start-minimal.yaml
kubernetes version： 1.22.15
yaml example：
apiVersion: argoproj.io/v1alpha1
kind: WorkflowTemplate
metadata:
  name: nginx
spec:
  arguments:
    parameters:
    - name: DISK_SIZE
  entrypoint: nginx
  templates:
  - name: nginx
    container:
      image: nginx:latest
      volumeMounts:
      - mountPath: /usr/share/nginx/html/
        name: html
    volumes:
    - name: html
      ephemeral:
        volumeClaimTemplate:
          spec:
            accessModes: [ "ReadWriteMany" ]
            storageClassName: nfs-client
            resources:
              requests:
                #storage: "30Gi"
                storage: "{{workflow.parameters.DISK_SIZE}}"
---
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  name: nginx-workflow
spec:
  workflowTemplateRef:
    name: nginx
  arguments:
    parameters:
    - name: DISK_SIZE
      value: "30Gi"

Test yaml, workflow error：

Version(s)
main
Paste a minimal workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
Test yaml, workflow error: quantities must match the regular expression '^([+-]?[0-9.]+)([eEinumkKMGTP]*[-+]?[0-9]*)$'

Logs from the workflow controller
time="2024-07-17T05:00:49.373Z" level=info msg="Persistence configuration disabled"
time="2024-07-17T05:00:49.373Z" level=info executorImage="quay.io/argoproj/argoexec:latest" executorImagePullPolicy= managedNamespace=
time="2024-07-17T05:01:35.357Z" level=info msg="Alloc=6263 TotalAlloc=925869 Sys=28005 NumGC=559 Goroutines=175"
time="2024-07-17T05:06:35.364Z" level=info msg="Alloc=6946 TotalAlloc=929892 Sys=28005 NumGC=561 Goroutines=175"
time="2024-07-17T05:11:35.356Z" level=info msg="Alloc=6129 TotalAlloc=934040 Sys=28005 NumGC=564 Goroutines=176"
time="2024-07-17T05:16:35.357Z" level=info msg="Alloc=6811 TotalAlloc=937786 Sys=28005 NumGC=566 Goroutines=176"
time="2024-07-17T05:21:35.357Z" level=info msg="Alloc=6122 TotalAlloc=941692 Sys=28005 NumGC=569 Goroutines=176"
time="2024-07-17T05:22:26.469Z" level=info msg="Processing workflow" Phase= ResourceVersion=11598301 namespace=default workflow=nginx-workflow
time="2024-07-17T05:22:26.469Z" level=info msg="Updated phase  -> Error" namespace=default workflow=nginx-workflow
time="2024-07-17T05:22:26.469Z" level=info msg="Updated message  -> malformed workflow template \"default/nginx\": quantities must match the regular expression '^([+-]?[0-9.]+)([eEinumkKMGTP]*[-+]?[0-9]*)$'" namespace=default workflow=nginx-workflow
time="2024-07-17T05:22:26.469Z" level=error msg="was unable to obtain node for nginx-workflow" namespace=default workflow=nginx-workflow
time="2024-07-17T05:22:26.469Z" level=info msg="Marking workflow completed" namespace=default workflow=nginx-workflow
time="2024-07-17T05:22:26.469Z" level=error msg="Unable to set ExecWorkflow" error="malformed workflow template \"default/nginx\": quantities must match the regular expression '^([+-]?[0-9.]+)([eEinumkKMGTP]*[-+]?[0-9]*)$'" namespace=default workflow=nginx-workflow
time="2024-07-17T05:22:26.469Z" level=info msg="Workflow to be dehydrated" Workflow Size=927
time="2024-07-17T05:22:26.479Z" level=info msg="Workflow update successful" namespace=default phase=Error resourceVersion=11598302 workflow=nginx-workflow
time="2024-07-17T05:26:35.356Z" level=info msg="Alloc=6900 TotalAlloc=945779 Sys=28005 NumGC=571 Goroutines=176"
time="2024-07-17T05:31:35.356Z" level=info msg="Alloc=6087 TotalAlloc=949681 Sys=28005 NumGC=574 Goroutines=176"

Logs from in your workflow's wait container
kubectl logs -n argo -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded

this must be specific to under volumes because i know top level container ephemeral-storage works with arg


visualize oceano bottle data

[x] read the data
[ ] create read_bottle() in calcofi4r
[ ] map by station id. for now use the lon/lat in the file; maybe later lookup an authoritative location.
[ ] visualize initial variables

Appendix 1: CalCOFI Data Inventory 2021 - Google Sheets:

Ocean temperature & HCI: temperature, salinity, oxygen, nutrients
Hypoxia: temperature, salinity, oxygen, nutrients
[OA/DIC: separate db; on website under pH]: Dissolved inorganic carbon (DIC) & total alkalinity (TA)

Profiling

Surfer

How?

across survey segments on only or any place?

noaa-iea.github.io/fl-wq

Two Different Views
A. Survey Tracks

Initial Map View: survey tracks
Selectable: segments along each line (that could include underway data along surface)
Plot: Profile plot along track, so starting distance (min(date)) on x axis

B. Interpolated Surface

Initial Map View: kriged surface, possibly with light tracks overlaid
Selectable: draw a transect (within extent of kriged surface)
Plot:

Profile plot along arbitrary transect
Measures of uncertainty with plot

Modeling methodologies for profile and kriging

gam(y ~

@cdobbelaere,
You can use oceano-bottle.Rmd and set path to Google Drive folder calcofi - Google Drive where it's sync'd to your local machine (using Download - Google Drive)

See #3 for more AOIs


How to use Docker from a windows machine

If Kitematic doesn't work, how do we have them use Docker from command line? Do the same commands work as they do for Mac?
Change repository to reflect this.

With the updates in #22, we have to set a password from the command line. So the steps will be (Mac and Linux at least):

Pull the appropriate image

docker pull ccdl/training_rnaseq:2019-houston

Run the container

docker run -e PASSWORD=<PASSWORD> -p 8787:8787 ccdl/training_rnaseq:2019-houston

Open Kitematic - you should see an image running.
Settings > Volumes > Set local folder to "main directory" that was transferred from the flash/hard drive
(Optional) Settings > General > Can rename the container to something like training_rnaseq by changing the NAME field
Navigate to localhost:8787 in your web browser
Log into RStudio. The username will be rstudio and the password will be whatever you selected above (can also be accessed from the Settings > General panel).
You should see a kitematic/ folder in your RStudio Files panel. Click on it. If you do not see the training modules folders in the kitematic folder, raise your hand.

Just gave this a try on the ALSF desktop (Windows 7 Professional). The commands worked. Navigating to localhost:8787 does not. So we should probably say

Go to the Home tab and look for the ACCESS URL in the IP & PORTS pane. Copy this URL and paste it into the navigator bar of your web browser.

This is similar to what we have here now: https://github.com/AlexsLemonade/RNA-Seq-Exercises#post-docker-steps

Do we want to split this into a "Kitematic" and "without Kitematic" steps?

For now, I might do "Before Kitematic" (steps 1&2) and "With Kitematic" (3-8) and then see what tomorrow's dry run brings.

The current steps 1 & 2 on the README are written as using Kitematic to pull the image. So I'm not sure how you mean to divvy this up.

We have to set a password from the command line. Steps 1 & 2 above replace what is currently on the README.

Can we get rid of the Optional step 5? I feel like it's doesn't help much and only adds an extra step where something could get messed up.

Sure

This was partially addressed by #24, but we need to do further testing with the Windows 10 computers that we should be using tomorrow.

Closed by https://github.com/AlexsLemonade/training-modules/pull/51


schema.links in editors.multiple.buildChildEditor should be removed

when schema.type is an array or not defined, and property links is defined, child Editors schema will be extended WITH the 'links' property, resulting in displaying those links twice.
should be delete before or after extending

Can you provide an example schema that causes this issue?

I've uploaded a live demo here http://hkuclion.com/demo/JsoneditorDemo/
If it's not opening, here's the quick reference
var schema1 = {
	'type':'object',
	'title':'without type',
	'properties':{
		'hkuc':{
			'additionalProperties':true,
			'title':'hkuc',
			'links':[{
				'href':'https://github.com/jdorn/json-editor/issues/629',
				'rel':'issue 629'
			}]
		}
	}
};

var schema2 = {
	'type':['string','boolean'],
	'title':'multiple type',
	'links':[{
		'href':'https://github.com/jdorn/json-editor',
		'rel':'best json editor ever'
	}]
};

Is there any update on this issue. I verify that I observe the same behaviour.
Also it would be nice if we could remove /hide the dropdown with null, if we did not specify the object type. It will just be a hyperlink and we have a good usecase to show hyper links.
Will that be possible, just to have a link ...? Please let us know

I had my own correction for the link property, it works here, but I don't know if it will cause further problem, just paste it here for reference.
If you are using version 0.7.28, use the unminified version, change line 4479~4491
    if(typeof type === "string") {
      schema = $extend({},self.schema);
      schema.type = type;
    }
    else {
      schema = $extend({},self.schema,type);
      schema = self.jsoneditor.expandRefs(schema);

      // If we need to merge `required` arrays
      if(type.required && Array.isArray(type.required) && self.schema.required && Array.isArray(self.schema.required)) {
        schema.required = self.schema.required.concat(type.required);
      }
    }

like below
    if(typeof type === "string") {
      schema = $extend({},self.schema);
      /*hkuc_20160704[*/
      delete schema.links;
      /*]*/
      schema.type = type;
    }
    else {
      /*hkuc_20160704[schema = $extend({},self.schema,type);]*/
      /*hkuc_20160704[*/
      schema = $extend({}, self.schema);
      delete schema.links;
      schema = $extend(schema, type);
      /*]*/
      schema = self.jsoneditor.expandRefs(schema);

      // If we need to merge `required` arrays
      if(type.required && Array.isArray(type.required) && self.schema.required && Array.isArray(self.schema.required)) {
        schema.required = self.schema.required.concat(type.required);
      }
    }

And it should work

Great Thanks for your fix !
Now this is what we see before the fix

This is what we see after this

However, this only fix part of my posted issue. I know each element need a type, but is there a way to get the dropdown hidden (null seems to be odd and it there a ways to hide a type element and then maybe fix the link alignment in the table too.
Ideally it should only be Test and then the link ...

Any update on how to overcome this issue ... All ideas are welcome.

Setting type to 'null' (a string) will prevent displaying the input control, but this also remove everything like the title.
If you really need a title, either set it as an property of a titled object, or write an extension to the types of the Editor.

Thank you for your suggestions


Allow extra options to the build process

Follow-up to #568
Is your request related to a problem? Please describe.
Originally issue was created due to a problem when building npm lambda with docker. Thinking this through, the workaround works, but can also make the process a bit clunky since it's different when building locally.
With npm, we might need to run npm install --omit=dev, with an alternative to add NODE_ENV=production environment variable in the docker_additional_option, but that doesn't handle the local build, which needs those variables set when running terraform apply (not tested).
Other runtimes might have the same issue, like golang using GOOS and GOARCH for instance, maybe GOFLAGS to add -tags, -ldflags (usually those are in arguments, so need to check if the env var is enough).
Describe the solution you'd like.
Allow some variables to be exposed both for the docker build and local build.
Describe alternatives you've considered.
Workaround only tested with the docker build, but with a local build it won't work.

I have the same problem.

this work for me
source_path = [
  {
    path = var.lambda_functions[count.index].source_path
    commands = [
      "npm install",
      "npm run build",
      "npm prune --omit=dev",
      ":zip"
    ]
  }
  ]


[shared_preferences] Use executeOnExecutor instead of execute.

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ Googlers: Go here for more info.

@googlebot I signed it!

We apologize for the long delay in triaging this PR. We’re in the process of overhauling our PR triage system to respond much more quickly, as well as working through the backlog.
Could you please fill in the PR description? It's not clear what the motivation for this change is and what problem you are trying to solve.


xds: crash in onDiscoveryResponse

We experienced a crash in the XDS code path in our CI. Unfortunately we don't have a lot of debug info here (this is one of the few areas without core dumping support). Attached below are the logs
Envoy log: https://storage.googleapis.com/istio-prow/logs/integ-security_istio_postsubmit/1505969504671240192/artifacts/security-90e03050bd514c82bd47a1/TestReachability/_test_context/test-ns1-1-99926-state1182920515/primary-0/vm-v1-55b6b4d745-nnkx6_istio-proxy.envoy.err.log
Core dump: unfortunately not available
Config dump: we don't have the exact config, but it should be extremely similar to https://storage.googleapis.com/istio-prow/logs/integ-security_istio_postsubmit/1505969504671240192/artifacts/security-90e03050bd514c82bd47a1/TestReachability/_test_context/test-ns1-1-99926-state1182920515/primary-0/a-v1-7f7dc896d6-qzzj7_proxy-config.json which was another non-crashing workload running at the same time.

But it's not clear to me if that is the root cause of the crash.


Fix feature and thumbnail images of GeoCAT tutorial blog post

Noticed two images were swapped. This PR fixes

Merged without approvals because there was no content change, only image swapping instead.


Fixed gcc non virtual destructor warning (bin.h) plus minor const fix

Added virtual destructor to BinIterator class. Let's see if using C++11's default works on Travis and MSVC.

Hi @cbecker, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

@guolinke I think this may be an important fix. Does  = default works on the Visual Studio version you are supporting for LightGBM? If so then this patch should be good to go.


EventHub dev version in 'unreleased' folder

Just to plug the Swagger update system and begin some tests.

Coverage remained the same at 55.738% when pulling 56b5a65838fbbf9d2c5f612df8dc01aa1b49a1de on lmazuel:eventhub-arm into cf9b2f30901f7adb6c661ec32e3a5875dbf79add on Azure:master.

Coverage remained the same at 55.738% when pulling 56b5a65838fbbf9d2c5f612df8dc01aa1b49a1de on lmazuel:eventhub-arm into cf9b2f30901f7adb6c661ec32e3a5875dbf79add on Azure:master.


[feature]: support multiple outgoing channel IDs in lncli

I want to pay an invoice using either all channels except A B C or define them X Y Z
lncli payinvoice --timeout 20m --fee_limit 35 --outgoing_chan_id XXX YYY ZZZ --pay_req
results in only XXX being used.
lncli payinvoice --timeout 20m --fee_limit 35 —outgoing_chan_id XXX —outgoing_chan_id YYY —outgoing_chan_id ZZZ --pay_req
results in only ZZZ being used.
response when using the --outgoing_chan_ids flag described in api-docs
[lncli] flag provided but not defined: -outgoing_chan_ids
LND_0.16.4-beta
what am I missing?

The API docs don't describe LNCLI, they describe the API that LNCLI uses

May I take this one?

By the way, for the query routes call, I would say we need to change it to accept the same as the payment, an array of strings for the outgoing_chan_id.

reopening as the pr is not merged yet


使用kubeflow1.6.1  使用自定义镜像有问题

使用
kubeflow1.6.1
k8s 1.22
k8s-gpushare-schd-extender:1.11-d170d8a
InferenceService
apiVersion: "serving.kserve.io/v1beta1"
kind: "InferenceService"
metadata:
  name: "firesmoke"
spec:
  predictor:
    containers:
      - name: kserve-container
        image: harbor.xxx.cn/library/model/firesmoke:v1
        env:
          - name: MODEL_NAME
            value: firesmoke
        resources:
          limits:
            aliyun.com/gpu-mem: 1

error
Status:
  Components:
    Predictor:
      Latest Created Revision:  firesmoke-predictor-default-00001
  Conditions:
    Last Transition Time:  2023-02-07T16:30:17Z
    Message:               Revision "firesmoke-predictor-default-00001" failed with message: binding rejected: failed bind with extender at URL http://<IP_ADDRESS>:32766/gpushare-scheduler/bind, code 500.
    Reason:                RevisionFailed
    Severity:              Info
    Status:                False
    Type:                  PredictorConfigurationReady
    Last Transition Time:  2023-02-07T16:30:17Z
    Message:               Configuration "firesmoke-predictor-default" does not have any ready Revision.
    Reason:                RevisionMissing
    Status:                False
    Type:                  PredictorReady
    Last Transition Time:  2023-02-07T16:30:17Z
    Message:               Configuration "firesmoke-predictor-default" does not have any ready Revision.
    Reason:                RevisionMissing
    Severity:              Info
    Status:                False
    Type:                  PredictorRouteReady
    Last Transition Time:  2023-02-07T16:30:17Z
    Message:               Configuration "firesmoke-predictor-default" does not have any ready Revision.
    Reason:                RevisionMissing
    Status:                False
    Type:                  Ready
Events:                    <none>

kubectl get pods -n kube-system |grep gpushare
gpushare-device-plugin-ds-h9h9t              1/1     Running     0          22h
gpushare-schd-extender-6774756f54-xk7sw      1/1     Running     0          22h

Hi!
I have the same problem. After getting trough the setup process everything looked good. We wanted to start the nvidia-version-check pod:
apiVersion: v1
kind: Pod
metadata:
  name: nvidia-version-check
spec:
  runtimeClassName: nvidia
  restartPolicy: OnFailure
  containers:
  - name: nvidia-version-check
    image: "nvidia/cuda:11.0.3-base-ubuntu20.04"
    command: ["nvidia-smi"]
    resources:
      limits:
        # GiB
        aliyun.com/gpu-mem: 8

The following error occurred:
Warning  FailedScheduling  26s   default-scheduler  failed bind with extender at URL http://<IP_ADDRESS>:32766/gpushare-scheduler/bind, code 500
The device plugin and the schd-extender seem to be running fine:
kubectl get pods -n kube-system |grep gpushare
gpushare-device-plugin-ds-rntz8           1/1     Running   0               11m
gpushare-schd-extender-5d8d4c849f-szkqw   1/1     Running   0               41m

I'm using kubernetes version 1.26.5

It seems to be very helpful the check the output of the gpushare-schd-extender:
[  warn ] 2023/06/21 18:11:36 gpushare-bind.go:36: Failed to handle pod jupyterlab-8c7544cbc-4m8pk in ns default due to error Pod "nvidia-version-check" is invalid: spec: Forbidden: pod updates may not change fields other than `spec.containers[*].image`, `spec.initContainers[*].image`, `spec.activeDeadlineSeconds`, `spec.tolerations` (only additions to existing tolerations) or `spec.terminationGracePeriodSeconds` (allow it to be set to 1 if it was previously negative)
  core.PodSpec{
        ... // 24 identical fields
        DNSConfig:          nil,
        ReadinessGates:     nil,
-       RuntimeClassName:   &"nvidia",
+       RuntimeClassName:   nil,
        Overhead:           nil,
        EnableServiceLinks: &true,
        ... // 4 identical fields
  }

In our case the problem was, that the scheduler (or another component) tried to change to RuntimeClassName back to nil. As we did not want the every pod runs in the nvidia runtime we explicitly not set this as the default runtime but specified this for deployments which needed GPU access. But this seams not to be compatible with the scheduler.
@631068264 maybe you can also share the outputs of: kubectl logs -n kube-system gpushare-schd-extender-XXX

Finally I follow this https://github.com/kserve/kserve/issues/924 and use volcano and Time-Slicing GPUs in Kubernetes  to solve gpu-mem share.
This is my note


Support https url scheme (add Faker::Internet.secure_url)

for issue https://github.com/stympy/faker/issues/459
I just added Faker::Internet.secure_url to create fake https url.
Maybe it would be better if url method support all url components like
Faker::Internet.url(scheme: 'https', domain: 'example.org')
but it is not good to make breaking changes. so I just added new method

@juyeong: why don't you make scheme have default as http?
Faker::Internet.url(host = domain_name, path = "/#{user_name}", scheme = 'http')
Faker::Internet.url(host = domain_name, path = "/#{user_name}", scheme = 'https')

Closed in favor of #747.


[feat] Easier updates for system tray menu

Describe the problem
I've gotten updates to work with the following approach, but they feel a bit inefficient
let tray = app.tray_by_id("main-tray").unwrap();

// Re-adding updated items to a new menu
let menu = MenuBuilder::new(app)
        .items(... )
        .build()
        .unwrap();

// Replace the menu
tray.set_menu(Some(menu)).unwrap();

Describe the solution you'd like
It would probably be better to include the current menu as part of the tray so object so it can be modified.
let tray = app.tray_by_id("main-tray").unwrap();

let menu = tray.menu();

// We can then modify the menu
... menu.insert();
... menu.remove();

Alternatives considered
No response
Additional context
No response

+1


Mentions not linking to User profiles

Description of the problem
I created a thread message with multiple mentions. The message posts however the mentions don't link to the User's profile like a typical mention on Facebook does. May not be a true issue but was expecting the mention to have the same experience at a standard mention.
Code to reproduce
# Logging In
from fbchat import Client
from fbchat.models import *

client = Client('email', 'password')

# Check to see if logged in
if not client.isLoggedIn():
    client.login('email', 'password')

# Thread ID =<PHONE_NUMBER>

thread_id = '0123456789'
thread_type = ThreadType.GROUP

# Will send a message with a mention
client.send(Message(text='Testing the @User1 @User2',
    mentions=[Mention(thread_id, offset=12, length=6),
    Mention(thread_id, offset=19, length=6)]),
    thread_id=thread_id,
    thread_type=thread_type)

# Securely log out
client.logout()

Environment information

Python 3.7.3
fbchat 1.8.3

When you're making mentions Mention(user_id, offset=19, length=6) - the user_id must be the mentioned user ID.
Or you can use formatMentions
client.send(Message.formatMentions("Testing the {} {}",
	('<first user id>', '@User1'), ('<second user id>', '@User2')),
	thread_id=thread_id, thread_type=thread_type)

I'll assume this is solved by @kapi2289's suggestion


make colorschemes integration "better"

Right now, only catppuccin is really "good" :/

onedarkpro LGTM

wait, I gotta do the alpha headers with onedarkpro


Placing a Quarry Addon On Block Destroyer Causes Game Crash

Issue description
The title says all. When I tried to place a quarry addon on a block destroyer, the game crashed.
Steps to reproduce

Create a new world;
Place a rectangle machine frame, and a block destroyer with 2 Ultimate Machine Core;
Place a quarry addon beside it;
If everything works "well", Minecraft will crash now.

Minecraft version
1.21 (Latest)
Fabric loader version
0.16.3
Fabric API version
0.103.0+1.21.1
Oritech version
0.8.1 (Mekanism? The form description is probably wrong.)
Other relevant versions
Err, I think the crash report includes it.
If a (crash)log is relevant for this issue, link it here: (It's almost always relevant)
https://gist.github.com/OakPlatinum/979d5b6949571c56fddba27473da1cb2

Power Bank Addon too :(

Hi, you seem to be using minecraft 1.21.1, which isn't supported by Oritech yet. Version 0.8.1 is compiled for 1.21. Minecraft 1.21.1 support will be released in a few days

Really? Can't believe I didn't realize it until now. XD


gafferpy seed matching backwards compatibility

Gaffer 2 removed seed matching, but gafferpy could retain backwards compatibility with existing scripts by adding this back and translating the json to use Views instead.

This could be done with **kwargs and the Operation base class

SeedMatching was only used in GetElements and GetElementsBetweenSets so it could also be used in just those

This can only be done in operations when there is no View provided and when the user provides elements rather than seeds. This is because the group is needed to put into the View.


[log] debug log in init functions would never show

because cli set the level after the init functions has been called ...
we should be able to enable that by setting the default level using ldflag, so even debug in init function would work

one way to avoid using ldflag is check a fixed environment variable like GOMMON_LOG_LEVEL, when using vendor I think it was possible to set ldflag for dependencies, when using go mod I am not sure if it is possible, also this makes application using library change their build flags as well


Publish wheels?

Thanks for this useful library! I'm just filing this issue to collect interest in having wheels for this library.

@mbr, is there some way we can help here?

Definitely interested, and willing to help if needed. Offline installation is complicated without published wheels.


Check for importing named exports from CJS module

With the new node.js 8.5 ESM support importing CJS modules as if they had named exports is not supported. (Unlike Babel)
Eg:
// bad
import { get } from 'lodash';

//good
import _ from 'lodash';
const get = _.get;

//good
import { get } from 'lodash-es';

This should be the case already - the fact that Babel allows it is a quirk of their implementation, and not something this plugin should allow.

This plugin should prevent it
On 19 Sep 2017 01:49, "Jordan Harband"<EMAIL_ADDRESS>wrote:

This should be the case already - the fact that Babel allows it is a
quirk of their implementation, and not something this plugin should allow.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/benmosher/eslint-plugin-import/issues/928#issuecomment-330396008,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAZQTJSyPAf4hTlUoxiZwg-pV_NcGRU7ks5sjw-igaJpZM4PZh9z
.

Right, sorry, what I mean to say is that this should have always been the default behavior, and an option should have been required to allow named imports from CJS packages (probably a separate one for node_modules and for project code).
What we should do now is add these options, but inverted - so that you can enable the correct and stricter checking.

To clarify (as on IRC), this is technically already case in named.

A module path that is ignored or not unambiguously an ES module will not be reported when imported.

This should be tweaked so that importing named imports from CJS files errors

Indeed - this should be done via an option so as not to be a breaking change. Additionally, this option should be able to differentiate between project code, and node_modules code, since you can't control the latter's use of syntax.

Just to add something new here:
According official node documentation, in ESM, file extensions are mandatory, with default value for this rule, it breaks Node native behavior.

@klarkc file extensions for relative paths are mandatory. For packages, "exports" can (and always should) provide an extensionless specifier.


Awesome Vite repo

Is your feature request related to a problem? Please describe.
The Vite ecosystem is growing but there's no centralized location to see cool projects related to Vite (eg. "Awesome Vite" repo).
Describe the solution you'd like
Awesome Vite repo. Thought about making one, but an official one under the vitejs org is probably better.
Describe alternatives you've considered
Search via "vite" keyword in npm
Additional context
Some cool plugins I found:

vite-plugin-react (official plugin)

vite-plugin-svelte

vite-transform-globby-import

vite-plugin-markdown

vite-plugin-vue2

vite-plugin-voie

vitesse

Made one on my own for now: https://github.com/antfu/awesome-vite
I am asking @yyx990803 if he would like to make it official.


No module named win32api

Hi,
when I start main.py I got the following error:
ImportError: No module named win32api
How can I install win32api on Mac??
pip install pypiwin32 doesn't work with error:
Could not find a version that satisfies the requirement pywin32>=223 (from pypiwin32) (from versions: )
No matching distribution found for pywin32>=223 (from pypiwin32)
Please help. Thanks !!
Marco

Hi,
I only tested this on windows, so most likely it doesn't work on Mac.
If you want to use it there, you need to replace the win32 api that I use for mouse capture with something a bit more platform agnostic (or at least mac specific).
At the time when I wrote this I couldn't find something easy to use for mouse control that's multi-platform so I just used directly the windows-specific one, but I am sure something is out there.
Thanks,
Alex