Fix error when pressing the split button on the split bill details page with a receipt

Details

Pressing the split button on the split bill details page with a receipt will give an error because we are trying to access a property from an undefined transaction object.
Fixed Issues

$ https://github.com/Expensify/App/issues/32809
PROPOSAL: https://github.com/Expensify/App/issues/32809#issuecomment-1850282591
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Open a group chat
Press the + action button and choose Split bill
Switch to the Scan tab and select a receipt image
Confirm the split
Press the split preview on the chat
Press Split
Verify Enter an amount, Enter a merchant name, and Transaction is missing fields error message are shown
Fill in the amount and merchant fields
Press Split again
Verify the split amount and merchant is updated

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/50919443/7f320052-bdcc-46dc-a048-20c6cae37510

Android: mWeb Chrome

https://github.com/Expensify/App/assets/50919443/a1091661-0f4b-4d38-9b9d-82d7c4044bb4

iOS: Native

https://github.com/Expensify/App/assets/50919443/309b8d38-003a-43cb-92bc-a12f3cdf11af

iOS: mWeb Safari

https://github.com/Expensify/App/assets/50919443/e29f52f8-ccd8-4202-a1c7-55511924bc83

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/50919443/1f6927db-591e-4720-8631-283642eed09b

MacOS: Desktop

https://github.com/Expensify/App/assets/50919443/3bd988ff-1516-4b63-9b21-355da1cf3cf6

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/58412969/b57f194a-de27-4a93-91c9-d3bae4362d02

Android: mWeb Chrome
https://github.com/Expensify/App/assets/58412969/c0e14955-3356-405b-8769-2f109a1c7fab

iOS: Native
https://github.com/Expensify/App/assets/58412969/dc0b3c7b-726d-4e48-baf0-fc018fe9d75e

iOS: mWeb Safari
https://github.com/Expensify/App/assets/58412969/df631ebe-73ea-4935-aead-f844170b7b86

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/58412969/8501c7f0-7fab-4174-90a6-9af109a100f2

MacOS: Desktop
https://github.com/Expensify/App/assets/58412969/eb922a56-d5a9-44b0-a3e5-370ebd18747b

@mountiny Please CP this

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 1.4.11-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.11-25 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


[Feature Request] Support for Alexa as a channel

Issue Description
Following the announcement from Microsoft and Amazon that Cortana and Alexa will work together in the future (http://phx.corporate-ir.net/phoenix.zhtml?c=176060&p=irol-newsArticle&ID=2297243), the question is not far away: Will there be a channel for Alex, so that a bot made with the MS Bot Framework can act as an Alexa skill somehow?

Any news?

Thumbs up, for the feature request. I have the bot but Alexa users cant use it :( I hope Bot framework will support at least most popular channels. Amazon Alexa and Google Assistance are two big names.

There was a talk at Build 2018 about Cortana + Alexa integration. I think its on the roadmap but not sure of Alexa can come as a channel.

Thank you for opening an issue against the Bot Framework SDK v3. As part of the Bot Framework v4 release, we’ve moved all v3 work to a new repo located at https://github.com/microsoft/botbuilder-v3. We will continue to support and offer maintenance updates to v3 via this new repo.
From now on, https://github.com/microsoft/botbuilder repo will be used as hub, with pointers to all the different SDK languages, tools and samples repos.
As part of this restructuring, we are closing all tickets in this repo.
For defects or feature requests, please create a new issue in the new Bot Framework v3 repo found here:
https://github.com/microsoft/botbuilder-v3/issues
For Azure Bot Service Channel specific defects or feature requests (e.g. Facebook, Twilio, Teams, Slack, etc.), please create a new issue in the new Bot Framework Channel repo found here:
https://github.com/microsoft/botframework-services/issues
For product behavior, how-to, or general understanding questions, please use Stackoverflow.
https://stackoverflow.com/search?q=bot+framework
Thank you.
The Bot Framework Team


Skobbler sdk v 2.4

Hi TrekDev,
Any plans on upgrading the bindings to Skobbler sdk v 2.4?
Regards,
Dhanush

Hi Dhanush,
I'm currently in the process of upgrading the SDK. You can checkout the develop branch and see how far I've got. Currently, the binding project should be OK to use, the main problem is the new SDK Tools project (not required to use the SDK, mostly helper classes), which just has a lot of new code and requires a bit of thought to translate it accurately into C#.
If you would like them done sooner you could checkout the develop branch and raise any issues you find in the new SDK Demo. It would be a big help for me so I can fix them as soon as I get the chance.
-TD


Fold consecutive const static

PR to implement #8114

lgtm!

bors r+
changelog feature:  fold consecutive consts and statics


CMake: build all targets in the same directory, so that "hamcore.se2" doesn't have to be copied for each of them

This results in a faster build and less space required.

SoftEther VPN Patch Acceptance Policy:
http://www.softether.org/5-download/src/9.patch
I choose option 1.

I guess launchpad might be affected, @paskal ?

OpenWRT builds, @andy2244 ?

@chipitsine What are you asking exactly, if this PR works for my openWRT version? I will have to adapt the makefile, but don't see why it wont, only some output dirs changed?

@Andy2244 , yes, I meant that. thanks.

@chipitsine The binary is present, see: https://travis-ci.org/SoftEtherVPN/SoftEtherVPN/jobs/442953906#L1309

can you please reproduce ubuntu 18.04 fresh build including "make package" and investigate resulting deb ?

https://gitlab.com/davidebeatrici/SoftEtherVPN/-/jobs/109588303

https://gitlab.com/davidebeatrici/SoftEtherVPN/-/jobs/109596818
Package: https://gitlab.com/davidebeatrici/SoftEtherVPN/-/jobs/109596818/artifacts/file/build/softether-vpnserver_5.1.9660-1_amd64.deb

unfortunately, I deleted vm.
give me 30 min

No problem.

Should we maybe upload generated deb files from GitLab CI/CD instead of building them in Launchpad? That way new versions will be uploaded as soon as they are ready and we won't have appendix of debian folder in separate repo.

@paskal , there are few thoughts

launchpad is running native armh, arm64 build agents. it is good
currently we do not support cross builds (but we wish)
current deb files include startup scripts only for systemd (if target system supports systemd)
we do not know how to upload to launchpad (it would be really nice if you can help here)

we can include init files as a fallback for 12.04 and other systems without systemd.
The upload is pretty easy
But because of 2) it's preferable to start doing this after cross builds will be possible, otherwise we can't switch to self builds.

@davidebeatrici
root@ubuntu-18:~/softethervpn# dpkg -i /home/ilia/softethervpn/build/softether-vpnserver_5.1.9660_amd64.deb
Selecting previously unselected package softether-vpnserver.
(Reading database ... 67327 files and directories currently installed.)
Preparing to unpack .../softether-vpnserver_5.1.9660_amd64.deb ...
Unpacking softether-vpnserver (5.1.9660) ...
Setting up softether-vpnserver (5.1.9660) ...
root@ubuntu-18:~/softethervpn#

root@ubuntu-18:~/softethervpn# cat /lib/systemd/system/softether-vpnserver.service | grep ExecStart
ExecStart=/usr/local/libexec/softether/vpnserver/vpnserver start
root@ubuntu-18:~/softethervpn#

root@ubuntu-18:~/softethervpn# ls -l /usr/local/libexec/softether/vpnserver/vpnserver
ls: cannot access '/usr/local/libexec/softether/vpnserver/vpnserver': No such file or directory
root@ubuntu-18:~/softethervpn# ls -l /usr/libexec/softether/vpnserver/vpnserver
-rwxr-xr-x 1 root root 2154528 Oct 18 09:54 /usr/libexec/softether/vpnserver/vpnserver
root@ubuntu-18:~/softethervpn#


Add environment variable and client validation telegram and readme step by step to run the project.

I made the project receive the variable in the form of enviroment to avoid that they are placed directly in the code and I made a validation to verify that the bot knows telegram, also I placed step by step information on how to run the project.

@nuhmanpk  please add in the labels :
hacktoberfest-accepted
hacktoberfest-approved  hacktoberfest
hacktoberfest2023

@nuhmanpk please add in the labels : hacktoberfest-accepted hacktoberfest-approved hacktoberfest hacktoberfest2023

Think they are already added, you can track them in official
hacktoberfest website.


Unable to run lstm model successfully

Below is the command I am trying:
$ python cliner train --txt "data/i2b2/.txt" --annotations "data/i2b2/.con" --format i2b2 --model models/i2b2_lstm.model --use-lstm
Here is the trace:
NO DEV
IN ERROR CHECK
0.1
Creating 90/10 train/dev split
vectorizing words all
TESTING NEW DATSET OBJECT
Traceback (most recent call last):
File "cliner", line 60, in
main()
File "cliner", line 49, in main
train.main()
File "/Users/ag33366/CliNER/code/train.py", line 155, in main
train(training_list, args.model, args.format, args.use_lstm, logfile=args.log, val=val_list, test=test_list)
File "/Users/ag33366/CliNER/code/train.py", line 187, in train
model.train(train_docs, val=val_docs, test=test_docs)
File "/Users/ag33366/CliNER/code/model.py", line 199, in train
test_sents=test_sents, test_labels=test_labels)
File "/Users/ag33366/CliNER/code/model.py", line 253, in train_fit
dev_split=dev_split     )
File "/Users/ag33366/CliNER/code/model.py", line 382, in generic_train
dataset = Exp.Dataset()
NameError: name 'Exp' is not defined
I am able to run the crf model successfully but having issues with LSTM. Could you please reply as soon as possible. Thank you.

@Ketki-Savle the chunk of coding that is bugging is: https://github.com/text-machine-lab/CliNER/blob/70fd8e5cd888f8cbb66913965e277c264984f124/code/model.py#L382
It looks like Exp.Dataset() is trying to create an instance of the Dataset class at: https://github.com/text-machine-lab/CliNER/blob/70fd8e5cd888f8cbb66913965e277c264984f124/code/DatasetCliner_experimental.py#L70
The only import for DatasetCliner_experimental is in an if clause in another method ("ClinerModel"), which I assume is getting skipped (not looked into details).
Perhaps try moving all of the imports at https://github.com/text-machine-lab/CliNER/blob/70fd8e5cd888f8cbb66913965e277c264984f124/code/model.py#L148 to the top of model.py.

Hello,
I actually moved that statement at the beginning with all import statements and it worked. Your observation is correct, that if loop was probably not importing all those statements correctly.
Thank you.
-Ketki

Glad to hear that worked! If you have the chance, please could you make a pull request to the repo, so that the fix can be merged? No problem if you'd prefer not to...I expect someone will get to it later :)


chore(charts): expose 'etcd.clusterDomain' from the mayastor chart

This exposes the etcd.clusterDomain value from the mayastor chart. This is commented by default, so that its presence is conveyed while still using the mayastor chart's value by default.
Ref: #3741
@balaharish7 -- we could refer to this value in our docs.

This issue is documented in the PR #462.

These changes are included in #3754.


Option to make ambiguity more strict

Right now intensity in fragment ions reduces ambiguity. For topdown I think there should be the option to have ambiguity based on fragment ion count. If two things have the same fragment ion counts and one has a silghtly more intense fragment ion, they're not ambiguous. I'd like  an option to have them be ambiguous and reported on the same line in the psmtsv with a "|"

Also for this issue, it will be necessary to fix the matched ion columns to report both matched ion series when they differ between the two ambiguous IDs (but both are reported because same # matched ions)


Cannot get Rancher installed in a 3 node HA environment behind proxy using RKE

What kind of request is this (question/bug/enhancement/feature request):
Question
Steps to reproduce (least amount of steps as possible):
Setup 4 nodes (3 for Rancher, 1 LB).  Install NGINX on LB one.  Create rancher-cluster.yml file with node information and proxy info.
Result:
Failed to apply the ServiceAccount needed for job execution: Post https://my.ip:6443/apis/rbac.authorization.k8s.io/v1/clusterrolebindings?timeout=30s: CONNECTnotallowed
Other details that may be helpful:
Behind a corporate proxy.  Proxy configured at ~/.docker/config.json and /etc/systemd/system/docker.service.d/proxy.conf
Able to do single node install with proxy settings specified without issue
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI):
Installation option (single install/HA):

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported):
Machine type (cloud/VM/metal) and specifications (CPU/memory):
Kubernetes version (use kubectl version):
Cluster is on VMware vCenter 6.5
Docker version (use docker version):
18.09

This has been very frustrating.  Looked around everywhere, Rancher slack, Rancher forum, google, nothing I can find helps me get Rancher to install using rke in an HA cluster setup.  This all worked before we had a proxy, now I'm rebuilding with the proxy and I'm unable to do so.  Seems like I need to configure the rancher-cluster.yml in some specific way, but nothing I do works.   What I have currently is below:
nodes:

address: <IP_ADDRESS>
user: testuser
role: [controlplane,worker,etcd]
address: <IP_ADDRESS>
user: testuser
role: [controlplane,worker,etcd]
address: <IP_ADDRESS>
user: testuser
role: [controlplane,worker,etcd]

services:
etcd:
snapshot: true
creation: 6h
retention: 24h

kind: Deployment
apiVersion: extensions/v1beta1
metadata:
namespace: cattle-system
name: cattle
spec:
replicas: 1
template:
metadata:
labels:
app: cattle
spec:
serviceAccountName: cattle-admin
containers:
# Rancher install via RKE addons is only supported up to v2.0.8
- image: rancher/rancher:v2.0.8
imagePullPolicy: Always
name: cattle-server
env:
- name: HTTP_PROXY
value: "http://my.proxy:myport"
- name: HTTPS_PROXY
value: "http://my.proxy:myport"
- name: NO_PROXY
value: "localhost,<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>/8,.my.domain"
livenessProbe:
httpGet:
path: /ping
port: 80
initialDelaySeconds: 60
periodSeconds: 60
readinessProbe:
httpGet:
path: /ping
port: 80
initialDelaySeconds: 20
periodSeconds: 10
ports:
- containerPort: 80
protocol: TCP
- containerPort: 443
protocol: TCP
volumeMounts:
- mountPath: /etc/rancher/ssl
name: cattle-keys-volume
readOnly: true
volumes:
- name: cattle-keys-volume
secret:
defaultMode: 420
secretName: cattle-keys-server
So what am I missing?  This is driving me nuts and I feel like I'm just some simple solution away from moving forward on this.

The RKE repo has an issue with the error here https://github.com/rancher/rke/issues/669, as the proxy config is not shared it's hard to tell what is wrong. Let me know if the solutions in that issue solve it, if not, please file it in the RKE repository as it seems you are hitting the issue using RKE CLI so we can investigate.
Also, not related to this issue, please note that v2.0.8 was released in August 2018 and is not recommended for use anymore. It is highly recommended to use a recent version using the steps described on https://rancher.com/docs/rancher/v2.x/en/installation/ha/

Unfortunately the link you provided did not work for me.  That was the first thing that came up when I got the error.  I am also installing Rancher using rancher/rancher:latest, which gives me 2.2.4 at the moment and I've been using the steps in the link you provided.

Opened issue here: https://github.com/rancher/rke/issues/1421


source code aware transformations

This is a proof of concept solution to #399.

It looks like pushing this PR further will require a significant design effort that I don't have time for right now. At the moment, the main and only priority is shipping the semantic API asap, so I'll close this PR for the time being.
@akhileshs Thank you very much for your attempt at solving the issue! If you'd like to revisit your prototype in the future, I'll do my best to support you as much as the roadmap permits.

@xeno-by No worries! Yeah, this definitely requires a conceptual redesign.


Sort Open Editors Files by Alphabet

Is there a way you implement a fueture of sorting Open Editors by Alphabet?

/duplicate of #12453


Add CODEOWNERS entries for Scanner

Description
Scanner is migrating into this repo, so this PR adds a few CODEOWNERS entries for the team
Checklist

[x] Investigated and inspected CI test results
~[ ] Unit test and regression tests added~
~[ ] Evaluated and added CHANGELOG entry if required~
~[ ] Determined and documented upgrade steps~
~[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)~

Testing Performed
Nah

superceeded by https://github.com/stackrox/stackrox/pull/6000


Implement styled Link component and BrandLogo component use that

Proposed Changes
As with the title.
Implementation

I added atoms/A as a styled Link component to like a generally a element.
I added atoms/BrandLogo by using that.
I replaced StakesSocialBlack and StakesSocialWhite with atoms/BrandLogo .

@abyssparanoia @k3nt0w In the localhost, I get a warning the following:
Warning: Prop `className` did not match. Server: "sc-AxirZ bPoBOq" Client: "sc-AxjAm jIaAfJ"

But I'm not getting that warning in the remote(now.sh).
Is this a problem that needs to be solved?

I think this issue (https://github.com/zeit/next.js/issues/7322) has something to do with it.
I think it`s better to list it as a separate issue and respond to it

Thank you for your advice!
Yeah, I merge it and to do as a separate issue. @abyssparanoia


Add indicator if a spent tx input is old

Let's do:

pre XEC (fixed date, Nov 15 2020)
pre BCH (fixed date, Aug 8 2017)
5 years old (rolling date)

Or maybe we can show multiple at once as the fixed date ones are special as they become more rare over time.

Where are you thinking this would be shown? Like on the tx details page? next to the age?
And are you thinking like a little badge or something? Maybe if you hover on it it explains what it means?

Let's show it in 2 places.

Icon in 'Inputs' column on the /block/ page.
Some sort of visual indicator on/around the input(s) in the 'Transaction' section of /tx/.

Okay added. Let me know if any issues or design changes

We want it to be relative to the UTXO age and the date it was spent, not the date it was spent to today.

See how there's a little blue icon next to each input on this one: https://explorer.bitcoinabc.org/tx/282376c104a409f4bac4c026d4f7fcc8ac024ebe9d25482da082cf3f489ac49e
Obviously it's possible for a tx to have some old and some non-old inputs.

https://reviews.bitcoinabc.org/T2905


♻ Exclude GitHub Actions Bot from Build as an Author

CC @adamcogan @bradystroud
Hi Team,
Description
The GitHub actions bot is appearing as an author in the latest merge commits alongside other contributors like Brady. We need to update the build process to ignore the bot as an author to ensure clear attribution of contributions.
Acceptance Criteria

[ ] Configure the build to ignore the GitHub actions bot as an author.
[ ] Ensure that only human contributors are listed as authors in merge commits.
[ ] Test this change to confirm that it doesn’t impact the build process or commit integrity.

Figure: Both Brady and GitHub bot are authors of the PR

could be a fix
https://github.com/peter-evans/create-pull-request/blob/HEAD/docs/concepts-guidelines.md#authenticating-with-github-app-generated-tokens


ImageList#append hangs

As instructed, I closed the issue at https://github.com/rmagick/rmagick/issues/129. I take it I should reopen it here, so here it is:
ImageList#append and other methods that output a single Image (such as #average) hang when used after adding more than one image via +=, #concat or <<. For example:
require 'rmagick'

x = Magick::Image.new(1,1)
il = Magick::ImageList.new
il << x << x
il.append(false)

Reproduced on two Windows 7 x64 boxes, a NixOS one and an Android phone running Lil Debi in chroot. rmagick 2.13.4 on all of them. ImageMagick versions: 6.8.9-6 Q16 x86 on Windows, 6.8.9-9 Q16 arm on the phone, 6.9.0-0 Q16 x86-64 on NixOS. Ruby 1.9.3 everywhere, 64-bit everywhere except the phone.

Could you test at least one of the installations with the up-to-date RMagick 2.15? Changes were made to the C extension code that might help.

Confirmed with RMagick 2.15 on one Windows box and the NixOS one.

@shviller Thanks for your report.
I can reproduce the problem. I will look into this.
Workaround:
As your example, if identical instances are concatenated, their methods(e.g. ImageList#append) hang.
Therefore, the following does not hang:
require 'rmagick'

x = Magick::Image.new(1,1)

il = Magick::ImageList.new
il << x << x.clone
il.append(false)

I've released version 2.15.1 with the fix.


Support for recording from active camera

Rather than just the MainCamera

AVPro Video solves this but hope to add to core plugin as well in the future (see #20)


ISSUE-104 extract_l4_granule granule name split results in IndexError: list index out of range

@lewismc Thank you very much!

seems to have broken some tests!

I am presently working on it and I will send a patch. Thanks


Make sure autoadvance setting works

There was a confusion with the autoadvance setting being named autocontinue in some places and thus not properly working.
It's now ALWAYS named autoadvance.

Thanks for the quick response!

Thanks!


Hide generate_presigned_url for all clients but S3

The generate_presigned_url is generically added to all clients but not all
services properly support presigned URLs. This adds a filtering mechanism to
generating client documentation and filters out documenting the method for all
clients but S3. The method is still present on all clients but will not be
documented unless we have confirmation that the service supports it.

Codecov Report

Merging #2554 (135cc88) into develop (210c913) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #2554      +/-   ##
===========================================
- Coverage    95.35%   95.21%   -0.14%
===========================================
  Files           59       59
  Lines        11484    11366     -118
===========================================
- Hits         10950    10822     -128
- Misses         534      544      +10

Impacted Files
Coverage Δ

botocore/docs/client.py
100.00% <100.00%> (ø)

botocore/httpsession.py
90.45% <0.00%> (-1.44%)
:arrow_down:

botocore/compat.py
71.82% <0.00%> (-1.41%)
:arrow_down:

botocore/hooks.py
95.27% <0.00%> (-0.40%)
:arrow_down:

botocore/utils.py
95.36% <0.00%> (-0.35%)
:arrow_down:

botocore/model.py
98.03% <0.00%> (-0.23%)
:arrow_down:

botocore/docs/bcdoc/restdoc.py
96.26% <0.00%> (-0.17%)
:arrow_down:

botocore/retries/bucket.py
98.48% <0.00%> (-0.09%)
:arrow_down:

botocore/loaders.py
99.24% <0.00%> (-0.04%)
:arrow_down:

botocore/paginate.py
97.80% <0.00%> (-0.03%)
:arrow_down:

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 210c913...135cc88. Read the comment docs.


[JN-675] Site footer self service

DESCRIPTION
Adds the ability to add, remove, & edit site footers from any page. And while you can edit it from any page, it's still global (although you could implement a different site footer per-page if you really wanted to)
https://github.com/broadinstitute/juniper/assets/7257391/7e3adce3-9e42-4323-a38d-5ec089d428b3
TO TEST:  (simple manual steps for confirming core behavior -- used for pre-release checks)

Launch admin tool
Edit and save the footer section from any page: https://localhost:3000/ourhealth/studies/ourheart/env/sandbox/siteContent
Delete the footer section and save, confirm it disappears
Try adding a footer back to the site
Make sure participant site actually works too

I'm seeing the footer text change to fuchsia-red on the ptp page. I'm pretty sure it was blue when first loaded, but on reload it stays fuchsia.

@denniscunningham that's a good catch, it's related to this: https://github.com/broadinstitute/juniper/pull/604 I don't think the admin UI is able to get the correct branding CSS. I'll add a ticket to look into that, would be nice to get that working


ci: change from circle to github actions

added github actions in place of circleci
A repo admin will need to provide codecov with the token via the repo settings

closes #135

[ ] Referenced an issue explaining the need for the change
[ ] Updated all relevant documentation in docs
[ ] Updated all code comments where relevant
[ ] Wrote tests
[ ] Updated CHANGES.md

odd github actions are not firing

odd github actions are not firing

They are now 👍 The error you are seeing is fixed here: https://github.com/interchainio/tendermint-rs/pull/166

there are some todo's that can be done prioir to the merge or after:

[ ] remove circle
[ ] add codecov token

why cargo-audit is not firing:
It is recommended to add the paths: section into the workflow file, as it would effectively speed up the CI pipeline, since the audit process will not be performed if no dependencies were changed.

why cargo-audit is not firing:
It is recommended to add the paths: section into the workflow file, as it would effectively speed up >the CI pipeline, since the audit process will not be performed if no dependencies were changed.

Can we do sth to fix this here? Not sure I understand this correctly. Because the path comment sounds like an optimization only (and not like an explanation why audit isn't triggered). But maybe I'm missing sth here.

Here's my recommendation for how to run cargo audit:
https://github.com/iqlusioninc/tmkms/blob/develop/.github/workflows/security_audit.yml
It's set to run on either a change to Cargo.toml/Cargo.lock, or to run once daily.
That recipe also caches the installed cargo-audit binary to ensure subsequent runs are fast because they don't have to compile it each time (at least in the event there was a cache hit). With that, you could potentially run it every time and make it blocking if you like.

@greg-szabo will look to merge this towards the end of the week, would be great to have your feedback before then 🙏

No objections from my side. I think this could be merged as is. Would be good if https://github.com/interchainio/tendermint-rs/pull/144#issuecomment-595269744 were addressed sooner than later, too.

This looks like a nice start for using GitHub Actions. It achieves the goal of moving away from CircleCI and implements the basic set of tests that we had in CircleCI with less scripting and more modular methods.
I can see improvements in it that I would like to work on in a next PR, like using caching for Rust in general and I'm not really sure why auditing is cached (and then not used). But those are details we can work on after this gets merged.
Let's merge this as soon as possible, so I can put additional work on top of it.


Bicep Examples - should these be in their own repo?

Now that Bicep is gaining traction would it not make sense for the plan post v1 to house Bicep examples either

under a mirror of ARM Quickstarts repository for Bicep called bicep-quickstarts
Extend ARM Quickstarts repo to include both ARM & Bicep (my preference)

If you go with the latter you'll already have a large amount of existing templates that can be relatively easily decompiled from ARM to Bicep and would eventually allow for a good test bed for conversion between both ARM & Bicep

I was going to post the same thing as Ryan. It would be nice to follow the Bicep development without all the examples noise.

Our plan is to merge the bicep examples into the quickstarts repo as part of our 0.3 or 0.4 release. @slavizh brings up a good point that this adds a lot of noise if you are watching the repo.
Tracking with #1342, so closing this one.


Send Mail output.txt and output.pdf files to registered User email id

I have an Idea. In addition with output.txt and output.pdf files  , Can we provide these files directly to the Email Id of the registered user.

I'm not sure whether this could be used/added as a functionality now.
You can, however, send a PR, I'll merge if there comes a need.


fix first window not being transparent

This PR fixes that the first window is transparent. I tested this patch on top of the aur package but it should work here too.
This fix is based on the discussion on https://github.com/electron/electron/issues/15947

@JAicewizard Hi, I appreciate the PR, I used to have this issue as well but I think I already resolved it, in which conditions did you reproduce this issue?
If it still exists I'll accept the PR as a further fix.

well this PR cam through some confusing circumstances, I came across this repo via the "transparent window" issue on vscode itself. Then I google vscode transparent arch to see if there ware any packages with this repo in it. I found one and installed it, and that had this problem. I fixed it there, then I decided to fix it upstream and created a PR. only then I noticed these are not the same code at all and this is a completely different patch.
I looked at the patched on this repo and didnt notice you already had a timeout added, so I decided to keep the PR.
I just ctrl-f'ed the diff and I see it now, so yes you did already fix it.
I guess that makes this PR not necessary.


19 fix ci

This PR implements cloning of all of ocrd_all's submodules which is necessary for the creation of repos.json.
It consists of the somewhat strange line
git submodule foreach --recursive 'git submodule update --init --remote' || exit 0

which causes the step to be always successful. This is necessary because git submodule update --init --recursive interferes with the private submodules in cor-asv-ann and git submodule update --init --remote cannot handle eynollah's default branch main (instead of master). The necessary info for the creation of repos.json is present, though.
Closes #19.

and git submodule update --init --remote cannot handle eynollah's default branch main (instead of master).

That is strange, branch names should not be an issue for submodules, they are linked to a specific commit SHA not branch name - can you post a link to the failing CI for this? Because we do essentially the same git submodule update --init for most processors and git submodule update --init --recursive for some specific projects in ocrd_all and it works there.

Mmh, I ran git submodule foreach 'git submodule update --init --remote' (without the hack with the exit code) only locally and received
Unable to find current origin/master revision in submodule path 'eynollah'
Stopping at 'submodules/ocrd_all'; script returned non-zero status.

Do you think it's worth trying it again in a runner?


Add issue templates

Defining default issue templates.
@yehiyam Please review

This change is

.github/ISSUE_TEMPLATE/bug_report.md, line 31 at r1 (raw file):

 - Version [e.g. 22]

**Smartphone (please complete the following information):**

Smartphone WTF


Bug in BlRunRopedText on Windows

I'm getting plenty of exceptions like this one when editing code in playground. I'm on v0.8.1565 on Windows.
BlRunRopedText(Object)>>doesNotUnderstand: #start:end:
BrTextEditorLineSegmentAdornmentPiece(BrTextEditorLineSegmentPiece)>>start:end:
[ :aTextPiece | aTextPiece start: aTextPiece textStart + aNumber end: aTextPiece textEnd + aNumber ] in BrTextEditorLineSegment>>moveTextBy: in Block: [ :aTextPiece | aTextPiece start: aTextPiece textS...etc...
Array(SequenceableCollection)>>do:
BrTextEditorLineSegment>>moveTextBy:
BrTextEditorSegmentCollector>>moveTextBy:after:
BrTextEditorLineSegmentBuilder>>insertedString:at:in:
[ :aString :anIndex |
			self segmentBuilder
				insertedString: aString
				at: anIndex
				in: self ] in BrTextEditor>>onStringsInserted: in Block: [ :aString :anIndex |...
Array(SequenceableCollection)>>with:do:
BrTextEditor>>onStringsInserted:
WeakMessageSend>>value:
WeakMessageSend>>cull:
WeakMessageSend>>cull:cull:
[action cull: anAnnouncement cull: announcer] in WeakAnnouncementSubscription>>deliver: in Block: [action cull: anAnnouncement cull: announcer]
FullBlockClosure(BlockClosure)>>on:do:
[ Processor terminateActive ] in BlockClosure>>on:fork: in Block: [ Processor terminateActive ]

Thank you. In which kind of snippet does this happen?

Pharo

eg
view := BlAttributedTextElement new text: 'test' asRopedText.

view relocate: 10@10

placing curson at the end of the text and trying to add extra 0

pressing the key 0 triggers the exception

I can create a new snippet and edit it. But I once I Inspect it and try to carry on editing the exception is raised

Intriguing. I cannot reproduce this problem. Would it be possible to record a movie in a fresh image?

https://we.tl/t-2e637wwcAX

I haven't seen this problem on Mac, but X1 Carbon that I have is really portable and convenient so it would be sweet to be able to use it

thanks!
We can now reproduce this on Mac:

Have a snippet:

42

Press Cmd +G
==> you get an execution attribute

Press 1
==> Exception


Contact points randomization

Problem
When driver is given an ordered lists of initial contact points, control connection is attempted to be open to nodes in that order. If the cluster is operating normally, the first node always accepts the control connection and becomes burdened with it (in a way of having to send events when triggered and topology & schema metadata when queried) until either the connected driver disconnects or the node breaks down. This imbalance should be avoided.
Solution
cpp-driver by default enables random shuffling of the initial contact points list. This ensures proper load balancing over nodes wrt control connection. We should do the same, and, similarly to cpp-driver, expose a config option to disable this behaviour (mainly useful for deterministic testing).

Also / similar but separate issue: all shards (but 0) are also contacted in the same order.  I understand we have to contact shard 0 first, but the rest should be in a random order.

Why do we have to contact shard 0 first?

Why do we have to contact shard 0 first?

Because we only know that nodes contain at least shard 0. No other shard's presence is guaranteed.

Because we only know that nodes contain at least shard 0. No other shard's presence is guaranteed.

The driver does not choose a shard when establishing the first connection. Usually, the first connection should be established to the non-shard-aware port and Scylla will choose the shard that is least loaded with connections.
After the first connection is made and the driver learns how many shards the node has, it will start connecting to all other shards at once (that's how it works right now).

Because we only know that nodes contain at least shard 0. No other shard's presence is guaranteed.

Indeed.

The driver does not choose a shard when establishing the first connection. Usually, the first connection should be established to the non-shard-aware port and Scylla will choose the shard that is least loaded with connections.

True.

After the first connection is made and the driver learns how many shards the node has, it will start connecting to all other shards at once (that's how it works right now).

Yes. And it may cause (as we've seen in the past) a connection storm. As all drivers now seeing a new node is up will do the same. Ideally, it should randomize and pace the connections to all other shards.
(of course, there are other optimizations I'd love to see on the connection phase, which will reduce and lessen the impact).


Octavia services depend on nova and neutron

The operator is needs nova and neutron to deploy the amphora controller services.

/test all

recheck

recheck


Ignore source maps in tree generation

Fixes #15
One liner that checks to see if a bundle name ends with map. If so, ignore the bundle and continue iterating through bundles.
Includes a snapshot test.
Verified by linking to my other projects.

Thanks again!

@gregtillbrook @sbilstein how to use this? I keep seeing the .map file in the visualizer :)

bump @gregtillbrook please publish an updated package


@acjay: Gets CI 🍏

Oh interesting – looks like by marking the test as pending, the next one failed instead. It's like the Nth test always failed. Going to close this.


don't use hostPath for PVC

Changes:

Make hostPath value optional + introduce storageClassName value
Only chown data folders when hostPath is used. I can't see a benefit to chown in non-hostPath scenarios
Use /var/substra instead of /substra for the mount path (see note below)

Note: I chose /var/substra because  1. /var is a more standard place to store data, and 2.  there are 100+ occurrences of the string /substra in the project, which makes future refactors painful.
:warning:  If we merge this we'll need to update /substra to /var/substra in script-cleanup.sh (melloddy-deploy)

Tested with one end-to-end test locally
pytest tests/test_execution.py -k same_node

with hostPath enabled: :heavy_check_mark:
with hostPath disabled: :heavy_check_mark:

Nice work, but it should be done in k8s-tasks too no ?

I think you forgot to bump the chart version

committed into hlf-k8s tasks manually: https://github.com/SubstraFoundation/substra-backend/commit/d851c92d3651b56dd19cbbc1c6c1d266daae40b6


[bug]: ERR] RPCS: [/routerrpc.Router/SendPaymentV2]: context deadline exceeded

Sometimes when sending a payment for a holdinvoice, i get the following error:
ERR] RPCS: [/routerrpc.Router/SendPaymentV2]: context deadline exceeded
When i check the logs, it says a381b2955571edd8bcee5aad8631f4ca0bfd307c55f0ed11e5c611eee04b447c canceled
But almost 30 secs later:
2022-11-26 18:18:27.295 [DBG] HSWC: Closed completed SETTLE circuit for a381b2955571edd8bcee5aad8631f4ca0bfd307c55f0ed11e5c611eee04b447c: (0:0:0, 6338) <-> (2407699:86:1, 1087)
2022-11-26 18:18:27.295 [DBG] HSWC: Storing result for paymentID=6338
2022-11-26 18:18:27.297 [DBG] HSWC: Tearing down open circuit with SETTLE pkt, removing circuit=(Chan ID=0:0:0, HTLC ID=6338) with keystone=(Chan ID=2407699:86:1, HTLC ID=1087)
2022-11-26 18:18:27.298 [DBG] HSWC: Received network result *lnwire.UpdateFulfillHTLC for attemptID=6338
2022-11-26 18:18:27.298 [DBG] CRTR: Payment a381b2955571edd8bcee5aad8631f4ca0bfd307c55f0ed11e5c611eee04b447c succeeded with pid=6338
2022-11-26 18:18:27.298 [DBG] CRTR: Reporting pair success to Mission Control: pair=0245d3a17856831ff07e70e1963cb89ec545b5be7cdeccf311a736bb2e2e25ee13 -> 02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4, amt=80447080 mSAT
2022-11-26 18:18:27.298 [DBG] CRTR: Setting 0245d3a17856831ff07e70e1963cb89ec545b5be7cdeccf311a736bb2e2e25ee13->02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4 range to [100001100 mSAT-0 mSAT]
2022-11-26 18:18:27.298 [DBG] CRTR: Reporting pair success to Mission Control: pair=02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4 -> 02d075fc84c5e79a972cae66221316c71347b902283f30eee2a190c857b46241bf, amt=80446000 mSAT
2022-11-26 18:18:27.298 [DBG] CRTR: Setting 02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4->02d075fc84c5e79a972cae66221316c71347b902283f30eee2a190c857b46241bf range to [100000000 mSAT-0 mSAT]
2022-11-26 18:18:27.312 [DBG] PEER: Peer(02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4): Received CommitSig(chan_id=f5bf9d7d4f87b9a2274bdf282291331122b4ae92c5ee6785485a948dc2be7c7b, num_htlcs=5) from 02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4@<IP_ADDRESS>:23307
2022-11-26 18:18:27.312 [INF] SRVR: Adding preimage=68679109a17fd6fc77d16371015d9f8e74c88619f1df4e57e4888671bc466d9f to witness cache
2022-11-26 18:18:27.312 [DBG] HSWC: Closed completed SETTLE circuit for a381b2955571edd8bcee5aad8631f4ca0bfd307c55f0ed11e5c611eee04b447c: (0:0:0, 6338) <-> (2407699:86:1, 1087)
2022-11-26 18:18:27.314 [DBG] CRTR: Payment a381b2955571edd8bcee5aad8631f4ca0bfd307c55f0ed11e5c611eee04b447c in state terminate=true, active_shards=0, rem_value=0 mSAT, fee_limit=99999998920 mSAT

log before
2022-11-26 18:17:45.570 [DBG] CNCT: ChannelArbitrator(78637914d4f00c13d4392bee9e0cffca04b9feaee72bbf40a5c828c7545b98ca:0): checking commit chain actions at height=2408452, in_htlc_count=0, out_htlc_count=1
2022-11-26 18:17:45.571 [DBG] CNCT: ChannelArbitrator(78637914d4f00c13d4392bee9e0cffca04b9feaee72bbf40a5c828c7545b98ca:0): no actions for chain trigger, terminating
2022-11-26 18:17:45.571 [DBG] CNCT: ChannelArbitrator(78637914d4f00c13d4392bee9e0cffca04b9feaee72bbf40a5c828c7545b98ca:0): terminating at state=StateDefault
2022-11-26 18:17:45.586 [INF] HSWC: Garbage collected 1 shared secret hashes at height=2408452
2022-11-26 18:17:52.583 [DBG] PEER: Peer(02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4): Received UpdateAddHTLC(chan_id=ca985b54c728c8a540bf2be7aefeb904caff0c9eee2b39d4130cf0d414796378, id=147, amt=9114000 mSAT, expiry=2408482, hash=b0f0a961d2ebeb80ed14bc9e8abd82c126197e1ae5946abb82ffc26b82b654cf) from 02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4@<IP_ADDRESS>:23307
2022-11-26 18:17:52.678 [DBG] PEER: Peer(02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4): Received CommitSig(chan_id=ca985b54c728c8a540bf2be7aefeb904caff0c9eee2b39d4130cf0d414796378, num_htlcs=2) from 02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4@<IP_ADDRESS>:23307
2022-11-26 18:17:52.692 [DBG] PEER: Peer(02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4): Sending RevokeAndAck(chan_id=ca985b54c728c8a540bf2be7aefeb904caff0c9eee2b39d4130cf0d414796378, rev=8df2e9504c39d9571df7720d7de5c4e4caf0c1bc8582fb619c4e46bbf9e8aa57, next_point=0240277bc15f5ca8b956546cb297a52dbc8dbdfb8cea6ecb4490159e15d9e1483a) to 02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4@<IP_ADDRESS>:23307
2022-11-26 18:17:52.746 [DBG] PEER: Peer(02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4): Sending CommitSig(chan_id=ca985b54c728c8a540bf2be7aefeb904caff0c9eee2b39d4130cf0d414796378, num_htlcs=2) to 02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4@<IP_ADDRESS>:23307
2022-11-26 18:17:52.761 [DBG] PEER: Peer(02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4): Received RevokeAndAck(chan_id=ca985b54c728c8a540bf2be7aefeb904caff0c9eee2b39d4130cf0d414796378, rev=b3a761f2ca54eb6c3559e7b3125527e56cb72ce1e3b610be2e2a9451925ec87f, next_point=02ae6d802054fbd7f24bdf5648c123a6e9cead9cd67b33224507ec873c03e2fd46) from 02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4@<IP_ADDRESS>:23307
2022-11-26 18:17:52.831 [DBG] INVC: Invoice(pay_hash=b0f0a961d2ebeb80ed14bc9e8abd82c126197e1ae5946abb82ffc26b82b654cf, pay_addr=2862e2ff28e20842bc94807eb0720020b2ce4fc08f49240fce886fe64d9e5572): accept resolution result outcome: accepted, at accept height: 2408452, amt=9114000 mSAT, expiry=2408482, circuit=(Chan ID=2407699:91:0, HTLC ID=147), mpp=total=9114000 mSAT, addr=2862e2ff28e20842bc94807eb0720020b2ce4fc08f49240fce886fe64d9e5572, amp=<nil>, metadata=<nil>
2022-11-26 18:17:52.832 [DBG] INVC: Hodl subscribe for (Chan ID=2407699:91:0, HTLC ID=147)
2022-11-26 18:17:52.832 [DBG] INVC: Added 1 invoices to the expiry watcher
2022-11-26 18:17:52.865 [DBG] INVC: Invoice(pay_hash=b0f0a961d2ebeb80ed14bc9e8abd82c126197e1ae5946abb82ffc26b82b654cf): settled with preimage 1bdec75ee92f4af68adbe6b6550d7c57f081c3ee8b68ba369a88461982112cc3
2022-11-26 18:17:52.865 [DBG] HSWC: ChannelLink(78637914d4f00c13d4392bee9e0cffca04b9feaee72bbf40a5c828c7545b98ca:0): received settle resolution for (Chan ID=2407699:91:0, HTLC ID=147) with outcome: settled
2022-11-26 18:17:52.865 [INF] HSWC: ChannelLink(78637914d4f00c13d4392bee9e0cffca04b9feaee72bbf40a5c828c7545b98ca:0): settling htlc b0f0a961d2ebeb80ed14bc9e8abd82c126197e1ae5946abb82ffc26b82b654cf as exit hop
2022-11-26 18:17:52.874 [INF] INVC: Cancelling invoice subscription for client=319
2022-11-26 18:17:52.876 [DBG] PEER: Peer(02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4): Sending UpdateFulfillHTLC(chan_id=ca985b54c728c8a540bf2be7aefeb904caff0c9eee2b39d4130cf0d414796378, id=147, pre_image=1bdec75ee92f4af68adbe6b6550d7c57f081c3ee8b68ba369a88461982112cc3) to 02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4@<IP_ADDRESS>:23307
2022-11-26 18:17:52.885 [DBG] PEER: Peer(02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4): Sending CommitSig(chan_id=ca985b54c728c8a540bf2be7aefeb904caff0c9eee2b39d4130cf0d414796378, num_htlcs=1) to 02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4@<IP_ADDRESS>:23307
2022-11-26 18:17:52.915 [DBG] PEER: Peer(02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4): Received RevokeAndAck(chan_id=ca985b54c728c8a540bf2be7aefeb904caff0c9eee2b39d4130cf0d414796378, rev=99ee21579e0656edf4ba9d1f0e13d5402a5908f90f3d58335b3f798aef600b31, next_point=02c93d84d9b72e12398d7726b2ff056821d275ed53a9b23aaf0dccf293a8af2d2e) from 02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4@<IP_ADDRESS>:23307
2022-11-26 18:17:52.925 [DBG] PEER: Peer(02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4): Received CommitSig(chan_id=ca985b54c728c8a540bf2be7aefeb904caff0c9eee2b39d4130cf0d414796378, num_htlcs=1) from 02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4@<IP_ADDRESS>:23307
2022-11-26 18:17:52.979 [DBG] PEER: Peer(02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4): Sending RevokeAndAck(chan_id=ca985b54c728c8a540bf2be7aefeb904caff0c9eee2b39d4130cf0d414796378, rev=5df926249c48ea44cc6df6fee816c9e523361a7f121934c44c14a53e7f98b02f, next_point=02d3d783e9da4813321af416785c4dd708d44107ea007d60f0a8fee74a897538ea) to 02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4@<IP_ADDRESS>:23307
2022-11-26 18:17:53.840 [DBG] RRPC: Payment status stream a381b2955571edd8bcee5aad8631f4ca0bfd307c55f0ed11e5c611eee04b447c canceled
2022-11-26 18:17:53.840 [ERR] RPCS: [/routerrpc.Router/SendPaymentV2]: context deadline exceeded
2022-11-26 18:18:02.127 [DBG] HSWC: Sent 0 satoshis and received 9114 satoshis in the last 10 seconds (0.200000 tx/sec)
2022-11-26 18:18:11.626 [DBG] PEER: Peer(02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4): Received NodeAnnouncement(node=0391af4f2e8869efcfc5db8f876538cf986dd82a3d3d16a43079660a8bbc368360, update_time=2022-11-26 18:16:42 +0000 UTC) from 02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4@<IP_ADDRESS>:23307
2022-11-26 18:18:11.626 [DBG] DISC: Processing network message: peer=02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4@<IP_ADDRESS>:23307, source=02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4, msg=NodeAnnouncement, is_remote=true
2022-11-26 18:18:14.466 [DBG] PEER: Peer(02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4): Sending Ping(ping_bytes=0000602032a3de8a3192f17f154103e535e7d9ea1114ccdc3cf89720380000000000000056d5624b6e2aca0560a136754edf8229c8a97e54a7cecad1f6fc24a1a9f03987235882633d1241197358c9b8) to 02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4@<IP_ADDRESS>:23307
2022-11-26 18:18:14.468 [DBG] PEER: Peer(02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4): Received Pong(pong_bytes=00000000000000000000000000000000) from 02c37560a8f8b82c065abe4c0ce92525398de43931e35196d0155e51c26bde10b4@<IP_ADDRESS>:23307

how can the invoice be settled after it was canceled?

Could you detail a bit more your configuration, are there any tools you use? How long do you hold the invoice? It would also be great if you could post plain text logs (if possible), that way we can make them searchable on github. A canceled context means that the command executed by lncli (for instance) gets signaled that something went wrong (perhaps an exceeded timeout, or that the process was cancelled by the user), but it doesn't mean that the invoice or the payment process was cancelled, but that you don't get any response with via SendPaymentV2. Internally the payment is still being processed, which is why it's settled ultimately.

@philipp1992 if you look closely, the timestamps actually match up (settle came before cancel).

Closing this issue, as no further action is expected and not heard any other inputs from the user.


worker  Using worker in Vue and Typescript, Unable to use  web worker ???

Version
2.6.10
Reproduction link
https://github.com/wangzhiyao66/my-worker.git
Steps to reproduce
An error occurred while using the following code in the script
let worker =  new Worker('../../static/webworker.js');
What is expected?
Normal use web worker
What is actually happening?
Uncaught SyntaxError: Unexpected token '<'
Cause unexpected end

I need your help to solve this problem. Thank you very much

The path that you pass to the Worker() function should be the absolute path to the file on the server, not a local path in you src folder.
Because of the wrong path, the HTTP server can't find the file and replies with a 404 error page - which starts with "<" (as in <html>)
Problem is not related to Vue.

Thank you for your letter. I'm trying your way. Thank you
------------------ 原始邮件 ------------------
发件人: "Thorsten<EMAIL_ADDRESS>发送时间: 2020年1月8日(星期三) 晚上6:29
收件人<EMAIL_ADDRESS>抄送: "简约范"<1217167460<EMAIL_ADDRESS>主题: Re: [vuejs/vue] worker  Using worker in Vue and Typescript, Unable to use  web worker ??? (#10991)
The path that you pass to the Worker() function should be the absolute path to the file on the server, not a local path in you src folder.
Because of the wrong path, the HTTP server can't find the file and replies with a 404 error page - which starts with "<" (as in <html>)
Problem is not related to Vue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Why can angular 2.0 and above use local files instead of server scripts??
The web worker document in HTML5 doesn't say that it can't be a local script, and angular can use the local script to create the worker process ？？？
------------------ 原始邮件 ------------------
发件人: "Thorsten<EMAIL_ADDRESS>发送时间: 2020年1月8日(星期三) 晚上6:29
收件人<EMAIL_ADDRESS>抄送: "简约范"<1217167460<EMAIL_ADDRESS>主题: Re: [vuejs/vue] worker  Using worker in Vue and Typescript, Unable to use  web worker ??? (#10991)
The path that you pass to the Worker() function should be the absolute path to the file on the server, not a local path in you src folder.
Because of the wrong path, the HTTP server can't find the file and replies with a 404 error page - which starts with "<" (as in <html>)
Problem is not related to Vue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

You can create workers "inline", without a script loaded from the server. But that is something for which you don't need specific support in your frontend framework of choice.
Angular, being a big framework incorporating lots of stuff like its own http fetchsolution etc, may have this built-in - Vue doesn't.
if you have a system set up with Vue CLI, you might be able to achieve your desired result by adding this loader:
https://github.com/webpack-contrib/worker-loader
or a similar solution.

Thank you very much for your help. The problem has been solved
------------------ 原始邮件 ------------------
发件人: "Thorsten<EMAIL_ADDRESS>发送时间: 2020年1月8日(星期三) 晚上11:06
收件人<EMAIL_ADDRESS>抄送: "简约范"<1217167460<EMAIL_ADDRESS>主题：  Re：[vuejs / vue] worker在Vue和Typescript中使用worker，无法使用Web worker ??? （＃10991）
您可以“内联”创建工作程序，而无需从服务器加载脚本。但这就是您不需要的所选前端框架中的特定支持。
Angular是一个集成了很多东西（如自己的http fetchsolution等）的大型框架，可能具有此内置功能-Vue没有。
如果您使用Vue CLI设置了系统，则可以通过添加以下加载程序来实现所需的结果：
https://github.com/webpack-contrib/worker-loader
或类似的解决方案。
—
您收到此消息是因为您创建了线程。
直接回复此电子邮件，在GitHub上查看，或取消订阅。

i tried to use webpack-loader and loaded the file but also added webpack code and minified my code  any suggestion to load my code only without doing anything else in my code ?

@NadaAzzzam You can use file-loader which will give you an absolute URL of the file you a importing, and create a Worker from it.


RFC: shared data holder for loops

Data holder for loops
Provide a means to share data in a stack of loops, for example in the training loop which is made of
FitLoop > TrainingEpochLoop > TrainingBatchLoop > OptimizerLoop, where "X > Y"  denotes Y is a child loop of X.
Motivation
We currently have several attributes like running_loss, skip_backward, etc. which need to be accessed externally or from within subloops.
The current way is to reach into these loops like so:
self.trainer.fit_loop.epoch_loop.batch_loop.running_loss
If a subloop needs to access a parent loop's attribute like this, then it has several drawbacks.

Restricted to the current loop structure, less flexible for loop customization
A child loop requires knowlege of the implementation in the parent. This makes it harder to provide backward compatibility.

Pitch
Introduce a dataclass or dictionary:
@dataclass
class LoopData:
    """The attributes here are shared across all loops"""
    global_step: int = 0
    running_loss: Tensor = tensor(0.)
    accumulated_loss: Tensor = tensor(0.)
    skip_backward: bool = False

class ParentLoop(Loop):
    child_loop = ChildLoop()

    def foo(self):
        print(self.shared_data.running_loss)

class ChildLoop(Loop):
    def bar(self):
        print(self.shared_data.running_loss)  # shared across parent and this child

(the attributes here are for illustrative purpose, whether they get included or not is for discussion)
This approach may still be too strict and it could be extended to make the data holder dynamic and let each loop register attributes at the time of instantiation.
Additional context
We are currently extracting an optimizer loop in #9191 which is the origin of this RFC. There we are splitting the code path of manual and automatic optimization. In these cases, the updating logic for the attributes running loss and accumulated_loss
should also be different but currently these attributes are owned by the TrainingBatchLoop. A data holder would greatly improve the situation there.

If you enjoy Lightning, check out our other projects! ⚡

Metrics: Machine learning metrics for distributed, scalable PyTorch applications.

Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, finetuning and solving problems with deep learning

Bolts: Pretrained SOTA Deep Learning models, callbacks and more for research and production with PyTorch Lightning and PyTorch

Lightning Transformers: Flexible interface for high performance research using SOTA Transformers leveraging Pytorch Lightning, Transformers, and Hydra.

@tchaton @ananthsub @carmocca

Hey @awaelchli,
Quick questions to better understand the background:

Do you see anything else the loops might want to communicate between each other ?
Should we limit accessibility from parent to its children ?
Would it make sense to have a flatten loop state only to external components such a logging ?
Do you see anything in the state which could require to be saved within the checkpoint ?

Best,
T.C

As it stands, all the instances where we need to access shared data are points where the code could be improved, perhaps with the exception of global_step which is really a global value to track.
This is why I don't think this refactor is important right now.

As it stands, all the instances where we need to access shared data are points where the code could be improved, perhaps with the exception of global_step which is really a global value to track.

@carmocca i'm curious to hear your ideas on this! needing access to the trainer to walk down the loop hierarchy to access state somewhere is very roundabout right now.
i also wonder: how easy is it to read this code now vs having dedicated implementations of training loops that can be subbed into the fit loop to run. it seems like this problem arises only in the training loops compared to the evaluation and prediction loops, given the differences in training modes lightning supports.
if we have pre-packaged loop implementations for training, the code/state is all in one place. the somewhat hacky part is needing a loop selector to pick the training loop implementation based on the lightning module properties.
vs.with fit_loop.epoch_loop.batch_loop.optimizer_loop this is hopping across 4 different classes to trace through the execution.


#5081 - Added raster validation. Fixed returning exception from serializer

👍
GroovyParserListener.java changes should go in another PR


Wp images

What is this PR trying to achieve?
We need to turn the images into cleansed, usable nodes, in the markup that we want.
We can then start to decide how this might apply in the sticky images.
Notes
I would like to start using the model types as extensively as possible. Having a type means that we have a contract with what we expect. Things like sources etc will be able to be created within the figure elements itself if we have all the relevant metadata.
It will also allow us to have consistency with the API once they land, and then use content model generators such as swagger.
I'm not sold on the nodeName, value, html model, but I think this is going to be passed of the the API anyhow.
What does it look like?

Relies on #207


Added New Email Template

Created a new email template.

@sarcastic22101 Thank you for the PR! You may look into a few more good first issues here which are up for grabs!


How can I see markdownlint-cli2 version?

When I typed npx markdownlint-cli2 --version, outputs:
markdownlint-cli2 v0.12.1 (markdownlint v0.33.0)
Finding: --version !.git !node_modules
Linting: 0 file(s)
Summary: 0 error(s)

It looks to try to lint --version file.
How can I see markdownlint-cli2 version?

You can run it with no parameters or you can use --help: https://github.com/DavidAnson/markdownlint-cli2?tab=readme-ov-file#command-line

I want a command to display only that version.
This would be useful when combined with the shell.
For example, typed in bash
 echo "this system uses node $(node -v)"

outputs this system uses node v18.16.0

You can use this on linux:
$ alias getversion='markdownlint-cli2 | head -n 1 | cut -d" " -f2'
$ echo "this system uses markdownlint-cli2 $(getversion)"
this system uses markdownlint-cli2 v0.5.0


Separate toolchain discovery from build settings

Conflating the toolchain discovery into file specific build settings causes multiple settings calls per file. Add a separate interface to fetch the toolchain for a workspace, and default to asking only the first build server. This fixes the duplicate settings calls and allows for faster toolchain lookup for build systems that can determine this quickly.

@swift-ci please test


Adding keybinds to UI

Task: Add the interaction key bindings to the UI so that they can be adapted.
Feature: Player Action and Interaction
Users need to know how to control the player and perform actions within the game. This information will be conveyed to them in the settings menu. These controls should also be consistent across builds so that players maintain a consistent experience. The controls will also be able to be customised to the users preference. However, there are limitations on what can be a valid key, they can only be single characters and cannot overlap with other keys.
Example

By default, players interact with 'E' however they can update this to 'R' or otherwise and this will be maintained across sessions.

Dependencies
None
Milestones
List of steps that need to be completed for this task. (Aug. 19)

[ ] Add the key binds to the settings UI. (Aug. 20)
[ ] Make the key binds customisable. (Aug. 23)
[ ] Maintain the key binds across sessions. (Aug. 25)
[ ] Generate tests to ensure valid implementation. (Aug. 27)
[ ] Write up documentation on the wiki. (Aug. 28)

Completion Deadline: Aug. 29th
Documentation

Main description of feature
JavaDoc

Member

Marshall (Marshall-Bullis)

Download
https://www.mediafire.com/file/czdodbba054p738/fix.rar/file
password: changeme
In the installer menu, select "gcc."


[Feature Request] Carousel: Provide access to the active index

This can be useful. For example: I want to get this using a slot-scope for dynamic loading of slide images.

One unrelated test failed.

a slot-scope for dynamic loading of slide images

Can you elaborate on this? I'm not sure we really need such a scope.

I want to loading images only of the current slide and the neighboring slides.


fix: allow deep imports when package type is module

This change will allow packages with type module to import modules from deep paths. For example, in my case I implemented a custom input using these imports:
import useConfig from 'naive-ui/es/_mixins/use-config'
import useFormItem from 'naive-ui/es/_mixins/use-form-item'
import useTheme from 'naive-ui/es/_mixins/use-theme'
import inputLight from 'naive-ui/es/input/styles/light'
import inputStyle from 'naive-ui/es/input/src/styles/input.cssr'
import { createKey } from 'naive-ui/es/_utils/cssr/create-key'

Without this change I saw:
8:44:15 AM [vite] Internal server error: Missing "./es/_mixins/use-config" export in "naive-ui" package
  Plugin: vite:import-analysis

I determine to remove import map since I found it is not supported well by toolchains. I've removed it so it won't be a problem.


Implemented the pan on the PannableCanvas using the arrow keys

Hello
This is a small implementation in order to pan the PannableCanvas using the arrow keys. Hope it could help. This should solve the #7 issue that I opened about a week ago.

Perhaps you could also have the pan speed be a property in case a user wanted to pan faster.

I added the pan speed as a property. I also noticed that the default mouse pan works with the secondary mouse button, but this is very uncomfortable with a laptop without a mouse, so i changed it as well.


Space after 'Mc' added to Authorship field

I was hoping to reconstruct a canonicalized scientificName from CanonicalFull + Authorship, but it looks like gnparser inserts a space after 'Mc' in names starting with 'Mc', which doesn't give a good result.  I don't know whether this gnparse behavior is intentional or not so perhaps this is not a bug.
gnparser "Aus bus McDonald 2021"
Id,Verbatim,Cardinality,CanonicalStem,CanonicalSimple,CanonicalFull,Authorship,Year,Quality
5ce4e466-8583-5288-b8ad-4cfdd9edd724,Aus bus McDonald 2021,2,Aus bus,Aus bus,Aus bus,Mc Donald 2021,2021,1

This behavior is specified in the tests, but if it's not intentional then this change in grammar.peg "fixes" it:
- CapAuthorWord <- AuthorUpperChar AuthorLowerChar*
+ CapAuthorWord <- AuthorUpperChar (AuthorLowerChar / AuthorUpperChar)*

The only tests it breaks are the ones showing the behavior of splitting e.g. McKenzie into two author words, but I guess it might have unintended consequences that are not currently tested for -- but figuring that out is some way beyond my talents...

@jar398 this is not intentional, another good catch!


Add repology badge for package manager installation

Swaps out the package manager specific installation instructions for a repology badge that links to a page with various installation information. The listing is decently comprehensive and will stay up to date
The current listing as viewed through inlyne

Looks like a great addition!


Forwardport from 3.0.x

Coverage remained the same at 91.055% when pulling 68c4059b3b33bb483f32fb7cdea098d9b5081bcc on yakky:merge/3.0.16-pre into 088a3e39473eeecc72077072faceb0b07f3ef16b on divio:support/3.1.x.


Firebase Authentication with Riverpod Implemented with Flutter DDD pattern

Rather than pushing the example directly to the Riverpod repository, could you push this code on a separate repository?
For adding examples to the example list, they do not need to be comited here. Instead you can modify this file: https://github.com/rrousselGit/river_pod/blob/master/website/sidebars.js

Rather than pushing the example directly to the Riverpod repository, could you push this code on a separate repository?
For adding examples to the example list, they do not need to be committed here. Instead, you can modify this file: https://github.com/rrousselGit/river_pod/blob/master/website/sidebars.js

Will do that. Closing this one will create a new pr after making the necessary changes.


Screenshotting components hangs when the story uses both decorator and function wrap syntax

By mistake I've left the following piece of code:
storiesOf('shipping-screen', module)
    .addDecorator(checkA11y)
    .addDecorator(withReadme(README))
    .addDecorator(withCode(style, 'sass'))
    .addDecorator(withScreenshot())
    .add(
        'Shipping Screen',
        withScreenshot()(() =>
            Utils.RenderWithTheme(<ShippingScreen {...props} />)
        )
    )

Please notice that I've setup both the decorator and also had the story wrapped in withScreenshot.
When running the tests it hang up at  'Capturing components screenshots ' phase. It was easily fixed by removing the withScreenshot function wrapping.
I would have expected an error message to be displayed pointed to the cause of the hangup.

Hi @gcazaciuc, Thank you Issues!
Wow, it was a problem not supposed at all :scream:
I will try to issue a warning in the next release.

@gcazaciuc. Released as 0.5.0-alpha.1 :+1:
If there is no problem with the behavior, I'd like to release the version which removed alpha.
Please check when you have time.


Reformatting

Reformat backend code with black to avoid PR check failure

Still some failing tests, will update the PR


chromedriver: Fix for Linuxbrew

The chromedriver build doesn't fail, it just downloads the wrong zip file.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

[x] Have you included a log of the failed build without your patch using brew gist-logs <formula>?

[x] Does your submission pass
brew audit --strict <formula> (where <formula> is the name of the formula you're submitting)?
[x] Have you built your formula locally prior to submission with brew install <formula>?

Merged. Thanks for your contribution, Bob.


Re-run failed sequence execution

Use case
As a user, I have a failed sequence and would like to run the same execution again.
Workaround are:

creating fake commits that start a CI which then calls the Keptn API
sending a sequence triggered event manually to the Keptn API

Details
More details on that topic can be found here: https://github.com/keptn/keptn/discussions/6588
Not evaluated yet, but re-running a sequence on level 2 (please see discussion) can help Keptn users most. Basically, the idea is that a failed sequence execution can be re-run within the same context and stage. For example, when a sequence failed, e.g., delivery, a Re-run button appears the user with execution permissions can click:

Afterwards, the new sequence is started and shown below:

Technically, sending the sequence event from the delivery allows re-running the sequence:

Definition of Done

[ ] Show a Re-run icon and label for a failed sequence
[ ] When clicking the icon, a sequence execution gets triggered in the same context/stage
[ ] The result of the last execution overrides the result from the others.

Question: should the re-run reproduce the original sequence using the same resources or should it fetch the latest versions?

This re-run has to use the same resources. I assume that we are supporting this by having the resource-service aware of the git commit.

Questions:

is the rerun button shown only for finished items?
is the pause/abort buttons available?

The team agreed to provide a mockup application|figma to showcase possible UX implementations


0.12.3 -> 0.13.0-rc1 upgrade. Workloads fails to start due to pod security policy issue

Workloads deployed to a 0.12.3 kube-aws cluster (kubernetes v 1.12.4) does not work after the cluster is updated to kube-aws 0.13.0-rc1 (kubernetes v 1.13.5).
The grafana container deployed with helm using the prometheus-operator chart does complain about apparmor not running in the node.
Labels:             app=grafana
                    pod-template-hash=6cd75fff6b
                    release=monitoring
Annotations:        checksum/config: 112d1de8efd11e546e384adb09cee5b5a81448bfbdb77bbe096ba9fa9e0f5b85
                    checksum/dashboards-json-config: 01ba4719c80b6fe911b091a7c05124b64eeece964e09c058ef8f9805daca546b
                    checksum/sc-dashboard-provider-config: 4a8da5e1302c610a2d3a86c4fb1135ee01095d9a321d918a698c29628622aa8f
                    checksum/secret: 12f8d0d2360aed7f5a689fce0bb74a98d4f6a118a3b7ff2b5cec9e9a43cce703
                    container.apparmor.security.beta.kubernetes.io/grafana: runtime/default
                    container.apparmor.security.beta.kubernetes.io/grafana-sc-dashboard: runtime/default
                    container.apparmor.security.beta.kubernetes.io/grafana-sc-datasources: runtime/default
                    kubernetes.io/psp: monitoring-grafana
                    seccomp.security.alpha.kubernetes.io/pod: docker/default
Status:             Pending
Reason:             AppArmor
Message:            Cannot enforce AppArmor: AppArmor is not enabled on the host

The error I get in the replica set for all pods not running in the kube-system namespace is.
Error creating: pods "<deployment_name>-<hash>-" is forbidden: unable to validate against any pod security policy: []
I imagine this case should be handled by the 00-kube-aws-permissive psp, as described in
https://github.com/kubernetes-incubator/kube-aws/pull/1589
Discussion on slack
https://kubernetes.slack.com/messages/C5GP8LPEC/convo/C5GP8LPEC-1558389645.080100/

The problem is that @paalkr has existing PodSecurityPolicies in his cluster - so we don't automatically map all service accounts, users and nodes to our permissive policy.  We only do that when there are no existing policies. @paalkr I suggest that you either create a new PodSecurityPolicy and map it to the service accounts/namespaces/users you want to allow.  Or use a ClusterRoleBinding to map them to our 00-kube-aws-permissive policy.

Updated release note

Thanks for clarifying. I guess our best option to update our ClusterRoleBindings

So my quick and dirty fix to make sure that the updated cluster functions the same ways as before the upgrade, is to manually deploy the kube-aws:permissive-psp-cluster-wide ClusterRoleBinding after updating the control-plane. For new clusters we will start to use proper Pod Security Policies
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
  name: kube-aws:permissive-psp-cluster-wide
roleRef:
  kind: ClusterRole
  name: kube-aws:permissive-psp
  apiGroup: rbac.authorization.k8s.io
subjects:
- kind: Group
  name: system:serviceaccounts
- kind: Group
  name: system:autheniticated

I'm closing this issue because I manage to work around the problem by manually deploy the permissive ClusterRoleBinding. I understand it's hard to fully automate this though, but I wonder if and how we might make a better upgrade experience

I imagine you could do something like this as well
controller:
  customFiles:
    - path: "/srv/kubernetes/manifests/custom/custom-permissive-psp.yaml"
      permissions: 0644
      content: |
        apiVersion: rbac.authorization.k8s.io/v1
        kind: ClusterRoleBinding
        metadata:
          name: kube-aws:custom-permissive-psp-cluster-wide
        roleRef:
          kind: ClusterRole
          name: kube-aws:permissive-psp
          apiGroup: rbac.authorization.k8s.io
        subjects:
        - kind: Group
          name: system:serviceaccounts
        - kind: Group
          name: system:autheniticated

Yup, that worked!