x-vector: add growable vector, similar to a Java ArrayList

This adds two modules X.Data.Vector.Ref and X.Data.Vector.Grow.
Ref is similar to an IORef, but doesn't have the overhead of thread safety. It's parameterised by the vector used to store the value, so it can be boxed, unboxed or storable.
Grow is a mutable vector that can have elements pushed on to the back of it, then frozen in to an immutable vector - it is parameterised in a similar way to Ref.
/cc @amosr @tranma @markhibberd @nhibberd @olorin

Nice, looks good to me.
Curious if you considered growing the vector exponentially similar to a C++ Vector or a Python list, doubling capacity whenever expansion is required rather than adding one element at a time?

Curious if you considered growing the vector exponentially similar to a C++ Vector or a Python list, doubling capacity whenever expansion is required rather than adding one element at a time?

It should be doing this I think

Do you want to drop the 7.8 build or does something depend on it?
Otherwise :+1: on :green_apple:

@erikd-ambiata hmm yeah maybe we should just drop the 7.8 build
i've done a fixup replacing fmap with liftM, so it should succeed now though

looks good 🍇
perhaps it should be called UnsafeRef?

It's not unsafe though? (also that's two words :savage:)

It should be doing this I think

You are correct, I was misreading.
:cat:


Snapshot not launching simulators on Xcode 9.1

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
When updating snapshot, fastlane after moving to Xcode 9, snapshot fails when running tests, and doesn't ever get round to loading a simulator.
I have tried solutions suggested at #10644 and #10969 to no avail.
Anyone having the same issues?
Thanks
Complete output when running fastlane, including the stack trace and command used
[11:30:00]: Get started using a Gemfile for fastlane https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile
DEBUG [2017-11-29 11:30:03.15]: Checking if there are any plugins that should be loaded...
-------
INFO [2017-11-29 11:30:03.64]: -------------------------------------------------
INFO [2017-11-29 11:30:03.64]: --- Step: Verifying required fastlane version ---
INFO [2017-11-29 11:30:03.64]: -------------------------------------------------
INFO [2017-11-29 11:30:03.64]: Your fastlane version 2.67.0 matches the minimum requirement of 2  ✅
INFO [2017-11-29 11:30:03.69]: ------------------------------
INFO [2017-11-29 11:30:03.69]: --- Step: default_platform ---
INFO [2017-11-29 11:30:03.69]: ------------------------------
INFO [2017-11-29 11:30:03.69]: Driving the lane 'ios screenshots' 🚀
INFO [2017-11-29 11:30:03.73]: ----------------------
INFO [2017-11-29 11:30:03.73]: --- Step: snapshot ---
INFO [2017-11-29 11:30:03.73]: ----------------------
DEBUG [2017-11-29 11:30:04.72]: Fetching available simulator devices
INFO [2017-11-29 11:30:05.07]: Successfully loaded '/Users/harrybloom/development/ios/wevat-customer/fastlane/Snapfile' 📄

+------------------------+------------------------+
|   Detected Values from './fastlane/Snapfile'    |
+------------------------+------------------------+
| languages              | ["en-GB", "zh-Hans"]   |
| scheme                 | WeVatUITests           |
| output_directory       | ./fastlane/screenshots |
| workspace              | ./WeVat.xcworkspace    |
| ios_version            | 11.1                   |
| stop_after_first_error | true                   |
| concurrent_simulators  | false                  |
| number_of_retries      | 0                      |
+------------------------+------------------------+

INFO [2017-11-29 11:30:05.08]: $ xcodebuild -list -workspace ./WeVat.xcworkspace
INFO [2017-11-29 11:30:06.95]: $ xcodebuild -showBuildSettings -workspace ./WeVat.xcworkspace -scheme WeVatUITests
DEBUG [2017-11-29 11:30:10.90]: Fetching available simulator devices
DEBUG [2017-11-29 11:30:11.17]: Found 34 simulators.
DEBUG [2017-11-29 11:30:11.17]: Fetching available simulator devices
DEBUG [2017-11-29 11:30:11.41]: Checking that helper files contain SnapshotHelperVersion [1.7]

+----------------------------+------------------------------------------+
|                      Summary for snapshot 2.67.0                      |
+----------------------------+------------------------------------------+
| devices                    | ["iPhone 7"]                             |
| output_directory           | /Users/harrybloom/development/ios/wevat  |
|                            | -customer/fastlane/screenshots           |
| workspace                  | ./WeVat.xcworkspace                      |
| languages                  | ["en-GB", "zh-Hans"]                     |
| launch_arguments           | [""]                                     |
| output_simulator_logs      | false                                    |
| ios_version                | 11.1                                     |
| skip_open_summary          | false                                    |
| skip_helper_version_check  | false                                    |
| clear_previous_screenshots | false                                    |
| reinstall_app              | false                                    |
| erase_simulator            | false                                    |
| localize_simulator         | false                                    |
| app_identifier             | com.wevat                                |
| buildlog_path              | ~/Library/Logs/snapshot                  |
| clean                      | false                                    |
| scheme                     | WeVatUITests                             |
| number_of_retries          | 0                                        |
| stop_after_first_error     | true                                     |
| concurrent_simulators      | false                                    |
| xcode_path                 | /Applications/Xcode.app                  |
+----------------------------+------------------------------------------+

INFO [2017-11-29 11:30:11.46]: Building and running project - this might take some time...
INFO [2017-11-29 11:30:11.62]: Patching simulators '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' to scale to 100%
DEBUG [2017-11-29 11:30:11.62]: Fetching available simulator devices
INFO [2017-11-29 11:30:11.85]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPhone-5' '1.0'
INFO [2017-11-29 11:30:11.96]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPhone-5s' '1.0'
INFO [2017-11-29 11:30:12.12]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPhone-6' '1.0'
INFO [2017-11-29 11:30:12.25]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPhone-6-Plus' '1.0'
INFO [2017-11-29 11:30:12.36]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPhone-6s' '1.0'
INFO [2017-11-29 11:30:12.46]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPhone-6s-Plus' '1.0'
INFO [2017-11-29 11:30:12.58]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPhone-7' '1.0'
INFO [2017-11-29 11:30:12.72]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPhone-7-Plus' '1.0'
INFO [2017-11-29 11:30:12.83]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPhone-SE' '1.0'
INFO [2017-11-29 11:30:12.93]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPad-Air' '1.0'
INFO [2017-11-29 11:30:13.05]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPad-Air-2' '1.0'
INFO [2017-11-29 11:30:13.16]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPad-(5th-generation)' '1.0'
INFO [2017-11-29 11:30:13.27]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPad-Pro-(9.7-inch)' '1.0'
INFO [2017-11-29 11:30:13.38]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPad-Pro-(12.9-inch)' '1.0'
INFO [2017-11-29 11:30:13.49]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPad-Pro-(12.9-inch)-(2nd-generation)' '1.0'
INFO [2017-11-29 11:30:13.60]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPad-Pro-(10.5-inch)' '1.0'
INFO [2017-11-29 11:30:13.71]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPhone-5s' '1.0'
INFO [2017-11-29 11:30:13.81]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPhone-6' '1.0'
INFO [2017-11-29 11:30:13.92]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPhone-6-Plus' '1.0'
INFO [2017-11-29 11:30:14.03]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPhone-6s' '1.0'
INFO [2017-11-29 11:30:14.14]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPhone-6s-Plus' '1.0'
INFO [2017-11-29 11:30:14.24]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPhone-7' '1.0'
INFO [2017-11-29 11:30:14.41]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPhone-7-Plus' '1.0'
INFO [2017-11-29 11:30:14.57]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPhone-8' '1.0'
INFO [2017-11-29 11:30:14.69]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPhone-8-Plus' '1.0'
INFO [2017-11-29 11:30:14.81]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPhone-SE' '1.0'
INFO [2017-11-29 11:30:14.92]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPhone-X' '1.0'
INFO [2017-11-29 11:30:15.03]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPad-Air' '1.0'
INFO [2017-11-29 11:30:15.14]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPad-Air-2' '1.0'
INFO [2017-11-29 11:30:15.25]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPad-(5th-generation)' '1.0'
INFO [2017-11-29 11:30:15.37]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPad-Pro-(9.7-inch)' '1.0'
INFO [2017-11-29 11:30:15.49]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPad-Pro-(12.9-inch)' '1.0'
INFO [2017-11-29 11:30:15.60]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPad-Pro-(12.9-inch)-(2nd-generation)' '1.0'
INFO [2017-11-29 11:30:15.71]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.iPad-Pro-(10.5-inch)' '1.0'
INFO [2017-11-29 11:30:15.84]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.Apple-TV' '1.0'
INFO [2017-11-29 11:30:15.96]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.Apple-TV-4K' '1.0'
INFO [2017-11-29 11:30:16.10]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.Apple-TV-4K-(at-1080p)' '1.0'
INFO [2017-11-29 11:30:16.25]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.Apple-Watch---38mm' '1.0'
INFO [2017-11-29 11:30:16.42]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.Apple-Watch---42mm' '1.0'
INFO [2017-11-29 11:30:16.59]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.Apple-Watch-Series-2---38mm' '1.0'
INFO [2017-11-29 11:30:16.76]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.Apple-Watch-Series-2---42mm' '1.0'
INFO [2017-11-29 11:30:16.94]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.Apple-Watch-Series-3---38mm' '1.0'
INFO [2017-11-29 11:30:17.11]: $ defaults write '/Users/harrybloom/Library/Preferences/com.apple.iphonesimulator.plist' 'SimulatorWindowLastScale-com.apple.CoreSimulator.SimDeviceType.Apple-Watch-Series-3---42mm' '1.0'
DEBUG [2017-11-29 11:30:17.29]: Patching simulator to work with secure text fields
INFO [2017-11-29 11:30:17.29]: $ defaults write com.apple.iphonesimulator ConnectHardwareKeyboard 0
DEBUG [2017-11-29 11:30:17.47]: Fetching available simulator devices
WARN [2017-11-29 11:30:17.85]: Running snapshot on: iPhone 7
INFO [2017-11-29 11:30:17.85]: $ set -o pipefail && xcodebuild -workspace ./WeVat.xcworkspace -scheme WeVatUITests -derivedDataPath '/var/folders/rp/1v266bc12h574xq5104g3dz40000gn/T/snapshot_derived20171129-56855-almmn4' -destination 'platform=iOS Simulator,name=iPhone 7,OS=11.1' FASTLANE_SNAPSHOT=YES build test | tee /Users/harrybloom/Library/Logs/snapshot/WeVat-WeVatUITests.log | xcpretty
INFO [2017-11-29 11:30:17.85]: ▸ Loading...
INFO [2017-11-29 11:30:21.26]: ▸ Building Pods/Bolts [Debug]
INFO [2017-11-29 11:30:21.26]: ▸ Check Dependencies
INFO [2017-11-29 11:30:21.44]: ▸ Processing Info.plist

#### compiling ####

▸ Signing /var/folders/rp/1v266bc12h574xq5104g3dz40000gn/T/snapshot_derived20171129-56855-almmn4/Build/Products/Debug-iphonesimulator/WeVat.app
▸ Build Succeeded
2017-11-29 11:34:37.959 xcodebuild[56943:9395575]  IDETestOperationsObserverDebug: Writing diagnostic log for test session to:
/var/folders/rp/1v266bc12h574xq5104g3dz40000gn/T/com.apple.dt.XCTest/IDETestRunSession-04B84662-124A-4A05-B4D4-701438A1F203/WeVatUITests-6231D496-AF9E-450C-B762-A1DFFE38DD29/Session-WeVatUITests-2017-11-29_113437-XMocqZ.log
2017-11-29 11:34:37.960 xcodebuild[56943:9387739] [MT] IDETestOperationsObserverDebug: (73DF6F09-DB54-446B-ADAC-474174AA4DFF) Beginning test session WeVatUITests-73DF6F09-DB54-446B-ADAC-474174AA4DFF at 2017-11-29 11:34:37.959 with Xcode 9B55 on target <DVTiPhoneSimulator: 0x7fdf3f020f20> {
SimDevice: iPhone 7 (0617698B-5484-439A-90C8-05AED18C4C46, iOS 11.1, Booted)
} (11.1 (15B87))
▸ Building Pods/Bolts [Debug]
▸ Check Dependencies
▸ Building Pods/Amplitude-iOS [Debug]
▸ Check Dependencies
▸ Building Pods/ReactiveKit [Debug]
▸ Check Dependencies
▸ Building Pods/Differ [Debug]
▸ Check Dependencies
▸ Building Pods/Branch [Debug]
▸ Check Dependencies
▸ Building Pods/FirebaseUI-FirebaseAuthUI [Debug]
▸ Check Dependencies
▸ Building Pods/Bond [Debug]
▸ Check Dependencies
▸ Building Pods/FBSDKCoreKit [Debug]
▸ Check Dependencies
▸ Building Pods/FirebaseUI-FirebaseFacebookAuthUI [Debug]
▸ Check Dependencies
▸ Building Pods/FirebaseUI-FirebaseGoogleAuthUI [Debug]
▸ Check Dependencies
▸ Building Pods/FBSDKLoginKit [Debug]
▸ Check Dependencies
▸ Building Pods/FirebaseUI-FirebasePhoneAuthUI [Debug]
▸ Check Dependencies
▸ Building Pods/GTMSessionFetcher [Debug]
▸ Check Dependencies
▸ Building Pods/GoogleToolboxForMac [Debug]
▸ Check Dependencies
▸ Building Pods/GTMOAuth2 [Debug]
▸ Check Dependencies
▸ Building Pods/Koyomi [Debug]
▸ Check Dependencies
▸ Building Pods/Protobuf [Debug]
▸ Check Dependencies
▸ Building Pods/R.swift.Library [Debug]
▸ Check Dependencies
▸ Building Pods/SVProgressHUD [Debug]
▸ Check Dependencies
▸ Building Pods/XLPagerTabStrip-XLPagerTabStrip [Debug]
▸ Check Dependencies
▸ Building Pods/leveldb-library [Debug]
▸ Check Dependencies
▸ Building Pods/nanopb [Debug]
▸ Check Dependencies
▸ Building Pods/XLPagerTabStrip [Debug]
▸ Check Dependencies
▸ Building Pods/Pods-WeVatUITests [Debug]
▸ Check Dependencies
▸ Processing Info.plist
▸ Compiling Pods-WeVatUITests-dummy.m
▸ Compiling Pods_WeVatUITests_vers.c
▸ Copying Pods-WeVatUITests-umbrella.h
▸ Touching Pods_WeVatUITests.framework
▸ Signing /var/folders/rp/1v266bc12h574xq5104g3dz40000gn/T/snapshot_derived20171129-56855-almmn4/Build/Products/Debug-iphonesimulator/Pods_WeVatUITests.framework
▸ Building Pods/Pods-WeVat [Debug]
▸ Check Dependencies
▸ Building WeVat/WeVat [Debug]
▸ Check Dependencies
▸ Running script 'Run R.swift generation'
▸ Building WeVat/WeVatUITests [Debug]
▸ Check Dependencies
▸ Processing Info.plist
▸ Copying /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/Library/PrivateFrameworks/XCTAutomationSupport.framework
▸ Copying /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/Library/Frameworks/XCTest.framework
▸ Preprocessing /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/Library/Xcode/Agents/XCTRunner.app/Info.plist
▸ Running script '[CP] Check Pods Manifest.lock'
▸ Compiling MainFlowTests.swift
▸ Compiling Constants.swift
▸ Compiling WeVatUITests.swift
▸ Compiling SnapshotHelper.swift
▸ Compiling Identifiers.swift
▸ Compiling XCUIElement+Extensions.swift
▸ Linking WeVatUITests
▸ Running script '[CP] Embed Pods Frameworks'
▸ Running script '[CP] Copy Pods Resources'
▸ Touching WeVatUITests.xctest
▸ Signing /var/folders/rp/1v266bc12h574xq5104g3dz40000gn/T/snapshot_derived20171129-56855-almmn4/Build/Products/Debug-iphonesimulator/WeVatUITests-Runner.app/PlugIns/WeVatUITests.xctest
** TEST FAILED **

All tests
Test Suite WeVatUITests.xctest started
MainFlowTests
✗ testMainFlow, No matches found for Find: Elements matching predicate '"leaving-date-skip-button" IN identifiers' from input {(

WeVatUITests.MainFlowTests
testMainFlow, No matches found for Find: Elements matching predicate '"leaving-date-skip-button" IN identifiers' from input {(
MainFlowTests.swift:57

	 Executed 1 test, with 1 failure (0 unexpected) in 14.015 (14.020) seconds

ERROR [2017-11-29 11:35:37.56]: Exit status: 65
INFO [2017-11-29 11:35:37.59]: Copying file '/Users/harrybloom/Library/Caches/tools.fastlane/screenshots/iPhone 7-0walkthrough.png' to '/Users/harrybloom/development/ios/wevat-customer/fastlane/screenshots/en-GB/iPhone 7-0walkthrough.png'...
WARN [2017-11-29 11:35:37.59]: Tests failed while running on: iPhone 7
WARN [2017-11-29 11:35:37.59]: For more detail about the test failures, check the logs here:
WARN [2017-11-29 11:35:37.59]: /Users/harrybloom/Library/Logs/snapshot/WeVat-WeVatUITests.log
WARN [2017-11-29 11:35:37.59]:
WARN [2017-11-29 11:35:37.59]: You can also find the test result data here:
WARN [2017-11-29 11:35:37.59]: /var/folders/rp/1v266bc12h574xq5104g3dz40000gn/T/snapshot_derived20171129-56855-almmn4/Logs/Test
WARN [2017-11-29 11:35:37.59]:
WARN [2017-11-29 11:35:37.59]: You can find the incomplete screenshots here:
WARN [2017-11-29 11:35:37.59]: /Users/harrybloom/Library/Caches/tools.fastlane/screenshots
WARN [2017-11-29 11:35:37.59]: /Users/harrybloom/development/ios/wevat-customer/fastlane/screenshots
ERROR [2017-11-29 11:35:37.59]: Caught error... 65
WARN [2017-11-29 11:35:39.86]: Lane Context:
INFO [2017-11-29 11:35:39.86]: {:DEFAULT_PLATFORM=>:ios, :PLATFORM_NAME=>:ios, :LANE_NAME=>"ios screenshots"}
ERROR [2017-11-29 11:35:39.86]: Too many errors... no more retries...
INFO [2017-11-29 11:35:39.87]: Successfully generated documentation at path '/Users/harrybloom/development/ios/wevat-customer/fastlane/README.md'

+------+---------------------+-------------+
|             fastlane summary             |
+------+---------------------+-------------+
| Step | Action              | Time (in s) |
+------+---------------------+-------------+
| 1    | Verifying required  | 0           |
|      | fastlane version    |             |
| 2    | default_platform    | 0           |
| 💥   | snapshot            | 333         |
+------+---------------------+-------------+

ERROR [2017-11-29 11:35:39.88]: fastlane finished with errors```

### Environment

<details><summary>✅ fastlane environment ✅</summary>

### Stack

| Key                         | Value                                       |
| --------------------------- | ------------------------------------------- |
| OS                          | 10.13.1                                     |
| Ruby                        | 2.4.0                                       |
| Bundler?                    | false                                       |
| Git                         | git version 2.13.6 (Apple Git-96)           |
| Installation Source         | ~/.rvm/gems/ruby-2.4.0-rc1/bin/fastlane     |
| Host                        | Mac OS X 10.13.1 (17B48)                    |
| Ruby Lib Dir                | ~/.rvm/rubies/ruby-2.4.0-rc1/lib            |
| OpenSSL Version             | OpenSSL 1.0.2k  26 Jan 2017                 |
| Is contained                | false                                       |
| Is homebrew                 | false                                       |
| Is installed via Fabric.app | false                                       |
| Xcode Path                  | /Applications/Xcode.app/Contents/Developer/ |
| Xcode Version               | 9.1                                         |

### System Locale

| Variable | Value       |   |
| -------- | ----------- | - |
| LANG     | en_GB.UTF-8 | ✅ |
| LC_ALL   |             |   |
| LANGUAGE |             |   |

### fastlane files:

<details><summary>`./fastlane/Fastfile`</summary>

```ruby
fastlane_version "2"

default_platform :ios

platform :ios do
  before_all do

  end

  desc "Runs all the tests"
  lane :test do
    scan(
      scheme: "WeVat",
      device: "iPhone 7",
      configuration: "Debug",
      clean: true
    )
  end

  lane :build do |options|
    cocoapods
    clear_derived_data
    cert()
    sigh()
    gym(
      workspace: "WeVat.xcworkspace",
      scheme: "WeVat",
      configuration: options[:configuration],
      clean: true,
      export_xcargs: "-allowProvisioningUpdates"
      )
  end

  lane :screenshots do
    snapshot(devices: ["iPhone 7"])
    frameit(gold: true)
    deliver
  end

  lane :increment_testflight_build_no do
    increment_build_number(
      build_number: latest_testflight_build_number + 1,
      xcodeproj: "WeVat.xcodeproj"
    )
  end

  desc "Submit a new Beta Build to Apple TestFlight"
  desc "This will also make sure the profile is up to date"
  lane :beta do
    increment_testflight_build_no
    #test
    ipa = build(configuration: "Beta")
    changelog = changelog_from_git_commits
    pilot(
      ipa: ipa,
      changelog: changelog,
      beta_app_description: 'WeVat Internal Testing',
      beta_app_feedback_email<EMAIL_ADDRESS>      distribute_external: true,
      groups: ["wevat-testers"]
    )
    add_git_tag
  end

  desc "Deploy a new version to the App Store"
  lane :appstoredeploy do
    test
    increment_testflight_build_no
    ipa = build(configuration: "App Store")
    appstore(
      ipa: ipa,
      skip_screenshots: true,
      force: true
      )
    add_git_tag
  end

  after_all do |lane|
    # This block is called, only if the executed lane was successful

    # slack(
    #   message: "Successfully deployed new App Update."
    # )
  end

  error do |lane, exception|
    # slack(
    #   message: exception.message,
    #   success: false
    # )
  end
end

# More information about multiple platforms in fastlane: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Platforms.md
# All available actions: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Actions.md

# fastlane reports which actions are used
# No personal data is recorded. Learn more at https://github.com/fastlane/enhancer

`./fastlane/Appfile`
app_identifier "com.wevat" # The bundle identifier of your app
apple_id<EMAIL_ADDRESS># Your Apple email address

fastlane gems

Gem
Version
Update-Status

fastlane
2.67.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

did_you_mean
1.0.2

executable-hooks
1.3.2

bundler-unload
1.0.2

rubygems-bundler
1.4.4

bundler
1.14.3

io-console
0.4.6

slack-notifier
1.5.1

CFPropertyList
2.3.5

claide
1.0.2

colored2
3.1.2

nanaimo
0.2.3

xcodeproj
1.5.3

rouge
1.11.1

xcpretty
0.2.4

terminal-notifier
1.7.1

unicode-display_width
1.1.3

terminal-table
1.7.3

plist
3.2.0

multipart-post
2.0.0

word_wrap
1.0.0

public_suffix
2.0.5

tty-screen
0.6.3

babosa
1.0.2

colored
1.2

highline
1.7.8

commander-fastlane
4.4.5

excon
0.54.0

faraday
0.11.0

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20161129

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

fastimage
2.1.0

gh_inspector
1.0.3

mini_magick
4.5.1

multi_json
1.12.1

multi_xml
0.6.0

rubyzip
1.2.0

security
0.1.3

xcpretty-travis-formatter
0.0.4

dotenv
2.2.0

faraday_middleware
<IP_ADDRESS>

uber
0.0.15

declarative
0.0.9

declarative-option
0.1.0

representable
3.0.4

retriable
2.1.0

addressable
2.5.1

mime-types-data
3.2016.0521

mime-types
3.1

little-plugger
1.1.4

logging
2.1.0

jwt
1.5.6

memoist
0.15.0

os
0.9.6

signet
0.7.3

googleauth
0.5.1

httpclient
2.8.3

google-api-client
0.13.5

json
2.0.2

openssl
2.0.1

generated on: 2017-11-29

i've noticed it stalls at this step for ~5 seconds
Running Tests: ▸ Touching WeVatUITests.xctest
▸ Signing /var/folders/rp/1v266bc12h574xq5104g3dz40000gn/T/snapshot_derived20171129-68931-rvsvnq/Build/Products/Debug-iphonesimulator/WeVatUITests-Runner.app/PlugIns/WeVatUITests.xctest```
and then reports ```** TEST FAILED **```

could the problem be caused by something related to this?

Doesn't it say in the error message what is going wrong?
All tests
Test Suite WeVatUITests.xctest started
MainFlowTests
✗ testMainFlow, No matches found for Find: Elements matching predicate '"leaving-date-skip-button" IN identifiers' from input {(

WeVatUITests.MainFlowTests
testMainFlow, No matches found for Find: Elements matching predicate '"leaving-date-skip-button" IN identifiers' from input {(
MainFlowTests.swift:57`

Seems it can't find a specific element your tests are looking for.

Nono I think that is a red herring. The problem is that the simulator
doesn’t even boot.
On Wed, 29 Nov 2017 at 21:48, Jan Piotrowski<EMAIL_ADDRESS>wrote:

Doesn't it say in the error message what is going wrong?
All tests
Test Suite WeVatUITests.xctest started
MainFlowTests
✗ testMainFlow, No matches found for Find: Elements matching predicate '"leaving-date-skip-button" IN identifiers' from input {(
WeVatUITests.MainFlowTests
testMainFlow, No matches found for Find: Elements matching predicate '"leaving-date-skip-button" IN identifiers' from input {(
MainFlowTests.swift:57`
Seems it can't find a specific element your tests are looking for.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/fastlane/fastlane/issues/11047#issuecomment-347850409,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACObYPTzHd_C331dYkLrxy8d5FZXQ-Ypks5s7VJ_gaJpZM4QuVxG
.

@harryblam With Xcode 9 the simulators don't launch the UI anymore. The simulator is most likely being started (because of the Running Tests line), the problem is probably with your tests

@milch thanks for pointing that out! Will close this issue off.


Add the benchmarks as part of github actions and fails PR if sees degradation

Allow PRs and commits in vitess to run a benchmarking job through GitHub Actions. This will allow us to verify the performance impacts of incoming changes.

There is now a comment added by the vitess bot that links the PR to the webpage where users can compare the PR's base and HEAD. Although, the PR is not marked as failed when there is a degradation.


Fails in sdk 21

The service binder code has changed as per...
http://commonsware.com/blog/2014/06/29/dealing-deprecations-bindservice.html
https://www.reddit.com/r/androiddev/comments/2jspqi/got_many_recent_reports_of_license_verification/
I'd fix it, but I uninstalled eclipse and I can't bring myself to re install it today... so I'm just going back to sdk 19 :-)

Fixed by https://github.com/Unity-Technologies/GooglePlayLicenseVerification/commit/645bf305d608545338bfea9f09b02118df09fc26.


Cropping of Images

I got this feature request per email, main usecase is cropping images quickly after taking a screenshot.
The idea is to enter a "CROP" mode which displays a rectangle to crop the image to. The nodes of the rectangle can be moved with "hjkl" for small steps and "HJKL" for large steps, possibly other keybindings for things like halfing/doubling the size and so forth. The nodes can be switched via "Tab" and "Shift-Tab". Pressing "Return" applies the crop and returns to "Image" mode.
The feature sounds really cool but I have no idea how difficult this would be. If it is too difficult it will not be implemented.

this can be done using external command. (using import from imagemagick)
:!import image.jpg

That is actually really smart, no idea why I didn't think about this as I use import for my screenshots anyway. Not keyboard driven or internal, but definitely very nice, puts the priority of this even lower.

Closing as new features will only be implemented in the Qt port.


Migrate primary branch from master to main

See https://github.com/Senzing/stream-loader/issues/283

Pull requests:

https://github.com/Senzing/g2iniparams/pull/11


mixed precision configs with higher tokens/sample

Adding mixed precision configs which qualify tokens/sample constraint for mlperf.

I know you can't add a comment in json, but can you add a README in maxtext/MaxText/configs/quantization/ with a sentence or two about each of the configs in that dir?

Sure. Will do this next week as part of b/352355780.

I know you can't add a comment in json, but can you add a README in maxtext/MaxText/configs/quantization/ with a sentence or two about each of the configs in that dir?

Sure. Will do this next week as part of b/352355780.

Can we do it in this PR? At the very least for the two files that this PR adds? I didn't realize json files don't support comments. You can add comments for the other json files like those added in https://github.com/google/maxtext/pull/762 in future PRs, but we should try to have PRs stay self contained

Did not use this config


Accessing event property inside onRowClick

Is it possible to provide access to the event property while inside the onRowClick function?
I am trying to access the event's ctrlKey and metaKey properties so that I can enable opening links in a new tab just as normal hyperlinks would function. I can do so using the regular onClick function seen here

I believe it is already accessible if you add it as the 3rd argument:
onRowClick = (rowData, rowMeta, e) => {
    const { ctrlKey, metaKey } = e;
    console.log(ctrlKey, metaKey);
}

@gabrielliwerant honestly i hate myself for not trying this before posting... but I had read the source here and didn't see event onClick={options.onRowClick ? options.onRowClick.bind(null, row, { rowIndex, dataIndex }) : null}
but I guess I don't quite 100% understand how functions work in ES6 yet

Haha, no worries, it can be confusing to know which arguments are getting passed along!

This doesn't work with typescript, the type doesnt include the event.


feat: use interfaces

We're currently processing your upload.  This comment will be updated when the results are available.


Cite additional related work

Cite these as related works of non-phylogenetic methods (Kupperman et al. 2022) and automated lineage assignment tools (Lefrancq et a. 2023).

After more thought, I couldn't find a logical place to mention the automated lineage assignment tools. Even though this project is similar in many ways to Lefrancq et al., it is more focused on the issues of reassortment and recombination and non-phylogenetic approaches to finding clusters.


Vscode cannot be opened after today's update(China, Windows7 ,64bit)

VSCode Version:latest version2018年8月15日15:54:37
OS Version:

Steps to Reproduce:
1.update Vscode
2.when updated, open Vscode

Does this issue occur when all extensions are disabled?: no any extensions
I just update my Vscode, but after updated, it doesn't work. And it's process dosen't exist in TaksManagement

Re-install cannot fix any problems;
Clear register and disk do nothing help;
Even, --rm Code file folder in Roaming has no effect for Vscode of latest versions; but for old version's, it works;

Is there anyone here?
I download the .zip 1.26version，it can works; but I don't know when next version comes updated, it will weather work or not;
Please help me. Thanks

Can you please try opening VS Code from cli with --verbose option and check if you see any errors printed?
Also try pointing to a different user data directory using --user-data-dir option

@miyoosan are you on Linux, maybe ArchLinux?

@bpasero I am on linux and I am experiencing the same issue. when Opening a file or opening workspaces

@flashery Perhaps you are experiencing https://github.com/Microsoft/vscode/issues/55934?

@nealot  thanks the have the updated version and fix the issue

@sandy081 @bpasero well, I am on Win7. I'd found my problem is similarily with #56503.
Since I have download then .zip Code, I can't recurrent the crash.
But I will  follow https://github.com/Microsoft/vscode/wiki/Native-Crash-Issues and share more information about the crash when it happens inthe near futrue.

@miyoosan please do. so you say you can run VSCode from the zip but not from the installation?

@bpasero yes

This sounds like a installation issue to me then.

Alright, let us know if you have more insights on the crash.

OK


You must fill out all required properties before checking in this document.

Hi!
When I try to publish a major version this error occurs.

You must fill out all required properties before checking in this document.

What I really want to do is save the file and automatically check in my masterpage, but my masterpage is  checkout and when i check in via sharepoint designer it says " We can't do that for you because the file is no longer checked out or has been deleted. "

Hello @saulsilva99. Does the library that you are checking files in/out of have custom or required fields on them?

Closing this issue do to age. @saulsilva99 please reopen if you are still experiencing the issue and can provide the details I requested above.

Closing this issue do to age. @saulsilva99 please reopen if you are still experiencing the issue and can provide the details I requested above.


Add support for Verilator as default linter

Hi there and thanks for your package.
I have added support for verilator as an additional compiler and added an option to choose between the the two.
I have set verilator as the default compiler, because I think that the returned info are better and it supports modern dialects of Verilog and SystemVerilog.
I'm new to coffescript so my code may not be as elegant as it should be.
Tarik

Hi,
Any chance the pull request is reviewed?
Tarik

Hi.
Is there a problem with this pull request? I've been using it for weeks and it works just fine.

@manucorporat review? merge?

@manucorporat No news good news

I can also vouch for this. Just tried it; it's nice having SystemVerilog linting...

There is an other atom plugin that uses exclusively Verilator.
https://atom.io/packages/linter-verilator
It seems that @manucorporat does not maintain this plugin anymore

Thanks for the heads up


feat: add deal test code

More details

Added MockStore
Added deal's validate_data_handler test code
Change requester_address value from request.From to request.Query

Thank you for your works! Left some comments

Thank you. I fixed it according to your comment.
(https://github.com/medibloc/panacea-oracle/pull/86/commits/b2513ade097ad424eb35e8c151c0756ac15c94c3)


Adding duration to report.step.result

cucumber-html-reporter is expecting step duration to be included as part of step.result.  This change will pass along the value so that we can get duration of steps as part of the HTML report.
Before:

After:

I dont think this timing is accurate though
Basically any step that finishes in your BDD step will be set as the time according to your code.
So if your step def consists of
I.amOnPage('https://google.com');
I.click('something');
I.click('something else');

It will get the step duration for that second click not the whole BDD gherkin step
I think what you actually want to do to get accurate timing is create your own timer on event.bddStep.before and then save the duration when it hits event.bddStep.after

Oh yeah....that makes sense.  Thanks for catching!

@ktryniszewski-mdsol changes have been made based on your feedback


TypeScript compile error: 'Promise' only refers to a type, but is being used as a value here.

I'm seeing the following compile error when trying to compile a small Angular/Rx project:
$ tsc -p .
node_modules/rxjs/Observable.d.ts(69,60): error TS2693: 'Promise' only refers to a type, but is being used as a value here.
node_modules/rxjs/operator/toPromise.d.ts(3,79): error TS2693: 'Promise' only refers to a type, but is being used as a value here.

RxJS version: 5.2.0
Code to reproduce:
typings.json
{
  "globalDependencies": {
    "es6-shim": "registry:dt/es6-shim#0.31.2+20160726072212"
  }
}

tsconfig.json
{
  "compilerOptions": {
    "outDir": "./dist/js/",
    "target": "es5",
    "noImplicitAny": false,
    "sourceMap": true,
    "module": "commonjs",
    "allowSyntheticDefaultImports": true
  },
  "include": [
    "./src/**/*",
    "./node_modules/typescript/lib/lib.es6.d.ts"
  ],
  "exclude": [
    "node_modules"
  ]
}

Angular service (edited)
import Rx from 'rxjs/Rx';
import {angular, ng} from "angular";

export class TweetEvents {
    requests = {
        getSentiment: new Rx.Subject<string>()
    }
    responses = {
        getSentimentSuccess: new Rx.Subject<Models.Sentiment>()
    }
    static $inject = [
        "$http"
    ];

    constructor(
        private $http: ng.IHttpService
    ) {
        this.initGetSentiment();
    }

    private initGetSentiment(): void {
        this.requests.getSentiment
        .flatMap((search: string) => {
            return Rx.Observable.fromPromise(
                this.$http({
                    url: 'https://example.com'
                  })
            )
        })
        .subscribe((response) => {
            this.responses.getSentimentSuccess.next(response);
        });
    }
}

angular.module("events")
    .service("TweetEvents", TweetEvents);

I'm pretty stumped and can't find examples online of other people with seeing exactly the same issue.

While I can't try this on my end, some things caught my eyes like including lib.es6.d.ts manually etcs. It'd be easier if you have repo can provide reproduce this issue.

It seems the cause was declaring commonjs modules in tsconfig.json while I'm using ES6 modules.

If I transpile my Typescript Project (a NodeJS-Application), then I get exactly the same two errors. I use commonjs modules in tsconfig.json
node_modules/rxjs/Observable.d.ts(1,25): error TS2307: Cannot find module 'promise'.
node_modules/rxjs/operator/toPromise.d.ts(3,79): error TS2693: 'Promise' only refers to a type, but is being used as a value here.

Here my Repo to reproduce
https://github.com/thomas3577/rxjs-node-typescript
Just run npm start

Can we please reopen this issue? It's still an issue .. @thomas3577 repo demonstrates it quite well.

Fixed by adding bluebird (as Promise lib) & core-js (as common ES6 polyfill). Use @types/core-js <= 0.9.36 to avoid other errors.

@ds82 Even I am facing the same issues with rxjs. Could you please help how did you integrate bluebird and corejs libraries within the code?

@ds82 Anything to be included in tsconfig.json ?

Nope.
You can see it working in this project: https://github.com/ds82/openhab1-rest

I'm still receiving this error when targeting es5.
Tried to all sorts of combinations with lib in tsconfig.json's compilerOptions.
Tried adding @types/es6-promise, @types/core-js and even tried to include the libraries themselves and not just the types.
But i'm still receiving:
ERROR in [at-loader] ./node_modules/rxjs/Observable.d.ts:58:60
    TS2693: 'Promise' only refers to a type, but is being used as a value here.

ERROR in [at-loader] ./node_modules/rxjs/Observable.d.ts:73:59
    TS2693: 'Promise' only refers to a type, but is being used as a value here.

FWIW, I have this same error on my own project and I have identified this is because my repo is a monorepo

What does it mean? I have the same error.

Same error in reactxp

Thanks a million @tje3d!
Notice that "lib": ["es2015"] seems to be enough for me to fix the 'Promise' issue.

I'm using Visual Studio with an Angular CLI-based project and experienced Typescript intellisense errors referring to this issue and several others.  In my case, I need to still target older browses (which apparently is what the "es5" settings is for).
This is what I had to do for es2017:
"compilerOptions": {
    "target" : "es5",
    "lib": ["es5", "es2017", "dom"]
}


Add Global module, expose DEV

Closes #588.
This has been lingering for a while. @MoOx mentioned there might be other methods that could be added, but I'm drawing a blank.
Any suggestions?

Thanks! Will approve, as this is what we agreed on in #588.
It occurred to me though that users will usually do open ReactNative;, bringing all submodules of ReactNative into scope, and therefore a generic name like Types, Common or Global as used here is maybe not such a good idea after all as it might already be in use in the user's project. If we decide to rename the module, we can still do this in a later PR though.

@cknitt You make a good point. When RNTypes was renamed into Types in the past, that conflicted with my Types module. I don't know how common Global would be (definitely less common than Types), but we could perhaps go with GlobalVariables instead.

Or maybe even ReactNativeGlobals (even though that's redundant). @MoOx What do you think?

About other stuff, I had this in mind https://github.com/reason-react-native/reason-react-native/blob/master/src/apis/AnimationFrame.re which has its own module...
But maybe that's not intuitive when coming from JS...
If we decide to move this stuff here, we cannot decide to use GlobalVar... This would be functions :)
Global is good for me as I don't see myself having this name as a module, but that's just me.
That said, I got the "Types" issue with BSRN in the past.
ReactNativeGlobals would feel a bit verbose indeed but that's an option.
Btw, Globals or Global ? Not sure what is best.
Ok my comment is totally not helping...

If we take a step back, what "globals" things do we have except raf functions & dev flag?
I don't see anything...
And raf & timers are all now in Timers/JSTimers.js... We could have a timer module (but that would also be generic 😂 But not that much.
I am wondering if we could have directly __DEV__ exposed by ReactNative... But since we have a namespace generated by BS, not sure we can do this...
Otherwise we could do Metro.__DEV__ ?? Since Metro handles the flag... But maybe that's not intuitive... ?
Otherwise... I don't have anymore idea. Or we could stop using bs namespace & do the namespace by hand and expose __DEV__ in main module... 😢

Speaking of Metro - we already have a Packager module. Why not put it there?

I think we could also have global.HermesInternal, but that's not quite straightforward so I opened issue #610 to discuss it.

@cknitt maybe instead if we go with a global (since we might have some stuff like Hermes flag) we could move require there?

Let's make thing simple & let's go with Global. Shouldn't be something tons of people use (!= the Types.re 😅)


M3-1827: update IP sorting function to cover equal items

Covers all three sorting cases: items are equal in rank, either of items has higher rank

Coverage increased (+0.001%) to 32.175% when pulling 16a263e34ed8d79e694ceeee78a9bb577cc56af6 on rulikrulit:feature/M3-1827-ips-sorting into 4c326ff6970a345401f85badf57d829b760ceee8 on linode:release-0.40.0.


Don't refcount texture slices individually

We only ignore the client's request to cycle if a resource hasn't been refcounted yet. We're currently tracking texture slices individually, but the only place this saves you is if you do something like bind each successive slice of a cubemap with cycle set to true. The client could just as easily cycle on the first slice and then not cycle on the others, with the understanding that cycling will cause data to be discarded.
Especially now that we're not binding slices for reads, I don't think there's any point in refcounting slices. This change would simplify the internal implementation quite a bit.

Resolved by #184


Fix the issue of clean-orphan-file mistakenly deleting data files.

Why are the changes needed?
When creating an Iceberg table on OSS and executing clean-orphan-file, there are normal data_files (just created but not yet committed to Iceberg) being cleaned up. The clean-orphan-file.min-existing-time-minutes parameter is not taking effect.
Through debugging, it was found that because OSS does not record the file access time, getAccessTime returns 0, causing the clean-orphan-file.min-existing-time-minutes parameter to become ineffective.
At the same time, the listPrefix function of Iceberg also uses getModificationTime. So using getModificationTime should be a better choice.
Brief change log

In the listDirectory function, replace getAccessTime with getModificationTime.

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[x] Add screenshots for manual tests if appropriate

[x] Run test locally before making a pull request

Documentation

Does this pull request introduce a new feature? no

@lintingbin Thanks for reporting this bug and trying to fix it.
I suggest you create an issue and link this PR to it.
It will help a lot when others try to search for the same issues.

@zhoujinsong The issue has been added and linked to this PR.

@zhoujinsong The issue has been added and linked to this PR.

Thanks for that.
We can add a prefix [AMORO-${issue number}] to the PR's title(I have added it for you this time).


Include .out file(s) in the distribution

FileNotFoundError: [Errno 2] No such file or directory: '/home/user/pkg/build/black/src/black-18.3a4/tests/debug_visitor.out'

Pull Request Test Coverage Report for Build 100

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 88.766%

Totals

Change from base Build 99:
0.0%

Covered Lines:
1122

Relevant Lines:
1264

💛  - Coveralls

Pull Request Test Coverage Report for Build 100

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 88.766%

Totals

Change from base Build 99:
0.0%

Covered Lines:
1122

Relevant Lines:
1264

💛  - Coveralls

Good catch. Thanks! ✨ 🍰 ✨


Revert "Lowercase URLs if they are all capitals"

Reverts alphagov/govuk-puppet#4524
Causes an nginx syntax error.

:+1: when green


fix clone for ADT

ADT clone was cloning the ADT but did neither attach it to a mesh nor create the layer that is needed for fullscreen UI

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/14851/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14851/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14851/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/14851/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14851/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14851/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14851/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/14851/merge#BCU1XR#0

snippet ID for testing - #xcpp9y#18083

WebGL2 visualization test reporter:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14851/merge/testResults/webgl2playwright/index.html

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14851/merge/testResults/webgpuplaywright/index.html

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14851/merge/testResults/webgl1/index.html
If tests were successful afterwards, this report might not be available anymore.


update maintainers list

Signed-off-by: Humble Chirammal<EMAIL_ADDRESS>requirements:

[x] I followed the contributing guidelines: https://github.com/github/india/blob/main/CONTRIBUTING.md.

Which change are you proposing?

[ ] Adding/updating open source project/s
[x] Adding/updating maintainer/s

Adding/updating open source project/s

[ ] The project was built in or receives significant contributions from India
[x] The project has at least 100 stargazers

Why should this open source project be featured?

Please replace this line with an explanation of why you think these changes should be made.

Adding/updating maintainer/s

[x] Maintainer's location on their GitHub profile indicates as India
[ ] Maintainer has approved this PR to be included on the website

What open source project/s does the individual maintain?
https://github.com/humblec , I am a maintainer in various open source projects which include kubernetes, glusterfs, ceph..etc

Please replace this line with GitHub URLs to projects that the individual/s maintains

Something that does not neatly fit into the binary options above

[ ] My suggested edits are not about an existing page, or at least not a single one

Please replace this line with an explanation of your proposed changes.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Cc @mvkaran @AbhinavRajesh

Thanks for your contribution @humblec blue_heart

yw ! and thanks for keeping me in the loop @mvkaran !


missing tags in git repo

seems last tag is 0.4.0:
https://github.com/someara/line-cookbook/releases
while there are two more releases after that:
http://community.opscode.com/cookbooks/line

stove now automatically adds tags, so this shouldn't happen in the future.
closing


Does not find packages in PACKAGE_DIR

I am using the PACKAGE_DIR environment variable to store packages that I re-use across applications in a separate folder. Unfortunately, the meteor helper does not find these packages.

It should be. When your Bash exec Atom, the environment variables are copied in the process. When this package fork a process for launching Meteor, the same thing happens.
Does your Atom knows about your environment variables?
You can activate Atom's console using cmi-i, just like in a regular Chrome. In the console, you can type  process.env and check if your environment variables are present.

No, the PACKAGE_DIRS variable is not present there. Now the big question is: why? I have added the environment variables using the .bash_profile file, like this:
export PACKAGE_DIRS=~/path/to/packages

This works for my bash, but obviously not for Atom. I am using MacOS and starting Atom from the standard applications folder.

Can't say. If Atom doesn't see this environment var, this plugin is dead blind.
On my side, I'm always launching Atom from the command line.

I did a cross-check now: If I use the terminal to start Atom, the environment variable is set. So the problem only occurs if I start Atom the "normal" way.

Yep, that's what I though when I led you on this track. Sounds completely related to Atom and not to this plugin.
One way to circumvent this issue could be a setting in your Atom's config.

Sounds related to this discussion: https://github.com/atom/atom/issues/3018
A workaround is provided.

Yes, the problem is indeed broader. I also found this one https://github.com/atom/atom/issues/6956. So this is not related to the package, and I am closing this. It would be helpful, however, if you could add an option to explicitly set the PACKAGES_DIR (with the environment variable's value as its default, if available). This would help us Mac users to workaround it for the time being.

Sounds doable. I can lead you on the appropriate track for a PR on this, if you want to contribute.

Unfortunately, I don't know nothing about Atom's internals, so I won't be able to create a PR.


Autocomplete note reference heading names

Is your feature request related to a problem? Please describe.
When you copy the note reference, you will switch to the target note page to paste it. Then you might forget the exact heading name to narrow down the reference scope (maybe the heading is too long or you need to know the next heading name) then you have to switch back to that page and copy the heading name. This makes the note reference less efficient. As shown in the figure below.
Describe the solution you'd like
I wish that when you are editing the reference there could pop up a sub-window illustrating the outline of the original note and you could locate it by clicking the corresponding headings to easily narrow down the reference you want. Or at least when you type the heading names, there could be IntelliSense autocomplete.
Additional context

thanks for the request.
something else we were considering is to let you copy a note ref that includes the currently selected header. auto complete is also coming but might be further down the backlog. would the former work for your use case in the meanwhile?

Yes, definitely! No hurry for the auto-complete one. Actually I just expect either one so I don't need to switch back and forth 😜.

fyi, we just implemented add selection as anchor when copying note ref functionality (that's a mouthful) to dendron: https://www.dendron.so/notes/eea2b078-1acc-4071-a14e-18299fc28f47.html#dendron-copy-note-ref
will create a separate tasks for auto completing. let me know if the above feature solves your problem since the auto complete will be low priority in that case :)

fyi, we just implemented add selection as anchor when copying note ref functionality (that's a mouthful) to dendron: https://www.dendron.so/notes/eea2b078-1acc-4071-a14e-18299fc28f47.html#dendron-copy-note-ref
will create a separate tasks for auto completing. let me know if the above feature solves your problem since the auto complete will be low priority in that case :)

Sorry for the late reply. Somehow I just directly updated from 0.10.4 to 0.10.6 yesterday and couldn't see the new functionality until then. I will test it and give further feedbacks.

all good. have you had a chance to play around with the new functionality?

all good. have you had a chance to play around with the new functionality?

Yeah, I tried and found two small problems:

When you select and copy the final heading as note ref, the generated reference still has the ":#*" sign and thus generated an empty reference because it cannot find the next ref.
I sometimes double click the heading line to select the heading instead of using mouse to manually select heading (it is quicker). But in this way dendron does not recognize I am selecting an anchor, so it just copies the whole note as a note ref.
I know this is not a bug, but I think there are other guys who are used to double-clicking to select a line.

Thanks!

We just released 0.12.1. This should fix 1) - we no longer add the next header if you are selecting the last header in the page.
As for 2), have you tried triple clicking the header? That selects the whole line and is compatible with note refs. Would that solve your use case?

We just released 0.12.1. This should fix 1) - we no longer add the next header if you are selecting the last header in the page.
As for 2), have you tried triple clicking the header? That selects the whole line and is compatible with note refs. Would that solve your use case?

Thanks for the fix! I am still waiting for the new version of dendron to be upgraded on my machine. As for 2), I will show you a screenshot showing that triple-clicking cannot work on my machine.

Okay, this took a while but the latest 0.12.4 update will create refs based on selecting any part of the header. how's that for your use case?

Okay, this took a while but the latest 0.12.4 update will create refs based on selecting any part of the header. how's that for your use case?

Thanks for the update. I just tried and now ref selection is indeed much easier. :)

Great! Going to keep this ticket open because I think auto completing headings will be useful regardless of this. It'll have to wait until have our server migration which means we're most likely looking at a november ship date for that

Great! Going to keep this ticket open because I think auto completing headings will be useful regardless of this. It'll have to wait until have our server migration which means we're most likely looking at a november ship date for that

Sure. Actually, my initial thought was: just copy the ref of heading where my current cursor lies inside because commonly people only want to cite one section, namely no need to do anything else. Unless I want to cite multiple sections, I simply replace the * with the ending section.
But the current solution is also great because it is more flexible and does not take more than 1 second. I really appreciate your effort! (Now the only issue for me is latex rendering in github page. I can try to provide a case study with my note with some latex equations in the future.)

I think there's value in having autocomplete since we already offer it on
links. Plus we'll be doing something similar for block references as well
On Thu, Apr 29, 2021 at 8:00 AM Kiran Pathakota @.***>
wrote:

Personally, I think we can close with the new reference shortcut that
copies the selected heading as well. @kevinslin
https://github.com/kevinslin - do you want to keep this open to do
anything with it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dendronhq/dendron/issues/175#issuecomment-829311256,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADD52PJJ3BGKLEMWTQ5X6LTLFYCFANCNFSM4Q5UOWGQ
.

This is done.


Add kpro_connection:sasl_reauthenticate_after/2

Allows authentication callback adapters to re-authenticate the
connection before session lifetime expires. An example use case is given
under function documentation.
This change requires adding the connection config, which contains SASL
options to the state record.
In theory, the connection process could read session_lifetime_ms out
of the SASL authentication response and set a timer itself, but this
would require quite a few changes to existing interfaces as the sasl
authentication functions return just ok and such an addition would
probably need to be behind a feature flag.

I will make a PR to the upstream when we have moved some of our services over.


More clarity needed on the different entities and sensors.

It's great that you have set this up!  I am really excited to be able to integrate Octopus Energy's data into my Home Assistant.  Let's hope they don't go bust!
When I added my API and account details, 12 different entities were set up, but only 10 are listed as associcated with the Integration. There are 2 sensors as well which are visible if I search on octopus.
For some reason there were some records for non-existant Gas and Electricity meters - perhaps they were the references for the pre-smart meters.  I have no idea, as I only recently moved into this house.  I disabled those entities as I could identify them through serial numbers that didn't correspond to those shown in my Octopus account page.
It would be helpful to have a clearer explanation of the different entities that are left so I can decide which to use in the Energy dashboard in HA.
What is the difference between Latest Consumption and Previous Accumulated Consumption? I assume the Latest Consumption might be data from the last 30 minutes (I am on Go) but perhaps it is the last day.  When is Previous Accumulated Consumption accumulated from? Is this of any use in the Energy dashboard?
There are 3 entities relating to the price of electricity - current and previous rate - I'm assuming that Current is the one I want to use in the config of the energy dashboard.  The third is a sensor, and is called latest consumption cost. This doesn't work with the Energy dashboard.
Gas only has the latest consumption cost sensor, and again it doesn't work with the energy dashboard.  Since I am on a fixed gas rate, I can just type that in anyway.
I guess some of this might be clearer after I have been running for some days, but for getting up and running it is a bit confusing.

Hi there. Thanks for using the component, and I'm sorry the docs weren't very good.
I've updated the readme with hopefully some further explaination of what sensors do what and when they appear. You can find it at https://github.com/BottlecapDave/HomeAssistant-OctopusEnergy#your-account

I also have a ticket already around gas price sensors https://github.com/BottlecapDave/HomeAssistant-OctopusEnergy/issues/17


Unnable to deploy on Cloudflare pages

Your work is very clean and nice, great template to work with,
I am trying to deploy to cloudflare pages, the worker size results more than 1MBit
would you be able to minimize the project size to be deployable on cloudflare pages ? i removed every article and every image from the project and that seems not to be the problem, i think the dependencies are making the project heavier than it should be ?

Thanks

It's nuxt-og-image
https://nuxtseo.com/nuxt-seo/guides/using-the-modules#keeping-workers-under-1mb

Thank you
I added in nuxt.config.ts the following :
  ogImage: {     enabled: false   },
And it works like charm,
thanks


tikv-ctl: add bad-regions subcommand.

close #2612

can you give me some examples, like damaging some region metas and using our tool?

I have add some test cases to show how the command check bad regions. PTAL thanks.

Great work

@overvenus PTAL again, thanks.


feat(embeddings): add Xenova transformers.js powered embedding

Add embedding powered by Xenova Transformers.js
Using Transformers.js lib provided by Xenova, you can generate embeddings locally !

Awesome!
I think this can just be called HuggingFaceEmbeddings :)

Hey unfortunately the integration test didn't work on my machine:
An error occurred during model execution: "TypeError: A float32 tensor's data must be type of function Float32Array() { [native code] }".

Is there more setup to do?


added a CI yaml file for the actions to be activated

I have fixed all the linting issues we had for the build CI to be working properly. Please accept the PR or let me know if there are any questions.


How to get pylint to ignore some errors

I have the following at the top of my Python file:
import config
And for every line where I type config.something I have a red mark underneath "config" indicating that it can't find the module.  I'm editing a file that resides on another host and I don't have that module's file residing locally, so I figure it makes sense that it's going to generate that error.
The problem is that I am referencing that module a ton in one file, so it's hitting it's max limit (I believe it's currently configured to 100) and then I don't see other legitimate errors.
Is there a more graceful way to handle this issue?  I really like the linting, but right now I'm not seeing any other errors because this error is maxing out the number of errors displayed.
Thanks!
Mike

Hi, @msoultan.  Thanks for letting us know about this.  We'll be taking a look at this as soon as we can.

@msoultan, this isn't functionality related to the Python extension. That said, from what I can tell pylint does give you the option.


Partial support for :unix as a supported base_os

Description
This adds unix as a supported TargetHost#base_os. Install behavior is not implemented for unix - there is not yet need for it.
Because of this, Actions::Base has been updated with an overrideable
supported_base_os_types method. It defaults to all supported base OSes  Prior to running an action
Base#run will now check the target host's base_os against supported
platforms and raise UnsupportedTargetOS if the base OS is not supported
by the action.
InstallChef was updated to declare it supports only :windows and :linux.
Signed-off-by: Marc A. Paradise<EMAIL_ADDRESS>Types of changes

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have run the pre-merge tests locally and they pass.
[x] n/a ~I have updated the documentation accordingly.~
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] All commits have been signed-off for the Developer Certificate of Origin.

I'm going to close this out - having to code paths for actions to not be able to do their job based on capabilities we implemented for a platform is the wrong way to approach this.


PushPlugin in Intel Xdk Android Project

Hello everyone,
I am unable to use the intel PushPlugin XDK Android project. Is there any simple design showing how to use this PushPlugin the XDK.
I'm not getting adjust 'intelxdk.config.android.xml' and the necessary permissions.
I appreciate any help.

You should not adjust intelxdk.config.android.xml because it is modified by XDK. You can set some additional permissions in intelxdk.config.additions.xml, but in my case that was not necessary to get the PushPlugin to work.
You can try to use version 2.4.0 which worked for me. Use it in the URL:
https://github.com/phonegap-build/PushPlugin.git#2.4.0


add 2d geometry capability to read_snirf and beer_lambert functions

I was playing around with the resting state dataset I and I realized that the read_snirf function from cedalion didn't work when optode locations were given in a 2D space (rather than in 3D).
--snirf.py file--
There was a FIXME: geo2d comment at the end of the read_nirs_element function, which I think it was referring to exactly this problem, right?
I modified the geometry_from_probe function (and some functions used inside it) so it does the same as it was doing before for 3D coordinates only but now also for 2D. The "dim" argument chooses whether we want the 2D or 3D info from the nirs element.
With this new geometry_from_probe function then I just used it twice inside read_nirs_element to get geo3d and geo2d. The resulting Element now has both attributes. I checked with the Stroop dataset, which has both 2d and 3d information, and the resulting Element seems to be working as expected: it has both geo2d and geo3d non-trivial (i.e. not None type) attributes.
--nirs.py file--
With a similar philosophy, I modified the beer_lambert function so it can handle 2d locations (by passing the dim=2) argument. If I understood the logic of the function correctly, the only difference now is that the distance within optodes is computed with a norm over 2d vectors, instead of 3d.

Hi Tomas,
thank you – nice! Could you please request this review from Eike (who is the master of our repo at this time while I am onboarding everyone, and potentially even afterwards until we have all the architecture solidified? 😃 )
Best
Alex
From: Tomás Codina @.>
Sent: Freitag, 14. Juni 2024 16:10
To: ibs-lab/cedalion @.>
Cc: Alexander von Lühmann @.>; Review requested @.>
Subject: [ibs-lab/cedalion] add 2d geometry capability to read_snirf and beer_lambert functions (PR #9)
I was playing around with the resting state dataset I and I realized that the read_snirf function from cedalion didn't work when optode locations were given in a 2D space (rather than in 3D).
--snirf.py file--
There was a FIXME: geo2d comment at the end of the read_nirs_element function, which I think it was referring to exactly this problem, right?
I modified the geometry_from_probe function (and some functions used inside it) so it does the same as it was doing before for 3D coordinates only but now also for 2D. The "dim" argument chooses whether we want the 2D or 3D info from the nirs element.
With this new geometry_from_probe function then I just used it twice inside read_nirs_element to get geo3d and geo2d. The resulting Element now has both attributes. I checked with the Stroop dataset, which has both 2d and 3d information, and the resulting Element seems to be working as expected: it has both geo2d and geo3d non-trivial (i.e. not None type) attributes.
--nirs.py file--
With a similar philosophy, I modified the beer_lambert function so it can handle 2d locations (by passing the dim=2) argument. If I understood the logic of the function correctly, the only difference now is that the distance within optodes is computed with a norm over 2d vectors, instead of 3d.

You can view, comment on, or merge this pull request online at:
https://github.com/ibs-lab/cedalion/pull/9
Commit Summary

a993458 https://github.com/ibs-lab/cedalion/pull/9/commits/a993458b02c8f824409cfe03b05ec289d41488e7  add 2d geometry capability to read_snirf and beer_lambert functions

File Changes
(2 https://github.com/ibs-lab/cedalion/pull/9/files  files)

M src/cedalion/io/snirf.py https://github.com/ibs-lab/cedalion/pull/9/files#diff-a5d62b493291899b39bdd32961f054f65db4cf3d90fd1e7d2844a7fcfa3c74d7  (58)
M src/cedalion/nirs.py https://github.com/ibs-lab/cedalion/pull/9/files#diff-4c42b7a9d8d4d44578d1d9f60cde8d84405ab62c39da5f06282eac86b4dc7027  (48)

Patch Links:

https://github.com/ibs-lab/cedalion/pull/9.patch
https://github.com/ibs-lab/cedalion/pull/9.diff

—
Reply to this email directly, view it on GitHub https://github.com/ibs-lab/cedalion/pull/9 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AC4BFNWSIF3QCAR2CYSYDYDZHL2R7AVCNFSM6AAAAABJKNZ6RSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM2TGNBWG44TONI .
You are receiving this because your review was requested.Message ID: @.***>

Hi Tomas, thank you – nice! Could you please request this review from Eike (who is the master of our repo at this time while I am onboarding everyone, and potentially even afterwards until we have all the architecture solidified? 😃 ) Best Alex From: Tomás Codina @.> Sent: Freitag, 14. Juni 2024 16:10 To: ibs-lab/cedalion @.> Cc: Alexander von Lühmann @.>; Review requested @.> Subject: [ibs-lab/cedalion] add 2d geometry capability to read_snirf and beer_lambert functions (PR #9) I was playing around with the resting state dataset I and I realized that the read_snirf function from cedalion didn't work when optode locations were given in a 2D space (rather than in 3D).
…
--snirf.py file-- There was a FIXME: geo2d comment at the end of the read_nirs_element function, which I think it was referring to exactly this problem, right? I modified the geometry_from_probe function (and some functions used inside it) so it does the same as it was doing before for 3D coordinates only but now also for 2D. The "dim" argument chooses whether we want the 2D or 3D info from the nirs element. With this new geometry_from_probe function then I just used it twice inside read_nirs_element to get geo3d and geo2d. The resulting Element now has both attributes. I checked with the Stroop dataset, which has both 2d and 3d information, and the resulting Element seems to be working as expected: it has both geo2d and geo3d non-trivial (i.e. not None type) attributes.
--nirs.py file-- With a similar philosophy, I modified the beer_lambert function so it can handle 2d locations (by passing the dim=2) argument. If I understood the logic of the function correctly, the only difference now is that the distance within optodes is computed with a norm over 2d vectors, instead of 3d.
_____ You can view, comment on, or merge this pull request online at: #9 Commit Summary * a993458 <a993458> add 2d geometry capability to read_snirf and beer_lambert functions File Changes (2 https://github.com/ibs-lab/cedalion/pull/9/files files) * M src/cedalion/io/snirf.py https://github.com/ibs-lab/cedalion/pull/9/files#diff-a5d62b493291899b39bdd32961f054f65db4cf3d90fd1e7d2844a7fcfa3c74d7 (58) * M src/cedalion/nirs.py https://github.com/ibs-lab/cedalion/pull/9/files#diff-4c42b7a9d8d4d44578d1d9f60cde8d84405ab62c39da5f06282eac86b4dc7027 (48) Patch Links: * https://github.com/ibs-lab/cedalion/pull/9.patch * https://github.com/ibs-lab/cedalion/pull/9.diff — Reply to this email directly, view it on GitHub <#9> , or unsubscribe https://github.com/notifications/unsubscribe-auth/AC4BFNWSIF3QCAR2CYSYDYDZHL2R7AVCNFSM6AAAAABJKNZ6RSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM2TGNBWG44TONI . You are receiving this because your review was requested.Message ID: @.***>

just saw you already co-assigned to @emiddell so nevermind!

@TCodina, in our recent joint development effort david and i merged quite some code into dev, and this also includes geo2d (if available in the snirf file) to be part of the recording container.
Could i ask you to check whether the current dev branch is covering all functionality you had pull-requested with this thread here so long ago? What we have now is that geo2D is read from snirf if it exists, and otherwise contains zeroes, i believe. What we do not have yet is an implementation of the projection from 3D to 2D. @lauracarlton has that somewhere in her plots, and we will have to discuss with @emiddell how to bring all of it together.
For you: Please check whether this request can be closed as it is covered by our latest work, or not, and let me know here!

Hi @avolu, I checked and the functionalities of the io.snirf.py file are all captured in the dev branch already, but the changes I made in the nirs.py file are not.

The geo2d functionality has been added in the meantime.


Fixing issue #28.

When recycling a view with RecyclerView, the text needs to be set to the view before trying to measure displayable text due to recycled text being present and of a different length. Prevents the StringIndexOutOfBoundsException.

Repo appears to be abandoned. Going to close to clean up my PR list.


Fix zero percentage replacement in get_binned_data Function and update parameter name

This pull request introduces changes that address the issue: The fixed value for feel_zeroes in get_binned_data may lead to deviation in some case. #334

Dynamic Fill Value Calculation: The fill value used to replace zero percentages is now calculated dynamically based on the actual data, rather than using a fixed value.

Ensuring Correct Fill Value: The fill value is guaranteed to be smaller than the minimum non-zero percentage in both the reference and current datasets. This adjustment ensures that the data distribution remains accurate.

Maintaining Data Distribution: These changes help maintain the correct distribution of data, which is crucial for accurate statistical tests, including Kullback-Leibler divergence drift score calculations.

Parameter Name Update: The parameter name has been updated from "feel_zeroes" to "fill_zeroes" for clarity and consistency.

Hope it helps
boemer00

Enhance get_binned_data Function with Flexible Fill Methods and Dynamic Scaling
This pull request introduces enhancements to my previous PR regarding the get_binned_data function. These changes address issues with handling very small percentages in data drift calculations while providing some flexibility and maintaining its original purpose.
Changes Made:

New Parameters:

fill_method (str, default='auto'): Allows users to select the method for calculating the fill value for zero percentages.
dynamic_scale (bool, default=False): Enables dynamic scaling of the fill value based on the data distribution.

Fill Methods: Three fill methods are now supported:

auto: Calculates a fill value that is the minimum of 1/10 and 1/2 of the smallest non-zero percentage.
min: Uses the minimum non-zero percentage as the fill value.
mean: Uses the average of the minimum non-zero percentages from reference and current data.

Dynamic Scaling: When enabled, applies an additional scaling factor to the fill value:
scale_factor = min(min_non_zero_ref, min_non_zero_cur) / max(min_non_zero_ref, min_non_zero_cur)

This is beneficial in cases where there is a significant difference between the minimum non-zero percentages in the reference and current data.

Normalisation: After applying the fill value, the percentages are normalised to ensure they always sum to 1:

reference_percents = reference_percents / np.sum(reference_percents)
current_percents = current_percents / np.sum(current_percents)

Error Handling: Added a ValueError for invalid fill_method values to prevent unexpected behaviour.

Lastly, I am happy to write a test for the new parameters but would appreciate direction on where this should be implemented.
Thanks


Property initial_capacity moved from vector to dynarr

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
:information_source: You can also turn on project coverage checks and project coverage reporting on Pull Request comment
Thanks for integrating Codecov - We've got you covered :open_umbrella:


gpu-operator initial version (1.1.0)

Thanks submitting your Operator. Please check below list before you create your Pull Request.

Flat operator directory structure is obsolete from 23-rd of October 2019, only nested directory structure will be accepted.

New Submissions

[x] Does your operator have nested directory structure?
[x] Have you selected the Project Community Operator Submissions in your PR on the right-hand menu bar?
[x] Are you familiar with our contribution guidelines?
[x] Have you packaged and deployed your Operator for Operator Framework?

[x] Is your submission signed?

Updates to existing Operators

[x] Is your new CSV pointing to the previous version with the replaces property?
[x] Is your new CSV referenced in the appropriate channel defined in the package.yaml ?
[x] Have you tested an update to your Operator when deployed via OLM?
[x] Is your submission signed?

Your submission should not

[x] Modify more than one operator
[x] Modify an Operator you don't own
[x] Rename an operator - please remove and add with a different name instead
[x] Submit operators to both upstream-community-operators and community-operators at once
[x] Modify any files outside the above mentioned folders
[x] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[x] Description about the managed Application and where to find more information
[x] Features and capabilities of your Operator and how to use it
[x] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[x] Human readable name and 1-liner description about your Operator
[x] Valid category name1
[x] One of the pre-defined capability levels2
[x] Links to the maintainer, source code and documentation
[x] Example templates for all Custom Resource Definitions intended to be used
[x] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

Hi @nvjmayo, thank you for contributing. Please remove replaces from CSV for this PR as there is nothing out there to replace so far and some pipelines could be confused. You will point replaces to previous existing version in every new PR.

need to re-trigger tests

/test CVP

/ok-to-test


Update MD file on new branch 2017-11-14_06-25-13

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/content1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Open fullscreen image Modal

Add
ng-click="::customPostsItemCtrl.showImageInModal('{{::customPostsItemCtr
l.item.featured_media}}','{{::customPostsItemCtrl.item.title.rendered}}'
)"
this implementation is tied to customPost.
it should be a function available to all modules

Sounds interesting. I'll try this on my branch as well, maybe I need this behaviour.

i tried to implement Modal but just got it on customPosts...

Thanks for sharing this. I will not merge it but it is a good start for us to think about creating this feature for any type of content.


firebase Structure update

I am going to use this structure
ps. edited at 12/11/2016
in /
event <---used to save event
user <---used to save user profile
in /event
abc <---- an example of event
def <-----an another example of event
in /event/abc
admin <---used to store param(maxTeamNum&minTeamNum,imgURL, description,), and owner (renewed on 13/11/2016)
member <--- used to store user who entered to the event
team <--- used to store team data
in /event/abc/admin/param (update in 24/11)
maxTeamNum
minTeamNum
imgURL
description
owner <-- who can edit the parameters of param and perform group merge (force)
in /event/abc/team
teamA <---- example of team
teamB <-----example of team
in /event/abc/team/teamA
leader: userA <---data to store who owns the team
size: 8 <-----the size of the team
teamMember:["wow","asdf"]<-- array of members who entered the team.
mergeRequests: ["teamB"] <-- if teamA wants to merge with teamB, teamA sends a mergeRequest #11 (proposed)
invitationRequests: ["xdd"] <-- if teamA wants to invite one member with no team joined, teamA sends a invitation. (proposed)
in /event/abc/member/xdd
name: "xdd" <--his displayname
selection : ["teamA","teamB"] <-- sending invitation to both team
joinedTeam : <--- empty string if no group, team name will be stored if the user has join a team (proposed)
in /user
userA <---folder storing userA's detail
wow <----folder storing wow's detail
in /user/userA (updated 24/11)
description : "hello I am userA" <--- string data for storing description
name: "User A" <---string showing display name
skill: ["C++","Python"] <---array to store his skill
comments : ["not very good ar","why this will be happen"] <--store other's comments towards this person (proposed)
own: ["/event/abc/team/teamA"] <--an array storing his permission on editing sth <--proposed and wait for discussion
like <--save like point (proposed)
dislike <--- save dislike point (proposed)

Good


Don't show next button during view + landscape mode

Prevent EntityDetailActivity's "Continue" button from being displayed while in landscape mode
Also fix code that rotates from landscape to portrait with an entity selected and launches EntityDetailActivity with that selection.
Bug 163637

Consolidated view mode detection into CommCareSession (cross-requested https://github.com/dimagi/commcare/pull/61)


volume.linear_interpolation does not interpolate any pixel

volume.linear_interpolation does not work as expected.
It is because of this line https://github.com/GlacioHack/xdem/blob/4e5ac649fec4acac88f2754f684ec22d941eb8c1/xdem/volume.py#L188
There, the mask get values 254 and 255, not 0 as expected by rasterio's fillnodata. Hence, no pixel is ever interpolated.

I don't quite get this description.  I tried casting types below:
In [1]: import numpy as np

In [2]: arr = np.random.randint(0, 2, size=(4, 4)).astype(bool)

In [3]: arr
Out[3]:
array([[False, False, False,  True],
       [ True, False, False, False],
       [ True, False, False, False],
       [ True, False, False, False]])

In [4]: arr.astype("uint8")
Out [4]:
array([[0, 0, 0, 1],
       [1, 0, 0, 0],
       [1, 0, 0, 0],
       [1, 0, 0, 0]], dtype=uint8)

True is cast as 1 and False is 0. I don't  get where 244 comes into the picture.

Looking at the docs, any value that is not 0 should be parsed as an inlier. Therefore ~nan_mask.astype("uint8") should work. Maybe it has to do with parentheses? ~(nan_mask.astype("uint8")) is maybe what it should say?

I found the issue!
In [5]: ~arr.astype("uint8")
Out [5]:
array([[255, 255, 255, 254],
       [254, 255, 255, 255],
       [254, 255, 255, 255],
       [254, 255, 255, 255]], dtype=uint8)

In [6]:  (~arr).astype("uint8")
Out [6]:
array([[1, 1, 1, 0],
       [0, 1, 1, 1],
       [0, 1, 1, 1],
       [0, 1, 1, 1]], dtype=uint8)

The problem comes from the type conversion being done before the inversion. "bitwise not 255" is weirdly enough 244!

Solved by #83


Westeros tutorial: Implementing share constraints

This PR adds a new tutorial for explaining how to add share constraints.
How to review
Run tutorial
Read through tutorials and see if the explanantions are understandable
PR checklist

[x] Tests added. Tutorial added~

[x] Documentation added.

[x] Release notes updated.
<!-- Add a single line at the top of the “Next release” section of
     RELEASE_NOTES.rst, where '999' is the GitHub pull request number:
<ul>
:pull:999: Title or single-sentence description from above.
-->

@behnam-zakeri thanks for suggesting and making the changes. These have now been merged.

Thanks @OFR-IIASA for applying the required changes. The tutorial is now ready to merge after passing the tests.

@khaeru Thanks for bringing this to my attention. Cahnges have been made accordingly. to address:

The CI checks are only meaningful if the new tutorials are tested. As it is, the new notebooks are not run. Please update the list of test cases, adding both this and the notebook from #366, and ensure the checks pass.

This requires a rebase to resolve conflicts.

This requires a rebase to resolve conflicts.

I pushed one commit to fix code formatting failure in test_tutorials.py: https://github.com/iiasa/message_ix/pull/367/checks?check_run_id=1701866010#step:8:41

I pushed one commit to fix code formatting failure in test_tutorials.py: https://github.com/iiasa/message_ix/pull/367/checks?check_run_id=1701866010#step:8:41

Thanks @OFR-IIASA and @behnam-zakeri for reviewing!

Merged by the 'squash' method because the commit messages didn't follow the code style guide. See the commit (c4c8876) for corrected examples.

I notice that the links from the documentation to the tutorials were all changed to link to the v3.0.0 tag instead of master. We keep these at master deliberately and only temporarily adjust them as part of the Release procedure (it's a chore to have to do this, but the simplest way I've yet discovered to handle this). Also v3.0.0 is not the latest release; that's 3.1.0.
As a result, if you look at the re-built docs after this PR (https://docs.messageix.org/en/master/tutorials.html#westeros-electrified) the link to the share constraint tutorial goes to v3.0.0; but that notebook of course did not exist as of that tag, and so it's a 404 error.
I will fix this for you in a separate PR before the release, but let's please avoid repeating it in the other PRs that update tutorials.

Thanks @OFR-IIASA and @behnam-zakeri for reviewing!

Merged by the 'squash' method because the commit messages didn't follow the code style guide. See the commit (c4c8876) for corrected examples.

I notice that the links from the documentation to the tutorials were all changed to link to the v3.0.0 tag instead of master. We keep these at master deliberately and only temporarily adjust them as part of the Release procedure (it's a chore to have to do this, but the simplest way I've yet discovered to handle this). Also v3.0.0 is not the latest release; that's 3.1.0.
As a result, if you look at the re-built docs after this PR (https://docs.messageix.org/en/master/tutorials.html#westeros-electrified) the link to the share constraint tutorial goes to v3.0.0; but that notebook of course did not exist as of that tag, and so it's a 404 error.
I will fix this for you in a separate PR before the release, but let's please avoid repeating it in the other PRs that update tutorials.


Remove VQE program

Now that the VQEProgram moved to Qiskit Nature, we don't need it in this repository anymore. Note that for the VQE tutorial to keep working we should first merge #45 before this.

This was done by #62, which also added some tests to make CI happy.


Markdown-to-HTML conversion fails if Markdown text contains $<anything>

This is cloned from IC issue 2352. The underlying problem is that something like the following:
```apex
System.debug('$1, $2, $3, $4, $5, $6, $.');
```

would fail (or if not, would yield unexpected results) because the $* expressions were being evaluated as regular expression group references. Those need to be escaped during the transforms and restored at the end of transform processing.

Delivered in <IP_ADDRESS>.


A suggest

Gradle is an useful and powerful tool.
I am an Andorid platform developer from China.When I download the app project from the Internet, I open the  project with Android Studio, and it will take a long time to download a version of Gradle.
I suggest that gradle not release so frequently.

@marcphilipp  Is there need a licenses to proxy or mirror the distribution url?
I recommend Tsinghua University (tuna/issues#505) and HUAWEI CLOUD to mirror or proxy the distribution url

Is there need a licenses to proxy or mirror the distribution url?

AFAIK, no.
BTW, we have already had an ICP license and expected enabling CDN nodes inside China soon.

@LeonDevLifeLog @WoodsCheney We've enabled CDN in China mainland. Please try downloading without any proxy.

I can help you!

I can download it without proxy!  :tada:
download speed very fast!


ContentCheck - Handle zero for length/minLength/maxLength

When setting a content check length to 0, the test is not properly added.

Solved as part of the next release of Portman


don't poll trying to resolve 0zk address as an unstoppable domain

Currently we try to resolve 0zk addresses as unstoppable domains, resulting in the below errors. SWR automatically retries on errors with exponential backoff, so we can either leave as is, or change the retry strategy, or be smarter and recognize that this is a 0zk address and not try to resolve it as a domain

Docs to reduce this can be found here
https://swr.vercel.app/docs/error-handling#error-retry


Automated Package Upgrade

:tada: This PR is included in version 5.0.525 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Sales vs Profit Margin is an inappropriate comparison

Module: 09
Lab/Demo: 09
Exercise: 02
Task: 01
Step: 03
Description of issue: User is asked to compare Sales and Profit Margin. Those are not compatible comparison as one is an absolute number (Sales) and the other (Profit Margin) is a ratio (which includes the absolute number as the denominator of the calculation). Therefore, the two are not apples-to-applies comparisons.
To correct this, we would change Profit Margin to Profit, thereby enabling the comparison of two absolute numbers.

This issue has been noted. We will review with our team.


/run/github-runner/runner1/_actions/reviewdog/action-setup/v1/install.sh: cannot execute: required file not found

Hello,
I got an issue while working on https://github.com/input-output-hk/haskell.nix/pull/1983, you can see the logs here:
Run reviewdog/action-suggester@v1
  with:
    tool_name: deadnix
    github_token: ***
    level: warning
    filter_mode: diff_context
    fail_on_error: false
    cleanup: true
  env:
    NIX_PATH: nixpkgs=channel:nixos-unstable
Run reviewdog/action-setup@v1
  with:
    reviewdog_version: v0.14.2
  env:
    NIX_PATH: nixpkgs=channel:nixos-unstable
Run $GITHUB_ACTION_PATH/install.sh
  $GITHUB_ACTION_PATH/install.sh
  shell: /nix/store/8fv91097mbh5049i9rglc73dx6kjg3qk-bash-5.2-p15/bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    NIX_PATH: nixpkgs=channel:nixos-unstable
    REVIEWDOG_VERSION: v0.14.2
    REVIEWDOG_TEMPDIR: /run/github-runner/runner1/_temp
/run/github-runner/runner1/_temp/4afc4738-e60d-4450-b422-c30a1edec6b7.sh: line 1: /run/github-runner/runner1/_actions/reviewdog/action-setup/v1/install.sh: cannot execute: required file not found
Error: Process completed with exit code 127.

… which is surprising since my workflow code is pretty straightforward, where the issue could potentially come from?
  deadnix:
    runs-on: [self-hosted, linux]
    steps:
      - uses: actions/checkout@v3
      - run: nix run github:astro/deadnix -- --edit --no-lambda-pattern-names
      - uses: reviewdog/action-suggester@v1
        with:
          tool_name: deadnix

I guess it is an issue of https://github.com/actions/runner.
/run/github-runner/runner1/_actions/reviewdog/action-setup/v1/install.sh should be downloaded by the runner.

We have stopped relying on action-setup as a work-around.
Please try https://github.com/reviewdog/action-suggester/releases/tag/v1.7.2

Thanks for your answer! I changed the version to<EMAIL_ADDRESS>but still have the same issue:
/run/github-runner/runner3/_temp/c56f75e4-a1f2-42bd-aeae-324eb81c5d9e.sh: line 2: /run/github-runner/runner3/_actions/reviewdog/action-suggester/v1.7.2/install.sh: cannot execute: required file not found

What other workarounds can I implement?

hmm, can you enable debug logging?
https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/enabling-debug-logging

hmm, can you enable debug logging?

Yes!

Debug logging cannot be enabled using workflow files.
https://github.com/input-output-hk/haskell.nix/pull/1983/commits/88689e1e3b78c16905fcef93fc64715dc485c435
Go to https://github.com/input-output-hk/haskell.nix/settings/variables/actions and set ACTIONS_RUNNER_DEBUG and ACTIONS_STEP_DEBUG true.

Thanks for your guidance! Here are the debug logs.

Do you have /bin/bash or /bin/sh?

I guess you don't have /bin/bash and/or /bin/sh.
I've modified it to work in such an environment.
try https://github.com/reviewdog/action-suggester/releases/tag/v1.7.4


sql/postgres: add support for row level security

Hello, first time contributor, so please let me know if I'm going about this the wrong way. I also haven't used RLS and with Postgres extensively.

I modelled the HCL based on discussions in #1071 which mimics the SQL statements used to create policies. See the .mdx change for how to use.
I've tested this manually against a Postgres DB in a docker container and seems to behave as expected including idempotency.
Unit tests covering the changes.
I couldn't get the integration tests running on either my branch or master.
I've included some fixes to some broken links in the contributing document.

resolves #1071

Hey @meringu, and thanks for your contribution.
Unfortunately, I can't accept this PR because we've already added support for RLS internally (the design is slightly different than yours) and we exposed it today for global use. You're welcome to give it a try and share your impressions 🙏
Sorry that you spent time on it and we can't accept these changes - I communicated in our Discord that this should be out in this release (or the one after). Roles and users are going to be joined to this feature.
If you still want to contribute the changes to the contributing document, you're welcome.


hubverse-aws-upload action should not run on forks

See output here: https://github.com/computationalUncertaintyLab/FluSight-forecast-hub/actions/runs/12053883846
We really only want this aws upload action to run on the upstream cdcepi/FluSight-forecast-hub repo, but it's running on this modeler's fork and generating some confusing output.

In principle, a fix could involve a construction similar to this: https://github.com/reichlab/covid19-forecast-hub/blob/master/.github/workflows/upload_to_zoltar.yml#L10
But each hub would have to update the repo owner as part of setting up the action?


Playing and Streaming commands don't work

When using any of those commands, you can't see the game changing on your own account. Only other people can see it. Its how discord works and I can't do anything about it. If this is indeed selfbot related and not the issue I talked about, then feel free to re-open it.