Issue-switch to material ui table

Automated Review Comments
Issues in index.html:

(2, 'Hardcoded string found')
(4, 'Line exceeds 80 characters')
(4, 'Hardcoded string found')
(5, 'Line exceeds 80 characters')
(5, 'Hardcoded string found')
(6, 'Line exceeds 80 characters')
(6, 'Hardcoded string found')
(10, 'Hardcoded string found')
Issues in src/components/Bar.js:
(3, 'Hardcoded string found')
(4, 'Hardcoded string found')
Issues in src/components/Example.js:
(4, 'Line exceeds 80 characters')
(7, 'Line exceeds 80 characters')
(21, 'Hardcoded string found')
(23, 'Line exceeds 80 characters')
(34, 'Line exceeds 80 characters')
(37, 'Hardcoded string found')
(40, 'Hardcoded string found')
(43, 'Hardcoded string found')
(44, 'Hardcoded string found')
(46, 'Line exceeds 80 characters')
(47, 'Line exceeds 80 characters')
(50, 'Hardcoded string found')
Issues in src/components/common/Container.js:
(6, 'Hardcoded string found')
(11, 'Hardcoded string found')
Issues in src/main.js:
(19, 'Hardcoded string found')
(21, 'Hardcoded string found')
(36, 'Hardcoded string found')

I got it.


Reorientation

One functionality I spent some time implementing in DICOMUtils.jl is a reorientation function that was ported from Monai.py. It’s not complete as far as I can tell but I’d love to help if I can. I have been super busy and need someone to lead this effort but I’d love to collaborate with you if you plan on making a full fledged dicom-based tool suite
see (https://github.com/Dale-Black/DICOMUtils.jl)
(https://github.com/JuliaNeuroscience/NIfTI.jl/issues)

Hi Dale, very cool that you're interested in this project!
I use this repo to help me with my research. I had a look at your repo, very nice functionality!
Regarding the reorientation, if I find the time, I want to write functions to get

the transformation matrix from DICOM (In fact I already have one, it's not pushed yet ... will happen in the next days)
the axis codes. I have little knowledge about these yet, but I agree it is sometimes useful to flip arrays to be all e.g. axial if displayed with matplotlib.

However, I think that the functionality for reorientation should go into another package, since it is not directly related to DICOM itself. I'm not sure what other package that can be, maybe some more general medical imaging package or one with medical image registration (not sure if one exists yet).
Unfortunately, at the moment, I don't need this functionality for my research, so I can't allocate time for it.
I reckon, towards a more complete Julia-universe, at some point it will definitely make sense to collect all the DICOMUtils and DICOMTools out there and merge them into a single repo. For leading this effort I am lacking the expertise (I'm a physicist), but I would be happy to take part as well!


add the validate L1Handler logic in fn validate_unsigned in pallet starknet

@tdelabro assign me please 🙏

and link the PR

closed by #1146


Documenting contrib

@GriffinQiu, this moves the location of some of the hook and operator you created, you'll have to import them from their new location in your scripts as in from airflow.contrib.hooks import VerticaHook
It also makes sure that the contrib items makes the documentation properly.

Can also add section on Community Contributed Executors :)

@kapil-malik, right, I just need to install the mesos libs in order to compile the docs with the executor.

oh ok ...


new feature: Experimental checks

The upcoming v0.10.0 release adds support for marking checks as experimental, which will make them not affect the process exit code and so will allow such checks to result in a FAIL without breaking continuous integration builds. This will give time for users to report problems on the implementation of new checks. If after some time nobody complains, then those new checks will more safely be made effective by removing their experimental tag.

@simoncozens, could you please take a look at this? I'd appreciate your feedback on this new feature.

it's only split out in the ghmarkdown reporter, not the HTML one?

oh, yeah. That's right. I'll have to do it in the other reporters as well. Thanks for pointing this out.


How can I handle imports?

Hi, I have a project with several files and modules. Is there a way to convert it simply to pscript?

You may want to have a look at Flexx. Flexx is able to detect functions/classes being used that are imported from other modules, and resolve everything. As long as your code does not use any unsupported builtins, anything related to the file system, and only pure Python, it should be able to compile everything.

It's also possible to use just PScript. In that case you just compile each module, and handle imports e.g by writing somemodule = window.somemodule at the top.

Hi!
How would I use Flexx to do that?
I suppose imports in functions and dynamic imports are not supported.
I am willing to improve PScript to support imports, is it within the scope of this project?
How should I start?

Hi!
How would I use Flexx to do that?

Thanks :)  well, Flexx and WebAssembly are mostly unrelated things. In the talk we've focused more on running WASM in Python, instead of the other way around. For running Python in the browser with WASM, which I assume is what you want to do, can be done in (at least) three ways:

Compile CPython (and other libs) to WASM, see Pyodide.
Run your code in RustPython compiled to WASM.
Compile typed Python code to WASM.

In the first two your code is still Python - only the VM (i.e. the interpreter capable of running Python code) is compiled to wasm. The latter is probably the most interesting, since you'd also gain a speed benefit. But such a compiler does not yet exist :) It would be a bit like PScript, but with types (and therefore more predictable, no hidden weird JS behavior).

I am willing to improve PScript to support imports, is it within the scope of this project?
How should I start?

I'm not sure if it is within scope. But you could start by extracting the logic from Flexx and rolling that into a new project. The code is in flexx/app I should warn you though that this Flexx subpackage is where many things come together, so it's not the easiest code to navigate :)  though most logic of your interest should be in _modules.py, _assetstore.py and perhaps _session.py.

Oh, sorry for the confusion!
"that" = "handle imports"
I know quite well about Pyodide. I guess your third thing could be achieved with Cython + emscripten :)
So my original question is: how would you transpile a module using flexx?

Aha :)

how would you transpile a module using flexx?

The exact way to go depends on your goals, but at some point you'll have a main Flexx widget:
class MyMainWidget(flx.Widget):  # or maybe flx.PyWidget
    def init(self):
        super().init()
        # ... this runs in JS. You can call existing Python functions here, and Flexx will pick it up, resolve everything that *that* code is using, etc. and then compile everything.

# Then you turn that into an app object
your_app = flx.App(MyMainWidget)

The app object you can then .serve()  or .launch(),  so you have a Python server connected over a websocket to the browser. You can then also have the client invoke actions in Python and the other way around.
For a more classical approach (and frankly, an approach that is a bit less magical) you can use your_app.dump() to create a dictionary with all the assets that you can then serve using Flask, Uvicorn, or whatever. Similarly you can .dump() the assets to disk.
The most important question is probably whether you want to convert your app to JS in full, or whether you need a server-client thing going on.


Remove merge config

Can you check it?

Without having mergeConfig you can not use local config values.


How to do file uploads with Axum

Currently, my colleague is trying to test file uploads with Axum and we are receiving a:
InvalidRequest(Error("invalid number", line: 1, column: 2))

Is there something specific I have to do between async-graphql and Axum to enable multi-part uploads? Or a simple example of Axum + Async Graphql with file uploads?

Are you using async-graphql-axum?

Yes

Does the client request follow this specification?
https://github.com/jaydenseric/graphql-multipart-request-spec

Yes.
I’m using the example from async-GraphQL, just running on Axum instead of
Actix
On Tue, Feb 1, 2022 at 3:12 AM Sunli @.***> wrote:

Does the client request follow this specification?
https://github.com/jaydenseric/graphql-multipart-request-spec
—
Reply to this email directly, view it on GitHub
https://github.com/async-graphql/async-graphql/issues/809#issuecomment-1026575232,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACRK6QL7ZDIBEVM5CTYG5RTUY6IWNANCNFSM5NIGBGQQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Regards,
Nicholas Frush
Founder
ghostbox
C:<PHONE_NUMBER>

I added axum-upload example and tested it with apollo-upload-examples, it works fine. 🙂

@sunli829 Cloned your example and I got the following:

Did you do the following:
1. git clone https://github.com/jaydenseric/apollo-upload-examples
2. duplicate `.env.example` as `.env` and configure `API_URL` to 'http://localhost:8000/graphql'

@sunli829 It was CORS :) I changed Axum's example to use permissive on CORSLayer instead.

@sunli829 u example cannot found any mutation for upload files !!!


Update form-processing-model-in-flow.md

Spelling change

@v-aangie  thank you for merging . May I know when it will update ?

@vihars711 - Although the file was merged, publication of 2021 docs ended 17 Dec. It should go live after 1 Jan 2022.

@vihars711 @JoeFernandezMS - This change request is now live: https://docs.microsoft.com/en-us/ai-builder/form-processing-model-in-flow.


(BUG) Torus login failed Node results do not match

Precondition:
The welcome page is opened
Steps to reproduce:

Click the Google button
Select mailbox
Pay attention to the error message

Actual result: User isn't able to sign up via torus
Expected result: User should be able to sign up via torus
Checked on qa V 1.7.1-0  // prod v 1.7.5
Moto g4 //Android 7   (for other devices torus works well)

@WolfVV i already told you that it's Torus issue, something is down on theirs side. Just wait some time and bug will disappear. We couldn't do anything with that. We already have added retry call but if we getting two failures in a row - login will be cancelled.

@WolfVV I need you to be absolutly positive that this is an android 7 specific issue.

@AnastasiiaOdnoshevna please check this

@sirpy @serdiukov-o-nordwhale
I've checked next scenarios for the devices with Android 7, 8, 9 and 10 OS:

user sign up via Torus;
user login in existing account via Torus

Used devices:

Huawei P10 // 7.0
Samsung Galaxy Note 8 // 7.1.1
Samsung Galaxy S7 // 8.0
Xiaomi Redmi S2 // 9
Pixel 4XL // 10

Login via Torus works without any issues on every Android version from 7 to 10. User can successfully create account and sign up.
Video from Huawei (Android 7) is here
Maybe as @serdiukov-o-nordwhale said, it's Torus issue, or maybe this issue 1/5 reproduced.
I wouldn't close the issue now and will check this scenarios a bit later again, to make sure everything still ok.

i think we can close it


fix(build): trigger build workflow on pushed tags

WHAT
This PR fixes the build workflow trigger declarations. The tags have previously been defined for workflow_dispatch, but this event type does not take other arguments than input. See docs
WHY
Creating a git tag in the release/1.9.8 branch did not trigger any builds. The new declaration should fix that
FURTHER NOTES
v1.9.8 tag was deleted again. When the changes are merged, we should be able to just re-create it

Ha, wait we have another prob. I encoded 'releases/' in every workflow that should trigger on the release branch itself. but it should be 'release/', right?
I'll create another PR on that change, that PR should precede the merging of this one ...

Hmm I think we can ignore the lint workflow issue. It is comparing the Chart version to the one in main branch. There, it is already bumped for the next release. What do you think @drcgjung

Hmm I think we can ignore the lint workflow issue. It is comparing the Chart version to the one in main branch. There, it is already bumped for the next release. What do you think @drcgjung

we could, but any further llinttest on the branch will behave so ... hmm second.
ct lint --target-branch ${{ github.event.repository.default_branch }}

should be
ct lint --target-branch ${{ github.event.ref }}

?

That could solve the issue. But to be honest, I'm unsure, if github.ref would be a better option. If i remember correctly, event.ref is different for each event.
I couldn't find a clear definition in the docs. This comment on StackOverflow shows different output examples at the end of the post.
We could also think about a dedicated release worklfow, that would just focus on the necessary steps for release, with the proper config and less conditions :).
So what do you think? should I merge it for now and create the release tag? Or should we find a solution first?

Merging #40 did not solve the issue. It seems like github.event.ref is empty for push (event should be push, when merging)
From workflow run logs:
Run ct lint --target-branch  --config charts/config/chart-testing-config.yaml

hmmpfs maybe something like
${{ github.event.ref || github.event.base_ref  }}


Redo all visuals

Currently the styling is incredibly minimal. Rework it to look closer to the Datapad.

Resolved as part of https://github.com/josephrkramer/batuu-scanner2/issues/45


re-factored code for pylexibank 2.x

So to get this PR running, you need

a clone of cldf/cldfbench, and pip install -e . run in it
a clone of lexibank/pylexibank with branch v2 checked out, and pip install -e . run in it
the branch for this PR

Now you should be able to run:
cd chenhmongmien
cldfbench download lexibank_chenhmongmien.py
cldfbench lexibank.makecldf lexibank_chenhmongmien.py --glottolog ../../glottolog/glottolog --glottolog-version v4.0 --concepticon ../../concepticon/concepticon-data

Thanks, very helpful. I shall use this as a cheatsheet for updating the datasets of which I'm the patron. Have there been any changes to pyclts that I'm missing? In a fresh environment with pylexibank v2 and master cldfbench:
  File "/cldf/cldfbench/src/cldfbench/catalogs.py", line 59, in <module>
    class CLTSAPI(pyclts.api.CLTS):
AttributeError: module 'pyclts' has no attribute 'api'

@chrzyki, I have a fix, should I push it?

the __init__ of pyclts is missing the line from pyclts import api

That's it, thanks!

Thanks as well @LinguList. When can I start/should I start adapting repositories with cldfbench and the new pylexibank?

@LinguList ok, go ahead and merge. I guess we don't need to keep master clean until the next release.

@chrzyki No, not yet - at least not wholesale. I'd like to try just a few, then make proper releases of cldfbench and pylexibank, then go all in.

Sounds good. I'll play around with 2-3 of the more complex datasets and report back.

I'll later propose a new example, and then also be able to show a first template that exposes all possibilities (all uncommented). I think we'll really need that to see what is there.


Update submodules automatically

The submodules currently need to be bumped manually. Should be able to get dependabot to do it automatically.

Background
We currently have a dawn-build repository that is responsible for building dawn using GitHub Actions and publishing releases. The version of dawn that is built is based on the submodule in that repository. These builds exist essentially as a cache so that the Actions runs in the main wgslsmith repository are relatively quick (dawn takes a while to build).
Currently, the build is triggered either manually or on a push so the version easily gets quite stale. Additionally, it can (and does) get out of sync with the submodule in this repo.
For naga, the situation is simpler since it is:
a) significantly easier to build, being a standard cargo-based rust project
b) takes much less time to compile and can be cached like any other rust dependency during wgslsmith's build
Proposal

Remove the submodule from dawn-build
Schedule the build to run daily, pulling the latest commit and publishing a release if the build is successful. This should be tagged with the relevant dawn commit hash.
Add a workflow to this repo that runs periodically (perhaps hourly).

checks if there is a new release to dawn-build
bumps the submodule to the latest dawn version corresponding to dawn-build and creates a PR
builds wgslsmith with the latest dawn-build version
executes some test shaders to check nothing's broken
merges the PR if everything looks good
if not, the PR stays open and can be manually checked

Similarly for naga, except we can check for updates directly against upstream.
It might be possible to use dependabot to implement some of this, but I haven't looked into it in detail.


The Contributors

Adding contributions along the project using the all-contributors bot.

@all-contributors please add please add @Swanson-Hysell for design mentoring

@all-contributors please add @bramvaes for design ideas

@all-contributors please add @duserzym for ideas

@all-contributors please add @Swanson-Hysell for code


Update readme example

The example on readme don't consider the delay argument. Could you update it with a working example?
Thanks for the lib btw!

I added that and also added a examples folder.
For now there is one example using esp-idf.
Thanks for pointing out that error 👍🏼


how to remove ', TDLib 1.6.0' from aplication_version value in Telegram session

hi
when we create session by tdlib that add extra string to application_version value in telegram session
this is my parameter value
tdlibParameters: {
device_model: 'Firefox',
system_version: 'Windows',
application_version: '5.7.0',
enable_storage_optimizer: true,
apiId: api_id,
apiHash: api_hash
}
but when i see telegram sessions
application_version: 5.7.0, TDLib 1.6.0
how to caler this copy right

I can see that you've reported that upstream (which was the right decision). Thus closing.

thanks


Missing Azure RBAC built-in role

The Azure RBAC built-in role "AzureML Compute Operator" is missing from the list in the page

It is found in the Azure Portal.

Kindly update the table, thanks!

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 99581afb-7950-6daa-7227-055d04446b7e
Version Independent ID: f1a5bf89-9e54-aede-3a9a-70788a95927b
Content: Azure built-in roles - Azure RBAC
Content Source: articles/role-based-access-control/built-in-roles.md
Service: role-based-access-control
GitHub Login: @rolyon
Microsoft Alias: rolyon

@MSFT-mengchong
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly.

Hi @MSFT-mengchong
Thanks for your feedback. We added the AzureML Compute Operator role to the docs.
https://learn.microsoft.com/en-us/azure/role-based-access-control/built-in-roles#azureml-compute-operator
Let us know if you have additional feedback.
thanks

Hi Robert
Thanks for the heads-up!
Cheerio
Meng Chong
[Title: Photo - Description: Picture of Meng Chong Quek.  Smiling, bald and bespectacled.]
Meng Chong Quek
Microsoft Technical Trainer
C:+65 6888 7708
<EMAIL_ADDRESS>Learn.Microsoft.comhttps://learn.microsoft.com/
Microsoft Learn. Spark possibility.
[Title: Badge - Description: Microsoft Certified Trainer]  [Title: Badge - Description: Microsoft Certifed Azure Network Engineer Associate]   [Title: Badge - Description: Microsoft Certified Cybersecurity Architect Expert]
From: Robert Lyon @.>
Sent: Friday, December 1, 2023 5:02 PM
To: MicrosoftDocs/azure-docs @.>
Cc: Meng-Chong Quek @.>; Mention @.>
Subject: Re: [MicrosoftDocs/azure-docs] Missing Azure RBAC built-in role (Issue #116968)
Hi @MSFT-mengchonghttps://github.com/MSFT-mengchong
Thanks for your feedback. We added the AzureML Compute Operator role to the docs.
https://learn.microsoft.com/en-us/azure/role-based-access-control/built-in-roles#azureml-compute-operator
Let us know if you have additional feedback.
thanks

Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/azure-docs/issues/116968#issuecomment-1835720630, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BAQZ6DAKEXMXWOVH3AT2CVTYHGMGXAVCNFSM6AAAAAA7GAX3A2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZVG4ZDANRTGA.
You are receiving this because you were mentioned.Message ID: @.***>


problem using the factscorer function with LLaMa

Good morning,
I was trying to use the factscorer function.
With this code :

I received this message error :

If I remove the openai_key=None in factscore = FactScorer(model_name="retrieval+llama", data_dir="/kaggle/working/"),  I have this error :
AssertionError: Please place your OpenAI APT Key in api.key.
I would like to know if I need to have an OpenAI key for using FactScore even if my model is LLaMa as you can see on the first picture.
Thank you!

Hi @samuel-LP, the OpenAI key is needed for the atomic fact generation step (which uses davinci-003 in both workflows).


Extension does not know how to serialize a BigInt

Describe the bug
When I store an integer as an attribute to e.g. a dataset in an HDF5 file, the H5Web extension does not display any attributes, but prints in red Do not know how to serialize a BigInt.
To Reproduce

Select the HDF5 file in VS Code explorer
Go to the dataset/group that has an integer as an attribute
Click on "inspect" in the top right corner
Scroll down to the Attributes section
See error --> Instead of the attributes, the extension shows Do not know how to serialize a BigInt in red.

I have created a tiny Python script that creates an HDF5 file that - when displayed in the VS code extension - leads to the described bug.
Here's also the resulting HDF5 file zipped: h5web_bug.zip
Expected behaviour
I would expect to see the attributes, instead of the error message.
Screenshots

Context

OS: Ubuntu 20.04 (WSL2)
VS Code version: 1.70.1
Extension version: 0.0.4

Hello @rmnldwg, thanks for raising the issue, even more so for providing a way to reproduce it !
I recently added support for int64 for dataset values (https://github.com/silx-kit/h5web/pull/1179) so it should be quite simple to do the same for attribute values.
Expect this to be fixed in the next release :slightly_smiling_face:

Amazing, thanks for the info!
Great extension by the way, it makes my job so much more seamless 👍🏻

Hi @rmnldwg, the issue should now be fixed in v0.0.5. Please let us know if that's not the case 😉

Re-opening as per https://github.com/silx-kit/vscode-h5web/issues/30


ADDING COOL ANIMATION TO TESTIMONIAL SECTION

please assign me

Heyy!!
I would like to work on this.
Please assign this to me under GSSOC'23.

Please assign me this issue so that I can resolve it under GSSOC-23

Hello ,
I'm harsh. I want to work on this issue under Gssoc'23. I am really eager to work on open source projects and contribute to this community.I've taken a look at the codebase and I believe I can make some valuable improvements. I'll start working on it right away.
Skills
HTML5, CSS3, JS, Bootstrap | node js mongodb | Php, mysql | MERN | Responsive Design
@agamjotsingh18
Can you please assign this issue to me.

Sure @DHRUVKHANDELWAL00


Make heat-equation example run on GPUs

This PR adds GPU support to the heat-equation example.

I think since this is meant as an example for a tutorial setting, keeping it as simple as possible is desirable (similar to the minimal-cuda-solver example). But maybe @hartwiganzt also has an opinion about that.

@Slaedr Mike had the same concern, though I think keeping this as simple as possible for an introductory tutorial is also important. Maybe let's discuss that tomorrow.

Okay, I understand. Even for the tutorial, maybe it's nice to just select between omp and cuda (not bother with the whole map)?

Could you check whether using cg without precondition on coo matrix works or not?
For dpcpp porting PR (not just in one branch), I plan to work dense->coo->cg first.
Thus, if it is fine, could you also change it?


Stuck in version 3.0.1, can't figure out why.

Question
Hello folks, I'm working on upgrading my POC single-spa from version 3.0.1 to 3.1 or latter, but I'm stuck.
I have 7 applications, and a "main" one which is the one that has single-spa. The ONLY application where this happens, is a Angular 7 app, which is running single-spa-angular at version 3.0.1.
When I access my localhost address, I receive the following error message:

Environment
 "dependencies": {
    "@angular/animations": "7.1.2",
    "@angular/cli": "7.1.2",
    "@angular/common": "7.1.2",
    "@angular/compiler": "7.1.2",
    "@angular/compiler-cli": "7.1.2",
    "@angular/core": "7.1.2",
    "@angular/forms": "7.1.2",
    "@angular/http": "7.1.2",
    "@angular/platform-browser": "7.1.2",
    "@angular/platform-browser-dynamic": "7.1.2",
    "@angular/router": "7.1.2",
    "@ng-select/ng-select": "2.20.0",
    "@ngx-translate/core": "10.0.1",
    "@ngx-translate/http-loader": "3.0.1"
    "angulartics2": "6.1.0",
    "core-js": "2.5.5",
    "crypto-js": "3.1.9-1",
    "file-saver": "1.3.8",
    "gojs": "1.8.38",
    "jsoneditor": "5.13.2",
    "lodash": "4.17.15",
    "marked": "0.7.0",
    "mixpanel": "0.10.2",
    "mixpanel-browser": "2.28.0",
    "moment": "2.24.0",
    "ng2-file-upload": "1.3.0",
    "ngx-infinite-scroll": "6.0.0",
    "ngx-logger": "3.3.13",
    "ngx-mask": "7.3.5",
    "ngx-toastr": "10.0.4",
    "node-sass": "4.9.3",
    "plotly.js": "1.42.5",
    "qrcode": "1.3.3",
    "rxjs": "6.5.2",
    "rxjs-compat": "6.5.3",
    "ts-md5": "1.2.4",
    "tslib": "1.9.0",
    "url": "0.11.0",
    "uuid": "3.3.2",
    "zone.js": "0.8.26"
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "0.11.0",
    "@types/crypto-js": "3.1.39",
    "@types/file-saver": "1.3.0",
    "@types/jasmine": "2.8.8",
    "@types/jasminewd2": "2.0.3",
    "@types/jsoneditor": "5.28.1",
    "@types/lodash": "4.14.129",
    "@types/mixpanel-browser": "2.23.1",
    "@types/node": "10.14.6",
    "@types/uuid": "3.4.3",
    "cypress": "3.4.1",
    "cypress-file-upload": "3.1.0",
    "cypress-plugin-retries": "1.2.2",
    "husky": "1.2.1",
    "is-docker": "2.0.0",
    "jasmine-core": "2.99.1",
    "jasmine-spec-reporter": "4.2.1",
    "karma": "4.0.0",
    "karma-chrome-launcher": "2.2.0",
    "karma-coverage-istanbul-reporter": "2.0.1",
    "karma-helpful-reporter": "0.3.4",
    "karma-jasmine": "1.1.2",
    "karma-jasmine-html-reporter": "0.2.2",
    "lint-staged": "8.1.7",
    "single-spa-angular": "3.1.0",
    "ts-node": "6.1.0",
    "tslint": "5.16.0",
    "typescript": "3.1.6"
  }
}

Libs:
- @angular/core version: 7.1.2
- single-spa-angular version: 3.1.0 and newer

Others:

- It seems that on version 3.0.1, when I check my **Network** tab on Chrome, I receive a webpack bundle. **But**, on version 3.1.0 and newer, I receive an **HTML** file for whatever reason.

Unexpected token < means that a URL responded with HTML instead of javascript. You can see this if you go to http://localhost:4210/zone.min.b4afa454.js - it will return an HTML file instead of a javascript file.
Generally speaking, zonejs should be loaded once in your single-spa root config's HTML file, and should not be loaded again by each subsequent application. It seems like perhaps your Angular 7 application is trying to load zone js separately from the root config? If so, the solution would be to only load ZoneJS once in the root config and change the Angular 7 app to not try to load it again. More info about this at https://single-spa.js.org/docs/ecosystem-angular#zonejs

Hey there, @joeldenning. Thanks for the prompt response. I can confirm that the file zone.min.b4afa454.js file in my localhost:4210, is returning a JS file. And, that there is only one zone.js import (latest version as recommended), and is located at localhost:4210's index.html file.
The problem seems to be on my localhost:4201, which is only returning two files: 0.js, and main.js, both are webpack-bundled js files:

The funny thing, is that if I rollback to version 3.0.1, it returns all the files bundled:

All of this, is ignoring cache. BTW, in both cases, this is the result of the npm run start:
><EMAIL_ADDRESS>serve /home/marco.bomfim/Dev/selfservice
> ng serve --disable-host-check --port 4201 --deploy-url http://localhost:4201/ --live-reload false

WARNING: Running a server with --disable-host-check is a security risk. See https://medium.com/webpack/webpack-dev-server-middleware-security-issues-1489d950874a for more information.
WARNING: --deploy-url and/or --base-href contain unsupported values for ng serve.  Default serve path of '/' used. Use --serve-path to override.
Your single-spa application can be downloaded at http://localhost:4201/main.js
** Angular Live Development Server is listening on localhost:4201, open your browser on http://localhost:4201/ **

Date: 2020-04-20T18:01:56.658Z
Hash: cdfde7db768c8bbb16c3
Time: 14375ms
chunk {0} 0.js, 0.js.map () 79.7 kB  [rendered]
chunk {1} 1.js, 1.js.map () 86.1 kB  [rendered]
chunk {2} 2.js, 2.js.map () 84.3 kB  [rendered]
chunk {main} main.js, main.js.map (main) 6.46 MB [entry] [rendered]
chunk {scripts} scripts.js, scripts.js.map (scripts) 786 kB  [rendered]
ℹ ｢wdm｣: Compiled successfully.

You can see that there should be more files returned by the application, and I can't pinpoint exactly what is going on. I would love to provide more information, if that would help somehow.

It looks like I misread the original error message. it is not zonejs that is failing to download, it's a different file. You need to find what the other file is - it should be red in the Network tab of your devtools. That file will be the one that is returning HTML instead of javascript.
The only change in<EMAIL_ADDRESS>when compared to 3.0.1 is how System.import() is interpreted. In 3.0.1, System.import() was interpreted as a webpack code split. In 3.1.0, it is interpreted as an in-browser module from the import map.
Do you have System.import() in your Angular 7 app? If so, are you intending it to be a webpack code split, or a systemjs in-browser module import? If you want to keep it as a webpack code split, switch from System.import() to import() - the System.import() version of code splits is deprecated by webpack.

I can't see any System.import() per se, but I can see a call to SystemJS.import(), which is called in a loader(alias) function, that takes the application ie: @platform/myapp, and imports it. Would changing this, perhaps help with this scenario?
Also, which are the libraries that should be loaded in-browser, instead of bundled? Would you happen to know?

Did you find the network request that is returning HTML when it should return JS? That is crucial to diagnosing this.

Also, which are the libraries that should be loaded in-browser, instead of bundled? Would you happen to know?

Each of your microfrontends should be an in-browser module. Additionally, you can consider making @angular/core and other angular libs in-browser modules in order to share them between microfrontends. However, if you haven't already set that up it's a fair amount of work so I'd not recommend doing that until after you have fixed the issue in front of you

I can't see any network requests that are not 200s or 300s. I had a 404, but it was a logger that I typed the wrong path, but that's sorted now.
The issue remains, but I'm completely blind to what I could do next to investigate this. As for the Angular being in-browser, that's the objective in the long term, but for now I'm more worried about this issue here.

The network request will have a 200 response, but it will return HTML instead of javascript. The reason is that the server is configured to return the index.html whenever it receives a request that it cannot handle. So it will be a network request to download a js file, but the response will be HTML.
Generally the URL for it is pretty easy to find in the browser console. If not, you can look in the network tab and find the request for a javascript file that is returning HTML

Hey, @joeldenning! Apologies for the delay on the reply. I can see two files that may be the culprits on the requests (both returning 200).
The first one is the locahost:4201/main.js, which I can't even preview the response body, so I can't say for sure whether it is a JS or HTML file:

The second, is the core.module (that I've mentioned on my edit in here), which is returning an HTML file:

Could any of those files pinpoint a direction that I could follow to debug this further? That's the precise point were I'm stuck actually

Nice finds. Try going to those URLs in their own browser tabs to diagnose the issue. Until you can get javascript to return from those urls, things won't work. Here are some things to verify:

Is 4201 is the correct port.
Is ng serve running on http or https.
Is it /js/main.js instead of main.js
Try the things listed here
What is the full url for the core module? Is that a webpack code split?

Ok, been trying to get some more info on this one, but unfortunately things are still not in the clear. I've verified the above, and can confirm that:

The port is the right one,
ng serve is ignoring host-check, and accepting both https and http requests
the path is indeed main.js. I've tweaked the address to several others, and the chunk 0.js is only accessible from localhost:4201/main.js
Followed the steps on the guide, and couldn't find anything wrong with our current setup

As for the last question... the path to the core-module file is ~/Dev/selfservice/src/app/legacy/core/core.module.ts the script we are using to build this, is:
"serve": "ng serve --disable-host-check --port 4201 --deploy-url http://localhost:4201/ --live-reload false --verbose=true",

It seems that who bundles the app, is ng itself. And, with the verbose flag, I can see that it bundles up a lot of content from .../legacy/core, but, I can't see the core.module.ts getting in the bundle as well.
There is another application that is the one that calls the other apps (micro-frontend architecture), which gets bundled with webpack. core.module is where the body of what I want to show on the screen lives, basically, it is the one that should be rendered, when the main application calls it out, but I'm not able to tell you whether it is a code split or not (as I don't know how ng bundles things up).

An interesting finding today, is that one of the applications that is being served along with the one that is currently broken, when we stop its execution, the broken application now works without any issues.
The application are a Vue and a Angular (the one shouting the error), and when the Vue gets disabled, the app works again. @joeldenning, do you happen to know if there are any special configuration, or something that would make a Vue application not work along with an Angular one?
I know single-spa should be language agnostic, but I wonder...

Even though angular.json is configured to import the polyfills from the polyfill.ts file is not actually being included to the bundled app

angular.json only specifies the path to polyfills.ts. Our webpack config strips polyfills file since Angular apps have to contain only main.js and lazy-loadable chunks.

The only way to make this work, is by commenting out the Zone.js that is comming from the index.html of the main app, and import zone.js in the main-single-spa.ts file instead.

This shouldn't be done. zone.js library has to be loaded in the root-config that orchestrates all applications.

@arturovt, that's what I'm trying to do in the past couple of days. Finding a way to set the ZoneJS to be included only inside the root config.
Currently, the app registration is not being made in a

Using the coexisting-angular-microfrontends repo, we could pinpoint the difference on the configuration that were causing this issue.
It seems that on v3.0.1, the builder used for build and serve are single-spa's and not Angular's builders:
v3.0.1 angular.json:
"architect": {
          "build": {
            "builder": "single-spa-angular:build",
            ...
          "serve": {
            "builder": "single-spa-angular:dev-server",
           ...
          "extract-i18n": {
            "builder": "@angular-devkit/build-angular:extract-i18n",
          ...
         "test": {
            "builder": "@angular-devkit/build-angular:karma",
         ...
         "lint": {
            "builder": "@angular-devkit/build-angular:tslint",

v3.1.0 and beyond:
"architect": {
          "build": {
            "builder": "@angular-builders/custom-webpack:browser",
            ...
          "serve": {
            "builder": "@angular-builders/custom-webpack:dev-server",
           ...
          "extract-i18n": {
            "builder": "@angular-devkit/build-angular:extract-i18n",
          ...
         "test": {
            "builder": "@angular-devkit/build-angular:karma",
         ...
         "lint": {
            "builder": "@angular-devkit/build-angular:tslint",

Also, another thing to notice, is that the extra-webpack.config.js file, now is used differently on the angular.json file. Instead of singleSpaWebpackConfigPath, it now requires the config to use customWebpackConfig:
v3.0.1 (uses singleSpaWebpackConfigPath):
"serve": {
            "builder": "single-spa-angular:dev-server",
            "options": {
              "browserTarget": "selfservice:build",
              "singleSpaWebpackConfigPath": "extra-webpack.config.js"
            },

v3.1.0 and beyond (uses customWebpackConfig):
"serve": {
            "builder": "@angular-builders/custom-webpack:dev-server",
            "options": {
              "browserTarget": "selfservice:build",
              "customWebpackConfig": {
                "path": "./extra-webpack.config.js"
              }
            },

Making the changes above, allowed us to upgrade not only single-spa-angular, but also Angular as a whole on the project. Hope this helps someone with similar issues.


Audit CSS selectors

I'm seeing some selectors which are arbitrarily increasing specificity e.g. .jp-MarkdownCell-content.p-Widget (seen quite a bit in #127).
Is this specificity increase needed?
CC @blink1073 @jasongrout

This will go away once we explicitly load the CSS in order.

Done in master!
#628
#680


load boolen settings correctly from config

We have to check for nil in the config hash instead of false. Otherwise switches with the value false don't override the default value from the application.

Make sense. Any chance you can write a test for this?

Sure. Should I add the check to the "test_init_from_config" method or should I put it into a dedicated test method?

If you can cover it in an existing method, that's fine, but separate single-purpose tests are always good.

Test for this pull request was added a while ago. Is this ok?

Thanks!  This is now live as 2.13.3


What is the state of LSP 3.0 support on vscode?

The current vscode (1.11.1) sends through an empty Client Capabilities in the initialize message.
Is this because 3.0 is not implemented there yet, or is there some specific action to enable it?

It is. You need to upgrade to the 3.x npm version of the libraries (vscode-languageclient & vscode-languageserver)

As a non-npm person, using an installed .deb package, how would I do that?

Not sure. We only maintain a JS/TS version of the protocol which is available on npm. I have no idea if you can install npm packages via a .deb package.

Ok, thanks.  I am using the release version of vscode as a reference, I will just wait for it to work through there, since I am interested in how it actually works in the context of an editor using it.

Ah, now I see. A better example is to look at vscode-eslint then. This usually uses out latest npm packages.


Adding refactorfirst.yml

[ x] I have not changed the README.md directly.

Awesome. Thanks! ✨

Thank you @mre!


[PRO] How the pro "solo" license works?

Description
I'm interested in purchasing the Nuxt UI Pro product, particularly the 'Solo' license. However, I have some questions regarding how exactly it functions, especially the aspect of having only one developer. For example, if another developer wants to utilize the project, are they able to? Is deployment restricted to only one developer? Additionally, could you provide more clarity on the following points:
Main question -How does code management and collaboration work on projects with only one developer under the 'Solo' license? Is there a recommended workflow for solo work?
How does the 'Solo' license handle collaboration or sharing of projects?
Is there a possibility to add additional developers to a project licensed as 'Solo' temporarily for specific purposes, such as code review or one-time contributions?
How are situations handled where more than one developer needs to work simultaneously on a project licensed as 'Solo'? Are there any specific solutions or recommendations for these cases?
I really didn't understood how it limit one develop per project.

The developer limit of the Solo and Team plans apply only for the invitation to the private GitHub repository, you can use the license key to build your projects on multiple computers!

I'm gonna close this, feel free to reopen or comment if my previous comment didn't answered your question 😊


Code on NPM is outdated

The latest version on NPM is 1.2.0, could you please update it to the current version (1.3.3)?
Thanks!

https://www.npmjs.com/package/angular-timer v1.3.3 is the current version. Let me know if you find any issues.
Thanks!


Removed cross bar switch port

Removed cross bar switch port (WB MI B) from mgmt_core and mgmt_soc and verified that dv simulations pass after the updates.

Merged.


[FEATURE] Configuration Management

Is your feature request related to a problem? Please describe.
The configuration is being managed through a config.py file, which needs to be manually edited to override the defaults.
Describe the solution you'd like
The configuration values should be stored in a .yaml file, which is then read and processed by the current config.py.
This config.yaml file would be copied to the ~/.medperf on first execution.
Users should be able to change the default values via a command (medperf config set [KWARGS])
Users can reset the configuration to the default settings via a command (medperf config reset)

What about having a filesystem with:
/.medperf/profiles//config.py
/.medperf/profiles//token
for user-specific stuff, and then:
/.medperf/server//datasets
/.medperf/server//mlcubes
for server-specific config (and right now, asset IDs are server-specific)?

I'll modify Micah's proposal by placing profiles inside the respective server folder. This is because user-specific information like token is server-dependent


Still Node 12 used by referencing old "peter-evans/repository-dispatch@v1"

You're still using and old version of peter-evans/repository-dispatch@v1 which still uses Node 12. Please update this to v2, too.
Originally posted by @thomasmerz in https://github.com/maxam2017/productive-box/issues/75#issuecomment-1363820734

Hi,
This issue has already been solved in #70. (released in version v1.1.3)
If you are still experiencing this issue, please update your forked repository 🙏


dependency: cleanup unused code

Most of this wasn't used since the removal of default_formula from Requirements.

@MikeMcQuaid FWIW, it looks like this breaks neovim HEAD install, failing with:
  NoMethodError: undefined method `modify_build_environment' for #<Dependency: "lpeg" []>

^ seeing the same on a few other formula updates I have been testing: freerdp (cmake) and minio (go) for example

Sorry, this is already fixed and I will look into improving where CI missed this for the future.


drivers: can: add RX overrun counter statistic

The RX overrun counter is incremented when the CAN controller receives a CAN frame matching an installed filter but lacks the capacity to store it (either due to an already full RX mailbox or a full RX FIFO).
Implementing support for this new statistic required a few changes/fixes to the NXP FlexCAN driver, which are included here as well. The fixes could be split to a separate PR, but they are only really needed for correctly counting the RX overruns.

Rebased after https://github.com/zephyrproject-rtos/hal_nxp/pull/217 was merged - and rebased again to fix merge conflict in west.yml.

Rebased to pull in 6554eb7cfa3c06349807cc0074cb30b270b30432 in order to fix unrelated CI issues.


Params sequence changed for all functions in the generated library after upgrading endpoints to 4.8

e.g for a function search(string a , int b, int c) in the new library the function looks like
search(int c, int b, string a).
we have a app using older library with the params sequence shown in the first example. this change will need the app to refactor all the functions.
is there any way of going back to the original sequence of params ?
Thanks.

Realised today that the params are now alphabetically sorted by name and not just random seqeunce


Fix stdout and stderr missing in pulumi update command

This PR fixes this issue: https://github.com/pulumi/pulumi-command/issues/190
In the Update method, the news input struct contains Triggers, Create, Update, and Delete fields, while the olds output struct contains Stdout, Stderr, Assets, and Archive fields.
The state variable in the Update method only contains news input, causing empty stdout and stderr in downstream code https://github.com/pulumi/pulumi-command/blob/master/provider/pkg/provider/local/commandOutputs.go#L71
We can fix this by merging the news and olds inputs and outputs into a new CommandOutputs struct. The result is a new CommandOutputs struct that contains all the fields from both the CommandInputs and BaseOutputs structs. If any fields are present in both structs, the value from news will take precedence over the value from olds.

/run-acceptance-tests

@brucetan-displayr Thanks for the PR! This looks good.

Thank you for your contribution! This looks good. Running tests now.

/run-acceptance-tests


[$500] Improve AdHoc build time

Problem
AdHoc builds are working well, but the build times are slow and other minor improvements can be made.
Solution
Implement further improvements:

We can shorten Android dev build time by adding one additional line in build.gradle where we will pass the flavors that are only for development and we can skip bundling JS and assets
Fabric requires iOS build schemes without spaces e.g. instead New Expensify AdHoc we should rename it to NewExpensifyAdHoc

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~016b1f5eb0cd53791a
Upwork Job ID:<PHONE_NUMBER>907130368
Last Price Increase: 2023-09-21

Just noting that last time our prod release CI flows broke due to the name change as the build path changed. So we'll need to be careful to watch out for this when first releasing the changes.

Hey @miljakljajic, can you pay out a C+ reviewer bonus for @sobitneupane please

Sent contract @sobitneupane !

@miljakljajic I will request payment in newDot. I believe a payment summary for the issue is all that's required.

Payment summary: 500 USD for the improvements made to AdHoc build time

Requested payment on newDot.
https://github.com/Expensify/App/issues/26152#issuecomment-1730864306

$500 payment approved for @sobitneupane based on BZ summary.

Thank you!


Unexpected results for Casecommons/with_model

with_model depends on active_record and rspec, as can be seen here:
https://github.com/Casecommons/with_model/blob/master/with_model.gemspec

Thank you! I'll take a look at this as soon as I can.

Your gemspec is formatted in a way that gemnasium-parser understands. The problem is that Gemnasium looks for a gemfile first and only pulls in the gemspec if called for in the gemfile:
source "https://rubygems.org"
gemspec

This is intentional in order to mimic how Bundler behaves.

Ah, it's so obvious to me now! I'd forgotten I'd done this wacky thing.


fix: vault center help url and extract it in url helper

📝 Description
This fixes the vault help center url displayed in

the banner that warns the user vault signer mode is on
the vault settings modal

I took the opportunity to extract this url in the config/urls file
❓ Context

Impacted projects: ledger-live-desktop
Linked resource(s): ``

✅ Checklist

[ ] Test coverage
[ ] Atomic delivery
[ ] No breaking changes

📸 Demo

🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.

can you rebase with latest develop?

Sure, I've just done it

CI seems to report some lint issues (prettier)

/home/runner/work/ledger-live/ledger-live/apps/ledger-live-desktop/src/config/urls.ts
  290:1   error  Delete `⏎`  prettier/prettier
  292:81  error  Insert `,`  prettier/prettier
  293:2   error  Insert `;`  prettier/prettier

@gre fixed, but not sure why the linux test was skipped ¯_(ツ)_/¯


Fix gap between fields in advanced filtering modal

Fixes #667

@limonte Did you check this change with IE11, i think the trick removed was there for IE11, maybe.

Yup, works as well in IE11.
Chrome:

IE:


Anything we should do about this

open globe.silo
Define expression svec of type scalar (yes scalar), but definition is alias for disp (a vector)
PC plot svec...hit draw...that will fail and plot turns red.

Specified the incorrect issue with my commit and accidently closed this issue. I'm reopening it.

This is an extremely rare corner case and would be difficult to fix, so we're closing this.


ActiveMQ Security

ActiveMQ security (JMS) is not enabled even if a ACTIVEMQ_USERNAME is set.

@sconstro Can you add more details on how to reproduce the issue?

@tholu  Done

@sconstro Thanks, I can reproduce the issue - the credentials.properties is not recognized (anymore).

So no more update/fix for the Security for 5.18.3 ?

@apexbb Didn't have time to look at it yet, but there will be an update/fix for 5.18.3.

@sconstro Fixed with the 5.18.4 release.


Integration Test - Release - 2022/01/13 03:35:16

Auto create for integration test. IssueCommandFlow

#pri1

Just type '#pri3'

#pri3

#assign PRMergerTest1

#assign NonAllowedUser

#reassign PRMergerTest2

#reassign NonAllowedUser

#please-close

The following users don't have valid GitHub IDs, or are not collaborators on this repo: nonalloweduser

GitHub user PRMergerTest1 has been removed from the MicrosoftDocs organization, so they were automatically removed as an assignee.

#unassign NonAllowedUser

#unassign PRMergerTest1


SIMSBIOHUB-188 Manage Animals

Links to Jira Tickets
-SIMSBIOHUB-188
Description of Changes

Overhauled the Edit Animal modal to be a full screen page instead. Accessed through the Manage Animals button on a survey.
Animals in this view appear listed in the sidebar by their alias. Clicking on one of these items opens an accordion to the various form sections.
Each form section has been adapted into a list of static cards. You can edit or delete cards from the relevant button icons. You can also add another card from the top of the page. Clicking the add or edit buttons brings up a form modal that will send a request on submission of the form.
Deleting any card should prompt a confirm delete modal.
Telemetry devices still work slightly differently than the rest of this page in that device and deployments get added together and deployments can be deleted but devices cannot. It's fairly consistently integrated otherwise.
Currently all sections hit the bulk endpoint in Critterbase (allows multiple sections to be added at once). This can be modified to single endpoints per each form section if this is the final version of this UI.

Testing Notes

A small patch to critterbase was required to fix a bug in the capture delete function. This should be in live dev already.
Currently some tests are broken but waiting till design / flow is more finalized before fixing

I understand this is still a WIP so apologies if these are well known but I did a quick run through and noticed a few things:

Formatting / spacing on family modal seems incorrect compared to the other sections.
Dragging the map around will place the marker, I don't believe it did this previously.
Doesn't seem like there's any way to place the release marker on the map anymore? Maybe this still needs design work.
Triggering error messages on the Add Telemetry modal will cause the dialog box to resize horizontally.

Formatting / spacing on family modal seems incorrect compared to the other sections.
Will look into this

Dragging the map around will place the marker, I don't believe it did this previously.
This has been corrected in the latest changes

Doesn't seem like there's any way to place the release marker on the map anymore? Maybe this still needs design work.
This has been updated in the new UI

Triggering error messages on the Add Telemetry modal will cause the dialog box to resize horizontally.
I'll look into this, will be part of the overall telemetry section changes coming

Figured I would do another quick run through of this.

Seems like clicking on the map to place the pin and resizing the uncertainty does not work. Perhaps this is intentional?
Clicking save on the animal subsection modals does not appear to fire a POST request right now.
Mortality has a header for release location.
Selecting Predation as reason allows you to select a taxon, then if you select a taxon and change the reason, it will grey out the taxon dropdown but not clear it. This behaviour might be fine though, I'm pretty sure the API will ignore the taxon in this case.
May want to check in with Jeremy about integrating the 'View Family Structure' modal better.
I think the lack of spacing between the critter ID and the general info card looks a bit odd.
Telemetry validation seems a bit bugged but I probably just don't have latest fixes for that right now.

Editing a qualitative measurement and changing it to a different qualitative measurement type works correctly, but changing it to a quantitative measurement does not. I think this is because the resulting quantitative measurement object is placed in the update payload, but it probably needs to go in the create payload instead.
I'm not sure if we should allow creation of multiple mortality events. This used to be disallowed when it was one big form.
It seems like the validation for telemetry devices may still be firing unreliably. See screenshot, it's verifying against device id 1 even though I entered 456.

I was able to save and edit all other sections successfully.

A couple things I noticed...

The mortality workflow saving was unreliable. I tried to make a new mortality twice, and didn't get any confirmation from either. Had to refresh page and try again. The first one I added eventually showed up.
Deleting a mortality event led to a runtime error, however, the deletion does succeed: ERROR Cannot read properties of undefined (reading 'projection_mode')
The capture workflow took a very long time to validate, but did succeed ultimately
Deleting a capture event also is also causing the same runtime error as above
Deleting a measurement causes the measurement dialog to briefly open and ten disappear

Found the issue for this, was a bad piece of state inside the dialog modal. It was keeping it open while the form was submitting, and subsequently while the form was deleting entries.
I think this fix solves all these issues.

Editing a qualitative measurement and changing it to a different qualitative measurement type works correctly, but changing it to a quantitative measurement does not. I think this is because the resulting quantitative measurement object is placed in the update payload, but it probably needs to go in the create payload instead.
I'm not sure if we should allow creation of multiple mortality events. This used to be disallowed when it was one big form.
It seems like the validation for telemetry devices may still be firing unreliably. See screenshot, it's verifying against device id 1 even though I entered 456.

I was able to save and edit all other sections successfully.

Fixed :)


40+ URLS - The dashboard showing nothing

📑 I have found these related issues/pull requests
We have added 40+ urls, after that whenever we hit the home page, it showing nothing. We have to wait for 15mins then it'll load all the URLS.

🛡 Security Policy

[X] I agree to have read this project Security Policy

Description
No response
👟 Reproduction steps
Add 40+ URLs
👀 Expected behavior
Home page should load
😓 Actual Behavior
Not able to see any URLs
🐻 Uptime-Kuma Version
1.23.11
💻 Operating System and Arch
Ubuntu 24
🌐 Browser
Chrome - Latest
🖥 Deployment Environment

Runtime:
Database:
Filesystem used to store the database on:
number of monitors:

📝 Relevant log output
No response

Had the same issue.
This is (i believe) because of the database being too big. After like 500MB it will start to lag extremely hard and the page will become very unresponsive because...
No idea.
Either try to decrease all of your Heartbeat Intervals or decrease your Monitor History and then try to shrink your database. This should help. Now, my databases is like ~240MB and it works fine.

Please see #4500 for recommendations how to get around the performance limitations if V1. You are likely using pretty slow disks when you are hitting this at 40 monitors.
Without further evidence to the contrary, I think this is done.
=> Closing as resolved


Particl Copay stopped showing USD value / transaction history

Particl Copay on Android 10 / Galaxy S10+ stopped showing USD value and transaction history.
This is also happening when the wallet is imported on a new fresh installed device.

Another user reported the absence of the transaction history on iOS.

thanks @levd, we are working on updating the copay app, and at the same time we have to move away from coinmarketcap.com


BibSched: monitor termination after timeout

Originally on 2013-04-04
The bibsched monitor is basically always started via an SSH connection. If this drops (and the admin has not used tools such as screen, the bibsched process will stay there running idle forever (consuming SQL connection and resources).
It would be nice if there was a timeout (e.g. 24 hours) after which, if no key is pressed, the monitor terminates on its own.

I guess the admins usually use screen or tmux to prevent this issue.


Use aria-labelledby to associate form-text (helper) with input field …

…when it contains mandatory info (e.g. data format)
Description

In order to ensure that user will have all the needed information with a screen reader, it could be better to link form-text (helper text) to input with aria-labelledby (instead of aria-describedby) when it contains mandatory information, like data format. When helper text is not so important, it can still be linked with aria-describedby.

the first example (exampleInputEmail1) stays with aria-describedby
the Bootstrap callout "Associating form text with form controls" has been updated to explain when aria-labelledby or aria-describedby should be used
the examples below (inputPassword5 and inputPassword6) now use aria-labelledby
the example in input-group should be linked to input with aria-describedby

Motivation & Context

This PR is coming form an exchange with @aniort, Orange accessibility expert.
It is due to the fact that aria-labelledby is better supported by all assistive technologies than aria-describedby, and that reading of aria-describedby may be disabled, depending on settings.
Type of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactoring (non-breaking change)
[ ] Breaking change (fix or feature that would change existing functionality)

Checklist

[x] I have read the contributing guidelines
[x] My code follows the code style of the project (using npm run lint)
[x] My change introduces changes to the documentation
[x] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] All new and existing tests passed

Live previews

https://deploy-preview-37587--twbs-bootstrap.netlify.app/docs/5.2/forms/overview#form-text

incidentally, would love more information on the assertion that

aria-labelledby is better supported by all assistive technologies than aria-describedby


virtual: add initializingworkspaces endpoint

virtual: add initializingworkspaces endpoint
This endpoint shows a client the ClusterWorkspaces which are
a) initializing
b) waiting for the client's initalizer to be removed
This endpoint is accessed under
/services/initilizingworkspaces/
Signed-off-by: Steve Kuznetsov<EMAIL_ADDRESS>
based off of #https://github.com/kcp-dev/kcp/pull/1140
/assign @sttts @ncdc
Follow-ups:

[ ] add authz
[ ] allow access to workspace contents

@sttts I'm now somehow not using the resource schemas helper correctly after your changes, get:
        	            	Internal error occurred: unable to determine API definition set: version "" not found in APIResourceSchema |internal.clusterworkspaces.tenancy.kcp.dev

What is this?

Fixed in https://github.com/kcp-dev/kcp/pull/1150. But as I commented, don't call that function. It is not meant for non-golang APIs from kube. Do the trivial mapping from our CRD fixture to APIResourceSchema.

@sttts that did not fix it, but I will try fetching the CRD.

but I will try fetching the CRD.

Was even thinking about not fetching, but just taking the fixture embeded in the config/crd package. Fetching live from the cluster is not any better.
Having said that, we really want proxy-only storage for these types, especially without pruning.

Pushed the oneliner fix. Otherwise it looks good. Approving.

New tests added in this PR are failing

Changed the tests to just expect an event with the correct UID and event type, there are too many other actors here to make any non-flaky statement about the content of the object.

Whelp looks like auto-merge picked it up now that the tests are no longer flaky.


Train motor AutoID/resistor?

Hi Jorge,
Do you happen to know/are you able to measure the resistance for the AutoID on the train motor?
I ask as using a 2k2 resistor should mimic a WeDo motor, but when used with a Powered UP controller, this will result in "bang-bang" style on/off operation. If we can mimic a train motor instead, then it will allow continuous variable power to be provided when using a PUP controller.
Cheers,
Nathan

Yes:
3 to 6 and 4 to 5 (no resistors, just shunts)
On Thu, Aug 9, 2018 at 1:45 PM Nathan Kellenicki<EMAIL_ADDRESS>wrote:

Hi Jorge,
Do you happen to know/are you able to measure the resistance for the
AutoID on the train motor?
I ask as using a 2k2 resistor should mimic a WeDo motor, but when used
with a Powered UP controller, this will result in "bang-bang" style on/off
operation. If we can mimic a train motor instead, then it will allow
continuous variable power to be provided when using a PUP controller.
Cheers,
Nathan
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/JorgePe/BOOSTreveng/issues/31, or mute the thread
https://github.com/notifications/unsubscribe-auth/AICXa9VNhR0lXv6WTmNmM_0TmRF9xBWwks5uPC7xgaJpZM4V1oEB
.

Aha thank you!
Do sensors and the Boost motor adhere to the same resistance based system, or do they have a more advanced handshake?

I see, I figured it was slightly more complex for those types of devices. I don't have much hardware experience so I'll have to make myself happy with the simple AutoID's of the wedo/train motors. :) Mimicking a train motor will suffice for the conversion cable I plan on making (since Lego has disappointingly said they won't be making one...)
Thanks!


Obsolete GO:0006927 transformed cell apoptotic process?

[Term]
id: GO:0006927
name: transformed cell apoptotic process
namespace: biological_process
def: "Any apoptotic process in a transformed cell, a cell that has undergone changes manifested by escape from control mechanisms, increased growth potential, alterations in the cell surface, karyotypic abnormalities, morphological and biochemical deviations from the norm." [GOC:jl, GOC:mtg_apoptosis, MeSH:C04.697.152]
synonym: "apoptosis of transformed cells" EXACT []
synonym: "killing transformed cells" EXACT []
synonym: "programmed cell death of transformed cells by apoptosis" EXACT []
synonym: "programmed cell death, transformed cells" EXACT []
synonym: "transformed cell apoptosis" NARROW []
synonym: "transformed cell programmed cell death by apoptosis" EXACT []
is_a: GO:0006915 ! apoptotic process
(The apoptosis dbxref was added because ‘apoptosis’ in the term name was changed into ‘apoptotic process)
The process described doesn’t sound like something we’d want to capture in GO. I realise that a significant fraction of experiments are conducted on cells in culture, and that these have necessarily undergone some sort of transformation to be able to grow in monolayers in a Petri dish, but I thought the guideline was to capture such experiments only when authors use cultured cells as a reasonable substitute for normal cells. If we state explicitly that the cells have no resemblance with normal ones, I believe we’ve gone beyond the scope of GO, and I think the term should be obsoleted.
The term was created a long time ago (2001), I suspect as part of an alignment to MeSH; it has 7 manual experimental annotations. I haven’t looked at them but I suspect that they should either be deleted, or moved to GO:0006915 apoptotic process (or to appropriate children thereof), based on the guideline above if that is correct.
@cmungall , @ukemi ,
I’m not aware of any particular reason to maintain MeSH mappings, but I don’t have the historical memory required. Could you please confirm?
@RLovering ,
could you please check the BHF-UCL annotation to P01375 and the HGNC annotation to Q07812.
@hdrabkin , @ukemi ,
could you please check the MGI annotation to P25446.
@mcourtot ,
could you please check the UniProt annotations to P62746, Q496M5, Q4FZD7 and Q96A26.
Many thanks to all!

Obsoletion email sent today.

Done.


Feat/opv3 wsteth

Need a review on test, proposal fail when test is run.
src/test/optimism/AaveV3OPWSTETHPayloadTest.t.sol


Given a point and a distance, is it possible to compute the corresponding extent ?

Hello,
I am trying to compute the extent ((latMin, latMax), (lngMin, lngMax)), from a point (Coordinate object) and a distance.
Is there an easy way to do that ? I am not familiar with GPS coordinates yet.
Thank for your time.

What do you mean with “extend”? Does the following sketch show the wanted values of ((latMin, latMax), (lngMin, lngMax))?

Yes, you correctly understood what I meant.
Here is another schema if needed:

It should be easy to do using destination point calculation:
<?php

use Location\Bearing\BearingEllipsoidal;
use Location\Coordinate;

require_once __DIR__ . '/vendor/autoload.php';

$berlin   = new Coordinate(52.5, 13.5);
$distance = 10000; // 10 km

$bearingEllipsoidal = new BearingEllipsoidal();

$northernMost = $bearingEllipsoidal->calculateDestination($berlin, 0, $distance);
$easternMost  = $bearingEllipsoidal->calculateDestination($berlin, 90, $distance);
$southernMost = $bearingEllipsoidal->calculateDestination($berlin, 180, $distance);
$westernMost  = $bearingEllipsoidal->calculateDestination($berlin, 270, $distance);

printf(
    'latMax=%f, latMin=%f, lngMax=%f, lngMin=%f%s',
    $northernMost->getLat(),
    $southernMost->getLat(),
    $easternMost->getLng(),
    $westernMost->getLng(),
    PHP_EOL
);

// verify the results:

$distCalc = new \Location\Distance\Vincenty();

printf(
    'dN=%f, dS=%f, dE=%f, dW=%f%s',
    $berlin->getDistance($northernMost, $distCalc),
    $berlin->getDistance($southernMost, $distCalc),
    $berlin->getDistance($easternMost, $distCalc),
    $berlin->getDistance($westernMost, $distCalc),
    PHP_EOL
);

The code above will produce the output below:
latMax=52.589865, latMin=52.410133, lngMax=13.647253, lngMin=13.352747
dN=10000.000000, dS=10000.000000, dE=10000.000000, dW=10000.000000

Thanks @mjaschen, It works like a charm !


issues with "go build ./..."

Thanks for sharing the codes. However, I was not able to run go build. I installed "go" from https://golang.org/dl/, and cd Clinical-Trial-Parser. Do you have more guidance on how to setup $GOPATH? Thanks!
src/cmd/cfg/main.go:13:2: cannot find package "github.com/facebookresearch/Clinical-Trial-Parser/src/common/conf" in any of:
/usr/local/go/src/github.com/facebookresearch/Clinical-Trial-Parser/src/common/conf (from $GOROOT)
/Users/xxx/go/src/github.com/facebookresearch/Clinical-Trial-Parser/src/common/conf (from $GOPATH)

Yes, please see the developer guide or #1.

thank you!


Add WebSocket reconnect functionality to dioxus-liveview

This adds functionality to dioxus-liveview needed for automatically reconnecting when the WebSocket was closed for any reason.
IMO, this is both important for production and for developer experience.
This PR in combination with cargo watch also enables an easy way to get hot-reloading/live-reloading working – for example, via cargo watch --exec run --delay 0.1 --clear.
Getting live-reloading working was my initial goal, but it turned out that automatic WebSocket reconnecting was the only missing part.
When cargo watch detects a change to the application source code, recompiles it, and then restarts the server, the WebSocket connection is closed. After the server successfully is restarted, the WebSocket client (which polls the server) reconnects again, which will trigger a full re-render of the app.
Please let me know if my implementation is appropriate, and you are interested in merging it into dioxus-liveview.
There are still a few things to do, but I first wanted to get some feedback on this PR.
There are also a few decisions to make, where I was not sure what would be ideal.
Please see the comments marked with TODO.

It probably makes sense to move some comments, that are not specific to certain lines of code, here, so they are easier to discuss. I therefore removed those comments, and added them below (with some more comments/ideas).

Ideally, there would be a way to set up an action that is sent from the server to the client after a connection is established, which is executed on disconnects (e.g., to display a message that says that the server can't be reached). Is there already such functionality? If not (and it would be difficult to implement), this can be added via a different PR (probably by someone else). I think, this could be as simple as "On disconnect, set element $selector to $rsx"

Similarly important would be, to signal to the app itself that the client disconnected (i.e., to the programmer of the app). Otherwise, it's not possible to save the current state of the user.
Ideally, it would somehow be possible to restore the state before the disconnect, when a client reconnects. At the moment, the app is just re-rendered in the browser, which leads to bad user experience (e.g., for end-users with spotty internet connections).
What would be a good way to restore state after reconnects? Could the reconnecting client send something to the server that would result in the restoration of the state? This seems slightly similar to rehydration.

It seems, the last two sections are also relevant to other renderers.
For example, let's say, the backend of an dioxus-desktop app panics, and the connection to the WebView is severed – what would happen?
Can Dioxus run in a thread that's not the main thread, which would mean that Dioxus can crash, without the program being closed?
I imagine, the UI would just freeze, then.
With a disconnet event handler (provided at startup, either by the user, or a default one), the UI/interpreter at least could display an error.
Similarly, if there is a bug in the interpreter that powers dioxus-desktop, the UI could crash/freeze (and disconnect from the backend), in which case the backend should be able to save the current state of the app.
Therefore, it would make sense to implement such error handling functionality globally for all renderers.
Please let me know if that makes sense. I will then open a separate issue with the above information.

From the source code:

Browsers log un-catchable errors to the developer console, when network requests fail. Those errors will potentially be logged many times until we successfully reconnect. Unfortunately, there doesn't seem to be a good way to avoid this. To not add to the noise with our own log messages, we'll not log anything while reconnecting.

I've read, that WebWorker network errors will not be logged to the developer console. So moving parts of this script to a WebWorker might be a solution.
However, that seems to add too much complexity, to be a reasonable option, IMO. With incremental re-compilation and the retry delay settings (below the above comment) the situation doesn't seem to be too bad.
Should I still try to create a WebWorker to try to suppress those errors?
Currently, the following is logged, with incremental recompilation (I've added support for logging, in Debug mode):
[Dioxus] WebSocket closed – code: [1006], reason: []
[Dioxus] Attempting to reconnect
[Dioxus] Note: WebSocket errors will be logged below, until we are able to reconnect:
> WebSocket connection to 'ws://<IP_ADDRESS>:3030/ws' failed:
> WebSocket connection to 'ws://<IP_ADDRESS>:3030/ws' failed:
> WebSocket connection to 'ws://<IP_ADDRESS>:3030/ws' failed:
> WebSocket connection to 'ws://<IP_ADDRESS>:3030/ws' failed:
> WebSocket connection to 'ws://<IP_ADDRESS>:3030/ws' failed:
[Dioxus] Connected to WebSocket

(The WebSocket connection to lines are displayed red (i.e., as error). That's the part that can't be suppressed)
...which doesn't seem too bad. But if the client can't reconnect for a few minutes, there would be hundreds of errors.

Should 'WebSocket auto-reconnect' be optional via a Cargo feature flag? It does seem to be very useful in both, production and while developing. However, it is a feature that might send many requests to the server, which might be unexpected. I think, having it always active and configurable (at runtime), and documenting the behavior would be the way to go.

Thanks for the PR! This is definitely something that's missing, and hasn't been something we approached due to all the complexities you've discovered.
With complex enough JS on the client, I don't think you need a web worker. Can't we just handle the disconnect and try to loop re-connect?
IE
loop {
    try {
        connect().await;
        liveview_loop().await;
    } catch (err) {
       // connection lost, wait some time before trying again
    }
}

I imagine the same thing could be added to all the interpreters instead of using the global callback thing currently in place.

That being said, it'd be very nice to have a handler on the server side that, like you said, could wait for a connection to be disconnected and give it maybe 30 seconds before serializing the state or just killing the app.
It would also mean we need to somehow indicate to the client that its state on the server was killed and it should just try to reload or wipe the page since the UI is likely out of sync.

Thanks for evaluating my PR, @jkelleyrtp.
My description above probably wasn't very good, and I'd like to clarify a few things:

With complex enough JS on the client, I don't think you need a web worker.

So this PR works already perfectly fine (for the hot-reload use-case, some stuff is missing for production).
You can give it a try by following the following steps:

git clone https://github.com/d4h0/dioxus
cd dioxus/packages/liveview/
git switch liveview-ws-reconnect
cargo run --example axum --features axum
Go to http://<IP_ADDRESS>:3030, and then open the DevTools Console

If you now close the server, you will see that the client tries to reconnect, which should work when you start the server again.
As you can see, there are some errors logged to the console (i.e., WebSocket connection to 'ws://<IP_ADDRESS>:3030/ws' failed).
These errors are specific to the DevTools Console (i.e., JavaScript has no access to them, and can not suppress them).
To demonstrate that, please run the following code in the DevTools Console:
await fetch("http://wecewcfwecfewfc.com").catch(e => console.log("catched!"))

As you can see, we catch the error (catched! is logged), but there is still an error logged: GET http://wecewcfwecfewfc.com/ net::ERR_NAME_NOT_RESOLVED.
As mentioned, such network errors can't be suppressed from JavaScript, which isn't ideal, because we have to poll the server many times until we potentially reconnect.
This might confuse or annoy users of Dioxus, but there isn't anything we can do about it.
The only potential solution I've seen, is to do the polling in a WebWorker. According to the comment I saw, network errors of WebWorkers are not displayed in the DevTools Console (but I haven't tried that yet).
I think, the added complexity of a WebWorker, just to avoid those errors, isn't worth it.
But if you think it is, I'll give it a try.

Can't we just handle the disconnect and try to loop re-connect?

Yes, that's exactly what the JavaScript client does :)
Unfortunately, WebSockets are callback-based, not Promise-based, so async/await can't be used.

I imagine the same thing could be added to all the interpreters instead of using the global callback thing currently in place.

Can you explain that a bit more? As far as I know, only dioxus-liveview uses WebSockets (dioxus-desktop seems to use the interprocess, which makes much more sense than WebSocket, for desktop apps).
At this point, I have only read the guide, created a simple hello-world app, and looked at the source code of dioxus-liveview, so I might miss something.

That being said, it'd be very nice to have a handler on the server side that, like you said, could wait for a connection to be disconnected and give it maybe 30 seconds before serializing the state or just killing the app.

As mentioned above, I haven't really used Dioxus, so the following might not make much sense.
I think, we should just signal the disconnect to the app, and let the programmer handle that situation.
Something like this:
use dioxus::prelude::*;

pub fn run(cx: Scope) -> Element {
    // Setup an action that will be executed by the client on disconnects:

    // (This would be sent to the client when the connection is established)

    set_client_disconnect_action(&cx, "#css-selector", || rsx! {
        "Server can't be reachead! Trying to reconnect..."
    });

    // ^ On disconnects the client will replace `innerHtml` of `#css-selector`
    // with the HTML generated by `rsx!`

    // Maybe we also should support custom JavaScript:

    let js = DangerousJs("alert('Server can't be reachead! Trying to reconnect...')");

    // ^ `DangerousJs` makes it clear that care is needed to prevent
    // Cross-Site-Scripting vulnerabilities, etc.

    set_client_disconnect_js_action(&cx, js);

    // Handle disconnects and reconnects on the server:

    let user_id = get_user_id();
    let state = use_state(&cx, move || get_user_state(user_id));

    on_disconnect(&cx, move || save_user_state(user_id, state));
    on_reconnect(&cx, move || state.modify(|state| *state = get_user_state(user_id));

    // To enable handling disconnects after a delay, the following API could be offered:

    let delay = std::time::Duration::from_secs(30);

    on_disconnect_with_delay(&cx, delay, move || todo!());

    // `delay` could be `Into<DisconnectDelay>`, which would be implemented for
    // `Duration` and `i32` (which would be converted into a `Duration` value,
    // e.g. via `Duration::from_secs`), so the following would be possible:

    on_disconnect_with_delay(&cx, 30, move || todo!());

    cx.render(rsx! {
        div {
            "Hello, world!"
        }
    })
}

It would also mean we need to somehow indicate to the client that its state on the server was killed and it should just try to reload or wipe the page since the UI is likely out of sync.

So right now, the app is re-rendered on every reconnect (innerHtml of root is set to ""). And one of my goals is to properly restore the server state.
This probably will involve that clients get an ID (e.g., a UUID), that is used to communicate between client and server (so that a client can be linked to a session).
With such an ID it should be easy to tell the client if its server state was deleted.
However, I think that logic should ideally be handled on the server. The client sends its session ID to the server, and the server sends the appropriate edits (so that we don't need to set innerHTML of root to "" on the client).

@jkelleyrtp: I realized that setting root.innerHTML to "" does not work (this seems to crash the Interpreter if some actual changes happen). I'm now trying to figure out how to properly manage the state across reconnects.
Also: I will add a builder to configure the generation of the interpreter glue. This makes it possible to configure how/if reconnects happen, and can be used to support features like https://github.com/DioxusLabs/dioxus/issues/736.
After that, or if I hit some problem I don't know how to overcome, I'll re-summarize the situation here (but feel free to add suggestions, if you have some).

Quick update: I'm still working on this, and went through a couple iterations already. Some unforeseen complexities gave me a bit of a headache, but my last version seems to work well. I have an idea to make things more flexible, and will explore that route next week. I guess, after that I'll have something to show.

@jkelleyrtp: The code is now ready to be reviewed.
In this comment I'll give you a high-level overview of the current state of the PR.
Before I start, I'd like to add a few warnings:

I discovered a few issues with the previous code which I've fixed (e.g. there was no proper error handling, WebSocket messages where just converted to strings, which resulted in close messages being ignored, and silently ignored messages in general). At some point I started to consider this PR as a complete rewrite of the previous code. There are not many lines left that existed before this PR.

I basically never have worked with other people on software projects before (besides a few small PRs), which means A) I wasn't forced to learn Git (i.e. I have almost no Git skills), and B) I might have done things that are inappropriate. Please let me know if there are any issues in this regard.

English isn't my native language, so the names I've chosen might not be good. Feel free to tell me if there is anything that could be named better (or just rename it). I've used cargo spellcheck, so hopefully there are not too many spelling errors.

With that being out of the way, I discovered two issues in regard to letting clients automatically reconnect:
Issue 1: In a distributed system (i.e. more than one server), clients might reconnect to a different server.
Because of that, I quickly gave up the idea to automagically store and restore the state in Dioxus. Instead, I've implemented simple tools that users can use to store/restore state:

A use_disconnect_handler hook, that provides a callback to Dioxus, which is called after a client disconnects (and can be used to save the state). Every component can have one or more handlers.

A ClientStatus enum is provided via get_client_status, which can be used to detect if a client is connecting or reconnecting (e.g. to restore state when a client reconnects).

A use_disconnect_client_actions hook, which can be used to define actions that will be executed on the client, after the connection is lost. This can be used, for example, to display a warning message, or to disable form element to prevent data loss.

With those tools, users are able to implement proper session management (e.g. via Redis or a database, in a distributed system).
A previous iteration also implemented this session management itself (i.e. it sent a session ID to the client, which it had to provide to the server when reconnecting).
However, it turned out, that it is better if the user handles the session management. This is both more flexible and more secure (because the user can use secure, HTTP-only, encrypted cookies to assign session IDs to clients. What I had implemented stored the session ID via JavaScript, in memory).
Issue 2: Saving state if the server crashes or restarts.
Basically, this is pretty hard to archive. At the moment, the best way to archive this, is to just save important state (e.g. form data) after every change. There is a comment somewhere in the code where I discuss this in more detail, and what potential options I see.
Besides the above tools, I've added/changed the following things:

I've added a proper error type (previously, the error type had only one SendingFailed variant, without any information, that was returned for every failure)

Adapters now need to produce/consume a WebSocketMsg enum (instead of producing/consuming strings). I've done this to properly handle WebSocket close messages (previously, close message were converted to an empty string, which wasn't handled, which both isn't great)

main.js was rewritten to enable automatically reconnecting, logging, and client-side actions

Besides interpreter_glue there now also is InterpreterGlueBuilder, which can be used to configure the generated JavaScript code

I've added a comprehensive example that demonstrates session management (sessions.rs)

What is missing?
There are a few things that I'd like to implement only after I got some feedback from you:

Updating/adding/finishing the documentation
I've only ported the Axum adapter (but I looked at the docs of Warp and Salvo, and porting those adapters shouldn't be a problem)
Updating the examples (there might be some minor things to do)
A few minor things marked by TODO comments (however, I'm not planning to address all TODO items with this PR. This PR is probably already way too big)

There are also comments marked with XXX, which directly address you, and where I'd like to get feedback from you.
Besides general feedback regarding the approach I've chosen, some of those XXX comments (or rather the issues they talk about) are important for finishing this PR. I've tried to decide as much as I could, but a few times I wasn't sure what the best approach would be.
Recommended review order
I thought, maybe it would be useful to give you a plan to review this PR. I'd do it in this order:

examples/session.rs: This will give you another high-level overview of what is going on
lib.rs: Mostly, the error type and the new glue code builder
adapters/mod.rs: The updated adapter traits, and the new WebSocketMsg type
adapter/axum_adapter.rs
hooks.rs: The functions here are all pretty simple, but there are some important comments
pool.rs
main.js

As I wrote above, there are not many lines left from the previous version of the code. So I don't think it would make sense to view Git diffs. I'd just clone my repo and review it in an IDE with Rust-Analyzer.

There seem to be some merge conflicts. I'll try to resolve them next Tuesday.

Alright, I've fixed the merge conflicts. This was the first time that I have resolved conflicts, so I hope this was done correctly.

@Demonthos: There were two issues with the hot-reload feature you have added to liveview (which I have just merged into my branch):

The hot-reload feature was added to the default features, which resulted in 100% of the CPU being used. I guess, because the hot-reload macro isn't executed anywhere in the code I use for testing (so the hot-reload server channel always returns None).

Compilation failed if the default features were disabled because some code that depends on dioxus_hot_reload wasn't guarded by the hot-reload feature flag.

I have removed hot-reload from the default features, and I've put all code that depends on dioxus_hot_reload behind the feature flag (see my last commit above).
When I merged the hot-reload changes I was already planning to propose to not add hot-reload to the default features. I think this incident is a good example for what could happen (it also doesn't feel right to have development features in the list of default features).
You might want to check the other places, where you have added the hot-reload functionality, for the above issues.
Ideally, the hot-reload functionality would check if the server is running, and panic if it does not.

@Demonthos: There were two issues with the hot-reload feature you have added to liveview (which I have just merged into my branch):

The hot-reload feature was added to the default features, which resulted in 100% of the CPU being used. I guess, because the hot-reload macro isn't executed anywhere in the code I use for testing (so the hot-reload server channel always returns None).

Compilation failed if the default features were disabled because some code that depends on dioxus_hot_reload wasn't guarded by the hot-reload feature flag.

You might want to check the other places, where you have added the hot-reload functionality, for the above issues.

Thanks for letting me know about these issues. I think both of these issues should be fixed in https://github.com/DioxusLabs/dioxus/pull/818. I moved the match into the future select so it will only resolve the future and update the vdom if the channel is connected which should resolve the performance issues.

I have removed hot-reload from the default features, and I've put all code that depends on dioxus_hot_reload behind the feature flag (see my last commit above).
When I merged the hot-reload changes I was already planning to propose to not add hot-reload to the default features. I think this incident is a good example for what could happen (it also doesn't feel right to have development features in the list of default features).

Here is my reasoning behind enabling the hot-reloading features by default:

It makes it easier to get started with hot reloading: You just need to call the macro without changing the Cargo.toml
It is also only enabled in debug builds. For me this is similar to having more extensive checking in debug mode: It makes the developer experience better by default, and you don't need to pay the runtime costs in release builds.
I think for most cases having hot reloading enabled in debug mode is beneficial. The feature is pretty new, so there could be bugs like this, but users can always disable the default features and enable them manually if there is an issue with the feature. We could disable it as a default feature until it is more stable, but in the long term I think it should be enabled by default.

It could also be useful to get some broader community feedback on how hot reloading should work through a poll:

Should the configuration be in rust code or in a .toml file?
Should we use the macro approach for hot reloading, the dioxus cli, or both?
Should hot reloading be enabled by default?
Other issues, or suggestions for hot reloading?

Ideally, the hot-reload functionality would check if the server is running, and panic if it does not.

I don't think the code should panic if hot reloading fails to connect. If it does not connect, it is not an issue with the users code, but with the library. We should provide some feedback to the user, but I don't think panicking is the right solution here. Currently, hot reloading logs when it successfully connects, we could add a different log if it fails to connect after a certain amount of time.

I think both of these issues should be fixed in https://github.com/DioxusLabs/dioxus/pull/818.

Yes, that should fix it.

Here is my reasoning behind enabling the hot-reloading features by default:

Alright, I'm not completely against it. It just feels a bit wrong to add a developer feature to the default features. But maybe it's a worthy compromise.

This is probably silly, but just in case it isn't, because liveview is a server and performance is important – do you think the following would make any significant difference?
    // #1: Moving `Pending` out of the loop:
    #[cfg(not(all(feature = "hot-reload", debug_assertions)))]
    let hot_reload_wait: std::future::Pending<Option<()>> = std::future::pending();

    loop {
        #[cfg(all(feature = "hot-reload", debug_assertions))]
        let hot_reload_wait = hot_reload_rx.recv();

        tokio::select! {
            // ..

            // #2: Using a condition that is always `false`, if `hot-reload` is disabled:
            Some(msg) = hot_reload_wait, if cfg!(all(feature = "hot-reload", debug_assertions)) => { .. }
        }
    }

This is probably silly, but just in case it isn't, because liveview is a server and performance is important – do you think the following would make any significant difference?
    // #1: Moving `Pending` out of the loop:
    #[cfg(not(all(feature = "hot-reload", debug_assertions)))]
    let hot_reload_wait: std::future::Pending<Option<()>> = std::future::pending();

    loop {
        #[cfg(all(feature = "hot-reload", debug_assertions))]
        let hot_reload_wait = hot_reload_rx.recv();

        tokio::select! {
            // ..

            // #2: Using a condition that is always `false`, if `hot-reload` is disabled:
            Some(msg) = hot_reload_wait, if cfg!(all(feature = "hot-reload", debug_assertions)) => { .. }
        }
    }

I would imagine it does not make much of a difference, but if you are still seeing performance issues in that area, you could try it. It could be more clear what the code was doing if we make two entirely separate switch statements depending on the features enabled, and the release build would not be polling any extra futures.

Alright. If I ever build something with Dioxus-Liveview that gets significant traffic, I'll probably anyway do some general profiling and benchmarking. Better to wait until then, before making the code more complex.

@jkelleyrtp: Do you have any idea when you will be able to have a look at this? See my previous comment, in case you missed it.
If there is an issue with what I came up with – even if it is fundamental – just let me know.

Due to the lack of feedback, and me therefore losing interest in working on this, I'll close this PR now. If anybody wants to continue, they can fork my branch (which I will not delete, for now).


Use status bar entry for creating pull request

As is, any time I push a new branch I get a notification asking me if I want to make a PR, this is sometimes helpful but sometimes annoying. I can choose to not see it again, but then I don't get it in the cases where I actually do want to make a PR.
I propose using the status bar to show a "Create Pull Request" message, in place of where the "Pull request #11111" message is now for branches that do have an associated PR:

We have several other places we show a "create" button: in the PR view, in the SCM view, and in the command palette. Since the buttons are more contextual that the status bar, they seem like a better place.


Handle interrupted exception during Kinesis rate limit

Currently if the primary thread is interruptted (either due to fetchTimeout or some other reason), the Thread.sleep throws an InterrupttedException which isn't handled. This leads to consumer not able to proceed beyond a certain number of records.
The solution is to simply handled the exception. The exception is also caught outside the Kinesis exceptions because we don't need to LOG it really and only use it to break the while loop. That is the behavior we do while checking for Thread.interrupted as well.

Codecov Report

Merging #10297 (66cf150) into master (a016255) will decrease coverage by 56.68%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master   #10297       +/-   ##
=============================================
- Coverage     70.36%   13.69%   -56.68%
+ Complexity     5827      182     -5645
=============================================
  Files          2016     1962       -54
  Lines        109635   107181     -2454
  Branches      16680    16388      -292
=============================================
- Hits          77145    14676    -62469
- Misses        27073    91340    +64267
+ Partials       5417     1165     -4252

Flag
Coverage Δ

integration1
?

integration2
?

unittests1
?

unittests2
13.69% <0.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...e/pinot/plugin/stream/kinesis/KinesisConsumer.java
32.78% <0.00%> (-1.12%)
:arrow_down:

...src/main/java/org/apache/pinot/sql/FilterKind.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ain/java/org/apache/pinot/core/data/table/Key.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...in/java/org/apache/pinot/spi/utils/BytesUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ain/java/org/apache/pinot/common/CustomObject.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...n/java/org/apache/pinot/core/data/table/Table.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../java/org/apache/pinot/core/data/table/Record.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../java/org/apache/pinot/core/util/GroupByUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...java/org/apache/pinot/spi/trace/BaseRecording.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...java/org/apache/pinot/spi/trace/NoOpRecording.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 1586 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


CSS Type Object Model update

Target Live Date: 2018-03-26

[x] This has been reviewed offline and approved by Phil, @mathiasbynens , eng
[ ] I have run gulp test locally and all tests pass.
[x] I have added the appropriate type-something label.
[x] I've staged the site and manually verified that my content displays correctly.

CC: @petele

Ready to go on 3/26

:tada: This has been pushed live to https://developers.google.com/web/


CORE-1311: add new features to CanvasKit ...

... to support hard line break styles.
The HardLineBreakStyle can be used to implement mixed alignment, indent, and list in one single pargraph.
We used to implement these features in JavaScript side with a grid of paragraphs. That leads to poor performance especially the layout is called very frequently for auto font sizing. With one single paragraph supporting these features the layout performance improves dramatically.

The usage is in this PR: https://github.com/Bluescape/web-frontend/pull/17695