[1.3] Bump netty to match version from core's buildSrc/version.properties and bump grpc to 1.56.1

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
This PR will match the build.gradle file on main here: https://github.com/opensearch-project/performance-analyzer-rca/blob/main/build.gradle#L373-L377
The dependencies on main should be updated or dependabot added to this repo if its not enabled already.
Without this change performance-analyzer-rca is being bundled with netty-codec-http-4.1.87.Final.jar, netty-codec-http2-4.1.87.Final.jar and netty-handler-4.1.87.Final.jar which are affected by https://avd.aquasec.com/nvd/cve-2024-29025, https://github.com/advisories/GHSA-xpw8-rcwv-8f8p and https://avd.aquasec.com/nvd/cve-2023-34462 respectively.
Check List

[ ] Backport Labels added.
[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

sgup432 can you please review it?

@cwperks
I see main branch has implementation 'io.grpc:grpc-stub:1.52.1', do we need to update it to 1.56.1 there as well?

@sgup432 Yes, main needs to be updated as well. I opened up a PR to add dependabot to automatically monitor for outdated dependencies and create PRs.
In the previous commit I made this PR exactly match main and it gave the following error:
Execution failed for task ':updateShas'.
> Could not resolve all dependencies for configuration ':runtimeClasspath'.
   > Conflict(s) found for the following module(s):
       - io.grpc:grpc-api between versions 1.56.1 and 1.52.1
     Run with:
         --scan or
         :dependencyInsight --configuration runtimeClasspath --dependency io.grpc:grpc-api
     to get more insight on how to solve the conflict.

ref: https://github.com/opensearch-project/performance-analyzer-rca/actions/runs/8761123266/job/24047189857?pr=546


Dashboard empty after upgrade from 2.15 to 3.0.3

Hi, missing all clusters and dashboard is now empty... any missing step?
Suggestion: it would be nice to have update guide in documentation...

@Povezi Maybe you shoude  clear chrome/firfox cache，then Refresh

No response. Closing as stale.


enchantment_module.cfg not working 1.16.5

I'm trying to make it so I can combine books like experience boost IV together to make experience boost V but none of the changes I make in enchantment_module.cfg works.. the enchantments I try to blacklist doesn't get blacklisted either.
Configuration file
general {
# If cobwebs can be used in anvils to remove enchantments. [default: true]
B:"Enable Cobwebs"=true
# A list of enchantments that are banned from the enchanting table and other natural sources. [default: ]
S:"Enchantment Blacklist" <
minecraft:thorns
minecraft:infinity
minecraft:fire_aspect
minecraft:multishot
minecraft:flame
vanillatweaks:siphon
vanillatweaks:blazing
vanillatweaks:hops
vanillatweaks:veteran
vanillatweaks:vigor
vanillatweaks:homing
astralsorcery:scorching_heat
cyclic:life_leech
charm:acquisition
charm:aerial_affinity
 >

# If any two enchanted items can be combined in an Anvil. [default: false]
B:"Item Merging"=true

# The maximum enchantment power a table can receive from normal sources. [range: 0.0 ~ 3.4028235E38, default: 20.0]
S:"Max Normal Power"=50.0

# The maximum enchantment power a table can receive. [range: 0.0 ~ 3.4028235E38, default: 75.0]
S:"Max Power"=150.0

}

MC versions <= 1.16 are not supported


Adding custom location make proxy host offline

Checklist

Have you pulled and found the error with jc21/nginx-proxy-manager:latest docker image?

Yes

Are you sure you're not using someone else's docker image?

Yes

Have you searched for similar issues (both open and closed)?

Yes

Describe the bug
When adding a custom location to add cors headers the proxy host became offline:
Nginx Proxy Manager Version
2.11.1

Can also confirm that this is still an issue and looks to have been one for months now. The popular solution  does not seem to work for me running in docker. Will this be addressed in the next production release?

For docker based npm installations a downgrade to 2.10.4 has worked for me.
Just stop npm, make a backup of your custom /data volume and downgrade to jc21/nginx-proxy-manager:2.10.4

Same issue, goes back to 2.10.4

I have this issue on 2.10.4.

Try 2.11.2, at least for me, that solved my issues!


Dispatch chains review and test.

This is the result of my code review and unit test of the dispatch.py module.
This is divided into a number of commits that are well isolated from each other, I recommend reviewing them individually rather than focussing on the diff as a whole.
The first commit pulls some utility functions out of endpoints.py into frules.py. This prevents an import cycle where dispatch.py needed to import endpoints.py, which needs to import dispatch.py: now both simply import frules.py. The functions that got moved were logically part of frules.py anyway.
 It takes advantage of the first commit to move an inline import up to the top of the module.
The third commit refactors the implementation and interface of DispatchChains. This class used a dictionary in its implementation, but never once accessed the values of that dictionary in order to do anything with them. As a result, I pulled that out and replaced it with a set. This obviously changed the interface as well, which no longer wants to deal with dictionaries or dict values, so I had to touch the bits of the code that touched the DispatchChains class.
Finally, I wrote UT for the end result.

Two comments added - one is really just a comment that you should consider and feel free to ignore if you like, and one needs addressing.


Motoko dip-721-nft-container example : wrong array list order access ?

Overview
I suspect a problem in the array access of this Motoko dip-721-nft-container example with List.get used.
My front-end was giving the wrong owner to a specific token id ( first of the list instead of the last ).
Requirements
Token ownership was fix after this change.
Considered Solutions
Retrieve the right item using explicit to token id match.
Recommended Solution
Retrieve the right item using explicit to token id match.
Considerations
I do not know the performance issue of this fix using List.find instead of .List.get

@branciard Thank you very much for fixing this. Much appreciated!
Could you please look one more time over here: https://github.com/dfinity/cla/issues/35, it seems like a period is missing over there. Sorry for the trouble...

CLA period done. Y're welcome @sesi200 . (Thank you for this very helpful NFTs Workshop Severin.)


fix(test): fixed arm64 tests: eBPF probe requirement is now kernel >= 4.17

What type of PR is this?
/kind bug
Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area tests
What this PR does / why we need it:
This fixes integration tests for arm64 after https://github.com/falcosecurity/libs/pull/416.
Basically, 416 fixed drivers support for arm64; unfortunately, we had to bump the minimum required version for ebpf probe and kmod; see https://github.com/falcosecurity/libs#drivers-officially-supported-architectures.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: FedeDP
To complete the pull request process, please assign dwindsor after the PR has been reviewed.
You can assign the PR to them by writing /assign @dwindsor in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dwindsor, FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [dwindsor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 8c5183c9ee8c81e41ea23876294f4b6d68ce8c91


Changes in Tooldata folder for Find Submarine Canyons, and Sub Depth Restriction Suitability

Edits include changing the folder where the support data resides. Also deleted "Sensor Viewshed" tool as it needs to be vetted before publishing.

@JudTown17


[Dubbo-2349][Baiji-3] Add english doc for rest.md and fix Chinese version

What is the purpose of the change
Add english doc for rest.md and fix Chinese version
Brief changelog
/docs/en-us/user/rest.md
/docs/zh-cn/user/rest.md
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Test your code locally by running docsite start, and make sure it works as expected.
[ ] Make sure no files under build directory is added.
[ ] If this contribution is large, please follow the Software Donation Guide.

This pr is created by Baiji 274 Group 3

I have read this document, and I learnt the principle of dubbo and how to replace Spring xml file with Java annotation.  The demos of different use of ClientResponseFilter gives us a quick stark.


Joh/diag source

Add source to diagnostic object such that user can tell what linter/language service/extension created what error, See #1010

@egamma @dbaeumer Started to flesh out the API with a simple source: string property. Question is what rendering you guys prefer in

Editor hover on diagnostics
In editor error view
error quick pick

I guess it should always be the same? And the should it be message (source) or (source) message

@jrieken @dbaeumer I prefer message (source), since the message is the primary information and the source is auxilliary, but I might revisit my opinion based on usage :smiley_cat:
What is the source for the built-in linter for JS or TS, is it empty?

I'd make them empty to begin with.

+1 for keeping them empty

Challenge is messages that end with a dot, like so:

@jrieken sorry what exactly is the issue with the messages ending with a dot.
Could we use [ ] instead of ()?
Can we use different colors when we render a marker and use blue for the source?

It does't look nice ;-) maybe a nicer different color or font style and []-brackets

Decided to put it in []-bracket in front of the message. From there on we can tweak


A question about implementation of the quantization process for latent y

Hi, thank you for great work.
I'm confused about the implementation of the quantization process in the 'quantization' method in 'EntropyModel' class.
In the method, uniform noises are added to the latent y in training stage (mode='noise'). it's fine to understand.
But in the case of 'dequantize' or 'symbols', firstly a substitution with the 'mean' values is performed and then rounding operation is performed.
I think the order of the two operation should be reversed, so that the output of the last layer of Encoder (Analysis network) is same with the input of the first layer of Decoder (Synthesis network).
Could you explain what i missed (concept or process)?
Thank you in advance.

I attach a picture simply because the explanation seems to be insufficient.

I am attaching a picture because there seems to be a lack of explanation.

It's resolved.


When requesting the wrong version of an existing file, the FileNotFoundError could be more informative.

When one tries to open a file path which exists, but provides a non-existent version_id, the operation throws FileNotFoundError containing the path.
fs.open(path, "rb", version_id=version_id)

It would be very helpful to inform that the version was not found despite the file existing.
https://github.com/fsspec/s3fs/blob/5c0541441ee37fce16df775f6954d39912f2a598/s3fs/errors.py#L79
Perhaps:
"NoSuchVersion": lambda msg, *a, **kw: FileNotFoundError(f"Non-existent version for file {msg}, *a, **kw),

or

class FileVersionNotFoundError(FileNotFoundError):
    pass
...
"NoSuchVersion": FileVersionNotFoundError,

Thank you for considering!

If the error response from S3 has this information, I agree it would be good to pass it on. A subclass of FileNotFound would indeed be appropriate, I think.

The error response from S3 has this information
I tried
try:
    s3.get_object(Bucket=bucket_name, Key=key, VersionId=version_id)
except ClientError as e:
    print(f"{e}")
    code = e.response['Error']['Code']
    print(f"Found error code {code} when trying to getObject {bucket_name}/{key} {version_id}")

I get the error
An error occurred (NoSuchVersion) when calling the GetObject operation: The specified version does not exist.
Found error code NoSuchVersion when trying to getObject <redacted>/<redacted>  <redacted>

Would you like to include a change to https://github.com/fsspec/s3fs/blob/main/s3fs/errors.py#L115 or nearby that would do this? I think it should either be a subclass of FileNotFound, or just extend the string message with the extra information.


Multiple Term queries fail in client

Please use the following questions as a guideline to help me answer
your issue/question without further inquiry. Thank you.
Which version of Elastic are you using?
[ ] elastic.v6 (for Elasticsearch 6.5)
Please describe the expected behavior
Kibana Query which works is
POST _search
{"query": {
"bool": {
"must": [
{"term":{"provided.datasetname":"scado"}},
{"term":{"provided.timeframe.issuetime":"2019-06-28T12:00:00Z"}}
] }}}
Please describe the actual behavior
Client throws error "elastic: Error 400 (Bad Request): [term] query does not support array of values [type=parsing_exception]"
Any steps to reproduce the behavior?
boolean_query := elastic.NewBoolQuery()
boolean_query.Must(elastic.NewTermQuery("field1":"scado"))
boolean_query.Must(elastic.NewTermQuery("field2":"2019-06-28T12:00:00Z"l))

boolean_query.Must(elastic.NewTermQuery("field1":["scado"])) was the issue not the client.


Fix SmartThings base_url check during startup with Cloud

Description:
Fixes an issue during startup where SmartThings falls back to checking base_url when using cloudhooks because the cloud isn't yet connected and assumed not available and added a new test for this condition.
CC @robbiet480
Related issue (if applicable): fixes #22232
Checklist:

[X] The code change is tested and works locally.
[X] Local tests pass with tox. Your PR cannot be merged unless tests pass
[X] There is no commented out code in this PR.

If the code does not interact with devices:

[X] Tests have been added to verify that the new code works.

Build failures are not related to SmartThings or this PR...  They are caused by the pulled python-tado package from pypi.


Create 2018-10-22-hackathon.md: Blog post for hackathon

Depends on https://github.com/bazelbuild/bazel-blog/pull/128

CC: @chaimhaas, @sstriker

WDYT about adding the photo from this tweet into the article?

Why not? It would put context around the post.
On Mon, Oct 22, 2018 at 3:17 PM Jingwen<EMAIL_ADDRESS>wrote:

WDYT about adding the photo from this tweet
https://twitter.com/TechAtBloomberg/status/1050415912715730946 into the
article?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/bazel-blog/pull/129#issuecomment-431944142,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AbdI8k-QbpLdiAramYe55lrKZAZq3HJFks5unhnOgaJpZM4XzY1w
.

WDYT about adding the photo from this tweet into the article?

I have the original picture (as the author of the tweet). Let me know who to send it to.

Chaim

also cc @davidstanke

Am not aware of any further outstanding issues here.

Is everyone happy? If so, I shall merge.

Good to merge?

There is a typo in the second last project mentioned -- Toolcahins -> Toolchains

https://github.com/bazelbuild/bazel-blog/pull/130


Getting the current task in PyTorch DistributedDataParallel

Hi,
I have a question about Task.current_task() method.
I am working with PyTorch and training using DistributedDataParallel, which uses multi-process and not single-process multi-thread.
The task is been initiated on the main process at the beginning, before the mp.spawn, and the processes get it by using Task.get_task(task_id). However, internally the current task does not seems to be available. How can I still get the current task in this type of setup?
Thanks!

Hi @bomri
Yes, torch distributed is fully supported (as well as other sub-process parallelization solutions)
Here is how it works, the main process (the one starting this entire flow) runs :
task = Task.init('examples', 'torch distributed')
Then any sub-process can either run:
task = Task.current_task() or even call again the Task.init(...).
The idea is that the main process passes the information to the sub-processes, that it had already initialized the Task, and what the Task.id is. This means any sub-process will just use this Task.id instead of creating a new one. As you notice the first Task.init should eb called before the mp.spawn so that all the information is passed to the sub-processes.
Make sense?
BTW:
Which OS are you using? There are a few issues with torch distributed on Windows (basically no fork...), but they are mostly torch related and not Trains related

I'm initializing the task before the spawn, but task = Task.current_task() always returns None. Running Task.init() for each process does return the same task correctly and from that point the current_task() works for internal functions.
But I get lot's of warnings like:
Task connect, second input model is not supported, adding into comment section
trains.Task - INFO - Task connect, second input model is not supported, adding into comment section
Could retrieve model location, skipping auto model logging
If I save the task_id in the main process and pass it to each process I am able to use get_task with that id and get the task properly
I am running on ubuntu 18.04

I'm initializing the task before the spawn, but task = Task.current_task() always returns None.

If the sub-process is forked (the default behavior on posix OS), all the local variables are copied to the sub-process, that includes the current_task.
However Torch distributed is creating the subprocesses with Popen, which means the current_task variable is not passed. In order for the sub-process to get it, it should basically run the same code as the main process, i.e. Task.init it will automatically get the correct task ID, as you noticed.

Task connect, second input model is not supported, adding into comment section

The warning you are getting is for loading the same model weights file multiple times (I assume from the multiple instances). Basically it says that logging the input weights is currently limited to a single weights file per experiment, and the second loaded weights file will be logged in the comment section of the experiment. I think we should check that if you are loading the same object multiple time it will know not to output the message, as it already logged the model weights and its the same one :)

If I save the task_id in the main process and pass it to each process I am able to use get_task with that id and get the task properly

Task.get_task will work regardless of anything else, and from any machine. But Task.get_task will not auto-magically collect the console outputs, TensorBoard  matplotlib etc.

upgrading to allegroai-3.2.0rc0 & trains-0.14.3, and using the exact same task init variables as in the main process seems to solve this issue.
Thanks @bmartinn for helping!

Awesome :)
Closing this issue, if the problem resurfaces, feel free to re-open.


Update Sherlock-Benchmark-10-Unicycle.jl

test for https://github.com/JuliaReach/NeuralNetworkAnalysis.jl/pull/238

Needs a rebase with master...


Fix segfault on user autocomplete in zsh

Under windows user name can contains local characters. Without metafy sometimes we get infinite loop and segfault.
Upstream commit https://github.com/zsh-users/zsh/commit/a11b241d4a5ec7ee1009905372cf32fb4538fbb3

increase pkgrel

It's done

==> Validating source files with sha256sums...
    zsh-5.3.1.tar.gz ... Passed
    zsh-5.3.1-doc.tar.gz ... Passed
    config.guess ... FAILED
    config.sub ... Passed
    zprofile ... Passed
    Makefile.in.patch ... Passed
    add-pwd-W-option.patch ... Passed
    msysize.patch ... Passed
    zsh-5.0.6-1.patch ... Passed
    msys-symlink-hack.patch ... Passed
    user-autocomplete.patch ... Passed
==> ERROR: One or more files did not pass the validity check!


优化短选项推荐方式

详情可看 #64

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.92%. Comparing base (32d32e8) to head (57aa7b5).
Report is 32 commits behind head on master.

Files with missing lines
Patch %
Lines

clop.go
66.66%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #65   +/-   ##
=======================================
  Coverage   78.92%   78.92%
=======================================
  Files          11       11
  Lines         816      816
=======================================
  Hits          644      644
  Misses        121      121
  Partials       51       51

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


htlcswitch: make max cltv expiry configurable and lower default

The current value was based on the previous default CLTV delta of 144 blocks. This has been lowered to 40 since lnd v0.6.0-beta, making the current value of 5000 blocks a bit high. Lowering it to one week should be more than enough to account for the other major lightning implementations. Eclair currently has a default CLTV delta of 144, while c-lightning's is 14.
The value can be configured through the --max-cltv-expiry flag.
Fixes https://github.com/lightningnetwork/lnd/issues/3286.

@wpaulino, when we receive a FailExpiryTooSoon in mission control, we black list all of the channels of that node. By lowering the default limit, your node is at risk of this happening. Is this intended?
A nicer, much more involved, solution would be to have nodes announce their max cltv (node or channel level), so we can take it into account during path finding.

Current distribution of time_lock_delta on mainnet:

time_lock_delta
occurences

144
28612

40
16650

30
7004

14
2985

4
2033

64
607

20
551

432
297

1000
295

10
253

72
180

39
156

300
141

34
137

6
135

7
131

142
104

140
69

100
59

12
49

43
44

24
31

60
19

288
14

420
14

48
13

80
10

50
9

143
7

600
6

576
5

101
4

120
4

2016
2

32
2

36
2

1440
1

145
1

16
1

21
1

250
1

44
1

@wpaulino, when we receive a FailExpiryTooSoon in mission control, we black list all of the channels of that node. By lowering the default limit, your node is at risk of this happening. Is this intended?

I wasn't aware we had this sort of interpretation on a FailExpiryTooSoon error.

A nicer, much more involved, solution would be to have nodes announce their max cltv (node or channel level), so we can take it into account during path finding.

I don't think there's an existing way to do this in the protocol?

Current distribution of time_lock_delta on mainnet:

Looking at this, bumping the default to 2016 should be more than enough.

Looking at this, bumping the default to 2016 should be more than enough.

We keep running into the error, even with 2016 and long routes? Why do you think it is more than enough?
There is already a max cltv limit restriction. We could also just change the default from no limit to 1000 or so


Ported OS validation into the new framework

Still not actually in use by EIB. Wiring that up will come in a PR once all of the existing validations have been ported over.

Do we want to include some validation for the new additions (time, proxies, etc.) in this PR?


Wip/6.0 Verify array (draft PR)

https://trello.com/c/9NiLgPRJ/16-verify-complete-array-support
This is a draft PR, so Andrea can inspect the progress and interact incrementally.
Currently only basic testing passed, but with one issue exposed: when one root entity has an array of 1000 elements, eager fetching will end up with 1000 rows sharing the same root entity. Currently the root entity will be initialized 1000 times. This is not directly related to the scope, however.
@dreab8 feel free to keep your eyes on this PR. The commits won't be merged until necessary so you can check its progress easily. Each step might end up with each new issue and you can stop us whenever you found I am heading in wrong direction, :).

Hi @NathanQingyangXu here a PR with a different approach to solve the issue

closed because of better approach by Andrea.


Feature Request: Partially expand item

Right now when you expand an item in your inventory it displays both the Activities, the description, and all of the traits on that item. This can be very handy when first leveling up or setting up a class. But it can also take up a lot of screen space when you just want to keep the items expanded to access their Activities. This is especially true for items that have extremely long descriptions

It would be nice if one could just display the activities. Perhaps make the expand button a 3 way toggle such that you get 1. Nothing, 2. Just Activities, 3. Everything.

Personally, I always want to see the description, especially on spells. I love how it works currently, and would be a little sad to find that getting to the item description is behind an extra click. If this is implemented, perhaps a second button or a shift-click to open just the activities could be a compromise.

Yeah I don't know what the solution is here but I definitely feel this. I was hoping to be able to have Monks Focus permanently expanded so I could always easily access the different features, but that has a LOT of text and nowhere to hide it. In the meantime it will be neater for me to just have separate features.


Runtime Library Configuration

Premake has functions for controlling the Runtime Library Configuration,

staticruntime, by turning it on or off we can configure either if visual studio should use the Multi-Threaded Static or DLL Runtime.
runtime that controls either the debug or non debug Runtime, if static or DLL is still determined by staticruntime.

Implemented in #46


BUG: special: cython_special missing dep

Fixes #21217

Patch up a missing dependency for cython_special extension, introduced accidentally in a large PR as described in the bisection in above ticket. I didn't check why it only affects debug builds.

[skip circle] [skip cirrus]

I merged, but indeed it would be good to figure out how this was working previously. Maybe you have an idea @thalassemia ?

I don't remember any dependence to LAPACK from the parts I touched. Maybe other parts had.

Yes, elliptic harmonics:
$ grep dstevr scipy/special -rn
scipy/special/lapack_defs.h:7:extern void BLAS_FUNC(dstevr)(char *jobz, char *range, CBLAS_INT *n, double *d, double *e,
scipy/special/lapack_defs.h:13:static void c_dstevr(char *jobz, char *range, CBLAS_INT *n, double *d, double *e,
scipy/special/lapack_defs.h:17:    BLAS_FUNC(dstevr)(jobz, range, n, d, e, vl, vu, il, iu, abstol, m,
scipy/special/_ellip_harm.pxd:40:    void c_dstevr(char *jobz, char *range, CBLAS_INT *n, double *d, double *e,
scipy/special/_ellip_harm.pxd:165:    c_dstevr("V", "I", &size, d, dd, &vl, &vu, &tp, &tp, &tol, &c, w, eigv,

Then let me join the club of  spooky action at a distance.

Thanks for the fix Tyler!
I still can't tell exactly what the problem was. It's very indirect - _ellip_harm uses a LAPACK function, and via the functions.json machinery that does end up in _ufuncs.so. But it doesn't get exposed in cython_special.pxd. So it may be something that is optimized out by the linker with -O2 but hangs around in cython_special.so only with -O0.

I confirm that this PR fixes the issue at hand! Thanks @tylerjereddy


Changed two translations

This pull request changes two translation.
auth.php made a translation feel more natural to read.
passwords.php fixed a spelling error.

@johnhout Maybe take a look at the open pull requests? There are a few open which bring good changes to this repo.


Refactor main

Codecov Report

Merging #31 (c6acb6f) into main (6e1513b) will decrease coverage by 0.21%.
The diff coverage is 96.29%.

@@             Coverage Diff             @@
##              main      #31      +/-   ##
===========================================
- Coverage   100.00%   99.78%   -0.22%
===========================================
  Files            8        9       +1
  Lines          472      473       +1
===========================================
  Hits           472      472
- Misses           0        1       +1

Impacted Files
Coverage Δ

weather_command/__main__.py
0.00% <0.00%> (-100.00%)
:arrow_down:

weather_command/main.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e1513b...c6acb6f. Read the comment docs.


Using after commit for jobs in batch

Laravel Version
10.39.0
PHP Version
8.1
Database Driver & Version
mysql
Description
i'm trying to use job batch with after commit jobs
but i can't figure out what is  wrong here and can't find such example in the docs or i'm missing something
this exception is thrown
serialization of 'Closure' is not allowed in vendor/laravel/framework/src/Illuminate/Queue/Queue.php line 159
Bus::batch([
            app(StorePostMainImage::class, [
                'post' => $post,
                'tempImageId' => $dto->mainImageId,
            ])->afterCommit(),
            app(StorePostImages::class, [
                'post' => $post,
                'tempImagesIds' => $dto->imagesIds,
            ])->afterCommit(),
        ])->then(function (Batch $batch) use ($post) {
            event(new PostImageBusProcessed(
                postId: $post->id,
                batchId: $batch->id
            ));
        })->dispatch();

this is the StorePostMainImage  class
public function __construct(
        protected StorePostMainImageAction $storePostMainImageAction,
        protected int $tempImageId,
        protected Post $post,
    ) {
    }

        public function handle(): void
    {
        $this->storePostMainImageAction->execute(
            post: $this->post,
            tempImageId: $this->tempImageId
        );
    }

this is the StorePostImages  class
public function __construct(
        protected StorePostImagesAction $storePostImagesAction,
        protected Post $post,
        protected array $tempImageIds
    ) {
    }

    public function handle(): void
    {
        $this->storePostImagesAction->execute(
            post: $this->post,
            tempImageIds: $this->tempImageIds
        );
    }

Steps To Reproduce

create an action class with single public method accept any params
create a job and import Batchable trait
inject the action class in the job constructor with other action params
in job handle method call the action class and pass the need params to the action public method
create a bus batch and put the created job in the bus jobs array but make the container resolve and create the job instance
dispatch the bus batch

Hi there,
Thanks for reporting but it looks like this is a question which can be asked on a support channel. Please only use this issue tracker for reporting bugs with the library itself. If you have a question on how to use functionality provided by this repo you can try one of the following channels:

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

However, this issue will not be locked and everyone is still free to discuss solutions to your problem!
Thanks.


[Analytics] Eigen 3.0 QA

Screens
We should attempt to move towards firing a single screenview per screen. Onboarding screenviews that are double firing currently:

[ ] Onboarding start and sign_up_splash: we should deprecate sign_up_splash and only fire Onboarding start

[ ] Onboarding signup and create_account: we should deprecate create_account and only fire Onboarding signup

[ ] Onboarding login and login: we should deprecate login and only fire Onboarding login

[ ] Every other onboarding screen fires a proper screenview and an additional screenview personalize which should be removed; we should only fire Onboarding follow artists, Onboarding follow categories, Onboarding select budget

[ ] Pressing the home button and the app while on an onboarding screen and then opening it again does not fire another screenview, and maybe it should if we consider reopening the app the start of a new session; a similar thing is happening with events, in the below case Follow artist:

Tracks

[ ] When following a category from the Onboarding follow categories screen, a gene favorite track -- an outdated event with no properties -- fires. Instead, we should fire Follow category. Nore that a category can be followed from a gene page or during onboarding. Contextual properties:

properties: {
gene_id,
source_screen: [gene page, onboarding top categories, onboarding search, onboarding recommended]
}

[ ] Follow artist fires with no contextual properties. Instead we should append to the event:

properties: {
artist_slug,
artist_id,
source_screen:[artist page, artist fair page, onboarding top artists, onboarding search, onboarding recommended]
}

[ ] We do not fire an event when user logs in using safari keychain. Instead, we should fire Successfully logged in with the following property:

properties: {
context_type: safari keychain
}

@anipetrov What a great and clear issue 👏

@ani FYI, there's another source screen for Artist Follow events, which would be the rails from the home page. @alloy did we put any analytics around that?

Closing this as most of it is implemented. Have moved the outstanding issue to #1947. Thanks @anipetrov and @ashfurrow!


mkpr

Applied mkpr on .github/workflows/auto_approve.yml
./merge.sh

Codecov Report

Merging #693 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #693   +/-   ##
=======================================
  Coverage   99.08%   99.08%
=======================================
  Files           1        1
  Lines         109      109
  Branches        9        9
=======================================
  Hits          108      108
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8b8ebb...9a6088c. Read the comment docs.


drivers: console: uart_console: avoid infinite loop in isr

Previously, the uart_console_isr() routine assumed that the return value of several uart API functions would only ever return the equivalent of a boolean value. In fact, an integer is returned on occasion, and that integer can take on many values.
Since unary operations would either go to "true" or "false" and since any non-zero integer evaluates to "true", even a return value of something like -ENODEV would evaluate to true.
Explicitly compare against the integer-equivalent value of the expected boolean output.
With this, in the case of errors, negative return values do not evaluate to "true", and the infinite loop is avoided.
Fixes #62999

used > 0 comparison instead of explicit == 1 to save 2 instructions on RISC-V

The bot didn't seem to auto-assign reviewers, so I the old analog PRNG picked a few.

IIRC, we used to use macros for some of these APIs - I think it was just never the case that they would return negative values perhaps, and then they were converted to syscalls, etc.


Admonitions are poorly formatted in documenter_output

I have the following admonition:
!!! note

    This tutorial is adapted from [ArviZ's quickstart](https://arviz-devs.github.io/arviz/getting_started/Introduction.html).

In Documenter, this looks like:

In Pluto, this looks like:

When building the notebook with PlutoStaticHTML with documenter_output, I would have expected it to look like one of the above, but instead it looks like:

This is a CSS problem. I try to not add too much CSS because that would make things a lot less flexible on your side. I think you can fix this pretty quickly by adding a bit of CSS styling to your Documenter settings. Having said that, I do agree with you that it makes sense to add some defaults for this kind of stuff. I'll keep this issue open and probably fix it at a later point


Feature Request: Support --external-checks-XXX

Feature Request:
action.yml to support --external-checks-dir and --external-checks-git

I believe that this is currently supported if you configure the external checks in a checkov config file and the config file is used by the GitHub action.
example snippet of .checkov.yml file
external-checks-dir:
  - ./checkov_external_checks

it can be used via
  external_checks_dirs:
    description: 'comma separated list of external (custom) checks directories'
    required: false
  external_checks_repos:
    description: 'comma separated list of external (custom) checks repositories'
    required: false


Create VWAP indicator

For a given ticker + option

Poll the options data every minute second and store the option data (volume, price, greeks, etc.)
Provide a method to get the hourly and daily totals
Calculate standard deviation for the option
Get the VWAP

Links

Calculate VWAP

Enhancements

[ ] Get current strike price (ticket -> lastTrade)
[ ] Get option chains for next 3 expiries
[ ] Filter out options chains below or above +-5% strikes
[ ] Print in CSV format
[ ] Get dates for expirations and filter by same day
[ ] Ensure format for fields that use scientific notation is printed in float
[ ] Write CSV to file
[ ] Put in non blocking function
[ ] Save to db on a 1 second delay
[ ] Resolved weird precision issue for greeks
[ ] Get the highs and lows on a 1 min interval
[ ] Use osiKey + timestamp as unique key
[ ] Ensure last trading price of underlying is part of report
[ ] Underlying price should come from the last row in a group sorted by time (i.e. the 55-59s)
[ ] Update report generation method to take a date


Carousel works only after the page is resized

The carousel displays the images when mounted but does not go to the next image unless the page is resized and this happens only if there is a 'd-flex' bootstrap property in the parent Div element, without the 'd-flex' the carousel works fine. is there any reason for this?

I ran into a similar issue as joshua today when creating an image carousel, on load the carousel wasn't scrolling fully to the next page until I resized the window (see bug gif below). In my case updateSlideWidth is called before the images load, so it gets the default slide width of ~200px. The easiest solution for me was to update my css to have a fixed width.
I'm curious what your template and css looks like @joshuadsouza08?
(I commented on this issue instead of creating a new one since it's a similar outcome "the carousel only works after the page is resized", but might be caused for different reasons, and may require a new issue depending on how ismail9k wants to do tracking. The solution for mine could be adding an image carousel example to the documentation, instead of a logic change.)
Template / CSS To Reproduce:
template:

    <carousel>
      <slide v-for="photo in photos as any[]" :key="photo.id">

      </slide>
      <template #addons>
        <navigation />
      </template>
    </carousel>

original css:
.carousel__item {
  min-height: 200px;
  width: 100%;
  background-color: var(--vc-clr-primary);
  color: var(--vc-clr-white);
  border-radius: 8px;
  display: flex;
  justify-content: center;
  align-items: center;

  img {
    height: 100%;
  }
}

bug gif:

Solution
(same template)
Updated css:
.carousel__item {
  height: 500px;
  width: 500px; // instead of 100%
  background-color: var(--vc-clr-primary);
  color: var(--vc-clr-white);
  border-radius: 8px;
  display: flex;
  justify-content: center;
  align-items: center;

  img {
    width: 100%; // constrain image width
  }
}

fixed gif:

i am rendering an adaptive card inside a 'div' element of the  tag.When I add the css property d-flex to the parent div element i get the bug as shown in the bug gif above.
`

      <template #addons>
        <Navigation />
        <Pagination />
      </template>
    </Carousel>

  {{ message.text }}

`
i tried using the css you suggested @thalida but it did not work for me. am i doing something wrong here ?

Hi @joshuadsouza08, I have the same exact behaviour as yours.
Using the basic example provided by @ismail9k, and no specific CSS.
Carousel is working fine when the app is first mounted. Then if I change page (I'm using Nuxt), and then go back to the page including the slider, navigation/slides stop working.

I will look into this issue. For now, as a temporary fix for this issue, you can use restartCarousel() method to recalculate the carousel slide width.

@ismail9k Thank you for your answer.
In the end, the following code worked for me (setting the initial slide on mounted)  @joshuadsouza08
<template>
  <carousel :items-to-show="1.5" v-model="initialSlide">
    <slide v-for="slide in 10" :key="slide">
      {{ slide }}
    </slide>
    <template #addons>
      <navigation />
      <pagination />
    </template>
  </carousel>
</template>


BulkTfpose_en.bat missing

"MotionTraceBulk_en.bat" calls "BulkTfpose_en.bat" but it doesn't get created from "mtbulk-install.bat"

Thanks for your report. I'll fix it.

Done. Now you can download a fixed version of motion_trace_bulk from
https://github.com/errno-mmd/motion_trace_bulk/archive/mat1.02.01-2.zip
or wait for next release of mmdmatic.


Update linting guidelines

Some of our linting guidelines for pep8/pylint are out of date so we should look at updating our rules and code base to match, for example https://github.com/ARM-software/workload-automation/pull/1131

Updated with https://github.com/ARM-software/workload-automation/pull/1134


Adds a setter for the TargetInfo type

Resolves https://github.com/xvrh/puppeteer-dart/issues/201
Adds a type setter on Target which sets the TargetInfo type.

@elliette Thanks, I'll merge it and publish it like that if it helps you.
Longer term, it would be great to have some tests (to demonstrate we can open and inspect the devtool panel).
Also it could be interesting to catch up with puppeteer-javascript regarding the isPageTargetCallback. There were some big changes in puppeteer with the Target class that are not ported yet in Dart.

@elliette Thanks, I'll merge it and publish it like that if it helps you.
Longer term, it would be great to have some tests (to demonstrate we can open and inspect the devtool panel).
Also it could be interesting to catch up with puppeteer-javascript regarding the isPageTargetCallback. There were some big changes in puppeteer with the Target class that are not ported yet in Dart.

Thank you! Will open up a PR to add tests. Also tagged you on the discussion about isPageTargetCallback.


Add support for Slot data decoding

Adds the Seek trait to the reader in the Decode trait. This allows seeking functionality when decoding packets, which vanilla Minecraft utilizes. This functionality is necessary for decoding Slot data from packets. The PR also adds a basic Slot struct.

I would opt for different type signature for Slot.
pub enum Slot {
    Empty,
    Full {
        item_id: VarInt,
        item_count: u8,
        nbt: Option<Compound>,
    },
}

Unless I am missing something, this seems more elegant and removes illegal states that would have to be checked.

I took @Sekky61's advice and updated the type signature for Slot. I also looked into using &mut &[u8] instead of Read + Seek but found that Slot::decode needs the seek functionality in order to prevent parsing invalid nbt data and to prevent just assuming that an error in the Compound::decode function means there is no nbt data like this. The vanilla implementation of Slot::decode uses Seek functionality to determine if there is nbt data before trying to parse it.


OPTIONS LIKE NEW AND RESET GAME

Please assign this to me for GSSoc'24 as i can include buttons like reset and new game which will improve ui of website

@Durgesh4993  I also want to contribute to solve this issue under GSSOC'24 , I can work with another contributor so please can you assign this issue to me too .

I am willing to resolve this issue, please assign this task to me.

Hello I am Gargi from IIT Kharagpur! I work with html,css,js,react.js and so on and am eager to learn more. I'd appreciate being assigned this task for GSSoC 24.

Hello!
I have always been interested in making web based games, and I can surely help you in resolving this issue.
I am fluent in JS and knows CSS.

Hi Can you assign this issue to me because i had experience in doing similar games .

@Saketh1714 @Parishri07 @Pujan-sarkar @VijaySamant4368 @gargimukherjee25 Please raise any other issue, i'll assign you
If you have any doubt you can directly send message on our discord (https://discord.gg/rZb46cCMmK), we have created seprate chennals for all projects...
Thank you :)


hypem - Unable to extract tracks

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.04.17. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[ x] I've verified and I assure that I'm running youtube-dl 2017.04.17

Before submitting an issue make sure you have:

[ x] At least skimmed through README and most notably FAQ and BUGS sections
[ x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[ x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add -v flag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
$ youtube-dl https://hypem.com/track/2mp4e/Hoop+-+Baseboards+%28feat.+Briana+Marela%29 --verbose
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'https://hypem.com/track/2mp4e/Hoop+-+Baseboards+%28feat.+Briana+Marela%29', u'--verbose']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.04.17
[debug] Python version 2.7.12 - Darwin-16.5.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 3.2.4, ffprobe 3.2.4
[debug] Proxy map: {}
[Hypem] 2mp4e: Downloading webpage with the url
ERROR: Unable to extract tracks; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 760, in extract_info
    ie_result = ie.extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 429, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/hypem.py", line 37, in _real_extract
    response, 'tracks')
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 787, in _html_search_regex
    res = self._search_regex(pattern, string, name, default, fatal, flags, group)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 778, in _search_regex
    raise RegexNotFoundError('Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract tracks; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
...
<end of log>

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://www.youtube.com/watch?v=BaW_jenozKc
Single video: https://youtu.be/BaW_jenozKc
Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc

Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.

Description of your issue, suggested solution and other information
Explanation of your issue in arbitrary form goes here. Please make sure the description is worded well enough to be understood. Provide as much context and examples as possible.
If work on your issue requires account credentials please provide them or explain how one can obtain them.

Works fine here. Could you run
youtube-dl --write-pages https://hypem.com/track/2mp4e/Hoop+-+Baseboards+%28feat.+Briana+Marela%29 --verbose

And upload all *.dump files?

Closing as no response for a long time.


reroot_at_edge() causes trifurcation and incorrect branch lengths

The Tree.reroot_at_edge() method does not work as described. In version 4.0.2 and 4.0.3, it results in a trifurcation and does not respect the provided edge lengths:
newick_str = '(((A:0.5,B:0.5):0.5,C:0.5):0.5,(D:0.5,E:0.5):0.5);
tree = dendropy.Tree.get(data=newick_str, schema='newick')

mrca = tree.mrca(taxon_labels=('A', 'B'))
print 'mcra.edge_length', mrca.edge_length

tree.reroot_at_edge(mrca.edge, length1=0.5 * mrca.edge_length, length2=0.5 * mrca.edge_length, update_bipartitions=True)

for child in tree.seed_node.child_nodes():
    print 'child.edge_length', child.edge_length

tree.write_to_path('rooted.tree', schema='newick')

The output is:
mcra.edge_length 0.5
child.edge_length 0.5
child.edge_length 0.5
child.edge_length 1.0

The resulting tree is:
[&R] ((A:0.5,B:0.5):0.5,C:0.5,(D:0.5,E:0.5):1.0);
Note that this tree incorrectly has a trifurcation and that the edge lengths to the root are not 0.25 as expected (i.e., half the edge length of the parent branch from the MCRA node).

The problem here is that you are reading in an unrooted tree (there is
no rooting token, and a rooting state is not specified when when reading
the tree). Encoding the bipartitions on an unrooted tree creates a basal
trifurcation.
This is noted in the documentation in a number of places, including, for
e.g., the primer sections on bipartitions and the primer section on tree
manipulations. It has also been covered in depth in several discussions
in this group.
Please read the documentation closely, especially the primer. E.g.:
http://pythonhosted.org/DendroPy/primer/treemanips.html#setting-the-rooting-state
To get the behavior you expect, you need to read in the tree as rooted
by at least one of the following means:
(1) Ensure that the tree string has the rooting token:
newick_str = '[&R] (((A:0.5 ...'

(2) Force a rooting state when reading the tree by passing in the
rooting="force-rooted" keyword argument:
tree = dendropy.Tree.get(data=newick_str,
                              schema='newick',
                              rooting='force-rooted')

(3) Explicitly set the rooting state after the tree is read by before an
operations or calculations on the tree:
     tree.is_rooted = True

Any one of these will do, but following code implements all three plus a
sanity check:
     #! /usr/bin/env python
     import dendropy
     newick_str = '[&R](((A:0.5,B:0.5):0.5,C:0.5):0.5,(D:0.5,E:0.5):0.5);'
     tree = dendropy.Tree.get(
         data=newick_str,
         schema='newick',
         rooting='force-rooted',
         )
     tree.is_rooted = True
     assert tree.is_rooted
     mrca = tree.mrca(taxon_labels=('A', 'B'))
     print 'mcra.edge_length', mrca.edge_length
     tree.reroot_at_edge(mrca.edge, length1=0.5 * mrca.edge_length,
length2=0.5 * mrca.edge_length, update_bipartitions=True)
     for child in tree.seed_node.child_nodes():
         print 'child.edge_length', child.edge_length
     tree.write_to_path('rooted.tree', schema='newick')

This results in:
     mcra.edge_length 0.5
     child.edge_length 0.25
     child.edge_length 0.25
     [&R] ((A:0.5,B:0.5):0.25,(C:0.5,(D:0.5,E:0.5):1.0):0.25);

On 9/4/15 2:59 AM, Donovan Parks wrote:

|newick_str = '(((A:0.5,B:0.5):0.5,C:0.5):0.5,(D:0.5,E:0.5):0.5); tree =
dendropy.Tree.get(data=newick_str, schema='newick') mrca =
tree.mrca(taxon_labels=('A', 'B')) print 'mcra.edge_length',
mrca.edge_length tree.reroot_at_edge(mrca.edge, length1=0.5 *
mrca.edge_length, length2=0.5 * mrca.edge_length,
update_bipartitions=True) for child in tree.seed_node.child_nodes():
print 'child.edge_length', child.edge_length
tree.write_to_path('rooted.tree', schema='newick')|

--

Jeet Sukumaran
<EMAIL_ADDRESS>Blog/Personal Pages:
http://jeetworks.org/
GitHub Repositories:
http://github.com/jeetsukumaran
Photographs (as stream):
http://www.flickr.com/photos/jeetsukumaran/
Photographs (by galleries):
http://www.flickr.com/photos/jeetsukumaran/sets/

These work, though it is not intuitive to me that a tree needs to be rooted before it can be rerooted with expected results. Rooting an unrooted tree is a well-defined operation.

I. As this thread is a public document, in the interests of information accuracy ...
(1) It is not the act of rooting an unrooted tree that causes the collapse of the basal bifurcation. It is the fact that the bipartitions are calculated on an unrooted tree. This is documented.
(2) The reasons for collapsing the basal bifurcation when calculating the bipartitions on an unrooted tree are sound: if not, there would be two identical bipartitions on the same tree, making calculations and indeed any other operations on the tree undefined. This is also documented.
(3) If you want to avoid this collapsing of the basal bifurcation while calculating bipartitions on an unrooted tree, you may also do so. This option is also documented.
II. On a more personal note ...
One's intuition is conditioned on many factors, much of which is constrained by the personal history and immediate use-cases that one has personally encountered. As it happens, in this case, defaults to result in behavior conforming to your intuition would fail in some of the broader range of applications that the library functionality is put to use. In particular, maintaining the basal bifurcation when bipartitions are calculated on an unrooted tree would result in putting the machine in an unacceptable unpredictable state. I agree that the result of this is counter-intuitive. Or, at least, it was to me until I considered the implications of NOT collapsing that basal bifurcation; now doing it any other way makes no sense. In either case, counter-intuitive or not (or perhaps precisely because the only possible behavior that could be supported by default to ensure correct behavior was counter-intuitive), we took great pains to document this.
III. Related to this, on another personal note ...
The documentation is far from perfect, or even complete. We add to it and correct it all the time, in many cases based on feedback from users who found errors orgaps. If your expectations and intuitions have been misled by the documentation, please point it out, and we will be happy to fix it. If some issue or glitch or gotcha is missing from the documentation, we will be happy to fill in the gap. I am entirely open to it needing improvement and welcome suggestions (or better yet, pull requests) to improve it. However, I believe that, with regards to issues being discussed here, the documentation is at least adequate and clear and unambiguous, both from an operational perspective (what behavior to expect and what you need to do get the behavior you want) as well from a conceptual one (why the library behaves the way it does). If this is not the case, please let us know.
IV. On another personal note, but less directed toward yourself personally, as much as to other persons who have stumbled onto this page because they were trying to figure out why their tree suddenly has a basal trifurcation ...
The fact is that we have put an immense effort into documenting the library. Effort that not only equals the actual programming effort, but was, frankly, tedious and time-consuming and entirely unrewarding. We did not enjoy it. We did not go to bed each night thinking, "can't wait to get up tomorrow to start working on the 'bipartitions' section!" There were many other things we would have preferred to do, from actually coding to walking the dogs to even, after the third solid week of writing the documentation, doing the dishes or vacuuming under the couch. But we did it anyway. We did it because the documentation, while not necessarily a sacred obligation, is contract with the users that is as important part of the library as any core functionality. It provides a way to bridge across personal histories and idiosyncracies and expectations. It communicates how the library works to users. It is meant to highlight usage issues such as this, where some behavior might make sense from the big picture view of the design, but result in some glitches or gotchas in a narrow range os sub-application. In an ideal universe, neither the reading nor the writing of documentation would be necessary. Library API's would be structured purely on common intuition. This is impossible when the number of users exceeds 1. Or indeed, even if the number of users is equal to 1 but that user is not found in the set of developers. Hence, the need and importance of the documentation to both the developers and users.
To communicate how the library works to the users.

I realise this is retreading old ground for the umpteenth time, but . . . .
Well, first off, the library is well documented especially around rooting state of trees (thanks!). This makes sense too:

It is not the act of rooting an unrooted tree that causes the collapse of the basal bifurcation. It is the fact that the bipartitions are calculated on an unrooted tree. This is documented.

But I do think this point has merit:

Rooting an unrooted tree is a well-defined operation

So I have two suggestions:

if the Tree.reroot_at_edge() and similar methods really do return a rooted tree (as in a tree with a basal bifurcation), then would it not be intuitive for the method to also update the rooted state i.e., set Tree.is_rooted = True ? That way if/when Tree.update_bipartitions() is called it would only update bipartitions, which I think is more intuitive than implicitly changing the topology as well. I realise the documentation explains why the topology will change under the current behaviour, but IMHO it is not intuitive.

if the rooting state of the tree should dictate how methods work e.g. the Tree.update_bipartitions() just mentioned, then Tree.reroot_at_edge() and similar methods should raise an exception if their Tree instance is not rooted to begin with. After all, rerooting implies the tree is already rooted and the root is being moved, which is a different operation to applying a root de novo to an unrooted tree.

I suspect either of the above would avoid confusion among users who haven't (recently) read the documentation.
Thanks for a great library.


Create SHAJU2609

please add extension next time (like .html or .md) Will fix it for you this time

Ok thank u Sultan
On Thu, Oct 1, 2020, 6:35 PM Sulthan Nizarudin<EMAIL_ADDRESS>wrote:

please add extension next time (like .html or .md) Will fix it for you
this time
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SpooderManEXE/Learn-Coding/pull/9#issuecomment-702120461,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARG4GC3VA5CVSKU2RDPAMCTSIR5APANCNFSM4SAMXQYA
.


[NF] mean value along axis

I added mean value calculation including some slicing tests.
There are 2 things I noticed but haven't investigated futher.

The 'less than' operator, e.g. 'X<2' doesn't work as expected. It rather behaves like 'less or equal'. (Haven't tested 'greater than'.)
Axes indices behave different to default python indices, i.e. 'X[0:2]' will return X[0:3]. If this is desired, it should be mentioned.

Best regards,
Sebastian

Thank you for the add of the mean computation, which will be very useful. Concerning your remarks:

Indeed, the "<" syntax corresponds to "<=", in a intent to alleviate the syntax, and because until now, we only needed a "less than" operation. It would however be better to add both syntaxes.
For the interval of indices, it is indeed not consistent with python syntax. I will correct it shrotly.

Thank you for the add of the mean computation, which will be very useful. Concerning your remarks:

Indeed, the "<" syntax corresponds to "<=", in a intent to alleviate the syntax, and because until now, we only needed a "less than" operation. It would however be better to add both syntaxes.
For the interval of indices, it is indeed not consistent with python syntax. I will correct it shrotly.


W3Schools full course listing added

What does this PR do?
Add resource(s) | Remove resource(s) | Add info | Improve repo
For resources
Description
Why is this valuable (or not)?
How do we know it's really free?
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:

[ ] Read our contributing guidelines.
[ ] Search for duplicates.
[ ] Include author(s) and platform where appropriate.
[ ] Put lists in alphabetical order, correct spacing.
[ ] Add needed indications (PDF, access notes, under construction).
[ ] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

Hello, this is for Hacktoberfest 2022.  Please let me know if this is accepted.  I thought the entire wonderful W3Schools course could be added.  Thank you

Hello, this is for Hacktoberfest 2022.  Please let me know if this is accepted.  I thought the entire wonderful W3Schools course could be added.  Thank you


Add method for mget with only ids and updated doc

I want to use the short version of mget where you only pass index, type and ids like so:
curl 'localhost:9200/test/type/_mget' -d '{
    "ids" : ["1", "2"]
}'

https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-multi-get.html
Disclaimer:
I'm terribly new to golang and I bet I've broken some practises.

Please consider my suggestions and ping me when you update the pull request.

Good suggestions! Though I couldn't get the tests working, even on the master branch. Seems a few tests uses localhost even though I used the -host flag =(
Another time =)


Importing eth_testrpc causes gevent to break stdlib

Importing eth-testrpc implicitly creates a global EthTesterClient instance which has a call to gevent.spawn().
This hangs Python interpreter
https://github.com/pipermerriam/eth-testrpc/blob/master/testrpc/testrpc.py#L29
I recommend not to have implicit calls to gevent as they tend to break Python for other software, like web servers, debuggers or schedulers.

Looking at the under the hood I think the right way to fix this is just to remove the need for the spawn all-together.  That pattern was the wrong fix for a problem with calling testrpc functions asynchronously.  What is really needed is just a simple lock in place of the async code and the threading part can go away entirely


link not available

privacy in Microsoft office link not available,
so update new link  or remove it sir

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 047d2b74-e963-a006-cb74-29257c409647
Version Independent ID: 4f274c79-18ae-2c36-19a3-cfb73d7e6cf3
Content: Privacy options in Office 2016
Content Source: DeployOffice/security/privacy-options-in-office.md
Service: o365-proplus-itpro
GitHub Login: @DHB-MSFT
Microsoft Alias: danbrown

I've submitted a pull request to update the link's description. The link is working.
@DHB-MSFT Feel free to add label and close this issue


YAML - OAuth token usage: Give better example for backwards compatibility and do not encourage the usage of Write-Host

Thanks i'm integrating this parts of this change into a large restructure i'm working on right now. Closing this PR.


bootmisc accidentally wiped non-/tmp settings

In Alpine, we had an incident where a user's box got rm -rf'd due to the bootmisc script: https://gitlab.alpinelinux.org/alpine/aports/-/issues/13070
It seems to me that we should just mount a tmpfs at /tmp, and not "wipe" anything there at all.

I plan on spinning up a VM this evening and seeing if I can reproduce it.

Since this was during boot I cannot think of any way there could have been mounts (bind or otherwise) inside of tmp. There would not be under normal runtime circumstances either. This could be mitigated with -xdev and -exec rm {} + instead of rm -rf though (with some additional type logic and a second pass with rmdir) but I seriously doubt it was the cause in my case.
I think the most likely cause was actual filesystem corruption - perhaps / getting cross-linked into /tmp/something as a "directory hardlink" (which you can't make, but is representable in the on-disk filesystem structures). I don't really know any good way to mitigate something like that, but the very possibility makes me think it's a very very bad idea to ever have any rm -rf execute during system boot (which might be happening after an event that caused fs corruption). The risk/benefit ratio here just does not make any sense.

i understand your preference.  you're free to disable the behavior, either through existing knobs or by having /tmp be a tmpfs.  but the fact is that clearing of /tmp is, and has been for decades, the standard in the *NIX world, and has been strongly recommended by FHS for decades (such that they would have mandated it if they felt FHS's scope included administration in general).  changing this default behavior would be a strong disservice to users, the vast majority of which want this.
so if we agree that the code as-is doesn't look like it would ascend into the / or otherwise start operating on paths not reachable via /tmp, then it sounds like there's nothing left to do or discuss here.

Hey @richfelker  I would like to know more about why Alpine is looking into moving off of OpenRC; I would like to see if we can work on ways to fix your issues.
I just now saw your comment above, and would like to know more about what other init systems are doing about /tmp.
Also, is -xdev an option to find (I'm not familiar with it)? Someone also mentioned -delete (I'm pretty sure this is an option to find). More info would be helpful.

In that case I'll just continue to follow up on the Alpine side about fixing this in a patch, and about this as yet another reason for moving off OpenRC.

you make it sound like OpenRC is unique or weird in its behavior.  as i clearly mentioned above, it is not, so any reasonable system you move to would have similar default behavior.  unless you write something from scratch, in which case you're free to do whatever non-standard leaky stuff you prefer.  it's not like there's that many choices out there anymore since systemd became the defacto Linux standard.

-xdev is an option for find, but it looks like -mount is the more portable option

-xdev is in POSIX, -mount is not, so not sure why you think that's more portable to use.
but as i noted, that only helps with find, not with rm, and the rm code path is the default and most common.

Why can't we just remove the rm stuff and always use find, which can be defanged with -xdev?

if you read the code comments you'd see:
        # Faster than raw find
        if ! rm -rf -- [!ajlq\.]* 2>/dev/null ; then

i don't recall the exact scale needed before one starts to see a difference between the two, but i don't think it was "tons of files"

A while ago, you noted that the logic in OpenRC originates from Debian (presumably by way of Gentoo baselayout-1).
Looking at Debian, they never use rm -rf anywhere.  In fact, they unconditionally use find -depth -xdev -delete.
Is this really something that needs performance optimization?

yes, openrc is simply baselayout-2 rebranded and relicensed to BSD
using rm was a measurable difference, and people want their system to boot fast. Debian didn't really focus on that since everything in their init setup was slow. it's easy to only use numbers from the latest top of the line systems and hardware stacks and not care about older or embedded systems.
I think systemd just uses tmpfs for /tmp, so they wouldn't need to clean (like we already do if you set your system up to use tmpfs). if Debian has added -xdev to their find, I'd be fine adding it to ours. an argument could be made in either direction, but feels mostly bike shedding.

@vapier I thought at the time that -mount was more portable because of this wording in the find man page:

-mount Don't descend directories on other filesystems.  An
alternate name for -xdev, for compatibility with some
other versions of find.

But, I'm fine with -xdev since that is in posix.

I can make bootmisc complain on Linux systems if any directory in cleanup_tmp_dirs is not a mounted tmpfs; it would be a modification of the loop at line 207.
What I would do is put a warning in for a release or so then in the future stop cleaning the directories for linux systems.
I don't know if I would have to keep the code in the *bsd world since I have no idea whether *BSD supports anything like a tmpfs.
Is this what we want to do?

@kaniini  If we do this, would you want the warning to be on the 0.44.x branch?

@vapier  Do you have any more specific info about why we need the rm -rf? I would like to understand what the problem there is, or if we can try by relying only on find again, I'm open to doing that.

not using tmpfs is not, and should not be, a problem. we should not be warning people or making it seem like there is a problem with their system. there are plenty of legitimate reasons why one would not use or want a tmpfs mount at /tmp. we should recommend that people use one if they can, but that's it.
we don't install the fstab file, but we can update the Gentoo default in baselayout and the handbook to mention it. that should at least help with new installs. other distros are also free to adjust their own setups and defaults accordingly without openrc being involved in their decision tree.
/tmp can be full of cruft from the previous boot, and exist on slow media (like MMC or spinning media). running find in the first place is slower, and running it twice is worse. we shouldn't be penalizing everyone in order to support corrupted systems. this is the wrong trade off.
we don't even know if this was the reason for the reported breakage in the first place -- a corrupt or hard linked directory could make the rootfs appear under /tmp and not as a mount (I.e. xdev wouldn't help). a corrupt filesystem could lead to data loss even just by writing to it regardless of file removal. it's impossible to protect against data loss when the system is already screwed. this is the entire reason we run fsck early on, and we don't code defensively against every possible method of corruption in every filesystem related operation.
so I'll reiterate again: if you don't like clearing /tmp due to some philosophical reason, then we already offer multiple alternatives.

@vapier

and the reason we have the rm is because we had user reports that the /tmp cleaning step took a long time

Can you site these reports? how long ago were they? could this be some legasy thing that isn't an issue any longer?

I wonder if we can guide people towards the tmpfs method by default somehow

I see that guidance being two parts.

Yes, distros can change their default fstab to support /tmp as a default. I will make this change in baselayout on Gentoo soon.
However, it does not affect live systems.
If we want people to change their live systems, we need to guide them toward that change too.
The only way I see to make that happen is to put something in bootmisc like this that warns them about the change.

@robbat2  @richfelker  @kaniini  @vapier  How does the pr look now? Is this ok?

@vapier can you please clarify your statement on how rm is safer than find if the filesystem has corruption? Esp. in the example case where /tmp/foobar ends up linked to / or /usr, so traversal visits unintentional places.

@vapier If I can avoid tmpfiles.d I'd rather do that, systemd-tmpfiles isn't portable.

i'm talking about the tmpfiles.d specification, not a specific implementation of the runtime.
systemd-tmpfiles itself should work on all Linux systems.  it builds independently of systemd and can be installed in isolation.  Gentoo has more than proved that fact.
opentmpfiles is a POSIX shell script that can run anywhere (ignoring the problems it had that we could rectify, but are choosing not to and instead telling people to use systemd-tmpfiles).
we could delete the vast majority of bootmisc by installing a single tmpfiles.d entry, and leave it to users to add more.  then say OpenRC requires a tmpfiles.d implementation at runtime and we're done.  if you're extremely concerned about providing a tmpfiles.d that runs under *BSD's, then you could always dust off opentmpfiles (and my partial conversion to a standalone C implementation).
continuing to bend over backwards to maintain our own ad-hoc checkpath tool instead of declarative & fast tmpfiles.d is a waste of our time, and results in less robust code that we ship (exhibit A: bootmisc).

can you please clarify your statement on how rm is safer than find if the filesystem has corruption

i didn't say it was safer, i said being defensive in the fact of filesystem corruption is a fools errand, and thus they're equiv at that point

Esp. in the example case where /tmp/foobar ends up linked to / or /usr, so traversal visits unintentional places.

i think you're misunderstanding things here.  if /tmp/foobar is a hard linked directory to / or /usr, then find -xdev won't save you.  find will happily descend into that subdirectory because that's all it is -- a subdirectory.  xdev checks for mount points which hardlink directories are not.
yes, i'm aware that Linux tends to ban them, but that's at the level of where it won't allow them to be created via syscalls.  in many filesystems, it is possible to create hardlinks in the FS itself via debugfs or raw FS manipulation, and since we're talking about FS corruption, that is possible.  in fact, CrOS recently had a persistence root exploit that involved creating a directory hardlink in an EXT4 FS via debugfs.

@vapier If you feel they are in fact equivalent, then you should have no fundamental objection to using find in place of rm.
The minimum viable change is what William is proposing, not "what's the best way we can do this".
I agree that using find/rm is not as much of an improvement as using some tmpfiles.d code, or tmpreaper, but it's small & lightweight.
If Gentoo is about choice, it SHOULD be possible to ship a bootmisc that uses find, as well as a "better" version that supports tmpfiles.d.
As for @kaniini's other request about being able to mostly disable the functionality:

what's the minimum set of files that need to be wiped to guarantee safe boots?
Is the historical list really still relevant?
If it's still relevant, can those entries can wind up in their own tmpfiles.d spec, and the rest of the wiping can be optional at that point?

That historical list:

esrv* - obsolete
kio* - likely safe, moved to /tmp/kde-$USER/
jpsock.* - never heard of this one
.fam* - obsolete by inotify?
.esd* - really obsolete unless you hate ALSA & PulseAudio
orbit-* - obsolete?
ssh-* - ssh agent? probably safe to delete on boot
ksocket-* - obsolete KDE?
.*-unix - maybe convert to .{ICE,X11}-unix, which need to exist for X still
.X*-lock - keep cleanup, can prevent X from starting
.Xauth* - probably ensure cleanup still, leaks X MIT auth cookies

And the other to clarify: what files in /tmp are really dangerous to remove?

{a,}quota{.user,.group} - if we're deleting things, why do we need to keep quota data?
lost+found - if we're cleaning up, why keep it at all?
journal - historical ext[34] journal file, likely needed to avoid corruption

It was pointed out to me that the -name switch was on the original find for a reason, so I put that back and added -xdev to all of the find calls. Also, if we make the directory, we don't need to wipe it since it will be empty.
This is also a less invasive change than the previous proposal.
@kaniini  @robbat2  @vapier
Please look at the pr again and let me know what you think. Hopefully this one will be the final iteration. ;-)

@richfelker  please comment if you can also.


Fix leaking test templates in test_runner.py

N = self.parallel templates are created, and these templates were
previously named 'zulip_test_template_<1, N>'.  However, to support
running multiple instances of test-backend, a unique
random_id_range_start was created for each template database.
There was no problem prior because the templates would simply be
used again and thus did not require any clean up. Now that there are
unique database names being created, every time test-backend is run
these templates can accumulate on disk.  Instead, we clean up our
templates at the end of every complete run of the test suite, or upon a
SIGINT.
Fixes: #12426
Testing Plan:
>>> tools/test-backend
>>> df -h
>>> manage.py dbshell
zulip_test=> \l

@timabbott fyi

Merged as ccfcd6b4d851cfd36483e6f9a8078c8ee68bcf7c, thanks @whoodes and @adnrs96!
I thought a bit more about how to handle leaking of test databases, which is still super high priority.  I think the following algorithm is I think the right way to do it:

When test-backend starts up, the parent process (before it forks) should write to a file under e.g. var/UUID/zulip_test_template/1234567 a list of the database IDs it's going to create.
We add a new function in zerver/lib/test_fixtures.py called destroy_leaked_test_templates and call it from provision and at the end of test-backend.  That function will list the var/UUID/zulip_test_template/
directory.  Any files that have a timestamp older than an hour have their databases deleted.  Additionally, any zulip_test_template_* databases that don't have a corresponding file have their databases deleted.

In addition to that follow-up, we should prioritize the following:

Cleaning up the root var/ directory; we've discussed that before.  ls -ltr var/ is a good way to find all the things that are not properly scoped under the ~/.zulip-dev-uuid directory.
We should at least update the comment explaining the double-number-append bug.

Again, thanks for fixing this!


Update gorel with each release

Hi @kltm @balhoff
The gorel files in the release (.owl and .obo) are not being regenerated with each release. For example looking at
http://snapshot.geneontology.org/ontology/extensions/gorel.owl
This files does not incorporate the changes I made here: https://github.com/geneontology/go-ontology/issues/24987
Can this be added to the pipeline?
(Also, it would be great if there was a date in the file header)
Thanks, Pascale

@pgaudet Which project do you want this in?

pipeline maintenance? or pipeline cleanup?

@pgaudet Not maintenance as this is something "new". It could be "cleanup" if you don't mind the scope creep ans PO and PM and pushing that end date out a little :)

@balhoff @pgaudet I'm not sure of the status here. Is there meant to be a date included in the file to mark it, or is just for the regeneration to be automated?

@kltm I think both. I update the file manually but still need to automate.

We may not need this, depending on how soon we can get rid of GO-REL and how soon P2GO can switch to RO


Install fails because newtonnet_predict script doesn't exist

It seems that the install script is somehow requiring a script outside the source directory.  Is this intended?

Thanks for catching this! cli/newtonnet_predict is missing. I filed a temporary fix to remove it from setup.py so that pip install -e . can run without problem. Will add this script back when Mojtaba is back from vacation.


Running Dependabot with Docker takes a long time to start

I run dependabot locally based on https://github.com/dependabot/dependabot-script. It works fine with gradle, bundler and npm, but checking a docker file, dependabot takes 20 minutes to actually start the generic-update-script.rb. Checking other dependency managers (gradle, bundler) takes on a few seconds, often 10-20.
Do you notice the same behavior at GitHub?
I don't understand it. The container actually does something network relevant, docker shows in and outgoing network traffic, but it should not take so long. The cpu is always idle, with 0-1%.
The used host environment is not relevant, it always takes 20 minutes, either locally on my machine (M1 MacBook or with a default amd64 linux server hosted in Frankfurt (Germany)).
After this "timeout" and finally starting dependabot it takes only a few seconds like running with bundler, gradle.
Using docker image sha256:289cd72eb67dd8a3b0a3b9aa94ed05e6a7f8e1b27ab51dda5af48d253feb6d04 for registry.gitlab.example.de/foo/dependabot:f5ba8c2a with digest registry.gitlab.sample.de/foo/dependabot@sha256:56ecb46af1f15baec2fe4b8133df304c2cdc088cbcdd940f67586630e60255f7 ...

// after 0.1 seconds
To use retry middleware with Faraday v2.0+, install `faraday-retry` gem

// after 20 minutes! the actually ruby script is called

Start dependabot generic-update-script.rb script
Parsing dependencies information
Parsing done - Found the following dependencies
Update dependency dependabot/dependabot-core
Done

generic-update-script.rb:
# This script is designed to loop through all dependencies in a GHE, GitLab or
# Azure DevOps project, creating PRs where necessary.

require "dependabot/file_fetchers"
require "dependabot/file_parsers"
require "dependabot/update_checkers"
require "dependabot/file_updaters"
require "dependabot/pull_request_creator"
require "dependabot/omnibus"
require "gitlab"

print "Start dependabot generic-update-script.rb script"
... remaining unchanged script

After digging, it looks like a duplicate of https://github.com/dependabot/dependabot-core/issues/2997


Added zikyo as kyo-combinators module

Address #451

Added kyo-combinators module
Copied sbt config from kyo-core
Copied zikyo code into kyo-combinators
Replaced ZiKyoTest with KyoTest
Minor fixes for scala 3.4.2 and changes to kyo API (CanEqual has problems!!)

@fwbrasil let me know if there's anything we need to add for it to publish properly to Maven. I literally just copied over the zio-core project definition and changed the names. Seems to work ok.

I think so! I wonder if the tool generating the website can copy from multiple files.

@fwbrasil do you have a preferred way to add the documentation for this?

@fwbrasil do you have a preferred way to add the documentation for this?

I'm looking into migrating to https://readthedocs.io/ and splitting the documentation into multiple files but can you add it to the readme for now?

LGTM besides the merge issue

I fixed the weird readme issues, and I've moved documentation over

Thank you so much @jiveshungerford! 🙏


Added a "Shopping List" mode feature

Added a "Shopping List" mode, where you can specify items that you want and the scan will inform you of everything you are missing. It also adds a dynamically added "Trash" recipe that identifies items in your inventory that you don't need to accomplish your goal

If it isn't clear in the screenshots, the recipe list is filtered to only show the recipes that are in the chain for the specified shopping list
The recipe list also includes the "trash" recipe, which selects up to 4 items that aren't in the shopping list tree

I also just refactored the initial code base to break it out into multiple files, which I think is just easier to maintain

The first two commits are 100% the refactor, all commits beyond that are my feature changes

Fixed misspelled Treant Horder > Treant Horde

I noticed the settings.ini file wasn't commited to the repo, so I added it to the .gitignore

That's a lot of work! Einhar approves
I'll try to review it as soon as possible. Trying to catch up with real life stuff after providing support for this tool for last 5 days 8 hours a day.

Haha, both of us did th same two small things with settings and rename treant :)

Omg thats amazing! where can I doiwnload it williammetcalf?

@4rtzel  alright I added some error handling. TBH I haven't written python in like 7 years I think, and I'm definitely no expert with using TKinter, so idk if I did this especially well. I'm definitely open to suggestions on how to handle errors for this type of thing.
I'm also sure it would be a bit confusing to a new user to understand exactly what to put in for the recipes, since its case/hypen sensitive

Omg thats amazing! where can I doiwnload it williammetcalf?

For the time being you would need to clone my fork of this repository and setup/run the python code directly. One this PR gets merged the project will need to be re-released

@4rtzel alright I added some error handling. TBH I haven't written python in like 7 years I think, and I'm definitely no expert with using TKinter, so idk if I did this especially well. I'm definitely open to suggestions on how to handle errors for this type of thing.
I'm also sure it would be a bit confusing to a new user to understand exactly what to put in for the recipes, since its case/hypen sensitive

I'm not a Python developer either so I can't really tell how good/bad it is :). For me it seems "good enough". Especially giving that this tool is a temporary solution for the UI problems in PoE.
As long as the main feature of your changes is functional, I'll merge them. You can leave the polishing to me.

I've been using it myself for a few days and it does seem to work. There's a few more additions I'd like to make but cant be bothered until I see what changes GGG makes.
Ideally I'd like it to show on-screen the items you are missing to make it easier to keep an eye out for them, and it would be nice if it filtered the recipes shown even smarter to not lead you to making duplicates of items you've already made. But I think this is a good baseline for the concept

I agree with you about waiting for the solution that GGG will come up with, before doing any more changes. My current plan is to merge your work and release v0.2.0 with keyboard changes.
After that, I'll merge https://github.com/4rtzel/poe-archnemesis-scanner/pull/35 for v0.2.1 release (@meepen changes modify the algorithm quite significantly, so it would be nice if people had a version to fallback to in case of any issues).

Played a little bit with the changes. Besides the issues, that I mentioned above (already fixed), everything seems to be working fine.
The code also looks much better now with the split. There are a few stylistic issues but nothing critical. Merging.


duckstation: unstable-2022-08-22 -> unstable-2022-07-08

Description of changes
Reverts #188024 (it wasn't meant to be merged, it was a preview version), but still moves Duckstation to a more recent version than before (the current latest stable).
Wayland is disabled because it's problematic in this version.
For those who used the preview version temporarily, there should be any problem downgrading (unstable-2022-08-22 saves data in a completely different folder, so it didn't touch any older data).

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@SuperSandro2000 The reason it's a bit messy is because I did the cleanup when drafting the update that shouldn't have been merged (which has breaking changes, it's not just a version bump), so by reverting it, it did an "anti-cleanup".

Sure, we can squash the commits and please keep some of the cleanups.
If the desktop file is wrong and will be removed anyway we can also generate it right now already.


Infinite Plan Loop on SNOWFLAKE.ML Privilege Grants

Terraform CLI and Provider Versions
Terraform v1.7.0
provider registry.terraform.io/snowflake-labs/snowflake v0.87.2
Terraform Configuration
resource "snowflake_grant_privileges_to_account_role" "schema_object" {
  privileges        = ["CREATE SNOWFLAKE.ML.ANOMALY_DETECTION","CREATE SNOWFLAKE.ML.FORECAST"]
  account_role_name = "TEST"

  on_schema_object {
    object_type = "SCHEMA"
    object_name = "DATABASE.SCHEMA"
  }
}

Expected Behavior
This should apply the "CREATE SNOWFLAKE.ML.ANOMALY_DETECTION","CREATE SNOWFLAKE.ML.FORECAST" to the "TEST" role one time and no longer appear in the plan.
Actual Behavior
This applies the "CREATE SNOWFLAKE.ML.ANOMALY_DETECTION","CREATE SNOWFLAKE.ML.FORECAST" to the "TEST" role one time and continually appears in the plan (infinite plan loop).
Steps to Reproduce

terraform apply

How much impact is this issue causing?
Low
Logs
No response
Additional Information
No response

Hey @coleheflin-gt. Thanks for reaching out to us.
Could you please share the result of SHOW GRANTS ON ...? My guess is that Snowflake is not returning them. In such a case, there's not much we can do on the provider side, until the results appear there.

Hi @sfc-gh-asawicki, thanks for the quick response! It does appear the grants are returned, see screenshot below.

Thanks for checking it @coleheflin-gt. I will try to reproduce this error inside the provider tomorrow.

@sfc-gh-asawicki Thanks for looking into this. I have created an internal ticket with snowflake and requested they cc you.

Hey @coleheflin-gt. It seems that Snowflake behavior was fixed (proved in https://github.com/Snowflake-Labs/terraform-provider-snowflake/pull/2806). Could you please try to check if you are still experiencing the infinite plan loop? (version bump is not needed because it was fixed on SF side, not the provider)

Thanks for following up, it has been resolved!


Connections leak when closed by the client

I'm currently tracking down ways the loop resource handle's Finalizer from #60 is called instead of the Dispose method.
One occurrence is when a Connection: Keep-Alive session is closed by the client instead of being reused.

Thinking about it: The code is not really doing anything special when waiting for the next Frame on a connection as opposed to any other read operation during request handling.
This explains the large number of connections when killing ab in #34.


Font and option suggestion

Hello.
I work since Day on my css snippet for icon. I want to know if it's possible to fusion with your plugin.
So, some suggestion :

Font

Font Awesome (Regular, Brands, and Solid)
Boxicons
IconMoons Free
Material Icons

Adding an option to change size (because you use remixicons 16px) with Style settings
Adding an option to change placement settings (padding, margin, vertical-align and maybe left)
Adding an option to change color

I think, if we can, fusion my snippet and your plugin can be super cool for other user !

Also, if possible, Material Design Icons: https://materialdesignicons.com

Cute, and very easy to use! Many thanks.
Hopefully, whatever you do in terms of improvement/tweaks/alteration, ease of use will remain the principle.

Hello.
I work since Day on my css snippet for icon. I want to know if it's possible to fusion with your plugin.
So, some suggestion :

Font

Font Awesome (Regular, Brands, and Solid)
Boxicons
IconMoons Free
Material Icons

Adding an option to change size (because you use remixicons 16px) with Style settings

Adding an option to change placement settings (padding, margin, vertical-align and maybe left)

Adding an option to change color

I think, if we can, fusion my snippet and your plugin can be super cool for other user !

I would love to collaborate and I really like your ideas!
You can feel free to add a PR and I will add you as a collaborator to this plugin :)

Also, if possible, Material Design Icons: https://materialdesignicons.com

Sure! Just open up another issue for that. I've created a project roadmap, so we can keep track of the current tasks, issues, and their progress.

Cute, and very easy to use! Many thanks.
Hopefully, whatever you do in terms of improvement/tweaks/alteration, ease of use will remain the principle.

Thank you for the kind feedback! User experience and simplicity will be priority number one!

I don't know Typescript, but you can found my snippet here : https://github.com/Mara-Li/Obsidian-Snippet-collection/blob/main/folders.icon.css
Don't worry about take it to work / tweak with it!

I don't know Typescript, but you can found my snippet here : https://github.com/Mara-Li/Obsidian-Snippet-collection/blob/main/folders.icon.css
Don't worry about take it to work / tweak with it!

Sure, thanks :) I will keep this issue open to notify you when it is done. In addition, I will create another issue for customizing the size, color, and placement.

Any update on this ?

Not yet. But I will try to think today of an idea to easily customize the icons.

Thank ! I check, and, with CSS I do something with change width and height :
.obsidian-icon-folder-icon > svg {
    width: var(--size);
    height: var(--size);
    left: var(--left-align);
    top: var(--vertical-align);
    position: relative;
}

Using Style Settings permit to custom size, left and vertical align.
So, the idea is to add this but for all icon ? In the same place you store the other data ?
I don't know if it's possible to add dynamic option but if yes :  Each time a new icon is added → add option in settings.
If no... A command, maybe ? With a modal to choose the folder/file ?
I'm don't like to add menu because I have a lot of option so it can be a pain to have again option. But I think it's the only viable solution.

Yeah. I like the idea of changing the style of all icons. For style changes for a single item might be too much.

Hey there.
You can now checkout the code and test the customizations for yourself! @Mara-Li would be good if you can give some feedback, if the current customization options fit your needs (font size and color)

Yeah I will check that !

It seems that changing the size doesn't do anything. Color work as expected.

Hm interesting. For me, it's working fine.

Ah, I forgot to remove my css !
It work as intended so 👍
It can be very good to add a way to change position/size for specific icon.

Beautiful!
I will think about it. The problem is that the data can be really huge the more folders and icons you have. I try to keep it as lean and clean as possible.

Yeah, I completely understand!

I've added the ability to change the padding of the icon. Therefore #3 is closed and therefore some parts of this issue. Should we create an extra issue for the icon packs?

No, I think it's okay o/ Thank you !


small cleanup

these small commits are actually doing more than the small corrections

be hide the scenes i'm trying to get .....how they say? "git flow" working
meaning I can get the main branch to update any changes but not any other branch
so these small commits are me trying different things to get local branches to update with a fetch or pull
so far i've manage to make some progress, namely I found out that ,merge works and rebase.
work in progress

after all the failed tries to get branches to fetch or pull, I would be happy for a simple keybinding to merge or rebase


SIFT install fails

I am trying to install SIFT on windows 10. Here is the screenshot with the error

You need to specific —mode=server on the install. Desktop mode is not supported for WSL.

Thank you

You are welcome.


Add GitHub issues template to guide users

This defines an issue template that will automatically populate the form when users and contributors open new issues. The goal is to guide people as they file issues.
cc @kubernetes/charts-maintainers

Can we standardize the prefix for issue & PR titles as well? I really like having [repo/chart] in there.

I don't think there's a way to do that automatically in the form, though I do like that.

I'd suggest to add a section on title/commit messages to the CONTRIBUTING.md. How about requiring commit messages in imperative mood? See https://chris.beams.io/posts/git-commit/.

lgtm

Good idea about mentioning the title in contributing, will add that.