Updated Wwise detection to account for Godot plugin libraries

SteamDB app page links to a few games using this
Runa & the Chaikurú Legacy: https://steamdb.info/app/2283470/ (depot showing the library in the files: https://steamdb.info/depot/2283472/)
Brief explanation of the change
Godot uses an unofficial but semi officially endorsed plugin to add Wwise to its games. However, the plugin's library file is different from the standard AkSoundEngine.dll. I have added the Godot version for both Godot 3.x and Godot 4.x to rules.ini and the test types folder. I did not account for WaapiGDNative.dll/so, but WWiseGDNative.dll/so should be enough. I don't know if this works so I would like someone with more knowledge of regex to see if what I typed works.

After running changed rules in this pull request (this bot only tests rules.ini changes):
Changed technologies: SDK.Wwise
2012 apps still match.
These apps now match: (13) 1707220 1786010 1965810 2065530 2118940 2283470 2407540 2422440 2429640 2512930 3179920 3227630 3240600
Please confirm that all these changed apps are correct.

I can confirm that these changed apps all use Wwise.

I would also like to say that 2118940 is a Godot game (Godot 3.x), as is 3179920 (Godot 4.x), since to my knowledge only the Godot wwise plugins have the libraries named like that

There's only 1 app that's using (based on what you said) Godot 4 & wwise that's not really enough to edit that rule to match these for now Let's only keep the godot 3 version

How many Godot 4.x games using Wwise must there be in order for those to be matched? The file for the 4.x plugin is from the same plugin as the 3.x extension, only updated. This plugin has also been put in a directory made by the Godot Foundation (https://github.com/godot-sdk-integrations).

5 to 10 apps (that are unique (demo & game itself count as 1), with 10 being preferable to not have too many edge case

5 to 10 apps (that are unique (demo & game itself count as 1), with 10 being preferable to not have too many edge case

So I presume that Chicken Fall Prologue is being counted as a separate game here rather than a demo (with Chicken Fall and Chicken Fall Prologue both having demos). Fine, I'll accept.

There's no use in keeping the linux version when it doesn't help to detect more games

apologies, I closed the pull request hoping that it wouldn't put my Unity commits into here


Go Back keyword should wait until page is loaded

Originally submitted to Google Code by Andreas.EbbertKarroum on 30 Mar 2010

I just ran into the situation that after a "Go Back" I had to insert a
sleep, because IE was not ready for the next command (Returned an Error
"Erlaubnis verweigert" / "permission denied"). After doing a "Go Back" the
SeleniumLibrary should wait until the page is fully loaded.
The patch also includes the new method from issue-107.

Originally submitted to Google Code by @pekkaklarck on 30 Mar 2010

Thanks for the report. Using self._wait_for_page_to_load definitely makes sense.

It would be better to have a patch with only the relevant changes. I know that's
hard to do with svn when you don't have commit rights - you need to revert the other
changes - and that's one very good reason why SeleniumLibrary should switch to
Mercurial. I submitted  issue 110  about it.

Instead of using Sleep as a workaround, you should use Wait Until Page Contains or
similar keyword.

Are there any cases where Go Back shouldn't wait for the page to load? If there
are, we can make it configurable, but it should wait by default.

Originally submitted to Google Code by Andreas.EbbertKarroum on 24 Apr 2010

This issue was closed by revision eda8bb516f.

Originally submitted to Google Code by @pekkaklarck on 24 Apr 2010

We use 'Done' status instead of 'Fixed'. Unfortunately there doesn't seem
to be option to configure the state used when issues are closed by commit
messages.

Originally submitted to Google Code by @yanne on 27 May 2010

Major improvements warrant a major version


[AVM Question/Feedback]: Update PE implementation in remaining modules

Check for previous/existing GitHub issues

[X] I have checked for previous/existing GitHub issues

Description
Some modules had to be excluded from the PE implementations updates provided in #1472 due to unrelated issues preventing them to be merged. The purpose of this issue is to track the PE implementation updates of these modules:

[x] #1827
Can be done if green:

[x] #1789
Can be done if green:

[x] #1943
Can be done if green:

[x] #2454
Can be done if green:

[x] #1791
Can be done if green:

[x] #2455
Can be done if green:

[x] #1793
Can be done if green:

Closing as done


Put src in a maven module so that other modules can be added later for other, related code that is not core

Is your feature request related to a problem? Please describe.
The problem is that there is some utility code that could be added to the project, but the classes for the utility should not be part of the core library.
Describe the solution you'd like
Make the project use maven modules. The core library (which is today 'src') can be kept separate for other code - utilities or frameworks - that might be built on top of or along side of the core library.
Describe alternatives you've considered
Putting all of the code in 'src' and either letting the utility code be shipped as runtime code, or rig the build to exclude the utility classes from the jfr-streaming jar. The problem with shipping with runtime is that the utility could create vulnerabilities. The problem with excluding the utility classes are many, but the biggest would be that the only way to get the utility would be to build from source. The preference is to be able to have a separate utility library that could be fetched from maven central which makes it a more natural way of using the utility in a build.
Additional context
Relevant to PR 16.

commit 828be85e80ecdfe81e9a93af87630b0c7a56a923
Author: David Grieve<EMAIL_ADDRESS>Date:   Mon Jul 11 11:21:29 2022 -0400
create maven module 'core' (#19)

* create maven module 'core'

* update release plugins


Patch vulnerabilities

Upgrade axios from 1.6.1 to 1.6.3
Upgrade babel-core from 7.23.2 to 7.23.7

@SayyareHamit This is ready for test in https://test.flyt.equinor.com/ (Flyt 1.0 QA environment is currently down)

The features mentioned below are not included when duplicating a process in https://test.flyt.equinor.com/   @nesadrian
Problems
Questions
Ideas
Write access/sharing rights
To-be process
Categories
Roles
Durations

@SayyareHamit Is this related to #653 ? This patch is only for Flyt 1.0 so the fixes in Flyt 2.0 is not implemented here yet

Is this correct version of environment? @nesadrian

Yes, commit c499832 is correct 👍

Oki, I got it. Than this is good to go. @nesadrian ✔


Swift 6.0

I have compiler error in swift 6.0 using @jvm macro

Hi @KovalenkoArsenii , could you pls provide more info where the @jvm macro was applied, especially a context, is it a class used within an actor ? A small example would be great so that I can reproduce it. Thanks is advance.


removal of old versions for the update to sf5

pre-pull-request for the removal of versions not maintained by symfony and the removal of old versions of php that are no longer maintained. This will facilitate the migration of behat code to the latest symfony 5 components.
pr ref : https://github.com/Behat/Behat/pull/1247

That would be awesome to stop supporting php 5... But alas, it's not planned until at least 4.0. Unless it has changed since then (Let a man dream 😂 )

@Taluu it might just be the beginning of version 4  :stuck_out_tongue_winking_eye:

What @Taluu said, basically

@ciaranmcnulty is the removal of php 5.* critical for you or is it really necessary to remove it? to know if my other pull request should be modified or not?

So when is 4.x planned?

Do we really need to wait for 4.x to remove PHP 5 support? It is not a BC break: https://www.doctrine-project.org/2017/07/25/php-7.1-requirement-and-composer.html

It's not on the sense of semver but that's what is applied on Behat (and most projects from symfony ecosystem)... :{

As I said, we're not planning to drop support yet


flutter has exited unexpectedly: "FileSystemException: Failed to decode data using encoding 'utf-8', path = 'C:\flutter_projects\android\gradle.properties'".

@kin92218
Can you provide flutter doctor -v and full error log ?

FR

@kin92218
Can you provide flutter doctor -v and full error log ?

Thank you for your kindness and sorry for my late response.
Actually, I have solved it by reinstalling many times.

Closing this as resolved based on above comment.


DumpTest with type Full frequently timeouts on MacOS tests

https://runfo.azurewebsites.net/search/tests/?q=started%3A~7+definition%3Adotnet-monitor-ci+name%3ADumpTest
Example test output:
[Monitor] User Settings Path: /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/cbb48c76-b7c1-4a16-8980-0dc76c016be3/UserConfig/settings.json
[Monitor] Path: /Users/runner/work/1/s/artifacts/bin/dotnet-monitor/Release/netcoreapp3.1/dotnet-monitor.dll
[Monitor] Args: collect --urls http://<IP_ADDRESS>:0 --metricUrls http://<IP_ADDRESS>:0 --no-auth
[Monitor] Begin Environment:
[Monitor] - COMPlus_EnableDiagnostics = 0
[Monitor] - Logging__Console__FormatterName = json
[Monitor] - Logging__LogLevel__Microsoft.Diagnostics.Tools.Monitor.Startup = Debug
[Monitor] - DotnetMonitorTestSettings__SharedConfigDirectoryOverride = /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/cbb48c76-b7c1-4a16-8980-0dc76c016be3/SharedConfig
[Monitor] - DotnetMonitorTestSettings__UserConfigDirectoryOverride = /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/cbb48c76-b7c1-4a16-8980-0dc76c016be3/UserConfig
[Monitor] End Environment:
[Monitor] Starting...
[Monitor] Process ID: 2593
[Monitor] Default Address: http://<IP_ADDRESS>:49967
[Monitor] Metrics Address: http://<IP_ADDRESS>:49968
[App1] Path: /Users/runner/work/1/s/artifacts/bin/Microsoft.Diagnostics.Monitoring.UnitTestApp/Release/net6.0/Microsoft.Diagnostics.Monitoring.UnitTestApp.dll
[App1] Args: AsyncWait
[App1] Begin Environment:
[App1] - COMPlus_EnableDiagnostics = 1
[App1] End Environment:
[App1] Starting...
[App1] Process ID: 2594
-> Method: GET, RequestUri: 'http://<IP_ADDRESS>:49967/processes/2594', Version: 1.1, Content: <null>, Headers:
{
  Accept: application/json
}
<- StatusCode: 200, ReasonPhrase: 'OK', Version: 1.1, Content: System.Net.Http.HttpConnectionResponseContent, Headers:
{
  Date: Tue, 15 Jun 2021 12:26:03 GMT
  Server: Kestrel
  Transfer-Encoding: chunked
  Content-Type: application/json; charset=utf-8
}
-> Method: GET, RequestUri: 'http://<IP_ADDRESS>:49967/dump/2594?type=Full', Version: 1.1, Content: <null>, Headers:
{
  Accept: application/octet-stream
}
[App1] Stopping...
[App1] Waiting for exit...
[App1] Exit Code: 137
[App1] Warning: Exception thrown while awaiting task: System.IO.IOException: Operation canceled
 ---> System.Net.Sockets.SocketException (89): Operation canceled
   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken) in System.Net.Sockets.dll:token 0x60002e2+0x8
   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.GetResult(Int16 token) in System.Net.Sockets.dll:token 0x60002dc+0x2d
   at System.IO.Pipes.PipeStream.ReadAsyncCore(Memory`1 destination, CancellationToken cancellationToken) in System.IO.Pipes.dll:token 0x60000ea+0xd1
   --- End of inner exception stack trace ---
   at System.IO.Pipes.PipeStream.ReadAsyncCore(Memory`1 destination, CancellationToken cancellationToken) in System.IO.Pipes.dll:token 0x60000ea+0xd1
   at System.IO.StreamReader.ReadBufferAsync(CancellationToken cancellationToken) in System.Private.CoreLib.dll:token 0x600579c+0x2c4
   at System.IO.StreamReader.ReadLineAsyncInternal() in System.Private.CoreLib.dll:token 0x6005794+0x319
   at Microsoft.Diagnostics.Monitoring.TestCommon.LoggingRunnerAdapter.ReadLinesAsync(StreamReader reader, List`1 lines, Action`1 callback, CancellationToken token) in /_/src/Tests/Microsoft.Diagnostics.Monitoring.TestCommon/LoggingRunnerAdapter.cs:line 139
   at Microsoft.Diagnostics.Monitoring.TestCommon.TaskExtensions.SafeAwait(Task task, ITestOutputHelper outputHelper) in /_/src/Tests/Microsoft.Diagnostics.Monitoring.TestCommon/TaskExtensions.cs:line 19
[App1] Warning: Exception thrown while awaiting task: System.IO.IOException: Operation canceled
 ---> System.Net.Sockets.SocketException (89): Operation canceled
   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken) in System.Net.Sockets.dll:token 0x60002e2+0x8
   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.GetResult(Int16 token) in System.Net.Sockets.dll:token 0x60002dc+0x2d
   at System.IO.Pipes.PipeStream.ReadAsyncCore(Memory`1 destination, CancellationToken cancellationToken) in System.IO.Pipes.dll:token 0x60000ea+0xd1
   --- End of inner exception stack trace ---
   at System.IO.Pipes.PipeStream.ReadAsyncCore(Memory`1 destination, CancellationToken cancellationToken) in System.IO.Pipes.dll:token 0x60000ea+0xd1
   at System.IO.StreamReader.ReadBufferAsync(CancellationToken cancellationToken) in System.Private.CoreLib.dll:token 0x600579c+0x2c4
   at System.IO.StreamReader.ReadLineAsyncInternal() in System.Private.CoreLib.dll:token 0x6005794+0x319
   at Microsoft.Diagnostics.Monitoring.TestCommon.LoggingRunnerAdapter.ReadLinesAsync(StreamReader reader, List`1 lines, Action`1 callback, CancellationToken token) in /_/src/Tests/Microsoft.Diagnostics.Monitoring.TestCommon/LoggingRunnerAdapter.cs:line 139
   at Microsoft.Diagnostics.Monitoring.TestCommon.TaskExtensions.SafeAwait(Task task, ITestOutputHelper outputHelper) in /_/src/Tests/Microsoft.Diagnostics.Monitoring.TestCommon/TaskExtensions.cs:line 19
[App1] Begin Standard Output:
[App1] {"EventId":1,"LogLevel":"Information","Category":"Microsoft.Diagnostics.Monitoring.UnitTestApp.Program","Message":"State: Ready","State":{"Message":"State: Ready","state":"Ready","{OriginalFormat}":"State: {state}"}}
[App1] {"EventId":1,"LogLevel":"Information","Category":"Microsoft.Diagnostics.Monitoring.UnitTestApp.Program","Message":"State: Waiting","State":{"Message":"State: Waiting","state":"Waiting","{OriginalFormat}":"State: {state}"}}
[App1] {"EventId":2,"LogLevel":"Debug","Category":"Microsoft.Diagnostics.Monitoring.UnitTestApp.Program","Message":"Received command: StartScenario; Expected: True","State":{"Message":"Received command: StartScenario; Expected: True","command":"StartScenario","expected":true,"{OriginalFormat}":"Received command: {command}; Expected: {expected}"}}
[App1] {"EventId":1,"LogLevel":"Information","Category":"Microsoft.Diagnostics.Monitoring.UnitTestApp.Program","Message":"State: Executing","State":{"Message":"State: Executing","state":"Executing","{OriginalFormat}":"State: {state}"}}
[App1] {"EventId":1,"LogLevel":"Information","Category":"Microsoft.Diagnostics.Monitoring.UnitTestApp.Program","Message":"State: Waiting","State":{"Message":"State: Waiting","state":"Waiting","{OriginalFormat}":"State: {state}"}}
[App1] End Standard Output
[App1] Begin Standard Error:
[App1] End Standard Error
[Monitor] Stopping...
[Monitor] Waiting for exit...
[Monitor] Exit Code: 137
[Monitor] Warning: Exception thrown while awaiting task: System.IO.IOException: Operation canceled
 ---> System.Net.Sockets.SocketException (89): Operation canceled
   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken) in System.Net.Sockets.dll:token 0x60002e2+0x8
   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.GetResult(Int16 token) in System.Net.Sockets.dll:token 0x60002dc+0x2d
   at System.IO.Pipes.PipeStream.ReadAsyncCore(Memory`1 destination, CancellationToken cancellationToken) in System.IO.Pipes.dll:token 0x60000ea+0xd1
   --- End of inner exception stack trace ---
   at System.IO.Pipes.PipeStream.ReadAsyncCore(Memory`1 destination, CancellationToken cancellationToken) in System.IO.Pipes.dll:token 0x60000ea+0xd1
   at System.IO.StreamReader.ReadBufferAsync(CancellationToken cancellationToken) in System.Private.CoreLib.dll:token 0x600579c+0x2c4
   at System.IO.StreamReader.ReadLineAsyncInternal() in System.Private.CoreLib.dll:token 0x6005794+0x319
   at Microsoft.Diagnostics.Monitoring.TestCommon.LoggingRunnerAdapter.ReadLinesAsync(StreamReader reader, List`1 lines, Action`1 callback, CancellationToken token) in /_/src/Tests/Microsoft.Diagnostics.Monitoring.TestCommon/LoggingRunnerAdapter.cs:line 139
   at Microsoft.Diagnostics.Monitoring.TestCommon.TaskExtensions.SafeAwait(Task task, ITestOutputHelper outputHelper) in /_/src/Tests/Microsoft.Diagnostics.Monitoring.TestCommon/TaskExtensions.cs:line 19
[Monitor] Warning: Exception thrown while awaiting task: System.IO.IOException: Operation canceled
 ---> System.Net.Sockets.SocketException (89): Operation canceled
   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken) in System.Net.Sockets.dll:token 0x60002e2+0x8
   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.GetResult(Int16 token) in System.Net.Sockets.dll:token 0x60002dc+0x2d
   at System.IO.Pipes.PipeStream.ReadAsyncCore(Memory`1 destination, CancellationToken cancellationToken) in System.IO.Pipes.dll:token 0x60000ea+0xd1
   --- End of inner exception stack trace ---
   at System.IO.Pipes.PipeStream.ReadAsyncCore(Memory`1 destination, CancellationToken cancellationToken) in System.IO.Pipes.dll:token 0x60000ea+0xd1
   at System.IO.StreamReader.ReadBufferAsync(CancellationToken cancellationToken) in System.Private.CoreLib.dll:token 0x600579c+0x2c4
   at System.IO.StreamReader.ReadLineAsyncInternal() in System.Private.CoreLib.dll:token 0x6005794+0x319
   at Microsoft.Diagnostics.Monitoring.TestCommon.LoggingRunnerAdapter.ReadLinesAsync(StreamReader reader, List`1 lines, Action`1 callback, CancellationToken token) in /_/src/Tests/Microsoft.Diagnostics.Monitoring.TestCommon/LoggingRunnerAdapter.cs:line 139
   at Microsoft.Diagnostics.Monitoring.TestCommon.TaskExtensions.SafeAwait(Task task, ITestOutputHelper outputHelper) in /_/src/Tests/Microsoft.Diagnostics.Monitoring.TestCommon/TaskExtensions.cs:line 19
[Monitor] Begin Standard Output:
[Monitor] {"Timestamp":"12:25:53 ","EventId":13,"LogLevel":"Warning","Category":"Microsoft.Diagnostics.Tools.Monitor.Startup","Message":"WARNING: Authentication has been disabled. This can pose a security risk and is not intended for production environments.","State":{"Message":"WARNING: Authentication has been disabled. This can pose a security risk and is not intended for production environments.","{OriginalFormat}":"WARNING: Authentication has been disabled. This can pose a security risk and is not intended for production environments."},"Scopes":[]}
[Monitor] {"Timestamp":"12:25:53 ","EventId":0,"LogLevel":"Warning","Category":"Microsoft.AspNetCore.Server.Kestrel","Message":"Overriding address(es) \u0027http://<IP_ADDRESS>:0\u0027. Binding to endpoints defined via IConfiguration and/or UseKestrel() instead.","State":{"Message":"Overriding address(es) \u0027http://<IP_ADDRESS>:0\u0027. Binding to endpoints defined via IConfiguration and/or UseKestrel() instead.","addresses":"http://<IP_ADDRESS>:0","{OriginalFormat}":"Overriding address(es) \u0027{addresses}\u0027. Binding to endpoints defined via IConfiguration and/or UseKestrel() instead."},"Scopes":[]}
[Monitor] {"Timestamp":"12:25:53 ","EventId":14,"LogLevel":"Information","Category":"Microsoft.Hosting.Lifetime","Message":"Now listening on: http://<IP_ADDRESS>:49967","State":{"Message":"Now listening on: http://<IP_ADDRESS>:49967","address":"http://<IP_ADDRESS>:49967","{OriginalFormat}":"Now listening on: {address}"},"Scopes":[]}
[Monitor] {"Timestamp":"12:25:53 ","EventId":14,"LogLevel":"Information","Category":"Microsoft.Hosting.Lifetime","Message":"Now listening on: http://<IP_ADDRESS>:49968","State":{"Message":"Now listening on: http://<IP_ADDRESS>:49968","address":"http://<IP_ADDRESS>:49968","{OriginalFormat}":"Now listening on: {address}"},"Scopes":[]}
[Monitor] {"Timestamp":"12:25:53 ","EventId":16,"LogLevel":"Debug","Category":"Microsoft.Diagnostics.Tools.Monitor.Startup","Message":"Bound default address: http://<IP_ADDRESS>:49967","State":{"Message":"Bound default address: http://<IP_ADDRESS>:49967","address":"http://<IP_ADDRESS>:49967","{OriginalFormat}":"Bound default address: {address}"},"Scopes":[]}
[Monitor] {"Timestamp":"12:25:53 ","EventId":17,"LogLevel":"Debug","Category":"Microsoft.Diagnostics.Tools.Monitor.Startup","Message":"Bound metrics address: http://<IP_ADDRESS>:49968","State":{"Message":"Bound metrics address: http://<IP_ADDRESS>:49968","address":"http://<IP_ADDRESS>:49968","{OriginalFormat}":"Bound metrics address: {address}"},"Scopes":[]}
[Monitor] {"Timestamp":"12:25:53 ","EventId":0,"LogLevel":"Information","Category":"Microsoft.Hosting.Lifetime","Message":"Application started. Press Ctrl\u002BC to shut down.","State":{"Message":"Application started. Press Ctrl\u002BC to shut down.","{OriginalFormat}":"Application started. Press Ctrl\u002BC to shut down."},"Scopes":[]}
[Monitor] {"Timestamp":"12:25:53 ","EventId":0,"LogLevel":"Information","Category":"Microsoft.Hosting.Lifetime","Message":"Hosting environment: Production","State":{"Message":"Hosting environment: Production","envName":"Production","{OriginalFormat}":"Hosting environment: {envName}"},"Scopes":[]}
[Monitor] {"Timestamp":"12:25:53 ","EventId":0,"LogLevel":"Information","Category":"Microsoft.Hosting.Lifetime","Message":"Content root path: /Users/runner/work/1/s/artifacts/bin/dotnet-monitor/Release/netcoreapp3.1/","State":{"Message":"Content root path: /Users/runner/work/1/s/artifacts/bin/dotnet-monitor/Release/netcoreapp3.1/","contentRoot":"/Users/runner/work/1/s/artifacts/bin/dotnet-monitor/Release/netcoreapp3.1/","{OriginalFormat}":"Content root path: {contentRoot}"},"Scopes":[]}
[Monitor] {"Timestamp":"12:26:03 ","EventId":5,"LogLevel":"Information","Category":"Microsoft.Diagnostics.Monitoring.RestServer.Controllers.DiagController","Message":"Written to HTTP stream.","State":{"Message":"Written to HTTP stream.","{OriginalFormat}":"Written to HTTP stream."},"Scopes":[{"Message":"SpanId:91eeb20c483a0ca7, TraceId:5609c96c020483e59c7ec9b652f69784, ParentId:0000000000000000","SpanId":"91eeb20c483a0ca7","TraceId":"5609c96c020483e59c7ec9b652f69784","ParentId":"0000000000000000"},{"Message":"ConnectionId:0HM9FV2UQNG8N","ConnectionId":"0HM9FV2UQNG8N"},{"Message":"RequestPath:/processes/2594 RequestId:0HM9FV2UQNG8N:00000002","RequestId":"0HM9FV2UQNG8N:00000002","RequestPath":"/processes/2594"},{"Message":"Microsoft.Diagnostics.Monitoring.RestServer.Controllers.DiagController.GetProcessInfo (Microsoft.Diagnostics.Monitoring.RestServer)","ActionId":"125616e6-d334-4933-bf99-dc810cd35538","ActionName":"Microsoft.Diagnostics.Monitoring.RestServer.Controllers.DiagController.GetProcessInfo (Microsoft.Diagnostics.Monitoring.RestServer)"},{"Message":"ArtifactSource_ProcessId:2594 ArtifactSource_RuntimeInstanceCookie:1300215ccf4d424e8d4936122a065d0b","ArtifactSource_ProcessId":"2594","ArtifactSource_RuntimeInstanceCookie":"1300215ccf4d424e8d4936122a065d0b"}]}
[Monitor] End Standard Output
[Monitor] Begin Standard Error:
[Monitor] End Standard Error

This may have been mitigated with increasing the dump collection timeout. However, keep this open for a little while longer and monitor the builds for this issue.


Bump Redis cluster to large in integration

The old redis instance before migration was a cache.r4.large. We are bumping the size of this instance to be at least a large so we can run tasks on integration without maxing out the CPU.

We can figure out whatever nonsense is going on in integration later and just live with even more hilarious utilization stats in the meantime 🙃

Rolling this out now (it'll drop everything in that Redis)

Yeah I see where you're coming from and I agree with this change, but I think we need to be careful about drawing general conclusions on these things like we did with the RDS stuff (which turned out very poorly indeed).
To my mind, the convincing argument for chucking resources at this is that we're choosing to live with the funky dual-use of integration for user training. Otherwise there'd be a ton of benefit in catching these spiky usage issues in integration so that prod becomes more robust.


Allow dissoc to remove non-string keys

e.g. numbers, null, undefined, NaN, etc.
Currently ramda behaves like this:
const a = {}
const b = R.assoc(42, 'value', a)  // {"42": "value"}
const c = R.dissoc(42, b)  // {"42": "value"}
R.equals(a, c) // false

The reason is that values passed to assoc are coerced into string keys (as per the javascript spec),
but dissoc doesn't do a similar conversion.
By principle of least astonishment I'd expect assoc and dissoc to reverse the other's actions 😁
I mostly care about numbers being coerced, but I can see a use-case for undefined or null as well.
I also came across this PR which was merged to solve a very similar problem: https://github.com/ramda/ramda/pull/1122/files
I ran into this exact situation on a side project of mine and it took a while to track down.
Let me know if there's anything else that needs doing, cheers!

Not sure what's going on with the circle-ci build, it seems to have trouble finding lodash when running the jobs, I didn't do anything that should affect that though 😋

LGTM. Let's get to the bottom of the (unrelated) test failures before merging.

#1884 should resolve the CI issues.

@ChrisPenner, if you rebase on master and force push to this branch you'll trigger a new test run.

Looks like it doesn't like this syntax on Travis for some reason, runs fine locally >_>
/home/travis/build/ramda/ramda/test/dissoc.js:27
    eq(R.dissoc(42, {a: 1, b: 2, [42]: 3}), {a: 1, b: 2});
                                 ^
SyntaxError: Unexpected token [

I'll fiddle with it

👍 🚢

:dromedary_camel:

Nice catch!


Omics upload qc - Migration needed

This is the first version to test the gene mapping informaiton. A migration is needed. This loads the HGNC-HUGO table, xrefs (3), temposeq, adds temoseq mapping, then backfills points. Then, in the admin, there is a way to look at the quality of the mapping. As of yet, NO changes to the Upload of Files has been made. That is up next (add links during upload and give user a warning for the set of missing connections to names in the HGNC-HUGO table).

This request should go to stage...at first, had master. Please make sure correct before push. Thanks.


nuxt generate fail on win10

I run npm run generate in nuxt7's template directory.
How ever i get error like this:
ERROR in app.abd666e0ab7b86ce9f4e.js from UglifyJs Unexpected token: name (_typeof) [app.abd666e0ab7b86ce9f4e.js:2752,7]  TypeError: __webpack_require__(...) is not a function
node v8.9.0
npm v5.5.1
I run the same code on linux mint, it can generate successfully.

ُThis bug with windows may be with this line as windows use backslashes. I'll check it soon.


Create a timeout command

Basic idea is that it will add user-specific override permissions to all channels for "disallow all" and then like only let them talk in some channel called "timeout" or "jail" or something.


Fix: Uppercase zipcode before validating or submiting

Details
Uppercase zipcode before validating or submiting
Fixed Issues

$ https://github.com/Expensify/App/issues/20569
PROPOSAL: https://github.com/Expensify/App/issues/20569#issuecomment-1586308230
Tests

Open the app
Open settings --> profile --> personal details --> Home address
Change country to 'Ascension Island'
Insert the same format zip code but in lowercase
Verify that it doesn't throw a validation error.

[x] Verify that no errors appear in the JS console

Offline tests

Same above
QA Steps

Open the app
Open settings --> profile --> personal details --> Home address
Change country to 'Ascension Island'
Insert the same format zip code but in lowercase
Verify that it doesn't throw a validation error.

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/129500732/f6e27705-cb1c-460a-88e3-25ef4c68d3a2

Mobile Web - Chrome
https://github.com/Expensify/App/assets/129500732/ed9bf63f-fb9c-40e6-8977-6ad7e3fa85e2

Mobile Web - Safari
https://github.com/Expensify/App/assets/129500732/82222566-0a14-4451-9a55-38cc025bb5ae

Desktop

https://github.com/Expensify/App/assets/129500732/42388486-00bc-4f4d-9b33-f9360c2e8931

iOS

https://github.com/Expensify/App/assets/129500732/77ec3a1c-4e6b-4503-9492-fdc4c381e12f

Android
https://github.com/Expensify/App/assets/129500732/3fa8a330-d1ae-4d28-8927-6ffc89c8741b

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/46707890/ceda5e1b-8e25-41a7-947b-fc6afbe94100

Mobile Web - Chrome

https://github.com/Expensify/App/assets/46707890/ff1e9b11-ba8e-4b97-a4a2-0e67c02fe92a

Mobile Web - Safari

https://github.com/Expensify/App/assets/46707890/fd95a977-8844-45e8-9abf-680a962815ca

Desktop

https://github.com/Expensify/App/assets/46707890/d79ce7e1-bf8f-4edd-978e-389887a69f26

iOS

https://github.com/Expensify/App/assets/46707890/c894626c-103b-4866-8188-bbd96105a071

Android

@dukenv0307  Can you include the testing steps to save with lowercase and it will auto-change after saving to uppercase in the author's checklist?
And also mark Verify that no errors appear in the JS console in the author's checklist?

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.29-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.29-11 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Various crashes causing tilemap data loss - only possibly related.

Describe the bug
Several other people and I seem to be experiencing a bug causing crashes and losses of tileset data with Godot 4. Github user SGT indicates that the problem only appeared with the plugin present, though nothing concrete. Nathan, would you mind taking a look if you could spare the time? If not your plugin's fault we'd all still be very appreciative of some attention given to the issue.
Affected version
Latest plugin versions: 2.14.0
Latest Godot 4 versions: 4.0.0 + 4.0.1
To Reproduce
Screenshots, test data, and more available in linked issue on Godot Github.

This should be fixed by the workaround in v2.14.1.


[Feature]: Enable JSONPath or alternative to pass backup configuration as CLI Arguments

Is your feature request related to a problem? Please describe.
We are developing an automation to trigger backup creation for different Milvus DBs across our PRD and DEV Milvus environments on a scheduled basis.
Thinking is, we maintain a single copy of milvus-backup and corresponding backup config and pass backup arguments like S3 Bucket, backup and log path as CLI flags. However, tool doesn't support passing backup configuration forcing us to update backup.yaml every time or having to maintain multiple such config files.
Describe the solution you'd like.
It'd help us if tool provides support for passing backup configuration dynamically. Think in the lines of how you'd pass "values" for helm charts via CLI.
Ideally, a user should be able to trigger backup using below command
./milvus-backup create -n <backup_name> -d <DB_name> --set minio.backupBucketName=<Bucket_name> --set log.file.rootpath=</PATH/TO/backup-$(date +%y%m%d%H%M)>
Describe an alternate solution.
Above is laid out keeping helm into consideration.
Alternate solution would be like that of K8s, using JSONPath.
Anything else? (Additional Context)
No response

@ganderaj Hi, it is a reasonable suggestion. Contribution is welcomed. We can put it into our roadmap, but it won't be done very soon


[Feature] Add Magic Number Calculator

Description
I can add a magic number calculator which can check a number is magic number or not.
A number is said to be a magic number, if the sum of its digits are calculated till a single digit recursively by adding the sum of the digits after every addition. If the single digit comes out to be 1,then the number is a magic number.
1252
1+2+5+2=10 => 1+0=1
Screenshots
No response
Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a GSSOC'24 contributor.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

Please assign me the issue @Rakesh9100

Go ahead @debangi29


[JN-383] Delete Datasets

Question about auditing: when we delete a dataset, should we preserve the dataset and data_repo_job records in the database (i.e. soft delete?), and maybe add the ID of who initiated it? We'd still delete the dataset in TDR, but I can imagine we might want to maintain some history of the dataset w/o having to parse the logs?

This adds the ability to delete a dataset. Currently only usable by super users (since they're the only ones who can create datasets right now). The deletion modal follows the pattern established by the Withdraw Participant functionality.

Heads up if testing locally:
Make sure that TDR export is configured as described here (note that some things have changed recently):
https://broadworkbench.atlassian.net/wiki/spaces/PEARL/pages/2767650818/Setting+up+TDR+locally

Does TDR do a hard or soft delete? Thinking about it from user expectations... If I'm someone who really understands what TDR is, who uses it, for what, etc., I might be surprised if Juniper and TDR had different forms of delete. On the other hand, if I'm someone who doesn't really understand TDR, (then I probably shouldn't have permission to delete datasets, but...) then I might not understand the implications of deleting from Juniper; I might think that I'm just doing some housecleaning in Juniper and not realize how that impacts TDR and access to the dataset.


Adjust StyleBoxFlat antialiasing to account for 2D stretch scale

Depends on https://github.com/godotengine/godot/pull/80965.

This prevents the antialiasing feather from becoming too wide at viewport sizes higher than the default, which can lead to blurry visuals.
This is adjusted to account for the 2D scale factor returned on the root Window, so it takes both the canvas_items scaling and content_scale_factor into account.
In terms of performance, the added calls take less than 1 microsecond in a debug editor build, so it's unlikely to amount to anything significant.
Line2D antialiasing can also benefit from the same technique (which could be done in a separate PR).
In the future, we can use the same opportunity to adjust corner detail based on this scale factor. This will require adjusting corner detail in the default project theme to work optimally though (i.e. without having too many triangles at high resolutions), so it's probably worth doing that in its own PR.

Other than antialiasing, the visual appearance of corners should remain as close as possible as before. Right now, border corners seem a bit less wide than before at high resolutions – I'm not sure why. I've tried to use aa_size instead of aa_size_scaled in the places that use grow() but it didn't look exactly right. @davthedev Any ideas?
Preview
Both projects use a base window size of 1152×648, but the screenshots were taken at 3840×2160 resolution. For an accurate comparison, view these images at 1:1 size by opening them in a new tab.
At the original window size, the result is 100% identical to before.

Before
After (this PR)

Before
After (this PR)

What's happening here, with the different border radiuses? I suspect this has nothing to do with this PR...

If this pr changes aa_size rendering offsets, perhaps it could/will also fix this old bug with incorrect offset of AA size on downscaled stylebox corner radius: https://github.com/godotengine/godot/issues/68514 . Just set a corner radius larger than size/2 and you should see it. It should probably be less noticeable if the aa offset is now based on display scale, but it'd be nice to get rid of it all together.

Thanks!


Add create output directory function

Description of the problem

This PR creates the output folder if it does not exist in the simulation directory.

Seems like the CI is complaining friend :)!


UI Issue in Staff page

Describe the bug

When check header checkbox of staff table and click the any staff row it opens staff view, after closing staff view  it not uncheck header checkbox.
When check header checkbox of staff table and click on create new staff it open create page, after closing the page  it not uncheck header checkbox.
"EasyCloudBooks will send this Message in Invitation Email" this message should near message label

Expected behavior

It should uncheck all checkbox
show message on correct position

Screenshots
If applicable, add screenshots to help explain your problem.

Check Box issue Fixed but Message (that's not a right way) Invalid


[JENKINS-29504] added support for Xcode plugin

Added support for the

xcode and
import developer profile

build steps of Xcode plugin

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

How does this compare to #358?

I have been rejecting pull requests which add DSL methods for setting plain text passwords. In this case the keychain password is unencrypted. I started a discussion on the mailing list about this, see https://groups.google.com/d/msg/job-dsl-plugin/59xhodIgrsY/L2_GrZNEBQAJ.
I'm also not very delighted about reviewing 30 options. Do you really need all those options? If not, please remove all options that you don't need.

Do be honest, I don't like this entire pull request at all:

too much copy/paste. These plethora of options new exist 3 times in actual source code, several times in test source code, and once in documentation. I would like to get rid of at least the 3 times in the real source code.
All the options are simply a copied from the config.xml as a flat list. They could probably be organized into more convenient methods, which group several dependant options into one method call. Also these booleans like are buildIpa are completely unneccesary, as setting eg. ipaName could simply implicitely set the boolean to true in the xml. No need to do that manually.
Best thing would be it the XCode plugin itself could contribute the DSL commands. I remember hearing about this somewhere, but now cannot find it anywhere...

Need to think some about this...

The documentation for contributing DSL from other plugins is in the wiki.
EIther move the DSL to the XCode plugin or just keep the options you need to set for your config. Other options can be added later on in a separate pull request.

Do you want to pick this up? Otherwise I will close the PR.

Unfortunately, not in the near future. We currently use it internally like it is here, but that's not really fit for general usage. I would rather go with the approach like in #358, but I don't see I will have time for that anytime soon.

OK, please reopen the PR or open a new one if you find some time to work on this.


doc: missed an H1 in the middle of a doc

@hshen14 My PR has nothing to do with the failing dockerfile paths check?  What can I do about this failing check?


ConPTY adds extra newlines symbols at soft-wrapped rows

Windows Terminal version
Not installed
Windows build number
10.0.19045.2788
Other Software
.NET 7.0 x64
Steps to reproduce

Create ConPTY from dotnet (minimized version below, full working code here, based on samples/GUIConsole.ConPTY)
Run powershell.exe
Send 500 'a' charachters to PTY input (as a single row)
Read 500 charachters from PTY output

SafeFileHandle inputRead, inputWrite, outputRead, outputWrite;

CreatePseudoConsole(new COORD { X = 40, Y = 20 }, inputRead, outputWrite, 0, out IntPtr hPC);
ProcessFactory.Start("powershell.exe -nologo", 0x00020016, hPC);

var writer = new StreamWriter(new FileStream(inputWrite, FileAccess.Write)) { AutoFlush = true };
var reader = new StreamReader(new FileStream(outputRead, FileAccess.Read));

// Write long row
writer.Write(new string('a', 500));

// Read output
char[] buf = new char[500];
var bytesRead = reader.ReadBlock(buf, 0, 500);
var output = new string(buf.Take(bytesRead).ToArray());

// Check output
// Expected: zero '\n' characters
// Actual: a lot of '\n' characters
Console.Out.Write(output.Split('\n').Length);

Expected Behavior
Pty output contains zero newlines symbols since only one line was sent
Actual Behavior
PTY adds extra \n to output turning soft-wrapping to hard-wrapping

Thanks for the report! I suspect this is fixed in main, but I'm gonna leave this open to validate that either there's already a test for it, or if not, to add one.
If it is fixed in main, then I'm betting it's only fixed in >22000 builds of Windows.
If it's not fixed, well, it should be ☺

Ok, thanks!
Any chance that it would be fixed in win10?

Probably not, though, our recommendation is going to be using a nuget package to ingest ConPTY. This nuget package doesn't exist yet[^1], but when it does, that'll let you use the latest version of ConPTY regardless of what OS version you're on. That's effectively what the Terminal does today (so that we can use ConPTY fixes even on Windows 10). I think there's other folks that have copied what we've done, but that's firmly in the "not yet officially supported" territory.
[^1]: Originally, this was tracked in #3577, but apparently we have no thread for "productize the conpty nuget" and we should. I'll take a todo item to create one.

addenda: now tracking that in #15065

Yep, we definitely already had a test for this one:
https://github.com/microsoft/terminal/blob/10c6206bfef7d045347327687266832931f47eb6/src/cascadia/UnitTests_TerminalCore/ConptyRoundtripTests.cpp#L451-L500
So, I'll just say "fixed in the latest conpty, but that's probably not on Windows 10, so we'll need to start shipping a conpty nuget that folks can consume externally"


ApiException should have a property for parsed response data for parsable error responses

This is related to a suggestion I made here: https://github.com/microsoft/kiota-http-dotnet/issues/188
Description
I think it would make sense that in the case that there is a known Error response type for a given status code, then the response should be parsed (which in the HttpClientRequestAdapter it already is) and added to the ApiException so that is accessible to the calling code handling the exception.
API Changes
To facilitate this, a new property would need to be added to ApiException:
public class ApiException : Exception
{
    public ApiException() : base()
    public ApiException(string message) : base(message)
    public ApiException(string message, Exception innerException) : base(message, innerException)

    public int ResponseStatusCode { get; set; }
    public IDictionary<string, IEnumerable<string>> ResponseHeaders { get; set; }
+   public object? ResponseObject { get; set; }
}

I would then expect the type of the ResponseObject to be disambiguated in calling code.

Holding until we get clarity on the initial issue

Closing as this is a non-issue, I missed that the parsed response type is the exception.


[HOLD for payment 2023-04-27] Update Spacing of Sign-In Page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Updating the spacing for the sign-in page to 680px coming from this convo: https://expensify.slack.com/archives/C03KN50J0PM/p1681820899902209?thread_ts=1681773481.743539&cid=C03KN50J0PM
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b8efd3d31f3c65d7
Upwork Job ID:<PHONE_NUMBER>036751360
Last Price Increase: 2023-04-18

Job added to Upwork: https://www.upwork.com/jobs/~01b8efd3d31f3c65d7

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.2-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/17571

If no regressions arise, payment will be issued on 2023-04-27. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@tjferriss could you handle the payment for PR review?

@tjferriss Applied.

Let me know when you've accepted and I'll process the payment.

@trjExpensify Accepted the offer. Thanks.

Payment sent


Print span info for errors

Filing a new one as #6144 was closed as RLS specific, but the underlying issue exists with rust-analyzer as well. It also exists in my private "Konsole + Kate" workflow.
TLDR: Cargo should print span information for diagnostics, that is column and line numbers (plus file name) that are seen as relevant to the error or diagnostic. It can maybe also print snippets like rustc, but a good first step would be to have some span information at all.
Consider when you mistype a dependency in Cargo.toml: cargo gives an error that the dependency can't be found. But it does not point to the line. In many IDEs, when there is a string like Cargo.toml:15:0, a ctrl+click on that opens the editor at right that spot. This is very helpful for editor workflows.
Instead, one has to look for the "actionable spot" of the error manually. This is sub-optimal and could be improved.
Earlier issues:

#6144
#7548
#9687

You mention rust-analyzer and your own workflow combined with "printing" spans.  Are you needing spans printed in human readable output or json?  I'm assuming rust-analyzer would actually be the latter and is a larger step beyond the human readable side.
If this issue is meant to encompass rust-analyzer, it would likely be good to get someone from that project on this issue so we make sure we deliver the right thing.
As for a path for this, it would look roughly like

Someone is working on #12235 which they expect to have spans and machine applicable support (cargo fix) as part of it
We then work to refactor the error side of things to be more like warnings (maybe leveraging Diagnostics) with cargo-running-rustc like behavior where we print the error immediately and then unwind the stack with a "operation failed" error

An extension of this is we can choose to make some errors not bail out immediately, allowing people to see what other errors come up

We re-work the errors, where possible, to include spans
We figure out the json format and how we want to put these errors as json messages alongside the rustc ones (or alongside non-ndjson message like from cargo metadata)

Are you needing spans printed in human readable output or json

human readable output would be a great start already, specifically in the format /path/to/Cargo.toml:line:col, because that format is recognized by many tools, like Kate which opens the editor right at that spot if you pass it that string as cli arg (that'd be my Konsole + Kate workflow). In VS code, I do use rust-analyzer for some tasks but not to show the errors. Usually that I do with the built-in terminal, which turns Cargo.toml:line:col into a link too.
The format is pretty standard, it's used by many of the compilers I worked with, like gcc, clang, javac, etc. VS Code also supports linking the style python uses, which is "foo/bar.py", line 12. So IMO Cargo should switch to that format as well. #12556 has been great progress already though.

I think, even if you assume the vs code devs were willing to add a custom format recognizer for cargo, the format currently outputted by cargo is hard to turn into a clickable link, as the filename is far away from the line and column info.
So, best to use Cargo.toml:line:col like format.

Java:
public class Program
{
    public static void main(Stvring[] args) {

	}
}

./Playground/Program.java:4: error: cannot find symbol
    public static void main(Stvring[] args) {
                            ^
  symbol:   class Stvring
  location: class Program
1 error

clang:
void main(void) {
    eror
}

a.c:1:1: warning: return type of 'main' is not 'int' [-Wmain-return-type]
void main(void) {
^
a.c:1:1: note: change return type to 'int'
void main(void) {
^~~~
int
a.c:2:5: error: use of undeclared identifier 'eror'
    eror
    ^

Python:
hio

Traceback (most recent call last):
  File "/home/user/src/cargo/a.py", line 1, in <module>
    hio
NameError: name 'hio' is not defined

No effort has been done to polish our existing spans: thats just what we get from toml_edit + anyhow: This is all incremental. With our diagnostic work, we plan to mirror rustc as much as possible.

Noted. Very enthusiastic about seeing progress in that area!


Snippets Incompatability

I love having Ternific but I also love using my custom snippets. There is an issue with using Brackets Snippets (by edtc) extension, whenever I go to type a snippet, the Ternific suggestions always takes priority, so I never get to use my snippets unless I backspace and hope it shows up, sometimes it does sometimes it won't. I'm not saying this is a bug or anything but I would love to see a compatibility between the two extensions, so I figured I would mention it here. Thanks for the awesome extension I still use it, depending on which project I'm working on. Cheers.

Hi thanks for using ternific! :)   So I am not familiar with snippits...  But I will install it and checkout the issue you are talking about.  I am sure we can figure out what's going on.

Awesome, would be great if you can think of something to make them work together a bit smoother. Even if you could somehow merge the tern list and snippet list somehow, I'd be happy. Maybe even a delay option for ternific so that we could manually adjust the time before the list shows up. Thanks for the reply and I hope to hear about an update in the future.


detailed_authentication

@ghufftesla maybe i should get removed from these repos?

just FYI they are "public" forks since Tesla isn't paying for an account that lets us have private things... maybe i just need to unsubscribe from the repos i guess...


Pixel-perfect positioning: don't floor positions with gpuAcceleration disabled

Currently, you floor the positioning because of blurriness with fractional translation, but this inevitably causes small positioning errors because elements on the page can be positioned using subpixels.
I'm thinking of not flooring when gpuAcceleration is disabled. When used with gpuAcceleration disabled, you achieve no blurriness (due to the lack of a new layer the popper is promoted to with translate3d?) and pixel-perfect positioning at a minor performance cost.
Any other comments?
See: #277

Fixed


BUG - "Attach logo" button in the iFrame does nothing when submitting a new use case on the site

When I click the Attach file button to upload a company logo, nothing happens.
This only applies to the iFrame version on the website. It's not an issue with new submissions using the direct Airtable form link (https://airtable.com/shrYlu3mjtCiBTlOG).
REPLICATION STEPS

Go to https://planetcassandra.org/usecases/
Click on ADD NEW USE CASE button
In the Company Logo File field, click on the Attach file button.

ENVIRONMENT

Platform - MacOS
Browser - Google Chrome Version 114.0.5735.198 (Official Build) (x86_64)

OTHER INFO
I captured this error in the JavaScript Console:
Uncaught DOMException: Failed to read the 'localStorage' property from 'Window': Access is denied for this document.
    at new r (https://static.airtable.com/esbuild/by_sha/1a93c562/br/chunks/web_client_filepicker_v3_client-4N3QNJAU.js:23:8659)
    at new r (https://static.airtable.com/esbuild/by_sha/1a93c562/br/chunks/web_client_filepicker_v3_client-4N3QNJAU.js:23:9909)
    at new e (https://static.airtable.com/esbuild/by_sha/1a93c562/br/chunks/web_client_filepicker_v3_client-4N3QNJAU.js:23:16940)
    at Ut (https://static.airtable.com/esbuild/by_sha/1a93c562/br/chunks/web_client_filepicker_v3_client-4N3QNJAU.js:23:22062)
    at new ir (https://static.airtable.com/esbuild/by_sha/1a93c562/br/chunks/web_client_filepicker_v3_client-4N3QNJAU.js:23:24946)
    at https://static.airtable.com/esbuild/by_sha/1a93c562/br/chunks/chunk-3Q2HBD5J.js:373:158343
    at async zci (https://static.airtable.com/esbuild/by_sha/1a93c562/br/chunks/chunk-3Q2HBD5J.js:800:77534)
    at async https://static.airtable.com/esbuild/by_sha/1a93c562/br/chunks/chunk-3Q2HBD5J.js:800:80581

I cannot replicate this issue.  Following the replication steps above, I was able to upload an image to the company logo field.  I submitted the form and verified that the logo image I uploaded was indeed stored in the Airtable Submissions table.


Redis-om model randomly returns NotFoundError

The model below, with indexed fields, as pasted below, returns data without issues in 13 cases and fails 2, running the same 15 unit tests core function to retrieve the object from Redis. In to cases, however, it fails to pull data with no apparent reason; The workaround added to find ALL entries when catching exception works, but the same behavior is observed in multiple other places with different models, all related to the same query.
The environmental variables and the name parameter are the same for all tests, but it only fails on 2 runs of the same function.
It also fails to find the object in related Python debugger console attached at breakpoint.
Model definition:
class PlatformR(JsonModel):
    """DDI Platform representation."""

    model_config = ConfigDict(
        strict=False,
    )

    id: str = RedisField(index=True)
    name: str = RedisField(index=True)

    hostname: str = RedisField(index=True)
    company: str = RedisField(index=True)
    api_version: Optional[str] = None
    credentials: Optional[PlatformCredentials] = None

Lookup function
    def get_hostname_by_name(self, ddi_platform: str) -> str:
        """Get hostname by platform name."""
        logging.debug("Get hostname by platform name")
        try:
            return (
                PlatformR.find(PlatformR.name == ddi_platform).first().hostname
            )
        except NotFoundError:
            logging.error(f"Platform {ddi_platform} not found")
            ### Workaround - find all object, filter manually by Python iteration
            for platform in PlatformR.find().all():
                if platform.name == ddi_platform:
                    return platform.hostname
            raise HTTPException(
                status_code=status.HTTP_400_BAD_REQUEST,
                detail=f"Platform {ddi_platform} not found",
            )

The error is observed in 0.3.2 and 0.3.1, previously we were using 0.2.1 without observing this issue.

How large is the index you are querying, and how large is the result set when you call all?

Experiencing the same issue with an index sized at 10K approximately.
Issue with .get(Object.id == 'abcd...').
Not experiencing issues with .find(Object.id == 'abcd...').all()
redis-om version 0.3.1

How large is the index you are querying, and how large is the result set when you call all?

there are 4 keys in that specific model in the DB, approx 10KB in total, the index is 128 Bytes
Whole database in the specific environment is just 56 keys


Could not load file or assembly 'CefSharp.Core.dll' or one of its dependencies.

What version are you using? <IP_ADDRESS>

Are you using WPF/WinForms/OffScreen? WinForms.

Are you targeting .Net Core? No

when add reference of CefSharp to the project and have "Generate Serialization assembly" setting as Auto/On, it gives error: SGEN : error : Could not load file or assembly 'CefSharp.Core.dll' or one of its dependencies. The specified module could not be found.
By turning that setting to off, this error will go away. But I need that setting to be on/auto as I will require that project.XMLSerializer.dll as part of the deployment. Is there any way to resolve this? Also, this error comes only in release mode. For Debug mode the project gets compiled successfully even the setting is set to Auto.

Previous discussion on the topic at https://github.com/cefsharp/CefSharp/issues/2223#issuecomment-355150664
Closing as there is already an open issue.


SSL support for accessing api.irail.be

To trust Let's Encrypt certificate, I've added following code:
// Create a new trust manager that trust all certificates
        TrustManager[] trustAllCerts = new TrustManager[]{
            new X509TrustManager() {
                public java.security.cert.X509Certificate[] getAcceptedIssuers() {
                    return null;
                }
                public void checkClientTrusted(
                    java.security.cert.X509Certificate[] certs, String authType) {
                }
                public void checkServerTrusted(
                    java.security.cert.X509Certificate[] certs, String authType) {
                }
            }
        };

        // Activate the new trust manager
        try {
            SSLContext sc = SSLContext.getInstance("SSL");
            sc.init(null, trustAllCerts, new java.security.SecureRandom());
            HttpsURLConnection.setDefaultSSLSocketFactory(sc.getSocketFactory());
        } catch (Exception e) {
            System.out.println(e);
        }

And then retrieve the content:
        URL link = new URL(url);
        HttpsURLConnection connection = (HttpsURLConnection) link.openConnection();
        InputStream in = connection.getInputStream();

This returns following error:
javax.net.ssl.SSLException: java.lang.RuntimeException: Could not generate DH keypair%s

I think you can just use the https packet and it will work, no?

See http://alvinalexander.com/blog/post/java/simple-https-example?

You should be able to use the certificates installed on the system itself instead of implementing your own certificate authority in java over again...

I'll check tonight

I'm trying to import the certificate into the JRE by running following command in the /usr/lib/jvm/default-java/jre/lib/security folder:
keytool -import -trustcacerts -keystore cacerts -storepass changeit -noprompt -alias mycert -file ~/api.irail.be.pem

This gives following error:
Certificate was added to keystore
keytool error: java.io.FileNotFoundException: cacerts (Permission denied)

I think we'll need to ask Skyscrapers to add it as root. Not sure if this will fix it...

But it cannot be that difficult. Root CAs are installed and you should be
able to do https requests with some library...
Op di 11 okt. 2016 20:50 schreef Brecht Van de Vyvere <
<EMAIL_ADDRESS>
I'm trying to import the certificate into the JRE by running following
command in the /usr/lib/jvm/default-java/jre/lib/security folder:
keytool -import -trustcacerts -keystore cacerts -storepass changeit -noprompt -alias mycert -file ~/api.irail.be.pem
This gives following error:
Certificate was added to keystore
keytool error: java.io.FileNotFoundException: cacerts (Permission denied)
I think we'll need to ask Skyscrapers to add it as root. Not sure if this
will fix it...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/iRail/brail2gtfs-rt/issues/31#issuecomment-253009146,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAVLwbR-bx_280Z_uxQz33PCs5OoAZmHks5qy9pngaJpZM4KMYMx
.

Because it's a self-signed certificate, it needs to be added to the system authority.
So this should be done on the server too.
The SSL handshake gets initiated, but it still gives the 'Could not generate DH keypair' error...
I've checked two things:

Let's Encrypt returns a 2048 bits key, so I've set this system property:
System.setProperty("jdk.tls.ephemeralDHKeySize", "2048");
TLS_DHE_RSA_WITH_AES_128_GCM_SHA256 is the cypher suite and should be supported on java 8 (http://docs.oracle.com/javase/8/docs/technotes/guides/security/SunProviders.html#SunJSSEProvider)

Any other ideas?

But it's not self-signed... It should be available as part of the normal
root CA...
Op zo 16 okt. 2016 23:15 schreef Brecht Van de Vyvere <
<EMAIL_ADDRESS>
Because it's a self-signed certificate, it needs to be added to the system
authority.
So this should be done on the server too.
The SSL handshake gets initiated, but it still gives the 'Could not
generate DH keypair' error...
I've checked two things:

Let's Encrypt returns a 2048 bits key, so I've set this system
property: System.setProperty("jdk.tls.ephemeralDHKeySize", "2048");
TLS_DHE_RSA_WITH_AES_128_GCM_SHA256 is the cypher suite and should
be supported on java 8 (
http://docs.oracle.com/javase/8/docs/technotes/guides/security/SunProviders.html#SunJSSEProvider
)

Any other ideas?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/iRail/brail2gtfs-rt/issues/31#issuecomment-254049422,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAVLwSJo2_10JT82yhIlaLCfY3aKYBggks5q0jFlgaJpZM4KMYMx
.

Here's more information on which platforms support Let's Encrypt: https://letsencrypt.org/docs/certificate-compatibility/
SHA-2 is something that a platform codebase might not support, and "IdenTrust’s DST Root X3 certificate in its trust store" is something that might need to be added.

Thanks @tuukka
I see that Java >= JDK 8u101 is supported.
I was testing on 8u77..
To be continued

The certificate is trusted so that's not the problem.
It still gives this error:
*** Diffie-Hellman ServerKeyExchange DH Modulus:  { ... } DH Base:  { 2 } Server DH Public Key:  { ... } Anonymous main, handling exception: java.lang.RuntimeException: Could not generate DH keypair %% Invalidated:  [Session-1, TLS_DHE_RSA_WITH_AES_128_GCM_SHA256] main, SEND TLSv1.2 ALERT:  fatal, description = internal_error main, WRITE: TLSv1.2 Alert, length = 2 main, called closeSocket() javax.net.ssl.SSLException: java.lang.RuntimeException: Could not generate DH keypair

It works! 👍

Thanks a lot Brecht!


feat(Topology/Bases): add a version of Set.PairwiseDisjoint.countable_of_isOpen

Add a version for Pairwise (Disjoint on _),
not Set.PairwiseDisjoint _.

bors r+


[Fix] Client i18n rendering

This should also prevent the /about and homepage from resetting the wallet connect.
server side rendering of the translations breaks this, but speeds up when generating SSR pages.

Checking right now, the homepage translations are not coming through


Acknowledge .mjs files

Hi! sanctuary-lint assumes that files must end in js to be linted. I've added the new mjs extension to it.

Please rebase this branch when you have a minute, Aldwin. :)

Rebased.


Update onboarding for project contractors

Our onboarding process isn't structured to account for "project contractors" who work with the program on a specific project for a scoped amount of time. Project contractors, sometimes called deliverable contractors, are distinct from staff contractors, who are on a service contract and work with the team indefinitely on a variety of projects.
Consider the following:

Which Google Groups project contractors should be added to

This controls which meetings go on their calendar and G-Drive access, and they can see messages in the Group

Which Slack channels contractors should be added to? Should they be multi-channel guests instead of full access? (Outside our control)
If they need all onboarding links up-front, since it is a considerable volume
Since they likely do not have an Incident Response role, can we make it clearer that the IR training is for staff only?

Update the following:

Templates in github.com/cloud-gov/product

Consider keeping one file per role, but making checkboxes contractor- or fed-specific
Include a checkbox for talking to the onboarding buddy about project-specific items

Any other onboarding SOPs

Check with the business team
Check cg-compliance-docs

Lastly, and not project contractor specific, can we shrink the "reading" section of the onboarding tickets, moving some items to a reference section?
See also:

G-Drive folder for this item: https://drive.google.com/drive/folders/1LwKAykxK4E-5VFriaPKzNEhv5zpe2V3e
Slack thread: https://gsa-tts.slack.com/archives/GAZ7T1BNV/p1704734898384189

Resolved by linked PRs.


Little error in the installing instructions

Hi   @xdebbie! I had just cloned the repository to try to help in this project. And I had noticed that there is a little error in one of the installation commands of the README.md.

It would be nice if you could label the issue as hackoberfest and assign it to me.
I hope it helps!

Hi @agirones , thank you for the input! Sure, it is labelled and assigned now. Thank you!

Hey @dhruvdesmond, have you managed to run the script on your computer following the instructions?

yes. just cd forkkit and run the command


Allow opening signinPopup in a new tab.

This PR changes PopupWindow to allow opening signinPopup in a new browser tab.
On the current code, if I set the config popupWindowFeatures to an empty string or null, the library uses the default setting (to open in a 500x500 popup window).
This PR allow setting it to empty string or null, making the signinPopup open in a new tab. It only uses the default if the config is undefined.

Would a new tab make sense?


All work nice but some time map freeze but music play normally, how to solve this problem

        raspberry pi zero w  All are working nice but some time map freeze but music play normally, how to solve this problem,

Originally posted by @Mubarak3786 in https://github.com/nisargjhaveri/WirelessAndroidAutoDongle/issues/149#issuecomment-2321655344

We currently don't have a nice solution for this. Seems like this issue is persistent for some people. The best hunch is that interference on the 2.4 GHz wifi could be causing this and using a 5GHz wifi might solve. But I don't think we have any proof that this is the case.
If you're up for more experimentation you can try using a board with 5 GHz wifi (RPi 3 A+ or RPi 4) and see if that helps. But as I said, no guarantees that it will work. Do let us know if you do try out though. :)


Corrected 'Login into' to 'Log into'

tweek-all status check seems to be stuck?
How do I make it pass?


Update SA1110 to also check the parameter list in primary constructors

Fixes #3784

Any comments on this, @sharwell?


Security: Upgrade boom and hawk to fix hoek

Versions
v1.7.4

Repro steps
CLI currently uses old Boom and  Hawk dependencies, which loads an old version of Hoek which is vulnerable.
Desired behavior
Upgrade to latest Boom and Hawk.

Is there a temporary workaround for this? any way for a library that depends on CLI to protect itself from this vulnerability?

@literalpie we don't use it, directly or indirectly. NPM isn't smart enough to know this, so shows the vulnerability. For now it's simply a warning. We're working on it.

Is this fixed yet ?

It has been fixed in this commit https://github.com/angular/devkit/commit/c827938d313b6ad2e8a28092acd11bc16dd8fb1e
So it's fixed only in v6.0.1 of devkit which corresponds to the v6.0.1 of "@angular/cli".
To have this issue fixed, you need to update "@angular/cli" to the v6.0.1. This means you'll have to update Angular to the v6.
@hansl I would also make this change (cherry-pick?) https://github.com/angular/devkit/commit/c827938d313b6ad2e8a28092acd11bc16dd8fb1e
in the earlier version of devkit (0.3.x) so that this bug is fixed in the older version of angular-cli (1.7.x) and people don't need to update everything to v6.0.1.

I know it's not strictly an angular-cli problem but is it possible to make an Angular 6 app without pulling in the vulnerable hoek? @angular-devkit/build-angular 0.6.1 still depends on node-sass 4.9.0 which pulls the old hoek version in.

Potential regression - vulnerable lib still installed with<EMAIL_ADDRESS>

In my case this commit solved the problem (update to Angular v6) https://github.com/affilnost/ngx-chartist/commit/bfb6cffff7495ec939269fb50133eb3896a135e2
I removed node_modules and run npm install and it helped.
Now I have "hoek": "4.2.1".
Maybe it helps someone..

Upgrade boom and hawk to fix hoek : Was it fixed ?

I'm seeing the same as @adambkaplan.
> rm -rf node_modules/
> rm package-lock.json
> npm install
...
>npm ls hoek

──┬<EMAIL_ADDRESS>  └─┬<EMAIL_ADDRESS>    └─┬<EMAIL_ADDRESS>      └─┬<EMAIL_ADDRESS>        ├─┬<EMAIL_ADDRESS>        │ └──<EMAIL_ADDRESS>deduped
        ├──<EMAIL_ADDRESS>        └─┬<EMAIL_ADDRESS>          └──<EMAIL_ADDRESS>deduped

This regression was reported 20 days ago.  Is there any movement on this? Are maintainers aware of the regression?

@hansl please reopen

AFAIK node-sass was never fixed, so this was also never fixed.
> ng --version
Angular CLI: 6.0.8
> ng new my-dream-app
> cd my-dream-app
> npm install
> npm ls hoek
<EMAIL_ADDRESS>C:\git\my-dream-app
`--<EMAIL_ADDRESS>  `--<EMAIL_ADDRESS>    `--<EMAIL_ADDRESS>      `--<EMAIL_ADDRESS>        +--<EMAIL_ADDRESS>        | `--<EMAIL_ADDRESS>deduped
        +--<EMAIL_ADDRESS>        `--<EMAIL_ADDRESS>          `--<EMAIL_ADDRESS>deduped

If I understand this https://github.com/sass/node-sass/issues/2252 correctly it also wont be fixed?

@ration I see them working on it for v5: https://github.com/sass/node-sass/issues/2355

npm i hoek worked for me.

anyone solve this warning or just ignore it?

This is fixed in<EMAIL_ADDRESS>Could Sass be upgraded?

I don't know if this is a fix or a rug to sweep it under, but if you git rm package-lock.json & install dependencies with yarn install instead GitHub doesn't seem to throw this warning.

This seems to fix it:
npm install<EMAIL_ADDRESS>

I'm still getting the vulnerable version of hoek with angular-cli 6.2.3 even after doing git rm package-lock.json and npm install:
``--<EMAIL_ADDRESS>--<EMAIL_ADDRESS>   --<EMAIL_ADDRESS>--<EMAIL_ADDRESS>       --<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>| --<EMAIL_ADDRESS>deduped           +--<EMAIL_ADDRESS>         --<EMAIL_ADDRESS>--<EMAIL_ADDRESS>deduped

Can this issue be reopened? Looks like this still an issue

I'm getting the same issue despite trying to update and install the package manually.


Added "databases"

Adds https://github.com/encode/databases to the "Database Integration" section.

@tomchristie databases looks awesome! I could see it's in alpha yet, but out of curiosity: are you using it already to prototype some future service? I'll give it a shot tomorrow probably :wink:

I have something that I'll start using it with, yes.
Tho I'm pretty focused on building out more OSS tooling, rather than service-building right now. It's feasible that next up will be "and here's a fully-fledged ORM that sits on top of databases", but let's not get too far ahead of ourselves. 😝

@tomchristie hahaha yeah, that makes sense. SQLAlchemy is there now for more than 10 years and is rock solid enough to trust on it with eyes blindfolded. I think that if the necessity really grows, SQLAlchemy might end up with an async implementation by itself - we already have GINO and if my memory does not betrays me, @zzzeek once wrote in his blog (regarding the arrival of asyncio and etc) that the required changes in SQLAlchemy are actually "doable" to achieve that (section "SQLAlchemy? Asyncio? Yes?") - but he's the author, I think that thought must be deep buried in his mind ... But I'm eager to see more async stuff coming out of (or for) SQLAlchemy :sweat_smile:


Error:Failed to resolve: com.afollestad:easyvideoplayer:0.2.12

its giving this error on gradle build.

add maven { url "https://dl.bintray.com/drummer-aidan/maven" } to your repositories

thanx so much 👍


agent: loop over DHCP servers and interfaces

See here:
https://github.com/opiproject/sztp/blob/2b14bd25261e65003efcd6a4ed7a65620b436286/sztp-agent/pkg/secureagent/daemon.go#L43
there is no loop, DHCP response is processed and function returns...
We want to loop over interfaces and DHCP responses until bootstrap completes...

@glimchb  should i loop through all the network interfaces i.e, eth0, wlan0 etc?
i would like to work on this

@bhoopesh369 I think there are 2 loops here...

one is main loop...

what is process of bootstrapping failed ?
today we fail... and exit...
instead we should return to main and try again...
I think that what I had in my mind the difference between daemon and run commands...
run will run once and exit
daemon will run in a loop until success

second is all the network interfaces i.e, eth0, wlan0 etc?

wdyt ? want to propose quick design before jumping into implementation ?

Cool got it.
So one main loop that runs until the bootstrap is complete. And inside this another loop for each network interface present in the machine. If in any of the interface the bootstrap is complete then return, else keep retrying.
This function makes me think Golang should have had a try-catch block :(


Datepicker steals focus when hitting escape

Describe the bug
When using a date picker it always listens for the escape key, even when closed.
When hitting the escape key when the date picker is closed it will focus on the little calendar icon. If the date-picker is out of view the page will scroll to the picker.
How to reproduce

https://v2.clarity.design/datepicker
Hit escape
The focus will shift to the first available date picker

Expected behavior
Nothing should happen when the picker is closed.
Versions
Reproducible on Clarity 2.3.2 and Angular 8.2.14

It looks like the datepicker container needs a guard that checks the ifOpenService state to make sure that it is open before it calls this.toggleButton.nativeElement.focus().
This is the line where the datepicker escape listener is handled: https://github.com/vmware/clarity/blob/master/src/clr-angular/forms/datepicker/date-container.ts#L132

I could address this as part of the clear functionality. Or in separate PR.
Sent with GitHawk


⚠ Jenkins Plugins Artifactory has degraded performance

In 3979264, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1209 ms

Resolved: Jenkins Plugins Artifactory performance has improved in abcf4b9 after 26 minutes.


Assign vector value of np.nan if value is 'NA'

Issue with Docker login. Hopefully rerun the test with correct config.


Fullscreen watchface means no buzzing

If watchface is fullscreen (ie it doesn't load widgets), messages fail to buzz. This patch fixes it.

Do you know why this line below in the same function isn't working though? It seems like it should, if your line above gets called?
if (!quiet && (!global.WIDGETS || !WIDGETS.messages)) return Bangle.buzz(); // no widgets - just buzz to let someone know

I'd really like to figure out why, rather than adding an identical line further up.
Just some background though - we do the buzz in a timeout so you don't get a bunch of buzzes queued up if more than one message arrives at once.

That line isn't reached because the watchface is showing and the if-statement above returns:
return load("messages.app.js");
Good choice with buzzing in the timer though. It may be better if buzzing in the condition above is removed completely and instead my "patch" is applied inside the timeout.
So lines 72-74 would condense to:
if (!quiet && loadMessages && unlockWatch != false){

And the timeout function would be:
{
  exports.messageTimeout = undefined;
  if (!quiet) {  //no loadMessages condition here - buzz should happen regardless, right?
    if(global.WIDGETS && WIDGETS.messages)
      WIDGETS.messages.buzz();
    else
      Bangle.buzz();
  }
  // if we're in a clock or it's important, go straight to messages app
  if (loadMessages){
    return load("messages.app.js");
  }
  if (global.WIDGETS && WIDGETS.messages) {  // show messages if widgets are loaded
    WIDGETS.messages.show();
  }
}

I will test this solution for a couple of days.

That sounds great, thanks! I imagine it'll make things work a lot better when multiple messages are received on connection too

Hi - I'm really sorry about this - not sure how I missed your commits and forgot to merge this!
Looking at the above, I think the things you fixed here all got fixed now (albeit slightly different ways)...

The watch now buzzes if the app isn't displaying widgets
As you mentioned above, the messages app now buzzes rather than the widget to avoid the half-complete buzz (it was done by loading a special messages.new.js file rather than just messages.app.js). I think this works better as it means the message is displayed at the time you get the buzz
I think repeat:off is fixed too

The buzz=>promise change is neat though so I'll just try and tweak this PR to add that (as there are merge errors for most other stuff now) and will merge it in