The sitemap isn't validated

Hi!
I have a sitemap.xml from this addon and its created and I can visit it correctly.
But when running a validate check with http://validator.w3.org/ it gives an error:
Sorry! This document cannot be checked.
Missing "charset" attribute for "text/xml" document.
The HTTP Content-Type header (text/xml) sent by your web server (Microsoft-IIS/8.5) did not contain a "charset" parameter, but the Content-Type was one of the XML text/* sub-types.
The relevant specification (RFC 3023) specifies a strong default of "us-ascii" for such documents so we will use this value regardless of any encoding you may have indicated elsewhere.
If you would like to use a different encoding, you should arrange to have your server send this new encoding information.
Kind regards
/ Henric

This is fixed in 2.0.7. New library version pushed to the nuget.episerver.com but have to wait for it to be available.


Update README.md

Hi, I am doing a technical writing project. I just noticed a few grammar issues. Other than that, it is perfect.
IMPORTANT: By submitting a patch, you agree that your work will be licensed under the license used by the project.
If your pull request does not pass CI, it will not be merged (unless heavily justified).
Description
Please provide a description of what this PR is meant to fix, and how it works (if it's not clear from the code changes).
Tests
Please list all major test changes. All issues should have a test created to address the issue in the future (as relevant).
If closing issues, please write Closes #ISSUE_NUMBER[, #ISSUE_NUMBER2, ...], to automatically close the equivalent issue.
Note: This template is a guide, remove sections as applicable.

@romantic668 Thank you very much


Ignore-Attribute for Test-Fixtures

Hello,
I implemented the attribute to ignore the complete fixture, which was mentioned in issue: #244
The fixture is ignored if the ignore attribute is set or if every test in the fixture is ignored.

Nice work, thanks!


ReferenceError: process is not defined when using MantleProvider

I get this error when trying to use the MantleProvider in my Shopify / Remix application:
ReferenceError: process is not defined
    at LocalizedApp (https://garlic-heath-usda-cas.trycloudflare.com/app/routes/app.tsx:25:23)
    at renderWithHooks (https://garlic-heath-usda-cas.trycloudflare.com/node_modules/.vite/deps/chunk-GZD7INZN.js?v=b548b456:11548:26)
    at mountIndeterminateComponent (https://garlic-heath-usda-cas.trycloudflare.com/node_modules/.vite/deps/chunk-GZD7INZN.js?v=b548b456:14926:21)
    at beginWork (https://garlic-heath-usda-cas.trycloudflare.com/node_modules/.vite/deps/chunk-GZD7INZN.js?v=b548b456:15914:22)
    at beginWork$1 (https://garlic-heath-usda-cas.trycloudflare.com/node_modules/.vite/deps/chunk-GZD7INZN.js?v=b548b456:19753:22)
    at performUnitOfWork (https://garlic-heath-usda-cas.trycloudflare.com/node_modules/.vite/deps/chunk-GZD7INZN.js?v=b548b456:19198:20)
    at workLoopSync (https://garlic-heath-usda-cas.trycloudflare.com/node_modules/.vite/deps/chunk-GZD7INZN.js?v=b548b456:19137:13)
    at renderRootSync (https://garlic-heath-usda-cas.trycloudflare.com/node_modules/.vite/deps/chunk-GZD7INZN.js?v=b548b456:19116:15)
    at recoverFromConcurrentError (https://garlic-heath-usda-cas.trycloudflare.com/node_modules/.vite/deps/chunk-GZD7INZN.js?v=b548b456:18736:28)
    at performConcurrentWorkOnRoot (https://garlic-heath-usda-cas.trycloudflare.com/node_modules/.vite/deps/chunk-GZD7INZN.js?v=b548b456:18684:30)

here is the return of my app component:
return (
        <AppProvider
            apiKey={apiKey}
            i18n={i18n.getTranslationTree("Polaris") as TranslationDictionary}
            isEmbeddedApp
        >
            <NavMenu>
              ...
            </NavMenu>
            <MantleProvider
                appId=XXX // hardcoded
                customerApiToken=XXX // hardcoded
                apiUrl=XXX // hardcoded
            >
                <Outlet />
            </MantleProvider>
        </AppProvider>
    )

This error disappears when I comment the MantleProvider, and comes back when I uncomment. Please let me know your thoughts! Thank you!

I was using process.env above in my component to retrieve Mantle credentials, which was the cause of the error. Surprisingly, this was not throwing an error when MantleProvider was commented out!


Fix bug with filter shards

This PR should fix the following bugs:

In ListFile, all files fall into only one file shard.
ListFile does not respect block filters.
ListFile and InspectFile return incorrect file sizes when given a block filter.


Is this no longer maintained?

35 pull requests
67 open issues
last commit was over 1 year ago

If this isn't being maintained, there should be a notice in the readme, and/or seek contributors.

@ttbarnes check this one https://github.com/devmark/angular-slick-carousel

This project is totally outdated, it's depended on  slick-carousel ~1.4.1 which had breaking changes and serious bug fixes and is version ~1.6.0 now.
If you use this with new version of slick you'll get lots of errors. Plus this has serious memory leak #17.
Unless this gets major updates and maintenance, don't use it. The project  mentioned above is compatible with latest versions of slick and has less issues.

+1

@ttbarnes when an open source project reaches this level then GitHub should automatically enable a warning informing prospective users that the project is most likely not being maintained

Now, 38 pull requests, 89 issues


[SPARK-6888][SQL] Export driver quirks

Make it possible to (temporary) overwrite the driver quirks. This
can be used to overcome problems with specific schemas or to
add new jdbc driver support on the fly.
A very simple implementation to dump the loading can be done like this (spark-shell)
class DumpQuirk extends org.apache.spark.sql.jdbc.DriverQuirks {
  def canHandle(url : String): Boolean = true
  def getCatalystType(sqlType: Int, typeName: String, size: Int, md: org.apache.spark.sql.types.MetadataBuilder): org.apache.spark.sql.types.DataType = {
    println("" + (sqlType, typeName, size, md))
    null
  }
  def getJDBCType(dt: org.apache.spark.sql.types.DataType): (String, Option[Int]) = (null, None)
}
org.apache.spark.sql.jdbc.DriverQuirks.registerQuirks(new DumpQuirk())

Not that this pull request is against 1.3 - I could not create a distribution with the current master.

Can one of the admins verify this patch?

This needs a JIRA -- see https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark

Added a ticket: https://issues.apache.org/jira/browse/SPARK-6888
Will add that to the commit after some sleep .zZzZzZ

ok to test.

Test build #30332 has started for   PR 5498 at commit 9ca66d9.

This patch merges cleanly.

@liancheng thank you, will updaste the patch.
Just one question: Should I sqash/amend the fixes or should I add a second commit?

You may just add new commits to this PR. Also, would you please add tests for this feature?

Test build #30332 has finished for   PR 5498 at commit 9ca66d9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30332/
Test PASSed.

I still have to write tests for AggregatedQuirks.

Test build #30375 has started for   PR 5498 at commit 7f23484.

This patch merges cleanly.

If we are going to make this a public API we should consider a clearer name.  Perhaps. JDBCTypeMapping?  You will also need to reopen the PR against master as we don't want to add new APIs in a maintenance branch.

Test build #30375 has finished for   PR 5498 at commit 7f23484.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30375/
Test PASSed.

@marmbrus thank you, I'll fix those issues and open a new one when done.
Regarding naming/api:
It is quite common that there is one class per sql/jdbc dialect. Often called that way (e.g. MySQLDialect on hibernate). I've found quite some projects that use the same naming (via github search).
Anyway, in this case I'd like to match those namings and add a default implementation per method (returning the neutral element).
On the other hand it's currently just doing type mapping. So JDBCTypeMapping would be a very valid name, too. It would restrict the use case more (can be good or bad).
I guess you know better what would suite spark :-)

Dialect seems reasonable to me.

We will also want to mark all of these @DeveloperApi

Test build #30463 has started for   PR 5498 at commit 22d65ca.

This patch merges cleanly.

Test build #30463 has finished for   PR 5498 at commit 22d65ca.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30463/
Test FAILed.

Replaced by https://github.com/apache/spark/pull/5555


Feature request: Software MAC support

Adding support for software MACs such as the following would be a nice way of reducing component costs for less demanding applications:
https://github.com/essele/rp2040-rmii
For example, a ENC424J600 that combines both a PHY and a MAC costs $5 and change while the LAN8720A PHY costs $1.29:
https://www.microchip.com/en-us/product/ENC424J600
https://www.microchip.com/en-us/product/LAN8720A
Meanwhile a RP2040 only costs $0.70:
https://www.digikey.com/en/products/detail/raspberry-pi/SC0914-13/14306010?s=N4IgTCBcDaIEoAUwAYAsyQF0C%2BQ
Having support for a software MAC would bring down the costs of projects that need Ethernet nicely, without resorting to the limitations of the TCP offload engine in the not much cheaper W5500:
https://www.digikey.com/en/products/detail/wiznet/W5500/4425702
The main downside of the software MAC in the linked GitHub project is that the controller needs to run at a multiple of 50MHz, and must run at 100MHz or higher, when the RP2040’s stock clock speed is documented as being 133MHz, but is 125MHz at boot. The downside of running it at either 100MHz or 150MHz (or higher) is probably more than worth the reduction in BOM costs.

Nice idea, it will be more useful if software MAC can work with other chips.

Nice idea, it will be more useful if software MAC can work with other chips.

The RP2040 is somewhat special, although I imagine if there was a way to use the following with others it could be possible:
https://github.com/lawrie/fpga_pio
Interestingly, the RP2040’s PIO is powerful enough to output a DVI signal needed for 720p HDMI:
https://github.com/Wren6991/picodvi
Note that I am writing from my superficial understanding. I only did preliminary research and then decided to use the ENC424J600 for my application as the volume is too low to justify developing this right now. I will send patches based on what I have done with the RP2040 + ENC424J600 in the near future after things are closer to a production ready state.


Redeclare Svg.reload as throwing an exception.

The .pxd file must match the .pyx file lest cimporters don't check for an exception.

Should be fine, thanks :)


Blank Screen when running examples/svelte

Describe the bug
I cloned the svelte app from the examples repo, installed dependencies (removed the relative path in Cargo.toml), and ran the tauri:prod:build script. Running the resulting binary only showed a white window, the app did not appear to be running.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
I expected the svelte app to show.
Platform and Versions (please complete the following information):
Operating System - Windows_NT(10.0.18363) - win32/x64
Node.js environment
Node.js - 13.7.0
tauri.js - 0.4.3
Rust environment
rustc - 1.41.0
cargo - 1.41.0
tauri-bundler - 0.4.0
Global packages
NPM - 6.13.6
yarn - 1.22.0

Did you enabled loopback interface?
Like this:
CheckNetIsolation.exe LoopbackExempt -a -n="Microsoft.Win32WebViewHost_cw5n1h2txyewy"

Yes. Just to make sure I just ran that command again (as administrator, in powershell), there is no change.

Are you using the edge feature flag or IE?  Ill take a look at it tomorrow.

@tensor-programming I had this issue with edge, as I left tauri.config.json as it was when I cloned it. However, I just tried building with the edge flag set to false, and I got the following error:

I clicked yes, however the screen remained blank nevertheless.

We had some ES6 syntax on our codebase, and also Svelte was crashing IE because it has a function with a default parameter specified, so I had to change the example to transpile it using Babel. This will be ready on the next deploy, and you can check it out right now by building from source.


Is it possible to implement onDisconnect method?

In Javascript, it is possible to pre-define the function/codes to be executed on the server side through the onDisconnect event. (such as remove its content)
Is it possible to do so in AS3?
Thanks in advance.

Hi,
You can implement this on several ways. For example in AIR mobile I detect when the user leaves the chat screen, when that happens I close and dispose the URLStream.
You only need to do something like:
myURLStream.removeEventListener(ProgressEvent.PROGRESS, myFunction);
myFunction is the same function that receives the messages.
You can see a full implementation in the following file:
https://github.com/PhantomAppDevelopment/pizza-app/blob/master/src/chatScreens/ChatScreen.as#L239
In the previous example on the dispose() function I can do anything I want, such as cleaning up objects or sending a request to the server.

Hi agentphantom, sorry i don't quite get it. The onDisconnect is "used to manage operations that will be run on the server when the clients disconnect". Here, what i mean is when the user suddenly loses the internet connection. The onDisconnect is used to 'pre-define' what actions to be executed on the database (such as removes the user ID) when the server detects that the user has been disconnected.
When you mention 'dispose()' function, how does it 'send a request to the server' when it is already disconnected (say he loses internet connection)?

Hi,
Now I fully understand what you mean. Right now the REST API and by extension the AS3 API officially don't support this feature (unless you use an ANE).
I took a look at the JavaScript SDK and found out that the onDisconnect function sends a small request to the server with specific strings "cancel", "remove", "set".
Problem is, the JavaScript SDK is minified, and that's just an educated guess from what I could understand.
Maybe it can be ported for AS3, but I don't know enough JavaScript to debug it. If you wish you can give it a try with JavaScript, debug all the requests that are sent, paste them here and then I can port it to AS3.

Thanks for your reply. To be honest, i have no idea how to debug this. The network tab on the browser shows nothing even though i debug through the codes line by line.  Anyway, i will continue looking into this.

I posted the question in stackoverflow. Meanwhile, i found an un-minified version of the firebase at here. Still in the attempts of understanding the magic behind...

Thanks!
I read the question and they have the right idea. Monitoring the outgoing traffic will do the trick.
I believe that a network analyzer like Wireshark can do the job.
Meanwhile I will keep reading the JS file to see if I can find the answer there.

This block looks interesting:
onDisconnectPut:function(pathString, data, opt_onComplete) {   if (this.connected_) {     this.sendOnDisconnect_("o", pathString, data, opt_onComplete);   } else {     this.onDisconnectRequestQueue_.push({pathString:pathString, action:"o", data:data, onComplete:opt_onComplete});   } }, onDisconnectMerge:function(pathString, data, opt_onComplete) {   if (this.connected_) {     this.sendOnDisconnect_("om", pathString, data, opt_onComplete);   } else {     this.onDisconnectRequestQueue_.push({pathString:pathString, action:"om", data:data, onComplete:opt_onComplete});   } }, onDisconnectCancel:function(pathString, opt_onComplete) {   if (this.connected_) {     this.sendOnDisconnect_("oc", pathString, null, opt_onComplete);   } else {     this.onDisconnectRequestQueue_.push({pathString:pathString, action:"oc", data:null, onComplete:opt_onComplete});   }

I finally saw something like this at the network tab:

it seems like web socket or sth.
And when i click on that, it shows:

(the 'ns' is my firebase namespace).
I am not sure if the normal REST API through urlrequest is able to achieve this, as mentioned by one guy in the stackoverflow....

Thanks for sharing those pictures!
Maybe the 'v' parameter does something special.
URLStream behaves almost the same as a websocket, the difference is that all the headers and responses are abstracted so you have an easier time sending and receiving them.
Disregard the commend about URLRequest, that guy doesn't know what he's talking about. URLRequest just describes what you want to do, it doesn't do any net connection by itself.
My recommendation is to find a way to read the outgoing traffic, there lies the answer.

Thank you for your reply.

Sorry for the long delay. Finally i am trying to use wireshark to capture something... However, i don't i think i understand what is being captured, as attached.
The only recognize-able letters are .....firebaseio.com.....
Did i miss out something in the wireshark?

Hi,
My bad! I did some research and Wireshark is to analyze traffic after it has been processed, that's why the output is encrypted.
I recommend to use Fiddler: http://www.telerik.com/fiddler
This one analyzes the HTTP and HTTPS requests before they are sent (similar to the ones you added here some days ago), but it says its more complete.
If you wish you can give it another go with Fiddler and report back your findings.

Hi,
I managed to install and try the Fiddler. But I have no idea which part of the tabs show the 'data transferred' over the network. For example, if i perform login to facebook, i expect my username and password to be captured through the fiddler right? But i see nothing meaningful... Correct me if i am wrong.

You can try this tutorial, it looks very useful:
https://www.ibm.com/developerworks/community/blogs/f37f6f3c-d39f-49c9-884b-a1665b7e2ca3/entry/tutorial_how_to_capture_http_traffic_using_the_fiddler_web_debugging_proxy?lang=en

Hi Phantom,
I think i saw something. But before anything, could you please tell me how to connect to 'websocket' in AS3?
Say the end point is sth like:
..wss://s-usc1c-nss-129.firebaseio.com/.ws?...
i don't think URLLoader or URLRequest would work.

HI,
I haven't tried this but it looks very complete and useful:
https://github.com/theturtle32/AS3WebSocket
Seeing at the examples it is very similar to setup like an URLStream.

Thanks for you reply. i actually tried that. but it throws some errors:
Definition com.adobe.net.URI could not be found.
Definition com.adobe.net.URIEncodingBitmap could not be found.
Definition com.adobe.utils.StringUtil could not be found.
Anyway, this is what i found. i use websocket plugin from firefox instead, that enables me to view what has been sent to the firebase

However, that seems to be sent over the websocket, but not throught database REST API?

My Bad, i didn't include the as3corlib. Now seems i am able to 'connect'. I will further post after more testing.

Ohh, interesting.
It sends a nested JSON with different parameters:
t (type maybe?) = "d" (probably refers to disconnect
d (a data object containing the payload)
r (no idea) = 4 (maybe it is a priority of some sorts)
a (action maybe) = "o" could be linked to a specific task such as on disconnected, I remember there are several onDisconnect variations.
b (a nested object containing the data, no clue what b could stand for)
p (path) = /allUser/3
d (data) = "Hey I'm disconnect"
With this new finding I can take another look at the unminified library.
I will update this comment if I find something new.
Thanks!

Hi Phantom,
I think you are almost right (with those parameters). I have tested with the local machine and it seems working. The conclusion is, it is feasible through the Web Socket, but not the REST API. (a bit of trouble but still it works) I have to thank you for your insights provided. I can rest in peace now. lol
[you may close this post :)]

That's great!
I will experiment with it and add it to the guide in the coming weeks.


chef-full bootstrap template/script should respect chef_config[:chef_client_path] (aka. CHEF-5115)

We would like to install the Chef Client in a custom directory. Therefore I reopen CHEF-5115 here:

I realized on PR 1295 for CHEF-5102 that the chef-full script looks for a fixed chef-client location to determine if it needs to install or not, but the chef_config[:chef_client_path] setting can change that location.
We should fix this. There aren't any tests around this script, because that's hard, so we'll have to test it manually.

So it's just https://github.com/opscode/chef/blob/master/lib/chef/knife/bootstrap/chef-full.erb#L26 ?
You can use a custom bootstrap template, see https://docs.chef.io/knife_bootstrap.html#custom-templates

Yes, this would probably fix CHEF-5115.
But if you want to install Chef Client in a custom directory that's only one half of the problem. It's just how the installation script checks if Chef Client is already installed. The installation itself is done by https://www.opscode.com/chef/install.sh.

IMHO:
If your business really takes value out of customizing the chef install location (which I doubt), consider forking and maintaining https://github.com/opscode/omnibus-chef and build your own installer-packages with it. The default_root can be overwritten and defaults to '/opt', see https://github.com/opscode/omnibus/blob/master/lib/omnibus/project.rb#L189 and https://github.com/opscode/omnibus-chef/blob/master/config/projects/chef.rb#L38
…or bootstrap using Ruby and rubygems.
But IMHO you should really consider going with the (sane) defaults of omnibus-chef. Maybe symlink /opt/ chef/ to another location of your choice, but stick with the other defaults.

@rmoriz just gave the correct answer.  internally we have a separate project which we build that installs into another location so that we can then use that chef to manage servers which build omnibus-chef in /opt/chef, so we wound up internally following that process.  a relocatable rpm/deb package is a hard problem and we won't be solving it any time soon.


[TC-329] hosting.config not matching with dynamic regex remap

See https://github.com/Comcast/traffic_control/issues/1562
The hosting.config has an entry for the origin created in the Delivery service UI for a live server (volume=2 which is RAM). The problem comes when we use a REGEX to set an origin dynamically.
Example Origin URL : http://server01.kabletown.net
Then the Regex is the following : ^/(server\w\d\d)/([^?]+)(?:\.m3u8|)(.*)$ http://$1-.kabletown.net/$2
The result in the hosting.config is :
hostname=server01.kabletown.net volume=2
hostname=*   volume=1
If the remap ends up with server02.kabletown.net then disks are used instead of RAM.
 @smalenfant smalenfant added bug Traffic Ops labels on Jun 28, 2016
 @smalenfant
     Member
smalenfant commented on Jun 28, 2016
There is also another side effect with the parent.config.
 @knutsel
     Member
knutsel commented on Jun 29, 2016
We could add hosting_override and parent_override columns to the delveryservice table, but that seems a bit too ATS specific? Or an overrides table that is linked to the ds table that has file -> override line?
@dg4prez : you had similar use cases recently, I think? Any thoughts on this?
 @dg4prez
     Collaborator
dg4prez commented on Jun 29, 2016 • edited
Perhaps rather than cluttering up regex remap with more overrides for that specific use case, we remove regex remap in favor of adding more manual options to any_map. Then we could directly write the configs entries we want. I've given some rough thought to how we'd do that, though I haven't applied it to the hosting.config so we'd need to add that in there as well. Note that these would all be for advanced users who fully comprehend how traffic server works. In my opinion this is already the case for any_map and regex remap, anyway.
Database changes
add table anymap (deliveryservice_anymap)
ID, remap text, edge_header, mid_header, type (edge, mid, etc), last updated
add table anyparent (deliveryservice_edgeparent)
ID, parent text, type (edge, mid, etc), last updated
#autogenerated by cachegroup for edge types, fully manual for mid
add table includes (deliveryservice_includes)
ID, file_name, file_content (this would need to be a large field), type (edge, mid, etc), last updated
UI
Origin server base URL - remove this
Use MSO feature - remove this
Remap Entries - create entries the same way we create them for regex entries - add one or a whole bunch. probably don't need order. Group of the following for each.
Raw Remap Text:
Edge Header Rewrite:
Mid Header Rewrite:
Tier Assignment: (edge, mid, etc checkboxes)
Note that in order to include header rewrite entries for each the header name would need to be something like xml_id_1, xml_id_2, etc. Not sure of the best answer, yet. Maybe the best way would be to place a line under each header saying what the user would need to add to the remap line in order to include it, or maybe the best way would be to have the system automatically append it.
Parent entries - Same as remap entries, add as many as needed
Mid Parent text:
Tier assignment: (edge, mid, etc checkboxes)
Manual includes - files we want to reference on the map lines like header rewrites etc that don't exist. We'd add each one, and the user would include the filename and contents.
Author: Jan van Doorn
JIRA Link: https://issues.apache.org/jira/browse/TC-329

@dg4prez - can we close this? I think we should. Voluspa may change all this in any case, and @rawlinp is also working on some BYOT ideas....


chore(build): Update engines constraints in all package.json

Signed-off-by: Jerome Simeon<EMAIL_ADDRESS>Changes

Update all engines descriptions in package.json files to require node 14
Upgrade to Ergo 0.23.0-alpha.3 with bug fixes and improvements

Coverage remained the same at 93.936% when pulling cf18fbb2328ef8a9413ab15dfb526edc9643d048 on jeromesimeon:js-node-14 into 38b285527dd06258601c9da64d7ab7350dbedec6 on accordproject:master.


[KLIMADAO/Klimadao] Polygon-digital-carbon for retirement data

Description
Removes bridged-carbon from fetching retirement data for /retirements and /retirements/[index].
Eventually /retirements will be moved to an endpoint. This is an interim solution for ICR; the ICR retirement data is only available on digital-carbon.
NOTES:

This PR uses several subgraphs deployed to testing (i.e. personal) accounts.  This PR should not be merged until they are deployed under the main klimadao (or maybe now new one for carbonmark?) graph account.
I'm using a placeholder ICR logo for now:

Open question as to what image should be used for the ICR logo

Anything in site/ can be ignored

Related Ticket
Closes #1938
Also related to #2047
Notes For QA

Specific pages, components or journeys that might be affected:

/retirements and /retirements/[index]

Relevant preview URLs:

Below

Other notes:

Just pinging @0xtapi for QA, even though I trust typescript and our schemas, i'm still worried about regressions
These are the pages that touched

retirement pages /retirement/[beneficiary_address]/[index]
the retirement PDF (click download button on above page)
retire from portfolio form /portfolio/[token_address]/retire

Checked pages, PDF, retired some carbon... found no issues on any of those pages/actions ✅

@psparacino where are we at with this?

@0xemc The staging subgraph is now fully synced so I can swap that one in and use that for the time being until the main one is deployed/synced. I don't think there any reason that won't work for the interim in order to get this merged

@0xemc The staging subgraph is now fully synced so it should be an immediate deploy to main once the PR is merged in the subgraph repo. All the prod subgraphs have been updated in this pr so once the main deployment is ready we can just hit merge.

Cool thanks, can you link the dependent subgraph repo PR here please?

@0xemc Repo: https://github.com/KlimaDAO/klima-subgraph
Once this PR is merged as far as I understand the main deployment should be live almost immediately

@0xemc Just fyi, there was a bump in the road and although it's been deployed to main it'll now (unexpectedly) require almost a day to sync again. The staging subgraph is up to date however. I can put that one in for now and then do a quick fix PR tomorrow when the main deployment syncs. Or wait and just merge all at once, whichever works best

@psparacino it's still not clear to me why it was necessary to wait for the subgraph PR since the preview build was passing with the updated subgraph url in lib/constants.ts?
This suggests to me we are not capturing or covering some possible source of bugs in our build pipeline. Can you TLDR this for me?

@0xemc The essential difference is that this PR requires the hash attribute on the retire entity (which the current subgraph deployed to klimadao/polygon-digital-carbon does not have).
Everything builds but the page will 404 if used with the current main subgraph. Just tried both locally with old and new to confirm.


[ENH] Deprecate FetchSegmentOperator

Description of changes
Summarize the changes made by this PR.

Improvements & Bug fixes

N/A

New functionality

Deprecate FetchSegmentOperator since the query node already receives the full collection information from the frontend.

Test plan
How are these changes tested?

[ ] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?
N/A

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#3261  👈 (View in Graphite)
#3255
#3252
#3243
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Merge activity

Dec 17, 5:51 PM EST: A user started a stack merge that includes this pull request via Graphite.


When using the bind:ref with components, getting error

Describe the bug
When using the bind:ref with the components, keep getting this error:
Uncaught (in promise) Svelte error: props_invalid_value
Cannot do bind:ref={undefined} when ref has a fallback value
And the component fails to render
Reproduction
Setup a sveltekit project and following instruction on:
https://next.shadcn-svelte.com/docs/installation/sveltekit
to get setup with shadcn.

Hey @ieedan yes it does! Seems like I might make a PR with all the components in bits/shadcn be updated to have this :)

Another way would be to just use:
<script>
let boundRef = $state(null)
</script>

<Button bind:ref{boundRef}><!-- content --> </Button>

Guess I'll just do that  in the meantime

The workaround with setting the initial value be null works fine.

I think the right thing to do is to PR and remove the null I can open one tomorrow

@ieedan, defaulting to null is by design. It aligns with what is used in all Bits UI components and aligns to the same return type as document.getElementById.

&& I despise idea of passing undefined as a prop and getting something populated up because when you don't bind:, passing undefined is the same as not passing the prop at all.

I do find the bindings a bit weird at the moment I don't quite understand the whole you can't bind to something with a default value

I do find the bindings a bit weird at the moment I don't quite understand the whole you can't bind to something with a default value

I think it has something to do with you technically passing undefined, which is the same as not passing a prop. This results in the fallback/default value being used, resulting in two separate signals (your undefined signal and the one internal to the component created via the fallback), creating a disconnected mess of sorts.
I asked about this early on in an internal Svelte chat, I can try to dig up the answer I was given to make it make more sense :)

I do find the bindings a bit weird at the moment I don't quite understand the whole you can't bind to something with a default value

I think it has something to do with you technically passing undefined, which is the same as not passing a prop. This results in the fallback/default value being used, resulting in two separate signals (your undefined signal and the one internal to the component created via the fallback), creating a disconnected mess of sorts.
I asked about this early on in an internal Svelte chat, I can try to dig up the answer I was given to make it make more sense :) @ieedan

Yeah if you don't mind finding it I'd love more context!


Tweak the pre-processor condition, for Node.js environments, in the animationStarted helper (issue 13057)

While it's still not entirely clear if this would've prevented the issue as reported, given that the particular use-case reported apparently no longer applies, this small change really cannot hurt in general and it won't effect "regular" viewer builds in any way.
Fixes #13057, to the extent that doing so is even necessary now given https://github.com/mozilla/pdf.js/issues/13057#issuecomment-803104197.

Thanks!


ReadFileBytes panics when a provided path is empty

When the ReadFileBytes function is called with an empty string as the file path (ReadFileBytes("")), it leads to panic because the subsequent call to the expandHomePath function checks if the first character is a tilde. While this issue might not immediately expose a vulnerability, it could cause disruptions in certain scenarios.
To mitigate this, it is recommended to:

Proactively check for empty paths. To prevent the panic scenario, add an early check at the beginning of the expandHomePath function to ensure the file path is not empty.
Review the codebase for duplicated code. We detected the presence of duplicate, error-prone ReadFileBytes functions within the go-authcrunch package.
Implement unit testing. To ensure the correct functionality of these functions, comprehensive unit tests should be created. These tests should cover various scenarios, including valid and invalid file paths.
Leverage fuzz testing. In addition to unit tests, use Golang’s native fuzz tests to increase the robustness of the go-authcrunch package. Native fuzz tests can be conveniently appended to the regular *_test.go test suite and do not need any overhead.

While this issue might not immediately expose a vulnerability, it could cause disruptions in certain scenarios.

Could you please elaborate with a pragmatic example?

When would someone use that function in a way that does not fail through panic at the start, only later to become a vulnerability or disruption?
What would happen differently in that scenario if the panic was avoided instead?


use socket as client only

Hi Juks,
I want to know if i neeed some custom thingd to use SQ as client rather than host in order to connect to another ISO host
Or send an iso message through SQ from http client to an ISO host. In this case, SQ will be serve as SWITCH

Hi!
No you do not need any custom thing. The client part is already implemented into the application.

Hi juks
Thank you for your feedback
I want to use SQ as client to connect to an iso host with fix header (length + fixheader +message)
To résume the host target has some specifications like :
Send sign on to host each first connections and after that others logics (key exchange and  that part has been done by customizing some code in SQ in isopacket and logics / packager
Now the issue is about received iso message from host
SQ say faulty invalid message in red

Hi!
The common message restrictions are defined here: https://github.com/juks/SocketQueue/blob/653ad6e888ebf6fb90399eaa4e8a216e103cbfda/lib/iso8583/lib/packager/smartVista.js#L24
And the test client source can be found in this file https://github.com/juks/SocketQueue/blob/master/lib/testSuite/lib/testClient.js

Hi,
Thank you for this feedback.
Kindly find below capture related to the problem encountered

obligatory fields in my custom packager
  '1804': [0, 1, 7, 11,12,24, 25,33 ,37,128],   '1200': [0, 1, 3, 4, 7, 11, 12, 22, 24, 25, 41, 42, 49],  '1100': [0, 1, 2, 3, 4, 5, 6 ,7, 11, 12, 22, 24, 41, 42, 49],  '1420': [0, 1, 3, 4, 7, 11, 12, 22, 24, 25, 41, 42, 49]

2019-08-26 09:27:10 - verbose: ISO SQ Host Sign on resquest
================================================================================================

 [Sign on Request]

 Message Type Indicator [0].......................1804
 Bitmap [1].......................................82300180880000000000000000000001
 Transmission Date and Time [7]...................1908260927
 System Trace Audit Number [11]...................575070
 Time, Local Transaction [12].....................190826092710
 Function Code [24]...............................801
 Message reason code [25].........................0000
 Code identification de organisme initiateur [33].505290
 Retrieval Reference Number [37]..................021445444832
 MAC [128]........................................00000000

================================================================================================
(node:8284) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
2019-08-26 09:27:15 - info: Got data from ISO-host (94b)
2019-08-26 09:27:15 - verbose: [0090ISO701000001814.0..............190826092757507019082609271006505290021445444...80000000000]
2019-08-26 09:27:15 - verbose: [30 30 39 30 49 53 4f 37 30 31 30 30 30 30 30 31 38 31 34 82 30 00 00 8a 00 00 00 00 00 00 00 00 00 00 01 31 39 30 38 32 36 30 39 32 37 35 37 35 30 37 30 31 39 30 38 32 36 30 39 32 37 31 30 30 36 35 30 35 32 39 30 30 32 31 34 34 35 34 34 34 00 00 00 38 30 30 30 30 30 30 30 30 30 30]
2019-08-26 09:27:15 - verbose: []
2019-08-26 09:27:15 - info: ISO host: failed to parse ISO host iso8583 packet
2019-08-26 09:27:15 - verbose: Invalid message!
2019-08-26 09:27:15 - verbose: [NOE]
2019-08-26 09:27:15 - verbose: [1814.0..............190826092757507019082609271006505290021445444...80000000000]
2019-08-26 09:27:15 - info: Upstream error: ISO host sent data with no client connected! Ignoring...
ISO host says
 [ <faulty>]

 Message Type Indicator [0].......................1814
 Bitmap [1].......................................823000008A0000000000000000000001
 Transmission Date and Time [7]...................1908260927
 System Trace Audit Number [11]...................575070
 Time, Local Transaction [12].....................190826092710
 Code identification de organisme initiateur [33].505290
 Retrieval Reference Number [37]..................21445444
 Response code [39]...............................800
 MAC [128]........................................00000000

================================================================================================
Moreover, the testClient is not used in my project here. Juste the  Upstream.js

There must me some header misconfiguration, so you get no message.
The basic check the triggers "Invalid message!" notice is here https://github.com/juks/SocketQueue/blob/653ad6e888ebf6fb90399eaa4e8a216e103cbfda/lib/iso8583/lib/packager/smartVista.js#L313


make documentation available easier

Original report by Galen O'Neil (Bitbucket: oneilg, GitHub: oneilg).

I figured out how to get sphinx to build the mass documentation to a static html page. The work is in
https://bitbucket.org/joe_fowler/mass/branch/docs
But, I don't know the best way to make this available.

readthedocs.org requires the repo to be public
readthedocs.com is $50/month
bitbucket pages allows you to host static websites, figuring out how to deploy is some bash/git trickiness. the easiest solution would involve commiting the html files of the docs to the repo, which we should probably avoid. It's probably possible to avoid this.
github pages, basically the same restrictions as github pages
have setup.py build the docs locally and tell people how to get to them. prevents us linking to specific docs.

I learned during this attempt that NIST does pay for a small license to Travis-ci.org, but you have to call Casey Hume to get it setup for a specific repo in the NIST usnistgov group/organization.

Original comment by Joseph Fowler (Bitbucket: joe_fowler, ).

I merged your docs branch. Does that mean this issue should be closed? Or do we still need to do something else?

Original comment by Galen O'Neil (Bitbucket: oneilg, GitHub: oneilg).

Also, the documentation build process depends on the recommonmark and sphinx packages, and I think we'd rather not install them every time we install mass. Or should I just not worry about installing extra dependencies and adding stuff to the repo?


plasma5Packages.ksysguard: remove if !allowAliases

Motivation for this change
Usually in Nixpkgs, attributes that are remnants of old packages are only included when aliases are enabled (which they are by default). This brings plasma5Packages into line with that, and also makes it easier to check the whole thing evaluates when working on the package set.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

That the name "allow" means "throw an error" is worse than useless, but that's not your fault. :frowning:

To be fair, this applies to all aliases (with most of them defined in pkgs/top-level/aliases.nix) where a lot of them point to a different attribute (i.e. a backwards-compat alias for a renamed package attribute), however some aliases indicate a full removal where an error is thrown.
What I'm trying to say is: yes, the naming is in this case unfortunate, but since most of the aliases point to a different package, there's a reason behind the naming :)

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/aliasing-ksysguard/16906/1


Impossible to waeve code into external dependencies like appcompat or okhttp

I planned to use this library for tracing purposes to add an interceptor to okhttpclient. I guess targeting classes outside of the project is a limitation of this library, so that targeting classes within okhttp3 package is impossible. It might be good to mention this limitation and others in the README to avoid late suprises.

Thanks @mlilienberg. Question for you. Do you currently have this configuration setting defined?  The filter was introduced to actually avoid what you're trying to do. In other words, we found that AOP weaving was occurring on more than just our own code, which was undesirable for us. Sounds like you actually want it though. And this may be a solution.

I think likely related to #2

I just happen to be working on implementing this plugin in a project that has a lot of okhttp clients and interceptors and can confirm removing the filter allows me to weave into interceptors.
    @Before("execution(* *.intercept(..))")
    fun intercept(joinPoint: JoinPoint) {
        println("attached intercept: " + joinPoint.sourceLocation + joinPoint.signature.name)
    }

Thanks for following up on my question.
I am not setting any aopWeave configuration. But i see in aop.log that other aspects in our classpath are recognized. When i use a path to target only project specific Aspects the log looks fine and only our own Aspects are processed. For me this looks all good as i can control what Aspects should be processed but i cannot target third party dependencies in those.
What i need is targeting a class living in okhttp package itself. @bsautner i think your aspect is working because your project contains implementations of okhttp3.Interceptor which become target of your aspect. It would not weave code into interceptors that are defined in third party libraries.
My goal is to trace all network communication through okhttp like firebase.performance or Instana does. For this instana is using such an Aspect processed with https://github.com/Archinamon/android-gradle-aspectj . But this does not support the latest android gradle plugin (4.2.0) anymore.
object MyInterceptor: Interceptor {
    override fun intercept(chain: Interceptor.Chain): Response {
        return chain.proceed(chain.request())
    }
}

@Aspect
class KotlinAspect {
    @Before("execution(* okhttp3.OkHttpClient.Builder.build(..))")
    fun addNetworkInterceptor(joinPoint: JoinPoint) {
        val target = joinPoint.target as OkHttpClient.Builder
        target.addInterceptor(MyInterceptor)
    }
}

Thanks all. @mlilienberg I'm going to set up a sample project locally and investigate. I'll report back.

@mlilienberg I discovered something new (well, at lest, new to me). And I think I might be a simple solution to your particular problem. Have you looked into using call instead of execution?
As we've established, In your example code you are trying to weave the okhttp3.OkHttpClient.Builder.build(..) method, and therefore, the Builder class which is in the OkHttp3 library. Yet our plugin, by default, attempts to only weave your project code.
The difference between call and execution is where the weave happens. If all of the calls to okhttp3.OkHttpClient.Builder.build(..) occur from code in your project, then you can use call instead, and it will work. I tested this out myself and I didn't even have to change your Aspect code. It just works, because it weave the code calling the build() method.
Example:
    @Before("call(* okhttp3.OkHttpClient.Builder.build(..))")
    fun addNetworkInterceptor(joinPoint: JoinPoint) {
        val target = joinPoint.target as OkHttpClient.Builder
        target.addInterceptor(MyInterceptor)
    }

@eschlenz thanks for your investigations. You solution is great for a lot of use cases. Unfortunately it is not applicable when the main goal of using AOP is not only separation of concerns but mostly to weave code into libraries you normally have no access to.
With firebase performance or Instana we got to know about a lot of network traffic we were not aware of, because they weave code into all UrlConnectionClient or OkttpClient instances. With a single aspect we could inspect traffic from image loading libraries like coil or glide or any other third party sdk that is using those network clients. Weaving code into appcompat classes like fragment or activity lifecycle methods could be another use case.
The limitation is also mentioned at the end of this article: https://jdvp.me/articles/Switching-AspectJ-Plugins-Android
I am not sure if this demand can be handled with the pipeline approach at all but it might help others, when this limitation is mentioned in the README. Even if this SDK is used to target internal classes only it might block later modularization attempts when the project becomes bigger.

I totally understand, and hear what you're saying. And I agree. I've been doing more research on this today in hopes of a quick fix, but haven't had much success.
I tried including both the project classes and the OkHttp library as targets for AspectJ. While this did produce the woven bytecode classes for OkHttp, it put that output beside the project classes. And then it seems as though the original OkHttp dependency (not woven) ended up being selected during APK assembly. So at runtime, the unwoven classes were still used.
I spent a bunch of time seeing if I could rewire the Gradle tasks a bit, but hit a wall.
I still think this is doable, though. I believe the correct way to approach this is to make use of Gradle Transforms. Transforms essentially let you modify dependency libraries. This is actually how Android's Jetifier works.
For the short term, I'm afraid I don't have a solution ready to go. However, I do think the Transform route is something we should pursue. So I will work with my team to define this work, and find a time to introduce it. With that in mind, I think it makes sense to keep this issue open for now.
Sorry I couldn't find a quick win for you.

Thanks for all the energy you put into this SDK, even with this limitation it is already amazing. I was aiming for a quick win but if this is possible in the future, it would be awesome.

I opened a PR that may help here
https://github.com/Ibotta/gradle-aspectj-pipeline-plugin/pull/18
My need is that I wrote a library that contains the AspectJ rules + UI to instrument code that is in our other apps.

One way of achieving it (of-course with some limitations) https://github.com/mbhaskar98/okhttp-aop


wfg_drive_spi: glitches on cs line

On real hardware the chip select line shows glitches

This seems to have been fixed during refactoring.


Tracking

We would consider 2 tracking options for scatter series, linear series, and bar series. The first one will be the closest existing point from all the series (this could be archived using a Voronoi diagram).
The second option is to find the closest X value, considering X as the independent axis. This should return the closest value of all the series at the X-axis. The range series only should implement this case, returning the corresponding limits.
Will be needed to see the values of series when I move the mouse over a position in a plot, giving a tooltip or visual hint of the tracked position and the requested data, similar to this case https://airbnb.io/visx/xychart

The react component should accept 2 properties:

onMouseMove
onClick

To which we will send a callback that is called with the following object:
{
event,
coordinates: {x1: 0, x2: 2, y1: 3},
series: {
a: {closestX, closestY, closest},
b: {closestX, closedY, closest},
}
}
Remarks:

event is the dom event object and contains information like the position in pixel in the dom
coordinates is the position of the mouse on all the axis in the axis units
series is an object containing one property (the series ID) per series. Each series has the following property

closestX: the closest Point (we give back the object) considering only the X value
closestY: the closest Point considering only the Y value
closest: the closest Point (Euclidean distance)

There's no x and y axis, because this could be done in any of the elements of the axis array, so I'll propose the following change:
interface TrackingResults {
  event: HTMLEvent;
  coordinates: {
    [axisId: string]: Record<string, number>; // Ranges, errors, values, etc
  };
  series: {
    [seriesId: string]: {
      [axisId: string]: SeriesPointType;
      closest: SeriesPointType; // Euclidean distance
    };
  };
};

The second thing is how to approach to this implementation, should it be inside the  element?

The second thing is how to approach to this implementation, should it be inside the element?

You mean should it be inside react-plot ? Yes, I think we don't have a choice, as the information is all inside the component.
How I would approach it is by conditionally adding a layer (group) with the event handlers and the logic.

For now, let's only focus on emitting the event, and the user can react to it (for example by updating an annotation)

Hello I want your opinion on the following thing. In react-plot the data is in a Series component, so if I want the closest point, because they are siblings, the components needs to connect through the father, that is Plot
<Plot>
  <LineSeries data={data1} xAxis="x" yAxis="y" />
  <LineSeries data={data2} xAxis="x" yAxis="y" />
  <LineSeries data={data3} xAxis="x" yAxis="y" />
  <Axis id="x" position="bottom" />
  <Axis id="y" position="left" />
  <Tracking onMouseMove={/* Here I get the values */} />
</Plot>

What strategy will you follow for sending the nearest point of each series to the tracking? At this moment I think of two options: having a context for the data, where every data from every series is added, and then in the tracking I search over this context or create a reducer event, where the tracking component pushes every requested point, each series listen to this event and returns the closest point and then the tracking component only listen to this responses and merges.
Example option 1: useEffect on LineSeries add data1, data2 and data3 to dataContext, and in Tracking onMouseMove I search over dataContext
Example option 2: onMouseMove pushes {x, y} to the closestContext stack and each LineSeries adds its <key, value> that is close to that point

Is there an advantage of using a <Tracking> component over just props on the Plot: <Plot onMouseMove={} ?

In a near future you could use render props for the tooltip, something like
<Tracking>
{ ({ coordinates }) =>
  <div style={{ left: coordinates.x, top: coordinates.y }} />
}
</Tracking>

That's something else. I think the tracking itself should be exposed at the top level.

Ok, even changing to the top level, we have to communicate through context to the Series children. Should we create a specific context for this and each time that the event has triggered the children make the closest calculation, or should we send the data to the parent on each series mount and in each event search on this loaded data?

It seems easier to handle this in the parent.

If you add data to a context in the parent, don't forget to cleanup the context when the Serie unmounts

With closest, should we search for the closest over the scaled value or the value in pixels?

I think the most intuitive for the user will be in pixels (closest to the mouse as viewed on the screen)


The module does not work with Combat Carousel activated.

Hi!
I wanted to test your great module, starting to have a few too many non-deactivatable tools, but it turns out that it seems to be incompatible with Combat Carrousel. I used Find the Culprit to find out why I couldn't save changes to the module, and it seems that with Combat Carousel enabled, your module just doesn't work anymore.
Edit : All latest version of Foundry, Combat Caroussel, Control Concealer ... And Dnd5e.

Thank you !

I've been hoping this would be fixed for so long now.. Both of these are really great modules...

The fix for this was unbelievably simple. Wish I'd taken a look sooner. You can temporarily install from my repo if you want it sooner. I didn't bump the version number in case @KayelGee's system does that automatically when generating a release.

appreciate the PR @dhorkin I'll check it on monday

waiting the revision about this. I found your module today and is a feature that I didn't know that I need when I dm using notebook (hiding ui for local gaming session). But I use Combat Carousel too.

Sorry for taking so long, covid actually knocked me out the week I wanted to look at @dhorkin PR.
I'll push out the new version today with the fix.


Can't load StarCoder2-3B

Hi,
I am using Python 3.10.8 and I've updated all packages, but I still get this error message, when try to use the model:
ImportError: Using `bitsandbytes` 8-bit quantization requires Accelerate: `pip install accelerate` and the latest version of bitsandbytes: `pip install -i https://pypi.org/simple/ bitsandbytes`

Any ideas what the problem might be?

Can you share screenshot of Error?

#6
ImportError with bitsandbytes
This error indicates that your environment lacks the necessary accelerate and updated bitsandbytes packages required for 8-bit quantization in the Transformers library.
To fix this, you need to install or update these packages. Run the following commands in your terminal.
pip install -U accelerate
pip install -U -i https://pypi.org/simple/ bitsandbytes
This will install the latest versions of accelerate and bitsandbytes, ensuring compatibility with the 8-bit quantization feature used in your script.
This may solve problems.

Thank you! I have them installed globally but still get the same error. It works when I made new .venv and installed all requirements again.


[WIP] Emit metric to track null build latency

Proposed Changes

Optionally emit a metric that tracks how long a simple no-op build takes to schedule, execute and finish watching. This should help us identify serious latency regressions that might affect all builds.

TODO
I'm pretty sure there's more I need to do here, to get these metrics displayed at http://testgrid-dot-knative-tests.appspot.com/knative-build -- like knative/serving has. I'm not sure if that change happens in this repo somehow/somewhere, or in whatever config powers testgrid. /cc @jessiezcc
Release Note
NONE

/hold

Once this is in it's just a matter of creating an aggregation job and a testgrid config. ;)

Once this is in it's just a matter of creating an aggregation job and a testgrid config. ;)

@adrcunha does this mean this PR can be submitted as-is? Is this really all that's necessary to start emitting metrics? 🤞

Yes, this PR is mostly done. But I would run e2e-tests.sh --emit-metrics locally to make sure it's logging the metric you want. Then, like I said, it's just a matter of adding a job to Prow and a display config to testgrid (file an issue and assign it to me).

Yes. But don't set the environment variable, use the --emit-metrics flag I mentioned.

@adrcunha  I'm apparently unable to run e2e tests locally now, with or without the flag. Getting:
Error from server (Forbidden): clusterrolebindings.rbac.authorization.k8s.io is forbidden: User "system:anonymous" cannot create clusterrolebindings.rbac.authorization.k8s.io at the cluster scope: Unknown user "system:anonymous"

Any idea what I may have done to get into this state? I thought the script started from scratch each time, is it possible some of my local config has crept in somehow? Prow seems to be able to run the tests just fine.

I thought https://github.com/knative/build/issues/286 was closed, let me take a look.

After rebasing to pick up the fix for #286 I ran ./test/e2e-tests.sh --emit-metrics and saw:
...
==============================
==== RUNNING GO E2E TESTS ====
==============================
ok          github.com/knative/build/test/e2e       303.314s
================================
==== RUNNING YAML E2E TESTS ====
================================
>> Starting tests
...

Am I supposed to see metrics in the logs? Or do metrics get sent somewhere during the test that I don't see?
(Also, wow, the tests take 5 minutes now, that's kinda annoying)

The ugly hack above will be gone once https://github.com/knative/test-infra/pull/120 is merged (and the vendored test-infra bumped again, of course).

$ PROW_JOB_ID=foo ./test/e2e-tests.sh --emit-metrics
...
2018/09/16 17:39:41 main.go:759: --gcp-project is missing, trying to fetch a project from boskos.
(for local runs please set --gcp-project to your dev project)
2018/09/16 17:39:41 main.go:771: provider gke, will acquire project type gke-project from boskos
2018/09/16 17:39:41 main.go:307: Something went wrong: failed to prepare test environment: --provider=gke boskos failed to acquire project: Post http://boskos/acquire?type=gke-project&state=free&dest=busy&owner=: dial tcp: lookup boskos: no such host
Test subprocess exited with code 1
Test result code is 1

Passing --gcp-project=bar to the script fails with an unrecognized flag.

I messed up my reply because I edited it, and now I can't even find your
message... Ugh.
Setting PROW_JOB_ID won't work because then kubetest will try to fetch
a project fro boskos. That's why I updated the comment mentioning that you
have to comment lines 196-199 in vendor/ github.com/knative/test-infra/scripts/library.sh.
Adriano Cunha | Serverless EngProd Team |<EMAIL_ADDRESS>| (650)
810-6491
On Sun, Sep 16, 2018 at 2:40 PM, Jason Hall<EMAIL_ADDRESS>wrote:

$ PROW_JOB_ID=foo ./test/e2e-tests.sh --emit-metrics
...
2018/09/16 17:39:41 main.go:759: --gcp-project is missing, trying to fetch a project from boskos.
(for local runs please set --gcp-project to your dev project)
2018/09/16 17:39:41 main.go:771: provider gke, will acquire project type gke-project from boskos
2018/09/16 17:39:41 main.go:307: Something went wrong: failed to prepare test environment: --provider=gke boskos failed to acquire project: Post http://boskos/acquire?type=gke-project&state=free&dest=busy&owner=: dial tcp: lookup boskos: no such host
Test subprocess exited with code 1
Test result code is 1
Passing --gcp-project=bar to the script fails with an unrecognized flag.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/knative/build/pull/337#issuecomment-421838260, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AiIO-a3b0RQcqTmuL5TT6xvs7SdVBjoPks5ubsVqgaJpZM4Wb2RI
.

I got this to work 🎉
info	TestSimpleBuild	trace/trace.go:261	metric NullBuildLatency<PHONE_NUMBER>387509233<PHONE_NUMBER>954654257 8.567145024s

/hold cancel

/assign adrcunha

@adrcunha Looks like all that's left is testgrid configs, as mentioned in https://github.com/knative/build/pull/337#issuecomment-418913310
Can you let me know when those are in and we'll have pretty graphs to 😍 over?


IP Blocking of mutual customers using Chocolatey via JFrog Artifactory

Checklist

[X] I have verified this is the correct repository for opening this issue.
[X] I have verified no other issues exist related to my problem.
[X] I have verified this is not an issue for a specific package.
[X] I have verified this issue is not security related.
[X] I confirm I am using official, and not unofficial, or modified, Chocolatey products.

What You Are Seeing?
Hello
My name is Adam and I'm a Product Manager JFrog
I am reaching out via this issue since we have been waiting for more the 3 days for a response from one of your representatives https://chocolatey.zendesk.com/hc/en-us/requests/21012
We recently discovered that our mutual customers are being blocked from accessing  when requesting from several of our SaaS IPs.
We understand that measures of this type usually occur due to some sort of abusive behavior originating from customers on our end. We are actively working to mitigate the issue and we would like to collaborate together to re-enabled and remove the IP block currently in place.
We are looking forward to working together and I apologize for contacting you via this method.
Thanks in advance,
Adam
What is Expected?
Please respond to our request
How Did You Get This To Happen?
NA
System Details
NA
Installed Packages
NA

Output Log
NA

Additional Context
NA

Hi @adam-browning, apologies for the delay responding to your ticket. You should have received an update to it ~16 minutes ago.

Thank you @Windos
Much appreciated!


Error 28000(9002): SSL Connection is required even when database does not require

Bug description
When a try to introspect a mysql database at azure i receive an error:
Error: Error in connector: Error querying the database: Error querying the database: Error querying the database: Server error: `ERROR 28000 (9002): SSL connection is required. Please specify SSL options and retry. '
Even when my database has no SSL required.
I dont know if it's because my database is at Azure or my username is something like '134@server-221'
How to reproduce

With DATABASE_URL: "mysql://username@username:password@server.mysql.database.azure.com:3306/database"

Run 'npx prisma introspect'

See error below:
Error: Error in connector: Error querying the database: Error querying the database: Error querying the database: Server error: `ERROR 28000 (9002): SSL connection is required. Please specify SSL options and retry. '

Expected behavior
Generate Entities from the database.
Prisma information
"mysql://username@username:password@server.mysql.database.azure.com:3306/database"
Environment & setup

OS: [Mac OS, Windows]
Database: [MySQL]
Prisma version: 2.0.0-beta.6
Node.js version: v13.13.0

@handelcamilo The error is coming the database driver. Can you please make sure that you can connect to your database without ssl from a database GUI or from another driver.

Hi @pantharshit00 ! In fact I can connect with no problem to de database from a database GUI(MysQL Workbench) and from my application .net core. That is a database of a project I already finish and is in production already. I though to use this database to test Prisma because it is a quite complex.
Any suggestion for this problem? Thank you!

Can you please double check that the tools or application that you are using doesn't use a private key to authenticate a SSL connection?

That connection is actually using SSL as you can see in the last message.
Try adding ?sslmode=prefer in your connection string and see if it works.

Hi @pantharshit00 , thanks for helping.
I already tried that, no success. From the docs the sslmode is "preferer" by default.

I am experiencing the same issue.
Database is available from CLI, and database server is being used by other services like FusionAuth.
On connect
Error: undefined: Error querying the database: Error querying the database: Error querying the database: Server error: `ERROR 28000 (9002): SSL connection is required. Please specify SSL options and retry.'
schema.prisma
datasource mysql {
  provider = "mysql"
  url      = "mysql://txxnt@thisisfashion-mysql-db:xxxxxxxxxxxxxxxxxxxxxxxxx7@txxxxxxxxxx-mysql-db.mysql.database.azure.com:3306/xxxcxxxnt?sslmode=require&sslaccept=accept_invalid_certs"
}

I tested with multiple SSL modes
@handelcamilo did you find a resolution?
@ikzelf you might want to monitor this one.

I am still having this issue @sanderkooger .
I can connect to my Azure  database even from TypeORM, but from Prisma.

I am still having this issue @sanderkooger .
I can connect to my Azure  database even from TypeORM, but from Prisma.

I mitigated by disabling ssl for the database.

Unfortunately that is not an option for me :(.

What's status of this? Any ideas how to use prisma with Azure MySQL? The SSL should be always enable and disabling SSL is not option even in development.

The issue label indicated we do not have a reliable, working reproduction for the problem. If you do, or thing one of the earlier comments is one, please post that here so we can try again. Until then, we can not do anything as we can not reproduce and understand the problem unfortunately.

The error what is get is MySQL "9002 SSL Connection is required. Please specify SSL options and retry". This only happens when "Enforce SSL Connection" is enabled.  Used connection string is: "mysql://xxxx<EMAIL_ADDRESS>https://docs.microsoft.com/en-us/azure/mysql/howto-configure-ssl#step-3--enforcing-ssl-connections-in-azure
https://techcommunity.microsoft.com/t5/azure-database-for-mysql/why-is-username-servername-required-to-connect-to-azure-database/ba-p/1204525

I will try it on azure. I need to setup an account. Please be patient.

Do we have any ideas what is the core issue?

ref)https://docs.microsoft.com/azure/mysql/concepts-ssl-connection-security

In some cases, applications require a local certificate file generated from a trusted Certificate Authority (CA) certificate file to connect securely. Currently customers can only use the predefined certificate to connect to an Azure Database for MySQL server which is located at https://www.digicert.com/CACerts/BaltimoreCyberTrustRoot.crt.pem.

download https://www.digicert.com/CACerts/BaltimoreCyberTrustRoot.crt.pem🔐 and save at /prisma
/prisma/prisma.schema

generator client {
  provider = "prisma-client-js"
}

datasource db {
  provider = "mysql"
  url      = env("DATABASE_URL")
}

update /prisma/.env

DATABASE_URL="mysql://test@test-mysql:mypassword@test.mysql.database.azure.com:3306/testdb?sslmode=require&sslcert=BaltimoreCyberTrustRoot.crt.pem"

npx prisma introspect

Prisma schema loaded from prisma\schema.prisma

Introspecting based on datasource defined in prisma\schema.prisma …

✔ Introspected 1 model and wrote it into prisma\schema.prisma in 638ms

Run prisma generate to generate Prisma Client.

npx prisma generate

🙆♀🙆♂🙆♀🙆♂🙆♀🙆♂

This will fix the issue.
Good point that certicate should be located in prisma folder so then connectionstring does not need to have full certificate path.

Awesome! Let me know if adding the certificate fixes the issue for you all. Additional ssl docs can be found here: https://www.prisma.io/docs/reference/database-connectors/mysql/#configuring-an-ssl-connection

Closing due to inactivity. Comment here if someone still hitting this.

I faced the same issue and the cert unfortunately didn't work for me 🤷
Instead I used ?sslaccept=accept_invalid_certs and worked without the cert


1 of 1 React Suspense Boundary — Error 3 of 3 errors in Admin view: Unhandled Runtime Error: Error: There was an error while hydrating. Because the error happened outside of a Suspense boundary, the entire root will switch to client rendering.

Describe the bug
1 of 1 React Suspense Boundary — Error 3 of 3 errors in Admin view: Unhandled Runtime Error: Error: There was an error while hydrating. Because the error happened outside of a Suspense boundary, the entire root will switch to client rendering.
To Reproduce
Steps to reproduce the behavior:

Go to Admin view

Expected behavior
Error message without the stack trace.
Screenshots
1 of 1 React Suspense Boundary — Error 3 of 3 errors in Admin view: Unhandled Runtime Error: Error: There was an error while hydrating. Because the error happened outside of a Suspense boundary, the entire root will switch to client rendering.

3 of 3 unhandled errors

Unhandled Runtime Error
Error: There was an error while hydrating. Because the error happened outside of a Suspense boundary, the entire root will switch to client rendering.

Call Stack
updateHostRoot
node_modules/react-dom/cjs/react-dom.development.js (19849:0)
beginWork
node_modules/react-dom/cjs/react-dom.development.js (21615:0)
beginWork$1
node_modules/react-dom/cjs/react-dom.development.js (27426:0)
performUnitOfWork
node_modules/react-dom/cjs/react-dom.development.js (26557:0)
workLoopSync
node_modules/react-dom/cjs/react-dom.development.js (26466:0)
renderRootSync
node_modules/react-dom/cjs/react-dom.development.js (26434:0)
recoverFromConcurrentError
node_modules/react-dom/cjs/react-dom.development.js (25850:0)
performConcurrentWorkOnRoot
node_modules/react-dom/cjs/react-dom.development.js (25750:0)
workLoop
node_modules/scheduler/cjs/scheduler.development.js (266:0)
flushWork
node_modules/scheduler/cjs/scheduler.development.js (239:0)
MessagePort.performWorkUntilDeadline
node_modules/scheduler/cjs/scheduler.development.js (533:0)

Desktop (please complete the following information):

OS: Mac
Browser: Chrome
Version: Version 114.0.5735.198 (Official Build) (x86_64)

Additional context
Relates to
https://github.com/freeCodeCamp/classroom/issues/134
https://github.com/freeCodeCamp/classroom/issues/359
https://github.com/freeCodeCamp/classroom/issues/360

Hi @theGaryLarson @Komal914 @sijin-raj @GuillermoFloresV
If @theGaryLarson and/or @Komal914 are looking for additional issues to solve, I reported:
• https://github.com/freeCodeCamp/classroom/issues/359
• https://github.com/freeCodeCamp/classroom/issues/360
• https://github.com/freeCodeCamp/classroom/issues/361
Thank you!

Related information from
https://codedayorg.slack.com/archives/C05E350DQH4/p1688894693666219?thread_ts=1688836862.909659
@Komal Kaur @sijin @Gary Larson
If I were in your shoes, below is how I would go about it:

Before considering a solution, I would seek to understand the problem clearly first:

Before skipping ahead to the solution phase and diving into the codebase such as error.js, which is probably at shallower abstraction layers closer to the surface and the user interface…

First, I would want clarity about the error messages and their contexts, which are probably at deeper abstraction layers below the surface and user interface.

For example:
Error messages 1 and 2:
The hints from the messages may help, specifically the keyword Hydration
Error message 3:
The hints from the error message may help, specifically the keyword Boundary
Error messages 1 and 2:

Unhandled Runtime Error
Error: Hydration failed because the initial UI does not match what was rendered on the server.

See more info here: https://nextjs.org/docs/messages/react-hydration-error

Google search of:

Error: Hydration failed because the initial UI does not match what was rendered on the server.

Points to
https://stackoverflow.com/questions/71706064/react-18-hydration-failed-because-the-initial-ui-does-not-match-what-was-render

I have been experiencing the same problem lately with NextJS and i am not sure if my observations are applicable to other libraries. I had been wrapping my components with an improper tag that is, NextJS is not comfortable having a p tag wrapping your divs, sections etc so it will yell "Hydration failed because the initial UI does not match what was rendered on the server". So I solved this problem by examining how my elements were wrapping each other.

Which points to
https://github.com/facebook/react/issues/24519#issuecomment-1122780621

This seems to be expected behavior? SSR cannot work with improper tag nesting as per the HTML spec, the browser's parser won't accept it, and the whole point of SSR is to have the browser parse the initial document structure for you without using any JS. Client side rendering can work with improper tag nesting because the DOM apis do allow creating these invalid nestings "by hand" (with document.createElement, appendChild, etc.).
There is no way to create a raw HTML document that nests a  directly inside a  using static markup, so there's no way to do it with SSR.
So this situation is a warning for client side rendering, an error for SSR, and a warning for hydration; but the only way to continue the "hydration" is to blast away all of the DOM so far because it will be wrong due to invalid nesting.

In error messages 1 and 2, a keyword is Hyrdation.
The referenced web link in error messages 1 and 2 is:
https://nextjs.org/docs/messages/react-hydration-error

Text content does not match server-rendered HTML
Why This Error Occurred
While rendering your application, there was a difference between the React tree that was pre-rendered (SSR/SSG) and the React tree that rendered during the first render in the Browser. The first render is called Hydration which is a feature of React.
This can cause the React tree to be out of sync with the DOM and result in unexpected content/attributes being present.
Possible Ways to Fix It
In general, this issue is caused by using a specific library or application code that is relying on something that could differ between pre-rendering and the browser.
An example of this is using window in a component's rendering.
Another example:
Invalid HTML may cause hydration mismatch such as div inside p.

Error message 3 of 3:

Unhandled Runtime Error
Error: There was an error while hydrating. Because the error happened outside of a Suspense Boundary, the entire root will switch to client rendering.

In error message 3, a keyword is Boundary.
Hence a Google Search for boundary in React leads to:
https://react.dev/reference/react/Component#catching-rendering-errors-with-an-error-boundary

Catching rendering errors with an error boundary
By default, if your application throws an error during rendering, React will remove its UI from the screen. To prevent this, you can wrap a part of your UI into an error boundary. An error boundary is a special component that lets you display some fallback UI instead of the part that crashed—for example, an error message.

https://nextjs.org/docs/pages/building-your-application/configuring/error-handling

Handling Client Errors
React Error Boundaries is a graceful way to handle a JavaScript error on the client so that the other parts of the application continue working. In addition to preventing the page from crashing, it allows you to provide a custom fallback component and even log error information.
To use Error Boundaries for your Next.js application, you must create a class component ErrorBoundary and wrap the Component prop in the pages/_app.js file. This component will be responsible to:

Render a fallback UI after an error is thrown
Provide a way to reset the Application's stat
Log error information

Hi, I can take over this issue. Please assign me.

https://github.com/freeCodeCamp/classroom/pull/398
lgtm as a good enough solution because Admin view isn't intended for Search Engine Optimization (SEO).
I don't know why the errors was happening in the first place, but it may not matter if Server Side Rendering can be disabled for the Admin view.

This error no longer happens after #401

Please contact @GuillermoFloresV if you have further questions about this. Thanks!


The SDK should set the Language property appropriately

Need to figure out what Visual C++ sets this to so we can try to be consistent with that, at least for C++.

Need to figure out what Visual C++ sets this to

C++ always, apparently. We'll set it to Zig, C, or C++.

Need to figure out what Visual C++ sets this to

C++ always, apparently. We'll set it to Zig, C, or C++.

Or not. The .NET SDK has some undesirable logic for C++. Cxx it is.


Reqeust to add a licence.

I'm interested in this project.  Would you consider adding a licence or some description of the terms of use?

Yes, I add MIT licence.

Thank you.


String of custom admin path causes conflict with datasource / events names

Hi,
I used 'back' as custom admin path to a new project.
When I was trying create a datasource with name "feedback" an error was returned.
The lastest stable version: 2.5.2
https://gist.github.com/anonymous/12ddd1f8dc4f4a39555e
On this parte of error:
"Symphony Fatal Error: Could not find Data Source feedcreated. If it was provided by an Extension"
The string was broken 'feedcreated'.
If I change de name to 'fedback', the error return 'fedcreated', so maybe the problem is about 'back' as I used on admin path.
Another information, the datasource / event with name 'feedback' was created but when try edit, same error again.
If need more information, let me know.

I think I found it.
What do you get if you replace this line with this one.
if (isset($_GET['symphony-page']) && strpos($_GET['symphony-page'], $adminPath, 0, 1) === 0) {

Notice the extra 1 parameter in the strpos call ?? This will limit the replacement to only one (your's get two replacement!!)
Does it fix the problem ?
@jensscherbl This kind of fix would get release as 2.5.3 with the new branching model ? I am willing to fix both integration a the 2.5.x branch.... How should I do it ?

Sorry, just tested my fix and it obviously does not work.
Been looking around and it seems like we have to choice.

Use preg_replace
Use this, which looks less nice, but is faster

$pos = strpos($haystack,$needle);
if ($pos !== false) {
    $newstring = substr_replace($haystack,$replace,$pos,strlen($needle));
}

From: http://stackoverflow.com/questions/1252693/using-str-replace-so-that-it-only-acts-on-the-first-match
And I think that this should go in General as str_replace_first

Use preg_replace. I favour readability of code than milliseconds.

Thanks Brendan.


Confusing comments in the first paragraph

The first paragraph in the article is little confusing (copied below). Is PoA required for non-Azure hosted clusters, or not?
"the Patch Orchestration Application (POA) is a wrapper around Service Fabrics RepairManager Systems service that enables configuration based OS patch scheduling for non-Azure hosted clusters. POA is not required for non-Azure hosted clusters, but scheduling patch installation by Upgrade Domains, is required to patch Service Fabric clusters hosts without downtime."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a3a16900-c967-ccf9-2d87-1c994013bf0e
Version Independent ID: 474287be-47ca-50b3-1240-8cca745eca9e
Content: Azure Service Fabric patch orchestration application
Content Source: articles/service-fabric/service-fabric-patch-orchestration-application.md
Service: service-fabric
GitHub Login: @khandelwalbrijeshiitr
Microsoft Alias: brkhande

@radheyshah no POA is not a requirement when using non-Azure hosted clusters as the comment mentions. However, if you want to ensure you are able to patch your cluster without downtime you would need to make sure to update the nodes one upgrade domain at a time so at least a single cluster remains active while the others are updating.
Personally, I find using POA makes patching simpler and ensure your services remain up. But it is not a requirement.

Thank you @MicahMcKittrick-MSFT for the clarification. The wording and punctuation in that paragraph is confusing - so it would be good to update the documentation to provide the clarity you just provided.


Flip function

Update flip function, flip test and images of flip.

you have quite thorough test cases!
some foundings:
(1) line 61: "img = Image.fromarray(output_img)", did you import "Image" before using it?
(2) you may want to remove line 63:  #mpimg.imsave(output_path, output_img)
(3) test function documentation not quite accurate. For example, line 34-35 say "Function to test that if the input type is correct. If is incorrect, a TypeError is raised". Actually the test function is to test whether flip.py throws a proper error when the input type is incorrect.


PHP SDK for Dialogflow to Support KnowledgeBase

Is your feature request related to a problem? Please describe.
I'm using the PHP SDK for Dialogflow. And I noticed it doesn't seem to support KnowledgeBase... In particular, passing knowledgeBaseName as a part of a detectIntent request. IS this on the roadmap?
e.g.
$query_params->setKnowledgeBaseNames($paramStruct);
$optionals_params = ['queryParams' => $query_params ];
$response = $sessions_client->detectIntent( $session, $query_input, $optionals_params );

Describe the solution you'd like
PHP SDK for Dialogflow to include KnowledgeBase functions and variables
Thank you.

Hi @danielpowney,
This feature is currently only supported in the v2beta1 version. We don't currently have a client for that version of the API. I'll work on getting it added in the next week or two.

Thanks this would be great!

@jdpedrie Is there an estimate for when v2beta1 support will be added for Dialogflow?

@danielpowney @elliotmassen KnowledgeBase (and V2) support were added in #3910
You can see the Knowlege bases client here and the knowledge bases client tests here for an idea of how to get started.


please migrate to use kuchikiki

This project uses kuchiki which is stale. A new project, kuchikiki, has emerged and claims to be backwards compatible.
Please consider migrating from kuchiki to kuchikiki.

Probably a good idea!

Fixed in d54c8196399aa042ea4d1ac6168f97fa87e3f15b


Docs Site

It would be useful to run a documentation site out of the /docs folder. This should be easy to do using GitHub pages. There are a few different tools that would make sense:

Jekyll, using something like the Just the Docs theme: Easy to set up and get running.
Read the Docs: Likely a bit more complicated to get configured, but also more feature-rich.

If this seems like an interesting idea, it would be useful to both pick a tool and also put together a list of content pages that would be needed in the documentation.

Love it - I think I'm in favour of jekyll considering its effort to setup seems small - I can have a look at getting something setup this weekend.

Cool! Yes, Jekyll is very easy to get going. If you'd like, I'm happy to push my test Jekyll setup in the repository in a separate branch/pull request for you to take a look at, but I totally understand if you'd like to handle it on your end. Either way, I do believe you'll need to configure the GitHub pages side of things on your end.

Thanks for all the work @rickwysocki - long overdue fix but I've resolved the gem issue by using a remote_theme isntead;

Sorry for just swinging back to this, but cool! Let me know if there's anything I can be helpful with.


Spelling mistake in Readme

Hi.
really cool library. But there is a small mistake in the example https://github.com/schlosser/pig.js/#options-object
onClickHander should be onClickHandler
Keep up the great work!

Fixed! Thanks for filing!


resolves #181 enable checklists

add ballot box glyphs (0x2610 and 0x2611) to notoserif-regular font
use ballot box glyphs as marker for checklists

Note that we are copying the ballot box glyphs from Font Awesome into NotoSerif. This allows you to still use a custom font that provides it's own ballot box glyphs.
In the future, we might consider using the Font Awesome font regardless of the font being used for text.


fix typo in descriptions 'not_like_escape' and 'not_ilike_escape'

Statements about case (in)sensitivity were reversed.

Thanks!


broker pod  keeps restarting

When creating a kafka cluster, there is always a broker pod that keeps restarting

Hey wongearl, could you provide some more information using the template below? We need more info so we can help 🙂
Describe the bug
A clear and concise description of what the bug is.
Steps to reproduce the issue:
Please describe the steps to reproduce the issue.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem like release numberm version, branch, etc.


Prevent to fuse a single reshape op.

mark related to https://github.com/alibaba/BladeDISC/issues/766


Error while installing python-pptx

I was trying to install python-pptx on my Python 3.4 and I got the following error:
error: Microsoft Visual C++ 10.0 is required (Unable to find vcvarsall.bat).
I used pip to start the install and I am using a Windows 7 x64 machine.  Does anyone know how to resolve this issue?
pip install python-pptx

You need to install the lxml package and perhaps Pillow separately on Windows. The error you're getting is when it's looking for a C compiler. Search for 'lxml binary installer'
http://www.lfd.uci.edu/~gohlke/pythonlibs/

Thank you


App styles not working after updating to version 2.0.4

Hi I have just updated from 0.3.47 to 2.0.4 but the styles within 'styleguide-app.css' are incomplete.
It is causing styleguide elements such as the design tool to have no styles attached. I have tried setting the 'includeDefaultStyles' to both true and false but no luck.

Hi @ChrisCraig68, It seems this is only happening to the clean build. I'll have a look when I get time. Thanks

Thanks @junaidrsd

I had the same issue going from 2.0.1 to 2.0.4. Reverting back to 2.0.1 works for now.

@OliverJEvans Thanks that worked for me.

I see the same thing. Not sure why this issue got closed, the bug still remains. I'd leave this open until this gets fixed by @junaidrsd 's pull request.

@junaidrsd, could you please reopen this issue?
The problem as mentioned in the inital post still persists.
I tested version 2.1.0 (git clone) and 2.0.4 (git clone and npm package) and the styles still do not work.
Thanks!

@mikezks I've tested once again with all possibilities and styles are working for me. Can you check by deleting output folder. It should work

@junaidrsd, thanks for your reply.
It seems to be related to the npm version. In the environment I tried to setup the styleguide today a npm 3.x.x version is allowed only. This seems to be the reason for the wrong styles. I tested it on another PC right now (with npm 5.4.2) and - as you said - everything works fine. Sorry for this confusion, but at least it may be helpful for others as well.
The issue can of course be closed again.

@junaidrsd, in contrast to what I wrote yesterday I do have the styles issue with npm 5.4.2 as well. It seems to be connected to the browser.
This bug does not occur in IE, edge, Firefox, but in Chrome only.
Could you please give me feedback whether you tested successfully with Chrome as well?
I tested with Version 61.0.3163.100 (Official Build) (64-bit) and Version 60.0.3112.90 (Official Build) (64-bit).
Steps to reproduce:
git clone http://github.com/SC5/sc5-styleguide.git
cd sc5-styleguide
npm install
npm run build
npm run demo

I think I found a solution resp. workaround:
Chrome does not like this code block:
<script type="text/ng-template" id="userStyles.html">
  <style>
    @import url('{{{appRoot}}}/styleguide.css');
    @import url('{{{appRoot}}}/styleguide_pseudo_styles.css');
    @import url('{{{appRoot}}}/styleguide_helper_elements.css');
  </style>
</script>

But loading it with your addCssLink() function works.

Thanks @mikezks for reporting problems, unfortunately I'm occupied with other things. If you have found a solution just create a PR I'll merge it.


BLD: Fix uploading wheel when it exists

What do these changes do?

Fix uploading wheel when it exists.
Related issue number

Fixes #xxxx
Check code requirements

[ ] tests added / passed (if needed)
[ ] Ensure all linting tests pass

https://github.com/aresnow1/xorbits/actions/runs/5856579155/job/15876714529 skip existing works.


Frontend unit test improvements

Hi @sjimenez77,
I have improved the test cases. Now total test cases are 140. Still, two components are pending due to not able to understand the functionality. I will check it and update it accordingly.
I have changed two files - HTML, SPEC.TS.
HTML - I have added just class names, other than I have not touched other code
Please review it and let me know in case any issue

These tests are definitely a big improvement for My Thai Star.
Thanks @chdattat for the effort.
Merging now.

Thanks @sjimenez77


make DMA unmap device callback optionally asynchronous

Signed-off-by: Thanos Makatos<EMAIL_ADDRESS>

Converted to draft as we're reworking dependee #608.


match-annotation parameter for modify-security-groups action

Specific use case this could be used for is trying to match tags on security group to tags on a subnet for automatic enforcement.
At the moment, we can do a match-resource for a subnet or security group type filter on an arbitrary tag, but when run against an ec2 resource, the match-resource compares tags on the ec2 with tags on the subnet or security group.
Ideal syntax would be something more akin to:
- type: security-group
   key: tag:SubnetType
   value: not-null
   match-annotation: subnet

This would (in theory) take the extant subnet type filter and allow it to be referenced under the match-annotation, allowing us to match the tag:SubnetType on both the SG and the subnet associated with the resource in question.

i think we probably can do this as a more generic match-attribute syntax with some value interpolation (prefix match) for annotations like we do for resource tags.

I think we can simplify this by swapping the match-resource from a boolean into a selector of resource type. I think it should inherit from all related resources. So since ec2 has security-group, subnet, and other related resources that are exposed in the filters, it should be more or less internal references.
Sample syntax
policies:
  - name: test-ec2-sg-subnet-matching
    resource: ec2
    filters:
      - type: security-group
        key: tag:SubnetType
        value: not-null
        match-resource: self | subnet | security-group | etc

How about this for usage/policy syntax instead? More of your match-attributes. Unsure of whether we need a new value_type type for simplicity on the checking of the contents of value but that sounds like a code review kind of decision.
Target state would be to have a few more keywords like tag: in the value field that can be matched across resources. Use case/example below should take the SubnetId that the ec2 is residing in and then compare its SubnetType tag to EC2's attached security groups' SubnetType tags.
policies:
  - name: test-ec2-sg-subnet-matching
    resource: ec2
    filters:
      - type: security-group
        key: tag:SubnetType     # attribute to match
        resource: SubnetId      # Resource ID or JMESPath expression from ec2 resource
        op: ne                  # match if the tags aren't equal, i.e. the security group doesn't belong in this subnet
        value-type: match-resource-attribute

this was implemented via the match-resource on the security-group filter.


I can't finish section 3 of part 5! My device's screen is black!

After I finished section 2, I tried to turn it on. But it's screen was black. So I read the Troubleshooting page, found that I don't have /luma/firmware.bin in my SD card. Then I tried the fourth one in it:

Try this test payload (mirror).
Rename /arm9loaderhax.bin, if it exists, to something else.
Place the arm9loaderhax.bin from the archive linked above in your SD root.
Insert your SD card into your 3DS and power on.
Press A. Your 3DS should power off; this means arm9loaderhax is working and something else is broken; your device is not bricked.

I just placed this file in the SD card, replace the one before. And the problem came, when I try to turn 3ds on with SD card in it, the LED is on. And if I press any buttons, it shut down! When I try to turn it on without SD card, the LED is lighted at first, then it shut down.
I need someone's help.

your device isn't bricked (arm9loaderhax is working) so you can continue with the guide as normal.

@ihaveamac
Thank you for answering. As I am a Chinese students, I followed a Chinese guide translated by an enthusiastic person. However, that guide is a bit of out of date. So now I have solved this problem.
XD

I have the same issue, could you tell me how you solved it?

Can you open up a menu when you press SELECT while booting?
Because no CFW can boot a 2.1 NAND. That's why it's not booting. Just continue following the guide, you will restore your original NAND backup with all your games and saves.

I already used the guide, imported my old nand backup and A9LH is working
fine, I can open hourglass9 with start, luma settings with select, decrypt9
with x etc.
This is the 5th 3DS I've installed A9LH on. I think I'm just going to try
restoring my old nand with decrypt 9 (deleting A9LH) and then re-install.
On Fri, Jul 29, 2016 at 6:49 PM, Ev1lbl0w<EMAIL_ADDRESS>wrote:

Can you open up a menu when you press SELECT while booting?
Because no CFW can boot a 2.1 NAND. That's why it's not booting. Just
continue following the guide, you will restore your original NAND backup
with all your games and saves.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Plailect/Guide/issues/275#issuecomment-236247409, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ATwfMictkNKOKLDor8pzSDGyWRXj5vC7ks5qaj0qgaJpZM4JX7xX
.

I just followed the guide in English...